DS18B20 Library Using an ATTiny1604

Hello Mr. Tillaart.
I remembered your good advice in august last year on how to distinguish between a MAX6675 and a MAX31855 mounted in a same circuit. Thank you again.
This time I come to you with an awkward problem. I try to use your library on an ATTiny1604 without success. I have no problem running the library on an ATTiny85, but with the ATTiny1604 , I cannot even see any activity on the pin PIN_PB0 (...I tried all the other pins as well). The circuit is the usual one with an active external 4k7 pullup to +5V. HardwareSerial connected (on pin PIM_PB2/PIN_PB3) works fine. I can use digitalWrite and digitalRead without any problems (the pin toggles fine, and reports the right values). I tried the library of Mr. Burton and the one of Mr. Stoffregen without success and with the same symptom (i.e. the pin stays high and does not show any activity on the oscilloscope).
I use the jtag2UPDI device built with and Arduino Nano that work flawlessly. I tried using both the Arduino IDE (1.8.19 and 2.3.2) and PlatformIO. The examples you give are loading fine and no load error is reported.
Was the problem reported to you before my present message?
Would you have a suggestion or solution or request for troubleshooting for me?
Thank you very much for your help.
Regards,
Rene-Jean Mercier

Welcome back,
Never used the specific device so I need to do some reading tomorrow.
Which onewire lib do you use?
Have you tried onewire-ng as replacement?
To be continued

You could try the onewirescanner.ino example sketch.
Also try ds18b20_int library, this uses no floating point math so preserves memory. In case it is a runtime memory problem.

Thank you for your quick reply.
I use this one lib_deps =<EMAIL_ADDRESS>But I will try the one you suggest tomorrow.
Regards,
RJMercier
Le jeu. 25 avr. 2024, à 21 h 47, Rob Tillaart @.***> a
écrit :

Welcome back,
Never used the specific device so I need to do some reading tomorrow.
Which onewire lib do you use?
Have you tried onewire-ng as replacement?
To be continued
—
Reply to this email directly, view it on GitHub
https://github.com/RobTillaart/DS18B20_RT/issues/31#issuecomment-2078484963,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGFVP36RFQ4YBPBG4GGJ6GLY7GW3VAVCNFSM6AAAAABGZ3ML26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYGQ4DIOJWGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

In fact I tried both. _INT and _RT. Same result. No activity on the pin.
I also tried the scanner. Same result. No activity on the pin.
Le jeu. 25 avr. 2024, à 22 h 02, Rob Tillaart @.***> a
écrit :

You could try the onewirescanner.ino example sketch.
Also try ds18b20_int library, this uses no floating point math so
preserves memory. In case it is a runtime memory problem.
—
Reply to this email directly, view it on GitHub
https://github.com/RobTillaart/DS18B20_RT/issues/31#issuecomment-2078495831,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGFVP3YFQ2MPMDQT2K3T7F3Y7GYSPAVCNFSM6AAAAABGZ3ML26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYGQ4TKOBTGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello Mr. Tillaart.
I could not go to bed before having tested your recommendation (i.e. the OneWire-Ng). I have been working on this for four days without success. :-(.
And your suggestion was GOOD ! It works !!!!!
I used the example in the library of Mr. PStolarz called Dallas Temperature.ino (compiled and loaded by PlatformIO).
It is "heavy" on flash memory though. Here is what PlatformIO reports;
Checking size .pio/build/ATtiny1604/firmware.elf
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [==        ]  19.2% (used 197 bytes from 1024 bytes)
Flash: [===       ]  34.3% (used 5617 bytes from 16384 bytes)
Building .pio/build/ATtiny1604/firmware.hex
You might want to adapt it to your _INT version --that I used on another project-- using the ATTiny85. It has a little footprint and  it is very well adapted for ATTiny application.
If you do something in that route, You can count on me for testing it on the ATTiny1604.
Best regards,
René-Jean Mercier

Mr. Tillaart,
I also found that the one from SpencerKone (https://github.com/SpenceKonde/OneWire/tree/master) also works !!!! The person who wrote jtag2UPDI.
Using the example of his library : DS18x20_Temperature.pde, PlatformIO reports :
Checking size .pio/build/ATtiny1604/firmware.elf
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [==        ]  20.4% (used 209 bytes from 1024 bytes)
Flash: [====      ]  38.7% (used 6333 bytes from 16384 bytes)
Building .pio/build/ATtiny1604/firmware.hex
Thank you so much. And as mentioned before, if you do any adaptation to reduce the footprint, I will test for you.
Regards,
René-Jean Mercier

Goodmorning,
Thanks for testing in the middle of the night.
At least I should make a section about these findings in the readme.md file of the DS18B20_INT library which was written with small footprint in mind.
Possibly in all onewire related libs, sort of general statement on memory usage, including the links.
It might also mean that the dependency mentioned in the library.json file could change.

I also found that the one from SpencerKone (https://github.com/SpenceKonde/OneWire/tree/master) also works !!!! The person who wrote jtag2UPDI.

This is a fork of the onewire library from Paul Stoffregen, several commits behind which might explain the smaller footprint.
A quick check shows that there are about 380 forks of Paul's work so probably there are a few dozen more that might work.
My libraries that refer to oneWire: DS1821, DS18B20_INT, DS18B20, DS2401, DS2438, MAX31850
(some updating todo)

Did a test run for Arduino UNO and OneWireNg resulted in a larger footprint for DS18B20_INT.
So depending on the platform footprint "winner" differs.
OK, that said I think this issue is solved for now and can be closed.

Hello Mr. Tillaart,
In trying to reply to your last question, here are the results that I got on PlatformIO UNO (an original and a clone).
I believe that if you decide to optimize and integrate the Mr. Konde and/or Mr. Stolarz OnWire library by taking the best of both and making it in the style of your functions (like  requestTemperatures(void); getTempC(void); ...easier to visualize), working on both 328 and the recent ATTiny series-0/1/2 and a smaller footprint, that would be winner. My offer to test still stands.
Uno 328P (original Arduino and a Clone)_With Piotr Stolarz  OneWire :
Dependency Graph
|-- OneWireNg @ 0.13.3
Building in release mode
Checking size .pio/build/uno_mini/firmware.elf
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [==        ]  22.8% (used 466 bytes from 2048 bytes)
Flash: [==        ]  21.4% (used 6892 bytes from 32256 bytes)
=========
Uno 328P (original Arduino and a Clone)_With Piotr Stolarz  OneWire (one sensor option):
/*

If defined: only one sensor device is allowed to be connected to the bus.
The library may be configured with 1-wire search activity disabled to
reduce its footprint.
*/
#define SINGLE_SENSOR
Dependency Graph
|-- OneWireNg @ 0.13.3
Building in release mode
Checking size .pio/build/uno_mini/firmware.elf
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [==        ]  23.1% (used 473 bytes from 2048 bytes)
Flash: [==        ]  19.4% (used 6256 bytes from 32256 bytes)

=========
Uno 328P (original Arduino and a Clone)_With Spence Konde
OneWire
Dependency Graph
|-- OneWire @ 2.3.5
Building in release mode
Checking size .pio/build/uno/firmware.elf
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [==        ]  19.6% (used 402 bytes from 2048 bytes)
Flash: [==        ]  16.3% (used 5266 bytes from 32256 bytes)

Thanks for the measurements. It gives extra context and food for thoughts.

Had a look at the oneWire code, about 1300 lines, written over last 17 years. Quite optimized per processor already, it will be hard and time consuming to even match this level. So not my challenge.

The library may be configured with 1-wire search activity disabled to reduce its footprint.

You can do that with the (Paul Stoffregen) onewire library too
// you can exclude onewire_search by defining that to 0
#ifndef ONEWIRE_SEARCH
#define ONEWIRE_SEARCH 1
#endif

Might be worth a try to reduce footprint.

As the original problem is solved I close the issue.

Hello Mr. Tillaart,
Thank you so much.
I will try and let you know.
Regards,
René-Jean Mercier
Le ven. 10 mai 2024, à 10 h 26, Rob Tillaart @.***> a
écrit :

Closed #31 https://github.com/RobTillaart/DS18B20_RT/issues/31 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/RobTillaart/DS18B20_RT/issues/31#event-12770488230,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGFVP3ZEFDI7MKCVCFFPW5TZBTKKVAVCNFSM6AAAAABGZ3ML26VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG43TANBYHAZDGMA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[MM-15270] Request team from API if invite_id is empty

Summary
PR adds a getTeam request in team settings/invitation modal if team.invite_id is empty since we'll soon be removing invite_id from the related websocket broadcasted event for security reasons.
This PR is backward compatible and can be merged.
Ticket
https://mattermost.atlassian.net/browse/MM-15270
Related PRs
https://github.com/mattermost/mattermost-server/pull/12952

/check-cla


ValueError: invalid literal for int() with base 10

Traceback (most recent call last):
  File "F:\MySSDPrograms\cudatext\py\cuda_git_blame\__init__.py", line 52, in do_blame_analyze
    result = parse_blame_analysis(*git_blame(fn))
  File "F:\MySSDPrograms\cudatext\py\cuda_git_blame\parser.py", line 76, in parse_blame_analysis
    committer_time = int(committer_time)
ValueError: invalid literal for int() with base 10<EMAIL_ADDRESS>ERROR: Exception in CudaText for do_blame_analyze: ValueError: invalid literal for int() with base 10<EMAIL_ADDRESS>

command Blame analyze file

Can you help me run  and send me the result. It seems I missed some special edge cases
git blame yourfile --line-porcelain

Thanks. I made a patch, tested on ATFlatControls/history.txt, CudaText/formmain.pas.


It should be like this:

Duplicate of https://github.com/Microsoft/vscode/issues/7062


[Feature Request] Additional menu bar with icons as shortcuts

Hey,
it would be nice if there would be a possibility to define an additional menu bar that can contain (default or custom) icons with shortcuts to commands like save file, save all etc.
Most editors like Notepad++ offer such menubars - for everyone that doesn't like that it is always possible to disable those bars

I don't think that is better feature, when coding you use icon to execute actions or you use shortcut key, i like shorts cut key for every task, example in minimal all eviroment: hide side bar, search file i use short cut key command + shift + p, .... You must use short cut key for better coding. Thanks

True story - and I do use lots of shortcuts which boosts my speed and performance to the moon ;-) - anyhow - to distribute and spread the use of atom editor to make it a widely used one you should also have possibilites for junior dev's, newbies and everyone that is not that familiar (yet) to start using an editor that grows with their abilities to code.
Imagine a young boy or girl, hearing about atom and want to give it a try. While not having much background in programming the young dev relies on lots of visual help - but by getting more and more familiar with developing, shortcuts, editor assistance etc. it customizes atom more and more to it's own needs and becoming a huge fan.
Nobody grows up as a professional dev, when I remember my first years in programming around 16 years ago and compare it to my behaviour today everything has changed.
notepad++ is a widely spread editor with lots of users - because it meets the req's of prof dev and young dev in same way.
Have lot's of assistance or purely shortcut behaviour it's your choice to display or disable a menu bar - but just because there is one has nothing to do with a "bad feature".

Thanks for the suggestion! I don't think this is something that will ever be added to Atom core by design, but something like this would be a great idea for a community package.

You can probably take a look at all these packages: https://atom.io/packages/search?q=toolbar
Many of them are built on top of suda's tool-bar package.
This one in particular looks close to what you're proposing:
https://atom.io/packages/tool-bar-almighty

As I am not searching for such a toolbar but just proposing idea for features I think this can be closed than as you have stated such a feature will not be part of atom. This is not a problem and the discussion should therefore be ended :)


format diagnostics

Codecov Report

Merging #7 into master will decrease coverage by 0.89%.
The diff coverage is 45%.

@@            Coverage Diff            @@
##           master       #7     +/-   ##
=========================================
- Coverage   39.93%   39.04%   -0.9%
=========================================
  Files           8        8
  Lines         293      292      -1
  Branches       36       36
=========================================
- Hits          117      114      -3
- Misses        176      178      +2

Impacted Files
Coverage Δ

src/util/Error.ts
63.63% <ø> (ø)
:arrow_up:

src/TsCheckerService.ts
0% <0%> (ø)
:arrow_up:

src/TsChecker.ts
90.9% <100%> (+0.43%)
:arrow_up:

src/TsCheckerWebpackPlugin.ts
100% <100%> (ø)
:arrow_up:

src/util/resultSerializer.ts
52.94% <36.36%> (-5.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dec01f...fac831b. Read the comment docs.


[Android] Filtered Input.ChoiceSet implementation

Related Issue
Fixes #5984
Description
Implements the Filtered style for Input.ChoiceSet which allows the user to type in to get filtered results inside of a dropdown. This code includes the implementation of the control as well as the inclusion of tests to verify the correct validation of the data in the control.
Sample Card
v1.5\Elements\Input.ChoiceSet.Filtered.json
How Verified
The fix was verified by adding tests to verify:

Serialization and Deserialization of the property
Validation success and failure cases

Microsoft Reviewers: Open in CodeFlow

/azp run AdaptiveCards-.NET-PR

/azp run AdaptiveCards-.NET-PR


Compilation in cygwin unable to find external include path mentioned in cmakelist

Describe the bug
I am adding my own module in px4 firmware folder. The header files for my modules source code are placed in an external folder (outside px4 firmware directory) at D:/Project/PX4/include. I was adding the required paths for my module in the Cmakelist.txt as follows
include_directories( "/mnt/d/Project/PX4/include" )
Till now I was using WSL on windows for compilation and it was working fine. Now I am trying to switch to cygwin for compilation in Windows.
I modified the cmakelist for cygwin as follows:
include_directories( "/cygdrive/d/Project/PX4/include" )
However, the compilation is failing for the Cmakelist.txt complaining that is unable to find any of the external header files.

To Reproduce
On Windows, clone PX4 v1.8.0 firmware.
Move the header files for any module ouside firmware directory.
Modify the cmakelist accodringly.
Try to build in Cygwin.
Full Cmakelist
Below is my full CMakelist.txt
include_directories(
"/cygdrive/d/Project/PX4/include"
)
px4_add_module(
MODULE modules__px4_app
MAIN px4_simulink_app
STACK_MAIN 2000
SRCS
cygwinTest1.cpp
cygwinTest1_data.cpp
nuttxinitialize.cpp
DEPENDS
platforms__common
)
string (REPLACE "-Werror" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
string (REPLACE "-Werror" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fpermissive -Wno-narrowing")
Any help in resolving this issue is much appreciated

@MaEtUgR , can you please help me with this issue?


Add additional instructions to line item creation steps in step-by-step section

While running through the step by step creation of a vanilla Prebid set up, I found a potentially setup-breaking instruction (as it did indeed break my test up).
The instruction states to only change Rotate creatives to Evenly on line items, then the default settings are okay to use.
The default setting in the Adjust delivery for Display creatives is All, which broke my setup; by having 2 creatives attached to the line item with only one ad slot to serve into.  As per the All rule, the line item can only be selected if all creatives have an open ad slot to serve into.
I believe the All setting would break most Prebid set ups, so I am just proposing adding One or more as a default step in these instructions to avoid that mistake.
🏷 Type of documentation

[X ] text edit only (wording, typos)

I checked our line item setup and we do use indeed one or more - all will for sure break everything as this is used for google ad manager's roadblock feature, which is nothing you want in a regular line item setup.


TB-7: as a User, I want to remove group subscription from my subscriptions

As a User, I want to remove group subscription from my subscriptions
Acceptance criteria:

/removeGroupSub added

implemented in pull request #22


[Feature request] toggle language servers

It should be nice to be able to enable/disable specific servers.

Agree, this is a must-have as currently LSP is an always-on setup.
What solutions do you think will work best?

A command that writes a project-specific setting to disable a language server by name?
The ability to configure a language server at the project level instead of at the package level?

I guess there should be an option to disable a server globally via LSP.sublime-settings and also a project specific setting to enable/disable certain servers.

The configuration to support this was merged in #74.
There is some discussion about what the default language server configuration should look like in #76.
It would be nice to say Enable or Disable instead of Toggle, but unsure how specific the name of a command in the quick panel can be? (The "Restart Servers" command should perhaps also say "LSP - Restart pyls" for example)

Enabling ane disabling the servers do make more sense. I also found "Restart Servers" confusing, does it restart all running servers or just restart the server of the current window!?
May be this?

LSP: Enable Server Globally
LSP: Disable Server Globally
LSP: Enable Server for Current Project
LSP: Disable Server for Current Project
LSP: Restart Server of Current Window

I also not that you are loading the project settings from the key LSP of view.settings. I think it should be window.project_data.

Yes, those look like good suggestions, including using window.project_data, thanks!
I've started some work on making these commands part of a first-time setup flow.

#119 added Enable/Disable language server Globally / in Project.
Please let me know if it doesn't work as expected!


Remove jquery from dependencies in AMD

Refering to #127.

This change is

@zackbloom @marcneuwirth @adamschwartz can we please get this in and released. This blocks odometer from being able to be used in more modern tools like webpack, when we aren't using jquery (which is quickly becoming common). I really need this so I can use this in our react app. Thank you very much!

Hello guys!
Any news on this? Can we merge this?
Thanks,
Jérôme

Please release that change ! I'm not using jQuery in my app and that is a blocker... Thanks for this great library !

A temporary workaround for this is doing the same thing you would do for backbone without jQuery.
My webpack 2 config looks something like this:
module: {
    loaders: [
      {
        test: /(backbone|odometer)\.js$/,
        loader: 'imports-loader?define=>false'
      }
    ]
  },
  plugins: [
    new webpack.IgnorePlugin(/^jquery$/)
  ]

Sorry to ask again but, where are we on this? Is there anything holding up?
@zackbloom
Thanks,
Jérôme

Sorry for the delay @jeerbl

Do you need to bump a new version to npm so we can get access to it? I'm having issues getting yarn to see the update.

Published as v0.4.8


feat: Adjust generate-module-index-data.js moduleJsonPath for AVM modules

Description
Adjust generate-module-index-data.js moduleJsonPath for AVM modules to remove double avm/res/avm/res or avm/ptn/avm/ptn paths to main.json
Testing of API manually works as expected: https://api.github.com/repos/Azure/bicep-registry-modules/contents/avm/res/network/private-endpoint/main.json?ref=tags/avm/res/network/private-endpoint/0.1.0
And have tested logic in output

-> Will be followed up by a better fix


ArrayStatistics overloads with length parameter?

I am using ArrayStatistics to calculate the same statistics on many (millions) sets of input data. For efficiency, I would like to be able to re-use the arrays I allocate to store the input data, but the number of values in each input set varies slightly. Is it possible to add overloads to the methods on ArrayStatistics that include a length parameter, so I can pass in an array that is larger than the number of values it contains?

A common pattern would be to allow providing not just a length but both index and count, thus operating on an arbitrary array segment.


Move Mercurial dependency to pip.txt

While replicating #3066 I was getting an error because of mercurial missing, a time ago I do this PR #3358 that add mercurial to the tests dependencies, but it's also required for the main project.

I think @berkerpeksag is right.
Because of the points mentioned, I think it's better to update the install docs to mention that mercurial is needed to have some extra features.
It's not an strict requirement (in case you want to contribute) --but if you want to work on something that depends on mercurial you will need to install it. So, adding this to the docs it's the best from my point of view.

@humitos I thinking on improve the installation docs with this notes https://github.com/rtfd/readthedocs.org/pull/3614#issuecomment-365844940, probably I will include the mercurial dependency there. Closing this for now.


timer_impl: Make time conversions a bit more C++y.

Use std::chrono::duration_cast rather than dividing by numbers with an eyeball glazing number of zeros for better readability.
Risk Level: low, refactoring only
Testing: existing tests pass
Signed-off-by: Dan Noé<EMAIL_ADDRESS>

I will investigate the mac failure.

I'll reopen this when I get some time to investigate the mac os failure.


Give a pragmatic solution to suppressing noisy output

This PR replaces the broken means of suppressing noisy output from #150 with a pragmatic hack. (Note that although @Carreau submitted #150, I was the one who came up with this broken solution, and he was only implementing my idea).
The pragmatic hack I've made is to offer an option jupyterlite_silence in config.py. Setting this to True causes the stderr and stout from the call to jupyterlite build to be directed to dev/null. I've verified that this works for suppressing output, and that the notebooks still work. I have not made jupyterlite_silence=True the default because it's a drastic step which suppresses even warnings and errors.
I think it's reasonable to go with this hack, at least for the time being, until the necessary changes can be made in jupyterlite  removing unguarded print statements and making doit for tasks configurable.
Many apologies for jumping the gun and making a broken release. I will be sure to learn my lesson from this. I will need help revoking the bad release from PyPI.
cc @Carreau, @martinRenou, @jtpio @matthewfeickert

Thanks very much for being so fast and responsive on this @steppi! Very much appreciated. :pray:

Many apologies for jumping the gun and making a broken release. I will be sure to learn my lesson from this.

I think we've all been there before, so no worries. :)

Many apologies for jumping the gun and making a broken release

No worries! I stopped counting the number of broken releases I made 🙈

I've made it so stdout and stderr of jupyterlite build is still printed if the command fails following @Carreau's suggestion. I've also made jupyterlite_silence = True the default, following the suggestion of @rgommers here: https://github.com/scipy/scipy/issues/20277#issuecomment-2009794310.

@Carreau, @martinRenou, @jtpio. Can we merge this and make a release? It would fix a broken build in one of SciPy’s CI jobs.

Ok, let's merge this and try. It's ok to do broken releases, it happens.

Thanks @Carreau!

Yes, thanks all for working on this!


Custom header template

Whats the best way to specify custom header template , with all the features . The Docs does not have any clear exaplanation .

Hello ,
I checked the source code and I got the below template and saved it to header-template.html

          Drag a column header here and drop it to group by that column.

{{col.colDef.name}}

              {{colFilter}}

But for some reason , I dont know why , I m getting this , as shown in the image . The template gets printed once again , below the template that I try to build


Fix Norwegian layout

#34 seems to have missed the µ sign and the fact that someone in the Nordics at some point in the past decided that using comma instead of period as the decimal separator was a great idea.

Erm... Just double checking. The code I changed is not included in any release yet, and it says "Add 102/105-key Norwegian layout" under the "Unreleased" section already.
Do you want me to add another bullet point stating the exact fixes?


Resolved addresses with maxRead/maxWrite distance are not centered around the current address

Current behavior and impact:

When reading or writing from memory outside of the maxRead/maxWrite distance, the address is calculated as currentAddress + (offset % maxDistance). This is not spec-compliant, however.

Steps to reproduce:

Read or write at a greater offset than the respective maxDistance.

Expected behavior:

Read and write operations are "centered" around the current instruction. The range is [sourceAddress - maxDistance; sourceAddress + maxDistance].

Acceptance Criteria:

[ ] The functionality is implemented according to spec

Fixed by #325


Lighthouse error when running a GPSI test with the Plus1 container

When running the following command:
docker run --rm -v "$(pwd):/sitespeed.io" sitespeedio/sitespeed.io:16.10.0-plus1 "https://www.zoopla.co.uk/for-sale/property/london/" --browsertime.iterations 1 --plugins.remove /lighthouse
I get a successful Sitespeed.io report but I get the following error in the console:
ERROR: Error: Lighthouse returned error: Something went wrong.
    at Gaxios.<anonymous> (/gpsi/node_modules/gaxios/build/src/gaxios.js:72:27)
    at Generator.next (<anonymous>)
    at fulfilled (/gpsi/node_modules/gaxios/build/src/gaxios.js:16:58)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

And subsequently I don't get any GPSI data as part of the run (we're looking to collect Lighthouse scores for long term trending)
I thought it might be a connectivity issue, but if I run the following test:
docker run --rm -v "$(pwd):/sitespeed.io" sitespeedio/sitespeed.io:16.10.0-plus1 "https://www.zoopla.co.uk/" --browsertime.iterations 1 --plugins.remove /lighthouse
I get no issues at all. I get the following message:
INFO: Got https://www.zoopla.co.uk/ analysed from Google Page Speed Insights
I have also tried running https://www.zoopla.co.uk/for-sale/property/london/ on GPSI directly and it works fine: (https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fwww.zoopla.co.uk%2Fto-rent%2Fproperty%2Flondon%2F&tab=mobile).

HI @shaqb thanks for creating the issue, let me try and see if I understand what's going on.

Hi @soulgalore - thanks for the reply. That's really interesting as every time I hit GPSI directly it works fine.

I even used the Pagespeed API and that also returned data correctly.

Hi @soulgalore - are you able to still recreate the issue on GPSI directly as I am unable to. If you are are you able to share any more output so I can raise it?

I tried twice just now, first time it didn't work, the next time it did. When It didn't work, the only errors showed was the one in the screenshot.

Thanks @soulgalore - I'll pass that on


fix(mat-datepicker): button ripple radius

Bug:
After switching from Month view to Year view, ripple doesn't take all of the width of the button.
Since year notation contains more characters, a width of the button is larger than the month notation equivalent. Plus seems like since button width is different, velocity of the ripple to fill the whole button is different as well.
Is it something we should address to ripple / button itself?
What is the expected behavior?
Ripple to take fullwidth of the button.
What is the current behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Material: v.6.3.3

Thinking about it in regards to the ripples. I'm not sure if that's something we need to address in the ripple implementation. There would be definitely some way to make the ripples always expand to the current boundaries, but it might turn into a breaking change, performance impacts etc.
Maybe we could instead just have a minimum width for the datepicker button that avoids a change in boundaries.

Closing this one as we cannot fix this. The ripple starts on mousedown, and then mid-animation the button changes its dimensions. We could expand to the full dimensions mid-animation with negative impact in performance, but then there would be the complexity of managing velocity of the ripple when it was already slower before (due to the smaller & old dimensions).


Merge extraAttributes with DatePicker button

Merge extraAttributes with DatePicker button  so you can modify roundness and paddings etc.

I wonder how we can make this consistent across all fields & layout components, because at the moment there's so much variation.

Perhaps @daggemarren can provide us with more fixes around these fields that need adjustments. We like the PR's :-)

I'm going to hold off on merging this PR until we find a consistent way to handle this across components.

Alright, gonna close this and someone can open a discussion / submit a new PR if they want to talk to people about making this behaviour consistent. At the moment though, I've got lots of issues & features to work though so I'm not able to dedicate time to this myself.

I really don't understand this action.
Instead of embracing a bugfix the PR is closed?

I really don't understand this action.
Instead of embracing a bugfix the PR is closed?

@ekandreas Hi, thanks for the feedback. I still stand by my decision. While this might be a "bug fix" for one field, it will continue to cause inconsistency across all fields of the project. I did not say that this was unappreciated, nor that this is an issue we will not solve. I just said that I am holding off merging this fix until we find a consistent solution across all components.
If you'd like to see this fix merged, please suggest to me how we can make attribute merging consistent. I'm happy to discuss it here, or in a Discussion. Hope to hear from you soon!

Hey @daggemarren @ekandreas, I've settled on a solution for this. I've made the changes in #935.

All extraAttributes() are now always merged onto the outer HTML element of the component.
The new extraAlpineAttributes() method always merges attributes onto the root Alpine element (the one containing x-data).
The extraTriggerAttributes() method (specifically for date pickers), merges onto the trigger button. In the future, if other custom attribute bags are required for other components, we may use this syntax as a template.


amplify 7.x.x fails ci/cd build for one branch / fine on other

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.10.0
Amplify CLI Version
7.x.x
What operating system are you using?
Ubuntu WSL
Amplify Categories
auth, storage, function, api, hosting
Amplify Commands
push
Describe the bug
Today I was pinged by a former customer that their amplify builds (which i setup and contributed to) where suddenly failing the ci/cd pipeline, sometimes.
The sytstem builds the 'dev' backend on pushes to master, 'prod' on pushes to the 'prod' branch. prod always was fine, on pushes to master we saw the following issue

:
2021-11-15T15:25:20.701Z [INFO]: UPDATE_COMPLETE amplify-controlapp-dev-95224 AWS::CloudFormation::Stack Mon Nov 15 2021 15:25:20 GMT+0000 (Coordinated Universal Time)
2021-11-15T15:25:30.450Z [WARNING]: ✖ An error occurred when pushing the resources to the cloud
2021-11-15T15:25:30.453Z [WARNING]: ✖ There was an error initializing your environment.
2021-11-15T15:25:30.461Z [INFO]: TypeError: Cannot read property 'includes' of undefined
                                     at moveBackendResourcesToCurrentCloudBackend (/root/.nvm/versions/node/v12.21.0/lib/node_modules/@aws-amplify/cli/src/extensions/amplify-helpers/update-amplify-meta.ts:67:81)
                                     at AmplifyToolkit.updateamplifyMetaAfterPush [as _updateamplifyMetaAfterPush] (/root/.nvm/versions/node/v12.21.0/lib/node_modules/@aws-amplify/cli/src/extensions/amplify-helpers/update-amplify-meta.ts:206:3)
                                     at runMicrotasks (<anonymous>)
                                     at processTicksAndRejections (internal/process/task_queues.js:97:5)
                                     at Object.run (/root/.nvm/versions/node/v12.21.0/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/src/push-resources.ts:310:7)
2021-11-15T15:25:30.490Z [ERROR]: !!! Build failed
2021-11-15T15:25:30.490Z [ERROR]: !!! Non-Zero Exit Code detected
2021-11-15T15:25:30.490Z [INFO]: # Starting environment caching...
2021-11-15T15:25:30.491Z [INFO]: # Uploading environment cache artifact...
2021-11-15T15:25:30.550Z [INFO]: # Environment caching completed

The backend was at this point successfully pushed (all stack successfully deployed) but the build failed and no frontend changes were rolled out.
The amplify push is done via the 'default'  amplifyPush --simple.
master and prod at this point are functionally identical (master was merged into prod via git merge --no-ff master). Dev might have been pushed to from a developers workstation via amplify push with a cli (version 7.x.x).
Pinning the build system to use amplify 6.4.0 resolves the build issues and makes the ci behaviour consistent again.
It should also be noted that the amplify project also utilizes custom cloudformation categories / resources (setting up iot rules). From the error it is difficult to say which part exactly did not have content where it was expected.
Expected behavior
Builds have same build status for same code on both branches when their code is identical.
Reproduction steps
not sure what first trigger this. I assume amplify cli v7 could be the issue as according to skimming the docs their might be some migration necessary.
GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

@ingwinlu Thank you for sending over your amplify folder to us. We took a look at the files and root-caused it to the "iotrule" custom category that you're having in the project which is missing a "service" key in all it's corresponding resources like the other Amplify resources. We're working on a fix right now but in the meanwhile if you add add a "service" to your custom category resources which you have in your project like other Amplify resources, you should be unblocked. We'll post an update once we release the fix for it.


BUG - Broken Account Creation Link

Describe the bug
Link to Account Creator is Broken
To Reproduce
Steps to reproduce the behavior:

Search for eosmechanics
Click on alohaeosprod

Expected behavior
https://explorer-test.telos.net/account/alohaeosprod
Erroneous Link:
https://explorer-test.telos.net/account/account

@DestinyDevTeam see linked PR for netlify Deploy Preview link.

Link to created by is now working.
Did test all the way to root: eosio from an ordinary account.


Leave a forward pointer to delegation roles in ddc doc

Leave a short forward pointer to delegations so that this doc's outline is better represented from teh summary.  Affects UCP 2.0.x
cc @joaofnfernandes
Signed-off-by: Riyaz Faizullabhoy<EMAIL_ADDRESS>

Deploy preview ready!
Built with commit 76fd6c0d5d8b7ea63e8a282b746e90aad2c382be
https://deploy-preview-839--docker-docs.netlify.com


Add customized constraints for VRP

I'm using google OR tools (python) to solve a vehicle routing problem in which the delivery points belong to a zone. What is the most effective way to consider into routing model the constraint that each vehicle can cross at most N zones?
Thank you very much!

Maybe one dimension per zone, +1 on each visit on its given dimension.
Count the number of dimensions > 0.
Something like that.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le ven. 29 mars 2019 à 16:42, FrancescoAntonini<EMAIL_ADDRESS>a écrit :

I'm using google OR tools (python) to solve a vehicle routing problem in
which the delivery points belong to a zone. What is the most effective way
to consider into routing model the constraint that each vehicle can cross
at most N zones?
Thank you very much!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1168, or mute the thread
https://github.com/notifications/unsubscribe-auth/AKj17Y8HK4C-m2oQuI6RDd8I3dPKKehuks5vbjRNgaJpZM4cSrTE
.

If your zoning needs aren't strict, then one thing that's worked for me is to use AddSoftSameVehicleConstraint - this lets you group your locations, then penalize crossing into another zone.  You can tune the penalty as low or as high as you like.
The effect here is to allow "stealing" of deliveries across zones - sometimes, it's a better plan overall if some delivery points are served by different drivers.
If your zoning requirements are strict, you could still use this feature, just set the coefficient value very high.

I have no good solutions.
You can always have 1 dimension per zone, and then add a constraint
MakeIsGreaterThanCstCt(cumul_at_end, 0) for each dimension, and restrict the sum of these to be less than your constant.
Performance of the local search will be degraded though.


Disable infopanel in visdiff due to new notifications connected component

@MarcoPolo

:no_entry: Error rendering the commits ed6b537f601b...04439261d78b on linux. :mag_right: 2 errored, 2 new, 5 changed

Error in ed6b537f601b: Chat_Info_Panel-Normal-ERROR

Error in ed6b537f601b: Chat_Info_Panel-Muted-ERROR

Added: Chat_Banner_Broken-Broken_Tracker_2

Added: Chat_Banner_Broken-Broken_Tracker_1

Changed: Chat_Inbox-You_Rekey_Selected (before) (after)

Changed: Chat_Inbox-You_Rekey (before) (after)

Changed: Chat_Inbox-Part_Rekey_Selected (before) (after)

Changed: Chat_Inbox-Long_Top (before) (after) (diff)
Changed: Chat_Banner_Broken-Broken_Tracker_3 (before) (after) (diff)

Visdiff seems very confused! But I guess I'll go ahead.


Abstract out ADF's time series generation functionality  so other components can use it

We should also be sure that this is not a duplicated effort (eg, with Brian Dobbin's tool).
This could also be an area where we could leverage GeoCAT.

The ADF tool just uses ncrcat and is not very flexible. The main things we want are chunking and compression. Should this be part of issue #18 ?

In our discussion during the CUPiD hackathon, we decided we'll want to pull out adf_diag.create_time_series(); this will entail a slight rewriting.
We want to avoid circular dependencies. Let's plan to make a timeseries.py file within CUPiD/cupid. Eventually, if we pull in Brian Dobbins' timeseries repository (if it's actually useful to replace), we can replace the timeseries.py file.

We could merge the ADF taylor diagram with GeoCat Viz taylor diagram.
Taylor_plot_setup, plot_taylor_data, and taylor_plot_finalize could probably be replaced by geocat's function. We probably can't replace gathering data from ADF, selecting variables, subsetting for seasonal averaging, etc.

Overarching CUPiD needs: timeseries, regridding, climatology/time averaging, website generation functionality.
Prioritization:

Website generation move into CUPiD -- This currently uses jinja and should be within CUPiD itself rather than universal outside of CUPiD.
GeoCAT could be really useful for regridding and ADF has more flexible time averaging (eg, 4 month seasonal averages or single).
Put timeseries into CUPiD -- if we are prioritizing this, it would be good to know which components need timeseries vs history files?
Determine if some of the more generalized plotting functions are more useful in GeoCAT viz or in CUPiD . (Within ADF/lib/plotting_functions.py, we may want to pull mask_land_or_ocean into a centralized place.)

Moving forward:

[ ] Have GeoCAT member attend ADF hackathon on a Thursday afternoon or another meeting time -- determine which functions we can make into GeoCAT functions - @kafitzgerald can coordinate with GeoCAT to see who can join.
[ ] Making top level CUPiD website - @justin-richling and @TeaganKing can collaborate on this.
[ ] See if timeseries is needed for other components during next CUPiD meeting @TeaganKing will add to agenda
[ ] @justin-richling - time averaging comparison with ADF and GeoCAT comp

From a discussion with @mnlevy1981 regarding the timeseries note-- we'll eventually want to have all components be able to run on timeseries in order to use smaller model output files, but we should probably first focus on some of the other items from the ESDS event hackathon last week.


Change versioning path

Per default, API Management wants to add the versioning at the end. Therefore, we should change the pattern
from api/v1 to v1/api.
But this would mean a breaking change, and we have to be careful and also change all clients relying on the existing endpoints.

really? Everything else uses api/v1, including Microsofts .Net ... we cannot adjust API Management? If we do it it gets complicated with the various internal clients we already have


147 BE getCategories

/api/v1/categories with a GET method now returns an array with all the categories (React, Javascript, Angular, etc.) as an array like this:
[
  {
    id: String,
    name: String
  }
]

/api/v1/categories with a GET method now returns an array with all the categories (React, Javascript, Angular, etc.) as an array like this:
[
  {
    id: String,
    name: String
  }
]

Swagger is ready?

Hay conflictos @oriolsastre

All paths are now defined in routes.ts, and used by routes and openapi from there.


Add a changelog to the project

Changes are mainly logged in the releases page and RPM/deb files, it would be convenient to have a changelog collecting them.
https://keepachangelog.com/en/1.0.0/

This is now available for releases 0.12.0 onwards


Daily Log Page

Description
Creates a Daily Log page where a user can view their daily caloric budgets, macronutrient targets as well as chronologically ordered list of food items they ate.
Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, tested, ready to review and merge

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

all updates are on the add-food-log-update branch


Workspaces error with incorrect json file

Microsoft PowerToys version
0.87.1
Installation method
Microsoft Store
Running as admin
No
Area(s) with issue?
Workspaces
Steps to reproduce
Create a new Workspace.
Launch it.
✔ Expected Behavior
For apps to launch
❌ Actual Behavior
Immediately errors without launching anything.

See log:-
[2024-12-23 10:31:44.801262] [p-6304] [t-14512] [info] workspaces-launcher logger is initialized
[2024-12-23 10:31:44.844718] [p-6304] [t-14512] [trace] Invoke point: 0
[2024-12-23 10:31:44.844875] [p-6304] [t-14512] [critical] Incorrect Workspaces file
Other Software
No response

Note the similar issue is similar, but not quite the same

@Crivens Please send a /bugreport we'll check if there is something broken in the .json file.
If you are blocked by this issue, you can delete the workspaces.json file. But note, that in that case you will loose all your workspaces and will have to re-create them.
We are sorry for the inconveniences. Best regards

Will do, but note that literally the file it's complaining about doesn't exist. Inside workspaces app it is loading, but explorer doesn't show the file existing (explorer set to show hidden files):-

On the original pic there is at least one workspace, which theoreticaly has to be stored in the workspaces.json file in the directory you were looking for it.
It might be that for some reason the json file has been deleted. As a sideeffect the tool should work normally (and you will have to re-create your workspaces - which would end up in re-creating the json file).

I'll try it, but note doing the PowerToys report bug option results in it saying it has, but the desktop showing it hasn't:-

Ok I deleted the original workspace. Note that even though the workspace file didn't exist where it said it should be (error on launch), it still loaded it fine.
Created a new workspace and saved it. Same error. Again the mentioned workspaces.json file does not exist in the directory it mentions in the error.


Adjust first day of week according to locale (#13)

Since there currently is no option parsing, this commit adjust the
calendar solely according to locale, therefore this won't be portable if
the system doesn't use glibc.
In the future, even the system doesn't use glibc, user can use options,
for examples, -s (Sunday) and -m (Monday), to at least override the
default first day of week (first_weekday), currently set to Monday.
The detail of calculating the first day of week from locale setting,
LC_TIME section, can be read in locale(5) (read NOTES section first),
and util-linux's cal.c is a good example to read.

At first glance LGTM. Any reason for changing start of the week to sunday over monday tho?

@shaggytwodope As far as I know, en_US locale is Sunday first, which probably is a good reason. I am also used to Sunday first.
While I was trying a few locales, there are actually three locales (ff_SN, fa_IR, and ps_AF) starting on Saturday. I hope that isn't a bug, at least not in my code but in the locale.

@livibetter Right on, changes make sense to me now. Good work mate.

After my previous comment, I realized that I haven't checked with cal command, but surprisingly all three locales start with Wednesday in cal. (I translate the positions of the dates since I can't read those languages)
My calculations using locale settings are all Saturday, and according to Wikipedia:

In the Iranian calendar, every week begins on Saturday and ends on Friday.

I am not sure what's going on and I definitely have no knowledge to figure out. Anyway, I just want to leave a note here and mention it,

Thank you so much for your work!


Separate importDocmaps and importDocmap into different task queues

We should work on the cluster deployment before merging this.


Feature Request: Average Read Latency

The instant read latency is affected by the current network conditions and is jittery.
An average read latency could be calculated perhaps using a sliding window (or just adding up previous reads), whenever we "check" with the relay again.

A bit of work is being done in this area. It is related to #19

PR #190 will likely address this request

@Cameri If you're interested, I got pretty far on this. You can check out the progress here: #190  (check the netlify preview)
Ignore the uptime stuff, that won't be functional/beautiful until a bit later.


Updates the CO2 cycle to PAGE-ICE

Updated values in CO2forcing.jl and mcs.jl, created new components in…Updated values in CO2forcing.jl and mcs.jl, created new components in CO2cycle.jl (also included in mcs.jl) for the CO2 concentration.
To be checked:

used tea0 as baseline annual CO2 emissions (TOTAL_E_CO2_0) and
teay_CO2emissionstoatm as annual emmissions (anthropogenic and
permanent).
-values obtained when running test but not the same as excel file,
suspected to be from emissions to atmosphere only using global co2
emissions and not also permanent, natural emissions but not sure.

@Georgina5764 For your interest, I think I got this all working now.  At least, my tests against the Excel data check out.


Please make a version with MahsaNG Core

Hi
Please make a version with MahsaNG Xray core , they fully unblock fragment
https://github.com/GFW-knocker/Xray-core

I have no plan to this at this time


Difference in character padding between new font converter and old one

I've recently been updating my project from v7.11 to v8.0 and I had converted my fonts again.
For v7 I used the older php based front converter on the lvgl.io website, and for v8 I used the current one which I believe is built on python.
Here is a video of the same app running v8.0 to the left and v7.11 to the right.
Notice that on the right side no matter the physical length of the number, it is fixed to the decimal point.
Whereas with the exact same calibration code on the left side you can see the entire label moving just slightly left and right.
I tried the new converted font on v7.11 and can confirm the issue is not with lvgl library, but the font file.
Is there an option for you guys to convert a font on the old and new font converters and compare the output?

Old font convertor did supported a lot of features (kerning and so on). So, any kind of claims "prev convertor was better" are invalid.

Notice that on the right side no matter the physical length of the number, it is fixed to the decimal point.
Whereas with the exact same calibration code on the left side you can see the entire label moving just slightly left and right.

If you wish to stick decimal point position, here are your options:

Use monospaced font
Draw int/point/fract parts manually.

I understand, you may not like existing point drift on your video. But font is drawn exactly as designed. Problem is with wrong font use, not with convertor.

v7.11 to v8.0

If you are 100% sure prev version was v7 (not v6), probably your v7 font was generated without kerning. But i strongly NOT recommend to use such kludges. It would be better to make small rework, as said im my prev post.

@embeddedt I may be very wrong about the versions. I mentioned it because I recall reading a thread not too long ago where it was mentioned. It might have been in regards to the image converter now that I think of it, or just an old thread that was bumped.
@puzrin what would cause the difference if the same font file was used to generate the custom LV fonts?

@david-res

what would cause the difference if the same font file was used to generate the custom LV fonts?

If the same convertor + the same vector font (TTF) => probably you missed kerning in previous run (not checked appropriate checkbox). Note, possibility to exclude kerning info is very tricky and not expected to be used wide.
https://en.wikipedia.org/wiki/Kerning.
Also, with proportional (not monospaced) font, even lack of kerning should not exclude drift when digits changed ("111" can be more narrow than "999", for example)


Incorrect links for "Designing resilient applications for Azure" and "Availability checklist"

The links for "Designing resilient applications for Azure" and "Availability checklist" both direct to the same page, https://docs.microsoft.com/azure/architecture/checklist/resiliency-per-service.
I think the "Designing resilient applications for Azure" should probably direct to https://docs.microsoft.com/azure/architecture/framework/resiliency/app-design.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d8314bbb-3e1b-7a68-dcd1-f7dfe34221a2
Version Independent ID: 5c26cb3f-ec5c-b028-f456-53998a67749e
Content: Disaster recovery and storage account failover (preview) - Azure Storage
Content Source: articles/storage/common/storage-disaster-recovery-guidance.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@mcollier Thanks for your question. We are checking on this and will respond to you soon.

#reassign: @tamram

@mcollier - Thanks for your feedback! This was resolved a while ago, but never got closed. Closing now.
#please-close


[Preprocess #2] Instructions for setting up Airflow

Closes https://github.com/opentargets/issues/issues/3102.

Note
Ready for review and merge (once approved).

Docs

Added comprehensive, reproducible instructions on how to install and set up Airflow.
Created a new “Development” section in the docs, which now contains:

Airflow
Contributing
Troubleshooting

Fixed the command to spin up the docs server.

Airflow

Removed .env and .docker-compose.yaml, which are best populated during each individual installation.
Made Dockerfile build less noisy.
Updated requirements.

Codecov Report

Merging #164 (8cf3e35) into tskir-3095-finngen-sumstat (66fa6eb) will not change coverage.
The diff coverage is n/a.

@@                     Coverage Diff                     @@
##           tskir-3095-finngen-sumstat     #164   +/-   ##
===========================================================
  Coverage                       90.75%   90.75%
===========================================================
  Files                              67       67
  Lines                            1461     1461
===========================================================
  Hits                             1326     1326
  Misses                            135      135

@mbdebian I've rebased against main and addressed all comments — could you please take a quick look to see if you're happy?


master <- develop

Build log
Preview build with this PR (commit): https://181-280922552-gh.circle-artifacts.com/0/index.html


Bump Jinja2 version from 2.11.3 to 3.0.3

This commit bumps the version of the Jinja2 templating library from 2.11.3 to 3.0.3. Version 3.1.x of Jinja2 is not supported until Wagtail 3.x (we are still on 2.15.x).
This allows for removal of a pinned MarkupSafe dependency.
See Jinja2 changelog here:
https://jinja.palletsprojects.com/en/3.1.x/changes/#version-3-0-3
Notes
To check whether this version upgrade introduces any template changes, I rendered every Wagtail page using wagtail-bakery on main and then with this change. Diffing the two batches of HTML showed no differences.
Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code follows the standards laid out in the CFPB development guidelines

Yes, I was pleasantly surprised here too. I think the upgrade to 3.1.x will be harder, if/when we get there.


training issue

Hi,
please, I tried to execute your code for training using the following command  python train.py, unfortunatly I got this error: the path for the .pth model is incorrect even I have set a pre-trained model (.pth from under the link you provided) "checkpoint" folder and I set resume=true in conf.json file.
Also, when I tried to use training data organized by the same way as you mentioned, I got an error too. Please,these errors are they engendered by the data that should I prepared to reach both repartitions : test and train as you mentioned. or the data that you have profided in LSUI dabase are sufficient to do the training?
if the preo-cessing is required, so how I can do it? Please, provide us more description about the project.
please, I'm in hurry and I want to find a solution.
Thank you in advance!

Because the paper has not been accepted yet, I have not provided a pretrained model, so you need to set "resume_state": null to train from scratch. In addition, there is no problem using LSUI for training. You can use any dataset for training. Please read carefully the method of setting the input and GT paths described in the readme:
Prepare dataset:

You should make sure your image size is 256*256
Your directory structure should look like this:

train:
DatasetName_train_16_256  (16 and 256 are set in config)
├── hr_256 (GT images)
└── sr_16_256 (input images)

test:
DatasetName_val_16_256
├── hr_256
└── sr_16_256

set train "dataroot" in config like:/xxx/xxx/xxx/DatasetName_train_16_256
set val "dataroot" in config like:/xxx/xxx/xxx/DatasetName_val_16_256

Because the paper has not been accepted yet, I have not provided a pretrained model, so you need to set "resume_state": null to train from scratch. In addition, there is no problem using LSUI for training. You can use any dataset for training. Please read carefully the method of setting the input and GT paths described in the readme:
Prepare dataset:

You should make sure your image size is 256*256
Your directory structure should look like this:

train:
DatasetName_train_16_256  (16 and 256 are set in config)
├── hr_256 (GT images)
└── sr_16_256 (input images)

test:
DatasetName_val_16_256
├── hr_256
└── sr_16_256

set train "dataroot" in config like:/xxx/xxx/xxx/DatasetName_train_16_256 set val "dataroot" in config like:/xxx/xxx/xxx/DatasetName_val_16_256

Thank you so much for your clarification and assistance. I have set the test and train repartitions,  and  the required adjustment in .json file as you mentioned. It's worked.
But, when running the training, I could not find the training model, even all sub-folders under "training-experiment" folder. Shall I install wndb to find the build training model or what?  or is there any further parameter in json file to adjust?
Moreover, when inference and validation operations are running before the ending, the laptop restart: is this resulted from the insufficient memory or RAM storage?  The same problem for inference and validation as the training operation, I find the sub-folders empty under the "val_experiment" folder.
You response will be useful to make my work correctly.
Thank you again!

Check the train_save configuration in your train config:
    "train": {
        "n_iter": 10000000,   // After how many iters it will end
        "val_freq": 50000,     // After how many iter will be val.
        "save_checkpoint_freq": 50000 // After how many iters will the checkpoint be saved.
        }

Thank you again for your previous efforts.
I have tried with the configuration that you have give me for the validation, but I have got the same issue: the laptop was switch-off, then restart. Also, all the sub-folders of the experiments_training folder were empty. Moreover, I have tried the inference operation and I have got the same issue for my laptop and all the sub-folders of the experiments_validation folder were empty, except the "results" sub-folder which contained some images as the execution was interrupted each time.
Please, can you help me to let the validation and inference operations go on very well and the laptop works without having the issue mentioned  above. Do I have to decrease the values of the model parameters? or what should I do?
Thank you

Your laptop's shutdown and restart were not caused by my code. I have successfully completed the training on my Linux server (with an Nvidia RTX 3090), and this code has been verified by many others without any issues. Please check your laptop for potential problems.

How long does it take to train the best model? Can the batch size only be 1?


Remove the change of box-shadow of is-disabled button upon hover

Description

This PR overwrote the box-shadow of .nes-btn.is-disabled:hover::after so that the disabled button won't change upon hover.
Before this pr, the disabled button behaved like:

After, it behaves like:

Thank you for your time on reviewing this PR :).
Compatibility

This should not break anything.
Caveats

None.

The new commit fixed the lint error of the commit message.


Invalid AzureCognitiveSearch configuration detected: 403 Client Error: Forbidden for url

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

When deployed to Azure, the example works, but when I tryied to run locally, using the same input variables, I am receiving the following error message "Invalid AzureCognitiveSearch configuration detected: 403 Client Error: Forbidden for url: https://AZURE_SEARCH_SERVICE.search.windows.net/indexes/azureblob-index-v3?api-version=2021-04-30-Preview. Given it works on Azure, the problem is not with my credentials (I used these credentials oustside azure directly on AzureCognitiveSearch SDK and it worked).
Is there any documentation on how to integrate AzureCognitiveSearch with ChatGPT API? I can't find anything detailing the inputs of the data source entry.
Minimal steps to reproduce

Install the application following the documentation and export the following environment variables:

AZURE_OPENAI_KEY
AZURE_OPENAI_RESOURCE
AZURE_OPENAI_PREVIEW_API_VERSION
AZURE_OPENAI_MODEL
AZURE_OPENAI_MODEL_NAME
AZURE_OPENAI_TEMPERATURE
AZURE_SEARCH_SERVICE
AZURE_SEARCH_INDEX
AZURE_SEARCH_TOP_K
AZURE_SEARCH_CONTENT_COLUMNS
AZURE_SEARCH_TITLE_COLUMN
AZURE_SEARCH_KEY
AZURE_OPENAI_STREAM

AZURE_SEARCH_SERVICE_ENDPOINT
AZURE_SEARCH_INDEX_NAME
AZURE_SEARCH_API_KEY

Any log messages given by the failure

Just the error message:

 "Invalid AzureCognitiveSearch configuration detected: 403 Client Error: Forbidden for url: https://AZURE_SEARCH_SERVICE.search.windows.net/indexes/azureblob-index-v3?api-version=2021-04-30-Preview"
  }

Expected/desired behavior

The API call should succeed, the same as it is on Azure environment

OS and Version?

Linux (Ubuntu 22.04)

azd version?

Runing python directly, no azd installed

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Hi @claudino-kognita A few questions:

Are you logged in locally via azd auth login? Can you try running that right before you start the local server?
I assume AZURE_SEARCH_SERVICE in your URL corresponds to the actual value, and that's your placeholder to avoid sharing the value in this issue.
Did you deploy it using azd up after logging in with the same credentials?

Thanks for replying.

No I am not logged in via azd, I wish it to work outside azure in a
kubernetes pod based on the documentatio there is no need for being logged
in to use the plugins (as I said before, Azure Cognitive Search worked
outside azure without login)

You are right (this is the name of the variable from the example)

It was deployed with exactly the same credentials (and worked), but not
from me and not from the same machine. I am trying to replicate the
behaviour using just the inputs as the instructions In the readme.

Em qua., 19 de jul. de 2023 20:33, Pamela Fox @.***>
escreveu:

Hi @claudino-kognita https://github.com/claudino-kognita A few
questions:

Are you logged in locally via azd auth login? Can you try running
that right before you start the local server?
I assume AZURE_SEARCH_SERVICE in your URL corresponds to the actual
value, and that's your placeholder to avoid sharing the value in this issue.
Did you deploy it using azd up after logging in with the same
credentials?

—
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/azure-search-openai-demo/issues/440#issuecomment-1642895199,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYQLBMLRKEH4YBTTHLQEY6LXRBVFPANCNFSM6AAAAAA2QQXTPI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hn, so how are you logged in via Azure on that pod? The app will need to get the credentials somehow. When deployed, it gets the credentials from the app's managed identity. Locally, most devs are logged in with the Azure Developer CLI or the Azure CLI, and that's how it gets the credentials.
You can learn more about AzureDefaultCredential (used by the code) here:
https://learn.microsoft.com/en-us/python/api/azure-identity/azure.identity.defaultazurecredential?view=azure-python
Also please read through https://github.com/Azure-Samples/azure-search-openai-demo#sharing-environments if it wasn't deployed from your account.

I expect to pass these as environment variables. As it worked calling
Cognitive Search directly using just the environment variables, I expect
the same behaviour for this sdk, as it should be possible to call directly
over requests lib, like a regular API call.
Em qua., 19 de jul. de 2023 20:57, Pamela Fox @.***>
escreveu:

Hn, so how are you logged in via Azure on that pod? The app will need to
get the credentials somehow. When deployed, it gets the credentials from
the app's managed identity. Locally, most devs are logged in with the Azure
Developer CLI or the Azure CLI, and that's how it gets the credentials.
You can learn more about AzureDefaultCredential (used by the code) here:
https://learn.microsoft.com/en-us/python/api/azure-identity/azure.identity.defaultazurecredential?view=azure-python
Also please read through
https://github.com/Azure-Samples/azure-search-openai-demo#sharing-environments
if it wasn't deployed from your account.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/azure-search-openai-demo/issues/440#issuecomment-1642910147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYQLBMN7YICP5NDTJR7N5A3XRBX53ANCNFSM6AAAAAA2QQXTPI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Pamela, can you confirm it calls the API over requests and not using azure
ask is this app (this is why I expect I has no need for azure credential
chain).
Em qua., 19 de jul. de 2023 20:57, Pamela Fox @.***>
escreveu:

Hn, so how are you logged in via Azure on that pod? The app will need to
get the credentials somehow. When deployed, it gets the credentials from
the app's managed identity. Locally, most devs are logged in with the Azure
Developer CLI or the Azure CLI, and that's how it gets the credentials.
You can learn more about AzureDefaultCredential (used by the code) here:
https://learn.microsoft.com/en-us/python/api/azure-identity/azure.identity.defaultazurecredential?view=azure-python
Also please read through
https://github.com/Azure-Samples/azure-search-openai-demo#sharing-environments
if it wasn't deployed from your account.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/azure-search-openai-demo/issues/440#issuecomment-1642910147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYQLBMN7YICP5NDTJR7N5A3XRBX53ANCNFSM6AAAAAA2QQXTPI
.
You are receiving this because you were mentioned.Message ID:
@.***>

That should work in theory, since AzureDefaultCredential will attempt to look for environment variables. You have all these setup?
https://learn.microsoft.com/en-us/python/api/azure-identity/azure.identity.environmentcredential?view=azure-python
You could try changing line 35 in app.py to explicitly use EnvironmentCredential class, to make sure thats where its getting the creds.

Pamela, are you sure those variables are needed and we are on the same
page? The application I am talking about (and the line 35 of it) could be
seen on this link:
https://github.com/microsoft/sample-app-aoai-chatGPT/blob/e86035d4a9d0563b337e0c75de29b8c4007a9703/app.py#L35
Here you can see just an environment variable being loaded. I found no use
of Azure ask on the whole page.
Em qua., 19 de jul. de 2023 21:13, Pamela Fox @.***>
escreveu:

That should work in theory, since AzureDefaultCredential will attempt to
look for environment variables. You have all these setup?
https://learn.microsoft.com/en-us/python/api/azure-identity/azure.identity.environmentcredential?view=azure-python
You could try changing line 35 in app.py to explicitly use
EnvironmentCredential class, to make sure thats where its getting the creds.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/azure-search-openai-demo/issues/440#issuecomment-1642921986,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYQLBMJTOODBDNRTP4SOKVTXRBZY3ANCNFSM6AAAAAA2QQXTPI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Ah, that is a different code sample than this repo, that explains the confusion.
If that's definitely the code you're using, then you're right, it does not use the Azure SDK, it uses AZURE_OPENAI_KEY and AZURE_SEARCH_KEY. Assuming those are set correctly, then I recommend checking your access. Here's what it looks like for me for the search service when I use "View my access":

You can see in this Bicep file how the roles can be configured programmatically (when deploying with azd):
https://github.com/microsoft/sample-app-aoai-chatGPT/blob/e86035d4a9d0563b337e0c75de29b8c4007a9703/infra/main.bicep#L198
We also have a script in this repo that can set roles, which you could use for that repo:
https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/scripts/roles.ps1

Update: I'm not sure that the roles should be needed for that repo's code, given it's using keys. But I'm also surprised by the error message. Please confirm which codebase you're using and check the values of AZURE_OPENAI_KEY and AZURE_SEARCH_KEY. You can print them out in app.py.

Thanks, I checked. They are all ok. I extracted the http request and made
it directly by curl, could confirm the credentials and the values, and the
error kept the same.
Is there any documentation about using Cognitive Search with this API?
Em qui., 20 de jul. de 2023 07:14, Pamela Fox @.***>
escreveu:

Update: I'm not sure that the roles should be needed for that repo's code,
given it's using keys. But I'm also surprised by the error message. Please
confirm which codebase you're using and check the values of
AZURE_OPENAI_KEY and AZURE_SEARCH_KEY. You can print them out in app.py.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/azure-search-openai-demo/issues/440#issuecomment-1643652856,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYQLBMIHT3LFV76TA6GQAGDXREAIDANCNFSM6AAAAAA2QQXTPI
.
You are receiving this because you were mentioned.Message ID:
@.***>

@claudino-kognita I have found documentation here:
https://learn.microsoft.com/en-us/azure/ai-services/openai/use-your-data-quickstart?tabs=command-line&pivots=rest-api
I'm going to close this issue since it's not about this repository. Feel free to open an issue on the other repository if you're continuing to see issues with that code.

I had the same issue today.. I just found i was using a Query key instead of an Admin Key on Opensearch key page. I think it shall be shared on the Documentation page.

@Zion-Avantis Were you using this repo or https://github.com/Microsoft/sample-app-aoai-chatGPT/ ? If you were using this repo, the azd up takes care of setting all the necessary keys. If you were using the other repo, please file an issue there with suggested clarification to the README. Thanks!

I was using the same repo as the author :) I am just answering in case people end up here :)

@Zion-Avantis thank you, I was stuck on that one too.

Thanks! I was stuck on this one for a while now. I agree, it should be mentioned in the documentation to use the Admin key, not a query one.

If we're talking about https://github.com/microsoft/sample-app-aoai-chatGPT#environment-variables it does say admin key there, but please send a PR to that repo if you think it needs to be mentioned somewhere else as well. Thanks!

@pamelafox you are right, the documentation states this, my bad. Thank you for your help.

Yes, sorry, didn't update here, but shared the issue on other canal and they updated it :) So it's fixed :)

Where to check and find  AZURE_SEARCH_KEY ?
I am getting below error
Traceback (most recent call last):
File "d:\AIML\AIMLenv\AzureOpenAI\ACS_LLama2_Langchain.py", line 77, in
relevant_documents=retriever.get_relevant_documents("what is Ansys")
File "D:\AIML\AIMLenv\lib\site-packages\langchain_core\retrievers.py", line 211, in get_relevant_documents
raise e
File "D:\AIML\AIMLenv\lib\site-packages\langchain_core\retrievers.py", line 204, in get_relevant_documents
result = self._get_relevant_documents(
File "D:\AIML\AIMLenv\lib\site-packages\langchain\retrievers\azure_cognitive_search.py", line 98, in _get_relevant_documents
search_results = self._search(query)
File "D:\AIML\AIMLenv\lib\site-packages\langchain\retrievers\azure_cognitive_search.py", line 74, in _search
raise Exception(f"Error in search request: {response}")
Exception: Error in search request: <Response [400]>

I think you are posting in the wrong repo, as none of those files match ours. Regardless, you can probably find AZURE_SEARCH_KEY by looking in the Azure Portal for your Azure search index and getting the keys from there, then exporting that environment variable in your environment.


WIP: add a wast format scanner+parser

Open to reviews and discussion. Expect bugs and unexpected behavior. This branch is not ready for merge (yet !).
As discussed in #34 with @sbinet here is a first take at a file scanner for .wast files. The implementation lacks proper unit tests and comments but I am open to suggestions and reviews.
The end goal of this feature is to be able to input .wast files to wagon and directly run wasm code. In a more usual context, wast files are mostly used for unit testing implementations of a wasm virtual machine and standard compliance.
This means that we could benchmark wagon against the wasm test suite.
I will continue working on this in my spare time. Again, feel free to comment and contribute. All help is welcome.
EDIT: to test the actual scanner, simply run go test in the /wast directory.

This change is

Review status: 0 of 4 files reviewed at latest revision, 10 unresolved discussions.

wast/scanner.go, line 1 at r1 (raw file):

package wast

please add a license header.

wast/scanner.go, line 53 at r1 (raw file):

const (
	EofRune = -1

do these need to be exported?

wast/scanner.go, line 70 at r1 (raw file):

	}

	s.inBuf.UnreadRune() // rewind

shouldn't we always rewind? (ie: use a defer just after the call to s.inBuf.ReadRune)

wast/scanner.go, line 119 at r1 (raw file):

}

func (s *Scanner) NextToken() (token *Token) {

I would probably just name it Next()

wast/scanner.go, line 324 at r1 (raw file):

}

// *** // *** // *** // *** // *** // **** // *** // *** // *** // *** // *** //

please remove

wast/scanner.go, line 328 at r1 (raw file):

const (
	scanErrPrefix  = "\x1b[31merror:\x1b[0m "
	scanWarnPrefix = "\x1b[34mwarining:\x1b[0m "

s/warining/warning/
not sold on the fancy ANSI colors either :)

wast/scanner.go, line 344 at r1 (raw file):

}

// *** // *** // *** // *** // *** // **** // *** // *** // *** // *** // *** //

please remove.

wast/scanner.go, line 443 at r1 (raw file):

func isNat(s string) bool {
	if strings.HasPrefix(s, "0x") {

what about 0X ?

wast/scanner_test.go, line 1 at r1 (raw file):

package wast

please add a license header.

wast/token.go, line 1 at r1 (raw file):

package wast

please add a license header.

Comments from Reviewable

(just a first pass, I'll look at it in more details in a bit)

Review status: 0 of 4 files reviewed at latest revision, 10 unresolved discussions.

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 10 unresolved discussions.

wast/scanner.go, line 70 at r1 (raw file):
Previously, sbinet (Sebastien Binet) wrote…
shouldn't we always rewind? (ie: use a defer just after the call to s.inBuf.ReadRune)

This actually fixes some EOF corner cases. Thanks

wast/scanner.go, line 443 at r1 (raw file):
Previously, sbinet (Sebastien Binet) wrote…
what about 0X ?

The wasm standard actually doesn't specify any syntax for 0X. I just thought to stick to pure standard before adding extensions to the language.
Reference: spec interpreter

Comments from Reviewable

It's starting to look good. perhaps time to start documenting a bit the exported API?

There is one pretty caveat here. It might look good, but this only showcases a very limited part of the accepted wast syntax. For instance, integers and floating point numbers syntax are pretty complex (pretty high priority in TODO list). Some instructions such as f64.reinterpret/i64 need some context.
A question I can't seem to be able to chose any reasonable solution is: do we want to generate specific tokens for each instructions independently or do we want to have higher level token kinds that wrap a specific set of instructions ?
Take this (surely malformed) snippet:
(func "foo" (param $x i32) (result f32)
     i32.reinterpret/f32
    ....)

Whould the tokens be: LPAR, FUNC, STRING "foo", ..., RPAR, REINTERPRET "i32" "f32", ... or LPAR, FUNC, STRING "foo", ..., RPAR, I32_REINTERPRET_F32, .... That is, in the first case, the tokens of kind REINTERPRET carry additional information about their specificity (source type, ...) which has the benefice of providing a more modular scanner and parsing API but adds (unnecessary ?) complexity to type design and internal processing.
I will probably be able to work on this later in January.
What are your thoughts ?

we now have a way to marshal wasm.Module to a wasm binary file.
it would be really great if someone could pick up the parsing of wa(s)t files, so we could synthesize a wasm.Module from that :)
@Spriithy?

Hi there, I am currently in holidays for the rest of the summer and starting a new position in early september. I can give a quick look maybe between the 21st-27th of August. It would be great if someone could pick up where I left off, unfortunately

needs https://github.com/go-interpreter/license/pull/4
any status update?

I'm afraid I won't have the time to work on this.
I liked your work on GoHEP, I hope the project will live on even after your recent annoucement.

No worries.
If you don't mind, I'll adopt that PR after having added you to the list of authors.
(I didn't realize you had a HEP background (or an eye towards it)... :) Thanks for your kind words about GoHEP)

Sure, I might give a look back at this if I find the time some day.
Physics rocks ;)

Codecov Report

Merging #50 into master will decrease coverage by 0.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   70.24%   69.34%   -0.91%
==========================================
  Files          49       51       +2
  Lines        5499     5871     +372
==========================================
+ Hits         3863     4071     +208
- Misses       1283     1439     +156
- Partials      353      361       +8

Impacted Files
Coverage Δ

wast/token.go
65.00% <0.00%> (ø)

wast/scanner.go
55.39% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca9570...b91d2df. Read the comment docs.

Codecov Report

Merging #50 into master will decrease coverage by 0.9%.
The diff coverage is 55.91%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   70.24%   69.34%   -0.91%
==========================================
  Files          49       51       +2
  Lines        5499     5871     +372
==========================================
+ Hits         3863     4071     +208
- Misses       1283     1439     +156
- Partials      353      361       +8

Impacted Files
Coverage Δ

wast/write.go
70.15% <ø> (ø)
:arrow_up:

wast/scanner.go
55.39% <55.39%> (ø)

wast/token.go
65% <65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca9570...a91ced3. Read the comment docs.


repos to keep an eye on

Some students are so excited for the next semester that they create empty repositories for the modules of the coming semester. Some as much as 2 months before the semester starts! (see also #16)
Those repos show up in the update-check script but since they don't contain any relevant information, they should not be added to the list.
However, they might be extended by their maintainers in the future.
To work around this problem, this issue contains a list of repositories that are incomplete/empty to check at a later point in time.

@daveschafer

[ ] https://github.com/daveschafer/hslu-hs19-islab
[ ] https://github.com/daveschafer/hslu-hs19-movk

@tschibu

[ ] https://github.com/tschibu/hslu-dl4g


CI: add tarpaulin

Simple result from 5 min discussion with @joseandro. Left for later.

Closing this in favour of: https://github.com/o1-labs/proof-systems/pull/2504


Web - Listview.separated not showing dividers

Steps to Reproduce

In main.dart

    return ListView.separated(
      separatorBuilder: (context, index) => Divider(
        height: 3,
        color: Colors.black,
      ),

Run in Chrome

Run

Expected results:
Like in iOS

Actual results:

Logs

[✓] Flutter (Channel beta, 1.23.0-18.1.pre, on Mac OS X 10.15.6 19G2021 x86_64, locale en-GB)
    • Flutter version 1.23.0-18.1.pre at /Users/alviswong/dev/flutter
    • Framework revision 198df796aa (2 weeks ago), 2020-10-15 12:04:33 -0700
    • Engine revision 1d12d82d9c
    • Dart version 2.11.0 (build 2.11.0-213.1.beta)

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[!] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on
        the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To install:
        sudo gem install cocoapods

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.1

[✓] Connected device (3 available)
    • iPhone 12 Pro Max (mobile) • 54C44AF6-5044-47EB-9750-FE7A955438CC • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-1 (simulator)
    • Web Server (web)           • web-server                           • web-javascript • Flutter Tools
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 86.0.4240.111

! Doctor found issues in 3 categories.

Hi @awfin
I see there's an open issue (https://github.com/flutter/flutter/issues/46339
) addressing the case you described.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


Iontransfer

Extend CoreNEURON gap transfer to be equivalent to NEURON
Associated with neuronsimulator/nrn#883

[x] Issue neuronsimulator/nrn#842 fixed
[x] Issue neuronsimulator/nrn#866 fixed
[x] Generalized to non-voltage sources.

How to test this?
cmake .. -DCMAKE_INSTALL_PREFIX=install -DIV_DIR=$HOME/neuron/ivcmake/build/install -DPYTHON_EXECUTABLE=`which python3` -DNRN_ENABLE_PYTHON_DYNAMIC=ON -DNRN_PYTHON_DYNAMIC="python2.7;python3.7" -DNRN_ENABLE_TESTS=ON -DNRN_ENABLE_CORENEURON=ON -DCMAKE_BUILD_TYPE=Debug
make -j 6 install
cd ../test/gjtests
nrnivmodl -coreneuron mod
mpiexec -n 2 nrniv -mpi -python test_natrans.py

File transfer mode not tested.
CI_BRANCHES:NEURON_BRANCH=iontransfer,

Generalized to non-voltage sources.

@nrnhines : I see above item is not checked yet. Is that still work in progress? Or should I review this already?
Retest this please.

I believe this is ready to merge.
valgrind --leak-check=full --show-leak-kinds=definite `pyenv which python` test_natrans.py

does not show any definite leaks that were introduced by this pull request. Do all the unsuccessful checks just mean that the data files are 1.4 and neuron master is still 1.3? Or that all the test data files need to be rebuilt?

Do all the unsuccessful checks just mean that the data files are 1.4 and neuron master is still 1.3? Or that all the test data files need to be rebuilt?

yes, we need to regenerate test data:

num_mpi=2
num_omp_thread=1
Error: Incompatible binary input dataset version (expected 1.4, input 1.3)
MPT ERROR: Rank 1(g:1) received signal SIGABRT/SIGIOT(6).

We have instructions to generate data here: https://github.com/BlueBrain/CoreNeuron/tree/master/tests/integration
I will take a look at other CI tests tomorrow.

It appears that there are other tests that fail with  Error: Incompatible binary input dataset version (expected 1.4, input 1.3) in the Simulation Stack build. I'm not sure how to interpret the  errors in the Jenkins pipeline for the
Failed in branch GPU-unified
Failed in branch GPU-non-unified
...
100% tests passed, 0 tests failed out of 15

It is certainly the case that I did not test this pull request on a gpu.

You can see log here: https://bbpcode.epfl.ch/ci/blue/organizations/jenkins/oss.coreneuron.pipeline/detail/oss.coreneuron.pipeline/1618/pipeline

[ 69%] Building CXX object coreneuron/CMakeFiles/coreneuron.dir/network/partrans_setup.cpp.o
cd /jenkins/07/workspace/oss.coreneuron.pipeline/build_GPU-non-unified/coreneuron && /gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/compilers/2020-02-01/linux-rhel7-x86_64/gcc-4.8.5/pgi-19.10-7s7noo24zw/linux86-64-llvm/19.10/bin/pgc++  -DCORENEURON_BUILD -DCUDA_PROFILING -DDISABLE_HOC_EXP -DEIGEN_DONT_VECTORIZE=1 -DENABLE_SPLAYTREE_QUEUING -DHAVE_MALLOC_H -DLAYOUT=0 -DMPICH_SKIP_MPICXX=1 -DMPI_NO_CPPBIND=1 -DNRNMPI=1 -DOMPI_SKIP_MPICXX=1 -DPG_ACC_BUGS -DSWAP_ENDIAN_DISABLE_ASM -I/jenkins/07/workspace/oss.coreneuron.pipeline/coreneuron/utils/randoms -I/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/tools/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/hpe-mpi-2.21-7pbszh6v5u/include -I/jenkins/07/workspace/oss.coreneuron.pipeline/build_GPU-non-unified/coreneuron -I/jenkins/07/workspace/oss.coreneuron.pipeline/build_GPU-non-unified/include -I/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/cuda-9.2.88-vwflnw2g4n/include -I/jenkins/07/workspace/oss.coreneuron.pipeline -I/jenkins/07/workspace/oss.coreneuron.pipeline/external/Random123/include -I/jenkins/07/workspace/oss.coreneuron.pipeline/external/CLI11/include  -acc  --diag_suppress 161,177,550 -mp  -g  -O2 -fPIC   --c++14 -o CMakeFiles/coreneuron.dir/network/partrans_setup.cpp.o -c /jenkins/07/workspace/oss.coreneuron.pipeline/coreneuron/network/partrans_setup.cpp

"/jenkins/07/workspace/oss.coreneuron.pipeline/coreneuron/network/partrans.cpp"
          , line 110: error: identifier "nt" is undefined
          tar_data[0:nt._ndata],                      \
                     ^

"/jenkins/07/workspace/oss.coreneuron.pipeline/coreneuron/network/partrans.cpp"
          , line 135: error: expected a "]"
              #pragma acc enter data copyin(ttd.src_indices.data()[0 : n]) if (nrn_threads[0].compute_gpu)
                                                                     ^

"/jenkins/07/workspace/oss.coreneuron.pipeline/coreneuron/network/partrans.cpp"
          , line 136: error: a pointer to a bound function may only be used to
          call the function
              #pragma acc enter data create(ttd.src_gather.data[0 : ng]) if (nrn_threads[0].compute_gpu)
                                                           ^

"/jenkins/07/workspace/oss.coreneuron.pipeline/coreneuron/network/partrans.cpp"
          , line 142: error: expected a "]"
              #pragma acc enter data copyin(ttd.insrc_indices.data()[0 : ttd.insrc_indices.size()]) if (nrn_threads[0].compute_gpu)

I will have time later this evening and then I can test/fix this.

For simulation stack, the pipeline launched here was successful : https://bbpcode.epfl.ch/ci/blue/organizations/jenkins/hpc.SimulationStack/detail/hpc.SimulationStack/2885/pipeline/


default to major version 6 only

@bratseth minimal hack to default to major version 6. feel free to ignore and do it differently :-)

I think I'd rather have a switch in the controller for this.