Doesn't work for me

otto at Ottos-MacBook-Pro in ~/code/meteor/projects/react-slingshot on master
$ npm start -s
sh: babel-node: command not found
otto at Ottos-MacBook-Pro in ~/code/meteor/projects/react-slingshot on master
$ module.js:327
throw err;
^
Error: Cannot find module 'lodash/lang/cloneDeep'
at Function.Module._resolveFilename (module.js:325:15)

Odd. Running fine on my Macbook pro.

Did you get any errors from npm install?
Did you happen to have a previous version installed? With the latest release, it's important to delete node_modules before doing an npm install.

No, but I had an old version of node.  I ran npm install again, but it seemed to do nothing. Then I upgraded to node 4 using nvm.  So, I will try deleting node modules and start again.

Ok, it worked now, thanks.  I didn't think about deleting node_modules

Great to hear!


Add boiler plate to project

Create some initialization stuff for the repo.
Decisions
Just want to make sure I clearly point out decisions that I've made here, so that you can engage with them specifically

added mandatory coverage
tests are outside of the package (if someone pip installs the package, they would not get the tests)
added developer tooling in scripts/
said that we recommend using conda for managing python environments

Questions

Do you want to add pylint, black, or pydocstyle for testing?

I like it, and I think its A LOT easier to add in the beginning of development, BUT it does make iteration slower if one is unfamiliar, and encourages greater style conformity than is strictly necessary. If there is any explanation that I can give to make this a more comfortable decision, let me know! Also COMPLETELY okay, as I think it is actually a reasonable decision, to not use it. In order of goodness I would probably say pylint is best to add, followed by black then pydocstyle -- in case you didn't want to add all of them, just a subset.

Should fill out author and author email?
Let me know if you want to add any sphinx documentation, I've done it in the past and can re-learn

@camenpihor This is great!
My only feedback is that I've used versioneer in the past for version bumping, and I think that could be helpful but otherwise I'm OK with all changes.
I also think we should add one of those three. An aim, personally, for me with this project is to get back up to speed on best practices so slower iteration is A-OK.

Down to check out versioneer!

And sure! Let's do pylint :)


Generate go clients and swagger files

I just notice we don't have go clients and swagger generated in upstream and this leads to apiserver build failure in clean master.
Since we already give the guidance there, it's just one command to generate the codes.
Why are these changes needed?
Address https://github.com/ray-project/kuberay/issues/84
https://github.com/ray-project/kuberay/issues/85
Related issue number
https://github.com/ray-project/kuberay/issues/84
https://github.com/ray-project/kuberay/issues/85
Checks

[x] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

To make the CI pass. I make minor changes to arguments of goimports. it doesn't support excluding folders.


docs: Explain how to insert label into input

Should close #17079

Merged, thanks!
I might try to be a bit clearer that using a custom replace function is a choice depending on what you need inserted, not something they need to do.


Load connections from file doesn't appear to do anything

Save/load of connections is not going to be implemented for now, as mentioned in kartoza/qgis_geonode#181. We can close this issue.


input_slider web UI hidden

**Home Assistant release (hass --version): 0.26.3
**Python release (python3 --version): Python 3.4.3+
**Component/platform: Web UI
**Description of problem:
The slider control is not shown on the web UI after a restart. The name and icon are visible, but not the slider.  I can click where it should be and it shows up and lets me control it, it even triggers the automation I have attached to it.  Once I unclick, it stays visible.
**Expected:  slider should be visible after a restart.
Problem-relevant configuration.yaml entries and steps to reproduce:
input_slider:
  den_fan:
    name: Den fan
    icon: mdi:fan
    initial: 0
    min: 0
    max: 3
    step: 1
  master_fan:
    name: Master fan
    icon: mdi:fan
    initial: 0
    min: 0
    max: 3
    step: 1

Actually, the slider goes to hidden when the value is zero. Moving to 1, 2, or 3 reveals the slidere. Moving it back to zero hides it.

Closing for now due to improvements in component, if you still have the same issue with the latest version. Please create a new issue.


[Feature] Added some resource links for Angular under Front-end

Resolves #12

@all-contributors please add @SharmaAayush

@all-contributors please add @SharmaAayush

@all-contributors please add @SharmaAayush  for content such as angular resources

@all-contributors please add @SharmaAayush  for content such as angular resources


Add missing instructions for setup command

Fixes #62

thanks for your contribution! 🎉 great to see you coming back!


[FLINK-35395][core] Fix KeyedStateStore class annotation error

What is the purpose of the change
[FLINK-35395][core] Fix KeyedStateStore class annotation error
Brief change log
There is an error in the annotation of the getState method of the KeyedStateStore class.
The example in the comments is to count the number of occurrences of each ID, but there are some logic errors.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

Thanks for the fix.
I wonder what does annotation error's mean? Isn't that just a java doc error?

I read the guide (https://flink.apache.org/how-to-contribute/overview/) and I don’t know if it is a doc error, because the guide indicates that the document is stored in the /doc directory of the warehouse, and here are the comments of the code. Is my understanding wrong? Please help me figure out what to do next

Oh, /doc means flink documentation, while java doc means the doc/comments on java class/interface/method/field.
But It doesn't matter, this fix is good enough. Would you mind changing the commit message to [FLINK-35395][core] Fix the example code of KeyedStateStore#getState?

I understand, it's just a java doc error, thank you.
Okay, the commit message has been modified.

Oh, /doc means flink documentation, while java doc means the doc/comments on java class/interface/method/field.
But It doesn't matter, this fix is good enough. Would you mind changing the commit message to [FLINK-35395][core] Fix the example code of KeyedStateStore#getState?

Yes, it's just a java doc error, thank you.
Okay, the commit message has been modified.


add maven to Dockerfile

What is the current behavior?
No maven installed

What is the new behavior?
maven installed

Have tests been run against this PR?

Have appropriate comments and documentation been made on this PR?

Related changes in other repos (link commit/PR here)

Other information:

maven build is solved by having staged build in marqo dockerfile. Closing this PR


Cannot execute() a prepared statement more than once

At first glance this is similar to #24, but in my case I'm not selecting but issuing DML statements.
The code is something like:
stmt.prepare(connection, "delete from ABC where key=?");

// some other stuff

void func(int key){
  stmt.bind(0, &key);
  stmt.execute();
}

So in the example above the first execution of func() succeeds, whereas any subsequent one fails at the bind() call. Digging deeper showed prepare_bind() is failing the call to SQLDescribeParam, which returns the HY010 - Function sequence error code.
At the same time, changing the code to
void func(int key){
  stmt.prepare(connection, "delete from ABC where key=?");
  stmt.bind(0, &key);
  stmt.execute();
  stmt.close();
}

eliminates the error, but then of we lose all the benefit of doing statement parsing only once.
The DB is Oracle, just in case that matters.

I have exactly the opposite problem. After connecting to a database, all the initial DML statements of type create table ... always returning [iODBC][Driver Manager]Function sequence error. I am using nanodbc::execute() method. Only after a first successful execution of DML statement of type insert table ... then the subsequent execution of create table ... would be successful.
Replacing the call with nanodbc::just_execute() solves the problem, however, this is not a solution because the app may not know in advance whether the SQL statement is DML or not.
The exception was thrown by columns() called by auto_bind(). But why it only throws exception initially and not after a first successful execution of insert statement? The insert statement can be inserted to any existing tables and probably other DML statement type that I haven't tried may have the same side effect to cure this initial problem.
I am using a SQLite-ODBC driver compiled directly from source and installed to iODBC driver manager on a Linux host system. At this moment, I have no idea whether this is a driver-specific bug or something to do with nanodbc.
Thanks in advance for any help and thanks for providing such a great library.

Sorry for the noise, I can confirm that my issue above is due a sqliteodbc driver bug when it was built against iODBC driver manager. Some how this issue does not come up again after I rebuilt the driver against unixODBC driver manager this time. Again, sorry for the noise.

@weitjong Don't worry about it! This is good information to have here because it may help someone else in the future :)

@yktoo I have been looking at this, I just haven't made comments here to that effect. I'm not seeing a super easy way to resolve this issue. The problem is that nanodbc ultimately translates into straight C API calls, and the order of those calls is important and also, sadly, particularly strict.
We could make this case work by automatically re-preparing the statement after execution because ODBC (I am pretty sure but correct me if I'm wrong) requires that to have happened to be able to call binding statements without error. However we don't want to make it so nanodbc makes those prepare statements unless the user wants them because that could easily lead to inefficient code paths.
A more elegant solution for your use case might be to encapsulate the data "delete from ABC where key=?" somehow, for example via a functor or lambda or other means (I just depends which would be best for you...).

This issue was moved to nanodbc/nanodbc#56


doc/storage: add video links

Add a link to the YouTube video about storage buckets, and also link the volume/bucket videos from the respective how-tos.
Signed-off-by: Ruth Fuchss<EMAIL_ADDRESS>

Documentation preview available at: https://linuxcontainers.org/lxd/docs/pr.11012/


Error when creating pipeline: Invalid address to set

Versions
go version go1.12.1 darwin/amd64
Terraform v0.11.13

Issue
When attempting to create a pipeline with the following code:
provider "buildkite" {
  api_token = "${var.buildkite_token}"
  organization = "${var.buildkite_organization}"
}

resource "buildkite_pipeline" "pipeline" {
  name = "${var.pipeline_name}"
  repository = "${var.pipeline_repo_url}"

  step = "${var.pipeline_steps}"
}

I receive the following error:
Error: Error refreshing state: 1 error(s) occurred:

* buildkite_pipeline.pipeline: 1 error(s) occurred:

2019-05-07T09:42:09.343-0700 [DEBUG] plugin.terraform-provider-buildkite: 2019/05/07 09:42:09 [ERR] plugin: plugin server: accept unix /var/folders/md/0x2d3mgs7d93v0cj_p_5_hf0jm3m9m/T/plugin838100482: use of closed network connection
* buildkite_pipeline.pipeline: buildkite_pipeline.pipeline: Invalid address to set: []string{"github_settings", "0", "separate_pull_request_statuses"}

2019-05-07T09:42:09.344-0700 [DEBUG] plugin.terraform-provider-buildkite: 2019/05/07 09:42:09 [ERR] plugin: stream copy 'stderr' error: stream closed

Any idea what can be done to fix this?

The changes in https://github.com/saymedia/terraform-buildkite/pull/24 are fixing this issue.


Fix #140 (improve error messages)

return errors like in C# code (neo-project/neo#587)
update tests
small refactoring

@decentralisedkev / @fabwa any thoughts?

I have noticed, that assert.Equal is used for comparing json's. assert.JSONEq seems more suitable here to me. Could you change it?

I think it would be better to do it in a separate PR, don't you think?

I add issue for your proposal https://github.com/CityOfZion/neo-go/issues/155

Award im-kulikov 150 points
Award fyrchik 30 points for review

https://neoscan.io/transaction/144dc06fbc54dd84165af08ddd9c01e8a720ca1bb05471dfd1af1503160f245f


Can we help users understand how and when they should use driverkit?

What to document
Right now helm install falco stable/falco doesn't come up because the driver is missing.
I believe that the intent is for users to user driverkit to install various drivers - right?
Can we please document this expectation so that folks understand what they need to do to install Falco?
Right now the Falco documentation doesn't mention driverkit I don't think docs?
If this is a dependency for Falco to run I think it should be released, maintained and supported as a core part of Falco - which also means we need to document it.
Also I don't really understand the difference between driverkit docker and driverkit kubernetes?
I tried running both and ran into errors
[nova@nova driverkit]$ ./driverkit kubernetes --output-module /tmp/falco.ko --kernelversion=59 --kernelrelease=4.15.0-1057-aws --driverversion=dev --target=ubuntu-aws
INFO[0000] driver building, it will take a few seconds to complete  processor=kubernetes
^C
[nova@nova driverkit]$ ./driverkit docker --output-module /tmp/falco.ko --kernelversion=59 --kernelrelease=4.15.0-1057-aws --driverversion=dev --target=ubuntu-aws
INFO[0000] driver building, it will take a few seconds to complete  processor=docker
FATA[0001] exiting                                       error="Error response from daemon: No such image: falcosecurity/driverkit-builder:latest"

I will add these to bring up on the next call so we can figure out what we want to do.
Thanks for building this <3

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Misspelling in QuickStart Page

I found a misspelling in quickstart page. Misspelling is under the "Exposing our API as an HTTP micro-service" header.
Paragraph:
To expose our API over HTTP, all we need to do is apply a hug HTTP route decorator to the function, in addition to the local decorator. hug includes convience decorators for all common HTTP methods (GET, POST, PUT, etc).
"convience" should be "convenience"

PR created.
#697


Fix/mvn deploy

@g-k should I merge this?

@ukasiu No, this pull request was an accident. I was trying to fix deployment for the fork we use at work.


Can't control the behavior of cache mechanism correctly.

When I'm using dask dataframe as input for HyperGBM(v0.2.2) with options:
use_cache=False and don't specify cache_dir
it gaves the error bellow:
[ERROR] E hypergbm.hyper_gbm.py 584 - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/workdir/hypergbm_cache/22805_16_32f8e48ef673a57e6644a4b1b295fb66_4355a2f3c42cdb4a7b3c3f53ee8a26b5.parquet/part.0.parquet'
[ERROR] Traceback (most recent call last):
[ERROR]   File "/usr/local/lib/python3.7/site-packages/hypergbm/hyper_gbm.py", line 582, in _save_df
[ERROR]     to_parquet(df, filepath, fs)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/tabular_toolbox/persistence.py", line 93, in to_parquet
[ERROR]     result = dask.compute(parts)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/dask/base.py", line 565, in compute
[ERROR]     results = schedule(dsk, keys, **kwargs)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/distributed/client.py", line 2654, in get
[ERROR]     results = self.gather(packed, asynchronous=asynchronous, direct=direct)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/distributed/client.py", line 1969, in gather
[ERROR]     asynchronous=asynchronous,
[ERROR]   File "/usr/local/lib/python3.7/site-packages/distributed/client.py", line 838, in sync
[ERROR]     self.loop, func, *args, callback_timeout=callback_timeout, **kwargs
[ERROR]   File "/usr/local/lib/python3.7/site-packages/distributed/utils.py", line 351, in sync
[ERROR]     raise exc.with_traceback(tb)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/distributed/utils.py", line 334, in f
[ERROR]     result[0] = yield future
[ERROR]   File "/usr/local/lib/python3.7/site-packages/tornado/gen.py", line 762, in run
[ERROR]     value = future.result()
[ERROR]   File "/usr/local/lib/python3.7/site-packages/distributed/client.py", line 1828, in _gather
[ERROR]     raise exception.with_traceback(traceback)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/tabular_toolbox/persistence.py", line 54, in _arrow_write_parquet
[ERROR]     pq.write_table(tbl, target_path, filesystem=filesystem, **pa_options)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/pyarrow/parquet.py", line 1797, in write_table
[ERROR]     **kwargs) as writer:
[ERROR]   File "/usr/local/lib/python3.7/site-packages/pyarrow/parquet.py", line 609, in __init__
[ERROR]     path, compression=None)
[ERROR]   File "pyarrow/_fs.pyx", line 660, in pyarrow._fs.FileSystem.open_output_stream
[ERROR]     out_handle = GetResultValue(self.fs.OpenOutputStream(pathstr))
[ERROR]   File "pyarrow/error.pxi", line 122, in pyarrow.lib.pyarrow_internal_check_status
[ERROR]     return check_status(status)
[ERROR]   File "pyarrow/_fs.pyx", line 1072, in pyarrow._fs._cb_open_output_stream
[ERROR]     stream = handler.open_output_stream(frombytes(path))
[ERROR]   File "/usr/local/lib/python3.7/site-packages/pyarrow/fs.py", line 314, in open_output_stream
[ERROR]     return PythonFile(self.fs.open(path, mode="wb"), mode="w")
[ERROR]   File "/usr/local/lib/python3.7/site-packages/hypernets/utils/_fsutils.py", line 105, in execute
[ERROR]     result = fn(self.to_rpath(rpath), *args, **kwargs)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/fsspec/spec.py", line 943, in open
[ERROR]     **kwargs,
[ERROR]   File "/usr/local/lib/python3.7/site-packages/fsspec/implementations/local.py", line 118, in _open
[ERROR]     return LocalFileOpener(path, mode, fs=self, **kwargs)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/fsspec/implementations/local.py", line 200, in __init__
[ERROR]     self._open()
[ERROR]   File "/usr/local/lib/python3.7/site-packages/fsspec/implementations/local.py", line 205, in _open
[ERROR]     self.f = open(self.path, mode=self.mode)
[ERROR]

And sometimes results in another error:
[ERROR] 07-14 16:24:18 E hypernets.e._experiment.py 85 - ExperiementID:[None] - evaluate feature importance:
[ERROR]   File "/usr/local/lib/python3.7/site-packages/hypernets/experiment/_experiment.py", line 75, in run
[ERROR]     y_eval=self.y_eval, eval_size=self.eval_size, **kwargs)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/hypergbm/experiment.py", line 1116, in train
[ERROR]     return super().train(hyper_model, X_train, y_train, X_test, X_eval, y_eval, **kwargs)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/hypergbm/experiment.py", line 839, in train
[ERROR]     step.fit_transform(hyper_model, X_train, y_train, X_test=X_test, X_eval=X_eval, y_eval=y_eval, **kwargs)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/hypergbm/experiment.py", line 431, in fit_transform
[ERROR]     importances = feature_importance_batch(estimators, X_eval, y_eval, self.scorer, n_repeats=5)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/hypergbm/feature_importance.py", line 73, in feature_importance_batch
[ERROR]     random_state=random_state)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/tabular_toolbox/dask_ex.py", line 356, in permutation_importance
[ERROR]     col_scores.append(scorer(estimator, X_permuted, y))
[ERROR]   File "/usr/local/lib/python3.7/site-packages/sklearn/metrics/_scorer.py", line 170, in __call__
[ERROR]     sample_weight=sample_weight)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/sklearn/metrics/_scorer.py", line 247, in _score
[ERROR]     y_pred = method_caller(clf, "predict_proba", X)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/sklearn/metrics/_scorer.py", line 53, in _cached_call
[ERROR]     return getattr(estimator, method)(*args, **kwargs)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/tabular_toolbox/dask_ex.py", line 274, in call_and_compute
[ERROR]     r = fn_call(*args, **kwargs)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/hypergbm/hyper_gbm.py", line 483, in predict_proba
[ERROR]     proba = getattr(self.gbm_model, method)(X)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/hypergbm/estimators.py", line 382, in predict_proba
[ERROR]     proba = dex.fix_binary_predict_proba_result(proba)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/tabular_toolbox/dask_ex.py", line 261, in fix_binary_predict_proba_result
[ERROR]     proba = make_chunk_size_known(proba)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/tabular_toolbox/dask_ex.py", line 142, in make_chunk_size_known
[ERROR]     a = a.compute_chunk_sizes()
[ERROR]   File "/usr/local/lib/python3.7/site-packages/dask/array/core.py", line 1274, in compute_chunk_sizes
[ERROR]     [tuple([int(chunk) for chunk in chunks]) for chunks in compute(tuple(c))[0]]
[ERROR]   File "/usr/local/lib/python3.7/site-packages/dask/base.py", line 565, in compute
[ERROR]     results = schedule(dsk, keys, **kwargs)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/distributed/client.py", line 2654, in get
[ERROR]     results = self.gather(packed, asynchronous=asynchronous, direct=direct)
[ERROR]   File "/usr/local/lib/python3.7/site-packages/distributed/client.py", line 1969, in gather
[ERROR]     asynchronous=asynchronous,
[ERROR]   File "/usr/local/lib/python3.7/site-packages/distributed/client.py", line 838, in sync
[ERROR]     self.loop, func, *args, callback_timeout=callback_timeout, **kwargs
[ERROR]   File "/usr/local/lib/python3.7/site-packages/distributed/utils.py", line 351, in sync
[ERROR]     raise exc.with_traceback(tb)

This first error is logged by hyper_gbm.py:
    def _save_df(self, filepath, df):
        try:
            # with fs.open(filepath, 'wb') as f:
            #     df.to_parquet(f)
            if not isinstance(df, pd.DataFrame):
                fs.mkdirs(filepath, exist_ok=True)
            to_parquet(df, filepath, fs)
        except Exception as e:
            logger.error(e)
            # traceback.print_exc()
            if fs.exists(filepath):
                fs.rm(filepath, recursive=True)

I can see before the invocation of to_parquet, the filepath is already created by fs. Here I'm confused about:

While the default cache_dir is hypergbm_cache, where does the prefix /tmp/workdir/ come from?  The only location related with this /tmp/workdir/ is hypernets\utils\_fsutils.py:
  if type(fs).__name__.lower().find('local') >= 0:
     if fs_root is None or fs_root == '':
         fs_root = os.path.join(tempfile.gettempdir(), 'workdir')

Is the path create by fs the same as the path in function to_parquet where there are also some operations related with the file system.

In jupyter, the error disappears?

Then comes to the mechanism of cache:
The use_cache option cannot control the cache behavior of hypergbm.hyper_gbm.HyperGBMEstimator.predict, hypergbm.hyper_gbm.HyperGBMEstimator.predict_proba  in steps such as hypergbm.experiment.PermutationImportanceSelectionStep or hypergbm.experiment.EnsembleStep, where the HyperGBMEstimator is loaded from training trails and the predict method is invoked with use_cache=None, then in hypergbm.hyper_gbm.HyperGBMEstimator.transform_data:
  def transform_data(self, X, y=None, fit=False, use_cache=None, verbose=0):
     if use_cache is None:
         use_cache = False

results in the action of saving intermediate data.

To avoid this, I think the easiest way may be:
Change use_cache to False when it's None in HyperGBMEstimator's transform_data.
Or, fix the to_parquet.

Expect for the fix.

Upload more details about your dask cluster, pls.


translate-attr-* doesn't work with tooltips

Hi, I was looking for a simple module that could handle tranlations in different languages easily, and found this one.
I have managed to translate the entire site in different languages except tooltips. They are plain html5 tooltips that use the title attribute as the tooltip text. When using the translate-attr-title attribute, it doesn't work, I don't see anything in the title attribute.
You can see the issue here:
http://myweblobby.tk/AngularTube/
Search for a video and click on it. The views, likes and dislikes icons should show a tooltip. The text in the title attribute is there, but it is certainly set after angular bootstrap ui kicks in.
Change to comments tab and scroll down. The scroll to top button should have a tooltip too.
If i use the filter method it only works for the first (default) language, it doesn't change.

@TheHacker66 .. it looks like it is working everything? Where is the problem?
Sidenote: I'm seeing several permanent flashes in text areas in your application. That does not look fine...

It should look like this (the one you see is the browser's tooltip, not the bootstrap one).

That behaviour is indeed wrong. I was using marquee tags and forgot to remove them. Now titles and authors should scroll on hover only.

Ah, missed that one.
Well, that's a limitation by bootstrap which does not look for changes in the attribute (regardless by translate or you). You can try to use a filter explicitly (XYZ). Otherwise you have to wrap or enrich the directive in question (in that case the bootstrap titler).

If i use the filter method it only works for the first (default) language, it doesn't change when i switch languages (you can try yourself, I have reverted changes).
I will look into the bootstrap directive, thanks.

I can confirm that using Angular UI Bootstrap it is possible to do so as @knalli described:

Hover for tooltip

PS: Why are you using both Angular UI Bootstrap and the default Bootstrap + jQuery? I think it's better to use just one (preferably the Angular version)


it can be used with the Table component ?

I would like to know if it can be used with the Table component, I have this requirement now
like this example：

Yes . it can be.  https://github.com/adazzle/react-data-grid/ uses this
You can also take a look at renderTag prop
https://github.com/vkbansal/react-contextmenu/blob/master/docs/api.md#contextmenutrigger-


cli: update paths to be configurable for rootless execution

Before using the default ctrsMapTrePath, check whether the runtime
is being ran rootlessly, and if so set the ctrsMapTreePath to the
rootlessRuntimeDir configured by the libpod rootless library.
Fixes: #1358
Signed-off-by: Gabi Beyer<EMAIL_ADDRESS>

We now have https://github.com/kata-containers/tests/blob/master/Unit-Test-Advice.md as a guide ;)

@gabibeyer I see you opened #1875 to address similar issue, is this PR still relevant?
If not, can we close this one?

@amshinde I was doing multiple separate PRs for the different components: path changes, rootless package, networking, etc. with different commits in each PR. Should I have 1 PR with all of the commits instead?


Fix #205: Add operation to get output paths

This adds outputDirectory to BuildTarget to fix #205

Thanks! I'm not sure this is the ideal way to address #205 rather than a more general "exclude" directory list for compilation artifacts that @olafurpg suggested. Also this has some overlap with classDirectory in javacOptions

I'm not sure this is the ideal way to address #205 rather than a more general "exclude" directory list for compilation artifacts that @olafurpg suggested.

I think you're right. I'll make a change to have a dedicated operation for obtaining "excluded" directories.
I'm not 100% sure about the naming though. "Exclude" says what clients should do with these directories (they should exclude them from indexing) but maybe BSP should instead say what these directories are and it's up to the IDEs to decide what to do with them.

I'm not 100% sure about the naming though. "Exclude" says how clients should handle these directories (they should exclude them from indexing) but maybe BSP should instead say what these directories are and it's up to the IDEs to decide how to handle them.

Also a good point. So maybe just a general list of "outputs" (since it could be multiple). What do you think @olafurpg

How about the name "generatedPaths"? It doesn't have to be a directory, it can also be a file. For example, Bazel auto-generates symbolic links. Otherwise I'm also OK with "outputPaths" or "outputs". I agree this should allow multiple paths.

How about the name "generatedPaths"? It doesn't have to be a directory, it can also be a file. For example, Bazel auto-generates symbolic links. Otherwise I'm also OK with "outputPaths" or "outputs". I agree this should allow multiple paths.

outputs sounds nice and general to me then, and it should be both directories and file paths. But I'm still fuzzy on the semantics - should this be only compile artifacts, or also generated sources? I think we would want the latter to be indexed.

Seems like this PR has grown stale, do you need any help to proceed?

Seems like this PR has grown stale, do you need any help to proceed?

Im sorry for letting this PR grow stale, I don't think I need any help before continuing the work. My plan is to work on this next week.

I added the outputPaths operation, it's ready for review.

Can I have somebody re-run the checks please? Thanks!

@jastice @tpasternak Can we have this released to maven central? I could then finalize my work in https://github.com/JetBrains/intellij-scala/pull/627 thx!

2.1.0-M3 is published :)

Also opened an issue on the BSP spec, as it'd need to be solved there too. https://github.com/build-server-protocol/build-server-protocol/issues/446


[GHP] Include GitHub events linked to references

Example
GH issue: issue
PR that mentions it: pr
Problem
The output of API v3 cannot point to the PR.
One possible alternative would be to check if it is possible to perform this using the API v4.
To note: it is important to verify that the PR that mentions it is merged

This GraphQL query allows to do so:
query {
  repository(owner: "uclouvain", name: "openjpeg") {
    issue(number: 1044) {
      timelineItems(first: 100) {
        nodes {
          ... on ClosedEvent {
            closer {
              ... on PullRequest {
                number
                title
              }
            }
          }
        }
      }
    }
  }
}

It is also possible that the PR is mentioned in the issue as a comment and is not linked to it.
Example: NVD
Issue: 11803
Check here

We might also want to include the commit where the issue was closed.
Example: https://github.com/hapijs/subtext/issues/72
Commit: https://github.com/hapijs/subtext/commit/1e2aed64b7154e1786d866a3b5bdd4f36e9f492d
Query:
query {
  repository(owner: "hapijs", name: "subtext") {
    issue(number: 72) {
      timelineItems(first: 100) {
        nodes {
          ... on ClosedEvent {
            closer {
              ... on Commit {
                commitUrl
              }
            }
          }
        }
      }
    }
  }
}

Returns:
{
  "data": {
    "repository": {
      "issue": {
        "timelineItems": {
          "nodes": [
            {},
            {},
            {},
            {
              "closer": {
                "commitUrl": "https://github.com/hapijs/subtext/commit/1e2aed64b7154e1786d866a3b5bdd4f36e9f492d"
              }
            },
            {},
            {}
          ]
        }
      }
    }
  }
}

Add commits that reference issues:
Example: https://github.com/expressjs/serve-static/issues/26
Query:
query {
  repository(owner: "expressjs", name: "serve-static") {
    issue(number: 26) {
      timelineItems(first: 100) {
        nodes {
          ... on ReferencedEvent {
            commit {
              commitUrl
            }
          }
        }
      }
    }
  }
}

Result:
{
  "data": {
    "repository": {
      "issue": {
        "timelineItems": {
          "nodes": [
            {},
            {},
            {},
            {},
            {},
            {},
            {},
            {},
            {},
            {},
            {},
            {},
            {},
            {},
            {},
            {
              "commit": {
                "commitUrl": "https://github.com/expressjs/serve-static/commit/1bb77964849f82bd9276de30259e9546c6f84e8f"
              }
            },
            {
              "commit": {
                "commitUrl": "https://github.com/expressjs/serve-static/commit/512a4f48e432052998d5165918c50c2cdafade5f"
              }
            },
            {
              "commit": {
                "commitUrl": "https://github.com/hakatashi/kaerema-10/commit/be0135f42aeaafaaea38798a53dec2fbe344f81b"
              }
            },
            {},
            {}
          ]
        }
      }
    }
  }
}

Add commits referenced in the comments of the issue:
Example: https://github.com/uclouvain/openjpeg/issues/1126
Possible ugly solution is to retrieve all comments and checks for links to commits and/or prs into the content of each:
query {
  repository(owner: "uclouvain", name: "openjpeg") {
    issue(number: 1126) {
      timelineItems(first: 100) {
        nodes {
          ... on IssueComment {
            author {
              login
            }
            body
          }
        }
      }
    }
  }
}


camellia-redis-proxy support CuckooFilter commands

Module: camellia-redis-proxy
Content: support CuckooFilter commands

CF.ADD
CF.ADDNX
CF.COUNT
CF.DEL
CF.EXISTS
CF.INFO
CF.INSERT
CF.INSERTNX
CF.LOADCHUNK
CF.MEXISTS
CF.SCANDUMP


AI4Finance-LLC / FinRL on pycharm Run Test.py No module named 'finrl.config'

ModuleNotFoundError: No module named 'finrl.config'
from finrl.config import config
Traceback (most recent call last):
File "F:/Project/AI4FinRL/Lib/site-packages/finrl/neo_finrl/data_processors/processor_yahoofinance.py", line 7, in
from finrl.config import config
ModuleNotFoundError: No module named 'finrl.config'

Incorrect installation?

It is
from finrl.apps import config

It is
from finrl.apps import config

Can't import
from finrl.apps import config
pycharm Report an error

already added from finrl.apps import config
pycharm Report an error

The config file is in finrl.apps only, probably follow one of the tutorial and install properly

Recently, we made changes in the file structure.  Per your request, we updated a new version to pypi.
Could you like to try again?

Have you tried Mark Directory as Sources Root on the FinRL-Library?


Add Windows support

Related: https://github.com/netlify/netlify-plugin-nextjs/issues/21
CI tests should be run on Windows as well, to ensure this plugin works for Netlify CLI users who run netlify build.
Many of our CLI users are on Windows (example: https://github.com/netlify/next-on-netlify/issues/56#issuecomment-709670418).

Fixed by https://github.com/netlify/next-on-netlify/pull/101


Improve code snippet for responsive videos and embeds

The code snippet suggested in this page to make videos and embeds responsive can be improved using a 16:9 aspect ratio by default in order to avoid blank lines in most of the videos. So the following CSS rule:
.video-container {
    position: relative;
    padding-bottom: 56.25%;
    padding-top: 30px;
    height: 0;
    overflow: hidden;
}

should be using padding-top: 0;

#4030


Video Tutorial

A while back I made a YouTube video on how to install. I didn't bother doing a pull request to add it to the README.me because I doubt it'd be merged. Here's the video though: https://youtu.be/engH5lQky6U

Thanks! You could post on the discord as well.

Thanks! You could post on the discord as well.

What discord? There's no link anywhere.


Lap time format issue

The result_lap_data() methods lap time data is formatted in a way that it is not usable. Is there any way to fix this?

How do you mean not usable? It is the number provided directly by iRacing, multiply it by 10000 to get the number of seconds.

I did not try that thank you for the assistance. Much appreciated.

No worries @Jamesburgess1312, enjoy!


Is Android NDK r25c support?

Accord to README,  rules in this repo currently work with Android NDK version 25b , but I can't find download url of NDK 25b.

However, NDK r25c is accessible. Is r25c supported? Or is there anything I should pay attention to while using r25c?

Providing download url of NDK 25b is also thankful.

Thanks!

It seems that the b -> c type updates are generally pretty small, so I think r25c should work just fine as well. Please file any issues you find if not.
Looking at the URLs for the r25c downloads like this one:
https://dl.google.com/android/repository/android-ndk-r25c-darwin.dmg
Replacing c with b seems to work still. It seems like the recommendation from the NDK docs is to upgrade though, so they must have pulled those URLs from the docs

Thanks a lot.

Any time an NDK minor version upgrade breaks compatibility with a build system, that's more likely an NDK bug.


agedu: 20180522.5b12791 -> 20180918.80c7beb

Motivation for this change
update
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build agedu

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: agedu
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: agedu
Partial log (click to expand)
make[1]: Leaving directory '/build/agedu-80c7beb'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w9z2fhb18hbjnjnrhkjjy9sflscdfm2a-agedu-20180918.80c7beb
shrinking /nix/store/w9z2fhb18hbjnjnrhkjjy9sflscdfm2a-agedu-20180918.80c7beb/bin/agedu
gzipping man pages under /nix/store/w9z2fhb18hbjnjnrhkjjy9sflscdfm2a-agedu-20180918.80c7beb/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w9z2fhb18hbjnjnrhkjjy9sflscdfm2a-agedu-20180918.80c7beb/bin
patching script interpreter paths in /nix/store/w9z2fhb18hbjnjnrhkjjy9sflscdfm2a-agedu-20180918.80c7beb
checking for references to /build in /nix/store/w9z2fhb18hbjnjnrhkjjy9sflscdfm2a-agedu-20180918.80c7beb...
/nix/store/w9z2fhb18hbjnjnrhkjjy9sflscdfm2a-agedu-20180918.80c7beb

Success on aarch64-linux (full log)
Attempted: agedu
Partial log (click to expand)
make[1]: Leaving directory '/build/agedu-80c7beb'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r4nmcsaxxwv0fhvncx6yzh28fnsjzyz0-agedu-20180918.80c7beb
shrinking /nix/store/r4nmcsaxxwv0fhvncx6yzh28fnsjzyz0-agedu-20180918.80c7beb/bin/agedu
gzipping man pages under /nix/store/r4nmcsaxxwv0fhvncx6yzh28fnsjzyz0-agedu-20180918.80c7beb/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r4nmcsaxxwv0fhvncx6yzh28fnsjzyz0-agedu-20180918.80c7beb/bin
patching script interpreter paths in /nix/store/r4nmcsaxxwv0fhvncx6yzh28fnsjzyz0-agedu-20180918.80c7beb
checking for references to /build in /nix/store/r4nmcsaxxwv0fhvncx6yzh28fnsjzyz0-agedu-20180918.80c7beb...
/nix/store/r4nmcsaxxwv0fhvncx6yzh28fnsjzyz0-agedu-20180918.80c7beb


default_duration_time from autoconfig doesnt get respected in meeting editor

the default_duration_time from autoconfig doesnt get respected in meeting editor dropdown, im guessing it should? at least that would make since to me. the default dropdown value is a static pulled from the server admin strings. I feel like somehow we should pull from $localized_strings['default_duration_time']. im using latest version 2.12.2
maybe thats done here
https://github.com/bmlt-enabled/BMLT-Root-Server/blob/a9da7caeb9ad31494d0e4ca4f39aae27075669bf/main_server/local_server/server_admin/c_comdef_admin_main_console.class.php#L349
this is the static its currently getting pulled from
https://github.com/bmlt-enabled/BMLT-Root-Server/blob/a9da7caeb9ad31494d0e4ca4f39aae27075669bf/main_server/local_server/server_admin/lang/en/server_admin_strings.inc.php#L139

I think you'd want to fix this code in the dom template that gets printed here:
https://github.com/bmlt-enabled/BMLT-Root-Server/blob/a9da7caeb9ad31494d0e4ca4f39aae27075669bf/main_server/local_server/server_admin/c_comdef_admin_main_console.class.php#L1659-L1679

Basically you'd just add a "selected" attribute to the hour and minute options if they match the default.
<option value="blar" selected>asdf</option>

fixed


Include the option for searching Facebook

https://spring.io/guides/gs/accessing-facebook/

Other options built-in http://projects.spring.io/spring-social/


Unicode issues with CandidateModel

The chemnder (chemical names) training set is now causing issues in the CandidateModel class, throwing:
Traceback (most recent call last):
  File "dd-biolib/examples/chemical_learning_demo.py", line 14, in <module>
    model = CandidateModel(candidates)
  File "dd-biolib/ddlite/ddlite.py", line 424, in __init__
    raise ValueError("Could not automatically extract features")
ValueError: Could not automatically extract features

due to self.feats = self.C.extract_features() throwing a UnicodeException 'ascii' codec can't encode character u'\u03b1' in position 0: ordinal not in range(128)
All input text and dictionaries are parsed as utf-8. Is this possibly due to string features in treedlib casting terms out of utf-8?

Can you send me a file that breaks this? Did this not happen previously?

I sent the file -- it's the same offender as before (the ChemNDER training dataset).


Remove EnableUpgradeForSelfHostedStarter config

Reverts some changes in https://github.com/mattermost/mattermost-webapp/pull/10764
Summary
This PR makes available the pricing modal and upgrade button to self managed workspaces
Ticket Link
MM-45684
MM-45685
Related Pull Requests
https://github.com/mattermost/mattermost-server/pull/20653
Screenshots

Release Note
NONE

@marianunez this doesn't include the idea of adding some form of tooltip letting admins know that it's only visible to them right?

@marianunez this doesn't include the idea of adding some form of tooltip letting admins know that it's only visible to them right?

Correct, what would you like it to say in the tooltip?
@AGMETEOR heads up we want to include a new tooltip for the Upgrade button so that it says that this is only visible to admins.

"Only visible to admins"
@marianunez @AGMETEOR

@AGMETEOR update: "Only visible to system admins"

@AGMETEOR @marianunez so I had the chance to speak to folks from the community about the "Upgrade" button and here's our best path forward after thinking through the experience:

the "Upgrade" button should only be visible to system admins
only in Enterprise edition (not in Teams Edition)
it's important to communicate that only system admins see this and not everyone. The tooltip is essential here.

@AGMETEOR @marianunez so I had the chance to speak to folks from the community about the "Upgrade" button and here's our best path forward after thinking through the experience:

the "Upgrade" button should only be visible to system admins
only in Enterprise edition (not in Teams Edition)
it's important to communicate that only system admins see this and not everyone. The tooltip is essential here.

@johndavidlugtu do you mean enterprise trial?


Update database.rst

I suppose this is a funny phrase, but "you" is referring to "you and your project", not the size of the database itself.


refactor network commands

move core of network commands from pkg/adapter to pkg/network to assist
with api development and remote podman commands.
Signed-off-by: baude<EMAIL_ADDRESS>

this is blocking apiv2 work.  please review and merge

@baude I mean, it is Sunday of shutdown :smile:

Ack. LGTM then.
On Mon, Dec 30, 2019, 12:23 Brent Baude<EMAIL_ADDRESS>wrote:

@baude commented on this pull request.
In pkg/network/network.go
https://github.com/containers/libpod/pull/4757#discussion_r362046174:

return errors.Wrapf(err, "failed to get live network names")

}
if util.StringInSlice(interfaceName, liveNetworkNames) {

if err := RemoveInterface(interfaceName); err != nil {

	return errors.Wrapf(err, "failed to delete the network interface %q", interfaceName)

}

}
// Remove the configuration file
if err := os.Remove(cniPath); err != nil {

return errors.Wrapf(err, "failed to remove network configuration file %q", cniPath)

}
return nil
+}

+// InspectNetwork reads a CNI config and returns its configuration
+func InspectNetwork(name string) (map[string]interface{}, error) {
It is really too loosely defined to do much more. I don't like it either.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/4757?email_source=notifications&email_token=AB3AOCAWULFCB745YMN5XRTQ3IU77A5CNFSM4KARK662YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQMPD5Q#discussion_r362046174,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3AOCB7OOEB2N5WS4OHV2TQ3IU77ANCNFSM4KARK66Q
.

/lgtm


TINYINT (8-bit integer) datatype is not supported

Context and Description
Trying to decode a TINYINT datatype will throw an error, whether you try to decode to Int or Int8. This is frustrating as I believe it's common practice to use TINYINT to represent boolean values.
Steps to Reproduce

Use the TINYINT datatype in a MySQL table
Attempt to use the corresponding Kuery model, with the type of the field set to either Int or Int8
Either one will fail

Solution
After inspecting DatabaseDecoder it seems this is caused by a missing line in the Int decoder:
/// Special case for integer, no integer type in database
public func decode(_ type: Int.Type, forKey key: Key) throws -> Int {
    let unwrappedValue = try unwrapValue(key, checkValueExitence(key))
    let returnValue: Int
    switch(unwrappedValue) {
    case let v as Int16: returnValue = Int(v)
    case let v as Int32: returnValue = Int(v)
    case let v as Int64: returnValue = Int(v)
    default:
    throw DecodingError.typeMismatch(type, DecodingError.Context(
        codingPath: [key],
        debugDescription: "Could not convert " + String(describing: unwrappedValue)
    ))
    }
    return returnValue
}

If the switch also included:
case let v as Int8: returnValue = Int(v)

then TINYINT would be correctly decoded. I confirmed this by changing my local copy of the file and testing it.
(P.S. It would also be really handy if there was a way to directly decode TINYINT to a boolean without implementing a custom decoder)

Don't forget the following:
public func decodeIfPresent(_ type: Int.Type, forKey key: Key) throws -> Int? {
    let value = try checkValueExitence(key)
    if value == nil { return nil}
    let returnValue: Int
    switch(value){
    case let v as Int8:  returnValue = Int(v)
    case let v as Int16: returnValue = Int(v)
    case let v as Int32: returnValue = Int(v)
    case let v as Int64: returnValue = Int(v)
    default:
        throw DecodingError.typeMismatch(type, DecodingError.Context(
            codingPath: [key],
            debugDescription: "Could not convert " + String(describing: value)
        ))
    }
    return returnValue
}

And additionally, in SwiftKuery, it is missing this:
extension Int8: SQLDataType {
    /// Return database specific representation of the int8 type using `QueryBuilder`.
    ///
    /// - Parameter queryBuilder: The QueryBuilder to use.
    /// - Returns: A String representation of the type.
    public static func create(queryBuilder: QueryBuilder) -> String {
        return "tinyint"
    }
}

Which would then allow using the following:
public struct RandomNameHere : Codable {
    public var id: Int
    public var randomColumnNameHere: Int8
}

extension RandomNameHere : Model {

}

@spykr, @xeokeri, Unfortunately we cannot add support for the TINYINT type. While MySQL and SQLite both support 1 byte integers PostgreSQL does not and as such we cannot add support in an abstract fashion for the type.
I considered whether we could do some special handling for PostgreSQL and store TINYINT values as a char but this leads to other issue such as someone storing an actual char in the table directly. Equally, storing as a larger integer type and then casting down has potential problems with value wrapping if a value greater than Int8's maximum is directly inserted into the table.


Change the command used to install pip on AppVeyor to avoid installation errors

Fixes #1107
This pull request:

[x] Has a title summarizes what is changing
[x] Includes a news entry file
[x] Has unit tests & code coverage is not adversely affected (within reason)
[x] Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
[x] Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

FYI you should always just use python -m pip and not the pip command. It not only is xplat but it also disambiguates which Python interpreter you're about to affect.


[Feature Request] <Depth-First Search (DFS) Algo>

🚀 Feature Request
Is your feature request related to a problem? Please describe.
The existing algorithms available in the repository do not include Depth First Search (DFS), a fundamental graph traversal technique. Without DFS, users may face difficulties in implementing algorithms that rely on recursive exploration of nodes, such as solving mazes, analyzing networks, or finding connected components.
Describe the solution you'd like
I propose to add the DFS algorithm implemented in Java to the repository. This will help users perform recursive graph traversals, allowing them to explore all possible paths in a graph in-depth before backtracking.
Describe alternatives you've considered
I considered other traversal algorithms like Breadth First Search (BFS), which is already implemented. However, DFS offers a different approach that is more efficient in some use cases, such as navigating tree structures, detecting cycles, and implementing backtracking algorithms.
Additional context
The implementation will include test cases for both directed and undirected graphs. I can also provide an example of how DFS can be used to solve maze problems or detect cycles in a graph.

Would you like to work on this feature?

[x] Yes
[ ] No

@ajay-dhangar please assign me this issue under hacktoberfest and gssoc extd.


Cannot assign VLAN to VLAN Group (UI)

Environment

Nautobot version (Docker tag too if applicable): 2.0.0rc1
Python version: 3.10
Database platform, version: postgres13
Middleware(s): None

Steps to Reproduce

Create a VLAN Group
Click the 4094 vlans available to create a VLAN
Create VLAN

Expected Behavior
Created VLAN shows up in the VLAN Group

Observed Behavior
VLAN is created but not associated to the VLAN Group. Additionally, you cannot edit an existing VLAN and add it to the group.

Looks to have been broken by #3094. That renamed the form field from VLANForm.group to VLANForm.vlan_group but didn't update templates/ipam/vlan_edit.html accordingly. Fixing this specific issue should be a one-line fix to the template.


NMDC Capture of Alternate and Related Identifiers

NMDC wants to provide and capture external / alternate and related identifiers to provide to users.
Alternate identifiers = an identifier for the EXACT same thing
Related identifiers = an identifier for something similar, but not identical
Some identifiers get specific slots, some do not. This guidance has been vague and unclear
Below is a collection of issues that have been made for working through all these identifiers.

[ ] #1538
[x] #1560
Complete in berkeley schema
[ ] #1470
[ ] #1472
[ ]  #1287
[ ] #500
[ ] #903
[ ] https://github.com/microbiomedata/nmdc-server/issues/932
[ ] #1678
[ ] #1329
PR submitted
[ ] https://github.com/microbiomedata/issues/issues/222
[ ] https://github.com/microbiomedata/issues/issues/564

Need to identify what NMDC slot matches to what external/ alternate identifiers.
Study:emsl_project_identifiers = 5 digit EMSL project ID

some work will be done in the berkeley fork in a new branch. That will be a long running branch that we will NOT merge back into the berkeley fork.

https://github.com/microbiomedata/berkeley-schema-fy24/tree/nmdc-schema-1752-alternative-identifiers


Change wrapping properties to stored properties using willSet/didSet

Hey Alex! This looks great, thank you!


Tapo T530 Bulb stopped working in Home Assistant Integ:v2.6.1 HA:2023.8.4

My Tapo L530 bulb was working in Home Assistant till yesterday when it shows as unavailable. The bulb still works in the Tapo app.
I've deleted the device from HA and tried to add it back in but it will not connect - error log is below.
I'm using version 2.6.1 of the Tapo integration with HA version 2023.8.4
The Tapo L530 bulb is running firmware 1.1.0 Build 230721 Rel.224802
I've tried changing my Tapo account password, I've also deleted the bulb from within Tapo and re-added it, it has a static IP on my network.  My acount ID does not contain a capital letter.
Logs here:
Traceback (most recent call last):
  File "/config/custom_components/tapo/config_flow.py", line 182, in _try_setup_api
    .get_or_raise()
     ^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/plugp100/common/functional/tri.py", line 159, in get_or_raise
    raise self.value
plugp100.responses.tapo_exception.TapoException: Returned unknown error_code: 1003  msg: No message

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/config/custom_components/tapo/config_flow.py", line 87, in async_step_user
    api = await self._try_setup_api(user_input)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/tapo/config_flow.py", line 185, in _try_setup_api
    self._raise_from_tapo_exception(error)
  File "/config/custom_components/tapo/config_flow.py", line 194, in _raise_from_tapo_exception
    raise CannotConnect from exception
custom_components.tapo.errors.CannotConnect

HACS says I am using version v1.6.1, but I have the same issue with an L530. It worked fine 2 days ago. Might be unrelated to the version, or HACS shows the wrong version for me.

I have the same issue. All three L530 bulbs are unavailable in HA but working in the Tapo app and through google home. If I hover over the device in the "Needs Attention" box I see the message in the screenshot.

to me out of 3 lamps only 1 does not work and gives me the same message as yours

I have this exact issue. I thought it was just me.
The error I receive when trying to re-add is:
 This error originated from a custom integration.

 Logger: custom_components.tapo.config_flow
 Source: custom_components/tapo/config_flow.py:87
 Integration: TP-Link Tapo (documentation, issues)
 First occurred: 24 August 2023 at 22:48:16 (9 occurrences)
 Last logged: 10:30:20

 Tapo exception 1003

It's worth noting that this only affects my L530E bulbs, and not any of the P100 smart plugs I have. All lights dropped off the network at the same time and rolling back to any of my backups hasn't had any effect.
The bulbs still show up within the Tapo app, although cannot be added to the Home Assistant integration.

I am also getting this error after updating to the latest version

Similar problems here but I think I can add a little more detail:
6x L530 v2 Firmware 224802 all offline in HA but available in Tapo app
3x L510 v2 Firmware 224802 all offline in HA but available in Tapo app
but:
5x L510 v1 Firmware 1.2.4 working as expected in both HA & Tapo app
plus an L900 & and L630 also working fine.
So it looks like the L510 & L530 v2 hardware only (& latest 224802 firmware)
These were all working normally until the night before last. No firmware updates were done on that night.
It was just after I'd updated to v2.6 of HA Tapo integration but BEFORE I'd updated to version 2.6.1
Currently wondering if there is something in firmware 224802 that is stopping HA Tapo v2.6.* re-authorising the bulbs.
Anyway thought it might be useful to share this info.

I'm having the same problem.

Linking to the library issue where the error comes from: https://github.com/petretiandrea/plugp100/issues/116

Me too - very annoying.

Duplicate of #482

Fixed!
Well done @petretiandrea !
Thank you.


bad-exit-annotation (PYI036) triggers on typing.overload definitions

Keywords searched in the issue tracker: PYI036, overload
Running ruff check --select PYI036 --isolated using Ruff version 0.4.0 on the file
import typing
from types import TracebackType

class Foo:
    def __enter__(self) -> typing.Self:
        return self

    @typing.overload
    def __exit__(self, exc_type: None, exc_val: None, exc_tb: None) -> None: ...

    @typing.overload
    def __exit__(
        self,
        exc_type: type[BaseException],
        exc_val: BaseException,
        exc_tb: TracebackType,
    ) -> None: ...

    def __exit__(
        self,
        exc_type: type[BaseException] | None,
        exc_val: BaseException | None,
        exc_tb: TracebackType | None,
    ) -> None:
        pass

produces six PYI036 errors (three for each overload definition). The expected behaviour is that no PYI036 errors are raised, as these are overloads that describe legal calls rather than the complete implementation. This approach was recommended on this blog post.

@AlexWaygood - do you mind taking this one?

Yeah, good call — I think we should just skip any functions decorated with @overload for this check. Thanks for the report!

On second thought, we can provide some validation for overloaded functions. Slightly more fiddly, but definitely doable.

Thanks Alex!

Some "related off-topic" from me, since I recently went through a similar thing.
There should be no need to write an overload if in either case we return None.
That's the thing for a PEP to propose the ability of unpacking unions of same-size tuples:
from __future__ import annotations

from typing import TYPE_CHECKING

if TYPE_CHECKING:
    from _typeshed import OptExcInfo  # tuple[None, None, None] | tuple[type[BaseException], BaseException, TracebackType]
    from typing_extensions import Unpack

class Foo:
    def __exit__(self, *args: Unpack[OptExcInfo]) -> None:
        pass

What Ruff might or might not want to do is allow unpacking _typeshed.ExcInfo in the annotations of the __exit__ signature, not require either object or full signature. But that would only make sense if we always expect an error to occur 🤷♀


[Switch] Missing disabled prop

The web component supports disabled, but disabled is not a prop on the react version of the Switch. Aria disabled is a prop, but it does not seem to work.

Does https://github.com/equinor/fusion-react-components/commit/1efec304edee3a0bd4a72cd4f589e38f93995558 fix this one @odinr?


Demo is broken

The demo at http://voicechatapi.com/ dosen't work.
When you go to the site and click "create your private conference room" it sends you to a page with a link and a button to "join your conference".
Neither does using the link nor the the button work. It simply displays a panel mentioning to click arrow when you see the permission on the browser, but the permission doesn't actually show up.
When looking at the console the following errors are shown:

Thanks for the notice! It should be working now. Let me know if you're having any more problems!


Support for Data bags in ChefSpec

Hi,
I'm trying to test a cookbook that uses a DataBag for certain variables however everytime I run rspec I get the following error:
[2012-09-25T15:59:05+01:00] ERROR: Failed to load data bag item: "ntp_data" "configs"
F[2012-09-25T15:59:05+01:00] ERROR: Failed to load data bag item: "ntp_data" "configs"
F

Failures:

  1) ntp::default should install ntp
     Failure/Error: let (:chef_run) { ChefSpec::ChefRunner.new.converge 'ntp::default'}
     Chef::Exceptions::InvalidDataBagPath:
       Data bag path '/var/chef/data_bags' is invalid
     # ./recipes/default.rb:16:in `from_file'
     # ./spec/default_spec.rb:4:in `block (2 levels) in <top (required)>'
     # ./spec/default_spec.rb:6:in `block (2 levels) in <top (required)>'

  2) ntp::default should configure ntp
     Failure/Error: let (:chef_run) { ChefSpec::ChefRunner.new.converge 'ntp::default'}
     Chef::Exceptions::InvalidDataBagPath:
       Data bag path '/var/chef/data_bags' is invalid
     # ./recipes/default.rb:16:in `from_file'
     # ./spec/default_spec.rb:4:in `block (2 levels) in <top (required)>'
     # ./spec/default_spec.rb:9:in `block (2 levels) in <top (required)>'

Finished in 0.00893 seconds
2 examples, 2 failures

Failed examples:

rspec ./spec/default_spec.rb:5 # ntp::default should install ntp
rspec ./spec/default_spec.rb:8 # ntp::default should configure ntp

My Spec looks as follows:
require 'chefspec'

describe 'ntp::default' do
  let (:chef_run) { ChefSpec::ChefRunner.new.converge 'ntp::default'}
  it 'should install ntp' do
    chef_run.should install_package "ntp"
  end
  it 'should configure ntp' do
    chef_run.should create_file "/etc/ntp.conf"
  end
end

and the recipe looks like this:
## install and configure NTP
package "ntp" do
  action :install
end

## we get our NTP configuration from a data bag, so let's load it here
ntp_data = data_bag_item("ntp_data","configs")

template "/etc/ntp.conf" do
  source "ntp.conf.erb"
  owner  "root"
  group  "root"
  mode   0644
  variables(
  :ntp_servers => ntp_data['servers']
  )
end

I realise that there are other NTP cookbooks around, however I'd like to use this simple example to learn how to use Data Bags in ChefSpec.
Thanks,
Matt

before do
cookbook_root = File.expand_path('../../',  FILE)
Chef::Config[:data_bag_path] = File.join(cookbook_root, '.data_bags')
end

I can't get this to work, it doesn't upload the cookbooks from the folder using ServerRunner
Any ideas?

Hi,
I am getting the same error as
Compiling Cookbooks...
[2018-02-15T09:27:21+00:00] ERROR: Failed to load data bag item: "jira" "jira"
[2018-02-15T09:27:21+00:00] ERROR: Failed to load data bag item: "jira" "jira"
when trying to test cookbook with test kitchen.
I am using chef-zer and docker provider.
please help me with the samw.


ARM64+linux build options

What changes does this PR introduce?
(Bug fix, feature, docs update, ...)
allows to use MITgcm within e.g. a docker container with gfortran, mpi, netcdf on a mac
What is the current behaviour?
(You can also link to an open issue here)
fails to build
What is the new behaviour
(if this is a feature change)?
See https://github.com/MITgcm/MITgcm/issues/847
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information:
happy to rename the new file if preferred
Suggested addition to tag-index
(To avoid unnecessary merge conflicts, please don't update tag-index. One of the admins will do that when merging your pull request.)

is https://github.com/MITgcm/MITgcm/pull/849/commits/105ccd9825599a1b631c350db48dd721e0d54a6f what you meant in https://github.com/MITgcm/MITgcm/issues/847#issuecomment-2189671367 @jahn ?

Yes, precisely.

I have no chance of testing this. Just some thoughts:

You should be able to -- download docker, launch it, and run this at the command line
docker run -p 8888:8888 gaelforget/ecco-docker
Once you are in the Jupyter instance then you should be able to proceed as per usual. The container will have gfortran, mpi, and netcdf libraries as explained in the README.md

I do not have any arm64 hardware.

I do not have any arm64 hardware.

understood. I meant it for Martin

Yes, would be good to mention that this was tested "in an Ubuntu docker container" on a Macbook, and maybe even state at the top that the optfile is for linux VMs or containers on ARM64 hardware. Of course, somebody might run linux natively on a Macbook and that should work too.
I cannot test this either, but otherwise it looks good to me.

done. thanks for suggestion

I still cannot reproduce the problem that lead to this PR:
After starting the desktop App of docker, I did this:
docker run -p 8888:8888 gaelforget/ecco-docker
(which lead to Gigabytes of downloads.

Y Y Y Y 22 16 16 16>16<16 16 16 16 16 16 16 16 16 16 16 16  .  .  .  .  .  .  .  . pass  vermix
Y Y Y Y 22 14 14 16>16<16 14 16 14 22 22 22 22 22 22 22 22  .  .  .  .  .  .  .  . pass  vermix.dd
Y Y Y Y 22 16 16 16>16<16 16 16 16 16 16 16 16 16 16 16 16  .  .  .  .  .  .  .  . pass  vermix.ggl90
Y Y Y Y 22 16 16 16>16<16 16 16 16 16 16 16 16 16 16 16 16  .  .  .  .  .  .  .  . pass  vermix.gglLC
Y Y Y Y 22 16 13 14>16<16 16 16  1 10 10 14 11 11  8 13 11  .  .  .  .  .  .  .  . pass  vermix.my82
Y Y Y Y 22 16 16 14>16<16 16 16  1 13 16 16 16 16 14 16 16  .  .  .  .  .  .  .  . pass  vermix.opps
Y Y Y Y 22 16 13 14>16<16 16 16  1 10 10 14 10 10  9 14 11  .  .  .  .  .  .  .  . pass  vermix.pp81
Start time:  Tue Jul 16 08:57:08 AM UTC 2024
End time:    Tue Jul 16 09:05:48 AM UTC 2024
======== End of testreport execution ========
(base) jovyan@21e7e0aaa3f2:~/MITgcm/verification$ git branch
* master
(base) jovyan@21e7e0aaa3f2:~/MITgcm/verification$

testreport automatically uses ../../../tools/build_options/linux_amd64_gfortran (at least that's what it tells me), and the makefile does contain the flag -mcmodel=medium
(base) jovyan@21e7e0aaa3f2:~/MITgcm/verification/vermix/build$ gfortran -v
Using built-in specs.
COLLECT_GCC=gfortran
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/11/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 11.4.0-1ubuntu1~22.04' --with-bugurl=file:///usr/share/doc/gcc-11/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-11 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-11-XeT9lY/gcc-11-11.4.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-11-XeT9lY/gcc-11-11.4.0/debian/tmp-gcn/usr --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu --with-build-config=bootstrap-lto-lean --enable-link-serialization=2
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)

@mjlosch I followed your instructions on a M2 mac mini (i.e. downloaded docker, entered the command to download, got a terminal in jupyter, downloaded MITgcm and ran testreport. Other than 2 out of 3 instructed ways of getting jupyter up not working,  my MITgcm results were identical to yours above -- thus also questioning the need for the PR.
That being said, your test uses netcdf but not mpi. In the container when I tried that, it complained about pkg-config not found and MPI_HOME not set, (without looking deeper) not sure if this is what the PR addresses.

thanks. I don't know exactly, but

pkg-config should be installed within environment, that the docker emulates(?), nothing that this PR can address;
MPI_HOME is something that we need to set, if it is not automatically set, which again may depend on the docker-env;

@gaelforget so @mjlosch and I both tested your docker image with MITgcm and did not have any issues -- thus calling into question the need for this PR. We were wondering however -- we both tested using M1/M2 macs, might there be a difference with M3+ macs (googling, I did not immediately find anything helpful). Maybe the mcmodel setting issue needed here?
I'm assuming my MPI question was a red herring; I wanted to test a mpi run in the docker image but it required a MPI_HOME setting (and I didn't try to find that path); but if there something critical in your opt file related to mpi please let us know.
On a final note: googling did suggest that performance will be degraded running MITgcm in docker rather than "natively". I didn't check this however. I'm presuming you are mainly providing this to be able to use other bits in ECCO/docker rather than any serious computation.

Sorry for the lag in response. Circling back to this now...

Can you try with this instead?
git clone https://github.com/gaelforget/ECCO-Docker
docker build -t ecco-docker-1 ECCO-Docker

The image you currently get from DockerHub.com (with docker run -p 8888:8888 gaelforget/ecco-docker) was an older I had built on my old laptop and pushed to DockerHub.
The sequence above will build a new, updated, one locally on your arm64 laptop. This is typically what I do before pushing to DockerHub.com

To reproduce the issue :

docker run -p 8888:8888 ecco-docker-1
execute the following sequence in a terminal window

git clone https://github.com/MITgcm/MITgcm
cd MITgcm/verification
./testreport -t advect_xy

On my laptop  this fails

git fetch origin pull/849/head:arm64_linux_build_options
git switch arm64_linux_build_options
./testreport -t advect_xy

On my laptop  this succeeds
Do you get the same result?

I still cannot reproduce the problem that lead to this PR: After starting the desktop App of docker (on my ARM M1 Apple Book), I did this: docker run -p 8888:8888 gaelforget/ecco-docker (which lead to Gigabytes of downloads.

Y Y Y Y 22 16 16 16>16<16 16 16 16 16 16 16 16 16 16 16 16  .  .  .  .  .  .  .  . pass  vermix
Y Y Y Y 22 14 14 16>16<16 14 16 14 22 22 22 22 22 22 22 22  .  .  .  .  .  .  .  . pass  vermix.dd
Y Y Y Y 22 16 16 16>16<16 16 16 16 16 16 16 16 16 16 16 16  .  .  .  .  .  .  .  . pass  vermix.ggl90
Y Y Y Y 22 16 16 16>16<16 16 16 16 16 16 16 16 16 16 16 16  .  .  .  .  .  .  .  . pass  vermix.gglLC
Y Y Y Y 22 16 13 14>16<16 16 16  1 10 10 14 11 11  8 13 11  .  .  .  .  .  .  .  . pass  vermix.my82
Y Y Y Y 22 16 16 14>16<16 16 16  1 13 16 16 16 16 14 16 16  .  .  .  .  .  .  .  . pass  vermix.opps
Y Y Y Y 22 16 13 14>16<16 16 16  1 10 10 14 10 10  9 14 11  .  .  .  .  .  .  .  . pass  vermix.pp81
Start time:  Tue Jul 16 08:57:08 AM UTC 2024
End time:    Tue Jul 16 09:05:48 AM UTC 2024
======== End of testreport execution ========
(base) jovyan@21e7e0aaa3f2:~/MITgcm/verification$ git branch
* master
(base) jovyan@21e7e0aaa3f2:~/MITgcm/verification$

testreport automatically uses ../../../tools/build_options/linux_amd64_gfortran (at least that's what it tells me), and the makefile does contain the flag -mcmodel=medium
(base) jovyan@21e7e0aaa3f2:~/MITgcm/verification/vermix/build$ gfortran -v
Using built-in specs.
COLLECT_GCC=gfortran
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/11/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 11.4.0-1ubuntu1~22.04' --with-bugurl=file:///usr/share/doc/gcc-11/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-11 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-11-XeT9lY/gcc-11-11.4.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-11-XeT9lY/gcc-11-11.4.0/debian/tmp-gcn/usr --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu --with-build-config=bootstrap-lto-lean --enable-link-serialization=2
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)

(base) jovyan@72d7842edbd8:~$ uname -a
Linux 72d7842edbd8 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Sorry, I gave you the wrong directions (docker run -p 8888:8888 gaelforget/ecco-docker does not suffice to reproduce the issue it turns out)
See https://github.com/MITgcm/MITgcm/pull/849#issuecomment-2333068161

@gaelforget so @mjlosch and I both tested your docker image with MITgcm and did not have any issues -- thus calling into question the need for this PR. We were wondering however -- we both tested using M1/M2 macs, might there be a difference with M3+ macs (googling, I did not immediately find anything helpful). Maybe the mcmodel setting issue needed here?
I'm assuming my MPI question was a red herring; I wanted to test a mpi run in the docker image but it required a MPI_HOME setting (and I didn't try to find that path); but if there something critical in your opt file related to mpi please let us know.

Sorry, I gave you the wrong directions (docker run -p 8888:8888 gaelforget/ecco-docker does not suffice to reproduce the issue it turns out)
See https://github.com/MITgcm/MITgcm/pull/849#issuecomment-2333068161

On a final note: googling did suggest that performance will be degraded running MITgcm in docker rather than "natively". I didn't check this however. I'm presuming you are mainly providing this to be able to use other bits in ECCO/docker rather than any serious computation.

Not sure how much overhead there is with MITgcm, but I have used this to run ECCO4 in cloud instance for example.

I am guessing you experts already know that but, just in case:

one way to find mpi.h on *buntu platforms:
sudo apt-get install apt-file
sudo apt-file update
sudo apt-file list libopenmpi-dev | grep mpi.h

on apple silicon with homebrew MPi installation:
export MPI_INC_DIR=/opt/homebrew/include

on apple intel with homebrew MPi installation:
export MPI_INC_DIR=/usr/local/include

On Sep 5, 2024, at 7:42 PM, Gael Forget @.***> wrote:
I'm assuming my MPI question was a red herring; I wanted to test a mpi run in the docker image but it required a MPI_HOME setting (and I didn't try to find that path); but if there something critical in your opt file related to mpi please let us know.

I was supposed to report the output of uname within the docker environment on my M1-MacBook. After
docker run -p 8888:8888 ecco-docker-1

I open a Jupyter Lab in my browser, open a terminal and type:
(base) jovyan@91e26c35c889:~$ uname -a
Linux 91e26c35c889 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
(base) jovyan@91e26c35c889:~$ uname -m
aarch64
(base) jovyan@91e26c35c889:~$ uname
Linux

A quick summary (after some discussion this am): This seems on a good track (new optfile), @jrscott might add some comments to the issue #847 ; And as part of issue #855, I will try to fix/update suggest_optfile_names script as it could be useful to use (but this will go in an other PR).

ready to merge then?

@jm-c see my comment in #847 since we have not agreed how to address my objection to the name I prefer to wait until we discuss at next MITgcm dev meeting.

@jrscott I don't see the need to wait 2 weeks to merge this PR, since:

it's in good shape, it correctly addresses the problems described in this issue (thanks @jahn for the efforts to narrow it down), and @mjlosh worked hard to reproduce the problem and check that it does fix it.
it follows the recommendations that Oliver provided us (back in Jun 25, see isuee #847);
it would be a useful (small) addition, as @gaelforget can show.

Now there is disagreement regarding the new optfile name but, until now,  it's not clear why a different and therefore less consistent name would be better.
@jahn since I keep quoting you, and although you already answered positively to this PR changes (on Jun 26, "Yes, precisely"), would you mind, when you find some time, to approve it ?

given @gaelforget's time constraint suggest we merge this now (despite my concerns about the naming confusion). @jm-c and I agree that the relevant doc in <IP_ADDRESS> is antiquated and desperately needs update anyway, and we can continue discussion of other relevant solutions/changes at MITgcm dev meeting and in issue #847 .

LGTM

@gaelforget I made a very minor adjustment to the new (additional) coment line (shorter, less upper case ...). but this looks good. @jrscott I agree, with one detail: to keep the issues focus on one specific topic, it would be better to open a new issue (and, of course, you can reference this PR and the issue 847 inside the new issue). @jahn thanks for the review and the input.
Now, I am planning to merge this PR soon (like later today), unless @gaelforget you would like to add something ?

all set!


CI: Create release builds for Apple silicon (ARM)

Create release builds for Apple's ARM machines as well.
Fixes #365.

Seems to work:


Check dependencies for a better error

When a dependency is missing, the error message is never informative.
We should check existence of dependencies at startup to directly warn the user about missing dependencies.

For the external dependencies of the tools, opam depext should have nice messages and can also install them on distros where it knows about the package manager. It's also future proof, we don't need to hardcode a list of packages and we don't have to deal with packages that have different names on different distros.
For the dependencies of the installer script, we need a clear error message.


Question: Why do you put your main file within lib?

Really looking at some insight into why you chose to put your main within lib. I'm thinking about doing it too.

There are no strng reasons about. Usually is because I don't want have lot of files in
root folder.
I use lib from start, so if the project grow to have lot of files, all process are already automated for source files in lib.

I totally agree I like it too, looks cleaner.


Add force-create button

This is off the back of https://phabricator.wikimedia.org/T259721
For now, this is visible to all who can see the creation buttons - we can lock it down to whoever necessary later if enwiki decides to make this CU-only.

This is off the back of https://phabricator.wikimedia.org/T259721
For now, this is visible to all who can see the creation buttons - we can lock it down to whoever necessary later if enwiki decides to make this CU-only.

Only admins (and stewards, though I'm not sure if stewards using the rights would be allowed under the global rights policy on enwiki) have centralauth-createlocal so showing the button to normal users of the interface is misleading since not everyone can use the special page

showing the button to normal users of the interface is misleading since not everyone can use the special page

Yeah probably, but we don't currently have any differentiation between enwiki admins vs enwiki non-admins. Building that into the tool will be a much larger undertaking for probably minimal benefit. For that matter, we also don't have any differentiation between checkusers and stewards either - both on-wiki groups have access to the buttons for local CU/log and loginwiki CU/log.
I expect enwiki to go one of two ways - either to limit this functionality to checkusers, or to expand this functionality to accountcreators (which would make this mostly moot).

showing the button to normal users of the interface is misleading since not everyone can use the special page

Yeah probably, but we don't currently have any differentiation between enwiki admins vs enwiki non-admins. Building that into the tool will be a much larger undertaking for probably minimal benefit. For that matter, we also don't have any differentiation between checkusers and stewards either - both on-wiki groups have access to the buttons for local CU/log and loginwiki CU/log.
I expect enwiki to go one of two ways - either to limit this functionality to checkusers, or to expand this functionality to accountcreators (which would make this mostly moot).

Perhaps add a tooltip noting that the use is restricted for now?

That's fair, but this is something which absolutely must be raised on-wiki as well - as it stands, this functionality will be going live to all admins fairly shortly, and it's been announced in both the admins newsletter and tech news recently, there's almost bound to be cases where this functionality will start being used by unknowing admins whether we like it or not.

Just for the record, I did add a local message warning administrators about it.
https://en.wikipedia.org/w/index.php?title=MediaWiki:Centralauth-createlocal-pretext&oldid=988268913
Grammar fixes welcome.

Codecov Report

Merging #631 (4de63e3) into master (93aed16) will increase coverage by 2.33%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             master    #631      +/-   ##
===========================================
+ Coverage      5.17%   7.51%   +2.33%
- Complexity     2348    2376      +28
===========================================
  Files           173     173
  Lines         11642   11477     -165
===========================================
+ Hits            603     863     +260
+ Misses        11039   10614     -425

Impacted Files
Coverage Δ
Complexity Δ

includes/Pages/PageViewRequest.php
0.00% <0.00%> (ø)
38.00 <0.00> (ø)

includes/Security/RoleConfiguration.php
84.84% <ø> (ø)
14.00 <0.00> (ø)

includes/Pages/PageBan.php
0.00% <0.00%> (ø)
42.00% <0.00%> (-37.00%)

includes/DataObjects/Ban.php
0.00% <0.00%> (ø)
26.00% <0.00%> (-23.00%)

includes/Helpers/BanHelper.php
0.00% <0.00%> (ø)
4.00% <0.00%> (-29.00%)

includes/Helpers/LogHelper.php
0.00% <0.00%> (ø)
46.00% <0.00%> (ø%)

includes/DataObjects/Comment.php
0.00% <0.00%> (ø)
17.00% <0.00%> (+14.00%)

includes/Pages/PageEditComment.php
0.00% <0.00%> (ø)
11.00% <0.00%> (-9.00%)

includes/API/Actions/CountAction.php
0.00% <0.00%> (ø)
6.00% <0.00%> (ø%)

includes/Providers/TorExitProvider.php
0.00% <0.00%> (ø)
8.00% <0.00%> (ø%)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93aed16...1a8786c. Read the comment docs.


Should we must limit lb:// protocol use host format?

Hi!Thanks the wonderful project.
I have some confuse with the lb:// check design.
Using lb://order_app will throw a exception of java.lang.IllegalStateException: Invalid host: lb://order_app because order_app is NOT a host scheme. Exception throw from here:
if("lb".equalsIgnoreCase(routeUri.getScheme()) && routeUri.getHost() == null) {
	//Load balanced URIs should always have a host.  If the host is null it is most
	/likely because the host name was invalid (for example included an underscore)
	throw new IllegalStateException("Invalid host: " + routeUri.toString());
}

Why limit application name with a host format?
Is there a best practice to name a application?
There also has some conflict with Spring Cloud Config if use order-app as a name. Because Spring Cloud Config use - distinct environment in some situation.

It's an assumption we make many places in spring cloud. We use spring framework URI utilities and java's URI class which is where the limitation comes from.
If we did anything, it would be during a major release (which will not happen for a long time, think spring framework 6 or spring boot 3). We would have to rework all locations to use some custom class. I personally don't want to spend the effort.

It's

Cannot have underline。dont use lb://order_app , but use lb://order-app .Because URI don‘t support underline.

Thank you very much


Social EditPost content fails to render into DetailSlider.

https://github.com/PolymerLabs/arcs/pull/1154 seems to have broken post creation somehow, to repro:

create a new arc for 'Write posts...'
click the '+' button bottom right to open detail slider
note JS console errors and the absence of a TextArea filling the DetailSlider where one should be able to enter text.

The assert at dom-context.js line 143 fails, but then the error message itself fails because slotSpec is not defined. This looks like an oversight in the error message string creation. But, assert wise, both this.subId and subId are null, and providedSlotSpec.isSet is false.
The call stack is from _initInnerSlotContext line 129.
dom-slot.js:84 Uncaught (in promise) ReferenceError: slotSpec is not defined
    at DomContext._validateSubId (dom-context.js:144)
    at DomContext._initInnerSlotContext (dom-context.js:129)
    at Array.from.forEach.elem (dom-context.js:124)
    at Array.forEach (<anonymous>)
    at DomContext.initInnerContexts (dom-context.js:113)
    at MutationObserver (dom-slot.js:81)

yes, I'll send a fix shortly. Sorry about that.

No problem! We need a Selenium test for Social post creation...

Actually, it has broken pretty much everything :( but selenium tests were already flaky, so I carelessly ignored it :(

I believe this should be fixed now, closing. Please, reopen, if you're still experiencing problems.


Fix pages menu min width

Fixes

Fixes #657 by @panchovm
Description

Adds a min-width of 200px to the pages menu dropdown.
Testing Instructions

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I wonder if this value will be used for any other element? Then it would be nice to add a tailwind width value.

Agreed, I think we could do that the next time a 200px value is introduced 👍


.NET interactive should not be a notebook content provider in VS code stable

Once the jupyter extension ships, if .NET extension is installed, jupyter will use the new editor and register itself as the notebook provider.
To allow python notebooks to still be supported when .NET interactive is installed, .NET interactive can't be the content provider.
If it is, then only .NET interactive languages can be used.
This PR here is the submission on the Jupyter side that enables jupyter and .NET in stable:
https://github.com/microsoft/vscode-jupyter/pull/4772

Maybe also have a dependency on the jupyter extension in stable too? (which I believe you already do in insiders?)


Suppress committee warning

Since committee gem v4.4.0, assert_response_schema_confirm requires HTTP status code explictly.
Been seeing this message a lot in the logs, so fix that up.

Pass expected response status code to check it against the corresponding schema explicitly.

Also, since we're now testing response status code with assert_response_schema_confirm(200),
so we no longer need our own test expect(response).to(have_http_status(:ok)).

After encountering the limitation of GITHUB_TOKEN permissions for pull requests from public forked repositories, I've decided to switch to using an internal branch rather than proceeding with a fork.
#2236


espup should clean up old path entries automatically

Installing a new toolchain (even just a pre-release) leaves old path entries behind. This means that long-term use of espup will eventually run into #270.
While this is related to #270 I consider this a separate issue. #270 can be hit first the time if the user starts with a particularly big path variable, but repeated use should not result in considerable, linear growth of the length of $Env:PATH.
I should note that it's not sufficient for espup update to do the cleanup, as pre-releases need to be installed with espup install.

Do you have any suggestions on how to solve this issue? The main concern that I have when cleaning the path is: How do I know that espup added that entry, and it's not there because the user also uses esp-idf?

I should note that it's not sufficient for espup update to do the cleanup, as pre-releases need to be installed with espup install.

Pre-releases should also be installed with espup update

Pre-releases should also be installed with espup update

The announcement was not at all clear about this.
https://matrix.to/#/!LdaNPfUfvefOLewEIM:matrix.org/$ZAzqDb185Cpjil1OOwdcAoSxLkm8E0rDUj1d_gPwGd8?via=matrix.org&via=tchncs.de&via=mozilla.org

Do you have any suggestions on how to solve this issue?

My best idea is to write a file to the installation folder that lists what was added (and that doesn't list duplicates/skipped entries), so espup could read, when removing that version, what it needs to delete. If you don't need to add a path because of esp-idf, don't list it in that file. This should be okay since espup only supports a single installed toolchain version, so there's no "race condition" when things are installed/uninstalled out of order.
I guess it's not perfect because users can manually mess everything up, but it's up to them to do so.

This should be okay since espup only supports a single installed toolchain version, so there's no "race condition" when things are installed/uninstalled out of order.

espup supports several installed toolchain versions, using the -a, --name parameter.
The main problem with the file approach is: Say that an esp-idf user wants to try Rust, before using espup he already has the path set for esp-idf, then he runs espup, uses the Xtensa Rust toolchain, but he wants to uninstall Rust stuff, then espup might delete the initial esp-idf path.
The environment variables are quite complex to handle at the moment, but if we manage to use LLD as our linker (https://github.com/esp-rs/esp-hal/pull/357), which is a WIP, all this would become much easier as we only need to set the LIBCLANG_PATH environment variable.

but he wants to uninstall Rust stuff, then espup might delete the initial esp-idf path

I might not have been clear with this, but I probably wouldn't store the env vars that are already added by esp-idf:

and that doesn't list duplicates/skipped entries

But since --name breaks my idea, nevermind :)

I will try to gather some information about the status of LLD support, if we are close to using it, we can leave this issue as unresolved as in the near future it won't apply. Otherwise, let's try to find a good way to solve this!


feat: add jp translation

Adds the Japanese translation file app_jp.arb to the lib/l10n directory, expanding the app's internationalization support.

Translation Coverage: Includes comprehensive translations for UI elements, error messages, settings, and user interactions, ensuring a localized experience for Japanese users.
User Interaction: Translates system messages, chat commands, and prompts, facilitating smoother engagement for Japanese-speaking audiences.
Settings and Features: Localizes settings, features descriptions, and warnings, such as audio source permissions and stream preview notices, enhancing usability for the target demographic.

For more details, open the Copilot Workspace session.

@SputNikPlop can you see if there are any japanese speakers you can run this translation file by?


chore: fix extractor for Tailwind

I fixed the problem with Tailwind. This fix solve the problem of responsive for fix #16 🎉

You've been busy 😎 thanks so much! I'll check this first thing tomorrow.

I couldn't sleep, and this is looking great! Thanks.


Weex Playground App下载地址被篡改

https://weex.apache.org/tools/playground.html
扫码下载时提示404，
下载APK安装后发现是360软件管家

感谢你的反馈，Weex目前是隶属于Apache Software Foundation的项目，因此在Gtihub渠道我们鼓励使用英文反馈问题。下面我将使用Google Trasnlate将你的问题翻译成英语，并以英语回答。

Https://weex.apache.org/tools/playground.html 404 when scanning code download, download APK after installation found to be 360 software housekeeper

This is because the 404 problem, we will fix it as soon as possible. Meanwhile there is an Android and iOS link, which still works now.

The problem has been solved, thanks