Close #38: Improve error reporting

Closes #38

Note: #44 will introduce a token-printing function, so it makes sense to wait for the merge of that one for now.

Starting from scatch with #50 because the rebase isn't worth it.
Still keeping this draft PR open for a while to save one click when checking the code in the web UI.


HDFS relating operations in runQuery should be parallel

In early BB, these operations are partial parallel. So, it increases about 8~9s for each query with latest BB.

Hi,
as far as I remember, running these commands in background break all error handling. If you run "runCmdWithErrorCheck" in background, the "exit 1" in that method will most likely terminate the subshell instead of the bigBench script itself (bash tends to run everything in a subshell, as soon as things get more sophisticated...). Even if you change that code to something else (e.g., leave out runCmdWithErrorCheck) , you still have to check the return value of every background process right before the "wait". I don't know how this could be accomplished reliably in bash.
This problem was the reason why I changed these commands from background to foreground processes in the first place. If you can guarantee that error handling still works with your patch, I am happy to merge your changes. For the moment, I tend towards not merging your changes as I am certain that we might run into error handling problems.
Best regards,
Manuel

Update: New solution - install "snakebite" hdfs client on you gateway machine from which you run Big-Data-Benchmark-For-Big-Bench.
https://github.com/spotify/snakebite
You can activate snakebite (if installed) in: conf/userSettings.conf (end of file).
Its not used for everything, but the performance critical paths can use snakebite instead of hadoop fs enabled.
Parallel execution is not desired and not possible (e.g. you have to delete,recreate and then cmod a folder in that order).
The real underlying issue of this ticket is the painfull slowness of the "hadoop fs" or "hdfs/dfs" commands, where most time is spent starting up and not executing the command itself.
Using snakebite hdfs client, which is now supported, reduces this time significantly, shaving off 10-30 seconds of execution time from each query. This is most noticable and beneficial with small scalefactors or non MR execution engines like TEZ/SPARK.

@joshuayao closing this for now, re-open if this is still an issue


Trying to create Hylia Site: 400 on /.netlify/git/settings

Hi there! Really excited to get a site spun up, it seems you've made it pretty easy :) That said, still having a problem after following your video walkthrough ++ scrounging through github issues.

The 400 error is {"code":400,"msg":"Operator microservice headers missing"}
I've tried disabling/enabling Git Gateway, Regenerating API token, Redeploying the site... I even tore everything down and started from scratch again from you video. No dice -- Any idea what might be up?

Howdy! This very much seems like a Netlify and Netlify CMS issue.
It might be best to report this to them because if I’m honest, I have no
idea what the issue could be.
Sorry!
On Fri, 29 May 2020 at 01:12, Sam Silver<EMAIL_ADDRESS>wrote:

Hi there! Really excited to get a site spun up, it seems you've made it
pretty easy :) That said, still having a problem after following your video
walkthrough ++ scrounging through github issues.
[image: image]
https://user-images.githubusercontent.com/7740431/83206714-418f2f80-a106-11ea-92b5-b5945aae7a69.png
The 400 error is {"code":400,"msg":"Operator microservice headers missing"}
I've tried disabling/enabling Git Gateway, Regenerating API token,
Redeploying the site... I even tore everything down and started from
scratch again from you video. No dice -- Any idea what might be up?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hankchizljaw/hylia/issues/127, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCFKRZRTW4KBCFSGCJJBHDRT34X5ANCNFSM4NNSSKXQ
.


User id as a pk for email confirmation & password reset

LGTM, but may break some frontend links, frontend will need to be updated shortly after this is merged

It should not as the id is only deferred from the confirm view to a backend API call. We may need to update the front props type but that's all.

This PR currently does not work for me, i imagine because the ResetPassword view (user/views.py#233) expects a user field in its request, and uses it to try and retrieve a user from its name. This makes the frontend fail, and i think the workflow would be the same without it, and it would still fail.

You're right on some points. ResetPasswordview should be edited too.

Moreover, i don't really get the appeal of using the PK instead of the username. Sure, you can see people's username on the website or guess it from somewhere else, but having PKs in the URLs means you have a parameter you can enumerate (even if you need to know the validation UUID; having the UUID means you can just enumerate until you find whoever reset, whereas if a username wasn't known prior, having the UUID does not necessarily mean you can find the user and reset it for them).

The goal of this PR is to remove use of username as user pk in user views so that we can allow users to change it. This should not bring any security problems as the endpoints currently using username are :

EmailConfirmView : take a token in parameters so can't be brute force.
ResetPassword : take a token in parameters
ResendEmailConfirmView : This is not used at the moment and should maybe use email instead.

Indeed, ResetPassword is missing, this need to be fixed.
There still is a UUID that can't be guessed in theses views and if someone find a valid UUID we have other things to be scared of because it's only send in the confirm mail with the complete URL.
The same thing was used for the ticket with the user id and a UUID.


Error in run step 23/35 No such directory.

Error message is as follows:
"mv: can't rename './@ExileServer': No such file or directory"
Dockerfile: http://termbin.com/mpzy
Command output: http://termbin.com/fggt

Looks like:
WORKDIR /tmp/$EXILE_SERVER_FILENAME/Arma\ 3\ Server
Should be:
WORKDIR /tmp/Arma\ 3\ Server

Same issue applies to the MySQL workfolder!

Try this https://github.com/timelf123/docker-arma3-exile
./build.sh - downloads the mods, keys and mpmissions for exile, sets up the folder structure for volumes, gets sql file ready for mysql to load
git clone https://github.com/timelf123/docker-arma3-exile.git
./build.sh
docker-compose up -d

Cheers.

Np - will be re-releasing a cleaned up version probably next week - but this should get you started


output the vm ip on osx

Still on the fence about OSX...last week showed me it's a real pain vs. Linux.
But this is an easy fix, so...

:+1:


[Question] - How would you cache the requests you make?

is caching included in the node package or is it self implimented, if its self done how would you save only the fetch requests so every time there made if theres cache they can fe fetched from there instead?

It should be self implemented. You could use something like memcached or redis

Will close this for now. We can start a separate discussion if you would like. @bobbymannino


⚠ TorrentLeech has degraded performance

In 33f9ace, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 3054 ms

Resolved: TorrentLeech performance has improved in b7cabfb after 6 minutes.


feat(react-scripts): handle ejection

Fix #13

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Codegen failure: Unimplemented raw_eq intrinsic

The Rust team has introduced a new intrinsic raw_eq here. Failure to codegen is blocking this week's rebase in #292.

Fix was in #331


Rename artifacts to match OPS-6181

Is this PR still required?
@dwelch-spike @rbotzer @mcoberly2 @pvinh-spike


Bump golangci to v1.59.1

I made the changes that were required to pass the linter. I removed the internal directory which hasn't made much sense for a long time. I've modified the GitHub action
the new linter has depguard as the main change, which is a guard for imported packages. these must be explicitly enabled/disabled in the configuration.

https://golangci-lint.run/usage/linters/#depguard
https://github.com/OpenPeeDeeP/depguard

@kuritka Sorry, looks like the merge of https://github.com/k8gb-io/k8gb/pull/1602 led to the conflict, can you please rebase together with other neighbour PRs?

@ytsarev amended. No worries, the changes may go little against each other as I did in separate PR's, so rebasing is in plan.


EarlGrey 2.0 | EarlGrey breaks unit test target

To repro clone https://github.com/bootstraponline/earlgrey-2-binary-example and run a unit test.

This is a major bug - any progress in resolving this?


Add support for Agricraft with Farming Station

Issue Description:
Farming station doesn't harvest crops in agricraft crop sticks.
Realistically I believe that the support would typically be implemented on the agricraft side, but from the looks of it, it seems that development has stopped on agricraft (possibly temporary). If anything could be done to support it from the ender io side that would be much appreciated!
What happens:
The Farming station will ignore agricraft crop sticks entirely.
What you expected to happen:
I was hoping that the farming station would harvest and replant the seeds in the crop sticks.
Steps to reproduce:
Set up farming station
Set up crop sticks with seeds in them
Wait.
Affected Versions (Do not use "latest"):
EnderIO: 5.0.26
EnderCore: 0.5.30
Minecraft: 1.12.2
Forge: <IP_ADDRESS>05

This is something the agricraft farming station from Ender IO Addons handles. This is not a bug and just needs to be ported by someone.


Change hardcoded name of bit register "b"

The bit register is now hardcoded as "b", however a user might declare the qubit register as "b" which should be possible. So this must be changed.

@elenbaasc why did you close this, Chris?


Change system order so it's possible to have synchronized transforms for newly spawned entities

Right now, the ordering is:
create_body_and_collider_system --> bevy's transform_systems --> sync_transform_system
And that means no matter when you spawn, the entities will have one out-of-sync frame when the rigid body gets created. But if you change the ordering to:
create_body_and_collider_system --> sync_transform_system --> bevy's transform_systems
Then you can spawn on either side of that chain and you'll always be in sync.

On what stage is the bevy transform_systems executed?
The reason why sync_transform_system happens during the POST_UPDATE stage is that it makes sense for it to happen right after the physics update which is done during the UPDATE stage.

The transform systems execute in UPDATE stage.

I believe this has been fixed by https://github.com/dimforge/bevy_rapier/pull/32.
Feel free to reopen if this is not the case.


Added message batching to OpcPublisher

Issue 54
Batches OPC UA messages into 4K IoT Hub messages.

@khilscher,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

#54


MODCLUSTER-822: Decline Contexts and Aliases if lengths are exceeded

ref MODCLUSTER-822
This approach abstracts processing of Alias and Context for both APP and CONFIG commands. As a result, Alias for CONFIG is now also case insensitive, but that seems more like the correct behavior...

Any plans to add tests for the new messages? ;-)

Any plans to add tests for the new messages? ;-)

I hope that I'll manage to add the httpd/perl framework soon and write tests in that. I added this PR to the Missing tests issue.

Merging. Thanks for the review!


Add sample tests for frontend

Reference Issues/PRs
#24
Changes

Add sample code for frontend testing.
Locally, this testing should be executed manually, and in CI, will be executed automatically.

How to test manually
git fetch origin pull/23/head:test/frontend
git checkout test/frontend
cd frontend
yarn test --watchAll=false

In CI, please run
cd frontend
CI=true yarn test

Here is a reference.

I checked the result in my local environment and it was work!
Thank you for your commit!
I'll merge instead of you.


[Triton-MLIR] add GitHub CI runners

This PR is to add GitHub Actions runners to the CI for better coverage.
Problem

A self-hosted runner deployed by OpenAI cannot be used for an external repository, so a developer cannot locally test a change by creating a PR to, for example, my own repository (like https://github.com/shintaro-iwasaki/triton/pull/2).  To run a test, draft/WIP PRs need to be created, making the official GitHub repository messy.
Setting of self-hosted is not public, so a developer is not sure if the problem is in the self-hosted machine or his/her code.
Build for macOS is currently broken (at least, on GitHub)

Solutions
This PR adds the default GitHub runners (macos-latest and ubuntu-latest) to CI.
Benefits

I can test my change using my forked GitHub repository without creating a PR (though it's not complete since GitHub runners don't have GPUs)
These GitHub runner configurations are more "reliable" and considered to be "well-maintained".
We can find an issue in macOS.

Discussions

Tests that need GPUs are skipped.
Currently tests take only 5 mins.  If it takes too long, we can skip some tests (e.g., now some format checks are skipped for macos) or only limit to compilation.
There exist plenty of GitHub runner resources, so I don't think Triton will run out of it.

Hmm. I don't think we should have the main repo use github runners at all for now (maybe in the future for non-GPU tests). Would something like this work?
runs-on: ${{ github.repository == 'openai/triton' ? [self-hosted, A10] : 'ubuntu-latest' }}

Thanks for your comments!
I believe, at least, macos support would be useful even for the main repository, particularly if we want to allow developers to use MacOS for developing Triton. If OpenAI's policy is no tests using GitHub's default runners, I remove macos, too, by doing something like:
runs-on: ${{ github.repository == 'openai/triton' ? [self-hosted, A10] : 'ubuntu-latest' }}

Ah yes, good point about macos. Let's do self-hosted,A10 vs ubuntu-latest for linux, and macos-latest for both
Then for the GPU tests we can check for the tags V100 or A10

Thanks, @ptillet. I updated the PR. ubuntu-latest shouldn't be triggered for this repository. I would appreciate it if you could approve running workflows.
Please let me know any problems.

[Details] Unfortunately, another job (Runner-Preparation) is needed to create a matrix. For example, the following does not work for some reasons.
      matrix:
        runner: [ubuntu-latest, macos-latest, ${{ fromJSON('["", "self-hosted"]')[github.repository == 'openai/triton'] }}]

The current solution is based on https://stackoverflow.com/questions/65384420/how-to-make-a-github-action-matrix-element-conditional

Hmm it looks like one test isn't running, I wonder why. I'm not at home right now but I'll take a look later tonight or tomorrow

Thanks for your approval! I think all the tests ran successfully (self-hosted and macos-latest).
This repository seems configured to require a certain test ("Integration-Tests", ... exact string match?) to merge, so perhaps that's why GitHub still reports
Integration-Tests Expected — Waiting for status to be reported


(Android) Store check in status in Realm

Description:

This PR exposes native methods to store Check In status in Realm.

@aledustet I updated the Realm fields, please review it again when you have some time


Bug: Incorrect data saved for SPAN Records

Issue:
Adding new Span record => Error message: "[SPAN-56-B] - You have reported an MPC Value for [Monitor Span], but an MPCValue is not appropriate for this ComponentTypeCode and SpanScaleCode. [SPAN-57-A] - You did not report an MECValue for [Monitor Span].  This value is required in a non-flow low-scale-span record." where the MPC value is required for component CO2.  However, the changes were accepted after changing the Span Scale from Low to High.
Test Data:
Create Span record: Component Type: CO2 concentration, Span Scale: Low, Span Method: Historical Data, MEC Value: leave blank, MPC Value: 12, MPF Value: leave blank, Span Value: 21, Full Scale Range: 21, Span Units of Measure: Percentage, Scale Transition Point: leave blank, Default High Range: leave blank, Flow Span Value: leave blank, Flow Full Scale Range: leave blank, Start Date - mm/dd/yyyy: 04/18/2023, Start Time: 13

SPAN-56-A

SPAN-56-B

SPAN-56-C

Checks work properly


<EMAIL_ADDRESS>

https://metamask.app.link/send/0x78650b139471520656b9e7aa7a5e9276814a38e9@56/transfer?address=0xfAe83fF14aCB884a1FFd597D481c0B5981023b36&uint256=1e22

Please submit the correct information, invalid information will cause the issue to close


Rename variables nutrition_satured_fat and nutrition_satured_fat_short_name

Rename those variables
    <string name="nutrition_satured_fat">Saturated fat</string>
    <string name="nutrition_satured_fat_short_name">Saturated fat (g)</string>

satured >> saturated

Closing as this has been already fixed.


Output file

I am unsure how exactly the output file is formatted. The first line is the number of words and another int. Is that the max size of each word? Then, on the next line, a word followed by a bunch of small doubles (it seems between -0.005 and 0.005); there are more than the amount of words there are (i.e 8 words, waaaay more than 8 doubles) so I assume this is not the distance. There are lines for each word. When I use the Distance class, it doesn't get all the words, instead it just gets the first and then every entry after is just a bunch of nonsense numbers which don't seem to correspond to anythying.

I found the issue- the parsing of the file, reading in the 4 bytes after reading the word, produces very erroneous results. I wrote another method ReadFloat which reads each float in and replaced the other code, and that fixed the problem. I also wrote a methods that advances the stream to the end of the line.


Upgrading the instance type in cluster launch

m5.large has 2 vCPU. When we do full kubeflow installation
most of its vCPU resources will be occupied and notebook server
will fail with error on unavailbale of vCPU resource. Upgrade the
instance type to m5.2xlarge so that vCPU limit will increase from
2 to 8.

@goswamig Thank you contributions, but m5.large is used because it can serve normal use cases, including individual users, demo, workshop.
So let's not change default instance type, instead, you can add a note:
If users are using kubeflow massively in production, it's recommended to use m5.2xlarge instance.

@PatrickXYS  I am getting error "CPU resource not available" when I try to launch notebook server with m5.large.

 Warning  FailedScheduling  62s   default-scheduler  0/3 nodes are available: 1 Too many pods, 3 Insufficient cpu.
  Warning  FailedScheduling  62s   default-scheduler  0/3 nodes are available: 1 Too many pods, 3 Insufficient cpu.

You can use more than one m5.large instance for your kubeflow testing / development

there is already 3 m5 launched in the config ...
cat << EOF > cluster.yaml
---
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: ${AWS_CLUSTER_NAME}
  version: "${K8S_VERSION}"
  region: ${AWS_REGION}

managedNodeGroups:
- name: kubeflow-mng
  desiredCapacity: 3
  instanceType: ${EC2_INSTANCE_TYPE}
EOF


channel description update script

scripts to update channel descriptions
motivation: want to make sure public channel list page has up to date, quality descriptions without the need to re-run all the chefs

Usage:
First setup ENV vars:
export NOTION_TOKEN="<notiontoken>"
export<EMAIL_ADDRESS>export STUDIO_PASS="yourpassword"
export STUDIO_TOKEN="yourstudiotoken"

then to test on the studio develop server run
fab update_channel_descriptions

TO run against production studio:
fab update_channel_descriptions:landscape='master'


Improve command-line arguments handling of ./utils/

Firstly
Addressing:
$ go run utils/parser.go
panic: runtime error: index out of range [1] with length 1

goroutine 1 [running]:
main.main()
	standards/utils/parser.go:137 +0x14f1
exit status 2

Secondly
Let the source URL to be command-line parameter
Also, replase os.Args() with flag.Args() that are slightly more powerful.

Awesome!
@isimluk , could the docs be updated to reflect this being a command line parameter? e.g. update the --help output?

(or whatever --help actually is)

Awesome!

Thanks!

could the docs be updated to reflect this being a command line parameter? e.g. update the --help output?

Actually, there was never any --help. Nevertheless, this PR silently, creates --help (due to magic in flag go module).
$ go run utils/parser.go --help
Usage of /tmp/go-build148765894/b001/exe/parser:
  -source string
    	url to fetch controls from (default "http://nvd.nist.gov/static/feeds/xml/sp80053/rev4/800-53-controls.xml")
exit status 2


feat: handle multiple firebase hosting targets

Closes #48

Prior to the PR, the jq command would return two URLs separated by a newline character for firebase projects that have multiple hosting targets. This caused github actions to error because it didn't like the \n as part of the output string. The tr command replaces the \n with a string that it acceptable.

Does that mean it returns both urls?


Node 4 support: switch from i2c to i2c-bus library

First of all, thank you for creating this library!
I made this change because the i2c package does not support node 4.x and newer. Switching to i2c-bus fixes that.
I'd really appreciate if you could merge this and publish a new release. I am giving a talk in a javascript conference next week, and would really like to use this library in my demo.
Thanks!

Thanks for doing the i2c port! It's published on npm now as Version v0.0.5

Wonderful, thanks!


Form parsing memory consumption

GetFormAsync buffers, reads to a string, and then parses into components. Consider:

Spool to disk option for large bodies or
Parsing the content as you go, no buffering required.

Fixed as part of https://github.com/aspnet/HttpAbstractions/issues/139


Test fix: Http1AdaptorEdge2EdgeTest::test_1001_client_request_close

Codecov Report

Merging #536 (39ad2c0) into main (3de1c52) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   25.15%   25.14%   -0.01%
==========================================
  Files         115      115
  Lines       28792    28792
  Branches     4673     4673
==========================================
- Hits         7242     7241       -1
  Misses      20581    20581
- Partials      969      970       +1

Flag
Coverage Δ

unittests
25.14% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/router_core/address_watch.c
78.48% <0.00%> (-1.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de1c52...39ad2c0. Read the comment docs.


LV624 parity

About the PR
added the heavy assault rifle to lv624
Why / Balance
Parity
Technical details

Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:
Added the M54CE2 to LV624

you need "- add: " in your changelog

Not sure why git created a massive diff out of the changes but I'll try to help you out with that tomorrow
For now I added the heavy pulse rifle to LV in my branch ty


Loading every time I open a book

The reader loads every time I open a book even when I have read it before.

Well I'm sure it can keep storing the books in the loader.

Well I'm sure it can keep storing the books in the loader.


[FLINK-2930] Respect ExecutionConfig execution retry delay

This only affects job recovery on non-master failures.

This looks like a pretty big issue, actually.
+1 to merge this.
Might not be a release blocker, but if there is another RC, I would add this.

+1, I also stumbled across the problem when I showed Aljoscha's demo at the Flink meetup in Paris.

@uce Builds seems to be failing. Can you look into it?

The problem is that the retries are hard coded in some other places. It was only working before this change, because it was actually not picked up anywhere. I will remove the hard coded parts. Also, I'm removing the getters and setters from the Environment. I don't think that it is the right place. We should keep it in the ExecutionConfig only.

I've also added FLINK-2958 in this PR.
What's your opinion about FLINK-2959?

Thanks for fixing. Merging commits for FLINK-2930 and FLINK-2958.


Add a medium length string mode

This adds a "medium string" mode where the sizes of arena allocations are stored using a char instead of a size_t, saving 8 bytes per string for strings with lengths between 16 and 255 bytes. I modified the tests so they use longer strings more often which exercises all the different memory allocation modes we're now supporting.
I also dropped the attempt to store the size_t sizes in aligned locations because it adds a bunch of bookkeeping headaches. If it turns out the memcpy to unaligned addresses is slow we can come back to this.

I'm glad I have ASAN running in the tests here, it noticed a serious flaw in the first version of this.


Added workflow step to deploy the canary image to prod

- Added workflow step to deploy the canary image to prod

@gkc and @kalluriramkumar I've added you as reviewers as I'd like your eyes on this before we merge.


samples(compute): add moving instances samples [do not merge]

Sure, this PR is just a WIP. I have splitted this PR into 3 parts and fixed your comments. We could jump into them for more detailed comments, if neded:

Disks samples: https://github.com/GoogleCloudPlatform/golang-samples/pull/2628
Snapshots samples: https://github.com/GoogleCloudPlatform/golang-samples/pull/2629
Samples for moving instances doc: https://github.com/GoogleCloudPlatform/golang-samples/pull/2630

@FrodoTheTrue Can we close this?

yep, sure


[WIP] Streamline organization onboarding using a newly introduced account request flow

Resolves #1772
Description
The manual work necessary for onboarding has been a thorn on our sides. It has taken extra resources & overhead to ensure interested users of Diaperbase get onboarded efficiently and timely. This PR simplifies and reduces the manual work required to onboard new organizations by introducing a new account request flow.
This flow, in summary, does this:

Prospective users fill out an account request form.
Our application sends them an email /w a confirmation link & details on how to test our application.
The user will click the confirmation link and confirm that they want an account.
Admins receive an email /w a link to the organization creation form that pre-populates with the account request form data provided in step 1. From there the admin can proceed to create the organization & account. (The link only works for one organization. This is to prevent accidental duplicative work by multiple admins)

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added a system spec that covers the flow
Manually testing :)

Screenshots
Note -- the copies still need to be worked out. The screenshots are subject to change on release
From the home page, you can click to access the account request form.

We notify them that the account request had been made and we sent them to follow up instructions in a email

In the email there is a

Clicking confirmation goes here:

And then confirming.

Upon confirming, admins will receive this email:

Clicking the 'Create This Organization' button goes to the organization to create the form but pre-populated.

Trying to use the link again to create another organization will yield an error message:

@edwinthinks All of it looks great!! 🥇
I think instead of click here to request a DiaperBase account, it should be click here to request a demo.
Maybe another line below that in small print, saying: once you have viewed the demo, you will be able to request a DiaperBase account.
Hopefully that should make it clear that they will get a demo first?
Also, once the account is set up, will it send out the welcome email that they receive now, upon account setup?
@armahillo and @seanmarcia Would you please provide a technical review?

I think instead of click here to request a DiaperBase account, it should be click here to request a demo.
Maybe another line below that in small print, saying: once you have viewed the demo, you will be able to request a DiaperBase account.

Sounds good I'll modify them based on your feedback.

Also, once the account is set up, will it send out the welcome email that they receive now, upon account setup?

Yep :)

@armahillo @seanmarcia. Fixed up specs and removed unnecessary code. Ready for review whenever either of you is available.

@armahillo You got this!

I would advise removing "Click Here" from the button text -- just have the button say what it does. "Request a Demo" should be fine. Maybe slap btn btn-primary on it as well?
Looking at the code now


Rendezvous: add an option to render a timelapse instead of just the end paths; add an option to deselect some players (to make it easier to see your path, e.g.)

Potentially just offer a slider to jump to a time, instead of timelapse.


Support for the new Node LTS (version 20)

As the current LTS version of node.js is 20 and the maintenance version is 18, we should reflect that within the protoype kit.
See here for the current LTS version: https://nodejs.org/en/download

This PR drops support for 16 which we shouldn't be doing.  We should be adding support for 20 without dropping support for 16.
We should also go back to using a specific version in our .nvmrc file, that should be 20.9.0 as that's the current LTS.

Hope this is useful, but you'll probably want Node.js v20.x rather than v20.9.0 or you'll miss new releases:
- lts/*
+ lts/iron

We've just completed our GOV.UK Frontend switch to Node.js 20
Snags wise, Dependabot is still using Node.js 18 which caught us out today:

https://github.com/alphagov/govuk-frontend/pull/4408

But otherwise all our tooling blockers were completed and I've added notes for asdf or nvm gotchas

Bear in mind too that you're still on the legacy { "lockfileVersion": 2 } format
Similar to how Node.js 18 shipped with npm v8 but later npm v9, watch out for this to become an issue:

https://github.com/alphagov/govuk-prototype-kit/pull/2356#discussion_r1350236981

With the version - I think it's important that we specify the version in .nvmrc as it allows reproducibility if we're looking at the same code in the future rather than it using whatever version is lts at that future time.

With the version - I think it's important that we specify the version in .nvmrc as it allows reproducibility if we're looking at the same code in the future rather than it using whatever version is lts at that future time.

That's fair, don't forget your node-version matrix uses the latest (cached) version too
matrix:
  node-version: [16.x, 18.x, 20.x]


[Onboarding flow] Display items identified when taking a picture

Purpose
We need to display to the user the items we identified when the picture was taken with the camera of the mobile device.
User story
As a user, I want to see what items were identified by the app so that I can move forward with the onboarding.
Acceptance criteria

[x] The app will display the picture the user took and the UI will display two actions:
[x] 'Good to go' button - when clicked, the user reviews the picture and decides to move on to the next question because all the items on hand have been included in the photo.
[x] 'Edit items' button - when clicked, the user reviews the picture and decides to add something more that is not included:
[x] Clicking the 'Edit items' button, will open a bottom sheet component (example here).
[x] When this bottom sheet component is open, there is a list of all the items identified by the app.
[x] The user can add a new item by typing on the text box on top of the bottom sheet component.
[x] The user can also choose to remove any of the items shown on the list if they don't want to have it included in the playtime suggestion by clicking on the trash icon on the side of the name of the identified item.

Design notes

Wireframes are here

Design specifics are here

Definition of Done (DoD)

[ ] The feature has been fully implemented, thoroughly tested, and integrated into the app with no critical bugs or performance issues.
[ ] Manual testing is complete, verifying that the feature meets all acceptance criteria.
[ ] Big features are documented inside the code, with clear explanations of functionality, usage, and any relevant edge cases.
[ ] The feature has undergone peer review, with the code approved by at least one other team member to ensure quality and maintainability.
[ ] The feature branch has been successfully merged into the main branch, and the pull request is closed and the branch is deleted.
[ ] The feature’s UI/UX has been reviewed to ensure consistency and alignment with design guidelines.

https://github.com/user-attachments/assets/778712c7-927a-43d0-a975-4caec659c825


Add cloudagent endpoint for getting agent uptime

This adds a new API to the cloudagent allowing clients to query the time in nanoseconds that the cloud agent has been running.

https://github.com/microsoft/moc/blob/main/rpc/common/admin/health/moc_common_health.proto is probably a better place to add these changes.

https://github.com/microsoft/moc/blob/main/rpc/common/admin/health/moc_common_health.proto is probably a better place to add these changes.

If we did that, would that mean that cloudagent would need to implement the other methods supported by the health endpoint? Looks like it doesn't implement any of them currently. I agree that looks like a better place to put this method though. Also, note that for our use case we really only need this to be on the cloud agent (wasn't sure if this would also require adding the uptime method to the services which do currently support the health endpoint).

https://github.com/microsoft/moc/blob/main/rpc/common/admin/health/moc_common_health.proto is probably a better place to add these changes.

If we did that, would that mean that cloudagent would need to implement the other methods supported by the health endpoint? Looks like it doesn't implement any of them currently. I agree that looks like a better place to put this method though. Also, note that for our use case we really only need this to be on the cloud agent (wasn't sure if this would also require adding the uptime method to the services which do currently support the health endpoint).

my bad, I assumed it's already implemented in the cloud agent. Makes sense to keep it separate. Maybe we can place it here https://github.com/microsoft/moc/blob/main/rpc/common/admin/health just in case we decided to implement uptime for the node agents in the future?


AMPI support for collectives on inter-communicators

Original issue: https://charm.cs.illinois.edu/redmine/issues/969

For MPI-2, the following intracommunicator collective operations also apply to intercommunicators:
• MPI BCAST
• MPI GATHER, MPI GATHERV
• MPI SCATTER, MPI SCATTERV
• MPI ALLGATHER, MPI ALLGATHERV
• MPI ALLTOALL, MPI ALLTOALLV, MPI ALLTOALLW
• MPI REDUCE, MPI ALLREDUCE
• MPI REDUCE SCATTER
• MPI BARRIER

Original date: 2016-03-14 17:10:03

Don't forget MPI_Reduce_scatter_block, the non-blocking versions of all of these, and the constant MPI_ROOT.

Original date: 2016-05-19 03:15:21

AMPI communicators, including intercommunicators, are implemented as chare arrays, so an intercomm has 3 proxies: local, remote, and the union of both.

Original date: 2017-01-12 20:35:42

~~https://charm.cs.illinois.edu/gerrit/#/c/2084/~~ https://github.com/UIUC-PPL/charm/commit/a7ebf6632a96a7a8682878c0faf6d716f53635e7

Original date: 2017-03-10 16:56:33

Turn enumeration into a checklist, to test out the plugin and track completion mechanically.

Original date: 2017-03-10 16:58:05

Scatter/Iscatter:
~~https://charm.cs.illinois.edu/gerrit/#/c/2285/~~ https://github.com/UIUC-PPL/charm/commit/9875cf240a97a3e216d52afb844d553bd52245f22

Original date: 2017-03-10 16:59:27

Bcast/Ibcast
~~https://charm.cs.illinois.edu/gerrit/#/c/2127/~~ https://github.com/UIUC-PPL/charm/commit/eee1147e1673ba1b4744a23a2a77b49d3dfd75059

Original date: 2017-03-10 17:08:29

Gather/Igather in progress:
~~https://charm.cs.illinois.edu/gerrit/2183~~ https://github.com/UIUC-PPL/charm/commit/f8def5bd321286312a83317cd6bc4edba24a90e1

Original date: 2017-03-10 17:12:39

~~https://charm.cs.illinois.edu/gerrit/#/c/2084/~~ https://github.com/UIUC-PPL/charm/commit/a7ebf6632a96a7a8682878c0faf6d716f53635e77 contains a consolidated lump of

bcast, ibcast
barrier, ibarrier
gather, igather
gatherv, igatherv
scatter, scatterv

So, implementations waiting to be broken out:
(i)barrier, (i)gatherv, scatterv

Original date: 2017-04-25 15:59:50

(I)Barrier: ~~https://charm.cs.illinois.edu/gerrit/#/c/2342/~~ https://github.com/UIUC-PPL/charm/commit/d615adc1632ec435757556f2b8ff986f0cb2e541
(I)Scatter(v): ~~https://charm.cs.illinois.edu/gerrit/#/c/2361/~~ https://github.com/UIUC-PPL/charm/commit/026a86de12384438c947493def637015d9389427
(I)Alltoall(v,w), I(all)(reduce), (i)reduce_scatter(_block), (I)(all)gather(v) are still to be done, but all reduce and gather routines require support for buffering early arriving CkReductionMsg's, which I am working on as a part of issue #1155.


Add prqlc to cheat/cheatsheets

I created a PR at cheat/cheatsheets/pull/227

Again, looks great!


CCP - Unable to use placeholder inputs in request headers

We are attempting to create a code less connector to our data API, currently we require two headers to be passed with the request one is the API Key but we also require a Client ID header.
We get the users input using the 'UserRequestPlaceholdersInput'
{
    "parameters": {
        "enable": "true",
        "userRequestPlaceHoldersInput": [
            {
                "displayText": "Hostname",
                "requestObjectKey": "apiEndpoint",
                "placeHolderName": "{{hostname}}"
            },
            {
                "displayText": "Client ID",
                "requestObjectKey": "apiEndpoint",
                "placeHolderName": "{{client_id}}"
            }
        ]
    },
    "type": "APIKey"
}

Then attempt to use this placeholder in the 'headers' section of the pollingConfig.request section
"pollingConfig": {
    "auth": {
        "authType": "APIKey",
        "APIKeyName": "ApiKey",
        "IsAPIKeyInPostPayload": false
    },
    "request": {
        "apiEndpoint": "https://{{hostname}/route",
        "httpMethod": "Get",
        "retryCount": 2,
        "queryWindowInMin": 5,
        "timeoutInSeconds": 120,
        "headers": {
            "Accept": "application/json",
            "ClientId": "{{client_id}}"
        }
    }

Describe the solution you'd like
I would like the input that the users entered to be set on the request header.
Describe alternatives you've considered
We can of course change how the API works to accept only an API Key but would rather we were able to pass users inputted values in headers as a part of the request.

Hi @tonytilbo , Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 28Nov23. Thanks!

This isn't published anywhere yet as we are just testing connecting our API.   The code snippet above should give you everything you need though.

@tonytilbo, thank you for your response, we will check on this and get by to you by - 11-12-2023. Thanks!

Hi @tonytilbo ,Aplogies for the delayed response ,Could you please follow the documentation (https://learn.microsoft.com/en-us/azure/sentinel/create-codeless-connector?tabs=deploy-via-arm-template%2Cconnect-via-the-azure-portal#request-configuration) Please "type": "OAuth2",
"ClientSecret": "{{clientSecret}}",
"ClientId": "{{clientId}}",
"GrantType": "client_credentials", or OAuth if outh need to generate token,Please use the respective authentication mechanism and request parameters in request  i,e. "queryTimeFormat": "yyyy-MM-ddTHH:mm:ssZ",
"retryCount": 2,
"timeoutInSeconds": 60,
"headers": {
"Accept": "application/json",
"User-Agent": "Scuba"
},
"queryParameters" etc,,Please let me know if need more details

Hi @tonytilbo ,Gentle reminder,,Could you please follow the documentation (https://learn.microsoft.com/en-us/azure/sentinel/create-codeless-connector?tabs=deploy-via-arm-template%2Cconnect-via-the-azure-portal#request-configuration) Please "type": "OAuth2",
"ClientSecret": "{{clientSecret}}",
"ClientId": "{{clientId}}",
"GrantType": "client_credentials", or OAuth if outh need to generate token,Please use the respective authentication mechanism and request parameters in request i,e. "queryTimeFormat": "yyyy-MM-ddTHH:mm:ssZ",
"retryCount": 2,
"timeoutInSeconds": 60,
"headers": {
"Accept": "application/json",
"User-Agent": "Scuba"
},
"queryParameters" etc,,Please let me know if need more details

Hi, @tonytilbo, since we have not received a response in the last 5 days, we are closing your issue- #9456 as per our standard operating procedures. If you still need support for this issue, feel free to re-open at any time. Thank you for your co-operation.


fix installation when zabbix_repo="other"

Description of PR
When you set zabbix_repo="other", there's no need to install the basic repo file.
In order for the installation to succeed, the fact zabbix_server_package must also be configured when choosing zabbix_repo="other".
Type of change
Bugfix Pull Request

Thanks! 👍


Largest Sum Contiguous Subarray [JavaScript]

This issue is about Largest Sum Contiguous Subarray.

[x] Issue Title is in form Algo/DS Name [Language].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).

[x] I ensure that I am not already assigned to 2 or more issues.

[x] I will send my PR only after I'm assigned to this issue by any maintainer.
[x] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

@aviaryan assign me this.

@aviaryan assign me this.


About U-Net experiment

Hi,
Could you share the code of the U-Net part in Table.4 ?

same problem.

It is the same as Stable Diffusion.


Generate Data Dictionary task

A task to generate a CSV file of at least:

field name
field label
type
description
help text

Done in #1319


Changes to archive and create logs structure

This PR  will archive old logs in /var/log/leapp/archive and create the logs directory structure.
/var/log/leapp/dnf-debugdata/
/var/log/leapp/leapp-upgrade.log
/var/log/leapp/leapp-report.txt
/var/log/leapp/dnf-plugin-data.txt

Can one of the admins verify this patch?


Create a staging PR and production PR

Hi,
I would like to setup a workflow to deploy my applications (monorepo) in staging and production with release-please.
What are the best practices?
I thought about :

create a release-please-config.staging with:

{
  "prerelease-type": "beta",
  "release-type": "node",
  "versioning-strategy": "prerelease",
  "versioning-type": "prerelease",
  "versioning": "prerelease",
  "prerelease": true,
  "include-v-in-tag": true,
  "last-release-sha": "767ce15708e433867bdff190abf422d9d7defbeb",
  "initial-version": "0.61.0",
  "include-component-in-tag": true,
}

create a staging workflow on each PR merged on main. -> Release please create a PR with new features and fixes
If I merge this PR, it: a) create a staging tag like v1.1.0-beta b) run the release-please-config.production workflow with the
following config:

{
  "release-type": "node",
  "include-v-in-tag": true,
  "last-release-sha": "767ce15708e433867bdff190abf422d9d7defbeb",
  "initial-version": "0.61.0",
  "include-component-in-tag": true,
  "pull-request-title-pattern": "chore: release Production ${version}",
}

Release-please create a new PR for me, with a new version v1.1.0. If I merge this PR, it creates a tag
But if I don"t merge the production PR, and I add some new bug fixes, a new staging PR is created v1.1.0-beta.1
Is it possible to create such a workflow?
I tried with 2 release-please-manifests, but I am not convinced of the way to do it

@Spoutnik97 did you figure this out yet 👀 I want to do something similar and haven't found much info on how to do it.

No! So I created a new package to do what I wanted to accomplish.
You can find it as a cli https://github.com/Spoutnik97/releaser or a npm package https://www.npmjs.com/package/releaser-cli
The GitHub's action is provided.
Ask me if you need help


The description below is wrong in README doc file.

the wrong edition
true when created by the Object constructor, or Object.create(null).
...
isPlainObject(null);
//=> true

false when not created by the Object constructor.
...
isPlainObject(Object.create(null));
//=> false

the correct edition
true when created by the Object constructor, or Object.create(null).
...
isPlainObject(Object.create(null));
//=> true

false when not created by the Object constructor.
...
isPlainObject(null);
//=> false

Hi, could you send PR?


什么时候能支持Jetpack Compose呀😄

什么时候能支持Jetpack Compose呀😄

我也很想知道

I also want to ask this question

+1

+1

+1

+1

+1


Bruchterme

Level1 of Fractional Equation.
New util: fracTex (number,number) => Fraction Latex

Thanks
Von meinem Xperia™ von Sony-Smartphone gesendet
---- alimfeld schrieb ----
@.*** commented on this pull request.

@@ -0,0 +1,306 @@
+import { ProblemGenerator } from "../ProblemGeneratorSpi";
+import { randomInt } from "../util/randomizer";
+import { calculategcd } from "../util/commonDivisor";
+import { SortByAlpha } from @.***/icons-material";

+interface Params {

Maybe something like this:
type fractionalTerm = {
   b: number;
   c: number;
   d: number;
}

type Params = {
   terms: fractionalTerm[];
   solutions: number[];
   pols: number[];
}

I think type would be more suitable than interface here.
In order to get the count of solutions you can always do: params.solutions.length
Not sure what "pols" is ;-)
--
Reply to this email directly or view it on GitHub:
https://github.com/alimfeld/matherhorn/pull/27#discussion_r792581977
You are receiving this because you authored the thread.
Message ID: @.***>

OK


improve Log channel state before shutdown backend service client

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


possible simplification of pcmdi driver

I used to have code to mask bad values after mask regridding via esmf/esmp I think @dnadeau4 fixed this and this code shouldn't be needed any longer.

@doutriaux1 @zshaheen I don't understand this issue.  Is it resolved?

@gleckler1 it was mostly a memo for me to take a look if i can simplify the code. I'll double check today.

@doutriaux1   CD did you ever do this?   If y pls close.

No I didn't remove it. It's not hurting anything except maybe performance. I'll take it out next week.


Extra Credit: Stage vs. Prod Setup

It would be great to have an article that discusses setting up the app with both a stage and production environment. Are there features of the Serverless Stack that help with this, such as the notion of different environments? An extra credit article on this subject would be great.

@EisenbergEffect, That's a good idea. Two ways to specify the deployment stage:

specify in serverless.yml

...
provider:
  name: aws
  stage: dev
...

or you can specify the stage name in CLI

serverless deploy --stage dev

You can read the details here

Thanks! I need to look into lambda details a bit more to understand stages. This points me in the right direction.

Yeah definitely something we would like to add to the tutorial.


Layout: Layout shift - inner components are rendered before the layout

Describe the bug
Inner components in layout can be rendered ahead of the layout itself causing layout shift.
Reproducer
primefaces-test.zip
Main xhtml:
<!DOCTYPE html>

    <h:head>
        <title>PrimeFaces Test</title>
    </h:head>
    <h:body>

		<pe:layout fullPage="false">
		 	<pe:layoutPane position="west">

test

		    </pe:layoutPane>

		    <pe:layoutPane position="center">

		    </pe:layoutPane>
		 </pe:layout>
    </h:body>

Environment:

PF Version: 10.0

To Reproduce
Steps to reproduce the behavior:

mvn clean jetty:run
Go to http://localhost:8080/primefaces-test/
Refresh the page and see if there's flickering

Expected behavior
The layout should be rendered before the inner components, layout shift shouldn't happen.

As a closer look, we can see at some point the layout hasn't been rendered yet while the inner components are rendered before the layout. Let's see if this is a known issue or there's something I missed :eyes: .

I think this is the way the PFE layout has always worked.  Because its a years newer version than the old PF one it supports responsive displays so I believe it is rendering the inner panels first to know for responsiveness and screensize whether they should start open or not.  @GedMarc any thoughts?

Can you try this version:
pfe-500.zip
It implements MOVES_SCRIPTS_TO_BOTTOM and a Jquery trick from this ticket:  https://github.com/primefaces-extensions/primefaces-extensions/issues/498

Updated reproducer:
pfe-500-updated.zip

Thanks @melloware. The updated reproducer is working fine. It was not intuitive to make this work so that's awesome to know such trick. I put a summary of what has changed in the reproducer compared to the original file

Include the following layout.js with the fix below

https://github.com/primefaces-extensions/primefaces-extensions/commit/59a9d5a0b2af3c52d9600ecb34b6d6e36f3784c7

Using:

<context-param>
        <param-name>primefaces.MOVE_SCRIPTS_TO_BOTTOM</param-name>
        <param-value>true</param-value>
    </context-param>

include the following js

 $(document).ready(function () {
                // show the HTML pane after everything has been asjusted
                // https://stackoverflow.com/questions/9550760/hide-page-until-everything-is-loaded-advanced/9551066
                document.getElementsByTagName("html")[0].style.visibility = "visible";
});

include the following css:

html {
    overflow: auto !important;
    visibility: hidden;
}

Thank you for documenting. The layout fix i had to make will be in 10.0.4

10.0.4 is in Maven Central now!


F6 Abide - force certain hidden field(s) to validate

Hi guys,
Bit of a strange one this, not a bug, but instead trying override the default Abide behaviour.  I have some hidden fields such as the one below
<input type="hidden" name="event_class_name" id="event_class_name" value="" required>Please choose a class

These fields are auto-populated (via JS) based on a user's selection within a table of event classes.  I appreciate that the default behaviour of Abide is to ignore 'hidden' fields but is there any way to override this?  If not anyway to hook into the validating (ie. before formvalid or forminvalid) process to get it to manually check these specific required 'hidden' fields?
Cheers,
Will

You can simply hide the input with CSS instead of making it type="hidden":
<input type="text" class="hide" required>Error message that is not hidden

@webdevan great solution...now why didn't I think of that...? :-)
Thanks,
Will


Firebase Connection Issue

I'm not able to fix this issue. Please help ....
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hello! A PR is not the right venue to raise an issue. You can file a bug or ask for help on one of our community channels.


Issue with where() causing exception

Hello,
When i add the clause where() to a query (tested with select and update) i got an exception
EXCEPTION

Argument 1 passed to NilPortugues\Sql\QueryBuilder\Builder\GenericBuilder::write() must implement interface NilPortugues\Sql\QueryBuilder\Manipulation\QueryInterface, instance of NilPortugues\Sql\QueryBuilder\Syntax\Where given, called in xxxxxxxxx

OK
$builder = new \NilPortugues\Sql\QueryBuilder\Builder\GenericBuilder();
$q1 = $builder->select()->setTable($tableName);
$sql = $builder->write($q1);

NOT OK
$builder = new \NilPortugues\Sql\QueryBuilder\Builder\GenericBuilder();
$q1 = $builder->select()->setTable($tableName)->where()->equals('id', 1);
$sql = $builder->write($q1);

Any ideas ?

Looks like a bug to me..I'll tag it as such and look into it.
I'll keep you posted

Yup I wanted to use this script a while back but I also had the above issue.

$builder = new \NilPortugues\Sql\QueryBuilder\Builder\GenericBuilder();
$q1 = $builder->select()->setTable($tableName);
$q1->where()->equals('id', 1);

$sql = $builder->write($q1);

Works just fine. But I agree it does not feel as natural as just typing the query, that I assume it's your main concern.
The reason this was done this way is because as a builder, it should not enforce order, therefore, ->limit() can be called before ->where(), for instance.

Ok ! we need to build query in two pass :)
thank you for support


Update README to link to ex1 folder

This addresses part of #10 and changes the link in "Scripts to generate the tables in the working paper" from a link to the notebook to a link to the ex1 folder.
@MattHJensen

Closing and opening a new PR that links to the notebooks folder.


Fix code scanning alert no. 7: Use of a broken or risky cryptographic algorithm

Fixes https://github.com/apache/tsfile/security/code-scanning/7
To fix the problem, we should replace the use of the MD5 algorithm with a stronger, modern cryptographic hash function such as SHA-256. This change will enhance the security of the cryptographic operations performed by the code.

Replace MessageDigest.getInstance("MD5") with MessageDigest.getInstance("SHA-256").
Ensure that the rest of the code correctly handles the output size of SHA-256, which is 256 bits (32 bytes), compared to MD5's 128 bits (16 bytes).

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.63%. Comparing base (6c4f911) to head (ad1a4b0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #286   +/-   ##
========================================
  Coverage    63.63%   63.63%
========================================
  Files          501      501
  Lines        31787    31787
  Branches      4110     4110
========================================
  Hits         20228    20228
  Misses       11082    11082
  Partials       477      477

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add a button to refresh each page

In order to avoid abusing futbin, could you add a button for manually refreshing?
It means that the user will determine whether to refresh one page of players.

Yes I get block mostly because it refresh multiple time when it’s not necessary but if it was possible the price are updated via another server than futbin or giving lowest price since in the market + plus a button to get actual price


webpack  AOT  v2.7  Property 'loadingTemplate' does not exist on type 'LoadingComponent'.

Hi,
When i start AOT by angular-tree-component and the version  of 2.7
throughs some mistake  like this:
Starting compilation using the angular compiler. Angular compilation done, starting webpack bundling. Error: Error at /Users/kunlun/Desktop/huala-system/compiled/node_modules/angular2-tree-component/dist/components/loading.component.ngfactory.ts:40:20: Property 'loadingTemplate' does not exist on type 'LoadingComponent'. Error at /Users/kunlun/Desktop/huala-system/compiled/node_modules/angular2-tree-component/dist/components/loading.component.ngfactory.ts:167:49: Property 'loadingTemplate' does not exist on type 'LoadingComponent'. Error at /Users/kunlun/Desktop/huala-system/compiled/node_modules/angular2-tree-component/dist/components/loading.component.ngfactory.ts:170:44: Property 'loadingTemplate' does not exist on type 'LoadingComponent'. Error at /Users/kunlun/Desktop/huala-system/compiled/node_modules/angular2-tree-component/dist/components/tree-node-content.component.ngfactory.ts:49:20: Property 'treeNodeContentTemplate' does not exist on type 'TreeNodeContent'. Error at /Users/kunlun/Desktop/huala-system/compiled/node_modules/angular2-tree-component/dist/components/tree-node-content.component.ngfactory.ts:189:49: Property 'treeNodeContentTemplate' does not exist on type 'TreeNodeContent'. Error at /Users/kunlun/Desktop/huala-system/compiled/node_modules/angular2-tree-component/dist/components/tree-node-content.component.ngfactory.ts:194:44: Property 'treeNodeContentTemplate' does not exist on type 'TreeNodeContent'. Error at /Users/kunlun/Desktop/huala-system/compiled/node_modules/angular2-tree-component/dist/components/tree-node.component.ngfactory.ts:67:20: Property 'nodeIndex' does not exist on type 'TreeNodeComponent'. Error at /Users/kunlun/Desktop/huala-system/compiled/node_modules/angular2-tree-component/dist/components/tree-node.component.ngfactory.ts:74:20: Property 'treeNodeContentTemplate' does not exist on type 'TreeNodeComponent'. Error at /Users/kunlun/Desktop/huala-system/compiled/node_modules/angular2-tree-component/dist/components/tree-node.component.ngfactory.ts:81:20: Property 'loadingTemplate' does not exist on type 'TreeNodeComponent'.
Thank you

Similar situation. Though I'm getting errors only regarding TreeNodeComponent:
Property 'nodeIndex' does not exist on type 'TreeNodeComponent'
Property 'treeNodeContentTemplate' does not exist on type 'TreeNodeComponent'
Property 'loadingTemplate' does not exist on type 'TreeNodeComponent'

Moreover: ...\node_modules\angular2-tree-component\dist\components\tree-node.component.d.ts really doesn't contain those props

Add the missing properties to the type definition file(workaround) and recompile. This should solve the issue.

There is also one more workaround - just take all files from lib directory, include in your project and build with your source code. Works for me.

i also solved this mistake by adding that property ,but i want find  another way

Hey,
True, there's a weird mismatch between .d.ts and compiled.
I'll look into it

Fixed in 2.8.0.
Please verify

thanks   i 'll have a try later


Zerofox Alerts: Feature - Add modify notes

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[x] Testing of all the changes has been performed (for bug fixes / features)
[ ] The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[ ] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[ ] Verify all checks are passing.
[x] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[x] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[ ] New App
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[ ] If you are exposing any endpoints using a REST handler,
please document them in the manual_readme_content.md.
[ ] If this is a new connector or you are adding new actions

[ ] Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
with the service that the connector is integrating with.
[ ] If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.

[ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[ ] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
the Vault API.
[ ] Are you are marking code to be ignored by Semgrep with nosemgrep?
If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

@lderequesensS  you can set the request ready for review

Hi @lderequesensS.
We are not able to push changes to this repository. Seems like a permission issue. Could please look into this issue from your end?

Hi @gdelavadiya-crest, you should have write access now, try again.

Hi @stutib-crest @mmomin-crest  is there anything left in this PR before merge?


Allow relative lua modules at runtime

Description of changes
I have made some changes to allow for relative lua package imports. This addresses the following two issues:

https://github.com/NixOS/nixpkgs/issues/113110
https://github.com/NixOS/nixpkgs/issues/189689

I decided to set these directly on the definitions of the lua / luajit derivations, so it's still possible to build versions of these packages that follow the previous, stricter path logic. I still think it makes sense to set these by default so that lua scripts are more easily portable (which in my mind is a nod to the fact that it's quite common to see lua scripts distributed without any package manager, but just as a tarball of a bunch of files).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Upon further testing I see that some of the issues have already been adressed in previous work it seems:
# 2873a731 == nixpkgs-unstable at the time of writing

echo "print(package.path)" | nix run github:NixOS/nixpkgs/2873a731#lua
# ./share/lua/5.2/?.lua;./?.lua;./?/init.lua
echo "print(package.path)" | nix run github:NixOS/nixpkgs/2873a731#lua5_1
# ./share/lua/5.2/?.lua;./?.lua;./?/init.lua
echo "print(package.path)" | nix run github:NixOS/nixpkgs/2873a731#lua5_2
# ./share/lua/5.2/?.lua;./?.lua;./?/init.lua
echo "print(package.path)" | nix run github:NixOS/nixpkgs/2873a731#lua5_3
# ./share/lua/5.2/?.lua;./?.lua;./?/init.lua
echo "print(package.path)" | nix run github:NixOS/nixpkgs/2873a731#lua5_4
# ./share/lua/5.2/?.lua;./?.lua;./?/init.lua
echo "print(package.path)" | nix run github:NixOS/nixpkgs/2873a731#luajit
# ./share/lua/5.2/?.lua;./?.lua;./?/init.lua
echo "print(package.path)" | nix run github:NixOS/nixpkgs/2873a731#luajit_2_0
# ./share/lua/5.2/?.lua;./?.lua;./?/init.lua
echo "print(package.path)" | nix run github:NixOS/nixpkgs/2873a731#luajit_2_1

I encountered the issue like this (fennel is a lisp-like that compiles to lua and it's distributed as a lua package):
# formatted for clarity:
nix run github:NixOS/nixpkgs/2873a731#lua.pkgs.fennel -- -e '(. package :path)'
# /nix/store/psx2jaqhvnizbn6sraapdc8afl2d77xv-fennel-luarocks-config.lua/share/lua/5.2/?.lua
# /nix/store/psx2jaqhvnizbn6sraapdc8afl2d77xv-fennel-luarocks-config.lua/share/lua/5.2/?/init.lua
# /nix/store/nb3wjqhykfd6f3pds9smxdr1xfc4pwaw-luarocks-3.9.1/share/lua/5.2/?.lua
# /nix/store/nb3wjqhykfd6f3pds9smxdr1xfc4pwaw-luarocks-3.9.1/share/lua/5.2/?/init.lua
# /nix/store/3dgc655m12q6x1prf8jp1386vwgwgv2c-lua5.2-fennel-1.3.1-1/share/lua/5.2/?.lua
# /nix/store/3dgc655m12q6x1prf8jp1386vwgwgv2c-lua5.2-fennel-1.3.1-1/share/lua/5.2/?/init.lua
# /home/arne/.luarocks/share/lua/5.2/?.lua
# /home/arne/.luarocks/share/lua/5.2/?/init.lua

My LUA_PATH and LUA_CPATH are empty, so this is the default behavior. This is the result of the above command after my patch:
/nix/store/a5a7d7l9ckqw63h80zhjpx8i671gappv-fennel-luarocks-config.lua/share/lua/5.2/?.lua
/nix/store/a5a7d7l9ckqw63h80zhjpx8i671gappv-fennel-luarocks-config.lua/share/lua/5.2/?/init.lua
/nix/store/d97swj4m7mhq64wmix69bk5vn9kjdakl-luarocks-3.9.1/share/lua/5.2/?.lua
/nix/store/d97swj4m7mhq64wmix69bk5vn9kjdakl-luarocks-3.9.1/share/lua/5.2/?/init.lua
./?.lua
./?/init.lua
/nix/store/6m9qq5k0sn0sm5fixy1lbbc0hik3lxl7-lua5.2-fennel-1.3.1-1/share/lua/5.2/?.lua
/nix/store/6m9qq5k0sn0sm5fixy1lbbc0hik3lxl7-lua5.2-fennel-1.3.1-1/share/lua/5.2/?/init.lua
/home/arne/.luarocks/share/lua/5.2/?.lua
/home/arne/.luarocks/share/lua/5.2/?/init.lua

@teto i saw you in a couple of lua issues. can you provide some feedback over whether this is useful at all, or is this misguided? see https://github.com/NixOS/nixpkgs/pull/273342#issuecomment-1848979662 for a closer description of what's happening.

sry for the delay. First of all thanks for trying to address the issue ! Happy to see folks trying to improve the lua ecosystem.
What I would like to see is a test in pkgs/development/interpreters/lua-5/tests/default.nix to check for the behavior you want (even as a separate PR).
I dont know how involved you want to be but to limit the issues mentioned at https://github.com/NixOS/nixpkgs/issues/189689 I think it would be great to have luajit be expressed as an overrideAttrs of the default lua interpreter maybe ? that would limit the drift between the 2 and might help with solving the issue.
pkgs/development/interpreters/lua-5/interpreter.nix
pkgs/development/interpreters/luajit/default.nix

@teto thanks for your feedback! i added some tests locally. can you help me figure out how to run them so i don't have to do the git-push-wait-for-ci-to-fail-git-commit-ammend-force-push-dance?
diff --git a/pkgs/development/interpreters/lua-5/tests/assert.sh b/pkgs/development/interpreters/lua-5/tests/assert.sh
index fe5582a0b062..328c4ee7f93a 100644
--- a/pkgs/development/interpreters/lua-5/tests/assert.sh
+++ b/pkgs/development/interpreters/lua-5/tests/assert.sh
@@ -14,3 +14,9 @@ function assertStringEqual {
         fail "Strings differ"
     fi
 }
+
+function assertStringContains {
+    if ! echo "$1" | grep -q "$2" ; then
+        fail "String does not match"
+    fi
+}
diff --git a/pkgs/development/interpreters/lua-5/tests/default.nix b/pkgs/development/interpreters/lua-5/tests/default.nix
index 38479af5f207..02b9e124f0d1 100644
--- a/pkgs/development/interpreters/lua-5/tests/default.nix
+++ b/pkgs/development/interpreters/lua-5/tests/default.nix
@@ -27,6 +27,10 @@ let
         wrapLuaPrograms
       '';
     });
+
+    luaWithModule = lua.withPackages(ps: [
+      ps.lua-cjson
+    ]);
 in
   pkgs.recurseIntoAttrs ({

@@ -40,11 +44,22 @@ in
       '';
   };

-  checkWrapping = pkgs.runCommandLocal "test-${lua.name}" ({
+  checkWrapping = pkgs.runCommandLocal "test-${lua.name}-wrapping" ({
     }) (''
       grep -- 'LUA_PATH=' ${wrappedHello}/bin/hello
       touch $out
     '');

+  checkRelativeImports = pkgs.runCommandLocal "test-${lua.name}-import" ({
+    }) (''
+      lua_vanilla_package_path=$(${lua}/bin/lua -e "print(package.path)")
+      lua_with_module_package_path=$(${luaWithModule}/bin/lua -e "print(package.path)")
+
+      assertStringContains "$lua_vanilla_package_path" "./?.lua"
+      assertStringContains "$lua_vanilla_package_path" "./?/init.lua"
+
+      assertStringContains "$lua_with_module_package_path" "./?.lua"
+      assertStringContains "$lua_with_module_package_path" "./?/init.lua"
+    '');
 })

I'm afraid I'm not deep enough into either lua or nix packaging to unify the lua / luajit packages as you described

All good, figured it out! I opened a nix repl in the base of this repo and was able to run the test like this:
nix build .#lua.tests.checkRelativeImports

At one point I decided to patch the lua interpreter to change the default LUA_PATH. Patching upstream software might not have been the correct call and might have created your issue. Not sure if I want to rollback this yet, or make it configurable.

I removed the patch and hopefully simplified the way LUA_PATH / LUA_CPATH is configured in the process. This means the path can be configured by overriding LuaPathSearchPaths / LuaCPathSearchPaths if I didn't do anything silly

Do you mind if I merge your code in new PRs ?
I would like to merge your changes to tests first, and then fix up things differently.
If I run from ubuntu
lua -e "print(package.path)"
./?.lua;/usr/local/share/lua/5.1/?.lua;/usr/local/share/lua/5.1/?/init.lua;/usr/local/lib/lua/5.1/?.lua;/usr/local/lib/lua/5.1/?/init.lua;/usr/share/lua/5.1/?.lua;/usr/share/lua/5.1/?/init.lua

so we are just missing ?.lua from default LUA_PATH.

I don't mind at all! I just ran your command on CentOS 7 and it looks like you're right. Only ./?.lua is missing by default,

i've stumbled across this again, and while it seems like lua is fixed, luajit most certainly is not.

i belive i found the underlying bug that stops this from working, it can affect both luajit and lua5.

@heyarne sry it took so long but this should be fine on master. Thanks to your contributions and @lolbinarycat  we now have some more tests https://github.com/NixOS/nixpkgs/blob/c67ab4eed2b3acd301748495b380437e0ba127d1/pkgs/development/interpreters/lua-5/tests/default.nix#L45 .  feel free to open an issue if it's not good yet.


Bad autocomplete when i use namespace class or static class

Hi @bmewburn ,
I have class with namespace , see: https://goo.gl/1m6B7J
(namespace: Nette\Diagnostics  , class: Debugger,  method: barDump)
In another class (ProjectPreseterClass) im calling this NS and get full list of variables of ProjectPreseterClas and its not exist relevant suggestion for Debugger class, see:
(My personal opinion is that should offer namespaces under Nette namespace at first and then classes in Nette namespace. Does it make  sense? :))

https://goo.gl/EjXuY6
https://goo.gl/yfXwhx
https://goo.gl/votY2T  (Debugger is in list, but after local variables of ProjectPresenterClass, its not good suggestion, and further it would be good to differ it with a special icon (to be clear that it is a class, not a variable))
https://goo.gl/Xeucvp (where are methods for Debugger class? Again somewhere behind local variables of ProjectPresenterClass),

This behavior is not very good and intuitive, is possible to change or set it?
====
Same problem with Singleton Class
See: https://goo.gl/AJNp3i
and calling in another php file https://goo.gl/Z1RBXe (no suggestion)
Thx for explanation.
PS. Of course I appreciate your work, but it would be great to improve it.

Available in next release.

Next release will be launched when?
Relase of  VSC plugin depends on release VSC editor or not?


tomato-c: 2023-8-21 → 2024-4-19

Requested in #346890
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

darwin failure expected https://hydra.nixos.org/build/274700951


No hatch environment seen in select environment QuickPick

Testing #23088
Platform: Windows
Follow the steps in the TPI. After running hatch run python -V and waiting for it to finish. Run Select interpreter command, it takes some time to refresh environments. But the hatch environment is not seen,

From logs:
2024-03-25 11:17:18.682 [info] > hatch env show --json
2024-03-25 11:17:18.682 [info] cwd: .
2024-03-25 11:17:19.195 [info] > hatch env find default
2024-03-25 11:17:19.195 [info] cwd: .

From command line:
> hatch env find default
C:\Users\kanadig\AppData\Local\hatch\env\virtual\something\XIyUl07c\something

This might be a bug is hatch itself, from VS Code with same CWD hatch returns: C:\Users\kanadig\AppData\Local\hatch\env\virtual\something\Lwno8mvj\something
The issue seems to be that VS Code (node APIs) use lowercase for Drive letters, the CWD set while running this might have lowercase drive letter and that might be changing the hash.

Yep I discovered the same issue while debugging, this was previously encountered with poetry as well: https://github.com/python-poetry/poetry/issues/3829. Opened an issue on Hatch while incorporating the same workaround as Poetry.

Upstream issue https://github.com/pypa/hatch/issues/1350

This is working now.


Razor Views do not recompile when directories with large numbers of files are present in the project tree

First off, I've been tearing my hair out for the past few hours trying to figure out what's causing this so if this isn't the right repo to report this in, feel free to move it.
Problem
If the material-design-icons package from npm is present in the node_modules directory, Razor templates do not get compiled on subsequent requests. This seems to be some limit with the number of files in the project tree. This package has 89,814 files in it. I was able to reproduce this by creating 10,000 empty files in a directory:
1..10000 | ForEach-Object { New-Item -ItemType File -Path foo -Name ([Guid]::NewGuid().Guid.ToString()) | Out-Null }

Removing this package (and my test folder if I created it) causes views to be recompiled on new requests after they are modified on disk.
Steps to Reproduce

Create a new MVC project: dotnet new mvc
Create 10000 empty files in a folder in the project:

mkdir foo
1..10000 | ForEach-Object { New-Item -ItemType File -Path foo -Name ([Guid]::NewGuid().Guid.ToString()) | Out-Null }

linux: for i in {1..10000}; do mktemp -p foo > /dev/null; done

dotnet run
Open http://localhost:5000 in a browser
Modify Views/Home/Index.cshtml and reload the page in the browser

Expected Result: The view is recompiled and updated after the page reloads
Actual Result: The request returns almost instantly and is not updated. No warnings are printed in the console with the standard project template.
Attempted Workaround
After removing my test folder, I tried the following to exclude the node_modules folder from consideration in hopes that it would be ignored when views should be recompiled:
  <ItemGroup>
    <Compile Remove="node_modules\**" />
    <Content Remove="node_modules\**" />
    <EmbeddedResource Remove="node_modules\**" />
    <None Remove="node_modules\**" />
  </ItemGroup>

  <PropertyGroup>
    <DefaultItemExcludes>$(DefaultItemExcludes);node_modules\**\*.*</DefaultItemExcludes>
  </PropertyGroup>

This had no effect: after modifying views on disk, I had to ctrl+c and run dotnet run again for the view to update.
Question
Is there a way to exclude the entire node_modules folder from the system? I am using webpack and don't need access to it at runtime. This seems like a really easy limit to hit on any project that uses a decent amount of frontend packages from npm.

@nlowe what OS \ platform did you see this issue in? We had report of an issue on CentOS where the FileSystemWatcher was getting overwhelmed when the app had a large number of files and stopped reporting changes. One workaround to unblock you in the meanwhile is to enable polling to detect file system changes. Set this environment variable DOTNET_USE_POLLING_FILE_WATCHER=1 and run the app. Perhaps that might help.
The work to investigate here is to figure out if we're adding a watcher that listens to the node_modules directory at runtime and see if there's a reasonable solution that avoids doing this.

I'm on Arch Linux. I don't have access to my machine right now but I'll test that out and get back to you.

@pranavkm setting that environment variable seems to work for my use case. Would this be a bad thing to set in a bash profile so I don't have to remember to set it every time?

@nlowe there's a small amount of extra I/O involved when you request a view. I would avoid using this in a production environment, but it's entirely harmless locally. In fact, setting this flag up is a staple of container based development workflows.

Good to know.

The work to investigate here is to figure out if we're adding a watcher that listens to the node_modules directory at runtime and see if there's a reasonable solution that avoids doing this.

Is there anything you need me to try regarding this?

@nlowe not at this point. We'll bother you if we are unable to reproduce the issue. I'll leave the issue open so we can track the work.

@pranavkm, was there any investigation done here?

I tried this on Ubuntu 16.04 back in December, but I couldn't reproduce the issue. At least it didn't seem like the issue was inherent to the way xplat does file system watching.

@stephentoub would you know if there's a hard limit on the number of files that can be present in a directory on Centos \ ArchLinux for the FileSystemWatcher stops producing change events?
 We should consider baking in polling alongside events from FSW. It's the only way to guarantee eventual consistency.

We should consider baking in polling alongside events from FSW. It's the only way to guarantee eventual consistency.

This a million times.
If you're in a dev environment, it's ok if the filewatcher approach works 99.9% of the time.
If you're using this production then you will have problems, and I don't think we should spend time trying to make it foolproof.

If you're using this production then you will have problems

This would play well with https://github.com/aspnet/Mvc/issues/6643 feature. Have it be off for users that don't care about reloading views in production, but have a setting that turns it on.

would you know if there's a hard limit on the number of files that can be present in a directory on Centos \ ArchLinux for the FileSystemWatcher stops producing change events?

FileSystemWatcher uses inotify on Linux.  I'm not aware of any limit on the number of files, but there are several other limits, which you can both see and set via procfs:

http://linuxinsight.com/proc_sys_fs_inotify_max_queued_events.html
http://linuxinsight.com/proc_sys_fs_inotify_max_user_instances.html
http://linuxinsight.com/proc_sys_fs_inotify_max_user_watches.html

The following is not directed at @nlowe  .... 😆

I feel like we need a standard response to these issues, or documentation, or to make the polling file-watcher the default. We know that file watching is a best-effort mechanism. We (MVC) also don't directly control any of these things and we can't react to them.
I think we should set the expectation that you shouldn't rely on the filewatcher in production.

Closing this issue in favor of https://github.com/aspnet/Home/issues/3135


Datapath work for adding bpf metrics map

This PR adds the ground work needed to support prometheus L3/L4 packet drops and forwards.
This adds the data path bits in place.
Fixes: #4155
Related-to: #3284
Related-to: #3337
Datapath work for adding bpf L3-L4 drop/forward metrics map

test-me-please

test-me-please

@tgraf Made changes as discussed offline yesterday. Please take a look.

Doesn't look like  this CI test flake is related to my changes:
Opened GH issue #4180 @ianvernon @eloycoto
5:27:57 Running Suite: runtime
15:27:57 ======================
15:27:57 Random Seed:<PHONE_NUMBER>
15:27:57 Will run 58 of 285 specs
15:27:57
15:27:57 RuntimeValidatedConnectivityTest Basic Connectivity test
15:27:57 Test connectivity between containers without policies imported
15:27:57 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:338
15:30:36
15:30:36 • Failure in Spec Setup (BeforeEach) [153.726 seconds]
15:30:36 RuntimeValidatedConnectivityTest [BeforeEach]
15:30:36 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:306
15:30:36 Basic Connectivity test
15:30:36 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:306
15:30:36 Test connectivity between containers without policies imported
15:30:36 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:338
15:30:36
15:30:36 error starting VM "runtime": exit status 1
15:30:36

test-me-please

test-me-please

test-me-please

test-me-please

@joestringer @tgraf @jrfastab Addressed review comments. Please take a look

test-me-please

Gingko tests passed.

test-me-please

On 21 May 2018 at 13:00, Manali Bhutiyani<EMAIL_ADDRESS>wrote:

@manalibhutiyani commented on this pull request.
In bpf/lib/trace.h
https://github.com/cilium/cilium/pull/4156#discussion_r189697091:

@@ -100,6 +101,20 @@ static inline void send_trace_notify(struct __sk_buff *skb, __u8 obs_point, __u3
.ifindex = ifindex,
};

switch (obs_point) {

case TRACE_TO_LXC:

case TRACE_TO_HOST:

case TRACE_TO_STACK:

case TRACE_TO_OVERLAY:

	update_metrics(skb->len, DIRECTION_INGRESS, REASON_FORWARDED);

	break;

/* TRACE_FROM_LXC is handled separately in ipv*_local_delivery() */

case TRACE_FROM_HOST:

case TRACE_FROM_STACK:

case TRACE_FROM_OVERLAY:

	update_metrics(skb->len, DIRECTION_EGRESS, REASON_FORWARDED);

I think I can still use send_trace_notify but the logic should change
like so:
static inline void send_trace_notify(struct __sk_buff *skb, __u8 obs_point, __u32 src, __u32 dst,
__u16 dst_id, __u32 ifindex, __u8 reason)
{
switch (obs_point) {
case TRACE_TO_LXC:
  	update_metrics(skb->len, DIRECTION_INGRESS, REASON_FORWARDED);
  	break;

  /* TRACE_FROM_LXC is handled separately in ipv*_local_delivery() */
  case TRACE_TO_HOST:
  case TRACE_TO_STACK:
  case TRACE_TO_OVERLAY:
  	update_metrics(skb->len, DIRECTION_EGRESS, REASON_FORWARDED);

}
}
This way TRACE_TO_LXC is specifically forwarded to endpoint successfully
at ingress and rest all TRACE_TO* (leaving out the PROXY cases) will be
forwarding at egress.
We need to handle the special case of endpoint to endpoint i.e egress
forwarding at ipv*_local_delivery()
Is that correct? DBG_CAPTURE_DELIVERY is selectively called via
send_trace_notify when we are only concerned with endpoints.
Please let me know if that's the correct logic, i.e we can simply change
send_trace_notify and not cilium_dbg_capture since send_trace_notify is a
subset of all the meaningful datapoints we need from cilium_dbg_capture/
DBG_CAPTURE_DELIVERY
If this is still incorrect, I would like to schedule a call to discuss
this further to avoid further delay on my part in understanding this.

We just walked through this, the cases above are handled correctly. It
doesn't handle the TRACE_TO_PROXY case, but we can defer that for now.
Regarding TRACE_TO_PROXY, it's not obvious whether we should be
incrementing the "forwarded" metric on egress at the TRACE_TO_PROXY
point, as there will be other metrics that count the packet when it drops /
passes through the L7 proxy. We could choose to count in LXC on the way to
the proxy, in bpf_netdev on the way out from the proxy (before deciding
to forward to tunnel / tail call another bpf_lxc / etc), or not at all
from BPF (and rely on the forwarded metric done in the proxy).

@tgraf @joestringer Made changes as per discussion offline.Could you please take a look and let me know if things look ok? Also, would like to start working on the controller side of things if the datapath bits look fine. Please let me know.

test-me-please

Spoke offline to @joestringer offline on this. This is probably a bug in the generic bpf map insertion which ignores all zero keys or a bug in bpf map traversal which ignores all zero keys.
In the interest of time, I am changing the direction ingress = 1 and egress = 2 and number of bits = 2 to make the map keys a non zero value and correctly get inserted in the map.

@tgraf @joestringer  Made changes. Tested. Works as expected. Please take a look.

test-me-please

test-me-please

test-me-please

test-docs-please

test-me-please

@aanm reported that he could not approve the PR because of the number of comments. Hence closing this one and opening a new PR. All review comments have been addressed.


Fix Deletion of MeshSync Resources

Description
Expected Behavior
Screenshots
Contributor Resources
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

@utkarsh-pro I'm creating this issue from a previous note taken about synchronization issues in removing stale resources. Are you able to expound on the issue's description? take it on?

Yes @leecalcote. I am assigning this issue to myself.

Hey, @utkarsh-pro are you on it still?

Hi, @manav1403 unfortunately I have been severely sick for past few days so I haven't been able to focus here yet although I do intend to, If this interests you, please take this up.
// @leecalcote

Ugh. I'm very sorry to hear this, @utkarsh-pro. I hope that you're feeling better soon. 🤒


Support pulling prebuilt ruby

This currently supports building ruby from source and using ruby from host. Building ruby from source can be slow and has to be redone every time we upgrade our clang compiler. ruby coming from the host machine is outdated and is often incompatible with newer gems; it also creates a room for non-hermetic builds. It would be nice if this can have support for pulling prebuilt ruby binaries based on the host platform.

Looking for additional core maintainers: https://github.com/bazelruby/rules_ruby/discussions/146


Question Regarding Update to Google Play Billing Library Version 6

I received a notification from Google stating that all new apps and updates to existing apps must use Google Play Billing Library version 6 or higher by August 31, 2024. They mentioned that from that date, any apps using versions lower than 6 will be blocked from publishing and updates.
Could you please let me know when React Native IAP will support Google Play Billing Library version 6? This update is crucial for us to continue publishing our app without interruptions.

Same here, waiting for updates to this post.

It looks like recent releases of react-native-iap already use version 6.x of the billing library.  See the definition of RNIap_playBillingSdkVersion here:
https://github.com/dooboolab-community/react-native-iap/blob/12.13.2/android/gradle.properties
Is there reason to believe otherwise?

@cddceo:  Interesting.  For what it is worth, I do not see a warning message in Google Play Console for my app.

@MarkCSmith
I got a hint from what you said.
I'll delete all node modules, update them again, and upload them back to the store.

I have updated my app and using the latest version of this library. Also uploaded the app but still the play console shows me the policy message.

also here

Me too. Has anyone found a solution?

I got same issue.

Hello everyone,
Could anyone test the 12.14.1-rc.1 release candidate and see if it works?
You can simply install the next version with the following command:
npm install react-native-iap@next

You can see the update in #2764

If anyone has some time, could you please review #2764? Thank you!

i believe that need change version at android/app/build.gradle
dependencies {
    def billingVersion = 7.0.0

    implementation "com.android.billingclient:billing:$billingVersion"
}

So I don't know if version 7 is supported yet
https://developer.android.com/google/play/billing/migrate-gpblv7?hl=pt-br

i believe that need change version at android/app/build.gradle
dependencies {
    def billingVersion = 7.0.0

    implementation "com.android.billingclient:billing:$billingVersion"
}

So I don't know if version 7 is supported yet
https://developer.android.com/google/play/billing/migrate-gpblv7?hl=pt-br

I think this is done here https://github.com/dooboolab-community/react-native-iap/pull/2764/files#r1640807011.
Am I missing something?

updating to 12.15.1 worked for me, just took google a few minutes to remove the warning message. make sure to update and roll out on all release tracks including internal testing.

working for me too, but I needed to update react native to 0.74

working for me too, but I needed to update react native to 0.74

may i know what is your react native version and kotlinVersion ?

working for me too, but I needed to update react native to 0.74

may i know what is your react native version and kotlinVersion ?

    "react-native": "0.74.3",
'android/build.gradle'

buildscript {
   ext {
       buildToolsVersion = "34.0.0"
       minSdkVersion = 24
       compileSdkVersion = 34
       targetSdkVersion = 34
       ndkVersion = "26.1.10909125"
       kotlinVersion = "1.9.22"
   }
   repositories {
       google()
       mavenCentral()
   }
   dependencies {
       classpath("com.android.tools.build:gradle")
       classpath("com.facebook.react:react-native-gradle-plugin")
       classpath("org.jetbrains.kotlin:kotlin-gradle-plugin")
   }
}

apply plugin: "com.facebook.react.rootproject"

`android/app/build.gradle
`

apply plugin: "org.jetbrains.kotlin.android"

If I'm stuck on RN 0.68.5 for the next few months, do I have any solutions?


Spinlocks need queueing

Describe the bug
Due to the severely varying iteration times of all the threads, some threads never get the chance to lock because they're too slow. A queue would help slower threads get a chance at locking as well.
Expected behaviour
Locking a spinlock should not take minutes.
Additional context
Run feature/window enough times and sometimes the windows won't get created or won't respond. either the rendering or input threads have gotten stuck on a spinlock. if you pause the program you'll pause inside a spinlock.

turns out the observed issue had nothing to do with the spinlock


Do not force using a profile and fallback to the default session chain

What about opening a PR upstream?


Changing infura account because of daily request limits

Refs keep-network/tbtc#703
Infura threw "daily request count exceeded" error. In this PR we are replacing existing with a new one to run e2e summary report.

good idea! will change it in the other PR


laravel 5.3 - issues

route middleware and "routeNeedsRole" method not working.
BadMethodCallException in Macroable.php line 74: Method filter does not exist.

I assume that entrust does not support laravel 5.3 now,
you can use laratrust

@paulcocis did you get a solution? facing the same issue here.

+1

@paulcocis @kevosomi I have the same problem. what's the solution?

Yes,Route::filter() was removed. I use Middleware take the place of Route filters.


compile failed , report the error which macro undefined

main.c:2241:14: error: ‘SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR’ undeclared (first use in this function)
SDL_SetHint(SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR, "0");

#ifdef SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR
  SDL_SetHint(SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR, "0");
#endif

#ifdef SDL_HINT_MOUSE_FOCUS_CLICKTHROUGH
  SDL_SetHint(SDL_HINT_MOUSE_FOCUS_CLICKTHROUGH, "1");
#endif


Transferring selection between editorStates

I'm building a component that uses the Editor component internally but only exposes the text content, not its selection state. Let's call this component CustomInput and have a look at following example:
class Example extends React.Component {
  state = {
    text: 'initial text',
  }
  render () {
    return <CustomInput value={this.state.text} onChange={text => this.setState({ text }) />
  }

The Example component does not care about the selection state of the CustomInput, just like
it should not care if it were using the standard html input component. It just cares about the value
of the edited text, which it can set and get via value and onChange respectively.
To accommodate this, the CustomInput has to be able to accept new values and inject them into the
editorState:
@autobind
class CustomInput extends React.Component {
  static propTypes = {
    value: React.PropTypes.string,
    onChange: React.PropTypes.func,
  }

  constructor(props) {
    // create the initial editorState
    const content = ContentState.createFromText(props.value || '')
    const editorState = EditorState.createWithContent(content)
    this.state = {
      editorState
    }
  }

  onChange (editorState) {
    // propagate the string value
    this.props.onChange(editorState.getCurrentContent().getPlainText())
  }

  componentWillReceiveProps (nextProps) {
    // get in the new value
    if (this.props.value !== nextProps.value) {
      const content = ContentState.createFromText(nextProps.value || '')
      const editorState = EditorState.createWithContent(content)
      // todo: transfer selectionState
      this.setState({
        editorState
      })
    }
  }

  render () {
    return <Editor editorState={this.state.editorState} onChange={this.onChange) />
  }

I'm creating a new editorState every time the value props changes. This is a problem because the
selectionState of the editorState depends on the opaque keys of the contentState. Transferring the
selection state is impossible:
const oldState = this.state.editorState
const selection = oldState.getSelection()
const newState = /* ... create new state ... */
const newStateWithSelection = EditorState.forceSelection(newState, selection)
// this doesn't work because the selectionState refers to keys in the oldState
// the keys in the newState are different

Note that these are simplified examples, in my real CustomInput I'm using several decorators
to annotate the code.
Do you guys have any tips on how to move forward on this? Is my intention misguided?
I've considered building a simple version of draftjs that only has the decorators and that uses deterministic keys for the contentState so the selectionState can be shared, but that feels like
overkill.

any ideas on this?

@romeovs I have the similar issue. Did you solve it?


Using FunctionApp instead of DaprFunctionApp according to changes in Python V2 library

@ASHIQUEMD - I can see that you have merged the changes yourself, can you please add the description in pull request what is the change you are making and why did you revert the DAPRFunctionApp to FunctionApp?


Adding bootstrap alert messages

@coding-geek21 Closing this as this is already listed and a PR for the same is under review. :)