Current Status

Hello, i'm a developper in the Godot team and was assigned to research Network API. I just realized this module exists, can you tell me about the current status of this module?

Great, I'm glad you've decided to pick up the torch! I was going to help with the Godot networking stack, but I've become to busy with other things. So, if there's any questions you want to ask pertaining to network programming in Godot (or Juan's unreasonable expectations), don't hesitate to ask and I will do my best to answer. I will leave this issue open for that purpose.
As for this module, it's currently only being maintained and is not under active development. Juan does NOT want to include ENet (the module this is based on) in Godot proper. The reason for this is that this module only works for UDP and there may be other protocols (e.g. for game consoles) that might need to be supported in the future (Bluetooth maybe?).
The new stack cannot use the raw socket interface because it will not support proxies on Android - this needs to be implemented in JAVA. Juan also wants the new network stack to seamlessly support stream based protocols (TCP) and packet based protocols (UDP), where the packet based protocols can handle pinging, connections, sequencing, and reliability as in ENet. He also wants RPC calls on scene tree objects (good luck!).
My advice is to start by creating a module and design an interface that works well with TCP and UDP, and write your own abstraction for the network interfaces. I would also suggest that you use a client/server model rather than peer to peer as this significantly cuts down on the complexity. Also, have a look at the code for PacketPeer(UDP) and StreamPeer(TCP) as they contain good examples of techniques used in network programming (e.g. lock-free ring buffers).
When you have all of that working, then bring it into Godot proper and start working on RPC (again, good luck... but I may have some ideas once you get that far).
Hope this helps!

What's ENet capable of itself? does it support TCP too or only UDP?
And asking your opinion from the user's point of view, how would you chose what protocol to use? Abstract is ok, but at some point the user mur have ocntrol of what's he using, this means a protocol must be used by default. I've thought on some ways Networking may be implemented:
-Nodes in the scene tree, traking, sending, retriving and setting the values of selected properties in especified nodes
-Method overloads to push and pull values on every stream phase
-All Child's of the "NetworkView" node have it's properties streamed completely and only procesed on the "Owner's" machine and reflected on the others (this is completely utopic, it needs some filtering somehow, because you can't pretend to stream all fransform animations positions, same happens when you call a function, sometimes you will want this very same function be called in the other player's computers)
I'm listening sugestions on the workflow the user may expect, GdNet module is awesome by itself, but it's still a little low level, like HttpClient class, and lacks signals to connect, because it's not a node or a resource (as long as i saw on the example)
Most importantly, how would an used select what protocols to use?
TcpClient node? UdpClient node? BluetoothClient node?
NetworkClientNode with a Protocol propertie?
How to bind clients to connections?
probably best choice are NetworkClient, NetworkConnection and NetworkServer nodes, this way the NetworkConnection and NetworkServer handles the ProtocolStack and NetworkClient's just bind to the NetworkConection they want to listen and write, but still, how should the stream travel beatwhen client and server? how do i select what NetworkClient send an specific stream? (i mean a byte array or a dictionary or whatever)
I'm all ears :P

Hi! Sorry, I've been really busy for the last week and haven't had a chance to respond until now.
I think your idea of a "NetworkView" is a good idea and could be used to attach a client or server instance to the SceneTree which would make RPC a possibility.
You will still need to support low-level network operations. I would suggest you have a look at my snapshot interpolation and state sync demos. Those are demos of how to implement networked physics, which is used in lots of games. Even these demos send variants over the network without compression (compression is why I wrote my raw packer module) which would certainly bog down the server, and perhaps the clients, in a large simulation (i.e. one with many interacting bodies). I would suggest browsing through Glen Fiedler's site (http://gafferongames.com/) before you implement anything as he is one of the foremost authorities on game networking.
I think having TcpClient, UdpClient, and BluetoothClient objects (not nodes) is a good idea, provided that the packet based protocols (UDP, and Bluethooth for now) have the ability to support pings, connections, sequencing, and reliability. If you need some basic algorithms for these features, I would be happy help if I can.

I'll start with Glen Fiedler's web page for now, i have studied the networks matter in general, but have not seen anything yet aimed to games and how to manage streams.
I'll talk again in some days if i make a discovery or need any help or if (hope not) i'm just clueless...

I think studying Fiedler's stuff is a great idea. I acquired most of my game networking knowledge from him. I think he also has some tutorials about game physics which is good to know a little bit about if you plan on implementing networked simulations.
Let's keep the lines of communication open. It's always a good idea to have someone to bounce ideas off of.


Using npm to test/update to v3.0.0-alpha

Would like to use npm install<EMAIL_ADDRESS>so I can get a jump on updating my site to the new v3.0.0-alpha adminLTE using bootstrap 4.  Are you still planning on using/updating the npm package?  (Currently have to manually update my files for adminLTE to check-out/test version 3).
Thanks for the work in updating to bootstrap 4!

Thanks for updating npm!
However to get my file compiled correctly like in v2.4.3 I had to add the line
"main": "dist/js/adminlte.min.js" to your package.json that npm pulled in.  Perhaps this could be added back into the package.json for v3-dev. ?  It shouldn't hurt anything.
I'm using laravel/webpack and without the 'main' key in your package.json to point to the correct js file I get a compile warning saying the * admin-lte dependency was not found.
With this line added I'm able to pull the 3.0.0-alpha version from npm making testing and re-coding my site much easier.  I appreciate all the work being put in to keep this package updated.

Updated datatables and added it to npm package.json. Will publish v3.0.0-alpha.2. Please close the issue if resolved. Otherwise, please let me know if it doesn't work. Thanks!


Fintune Regex for finding static content

The Regex for finding content still has some work to do. My solution works, but it feels a bit janky.
var staticContents = Regex.Matches(viewContent, @"(?<!(=>))(?<=>)(?![.,])([\s\w,.&?!'#\(]+)(.*?)")
                            .Cast<Match>()
                            .Where(x => !string.IsNullOrWhiteSpace(x.Value) &&
                                                 Regex.Match(x.Value, @"\D+").Length > 1 &&
                                                !Regex.IsMatch(x.Value, @"(if *\()"))
                             .Select(m => m.Value.Trim())
                             .ToList();

There are so many combinations on how static content is placed in views. Would like to come up a new solution to find static content that is a bit more robust and more fool proof.
In addition. It would be nice if it could:

Skip commented static content

Maybe add a HTML parser to handle this instead of regex?


Incorrect formatting of @@SESSION.time_zone

Applying format to the following query
SELECT @@GLOBAL.time_zone, @@SESSION.time_zone;

outputs the following result
SELECT
  @ @ GLOBAL.time_zone,
  @ @ SESSION.time_zone;

I'm using
"sql-formatter": "^4.0.2"

Also:
SELECT @@time_zone;

There should be no space after @.

Try to add regex on top of returned formatted string something like this formattedCode.replace(/@ @/g, "@@")

Hi, this issue is fixed in my fork here:
https://github.com/inferrinizzard/prettier-sql
https://www.npmjs.com/package/prettier-sql


[DC-1053] Cleaning Rule for fixing the unmapped survey answers

completed the cleaning rule fix_unmapped_survey_answers
added the unit test for fixed_unmapped_survey_answers
added the integration test for fix_unmapped_survey_answers

@ChaoPang just a couple comments above. But this looks good and makes sense to me if @mark-velez is good with it!
The unit and integration tests are passing for me locally, so you may just need to re-run the integration_test in CircleCI, it seems to be finicky lately.
I also wanted to ask if this cleaning rule needs to be added to the pipeline? If so, clean_cdr.py will need to be updated with this class and added to the RDR_CLEANING_CLASSES


[move] Make error message for invalid field access nicer

Description
Attempts to make the error message for an invalid field access (outside of the declaring module) a bit nicer and easier to understand.
Test Plan
Updated existing tests.

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)

[ ] protocol change
[X] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes
Made error messages for accessing struct fields outside of the declaring module nicer.

Amazing! Thanks!


Codes B301-B306 conflict with flake8-bugbear

This is related to a discussion ongoing in the flake8-bugbear repo issues: https://github.com/PyCQA/flake8-bugbear
Main points pasted below from @myii on Github:
The conflict is not with flake8-bandit but rather with openstack/bandit

There are two projects that are involved here:

    https://github.com/openstack/bandit
        Project started on 16 July 2014
        This is the main project, where the conflicts are arising

    https://github.com/tylerwince/flake8-bandit
        Project started on 29 Oct 2017
        However, this is just a wrapper around bandit
        They have no control over the error codes that are supplied by bandit

The OpenStack Bandit project has been using B30x codes for a few years as well

Taking B301 as the earliest example in both projects:

    Bandit: openstack/bandit@c364408
        This commit was made on 22 Jan 2016

    Bugbear: 0fb7d8d
        This commit was made on 8 Jun 2016

It seems that the problem is more with flake8-bandit than not. Bandit was never intended to be a Flake8 plugin, as I recall, so I didn't bother warning y'all since it didn't seem like it would ever be a problem.

Possibly fixed in https://github.com/tylerwince/flake8-bandit/commit/533ef6e3d869cee7b3a754801147d8a2a7ae1fd2 ?


Introduce working e2e test for GH Actions [WATCHER]

Description
Changes proposed in this pull request:

Introduce e2e test as pre- and post-PR job (we first decided just to have it as post-job, but since it runs as long as the smoke tests run, we can also have it as pre-job); Used already existing go e2e test suite, and fixed it
Job uses PR-Image in pre-merge run, and latest image after PR has been merged
Upgrade setup-go to v4 in smoke tests (incl. bug fixes + remove cache=true since this is default in v4)
Renamed test.yaml to smoke-test.yaml to be a bit more specific
Renamed jobs, since names like Test are not specific enough
Removed manifests kustomize from make deploy command, since they are already called in the install target, thus manifests kustomize have been run twice when calling make deploy
Set kyma-reque-success-interval in test setup to 30seconds for easier debugging
Fix local test setup guide
Fix linting in flags.go
Include more logging in e2e tests (By-steps)

Related issue(s)
#288

/wip

/wip

/test pull-lifecycle-mgr-tests

/test pull-lifecycle-mgr-tests

/test pull-lifecycle-mgr-tests

/test pull-lifecycle-mgr-tests


[BUG] Flagged as Trojan

Windows Defender marks this as a Trojan:Script/Wacatac.F!ml and is a severe threat.

Due to current budget constraints, our application is not code-signed, so Windows marked it as a virus.


Adding UI Effects to anchor or button

Hi, I wish semantic ui adding effects, i've found inspiring good resource
http://tympanus.net/Development/CreativeLinkEffects/
http://tympanus.net/Development/CreativeButtons/
proposal class sample
...
...

The technology will never moving backwards, so the browser too, I think css3 is our era, and we must applying css3 into semantic ui, I'm bootstrap and foundation user for years, if semanticui adding more values and options for frontend developers, semanticui will become more popular.
Thanks.

Does this work on anchor hover fx?


Question - how to migrate the project to .NetCore 2.0

Hi
I can see there is a tool to do that but running the solution does not help much.
Do you have the instructions please?

This project does not have migration tool, if you mean Rename.cmd it's just a script to rename the project, so you can start implementing your own project with correct namespace and project names.

Thanks for clarifying.

Is that a way to migrate to .Net core 2.0? changing target framework to netcore2.0 in csproj does give error of compatibility

Yes changing to netstandard2.0 and netcoreapp2.0 and updating package references to 2.0 shoudl be enough, unless your are using API's which had breaking changes made between 1.x and 2.0.


Build failing for both projects on fresh clone

Following the README.md (making one change as Local.config should not have file attribute) I cloned the repo and updated config. Upon trying to build, I get a failed build for both projects:

No errors show up in the Errors pane.

@brentschooley thanks for pointing out the README is not correct, you're right, I've just opened a PR to fix the misleading step.
I tried to reproduce the error, but on my end it works as expected. Would you mind letting me know which Windows do you have installed. Which version of VS are you using?
Again, thanks for reporting this issue.


Change how anchor name value is gotten

This should account for getting a value that doesn't exist in a math glyph, addressing #678

the anchor.name attribute is optional according the spec, so is anchor.color, this could also be changed to  anchor.get("color")

Agree, changed. Still not going to solve @LettError's problem, unfortunately

@justvanrossum UFO Spec: https://unifiedfontobject.org/versions/ufo3/glyphs/glif/#anchor

Would like to test, but how do I get this code to run locally?

UFO Spec

Perhaps I'm nitpicking, but what I mean is, this is just an object implementation, and it can decide by itself whether it demands those attributes to exist or not. Perhaps it requires the "missing" attributes to be substituted by None. The spec specifies the format, not how objects should be implemented.


Release tracking PR: v0.1.2

Two patches in preparation for doing a point release to release the bug fix in #88.

Patch 1: Remove the version number from fuzz manifest.
Patch 2: Add changelog and bump version.

Tagged and published.

Thank you both!


Any way to add an 'asURLRequest' example in the 4.0 migration guide?

I'm new to Alamofire and I'm trying to start out with 4.0 but all the tutorials out there explaining the router pattern are now not applicable and I'm a little lost as a newb. In the guide it says that router patterns will need to change:

You will now implement the asURLRequest method instead of the property which gives you the ability to throw an error if necessary

Is there a possibility that an example could be provided for people as a reference to change over their router designs to use the new asURLRequest method?

All of the examples in the README, including the router example have been updated to use the new protocol.


Authenticate with MobilePhoneNumber.

Authenticate with MobilePhoneNumber is a nice feature to have. What's your thought?

Given that I don't foresee making this change, I'll close this issue. Thanks.


Fails to find element with class if className is multiline template literal

Hi
I encountered an issue where if an element in a component has a className set using a template literal, and that literal spans over multiple lines, wrapper.find(...) cannot find that element when using shallow(...) or mount(...).
Example component.
import React, { PropTypes } from 'react';

export default function Accordion({ open }) {
    return (

                ...

                ...

    );
}

Accordion.propTypes = {
    open: PropTypes.bool.isRequired,
};

React and the render-function in Enzyme handles this just fine - the resulting class attribute is what I expect, given the open property, and `wrapper.find(...)` can reach the element.
However, when using shallow(...)or mount(...), the element can't be found.
Example test.
import React from 'react';
import { shallow, render } from 'enzyme';
import Accordion from '~/components/Accordion';

describe('Accordion', function (){

    it('renders a title using render()', function (){
        const wrapper = render(<Accordion title="Hello">World</Accordion>);
        expect(wrapper.find('.accordion__title').text()).to.equal('Hello'); // Works fine
    });

    it('renders a title using shallow()', function (){
        const wrapper = shallow(<Accordion title="Hello">World</Accordion>);
        expect(wrapper.find('.accordion__title').text()).to.equal('Hello'); // Fails since .text() has no element to work with
    });

});

An obvious workaround is to not have the template literals span multiple lines - the test then works just fine. However, the behaviour is unexpected since React and render() handles it just fine - shallow(...) and mount(...) should do as well.

@wkillerud this should be resolved now (https://github.com/airbnb/enzyme/pull/348). Going to close this issue, but you're still having the same issue on 2.3.0 let me know and we can investigate it.


Changes Bundle to Plugin in Vundle instructions

For reference: https://github.com/gmarik/Vundle.vim/pull/403

Nice catch, thanks for the update


VBA -  Error message for manually entered address in the field in company info and unable to proceed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue was found when executing #5771
Action Performed:

Launch the app and login
Create a workspace
Click the workspace in the settings
Click Connect Bank account
Continue with VBA flow

Expected Result:
After entering address manually in company info page user should be able to proceed to personal info page
Actual Result:
Error message displayed as "Please enter a valid street address that is not a PO Box" in company address field and unable to proceed
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: v1.1.7-12
Reproducible in staging?: Yes
Reproducible in production?: Credentials will not work in production
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Switching to Weekly pending additional discussion

@kevinksullivan this is reproducible with valid addresses and each time the user decides to don't use the address picker (enter the address manually)

Yep, it is not obvious at all that the user MUST select a result from the picker
A related GH issue: https://github.com/Expensify/App/issues/5867
Do we know of any address that causes problems even when the user select them from the picker (autocomplete)? The mentioned GH issue is related to a problem with addresses in some parts of NY

Hmm this feels pretty rough still. Additionally, this means it's impossible to enter an apartment number if not shown, right? I believe @MitchExpensify ran into this problem as well. I think address lookup works really well for most cases, but it completely blocks users from going forward as well. I wonder if we pursue an alternative solution that auto-fills information but still lets a user manually edit it? Because address lookup is realistically too strict for individuals who often times will have a unit number that doesn't populate.

Hmm this feels pretty rough still. Additionally, this means it's impossible to enter an apartment number if not shown, right? I believe @MitchExpensify ran into this problem as well. I think address lookup works really well for most cases, but it completely blocks users from going forward as well. I wonder if we pursue an alternative solution that auto-fills information but still lets a user manually edit it? Because address lookup is realistically too strict for individuals who often times will have a unit number that doesn't populate.

Yep, it is impossible to enter an apartment number. I agree with that we should offer an alternative where the user can enter / modify things manually. I could work on that if we define how it should work :)

Issue reproducible during KI retests.

Yep, it is impossible to enter an apartment number. I agree with that we should offer an alternative where the user can enter / modify things manually. I could work on that if we define how it should work :)

So what are the decisions to make here?

Allow the user to simply modify the content of the field to append an apt number?
Add an adjacent field to enter the apt/unit:

Anything else?

@trjExpensify
The decided way to go was discussed here: https://expensify.slack.com/archives/C03TQ48KC/p1635812089454700
In summary:

Always show all inputs for: city , state ,street + number + (apt number), zip code
The input street + number will keep its autocomplete behaviour. If the user selects a result, we will populate other fields.
The user will be allowed to manipulate any of the address components

That sounds good to me! @aldo-expensify looks like you're already working on PR for this? 🙏

That sounds good to me! @aldo-expensify looks like you're already working on PR for this? 🙏

Yep! this PR: https://github.com/Expensify/App/pull/6200

Re-assigned to you! 😅 Let me know if I can help with anything 👍

I love the auto-fill / edit solution. Using this app Learn & Earn as an example, they had an awesome KYC experience overall, and the auto-fill allowed me to easily make any changes necessary or add an apt number with no issues.

Resolving conflicts in PR, after that it should be ready for review.

I love the auto-fill / edit solution. Using this app Learn & Earn as an example, they had an awesome KYC experience overall, and the auto-fill allowed me to easily make any changes necessary or add an apt number with no issues.

this looks good in my opinion, close to what we are doing in the PR, except for the Apt number field. For now, that will remain in the same field with the street name/number.

I'm closing this because with the current state of the address field, a user should be able to input an address manually if the google search results aren't useful:
https://user-images.githubusercontent.com/87341702/142908156-040abbf3-3ea2-4605-a87e-7809290ceda6.mov
Remaining developments and comments on the address inputs will be in this GH issue / PR


Roll engine 2fe4439178f3..08a133508854 (2 commits)

https://github.com/flutter/engine/compare/2fe4439178f3...08a133508854
git log 2fe4439178f3e09ddaa4d016688691a1adc65ed6..08a1335088543b250bc1517927fd9c068d9424ce --no-merges --oneline
08a133508 More detailed comments for engine build windows VM (flutter/engine#8456)
1854b8571 Roll src/third_party/dart a2709992a2..907c514c89 (1 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5346186172039168

Commit queue failed; closing this roll.


Add Hull tests to charts CI

We need to add new tests which are written using the hull framework for all the feature charts to the charts CI. This will help automate the tests whenever a new PR is raised in the rancher/charts repository.

The charts CI is working as expected. The CI fails in scenarios where there are some failures in the hull tests or if the coverage of the tests is <100%. The CI passes if all the tests pass and the coverage is 100%. Refer to this PR build for more details.
Closing this issue based on the above observations.


[Add] add optional selection for filter order

Add a chance to change the order of optional value.
When left empty, it will order the optional value by metric.

It's a bit better than before, but ultimately we'll want for each filter to be able to specify its own metric (or no metric at all) and its own ordering preference.

Coverage decreased (-0.02%) to 69.398% when pulling 2deaef6ef95d22782f253eed60db9a137741a4c6 on RoganW:add_filter_order into c9c6bcaabeab4127a601dfda69a1411d2893c1d5 on apache:master.

Coverage decreased (-0.02%) to 69.398% when pulling 2deaef6ef95d22782f253eed60db9a137741a4c6 on RoganW:add_filter_order into c9c6bcaabeab4127a601dfda69a1411d2893c1d5 on apache:master.

@mistercrunch Yeah, I think your proposal is more reasonable.
I'll optimize that later.

Coverage decreased (-0.03%) to 69.388% when pulling c6fb6687f09049168cd8c5d0dbe6b84ed5ec0c37 on RoganW:add_filter_order into c9c6bcaabeab4127a601dfda69a1411d2893c1d5 on apache:master.

Coverage decreased (-0.02%) to 69.398% when pulling c6fb6687f09049168cd8c5d0dbe6b84ed5ec0c37 on RoganW:add_filter_order into c9c6bcaabeab4127a601dfda69a1411d2893c1d5 on apache:master.

@mistercrunch Already optimized

What I'm proposing would be much more complicated. We may want to just land this as it is in the meantime.

Coverage decreased (-0.01%) to 69.403% when pulling 2668e914d77ce964c49b52a212263100c3b40532 on RoganW:add_filter_order into c9c6bcaabeab4127a601dfda69a1411d2893c1d5 on apache:master.

Coverage decreased (-0.01%) to 69.403% when pulling 9a987162fc587255d53d5e961966087bf43ba516 on RoganW:add_filter_order into c9c6bcaabeab4127a601dfda69a1411d2893c1d5 on apache:master.

Notice: this issue has been closed because it has been inactive for 250 days. Feel free to comment and request for this issue to be reopened.


Quick note on your most recent merge

Hi there,
I see you just pushed a new merge, and I just wanted to let you know I needed to make one adjustment to the sync server to make this go:
diff --git a/scripts/fake-registration-server.py b/scripts/fake-registration-server.py
index 2ec144c..45569d4 100755
--- a/scripts/fake-registration-server.py
+++ b/scripts/fake-registration-server.py
@@ -82,7 +82,7 @@ class JSONHandler(tornado.web.RequestHandler):
                 't': ts,
                 'success': True }
             answer = jsonstr(answer)
-            payload = b64encode(AES.new(options.secKey, AES.MODE_ECB).encrypt(pad(answer))).decode()
+            payload = b64encode(AES.new(options.secKey.encode("utf-8"), AES.MODE_ECB).encrypt(pad(answer).encode("utf-8"))).decode()
             signature = "result=%s||t=%d||%s" % (payload, ts, options.secKey)
             signature = hashlib.md5(signature.encode()).hexdigest()[8:24]
             answer = {

Otherwise, I got this error:
    Traceback (most recent call last):
      File "/usr/local/lib/python3.7/dist-packages/tornado/web.py", line 1697, in _execute
        result = method(*self.path_args, **self.path_kwargs)
      File "./fake-registration-server.py", line 224, in post
        self.reply(answer, encrypted)
      File "./fake-registration-server.py", line 85, in reply
        payload = b64encode(AES.new(options.secKey.encode("utf-8"), AES.MODE_ECB).encrypt(pad(answer))).decode()
      File "/usr/local/lib/python3.7/dist-packages/Crypto/Cipher/_mode_ecb.py", line 135, in encrypt
        c_uint8_ptr(plaintext),
      File "/usr/local/lib/python3.7/dist-packages/Crypto/Util/_raw_api.py", line 235, in c_uint8_ptr
        raise TypeError("Object type %s cannot be passed to C code" % type(data))
    TypeError: Object type <class 'str'> cannot be passed to C code

I think there are other places that needed this, but this change was the bare-minimum required (for me) to get the new version working.  Thanks again for this tool, it rules not having to crack open the cases for some of these devices in order to prop up new firmware.  Great work!

Hi @vishnubob thanks for the report. That's odd, that line wasn't touched in the latest release. I'll see if I can reproduce it. What environment are you working with?

@kueblc This is on a clean install of Raspbian Buster after using your provisioning script.  I was literally working on a pair of switches when you pushed your update.  I googled the error, which led me to the recommendation of byte encoding the string:

While unnecessary in my environment, it also doesn't seem to hurt. Just pushed this change, thanks for reporting @vishnubob

hi,
thanks for the fix, vishnubob, and thanks for tuya-convert, kueblc!
looks like you haven't pushed the changes to master yet, kueblc:
https://github.com/ct-Open-Source/tuya-convert/blob/master/scripts/fake-registration-server.py
after having installed python2-sslpsk for python2 only psk-frontend.py and applied above patch I successfully flashed 4 gosund sp1 devices on my arch linux machine.
following error still remains, but obviously isn't fatal:
Traceback (most recent call last):   File "./mq_pub_15.py", line 98, in <module>     sys.exit(main())   File "./mq_pub_15.py", line 93, in main     m1 = iot_enc(message, localKey, protocol)   File "./mq_pub_15.py", line 32, in iot_enc     messge_enc = encrypt(message, local_key)   File "./mq_pub_15.py", line 24, in <lambda>     encrypt = lambda msg, key: AES.new(key, AES.MODE_ECB).encrypt(pad(msg))   File "/usr/lib/python3.8/site-packages/Crypto/Cipher/AES.py", line 232, in new     return _create_cipher(sys.modules[__name__], key, mode, *args, **kwargs)   File "/usr/lib/python3.8/site-packages/Crypto/Cipher/__init__.py", line 79, in _create_cipher     return modes[mode](factory, **kwargs)   File "/usr/lib/python3.8/site-packages/Crypto/Cipher/_mode_ecb.py", line 215, in _create_ecb_cipher     cipher_state = factory._create_base_cipher(kwargs)   File "/usr/lib/python3.8/site-packages/Crypto/Cipher/AES.py", line 103, in _create_base_cipher     result = start_operation(c_uint8_ptr(key),   File "/usr/lib/python3.8/site-packages/Crypto/Util/_raw_api.py", line 144, in c_uint8_ptr     raise TypeError("Object type %s cannot be passed to C code" % type(data)) TypeError: Object type <class 'str'> cannot be passed to C code

Thanks, good catch @frostworx f2499d24f4aed1720d37bbfc90255d5b46c89e96

thanks for the quick fix! have a nice weekend @kueblc :)


[5.9] Fix SILCombine to preserve a release of a move-only type

The release needs to be preserved in case a user-defined deinit is present in the released type. Checking for move-only is slightly conservative.
Fixes rdar://109846094 ([move-only] SILCombine eliminates struct deinitialization)
(cherry picked from commit dc974e8c00d923474905d9c41d6b71bc045751d9)

Explanation: SILCombine removes releases of aggregates whose members don't contain any references. This deletes struct deinitializers, so they silently never run.

Scope of Issue: A struct's deinit would silently fail to run when the struct was a member within another type. In the most trivial cases, with no type composition, and earlier MoveOnlyDeinitInsertion pass was hiding the problem.

Risk: Zero risk to regular copyable code. And non-copyable was already broken.

PR to main: https://github.com/apple/swift/pull/66161

Reviewed By: Michael Gottesman

Resolves: rdar://109846094 ([move-only] SILCombine eliminates struct deinitialization)

@swift-ci test

@gottesmm please merge after your review

@tbkka waiting for your approval


The Battle For Wesnoth

Description
Added a yolk for The Battle For Wesnoth game. Needed some specific libraries in the main container to run. I have never used Github actions/workflows before so please let me know if I did something wrong with that.
For this PR: https://github.com/parkervcp/eggs/pull/2863#issue-2229058331
All Submissions:

[x] Have you ensured there aren't other open Pull Requests for the same update or change?
[x] Have you created a new branch for your changes and PR from that branch and not from your master branch?

New Image Submissions:

[x] Have you added your image to the Github workflows?
[x] Have you updated the README list to contain your new image?

Forgive me for my ignorance, but I noticed in the games.yml file that it says
runs-on: ubuntu-latest
So I assumed that I had to make the Dockerfile using ubuntu like this
FROM --platform=$TARGETOS/$TARGETARCH ubuntu:22.04
Do I have to use ubuntu or could I use a debian base instead?

Forgive me for my ignorance, but I noticed in the games.yml file that it says
runs-on: ubuntu-latest
So I assumed that I had to make the Dockerfile using ubuntu like this
FROM --platform=$TARGETOS/$TARGETARCH ubuntu:22.04
Do I have to use ubuntu or could I use a debian base instead?

Its just what the workflow runs on. But keep in mind that we moved to debian 12 if possible.

Got it. I will change it to debian then.

So I wasn't able to get the github actions working, but I started doing testing manually building the container and uploading it to dockerhub. I have successfully gotten the egg to work properly using that container.

Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.

Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.

This repo will become soon read only. All pr must be moved to their individual repo's

Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.

This repo will become soon read only. All pr must be moved to their individual repo's

Wait so there will no longer be a single unified yolk repository?
In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?

Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.

This repo will become soon read only. All pr must be moved to their individual repo's

Wait so there will no longer be a single unified yolk repository?
In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?

Yolks will stay 1 single yolks repo.

Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.

This repo will become soon read only. All pr must be moved to their individual repo's

Wait so there will no longer be a single unified yolk repository?
In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?

Yolks will stay 1 single yolks repo.

Alright so this PR is still in the right place, but the original PR draft for the egg should be moved to the games repo. Am I understanding that correct?

Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.

This repo will become soon read only. All pr must be moved to their individual repo's

Wait so there will no longer be a single unified yolk repository?
In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?

Yolks will stay 1 single yolks repo.

Alright so this PR for the yolk is still in the right place, but the original PR draft for the egg should be moved to the games repo. Am I understanding that correct?

yes you are.


fix(site): tooltip flicker on hover

Instructions

site: fix tooltip flicker on hover [chrome]
label: bug

What I'm Solving

see #194 and an imperfect solution in this first round pull request

Design Decisions

Round Two! 🥊 I spent some additional time looking into this bug after reviewing the excellent feedback from @jaketrent in the original PR.

I noticed the tooltip flicker only occurred on webkit browsers, and only when the cursor moved across the boundary of the child <span /> text element nested within the <button />. Applying a pointer-events: none style to that <span /> prevented the onMouseOut callback from being fired for the parent <button /> and eliminated the flicker!

How to Verify

See Hover me example under http://localhost:1337/components/tooltip#in-app-example while
running the design system locally with this branch checked out.

Haha!!  Lol, what a great, simple solution.  I love it.  These kinds of realizations are so great.    Very helpful, merging.


can not find  './Data/volunteerA/dyn/deeds_bh/sl_ss9_tt1_displ.mat' file

https://github.com/mattiaspaul/realtimeDeeds/blob/eac54eeaa7818f9a01e0a3b778e0e4f1dce28bff/example.m#L22
Hello, your paper is attractive, and  I am interested in it.  Thank you for providing  your code for learning.
But when I run the example.m,  I can not find the displ.mat data. Could you share them?

Hi, the dataset is not included here. You can download them from https://zenodo.org/record/55345#.WvLINd8xBhF

I have issue that I can not find ./Data/volunteerA/dyn/deeds_bh/sl_ss9_tt1_displ.mat'  on https://zenodo.org/record/55345#.WvLINd8xBhF and https://zenodo.org/record/55345#.W3pa87gxVPY. please suggest to find them. Could you share them?

Sure, thank you for asking. I forgot to upload it. You can download it here. The read me file is also updated to include this link.

Thank you for helping.

I have found some issue on your code that shows error bellow :
Undefined function or variable 'vl_nnconv'.
Error in example (line 89)
gRefSum2 = vl_nnconv(gRefBlock.^2,gfilt,[]);
please suggest me to edit them.
Thanks.

For the 'vl_nnconv' function, you should download the MatconvNet toolbox according to the instructions from: http://www.vlfeat.org/matconvnet/


Some blocks have missing loot tables

The following blocks don't drop when you break them, and in fact have no loot tables at all:

Framed Big Block
Framed Huge Block
Framed Chest
Framed Up-Extended Block
Framed Down-Extended Block
Framed Door
Framed Fence

yup. sorry I didnt notice this earlier. will add them in when i have time


When the user reloads the page the task get removed.

Assign the task to me I will work on this issue.

issue Already exists


Discussion on new rules to be  implemented next

Per our discussion in the last meeting, we may want to add three new rules. I checked all the top rules that are violated in our dataset at least once. I think the following are the ones that we may be able to (partially) fix.
S2066, S1143, S1850, S2225, S2097, S1221, S2200, S1872, S2276, S2236, S1217, S3346
Do you think any of them has a higher priority? @slarse @fermadeiral @monperrus @nharrand

Quick note:
1850 has been deprecated (see the deprecation notice at the bottom of the page), the new rule is 2589

To me, priority can be set on a project basis, not on a rule basis. We want to repair violations from projects which could become "champions" of Sorald! They would spread the word after.
So the highest priority would be on rules for which we have violations in projects where the lead devs strongly care about Sonar warnings.

Some general notes on the feasibility of implementing processors for these rules.

S2066: Would be easy to implement a naive fix for (just add static keyword). But if the class accesses any instance variables from the enclosing class, this will cause breakage. Repairing the general case where there is instance variable access is probably impossible with a template-based solution.
S1143: I don't think this is feasible to repair. You can't just remove return statements unconditionally, especially not when they are non-void.
2589: This is definitely doable with template-based repair, but I suspect it might be hard to match the sonar warning to the correct boolean subexpression. It would be an interesting rule to implement to drive the development of our sonar-to-spoon matching heuristic.
S2225: We can partially repair this, as making toString() returning null can easily be repaired by returning "" instead. Fixing clone() is probably not possible in the general case, though.
2097: This should be easy to repair, just add an instanceof check to the beginning of the method. Only tricky part is determining if there's already a null-check in there, or if it needs to be added.
S1221: Easy as long as there's no "real" toString or the like.
S2200: Feasible to repair, but probably not in all cases.
S2276: Should be easy.
S1872: Doable if we have complete type resolution for the affected elements, so this one would be pretty cool to attempt to repair.
S2276: No general solution for this one.
S1217: Should be easy.
S3346: Doable with complete type resolution of affected elements. This would be a pretty cool one to fix; it's a non-trivial repair that plays on Spoon's strengths of having deep type information on the target program.

Some interesting (and easy) rules to repair:

https://rules.sonarsource.com/java/RSPEC-3078
https://rules.sonarsource.com/java/RSPEC-2446

Good suggestions.
Note: the reason that we did not consider these is that they do not have any instances in Marcilio et al. dataset.


Issue 41 cimulator buid

Add test which check that c simulator is built correctly

Looks like more tests are failing now...

The tests are still failing. Please make sure that the tests pass before requesting re-review!

It was not failing. Issue is we have 2 pipeline for python only and c/c++ running in parallel that is what create this intermittent failure.

The tests are still failing. Please make sure that the tests pass before requesting re-review!

tests are not failing as you can see in github actions issue is that 2 workflows for c/c++ and pure python works in parallel which creates this intermittent error need to run jobs sequentially

Status update: there are two main problems
(i) the PYTHON_ONLY flag is not being raised properly in "python only" workflow:
https://github.com/jpmorganchase/QOKit/actions/runs/10218741603/job/28275531066?pr=47
(ii) the simulator is not being built properly on MacOS:
https://github.com/jpmorganchase/QOKit/actions/runs/10218741601/job/28275532498?pr=47

Update: the Mac build failure is due to clang not supporting openmp. Installing GCC should resolve the issue, but I can't get make to use the right compiler

fixed following pipeline issues:

Mac OS was added with gcc brew install but in Mac OS default path is to Apple clang
Added correct path for gcc - export PATH=$PATH:/opt/homebrew/
Corrected test case for python only
Removed incorrectly added  make in pipeline. No need for make since make is in setup.py


[NB] Garage, windows and curtains

Introduction of garage, window and curtains under homeassistant_HassTurnXX.yaml.
Further work is required to utilize the wider "garasj[edør|eport][(en|er|ene)]"

@LaStrada is there anything else I need to do here? The updated files should reflect your proposed changes.

#978 and other PRs are creating several conflicts. I will therefore close this PR and replace it with a simpler one.


[BUG] JSQLParser Version 4.6+, parse fail when sql with 3 or more '\n'

Failing SQL Feature:

any sql with 3 or more empty line

SQL Example:

Simplified Query Example, focusing on the failing feature-- parse this sql would throw an 'Encountered unexpect token' excption
select 1,\n\n\n2 from dual

Software Information:

JSqlParser 4.6+
Database ALL

Tips:
test case
final String sql = "select 1,\n\n\n2 from dual";
// throw exception
CCJSqlParserUtil.parse(sql);

Greetings!
Its a feature, not a bug.
Why would you need 3 empty lines within your statement?

my job is review sql from different team, i can stop them to write the sql like this. this feature severely breaks the campatibility of version 4.3. maybe we should a switch to turn it off.

maybe we should set a switch to turn it off.

Its a Token in JavaCC (but not a production) and so it was very difficult to make it optional.
Also, its is not really needed since all you need to do was replacing the redundant empty lines before parsing, e. g.
CCJSqlParserUtil.parse(sql.replace("\\n+", ""));

Last but not least, I assume you come from MyBatis Plus (which is the main producer of those statements).
They have provided a fix for their behavior already.


How create a dynamic height to swiper container according slide height?

Which OS ?
both, iOS and Android
Version
Which versions are you using:

react-native-swiper v1.6.0-rc.3?
react-native v16.9.0?

Expected behaviour
Dynamic height according slider, to dynamic height of lists and and static height for a few views.
Actual behaviour
Currently takes the major height of slide and set as the default height (as a static height, not adjusting according content).
How to reproduce it>
To help us, please fork this component, modify one example in examples folder to reproduce your issue and include link here.
Create two sliders with different heights.

Which OS ?
both, iOS and Android
Version
Which versions are you using:

react-native-swiper v1.6.0-rc.3?
react-native v16.9.0?

Expected behaviour
Dynamic height according slider, to dynamic height of lists and and static height for a few views.
Actual behaviour
Currently takes the major height of slide and set as the default height (as a static height, not adjusting according content).
How to reproduce it>
To help us, please fork this component, modify one example in examples folder to reproduce your issue and include link here.
Create two sliders with different heights.

I have same question, Hope the author  or anybody provide the  answer.

Which OS ?
both, iOS and Android
Version
Which versions are you using:

react-native-swiper v1.6.0-rc.3?
react-native v16.9.0?

Expected behaviour
Dynamic height according slider, to dynamic height of lists and and static height for a few views.
Actual behaviour
Currently takes the major height of slide and set as the default height (as a static height, not adjusting according content).
How to reproduce it>
To help us, please fork this component, modify one example in examples folder to reproduce your issue and include link here.
Create two sliders with different heights.

I have same question, Hope the author  or anybody provide the  answer.

Yes, facing the same problem, also tried giving height as undefined but no luck.

Yes, facing the same problem, also tried giving height as undefined but no luck.

@aithashi  you can wrap swiper in a parent view and give that view 10% height of the screen. automatically the swiper will adjust its height according to the parent view. The only problem with swiper is that how can the swiper take height according to the child component of swiper.

Is there a solution for this?

Below is my solution to this.
I set the height in each children component.
import { Animated } from 'react-native';
import Swiper from 'react-native-swiper';

const AnimatedSwiper = Animated.createAnimatedComponent(Swiper);

const Slider = ({ children }) => {
	const [current, setCurrent] = React.useState(0);
	const [height] = React.useState(new Animated.Value(100));

	React.useEffect(() => {
		Animated.timing(height, {
			useNativeDriver: false,
			toValue: children[current].props.height,
		}).start();
	}, [current]);

	return (
			<AnimatedSwiper
				height={height}
				onIndexChanged={(index) => setCurrent(index)}
				loop={false}
			>
				{children}
			</AnimatedSwiper>
	);
};```


NTR: sperm migration through the uterotubal junction

Please provide as much information as you can:

Suggested term label:
sperm migration through the uterotubal junction

Definition (free text)
The controlled self-propelled movement of a sperm cell from the uterus through the uterotubal junction (UTJ) into the oviduct, where interaction between the sperm and the UTJ acts as a major selective barrier for sperm, allowing only living, motile, uncapacitated, morphologically normal sperm with intact acrosomes to pass from the uterus into the oviduct.

Reference, in format PMID:#######
[GOC:krc, PMID:34057175, PMID:32712384, PMID:31131960, PMID:29353867]

Gene product name and ID to be annotated to this term
mouse genes: Ace, Adam1a, Adam2, Adam3, Calr3, Clgn, cystatin, Ly6k, Lypd4, Pdilt, Pgap1, Pmis2, Prss37, Rnase10, TEx101, Tmprss12, Tpst2, Prss55, Pate (see Figure 1 in Mahé C, et al. Sperm migration, selection, survival, and fertilizing ability in the mammalian oviduct. 2021. PMID:34057175)

-- Regarding Lypd4, see Wang D, et al. LYPD4, mouse homolog of a human acrosome protein, is essential for sperm fertilizing ability and male fertility. Biol Reprod. 2020 Apr 24;102(5):1033-1044. PMID: 32040177.
-- Regarding Pdilt, see Tokuhiro K, et al. Protein disulfide isomerase homolog PDILT is required for quality control of sperm membrane protein ADAM3 and male fertility [corrected]. Proc Natl Acad Sci U S A. 2012 Mar 6;109(10):3850-5. PMID: 22357757
--- also see this ticket because the equivalence axiom of the existing term "germ cell migration" is too broad and would incorrectly encompass the new term requested in this ticket
---   #25651

Parent term(s)
is_a: cell migration ! GO:0016477
part_of: multicellular organismal reproductive process ! GO:0048609
has_part: name: flagellated sperm motility ! GO:0030317 (I know that C. elegans have amoeboid sperm but since this term refers to the junction between the uterus and the oviduct, I think flagellated sperm motility is likely appropriate.

If it's possible to specify the start and end locations, these terms may be helpful:
-- uterus ! UBERON:0000995
-- oviduct ! UBERON:0000993

Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term?

Synonyms (please specify, EXACT, BROAD, NARROW or RELATED)

sperm migration through the UTJ - RELATED
sperm migration from the uterus to the oviduct - EXACT

Cross-references

For enzymes, please provide RHEA and/or EC numbers.

Can also provide MetaCyc, KEGG, Wikipedia, and other links.

Any other information

Hi @krchristie
I was wondering how this
GO:0097722 sperm motility (if at all?). They sound like 2 sides of the same coin.
Definition (GO:0097722 GONUTS page)
Any process involved in the controlled movement of a sperm cell.

Hi @krchristie I was wondering how this GO:0097722 sperm motility (if at all?). They sound like 2 sides of the same coin.
Any process involved in the controlled movement of a sperm cell.

Hi @ValWood - I have submitted a ticket about the fact that "cell migration" is incorrectly classified as a type of "cell motility". For a moment, think about elephants, elephant motility is methods of motility, e.g. walking, running, swimming. Elephant migration is the annual pattern of movements guided by external signals like rainfall patterns, food availability, etc. For details on this issue within GO, please see my comments in the ticket:

#25650

Also, note that GO:0097722 "sperm motility" is broader than the specific motility term that I have suggested for a has_part relationship to the new term I am requesting:

has_part: name: flagellated sperm motility ! GO:0030317 (I know that C. elegans have amoeboid sperm but since this term refers to the junction between the uterus and the oviduct, I think flagellated sperm motility is likely appropriate.

Also worth checking this ticket since the current logical definition of "germ cell migration" is too broad for its definition which is specific to the migration of primordial germ cells within an embryo:

#25651

It is a sticky one as to where to place 'sperm migration through the uterotubal junction'. A key element in the def of cell migration is "guided by molecular cues". Usually cell migration involves instructive cues that guide the direction of movement of the motile cell. It appears that sperm migration (an adopted term in literature) involves a combination of motility of the sperm with the selective environment set up by the female reproductive tract (Wikipedia:Cell_migration). There does not seem to be a conventional, 'instructive' cue.
Thus, I am in favor of placing the term under (is_a) 'sperm motility' but keeping the proposed term label 'sperm migration through the uterotubal junction'. Is this good? @krchristie

[Term]
id: GO:0160131
name: sperm migration through the uterotubal junction
namespace: biological_process
def: "The controlled self-propelled movement of a sperm cell from the uterus through the uterotubal junction (UTJ) into the oviduct, where interaction between the sperm and the UTJ acts as a major selective barrier for sperm, allowing only living, motile, uncapacitated, morphologically normal sperm with intact acrosomes to pass from the uterus into the oviduct." [GOC:krc, PMID:29353867, PMID:31131960, PMID:32712384, PMID:34057175]
synonym: "sperm migration from the uterus to the oviduct" EXACT []
synonym: "sperm migration through the UTJ" RELATED []
is_a: GO:0016477 ! cell migration
relationship: has_part GO:0030317 ! flagellated sperm motility
relationship: part_of GO:0048609 ! multicellular organismal reproductive process
created_by: rynl
creation_date: 2023-12-09T01:02:52Z


Add validator to perform offline CRD validation in tests

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f6cb7eb6ec492b425ff34e7b37307f59ef6eb17e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f6cb7eb6ec492b425ff34e7b37307f59ef6eb17e
link
/test lint_istio

gencheck_istio
f6cb7eb6ec492b425ff34e7b37307f59ef6eb17e
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f6cb7eb6ec492b425ff34e7b37307f59ef6eb17e
link
/test lint_istio

gencheck_istio
f6cb7eb6ec492b425ff34e7b37307f59ef6eb17e
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
f6cb7eb6ec492b425ff34e7b37307f59ef6eb17e
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f6cb7eb6ec492b425ff34e7b37307f59ef6eb17e
link
/test lint_istio

gencheck_istio
f6cb7eb6ec492b425ff34e7b37307f59ef6eb17e
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
f6cb7eb6ec492b425ff34e7b37307f59ef6eb17e
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
f6cb7eb6ec492b425ff34e7b37307f59ef6eb17e
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
63e62c5632f97389d96de5c27aa58c0953e8d3f4
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
dc7aed4ff4c7931e3839651d25077c058ea8f303
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

| /test integ-multicluster-k8s-tests_istio
-- | --

/retest


Add id to each step in the wizard

Used for gathering some behavioural data. Format: #wizard-$step(-$substep).

It needs to go inside the child of pf-c-wizard__main-body, because that is what tends to change between the steps as far as I can see.
So just to try out the syntax: #wizard-target-aws, #wizard-target-msazure, #wizard-systemconfiguration-filesystem, #wizard-systemconfiguration-packages etc.
I checked out the code, but unfortunately it's way too much react for me, so I would need to ask someone for a favor.


 does not work

Hi There
Not sure why, but since meteor 1.2 meteor-include directive displays nothing.

Yes, it has been deprecated in favor of blaze-template:  http://angular-meteor.com/api/blaze-template
You only need to do:
meteor add urigo:angular-blaze-template

<blaze-template
    name="loginButtons">
</blaze-template>

Thanks Uri,
My bad. You do have thus in your instructions here
http://angular-meteor.com/tutorials/angular1/user-accounts-authentication-and-permissions
but just so you know in code snippet, 8.1 the old method is still included as well.
Cheers bro. love your work.
From: Uri Goldshtein<EMAIL_ADDRESS>Sent: Friday, 25 September 2015 8:45 PM
To: Urigo/angular-meteor<EMAIL_ADDRESS>Cc: nigel-dewar<EMAIL_ADDRESS>Subject: Re: [angular-meteor]  does not work (#707)
Yes, it has been deprecated in favor of blaze-template: http://angular-meteor.com/api/blaze-template
You only need to do:
meteor add urigo:angular-blaze-template

—
Reply to this email directly or view it on GitHub https://github.com/Urigo/angular-meteor/issues/707#issuecomment-143162471 .  https://github.com/notifications/beacon/AI94WAdfLTrX54VNP0MmowhTQQ4EMWSuks5o1QD8gaJpZM4GDliv.gif

@nigel-dewar thanks!  I've just fixed the tutorial and pushed a new update.

not sure why but when I include  and press it the dropdown does not show the login menu.  Instead {{> loginButtons}} just works fine. Maybe there is issue in meteor 1.2.1?

@torayeff it might be the new urigo:angular-blaze-template package version.
Try to downgrade to 0.0.1 for now and let me know if that helped

@Urigo yes the problem was with the new version. I downgraded and now it is fine. But after updating angular package (1.0.4 => 1.0.5) I started receiving this error in browser console:
update failed: Access denied. In a restricted collection you can only update documents, not replace them. Use a Mongo update operator, such as '$set'.
I am following angular-meteor tutorial, step 8.

@torayeff can you share your code in a repo?

Now everything is working for me with angular package 1.0.6 and urigo:angular-blaze-template package 0.1.1. Thanks.

Hi @Urigo . For this:
$stateProvider
  .state('parties', {
    url: '/parties',
    templateUrl: 'parties-list.html',
    controller: 'PartiesListCtrl'
  })
  .state('partyDetails', {
    url: '/parties/:partyId',
    templateUrl: 'party-details.html',
    controller: 'PartyDetailsCtrl'
  });

If I provide templateUrl: 'client/parties/views/parties-list.html', I receive this error:
WARNING: Tried to load angular more than once.
My repo is here https://github.com/torayeff/angular-meteor-bootstrap

Looks like a typo in path or a caching problem.
The caching problem should be solved in the new 1.3 version


Rosetree causes type and layout problems

app "rosetree"
    packages { base: "platform" }
    imports [base.Task]
    provides [ main ] to base

main : Task.Task {} []
main =
    myTree : Tree Str
    myTree = tree "foo" [ singleton "bar", singleton "baz" ]

    myTree
        |> count
        |> Str.fromInt
        |> Task.putLine

Tree a : [ Tree a (List (Tree a)) ]

tree : a, List (Tree a) -> Tree a
tree = \a, t -> Tree a t

singleton : a -> Tree a
singleton = \x -> Tree x []

count : Tree Str -> I64
count = \t -> foldl (\_, x -> x + 1) 0 t

foldl : (Str, I64 -> I64), I64, Tree Str -> I64
foldl = \f, acc, (Tree d xs) -> listFoldl xs (foldlHelper f) (f d acc)

listFoldl : List (Tree Str), (Tree Str, I64 -> I64), I64  -> I64
listFoldl = \a,b,c -> List.walk a b c

foldlHelper : (Str, I64 -> I64) -> (Tree Str, I64 -> I64)
foldlHelper = \f -> \subtree, subacc ->
    foldl f subacc subtree

# foldl : (a, b -> b), b, Tree a -> b
# foldl = \f, acc, (Tree d xs) -> List.walk xs (foldlHelper f) (f d acc)
#
# foldlHelper : (a, b -> b) -> (Tree a, b -> b)
# foldlHelper = \f -> \subtree, subacc ->
#     foldl f subacc subtree

This runs into all kinds of layout and recursion problems.

FWIW, I get this output today:
[jan@framey roc]$ cat test.roc
app "rosetree"
    packages { pf: "examples/hello-world/platform/main.roc" }
    imports []
    provides [main] to pf

main =
    myTree : Tree Str
    myTree = tree "foo" [ singleton "bar", singleton "baz" ]

    myTree
        |> count
        |> Str.fromInt

Tree a : [ Tree a (List (Tree a)) ]

tree : a, List (Tree a) -> Tree a
tree = \a, t -> Tree a t

singleton : a -> Tree a
singleton = \x -> Tree x []

count : Tree Str -> I64
count = \t -> foldl (\_, x -> x + 1) 0 t

foldl : (Str, I64 -> I64), I64, Tree Str -> I64
foldl = \f, acc, (Tree d xs) -> listFoldl xs (foldlHelper f) (f d acc)

listFoldl : List (Tree Str), (Tree Str, I64 -> I64), I64  -> I64
listFoldl = \a,b,c -> List.walk a b c

foldlHelper : (Str, I64 -> I64) -> (Tree Str, I64 -> I64)
foldlHelper = \f -> \subtree, subacc ->
    foldl f subacc subtree

# foldl : (a, b -> b), b, Tree a -> b
# foldl = \f, acc, (Tree d xs) -> List.walk xs (foldlHelper f) (f d acc)
#
# foldlHelper : (a, b -> b) -> (Tree a, b -> b)
# foldlHelper = \f -> \subtree, subacc ->
#     foldl f subacc subtree
[jan@framey roc]$ roc test.roc

thread '<unknown>' has overflowed its stack
fatal runtime error: stack overflow
Aborted (core dumped)
[jan@framey roc]$

This seems to still be an issue.
app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.17.0/lZFLstMUCUvd5bjnnpYromZJXkQUrdhbva4xdBInicE.tar.br" }

import pf.Stdout

main =
    myTree : Tree Str
    myTree = tree "foo" [ singleton "bar", singleton "baz" ]

    myTree
        |> count
        |> Inspect.toStr
        |> Stdout.line

Tree a : [ Tree a (List (Tree a)) ]

tree : a, List (Tree a) -> Tree a
tree = \a, t -> Tree a t

singleton : a -> Tree a
singleton = \x -> Tree x []

count : Tree Str -> I64
count = \t -> foldl (\_, x -> x + 1) 0 t

foldl : (Str, I64 -> I64), I64, Tree Str -> I64
foldl = \f, acc, (Tree d xs) -> listFoldl xs (foldlHelper f) (f d acc)

listFoldl : List (Tree Str), (I64, Tree Str -> I64), I64  -> I64
listFoldl = \list, func, acc -> List.walk list acc func

foldlHelper : (Str, I64 -> I64) -> (I64, Tree Str -> I64)
foldlHelper = \f -> \subacc, subtree ->
    foldl f subacc subtree

produces
$ roc build
thread 'main' panicked at crates/compiler/mono/src/borrow.rs:396:34:
internal error: entered unreachable code:
	No borrow signature for LambdaName { name: `#UserApp.foldlHelper`, niche: Niche(Captures([])) } layout.

	Tip 1: This can happen when you call a function with less arguments than it expects.
	Like `Arg.list!` instead of `Arg.list! {}`.
	Tip 2: `roc check yourfile.roc` can sometimes give you a helpful error.

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


No drawing instructions

Hi,
I have this little test program:
package main

import (
	"bytes"
	"fmt"
	"github.com/rustyoz/svg"
	"github.com/xyproto/tinysvg"
	"image"
)

func Render(svgdata []byte) (*image.RGBA, error) {
	p, err := svg.ParseSvgFromReader(bytes.NewReader(svgdata), "Untitled", 1.0)
	if err != nil {
		return nil, err
	}
	fmt.Println("title:", p.Title)
	fmt.Println("groups:")
	for _, group := range p.Groups {
		fmt.Println("group:", group)
	}
	fmt.Println("width:", p.Width)
	fmt.Println("height:", p.Height)
	fmt.Println("viewbox", p.ViewBox)
	for _, element := range p.Elements {
		fmt.Println("element:", element)
	}
	fmt.Println("name:", p.Name)
	fmt.Println("transform:", p.Transform)

	drawingInstructionChan, errorChan := p.ParseDrawingInstructions()

	go func() {
		for err := range errorChan {
			if err != nil {
				fmt.Println("error", err)
			} else {
				fmt.Println("no error")
			}
		}
	}()

	go func() {
		for drawingInstruction := range drawingInstructionChan {
			fmt.Println("drawing instruction", drawingInstruction)
		}
	}()

	img := image.NewRGBA(image.Rectangle{image.Point{0, 0}, image.Point{256, 256}})
	return img, nil
}

func main() {
	document, svg := tinysvg.NewTinySVG(256, 256)
	svg.Describe("Diagram")

	roundedRectangle := svg.AddRoundedRect(30, 10, 5, 5, 20, 20)
	roundedRectangle.Fill("red")

	fmt.Println(document)

	_, err := Render(document.Bytes())
	if err != nil {
		panic(err)
	}
}

However, I can't see any drawing instructions appearing. I would expect this line to kick in at least once:
fmt.Println("drawing instruction", drawingInstruction)

What am I doing wrong?
This is a feature request for adding some documentation or a small example program for simple use of this package.

Never mind, I see now that the channel is buffered and need to be read asynchronously. At least that is my current working theory.

Following the example of:
https://github.com/rustyoz/svg/blob/master/path_test.go#L67
I still can't make it work. Any help is appreciated.

Hi @xyproto
It appears that the later developers, (I only did the first few commits) haven't implemented the drawing instruction parser for rectangles fully.
 Unfortunately i don't have the time to fix this.
I would search for references to the later fork https://github.com/vytis/svg to find examples of it being used. Good luck

Thanks for the information and the detailed reply! It's helpful to know the current state of the implementation, and I wasn't aware of the fork.


How to get payload's extra arguments iOS

Hi, i have a question.
I need to get some extra arguments for iOS.
Payload that i send from my c# server, looks like this:
{
      "aps":{
          "alert":"Esto es una prueba de notificaciones",
          "badge":1,
          "sound":"default"
      },
      "idcuenta":"HOLA",
      "fecha":"02-03-2016 12:09:09"
}

The extra arguments are: idcuenta and fecha.
but when i got the console.log in:
push.on('notification', function(data) {
    console.log('idcuenta:' + data.idCuenta);
}

Says: idcuenta:undefined
I don't know how to get those values. Can you help me please, really appreciate.
PD: Apologize for the misunderstanding, my native language is not english.

@acarolinee it should be at data.additionalData.idcuenta. In your notification handler you an see the structure of the returned data by doing:
push.on('notification', function(data) {
    console.log(JSON.stringify(data.idCuenta));
}

Oh, it works! I used data.additionalData.idcuenta as you said.
Thank you so much


[MB-9034] create shipment cards in storybook and use in the billableweightcard component

Description
Explain a little about the changes at a high level.
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
Add any steps or code to run in this section to help others prepare to run your code:
echo "Code goes here"

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this article explains more about the approach used.

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Messages

:book:
:link: MB-9034

  Generated by :no_entry_sign: dangerJS against 78706e0a05d0f5a5b47d1627c09d29ef3e81e4e8

The component looks good!
Doesn't block the story, but could we stay away from numbering the shipments like HHG 1? I know it's just in Storybook but don't want to give anyone the wrong idea, since we don't do this in practice.

Good point, I update this


Make a UI that contains all projects in this repository

Make a UI that contains all projects in this repository

to help someone who can see all projects list

Ok


Consider additional vim arguments?

Currently, we set a few vim arguments ( https://github.com/agl/pond/blob/master/client/cli.go#L1691 ):
cmd := exec.Command("vim", "-n", "--cmd", "set modelines=0", "-c", "set viminfo=", "+4", "--", tempFileName)

I think we might want to consider adding the following options (-n does noswapfile but isn't as readable):
-c 'set nobackup'
-c 'set noswapfile'
-c 'set nowritebackup'

We may also want to set -N:
       -N          No-compatible mode.  Reset the 'compatible'  option.   This
                   will  make Vim behave a bit better, but less Vi compatible,
                   even though a .vimrc file does not exist.

We should probably not load plugins by using the --noplugin option:
       --noplugin  Skip loading plugins.  Implied by -u NONE.

For the console version, we might want to consider the -X option:
       -X          Don't connect to the X server.  Shortens startup time in  a
                   terminal,  but  the  window title and clipboard will not be
                   used.

Once we sandbox, we may want to consider this option:
       -m          Modifying  files  is  disabled.  Resets the 'write' option.
                   You can still modify the buffer, but writing a file is  not
                   possible.

I'm happy to submit a patch with these changes, but adam won't necessarily get to it anytime soon.


404 Link

https://realm.io/docs/cocoa/api/Classes/RLMObject.html

You're looking for https://realm.io/docs/objc/latest/api/Classes/RLMObject.html

awesome thanks


Custom

Thank you for the pull request, but I do not see how this repository can benefit from the proposed changes.

Sorry about this one, it was not intended to be a pull request for this repository. Thanks for closing the PR.


Reduce the number of warnings according to the test policy

Signed-off-by: Oleg Kopysov<EMAIL_ADDRESS>Description
Reduce the number of warnings according to the test policy.
The current number of warnings is 0.
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Code cleanup/refactoring
[ ] Documentation update
[ ] This change requires a documentation update
[ ] CI system update
[ ] Test Coverage update

How Has This Been Tested?
$ mvn clean install

[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ lpvs ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 15 source files to D:\Git\GitHub\LPVS\target\classes
[INFO]
[INFO] --- maven-resources-plugin:3.2.0:testResources (default-testResources) @ lpvs ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] Copying 0 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ lpvs ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 10 source files to D:\Git\GitHub\LPVS\target\test-classes

Test Configuration:

Java: v11
LPVS Release: v1.0.0

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

@MoonkiHong  @t25kim
I've completed working on warning fixing. Please take a look at this PR.


Test against Vertica on Travis CI

There have been two issues related to using nanodbc with Vertica, #33 and #54, and there have also been added related CMake option NANODBC_HANDLE_NODATA_BUG.
Unfortunately, those involved in nanodbc development seem unable to actively test the library against Vertica.
Good news though, it seems to be feasible to set up Vertica on Travis CI containers, for example wvanbergen/vertica project does this::
before_install:
  - sudo wget -nv https://s3.amazonaws.com/circle-support-bucket/vertica_7.0.1-0_amd64.deb
  - sudo dpkg -i vertica_7.0.1-0_amd64.deb
  - sudo /opt/vertica/sbin/install_vertica --failure-threshold HALT --accept-eula --dba-user-password dbadmin --license CE -s localhost
  - sudo -u dbadmin /opt/vertica/bin/adminTools -t create_db --database ci -s localhost -p dbadmin
  - sudo -u dbadmin openssl req -x509 -nodes -days 365 -newkey rsa:2048 -keyout /home/dbadmin/ci/v_ci_node0001_catalog/server.key -out /home/dbadmin/ci/v_ci_node0001_catalog/server.crt -batch
  - sudo -u dbadmin chmod 600 /home/dbadmin/ci/v_ci_node0001_catalog/server.key /home/dbadmin/ci/v_ci_node0001_catalog/server.crt
  - sudo -u dbadmin /opt/vertica/bin/adminTools -t stop_db --database ci -p dbadmin
  - sudo -u dbadmin sh -c 'echo "EnableSSL = 1" > /home/dbadmin/ci/v_ci_node0001_catalog/vertica.conf'
  - sudo -u dbadmin /opt/vertica/bin/adminTools -t start_db --database ci -p dbadmin

Then, How do I install an ODBC driver in Linux? should help to complete the test environment.
So, the task is to play with nanodbc's .travis.yml and give it a try.
Any takers?

Oh wow, I didn't realize there were versions of Vertica that are freely available!

Vertica is now tested on Travis CI with one build job.

That's awesome!!!


user-exit to block pull based on arbitrary set of conditions

Looking at ZIF_ABAPGIT_EXIT there does not seem to be a way to block the pull action if the user can otherwise run aG and has developer rights. This is in line with developers being able to edit any source code at will, of course, without the help of aG.
I am trying to square the circle of each user developing on its own system (as is normal with git or with miniSAPs) and then pushing to the repo with the typical situation where multiple developers interact on a real SAP system and perhaps just one of them is the release master, able to choose which version goes into a transport to be delivered to customers. Ideally, this user alone should be able to switch branches/tags and pull from the repo, whereas the rest would simply be allowed to work on the code and maybe push. This of course could vary from package to package / repo to repo, so a blanket ban on aG at the authority-check level isn't perhaps appropriate.
Does it make sense?

A: so its a software add-on development setup, where the software is released to customers, eg. on a month schedule?
B: is there anything else you would like to do on the git side more than branches/tags? I'm thinking about code review, static analysis, unit testing

A: correct, that's our case
B: not at the moment, first we need to get colleagues up to speed with abapGit, then we can think about those topics. I know for sure that we run ATC checks in batch at the moment. How and when to integrate that with aG, that I can't say at  the moment. (not because it is a secret, we really need to see how it fits us)

https://docs.heliconialabs.com/abap-product-development.pdf for central development I suggest doing

Automatic push to a branch in GitHub can be setup so developers does not have to dig into using git

then you'll get the backup and possibility to do branching/tags
note that if/when you release the transport there must be no work-in-progress in the central dev system

That is an alternative approach requiring no code changes for aG, correct? Or just a bridge solution?

I made a mental shift: The single source of truth is the repository - not the SAP system. Permissions on GH protect the repo and "changes to the truth" go through PRs with checks and reviews.
Deploying to QA can be a pull from the main branch, or if you want to use CTS, a central dev system pulling from main into a transport that goes to QA.
It's gives a new kind of freedom. I have four systems on different releases (Azure VMs). I can code in any system and push, or pull in any system and test. The repo takes care of my sanity (and I even stopped backing up my SAP systems).

anyhow, pull requests with additional user exits are welcome
but I do think there are easier ways to handle your scenario

Thanks @larshp and @mbtools , as soon as our internal git server is up and running we'll start experimenting with automatic push, then we'll reevaluate our requirements. I'm leaving this open until we make up our minds.

github.com is USD 4 / user / month
spending 1 hour setting up internal git server corresponds to license for multiple users for multiple years

Can't and won't get into details but that's not the only point to consider and anyway that's not my call to make :)

true, I did not go into detail with the advantages
I even think public repositories is an option for ABAP product development, all customers have the source code anyhow

Note to self: ZIF_ABAPGIT_AUTH might be interesting.

@AndreaBorgia-Abo did ZIF_ABAPGIT_AUTH work out, or would you like to provide a PR with the exit?

@larshp I had no time to work on this and I still have @mbtools suggestion in mind that we should handle this server-side.
@mssoftag ping me when you have time for a chat.

okay, no problem, I've assigned the issue to you, for now..

Quick update (and memo to self): until the translations can be reliably stored in git with aG, we're not able to use it so this issue is also absolutely low priority.
Leaving open until further evaluation.


Create relationship between orgs and loops

Change-type: minor
Signed-off-by: Lucian Buzzo<EMAIL_ADDRESS>

@balena-ci retest

@balena-ci I self-certify!


Add interface for createSelector in SelectSelector

Small Refact for the SelectSelector

Codecov Report

Merging #889 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
+ Coverage   99.76%   99.76%   +<.01%
==========================================
  Files         282      282
  Lines        7167     7168       +1
  Branches     1753     1753
==========================================
+ Hits         7150     7151       +1
  Misses         17       17

Impacted Files
Coverage Δ

src/components/select/SelectWithFilter.tsx
100% <ø> (ø)
:arrow_up:

src/components/select/SingleSelectConnected.tsx
100% <100%> (ø)
:arrow_up:

src/components/select/SelectSelector.ts
100% <100%> (ø)
:arrow_up:

src/components/select/MultiSelectConnected.tsx
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec64002...78c8372. Read the comment docs.


Add .mill extension to Scala language highlighting

The Mill Scala build tool recently moved its file format extension from .sc to .mill (https://github.com/com-lihaoyi/mill/pull/3426) to better differentiate it from other Scala scripts (Ammonite, Scala-CLI, IntelliJ/VSCode worksheets). This updates Linguist to understand that .mill files should be highlighted as Scala

Description

Checklist:

[ ] I am adding a new extension to a language.

[ ] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.FOOBAR+KEYWORDS

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am adding a new language.

[ ] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.FOOBAR+KEYWORDS

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a syntax highlighting grammar: [URL to grammar repo]

[ ] I have added a color

Hex value: #RRGGBB
Rationale:

[ ] I have updated the heuristics to distinguish my language from others using the same extension.

[ ] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am changing the source of a syntax highlighting grammar

Old: [URL to grammar repo]
New: [URL to grammar repo]

[ ] I am updating a grammar submodule

[ ] I am adding new or changing current functionality

[ ] I have added or updated the tests for the new or changed functionality.

[ ] I am changing the color associated with a language

[ ] I have obtained agreement from the wider language community on this color change.

[URL to public discussion]
[Optional: URL to official branding guidelines for the language]

Got it! Will follow the instructions and report back when we have >200 results in the wild


ReadTimeoutError: PMS5003 Read Timeout: No response after reset

I keep getting this error with PMS5003 plugged to PicoEnviro+

%Run -c $EDITOR_CONTENT
particle.py - Continuously print all data values.
and draw a pretty histogram on display

Traceback (most recent call last):
File "", line 24, in
File "/lib/pms5003/init.py", line 212, in init
File "/lib/pms5003/init.py", line 288, in reset
ReadTimeoutError: PMS5003 Read Timeout: No response after reset
What am I doing wrong?

Have you checked that the cable is securely plugged in at both ends?
Might be worth unplugging the device and restarting Thonny if you haven't tried that already?

yes, thank you for reply. I actually checked that at least 20 times (switched ends too) as it was also my first thought. The problem is also that, it gives the same error without the sensor plugged.  Unless you experts tell me the code/drivers are not good for the pico-enviro+ board, I will contact the vendor for a substitute.

This example code is working fine for me, so I agree that it sounds like you might have a faulty sensor - if you bought it from us please drop a message to support with the order number and a link to this issue and they'll get it sorted for you!
https://shop.pimoroni.com/pages/contact-us

Closing for now, but let us know if the replacement doesn't fix things!


Code folding collapse

If the active line is not visible and you try to collapse code folding, the caret moves up (active line + lines from top) and the code folding is not collapsed.

Fixed.


How to specify pbounds when there are no variable names per se

How do I create pbounds when the function I am optimising can take in an arbitrary number of parameters, e.g.
def bayes_opt_function(*p):
        return my_function(np.array(p))

Thanks

Hi @tomsturges,
the number of parameters needs to be fixed. What kind of problem are you working with?

So I have some code for running an optics simulation.  I am parameterising this height profile with a polynomial. I have a config.yaml file which sets up the whole simulation. One of the parameters is the order of the polynomial I would like to consider. So what I end up optimising is the coefficients of a polynomial, which can vary depending on the config file. I would like to automate the whole process so that e.g. the order of the polynomial and the bounds can be specified in the config file and then the code sets up the optimisation and pbounds. Hence I'm trying to think of a way I can accomplish this. Thanks for your consideration.

First of all, there would be the straightforward way of doing it which is using a very high degree since an n-degree polynomial can be considered an (n+1)-degree polynomial with the (n+1)th coefficient being zero. Please note, that BO is not the best optimization to use for high dimensional optimization settings though.
However I think you might want to question the general idea behind what you're doing. BO relies on the euclidean distance of your data points being meaningful. I think this is not necessarily the case if what you're considering is a vector of polynomial coefficients. As a suggestion, I would look into parameterising your profile with a linear combination of orthogonal polynomials, e.g. Chebyshev polynomials or use some other way of specifying the profile that does not use polynomials.
Disclaimer: This is a tricky problem, and I'm just listing ideas that come to mind.

From the technical/programming perspective, see #349.

Thanks very much for your suggestions. I will look into them and consider them in my project.

Ah! I was having the same problem and was about to implement the kwargs route. I have about 20,000 parameters and I didn't know exactly about how to do this.

@Sulstice if your problem is this high-dimensional you might want to look for a different optimization method. The rule-of-thumb for BO is a maximum dimension of 20, to get an accurate model of the system with this many parameters you'd have to sample points in the ten thousands and with GPR scaling cubically you will run into problems.


[DEVENGAGE-2189] Only add a random suffix on export to resources that have been sanitized with the same matching name pattern

As I mentioned in the https://inindca.atlassian.net/browse/DEVENGAGE-2189 JIRA, adding a random string of digits as a suffix to all resource names that have been sanitized feels very heavy handed. We certainly need to handle the edge case to prevent a name collision on export, but this should only happen if there is the risk of an actual name collision.
This PR adds support for detecting such a name collision and using the same approach to add the string of numbers based on the hash of the original name, or otherwise leaving the name alone after being sanitized.
I also added a test case to check for these various cases.

Here's an example of what it looks like before:
genesyscloud_user_roles.ashley_rapone_genesys_com_3226576763
genesyscloud_user_roles.brian_goad_genesys_com_2300943017
genesyscloud_user_roles.chris_woods_genesys_com_1015040417
genesyscloud_user_roles.fa_advisor1_pjfinancial_com_1944987575
genesyscloud_user_roles.faadvisor2_pjfinancial_com_3819324546
genesyscloud_user_roles.faadvisor3_pjfinancial_com_1654418959
genesyscloud_user_roles.george_ganahl_genesys_com_4023066032
genesyscloud_user_roles.monty_du_pont_com_1458860085
genesyscloud_user_roles.monty_du_pont_com_2192183309
genesyscloud_user_roles.patrick_johnson_genesys_com_2916959053
genesyscloud_user_roles.test_agent_genesys_com_3502235651

and after this change:
genesyscloud_user_roles.ashley_rapone_genesys_com
genesyscloud_user_roles.brian_goad_genesys_com
genesyscloud_user_roles.chris_woods_genesys_com
genesyscloud_user_roles.fa_advisor1_pjfinancial_com
genesyscloud_user_roles.faadvisor2_pjfinancial_com
genesyscloud_user_roles.faadvisor3_pjfinancial_com
genesyscloud_user_roles.george_ganahl_genesys_com
genesyscloud_user_roles.monty_du_pont_com_1458860085
genesyscloud_user_roles.monty_du_pont_com_2192183309
genesyscloud_user_roles.patrick_johnson_genesys_com
genesyscloud_user_roles.test_agent_genesys_com

You can see that it handles the edge case where two resource names could collide and appends the hash suffix to both (each) resource names.


proposal: allow implicit type casting to void functions if functions have the same parameter types

Allow the implicit type casting from functions with a set of arguments and non-void return value to a function with the same set of arguments and void return value.
Example - callbacks:
doSomething := func(callback func()) {
  //...
  callback()
}

foo := func() int {
  return 0
}

Currently, we would have to call doSomething like so:
doSomething(func() {
  foo()
})

With the proposed change, this could be written as:
doSomething(foo)

Example - variables:
This, of course, should also affect variable assignments.
Before:
var bar func() = func() {
  foo()
}

After:
var bar func() = foo

But why? Your proposal doesn’t address the reason why the language should grow this exception. Will this address a widespread deficiency in the use of Go in a specific domain? If so, what alternatives are currently in use? What are their limitations?

But why? Your proposal doesn’t address the reason why the language should grow this exception. Will this address a widespread deficiency in the use of Go in a specific domain? If so, what alternatives are currently in use? What are their limitations?

Please note that you should fill https://github.com/golang/proposal/blob/master/go2-language-changes.md when proposing a language change.

Please note that you should fill https://github.com/golang/proposal/blob/master/go2-language-changes.md when proposing a language change.


Use EntityName as opposed to entities class name in queries

Fix for https://github.com/Blazebit/blaze-persistence/issues/466

Description

Related Issue

Motivation and Context

Would you mind changing the commit message to "#466 - Use entity name as opposed to entity class name in queries to fix #466" and rebase it against my issues/414 branch?

Sure, I’ll reapply it in a bit. As far as I remember I already based it on 414 though, or have there been some squashes?
Jan-Willem
Op 6 nov. 2017 om 18:34 heeft Christian Beikov <notifications<EMAIL_ADDRESS>het volgende geschreven:
Would you mind changing the commit message to "#466https://github.com/Blazebit/blaze-persistence/issues/466 - Use entity name as opposed to entity class name in queries to fix #466https://github.com/Blazebit/blaze-persistence/issues/466" and rebase it against my issues/414 branch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/beikov/blaze-persistence/pull/1#issuecomment-342224790, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADTwtCyMF2YDv7RUOX3RrQ3W5v9nMmanks5sz0MKgaJpZM4QSBZG.

I rebased my 414 branch as I am about to apply it to master.

Or even, better. Do the rebase against the master as I just merged 414 and provide a PR against that please.


race condition between related tables being dumped.

If table A has some values; and table B has a foreign key on table A; then table A will be dumped before table B.
In the time between table A being dumped and table B being dumped, more rows might be added to table A and table B, so that table B now has rows referring to these new un-dumped table A rows.
The two dumps, A.dump and B.dump, now cannot be restored together because table B has a foreign key violation wrt table A.

possible solution is to run the entire dump inside a transaction.


Router issue when two route share nearly similar paths

Hi.
I created two routes:
/binders/<smartcabinet_id:string>/<binder_id:string>
/binders/<binder_id:string>/samples
It seems that the second one will be never used, so I need to change the path, also if the REST definition is right because, in my use case, samples belongs to binders.
Any advice?
sanic 0.2.0

I don't know how the router is implemented but in other frameworks, the order of definition of the routes matters.
Try adding the route with the samples first and the other with the regular expression after.
I.e:
app.add_route(handler1, '/binders/<binder_id:string>/samples')
app.add_route(handler2, '/binders/<smartcabinet_id:string>/<binder_id:string>')

Yeah the way the router works with dynamic routes is through regex so if you define /binders/<smartcabinet_id:string>/<binder_id:string> first then it'll pretty much override any other routes that would match the same regex.
So even though you named different params for the routes they'll still get counted as the same route since dynamic routes work through regex. Unfortunate side effect of dynamic routes in the first place since there's no real easy way to determine if a route matches without regex.
What I would suggest in this scenario is that you either define it first as @argaen said or handle special cases where the binder_id is equal to samples.

ok, thanks