Read and persist state returned in ARTLocalDevice/ ARTDeviceDetails

In trying to make sure behaviour is correct in push notifications, I noticed that the DeviceDetails.DevicePushDetails.state is always null on Android and iOS. A user can get the LocalDevice by calling ARTRealtime#device, to get back ARTLocalDevice, which extends from ARTDeviceDetails, which contains ARTDevicePushDetails. Unfortunately, @property (nullable, nonatomic) NSString *state; is always nil.
It looks like it was never implemented? This value is not null when using the http api/ dashboard, its just the fact that ably-cocoa and ably-java doesn’t ever use it. This value is definitely returned to SDKs which call POST /push/deviceRegistrations. However, it is also returned by other HTTP requests, e.g. PUT rest.ably.io/push/deviceRegistrations/<deviceId>.
Similar ably-java issue: https://github.com/ably/ably-java/issues/697 Note, in ably-java it is an enum: active, failing and failed. It might be worth switching to use an enum. However, it is also null on Ably-java.
┆Issue is synchronized with this Jira Uncategorised by Unito

From slack discussion:

ben.butterworth:
it should be set more often than just in tests? It should be updated when data is received from Ably, so that devices know what state they are? However, it's a field that may change based on the ably servers.
This happens when ably tries to send a message to APNs but if it returns with error, then this state will be updated
ben.butterworth:
that method you showed in screenshot is not used when the device registers/ subscribes, that is used by push admin API when listing device registrations. Push admin is probably a very uncommon feature being used on cocoa (edited)
Maybe we should remove the state field altogether?
its not a very useful field if the client never gets told the error, when the failure happens on the server. Unless the ably-cocoa client can download the latest state from the ably server

So, yes, this field is only updated manually by calling methods with push/deviceRegistrations/<deviceId>. Since there is no way to immediately inform a client app that there was an error while sending push (unless we directly send this error via ARTRealtime object via some diagnostics/system channel) state field will be useless. That's why these methods placed in the Admin namespace, because normally user should not use any of that. All interactions with APNs should be performed on the server, client app only must be subscribed properly (without error during subscription process). I can move ARTDevicePushDetails.h(m) files into the Admin file group, so it would be obvious these are not for customer use. @ben-xD

We expose ARTDevicePushDetails to users, I'm not sure if its just an "admin" feature. Here is how we expose it: ARTRealtime and ARTRest expose push property, which is ARTLocalDevice, a subclass of ARTDeviceDetails, which in turn has a property, push, which is ARTDevicePushDetails. This what I mean, to the user, when they check the device details, this push.state is always null.
Regarding your comments:

I'm not sure which methods specifically you're talking about in the admin file group/ directory. The .push is not an Push Admin feature.
I'm also not sure when you say "for customer use" Push Admin API is still for customer used, but designed for use on the server side. They are not internal to ably SDK.

Anyways, I mean there is no way to update state property immediately. If the users want to know its value they must explicitly call GET push/deviceRegistrations/<deviceId>.

Then perhaps ARTPush#device should be a method that makes that network request to get the state from Ably instead of a property. This way, the user can know for sure if the state/ error related to APNs and FCM is failed when they get the device details. After all, the device details is a network dependent state stored in Ably servers, much like presence, so it should make a network request. We should do this on Ably-java as well.
My preference: Or perhaps a new method ARTDeviceDetails#getPushState() which should make the network request check this FCM/ APNs state. This would affect the activation state machine less.
Alternatively, we should completely remove this state and errorReason field from being available when a user calls ARTPush#device because it is currently useless to a user. Note: It is still useful when being used by Push Admin though. ARTDevicePushDetails type is being used in both push admin and the normal push API.

@paddybyers this would be a breaking change but I think its much better to make a network request on this method call having a field that is null all the time.

One of possible solutions would be to have a system channel ARTRealtimeChannel through which Ably server could send a diagnostics/control messages to its clients, including any push state changes.

Are you suggesting automatically making the client set up a realtime channel permanently to receive any state changes?This is because state change can happen not just when an Ably client is not instantiated, but also when when the app is off/ terminated.
Of course, we cannot use push notifications to update the failed states of Push, since if the state is failed, the push message won't be delivered. If by nature we cannot have it pushed to us, we should request it. Hence my network request suggestion :).

but also when when the app is off/ terminated
True, but server can send all actual information upon system channel successfully attached.

What's the point of all this overhead and complexity in both and realtime when we can update it when it matters by making a network request? (the user calls the device method)

Apparently we already have such a method in ARTPushDeviceRegistrations: get:callback:. It takes deviceId as an argument.

Yes absolutely, that's what I meant by

Note: It is still useful when being used by Push Admin though. ARTDevicePushDetails type is being used in both push admin and the normal push API.

I think listing a device/ clients own subscriptions (device or client ID) should not require Push Admin, but it currently does because it uses the same exact endpoint.
A concern is if we need to add a new endpoint in realtime (or modify the existing one) so that non push admins can get this information too.

I had a call with Paddy, here's what I thought he's trying to say:
Concern: HTTP Request synchronizing with Activation State Machine State
Paddy had concerns with my suggestion of making an HTTP request to get device details from the server. This is because we would probably want to synchronise the device details data received with the local device state used by the activation state machine. I think this state is server state, not local device state, so we should be fine with synchronizing data from the server.
Solution
To avoid synchronizing or having the theoretical inconsistency between this method and local device, clients could make a network request to with ARTPush#getPublishError(). You may think state is important, but if an errorReason is non null, then we can assume it failed. Push#getPublishError() just to get the error reason if there was one. We could still include state if you prefer, calling a method called Push#getPublishState() instead. This is specifically getting state related to push publishing: e.g. if it is successful or the errorReason.
Additional things Paddy said:

Users are expected to call activate on every launch so we validate their device details anyway. (This is not documented anywhere, and I believed we ask users to only call activate once, since the state is saved between app launches. Furthermore, the activation documentation states that it is idempotent, not mentioning any state update:

calling it again when device is already activated has the sole effect of calling its callback.

state is not a useless field if the ARTPush:activate: updates this state when it completes.

I personally think it would be very confusing if state would only change is activate was called. We didn't discuss any current "expected behaviour" mechanism to update this state. (currently its always null when calling Push.device())
paddy also suggested also adding an extra case to the DeviceDetails.Push.State enum, to signal that the activation state was not yet ready, e.g. SYNC or IN_PROGRESS. (those specific cases are my ideas)

My thoughts:
I think the bullet points above are problematic. He had to go to another call so I could not discuss further:

It is confusing if state is only updated when activate is called. users would keep checking the state, and nothing would happen. If a user wants to check on an error, they would have to call activate. This would be confusing for the developer, and future developers/ readability: the code would need comment like: // Calling activate again to check push error state.

So my current suggestion is similar to my previous one, but slightly improved:

Implement a new method ARTDeviceDetails#getPushState() or ARTPush#getPublishState/Error which should make the network request check this FCM/ APNs state/ errorReason. It does no synchronisation with the state machine to keep it simple.
Create a new type to be returned for ARTPush.device, same as before, but excluding state and errorReason (they are always null). Keep the existing type to be returned by Push Admin APIs.

@ben-xD As a temporary solution I can spit a diagnostic message to the console like "To update 'state' field to an actual value you must call 'ARTPushDeviceRegistrations: get' first. Diagnostic messages is a common practice in Apple to notify API users about incorrect usage of the framework (a lot of them in AutoLayout f.e.)."

That won't update the field though? Calling ARTPushDeviceRegistrations:get: you mention will just return different instances of ARTLocalDevice/ ARTDeviceDetails?

Diagnostic messages is a common practice in Apple to notify API users about incorrect usage of the framework (a lot of them in AutoLayout f.e.).

Please don't use this practice. Auto Layout is a very different kettle of fish - and, actually, Apple's 'need' to emit those kind of diagnostics when people get it wrong is perhaps more indicative of problems in their API design. 🤔 In our context, being an SDK that gets embedded into somebody else's app, we can't be brushing stuff like this under the covers like that. Nobody is ever going to see those diagnostics - I guarantee it - as these kind of edge cases are much more likely to be happening at runtime on a customer's device.

@ben-xD You are right, it only gets data, so looks like the new method really needed.

Please see https://github.com/ably/docs/issues/1251 for the discussion.

@maratal is this unblocked now based on the discussion in https://github.com/ably/docs/issues/1251 ?

@jamienewcomb Yes, seems like it can be unblocked

As mentioned by Ben earlier here - https://github.com/ably/docs/issues/1251#issuecomment-968903950, updated server endpoint now supports retrieving push state for the current device without Push-Admin capability. Now I'm not sure whether we should move DeviceRegistrations API out of Admin namespace, but meanwhile it is a mistake in one repo or another (cocoa vs java). Shout out to the server and spec/documentation teams for clarification. See https://github.com/ably/ably-cocoa/pull/1186#discussion_r781164694 for the context.
What is now needed to push this issue forward:

A test device similar to one with the id "testDeviceDetails" (f.e. "testFailedDeviceDetails") which would always return failed state with some error, so I could write a test for the updated endpoint. Currently tests always consider a success.

An update in the docs about the new method and that you don't need Push-Admin capability for the local device.

Alternatively, we can skip adding the new method, as the old one (from DeviceRegistrations API) works now just fine without Push-Admin capability if you pass local device id to it. WDYT @QuintinWillison

I think we need to come to a cross-platform conclusion on how we want to solve this issue. I've created ably/docs#1288, should we continue the conversation there?

Good summary, thanks @lawrence-forooghian (let's continue there).

I don't feel it's helpful to keep this issue open, now that the discussion has been moved to docs/spec. Thanks, @lawrence-forooghian and @maratal. If new work comes out of the spec discussion then that will create a new, focussed, well-scoped issue in this repository.


StreamBuilder with even more streams

The big hold up with just adding StreamBuilder version beyond 7 is our dependency on the Tuple package. It only has types going up to 7.
We'll need to replace the Tuple dependency with likely our own classes to hold the streams and the snapshots.
In doing this I think we should probably go up to StreamBuilder15. I've seen this pattern with generics in other languages and generally 15 or so seems to be a good stopping point.

Something to note, if this is added it will be a breaking change and will require updating to version 2

I'll have more time to actually add this sometime in the next few weeks. If someone needs it before then, PRs are welcome

Closed with the release of version 3.0.0 which added up to StreamBuilder15


Publish on PyPi

Is your feature request related to a problem? Please describe.
Currently, the only way to run GANDLF is to do a git clone and follow setup steps.
Describe the solution you'd like
It would make it much easier to work with if this is presented in PyPI.
Describe alternatives you've considered
Publish on conda is also a solution.
Additional context
A few examples:

https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/pypi?view=azure-devops&tabs=yaml
https://stackoverflow.com/a/57957608/1228757

Opening because still not fixed.

This helped: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/package/twine-authenticate?view=azure-devops#publish-python-distribution-to-azure-artifacts-feed

Done.


[FIX] Stats persistence

Fixes an issue where stats are bound to this.stats and not to the this.db object which interferes with LokiJS persistence adapters.

@Bagaric Looks like only one claim test is failing

@Bagaric Looks like only one claim test is failing

TypeError: found.costs.plus is not a function
Is found.costs of BigNumber type?

@kosecki123 It is. Where do you get that error?

This is from https://travis-ci.org/ethereum-alarm-clock/timenode-core/jobs/416135505 from unit test

Pull Request Test Coverage Report for Build 1304

17 of 17 (100.0%)  changed or added relevant lines in 1 file are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.4%) to 84.44%

Files with Coverage Reduction
New Missed Lines
%

src/Actions/Actions.ts
3
64.15%

src/Actions/Pending.ts
4
40.54%

Totals

Change from base Build 1266:
0.4%

Covered Lines:
559

Relevant Lines:
638

💛  - Coveralls


python311Packages.pycatch22: 0.4.3 -> 0.4.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.pycatch22 is: Python implementation of catch22
meta.homepage for python311Packages.pycatch22 is: https://github.com/DynamicsAndNeuralSystems/pycatch22
meta.changelog for python311Packages.pycatch22 is: https://github.com/DynamicsAndNeuralSystems/pycatch22/releases/tag/v0.4.4
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.4.4 with grep in /nix/store/v6shlxr5rdh7b6mlfkdgjd29hjh2wm5l-python3.11-pycatch22-0.4.4
found 0.4.4 in filename of file in /nix/store/v6shlxr5rdh7b6mlfkdgjd29hjh2wm5l-python3.11-pycatch22-0.4.4

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pycatch22
python311Packages.pycatch22

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/v6shlxr5rdh7b6mlfkdgjd29hjh2wm5l-python3.11-pycatch22-0.4.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.pycatch22 https://github.com/r-ryantm/nixpkgs/archive/327120692f4115efab9ef302976b9e7d899b81ef.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/327120692f4115efab9ef302976b9e7d899b81ef#python311Packages.pycatch22

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/v6shlxr5rdh7b6mlfkdgjd29hjh2wm5l-python3.11-pycatch22-0.4.4
ls -la /nix/store/v6shlxr5rdh7b6mlfkdgjd29hjh2wm5l-python3.11-pycatch22-0.4.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.pycatch22
python311Packages.pycatch22

Maintainer pings
cc @mbalatsko for testing.

license should be updated to gpl3Plus


Add enforce_sub_prefix option to AFQDataset and load_afq_data

Resolves #94

I think this is ready for review @arokem, whenever you get a chance.

I'm going to recommend merging and eating the -0.005% decrease in coverage since the code changes are in datasets.py and the coverage for that file is 100%


adding 33-Search-in-Rotated-Sorted-Array.c

File(s) Modified: 33-Search-in-Rotated-Sorted-Array.c.
Language(s) Used: C
Submission URL: _https://leetcode.com/submissions/detail/782897794/_

Thanks, @PritomKarmokar!


GitHub Copilot Chat Copy/Paste Broken

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.89.1
OS Version: Windows 11 Home 23H2

Steps to Reproduce:

Ask GitHub Copilot a question in the Copilot Chat left side bar.
Copy a few words from Copilot's response and paste them into a text editor.
The entire response Copilot gave is pasted, rather than just the text that was copied.
This is INCREDIBLY annoying!!!

https://github.com/microsoft/vscode-copilot-release/issues/416


[ADD]: LANDING PAGE WITH ANIMATED CARDS ✨

Close #2364
Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

Please review this PR @MohitGupta121


Unclear Scope Requirements for Issuing Authentication Tokens

The documentation says to issue an OAuth2 Bearer Token with the scope 6a8b4b39-c021-437c-b060-5a14a3fd65f3/full_access:

The API is protected through Azure Active Directory and uses OAuth2 bearer tokens. The app registration needs to have the API Permission for Verifiable Credentials Service Admin and then when acquiring the access token the app should use scope 6a8b4b39-c021-437c-b060-5a14a3fd65f3/full_access.

However, if you try to create client_credentials with either the MSAL library or directly with CURL with the above scope, an error is returned: AADSTS1002012: The provided value for scope 6a8b4b39-c021-437c-b060-5a14a3fd65f3/full_access is not valid. Client credential flows must have a scope value with /.default suffixed to the resource identifier (application ID URI).
If you request a scope of 6a8b4b39-c021-437c-b060-5a14a3fd65f3/.default a bearer token is issued, however if you try to use it the API returns the error "Provided access token contains no wids."
I may be misunderstanding something, but is the scope that is provided in this documentation correct?
Raw token request:
POST https://login.microsoftonline.com/<tenant_id>/oauth2/v2.0/token

QUERY PARAMS:
client_id=<client_id>
client_secret=<client_secret>
scope=6a8b4b39-c021-437c-b060-5a14a3fd65f3/full_access
grant_type=client_credentials

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3c965519-3e41-a8fc-1be5-f7e4bdd89c0b
Version Independent ID: 55abf759-0324-2f21-83e4-f2dbaaf9a624
Content: Admin API for managing Microsoft Entra Verified ID - Microsoft Entra Verified ID
Content Source: articles/active-directory/verifiable-credentials/admin-api.md
Service: decentralized-identity
Sub-service: verifiable-credentials
GitHub Login: @barclayn
Microsoft Alias: barclayn

@thenhawke
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@barclayn
Could you Please review and add your comments on this update as appropriate.

#please-close


test(6.4.4-sp): ignore backup tests

Ignore backup tests on stable branch

Already present in https://github.com/googleapis/java-spanner/pull/1445


Rip out kubecfg.sh

It's causing problems and is kind-of GCE dependent anyway, we should just use the kubecfg binary, and document the environment variables it uses.

Reopened since it still needs to be removed.
/cc @jlowdermilk

Doh. Didn't mean to declare this fixed in that PR.

Closing this (again) as it is a dupe of #2144


fix(@vtmn/svelte, @vtmn/vue, @vtmn/react): interactive VtmnRating have duplicate restprops

Related to #1385
Changes description
Add on the VtmnRating svelte component a check on the restProps in order to not apply it on the root level of the component and under if the rating is interactive.
No changes on the class, only on props like aria-label etc ...
Context
In some case, if the component is interactive, the class are applied twice, on the root level and under.
Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on related showcases.
[x] If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

No

Tested on svelte / react / vue on storybook.

Thanks @Tlahey, that's ok for me. I'll let @thibault-mahe review next Tuesday.


fix: make the bot more descriptive

CATEGORY

[x] Build / Development Environment

SUMMARY
Make the request-info bot be more specific about what field is missing.
REVIEWERS
@john-bodley @mistercrunch

Codecov Report

Merging #7279 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7279   +/-   ##
=======================================
  Coverage   64.93%   64.93%
=======================================
  Files         424      424
  Lines       20592    20592
  Branches     2280     2280
=======================================
  Hits        13372    13372
  Misses       7097     7097
  Partials      123      123

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9db605...cd3efb5. Read the comment docs.

Codecov Report

Merging #7279 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7279   +/-   ##
=======================================
  Coverage   64.93%   64.93%
=======================================
  Files         424      424
  Lines       20592    20592
  Branches     2280     2280
=======================================
  Hits        13372    13372
  Misses       7097     7097
  Partials      123      123

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9db605...cd3efb5. Read the comment docs.


CustomSet: Fix erroneous unit test expected value in CustomSetTest

 @Test
  fun `union of non empty sets contains all unique elements`() {
      val set1 = CustomSet(1, 3)
      val set2 = CustomSet(2, 3)
      val expected = CustomSet(3, 2, 1)
      assertEquals(expected, set1 + set2)
  }

I think that this unit test is erroneous. The expected val should instead be CustomSet(1, 2, 3)
All the other unit tests keep the CustomSet sorted ascending except this one.
Without keeping the underlying data structure sorted in some way, the exercise cannot be done.
I will open a PR to fix this if that's alright.

It was not a mistake in the test after having a closer look.


do not merge - testing codeowners

testing: https://github.com/dbt-labs/dbt-core/pull/7406

Description

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

👍 Confirmed that Cloud Artifacts is tagged on these changes, but does not block merge on review, as desired.
Merging blocked before review:

Review from core team, not in cloud artifacts team:

Merging unblocked on passing CI checks:


Updated: webstorm 192.6817.13

Newer version of webstorm (192.7142.35) is now available in master. e18c5a6417b65f9af059ed07b38e4d7397416dfb


PickerPoint position issue

When using React-Times as controlled component and updating time form outside the setStep function is not beeing called while time does. This is cousing weird result. When we open picker after updating time the hour in picker is ok but in place of previous one.

Anyone intrested in fixing this?


Provide more meaningful error responses

For optional parameters that are conditionally required, rather than just proxying the API's - "Param X is required" we need to validate the response and send a more meaningful message to the client like "Param X is now required as we have Param Y set".

As per previous discussions with Prasanna and Fod, We do not validate request and response of T1-Java. All error messages we send to client, are directly coming from T1 mediamath API.

Agreed – the push-back here should be on the API to provide a more meaningful message. Attempting to second-guess dependencies on parameters in the SDK will replicate business logic and introduce another maintenance overhead.

@FodT True, by right it should be the API which should take this responsibility. But given our API's short-comes should our SDK's take this so that we have happy clients is my thought.


Add .circleci/config.yml

@ama-ch
It seems to be working fine. Please review this 🙏

LGTM!

LGTM! Thank you :octocat:

Thanks!


Updated the Readme.md with to be compatible with the current code

Code changes because of lombok integration
Added separate example file for Readme.md example
Ensures that the example is built separately (imports, etc.)

The Readme.md has some small errors, because with the introduction of lombok, the TableDrawer Syntax changed. Also, the colors are not accessible, because they are part of the integration tests.
To resolve this issue, I created a this PR that runs the Readme.md example in a separate file. It would be great to just do an include of the lines into the Readme.md, but this is apparently not possible.

I like the idea to extract the code into a file of its own. Also I agree that it would be nice to just include it in the README directly (it is cumbersome to always copy it). Maybe this could be done by a git hook so that before every commit the contents or part of the contents of the extracted file is/are replaced in the README.
I will have a look in the next days.

Will merge this now, but I think I will replace the actual code in the README with the link to the extracted file at one point – the duplicated stuff is otherwise hard to maintain (keeping in sync).


Change slidefrom based on viewport

I would like to know if it´s possible to change the slidefrom direction based on the viewport width. For example slide right on desktop but slide from bottom on mobile, so that it fits better on screen. I've tried removing the class 'right' and adding class 'bottom' depending on window width with jQuery:
if (jQuery(window).width() < 575) {
  jQuery('.slide-out-panel').removeClass("right");
  jQuery('.slide-out-panel').addClass("bottom");
}

But this doesn't work. I also tried just changing the CSS based on the viewport, which does stick the content to the bottom but animation still slides from the right:
@media (max-width:575px) {
  #slide-out-panel {
    bottom: 0;
    top: initial !important;
  }
}

The reason the CSS doesn't work is that the javascript is doing some of the work. Perhaps adding a feature to change the direction if mobile would be a useful update to the plugin when I have some time.
This is one way to do it. It's not perfect, but it works. It does need a little bit extra to remove the .close-slide-out-panel element as it adds a new one each time you initiate the panel. It also needs to remove the style attribute to correct the position when it changes to the bottom. It is something I should fix when I have the time, as the adjustments for it in the code below is a bit hacky.
var changingPanel;

function changePanel() {
  // If you have more than one panel being used //
  // $('.close-slide-out-panel[data-id="changingPanel"]').remove();

  // If you have only one panel being used //
  $('.close-slide-out-panel').remove();

  // This is to correct the 'right' style position of the slide when it changes direction //
  $('#changingPanel').removeAttr('style');

  if (window.innerWidth <= 575) {
    changingPanel = $('#changingPanel').SlideOutPanel({
        slideFrom: 'bottom',
    });
  }
  else {
    changingPanel = $('#changingPanel').SlideOutPanel();
  }
}

changePanel();

var resizeTimer;

$(window).on('resize', function() {
  clearTimeout(resizeTimer);
  resizeTimer = setTimeout(function() {
    changePanel();
  }, 250);
});

Thanks, works great. Only the container is not full width. I've tried .slide-out-panel-container {
width: 100vw !important;
}
@media (max-width: 768px) {
.slide-out-panel-container.open {
width: 100vw !important;
}
}`
But it gets ignored.

It was full width when I tested locally. Do you have a repo or site that I can take a look at to see what it's doing for you?

Sure, I sent you an email

In your JS you need to remove the code below. What's happening is that the panel is being initiating twice on page load. Calling changePanel()on load is doing the initiating already. Remove this from the code and give see if that works.
const slideOutPanel = jQuery('#slide-out-panel').SlideOutPanel({
    slideFrom:'right'
});

But if I do that, the slidepanel won't open on click.

The click handler looks like it's using the wrong class name.

You mean jQuery('body').on('click', '.slideout', () => {     slideOutPanel.open();   }); ?  Because if I don't and use your code nothing happens

As it is right now, it's initiating the panel on an element with the ID of #changingPanel which doesn't exist on your page. Your panel ID is #slide-out-panel. You can either change it to #changingPanel as your panel ID, or just update #changingPanel to the ID you are using. Completely up to you how you want to name it.


Clean up forecast modules

Use common generate_cutoffs for pmdarima and prophet training
Move import outside of prophet estimator and fit function
Improve test coverage

Manually tested e2e automl forecasting with custom wheel

high_temp: https://e2-dogfood.staging.cloud.databricks.com/?o=6051921418418893#notebook/4240927549507925/command/4240927549507935
store_item_demand (multivariate): https://e2-dogfood.staging.cloud.databricks.com/?o=6051921418418893#notebook/4240927549508282/command/4240927549508293
weekly_count (weekly): https://e2-dogfood.staging.cloud.databricks.com/?o=6051921418418893#notebook/4240927549509244/command/4240927549509254

Also double check on the test coverage.

I think the test coverage looks good.
---------- coverage: platform linux, python 3.8.12-final-0 -----------
Name                                                             Stmts   Miss  Cover
databricks/init.py                                               1      0   100%
databricks/automl_runtime/init.py                                0      0   100%
databricks/automl_runtime/forecast/init.py                       1      0   100%
databricks/automl_runtime/forecast/pmdarima/init.py              0      0   100%
databricks/automl_runtime/forecast/pmdarima/diagnostics.py          26      0   100%
databricks/automl_runtime/forecast/pmdarima/model.py               129      1    99%
databricks/automl_runtime/forecast/pmdarima/training.py             61      1    98%
databricks/automl_runtime/forecast/pmdarima/utils.py                24      0   100%
databricks/automl_runtime/forecast/prophet/init.py               0      0   100%
databricks/automl_runtime/forecast/prophet/forecast.py              67      1    99%
databricks/automl_runtime/forecast/prophet/model.py                 98      3    97%
databricks/automl_runtime/forecast/utils.py                         23      3    87%
databricks/automl_runtime/hyperopt/init.py                       0      0   100%
databricks/automl_runtime/hyperopt/early_stop.py                    25      0   100%
databricks/automl_runtime/sklearn/init.py                        3      0   100%
databricks/automl_runtime/sklearn/base_datetime_transformer.py      30      0   100%
databricks/automl_runtime/sklearn/column_selector.py                14      0   100%
databricks/automl_runtime/sklearn/date_transformer.py                7      0   100%
databricks/automl_runtime/sklearn/timestamp_transformer.py           8      0   100%
databricks/automl_runtime/utils.py                                  10      0   100%
databricks/automl_runtime/version.py                                 0      0   100%
TOTAL                                                              527      9    98%


Add ioBroker to "used in" list.

ioBroker looks cool! I'd love to hear about your experience using Sonus and what additional features you'd like to see. Shoot me an email if you've got the time 😊


Uploaded BU line lists #161

You are a superstar @anelda

@anelda can we deal with the - vs _ issue.

Oh gosh! The devil is in the details. Please see #190 192


Enhance tap-mongodb extractor

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/631
Originally created by @bencodezen on 2019-05-02 19:52:53

Currently the tap-mongodb has a warning on it for only being a proof of concept. We need to find a way to make this more reliable.

View 2 previous comments from the original issue on GitLab


[Screen Reader -  Bot Framework Web Chat- Card Sports] Descriptive information about the 'image' link controls is not announced which appears after sending 'card sports' text

User Experience:
If descriptive information about the 'image' link controls is not announced which appears after sending 'card sports' text, the screen reader dependent user will not get proper descriptive information about the link control. The user will face issue in navigating to the control and utilizing it's functionality.
Note: Login Credentials must not be provided within the bug.
Test Environment:
OS Version: 21H1
OS Build: 19043.1110
Browser: Microsoft Edge Version 94.0.972.2 (Official build) dev (64-bit)
Screen Reader: Narrator, JAWS, NVDA
Repro steps:

Open URL provided by product team.
Web chat bundle will open.
Navigate on the web chat bot and select microphone icon.
Speak "help" keyword in Type your message box, then select send button.
Cards related to the keyword will appear, navigate on the cards.
Verify the issue.

Actual Result
Descriptive information about the 'image' link controls is not announced which appears after sending 'card sports' text. Only 'Image' and control type as link is announced when focus is navigated on the control.
Expected Result
Descriptive information about the 'image' link controls should be announced which appears after sending 'card sports' text. When the focus reaches on the control, proper role and image description should be announced for each and every control.
Note:
This issue exists with NVDA and JAWS also.
This issue exists with similar controls throughout the application.
WCAG Reference
WCAG 1.3.1 – Info and Relationships
Reference Links
Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.

#A11yMAS;#A11ySev2;#HCL;#MAS1.3.1;#NonBenchmark;#Accessibility;#Win10-Edge(Chromium);#E2E-HCL-BotFrameworkWebChat-Aug21;#AILimited;

This is an Adaptive Cards issue.
Could you file it to them at https://github.com/microsoft/adaptivecards?
FYI, I have attached the content of the card here.
BingSports.txt

I have attached the DOM node for your reference.

Descriptive information about the 'image' link controls should be announced which appears after sending 'card sports' text. When the focus reaches on the control, proper role and image description should be announced for each and every control.

On the DOM node, I am seeing both alt and role set. And it seems to fulfill the requirement ("proper role and image description").
As we do not own the Adaptive Cards control, if this is an issue, please file it to Adaptive Cards team.

Studied a bit more. It seems it is an Adaptive Card problem. They should not convolute the link image with the .
When we try to reproduce the DOM tree as rendered by Adaptive Cards library. It becomes:

When combining link and image as a single element, the screen reader will NOT narrate the alt text.
The following is our pure HTML repro. Given 2 image links below: Panthers and Seahawks. The Panthers logo is . The Seahawks logo is .

The Panthers logo, when navigating using screen reader, we will hear:

"Link image open URL action", when CAPS + DOWN is pressed, it will be followed by
"Panthers logo"

For the Seahawks logo, we will hear:

"Link image open URL action"
After CAPS + DOWN is pressed, it will NOT narrate "Seahawks logo"

Filed a bug to Adaptive Cards repo, https://github.com/microsoft/AdaptiveCards/issues/6442.

Since the image label (a.k.a. alt text) is ignored, in the meanwhile, I will change the Adaptive Cards JSON to be more descriptive on the link label.

As verified this issue is fixed now. Here screen reader is announcing correct descriptive information about the image link. Hence closing the issue

Thanks @v-shikch and @mishraadi. Appreciated.


feat(interfaces): Update interfaces for export

Fixes #10

Updates the interfaces and exports so that modules can be directly imported from the main module

import zoominfo, { ICompanyEnrichResults, IContactEnrichResults, ZoomInfoException } from 'zoominfo-node'

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


kernel-headers: fix asm symlinks

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Hmm will target staging, 1 second.

Github is being special, #36303


Bug: NavList SubNav active state

Description
Hi there 👋  I'm running into an issue where if a NavList SubNav is closed and there are no aria-current children that are active, the active state is still on the SubNav level.
https://github.com/primer/react/assets/22055162/67e25d6f-34c9-44f8-a6ce-39242c874903
Please let me know if I'm misunderstanding, but I would have expected that if all the aria-current in the children were false there would be no active marker on the parent of those children. Thank you so much!
Steps to reproduce

Create a NavList with multiple parents that have children
Set aria-current based on the child route being equal to the current page
Open and close different parents after clicking on different children

Version
v35.26.1
Browser
Chrome

Hi, Can I work on this issue?

Related + more context: https://github.com/github/primer/issues/2512

Hey @joshblack / @siddharthkp , i would like to take up this issue, if it's open.

@gracepark Can we close this as completed by https://github.com/primer/react/pull/3698

Yes we can @siddharthkp! Closing now, thank you.


SDA-8538 | fix: create hcp account roles in interactive mode

Note: this change will be available in prod once all managed policies are published.
Example:
oadler@fedora:rosa (SDA-8538)$ ./rosa create account-roles -i
I: Logged in as 'oadler.openshift' on 'https://api.stage.openshift.com'
I: Validating AWS credentials...
I: AWS credentials are valid!
I: Validating AWS quota...
I: AWS quota ok. If cluster installation fails, validate actual AWS resource usage against https://docs.openshift.com/rosa/rosa_getting_started/rosa-required-aws-service-quotas.html
I: Verifying whether OpenShift command-line tool is available...
I: Current OpenShift Client Version: 4.11.0
I: Creating account roles
? Role prefix: oadler
? Permissions boundary ARN (optional):
? Path (optional):
? Role creation mode: auto
? Create hosted CP account roles: Yes
I: Creating roles using 'arn:aws:iam::765374464689:user/oadler'
I: Created role 'oadler-HCP-Support-Role' with ARN 'arn:aws:iam::765374464689:role/oadler-HCP-Support-Role'
I: Created role 'oadler-HCP-Worker-Role' with ARN 'arn:aws:iam::765374464689:role/oadler-HCP-Worker-Role'
I: Created role 'oadler-HCP-Installer-Role' with ARN 'arn:aws:iam::765374464689:role/oadler-HCP-Installer-Role'
I: To create an OIDC Config, run the following command:
	rosa create oidc-config
I: To create a cluster with these roles, run the following command:
	rosa create cluster --sts

/lgtm


Bootstrap 3.21 CMake

msquic depends on >= 3.20 cmake, and currently visual studio 2019 images we provide in internal build have less than this.

@wfurt: Trying out CMake bootstrapping in this build

OK, I realized there was a ps1 file downloading 3.18.4 and worked through the rest of the problems, current commits reflect this.
This build in internal is running the latest commit to validate that it's capable of getting new-enough Cmake.

Also filed https://github.com/dotnet/arcade/issues/7689 which I noticed while poring over these logs.


Pin interactive

Adds pinning of primary column when section is scrolled and secondary column is longer than primary column. use-resize-observer library was added to get the final height of the primary column on render.
Refactor section and its styling into it's own component
Puts embeddable styling back in the embeddable.scss
Fixes overlapping columns when browser window is resized.
Changes embeddable schema from is_full_width to is_half_width

Removed duplicate commits when branched off responsive-layout


Unclear how to pass options to the ValidationPipe

From the documentation, it's unclear how you are supposed to pass validation pipe configuration options. I am trying to prevent the received document to pass validation when it contains keys that I don't expect. Example

class CreateProductInput {
  @IsNotEmpty()
  url: string | undefined;
}

class ProductHandler {
  @Post()
  @HttpCode(201)
  public async create_product(@Body(new ValidationPipe(options = {forbidNonWhitelisted: true, forbidUnknownValues: true})) body: CreateProductInput) {
}
}

The above code does not work: error - ReferenceError: options is not defined.
I also tried without new, with no result:
public async create_product(@Body(ValidationPipe({forbidNonWhitelisted: true, forbidUnknownValues: true})) body: CreateProductInput) {

The type hinting seems to say I should pass the options at construction:
(alias) ValidationPipe(options?: ValidationPipeOptions | undefined): ParameterPipe<any, unknown>

Moreover, how can one set it globally for all validations?

Hi @stefanoborini
Your second example is the correct one:
public async create_product(@Body(ValidationPipe({ forbidNonWhitelisted: true, forbidUnknownValues: true })) body: CreateProductInput) {

The fact that it doesn't work is most probably not related to next-api-decorators but how you construct your class and how you configure class-validator and/or class-transformer.
If you are sure the problem is related to next-api-decorators, please provide a minimum reproducible repo and feel free to reopen the issue.

Moreover, how can one set it globally for all validations?

Unfortunately it's not possible to set validation options globally, as Next.js handles the routing. Your safest bet would be assigning the options to a global variable and pass it to each ValidationPipe instance.


When using ThemeManager::addThemeLocation maintain new themes

This is only an issue when using Laravel. When ThemeManager::addThemeLocation is called
Possible solution: add a static variable within the ThemeManager class.
Possible solution: Use global either in a function or within ThemeManger.
There will need to be a way to reset static/global variable, mainly for testing at this point.

After some testing this seems to not be true. Tested using a themes folder and a folder called themes-alternative (one theme w/name equal to example-theme).
debug( \ThemeManager::themeExists('example-theme') ); //false

\ThemeManager::addThemeLocation(base_path('themes-alternative'));

debug( \ThemeManager::themeExists('example-theme') ); //true


Error with shadcn-ui

I think shadcn changed their CLI so might need to pin the version to 0.8.0?
claude-tools new-app
Welcome to Claude Tools App Creator!
? What is the name of your project? claude-artifacts
? What should we name the main component? MyComponent
? Would you like to install and use lucide-react icons? Yes
Creating a new Claude app: claude-artifacts
✔ Creating Vite app
✔ Installing dependencies
✔ Installing Tailwind CSS
✔ Configuring Vite
✔ Creating jsconfig.json
✔ Configuring shadcn-ui
✖ Initializing shadcn-ui
Error initializing shadcn-ui
Command to run manually: npx shadcn-ui@latest init --yes

Yea, I think they updated their cli tool. I need to fix it at some point but I haven't yet got around to it.


add RecordParser

Hi! I saw your post and I would like to add my parser on benchmark, when this PR is finished.

Hey @leandromoh, thanks for taking the time to open a PR. It looks like the CI is complaining about some missing types. Perhaps we're missing the package reference in the .csproj to https://www.nuget.org/packages/recordparser?

Perhaps we're missing the package reference in the .csproj

yes, I was working with a local reference, whilist the PR was in draft, to do some experiments..
It was a bit funny that your benchmark test the exactly cenario that my lib was not thought to resolve, that is , when you want to get all column values as string before to parse to specific type (ex. int). I designed RecordParser exactly to avoid intermediary unnecessary string allocations, if a field is some value type, like int for example, I parse it without intermediary string, in a straight manner from ReadOnlySpan<byte> (from file) to ReadOnlySpan<char> and finally int.
Surprisely the lib was good, at least on my pc.

@joelverhagen PR is ready for review


Working with Lombok without any IDE plugin

Is it possible to work with Lombok without any IDE plugin? As we can do it with Immutables, for example?
It's a pain to be dependent on third-party plugins (

Of course you can. Just ensure lombok.jar is on the classpath when invoking javac. Maven or Gradle will do that for you if you add Lombok as dependency. But you can also do it completely manual.
However, if you use IntelliJ, you will still get error markers, and its internal compiler will not work. That means you have to invoke Maven/Gradle each time you make a change, and things like hot code replace won't work.

I have Lombok dependency in Maven pom.xml like the follows (it's generated with Spring starter):
    <dependencies>
        ...
        <dependency>
            <groupId>org.projectlombok</groupId>
            <artifactId>lombok</artifactId>
            <optional>true</optional>
        </dependency>
        ...
    </dependencies>

Then I comile the project I can see comiled classes in the target/classess/ folder with Lombok code. But I can't see any generated source files in the target/generated-sources folder (as other code generators do, for example Immutables or MapStruct). So then I turn off the Lombock plugin in IntelliJ IDEA I get error markers in the code. So is it possible to make Lombok to generate such source code?

Lombok is not a code generator. It makes its changes directly during compilation, so Lombok only affects the compiled class files.
You can use delombok to get what would be the Java code for what Lombok generates, and work with that. However, you loose all Lombok annotations and, thus, the brevity of them.

Thank you for clarification. )
It would be great if code generation was implemented - we wouldn't depend on third-party plug-ins...

That is conceptionally impossible, because Lombok's annotations modify the source file they are in. You cannot achieve this functionality with a classic code generator.

@Cepr0 What you want is plain impossible. You want to write @Getter in your IDE and to get it now. In the same class, in your IDE. You don't want a generated read-only code somewhere, which your IDE could simply reload; you want you IDE to see changes in the file you're just editing.
In Eclipse and Netbeans, all you need is lombok.jar installed in the IDE. It's not third party, it's the only file this project produces. For intellij idea, you indeed need a third party plugin.


'utf8' codec can't decode byte 0x9c in position 1: invalid start byte

I'm receiving utf-8 errors, seems to be while sending statistics.
2016-08-20 10:59:51,041 [PokemonGoBot] [INFO] [api_error] Session stale, re-logging in.
Traceback (most recent call last):
  File "pokecli.py", line 674, in <module>
    main()
  File "pokecli.py", line 176, in main
    report_summary(bot)
  File "pokecli.py", line 211, in report_summary
    metrics.capture_stats()
  File "/usr/src/app/pokemongo_bot/metrics.py", line 84, in capture_stats
    response_dict = request.call()
  File "/usr/src/app/pokemongo_bot/api_wrapper.py", line 217, in call
    if not self.can_call():
  File "/usr/src/app/pokemongo_bot/api_wrapper.py", line 118, in can_call
    raise NoPlayerPositionSetException()
pgoapi.exceptions.NoPlayerPositionSetException
2016-08-20 10:59:51,054 [sentry.errors] [ERROR] Sentry responded with an error: 'utf8' codec can't decode byte 0x9c in position 1: invalid start byte (url: https://app.getsentry.com/api/90254/store/)
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/raven/transport/threaded.py", line 174, in send_sync
    super(ThreadedHTTPTransport, self).send(data, headers)
  File "/usr/local/lib/python2.7/site-packages/raven/transport/http.py", line 47, in send
    ca_certs=self.ca_certs,
  File "/usr/local/lib/python2.7/site-packages/raven/utils/http.py", line 66, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 494, in open
    response = self._open(req, data)

  File "/usr/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 512, in _open
    '_open', req)
  File "/usr/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 466, in _call_chain
    result = func(*args)
  File "/usr/local/lib/python2.7/site-packages/raven/utils/http.py", line 46, in https_open
    return self.do_open(ValidHTTPSConnection, req)
  File "/usr/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 1284, in do_open
    h.request(req.get_method(), req.selector, req.data, headers)
  File "/usr/local/lib/python2.7/httplib.py", line 1057, in request
    self._send_request(method, url, body, headers)
  File "/usr/local/lib/python2.7/httplib.py", line 1097, in _send_request
    self.endheaders(body)
  File "/usr/local/lib/python2.7/httplib.py", line 1053, in endheaders
    self._send_output(message_body)
  File "/usr/local/lib/python2.7/httplib.py", line 895, in _send_output
    msg += message_body
  File "/usr/local/lib/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0x9c in position 1: invalid start byte
2016-08-20 10:59:51,056 [sentry.errors.uncaught] [ERROR] [u'NoPlayerPositionSetException', u'  File "pokecli.py", line 674, in <module>', u'  File "pokecli.py", line 176, in main', u'  File "pokecli.py", line 211, in report_summary', u'  File "pokemongo_bot/metrics.py", line 84, in capture_stats', u'  File "pokemongo_bot/api_wrapper.py", line 217, in call', u'  File "pokemongo_bot/api_wrapper.py", line 118, in can_call']

running with dev a1c9419521c9ed28e361aaecc87581addfce6ba8

#4368

The previous suggestion to update pgoapi to 1.1.8 doesn't work (#4368). I have version 1.1.8 and I'm getting this error. Details reported in #4477

same on OS X darwin...

After bi-secting, this issue happened after commit "695ca70305be244a5c6fc12464d5242f14f648e7".
While "d02152308882c31329df72a2de1309b978fdfcef" was the last okay commit.

After bi-secting, this issue happened after commit "695ca70305be244a5c6fc12464d5242f14f648e7".
While "d02152308882c31329df72a2de1309b978fdfcef" was the last okay commit.

UnicodeDecodeError: 'utf8' codec can't decode byte 0x9c in position 1: invalid start byte
2016-08-22 13:28:06,025 [sentry.errors.uncaught] [ERROR] [u"NameError: global name 'fort_details' is not defined", u'  File "pokecli.py", line 685, in ', u'  File "pokecli.py", line 118, in main', u'  File "pokemongo_bot/init.py", line 565, in tick', u'  File "pokemongo_bot/cell_workers/catch_pokemon.py", line 29, in work', u'  File "pokemongo_bot/cell_workers/catch_pokemon.py", line 91, in get_lured_pokemon']

It looks like this issue can be duplicate to (#4528).

@mjmadsen close this?

Yeah.


Completion percentage

Not specifically a txgh issue, but (pursuant to our email exchange) something I wanted to get on the radar.
At the moment, the Transifex hook only fires once a translation is at 100%.  While I can see some logic to this, I think it is essential to make this a configurable setting in either Transifex or txgh, so we can specify the percentage.  This is after all a tool for continuous integration of Github and TX, so it seems a shame not to be able to actually use it to fully do that.
So either Transifex should fire the hook on every change and txgh decides what completion percentage it wants on a per-project basis, or the hook at Transifex should be configurable with the trigger percentage.  Or both, really.
Thanks for listening.  :)

We'll need a polling mechanism in Txgh with added configuration that allows you to set how often to pull translations.  The 'percent complete' logic can then be added in a configurable way on the Txgh side without relying on Transifex.

In another response, you said you didn't think modifying the webhook on the Transifex end to allow a configurable trigger percentage would get on the road map "any time soon".
Who would we need to lobby at Transifex to make that happen?
I'm not against polling in principle, but my project has over a thousand language files.  That's not really conducive to polling.

@cheesegrits You just lobbied.   We pay special attention to any requests coming from the community.    :+1:
I'll still keep the polling mechanism as an open issue because it allows the greatest flexibility in Txgh and can cover more generalized cases for smaller projects.  That allows the Transifex core web hooks to focus on more streamlined use cases.

I totally agree that polling would be a very useful feature.  But for larger projects ... speaking of which, I actually I massively underestimated the number of language files we have.  I forgot we added a lot of new languages last year).  We now have a tad under 4000 ...
[vagrant@vagrant-centos65 joomla30]$ grep trans. .tx/config | wc -l
3958
Having a working txgh has massively improved our Transifex integration, but our lives would be complete if we could get that option to trigger the Transifex hook on every change.
Thanks for all your work on this so far.

I totally agree that polling would be a very useful feature.  But for larger projects ... speaking of which, I actually I massively underestimated the number of language files we have.  I forgot we added a lot of new languages last year).  We now have a tad under 4000 ...
[vagrant@vagrant-centos65 joomla30]$ grep trans. .tx/config | wc -l
3958
Having a working txgh has massively improved our Transifex integration, but our lives would be complete if we could get that option to trigger the Transifex hook on every change.
Thanks for all your work on this so far.

Any word on this?
I'm doing another build of my product, going through my 3 monthly pain with pulling all 3156 translation files from Transifex with a manual client pull.
It'd be REALLY nice if we could get rid of that 100% thing ...

@cheesegrits
Alright so we have had success getting this request on the roadmap to alter the webhook behavior in the core product.  But there is still some specification work todo before actual development can start.
What about going back to the polling idea?  That's something I can quickly whip into Txgh and while it won't be 'realtime'ish it should save you having todo manual pulls.

It would definetely help while we wait for realtime.

Any news on poll or realtime?


[SDA-8387] Add possibility to delete operator roles from prefix

Related issue: https://issues.redhat.com/browse/SDA-8387
What
Operator roles created from/for BYO OIDC clusters do not have cluster ID tag, so it is required to provide a different way of deleting them
Why
Facilitates flow for customers so they don't need to deal directly with aws console/cli

/lgtm

/lgtm


Fix typos and unit test of ares-log

:Release Notes:
Fix typos and unit test of ares-log
:Detailed Notes:

Fix miss typos
Update unit test of ares-log

:Testing Performed:

Pass unit test
Pass eslint

:Issues Addressed:
[WRN-15807] Prepare to release CLI v2.3.0

@YoungeunKim
I'll wait for an answer and merge this commit about files/templates/ose-sdk-templates/bootplate-web/index.html


ASP.NET Core 2

It's been out for a while. You, as Microsoft, should have a starter pack for it out of the box.

Hey! Why don't you contribute, since we're so lame. :-) In fact, you're right. Let's get someone on that.

Nobody on the team has .NET Core experience, believe it or not. Having a beefier set of language packs available is on the roadmap, but we're still nailing down the user experience before we start expanding beyond our own knowledge base.
As @squillace said, write one up if you feel motivated!

@squillace The last time I touched .NET was back in 2008, but I will give it a try and submit a PR as it doesn't look a big deal anyway.

@nikolay: I'll make you a deal. You give it a shot (hopefully it should be fairly straightforward), and I'll have the core team come over and vet it. :-) Everyone will learn something, I'm sure.

@squillace You made me an offer I can't refuse! 😄

Most excellent.

Yeah, @nikolay, I think we can get some help. https://twitter.com/sajaya/status/908180245026529282. :-)

One problem with adding "another" ASP.NET pack at this point is that Draft does not have a way to determine the difference between two identical packs: #308
We first need to handle the case where there may be multiple versions of a pack available in $(draft home)/packs via draft create before we can support ASP.NET 1 and ASP.NET 2 applications identically.

worthwhile test case to use to solve the issue.


person payload

What is the best way to set the person payload? Using Rollbar.configure won't work in  this case because it's not loaded in dev and test mode (issue).

Hm, perhaps checking for the existence of the Rollbar global first, i.e. Rollbar && Rollbar.configure(...)? The addon does this, and it's probably a good idea for your own app code to do so as well - you can't guarantee that the Rollbar lib successfully loaded (since it's hosted on Rollbar's CDN).

Chris from Rollbar support here, just saw this (sorry I missed it so long).
Anything you can configure can be put in the _rollbarConfig. So:
var _rollbarConfig = {
  /** The Usual **/
  payload: {
    /** Other stuff **/
    person: {
      id: getPersonId()
    }
  }
};


v.0810i

👷 Deploy Preview for analyticalnutrition processing.
🔨 Explore the source changes: 38bcb5e3ba54bd219c48012cb485f471daa0c0d5
🔍 Inspect the deploy log: https://app.netlify.com/sites/analyticalnutrition/deploys/61133eb9de00a200071e2d31


Update sbt to 1.5.5

Updates org.scala-sbt:sbt from 1.4.9 to 1.5.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-minor

Codecov Report

Merging #8 (0f04ca4) into master (8fa0913) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   68.11%   68.03%   -0.09%
==========================================
  Files          36       36
  Lines        1170     1170
  Branches       34       34
==========================================
- Hits          797      796       -1
- Misses        373      374       +1

Impacted Files
Coverage Δ

...scala/zio/tarantool/internal/ResponseHandler.scala
69.56% <0.00%> (-4.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa0913...0f04ca4. Read the comment docs.


Update verbose logging

Right now we log stack traces of every "starting" subscription. This makes it difficult to figure out which subscriptions are still ongoing at any given point. We have to look at logs and compare memory addresses of OnSubscribe objects.
Instead let's track the ongoing subscriptions, capture their stack trace when they are initially started, and then only print those stack traces when asked (i.e. "how may are left ongoing?").

@rosshambrick if we do this, do you think we still need the AtomicInteger counter? Can we just use the size of onSubscribeList instead?

I think you could just use the side of the list.  We need to make sure it's thread safe though.

Can you update the README to reflect the new troubleshooting method based on this change?

Did this PR just die?

I just closed it cause it had gotten stale and I don't really need it for that one project.


can‘t watch directory changed when create file by other program

when we create directory or files to the path which the droppy mount, but the droppy don't update the file list.

Which OS and file system is this on? If it is a network drive, you may need to set the pollingInterval option.


context menu

option "add friend"  on the same position like "show user info"

Duplicate, more description in #55


[Bug]: (minor) Application title displaying incorrectly

Bug Description
Application title bar does not correctly display 'document name - vault name - obsidian version'.
Relevant Screenshot

window title with note opened

window title with no note opened
To Reproduce
n/a
Obsidian Version
0.15.6
Installer Version
0.14.15
Font Size
17
Which editor are you using?

[ ] New Editor
[ ] Legacy Editor

In which mode(s) does the problem occur? (if applicable)

[ ] Source (Edit)
[ ] Reading (Preview)
[ ] Live Preview

Which operating system?

[ ] macOS
[X] Linux
[ ] Windows
[ ] iOS
[ ] Android

Plugin-Specific Problems

[ ] I took note of the specific instructions regarding those plugins.

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Themes - Manage → Update).
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] In case I am missing an UI element, I have checked that it cannot be re-enabled with the Style Settings plugin.
[X] If the bug occured after updating the theme, I read the last couple of entries in the changelog to make sure the bug is not an intentional change. (In that case, there will most likely be a style setting to turn it off again.)

Hi! As you may have heard, the upcoming Obsidian update 0.16 has a massive amount of changes for theme development, necessitating a complete rewrite of Shimmering Focus. This means:

A lot of bugs and feature requests will be obsolete. with Obsidian 0.16 and the rewritten Shimmering Focus.
As the theme has over 15,000 lines of CSS, the rewriting will take a considerable amount of time. Recreating the core features alone will likely take me a while, so I simply will not have much time to implement many feature requests, since the recreation of the past core features has priority.

Basically, this is the reason why I am – for now – closing this issue. If your bug still exists / your feature request is still relevant in the upcoming version 3.0 of Shimmering Focus, please comment here and I will re-open it. 🙂


[DPG]: Improve the layout of functions parameters in autogenerated document

The auto generated document for DPG contains some raw data which is not well formatted.
example:  https://docs.microsoft.com/en-us/java/api/com.azure.iot.deviceupdate.deviceupdateclient?view=azure-java-preview
Please improve the document to be consistent with other java libraries.

Would do you mean by raw data?
Without these data, how does customer know what kind of model to set as payload and response body?


ZombieComponent is getting bloated as dear god

It should be like 3 separate components at this stage as people keep trying to tack things onto it.

zombie were reworked, so


When grids are turned into shuttles they lose all collisions.

Placed a seat on the station grid and found it was locked in place from some collision, teleported it west a bit and all the players that came with it could start walking and shooting through walls.

This is probably because of the DynamicTree stuff @Tyler-IN

Not an issue. Source: Sloth.


MINOR: Remove SubscribedTopicRegex field from ConsumerGroupHeartbeatRequest

The support for regular expressions has not been implemented yet in the new consumer group protocol. This patch removes the SubscribedTopicRegex from the ConsumerGroupHeartbeatRequest in preparation for 3.7. It seems better to bump the version and add it back when we implement the feature, as part of https://issues.apache.org/jira/browse/KAFKA-14517, instead of having an unused field in the request.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I kept maybeUpdateSubscribedTopicRegex  because we will actually use it soon so removing everything does not make sense in my opinion. My goal was only to get a clean and stable RPC in 3.7.

I noticed PlaintextIntegrationTest failling on all builds. Is that from this change or something that got merged incorrectly?

https://github.com/apache/kafka/pull/14790#issuecomment-1847650922

I checked all the failed tests and none of them are related to this PR. I will merge it.


filter out old YT vids

What website(s) would this filter apply to?
YouTube
What content should be blocked?
Need a Time Filter for the YT Subscrition Box. To hide every video, which is older like half a year ore older.
What options should be offered?
ability if you want to block from a few months or from years? some may like to keep older videos in their Subscription Box.
Did you write a custom uBlock filter already?
no
Additional notes
just want to have yt clean again, like years ago, when it showed only the new unseen videos.

Just a note. I remember that @xvello once said to me that he didn't want to hide the short in YT Subsciption.
Let first see what he thinks of this idea.

If you mean with Subscription Box the box that pops up when you click on the notification bell, I have good news: YouTube will remove videos from there if they stay there for to long (somewhere after 2 or 3 months - is my experience).

Hello @NoAimy, thanks for using the project and suggesting an improvement!
This topic has already been discussed in https://github.com/letsblockit/letsblockit/issues/349 and https://github.com/letsblockit/letsblockit/issues/474 : such filtering would be extremely brittle and depend on the user's display language.
I suggest you test a few [alternative interfaces for youtube] (https://github.com/mendel5/alternative-front-ends#youtube) instead. These interface have access to more metadata than our rules do, and could easily implement this kind of filtering.


strongswan: replace kmod with config.system.sbin.modprobe

As described in #5492, NixOS's strongSwan module needs to use modprobe so it puts kmod in the PATH. I noticed errors in the journal saying that certain kernel modules weren't loaded. When I replaced kmod with config.system.sbin.modprobe the errors disappeared.

Why did errors disappear?

I believe the errors disappeared because pkgs.kmod doesn't look in the right modules directory and
config.system.sbin.modprobe does.


'Extra' extension issue with pyinstaller

I posted this on stackoverflow because I thought it was a pyinstaller issue, but I'm wondering if it's really a python-markdown issue.
https://stackoverflow.com/questions/59052079/pyinstaller-and-python-markdown-importerror-no-module-named-extra

I'm running into an issue trying to get python-markdown to work in pyinstaller.  I have this code to demonstrate the issue in file called test.py:
import markdown

testMarkdown = "blahdy blah blah"
print(markdown.markdown(testMarkdown))
print(markdown.markdown(testMarkdown, extensions=["extra"]))

When I run it using python3, I get as desired:
(venv) C:\Users\madgrizzle>python3 test.py

blahdy blah blah

blahdy blah blah

I run pyinstaller as follows:
(venv) C:\Users\madgrizzle>pyinstaller test.py

and run the resulting code, I get the following:
(venv) C:\Users\madgrizzle\dist\test>test

blahdy blah blah

Traceback (most recent call last):
  File "test.py", line 5, in <module>
  File "lib\site-packages\markdown\core.py", line 390, in markdown
  File "lib\site-packages\markdown\core.py", line 100, in __init__
  File "lib\site-packages\markdown\core.py", line 126, in registerExtensions
  File "lib\site-packages\markdown\core.py", line 166, in build_extension
  File "importlib\__init__.py", line 126, in import_module
  File "<frozen importlib._bootstrap>", line 985, in _gcd_import
  File "<frozen importlib._bootstrap>", line 968, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
ImportError: No module named 'extra'
[14432] Failed to execute script test

I tried to rebuild using:
(venv) C:\Users\madgrizzle>pyinstaller --hidden-import="markdown.extensions.extra" test.py

but I get the same error message.
Is there something special that's needed for including markdown extensions?
Additional Information:
It appears that the 'extra' extension might be causing the problem.  Per https://python-markdown.github.io/extensions/extra/, 'extra' is a compilation of multiple extensions, including fenced_code and tables.  If I just try to use the tables extension by itself, pyinstaller works IF I use the full-name as follows:
markdown.markdown(testMarkdown, extensions=["markdown.extensions.tables"])

If instead of using 'markdown.extensions.tables' I use 'markdown.extensions.extra', compile using pyinstaller, and run it, it responds back with a missing "fenced_code" module.  Basically, it seems I have to avoid 'extra' with pyinstaller.

There are three ways to load an extension:

Pass in an instance of the class.
Pass in the full importable path (markdown.extensions.tables).
Pass in a short name for the extension (tables).

The way the third option works is that extensions are registered on install with a setuptools entrypoint. When Markdown receives a string, it checks for an entrypoint with the same name and, if it finds one, it uses it (if it fails, it then falls back to trying to import the string as an importable path). My assumption is that pyinstaller is not playing nice with entrypoints. Therefore, if you are using pyinstaller, you cannot use the short names for extensions.
However, the extra extension uses the short names internally. I suppose this could be considered a bug as it limits the extension to only work where entrypoints are fully supported. The problem is that by using entrypoints, its easy to pass extension configs to each individual extension within extra. That's not so easy if we do something else. In other words, a solution is not immediately clear.

I just remembered that we broke support for  markdown=1 out into its own extension. That being the case, as of the next release (3.2) extra  will only be a shortcut to calling a bunch of other extensions and will offer no functionality of its own. Therefore, users can just call the extensions it bundles separately with no loss of functionality. Given the above, I don;t think we will bother to address this.
If we do anything, we probably should just deprecate the extra extension.

Thanks, seems reasonable and just including the full list of extensions in markdown.markdown isn't much of a burden.


Proposal: Functions to mutating node's properties

So, today I was creating a flex layout using elm, and turn out that, for flex to work, alot of divs in the three should have flex, so I found myself editing a lot of places and realized there is no way to mutate a Node.
For example, if I want a component renders a div and want to add some styles to that div in diferent contexts, I cant easily. So most of the time I found myself passing styles and children as parameters to my functions just to be able to extend it somewhere, cluttering with empty lists the places where no customization is needed, so I realized:
Why not being able to transform the Node data structure? Maybe with functions like:
addProperty : Property msg -> Node msg -> Node msg
changeProperty : (String msg -> String msg) -> String msg -> Node msg -> Node msg
addStyles : List (String msg, String msg) -> Node msg -> Node msg

It would be really easier to deal with those things without having to add a lot of parameters when there is no need to and without having to create a big DOM tree
What do you guys think?
Maybe I can try to make that work and submit a PR if people are interested in it.

Hey @bamorim,
It's preferred that proposals like this are shared on elm-dev so that github issues can be used for tracking bugs and problems. Can you send a message over there with your idea?

Sorry about that @lukewestby.
I'll post that there.

@bamorim no apology necessary! thanks for understanding :)


test-network-monitor: test-network-monitor.c:290: main: Assertion `data.count > 0' failed.

Describe the bug
Running the mptcp 0.9 test suite, the test-network-monitor test fails, from tests/test-suite.log:
FAIL: test-network-monitor
==========================

test-network-monitor: test-network-monitor.c:290: main: Assertion `data.count > 0' failed.
FAIL test-network-monitor (exit status: 134)

To Reproduce
Steps to reproduce the behavior:

Get mptcp 0.9
Run make check as described in the README.md

Expected behavior
All tests should pass
Screenshots
n/a
Desktop (please complete the following information):

Linux Kernel: 5.15.12
Compiler: gcc (Gentoo 11.2.1_p20220115 p4) 11.2.1 20220115

Additional context
test-suite.log
build.log

It looks like the assert() in the test is triggered because the mptcpd network monitor was unable to find non-loopback network interfaces.  Do you have a non-loopback network interface on your Gentoo box?
For reference, this is what my test-network-monitor output looks like:
test-network-monitor.c:check_interface()
interface
  family: 0
  type:   1
  index:  2
  flags:  0x00011043
  name:   enp3s0
test-network-monitor.c:check_interface()   addrs:
test-network-monitor.c:dump_addr()     <IP_ADDRESS>
test-network-monitor.c:dump_addr()     fd68:b197:9fe1:4727:d2b2:6d1a:21dc:61a
test-network-monitor.c:dump_addr()     fd68:b197:9fe1:4727:f220:c186:21c0:dbc3
test-network-monitor.c:dump_addr()     fd68:b197:9fe1:4727:7755:b435:42b6:fa7d
test-network-monitor.c:dump_addr()     fd68:b197:9fe1:4727:d79e:2600:23ac:bce5
test-network-monitor.c:dump_addr()     fe80::5d81:62a3:414a:484d
PASS test-network-monitor (exit status: 0)

Do you have a non-loopback network interface on your Gentoo box?

I definitely do :)
# ip link show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    link/ether d0:50:99:87:75:b5 brd ff:ff:ff:ff:ff:ff
3: wlan0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DORMANT group default qlen 1000
    link/ether 7c:5c:f8:b2:5a:fc brd ff:ff:ff:ff:ff:ff
4: tun0: <POINTOPOINT,MULTICAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UNKNOWN mode DEFAULT group default qlen 500
    link/none

Ha!  I figured as much.  It'd be really odd if you didn't. :)
I'm not sure why test-network-monitor is failing for you.  I'll keep digging.

Can you attach your kernel .config file?  I'd like to compare kernel configs.

Can you attach your kernel .config file? I'd like to compare kernel configs.

Certainly - here you go, straight from /proc/config.gz: config.gz

I also get this error when running from a chroot (pbuild to build debian packages). But I guess it is normal without network interfaces.

Ah! Yes, I'm also running the tests in a sandbox.
Would it be possible for the test to be modified so it works inside a sandbox which only exposes the loopback interface?

Sure.  We can do that.


The type or namespace does not exist

I am having the issue with missing namespaces on latest everything (Windows 10, vs & msbuild 16.7, vscode 1.47.3, omnisharp is 'latest' and pre-release v1.23.0-beta2 ).

Steps to Reproduce
I just open the project in VSCode. Opening it in VS or running it with dotnet CLI works normally.
OmniSharp log
My debug log of omnisharp is here ( 'latest' version)

11.35.5-beta.80 - https://gist.github.com/majkinetor/d7985109c607ca9420e07cc4a2627f61
1.36.0 - https://gist.github.com/majkinetor/46cb9c6b4fa9d27832bad1d9782c8a4c

C# log
Installing C# dependencies...
Platform: win32, x86_64
Downloading package 'OmniSharp for Windows (.NET 4.6 / x64)' (35348 KB).................... Done!
Validating download...
Integrity Check succeeded.
Installing package 'OmniSharp for Windows (.NET 4.6 / x64)'
Downloading package '.NET Core Debugger (Windows / x64)' (42010 KB).................... Done!
Validating download...
Integrity Check succeeded.
Installing package '.NET Core Debugger (Windows / x64)'
Downloading package 'Razor Language Server (Windows / x64)' (50405 KB).................... Done!
Installing package 'Razor Language Server (Windows / x64)'
Finished

Environment information
VSCode version: 1.47.3
C# Extension: 1.23.0
Dotnet Information
.NET Core SDK (reflecting any global.json):
 Version:   3.1.400
 Commit:    035fb2aa2f
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19041
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\3.1.400\
Host (useful for support):
Version: 3.1.6
Commit:  3acd9b0cd1
.NET Core SDKs installed:
3.1.400 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.20 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.20 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.20 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.0.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

align-by-regex
janjoerke
1.0.4

align-mode
Gruntfuggly
0.0.21

better-align
wwm
1.1.6

better-toml
bungcip
0.3.2

Bookmarks
alefragnani
11.3.1

chat
karigari
0.35.0

code-settings-sync
Shan
3.4.3

codestream
CodeStream
8.3.1

codetour
vsls-contrib
0.0.34

csharp
ms-dotnettools
1.23.0

dakara-foldplus
dakara
1.4.1

emojisense
bierner
0.7.0

excel-to-markdown-table
csholmq
1.2.2

filter-lines
earshinov
0.2.0

gistfs
vsls-contrib
0.1.8

gitlab-workflow
GitLab
3.2.0

gitlens
eamodio
10.2.2

haml
karunamurti
1.3.0

hexeditor
ms-vscode
1.2.1

markdown-all-in-one
yzhang
3.2.0

markdown-checkbox
bierner
0.1.3

markdown-pdf
yzane
1.4.4

output-colorizer
IBM
0.1.2

pdf
tomoki1207
1.1.0

plantuml
jebbs
2.13.13

powershell
ms-vscode
2020.6.0

project-manager
alefragnani
11.1.0

remote-containers
ms-vscode-remote
0.128.0

remove-empty-lines
usernamehw
0.0.6

restructuredtext
lextudio
129.0.0

ruby
rebornix
0.27.0

spellright
ban
3.0.52

swagger-viewer
Arjun
3.0.1

todo-tree
Gruntfuggly
0.0.178

vetur
octref
0.26.1

vscode-autohotkey
slevesque
0.2.2

vscode-docker
ms-azuretools
1.4.1

vscode-format-context-menu
lacroixdavid1
1.0.4

vscode-JS-CSS-HTML-formatter
lonefy
0.2.3

vscode-postgres
ckolkman
1.1.11

vscode-ruby
wingrunr21
0.27.0

vscode-solution-explorer
fernandoescolar
0.3.10

vscode-sql-formatter
adpyke
1.4.4

vscode-table-formatter
shuworks
1.2.1

vscode-textile-preview
GehDoc
1.3.4

vscode-todo-highlight
wayou
1.0.4

vscode-xml
redhat
0.13.0

vscode-yaml
redhat
0.9.1

vsliveshare
ms-vsliveshare
1.0.2478

NOTE: Initially reported here

could you please provide the log from 1.23.0? the linked log is from the older version
also, could you provide a repro project?

could you please provide the log from 1.23.0?
Here it is: https://gist.github.com/majkinetor/46cb9c6b4fa9d27832bad1d9782c8a4c

also, could you provide a repro project?

Not at the moment.

thanks a lot. unfortunately the log still doesn't show any problems, so it is very difficult to troubleshoot this.
if you don't wish to share this project, perhaps you could create a simple repro with this problem and provide that instead.


Only publish the npm package api-augment to latest on full releases

Goal
The goal of this PR is to update CI publishing of Api-Augment on RC releases.
Closes #1776

👍 great


[WIP] feature: bring reactiveui.fody into the main project

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
@kswoll has been doing a stunning job over the last couple years maintaining his addin. I think it's high time to in-line his work and make it official. We had conversations back in May - this PR just makes it official and does the needed to make it happen.
What is the new behavior (if this is a feature change)?
We are in-lining https://github.com/kswoll/ReactiveUI.Fody and making it an official thing.  Kirk Woll will get commit bit access to the reactiveui/reactiveui repository as a contributor/maintainer so that he can still work autonomously but over time the core team will also increase their knowledge of things they maintain to include fody.
What might this PR break?
Nothing
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
We need @kswoll to be the person that presses the merge button.

@ghuntley,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Hello all!  Catching up on this, but excited to see this all get merged.  Currently ReactiveUI.Fody is using AppVeyor to build and publish to Nuget.  How do you see this happening going forward?  What is the best strategy?  Will this get incorporated into the regular ReactiveUI build process?  Should I add one or more people as owners to the nuget package?

Okay so @kirkplangrid you'll no-longer be a single person maintaining this, the software and yourself will inherit a team of maintainers. Yay. Additionally you'll no longer need to run your own CI pipeline or any of that awesome stuff that often ends up being a timesuck from doing software development. The biggest change will be that Fody's version number will match the ReactiveUI version number and will be pinned to only work with that particular release (this is a very good thing!)
I need you to add add the NuGet.org users "@ghuntley" and "@reactiveui" as owners to the NuGet package. Thx 👍

Wooot - thank-you. Can confirm that NuGet is setup appropriately.  Need to clean up the PR a little bit and tweak build.cake then we can ship v8 compatible version.

@kswoll A label has been created especially for reactiveui-fody

You now have maintainer access to do things like merge pull-requests, triage labels etc. Please drop on by Slack and speak with myself before doing your first couple of PRs and I'll show you the ropes. For example GitHub issues are automatically closed after 67 of inactivity unless the maintainer tags the issue with an exemption. https://github.com/reactiveui/ReactiveUI/blob/develop/.github/stale.yml#L8
A PR has been sent over back upstream to your repository that directs people to this discussion and informs them that the project has moved.
https://github.com/kswoll/ReactiveUI.Fody/pull/51

Coverage remained the same at 69.487% when pulling 8a626749feddc321e6cdd8677f3d897193af704b on fody into 08d9e58425174cedcbb9073ae0d8fd2b7c2cea7a on develop.

Anything blocking this pull request. I've just discovered that my upgrade to ReactiveUI.Fody to support 8.0 doesn't actually work.

Are there any workarounds for this atm? I'm trying to update another nuget package that has a dependency on 8.0.

@ghuntley,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

This PR is open for further work. @worldbeater could you please take it over and finish it up?

Ok, I'll dive into it! Will need some time c:

I think the only thing remaining here is to fix the versioning and the NuGet package format. I'm pretty sure the netstandard ReactiveUI.Fody.dll should be in the package root for Fody to actually pick it up. Because of this, I also think netstandard is the only TargetFramework required for the ReactiveUI.Fody project. Additionally, ReactiveUI.Fody should probably have a dependency on ReactiveUI.Fody.Helpers since it won't work without it.
I know how to fix the versioning and add the reference, but I'm not familiar enough with the new csproj/NuGet to know how to drop the files in the root of the package instead of the lib folder. This is how the current ReactiveUI.Fody package looks:

How can I help?

I think the only part remaining is updating the docs to add Fody

When and how can we use this?
Today, I added Fody package, added  in FodyWeavers.xml and it cannot find the weaver. Is this how this will work?
Cannot wait till it's done

@qrzychu This was released a couple months ago. You need to reference the newer ReactiveUI.Fody package and add <ReactiveUI /> to FodyWeavers.xml. If you have problems, please turn to StackOverflow or create a new issue with more details. This is already confirmed working by many people.


Crash in mcsema-lift

After running
mcsema-disass --disassembler binja --arch amd64 --os linux --output cfgs/sqliteCFG_main_stable --binary sqlite3 --entrypoint main

then
mcsema-lift --arch amd64 --os linux --output sqLifted --cfg cfgs/sqliteCFG_main_stable

I get the following crash:
E0906 14:33:13.471191  7240 CFG.cpp:213] Data cross reference at c22f9 targeting 1 does not match any known externals and is not contained within any data segments.
E0906 14:33:13.471236  7240 CFG.cpp:220] Data cross reference at c22f1 targeting __elf_header at 0 does not match any known externals and is not contained within any data segments.
F0906 14:33:14.887027  7240 Instruction.cpp:162] Unused immediate operand reference to ff00 in instruction (AMD64 33722 2 (BYTES 0f c8) BSWAP_GPRv_32 (WRITE_OP (REG_64 RAX)) (READ_OP (REG_64 RAX)))
*** Check failure stack trace: ***
    @           0x892df8  google::LogMessage::Flush()
    @           0x89627c  google::LogMessageFatal::~LogMessageFatal()
    @           0x5a88a0  mcsema::InstructionLifter::LiftIntoBlock()
zsh: abort

Backtrace:
#7  0x00000000005a88a0 in mcsema::InstructionLifter::LiftIntoBlock (this=<optimized out>, inst=..., block_=<optimized out>) at /home/kyle/dev/ToB/remill/tools/mcsema/mcsema/BC/Instruction.cpp:171
#8  0x00000000005a58b0 in mcsema::(anonymous namespace)::LiftInstIntoBlock (block=0xa3de150, ctx=..., is_last=<optimized out>) at /home/kyle/dev/ToB/remill/tools/mcsema/mcsema/BC/Function.cpp:741
#9  mcsema::(anonymous namespace)::LiftBlockIntoFunction (ctx=...) at /home/kyle/dev/ToB/remill/tools/mcsema/mcsema/BC/Function.cpp:776
#10 mcsema::(anonymous namespace)::LiftFunction (cfg_module=<optimized out>, cfg_func=<optimized out>) at /home/kyle/dev/ToB/remill/tools/mcsema/mcsema/BC/Function.cpp:933
#11 0x00000000005a30bf in mcsema::DefineLiftedFunctions (cfg_module=0x14cc2d0) at /home/kyle/dev/ToB/remill/tools/mcsema/mcsema/BC/Function.cpp:996
#12 0x00000000005aa5e0 in mcsema::LiftCodeIntoModule (cfg_module=0x14cc2d0) at /home/kyle/dev/ToB/remill/tools/mcsema/mcsema/BC/Lift.cpp:175
#13 0x00000000005b0543 in main (argc=1, argv=0x7fffffffdee8) at /home/kyle/dev/ToB/remill/tools/mcsema/tools/mcsema_lift/Lift.cpp:373

@KyleMiles any progress on identifying the root cause? I think it was binja cfg recovery related?

Yes, just submitted #462 for this.

Resolved by 462


add missing asserts guard to tests using experimental features

fallout from https://github.com/apple/swift/pull/68711
https://ci.swift.org/job/oss-swift_tools-R_stdlib-RD_test-simulator/3967/

@swift-ci smoke test and merge

@swift-ci smoke test and merge


Main blue example doesn't follow written guidelines

Hello, tech illustrator for this page!
Regrettably, the big blue sample diagram with running text used on this page (as viewed 11/21/22) is a very bad example that does not follow the written standards on the page. It has small, non-bold, white text on a solid-color background (always a "no-no"), and low-contrast other colors layered over other colors, including transparent, narrow, light yellow (weak color) lines over various shades of blue, low-contrast bullet points at the bottom in front of the text, and so on.
The blue sample diagram is painful for me to view and understand (tech writer/illustrator with lens-corrected 20/20 vision). It would be hard or impossible for people with low-vision or color blindness to see and understand, and it would waste tons of ink/toner printing it out for people who wanted to do so (they still exist).
Please update this sample diagram to match the written advice about color contrast and accessibility!
Thank you,
Laura
Attached: Screenshot taken on Windows from the PDF file of the document, displayed at 100% size. Note that the white letters drop out even in the main, non-bold headings!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 487e11e9-6e17-a1c7-a300-796b64b53b91
Version Independent ID: 96af150e-f856-01c0-b65a-145f3f83c28c
Content: Illustrating network traffic flows - Microsoft Style Guide
Content Source: styleguide/procedures-instructions/illustrating-network-traffic-flows.md
Product: non-product-specific
GitHub Login: @pallep
Microsoft Alias: pallep

Hi and thanks for your feedback! We are aware that this illustration is out of date and are investigating how we can improve it to comply with Accessibility standards. We will circle back as we have more information.

(oops, I clicked the wrong button)

Hi @LauraDSchneider , so sorry to drop the ball here. This topic has actually been retired entirely in the internal version of the guide, but somehow has not been deleted on this external version. I am working on that right now.

Hi @S-LRaillard !
No worries on dropping the ball, it happens to all of us.
Just to clarify: are you saying that you're retiring the entire topic of tech illustration from the Microsoft Style Guide?
If so, please tell me that Microsoft publishes (online, publicly available) tech illustration style guidelines somewhere that my team could reference! (Separate from marketing illustration guidelines, of course.)
As a tech writer/editor/illustrator/etc. with 30+ years across the broad tech comm field, I can't mentally separate the concepts of tech writing from tech illustration. Of course, simple to complex tech illustrations might be done by a tech illustrator in collaboration with a tech writer that does not have training, interest, proficiency, or just plain the software tools for doing the tech illustration themselves...
But, tech writing and tech illustration intermingle inseparably to convey complex topics to readers with different thinking styles, such as those with more visual brains. The words are always needed, of course (for alt or long_desc text, at minimum), but... sometimes an illustration is just plain necessary to concepts best. They also help break up endless lines of text and procedures to help retain reader attention. And, they help all readers grasp concepts by providing them from multiple perspectives.
:-) Besides, who doesn't like a "book with pictures", especially in a complex installation or sys admin guide, system overview/concepts section, or troubleshooting decision trees?
Hoping for good news that this information was simply relocated elsewhere (fingers crossed)!
And, thank you so much for removing the outdated, non-compliant, too-busy diagram! (There was much rejoicing.)
Cheers!
--Laura

@LauraDSchneider hi again :) I meant that the topic "illustrating network traffic flows" was retired, as its original author felt it was no longer relevant. No other topics have been retired in the general domain of tech illustration. (see "procedures and instructions"). However, please note that the MWSG does not currently have a tech illustrator on hand, so this is largely outside of my scope of work for the moment.

Hello again and good day, @S-LRaillard !  :-)   I'm SOOOO happy to hear this news! Wishing you a fantastic day and a tech illustrator added to your team in the very near future to flesh out and update those standards. They make all the difference to teams like mine who need concrete 3rd-party guidance on tech illustrations (as an internal employee, my word is simply an opinion, not "fact" unless I can show proof). And, honestly, I've read and referenced most of them, and nobody does style guides better than Microsoft: you all are simply the best.  Cheers!


Supervisor 2023.06.1 error

I get the below error every time I reload the integration after updating to Supervisor 2023.06.1.
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 387, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/ha_hatch/__init__.py", line 164, in async_setup_entry
    await setup_connection("initial setup")
  File "/config/custom_components/ha_hatch/__init__.py", line 136, in setup_connection
    _, mqtt_connection, rest_devices, expiration_time = await get_rest_devices(
  File "/usr/local/lib/python3.10/site-packages/hatch_rest_api/util_bootstrap.py", line 31, in get_rest_devices
    token = await api.login(email=email, password=password)
  File "/usr/local/lib/python3.10/site-packages/hatch_rest_api/hatch.py", line 64, in login
    await self._post_request_with_logging_and_errors_raised(
  File "/usr/local/lib/python3.10/site-packages/hatch_rest_api/hatch.py", line 19, in request_with_logging_wrapper
    if response_json["errorCode"] == 1001:
KeyError: 'errorCode'

I'm thinking the problem change is https://github.com/home-assistant/supervisor/pull/4333

released 1.15.1 to improve logging when the api is missing expected response components, might fix your concern.
however if it doesn't please turn on logging of the hatch api
logger:
  default: warning
  logs:
    custom_components.ha_hatch: debug
    hatch_rest_api: debug

and include your raw api responses from before this error to help us track down what is happening

it looks like this
2023-06-06 15:02:13.775 DEBUG (MainThread) [hatch_rest_api.util_http] response json: {'timestamp': '2023-06-06 19:02:13.421', 'status': 500, 'error': 'Internal Server Error', 'path': '/public/v1/login'}

not sure why the api server started throwing 500 errors, will keep looking into when I have more time

1.15.2 allows it to keep working but introduces a warning I'll work on fixing next week. looks like the instance of aiohttp home assistant core provides has somehow changed in an incompatible way

I can confirm 1.15.2 gets me back up and running, thank you for the quick turnaround!

real fix in 1.15.5, user agent provided by home assistant was causing the api 500 error https://github.com/dahlb/hatch_rest_api/commit/f5288ff7ea8b8185d305cf06ce23131f2725851c