Rule suggestion: enforce const when require is used

When we are in modern env it make sense to always use const when require deps. So it would be good to have some rule for that. Something like the no-mutable-exports, but for "imports", actually when use requires. Probably the name may be enforce-require-const or sort of.
enforcing this
const chalk = require('chalk')
const fooBar = require('foo-bar-baz-qux')

because currently we can
let chalk = require('chalk')
var fooBar = require('foo-bar-baz-qux')

Which may not be good thing if someone incidentally re-assign it, somehow.
Or i'm wrong? Is there rule somewhere (other plugins, natives)?

Why would we need special handling for requires?
eslint's core rule will require const whenever it's not reassigned, which should apply to every variable that's not reassigned.

eslint's core rule will

Hm. Which is that rule?

Why would we need special handling for requires?

Because i don't think it make any sense such variables to be mutable. Of course, there are some cases that you need to reassign it, like it was the case with stream module and readable-stream... But i think they are rare cases, and if they are not rare cases, then at least should be seen in code so much. I, don't like and actually don't use dynamic requires.
Second reason is consistency. ES6 module imports, i believe, can't be reassigned? e.g.
import foo from 'foo'

foo = 123

But i'm not sure enough. At least, seen it in Rollup errors couple of times.

You're right that they shouldn't need to be reassigned - but that's true of most variables.
http://eslint.org/docs/rules/prefer-const

Oh yea, i have that rule, but i'm considering to remove it - not pretty sure.
In any way, i believe it would be useful to have such kind of rule, for someone that 1) don't have it, 2) intentionally don't want to use it, 3) or is not so es6.

I think if you don't want prefer-const, you shouldn't want them for requires; and vice versa. require() is just a function call; it's no different than any other variable. I'm a strong -1 on adding a rule for this to eslint-plugin-import.

I think if you don't want prefer-const, you shouldn't want them for requires; and vice versa.

Absolutely not true :D If i or someone don't want especially prefer-const it not immediately means that he not uses let and const and uses vars. Requires are just critical point which deserve to be const.
Anyway, what you consider. :)

If you're using const anywhere, you should be using var nowhere, and using let in as few places as possible, full stop.

I would +1 to this, as would several on my team.

If you're using const anywhere, you should be using var nowhere, and using let in as few places as possible, full stop.

I can see the merit in this, however please consider that many people use const to communicate things to people reading the code as much or more than to the machine.
When I declare a variable as const I'm saying "This variable should never change, not just during runtime but also in any future code changes" (I would love the option to enforce saying this about requires). However if I use let for a variable that doesn't happen to change I'm saying "This variable doesn't happen to be changing now but that doesn't mean it couldn't in the future"

@BrighTide const only communicates "this variable is not reassigned". If you're using it to communicate anything further, including things that you don't need yet (YAGNI), then you're not using it correctly. Use const and a comment for that.

Sorry, by "This variable should never change" I meant  "This variable is not reassigned".
To me const communicates "This value shouldn't be reassigned, it's special", rather than "This value hasn't happened to be reassigned in the past". It's fair that different teams might use it in different ways, but isn't that the point of having linting options?

const should be the default; it’s let that’s special: because reassignment is strange and rare and needs calling out. In addition, conversion from const to let should be a burden.
Regardless, the prefer-const rule handles this; to have an eslint rule for every “special” meaning of const would get rapidly unscalable; you’re welcome to make your own plugin and rules for that if you believe you need it.


Isolate sys path when executing test-opengl script

The exception is due to the fact the root of the module (silx.git/build/lib.linux-x86_64-3.7/silx/gui/utils) is used as PYTHONPATH, as result it overwrite the signal module from the system, cause there is a silx.git/build/lib.linux-x86_64-3.7/silx/gui/utils/signal.py. Same for concurrent.
I have also tried to use -m silx.gui.utils.glutils but it is also problematic in dev env -> Do NOT use %s from its sources.
So here is a solution, using -I which could also create other problems, i guess.
-I     : isolate Python from the user's environment (implies -E and -s)
-E     : ignore PYTHON* environment variables (such as PYTHONPATH)
-s     : don't add user site directory to sys.path; also PYTHONNOUSERSITE

Closes #3182
With -I
In [1]: import silx.gui.utils.glutils
   ...: silx.gui.utils.glutils.isOpenGLAvailable()
['/users/valls/Software/miniconda3/envs/silxenv/bin/python', '/users/valls/workspace/silx.git/build/lib.linux-x86_64-3.7/silx/gui/utils/glutils.py', '2', '1']
Out[1]: <_isOpenGLAvailableResult: True, "">

Without -I
In [1]: import silx.gui.utils.glutils
   ...: silx.gui.utils.glutils.isOpenGLAvailable()
['/users/valls/Software/miniconda3/envs/silxenv/bin/python', '/users/valls/workspace/silx.git/build/lib.linux-x86_64-3.7/silx/gui/utils/glutils.py', '2', '1']
Traceback (most recent call last):
  File "/users/valls/workspace/silx.git/build/lib.linux-x86_64-3.7/silx/gui/utils/glutils.py", line 30, in <module>
    import subprocess
  File "/users/valls/Software/miniconda3/envs/silxenv/lib/python3.7/subprocess.py", line 50, in <module>
    import signal
  File "/users/valls/workspace/silx.git/build/lib.linux-x86_64-3.7/silx/gui/utils/signal.py", line 32, in <module>
    from silx.gui.utils import concurrent
  File "/users/valls/workspace/silx.git/build/lib.linux-x86_64-3.7/silx/gui/utils/concurrent.py", line 35, in <module>
    from concurrent.futures import Future
  File "/users/valls/workspace/silx.git/build/lib.linux-x86_64-3.7/silx/gui/utils/concurrent.py", line 35, in <module>
    from concurrent.futures import Future
ModuleNotFoundError: No module named 'concurrent.futures'; 'concurrent' is not a package
Out[1]: <_isOpenGLAvailableResult: False, "Qt OpenGL widget error: retcode=1, error=b''">

Changelog:

Fix isOpenGLAvailable on specific Python version

I don't think -I is appropriate since the check script needs to run with an environment as close as possible to the one initially executed. -I prevent adding the script directory to sys.path, but it also does other things for isolation that we don't want here.
PR  #3184 provides an alternative solution.
I'm closing, please reopen if needed.


fix(build): check for existing tag on remote branch instead of local

The semantic release now tags the build before the release-all script is run. Therefore, we cannot test if the local branch has been tagged. We must check if the remote branch has been tagged, instead.

:tada: This PR is included in version 3.26.84 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[3pt]  - Display reservations for a given item on the Reservations pop-up - Student C

When the popup loads, the webapp retrieves data from the Involvement API to show the item's reservations.

This task does not include the counter of the reservations.

we don't have 3th coding partner


"waiting for tree to go green bot" not working properly for flutter/packages repo

The packages repo includes the "waiting for tree to go green" label and the backend seems to be configured correctly but its pending PRs are not being processed.

\cc @ditman

Actually I looked at a PR from a different repo. We are tracking https://github.com/flutter/packages/pull/498

Thanks for enabling this!!


Redact sensitive information from logs

Is your feature request related to a problem? Please describe.
There is no log redaction, and part of the bug report process includes users posting their logs. It's possible for users to accidentally leak their access token if it's ever mistakenly printed to console and they report a bug.
Describe the solution you'd like
Logs should be intercepted, either by overwriting the window.console object or by using a different logger that supports redaction.
Describe alternatives you've considered

We could ask users to scan their logs before submitting them to remove any sensitive data, but that is likely too high of an ask for bug reports.
We could remove all logs, but that would make bug reports a lot harder to resolve.
We could hide the token in a procedure rather than returning a string, but it's still possible that the procedure could leak the token. This also doesn't support other kinds of redaction, such as their username.
We could develop a log preprocessor for bug reports, but that's not something that GitHub natively supports and would significant new infrastructure.

Additional context
See the wiki for getting started.

Arkadiusz has a neat blog post investigating this problem.


MRG: Update Ultradian Analysis

@jarrodmillman  Could you please merge this?

I cleaned this up and added your changes in pull request #94


GPU Support | Ubuntu 16.04 | GEFORCE GTX 1080 Ti

Hi all!
So I'm having a problem using GPU support in Ubuntu 16.04 with Python 2.7 (with Anaconda).  I followed the CUDA and cuDNN instructions, and have all the verifications successfully passing.  Here's the passing result of the last catch-all test:
cudnnGetVersion() : 7301 , CUDNN_VERSION from cudnn.h : 7301 (7.3.1)
Host compiler version : GCC 5.4.0
There are 1 CUDA capable devices on your machine :
device 0 : sms 28 Capabilities 6.1, SmClock 1582.0 Mhz, MemSize (Mb) 11164, MemClock 5505.0 Mhz, Ecc=0, boardGroupID=0
Using device 0

Testing single precision
Loading image data/one_28x28.pgmhttps://github.com/apple/turicreate/issues/1190
Performing forward propagation ...
Testing cudnnGetConvolutionForwardAlgorithm ...
Fastest algorithm is Algo 1
Testing cudnnFindConvolutionForwardAlgorithm ...
^^^^ CUDNN_STATUS_SUCCESS for Algo 0: 0.021504 time requiring 0 memory
^^^^ CUDNN_STATUS_SUCCESS for Algo 1: 0.027648 time requiring 3464 memory
^^^^ CUDNN_STATUS_SUCCESS for Algo 2: 0.034816 time requiring 57600 memory
^^^^ CUDNN_STATUS_SUCCESS for Algo 7: 0.069632 time requiring 2057744 memory
^^^^ CUDNN_STATUS_SUCCESS for Algo 4: 0.070656 time requiring 207360 memory
Resulting weights from Softmax:
0.0000000 0.9999399 0.0000000 0.0000000 0.0000561 0.0000000 0.0000012 0.0000017 0.0000010 0.0000000
Loading image data/three_28x28.pgm
Performing forward propagation ...
Resulting weights from Softmax:
0.0000000 0.0000000 0.0000000 0.9999288 0.0000000 0.0000711 0.0000000 0.0000000 0.0000000 0.0000000
Loading image data/five_28x28.pgm
Performing forward propagation ...
Resulting weights from Softmax:
0.0000000 0.0000008 0.0000000 0.0000002 0.0000000 0.9999820 0.0000154 0.0000000 0.0000012 0.0000006

Result of classification: 1 3 5

Test passed!

Testing half precision (math in single precision)
Loading image data/one_28x28.pgm
Performing forward propagation ...
Testing cudnnGetConvolutionForwardAlgorithm ...
Fastest algorithm is Algo 1
Testing cudnnFindConvolutionForwardAlgorithm ...
^^^^ CUDNN_STATUS_SUCCESS for Algo 0: 0.024480 time requiring 0 memory
^^^^ CUDNN_STATUS_SUCCESS for Algo 1: 0.027488 time requiring 3464 memory
^^^^ CUDNN_STATUS_SUCCESS for Algo 2: 0.047104 time requiring 28800 memory
^^^^ CUDNN_STATUS_SUCCESS for Algo 4: 0.068608 time requiring 207360 memory
^^^^ CUDNN_STATUS_SUCCESS for Algo 7: 0.069632 tihttps://github.com/apple/turicreate/issues/1190me requiring 2057744 memory
Resulting weights from Softmax:
0.0000001 1.0000000 0.0000001 0.0000000 0.0000563 0.0000001 0.0000012 0.0000017 0.0000010 0.0000001
Loading image data/three_28x28.pgm
Performing forward propagation ...
Resulting weights from Softmax:
0.0000000 0.0000000 0.0000000 1.0000000 0.0000000 0.0000714 0.0000000 0.0000000 0.0000000 0.0000000
Loading image data/five_28x28.pgm
Performing forward propagation ...
Resulting weights from Softmax:
0.0000000 0.0000008 0.0000000 0.0000002 0.0000000 1.0000000 0.0000154 0.0000000 0.0000012 0.0000006

Result of classification: 1 3 5

Test passed!

https://github.com/apple/turicreate/issues/1190
So I think I have CUDA running properly.  I've also installed TuriCreate as per here (using conda virtual env) and followed the Linux GPU information here, but using -cu90 instead of -cu80 because I'm using CUDA 9.0 and uninstalled mxnet, as specified; below are the commands I used:
export LD_LIBRARY_PATH=/usr/local/cuda/lib64:$LD_LIBRARY_PATH
(venv) pip uninstall -y mxnet
(venv) pip install mxnet-cu90==1.1.0

I also double-checked that cuda is symlinked properly (cuda -> cuda-9.0) for CUDA 9.0.
The problem is what I get when I run the training script (the 'Introductory Example', here):
python training.py
Traceback (most recent call last):
  File "training.py", line 10, in <module>
    model = tc.object_detector.create(train_data)
  File "/home/gilles/.conda/envs/venv/lib/python2.7/site-packages/turicreate/toolkits/object_detector/object_detector.py", line 181, in create
    from ._mx_detector import YOLOLoss as _YOLOLoss
  File "/home/gilles/.conda/envs/venv/lib/python2.7/site-packages/turicreate/toolkits/object_detector/_mx_detector.py", line 9, in <module>
    import mxnet as _mx
ImportError: No module named mxnet

Notice that it says it can't find mxnet. Even with turicreate.config.set_num_gpus(1) at the top it seems to want to use mxnet instead of mxnet-cu90.
So I'm thinking I'm missing something that remaps/links mxnet to the mxnet-cu90 (version 1.1.0) that I have installed.
But that's just my current best guess, and don't know where to go from here.
Thoughts?
Thanks in advance,
Brandon

A quick thought: Should I be using Python 3.x instead?  Apple seemed to recommend Python 2.x, so I went with that on this fresh install/effort.

I've found this so far (here).  Going to see if it's indeed that sudo issue for pip:

I figured what the problem was:
mxnet wasn't installed correctldue to lack of premissions.
In step 5 need to type: sudo pip install mxnet-cu80 instead of just
"pip install mxnet-cu80 "

Nope, that has no change for me.

Maybe I found something:
nvcc --version returns:
The program 'nvcc' is currently not installed. You can install it by typing:
sudo apt install nvidia-cuda-toolkit
However, when I cd to /usr/local/cuda-9.0/ and cat version.txt, I see I have CUDA Version 9.0.176
Is nvcc not being recognized the issue?

Added it to the path manually... not sure why it wasn't in there to start.
export PATH="/usr/local/cuda-9.0/bin:$PATH"
(venv) gilles@learner:~$ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2017 NVIDIA Corporation
Built on Fri_Sep__1_21:08:03_CDT_2017
Cuda compilation tools, release 9.0, V9.0.176

As a sanity check, what packages appear alongside turicreate in /home/gilles/.conda/envs/venv/lib/python2.7/site-packages/? Is it possible that something is misconfigured in your environment/path, and which pip is not using the one from your virtual environment?

Thanks for the help nickjong!
So I'm glad you asked this as I was actually looking at it as well (which means maybe I'm on the right track!).
which pip
/home/gilles/.conda/envs/venv/bin/pip

Here's the mx listings in there:
`(venv) gilles@learner:~/.conda/envs/venv/lib/python2.7/site-packages$ ls mx
mxnet:
attribute.py context.py           executor_manager.pyc  io.py libmxnet.so       misc.pyc     ndarray_doc.py   random.py     symbol            visualization.pyc
attribute.pyc  context.pyc          executor.py           io.pyc              libquadmath.so.0  model.py     ndarray_doc.pyc  random.pyc    symbol_doc.py
autograd.py    contrib              executor.pyc          kvstore.py log.py            model.pyc    notebook         recordio.py   symbol_doc.pyc
autograd.pyc   _ctypes              gluon                 kvstore.pyc         log.pyc           module       operator.py      recordio.pyc  test_utils.py
base.py        _cy2                 image                 kvstore_server.py   lr_scheduler.py   monitor.py   operator.pyc     registry.py   test_utils.pyc
base.pyc       _cy3                 initializer.py        kvstore_server.pyc  lr_scheduler.pyc  monitor.pyc  optimizer.py     registry.pyc  tools
callback.py engine.py            initializer.pyc       libgfortran.so.3    metric.py name.py      optimizer.pyc    rnn           torch.py
callback.pyc   engine.pyc           init.py           libinfo.py          metric.pyc        name.pyc     profiler.py rtc.py        torch.pyc
COMMIT_HASH    executor_manager.py  init.pyc          libinfo.pyc         misc.py           ndarray      profiler.pyc     rtc.pyc       visualization.py
mxnet_cu90-1.1.0.dist-info:
DESCRIPTION.rst  INSTALLER  METADATA  metadata.json  RECORD  top_level.txt  WHEEL
`
So it actually appears that it is indeed properly there.
So funnily enough, after a restart (and perhaps, unfortunately, other undocumented prodding), it is actually now running, but crashing.  I think you're right that there was something in the path or oherwise virtual environment that just hadn't gotten updated.
Here's what I get now, when running the mxtest.py script (reproduced further below):
`python mxtest.py
RuntimeError: module compiled against API version 0xc but this version of numpy is 0xb
[0]
terminate called after throwing an instance of 'dmlc::Error'
what():  [10:31:28] /home/travis/build/dmlc/mxnet-distro/mxnet-build/mshadow/mshadow/./stream_gpu-inl.h:196: Check failed: e == cudaSuccess CUDA: unknown error
Stack trace returned 9 entries:
[bt] (0) /home/gilles/.conda/envs/venv/lib/python2.7/site-packages/mxnet/libmxnet.so(+0x2a9e78) [0x7f93b9898e78]
[bt] (1) /home/gilles/.conda/envs/venv/lib/python2.7/site-packages/mxnet/libmxnet.so(+0x2aa288) [0x7f93b9899288]
[bt] (2) /home/gilles/.conda/envs/venv/lib/python2.7/site-packages/mxnet/libmxnet.so(+0x24318ab) [0x7f93bba208ab]
[bt] (3) /home/gilles/.conda/envs/venv/lib/python2.7/site-packages/mxnet/libmxnet.so(+0x2442c27) [0x7f93bba31c27]
[bt] (4) /home/gilles/.conda/envs/venv/lib/python2.7/site-packages/mxnet/libmxnet.so(+0x2442db6) [0x7f93bba31db6]
[bt] (5) /home/gilles/.conda/envs/venv/lib/python2.7/site-packages/mxnet/libmxnet.so(+0x243f68b) [0x7f93bba2e68b]
[bt] (6) /home/gilles/.conda/envs/venv/bin/../lib/libstdc++.so.6(+0xb8678) [0x7f93a5530678]
[bt] (7) /lib/x86_64-linux-gnu/libpthread.so.0(+0x76ba) [0x7f93f189b6ba]
[bt] (8) /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f93f0ec141d]
Aborted (core dumped)
`
And that's with numpy-1.13.3.  Weird that it's incompatible/home/gilles/.conda/envs/venv/bin/pip
, as mxnet-cu90-1.1.0 says 'has requirement numpy<=1.13.3'.  Doing that latest (1.15.4) version of numpy throws the same error... so not sure there.
And I'm not sure if the numpy error is relevant to the crash but I don't think it is.
So in the mxtest.py script, I had it print the number of GPUs available (print(mx.test_utils.list_gpus())), and it gives an answer of [0].
So I think the crash is because mxnet is not finding a GPU to run on, strangely.
Looking into this a bit more, the only real hit I could find is that mxnet + turicreate + CUDA 9.+ is broken:
https://medium.com/@nickzamosenchuk/training-the-model-for-ios-coreml-in-google-colab-60-times-faster-6b3d1669fc46
So at this point I'm going to try CUDA 8 and and cuDNN 5, instead of the CUDA 9 and cuDNN 7 that I have installed now.
Thoughts?
Thanks again!

Yep, that fixed it.  I installed CUDA 8, cuDNN 5 for CUDA 8, set all the paths again (removing CUDA 9 specific stuff, and actually leveraging symbolic links this time, FWIW), and it runs now:
(venv) gilles@learner:~/Downloads$ python mxtest.py
RuntimeError: module compiled against API version 0xc but this version of numpy is 0xb
[0]
hello

Funnily enough, I still have the numpy issue.  Going to see about solving that, but it doesn't seem to be a related problem.

Oh and curiously, it still returns 0 for the number of GPUs... maybe I'm calling that function wrong.

The numpy issue was solved by installing the latest version, as below:
(venv) gilles@learner:~/Downloads$ pip install --no-cache-dir -U numpy
Collecting numpy
  Downloading https://files.pythonhosted.org/packages/de/37/fe7db552f4507f379d81dcb78e58e05030a8941757b1f664517d581b5553/numpy-1.15.4-cp27-cp27mu-manylinux1_x86_64.whl (13.8MB)
    100% |████████████████████████████████| 13.8MB 10.4MB/s
turicreate 5.1 requires mxnet<1.2.0,>=1.1.0, which is not installed.
mxnet-cu80 1.1.0 has requirement numpy<=1.13.3, but you'll have numpy 1.15.4 which is incompatible.
mxnet-cu90 1.1.0 has requirement numpy<=1.13.3, but you'll have numpy 1.15.4 which is incompatible.
Installing collected packages: numpy
  Found existing installation: numpy 1.12.1
    Uninstalling numpy-1.12.1:
      Successfully uninstalled numpy-1.12.1
Successfully installed numpy-1.15.4

Note however that this is counter-intuitive given the error above, that this numpy is incompatible w/ mxnet-cu80 1.1.0.
I also just noticed that mxnet-cu90 is still in there... removing that now.

Well, apparently that was a bad idea.  Removing mxnet-cu90 killed it.

Sweet.  I figured that out, which actually is a super-set solution to the previous problem of Python not finding mxnet when mxnet-cuxx is installed.
What's the problem?
If you uninstall any of the mxnet-cuxx versions, Python now thinks there is no mxnet installed, even if there's another mxnet-cuxx installed (or even reinstalled).
The way to fix it is to uninstall all the mxnet-cuxx versions, reinstall standard mxnet (which convinces Python that there is an mxnet, and sets up some dependencies, I bet).  Then uninstall it and install mxnet-cuxx.
That fixed it for me at least!


[BUG]: Karavi metrics pod not able to send data to OTEL

Bug Description
Installed observability module and configured both data sources in the grafana GUI. I can see in the logs that the data is being scraped, but it seems like there is an issue sending the data to otel. There are no firewalls in place. This is leading to no info being shown in Grafana. All drop downs are blank. Topology dashboard works fine
Logs
see screenshot
Screenshots

Additional Environment Information
<IP_ADDRESS> is otel
Steps to Reproduce
install observability module based on doc
Expected Behavior
data sent to otel/grafana
CSM Driver(s)
CSI for Powerstore
Installation Type
No response
Container Storage Modules Enabled
No response
Container Orchestrator
Kubernetes  1.21.6
Operating System
centos 7

Hello @encore0, can you provide us with which deployment mechanism you used from the documentation, the version of otel and grafana you're using, and are you using the default values.yaml file we provide or your own?

Hi! I used helm for everything. I did not change any values in any of the values.yaml. Grafana 7.3, otel/opentelemetry-collector:0.9.0. This system is on the Dell network if you want to log into it.

Issue was related to not having a specific version of otel/nginx


Loading the app on expo by scanning QR code returns "Something went wrong. Network response timed out."

Please make our job easier by filling this template out to completion. If you're requesting a feature instead of reporting a bug, please feel free to skip the Environment and Reproducible Demo sections.
Description
1-2 sentences describing the problem you're having or the feature you'd like to request
Expected Behavior
What action did you perform, and what did you expect to happen?
Observed Behavior
What actually happened when you performed the above actions?
If there's an error message, please paste the full terminal output and error message in this code block:
Error text goes here!

Environment
Please run these commands in the project folder and fill in their results:

npm ls react-native-scripts:
npm ls react-native:
npm ls expo:
node -v:
npm -v:
yarn --version:
watchman version:

Also specify:

Operating system:
Phone/emulator/simulator & version:

Reproducible Demo
Please provide a minimized reproducible demonstration of the problem you're reporting.
Issues that come with minimal repro's are resolved much more quickly than issues where a maintainer has to reproduce themselves.

Description
Something went wrong. Network response timed out.
Expected Behavior
Show show the app in either iphone or android using expo (barcode scan)
npm ls react-native-scripts:
<EMAIL_ADDRESS>C:\Users\terry-vmi\Desktop\react\AwesomeProject
`--<EMAIL_ADDRESS>npm ls react-native
<EMAIL_ADDRESS>C:\Users\terry-vmi\Desktop\react\AwesomeProject
`--<EMAIL_ADDRESS>npm ls expo
<EMAIL_ADDRESS>C:\Users\terry-vmi\Desktop\react\AwesomeProject
--<EMAIL_ADDRESS> -- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing: react@>= 16.0.0, required by<EMAIL_ADDRESS>node -v
v6.10.2
npm -v
3.10.10
yarn --version
0.24.6
watchman version
bash: watchman: command not found
Operating system:
Windows 10
iPad Air

Hi! Please see the network troubleshooting section of the README, and make sure to complete the issue template when reporting bugs. Thanks!

The words "network", "trouble", and "template" are not in the README... I guess I'll just open another issue as described in the README because this was the top Google result when searching for this error.

@davelogear sorry for the confusion, I was referring to the README included with the template project: https://github.com/react-community/create-react-native-app/blob/master/react-native-scripts/template/README.md

Got into this same issue.


tests/benchmarks/timing_info measurements are suddenly higher than previous values on nrf52_pca10040

Describe the bug
tests/benchmarks/timing_info measurements are suddenly higher than previous values on nrf52_pca10040.
To Reproduce
Steps to reproduce the behavior:
run  tests/benchmarks/timing_info
Expected behavior
No uptick in measurement
Impact
Its not blocking anything
Screenshots or console output
***** Booting Zephyr OS v1.14.0-rc3-99-g14db4eedff71 (delayed boot 1000ms) *****
starting test - Time Measurement
Timing Results: Clock Frequency: 64 MHz
Context switch                               : 372 cycles ,  5766 ns
Interrupt latency                            : 100 cycles ,  1550 ns
Tick overhead                                :   0 cycles ,     0 ns
Thread Creation                              :1400 cycles , 21700 ns
Thread cancel                                :3388 cycles , 52514 ns
Thread abort                                 :3732 cycles , 57846 ns
Thread Suspend                               :1116 cycles , 17298 ns
Thread Resume                                :1056 cycles , 16368 ns
Thread Yield                                 :1160 cycles , 17980 ns
Thread Sleep                                 :1964 cycles , 30442 ns
Heap Malloc                                  : 792 cycles , 12276 ns
Heap Free                                    : 864 cycles , 13392 ns
Semaphore Take with context switch           :2012 cycles , 31186 ns
Semaphore Give with context switch           :1492 cycles , 23126 ns
Semaphore Take without context switch        : 120 cycles ,  1860 ns
Semaphore Give without context switch        : 624 cycles ,  9672 ns
Mutex lock                                   : 624 cycles ,  9672 ns
Mutex unlock                                 : 736 cycles , 11408 ns
Message Queue Put with context switch        :1384 cycles , 21452 ns
Message Queue Put without context switch     : 304 cycles ,  4712 ns
Message Queue get with context switch        :1652 cycles , 25606 ns
Message Queue get without context switch     : 312 cycles ,  4836 ns
MailBox synchronous put                      :2252 cycles , 34906 ns
MailBox synchronous get                      :1656 cycles , 25668 ns
MailBox asynchronous put                     : 512 cycles ,  7936 ns
MailBox get without context switch           :1228 cycles , 19034 ns
Drop to user mode                            :1336 cycles , 20708 ns
User thread Creation                         :3184 cycles , 49352 ns
Syscall overhead                             : 228 cycles ,  3534 ns
Validation overhead k object init            : 240 cycles ,  3720 ns
Validation overhead k object permission      : 232 cycles ,  3596 ns
Timing Measurement  finished
PASS - main
===================================================================

Environment (please complete the following information):

OS: Fedora29
Toolchain:  Zephyr SDK v.10.0
Commit SHA or Version used: 14db4eedff

Additional context
Add any other context about the problem here.
I am comparing the values to the last result I have for a 12/mar/19 commit  [af4eceaa17]

@pizi-nordic @nashif @arun1joshi could this be a regression with the performance of the compiler?

this can be a lot of things, I would like to see the data from a "good run" first.

no update for a while, not sure this is a bug, numbers change all the time.


Upgrade http4s to 0.16.5a (latest on 0.16.x series)

There were a few important fixes released in these past few releases that we probably want to have in the release.

@nicflores When you have a chance can merge this since we'll have to wait on a release cycle anyway, might as well get this into the release


Update 1 6

NetImgui 1.6
Updated NetImgui (mostly same as 1_5 branch, but updated ClientName command)
Unreal Commands
Imported Unreal Commands support from UnrealNetImgui.

Meant to merge to netimgui branch


Cash Register Project: Directions require improperly represented cents

Describe the Issue
It feels improper for this kind of challenge to accept a decimal like 19.5 with only one decimal point. Money has a significant figure amount of two decimals points, and it is more symbolic of actual activities. It's not a major issue but it would be feel more correct.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/build-a-cash-register-project/build-a-cash-register
Your code
N/A

Expected behavior
Numbers with two decimal places should be used in the directions i.e 19.5 should be 19.50.
Screenshots
No response
System

Device: Desktop
OS: Windows 10
Browser: Firefox
Version: 122.0.1

Additional context
No response

I believe this was to maintain parity with the old certification requirements, where the expected array had numbers:
[
  ["PENNY", 1.01],
  ["NICKEL", 2.05],
  ["DIME", 3.1],
  ["QUARTER", 4.25],
  ["ONE", 90],
  ["FIVE", 55],
  ["TEN", 20],
  ["TWENTY", 60],
  ["ONE HUNDRED", 100]
]

It is worth noting that in general, the user stories for the new certifications match the user stories for the old certifications, requiring only the minimal changes necessary to get the DOM tests to pass.
The idea is that a camper can come back, take their old cert code, and resubmit under the new cert without having to rewrite the entire project.

Oh I see. We can carry on then.


Port all the images to svg

Ticket to track all the images converted.

We have font-awesome landed.


Invalid UIActivityIndicatorViewStyle '100'. should be one of: (0, 1 )

Please help, my app runs on android and used to run on ios but now react-native run-ios  gives me this error:
Invalid UIActivityIndicatorViewStyle '100'. should be one of: (
0,
1
)

React Native version: 0.39 and 0.40
Platform: iOs 9.0 and 10.2
Operating System: macOs Sierra 10.12.2

Under the hood a static function differs from an instance function only in how it takes its implicit parameters: instance functions take one implicit parameter for self while static functions take no implicit parameters for anything.
As far as the code for the function is concerned, there is no penalty for a function being static or non-static. Same goes for performance: static functions are simplest lightweight "packages" of executable code; calling them carries no additional costs.
Your particular implementation, however, may benefit from storing activityIndicator in a variable to avoid re-creating it in each static call. Moreover, this would make it easier for you to remove the activity indicator from superview once the activity has finished. If you would like to use a single activityIndicator, you could keep your function static, and add a class variable for activityIndicator. Otherwise, you should make multiple instances of ActivityIndicator class, each having its own activityIndicator instance variable. In this case, startActivityIndicator should become an instance method as well.

Thank you but I am being silly. My apologies. In android, the ActivityIndicator can be any size (a number representing width and height, I presume) but in iOs it can only be 0 ('small') or 1 ('large').

Okay laclance.
Can you favour me i have a samll issue
On Tue, Jan 24, 2017 at 12:28 PM, laclance<EMAIL_ADDRESS>wrote:

Closed #12030 https://github.com/facebook/react-native/issues/12030.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/12030#event-934027520,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATmTnDnwyaL7WZ4n2oz2NlSnKkyLVOQ9ks5rVaEigaJpZM4Lqt-s
.

sure?

yah Thank u
On Tue, Jan 24, 2017 at 1:19 PM, laclance<EMAIL_ADDRESS>wrote:

sure?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/12030#issuecomment-274732233,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATmTnIvfVN4EsxXLSaXGJdGTcCt8H3l_ks5rVaz1gaJpZM4Lqt-s
.

http://stackoverflow.com/questions/41743667/react-nativehow-can-i-get-the-dot-or-image-when-i-click-on-the-particular-pos
Can you Refer This Link I was Post the Issue...Plz Refer this
On Tue, Jan 24, 2017 at 4:37 PM, ALLU LAVARAJU<EMAIL_ADDRESS>wrote:

yah Thank u
On Tue, Jan 24, 2017 at 1:19 PM, laclance<EMAIL_ADDRESS>wrote:

sure?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/12030#issuecomment-274732233,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATmTnIvfVN4EsxXLSaXGJdGTcCt8H3l_ks5rVaz1gaJpZM4Lqt-s
.

thanks in Advance
On Tue, Jan 24, 2017 at 4:38 PM, ALLU LAVARAJU<EMAIL_ADDRESS>wrote:

http://stackoverflow.com/questions/41743667/react-
nativehow-can-i-get-the-dot-or-image-when-i-click-on-the-particular-pos
Can you Refer This Link I was Post the Issue...Plz Refer this
On Tue, Jan 24, 2017 at 4:37 PM, ALLU LAVARAJU<EMAIL_ADDRESS>wrote:

yah Thank u
On Tue, Jan 24, 2017 at 1:19 PM, laclance<EMAIL_ADDRESS>wrote:

sure?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/12030#issuecomment-274732233,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATmTnIvfVN4EsxXLSaXGJdGTcCt8H3l_ks5rVaz1gaJpZM4Lqt-s
.

did u get it my question?
On Tue, Jan 24, 2017 at 4:39 PM, ALLU LAVARAJU<EMAIL_ADDRESS>wrote:

thanks in Advance
On Tue, Jan 24, 2017 at 4:38 PM, ALLU LAVARAJU<EMAIL_ADDRESS>wrote:

http://stackoverflow.com/questions/41743667/react-nativehow-
can-i-get-the-dot-or-image-when-i-click-on-the-particular-pos
Can you Refer This Link I was Post the Issue...Plz Refer this
On Tue, Jan 24, 2017 at 4:37 PM, ALLU LAVARAJU<EMAIL_ADDRESS>wrote:

yah Thank u
On Tue, Jan 24, 2017 at 1:19 PM, laclance<EMAIL_ADDRESS>wrote:

sure?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/12030#issuecomment-274732233,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATmTnIvfVN4EsxXLSaXGJdGTcCt8H3l_ks5rVaz1gaJpZM4Lqt-s
.


Missing importlib resources on a fresh venv

Hi,
I tried the last wheel (1.0.4) and run an example application.
/home/sylvain/Documents/Blackboard/venv/bin/python /home/sylvain/Documents/Blackboard/00.py
Traceback (most recent call last):
  File "/home/sylvain/Documents/Blackboard/venv/lib/python3.6/site-packages/bgfx/utils.py", line 26, in <module>
    import importlib.resources as pkg_resources
ModuleNotFoundError: No module named 'importlib.resources'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/sylvain/Documents/Blackboard/00.py", line 9, in <module>
    from bgfx import bgfx, ImGuiExtra, as_void_ptr
  File "/home/sylvain/Documents/Blackboard/venv/lib/python3.6/site-packages/bgfx/__init__.py", line 2, in <module>
    from .utils import *
  File "/home/sylvain/Documents/Blackboard/venv/lib/python3.6/site-packages/bgfx/utils.py", line 29, in <module>
    import importlib_resources as pkg_resources
ModuleNotFoundError: No module named 'importlib_resources'

Not sure if a dependency is missing for the wheel or if my version of python isn't supported.
Regards

I use python 3.6 within a venv on Ubuntu 18.04 (with all updates).

Hi @meuns, yes you need to install importlib-resources. Python 3.6 is supported and it's strange because that dependency should automatically be installed by other packages. I will add it explicitly, thanks!

Hi @fbertola, I can run examples without much any problem now. Thanks


Calling getApi using vsls 1.0.1526 (npm package) always returns null

Describe what happened:
Calling getApi using vsls 1.0.1526 always returns null. It looks like it issue is that it is using its own package.json version 1.0.1526 but live share only supports versions less than 0.4
What was your system configuration?
Product and Version [VS/VSCode]: VSCode Insiders 1.44
OS Version[macOS/Windows]: Windows 10
Live Share Extension Version: 1.0.1711
/cc @lostintangent

Hi Eric! thank you for reporting this issue. We will prioritize it and take a look accordingly.
regards,

@daytonellwanger has a fix for this, we should be able to make it available in the next release!

Looks fixed in version 1.0.1830


Could this be used with KnpMenuBundle?

I'm using this for the first time and I was wondering if there's anyway to incorporate KnpMenuBundle to use with side bars?

In terms of rendering it would work. The Knp MenuItemInterface is pretty much identical to the Theme's MenuItemInterface. You would have to build some kind of wrapper/proxy for the KnpMenuItem (or fork this bundle and get rid of the MenuItemInterface type hints).
Unfortunately, creating an inherited MenuItemInterface extending both is not possible.

Would you mind if we migrate the menu to KnpMenuBundle?
I can have a look to it and implement it for the next release if you are happy with that.
The main reason is to reuse a pice of software that already exists and works quite well and it makes easier to migrate current projects to this theme or even extend it with more advanced third party menu systems.

+1

Have a look at the 2.x pre-release which comes with KnpMenuBundle support.


added Enron Exploratory analysis

dataset. it is quite big so can not be uploaded here
https://www.kaggle.com/wcukierski/enron-email-dataset

@ron2111 check

LGTM @ron2111
No need to add the dataset just linking it would be good enough as a comment or something
Please add a project readme as well for others and your name in the list of contributors

Where is the list of contributors?

In the project readme

done @ron2111


⚠ Bofrost.at has degraded performance

In 93cec33, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1537 ms

Resolved: Bofrost.at performance has improved in d29b105 after 6 minutes.


question on saved model weights

The readme file says the usage of 32 (3x3) first conv2D and 2nd layer 64 (3x3), but python program cnn_major.py it is given as shown below,
# 1 - Convolution
model.add(Conv2D(64,(3,3), border_mode='same', input_shape=(48, 48,1)))
2nd Convolution layer
model.add(Conv2D(128,(5,5), border_mode='same'))

So, to save the model weights results which is correctly used from the above.

@rishabhjainps can u please reply

@priyaganaboor Yes you are correct.
ReadMe needs to be updated for shallow cnn, It should be

First convolutional layer, we had 64 3×3 filters, along with batch normalization and dropout and max-pooling with a filter size 2×2.

Second convolutional layer, we had 128 5×5 filters, along with batch normalization and dropout and max-pooling with a filter size 2×2.

https://github.com/rishabhjainps/Facial-Expression-Recognition/blob/master/cnn_major_shallow.py#L70

Thank u so much for the reply :)
And also u said dataset is divided into 80:10:10
But I don't see that in your code.
If it is 80:10:10 ideally the images should be divided into 28,709(training), 3,589(validation), and 3,589(test).
But ur code divides the dataset into some other ratio that it results in 32298(training), 3,589(testing).
Correct right??
@rishabhjainps

Basically we first takeout 10% of whole data set as test data set. It is part which is totally untouched till the end, only used to calculate accuracy of model.
Validation dataset is there to fine tune the model hyper-parameters for CNN which is specified in below line.
https://github.com/rishabhjainps/Facial-Expression-Recognition/blob/master/cnn_major.py#L143

If we have find the accuracy of individual class?
@rishabhjainps


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_03tf37wv8u/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_03tf37wv8u/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
Errors were found


Fix issue with last mod timestamp of the sitemap index file

Fix issue where the last mod timestamp of the sitemap index file wasnt using the most recently last edited timestamp, but the last item in the stack. This often meant editing a page wouldn't update the index file last mod date. Update test to check this, and include test for changeset bbd5e29

This broke Postgres support :(

@simonwelsh
More info? Is it broken at the DB abstraction layer (max not supported?) or doesn't postgress like max on date fields... (seems it does..)

@nfauchelle #80
Can't order a SELECT DISTINCT on something not being selected.


Handle multiple Access Token API endpoints

Is your feature request related to a problem? Please describe.
Since Artifactory v7.21.1, the API for managing Access Tokens  has changed
The latest version of the provider is still relying on the "old" endpoints
Describe the solution you'd like
The provider should handle both endpoints based on the Artifactory version
Describe alternatives you've considered
NA
Additional context
NA

@yannc21 We have plan to replace the old access token resource with the new API. No ETA as of now.

@chb0github the "new API" is the recommended one since v7.21 and so the currently used one is obsolete. The "new API" provides more advanced usage of Access Tokens and fixes some issues.  The previous release (v7.19)  which only supports the "old API" will be EOL in November 2022. If we don't support the new API then we are penalizing users relying with the latest Artifactory version.


COLMAP ETH3D Results

Great work, and thank you for open sourcing your code!
Could you provide more details for why the pose AUC values are so low for COLMAP (SIFT + NN) on ETH3D (e.g., did it completely fail on some datasets)?
The original ETH3D paper (and others) demonstrated that COLMAP performs exceedingly well on these datasets, and the ETH3D ground truth is actually predicated on a COLMAP solution.

Hi, in the multi-view pose estimation task, COLMAP with SIFT+NN fails in some scenes (a large number of images are missing registration), which leads to poor final scores.
As for the GT pose generation of ETH3D, their original paper (Sec 3.2) describes that they acquire pose GT by using COLMAP (SIFT+NN) to perform matching between rendered images (using laser scanned geometry) and captured images for initial registration. I think the rendered dense views can reduce the matching difficulty and make the task easier compared with our evaluations.
If I have not overlooked something, the original ETH3D paper seems to only evaluate the COLMAP-MVS part instead of COLMAP-SfM and compare it with other MVS baselines using known GT poses.

Yes, you're right. I was under the impression that the MVS experiments used the estimated poses as opposed to GT. PixSfM also demonstrated impressive pose estimation results on ETH3D, but they used a specialized evaluation scheme that only used a subset of the images for each dataset.
Thank you for your response!


DotNetCore ARM (32-bit) won't build in 5.0.0

The link is broken for the DotNetCore 5.0.0 RC1 binary downloads for ARM32 so I wasn't able to add it to the build recipes. Will update when link is working (or subsequent version is released).

The link is working now https://download.visualstudio.microsoft.com/download/pr/5fc4659b-86c2-4e8f-b409-853e6d8224a5/6de0fc8c6e26f308bf246aaa967c9fc1/dotnet-runtime-5.0.0-linux-arm.tar.gz
Another thing i noticed is in dotnet-core_5.x.x.inc it the file paths that have "-rc.1.20451.14" shouldn't have them so just replacing all with "" i was able to build

Yep, they should all be updated now with the release build.


eCarePlanner 3.2.2 - Medications - integrate third-party endpoint data

eCarePlanner 3.2.2 at this time only queries for MedicationRequest resources from the OHSU FHIR server.
You should be able to pull all necessary information from the MedicationRequest resource, without requiring the Medication resource itself in most cases.
Action items:

Update eCarePlanner to query the SDS for all of a patient's MedicationRequest resources from each third-party endpoint partition, and integrate information from those queries into the Health Maintenance & Interventions tab, Active Medications list.
Update the eCarePlanner Active Medications list to include Provenance information to show from where the data originated.

MedicationRequest LOE 4 Hours
Provenance LOE 4 Hours


Some test fails sometime but passes other times

I am trying to test automate windows 10 calculator. If I run test individually it works fine and all the test Passes but If i Click on run all test only the first test passes rest all gets failed. Sometimes if I press Run all test button then sometimes two test passes and sometimes all the test passes. Indivially they work fine so I am not able to debug the issue. I have tried adding thread.sleep but that also doesnt work.
Request you to please help

Anyone who can help here please

Anyone who can help here please

did you close application properly?

There could be various issues:

Tests are run in parallel. Make them run in sequence.
Tests use the previous state of the application instead of a fresh state. Either restart the application before each test or implement something to go back to the "default" screen before each test.
If that does not work, you need to observe more carefully what fails on the tests to find out the cause.

Got the same effect :)
There are two separate issues:

there is some IDE integration defect, perhaps in NUnit's Visual Studio Test Adapter, sometimes tests succeed but reported as failed -- I found this only after I logged each UI operation
every UI operation is out-of-process and asynchronous, and as such it may fail sporadically -- the only true cure for this is to wrap each UI operation into some retry mechanism -- I found that the Polly library works pretty well


Fix test results when the same request is executed more than 1 time (#2522)

Description
This change resolves an issue when the runner execute the same request more than once. For example this happens when the request script sets the next request to itself. Before the changes the runner test results would look like this:

After this fix the result will show like this:

Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[x] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

@helloanoop  could you review this fix?

@Its-treason and @dcoomber Could you guys review this fix?

If i'm understood your code correctly: You are trying to find the last Item instead of the first item? Could you use findLast instead? This would make the code a lot easier to read.

If i'm understood your code correctly: You are trying to find the last Item instead of the first item? Could you use findLast instead? This would make the code a lot easier to read.

Changed as suggested. No Idea why I over complicated on the first time....

@Its-treason can you please take a look again? I have done the suggested changes.

@helloanoop, @Its-treason and  @dcoomber what would be the next step to get these merged and released?

This is all you can do for now, you have to wait for the Maintainer to merge this. CC: @sanjai0py


The demo has relatively low performance.

I ran demo_instseg.py with your released weights and found that it did not detect any object, but if I used images and text descriptions that included people, then it worked normally. This indicates that the performance is relatively low for OV objects. I don't know why, have you run this script?

For our demo, you have to provide a set of categories. "Open-set" means that our model is able to deal with vocabulary different from the one our model is trained on. However, the aimed categories should be contained in the set of categories you set.

@HaoZhang534 I ran the script you provided directly without any modifications. You can try it yourself.

I ran the demo script, and it worked fine in my case. I think if you test with a custom image, you should modify the class in either stuff and thing to include them in.

@hhaAndroid Hi, sorry for the late reply, as said by @choyingw, if you test with your only images, you sould change the class names to include the classes in your image.


add copy of pymmconfig

Hi Kieran,
Here's a copy of pymmconfig! I hope it's helpful! Just looking through it there's a lot of junk I had forgotten about. I pasted in a couple of functions that are used from the pymmFunctions file so you don't need it, but commented out the original references that you can delete.
The interview logic is a little rickety, so I hope you can get what you need!
Thanks!
Michael

It looks like this wants to merge to your master branch... I had made a separate branch, but sorry, I don't know how to direct the PR to a branch other than master... :/

Ahhh,these additions are so thoughtful. I took a quick look at some of your comments as well. I am going to just merge to master tomorrow and make some quick edits.thank you!
.

Sorry for the delay, a million thanks @mcampos-quinn !!

Whee!


Parse invalid CIDR values without throwing exceptions

Addresses #619

Note: I chose not to create tests because I'd like to let cuttlefish do this for us instead (see also basho/cuttlefish#182).

And...shockingly (not) tests run from the Riak console worked but in deployment it...doesn't.

Closing, will open a new PR when this works.


Auto reload between error pages and prototype pages

What
This is a continuation of https://github.com/alphagov/govuk-prototype-kit/issues/2091 - that was focussed on live reloading once the user gets to the error page.
At this stage we should add the following functionality:

When the user is on a working page but then breaks their kit (e.g. routes.js or filters.js) the browser should live reload to show the error page.
When the user is on that error page and resolves the error, the prototype will start and the browser should live reload to show the page from the prototype kit.

Why
So that the user finds out quickly when they cause an error and when they resolve the error.
Who needs to work on this

Developer

Who needs to review this

Developer

Done when

[x] The user is taken to an error page (without having to manually refresh the browser) when an error stops the kit from running
[x] The user is taken back to their prototype (without having to manually refresh the browser when the error is resolved and the prototype can run again

This is a duplicate of https://github.com/alphagov/govuk-prototype-kit/issues/2091


add a reference for Laplacian pyramid

add a reference for Laplacian pyramid

Can one of the admins verify this patch?


zmq issue

Hello,
I am trying to setup the ZQM integration for dispatcher and I am getting this issue. I think the config piece is not right and there is not much information on how to set it:
Can somebody that did this before check this setup?
"port": 443,
"log_level": "debug",
"json_log_enable": true,
"namespace": "telemetry",
"reliable_ack": false,
"rate_limit": {
"enabled": false,
"message_limit": 100
},
"pubsub": {
"gcp_project_id": "tesla-telemetry-437316"
},
"zmq": {
"addr": "tcp://xxxxxx.compute-1.amazonaws.com:5555"
},
"records": {
"alerts": [
"logger",
"pubsub"
],
"errors": [
"logger",
"pubsub"
],
"V": [
"logger",
"pubsub",
"zmq"
]
},
pp-1  | 2024/10/04 15:30:20 maxprocs: Leaving GOMAXPROCS=1: CPU quota undefined
app-1  | {"activity":true,"context":"fleet-telemetry","level":"info","msg":"config_skipping_empty_metrics_provider","time":"2024-10-04T15:30:20Z"}
app-1  | {"activity":true,"context":"fleet-telemetry","level":"info","msg":"starting_server","time":"2024-10-04T15:30:20Z"}
app-1  | {"activity":true,"context":"fleet-telemetry","level":"info","msg":"pubsub_registerd","namespace":"telemetry","project":"tesla-telemetry-437316","time":"2024-10-04T15:30:20Z"}
app-1  | panic: no such device
app-1  |
app-1  | goroutine 1 [running]:
app-1  | main.main()
app-1  |        /go/src/fleet-telemetry/cmd/main.go:46 +0x125
Catalin

Sorry I didn't get back to you on Discord, I couldn't remember how it had it configured but I've gone back through my commit history now.
You configure the Fleet Telemetry server as a ZMQ producer, which ZMQ clients connect to, so you shouldn't put an external domain, but rather an IP and port to bind to.
"zmq":"<IP_ADDRESS>:3000"

Sorry I didn't get back to you on Discord, I couldn't remember how it had it configured but I've gone back through my commit history now.
You configure the Fleet Telemetry server as a ZMQ producer, which ZMQ clients connect to, so you shouldn't put an external domain, but rather an IP and port to bind to.
"zmq":"<IP_ADDRESS>:3000"

Sorry I didn't get back to you on Discord, I couldn't remember how it had it configured but I've gone back through my commit history now.
You configure the Fleet Telemetry server as a ZMQ producer, which ZMQ clients connect to, so you shouldn't put an external domain, but rather an IP and port to bind to.
"zmq":"<IP_ADDRESS>:3000"

No worries. Thank you for the input here! More people might benefit from the guidance.
On the topic: I added as in the config: "zmq": {
"addr": "tcp://<IP_ADDRESS>:4444"
},
Error disappeared but the subscriber that is outside of the server does not receive the messages. Logs look clean on the telemetry, but I did not install ZMQ on it (Amazon Linux 2023 distribution). Two questions here:

Does telemetry comes with zmq library components for itself to function or it needs to be installed? I assume it would log the errors if not.
If telemetry becomes ZQM producer then I should be able to be subscriber on same instance as well. Do I get this right?

The way I used it was I had my NodeJS application connect to my fleet telemetry server using ZMQ. You dont need to install any other software to use ZMQ as its connections are directly client to server.
You need to configure your subscriber to connect to the IP of your fleet telemetry container/server on 4444 (your exposing that port right?)


'Loan Sniping' Frontrunning issue.

As discussed.
I should be able to make it such that debt orders submitted to kernel revert if the "rightful lender" doesn't send it.

This is no longer relevant as we're not building on Dharma


💡[Feature]: Cirrhosis Prediction

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Cirrhosis is a chronic liver disease characterized by liver scarring and impaired liver function. Early prediction of cirrhosis can lead to better management and treatment, potentially improving patient outcomes
Use Case
Dataset: https://www.kaggle.com/datasets/fedesoriano/cirrhosis-prediction-dataset
Benefits
Machine learning models can identify patients at risk of developing cirrhosis before clinical symptoms become apparent, allowing for earlier intervention.
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hey @Avdhesh-Varshney sir . please assign this issue

Hey @Avdhesh-Varshney sir . please assign this issue

@Khushi-Pushkar go ahead. And don't do spam of issues


Need an updated prod_util library to support err_exit() on HPCs with Slurm

Is your feature request related to a problem? Please describe.
The current prod_util released with spack-stack is too old and err_exit() will not work as expected on HPCs with Slurm (such as Hera, Jet, Orion, etc)
Describe the solution you'd like
prod_util needs to be updated to support slurm for err_exit() as in this PR https://github.com/NOAA-EMC/NCEPLIBS-prod_util/pull/69
Additional context
An updated prod_util has been used for a while in the rrfs-workflow  through a temporary installation.

@climbfuji Not sure whether a tag will be ready tomorrow but my PR was merged today and the latest commit hash is d1db177. Can spack-stack uses a hash?

We can but we really don't want to do that. I'd rather wait until Friday, but if the tag isn't ready by then it likely won't be in spack-stack-1.6.0.

Resolved via https://github.com/JCSDA/spack-stack/pull/906

Thanks, @climbfuji


Add diff screenshot to README

When reading the README it's not clear what the end result will look like. An animated gif would be even more helpful (example).

Good point, I've added a gif. I still don't have a good process for making these, but it's probably going to be a good idea to think about adding one for each of my plugins, so some automation will be a good idea :).


tapd not sent out error when find connection empty.

Describe the bug

There are no Connection with ConnectionId 1.
So the tapd get an empty struct
But here don't sent an error
The empty sturct are using continue.
It is unsafe.
To Reproduce
Steps to reproduce the behavior:

Debug plugins/tapd/tapd.go with param “-c 1 -w 1” without the database data  of ConnectionID 1.
break after db.Find and look at the err and connection.

Expected behavior
Send out an error if there is no data about target ConnectionID.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

use First instead of Find


feat(graph) Add createdOn, createdActor, updatedOn, updatedActor to graph edges

This PR adds the mechanism to define what the createdOn and updatedOn timestamps are on a graph index edge as well as the createdActor and updatedActor. In order to specify, all you need to do is set the path to the field on the aspect inside of the Relationship annotation. As an example, this is what you can do to set these fields on Upstream in UpstreamLineage
  /**
   * The upstream dataset the lineage points to
   */
  @Relationship = {
    "name": "DownstreamOf",
    "entityTypes": [ "dataset" ],
    "isLineage": true,
    "createdOn": "upstreams/*/created/time"
    "createdActor": "upstreams/*/created/actor"
    "updatedOn": "upstreams/*/auditStamp/time"
    "updatedActor": "upstreams/*/auditStamp/actor"
  }
  @Searchable = {
    "fieldName": "upstreams",
    "fieldType": "URN",
    "queryByDefault": false
  }
  dataset: DatasetUrn

This also sets a default createdOn and createdActor on all new graph edges being created using the metadataChangeLog.systemMetadata.lastObserved timestamp and the metadataChangeLog.created.actor for those fields.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Aside from build failing :)


How to containerize the .NET Framework web apps with Windows Containers and Docker - errors

There are inconsistencies between the walkthrough and the actual experience locally on my environment.
Add - Docker Support generates only these two files in Solution Explorer ( VS 2022 Preview), no .yml are present as per screenshot of this walkthrough ( see section: Using Visual Studio to add Docker Support to the application.

Eventually two images are downloaded and extracted in Docker.

When build starts errors appears as below.
Lastly, website starts but it's broken:

Build started...
1>------ Build started: Project: eShopLegacyMVC, Configuration: Debug Any CPU ------
NU1608: Detected package version outside of dependency constraint: Autofac.Mvc5 4.0.2 requires Autofac (>= 4.0.1 && < 5.0.0) but version Autofac 6.1.0 was resolved.
NU1605: Detected package downgrade: System.Diagnostics.DiagnosticSource from 4.7.1 to 4.5.1. Reference the package directly from the project to select a different version.
eShopLegacyMVC -> Autofac 6.1.0 -> System.Diagnostics.DiagnosticSource (>= 4.7.1)
eShopLegacyMVC -> System.Diagnostics.DiagnosticSource (>= 4.5.1)
NU1605: Detected package downgrade: System.Threading.Tasks.Extensions from 4.5.2 to 4.5.1. Reference the package directly from the project to select a different version.
eShopLegacyMVC -> Autofac 6.1.0 -> Microsoft.Bcl.AsyncInterfaces 1.1.0 -> System.Threading.Tasks.Extensions (>= 4.5.2)
eShopLegacyMVC -> System.Threading.Tasks.Extensions (>= 4.5.1)
1>  Consider app.config remapping of assembly "System.Net.Http.Formatting, Culture=neutral, PublicKeyToken=31bf3856ad364e35" from Version "<IP_ADDRESS>" [] to Version "<IP_ADDRESS>" [C:\Users\oluca.nuget\packages\microsoft.aspnet.webapi.client\5.2.7\lib\net45\System.Net.Http.Formatting.dll] to solve conflict and get rid of warning.
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(2301,5): warning MSB3247: Found conflicts between different versions of the same dependent assembly. In Visual Studio, double-click this warning (or select it and press Enter) to fix the conflicts; otherwise, add the following binding redirects to the "runtime" node in the application configuration file:
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): warning MSB3026: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Beginning retry 1 in 1000ms. The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): warning MSB3026: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Beginning retry 2 in 1000ms. The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): warning MSB3026: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Beginning retry 3 in 1000ms. The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): warning MSB3026: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Beginning retry 4 in 1000ms. The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): warning MSB3026: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Beginning retry 5 in 1000ms. The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): warning MSB3026: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Beginning retry 6 in 1000ms. The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): warning MSB3026: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Beginning retry 7 in 1000ms. The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): warning MSB3026: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Beginning retry 8 in 1000ms. The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): warning MSB3026: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Beginning retry 9 in 1000ms. The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): warning MSB3026: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Beginning retry 10 in 1000ms. The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): error MSB3027: Could not copy "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". Exceeded retry count of 10. Failed. The file is locked by: "vmwp.exe (23816), vmmem (2992)"
1>C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(4631,5): error MSB3021: Unable to copy file "obj\Debug\eShopLegacyMVC.dll" to "bin\eShopLegacyMVC.dll". The process cannot access the file 'bin\eShopLegacyMVC.dll' because it is being used by another process.
========== Build: 0 succeeded, 1 failed, 1 up-to-date, 0 skipped ==========

Hi @LucaOtto, Thanks for reporting the issue. Can you check once again after removing the container if any, removing the images and volume( if any)? The build error is showing that there is already another running process. The actual error may be different. Thanks

Hi @erjain . Your ask is not clear. These Docker images were generated by the above command as per walkthrough. Without them there is no website to show. I see the error you mention, but I have no other images running other than the ones pulled when I add Docker Support to the project. I followed the steps again, same error as above.
Thanks

Hi @LucaOtto, Sorry for the confusion. Please try resetting your docker desktop as shown below:
.
And then, try adding docker files using the option of Container Orchestration support as below, build should be successful:

Hi @erjain I just added the Container Orchestration support and VS started pulling down the Docker image. Just a FYI: the walkthrough doesn't specify this step here ( https://github.com/dotnet-architecture/eShopModernizing/wiki/02.-How-to-containerize-the-.NET-Framework-web-apps-with-Windows-Containers-and-Docker#using-visual-studio-to-add-docker-support-to-the-application ) the first screenshot is not complete and the second one shows the files created after adding Container Orchestration. I'll confirm that it works once the container is live in Docker. Thanks.

Hi @erjain I'm still seeing the same error when opening the website. I've attached VS output.
Docker Desktop shows these images and containers running, from which I start the website.
Thanks

VS output.txt


[Feature request or Question] Callback for y-label formatting

Hi i wanna create an XY-chart which features "racing times" on the y-axis. They are formatted "minute:ss:mmm". What i would love to do is pass as x-values the date when the times were achieved and as y-values the times in millies. However seeing the times in millies is not really helpful, so i was hoping to get a callback when a y-value is to be displayed.
Thanks
Markus

If I understand correctly, what you want to achieve is doable without a callback, a simple number format is enough.
To allow for providing a callback would be a different (and more powerful) feature.


Set up the icepyx gallery

This repo is meant to hold the usage example notebooks for icepyx. The original effort was to integrate this into icepyx, but there were some troubles, see the PR https://github.com/icesat2py/icepyx/pull/125. I am currently working on setting up the functionality on my fork.
The Pangeo Gallery is here. It has a contributor guide that I have been following to set up this repo.
Currently, I am stuck on image management. The image that we used for the IceSat-2 Hackweek is here, but has old, API-breaking changes that are not compatible with the current examples. @JessicaS11, @scottyhq, and I have been tossing around various solutions to this problem. We need a different image than previously used and I think there are two main solutions:

Leave the image on the IceSat-2 Hackweek image repository. We can get a new conda-lock file for the icesat2 hackweek image and release a new tag. This doesn't interfere with the image for the Zenodo release and gets a new image that we know will work quickly, but it's not in the same place that icepyx people are working.
Make a repo for this image in the icesat2py org. This allows for minimizing the packages involved so the image is smaller / faster, is technically the right place for this image to live, where icepyx is being developed, and is independent of the hackweek, but will be more work.

Make a repo for this image in the icesat2py org. This allows for minimizing the packages involved so the image is smaller / faster, is technically the right place for this image to live, where icepyx is being developed, and is independent of the hackweek, but will be more work.

This seems like a good idea. I recommend using this to setup a repository that builds an image with the minimal conda dependencies for icepyx https://github.com/jupyterhub/repo2docker-action

@salvis2, I say we go with @scottyhq's suggestion to set up a repo2docker-action. Let me know if you need anything from me!

@JessicaS11 , I can set up the repo. I'm assuming the only things that it will need are whatever I find in the example notebooks import statements. Let me know if there's anything else it needs.
We will need to decide whose DockerHub credentials will be used for pushing the image (probably not mine). Also would be good to create an icepyx organization on DockerHub (or we can put it somewhere else). Just want somewhere for the image to live. It could just be under your username for now. I'll set up the image repo in the next few days and ping you there but that's what I think will need doing.

@salvis2 I think that should be good (what's in the import statements), unless we need to be more proactive for installing icepyx itself (currently that will need to be done with pip, as we're not on conda yet, so it could make sense to create the environment with needed dependencies. One of them is gdal, which tends to mess things up if you try to add it later).
I'll look into creating an icepyx organization on DockerHub, but I'm fine for it to be under my username for now.

Per a suggestion by @scottyhq , I put in my own credentials and a place for an image to live under my username, and the build worked! https://github.com/salvis2/icepyx-examples-image/actions/runs/316625746
@JessicaS11 if you have credentials to put into the icepyx-gallery repo tomorrow, I'll use them to build the image and get to testing the gallery. I can test with my own image otherwise and we will just switch things later.

So I tried building the notebooks and found out it doesn't have icepyx installed. It doesn't have anything that I specified in requirements.txt. I can find packages from environment.yml though. @scottyhq , do you know why it wouldn't pick up the requirements.txt file? I figured everything in the root folder would be fine: https://repo2docker.readthedocs.io/en/latest/usage.html#where-to-put-configuration-files. The configuration files documentation says it supports the file, but their example doesn't have git links.

Fixed the requirements.txt issue in https://github.com/icesat2py/icepyx-examples-image/commit/bd6cbd86ef2fadfa284c6759e1fb29783bfe65d1

Okay! We are getting to a good spot. The notebooks can launch with binder, start building, and import icepyx correctly at least. They are currently failing with different errors:
ICESat-2_DAAC_DataAccess2_Subsetting.ipynb
CellExecutionError: An error occurred while executing the following cell:
------------------
region_a.earthdata_login('username','email')
------------------
...
AssertionError: Enter a properly formatted email address

ICESat-2_DAAC_DataAccess2_Subsetting.ipynb
CellExecutionError: An error occurred while executing the following cell:
------------------
region_a = ipx.Query(short_name, spatial_extent, date_range)
------------------
...
AssertionError: Check that the path and filename of your geometry file are correct

ICESat-2_DEM_comparison_Colombia_working.ipynb
CellExecutionError: An error occurred while executing the following cell:
------------------
%%bash
cd ~
# git clone https://github.com/icesat2py/icepyx.git
# git clone https://github.com/ICESAT-2HackWeek/topohack.git
# git clone https://github.com/darribas/contextily.git

cd contextily
pip install -e .
cd ../topohack
pip install -e .
cd ../icepyx
pip install -e .
------------------
...
CalledProcessError: Command 'b'cd ~\n# git clone https://github.com/icesat2py/icepyx.git\n# git clone https://github.com/ICESAT-2HackWeek/topohack.git\n# git clone https://github.com/darribas/contextily.git\n\ncd contextily\npip install -e .\ncd ../topohack\npip install -e .\ncd ../icepyx\npip install -e .\n'' returned non-zero exit status 1.

As far as that last one is concerned, the three modules here should be installed via pip, so we shouldn't need to install them here.

This is looking great @salvis2! For the last issue, I think you're right that we can take those out since we've included those resources by default in the environment. That example was originally developed to be run on an older image that didn't have those modules.
As for the other two, I'll admit I'm not entirely sure why the subsetting example is returning them but the data access example did not. Any thoughts on that?

Ah well the first problem is that I pasted the wrong notebook name in second position. I've edited the comment to reflect this.
So the data subsetting notebook fails because the email provided is literally 'email'. The data access notebook fails on the query because of something about the geometry file.
The geometry file may not actually get to binder. The default setup of binderbot is to only clone files in the base repo and I changed that for the GitHub Action but it may be a limitation for binder as well. There was another example where I had to put the data file into a notebook cell to get it to run.

I'm trying a fix for the last notebook with the most obvious error but I don't think I will get all the notebooks building by myself. I'll set up a PR for all the files today and y'all can take it from here. I've opened up another issue #3 with brief instructions on finalizing the link between this repo and the gallery once everything else is ready.

Just to follow up on this (after almost half a year). Am I correct in saying that the main issue is now having an email/password combination in the notebook to run the gallery example code? Was wondering if there's a way around the authentication issue, e.g. a way of caching the data or using an alternative authentication method (does NSIDC have API tokens)?


SNI callback doesn't have access to the IServiceProvider

It seems like it would be very useful for the SNI callback to be able to activate services from DI, but I don't see anywhere I can get a ServiceProvider. The IFeatureCollection is connection-level and doesn't contain a service provider. I know the RequestServices aren't available, but I presume there are singleton and transient services I could be able to activate.

Sounds like something that could be added to the feature collection.

Yep, that's what I was thinking.

Triage: We'll think about this if we hear more customer feedback.


apply the inverse scale factor using the transform in UI text extraction

Objective
bevy_ui::extract_text_uinodes multiplies the position and atlas coordinates of each glyph by the inverse scale factor. It would be more efficient to apply the scaling directly to the text node's transform.
Solution
Scale the transform by the inverse scale factor instead.
cargo run --profile stress-test --features trace_tracy --example many_glyphs

Changelog
bevy_ui::extract_text_uinodes:
The text node's transform is scaled by the inverse scale factor, instead of multiplying the positions and atlas coordinates of each individual glyph.

Is this effectively reverting https://github.com/bevyengine/bevy/pull/8197? It seems like it reintroduces the bug that was fixing.

Oh you are right, this doesn't work the text is still distorted when cropped. I must have been on the wrong branch or something when I tested it earlier I was thinking other changes since #8197 must have fixed the cropping.

Is this effectively reverting #8197? It seems like it reintroduces the bug that was fixing.

An alternative is that we could scale the texture rects and atlas size stored in the texture atlas. It would simplify extraction but seems like a hack though.

Avoids any problems now by only applying the scaling to the transform when text is unclipped.

Can you run a new set of benchmarks quick? It sounds like we've introduced a branch since that last one.


New Schema.org tests should work with nested objects

Describe the bug
The new Schema.org property tests - that check if property names valid or not - should work with nested objects.
Note: Applies to the new Schema.org property tests are in master but not in the release version.
To Reproduce
Nested property names (ie any property that is not a top level property) are not currently checked for validity. See existing invalid properties fixture for an example of an error that is not caught (only some of the errors in the example are caught by the current tests).
Expected behaviour
Nested property names should be checked to see if they are valid and should raise an error if they are not valid on a nested property. This might prove tricky to implement as some properties can be one of many different types and that might complicate the logic.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Note: Applies to the new Schema.org property tests are in master but not in the release version.

Does this mean this bug is not present in v4.5?

Can confirm yes this bug is not in the currently released version just in the master version - the current version does not check property names for validity at all (just reports what it finds).
This is my fault for merging the work for the next release (5.0) into master instead of pushing to a separate branch.


Ignore non-infrastructure costs

Proposal for addressing part of https://github.com/thegreenwebfoundation/green-cost-explorer/issues/15
I think focusing on the infrastructure costs would make sense because it's actionable.

good idea, I've added a note in the readme @vsmart !

Thanks @Jell! 🎉


ALM server should retry forever to connect to Postgres

Nowadays, alm server retries 50 times to connect to Postgres and then fails. This parameters is configurable but I believe the alm-server should try forever to connect to the db. In a distributed system, all the pieces should remain alive even if one goes or is down during a certain amount of time. So I am more in favor of having a constant retry instead of an arbitrary amount of retries.
Piece of code where this can be configured in configuration.go:
// The number of times alm server will attempt to open a connection to the database before it gives up
	viper.SetDefault(varPostgresConnectionMaxRetries, 50)

I also tested to freeze the network virtual interface of the container to see if alm-server is affected. alm-server is able to keep working (to talk again with the db) once the interface is enabled again.
However if, at anytime, I s

(dial tcp <IP_ADDRESS>:5432: getsockopt: connection refused)
[2017-02-14 10:36:16]

(dial tcp <IP_ADDRESS>:5432: getsockopt: connection refused)
almightycore_db_1

alm-cli  returns a weird error if the server cannot connect to the Postgres db, as shown above.
vagrant@vagrant-ubuntu-trusty-64:~/rh_repo/gopath/src/github.com/almighty/almighty-core$ ./bin/alm-cli generate login -H localhost:8080 --pp
2017/02/14 10:15:53 [INFO] started id=tfLHFub1 GET=http://localhost:8080/api/login/generate
2017/02/14 10:15:53 [INFO] completed id=tfLHFub1 status=401 time=33.623161ms
error: 401: {"errors":[{"code":"unauthorized","detail":"Postgres developer mode not enabled","id":"4mog+2iF","status":"401","title":"Unauthorized"}]}

@hectorj2f A user should be able to set the maximum number of connection retries with this config line:
https://github.com/almighty/almighty-core/blob/master/config.yaml#L12
postgres.connection.maxretries: 50

But I agree that we should make the default better.

This has been addressed by #790


Loop over namespaces when listing reconciled objects

Fixes #3231
What changed?
When getting reconciled objects, instead of just looping over kinds and retrieving all objects cluster-wide, loop over only namespaces which the current user has access to, as well as kinds as before.
Why was this change made?
When an OIDC impersonated user does not have cluster-wide privileges, the weave-gitops UI will not show any resources that are reconciled as part of kustomize/helmrelease etc objects. This change means that only objects in namespaces which the user has permissions in will be listed.
How was this change implemented?
Simply providing another option to the client when calling List(), which specifies the namespace to list from, and looping over the namespaces which the user has access to. The list of user-accessible namespaces was already defined a few lines later in the code.
How did you validate the change?
Tested locally/in our production clusters.
We are expecting that existing tests should already cover this and dont need updating.
Release notes
Bugfix, nothing notable
Documentation Changes
None

@timricese thank you for submitting this PR! 🎉 We'll review it as soon as we have some bandwidth.
Some checks are failing. Could you please fix whatever can be fixed? (All that is not caused by some unpatched JS vulnerabilities or similar issues.)

Thanks!
The failing test (just linting whitespace) should work now.

Great stuff @timricese. I added a commit providing integration tests for the intended behaviour. Let me know what you think.


fix(sbb-menu): fixed the window snap on scrolling with an open menu

Preflight Checklist

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the pull request tracker for a Pull Request (PR) that matches the one I want to submit, without success.

Issue
With an open menu, if you scroll down the page there is a snap effect that moves the scroll to the focused trigger element
Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information on what is checked during the review process.
Browsers
I tested the build on the following browsers:

[x] Firefox Desktop
[x] Chrome Desktop
[x] Edge Desktop
[x] Safari Desktop
[x] Chrome Mobile
[ ] Safari Mobile

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Codecov Report

Merging #1736 (1dbeafd) into master (ab917b0) will increase coverage by 0.86%.
The diff coverage is 61.66%.

:exclamation: Current head 1dbeafd differs from pull request most recent head 08a6b06. Consider uploading reports for the commit 08a6b06 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master    #1736      +/-   ##
==========================================
+ Coverage   54.85%   55.72%   +0.86%
==========================================
  Files          49      149     +100
  Lines        1659     5786    +4127
  Branches      406     1579    +1173
==========================================
+ Hits          910     3224    +2314
- Misses        671     2363    +1692
- Partials       78      199     +121

Impacted Files
Coverage Δ

...ts/sbb-accordion-item/sbb-accordion-item.events.ts
100.00% <ø> (ø)

...mponents/sbb-accordion-item/sbb-accordion-item.tsx
0.00% <0.00%> (-37.21%)
:arrow_down:

src/components/sbb-calendar/sbb-calendar.events.ts
0.00% <0.00%> (ø)

src/components/sbb-checkbox/sbb-checkbox.events.ts
0.00% <ø> (ø)

...components/sbb-datepicker/sbb-datepicker.events.ts
0.00% <0.00%> (ø)

src/components/sbb-dialog/sbb-dialog.tsx
44.69% <ø> (ø)

src/components/sbb-divider/sbb-divider.tsx
100.00% <ø> (ø)

src/components/sbb-footer/sbb-footer.tsx
100.00% <ø> (+12.50%)
:arrow_up:

src/components/sbb-form-error/sbb-form-error.tsx
100.00% <ø> (ø)

src/components/sbb-form-field/sbb-form-field.tsx
36.20% <ø> (ø)

... and 28 more

... and 122 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Bugfix]Automatically adjust content insets

Add controller to closest parent on time so as to fix the automaticallyAdjustContentInsets feature.
Here’s the bug to fix:
https://github.com/facebook/react-native/issues/898

It seems like this PR combines several different things (adds title icon to navigator, fixes content insets bug, fixes some sort of routing issue with navigator).
It would be really helpful if you could split these into separate pull requests, not only to make it easier to review them, but also because that way if one of them introduces a bug, we can isolate it and roll back without stripping out the other features/fixes.

@nicklockwood yes, it's a misoperation. So I close this PR and create another one with just what the title says: https://github.com/facebook/react-native/pull/3509
Thank you for your reply~


It would be nice if it works after download

In the previous version, it was comforting to see a nice sample site after download and running
bundle exec jekyll serve
I stayed with mm largely because of this because it was like being blindfolded and dropped off in a foreign country. I don't know how much time it would take me to get it working.
Now, mm joins amplify, jekyll-bootstrap, and others with this frustrating screen:

It makes me want to run away screaming.
Even though people will be changing files after cloning etc.
can you at least get us to first base here?

This was by design. I purposely removed all of the demo posts, pages, and collections because that is content and not part of the theme. You'd be surprised how many people had no clue they could (or should) remove them. For example you know how many forks kept the "Theme Setup" page? Answer. A TON!
And as you even said:

Even though people will be changing files after cloning etc.

All the more reason to remove the demo content. Why give people an extra step if they're going to remove it anyways?
Regardless I did leave the index.html page in tact and it does get you to a base site.
It looks to me as if you're using my gh-pages branch which you really shouldn't be doing.
If you use master you'll get the normal "Recent Posts" homepage albeit with no posts. My gh-pages branch has baseurl: minimal-mistakes/ set which means you have to access it at http://localhost:4000/minimal-mistakes/ because of said baseurl.

Here is my approach

git clone https://github.com/mmistakes/minimal-mistakes  mymm
bundle the folder
git clone https://github.com/mmistakes/minimal-mistakes-demo
Copy demo files over the template:
cp -r ./minimal-mistakes-demo ./mymm
(in the future, I'll move from folder containing my files)
bundle exec jekyll serve

This results in this error message:
  Liquid Exception: The included file '/Users/mac/gits/jekyll/minimal-mistakes/_includes/feature-row' should exist and should not be a symlink in minimal-mistakes-demo/_pages/splash-page.md
jekyll 3.0.3 | Error:  The included file '/Users/mac/gits/jekyll/minimal-mistakes/_includes/feature-row' should exist and should not be a symlink

I found the Gem-based "quick start" instructions did not result in a fully working install.  I found this issue logged when searching for information. I am just posting this as feedback and in case it helps others who may end up here with the same problems. Here are the steps which worked for me for a complete working install, albeit containing only one post:
$ gem install jekyll bundler
$ jekyll new jekyll-mm
$ cd jekyll-mm
$ sed -i -e 's/"minima".*/"minimal-mistakes-jekyll"/' Gemfile
$ bundle install
$ rm _config.yml index.md about.md
$ wget https://raw.githubusercontent.com/mmistakes/minimal-mistakes/master/_config.yml
$ echo 'theme: minimal-mistakes-jekyll' >> _config.yml
$ wget https://raw.githubusercontent.com/mmistakes/minimal-mistakes/master/index.html
$ sed -i -e 's/^layout: post/layout: single/' _posts/*welcome-to-jekyll.markdown
$ jekyll serve

note espacially the neeed to add theme: minimal-mistakes-jekyll to the supplied _config.yml. Without this it does not work.


Missing a site navigator to "Transferring Save games"

You have a guide for how to transfer wii saves, but no way to access this via Site navigation
https://wii.hacks.guide/transfer-saves.html

Fixed in commit a572e6a.