Make pg ranges nullable

See failing test on travis https://travis-ci.org/calebmer/postgraphql/jobs/185117607

Yeah, here we aren't handling null liberals. The fix should be fairly simple though.

I would prefer if someone else would tackle this … I dont yet feel confident enough with Typescript.

@calebmer I have fixed part of the problem by making the PgRangeObject nullable.

I cant update the failing snapshot of the introspection since this test has been failing for me some reasons I don’t understand,
*  will get everything needed in an introspection
    No class was found with id 26773

I am confused since it seems to work without changing the suggested transformPgValueIntoValue. I made sure by adding a line to the query fixtures.
Also sorry for the noise ☺ I will try to be more succinct.

re: updating the snapshot. see https://github.com/calebmer/postgraphql/pull/286#issuecomment-268311044. Could you go ahead and do it for me. Also by any chance do you know why this tests fails for me.

@ferdinandsalis and @calebmer: I've updated the snapshot (had to exclude my failing money tests which are still throwing Cannot return null for non-nullable field Type.money) but I'm not sure if you want to review the diff again before merging?

Released in 2.4.1 :tada:

@benjie thanks for updating the snapshot ☺ did not think about excluding the failing test …
Happy Holidays everyone!

I'm addicted to --patch in git; I use it with everything: git add, git checkout, git stash, git reset; so omitting the failing tests was just a couple of ns 😀
Happy Holidays to you too 🎉


Add type narrowing support for while

Purpose

This PR adds support for narrowing the type of a var when a type test is used in the while condition.

Fixes #16136
Samples
record {| string val; |}?[] arr = [{val: "foo1"}, {val: "foo2"}, {val: "foo3"}, (), {val: "foo5"}];

    record {| string val; |}|() rec = arr[0];
    int i = 0;

    while (rec is record {| string val; |}) {
        string s = rec.val;
        io:println(s);
        i += 1;
        rec = arr[i];
    }

Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #16137 into jballerina will decrease coverage by 0.01%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             jballerina   #16137      +/-   ##
================================================
- Coverage         12.49%   12.48%   -0.02%
+ Complexity         3888     3850      -38
================================================
  Files              2039     2039
  Lines             91477    91478       +1
  Branches          12040    12035       -5
================================================
- Hits              11434    11422      -12
+ Misses            78000    77990      -10
- Partials           2043     2066      +23

Impacted Files
Coverage Δ
Complexity Δ

.../compiler/semantics/analyzer/SemanticAnalyzer.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...lerinalang/observe/nativeimpl/CounterGetValue.java
28.57% <0%> (-71.43%)
1% <0%> (-1%)

...allerinalang/observe/nativeimpl/GaugeGetValue.java
28.57% <0%> (-71.43%)
1% <0%> (-1%)

...llerinalang/observe/nativeimpl/GaugeDecrement.java
33.33% <0%> (-66.67%)
1% <0%> (-1%)

...llerinalang/observe/nativeimpl/GaugeIncrement.java
33.33% <0%> (-66.67%)
1% <0%> (-1%)

...erinalang/observe/nativeimpl/CounterIncrement.java
33.33% <0%> (-66.67%)
1% <0%> (-1%)

...allerinalang/observe/nativeimpl/GaugeSetValue.java
33.33% <0%> (-66.67%)
1% <0%> (-1%)

...lang/langserver/sourceprune/LHSTokenTraverser.java
55.55% <0%> (-41.75%)
9% <0%> (-18%)

...lang/langserver/sourceprune/RHSTokenTraverser.java
44.64% <0%> (-41.08%)
9% <0%> (-11%)

...erinalang/observe/nativeimpl/GaugeGetSnapshot.java
66.66% <0%> (-33.34%)
1% <0%> (-1%)

... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77692f...d6fb641. Read the comment docs.


Fix method name typo in warning log

The method is called handle_action instead of handle*r*_action. The debug log three lines below states the correct method name.

Coverage remained the same at 36.524% when pulling 83b413be5665bf92f4a451ab495c090bf8b70a81 on der-lyse:typo into 2ecb4cac85269d28f142f8a7bd7c6f90013937fc on newsboat:master.

Coverage remained the same at 36.524% when pulling 83b413be5665bf92f4a451ab495c090bf8b70a81 on der-lyse:typo into 2ecb4cac85269d28f142f8a7bd7c6f90013937fc on newsboat:master.

Coverage remained the same at 36.524% when pulling 83b413be5665bf92f4a451ab495c090bf8b70a81 on der-lyse:typo into 2ecb4cac85269d28f142f8a7bd7c6f90013937fc on newsboat:master.

Thank you!


Bootstrap doesn't build the grid using screen-xs

It's just been noticed that when compiling Bootstrap 3.3.7 you don't use $screen-xs to build the grid/visible classes/responsive utilities.
In my mind it would seem more appropriate for the breakpoints to be like this;
screen-xs = 0px - 768px
screen-sm = 769px - 992px
screen-md = 993px - 1200px
screen-lg = 1201px +

thank you my friend :)

Bootstrap 3 is essentially in maintenance mode as we focus on working towards a stable v4. As such, we're only accepting changes to v3's code on a case-by-case basis, usually only for critical bug fixes or docs improvements.

This is a saved reply.


Improve onboarding task description and replies

Details

The PR improves onboarding task views:

Subtitle and instruction comments have been combined into a task description.
Omited task action replies.

Fixed Issues

$ https://github.com/Expensify/App/issues/40998
PROPOSAL: N/A
Tests

Note: you can run the flow as many times as you want by adding a test button into TestToolMenu.tsx.
Details
<TestToolRow title="Onboarding Flow">
    <Button
        small
        text="Navigate"
        onPress={() => {
            Navigation.dismissModal();
            Navigation.navigate(ROUTES.ONBOARDING_PURPOSE);
        }}
    />
</TestToolRow>

Open the app with an entire new user.
Complete the onboarding flow.
Verify that the app has generated the proper messages.
Verify that task actions don't have replies.
Click on a task action.
Verify that the task has a description.
Verify that the description is formatted and renders bold text and links properly.
Verify that the task does not have any actions, except the "marked as completed" for the "create a workspace" case.

[x] Verify that no errors appear in the JS console

Offline tests

Same as "Tests".
QA Steps

Same as "Tests".

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/57314631/04c1d06f-6601-4918-8c7a-84fc748d9951

iOS: Native

https://github.com/Expensify/App/assets/57314631/055aa2ff-eb30-4119-a648-65bbb92cb660

iOS: mWeb Safari

https://github.com/Expensify/App/assets/57314631/abfd9e7f-9477-49d1-8525-26784c2f0ffc

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/57314631/1e2192f9-2331-4189-a73f-e4d744739f2a

MacOS: Desktop

https://github.com/Expensify/App/assets/57314631/3a696a27-6dc5-48e4-af47-1ae0c86fe153

Un-assigning you @rushatgabhane since @rayane-djouah took care of it.

Code looks good to me, testing it out.

Auth PR deployed to production, removing the hold. This should be able to be merged.

Fixed the conflict, the TRACK option has been removed in https://github.com/Expensify/App/pull/41354. Going to do a final review and merge.
We can change the messages to use markdown in a follow-up PR, it's not breaking anything.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.69-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.69-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Can build the project

I'm using
docker compose up --build
and I get
 => ERROR [frontend build 4/7] RUN yarn add @neo4j-nvl/interaction-handlers @neo4j-nvl/core @neo4j-nvl/react       0.7s
------
 > [frontend build 4/7] RUN yarn add @neo4j-nvl/interaction-handlers @neo4j-nvl/core @neo4j-nvl/react:
0.564 yarn add v1.22.19
0.602 error An unexpected error occurred: "Failed to replace env in config: ${NPM_TOKEN}".

@xpilasneo4j  please use DEV branch.
Similar issue to #261

Thank you, sorry about the duplicated issue


S3 mixer doesn't start

Hello everyone,
I am currently using SageMaker connected to an S3 Bucket. I successfully downloaded data and obtained tagging results with Dolma without encountering any issues. However, during the final mixing step, I encountered the following error:
[2024-03-26T11:38:37Z INFO  dolma::s3_util] Listing objects in bucket=h-datasets, prefix=pretraining/wikipedia/v0/documents/ thread '<unnamed>' panicked at src/s3_util.rs:249:18: called 'Result::unwrap()' on an 'Err' value: ServiceError(ServiceError { source: Unhandled(Unhandled { source: ErrorMetadata { code: Some("PermanentRedirect"), message: Some("The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint."), extras: Some({"aws_request_id": "M0KWX3F3J6VJX7FS", "s3_extended_request_id": "dHPizkgVIoHo4PH0GgJQVt+LvOXiFOKdN7JKqIP6pDWGqvGLmAxrY4Ct7JSCA3geVAkkJxOCpwo="}) }, meta: ErrorMetadata { code: Some("PermanentRedirect"), message: Some("The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint."), extras: Some({"aws_request_id": "M0KWX3F3J6VJX7FS", "s3_extended_request_id": "dHPizkgVIoHo4PH0GgJQVt+LvOXiFOKdN7JKqIP6pDWGqvGLmAxrY4Ct7JSCA3geVAkkJxOCpwo="}) } }), raw: Response { inner: Response { status: 301, version: HTTP/1.1, headers: {"x-amz-bucket-region": "us-west-2", "x-amz-request-id": "M0KWX3F3J6VJX7FS", "x-amz-id-2": "dHPizkgVIoHo4PH0GgJQVt+LvOXiFOKdN7JKqIP6pDWGqvGLmAxrY4Ct7JSCA3geVAkkJxOCpwo=", "content-type": "application/xml", "transfer-encoding": "chunked", "date": "Tue, 26 Mar 2024 11:38:36 GMT", "server": "AmazonS3"}, body: SdkBody { inner: Once(Some(b"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error>PermanentRedirect<Message>The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint.</Message><Endpoint>h-datasets.s3-us-west-2.amazonaws.com</Endpoint><Bucket>h-datasets</Bucket><RequestId>M0KWX3F3J6VJX7FS</RequestId><HostId>dHPizkgVIoHo4PH0GgJQVt+LvOXiFOKdN7JKqIP6pDWGqvGLmAxrY4Ct7JSCA3geVAkkJxOCpwo=</HostId></Error>")), retryable: true } }, properties: SharedPropertyBag(Mutex { data: PropertyBag { contents: ["aws_smithy_http::connection::CaptureSmithyConnection", "aws_http::user_agent::AwsUserAgent", "aws_sdk_s3::endpoint::Params", "aws_credential_types::credentials_impl::Credentials", "aws_types::region::SigningRegion", "aws_types::region::Region", "aws_credential_types::cache::SharedCredentialsCache", "aws_smithy_types::endpoint::Endpoint", "aws_sig_auth::middleware::Signature", "aws_sig_auth::signer::OperationSigningConfig", "aws_types::SigningService", "alloc::vec::Vec<http::version::Version>", "aws_smithy_http::operation::Metadata"] }, poisoned: false, .. }) } }) note: run with 'RUST_BACKTRACE=1' environment variable to display a backtrace
Regarding permissions, everything appears to be functioning correctly since I can list the objects using my credentials, which are stored in aws/credentials and also exported in the environment variables.
Does anyone have any suggestions? Thank you for your time.

hello @marcopasqua! Could you post your mixer configuration? you might have a typo there.
I suggest running the mix command with --dryrun to print the configuration as it is parsed by the toolkit.

@marcopasqua You may want to make sure the region for your bucket is set properly. This was the problem for me :).


Fail to record on AMD GPU

I switched to an AMD laptop and wl-screenrec stopped working for me:
RUST_BACKTRACE=full wl-screenrec -g "$(slurp -d)" --low-power off
Using output DP-2
Opening libva device from DRM device /dev/dri/renderD128
[h264_vaapi @ 0x643f87ae4680] Driver does not support some wanted packed headers (wanted 0xd, found 0x1).
Protocol error 6 on object zwp_linux_buffer_params_v1@14: invalid buffer stride or height for plane 0
thread 'main' panicked at src/main.rs:1703:45:
called `Result::unwrap()` on an `Err` value: Backend(Protocol(ProtocolError { code: 6, object_id: 14, object_interface: "zwp_linux_buffer_params_v1", message: "invalid buffer stride or height for plane 0" }))
stack backtrace:
   0:     0x643f870971fe - <unknown>
   1:     0x643f8705e8c0 - <unknown>
   2:     0x643f870953c3 - <unknown>
   3:     0x643f87096fa4 - <unknown>
   4:     0x643f87098680 - <unknown>
   5:     0x643f87098395 - <unknown>
   6:     0x643f87098b8e - <unknown>
   7:     0x643f87098a8e - <unknown>
   8:     0x643f870976c6 - <unknown>
   9:     0x643f87098812 - <unknown>
  10:     0x643f87001855 - <unknown>
  11:     0x643f87001cf3 - <unknown>
  12:     0x643f870dff7c - <unknown>
  13:     0x643f87109ab3 - <unknown>
  14:     0x643f87116a39 - <unknown>
  15:     0x643f87090a45 - <unknown>
  16:     0x643f87116a2e - <unknown>
  17:     0x7818a4643cd0 - <unknown>
  18:     0x7818a4643d8a - __libc_start_main
  19:     0x643f87006e45 - <unknown>
  20:                0x0 - <unknown>

Here is my system:
CPU:
  Info: 8-core model: AMD Ryzen 7 7840U w/ Radeon 780M Graphics bits: 64
    type: MT MCP arch: Zen 4 rev: 1 cache: L1: 512 KiB L2: 8 MiB L3: 16 MiB
  Speed (MHz): avg: 1277 high: 2311
    min/max: 400/5289:5132:5447:6076:5605:5760:5918 cores: 1: 1397 2: 400
    3: 1397 4: 1822 5: 1397 6: 1891 7: 1397 8: 1396 9: 1397 10: 400 11: 1397
    12: 400 13: 1645 14: 400 15: 2311 16: 1395 bogomips: 105434
  Flags: avx avx2 ht lm nx pae sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3 svm
Graphics:
  Device-1: AMD Phoenix1 vendor: Framework driver: amdgpu v: kernel
    arch: RDNA-3 bus-ID: c1:00.0 temp: 48.0 C
  Device-2: Realtek Laptop Camera driver: uvcvideo type: USB bus-ID: 3-1:2
  Display: wayland server: Xwayland v: 23.2.4 compositor: Hyprland driver:
    gpu: amdgpu resolution: 1: 3840x2160~60Hz 2: 2256x1504~60Hz
  API: OpenGL v: 4.6 compat-v: 4.5 vendor: amd mesa v: 23.3.5-arch1.1
    glx-v: 1.4 direct-render: yes renderer: AMD Radeon Graphics (radeonsi
    gfx1103_r1 LLVM 16.0.6 DRM 3.57 6.7.4-arch1-1)

Are you comfortable with building Hyprland? The error is a bit unhelpful as is. If you could apply this patch to wlroots and try again....
diff --git a/types/wlr_linux_dmabuf_v1.c b/types/wlr_linux_dmabuf_v1.c
index 9560ace30..4b257a7b6 100644
--- a/types/wlr_linux_dmabuf_v1.c
+++ b/types/wlr_linux_dmabuf_v1.c
@@ -338,7 +338,8 @@ static void params_create_common(struct wl_resource *params_resource,
                                attribs.stride[i] * height > size) {
                        wl_resource_post_error(params_resource,
                                ZWP_LINUX_BUFFER_PARAMS_V1_ERROR_OUT_OF_BOUNDS,
-                               "invalid buffer stride or height for plane %d", i);
+                               "invalid buffer stride or height for plane %d: offset=%u stride=%u height=%d size=%zd. format=0x%08x",
+                               i, attribs.offset[i], attribs.stride[i], height, size, format);
                        goto err_out;
                }
        }

Sure:
RUST_BACKTRACE=full wl-screenrec -g "$(slurp -d)" --low-power off
Using output DP-2
Opening libva device from DRM device /dev/dri/renderD128
[h264_vaapi @ 0x606d136878c0] Driver does not support some wanted packed headers (wanted 0xd, found 0x1).
Protocol error 6 on object zwp_linux_buffer_params_v1@14: invalid buffer stride or height for plane 0: offset=0 stride=15360 height=2164 size=33177600. format=0x34325258
thread 'main' panicked at src/main.rs:1703:45:
called `Result::unwrap()` on an `Err` value: Backend(Protocol(ProtocolError { code: 6, object_id: 14, object_interface: "zwp_linux_buffer_params_v1", message: "invalid buffer stride or height for plane 0: offset=0 stride=15360 height=2164 size=33177600. format=0x34325258" }))
stack backtrace:
   0:     0x606d128281fe - <unknown>
   1:     0x606d127ef8c0 - <unknown>
   2:     0x606d128263c3 - <unknown>
   3:     0x606d12827fa4 - <unknown>
   4:     0x606d12829680 - <unknown>
   5:     0x606d12829395 - <unknown>
   6:     0x606d12829b8e - <unknown>
   7:     0x606d12829a8e - <unknown>
   8:     0x606d128286c6 - <unknown>
   9:     0x606d12829812 - <unknown>
  10:     0x606d12792855 - <unknown>
  11:     0x606d12792cf3 - <unknown>
  12:     0x606d12870f7c - <unknown>
  13:     0x606d1289aab3 - <unknown>
  14:     0x606d128a7a39 - <unknown>
  15:     0x606d12821a45 - <unknown>
  16:     0x606d128a7a2e - <unknown>
  17:     0x78c81a443cd0 - <unknown>
  18:     0x78c81a443d8a - __libc_start_main
  19:     0x606d12797e45 - <unknown>
  20:                0x0 - <unknown>

Could you test the rgb_size_from_compositor branch?

It is recording now. One issue: When using slurp, wl-screenrec only records my top-left corner. The size from the slurp selection is applied, but not the position.
I greatly appreciate your help!

That issue is #47


Unable to use GIF or WebP in a release apk, Fresco imagepipeline is stripped by ProGuard

If we build an apk in release with ProGuard enabled, when we load a scene that include a GIF or WebP image from the Image component, the application will crash with the following error :
java.lang.UnsatisfiedLinkError: JNI_ERR returned from JNI_OnLoad in "/data/app/com.imagepipeline-1/lib/x86/libgifimage.so"

Tested with<EMAIL_ADDRESS>Steps to reproduce
import { Image } from 'react-native';

export default function ImagePipeline() {
  return (
    <Image
      style={{ flex: 1 }}
      source={{ uri: 'https://media.giphy.com/media/GRld0uPxi1V1C/giphy.gif' }}
      resizeMode={'cover'}
    />
  );
}

Be sure you're using a GIF or WebP icon with the Image component.
Enable ProGuard in release builds. In android/app/build.gradle def enableProguardInReleaseBuilds = true
Build your application in release.
Open the scene that contains the GIF or WebP.
Enjoy the crash.

Proposed solution
Fresco documentation recommends the following ProGuard configuration :
# Keep our interfaces so they can be used by other ProGuard rules.
# See http://sourceforge.net/p/proguard/bugs/466/
-keep,allowobfuscation @interface com.facebook.common.internal.DoNotStrip

# Do not strip any method/class that is annotated with @DoNotStrip
-keep @com.facebook.common.internal.DoNotStrip class *
-keepclassmembers class * {
    @com.facebook.common.internal.DoNotStrip *;
}

# Keep native methods
-keepclassmembers class * {
    native <methods>;
}

-dontwarn okio.**
-dontwarn com.squareup.okhttp.**
-dontwarn javax.annotation.**
-dontwarn com.android.volley.toolbox.**

So I tested this by adding it to the React Native proguard file like this :
 # React Native

 # Keep our interfaces so they can be used by other ProGuard rules.
 # See http://sourceforge.net/p/proguard/bugs/466/
 -keep,allowobfuscation @interface com.facebook.proguard.annotations.DoNotStrip
 -keep,allowobfuscation @interface com.facebook.proguard.annotations.KeepGettersAndSetters
+-keep,allowobfuscation @interface com.facebook.common.internal.DoNotStrip

 # Do not strip any method/class that is annotated with @DoNotStrip
 -keep @com.facebook.proguard.annotations.DoNotStrip class *
+-keep @com.facebook.common.internal.DoNotStrip class *
 -keepclassmembers class * {
     @com.facebook.proguard.annotations.DoNotStrip *;
+    @com.facebook.common.internal.DoNotStrip *;
 }

I built the apk and everything worked fine.
An another solution would be to add this line to the proguard :
-keep class com.facebook.imagepipeline.** { *; }

I'll do the pull request, but before that I just need your opinion.
Do you think this could have side effects?
Do you prefer a method?
Any other ideas?
cc @AndrewJack, @mkonicek, @janicduplessis

@facebook-github-bot label Android

The first solution seems a bit better since it might avoid similar problems in the future.

@AndrewJack I tested to display a GIF with<EMAIL_ADDRESS>it doesn't work since Fresco has been updated. (Without ProGuard)
final_failed @ onFailure: failure: java.lang.NullPointerException: Attempt to invoke interface method 'com.facebook.imagepipeline.image.CloseableImage com.facebook.imagepipeline.animated.factory.AnimatedImageFactory.decodeGif(com.facebook.imagepipeline.image.EncodedImage, com.facebook.imagepipeline.common.ImageDecodeOptions, android.graphics.Bitmap$Config)' on a null object reference

@charpeni The fresco dependencies have been split, I overlooked that when upgrading.
We either need to add a selectionl of these dependencies or allow users to add the gif/webp support themselves.
  // If your app supports Android versions before Ice Cream Sandwich (API level 14)
  compile 'com.facebook.fresco:animated-base-support:0.10.0'

  // For animated GIF support
  compile 'com.facebook.fresco:animated-gif:0.10.0'

  // For WebP support, including animated WebP
  compile 'com.facebook.fresco:animated-webp:0.10.0'
  compile 'com.facebook.fresco:webpsupport:0.10.0'

  // For WebP support, without animations
  compile 'com.facebook.fresco:webpsupport:0.10.0'

I'll investigate further.

It probably would not hurt to add gif/webp libs to RN because FB has all those libraries internally anyway.
Although it would be better to make users decide if they want the feature or not.
The leaner core is the faster builds are after all.

After adding compile 'com.facebook.fresco:animated-gif:0.10.0' to gradle file and rebuilt,
animated gifs <Image> wrapped in <Text> keep still, while those out of <Text> work fine.

<View>
  <Text>
    <Text>Inline animated gif --> </Text>
    <Image
      style={{width: 20, height: 20}}
      source={{uri: 'http://img.t.sinajs.cn/t4/appstyle/expression/ext/normal/5c/huanglianwx_org.gif'}}/>
  </Text>
  <Image
    style={{width: 20, height: 20, overlayColor: 'white'}}
    source={{uri: 'http://img.t.sinajs.cn/t4/appstyle/expression/ext/normal/5c/huanglianwx_org.gif'}}/>
</View>

@AndrewJack @janicduplessis

Another bug on iOS:
After pressing home key and then went go back to my App, all the gif images disappeared. And came back after the component was re-rendered.

First, let me say thanks to everyone on this ticket.  You saved me a headache!  I just ran into this problem.
@bestander  et al.  I agree it would be nice to add the libs.
1, easy for those of us upgrading to expect continued support of what we've put in various projects.
2, I remember being impressed when I saw gifs work in RN.
3, The functionality between mobile and web is nicely bridged by RN, keeping so with gif seems aligned.
Thanks again!

@mdluo Another bug on iOS: After pressing home key and then went back to the App,all the gif images disappeared.  do you know reason?

@mdluo @RongjieChen It will be fixed by #7612.

Thank you all, I will close this issue and submit a pull request to ensure the best experience with Fresco to the React Native developers.

Hi,
I had the GIF support issue now it's working in react native android now I want to know how can I make GIF image corner rounded I tried 'borderRadius: 10' it's working on other image format PNG or JPG but it's not working with GIF images.

@NitishAgrawal Can a workaround be that you wrap the image in a View and set borderRadius: 10 and overflow: 'hidden' on that?


Refactor urlbox_client post method.

What's this PR do?
Refactors urlbox_client post method.
Background context
This now uses the new _process_options method, as does all the other
get/head/delete methods.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@7fdfae1). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage        ?   99.07%
=======================================
  Files           ?        9
  Lines           ?      432
  Branches        ?        0
=======================================
  Hits            ?      428
  Misses          ?        4
  Partials        ?        0

Flag
Coverage Δ

unittests
99.07% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fdfae1...c3b6128. Read the comment docs.


RollingWindow enumerates in reverse time order

The RollingWindow<T> class provides a reverse time based indexing system common to trading platforms where rollingWindow[0] is the most recent piece of data and rollingWindow[n] would be the piece of data from n bars in the past.
For convenience, RollingWindow<T> : IEnumerable<T> but it enumerates the windows using the same indexing scheme, causing the enumeration to process backwards in time. This is not expected behavior for most, given that we typically want to enumerate chronologically, but provide indexing in reverse chronological order for the convenience of  'n bars ago'.
Are there any strong opinions in either direction here? I vote for updating the IEnumerable<T> implementation in RollingWindow<T> to perform the enumeration in chronological order.
Thoughts?

I really think rollingWindow[0] should give the same element as the first element given when using an enumerator. Doing otherwise will be maddeningly inconsistent, at least to me as a developer.
As a compromise, maybe offer a "ChronologicalEnumerator" method, that will always iterate according to chronological order (regardless of the order in which they are added to the window)?
Regardless, there's always the Enumerable.Reverse extension method for people who want it in the opposite direction.

I had similar thoughts which is why I implemented it that way in the beginning. I've heard some users of the code base state it is a little unexpected to enumerate in reverse chronological order.
Would it be crazy to have the indexing use negative numbers?
window[-1] gives you the previous value, this way the indexing and enumeration would be in sync?

A C# developer would expect to refer to rollingWindow[0] as the first element added to a collection, but the majority of retail trading scripting languages (NinjaScript, EasyLanguage, etc.) use the "barsAgo" pattern (rollingWindow[0] is always the current/last element of the data series).
My vote is to keep the current implementation for the indexer: it makes life easier for a strategy developer to migrate existing strategies to Lean/QC.

@StefanoRaggi  +1
I vote for retaining the current barsAgo implementation for the indexer.  If the developer wants to Array notation, use an array.
While debugging, I noticed that the underlying _list<{Class}> is not in the same sequence as the indexer, particularly when the indicator !IsReady().  So trying to use the for loop in @mchandschuh comment would lead to frustration and errors.  I learned I cannot rely on looping thorough the underlying list.  I learned I have to stick to the interface.  So if I want to iterate the RollingWindow I have to use a for loop like this.

            decimal sum = 0;
            for (int i = 0; i < Price.Count; i++)
                sum += Price[i];
            for (int i = Price.Count; i != 0; i--)
                sum -= Price[i];

EasyLanguage and most of the other scripting languages use the [0] notation for the most recent value of the RollingWindow.  However,  the = assignment in EasyLanguage creates the new [0]th element before the assignment, like this:

// creates rw[0], adds it to the list and
// then assigns it the value of 42
//  + the value of the next to last addition to the rw window.
rw = 42 + rw[1];

Whereas, RollingWindow.Add method creates the new element after the assignment, like this:

rw.Add(42 + rw[1]);  // not correct
rw.Add(42 + rw[0]);  // correct

or

var x = 42 + rw[0];
rw.Add(x);  // correct

Thanks for feedback @StefanoRaggi, @bizcad, @AnObfuscator. Will leave the system in its current form as a "barsAgo" indexer.


getSingleDebouncedButtonPress was renamed to getSingleDebouncedPress wrong readme

In the readme there is written:

The getSingleDebouncedButtonPress() function will return true once for each time it detects the button changing from the released state to the pressed state. The getSingleDebouncedButtonRelease() function will return true once for each time it detects the button changing from the pressed state to the released state.

These functions were renamed getSingleDebouncedPress and getSingleDebouncedRelease.

Thanks for letting us know!  I have fixed that problem, and I also fixed a similar problem in Pushtbutton.h.


Enabling normal map breaks 3D rendering

Godot 3.0.4
Windows 10 64 bits
nVidia geForce GTX 1060
I am unable to use normal mapping on a mesh in my project. If I do, the whole mesh becomes dark and unshaded. It renders normally if I uncheck normal map.
I could reproduce this only on this mesh so far. Other meshes in my project have normal maps but render fine for some reason. Nothing prints in the log.

Example project:
NormalMapBug.zip

Ok... the mesh was missing tangents.


Update to 0.9.2rc3

Re-configured the recipe to fit with standards from the docs (see run_constrained)
Also rerendered:
MNT: Re-rendered with conda-build 3.28.1, conda-smithy 3.30.1, and conda-forge-pinning 2<IP_ADDRESS>.50.53

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Also, I would like to help maintain this feedstock, but I can add that in a separate PR.


Update document

For step 5 add section c) exclude one account. You must exclude one account from the policy in case you are locked out. Without excluding minimum one account Azure will not allow you to create the policy.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5815957c-cc37-2982-7a50-16e96c0378b8
Version Independent ID: 33f22bdb-1675-96b0-27ad-8d1ba7cc5a75
Content: Conditional Access - Block access by location - Azure Active Directory
Content Source: articles/active-directory/conditional-access/howto-conditional-access-policy-location.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@dlagunas Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

You dont have to exclude a user in this case because you would only be blocking locations you specifically dont want users signing in from. You could choose to exclude a user if you wish.

#please-close


vim v7.4.1799

Hey @gutierri :

Please send version updates to Homebrew, not Linuxbrew, unless it's a Linux-only formula. (You can usually tell by the presence of the text # tag "linuxbrew"). We'll get the change post-merge.
We have split this repository into Linuxbrew/brew (Homebrew commands and libraries) and Linuxbrew/homebrew-core (formulae). Please send version updates and new formulae to the homebrew-core repository for the appropriate project from now on (this is true for both Homebrew and Linuxbrew). We're still working on fully migrating everyone to the split repos; I apologize for the growing pains.
In this particular instance, I don't think upstream will merge the PR since they have a specific schedule for updating vim.

Closing based on points 1 and 3. Thanks for contributing!

@rwhogg Just in case you haven't noticed it, this could also be useful https://github.com/Homebrew/brew/pull/168 which would be a big step forward, in my opinion.


Schedule Hold

When I use this integration with my S30, it sets schedule hold state.  I can cancel hold to get back to how the thermostat is supposed to operate but then schedule hold is initiated again at the next schedule change I think.   It is like the integration is setting a value different than the schedule at transition which triggers the hold.

That is interesting.   The integration does not send commands to the thermostat on its own, it only sends commands when requested to by an automation or from a Lovelace card.  There are several possibilities:

There are automations configured that ran and changed something
The thermostat was adjusted by someone - from the panel, HA or mobile app
Something is broken

Does this situation reliably reoccur? Or was this a one off?
if it reproduces, then I’d suggest capturing a full debug log as that’ll show the messages going back and forth as well as the integration adding and removing holds.
Instructions are here.
https://github.com/PeteRager/lennoxs30#reporting-bugs
I’ll need both the home assistant log file and the message log file.

Hello,
I also suspected tampering or an app on a phone.  I disabled all including the HA integration and the S30 works as expected.  Enabling the integration only brought the problem back.  I am confident I have not made any automations referencing the integration but will look again soon.  I really only notice because of the schedule hold text on the S30 and the fact the fan does not follow its scheduled setting of On when in schedule hold mode.  The temperature settings are following the S30 schedule.  I have no apps connected but have noticed a widget on my iPhone.  I don’t know where it came from and will try to remove it.
Cheers

On Sep 1, 2022, at 6:48 AM, PeteRager @.***> wrote:
That is interesting. The integration does not send commands to the thermostat on its own, it only sends commands when requested to by an automation or from a Lovelace card. There are several possibilities:
There are automations configured that ran and changed something
The thermostat was adjusted by someone - from the panel, HA or mobile app
Something is broken
Does this situation reliably reoccur? Or was this a one off?
if it reproduces, then I’d suggest capturing a full debug log as that’ll show the messages going back and forth as well as the integration adding and removing holds.
Instructions are here.
https://github.com/PeteRager/lennoxs30#reporting-bugs https://github.com/PeteRager/lennoxs30#reporting-bugs
I’ll need both the home assistant log file and the message log file.
—
Reply to this email directly, view it on GitHub https://github.com/PeteRager/lennoxs30/issues/195#issuecomment-1234233505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOJDTO2QTRZXZ47ECQHME3V4CQ27ANCNFSM6AAAAAAQB6RPVQ.
You are receiving this because you authored the thread.

Ok, I'd go about capturing those debug logs then.
I do believe that the Fan setting is not part of the schedule.  When I first got my S30, i wanted to be able to schedule the fan to coming on as part of schedule and then go off on a different part of the schedule.  This was not possible, hence I started creating this integration so I could do that.
Anyways, getting the logs will be the next step.   You can post here or email to me.

Closing the stale issue, please reopen if needed


card.io won't present app crashes

The app crashes at this line
let cardIOViewController = CardIOPaymentViewController(paymentDelegate: self)
It's not recognizing paymentdelegate

Hi,
what is the crash report? Also, which branch are you working on?

So everything worked could we talk on the messenger so I can send you pictures

The crash report is

once I click on the credit card to take a picture, the app crashes

@DannyVancura what would be the fix

That is not the full crash report. Please include line 1-31 as well.

ok

how do i get the crash report

@DannyVancura is this it

what would be the fix

@DannyVancura could you please help me resolve the issue

Is this the unmodified example project from the Caishen repository that you are running? It seems that there is an issue with the project settings here. In fact, the error description even tells you what's wrong and how to solve it:
Terminating app due to uncaught exception 'CardIO-IncompleteIntegration', reason: 'Please add -ObjC to 'Other Linker Flags' in your project settings.

I removed -objc because i got this error after i ran pod install

@DannyVancura there were 2 duplicate symbols for architecture i386

what do you think might be the fix

can you help me

i did pod degenerate and did pod install and i came up with the same problem from yesterday

Cocoapods and CardIO related issue. Please refer to respective repositories for details.


fix: update dependencies

Closes #18, #24, #25

:tada: This PR is included in version 1.2.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Lazy-loading the SVG sprite

Do you want to request a feature, report a bug or ask a question?
Question
What is the current behavior?
SVG is bundled.
What is the expected behavior?
How would I go about lazy-loading the SVG sprite, rather than bundling it?
Thanks.

Which kind of sprite do you have? In JS or external?

I am loading the entire dir of SVGs this way:
const svgs = require.context('../../assets/svg/', true, /\.(svg)$/i)

Could you please create repo with minimal setup to demonstrate a problem (package.json, webpack config, SVG image and piece of your code). If you don't want to create a repository - you can create a gist with multiple files.


Introduce a StorageBytes type in the standard library

Description
The following allows for the storage of a collection of tightly packed bytes with the use of the Bytes type. This will provide significant space savings over a StorageVec<u8> and will also unblock StorageString in the Sway-libs repo.
Please note however that the bytes are still padded to the size of a quadword in storage. There will be at most 31 padded bytes for any StorageBytes type.
I've initially opted to omit adding functions such as push(). This is to encourage any byte manipulation to be done in the heap using the Bytes type and prevent successive storage read/writes calls in the same transaction.
Closes #3910
Checklist

[x] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

I opened this issue for further discussion: https://github.com/FuelLabs/sway/issues/4013


not working

it is not working after the new update

@TheRealJoelmatic do you have a solution? everybody has this problem

Fixed in 3.2


Protected CreatePrincipal Method for UserClaimsPrincipalFactory

Hello wonderful people,
I'd like to hook the creation of new ClaimsPrincipal(id) in UserClaimsPrincipalFactory:CreateAsync at this location and return my own MyAppClaimsPrincipal(id) implementation.
The following is what I'd like to change in UserClaimsPrincipalFactory.cs:
UserClaimsPrincipalFactory.cs
public class UserClaimsPrincipalFactory<TUser, TRole> : IUserClaimsPrincipalFactory<TUser>
    where TUser : class
    where TRole : class
{
        public virtual async Task<ClaimsPrincipal> CreateAsync(TUser user)
        {
            //... keep all microsoft's stuff
            return CreatePrincipal(id);
        }
        protected virtual ClaimsPrincipal CreatePrincipal(ClaimsIdentity id)
        {
            return new ClaimsPrincipal(id);
        }
}

Currently, in order to wrap the ClaimsIdentity from CreateAsync, I have to call the base.CreateAsync like this:
public class MyAppClaimsPrincipalFactory : UserClaimsPrincipalFactory<User, Role>
  public override async Task<ClaimsPrincipal> CreateAsync(User user)
  {
      var basePrincipal = await base.CreateAsync(user);
      var myAppPrincipal = new MyAppClaimsPrincipal(basePrincipal.Identities.First(), this.Options);
      return myAppPrincipal;
  }
}

It would be great if I could simply handle the ClaimsPrincipal creation itself by overriding CreatePrincipal(id) as I've proposed above. I could simply do this instead:
  protected override ClaimsPrincipal CreatePrincipal(ClaimsIdentity id)
  {
      return new MyAppClaimsPrincipal(id);
  }

Hm. Yea, it's a small nit-pick on the principal creation process but it does avoid a wasteful principal object allocation. I'd be happy to send a PR if you'd be okay with this small change. It's cool if not.
Thank you for your consideration, :v:
Brian
:thought_balloon: :mag: "I want to know... what you're thinking..."

Seems fine, feel free to submit a PR and we'll take a look

return my own MyAppClaimsPrincipal(id) implementation.

IIRC, according to @blowdart that's not supported.


I do not see this feature

Hello Team,
Please how can I get this feature in my tenant? We need need it urgently.
Is there any documentation as to the road ma?, so I can show my manager.
I look forward to your response

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f5920152-5fee-41ed-56df-ad7b51b25cc2
Version Independent ID: 88cfc850-5e36-48ee-ba99-088b2b653f1e
Content: Manage discovery of private teams in Microsoft Teams - Microsoft Teams
Content Source: Teams/manage-discovery-of-private-teams.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@ceejey01 thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


There may be a risk of transient data loss during initial startup

If the Connect Borker has not succeeded, Publish may result in data loss。

Sure, perhaps it could be inevitable.

@perfgao if you can try this branch:
https://github.com/Kong/lua-resty-events/pull/58
It should fix it.

With release 0.3.0, I consider this fixed. @perfgao, if further issues happen, let us know!


Portainer stack deploy takes 2, 3 minutes

Server: Dell EMC PowerEdge R640
OS: Ubuntu 16.04.5
Portainer version: 1.19.2
No registry created
+++++++++++++++++++++++++++
I created a Portainer stack with 16 services. It takes 2,3 minutes to deploy the stack every time after updating the stack content. All the images used in the stack have been pre-loaded to the server already, do not need to pull. The server does not have internet connected to it.
But it takes only a second when creating a stack from command line like below:
docker stack deploy test1 --compose-file docker-compose.yml
I wonder what extra jobs Portainer is doing comparing command line?

I'm not able to reproduce this behaviour when creating a stack with 16 different services (3*4 different images) : both Portainer and
Tested on latest develop branch, on a VM running as a swarm manager.
CREATING A STACK
Portainer with download: 32.65s

Portainer without download: 29.16s

cmd line without download: 30.29s

UPDATING A STACK
With Portainer: 30.53s

With cmd line: 31.36s

Portainer: 1.19.2
Docker 18.06.1-ce
No registry created inside Portainer
This may be related to Docker. Tested few more, found out this is happening to Docker stack deploy command as well.
My local network is setup as:
Server --> Linksys router --> internet
Below are the three scenarios I testes:

Server disconnects Ethernet cable to Linksys

it takes 1 sec to update stack

Server connects to Linksys with Ethernet cable, Linksys connects to internet

it takes 13 sec to update stack

Server connects to Linksys with Ethernet cable, but Linksys disconnect from internet

it takes forever >10 min

Why the internet access matters?

This may be related to Docker. Tested few more, found out this is happening to Docker stack deploy command as well.

Interesting, behind the scenes Portainer is using the CLI command docker stack deploy to deploy the stack. If this problem occurs with the CLI tool, it WILL happen with Portainer as we leverage the CLI for Swarm stack management.

Why the internet access matters? All images are pre-loaded locally.

We're just trying to figure out how to reproduce the problem, the more info we have the better.

Portainer: 1.19.2
Docker: 18.06.1-ce
No registry created inside Portainer instance
I have tried deploy/update stack with/without internet connection many times.

@wyang18 what kind of workload are you running, do they have to interact with internet?

No, we have no service need internet

@wyang18 can you try docker stack deploy --resolve-image=never to see if it makes things faster?

Can you try
As a test, do (using the CLI), docker stack deploy --resolve-image=never to see if the performance issue is resolved. If yes, then for sure your issue is because of Digest check.
From: Neil Cresswell
Sent: Wednesday, 7 November 2018 11:22 AM
To: 'portainer/portainer'<EMAIL_ADDRESS>portainer/portainer<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: RE: [portainer/portainer] Portainer stack deploy takes 2, 3 minutes (#2418)
OK… so here’s the thing…
When you create a service (or stack) in Docker, the image TAG is not used, instead DIGESTS (HASH) are used. Pre-pulling the image is not applicable when deploying services/stacks.
To do the digest validation, internet access is required, so too is access to the registry holding the image.
https://success.docker.com/article/images-tagging-vs-digests
So, it seems in your case, it’s the image digest check that is causing the extended delay… it doesn’t matter that the image is local, the digest (hash) check will still occur over the internet.
As a test, do (using the CLI), docker stack deploy --resolve-image=never to see if the performance issue is resolved. If yes, then for sure your issue is because of Digest check.
From: wyang18 <notifications<EMAIL_ADDRESS>Sent: Wednesday, 7 November 2018 11:05 AM
To: portainer/portainer <portainer<EMAIL_ADDRESS>Cc: Subscribed <subscribed<EMAIL_ADDRESS>Subject: Re: [portainer/portainer] Portainer stack deploy takes 2, 3 minutes (#2418)
Portainer: 1.19.2
Docker 18.06.1-ce
No registry created inside Portainer
This may be related to Docker. Tested few more, found out this is happening to Docker stack deploy command as well.
My local network is setup as:
Server --> Linksys router --> internet
Below are the three scenarios I testes:

Server disconnects Ethernet cable to Linksys

it takes 1 sec to update stack

Server connects to Linksys with Ethernet cable, Linksys connects to internet

it takes 13 sec to update stack

Server connects to Linksys with Ethernet cable, but Linksys disconnect from internet

it takes forever >10 min

Why the internet access matters? All images are pre-loaded locally.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_2418-23issuecomment-2D436425684&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=JsF5--UmldG6rWFsnpIqn5Aupfn4f_Ysw_Nda-hmonQ&s=II746olTcIXFKXmV5Q3lqSVVCOh3nwE4Gb5kuybHRAY&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlWEkiLMUZBvoQ6mn03kUAgxySjJRks5usgebgaJpZM4YB3w9&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=JsF5--UmldG6rWFsnpIqn5Aupfn4f_Ysw_Nda-hmonQ&s=qt2DLsPbpjJ2npKyd8AB1ZzKx2wPvFyLT-spMcqsRtE&e=.

Under following setting:

Server connects to Linksys with Ethernet cable, but Linksys disconnect from internet

Run command
docker stack deploy -c docker-compose.yml --resolve-image=never mystack
The service creating command was "completed" in less than a sec for all 18 services with the msg below:
"Creating service mystack_xxxxxx"

But as you can see from the image above, the "docker ps" command returns no new containers, and status shows "pending" in portainer.
If I wait long enough (about 20 min), the containers for all 18 services are created eventually.

The tasks are sitting pending, which means trying to pull down the image.
Can you try using a docker standard registry? Deploy the registry, push the images there, and try again.
Rgds,
Neil Cresswell
On 8/11/2018, at 5:43 AM, wyang18 <notifications<EMAIL_ADDRESS>wrote:
Under following setting:

Server connects to Linksys with Ethernet cable, but Linksys disconnect from internet

Run command
docker stack deploy -c docker-compose.yml --resolve-image=never mystack
The service creating command was "completed" in less than a sec for all 18 services with the msg below:
"Creating service mystack_xxxxxx"
[img_0814]https://urldefense.proofpoint.com/v2/url?u=https-3A__user-2Dimages.githubusercontent.com_44609269_48145527-2D9fd09500-2De278-2D11e8-2D91ef-2Dd5732c183dfc.JPG&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=jQ4_KuLtvdy_NbQOOKkrMnQrwEd3ugP4uJr6xIW_Fuw&s=MX71bH8OZgUrMZFuIbHnIDBim0zctE8shb7rPDUxhHM&e=
But as you can see from the image above, the "docker ps" command returns no new containers, and status shows "pending" in portainer.
If I wait long enough (about 20 min), the containers for all 18 services are created eventually.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_2418-23issuecomment-2D436690703&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=jQ4_KuLtvdy_NbQOOKkrMnQrwEd3ugP4uJr6xIW_Fuw&s=vwRwQmZh98Uv39174aaQiwxS1tqC-_HnZLLpRgAi3hk&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlRBDD4hNtNN44K94RsccK7JisOCkks5usw1UgaJpZM4YB3w9&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=jQ4_KuLtvdy_NbQOOKkrMnQrwEd3ugP4uJr6xIW_Fuw&s=X4zyQqrZwB_14FHwORD8MeppnAxtxohxlsWHpM_OsGg&e=.

A work around for this issue is to tag all images locally instead of using the full path like gcr.io/xxxx. It seems fixed the deployment issue as long as we continue to pre-load images to server.
Thanks everybody for all valuable suggestions.

@wyang18 ok, closing this one.


[PIP] set osx deploy target for v1.x wheels

Signed-off-by: Sheng Zha<EMAIL_ADDRESS>Description
set osx deploy target for v1.x wheels
Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

[x] set osx deploy target for v1.x wheels

Comments

This PR includes half of #19110 that hasn't been ported yet.

@mxnet-bot run ci [unix-gpu]


diamonds, fuel-economy: suppress "literal string will be frozen in the future" warning

Before change:
$ ruby test/run-test.rb -t '/DiamondsTest|FuelEconomyTest/' 2>&1 | grep red-datasets
/Users/zzz/src/github.com/red-data-tools/red-datasets/lib/datasets/ggplot2-dataset.rb:49: warning: literal string will be frozen in the future
(repeated 29 times)

After change:
$ ruby test/run-test.rb -t '/DiamondsTest|FuelEconomyTest/' 2>&1 | grep red-datasets

Thanks.

Thanks for your review!


rollup-plugin-babel does not use .babelrc

Using this:
plugins: [
  babel(), // version ^4.0.0-beta.7
],

I get the Support for the experimental syntax 'objectRestSpread' isn't currently enabled
I edited my .babelrc to include @babel/plugin-proposal-object-rest-spread:
{
  "presets": [["@babel/preset-env", { "modules": false }]],
  "plugins": ["@babel/plugin-proposal-object-rest-spread"]
}

But it doesn't change anything unless I include it directly in rollup-plugin-babel's config:
plugins: [
  babel({
    plugins: ['@babel/plugin-proposal-object-rest-spread'],
  }),
],

Why isn't rollup-plugin-babel reading my .babelrc? 😪

You'd have to share a repository with the issue reproduced, without it I won't be able to help you.

babel@7 wont use ur local .babelrc config to transpile files inside node_modules. You can rename ur config file to babel.config.js - it should work.


ReactiveCocoa 4.0 support

Fixes a minor issues with the final ReactiveCocoa 4.0 release, which uses Result.NoError instead of its own NoError type. I also updated the Podspec and changed the version to 0.9.0.

:+1:

NSTextField.swift also needs an import for Result.NoError

Sorry, forgot the Mac target. Should be fixed now.

Thanks!


generated wrong SQL when use where TableA.TableB.Field == 'abc'

when I code:
_context.Leaves.Where(l => l.Empl.Name=="ju")
the SQL generated:
SELECT [l].[Id], [l].[Date], [l].[DepartmentId], [l].[EmplId], [l].[Hours], [l].[LeaveType], [l.Empl].[Id], [l.Empl].[DepartmentId], [l.Empl].[FromDate], [l.Empl].[LeaveDate], [l.Empl].[Name], [l.Empl].[OperationId], [l.Empl].[Section], [l.Empl].[SkillLevel]
FROM [Leaves] AS [l]
LEFT JOIN [Empls] AS [l.Empl] ON [l].[EmplId] = [l.Empl].[Id]
ORDER BY [l].[EmplId]
why it select all the fields in table Empl? and can't find 'where'
is this a bug?

All fields are selected due to this issue: https://github.com/aspnet/EntityFramework/issues/6647
Where is not in the query due to issue https://github.com/aspnet/EntityFramework/issues/4588 (which has already been fixed and will be available in 1.1.0)


Add nre-ableton to JenkinsPipelineUnit

Description

Submitter checklist for changing permissions

Always

[ ] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] All newly added users have logged in to Artifactory at least once

Merge permission to GitHub repository

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo.

Sorry, I hit shift+enter instead of enter when editing the PR. I'll resubmit this PR later once I've finished reading the contributing guidelines etc.


Update download URLs to match the new format

Zoxide changed the release naming format with version 0.8.2 ref. The plugin couldn't download the new versions as it couldn't find them.
This PR just changes the zoxide-v${version} to zoxide-${version} (just removed three v's).

Hello, thanks for your PR.
I merged a previous one to support macos, to there is a small conflict. Could you update this?
Thanks a lot.

Sure. No problem.
Updated 👍👍


[mattermost] 9.5 release

Release isn't final yet. Planned release date is 16th Feb: https://github.com/mattermost/mattermost/issues/25937, so we can merge around that time.

Moving this to draft so it's easier to skip this PR when reviewing PRs.

Confirmed and merged as per https://docs.mattermost.com/deploy/mattermost-changelog.html


Don't count the locality with the precincts

If we don't restrict out join with AND precincts.simple_path = 'VipObject.Precinct.LocalityId', we'll  get one more than we should.
https://www.youtube.com/watch?v=1fbMQ5Z2lN4

LGTM 👡


[stable/logstash] Allow templating in elasticsearch host

Signed-off-by: James Lucas<EMAIL_ADDRESS>
Is this a new chart
No, it's a tweak to an existing chart.
What this PR does / why we need it:
The default value for the elasticsearch host in the logstash chart does not include the release name prefix and it doesn't appear to be possible to override it in a generic way without passing the .values.yaml value through tpl.
Which issue this PR fixes
None
Special notes for your reviewer:
@christian-roggia @rendhalver I would also like to increase the dependency version in the elastic-stack chart to include this, but I don't think I can do that until the new version has been deployed?
I also considered changing the default value within logstash/.values.yaml but decided against it as it only makes sense when used as a sub chart, so thought it better to do that in the parent chart's .values.yaml?
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md (added note to say value is passed through tpl)
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

@jamesalucas yes you will need to wait till this is merged and built before you can update the elastic-stack Chart.

Would it be possible to review this when you have a chance? Thanks!
/assign @rendhalver

/approve
/lgtm


Store EFMs as JSON

Unintuitive notice: These JSONs cannot be loaded in CNApy, just saved

Perhaps these should be gzipped by default as the files could get very large.


Change version selection

For ga4gh/dockstore#1553
Changing the previous selection algorithm to be easier to read.

If the URL specifies a specific Tag or WorkflowVersion, choose to display that one.  Otherwise,
If the default version is specified, choose to display the default version.  Otherwise,
Choose the first version in the array (the last updated version?)

Also change the test because the checker is a stub since it can't be refreshed (no such Git repo).  Therefore, it cannot have a master branch to go to (not sure why it went there in the first place).

FYI, pending a review request and/or build completion


[FLINK-9274][kafka] add thread name for partition discovery

What is the purpose of the change
For debugging, threads should have names to filter on and get a quick overview. The Kafka partition discovery thread(s) currently don't have any name assigned.
Brief change log

set "Kafka Partition Discovery for " as the partition discovery thread's name

Verifying this change
This change is a trivial rework / code cleanup without any test coverage. It was tested locally with a stacktrace of the end-to-end test.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Good fix, thanks!
Merging...


refactor(test): updated test helpers to be strongly typed

Description:
This allows tests to pick more on variation in type definitions when tests are being built
Related issue (if exists):

@kwonoj I've updated and fixed the merging issues, however I'm getting this error in travis:
Merge commit detected.
Merge commit detected.
Request failed [404]: https://api.github.com/repos/ReactiveX/rxjs/statuses/369be8144cc597c26ee5808452a2178471fa7ead
Response: {
  "message": "Not Found",
  "documentation_url": "https://developer.github.com/v3/repos/statuses/#create-a-status"
}
Failing the build, there is 1 fail.

Coverage remained the same at 97.502% when pulling e1d4411b72ea25a2d5a905ba10cef9e63130477a on david-driscoll:typed-tests into 92dd3d135d3fcf7fa98526a2ba0493754407a94a on ReactiveX:master.

I figured it out! 🎉
This should be good to go now.


T5 Encoder in unet training

I'm not very knowledgeable about this, but is it necessary to load the T5 encoder if I plan to train only the U-Net? Is it possible to skip loading the encoder?

It is necessary to initially load it and do the caption/classtoken (trigger word) encoding, with disk caching enabled it is then unloaded and never loaded again during the training process.


Clear metadata on print start with prints without metadata

When starting a print witrhout preview and metadata after a normal print, data from the previous print will be used, which is suboptimal.

Can not confirm, closing


RuntimeWarning & ValueError when using endaq.plot.octave_spectrogram()

The Webinar I'm referring to: link
I can't attach the Jupyter Lab script nor the csv file, however the csv file is available here
I'm using a Jupyter Lab script with Python 3.9.11 (installed with asdf)
I measured vibration and I now want to analyze the data using the endaq python library. Unfortunately, I can't use the endaq.plot.octave_spectrogram() method. When I realized that (until now) only this method is not working I downloaded the file from the introduction Webinar for the library and copied the code as well. Even then, with the exact same code and data I get these Errors. I tried other methods which are mentioned previously in the Webinar and they work fine. Below is a minimum working example with the mentioned csv file and the endaq.plot.plots.rolling_min_max_envelope() method. I also added endaq.plot.octave_spectrogram() which is not working for me.
I also tested this on my private Windows PC with the same Python Version which was not installed with asdf. Same result. Every mehtod I tested works except endaq.plot.octave_spectrogram().
Yes, the csv file is in the same folder, I also tested it with only using the link like in the Webinar... no difference.
Minimum example:
# working part
import endaq

import plotly.express as px
import plotly.graph_objects as go
import pandas as pd
import numpy as np
import scipy

df_vibe = pd.read_csv('motorcycle-vibration-moving-frequency.csv',index_col=0)
df_vibe = df_vibe - df_vibe.median()
df_vibe

accel_time_labels = dict(
    xaxis_title_text='',
    yaxis_title_text='Acceleration (g)',
    legend_title_text=''
)

fig = endaq.plot.plots.rolling_min_max_envelope(
    df_vibe,
    desired_num_points=1000,
    plot_as_bars=True,
    opacity=1.0
    )
fig.update_layout(
    accel_time_labels,
    title_text='Engine Reving of Motorcycle',
)
fig.show()

# not working part
freqs, bins, Pxx, fig = endaq.plot.octave_spectrogram(df_vibe[['Z (40g)']],
                                                      window=0.5,
                                                      bins_per_octave=12,
                                                      max_freq=1000,
                                                      freq_start=40)
fig.show()

Error Message:
`/home/marcel/.asdf/installs/python/3.9.11/lib/python3.9/site-packages/endaq/calc/psd.py:169: RuntimeWarning:
empty frequency bins in re-binned PSD; original PSD's frequency spacing is too coarse

ValueError                                Traceback (most recent call last)
Input In [7], in <cell line: 1>()
----> 1 freqs, bins, Pxx, fig = endaq.plot.octave_spectrogram(df_vibe[['Z (40g)']],
2                                                       window=0.5,
3                                                       bins_per_octave=12,
4                                                       max_freq=1000,
5                                                       freq_start=40)
6 fig.show()
ValueError: not enough values to unpack (expected 4, got 2)`

Hey @MarcelEckh, first off thank you for officially being the first non-enDAQ person to post an issue here! It's a first but not a last and although I don't want to diminish the frustration you are undoubtedly feeling, I'm excited that this is the beginning of accelerated adoption of our library! Sorry it has taken us so long to see this, I'll change my settings in GitHub to get notified every time an issue is posted! I'm also going to at my fellow contributors: @StokesMIDE @CFlaniganMide @pscheidler
I'm not a big fan of the implementation of this function, I had posted a related issue actually: #35. More on that next after I help fix the immediate issue.
The runtime errors are more messages than errors to let you know that the PSD is too coarse for the given time range. They are admittedly annoying but they can be ignored as they are "just" warnings. The software team won't like this too much but you can explicitly turn them off via (found on stackoverflow):
import warnings
warnings.filterwarnings("ignore")

The actual error you have is that the function was updated to only return two parameters not 4 so you need to change the line:
freqs, bins, Pxx, fig = endaq.plot.octave_spectrogram(df_vibe[['Z (40g)']]
to
df, fig = endaq.plot.octave_spectrogram(df_vibe[['Z (40g)']]
I showed an example of it running correctly in this colab (here's the link).
Now to how we can improve this function! I had a few issues with the current implementation:

The returned data isn't actually in real engineering units that you can relate to anything else
There is no ability to customize your display, see options below (all in that colab)

I really don't like that this function does a lot of calculations in the plotting module, I'd rather have rolling_psd, rolling_fft, rolling_srs functions in endaq.calc and then a single plot.3d_spectrum function that allows the users to pass the output from one of the calc functions to it. I'll clean some of this code up in the colab and do a pull request tomorrow and at you to be aware we are acting on your feedback! Speaking of, please let me know if you like or dislike what I'm proposing!

@MarcelEckh I wanted to give you an update that I'm getting somewhere with some new functions but won't finish tonight, here's the work in progress if you want to check it out! What I have left to do is:

[ ] Add a rolling_shock_spectrum function and test
[ ] Add some simple examples into the docstrings (lots of examples are in the colab already though!)
[ ] Build a new branch, test, and submit a pull request!

Hi @shanlyMIDE, I feel honored by your reply and it's absolutely great to get such good help so quickly! Thank you very much for that!
The colab you created also helps a ton and I was able to correct my code and now it works. To be honest, I completely missed the changes that were being done to this function.
Regarding your proposals: I really like them and I'd especially appreciate having the returned data in actual units.

Alright it's been submitted! We'll let you know when we have something fully merged into development, but you can download and test this specific branch

Awesome! I look forward to it.

closing this now because it is in development! https://github.com/MideTechnology/endaq-python/pull/191
Here is the specific major function (that links to a lot of the other new ones): https://docs.endaq.com/en/development/endaq/plot.html#endaq.plot.spectrum_over_time
You can download this branch via:
pip install git+https://github.com/MideTechnology/endaq-python.git@development


Add integration test to get the number of repositories created per year

Do you mean the number of repositories per year of the first commit, right? If it's that, this is currently blocked by not having the parents in the commit row.
Query would be something like:
SELECT COUNT(*), YEAR(commit_date)
FROM (
  SELECT *
  FROM commits
  WHERE parent_commits(hash) = 0
  ORDER BY commit_date
  LIMIT 1
) commits
GROUP BY commit_date

As you can see, we need a way of telling if a commit has no parents.
We could do with just returning the first commit according to the date, but might not be accurate:
SELECT COUNT(*), YEAR(commit_date)
FROM (
  SELECT *
  FROM commits
  ORDER BY commit_date
  LIMIT 1
) commits
GROUP BY commit_date

Would that be enough?


Polybar example error

I have succesfully compile and installed polybar ,after that i execute make userconfig with sudo , run fine.
But after that i try to launch with polybar example but it will not launch.
OS- Fedora29
output-
~
• • • git clone --branch 3.2 --recursive https://github.com/jaagr/polybar
Cloning into 'polybar'...
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 12900 (delta 0), reused 0 (delta 0), pack-reused 12896
Receiving objects: 100% (12900/12900), 6.96 MiB | 676.00 KiB/s, done.
Resolving deltas: 100% (9585/9585), done.
Submodule 'lib/i3ipcpp' (https://github.com/jaagr/i3ipcpp) registered for path 'lib/i3ipcpp'
Submodule 'lib/xpp' (https://github.com/jaagr/xpp) registered for path 'lib/xpp'
Cloning into '/home/azrulFTW/polybar/lib/i3ipcpp'...
remote: Enumerating objects: 762, done.
remote: Total 762 (delta 0), reused 0 (delta 0), pack-reused 762
Receiving objects: 100% (762/762), 299.49 KiB | 156.00 KiB/s, done.
Resolving deltas: 100% (243/243), done.
Cloning into '/home/azrulFTW/polybar/lib/xpp'...
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 2597 (delta 0), reused 2 (delta 0), pack-reused 2591
Receiving objects: 100% (2597/2597), 447.60 KiB | 194.00 KiB/s, done.
Resolving deltas: 100% (1805/1805), done.
Submodule path 'lib/i3ipcpp': checked out 'd4e4786be35b48d72dc7e59cf85ec34a90d129b5'
Submodule path 'lib/xpp': checked out '00165e1a6d5dd61bc153e1352b21ec07fc81245d'

~
• • • mkdir polybar/build                   ⌚ 18:49 |azrulFTW @ localhost|

~
• • • cd polybar/build                      ⌚ 18:49 |azrulFTW @ localhost|

                                   --   --   (3.2  origin)  ⌫ 3.2.1
~/polybar/build
• • • cmake ..                              ⌚ 18:49 |azrulFTW @ localhost|
-- Trying to enable ccache
-- Using compiler cache /usr/bin/ccache
-- The C compiler identification is GNU 8.2.1
-- The CXX compiler identification is GNU 8.2.1
-- Check for working C compiler: /usr/lib64/ccache/cc
-- Check for working C compiler: /usr/lib64/ccache/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/lib64/ccache/c++
-- Check for working CXX compiler: /usr/lib64/ccache/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- No build type specified; using RelWithDebInfo
-- Using supported compiler GNU-8.2.1
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.5.3")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Checking for module 'cairo-fc'
--   Found cairo-fc, version 1.16.0
-- Checking for module 'alsa'
--   Found alsa, version 1.1.7
-- Checking for module 'libpulse'
--   Found libpulse, version 12.2-rebootstrapped
-- Checking for module 'xcb-xkb'
--   Found xcb-xkb, version 1.13.1
-- Checking for module 'xcb-randr'
--   Found xcb-randr, version 1.13.1
-- Checking for module 'xcb-randr>=1.12'
--   Found xcb-randr, version 1.13.1
--  Build:
--    Type: RelWithDebInfo
--    CC: /usr/lib64/ccache/cc  -O2 -g -DNDEBUG
--    CXX: /usr/lib64/ccache/c++  -Wall -Wextra -Werror -Wno-noexcept-type -O2 -pedantic -pedantic-errors -O2 -g -DNDEBUG
--    LD: /usr/bin/ld
--  Targets:
-- [X]   polybar-msg
-- [ ]   testsuite
--  Module support:
-- [X]   alsa (1.1.7)
-- [ ]   curl
-- [X]   i3
-- [ ]   mpd
-- [ ]   network
-- [X]   pulseaudio (12.2-rebootstrapped)
-- [X]   xkeyboard (1.13.1)
--  X extensions:
-- [X]   xcb-randr (1.13.1)
-- [X]   xcb-randr (monitor support) (1.13.1)
-- [ ]   xcb-render
-- [ ]   xcb-damage
-- [ ]   xcb-sync
-- [ ]   xcb-composite
-- [X]   xcb-xkb (1.13.1)
-- [ ]   xcb-xrm
-- [ ]   xcb-cursor
--  Log options:
-- [X]   Trace logging
-- Font not found: fixed:pixelsize=10
-- Font not found: unifont:fontformat=truetype
-- Font not found: siji:pixelsize=10
-- Checking for module 'xcb-proto'
--   Found xcb-proto, version 1.13
-- Found PythonInterp: /usr/bin/python2.7 (found suitable version "2.7.15", minimum required is "2.7")
-- XCB[XCB]: Found component XCB
-- Found XCB_XCB: /usr/lib64/libxcb.so
-- XCB[ICCCM]: Found component ICCCM
-- Found XCB_ICCCM: /usr/lib64/libxcb-icccm.so
-- XCB[EWMH]: Found component EWMH
-- Found XCB_EWMH: /usr/lib64/libxcb-ewmh.so
-- XCB[UTIL]: Found component UTIL
-- Found XCB_UTIL: /usr/lib64/libxcb-util.so
-- XCB[IMAGE]: Found component IMAGE
-- Found XCB_IMAGE: /usr/lib64/libxcb-image.so
-- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-icccm.so;/usr/lib64/libxcb-ewmh.so;/usr/lib64/libxcb-util.so;/usr/lib64/libxcb-image.so
-- Searching for xcbgen with python2
-- Searching for xcbgen with python2.7
-- Searching for xcbgen with python3
-- Found xcbgen in /usr/lib/python3.7/site-packages
-- XCB[RANDR]: Found component RANDR
-- Found XCB_RANDR: /usr/lib64/libxcb-randr.so
-- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-icccm.so;/usr/lib64/libxcb-ewmh.so;/usr/lib64/libxcb-util.so;/usr/lib64/libxcb-image.so;/usr/lib64/libxcb-randr.so
-- XCB[XKB]: Found component XKB
-- Found XCB_XKB: /usr/lib64/libxcb-xkb.so
-- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-icccm.so;/usr/lib64/libxcb-ewmh.so;/usr/lib64/libxcb-util.so;/usr/lib64/libxcb-image.so;/usr/lib64/libxcb-randr.so;/usr/lib64/libxcb-xkb.so
-- xpp: including xcb proto randr.xml
-- xpp: including xcb proto xkb.xml
-- xpp: including xcb proto xproto.xml
-- Checking for module 'jsoncpp>=1.7.7'
--   Package 'jsoncpp', required by 'virtual:world', not found
-- Could not find jsoncpp>=1.7.7 -- building static lib...

-- Install configuration: "RelWithDebInfo"
-- Installing: /usr/local/share/doc/polybar/config
-- Installing: /usr/local/share/bash-completion/completions/polybar
-- Installing: /usr/local/share/zsh/site-functions/_polybar
-- Installing: /usr/local/share/zsh/site-functions/_polybar_msg
-- Installing: /usr/local/share/man/man1/polybar.1
-- Installing: /usr/local/bin/polybar
-- Installing: /usr/local/bin/polybar-msg

                                   --   --   (3.2  origin)  ⌫ 3.2.1
~/polybar/build
• • • make userconfig                                                                                ⌚ 18:57 |azrulFTW @ localhost|
[  4%] Built target jsoncpp_lib_static
[  9%] Built target xpp
[ 13%] Built target i3ipc++
[100%] Built target polybar
Scanning dependencies of target userconfig
-- Installing: /home/azrulFTW/.config/polybar/config
CMake Error at cmake/userconfig.cmake:7 (file):
  file INSTALL cannot copy file "/home/azrulFTW/polybar/doc/config" to
  "/home/azrulFTW/.config/polybar/config".

make[3]: *** [CMakeFiles/userconfig.dir/build.make:57: CMakeFiles/userconfig] Error 1
make[2]: *** [CMakeFiles/Makefile2:137: CMakeFiles/userconfig.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:144: CMakeFiles/userconfig.dir/rule] Error 2
make: *** [Makefile:190: userconfig] Error 2

                                   --   --   (3.2  origin)  ⌫ 3.2.1
~/polybar/build
• • • polybar example                                                                                ⌚ 18:58 |azrulFTW @ localhost|
error: Undefined bar: example

                                   --   --   (3.2  origin)  ⌫ 3.2.1
~/polybar/build
• • • polybar example                                                                                ⌚ 18:59 |azrulFTW @ localhost|
error: Undefined bar: example

                                   --   --   (3.2  origin)  ⌫ 3.2.1
~/polybar/build
• • • sudo make userconfig                                                                                ⌚ 19:01 |azrulFTW @ localhost|
[sudo] password for azrulFTW:
[  4%] Built target jsoncpp_lib_static
[  9%] Built target xpp
[ 13%] Built target i3ipc++
[100%] Built target polybar
-- Installing: /root/.config/polybar/config
[100%] Built target userconfig

                                   --   --   (3.2  origin)  ⌫ 3.2.1
~/polybar/build
• • • polybar example                                                                                ⌚ 19:05 |azrulFTW @ localhost|
error: Undefined bar: example

You already have a config file at ~/.config/polybar/config that's why make userconfig can't install the config file. The config file at ~/.config/polybar/config seems to not contain a bar definition for example though.

sorry there,ive unintalled and erased the old configuration, everything work now.Thanks


Update devenv-httpclient.md

Corrected a small Typo, headers > ContentHeaders

Thanks for your contribution, much appreciated


Add core and nlu additional params to training endpoint

Proposed changes:

Implementation of https://github.com/RasaHQ/rasa/issues/4596
Fix the type casting issue for some bool parameters in the server

Status (please check what you already did):

[x] added some tests for the functionality
[x] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@wochinge please review this, I'll update the changelog later

Thanks for submitting a pull request 🚀 @amn41 will take a look at it as soon as possible ✨

Cool, thanks @wochinge, it's my pleasure to have contributions to this project


libfuse: don't try to get quota when disconnected

Make Linux/macOS work the same way as Windows.  I saw someone complain
about this on Twitter:
https://twitter.com/bytebot/status/865182626977640449

It seems the ExtraFilename from libfs.RemoteStatus is used to indicate user's not logged in or "human error"? How is it used?

It also indicates when the client is disconnected from the mdserver, which is the main thing this PR is targeting.
(I think the "Human" prefix in the const names just indicates that it is a file explaining the error in a way that's readable by humans.)

OK thanks!


#135 Fix Compiler error after upgrading to Flutter 3.0

closes #135

Thanks!

Can this be pushed to pub.dev as a new version? Thanks!

cc @jnschulze

Can this be pushed to pub.dev as a new version? Thanks!

Yes, I’m going to publish a new version today.

This is not correct, we can not remove the null check as the WidgetsBinding is potentially null. Please get the instance with '?', see #157, thanks.


v2.2.3

This issue is to increment version in documentation and installation files in preparation for release.
Before merge to master :

[x] Increment version in changelog and citation files
[x] Update year to 2024
[x] Update Python versions in tests (3.7 has reached end-of-life and 3.12 is released)

Before merge to maintenance/2.2.x :

[x] Increment version in documentation
[x] Increment version in configuration/project files

After merge to maintenance/2.2.x :

[ ] Create release tag
[ ] Upload pdf documentation
[ ] Update default version page on readthedocs
[ ] Upload to Pypi (This should now be done automatically)

The documentation for #296 is temporarily hidden here.


Feature: Add performance infra [Do not merge]

Testing

/ok-to-test-perf sha=c887404

/ok-to-perf-test  sha=e98893c


Error log name different from the actual

https://github.com/groupon-testium/webdriver-http-sync/blob/master/lib/session.js#L12
Hi, I use testium.
webdriver-http-sync said error below when run testium with 'phantomjs'.
Uncaught Error: Assertion failed: Failed to start Selenium session. Check the selenium.log.

But as it is, testium output log name as 'phantomjs.log'. This is not actual.
It'll be potentially confusing.
Thanks.

Thanks for the bug report! We'll look into fixing this.


Compilation failing with libxml-related errors (with libxml 2.12.0 - 2.12.2)

Description
Hi there,
I have been trying my hand at maintaining an Arch User Repository package for modsecurity: https://aur.archlinux.org/packages/modsecurity. For a short while now, compilation of modsecurity 3 is failing on Arch with the following:
mv -f audit_log/writer/.deps/libmodsecurity_la-parallel.Tpo audit_log/writer/.deps/libmodsecurity_la-parallel.Plo
/bin/sh ../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I.  -std=c++11 -I.. -g -I../others -fPIC -O3 -I../headers -DWITH_CURL_SSLVERSION_TLSv1_2 -DWITH_CURL     -DWITH_YAJL -I/usr/include/yajl  -DPCRE_HAVE_JIT -I/usr/include  -DWITH_MAXMIND  -DWITH_LUA -DWITH_LUA_5_4 -I/usr/include -I/usr/include/libxml2 -DWITH_LIBXML2   -g -O2 -MT libmodsecurity_la-modsecurity.lo -MD -MP -MF .deps/libmodsecurity_la-modsecurity.Tpo -c -o libmodsecurity_la-modsecurity.lo `test -f 'modsecurity.cc' || echo './'`modsecurity.cc
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -std=c++11 -I.. -g -I../others -fPIC -O3 -I../headers -DWITH_CURL_SSLVERSION_TLSv1_2 -DWITH_CURL -DWITH_YAJL -I/usr/include/yajl -DPCRE_HAVE_JIT -I/usr/include -DWITH_MAXMIND -DWITH_LUA -DWITH_LUA_5_4 -I/usr/include -I/usr/include/libxml2 -DWITH_LIBXML2 -g -O2 -MT libmodsecurity_la-modsecurity.lo -MD -MP -MF .deps/libmodsecurity_la-modsecurity.Tpo -c modsecurity.cc  -fPIC -DPIC -o .libs/libmodsecurity_la-modsecurity.o
modsecurity.cc: In constructor ‘modsecurity::ModSecurity::ModSecurity()’:
modsecurity.cc:89:5: error: ‘xmlInitParser’ was not declared in this scope
   89 |     xmlInitParser();
      |     ^~~~~~~~~~~~~
modsecurity.cc: In destructor ‘modsecurity::ModSecurity::~ModSecurity()’:
modsecurity.cc:102:5: error: ‘xmlCleanupParser’ was not declared in this scope
  102 |     xmlCleanupParser();
      |     ^~~~~~~~~~~~~~~~
make[3]: *** [Makefile:2168: libmodsecurity_la-modsecurity.lo] Error 1
make[3]: Leaving directory '/home/mark/Software/AUR_PACKAGES/modsecurity/src/build/src'
make[2]: *** [Makefile:3505: all-recursive] Error 1
make[2]: Leaving directory '/home/mark/Software/AUR_PACKAGES/modsecurity/src/build/src'
make[1]: *** [Makefile:1239: all] Error 2
make[1]: Leaving directory '/home/mark/Software/AUR_PACKAGES/modsecurity/src/build/src'
make: *** [Makefile:1049: all-recursive] Error 1

Logs and dumps
N/A
To Reproduce
git clone "https://github.com/SpiderLabs/ModSecurity/"
cd ModSecurity
git submodule init
git submodule update
./build.sh
./configure --prefix=/usr
make

Expected behavior
Successful build.
Server (please complete the following information):

OS (and distro): [e.g. Linux, archlinux]

# uname -a
Linux t480 6.6.3-arch1-1 #1 SMP PREEMPT_DYNAMIC Wed, 29 Nov 2023 00:37:40 +0000 x86_64 GNU/Linux

Rule Set (please complete the following information):
N/A
Additional context
Maybe the version of libxml2 is relevant?
$ pacman -Qi libxml2
Name            : libxml2
Version         : 2.12.1-1
[clip]
Provides        : libxml2.so=2-64

I see there are reports on the libxml2 tracker of 2.11.0 breaking things: https://gitlab.gnome.org/GNOME/libxml2/-/issues/526. For info, the progression of changes to libxml2 on Arch can be found here: https://gitlab.archlinux.org/archlinux/packaging/packages/libxml2/-/commits/main
I'd be grateful for any help debugging this further, or for anybody's time looking into this.
Best,
Mark.

building libmodsecurity on Fedora v39 & rawhide @ COPR,
https://copr.fedorainfracloud.org/coprs/pgfed/nginx-mainline/build/6726088/
the rawhide build, with libxml2 v2.12x fails similarly as above
the F39 build, with libxml2 v2.10.x succeeds
the detailed rawhide build's log is here,
https://download.copr.fedorainfracloud.org/results/pgfed/nginx-mainline/fedora-rawhide-x86_64/06726088-libmodsecurity/builder-live.log.gz

Thanks for noting this.
It looks like the maintainers of that project have made a patch very recently: https://gitlab.gnome.org/GNOME/libxml2/-/issues/642
ModSecurity is asserted to be one of the projects that now build correctly (  https://gitlab.gnome.org/GNOME/libxml2/-/issues/642#note_1936430  )
It seems likely that we (the ModSecurity project) won't need to do anything about this issue.

@martinhsv

It seems likely that we (the ModSecurity project) won't need to do anything about this issue.

here's a still FAILed build of libmodsecurity, with libxml2.12.2:
https://download.copr.fedorainfracloud.org/results/pgfed/nginx-mainline/fedora-39-x86_64/06735554-libmodsecurity/builder-live.log.gz
i don't yet know if this is an issue of libmodsecurity vs modsecurity build, or whether the 'downstream' fix mentioned here:
https://gitlab.gnome.org/GNOME/libxml2/-/issues/642#note_1937004
needs be applied

this additional patch -- for missing headers --
https://gitlab.archlinux.org/archlinux/packaging/packages/libmodsecurity/-/blob/main/libxml-includes.patch?ref_type=heads
appears to do the trick.

The build works again with libxml 2.12.x if using >= 2.12.3. See related PR (#3205) for some additional detail.
Closing.


Problems compiling Flutter Project Could not find lint-gradle-api.jar (com.android.tools.lint:lint-gradle-api:26.1.2).

Hi, I am new to flutter and was working with it fine until an upgrade yesterday.
Now I can not compile anymore because Flutter has probplems using Gradle. I do not get the problem :/ can anybody please give me a clue??
Error Message:
* Error running Gradle:
ProcessException: Process "C:\Users\peter\AndroidStudioProjects\flutter_app\android\gradlew.bat" exited abnormally:
Project evaluation failed including an error in afterEvaluate {}. Run with --stacktrace for details of the afterEvaluate {} error.

FAILURE: Build failed with an exception.

* Where:
Build file 'C:\Users\peter\AndroidStudioProjects\flutter_app\android\app\build.gradle' line: 26

* What went wrong:
A problem occurred evaluating project ':app'.
> Could not resolve all files for configuration 'classpath'.
   > Could not find lint-gradle-api.jar (com.android.tools.lint:lint-gradle-api:26.1.2).
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/lint/lint-gradle-api/26.1.2/lint-gradle-api-26.1.2.jar

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s
  Command: C:\Users\peter\AndroidStudioProjects\flutter_app\android\gradlew.bat app:properties

Finished with error: Please review your Gradle project setup in the android/ folder.

Steps to Reproduce

Update --> Fail
Reinstalling and creating a new Flutter project allways throws the same error
...

Logs
idea.log

<!-- If possible, paste the output of running `flutter doctor -v` here. -->
C:\Users\peter\AndroidStudioProjects\flutter_app>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel dev, v0.10.0, on Microsoft Windows [Version 10.0.17134.345], locale de-DE)
[!] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[√] Android Studio (version 3.2)
[√] VS Code, 64-bit edition (version 1.25.1)
[√] Connected device (1 available)

! Doctor found issues in 1 category.

Merging with #23404

I get this probplem too, how to fix it

Go to path where Flutter SDK is installed my Flutter SDK path                                                                   i.e : C:\Flutter SDK\flutter\packages\flutter_tools\gradle

Edit the flutter.gradle file by moving
maven {
url 'https://dl.google.com/dl/android/maven2'
}
in the top of jcenter()

i.e. flutter.gradle file buildscript section will look like this
buildscript {
repositories {
maven {
url 'https://dl.google.com/dl/android/maven2'
}
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.1.2'
}

OR follow this link :
https://stackoverflow.com/questions/52945041/couldnt-locate-lint-gradle-api-26-1-2-jar-for-flutter-project

Or you can upgrade gradle in android with below steps:

Edit android/gradle/wrapper/gradle-wrapper.properties and upgrade:
distributionUrl=https://services.gradle.org/distributions/gradle-4.4-all.zip
Edit android/build.gradle:
classpath 'com.android.tools.build:gradle:3.1.2'

distributionUrl=https://services.gradle.org/distributions/gradle-4.4-all.zip

You saved my day. Thanks a lot!

this good also save someone else's day:
distributionUrl=https://services.gradle.org/distributions/gradle-4.6-all.zip


Incorrect function args when yield used in argument list

def argsof(**args)
  pp args
end

def yield_args(&)
  argsof(
    "foo": yield "foo",
    "bar": yield "bar",
  )
end

def yield_args2(&)
  argsof(
    "foo": yield("foo"),
    "bar": yield("bar"),
  )
end

yield_args { |x| x }
yield_args2 { |x| x }

gives output
{foo: "foo"}
{foo: "foo", bar: "bar"}

This should generate the same result for both calls, the second function argument cannot be lost.

Oh dear, I think this parses as argsof(foo: yield("foo", bar: yield("bar"))). I think perhaps this could be made a syntax error?

Wouldn't that potentially break existing code? It seems yield without parentheses is a lot more common...

The behaviour is identical when calling a method instead of yield:
def argsof(**args)
  pp args
end

def yield_args(&)
  argsof(
    "foo": vield "foo",
    "bar": vield "bar",
  )
end

def yield_args2(&)
  argsof(
    "foo": vield("foo"),
    "bar": vield("bar"),
  )
end

def vield(arg, **args)
  arg
end

yield_args { |x| x }  # => {foo: "foo"}
yield_args2 { |x| x } # => {foo: "foo", bar: "bar"}

So while this looks certainly deceitful, it's syntactically sound and I don't think we can really change much about it without causing a major disruption.
Perhaps the formatter could help clarify the situation (for example by adding parentheses in ambiguous cases like this one).
However, the formatter actually fails on this code: expecting ), not DELIMITER_START, , at :8:5.


request: functions similar to Matrix.AddVectorToAllRows(Vector)

I came across problem where i had to to add vector to all rows of matrix (inplace update).
I have solved it by for loop -> Matrix.Row() -> Vector.Add() -> Matrix.SetRow() to avoid allocations of new copy for each vector. But i really don't like this solution, its actually more code than simple for loop over float[] storages of dense matrix and vector (my previous solution to this). for(int i=0;i<=matstorage.Length;i++) {matstorage[i]+vecstorage[i/vecstorage.Length] }
I really would like to see new methods on matrices to do basic mathematical functions on selected rows, all rows, selected columns and all columns.
something like:
Matrix.RowAdd(vector other, matrix result) //add to all
Matrix.RowAdd(int rowindex, vector other, matrix result)//add to one
Matrix.RowAdd(int rowindexFrom, int rowCount, vector other, matrix result)//add to some
for rows and columns and for pointwise operations

Dear Christoph, is the MapRowVectorsInplace function still under consideration, since it would help me a lot as well, and the functions make sense as addition to the other map-functions?
Thank you for making the library,
Arthur


Rename ws to api to not be confused with websockets

I find it SUPER confusing that we have both ws and websockets, but ws really means API except when it actually means websockets.

Opened a related PR (https://github.com/ManageIQ/manageiq-pods/pull/221) that we will need for the pods repo.

I would merge if I had permission...

ping @Fryguy @bdunne, this been approved for a while. can I go ahead and merge ?

ping @bdunne @carbonin this was merged, the counterpart
https://github.com/ManageIQ/manageiq-pods/pull/221
needs some TLC.