[CSUB-1060] Rename creditcoin3 CLI to just creditcoin

Description of proposed changes

Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

@pLabarta note: I've rebased; squashed your commits and added changes to satisfy the rest of the failing CI jobs.


installing gafferpy

I have tried on a number of times to build the gafferpy tools on a windows device. I have replaced the <gaffer.version> from the instructions with the following:
gaffer.1.12.0
gaffer.1
1.12.0
and all iterations on the below code output the same error that the file cannot be located.
pip3 install gafferpy-<gaffer.version>-py2.py3-none-any.whl
Error example:
pip install setup.py gafferpy-gaffer.1.12.0-py2.py3-none-any.whl
WARNING: Requirement 'gafferpy-gaffer-py2.py3-none-any.whl' looks like a filename, but the file does not exist
Collecting setup.py
  ERROR: Could not find a version that satisfies the requirement setup.py (from versions: none)
ERROR: No matching distribution found for setup.py

Intention is to get my local python web application to use the python shell to connect to the gaffer server running in Docker.
I obtained the gaffer version from the running API page:

closing


Set tlBaseVersion to release 0.1.0

Is there anything else that we need to do now other than push a tag @armanbilge?


Q: will (sadly forced) migration from twistor/flysystem-guzzle require me to depend on the whole AWS SDK?

I am forced to migrate away from an S3-over-twistor/flysystem-guzzle setup. One big advantage of that setup was that it just used a regular HTTP client to communicate with S3, and didn't require me to bring THE SHEER VASTNESS OF ALL THE DOZENS OF MEGABYTES OF THE ENTIRETY OF THE AWS SDK into my application.
Must that advantage definitely be lost if I migrate to flysystem-aws-s3-v3?

You can always choose to maintain your own guzzle-only adapter.

What is the answer to the yes/no question I posed?

Word of advice, you need to work on your social skills. Issues with bold full caps stuff, pushing towards yes/no answers. You're pretty close to getting closed and blocked from raising new issues.
You can use league/flysystem-aws-s3-v3 which depends on the SDK, or you can use the async version which uses async-aws-sdk which doesn't depend on the SDK. For docs, see: https://flysystem.thephpleague.com/docs/adapter/async-aws-s3/


Add resources for Russian language

@RocketChat/android
Add resources for Russian language (app & widget):

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM! Thank you @Sveer!


refactoring on path towards symbolic execution

probably smoother to leave the existing transforms in place and work on a secondary symbolic approach side by side. or you'll have to constantly merge update we make to the current approach.


[In-App-Purchase][iOS] Purchase Stream Not Triggering for Purchased Status in TestFlight on iOS on Subscription

Steps to reproduce

Set up a listener for the purchase stream:InAppPurchase.instance.purchaseStream.listen(_listenToPurchaseUpdated);

Deploy the app to TestFlight on iOS.
Purchase a subscription in the app.
Observe the following:

The purchase stream is triggered correctly for the Pending state.

Complete the subscription purchase.
Check if the purchase stream is triggered for the Purchased status.

Notes:

The issue occurs only for subscriptions, not regular in-app purchases.
This behavior is observed only in TestFlight; it works correctly during development.

Expected results
The purchase stream (InAppPurchase.instance.purchaseStream) should be triggered with the Purchased status after completing a subscription purchase.
Actual results
The purchase stream (InAppPurchase.instance.purchaseStream) is not triggered with the Purchased status after completing a subscription purchase.
However, it works correctly for consumable purchases.
Code sample
Code sample
import 'dart:async';
import 'dart:developer';

import 'package:in_app_purchase/in_app_purchase.dart';

class InAppPurchaseService {
  late StreamSubscription<List<PurchaseDetails>> _subscription;

  void init() {
    log("init is called on InAppPurchaseService");
    final instance = InAppPurchase.instance;

    final Stream<List<PurchaseDetails>> purchaseUpdated =
        instance.purchaseStream;
    _subscription = purchaseUpdated.listen(
      _listenToPurchaseUpdated,
    );
  }

  void _listenToPurchaseUpdated(List<PurchaseDetails> purchaseDetailsList) {
    purchaseDetailsList.forEach((PurchaseDetails purchaseDetails) async {
      if (purchaseDetails.status == PurchaseStatus.error) {
      } else if (purchaseDetails.status == PurchaseStatus.pending) {
        /// This get called
      } else if (purchaseDetails.status == PurchaseStatus.purchased) {
        /// This is not called for subscription
        ///
        /// Handle verification and consume the purchase
      } else if (purchaseDetails.status == PurchaseStatus.canceled) {
      } else if (purchaseDetails.status == PurchaseStatus.restored) {}
    });
  }
}

/// From the UI we will make purchase using
 await InAppPurchase.instance.buyNonConsumable(
     purchaseParam: PurchaseParam(
     productDetails: _selectedProduct!,
   ),
 );

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.0, on macOS 15.2 24C101 darwin-arm64, locale en-NP)
    • Flutter version 3.22.0 on channel stable at /Users/pawanacharya/fvm/versions/3.22.0
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5dcb86f68f (8 months ago), 2024-05-09 07:39:20 -0500
    • Engine revision f6344b75dc
    • Dart version 3.4.0
    • DevTools version 2.34.3

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/pawanacharya/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_SDK_ROOT = /Users/pawanacharya/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    ! Some Android licenses not accepted. To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 16.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16B40
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] IntelliJ IDEA Ultimate Edition (version 2022.1.4)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 74.0.1
    • Dart plugin version 221.6103.1

[✓] VS Code (version 1.76.2)
    • VS Code at /Users/pawanacharya/Desktop/Visual Studio Code.app/Contents
    • Flutter extension version 3.92.0

[✓] Connected device (4 available)
    • Pawan’s iPhone (mobile)         • 00008120-001E49E4210BC01E • ios            • iOS 18.2 22C152
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 15.2 24C101 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 15.2 24C101 darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome 131.0.6778.205

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Hi @devpawann, do you experience the same issue if you run the app in release mode locally? Do you get any errors during the flow? Are all your configurations et al, properly configured for TestFlight. The plugin doesn't really know which environment it's running in (i.e, it doesn't do anything differently whether you're running locally or in TestFlight), so perhaps this could be due to differences between the sandbox environment and the live environment.
At what point is the init method called in your application?

@danagbemava-nc
Yes, I even tried to runthe  app locally with --release flag and everything worked fine, and I published the same build to test flight and faced the issue.
I didn't see any error, just the listener was not triggered that is the issue.

Hi @devpawann, what version of in_app_purchase & in_app_purchase_storekit are you using in your project?

Yes, I even tried to run the app locally with --release flag and everything worked fine

In your local testing in release mode, was it the sandbox store environment that was activated or the production store?

@danagbemava-nc
in_app_purchase: ^3.2.0


get rid of tz address in admin

Done in https://github.com/tzConnectBerlin/kanvas/commit/14b79771641b7387743777315619ce670ab025b2


Update Rollup.js to v. 3

In v.3 Rollup changed its methods for specifying different plugin specs, looks like this is breaking tests. should be an easy update but will require more integration testing. See #371
[!] RollupError: Node tried to load your configuration file as CommonJS even though it is likely an ES module. To resolve this, change the extension of your configuration to ".mjs", set "type": "module" in your package.json file or pass the "--bundleConfigAsCjs" flag. #

The new Rollup version moves from CommonJS to an ES module format for the config. A quick fix is to add --bundleConfigAsCjs, which will treat the config as CommonJS. Alternatively, we could change rollup.config.js to ES module syntax.
https://rollupjs.org/migration/


Avoid high-probability hash collisions, use md5 instead of crc32

It may not be suitable to use crc32 in this scenario
$ cat ./main.go
package main

import (
	"fmt"
	"hash/crc32"
)

func main() {
	a := crc32.ChecksumIEEE([]byte("xxx-c294f5b1"))
	b := crc32.ChecksumIEEE([]byte("xxx-fc26498f"))
	fmt.Println(a == b, a, b)
}

$ go run ./main.go
true<PHONE_NUMBER><PHONE_NUMBER>

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@wzshiming: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-pilot-multicluster-tests_istio

integ-operator-controller-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-pilot-multicluster-tests_istio

integ-operator-controller-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-pilot-multicluster-tests_istio

integ-operator-controller-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-pilot-multicluster-tests_istio

integ-operator-controller-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-telemetry-mc-k8s-tests_istio

unit-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-telemetry-mc-k8s-tests_istio

unit-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-telemetry-mc-k8s-tests_istio

unit-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-distroless-k8s-tests_istio

integ-pilot-multicluster-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-distroless-k8s-tests_istio

integ-pilot-multicluster-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-pilot-multicluster-tests_istio

unit-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
ec02c47f8e998f465847b028b3b809c86b59ada0
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn  It looks like MD5 is faster
$ go test -bench=^BenchmarkConfigKey_ -run=^TestConfigKey_ pilot/pkg/model/config_test.go -benchtime=3s -benchmem
goos: darwin
goarch: amd64
cpu: Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
BenchmarkConfigKey_HashCodeCRC32-8      17446644               205.2 ns/op            48 B/op          5 allocs/op
BenchmarkConfigKey_HashCodeMD5-8        19704902               183.4 ns/op             0 B/op          0 allocs/op
PASS

@hzxuzhonghu  the probability is really low but it does conflict
 go test -run=^TestConfigKey_ -v pilot/pkg/model/config_test.go
=== RUN   TestConfigKey_HashCodeCRC32
    config_test.go:520: true 533326774 533326774
--- PASS: TestConfigKey_HashCodeCRC32 (0.00s)
PASS

var ck1 = model.ConfigKey{
	Kind: config.GroupVersionKind{
		Group:   "core",
		Version: "v1",
		Kind:    "Pod",
	},
	Namespace: "default",
	Name:      "xxx-c294f5b1",
}

var ck2 = model.ConfigKey{
	Kind: config.GroupVersionKind{
		Group:   "core",
		Version: "v1",
		Kind:    "Pod",
	},
	Namespace: "default",
	Name:      "xxx-fc26498f",
}

func HashCodeMd5(key model.ConfigKey) uint64 {
	hash := md5.New()
	for _, v := range []string{
		key.Name,
		key.Namespace,
		key.Kind.Kind,
		key.Kind.Group,
		key.Kind.Version,
	} {
		hash.Write([]byte(v))
	}
	var tmp [md5.Size]byte
	sum := hash.Sum(tmp[:0])
	return binary.BigEndian.Uint64(sum)
}

func HashCodeCRC32(key model.ConfigKey) uint32 {
	var result uint32
	result = 31*result + crc32.ChecksumIEEE([]byte(key.Kind.Kind))
	result = 31*result + crc32.ChecksumIEEE([]byte(key.Kind.Version))
	result = 31*result + crc32.ChecksumIEEE([]byte(key.Kind.Group))
	result = 31*result + crc32.ChecksumIEEE([]byte(key.Namespace))
	result = 31*result + crc32.ChecksumIEEE([]byte(key.Name))
	return result
}

func TestConfigKey_HashCodeCRC32(t *testing.T) {
	cv1 := HashCodeCRC32(ck1)
	cv2 := HashCodeCRC32(ck2)
	t.Log(cv1 == cv2, cv1, cv2)
}

func BenchmarkConfigKey_HashCodeCRC32(b *testing.B) {
	for n := 0; n != b.N; n++ {
		HashCodeCRC32(ck1)
	}
}

func BenchmarkConfigKey_HashCodeMD5(b *testing.B) {
	for n := 0; n != b.N; n++ {
		HashCodeMd5(ck2)
	}
}

@wzshiming: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@wzshiming: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bc9789c3f32fca083c3d472e7469bd2d6fb5e9d8
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


ci: require 100% patch coverage

Change-Id: I995c3c5fc9cc24287bef6bfbd79255a19ba4552f

Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.03%. Comparing base (5481337) to head (161ff1b).

Files with missing lines
Patch %
Lines

rigid_geometric_algebra/detail/contract.hpp
50.00%
1 Missing :warning:

Additional details and impacted files
@@                              Coverage Diff                              @@
##           Ic9dd1bde0044d0ff3de86c6e5e85f3dc7155d32a      #66      +/-   ##
=============================================================================
- Coverage                                      93.31%   93.03%   -0.28%
=============================================================================
  Files                                             24       24
  Lines                                            314      316       +2
  Branches                                          10       11       +1
=============================================================================
+ Hits                                             293      294       +1
- Misses                                            21       22       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix tool ids in ref-based RNA-Seq tutorial

The tools from the toolshed have different parameters or at least different parameter names. Either we can just correct the tool names as I suggested in this PR or we can change the parameters. If we opt for the latter case, the tutorial will not match the recording on GTN.

So if I understand it correctly, the parameters don't match the TS tool? They match the ID you've corrected it to? Correcting the tool id to the builtin cut makes more sense to me here for sure :)

Thanks a lot @pavanvidem!

Yes and yes, @hexylena


I need help with a issue i have encountered, pls help

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2023.07.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
Romania
Example URLs
App version: 1.10.0 (11000)
Device information: Android 13 (API 33)
Supported ABIs: [arm64-v8a, armeabi-v7a, armeabi]
Yt-dlp version: 2023.07.06
URL: https://youtube.com/playlist?list=PLPrnwDi1vgoGSD9futk1EUV6YBQvZha0i&si=Clu5VxEB_knXdA00
WARNING: [youtube:tab] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [youtube:tab] Incomplete yt initial data received. Retrying (1/3)...
WARNING: [youtube:tab] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [youtube:tab] Incomplete yt initial data received. Retrying (2/3)...
WARNING: [youtube:tab] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [youtube:tab] Incomplete yt initial data received. Retrying (3/3)...
WARNING: [youtube:tab] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [youtube:tab] Incomplete yt initial data received; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U. Giving up after 3 retries
WARNING: [youtube:tab] YouTube said: INFO - Unavailable videos are hidden
WARNING: [youtube] unable to extract initial player response; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
ERROR: [youtube] Crd8hmWsxqQ: This video has been removed by the uploader
Provide a description that is worded well enough to be understood
I wanted to download a full playlist from youtube with the ''seal'' app, the playlist contains 1318 vids, when i last entered the app while it was downloading videos, a warning text was there. So i did what it said there and i made a github account so i could receive assistance
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
App version: 1.10.0 (11000)
Device information: Android 13 (API 33)
Supported ABIs: [arm64-v8a, armeabi-v7a, armeabi]
Yt-dlp version: 2023.07.06

URL: https://youtube.com/playlist?list=PLPrnwDi1vgoGSD9futk1EUV6YBQvZha0i&si=Clu5VxEB_knXdA00
WARNING: [youtube:tab] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [youtube:tab] Incomplete yt initial data received. Retrying (1/3)...
WARNING: [youtube:tab] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [youtube:tab] Incomplete yt initial data received. Retrying (2/3)...
WARNING: [youtube:tab] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [youtube:tab] Incomplete yt initial data received. Retrying (3/3)...
WARNING: [youtube:tab] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [youtube:tab] Incomplete yt initial data received; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U. Giving up after 3 retries
WARNING: [youtube:tab] YouTube said: INFO - Unavailable videos are hidden
WARNING: [youtube] unable to extract initial player response; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
ERROR: [youtube] Crd8hmWsxqQ: This video has been removed by the uploader

Try updating to yt-dlp nightly:
Press and hold yt-dlp version in Settings, and select Nightly version
If that doesn't work, try to get a verbose log from Seal to post here

@TteokbokkiNari it's fixed in nightly, yt-dlp --update-to nightly

Ah, thank you a ton!! @bashonly
Works now indeed. ^^


[build] CMake: support OpenGL ES3 in LibraryConfigurations.cmake

Only put ES2 as a fallback if GRAPHICS is not specified.

LGTM! approved.

Actually, one last nit:
emscripten documents the option as -sFULL_ES3 and not -sFULL_ES3=1
To enable OpenGL ES 3.0 emulation, specify the emcc option -sFULL_ES3 when linking the final executable (.js/.html) of the project.

Change that and all should be fine.

Doesn't another part of the emscripten doc say that -sOPTION is exactly equivalent to -sOPTION=1?


README update

Including more info on the readme, making it almost replicate the homepage of the learnteachcode.org and adding slack channel list

Thanks @rouzbeh84 ! Cool :) My only concern is in duplicating info that may change somewhat frequently -- the list of Slack channels and also the list of regular meetups. It's the sort of thing that we often forget about and then it's out of date. Not sure how to automate that better though... lemme know if you have any ideas!

I see, the slack channels could maybe only list the core language specific ones that we know will be there and the meetups can be removed altogether and just have the link to the meetup calendar page?


Make aposAreaImage/apos.files.findImage() smarter

Tom and I chatted about making this nunjucks helper smarter in that it could search at a depth for you. The use case is a schema widget with a slideshow buried in it. I want that slideshow's first image, but now I have to use crusty old dot syntax to get at it. I should be able to pass the schema widget in as my  area and then have apostrophe return the first image it can find.

To  be a little more precise, you would be able to pass your area in, and if the first image happened to be buried in some sub-area in a schema widget inside that area, it would still work.
It could also be made to work with page objects but that's not really the use case at hand and it could turn out badly - an obsolete area no longer used in templates could be the source of the images. So we should stick to finding things in areas, but get smarter at finding things in sub-areas.

(In truth, you could still have this problem of old images coming up with schema widgets, if you change their schemas. But probably not very often.)


Install page is slow when an app has thousands of builds, should paginate

The install page (https://install.appcenter.ms/orgs/:orgName/apps/:appName) is very slow to load and use, and I'm concerned that it will become unusable or start to timeout soon. I think it is because it loads and displays all 6000 of our app builds, going back over a year. We make many app builds a day so this list keeps growing.
Describe the solution you'd like
This page should use pagination and default to showing only recent app builds (20?).
Ideally, the page would also have filtering/searching by date and description. We include our git branch names in the description so this would be really useful.
Describe alternatives you've considered
A direct link for a build would be a useful alternative or additional feature; we have a Slack integration in our Fastfile that posts a link to the install page. If a direct link to a build detail page such as https://install.appcenter.ms/orgs/:orgName/apps/:appName/:buildId were exposed as Fastlane::Actions::SharedValues::APPCENTER_BUILD_LINK, we would post that to Slack instead and our QA engineers wouldn't have to use the existing install page. We make use of APPCENTER_DOWNLOAD_LINK, but a page containing metadata and a download link for a single, specific build would be preferable. I recall seeing in the Hockey -> App Center migration document on Github that a build detail page was initially on the roadmap, but I can't find that document now.

Bump

When will this be fixed?

App center at our company is pretty much unusable for most iPhones because the page lacks pagination. Any idea when this may get addressed in any way?

App center install page no longer loads on iOS for our organization. How can we escalate this? cc @DmitriyKirakosyan

I'm seeing this issue as well.

Why was this closed?

Thank you for the feature request @elijahr! Currently, we are focusing on improving the reliability and performance of the service and new feature work is significantly reduced. To keep the team focused we are closing feature requests with no activity in the past 30-60 days. If you believe this is still relevant, feel free to create a new issue and tag this item so that we can review it. Sorry for the inconvenience.

. If you believe this is still relevant

This is disappointing to read for something as basic as having pagination, this alongside the inability to match dSYM with the corresponding build on iOS is really frustrating.

This should be reopened, this is a small implementation that brings significant user advantage.

This should indeed be re-opened, makes the appcenter barely usable on iOS

In case this helps anyone still suffering, what we ended up doing was to periodically purge old builds.
We realised that we had thousands of old builds that no one would ever really use, so we run a weekly job that connects via Appcenter API and remove old builds keeping only the last 100 or so, that way we were able to get Appcenter usable again.


[BUG] - Error running with more than 1 worker and some hyphothesis

Describe the bug
Running the commando within certain params, Im getting a error (like an exception) but all test cases are passing. The problem is running with 2 or more workers and with more than 27 hypothesis examples.
To Reproduce
Steps to reproduce the behavior:

Command
schemathesis run --stateful=links --stateful-recursion-limit=3 --checks=all --workers=2 --hypothesis-deadline=None --hypothesis-suppress-health-check=too_slow,filter_too_much --validate-schema=true --show-errors-tracebacks --hypothesis-max-examples=27 http://localhost:8100/v1/openapi.json
Error given

======================================================================================= Schemathesis test session starts ======================================================================================
platform Linux -- Python 3.7.9, schemathesis-2.7.5, hypothesis-5.41.1, hypothesis_jsonschema-0.18.0, jsonschema-3.2.0
rootdir: /home/lm/code/project
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/home/lm/code/project/.hypothesis/examples')
Schema location: http://localhost:8100/v1/openapi.json
Base URL: http://localhost:8100/v1
Specification version: Open API 3.0.0
Workers: 2
collected endpoints: 6

...E.........

==================================================================================================== ERRORS ===================================================================================================
_________________________________________________________________________________ PUT: /v1/asset_credentials/{credentials_id} _________________________________________________________________________________
Traceback (most recent call last):
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/schemathesis/runner/impl/core.py", line 115, in run_test
    test(checks, targets, result, headers=headers, **kwargs)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/schemathesis/runner/impl/core.py", line 230, in network_test
    case: Case,
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/core.py", line 1162, in wrapped_test
    raise the_error_hypothesis_found
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/core.py", line 1131, in wrapped_test
    state.run_engine()
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/core.py", line 750, in run_engine
    runner.run()
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/engine.py", line 497, in run
    self._run()
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/engine.py", line 899, in _run
    self.generate_new_examples()
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/engine.py", line 750, in generate_new_examples
    self.test_function(data)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/engine.py", line 218, in test_function
    self.__stoppable_test_function(data)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/engine.py", line 194, in __stoppable_test_function
    self._test_function(data)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/core.py", line 703, in _execute_once_for_engine
    escalate_hypothesis_internal_error()
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/core.py", line 674, in _execute_once_for_engine
    result = self.execute_once(data)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/core.py", line 629, in execute_once
    result = self.test_runner(data, run)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/executors.py", line 52, in default_new_style_executor
    return function(data)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/core.py", line 569, in run
    args, kwargs = data.draw(self.search_strategy)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 887, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/core.py", line 218, in do_draw
    return self.mapped_strategy.do_draw(data)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/collections.py", line 57, in do_draw
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/collections.py", line 57, in <genexpr>
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 650, in do_draw
    result = self.pack(data.draw(self.mapped_strategy))
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/lazy.py", line 150, in do_draw
    return data.draw(self.wrapped_strategy)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 650, in do_draw
    result = self.pack(data.draw(self.mapped_strategy))
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/collections.py", line 57, in do_draw
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/collections.py", line 57, in <genexpr>
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/lazy.py", line 150, in do_draw
    return data.draw(self.wrapped_strategy)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 650, in do_draw
    result = self.pack(data.draw(self.mapped_strategy))
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/lazy.py", line 150, in do_draw
    return data.draw(self.wrapped_strategy)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/collections.py", line 57, in do_draw
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/collections.py", line 57, in <genexpr>
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 650, in do_draw
    result = self.pack(data.draw(self.mapped_strategy))
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/collections.py", line 57, in do_draw
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/collections.py", line 57, in <genexpr>
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/core.py", line 1809, in do_draw
    return self.definition(data.draw, *self.args, **self.kwargs)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis_jsonschema/_from_schema.py", line 585, in from_object_schema
    out[key] = draw(merged_as_strategies(pattern_schemas, custom_formats))
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 724, in do_draw
    data=data, filter_strategy=self
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 352, in do_filtered_draw
    return filter_strategy.default_do_filtered_draw(data)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 739, in default_do_filtered_draw
    value = data.draw(self.filtered_strategy)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 589, in do_draw
    return data.draw(strategy)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 724, in do_draw
    data=data, filter_strategy=self
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/lazy.py", line 154, in do_filtered_draw
    data=data, filter_strategy=filter_strategy
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 352, in do_filtered_draw
    return filter_strategy.default_do_filtered_draw(data)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/strategies.py", line 739, in default_do_filtered_draw
    value = data.draw(self.filtered_strategy)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/lazy.py", line 150, in do_draw
    return data.draw(self.wrapped_strategy)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/core.py", line 1809, in do_draw
    return self.definition(data.draw, *self.args, **self.kwargs)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis_jsonschema/_from_schema.py", line 587, in from_object_schema
    out[key] = draw(from_schema(additional, custom_formats=custom_formats))
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/internal/conjecture/data.py", line 883, in draw
    return strategy.do_draw(self)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/recursive.py", line 98, in do_draw
    with self.limited_base.capped(self.max_leaves):
  File "/usr/lib/python3.7/contextlib.py", line 112, in __enter__
    return next(self.gen)
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/hypothesis/strategies/_internal/recursive.py", line 50, in capped
    assert not self.currently_capped
AssertionError

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/lm/.virtualenvs/project/lib/python3.7/site-packages/schemathesis/runner/impl/core.py", line 170, in reraise
    raise InvalidSchema(message) from error
schemathesis.exceptions.InvalidSchema: Unknown schema error

=================================================================================================== SUMMARY ===================================================================================================

Performed checks:
    not_a_server_error                              220 / 220 passed          PASSED
    status_code_conformance                         220 / 220 passed          PASSED
    content_type_conformance                        220 / 220 passed          PASSED
    response_headers_conformance                    220 / 220 passed          PASSED
    response_schema_conformance                     220 / 220 passed          PASSED

If possible, please post a minimal version of your API schema that cause this behavior:
{
    "openapi": "3.0.0"
    put:
      summary: Updates credentials with id credentials_id.
      tags:
        - a c
      operationId: ac.api.update
      requestBody:
        required: true
        content:
          application/json:
            schema:
             $ref: "#/components/schemas/CredentialsWithPass"
      responses:
        '202':
          description: Updated successfully.
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Metadata"
          links:
            GetCredentialById:
              $ref: '#/components/links/GetCredentialById'
            GetCredentialWPassById:
              $ref: '#/components/links/GetCredentialWPassById'
            DeleteCredentialsById:
              $ref: '#/components/links/DeleteCredentialsById'
            UpdateCredentialsById:
              $ref: '#/components/links/UpdateCredentialsById'
        '400':
          description: Invalid provided body credentials or id.
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Error'
        '404':
          $ref: '#/components/responses/404InvalidCredentialsId'
        '503':
          $ref: '#/components/responses/503ConnectionKV'
}

Expected behavior
The idea is that to use more than 2 workers and at most 100 examples. This is to cover most of the API Cases
Environment (please complete the following information):

OS: Ubuntu 18.04LTS
Python version: 3.7.9
Schemathesis version: 2.7.5
Spec version: OpenAPI 3.0.0

Thanks! I will take a look at this issue in the next few days

Sorry for not getting back to you! I have a couple of things to finish, and when they are done, I'll get back to this issue

The problem is that underneath there is a shared strategy that is accessed by multiple threads, and a race condition occurs. I reported it to Hypothesis, and once it is resolved, I will bump the Hypothesis version here, release a new version with these changes and close this issue :) Likely it will be a part of the Schemathesis 3.0 release

Great! I'll stay tuned. Thanks!

Schemathesis 3.2.2 supports Hypothesis 6, where the issue is fixed. Let me know if it doesn't work for your use case.


tests do not run correctly on solidus_gateway master

jason@Jasons-MB-Air-2:solidus_gateway (master)$ be rspec spec/*
Coverage report generated for RSpec to /Users/jason/Projects/Mack-Weldon/solidus_gateway/coverage. 332 / 828 LOC (40.1%) covered.
/Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/decorator.rb:10:in `method_missing': Factory already registered: skrill_quick_checkout (FactoryGirl::DuplicateDefinitionError)
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/decorator/disallows_duplicates_registry.rb:6:in `register'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl.rb:70:in `block in register_factory'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl.rb:69:in `each'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl.rb:69:in `register_factory'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/syntax/default.rb:20:in `factory'
	from /Users/jason/Projects/Mack-Weldon/solidus_gateway/spec/factories/skrill_factory.rb:2:in `block in <top (required)>'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/syntax/default.rb:49:in `instance_eval'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/syntax/default.rb:49:in `run'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/syntax/default.rb:7:in `define'
	from /Users/jason/Projects/Mack-Weldon/solidus_gateway/spec/factories/skrill_factory.rb:1:in `<top (required)>'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `load'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `block in load'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:240:in `load_dependency'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `load'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/find_definitions.rb:20:in `block (2 levels) in find_definitions'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/find_definitions.rb:19:in `each'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/find_definitions.rb:19:in `block in find_definitions'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/find_definitions.rb:15:in `each'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/find_definitions.rb:15:in `find_definitions'
	from /Users/jason/Projects/Mack-Weldon/solidus_gateway/spec/spec_helper.rb:49:in `block in <top (required)>'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core.rb:97:in `configure'
	from /Users/jason/Projects/Mack-Weldon/solidus_gateway/spec/spec_helper.rb:22:in `<top (required)>'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `load'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `block in load'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:240:in `load_dependency'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `load'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/configuration.rb:1361:in `block in load_spec_files'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/configuration.rb:1359:in `each'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/configuration.rb:1359:in `load_spec_files'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:102:in `setup'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:88:in `run'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:73:in `run'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:41:in `invoke'
	from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/exe/rspec:4:in `<top (required)>'
	from /Users/jason/.rvm/gems/ruby-2.1.5/bin/rspec:23:in `load'
	from /Users/jason/.rvm/gems/ruby-2.1.5/bin/rspec:23:in `<main>'
	from /Users/jason/.rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `eval'
	from /Users/jason/.rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `<main>'

I see it registered inside of solidus_gateway/spec/factories/skrill_factory.rb but I can't seem to find where FG is loading it first-- I suspect one of the dependent gems

this is reproducible on master: 1. clone the repo, 2. run rake test_app, 3. run rake spec/*

Running rspec spec/* (I assume rake was a typo) will not work, since that will load the spec_helper twice (causing your skrill_quick_checkout issue). Just run rspec or rspec spec.

confirmed rake spec/* was a typo, what I meant was bundle exec rspec spec/*
you are indeed correct, bundle exec rspec spec works as expected, my mistake.
Thanks for the feedback!


feat: refactor to provie writeEye and consultEye functions

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[PE-D][Tester B] Restrictions on a person's name does not allow for the adding of some legal names

For example, “John-Doe” and “Tan Mei Ling, Jane” are not allowed, but legal names can have commas and hyphens.

Labels: severity.Low type.FeatureFlaw
original: sunzihan23/ped#3

Thank you for the feedback. This restriction is in place to ensure uniformity and prevent issues with data entry, retrieval, or display in Connectify, ensuring a smooth and consistent user experience. While restrictive to the user, such limitations are in place to avoid complications and ensure the accurate handling of data.


[BUG] Fix transaction not be cleared after BE down.

After BE down, transactions related should be cleared.
The hostname is used to retrive the transactions.
But hostname is recorded as hostname + port, the port
should be removed.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] Documentation Update (if none of the other choices apply)
[] Code refactor (Modify the code structure, format the code, etc...)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
[] Compiling and unit tests pass locally with my changes
[] I have added tests that prove my fix is effective or that my feature works
[] If this change need a document change, I have updated the document
[] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM


Investigate sources of hop varietal information

Hops are currently just a list, but it might be nice if the database could be populated with more information about the varietals (year/place developed, if found in wild, bred from another, etc).

Maybe scrape yakima chief website.
https://shop.yakimachief.com

655ac5222ff60a3d033acc00827877b4e4587ed7 makes a json object out of the Yakima Chief hop PDF.  Extracts hop names, proprietary ID if provided, tasting notes, country of origin, and styles.
Still need to load to database.  Jupyter notebook needs some work if I want to get the alpha acids or other chemistry data on the hop - PDF has some quirky formatting that is mostly standard, but missing for some pages requiring a rats nest if statement snarl.
At this point I'll note to self that I may want to see what other sources I can scrape/merge since this only covers what Yakima Chief sells.  For instance Zappa is proprietary to a competitor CLS farms, and sold at Yakima Valley Farms.  Other brewing supply sites have descriptions too.  There seems to be an industry standard for at least some of the aromatics and oils used by most sites/vendors.


MIDI Messages are not all 3 bytes

Some useful MIDI messages are 2 bytes (see program change), and some less common ones are even one byte.
https://www.midi.org/specifications-old/item/table-1-summary-of-midi-message
I've created a fork with some different approaches that suit my needs. I'm happy to contribute them back, but I understand the changes are somewhat dramatic. https://github.com/fcanas/CombineMIDI

Thanks for pointing up this issue!
If we wanted to pursue this I see some things what we would need to do:

[ ] Update the documentation
[ ] Update the logic of chunking messages into three bytes

There is one point for discussion: Modelling the messages as enum with associated values makes the code much more complicated – I believe it would be enough if the second and third byte were optional or if they were filled with zeros. (I can see some developer experience improvements in your implementation.)

An approach without modeling messages in an enum might look like this. It's not exhaustive, but it adds some more messages, and fills out support for 1, 2, and 3 byte messages. https://github.com/fcanas/CombineMIDI/commit/ede63d900b3561c88187d1b418a65bf23913a469
There's some complexity in dealing with a byte stream and ensuring proper message construction. I'm sure there are other approaches, but this is the one that occurred to me first.
Possibly a MIDIMessage should store its bytes as its sole representation, with convenience status, and optional channel, and data accessors.
The risk in keeping an internal 3 byte model, whether contiguous or restructured into various properties, is that more complexity would need to be added if the model were to be serialized. 1 and 2 byte messages are not zero-padded when transmitted.
On the use-side, I personally like the richer enum modeling for message as I can use the API without looking up MIDI documentation. I absolutely understand if you're not a fan, and I'm also open to other approaches.

Thanks for your work!
Can you open a PR? I think your solution is great – I might just add some more documentation and release it afterwards.

There's some complexity in dealing with a byte stream and ensuring proper message construction. I'm sure there are other approaches, but this is the one that occurred to me first.

I might have some ideas for improvements, but we don't have to implement them. Your solution works fine.

Possibly a MIDIMessage should store its bytes as its sole representation, with convenience status, and optional channel, and data accessors.

That is a good idea, but again, I don't see it as a necessary change.

The risk in keeping an internal 3 byte model, whether contiguous or restructured into various properties, is that more complexity would need to be added if the model were to be serialized. 1 and 2 byte messages are not zero-padded when transmitted.

I agree this would be solved by storing the messsage as a byte array internally.

On the use-side, I personally like the richer enum modeling for message as I can use the API without looking up MIDI documentation. I absolutely understand if you're not a fan, and I'm also open to other approaches.

I think about the rich enum as an extension of the basic model. It can make some operations on the MIDI messages more complicated – like filtering. I am not against it, but I would like to keep the basic representation and add the rich enum if it ergonomically suits the user better.


Clicking on JavaScript on the same page takes you to an unrelated page.

Scenario:
I am looking for JavaScript documentation for Cognitive Services on their page and have 2 JavaScript options.
Link 1
Link 2
If I click on link 2, I am redirected to a different page. It is hard to find the Cognitive Services and confusing to end up in different sidebar navigation.
This is consistent throughout the documentation. I can see why it is useful in some cases to be able to go to language-based selection but at the same time, I have lost what I was looking for, Cognitive Services.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ef96562d-099d-9400-c88c-ba0439e136a6
Version Independent ID: 049314ea-8e68-50ee-3469-4d39c801fc54
Content: Quickstart: Computer Vision client library - Azure Cognitive Services
Content Source: articles/cognitive-services/Computer-vision/quickstarts-sdk/client-library.md
Service: cognitive-services
Sub-service: computer-vision
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@Yonet Thank you for the feedback (and the screenshot)!
This is a design decision made for all of Azure and closely resembles what you'll see in other product pages, like Office.  I'll pass your feedback along but for now it may be valuable to get familiar with the documentation layout as it can take a little getting used to.  Once you know what to look for and where, using the documentation quickly becomes second nature and can be a valuable resource.

Each row in the top navigation takes you a layer closer to the product and service that you are looking at.  Within the actual documentation itself, you may see options for changing instructions and code samples to match the language you are interested in (JavaScript, in this case).
Selecting "Develop" from the 2nd row will give you Azure wide results.  For service specific results in your language, you'll typically want to check either the table of contents on the left (example:  Quickstart - .NET, Quickstart - Python, etc.) or look for  an option to select the language within the documentation itself.

Thank you @kobulloc-MSFT. I'm an msft employee and  very familiar with the structure. We are looking at the reasons why and where new user churn is happening and how we can improve the retention rates. I am working on a end to end scenarios where a user come to the documentation with a goal to do something and how easy it is to accomplish that goal without getting lost in documentation. Although it is a design decision, it is very confusing for an unfamiliar user to end up on azure JavaScript docs while they are browsing in cognitive services documentation and looking for JavaScript SDK.
I know it is not an improvement that will happen tomorrow but we have to file the issue to keep track of the feedback.
Thanks!

@Yonet Thank you for working to improve our documentation experience!  I'm going to close this as there's no additional action we can take on our end, but it will remain visible for tracking purposes.  If you need this reopened, just tag me in your reply and I'd be happy to adjust the issue accordingly.

Can we keep it open to keep track until to make sure we give the feedback to the docs team and we get a response. Closing defeats to purpose of giving the feedback. Thanks.

@Yonet No worries!  Just tag me in a reply when you are ready to close this.

@kobulloc-MSFT thank you.

@Yonet - A good approach would be to create a work item in the tracking tool that you use, e.g. Azure DevOps, add a link to this Github issue in that work item, and close this work item. We are actively looking to close Github issues on our content, driving them to resolution, and have SLAs towards it. For long running issues, like this one, the approach we follow is what I have recommended here.
#please-close

Hi @nitinme, I can save the link for the issue but my question is, how will I know if the doc team has a solution or not going to fix? If there is a DevOps for the azure docs team, please direct me there. The only way I know I can give feedback to the documentation team is through github issues.
Thanks!


Sessions Page

This PR adds a streaming page. Many major changes:
Backend:

DB: jobs/scans are associated in the association table
DB: jobs have notes, submit date
FastAPI: crud, endpoints, and schemas changed to reflect these changes
Faust: job_worker updated to reflect the above changes
Templates: new streaming job template
Kafka: job event notifications

Frontend:

API updated
Jobs store added
SessionCard component added
SessionPage, Sessions Page added
Routes changed, navigation improved
Scans are stored in the store by upsert rather than set

& more...

todo:

[ ] Remove unused things from job store (fetchedJobIds)
[ ] Make generic selectors for job store
[ ] test cascading delete
[ ] Separate update logic into separate, non-committing function
[ ] Specify job events consumed by client
[ ] add filter for scan_id on GET /jobs/
[ ] add filter for job_id on GET /scans/
[ ] pytz, not zoneinfo
[ ] put NoThumbnail somewhere in a component
[ ] pass in event handler into scans page
[ ] check if confirmRemoval works

@swelborn We will need to fix up the tests as well.

pytest is fixed. since process_submit_job does not change event.scan.created from string, it goes into the template as a string in the current iteration. we can change this behavior, if desired. see changes to tests.


Wip federation

Enables OpenID Connect Federation. There is remaining work to create IDP, groups and mappings in keystone The work to create IDP, groups, mappings has been completed.

Latest commit completes the openid connect integration for Horizon. Craig is working on the CLI integration and should be done soon. I expect a PR dependent on this one to be out there

I think the code looks fine, there's just the matter of cleaning up the commits. Will defer to @craigtracey too.

retest

Apache fails to start
msg: Output of config test was:
AH00526: Syntax error on line 6 of /etc/apache2/sites-enabled/keystone.conf:
Invalid command 'OIDCClaimPrefix', perhaps misspelled or defined by a module not included in the server configuration
Action 'configtest' failed.
The Apache error log may have more information

CI passed.

Alright, I think the only thing left to do here is to squash the commits down. This doesn't test federation in the CI path, so we'll have to figure out a good ay to test it otherwise.

This was done in #1700


Containerd not restarting properly after upgrade to systemd 252.11 on stable

Description
We have noticed strange downtimes all over our kubernetes infrastructure since the recent upgrades to v3510. The root cause seems to be that the containerd service is not properly restarting when it exits sometimes. The symptoms are as follows: The containerd systemd unit stays in active(running) state even when the main process has exited even though the systemd unit has ExitType set to main and not cgroup. Containers already running stay active, but everthing else (i.e. kubernetes, docker) stops working obviously.
The systemd unit looks like this
containerd.service - containerd container runtime
     Loaded: loaded (/run/systemd/system/containerd.service; enabled; preset: disabled)
    Drop-In: /etc/systemd/system/containerd.service.d
             └─10-kubeone.conf
     Active: active (running) since Wed 2023-08-09 19:27:23 UTC; 11min ago
       Docs: https://containerd.io
    Process: 1778 ExecStartPre=mkdir -p /run/docker/libcontainerd (code=exited, status=0/SUCCESS)
    Process: 1802 ExecStartPre=ln -fs /run/containerd/containerd.sock /run/docker/libcontainerd/docker-containerd.sock (code=exited, status=0/SUCCESS)
    Process: 1809 ExecStart=/usr/bin/env PATH=${TORCX_BINDIR}:${PATH} ${TORCX_BINDIR}/containerd --config ${CONTAINERD_CONFIG} (code=killed, signal=HUP)
   Main PID: 1809 (code=killed, signal=HUP)

Impact
This effectively breaks any environment requiring containerd restarts/reloads such as environments using alternative runtimes that are loaded after the initial boot process e.g. nvidia runtime or kata-containers.
Environment and steps to reproduce

Set-up: Boot a fresh flatcar 3510.2.6 VM using the flatcar_production_qemu.sh
Task: Restart containerd when at least one container is running (if no containers are running the bug does not occur)
Action(s):
a. Start a container e.g. docker run -d busybox sleep 9999999
b. Look at systemctl status containerd, make sure the main process and container are running, note the main PID
c. kill -SIGHUP <containerd-main-pid>
Error: Look at systemctl status containerd again and wait for a restart (which will not happen)

Expected behavior
Containerd is restarted as specified in the systemd unit. I have just verified this with a fresh 3374.2.5 VM and containerd restarts as excpeded.
Additional information
I am not entirely sure what release has introduced this behaviour since it took me a while to track this down, but it must have happened somewhere between 3374.2.5 and 3510.2.6. It probably was 3510.2.5 though since it upgraded systemd to 252.11
I would greatly appreciate if someone has any idea for a temporary hotfix other than switching to LTS until this is fixed.

Thanks for the detailed report! This is a regression in systemd v252.11, fixed in v252.12. Here are some links:

same issue: https://github.com/systemd/systemd/issues/28030
upstream fix: https://github.com/systemd/systemd/pull/28000
backport of fix to v252: https://github.com/systemd/systemd-stable/commit/34e834f496338fdc2a8a8cc771cba4082079cf9a

A workaround is to execute systemctl restart containerd (which works well for k8s/kata but stops docker).

@tormath1 is (likely) going to try cherry-picking the commit into stable before v252.12+ arrives. In that case we would aim for the next stable.

@tormath1 You are absolutely right, SIGTERM and SIGKILL do not cause the same problem.
I know that nvidia's container toolkit is doing this, but we also had problems on a cluster that does not have NVIDIA devices. I can't say right know what was killing containerd there. Possibly kata order kubevirt? I would have to ask.

I can confirm that this works. gpu-operator related problems can be fixed by adding
toolkit:
  env:
  - name: RUNTIME_ARGS
     value: --restart-mode=systemd

to the NVIDIA ClusterPolicy.

Just as a note for other people hitting this problem ... We identified one more culprit causing downtimes related to this bug. The system ugprade component of Rancher / RKE2 can get stuck in a deadlock while upgrading.


feat: provide the request info in Context for all Storage() callbacks

Is your feature request related to a problem? Please describe.
Several times I've needed information that is present in the original http.Request when implementing op.Storage APIs or even Client APIS.
Describe the solution you'd like
Capture the original http.Request and request body and put them into context.Context so any op.Storage API can get that information if it needs it.
Describe alternatives you've considered
Change all of the op.Storage APIs to include additional information.

I'm not sure if we would want something like this, so I will take it up with my colleagues. Meanwhile. you could easily achieve this by creating your own middleware:
type ReqKeyT int

const ReqKey ReqKeyT = 0

func requestToCtx(next http.Handler) http.Handler {
	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		ctx := context.WithValue(r.Context(), ReqKey, r)
		next.ServeHTTP(w, r.WithContext(ctx))
	})
}

	handler, err := op.NewOpenIDProvider(issuer, config, storage,
		//we must explicitly allow the use of the http issuer
		op.WithAllowInsecure(),
		// as an example on how to customize an endpoint this will change the authorization_endpoint from /authorize to /auth
		op.WithCustomAuthEndpoint(op.NewEndpoint("auth")),
		op.WithHttpInterceptors(requestToCtx),
	)

Closing as this is the alternative solution to #326. Also discussed in discord.

@muhlemmer  There are other situations where the entire request is useful.  In my implementation, I'm passing the request through to the storage layer (using Context)  for /authorize, /revoke, and /end_session.  We can solve those individually, but it seems like a general solution is warranted.


Issues building for Node 23.0.0 with Visual Studio 2022

I have the latest C++ packages installed in VS 2022 but build is failing due to
node-gyp\Cache\23.0.0\include\node\v8config.h(13,1): error C1189: #error:  "C++20 or later required."
I've googled the error but can't find much that has seemed helpful that way, and when trying to google how to get C++ 20 support I am only finding mention of doing this for a C++ project, which of course I'm not doing here. I am just trying to use npm rebuild to get my packages reinstalled under node 23.0.0 and I'm hoping this is right place to report since the error occurs on this library. (Sorry if not correct due to my inexperience with the errors).

In the binding.gyp, the following is needed: 'cflags_cc': ['-std=c++20'].
node-gyp is building native code, which is in C/C++, and abstracts away the process when you run npm install.
The above patch has already been made. I don't believe it's been published to npmjs just yet.
If you would like to add the latest "hot-off-the-press" version, use
npm install github:WiseLibs/better-sqlite3#master

...at least until an official package update is made.

If you want to compile the project by yourself, you might also clear all the auto generated files within the build folder (better-sqlite3\build) to force them to be recreated with the proper settings.
If the issue persists, ensure that the default compiler version and binary paths point to the correct MSVC compiler (MSVC 2019 v16.9 and higher, not to confuse with the version of your Visual Studio).

Thanks, this was very  helpful.


Requesting non-existent item property causes performance degradation instead of an error

I use stac-fastapi in conjunction with a PgSTAC backend. Today, I noticed a troublesome issue: when a client sends a request to the /search endpoint (with the filter extension activated) using a non-existent Item property, the backend initiates a comprehensive scan to locate the item. This significantly impairs the database's performance. Is there a way to specify which properties are eligible for filtering, thus preventing unnecessary requests from being forwarded to the database? Alternatively, can this be configured on the PgSTAC side in some way?

Strict mode for search has been implemented in https://github.com/stac-utils/pgstac/pull/216


Channel not found error. Fixes #109

I would use a more user-friendly message like "Unable to connect to stream $name, looks like the "

Updated!


route path parsing not matching express/fastify

Hi,
It looks like the path parsing is not working like express or fastify (although the documentation points to them as reference: https://elysiajs.com/concept/route.html)
For example, when using this pathMatch /:id/:filename.:ext, the path /test/foo.png does not match (because ext is not optional) and the match results in:
{
  id: 'test',
  filename: 'foo.png'
}

while I would expect:
{
  id: 'test',
  filename: 'foo',
  ext: 'png'
}

Testing this path matching using express-route-tester works as expected (in all versions):
https://forbeslindesay.github.io/express-route-tester/
I now have to use a workaround to split the extension in the handler.
Hope this helps!
Btw: keep up the good work. I love ElysiaJS and it quickly became my goto node (Bun!) framework of choice!

We don't support path matching like this using string literal.
However, we do support this approach by using decoder, or using transform.
We are not going to support path matching using string literal due to:

Performance reason.
You can have full control over the path matching using a decoder rather than limiting it to what Elysia provided.

Feels free to reopen the discussion if this doesn't answer your question.


Investigate use of submission patch and refactor it to meet the needs

Description
The use of endpoint for patching submission has changed radically during a few code updates. Currently, it is probably used to only update the submission's name and description but it needs to be investigated. If this is the case, then the patching function should be minimized to accept only those fields as JSON and no extra db-related information.
Current request body for the call:
 [{"op": "replace", "path": "/name", "value": "test2"}]
Expected request body for the call:
{"name": "test2"}
DoD (Definition of Done)
Call to patch submission/<submission_id> will update only submission's name and description with simple JSON string.
The frontend has been adapted with this update
Testing
Integration tests both on the front and the backend

Replaced folder with submission.

The other endpoints still support PATCH with the same syntax. Should we only restrict which fields in submission can be updated with PATCH, or also refactor other PATCH endpoints to function similarly, without the JSON:patch syntax?
I think it's worse UX that submission PATCH endpoint has different format than the other PATCH endpoints.

This change also means that some possible use cases would be removed, for e.g., what's now in integration tests: https://github.com/CSCfi/metadata-submitter/blob/53c60c7e6242ff3793427ee2f9edc7895bcf70f7/tests/integration/run_tests.py#L1606=


Memcache sample deprecated and not working

The app.yaml configuration file uses vm: true, which is deprecated. Also, the memcache service is currently not available for the App Engine flexible environment according to this.

Nope, not working. After running gcloud app deploy it fails with the following error:
ERROR: (gcloud.app.deploy) INVALID_ARGUMENT: Deployments to App Engine Flexible require `env: flex` in app.yaml.  The `vm:true` setting has been deprecated.
To learn more, please visit https://cloud.google.com/appengine/docs/flexible/python/upgrading.

Closing comment as it's intended behavior as Memcache is not available for GAE flexible environment.


Fix: refactored mismatching deletion resource types

In cases where the resource type name mismatches in the following funcs, its deletion functionality will break:
# pkg/kor/<resource>s.go

func GetUnused<Resource>s()
	if opts.DeleteFlag {
          if diff, err = DeleteResource(diff, clientset, namespace, "<Resource>", opts.NoInteractive); err != nil {

# pkg/kor/delete.go

func DeleteResourceCmd()
        "<Resource>": func(clientset kubernetes.Interface, namespace, name string) error {

I've fixed the following mismatches in order to resolve #200:

delete.go -> changed Roles to Role to match passed resource-type in roles.go.
serviceaccountss.go -> changed Serviceaccount to ServiceAccount.
statefulsets.go -> changed Statefulset to StatefulSet.

Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (47ec5b8) 44.43% compared to head (828c7fb) 44.43%.

Files
Patch %
Lines

pkg/kor/delete.go
0.00%
3 Missing :warning:

pkg/kor/serviceaccounts.go
0.00%
1 Missing :warning:

pkg/kor/statefulsets.go
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   44.43%   44.43%
=======================================
  Files          29       29
  Lines        2444     2444
=======================================
  Hits         1086     1086
  Misses       1205     1205
  Partials      153      153

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


audio: InfiniteLoop should take start and length

This was rejected at #200 once since I wanted to keep API simple as much as possible at that time. Now I think a stream with a ranged loop is very common.
As I can't change NewInfiniteLoop signature for backward compatibility, how about

Introducing Loop that takes start and length positions for ranged loop at version 1.x
Marking InfiniteLoop deprecated at version 1.x
Removing InfiniteLoop at version 2.x

? InfiniteLoop will be a Loop with 0 start position.

I started to think a new independent package for loops. I've not determined.

Let's consider renaming later.


Read Only option?

Is there a read only option?
I've tried enableOnReadonly but had no joy
Pen: http://codepen.io/anon/pen/Wobrjg
Thanks

Hi, What do you expect from a readonly option ?
FYI, enableOnReadonly  option is meant so the datepicker will show even if the input field is readonly.

So that all dates cannot be highlighted / selected.
Ah cool, that's why it wasn't working as i thought it would haha.
My other option would be to disable all dates then but i need to highlight certain dates as well and can only see a daysOfWeekHighlighted option is there a way to highlight specific dates similar to datesDisabled: '21/11/2016, 24/11/2016'?

@flash506 I didn't see the issue here. Selected date will be highlighted even if you disable all dates by datesOfWeekDisabled: [0, 1, 2, 3, 4, 5, 6]. Here is a JSFiddle demonstrating approach: https://jsfiddle.net/w72sw25c/

my issue is that if i highlight certain dates using beforeShowDay and disable the calendar my highlighted dates no longer show
I've commented out the daysOfWeekDisabled in the pen - but if commented back in it doesn't show highlighted dates...
updated pen: http://codepen.io/anon/pen/Wobrjg
Thanks

I've updated my JSFiddle to show that datesOfWeekDisabled and beforeShowDay are working nicely together: https://jsfiddle.net/w72sw25c/1/ There must be an issue with your code.

Got it - needed !important in css
thanks for your help.
Much appreciated

I see a value on a real readonly option.
The current situation is the following:

input disabled: Picker not showing
input readonly: Picker showing and working if enableOnReadonly if true, else it won't show
regular input : Picker showing and working

I think that we could change for this:

input disabled: Picker not showing
input readonly: Picker showing and working if enableOnReadonly if true, else it will show but not work
regular input : Picker showing and working

@Azaret I'm not quite sure about suggested api change. It wouldn't be possible any more to not showing a picker on a readonly input.
In detail you are suggesting a fundamentally change to enableOnReadonly option. Currently it controls if a picker shows up. You drop this option and replace it by another option having same name to control if a picker allows to change value of readonly input.
I confirm that default behaviour for enableOnReadonly = true is unexpected. But I think changing this default would be a better way. Therefore I would recommend another change:
If input element bootstrap-datepicker is attached to is readonly, datesOfWeekDisabled will default to [0, 1, 2, 3, 4, 5, 6]. This would allow all uses cases:
Having an element <input readonly>, bootstrap-datepicker

won't show up as default,
will show up but won't allow to change value if enableOnReadonly is true,
will show up and will allow to change value if enableOnReadonly is true and datesOfWeekDisabled is an empty array.

I don't really like this since datesOfWeekDisabled is not meant to be used for this.
Also it would be expected for the picker to change state as the input change, so if the input change from readonly to editable state then the picker should switch from readonly to editable state. With such implementation as yours it will need extra work to save user defined datesOfWeekDisabled if any.
You are actually suggesting to fundamentally change datesOfWeekDisabled option.
Which is not a bad thing, breaking up things can be good ;)
But in this case I think it's a bad idea, not because of changing datesOfWeekDisabled behavior but because datesOfWeekDisabled has nothing to do with the input state and was not meant for our case.
Another argument is that for 2.0 date stuff will be handle by engine backends, and moment.js for instance can use various calendars. That mean that an option like datesOfWeekDisabled will be linked to the engine and might have variable values, while the readonly option will only be for UX and should works fine no matter the amount of days in a week.
What we could do it add an option like readonlyMode with 3 values:

readonly Picker will open but not work
editable Picker will open and work
disabled Picker wont open
If this feature is build for 1.x, editable will be default for 1.x.
Then for 2.0 the default will be changed for readonly because it make sense to have readonly behavior on a readonly input by default.

Still if this change is made in 1.x then enableOnReadonly: true will be an alias for readonlyMode: 'editable' and enableOnReadonly: false will be an alias for readonlyMode: 'disabled'. enableOnReadonly will also be marked as deprecated and removed in 2.0.

Adding a more flexible readonlyMode option and deprecating enableOnReadonly sounds good.
I've only one point to clear out: readonlyMode must not affect pickers attached to an input element not having readonly property.

Yes, editable and disabled inputs stay with the same behaviors.
Also the option shall come with a method setReadonly taking a boolean as parameter to programmatically change the readonly state of the picker.
And we should have some markup support for inline pickers, maybe like data-readonly so people can expect the same behaviors.

Any news about this?


Never expires (as defined in config)

Hello,
I saw sometimes token is expiring with default 86400sc value, when it pass one day and I come back to  call a new request.
I now need to test and implements from my client the case when token expires to set a new one, or refresh existing (using gesdinet bundle).
But, I set token_ttl to 120sc and looks like the token still active. Doesn't matter cache is cleared and 2 minutes passed.
Any idea about this ?

Hi, could you show us your config ? Which version of the bundle and the namshi/jose library do you use ?

JWTBundle 1.4.
I was doing some tests from angular, and it looks like to refresh, so ...
Tests I done before with postman let me uses token even it was expired.
Anyway, angular side is the important. Thanks for answer :)


Uncaught (in promise) TypeError: Cannot read property 'map' of undefined

Sometimes, and I can't figure it out why, we're unable to see the list of items.
Looking at the console we have the following error:
Uncaught (in promise) TypeError: Cannot read property 'map' of undefined
It seems that it's something related to the categories.

PR#15 resolves this.

Great, PR #15 was just merged.
Thanks!


server.js: Made the stats command more API-like. Still keeping the old functionality.

should do that for invites too


Platform not registered by any plugin

Getting this error: The requested platform "SamsungTVControl" was not registered by any plugin. Your config.json is requesting the platform "SamsungTVControl" which has not been published by any installed plugins.
8/9/2020, 5:22:55 AM HOOBS listening on port 8080.
8/9/2020, 5:23:02 AM Loaded plugin "homebridge-alexa".
8/9/2020, 5:23:02 AM Loaded plugin "homebridge-chamberlain".
8/9/2020, 5:23:02 AM Loaded plugin "homebridge-delay-switch".
8/9/2020, 5:23:02 AM Loaded plugin "homebridge-leviton".
8/9/2020, 5:23:03 AM Loaded plugin "homebridge-nest".
8/9/2020, 5:23:03 AM Loaded plugin "homebridge-samsung-tizen".
8/9/2020, 5:23:03 AM Loaded plugin "homebridge-samsungtv-control".
8/9/2020, 5:23:03 AM [Alexa] homebridge-alexa v0.4.73, node v12.14.1, homebridge v3.2.6
8/9/2020, 5:23:03 AM [Alexa] Initializing platform accessory "Alexa"...
8/9/2020, 5:23:03 AM [Nest] Fetching Nest devices.
8/9/2020, 5:23:03 AM The requested platform "SamsungTVControl" was not registered by any plugin.
8/9/2020, 5:23:03 AM Your config.json is requesting the platform "SamsungTVControl" which has not been published by any installed plugins.

Config:
{
            "platform": "SamsungTVControl",
            "devices": [
                {
                    "usn": "uuid:0aba9501-00b4-1000-8d01-kjsfndkjakjdf",
                    "name": "Living Room TV"
                }
            ],
            "plugin_map": {
                "plugin_name": "homebridge-samsungtv-control"
            }
        }

How did you install homebridge and the plugin itself?

How did you install homebridge and the plugin itself?

I installed from the search plugin page. I did not use the command line.

I have the same issue. Have you been able to resolve this?

I also have the same issue. I am installing it through HOOBS on a Raspberry Pi.

I also have the same issue. I am installing it through HOOBS on a Raspberry Pi.

I'm having this problem as well

I could not reproduce the problem by now unfortunately.

@mmende : could it be that when installing the plugin via hoops, the old version of the plugin is installed (the one on homebridge-samsungtv-control, rather than the one on homebridge-samsungtv-control2) ?

Same issue here.  I do wonder if it's a naming issue, the old version vs. the new version?  Would love to get it resolved, not sure what else to try.

This is really strange. Did someone affected by this issue try starting homebridge in debug mode? There might be some error thrown by the plugin preventing homebridge from adding it and therefore not registering it...

I stopped hoobs and ran it in debut mode. Same error message:
"The requested platform "SamsungTVControl" was not registered by any plugin.
Your config.json is requesting the platform "SamsungTVControl" which has not been published by any installed plugins."

I just published version 2.0.0. Would be awesome if you guys could let me know if the problem still exists.


show skipped test results file only when using --all

With #728 being merged the script catkin_test_results will not be able to crawl the test results folder by default. Instead it uses the current directory (commonly the workspace root). This usually results in more xml files to be found which are not actually test result files.
Therefore this patch only outputs the skipped result files when the --all option is passed to reduce the verbosity of the tool.
@esteve @tfoote @wjwwood Please review.

+1

+1