[UI Issue] : Guides are not center aligned on Mobile View

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?

I am using Google Chrome.

It is on the Get Started Page

The Guide Section is not center aligned in Mobile View.

What changes are you suggesting?
The section should be center aligned.
It just works as a better UI element.
Additional information
No response

@TartejBrothers Thanks so much for opening this issue! ✨ You, or anyone else, are welcome to submit a PR with this fix. 💛

I will look into it.

@nguyenalex836 I fix the issue but unable to test it locally. Can you please respond to this discussion?

@TartejBrothers If you open that page on bigger screen, you'll get it that they don't want to block the card element text under 'Scroll to top' button.
This is what happens after you see it center aligned. Check the scroll to top (blue color) button blocking the text.

Hi @adsingh14! Regarding that discussion you linked, your question best be handled by our support team. Please reach out to them for assistance 💛

@nguyenalex836 Please read my reply regarding this issue in my previous reply.

@adsingh14 If thats the case then ok, but there are other places where this thing is not followed.
Example :

Thanks, @adsingh14! As I noted above and in the discussion you linked, your question regarding being unable to test this locally would best be handled by our support team. Please reach out to them for assistance 💛

@nguyenalex836 My question was also regarding the a11y, please check the images I shared. I was asking about it.

@nguyenalex836 My question was also regarding the a11y, please check the replied images above.

Thanks, @adsingh14! You are welcome to submit a PR with what you have, even if those changes will not look good in terms of a11y. If you add a note with your PR highlighting the issues you ran into related to a11y, our team can provide input on the best next steps 💛

@nguyenalex836 Please check out this PR. I hope the referenced issue will clarify the whole context in brief.


Implement transaction for i2c

Straightforward/naive implementation of embedded_hal's i2c transaction function.

Apologies for the late response. Thanks for this PR!


Store the original token in the claims

To be able to retrieve the original token from the claims and call collateral services, I would need the WsFederationAuthenticationHandler to add the original token to the claims.
Something like that (the first line comes from the existing implementation so that you see where I would do that):
var principal = Options.SecurityTokenHandlers.ValidateToken(token, tvp, out parsedToken);

if (parsedToken != null)
{
    ClaimsIdentity identity = principal.Identity as ClaimsIdentity;
    if (identity != null)
    {
        StringBuilder sb = new StringBuilder();
        var writer = XmlWriter.Create(new StringWriter(sb), new XmlWriterSettings
        {
            OmitXmlDeclaration = true
        });
        Options.SecurityTokenHandlers[parsedToken].WriteToken(writer, parsedToken);
        writer.Flush();
        identity.AddClaim(new Claim("access_token", Convert.ToBase64String(Encoding.UTF8.GetBytes(sb.ToString()))));
    }
}

Is it something that would interest you as a pull request (using an option of course)?

Sure
On Thu, Aug 10, 2017 at 9:00 AM epot<EMAIL_ADDRESS>wrote:

To be able to retrieve the original token from the claims and call
collateral services, I would need the WsFederationAuthenticationHandler to
add the original token to the claims.
Something like that (the first line comes from the existing implementation
so that you see where I would do that):
var principal = Options.SecurityTokenHandlers.ValidateToken(token, tvp, out parsedToken);
if (parsedToken != null)
{
ClaimsIdentity identity = principal.Identity as ClaimsIdentity;
if (identity != null)
{
StringBuilder sb = new StringBuilder();
var writer = XmlWriter.Create(new StringWriter(sb), new XmlWriterSettings
{
OmitXmlDeclaration = true
});
Options.SecurityTokenHandlers[parsedToken].WriteToken(writer, parsedToken);
writer.Flush();
identity.AddClaim(new Claim("access_token", Convert.ToBase64String(Encoding.UTF8.GetBytes(sb.ToString()))));
}
}
Is it something that would interest you as a pull request (using an option
of course)?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chrisdrobison/aspnetcore-wsfed/issues/17, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABu24ba18jjOvo3UWccJL2ZDNgKZ-JJoks5sWxsUgaJpZM4Ozjee
.

Awesome, it would avoid an ugly copy&paste :D. I will submit that asap.

Here we go, I submitted a PR. Let me know what you think of this first implementation.


Feature/oc 531 separate message brokers

SonarQube analysis reported 9 issues

 7 major
 2 info

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ProtocolRequestMessageListener.java#L49: Extract this nested try block into a separate method.
 RegisterDeviceMessageProcessor.java#L41: Make this IP "<IP_ADDRESS>" address configurable.
 ProtocolRequestMessageSender.java#L78: Reduce this anonymous class number of lines from 27 to at most 20, or make it a named class.

SonarQube analysis reported 9 issues

 7 major
 2 info

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ProtocolRequestMessageListener.java#L49: Extract this nested try block into a separate method.
 RegisterDeviceMessageProcessor.java#L41: Make this IP "<IP_ADDRESS>" address configurable.
 ProtocolRequestMessageSender.java#L78: Reduce this anonymous class number of lines from 27 to at most 20, or make it a named class.

SonarQube analysis reported 9 issues

 7 major
 2 info

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ProtocolRequestMessageListener.java#L49: Extract this nested try block into a separate method.
 RegisterDeviceMessageProcessor.java#L41: Make this IP "<IP_ADDRESS>" address configurable.
 ProtocolRequestMessageSender.java#L78: Reduce this anonymous class number of lines from 27 to at most 20, or make it a named class.

SonarQube analysis reported 23 issues

 20 major
 1 minor
 2 info

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ProtocolRequestMessageListener.java#L49: Extract this nested try block into a separate method.
 RegisterDeviceMessageProcessor.java#L41: Make this IP "<IP_ADDRESS>" address configurable.
 ProtocolRequestMessageSender.java#L78: Reduce this anonymous class number of lines from 27 to at most 20, or make it a named class.
 Iec61850GetConfigurationCommand.java#L61: Reduce this anonymous class number of lines from 135 to at most 20, or make it a named class.
 Iec61850PowerUsageHistoryCommand.java#L52: Reduce this anonymous class number of lines from 23 to at most 20, or make it a named class.
 Iec61850SetConfigurationCommand.java#L52: The Cyclomatic Complexity of this method "apply" is 32 which is greater than 10 authorized.
 Iec61850SetConfigurationCommand.java#L157: Reduce the number of conditional operators (6) used in the expression (maximum allowed 3).
 Iec61850SetLightCommand.java#L61: Reduce this anonymous class number of lines from 25 to at most 20, or make it a named class.
 Iec61850SetScheduleCommand.java#L82: Reduce this anonymous class number of lines from 137 to at most 20, or make it a named class.
 Iec61850SetScheduleCommand.java#L157: The Cyclomatic Complexity of this method "writeScheduleEntryForRelay" is 11 which is greater than 10 authorized.

Retest this please.

SonarQube analysis reported 23 issues

 20 major
 1 minor
 2 info

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ProtocolRequestMessageListener.java#L49: Extract this nested try block into a separate method.
 RegisterDeviceMessageProcessor.java#L41: Make this IP "<IP_ADDRESS>" address configurable.
 ProtocolRequestMessageSender.java#L78: Reduce this anonymous class number of lines from 27 to at most 20, or make it a named class.
 Iec61850GetConfigurationCommand.java#L61: Reduce this anonymous class number of lines from 135 to at most 20, or make it a named class.
 Iec61850PowerUsageHistoryCommand.java#L52: Reduce this anonymous class number of lines from 23 to at most 20, or make it a named class.
 Iec61850SetConfigurationCommand.java#L52: The Cyclomatic Complexity of this method "apply" is 32 which is greater than 10 authorized.
 Iec61850SetConfigurationCommand.java#L157: Reduce the number of conditional operators (6) used in the expression (maximum allowed 3).
 Iec61850SetLightCommand.java#L61: Reduce this anonymous class number of lines from 25 to at most 20, or make it a named class.
 Iec61850SetScheduleCommand.java#L82: Reduce this anonymous class number of lines from 137 to at most 20, or make it a named class.
 Iec61850SetScheduleCommand.java#L157: The Cyclomatic Complexity of this method "writeScheduleEntryForRelay" is 11 which is greater than 10 authorized.

SonarQube analysis reported 23 issues

 20 major
 1 minor
 2 info

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ProtocolRequestMessageListener.java#L49: Extract this nested try block into a separate method.
 RegisterDeviceMessageProcessor.java#L41: Make this IP "<IP_ADDRESS>" address configurable.
 ProtocolRequestMessageSender.java#L78: Reduce this anonymous class number of lines from 27 to at most 20, or make it a named class.
 Iec61850GetConfigurationCommand.java#L61: Reduce this anonymous class number of lines from 135 to at most 20, or make it a named class.
 Iec61850PowerUsageHistoryCommand.java#L52: Reduce this anonymous class number of lines from 23 to at most 20, or make it a named class.
 Iec61850SetConfigurationCommand.java#L52: The Cyclomatic Complexity of this method "apply" is 32 which is greater than 10 authorized.
 Iec61850SetConfigurationCommand.java#L157: Reduce the number of conditional operators (6) used in the expression (maximum allowed 3).
 Iec61850SetLightCommand.java#L61: Reduce this anonymous class number of lines from 25 to at most 20, or make it a named class.
 Iec61850SetScheduleCommand.java#L82: Reduce this anonymous class number of lines from 137 to at most 20, or make it a named class.
 Iec61850SetScheduleCommand.java#L157: The Cyclomatic Complexity of this method "writeScheduleEntryForRelay" is 11 which is greater than 10 authorized.


Tone.connect does not seem to work

The Tone.connect method isn't listed in the doc. However I did find the method doc by navigating to the url directly (https://tonejs.github.io/docs/14.7.39/fn/connect).
As you can see in this fiddle, I can't seem to connect a native gain node to a Tone gain. If I understand, the Tone.connect method's purpose is to connect a native audio node to a tone node, right?

As long as that context is wrapped in the standardized-audio-context wrapper (so don't take the private property _nativeContext) then that's how it should work. Tone.connect still requires the same AudioContext and in the situation that you've given, it's actually a subtly different AudioContext. Tone.context.rawContext is an instance of StandardizedAudioContext and Tone.context.rawContext._nativeContext is an instance of the browser's native AudioContext.
If you'd like to connect things up in the latter way, then you'd have to use Tone.setContext(yourNativeAudioContext), but you'd lose all of the benefits of standardized-audio-context's cross-browser compatibility.
so to modify your code so that it works would look like this:
const toneNativeAudioContext = Tone.getContext().rawContext;
const nativeGain = toneNativeAudioContext.createGain()
console.log(nativeGain instanceof AudioNode)
Tone.connect(nativeGain, new Tone.Gain());

nativeGain instanceof AudioNode now would return false, but if that's an important check you could use std-audio-context's isAnyAudioNode instead.

Thanks for the answer.
My use case involves an AudioWorkletNode. Unsurprisingly, the browser throws an error when attempting to create an AudioWorkletNode with a StandardizedAudioContext: new AudioWorkletNode(Tone.getContext().rawContext, 'someName');
I see that tone solves this problem with https://tonejs.github.io/docs/14.7.39/Context#createAudioWorkletNode. However, I'm using a custom AudioWorkletNode, e.g. class CustomAudioWorkletNode extends AudioWorkletNode { ... }. Is this feature currently supported? If not, does a workaround come to mind?

I think Edit 3 is the approach that i'd recommend. Here's a small example which is working well for me and seems to be pretty readable.

@tambien As I said, Edit 3 will work, as long as the AudioContext it uses comes from the same standardized-audio-context "audio context store". Imagine a scenario where you are installing a library that exports a 'CustomAudioWorkletNode". If this library uses a different version of standardized-audio-context, it will not be possible to connect CustomAudioWorkletNode to any other tone node, because they are originating from two different audio context stores. The solution to that would be to add "standardized-audio-context" as a peerDependency instead of a dependency. This might have already been clear to you, but I just wanted to make sure I explained the problem fully. Whatever you decide is fine with me, I am in control of the other said library, so I can add standardized-audio-context as a peer dep of this other library. But that might not always be the case for other people. Cheers!


java.lang.IllegalArgumentException: Unknown meta type 14

I have a spigot + forge 1.12.2 server on travertine bungee setup and it is kicking players with this error:
https://pastebin.com/9RZahSq4
Anyone could fix this?

There is an option in waterfall.yml to disable entity metadata rewriting


feat: Label workflow-created pvc with workflow name

Checklist:
I've created an enhancement proposal and discussed it with the community.

@jamhed this PR looks good - but it is old - do you still want it?

@alexec yep, i'd like to, i'll update soon.

@alexec I think I don't have rights to dismiss the review.


Remove ligo dependency

Remove dependency from ligo.skymap from fancy.
We generate a try/except within allskymap.py and raise an import error if it is not installed. Further pytest will skip running this test if ligo.skymap is not installed.

This solves issue https://github.com/cescalara/fancy/issues/31 and solves the merge request https://github.com/cescalara/fancy/pull/32

Closing as already included in #34


Fix lstrip, rstrip, and split so they don't call pony_throw

lstrip, rstrip, and split were relying on Array.find(), which was causing them to unnecessarily call pony_throw.  This change fixes that.  I've updated Array.contains() so it doesn't need to call pony_throw and rely on that instead.

Actually, this is incomplete, because Array.contains() calls pony_throw.  I will update soon.

So these are performance enhancements, correct?

Yes.
On Sun, Jun 26, 2016 at 7:25 AM, Sean T Allen<EMAIL_ADDRESS>wrote:

So these are performance enhancements, correct?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ponylang/ponyc/pull/976#issuecomment-228596548, or mute
the thread
https://github.com/notifications/unsubscribe/AEgtzO9ehy4s-Gs59BFMFf9N4ibeT7uoks5qPmGrgaJpZM4I-aEG
.


fiat password does have the character '!'

Good morning.
I'm trying to set up docker under jeedom.
The installation and configuration is well done.
On the other hand, in the logs, I have these error messages.
My fiat password does have the character '!'. At first glance, this seems to be a problem, right?
2024-09-28T08:00:45.620089581Z PHP Warning:  syntax error, unexpected '!' in ./fiat.cfg on line 9
2024-09-28T08:00:45.620138051Z  in /fiat/fiat_mqtt.php on line 194
2024-09-28T08:00:45.620093422Z 2024-09-28 10:00:45 reading config file './fiat.cfg'
2024-09-28T08:00:45.620159702Z 2024-09-28 10:00:45 GoogleApiKey is empty, unable to translate location address
2024-09-28T08:00:45.621450311Z PHP Notice:  Trying to access array offset on value of type bool in /fiat/fiat_mqtt.php on line 128
2024-09-28T08:00:45.621501016Z PHP Notice:  Trying to access array offset on value of type null in /fiat/fiat_mqtt.php on line 128
2024-09-28T08:00:45.621519804Z PHP Notice:  Trying to access array offset on value of type bool in /fiat/fiat_mqtt.php on line 128
2024-09-28T08:00:45.621532724Z PHP Notice:  Trying to access array offset on value of type null in /fiat/fiat_mqtt.php on line 128
2024-09-28T08:00:45.621468121Z 2024-09-28 10:00:45 forked child with pid 8
2024-09-28T08:00:45.621545366Z PHP Notice:  Trying to access array offset on value of type bool in /fiat/fiat_mqtt.php on line 128
2024-09-28T08:00:45.621558636Z 2024-09-28 10:00:45 child is starting subscriber for executing commands
2024-09-28T08:00:45.621561080Z PHP Notice:  Trying to access array offset on value of type null in /fiat/fiat_mqtt.php on line 128
2024-09-28T08:00:45.621595442Z PHP Fatal error:  Uncaught TypeError: Argument 1 passed to apiFiat::__construct() must be of the type string, null given, called in /fiat/fiat_mqtt.php on line 128 and defined in /fiat/fiat_vehicle/api.php:59
2024-09-28T08:00:45.621609271Z Stack trace:
2024-09-28T08:00:45.621621144Z #0 /fiat/fiat_mqtt.php(128): apiFiat->__construct()
2024-09-28T08:00:45.621631690Z #1 /fiat/fiat_mqtt.php(221): fiat_get_data()
2024-09-28T08:00:45.621650687Z #2 {main}
2024-09-28T08:00:45.621666961Z   thrown in /fiat/fiat_vehicle/api.php on line 59
2024-09-28T08:00:45.621684072Z PHP Notice:  Trying to access array offset on value of type bool in /fiat/fiat_mqtt.php on line 64
2024-09-28T08:00:45.625267451Z PHP Notice:  Trying to access array offset on value of type null in /fiat/fiat_mqtt.php on line 28
2024-09-28T08:00:45.625328004Z PHP Notice:  Trying to access array offset on value of type null in /fiat/fiat_mqtt.php on line 28
2024-09-28T08:00:45.625267451Z 2024-09-28 10:00:45 MQTT connection failed: Argument 1 passed to PhpMqtt\Client\MqttClient::__construct() must be of the type string, null given, called in /fiat/fiat_mqtt.php on line 28
2024-09-28T08:00:45.625352379Z 2024-09-28 10:00:45 Exception catched: Call to a member function subscribe() on null

here is my fiat.cfg file
[mqtt]
server =<IP_ADDRESS>
port =1883
username =XXXXXX
password =rXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXR

[fiat]
username =USERNAME
password =!PASSWORD!
PIN =PIN
sleep =300
sleep_charging =60

thank you for your help!

Hi,
is your password enclosed with '"'? Please try something like this:
password = "my_password!"

I changed my password without '!'. The connection seems to be working fine, but now it seems to be unable to connect to my mqtt broker. I checked the settings, and they are fine though.
any idea of the problem?
2024-09-28T08:30:20.035817036Z 2024-09-28 10:30:20 reading config file './fiat.cfg'
2024-09-28T08:30:20.035902872Z 2024-09-28 10:30:20 GoogleApiKey is empty, unable to translate location address
2024-09-28T08:30:20.036993663Z 2024-09-28 10:30:20 forked child with pid 8
2024-09-28T08:30:20.037197322Z 2024-09-28 10:30:20 child is starting subscriber for executing commands
2024-09-28T08:30:20.044973661Z 2024-09-28 10:30:20 MQTT connection failed: [6] Establishing a connection to the MQTT broker failed: The configured broker responded with unauthorized.
2024-09-28T08:30:20.045001807Z 2024-09-28 10:30:20 Exception catched: Call to a member function subscribe() on null
2024-09-28T08:30:20.735254214Z PHP Deprecated:  This installation of the SDK is using PHP version 7.4.33, which will be deprecated on January 13th, 2025.
2024-09-28T08:30:20.735314837Z Please upgrade your PHP version to a minimum of 8.1.x to continue receiving updates for the AWS SDK for PHP.
2024-09-28T08:30:20.735359326Z To disable this warning, set suppress_php_deprecation_warning to true on the client constructor or set the environment variable AWS_SUPPRESS_PHP_DEPRECATION_WARNING to true.
2024-09-28T08:30:20.735374342Z More information can be found at: https://aws.amazon.com/blogs/developer/announcing-the-end-of-support-for-php-runtimes-8-0-x-and-below-in-the-aws-sdk-for-php/
2024-09-28T08:30:20.735388869Z  in /fiat/vendor/aws/aws-sdk-php/src/ClientResolver.php on line 1456
2024-09-28T08:30:21.629343487Z 2024-09-28 10:30:21 MQTT connection failed: [6] Establishing a connection to the MQTT broker failed: The configured broker responded with unauthorized.
2024-09-28T08:30:21.629397405Z 2024-09-28 10:30:21 MQTT publish failed: Call to a member function publish() on null
2024-09-28T08:30:21.629416122Z 2024-09-28 10:30:21 updated data for (ZFAEFAC45NX094438)
2024-09-28T08:30:22.045641159Z 2024-09-28 10:30:22 child is restarting subscriber for executing commands
2024-09-28T08:30:22.045984083Z 2024-09-28 10:30:22 MQTT connection failed: [6] Establishing a connection to the MQTT broker failed: The configured broker responded with unauthorized.
2024-09-28T08:30:22.046010343Z 2024-09-28 10:30:22 Exception catched: Call to a member function subscribe() on null
2024-09-28T08:30:24.046417471Z 2024-09-28 10:30:24 child is restarting subscriber for executing commands
2024-09-28T08:30:24.047106252Z 2024-09-28 10:30:24 MQTT connection failed: [6] Establishing a connection to the MQTT broker failed: The configured broker responded with unauthorized.
2024-09-28T08:30:24.047186290Z 2024-09-28 10:30:24 Exception catched: Call to a member function subscribe() on null
2024-09-28T08:30:26.047894506Z 2024-09-28 10:30:26 child is restarting subscriber for executing commands
2024-09-28T08:30:26.048136299Z 2024-09-28 10:30:26 MQTT connection failed: [6] Establishing a connection to the MQTT broker failed: The configured broker responded with unauthorized.
2024-09-28T08:30:26.048162979Z 2024-09-28 10:30:26 Exception catched: Call to a member function subscribe() on null
2024-09-28T08:30:28.048611522Z 2024-09-28 10:30:28 child is restarting subscriber for executing commands
2024-09-28T08:30:28.049086657Z 2024-09-28 10:30:28 MQTT connection failed: [6] Establishing a connection to the MQTT broker failed: The configured broker responded with unauthorized.
2024-09-28T08:30:28.049121508Z 2024-09-28 10:30:28 Exception catched: Call to a member function subscribe() on null

Looks like there are some issues with the authentication to your MQTT broker. Could you please try to surround your password with the sign "?
Are there maybe some other restrictions on the MQTT broker? Maybe you could try to setup the MQTT broker without authorization for testing.

It connects well without login and password by configuring mosquito like this
allow_anonymous true

do you think it is possible that it is compatible with ha/mqtt discovery?

Sorry, I'm French and I have bad English.
I already use HA for only this Fiatchamps add-on, but I would like to use only jeedom. That's why I'm very interested in your docker :-)

was able to reproduce your error authentication error with moquitto. This seems to be something inside mosquitto. So the only solution I found was to set "allow_anonymous true" what you have also find out. I found similar issues when doing a google search.
So from my side there is nothing I could fix.
Will close this issue.


Large file working copy handling on web

In the latest pre-release of GitHub Repositories, we support committing files via LFS: https://github.com/microsoft/vscode-remote-repositories-github/issues/7. This means GitHub Repositories (and soon vscode.dev) will become a zero-configuration Git LFS-capable client, which will make it easier to edit and commit to e.g. microsoft/vscode-docs without error (forgetting to install and set up LFS locally).
Currently, the likely workflows that users will use are:

the Upload... action from the explorer context menu to upload a file, then commit via SCM view
paste from clipboard into a markdown file, rename file if necessary, then commit via SCM view

In both these workflows, the user must first create a working copy in the workspace (managed by GitHub Repositories as an entry in IndexedDB via the extension context's global storage location and VS Code FS APIs) before committing. The problem with this is that we would store the full working copy of the file in the browser, and browsers are subject to unknown and potentially severe storage limitations. It seems quite likely that a user might unintentionally exhaust their browser storage limit in this way. Specifically:

FireFox browsers are limited to 50% of disk storage

a domain group (both vscode.dev and insiders.vscode.dev are one group) may use 20% of this global limit

There are separate limits for Chrome and it is possible to have a quota of 0

Note that this problem also occurs if a user happens to be editing a large file in vscode.dev with GitHub Repositories that is not LFS-tracked, so the problem is not LFS-specific and already exists today.

One suggestion was to implement some form of streaming upload gesture in the SCM view which would immediately commit and push an LFS file to the remote repository, bypassing having to write an LFS file to browser storage and only then commit it to the remote. However, this is incompatible with workflow number 2 above, which is a smooth workflow for adding both an image and a markdown link reference in one gesture, and is less natural as well. There are also UX issues, e.g. we would prompt the user for a commit message before making the commit.
I'm filing this issue to discuss how we can ensure that users who edit large files in vscode.dev with GitHub Repositories do not accidentally run out of browser storage. In particular:

Do we need a special setting on web for file size limits that is more conservative than the limit in desktop?
Do we handle the QuotaExceededError which is thrown when an origin exhausts the group origin policy even after group origin eviction has occurred? At minimum we should provide an error message, we can also suggest Reopen in Desktop with GitHub Repos which will at least circumvent the browser-imposed limit

Note: If the group limit is exceeded, or if origin eviction couldn't free enough space, the browser will throw a QuotaExceededError.

Ben, I assigned you to start because I see you are involved in related discussions https://github.com/microsoft/vscode/issues/172129 and https://github.com/microsoft/vscode/issues/167719, please let me know if I should reach out to someone else!

Yes this has to be handled by the FSP.
@bpasero May I know what is expected when there is not enough space on the disk for the FSP to write. For eg., what does node does in this cas?

Node.js will throw an error, probably directly passing it through from the lower level OS call. It is up to the caller of the method how to deal with the error.

@bpasero that setting is only observed for opening files today, would it make sense to observe it in the Upload action as well?

I am not sure, the setting is really only for editors opening, not so much general file IO transfer limitations. The original intent was to limit the possible network cost opening a large editor could have by accident because we immediately open a file when you click it. The setting is also called workbench.editorLargeFileConfirmation.
I think the file system provider should stat the file and refuse to do the operation if the available space is known to be exceeded

That makes sense. I think we can use navigator.storage.estimate--sadly Safari does not support. I am not sure how the performance of this API holds up though.
https://github.com/microsoft/vscode/blob/549d31a5d58387f68c38e053eb8e99e4288006bd/src/vs/platform/files/browser/indexedDBFileSystemProvider.ts#L284-L295
would instead be
async writeFile(resource: URI, content: Uint8Array, opts: IFileWriteOptions): Promise<void> {
	try {
		const existing = await this.stat(resource).catch(() => undefined);
		const estimated = await navigator?.storage?.estimate?.();
		const memoryLimit = (estimated?.quota ?? 0) - (estimated?.usage ?? 0);
		if (existing?.type === FileType.Directory) {
			throw ERR_FILE_IS_DIR;
		} if ((existing?.size ?? 0) > memoryLimit) {
			throw ERR_FILE_EXCEEDS_MEMORY_LIMIT;
		}
		await this.bulkWrite([[resource, content]]);
	} catch (error) {
		this.reportError('writeFile', error);
		throw error;
	}
}

Sure, feel free to open a PR, maybe consult with @sandy081 who I think owns this provider.


Problems need to be updated

Can you please update the problem set.

My internet connection is not that good , so It would be really helpful if
I could get the problem statement offline.
bhishma
On Thu, Dec 31, 2015 at 1:09 PM, Nemo<EMAIL_ADDRESS>wrote:

I might get around to it someday. Could you tell me what exactly are you
using this for?
—
Reply to this email directly or view it on GitHub
https://github.com/captn3m0/codechef/issues/2#issuecomment-168143949.

My internet connection is not that good , so It would be really helpful if
I could get the problem statement offline.
bhishma
On Thu, Dec 31, 2015 at 1:09 PM, Nemo<EMAIL_ADDRESS>wrote:

I might get around to it someday. Could you tell me what exactly are you
using this for?
—
Reply to this email directly or view it on GitHub
https://github.com/captn3m0/codechef/issues/2#issuecomment-168143949.

If you could tell how to update the repository, I'd be willing to send across a Pull Request to update the repository!

@salman-bhai Some steps may be missing:

Visit https://www.codechef.com/problems/easy (and other category pages)
Run something like copy($('.problemname a').toArray().map(function(x){return x.getAttribute('href')})) in the javascript console to get the entire problem list
Store this list in URLs subdirectory
Run wget --input-file to download everything in URLs/easy.txt into the PROBLEMS/EASY directory.
Repeat 1-4 for other categories
Take a complete backup at this point
Run strip.php (and modify it if needed). This script strips out the header/footer and other useless elements to improve problem file size.

Commit and file PR :+1:

I'll try this and let you know what happens!

Let me know if you face any issues :+1:

@salman-bhai Thinking of tackling this. Did you make any progress that I could continue on?

Umm no not really. KInda got stuck and then didn't really move on!

I'm interested in fixing this issue . Can you please help me in getting started .

@bhi5hmaraj See my comment above in this thread.

Working on this in #3, made some progress by shifting over the codechef API, except it seems to have rate-limiting and more checks in place.

Progress:
./vendor/bin/robo stats
➜  [school] Download Status: 112/112
➜  [easy] Download Status: 130/510
➜  [medium] Download Status: 136/535
➜  [hard] Download Status: 104/312
➜  [challenge] Download Status: 0/102

I'm going to be merging #3, since I took care to migrate old problems (so the new version has guaranteed more problems than there used to be)

Spent some more time only to realize that the codechef URL scheme is not consistent (no more rate limits). Haven't worked on challenge problems, but closing this for now:
./vendor/bin/robo  stats
➜  [school] Download Status: 112/112
➜  [easy] Download Status: 546/547
➜  [medium] Download Status: 546/546
➜  [hard] Download Status: 319/319
➜  [challenge] Download Status: 0/102


Can we read the uploaded text/csv file content before posting it to the server?

As we can show the uploaded image before posting it to the server, is there a way to read uploaded text/csv file before posting it to the server?
Any working example would be of great help.

Any update on this?

As we can show the uploaded image before posting it to the server, is there a way to read uploaded text/csv file before posting it to the server?
Any working example would be of great help.

Any update on this?


Run static checks on GitHub

This runs a number of static checks:

buildifier for Bazel files.
ruff for Python.
Two type checkers for Python: mypy and pytype. This may be excessive. There is also the problem that this does not give a good way of installing dependencies for type checking.

Two attempts to run type checking through Bazel, so that dependencies can be installed etc., are in #9 and #10. However, neither of them works at this stage.


unify Config generation, loading and updating

Describe your changes
There are 2 primary changes:

(misc) allows passing custom system service name (helps https://github.com/NixOS/nixpkgs/pull/287236 )
unifies configuration loading and updating into a single Config.apply(ConfigInput):

has better logging (informs of everything it does)
accepts both empty Config{} and empty InputConfig{} filling in missing parts automatically
handling was slightly inconsistent between createNewConfig() and update()
added InterfaceBlacklist to the InputConfig

Basically when I tried to start the netbird service run with just WgIface and WgPort present in config.json it crashed, so I got to fixing stuff :)
Issue ticket number and link

partially addresses #1562 by making incomplete configs acceptable (currently it segfaults on missing pointers/values)
to be used in https://github.com/NixOS/nixpkgs/pull/287236

Checklist

[x] Is it a bug fix
[ ] Is a typo/documentation fix
[x] Is a feature enhancement
[x] It is a refactor
[ ] Created tests that fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Note I was unable to run tests locally:
kdn@krul ~/d/g/n/netbird (fixups) [1]> go test -exec sudo ./...
package github.com/netbirdio/netbird/client/ui
        imports fyne.io/fyne/v2/app
        imports fyne.io/fyne/v2/internal/driver/glfw
        imports fyne.io/fyne/v2/internal/driver/common
        imports fyne.io/fyne/v2/internal/painter/gl
        imports github.com/go-gl/gl/v3.2-core/gl: build constraints exclude all Go files in<EMAIL_ADDRESS>

this commit seems to work on a live system https://github.com/netbirdio/netbird/pull/1586/commits/dcf9b84ee3360d7d1ba81976be9956e1623d4054

before
don't mind that jq error, it was still creating a file and starting:
Feb 15 09:44:54 krul (re-start)[420986]: netbird.service: ConfigurationDirectory 'netbird' already exists but the mode is different. (File system: 755 ConfigurationDirectoryMode: 700)
Feb 15 09:44:54 krul netbird-pre-start[420986]: created empty /var/lib/netbird/config.json
Feb 15 09:44:54 krul netbird-pre-start[420999]: jq: error: syntax error, unexpected '/', expecting end of file (Unix shell quoting issues?) at <top-level>, line 1:
Feb 15 09:44:54 krul netbird-pre-start[420999]: /var/lib/netbird/config.json
Feb 15 09:44:54 krul netbird-pre-start[420999]: jq: 1 compile error
Feb 15 09:44:54 krul netbird-pre-start[421001]: 0a1,4
Feb 15 09:44:54 krul netbird-pre-start[421001]: > {
Feb 15 09:44:54 krul netbird-pre-start[421001]: >   "WgIface": "wt0",
Feb 15 09:44:54 krul netbird-pre-start[421001]: >   "WgPort": 51831
Feb 15 09:44:54 krul netbird-pre-start[421001]: > }
Feb 15 09:44:54 krul systemd[1]: Started A WireGuard-based mesh network that connects your devices into a single private network.
Feb 15 09:44:54 krul (bird-wt0)[421033]: netbird.service: ConfigurationDirectory 'netbird' already exists but the mode is different. (File system: 755 ConfigurationDirectoryMode: 700)
Feb 15 09:44:54 krul netbird-wt0[421033]: 2024-02-15T09:44:54+01:00 INFO client/cmd/service_controller.go:24: starting Netbird service
Feb 15 09:44:54 krul netbird-wt0[421033]: panic: runtime error: invalid memory address or nil pointer dereference
Feb 15 09:44:54 krul netbird-wt0[421033]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0xf0997d]
Feb 15 09:44:54 krul netbird-wt0[421033]: goroutine 8 [running]:
Feb 15 09:44:54 krul netbird-wt0[421033]: net/url.(*URL).Hostname(...)
Feb 15 09:44:54 krul netbird-wt0[421033]:         net/url/url.go:1144
Feb 15 09:44:54 krul netbird-wt0[421033]: github.com/netbirdio/netbird/client/internal.UpdateOldManagementURL({0x16b78e8, 0xc0000e65f0}, 0xc0008266e0, {0xc00004a03a, 0x1c})
Feb 15 09:44:54 krul netbird-wt0[421033]:         github.com/netbirdio/netbird/client/internal/config.go:358 +0xfd
Feb 15 09:44:54 krul netbird-wt0[421033]: github.com/netbirdio/netbird/client/server.(*Server).Start(0xc000002480)
Feb 15 09:44:54 krul netbird-wt0[421033]:         github.com/netbirdio/netbird/client/server/server.go:109 +0x4e5
Feb 15 09:44:54 krul netbird-wt0[421033]: github.com/netbirdio/netbird/client/cmd.(*program).Start.func1()
Feb 15 09:44:54 krul netbird-wt0[421033]:         github.com/netbirdio/netbird/client/cmd/service_controller.go:59 +0x513
Feb 15 09:44:54 krul netbird-wt0[421033]: created by github.com/netbirdio/netbird/client/cmd.(*program).Start in goroutine 1
Feb 15 09:44:54 krul netbird-wt0[421033]:         github.com/netbirdio/netbird/client/cmd/service_controller.go:47 +0x315
Feb 15 09:44:54 krul systemd[1]: netbird.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Feb 15 09:44:54 krul systemd[1]: netbird.service: Failed with result 'exit-code'.
Feb 15 09:44:54 krul systemd[1]: netbird.service: Scheduled restart job, restart counter is at 1.

after
kdn@krul ~/d/g/n/nix-configs (main)> journalctl --since -5m -u netbird.service
Feb 15 12:35:10 krul systemd[1]: Stopping A WireGuard-based mesh network that connects your devices into a single private network...
Feb 15 12:35:10 krul netbird-wt0[647207]: 2024-02-15T12:35:10+01:00 INFO client/cmd/root.go:150: shutdown signal received
Feb 15 12:35:12 krul netbird-wt0[647207]: 2024-02-15T12:35:12+01:00 INFO client/cmd/service_controller.go:80: stopped Netbird service
Feb 15 12:35:12 krul systemd[1]: netbird.service: Deactivated successfully.
Feb 15 12:35:12 krul systemd[1]: Stopped A WireGuard-based mesh network that connects your devices into a single private network.
Feb 15 12:35:12 krul systemd[1]: Starting A WireGuard-based mesh network that connects your devices into a single private network...
Feb 15 12:35:12 krul netbird-pre-start[721471]: Comparing /var/lib/netbird/config.json with /var/lib/netbird/config.json.new ...
Feb 15 12:35:12 krul netbird-pre-start[721474]: 52c52
Feb 15 12:35:12 krul netbird-pre-start[721474]: <   "WgPort": 51820
Feb 15 12:35:12 krul netbird-pre-start[721474]: ---
Feb 15 12:35:12 krul netbird-pre-start[721474]: >   "WgPort": 51831
Feb 15 12:35:12 krul netbird-pre-start[721471]: Updating /var/lib/netbird/config.json ...
Feb 15 12:35:12 krul systemd[1]: Started A WireGuard-based mesh network that connects your devices into a single private network.
Feb 15 12:35:12 krul netbird-wt0[721477]: 2024-02-15T12:35:12+01:00 INFO client/cmd/service_controller.go:24: starting Netbird service
Feb 15 12:35:12 krul netbird-wt0[721477]: 2024-02-15T12:35:12+01:00 INFO client/cmd/service_controller.go:64: started daemon server: /var/run/netbird/sock
Feb 15 12:35:12 krul netbird-wt0[721477]: 2024-02-15T12:35:12+01:00 INFO client/internal/connect.go:95: starting NetBird client version 0.25.7
Feb 15 12:35:12 krul netbird-wt0[721477]: 2024-02-15T12:35:12+01:00 ERRO client/server/server.go:121: init connections: rpc error: code = PermissionDenied desc = no peer auth method provided, please use a setup key or interactive SSO login

moved service name flag out into https://github.com/netbirdio/netbird/pull/1691

FYI: this seems like a good standard for configurations https://uapi-group.org/specifications/specs/configuration_files_specification/


HHH-13466 : ClassCastException when changing a Collection association to a Set if @PreUpdate listener exists

https://hibernate.atlassian.net/browse/HHH-13466
The bug happens because an entity's reference to a PersistentCollection was modified to refer to a HashSet.
During flush, the pre-update listener is executed, DefaultFlushEntityEventListener#copyState detects a dirty collection because of this block, specifically this line:
( state[index] != newState[index] && !types[index].isEqual( state[index], newState[index] ) )
state[index] refers to the wrapped collection (PersistentBag);
newState[index] refers to the unwrapped collection (a Set), read from the entity after the pre-update listener executes.
The reason why types[index].isEqual( state[index], newState[index] ) == false  is because, in CollectionType#isEqual,  ( (PersistentCollection) x ).isWrapper( y ) ) == false.
PersistentBag#isWrapper returns false because it doesn't wrap the Set; instead it wraps a List with the elements that were extracted from the Set by the PersistentBag constructor.
The fix adds a new field to PersistentBag, providedCollection. which is explicitly provided to a PersistentBag constructor. This is the collection that is directly accessible to the application, so it makes sense that, if providedCollection is not null, then that is the Collection for which PersistentBag#isWrapper should return true, even if it was a Set that was provided.
Without this change, FlushVisitor#processCollection throws the CCE when it tries to cast the Set to a PersistentCollection.
I tried to find a way to look up the PersistentCollection from FlushVisitor#processCollection. Looking up the collection by CollectionKey won't work because it returns the original, unmodified collection. I also looked at iterating PersistentContext#getCollectionEntries values, but, its not possible to locate the PersistentCollection because PersistentCollection.isWrapper( collection ) returns false, for the same reason as above.

@sebersole, I'm going to close this and come up with a better solution.

Reopening because my other solutions were too complicated.

Superseded by https://github.com/hibernate/hibernate-orm/pull/2957


Feature/portal layout fix 2

Don't want all 15 commits this PR includes.  Will cherry-pick the needed commits into the release branch.


 Also
                # this introduces another dependency on astropy which may
                # not be desireable.
                from . import fits_embed
                return fits_embed.AsdfInFits._open_impl(fd, uri=uri,
                            validate_checksums=validate_checksums,
                            ignore_version_mismatch=self._ignore_version_mismatch,
                            extensions=self._extensions,
                            strict_extension_check=strict_extension_check,
                            ignore_missing_extensions=ignore_missing_extensions,
                            _extension_metadata=self._extension_metadata)
            except ValueError:
                raise ValueError(
                    "Input object does not appear to be an ASDF file or a FITS with " +
>                   "ASDF extension") from None
E               ValueError: Input object does not appear to be an ASDF file or a FITS with ASDF extension

This is also reported as astropy/astropy#8464, since a bugfix should not break other packages.

This is a bug but it is not related to astropy. Closing since it was fixed in https://github.com/spacetelescope/asdf/pull/649.

Also, fwiw asdf regularly tests against dev versions of astropy.

Ah, OK. That is a real coincidence: we had a test two days ago with the old version that succeeded.
Would it be possible to mark this test with @pytest.mark.remote_data? Somehow, it depends on remote access (even if it depends on a non-existence), and in Debian, we generally don't want to (try to) access outside services during test.


add a little detail to summit social location

Add a link to the website for the social location and add an emphasis that it is next to the convention center

/assign @jberkus


Add classifier support

Classifier is ignored for dependencies. It is not added to the manifest file.
As far as I see the following pattern works:
groupId:artifactId:version:classifier

Classifier support should be supported in latest version 1.2.0.


Request for Updated Link to Pre-Trained Model

Thank you for your work.
It seems that the link to the pre-trained model is unavailable. Could you provide an updated link or guide me on how to access the model? I’d really appreciate your help.
Thanks again!
Best regards.

Hi, are there any updates as to the model weights being provided. it would be a great help.

Same question here!

Same question here!

Thanks for your feedbacks and sorry for being late on this issue:
here is the updated model link:
https://drive.google.com/file/d/1seW8qSnaBOQ4_S9bQ4ThVOdeJGYJ-f74/view
thank you for your interests!

Thank you for sharing your awesome work!


Upgrade to latest version of threejs (r164.1)

Description
Upgrade to the latest version of ThreeJS
Version

model-viewer: v3.5.0

Browser Affected

[x] Chrome, version: xx.x.xxxx.xx
[x] Edge
[x] Firefox
[x] IE
[x] Safari

OS

[x] Android
[x] iOS
[x] Linux
[x] MacOS
[x] Windows

AR

[ ] WebXR
[ ] SceneViewer
[ ] QuickLook

A little be of context on why this point release is important would be nice... 😄

@elalish It adds support for the glTF extension KHR_materials_dispersion, so upgrading allows any models that use it to display properly in Google Model Viewer.

Excellent, thank you!


WIP: Introduce 'scope' field in key value model

TODO:

[X] GET on user scoped variables

[ ] Validate allowed scopes

[X] LIST on scoped variables

[ ] Validate allowed scopes

[ ] V2 APIs for scoped key value   ##access  ?
[ ] Backward compatibility tests

[ ] Migration script if needed

[ ] Tests
[ ] Docs
[x] CLI shows 400: Bad request but doesn't tell what is bad about the request
[ ] Changelog

Prefix based RBAC will be in another PR. Trying to scope things down.
CLI examples:
GET
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$ st2 key set company brocade     [ruby-1.9.3p484]
+------------------+---------+
| Property         | Value   |
+------------------+---------+
| name             | company |
| value            | brocade |
| expire_timestamp |         |
+------------------+---------+
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$ st2 key get company             [ruby-1.9.3p484]
+------------------+---------+
| Property         | Value   |
+------------------+---------+
| name             | company |
| value            | brocade |
| secret           | False   |
| encrypted        | False   |
| scope            | system  |
| expire_timestamp |         |
+------------------+---------+
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$ st2 key set boss lakstorm --scope=user
+------------------+----------+
| Property         | Value    |
+------------------+----------+
| name             | boss     |
| value            | lakstorm |
| expire_timestamp |          |
+------------------+----------+

## XXX: Get needs to be fixed so asking for something without scope "user" doesn't return it.

(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$ st2 key get boss                [ruby-1.9.3p484]
+------------------+----------+
| Property         | Value    |
+------------------+----------+
| name             | boss     |
| value            | lakstorm |
| secret           | False    |
| encrypted        | False    |
| scope            | user     |
| expire_timestamp |          |
+------------------+----------+
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$ st2 key set manas grump --scope=nsfw
ERROR: 400 Client Error: Bad Request
MESSAGE: Invalid scope "nsfw"! Allowed scopes are ['system', 'user']. for url: http://<IP_ADDRESS>:9101/v1/keys/manas

(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$

LIST
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$ st2 key list --scope=user       [ruby-1.9.3p484]
+------+-------+--------+-----------+------------------+
| name | value | secret | encrypted | expire_timestamp |
+------+-------+--------+-----------+------------------+
+------+-------+--------+-----------+------------------+
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$ st2 key list --scope=system     [ruby-1.9.3p484]
+------+-------+--------+-----------+------------------+
| name | value | secret | encrypted | expire_timestamp |
+------+-------+--------+-----------+------------------+
| foo  | bar   | False  | False     |                  |
+------+-------+--------+-----------+------------------+
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$ st2 key set boss lakstorm --scope=user
+------------------+----------+
| Property         | Value    |
+------------------+----------+
| name             | boss     |
| value            | lakstorm |
| expire_timestamp |          |
+------------------+----------+
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$ st2 key list --scope=user       [ruby-1.9.3p484]
+------+----------+--------+-----------+------------------+
| name | value    | secret | encrypted | expire_timestamp |
+------+----------+--------+-----------+------------------+
| boss | lakstorm | False  | False     |                  |
+------+----------+--------+-----------+------------------+
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$

@lakshmi-kannan What does st2 key list show? Would there be a scope column?

@manasdk Not yet
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●●)$ st2 key list                    [ruby-1.9.3p484]
+------+-------+--------+-----------+------------------+
| name | value | secret | encrypted | expire_timestamp |
+------+-------+--------+-----------+------------------+
| foo  | bar   | False  | False     |                  |
+------+-------+--------+-----------+------------------+
(virtualenv)vagrant@st2dev /mnt/src/storm/st2 (issue_167/user_scoped_vars●)$

I've added some in-line comments.
Overall, I'm fine with other changes, but as mentioned on Slack, I would remove v2 stuff from this PR.
I think we all need to get on the same page and have a consistent story for the v2 API so we don't need to deprecate v2 yet again in the near future when we plan to work on an improved API.
Also, what's our plan for RBAC here? Will this be done separately, or?

I would remove v2 stuff from this PR.

What is wrong with it? is the v2 API bad already?

@manasdk The problem is that it's a one off-thing.
We need a consistent story and plan for it (that means how paths are going to look like, responses, etc.). I'm fine with adding it as soon as we have a consistent story and plan for it, because then we can make sure this new v2 API follows all of those conventions.
Tomorrow I plan to start a discussion thread on v2 API and we can continue discussion about that there.

The problem is that it's a one off-thing.

Is it ad-hoc? Isn't this exactly the reason i.e. we are changing a model therefore need to have a new endpoint. I am fine with the discussion driving the impl and then coming around to picking up changes here but why would you suggest reverting the changes?

@manasdk Yes, and the same end result can be achieved using v1 API so I see no point in rushing v2 API until we have a clear picture on how we want it to look.

@manasdk @Kami : Removed v2 APIs here 67d7ed9

@Kami: > Also, what's our plan for RBAC here? Will this be done separately, or?
You should read the description sometimes before complaining everywhere.


Barcode detection algorithm issues

Issues:

Currently uppercase bases mismatch with lowercase and vice-versa; this could introduce a bug if the bases are capitalized differently
When converting from tagged BAM to FASTQ, we should check the PF flag to remove that reads

Improvements:

Option for do not count as mismatches the N bases
Allow only certain number of Ns in the barcode
Track the second best match and set a threshold for the minimum differences with respect to the best one
Output a MetricFile (from htsjdk) with an histogram with number of mismatches in the barcode and the final statistics for the de-multiplexing

Case-insensitive implementation of number of mismatches in commit e888fd11d15ed8fb74d1aa53153aeda8fd02a518

Added function to count mismatches both with and without taking into account Ns in commit 32881a87031bab7e9bcab88e2e9969de144ad6de (but not used in the tools yet)

Added metric file in aa1abc58b372056b1e3ee1126d4e8e1784d78e9d. It could be improved with a header.

Added option for allow only certain number of Ns in the barcode and new metrics in 9f8460b6a0e03a538901212c717d50b41a5e414d. Other thresholds are also included.

Added filter for reads that fails the vendor quality (PF flag) in TaggedBamToFastq in 7f7137e1f6ee1e67fdb3fc29779d4696ea9d8bfa

All the improvements are already implemented and included in release 0.1.3 and subsequent.


Env prompt: Escape sequences

Hello there!
Just an optical inconvenience...
Given following snippet:
export TYPE=[Guest type \(hyperv,proxmox,openstack\)]
export TARGET=[IP of waiting server]

Result:

The backslash-escape in front of the parentheses is required in bash. Runme should probably parse, sanitize and display these properly.

Thanks for reporting, @max06! We will get that fixed in the following weeks.

The cosmetic fix will go out with the next stable release, @max06.

Lovely, thanks a lot!


update Getting Started / Kubfelow on Kubernetes page

Many issues on kubeflow/kubeflow github project are created due to the default behaviour of kfctl init command which is fetching unstable master branch by default. Explicitly mentioning -v flag in Kubeflow Getting started documentation page will help to reduce this misunderstanding.

This change is

CLA signed :)

/assign @jlewi

Just found out that this commit is relevant to the versions prior to 0.5.1, in upcoming releases this kfctl behavior is fixed, see https://github.com/kubeflow/kubeflow/pull/3205

Do you want to add a note that if you are using kfctl v0.5.1 or later you don't need to set it?

@jlewi and @solovyevt Since this issue is no longer relevant in the latest versions of Kubeflow, shall we close this PR?

Based on my previous comment, I'm closing this PR, but please do re-open it if necessary.
/close


Add windows text-to-speech subsystem

This change makes small modifications to the TTS subsystem definition (most notably, the removal of configuration options, until a cross platform set can be determined) and adds a subsystem implementation for Windows standalone and UWP.

/azp run


cmake: linker: lld: add missing -no-pie flag

See also https://github.com/zephyrproject-rtos/zephyr/pull/38903
This is required when building tests for native_posix on ubuntu 22.04 using clang-14 from the normal deb repository.
Signed-off-by: Christian Taedcke<EMAIL_ADDRESS>

Hmm, I'm wondering if it's due some changes in clang or it was always broken?

The only thing i noticed is this issue did not occur with zephyr 3.1 using the same build environment. But i don't know for sure if lld was used there (using the default zephyr config when setting ZEPHYR_TOOLCHAIN_VARIANT=llvm).


Colours appear lighter on iOS compared to Android

Using the following example:
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      home: Scaffold(
        body: Center(
          child: FlatButton(
            color: const Color(0xFFFE9700),
            shape: StadiumBorder(),
            child: Text('Click me!'),
            onPressed: () {},
          ),
        ),
      ),
    ),
  );
}

We can see that the button is rendered with the correct colour FE9700 on Android:

But appears lighter, using colour F19B38 on iOS:

This may relate to an older issue -> #11410.

What Android device and version are you using? If it's a recent version, and you go into Settings -> Display -> Colors, what is that set to (Natural, Boosted, etc...)?

I've tested this on an emulated Pixel 3 and a physical Samsung S8, both running Android 9, neither have any colour boosting enabled, and the colours appear darker on both.

I believe I may of been incorrect about Android being at fault with this issue, I will rename it to "Colours appear lighter on iOS compared to Android" to better reflect the real issue.
After looking into the screenshots I attached to this ticket, I can see that Android is correctly rendering the button with the colour FE9700, however, iOS renders the button with the colour F19B38.
I've tested this on a Simulated iPhone XS, and a physical iPhone 6, both runnning the latest iOS 12.4

how can I set P3 colors on my flutter app (instead of sRGB), so I can achieve those vivid P3 colors please?

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-2.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-2.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision 15a28159bc (8 days ago), 2020-06-23 04:52:58 -0700
    • Engine revision 91a63d6a44
    • Dart version 2.9.0 (build 2.9.0-19.0.dev 7e72c9ae7e)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.1

[✓] Connected device (4 available)
    • SM M305F      • 32003c30dc19668f • android-arm64  • Android 10 (API 29)
    • macOS desktop • macos            • darwin-x64     • Mac OS X 10.15.5
      19F101
    • Web Server    • web-server       • web-javascript • Flutter Tools
    • Chrome        • chrome           • web-javascript • Google Chrome
      83.0.4103.116

• No issues found!

Still reproducible on 1.22.6. Even images appear lighter on iOS Physical Device! Most probably coz of Display P3?
Flutter 1.22.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 9b2d32b605 (2 weeks ago) • 2021-01-22 14:36:39 -0800
Engine • revision 2f0af37152

I really need display P3 for iOS soon. Are there any developments with this issue?

I can't stand the way colors look on Flutter apps compared to others, when Flutter will make a use of P3 color gamut? Can't wait!

Reproducible
IOS | MacOS | Android

flutter doctor -v (mac)
[✓] Flutter (Channel master, 3.7.0-3.0.pre.33, on macOS 12.6 21G115 darwin-arm64, locale en-IN)
    • Flutter version 3.7.0-3.0.pre.33 on channel master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (38 minutes ago), 2022-12-05 18:27:21 -0800
    • Engine revision a309d239c4
    • Dart version 2.19.0 (build 2.19.0-463.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly
      to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.55.20221129

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.94

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel stable, 3.3.9, on macOS 12.6 21G115 darwin-arm, locale en-IN)
    • Flutter version 3.3.9 on channel stable at /Users/mahesh/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (24 hours ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.53.20221101

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

If I'm reading this correctly, this is requesting display P3 wide gamut colors profile adoption, which is being tracked more specifically with https://github.com/flutter/flutter/issues/55092.  I'm going to forward duplicate this there since that issue is already being tracked for prioritization in a few places.
If there's more being tracked here than display P3 let us know and we'll reopen and refocus this.

This isn't actually a bug in Flutter per se, but we may be able to address it in Flutter.
Here is the sRGB reading for the Android image:

Here's the sRGB reading for the iOS image:

Notice that the Android screenshot isn't in the sRGB colorspace (it says "clipped").  This is, as Brian mentioned, a result of the Android device somewhere in the rendering pipeline beyond Flutter (Operating System, Driver, Display).  The iOS color almost matches the specified color.  The discrepancy ((255, 152, 1) vs (254, 151, 0)) is probably sampling/roundoff error when converting and capturing the screenshot.
The color mentioned in the description erroneously specifies the iOS color as F19B38, they sampled the color in Display P3 and manually converted the values to a hash value (implicitly converting it to sRGB incorrectly).
Sooo... this bug could potentially be fixed without adding support for Display P3 (what that means is another discussion).  It could be a matter of telling Android to somehow not extrapolate sRGB colors to Display P3 colors.  Some setting on the Androids drawing surface might be able to do that (for example, setting it to Display P3 and maybe explicitly converting the colors with a fragment shader?).   Implementing some support for Display P3 will potentially fix this issue though since the renderer would have to reserve the space for these extrapolated Display P3 colors with real Display P3 colors.

Thanks for looking into this more!

@brianosman I suspect this issue may be related to the EGL_GL_COLORSPACE setting of the surface provided by Skia.  It looks like Skia isn't setting that explicitly and the default value is EGL_GL_COLORSPACE_LINEAR.  I suspect setting EGL_GL_COLORSPACE to EGL_GL_COLORSPACE_SRGB will force our colors to be in the sRGB colorspace.  It sounds like EGL_GL_COLORSPACE_LINEAR may be extrapolating the colors into the Display P3 space where it is available.
I can try it out but it's going to take some time so I thought I'd pick your mind while I'm waiting on compilation.

Unfortunately, that setting won't address this issue. It's very poorly
named, and has nothing to do with gamut (which is the real problem here).
It primarily changes how blending works when drawing to the surface
(whether the values are encoded with the sRGB transfer function or not).
Newer Android API revisions do have the ability for apps to specify that
they operate in wide-gamut color, but it has to be controlled via Android
API https://developer.android.com/training/wide-color-gamut (it can't be
done at the GL or EGL level).
On Tue, Jan 3, 2023 at 7:29 PM gaaclarke @.***> wrote:

@brianosman https://github.com/brianosman I suspect this issue may be
related to the EGL_GL_COLORSPACE
https://registry.khronos.org/EGL/extensions/KHR/EGL_KHR_gl_colorspace.txt
setting of the surface provided by Skia. It looks like Skia isn't setting
that explicitly and the default value is EGL_GL_COLORSPACE_LINEAR
https://registry.khronos.org/EGL/extensions/EXT/EGL_EXT_gl_colorspace_display_p3.txt.
I suspect setting EGL_GL_COLORSPACE to EGL_GL_COLORSPACE_SRGB will force
our colors to be in the sRGB colorspace. It sounds like
EGL_GL_COLORSPACE_LINEAR may be extrapolating the colors into the Display
P3 space where it is available.
I can try it out but it's going to take some time so I thought I'd pick
your mind while I'm waiting on compilation.
—
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/39113#issuecomment-1370360888,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEMSDHUMYU2RZ2XLY7FAAXDWQS76VANCNFSM4IO6LQ5A
.
You are receiving this because you were mentioned.Message ID:
@.***>

I tried to reproduce the issue and set the operating system color to "boosted" and "adjusted" and got the same results as iOS on a Pixel 4a on Android 13:

So, this seems to suggest that the problem isn't universal across devices with the expanded color gamut.  Maybe it doesn't manifest on Android 13?
(I was able to verify that my device supports wide gamut colors in the Photos app with a test image.)
After reading Brian's article it seems like setting EGL_GL_COLORSPACE_KHR to EGL_GL_COLORSPACE_DISPLAY_P3_EXT may fix the issue.  But since I don't know what devices are affected and it doesn't manifest on my device it's not possible for me to test that theory.
This bug is unactionable until we are able to identify a device that can reproduce the issue.  @MichaelM97 @maheshmnj do you have info on what device you were seeing this on?  Does the problem persist with Android 13?
Engine hash
985f4ac51eb8edc8e009fb6582cfd03db47a9e1e
methodology

Take screenshot on android device
download the screenshot with adb
Open the image in Preview, verify the colorspace of the screenshot
Use Digital Color Meter to view the pixel color

@gaaclarke I was able to reproduce it on an Android emulator  Pixel 4 api 30 as can be seen in the below screenshot

I am also able to reproduce it on my physical device Android Xiaomi Redmi k20 pro (Android 11), But Surprisingly when I take a screenshot either by adb or flutter tool or screenshot from device and upload it here, I don't see the issue. The button has dark color only when viewing the screenshots or the actual app on my physical device.

Xiaomi Screenshot
flutter screenshot
adb screenshot

logs
mahesh@Maheshs-MacBook-Air-M1 flutter_issue % adb -s <IP_ADDRESS> shell screencap -p /sdcard/screen.png
mahesh@Maheshs-MacBook-Air-M1 flutter_issue % adb -s <IP_ADDRESS> pull /sdcard/screen.png
/sdcard/screen.png: 1 file pulled, 0 skipped. 0.9 MB/s (46295 bytes in 0.049s)
mahesh@Maheshs-MacBook-Air-M1 flutter_issue %


Run forest node in DigitalOcean

Summary of changes
Changes introduced in this pull request:

New terraform scripts that deploys and run Forest in the cloud.
Built to run with just a single command in terraform and ansible

Reference issue to close (if applicable)
Closes Issue #2422

I'll review the rest later; got a meeting to attend. It'd be fantastic if you ran the README through Grammarly or another typo/grammar checker. Also, I still see the .DS_Store files. Please remove them.
A general thing that came to my mind - this repository is supposed to hold all infrastructure code, so it'd be best to put all the changes related to the node under the forest_node directory. You can then link to it from the main README.

I do not think the .DS_Store still exists because I don't have it in my working branch. Also, I have moved the main forest_node details for installation to the right directory. However, I do not think there's a need to link it from the main readme; for sure, anyone who accesses the forest_node directory will see all the necessary details.


Improve Kona Micro gateway guide on configuration via the KonaFT tool

Summary
The Tektelic Kona Micro gateway can be configured to connect with The Things Stack via SSH access and the KonaFT tool.
Why do we need this?
Configuring the gateway via the KonaFT tool is the easiest way, and users can easily identify if the packet forwarder is running on the gateway or not.
What is already there? What do you see now?
The current documentation includes configuring the Kona Micro gateway to The Things Stack in LBS and UDP protocols via the SSH access method. Ref: https://www.thethingsindustries.com/docs/gateways/tektelickonamicro/udp/#connect-to-the-gateway
What is missing? What do you want to see?
Add steps to configure the gateway to connect with The Things Stack via the KonaFT tool.
How do you propose to document this?
Insights:
Note: Make sure to login to the support.tektelic.com portal before accessing the below-mentioned references/guides.
Step 1: Download the KonaFT application from the below reference and complete the installation.
Note: This tool can be installed on Windows Platforms only. Ref: https://support.tektelic.com/portal/en/kb/articles/konaft
Step 2: Connect your gateway to the KonaFT tool by watching the KFT_Connect video from the guide below.https://support.tektelic.com/portal/en/kb/articles/konaft-instructional-videos
Step 3: Assigning Static IP to Kona Gateway using KonaFT. Ref: https://support.tektelic.com/portal/en/kb/articles/assigning-static-ip-to-kona-gateway-using-konaft
Step 4: Configuring the Gateway to The Things Stack with Semtech UDP packet forwarder.
Note: This guide contains instructions for connecting gateway to The Things Network(V2). Here, you can update the server_address to The Things Stack address. Ref: https://support.tektelic.com/portal/en/kb/articles/the-things-network-commissioning-a-gateway
Can you do this yourself and submit a Pull Request?
No.

@nejraselimovic,
Yes. Currently, the KonaFT tool supports only UDP packet forwarder configuration. Ref: https://support.tektelic.com/portal/en/kb/articles/konaft


Failed to parse the given SQL

desc table t1 as `t2`
This sql is valid.

Please backport fix to 2.x release

Thank you @Okapist for reporting the issue. It's a bit surprising that alias can be used in desc statement :p
I'll create PR to fix this in 0.3.1, but I think we probably don't need to backport the fix to 0.2.x, because it's just a warning and the query will be sent to server anyway. Let me know if you think backport helps at your end.

We have a lot of this statements and it's generate a lot of unnecessary logs.
I saw in Roadmap that 3.x branch is technical and better to wait for 4.x. This is to long.

I see. There are two approaches to get rid of the annoying warnings: 1) increase log level to ERROR or at least do that for ClickhouseSqlParser; 2) change connection string by adding use_new_parser=false.
I'll backport the fix to 0.2.x branch and create a snapshot package.

@Okapist, you may check out code from 0.2.x branch and use mvn -DskipTests clean package to generate new package for the fix.


prisma format on 1:1 relationships adds unnecessary relation

Bug description
I have put the schema file in this gist: https://gist.github.com/Abrifq/b6646e3348871175870b5122a4002223
Basically, one-to-one relationships makes Prisma Formatter think there is no @relation on one side, so it thinks it should add one and then complain about there is two @relation pointing at each other and failing the format process.
How to reproduce

Download schema from the gist.
Run DEBUG="*" prisma format --schema="./schema.prisma"
Expect it to run correctly but see an error.
Expected behavior
Format should recognize the @relation at the *Description models, and count the relationship as linked, thus adding no more @relations.
I will also open another issue for triggers (for example, onDelete) being confused about which side it should be put on 1-to-1 relationships even though it shouldn't matter, when i can duplicate the problem with least amount of code. (Current code/schema is a bit too long)
Prisma information

Prisma schema is included in the gist, however here is a copy:

// This is your Prisma schema file,
// learn more about it in the docs: https://pris.ly/d/prisma-schema

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model Tester {
  TesterID String @id @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  Name     String @db.Text

  Ingredients TesterIngredients[]
  Description TesterDescription
}

model Ingredient {
  IngredientID   String @id @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  IngredientName String @db.Text

  UsedIn    TesterIngredients[]
  Description IngredientDescription
}

model IngredientDescription {
  IngredientID String @id @db.Uuid
  Description String @db.Text
  ImagePath String? @db.Text

  Ingredient Ingredient @relation(fields:[IngredientID],references:[IngredientID])
}

model TesterDescription {
  TesterID String @db.Uuid @id
  Description String @db.Text
  ImagePath String? @db.Text

  Tester Tester @relation(fields:[TesterID],references:[TesterID])
}

model TesterIngredients {
  TesterID String @db.Uuid
  IngredientID String @db.Uuid
  @@id([TesterID,IngredientID])

  Tester Tester @relation(fields:[TesterID],references:[TesterID])
  Ingredient Ingredient @relation(fields:[IngredientID],references:[IngredientID])
}

Environment & setup

OS: Ubuntu 21.10 based Linux Distro (Drauger OS), has openssl 1.1.x installed.
Database: Haven't come to apply the schema yet but it's PostgreSQL
Node.js version: Also included in the gist! v17.4.0

Prisma Version
prisma                  : 3.8.1
@prisma/client          : 3.8.1
Current platform        : debian-openssl-1.1.x
Query Engine (Node-API) : libquery-engine 34df67547cf5598f5a6cd3eb45f14ee70c3fb86f (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 34df67547cf5598f5a6cd3eb45f14ee70c3fb86f (at<EMAIL_ADDRESS>Introspection Engine    : introspection-core 34df67547cf5598f5a6cd3eb45f14ee70c3fb86f (at<EMAIL_ADDRESS>Format Binary           : prisma-fmt 34df67547cf5598f5a6cd3eb45f14ee70c3fb86f (at<EMAIL_ADDRESS>Default Engines Hash    : 34df67547cf5598f5a6cd3eb45f14ee70c3fb86f
Studio                  : 0.452.0

I suggest adding these labels to this issue:

topic: prisma-format
topic: relations
engines/data model parser
topic: schema validation
topic: schema file
tech/engines

Thanks for reporting this. We plan to revisit format at some point but unfortunately don't have a timeline just yet.

Here is a slightly cleaned up original schema that makes it easier to see the diff that formatting creates:
// This is your Prisma schema file,
// learn more about it in the docs: https://pris.ly/d/prisma-schema

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model Tester {
  TesterID String @id @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  Name     String @db.Text

  Ingredients TesterIngredients[]
  Description TesterDescription
}

model Ingredient {
  IngredientID   String @id @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  IngredientName String @db.Text

  UsedIn    TesterIngredients[]
  Description IngredientDescription
}

model IngredientDescription {
  IngredientID String @id @db.Uuid
  Description String @db.Text
  ImagePath String? @db.Text

  Ingredient Ingredient @relation(fields: [IngredientID], references: [IngredientID])
}

model TesterDescription {
  TesterID String @id @db.Uuid
  Description String @db.Text
  ImagePath String? @db.Text

  Tester Tester @relation(fields: [TesterID], references: [TesterID])
}

model TesterIngredients {
  TesterID String @db.Uuid
  IngredientID String @db.Uuid

  Tester Tester @relation(fields: [TesterID], references: [TesterID])
  Ingredient Ingredient @relation(fields: [IngredientID], references: [IngredientID])

  @@id([TesterID, IngredientID])
}

As prisma format itself fails with a validation error, you can use our VS Code extension's "Format Document" functionality to get the formatting result:
// This is your Prisma schema file,
// learn more about it in the docs: https://pris.ly/d/prisma-schema

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model Tester {
  TesterID String @id @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  Name     String @db.Text

  Ingredients               TesterIngredients[]
  Description               TesterDescription   @relation(fields: [testerDescriptionTesterID], references: [TesterID])
  testerDescriptionTesterID String              @db.Uuid
}

model Ingredient {
  IngredientID   String @id @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  IngredientName String @db.Text

  UsedIn                            TesterIngredients[]
  Description                       IngredientDescription @relation(fields: [ingredientDescriptionIngredientID], references: [IngredientID])
  ingredientDescriptionIngredientID String                @db.Uuid
}

model IngredientDescription {
  IngredientID String  @id @db.Uuid
  Description  String  @db.Text
  ImagePath    String? @db.Text

  Ingredient Ingredient @relation(fields: [IngredientID], references: [IngredientID])
}

model TesterDescription {
  TesterID    String  @id @db.Uuid
  Description String  @db.Text
  ImagePath   String? @db.Text

  Tester Tester @relation(fields: [TesterID], references: [TesterID])
}

model TesterIngredients {
  TesterID     String @db.Uuid
  IngredientID String @db.Uuid

  Tester     Tester     @relation(fields: [TesterID], references: [TesterID])
  Ingredient Ingredient @relation(fields: [IngredientID], references: [IngredientID])

  @@id([TesterID, IngredientID])
}

Validating that leads to the following with 5.14.0:
PS C:\Users\Jan\Documents\throwaway\1483> npx prisma validate --schema prisma/11480.prisma
Environment variables loaded from .env
Prisma schema loaded from prisma\11480.prisma

Error: Prisma schema validation - (validate wasm)
Error code: P1012
error: Error parsing attribute "@relation": The relation fields `Description` on Model `Tester` and `Tester` on Model `TesterDescription` both provide the `references` argument in the @relation attribute. You have to provide it only on one of the two fields.
  -->  prisma\11480.prisma:18
   |
17 |   Ingredients               TesterIngredients[]
18 |   Description               TesterDescription   @relation(fields: [testerDescriptionTesterID], references: [TesterID])
19 |   testerDescriptionTesterID String              @db.Uuid
   |
error: Error parsing attribute "@relation": The relation fields `Description` on Model `Tester` and `Tester` on Model `TesterDescription` both provide the `references` argument in the @relation attribute. You have to provide it only on one of the two fields.
  -->  prisma\11480.prisma:44
   |
43 |
44 |   Tester Tester @relation(fields: [TesterID], references: [TesterID])
45 | }
   |
error: Error parsing attribute "@relation": The relation fields `Description` on Model `Tester` and `Tester` on Model `TesterDescription` both provide the `fields` argument in the @relation attribute. You have to provide it only on one of the two fields.
  -->  prisma\11480.prisma:18
   |
17 |   Ingredients               TesterIngredients[]
18 |   Description               TesterDescription   @relation(fields: [testerDescriptionTesterID], references: [TesterID])
19 |   testerDescriptionTesterID String              @db.Uuid
   |
error: Error parsing attribute "@relation": The relation fields `Description` on Model `Tester` and `Tester` on Model `TesterDescription` both provide the `fields` argument in the @relation attribute. You have to provide it only on one of the two fields.
  -->  prisma\11480.prisma:44
   |
43 |
44 |   Tester Tester @relation(fields: [TesterID], references: [TesterID])
45 | }
   |
error: Error parsing attribute "@relation": A one-to-one relation must use unique fields on the defining side. Either add an `@unique` attribute to the field `testerDescriptionTesterID`, or change the relation to one-to-many.
  -->  prisma\11480.prisma:18
   |
17 |   Ingredients               TesterIngredients[]
18 |   Description               TesterDescription   @relation(fields: [testerDescriptionTesterID], references: [TesterID])
19 |   testerDescriptionTesterID String              @db.Uuid
   |
error: Error parsing attribute "@relation": The relation fields `Description` on Model `Ingredient` and `Ingredient` on Model `IngredientDescription` both provide the `references` argument in the @relation attribute. You have to provide it only on one of the two fields.
  -->  prisma\11480.prisma:27
   |
26 |   UsedIn                            TesterIngredients[]
27 |   Description                       IngredientDescription @relation(fields: [ingredientDescriptionIngredientID], references: [IngredientID])
28 |   ingredientDescriptionIngredientID String                @db.Uuid
   |
error: Error parsing attribute "@relation": The relation fields `Description` on Model `Ingredient` and `Ingredient` on Model `IngredientDescription` both provide the `references` argument in the @relation attribute. You have to provide it only on one of the two fields.
  -->  prisma\11480.prisma:36
   |
35 |
36 |   Ingredient Ingredient @relation(fields: [IngredientID], references: [IngredientID])
37 | }
   |
error: Error parsing attribute "@relation": The relation fields `Description` on Model `Ingredient` and `Ingredient` on Model `IngredientDescription` both provide the `fields` argument in the @relation attribute. You have to provide it only on one of the two fields.
  -->  prisma\11480.prisma:27
   |
26 |   UsedIn                            TesterIngredients[]
27 |   Description                       IngredientDescription @relation(fields: [ingredientDescriptionIngredientID], references: [IngredientID])
28 |   ingredientDescriptionIngredientID String                @db.Uuid
   |
error: Error parsing attribute "@relation": The relation fields `Description` on Model `Ingredient` and `Ingredient` on Model `IngredientDescription` both provide the `fields` argument in the @relation attribute. You have to provide it only on one of the two fields.
  -->  prisma\11480.prisma:36
   |
35 |
36 |   Ingredient Ingredient @relation(fields: [IngredientID], references: [IngredientID])
37 | }
   |
error: Error parsing attribute "@relation": A one-to-one relation must use unique fields on the defining side. Either add an `@unique` attribute to the field `ingredientDescriptionIngredientID`, or change the relation to one-to-many.
  -->  prisma\11480.prisma:27
   |
26 |   UsedIn                            TesterIngredients[]
27 |   Description                       IngredientDescription @relation(fields: [ingredientDescriptionIngredientID], references: [IngredientID])
28 |   ingredientDescriptionIngredientID String                @db.Uuid
   |

Validation Error Count: 10
[Context: validate]

Prisma CLI Version : 5.14.0

(Note how this is 2 more validation errors than provided in the Gist for Prisma 3.8.1)

In the diff above we could see that Tester.Description and Ingredient.Description were added by the formatting.
This only happens when we run formatting on the schema as it is, including validation errors:
PS C:\Users\Jan\Documents\throwaway\1483> npx prisma validate --schema prisma/11480.prisma
Environment variables loaded from .env
Prisma schema loaded from prisma\11480.prisma

Error: Prisma schema validation - (validate wasm)
Error code: P1012
error: Error parsing attribute "@relation": The relation field `Tester` on Model `TesterDescription` is required. This is no longer valid because it's not possible to enforce this constraint on the database level. Please change the field type from `Tester` to `Tester?` to fix this.
  -->  prisma\11480.prisma:43
   |
42 |
43 |   Tester Tester @relation(fields: [TesterID], references: [TesterID])
44 | }
   |

Validation Error Count: 1
[Context: validate]

Prisma CLI Version : 5.14.0

Following these instructions we end up with this schema:

// This is your Prisma schema file,
// learn more about it in the docs: https://pris.ly/d/prisma-schema

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model Tester {
  TesterID String @id @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  Name     String @db.Text

  Ingredients TesterIngredients[]
  Description TesterDescription?
}

model Ingredient {
  IngredientID   String @id @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  IngredientName String @db.Text

  UsedIn      TesterIngredients[]
  Description IngredientDescription?
}

model IngredientDescription {
  IngredientID String  @id @db.Uuid
  Description  String  @db.Text
  ImagePath    String? @db.Text

  Ingredient Ingredient @relation(fields: [IngredientID], references: [IngredientID])
}

model TesterDescription {
  TesterID    String  @id @db.Uuid
  Description String  @db.Text
  ImagePath   String? @db.Text

  Tester Tester @relation(fields: [TesterID], references: [TesterID])
}

model TesterIngredients {
  TesterID     String @db.Uuid
  IngredientID String @db.Uuid

  Tester     Tester     @relation(fields: [TesterID], references: [TesterID])
  Ingredient Ingredient @relation(fields: [IngredientID], references: [IngredientID])

  @@id([TesterID, IngredientID])
}

This schema is valid.
It seems that formatting is getting confused by these existing validation errors somehow, which causes it to try to add the other side of a relation. Instead we might want to automatically fix the actual problem.


afl-fuzz + ASAN: not detecting SIGSEGV from program with halt_on_error=0

I'm aware that halt_on_error=0 in ASAN is USE AT YOUR OWN RISK, but I know what I'm doing in this case and I actually do want my program to continue after an unsafe access.
I have a program with a known buffer-overflow. I have compiled this with ASAN and I am able to verify that the program aborts on a buffer-overflow with SIGABRT. In gdb I see:
Stopped reason: SIGABRT
__GI_raise (sig=sig@entry=0x6) at ../sysdeps/unix/sysv/linux/raise.c:51

On the command line, the program ends with the expected stacktrace and the message Aborted.
With halt_on_error=0, the program obviously does not crash on the buffer overflow, but I can eventually get it to crash due to the corruption from the buffer overflow (because of corrupted chunk metadata). In GDB I end up seeing something like this:
Stopped reason: SIGSEGV
0x00000000004e95ba in __asan::GetThreadContextByTidLocked(unsigned int) ()

On the command line, in this case, the program continues after the first stacktrace as expected, and then crashes with another stack trace (expected) and the message:
AddressSanitizer:DEADLYSIGNAL
AddressSanitizer: nested bug in the same thread, aborting.

Based on this I assumed that afl-fuzz would be able to see that the program crashes.
When running with afl-fuzz without the -C flag, with halt_on_error=1 and with an input that causes a buffer overflow, I get an appropriate error message saying that the input should not be one that causes an outright crash. This is because ASAN causes the program to abort. However, when doing the same thing but with halt_on_error=0 and with the same input that crashed the program in gdb, I find that afl-fuzz does not notice that the program has crashed. It will start up fine even with the crashing input.
Is there something in ASAN that is preventing afl-fuzz from handling the SIGSEGV in this particular case?
I'm pretty new to both afl and ASAN so it's also quite possible I'm just doing something wrong.
The commands I'm running are:
ASAN_OPTIONS=symbolize=0:abort_on_error=1:halt_on_error=0:log_path=./asan-log/asan.log ../afl-fuzz -i seeds -o asan-results -m none ./myprog

and
ASAN_OPTIONS=symbolize=0:abort_on_error=1:halt_on_error=1:log_path=./asan-log/asan.log ../afl-fuzz -i seeds -o asan-results -m none ./myprog

I figured out the issue. In afl-fuzz.c there is this bit of code in the run_target function:
  /* Report outcome to caller. */

  if (WIFSIGNALED(status) && !stop_soon) {

    kill_signal = WTERMSIG(status);

    if (child_timed_out && kill_signal == SIGKILL) return FAULT_TMOUT;

    return FAULT_CRASH;

  }

  /* A somewhat nasty hack for MSAN, which doesn't support abort_on_error and
     must use a special exit code. */

  if (uses_asan && WEXITSTATUS(status) == MSAN_ERROR) {
    kill_signal = 0;
    return FAULT_CRASH;
  }

With halt_on_error=1 ASAN will issue a SIGABRT (with exit code 134 as expected) when it detects a heap buffer overflow. This is caught by the first if. With halt_on_error=0 and with the program eventually crashing, I'm not entirely sure why the SIGSEGV doesn't make it out. Instead I'm seeing an exit code of 1 from ASAN. To get around this, I added exitcode=86 to my ASAN_OPTIONS. This flag allows you to set a custom exit code for ASAN. As 86 is the value of MSAN_ERROR, the second if applies and the crash gets properly reported.
Seems kind of hacky, but I was able to get it to work this way.


content length attributes not set when ignoreNetworkEvents is true

What happened?
Steps to Reproduce

Open the examples/opentelemetry-web/examples/fetchexample
Start example
Note that the GET event has a http.response_content_length attribute
Add the ignoreNetworkEvents: true config to the FetchInstrumentation in the index.js file
Run example
Note that the GET event no longer has a http.response_content_length attribute

Expected Result
http.response_content_length attribute should still be present even if ignoreNetworkEvents is set to true
Actual Result
http.response_content_length is not present when ignoreNetworkEvents is set to true.
Additional Details

OpenTelemetry Setup Code
const provider = new WebTracerProvider({
  resource: new Resource({
    [SEMRESATTRS_SERVICE_NAME]: 'fetch-web-service'
  }),
  // Note: For production consider using the "BatchSpanProcessor" to reduce the number of requests
  // to your exporter. Using the SimpleSpanProcessor here as it sends the spans immediately to the
  // exporter without delay
  spanProcessors:[
    new SimpleSpanProcessor(new ConsoleSpanExporter()),
    new SimpleSpanProcessor(new OTLPTraceExporter()),
  ]
});

provider.register({
  contextManager: new ZoneContextManager(),
  propagator: new B3Propagator(),
});

registerInstrumentations({
  instrumentations: [
    new FetchInstrumentation({
      ignoreNetworkEvents: true,
      ignoreUrls: [/localhost:8090\/sockjs-node/],
      propagateTraceHeaderCorsUrls: [
        'https://cors-test.appspot.com/test',
        'https://httpbin.org/get',
      ],
      clearTimingResources: true,
    }),
  ],
});

const webTracerWithZone = provider.getTracer('example-tracer-web');

package.json
No response
Relevant log output
No response
Operating System and Version
Mac M3 Pro, macOS Sonoma 14.4
Runtime and Version
Node v18.20.4
Chrome v131.0.6778.86

Looks like this wasn't tracked before https://github.com/MustafaHaddara made https://github.com/open-telemetry/opentelemetry-js/pull/4706  @MustafaHaddara is there any way you can take a look at this?


BSC Erigon

Cloud you say what repo do you use to run erigon bsc node?

https://github.com/binance-chain/bsc-erigon
Make sure you are on the bsc branch.

Thank you.
I tried, but it doesn’t work for me.
I’m on bsc branch, but it doesn’t get blocks. Always show me - got 0 blocks…
Could you share arguments which you are using ?

Sounds interesting! Thank you.
Going to try it and closing this issue

FYI, I am having some issues with some asserts happening. Others have also reported this issue here:
https://github.com/binance-chain/bsc-erigon/issues/17
I am instead trying to use ledgerwatch's checkout here:
https://github.com/ledgerwatch/erigon/commit/4819ee1545c874a87165d3334e15094133324abc
The commands should be the same.
This is the second time I've hit this assert in 4 days and both happened around the same spot.

btw,
I still use ./erigon --datadir ./data  --chain bsc and after 2-3 hours it started to write the blocks.


add '-!' to stop greddy consumption for slice flags.

Coverage increased (+0.001%) to 85.5% when pulling 43dc02e89dcf57b33abce3d60b7520ede47dd871 on stop-consumption into 46d5fc1f3ad582bc923a2a0819ff128a63b37171 on master.


Build binaries for Linux, Windows, and macOS for every release

This creates lychee binaries for every release.
See #59 for more info.
Created a fake release here to show how the output looks like.
Some notes:

mips builds are not supported by ring at the moment, which is a sub-dependency. reqwests has support for rustls through a feature flag, but I doubt that it supports mips either.
With around 26 minutes, the windows builds take the longest time. (2-3x as long as macOS and Linux.) I don't know why this is; the compile step is just slower. ¯_(ツ)_/¯
Introducing a feature flag for using vendored openssl as it prevents headaches with the OpenSSL shared library on Linux.
Adding openssl-sys as direct dependency. This allows us to pass the vendored-openssl feature flag to this dependency and compile openssl from source.
Using<EMAIL_ADDRESS>to pull in the tag name from a release. This allows us to create a new release from the Github UI while the pipeline can still detected the respective tag for a release.

Going ahead and merging this to unblock #64. We can always revisit this pipeline and fix any potential issues.


Add a new contributor and fix markup

Add Deex Iv
Fix errors of markup

@DeexIv, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


About the mean and std of I3D (inception-v1)?

At test_configs/I3D_RGB/i3d_kinetics400_3d_rgb_inception_v1_seg1_f64s1.py, I find out the mean and std is
 img_norm_cfg = dict(     mean=[123.675, 116.28, 103.53], std=[58.395, 57.12, 57.375], to_rgb=True)
But in the source repo kinetics-i3d, whose ReadMe.md tells that:

From the RGB data, we added 1 and then divided by 2 to rescale between 0 and 1.

It seems the mean and std not match.
The mean and std of inception-v1 should be [128,128,128], [128,128,128], which may be mixed with the mean and std of Resnet-50.

Thanks for pointing out the bug, I will provide a fix PR.


Fix some test files lint errors.

Codecov Report

Merging #1378 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1378   +/-   ##
======================================
  Coverage    81.5%   81.5%
======================================
  Files          17      17
  Lines        1692    1692
  Branches      321     321
======================================
  Hits         1379    1379
  Misses        246     246
  Partials       67      67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ead679...7e22338. Read the comment docs.

Just fyi, we don't run lint against tests/ folder. Personally i don't care codestyle in unit tests, but i'm not oppose to it and if we wanna fix those, can we bring up a PR for addressing them all once ? (since i saw a similar PR before)

@yunstanford I fixed all tests lint error.
@ahopkins, first I fix them with autopep8 and then check it and change them by hand