[ Feature Request ] Ability to add discord RPC & to Connect to external apps's rpc data!

hello! its been a while! i've been using the bot alot it has helped alot! but i was wondering if it would be possible to add discord rpc to this?
ofc custom one would be good. but i was more of looking towards if it would somehow will read/listen to external application's rpc stuff
for example - for youtube music - https://github.com/th-ch/youtube-music , they have a discord rpc plugin. i was hopping if TEAS can somehow get that rpc info and run its own instance of rpc as well?
if this is possible then it builds a bridge to allow 2 types of rpc types - 1. custom rpcs , 2 - ability to read other application's rpc or connect to external app's plugin data or something!
i wonder for vlc and other media players there would be a rpc for it ig? so it would be good if its possible to connect to that!
or maybe just a lastfm integration will help alot ig? and for thumbnail or something ( if the above stuff is possible to connect to external apps somehow. then that would solve it ig? )

i tbh idk how the ytmusic app does the rpc stuff. since i dunno much bout coding. if possible could you take a lookie on their repo on how their rpc stuff works etc? maybe we can find a way to achieve this or so? ig?
do lmk if this is possible or not~ thank you ✨
hope you do enjoy your day ahead! happy Monday!

i did make sure to ask in the youtube-music's repo if this was possible
ref - https://github.com/th-ch/youtube-music/discussions/1798

Cross posting my answer to linked discussion:

You can have an arRPC server running locally!
Sadly TheEpicAudioStreamer needs to support arRPC, which ain't hard to do.
They just have to listen for messages from ws://<IP_ADDRESS>:1337 and update the bot's rich presence based on them.

Note: Normal discord may conflict with arRPC, might need some testing.

Since this project looks stagnant (1 year of inactivity), I may make a PR later this day.

Thanks for crossposting! ✨

Hi there!

Since this project looks stagnant (1 year of inactivity).

Now that's a little harsh @ArjixWasTaken :P Still very much here and keeping an eye on TEAS, I just didn't feel like there was much to do on it recently just waiting for it to either implode again because of a Discord API change or because someone reports a bug/requests a feature. :)
Rich Presence support definitely sounds interesting and a cool feature for the bot to have. I'm happy to read into it (and how DSharpPlus handles it) and add support for it to receive those RPC messages from arRPC. Might be a week or two though as I'm currently a little busy.

Oh that's great!
Totally understandable, some projects don't need constant updates.

Just a small update here, this is still in the works and I was finally able to pick up the project again a couple of days ago. It will likely be another few weeks before I can release the new version as I'm trying to also get a couple of other (QoL) improvements in that I've had in mind for a while, but it's coming. :)

So kinda good news bad news situation here. The good news is that I finally managed to get everything done that I wanted to do before starting on this feature request and was excited to get going here.
The bad news is (and I probably should have researched this earlier) that, as it turns out, bots on Discord cannot use rich presence - it's a user feature only. Unless, @ArjixWasTaken you know more than I'm able to find here, you seemed to be confident that it was possible?
Again some good news is that as part of the other features I was working on, I already implemented the ability to define a custom activity that the bot will display ("Playing "). And while it's not as pretty as a rich presence, this might be at least somewhat of a workaround. Mind that this is static and will not update at runtime unfortunately.
I'm happy to be told I'm wrong and that bots can in fact use rich presence, but otherwise I'll likely release the update as it is now over the next couple of days.

I also did not consider that, yikes!
I am not familiar with the code-base here, but a self-bot (a bot using a real user account) would work fine.
The problem is, you may get that user account banned if discord decides to take action on it. (they rarely do)

Thanks for your input! Yeah DSharpPlus does not support self-bots and I don't think that would be a good idea for this application anyway given that it would make it fairly volatile (and against ToS) for a relatively small benefit.

I've just released version 0.7.0 and will close this issue for now, but more than happy to revisit if the situation changes in the future.


Facebook account requestFBToken Proxy using

Hello,
Help me, @pulviscriptor Agar.io is patched, requestFBToken for max 2 account in max 1 ip.
Learn to me please requestFBToken.agent
Good Work.

Maybe examples/auth_token.js will help

lol i just tested with 3 acc on same ip and it worked fine???

@LostCodesy
Check examples/socks.js there you can see how to use agents.

@pulviscriptor yes but I think I need to https ?

@LostCodesy
For client i tested only SOCKS, i'm sure SOCKS will work for your needs too. I don't know about HTTP/HTTPS, you need to test yourself to find out.

Lol, I got 700 working tokens, all requested fine and when my bots use it, I get the bots, so u might want to change IP or something

@SrNicolas me have 5,000 working proxies but not working disconnect in agario.
Please give me a working facebook bot and me give you Facebook Cookie Checker , Oke?

Ok
Add me to skype and we talk: nicolasdelito

@SrNicolas i added, my skype = greenskypark

@SrNicolas Add me to skype


Add "Contribution Graphs for GitHub" by @AnderGoig

[x] Project URL: https://github.com/AnderGoig/github-contributions-ios
[x] Update contents.json instead of README
[x] One project per pull request
[x] Screenshot included
[x] Avoid iOS or open-source in description as it is assumed
[x] Use this commit title format if applicable: Add app-name by @github-username
[x] Use approved format for your entry

Thx, should be merged soon!


colab运行报错

报错信息如下，如何解决？
有社群吗？
--------uuid:  qw
----------work_dir:  /tmp/qw/ly261666/cv_portrait_model/person1
2023-09-23 14:17:59,031 - modelscope - INFO - Use user-specified model revision: v1.0.0
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/gradio/queueing.py", line 388, in call_prediction
output = await route_utils.call_process_api(
File "/usr/local/lib/python3.10/dist-packages/gradio/route_utils.py", line 219, in call_process_api
output = await app.get_blocks().process_api(
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1437, in process_api
result = await self.call_function(
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1109, in call_function
prediction = await anyio.to_thread.run_sync(
File "/usr/local/lib/python3.10/dist-packages/anyio/to_thread.py", line 33, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
return await future
File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 807, in run
result = context.run(func, *args)
File "/usr/local/lib/python3.10/dist-packages/gradio/utils.py", line 650, in wrapper
response = f(*args, **kwargs)
File "/content/facechain/app.py", line 489, in run
prepare_dataset([img['name'] for img in instance_images], output_dataset_dir=instance_data_dir)
File "/content/facechain/facechain/train_text_to_image_lora.py", line 193, in prepare_dataset
image = get_rot(image)
File "/content/facechain/facechain/train_text_to_image_lora.py", line 144, in get_rot
ort_session = onnxruntime.InferenceSession(model_path)
File "/usr/local/lib/python3.10/dist-packages/onnxruntime/capi/onnxruntime_inference_collection.py", line 432, in init
raise e
File "/usr/local/lib/python3.10/dist-packages/onnxruntime/capi/onnxruntime_inference_collection.py", line 419, in init
self._create_inference_session(providers, provider_options, disabled_optimizers)
File "/usr/local/lib/python3.10/dist-packages/onnxruntime/capi/onnxruntime_inference_collection.py", line 451, in _create_inference_session
raise ValueError(
ValueError: This ORT build has ['AzureExecutionProvider', 'CPUExecutionProvider'] enabled. Since ORT 1.9, you are required to explicitly set the providers parameter when instantiating InferenceSession. For example, onnxruntime.InferenceSession(..., providers=['AzureExecutionProvider', 'CPUExecutionProvider'], ...)

I don't speak chinese and came here just by mistake actually :sweat_smile:
But seeing the error - I had the same problem.
Just open facechain/text_to_image_lora.py and change like 144 to ort_session = onnxruntime.InferenceSession(model_path,providers=onnxruntime.get_all_providers()) and it will work - until you run in the runtime-error "context already set" tho...

把onnxruntime的版本由1.16.0改成1.15.0


AttributeError: module 'tensorflow.python.keras.api._v2.keras.preprocessing.text' has no attribute 'text_dataset_from_directory'

Describe the bug
Unable to load the function text_dataset_from_directory. I have installed tensorflow 2.2 and keras
Expected behavior
Not able to load the function.
Environment:
OS:  Windows 10
Python version - 3.8.2

I installed tf - nightly as well, but still unable to resolve issue. I am not sure if am missing anything. Please help me on this.


v2 Search Results

[x] make search results return on each keystroke rather than button click. Was sort of working here because of the document selector, but would only show first value

[x] Can't click off of the search result - must select after searching to jump back to playlist

[x] Would like to add the mouseover pointer to a hand for the search results

Any next steps here? @mlm603


chore(deps): upgrade jenkins-x/jx3-pipeline-catalog to version 3.2.317

from: https://github.com/jenkins-x/jx

/close


Add 'Showcase' section to the site

Preview:

Images have already been run through ImageOptim.

@addyosmani ladies and gents :clap:

:+1: lgtm

@sgomes any opposition to landing this?

Nope, LGTM. Thanks,@addyosmani!

:sake:


unresolved symbols for generated API

For some reason RA is unable to resolve two imported symbols from another module while cargo check (and vim+RA as well) says all is good. Both of these symbols are provided by a proc macro. Strange thing is that these symbols are used from other parts of the code too but RA doens't complain about those.
The version of RA in both VS Code and vim are the same: df0936b4a 2021-08-02 stable

You will need to set "rust-analyzer.experimental.procAttrMacros": true in your vscode config. Otherwise proc macro attributes are not expanded.

You will need to set "rust-analyzer.experimental.procAttrMacros": true in your vscode config. Otherwise proc macro attributes are not expanded.

yeah I know. It's enabled. Is it relevant though? Before this attribute was introduced, there was no errors, just that completion won't work for attribute macros. Also, how come the other usage is fine but RA only complains about these two in this one file?

Seems related to https://github.com/rust-analyzer/rust-analyzer/issues/9782

Before this attribute was introduced, there was no errors, just that completion won't work for attribute macros.

That's unlikely to be true; the unresolved import diagnostic has existed for almost a year now.

Before this attribute was introduced, there was no errors, just that completion won't work for attribute macros.

That's unlikely to be true; the unresolved import diagnostic has existed for almost a year now.

I guess I misremember then. :shrug:

I reset my VScode settings/extentions etc and now I can't reproduce this issue.


Cannot Find in plug-in repo through octoprint and receiving this error when attempting to install manually.

ERROR: Command errored out with exit status 1:
command: /home/pi/oprint/bin/python2 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-aiJiO3/lxml/setup.py'"'"'; file='"'"'/tmp/pip-install-aiJiO3/lxml/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-aiJiO3/lxml/pip-egg-info
cwd: /tmp/pip-install-aiJiO3/lxml/
Complete output (3 lines):
Building lxml version 4.6.2.
Building without Cython.
Error: Please make sure the libxml2 and libxslt development packages are installed.
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
Error!
Could not parse output from pip, see plugin_pluginmanager_console.log for generated output

You're running Python 2, which isn't supported. Therefore you're unable to see it in the repo.
See this blog post on how to upgrade to Python 3.

You're running Python 2, which isn't supported. Therefore you're unable to see it in the repo.
See this blog post on how to upgrade to Python 3.

Thank you, I upgraded to Python 3 and now I can see the plug-in in the repo and was able to click it to install. It runs through the install, says it was successful, then prompts to reboot. When I do and the pi reboots and I log back in I cant find the plug in. When I look at plug in manager it shows its installed but then I look at the repo to install and the plugin is still listed to be installed as if I never did anything. I've tried multiple times. I've been able to install other plug-ins today so not sure what's going on now.


BIGTOP-2480: Fix occasional timeout on hadoop-processing Juju bundle

During test runs, we are sometimes seeing the bundle test timeout during the initial deploy on slow clouds. GCE in particular is slow to deploy (but is faster once deployed, go figure).
There is a feature of the bundletester tool which can be used to increase the deployment timeout.

@johnsca  is this still valid?  It's not clear to me how 00-deploy is doing anything different than 01-deploy.py is doing with its d.setup and wait_for_messages calls:
https://github.com/apache/bigtop/blob/master/bigtop-deploy/juju/hadoop-processing/tests/01-bundle.py#L37

@kwmonroe Yes, the motivation behind this change is still valid but there is now another, cleaner way to get the same result.
The difference between 00-deploy and 01-bundle is that the former is being used as a pre-deploy step (line 2 in tests.yaml).  This lets us override the timeout of the initial deploy and at the time of this PR's submission was the only way to do so.  juju-solutions/bundletester#50 has since been released, however, so we could replace 00-deploy and the bundle_deploy option with the deployment_timeout option.
I can update this PR, or close and submit a new one.
Oh, and I also think its worthwhile to rev the charms to the most recent versions, yes?

Let's kill this JIRA/PR @johnsca.. I've added deployment_timeout to the bundle refresh jira, which already bumped charm revnos:
https://issues.apache.org/jira/browse/BIGTOP-2550
Code:
https://github.com/juju-solutions/bigtop/blob/feature/BIGTOP-2550/bundle-to-xenial/bigtop-deploy/juju/hadoop-processing/tests/tests.yaml#L2
--- a/bigtop-deploy/juju/hadoop-processing/tests/tests.yaml
+++ b/bigtop-deploy/juju/hadoop-processing/tests/tests.yaml
@@ -1,4 +1,5 @@
 reset: false
+deployment_timeout: 3600
 packages:
   - amulet
   - python3-yaml


TypeError: Zotero.ItemPaneManager.registerInfoRow is not a function

Debug log ID
DIKURQSY-fio-StSwGVoIrkT7
What happened?
Since the last update, the add-on sends this message error:
TypeError: Zotero.ItemPaneManager.registerInfoRow is not a function
It comes when I start Zotero, and I cannot use Zotero in TexStudio anymore.
After some tests, I figured out that this message appears each time I deactivate and activate Better BibTex for Zotero add-on in Zotero.
I then saw that there had been an update and connected the dots.
Thanks for your help and for this very useful add-on!

Zee #3092


Installation for CUDA 11 issues

Hi, I need to work with CUDA 11, so I investigated on how to do that
(PyTorch3D seemed to be really picky about the Python/PyTorch version):
Here's the sequence of commands before running this repo's scripts
conda create -n mcmr python=3.8
conda activate mcmr
conda install -c pytorch pytorch=1.10.0 torchvision cudatoolkit=11.3 -c conda-forge
conda install -c fvcore -c iopath -c conda-forge fvcore iopath
conda install -c bottler nvidiacub
conda install -c pytorch3d pytorch3d
python -m pip install opencv-python
python -m pip install imageio
python -m pip install lpips
python -m pip install tensorboard
python -m pip install meshzoo
python -m pip install scikit-image
python setup_softras.py build develop

Tested on Ubuntu20.04, with CUDA 11.4 on a docker
I place the sequence of commands I used in case others find it useful

Just one remark about tensorboard, since on this setup https://github.com/aimagelab/mcmr/issues/6#issue-1224079249:
when testing https://github.com/aimagelab/mcmr#22-cub I get:
Traceback (most recent call last):
  File "/home/robotics/object_pose_detection/mcmr/main.py", line 16, in <module>
    from torch.utils.tensorboard import SummaryWriter
  File "/home/robotics/conda/envs/mcmr/lib/python3.8/site-packages/torch/utils/tensorboard/__init__.py", line 4, in <module>
    LooseVersion = distutils.version.LooseVersion
AttributeError: module 'distutils' has no attribute 'version

since for the moment I don't needed I just commented the offending line from torch.utils.tensorboard import SummaryWriter

Related PR https://github.com/pytorch/pytorch/pull/69904

Hi @AlbertoRemus , thanks for reporting the issue and finding solution for it!
@alexj94 btw, can we remove the dependency from tensorboard and simply use torch.utils.tensorboard instead?


[TFLite] Enable int64 biases for int16 quantized operators

This enables int64 biases for quantized fully connected, requantize and transpose convolution in TFLite networks. It goes on top of existing int16 support for TFLite frontend.
cc @areusch for reviews

Hello @leandron,
I'm working on similar lines & have a model with conv2d_transpose & all the other ops are already supported from your already merged commit. I've made the same changes you've done for conv2d_transpose from this patch, but the dequantize layer at the end is getting int64 input which isn't right. Am I missing something that needs to be changed?
Thanks in advance!

Hello @leandron,
I'm working on similar lines & have a model with conv2d_transpose & all the other ops are already supported from your already merged commit. I've made the same changes you've done for conv2d_transpose from this patch, but the dequantize layer at the end is getting int64 input which isn't right. Am I missing something that needs to be changed?
Thanks in advance!

In TFlite as of now, biases are set by default to be int64 when int16 quantisation is used.
I have this model which was created using the default int16 flow, and can be used to check these internal data types with e.g. Netron

Please have a another look.

Sorry for the delay - thanks @leandron 😸


Add entry option for hybrid workshops

https://github.com/carpentries/community-facilitators-program/issues/40#issue-1158379425

This PR would need additional work before accepting/merging, but before we consider this I wanted to check with @sheraaronhurt --- would we consider the option of offering hybrid online/inperson workshops, or would we want hosts to pick one or the other?

@maneesha let me get back to you on this. Will have a response soon :)

At a recent workshop admin team meeting, we agreed we would not be offering hybrid workshops, so I am closing this issue now.  We can reconsider this if things change.


Build: Warning Fixes

Fixed Warnings:
Some where real issues and some where Analyzer Bugs so I suppressed them

@inforithmics Sorry, my attempt to resolve the conflict caused dotnet format to fail. This would be easier to fix for me if your branch was in the main mapsui repository.


Can't build AspNetCore source with VS 2019 RTM

When I follow the instructions in docs/BuildFromSource.md and run .\restore.cmd it tells me that I don't have the correct version of Visual Studio 2019 installed"
The screenshot below shows I have Visual Studio Community 2019 16.0 RTM installed.

If I run .\eng\scripts\InstallVisualStudio.ps1 -Edition Community as suggested by the error message in the screenshot above; it launches the the Visual Studio Installer and tries to modify my existing installation of Visual Studio Community 2019 16.0 RTM.
Currently Visual Studio Community 2019 16.0 RTM is the same as Visual Studio Community 2019 Preview 5

At the moment the only way to get around this Visual Studio version check in .\restore.cmd is to install Visual Studio Community 2019 Preview 5 as the check seems to be looking for a preview version.
N.B. Before I installed Visual Studio Community 2019 16.0 RTM when I ran .\eng\scripts\InstallVisualStudio.ps1 -Edition Community it wanted to install Visual Studio Community 2019 Preview 5
Going forward are we going to be getting any more Preview versions of Visual Studio 2019 now that it has RTM'd or will it be the RTM version plus subsequent servicing updates?

I think VS2019 RTM (incl. Community Edition) are all you should need. But perhaps there's a bug in the setup scripts, which we will investigate.

Fixed with https://github.com/aspnet/AspNetCore/pull/9057

Thanks, @natemcmaster !

Hi,
Sorry but this isn't fixed.
I have just updated my AspNetCore fork so I'm currently even with master.

I have run .\restore.cmd and I'm still getting the same error:

Re-opening for @natemcmaster to take a look at

And did you run InstallVisualStudio.ps1 ?

I must apologise - my bad.  I did run InstallVisualStudio.ps1 -Edition Community and it loaded up the VS Installer with my original VS 2019 RTM installation showing the following workloads were installed:

ASP.NET and web development
.NET  desktop development
Desktop development with C++
Visual Studio extension development
.NET Core cross-platform development

It appeared like that I had everything installed; but I didn't.
I have re-run the command and since noticed the Modify button!  I have just installed 53 missing packages!  Obviously the workloads I had were using the default set of components and they have been customised to include more than the default.


properly ci_tools.txt in run_X step templates

And eliminate unnecessary setuptools that is immediately discarded in favor of newer.

/check-enforcer override


getopt illegal option --o

Hello,
I really would like to use your software on one of the datasets. Can it run on MacOS? I installed it successfully, but when I call InPACT -h
the error 'getopt illegal option --o' kept popping up. I tried to remove -o from the 'InPACT' script, but now I get another error:
error: argument --annotation_file: expected one argument
although I'm sure that I put only one argument after -a in InPACT call.
Any suggestions?

Hello!
Thank you for raising this issue. The getopt command under MacOS defaults to the FreeBSD version, which is different from the GNU/Linux version. To resolve this, you can install the GNU version of getopt and specify its path in script. Here’s how you can do it:

Install GNU getopt using Homebrew

brew install gnu-getopt

Specify the path of GNU getopt in script

#!/bin/bash

GETOPT=/xxx/bin/getopt
ARGS=`$GETOPT XXX`

We hope this helps you resolve the issue. If it doesn't work, we recommend running it on Linux. If you have any further questions, feel free to ask.
Thank you,
Liu


serve.dev via https

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[X] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior
Currently the seed is served thru http.
Expected behavior
To access some features (e.g. MediaDevices) the app has to be served thru https, so that for ex. mobile phones can use those features the via the running dev instance.

Here's a way to approach:

With flags pass path to the certificate and run browsersync in TLS mode.

@g-schmitz would you want to open a PR? The issue is low priority so, unfortunately, it's not something I'll be able to start working on in near future.

Just for the ones that need a quick solution:
Use something like local-ssl-proxy in the meantime.
https://www.npmjs.com/package/local-ssl-proxy

Lets close the issue for now. local-ssl-proxy seems reasonable for dev purposes.


OS X (Snow Leopard) - Cannot view log

Using Sublime Text 2 Build 2126
This works a treat on my Ubuntu netbook, but on OS X when I try to view the log for a file, I get no popup, and the following in the console:
Exception in thread Thread-1:
Traceback (most recent call last):
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/threading.py", line 522, in __bootstrap_inner
    self.run()
File "./git.py", line 77, in run
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/subprocess.py", line 595, in __init__
    errread, errwrite)
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/subprocess.py", line 1106, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

I have a similar problem, but without this error message in the console. If I try to view the log "Git Log All", or "Git Status" or whatever, I get no popup or another output. Sometimes I get the error message "unrecognized button type 7" in the console.
But the git command (in the terminal) works.
Here's a litte demonstration video: http://cl.ly/2V0m3A2Y341q1l1X0r0t

Just as a data-point, I don't have this problem with status or log
Snow Leopard (10.6.8), git <IP_ADDRESS>, Sublime Text 2 (Build 2126) with Package Control
Could it be tied to the version of git?

@atavistock - oooh good point.  I'm on git <IP_ADDRESS> on Snow Leopard, where it's not working... and on <IP_ADDRESS> on my Ubuntu box where it's working fine.
Not sure I'll be able to update git this afternoon, but will look into getting that done as soon as I can and report back as to whether or not that's resolved the issue.
Thanks!

The problem seems to be due to the git version 1.7.7 (for me). After a downgrade to the git version <IP_ADDRESS> it works.

This error happens when git isn't in the PATH available to python. This seems to happen because some ways of installing git put it somewhere which isn't accessible on the default non-login-shell path.
I've committed 899e414 which provides an error message explaining this error.
There's a setting to provide an explicit path to your Git binary which can help with that.

@kemayo - Added the Git.sublime-settings to my User package with the path to my Git binary for git_command.  Pulled 899e414 and it worked.
Thanks!


Adding 1000-sans and 10000-sans, fixing minor cert-generator bug

An obvious attempt to up my github lines-of-code count.

I picture you saying to yourself this morning:

Today, I will be dark green on Github.

Mostly I'm just daydreaming about pulling ahead of @lgarron in the Contributor Race.  :D

An obvious attempt to up my github lines-of-code count.

I dare say someone's feeling too lazy to generate SANs programatically! :-P
Do these crash Chrome, et al. even if the cert is invalid? If so, I'd like to find a way to serve it from badssl.com
(Extra credit: convince a CA to sign this for us.)

I mean, I generated the list of SANs with a program, so I'm obviously not that lazy!  I just didn't want to deal with the hassle of creating temporary files, removing them, having git ignore them, etc.
On the 10000-sans page, Chrome will spit up this error:

So it doesn't really matter if it's valid in that sense, to see Chrome rejecting things.  The 1000-san one does work, and would obviously generate an error with Chrome, being self-signed and all.
Your CA should sign these: there's nothing in the RFC that specifies an upper bound to the number of SANs that a certificate can contain.

I just didn't want to deal with the hassle of creating temporary files, removing them, having git ignore them, etc.

Process substitution?
I don't mind the current approach, but it would be nice if it were trivial to generate certs with 1023 or 100,000 SANs using the same code.

I'll be happy to put in the effort should be there be enough demand for it.  I just don't think it's worth it at the moment, is it?
#!/usr/bin/env python

import sys

if len(sys.argv) != 2:
    print sys.argv[0] + ' <number of sans>'
    sys.exit(1)

print 'DNS.1 = ' + str(sys.argv[1]) + '-sans.badssl.com'

for i in range(2, int(sys.argv[1]) + 1):
    print 'DNS.' + str(i) + ' = wowmoarhost' + str(i) + '.badssl.com'

I just don't think it's worth it at the moment, is it?

I'd prefer it, but I guess there's some value in having the cert sources hard-coded so that they're straightforward to look at.

@lgarron I could try to get Let's Encrypt to sign it, I have a beta invite for my hoverbear.org domain. :)

@lgarron, any chance we could merge this PR?  I've got another site to work on that will also require changes to the certificate generator, and I'd like to let you avoid the hassle of merging resolution.  :)

@lgarron, any chance we could merge this PR? I've got another site to work on that will also require changes to the certificate generator, and I'd like to let you avoid the hassle of merging resolution. :)

Hey, hey, give this millennial a good night's sleep and let them roll out of bed before poking. :-P
(Will look at outstanding PRs now.)

:point_right: :sleeping:
:point_right: :sleeping:
:point_right: :sleeping:
:point_right: :sleeping:
:point_right: :sleeping:


one single .so?

Hi,
This is definitely a great tool. Is it possible to package everything into one dynamic library file ".so"? Currently a package contains quite a few ".so"s.
Thanks.

Hi,
Maybe you need the pyinstaller to do this, or use gcc to combine the .a files into one .so

No worries if this feature is not in your development plan. Just out of curiosity. Thanks again for the tool.


clear the provisioning state when inspection is done

"Ready" means it is available to be used, so I used None as an intermediate step between this and inspection.

I rebased this and updated the new state to ready instead of none.

I think this is going to be obsolete, based on the discussion we had yesterday about moving state management out of the drivers and into Reconcile().


Improve enzyme declarations

Fixes chaining to have correct types instead of any, adds missing API methods and declares named exports correctly for Flow >= v0.28

cc @turadg (who wrote the original) for general review

LGTM, thanks!

I should have tested this before replying, but I just tried this out with Flow 0.28 and I get a bunch of this error,
property `length`. Property not found in ShallowWrapper

My temp work-around is to add the prop to Wrapper,
    length: number;

Any better solution?

@turadg right, that's not documented in itself but seems to be in the code and the first example here implies it's available, so I think it's a good idea to get that merged in as well :smile:


getting startDate and endDate data in seperate arrays using range picker

const date = ref(); is displaying both startDate and endDate. Can i seperate this into 2 arrays with one just displaying startDate and the other displaying endDate. Much appreciated
<template>

  <Datepicker v-model="date" :enable-time-picker="false" no-today  @update:modelValue="handleDate"  :month-change-on-scroll="false" range inline auto-apply />

</template>

<script setup>
 const date = ref();

  onMounted(() => {
            const startDate = new Date();
            const endDate = new Date(new Date().setDate(startDate.getDate() + 3));
            date.value = [startDate, endDate];

   })

</script>

Why would you do that? If you need you can map data separately, or if you need it for 2 pickers, you can use initial array [null, null] and v-model="array[0 | 1]"  or something like that


test: Ensure no 6+ minute delays for disrupted stateful workloads

Fixes #N/A
Description
Add tests that validate Karpenter PR 1294's solution to 6+ minute delays for disrupted stateful workloads outlined in #6336.
Add two storage E2E tests that ensure:

Disrupted stateful workloads run on a new node within 5 minutes
Un-drain-able stateful workloads (due to tolerations) do not block node deletion

Also adds read RBAC permissions for volumeattachment objects. (Let me know if this should be a separate fix PR)
How was this change tested?
Running FOCUS="StatefulSets" make e2etests locally on cluster with and without modified Karpenter from Karpenter PR 1294.
NOTE: The test should run a disrupted stateful workload on a new node within 5 minutes currently fails due to Karpenter PR 1294 not being merged. This test will validate that the 6+ minute delay is eliminated.
NOTE-2: We are not testing whether the 1+ minute EBS DetachVolume & EC2 TerminateInstances race delay occurs because the smaller time frame is likely to induce flakes.
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 79.023%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
93.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
5967

Relevant Lines:
7551

💛  - Coveralls

@AndrewSirenko please also remember that not only statefulset should be handled. Also, we should handle cases where we have deployment with volume (single replica deployment)

@AndrewSirenko please also remember that not only statefulset should be handled. Also, we should handle cases where we have deployment with volume (single replica deployment)

I can remove "statefulset" from the test title to make it more clear this test implicitly covers both the statefulset and deployment cases. Thanks!
But I'm not sure if a separate test using deployment instead of statefulset would provide any additional coverage for karpenter (because the underlying mechanism for node draining and workload disruption is the same in both cases).
@jmdeal let me know if you think the additional test provides additional coverage, or would just take up computing time.

/hold
Until Karpenter PR 1294 is merged

/hold
Testing e2e tests against kubernetes-sigs/karpenter#1294

/karpenter snapshot

x-ref: Testing e2e tests against https://github.com/kubernetes-sigs/karpenter/pull/1294 stacked on top of #6614 here: https://github.com/aws/karpenter-provider-aws/pull/6615/commits


Update "Hold expense" modal copy and icons

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/52655
PROPOSAL: https://github.com/Expensify/App/issues/52655#issuecomment-2479856195
Tests

Login with an account that has not seen hold request modal before (better be a new account)
Submit 2 expenses to a workspace
Hold 1 expense
Verify hold request modal shows
Press Got it (or press backdrop)
Verify the modal disappears
Hold the other expense
Verify hold request modal does not show again

Login with an account that has not seen track training modal before
Go offline
Press FAB > Track expense
Verify the track training modal shows with an animation
Go online
Verify the track training modal shows with a video

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Login with an account that has not seen hold request modal before (better be a new account)
Submit 2 expenses to a workspace
Hold 1 expense
Verify hold request modal shows
Press Got it (or press backdrop)
Verify the modal disappears
Hold the other expense
Verify hold request modal does not show again

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

https://github.com/user-attachments/assets/5e464625-9cc9-4aa9-b3a3-db4623ed9da4

MacOS: Chrome / Safari

MacOS: Desktop

Oh yeah that's much better!

What's the latest on this one @gijoe0295 & @parasharrajat ? Can we get this merged?


Any reason the library is using master version of yiisoft/db?

Is there any reason why in composer this library is using dev-master version of the yiisoft/db library and not the released version? It is not installable as it is as the mix happens until you constraint related dependencies to dev-master

This package will be depended from future major version of Yii DB, so currently yiisoft/db:dev-master is used.

You can temporarily install the db package by specifying in the composer require section:
"yiisoft/db": "dev-master as 1.3.0",

perfect. Thank you!


Local Drives disappear

Description
Worked correctly when initially installed.  When opening on subsequent days, all local drives not shown. The main screen shows 'Folders' OK, but under that it has text 'Drives' and just blank section (where it should show at least 5 physical drives).
On the sidebar - it does not show 'Drives' at all - despite being selected (and toggled) in Options.
Had same result on multiple versions over last 2 months.
Steps To Reproduce
On main screen when opened
Expected behavior
To see the local drives in the 'Drives' section
Files Version
<IP_ADDRESS>
Windows Version
Windows 11 Pro 22H2 22593.1 Feature Experience 1000.22593.1.0
Relevant Assets/Logs
debug_fulltrust.log
debug.log

Thanks for the report. Could you post a screenshot of Files on start?

Also, could you check if the issue is due to disconnected network drives?

Also, could you check if the issue is due to disconnected network drives?

After posting - I did notice it was all my drives with drive letters -- so includes the 4x Network drives that are on my Server. The server was on and the drives available when opening FILES just now.

Have included a screenshot from File Explorer taken at the same time showing all the active drives.

This is the only issue I have with this great program.

I can also see this bug, I'm using the sideloaded version. It showed up a day after installation, reinstallation fixed it for the moment but I'll keep testing. Something of note, when the drives disappear, at the same time the option selector for which terminal is used in the context menu appears empty and can't be changed, nor does the button to open the config file work after this point.

Is this still an issue in <IP_ADDRESS>?

I have just started to use <IP_ADDRESS> (I didn't realise when upgrading, the old version remains installed).  Am testing, removing network, using sleep, hibernate etc. as I previously suspected it might be cause --- however, currently all is working as it should!

Version <IP_ADDRESS> - this is still happening unfortunately. I am still unable to tell the sequence of events that causes the issue to present itself.

Sorry - now note that it is all mapped drives that disappear. please see the Windows Explorer view and then the Files view on the same computer.   Thanks for any review of this bug!


[Event Hubs] Doc Updates

Summary
The focus of these changes is to perform some updates and refinements for the Event Hubs documentation:

Fix the broken link for creating an Azure account
Clarify the Event Processor handler contract for concurrent invocations
Clarify thread-safety for model types
Tweak some README sections to remove references to .NET Core 2.x (retired)
Include the troubleshooting guide in the title link set for visibility
Include the mocking sample as part of the "Additional Concepts|Mocking" area

API change check
API changes are not detected in this pull request.


move 'private' to top

As in the most package.json files, 'private' is an important information, which should be below name/version. Could you change this? Do you want an pull-request for this change?

Sure, feel free to raise a PR for this 😄

Awesome, thx.

1.7.1 btw 😄 https://www.npmjs.com/package/sort-package-json


[Unicode Symbols Search] ...

Extension
https://www.raycast.com/mmazzarolo/unicode-symbols
Description
Error:
TypeError: Cannot read properties of undefined (reading 'length')

ItemGrid.tsx:29:30

---
26:   `;
27: };
28:
29: const GridItem = memo(({ item }: { item: Character }) => {
30:   const [light, dark] = useMemo(() => {
31:     return [
32:       `data:image/svg+xml;base64,${encode(getSquare(item.value))}`,
---

    at ray-grid-section
ja:index.js:20:24805
Mr:index.js:11:6635

Steps To Reproduce
Running the default command would cause the issue
Current Behaviour
No response
Expected Behaviour
No response

After I clear the cache manually, the problem is resolved.
It might be caused by the recent change. https://github.com/raycast/extensions/pull/9506

@Yukaii you might be right, I'm thinking that this was introduced by my PR with this piece of code:
        item.aliases.length > 0 ? `Aliases: "${item.aliases.map(upperCaseFirst).join(", ")}"` : "",

... which might break on a cached item that doesn't have aliases. In other parts of the code it does a better check for aliases, didn't catch this one in my code.
I'll write a small fix for it.


Remote connection doesn't appear for a very long time

If you specify a remote server I have to wait almost 2 minutes before I can select a remote server.
It looks like it's broken.
It seems like we need some sort of loading status?

Its instantaneous for me, can you provide the logs or provide more information on where the delay is.
Is the delay in connecting or fetching kernels?

Well without looking at the logs the delay was in the creation of the remote notebook controllers.

Try to repro and it doesn't take any time now. Not sure what went wrong.


fix colony_integrator.md getBuilderResources description

Description suggested it lists all resources but it only lists required resources for the current build.
Steps to validate:
Start a build
add an item to the builder's hut that is not related to the build (eg: a diamond)
execute method
unrelated item will not be listed

Agreed 👍🏻


[Nautobot 2.2] Unable to add Software to Device without also specifying Software Image

Environment

Nautobot version (Docker tag too if applicable): 2.2.0-beta.1
Python version: 3.11

Steps to Reproduce

Create Software object
Try to assign Software object to a Device by editing existing Device object
Try saving the object

Expected Behavior
Save operation should succeed and Software object should be associated with the Device.

Observed Behavior
Save operation fails with form error stating that no software image files for software version, matching device's device type, are found.

Hi. I agree with progala, being able to associate a software version to a device without needing to manage software file versions + their associations with software versions + the devices types' associations with software file versions would really ease the process of very simply storing the version of the device's platform.

I ran into this as well.  It looks like it's coming from this validation block in the model:
https://github.com/nautobot/nautobot/blob/6808148732c8824bacca156eadae0e103077fbc3/nautobot/dcim/models/devices.py#L807-L821
Is this validation block needed for some other purpose?  I tested after removing those lines and was able to set a software version in the web GUI and with pynautobot.

Hi. Following a question on slack, I confirm this is not fixed in 2.3.


add: hosting snippet info

Hi! @markodenic, I have contributed some info snippets for the hosting platform. The content is taken from the official respective websites. Contributed content can be viewed in the screenshot.

@DalpatRathore Looks good to me. Can you, please just change "Snippet" to "Description"? Thanks!


Add LGTM logo

This is a follow up PR to #1672 (and I only expect that this'll get merged following the other PR). Minified with svgo.
Preview of what the badge looks like exported as PNG (with logoWidth=20)

Full disclosure, I work at Semmle on lgtm.com.

Looks good to me, thanks for your contribution! 😉


Medical guidebook entries

About the PR

This PR adds several guidebook entries to help players understand the mechanics behind the medical profession, with helpful coloring and even pictures! Issue https://github.com/space-wizards/space-station-14/issues/13506
Includes cryogenic information that might interest issue https://github.com/space-wizards/space-station-14/issues/13512.
I was going to add a chemistry entry here too but I could not come up with a good way to have the entry automatically update chemical formulas.  If we put any recipes in the guide, and the recipe or values change it could be a nightmare of conflicting information and tedious vigilant updates to the guidebook.  If someone know how to do this and wants to tell me, I'll add a chemistry page too.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: MagnusCrowe

add: Added guidebook entries for Medical

@MagnusCrowe The hard part of the chemistry guidebook is already done in one of my PRs, #14060. What needs done still is wiring up the backend to the frontend ui of the guidebook.

Also the usual headsup: If you take my work, please use git merge to incorporate it, not copy paste.

Also the usual headsup: If you take my work, please use git merge to incorporate it, not copy paste.

It won't be part of this pull request but if I am the one to write the Chem guide, I'll do that.

Any chance of a review?

Thank you for all the feedback.  I will work on it.

re-open once you come back


Work around buggy libexecinfo by defining our own traceHandler

On Alpine Linux, which uses Musl libc, there is no backtrace() and co.
As a result, to provide trace information when an exception is thrown,
druntime was made to rely on libexecinfo, which provides a backtrace-like interface.
However, it turned out that this library is buggy and routinely leads to SEGV
in various pieces of code. Hence, we are in the process of adding support
for libunwind to druntime, which is the industry standard when it comes to frame inspection.
The work upstream is almost complete, and the results we've seen are very
encouraging. However, the support will only land in v2.096.0, which means
LDC v1.26.0, which is two release away, estimated to be around 4 months from now.
It is likely that this support can be back-ported to LDC v1.25.0 with a little effort,
which would put the ETA at 1 month, much more reasonable.
Given this uncertain schedule, we want to work around the issue by copying over the support
from the druntime PR. The workaround is rather crude: we simply define a trace handler
that prints addresses and function names. This means we loose file/line information temporarily,
but Agora should be much more stable.
If the missing file/line information turns out to be problematic,
we could get it back by copying over the relevant parts of druntime,
as they have been made to be self-contained by our previous refactorings.
As a last note, this also means we force users to link in libunwind on other POSIX platforms.
It's not an issue on OSX, as it's distributed with the development environment,
but will create another constraint on Linux.

Kinda sorta fixes https://github.com/bpfkorea/agora/issues/1407

Kinda sorta fixes https://github.com/bpfkorea/agora/issues/1407

Green

Green


Remove bonus ) in pkg.php

Reported in forum https://forum.pfsense.org/index.php?topic=101390.0

Merged. Thanks
Steve
Stephen Beaver | +1<PHONE_NUMBER>;239 |<EMAIL_ADDRESS>| www.netgate.com

On Oct 26, 2015, at 1:21 PM, Phil Davis<EMAIL_ADDRESS>wrote:
Reported in forum https://forum.pfsense.org/index.php?topic=101390.0 https://forum.pfsense.org/index.php?topic=101390.0
You can view, comment on, or merge this pull request online at:
https://github.com/pfsense/pfsense/pull/1988 https://github.com/pfsense/pfsense/pull/1988
Commit Summary
Remove bonus ) in pkg.php
File Changes
M src/usr/local/www/pkg.php https://github.com/pfsense/pfsense/pull/1988/files#diff-0 (2)
Patch Links:
https://github.com/pfsense/pfsense/pull/1988.patch https://github.com/pfsense/pfsense/pull/1988.patch
https://github.com/pfsense/pfsense/pull/1988.diff https://github.com/pfsense/pfsense/pull/1988.diff
—
Reply to this email directly or view it on GitHub https://github.com/pfsense/pfsense/pull/1988.


Add Patterns

@aneeshd27 Thanks for your contribution, but please make separate pr for each Pattern as it will be better to merge them so I am closing this pr.


NFOV_BINNED broken depth image displaying on NUC8i7HVK - 1.1.0 SDK

NFOV_BINNED displays a broken depth image when running on a NUC8i7HVK in the Kinect Viewer from the SDK 1.1.0 installer in usage:
https://user-images.githubusercontent.com/25708712/60984625-dfacb800-a2f0-11e9-9d56-e7f928cdfba5.PNG
This only occurs on the NUC8i7HVK  and not on my alternate desktop system. It also occurs across multiple different Kinect Hardware units.
This is with all standard connections attached (USB 3.0 and Power).
System: NUC8i7HVK  w/ 32 GB RAM
OS: Windows 10 Version 1903 (OS Build 18362.239)
SDK: 1.1.0
Firmware
RGB camera: 1.6.98
Depth camera: 1.6.70
Audio: 1.6.14

As a followup to this, after testing, this issue does not occur in Ubuntu 18.04 on the NUC8i7HVK.

@somacoder thank you for reporting this issue, we definitely want to know more about this issue. May I ask two questions to help us narrow down a little bit more:

It seems this issue only happens on the NUC8i7HVK device on windows, and also this issue does not happen on other desktop windows system. Have you try to update the graphics driver of the NUC8i7HVK see whether it helped addressing this issue? Please share what your current graphics driver version is.
On the NUC8i7HVK, does this issue also happen to other 3 depth modes, or it only happens to the NFOV_BINNED?

Thanks for the followup. I've since re-imaged to Linux and am programming there (my goal all along once Linux became stable). As such, this system specific issue is less a priority over the Linux bugs currently for me, specifically point cloud visualization bug in the viewer and the libusb multi-camera support bug in the recorder. However, given the NUC8i7HVK will almost certainly be a go to system for this device moving forward, it makes sense to address eventually.

I did not update the graphics manually. The RX Vega M is strange in that I think the driver is exclusively distributed by Intel not AMD, so I didn't get around to manually installing that. This could have very well have solved the problem. I can't say what the driver was before I re-imaged.
This only occurred with NFOV_BINNED.

I will make it a priority to install Windows again on a separate disk to test again when I get a little more spare time.

Are there issues opened for the 2 bugs you mentioned above?

@somacoder thank you for answer my questions. Yes, I think it is definitely worth to try repro this issue on this device and see whether you can update the graphic driver can help solve the issue. We have experienced one Intel Graphics driver issue before results in a color point cloud missing points https://github.com/microsoft/Azure-Kinect-Sensor-SDK/issues/294, and somehow the windows update on surface does not pull the latest intel graphics driver automatically and manually update fixed the issue. Therefore, please try similar thing on the NUC8i7HVK, likely causing by the graphics driver.
I will keep an eye on this issue and looking forward to hear your testing results

Sounds good! Thanks all. And to @wes-b, yes, those are being handled and look to be resolved soon. I know you all are hard at work and I appreciate the proper triaging!

@somacoder given it may take some time for you to try repro again and testing the update the Intel GPU driver, we are going to close this issue for now, and if update the Intel GPU driver did not fix your issue, please reopen this issue with your repro and testing result at then. Thank you a lot for actively on this issue!

Updating to the newest driver here did not fix the problem. https://downloadcenter.intel.com/download/28600/Radeon-RX-Vega-M-Graphics-Driver-for-Windows-10-64-bit-for-NUC8i7HNK-NUC8i7HVK?product=126143

Success! If you download the Radeon software for the standard RX Vega 64, a driver update will be installed over Intel's advertised driver for this unit, fixing this bug. Strange that Intel communicates having to use their driver available on their website. Doubly strange considering that AMD also doesn't advertise support for the Radeon™ RX Vega M anywhere on their site. https://www.amd.com/en/support/graphics/radeon-rx-vega-series/radeon-rx-vega-series/radeon-rx-vega-64

@somacoder thank you very much for the effort, we really appreciated your follow through here. It is definitely make sense this is some graphic driver bug, and it is also glad to know the newer version that you updated manually did fix the issue. This is very helpful for others if they are hitting same issue.


Add Onvif Metadata

I created a Pull request for handling RTSP data track, espacially Onvif Metadatas tracks.
So I added

a Data type inside the RequiredTracks
a new codec : OnvifMetadataCodecInfo
a new parser : OnvifMetadataPayloadParser for parsing the packets

I also added the units test for the OnvifMetadataPayloadParser.


Optimize runtime for PNG and JPEG

Disable optimizers that are unlikely to be useful. Prefers oxipng (recently introduced in image_optim) for PNG, and jpeg-recompress for JPEG.

Thanks! Releasing v2 of this action too. 😊


cmake: Fix static linking in parallel build

The yajl build system contains a race condition, which gets triggered by high make --jobs settings - It tries to link the executable gen-extra-close against libyajl before it is created:
[ 21%] Linking C executable gen-extra-close
[ 26%] Building C object src/CMakeFiles/yajl_s.dir/yajl_buf.c.o
/home/test/autobuild/instance-3/output/host/opt/ext-toolchain/bfin-uclinux/bfin-uclinux/bin/ld.real: cannot find -lyajl

Fix this issue by linking against the shared yail library in a shared build. Apply this fix also to all other build targets who are linking against the library.

Project seems to be dead. Closing.


Update CHANGELOG.md

Restore previous changes

Codecov Report

Merging #87 into master will decrease coverage by 0.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   85.94%   85.16%   -0.78%
==========================================
  Files          20       20
  Lines         441      445       +4
==========================================
  Hits          379      379
- Misses         62       66       +4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b2cdd...af45775. Read the comment docs.


Custom changes for godot-rapier

Change how interaction groups work to be or instead of and.
Add custom friction rules needed for godot symetry https://github.com/dimforge/rapier/issues/622

Thanks for comments. The main problem currently with godot-rapier is in order to integrate into godot physics it needs to work in same way.
Friction and bounce works differently in rapier vanilla, this just makes it work same way as in godot. I could show examples or reference how it works in godot, but not sure if rapier would want to change its behaviours because godot does something in a specific way.
Layers and masks also work differently in godot. Collisions happen with an or instead of and, but it's a bit more complicated also. Godot also has asymetrical collisions. Meaning if A has layer 1 but no mask and B has layer 1 and mask 1, B will collide with A but A will not collide with B. https://docs.godotengine.org/en/stable/tutorials/physics/physics_introduction.html#collision-layers-and-masks
Probably right now godot rapier is not big enough to say something like: this is how it works, deal with it. People aren't going to change their project in godot to work with different way godot rapier works. So for now at least, having some local changes might be expected, again unless rapier is willing to add them to rapier vanilla.

For the interaction groups ||, I'll mention https://github.com/dimforge/rapier/pull/170 which adds an opt-in for this change.

Perfect, if that gets in I can remove some parts of this.


store terraform.tfstate in configured region rather than s3 default

Updating the S3_ENDPOINT in install-pcf/aws/params.yml to a different region endpoint (e.g. https://s3-us-west-2.amazonaws.com) results in the following error when running the bootstrap-terraform-state job:

BucketRegionError: incorrect region, the bucket is not in 'us-east-1' region.

These changes use the TF_VAR_aws_region value to ensure the state file can be stored in a non default S3 region.

@pvsone Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@pvsone Thank you for signing the Contributor License Agreement!

hi @pvsone, thanks for raising this issue. Prioritizing this work.

I had to revert this from master as I was getting authentication problems against non-us-east-1 buckets. We'll do some more testing soon and try to merge again.

Tested again and it looks like it works. Reverted the revert https://github.com/pivotal-cf/pcf-pipelines/commit/bcad37403e358cfe80d32d26f21d0eef4c7f6dee


Updates to the rebase script

Soft reset does not drop changes from the staging area
Use git status --porcelain instead of disabling errexit

@stevekuznetsov @bbguimaraes

More scoped, I like it. Updated
On Thu, Mar 9, 2017 at 5:26 PM, Steve Kuznetsov<EMAIL_ADDRESS>wrote:

@stevekuznetsov approved this pull request.
Rest LGTM
In scripts/merge-and-build.sh
https://github.com/openshift/aos-cd-jobs/pull/70#discussion_r105206396:

git add .tito/ origin.spec
git commit -m "[CARRY][BUILD] Specfile updates"

Drop the previous web console diff - will be regenerated below.

git stash

Not sure this is the best approach, instead
git checkout -- pkg/assets/bindata.go pkg/assets/java/bindata.go
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openshift/aos-cd-jobs/pull/70#pullrequestreview-26074537,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADuFf06iDEtrSmySLPLWOrpZ7yGpPvawks5rkCg3gaJpZM4MUQXc
.


[internal/6.0.1xx] Stage 2 build failure

Stage 2 build failure (internal Microsoft link)
##[error]/tarball/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj(0,0): error NU1603: (NETCORE_ENGINEERING_TELEMETRY=Restore) Microsoft.Build.Tasks.Core 17.0.4 depends on System.Security.Cryptography.Pkcs (>= 6.0.4) but System.Security.Cryptography.Pkcs 6.0.4 was not found. An approximate best match of System.Security.Cryptography.Pkcs 6.0.5 was resolved.

This is a duplicate of https://github.com/dotnet/source-build/issues/4681.


Skip git command when git is not installed

Unblock pr https://github.com/openshift/odo/pull/4304 failing due to https://github.com/openshift/odo/pull/4304/files#issuecomment-757650119

/approve

/approve

/lgtm

/lgtm

/hold

/hold

/hold cancel

/hold cancel


Feature: Implement light mode and dark mode, along with its toggle switch

Feature description
implement dark and light mode and its toggle tab in the navbar for better convivence.
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Please can I be assigned this issue


new tar source etag saved strangely

See original issue on GitLab
In GitLab by [Gitlab user @tristanvb] on Mar 12, 2018, 06:48
When running bst track on tar sources, we save something like this:
  etag: '"2c6740-53c8cf064bf9d"'

This seems quite odd; I would expect something like:
  etag: 2c6740-53c8cf064bf9d

[Gitlab user @juergbi] is this intentional for some reason ?
Perhaps this is a subtle regression from fixing the loader to load everything as strings ?

In GitLab by [Gitlab user @juergbi] on Mar 12, 2018, 08:36
It does look a bit odd but the double quotation marks are part of the ETag value. It's not some generic quoted HTTP field value. In the case of weak validators, there are even characters before the first quotation mark: ETag: W/"xyzzy". And storing the string with quotes obviously requires another set of quotes in YAML.

In GitLab by [Gitlab user @tristanvb] on Mar 12, 2018, 08:37
Ok, that just looked very weird :)

In GitLab by [Gitlab user @tristanvb] on Mar 12, 2018, 08:37
closed


(WIP) Admin Panel build

@ouranos FYI, this is a work in progress.

$ time rake mnoe:admin:install
real	1m12.411s
user	0m56.277s
sys	0m15.603s


upgrade cache-action because only v6 is whitelisted by ASF

Thanks @danischroeter, I made a change after you made your review. I noticed that a custom maven repo used for a restlet jar was causing the build to fail. The URL has an expired SSL cert. I found an alternative site that works. Would you be able to re-review?


Move drush.yml into /drush from sites/all/drush

The Problem/Issue/Bug:
Drupal 8 drush drush.yml has always been placed in /sites/all/drush. However, community opinion seems to be that putting drush.yml in /drush.
Both of these

Can break multisite in the same way by overriding the default uri
Create a new drush.yml file that is annoying to people and they may have to take over.

But this is a slightly better place, outside Drupal's docroot, etc.
How this PR Solves The Problem:
Manual Testing Instructions:
Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

I think the drush folder in the root makes more sense. That seems to be a more standard approach.


Add Pause/Resume Auto Follower APIs

Implements: https://github.com/elastic/elasticsearch/pull/47510

Missing integration tests - could add steps to CrossClusterReplicationAutoFollowTests?

The only issue is that the test suite is marked with a BlockedByIssue attribute, so this suite doesn't run. I can add some placeholder tests in?

The BlockedByIssue does not seem relevant anymore

OK, the issue with the integration tests is "could not determine the license type for cluster [remote-cluster]".
This fails as the remote cluster is not actually running, but is provided as settings only (https://github.com/elastic/elasticsearch-net/blob/27f44edec582033092bb82f422d633f96ebec09c/src/Tests/Tests.Core/ManagedElasticsearch/NodeSeeders/DefaultSeeder.cs#L96).
Will open an issue for this.

Opened: https://github.com/elastic/elasticsearch-net/issues/4284

Ported to master


drivers: sensor: mcux qdec modulus check

Add check for modulus value to guard agains division by zero.

This PR changes the counts_per_revolution behavior. Therefore this PR is no longer relevant.


First of all I love this plugin, I've been using it for a few months and coming fro AWM I can't say that it became a must in my config.
However, I'd love to use this plugin with something like kanshi.
For that I would need to be able to assign monitor to workspace in the split-monitor-worksapaces config. The must would be using the display name like kanshi allows you.
Something like specifying the monitor name and the starting number for that monitor workspaces.
How possible do you think that would be ?

Just realized there is actually an opened PR with something similar
!35

My fork also does this btw


Enable the PullRequestHandler for more PR types

The PullRequestHandler only runs on PR creation currently. I'm updating it so that it runs when reopened and edited.

/verify


Document proper worker config for QEMU workers

A couple of changes here, most of which I am not super sure about. Please review with special care! (Keeping as a draft PR to avoid accidental merge, until we have some agreement this PR is good.)
Main change here is updating the docs on how to set workers in order to use QEMU workers. From my experience and from a quick look at the source, using http://worker (instead of http://localhost) is the way to go.
Then I got errors when I ran npm run docs, so I tossed in a commit that fixes them. I think the resulting code in core/lib/common/suite.js became a bit less elegant (mixing setup and TaskQueue, versus using "setup" only, as it did before). I am pretty sure there are better solutions for this!
Finally, fixed a few typos.

@balena-ci retest

@resin-jenkins retest this please

Hey @lmbarros How about splitting the docs fix into a different PR for us to review later? We already have an issue on that: https://github.com/balena-os/leviathan/issues/780
Regarding the issue itself, how about making the workaround fix for the taskqueue, generate the docs and then revert the change you made.
And, now regarding the PR

Vipul's suggestions seem good to me, if these were separate PR's, I'd approve it.

@vipulgupta2048 , @jakogut Thanks for the comments! This PR was quite messy, indeed (I kept adding just one more commit to it...)
Now this PR contains only the fixes to the docs comments, and the (improved) fix to the npm run build moved over here: https://github.com/balena-os/leviathan/pull/813.


Tests fail even when notebook does not have assert statements

Hi, first of all, thanks for creating this great tool. I was a bit skeptical at first, but I am amazed at how easy it is to create great code quality with nbdev.
I am raising this issue because I am unable to run nbdev_test_nbs succesfully. I keep getting the following:
testing /home/luis/Projects/my_nbdev_pkg/nbs/00_api.ipynb
Error in /home/luis/Projects/my_nbdev_pkg/nbs/00_api.ipynb:
preprocess() missing 1 required positional argument: 'resources'
testing /home/luis/Projects/my_nbdev_pkg/nbs/01_convert.ipynb
Error in /home/luis/Projects/my_nbdev_pkg/nbs/01_convert.ipynb:
preprocess() missing 1 required positional argument: 'resources'
testing /home/luis/Projects/my_nbdev_pkg/nbs/02_upload.ipynb
Error in /home/luis/Projects/my_nbdev_pkg/nbs/02_upload.ipynb:
preprocess() missing 1 required positional argument: 'resources'
testing /home/luis/Projects/my_nbdev_pkg/nbs/Dummy.ipynb
Error in /home/luis/Projects/my_nbdev_pkg/nbs/Dummy.ipynb:
preprocess() missing 1 required positional argument: 'resources'
testing /home/luis/Projects/my_nbdev_pkg/nbs/index.ipynb
Error in /home/luis/Projects/my_nbdev_pkg/nbs/index.ipynb:
preprocess() missing 1 required positional argument: 'resources'
Traceback (most recent call last):
  File "/home/luis/.config/miniconda3/envs/my_nbdev_pkg/bin/nbdev_test_nbs", line 8, in <module>
    sys.exit(nbdev_test_nbs())
  File "/home/luis/.config/miniconda3/envs/my_nbdev_pkg/lib/python3.9/site-packages/fastcore/script.py", line 105, in _f
    tfunc(**merge(args, args_from_prog(func, xtra)))
  File "/home/luis/.config/miniconda3/envs/my_nbdev_pkg/lib/python3.9/site-packages/nbdev/test.py", line 120, in nbdev_test_nbs
    raise Exception(msg + '\n'.join([f.name for p,f in zip(passed,files) if not p]))
Exception: The following notebooks failed:
00_api.ipynb
01_convert.ipynb
02_upload.ipynb
Dummy.ipynb
index.ipynb

I even created Dummy notebook with no tests in it that fails too.
I am using nbdev1 1.1.13, I am using nbdev_template` from the 20th of Jan.

My environment is the following:

# packages in environment at /home/luis/.config/miniconda3/envs/my_nbdev_pkg:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                        main
argon2-cffi               20.1.0           py39h27cfd23_1
attrs                     20.3.0             pyhd3eb1b0_0
backcall                  0.2.0              pyhd3eb1b0_0
beautifulsoup4            4.9.3              pyha847dfd_0
blas                      1.0                    openblas
bleach                    3.3.0              pyhd3eb1b0_0
brotlipy                  0.7.0           py39h27cfd23_1003
ca-certificates           2021.1.19            h06a4308_0
certifi                   2020.12.5        py39h06a4308_0
cffi                      1.14.5           py39h261ae71_0
chardet                   4.0.0           py39h06a4308_1003
cryptography              3.3.1            py39h3c74f83_1
cycler                    0.10.0           py39h06a4308_0
dbus                      1.13.18              hb2f20db_0
decorator                 4.4.2              pyhd3eb1b0_0
defusedxml                0.6.0              pyhd3eb1b0_0
entrypoints               0.3              py39h06a4308_0
expat                     2.2.10               he6710b0_2
fastcore                  1.3.19                     py_0    fastai
fastrelease               0.1.11                   pypi_0    pypi
fontconfig                2.13.1               h6c09931_0
freetype                  2.10.4               h5ab3b9f_0
ghapi                     0.1.16                     py_0    fastai
glib                      2.67.4               h36276a3_1
gst-plugins-base          1.14.0               h8213a91_2
gstreamer                 1.14.0               h28cd5cc_2
icu                       58.2                 he6710b0_3
idna                      2.10               pyhd3eb1b0_0
importlib-metadata        2.0.0                      py_1
importlib_metadata        2.0.0                         1
ipykernel                 5.3.4            py39hb070fc8_0
ipython                   7.20.0           py39hb070fc8_1
ipython_genutils          0.2.0              pyhd3eb1b0_1
ipywidgets                7.6.3              pyhd3eb1b0_1
jedi                      0.17.2           py39h06a4308_1
jeepney                   0.6.0              pyhd3eb1b0_0
jinja2                    2.11.3             pyhd3eb1b0_0
jpeg                      9b                   h024ee3a_2
jsonschema                3.2.0                      py_2
jupyter                   1.0.0            py39h06a4308_7
jupyter_client            6.1.7                      py_0
jupyter_console           6.2.0                      py_0
jupyter_core              4.7.1            py39h06a4308_0
jupyterlab_widgets        1.0.0              pyhd3eb1b0_1
jupytext                  1.9.1              pyhd3deb0d_1    conda-forge
keyring                   22.0.1           py39h06a4308_0
kiwisolver                1.3.1            py39h2531618_0
lcms2                     2.11                 h396b838_0
ld_impl_linux-64          2.33.1               h53a641e_7
libedit                   3.1.20191231         h14c3975_1
libffi                    3.3                  he6710b0_2
libgcc-ng                 9.1.0                hdf63c60_0
libgfortran-ng            7.3.0                hdf63c60_0
libopenblas               0.3.10               h5a2b251_0
libpng                    1.6.37               hbc83047_0
libsodium                 1.0.18               h7b6447c_0
libstdcxx-ng              9.1.0                hdf63c60_0
libtiff                   4.1.0                h2733197_1
libuuid                   1.0.3                h1bed415_2
libxcb                    1.14                 h7b6447c_0
libxml2                   2.9.10               hb55368b_3
libxslt                   1.1.34               hc22bd24_0
lxml                      4.6.2            py39h9120a33_0
lz4-c                     1.9.3                h2531618_0
markdown-it-py            0.6.1              pyhd8ed1ab_0    conda-forge
markupsafe                1.1.1            py39h27cfd23_0
matplotlib                3.3.2                h06a4308_0
matplotlib-base           3.3.2            py39hd261b2b_0
mdit-py-plugins           0.2.4              pyhd8ed1ab_0    conda-forge
mistune                   0.8.4           py39h27cfd23_1000
nbconvert                 5.5.0                      py_0
nbdev                     1.1.13                   pypi_0    pypi
nbformat                  5.1.2              pyhd3eb1b0_1
ncurses                   6.2                  he6710b0_1
notebook                  6.2.0            py39h06a4308_0
numpy                     1.19.2           py39h87658db_0
numpy-base                1.19.2           py39h0f7b65f_0
olefile                   0.46                       py_0
openssl                   1.1.1j               h27cfd23_0
packaging                 20.9               pyhd3eb1b0_0
pandas                    1.2.2            py39ha9443f7_0
pandoc                    2.11                 hb0f4dca_0
pandocfilters             1.4.3            py39h06a4308_1
parso                     0.7.0                      py_0
pcre                      8.44                 he6710b0_0
pexpect                   4.8.0              pyhd3eb1b0_3
pickleshare               0.7.5           pyhd3eb1b0_1003
pillow                    8.1.0            py39he98fc37_0
pip                       21.0.1           py39h06a4308_0
prometheus_client         0.9.0              pyhd3eb1b0_0
prompt-toolkit            3.0.8                      py_0
prompt_toolkit            3.0.8                         0
ptyprocess                0.7.0              pyhd3eb1b0_2
pycparser                 2.20                       py_2
pygments                  2.8.0              pyhd3eb1b0_0
pyopenssl                 20.0.1             pyhd3eb1b0_1
pyparsing                 2.4.7              pyhd3eb1b0_0
pyqt                      5.9.2            py39h2531618_6
pyrsistent                0.17.3           py39h27cfd23_0
pysocks                   1.7.1            py39h06a4308_0
python                    3.9.1                hdb3f193_2
python-dateutil           2.8.1              pyhd3eb1b0_0
pytz                      2021.1             pyhd3eb1b0_0
pyyaml                    5.4.1            py39h27cfd23_1
pyzmq                     20.0.0           py39h2531618_1
qt                        5.9.7                h5867ecd_1
qtconsole                 5.0.2              pyhd3eb1b0_0
qtpy                      1.9.0                      py_0
readline                  8.1                  h27cfd23_0
requests                  2.25.1             pyhd3eb1b0_0
scipy                     1.6.1            py39hf56f3a7_0
seaborn                   0.11.1             pyhd3eb1b0_0
secretstorage             3.3.1            py39h06a4308_0
send2trash                1.5.0              pyhd3eb1b0_1
setuptools                52.0.0           py39h06a4308_0
sip                       4.19.13          py39h2531618_0
six                       1.15.0           py39h06a4308_0
soupsieve                 2.2                pyhd3eb1b0_0
sqlite                    3.33.0               h62c20be_0
terminado                 0.9.2            py39h06a4308_0
testpath                  0.4.4              pyhd3eb1b0_0
tk                        8.6.10               hbc83047_0
toml                      0.10.1                     py_0
tornado                   6.1              py39h27cfd23_0
traitlets                 5.0.5              pyhd3eb1b0_0
tzdata                    2020f                h52ac0ba_0
urllib3                   1.26.3             pyhd3eb1b0_0
wcwidth                   0.2.5                      py_0
webencodings              0.5.1            py39h06a4308_1
wheel                     0.36.2             pyhd3eb1b0_0
widgetsnbextension        3.5.1            py39h06a4308_0
xz                        5.2.5                h7b6447c_0
yaml                      0.2.5                h7b6447c_0
zeromq                    4.3.3                he6710b0_3
zipp                      3.4.0              pyhd3eb1b0_0
zlib                      1.2.11               h7b6447c_3
zstd                      1.4.5                h9ceee32_0

My repo is private for now until I make my first release, so I am unable to share the actual source code, sorry for that. Though I think nbdev_test_nbs should just work based on the examples I've seen and on @hamelsmu 's video demo.
More over, nbdev_build_lib and nbdev_build_docs run fine and I can serve my docs using make docs_serve

Yes - tests also fail on syntax errors, for example, it looks like you are experiencing some syntax error when trying to call your preprocess function from your library. This is because nbdev_test_nbs will run all the code in your notebooks including your tests, so if there are any syntax errors things will fail.
Hope that helps.

Thanks @hamelsmu for the quick response! That's weird because the notebooks run with no problems. I'll review my code tomorrow,thanks!

I would suggest running a fresh kernel, "restart kernel and run all" may help you see errors locally.  Also run nbdev_test_nbs to run all the unit tests locally

Hi again @hamelsmu, the notebook run with no errors when doing "restart kernel an run all", also the preprocess() function is only present in one notebook, though all notebooks fail.

I am also wondering, is the tests/ folder special in nbdev? I have one with some sample documents to test my code on and I am wondering if that's causing problem

Ok, I figured it out! My environment was wrong I was using:
nbconvert                 5.5.0                      py_0
nbdev                     1.1.13                   pypi_0    pypi

I think I initially installed nbdev from a location other than the conda fastai channel!
I deleted the environment and reinstalled via pip and now things are working:
nbconvert                 5.6.1                      pypi_0    pypi
nbdev                     1.1.13                   pypi_0    pypi

Thanks for the help @hamelsmu! :100:

I think this issue is due to the version of nbconvert.
I got the exact same error while running nbdev_test_nbs:
preprocess() missing 1 required positional argument: 'resources'
However, I didn't have a preprocess function in my code. Upgrading nbconvert to 5.6.1 fixed the problem


Reword flutter run help screen.

Description
Reorganized the help screen to be more relatable to the user, by following common practices in command listing.
Related Issues
Closes #44090
Tests
I added the following tests:
I didn't add any other test but modified the ones that were in place:
packages/flutter_tools/test/general.shard/resident_runner_test.dart
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I signed the CLA.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I updated/added relevant documentation (doc comments with ///).
[X] All existing and new tests are passing.
[X] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[X] No, this is not a breaking change.

@Hixie I think @esarbanis was discussing this with you. Would you like to review it?

This rocks. I'll look at it in more detail tonight. Overall looks good except for stylistic nits.

We should wrap to the screen width if it's less than the maxWidth.
We should add some tests that check what the full output is in various conditions.

@Hixie I resolved the formatting issues ( 🤞)  and I will work on the screen size and test coverage.
Thanks for the pointers! I really appreciate your taking the time to review this.

@Hixie I made a significant refactoring so as to be easier to test. I would appreciate any feedback before I move forward with this design.

this keeps getting better, i love it

@Hixie @jonahwilliams I think I am ready for another review run 🤞

This is great, don't hesitate to add yourself to the root AUTHORS file

This looks great. LGTM.

@esarbanis can you fix the analysis error?
dart --enable-asserts ./dev/bots/analyze.dart
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
The following file import a test directly. Test utilities should be in their own file.

/tmp/flutter sdk/packages/flutter_tools/test/general.shard/base/command_help_test.dart

@jonahwilliams Thanks for your invaluable input, can you please give it another go?

@jonahwilliams any feedback?

@esarbanis It looks like the failing presubmit check could be related. You can check that by pulling up to head and doing another push. I believe @jonahwilliams said he was happy with the change once the presubmit checks are green, but I'll also re-request a review from him.

@zanderso thanks! I  rebased on top of the current master, let's see how the checks run 🤞

@esarbanis The issue is on this line:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart#L205
Its checking that the logs have an exact length (which is probably not the right thing to do...). If you reworded the help screen it probably changed the messages here. I would update the expectation clause after verifying what is printed is reasonable.

@jonahwilliams thanks!

@jonahwilliams @Hixie @zanderso Now that the Xmas and New Year vacations have come and gone, is it reasonable to ask for any feedback?

It looks like the test the @jonahwilliams mentioned still needs an update, and the merge conflicts should be resolved, then this should be ready to land.

Thanks @zanderso, I took care of the conflicts. If no new test break appears, then I guess I should wait for @jonahwilliams change.

@esarbanis I've reuploaded this PR here https://github.com/flutter/flutter/pull/48314 with the test fixed and merge conflicts resolved.

@zanderso thanks! I am closing this off then.


KAFKA-5277: Sticky Assignor should not cache previous assignment (KIP-54 follow-up)

... plus some minor cleanup

@hachikuji For your review. Thanks!

@vahidhashemian Thanks for the updates. LGTM

@hachikuji, could you please take a look at KAFKA-7026? It seems to me that having the leader keep the latest assignment might be useful after all (as a potential and simple fix for the reported bug). Will be happy to explain further if needed. Thanks!


Added missing contributors

Summary
Added 4 missing contributors into repo.
viren is Viren Sawant
cwalten is Christian Alten
bunnyLord is Tatiana Alexenko
Nerdenator is Aaron McRuer

These contributors are already on this list.


Only define NOMINMAX if missing

NOMINMAX may well be already defined if building this as part of an existing Windows codebase.

Any reason to not add this define to CmakeLists.txt?

@paulej I considered it, but I figured this works regardless of build system should someone decide to use this library in that fashion.


Add Java 20

Modeled after #204

Thanks for the PR @blaenk! It looks good, but going forward we've decided to replace the short-term release in the JVM provider buildpacks, rather than having 2 overlap. If you could please add a change to remove 19 while adding 20, similar to https://github.com/paketo-buildpacks/bellsoft-liberica/pull/383/files, we can get this merged!

Sure I'll do that when I get a chance if someone doesn't get to it first.
By the way, if someone specifies BP_JVM_VERSION to 19 then I guess things will break? Assuming they're using gcr.io/paketo-buildpacks/amazon-corretto:latest?
Does that mean that one shouldn't pin to :latest? Or what is the idea here? Should I not be pinning BP_JVM_VERSION?
Making sure I don't get myself into that situation.

Thank you @blaenk! To answer your question regarding 19, that is correct. The idea being that it's probably best to pin to the latest LTS version (i.e. 17 currently, with no need to manually pin since it's now the default), and users can specify short-term releases for exploring new features etc. It's definitely best then to use the :latest of the buildpack itself to get patches/maintenance updates etc.

Thank you @blaenk! To answer your question regarding 19, that is correct. The idea being that it's probably best to pin to the latest LTS version (i.e. 17 currently, with no need to manually pin since it's now the default), and users can specify short-term releases for exploring new features etc. It's definitely best then to use the :latest of the buildpack itself to get patches/maintenance updates etc.


Create Result Issue

I got this error when trying to create result

thanks for creating the issue.
Hope you have the latest code changes. Unfortunately I cannot able to reproduce this error page on my local. Please share the steps you followed.

thanks for creating the issue.
Hope you have the latest code changes. Unfortunately I cannot able to reproduce this error page on my local. Please share the steps you followed.

I got this error on your website https://django-school-app.herokuapp.com/
1 - i opened https://django-school-app.herokuapp.com/result/create/
2 - select first student and clicked on procced button
3 - select English and Physics checkbox
4 - clicked on create button and got this error

I got this error on your website https://django-school-app.herokuapp.com/
1 - i opened https://django-school-app.herokuapp.com/result/create/
2 - select first student and clicked on procced button
3 - select English and Physics checkbox
4 - clicked on create button and got this error


Non-lazy(Automatic) IsarLink/IsarLinks save() and load()

Is your feature request related to a problem? Please describe.
I'm always frustrated when the collection have many link/links since the all of them need manually call save() and load(), I understand this might help to improve performance if user only create/update of few of these fields, but it almost the top pain to manage and maintain these lazy link/links.
Describe the solution you'd like
Is it possible to give an option that let these link/links are automatic save and load, like object box do.
Version

Platform: iOS, Android,
Flutter version: [2.9.0-0.1.pre]
Isar version: [2.0.0 dev.1]

Thanks for this request. It's not planned in the immediate future because of performance considerations but I'll keep it in mind :+1:

Same problem here, I discovered Isar for a new project. I wonder if Isar is optimized for models with many relationships? Thank you @leisim

I'm going to close this for now as it is not likely to be implemented.

I would also really appreciate this feature. Perhaps it could be optional to automatically save them. That way you could still decide to not use this feature in case you want to make certain performance optimizations.


Fix for multicolored strings in CLI

Description
This PR fixes multicolored strings in CLI. See: #3173
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

@paulbalandan I hope you find some time after weekend and test this on Windows :)

@michalsn this solution works like a charm. Thanks.

On a different note. I don't know if this is worthy of a bug report but CLITest::testWrap always fails on Windows tests. I'll investigate further and let you know. Anyway, thank you.


Update to use Wagyu for clipper

I've started reviewing the visual changes. Right off I see something that looks problematic - it appears as if valid polygons are being lost with wagyu or the changes related to integrating wagyu.
If you look at the change to the tile0-b.expected.png https://github.com/mapnik/node-mapnik/pull/719/files#diff-4f291e06e1d0518dba661cecc3460514 the old image has all of northern Norway:

While the new image is missing northern Norway:

(Run the "swipe" on the github diff page or open them both in a browser tab and flip back and forth and the difference is obvious)
The missing regions appear to be Troms and Finnmark - ref https://www.openstreetmap.org/#map=6/68.588/16.699

The nz-1b.png testcase (https://github.com/mapnik/node-mapnik/pull/719/files#diff-c9615730b7b1b3b34d32861700d806dd) is also very different. It looks like previous to this PR many islands were dropped and now they are not. @flippmoke - what changed here? If this is expected, please add an explanation in the CHANGELOG.md

As per the questions around: https://github.com/mapnik/node-mapnik/pull/719#issuecomment-291265580
This is in some ways related to https://github.com/mapbox/mapnik-vector-tile/issues/131. Originally when we first put in the Angus clipper we were finding that better outputs with less errors were occuring when we did CleanPolygon. However, this typically removed data that was somewhat valid.
Wagyu was designed to deal with all the problems that CleanPolygon was doing, but in a much better way. Therefore, I am not shocked at all to see this data reappear.

https://github.com/mapnik/node-mapnik/pull/719#issuecomment-291263073
I really hate it when I don't remember why we have a test, but we do... The data is not missing from the tile because tile0.mvt is used for lots of other rendering tests and you see a few in the diff even, but they do not change more then perhaps a pixel.
This is the funky case when we are testing the rendering from a vector tile using a negative buffer.
vtile.render(map, new mapnik.Image(256, 256), {buffer_size:-64}, function(err, vtile_image) {

This might be slightly different due to a slight change in a coordinate of this little region that perhaps made mapnik do something different, or perhaps the latest version of mapnik has a small change here?


perf(plugins-iterator): cache globals and replace iterators with iterator getters

perf(plugins-iterator) cache global plugins for faster execution
perf(plugins-iterator) replace iterators with iterator getters

@ADD-SP, if you could benchmark this, it would be great, Thank you!

svg files

One note: this needs to be carefully adapted on EE.

I did two performance tests to confirm @fffonion 's result. I created a dummy plugin (on rewrite, access,  certificate, and log) and enabled it globally.
There are significant performance improvements.
Fixed RPS
This test aims to measure the latency.

Unlimited RPS


Aarti7

Title and Issue number
Prim's Algorithm #5102
Close #5102

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

Please review this PR under gssoc. @MohitGupta121 @TusharKesarwani @pranjay-poddar

@MohitGupta121 @TusharKesarwani @pranjay-poddar Please merge this PR under gssoc'23


feat: add error visual indicator pull image input - typeahead changes

What does this PR do?
Adds error classes and adds new property
Screenshot / video of UI
What issues does this PR fix or reference?
Part of #8926
1/2 PR's

[x] Tests are covering the bug fix or the new feature

The PR title is misleading, could you rename it ? We are not changing any notification related stuff, probably something like feat: add error visual indicator pull image input

We have some inconsistencies with the shortnames

By typing and removing sometime I am getting red or purple for hello-world

@axel7083 can you please re-check? I've split this PR into two smaller ones