js with window object fails to compile

TypeScript Version:  Version 2.0.0
Code
// from https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API/Using_the_Web_Storage_API
function storageAvailable(type) {
	try {
		var storage = window[type],
			x = '__storage_test__';
		storage.setItem(x, x);
		storage.removeItem(x);
		return true;
	}
	catch(e) {
		return false;
	}
}

Expected behavior:
This is a snippet of code from: https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API/Using_the_Web_Storage_API
Since this is sample javascript code, I was expecting it to work.
Actual behavior:
var storage gets typed as Window, and thus can't resolve setItem nor removeItem.

FWIW, my environment, I'm editing with Visual Studio Code, and running Ionic 2(beta) from the cli.  Both the ionic build and Visual Studio threw compile errors.
I'm not really sure what the error is exactly, so please edit the title as appropriate!

@ChogyDan the simplest fix is to annotate what the parameter type is allowed to be, like in the first line below (the rest is unchanged):
function storageAvailable(type: 'localStorage' | 'sessionStorage') {
    try {
        var storage = window[type];
        var x = '__storage_test__';
        storage.setItem(x, x);
        storage.removeItem(x);
        return true;
    }
    catch(e) {
        return false;
    }
}

Unfortunately we don't map string literals types to their property names (#6080), so @yortus' suggestion won't work fully.
You'll have to use a type assertion for storage:
let storage = window[type] as Storage;

TypeScript Version: I dunno, sorry

tsc --version

@DanielRosenwasser the version I posted does work fine and compiles too. The only difference is that storage gets typed as any instead of Window (if type is any then the compiler picks up the [index: number]: Window; declaration in the Window interface.
Typing storage as any seems OK here since the function is doing a runtime test for the existence of the methods. It storage were more strongly typed, it would give a false compile-time assurance that the methods existed, when they may not for some runtimes (which is the whole point of the function).

Version updated, thanks.  I also appreciate the recommended fixes for the code.  @DanielRosenwasser is interesting because both sessionStorage and localStorage type as Storage.
But for the sake of argument, explicitly typing storage as any also works, since that is what is supposed to be happening anyway.  I feel like that typing the return type of window[type] as Window is not what typescript should be doing.  I thought typescript was doing the "wrong" thing here, and that's why I filed a bug.

The surprising part as @ChogyDan mentions is this:
let a;
let b = window[a]; // type of b is 'Window' !?

This arises from the Window interface declaration in lib.d.ts which has the following indexer:
interface Window {
    ...
    [index: number]: Window;
}

I was going to suggest adding [index: string]: any to fix the OP case. However I tried adding it both before and after the numeric indexer but it didn't work. No matter which way I arranged the two indexers, indexing with any always used the numeric indexer and infered the result as Window.

i would say remove the indexer from Window all together.

@mhegazy I looked up the indexer in the spec, and it looks like it is supporting window === window.frames and window.frames is an array (which... makes window an array as well).  Indexing on window.frames gives a window object.
I thought removing the indexer might be a good idea, but I guess it won't follow the spec.
References:
Window object: https://developer.mozilla.org/en-US/docs/Web/API/Window
frames object: https://developer.mozilla.org/en-US/docs/Web/API/Window/frames
Discussion on how window===window.frames is confusing but the accepted standard for js: https://groups.google.com/forum/?hl=en#!topic/mozilla.dev.platform/VijG80aFnU8

I wrote that specific code snippet on Mozilla.com. I have to admit I have never used TypeScript before.
My idea for the snippet was that people should be able to easily copy-paste and use it... So I'm sorry to hear that it's giving issues. If you have any suggestions for how to change that snippet so it would work out-of-the-box in both TypeScript and Javascript then please share them here.

i do not think there is something wrong with the snippet per se. the issue here is the DOM spec says that indexing into the window object with a number returns you a frame, in the snippet, the TS compiler does not know what is the type of type would be at run time, so it is safe to assume it can be a number, @yortus' suggession in https://github.com/Microsoft/TypeScript/issues/10457#issuecomment-241240834 is the ideal workaround here.
My proposal is to remove the index signature all together. I would expect ppl indexing into window with any more than indexing into it with number to get frames.

Are we sure this isn't an issue with typescript itself?  It seems that indexing with type any will default to using the number indexer, instead of what would make sense to me, the string indexer.  I've written some sample code (in visual studio):
class NumberWasIndexed {
    makeNotAssignable: string;
}
class StringWasIndexed {}

class test {
    num1: number;
    string1: string;
    [number: number]: NumberWasIndexed;
    [string: string]: StringWasIndexed;
}
var aTest: test;

function someFunction ( all:           string | number | symbol | any,
                        withoutAny:    string | number | symbol,
                        _number:                number,
                        _string:       string,
                        _symbol:                         symbol,
                        _any:                                     any) {
    var stringIsIndexed = aTest[_string];
    var numIsIndexed = aTest[_number];
    numIsIndexed = aTest[all];  //Why is this using the number indexer?
    stringIsIndexed = aTest[withoutAny]; //and this one uses the string indexer.
    stringIsIndexed = aTest[_symbol];
    numIsIndexed = aTest[_any]; //same question
}

string | number | symbol | any === any. there is no difference, and there should not be, between all and _any.
The symbol one is a bug. i would say this should be an error. indexing with symbols is tracked by https://github.com/Microsoft/TypeScript/issues/1863
indexing with any, is the question here. numeric indexer is considered a subdomain of the string indexer. so the logic for look up goes like if there is a numeric indexer, and the argument is number like, then use it if not use the string indexer, otherwise it is any.  so if you are indexing with any, it is as likely to be a number as it is to be a string. given that most objects do not have both indexers, using the most specific seems the correct thing to do. this way indexing in an array with any will return you the element type and not just any.

using the most specific seems the correct thing to do. this way indexing in an array with any will return you the element type and not just any.

@mhegazy I don't think there is one correct thing to do here. The current logic favours arrays over objects, leading to surprises like this issue.
I was expecting similar behaviour to how TypeScript handles overloads - i.e. declaration order matters. The following example is very similar to this issue except the indexers are overloaded functions. In this case, calling indexer with an argument of type any will pick whichever overload is declared first. That way the programmer can tweak the declaration to get the most appropriate behaviour for that case.
interface Window {
    indexer(string: string): any;
    indexer(number: number): Window;
}
let w: Window;
let prop: any;

// If we swap the overloads above, a would be Window
let a = window.indexer(prop); // a is any (uses first overload)

The current logic favours arrays over objects, leading to surprises like this issue.

that is correct. except that non-array objects rarely have numeric indexers.

So in this specific case, would changing window[type] to window['' + type] help?

yes. But ideally you would not need to do this.

I was waiting for the "TypeScript gods" to make a declaration of how to resolve this dilemma: does TS need to change to accommodate more precise indexer definitions? or should the the .d.ts file be adjusted?
I realized that unless there are other abstractions that TS is trying to model that need complicated indexers, it shouldn't be changed.  The window abstraction doesn't need to be the driver for this change.  So removing the indexer seems like the right call.
I went ahead and researched how to do a pull request for this issue.  You can see my work here: https://github.com/Microsoft/TSJS-lib-generator/pull/146


Current tab indicator on top when tabs are at the bottom

Hi,
Not sure if it is possible, but I think in case the tabs menu is in the bottom of the screen, the indicator of the current tab should be in the upper part of that tab.

https://maykar.github.io/custom-header/#configuration/tabs
2nd config option

Sorry for that.
My bad....
On Sat, Feb 8, 2020 at 8:26 PM Ryan Meek<EMAIL_ADDRESS>wrote:

https://maykar.github.io/custom-header/#configuration/tabs
2nd config option
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/maykar/custom-header/issues/130?email_source=notifications&email_token=ABKRVKSRUI733WA4TES5OSDRB32MHA5CNFSM4KR4DXZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFYNAI#issuecomment-583763585,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKRVKUQGJ62RCJCUCXIXVDRB32MHANCNFSM4KR4DXZQ
.

--
Dima Trosman


Yarn PR's do not include offline mirror files

If yarn is configured to use offline mirror then during an install/update the tarballs are stored in a directory which is committed to the repo. This means the repo still works if flying, a package goes missing from npm, etc. It also happens to speed up the install process quite significantly.
The PR's created by dependabot do not include the updated/removed tarballs.

@infin8x Any updates on this concept?  Looks like this works with go/ruby but yarn offline mirror is missing (also may be easy change due to already respecting .yarnrc file.

Unfortunately I'm not on the Dependabot team anymore. @mayakacz or @feelepxyz may be able to get you in the right direction.

@Austio we haven't had a chance to look at this but we have a few issues that are related to the fact that we only partially insert the .yarnrc into updates (dependabot only extracts the registry if it's set to registry.npmjs.org). We also don't clone the full repo contents for javascript projects so would have to do that before updating the vendored dependencies.
We're currently focusing on update existing ecosystems so will be a while before we can look at this.

Duplicate of:

https://github.com/dependabot/dependabot-core/issues/462


BenchmarkDotNet Out-of-box experience and "getting started" documentation

I just wanted to put together a list of things that I think could be done to make it easier for new users to get started with BenchmarkDotNet.

[X] Getting started guide on the github repo

at the moment the front page mostly covers "Why is microbenchmarking hard?", which is really valuable, but I think it should be put elsewhere and linked to.
I think the first thing people should see is a list of features (there already), plus a really brief "getting started" guide, showing how to write a simple benchmark and how to run it (some of this already exists).

[ ] Use NuGet to automatically add a simple benchmark to your project when you add the BenchmarkDotNet package.

I've done this before and NuGet makes it easy via source code transformations

[ ] ????? (anything else)

Let me know if you have any other ideas and I'll add them to the list above, then we can tick them off as they get done.

“Getting started” is a great idea, we definitely should have such section.
We can replace "Why is microbenchmarking hard?" with the link to http://andreyakinshin.gitbooks.io/performancebookdotnet/content/science/microbenchmarking.html

@mattwarren, I have updated the README. What do you think?

My thoughts on getting started (and apologies if I didn't follow the readme correctly:

@smudge202 how exactly are you executing the tests?
From reading this comment I assume that you are using DNX, is that right?
@AndreyAkinshin has only recently added support for CoreCLR, so maybe this is related

The CoreCLR support will be added after Microsoft Connect(); 2015, I'm waiting for some updates. =)

Do you know if the issue that @smudge202 is getting is related to DNX/CoreCLR support?
Or do you think it's a general problem because his Benchmark look like this:
[Benchmark]
public void DispatchingToNoReceivers()
    => Dispatcher.Dispatch(Event);

and we don't currently support that type of Benchmark?

As per the comment you referenced, @mattwarren , I'm fairly sure it'll be a DNX incompatibility. Unfortunately, the NuGet package doesn't list supported frameworks.

Ignore my comment above, I just ran a test and we do support [Benchmark] methods created with the new C# 6 syntax, i.e. this works fine:
[Benchmark]
public void SleepWithCSharp6Syntax() => Thread.Sleep(100);

@mattwarren, I believe you're confusing DNX/CoreCLR with C#6. Two very different things.
C#6 is independent, simply something the compiler does or does not support.

@AndreyAkinshin I just saw this post The road to DNX – part 1 and thought you might find it useful when you do the DNX/CoreCLR work.

I've taken a look at this issue and published my WIP branch here.
The actual issue is of course an incompatibility with vNext projects (or whatever name we're going by today), but I went a step further and converted the existing projects too (hopefully that doesn't present too much confusion, but it does prove that even the existing tests fail when hosted by DNX). I actually wanted to see if we could get a netstandard1.*/dotnet5.*+1 TFM in there as well, but I think the third party and framework dependencies will prevent that.
Anyway, the specific issue is that whilst running under DNX (such as through the xunit.runner.dnx as shown in the linked fork because I've converted the existing tests to run under DNX), you don't get as much information or even the same information relating to assemblies. Assembly paths will typically return the location of dnx.exe, whilst Assembly.Location will return null, as is the case on this line.
To work around this, I previously used this stackoverflow answer. Here lies the issue, the current API handles all assembly/file/type handling internally and I see no obvious extensibility points whereby DNX could be plugged in to the core library allowing the location to be retrieved correctly based upon the underlying runtime.
I could take a stab at making BenchmarkDotNet more extensible in order to allow such a plugin mechanism, though it may well be easier to cross compile the core code with separate BenchmarkClassicGenerator classes based upon TFM and wrap them uptogether in the same nuget package? I don't want to sink too much time into this without someone up the chain taking a peak and pointing me in the direction you'd like to go (even if that direction is to buzz off :) )

@smudge202,

I could take a stab at making BenchmarkDotNet more extensible in order to allow such a plugin mechanism

I'll be grateful for any help! CoreCLR support is a very important feature, we need it in order to measure efficiency of new version of RyuJIT.
About the architecture: now we have the following interfaces: IBenchmarkGenerator, IBenchmarkBuilder, IBenchmarkExecutor, and the "classic" implementations of it. I want a new "DNX" implementations (or which name should we choose?). Next, BenchmarkToolchainFacade should be able to create a facade for new implementation in the CreateToolchain method. The BenchmarkToolchain enum should have a new value (like Dnx) which we will use in BenchmarkTasks. Ideally, the DNX support shouldn't affect to other parts of the library (except Generator/Builder/Executor).
Feel free to ask any details (we can discuss the subject in a separate issue or in the chat).

Thanks for the information, @AndreyAkinshin . To be clear, I believe CoreCLR support and DNX support are going to be two different issues.
To move to CoreCLR (and take advantage of what I hear is coming with rc2 in February, I think we need to find a way to drop the dependencies on System.Management, Microsoft.Diagnostic.Runtime, Dia2Lib, and Interop.Dia2Lib. To be honest, apart from seeing that we reference them, I haven't see how deeply nested the dependency goes. I recommend opening a second issue to tackle CoreCLR.
With regards to DNX, I actually took a look at implementing a cross compiled version last night. I defined DNX (which I think David Fowler hates...) into a dnx451 target, pulled in a Microsoft.Dnx.Runtime dependency for the dnx target, and started going through all the interfaces available through the common service locator. We can get access to the LibraryManager, RuntimeEnvironment and ApplicationEnvironment, however, none of those expose the assembly location. Thinking about it, that is probably by design. I won't speculate with regards to my very poor understanding on how DNX compiles (on the fly?) and how assembly location probably doesn't make sense.
I think there are two options. Ask guys from the DNX team (hop into their gitter or @ them on here) what they would recommend (should probably leave that as a last resort). Alternatively, examine why it is we need (or think we need) the assembly location. I only briefly glanced at the consumer code, but it almost looked like it was trying to generate a csproj style reference?

I think we need to find a way to drop the dependencies on System.Management, Microsoft.Diagnostic.Runtime, Dia2Lib, and Interop.Dia2Lib

@mattwarren, can you move these dependencies from the core to another assembly in the nearest future?

I think we need to find a way to drop the dependencies on System.Management, Microsoft.Diagnostic.Runtime, Dia2Lib, and Interop.Dia2Lib

Yeah no problem, in the next few days I'll check-in some changes so that these are moved out of BenchmarkDotNet core and put into "BenchmarkDotNet.Diagnostic" as we discussed.

In The road to DNX - part 2, Marc says this:

I do not recommend polluting all your code with constant #if. Rather, my strategy is to create a utility class that bridges the gap (usually, but not always, via extension methods), and have just that class deal with different implementations.

It would be nice if we could follow this advice as it seems a lot cleaner to have all the #if code in as few places as possible. (not saying you were going to do this, just wanted flag it up)

Yup. I usually ifdef to get things running and then look to clean things up. Happy to go with extensions if/when we move forward on this.

@mattwarren, are you happy with current version of README?

It's been a while since I read through it all the way, I'll take a look in the next day or so and if I spot anything I'll make some changes.

Great, thanks.

Now we have nice documentation with the "Getting started" section. We also have another issue about online documentation: https://github.com/PerfDotNet/BenchmarkDotNet/issues/219


Coverage is not displayed in PR comment.

I'm trying to use<EMAIL_ADDRESS>with a multi-module project.  Jacoco reports are generated, paths to jacoco.xml files are set, but after successful action run I have nothing in the PR comment. End of the log file in debug mode:
overallCoverage: [object Object]
filesCoverage: {
"files": [],
"percentage": 100
}
My Jenkins env is able to display the same Jacoco reports, so they are ok.

Let me check and get back.
By the way, is this an android project or a multi module java project ?

multi module java

The root cause was environmental, wrong configs


PKGBUILD?

A PKGBUILD would allow it to be put into the AUR giving it a potential bigger audience.
I would be willing to create one.
Or it maybe useful to make your own, so you can learn if you haven't, DollarSkip's PKGBUILD seems to fit exactly

Actually I have already created one some time ago based on the webcord one: https://github.com/Itai-Nelken/aptpac/blob/main/C-edition/PKGBUILD
Thanks for the suggestion!
A problem is that there already is a app called aptpac in the AUR...

Why not just call it aptpac-c

good idea!

I added a script that generates a PKGBUILD for the C-edition. the PKGBUILD generated is based on the DollarSkip one, si thanks @cleanmachine1!
commit 6b6efea072ca3fea01b828eca324bf47a8fea722


Suggest additional serialize option

When I use message, I use serialize a lot.
How about using the rinf message option (such as -useSerialize) to enable serde::Serialize, Deserialize?

Hi @rabbitson87 , thanks for your opinion.
May I ask you why Protobuf serialization is not sufficient for you? Is it slow, or is there any other reason?
For now, if you want to use other serialization method for some messages, you can pass binary data between Dart and Rust to do that. If I've missed something, please let me know.

https://rinf.cunarist.com/messaging/#binary-data

I used serde to deal with rust, but I think it can be solved by using protobuf.
I'll look for more thanks!


Correction for raw affiliation CIRAD, UPR HortSys, ELSA, F-97232, Le Lamentin, Martinique, France

Correction needed for raw affiliation CIRAD, UPR HortSys, ELSA, F-97232, Le Lamentin, Martinique, France
raw_affiliation_name: CIRAD, UPR HortSys, ELSA, F-97232, Le Lamentin, Martinique, France
new_rors: 05kpkpg04;03573dx38;03x53g461
previous_rors: 0376kfa34;05kpkpg04
works_examples: W4389545973
contact: f730ae00153c51650e729a637b126a05:87f44b18d5b6e878be521222f32f @ cirad.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Need to rotate stream without rotating preview.

I need to rotate the stream without preview rotation in order to support both portrait and landscape modes. It looks like it can't be implemented right now. I'm using OpenGLView.

Hello,
It is not implemented. I have little time this weeks but I will developed it the next feature, but for now, I'm trying to fix other problems.

Use rotation example
Closing as inactive.


Can't check contents of directory in local network (unknown status)

Wrong. It was just me not pressing "Apply" button. Need to add question about applying settings when pressing "Update".


Drop the Address table

According to the offline-discussion on 10.03.23 we decide to drop the Address table

Done with 17fad58


Improve speed in workflow build-related operations

Not sure if this is a limitation of the images that we are using or what, but both release and PR workflows are slow.
What could we do to improve these build times (possibly caching?

@ggirotto what do you think about this?

I have a strong hypothesys about speeding up the release workflow. Today we build the iOS app twice: first by using flutter build and second by using build_ios_app fastlane action. I'm almost sure that we could just remove the build_ios_app fastlane action and keep just flutter build. I've notes on my side to test it, but I haven't tested yet.
In the pull_request workflow, we could definitely cache flutter SDK. I've tried for a few hours, but without success I gave up because this github actions task were taking to long, but now I think we could go back and improve this caching stuff
Cache reference: https://github.com/subosito/flutter-action/issues/16

I think #98 resulted in a decent performance improvement (I guess it was around ~33% of less time spent passing the workflow).
@ggirotto Are there other improvements that comes to your mind in both pull_request and release workflows that we can keep track, or do you think the time vs benefits are not worth to further improve the total time spent?

I had another hypothesis about caching the Flutter setup, but since the time taken to setup Flutter env is of only ~50 seconds I don't think it will bring great benefits to the overall build time.

Closing as we've reached a decent improvement with #98, although we can still look forward to more improvements if they appear plausible


Add SSL root certificate support

@nooberfsh please check the PR

@nooberfsh please check the PR

Hi, thanks for the PR, I will review it after work.


panic: open /var/log/web-history.log: permission denied

I just pulled the code and ran make
looks like is assumes the log folder ?

# setup config.
cp example.setting.toml setting.toml

./history-engine-darwin-arm64
{"level":"debug","time":"2024-05-27T19:43:10+10:00","message":"open .env: no such file or directory"}
panic: open /var/log/web-history.log: permission denied

goroutine 1 [running]:
history-engine/engine/setting.checkFileExist()
        history-engine/engine/setting/log.go:30 +0x70
history-engine/engine/setting.loadLogger()
        history-engine/engine/setting/log.go:21 +0xc0
history-engine/engine/setting.Load({0x1034cff7e?, 0x1034c78b0?})
        history-engine/engine/setting/setting.go:19 +0x38
main.loadSetting(0x1400060f840?)
        history-engine/engine/main.go:46 +0x60
github.com/urfave/cli/v2.(*Command).Run(0x140000d2160, 0x1400060f840, {0x14000030180, 0x1, 0x1})
        github.com/urfave/cli/v2@v2.27.1/command.go:219 +0x3d0
github.com/urfave/cli/v2.(*App).RunContext(0x14000636400, {0x10378c2f8, 0x103ccd460}, {0x14000030180, 0x1, 0x1})
        github.com/urfave/cli/v2@v2.27.1/app.go:337 +0x514
github.com/urfave/cli/v2.(*App).Run(...)
        github.com/urfave/cli/v2@v2.27.1/app.go:311
main.main()
        history-engine/engine/main.go:34 +0x334

Probably best to extend the Makefile to setup a runnable system in the Releases folder
Also add a Procfile and use runner to run both things at once:
https://github.com/gedw99/runner

Thanks for the reminder.
The default log path is indeed incorrect.
This project is still under development, and the overall progress is only about 30%.


Feat/improve doc build logic

Description
This PR will close #501. Pre-build scripts are set up as hooks in conf.py and "sphinx-build ..." is being called directly in tox instead of "make ..."
Checklist

[x] I have tested these changes locally.
[x] I have added necessary documentation or updated existing documentation.
[x] I have linked the issue(s) addressed by this PR if any.

Noted @FedericoNegri .


Array types

Term introduction syntax:
[1, 2, 3]

Type formation syntax:
T[]

But the term elimination stuff could have different styles:

OOP methods
Global functions with the reverse application
Interface methods

That's tough...

I prefer defining the array type in prelude, but some of the disadvantages are clear:

Array type would be written like Array<T>, but we could define some syntactic sugar for it, legalizing T[], T[][], etc.
How to model the variadic constructor for the array? I.e. [1, 2, 3], like you could model other function's parameter using arrays, but what about the array itself...

We could put Array<T> in the prelude and NativeArray<T> in the builtins, the native array is quite like the builtin array type in JavaScript and its methods would be like Array.prototype.X stuff
The variadic constructor [1, 2, 3] will only work for Array<T>, and there would be a generated constructor for Array<T> that receives a native array, we could simply ignore it. Most of the users should use [] or [1, 2, 3] to create an Array<T>
The variadic constructor [1, 2, 3] will be translated into a concrete expression and an abstract term called Arr, with type of Array<T>

Still got some trouble: The prototype function Array.prototype.at for JavaScript's native arrays is of type (n: number) -> T | undefined, it's tough to transform union types into tagged unions without much cluttering (e.g. not quite elegant to call the imported RowScript API function enumify).

JavaScript's native arrays is of type (n: number) -> T | undefined.

Add new term definitions to the abstract syntax and upon code generation we do some converison.

For now the .length property can only be a method call... similar properties would make the daily-used prelude types pretty ugly.


Bump version to 0.10.1.dev0

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Merge 1.6.3

TravisCI is failing on both Linux and macOS. It looks as though perhaps gems are not being installed correctly.
==> brew audit testbottest --online
Error: No such file or directory - rubocop
==> FAILED

https://travis-ci.org/Linuxbrew/brew/jobs/374573738#L345
https://travis-ci.org/Linuxbrew/brew/jobs/374573739#L706

I don't have the time at the moment to debug the TravisCI failure. Merging despite the TravisCI failure.

PR https://github.com/Homebrew/brew/pull/4149 adds it back.


Updates CI configuration

Updates README
Simplifies Travis CI configs

It looks like line 7 of the README has an erroneous URL that needs cleaning up:
Download the https://jekyllrb.com/repository to your local machine using git:


Update MS Date

Updating the MS Date to indicate the article is current

@DavidCBerry13 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


2.x Use Eureka 1.x mock server in bridge integration tests.

NetflixOSS » eureka » eureka-pull-requests #84 SUCCESS
This pull request looks good


Allen & Heath SQ5 module the softkey's doesn't work anymore in Companion

In version companion-2.2.0-100a58c5-3364-mac and later the Softkey's don't work anymore in Companion.
In Version  companion-2.2.0-6a43713a-3345-mac works everything fine.
Tested on mac os.

Hi @webby123, you are right! In that update I added the possibility to configure what MIDI channel is used. In SK function I didn't change that value. Thanks, I fix the issue and in next beta release all will back to work correctly.


Rotating journal logs

Rotating and vacuuming journal log files to prevent running out of disk space on /.

It's the file that is growing without bound on the instances, so at this point I believe it is the cause of the outages.

And reformatted the code for line length

I'm curious, what is writing logs? I just checked out staging site, and we don't seem to have processes that write log files..

It's the base OS that runs the Docker instance that houses the AppEngine Flex images, along with fluentd logging and nginx networking sidecars. It basically looks like Kubernetes + Istio, but I think it predates that tech. The logfile in question is controlled with journalctl, and can be easily rotated and culled, but I can't control the base image that runs AppEngine Flex. I'd much prefer if it were running Container Optimised OS instead of Debian Stretch.


update to jre 8u181

@smelchior Thanks! I have pushed all the other branches (cleaned and full), and they are building on DocherHub at the moment.

perfect, thank you!


Change Future to CompletableFuture in java client

Future.get() blocks threads and causes performance issues for users of the java client library or requires an additional watcher thread checking for completions and issuing callbacks.  The underlying HTTP client provides non-blocking IO and a ListenableFuture that is easily modified into a CompletableFuture.
Using callbacks users of the library will see higher performance without any noticeable drawbacks.
CompletableFuture implements Future so any users of the library can continue to do so without changing their code should they choose to do so.

Please assign this task to me. Thanks


Update jokes.json

Remove gender assumptions.

Remove gender assumptions.

@IEvangelist Now it looks good. Thanks


PlugDiff with vim-startify

Explain the problem here ...
With mhinz/vim-startify installed if I open a new neovim instance and I run :PlugUpdate followed by pressing D for the differences. The screen looks like this:

As you can see there is a random empty second window.

NVIM v0.1.3-244-g3e0fab6
Build type: Dev
Compilation: /usr/local/Library/ENV/4.3/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector
-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -I/tmp/neovim20160227-5566-ze7f7v/build/config -I/tmp/neovim20160227-5566-ze7f7v/src -I/tmp/neovim20160227-5566-ze7f7v/dep
s-build/usr/include -I/tmp/neovim20160227-5566-ze7f7v/deps-build/usr/include -I/tmp/neovim20160227-5566-ze7f7v/deps-build/usr/include/luajit-2.0 -I/tmp/neovim20160227-5566-ze7f7v/deps-build/usr/include -I
/tmp/neovim20160227-5566-ze7f7v/deps-build/usr/include -I/tmp/neovim20160227-5566-ze7f7v/deps-build/usr/include -I/tmp/neovim20160227-5566-ze7f7v/deps-build/usr/include -I/usr/local/opt/gettext/include -I
/usr/include -I/usr/include -I/tmp/neovim20160227-5566-ze7f7v/build/src/nvim/auto -I/tmp/neovim20160227-5566-ze7f7v/build/include
Compiled by nhooyr@aubble

Optional features included (+) or not (-): +acl   +iconv    +jemalloc
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/HEAD/share/nvim"

Type:

[x] Bug
[ ] Enhancement
[ ] Feature Request
[ ] Question

OS:

[ ] All/Other
[ ] Linux
[x] OS X
[ ] Windows

Vim:

[x] Terminal Vim
[ ] GVim
[ ] Neovim

Hi, this is a duplicate of #426.


Request: Add Version number to script to enable better troubleshooting.

Add a version number to the script. This will help identify what version of the script a user is using.
Example would be if a user finds an error, but there version is 1.5. But according to github, the latest is version available is 1.7.
You could then easily inform the user to update and retest before anyone takes the time to troubleshoot further when it could have been something that may have already been resolved.
Just a thought...

That's what the commit hash tags are for
Not really interested in doing this


PettingZoo version and missing dependence.

To replicate the result of your work in the MPE environment, the following packages should be installed (and are not mentioned in your documentation)
pip install gym==0.21.0
pip install pettingzoo==1.21.0
pip install supersuit ==3.3.0
pip install icecream

Right. Thanks for your correction. We will have a major revision to our instructions.  Issues will be fixed and add new functions will be added.

To replicate the result of your work in the MPE environment, the following packages should be installed (and are not mentioned in your documentation)
pip install gym==0.21.0
pip install pettingzoo==1.21.0
pip install supersuit ==3.3.0
pip install icecream

Thank you so much! May i ask what's your Pytorch version? Thanks!


Can't "see" iPega PG-9077

I am running python 3.6.3 on windoze 10.
I have a bluetooth keyboard and mouse by Microsoft.
I have a iPega PG-9077 connected to windoze 10 by bluetooth.
from inputs import devices
devices.gamepads
[]

Keyboards and mice returns single (expected) connections so that'll be the microsoft pair.
So, is there something else I need to to get inputs to "see" the iPega gamepad please?

Is there any way you can set it to emulate a XBOX 360 controller?
Otherwise, I'll have to buy one and find out.


Check for ngx translate extract issue

See hotfix #4077 and the issue at ngx translate extract https://github.com/biesbjerg/ngx-translate-extract/issues/118

Cannot reproduce this issue in current angular 7.2.5
@FinnStutzenstein please test again and close this issue if it seems to be fixed


Project name
Code Buddy
Description
This is a Microsoft Teams Bot to review your PRs - It responds to chat commands. Just type in your PR in the chat and get them reviewed by AI. It has been developed using large language models and trained on OpenAI Studio.
Repo link
https://github.com/goyal-anjali/anjali-davinci-bot
Video link
https://www.kapwing.com/w/TK7JKDEWmp
Do you often feel overwhelmed by the number of Pull Requests (PRs) waiting for your review? 😓 Or do you get impatient when your own PRs are delayed or ignored by others? We know how you feel!
But don’t worry! With "Code Buddy", your LLM powered Code Reviewer, you can clear your PR review backlog and stop nagging your coworkers. 🙌
The criteria it covers

Code Hygiene
Formatting issues
Exception handling
Validation checks
Design principles

Here's how Code Buddy enhances your productivity ⏱ :

Can be triggered from various sources - Teams, ADO, or CLI 💪
It handles the boring tasks of “nitpicking” and pointing out formatting errors 😅
It categorizes the issue as a bug, enhancement or a performance issue🔧
It integrates smoothly with Teams 🚀
It identifies all the changed files in a PR and comments at the right line numbers. ⚡

Get ready to do more with less.
It can:

Learn from your team’s codebase to provide more relevant review comments. 📚
Adapt to your and your team's specific coding style. 👥

No more endless back-and-forth discussions on code reviews, no more delays in merging critical changes. 😎 Impress your managers by delegating menial tasks to DaVinci, saving your brain power to tackle more complex challenges! 💡

Thank you for your submission @goyal-anjali, we are looking forward to checking out your project! Would you be willing to fill out the feedback survey? That'd help us learn from your experience and improve the hackathon next time: https://aka.ms/hack-together-teams/survey


add -Xfuture option. fix warnings

procedure syntax and view bounds are deprecated

Codecov Report

Merging #825 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   87.99%   87.99%
=======================================
  Files          64       64
  Lines        1499     1499
  Branches        4        4
=======================================
  Hits         1319     1319
  Misses        180      180

Impacted Files
Coverage Δ

core/src/main/scala/shapeless/syntax/sized.scala
66.66% <ø> (ø)
:arrow_up:

...main/scala/shapeless/syntax/std/traversables.scala
100% <100%> (ø)
:arrow_up:

core/src/main/scala/shapeless/test/package.scala
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06fd39a...00f2755. Read the comment docs.

Many thanks for that ... it's saved me from a huge chore ... very much appreciated :-)


changefeed: error with 400 for nonexistent change_id

Check early that the change_id parameter exists for rethinkdb instead of returning a 500 on a query error.
Closes https://github.com/theupdateframework/notary/issues/1257
Signed-off-by: Riyaz Faizullabhoy<EMAIL_ADDRESS>

I always figured the fix for this would be to default the change ID at the handler/input verification level, rather than erroring when not provided.

@endophage: that works too.  Do you think "0" makes most sense, even in the context of rethinkdb?

Yeah, and I also have a strong preference for making Go's "zero" values the defaults whenever possible.


Add a managed storage interface with tests.

transparent when no failures occur
cache first when failures occur with 5 second retries

Codecov Report

Merging #84 into development will increase coverage by 0.68%.
The diff coverage is 85.71%.

@@               Coverage Diff               @@
##           development      #84      +/-   ##
===============================================
+ Coverage        33.72%   34.41%   +0.68%
===============================================
  Files              245      246       +1
  Lines             3143     3185      +42
  Branches           218      224       +6
===============================================
+ Hits              1060     1096      +36
- Misses            1971     1977       +6
  Partials           112      112

Impacted Files
Coverage Δ

...nt-lib/src/adapters/database/ElementRXDBAdapter.js
86.2% <ø> (ø)
:arrow_up:

packages/element-lib/src/adapters/storage/index.js
100% <100%> (ø)
:arrow_up:

...lement-lib/src/adapters/storage/storage-manager.js
85.36% <85.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dfb639...da1b9fd. Read the comment docs.

Looks good, just need to run clean and bootstrap for the lock files.

I ran that and there were no changes.


Go crashes

Got a SIGSEGV: segmentation violation.
Just write request.url in line 33 instead of "" in the example main.roc. Then you got a bad error ...

Fixed


Add Callout for Publishing Requirements between AAD/Teams/SPO

I'd like to ask if there can be a callout for the current behavior of labels between M365 Groups/Teams/SharePoint Online.
Current behavior:

SPO for Admins: Requires that a label exist and be scoped for Sites/Groups.
SPO for Users, M365 Groups, and Teams: Requires that the label exist, be scoped for Sites/Groups, and be published to the users via Label Policy.

This may make sense to add after this section:
Thanks!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d40ac52-6f02-b0f3-0c45-9f359473703b
Version Independent ID: 108355a9-05a3-4d17-c417-c4d5664a4506
Content: Use sensitivity labels with Microsoft Teams, Microsoft 365 groups, and SharePoint sites - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/sensitivity-labels-teams-groups-sites.md
Service: o365-seccomp
GitHub Login: @cabailey
Microsoft Alias: cabailey

@SeanTGeoghegan  We have already documented that these labels must be scoped to sites & groups, and published for users to apply.  What you might be missing is the following sentence in the SharePoint admin center section (https://docs.microsoft.com/en-us/microsoft-365/compliance/sensitivity-labels-teams-groups-sites?view=o365-worldwide#view-and-manage-sensitivity-labels-in-the-sharepoint-admin-center):
"Unlike user apps, where sensitivity labels can be assigned to specific users, the admin center displays all sensitivity labels for your tenant."
If admins are applying them in apps, the labels still need to be published.

@cabailey you are right - I did miss that part! Thank you for the clarification.

Use the page's list of admin centers vs user apps - and which ones support sensitivity labels for sites & groups: https://docs.microsoft.com/en-us/microsoft-365/compliance/sensitivity-labels-teams-groups-sites?view=o365-worldwide#support-for-sensitivity-labels   For example, the Azure portal for group management lets you assign the labels as admins, Teams admin center doesn't yet support these labels.

Thank you for that,
The Azure AD M365 Group Management interface requires that Sensitivity Labels be published to the user creating the group, even though it is an admin center - any admin creating groups that does not have them published will not be shown the Sensitivity Drop down.

Thanks, let me check these with engineering.

@cabailey Awaiting your kind response. Thanks

Yes - not forgotten!  Support for the Teams admin center was confirmed by engineering & updated on the page. The anomaly for the Azure AD portal was the reason for the delay & still under discussion with engineering.  The expected design is that an admin would be able to see all the labels, but the Azure AD documentation does say "The current signed-in user must be within the scope of the sensitivity label publishing policy".  I wondered if this difference is because users who aren't admins can create and then manage Microsoft 365 groups in the Azure AD portal - so the portal here is acting more like a user app than an admin portal.
Since the Azure AD documentation has this requirement, I'm updating the page day today to reflect this but will need to update again if there's a change to allow admins to see all labels.

Doc update live now, so closing this issue.  But I will continue to look into this & revise as needed.


Buffer128 param should be four Buffer32 params

This parameter, and its singular command, is too underspecified. Thus, it was implemented in a manual manner by the compiler.


Setting an option value via array syntax is not permitted

Hi
Why is setting values not permitted?
I want to use a "--dry" flag that will automatically activate few other options via boolean flags, so the user doesn't have to type 3 switches but just to use one.
$command= new Commando\Command();

// some options are defined here

//--dry flag should enable --skip --run --show flags
if ($command['dry']) {
    $command['skip'] = true;
    $command['run'] = true;
    $command['show'] = true;
}

Fatal error: Uncaught Exception: Setting an option value via array syntax is not permitted in C:\......1
Stack trace:

Is there any workaround? Like get a copy of parsed options as array and then overrwrite?

Found solution
$command->getOption('skip')->setValue(true);
$command->getOption('run')->setValue(true);
$command->getOption('show')->setValue(true);


Form Switch Label Text

Trying to utilize the Switch toggle as such:

  <input id="switch-example" type="checkbox">
  Subscribe to our weekly newsletter

Results in:

One would expect this result?

@huphtur What CSS changes did you make to get the expected result?

Additionally the switch does not work if the label is set (at least on Chrome / Win7)

Sorry, forgot to mention I created the expected results image in Photoshop. Label text before the switch would also be a good solution for both UX and accessibility.

:+1:

It might be possible to make the body of the switch a pseudo-element, and then the text just sits after it. The thing is that the switch itself needs to be clickable, and not require any JavaScript, which is why it's always been structured how it is.
However, people have also asked that we support text inside the switch, although it might be possible to support both. Inner text isn't a label, anyway, it's a state.

You can have more than one label associated with a form input. Try using this:

  <input id="switch-example" type="checkbox">

Subscribe to our weekly newsletter

.switch {
  float: left;
  margin-right: .5rem;
}
.switch + label {
  line-height: rem-calc(34);
}


Return ResponseBuffer and close tab after each request.

Fix for issue #16:
	Always return `ResponseBuffer` as body instead of `ResponseText`.

Fix for issue #13:
	Move `page.close()` out of try block, so that the tab closes before
	returning the response.

Closes #16
Closes #13

Could you fix your linter and stop having it modifying the whole file? It makes difficult to review what changed, and also I don't want to have a space between the value in a function, example that I don't want:
const puppeteer = require( 'puppeteer-extra' );
const StealthPlugin = require( 'puppeteer-extra-plugin-stealth' );
puppeteer.use( StealthPlugin() );

Thanks. I'll test that hopefully today.

Sorry for making you wait for this PR to be merged.
I've tested it and it works great. Thank you for your contribution!


to solve onBlur problem with IE

This correction are fixing the issue #43, but is needed to review this solution because i think we can improve this one.

we have improved our code and implemented overlay for this issue.


Use specific service gem for Google Drive API

Using google-api-client directly is deprecated and emits a warning on
bundling - we should be using the service-specific gem
google-apis-drive_v3 instead.

Although, I think we use google-api-client for a couple of other things too (e.g indexing)

Although, I think we use google-api-client for a couple of other things too (e.g indexing)

Although, I think we use google-api-client for a couple of other things too (e.g indexing)

The BigQuery indexing happens through the google-cloud-bigquery gem (which ironically uses google-api-client under the hood :trollface: ), so shouldn't be impacted I don't think... At least from my brief digging through!

Although, I think we use google-api-client for a couple of other things too (e.g indexing)

The BigQuery indexing happens through the google-cloud-bigquery gem (which ironically uses google-api-client under the hood :trollface: ), so shouldn't be impacted I don't think... At least from my brief digging through!

Ooooh I see now, the actual indexing. How did I miss that 🤦

Ooooh I see now, the actual indexing. How did I miss that 🤦

Ooooh I see now, the actual indexing. How did I miss that 🤦

I was just looking at the scope array in config/initializers/google_api.rb. I'm not sure if we're using analytics or not

Ooooh I see now, the actual indexing. How did I miss that 🤦

I was just looking at the scope array in config/initializers/google_api.rb. I'm not sure if we're using analytics or not

It doesn't look like we are – all I could find was some reference in the docs. Will merge this and see if Steven starts screaming 😁

It doesn't look like we are – all I could find was some reference in the docs. Will merge this and see if Steven starts screaming 😁


Correction for raw affiliation Cirad; UMR Eco&Sols [Dakar, Senegal] (Senegal); VARTC - Vanuatu Agricultural Research and Training Centre (Vanuatu)

Correction needed for raw affiliation Cirad; UMR Eco&Sols [Dakar, Senegal] (Senegal); VARTC - Vanuatu Agricultural Research and Training Centre (Vanuatu)
raw_affiliation_name: Cirad; UMR Eco&Sols [Dakar, Senegal] (Senegal); VARTC - Vanuatu Agricultural Research and Training Centre (Vanuatu)
new_rors: 057k8nt63;00b80ez59
previous_rors: 057k8nt63
works_examples: W2930561789
contact: 3e4d1251a2bbcdb94aa886a601b12192:3c90772903237320ef0b3f8e308ad3d01d32 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


CMake fixes

This PR addresses most of https://github.com/triton-inference-server/server/issues/3141. Summary:

Isolate RapidJSON dependence to cases where it is actually used (HTTP CC client, perf analyzer, examples)
Add CMake option TRITON_USE_THIRD_PARTY, on by default. If turned off, disables installation of third-party dependencies for CC clients (in case dependencies are obtained separately)
Add CMake option TRITON_KEEP_TYPEINFO, off by default. If turned on, disables the use of ldscripts to keep typeinfo (needed by some sanitizers etc.), following #2404
Propagate related flags added to common repo in https://github.com/triton-inference-server/common/pull/46
Remove unnecessary dependencies in gRPC CC client: core repo, json libraries
Remove unused TRITON_BACKEND_REPO_TAG flag

The goal here is to be able to install just the gRPC cc client without any extra/unnecessary libraries. This works in my tests of r22.03 and r22.04. (Contrary to item 1 in https://github.com/triton-inference-server/server/issues/3141, I still use the CMakeLists.txt in src/c++ rather than the top-level one; it just seemed easier after a further look.)
Default behavior should not be impacted, so official builds should continue to work as usual.

superseded by #95


Nameservice Fullstack integration

Description
We have a nameservice.cairo to test, deployed to Sepolia soon.
We need a Nameservice like Starknet.id or .brother.
Create components and screens in the mobile. Indexer and endpoints need to be done. We can split the tasks in frontend and backend/indexer issues.
apps/mobile:

[ ] Create components and screens
[ ] Component to buy a name (verify the name, check amount)
[ ] List all name bought, with expiry time and owner

apps/indexer

[ ] Create the Indexer scripts

apps/backend

[ ] Create the backend endpoints for nameservice.cairo events

I’d like to work on this. I propose creating mobile components for name purchasing, indexer scripts for efficient data retrieval, and backend endpoints to handle nameservice.cairo events. This approach ensures seamless integration across all layers.
Draft pr in 24hrs
also a doubt  if the backend also handles validations for name availability or is managed solely on the frontend but guess ill figure it out.

For the front-end (Apps/Mobile)
Create name buying and management components and screens. A "Buy Name" flow to check availability and process payments.
For the back-end (Apps/Backend)
Implement the back-end endpoints needed to process nameservice.cairo events. Create an endpoint for name validation, purchase, and ownership queries.
Indexer (Apps/Indexer)
Create indexer scripts to track events on Sepolia and index the nameservice.cairo data efficiently.

Mind if I take this issue?

I have gone through the description, and I can resolve all task

I'm a senior fullstack dev, assign me some of your tasks and I'm committed to finishing them by the end of the next few weeks.

I’d like to work on this. I propose creating mobile components for name purchasing, indexer scripts for efficient data retrieval, and backend endpoints to handle nameservice.cairo events. This approach ensures seamless integration across all layers.
Draft pr in 24hrs
also a doubt if the backend also handles validations for name availability or is managed solely on the frontend but guess ill figure it out.

gm, can you ping me on TG please?

Hi, I’d like to work on this issue as I have experience in front-end development.
I can implement the required changes and ensure everything works seamlessly as described.
I estimate completing the work within 12-24 hours. Could you please assign this to me?

Application for Nameservice Feature Development
Hi,
I’d like to contribute to this project. I have experience in frontend and backend development, as well as working with blockchain-specific functionalities. Here's how I propose splitting the tasks:

Frontend (apps/mobile):

Create screens and components for buying and managing names.
Implement features like name verification, amount checking, and listing purchased names with expiry and ownership details.

Indexer (apps/indexer):

Write indexer scripts to process nameservice.cairo events efficiently.

Backend (apps/backend):

Build endpoints to support the frontend and indexer with real-time data.

I am comfortable working on either frontend or backend/indexer tasks based on project needs.
Thank you!

I’d like to resolve this issue kindly assign me.

Why I’m Interested: With experience in building mobile components and working with backend integrations, this issue aligns perfectly with my skills. It offers an opportunity to contribute to a decentralized identity system, enhancing the mobile app's functionality and ensuring a seamless experience for users. I'm excited to work on such a key feature for the platform and explore how decentralized services are integrated with mobile applications.
Proposed Approach:
Mobile App Development:
    Create Components & Screens:
        Build a user-friendly interface to allow users to buy and manage names.
        Add a component to verify the name availability, check the amount needed, and confirm the purchase.
        Implement a listing screen to display all names bought, showing details such as expiry time and ownership.
    UI/UX Considerations:
        Ensure smooth and intuitive navigation for purchasing and managing names.
        Handle edge cases like expired names, unavailable names, or failed transactions.

Backend Development:
    Create Endpoints for nameservice.cairo Events:
        Set up backend endpoints to listen to events from nameservice.cairo, handling claims, purchases, and name expiration.
        Ensure secure and accurate event processing and update the database with relevant name data.
    API Integration:
        Provide API endpoints to fetch names and associated details (e.g., expiry time, owner).

Indexer Development:
    Create Indexer Scripts:
        Develop indexer scripts to collect and store name-related data from the blockchain events triggered by nameservice.cairo.
        Ensure the indexer handles name claims, purchases, and expirations correctly, storing all relevant data in a structured format for efficient querying.

Testing and Validation:
    Ensure proper testing of:
        The mobile app’s functionality (name verification, buying, listing).
        Backend processing of events and storing/updating name-related data.
        Indexer scripts for data accuracy and efficiency.

Adhere to Guidelines:
    Follow the contributor’s guide for style, structure, and best practices to ensure consistency with the project.

Outcome: The mobile app will be fully equipped with a NameService feature, allowing users to purchase and manage names. The backend will process events from nameservice.cairo, and the indexer will efficiently store and query name-related data. This will provide users with a seamless and decentralized identity service integrated within the app.

Can I take care of this issue?
My ETA is 50 hours

May I take care of this?
Frontend (Mobile):
Create screens/components to buy a name (validate, check cost) and list claimed names (expiry, owner).
Indexer:
Scripts to process nameservice.cairo events.
Backend:
Endpoints for name ownership and expiry data.

I’d like to resolve this.

I'd like to take this issue.

Could I grab this task?


Simplify Producer and Consumer traits further

This PR combines a number of refactorings. The general goal is to increase safety and to lower the number of esoteric annotations (lifetime parameters, phantom types) as well as general...clumsiness of the parallel iterator internal traits.

Remove the Shared associated types from Producer and Consumer

instead, carry the shared pointers inside the implementations
this is possible because we are always obtaining instances of these types via callbacks now

Remove the lifetimes from Producer and Consumer

they were only ever needed to deal with Shared

Make Item an input type (not an associated type) of Consumer

this makes sense because items flow in to a consumer, so in a sense it is not the one that chooses the kinds of items it will be provided
of course, in some cases, consumers can only consume compatible kinds of items, but nobody says they have to have an impl that applies to all input types
this in turn allows removing a number of phantom types that only served to "remember" the type of input we were expecting; this is now specified on the trait reference Consumer<Item>

Refactor the producer to extend IntoIterator

when we start sequential execution, we convert to an iterator
this lets us leverage existing iterator implementations

Refactor the consumer to have more distinct phases

a consumer now has a clear protocol: either it gets split into two parallel consumes (whose results are then reduced), or else it gets converted into a folder and processes items sequentially
this protocol shift is needed to support removing shared as well
it also helps with making things safe

Make all traits safe

the unsafety is now concentrated in the collector. Having the more refined protocol helps us to remove some assertions from this path; it's now fairly minimal. I think we could actually remove some of the assertions we have by having the collector call bridge directly instead of calling drive (in fact, arguably, we don't need drive at all).

Some things that might be nice to do before landing:

[ ] Measurements of impact (which sort of needs good benchmarks)
[ ] Some negative tests of evil producers that fail to uphold their end of the bargain in various ways; we would want to be sure that the collect consumer doesn't fail under those cases.

[ ] fail to produce correct number of items
[ ] produce too many items
[ ] abuse consumer protocol by never calling complete
[ ] abuse consumer protocol by leaking calling
[ ] not sure what else

cc @cuviper @bjz -- these changes may interest you :)

OK, addressed the various nits and bugs, the only thing I haven't investigated yet is simplifying collect per @cuviper's suggestion. We could definitely use some more tests targeting splits. :)

OK, given my dearth of time, I've decided to defer the "negative tests" and make an issue for them. I'll try to do some benchmarking of what we have now -- even though the existing benchmarks don't really stress test much of the par iter infrastructure. But that's ok.

OK, I did measurements and found basically no performance difference (as expected).


Textupdate and linkfix in one

Updated the text that suggested that documentation is for Origo API and fixed the links ones again for the top left logo and "Back to top".

Issue #76


Use downgraded analyze for flutter/packages

Add the --downgrade flag to the flutter/packages analyze test, so that it won't get the latest version of dependencies, avoiding out-of-band failures in flutter/flutter due to package publishing events.
Fixes https://github.com/flutter/flutter/issues/129633
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

@devoncarew We should make this change to the Dart repo version of the test as well, to reduce random breakage.

Is using newest and oldest not possible, or not worth?

The purpose of this change is explicitly to avoid using the newest, because doing so exposes flutter/flutter to out-of-band breakage. All we care about when we are running these tests in the context of the flutter/flutter repo is catching cases where flutter/flutter changes would break flutter/packages, and the dependency versions are irrelevant for that.
In flutter/packages, we run this test both ways, because the goal of the testing there has a very different scope.

@devoncarew We should make this change to the Dart repo version of the test as well, to reduce random breakage.

👍 - makes sense. Probably good to track w/ an issue in the dart-lang/sdk repo? cc @srawlins

@devoncarew We should make this change to the Dart repo version of the test as well, to reduce random breakage.

👍 - makes sense. Probably good to track w/ an issue in the dart-lang/sdk repo? cc @srawlins

I tracked down my breadcrumbs to the script and posted https://github.com/dart-lang/sdk/pull/52989


@mzikherman - [WIP] Artwork filter pt. 2

This time I am building a component that will wrap all of them together.

This is still missing:

[ ] Component to listen to url params
[ ] Sort dropdown
[x] Headline component ("Small conceptual art under $100)")

Added headline component

Off-topic, but just wanna double-check with you that the artwork brick needs a better loading state (grey background and correct height laid out immediately).

Would it be possible to change the label of the selected price filter to remove ‘BETWEEN’ and just show the price range instead?

@alloy first point: yes! Second point: just replicating what we do on artsy.net currently. These filters are the least used across the site (only on the tag, gene and fair pages). I suppose it would be up to @briansw or @katarinabatina whether or not to change the way those filters behaved.

@alloy you're just saying change it from "Between $1,000 and $5,000" to "$1,000–5,000" right? Seems like a good call considering the range gets truncated so severely. If it's a big time investment, it's probably not worth the effort since these pages don't drive many inquiries.
$50–1,000
$1,000–5,000
$5,000–10,000
$10,000–50,000
$50,000+

@briansw Yep, that’s exactly what I meant, but, just to be clear, only for the selected state. In the dropdown I think it’s fine to prefix with ‘Between’. I hear you both on them being little, so let’s indeed skip it if it’s more than a few minutes of work.

I'd say let's make them match in the dropdown and selected state if we end up doing this.

Looking dope, @broskoski :bowtie: 👌

Here's how it's looking now:

In my rudimentary tests, I couldn't successfully capture changes to url params, but I suspect it's due to the React Storybook router. I think that part will need to be done outside of this context.

ok I'm merging, I think this looks stellar! 🎉

Looks great @broskoski! 👏


Allow applying changes to all presets

Right now, if I change something that I want to be reflected in all of my presets, I have to select the preset, make the change, save, and repeat.
Would be nice to apply changes to all.

Hi, the plugin is in the middle of a rework and the new version will include a new way for editing presets.

If you made changes to some plugin, presets will notify about the change in the edit view as "Modified" and you can update the configuration in the edited preset if wanted.
In your case, this edit button could have some sort of "apply to all presets" context menu option for situations when the change should apply presets.
I will look into this if its feasible and if so, it will come out once the rework is finnished. See plugin-rewrite branch.
Thanks for the suggestions!

In the upcoming version, presets are no more copies of all your configurations but more so only presets of the plugins that should change when enabling presets. So if you wanted to use same settings for a plugin in every preset, you simply take the plugins configurations off the presets so that it does not get changed. Examples of not saving plugin configurations to presets would be with music or ground items.
In addition to this you can now add and remove plugin configurations from all presets on one go by right clicking the switch.

Awesome, thanks for the update. Looking forward to it!


Update pubnub and clear logs

WIP
Closes #17 #18

The tests are unstable and new functionality (clear) is not covered yet, but the body of the code is OK to review

Ah OK seems the windows failure is now the same browser failure (it used to be something different in the node part).
The browser failure is essentially history getting 0 results when it's supposed to get 3.
Will try playing with delays as I don't have any better ideas.
AH, and of course I've tested this by hand in the real UI and it works fine.

Should I just disable the automated browser tests by excluding them from the default test script? They run locally and we also test it indirectly in the UI, but they fail consistently in the CI.

I don't think we should disable the tests - we'll forget about them pretty quickly if we do. We should get them fixed, but that doesn't have to block things. If we need this out in time to make the SDK 6.0 release, and we've tested this manually, then I think this is good to merge now, and we can come back and improve the tests later (and it'll be easier to remember to do that if they stay failing).


[WIP] fix: Handle empty state in the editor

I have successfully created a solution to handle the empty state in the editor. However, I have broken drag-n-drop once the editor is empty 😬
Hence, this PR is a draft
Fixes #59

@johno Closing this in favour of #122


chore(stylex,tests): bump stylex to 0.6.0 and fix tests

Following up from the release of stylex 0.6.0: https://github.com/facebook/stylex/commit/87e718e6f07359a5e7cfce59da6ea89f70917bed
This PR also takes care of fixing npm run test. It was originally failing because mime-types was not a direct dependencies, and then snapshots needed to be updated.
I also tested the examples, as far as I can tell it's working:

It throws an error in logs saying:
Warning: Failed prop type: Invalid prop `position` of value `static` supplied to `Text`, expected one of ["absolute","relative"].`

so probably it was something pre-existing.

Thanks


Use pastell tones instead of bright colors

Follow up to #13, #14, and https://github.com/ultimate-comparisons/ultimate-comparison-BASE/pull/48#issuecomment-304681949
The current auto coloring uses the same colors across tags.
Example (taken from https://ultimate-comparisons.github.io/ultimate-tex-makers-comparison/)

Why is geddit3 the same category as all?

red is a signal color and should be avoided - see e.g., discussion at http://munsell.com/color-blog/why-that-color-signal/ for coloring

[ ] I would propose to have automated coloring assigning a single color for each category. color1 for supported tools, color2 for detect changes in tex, etc.

[ ] For the colors itself, I opt for pastel tones. They are not as bright (and disturbing) as the current colors. See for example http://www.templatemonsterblog.de/pastellfarbendes-webdesign/ for a long discussion and some example colors.

More information about colors and web sites: https://www.w3.org/WAI/gettingstarted/tips/designing and Section 1.4.3 of https://www.w3.org/WAI/WCAG20/quickref/#qr-visual-audio-contrast-contrast1

solved in #82


Dependency Error on Installing @graphprotocol/graph-cli due to<EMAIL_ADDRESS>

Which packages are impacted by your issue?
@graphprotocol/graph-cli
Describe the issue
When attempting to install @graphprotocol/graph-cli, a dependency error occurs. This issue originates from the<EMAIL_ADDRESS>package.
The error stems from version 34.0.0 of the package, which attempts to install concat-stream from a forked version on the feat/smaller branch. Unfortunately, this branch was deleted a few hours ago (link to branch) (link to PR). Refer to the screenshot below for additional context:

Upon inspecting the node_modules of the cli package, it is evident that concat-stream is being installed from the forked version:
    "concat-stream": "github:hugomrdias/concat-stream#feat/smaller",

I believe upgrading the version for ipfs-http-client will fix this issue
Reproduction
Steps listed above
Steps to Reproduce the Bug or Issue
pnpm i @graphprotocol/graph-cli
Expected behavior
To install
Screenshots or Videos
Attached above
Platform

OS: macOS

Subgraph Manifest
No response
Subgraph GraphQL Schema
No response
Additional context
No response

following this..
in my pnpm monorepo, i did this override..
"pnpm": {
    "overrides": {
      "ipfs-http-client": "60.0.0"
    }
  },

install goes through, but now i need to test the subgraphs if all still works

following this..
in my pnpm monorepo, i did this override..
"pnpm": {
    "overrides": {
      "ipfs-http-client": "60.0.0"
    }
  },

install goes through, but now i need to test the subgraphs if all still works
edit: didn't work..
but this probably will:
 "pnpm": {
    "overrides": {
<EMAIL_ADDRESS>"github:mihirgupta0900/concat-stream#master"
    }
  }

Yes, that works for the time being 👍

should be patched in<EMAIL_ADDRESS>


Add python3 alias for python

I think it would be nice to add python3 alias for python.

but then what if someone writes a Python 2 code inside it? would it break? XD
Jokes aside, I understand the idea but I don't think would be really necessary, since is just a matter of getting used to just writing "py" or "python"

I have markdown documents with ```python3 blocks and it works in GitHub.

I think python is python... we don't have multiple versions of parsers/highlighters and don't desire to.  If you want another alias, it's trivial to add one for python3:
hl's.registerAliases("python3", {languageName: "python"})

https://highlightjs.readthedocs.io/en/latest/api.html#registeraliases


[BEAM-360] Adds a PTransform for Avro source and updates snippets.

Wrapping a custom source as a 'PTransform' is better than directly using the source using 'df.Read' since the 'PTransform' can be extended without breaking end-user code.
Updates the documentation of avroio module.
Adds 'PTransform' wrappers to custom sources and sinks in 'snippets.py'.

R: @silviulica

LGTM - had just a bunch of cosmetic changes.
Thanks Cham!

R: @robertwb

Thanks Dan.


Db contrib/develop

JS Client - ability to cancel invocation
Plexus Studio - various improvements

:x: Build plexus-interop 0.9.0-491 failed (commit https://github.com/finos-plexus/plexus-interop/commit/bcca17b4e5 by @udalmik)

:x: Build plexus-interop 0.9.0-492 failed (commit https://github.com/finos-plexus/plexus-interop/commit/c73fcc0b49 by @udalmik)

:x: Build plexus-interop 0.9.0-493 failed (commit https://github.com/finos-plexus/plexus-interop/commit/c73fcc0b49 by @udalmik)

:x: Build plexus-interop 0.9.0-494 failed (commit https://github.com/finos-plexus/plexus-interop/commit/c73fcc0b49 by @udalmik)

:x: Build plexus-interop 0.9.0-495 failed (commit https://github.com/finos-plexus/plexus-interop/commit/c73fcc0b49 by @udalmik)

:x: Build plexus-interop 0.9.0-500 failed (commit https://github.com/finos-plexus/plexus-interop/commit/2882a66a76 by @udalmik)

:white_check_mark: Build plexus-interop 0.9.0-501 completed (commit https://github.com/finos-plexus/plexus-interop/commit/561370245e by @udalmik)


Update google-cloud-storage to 1.117.1

Updates com.google.cloud:google-cloud-storage from 1.109.1 to 1.117.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.cloud", artifactId = "google-cloud-storage" } ]

labels: library-update, semver-minor

Superseded by #246.


Patch 3

2016-04-08 09:20:53 Thread-13 :: [98927da] Missing time zone for network: SRC
2016-04-08 09:20:53 Thread-13 :: [98927da] Missing time zone for network: Fuse

Thanks for the pull request! Before a real human comes by, please make sure your PR has all of the below criteria checked

[x] Give a description on what the PR is for.
[x] Make sure your PR is based on the DEVELOP branch
[x] Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review

Please make sure you also read contribution guide and followed all of the steps.
Thanks!


[KYUUBI #1575] Implement api: /${version}/operations/${operation_identifier}/resultsetmetadata

Why are the changes needed?
#1575
Implement api: /${version}/operations/${operation_identifier}/resultsetmetadata

/${version}/operations/${operation_identifier}/resultsetmetadata

mapping: ICLIService#getResultSetMetadata
desc: get the table schema of the result set via the given operation identifier
method: GET
params: none
returns: an instance of TableSchema

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

cc @yaooqinn @yanghua

Codecov Report

Merging #1576 (310ad98) into master (9dfbd2b) will decrease coverage by 19.72%.
The diff coverage is 75.72%.

:exclamation: Current head 310ad98 differs from pull request most recent head ea635da. Consider uploading reports for the commit ea635da to get more accurate results

@@              Coverage Diff              @@
##             master    #1576       +/-   ##
=============================================
- Coverage     78.80%   59.08%   -19.73%
- Complexity       80      248      +168
=============================================
  Files           175      260       +85
  Lines          6451    12965     +6514
  Branches        764     1622      +858
=============================================
+ Hits           5084     7660     +2576
- Misses          923     4663     +3740
- Partials        444      642      +198

Impacted Files
Coverage Δ

...g/apache/kyuubi/sql/KyuubiEnsureRequirements.scala
30.18% <0.00%> (ø)

...pache/kyuubi/sql/KyuubiSQLExtensionException.scala
100.00% <ø> (ø)

...ache/kyuubi/sql/RepartitionBeforeWritingBase.scala
0.00% <0.00%> (ø)

.../kyuubi/engine/flink/config/EngineEnvironment.java
66.66% <ø> (ø)

...yuubi/engine/flink/config/entries/ConfigEntry.java
40.00% <ø> (ø)

...bi/engine/flink/config/entries/ExecutionEntry.java
58.59% <ø> (ø)

...che/kyuubi/engine/flink/context/EngineContext.java
43.47% <ø> (ø)

.../kyuubi/engine/flink/context/ExecutionContext.java
81.57% <ø> (ø)

...he/kyuubi/engine/flink/context/SessionContext.java
61.90% <ø> (ø)

.../apache/kyuubi/engine/flink/result/ColumnInfo.java
38.88% <ø> (ø)

... and 229 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dfbd2b...ea635da. Read the comment docs.

thanks, merging to master


[BugFix] Disable local passthrough for global merger

There is a clear conflict between local paththrough optimization and global merger which requires the correct ordering of the data transmition.
On the one hand, SinkBuffer and PipelineSenderQueue together maintain a sliding window for the ordering of the data packets, which requires the first sent packet must be processed first.
On the other hand, the local passthrough may cause a silly syndrome where the first sent packet may potentially be processed later. which is clearly defined in the pr #20550
And to a conclusion, we must disable the local passthrough optimization when it comes to global merger.
How to reproduce this problem
SELECT SUM(wv) FROM (
    SELECT max(fn_int) OVER (ORDER BY fn_int ROWS BETWEEN 2 PRECEDING AND 2 PRECEDING) AS wv FROM t_large
) tmp

the table t_large has 100M rows. and this sql may be blocked forever at a relatively low ratio.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[x] 3.0
[x] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


Add blocking algorithm

Task/Issue URL: https://app.asana.com/0/72649045549333/1207151848931036/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5376  👈 (View in Graphite)
#5370
#5369
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.


Scrum Master's (Ethan) Plan - Endgame

At the moment, our progress is lacking in terms of my expectations. I have planned out some new changes that I think would help us complete our project in the time we have been given.

Email - iteration can be used in the database, make sure the email is a real registered email>iterate to see if there is only one of the email so no clutter


Update browser token auth login page help screenshot

Replace the temporary image with an up to date image that we're all happy with. Also review copy.
Left over work from https://github.com/dotnet/aspire/pull/3213

@leslierichardson95 if you have any particular thoughts on the screenshot.

@JamesNK for the token example screenshot, did you try it at different screen resolutions and/or scaling? I'm wondering what it looks like on screens with higher DPI/scaling ratios set as this is often requires multiple image files to ensure it doesn't look super pixelated at higher DPIs.

From @DamianEdwards

@tlmii I think we should keep the "[ProjectName] Dashboard" header text and the placeholder text based on the most recent screenshot in the #3213 issue.  Personally, I still prefer the login button inline with the input textbox but for consistency and majority rules' sake, I don't mind if the button is below it. :)

@tlmii I think we should keep the "[ProjectName] Dashboard" header text and the placeholder text based on the most recent screenshot in the #3213 issue.  Personally, I still prefer the login button inline with the input textbox but for consistency and majority rules' sake, I don't mind if the button is below it. :)

@leslierichardson95 this issue is just about getting a better, updated screenshot for the more information popup. See the screenshot here that includes the popup with the screenshot in question (very meta):
https://github.com/dotnet/aspire/pull/3213#issuecomment-2024345577
I know there are some tools to make nice console window/code screenshots that people post on social media. It should also probably be more generic than using my personal prompt.

Oh whoops my bad!  In that case, I'm still trying to remember a page or experience that has an example of a "more info / "where is my cvv"-style popup we could take inspiration from.  At the very least, maybe we should make the more info popup the same width as the login popup or maybe consider expanding the login page vertically with the additional screenshot info instead?
Also, I think we should rename "more info" to "Where is my login token?" which feels a bit more specific and so that we alleviate any potential confusion about "more info" being doc-related.  For the screenshot, we should highlight or put a box around the token location so that it's clear to the user.

@leslierichardson95 I had pointed you to an older screenshot so there were a few things out of date. Sorry about that. You'll see the updated ones here in a minute.

Here's a stab at a replacement screenshot. Bigger, too, and clickable to open in a new tab/window if they need that for some reason:

cc @leslierichardson95 @kvenkatrajan

LGTM

Consider adding some text before the More info:

Copy the highlighted token from the console to the login page and login.
Alternatively, click on the console link to automatically login. The address might not be correct when the dashboard is running in a container and the external port is mapped to a different value.

Also, could More info be changed to More information? I used the full word in some other places. Should be consistent.


[Naming] Clock Naming

hi,
just wanted to get some general opinions.
Right now we have 3 clocks defined
main, fixed and usb.
We need to add another slow clock as well as decide if fixed is a good name.
Some of our partners have started calling the fixed clock io clock, to imply that the clock should be static frequency in nature for io's.  Are people okay with that name?
Would anyone object to the creation of "slow" for a KHz level clock?

Hi @tjaychen ,
slow sounds good to me.
Regarding fixed/io: what about fast? This maybe depends a bit on the difference between main and fixed/io. If I remember correctly, both slow and fixed/io are actually fixed, whereas main is about equally fast as fixed/io but not fixed. ;-)

Thanks for bringing this up @tjaychen .
I am fine with creating a slow clock for the KHz level clock (we already started to use that name in some IPs, AFAIK).
re fixed versus io, I would say that fixed may be a bit misleading, as it sort of implies that all other clocks are not fixed. that is only true for the main clock. so switching over to io clock or something else is ok from my side.

My prev. experience uses that kind of slow clock as aon_clk. or aux_clk. slow is fine also but personally prefer aux_clk. :)

Hi @tjaychen ,
slow sounds good to me.
Regarding fixed/io: what about fast? This maybe depends a bit on the difference between main and fixed/io. If I remember correctly, both slow and fixed/io are actually fixed, whereas main is about equally fast as fixed/io but not fixed. ;-)

so i don't REALLY want to use fast mostly because the main clock is supposed to even faster... the main clock is supposed to be ~100MHz, while fast is really only around 24MHz.

o i like aon_clk.... that does very accurately reflect it's function :)
I think aux is pretty good too...
let me contemplate this a bit... for the same reason i don't really like fast, i also don't really like slow, (and @msf's point about fixed also makes sense)...
so i think I am leaning towards aon/aux or io.  Let me know if you guys would have a big problem with that combination.

+1 for aon and io

my preferences:
clk_aon for the ~100kHz always-on clock (although I see some trends to alw for the always-on stuff, I prefer aon)
clk_main is fine for jittery proc + crypto clock
clk_io or clk_timer or clk_fixed for the other clock, but how will we distinguish the different divided versions?
I kind of don't like the slow and fast connotations. aux for aon wfm, though "auxiliary to what?" will be the question, while aon is more correct, brief, and accurate.

I also generally like aon for the 100kHz clk and io for the fixed one - main is a reasonable name for the "core" clk (I've seen core used for this but it's so overloaded with meaning that it gets dangerous in a hurry).
slow/fast feel weird to me, would probably avoid.

thanks all, i think there is general consensus towards main / io / aon.
If there are no other objections, I will close this issue and make the same
proposal to our partners.
Once they approve, I will begin a clock re-naming exercise.
On Thu, Apr 23, 2020 at 11:26 AM Chris Gori<EMAIL_ADDRESS>wrote:

I also generally like aon for the 100kHz clk and io for the fixed one -
main is a reasonable name for the "core" clk (I've seen core used for
this but it's so overloaded with meaning that it gets dangerous in a hurry).
slow/fast feel weird to me, would probably avoid.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/2007#issuecomment-618571276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSQTTRTGFAW4NRCUNHTROCB4LANCNFSM4MMVVMUQ
.

If there are no other objections, I will close this issue and make the same proposal to our partners. Once they approve, I will begin a clock re-naming exercise.

@tjaychen which partners? This issue should hit all of the OT team.  Maybe this: everyone on the thread has until EOD Friday to weigh in if they're not happy with main / io / aon.

Pardon on that last comment, I wrote it Thursday PM, but network issues rejected it, just hit resend. We can give until EOD Monday perhaps.

sounds good, thanks Scott
On Fri, Apr 24, 2020 at 4:28 PM Scott Johnson<EMAIL_ADDRESS>wrote:

Pardon on that last comment, I wrote it Thursday PM, but network issues
rejected it, just hit resend. We can give until EOD Monday perhaps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/2007#issuecomment-619279247,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSQDC6FLVQTB6Z6YZHDROIOBDANCNFSM4MMVVMUQ
.

soo..i'm beginning to think clk_aon is not such a good idea. The aon term is becoming overloaded with the power domain.
For example, imagine we want to create a reset that is in the aon power domain, but also synced to clk_aon.. we are going to have a funny looking name if we assume the format is rst_{root_name}_{power_domain}_{clk_domain}_n
Maybe that's okay as long as we are consistent....

Hmm, good point. rst_aon_aon_aon_n? :)
maybe back to clk_aux?
On Thu, May 14, 2020 at 12:05 AM tjaychen<EMAIL_ADDRESS>wrote:

soo..i'm beginning to think clk_aon is not such a good idea. The aon term
is becoming overloaded with the power domain.
For example, imagine we want to create a reset that is in the aon power
domain, but also synced to clk_aon.. we are going to have a funny looking
name if we assume the format is
rst_{root_name}{power_domain}{clk_domain}_n
Maybe that's okay as long as we are consistent....
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/2007#issuecomment-628433662,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJZQKVNPZOQOUYAV2JQOF3TRROJ5NANCNFSM4MMVVMUQ
.

@sjgitty
sorry for not responding sooner. Yes i think once power domains are introduced, i'm going to move this back to clk_aux.
I'll close this issue down for now, thanks everyone for the input!


Sincpt function in SpiceyPy returning "SpiceyPy returns not found for function: sincpt"

Hey Andrew,
Love your SpiceyPy library by the way and I'm sorry to bother you on your GitHub account. I've been struggling with this error for a couple days and was hoping you might be able to shed some light on the issue. Here's what's happening:
I'm trying to implement the Surface Intercept method within your SpiceyPy library (SpiceyPy.sincpt) and keep getting the error "Spice returns not found for function: sincpt".
Now I know i'm using the correct amount and type of parameters in my method call and have also tried using the depracated srfxpt method (which returns the same error as sincpt). I've been using other methods within your library without error such as getfov, spkezr, utc2et, etc.. so I know that the library has been correctly imported. I've tried looking at the SpiceyPy methods for error checking just to make sure it was throwing the correct error and as I understand it (which is not well >.< ), it is and it's not just defaulting to a more generic error. You would know better than I, do you know what could be going wrong here?
Please let me know if you need anything from me in regards to this issue, as this is my first time posting an issue, I am liable to have forgotten something. Thanks Andrew and I hope to hear from you!

Sorry to say but I would just quadruple check the actual parameters you are passing to sincpt. The error indicates that spice does not find a surface intercept given the input as I think you have worked out. It would indicate to me an bad input or incomplete or wrong kernels because presumably you know there should be a surface intercept at that time and those other inputs.
I would recommend fiddling with the parameters like the time, look vectors and etc a bit. It might be worth going through the naif spice documentation to see a worked example of sincpt. Alternatively you could try contacting the naif with the specific kernels and code you are writing to work out what is going on.
-Andrew Annex

On May 24, 2018, at 7:42 PM, Justin Clark<EMAIL_ADDRESS>wrote:
Hey Andrew,
Love your SpiceyPy library by the way and I'm sorry to bother you on your GitHub account. I've been struggling with this error for a couple days and was hoping you might be able to shed some insight on the issue. Here's what's happening:
I'm trying to implement the Surface Intercept method within your SpiceyPy library (SpiceyPy.sincpt) and keep getting the error "Spice returns not found for function: sincpt".
Now I know i'm using the correct amount and type of parameters in my method call and have also tried using the depracated srfxpt method (which returns the same error as sincpt). I've been using other methods within your library without error such as getfov, spkezr, utc2et, etc.. so I know that the library has been correctly imported. I've tried looking at the SpiceyPy methods for error checking just to make sure it was throwing the correct error and as I understand it (which is not well >.< ), it is and it's not just defaulting to a more generic error. You would know better than I, do you know what could be going wrong here?
Please let me know if you need anything from me in regards to this issue, as this is my first time posting an issue, I am liable to have forgotten something. Thanks Andrew and I hope to hear from you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for the quick reply Andrew,
Just to double check, the error: "Spice returns not found for function: sincpt" is thrown when there is not a surface intercept returned at that specific et and doesn't just return false without throwing the error?

Yes, spiceypy does this to make spice more python idiomatic. I added a context manager for this behavior so you can disable it at runtime if you wish see the docs link for examples
http://spiceypy.readthedocs.io/en/master/basics.html
-Andrew Annex

On May 24, 2018, at 8:22 PM, Justin Clark<EMAIL_ADDRESS>wrote:
Thanks for the quick reply Andrew,
Just to double check, the error: "Spice returns not found for function: sincpt" is thrown when there is not a surface intercept returned at that specific et and doesn't just return false without throwing the error?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Ahh.. I was misinterpreting the error. I thought it was telling me that the method sincpt() was not found in the SpiceyPy library. That helps so much, thanks for being available Andrew!


Rarity/include message about missing attributes in output instead of throwing error

Problem
The problem occurs when I use calculateRarity function. Currently, when one of my JSON files doesn't contain attributes property, the package throws an error

We can even regard it as a bug because the metadata set without attributes is still valid.
Solution
Include a message about a failed attempt to calculate rarity in the output:
[
  {
      totalRarity: "1.00" // metadata with attributes
  },
  {
      totalRarity: 'Cannot calculate - no attributes' // metadata without attributes
  }
]

or
[
  {
      totalRarity: "1.00",
      validAttributes: true
  },
  {
      totalRarity: undefined
      validAttributes: false
  }
]

Those are only my suggestions. All reasonable solutions are fine.
Alternatives
No response

After consideration, I don't think we should skip files during the rarity calculation when it's missing attributes. If this happens, something is clearly wrong with the collection and I would make the final rarity calculation invalid. From a code perspective, it's better to throw an error, which you can catch, and not calculate rarity for such a use case.
Here's the PR adding the error: https://github.com/hashgraph/hedera-nft-utilities/pull/29

Closed by #29


feat: return disabled variation when prerequisite not met

TODO: config ci secrets:NUGET_API_KEY

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Use where clauses for readability

Feel free to close this if where clauses are not more readable for you.  :)

You're right, it is more readable, especially after a rustfmt pass. Trying to do everything without using a where clause is a bad habit of mine, one which I'll probably try to avoid in the future.


I cannot not obtain your data.

Sorry, I cannot obtain your data. There is an error.
ModuleNotFoundError: No module named 'referit.external._mask'

This is a duplicate of #22, please follow up your issue there


2DGS render depth is not aligned with the official implementation

Gsplat renders depth with splat's z while the official implementation does with ray-splat intersection point's z
The official implementation: https://github.com/hbb1/diff-surfel-rasterization/blob/main/cuda_rasterizer/forward.cu#L365

@jianhengLiu did this work help your results? If so, could you consider submitting a PR to the official project?

@jianhengLiu did this work help your results? If so, could you consider submitting a PR to the official project?

Sure! I will take some time to evaluate the modified version results and submit a PR.


changed project-ID in pom.xml

qq what is this for?

qq what is this for?

Im not sure exactly, but Yu said to change our Pom.xml Project Id to the new one he created. So I did that


Is this project dead?

Haven't seen a commit since 2013

ping @altercation

@TrevorBramble: a notice in the README would be very appreciated if the maintainer(s) aren't going to merge pull requests or fix bugs.

+1

I'm also interested, but there are 2,372 forks, and GitHub can't even display the list of them, so I guess there is no way to find out if anyone else is already carrying a fork forward.  Kind of a shame to see this great theme...well, not stagnate, because the theme itself is basically done.  But I think it would be very helpful to have an up-to-date central repo of Solarized resources.  There are people making PRs here, but no one to merge them, so where do enthusiastic users go to share their Solarized stuff, other than blogs scattered all over?
For fellow GitHub users, allow me to share https://github.com/alphapapa/solarized-everything-css which has Solarized user-stylesheets for GitHub.  Much easier on the eyes.  :)

Ya'll might want to head over to #371 and join the discussion there...