Feat/custom admin buttons

Description
Related to: #1324
Lays the groundwork for allowing different elements within the admin panel to be replaced with custom components. In this PR, the Save/SaveDraft/Publish/Preview buttons can all be replaced with custom react components.
Example config
// payload.config.ts

const Config = {
  admin: {
    components: {
      elements: {
        /**
         Custom "Save" button
           - drafts must be disabled
         */
        SaveButton: CustomSaveButton,
        /**
         Custom "Save Draft" button
           - drafts must be enabled
           - autosave must be disabled
         */
        SaveDraftButton: CustomSaveDraftButton,
        /**
         Custom "Publish" button
           - drafts must be enabled
         */
        PublishButton: CustomPublishButton,
        /**
         Custom "Preview" button
         */
        PreviewButton: CustomPreviewButton,
      },
    },
  }
}

Example component
Note that this component uses the DefaultButton from props just to show the abstraction. But it could render anything and use the props passed to create a custom button and omit the usage of DefaultButton.
import * as React from 'react';
import { CustomPublishButtonProps } from 'payload/types';

export const CustomPublishButton: CustomPublishButtonProps = ({ DefaultButton, disabled, label, publish }) => {
  return (
    <DefaultButton
      label={label}
      publish={publish}
      disabled={disabled}
    />
  );
};

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes
[x] I have made corresponding changes to the documentation

Omg merge on mobile doesn't let you edit the message when you click squash merge 💀

Would it be possible to extend this PR to include custom buttons that can be added next to the admin buttons? I would imagine that the schema would include a label, onClick functions, and custom components. This allows for additional actions such as opening modals, making requests or editing other documents.


How to test EventStream (in the context of DeadLetter testing)

I've been looking at how we can test that messages are sent to the DeadLetterProcess and subsequently published on the EventStream and the current design makes it difficult to test. Both DeadLetterProcess and EventStream have Instance static properties that are used to access them. The result of this is that you do not (by default) get isolation between tests (i.e. when Test1 and Test2 run in parallel and both use the static Instance of EventStream they will interfere with each other's assertions)
I can currently think of two options to deal with this:

Run any tests that use static Instances in a custom xunit test collection (https://xunit.github.io/docs/running-tests-in-parallel.html). This would make them run serially, so there would be no interference. Each test would be responsible for clearing up any state that is setup (i.e. remove subscriptions in the EventStream etc.)
Redesign - allow passing in of an EventStream in the Props, same way you can pass a Mailbox or Dispatcher. This would then be passed into the DeadLetterProcess ctor inside of the ProcessRegistry.Get method. We'd need a way to know about the EventStream - looks like it would need storing on the PID object.

No. 1 is basically an anti-pattern - shared state between tests etc.. - but it would be the easiest to implement. There are quite a few downsides to this approach though:

You have to remember to use the xunit test collection on all tests that might publish anything to the EventStream. This becomes a problem when you don't realize you're using the EventStream (i.e. it's called from within something else deeper down the chain) - the worse part is tests will pass in isolation, but sometimes fail when running all together.
You have to remember to clean up any left over state
Tests using the collection run serially, thus the overall test suite becomes slower

The advantage is that no src code has to change - there's no test induced design damage
No. 2 - i don't know the code base well enough to know the impact of such a redesign. It looks do-able - just pass some references down, but I think someone with more experience of the code base would have to ok this.
Thoughts? Might also be related to https://github.com/AsynkronIT/protoactor-dotnet/issues/90
Here's an example of testing using no1:
https://gist.github.com/tomliversidge/0bb0d84931e4de369925d7630bb17a96
and no2:
https://gist.github.com/tomliversidge/63082b3e8c6e2496c024feee3adac369

There is now the EventProbe that can be used exactly for this


Relation with The Pipeline Operator

As per the discussion from the Nov 2020 TC39 meeting: what would be the relation between this proposal and the pipeline operator proposal? Would they be mutually exclusive or would they coexist?
If they are going to be mutually exclusive, I'm concerned about the harm to the FP party of the JS community, considering:

the heavy reliance on this of this proposal,
also I'm unsure whether or not this can cover all use cases of pipeline operator gracefully.

Personally I think they can coexist, and if we have both, I would prefer F# style pipeline which can be seen as a specialization sugar/optimization for FP party. Smart style is much like a (unsuccessful) compromise between FP and OO.
The problem may be, not every TC39 delegates agree that. 🤷♂
About your two questions:

the heavy reliance on this of this proposal,

One of the important design goal of extensions is, ensure extension methods/accessors have the same developer experiences as close as real methods/properties. Essentially it's not this proposal heavily rely on this, but all the built-in methods and ton's of our ecosystem heavily rely on classes and methods which use this.
I don't think we can change that, and even I love FP, I don't think we can throw all the built-ins and all assets which based on classes and this, at least, not on the language level. (Frameworks/libraries can be designed for specific coding style or paradigm, but not a language which already have OO style in its soul.)
So if there are problems of this, what we should do is developing our tools, educations, and new language features to help developers conquer them, at least help to mitigate the issues. We should not reject a proposal just because it rely on this, a proposal which can help to solve this issue have to rely on this!

also I'm unsure whether or not this can cover all use cases of pipeline operator gracefully.

I'd like to explore that in next step, personally I believe it could cover all use cases but there will be differences in some aspects (ergonomics, performances, optimization prospect of engines, etc.) compare to different pipeline operator proposals.
I will create a separate doc for this topic and update this issue.

@hax thanks for the elaboration.

One of the important design goal of extensions is, ensure extension methods/accessors have the same developer experiences as close as real methods/properties.
...
I don't think we can change that...

Yeah, I totally see why extensions should be designed around this and I'm not here for changing it. My point is if extensions proposal is considered as a replacement of pipeline operator proposal, then this (no pun intended) might not be valued by FP party of JS community.

I'd like to explore that in next step

Great and see that's see how that goes ;)

I'm actually not so sure that these two proposals will co-exist very well.
What's the benefit of doing array::removeNullish() instead of removeNullish(array)? Well, I suspect it's the same reason why people sometimes prefer doing array |> removeNullish - it removes nesting and linearizes their code.
// Before
removeNullish(array.flat())
  .map(x => x + 1)

// After
array
  .flat()
  ::removeNullish()
  .map(x => x + 1)

The thing is, the pipeline operator gives us the capability of doing this already.
array
  |> ^.flat()
  |> removeNullish(^)
  |> ^.map(x => x + 1)

Sure, we had to refactor it a bit, but we could certainly have tooling help to automatically refactor fluent APIs into pipelines. Besides, it's more important that the code be easy-to-read than easy-to-write.
I also wouldn't be surprised if the pipeline operator will cause the number of fluent APIs out there to die down, as the pipeline operator removes a lot of the need for them. (e.g. if the array stdlib were rewritten today, it could very well look like this instead)
array
  |> Array.flat(^)
  |> removeNullish(^)
  |> Array.map(^, x => x + 1)

Fluent APIs and pipelines both solve the same problem, but in slightly different ways. I think it would be better if, as language designers, we specifically try to encourage just one style, not both. (Sure, people can use both styles if wanted, but the syntax should focus on just one)

@theScottyJam because a lot of prototype methods already exist in the language, like Array.prototype.map, for example - and when someone wants to author code that doesn't break if someone runs delete Array.prototype.map, they'd need to const { map } = Array.prototype;, and then they could arr::map(), robustly.

hmm, if I understand the current iteration of this proposal, it's not that user-friendly for that use case. I believe you have to do this? Because the extension methods go in a separate namespace?
const { map: ::map, filter: ::filter } = Array.prototype // <-- Three colons next to each other looks pretty weird

[1, 2]
  ::map(x => x + 1)
  ::filter(x => x > 0)

A syntax shorthand for function.call() would do a better job then the current proposal. (Which might not be a bad idea - perhaps I might open another thread to discuss it more, if there's not any blatent flaws in it). Let's say Array.prototype.map.call([2, 3], x => x + 1) is the same as Array.prototype.map@([2, 3], x => x + 1), then we could do this instead:
const { map, filter } = Array.prototype

[1, 2]
  |> map@(^, x => x + 1)
  |> filter@(^, x => x > 0)

// or...

const $Array = { ...Array.prototype }

[1, 2]
  |> $Array.map@(^, x => x + 1)
  |> $Array.filter@(^, x => x > 0)

I guess ::map(x => x + 1) is a little more concise at the usage sight than |> map@(^, x => x + 1), but honestly, I would be ok using the latter version. I'm already used to having all of my functions be static and piped that way from my experience in functional languages. But, I could understand if others don't like the extra verbosity.

the separate namespace is a nonstarter, so i wouldn’t think too hard about it.

I just found @js-choi's bind proposal repo - from what I understand, there's plans to present that one soon. I do like that proposal repo a little better - it seems much simpler.
Umm... but it doesn't look like it provides a namespacing option either - perhaps that's a nonstarter either until that gets updated?

I just found @js-choi's bind proposal repo - from what I understand, there's plans to present that one soon. I do like that proposal repo a little better - it seems much simpler.

I’ve been talking about it with @hax, although I haven’t been able to talk with him recently about it. My hope is to collaborate and present a united proposal together, next meeting.

Ahh, the fact this proposal "has a separate namespace" is a nonstarter, not that the function.call syntax not having a separate namespace is a nonstarted - got it :)
I was almost about to open another thread asking for clarification as to why a namespace was so important 😄


TestGetApps and TestGetAppsEmpty fail if there are sites configured not by the tests

What happened (or feature request):
I ran make testpkg but there was an existing unrelated site in ddev. It caused the tests to fail with
=== RUN   TestGetApps
--- FAIL: TestGetApps (0.03s)
        Error Trace:    local_test.go:148
	Error:		Not equal: 4 (expected)
			        != 3 (actual)

TestGetAppsEmpty has the same problem:
--- FAIL: TestGetAppsEmpty (0.02s)
        Error Trace:    local_test.go:320
	Error:		Not equal: 1 (expected)
			        != 0 (actual)

FAIL
FAIL	github.com/drud/ddev/pkg/plugins/platform	522.081s

What you expected to happen:
Tests should not be broken by non-test state, if possible
How to reproduce it (as minimally and precisely as possible):

Start a ddev site (or have it stopped)
Run make testpkg

Anything else do we need to know:
Related source links or issues:

@rfay I see a merged pull request referencing this. Does this solve/fix the issue?

Yeah, #279 isn't a full approach but it's good enough for now. Closing.


feat: Create event pagination page

The /events api needs to be paginated.

@dricazenck -
can you confirm if this structure for the paginated response looks correct ? + do you want me to replace the "events" field with "items" to be generic ?
{
"metadata": {
"totalItems": null,
"totalPages": 3,
"currentPage": 1,
"pageSize": null
},
"data": {
"hero": {
"title": "Online and In-Person Events",
"description": "Join the Women Coding Community for events and meetups that enhance your skills, deepen your knowledge, and expand your professional network.\n\nOur events include webinars, hands-on workshops, study groups, panel discussions, and keynotes with industry experts. Whether online or in-person, these gatherings offer valuable opportunities to share insights, learn collaboratively, and stay updated on the latest trends. Connect, grow, and thrive with fellow members in a supportive environment.",
"image": {
"path": "https://cloudprovider.com/image.png",
"alt": "There is a group of women showing WCC logo",
"type": "DESKTOP"
}
},
"contact": {
"title": "Contact us",
"links": [
{
"type": "EMAIL",
"link"<EMAIL_ADDRESS>},
{
"type": "SLACK",
"link": "https://join.slack.com/t/womencodingcommunity/shared_invite/zt-2hpjwpx7l-rgceYBIWp6pCiwc0hVsX8A"
}
]
},
"events": [
{
"topics": "Book Club",
"eventType": "IN_PERSON",
"startDate": "THU, MAY 30, 2024, 8:00 PM CEST",
"endDate": "THU, MAY 30, 2024, 9.30 CEST",
"title": "Book Club: The Pragmatic Programmer",
"speakerProfile": {
"label": "John Doe",
"uri": "https://meetup.com/event1"
},
"hostProfile": {
"label": "John M",
"uri": "https://meetup.com/event1"
},
"description": "Join us for a discussion of this essential guide to writing clear and maintainable code!",
"images": [
{
"path": "https://cloudprovider.com/image.png",
"alt": "Pragmatic programmer book cover",
"type": "DESKTOP"
}
],
"eventLink": {
"label": "Go to Meetup Event",
"uri": "https://meetup.com/event1"
},
"eventResources": [
{
"link": {
"label": "Slides",
"uri": "https://googledrive/event1"
}
},
{
"link": {
"label": "Recording",
"uri": "https://meetup.com/event1"
}
}
]
}
]
}
}

@goelsonali yes that is correct, and we should be using more generic items instead of events.


Check what's causing this and how to reproduce.

https://pypi.org/project/pytest-timeout/


Problem with OpenEXR

cjxl.exe image_21447_24bit.exr image_21447_24bit_exr.jxl -v -m 1 -q 100 -e 5 -C 1 --num_threads=4
JPEG XL encoder v0.7.0 0.7.0-59f7d19 [Unknown]
cjxl_main.cc:676: JXL_FAILURE: Codecs failed to decode input.

Currently OpenEXR is not supported, but we are planning on bringing this back.


cache error fallback

If the call to the cache store fails.  Should it fall back to the wrapped function?

In caching.js this is controlled by passing an ignoreCacheErrors option: https://github.com/BryanDonovan/node-cache-manager/blob/master/lib/caching.js#L30
...but I just noticed that same option doesn't exist in multi_caching.js.

I'll add this to multi_caching.js when I get some time (soon hopefully).  Do you need it in multi_caching.js now, or are you just using regular caching.js?

That worked perfectly.  Right now I'm only using caching.js.  Thank you such a quick reply.

Does not fall back if redis is unavailable.

ignoreCacheErrors not work with both of redis stores

@mogadanez - do you mean when redis is unavailable?

exactly, just provide  unexisting url  for redis.

BTW, seems I found solution.
enable_offline_queue: false  for internal redis library
from redis doc:

enable_offline_queue | true | By default, if there is no active connection to the Redis server, commands are added to a queue and are executed once the connection has been established. Setting enable_offline_queue to false will disable this feature and the callback will be executed immediately with an error, or an error will be emitted if no callback is specified.

Not sure if enable_offline_queue will work.  It doesn't seem to prevent errors for me.  Are you using async/await?  If so, you can probably wrap your calls in a try/catch block.  The issue here is that the ignoreCacheErrors only ignores errors returned via callbacks and doesn't deal with thrown errors.  It would be difficult to wrap the internal caching.js calls with try/catch.  But if you're using async/await, it shouldn't be too hard to do the try/catch in your code.

when enable_offline_queue:false
if goes inside if  here:
https://github.com/NodeRedis/node-redis/blob/4f85030e42da2eed6a178e54994330af5062761e/index.js#L769
if  enable_offline_queue:true
https://github.com/NodeRedis/node-redis/blob/4f85030e42da2eed6a178e54994330af5062761e/index.js#L791 ( else case)
 self.offline_queue.push(command_obj);

and offline_queue will not proceed until ready status, so without this option, it never calls callback from cache manager, and completely not working( hangs )
RedisClient.prototype.on_ready = function () {
.....
    this.send_offline_queue();
    this.emit('ready');
}

my code now:
var redisStore = require('cache-manager-redis-store');

 let cacheImpl = cacheManager.caching({
        store: redisStore,
        host:"example.com", // default value
        enable_offline_queue:false,
        ignoreCacheErrors:true,
        db: 0,
        ttl: 6000,
        prefix: process.env.DATABASE_NAME
    });
....

  static async wrapQuery( key, query, params )
    {
        let res  = await cacheImpl.wrap(key, async ()=> {
            let [rows] = await  db.query(query, params);
            return rows
        });
       console.log( res )
        return res
    }

this works fine

Awesome, glad you figured out a workaround.

Thank you @mogadanez for sharing your solution. Unfortunately, we are using multicaching and the option ignoreCacheErrors doesn't seem supported. @BryanDonovan Is there any plan to implement ignoreCacheErrors in multicaching too?
Thank you for this package.

您好， 您的邮件已收到，我会尽快回复，谢谢。


Local Interpolation

The purpose of this PR is to refactor interpolation to make it both easier and to introduce functionality that allows one to use the interpolation code in multiple ways:

The PointSet has been completely removed in favor of the in-kernel SplineData.
The interface for p2g and g2p is now simpler - just pass a Kokkos::View or Cabana::Slice or other object with operator() that contains the point coordinates and tell it how many points there are. @sfogerty this should make your life easier.
This significantly reduces memory footprint - no need to allocate data and carry it around for all those particles anymore or worry about that reserve issue for memory
For the some users (e.g. @rfbird) you can now not only create SplineData in a kernel and do kernel-fused p2g and g2p with a convenient helper object, it is now very clean to do so with multiple variants. For example, cell and node interpolation can happen at the same time in the same kernel with different orders of spline functions (e.g. quadratic and cubic) by making a SplineData<double,2,Node> and SplineData<double,3,Cell> and writing loops over their constituent entities.

So basically we get fewer objects, a unified implementation, more generality, and a reduction in memory usage. I'd still like to see if we can come up with a nice in-kernel abstraction for loops over local particle stencils but that will be future work.

@rfbird @sfogerty @streeve @kwitaechong any input?


Why is this url 404? http://alistapart.com/author/markhuot

He's on the author list, so he's in the system.

Maybe or maybe not relevant: His is the first member account, and has the lowest ID number.
I changed him from Member to Author, I put in his first and last names and added a bio, but that didn't make a difference.

It is because there were two records in the DB with the username markhuot (username should be a unique value). Probably one of the two got ported in from some migration. I changed the username for the second record to markhuot1 and it worked. We should merge them and delete one of the two.

Nice one.


Penalty for violating balance constraints

Penalty was high, now set to 1000

currently I use 3000 (max. price in European electricity market design)

change to 4000


Dark mode for Analog Clock

Hey there, I have created a dark mode toggle for the analog clock. Check it OUT.

@Astrodevil
Should I close this issue? Or ask author of issue to work on this.

I have added the dark mode feature. Could you please review it?


deprecate 3.7 - add 3.10

If all tests pass, I suggest we add support for 3.10 and we deprecate 3.7.
That way we can use the new features introduced in python 3.8 (such as the walrus operator :=)

Merging!


Add debug information for "key not found: downloadurl" @gdrive

Related: https://github.com/CartoDB/cartodb/issues/6854
We need some extra debug information for the issue reported in #6854. We know that gdrive file listing is failing because the item that we are parsing does not have a downloadUrl neither an exportLink (for gdrive files).
We're using a pretty old Ruby library for the Google Drive client which perhaps has something to do with the exception that we were facing, but we would need to know which are the details of the elements that make the list crash.
This PR basically adds a notfiy_debug for "malformed" items and ignores them when listing to workaround the issue.

After some issues when testing in staging produced by using compact!, which was getting rid of the whole list, the new code seems to be working as expected (it doesn't break listing).

retest this please

retest this please

cc @jgoizueta

:+1:


Clarify documentation for mmm endpoints

Clarify the documentation of the mmm/temperature endpoint specifically, but maybe the other mmm endpoints as well.
Specifically, be more clear about this phrase:

temperature values summarized across all models and scenarios

What models?
What scenarios?
How were min/max calculated? Min/max of annual averages, not individual days, right?

I'm going to chime in on this issue and say that I am not fond of having mmm as a top-level route. I'd rather have it be some_variable and/or some_variable/all gets you whatever is on Rasdaman, and then some_variable/mmm gets you the summary via WCPS or some other summarizing mechanism.

Since we're removing the mmm endpoint we can close this ticket.


Add 3.3 V power up to 5 V to power arduino

https://cdn-shop.adafruit.com/datasheets/BST-BMP280-DS001-11.pdf
5Volts can destroy sensor


fix: typescript schema import appearing with '.' instead of './'

Fixes the bug mentioned in #145.

I closed the previous PR #151 because it was using my master branch as source and I wanted to modify it.
So I created another branch.

New PR is #293


Runtime: Core BPF Migration: Use buffer accounts for source ELFs

Problem
As discussed in #590, using buffer accounts rather than deployed programs can
help protect Core BPF migrations from unexpected issues that could occur before
feature activation, such as invocation of the source program.
Using buffer accounts would preserve much of the same functionality while
reducing some complexity (such as condensing to one account).
Summary of Changes
Replace upgradeable BPF programs as the source for the builtin's BPF ELF with
buffer accounts.
This change is done in modular commits to make review easier.

Introduce a new module, inspired by source_upgradeable_bpf, for buffer
account sources.
Lightly refactor some helpers.
Make some light naming revisions.
Swap upgradeable program for buffer account in the migration module.
Drop the original source_upgradeable_bpf module.

Codecov Report
Attention: Patch coverage is 91.77215% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 81.8%. Comparing base (9ba0d6f) to head (8a5108e).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #831     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%
=========================================
  Files         851      851
  Lines      231556   231478     -78
=========================================
- Hits       189449   189364     -85
- Misses      42107    42114      +7


Ocelot on IIS

hello everybody,
i have 2 apps, each app in different directory in IIS , when call any api return 404 and apps as the following :

first app called "OcelotGateway" in directory "localhost/XYZ/OcelotGateway"

second app calld "Authentication" in directory "localhost/XYZ/Authentication"

how to write configuration of Reroutes to handle something like this
my ocelot.json file is
{
 "ReRoutes": [
    {
      "DownstreamPathTemplate": "/api/{everything}",
      "DownstreamScheme": "http",
      "DownstreamHostAndPorts": [
        {
          "Host": "localhost/XYZ/OcelotGateway",
          "port": 58748

        }
      ],
      "UpstreamPathTemplate": "/api/auth/{everything}",
      "UpstreamHttpMethod": [
        "POST"
      ]
    },
],
 "GlobalConfiguration": {
    "BaseUrl": "http://localhost:5000/xyz/OcelotGateway"
  }
}

thanks in advanced

@mohamed-mohamed2563 Okay, so the DownstreamPathTemplate, DownstreamScheme and DownstreamHostAndPorts refer to what will essentially be behind your API gateway, while the UpstreamPathTemplate and UpstreamHttpMethod properties refer to what the client will be calling on your API gateway.
So assuming that http://localhost:5000/XYZ/OcelotGateway is the base URI of your API gateway and you want to put http://localhost:58748/XYZ/Authentication behind that gateway and expose that through /api/auth/{everything} you'll want to have the following configuration:
{
 "ReRoutes": [
    {
      "UpstreamPathTemplate": "/api/auth/{everything}",
      "UpstreamHttpMethod": [
        "POST"
      ],
      "DownstreamPathTemplate": "/XYZ/Authentication/{everything}",
      "DownstreamScheme": "http",
      "DownstreamHostAndPorts": [
        {
          "Host": "localhost",
          "Port": 58748
        }
      ]
    },
],
 "GlobalConfiguration": {
    "BaseUrl": "http://localhost:5000/xyz/OcelotGateway"
  }
}

Does that answer your question?

Hi @jmezach,
I have a similar approach / issue on my staging server, using IIS.
This is my ocelot.json file:
{
"ReRoutes": [
{
"DownstreamPathTemplate": "/commonFolder/api1/api/products/{everything}",
"DownstreamScheme": "http",
"DownstreamHostAndPorts": [
{
"Host": "localhost",
"Port": 80
}
],
"UpstreamPathTemplate": "/api1/{everything}",
"UpstreamHttpMethod": [ "Post" ],
}

],
"GlobalConfiguration": {
"BaseUrl": "https://mydomain.com/commonFolder/gateway"
}
}
When I use Postman with the following url https://mydomain.com/commonFolder/gateway/api1/post I get nothing more then a  HTTP Error 500.37 - ANCM Failed to Start Within Startup Time Limit.
My solution is build using .net core 3.1 and Ocelot 14.0.11. Btw, running on my machine using IISExpress, everything works fine.
Any help will be very appreciated.
Regards,
C

The ANCM Failed To Start Within Startup Time Limit error suggests that something is going wrong during startup of your API gateway application. You could try enabling logging through the Web.config as documented [here[(https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/aspnet-core-module?view=aspnetcore-3.1#log-creation-and-redirection) to figure out what's going wrong.

This is what I get on log:
[aspnetcorev2.dll] Initializing logs for 'C:\Program Files\IIS\Asp.Net Core Module\V2\aspnetcorev2.dll'. Process Id: 7864.. File Version: 13.1.20018.2. Description: IIS ASP.NET Core Module V2. Commit: c3acdcac86dad91c3d3fbc3b93ecc6b7ba494bdc.
[aspnetcorev2.dll] Resolving hostfxr parameters for application: '.\APIGateway.exe' arguments: '' path: 'C:\mydomain.com\commonFolder\Gateway'
[aspnetcorev2.dll] Known dotnet.exe location: ''
[aspnetcorev2.dll] Process path '.\APIGateway.exe' is not dotnet, treating application as standalone or portable with bootstrapper
[aspnetcorev2.dll] Checking application.dll at 'C:\mydomain.com\commonFolder\Gateway.\expressoft.Connect.APIGateway.dll'
[aspnetcorev2.dll] Checking hostfxr.dll at 'C:\mydomain.com\commonFolder\Gateway.\hostfxr.dll'
[aspnetcorev2.dll] hostfxr.dll found app local at 'C:\mydomain.com\commonFolder\Gateway.\hostfxr.dll', treating application as portable with launcher
[aspnetcorev2.dll] Resolving absolute path to dotnet.exe from 'dotnet'
[aspnetcorev2.dll] Invoking where.exe to find dotnet.exe
[aspnetcorev2.dll] where.exe invocation returned: 'C:\Program Files\dotnet\dotnet.exe
C:\Program Files (x86)\dotnet\dotnet.exe
'
[aspnetcorev2.dll] Current process bitness type detected as isX64=1
[aspnetcorev2.dll] Processing entry 'C:\Program Files\dotnet\dotnet.exe'
[aspnetcorev2.dll] Binary type 6
[aspnetcorev2.dll] Found dotnet.exe via where.exe invocation at 'C:\Program Files\dotnet\dotnet.exe'
[aspnetcorev2.dll] Resolving absolute path to hostfxr.dll from 'C:\Program Files\dotnet\dotnet.exe'
[aspnetcorev2.dll] hostfxr.dll located at 'C:\Program Files\dotnet\host\fxr\3.1.2\hostfxr.dll'
[aspnetcorev2.dll] Parsed hostfxr options: dotnet location: 'C:\Program Files\dotnet\dotnet.exe' hostfxr path: 'C:\Program Files\dotnet\host\fxr\3.1.2\hostfxr.dll' arguments:
[aspnetcorev2.dll] Argument[0] = 'C:\Program Files\dotnet\dotnet.exe'
[aspnetcorev2.dll] Argument[1] = 'C:\mydomain.com\commonFolder\Gateway.\expressoft.Connect.APIGateway.dll'
[aspnetcorev2.dll] Loading hostfxr from location C:\Program Files\dotnet\host\fxr\3.1.2\hostfxr.dll
[aspnetcorev2.dll] Canceling standard stream pipe reader
[aspnetcorev2.dll] Loading request handler:  'C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App\3.1.2\aspnetcorev2_inprocess.dll'
[aspnetcorev2.dll] Creating handler application
[aspnetcorev2_inprocess.dll] Initializing logs for 'C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App\3.1.2\aspnetcorev2_inprocess.dll'. Process Id: 7864.. File Version: 13.1.20018.2. Description: IIS ASP.NET Core Module V2 Request Handler. Commit: c3acdcac86dad91c3d3fbc3b93ecc6b7ba494bdc.
[aspnetcorev2_inprocess.dll] Waiting for initialization
[aspnetcorev2_inprocess.dll] Starting in-process worker thread
[aspnetcorev2_inprocess.dll] Resolving hostfxr parameters for application: '.\APIGateway.exe' arguments: '' path: 'C:\mydomain.com\commonFolder\Gateway'
[aspnetcorev2_inprocess.dll] Known dotnet.exe location: 'C:\Program Files\dotnet\dotnet.exe'
[aspnetcorev2_inprocess.dll] Process path '.\APIGateway.exe' is not dotnet, treating application as standalone or portable with bootstrapper
[aspnetcorev2_inprocess.dll] Checking application.dll at 'C:\mydomain.com\commonFolder\Gateway.\expressoft.Connect.APIGateway.dll'
[aspnetcorev2_inprocess.dll] Checking hostfxr.dll at 'C:\mydomain.com\commonFolder\Gateway.\hostfxr.dll'
[aspnetcorev2_inprocess.dll] hostfxr.dll found app local at 'C:\mydomain.com\commonFolder\Gateway.\hostfxr.dll', treating application as portable with launcher
[aspnetcorev2_inprocess.dll] Resolving absolute path to hostfxr.dll from 'C:\Program Files\dotnet\dotnet.exe'
[aspnetcorev2_inprocess.dll] hostfxr.dll located at 'C:\Program Files\dotnet\host\fxr\3.1.2\hostfxr.dll'
[aspnetcorev2_inprocess.dll] Parsed hostfxr options: dotnet location: 'C:\Program Files\dotnet\dotnet.exe' hostfxr path: 'C:\Program Files\dotnet\host\fxr\3.1.2\hostfxr.dll' arguments:
[aspnetcorev2_inprocess.dll] Argument[0] = 'C:\Program Files\dotnet\dotnet.exe'
[aspnetcorev2_inprocess.dll] Argument[1] = 'C:\mydomain.com\commonFolder\Gateway.\expressoft.Connect.APIGateway.dll'
[aspnetcorev2_inprocess.dll] Setting environment variable ASPNETCORE_IIS_HTTPAUTH=anonymous;
[aspnetcorev2_inprocess.dll] Setting environment variable ASPNETCORE_IIS_PHYSICAL_PATH=C:\mydomain.com\commonFolder\Gateway
[aspnetcorev2_inprocess.dll] Loading hostfxr from location C:\Program Files\dotnet\host\fxr\3.1.2\hostfxr.dll
[aspnetcorev2_inprocess.dll] Initial Dll directory: '', current directory: 'c:\windows\system32\inetsrv'
[aspnetcorev2_inprocess.dll] Setting dll directory to c:\windows\system32\inetsrv
[aspnetcorev2_inprocess.dll] Setting current directory to C:\mydomain.com\commonFolder\Gateway
[aspnetcorev2_inprocess.dll] Stopping CLR
[aspnetcorev2_inprocess.dll] Starting shutdown sequence 0
[aspnetcorev2_inprocess.dll] Clr thread wait ended: clrThreadExited: 0
[aspnetcorev2_inprocess.dll] Canceling standard stream pipe reader
[aspnetcorev2_inprocess.dll] Stopping in-process worker thread
[aspnetcorev2_inprocess.dll] Event Log: 'Application '/LM/W3SVC/2/ROOT/expressoft.connect/Gateway' with physical root 'C:\mydomain.com\commonFolder\Gateway' failed to load coreclr. Exception message:
Managed server didn't initialize after 120000 ms.'
End Event Log Message.
[aspnetcorev2_inprocess.dll] InvalidOperationException 'Managed server didn't initialize after 120000 ms.' caught at F:\workspace_work\1\s\src\Servers\IIS\AspNetCoreModuleV2\InProcessRequestHandler\inprocessapplication.cpp:420
[aspnetcorev2_inprocess.dll] Failed HRESULT returned: 0x8007023e at F:\workspace_work\1\s\src\Servers\IIS\AspNetCoreModuleV2\InProcessRequestHandler\dllmain.cpp:131
[aspnetcorev2_inprocess.dll] Starting app_offline monitoring in application 'C:\mydomain.com\commonFolder\Gateway'
[aspnetcorev2_inprocess.dll] Starting file watcher thread
Tks,
C

Hi again,
I found a solution based on "failed dto load creclr" exception and now everything works fine if I switch from inprocess to outOfProcess hostingModel.
Thank you very much for your time @jmezach!
Regards,
C

Cool! No problem. Glad I could help you out. I'll go ahead and close this issue.


dndDragging not working?

Using the demo here
http://marceljuenemann.github.io/angular-drag-and-drop-lists/demo/#/advanced
The group of items dragging seems to use the ghost image in chrome and firefox and seems to ignore the CSS all-together.  The inner items work but I think they appear to work because they are smaller not because they are actually working.
Is there a way to adjust the ghost image/style used during the drag?

I would also like to know how to adjust this.

I don't think I quite understand the issue at hand... Maybe a screen cap would help?
You can adjust the ghost image in dragstart using event.dataTransfer.setDragImage, but it can not be modified during the drag.

Hello, first of all, great library! In the multiselection-demo, [(http://marceljuenemann.github.io/angular-drag-and-drop-lists/demo/#/multi)], the preview image(event.dataTransfer.setDragImage) is only set after the first drag. This occurs in my chrome 56.x version. I could not find the bug mentioned in other issues.

i did not add the img to the dom, before the drag-action. This is why the dragimage only shows the second time, this should also be adjusted in the demo.

Hello, marceljuenemann
I also faced this problem.
First time ghost image doesn't show, but from second it is working well.
Please help to solve first time not show problem.
Thanks :)


Array data dependence analysis

Provides a array dependency analysis as* described by "Compilers: Principles, Techniques, and Tools".
Requires functionality of #179 and #178.
Implemented features:

has_data_dependencyin analyse_array_data_dependency_detection.py allowing to determine if two array accesses in different loops exhibit a data dependency
a notebook 06_array_data_dependency_detection.ipynb showing a full integration (from source code, manual selecting of arrays, to determining if there exists a dependency)
a test test_analyse_array_data_dependency_detection.py testing 8 different test cases mostly taken from the Dragon book

Current Problems/Things I need help with: --> Expecting failure of tests due to missing ortools

[ ] How do I integrate the requirement of ortools for the solving of the integer linear problem into loki?
[ ] I have written an additional latex document, for exact formulation of linear algebra equations, since the Dragon is lacking them for this chapter, I will append it, how should it be preserved? array_data_dependency_description.pdf

Asterisk:
The following parts of the Dragon book are implemented:

"11.6.1 Definition of Data Dependence of Array Accesses", i.e. the full linear algebra description of the problem (iteration space, array access function)
"11.6.3 The GCD Test", i.e. a Gaussian Elimination algorithm specialized for Diophantine equations (i.e. pure integer matrix vector equation) and therefore the substitution of the result into the inequalities as described by equation (5) of the array_data_dependency_description mentioned above.
Independent-Variables Test from "11.6.4 Heuristics for Solving Integer Linear Program"
The Acyclic Test, Loop-Residue-Test, Memoization and the full Branch and bound solution to integer linear programming problems were not implemented, to ensure full usability a general integer linear program solver provided by ortools is used, therfore full usability is ensured, to the best of my abilities.

Again, just a quick response to your immediate questions:
To integrate ortools, I suggest to add them to pyproject.toml as an optional dependency for now, similar to the examples:
https://github.com/ecmwf-ifs/loki/blob/af8ec9fc47bc529f914969d9e88ed898dc788ebf/pyproject.toml#L62-L65
Call the option dataflow_analysis or something similarly meaningful. The import of ortools should then be wrapped with a safeguard similar to open-fortran-parser and clean exception if it isn't available.
https://github.com/ecmwf-ifs/loki/blob/af8ec9fc47bc529f914969d9e88ed898dc788ebf/loki/frontend/ofp.py#L15-L21
For the document, the best would probably be to convert this to a Sphinx document and integrate it into the documentation. But we can take care of that, so keeping the PDF like this is fine for now.

Since #178 and #179 are now stable, this branch has been rebased and most issues fixed.
Not functional (require help):

[ ] ortools installation (cant seem to figure it out how to add it to install)
[ ] test of notebook "06_..." complains about ungrouped-imports, but it is a notebook? that shouldnt matter there, at least to my understand

Enhancements:

[ ] convert function documentation to numpy style

"Example 11.35 from Compilers: Principles, Techniques, and Tools" should return false due to indepdent variable test, that is not the case. Whats going on?


jsx-runtime import should have .js extension

Describe the bug
It seems that the issue in react-dnd/react-dnd#3423 is due to swc emitting the jsx-runtime import as react/jsx-runtime instead of react/jsx-runtime.js, which is a problem in ES6 mode.
Input code
No response
Config
No response
Playground link
No response
Expected behavior
swc should emit a valid jsx-runtime import statement in ESM mode.
Actual behavior
No response
Version
1.2.168
Additional context
No response

This shouldn't be necessary, there's an entry in the package exports for the extensionless version<EMAIL_ADDRESS>See https://github.com/babel/babel/issues/12210

Yeah, that was added in React 18. TBH I just ended up upgrading React to resolve this. Maybe this isn't worth changing.


Large files being tracked in git

Approximately 700 mb are being tracked on old database files within the git repo. When trying to purge the files on a fork and switch over the database folder to git lfs, I run into this issue:
Git LFS: (0 of 8 files) 0 B / 237.83 MB
Git LFS objects can not be uploaded to this public fork.
Docs: https://github.com/contact
Git LFS objects can not be uploaded to this public fork.
Docs: https://github.com/contact
Since LFS is a part of github and not git, it might be in our best interest to use something else to download the database files.

Good point. I've moved all databases except the default to my site last
release for this reason... Maybe it will help at least going forward.
On May 13, 2016 12:45 PM, "Benjamin Hillmann"<EMAIL_ADDRESS>wrote:

Approximately 700 mb are being tracked on old database files within the
git repo. When trying to purge the files on a fork and switch over the
database folder to git lfs, I run into this issue:
Git LFS: (0 of 8 files) 0 B / 237.83 MB
Git LFS objects can not be uploaded to this public fork.
Docs: https://github.com/contact
Git LFS objects can not be uploaded to this public fork.
Docs: https://github.com/contact
Since LFS is a part of github and not git, it might be in our best
interest to use something else to download the database files.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/GabeAl/NINJA-OPS/issues/12


User is not able to delete message if text length is small.

Describe the bug
User is not able to delete the message if the length of text message is small.
To Reproduce
Steps to reproduce the behaviour:

Join a room
Send a message 'Hi'
That's It

Expected behaviour

It should show delete message option regardless of length of characters
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

@sanskarbansal  As the website is not implemented on small devices, we will look into that thing later, So this issue can be solved by giving the message box a `minimum-width.

I would like to work on this issue under LGMSOC21. Please assign to me.

@RituCs go ahead


[Enhance] speed up training

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
To speed up training
Modification
Refer to https://github.com/open-mmlab/mmdetection/pull/6974
modify default_runtime.py, add opencv_num_threads = 0 and mp_start_method = 'fork'
modify tools/train.py
Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

Does setup_multi_processes also work for tools/test.py?

Theoretically, it works. I will revise the code later according to the newest pr of mmdet.

The update refers to https://github.com/open-mmlab/mmdetection/pull/7036


Add PreTeXt to syntax list

Please feel free to close if this is an unwelcome request. PreTeXt is an XML vocabulary for the generation of scholarly documents that is actively used by a community of one or two hundred authors. Around 50 books have been written in it (that we know of). In addition I wrote PreTeXtual to duplicate some of the functionality of LaTeXtools. It provides a syntax definition that reflects the RELAX-NG schema of PreTeXt. The snippets that give the package much of its utility rely on the scopes that the package provides.
I would like to include instructions for using Exalt to validate PreTeXt in the official documentation, but without the change in this PR, it is either necessary for users to edit the Exalt source themselves or switch syntaxes in Sublime. It would be nice to have it supported natively if this is a change you're willing to make. Thanks for considering it and of course I understand if not. Thanks for your work on Exalt.

I like your idea much better. It is far more elegant and general. I will try to do it tonight or tomorrow if I can grab a few minutes.

I gave this a stab and released v0.3.6. When it appears in Package Control, could you give it a try and let me know if it solves the issue for you?

This seems to work beautifully after a quick test. I'll close this PR. Sorry I ended up forgetting about this issue, but thank you very much for the improvement! Now I can recommend Exalt in the PreTeXt documentation.

No worries! Glad to hear it's working.
Please don't hesitate to let me know if you come across any further issues.


Page metadata management

Create a metadata management system on page-level.
A few use-cases where this is relevant:

same-as redirect management of a page
social-media metadata management

We discovered an issue with the sameAs property.
If it's used without a prefix, eg. like this:
<meta property="sameAs" content="/w/1/index.php/Bakehouses/BelgiumBoortmeerbeekHeverBlokstraat38" datatype="xsd:anyURI" />
but the template file is defined with a prefix, eg. like this:
<meta property="sameAs" datatype="xsd:anyURI"/>
the substitution is not made during parsing and the value dissapears in a subsequent save, effectively losing data.

This issue was resolved internally, by rewriting the HtmlParser and implementing a floating RDF context window that keeps the context actual while parsing the html files. Basically, this means all properties (both @data-property and @property) are now expanded fully (eg. converted to full ontology URIs) during parsing.

Page alias management implemented.
Up next: social media metadata (in separate issue)


Max value dont work with zero decimal places

Hi,
if you put inline max value like this: 1000.00 it doesn't work, however 1000.01 works fine.
Demo: http://jsfiddle.net/F2a36/

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually, especially after several years with no activity. It doesn't mean I'm abandoning the project, just that I'm unable to work through 200+ open issues with the little time I can afford to spend on this project.
To the reporter (or anyone else interested in this issue): If you're still affected by the same issue, please consider opening a new issue, with a testpage that demonstrates the issue with a current version of the plugin. Even better, make an attempt to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!

Hey,
That's fair enough. :)
But I think closing the issue might be misleading for some people, you should rather tag it help wanted

#1391 should solve this.

@danielhusar its now fixed :-)


Add new field extracted_to to CodebaseResource

In #485, we have an issue where we get two DiscoveredPackages for the same package when we scan a pypi wheel using the scan_codebase pipeline. This is happening because we report a Package detected from the wheel itself, and then we create another Package from the extracted METADATA file from the wheel. A way to avoid this would be for scancode.io to know where archives were extracted to. This way, if we detect that an archive is a Package, then we can easily tag its extracted contents as being part of that package. Alternatively, if we detect that an extracted archive is a package itself, then we can easily tag the archive as part of the package.

Hey can i work on this?
Also can you please describe what the extracted_to field would look like? will it be a ForeignKey or what?

@pombredanne ^^

@TG1999 ^^

You sure can work on this! You would need to get familiar on how extractcode works and how extraction works in SCanCode.io. It extracts files to a directory. Keep the extracted_to would be about keeping track of which an archive is extracted to.

Closed in favor of https://github.com/nexB/scancode.io/issues/827


Check yaml file exists in cloned repo

Description

Checklist

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[ ] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

Check yaml file exists in cloned repo

Style guide errors are resolved. Thanks @rustydb


Provide explicitly pausing annotations of ScaledObjects at the current replica count

Add pausing annotations of ScaledObjects  at the current replica count

Refactor current paused checking method of ScaledObjects
Add autoscaling.keda.sh/paused:true in ScaledObjects

Checklist

[ ] When introducing a new scaler, I agree with the scaling governance policy
[X] I have verified that my change is according to the deprecations & breaking changes policy
[X] Tests have been added
[X] Changelog has been updated and is aligned with our changelog requirements
[ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[ ] A PR is opened to update the documentation on (repo) (if applicable)
[ ] Commits are signed with Developer Certificate of Origin (DCO - learn more)

(https://github.com/kedacore/keda/issues/3304)
Fixes #

Relates to #

/run-e2e internal*

Can you add an e2e test that applies both paused + paused with specific replica count and make sure that the explicit count wins please?

Add  e2e test that applies both paused + paused.

/run-e2e

/run-e2e

/run-e2e

There is a Solr e2e test failed. It seems like that there is a problem when setting up Solr. Do you have any idea to fix it? @JorTurFer

There is a Solr e2e test failed. It seems like that there is a problem when setting up Solr. Do you have any idea to fix it? @JorTurFer

Let me check. In any case, you can ignore it as it's not related with this PR

/run-e2e

/run-e2e internal*

@SpiritZhou while waiting for a review; would you mind updating our docs in a separate PR please?

@SpiritZhou while waiting for a review; would you mind updating our docs in a separate PR please?

I have updated our docs (https://github.com/kedacore/keda-docs/pull/1190). Do you mean we need to add more detail info in the doc?

Any concerns for you @zroubalik / @JorTurFer ?

LGTM, let's merge this once docs PR is finished.
Thanks for the contribution!

Hi @zroubalik do you mind to review the docs PR again?

/run-e2e pause


resolves #15

@abecodes I updated the README.MD to describe nvim-cmp with luasnip config

Very much appreciated, thank you 🥇


fix: only show user orgs to add to projects

Description
Fix #644

I don't know if this is what we want here. E.g. in the student project we explicitly used this to be able to share with an org they are not a member of.


[Plugin User Interaction]: Improve causality of spans from bubbled events

Which problem is this PR solving?

Currently when bubbled events trigger multiple listeners, we create separate spans/traces for each of them, even though they were causally related.  It also makes it hard to see whether multiple "clicks" happened or just one.

Short description of the changes

Track event bubbling and assign parent span relationship (lowest traced handler on event bubble gets top-most span, other higher-element handlers are tracked as child spans recursively).

overall lgtm, I just would like to ask you to update the image images/main-sync.jpg to show how the trace will look like now after this change.

There's no difference in the examples because of this change - this only affects scenarios where event listeners on bubbling events are added at multiple levels of the DOM tree, which the examples don't do.


Navigating to Groups section in the Console Loads the browser 2 times

Describe the issue:

Get pack https://wso2.org/jenkins/view/products/job/products/job/product-is/org.wso2.is$wso2is/lastSuccessfulBuild/artifact/org.wso2.is/wso2is/6.0.0-beta2-SNAPSHOT/wso2is-6.0.0-beta2-SNAPSHOT.zip
Login to console as admin
Navigate to manage > groups section

Observe the browser loading tab. When navigating to groups section it will load for 2 times in the browser.
https://user-images.githubusercontent.com/31848014/183346171-74e3b808-8ccd-4b35-8133-2105c528ac0e.mp4
Google Chrome 99.0.4844.82
Firefox 103.0

The loader which comes on top of the UI is due to API calls which will trigger the loader each time an API request is made. Since the groups view require loading userstores, the second loader is triggered. Hence this is expected.


Span status should be set to Ok or error

The current spans statuses are always unset.

The spans should be finished with either

ok, if successful
error, if an error was returned

This has the advantage, that spans with an error are instantly visible in tools like Grafana:

This could be automated.

I just see that the error is set indeed, but the Ok is not set.

@dkrizic Good catch! Thanks for pointing this out. I’m a little bit busy at the moment but I can cover this area later. Alternatively, feel free to contribute if you’d like to address it sooner—I'd be happy to review the PR

@ravilushqa Could you please fix the pipeline on main, my PR fails as well, I just changed some go files.

@dkrizic It looks like there's an issue with the linting stage. I'll take a look and let you know once it's fixed.

done https://github.com/ravilushqa/otelgqlgen/pull/210


Cannot connect to BPL devnet

Trying to get this to work. I added the network hash and peers here::
https://github.com/billotronic/ark-client/commit/6dc4fa4521cc414183cdcf229d6d8193c3a2df24
and this is what I get
ark> connect devnet
Node: <IP_ADDRESS>:4000, height: undefined
ark devnet>

/usr/lib/node_modules/ark-client/index.js:108
      var respeers = JSON.parse(body).peers.map(function(peer){
                                           ^

TypeError: Cannot read property 'map' of undefined
    at Request._callback (/usr/lib/node_modules/ark-client/index.js:108:44)
    at Request.self.callback (/usr/lib/node_modules/ark-client/node_modules/request/request.js:188:22)
    at emitTwo (events.js:125:13)
    at Request.emit (events.js:213:7)
    at Request.<anonymous> (/usr/lib/node_modules/ark-client/node_modules/request/request.js:1171:10)
    at emitOne (events.js:115:13)
    at Request.emit (events.js:210:7)
    at IncomingMessage.<anonymous> (/usr/lib/node_modules/ark-client/node_modules/request/request.js:1091:12)
    at Object.onceWrapper (events.js:314:30)
    at emitNone (events.js:110:20)

The client connects fine to the ark mainnet. Not sure where to go from here
r00t@spiderskullisland Downloads]$ node -v

v6.9.2

[r00t@spiderskullisland Downloads]$ uname -a

Linux spiderskullisland 4.11.8-1-MANJARO #1 SMP PREEMPT Fri Jun 30 06:55:31 UTC 2017 x86_64 GNU/Linux

It is configured to connect to the testnet


You might want to fill the addr struct passed to accept

The standard accept function will fill the "addr struct" (passed as argument) with the address of the peer socket. This is not done by the "accept" in desock.c. Some applications will not continue executing until the "addr struct" is filled. For instance, the latest version of nginx will check the address of the peer socket (I tried it with select mode but not sure about other modes).

Good catch. Do you have a fixed implementation you could PR, by any chance?

I think you can fill the "addr struct" with a fake address (e.g. INADDR_ANY)  and set the "socklen_t * addrlen" correspondingly. That's what I did.

Could you push your code as a PR?

I am still "borrowing" the preeny code. When all set, I will PR.

Awesome, thanks :-)

7 months and still no PR :p
Running into the same issue with nginx.

There are some other interesting issues that might be worth looking into. While I'm having the same issue with addr not being set, I'm finding that eventually it does get set after about a minute... I'm not sure if something in the code is causing it to fall back to original_accept, but I'll try to investigate more.


Resource tree expands every time you run your project

Godot 2.1.3, Windows 10
If you collapse the subfolders of your res:// directory in the FileSystem section and then run your project, they all pop open.
This is very frustrating if you have a lot of nested folders, and I can't think of any practical/intended reason why this functionality would be present.

Duplicate of #7134, which is marked as dupe of #796, and is potentially fixed by #6732 (which isn't merged yet).
Thus, closing.

Ah, sorry! Looks like different keywords were used to describe it each time :)
(sorry as well for the extremely late reply) :)


fix(client): do not reset karmaNavigating in onbeforeunload

The unload handler itself does not know about navigation.
May fix #3482

:white_check_mark: Build karma 2796 completed (commit https://github.com/karma-runner/karma/commit/9acc32c0db by @johnjbarton)


185647872 connected plot points

This renders lines between plot points when both axes are numeric, using the Adornment pattern, as described in PT#185647872
There are a set of questions to resolve before taking it out of draft:
usePointLocations is a utility function and not so much a proper hook a hook at the moment, since it doesn't involve any lifecycle factors.   It uses and exports versions of getScreenX and getScreenY that could maybe be used in scatterdots in the future, but for the moment are only used by the ConnectingLine adornment.

[ ] decide if this is the time/context to refactor scatterdots so that it uses these getScreenX and getScreenY and/or determine if that's even a worthwhile path
[ ] resolve the typing issue in the dataset param for getScreenY

I screwed this up with a local rebase, so this PR is now closed.  I reimplemented it in #1902


Accidentally made squash. After this revert I will simply repeat the pull request and make a merge. Sorry for that.

@pbchekin please take a look


Print out exception message when attempting to find the Chrome driver

I'm finding it hard to know why my chromium / selenium setup is not working so as a first step I thought I'd get the tool to print out the error.

@boxabirds this is a helpful little addition. I have seen a lot of queries around this error.
Thanks. Merging the PR.


App: Compared to Feedly and InoReader image loading is not performant

As the title says, this is about reading Feeds on the Smartphone app.
I really like the small image View. All the big Feed Reader (Feedly, InoReader and Newsblur) having this view and it's pretty easy to compare how much is needed to scroll through the same Feed.
So round about I can say that the InoReader is taking the lowest bandwidth. Let me show that in a (round about) bandwidth comparison:

InoReader 0,8 MB
Feedly 2,2 MB
NewsBlur 2,6 MB

Would it be possible to improve that view by serving compressed images or smaller images like InoReader does.
This is by the way the reason why I currently prefer InoReader. But I more like NewsBlur as it fits much better to my UX experience.
Thanks and hopefully it's not that hard to fix.

The design goal of the app is certainly to serve up feeds' content without altering it too much, which includes keeping images at their original resolution as chosen by publishers/authors.  Have you tried enabling downloading offline stories/images?  This will prefetch almost all content when you are on WiFi (or your selected network type of choice) and vastly reduce how much bandwidth is used while reading.

I see and this a good thing for sure. I totally understand that there is no real will to change that.
Alright so I noticed I didn't have the settings (fetch stories/images) enabled. My fail.
So now they are enabled but I'm not quite sure what to check in the Download Using section. Is it Unmetered Wifi or Ethernet Only for denying downloading(fetching) without Wifi network. Am I right?

Yes, that default setting (unmetered WiFi / ethernet only) will only allow prefetch when on such unlimited-style networks. Images will still be loaded on demand regardless of network if they weren't cached, of course.

Great, issue solved with that solution. Thanks.


customise getEmailWhitelist function based on active defence to preve…

…nt bot getting confused

The code looks good to me, but for some reason it's getting into a function call loop for me where it keeps sending emails

No idea how the code changes could cause this though.

oh i've seen this once before actually, cant replicate it right now though. might be a different bug?

if you reset backend does it happen again?

if you reset backend does it happen again?

No, even if I reset both backend and frontend I see the same thing. The prompt I use is "send an email to<EMAIL_ADDRESS>saying hi". Looking at the logs it doesn't look like the getWhitelist function is even called by the bot, so I'm really not sure what's happening.

thats weird! looking into it


display-name has false positive on nested use of memo and forwardRef

Since #2399, eslint-plugin-react knows not to complain about code like this:
export const ComponentWithMemo = React.memo(function Component({ world }) {
 return
Hello {world}

})

export const ComponentWithForwardRef = React.forwardRef(function Component({ world }) {
  return
Hello {world}

})

In that pull request, nested use of memo and forwardRef like so...
export const ComponentWithForwardRef = React.memo(React.forwardRef(function Component({ world }) {
  return
Hello {world}

}))

...was intentionally treated as a display-name violation due to a React bug causing such components to be anonymous. This issue was solved in November 2019, so the display-name should now accept this.

In which React versions is that fixed in React? We should only consider that satisfactory in those versions.

I'm unsure, but judging by the date, it should have gone in somewhere in the React 16 cycle.

Clicking on the commit that merged the PR implies it's actually gone out in v0.14.10, v15.7.0, and v16.12.0+ - so that's the range we should be using.

React.memo takes a component, so a function passed to it absolutely should be required to have a displayName, since it won't implicitly infer a name from anywhere.
React.forwardRef does not take a component, so this shouldn't complain.
However, the specific nested case should complain - unless React is one of the versions mentioned here, in which case it should not complain.
To handle that in the code, the report call should only be made if the react version fetched from settings is high enough.


Upgrade Autoform to 6.0.0

Closes #20

Might be best to bump the major version here since the jump to 6.0 could break dependents. Up to you.


[release/3.1] Fix the badness and get this branch building

work around dotnet/core-eng#7970 w/ lots of logging (ugly hack that should be reverted ASAP)
work around dotnet/arcade#4021 (not too bad)

Success modulo a missing New-Item -ItemType Directory .\.tools\ -ErrorAction SilentlyContinue❕❕
/bump reviewers (should get this in ASAP i.e. without waiting for a merge from the 3.0 branch).


Introduce Swift Formatting

:tada: This PR is included in version 2.11.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[QUESTION]How to iterate over a list of items to use it in c.Search method of twint library and save the output into separate files?

I'm trying to collect some data from twitter using twint library.
I've a list of search_terms and I want to take each value from this list and call c.Search on each value. I tried the below method, but I get output only for aclens value and only that is saved in csv format.
What am I doing wrong? Please correct me if am wrong in writing the code for output as well.
This is my code:
import twint
import os

search_terms = ['nike','adidas']

def jobone():
    c = twint.Config()
    for i in range(len(search_terms)):
        c.Search = search_terms[i]
        c.Lang = "en"
        c.Since = "2019-07-01 00:00:00"
        c.Limit = 3000
        c.Store_csv = True
    for filename in search_terms:
        c.Output = os.path.join('../data/{}.csv'.format(filename))

    twint.run.Search(c)

jobone()

Expected Output:
3 csv files stored separately with the names given in the search_terms with tweets in those csv files.
Running this on Linux machine.

Solved this.


could not write anything on opening terminal in atom

On opening terminal in atom ,I can not write anything .
Only there is blinking of cursor but could not able to write.

Same problem. Running Atom 1.32.1 on MacOS Mojave. node-gyp, xCode and python are installed.

+1

Also having problems with just getting a blinking cursor and not able to type into the terminal.
I have Atom 1.32.1 on MacOS Sierra.  Used apm install --verbose terminal-plus and the following is the last part of the output.
gyp verb install version is good
2.0.9
gyp info ok
><EMAIL_ADDRESS>install /private/var/folders/wb/dt2lvcmn6tl008t3d1_hyptr0000gn/T/apm-install-dir-118108-84065-98fdgs.rhw3r/node_modules/terminal-plus/node_modules/pty.js
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/pty/src/unix/pty.o

><EMAIL_ADDRESS>postinstall /private/var/folders/wb/dt2lvcmn6tl008t3d1_hyptr0000gn/T/apm-install-dir-118108-84065-98fdgs.rhw3r/node_modules/terminal-plus/node_modules/pty.js
> node scripts/post-install.js

npm WARN saveError ENOENT: no such file or directory, open '/private/var/folders/wb/dt2lvcmn6tl008t3d1_hyptr0000gn/T/apm-install-dir-118108-84065-98fdgs.rhw3r/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/private/var/folders/wb/dt2lvcmn6tl008t3d1_hyptr0000gn/T/apm-install-dir-118108-84065-98fdgs.rhw3r/package.json'
npm WARN apm-install-dir-118108-84065-98fdgs.rhw3r No description
npm WARN apm-install-dir-118108-84065-98fdgs.rhw3r No repository field.
npm WARN apm-install-dir-118108-84065-98fdgs.rhw3r No README data
npm WARN apm-install-dir-118108-84065-98fdgs.rhw3r No license field.

+<EMAIL_ADDRESS>added 25 packages from 15 contributors and audited 97 packages in 34.258s
found 1 high severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details
✓

Let me know if more info is needed or if there are steps I can take to use terminal-plus.
Kevin

See here: #543.

Awesome, thanks.  Will try the Termination library.
Kevin
On Sat, Nov 10, 2018 at 11:03 AM Reader8765<EMAIL_ADDRESS>wrote:

See here: #543 https://github.com/jeremyramin/terminal-plus/issues/543.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jeremyramin/terminal-plus/issues/552#issuecomment-437594183,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYqIh5XYnE-g5Jy8_xkD-NsJLkwqpyjDks5utvjtgaJpZM4YCV5y
.


PP-100 Add excluded tests/core/models files to mypy type check

Description
Adding tests from tests/core/modes module that were excluded to mypy type checking.

Motivation and Context
During tests refactor some files were excluded from type checking. This is part of the effort to have full CM type checking coverage.
Jira

How Has This Been Tested?
Ran mypy type checker and existing tests.

Checklist

[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.

Looks Good 👍 Just added one question

@RishiDiwanTT thanks for the review! If you have the time please review https://github.com/ThePalaceProject/circulation/pull/1226 so I can merge both to the main.


Add new workflow for issue -> PR.

This workflow will automatically create a PR with a new ./tweets/*.tweet file merging which should trigger already present twitter-together workflow and the tweet should go out.
I have tested this workflow on my own repo here: https://github.com/anubha-v-ardhan/test-twitter-together
The required issue form for this workflow will be added soon (see issue #16)
Fixes: #15
Thankyou :)

@saiyam1814 Added a few comments explaining each major step. Do let me know if more detailed comments are needed

LGTM


Add respond_to? for method_missing

As of your presentation yesterday, can you make it respond_to_missing? instead?


Update wiki text for using Sublime nightlies

As a follow-up from https://github.com/Microsoft/TypeScript-Sublime-Plugin/pull/433#issuecomment-178179257.

Should be updated now.


Updated build tools & A force close bug fix

Edit: This PR solves #44
I'm not sure what was the source of the bug but after updating the build tools of my app the ReporterActivity kept force closing on create (When using the setGuestEmailRequired(true)) and when clicking the submit button.
This is the exception I was getting
   java.lang.ClassCastException: android.widget.FrameLayout cannot be cast to android.support.design.widget.TextInputLayout
           at com.heinrichreimersoftware.androidissuereporter.IssueReporterActivity.validateInput(Unknown)
           at com.heinrichreimersoftware.androidissuereporter.IssueReporterActivity.reportIssue(Unknown)
           at com.heinrichreimersoftware.androidissuereporter.IssueReporterActivity.access$100(Unknown)
           at com.heinrichreimersoftware.androidissuereporter.IssueReporterActivity$5.onClick(Unknown)

I managed to fix it by replacing the view.getParent with view.getParent().getParent().
But just to be safe (and for backwards compatibility) I added a while loop to check if the correct class is being cast (until the correct class is being cast)

View layout = (View) editText.getParent();
while (!layout.getClass().getSimpleName().equals(TextInputLayout.class.getSimpleName()))
      layout = (View) layout.getParent();
TextInputLayout realLayout = (TextInputLayout) layout;

I'm not sure what was the source of the bug but after updating the build tools of my app the ReporterActivity kept force closing on create (When using the setGuestEmailRequired(true)) and when clicking the submit button.
This is the exception I was getting
                                                            java.lang.ClassCastException: android.widget.FrameLayout cannot be cast to android.support.design.widget.TextInputLayout
                                                                   at com.heinrichreimersoftware.androidissuereporter.IssueReporterActivity.validateInput(Unknown)
                                                                   at com.heinrichreimersoftware.androidissuereporter.IssueReporterActivity.reportIssue(Unknown)
                                                                   at com.heinrichreimersoftware.androidissuereporter.IssueReporterActivity.access$100(Unknown)
                                                                   at com.heinrichreimersoftware.androidissuereporter.IssueReporterActivity$5.onClick(Unknown)

I managed to fix it by replacing the view.getParent with view.getParent().getParent().
But just to be safe I added a while loop to check if the correct class is being cast (until the correct class is being cast)

        View layout = (View) editText.getParent();
            while (!layout.getClass().getSimpleName().equals(TextInputLayout.class.getSimpleName()))
                layout = (View) layout.getParent();
            TextInputLayout realLayout = (TextInputLayout) layout;
            realLayout.setError(getString(errorRes));

In your commit the @IntDef was moved. Please move it back to the related constants as it was before so I can merge this pull.

It was done automatically by Android Studio code rearrangement.
Fixed it.


Extend op attrs with commutattive annotation

This PR extends the op attrs with commutativity.
This is required for the ongoing work to use the pattern language to express more general patterns.
@mbs-octoml  @mbrookhart @jroesch @electriclilies

closing due to inactivity, feel free to reopen if you'd like to merge


Deep GP example: input-connected network?

Putting autograd to the test of the many examples provided, the deep Gaussian process example is based on @duvenaud deep limits (unfortunately on inefficient matllab). More doc at the beginning of deepGP.py should clarify if the deep GP implemented is the pathology-free input-connected network or not.
In addition, it would be great to have a complete example matching with deepGPy of Hensman and Lawrence  https://github.com/SheffieldML/deepGPy  with the step function example pushed to two or three hidden layers with the corresponding normalized singular values. The example in autograd of "1.4 Fixing the pathology" would really be the ultimate test.
Fantastic work.

Thanks for the kind words.  The deep GP example isn't input-connected, and in fact is a very rough-proof-of-concept.  A student is turning it into a nicer version, which we'll put up once he's done, but neither one implements the full-fledged variational version by the Sheffield group.  This demo is more like FITC at each layer.


Possible issue on Linux with Firefox

Hey there,
I had been testing my application all day on Windows and utterances has been loading all day just fine through a QT WebEngine panel but when I fired it up on a Linux VM, nothing loaded. I then attempted to just open it in a browser to see if I got anything back and I checked the Firefox console and see that it says the following:
The Components object is deprecated. It will soon be removed.
SyntaxError: An invalid or illegal string was specified utterances.71248704.js:1
    oa https://utteranc.es/utterances.71248704.js:1

The page I was attempting to load on both machines was follows:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
  <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
  <meta http-equiv="Content-Style-Type" content="text/css" />
  <title>ISSUE_TITLE</title>
</head>

<body bgcolor="#3A3A3A">
<style type="text/css">.utterances { margin-top: -50px; }</style>
<script src="https://utteranc.es/client.js"
  repo="instance-id/instance-id.github.io"
  issue-term="title"
  theme="github-dark"
  crossorigin="anonymous"
  async>
</script>

</body>
</html>

Thanks,
-MH
Browser ----------
Firefox 74.0 (64-bit)
System -----------
             /////////////                mosthated@pop-os-vm
         /////////////////////            -------------------
      ///////*767////////////////         OS: Pop!_OS 19.10 x86_64
    //////7676767676*//////////////       Host: VMware Virtual Platform None
   /////76767//7676767//////////////      Kernel: 5.3.0-7642-generic
  /////767676///*76767///////////////     Uptime: 42 mins
 ///////767676///76767.///7676*///////    Packages: 2131 (dpkg)
/////////767676//76767///767676////////   Shell: zsh 5.7.1
//////////76767676767////76767/////////   Resolution: 1697x982
///////////76767676//////7676//////////   DE: GNOME 3.34.3
////////////,7676,///////767///////////   WM: GNOME Shell
/////////////*7676///////76////////////   WM Theme: Pop
///////////////7676////////////////////   Theme: Pop-dark [GTK2/3]
 ///////////////7676///767////////////    Icons: Pop [GTK2/3]
  //////////////////////'////////////     Terminal: gnome-terminal
   //////.7676767676767676767,//////      CPU: AMD Ryzen 9 3950X 16- (8) @ 3.49
    /////767676767676767676767/////       GPU: VMware SVGA II Adapter
      ///////////////////////////         Memory: 3507MiB / 12080MiB
         /////////////////////
             /////////////

@MostHated great account name :laughing:
I can't reproduce this- do you have any add-ons installed? Does it repro in safe mode?
https://support.mozilla.org/en-US/kb/troubleshoot-extensions-themes-to-fix-problems

Thanks, lol. I am quite fond of it.
As for the issue, no worries. It seems to have something to do with being run locally. Because I am using this as a frame/window within my application I just had the code/html page above on disk and loaded via python/QT and Linux just doesn't seem to like that, neither in Firefox or Python/QT. For some reason, Windows doesn't seem to care that it's run locally and it loads and displays just fine in both FF and py/qt.
Turns out, though, it is probably not going to be a good idea to try and run the page locally anyways due to the callback/redirect that occurs after you authenticate and login with Github. I am guessing it just doesn't have a way to try and redirect you back in that instance. I took the code above and uploaded to one of my servers and now everything seems to work fine on Linux in all instances. I had been awake for close to 72 hours when I was trying that, so it completely slipped my mind when I was trying to get it working, so that's my bad, lol.
I was using a text box a first to have someone input a title to use as the issue post title, then they would hit a button and then Python would read the data on the page from disk and do a string replace on the title section of the page and then actually load it so that it was loaded with the title someone typed in as seen below:
        self.html_path = os.path.abspath(os.path.join(os.path.dirname(__file__), "bugsubmit.html"))
        self.html = codecs.open(self.html_path, 'r')
        self.html_str = self.html.read()
        self.html_out = self.html_str.replace('ISSUE_TITLE', self.ui.title.text())
        # self._webview.setHtml(self.html_out, self.base_url)

Having to load the page on a server though doesn't exactly give me much of a way to change the page's title before loading it anymore, though. Is there any sort of way, or any recommendation you might be able to give about how I might be able to go about submitting the text in the comment as well as a custom title at the same time? If it's even possible, that is.
I know currently, it has to have the title first then it looks for other comments in there, but I am wondering if there is a setting to make it not care about any other comments, as each post is to be a separate issue thread to begin with?
If not, no worries at all, I am sure something will present itself as I continue to search for a workaround/solution.
Thanks
-MH


Update Enterprise tier benchmark numbers

Improved performance numbers for the Enterprise tiers.

@microsoft-github-policy-service agree

@flang-msft
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Updated link for OpenAPI 2.0 implementation

Fixed the link under the "Changes Since v2.13" section for the Open API v2.0 implementation.

LGTM

lgtm


Adform mobile integration documentation

Added Adform documentation for Adform Advertising SDK Integration changes.

iOS documentation is for Adform Advertising SDK Integration.

@rprunskas - please take a look at Jean's comments so we can re-review.

@rprunskas - please take a look at Jean's comments so we can re-review.

@jeanstemp Thanks for the review, I have changed documentation accordingly.

Hello,
We've made adjustments as requested. Can this pull request please be merged?
Thanks!

@andriusmisiunas It looks like the SDK changes themselves are still on hold. (See @mjacobsonny comment under https://github.com/prebid/prebid-mobile-android/pull/53) We don't want to merge in the documentation until the SDK updates can be made.

I believe the 1.0 SDKs have been released, but https://github.com/prebid/prebid-mobile-android/pull/53 is still open. What's the status here?

We have asked the developer to modify the changes according to the new SDK and resubmit the PR https://github.com/prebid/prebid-mobile-android/pull/53. Waiting for the developer to confirm the same

@ppuviarasu - we're coming up on a year here. Any progress?

Closing due to lack of activity in over a year.


Fix unit tests failure due to racing condition

The tests passed on the local debugging session but failed during
running. There are 2 issues contribute to the failure on the sever.

Initialize() will return slightly earlier than
traceEventSession.Process() is fully running. Which leads to the event
lost for the unit test because the unit test invokes the event
immediately after calling the initilize() on the module.
Although the right fix would be locking on initilize() until Process()
is fully up, it is an overhead to implement. At the same time, in real
world scenario, events are emitted in different process and will be
capatured once Process() is up.
So, I am fixing the issue by simple put a delay in the unit test after
calling initialize().

When using F5 (Debug) to invoke unit tests and break the test case in
the middle, the trace event session will be left. That's why after
Debug, the unit tests start to pass because there are existing opening
sessions writing the events into the channel. This introduces huge
inconsistence for the unit test result.
I added clean up logic for the tests to solve this issue.

Hi @xiaomi7732, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Actually, I suggest that the test fix is incorrect and that this failure uncovered a real issue product issue.
We should not include an arbitrary delay into unit tests.

It makes the test unreliable (what if the delay is still insufficient under some circumstances)?
It makes the test slower than it could otherwise be.

I had exactly the same problem to solve in the EventFlow implementation. Take a look (the test event session has an event that gets set when Process() gets to run and the test waits on that event before proceeding).
The product issue is that a real TraceEventSession gets created when the Etw telemetry module gets created. That is incorrect and I missed that during code review, sorry. The trace event session creation should be delayed until Initialize().
Also, unit tests should not cause the Etw telemetry module to create a real trace event session, ever. As you discovered, this might cause undesired side effects. Best practice is to ensure maximum isolation for the code under test and a mock trace event session provides that. HTH!

@karolz-ms, thanks for the review.
There are several points in your review and I'll explain one by another.

We should not include an arbitrary delay into unit tests - I agree. The reasons are good. I have addressed all of them except one. The only one exception is for the ReactToConfigurationChange test, where after configuration is updated, a small delay needs to be there before the pipeline start to get the events again. That I can't handle by waiting on the channel because the lost event will never be there.

At the same time, I am not too concerns about it. Because in the production environment, the events are provided by other processes. There needs no sync signal between the processes. Before session.Process() fully functional, no events are expected to be caught while as long as the session.Process() starts to fully function, events will then be caught.

We should delay the creation of the TraceEventSession until Initialize() is called - Good point. Sorry I didn't consider that before. It is fixed.

Unit tests should not cause the Etw telemetry module to create a real trace event session - Generally, I would agree this. However, ETW trace is an exception here. If we need to test the conversion of the event data object or to test the event handling against the EtwTelemetryModule, without creating a real etw session, there have to have a way to create a mock of TraceEvent. After all, that's the source data structure that we are interested in to verify against the result data (ITelemetry).

Directly mocking TraceEvent is not fit per current implementation because TraceEvent is not inheritable, nor of the existing derived classes has the ability that allow us to mock the Level property or the Message property. Unfortunately, those are the properties that we are interested in.
One way out would be abstract TraceEvent and having a wrapper for it and having all the access to use the wrapper. Technically, it is doable. But this means an additional wrapper in production code, and the only usage of the wrapper is for the unit tests. I don't think we should do that.
On the other hand, I do see the concerns that not able to creating ETW sessions because there's limitations on the user account / group / process privilege. I updated the unit test to making sure we have a good enough environment. Otherwise, the all the etw collector test cases will be skipped with a  warning of inconclusive assertion.
Hope this addresses all the concerns.
Thanks again for the review.

@xiaomi7732 do you want to follow @karolz-ms advice or this PR is good to merge?

@karolz-ms Updated.
@SergeyKanzhelev, please help merge the change. Thank you!


 colour is not changing and  colour have changed

Challenge Waypoint: Change the Font Size of an Element has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.80 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

In the future please use the Help Chat for challenge help.
Thanks and happy coding!


Set up settings screen and wire it up to Supabase

Not fully functional with our goals, but changing email and full name works.
Preferences such as push notifications and/or email notifications will be done separately.
We also need some way of giving the user feedback when confirmation mails are sent when emails are being sent.


Why is WIC backend disabled by default?

Is this to support old Windows versions? Because it's not tested well enough? Or is there some other reason?

I ported this from autotools, where it was always disabled.
https://github.com/libsdl-org/SDL_image/blob/c1b7cf959c7d3150b0707f95a0c5268689c9e537/configure.ac#L290
This discussion from 2 years ago point at lack of trust in the wic backend.
I think the actual reason is that the current implementation does not allow to make use of libjpeg and wic simultaneously.
See
https://github.com/libsdl-org/SDL_image/blob/c37c316cce394eb11f0396b2feed9785525c76af/CMakeLists.txt#L403
By refactoring the code to being able to dynamically choose a backend, I think wic can be enabled.
Would SDL hints be a good for this?

I think the actual reason is that the current implementation does not allow to make use of libjpeg and wic simultaneously.

And yet Image I/O is enabled by default, go figure. I guess that's for historical reasons? Looking back, it seems that WIC backend came from a user patch while Image I/O was contributed much earlier by one of core devs. But I may be wrong on this one.

This discussion from 2 years ago point at lack of trust in the wic backend.

Quoting linked discussion:

And actually I'm not fond of enabling this one - it's not enabled in autotools, it's not enabled in MSVC project files - and who knows why..

Which gives us circular reasoning - it's off by default because there's no trust in it due to being off by default...

By refactoring the code to being able to dynamically choose a backend, I think wic can be enabled.
Would SDL hints be good for this?

Why not, SDL hints sound like a fine tool for this job. Make format initialization fill in function pointers for preferred decoder and then use those.
My main motivation for asking this is https://github.com/mesonbuild/wrapdb/pull/982. If lack of ability to switch at runtime to libpng/libjpeg/stb_image is the main concern, do you think defaulting to WIC on library-user-controlled builds would make sense?

It's off by default because it gave different color values for decoded images. We wanted decoded output to be consistent across platforms.


Cannot dotnet run templates created via build.cmd

Describe the bug
When contributing to the templates, the steps to build and create templates to test does not work as expected following the steps in the README
To Reproduce
Steps to reproduce the behavior:

Follow steps to build templates from source in this repo
Attempt to dotnet run generated template

Expected behavior
Get below error, looks like the project is not pointed to the framework built from source
It was not possible to find any compatible framework version                                                            The specified framework 'Microsoft.AspNetCore.App', version '3.0.0-dev' was not found.
  - The following frameworks were found:
      2.1.9 at [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
      2.1.11 at [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
      2.2.3 at [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
      2.2.5 at [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
      3.0.0-preview5-19227-01 at [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]

You can resolve the problem by installing the specified framework and/or SDK.

The .NET Core frameworks can be found at:
  - https://aka.ms/dotnet-download

Additional context
.NET Core SDK (reflecting any global.json):
Version:   3.0.100-preview5-011568
Commit:    b487ff10aa

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18362
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview5-011568\

Host (useful for support):
  Version: 3.0.0-preview5-27626-15
  Commit:  61f30f5a23

.NET Core SDKs installed:

2.1.507 [C:\Program Files\dotnet\sdk]
2.1.604 [C:\Program Files\dotnet\sdk]
2.1.700-preview-009618 [C:\Program Files\dotnet\sdk]
2.1.700 [C:\Program Files\dotnet\sdk]
2.1.800-preview-009677 [C:\Program Files\dotnet\sdk]
2.2.204 [C:\Program Files\dotnet\sdk]
2.2.300-preview-010067 [C:\Program Files\dotnet\sdk]
2.2.300 [C:\Program Files\dotnet\sdk]
2.2.400-preview-010195 [C:\Program Files\dotnet\sdk]
3.0.100-preview5-011568 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.0-preview5-19227-01 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.0-preview5-27626-15 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.0.0-preview5-27626-15

[C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

@ryanbrandenburg @mkArtakMSFT it looks like something in the project templates README needs to be updated. Can you take a look at this one?

@isaac2004 by follow steps to build do you mean these steps?

@ryanbrandenburg yep, not sure what is going wrong

If I had to guess based off your error message the . .\activate.ps1 script didn't succeed for some reason. If it had your ".NET Core runtimes installed:" area would contain some entries like $YourRepo.dotnet\x64* before you do "dotnet run" is something pre-pended to your powershell prompt (for me it's (AspNetCore))?

@ryanbrandenburg yep it is

@ryanbrandenburg how else we can help here? @aspnet/build do you have any suggestions regarding this?

After doing a clean clone and talking with @ryanbrandenburg, I got it working. Closing


Feedback provider for legacy usage

Summary of the new feature / enhancement
Users switching from cmd or bash may have muscle memory for commonly used commands with parameters.  It would be useful to have a FeedbackProvider detect this and inform the user what the correct PowerShell syntax would be and have a predictor so that it can fill in the suggested fix.
Common use cases:
rm -rf
dir /s/q
Please add your own to this issue.
Proposed technical implementation details (optional)
No response

From cmd, I find myself doing

dir /s /b
rd /s /q

Yes, rd /s /q is the primary reason I'm still using cmd instead of PowerShell

ipconfig
arp
netstat
tracert
ping
route

dir /a:h to see hidden files
cmd /c /dir /a:h works of course, I just get an error first and remember to add that

nslookup
ping  -t
shutdown /r /t 0
echo
wget
curl
set (to display environment variables, cmd)
icacls (huge rabbit hole but would be nice if it had a translation table, from icacls to set-acl)

In recent history this has been provided for UNIX by "rosetta stones", eg https://www.lurklurk.org/rosetta.html or https://bhami.com/rosetta.html. This would be easier to manage as an external page rather than a feedback provider.

Rosetta stones does not solve the frustration of broken muscle memory

ls -la
Always gets me

ipconfig
arp
netstat
tracert
ping
route

These commands all still work in  PowerShell.  There are equivalent commands for some things, but if you want Test-NetConnection instead of ping it is probably because you want different functionality

nslookup
ping -t
shutdown /r /t 0
echo
wget
curl
set (to display environment variables, cmd)
icacls (huge rabbit hole but would be nice if it had a translation table, from icacls to set-acl)

Mostly the same although there are some things in shutdown.exe that stop-computer / restart-computer doesn't same able to do.  Set is an obvious one which is missing.  Things like curl vs invoke-webrequest if you know curl and you don't need any other functionality then using what you would use in another shell is fine. .
Echo is aliased so the muscle memory works

dir /a:h to see hidden files cmd /c dir /a:h works of course, I just get an error first and remember to add that

It took me ages to learn that dir -force in Powershell returned hidden and system files, but "filter to just hidden" is clunky.
One that gets me is  in most languages we can create an object with  Var = New Object-type, but in PS, New is the old -Object cmdlet that doesn't have an alias to the verb without the -Object

rm -rf
ls -la
df -h
So unix like tools would be a cool thing

Users switching from cmd or bash may have muscle memory for commonly used commands with parameters.

Is there a need on Linux or macOS? Most of the commands mentioned simply use the underlying implementation so should just work.
PS /home/bythesea> get-command mkdir,ls,pwd,cat,echo,rm,df,curl,wget,ping,traceroute

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     mkdir                                              <IP_ADDRESS>    /bin/mkdir
Application     ls                                                 <IP_ADDRESS>    /bin/ls
Alias           pwd -> Get-Location
Application     cat                                                <IP_ADDRESS>    /bin/cat
Alias           echo -> Write-Output
Application     rm                                                 <IP_ADDRESS>    /bin/rm
Application     df                                                 <IP_ADDRESS>    /bin/df
Application     curl                                               <IP_ADDRESS>    /usr/bin/curl
Application     wget                                               <IP_ADDRESS>    /usr/bin/wget
Application     ping                                               <IP_ADDRESS>    /bin/ping
Application     traceroute                                         <IP_ADDRESS>    /usr/sbin/traceroute

It appears you are trying to recursively and forcibly remove files.  In PowerShell, the correct syntax would be:
rm -r -fo

But this isn't really true, because while it is an alias on Windows it uses the native command on Linux and macOS
On Linux
PS> get-command rm

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     rm                                                 <IP_ADDRESS>    /bin/rm

On Windows
PS> get-command rm

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Alias           rm -> Remove-Item

So it would be more correct to say
It appears you are trying to recursively and forcibly remove files.  In PowerShell, the correct syntax would be:

   Remove-Item -Recurse -Force

If you want users to write portable scripts.

you like?

Set is an obvious one which is missing. Things like curl vs invoke-webrequest if you know curl and you don't need any other functionality then using what you would use in another shell is fine.

I am not sure why Set should be considered missing. PowerShell is not cmd.exe, it does not manage its variables in the same way, and neither should it pretend to.
curl is not an alias anymore so should happily work even on Windows.
PS> Get-Command curl

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     curl.exe                                           <IP_ADDRESS>    C:\WINDOWS\system32\curl.exe

Linux
PS> Get-Command curl

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     curl                                               <IP_ADDRESS>    /usr/bin/curl

Still a good addition to PowerShell that I don't think has been added yet.