Can we perhaps add Release Please back, now that we're moving to a 2 week release schedule ?

@M123-dev Can we perhaps add Release Please back, now that we're moving to a 2 week release schedule

https://github.com/openfoodfacts/smooth-app/pull/1827

Sure @teolemon

But can you elaborate a bit more.

Release Please -> public Release every two weeks
Should we publish the changelog to the stores

‐--------

Do we want daily Releases to internal/testflight
What about public beta on playstore

https://github.com/openfoodfacts/smooth-app/discussions/2249
#2286

Assigned myself but won't be able to work on it for some time if anyone wants to take it feel free to do so. There should be a PR in the git history where I did exactly that should be just a thing of doing the same changes again


Docs generated?

Are the docs generated by some processor from the source code?
If yes, why are they part of the repo?

They were generated using dlang-community/harbored-mod. I'll remove them.

Thanks for clarification :)


add compose type generate support

@StrongMonkey you need to move this logic to types.  It's not generic enough for norman.


Integrate website analytics for Web export

Modify https://github.com/Praytic/youtd2/tree/main/Build/Web to include Google analytics (or alternatives) to collect website stats.

Using Sentry analytics and error reporting


python.buildEnv: install out and lib outputs

Motivation for this change
Needed for example for Caffe which places its binaries into a separate bin
output.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

With Python libraries we do not use multiple outputs.
Caffe is not a Python library. How about we stick to the buildEnv behaviour, that is,
extraOutputsToInstall ? []

What is needed long-term is a "higher-level" buildEnv that is aware of how to building Python envs, and Haskell envs, and Perls envs, and ...., all together in one env.

@FRidh Caffe is actually a Python library (it has Python bindings). The problem is that because they are installed in out and the default output is bin buildEnv gets confused now.

I just saw you added the bindings to python-packages.nix.
In any case, I still think we should not deviate from buildEnv by installing more outputs.

Yeah, I see why this is a good approach. Should we then add extraOutputsToInstall?
I still don't like that people will ask questions like "I made a Python environment with Theano and it doesn't work, what's the matter?" but I don't see any better way to do it (apart from making Theano not use multiple outputs but I don't like it...).

Closing in favor of a commit that adds extraOutputsToInstall ? []


Implement missing algorithm id generation for the RSA-PSS signatures

Fixes #13969

properly handle the mandatory RSA-PSS key parameters
improve parameter checking when setting the parameters
compute the algorithm id at the time it is requested so it
reflects the actual parameters set
tests added to the test_req recipe that should cover the PSS signature
handling

Checklist

[x] tests are added or updated

Finally CI passed

Finally CI passed

@levitte please re-approve

Reconfirmed approval.

This pull request is ready to merge

Merged to master. Thank you for the reviews.


Compatibility improvement

Improvement of compatibility with liip/imagine-bundle

Thanks.

My plasure Denis, very helpfull bundle! I've tested it with newest liip v2.3.1 work like charm.


Cannot output files to blog directory

I have not been able to set up org-static-blog correctly.  After doing org-static-blog-publish,  it doesn't output any file to the blog directory.  Below is what I have in my .emacs file.  I essentially  copy and paste from the example from org-static-blog website.
(use-package org-static-blog
  :ensure t
  :config
  (setq
   org-static-blog-publish-title "My Static Org Blog"
   org-static-blog-publish-url "https://staticblog.org/"
   org-static-blog-publish-directory "~/git/www/nguyenthanhvuh/docs/myblog/"
   org-static-blog-posts-directory "~/git/www/nguyenthanhvuh/docs/myblog/posts/"
   org-static-blog-drafts-directory "~/git/www/nguyenthanhvuh/docs/myblog/drafts/"
   org-static-blog-enable-tags t
   org-export-with-toc nil
   org-export-with-section-numbers nil

   ;; This header is inserted into the  section of every page:
   ;;   (you will need to create the style sheet at
   ;;    ~/projects/blog/static/style.css
   ;;    and the favicon at
   ;;    ~/projects/blog/static/favicon.ico)
   org-static-blog-page-header
   "<meta name=\"author\" content=\"John Dow\">
<meta name=\"referrer\" content=\"no-referrer\">
<link href= \"static/style.css\" rel=\"stylesheet\" type=\"text/css\" />
<link rel=\"icon\" href=\"static/favicon.ico\">"

   ;; This preamble is inserted at the beginning of the  of every page:
   ;;   This particular HTML creates a
 with a simple linked headline
   org-static-blog-page-preamble
   "

  My Static Org Blog

"

   ;; This postamble is inserted at the end of the  of every page:
   ;;   This particular HTML creates a
 with a link to the archive page
   ;;   and a licensing stub.
   org-static-blog-page-postamble
   "

  Other posts

bastibe.de by Bastian Bechtold is licensed under a Creative Commons Attribution-ShareAlike 3.0 Unported License."

   ;; This HTML code is inserted into the index page between the preamble and
   ;;   the blog posts
   org-static-blog-index-front-matter
   "
 Welcome to my blog
\n")
  )

Do you see any error messages?

I do not see any error message.  After I execute M-x org-static-blog-publish, it closes the current buffer and just displays "Attempt to display deleted buffer".  Is there a way to show what is going on behind the scene?
I am using emacs 27.2 on Mac OS with org-static-blog from melpa version 20210606.1806.

I figured out the problem.   I replace  the  ~/  to the full path /Users/myusername   and it works.  This is probably bug in org-static-blog that is specific to Macs (where the user's directory is /Users/myusername  instead of /home/myusername as in most Linux/Unix ).


disagg: Fix error when there are empty partitions

What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tiflash/issues/8220
Problem Summary:
When there are empty partition tables, we may receive EstablishDisaggTaskResponse with empty segment read tasks because the SchemaBuilder won't construct a table with a segment without any rows inside it.
create database if not exists partition360;
create table if not exists `partition360`.`partition360_8` (
  `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT COMMENT '自增id',
  `m_req_all` bigint(20) unsigned NOT NULL DEFAULT '0',
  `text` varchar(2048)        NOT NULL default '',
  `create_date` date NOT NULL DEFAULT '2000-01-01',
  `aid` int(11) unsigned NOT NULL DEFAULT '0',
  `atime` time NOT NULL DEFAULT '-01:00:00',
  `create_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP,
  PRIMARY KEY (`id`,`create_date`) /*T![clustered_index] NONCLUSTERED */,
  UNIQUE KEY `unq_p` (`aid`, `atime`, `create_date`)
  ) PARTITION BY RANGE COLUMNS(create_date) (
  PARTITION `p20210506` VALUES LESS THAN ("20210507"),
  PARTITION `p20210507` VALUES LESS THAN ("20210508")
  )
alter table partition360_8 set tiflash replica 2;
select * from partition360_8;
(1105, 'other error for mpp stream: Code: 49, e.displayText() = DB::Exception: Check n > 0 failed, n = 0, e.what() = DB::Exception,')

What is changed and how it works?
Add an empty channel for RNWorkers in this situation
Check List
Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Fix the issue that executing queries on empty partitions causes query failure

/run-all-tests

/hold

/hold cancel

/run-all-tests


[Docs] Clarification on Array Syntax needed

In the docs two versions to specify an array are used:

T[]
Array<T>.

IMHO this could lead to confusion and only one of the two ways should be used. (Why are there even two ways of doing this?)

We support T[] for TypeScript compatibility, though we tend to lean towards Array<T> ourselves, since we find it easier to read (Array<T> has no precedence ambiguity and when T is a long type expression the [] can be hard to spot).


Retain YAML formatting when using the Git write-back method

Is your feature request related to a problem? Please describe.
When the Image Updater updates a .argocd-source-<appName>.yaml or kustomiztion.yaml file, it does not retain their indentation. For instance, it may generate the following diff:
 apiVersion: kustomize.config.k8s.io/v1beta1
 resources:
-  - some-resource.yaml
+- some-resource.yaml
 images:
...

Describe the solution you'd like
Instead, the Image Updater should retain the existing formatting.
It turns out the issue is pretty common for other projects that edit YAML (see issues linked to https://github.com/kubernetes-sigs/kustomize/issues/3946). Since version 0.11.1, kyaml enables retaining the source file indention (see  https://github.com/kubernetes-sigs/kustomize/pull/4043). This feature has been integrated in Flux's Image Automation Controller (see https://github.com/fluxcd/image-automation-controller/pull/366), and I believe we can implement a similar feature for the Image Updater.
Describe alternatives you've considered
None.
Additional context
None.

Would be really great to have the original file content retained, and the only replaced parts are changed.
In our scenario when we write back to git helm values file for new tag, all the values become sorted and reformatted.

Need to check how to implement this in https://github.com/argoproj-labs/argocd-image-updater/blob/master/pkg/argocd/git.go#L338


swapDevices defining swap files should not be removed in the VM variant

The qemu-vm module clears the configured swapDevices when useDefaultFilesystems is false.
This makes sense in the context of swap partitions, as the default VM configuration does not declare any. There is no reason, however, for swap files to be disabled in VMs - they can be created in the default VM filesystem just fine.
When the device field in a swapDevices entry contains a path, it is treated as a file. Such entries should not be removed from the list in VMs.
I'm not sure how to go about fixing this. @T0astBread, do you have any ideas perhaps?

Add a :+1: reaction to issues you find important.

Did you mean "clears the configured swapDevices when useDefaultFilesystems is true"? Because it uses mkDefault when that flag is false which results in swapDevices in your system configuration taking precedence. There is also a test for swap devices with a non-default filesystem layout in nixos/tests/swap-partition.nix.

Assuming that's what you meant, I'm not totally sure but yeah, you could probably keep swap files with the default filesystem layout provided they are created and formatted somewhere before being activated (boot.initrd.postDeviceCommands comes to mind).
Filtering swapDevices to include only swap files (and drop partitions) is gonna be tough if not impossible though because both types of swap have a path in the device field. One simply points to a regular file while another points to a device file. And I'm pretty sure that's impossible to determine at evaluation time.
Maybe an alternative idea would be to introduce a new option to set swap devices in VM configurations specifically? I.e. something like virtualisation.swapDevices (analogous to virtualisation.fileSystems) which, if defined, takes precedence in a VM. In pseudocode, the order of precedence for swap devices would be:
if useDefaultFilesystems is true:
  if virtualisation.swapDevices is defined:
    virtualisation.swapDevices
  else:
    []
else:
  if virtualisation.swapDevices is defined:
    virtualisation.swapDevices
  else if swapDevices is defined:
    swapDevices
  else:
    []

Then you could place your swap files in virtualisation.swapDevices AND swapDevices and they will be present in both VMs and the real config. On the other hand, I'm also not sure if that's not way too complicated.


Develop

123

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: huoteng:x: huoteng.hthuoteng.ht seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Python: Added missing kernel pkg alias

copy pasting boilerplate code does not work without alias

Python 3.10 Test Coverage Report • FileStmtsMissCoverMissingTOTAL5881104582% report-only-changed-files is enabled. No files were changed during this commit :)
Python 3.10 Unit Test Overview

Tests
Skipped
Failures
Errors
Time

1257
1 :zzz:
0 :x:
0 :fire:
14.639s :stopwatch:


Typo on string 3

:tada: This PR is included in version 0.295.25 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Can a variational form contain more than two integrators?

Hi,
may I ask if it is possible to add different integrators into
one variational form,  like
ParBilinearForm *pVarf(new ParBilinearForm(pfespace));
pVarf->AddDomainIntegrator(new MassIntegrator(one));
pVarf->AddDomainIntegrator(new DiffusionIntegrator(one));
OperatorHandle  C;
pVarf->Assemble();
pVarf->FormSystemMatrix(p_ess_tdof_list, C);
In the end, will matrix C contain both  mass and diffusion parts ?
Thanks

Yes, all the integrators (domain, boundary, etc.) are summed and assembled into the matrix. You can add as many integrators as you need.

Thank you @pazner .  This is really a great help.  It seems I did it correctly now. Many thanks.


Missing Monthly Package files from November 2023.

We don't see any new package files uploaded after October 2023.
aws s3 ls s3://anaconda-package-data/conda/hourly/2023/

Hi @rshah-coatue. Thanks for reporting this. November 2023 data is now available in the bucket.
December 2023 data is still being processed by an upstream pipeline and should be available before the end of the week.

Hi @rshah-coatue. Thanks for reporting this. November 2023 data is now available in the bucket.
December 2023 data is still being processed by an upstream pipeline and should be available before the end of the week.

Thanks much @cappadona.  Please keep me posted when December Data is available. Really Appreciated.

No worries, @rshah-coatue. December 2023 data is now available in the bucket as well. Thanks for your patience and understanding 🙏🏼.

Thank you very much for the update @cappadona.


drivers: espi: Correct default eSPI to UART mapping

Correct default mapping for eSPI UART virtual port to SoC UART
for MEC172x.
Signed-off-by: Meza Arellano, Jose A<EMAIL_ADDRESS>

Need to fix the compliance check


Getting fields from GraphQL

Description
I'm trying to figure out how to get all the fields from facebook's schema definition.
Research
Currently, I can get data on a facebook group with the following fragment:
QueryFragment Group: Group {                     id,                     name,                     url,                     description,                     privacy_info {                         icon_name,                         label {                             text                         },                         description                     },                     group_topic_tags,                     discoverability_info {                         icon_name,                         description {                             text                         },                         label {                             text                         }                     }                 }
I know the fields from:

common sense
looking at network traffic on the browser
guessing names simular to facebook-offical-graph-api

I'd like to know if there's a way to get all the fields?
I've looked into introspection queries without much success, but I'm not very experienced with GraphQL
Thank you for this repository, I've found a lot of usefull information and help from here!

Hmm, it's been a while since I looked into it, but my experience is that Facebook's GraphQL implementation is different from the Open Source implementations - For example, they don't support introspection queries, and they're moving towards hiding the schemas behind a "doc_id"/"query_id". The little information I've gathered has been from analysing error messages (not sure if this is still possible), and looking at network traffic, like you.
At some point I started trying to map their schema, I've now uploaded the little progress I made here, if you feel like taking a look, but I quickly discovered how infeasible that would've been without some kind of automation.
And that's about the point we're at 😕. If you do find anything, I'd love to know!

Thank you!
I haven't made much progress besides the group fields posted above.
I'll post any updates I discover in this thread


Rule Proposal: AllowedRange

Hi All,
There are currently a number of CloudFormation resources that have numeric attributes that only allow a specific range of values (eg. AWS::Cognito::UserPoolClient#RefreshTokenValidity).
It would be convenient if it was possible to easily validate that a supplied value was between a specific range of numbers. Therefore, I'm proposing an AllowedRange rule that would fail if the input provided is outside of the test range.
If this rule were to be implemented, resource specifications could be added to some resources something like:
{
  "ValueTypes": {
    "RefreshTokenValidity": {
      "AllowedRange": {
        "start": 0,
        "stop": 3650,
        "step": 1
      }
    }
  }
}

This would allow more stringent checks on input via cfn-lint and would potentially catch bugs/issues before they fail during a CloudFormation deploy.
Thanks!

@jessedoyle we are doing a portion of this.  What we hadn't done in is the step portion which would have been a good idea.  Since we don't have a lot of those defined it shouldn't take us long to include that.
https://github.com/aws-cloudformation/cfn-python-lint/blob/v0.21.5/src/cfnlint/data/ExtendedSpecs/all/03_value_types.json#L1082-L1085

And of course I went to test your scenario and found an issue.  I've include a sample... which has a lot more changes than what was really required.
Basic steps are:

Add the type to 03_value_types.json
Add the relationship to the new type in 04_property_values.json
Run cfn-lint --update-specs

@kddejong - Awesome thanks, I see that the NumberSize rule was added a couple of months ago (https://github.com/aws-cloudformation/cfn-python-lint/pull/792). This rule is exactly what I was looking for!
We maintain a few internal custom resources for Cognito resources, so we'll definitely be updating our resource spec overrides to include the NumberMin and NumberMax checks.
The step parameter was just a suggestion because it was similar to python's range function semantics, but I think it's fine without it.
Also, thank you for submitting a fix for the when the max/min spec was 0!
I consider the matter resolved, so I'm closing the issue.


Give saveAsExcel its own config options

Description: As a prerequisite to the hackathon project I'm working on to add support for exporting to Markdown, I propose giving saveAsExcel its own configuration section. This will be expanded later to give Markdown its own section, as well.
This fixes a (well, what I perceive as a) bug where the configuration for save as CSV (specifically, include headers) is used as the config for save as Excel. Thus, although the configuration states that queryEditor.results.saveAsCSV.includeHeaders the setting only impacts "saving results as CSV", it actually impacts saving to CSV and Excel. To resolve this, I have added a new configuration setting queryEditor.results.saveAsExcel.includeHeaders that controls header inclusion just for Excel. To facilitate this, the getConfigForExcel method in the ResultsSerializer has been updated to not call the getConfigForCsv method and instead read exclusively from the save as Excel settings.
Testing:

My manual tests behave as expected
Manual testing:
a) Set Query Editor -> Results -> Save As Excel : Include Headers to false
b) Run a query that selects something
d) Right click on results, select Save As Excel, give it a place to save (alternatively, click the little button for it)
e) Open file, validate headers are not included
f) Repeat a - e with Include Headers set to true, checking for headers
g) Repeat a - f while modifying Save As CSV : Include Headers

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 11 (36.36%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 42.442%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/services/query/common/resultSerializer.ts
0
7
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
29241

Relevant Lines:
64081

💛  - Coveralls

would be better to have separate ones for each save type
I wholeheartedly agree, but in the interest of small, simple PRs, I didn't put that in this PR. In my testing I also discovered that at least the query results export action seems to be going through the serialization service, which does use a single request type. I'd like to stop using that, but I think I'd be getting in deeper than I have time to accomplish (even outside the hackathon)

Maybe a small bit of annoyance/confusion from users that had the CSV setting set and then are wondering why it stopped working
I saw there's some kind of config migration mechanism but I have no idea where that is/how it works. My suggestion for that would be to create the new setting as whatever the user has CSV set to. If you can give me suggestions on how to approach that, I can add that in


PlantUML Build-In Function %filename not supported

Description
Running the example file PlantUML-buildin-functions.puml in NotePad delivers no value to %filename.
Running the example file in Windows 10 from Git Bash with the same JAR File provides a proper output.
Reproduction
Steps to reproduce the behavior:

Update to PlantUmlViewer/plantuml-1.2024.3.jar
Process the file in Notepad and export to SVG PlantUML-buildin-functions-notepad.svg
Process the file in Git Bash with

java -jar "c:/Program Files/Notepad++/plugins/PlantUmlViewer/plantuml-1.2024.3.jar"
    -tsvg -charset UTF-8 PlantUML-buildin-functions.puml

Compare both output files (attached examples)
PlantUML-buildin-functions-gitBash-win10

PlantUML-buildin-functions-notepad-win10

Expected behavior

I would expect to be able to put the %filename() into the footer.
The example might be good for the plantuml manual to explain buildin functions.
The output of Notepad processing is supported by the windows explorer preview.
But the embedding of code differs from that in the PlantUML Standard.

Can you explain the difference in processing XML Export results in Notepad to the Git Bash processing (Comparing the code makes this visible)?
Is it possible to run it in Notepad and achieve the same result:
bash:
<?xml version="1.0" encoding="us-ascii" standalone="no"?> ...

notepad:
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">...

Code
PlantUML-buildin-functions.puml
@startuml

left header
How to place an SVG-Logo here?
'<img: src="image.png"{scale=0.12}>
endheader

left footer
Rendered with PlantUML version %version() on %date("yyyy-MM-dd' at 'hh:mm") from file: %filename()
endfooter

title PlantUML buildin functions

l -> r
note left
Name
  Description
  Example
  > output

%date ("yyyy-MM-dd' at 'hh:mm")
  Retrieve current date.
  You can provide an optional format for the date
  > %date("yyyy-MM-dd' at 'hh:mm")

%dirpath ()
  Retrieve current dirpath
  > %dirpath()

%false ()
  Return always false
  > %false()

%file_exists ("./PlantUML-buildin-functions.puml")
  Check if a file exists on the local filesystem
  > %file_exists("./PlantUML-buildin-functions.puml")

%filename ()
  Retrieve current filename
  > %filename()

%function_exists ("%filename")
  Check if a function exists
  > %function_exists("%filename")

%set_variable_value ("$my_value","my_value")
  Set a global variable
  > %set_variable_value("$my_value","my_value")

%get_variable_value ("$my_value")
  Retrieve some variable value
  > %get_variable_value("$my_value")

%getenv ("Path")
  Retrieve environment variable value
  > %getenv("Path")

%intval ("42")
  Convert a String to Int
  > %intval("42")
end note
note right
%lower ("Hello")
  Return a lowercase string
  > %lower("Hello")

%newline () X
  Return a newline
  > %newline() X

%not (2+2==4)
  Return the logical negation of an expression
  > %not(2+2==4)

%string (1 + 2)
  Convert an expression to String
  > %string(1 + 2)

%strlen ("foo")
  Calculate the length of a String
  > %strlen("foo")

%strpos ("abcdef", "ef")
  Search a substring in a string
  > %strpos("abcdef", "ef")

%substr ("abcdef", 3, 2)
  Extract a substring. Takes 2 or 3 arguments
  > %substr("abcdef", 3, 2)

%true ()
  Return always true
  > %true()

%upper ("Hello")
  Return an uppercase string
  > %upper("Hello")

%variable_exists ("$my_value")
  Check if a variable exists
  > %variable_exists("$my_value")

%version ()
  Return PlantUML current version
  > %version()
end note

@enduml

Environment

Windows: [Win10]
Notepad++ version: [8.6.9 64-bit]
PlantUML PlugIn <IP_ADDRESS>
PlantUML Version 1.2024.3

Additional information

Maybe the parameter -filedir might enable the proper setting.

Also the !include of files with relative path descriptions ./file.puml or ../path/file.puml
does not work in my environment of Notepad++.

All environment variables are delivered by printenv, e.g.:
OS=Windows_NT
HOMEDRIVE=C:

We could not get this working for the %getenv() function at all, to access them, as shown in the example above:
%getenv ("OS")
  Retrieve environment variable value
  > %getenv("OS")

Hi @SieDa ,
thanks for your report. Filename was supported yet since it was not overridden by the pluging accordingly. I've fixed it in the latest commit. Try out the following build and let me know if it works for you: Run<PHONE_NUMBER>7.
Unfortunately, it seems like PlantUML isn't supporting %filedirectory() the same way so this still will not work. I've created an issue at the PlantUML repository. Maybe they have a look at it soon.
BR,
Philipp

Hi Philipp,
the example should be changed to "HH:mm" to show the timestamp based on 24h - Output is supporting the dirpath() and  filename() now:
"Rendered with PlantUML version 1.2024.8 on 2024-11-23 at 10:35 from file: PlantUML-buildin-functions.puml"
BR SieDa

My favourite !include now - thanks a lot:
'footer.puml
left footer \
Rendered with PlantUML version %version() on %date("yyyy-MM-dd' at 'HH:mm") from\l\
dir: %dirpath() \l\
file: %filename()


pcdet052 multi gpu training problem

Hi, I just update to pcdet052, and use Waymo to train, I find that when use multi gpu training and workers > 0, and when using gt aug, the code will stuck long time before start to training , but if I set workers = 0, quickly start to train. so either set workers = 0 and use gt aug, or set workers > 0 and don't use gtaug, I don't meet that problem in pcdet030.

Hello, I guess this is also caused by the larger size of gt database compared to pcdet030. A preivous issue also mentioned this but focus more on the larger memory usage. I think you can try to use shm to solve this.

@sshaoshuai, it works, after comment the line, quickly start to train.

what's more, the reason why starting to train so slow is not related with gtaug, even I use the gtaug generated before which sample interval is 10, it still use very long time to start to training, and when use more gpu like 8 v100, after stuck 2 hours, it still don't start to train.

Hi, I meet a similar problem.
In pcdet052, when I run detection on waymo dataset, gt sampling comsumes lots of time, which causes my training process unreasonble slow.
If I comment gt sampling in config files, the training is quick.
I checked running time of gt sampling, and noticed large time cost in database_sampler.py
Where could the problem lie in?
BTW, this does not work in my condition.

If you use dist_train.sh, please try to comment the following two lines:
https://github.com/open-mmlab/OpenPCDet/blob/master/pcdet/utils/common_utils.py#L162-L163
It is expected to be much faster to start the training.
After your try, I appreciate if you could come back to tell us whether it works.

Use shared_memory might solve your problem
https://github.com/open-mmlab/OpenPCDet/blob/5861246c31c876f0e5a3e125086ed2b0be7bc9da/tools/cfgs/dataset_configs/waymo_dataset.yaml#L31

If you use dist_train.sh, please try to comment the following two lines:
https://github.com/open-mmlab/OpenPCDet/blob/master/pcdet/utils/common_utils.py#L162-L163
It is expected to be much faster to start the training.
After your try, I appreciate if you could come back to tell us whether it works.

I have tried it, but it is still to slow to start on kitti dataset.


go/internal/gcimporter: too much CPU wasted on copying bytes

What version of Go are you using (go version)?

$ go version
go version go1.16.4 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/sz/.cache/go-build"
GOENV="/home/sz/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/sz/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/sz/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/sz/sdk/go1.16.4"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/sz/sdk/go1.16.4/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.4"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3202951029=/tmp/go-build -gno-record-gcc-switches"

What did you do?
I'm using go vet to do static checks on my project code. Said io.ReadAll wastes some 30% of time on my codebase. I've managed to reproduce the issue on smaller codebase. The code to reproduce is here: https://gist.githubusercontent.com/g7r/fef9fbf7577bb380de26587c08681b12/raw/1486d5d986f5f3222befca5197cee806632d82d2/repro_test.go. Run go test -bench . -benchtime 10000x -cpuprofile cpu.prof repro_test.go to gather profile.
What did you expect to see?
I expect not to see that large chunk of profile is dedicated to move memory while reading file into byte slice.
What did you see instead?
A lot of memory is being moved during file read. See attached profile screenshot:
I suggest we should remove io.ReadAll and use Reader in iImportData.

cc @dominikh who has profiled his static analysis tools for a while

I don't have much to say about this specific issue/"proposal", but I have a data point to contribute: I have a custom fork of gcimporter in Staticcheck, with the following changes to improve performance:

allow reuse of byte slices in GetExportData
only read type information from archives, skipping object code
read directly from an os.File when possible, skipping the indirection through a buffered reader
use unsafe for a more efficient implementation of (*token.File).SetLines

The 2nd and 3rd point likely have overlap with what's proposed here.

To comment on the suggestion to use io.Reader instead: with my changes, the amount of data read is quite reduced, making (the equivalent to) ReadAll much less expensive. Also, it's not a trivial change; IImportData is written around having random access to the data. An io.Reader alone wouldn't suffice, we'd also need seeking, and it would quite uglify the code. Mmap would be an alternative, if it didn't come with all the downsides of mmap.

cc: @findleyr @mdempsky

The compiler's importer (which gcimporter is derived from) simply mmaps the files and then lets them linger until process termination. This is acceptable for the compiler because it only reads a bounded number of exports. It's also necessary because the compiler simply returns string references that point directly into the mmap'd memory.
As @dominikh mentions, the export data format is structured around random access, so changing to an io.Reader isn't going to help. Changing to a ReaderAt would potentially work though without too much trouble: just change importReader.declReader into an io.SectionReader or something.
I've also designed a new export data format. When I get around to the go/types importer for it, I'll make sure to explore using ReaderAt instead of reading the file into memory as a byte slice.

Sorry for delay with the pull request, had to figure out test breakage.
I've made a quick performance comparison of master branch and my PR:
# before
$ go test -bench . -benchtime 10000x repro_test.go
goos: linux
goarch: amd64
cpu: Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
BenchmarkGCImport-12    	  10000	  2468308 ns/op
PASS
ok  	command-line-arguments	26.259s

# after
$ go test -bench . -benchtime 10000x repro_test.go
goos: linux
goarch: amd64
cpu: Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
BenchmarkGCImport-12    	  10000	  1975409 ns/op
PASS
ok  	command-line-arguments	22.049s

I got it that the code is under a heavy refactoring now but the fix is pretty local and gives good boost. Actually, the boost is even bigger on our internal codebase.


added l in amongus font

added l in amongus font
Referenced Issues
closes #943

added l in amongus font


Sub-entry batching implementation

This PR is implementing the sub-entry batching functionality https://github.com/qweeze/rstream/issues/53.
Similarly on what we already do in  Java/.NET clients:
https://rabbitmq.github.io/rabbitmq-stream-java-client/stable/htmlsingle/#sub-entry-batching-and-compression
https://rabbitmq.github.io/rabbitmq-stream-dotnet-client/stable/htmlsingle/index.html#sub-entry-batching-and-compression
Unit tests have been added as well as some manual tests with other clients to see compatibility

Hey @qweeze we are working on this sub-entry batch implementation similary to how is done: https://rabbitmq.github.io/rabbitmq-stream-dotnet-client/stable/htmlsingle/index.html#sub-entry-batching-and-compression and https://rabbitmq.github.io/rabbitmq-stream-java-client/stable/htmlsingle/#sub-entry-batching-and-compression
I'm doing a few more tests before completing it. Feel free if you'd like a have a look! Thanks!


docs(displaying-data): add table of contents

This is the first step for closing #935
The big image before the TOC gives a weird visualization, but I think that it should be there or perhaps delete it.

Updated :)

This is on hold until we figure out if we generate it automagically or not.


getWebcamByName problem.

I have imported 0.3.11 library into Processing and entered the following code.
import com.github.sarxos.webcam.Webcam;
import java.util.List;

void setup(){

   // I list all the cams to check the camera is seen and it is
    for (Webcam webcam : Webcam.getWebcams()) { println(webcam.getName()); }

   // I try the camera name I know and love but it is not found
    Webcam webcam = Webcam.getWebcamByName("MHS-FS2");
    if (webcam != null) {
      System.out.println("Webcam: " + webcam.getName());
    } else {
      System.out.println("No webcam detected");
    }

    // I still see the camera
    List<Webcam> cams = Webcam.getWebcams();
    System.out.println(cams.get(1).getName());

  // I get the code to build the string and voila!  I need to know where the camera is in the list
    webcam = Webcam.getWebcamByName(cams.get(1).getName());
    if (webcam != null) {
      System.out.println("Webcam: " + webcam.getName());
    } else {
      System.out.println("No webcam detected");
    }

  noLoop();
}

void draw() {
}

The loop through cams returns my camera in the list.
However, the call getWebcamByName("MHS-FS2") fails with a null.
Lifting the element (1) from the list of cams returns the "MHS-FS2 1".
So the code concatenates the list position of the camera to the camera name which is not intuitive .  The result is a tuple and likely akin to a dictionary or map where I expect to either to recover either the key or the val etc.
Is this something your code does or is it the OS?
If I attach multiple cameras, in different orders, I might expect that they appear in different positions in the list each time (dependant on how they are handled by OS of course).  Makes it hard to know in the code ahead of time.
I do have two bloggies so I will be curious how I will need to juggle between the two (in that case I would still have to associate a list index with one or the other bloggie ... tricky, something for me to fiddle with).
Otherwise, workable.

Hi @Bazmundi,
On the OS level, every webcam is internally recognized via ID (1, 2, 3, etc). This is a number that is given by OS and it's used to address specific webcam. The webcam name is something additional, that Webcam Capture API extracts additionally so users sees the webcams by the "name + ID" instead of just "ID" (usability feature to have "Microsoft Webcam 1" instead of just "1").
You can find out what are the cameras names by doing:
for (Webcam w : Webcam.getWebcams()) {
  System.out.println(w.getName());
}

The above is the "real" name that should be used to find specific webcam via the call to getWebcamByName(...).
You may ask why we cannot return single instance when calling this method? This is because you may have many webcams of the same model connected to the USB hub.

Yep.  Gotcha.  I do note that I did get stung, having downgraded from Windoze 7 to Windoze 10, as my cameras are listed in reverse order between the two versions of the OS.  The real quirk being that the Processing Video library returns entirely a different name for the camera as it appears to print a name for each resolution of the camera and no index.  No matter, I am using your library and thankfully yours actually works ;)
Well done!

The Processing is printing supported formats together with camera names. I didn't want to do that because not all capturing frameworks that can be used under the hood of Webcam Capture API support getting info on supported formats. E.g. OpenIMAJ does not have it and I'm pretty almost sure that OpenCV does not support it as well. The other ones like GStreamer, JMF, etc. has pretty nice API for this, but I wanted to keep Webcam Capture API to be common in regards to framework is being used.
Just FYI, I'm closing this ticket. If you have any further comments in regards to this issue, please do not hesitate to drop them here.


Animania animals not producing dung

This is a mod integration request. I assume that animals produce dung once in a while. I'm playing a few days now with Better With Mods, and it seems that dung is not produced by the animals from the Animania mod.

It should be working with any entity that extends EntityAnimal. Animania must be doing something different.


Lower screenshot quality with copy&paste canvas to PDF

Thank you for submitting an issue to jsPDF. Please read carefully.
Are you using the latest version of jsPDF?
Yes ("jspdf": "^1.3.5")
Have you tried using jspdf.debug.js?
Yes
Steps to reproduce

Use html2canvas to take a screenshot of a SVGDashboard

html2canvas(SVGDashboard).then(canvas => {
           // add canvas to browser to see its quality
           body.appendChild(canvas);

          // do step 2...
});

Note:
I find the quality of canvas is pretty good (Hardly see any blur)

Copy-Paste the Canvas from step 1 to PDF

 const pdf = new jsPDF({

                        orientation: canvas.width >= canvas.height ? 'landscape' : 'portrait',
                        unit: 'px',
                        format: [canvas.width, canvas.height]
                    });

                    const imgData = canvas.toDataURL('image/png');
                    pdf.addImage(
                        imgData,
                        'PNG',
                        0,
                        0,
                        canvas.width, canvas.height);

                    pdf.save('test.pdf');

the dashboard is more blurred compared to the canvas.

What I saw
Even thought html2canvas is able to generate a high-quality canvas from a SVG dashboard, jsPDF does not maintain the quality of the canvas.
What I expected
Since the canvas returned from html2canvas does not get re-sized, I expect the quality of the canvas to remain the same on the PDF generated by jsPDF.
Possible solutions

scale up the size of the SVGDashboard by 2 or more before taking screenshot with html2canvas
As a result, I will end up with a bigger canvas. As the canvas gets scaled down with pdf.addImage(). its quality should improve.

I am wondering if jsPDF provides other ways to improve the quality of the canvas when pdf.addImage is called to place the image on PDF.
Any help is appreciated.

Problems
I found the this issues occurs due to limiting the number of pixels for the PDF with "format: [canvas.width, canvas.height]".
Solution
While maintaining the aspect ratio of the paper, scales up the resolution by 3 times.
After I use "scale: 3" on the html2canvas before passing the canvas to jsPDF, the final PDF looks as clear as the canvas version.
Sidenote
it is recommended to use "FAST" as compress for addImage for small file size

I've made an example here.
But it does not work in Internet Explorer: any hints?


Auto pin option?

[X] I am on the latest release of BBT and Zotero
[X] I am posting a single question, bug or feature request
[X] I have included a descriptive subject of the problem
[X] I am available for follow-up questions and testing

Bug classification
Would it be possible to add an option to auto pin the key when a new item is added, and a new key is first generated?  We prefer to always have the keys pinned so they show up in the extra field when viewing on the web, and in general to ensure consistency across users of our shared lib.  Thanks!

Can you try 5745? You'll have to enable the hidden autoPin setting.

hmm -- didn't seem to work -- I enabled that setting in the config editor, restarted zotero, and grabbed a new reference, and it wasn't pinned automatically...

:robot: this is your friendly neighborhood build bot announcing test build 5832 ("Merge branch 'master' into 890").

Oh great, patching the save function doesn't always work. I have another option, but it's slower. Try 5832.

yep that works! :)

Alright, should drop in a few minutes.

btw are you going to add the autoPin option to a visible place in the preferences??  obviously would make it easier for others to find it..

I'm not sure yet. Z5 makes auto-pin a potential cause for race conditions, and I need to think more about potential edge cases.


Run main CDK deployment in ECS

This is for https://github.com/gchq/sleeper/issues/293 and https://github.com/gchq/sleeper/issues/292. This is closely related to https://github.com/gchq/sleeper/issues/531.

This would cause a lot of complexity in terms of permissions, and would result in a container in ECS with a very large number of permissions. Closing for now.


Adding Flowables::empty and Flowables:error

Adding some simple helpers for getting a completed or errored flowable (to assist error handling mostly).

Good additions. Definitely also reminds me we need to create a generic TestSubscriber soon.


POC: Add Microsoft.Data.SqlClient.Core package that has no Azure SDK …

…dependencies (to demonstrate where dependencies are used and test a build)
relates to #1108
Following linked files were removed from the .csproj:
    <Compile Include="..\..\src\Microsoft\Data\SqlClient\ActiveDirectoryAuthenticationProvider.cs">
      <Link>Microsoft\Data\SqlClient\ActiveDirectoryAuthenticationProvider.cs</Link>
    </Compile>
    <Compile Include="..\..\src\Microsoft\Data\SqlClient\ActiveDirectoryAuthenticationTimeoutRetryHelper.cs">
      <Link>Microsoft\Data\SqlClient\ActiveDirectoryAuthenticationTimeoutRetryHelper.cs</Link>
    </Compile>
 <Compile Include="..\..\src\Microsoft\Data\SqlClient\AzureAttestationBasedEnclaveProvider.cs">
      <Link>Microsoft\Data\SqlClient\AzureAttestationBasedEnclaveProvider.cs</Link>
    </Compile>

doesnt this bifurcate the ecosystem? eg if i want to write a lib that extends/uses sql, i now need two packages, one that targets each sql package

doesnt this bifurcate the ecosystem? eg if i want to write a lib that extends/uses sql, i now need two packages, one that targets each sql package

Not at all, the Azure version of the package could depend on the base version, and the extension libs could use the base version like how it does now, just with user versions not including the azure libs. This way it all acts similar to how creating extendable/extension libs using Microsoft.Extensions.DependencyInjection is currently.

@AraHaan

Not at all, the Azure version of the package could depend on the base version, and the extension libs could use the base version like how it does now, just with user versions not including the azure libs. This way it all acts similar to how creating extendable/extension libs using Microsoft.Extensions.DependencyInjection is currently.

but "creating an Azure version of the package " is not what is being proposed here. this is slicing off a new Microsoft.Data.SqlClient.Core package.
so it means, to avoid the azure bits, the stack of libraries that currently use/extend Microsoft.Data.SqlClient would need to move to Microsoft.Data.SqlClient.Core. for example  Microsoft.EntityFrameworkCore.SqlServer. and that would be considered a breaking change for each of those libs, so would likely have a very long tail until top level apps could remove Microsoft.Data.SqlClient
while breaking out a Microsoft.Data.SqlClient.Azure  package would be a breaking change for this project, it does seem like that would have less combine fallout for consumers
unless u misunderstand what is being proposed here

while breaking out a Microsoft.Data.SqlClient.Azure package would be a breaking change for this project, it does seem like that would have less combine fallout for consumers

Except it would be breaking for anyone using Azure auth today...

@ErikEJ

Except it would be breaking for anyone using Azure auth today...

yeah. no idea which group is more common

OK - once 5.2 has been released, I will try this approach (initially .NET only)
Microsoft.Data.SqlClient.Azure = current package, renamed (new .csproj with all current dependencies)
Microsoft.Data.SqlClient = new package without Azure auth dependencies
This will require anyone using Azure auth methods to use an explict reference to:
<PackageReference Include="Microsoft.Data.SqlClient.Azure" Version="6.0.0" />
Attempts to use Azure auth with Microsoft.Data.SqlClient should result in an actionable error message with links to a suitable docs page
Thoughts? @SimonCropp @roji @AraHaan @David-Engel

while breaking out a Microsoft.Data.SqlClient.Azure package would be a breaking change for this project, it does seem like that would have less combine fallout for consumers

Except it would be breaking for anyone using Azure auth today...

Yeah, except they can unbreak themselves by appending .Azure to the package name and calling it a day by releasing a new patch release if they do in-fact use the azure functionality.

OK - once 5.2 has been released, I will try this approach (initially .NET only)
Microsoft.Data.SqlClient.Azure = current package, renamed (new .csproj with all current dependencies)
Microsoft.Data.SqlClient = new package without Azure auth dependencies
This will require anyone using Azure auth methods to use an explict reference to:
<PackageReference Include="Microsoft.Data.SqlClient.Azure" Version="6.0.0" />
Attempts to use Azure auth with Microsoft.Data.SqlClient should result in an actionable error message with links to a suitable docs page
Thoughts? @SimonCropp @roji @AraHaan @David-Engel

Sounds good, yeah.

OK - once 5.2 has been released, I will try this approach (initially .NET only)
Microsoft.Data.SqlClient.Azure = current package, renamed (new .csproj with all current dependencies)
Microsoft.Data.SqlClient = new package without Azure auth dependencies
This will require anyone using Azure auth methods to use an explict reference to:
<PackageReference Include="Microsoft.Data.SqlClient.Azure" Version="6.0.0" />
Attempts to use Azure auth with Microsoft.Data.SqlClient should result in an actionable error message with links to a suitable docs page
Thoughts? @SimonCropp @roji Shay Rojansky FTE @AraHaan @David-Engel David Engel (SIMBA TECHNOLOGIES INC) Vendor

We should err on the side of compatibility. The reverse would be far less disruptive. People already expect M.D.SqlClient to support Azure connectivity. Those few who object to the current long dependency tail can move to a new M.D.SqlClient.Core package, which just has the base functionality. Base functionality in my mind is SQL auth, integrated Windows auth, and token auth (AccessToken, AccessTokenCallback).

@David-Engel

Those few who object to the current long dependency tail can move to a new M.D.SqlClient.Core package, which just has the base functionality

to achieve that all libs using Microsoft.Data.SqlClient would need to make a breaking change.
i think breaking change decisions should be made based on total impact to the consumers of Microsoft.Data.SqlClient.
ie SqlClient usage is an ecosystem, so decisions on braking changes should take that ecosystem into account

@ErikEJ
OK - once 5.2 has been released, I will try this approach (initially .NET only)

Microsoft.Data.SqlClient.Azure = current package, renamed (new .csproj with all current dependencies)

Microsoft.Data.SqlClient = new package without Azure auth dependencies

This will require anyone using Azure auth methods to use an explict reference to:

<PackageReference Include="Microsoft.Data.SqlClient.Azure" Version="6.0.0" />

Yes. i think that is the best compromise of all the options discussed

Those few who object to the current long dependency tail can move to a new M.D.SqlClient.Core package, which just has the base functionality

to achieve that all libs using Microsoft.Data.SqlClient would need to make a breaking change. i think breaking change decisions should be made based on total impact to the consumers of Microsoft.Data.SqlClient. ie SqlClient usage is an ecosystem, so decisions on braking changes should take that ecosystem into account

@SimonCropp
How would libs need to make a breaking change? I don't think we are thinking the same thing. My goal is not to have breaking changes for any existing users of Microsoft.Data.SqlClient. Libs referencing MDS would not have to change. MDS would have a dependency on MDS.Core. Only users who want the version without Azure support would need to change their dependency from MDS to MDS.Core.

Those few who object to the current long dependency tail can move to a new M.D.SqlClient.Core package, which just has the base functionality

to achieve that all libs using Microsoft.Data.SqlClient would need to make a breaking change. i think breaking change decisions should be made based on total impact to the consumers of Microsoft.Data.SqlClient. ie SqlClient usage is an ecosystem, so decisions on braking changes should take that ecosystem into account

@SimonCropp How would libs need to make a breaking change? I don't think we are thinking the same thing. My goal is not to have breaking changes for any existing users of Microsoft.Data.SqlClient. Libs referencing MDS would not have to change. MDS would have a dependency on MDS.Core. Only users who want the version without Azure support would need to change their dependency from MDS to MDS.Core.

Basically libs the once depended on the single package would be broken for a bit because they would need to then reference the "Core" package to then remove the azure bits, vs having all the core bits pushed in a new MAJOR version of the current package and split the azure bits to a separate version with .Azure appended to it's name. Either way those who depends on the SqlClient package will be broken anyways, except it limits the breakage to those who ACTUALLY want the azure bits.

Basically libs the once depended on the single package would be broken for a bit because they would need to then reference the "Core" package to then remove the azure bits, vs having all the core bits pushed in a new MAJOR version of the current package and split the azure bits to a separate version with .Azure appended to it's name. Either way those who depends on the SqlClient package will be broken anyways, except it limits the breakage to those who ACTUALLY want the azure bits.

This still isn't making sense to me. Why do we need to break anyone? In my scenario, those that currently depend on MDS (Azure or not) should require no change. MDS currently supports Azure and will continue to. The only ones that need to change should be those that really don't want Azure (the "feature" we are removing) because they want a slimmed down dependency tree.
Think of the existing MDS package as the "all in" package. For those who don't want everything, they can make changes.

As such I feel like from the start the azure bits should have been a separate opt-in .Azure package anyways much like how a lot of things in MSBuild and even the runtime (dotnet/runtime) has opt-in escape hatches put in place.

I'm not going to disagree with that. But it doesn't matter. We are here now and we aren't going to make a breaking change for Azure users (or any other users) that depend on MDS.

@David-Engel
lets take a specific example Microsoft.EntityFrameworkCore.SqlServer. IMO for them to move from Microsoft.Data.SqlClient to Microsoft.Data.SqlClient.Core, that would be a breaking change. and that change would need to be done in all similar libraries.
i think we should avoid that long tail of breaking changes. and just do on in this repo
also, to fully remove the azure bits, the fact that "change to different nuget" is significantly more works and more difficult o communicate to all consuming libs. when compared to "do a nuget update" which they are used to regularly doing
also the Microsoft.Data.SqlClient + Microsoft.Data.SqlClient.Azure approach means top level apps can remove the azure bits with only a single top level ref update.
where the Microsoft.Data.SqlClient + Microsoft.Data.SqlClient.Core approach requires all intermediate nugets to be updated to remove the azure bits

let me clarify that specific example

an project using azure references Microsoft.EntityFrameworkCore.SqlServer and not Microsoft.Data.SqlClient.
we do Microsoft.Data.SqlClient + Microsoft.Data.SqlClient.Core  in a "non breaking way"
to get the value out of "no azure bits" Microsoft.EntityFrameworkCore.SqlServer moves from Microsoft.Data.SqlClient to Microsoft.Data.SqlClient.Core
project updates Microsoft.EntityFrameworkCore.SqlServer
boom because no azure bits

now multiple over all the libs that extend Microsoft.Data.SqlClient. ie it might not break when they update Microsoft.EntityFrameworkCore.SqlServer. it might break when they update ErikEJ.SqlClient.Extensions, or  Serilog.Sinks.MSSqlServer, etc. but evernually they will update the last sql client lib that removes  Microsoft.Data.SqlClient (and hence azure) and their project will break

I think I see the disconnect. You are trying to make it easier for Azure to be an opt-in for everyone, including those who currently only have it via a transitive dependency. But you are proposing breaking Azure for everyone all the way down the line in order to do it.
So in your scenario, everyone (EF, for example) would only depend on/get non-Azure functionality (and all their Azure users would be broken). To get Azure authentication, apps (likely at the tail end unless libs like EF want to offer a ".Azure" variant) would simply need to add a dependency on the .Azure package.
I think you underestimate the disruption this would cause to existing Azure users. Given that Microsoft owns this library, uses it heavily internally (think about all the code that must be behind MS/Azure products and services), heavily promotes MDS in their docs (that's a lot of updating docs - if version >= 6, use M.D.S.Azure), and has an interest in keeping it simple and easy to use against Azure, I can't see how this change would be welcomed.

let me clarify that specific example
* an project using azure references Microsoft.EntityFrameworkCore.SqlServer and not Microsoft.Data.SqlClient.

* we do Microsoft.Data.SqlClient + Microsoft.Data.SqlClient.Core  in a "non breaking way"

* to get the value out of "no azure bits" Microsoft.EntityFrameworkCore.SqlServer moves from Microsoft.Data.SqlClient to Microsoft.Data.SqlClient.Core

* project updates Microsoft.EntityFrameworkCore.SqlServer

* boom because no azure bits

now multiply that over all the libs that extend Microsoft.Data.SqlClient. ie it might not break when they update Microsoft.EntityFrameworkCore.SqlServer. it might break when they update ErikEJ.SqlClient.Extensions, or Serilog.Sinks.MSSqlServer, etc. but evernually they will update the last sql client lib that removes Microsoft.Data.SqlClient (and hence azure) and their project will break

Or do like the Microsoft.Extensions.DependencyInjection approach and allow someone to register the azure bits if they want them, as a service.

@AraHaan

Or do like the Microsoft.Extensions.DependencyInjection approach and allow someone to register the azure bits if they want them, as a service. After all Azure is in a nutshell a service after all.

r u proposing only a runtime api level change ?
if so, this cant be only a run time change. we already have one significant bug cause by sqlclient nuget pulling in azure refs AzureAD/microsoft-authentication-library-for-dotnet#4468 i know because it broke our integration environment
it has to be nuget change

@AraHaan

Or do like the Microsoft.Extensions.DependencyInjection approach and allow someone to register the azure bits if they want them, as a service. After all Azure is in a nutshell a service after all.

r u proposing only a runtime api level change ?
if so, this cant be only a run time change. we already have one significant bug cause by sqlclient nuget pulling in azure refs AzureAD/microsoft-authentication-library-for-dotnet#4468 i know because it broke our integration environment
it has to be nuget change

Basically yes, have the azure bits after they install the azure version of the library (which has a dependency on the base version) which:

must be explicitly initialized by the application to "register it" as a "service" for the base version to obtain and use.

@AraHaan

Basically yes, have the azure bits after they install the azure version of the library (which has a dependency on the base version) which:    must be explicitly initialized by the application to "register it" as a "service" for the base version to obtain and use.

ahh. yes. thats what i want

if we do go with the Microsoft.Data.SqlClient + Microsoft.Data.SqlClient.Core approach. the doco will be a fun read for everyone moving forward

use Microsoft.Data.SqlClient if you are targeting Azure. otherwise use Microsoft.Data.SqlClient.Core

and that when people even bother to read and understand that doco. because the entire internet history of blogposts, stackoverflow, and training will continue to be pointing to "Microsoft.Data.SqlClient is the one you want"
IMO the technical debt and significant number of people who will continue to pick the incorrect package should be reason enough to rule out that approach

@David-Engel

I think you underestimate the disruption this would cause to existing Azure users.

I dont think i do. We release a new major of Microsoft.Data.SqlClient . and in the release notes we include "azure users please add a ref to this other nuget and add a single line to your app startup". i think that is a very small disruption in the scheme of breaking changes

Given that Microsoft owns this library, uses it heavily internally (think about all the code that must be behind MS/Azure products and services), heavily promotes MDS in their docs (that's a lot of updating docs - if version >= 6, use M.D.S.Azure), and has an interest in keeping it simple and easy to use against Azure, I can't see how this change would be welcomed.

to me that reads like "azure consumer trump the needs of the larger community". in my mind this is not a "Microsoft owned library" but a "community OSS library with MS as the curator". at no point should the impact on the larger community (who have helped maintain this library over the years) be disregarded for the need of the Azure consumer

Another consideration: how fast can I get rid of Azure bits? With .Azure approach, I can reference the latest MDS and all the Azure related .DLLs are gone from the publish directory. With .Core approach, the timing of losing azure bits depends on if and when a library like Microsoft.EntityFrameworkCore.SqlServer decides to migrate to .Core variation. That could take years.
Otherwise I agree with all @SimonCropp's points. There is no way of avoiding a breaking change with both approaches. When I do dotnet outdated and see a major version update I expect a breaking change and if one doesn't occur, I consider it a bonus.

I think you underestimate the disruption this would cause to existing Azure users. Given that Microsoft owns this library

With .Azure option a user adds an extra package reference is one of the simplest to deal with. Not ideal, but straightforward.
Compare this to a list of breaking changes for a typical major EF Core release, also owned by Microsoft. EF Core 3.1 took me days to resolve. With the recent EF Core 8 the recommendation was to switch to daily builds.

Thanks for the interesting discussion, everyone. I think it is obviuos that if this is going to happen (and a PR is going to be accepted),the only way to do this is via MDS.Core. There is a too long history of just having Azure auth available.
Yes, it will take years for consumers to adapt to this, and some may not. So be it.
Base functionality in .Core will be SQL auth, integrated Windows auth, and token auth (AccessToken, AccessTokenCallback).
I will close this draft, and maybe revisit af 5.2 has been released, as next planned version seems to be 6.0 now.

I think it is obvious that if this is going to happen, the only way to do this is via MDS.Core.

Why?
As you said in a previous comment, attempts to use Azure auth with Microsoft.Data.SqlClient should result in an actionable error message with links to a suitable docs page.
Wouldn't that be the best solution?
I remember that Microsoft.Data.SqlClient version 4 was released with Encrypt=true by default and this really caused havoc. It had a good error message:

A connection was successfully established with the server, but then an error occurred during the login process. (provider: SSL Provider, error: 0 - The certificate chain was issued by an authority that is not trusted.)

But it did not have a actionable error message.
For this breaking change, having the error message mentions that adding a package reference to Microsoft.Data.SqlClient.Azure will solve the issue would be the smoothest path forward and the easiest for all the libraries depending on Microsoft.Data.SqlClient package.

Why?

Because any change needs to be approved by the responsible maintainers of this repo...

@ErikEJ so all the maintainers have chimed in?

Why?

Because any change needs to be approved by the responsible maintainers of this repo…

The why was about the only way to do this is via MDS.Core
Only @David-Engel has argued about this route, all other participants in this thread are arguing towards Microsoft.Data.SqlClient + Microsoft.Data.SqlClient.Azure. And also the 49 upvotes on https://github.com/dotnet/SqlClient/issues/1108#issuecomment-861119074
But David is the lead for SQL Server drivers so I don't have high expectations on the weight of random internet people arguments. ¯\_(ツ)_/¯

A few notes/thoughts/summary from me...

I don't have the latest figures, but IIRC a very significant number of usages of SqlClient comes through EF Core.
If we go with the SqlClient+SqlClient.Core, EF must react to the change for it to affect its users; otherwise Microsoft.EntityFramework.SqlServer continues to reference SqlClient, and there's no way to opt out of the Azure dependencies while using EF. So at this point there are two options:

Do the same at the EF level and introduce a new M.EF.SqlServer.Core, for users who don't want Azure dependencies. This means that library dependencies on top of SqlClient - EF isn't the only one - all need to bifurcate and take on added maintenance/communication burden (we'd need to explain to our users what the difference between the package is etc.). I'd really like to avoid this.
Switch M.EF.SqlServer to depend on the new SqlClient.Core package; users who want Azure also add SqlClient.Azure as described above. If this happens, EF Azure users are broken in the exact same way as going the other way in SqlClient and introducing SqlClient.Azure instead (as @SimonCropp argued above). In other words, the breaking change has just been pushed up.

In other words, I'd argue that a more holistic view of the ecosystem is needed here; if SqlClient were a single library used directly, that would lead to a different set of considerations than the current one, where SqlClient is more of an underlying library typically consumed via other 3rd-party layers (such as EF). Either you ask all layers to make a change as well, or the breakage is pushed onto them.
Another pretty obvious point but worth saying - with SqlClient.Core we end up in a place where package naming is simply misleading; SqlClient.Azure clearly expresses what that package is about (adding Azure-specific stuff), but just having SqlClient+SqlClient.Core makes it non-obvious for users to choose the right option.
Thinking ahead a bit, introducing SqlClient.Core blocks that name to mean "SqlClient but without Azure", forever; if we need to do a similar exercise at some point, the name is already taken. I specifically have NativeAOT in mind; if SqlClient has any functionaliy by default that's incompatible with NativeAOT, introducing a SqlClient.Core is one main way to deal with that (this has happened in other places in the ecosystem). But if SqlClient.Core is already used to mean "but without Azure", we can't do that.
Finally, I agree with above arguments that although this a breaking change, it's the "best kind" of breaking change - it's discoverable immediately (not e.g. a subtle behavioral change discovered only after moving to production), and we hopefully can include an informative exception pointing to the exact mitigation ("install SqlClient.Azure"). We have some experience with introducing such changes in EF, and if done right, the actual impact and user dissatisfaction has been minimal.

Thanks for joining, @roji - your opinion is valuable to me. So your are in favor of my proposal above ❤
Let's stand down, try to not get too emotional and think about this one more time...
I will share my proposal and collect more feedback

while i am grateful that this is be re-considered. it is annoying that it only takes 1 MS employee to re-iterate, what several  community members have already stated, to be re-considered
there is a noticeable bias on .net OSS project to give priority to who says something over what is being said.
if a community member had made exactly the same comment as @roji would we have had the same outcome?

@AraHaan > add: Microsoft.Extensions.DependencyInjection.Abstractions
That will add a new trail of dependencies for .NET Framework, so...

@AraHaan > add: Microsoft.Extensions.DependencyInjection.Abstractions
That will add a new trail of dependencies for .NET Framework, so...

But won't it be ok for .NET Framework though, even if it is used as an implementation detail internally?

This is great although it will be a breaking change for me. Thanks for pointing this out

@AraHaan Making this change and adding new dependencies does not seem right

Everyone, just to be clear - I work at Microsoft but I don't make any decisions where SqlClient is concerned. @David-Engel is the owner here and has the final say, and I know he has SqlClient's best interests in mind, as well as the best knowledge about who uses SqlClient, how, and what breaking changes make sense in that context. Although I have my opinion, I fully trust @David-Engel will make the right choice here etc.
@dustinmoris your comment really does not reflect the reality of the situation; there's no "corporate politics" or an employee show-down with clout. There really are just two Microsoft here engineers, discussing what to do the best for SqlClient and for the .NET ecosystem as a whole. We regularly engage with the community on important design decisions, and very frequently change our minds based on community feedback that we get. It's very common for people on the outside to assume "corporate politics" and various dark "behind the scenes" dealings at Microsoft - I deal with this all the time - but we're really just a bunch of passionate engineers discussing and trying to arrive at the best outcome given the situation.
So again, I'm just voicing my opinion here, with the added weight that I have the EF perspective (and EF is an important factor, being a major way that SqlClient is used).
@AraHaan for the record, I'm against the direction of introducing DI into SqlClient. Unlike EF, SqlClient (and other ADO.NET providers) aren't currently based on DI concepts, and rewriting SqlClient to start using DI internally is a far-reaching change that doesn't really seem related to this discussion in any way. I do agree that better integration with DI is a good idea, but I'd do that in a separate package (much like how Npgsql has Npgsql.DependencyInjection for people who want it). Enabling Azure functionality via an external package (regardless of how we call it) is most probably doable without introducing DI.

Published payload with .NET 8 target:

Make this change, increment the version to 6.0, and break it.
Why would anyone running on-prem SQL Server want all of the Azure bloat in their apps?
It's super annoying that the SqlClient dragged in all these dependencies, and honestly the Microsoft team should have thought of this at the beginning.
This is a great solution. Break it, fix it, move on.

Thanks for all the input folks. I've just been stating my opinion based on my own experiences. It's good to hear different opinions. I'm not against having my mind changed. After reading all the comments, I'm inclined to agree that MDS + MDS.Azure seems to make more sense. (Implementation details TBD.) I'll have to discuss this with other internal stakeholders to see what their thoughts are. I don't want to make people do a bunch of work that won't ever be merged.

@David-Engel thanks so much for re-considering

Anything new about this yet? It has been a few months since the last comment on this.

Closing PR in favor of https://github.com/dotnet/SqlClient/pull/2247#issuecomment-1934709067 - as it will require rework and new PR would be ideal here. We've picked up the work for upcoming milestones, so it will be worked upon by our team.

@cheenamalhotra mind doing an issue for this and a feature branch so people who are interested can keep track with the progress and potentially submit PR's to help land a hand if needed?

@cheenamalhotra , I'll second @AraHaan's request. Please post this here so we know which issue to watch. Can you also confirm that this will be delivered with .NET 10? For us, this is an extremly important issue because System.Data.SqlClient is no longer officially supported on .NET 10 and Microsoft.Data.SqlClient in its current shape is a significant problem due to the current dependency tree.

I would recommend delaying the System.Data.SqlClient with not being supported in .NET 10 until it is proven that Microsoft.Data.SqlClient can do this for .NET 10 before it's release so it does not break people who have STRICT security standards on dependencies.

Would recommend tracking the same issue https://github.com/dotnet/SqlClient/issues/1108


[tool_crash] FileSystemException: Cannot open file, OS Error: The system cannot find the file specified., errno = 2

Command
flutter create responsive --overwrite

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot open file, OS Error: The system cannot find the file specified.
, errno = 2
#0      _File.throwIfError (dart:io/file_impl.dart:635:7)
#1      _File.openSync (dart:io/file_impl.dart:479:5)
#2      _File.readAsBytesSync (dart:io/file_impl.dart:539:18)
#3      _File.readAsStringSync (dart:io/file_impl.dart:584:18)
#4      ForwardingFile.readAsStringSync (package:file/src/forwarding/forwarding_file.dart:96:16)
#5      ErrorHandlingFile.readAsStringSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:222:22)
#6      _runSync (package:flutter_tools/src/base/error_handling_io.dart:597:14)
#7      ErrorHandlingFile.readAsStringSync (package:flutter_tools/src/base/error_handling_io.dart:221:12)
#8      CreateBase._computeTemplateManifest (package:flutter_tools/src/commands/create_base.dart:613:37)
#9      CreateBase._templateManifest (package:flutter_tools/src/commands/create_base.dart:599:30)
#10     CreateBase.renderMerged (package:flutter_tools/src/commands/create_base.dart:456:25)
#11     CreateBase.generateApp (package:flutter_tools/src/commands/create_base.dart:479:29)
#12     CreateCommand.runCommand (package:flutter_tools/src/commands/create.dart:295:37)
<asynchronous suspension>
#13     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1161:27)
<asynchronous suspension>
#14     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#15     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
#16     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
<asynchronous suspension>
#17     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#18     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)

[✓] Flutter (Channel stable, 2.10.4-0.0.pre.1, on Microsoft Windows [Version 10.0.19044.1526], locale en-US)
    • Flutter version 2.10.4-0.0.pre.1 at C:\Users\bellb\Desktop\Flutter
    • Upstream repository https://github.com/ChawalitL/flutter.git
    • Framework revision 1802f5b539 (13 days ago), 2022-03-11 23:18:40  0700
    • Engine revision bd539267b4
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at C:\Users\bellb\AppData\Local\Android\Sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • ANDROID_SDK_ROOT = C:\Users\bellb\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.11 9-b60-7590822)
    • All Android licenses accepted.

[✗] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Visual Studio - develop for Windows (Visual Studio Community 2022 17.1.2)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.1.32319.34
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 2021.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11 9-b60-7590822)

[✓] VS Code (version 1.65.2)
    • VS Code at C:\Users\bellb\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.36.0

[✓] Connected device (2 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19044.1526]
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 99.0.1150.46

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Flutter Application Metadata
No pubspec in working directory.

Duplicate of #65242

i remove flutter and setup agian than set path
now it work
thank you guy


Make browser loading faster

This is temporary just to fix a problem I've been annoyed by for a year or two now. At some point in the future, I want to actually recode the entire file browser. I just don't have the time for that right now.

Change names to remove dashes
Add FOLDER:Clear() and FOLDER:LoadDataFolder(folderPath) to replace PurgeFiles
Make loading folder/file nodes non-blocking

I have not confirmed 100% if this works for Advdupe 1 or the Public folders.

You're adding each file to the tree one per think now? I really don't see how this makes loading faster.

Forgot about this too. Still not a fan of the think hook, but whatever


Convert to TypeScript

This is a Hacktoberfest task!
You can read more about Hacktoberfest on our blog and see all tasks on our Hacktoberfest Project Board.
Summary
This library is currently plain JS, but we'd love it to be TypeScript
Details
We just went through the exercise of converting postgrest-js and gotrue-js to TypeScript. This involves:

Moving the build process over to the TypeScript compiler
Adding types to all of the classes and methods
[Optional] Migrating the tests over to Jest.

Can I work on this?

Definitely @abraaoduarte - let me know if you need help

Ok, thanks.
I will open a PR for each file that I manage to pass to Typescript so I don't have too much to review at once.

Hey @abraaoduarte checking in on this. How is everything going? I will be releasing another version of supabase-js soon and I'm planning to add the Typescript changes here. If you haven't started this already, let me know and I will pick it up 👍

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore: Generate changelog for 0.3.0 release

Which issue does this PR close?

N/A
Rationale for this change

Preparing for next release
What changes are included in this PR?

How are these changes tested?

Looks good.


mochaHooks not detected if the base export is a function

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[x] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description
// hooks.js
module.exports = () => {}; // mochaHooks not detected with this line present

module.exports.mochaHooks = {
    afterEach: () => console.log(1),
};

This seems like something that should work and probably just needs an updated typeof check somewhere. Use-case is a plugin that needs to register a hook but also exports some functions for the user.
Versions

The output of mocha --version and node_modules/.bin/mocha --version: 9.2.2
The output of node --version:  v16.6.2

@MartinKolarik
module.exports references per default an Object, which is returned when requiring a module.
With your module.exports = () => {}; you have overwritten module.exports from type Object to Function.
[Function (anonymous)] {
  mochaHooks: { afterEach: [Function: afterEach] }
}

Mocha isn't searching for a property named mochaHooks on a Function, neither in an Array nor a Map etc. It expects an Object with a property mochaHooks and is also documented that way:  exports.mochaHooks = { ... }.

@juergba thanks for a quick response. Yes, by default exports is an object and this changes it to a function but that's a fairly common pattern in node to provide a default export as well as some named exports. Functions in JS are basically callable objects, so this shouldn't cause any issues. Also, Array, Map and almost everything else is just an object in JS, so all of them do work, as you can check:
module.exports = new Map();

module.exports.mochaHooks = {
    afterEach: () => console.log(1), // works because typeof new Map() === 'object'
};

module.exports = new Map();
module.exports.mochaHooks = {
afterEach: () => console.log(1), // works because typeof new Map() === 'object'
};

This is still relevant.


Subtitles not showing in fullscreen

When I switch to fullscreen mode, the subtitles disappear (tested on Chrome 109.0.5414.121 (Official Build) (64-bit) and Firefox 109.0.1 (64-bit) on Windows 10).

Yeah, this is an issue with how animebook uses the default video player the browser provides. You can get around this by hitting F11 to enter fullscreen mode with your browser instead (you'll also get the sidebar this way, which is nice).

Oh perfect, thank you. That works great!
Apologies if this had been asked and answered before.


eth phunk 1457

punk 1457 has error to purchase says will fail"

You shouldn't have a buy button for this. I only see 'Place Bid' because it is not for sale. Do you have a Buy button?

Seems to be reslved


Build native UI testing support for macOS plugins

file_selector shows native UI, so automated testing for it will require building out native UI test support for macOS in integration_test. We will almost certainly want to use XCUITest for this, as on iOS.

Currently blocked on https://github.com/flutter/flutter/issues/90673.

@matanlurey I know macOS isn't in scope for https://github.com/orgs/flutter/projects/181 but FYI in case you want to track it somewhere.


refactor: simplified convertDecklistToDeck functionality

@crookedneighbor Figured out running individual tests and got a chance to look at the regex.

Thanks for this, I updated the comment to describe what each piece of the regex is doing. It is very verbose, but future maintainers of that regex will want a breakdown of the logic, I think: https://github.com/Commander-Spellbook/website-v2/pull/326/commits/c8bcf0a6084051db05e56942f6b5b60fa01839ef


Remove duplicated execCommand() functions and use util.ExecCommand()

Describe what this PR does
Both cephFS and RBD components have their own execCommand() with slightly different semantics. There is also a util.ExecCommand() that is used a few times too.
In order to clean things up, remove the cephfs.execCommand() and rbd.execCommand() functions, and replace the calls with util.ExecCommand().

@mergifyio rebase

Rebased, @Madhu-1 please review again. just fixed one minor conflict in internal/cephfs/volume.go where JoinErrors() is used.

@nixpanic need rebase

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? pray

Rebased, so reviews are needed again :roll_eyes:


[AVOCADO-220] Add allelic fraction hard filter.

Resolves #220.

Coverage increased (+0.2%) to 84.055% when pulling 169b62c70d4bcf3252c61496f1bba792be869e9c on fnothaft:issues/220-ad-filter into eee80c8c8f60131aa7577804de6ee94987046eda on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/avocado-prb/176/
Test PASSed.


Contributing to this project

hi @armcha , I would love to contribute to this project as a way to improve my android skills. Is there anything I can help with?

same question

There is a TODO list on the README.

@gabrieloshiro I've seen the todo list but he/she could already be working on any of those tasks. We don't want to duplicate work.
One way to proceed could be to create new issues for the things he/she needs help with and the task can be assigned to one person.

Hi, thank you for interest. I don't work on any task specified in TODO list, so you can start whichever you'd like, for example, add/remove favorite would be preferable.

@armcha Duly noted. I will work on the ability to add and remove favorites. I have created an issue for the task, please assign it to me.


Usage of API

Hello
I try to do facial recognition with this example
https://github.com/takuya-takeuchi/FaceRecognitionDotNet/wiki/Quickstart#1-initialize
but I get an error when compiling in visual studio
Argument 2: cannot be converted from 'FaceRecognitionDotNet.Location' a 'System.Collections.Generic.IEnumerable<FaceRecognitionDotNet.Location>'
in this line
IEnumerable encodingA = FaceRecognition.FaceEncodings(imageA, locationsA.First());
I am missing some nuget package
Originally posted by @Gaara1996 in https://github.com/takuya-takeuchi/FaceRecognitionDotNet/issues/187#issuecomment-1016837295

You can do
IEnumerable encodingA = FaceRecognition.FaceEncodings(imageA, new [] { locationsA });

OK, Wiki is wrong.
I revised it.
Thanks. :)

Thanks for the help in the end I left it this way
IEnumerable encodingB = fr.FaceEncodings(imageB).ToArray();
and it worked =)


Support #![crate_type = "proc-macro"]

Warning
This doesn't work until after #825 has been merged.

Could you link me the code you ran there so I could add it to the test suite?

https://gist.github.com/rust-play/23b7c1923796dce51412f4b5e54852c7

When I remove the #[test], I see

warning: library playground should only specify proc-macro = true instead of setting crate-type

Is that worrisome?

I do not get that. Are you sure you are running against a container that contains the modify-cargo-toml change from this PR?
Full output with #[test]:
Standard Error

   Compiling playground v0.0.1 (/playground)
    Finished test [unoptimized + debuginfo] target(s) in 0.69s
     Running unittests src/lib.rs (target/debug/deps/playground-cc6c5b427caf9369)
   Doc-tests playground
error: test failed, to rerun pass '--doc'

Standard Output

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

running 1 test
test src/lib.rs - demo (line 6) ... FAILED

failures:

---- src/lib.rs - demo (line 6) stdout ----
wow wow
error[E0412]: cannot find type `aaa` in this scope
 --> src/lib.rs:8:10
  |
4 | playground::demo!();
  | ------------------- similarly named struct `Aaa` defined here
5 | type T = aaa;
  |          ^^^ help: a struct with a similar name exists: `Aaa`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0412`.
Couldn't compile the test.

failures:
    src/lib.rs - demo (line 6)

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.24s

Full output without #[test]:
Standard Error

   Compiling playground v0.0.1 (/playground)
    Finished dev [unoptimized + debuginfo] target(s) in 0.58s

Standard Output

Warnings

No main function was detected, so your code was compiled
but not run. If you’d like to execute your code, please
add a main function.

I did rebuild the containers, but I'll double check that during my next attempt.
I am getting the (expected?) output:
---- src/lib.rs - demo (line 6) stdout ----
wow wow
error[E0412]: cannot find type `aaa` in this scope
 --> src/lib.rs:8:10
  |
4 | playground::demo!();
  | ------------------- similarly named struct `Aaa` defined here
5 | type T = aaa;
  |          ^^^ help: a struct with a similar name exists: `Aaa`

Is a doc test the only way to exercise the proc macro with the current playground setup?
If so, we might want to add a follow-up issue to try and regex for /// ```-like lines and enable test mode for that.
I suppose somehow supporting multiple crates would be another solution...

Is a doc test the only way to exercise the proc macro with the current playground setup?

That's right. An ordinary #[test] unit test will compile and run as well, but does not depend on the proc macro, so it can't use the macro as a macro, unlike an integration test or doc test. At best it can test helper functions inside of the implementation.


ReportLatencyResultsCallback callback implementation

hi,
 I am working on MLperf submission for a SW+HW solution, my benchmark implementation is C++ based.
I am trying to figure out how to implement the following callback: ReportLatencyResultsCallback.
From the name I deduced it is been called by loadgen to retrieve the timing data for all samples of the query sent to the SUT.  But form the callback function signature it seems that it is not the case (const int64_t *), can I get clarification
for this function usage and implementation. The Python reference example is not using this callback at all, so if there is a C++ benchmark implementation that would be excellent.
,Thanks
Reuven

Hello!
I also have a related question. I am trying to run predictions by overriding mlperf :: SystemUnderTest.IssueQuery (const std :: vector <mlperf :: QuerySample> & samples) and  QuerySampleLibrary.LoadSamplesToRam( const std::vector<mlperf::QuerySampleIndex>& samples) . However, I do not understand how the indices I get in LoadSamplesToRam () relate to the indices used in the QuerySample structure? I am not sure about the Accuracy mode, but in Performance mode one "sample" can be used for prediction multiple times

Hi Reuven, bellycat.
Regarding ReportLatencyResultsCallback: That is an optional hook that enables a client to process the raw latencies recorded by the loadgen. It is not necessary to implement it since the loadgen log files will include a summary of the latencies.
Regarding QuerySampleIndex: The index in the the QuerySample struct should be the same value that was in the LoadSamplesToRam call; i.e. it is not an index into the |samples| vector argument of LoadSamplesToRam.

Hi Brian,
thanks for answering the question, i would like to better understand the mechanism behind time measurement applied loadgen, when and how does time measurement being executed and logged?  is this responsibility of my IssueQuery  callback implementation, i tried to follow the path set by the Python reference example but it seems to be a bit misleading.
in the python code it seems that the measurements start at the beginning of run_one_item() after generating a new item, and stopped after the post_process but i failed to understand how it is been recorded by loadgen.
Thanks,
Reuven

The reference python code has timing code of its own, but that will not be used for submissions. The official stats are tracked within the loadgen internally.
The end timestamp of every sample is taken here:
https://github.com/mlperf/inference/blob/939d5f91df8eb642ab0e530ee0289eb332a1db6c/loadgen/loadgen.cc#L155
That timestamp is submitted to the logging thread, which aggregates the results from all the threads calling QuerySamplesComplete. The latency is recorded on the logging thread here: https://github.com/mlperf/inference/blob/939d5f91df8eb642ab0e530ee0289eb332a1db6c/loadgen/loadgen.cc#L235
At the end of the test, PerformanceSummary::Log takes the latencies (and other timestamps) and calculates metrics applicable to the requested scenario:
https://github.com/mlperf/inference/blob/939d5f91df8eb642ab0e530ee0289eb332a1db6c/loadgen/loadgen.cc#L804

Hi Brian,
thanks for clarifying this point, i would like to check with you two more issues i faced during implementation:

in multi stream and offline scenarios i can process all samples delivered during the call IssueQurey callback, lets assume i get 8 samples, i can process this using one thread in a single calculation of my HW  and report the results in one call of  QuerySamplesComplete, how time measurement is calculated for such batch size processing (all calculation are completed within the same time instance)?

are the good results counter and total result counter as calculate by the python version is needed in the c++ implementation or loadgen calculates this internally.
thanks,
Reuven

@dilipajm check this

Hi Brian,
thanks for clarifying this point, i would like to check with you two more issues i faced during implementation:

in multi stream and offline scenarios i can process all samples delivered during the call IssueQurey callback, lets assume i get 8 samples, i can process this using one thread in a single calculation of my HW  and report the results in one call of  QuerySamplesComplete, how time measurement is calculated for such batch size processing (all calculation are completed within the same time instance)?

If multi_stream_samples_per_query is 8, all samples will have the same start and end timestamps.

are the good results counter and total result counter as calculate by the python version is needed in the c++ implementation or loadgen calculates this internally.

The loadgen calculates everything it needs for performance metrics internally.

thanks,
Reuven


URP 14 shadow atten only return white

I'm using Unity 2022.3.13f1, URP 14,
I don't know what's up but shadow atten is just white...

Shader Graph doesn't seem to collect keywords from nested subgraphs, so if you're using the Main Light Shadows node in a subgraph that might be why. You can manually add the keywords to the Blackboard :

For shadows to work in the Unlit Graph, the following keywords must be defined in the blackboard :

Enum Keyword, Global Multi-Compile "_MAIN_LIGHT", with entries :

"SHADOWS"
"SHADOWS_CASCADE"
"SHADOWS_SCREEN"

Boolean Keyword, Global Multi-Compile "_SHADOWS_SOFT"

thank you, sorry for your time, this is a wrong call. I don't know why my graph has receive shadow set to off. it's ok now.


Vehicle's type classification (car,bus,truck ...)

Which model is better for vehicle's type classification ? THX

Hi, you can try the vehicle_attribute_recognition model, the types of vehicles that can be recognized are "sedan", "suv", "van", "hatchback", "mpv", "pickup", "bus","truck", " estate", you can refer to here for related instructions


Update services.yaml

Add 4EVERLAND to services provider.
What kind of PR is this?
Select only one to speed up review/approval; i.e., don't lump an addition and a removal into a single PR.

[x] Adding something new to awesome-ipfs
[ ] Editing something already listed on awesome-ipfs
[ ] Removing something from awesome-ipfs
[ ] Something else (if so, please explain in the "Additional details" section below)

Pre-submit checklist
Please confirm ALL of the following before submitting your PR.

[ ] This PR includes only one addition, removal, or edit.
[x] I edited the /data directory instead of the README.md.
[ ] I reviewed the content policy and the and the IPFS Community Code of Conduct to ensure my submission meets the requirements.
[ ] I have followed the CONTRIBUTING.md guidelines.

Additional details
Is there anything else we should know about this PR?

For new additions: What is your project's current size/reach?

For new additions: What is your project's potential size/reach?

For new additions: How critical is IPFS to your project?

[ ] Essential
[ ] Somewhat critical
[ ] Useful, but not critical

For new additions: What core goal(s) does your project address?

[ ] Big-data solutions
[ ] Freedom from corporate/government interference
[ ] Data integrity
[ ] Dev tools or other ways to enable developers
[ ] Disaster resilience/recovery
[ ] File storage/retrieval
[ ] File streaming
[ ] Permanent archiving
[ ] Self-sovereign identity
[ ] Platforms that utilize consensus, reputation, or incentivization
[ ] Other (please list)

Is anything about IPFS blocking your project?

I am closing this PR as the repo has a new structure, and your project has been added.


ControlNet not recognized by infer

https://arca.live/b/aiart/77022872

original post deleted
fkkk
Parameter name was "ControlNet"


Avoid qiskit-1.3

Looks like something changed in Qiskit v1.3 that breaks our interop. Pinning to 1.2 while we investigate.

@swernli think you could file an issue so we don't get distracted and forget?


Add statistics for each level

(Possibly on the way to a layout engine) I want number of nodes at each level and the number of distinct values at each level.
Possible syntax:
stats html
and
stats text
and
stats markdown - though here the support for tables in Markdown is a little murky so would impose my own taste.
Will create a stats branch to work on this.

Maybe also stats csv.

I do not understand the usecase.  What would you do with this information?

So I could easily say "45 CICS regions attaching to 8 db2 subsystems on 5 systems" - as 45 level 2, 8 level 1, 5 level 0 nodes.
Also counting nodes at each level makes it possible to layout - in SVG or HTML5 Canvas - with the maximum level node count (in this example 45) conditioning the spacing. Naïve layout but something for those who don't have eg iThoughts. BTW the HTML export sort of does this - but clunkily.

CSV done. And the difficult part is collating the statistics.

My sense would be that it should be done by traversing the tree.

It's done. :-) And now so is HTML table output. Hopefully will pass the test this time - tabs versus spaces.

Markdown Tables done. (According to Marked 2 this is the right syntax.)

Likewise text output. Will now do README.md and then merge.

I just submitted a minor change to README.md

Ah. I wonder what that did to my attempt to merge your pull request.