Using Keccak-P1600 Rho constant in Keccak-P800

https://github.com/kste/sphincs/blob/ee5af8e9cffecb33f3eecd0908b86c673ced3f63/x86/crypto_sign/sphincs256keccak/avx2/KeccakP-800-times8-SIMD256.c#L177
There exists some errors in this file. The rho offset for Keccak-P800 should module 32 which means all the constants should smaller than 32. But I found that in https://github.com/kste/sphincs/blob/ee5af8e9cffecb33f3eecd0908b86c673ced3f63/x86/crypto_sign/sphincs256keccak/avx2/KeccakP-800-times8-SIMD256.c, some of the constants are larger than 31. Also, I look at the Keccak-P1600 implementation and find out that its constants are being used in Keccak-P800.
The above implementation error leads to the fail verification of SPHINCS when instantiate with Keccak-P800 (I tested it myself).

Thank you for reporting this!
The ROL32in256() macro includes the necessary % operation for getting the correct constants, but I agree it would be better to just directly use the correct ones.
The round constants should match https://github.com/gvanas/KeccakCodePackage/blob/master/SnP/KeccakP-800/Optimized32/KeccakP-800-opt32.c , so the issue might be somewhere else.

Alright, do you have any plan to fix or test this?

I will have a look at it as soon as I find time!


CB-3005 Zeppelin Notebook For S3

Zeppelin does not require any S3 Specific initialization now  and uses the default zeppelin.notebook.dir since CDPD-2933 is resolved
Closes #CB-3005

thanks @smaniraju


[Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
hi
the jenkins scope selector fails when at least 1 job in the whole list contains '/' character. It tries to call jenkins API with non encoded job name which leads to a 404 error (see screen). This makes jenkins scope selection impossible:

if i may suggest, var "repoId" should be URL encoded here as job name may contain "either reserved or potentially unsafe when used in URLs"  : https://github.com/apache/incubator-devlake/blob/d708a808c5808be330998c8bbdaf1e02b8d004d8/config-ui/src/plugins/components/data-scope/api.ts#L22
What do you expect to happen

URL specific chars should be encoded when repoId is used as a path parameter
call to jenkins API should success for each existing job (or at least failure should not be a blocker to add other jobs in scope)

How to reproduce

link devlake with a jenkins instance containing a job named "test/myjob"
try to add scope from this jenkins in a new blueprint

Anything else
No response
Version
v0.15.0
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Decoding path parameters is not a good idea, I think putting repoId in query string is a good way to solve this issue.
This will break the compatibility of API.
As for the failure blocks following action, It shouldn't happen, because it's just a 404 error. Can you offer more information about  it?

hi,
thanks for this reply. Indeed letting you fully the choice of how to handle this case of handling URL specific chars in jenkins jobs names.
If this could help, here a recording showing : the 404 errors for job names containing "/" char + no selected scope whereas selection has been made and a message confirmed that changes were successfully saved.

Thanks

hi, thanks for this reply. Indeed letting you fully the choice of how to handle this case of handling URL specific chars in jenkins jobs names. If this could help, here a recording showing : the 404 errors for job names containing "/" char + no selected scope whereas selection has been made and a message confirmed that changes were successfully saved.

Thanks

The success message is really confusing. It looks like  this message doesn't  depend on API's success(or any other) response, just a wrong state transformation.

I can help to fix the backend API, but we'd better get some advice from the core maintain team.

@aubertaa we tried to reproduce the problem and ran into a problem, seems like the jenkins would allow us to do so:

What is your jenkins version and how did you create that specific scope?

you may create "multibranch pipeline" and create a new branch named with a "/" in your git repository.
Then scan your branches from jenkins, it will create a job named like the branch.
Regards,

Hi, @aubertaa , thanks for the quick response, we might have to solve the problem later due to limited bandwidth.


Going on boat with controller feels very rough

https://github.com/Wilyicaro/Legacy-Minecraft/assets/39068731/6e8e7430-3a07-481a-8028-3a356e5d61ed

It was like this in the original console edition. I do agree that it should be changed.

It was like this in the original console edition. I do agree that it should be optionally changed.

Nah It's the fact that when you hold forward it turns for some reason

Fixed in version 1.5, thanks for reporting.


[Refactor] Breakup CorruptCoreConnector.OnMessageReceived into helper functions

OnMessageReceived is a massive message handling function. I've broken up most of the individual actions taken by each of the switches with helper functions.

Thanks for going through the effort to break up this behemoth. We've actually been discussing completely reworking the way the netcore receivers work to use an attribute based method where we either codegen the switch, or use a dictionary of function references that's built based on attributes. This is an important first step to that one. We're still fleshing out implementation details, but in all likelyhood it'll be something like
    [Command("SHOW_TOOL", RTCSide.Client)]
    public static void ShowWindow()
    {
        S.FormExecute(() =>
        {
            var form = S.GetOrInitialize<Form1>();
            form.Activate();
            form.Show();
        });
    }```


Right clicking Lute while equipped on Bard takes up extra spaces in inventory

This problem is not happening anymore. Could you double check it before close this issue? Just to be sure

Can also confirm this isn't happening on the demo instance, right clicked it back and forth multiple times to make sure.

Can't reproduce anymore, not sure what commit fixed it but oh well, closing.


[BUG] incorrect query in TDVT BUGS.B27875-asc-nulls-first

Describe the bug
TDVT test case BUGS.B27875-asc-nulls-first failed on Trino test because TDVT sent the following query:
SELECT "Calcs"."key" AS "key",   SUM("Calcs"."num2") AS "sum_num2_ok" FROM "public"."calcs" "Calcs" GROUP BY "Calcs"."key" ORDER BY "sum_num2_ok" ASC LIMIT 10

To get the actual match expected, NULLS FIRST is required in the order by element:
SELECT "Calcs"."key" AS "key",   SUM("Calcs"."num2") AS "sum_num2_ok" FROM "public"."calcs" "Calcs" GROUP BY "Calcs"."key" ORDER BY "sum_num2_ok" ASC NULLS FIRST LIMIT 10;

Screenshots
Got error in ..._diff.xml.
Tuples - D:\dev\data-dev\tableau-tests\tdvt\logicaltests/calcs\setup.BUGS.B27875-asc-nulls-first.postgres91.xml
	 <<<< >>>>
	actual: "key03"
	expected: "key02"
	 <<<< >>>>
	actual: 8.51
	expected: %null%
	 <<<< >>>>
	actual: "key04"
	expected: "key03"
	 <<<< >>>>
	actual: 6.46
	expected: 8.51
	 <<<< >>>>
	actual: "key05"

Desktop (please complete the following information):

OS: Mac 13.1
Tableau Version: 2022.4

About you:
Name: Song Gao
Company: Starburst Data
tabquery_logs.zip
tdvt_actuals_combined.zip
tdvt_log_combined.txt
tdvt_output_combined.json.txt
test_metadata.csv
test_results_combined.csv

Thanks for reporting this. Can you try modifying your dialect file to add a format-order-by element and see if that resolves this issue. Example:
<dialect ...>
...
  <sql-format>
    <format-order-by value='Nulls' />
  </sql-format>
</dialect>


Dynamic Placeholder Change

Is there way to change the placeholder with some dynamic names with props, So currently it is there as " select..."

Can we make select input box as borderless

@ashraf-commits sure, If you just want to change select into something elase you can use internationalization to customize


Cleanup language service host

computeLineStarts is an impl detail we shouldn't be using:
https://github.com/Microsoft/TypeScript/issues/4057#issuecomment-130120572

Well this is simpler.