Hide the thread that have not been commented

Details

Hide the thread that have not been commented
Fixed Issues

$ https://github.com/Expensify/App/issues/29851
PROPOSAL: https://github.com/Expensify/App/issues/29851#issuecomment-1768604599
Tests

Login with any account
Create a new workspace and go to the announce room
Send a new message
Click on reply in thread of the message
Go back to the announce room
Verify that the thread is hidden in LHN

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Login with any account
Create a new workspace and go to the announce room
Send a new message
Click on reply in thread of the message
Go back to the announce room
Verify that the thread is hidden in LHN

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Screencast from 23-10-2023 10:26:06.webm

Android: mWeb Chrome
https://github.com/Expensify/App/assets/129500732/3df0d05c-71fe-4cfb-8ad1-ac4ee342ccd4

iOS: Native
https://github.com/Expensify/App/assets/129500732/c1a38ccb-8c84-4516-ae7e-5c1e875cf49d

iOS: mWeb Safari
https://github.com/Expensify/App/assets/129500732/f91b3b22-14a9-4d91-a7af-2f70560943f1

MacOS: Chrome / Safari
Screencast from 23-10-2023 10:07:07.webm

MacOS: Desktop
https://github.com/Expensify/App/assets/129500732/2503857a-bf33-4a65-a843-6c068ae4e4b2

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.91-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.91-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Oracle?

How close is the Oracle version to being complete and included in an updated Nuget package?

Hi jeff, the release is pretty ready, but i am still validating some stuff, hopefully in the beginning of the next year it will be ready.
You can always use the nightly feed, it already contains the Oracle Compiler.
https://sqlkata.com/docs/#nightly-builds

Hi @ahmad-moussawi . I am trying to use sqlkata for Oracle too.
When I use your current git repository it works for me so far.
`        private class OracleSqlServerCompiler : SqlServerCompiler
{
public OracleSqlServerCompiler()
{
this.parameterPlaceholderPrefix = ":p";
}
        public override string WrapValue(string value)
        {
            return value;
        }
    }

`
But when I use your nuget 1.1.3 build the parameterPlaceholderPrefix field is not accessible from the class inherited from SqlServerCompiler.
Any idea why?
Thanks,
Alexey

HI @alexeynovitskiy, please use the nightly build feed to get the master branch package
Install-Package SqlKata -Version 1.1.3 -Source https://www.myget.org/F/sqlkata/api/v3/index.json

A side question why you want to access the parameterPrefixPlaceholder ?

Hi @ahmad-moussawi , thanks for the quick response.
I want to use : instead of @ since Oracle has a different syntax for parameters.

In the latest version, it's already using the : as prefix, so no need to change it by yourself.

I just pulled the latest repository and checked it using the master branch.
The following unit test failed.
        [Fact]
        public void OracleMyTest()
        {
            var compiler = new SqlServerCompiler();
            var query = new Query("Users").Where("Id", 1).Where("Status", "Active");
            var result = compiler.Compile(query);
            Assert.Contains(":p", result.Sql);
        }

What branch do you use to release the nightly build?

Off course it will fail since naming the method "Oracle" is not sufficient :), you should use the Oracle compiler instead of SqlServer one :)

I didn't expect that naming the method "Oracle" is sufficient. I didn't know you'd already supported oracle.
This is why I wanted to write my class inherited from SqlServerCompiler and make it work for Oracle.
You should update your git description.

Btw, do you think you need to use " for OpeningIdentifier and ClosingIdentifier?
This query
var query = new Query("Users").Where("Users.Id", 1).Where("Users.Status", "Active");
will be compiled to
SELECT * FROM "Users" WHERE "Users"."Id" = :p0 AND "Status" = :p1
Will the result sql statment get executed sucessfully ?

ohh sorry, I thought you made it by mistake, yes Oracle compiler was supported by @tlaguz and another version by @mathijs-dumon and they will be available in 2019.

No problem. What about using " for OpeningIdentifier and ClosingIdentifier?
When I use database or table alias to build a query I get a query that's not executed successfully by Oracle.
I can solve this problem by creating my class and override Compiler.WrapValue, but it would be much better if I could use without customization.
@tlaguz , @mathijs-dumon any help? maybe I do something wrong?

Which version of Oracle do you use?

SELECT * FROM "Users" WHERE "Users"."Id" = :p0 AND "Status" = :p1
Will the result sql statment get executed sucessfully ?

Yes. How does your schema look like? Regarding double quotation marks: https://stackoverflow.com/questions/563090/what-exactly-do-quotation-marks-around-the-table-name-do
I believe it's expected to use them in case the tables were created with "TableName" syntax. You have to remember about proper capitalization though.

Oracle uses the " as keyword identifier, so no need to change it, check https://stackoverflow.com/a/1162391/1104402 for more info.
If the problem persist, I prefer if you can open a new issue for it, so we can track it better.

@ahmad-moussawi , @tlaguz  thank you, it works, capitalization was the reason.
Do you have any more precise than the 2019 year estimation when it is going to come out?

Version 1.1.4 is now released and available on NuGet.


Add ability to verify 2020 proofs using 2018 keys.

If the 2020 signature suite encounters a 2018 type key, convert it to 2020 and enable verification.
Desired Behavior
The additional functionality we're looking for is:
Be able to verify proofs of type Ed25519Signature2020, using legacy 2018 keys (keys of type Ed25519VerificationKey2018). (This is needed since much of our peer ecosystem does not have 2020 keys implemented, so we need this for wallet interop, etc.)
Specifically, when a documentLoader returns a public key object of type 2018 (AND that key object has the 2018 context), allow the 2020 signature suite to verify a 2020 signature with that 2018 key.
If it receives a type 2018 key but it does not have a context (or is using the 2020 context for some reason), then throw an error.
Implementation Notes

[x] Add @digitalbazaar/ed25519-verification-key-2018 lib to devDependencies.
[x] Replace test suite documentLoader setup with our jsonld-document-loader, and load it up with the ed25519 2020 AND the 2018 context.
[x] Add a couple of unit tests to the test suite. For these, you'll want to add a static entry to the document loader that's like keyId -> public key object of type 2018

If a 2020 signature's verificationMethod is a 2018 key, validate the signature with that key correctly (but only if the resolved key object has a 2018 context).
If a 2020 signature's verificationMethod is a 2018 key, BUT the resolved key object (resolved via the documentLoader) does NOT have a 2018 context, throw error.
Same as above, but instead of no context, have the 2018 type key object have the wrong context (like a 2020 one).

[x] To pass these tests, you'll be modifying the 2020 signature suite itself. First, modify the assertVerificationMethod code. Add support for the 2018 context (but only if the type is 2018 as well).
[x] Modify getVerificationMethod -- (after the assertVerificationMethod call, at the bottom) will need to convert from a 2018 key to a 2020 key (so that the verifySignature logic, later on, can proceed as normal, with a 2020 key).

Implemented in PR #12, closing.


Other fields in the data.

When i got the data from server i was only able to access the 'text' field, how can i access rest of the fields.
I need perform some logical operation based on that data.

Hi!
Your can use data property. Ex:

addPage(node) {
  const newNode = node.append({
    text: 'New File',
    data: {
      isPage: true
    }
  })

  node.expand()

  // then you can read `isPage` property like:
  console.log(newNode.data.isPage)
}

that's kinda hacky way to do it.

Yeah... But it will be on the library side :)  I will check the possibility

I ended up doing that, I will close the issue anyway,
I changed the format of every folder from server and pushed it into the tree.
changeFormat(record){
            let newNode = {
                'text': '',
                'children': [] as any,
                'data': {
                    'id': '',
                    'name': '',
                    'slug': '',
                    'visibility':'',
                    'status':'',
                    'parent_id': null
                }
            }
            newNode.text = record.name;
            newNode.data.id = record.id;
            newNode.data.name = record.name;
            newNode.data.slug = record.slug;
            newNode.data.visibility = record.visiblity;
            newNode.data.status = record.status;

            if(record.parent_id){
                newNode.data.parent_id = record.parent_id;
            }

            if(record.category && record.category.length > 0){
                record.children.forEach((category)=>{
                    let child = this.changeFormat(category);
                    newNode.children.push(child);
                })
            }

            return newNode;


Not able to get responce headers

Hi Christopher,
This problem of mine is defined at micropython forum...
https://github.com/orgs/micropython/discussions/9733
Your help would be much appreciated !!!!
Thank You

From the readme:

save_headers (bool) - a boolean, which is passed to the constructor of the response class instance, which determines whether it keeps a reference to the response headers in the instance. This is set to False by default to save memory. If set to True, the default response class will make the reponse header lines available via its headers instance attribute as a list of unparsed bytes objects.

This only works in mrequests, not urequests.

Christopher
That Worked !!

THANK YOU SO MUCH !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Rich Golden
From: Christopher Arndt @.>
Sent: Monday, October 24, 2022 3:50 PM
To: SpotlightKid/mrequests @.>
Cc: Rich Golden @.>; Author @.>
Subject: Re: [SpotlightKid/mrequests] Not able to get responce headers (Issue #7)
From the readme:
save_headers (bool) - a boolean, which is passed to the constructor of the response class instance, which determines whether it keeps a reference to the response headers in the instance. This is set to False by default to save memory. If set to True, the default response class will make the reponse header lines available via its headers instance attribute as a list of unparsed bytes objects.
—
Reply to this email directly, view it on GitHubhttps://github.com/SpotlightKid/mrequests/issues/7#issuecomment-1289521381, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEJ4GXZJ4QIHBVT3QBLRKLTWE3R7HANCNFSM6AAAAAARNIZOSY.
You are receiving this because you authored the thread.Message ID: @.***>

See also this example: https://github.com/SpotlightKid/mrequests/blob/master/examples/parse_response_headers.py

Hi Christopher,
Got some problems…
If I use mrequests…
and use {"Authorization": "Bearer"} I get a Warning: Comparison between bytes and str but not in urequests
also data=payload returns null… but not in urequests.
Again am I overlooking something ???
import mrequests as requests
import ujson
headersList = {"Authorization": "Bearer"}
payload = ujson.dumps({
"msg": "Can you here me now ???"
})
r = requests.get("http://httpbin.org/anything", headers=headersList, data=payload)
print(r.text)
r.close()

Warning: Comparison between bytes and str
{
"args": {},
"data": "",
"files": {},
"form": {},
"headers": {
"Authorization": "Bearer",
"Host": "httpbin.org",
"X-Amzn-Trace-Id": "Root=1-63593988-4a3ac2c4683689f761abb814"
},
"json": null,
"method": "GET",
"origin": "<IP_ADDRESS>",
"url": "http://httpbin.org/anything"
}
import urequests as requests
import ujson
headersList = {"Authorization": "Bearer"}
payload = ujson.dumps({
"msg": "Can you here me now ???"

},
"method": "GET",
"origin": "<IP_ADDRESS>",
"url": "http://httpbin.org/anything"
}
Thanks Rich
From: Christopher Arndt @.>
Sent: Monday, October 24, 2022 4:09 PM
To: SpotlightKid/mrequests @.>
Cc: Rich Golden @.>; Author @.>
Subject: Re: [SpotlightKid/mrequests] Not able to get responce headers (Issue #7)
See also this example: https://github.com/SpotlightKid/mrequests/blob/master/examples/parse_response_headers.py
—
Reply to this email directly, view it on GitHubhttps://github.com/SpotlightKid/mrequests/issues/7#issuecomment-1289543729, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEJ4GX7YY7LCF7JANOEZKC3WE3UERANCNFSM6AAAAAARNIZOSY.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Pass in everything (URL, header keys and values, as bytes not str, and the warning should go away. It's just a warning, though, and should still work. See also #3.
As for data. You can't send request data with a GET request with mrequests. Doing that makes no sense in HTTP. Use a POST request. The fact that it works with urequests is due to the fact that httpbin.org runs an HTTP server specifically made for testing, so it doesn't always act according to standards.)

Also, please open new issues for new problems.


DCMP Autos: Davis Spiky Auto

[ ] Make quick 4 actually work
[x] Amp, Center, Source starting locations with 2 or 3 spikes
[x] Spikes to centerlines and shots
[x] First centerline shot to second centerline shot ability

Still need to test


Request for T2 baseline search parameters

I tried to reproduce the T2 baseline using official indices and codes in PR https://github.com/harsha-simhadri/big-ann-benchmarks/pull/17, but cannot get reasonable results compared to the official baseline(i.e. 2000QPS, 0.957 Recall@10 for BIGANN-1B). So would you please release your code and configurations for T2 baseline evaluation?
Here is my operations and results for BIGANN-1B:

Buy a Standard_L8s virtual machine from Azure with Ubuntu 20.04
Install necessary softwares such as Docker, Anaconda, CMake, etc.
Checkout code of PR https://github.com/harsha-simhadri/big-ann-benchmarks/pull/17
Run pip install -U -r requirements_py38.txt to install python requirements
Run python install.py to build docker images
Run python run.py --dataset bigann-1B --algorithm diskann-t2
Run python data_export.py --output result.csv to export results

The final results are as follows:
algorithm,parameters,dataset,count,qps,distcomps,build,indexsize,queriessize,wspq,recall/ap
diskann-t2,DiskANN,bigann-1B,10,883.7374471075963,0.0,1000000.0,51774612.0,58585.96596698971,inf,0.0019
diskann-t2,DiskANN,bigann-1B,10,1307.73774493947,0.0,1000000.0,51774612.0,39590.97471977949,inf,0.00108
diskann-t2,DiskANN,bigann-1B,10,803.5946779065205,0.0,1000000.0,51774612.0,64428.764181067374,inf,0.00208
diskann-t2,DiskANN,bigann-1B,10,1118.5931944484782,0.0,1000000.0,51774612.0,46285.4702289937,inf,0.00133
diskann-t2,DiskANN,bigann-1B,10,1604.1311836371815,0.0,1000000.0,51774612.0,32275.796722938252,inf,0.00076
diskann-t2,DiskANN,bigann-1B,10,929.937028492744,0.0,1000000.0,51774612.0,55675.39565976534,inf,0.0017500000000000003
diskann-t2,DiskANN,bigann-1B,10,966.1165292100424,0.0,1000000.0,51774612.0,53590.44218230504,inf,0.0017399999999999998
diskann-t2,DiskANN,bigann-1B,10,990.0256363593018,0.0,1000000.0,51774612.0,52296.23365147877,inf,0.00166
diskann-t2,DiskANN,bigann-1B,10,1051.6221286578705,0.0,1000000.0,51774612.0,49233.09484375076,inf,0.00149
diskann-t2,DiskANN,bigann-1B,10,682.3607260592325,0.0,1000000.0,51774612.0,75875.72089473638,inf,0.00258

Could you please try again with master branch. The results I see with the commands you are listed are on https://github.com/harsha-simhadri/big-ann-benchmarks/pull/31

@DelightRun Were you able to run these params?

Please re-open if there is an issue


User message API

It looks like the command inbox or other commands from the category messages does not work anymore because of the very recent changes of the twitter API (17 september 2018) regarding the Direct message endpoints. Here are some informations

API changes are being discussed in #271

Fixed in 1.5.0


Update modpack to support 1.19.4

Since 1.19.3 has been skipped, we are now aiming for full release for 1.19.4 version.

If everything goes right before 1.19.4 release, we might publish 1.19.3 version before 1.19.4, but it will stay incomplete. We don't see this modpack to be completed because of some specific mods are not working on 1.19.3 support (And some mod like LambdaBetterGrass is not working on 1.19.3 before 1.19.4 release)


Fix iframe errors for h1 and role main

Summary
When I run bbc-a11y on https://www.test.bbc.com/afaanoromoo/bbc_afaanoromoo_radio/liveradio I get the following errors:

Structure: Headings: Exactly one main heading

In frame //div[@id='root']/main/div/div/div/iframe : Found 0 h1 elements.

Structure: Containers and landmarks: Exactly one main landmark

In frame //div[@id='root']/main/div/div/div/iframe : Found 0 elements with role="main".

iframes do not have to contain one main heading nor do they have to have exactly one main landmark, however the page they are embedded on must have both these - these elements do not have to come from the iframe, it could be elsewhere on the page.
Expected Behaviour
When I run bbc-a11y on https://www.test.bbc.com/afaanoromoo/bbc_afaanoromoo_radio/liveradio I should not get the following errors as the page itself has exactly one main heading and exactly one main landmark:

Structure: Headings: Exactly one main heading

In frame //div[@id='root']/main/div/div/div/iframe : Found 0 h1 elements.

Structure: Containers and landmarks: Exactly one main landmark

In frame //div[@id='root']/main/div/div/div/iframe : Found 0 elements with role="main".

Thanks for opening the issue.
It's an interesting one. Are the MAG structure requirements intended to apply to iFrames or not....
I don't have an opinion on this one yet
"iframes do not have to contain one main heading nor do they have to have exactly one main landmark"
Is this your opinion or is it based on something in MAG? I wonder what WCAG and others do.
Feels like whichever way we go, we should update the MAG to be clearer around these requirements.

bbc-a11y is currently aimed at checking a complete page, rather than isolated iframe content or components. I thought I had created an issue to look into how bbc-a11y might be used with components, something we've discussed in PDG, but apparently I haven't yet.
As Jamie points out, perhaps this is something we need to consider in regard the existing guidelines.
Meanwhile, you may wish to use some of the features, such as skip, when testing a page fragment: https://github.com/bbc/bbc-a11y/blob/master/guides/using/using-bbc-a11y-in-your-project.md

"bbc-a11y is currently aimed at checking a complete page" exactly @EmmaJP. So if the complete page has 'Exactly one main heading' and 'Exactly one main landmark' then these errors should not be present as they are on https://www.test.bbc.com/afaanoromoo/bbc_afaanoromoo_radio/liveradio due to the iframe not having these as well.

This is blocking us going live
For visibility, can someone with write access to this repo please add the Simorgh project to this issue (and a ws-media-stream label if possible)

Jonathan said he's not working on this, so we can pick it up

The tool is not working against our pages because the embed doesn't have an H1: https://www.bbc.com/ws/av-embeds/media/bbc_korean_radio/liveradio
Can we can run the tests against the entire page and make exceptions where there is an iframe?

@aeroplanejane - If you want to, in the meantime, you could get bbc-a11y to ignore this error. See https://github.com/bbc/bbc-a11y/blob/master/guides/using/using-bbc-a11y-in-your-project.md#hiding-errors


fix(transformEntries): shouldPublish will 'preserve' by default

Summary
Fix for the following issue: https://github.com/contentful/contentful-migration/issues/329
Description
transformEntries DSL was publishing all entries by default, now it will be 'preserve' by default

This is technically a breaking change.
Could you mark it as such in the commit?


Retrieve value from JSONField

I'd like to retrieve values from a JSONField because all contents of the whole JSON bloat the vector tiles. Doesn't seem to be possible. Do you see a way?
I tried this (adapted from test suite):
class Feature(models.Model):
    geom = models.GeometryField(srid=4326)
    name = models.CharField(max_length=250)
    layer = models.ForeignKey(Layer, on_delete=models.CASCADE, related_name='features')
    date = models.DateField(null=True)
    json = models.JSONField(null=True)

        Feature.objects.create(
            name="feat1",
            geom="POINT(0 0)",
            layer=cls.layer,
            date="2020-07-07",
            json={"foo": "bar", "baz": "oof"}
        )

1st Attempt (related field notation)
class PostGISFeatureWithJSONView(PostgisMVTView, ListView):
    queryset = Feature.objects.all()
    vector_tile_layer_name = "features"
    vector_tile_fields = ('json__foo', )

results in (Nothing included in MVT)
-                             'properties': {},
+                             'properties': {'foo': 'bar'},

2nd Attempt (annotate related field notation)
class PostGISFeatureWithJSONView(PostgisMVTView, ListView):
    queryset = Feature.objects.annotate(foo=F('json__foo'))
    vector_tile_layer_name = "features"
    vector_tile_fields = ('foo', )

results in (whole JSON included in MVT)
-                             'properties': {'baz': 'oof', 'foo': 'bar'},
?                                            --------------
+                             'properties': {'foo': 'bar'},

3rd Attempt (KeyTransform)
from django.db.models.fields.json import KeyTransform

class PostGISFeatureWithJSONView(PostgisMVTView, ListView):
    queryset = Feature.objects.annotate(foo=KeyTransform("foo", "json"))
    vector_tile_layer_name = "features"
    vector_tile_fields = ('foo', )

results in (Nothing contained in MVT)
-                             'properties': {},
+                             'properties': {'foo': 'bar'},

KeyTextTransform seems to be working.
I don't know why KeyTransform is excluded from final query

OK, I understand.
https://www.postgresql.org/docs/9.3/functions-json.html
According documentation, "->" operator return JSONB.
Django can decode it as SQL values, but it seems that ST_ASMVT doesn't.
For text or nontyped values, you should use KeyTextTransform.
 Works splendidly!
I'm closing as this is a ST_ASMVT limitation.

Il will add this workaround in documentation


Identity token implementation

allow all user roles to get identity tokens for resourceServer and APD
updated docs to accept user role trustee for token creation

Can one of the admins verify this patch?

ok to test


NuGet.exe 3.3.0 update command on solution installs package in all projects

Given SomeSolution.sln with ProjectA and ProjectB, where ProjectA references a Package 1.0.0.
The old nuget.exe (v2) would upgrade Package to the latest version in ProjectA, and leave ProjectB alone, as expected.
The new nuget.exe (v3) upgrades Package to latest version in ProjectA, but also installs the Package in ProjectB. For this to occur ProjectB has to contain a packages.config file.
Is this change in behaviour intended?

This might be the wrong place to report this issue, my apologies if that's the case.

This issue was moved to NuGet/Home#1865


Ansible Failed to complete - Windows 7

Issue Type

Support Request

Your Environment

Vagrant 2.2.7
bash: vboxmanage: command not found
VirtualBox
bash: ansible: command not found

Your OS

Windows (version)

Full console output
https://gist.github.com/AGreenCoSA/4fd2d639631aa8f9904d2e905d58ff15
Summary
PHP Fatal error:  Allowed memory size of<PHONE_NUMBER> bytes exhausted (tried to allocate 67108864 bytes) in phar:///usr/bin/composer/src/Composer/DependencyResolver/Solver.php on line 223"], "stdout": "\nFatal error: Allowed memory size of<PHONE_NUMBER> bytes exhausted (tried to allocate 67108864 bytes) in phar:///usr/bin/composer/src/Composer/DependencyResolver/Solver.php on line 223\n\nCheck https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.", "stdout_lines": ["", "Fatal error: Allowed memory size of<PHONE_NUMBER> bytes exhausted (tried to allocate 67108864 bytes) in phar:///usr/bin/composer/src/Composer/DependencyResolver/Solver.php on line 223", "", "Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors."]}
Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

Note that for composer installs, it seems that Drupal now requires more than 1.5 GB of RAM allocated to Composer to install correctly. That setting can be modified via the php_memory_limit variable (set it to -1 to allow all the memory).
See https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on setting COMPOSER_MEMORY_LIMIT or other options too.
Note that Windows 7 is no longer supported by Microsoft, nor by this project :(


Text (exceeded DFT_GRAPH_LIMIT)

Thanks for reporting a bug! Please include all of the following:
(1) A description of the issue. A screenshot is often helpful too.
First time trying to use difftastic and my first comparison resulted in the error:
 Text (exceeded DFT_GRAPH_LIMIT)

I found https://github.com/Wilfred/difftastic/issues/316 and tried setting set --export DFT_GRAPH_LIMIT 5000000 (fish) but no go on resolving this.
(2) A copy of what you're diffing. If you're diffing files, include the before and after files. If you're using difftastic with a VCS repository (e.g. git), include the URL and commit hash.
I can't share the files unfortunately.
(3) The version of difftastic you're using (see difft --version) and your operating system.
difft --version
Difftastic 0.56.1 (built with rustc 1.76.0)

https://github.com/Wilfred/difftastic/blob/b3732b9ebb66752f6ab9fbc289d0c7e0396fd536/src/main.rs#L601-L610

Should pull an ENV variable per this: https://github.com/Wilfred/difftastic/blob/b3732b9ebb66752f6ab9fbc289d0c7e0396fd536/src/options.rs#L270-L279
I need to figure out how to test it is taking my new value in fish.

K, got it working with one more zero, bumping it to 50 million, instead of 5 million.
set --export DFT_GRAPH_LIMIT 50000000

Note that DFT_GRAPH_LIMIT is proportional to the amount of memory used, so I don't want to 10x the default value here.
I think this is working as intended.


Containerization of the frontend

Containerization of the frontend i.e. we need to dockerize the angular build.
Create jobs in Jenkins to deploy the build.

PR Created - https://github.com/Sunbird-RC/sunbird-rc-ui/pull/15


Add a short sha tag to pushed images

This is a proof-of-concept PR.
I love this plugin!!  This plugin made it a breeze to split up our tests and dropped our previous pipeline times from 10+ min down to under 5 for the worst case, and down to 2m30s in the best case!
However, the tags it produces, are, well...ugly.  They're completely cromulent on the backend, but we use those tag names in a deploy tool, and well, who wants to deploy my-application-app-build-100?  We're already used to the git short sha's, so I think it'd be nice to have an option to push that tag to the repo.
This commit adds the short sha (git rev-parse --short $BUILDKITE_COMMIT) as a tag that's pushed to the repo.
I'm not emotionally invested in this exact code change, so as long as we've got some way to indicate either "add the short sha as a tag" or "use this as a tag for this build", my request would be met.
Again, thanks for this great plugin!

Thanks so much for the contribution and the kind works, @anoldguy!
I love this idea. I'd love to give folks the ability to opt in to tagging their docker images by commit (full and abbreviated), and branch, and maybe some other things — build? job? We could make these plugin options which folks can opt in to. Maybe pushing the weird docker compose tag could be opted out, too, although it's important to maintain the ability to trace the lineage of a pushed imaged. But just wrapping your current PR in a config option would be a great start, and I'm happy to add this. Maybe aiming for a syntax like:
steps:
  - command: test.sh
    plugins:
      docker-compose:
        build: app
        image-repository: index.docker.io/example/application
        tags:
          - "literal tag"
          # Variables work on the beta agent, so this should work
          - $BUILDKITE_COMMIT
          - $BUILDKITE_COMMIT_ABBREV # this one doesn't exist yet, though
          - ${BUILDKITE_COMMIT:0:7} # or maybe we add more parameter expansion options?
          - $BUILDKITE_BRANCH

The only blocker here is if there are multiple agents on the same machine sharing a docker daemon which end up building the same commit then we'll have a race condition around which job gets to tag and push which image. The remote moving is not a problem, but the local tag could change between docker tag and docker push, or be removed by a job while another is trying to push it.
I'm not sure how to solve this. I'd love a docker push [repo] [image id]:[remote label] like git push [repo] [commit]:[remote ref], but I can't find an equivalent. Do you have any thoughts?

Hi there. I wanted to add that docker-compose has the following option:
If you specify image as well as build, then Compose names the built image with the webapp and optional tag specified in image:

build: ./dir
image: webapp:tag

It'd be great to support this method and push webapp:tag to docker registry.
Also you can use interpolation and do something like this in docker-compose.yml:
image: company/webapp:${BUILDKITE_COMMIT}

(I tried it, it works)
The only missing part here is for docker-compose-buildkite-plugin to push the proper tag. Adding a new tag isn't even required unless you need multiple tags.

Hi @sj26!
Waitwaitwaitwaitwait. You can use ENV vars in the pipeline steps yml?!?
<mind_blown.gif>
Ok, if you could use your proposed syntax, that'd be awesome!  However, I don't have an answer for the docker race condition you mention, so... ¯\_(ツ)_/¯   We're pretty flexible in the implementation, tho, so let's not rule anything out yet.
You know, I just noticed that the plugin uses $BUILDKITE_JOB_ID (sans -) to tag the existing images in COMPOSE_SERVICE_DOCKER_IMAGE_NAME.  Until we get a better handle on how this could work for more customers than just us, I'll write a step that calculates the equivalent of COMPOSE_SERVICE_DOCKER_IMAGE_NAME and tags/pushes after all the tests have completed. It's not perfect, but it works within the framework without too many contortions.
I don't suppose we could expose the COMPOSE_SERVICE_DOCKER_IMAGE_NAME as a short-term workaround?
My end goal is to have a tag in my image repo that I can specify. Any solution you can provide and support easily is better than a perfect one that's difficult to maintain or would exist just for us.

In terms of requirements and outcome, how does this compare with https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/pull/8 ?

Sorry we haven't moved on this one yet. I've just proposed substring expansion over on the agent in https://github.com/buildkite/agent/pull/387. I'll see if we can add a config array for tags here, too. Tag collisions might just be a caveat of the feature. :-)

@anoldguy I've taken an stab at the config syntax I posted earlier to enable specifying custom tags over in https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/compare/custom-tags, any chance you could take it for a drive and see how it feels?
To achieve your short sha tag with your current agents you could switch to a dynamic pipeline and interpolate into your pipeline.yml. I've also release a new agent beta, v3.0.beta-11, which contains substring expansion (${BUILDKITE_COMMIT:0:7})!

We're running the beta stack of the elastic-ci-stack-for-aws, but that's only picking up beta-9 atm. I'll see about trying to get a new agent on some of them to test!

Sorry @anoldguy, I think we forgot to rebuild the elastic-ci-stack after the most recent beta release! I've pusher another build which should have updated the cloudformation with a new ami here:
https://s3.amazonaws.com/buildkite-aws-stack/aws-stack.json

Ok, so after re-reading this, perusing #9, #22, and #28, I see I can't specify a custom tag using the master branch.  Back in October, I created a fork and branch to work on this code and I've got a version that's been working for us since then, but the changes were fairly drastic, and haven't aged well with the changes since then to the main master branch.
Is there any chance of this feature (regardless of implementation) getting added?
If docker supported deleting tags via the API, this wouldn't be a problem, I'd write a custom step to push the custom tag after tests have run, and then untag the BK generated names.
I don't mind writing the feature again, against master, but I'd like to make sure that I'm not working on something that people don't think belongs in the plugin.
❤ @anoldguy

Hrm, My understanding was that #28 implemented a [image-name](https://github.com/buildkite-plugins/docker-compose-buildkite-plugin#image-name-optional) config option that lets you choose an image name:
steps:
  - name: ":docker: Build"
    agents:
      queue: docker-builder
    plugins:
      docker-compose:
        build: app
        image-name: ${BUILDKITE_PIPELINE_SLUG}-${BUILDKITE_COMMIT}
        image-repository: index.docker.io/org/repo

I'm slightly confused because I think that image-name in this context provides a tag, not an imagename, but I think it should do what you want @anoldguy? If not, it's a bug and we will fix it.

Thanks for the reply, @lox! I'll give that a try. Sorry, I completely missed that image-name was standing in for tag. 😳
Regardless, I'll close this PR, as it's really not relevant anymore! (We should probably do the same for #9, right?)

@anoldguy thanks for the reminder! I've updated and closed #9.


node.get_versions in upgrade should return a LooseVersion

I need to run a lot of CI to be sure this doesnt break everything
@mambocab to review

http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-trunk-upgradeing-dtest/1/
http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-trunk-upgradeing-upgrade/1/

@mambocab ready for re-review. The newest CI builds from those jobs show no bad results of this change (though not all dtests ran)

I'm confident enough to +1. Have you run it against something older than trunk? That'd make me even more confident -- even a small local run against one of the formerly-buggy tests would be great.

I'd love to see this run in some test jobs before it's committed.

Also running on 2.2 as well then: http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-2.2-upgrade-upgrade/

So that was all passing. Am I good to merge? ^

+1


remove obs-sq resource type

This change is

Should be removed in
v1.1.0-rc.6 build 21-ad9123a
https://develop--tc-create-app.netlify.app/


[Don't merge] Platform tests

Current status
Easy bugs

Set offset=1 (#4)
Iterate for the total number of steps (#6).

Scheduler state bug
I created a stateless implementation that I test using torch-micro-scheduler.py and jax-micro-scheduler.py. They use random input (the same in both scripts) and print the output after every call to scheduler.step. The last line from torch-micro-scheduler.py, when running in CPU, is:
50 [1]: [[ -0.03086062 -14.875211   -21.42081      4.41971   ]]

The last one from jax-micro-scheduler.py using CPU is:
50 [1]: [[[ -0.0308551 -14.875193  -21.420778    4.419718 ]]]
And when using a CUDA device it is:
50 [1]: [[[ -0.03085638 -14.875197   -21.420776     4.4197164 ]]]
I consider this to be close enough. These tests were conducted in the same Linux box.
Remaining bugs
A simple image generation loop, without classifier-free guidance, still shows differences between the PyTorch and the Flax versions.
The test scripts show a slice of the current latents after each iteration step. These are the results:
PyTorch CPU

Step  0 [981]: [-0.20029372 -0.71322274 -0.6588407   1.3012452 ]
Step  1 [961]: [-0.20023333 -0.7130672  -0.6587741   1.3011351 ]
Step  2 [961]: [-0.19388276 -0.7101537  -0.6593911   1.2980776 ]
Step  3 [941]: [-0.18676892 -0.7066815  -0.6598941   1.2944702 ]
Step  4 [921]: [-0.17876498 -0.70243776 -0.660212    1.290017  ]
Step  5 [901]: [-0.16972902 -0.69751877 -0.66045487  1.284985  ]
Step  6 [881]: [-0.15949863 -0.69193625 -0.66029674  1.2790979 ]
Step  7 [861]: [-0.14811812 -0.68585664 -0.6598889   1.2726934 ]
Step  8 [841]: [-0.13533752 -0.6792915  -0.6590149   1.2656195 ]
Step  9 [821]: [-0.12131497 -0.6722729  -0.657692    1.2578422 ]
Step 10 [801]: [-0.10598446 -0.6647858  -0.65582865  1.2492626 ]
Step 11 [781]: [-0.08965665 -0.65693915 -0.6534673   1.2399257 ]
Step 12 [761]: [-0.07231925 -0.6487282  -0.6504389   1.2296318 ]
Step 13 [741]: [-0.05423042 -0.64025223 -0.64689887  1.2185035 ]
Step 14 [721]: [-0.03560711 -0.63162565 -0.64254385  1.2063537 ]
Step 15 [701]: [-0.0166229  -0.62293816 -0.63756216  1.1934131 ]
Step 16 [681]: [ 0.00244747 -0.61430305 -0.631572    1.1795033 ]
Step 17 [661]: [ 0.02151561 -0.6057371  -0.62473357  1.1647282 ]
Step 18 [641]: [ 0.04053753 -0.59714484 -0.6170455   1.1489599 ]
Step 19 [621]: [ 0.05943215 -0.5886498  -0.6084518   1.1321318 ]
Step 20 [601]: [ 0.07833029 -0.58015937 -0.5992237   1.114365  ]
Step 21 [581]: [ 0.09711783 -0.5717824  -0.5891966   1.0954585 ]
Step 22 [561]: [ 0.11586673 -0.56339365 -0.57859325  1.0755281 ]
Step 23 [541]: [ 0.13457038 -0.5550037  -0.56728995  1.054374  ]
Step 24 [521]: [ 0.15327923 -0.54639286 -0.5554153   1.0321356 ]
Step 25 [501]: [ 0.17189951 -0.53757924 -0.5428081   1.008607  ]
Step 26 [481]: [ 0.19037156 -0.52846026 -0.5295105   0.9838172 ]
Step 27 [461]: [ 0.20872533 -0.5189969  -0.5155331   0.9578293 ]
Step 28 [441]: [ 0.22693683 -0.50913084 -0.5008364   0.9305079 ]
Step 29 [421]: [ 0.24495293 -0.4988736  -0.48545808  0.9019891 ]
Step 30 [401]: [ 0.2628477  -0.48817235 -0.46945277  0.87225354]
Step 31 [381]: [ 0.28055626 -0.47705117 -0.45268854  0.8412365 ]
Step 32 [361]: [ 0.2980854  -0.46552035 -0.4353878   0.80914426]
Step 33 [341]: [ 0.3154298  -0.45355433 -0.41739047  0.77581835]
Step 34 [321]: [ 0.33256987 -0.44116807 -0.39883557  0.7414012 ]
Step 35 [301]: [ 0.34944463 -0.4283454  -0.3796378   0.705828  ]
Step 36 [281]: [ 0.3660169  -0.41508853 -0.35983148  0.6691652 ]
Step 37 [261]: [ 0.38228554 -0.40139943 -0.3394577   0.6314346 ]
Step 38 [241]: [ 0.39813244 -0.38732246 -0.31853062  0.59268993]
Step 39 [221]: [ 0.41363195 -0.37279892 -0.29705465  0.5529112 ]
Step 40 [201]: [ 0.42867348 -0.35788408 -0.27501422  0.5121036 ]
Step 41 [181]: [ 0.44330248 -0.3425106  -0.25247994  0.47017682]
Step 42 [161]: [ 0.45744026 -0.32664642 -0.22940254  0.42711228]
Step 43 [141]: [ 0.47099906 -0.3102275  -0.20562789  0.38262194]
Step 44 [121]: [ 0.48409614 -0.29324844 -0.1810959   0.3365584 ]
Step 45 [101]: [ 0.4967933  -0.27560505 -0.15544392  0.28805938]
Step 46  [81]: [ 0.5093855  -0.25712317 -0.12850419  0.23624928]
Step 47  [61]: [ 0.5223362  -0.23739506 -0.09932347  0.17866679]
Step 48  [41]: [ 0.53584635 -0.21572267 -0.06636252  0.11064841]
Step 49  [21]: [ 0.5504587  -0.18439673 -0.01844398  0.00506777]
Step 50   [1]: [ 0.5498064  -0.18463875 -0.01927387  0.00364937]

Flax CPU

Step: 0: [-0.19992101 -0.7129871  -0.6586888   1.3008868 ]
Step: 1: [-0.19981347 -0.7128339  -0.6585821   1.3007385 ]
Step: 2: [-0.19290741 -0.70965886 -0.6589236   1.2971743 ]
Step: 3: [-0.18514648 -0.7057757  -0.6591348   1.2928768 ]
Step: 4: [-0.17614478 -0.70119715 -0.6590942   1.2878238 ]
Step: 5: [-0.16603893 -0.69599694 -0.6587924   1.2821018 ]
Step: 6: [-0.1546922  -0.69035506 -0.65814054  1.2758265 ]
Step: 7: [-0.14186884 -0.6842141  -0.6570212   1.2688968 ]
Step: 8: [-0.12765141 -0.6776505  -0.65541327  1.2612278 ]
Step: 9: [-0.11221321 -0.6706691  -0.6532921   1.2528518 ]
Step: 10: [-0.09563611 -0.6633487  -0.6506718   1.2437    ]
Step: 11: [-0.07814168 -0.65575045 -0.64742196  1.2336963 ]
Step: 12: [-0.05991069 -0.6480145  -0.6434747   1.2227519 ]
Step: 13: [-0.04123378 -0.6402351  -0.63899314  1.211138  ]
Step: 14: [-0.02239008 -0.6325704  -0.6335036   1.198588  ]
Step: 15: [-0.00347782 -0.6249878  -0.62726957  1.1853817 ]
Step: 16: [ 0.01554522 -0.61738086 -0.62022686  1.1712673 ]
Step: 17: [ 0.03435938 -0.61008286 -0.61222446  1.1561339 ]
Step: 18: [ 0.05318831 -0.6028376  -0.60362244  1.140135  ]
Step: 19: [ 0.07208736 -0.5956207  -0.5944642   1.1233044 ]
Step: 20: [ 0.09092688 -0.58852077 -0.58460766  1.1053636 ]
Step: 21: [ 0.10976899 -0.58154446 -0.574152    1.0863402 ]
Step: 22: [ 0.12861738 -0.5744467  -0.5630966   1.0662225 ]
Step: 23: [ 0.14747892 -0.56707346 -0.55156934  1.0450902 ]
Step: 24: [ 0.1661616  -0.55952215 -0.53917605  1.022551  ]
Step: 25: [ 0.18472286 -0.5516906  -0.52600926  0.9986482 ]
Step: 26: [ 0.2032078  -0.54341716 -0.51236373  0.9736709 ]
Step: 27: [ 0.22153237 -0.53473914 -0.49796087  0.94738066]
Step: 28: [ 0.23979937 -0.5256013  -0.48277816  0.9196414 ]
Step: 29: [ 0.2578938  -0.51604843 -0.4671864   0.89093804]
Step: 30: [ 0.27593407 -0.5060353  -0.4508992   0.8608283 ]
Step: 31: [ 0.29384482 -0.4955864  -0.43395382  0.8294597 ]
Step: 32: [ 0.31158978 -0.48479837 -0.41666374  0.79701966]
Step: 33: [ 0.32928428 -0.4736257  -0.3989653   0.7633914 ]
[Still running; the process is very slow, will complete when it's done]

As you can see, the numbers are slowly drifting apart. For example, the difference after the first step is in the order of 1e-4. After step 33, it is 0.014 for the first column.
Could there be something in the UNet that is slightly different? How would you go about debugging this?

After the sinusoidal fix (#7), the differences after the inference loop are in the order of ~8e-4 for the slice I print in one of my test images. This is the visual result (left: before the fix; middle: PyTorch CPU reference; right: after the fix). I see no difference between the PyTorch and Flax versions:

Next steps:

[ ] Should we enable int64 for timesteps?

This means that some operations will be performed in float64 and then we'll cast to float32. It has to be enabled explicitly using jax.config.update("jax_enable_x64", True). I haven't measure performance impact, my anecdotal results on one test image are:
int32: jnp.sum(jnp.abs((latents - torch_latents))) -> 98.92086
int64: jnp.sum(jnp.abs((latents - torch_latents))) -> 96.41958

[ ] Improve the stateless scheduler code

I'm using both a dataclass and a dict depending on what part of the code, and I'm sharding manually. I believe I should move to a flax.struct.dataclass to simplify.

[ ] Test a complete generation loop. Currently I'm using text embeddings generated in PyTorch, and I'm not applying classifier-free guidance.

[ ] Merge the bug fixes: #4, #6, #7, plus a new one for the scheduler when it's ready.

[ ] Adapt the Flax inference notebook and publish it!

Thanks a lot for the summary @pcuenca and great job finding the bug!
Regarding the questions:
1.) I think we should not create flloat64 timesteps, but just keep float32 timesteps (the 2% relative diff is not worth it IMO)
More generally I think after having verified that TPU works well we can spin up a demo with this and then before publishing the notebook, I'd actually merge everything directly into diffusers and make a bigger release (0.3.0) saying we now also support JAX

I think we should not create flloat64 timesteps
👍

I'd actually merge everything directly into diffusers and make a bigger release (0.3.0) saying we now also support JAX

Fine for me! But this is only for Stable Diffusion with this one scheduler, we need to be clear about that :)


Create GitHub auto-action for 'brm generate'

Description
This adds a GitHub action to auto generate the required files. This eliminates a developers need to open the project and manually run 'brm generate'.

@shenglol , @alex-frankel
Would like to propose this GitHub action to automate running 'brm generate'.
Here is an example commit generated when this step found that my files where not up to date.

https://github.com/dciborow/bicep-registry-modules/pull/1/commits/4aed441096eb0051a36619f2bea631aeab83aff3

Unfortunately, this is not going to work, since the job won't be able to push commits to forked repositories as it requires write access. We also prefer developers to run the generation step locally to make it easier to track commit history.


Calculator extension

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: divyakolagani sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Fix typo collision detection in stack()

Avoid comparing items that have not been positioned yet (item.dimensions.top is null).  I am sure that was the original intent, but item.top was being checked by mistake.

I'm right now not merging patches since I'm still not under control of the npm. I hope I soon get that permission so I can do the merge-fest. sorry for letting you wait.

No worries on the wait, I appreciate your work on it!


Miscellaneous fixes

Codecov Report

Merging #33 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   97.27%   97.45%   +0.17%
==========================================
  Files           8        8
  Lines         771      786      +15
==========================================
+ Hits          750      766      +16
+ Misses         21       20       -1

Impacted Files
Coverage Δ

src/czml3/properties.py
99.52% <100%> (+0.24%)
:arrow_up:

src/czml3/core.py
100% <100%> (ø)
:arrow_up:

src/czml3/common.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe4b83...997c84d. Read the comment docs.


Getting error on Authorization Code Grant

When I try to get authoriztion, the callback is going to the method onFailure, and the error message is "null". I don't understand what is the field "code" that we have to define, and maybe this why I have error on the authorization. Can you help me? Thanks a lot.
PS: this is my code with error http://pastebin.com/X0M4qf40

+1

+1

The documentation specifies:

code
Required. The authorization code returned from the initial request to the Account's /authorize endpoint.


erro no npm install

to com um erro no npm install and eu uso o comando da isso:
npm notice Beginning October 4, 2021, all connections to the npm registry - including for package installation - must use TLS 1.2 or higher. You are currently using plaintext http to connect. Please visit the GitHub blog for more information: https://github.blog/2021-08-23-npm-registry-deprecating-tls-1-0-tls-1-1/
npm notice Beginning October 4, 2021, all connections to the npm registry - including for package installation - must use TLS 1.2 or higher. You are currently using plaintext http to connect. Please visit the GitHub blog for more information: https://github.blog/2021-08-23-npm-registry-deprecating-tls-1-0-tls-1-1/
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade to latest, formidable@v2 or formidable@v3! Check these notes: https://bit.ly/2ZEqIau
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>The latest version is available, immediately update to get the update.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade to v7.0.2+ of superagent.  We have fixed numerous issues with streams, form-data, attach(), filesystem errors not bubbling up (ENOENT on attach()), and all tests are now passing.  See the releases tab for more information at https://github.com/visionmedia/superagent/releases.
npm WARN deprecated<EMAIL_ADDRESS>Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
npm WARN deprecated<EMAIL_ADDRESS>Version no longer supported. Upgrade to @latest
npm ERR! code 1
npm ERR! path C:\Users\joao\downloads\botzin\iris\node_modules\youtube-dl-exec
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c npx bin-version-check-cli python ">=2"
npm ERR! Error: Couldn't find version of python
npm ERR!     at binaryVersion (file:///C:/Users/joao/AppData/Local/npm-cache/_npx/7b761a280cf4a94b/node_modules/bin-version/index.js:55:8)
npm ERR!     at processTicksAndRejections (node:internal/process/task_queues:96:5)
npm ERR!     at async binaryVersionCheck (file:///C:/Users/joao/AppData/Local/npm-cache/_npx/7b761a280cf4a94b/node_modules/bin-version-check/index.js:14:18)
npm ERR!      C:\Users\joao\AppData\Local\npm-cache_logs\2022-04-04T17_19_50_859Z-debug-0.log
oq eu faço?

Leia a #538.


ENH: Require the iterables in a zip call to have equal length

Require the iterables in a zip call to have equal length.
Fixes:
installing ruff...
--- .maint/paper_author_list.py
+++ .maint/paper_author_list.py
@@ -57,7 +57,7 @@
         % "; ".join(
             [
                 "%s \\ :sup:`%s`\\ " % (i["name"], idx)
-                for i, idx in zip(author_matches, aff_indexes)
+                for i, idx in zip(author_matches, aff_indexes, strict=False)
             ]
         )
     )

Would fix 1 error.

raised for example in:
https://github.com/nipreps/eddymotion/actions/runs/8674793170/job/23787520437?pr=158#step:4:26
Documentation:
https://docs.astral.sh/ruff/rules/zip-without-explicit-strict/#zip-without-explicit-strict-b905

We should replace these two files:
.maint/paper_author_list.py
.maint/update_zenodo.py

with: https://github.com/nipreps/GOVERNANCE/blob/main/project-docs/.maint/update_authors.py.
Let's just remove the two files and update (ruff styling) the new source script for these maintenance tasks.


Sidebar files/folders alignment

What is wrong with the sidebar?
My theme does not match what you have in the README.md example.
Your example:

Mine:

Is this what everyone else gets? Am I missing something?

Will definitely move the DEV theme into master when I push the next release!

Any updates on this? It still shows mis-aligned files in predawn.sublime-theme.

@ravikumars Are you using ST2 or ST3. Since ST3 is still in beta I think I'll keep the predawn-DEV.sublime-theme for now.

I am actually using ST3. I will use predawn-DEV for now. Thanks.


[Bug]: ReflectionTypeLoadException with Mudblazor 6.17.0

Contact Details
No response
What happened?
After upgrading Mudblazor from 6.16.0 to 6.17.0, I get a ReflectionTypeLoadException when adding MudExtensions with
builder.Services.AddMudServicesWithExtensions(c => c.WithoutAutomaticCssLoading());

System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
Method 'Show' on type 'MudBlazor.Extensions.Services.MudExDialogService' from assembly 'MudBlazor.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' tried to implicitly implement an interface method with weaker type parameter constraints.
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeModule.GetTypes()
   at Nextended.Core.Extensions.ServiceCollectionExtensions.<>c.<RegisterAllImplementationsOf>b__4_1(Assembly a)
   at System.Linq.Enumerable.SelectManySingleSelectorIterator`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
   at Nextended.Core.Extensions.ServiceCollectionExtensions.RegisterAllImplementationsOf(IServiceCollection services, Type[] interfacesToSearchImplementationsFor, Assembly[] assembliesToSearchImplementationsIn, ServiceLifetime lifeTime)
   at MudBlazor.Extensions.ServiceCollectionExtensions.AddMudExtensions(IServiceCollection services, Assembly[] serviceImplementationAssemblies)
   at MudBlazor.Extensions.ServiceCollectionExtensions.AddMudExtensions(IServiceCollection services, Action`1 config, Assembly[] serviceImplementationAssemblies)
   at MudBlazor.Extensions.ServiceCollectionExtensions.AddMudServicesWithExtensions(IServiceCollection services, Action`1 config, Assembly[] serviceImplementationAssemblies)
   at Program.<Main>$(String[] args) in /home/david/github/WebAppV3/WebAppV3/Program.cs:line 39
System.TypeLoadException: Method 'Show' on type 'MudBlazor.Extensions.Services.MudExDialogService' from assembly 'MudBlazor.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' tried to implicitly implement an interface method with weaker type parameter constraints.

Expected Behavior
No exception.
Screenshots
No response
Reproduction link
No response
What application type are you referring to?
Please select an application type...
Custom Application Type
No response
MudBlazor.Extension Version
1.7.84
MudBlazor Version
6.17.0
What browser are you using?
Chrome
Sample Solution
No response
Pull Request
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Not adding anything new, but confirming that I am seeing same after updating MudBlazor to 6.17.0 at:
builder.Services.AddMudExtensions();  /* <<< EXCEPTION OCCURS HERE */
builder.Services.AddMudServicesWithExtensions();

System.Reflection.ReflectionTypeLoadException
  HResult=0x80131602
  Message=Unable to load one or more of the requested types.
Method 'Show' on type 'MudBlazor.Extensions.Services.MudExDialogService' from assembly 'MudBlazor.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' tried to implicitly implement an interface method with weaker type parameter constraints.
  Source=System.Private.CoreLib
  StackTrace:
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeModule.GetTypes()
   at Nextended.Core.Extensions.ServiceCollectionExtensions.<>c.<RegisterAllImplementationsOf>b__4_1(Assembly a)
   at System.Linq.Enumerable.SelectManySingleSelectorIterator`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
   at Nextended.Core.Extensions.ServiceCollectionExtensions.RegisterAllImplementationsOf(IServiceCollection services, Type[] interfacesToSearchImplementationsFor, Assembly[] assembliesToSearchImplementationsIn, ServiceLifetime lifeTime)
   at MudBlazor.Extensions.ServiceCollectionExtensions.AddMudExtensions(IServiceCollection services, Assembly[] serviceImplementationAssemblies)

Also using MudBlazor.Extensions 1.7.84.

Looks like interface changed. I will update asap

Should be solved in 1.7.85
MudBlazor.Extensions 1.7.85 Nuget


Wall

Currently a bit of WIP. This is aiming to get the point where we can turn on -Wall so that we notice early when we're doing dodgy things!

This is all that's going to come on this branch for now, as some of the unmatched patterns have pulled my sideways into looking at how we do serialisation/tagging and our data validation again.


Add a JSON writer

See quasiquoting/lodox#31.

https://github.com/lfe-rebar3/lodox/blob/master/src/lodox-json-writer.lfe
Now we just need to make it callable from rebar3.


feat: show the names of the tags to be created

fixes #652

Going to a PR is premature as there are open questions that need resolving in the Issue first. While you likely don't intend it, active PRs exert social pressure on maintainers and clog up their review pipeline. As such, i take the stance that Issues must be decided first and am closing this. If the discussion resolves with agreement to move forward, this can always be reopened or a new PR createdd


Condition Format

I get no idea from the official web, i try to type but that didn't work at all or maybe my command format was wrong, but there is too less info for user, you are do it without pay any serious . i really cant understand what the function condition and some function, if can please update the official web and give example clearly for the function , thank you.
/rpgitem condition add test1 andcondition conditions:test1,test2 id:test
/rpgitem condition add test2 andcondition conditions:test1,test2 id:test
/rpgitem power add test1 potiontick amplifier:4 effect:INCREASE_DAMAGE conditions:test
/rpgitem power add test2 potiontick amplifier:4 effect:INCREASE_DAMAGE conditions:test
Is any wrong there?  i wanna do a weapon put on offhand and mainhand and get the buff
真的是看不懂官網啦，希望官網快快更新，condition什麼的都弄不出來，明明只想弄一個套裝

新的文档在这里 https://nyaacat.github.io/RPGItems-wiki/#/zh-cn/

這只是中文版吧 .-.

andcondition is buggy.
You can
/rpgitem power add test1 potiontick amplifier:4 effect:INCREASE_DAMAGE conditions:test1,test2


PHP 5.4 doesn't work OOTB?

Your page claims that CA will run fine under PHP 5.4, but I get many errors relating to deprecated features (e.g. call-time pass by reference). Am I missing something?

I've got the latest version (4.0.0) of this project. But there are some errors with php <5.5.
For example:
PHP Fatal error:  Can't use function return value in write context in /opt/crawler/web/crawler/pub/ajax/content.sources.ajax.inc.php on line 1512
See Parameters section on empty() documentation
So I think it would be nice to update the Pre-requisites in readme.md


WSO2 API-M 4.1.0: 404 problem with new API

Description:

I was able to create and publish APIs on my dev WSO2 installation based on H2 DB. Unfortunately started from the fifth APIs (the first four still working very well) I have this error.
If I'm calling the API from Postman I receive
{ "code": 404, "type": "Status report", "message": "Not Found", "description": "The requested resource is not available." }
Into the logs I see
INFO {org.apache.synapse.mediators.builtin.LogMediator} - STATUS = Message dispatched to the main sequence. Invalid URL., RESOURCE = XXXXXXXXXXXXXXX, HEALTH CHECK URL = XXXXXXXXXXXXXXX
Any help will appriciate.
Affected product version:
API-M version 4.1.0
Affected component:
API-M version 4.1.0
Environment details (with versions):

OS: Ubuntu 18.04
Client: Ubuntu 18.04
Env (Docker/K8s): standalone installation with H2 DB

Optional fields
Related issues:

Suggested labels:

Suggested assignees:

When this fifth API is deployed from the Publisher portal, do you see the "synpase config successfully deployed" info logs in the wso2carbon.log file?
Ex:
[2022-05-09 12:08:31,802]  INFO - DependencyTracker API : PizzaShackAPI:v1.0.0 was added to the Synapse configuration successfully

I am facing that issue too. But for me, there is no such issue on H2 db. But for mysql, I got such error. Unluckily I got such issue on the creation of first endpoint.
When I change mysql db, I have to restart the APM server on every time I created new endpoints. If I didn't restart APM server, I cannot call the created endpoints. I got 404 response.

@dushaniw Yes. I can see these log if I am using H2 db. But I cannot see that log in using Mysql.

I'm using PostgreSQL with APIM 4.1.0 and facing the same issue. In my case, I'm also getting the message synapse config successfully deployed in the logs. But, when I try to invoke the api, am getting 404 error. This worked fine in my APIM 3.2.0 and the issue is only with 4.1.0

Resolution/Invalid

@engineering-dotcms May I know your finding? I think we have different issue. Thanks.

@engineering-dotcms Could you please tell us what was the sollution for you. I'm facing the same issue with Postgres SQL.
Many thanks


”Hodod” is listed in the drop-down menu

Description:
"Hodod" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Hodod" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Hodod, SATU MARE".


Hey, I could clean up all of the 'or' statements similar to this one if you'd like?

Hey, not sure if this would be of interest but:
https://github.com/TryGhost/Ghost/blob/28283b54acd7f3797ed3e0b854d0aea993f0f584/core/frontend/meta/twitter-image.js#L15
-  if (_.includes(context, 'post') || _.includes(context, 'page') || _.includes(context, 'amp')) {
+  if (['post','page','amp'].some(one => _.includes(context, one))) {

Thank you for the offer, although I think this kind of change is very subjective.
If you'd like to discuss contributing to Ghost there is a section on the forum for this: https://forum.ghost.org/c/contributing/27, There is much work that we'd love to have help with, and you'll see those tasks marked help wanted here in GitHub.


Only run tests for updated packages

This PR adds a script which runs CI tests only for updated packages (via lerna updated) to speedup them :)

Sweeeeeeeet!!


Ability to add adjustment points into lines in content menu

I found that some images in the online library can have multiple adjustment points,
Currently, This way I found is that, I need to copy the shape, then change its points in the shape's JSON, then paste it into editor... Is there any better way to do things like so?
I can't find any way to create a shape which have multiple adjustment points:

Also, it seems that the version I am using don't have the feature "closing multi-point shapes" (mentioned in #2035) at all, so that I can't set the background color for drawings drawn by the pen tool:

Why?

Oh, I found a way to create such, but can


Add 'Commented' button in the main issues search tab

Fixes #1102

Thsi works, however I'd like to see it on the PRs too. Can you try to fit them on one line with some CSS (display:flex) like this?

Alternative solutions welcome

We can decrease the size of the search bar further (I see we have done that already
for Yours filter)

Decrease the padding of all filter buttons to accommodate them in one line

Or a bit of both?

If you can do just the first one I think that's ok

@bfred-it please verify when you get chance. thanks.

Let's see if anyone else has anything to say about the style

The screenshots look identical to me, so I'm ok with either. 👍

Can you mention it in the readme? It can be mentioned on the same line for Yours

Here's the final screenshot. Adding it to readme.


feature request: get current vtol state

I currently stumbled over the fact, that I can control the VTOL state from MAVSDK but don't have the possibility to read it's current state. Is this left out by purpose? I would have expected a property in the telemetry plugin, where the in_air property is generated from the extended_sys_state.
Regards

Good point. I think it would be worthwhile to add that to the telemetry plugin.

Not sure I get what's missing. So when flying a VTOL, you don't know if it is in_air or not?

@JonasVautherin No, I get the inAir state, this is fine. I only wish I could get the current state of the vtol, wether it is currently flying as a fixed or rotary wing.
@julianoes thank you for sharing this helpful links. I will have a deeper look after my vacation.

Oh I see, so something like a SubscribeVtolState in telemetry.proto (from Julian's link above), right?

Exactly. This would be a really helpful extension. As far as I overlooked the API there is currently no way to determine the current vtol state.

Yeah that makes sense :+1:. As Julian said, your first step is to add the function definition in telemetry.proto (I suggested SubscribeVtolState), and then generate the C++ code. Write the implementation there, and it will later come automagically to MAVSDK-Python :blush:. I made a live demo during the last DevSummit, if you want to have a look: https://www.youtube.com/watch?v=T1orxSyqDzI

@JonasVautherin @julianoes thank you both for your kind support. I currently made two pull requests mavlink/MAVSDK#1521 and mavlink/MAVSDK-Proto#250 Let me know when I need to add or change anything.

LGTM

@julianoes is there anything to do in order to have this feature available in mavsdk-python?

I would suggest that we make a new mavsdk-python release after the next mavsdk release. Should automatically bring it then

Ok I found the issue, which stopped me from testing this: #391

FYI Release is coming https://github.com/mavlink/MAVSDK-Python/releases/tag/0.20.0


⚠ GreatPosterWall has degraded performance

In 4b0984c, GreatPosterWall ($GPW) experienced degraded performance:

HTTP code: 200
Response time: 1353 ms

Resolved: GreatPosterWall performance has improved in 4f0bdb6.


Does imgui work on JDK 11?

Do all the features of imgui work on JDK 11 properly?

Yep
Reopen otherwise


typo in second block

Second "important" block: change Dynamics Omnichanell   to  Dynamics Omnichannel. Typo.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 24c63639-af9e-0fec-0025-052361e49d5e
Version Independent ID: 33bb4d18-4c3f-111a-3193-3858eaafd7de
Content: Azure direct routing provisioning and configuration - Azure Communication Services
Content Source: articles/communication-services/concepts/telephony/direct-routing-provisioning.md
Service: azure-communication-services
Sub-service: pstn
GitHub Login: @boris-bazilevskiy
Microsoft Alias: bobazile

Thanks for the feedback! We are currently investigating and will update you shortly.

Fixed. Thank you for the feedback!
From: Ryan Hill @.>
Date: Monday, 28 March 2022, 15:51
To: MicrosoftDocs/azure-docs @.>
Cc: Boris Bazilevskiy @.>, Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] typo in second block (Issue #90582)
Thanks for the feedback! We are currently investigating and will update you shortly.
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F90582%23issuecomment-1080679570&data=04|01|boris.bazilevskiy%40microsoft.com|1218f9cdf7104a41cc6508da10c219fc|72f988bf86f141af91ab2d7cd011db47|1|0|637840723121245972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=kJcXx9Hux5p2F4Okm7ofOZZvg3KCS%2F7O9cifJhHnOt4%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQ22VLEXYT5VT3QEKQT6SATVCG2PFANCNFSM5R2KQRGA&data=04|01|boris.bazilevskiy%40microsoft.com|1218f9cdf7104a41cc6508da10c219fc|72f988bf86f141af91ab2d7cd011db47|1|0|637840723121245972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=e4NUY9iyNyS0SYiokFhpdFWYmmjqhSaPG9CKSMihZlc%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

#please-close


New _uploadPhoto method (development help wanted)

Summary
Endpoint for _uploadPhoto was changed, but I'm not able to fix it by myself.
🔥 HELP WANTED! 🔥
New method development
According to new photo upload requests code should look like this:
  async _uploadPhoto({ photo }) {
    const uploadId = new Date().getTime();
    return this.request.post(`/rupload_igphoto/fb_uploader_${uploadId}`, {
      headers: {
        'x-instagram-rupload-params': JSON.stringify({
          'media_type':1,
          'upload_id': uploadId.toString(),
          'upload_media_height': 1800,
          'upload_media_width': 1800
        }),
        'x-entity-name': `fb_uploader_${uploadId}`,
        'x-ig-app-id':<PHONE_NUMBER>879628,
        'x-entity-length': fs.statSync(photo).size,
        'content-type': 'image/jpeg',
        'referer': 'https://www.instagram.com/create/details/',
        'offset': '0',
        'x-instagram-ajax': 'f4c28142cf13'
      },
      // body: fs.readFileSync(photo).toString('utf8')
      body: fs.createReadStream(photo)
    })
  }

Uploading images from web was removed by me.
This method is returning two types of errors.
Type one:
{ debug_info:
   { retriable: true,
     type: 'PartialRequestError',
     message: 'Partial request (did not match length of file)' } }

Error appearing with: body: fs.createReadStream(photo)
Type two:
Using body: fs.readFileSync(photo).toString('utf8') upload is succesful:
{ upload_id: '1558814131153', xsharing_nonces: {}, status: 'ok' }

But, requesting /create/configure/ failing:
{ message: 'media_needs_reupload',
  media:
   { upload_id: '1558814131153',
     device_timestamp: '1558814131153' },
  error_title: 'bad image input extra:{}',
  status: 'ok' }

Network request from browser
If you want to view Instagram web request, switch your DevTools to mobile simulation, and try to upload image.
Real request headers:
:authority: www.instagram.com
:method: POST
:path: /rupload_igphoto/fb_uploader_1558812010088
:scheme: https
accept: */*
accept-encoding: gzip, deflate, br
accept-language: en-US;q=0.8,en;q=0.7,pt;q=0.6
cache-control: no-cache
content-length: 120754
content-type: image/jpeg
cookie: <cookies here>
offset: 0
origin: https://www.instagram.com
pragma: no-cache
referer: https://www.instagram.com/create/details/
user-agent: <ua>
x-csrftoken: <token>
x-entity-length: 120754
x-entity-name: fb_uploader_1558812010088
x-ig-app-id:<PHONE_NUMBER>879628
x-instagram-ajax: f4c28142cf13
x-instagram-rupload-params: {"media_type":1,"upload_id":"1558812010088","upload_media_height":1080,"upload_media_width":1080}
x-requested-with: XMLHttpRequest

Payload contains image only (checked by me, by converting payload to base64):

My mistake, current method is working, but returning errors sometime.

Hello
I am also working on this and have found some success. Can you mail me so that we can collaborate<EMAIL_ADDRESS>

Why not post it here for all to see?

Hello
I am also working on this and have found some success. Can you mail me so that we can collaborate<EMAIL_ADDRESS>

you should consider using payload without multiple param, just dump the image into payload.
in c# restsharp you can use something like this:
restReuqest.AddParameter("image/jpeg", imageBytes, ParameterType.RequestBody)
if your payload contain multipart data like this :
-------------------------------28947758029299
Content-Disposition: form-data; name="fb_uploader_1567869982643"; filename="12.jpg"
Content-Type: image/jpeg
ÿØÿàÿØÿàÿØÿàÿØÿàÿØÿàÿØÿà.....
this error will come up to you.
sorry for bad english.
hope it's help you.

Anyone have solved it?

Any progress on this? I'm trying to implement the photo configuration (but in Python) and I also can't make it work with create/cofigure because I'm getting "no or malformed device_timestamp" error.

I solved the problem in the max two days i post an pull request to update this.

Upload method updated!, just wait commit aproval

Has anyone made any progress on this? I have everything working up to the request to the configure url in Python. When trying to POST to the configure url, I am getting this response:
{'message': "Uploaded image isn't in an allowed aspect ratio", 'status': 'fail'}
Has anyone else ran into this, or solved this issue?

Has anyone made any progress on this? I have everything working up to the request to the configure url in Python. When trying to POST to the configure url, I am getting this response:
{'message': 'media_needs_reupload', 'media': {'device_timestamp': '1591333240992'}, 'error_title': 'staged_upload_not_found extra:{}', 'status': 'ok'}
Has anyone else ran into this, or solved this issue?
I updated the upload method, just wait commit approve

Pull request :
https://github.com/jlobos/instagram-web-api/pull/144

@codexJoin I have pretty much the same code you have implemented in my Python script. For some images I can successfully get the:
{'upload_id': '1591370485603', 'xsharing_nonces': {}, 'status': 'ok'}
But when trying to request the configure url I now get this:
{'message': "Uploaded image isn't in an allowed aspect ratio", 'status': 'fail'}
My method:
def upload_picture(self):
        time_stamp = str(int(datetime.now(tz=timezone.utc).timestamp() * 1000))

        upload_picture_response = self.session.post(
            url="https://www.instagram.com/rupload_igphoto/fb_uploader_" + time_stamp,
            data=open("pic.jpg", "rb"),
            headers={
               'x-instagram-rupload-params': json.dumps({"media_type":1, "upload_id": time_stamp, "upload_media_height":800, "upload_media_width":800}),
                'x-ig-app-id': "1217981644879628",
                'x-entity-length': str(os.path.getsize("pic.jpg")),
                'content-type': 'image/jpeg',
                'referer': 'https://www.instagram.com/create/details/',
                'offset': '0',
                'x-instagram-ajax': 'f4c28142cf13',
                "x-entity-name" : "fb_uploader_" + time_stamp,
                'Content-Length': str(os.path.getsize("pic.jpg")),
            }
        )

        print(upload_picture_response.request.headers)
        print(upload_picture_response.json())
        print(upload_picture_response.status_code)

        configure_picture_response =  self.session.post(
            url="https://www.instagram.com/create/configure/",
            data={
                "upload_id": time_stamp,
                "caption": "Hello World!",
                "custom_accessibility_caption" : "",
                "retry_timeout" : "",
            },
            headers={
                "origin": "https://www.instagram.com",
                "referer": "https://www.instagram.com/create/details/",
                "sec-fetch-dest": "empty",
                "sec-fetch-mode": "cors",
                "sec-fetch-site": "same-origin",
                "x-ig-app-id": "1217981644879628",
                "x-instagram-ajax": "5fb9742e2e7e"
            }
        )
        print()
        print("--------------------")
        print()

        print(configure_picture_response.request.headers)
        print(configure_picture_response.json())
        print(configure_picture_response.status_code)

@tydegennaro instagram only accept images with aspect ratio 1080 x 1080 or more, and just accept jpeg images. see im my code, i convert images to allowed aspect ratio and format.

@codexJoin Ahh I see. I just got this to work. I left out the resizing the image part. I assumed that Instagram would do this automatically. Thanks for your help!

@tdeg is this still working?


Improve render graph error detection

It's currently possible to call connectNode() on a node that has not been added to the render graph without throwing an error.   What happens is implementation-specific according to the general graph documentation, but we should be explicit in how we handle it.
This PR throws an exception but another approach would be to add the node explicitly.

Hooray Jenkins reported success with all tests good!

Closing due to likely irrelevance. Pinging @dave2s to comment on relevance after the rendering GSoC 2019 project and to coordinate with @mkienenb as needed.

The problem is not relevant anymore. Connect() will be implicitly called only for present nodes after the graph has been created as of #3732. This will happen on the basis of DependencyConnections, which are used for explicitly connecting nodes now instead.


Vitest istanbul or c8 coverage cannot resolve vuetify components

Describe the bug
When I use a vuetify component and run the coverage I get Warnings. It looks like it cannot resolve vuetify components. Do you know how could I fix this?
Reproduction
vite.config.js
export default defineConfig({   test: {     deps: {       inline: ['vuetify'],     },     globals: true,     environment: 'jsdom',     mockReset: true,     coverage: {       provider: 'istanbul',       reporter: ['text', 'html'],       reportsDirectory: './tests/unit/coverage'     },   },   plugins: [vue()], })
package.json
{      ...     "coverage": "vitest run --coverage",     "test:unit": "vitest --run --environment jsdom --root"   },   "dependencies": {     "@vitejs/plugin-vue": "^4.2.3",     "@vue/test-utils": "^2.3.2",     "jsdom": "^22.1.0",     "vue": "^3.2.47",     "vuetify": "^3.3.2"   },   "devDependencies": {     "@vitest/coverage-c8": "^0.31.4",     "@vitest/coverage-istanbul": "^0.31.4",     "vite": "^4.3.9",     "vitest": "^0.31.4"   } }
main.js
`const app = createApp(App);
const vuetify = createVuetify({
components: components,
directives: directives,
});
app.use(vuetify);
app.mount('#app')`
Warnings

System Info
System:
    OS: Windows 10
    Memory: 48.81 GB / 63.73 GB
  Binaries:
    Node: 18.16.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.5.1 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    @vitejs/plugin-vue: ^4.2.3 => 4.2.3
    @vitest/coverage-c8: ^0.31.4 => 0.31.4
    @vitest/coverage-istanbul: ^0.31.4 => 0.31.4
    vite: ^4.3.9 => 4.3.9
    vitest: ^0.31.4 => 0.31.4

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I don't see how this is related to coverage? Did you define your vuetify plugins in your tests?

Yes I have tried to define vuetify plugin in my tests too. The tests run without warnings I get this warnings only in coverage.


[Draft] fix issue 616

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)

[ ] Did you read the contribution guide?
[ ] Did you update the docs? We use Numpy format for all the methods and classes.
[ ] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Type of Change

[ ] Examples / docs / tutorials / contributors update
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Improvement (non-breaking change which improves an existing feature)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

Codecov Report

Merging #623 (8326c47) into master (f734ec0) will decrease coverage by 30.96%.
The diff coverage is 62.85%.

@@             Coverage Diff             @@
##           master     #623       +/-   ##
===========================================
- Coverage   84.54%   53.58%   -30.97%
===========================================
  Files         118      118
  Lines        5973     6050       +77
===========================================
- Hits         5050     3242     -1808
- Misses        923     2808     +1885

Impacted Files
Coverage Δ

etna/models/holt_winters.py
80.72% <50.00%> (-18.06%)
:arrow_down:

etna/models/sarimax.py
52.17% <50.00%> (-41.69%)
:arrow_down:

etna/models/base.py
77.50% <53.33%> (-10.50%)
:arrow_down:

etna/models/__init__.py
100.00% <100.00%> (ø)

etna/models/catboost.py
82.22% <100.00%> (-17.78%)
:arrow_down:

etna/models/prophet.py
92.68% <100.00%> (-6.09%)
:arrow_down:

etna/models/sklearn.py
58.82% <100.00%> (-35.12%)
:arrow_down:

etna/commands/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

etna/commands/backtest_command.py
0.00% <0.00%> (-96.43%)
:arrow_down:

etna/commands/forecast_command.py
0.00% <0.00%> (-92.00%)
:arrow_down:

... and 74 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Provide better error on failed login

We require admins to add each user they wanna permit into the admin
panel. When users who haven't been expressly added, they get a standard
403 Forbidden error.
This page should be a little more informational, and contain information
on why they couldn't log in, and asking them to contact the admins
to get them added. To begin with, I don't think we need to expose who
the admins are, but we can add that optionally later if needed.

We will need to override https://github.com/jupyterhub/jupyterhub/blob/master/share/jupyterhub/templates/error.html in our templates I think.

@GeorgianaElena this is done, right?

@yuvipanda, yeah, this should be fixed by https://github.com/2i2c-org/pilot-homepage/pull/2. I forgot to reference this for closing. Closing it now. Thank you!


add expiry control to invoice command

Signed-off-by: Nitesh Balusu<EMAIL_ADDRESS>Closes #435
Added expiry control to invoice command.
Files changed:
offchain/create_invoice.js
offchain/sign_payment_request.js

Fixed

Looks good, i'll play around with this tomorrow


feat: rollback Throw an error if  scripts contain  in package.json

Related Issue:
https://github.com/zeit/now-cli/issues/2546
Descriptions:
I think it is necessary for developers who uses now dev in dev scripts

Codecov Report

Merging #2552 into canary will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           canary    #2552      +/-   ##
==========================================
+ Coverage   13.64%   13.65%   +0.01%
==========================================
  Files         256      256
  Lines        9430     9423       -7
  Branches     1077     1075       -2
==========================================
  Hits         1287     1287
+ Misses       8019     8012       -7
  Partials      124      124

Impacted Files
Coverage Δ

src/util/dev/types.ts
0% <ø> (ø)
:arrow_up:

src/commands/dev/index.ts
0% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18cedcb...7c5c65b. Read the comment docs.

Hi @zx6658, please take a look at this response on the PR that added those changes to see why they were added: https://github.com/zeit/now-cli/pull/2507#issuecomment-511133351

@AndyBitz The reasons given do not require such a brute force approach. Given this comment from @leo would suggest as much too.
It would suffice with doing this check only if config.zeroConfig === true or pkg['now-dev'] exists, meaning we can disable the check and get back to the "old behavior" by setting {zeroConfig: false} as config to the builder or leave everything as is before this change was merged. As the issue of infinite loop only affects those using zeroConfig, meaning us with now-dev are not really affected (or at least shouldn't be, right?).
I haven't look too much into this new "zero config" approach to tell, but from what I've seen this zeroConfig thing requires the use of now as a global command to run things...we want our developers to use npm run dev to make sure that we can change the underlying implementation if/when the time comes. Any pointers are appreciated on this topic.

@michaellopez Let us know if #2559 alleviates your concerns.
However, as a more general solution, you could also just have a ./dev.sh script that starts the dev server, while still allowing you to change the underlying implementation.

@TooTallNate thanks for the quick response! Looking at that PR it looks great, a much better approach to identifying zero config (than my clunky suggestions) and only issuing the warning then. The logic feels right but I will test it out in a few days, I don't have access to my laptop right now.

I'll close this PR as it was fixed in https://github.com/zeit/now-cli/pull/2559


Adding tag support

Added tag support for DO Api, including listing and deleting droplets by tag.

Great work! :100:
Could you go thru and fix the style issues so the codebase is consistent? I left some comments, but there is also a few mismatching opening brackets (Codebase follows 1TBS)

Missed those object initializers and a few brackets, thanks for pointing it out! Fixed the style issues, even found a couple that weren't mine and corrected. 😊

Thanks! I'll merge this when I'm ready to push a new version to NuGet. Hopefully tonight.


Add support for Juju 3.4

Fix getting results from run_on_unit and run_action. Also, series was replaced with base in juju status, so the small function to convert base to series was required.

Need to fix lint.

It is not related with this PR.

Hi @rgildein, can you update your PR? We just fix the linter issue.


fix(axios-extension): message bas deploy

BUG - Wrong link to the error message displayed during deployment in BAS #1257
Adds additional note for a customer to replace the host in the URL.

Closing PR, created branch directly on the repo.., creating PR from there...
#1265


Generate markdown for filecache.checkStale

Unblocks pre-merge
Related to #8260
Signed-off-by: Gera Shegalov<EMAIL_ADDRESS>

https://github.com/NVIDIA/spark-rapids/pull/8241
has this change already in it, just waiting on CI which shouldn't be much longer

actually just merged that

duplicates #8241


May I ask how to auto-replay the video?

I would like to start playing the same video once the video finishes playing.
Is there anything like onCompleteListener or setOnPreparedListener in dkplayer? If there is, may I ask how to use it?
Thanks dueeeke.

    PlayerConfig config = new PlayerConfig.Builder().setLooping().build();
    mIjkVideoView.setPlayerConfig(config);

Thanks dueeeke.


new file creaton Jenkinsfile

@kasasravankumar Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Fix Cloudflare Response

Fix cloudflare response handling
Add optional Zone ID variable + update readme

Thanks!
Am I correct, that you edited docs/contrib/cloudflare.md manually? Because then it will be overwritten the next time someone runs docgen.php.
Please add zone_id here: https://github.com/deployphp/deployer/pull/2637/files#diff-1e8f299762134059f356e543db92da5fa8b6d334f1f8b5f24fbf34dfd8aeafffR18
and run docgen.php :-)
Thanks for the work!

😂 Link to line broken if outside of the diff. into contrib/cloudflare.php  line 18 please

I see :)
Done.


Please fix: lengths encoding, fixed-size arrays and references

T::minimum_bytes_needed() for some types returns hardcoded values, instead of values based on size_of::<T>(), which leads to errors on 64-bits machines. For example, encoding a BTreeSet with more than 2**32 elements won't work properly.

Now Readable and Writable are only implemented for fixed-size arrays up to 16. Please use generic const expressions and implement them for any size array.

Readable and Writable are not implemented for &[u8] and similar types which is a shame.

Please, consider fixing these issues. If you need a PR, I can provide you with one.

The first point is a feature, not a bug. If you need to store more than 2^32 elements you can always use the length_type attribute or create a newtype. Besides, we can't really change this without breaking backwards compatibility even if we wanted to as the serialization format is stable and will not change.
Points (2) and (3) are indeed reasonable and could indeed be fixed.


CSS multiple media queries being overidden

I'm using styled-components package, which lets you use js-in-css.
I used this css function many times before to output css like this:
      padding-left: 8px;

      @media only screen and (min-width: 320px) {
        padding-left: calc(8px + 8 * (100vw - 320px) / 704);
      }

      @media only screen and (min-width: 1024px) {
        padding-left: 16px;
      }

      padding-right: 8px;

      @media only screen and (min-width: 320px) {
        padding-right: calc(8px + 8 * (100vw - 320px) / 704);
      }

      @media only screen and (min-width: 1024px) {
        padding-right: 16px;
      }

But with create-react-app, when I do this, the second (padding-right)'s media queries (min-width: 320px and min-width: 1024px) is being overriden by padding-right: 8px; but padding-left works as expected.
In browser it outputs like this:
@media only screen and (min-width: 320px)
.gHTQkl > .frame > .focus > .content {
  padding-left: calc( 320px + 704 * (100vw - 320px) / 704 );
}

.gHTQkl > .frame > .focus > .content {
  padding-left: 8px; // CROSSED OUT
  padding-right: 8px;
}

@media only screen and (min-width: 320px)
.gHTQkl > .frame > .focus > .content {
  padding-right: calc( 320px + 704 * (100vw - 320px) / 704 );  // CROSSED-OUT
}

I made the function to loop 3 times to add padding-left and padding-right to appear next to each other like:
      padding-left: 8px;
      padding-right: 8px;

      @media only screen and (min-width: 320px) {
        padding-left: calc(8px + 8 * (100vw - 320px) / 704);
        padding-right: calc(8px + 8 * (100vw - 320px) / 704);
      }

      @media only screen and (min-width: 1024px) {
        padding-left: 16px;
        padding-right: 16px;
      }

This seems to fix the problem but obviously if I run same function for another css property for example, width, in the same class it won't work.

Why do you think this is related to CRA specifically?
Have you tried reproducing this without CRA?

Specifically I’m not sure how CRA environment could possibly influence how styled-components works.

Yeah but if I use it without CRA, it works fine.
The only difference was I started with CRA, so I thought I'd ask here...

Do you mean that styled-components works differently depending on whether you're in CRA environment or not? This sounds like a styled-components bug, and I encourage you to file an issue with them.

(I’ll close because it is extremely unlikely CRA can break how a third party library handles CSS-in-JS. But if you can narrow it down to CRA itself I’ll be happy to reopen.)

Ok thank you, I'll create an issue with them.


1772 1773 chainheadertree issue 25 26

Consensus and headers are at block 5. Block 6 is presented and PV is successful. Call PartialOrFullValidationFailed and after make sure that there is a single US_CONSTANTs on CT.
CT is at block 5. Call PartialValidationSucceeded with header 6. ConsensusTipChanged on block 6. Make sure US_CONSTANT moved to 6.
See #1321 (comment)
Preferred reviewers: @Aprogiena or @noescape00

Looks good to me. The only thing I don't like is the local definition of local PID, which should be obtained from CHT, or at least defined as class wide constant.

@noescape00 Please make the last checks and then we can go, looks good to me


docs(workflow): complete README

Complete descriptions of workflows and jobs not captured by initial test scope

Mind opening an issue to fill out these remaining job steps and link it in the Improve Testing Confidence Documentation epic?
Originally posted by @nayib-jose-gloria in https://github.com/chanzuckerberg/single-cell-data-portal/pull/3517#discussion_r1014353092

@nayib-jose-gloria Issue could use more detail as to what documentation is needed and where to put it. Please update or close, if no longer relevant. Ty!

Now a dup of #5942, closing


[Event Request] Codeunit 99000854 Inventory Profile Offsetting - OnBeforeInsertTempSKU

Hi Team,
In codeunit 99000854 we need possibility to replace and avoid using standard code. Having event with handling in the beginning of procedure InsertTempSKU, would be a perfect solution :

[IntegrationEvent(false, false)]
local procedure OnBeforeInsertTempSKU(var TempSKU: Record "Stockkeeping Unit"; var IsHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.