NoSQL Entity Methods

Description
The Entity class takes advantage of some features of SQL databases that do not extend to NoSQL types. In particular, a SQL table has a set schema and thus predictable fields and data types coming out and requirements for writing. With NoSQL this often isn't the case, and anything can go into or come out of a document.
This PR adds some modified version of Entity methods that can help enforce some expected values on an Entity so a NoSQL model could choose to enact a "strict" data model. If these methods are well received I will write tests and User Guide entries for them.
Note bene: These are methods I have been using for months in a Firestore-based project.
Checklist:

[X] Securely signed commits
[X] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[X] Conforms to style guide

@najdanovicivan I'd particularly like to hear from you on this. I know Mongo can have schemas, but I think some of the same issues might be possible?

@najdanovicivan I'd particularly like to hear from you on this. I know Mongo can have schemas, but I think some of the same issues might be possible?

I've been thinking about this and I have a better solution. Closing this for now.

I've been thinking about this and I have a better solution. Closing this for now.

@MGatner for now we're using setters to handle the data to be of correct type in the $attributes property.  And we're overriding the setAttributes method to properly initialize the data.
I have a set of ideas to make additional improvements to Entity class but still haven't got time to work on it.
What I don't like about casts is that those only work in getters. Also when datamap is being used the getter methods naming do not follow the datamap.
So we'll need some improvements for the data initialization to make sure it's attributes are filled with the correct variable type.
There are multiple methods which are there to fill the data setAttributes, fill() ... we need to make sure that only one of them is used when data is loaded from db.  I followed the logic from BaseResult which always uses the setAttributes method when I did other driver implementations.
I also had issue setting data from $_POST in the entity as fill() method will only call the magic setter which makes it impossible to fill some properties which are outside the $attributes property.
So I ended up filling the data this way
foreach ($data as $key => $value)
		{
			$entity->$key = $value;
		}

The issue with datamap is on the other hand very confusing. Here's the example of using it with ElasticSearch where we have fields prefixed with data type. You have to put everything in same index in ElasticSearch in order to be able to use joins
protected $datamap = [
    'live' => 'site_live'
];

//Setter method still use the old name as setter doe not follow the datamap it should work with setLive() method
public function setSiteLive($value): self
{
		$this->attributes['site_live'] = filter_var($value, FILTER_VALIDATE_BOOLEAN);
		return $this;
}

So we can either modify the $datamap but to avoid the BC we can add separate property $dbmap which will just do the conversion between field names in db. So in the end we get different names in $attributes arrays eg. site_live value get's stored as $this->attributes['live']
And one very useful feature will be auto initialization of nested object/object arrays. I'd like to be able to have something like this
protected $initTypes = [
    'categories' = '?Articles\Entities\Category[]'
    'user' = 'Users\Entities\User'
    'live' = 'boolean'
];

What will this do in the end is init the object having $this->attributes['categories'] as array of Article\Entities\Category objects and $this->attributes['users'] initialized as Users\Entities\User object.  $this->attributes['live'] will be converted to bool at initialization.
There will probably be more changes needed along the way. So i propose we make some sort of ticket with voting where anyone will be able to suggest feature request so that we can vote on what is to be implemented.

@MGatner for now we're using setters to handle the data to be of correct type in the $attributes property.  And we're overriding the setAttributes method to properly initialize the data.
I have a set of ideas to make additional improvements to Entity class but still haven't got time to work on it.
What I don't like about casts is that those only work in getters. Also when datamap is being used the getter methods naming do not follow the datamap.
So we'll need some improvements for the data initialization to make sure it's attributes are filled with the correct variable type.
There are multiple methods which are there to fill the data setAttributes, fill() ... we need to make sure that only one of them is used when data is loaded from db.  I followed the logic from BaseResult which always uses the setAttributes method when I did other driver implementations.
I also had issue setting data from $_POST in the entity as fill() method will only call the magic setter which makes it impossible to fill some properties which are outside the $attributes property.
So I ended up filling the data this way
foreach ($data as $key => $value)
		{
			$entity->$key = $value;
		}

The issue with datamap is on the other hand very confusing. Here's the example of using it with ElasticSearch where we have fields prefixed with data type. You have to put everything in same index in ElasticSearch in order to be able to use joins
protected $datamap = [
    'live' => 'site_live'
];

//Setter method still use the old name as setter doe not follow the datamap it should work with setLive() method
public function setSiteLive($value): self
{
		$this->attributes['site_live'] = filter_var($value, FILTER_VALIDATE_BOOLEAN);
		return $this;
}

So we can either modify the $datamap but to avoid the BC we can add separate property $dbmap which will just do the conversion between field names in db. So in the end we get different names in $attributes arrays eg. site_live value get's stored as $this->attributes['live']
And one very useful feature will be auto initialization of nested object/object arrays. I'd like to be able to have something like this
protected $initTypes = [
    'categories' = '?Articles\Entities\Category[]'
    'user' = 'Users\Entities\User'
    'live' = 'boolean'
];

What will this do in the end is init the object having $this->attributes['categories'] as array of Article\Entities\Category objects and $this->attributes['users'] initialized as Users\Entities\User object.  $this->attributes['live'] will be converted to bool at initialization.
There will probably be more changes needed along the way. So i propose we make some sort of ticket with voting where anyone will be able to suggest feature request so that we can vote on what is to be implemented.

This is all good stuff. I haven't had to wrestle with the datamap but it seems like that might need a pass, maybe even bug fixes or clarification about what it should and should not do.
For attribute validation (part of this PR) I think I decided this belongs in the Model. I would like to expand Model Validation to be able to apply to items coming out of the database as well - this will help a lot with "field expectation" in unstructured NoSQL documents.
I should also add, with Firestore I use $attributes on Entity very heavily to provide initial values. I'm not sure we would need a separate "init" property/method since you can provide them manually, unless I misunderstood you?

This is all good stuff. I haven't had to wrestle with the datamap but it seems like that might need a pass, maybe even bug fixes or clarification about what it should and should not do.
For attribute validation (part of this PR) I think I decided this belongs in the Model. I would like to expand Model Validation to be able to apply to items coming out of the database as well - this will help a lot with "field expectation" in unstructured NoSQL documents.
I should also add, with Firestore I use $attributes on Entity very heavily to provide initial values. I'm not sure we would need a separate "init" property/method since you can provide them manually, unless I misunderstood you?

There are some issues having validation in model eg. nested values in arrays are not being validated properly. I don't like it at all as you might end up changing the model eg using different db. I believe data validation should be done completely inside entity having the method validate() there but that's completely outside the scope for this one.
Init I've mentioned does not have anything to do with default values. I set those in entity constructor where needed.
$initTypes is just a cast which will happen to the $attributes when data is loaded from db. It only extends the default types to be able to cast to custom class or array of items of that class

There are some issues having validation in model eg. nested values in arrays are not being validated properly. I don't like it at all as you might end up changing the model eg using different db. I believe data validation should be done completely inside entity having the method validate() there but that's completely outside the scope for this one.
Init I've mentioned does not have anything to do with default values. I set those in entity constructor where needed.
$initTypes is just a cast which will happen to the $attributes when data is loaded from db. It only extends the default types to be able to cast to custom class or array of items of that class

The advantage of validating database results in the model is that the rules are all present there already (assuming they are the same, which I can't imagine a scenario where they would not be?). It's also a logical pairing since Model already has the whole scaffold for interactive with Validation class. I'm not sure what to think about nested values - I think that's a limitation of the current Model since SQL databases (mostly) cannot return them.
I was not opposed to Entities doing some validation (that's how I am doing on my current Firestore project) until I decide it is a bit of a data handling violation. Currently an Entity can receive absolutely anything, then has some tools for defining various ways of presenting that info. Introducing validation creates the new concept of an "invalid Entity", whereas keeping it at the Model gives us the opportunity to decide what to do with "invalid" data (throw exception, skip it / not create the Entity).

The advantage of validating database results in the model is that the rules are all present there already (assuming they are the same, which I can't imagine a scenario where they would not be?). It's also a logical pairing since Model already has the whole scaffold for interactive with Validation class. I'm not sure what to think about nested values - I think that's a limitation of the current Model since SQL databases (mostly) cannot return them.
I was not opposed to Entities doing some validation (that's how I am doing on my current Firestore project) until I decide it is a bit of a data handling violation. Currently an Entity can receive absolutely anything, then has some tools for defining various ways of presenting that info. Introducing validation creates the new concept of an "invalid Entity", whereas keeping it at the Model gives us the opportunity to decide what to do with "invalid" data (throw exception, skip it / not create the Entity).


When you "Lock unspent" in coincontrol, the "Available amount to mint:" does not get updated.

Technically that amount is available, it's just locked, it's the same situation with overall available balance. This is the same behaviour as in Bitcoin afaik. Therefore I don't think it should be changed. Thoughts @reubenyap @catchingknives ?

This is addressed in #426. Would keep this open till merged

Implemented in #439


Fix: indentation of block in the __add__ docstring

currently renders as

on this URL: https://www.tensorflow.org/api_docs/python/tf/Tensor#add

I didn't introduce this lint failure, but fixed it in 04c740a80629f468f7d6df854b14df1db90b8c50

Got introduced in 88d40fca9a0bd529b50ee33d98060f93a7dcf66d


Build fixes

variable can't be changed if setup outside
save out to workspace
fix dep update

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
af0471be916493019cbd74dca81717fc7e65fd03
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm still needed...

/lgtm

I like shorter names - but I like consistency more, that's what golang
uses.
My bigger problem is that ISTIO_BIN is used in few tests - and should
probably be used more consistently
to the location where binaries are located. Except that's now 'ISTIO_OUT'.
Also it would be good if under out/ we had some organization (bin, etc)
mirroring the final image. Would
make docker files simpler, and allow docker tests with mounted directories
instead of rebuilding.
I guess we'll keep improving things slowly...
On Thu, Feb 1, 2018 at 9:58 PM, mattdelco<EMAIL_ADDRESS>wrote:

@mattdelco commented on this pull request.
In Makefile
https://github.com/istio/istio/pull/3083#discussion_r165564204:

@@ -64,16 +64,6 @@ else
# export GOOS ?= windows
endif

-ifeq ($(GOOS),linux)
The section was an attempt to keep the directories short (mostly for
situations without auto-complete), and for anyone who's been hiding in a
cave and didn't know what "darwin" was. I suppose if I really cared about
total length I could've also used "rel" and "dbg" for BUILDTYPE_DIR. Most
cross-compiled builds I've seen used a 2 or 3 level directory structure
akin to what I used. The only time I can recall underscores is in the
Windows driver dev kit (and that might've been to avoid a 4th directory for
OS version).
Anyway, I'm not wedded to any particular scheme--I just wish it could've
been hashed out earlier in my PR so that a PR like this didn't cause a
rebuild and stale directories for devs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/3083#discussion_r165564204, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6sGuNiYjGG0_2W47n9jGGki3O9onks5tQqQigaJpZM4R2cwD
.


Add step in documentation to install grunt-cli to run 'grunt'

Signed-Off-By: Huy Nguyen<EMAIL_ADDRESS>

@wawjr3d just figured it would be simpler to reopen the PR since it's quite small change. 4th time the charm :)

:) you got it. looks good


Update How_to_use_Bones_and_Skeletons.md about instancing issue

Based on discussion with @deltakosh in this thread: https://forum.babylonjs.com/t/shared-skeleton-between-glb-import-instances-incorrectly-culls-instances/13209

Per following discussion we will fix it at engine level:)


16-bit image is way too big

We have a unit test for 16-bit image because they caused problems in the past. However, the test file is 2048x2156, which is enormous considering we only want to test if these images can be properly loaded and processed. With nnunet, inference is really long and this is not convenient.
proposed fix
we can crop this image - it should be at least 10x smaller

With its original size of 2048x2156, the test_segment_image_creates_runs_successfully_for_16bit_TIF_gray_file unit test takes a ridiculous ~10min to segment. Reducing the image size to 2048x209 (~10x smaller) brings this inference time to 1min20, which is reasonable.
Changes applied in 181a3c7


this tool no longer works on my machine

please revert back to commit e93a36d41dae4bb5c72bdeb235e14a4dea1e478d
Thank you,

Can you provide some more context on why it no longer works? I'm reluctant to revert without some supporting info.

thank u for replying. Here's the info I'm using on my machine:

commit hash e93a36d41dae4bb5c72bdeb235e14a4dea1e478d

For my TrustedSec friends this version is available https://github.com/garrettfoster13/pre2k-TS


Network panel not active until page loaded

Need to activate prior to load so we can see the page loading activity, like in FB2
Note this does work once the network tab has been opened at least once.
But if any other tab is active when FB is opened, then the network panel does not log anything.

@Mahks why do you need this?
Note, that you can export all the collected data in the Net panel (as HAR file) using HARExportTrigger extension. This extension can export all the data even if the Toolbox isn't open at all!
Read more about this extension here: http://www.softwareishard.com/blog/har-export-trigger/
I am closing this report, but feel free to reopen or explain what is your use case and I can help!
Honza


Drag and drop causes improper display of the "selected files indicator"

Description
When drag and drop an oobject ( no matter files/folders ) in Files, if the object is dragged over other objects ( say, a folder/executable ), the targeted ones' selected indicator will be lit up like this:

This behavior is okay but, after leaving the target object, the target object's selected indicator will still being lit up, which is incorrect.

Same situation happens on draging files/folders out of Files ( say, to other applications like browser to upload files ); if one or more files/folders were selected, their indicator WON'T disappear, which is different from what Windows Exploere does.

Moreover, after drag and drop, those pre-selected objects BEFORE the drag and drop action will also unable to disappear unless click on them once, which may misleading users thinking those files were selected (but status bar reports none of the objects were selected)

Steps To Reproduce
1.Go to a path that contains decent amount of files/folders.
2.Follow the description section.
3.See the error.
Expected behavior
Selected indicator should behave like Windows Explorer, e.g. disappear when drag and drop other objects.
Files Version
Version: <IP_ADDRESS> OS Version: 10.0.22000.434
Windows Version
Windows 11 21H2 22000.434
Relevant Assets/Logs
debug_fulltrust.log
debug.log

Tracked in #6768


perform  [manually]

Hi authors, I recently tried to run the example on how to perform  [manually] get & send the protocol messages.
And I want to obtain the intersection results from the recevier, however it shows that the intersection size is 0 when I  use ./frontend -messagePassing.
Code:
// that it need to receive a message from the other party.
auto protocol = recevier.run(set, sock) | macoro::make_eager();
// Perform the communication and complete the protocol.
communicate(protocol, false, sock, verbose);
std::cout << "size:"<< recevier.mIntersection.size()<<std::endl;
std::cout << "recver done\n";
Output:
sender done
size:0
recver done
I think its size should be 100, but it is 0. I dont know whither I made a mistake？

yes, there appears to be a bug. I'll look into it

pushed a fix. There was a new feature to reduce the round complexity from 6 rounds to 3 but that doesnt appear to be working correctly. Turned off the feature and everything is working. This feature is off if the last parameter to setup is false. See here. https://github.com/Visa-Research/volepsi/blob/main/frontend/messagePassingExample.h#L153

Also fixed the feature issue of using fewer rounds. See this option https://github.com/Visa-Research/volepsi/blob/main/frontend/messagePassingExample.h#L136
When set, the protocol does a bit more work but required fewer messages to be sent.


FF_Sleep in IOMan always skipped

Hi,
I was exploring the code to find why my code is slowish and I can't download with filezilla more than 300k sec, and I ran into this little bug :
if( FF_GETERROR( slRetVal ) != FF_ERR_DRIVER_BUSY )
{
   break;
}

The following FF_Sleep and while(1) can never occur since we are comparing slRetVal & 0xFFFF and a full uint32_t constant.
I think
if(  slRetVal  != FF_ERR_DRIVER_BUSY )
{
   break;
}

should make the jobs.
Cheers,

Thanks a lot @Eriobis for reporting this.
I had never noticed this because none of the FreeRTOS+FAT drivers have an access function that can return FF_ERR_DRIVER_BUSY.


Emoji not shown on Windows powershell

I noticed a diff in my output from your video...no emoji recognized.

Cheers, Will investigate in parallels in the morning. It's probably macOS using post Unicode 13.0 emoji symbols that aren't compatible with windows.
I will switch them out for something from here: https://www.unicode.org/Public/UCD/latest/ucd/emoji/emoji-data.txt tomorrow

Discovered this is a thing with Powershell -- powershell does not do this by default, without adding this command:
[console]::InputEncoding = [console]::OutputEncoding = [System.Text.UTF8Encoding]::new()

which after that results in:

Regardless since using Spectre may want to use the emoji markup instead of pasting (e.g., :check_mark: and :rocket:)

Thats what I've done
Added a statement to the readme as well take from Spectre docs - we shouldn't really  mess with a users console encoding directly from the app, so leaving it open to the user to set that on their system ^^
Maybe the config file can enable / disable emoji support too.


PP-2687 Ignore snyk issue

As specified in the ticket, after investigation we can tell that we have no exposure for the issue found for the dependency 'npm:timespan:20170907'.
We don't want to keep the alert to avoid that another person on support wastes time investigating the issue again. Considering that there's no fix for this issue yet, we decided to ignore the issue for a given period of time and the revisit to check if it applies.
In order to ignore the issue the snyk client has to be installed and the ignore the desired dependency by running:
snyk ignore --id=npm:timespan:20170907 --expiry='2018-01-20' --reason='No exposure. Transitive dependency pulled from forever dependency.'

That will modify the existing .snyk file in the repo to tell Snyk to ignore that issue.

Agree with Alex's comment. Also the thing to check here is if we were to introduce a new dependency that also had timespan as a dependency, would Snyk continue to ignore it, or would that be considered a separate alert? I think we at least need to find out whether that is the case or not, and possibly amend expiry accordingly, or discuss if this is a good approach

I'm not completely sure, but I think if we introduce a new dependency that breaches the same alert it won't alert. But it will alert if it's the same dependency but a different issue, I guess that's why the id contains the date (e.g. 'npm:timespan:20170907'). So the thing is that there's always a potential risk but we cannot leave the issue open either. We can always revisit when the expiration date is expired and check if there are fixes, but maybe 3 months is too much?

yeah in that case I would say 3 months is too much. Maybe try 30 days to start with?

Ok, makes sense. I'll update the expiration date on both PRs then.


So many unnecessary dependencies in GLFW 3

I need GLFW for only Windowing, Vulkan and input handling. But with GLFW 3, there is so many unnecessary dependencies. They are making Visual Pollution.
When i pass this command on terminal:
pkg-config --cflags --static --libs glfw3
this gives a big list:
-I/usr/local/include -L/usr/local/lib -lglfw3 -lrt -lm -ldl -lXrandr -lXinerama -lXxf86vm -lXext -lXcursor -lXrender -lXfixes -lX11 -lpthread -lxcb -lXau -lXdmcp
I mean, most of them are unnecessary. Can somebody solve this problem?

Which are the unnecessary ones?

pthread (i do not even need threads), lm (i will not use standart C math library) and many other.

GLFW uses libm and pthreads for gamma ramp calculations and TLS. It also uses libdl, librt, libXrandr, libXinerama, libXxf86vm, libXcursor and libX11. The remaining ones are pulled in via the X11 pkg-config files due to your use of the --static flag.

In declaration of GLFW writes 'light weight', if we have to link it
statically it is not 'light weight'. I'm using C instead of C++ because of
C executables are more smaller. Is possible to link it dynamically?
On Fri, Aug 26, 2016 at 6:19 PM, Camilla Berglund<EMAIL_ADDRESS>wrote:

GLFW uses libm and pthreads for gamma ramp calculations and TLS. It also
uses libdl, librt, libXrandr, libXinerama, libXxf86vm, libXcursor and
libX11. The remaining ones are pulled in via the X11 pkg-config files due
to your use of the --static flag.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/glfw/glfw/issues/846#issuecomment-242764969, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT0dMH4pnPuenkaWe_Y0dm8gHaZmfXWwks5qjwP4gaJpZM4JtqEC
.

And not 'portable' with all.
On Fri, Aug 26, 2016 at 6:33 PM, Ibrahim Ipek<EMAIL_ADDRESS>wrote:

In declaration of GLFW writes 'light weight', if we have to link it
statically it is not 'light weight'. I'm using C instead of C++ because of
C executables are more smaller. Is possible to link it dynamically?
On Fri, Aug 26, 2016 at 6:19 PM, Camilla Berglund <
<EMAIL_ADDRESS>wrote:

GLFW uses libm and pthreads for gamma ramp calculations and TLS. It also
uses libdl, librt, libXrandr, libXinerama, libXxf86vm, libXcursor and
libX11. The remaining ones are pulled in via the X11 pkg-config files due
to your use of the --static flag.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/glfw/glfw/issues/846#issuecomment-242764969, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT0dMH4pnPuenkaWe_Y0dm8gHaZmfXWwks5qjwP4gaJpZM4JtqEC
.

In what way is linking statically less lightweight?

Well, I do not want to my application size more than 200 KB without doing
nothing. Especially for developers working for embedded devices, size of
the program is critical. I know GLFW is not supported embedded devices yet
.
And SDL2 and GLFW like libraries are compatibility* layer*s, if we link
them statically, there
no meaning to use them.
As a sample: If you write a program with SDL2 and link it dynamically on
Ubuntu 14.04 using X display manager for x86_64 architecture, you can run
the program on Ubuntu 14.04 using another display manager with x86_64
architecture.
But if you link it statically, you can't.
On Fri, Aug 26, 2016 at 6:48 PM, Camilla Berglund<EMAIL_ADDRESS>wrote:

In what way is linking statically less lightweight?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/glfw/glfw/issues/846#issuecomment-242773059, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT0dME8gvDOu0kx15hjy9lP7vBhUGSJjks5qjwrWgaJpZM4JtqEC
.

As a sample: If you write a program with SDL2 and link it dynamically on Ubuntu 14.04 using X display manager for x86_64 architecture, you can run the program on Ubuntu 14.04 using another display manager with x86_64 architecture.

SDL2 supports all three window systems in the same binary, so it would make no difference in this regard whether it was statically or dynamically linked. GLFW will work the same way in 3.4 or 4.0.
If you want to link GLFW dynamically then do. If you built it yourself, see the BUILD_SHARED_LIBS CMake option. Otherwise see the listing for your distro package.

Thanks.
On Fri, Aug 26, 2016 at 8:46 PM, Camilla Berglund<EMAIL_ADDRESS>wrote:

As a sample: If you write a program with SDL2 and link it dynamically on
Ubuntu 14.04 using X display manager for x86_64 architecture, you can run
the program on Ubuntu 14.04 using another display manager with x86_64
architecture.
SDL2 supports all three window systems in the same binary, so it would
make no difference in this regard whether it was statically or dynamically
linked. GLFW will work the same way in 3.4 or 4.0.
If you want to link GLFW dynamically then do. If you built it yourself,
see the BUILD_SHARED_LIBS CMake option. Otherwise see the listing for
your distro package.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/glfw/glfw/issues/846#issuecomment-242803182, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT0dMIKjW_Erqj28DdkAO3GZFmc2Q9pRks5qjyZ2gaJpZM4JtqEC
.


Added test for timer wakeups

This change is

@AspirinSJL have moved grpc_init, grpc_shutdown_blocking into SetUp, TearDown to workaround #20012

Failures: #19819, #19170, #20017, #20029


Fix: Selectively add CWL instructions (DOCK-2144)

Description
Selectively include CWL instructions for workflows.
Remove comment mentioning common-workflow-language/cwltool/pull/1093 (which has been merged)

 Before
Nextflow:

 After
Nextflow:

CWL:

Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2144
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that your code compiles by running npm run build
[x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[x] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[x] Do not use cookies, although this may change in the future
[x] Run npm audit and ensure you are not introducing new vulnerabilities
[x] Do due diligence on new 3rd party libraries, checking for CVEs
[x] Don't allow user-uploaded images to be served from the Dockstore domain

In general, when possible it would be good if you referenced the GitHub issue in the PR and/or commit messages. I'm not sure if that's part of our official SDLC, but then you get the GitHub linking features; it becomes more visible external users, etc.

I'm not sure if I have access to Github Issues in this repo, I have a reference to the DOCK-2144 issue in the commit title, is this sufficient? https://github.com/dockstore/dockstore-ui2/pull/1529/commits

@Richard-Hansen

In general, when possible it would be good if you referenced the GitHub issue in the PR and/or commit messages. I'm not sure if that's part of our official SDLC, but then you get the GitHub linking features; it becomes more visible external users, etc.

I'm not sure if I have access to Github Issues in this repo, I have a reference to the DOCK-2144 issue in the commit title, is this sufficient? https://github.com/dockstore/dockstore-ui2/pull/1529/commits

I'm not sure if I have access to Github Issues in this repo

All public GitHub issues for all Dockstore-related repos are in the dockstore/dockstore repo.
You can find the corresponding GitHub issue for a DOCK ticket by clicking on the text "GitHub issue" in the description of the JIRA ticket.

I have a reference to the DOCK-2144 issue in the commit title, was this sufficient?

My argument is that the GitHub issue is preferred over (or as well if you prefer) to the DOCK issue.
The issue and the PR are linked; it lets you navigate back and forth easily. When the PR is merged, the GitHub issue is marked merged. An external user who logged a bug can easily find the code that fixed the issue. Our JIRA issues require auth and are not visible to the general public.
That said, that's been my rule of thumb when providing PR feedback, and maybe we should formalize it (or dump it, if I'm the only one who likes it).

I'm not sure if I have access to Github Issues in this repo

All public GitHub issues for all Dockstore-related repos are in the dockstore/dockstore repo.
You can find the corresponding GitHub issue for a DOCK ticket by clicking on the text "GitHub issue" in the description of the JIRA ticket.

I have a reference to the DOCK-2144 issue in the commit title, was this sufficient?

My argument is that the GitHub issue is preferred over (or as well if you prefer) to the DOCK issue.
The issue and the PR are linked; it lets you navigate back and forth easily. When the PR is merged, the GitHub issue is marked merged. An external user who logged a bug can easily find the code that fixed the issue. Our JIRA issues require auth and are not visible to the general public.
That said, that's been my rule of thumb when providing PR feedback, and maybe we should formalize it (or dump it, if I'm the only one who likes it).

I was not aware that all the dockstore repo issues were kept within the dockstore/dockstore repo, I too would prefer to use the github linked issue number to keep track of the commits.
I agree with your sentiment on this, if you do formalize tracking the GitHub issue within the commit title, consider to include the PR that resolves the issue within the commit that is merged into develop. e.g.
Fix: Selectively include CWL instructions (dockstore/dockstore#4862, PR #1529)

That said, that's been my rule of thumb when providing PR feedback, and maybe we should formalize it (or dump it, if I'm the only one who likes it).

FWIW, this is my rule of thumb (reference github if possible, jira if not (SEAB)).


Filter abilities

Normalized database
Added filter button

Is there a way to not have the extra border here? (that's in the ability page)
The filter 'button' is not very pretty either. Maybe just a text would be better, to match the 'Character Level' label?

There is a bug on the Gear tab. Steps to reproduce :

Go to the gear tab
Click on the 1-14 card back
Expected : the gears 1 to 14 shows
Actual : No gear is shown

I suspect it's because the filter is empty?


[BUG]: DisTubeError [YTDLP_ERROR]: ERROR: [youtube:truncated_id]. Incomplete YouTube ID

Describe the bug
Unable to play  music containing '-' in video ID from search result
To Reproduce
Steps to reproduce the behavior:

Run command /music search query: bhromor recall
Click on '1⃣'
See bot crashes

Expected behavior
play the music
Screenshots

Desktop (please complete the following information):

OS: win
Node: v18
Discord.js: v14

Additional context
find a better way to pass button info in src/events/interaction/buttonHandler.js.
or
pass YouTube video link in a better way in src/commands/music/search.subCommand.js  and distribute buttons in a better way current way causing error

Improvements:
Music player duration. convert to hour

Fix:
fix search limit

Improves:

Fix sorting for monthly favorite music

favorite music database will be cleared after 1 day of sending the message to user


Correct spelling errors

Thank you so much for fixing the errors. Happy Contribution!!!😊✨

@KiranAminPanjwani You are welcome to remove the Hacktoberfest label.  I didn't intend a few spelling changes to count towards my Hacktoberfest count.  (And it is still September.)


Change instruction count to 4 in oak adapter

@imstar15 if you need to publish the change, run npm run changeset to increment the patch version to 0.1.3. The npm run changeset will automatically add a new commit to this PR.


[AP-3099] Add rswag documentation

What
Add interactive API documentation using rswag
Link to story
So we can interact with API via an GUI, and
remove need for jquery.
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

Hi - the only comment I've got is that the default landing place for the swagger docs is V3, with V4 showing the POST assessement, which I think is the only difference in the payloads.

👍  I have made V4 page default now and moved all endpoints to it


ImageMagick Access Violation

AccessViolation error :
First chance exception at $005FD2F3. Exception class $C0000005 with message 'access violation at 0x005fd2f3: read of address 0x00000010'. Process ImageMagickTest.exe (3492)
happen when executing samples from readme.md at line ::
aWand := ALImageMagickLib.NewMagickWand;
Any advice whats needed to run this ?

your program is not finding the ImageMagick dlls. You can copy the files of the ImageMagick to the path of your program. You can find all files in "alcinoe\lib\dll\imagemagick"

thanks @viniciusfbb ! I have updated the homepage readme.md with this info.


bootstrap doesn't working in dashboard.blade.php

bootstrap doesn't work in dashboard.blade.php

I have submit the pr #3 for this.

This issue solved?


Lint module doc & a few other things

The discipline of importing module doc from the readme is tooling-assisted now,
lint for ineffective visibility (#[warn(unreachable_pub)]), and fix the resulting errors,
document the proof module,
other minor changes (e.g. visible lifetimes required in Rust ed. 2021)

Will remove d0957aa in the hope I will re-activate @emmorais 's review. Then we just need @porcuquine 's stamp.


rancher alpha repo

$ helm search rancher
rancher-alpha/rancher   2.3.0-alpha3    v2.3.0-alpha3   Install Rancher Server to manage Kubernetes clusters acro...
But when I want to install the rancher,just give the error.
Error: failed to download "rancher-alpha/rancher" (hint: running helm repo update may help)
anyone have some ideas? Please help me,thank you.

Did you execute helm repo add rancher-alpha https://releases.rancher.com/server-charts/alpha?

@khauser yes. I did that.

@khauser

So helm upgrade rancher rancher-alpha/rancher --version=2.3.0-alpha3 --set hostname=<yours> fails?

Yes. I install the new rancher.
helm install rancher-alpha/rancher --name rancher --namespace cattle-system --set hostname=rancher-test.ptit365.com --set ingress.tls.source=secret
It's failed.

@khauser It is ok now. i just add --version=2.3.0-alpha3. Nad it is working. Thank you for help.

Just wanted to add that you can see the available versions of the latest chart for example with:
$ helm search repo rancher-latest/rancher --versions

Just wanted to add that you can see the available versions of the latest chart for example with:
$ helm search repo rancher-latest/rancher --versions


resized cards and font

@smaranjitghose sir i have resized the cards range fields and font for editor page. Please review.

@smaranjitghose sir i have resized the cards range fields and font for editor page. Please review.

Reduce the size further so that all of the cards are in a single row

For the menu bar above, try to left align the options( currently it's right aligned)

okay sir!

@smaranjitghose sir please review again.

Download button is not working. Except that awesome efforts @mharshita !

Okay sir, i will try to fix it. Thanks :)


Plugin copies the file to /var/cache folder and does its checking

To get this working, I had to add sensu user to the adm group so that I can address /var/log/auth.log. But for some reason I started to get Permission Denied for /var/cache/check-log/.../var/log/auth.log. I had to give chmod 777 access (without -R) to /var/cache/check-log/.../var/log/auth.log to get it to work. Ideally adding sensu user to root group should have done the trick.
Please help me solve this issue without having to do chmod on /var/cache/check-log/.../var/log/auth.log.

I fixed this by changing check-log.rb line 36
BASE_DIR = '/var/cache/sensu/check-log'.freeze
This works (on ubuntu) because /var/cache/sensu is created by the sensu package install with r/w/x permissions for the sensu user, which is what the sensu-client daemon runs as.

We need to remove the constant and make this an option that the user can control. I have commented this on the PR.


Support additional embedding providers, particularly OSS ones that can run locally

Feature Request - support other embedding providers/approaches (Doc2Vec, Sentence Transformers, etc). Would love to be able to use Semantic Memory/Semantic Kernel for completely local-running 'free/OSS' POC's that can then be easily migrated 'up' to Azure Open AI/Open AI or other paid services as needed.

hi @kheiman61 using custom embedding generators is already possible, by implementing the ITextEmbeddingGeneration interface and using the memory builder WithCustomEmbeddingGeneration method.
Something like:
public class CustomEmbeddingGenerator : ITextEmbeddingGeneration
{
    public Task<IList<ReadOnlyMemory<float>>> GenerateEmbeddingsAsync(
        IList<string> data,
        CancellationToken cancellationToken = default)
    {
        // implementation code
    }
}

and
var memory = new MemoryClientBuilder(appBuilder.Services)
    .FromAppSettings()
    .WithCustomEmbeddingGeneration(new CustomEmbeddingGenerator(...))
    .Build();

Thank you! I’ll give it a shot.


Anish Rao Kotha File added

Have you read the Contributing Guidelines on Pull Requests?
(Yes.)
Description
( Euclidean Algorithm in Java )
Checklist

[ Y ] I've read the contribution guidelines.
[ Y ] I've checked the issue list before deciding what to submit.
[ Y ] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Solved Issue #1980

The code is copied from Geeks for geeks.

The code is copied from Geeks for geeks.


MTM/market value not loading for futures

Not sure why, haven't looked into it

I'm seeing this currently with FOP EW4Q9 P2780, will try looking into it

Looks like SMART routing isn't supported with futures or futures options. We'll have to track the exchange that each instrument belongs to.


remove microphy integration test

Since we do not do active development in microphysics emulation anymore, this PR removes the integration test.

Closing for outdated local branch


Move package.json error reporting to tester

See DefinitelyTyped/DefinitelyTyped#13113

Quick comments:

Erroring on these fields won't work once redirects are setup - all of @types uses it for testing
The check (https://github.com/Microsoft/types-publisher/pull/207/files#diff-3cd3598c6c892a75812c78c325162a4eR176) for scripts is buggy - it won't error on bad fields when it encounters scripts first (e.g. ['scripts', 'devDependencies'] which allows for a workaround of this check).

For 2, see #208. For 1, we'll deal with when we update for redirects.


CouchDB tests fail for a variety of reasons

The CouchDB tests fail on OSX due to:

The path for the credentials file is incorrect.
The port number is hard coded for 80
The userid and password are required (this depends on the DB configuration)
The needed database kitura_db was assumed to exist

Verified as working correctly.


[SPARK-17347][SQL][Examples]Encoder in Dataset example has incorrect type

What changes were proposed in this pull request?
We propose to fix the Encoder type in the Dataset example
How was this patch tested?
The PR will be tested with the current unit test cases

Test build #64730 has started for PR 14901 at commit 31a0cd7.

Test build #64730 has finished for PR 14901 at commit 31a0cd7.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64730/
Test FAILed.

Test build #64731 has started for PR 14901 at commit 8ef776d.

Test build #64731 has finished for PR 14901 at commit 8ef776d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64731/
Test PASSed.

merged to master/2.0


Recommended style object placement in projects

I'd like to know if there's any kind of recommended structure for separating components and their styles, or if it's better to place them in the same file as the component file.
In short words, I'd like to know what's make more sense:
Button.js
import React from 'react';
import injectSheet from 'react-jss';

const styles = {
  ...a ton of styles here
};

const Button = ({ classes }) => (
  <Button ... />
);

export default injectSheet(styles)(Button);

Or to have:
buttonStyle.js
export default {
  ...a ton of styles here
};

Button.js
import React from 'react';
import injectSheet from 'react-jss';

import styles from './buttonStyles';

const Button = ({ classes }) => (
  <Button ... />
);

export default injectSheet(styles)(Button);

If you are able to write small components - put styles in the same file. I started with separate file per styles and after a year migrated to same file and small components.


Add CMake interface library for tests to clean up graph

As made evident in #973, we really need an interface library setup for our tests. Instead of each and every test repeating the logic:
target_link_libraries(backtrace_enc oelibcxx oeenclave)
target_compile_options(backtrace_enc PRIVATE
    -Wconversion
    -Wpointer-arith)

We can replace this with one instance of:
add_library(oetest-interface INTERFACE)
target_link_libraries(oetest-interface INTERFACE oelibcxx oeenclave)
target_compile_options(oetest-interface INTERFACE -Wconversion -Wpointer-arith)

And then all the tests just do:
target_link_libraries(backtrace_enc oetest-interface)

(If needed to differentiate CXX from C, we can have a pair of interfaces etc.)

So, we kind of have this.
For tests that are enclaves, we can add flags if we want to add_enclave. For libunwind, libcxx, and libcxxrt, we have support libraries.
It appears that the mentioned warnings in the OP were just added globally, which is fine for now. Closing!


Swagger integration -- two service scopes

https://github.com/Microsoft/aspnet-api-versioning/wiki/API-Documentation#aspnet-core
These docs say to do this
    services.AddSwaggerGen(
        options =>
        {
            var provider = services.BuildServiceProvider()
                                   .GetRequiredService<IApiVersionDescriptionProvider>();

            foreach ( var description in provider.ApiVersionDescriptions )
            {
                options.SwaggerDoc(
                    description.GroupName,
                    new Info()
                    {
                        Title = $"Sample API {description.ApiVersion}",
                        Version = description.ApiVersion.ToString()
                    } );
            }
        } );

Does this not mean you have two service scopes for the lifetime of your application? Is this not a bad idea?

Arguably that's true, but it shouldn't matter. This service is only used here. It's needed to collate the API versions to build the Swagger document. Since services is within a closure, it's evaluation is delayed until it's needed (and the rest of the services have been registered).
If you know of an alternate way to retrieve the IApiVersionDescriptionProvider service here, please share and I'll update the examples. API Versioning has no direct dependencies on Swagger/Swashbuckle. You can change things as you see fit for this. However, if you do have a better way, I'm happy to update things to help others fall into the pit of success.  Thanks.

I think I'm good! Thanks. As I understand the service scope object will be disposed of after this closure has been invoked wont it? So unless you're doing something dumb (like capturing a service from it e.g.) it shouldn't hang around should it?

Correct. This interface is really just an abstraction for a property/method. At this point in the code, you're just asking for a thing that can collate and iterate all defined API versions. After this one usage, it is never used again - anywhere.  Should you find that to the contrary, let me know and I'll fix it.  Thanks.

That's great! That was my only concern really. I suppose for added piece of mind could wrap it in a using, it isdisposable isn't it?
Thanks 😁

@commonsensesoftware since Core 3, this pattern is throwing a warning as discussed here:
https://github.com/dotnet/aspnetcore/issues/14587
is it possible to make this late-resolved, like other package authors have done (for example see https://github.com/Particular/NServiceBus.RavenDB/issues/445)

@ericsampson  It is and has been for some time. The examples also demonstrate the configuration. Things are wired up here and are implemented here. I hope that helps.

@commonsensesoftware thank you so much - I must have missed that change, sorry for the noise! I'll pull it into our codebases. Thanks again.


Add repository of common translations

Mentioned in several discussions at this point, and so collecting into a single issue here.
responses.js has done a good job of eliminating large translations, but it got a little bit complicated to handle a lot of things like tankbusters.  Each property on Responses is a function that takes a severity and returns an object for a response field on a trigger, e.g. { alertText: { en: 'Buster on YOU', de: etc etc } }.  This is complicated to use in any real way.
I think we need some separate global object that folks can get translations from? It could also live in responses.js because it's probably going to be used for responses, but it should be a separate object from Responses itself.  Putting it in the responses.js file also means it'd be straightforward to have all of the things in Responses use these new translations too, which sounds nice to avoid even more duplication.
Opinions welcome for what we should call this new thing? Translations feels long.  Names are hard.

That's exactly the solution I was thinking of, glad to see it makes sense to others.
I don't think there's a single word that covers this situation, since we don't want to collide on Popup or TriggerText. TextDump is only eight characters, I suppose. Maybe CommonText? It's ten characters but is explicitly obvious as to what it does.

LocaleText? Maybe Translations is fine too?

I like LocaleText, now that you mention it. That may be the optimum combination of brevity and clarity.
Thinking about it more, reducing horizontal width may not be as important as it could be elsewhere. In theory, the end of any given line of code where one of these text replacements appears will probably not be past column 20-30 or so. In exchange, we will be going from this:
alertText: {
  en: 'Back Then Front',
  de: 'Nach Hinten, danach nach Vorne',
  fr: 'Derrière puis devant',
  ko: '뒤로 => 앞으로',
  cn: '后 => 前',
},

To this:
alertText: LocaleText.backThenFront(),

It's not comfortable, but it's no worse than the status quo.

How about i18n?

Hmm. I like that in terms of "it's really short", but I'm not sure whether we want to deliberately introduce industry jargon as a project keyword.

And why not (common respons), because either it will be used with (respons), or replace it. The principle of this file is to make it all simple and common for all languages if I understood correctly.

Thinking about this more, and after some discussion, I'm a little unsure how we want to handle the structure of this new element. Personally, I think it should be an object of functions just like Responses. This would maintain commonality with how the rest of the replacement elements work. However, because of stuff like 'stack on ' + matches.target we would need to figure out some way to pass that information to these functions. As I see it, we have two options there:

Nest functions horribly:

let LocaleText = {
  stackOnTarget: () => {
    let intermediaryFunction = (data, target) => {
      return {
        en: 'Stack on ' + data.ShortName(target),
        de: 'Auf ' + data.ShortName(target) + ' sammeln',
        fr: 'Packez-vous sur ' + data.ShortName(target),
        ja: data.ShortName(target) + 'にスタック',
        cn: '靠近 ' + data.ShortName(target) + '集合',
        ko: '쉐어징 → ' + data.ShortName(target),
      };
    }
    return intermediaryFunction;
  }
}

The advantage to this is that no matter what, we could call LocaleText functions in exactly the same way we would any other replacement, and they would just work. (Here, we would write alertText: LocaleText.stackOnTarget().) The downside is that it's just so bad.
Or, option 2:
let LocaleText = {
  stackOnTarget: (data, target) => {
      return {
        en: 'Stack on ' + data.ShortName(target),
        de: 'Auf ' + data.ShortName(target) + ' sammeln',
        fr: 'Packez-vous sur ' + data.ShortName(target),
        ja: data.ShortName(target) + 'にスタック',
        cn: '靠近 ' + data.ShortName(target) + '集合',
        ko: '쉐어징 → ' + data.ShortName(target),
      };
  },
}

This makes sense and doesn't nest any extra functions. Unfortunately, we now have to remember how to call each LocaleText function. ("Does it take 1 argument? 2? I'm not sure, I gotta look at the LocaleText file again".) We would call this as alertText: LocaleText.stackOnTarget(data, matches.target). That still saves the tons of vertical space we want, but it does tend to creep over horizontally.
Maybe I'm overthinking this and we could figure out a good way to just return bare text objects? I feel like limiting this to stuff that doesn't require access to data or matches might make stuff harder in the future, but there's of course the very reasonable counterpoint "that's what responses is there for!"
Sorry this is so rambly. I've not had a lot of luck sitting down and putting something really solid together, so I'm instead just trying to get some thoughts written down in hopes someone else can make something good out of the pieces.
(Also, to be clear, I'm not taking this as a situation where I feel that LocaleText is settled, just that I'm using it as a placeholder until we do work that out.)

I am not competent in this area, so I cannot help you. But I thought about it:

could the new file work like (common).
If this is the case, it would suffice to fill with a maximum of translation all the situations that we have in the files (raid, trial and other). What the file does (respon).
You just have to push it further, and have as many triggers as possible. What we forget, would be added afterwards.

This is only my reflection, I do not know if it will help you.

Coming back to this, I think with output strings, this repository of common translations could be a repository of output strings to reuse.  I think this would easily let us make a dictionary of bare text objects that could be reused, as those strings can now have parameters in them.


fix: error in repeated squashed union resolver

Pull Request Test Coverage Report for Build 538879437

14 of 14 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 95.68%

Totals

Change from base Build 536902228:
0.04%

Covered Lines:
821

Relevant Lines:
844

💛  - Coveralls


💡 New release in the Actions marketplace

Description
Hello @dariocurr,
Would it be possible to make a new release of your GitHub action? The v2 still links to the old version of test-summary that gives a Node.js deprecation warning. I can see you already updated the dependency but it's not yet available as a versioned release.
Thanks for your time. If I can help with that, let me know!
Basic Example
Warning message:
The following actions use a deprecated Node.js version and will be forced to run on node20<EMAIL_ADDRESS>For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Workaround
Use dariocurr/pytest-summary@main

I have updated tags and releases. Thanks for the heads up. I will add a workflow to automate it.
Please double-check that everything is back on track!

Thank you for your contribution!


Thoughts on protecting some methods behind authentication and permissions

Problem
Currently, this generator can't be used whenever there needs to be permission per procedure. For example, only some users are supposed to have access to a procedure. Or a procedure requires the user to contain a specific scope in their JWT.
Suggested solution
Add a way to pass information into the generator (maybe directives in the Prisma file?)
Alternatives
Manually write all tRPC procedures by hand.

Hey @TheBestMoshe
I like your suggestion very much.
How do you feel about an option that let's you  pass a custom middleware. This middleware will be applied to all routers:
export const postsRouter = createRouter()
  .middleware(async ({ ctx, next }) => {
    if (!ctx.user?.isAdmin) {
      throw new TRPCError({ code: "UNAUTHORIZED" });
    }
    return next();
  })
  .mutation("findUniquePost", {
    input: PostFindUniqueSchema,
    async resolve({ ctx, input }) {
      const findUniquePost = await ctx.prisma.post.findUnique(input);
      return findUniquePost;
    },
  })

So that way, you can have as many custom cases you need, all in one place.
Would that solve your problem?
Please let me know if you have any other implementation ideas in mind.

How about a middleware per router, not a global one?

The directive way inside the Prisma schema could have worked if we're spelling out all possible procedures in the Prisma schema itself, but unfortunately, we only spell models and enums.  It was only possible in GraphQL schemas.

I guess the most sane thing to do here is a middleware that handles auth inside of it based on proc name. Very soon, I'm looking to build a separate middleware library that makes proc auth a breeze.

@omar-dulaimi I agree that a middleware might be the best approach. Especially if the Prisma tRPC Generator can generate helper functions that can include the typescript definitions of the possible inputs and outputs.
I think a middleware approach would be more flexible than declaring it in the Prisma file. This would enable arbitrary rules that do not need to be built into the library.

I guess the most sane thing to do here is a middleware that handles auth inside of it based on proc name.

This sounds like a great approach!

@TheBestMoshe Thank you for the feedback.
I have implemented the middleware solution and it's out now in<EMAIL_ADDRESS>Glad to have it implemented. Please keep your ideas coming!
I appreciate it.

Hello @TheBestMoshe
Announcing tRPC Shield
It's based on GraphQL Shield if you have used it before, it allows you to abstract away your permissions into a single file!
take this example:
const permissions = shield({
  query: {
    fruits: and(isAuthenticated, or(isAdmin, isEditor)),
    customers: and(isAuthenticated, isAdmin),
  },
  mutation: {
    addFruitToBasket: isAuthenticated,
  },
})

You can define rules as you like, then mix and match then to get exactly what you need with logical operators.
To make things even smoother for tRPC users who also use Prisma, I built a new generator that takes care of emitting the right shield for your Prisma schema:
import { shield, allow } from 'trpc-shield';

export const permissions = shield({
  query: {
    aggregatePost: allow,
    aggregateUser: allow,
    findFirstPost: allow,
    findFirstUser: allow,
    findManyPost: allow,
    findManyUser: allow,
    findUniquePost: allow,
    findUniqueUser: allow,
    groupByPost: allow,
    groupByUser: allow,
  },
  mutation: {
    createOnePost: allow,
    createOneUser: allow,
    deleteManyPost: allow,
    deleteManyUser: allow,
    deleteOnePost: allow,
    deleteOneUser: allow,
    updateManyPost: allow,
    updateManyUser: allow,
    updateOnePost: allow,
    updateOneUser: allow,
    upsertOnePost: allow,
    upsertOneUser: allow,
  },
});

You can fined them here:
tRPC Shield: https://github.com/omar-dulaimi/trpc-shield
Prisma tRPC Shield Generator: https://github.com/omar-dulaimi/prisma-trpc-shield-generator
As a side note, you might have to use @ts-ignore here and there until I figure how to type the shield so that it can be chained. So, contributions of any kind are highly welcomed, so we could get this promising shield as stable as we can.
BTW, it uses zero dependencies! :slight_smile:

@omar-dulaimi  can you please document this feature? I'd like to know how I can pass a custom middleware or configure the permissions. thanks :)

Hey @MartinMuzatko
To pass a custom middleware, you only need to pass the withMiddleware flag in your Prisma schema like so:
generator trpc {
  provider       = "prisma-trpc-generator"
  withMiddleware = true
}

Same thing if you want to get a shield generated:
generator trpc {
  provider       = "prisma-trpc-generator"
  withShield     = true
}

You could also generate both of them if you add both flags above.
To learn more about tRPC Shield and how to configure it's permissions, you should go here: https://github.com/omar-dulaimi/trpc-shield
It explains all possible options in that project README :)

I am not sure I understand correctly. The point of Shield and custom middleware is that I can customize them. If they are generated, how can I update them, without having the generator overwriting them again?
Where is the entrypoint for my custom middleware? Do I need to write to a file and give the path to the generator config in Prisma?
Surely, if I just test this out, I'll see how things work out. But that is something I would like to know before I even install the module to my pc, when looking for new things that fit into my stack :)
I'll report back once I know more.

@MartinMuzatko
The purpose of all Prisma generators is to always be in-sync with the Prisma schema and client. So, yeah it will overwrite every time a generate happens. Best thing you can do is imagine them as snippets generators. You could use them as is or modify them to your liking, in another directory where it will be source control tracked.
The middleware lies inside the helpers directory, in the createProtectedRoute to be exact.

I am not sure I understand correctly. The point of Shield and custom middleware is that I can customize them. If they are generated, how can I update them, without having the generator overwriting them again?
Where is the entrypoint for my custom middleware? Do I need to write to a file and give the path to the generator config in Prisma?

FWIW I'm having this same issue. Feels like this could be resolved more generically by allowing the caller to configure a their own custom createRouter function - that way they could implement middleware, or a shield, or... really whatever they want. The limitation of having to add a post-generate step to copy existing code into helpers/createRouter.ts feels like unnecessary burden on the caller.
I need this functionality and can configure it in a fork I'm maintaining. Happy to PR the change into the upstream if there's appetite for it.


Pilot discovery doesn't have retries of requests to apiserver

Noticeable when deploying the Eureka/Consul demos. The API server takes half a second to startup, which means that pilot isn't not able to make the initial request to the apiserver.
I1004 20:15:45.779376       1 client.go:169] registering CRD "routerules.config.istio.io"
Error: failed to register custom resources. Post http://istio-apiserver:8080/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions: dial tcp <IP_ADDRESS>:8080: getsockopt: connection refused

This wouldn't be a big deal in K8S or with Nomad, since the container would restart and work the 2nd time, but you have to restart the container manually in Docker.

This is still an issue as it causes downtime in K8S or Nomad.. Its silly to expect the platform to restart Pilot if it can't reach the API server.

Issue moved to istio/istio #1383 via ZenHub

I have the same problem.


Pass variables from referencing page to referenced JavaScript file with jquery-file-upload

I want to pass variables that can be used by .fileupload() below in a separate js file.
main Html
  <form id="fileupload" action="url here" method="POST" enctype="multipart/form-data">
    //I want to pass variables, e.g. count, that can be used by .fileupload() below
  </form/>

<script src="~/js/fileUpload.js"></script>

I want to pass variables, e.g. count, that can be used by .fileupload() below
fileUpload.js
$(function () {
    'use strict';

    $('#fileupload').fileupload(
        {
            dataType: 'json',
            acceptFileTypes: /(\.|\/)(gif|jpe?g|png)$/i,
            singleFileUploads: false,
            autoUpload: false,
            sequentialUploads: true,
            always: function (result) {
               //use variables here which are passed from main Html
        });
});

Please see #2190.


Implement aspiration windows

Codecov Report
Patch coverage: 89.68% and project coverage change: +0.03 :tada:

Comparison is base (2b34438) 92.74% compared to head (d397c91) 92.77%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   92.74%   92.77%   +0.03%
==========================================
  Files          86       87       +1
  Lines       12911    13003      +92
==========================================
+ Hits        11974    12064      +90
- Misses        937      939       +2

Impacted Files
Coverage Δ

search/src/history_table.rs
93.33% <0.00%> (ø)

search/src/lib.rs
100.00% <ø> (ø)

search/src/move_selector.rs
96.01% <0.00%> (-0.60%)
:arrow_down:

search/src/node_counter.rs
70.21% <0.00%> (ø)

search/src/search_data.rs
99.30% <87.50%> (-0.70%)
:arrow_down:

search/src/alpha_beta.rs
98.52% <90.00%> (+0.25%)
:arrow_up:

search/src/aspiration_window.rs
98.33% <98.33%> (ø)

search/src/move_candidates.rs
100.00% <100.00%> (ø)

search/src/pv_table.rs
91.93% <100.00%> (+1.61%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add template sample for com.liferay.portal.security.auth.AutoLogin

Just started reviewing :) :octocat: Sent from GH.


device.Telemetry not compatible with PanOS 10.x

Describe the bug
PANOS version 10.x uses a different XPATH and schema for telemetry configuration.  device.Telemetry not compatible with PanOS 10.x
<device-telemetry>
	<threat-prevention>yes</threat-prevention>
	<device-health-performance>yes</device-health-performance>
	<product-usage>yes</product-usage>
	<region>americas</region>
</device-telemetry>

Expected behavior
from panos.device import Telemetry

new_telemetry_params = {
    'threat_prevention': True,
    'device_health-performance': True,
    'product_usage': True,
    'region': 'americas',
}
new_telemetry_obj = Telemetry(**new_telemetry_params)
fw.add(new_telemetry_obj)
new_telemetry_obj.apply()

Should configure device telemetry settings on PANOS 10.x device.
Current behavior
Unable to configure device telemetry settings.
Using new params:
Traceback (most recent call last):
  File "C:\Users\Mark\AppData\Roaming\JetBrains\PyCharmCE2021.1\scratches\scratch.py", line 25, in <module>
    new_telemetry_obj = Telemetry(**new_telemetry_params)
  File "C:\Users\Mark\Documents\projects\pan-os-python\panos\base.py", line 2328, in __init__
    raise ValueError('No param "{0}" exists'.format(name))
ValueError: No param "threat_prevention" exists

Using old params:
Traceback (most recent call last):
  File "C:\Users\Mark\AppData\Roaming\JetBrains\PyCharmCE2021.1\scratches\scratch.py", line 41, in <module>
    old_telemetry_obj.apply()
  File "C:\Users\Mark\Documents\projects\pan-os-python\panos\base.py", line 604, in apply
    device.active().xapi.edit(
  File "C:\Users\Mark\Documents\projects\pan-os-python\panos\base.py", line 3673, in method
    raise the_exception
panos.errors.PanDeviceXapiError: Could not get schema node for xpath<EMAIL_ADDRESS>
Possible solution
Add 10.0 and 10.1 version support
Steps to reproduce
from panos.device import Telemetry

HOSTNAME = os.environ["PAN_HOSTNAME"]
USERNAME = os.environ["PAN_USERNAME"]
PASSWORD = os.environ["PAN_PASSWORD"]
fw = Firewall(HOSTNAME, USERNAME, PASSWORD)

new_telemetry_params = {
    'threat_prevention': True,
    'device_health-performance': True,
    'product_usage': True,
    'region': 'americas',
}
new_telemetry_obj = Telemetry(**new_telemetry_params)
fw.add(new_telemetry_obj)
new_telemetry_obj.apply()

Screenshots

Context
Have to deal with annoying pop up asking me to configure telemetry
Your Environment
PA systems:

PA-850
PAVM-100

pan-os-python: 1.0.2
python: 3.9.1

@markharden817
This is incorrect config.  If you look at the CHILDTYPES you'll notice that device.Telemetry does not show up as a child type for firewall.Firewall; it shows up as a child type for device.SystemSettings.
Thus your object hierarchy should be firewall.Firewall > device.SystemSettings > device.Telemetry.


build: using node 8x, node 7x removed.

Coverage remained the same at 93.382% when pulling 7cab623340e9e7a83dea6e841af5af2a82794547 on node-8 into 542d5ceebcaa1f7d169dca484fa5a886401fdd88 on master.


Adding React 0.14.7 Compatibility

For better touch device processing and performance tuning etc..
Note: react 14 requires including reactDOM now to React with Plugins script.

We've been compatible with this version of React for a while, though it does dump deprecation warnings to the console.


About Evaluation

Hi dear author, Thanks for the amazing work.
I tried to test the model so I followed the instructions in README

download the pre-trained models
run sample.py to sample the motions with the pre-trained kit-mmm-xyz model
run evaluate.py to calculate the metrics with motions above

However, I found that the results were not good enough. I am new to this area, and don't know where I did wrong. I will be deeply graceful if you could help me find out the mistakes. Thanks

APE_root
APE_traj
APE_mean_pose
APE_mean_joints
AVE_root
AVE_traj
AVE_mean_pose
AVE_mean_joints

Paper
0.963
0.955
0.104
0.976
0.445
0.445
0.005
0.448

My run
1.033
1.024
0.104
1.048
0.448
0.448
0.005
0.451

Hello @52PengUin,
Actually you did not do anything wrong, the model is not exactly the same as when the one I used to produce the paper. I tried to clean up the code, and fix some seeds to be more reproducible but this made the model not exactly the same.
The difference is not very great in fact, and may also depend on the randomness of the generation.

OK, I understand the problem now. Thank you for the reply.


[FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

What is the purpose of the change
This pull request try to refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6
Brief change log

Moved table-specific code from elasticsearch 6.x general connector to sql connector
changed pom file and some resource files

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I have reported the Kafka test issue on Travis. Trying to rebuild now.

@flinkbot run travis

@flinkbot run travis

Still failed because of the same Kafka relevant test failure.

@flinkbot run travis

I don't think this will still work because this was not changed:
https://github.com/apache/flink/blob/10f9f1d431dbf047ea14130d9fb7fdd4f78178fc/flink-connectors/flink-connector-elasticsearch6/src/main/resources/META-INF/services/org.apache.flink.table.factories.TableFactory#L16
. And you changed the name of the package.

I have moved the file from flink-connector-elasticsearch6 to flink-sql-connector-elasticsearch6 just like what I did in the PR #9720 . So it should not be a problem?

@aljoscha Thanks for reviewing. @twalthr and Jark have different opinions about the purpose of this PR want to do. Can you have a look at our discussion in the JIRA.

I don't think this will still work because this was not changed:
https://github.com/apache/flink/blob/10f9f1d431dbf047ea14130d9fb7fdd4f78178fc/flink-connectors/flink-connector-elasticsearch6/src/main/resources/META-INF/services/org.apache.flink.table.factories.TableFactory#L16
. And you changed the name of the package.

I have moved the file from flink-connector-elasticsearch6 to flink-sql-connector-elasticsearch6 just like what I did in the PR #9720 . So it should not be a problem?

Yes, but for the other PR you changed the service file: https://github.com/apache/flink/blob/e2c4213a8f0664285658f25f2169487eb952909e/flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/services/org.apache.flink.table.factories.TableFactory#L16

I don't think this will still work because this was not changed:
https://github.com/apache/flink/blob/10f9f1d431dbf047ea14130d9fb7fdd4f78178fc/flink-connectors/flink-connector-elasticsearch6/src/main/resources/META-INF/services/org.apache.flink.table.factories.TableFactory#L16
. And you changed the name of the package.

I have moved the file from flink-connector-elasticsearch6 to flink-sql-connector-elasticsearch6 just like what I did in the PR #9720 . So it should not be a problem?

Yes, but for the other PR you changed the service file:
https://github.com/apache/flink/blob/e2c4213a8f0664285658f25f2169487eb952909e/flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/services/org.apache.flink.table.factories.TableFactory#L16

Yes, but for the other PR you changed the service file:

In this PR, I also changed the service file, now it is:
org.apache.flink.streaming.sql.connectors.elasticsearch6.Elasticsearch6UpsertTableSinkFactory

@flinkbot run travis

This PR go to wrong direction, closing it.


Update OpenVINO supported releases

There were some other references to OpenVINO 2020.1 in the docs that I'll update to point to this section of the FAQ.

This is valid only for gen2.

This is valid only for gen2.

@szabi-luxonis so Gen 1 only supports 2020.1? I can update it to make that distinction.

@szabi-luxonis so Gen 1 only supports 2020.1? I can update it to make that distinction.

@szabi-luxonis so Gen 1 only supports 2020.1? I can update it to make that distinction.

Yes.

@szabi-luxonis so Gen 1 only supports 2020.1? I can update it to make that distinction.

Yes.

LGTM

LGTM


Registering a workflow on staging will show duplicate types

I went onto staging and tried to manually add a new remote workflow. I see duplicated descriptor types.

┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Issue Number: DOCK-997

curl 'https://staging.dockstore.org/api/metadata/descriptorLanguageList'
returns 5 things

Hmm, probably an unintended side-effect of https://github.com/dockstore/dockstore/issues/2860

@ByteMap I wonder if this is the same issue we saw during your Friday demo? Maybe try #2896 a try locally to see if it addresses your problem.


linker: riscv: Disable creating ROM domain by config option.

Patch is useful for RISCV platforms which can not provide ROM memory.
Switching CONFIG_XIP to "n" disables allocating ROM region.
Signed-off-by: Vitaly Gaiduk<EMAIL_ADDRESS>

Codecov Report

Merging #10548 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10548   +/-   ##
=======================================
  Coverage   53.34%   53.34%
=======================================
  Files         210      210
  Lines       25825    25825
  Branches     5686     5686
=======================================
  Hits        13776    13776
  Misses       9734     9734
  Partials     2315     2315

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47bd922...0d1798e. Read the comment docs.


ci: lightwalletd tests fail with "could not read ScriptSig"

Motivation
Zebra's lightwalletd tests are currently failing with:

{"app":"lightwalletd","error":"error parsing block: parsing transaction 0: while parsing transparent input: could not read ScriptSig","height":1687104,"level":"warning","msg":"error zcashd getblock rpc","time":"2022-06-01T02:00:00Z"}
{"app":"lightwalletd","level":"fatal","msg":"unable to issue RPC call to zcashd node","time":"2022-06-01T02:00:00Z","timeouts":11}
https://github.com/ZcashFoundation/zebra/runs/6681266038?check_suite_focus=true#step:9:1437

It looks like https://github.com/adityapk00/lightwalletd has not been updated for NU5, so we need to switch our tests to another lightwalletd.
Designs
We could switch to the most up-to-date lightwalletd fork:
https://github.com/zcash/lightwalletd
Or we could temporarily disable these error messages.

It seems like main is still using adityapk00/lightwalletd, despite PR https://github.com/ZcashFoundation/zebra/pull/4553 :

{"app":"lightwalletd","error":"error parsing block: parsing transaction 0: while parsing transparent input: could not read ScriptSig","height":1687104,"level":"warning","msg":"error zcashd getblock rpc","time":"2022-06-04T08:33:12Z"}

https://github.com/ZcashFoundation/zebra/runs/6736917351?check_suite_focus=true#step:9:1154

This seems to be caused by:

When building the image, it fetches the lightwalletd docker image with the latest tag
The image with the latest tag is very old

So the issue can be:

We are not tagging the image with latest
Or we should be pointing to something other than latest

I manually retagged latest and I'm currently retrying some jobs to check if they work.

I created https://github.com/ZcashFoundation/zebra/issues/4590 to better track the issue


Game Adddition

Could you please add
Tales of Symphonia
Tales of Vesperia
Thank you!

I have added the game(s) you requested in the most recent release: https://github.com/hobby-grade/Nintendo-Switch-Discord-Status/releases/tag/v1.1.5
Thank you for checking out the project, reach out if you have any more suggestions!


DO NOT MERGE - Issue OBST-209. Add asciidoctor-default.css

Add asciidoctor-default.css style and
Change  document-attributes.adoc to use it :stylesheet: asciidoc-default.css

@ALRubinger @cmoulliard @edewit thoughts on changes here vs. the current style?

I'm a bit lost on these changes too. :)  Ultimately I think we need to devise a closer openshift.io look.  @cmoulliard mind explaining the motivations behind this one?  Or were ya just inspired? :D

The readability of the contents improved, but the branding elements (header, footer, etc) are broken (or disappeared)

are broken (or disappeared)

I will have a look.

mind explaining the motivations behind this one?

Such css styles are coming from my previous experience with GPTE team where we designed many courses, labs, .. content using asciidoctor. Open Sans font used by Pattern Fly is not great to render such course content. This is why I'm proposing as alternative to use the asciidoctor default css or foundation css.

@cmoulliard I agree that the styles you propose improve readability, but we need to recover the branding elements

@cmoulliard I think it's just the header that disappeared:

Header and footer enabled again for foundation.css and asciidoctor-default.css

👍 like it, good to merge

7093dd2 Still a ways to go I think, but the rendering here is a marked improvement; thanks all!


Unable to run genDrumkit

Describe the bug
A clear and concise description of what the bug is.
After install it, the command returns:

Traceback (most recent call last):
File "/usr/bin/genDrumkit", line 4, in
import('pkg_resources').run_script('genDrumkit==0.1.3', 'genDrumkit')
File "/usr/lib/python3.10/site-packages/pkg_resources/init.py", line 651, in run_script
self.require(requires)[0].run_script(script_name, ns)
File "/usr/lib/python3.10/site-packages/pkg_resources/init.py", line 1455, in run_script
exec(script_code, namespace, namespace)
File "/usr/lib/python3.10/site-packages/genDrumkit-0.1.3-py3.10.egg/EGG-INFO/scripts/genDrumkit", line 13, in
ModuleNotFoundError: No module named 'gen_drum_kit'

To Reproduce
Steps to reproduce the behavior:

Download source code
run python setup.py build
python sudo setup.py install
run genDrumkit

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

This is a known issue / missing feature:
So far the code has not been prepared for integration using python setup.py.
Work-around:
get code (git or download and unpack zip)
% cd .../src
% chmod +x genDrumkit
% ./genDrumkit --help

Oohh I see. So, how can I uninstall it/ undo setup.py?
Thanks!

To be honest, no idea at the moment.
Probably best option is to find it in the file system and wipe it manually with "sudo rm -r" (use with care!!!)
On the other hand, it should not take to much disk space ...
Will take some time to implement proper installation due to current lack of knowledge on my side. :-(

disabled existing setup (which was incomplete) so no-one else will run into the problem

Probably best option is to find it in the file system and wipe it manually with "sudo rm -r" (use with care!!!)

this did the job!

❯ sudo pip uninstall genDrumkit
Found existing installation: genDrumkit 0.1.3
Uninstalling genDrumkit-0.1.3:
Would remove:
/usr/bin/genDrumkit
/usr/lib/python3.10/site-packages/genDrumkit-0.1.3-py3.10.egg
Proceed (y/n)? y
Successfully uninstalled genDrumkit-0.1.3

Great! Thanks! Will try it directly from the downloaded dir and reach you if I have more questions!
Thanks for your help and the package as well!

Ah, thanks for the info! Learned something new today

... and keep in mind, taking into consideration the lack of specs (-> reverse engineering), the complexity of the task, and my certainly limited knowledge I would expect further issues. Though I did run it on all Hydrogen kits I have around.
It might be necessary to tweak the generated xml files with an editor to make it run on Drumgizmo


[loc][Query][msbuild] Localizability of 0; "ImportedProjectNotFound"

Hi,
please help localization team to answer question from translator.
In case translator is not sure about context/meaning/localizability of string we raise a question.
Source:
MSB4019: The imported project "{0}" was not found. Confirm that the expression in the Import declaration "{1}" is correct, and that the file exists on disk.
File Name:
Build\Resources\xlf\Strings.xlf
==========================================
Query:
According to the DevComment, <Import> should not be localized.
Does it refer to "Import" of "the Import declaration" in this source?
Could you please confirm?

@PDostalek I edited your post to put ` characters around <Import>; if you don't do that, GitHub-flavored Markdown hides the text inside the <>.

That instruction is intended to read as

Don't localize the word Import in the Import declaration; it refers to an XML attribute.

Thanks for clarification


Provide version env var in changelog-entry action

Fixes #1847
TODO:

[x] Write new tests or update the old ones to cover new functionality.
[x] Update doc-strings where appropriate.
[ ] Update or write new documentation in packit/packit.dev.

RELEASE NOTES BEGIN
Packit now provides PACKIT_PROJECT_VERSION  environment variable when running changelog-entry action.
RELEASE NOTES END

recheck


GHC 8.0.2: use -split-sections

See the commit for more information.
cc @peti, I haven't tested much (built stack and darcs) but upstream did quite some testing.

@peti rebased.

Will you pick up this PR? It's a really nice feature and I'd love to have it in before we're forking off a new release branch.

Yes will do. Planning to clean this up very soon.

cc @peti ready for review :)


Gulp task package refactored into multiple tasks

@dgolovin, @jrichter1 please review and merge if everything is OK.

Rebased

Updated and rebased

I'm getting the following error from 'unzip-7zip-extra' when running a package task.
Error: Command failed: C:\WINDOWS\system32\cmd.exe /s /c "C:\Users\jbossqa\Downloads\developer-platform-install\dist\win\7za.exe e C:\Users\jbossqa\Downloads\developer-platform-install\dist\win\7z920_extra.7z -oC:\Users\jbossqa\Downloads\developer-platform-install\dist\win -y 7zS.sfx"
'C:\Users\jbossqa\Downloads\developer-platform-install\dist\win\7za.exe' is not recognized as an internal or external command,
operable program or batch file.
at ChildProcess.exithandler (child_process.js:203:12)
at emitTwo (events.js:87:13)
at ChildProcess.emit (events.js:172:7)
at maybeClose (internal/child_process.js:818:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)

[12:37:24] Error in plugin 'run-sequence'
Message:
An error occured in task 'unzip-7zip-extra'.

Fixed

A wild error has appeared:
Creating C:\Users\jbossqa\Downloads\developer-platform-install\dist\win\DeveloperPlatformInstaller-win32-x64-0.0.2.exe
[13:09:17] 'package' errored after 347 μs
[13:09:17] ReferenceError: cmd is not defined
at Gulp. (C:\Users\jbossqa\Downloads\developer-platform-install\gulpfile.js:120:8)

Fixed

Pushed to master.


Remove boot/firmware paths

After was merged now it's possible to remove boot/firmware paths files.
See https://github.com/ros-realtime/ros-realtime-rpi4-image/blob/master/focal-rt-ros2/rootfs/setup/phase1.sh#L41

@LanderU @shuhaowu Was this completed?


⚠ SkipTheCommericals has degraded performance

In 1f3f94b, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 17121 ms

Resolved: SkipTheCommericals performance has improved in da67487.


[Release-1.8] Update common-files

Signed-off-by: gargnupur<EMAIL_ADDRESS>[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@gargnupur: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.8
ac3dc9a45ebae476619603638be5288b87d94f8a
link
/test release-notes_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Returning Duplicate Neighbors

It's weird, but I get completely different results when running the first example of the documentation:
import numpy as np
from voyager import Index, Space

# Create an empty Index object that can store vectors:
index = Index(Space.Euclidean, num_dimensions=5)
id_a = index.add_item([1, 2, 3, 4, 5])
id_b = index.add_item([6, 7, 8, 9, 10])

print(id_a)  # => 0
print(id_b)  # => 1

# Find the two closest elements:
neighbors, distances = index.query([1, 2, 3, 4, 5], k=2)
print(neighbors)  # => [0, 1]
print(distances)  # => [0.0, 125.0]

0
1
[0 0]
[0. 0.]

It seems when querying, a neighbor is being considered more than once.
My device is Mac M1Pro, Python 3.12.

Hi! thanks for reporting this. I was able to reproduce.
We just released version v2.0.7, the issue is now solved. You should get the expected behaviour, as in the documentation. If not feel free to reopen the issue.


Do not try to copy python

Apologies for the spam, I thought I was making this against my own fork.


feat: add medium and large sizes to testimonial

Add medium and large sizes to testimonial
The testimonial component will be able to be rendered in a medium and large size, to better support longer quote content.
Abstract Reference:

Components:

Merging your changes
When you are ready to merge to master, use the "squash and merge" button in GitHub, and follow the commit message guide to write your commit message.

📬Published Alpha Packages<EMAIL_ADDRESS>
📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5e7b672ed0633101cd9fb4f9--codecademy-styleguide.netlify.comDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5e7b6e1d1d92a101b0d8626b--codecademy-styleguide.netlify.comDeploy Logs


feat: add demo project for the ease of use

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Demo project is added and it can be run by yarn run demo. This library's, so called, how-to guidance are commented.
I hope that first comers will get helped by this demo.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

If you need a general guide, the readme should complement it.


Update gRPC version.

This allows option php_namespace to be recognized.

Do we know why this has turned up as a problem now, rather than much earlier? There are many APIs in googleapis that have the php_namespace option, and have done for several months.

Do we know why this has turned up as a problem now, rather than much earlier? There are many APIs in googleapis that have the php_namespace option, and have done for several months.

My guess is that we never tried to build any of them in Python or Ruby. :-)

My guess is that we never tried to build any of them in Python or Ruby. :-)

That could be true... but Spanner, Pubsub, Logging, Firestore, Monitoring, Error reporting, Video Intelligence and Trace have all had this option for 4 months. There are also the new APIs like DataTransfer, which have had it almost since the proto was open sourced.

It is possible, although I would expect this to affect artman.
Let me double-check this fix. :-)

I agree with Luke's assessment, that I would expect this to affect artman as well, although I am not positive.
I would also note that artman uses protoc/protobuf in some funny ways. For example, the function here gets the protobuf path using a gradle task in toolkit - I can see there being a strange interaction between having different versions of protoc CLI and toolkit gradle protobuf library.
https://github.com/googleapis/artman/blob/master/artman/utils/protoc_utils.py#L341

I agree with Luke's assessment, that I would expect this to affect artman as well, although I am not positive.

We just did testing on our side, and with the PR it works. I think this should belong in one of the great mysteries of the universe (at least for now).

I would also note that artman uses protoc/protobuf in some funny ways. For example, the function here gets the protobuf path using a gradle task in toolkit - I can see there being a strange interaction between having different versions of protoc CLI and toolkit gradle protobuf library.

It also uses grpcio-tools and grpc-tools in Python and Ruby, respectively, which I am fairly certain bundle their own protobuf versions.


Add python linter

@aakarshg suggested adding a linter and it is a good practice to use linters to improve the code quality. We need to enable it for every pull request using a CI like travis.

Fixed by https://github.com/openshift-scale/cerberus/pull/7. Thanks @aakarshg.


The significance of the Cubic Hermitian split

Thank you for open-source this amazing work. I'm a bit confused. May I ask why we need to perform Cubic Hermitian spline on the attitude trajectory? How much does Cubic Hermitian spline improve the accuracy of the system

Hello @wuming122333 ,
thanks for your interest.
Cubic Hermitian spline interpolation was only used for the translational part of the trajectory.
For the orientational part (attitude) slerp is used.
As noted in the README here, instead of Cubic Hermitian splines in the open source code Barycentric Rational Interpolation is used for the translational part (due to the license conditions).
The type of interpolation can significantly influence the quality of the estimated trajectory in the case of high-frequency movements. Therefore, this type of interpolation makes sense for handheld systems, but is less important for data from car roof-mounted scanners.
Best regards
David


Fix isoTimestamp regex

To allow timezones
Closes #500

This is a duplicate of #496. Feel free to add a review to this PR.


add foundational_skills to taxonomy folders

Updated TAXONOMY_FOLDERS to include 'foundational_skills' to enable sdg parsing and generation of freeform skills
fixes: https://github.com/instructlab/sdg/issues/247

I see foundational skills was ditched in latest taxonomy


Replace csvkit with agate

[x] remove csvkit dep
[x] return tablular data as agate dataframes
[x] make dbt seed use agate + csv modules for reading csv files

This is going out in 0.9.2

Replaced by agate
https://github.com/fishtown-analytics/dbt/pull/665
https://github.com/fishtown-analytics/dbt/pull/618

@drewbanin that's great news, thanks!  I'll be able to run dbt along with all my other pip packages now in a single virtualenv, now that the csvkit dependency is removed.

@haylo75 awesome!


Remove id and source column, optimize data writing & components

This PR implements a couple of optimizations. Probably too many at once. We can split them if we want to take the time for this.

Refactor the DataWriter class to only call compute() once.
Remove the id and source column and let the user work with the dataframe index directly. The separate columns were giving too many issues without benefits. It was not clear when the uid column should be rebuild and reset, which led to every component both resetting and rebuilding it.
Make querying the clip client concurrent. This was taking a long time before, since each request was handled sequentially. We should do the same for the image downloading component.
Use LAION ids.
Pass the ids in the captioning component so the resulting captions are linked to the original ids. I'm not sure that the captions were being linked to the correct images in the previous implementation. Not too happy with my current implementation though, this should be cleaned up.

Split into #157 #159 #168


Failed to build VS solution

This is with the latest source.
$ cmake -G "Visual Studio 12 Win64" .
CMake Error: Could not create named generator Visual Studio 12 Win64
Generators
Unix Makefiles               = Generates standard UNIX makefiles.
Ninja                        = Generates build.ninja files.
CodeBlocks - Ninja           = Generates CodeBlocks project files.
CodeBlocks - Unix Makefiles  = Generates CodeBlocks project files.
CodeLite - Ninja             = Generates CodeLite project files.
CodeLite - Unix Makefiles    = Generates CodeLite project files.
Eclipse CDT4 - Ninja         = Generates Eclipse CDT 4.0 project files.
Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files.
KDevelop3                    = Generates KDevelop 3 project files.
KDevelop3 - Unix Makefiles   = Generates KDevelop 3 project files.
Kate - Ninja                 = Generates Kate project files.
Kate - Unix Makefiles        = Generates Kate project files.
Sublime Text 2 - Ninja       = Generates Sublime Text 2 project files.
Sublime Text 2 - Unix Makefiles
= Generates Sublime Text 2 project files.

Try "Visual Studio 12 2013 Win64".

Also note that according to the wiki, VS does not support the ("AT&T") syntax used in the assembler mnemonics so most optimization will not be available in the VS build. (Supposedly "gcc -S -masm=intel" or "llvm-mc-3.2 -x86-asm-syntax=intel" can be used to convert to Intel syntax, but this would have to be done for a large fraction of the code and with appropriate #ifdef's so as not to break other platforms.)

Thanks for the quick turnaround,

It's your cmake cannot detect VS2013, not OpenBLAS's fault.

Do you know how to make cmake detect visual studio?

Thanks guys, I was doing this on cygwin, it seems to have worked now that I moved over to powershell.


support private registry authenticate

support private registry authenticate & images
code happy !
: ）

Cool! +1

Shipyard v3 has been released and is a major refactor. Could you please do a fresh checkout and rebase?  Thanks!

roger

:+1:

Closing as this has been inactive.  Please open a new PR if you want to add this.  Thanks!


Message events

See http://forum.espruino.com/conversations/379866/

Emit "message" events for incoming messages.
Allow event handlers to prevent default app from loading.
Add setting to hide default widget, meant for people who want to install custom widgets.
Move buzz() from the widget to the library.

Thanks! Nice idea moving the buzz logic out of the widget draw function


Responsive Handler Bug will give large screen for all screen types

https://github.com/jfoenixadmin/JFoenix/blob/f80f126043cb61142d6316f3b8549071c4abfce3/jfoenix/src/main/java/com/jfoenix/responsive/JFXResponsiveHandler.java#L64
As you can see it just ignores whatever the user passed as pseudo-class.

Thanks for pointing out the issue 👍


BUG: loglaplace moment should be non-negative.

The current implementation of scipy.stats.loglaplace.moments incorrectly returns a negative number when the requested moment does not exist. This commit fixes this bug and correctly returns np.inf instead.
A test case is added for parameter combinations that lead to non-finite moments. Non-central moment is allowed to return inf or nan as it is not well-defined when a lower-order non-central moment is non-finite.
The generic stats() implementation is updated to suppress floating point warnings caused by (inf-inf) operation.

Reference issue
Closes gh-20001.
What does this implement/fix?
Return np.inf when the moment doesn't exist for certain parameter combinations.
Additional information

Thanks for quick action!


can'n save changes of stored procedure

create a stored procedure
open it for edit, change  sql ddl of this procedure and press save button[disk icon in toolbar],but the change of this stored procedure not saved to database ,error log is flowing:
null org.jkiss.dbeaver.model Error Sat Feb 20 23:01:43 CST 2016 org.eclipse.swt.SWTException: Invalid thread access
dbeaver 3.5.9  MySQL [5.5.5-10.0.15-MariaDB] mysql-connector is 5.1.38 or mariadb java-client 1.35

Duplicate of #174

get it