Company name changes - update in Orgbook test required

Hi,
MOTI has completed some test company name changes on the following BC corporations which have had name changes completed in COLIN:
Company 1 new name: 0879839 B.C. LTD.
Company 1 Incorporation number: BC0879839
Company 2 new name: 0879833 B.C. LTD.
Company 2 Incorporation number: BC0879833
This is a high priority for us as we're testing a major bug in our public facing application.

@amanji can you take this please.  Note the high priority.
@esune — FYI.


Auto deploy on AWS

Finally! Note that cache invalidations are not automatic.

awesome, thanks! will merge #29 and release a patch version so we can see if it's working...
Sending you an invite to be a collaborator on the repo btw — totally up to you if you want that or not :)

Hmm... seems that something is failing? packd.now.sh is at 2.5.1, bundle.run is still on 2.5.0

Yes awesome, thanks.


ConstEval depends unconditionaly on the VMVX driver

The target ConstEval runtime (iree::compiler::ConstEval::Runtime) unconditionally depends on the VMVX HAL driver:
https://github.com/google/iree/blob/0916baf04b08f5125ee6b9de65d0e9a11365a9b8/iree/compiler/ConstEval/CMakeLists.txt#L77
Trying to build IREE with
 -DIREE_HAL_DRIVER_DEFAULTS=OFF
 -DIREE_HAL_DRIVER_VMVX_SYNC=ON

hence fails (even though not the only error at the moment).

We should always have the vmvx build rules be available (remove the if's from the build/cmake files).

Yep, that dep is by design.
A few options

Make it conditional, so the compiler pass -iree-consteval-jit-globals would not be available if the VMVX HAL driver was not included in the build
If the compiler is enabled, enable the VMVX HAL driver
Always enable the VMVX HAL driver (change it from an option that can be turned off to a variable that is always on?)

Ben, you vote for option 3?

2 or 3, maybe 2 - the intent of the IREE_HAL_DRIVER flags are to control what gets pulled into the default runtime builds via iree/hal/drivers/init.h. The fact that it also entirely removes the build rules for registration is just for people who build :all so that it wouldn't build cuda on bare metal and such. But if in a cmake configuration you're building the compiler you've definitely got support for what VMVX needs and it has zero additional deps so having the rule around is harmless.
I still don't like any of this (vmvx is just a loader for the local CPU backend) but 2 feels like the easiest workaround - I'd probably just change the vmvx/registration/ cmakelist to be IREE_HAL_DRIVER_VMVX || IREE_BUILD_COMPILER.

We always need a reference implementation that the compiler can use: otherwise, in the limit, there is no clear backend that is always suitable, although host codegen can be considered.
I think Ben and I are suggesting a different option: always leave the build rules for it but don't include them in the runtime. The const-eval stuff instantiates it's driver explicitly with an explicit dep. Those options primarily control what is built in to the tools/apis. Different things.

I don't think it's an issue in this case, but we can leave the build rules and exclude from all.

oo I like that - forgot about EXCLUDE_FROM_ALL - the fewer conditional rules the better!

Here's my interpretation of that fourth option:
Make these always available (or gated on IREE_BUILD_COMPILER), maybe add some EXCLUDE_FROM_ALL?
https://github.com/google/iree/blob/0916baf04b08f5125ee6b9de65d0e9a11365a9b8/iree/hal/vmvx/registration/CMakeLists.txt#L13-L21
Then keep these checks?
https://github.com/google/iree/blob/0916baf04b08f5125ee6b9de65d0e9a11365a9b8/iree/hal/drivers/CMakeLists.txt#L19-L24
Anything explicitly depending on the registration (and not using iree_hal_register_all_available_drivers) can continue to do so.

yeah - I think having them always there with EXCLUDE_FROM_ALL is good - there's no real reason to build them with :all as they'll get pulled in by the drivers/init if enabled and built there

I noticed this issue while documenting how to build the compiler for our bare-metal use-case: https://github.com/iml130/iree-bare-metal-arm#option-a-build-iree. I actually think always building the VMVX HAL driver is fine, even though the VMVX_SYNC driver would be sufficient for our use-case. Anyway, I clearly see that there should be a reference pass, but I dislike the error a users currently sees (it is unclear that why it has to be enabled). So gating this on IREE_BUILD_COMPILER or adding EXCLUDE_FROM_ALL sounds good (when opening the issue I just wasn't sure what would be a desired fix).

makes sense! I wholeheartedly agree that the crossing of the streams of compiler/runtime with the flag is confusing to users so if we can make that cut I think we'll be in a better place. Thanks for raising this issue :)


some readme additions

Signed-off-by: Matthias Luebken<EMAIL_ADDRESS>Description of your changes
Some readme additions:

Link to the right provider image
Link to the API token
Example on how to query the status of the cluster

Fixes #
I have:

[x] Read and followed Crossplane's contribution process.
[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Thanks for the contributions @luebken


Issue with denied routes in custom-server-express example

I have a page with url denied in server.js (I should see the content of the _error page instead of the original "post.js" content), but when I access this url, the _error content is almost instantly rerendered by the original "post.js" content. Is there any way how to avoid this strange behavior?

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

After visitng localhost:3000/post url without additional parameter the server should post content of the custom _error.js page. (This behavior is standart in next v. 3.0.1)

Current Behavior

The _error page is loaded, but almost instantly rerendered with post.js content. This behavior happens on next v. 3.0.2 and later.

Steps to Reproduce (for bugs)

Download or clone this repo https://github.com/josefkrajkar/custom-express-server
Install dependencies npm install
Run the dev server with command npm run dev
Visit the localhost:3000/post in your browser

Your Environment

Tech
Version

next
3.0.2

node
8.1.3

OS
MacOs Sierra 10.12.6

browser
Google Chrome 61.0.3163.100

Commit with the solution: https://github.com/josefkrajkar/custom-express-server/commit/e725d63b6f38dfe87ed93390d76e7e0555f51b6c


feat(frontend): filter menu options on Settings page

Motivation
The menu option "Your addresses" does not work on the "Settings" page. Moreover, display a "Settings" link in the menu on the "Settings" page does no add much value. Therefore this PR filters the options displayed in the menu when the user visit the "Settings" page.
Changes

Refactor options related to the wallet from the menu in a new component MenuWallet
Do not display wallet options and "Settings" option in the menu when user visit the "Settings" page

Screenshot
This option does not work:

Shall we maybe add "your addresses" somewhere among the settings? Ultimately they will become User Profile anyway...

Let's see if "Settings" remains just settings or becomes also a profile page I would say. Maybe those will be two different pages?


Fixes Links In Docs Page

Just a few fixes in the links at the bottom of Connect: Extracting Data with mapStateToProps docs page.

Thanks!


Potential security threat

Security issue
The access token generation function for the Safaricom API in src/middleware/generateAccessToken.js seems to be functional, but there are a few improvements that could be made to enhance its security.
Expected Behavior
The function should validate the inputs for the Safaricom API credentials,
     process.env.SAFARICOM_CONSUMER_KEY

and
     process.env.SAFARICOM_CONSUMER_SECRET

both should be validated before they are used. This will help to prevent potential security vulnerabilities such as injecting malicious code.
Current Behavior
The inputs for the Safaricom API credentials are not being validated
Failure Information (for bugs)
Steps to Reproduce

Call the accessToken function
Observe the behaviour of the inputs from the Safaricom API credentials

Thank you chief. Will look into that @barakadanny


[PopOver] Fix Animation vertical

[ ] PR has tests / docs demo, and is linted.
[ ] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Fixes the popover animation origin issue.
Animation starts from the point of click.
Closes : #4219
Current Issue:

Fix:

Also, the popover position looks alright to me, it scrolls correctly and closes when it should. @mbrookes  and I were discussing it.Updating the react-event-listner solves the issue.

@mbrookes and I were discussing it.

Not me I don't think.
Apart from anything else:
"For inline display, such as on a form, consider using compact controls such as segmented dropdown buttons".
https://www.google.com/design/spec/components/pickers.html

@mbrookes
I wonder if us terming it inline is somewhat deceiving -- especially since it isn't any more inline than the dialog version. The Popover is still rendering through a portal in the html document and breaking out of the document flow.
I wouldn't call our popover version of the datepicker "inline" -- but maybe that's just me. Stick an overlay style on the popover layer and you've pretty much got a dialog 😄

I don't think whatever inline should be called is a particularly useful feature as it stands. If it were me, I'd deprecate it in favour of an actual inline picker, rather than trying to fix it.

@mbrookes me neither... and as long as DatePicker isn't crazy rigid, there's no reason people can't implement it the way we instruct people to implement menu if they really want it in a popover -- right? (using Popover).

Not me I don't think.

@mbrookes : I was talking about the weird scrolling issue which we were discussing on Saturday.
So what are we going to do about the inline thing? Are we keeping it as is or are we going to go with something new? The reason I am asking is because then I will temporarily halt my work on the inline-timepicker as well.

@mbrookes @tintin1343
What shall we do what shall we do? 😄

@tintin1343 in this PR does vertical expanding still work the other way?

No, it changes it. Unfortunately the changed version is also broken. See: https://github.com/callemall/material-ui/pull/4222#issuecomment-218120174

@tintin1343 closing for now. Feel free to reopen if you have another chance to look at it and still feel it's worth pursuing given that inline DatePicker in it's current form is not optimal.


fix(DDI-1256): Make the form stepper focus on safari

Description
In Safari on the MacOS, focus (the yellow border around an element) is not visible when clicking on a step, using the Stepper component.
Task
https://goa-dio.atlassian.net/browse/DDIDS-1256
Changes

Add :focus and :active css to make the outline visible.

Reference: https://developer.mozilla.org/en-US/docs/Web/CSS/:active (for active)
https://developer.mozilla.org/en-US/docs/Web/CSS/:focus
Screenshot
https://user-images.githubusercontent.com/120135417/228637987-13f7cb73-5d81-417d-b504-adc14b482f12.mov

:tada: This PR is included in version 4.0.0-alpha.133 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.172 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-alpha.17 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.21 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Is API key needed

From the examples, it gets weather data without API key.

The webpage definitely says that.  I've never used it and I've never had an issue not using one either.  I'll dig a bit further into it to be safe.

Thanks for your reply. I use below to get data
func (this *WeatherModel) Get(city string) (*owm.ForecastWeatherData, error) {
    var days int = 2
    w, err := owm.NewForecast("C", "zh_cn")
    if err != nil {
        goto fail
    }

    err = w.DailyByName(city, days)
    if err != nil {
        goto fail
    }

    return w, nil

fail:
    return nil, err
}

The response is like
{
    "data": {
        "list": {
            "cod": "200",
            "message": 0.0632,
            "city": {
                "id": 1795565,
                "name": "Shenzhen",
                "coord": {
                    "lon": 114.068298,
                    "lat": 22.54554
                },
                "country": "CN",
                "population": 0,
                "sys": {
                    "population": 0
                }
            },
            "cnt": 2,
            "list": [
                {
                    "dt":<PHONE_NUMBER>,
                    "temp": {
                        "day": 303.59,
                        "min": 300.26,
                        "max": 304.79,
                        "night": 300.26,
                        "eve": 303.52,
                        "morn": 300.91
                    },
                    "pressure": 1019.01,
                    "humidity": 68,
                    "weather": [
                        {
                            "id": 803,
                            "main": "Clouds",
                            "description": "多云",
                            "icon": "04d"
                        }
                    ],
                    "speed": 5.11,
                    "deg": 189,
                    "clouds": 56,
                    "snow": 0,
                    "rain": 0
                },
                {
                    "dt":<PHONE_NUMBER>,
                    "temp": {
                        "day": 300.49,
                        "min": 297.93,
                        "max": 300.49,
                        "night": 297.93,
                        "eve": 298.72,
                        "morn": 299.68
                    },
                    "pressure": 1009.01,
                    "humidity": 0,
                    "weather": [
                        {
                            "id": 503,
                            "main": "Rain",
                            "description": "大雨",
                            "icon": "10d"
                        }
                    ],
                    "speed": 4.85,
                    "deg": 190,
                    "clouds": 21,
                    "snow": 0,
                    "rain": 52.44
                }
            ],
            "Unit": "C",
            "Lang": "ZH_CN"
        }
    },
    "msg": "获取成功",
    "success": true
}

The temperature is a little strange. Should it be divided by 10?
I change the unit to F to make another request, but the response is exactly the same as above. It seems that the unit not works.

I'm on my phone and not near a computer but from what I can tell this might be an overarching bug you've found. I can verify and fix in a few hours. You're more than welcome to patch, test, and submit a pull request if you'd like.

fix in #21.


Hosting Helm chart repository in GitHub Pages.

Changes:

Created Helm chart repository that is hosted in out GitHub Pages.
Updated docs/deploy/howto-deploy-helm.md with details about consuming from new Helm chart repository.
Updated docs/dev-guides/howto-release-helm-chart.md with details about publishing to new Helm chart repository.
Minor fix in docs/manual/readme.md.

Let's add a recommendation to use the one from GitHub Pages in our docs.

Let's add a recommendation to use the one from GitHub Pages in our docs.

Added recommendation to use new Helm chart repository.


Graphics.lineTo padding bounds in some cases

https://codepen.io/staff0rd/pen/rrRdpj?editors=0010

Each of the above is a Graphics.drawCircle inside a container, with a sprite placed behind it equal to the bounds of the Container.  When including a line that touches any bound of the circle, the bounds are increased transparently.  I would expect all, except the last, to have the same bounds as the first and sixth(!) image.  For the last image, I would expect the width to be the width of the circle plus half the width of the line.

Fixed by #3234


Minor edits from review of Enum docs

Change Summary

Related issue number
Closes PYD-69
Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review


#136 RqHeaders must be an interface

Refactored RqHeaders

@longtimeago @davvd  I recreated pull request #191

@lauresh Let me find a reviewer for this pull request, thanks for submitting it

@longtimeago it's yours, please review

@rultor merge pls

@rultor merge pls

@longtimeago Thanks for your request. @yegor256 Please confirm this.

@rultor merge this

@rultor merge this

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge this

@yegor256 Oops, I failed. You can see the full log here (spent 2min)
+ git config user.email<EMAIL_ADDRESS>+ git config user.name rultor
+ '[' -z 'sudo locale-gen en_US en_US.UTF-8' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'sudo locale-gen en_US en_US.UTF-8' ';' 'sudo dpkg-reconfigure locales' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'sudo gem install --no-rdoc --no-ri pdd' ';' 'version=$(curl -K ../curl-appveyor.cfg --data "{accountName: '\''yegor256'\'', projectSlug: '\''takes'\'', pullRequestId: '\''${pull_id}'\''}" https://ci.appveyor.com/api/builds | jq -r '\''.version'\'')' ';' 'while true' ';' 'do status=$(curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/${version} | jq -r '\''.build.status'\'')' ';' 'if [ "${status}" == "null" ]; then exit 1; fi' ';' 'if [ "${status}" == "success" ]; then break; fi' ';' 'if [ "${status}" == "failed" ]; then echo "see https://ci.appveyor.com/project/yegor256/takes/build/${version}"; exit 1; fi' ';' 'echo "waiting for AppVeyor build ${version}: ${status}"' ';' 'sleep 5s' ';' done ';' 'mvn clean install -Ptakes -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean site -Psite --errors --settings ../settings.xml' ';' 'mvn clean' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';'
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
Version: SKS 1.1.5
gpg: armor header:
Comment: Hostname: keys.exosphere.de
gpg: armor header:
gpg: pub  2048R/9AF0FA4C 2014-08-17  Rultor.com<EMAIL_ADDRESS>gpg: key 9AF0FA4C: "Rultor.com<EMAIL_ADDRESS>not changed
gpg: Total number processed: 1
gpg:              unchanged: 1
++ pwd
++ pwd
+ gpg --verbose --keyring=/tmp/rultor-kUcK/.gpg/pubring.gpg --secret-keyring=/tmp/rultor-kUcK/.gpg/secring.gpg --decrypt repo/curl-appveyor.cfg.asc
Version: GnuPG v1
gpg: armor header:
gpg: public key is 9A839C3A
gpg: using subkey 9A839C3A instead of primary key 9AF0FA4C
gpg: using subkey 9A839C3A instead of primary key 9AF0FA4C
gpg: encrypted with 2048-bit RSA key, ID 9A839C3A, created 2014-08-17
      "Rultor.com<EMAIL_ADDRESS>gpg: AES256 encrypted data
gpg: original file name='curl-appveyor.cfg.enc'
+ gpg --no-tty --batch --verbose --decrypt --passphrase rultor-key:yegor256/takes curl-appveyor.cfg.enc
Version: GnuPG v1
gpg: armor header:
gpg: CAST5 encrypted data
gpg: encrypted with 1 passphrase
gpg: original file name='curl-appveyor.cfg'
gpg: WARNING: message was not integrity protected
+ rm -rf curl-appveyor.cfg.enc
+ rm -rf .gpg
+ cd repo
+ git remote add fork git@github.com:lauresh/takes.git
+ git remote update
Fetching origin
Fetching fork
From github.com:lauresh/takes
 * [new branch]      136        -> fork/136
 * [new branch]      gh-pages   -> fork/gh-pages
 * [new branch]      master     -> fork/master
 * [new branch]      n136       -> fork/n136
+ '[' false == true ']'
+ git merge fork/n136
Auto-merging src/main/java/org/takes/rq/RqMultipart.java
Auto-merging src/main/java/org/takes/rq/RqPrint.java
CONFLICT (content): Merge conflict in src/main/java/org/takes/rq/RqPrint.java
Auto-merging src/test/java/org/takes/rq/RqMultipartTest.java
CONFLICT (content): Merge conflict in src/test/java/org/takes/rq/RqMultipartTest.java
Automatic merge failed; fix conflicts and then commit the result.

@lauresh please merge from master

@longtimeago merged

@rultor merge please

@rultor merge please

@longtimeago Thanks for your request. @yegor256 Please confirm this.

@rultor try to merge

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge

@yegor256 Oops, I failed. You can see the full log here (spent 8min)
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/747
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
waiting for AppVeyor build 747: running
+ echo 'waiting for AppVeyor build 747: running'
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/747
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 747: running'
+ sleep 5s
waiting for AppVeyor build 747: running
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/747
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 747: running'
+ sleep 5s
waiting for AppVeyor build 747: running
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/747
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 747: running'
+ sleep 5s
waiting for AppVeyor build 747: running
+ true
++ jq -r .build.status
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/747
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 747: running'
+ sleep 5s
waiting for AppVeyor build 747: running
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/747
++ jq -r .build.status
+ status=failed
+ '[' failed == null ']'
+ '[' failed == success ']'
+ '[' failed == failed ']'
+ echo 'see https://ci.appveyor.com/project/yegor256/takes/build/747'
+ exit 1
see https://ci.appveyor.com/project/yegor256/takes/build/747

@rultor merge please

@rultor merge please

@longtimeago Thanks for your request. @yegor256 Please confirm this.

@yegor256 can we try to merge again?

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 9min)

@elenavolokhova please, let us know what do you think about this ticket, according to our QA rules

@rultor please deploy

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor please deploy

@davvd Oops, I failed. You can see the full log here (spent 6min)
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/857
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 857: running'
+ sleep 5s
waiting for AppVeyor build 857: running
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/857
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 857: running'
+ sleep 5s
waiting for AppVeyor build 857: running
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/857
++ jq -r .build.status
waiting for AppVeyor build 857: running
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 857: running'
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/857
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 857: running'
+ sleep 5s
waiting for AppVeyor build 857: running
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/857
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 857: running'
+ sleep 5s
waiting for AppVeyor build 857: running
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/857
++ jq -r .build.status
+ status=failed
+ '[' failed == null ']'
+ '[' failed == success ']'
+ '[' failed == failed ']'
+ echo 'see https://ci.appveyor.com/project/yegor256/takes/build/857'
+ exit 1
see https://ci.appveyor.com/project/yegor256/takes/build/857

@longtimeago

Please ask @lauresh to add the link to original issue to description, explain what was done in this PR.
No issues were found in this PR. Try to find at least three issues next time.

@
elenavolokhova https://github.com/elenavolokhova I'll try next time
2015-05-04 10:32 GMT+02:00 ElenaV<EMAIL_ADDRESS>
@longtimeago https://github.com/longtimeago

Please ask @lauresh https://github.com/lauresh to add the link to
original issue to description, explain what was done in this PR.
No issues were found in this PR. Try to find at least three issues
next time.

—
Reply to this email directly or view it on GitHub
https://github.com/yegor256/takes/pull/193#issuecomment-98634045.

--
С уважением,
Павел

@elenavolokhova
#136
https://github.com/yegor256/takes/issues/136

@lauresh
According to our quality rules:

Pull request description explains the solution proposed and contains a link to the original ticket it is related to.

Pull request must briefly explain what was done in the branch, so that we can use this information later, for traceability. Please update the description itself with the link and more meaningful explanation about fix. It is not convenient to read all conversation here to find the link in the last comment.

@elenavolokhova description:
Problem described in ticket #136 :
RqHeaders must be an interface and its implementation must be in its nested class RqHeaders.Base.
Solution:
RqHeaders now is interface, and its implementation now in nested class RqHeaders.Base. It is no behaving changes.

@YamStranger Thank you.

@davvd Quality is acceptable

@davvd Quality is acceptable

@elenavolokhova thanks, got it. everybody, please try to make it good next time

@longtimeago I added 10 mins to @elenavolokhova (for QA review) in transaction 57186578. Thanks a lot, I just topped your account for 21 mins, transaction ID 57186588, total time was 192 hours and 45 mins. you're getting extra minutes here (c=6). +21 added to your rating, current score is: +4474


No Rules for checklist.conf

New configuration file for 6.5 checklist.conf is not supported by VIM Syntax.

Also missing from etc/apps/splunk_monitoring_console/README/
dmc_alerts.conf
splunk_monitoring_console_assets.conf

Yes, but I have it on Great Authority, don't touch those :D

See commit 0d725d5a622f6770a1aeda6c372fe06dbcd73c8e


Various fixes for MTC feed merge

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
This PR fixes some issues with how the GTFS+ file directions.txt was being handled in an MTC merge (and updates the test accordingly). It also fixes the handling of stops where stop_code is being used as the primary key (an MTC requirement), but there is no stop_code provided for a certain stop. In this case, it should default to stop_id and skip stops that have already been included. The previous behavior was intended to do this, but was including all stops with a modified/prefixed stop_id.
It also bumps gtfs-lib to 4.3.6

Codecov Report

Merging #205 into dev will increase coverage by 0.47%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                dev     #205      +/-   ##
============================================
+ Coverage     16.94%   17.42%   +0.47%
- Complexity      309      311       +2
============================================
  Files           146      146
  Lines          7357     7358       +1
  Branches        982      982
============================================
+ Hits           1247     1282      +35
+ Misses         6000     5966      -34
  Partials        110      110

Impacted Files
Coverage Δ
Complexity Δ

...conveyal/datatools/manager/jobs/MergeFeedsJob.java
71.51% <0%> (ø)
76 <0> (-1)
:arrow_down:

...eyal/datatools/manager/gtfsplus/GtfsPlusTable.java
96.29% <100%> (+96.29%)
1 <0> (+1)
:arrow_up:

...va/com/conveyal/datatools/manager/DataManager.java
64.51% <0%> (+1.07%)
33% <0%> (-1%)
:arrow_down:

...atools/manager/extensions/mtc/MtcFeedResource.java
6.54% <0%> (+6.54%)
3% <0%> (+3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b36529...1169a5a. Read the comment docs.

@evansiroky, I'm merging in order to trigger an s3 deploy, but this still needs a proper review.

🙏

:tada: This PR is included in version 3.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Updated Swift 4

@aashishtamsya can I use your branch for swift 4 support? or it must be merged before?

Yes @mickychen0524 you can use that.

@aashishtamsya can you provide the url?

Hello I also need it for Swift 4 ... can you provide the link for your branch or some one could merge this ? Thanks !

Link to the branch

Thanks a lot for working on Swift 4 support! 🙏
Swift 4 support has been already merged with #118 😉


Add a pull request template file

You could refer to https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository
add a  .github/PULL_REQUEST_TEMPLATE.md

I would like to take on this.

Thank you for your contribution, looking forward to your PR

https://github.com/memfreeme/memfree/pull/56 resolve it.


Update request: gcc 14.2 → 15

Package name: gcc 15
Latest released version: 15

Current version on the unstable channel: gcc14
Current version on the stable/release channel: gcc14

[x] Checked the nixpkgs pull requests

Notify maintainers

@vcunat
@Synthetica9
@Ericson2314
Note for maintainers: Please tag this issue in your PR.
It's a recent version that I think that was released ~2 days ago: https://gcc.gnu.org/gcc-15/changes.html

Add a :+1: reaction to issues you find important.

It seems that I'm too fast, I saw in cppreference that the C23 extension that I wanted to test in gcc (embed) was available for gcc15 and found that page, I looked at the development plan and it's not there yet.
close for the moment, sorry for the ping.


Issues with Splash Attention

I've been testing both the Splash Attention and the good 'ol vanilla Flash Attention implementations. And it seems that the learning rate affects them very differently. In fact, in my experiments, Splash Attention always seems to underperform and it's harder to get right.
For example, using learning rates 1e-4, 3e-4, and 1e-5, the vanilla implementation (blue-ish) always converges but Splash Attention (red-ish) never gets quite as good.

I also tried with a different dataset, in this case books instead of newspapers. Same.

Splash Attention only seems to shine in tokens per second, where it gets around 4000 more tokens per second than the vanilla implementation.

At this point, I think it would be useful to have a way to select which implementation you want to run.
Also, is there a way to avoid doing evals at the beginning of the training?

Ugh yeah I'll disable/turn into opt in until we figure this out. Thanks for the report. I should have tested it more carefully. The loss curve was approximately the same in my quick test but apparently it's no good.

i bet i messed up mqa

pretty sure this will be fixed in #596 (though I'll make it default on after i test it a bit more)

@versae can you try latest main with:
--model.attn_backend splash

and  (the default:)
--model.attn_backend jax_flash

and lmk if things seem good? pretty sure it's correct now

Nice catch BTW
https://github.com/stanford-crfm/levanter/pull/596/files#diff-fbe2e2b3c420db2356f984aa3ecff7877ca98a9391bd8c9d2139bb9f3c61e100R763

thanks. I should have caught it before, but glad it's fixed now

declaring it fixed in #598


Update GitHub Actions page

Tasks

[ ]

Estimated Time: 20min
Writing the Issue

[ ] Write each task for this issue using checkboxes
[ ] Write all verbal instructions as tasks
[ ] Add labels and assignees

Before Working on the Issue

[ ] Assign yourself
[ ] Share your screen on Discord
[ ] Write which issue you are starting on Slack
[ ] Git: Fetch the latest main
[ ] Git: Create a branch with the name of the issue

Pre-PR Checks

[ ] Insure that changes include only what is necessary for this PR
[ ] Implement necessary Unit tests
[ ] Implement necessary E2E tests
[ ] Perform functionality checks

特に更新することはなかったです。


Fix issue #76 (bubble removed after enter)

Fixes #76

Hi Will,
please, don't merge this PR yet. I've just found a problem with the commit fixing findCodeBlock.
Nico


Is there any way I can get image album name list quickly.

const data = await CameraRoll.getPhotos({ first: 100000,groupTypes,assetType:'Photos'}); //得到10000条相片
// console.log('data',data);
const uniqTypesPics = .groupBy(data.edges, (val) => {
return val.node.group_name;
}); // 根据他的group_name进行分组
let categorys =.keys(uniqTypesPics).map((key)=> {
return {
name: key,
displayName:key,
demoImage: uniqTypesPics[key][0].node.image,//拿到分组的第一张图片作为样例
count: uniqTypesPics[key].length,//拿到分组的图片数量
};
});
// console.log('category',categorys);
I want to get all photo albums when used above code ,  but is very slowly when photo number above 5000,  i want to get all photo albums in 3 seconds.
Please help us .Thanks a lot.
React Native Environment Info:
System:
OS: macOS 10.14
CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
Memory: 496.03 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.13.0 - /usr/local/bin/node
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
IDEs:
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmPackages:
react: 16.6.3 => 16.6.3
react-native: ^0.58.4 => 0.58.6
npmGlobalPackages:
create-react-native-app: 2.0.2
eslint-plugin-react-native: 1.0.0
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7
react-native-update-cli: 0.1.0

@shergin @javache @davidaurelio @mkonicek

It looks like you are using an older version of React Native. Please update to the latest release, v0.59 and verify if the issue still exists.
The "Resolution: Old Version" label will be removed automatically once you edit your original post with the results of running react-native info on a project using the latest release.

Thank you very much.  I will try it.


Find whether people have had a task at a workshop together

I'd like to input 2 (or more) people and return what workshops (if any) those people have had a role in (any role).
Low priority but it would help me when I place people at workshops to know if they've worked together before.

@maneesha  This is mostly intended for finding staff, not participants, right?

Yes - this should apply to instructor, host, helper, and organizer.
Does not apply to learner.

Closing this as stale/not a priority.


test-branch/execute-job/quoted-authorization/e44ed1e3-7023-4b89-8334-0c598824ae15

PR for testing 12d8c02005ecd4f38b942744bd1468a830db83dc

/canonical/self-hosted-runners/run-workflows 12d8c02005ecd4f38b942744bd1468a830db83dc


chore: change form validation

Description of changes:

extend existing validation instead of replacing it if custom validation function
factor out the validation tasks so that it can be reused on submit later (currently only used on change)
fix logic for getting if form is valid.
remove empty error messages on mount

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

since the errors is starting with an object can we use optional chaining for instances like below?
errorMessage={errors.name.errorMessage}
hasError={errors.name.hasError}

good call. done

Codecov Report

Merging #597 (9186148) into tagged-release/forms-and-views (e71dfd4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@                        Coverage Diff                         @@
##           tagged-release/forms-and-views     #597      +/-   ##
==================================================================
+ Coverage                           90.73%   90.74%   +0.01%
==================================================================
  Files                                  87       87
  Lines                                3281     3285       +4
  Branches                              892      891       -1
==================================================================
+ Hits                                 2977     2981       +4
  Misses                                285      285
  Partials                               19       19

Impacted Files
Coverage Δ

...codegen-ui-react/lib/forms/form-renderer-helper.ts
91.76% <100.00%> (+0.30%)
:arrow_up:

.../codegen-ui-react/lib/forms/react-form-renderer.ts
75.96% <100.00%> (+0.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71dfd4...9186148. Read the comment docs.


Spine Broken/Restricted

Just trying to view shared mappings.  However I can't see multiple spine entries.  Below is an example screenshot.

@stuartasutton saw this too, but I was unable to reproduce it. (I suspect 503 refers to a HTTP The server is currently unavailable error)

@excelsior @jbaird123 any updates happening to the server that could be causing this?

It's a performance issue. There are hundreds of elements in this domain's spine and they loaded individually, one-by-one. I'll make changes to load them at once.

Just a note...and not sure it is relevant. This 503 code first appeared after I uploaded three files for ASN--the original and two separate files to pick up properties missed in the original file.

This has been resolved.


Added Postman Top 50 to API Zoo

I scraped Postman top 50 collections into format specified on the doc. I didn't add any of the optional arguments because most of the collections did not have that info. Many of the postman collections are also missing data, like a version or a description. Many of these collections also have unresolved variables. I have an error log of these things, so let me know if you want to see it, or if you want me to handle the errors in a different way. Currently, i just have "POST MISSING DESC", or something to that effect in those fields. Let me know if you want anything changed.

For anyone else who wants to scrape postman data, I have added the code below. Postman has an api you can call to download collection data in json form, which can then be parsed. I have two files, collection_download.py, and process_collection.py
import requests
import json
import os

PASS = 'PMAK-65b609090d4fbc0001038084-cec0b1cab946c10fc489a9f058f926d7c4'
headers = {'X-Api-Key': PASS}
collection_ids = []
start_ind = 39
def parse_top50():
    f = open('top50')
    for line in f.readlines():
        collection_ids.append(line[line.rfind('/')+1:].replace('\n', ''))
    #print(collection_ids)

def download_links():
    for i in range(start_ind, len(collection_ids)):
        id = collection_ids[i]
        r = requests.get(f'https://api.getpostman.com/collections/{id}', headers = headers)
        json_r = r.json()
        with open(f'input/{json_r["collection"]["info"]["name"].replace("/", "")}.json', 'w') as fp:
            json.dump(json_r['collection'], fp, indent= 4)

parse_top50()
download_links()

import json
import re
import os

USERNAME = "opatothan"

errlog = dict()

#UTILS

def version_in_name(name):
    pattern = r'v\d+'
    match = re.search(pattern, name)
    if match:
        return match.group(0)
    else:
        return None

def log_error(error, collection_name):
    if(error in errlog[collection_name]):
        errlog[collection_name][error]+=1
    else:
        errlog[collection_name][error] = 1

def parse_api_call(collection_name, input_json, variables):
    #takes in json object representing a single api call and turns it into a python dict in the structure established by apizoo doc
    try:
        output = dict()
        request = input_json['request']
        arg_params = ["auth", "method", "header", "body"]

        url = request['url']['raw']
        for key, val in variables.items():
            url = url.replace('{{'+key+'}}', val)
        if('{{' in url):
            log_error("Warning: unresolved variables", collection_name)
        if('description' in request):
            desc = ' '.join(request['description'].split(" ")[:20])
        else:
            desc = 'NO DESC IN POSTMAN'
            log_error("Warning: no description in postman", collection_name)

        output['user_name'] = USERNAME
        output['api_name'] = f'{collection_name}: {input_json["name"]}'
        output['api_call'] = url
        if('version' in variables):
            output['api_version'] = variables['version']
        else:
            output['api_version'] = "NO VERSION IN POSTMAN"
            log_error("Warning: no version in postman", collection_name)
        output['api_arguments'] = {param:request[param] for param in arg_params if param in request}
        output['functionality'] = desc

        return output
    except Exception as error:
        #print("An exception occurred:", error)
        #print(input_json)
        log_error(repr(error), collection_name)
        return None

#END UTILS

def scrape_collection(filename):
    api_calls = []
    f = open(f'input\{filename}', encoding = 'utf8')
    cur_collection = json.load(f)
    collection_name = cur_collection['info']['name']
    variables = dict()
    errlog[collection_name] = dict()

    if('variable' in cur_collection):
        for var in cur_collection['variable']:
            variables[var['key']] = str(var['value'])
        if('version' not in variables and version_in_name(collection_name)!= None):
            variables['version'] = version_in_name(collection_name)

    def recurse(cur_json):
        if('item' in cur_json):
            for item in cur_json['item']:
                recurse(item)
        else:
            res = parse_api_call(collection_name, cur_json, variables)
            if res != None:
                api_calls.append(res)
    recurse(cur_collection)
    with open(f'output/{collection_name.replace("/", "")}.json', 'w') as fp:
        json.dump(api_calls, fp, indent= 4)

#files = ["ActiveCampaign API v3.json", "Amadeus for Developers.json"]
files = os.listdir('input')
for x in files:
    scrape_collection(x)

# with open(f'output/opatothan.json', 'w') as fp:
#     json.dump(api_calls, fp, indent= 4)
with open(f'output/errlog', 'w') as fp:
    json.dump(errlog, fp, indent=4)


"Date of last change" dates for some COVIDcast-signals pages should actively link to changelog

For the following sources, the "Date of  last change" display accurate dates, but these dates are not actively linked to the changelog at https://cmu-delphi.github.io/delphi-epidata/api/covidcast_changelog.html:
...delphi-epidata/api/covidcast-signals/doctor-visits.html
...delphi-epidata/api/covidcast-signals/google-symptoms.html
...delphi-epidata/api/covidcast-signals/hospital-admissions.html
...delphi-epidata/api/covidcast-signals/quidel.html

An example of an actively linked "Date of last change" is currently available in the bulleted main summary list for "COVID-19 Trends and Impact Survey" at .../delphi-epidata/api/covidcast-signals/fb-survey:

To add: I've been confused about whether this line refers to documentation changes or data changes before. It's definitely doc changes, but to save others confusion, would be nice to clarify.


HLint assumes that rec is a keyword, so you can't use it as an identifier

Consider
$ cat Repro.hs
f rec = rec

$ ~/local/hlint/dist/build/hlint/hlint Repro.hs
Repro.hs:1:3: Warning: Parse error: rec
Found:
    f rec = rec

  >

1 suggestion

See https://github.com/ndmitchell/hlint/issues/134 for some background of the last time someone raised this. Passing -XNoDoRec solves it temporarily.

Thank you! Sorry for creating duplicated issues. I swear that I searched for 'rec' before creating.

No problem - there were no other open issues tracking this. Last time I got a report about rec I didn't do anything, but now I've decided there are enough instances to turn off DoRec by default. Done, along with a test.


Accept qiskit.opflow Operators as parameters for models

What is the expected behavior?
Similar to how we are able to use qiskit.quantum_info.Operator types as parameters for models, Operators of base class qiskit.opflow.OperatorBase should also be usable.
Current behaviour
Code Example:
from qiskit_dynamics.solvers import Solver
from qiskit.opflow import Z
drift = Z

hamiltonian_solver = Solver(
    static_hamiltonian=drift
)

Throws DispatchError: 'Dispatch does not support numpy object arrays.'
Solution idea
Add type qiskit.opflow.OperatorBase in function qiskit_dynamics.type_utils.to_numeric_matrix_type

Closing this based on the discussion in #167.


[Bug]: Toggling the Trouble Pane/Window destroys vertical layout with vsplit windows/panes

Problem
When I got vertically split windows it seems TroubleClose would simple add the space its own window had taken vertically (height) to the bottom most window/pane of split windows/panes.
Vice Verse also Trouble seems to to take the space its own window needs from the upper windows in a vertical split layout only and no matter what the layout was.
Together, toggling Trouble on/off, which I do for example automatically before and after every session auto-save (write-file),
destroys a vertical split-window/pane-layout. adding a lot of vertical size to the bottom most pane/window only.
Solution/Feature Request/Bugfix:
don't just take/remove the space Trouble needs from the bottom-most pane/window, resize the vertical layout adding/removing the Trouble-Windows height relatively/in-relation of the current vertical layout (in %).
Actually this is a real problem for me with my current setup, but I quite like Trouble ... hmm, I would even consider giving up nvims vertical splits altogether rather then giving up trouble, but as is now vertical splits become quite useless, always being autoresized to uncomfortable dimensions :-)
Please fix, would be awesome!!! <3

Development on the main branch is EOL.
Trouble has been rewritten and will be merged in main soon.
This issue/feature either no longer exists or has been implemented on dev.
For more info, see https://github.com/folke/trouble.nvim/tree/dev


Official Docker Image based on Ubuntu

Is your feature request related to a problem? Please describe.
Current official Docker image is based on Alpine:
https://github.com/Azure/azure-cli/blob/dev/Dockerfile
I think at some point it would be good to have official image that can be used by Visual Studio Code Remote - Containers.
https://code.visualstudio.com/docs/remote/containers
Unfortunately:
"Note: Alpine Linux and Windows based dev containers are not currently supported."
Describe the solution you'd like
Perhaps it would make sense to have Ubuntu based container as well?
Describe alternatives you've considered
I was testing this scenario with Dockerfile included in .devcontainer, however this solution is pretty inefficient. Having official developers container would be really useful.
Perhaps Dockerfile should be in azure-cli-dev-tools though.
Additional context

This is something I've kicked around for a while! I think it's a great idea. You can see a little conversation about this here: https://github.com/Azure/azure-cli/pull/8430
Basically what it comes down to, is that you already have a great place to start with ${repo_root}/scripts/release/debian/Dockerfile. The last container is called execution-env and only contains what is necessary to run the CLI. If you add the other dependencies that are currently in the alpine image, and I think we'd be good to go.

add to S163.

we have a cicd using a sidecar injecting stuff in a main build container, for some steps we only need azure-cli to be there. Major drawback: we have to roll our own since alpine is lacking some features.
I'm also wondering why azure-cli has alpine and only alpine, most of the MS related tools use a debian based image by default


Add other-modules to tests test-suite

The tests test-suite didn't have a other-modules field, which means that the tar.gz in Hackage doesn't have all required files. See #12.

LGTM, thanks!
On Sunday, July 19, 2015, Juan Pedro Villa Isaza<EMAIL_ADDRESS>wrote:

The tests test-suite didn't have a other-modules field, which means that
the tar.gz in Hackage doesn't have all required files. See #12
https://github.com/stackbuilders/twitter-feed/issues/12.
You can view, comment on, or merge this pull request online at:
https://github.com/stackbuilders/twitter-feed/pull/13
Commit Summary

Add other-modules to tests test-suite

File Changes

M twitter-feed.cabal
https://github.com/stackbuilders/twitter-feed/pull/13/files#diff-0
(2)

Patch Links:

https://github.com/stackbuilders/twitter-feed/pull/13.patch
https://github.com/stackbuilders/twitter-feed/pull/13.diff

—
Reply to this email directly or view it on GitHub
https://github.com/stackbuilders/twitter-feed/pull/13.

--
Justin Leitgeb http://justinleitgeb.com
Twitter: @justinleitgeb http://twitter.com/justinleitgeb
Github: @jsl https://github.com/jsl
Co-Founder and CTO, Stack Builders Inc. http://www.stackbuilders.com

@jsl Merged and version bumped, ready for cabal sdist and uploading to Hackage as well.

Uploaded to Hackage. I also added you to the maintainers group, @jpvillaisaza. Thank you!


Background acrylic not supported on windows 10

Describe the bug
Background acrylic not supported on windows 10 DesktopAcrylicController.IsSupported() returns false.
Someone else encountered it here  #7061
Steps to reproduce the bug
try DesktopAcrylicController.IsSupported() on windows 10
Expected behavior
DesktopAcrylicController.IsSupported() returns true
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.1 Preview 3: 1.1.0-preview3
Windows app type

[ ] UWP
[X] Win32

Device form factor
Desktop
Windows version
Windows 10 (21H2): Build 19044
Additional context
This is not documented and no indication was given with the release of 1.1preview 3 that acrylic would not work with windows 10.

It still returns false with 1.1.0 stable version...
(Windows 10 21H1)

turns out this isn't a bug, the WinUI team have announced that acrylic will not be supported on windows 10.
So much for down-level support

@Samuel12321: Can you give me the link to the announcement? It's quite disappointed :(

So, if acrylic is not going to be supported on Windows 10, then how did they made the acrylic effect on the new Windows Terminal application? 😕

It still returns false with 1.1.0 stable version... (Windows 10 21H1)

The same on Windows 10 21H2 (19044.1889) with WinUI 3 - Windows App SDK 1.1.4.

So, if acrylic is not going to be supported on Windows 10, then how did they made the acrylic effect on the new Windows Terminal application? 😕

windows terminal uses winui 2 islands

That is pretty backwards. Use the latest version, get less features and worse support.

Update: Desktop acrylic on Win10 will be supported starting in 1.2-preview2.

:tada:Microsoft.WindowsAppSDK v1.2.220930.4-preview2 has been released which fixes this issue.
Handy links:

Release Notes
Official Nuget Release


<|? throws typeMismatch error where it should not

Himotoki version 3.0.0
<|? throws typeMismatch error where it should not.
e.g.
let json = ["hello": "1"]
let _: Int? = try e <|? "hello" // typeMismatch error is thrown.

Closing as per #161.


Just Dance 2022

Could you add Just Dance 2022, please? Thank you! :)

I will add this game in a release that I push on December 24th!

Wondering if it has still released

It's late, but here is the release! https://github.com/hobby-grade/Nintendo-Switch-Discord-Status/releases/tag/<IP_ADDRESS>


rm misleading log msg re: appending to gitignore

I'm trying out dotenvx and ran this command:
$ dotenvx encrypt

✔ encrypted (.env)
✔ key added to .env.keys (DOTENV_PRIVATE_KEY)
ℹ add .env.keys to .gitignore: [echo ".env.keys" >> .gitignore]

$ git status
Untracked files:
	.env
	.env.keys

$ ls -a

.env
.env.keys
. git
Makefile
README.md

and deduced that the final log (echo ".env.keys" >> .gitignore) is not happening.
This seems to be purposeful (https://github.com/dotenvx/dotenvx/pull/45), just figured better to align the logs with the actual execution.

thanks but this is an informational log - leaving it to the user to take that action if they wish

No worries, I read this [echo ".env.keys" >> .gitignore] as a thing that was happening / supposed to happen.
In the issue that spurred your PR, there's mention of a separate command to handle adding the .env.keys to .gitignore, but I don't see it listed when I run dotenvx help or dotenvx encrypt --help.

Aha, that's the one, ty!

this has been bothering me the last few days. i think you were right - this wasn't clear enough. here's the latest using ⮕  next run


Update tfsec Version to 1.17.0

Automated update from tfsec version 1.15.4 to version 1.17.0
Release Notes: https://github.com/aquasecurity/tfsec/releases/tag/v1.17.0

ever since 1.16.0, we are observing the behavior seen in this issue: https://github.com/aquasecurity/tfsec/issues/1677
won't update until this is resolved.


Null & zero-length app string gets translated into a send to /apps/None/

Should probably throw an exception before sending, since it cannot be valid

app_id is validated during construction in 1.0


License

Hi, there is a chance I have missed the relevant information somewhere, but which pretence do you allow this code to be used under? It looks great as a way of using Spring Boot with React Router as there does not seem to be much information available on this.
Thank you.

This repository was originally built alongside this blog:
http://www.blackpepper.co.uk/spring-react-redux-routing/
Do you have any specific questions on how to integrate Spring and react-router?

I added a license file in commit 99f519f, specifying MIT.


Ruby Group Capstone -- Catalog Of My Things

https://github.com/BHObserver/Catalog-Of-My-Things/pull/59
This is the final product of Ruby Group Capstone - Catalog of Things
In this branch >>

Each class from the UML class diagram is created in a separate .rb file.

All associations (1-to-many relationships) and aggregations (parent-child relationships) between classes should be implemented.

All methods visible in the diagram have been implemented.

Added unit tests for all implemented methods.

User interface

Created a main.rb file that will serve as your console app entry-point.
The console app, at the start:
Present the user with a list of options to perform.
Let users choose an option.
If needed, ask for parameters for the option.
Have a way to quit the app.

All data is preserved by saving collections in .json files.

Database

Created a schema.sql file with tables that will are analogical to the structure of the classes in the app. - added all properties and associations from the parent Item class as table columns to all tables based on the child classes

To the next reviewer, kindly note that some changes were introduced to this repo whilst under review


Cannot Set Response Header in Windows

in my Arch Linux environment, i have run.sh with content below:
#!/usr/bin/env bash
export HTML_INDEX="site/index.html"
export MAIN_JS="site/main.js"

shell2http -export-all-vars -cgi -form / "cat $HTML_INDEX" \
/echo 'echo "$v_msg"' \
/call2 'echo "Content-Type: application/json";echo ;echo "{\"error\": \"ok\"}"' \
/main.js 'echo "Content-Type: application/javascript";echo ;cat $MAIN_JS'

in the script above i can set correct Content-Type response header of the /main.js path. it works correctly in browser.
now, i want to replicate script above in Windows environment (Windows 8.1) with run.bat below:
@echo OFF

set HTML_INDEX=site\index.html
set MAIN_JS=site\main.js
set TYPE=Content-Type: application/javascript

shell2http.exe -cgi / "type %HTML_INDEX%" ^
/main.js "echo %TYPE% & type %MAIN_JS%"

the problem is, the Content-Type not set in Response Header, but included in Response Body output of /main.js
Content-Type: application/javascript
alert('Hello World') <-- content inside `site\main.js`

i've tried adding \n\n and echo. to add newline
/main.js "echo %TYPE%\n\n & type %MAIN_JS%"
/main.js "echo %TYPE% & echo. & type %MAIN_JS%"

the Content-Type always included inside the Response Body.
but of course, if i only using this command below:
/main.js "type %MAIN_JS%"

the main.js script executed by the browser successfully, but with Content-Type: text/plain.
How to make the Response Header setting works in windows?

Why not used -export-all-vars option in run.bat like in run.sh?
Or please try (twice echo.):
/main.js "echo %TYPE% & echo. & echo. & type %MAIN_JS%"

i don't use -export-all-vars flag because all the variables inside the run.bat already works as expected.
here i test the code with -export-all-vars flags with double echo.  :
shell2http.exe -export-all-vars -cgi / "type %HTML_INDEX%" ^
/main.js "echo %TYPE% & echo. & echo. & type %MAIN_JS%"

the echo. corectly add newline. Here the screenshot from Google Chrome (68.0.3440.84) response body:

i wonder if it's related with the line ending the OS used as the unix \n and windows \r\n.
i've already tried to save the run.bat with \n  using Notepad2-mod, but stil not working.

As a workaround please try adding a header inside to main.js, with two \n after header.
And run: /main.js "type %MAIN_JS%"
And I'll try to debug on windows.

Thanks, it works!
But, why this code doesnt work? the code below is manually typed.
Content-Type: application/javascript\n\nalert('Hello World')

it's working if i set the Line Ending to UNIX (LF) in my Notepad2, then adding \n by pressing Enter.

But, Yeah the workaround is enough to solve my problem. Thanks. :+1:

Hi, I investigated the problem on windows. The reason is space between two new lines after headers:
/main.js "echo %TYPE% & echo. & echo. & type %MAIN_JS%"

This variant should work correctly:


The filewatch does not work if files are creating too fast

Hi,
I find a issue using the gem. If the files in the watching dirs are creating too fast, say almost less than tens of milliseconds, the filewatcher does not trigger the file creation. How should I deal with this situation if the files need to be monitored in such a short time?

Filewatcher check files with specified interval (100 ms by default) and has every option (disabled by default). Please, read README. Does it help?

If I'd like to make it faster response, do I need to set it to a smaller interval?

Yes.

I find the default is 0.5 second.

Oops, sorry, my mistake. You're right.

By the way, are you sure that you understood every option? Filewatcher can has even 1 second interval and returns the Hash of all changed files in this second.

I would like to hear a feedback, if I can. :slightly_smiling_face:

I'll close it for now. I hope, the issue is resolved. I can answer and re-open for additional questions.


New release

[x] Fix #28 .
[x] Update Android build tools, etc.
[ ] Investigate #30.

When I have the time.

I think #33 is mandatory and should be added to the upcoming release.

v1.1.7 released, will be available on maven central within an hour.


Can we package zipkin dependencies as OSGi bundles

It would be great if we can package zipkin dependencies as OSGi bundles.

I am already running zipkin in OSGi. What dependencies are you missing?

I mean all the zipkin components are packaged as jar (e.g. https://github.com/openzipkin/brave/blob/master/brave-core/pom.xml#L10). IMHO it would be great they can be packaged as OSGi bundles. Then we don't need to create separate OSGi bundle to use zipkin in OSGi environment.

This is already the case. If you look at the resulting jar files they already contain OSGi meta data now.

@cschneider Thank you for the info. I just downloaded the https://mvnrepository.com/artifact/io.zipkin.brave/brave-core/3.15.0 and checked the MANIFEST.MF. But it doesn't contain any OSGi headers.
It only contains following
Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Built-By: travis
Created-By: Apache Maven 3.3.9
Build-Jdk: 1.8.0_65

Did I do something wrong?

Just use the newest one 3.15.1. There is still an issue with this released version though. It does not export the private package com.github.kristofa.brave.internal but this package is used in some other brave modules. We are currently trying to find a way to make this work nicely.
See #271
So first start with the newest release 3.15.1 and if you hit problems try the newest snapshot by building from the source of master. Any feedback about possible problems in OSGi is highly welcome.
If you need an example to start with take a look at https://github.com/cschneider/brave-osgi-example .
Currently it is at the state of simple brave api working with the kafka and Urlconnection senders.
I am currently working on full REST and SOAP logging and will update the example once I get it working.

@cschneider can you look at all the new things in brave and make sure they are OSGi ok?

The MANIFEST.MF of all bundles looked good until version 4.10.0. Starting with 4.10.1 the MANIFEST.MF of some bundles is incomplete. I guess it has something to do with commit 2fea453e253a92bbc127390736dbc8545f16d1b6 because there were only two commits between 4.10.0 and 4.10.1.
Following bundles are still ok:

brave
brave-instrumentation-http
brave-instrumentation-rpc
Following bundles are not ok:
brave-context-log4j12
brave-instrumentation-httpclient
brave-instrumentation-servlet
brave-instrumentation-spring-webmvc
brave-spring-beans
I didn't check any other bundles.

@ConradGroth did you check these bundles against the latest 5.x release of brave or only 4.10 ?

I think in some modules the jar plugin does not process the generated Manifest.
Is there a reason why the maven jar plugin in the parent does not have:

org.apache.maven.plugins
maven-jar-plugin
3.1.0

${project.build.outputDirectory}/META-INF/MANIFEST.MF

I see that this config is present in some poms but not in others.

it would be easy to try it out i guess, but i know nothing about OSGI. Are you saying that the modules that are OSGI compliant have above config and those that are not don't ?
https://maven.apache.org/shared/maven-archiver/examples/manifestFile.html

I guess the parent should be the one having the below, with a big comment why, huh :)
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>

oh I see.. I think due to the huge manifest files the plugin creates by default (and certain use of internal types), we only cherry-picked the important modules and created bnd files for each.

I will backfill these.

some refactoring needed as this is actually beyond tedious https://github.com/openzipkin/brave/pull/1009

@jorgheymans I checked the 5.8.0 bundles.


Update README.md

I added most of the commands for the cross sectional and longitudinal. Will add rest later this week

Can you pull from upstream because you are reverting a lot of changes that alan made.

Also can you put the data download/prep in the input data download section


Please update flutter icons similar to web version

Icon name
drama
Use cases
In Web New icons version is 0.341.0. But in flutter have lucide_icons: ^0.257.0 pls update
Design ideas
In Web New icons version is 0.341.0. But in flutter have lucide_icons: ^0.257.0 pls update
Checklist

[X] I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)
[X] I have searched existing icons to make sure it does not already exist and I didn't find any.
[X] I am not requesting a brand logo and the art is not protected by copyright.
[X] I am not requesting an icon that includes religious, political imagery or hate symbols.
[X] I have provided appropriate use cases for the icon(s) requested.

Duplicates #1692 and #1898, please refer to #1593 as to why the Flutter package has not been updated lately, and also check out https://github.com/lucide-icons/lucide-flutter where @n-bernat is already working on updating it.


Surf height not accurate

The surf height seems to be... a little off
At the moment, it is taking the max wave height from the API for the current/forecasted day
Looking at the API docs, we are taking the Current Conditions max values(max height, direction, period). We can maybe keep this as an argument if the user wants this data, but we should try to provide as accurate of data as possible(not max values)

Hi, I would like to work on this if that's okay :D

@Rajiv-Rago of course!
There is an open PR that is working on the same files/functions that would be altered in this fix.
Hopefully that PR can be merged in the next day/two, and then you will be good to go!


Emit warning when CloudFront distribution does not correspond to S3 bucket

When the incorrect distribution is configured, production files will correctly upload to the bucket. Upon realizing the distribution is improper, a user may attempt to change the distribution to the correct one. However, once the user attempts to deploy again, the files will not be invalidated properly because the bucket will have the same files (if no changes have been made since).
Is it possible to match if a CloudFront distribution is linked to an S3 bucket? Should there be a command to forcefully invalidate? Or, can all of this be avoided by automatically finding the distribution ID for a user.

Perhaps add an invalidate flag to force invalidation


Dim URL quoted text getting garbled?

Using Chrome and attempting to control my milights according to the post here:
http://codecorner.galanter.net/2016/05/12/full-control-of-your-limitless-ledmilight-bulbs-from-amazon-echo/
The "On URL" and "Off URL" entries work great, however when I attempt to run two udp sequences to dim the lights, like this:
[{“item”:”udp://<IP_ADDRESS>:8899/0x450055″},{“item”:”udp://<IP_ADDRESS>:8899/0x4E${intensity.math((X*27)/255)}55″}]
then doing "Update Device", the quoted text is getting garbled:
[{â€œitemâ€�:â€�udp://<IP_ADDRESS>:8899/0x450055â€³},{â€œitemâ€�:â€�udp://<IP_ADDRESS>:8899/0x4E${intensity.math((X*27)/255)}55â€³}]
Not quite sure what I'm doing wrong?

The character set at the website that you cut and pasted from is nonstandard and it pastes that info into the text box. just type it in as you see it and it will fix it.

Did you get this fixed?

I did, thanks for the fast response, it's copy/paste weirdness that was circumvented by your suggestion.


[PE-D][Tester B] No restriction on length of phone number

There was no restriction on how long the phone number can be

Labels: severity.Low type.FeatureFlaw
original: dez2003/ped#2

Preliminary Comments:

Can probably be fixed similar to #223.

Extreme user behaviour, not considered bug


Fix the drawing tests to not use Objective-C and build on OS X.

This fixes #1453 and #1448.
I thought that #1453 was the cause of the teardown crash I was seeing, so it got fixed here; it turns out that CGImageDestination was overreleasing a CGImage's CGDataProvider.

This change is

/* static / DrawingTestConfigImpl DrawingTestConfig::Get() {

static?

Refers to: tests/UnitTests/CoreGraphics.drawing/EntryPoint.cpp:93 in f000645. [](commit_id = f000645256b7d268d71b39deb9765050ea357d3e, deletion_comment = False)

/* static / DrawingTestConfigImpl DrawingTestConfig::Get() {

Yes.
This is a static member function on DrawingTestConfig.
Since we cannot annotate it as such via classical means, this comment serves to illustrate that it is static.

In reply to: 263743436 [](ancestors = 263743436)

Refers to: tests/UnitTests/CoreGraphics.drawing/EntryPoint.cpp:93 in f000645. [](commit_id = f000645256b7d268d71b39deb9765050ea357d3e, deletion_comment = False)


Maximum number of  instruments in websockets api

It seems that if i subscribe to more than 40 instruments in websockets API for 1minute candle data, then the data is getting dropped. I am not getting data consistently.
What is maximum limit on the number of instruments in the websockets API?
Kite from Zerodha allows upto 1000 instruments in one websocket connection.

Would love to know the number of instruments that we can subscribe to

I am trying something similar. How do i modify the below command to include multiple stock_tokens ?
subscribe stocks feeds by stock-token
breeze.subscribe_feeds(stock_token="1.1!500780")

Dear Client,
Please subscribe the multiple stock tokens by passing through a list.
breeze.subscribe_feeds(stock_token=['4.1!35002','4.1!56352'])
[E29CF836]
Thanks & Regards,
Amrit Mohanty,
API & Algo Products,
Derivatives, EPG
ICICIdirect

From: GauravSuryavanshi2020 @.>
Sent: Wednesday, March 6, 2024 8:27 PM
To: Idirect-Tech/Breeze-Python-SDK @.>
Cc: Subscribed @.***>
Subject: Re: [Idirect-Tech/Breeze-Python-SDK] Maximum number of instruments in websockets api (Issue #45)
CAUTION: This email originated from outside the organization! Do not click links, open attachments or reply, unless you recognize the sender's email address! Use 'Report suspicious Email' button in the toolbar to report Phishing mails. Beware!
I am trying something similar. How do i modify the below command to include multiple stock_tokens ?
subscribe stocks feeds by stock-token
breeze.subscribe_feeds(stock_token="1.1!500780")
—
Reply to this email directly, view it on GitHubhttps://github.com/Idirect-Tech/Breeze-Python-SDK/issues/45#issuecomment-1981054540, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3TQZ4ZUVURSBBSRVK5EY5LYW4VEXAVCNFSM6AAAAAA6VWI6QCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBRGA2TINJUGA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
Print this mail only if absolutely necessary. Save Paper. Save Trees." "The information contained in this e-mail and any attachments to this message are intended for the exclusive use of the intended recipient and may contain proprietary, confidential or legally privileged information. If you are not the intended recipient, please note that you are not authorised to disseminate, distribute or copy this e-mail or any parts of it or act upon/rely on the contents of this e-mail in any manner. Please notify the sender immediately by e-mail and destroy all copies of this e-mail and any attachments. Please also note that ICICI Bank or its subsidiaries and associated companies, (collectively "ICICI Group"), are unable to exercise control or ensure the integrity of/over the contents of the information contained in e-mail transmissions and that any views expressed in this e-mail are not endorsed by/binding on the ICICI Group unless the sender does so expressly with due authority of ICICI Group. Before opening any attachments please check them for viruses and defects and please note that ICICI Group accepts no liability or responsibility for any damage caused by any virus that may be transmitted by this email. Any unauthorized use of this email or any attachment(s) may be treated as infringement of right(s) including right of privacy under the applicable laws of India including Information and Technology Act, 2000. Thank you for your cooperation. Regulatory Disclosures are available on https://www.icicisecurities.com (for institutional business) and www.icicidirect.com (for retail business).

I am gertting the bgelow error after getting data for 2 minutes :
IOPub data rate exceeded.
The Jupyter server will temporarily stop sending output
to the client in order to avoid crashing it.
To change this limit, set the config variable
--ServerApp.iopub_data_rate_limit.
Current values:
ServerApp.iopub_data_rate_limit=1000000.0 (bytes/sec)
ServerApp.rate_limit_window=3.0 (secs)

I increased the limit of iopub_data_rate_limit to 10e10 in sever.py but this did not work.
I wish to get tick data of all futures and opitions tokens that are available (approximate 35000) . How can I get tick data for Thirty five thousand tokens ?
Commands planning to use are as below 👍 # Assign the callbacks.
breeze.on_ticks = on_ticks
subscribe stocks feeds by stock-token
breeze.subscribe_feeds(stock_token=["4.1!66506","4.1!66507"....])
If it is a paid service for getting these many tokens dta then what are the charges ?

Any update on this ?
Need to know if there is any limit ?

Dear Mitul,
Thank you for showing interest in Breeze API.
There is no limit on the number of contracts you can subscribe to via WebSocket.
If you encounter any issues, kindly share a screenshot of the error for further assistance.
Below is the code to subscribe to multiple contracts:
import time
from breeze_connect import BreezeConnect
from datetime import datetime, timedelta
key_api = ""
key_secret = ""
key_session = ""
breeze = BreezeConnect(api_key=key_api)
breeze.generate_session(api_secret=key_secret, session_token=key_session)
Connect to websocket(it will connect to tick-by-tick data server)
breeze.ws_connect()
Callback to receive ticks.
def on_ticks(ticks):
data.append(ticks)
print("Ticks: {}".format(ticks))
Assign the callbacks.
breeze.on_ticks = on_ticks
breeze.subscribe_feeds(stock_token=['4.1!3499','4.1!2885','4.1!3456'])
Stock tokens can be found out from below file also.
https://traderweb.icicidirect.com/Content/File/txtFile/ScripFile/StockScriptNew.csv
[E29CF836]
Thanks & Regards,
Akash Sapkal,
Team Breeze API,
ICICI Securities

From: Mitul Limbani @.>
Sent: 07 October 2024 08:48
To: Idirect-Tech/Breeze-Python-SDK @.>
Cc: BREEZEAPI @.>; Comment @.>
Subject: Re: [Idirect-Tech/Breeze-Python-SDK] Maximum number of instruments in websockets api (Issue #45)
CAUTION: This email originated from outside the organization! Do not click links, open attachments or reply, unless you recognize the sender's email address! Use 'Report suspicious Email' button in the toolbar to report Phishing mails. Beware!
Any update on this ?
Need to know if there is any limit ?
—
Reply to this email directly, view it on GitHubhttps://github.com/Idirect-Tech/Breeze-Python-SDK/issues/45#issuecomment-2395814483, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3TQZ43FNNT2R7PKYGVDOEDZ2H4RNAVCNFSM6AAAAABPO7BMACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVHAYTINBYGM.
You are receiving this because you commented.Message ID: @.***>
Print this mail only if absolutely necessary. Save Paper. Save Trees." "The information contained in this e-mail and any attachments to this message are intended for the exclusive use of the intended recipient and may contain proprietary, confidential or legally privileged information. If you are not the intended recipient, please note that you are not authorised to disseminate, distribute or copy this e-mail or any parts of it or act upon/rely on the contents of this e-mail in any manner. Please notify the sender immediately by e-mail and destroy all copies of this e-mail and any attachments. Please also note that ICICI Bank or its subsidiaries and associated companies, (collectively "ICICI Group"), are unable to exercise control or ensure the integrity of/over the contents of the information contained in e-mail transmissions and that any views expressed in this e-mail are not endorsed by/binding on the ICICI Group unless the sender does so expressly with due authority of ICICI Group. Before opening any attachments please check them for viruses and defects and please note that ICICI Group accepts no liability or responsibility for any damage caused by any virus that may be transmitted by this email. Any unauthorized use of this email or any attachment(s) may be treated as infringement of right(s) including right of privacy under the applicable laws of India including Information and Technology Act, 2000. Thank you for your cooperation. Regulatory Disclosures are available on https://www.icicisecurities.com (for institutional business) and www.icicidirect.com (for retail business).


idea version is 2022.1. java.lang.NoClassDefFoundError

Describe the bug
1.java.lang.NoClassDefFoundError
2.Caused by: java.lang.NoClassDefFoundError: Could not initialize class com.xenoamess.p3c.pmd.lang.java.util.namelist.NameListConfig
Screenshots

@f1558
Please use https://plugins.jetbrains.com/plugin/14109-alibaba-java-coding-guidelines-xenoamess-tpm-/versions/stable/168169
JetBrains is reviewing this update. Please expect it to be approved within two business days of the upload.
But  it IS usable.


Improve 7.6 release notes

Rework dependency block release notes
Rework preamble and section ordering in release notes and match release features

@bot-gradle test RfR

OK, I've already triggered the following builds for you:

ReadyForRelease build

Only comment I have is it is not clear in the preamble why a strongly-typed dependencies block matters.

@big-guy @octylFractal Any idea on clarifying that

Included suggested changes. Will merge so that we are good to go for RC1. We can polish further before GA.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

Something needs to be cherry-picked to release, on it.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build cancelled.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

This PR also incorporated Piotr's Feedback from the google doc.  All points have been addressed and I think this can be safely merged.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.


Create codeql-analysis.yml

This is just a test for the new CodeQL security scanner. Please don't merge yet.
Have you read CONTRIBUTING.md lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:

[ ] I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
[ ] I've updated the RC_XXX release ticket with any manual steps required to release this change
[ ] I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing
[ ] I've updated Swagger to reflect any API changes

In all cases:

[ ] Get two thumbsworth of review and PO signoff if necessary
[ ] Verify all tests go green
[ ] Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
[ ] Test this change deployed correctly and works on dev environment after deployment

Yea no worries, this is just something we're testing - not for merge. This was an automated GitHub Action created by GitHub, we'll likely tweak it further.


Eliminating security warnings

Change Description
Eliminating security warnings.  This is a bit ugly just because of the Ricardian renderer and its components.
API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Replaced by PR #32 , a simpler approach that doesn't break the tests...


CORS Issues

Anybody has any idea why I might be getting this kind of error:
Failed to load https://login.microsoftonline.com/common/discovery/keys: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:1337' is therefore not allowed access.

I am using Microsoft Azure Authentication Directory and I have set my callback on my registered app.

They don't support CORS. Contact support and let them know you want this feature.

Wow what a bummer.

@Hyjaz  How did you solve this issue?

@g-guth You need to add metadata and signInKeys in your settings section.
Here is the actual closed issue that resolves this issue.
https://github.com/IdentityModel/oidc-client-js/issues/275

.... And CORS again, whey for the sake of Godness, we always have that CORS.
Is this 29 days ago refers to the latest docs state?
I'm struggling with this doc a few days, and I can't login normally to Skype Bot API. I can install Chrome Extension for CORS on/off, but then subsequent request fail.
So again? Why CORS?
PS. My variant of code: Simple javascript $.ajax with method POST call to https://login.microsoftonline.com/botframework.com/oauth2/v2.0/token as it's written in docs regarding Auth in docs, and I have
Failed to load https://login.microsoftonline.com/botframework.com/oauth2/v2.0/token: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:5000' is therefore not allowed access.
 And in fact I understand, that CORS issue here is NOT with my server or even not with my Request, but with MS Response from server.
People, plz help, I'm lost...

People, plz help, I'm lost...

If MSFT doesn't support CORS, they don't support CORS.

Since Microsoft does not support cors, you need to add metadata in your request. I have added the issue number in my previous answer. That should work. So you are missing your metadata and signinkeys.

@brockallen but why docs don't say anything about it? And how other people deal with this? Is the ngrok the only solution? I don't believe I'm first who faced with this during Auth, so how people solved it?
@Hyjaz if u mean this snippet:
 metadata: {
            issuer: 'https://login.microsoftonline.com/{tenant}/v2.0',
            jwks_uri: 'https://login.microsoftonline.com/{tenant}/discovery/v2.0/keys',
            end_session_endpoint: 'https://login.microsoftonline.com/{tenant}/oauth2/v2.0/logout"',
            authorization_endpoint: 'https://login.microsoftonline.com/{tenant}/oauth2/v2.0/authorize'
        }

Then I don't get where I should add it it?
In docs there is no direct usage of field metadata, and I see only type/technology of Auth:

OpenID metadata | The Bot Connector service publishes a list of valid tokens that it uses to sign its own JWT tokens to OpenID metadata at a well-known, static endpoint.

And in fact, I also tried GET+ GET approach. And when I fetch request to get metadata via GET, I have similar error:

Failed to load https://login.botframework.com/v1/.well-known/openidconfiguration: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:5000' is therefore not allowed access.

@brockallen but why docs don't say anything about it?

No clue. Ask Microsoft (not me).

@alundiak try adding it in the data.
Do not forget the signin keys, because without the signin keys you will get another cors issue after you get through the first server call.

@Hyjaz
DIdn't help. The same:

localhost/:1 Failed to load https://login.microsoftonline.com/botframework.com/oauth2/v2.0/token: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:8080' is therefore not allowed access.

And regarding yours

signin keys

I'm sorry, but I don't know/guess what is this.

@alundiak
var dataObject= {
    authority: 'https://login.microsoftonline.com/{tenant_id}',
  client_id: '{client_id',
  redirect_uri: `${window.location.protocol}//${window.location.hostname}${window.location.port ? `:${window.location.port}` : ''}/callback`,
  response_type: 'id_token',
  scope: 'openid profile',
  post_logout_redirect_uri: `${window.location.protocol}//${window.location.hostname}${window.location.port ? `:${window.location.port}` : ''}/`,
  filterProtocolClaims: true,
  loadUserInfo: true,
  metadata: {
    issuer: 'https://sts.windows.net/{tenant_id}/',
    jwks_uri: 'https://login.microsoftonline.com/{tenant_id}/discovery/keys',
    end_session_endpoint: 'https://login.microsoftonline.com/{tenant_id}/oauth2/logout',
    authorization_endpoint: 'https://login.microsoftonline.com/{tenant_id}/oauth2/authorize'
  },
  signingKeys: [{}]
}
Replace those that are in brackets with your own values.

@Hyjaz this is kinda different type os usage Bot Connector. I don't want to use redirect to any page and get back then. I simply send $.ajax() POST request to get token, and then use the token in JavaScript code to do second request $.ajax() POST to Skype API (https://smba.trafficmanager.net/apis/v3/conversations/" + conversationId + "/activities)
So no UI interaction at all.
This is REST approach, which is documented on docs.
https://docs.microsoft.com/en-us/bot-framework/rest-api/bot-framework-rest-overview
But thanks for that code snippet, now I at least understand u was talking about different things :) than I was thinking.

So no UI interaction at all.

Then why are you using this oidc-client library?

@brockallen in fact I don't use it. AFAIK. I simply spotted on CORS issue on Google/github, and as soon it's related to MS APP/Skype Bot / IdentityModel, I sought it's issue deep down.
So far, instead of JavaScript, I resolved my needs using Bash/Pythin script, where nio ** CORS happens so far.
So thanks and sorry. @Hyjaz u 2 thanks :)
PS. PS, but my CORS issue with MS App/Bot platform, I will move to BotBuilder github for further research.

PS. PS, but my CORS issue with MS App/Bot platform, I will move to BotBuilder github for further research.

FWIW there's much Microsoft's token service does not fully and/or properly support. G'dluck.

@alundiak, I'm wanting to take the same approach (hit the auth service, and then use that token directly in my code to hit the DirectLine chat service).  Did you ever figure out the right headers to use to make that happen?  If so, can you paste them here?

@nathanlogan I'm a bit away from this stuff these months. I will try get back later maybe.


Support for KafkaAdmin client

Added new folder - examples for various kafka-admin-client usage deployments/operations.

It would be nice to have some description


Remove notification when there is no error. Fixes #8

The message is moved to status bar so The code cannot be merge.
And also close #8


feat(options): border width

Hi!
IMHO, it'd be good if border width can be configured.
How do you think?
Thanks :)

Hi @jjangga0214, first of all thanks for using this package.
Your suggestion makes perfect sense. I'll make this change soon.
Thanks very much!

Hi @jjangga0214 , i just released a new version with your suggestion. I even added on the  example a case of a checkbox that configures its own border.
You can check the changes on the 2.0.2 version.
Thanks again for using this package.
I'll close this issue for now but feel free to reopen if needed


Eror getting config

Hi! I'm getting error on parsing mainnet config, issue encountered between Dec. 10 and 11.
Code:
_, err := liteclient.GetConfigFromUrl(context.Background(), "https://ton.org/global.config.json")
if err != nil {
  return fmt.Errorf("get config: %w", err)
}

Returns:
get config: invalid character '<' looking for beginning of value

Hi, Yes I can confirm it!

It's caused because in response HTML is present, GetConfigFromUrl not handling status of response

any quick fix for it?

idk, vpn or proxy to bypass cloudflare

curl https://ton-blockchain.github.io/global.config.json and curl https://ton.org/global.config.json works fine on both VPS and my machine! Using VPN or proxy for what when I can get the result using curl but it does not work with tonutils-go?

Yeah, you're right. I'm pretty sure the problem may caused by missing headers, User-Agent maybe, will check later

Same for me, looks like some rules on the server blocks it, i will notify the team.
As an option for now you can download it and put locally, then load with liteclient.GetConfigFromFile("path to file.json")

I tested both absolute and relative path
open /root/xyz/mainnet-global.config.json: no such file or directory"
open ../mainnet-global.config.json: no such file or directory"

does it work for you? @ysomad I still get the same error.
Any update when it can fixed? @xssnick

does it work for you? @ysomad I still get the same error. Any update when it can fixed? @xssnick

You getting error even when using file? URL https://ton-blockchain.github.io/global.config.json works fine for me, for ton.org I already notified them, hope will be fixed soon

does it work for you? @ysomad I still get the same error. Any update when it can fixed? @xssnick

You getting error even when using file? URL https://ton-blockchain.github.io/global.config.json works fine for me, for ton.org I already notified them, hope will be fixed soon

Thanks! I fixed it, problem was on my side! But it'd be good if it fixes soon from the URL!
One more question, how often the .json will change? can I keep it as a file for how long?

https://github.com/xssnick/tonutils-go/pull/289
@xssnick i have recomend fix this, i tested ok, if ok merge it


Fix: #103 & write test case to get_star_imp function return None

@hadialqattan  would you mind reviewing this?

@hadialqattan would you mind reviewing this?

I'll as soon as possible!


[Proposal] Raise compile error on duplicated props/slots

Hey there,
I think it might be helpful to raise a compile error in case of passing duplicated props or slots to a component.
Additionally the current behavior varies between props and slots:
defmodule MyApp.Components.Modal do
  use Surface.LiveComponent

  slot header
  prop paragraph, :string

  def render(assigns) do
    ~H"""

      <slot name="header" />

@paragraph

    """
  end
end

<Modal paragraph="one" paragraph="two">
  <template slot="header">

one

  </template>
  <template slot="header">

two</two>
  </template>
</Modal>

This example would render the Modal with paragraph=two but with the header-slot = one.
I will try to submit a PR on this topic if people agree with this proposal (might take me some time though).

@nduitz Thank you for creating this issue.
Multiple slots is a valid behaviour especialy with Renderless Component. For example, the following components (extracted from the doc) are valid and the Grid component accepts multiple slots that have the same name, cols. You can access these slots with the assign variable @cols and loop over it.
  defmodule Column do
    use Surface.Component, slot: "cols"

    @doc "The field to be rendered"
    prop field, :string
  end

  defmodule Grid do
    use Surface.Component

    @doc "The list of items to be rendered"
    prop items, :list, required: true

    @doc "The list of columns defining the Grid"
    slot cols

    def render(assigns) do
      ~H"""

            <th :for={{ col <- @cols }}>
              {{ Phoenix.Naming.humanize(col.field) }}

          <tr :for={{ item <- @items }} class={{ "has-text-warning": item[:selected] }}>
            <td :for={{ col <- @cols, field = String.to_atom(col.field) }}>
              {{ item[field] }}

      """
    end
  end

  defmodule Example do
    use Surface.LiveComponent

    data albums, :list, default: []

    def mount(socket) do
      {:ok, assign(socket, albums: [
        %{name: "The Dark Side of the Moon", artist: "Pink Floyd", released: "March 1, 1973"},
        %{name: "OK Computer", artist: "Radiohead", released: "June 16, 1997"},
        %{name: "Disraeli Gears", artist: "Cream", released: "November 2, 1967", selected: true},
        %{name: "Physical Graffiti", artist: "Led Zeppelin", released: "February 24, 1975"}
      ])}
    end

    def render(assigns) do
      ~H"""

        <Grid items={{ @albums }}>
          <Column field="name" />
          <Column field="artist" />
          <Column field="released" />
        </Grid>

      """
    end
  end

That being said, I recognize we could be more explicit when we allow this behaviour like we do with props and the :accumulate option that instructs Surface to group all different values provided for a property into a single list.
For example:
  # Component
  defmodule Accumulator do
    use Surface.Component

    prop acc, :string, accumulate: true

    def render(assigns) do
      ~H"""

        <li :for={{ str <- @acc }}>{{ str }}

      """
    end
  end

 # Usage
  <Accumulator acc="hello" acc="world" acc="!" />

 # Result

hello

world

!

If you do not set the :accumulate option to true like in your example, the last value will override the previous one. This is why <Modal paragraph="one" paragraph="two"> use two for the paragraph prop.
You are right when you say that the behaviour is not consistent between props and slots. I believe we should fix that. This brings up several suggestions:

Warn when props are specified multiple time but the accumulate option is not set to true
Being more explicit if the api allows multiple time the same slot name by adding an accumulate option to slot
Warn when multiple slots are used but the accumulate option is not set to true
In case of several slots with the same name, use the last value to be consistent with what we do with slot

@nduitz @miguel-s @lnr0626 @msaraiva what do you think of this plan? Do you see edge cases?

@Malian
Thank you for your response.
I saw the possibility to use a slot multiple times while digging in the code. So I think you are absolutely right that slots should be marked explicitly as accumulate: true if intended, making it easier to determine to warn or not.

Regarding props, I agree we should emit a warning or even an error if there's more than one defined and accumulate is false.  This validation makes sense since the value can be either a list or an unwrapped value. This mimics the same behaviour we can find in some other places in Elixir, e.g. Module.put_attribute/3.
For slots, however, I believe we should always have them as lists as it makes the implementation much more consistent and its use more predictable (it's similar to the way most other implementations work). I might be wrong though :)

I definitely agree that we should emit at least a warning if props are specified multiple times, but accumulate is false
For slots, I'd agree we should always treat them as lists as the implementation is much simpler that way. I think the confusion may be arising because we allow <slot name="<name>" /> as short hand for <slot name="<name>" index="0" />. Would adding some additional documentation about this help?

... we allow <slot name="<name>" /> as short hand for <slot name="<name>" index="0" />

I've been using this without ever knowing that's how it actually works 😮 Some documentation around this would be really nice 👍

Would adding some additional documentation about this help?

Yeah, I believe so! 👍
Ok. That leave us with two thing to do:

Add a warning if props are specified multiple times, but accumulate is false
Update the docs to inform that slots are always lists and <slot name="<name>" /> is just a short hand for <slot name="<name>" index="0" />

I updated the title of this issue and created a new one at https://github.com/surface-ui/surface_site/issues/19 for the docs.


Move code to AsteroidOrbits.jl

x-ref: https://github.com/Astroshaper/AsteroidOrbits.jl/pull/1

Codecov Report
Patch coverage has no change and project coverage change: -1.08 :warning:

Comparison is base (5a04ff5) 27.16% compared to head (44cf3cc) 26.09%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   27.16%   26.09%   -1.08%
==========================================
  Files          17       15       -2
  Lines        1627     1307     -320
==========================================
- Hits          442      341     -101
+ Misses       1185      966     -219

Impacted Files
Coverage Δ

src/AsteroidThermoPhysicalModels.jl
100.00% <ø> (ø)

src/TPM.jl
73.52% <ø> (+10.07%)
:arrow_up:

src/coordinates.jl
0.00% <ø> (-36.46%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.