Step of demosaicing

Hi Yazhou,
An excellent work!
I notice that you use bilinear demosaicing by Python library colour_demosaicing, and I guess it is aiming to reverse this step. However, I wonder would if bilinear demosaicing would be enough for an ISP? It seems to have some disadvantages, such as colour error and blurring. Did you notice this problem?
Best,
Kenneth

Get it.
And maybe you could create a pull request to colour_demosaicing? That would be a meaningful contribution~
Anyway, thanks!

Thanks, Kenneth. Will do.


SFTokenBucket class collides with an Apple Private Class

objc[71561]: Class SFTokenBucket is implemented in both /Applications/Xcode-10.3.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/Sharing.framework/Sharing (0x1287ed228) and /Users/fbarthelemy/Library/Developer/Xcode/DerivedData/TRClient-gzzcmjoochuykxgkrnwnsjhgriqb/Build/Products/Release-iphonesimulator/Sift.framework/Sift (0x10f792340). One of the two will be used. Which one is undefined.

Apple reserves 2-letter Class Prefixes in Objective-C, so it might be safer to rename all SF* prefixed classes to SSF? -- not sure how you want to handle this.

Also, when you add a category like NSData (Gzip), you need prefix all the methods so they don't collide with client libraries. :(

This article: https://nshipster.com/namespacing/ gives some background.
This article: https://nshipster.com/at-compiler-directives/ explains @compatibility_alias which might be useful here!

Hi @fbartho, thanks for all the context here and sorry for the delay. We'll take a look at this over the next few days and then update to let you know our plan.
Any info you have on the impact on and frequency of affected users would be helpful.  Have a good weekend.

Sorry, because of this kind of collision, I can’t guarantee that we would get accurate crashlogs.
I do not have an estimate on how much this is happening in the wild. I also unfortunately can’t provide a reliable reproduction case.
My advice is entirely based on general best practices for Objective-C development on iOS — hopefully helping us catch this before it becomes an urgent problem!

@aaronTufts We are seeing this warning occur 20% of the time in our CI jobs.

I am seeing this warning also

Thanks for sharing the info everyone. We're taking a look.

Hi all, thanks for your patience here. We're starting work on this in our next sprint, which starts Monday.

Fix for this issue has been released with v2.0.0. on 02/24/2020. Please refer to change log for more details. Keeping this ticket open for few days for any post release issues.

@pjain-sift -- it looks like the 2.0.0 release isn't fully marked as the latest release?

(The code we use to update our dependency relies on the Github Releases page)

@pjain-sift -- it looks like the 2.0.0 release isn't fully marked as the latest release?

(The code we use to update our dependency relies on the Github Releases page)

Done.

Thanks @pjain-sift -- we have a PR to update our app with the new version, and at a first approximation it compiled! -- That said, we won't be able to properly test until later this week. I didn't want to leave you waiting for more immediate feedback!


add options to VectorDBQAChain.fromLLM

allows for passing VectorDBQAChain options into VectorDBQAChain.fromLLM.
updated the doc for discoverability

Closing because functionality was merged here: https://github.com/hwchase17/langchainjs/pull/283
Thanks!


python37Packages.azure-mgmt-containerservice: 14.0.0 -> 15.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.azure-mgmt-containerservice is: "This is the Microsoft Azure Container Service Management Client Library"
meta.homepage for python37Packages.azure-mgmt-containerservice is: "https://github.com/Azure/azure-sdk-for-python"
meta.changelog for python37Packages.azure-mgmt-containerservice is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 15.0.0 with grep in /nix/store/jpj3kn3k3zgiy9ddv14abjg24d88w6xb-python3.7-azure-mgmt-containerservice-15.0.0

directory tree listing: https://gist.github.com/d99cf2f91bb7d2a9b148cbebc59c7027

du listing: https://gist.github.com/5349c6b42989acd281de988e98cb72d9

Rebuild report (if merged into master) (click to expand)

13 total rebuild path(s)

4 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
azure-cli
python37Packages.azure-mgmt-containerservice
python38Packages.azure-mgmt-containerservice
python39Packages.azure-mgmt-containerservice

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jpj3kn3k3zgiy9ddv14abjg24d88w6xb-python3.7-azure-mgmt-containerservice-15.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.azure-mgmt-containerservice https://github.com/r-ryantm/nixpkgs/archive/f94e2a23ac5f7ba82cd39d8a3223403eac9fd3b4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jpj3kn3k3zgiy9ddv14abjg24d88w6xb-python3.7-azure-mgmt-containerservice-15.0.0
ls -la /nix/store/jpj3kn3k3zgiy9ddv14abjg24d88w6xb-python3.7-azure-mgmt-containerservice-15.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

python37Packages.azure-mgmt-containerservice

2 packages built:

azure-cli
python38Packages.azure-mgmt-containerservice

Maintainer pings
cc @mwilsoncoding for testing.

Result of nixpkgs-review pr 115054 at f94e2a23 run on aarch64-linux 1

3 packages built:

azure-cli
python37Packages.azure-mgmt-containerservice
python38Packages.azure-mgmt-containerservice


Use txt files to store language

  Use txt files like zh.txt  en.txt to store languages for more compatible

https://github.com/pcfantasy/RealConstruction/commit/81582967e58db1b534240e379c64d24db009961c
Use RealConstruction Mod as a test for translation update, will update this in RealCity after no issue find in RealConstruction Mod

done


Display strings for settings are missing

Looks like some strings were deleted from pakcage.nls.json
Or the settings just weren't removed if they no longer apply

Fixed.


RFC: Block Format V2

Rendered Link

Summary

Introduce different encoding for flexible length types.
Remove the epoch of the key that is lower than the watermark on the bottom level, and remove the redundant encoding of table_id in key (in storage).
Rely on statistical information to determine whether to introduce dictionary encoding for epoch.


Add option to skip certificate validation

I couldn't find any switch to disable certificate validation. Would be nice to have. I.e. if used with proxy tools like burp or proxychains.

Hi,
SSL Cert Verification is disabled by default; I defined it this way to avoid errors with self-signed certificates or when testing the tool against development environment URLs:
https://github.com/rfc-st/humble/blob/9ae4f33cec1d8fdc990c42bd36fac64df217bbae/humble.py#L766

Thanks for your reply. :)
I see. It's related to ipapi.co which you are already stating in https://github.com/rfc-st/humble#caveats. Always better to read the manual first hehe.
A switch for disabling that behaviour would be nice. Of course it's no problem to edit the source code for such seldom cases. But especially for humble installed as OS package, a switch would be the prefered solution I think.
Feel free to close this issue, if you are think there is no switch needed. :)

I will take a look at it this week to see what might be the best solution, without relying on more parameters. At first sight, maybe add also 'verify=False' in the call to ipapi.co, to avoid errors in certificate validation.
Thanks for your suggestion!,

Hello!,
Have a look at this recent commit: https://github.com/rfc-st/humble/commit/1c99b73ddc7bb5f6766cda250b681eba059f6eba

In case of any error associated with the request to ipapi.co (e.g. the URL is not accessible) the analysis will now continue as normal, without the need for the end user to modify the code beforehand.

Additionally, I have added 'verify=false' in that request to disable certificate validation.

Finally, I have removed the 'Caveats' part in the README; it is no longer needed.

I've done a couple of tests and everything seems fine. If you agree, confirm it with me and I'll close this topic.
Thanks!.

Hi rfc-st,
thanks a lot. Just tested latest master and works fine for me. :)
proxychains python3 humble.py -u https://web.site -o html -r
[proxychains] config file found: /etc/proxychains4.conf
[proxychains] preloading /usr/lib/x86_64-linux-gnu/libproxychains.so.4
[proxychains] DLL init: proxychains-ng 4.16
[proxychains] Strict chain  ...  <IP_ADDRESS>:8080  ...  ipapi.co:443  ...  OK

 Analyzing URL and saving the report, please wait ...

 Report saved to /home/vagrant/Downloads/humble-master/web.site_headers_20230915.html

By the way: I noticed, the tool does not recognize empty/failed responses by the webserver. Instead the tool lists all headers as missing, which does not makes really sense in such cases. Would be better to display an error like no response or something else. But this is another issue and shouldn't be stated here. I just wanted to let you know. :)
So again. Thanks for fixing and improving this peace of software. Issue can be closed. :)

Thanks for your confirmation!. On the other point, I will take a look at it later.


Added tabs block, added transition

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fixes #84

Added tabs block
Added fade transition when switching tabs, implemented for tabs and hero-horizontal-tabs
Small change to network-item due to an icon being shorter now
Updated spaced style to not change heading color

Test URLs:

Original: https://www.sunstar.com/about/business-performance/

Before: https://main--sunstar--hlxsites.hlx.page/_drafts/dbute/tabs/tabs

After: https://tabs--sunstar--hlxsites.hlx.page/_drafts/dbute/tabs/tabs

[x]  If you are adding a new block or a variation to an existing block, please fill below:
Block library path: https://--sunstar--hlxsites.hlx.page/tools/sidekick/library.html?plugin=blocks&path=/sidekick/blocks/&index=0

🔸 1 visual difference detected

/sidekick/blocks/sections (main vs branch)Expected an image 1312px by 6512px, received 1312px by 6295px. 320968 pixels (ratio 0.04 of all image pixels) are different.

The diff images are attached in the artifact

This is due to adding new styles to the library


Cms/jimklimov/stories/user story/jenkins is the way for networkupstools/index

Posting a success story for NUT multi-platform builds

@alyssat @MarkEWaite https://deploy-preview-14--jenkins-is-the-way.netlify.app/user-story/jenkins-is-the-way-for-networkupstools


cp: cannot stat 'enableCCUDevices.sh': No such file or directory

Hi there,
when build.sh reaches line 129 to copy the "enableCCUDevices.sh" file, it is still in the build subdirectory.
Visible when adding something like pwd && ls one line before:

Start ccu2 service
/home/pi/docker-ccu2/build
ccu2-2.29.23.tgz  docker_build	rootfs-2.29.23.ubi  ubi  ubi-2.29.23.tgz  ubi_reader
cp: cannot stat 'enableCCUDevices.sh': No such file or directory

Had to add a cd .. prior that command. Just wanted to let you know ...

Be sure to go into su interactive mode before running build.sh
sudo -i
Othwise, when you sudo build.sh, root will cd into its home directory, leaving the folder where the script is.

I will add a check for root. Thanks @TomTom101 .


copernicus.eu to be done

NAS to be returned to CLS Deadline 23/03. Adress in MoM N17.

This is done. Thanks.


Ensuring PSD func has needed functions

The webpack'd version of psd.js that we've hacked together wasn't
playing nice with ProjectView in Marvelapp, because the fromDroppedFile
was absent. I had to attach it, as well as attach the toBase64 function
to the PSD function (the main exported object) so that it could be used
in the appropriate place when the time comes (see ProjectView in an
upcoming PR on marvelapp_pie).
I realise this is somewhat hacky, but I struggled for a while to try to
mimic what the psd.js Cakefile does when it compiles the library for
the web using Browserify and failed. This works :)

great work


Notebook Markdown import/export bug with consecutive newlines

Running the export on
# %% markdown
# Hello world
#
# Test
# %%
print('hi')

gives cells of
{
  "cells": [
    {
      "cell_type": "markdown",
      "source": [
        "Hello world\n",
        "\nTest"
      ],
      "metadata": {}
    },
    {
      "cell_type": "code",
      "source": [
        "print('hi')"
      ],
      "outputs": [],
      "execution_count": null,
      "metadata": {
        "collapsed": false,
        "outputHidden": false,
        "inputHidden": false
      }
    }
  ],
  "metadata": {},
  "nbformat": 4,
  "nbformat_minor": 4
}

The issue is that there's a leading \n. So when it gets imported back into Atom, the newline is for some reason stripped and no comment symbol is included:
# %% markdown
# Hello world
#
Test
# %%
print('hi')

I think it's standard in Jupyter notebook files to not have leading newlines; I think they're usually appended to the end. But not sure if that's a requirement or just common.
Either way current Hydrogen behavior is bad on import or export or both.

I think it's the import side that doesn't abide by the standard. The nbformat documentation on cells says:

All cells have the following basic structure:
{
  "cell_type" : "type",
  "metadata" : {},
  "source" : "single string or [list, of, strings]",
}

On disk, multi-line strings MAY be split into lists of strings. When read with the nbformat Python API, these multi-line strings will always be a single string.

So to be faithful to the standard, I think the notebook import should concatenate cells into a string, then split on newlines.

This comes from commutable behavior: https://github.com/nteract/nteract/commit/4445a69a18cdb96e570734bd183fbd272a035afb#r32423015

I'll keep this open until we merge an update for commutable > 7.0.1

So now I think if we update to<EMAIL_ADDRESS>remultiline should at least work correctly, though it still isn't applied during parseNotebook

So now I think if we update to<EMAIL_ADDRESS>remultiline should at least work correctly, though it still isn't applied during parseNotebook


Add Enum support to type-stubs

This supports declaring Enum and subclasses of Enum like IntEnum inside translated files.

I think this would fail if the inspected class definition uses from enum import Enum; class Blah(Enum) instead of class Blah(enum.Enum), since we don't "rewrite" the base class qualification but still just import enum.
I think it's acceptable to enforce "module qualified" Enums when needed though - there are some other cases the type stub generator has similar requirements at the moment iirc

I think it's acceptable to enforce "module qualified" Enums when needed though - there are some other cases the type stub generator has similar requirements at the moment iirc

Good catch here. Agree that it's acceptable (if not ideal) to have this constraint, although ideally we can give that feedback when generating the stubs rather than generating invalid stubs that cause errors at check-time.


libaccesom2: Build failure when using Spack v0.21 and nci-openmpi

While testing Spack v0.21 on Gadi, the following happened when using nci-openmpi:
[gadi test-v0.21-nci-openmpi]$ spack install access-om2<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
CMake Error in /[...]/tmp/spack-stage/spack-stage-libaccessom2-master-q7h257hjh2fom5c7zgc6annmrzce2pm5/spack-build-q7h257h/CMakeFiles/CMakeTmp/CMakeLists.txt:
  Imported target "MPI::MPI_Fortran" includes non-existent path

    "/apps/openmpi/4.0.2/include/Intel:-I/apps/openmpi/4.0.2/include/Intel"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

See build log for details:
  /[...]/tmp/spack-stage/spack-stage-libaccessom2-master-q7h257hjh2fom5c7zgc6annmrzce2pm5/spack-build-out.txt

==> Warning: Skipping build of mom5-master-5vptfbmf7kqenqdzmdeuv6udjmitb6bo since libaccessom2-master-q7h257hjh2fom5c7zgc6annmrzce2pm5 failed
==> Warning: Skipping build of access-om2-latest-lzin4rut23ztsvtlq44xc5lre6sddnt4 since mom5-master-5vptfbmf7kqenqdzmdeuv6udjmitb6bo failed
==> Warning: Skipping build of cice5-master-3rqpsj5jag2qvezxs6wlrm5l3ounhwmd since libaccessom2-master-q7h257hjh2fom5c7zgc6annmrzce2pm5 failed
==> Error: access-om2-latest-lzin4rut23ztsvtlq44xc5lre6sddnt4: Package was not installed
==> Error: Installation request failed.  Refer to reported errors for failing package(s).

Testing Spack v0.21 in a Docker image with openmpi:
[root@d038f8bf660a /]# spack --version
0.21.1 (e30fedab102f9281a220fb4fae82e3f8c43a82ac)

[root@d038f8bf660a /]# spack install access-om2<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
[+] /opt/release/linux-rocky8-x86_64/intel-2021.2.0/mom5-master-jqnmk4kpfy6qkpdrmi7puxg22dfxpj7r
==> Installing access-om2-latest-uutnryfwqdj7xjhfw2srbfyleckoshiw [37/37]
==> No binary for access-om2-latest-uutnryfwqdj7xjhfw2srbfyleckoshiw found: installing from source
==> No patches needed for access-om2
==> access-om2: Executing phase: 'install'
==> access-om2: Successfully installed access-om2-latest-uutnryfwqdj7xjhfw2srbfyleckoshiw
  Stage: 0.00s.  Install: 0.00s.  Post-install: 0.07s.  Total: 0.24s
[+] /opt/release/linux-rocky8-x86_64/intel-2021.2.0/access-om2-latest-uutnryfwqdj7xjhfw2srbfyleckoshiw

[root@d038f8bf660a /]# spack find
-- linux-rocky8-x86_64 /<EMAIL_ADDRESS>------------------------------
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
-- linux-rocky8-x86_64 /<EMAIL_ADDRESS>-------------------------
access-om2@latest  <EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>                   libaccessom2@master   oasis3-mct@master
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>ca-certificates-mozilla@2023-05-30  <EMAIL_ADDRESS><EMAIL_ADDRESS>cice5@master  <EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>                    mom5@master  <EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>==> 51 installed packages

Testing Spack v0.21 on Gadi using openmpi succeeds in building libaccessom2:
[gadi test-v0.21-openmpi]$ spack install access-om2<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
[gadi test-v0.21-openmpi]$ spack find
-- linux-rocky8-x86_64_v4 /<EMAIL_ADDRESS>--------------------
access-om2@latest  <EMAIL_ADDRESS>         oasis3-mct@master
<EMAIL_ADDRESS>                     libaccessom2@master  <EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>ca-certificates-mozilla@2023-05-30  <EMAIL_ADDRESS><EMAIL_ADDRESS>cice5@master  <EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>                    mom5@master  <EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>==> 46 installed packages

==> Installing access-om2-latest-sdntrjn6funnpxiggzmj5tbgaqhxowqr [46/46]
==> No binary for access-om2-latest-sdntrjn6funnpxiggzmj5tbgaqhxowqr found: installing
from source
==> No patches needed for access-om2
==> access-om2: Executing phase: 'install'
==> access-om2: Successfully installed access-om2-latest-sdntrjn6funnpxiggzmj5tbgaqhxowqr
  Stage: 0.00s.  Install: 0.00s.  Post-install: 0.78s.  Total: 2.98s
[+] /[...]/test-v0.21-openmpi/release/linux-rocky8-x86_64_v4/intel-<IP_ADDRESS>1/access-om2-latest-sdntrjn6funnpxiggzmj5tbgaqhxowqr

Modifying nci-openmpi and setting OMPI_FCFLAGS instead of appending is a workaround:
diff --git a/packages/nci-openmpi/package.py b/packages/nci-openmpi/package.py
index 3b1006a..38b2c84 100644
--- a/packages/nci-openmpi/package.py
+++ b/packages/nci-openmpi/package.py
@@ -34,7 +34,7 @@ class NciOpenmpi(Package):
         elif self.spec.satisfies("%gcc"):
             finc_path = join_path(self.prefix.include, "GNU")
             flib_path = join_path(self.prefix.lib, "GNU")
-        env.append_path("OMPI_FCFLAGS", "-I" + finc_path)
+        env.set("OMPI_FCFLAGS", "-I" + finc_path)
         env.append_path("OMPI_LDFLAGS", "-L" + self.prefix.lib + " -L" + flib_path)

     # The following is reproduced from the builtin openmpi spack package

[gadi]$ spack install access-om2<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
==> Installing access-om2-latest-k6qc7etkb7w3r55xrlpxkfnukvbxpxzu [16/16]
==> No binary for access-om2-latest-k6qc7etkb7w3r55xrlpxkfnukvbxpxzu found: installing from source
==> No patches needed for access-om2
==> access-om2: Executing phase: 'install'
==> access-om2: Successfully installed access-om2-latest-k6qc7etkb7w3r55xrlpxkfnukvbxpxzu
  Stage: 0.00s.  Install: 0.00s.  Post-install: 0.34s.  Total: 2.09s
[+] /[...]/test-v0.21-nci-openmpi/release/linux-rocky8-x86_64_v4/intel-<IP_ADDRESS>1/access-om2-latest-k6qc7etkb7w3r55xrlpxkfnukvbxpxzu

The original CMake error for v0.21:
"/apps/openmpi/4.0.2/include/Intel:-I/apps/openmpi/4.0.2/include/Intel"

implies
OMPI_FCFLAGS="-I/apps/openmpi/4.0.2/include/Intel:-I/apps/openmpi/4.0.2/include/Intel"

I believe the error was nci-openmpi using env.append_path. This is intended for paths, so defaults to a : separator.
Instead it should have used env.append_flags which defaults to using space (" ") as the separator.
So the error seems to occur because OMPI_FCFLAGS is now being populated in v0.21. Using append_flags would not have created an error in this case, though an include flag and path would be duplicated.

The problem to solve is to find out why Spack v0.20's OMPI_FCFLAGS does NOT contain the path, whereas in v0.21, it does contain the path.

Does compiling with spack v0.20 still work with the existing package definition? If not my guess is there was some change to the NCI wrappers that started populating OMPI_FCFLAGS.

You tested the recently built access-om2 with Spack v0.20: https://forum.access-hive.org.au/t/testing-spack-model-component-builds-for-access-om2/1567/11 , that's why this issue is specifically about Spack v0.21.

Last week and again today, to double check, I tested NOT setting OMPI_FCFLAGS in nci-openmpi. In both instances, libaccessom2 failed to build.
2024/01/29
diff --git a/packages/nci-openmpi/package.py b/packages/nci-openmpi/package.py
index 3b1006a..80e2e2b 100644
--- a/packages/nci-openmpi/package.py
+++ b/packages/nci-openmpi/package.py
@@ -34,7 +34,7 @@ class NciOpenmpi(Package):
         elif self.spec.satisfies("%gcc"):
             finc_path = join_path(self.prefix.include, "GNU")
             flib_path = join_path(self.prefix.lib, "GNU")
-        env.append_path("OMPI_FCFLAGS", "-I" + finc_path)
+        #env.set("OMPI_FCFLAGS", "-I" + finc_path)
         env.append_path("OMPI_LDFLAGS", "-L" + self.prefix.lib + " -L" + flib_path)

     # The following is reproduced from the builtin openmpi spack package

1 error found in build log:
     5     -- Detecting Fortran compiler ABI info - done
     6     -- Check for working Fortran compiler: /[...]/test-v0.2
           1-nci-openmpi/spack/lib/spack/env/intel/ifort - skipped
     7     ---- PROJECT_VERSION: '2.0.202212'
     8     ---- FQDN: gadi-login-04.gadi.nci.org.au
     9     ---- NUMBER_OF_LOGICAL_CORES: 48
     10    -- Could NOT find MPI_Fortran (missing: MPI_Fortran_F77_HEADER_DIR M
           PI_Fortran_MODULE_DIR) (found version "3.1")
  >> 11    CMake Error at /apps/cmake/3.24.2/share/cmake-3.24/Modules/FindPacka
           geHandleStandardArgs.cmake:230 (message):
     12      Could NOT find MPI (missing: MPI_Fortran_FOUND) (found version "3.
           1")
     13    Call Stack (most recent call first):
     14      /apps/cmake/3.24.2/share/cmake-3.24/Modules/FindPackageHandleStand
           ardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
     15      /apps/cmake/3.24.2/share/cmake-3.24/Modules/FindMPI.cmake:1835 (fi
           nd_package_handle_standard_args)
     16      CMakeLists.txt:34 (find_package)
     17

See build log for details:
  /[...]/tmp/spack-stage/spack-stage-libaccessom2-master-alfppnrq65u25lkgvx37arfe745ck6ng/spack-build-out.txt

2024/02/07
diff --git a/packages/nci-openmpi/package.py b/packages/nci-openmpi/package.py
index 3b1006a..4bfe945 100644
--- a/packages/nci-openmpi/package.py
+++ b/packages/nci-openmpi/package.py
@@ -34,7 +34,6 @@ class NciOpenmpi(Package):
         elif self.spec.satisfies("%gcc"):
             finc_path = join_path(self.prefix.include, "GNU")
             flib_path = join_path(self.prefix.lib, "GNU")
-        env.append_path("OMPI_FCFLAGS", "-I" + finc_path)
         env.append_path("OMPI_LDFLAGS", "-L" + self.prefix.lib + " -L" + flib_path)

     # The following is reproduced from the builtin openmpi spack package

[gadi]$ spack --version
0.21.1 (e30fedab102f9281a220fb4fae82e3f8c43a82ac)

[gadi]$ spack install access-om2<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

1 error found in build log:
     5     -- Detecting Fortran compiler ABI info - done
     6     -- Check for working Fortran compiler: /[...]/test-v0.2
           1-nci-openmpi-2/spack/lib/spack/env/intel/ifort - skipped
     7     ---- PROJECT_VERSION: '2.0.202212'
     8     ---- FQDN: gadi-login-04.gadi.nci.org.au
     9     ---- NUMBER_OF_LOGICAL_CORES: 48
     10    -- Could NOT find MPI_Fortran (missing: MPI_Fortran_F77_HEADER_DIR M
           PI_Fortran_MODULE_DIR) (found version "3.1")
  >> 11    CMake Error at /apps/cmake/3.24.2/share/cmake-3.24/Modules/FindPacka
           geHandleStandardArgs.cmake:230 (message):
     12      Could NOT find MPI (missing: MPI_Fortran_FOUND) (found version "3.
           1")
     13    Call Stack (most recent call first):
     14      /apps/cmake/3.24.2/share/cmake-3.24/Modules/FindPackageHandleStand
           ardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
     15      /apps/cmake/3.24.2/share/cmake-3.24/Modules/FindMPI.cmake:1835 (fi
           nd_package_handle_standard_args)
     16      CMakeLists.txt:34 (find_package)
     17

See build log for details:
  /[...]/tmp/spack-stage/spack-stage-libaccessom2-master-alfppnrq65u25lkgvx37arfe745ck6ng/spack-build-out.txt

The root cause appears to be because nci-openmpi's setup_run_environment() is run twice on Spack v0.21, whereas, it is only run once on Spack v0.20.

The root cause appears to be that nci-openmpi's setup_run_environment() is run twice on Spack v0.21, whereas, it is only run once on Spack v0.20.

It appears that nci-openmpi's setup_run_environment() is run twice on Spack v0.21, whereas, it is only run once on Spack v0.20. This also explains why not setting OMPI_FCFLAGS fails.

Sorry, a very naive question. Is there any reason for not using the gadi OpenMPI as an external package? I'm asking because we've been doing that for the COSIMA spack instance without any issues up to now, but maybe there's something I missed?

Hi @micaeljtoliveira , How are you informing Spack built packages that are using openmpi's compilers to modify LDFLAGS/FCFLAGS to include Gadi's non-standard directory paths? e.g. For Intel compilers, LDFLAGS to include -L/apps/openmpi/4.0.2/lib/Intel and FCFLAGS to include -I/apps/openmpi/4.0.2/include/Intel?

@harshula I'm not. That's usually the job of the mpi compiler wrapper, no?

Hi @micaeljtoliveira , I'll try a build without nci-openmpi and using:
  openmpi:
    externals:
    - spec<EMAIL_ADDRESS>      prefix: /apps/openmpi/4.0.2
      modules:
      - openmpi/4.0.2
    buildable: false

Does that look correct? Let's see what happens.

It appears that nci-openmpi's setup_run_environment() is run twice on Spack v0.21, whereas, it is only run once on Spack v0.20.

Using git bisect, I found that the change of behaviour appears to have been introduced in https://github.com/spack/spack/pull/35737 .

Hi @micaeljtoliveira ,

That's usually the job of the mpi compiler wrapper, no?

This is what happens if I do NOT use nci-openmpi:
-- Could NOT find MPI_Fortran (missing: MPI_Fortran_F77_HEADER_DIR MPI_Fortran_MODULE_DIR) (found version "3.1")
CMake Error at /apps/cmake/3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find MPI (missing: MPI_Fortran_FOUND) (found version "3.1")
Call Stack (most recent call first):
  /apps/cmake/3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /apps/cmake/3.24.2/share/cmake-3.24/Modules/FindMPI.cmake:1835 (find_package_handle_standard_args)
  CMakeLists.txt:34 (find_package)

Have a look at CMakeLists.txt and the SPD and see if there's problem:
https://github.com/ACCESS-NRI/libaccessom2/blob/master/CMakeLists.txt
https://github.com/ACCESS-NRI/spack-packages/blob/main/packages/libaccessom2/package.py

Have a look at CMakeLists.txt and the SPD and see if there's problem:

Yes, there's an issue. You explicitly need to tell spack to use the mpi compiler wrappers by adding something like this to the package.py file:
    def cmake_args(self):
        return [
            self.define("CMAKE_C_COMPILER", self.spec["mpi"].mpicc),
            self.define("CMAKE_CXX_COMPILER", self.spec["mpi"].mpicxx),
            self.define("CMAKE_Fortran_COMPILER", self.spec["mpi"].mpifc),
        ]

This is a very common pattern in spack SPD's (and a bit silly in my opinion, because if one says that MPI is required, spack should use the wrappers automatically...)
I've tested the above snippet in the COSIMA spack instance and seems to works fine.

Hi @micaeljtoliveira , Compilation succeeds when cmake_args() is added. We'll also do a runtime test. Thanks! The aforementioned code appears to tell CMake where to find the MPI compilers? Is the problem in CMake's find_package(MPI)?

The aforementioned code appears to tell CMake where to find the MPI compilers? Is the problem in CMake's find_package(MPI)?

Hi @harshula, I don't think this is a CMake problem, but rather a feature. My understanding is that find_package(MPI) job is not to find out which compiler wrapper to use, just to make sure the MPI libraries and include files are correctly set.
Note that usually one also needs to explicitly pass exactly the same information to the autotools.

Hi @micaeljtoliveira , The runtime tests were successful. I definitely prefer to use openmpi directly because it simplifies supporting both Gadi and CI. While debugging this Issue, I found that CMAKE_PREFIX_PATH contained /apps/openmpi/4.0.2 and PATH contained /apps/openmpi/4.0.2/bin. Should the search for the MPI compiler happen in CMakeLists.txt?

The change in Spack v0.21 that resulted in this issue is being addressed upstream in https://github.com/spack/spack/issues/42700 and spack-packages in https://github.com/ACCESS-NRI/spack-packages/issues/65 . Next, I'll make the change in libaccessom2's SPD.

Documentation has been updated too:

https://forum.access-hive.org.au/t/how-to-build-access-om2-on-gadi/1545
https://github.com/ACCESS-NRI/spack-config/issues/5

Should the search for the MPI compiler happen in CMakeLists.txt?

@harshula I've been investigating a bit more the behaviour of CMake+MPI and it seems that CMake is supposed to figure out how to correctly compile an MPI program without using the wrappers (that would be one of the jobs of find_package(MPI)). This does not seem to work correctly on Gadi because of the "special" way how compilers and MPI libraries are installed and used.
The way to circumvent this problem on Gadi when using CMake directly, is simply to explicitly set the compilers with the corresponding CMake options (CMAKE_Fortran_COMPILER and CMAKE_C_COMPILER). When using Spack, this is slightly more complicated, as Spack doesn't easily let you do that in the spack.yaml files, so one needs to do it either by adding a new MPI package like was done when using nci-openmpi or by modifying the SPD's like I suggested.
I guess in the end there's no "correct" way of doing this, as NCI will not change the way they install their software anytime soon, so I would argue for whatever is more convenient for us.

Notes
Loading the CMake module is not a workaround that can replace setting CMAKE_*_COMPILER:
diff --git a/common/gadi/packages.yaml b/common/gadi/packages.yaml
index 28bb638..19e1e3c 100644
--- a/common/gadi/packages.yaml
+++ b/common/gadi/packages.yaml
@@ -12,6 +12,7 @@ packages:
     externals:
     - spec<EMAIL_ADDRESS>       prefix: /apps/cmake/3.24.2
+      modules: [cmake/3.24.2]
     buildable: false
   openmpi:
     externals:

Hi @micaeljtoliveira ,
The libaccessom2 build succeeds on Gadi, even without the MPI compiler wrappers being passed explicitly to CMake, when extra_attributes was added to packages.yaml. e.g.
    - spec<EMAIL_ADDRESS>      prefix: /apps/openmpi/4.1.5
      extra_attributes:
        environment:
          prepend_path:
            CMAKE_PREFIX_PATH: /apps/openmpi/4.1.5/include/Intel
      modules: [openmpi/4.1.5]

@harshula That's interesting. It just confirms what I wrote above regarding the way paths are set by the environment modules on Gadi. In any case, I guess setting the prefix is slightly cleaner than setting CMAKE_Fortran_COMPILER and CMAKE_C_COMPILER.

Hi @micaeljtoliveira ,
Upstream Spack removed the MPI compiler wrappers being passed explicitly to CMake in the FMS SPD (https://github.com/spack/spack/commit/d21aa1cc124a8f005c8d400637dc180e6ab85529#diff-f04fae00f6c65e2738850eed4ec088e76c09a1fe79d8516cfd51af8dd0e89aa4L115-L118). This could be the direction Spack is moving in.
I had added a revert of the FMS change to our fork of Spack v0.22. I'm not planning on keeping that revert when we move to Spack v0.23.


add cadlranch test cases for type/union

Description
The current implementation of convenience method with union types is incorrect.
The operation involving with union types will be "low confident" when the confident level change merges, therefore all the convenience methods in this new test project will be removed internal.
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

@lirenhe this PR is now ready for review again


Update to Leaflet 1.x

Biggest problem will be the extensions. Some of them are old and were not updated for years.

See d855a75c17f7988a332b4cc33acf5a4cb2ca5a79 for a first try.
(Measurement)[https://github.com/jtreml/leaflet.measure] was last updated three years ago. After a small fix basic measurement works, but a path cannot be finished. Also the mouse cursor flickers.

Implemented in the leaflet-1.0 branch which will be merged to master after some time of testing.


Problems with Shaarli v. 0.12.1

I've been using Material for a long time now with a particular Shaarli instance (beginning around v. 0.9, I think). I've been keeping things up-to-date, though, and today upgraded my Shaarli's to 0.12.1 (from 0.11.1). With the default template, everything is fine. With Material (latest!), however, I get this error message:
An unexpected error happened, and the error template could not be displayed.

Template error not found!
/home/mysite/public_html/shaarmarks/inc/rain.tpl.class.php268
#0 /home/mysite/public_html/shaarmarks/inc/rain.tpl.class.php(164): RainTPL->check_template('error')
#1 /home/mysite/public_html/shaarmarks/application/render/PageBuilder.php(253): RainTPL->draw('error', true)
#2 /home/mysite/public_html/shaarmarks/application/front/controller/visitor/ShaarliVisitorController.php(66): Shaarli\Render\PageBuilder->render('error', '/shaarmarks')
#3 /home/mysite/public_html/shaarmarks/application/front/controller/visitor/ErrorController.php(45): Shaarli\Front\Controller\Visitor\ShaarliVisitorController->render('error')
#4 [internal function]: Shaarli\Front\Controller\Visitor\ErrorController->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Error))
#5 /home/mysite/public_html/shaarmarks/vendor/slim/slim/Slim/App.php(728): call_user_func_array(Object(Shaarli\Front\Controller\Visitor\ErrorController), Array)
#6 /home/mysite/public_html/shaarmarks/vendor/slim/slim/Slim/App.php(396): Slim\App->handlePhpError(Object(Error), Object(Slim\Http\Request), Object(Slim\Http\Response))
#7 /home/mysite/public_html/shaarmarks/vendor/slim/slim/Slim/App.php(297): Slim\App->process(Object(Slim\Http\Request), Object(Slim\Http\Response))
#8 /home/mysite/public_html/shaarmarks/index.php(176): Slim\App->run(true)
#9 {main}

I have read through the "Compatibility with Shaarli v0.12.0-beta" #115 thread, and I'm none the wiser. Grateful for any help with this — I miss Material! (Update 2020-11-20 : I missed Material so much that I rolled that instance back to 0.11.1! So normal service is resumed, although it would be great to have this running with 0.12.1, too.)

Exactly the same situation here. Thank you for any hint as where to go now.
Salutations

Exactly the same situation here, even the same error message. Thank you for any hint as where to go now.
Salutations

I rolled back to 0.11.1 Shaarli on the instance that I use with Material. Hopefully we can work out (or Kalvn can! 😬) how to get this working with 0.12.1.

I didn't have enough time to start working on v0.12.1 (which seems to be massive) compatibility but I'll try to do that soon!

I didn't have enough time to start working on v0.12.1 (which seems to be massive) compatibility but I'll try to do that soon!

Grateful for that! I've actually had a look a few times at trying to create a "minimalist" theme for Shaarli (something I've done with my CMS of choice quite few times over the years). It looks anything but easy with Shaarli, and all the trickier if a point-upgrade brings so many changes! So thanks for keeping Material up-to-date.

Many projects treat the 0th major release as unstable where even point releases can break things, and maintainers don't guarantee compatibility with earlier releases, so while this is being annoying, this is how the world works. Shaarli is about to get its 1st major release in some time, then point releases shouldn't break so many things: https://github.com/shaarli/Shaarli/issues/1640

I just published v0.12.0 https://github.com/kalvn/Shaarli-Material/releases/tag/v0.12.0 which should solve that problem.
Working on v0.12.1 now :)

I just published v0.12.0 https://github.com/kalvn/Shaarli-Material/releases/tag/v0.12.0

Thank you very much. I'm only in this situation because I like your work so much. So thank you for sharing it!

This theme is great ! But, when using it with shaarli v0.12.1, the red "plus" button is missing (the button used to add new links)

You can follow this issue here @pascollin : https://github.com/kalvn/Shaarli-Material/issues/117

I've rebuilt my Shaarli using the support-v012 branch, and now all my previously observed issues are gone. There were some unnoticed changes on that branch in November, I suggest you all to try it :) Happy new year to everyone! :tada:

I've rebuilt my Shaarli using the support-v012 branch,...

Thanks for the pointer, @immanuelfodor — but I can't identify any branch with that name. Has it been erased? or is the name not quite right? or am I looking in the wrong place?

Happy new year to everyone! 🎉

Ditto! 👍

I've rebuilt my Shaarli using the support-v012 branch,...

Thanks for the pointer, @immanuelfodor — but I can't identify any branch with that name. Has it been erased? or is the name not quite right? or am I looking in the wrong place?

Happy new year to everyone! 🎉

Ditto! 👍

Fixed in v0.12.1.

FYI: I had similar symptoms (but different cause). My problem was due to folder/file permissions on the /data and /cache folders and subfolders.
When I reinstalled Synology DSM (this is where docker is installed and Shaarli is hosted)... I forgot about making the /data and /cache folders writeable to "users".
To fix MY problem: I stopped the container, stopped inheritence of permissions for /shaarli folder in docker, then made /data and /cache writeable to 'users'. Then I restarted the container and it started up with no problems!
Hopefully this anecdote/scenario can help someone else with a similar (Synology-related) problem in the future.


Fix NSMutableURLRequest setValue:forHTTPHeaderField: method to match reference platform behavior

Fixes #762

@DHowett-MSFT is added to the review. #Closed

@ms-jihua is added to the review. #Closed

Title for this PR seems incorrect :)

Thanks github. I have no idea how it populated this

In reply to: 237972440 [](ancestors = 237972440)

You can edit it!

In reply to: 237972693 [](ancestors = 237972693,237972440)

:shipit:

:shipit:


modification download

Currently, the link takes you directly to the Ftp site.
I think it would be better if we had a page like GO and FYPO where the format is described (and also duplicate this in the README)
The format is currently only available from the submission page:
https://www.pombase.org/documentation/modification-data-bulk-upload-format
(also I think the export format now has an assigned_by column so we need to add that)

At the same time can we change the assigned by Label from UniProt to UniProtKB

At the same time can we change the assigned by Label from UniProt to UniProtKB

I've made that change.

While we're doing this I think we should rename the file.  Currently it's pombase-chado.modifications.gz.  The "chado" isn't meaningful to most users.  I don't know why I did that.  :-)
I'd prefer something like: pombase_protein_modifications.tsv.gz
I like having the "pombase" in the file name because I've had cases where I've downloaded a file and then later on couldn't remember where I got it.  "pombe" in the file name would work too.

I've made a first attempt at a modifications file documentation page, linked from the Datasets page:

https://www.pombase.org/datasets
https://www.pombase.org/downloads/modifications

It can be edited here: https://github.com/pombase/website/blob/master/src/docs/downloads/modifications.md
I'd like to improve the description for "assigned_by" and perhaps we need to describe what the extensions mean?

I think pombase is good in the label. It's clearer than just pombe and will remind people

I think the docs are great, nice clear and concise.
For extensions we could refer people to the full list on  the submission page
https://www.pombase.org/documentation/modification-data-bulk-upload-format

For extensions we could refer people to the full list on the submission page
https://www.pombase.org/documentation/modification-data-bulk-upload-format

Thanks.  That solves that problem!

I'd prefer something like: pombase_protein_modifications.tsv.gz

That will be updated in the morning.
I'll close this after checking tomorrow.


I suspect typescript is having trouble with multiple tsconfig files in one window

I think the crashing started after installing vetur.

VSCode Version: Code 1.15.0 (8b95971d8cccd3afd86b35d4a0e098c189294ff2, 2017-08-09T20:06:21.685Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

vscode-docker
Pet
0.0.16

vscode-eslint
dba
1.2.11

githistory
don
0.2.3

python
don
0.7.0

gitlens
eam
4.3.3

LogFileHighlighter
emi
1.1.1

flow-for-vscode
flo
0.7.1

terraform
mau
0.0.16

vscode-clang
mit
0.2.2

cpptools
ms-
0.12.2

vetur
oct
0.9.3

java
red
0.8.0

bash-debug
rog
0.1.0

vscode-hexdump
sle
1.4.0

gitblame
wad
2.1.0

Steps to Reproduce:

Reproduces without extensions: Yes/No

@ubershmekel Please provide more information. Sample project, what do you see, what do you expect.

I got these errors in vs code:

The Vue Language Server server crashed 5 times in the last 3 minutes. The server will not be restarted. [Close]

The TypeScript language service died unexpectedly 5 times in the last 5 Minutes. [Report Issue]

I clicked Report Issue which created this github issue. Note there is no "Dismiss" button - it practically forces you to visit the github issue creation page.
This is what appears in the Output window.
[Error  - 11:09:08 AM] 'getApplicableRefactors' request failed with error.
Error: Service died.
    at TypeScriptServiceClient.serviceExited (/Users/yuval/Downloads/Visual Studio Code.app/Contents/Resources/app/extensions/typescript/out/typescriptServiceClient.js:400:32)
    at ChildProcess.childProcess.on (/Users/yuval/Downloads/Visual Studio Code.app/Contents/Resources/app/extensions/typescript/out/typescriptServiceClient.js:311:30)
    at emitTwo (events.js:111:20)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
[Info  - 11:09:50 AM] TSServer exited
[Info  - 11:09:50 AM] Using tsserver from: /Users/yuval/Downloads/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib
[Info  - 11:09:50 AM] Forking TSServer
PATH: /Users/yuval/Library/Python/2.7/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/Applications/Wireshark.app/Contents/MacOS
[Info  - 11:10:33 AM] TSServer exited
[Info  - 11:10:33 AM] Using tsserver from: /Users/yuval/Downloads/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib
[Info  - 11:10:33 AM] Forking TSServer

I was later able to get this output as well:
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 2: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 3: v8::internal::FatalProcessOutOfMemory(char const*) [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 4: v8::internal::FatalProcessOutOfMemory(char const*) [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 5: v8::internal::Factory::NewByteArray(int, v8::internal::PretenureFlag) [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 6: v8::internal::SourcePositionTableBuilder::ToSourcePositionTable(v8::internal::Isolate*, v8::internal::Handle<v8::internal::AbstractCode>) [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 7: v8::internal::Factory::NewJSFixedArrayIterator(v8::internal::Handle<v8::internal::FixedArray>) [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 8: v8::internal::Factory::NewJSFixedArrayIterator(v8::internal::Handle<v8::internal::FixedArray>) [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 9: v8::internal::compiler::SourcePositionTable::Print(std::__1::basic_ostream<char, std::__1::char_traits<char> >&) const [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
10: v8::internal::compiler::SourcePositionTable::Print(std::__1::basic_ostream<char, std::__1::char_traits<char> >&) const [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
11: v8::internal::compiler::SourcePositionTable::Print(std::__1::basic_ostream<char, std::__1::char_traits<char> >&) const [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
12: v8::internal::compiler::SourcePositionTable::Print(std::__1::basic_ostream<char, std::__1::char_traits<char> >&) const [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
13: v8::internal::RegisterConfiguration::AreAliases(v8::internal::MachineRepresentation, int, v8::internal::MachineRepresentation, int) const [/Users/yuval/Downloads/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
14: 0xcd6004843a7
15: 0xcd60048474d
16: 0xcd600ac1bc6
17: 0xcd600a6f08c
18: 0xcd600a6f8e5
19: 0xcd600c3a612
[Info  - 11:22:51 AM] Connection to server got closed. Server will restart.```

My machine has 16GB physical memory and only 11.35 is used when this happened.

I tried to reproduce the issue a few ways. Copying the code workspace did not reproduce the typescript server crash, it did reproduce the vue server crash. I'm giving up on figuring this one out. I'll just stick to react and flow for this project. Feel free to close this issue. Thanks.

Thanks for the quick followup.
If this only repos when you have Veture enabled, please try filing an issue against that extension. Closing this issue as caused by extension. Please let me know if you hit this bug again with extensions disabled.


Mac support? (vLLM)

noob here, does this mean no mac support, "AssertionError: vLLM only supports Linux platform (including WSL)."

+1 on this

+1

Hi we currently have no plans. If you are interested, feel free to submit a PR. Thanks.


ref: Expose the message in the producer callback

In Relay I need access to the message in order to emit it as a datadog metric. This exposes the message but still keeps the serialization opaque.
#skip-changelog

In Relay I need access to the message in order to emit it as a datadog metric. This exposes the message but still keeps the serialization opaque.

I am not sure I understand the rationale here. When you want to produce COGS data as datadog metrics why do you need to go through Kafka at all ? Also wouldn't that be a problem with pops ?
I think having the same interface (the usage accountant) is not a bad idea, that makes it harder to remove accidentally datadog metrics that the cogs pipeline relies upon. Though what about just have a separate implementation of the accountant that only produces to datadog on its own ?

I am not sure I understand the rationale here. When you want to produce COGS data as datadog metrics why do you need to go through Kafka at all ?

I don't that's why I'd like to switch out the producer from Kafka with a custom one which just emits a statsd metric in Relay.

Though what about just have a separate implementation of the accountant that only produces to datadog on its own ?

I thought about vendoring it, but I ended up thinking I'd rather not vendor the implementation into Relay if we have the crate. What would be an option is to make the accumulator public and Relay just uses that instead of the accountant. Ultimately though I preferred increasing the typing of the producer trait.

Diff of the changes put to use in Relay

I don't that's why I'd like to switch out the producer from Kafka with a custom one which just emits a statsd metric in Relay.

Ok, that makes sense to me. The title and description of this PR made me thing to something different.

I thought about vendoring it, but I ended up thinking I'd rather not vendor the implementation into Relay if we have the crate. What would be an option is to make the accumulator public and Relay just uses that instead of the accountant. Ultimately though I preferred increasing the typing of the producer trait.

I did not mean vendoring it but rather make it a trait with two implementations (Kafka and datadog) or having a custom producer that actually writes to datadog. Which seems to be what you are doing.

Not necessary anymore, we'll eventually remove the entire lib from Relay.


boards: renesas: Add support for Renesas RA entropy running on TRNG HWIP

Initial support for entropy driver running on Renesas RA TRNG HWIP
Enable entropy support on board:

fpb_ra6e2
ek_ra6e2
ek_ra4e2
ek_ra2a1

Needs rebase due to merge conflict

@khoa-nguyen-18 still has a merge conflict 😐

Sorry for the late rebase, I've just rebased and solved the conflicts


print errors as JSON with --output-format=json

Fixes #216
Several caveats that we can potentially hammer out now or over time:

The errors will however still go to stderr rather than stdout, as a current artifact of the order we set things up in.
Two major classes of errors, Audit Violations and Unvetted Dependencies, are currently treated
Very early errors like CLI parsing will not have this format, as we cannot at that point "know" what you want
Panics will not have this format
I don't really know the full schema of this format at the moment, but some examples can be found in the checked in snapshots

Here is the complex example, pretty formatted:
{
    "message": "There are some issues with your policy.audit-as-crates-io entries",
    "severity": "error",
    "labels":
    [],
    "related":
    [
        {
            "message": "Some first-party packages match published crates.io versions\n firstA:10.0.0\n firstAB:10.0.0\n firstB:10.0.0\n firstB-nodeps:10.0.0",
            "severity": "error",
            "help": "Add a `policy.*.audit-as-crates-io` entry for them",
            "labels":
            [],
            "related":
            []
        },
        {
            "message": "some audit-as-crates-io packages don\'t match published crates.io versions\n rootA:10.0.0\n rootB:10.0.0",
            "severity": "error",
            "help": "Remove the audit-as-crates-io entries or make them `false`",
            "labels":
            [],
            "related":
            []
        }
    ]
}

It seems like json parsers are mad about ' getting escaped, I'll look into this upstream.

filed https://github.com/zkat/miette/pull/180 for the escaping thing

cc @glandium

Looking at the code, the following fields can be in a JSON error:

message
code
severity ("error" | "warning" | "advice")
url
help
filename
labels (array of objects)

label
span (object)

offset
length

related (array of this object recursively)

upstream fix landed and pulled in


Notebook pipelines: support directories and wildcards as "output files"

Before a notebook is executed it might not be known what the exact file names are that a notebook generates and wishes to make available to subsequent notebooks. Testing 1.0.0 Beta it appears that currently wildcards or directories are not supported as "Output Files" values.
Example scenario:

The first (generic) notebook downloads a compressed archive, extracts the content, processes it and stores the resulting X data files in a well known location, e.g. data/. How many data files are being produced is not known ahead of time.
As a user I currently cannot define the "Output Files" that I want to share with subsequent notebooks  because wildcards (e.g. data/*) and directory names (e.g. data/ or data) cause a post-processing error, such as

Uploading file data/* as data/* to bucket ptitzler
Unexpected error: <class 'FileNotFoundError'>
Converting from ipynb to html....
Uploading Errored Notebook back to Object Storage
Uploading file load_data-output.ipynb as load_data.ipynb to bucket ptitzler
Uploading file load_data.html as load_data.html to bucket ptitzler
Traceback (most recent call last):
  File "bootstrapper.py", line 219, in <module>
    put_file_to_object_storage(cos_client, input_params['cos-bucket'], file)
  File "bootstrapper.py", line 146, in put_file_to_object_storage
    file_path=file_to_upload)
  File "/usr/local/lib/python3.7/site-packages/minio/api.py", line 696, in fput_object
    with open(file_path, 'rb') as file_data:
FileNotFoundError: [Errno 2] No such file or directory: 'data/*'

This was fixed by #702.

@kevin-bates I am still able to reproduce the behavior using 1.0.0.rc2.

log file:
Get file load_data-1b2fc3fa-2b94-4ad8-8caa-c650e5440f62.tar.gz from bucket ptitzler
Processing dependencies........
TAR Archive pulled from Object Storage.
Unpacking........
Unpacking Complete.
Executing notebook through Papermill: load_data.ipynb ==> load_data-output.ipynb
Converting from ipynb to html....
Uploading Result Notebook back to Object Storage
Uploading file load_data-output.ipynb as load_data.ipynb to bucket ptitzler
Uploading file load_data.html as load_data.html to bucket ptitzler
Processing outputs........
Uploading file data/noaa-weather-data-jfk-airport/* as data/noaa-weather-data-jfk-airport/* to bucket ptitzler
Unexpected error: <class 'FileNotFoundError'>
Converting from ipynb to html....
Uploading Errored Notebook back to Object Storage
Uploading file load_data-output.ipynb as load_data.ipynb to bucket ptitzler
Uploading file load_data.html as load_data.html to bucket ptitzler

I'm sorry @ptitzler - I was thinking dependencies and inputs, not outputs.  You're correct in re-opening.

This will be addressed in the kfp-notebook repo, transferring now.


Add missing sourcemaps

This PR fixes the missing map files lookup.
As far I understood, the in-memory-web-api folder works just as a temporary folder so there's no problem of declaring the sourceRoot - since the files that the developer will be using are the ones at the root folder.
Fixes #7.
BTW, the project would definitely benefit with a refactor to the build process (and some documentation 😄).

I signed it!

I'm waiting for this.
When merge?

@filipesilva any chance we could get this in?

Thanks for these changes!

You're welcome. Thanks for the merge.


Updated Hello World for C Shell scripts

Description

Types of changes

[ ] Bug fix or improving code quality
[x] New language
[ ] New feature

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.

Added C Shell to the list


eslintls installation fails

To reproduce:

Uninstall eslintls using LspUninstall eslintls
Quit Neovim
Install it back using LspInstall eslintls
Get an erroneous output

LspInfo output
Configured servers: cssls, emmet_ls, tsserver, html, eslintls
Neovim logs at: /home/zlksnk/.cache/nvim/lsp.log
1 client(s) attached to this buffer: tsserver
Client: tsserver (id 1)
root:      /home/zlksnk/personal/s
filetypes: javascript, javascriptreact, javascript.jsx, typescript, typescriptreact, typescript.tsx
cmd:       /home/zlksnk/.local/share/nvim/lsp_servers/tsserver/node_modules/.bin/typescript-language-server --stdio
1 active client(s):
Client: tsserver (id 1)
root:      /home/zlksnk/personal/s
filetypes: javascript, javascriptreact, javascript.jsx, typescript, typescriptreact, typescript.tsx
cmd:       /home/zlksnk/.local/share/nvim/lsp_servers/tsserver/node_modules/.bin/typescript-language-server --stdio
Clients that match the filetype javascript:
Config: emmet_ls
filetype: No filetypes defined, please define filetypes in setup().
Config: tsserver
cmd:               /home/zlksnk/.local/share/nvim/lsp_servers/tsserver/node_modules/.bin/typescript-language-server --stdio
cmd is executable: True
identified root:   /home/zlksnk/personal/s
custom handlers:
Config: eslintls
filetype: No filetypes defined, please define filetypes in setup().

Version info:
Plugin commit: d10094cc9854c4616075c900dc47d4487b1d4d5d
Nvim version: NVIM v0.5.0-dev+1233-g82ac44d01 \ Build type: RelWithDebInfo
Node.js version: 14.16.0
NPM version: 6.14.11
Operating system: Ubuntu 20.04.2 LTS on Windows 10 x86_64
Additional information: NPM 6 uses v1 lockfile but eslintls uses v2.

I can't seem to repro. What OS are you on? Could you try manually cloning https://github.com/microsoft/vscode-eslint and run (with the Node and NPM version you've listed):
$ npm install
$ cd server
$ npm install
$ npx tsc

npx tsc fails with that error:
error TS6047: Argument for '--target' option must be 'ES3', 'ES5', or 'ES6'.
error TS5023: Unknown compiler option 'moduleResolution'.
error TS5023: Unknown compiler option 'lib'.

npx tsc -v output:
message TS6029: Version 1.5.3

I'm on WSL (Ubuntu 20.04.2 LTS on Windows 10 x86_64). I can reproduce the same issue on an another machine running Ubuntu.

Instead of $ npx tsc could you try $ ../node_modules/.bin/tsc? I'll try to get a repro going

Ok I can repro on an Ubuntu machine. Problem seems to indeed be with npx tsc. #9 seems to fix it, are you somehow able to try that branch locally (issue-7)?

I can confirm that #9 resolves the issue.


mail client

make sure client is properly implemented

implement j.client using our new config mgmt

learn how to do it in template for client

verified.


Stream array elements so don't a have to load entire hash in memory?

Is this possible - i.e. so you pass in a block to handle array elements?

This issue is duplicate of #11. Will close it as more old.


Cleanup Docs

[ ] Get into intro example earlier and make it more clear.
[ ] ?? I had a few more ideas after reading https://github.com/noffle/art-of-readme but forgot to document them. Maybe read again.

I tried to do this for SLEEP update.


Add support for annotations with grammar

Recent additions to just added [annotations("with-arguments")]:
[group("foo"), group("echo")]
foo:
  echo "foo"

[doc("this is bar")]
bar:
  echo "bar"

https://just.systems/man/en/chapter_35.html
https://just.systems/man/en/chapter_28.html
Fixes https://github.com/IndianBoy42/tree-sitter-just/issues/164

Getting some issues with npx tree-sitter:
$ just test-parse-highlight
+ '[' '!' -d ~/Documents/tree-sitter/just/repositories/just ']'
++ git -C ~/Documents/tree-sitter/just/repositories/just rev-parse HEAD
+ actual_sha=5f91b37c82e6a92df2575babcb17a6a8e9c505f7
+ '[' 5f91b37c82e6a92df2575babcb17a6a8e9c505f7 '!=' 5f91b37c82e6a92df2575babcb17a6a8e9c505f7 ']'
Checking parsing and highlighting...
Checking '~/Documents/tree-sitter/just/test/issue69-segfault.just': parse'
Unknown scope 'source.just'
Traceback (most recent call last):
  File "/var/folders/46/8kdrb66s5hg5bpjclp5wqpqh0000gn/T/just-M5x9MF/test-parse-highlight", line 208, in <module>
    sp.check_output(
  File<EMAIL_ADDRESS>line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['npx', 'tree-sitter', 'parse', PosixPath('~/Documents/tree-sitter/just/test/issue69-segfault.just'), '--scope', 'source.just']' returned non-zero exit status 1.
error: Recipe `test-parse-highlight` failed with exit code 1

Thanks for updating, could you rerun just setup (or only npm install --include=dev) and then just gen? Probably something got out of sync

Thank you for the PR!


VPC Endpoints - AppStream, Athena & Rekognition

Description
Add the following VPC Endpoints:

Athena
Rekognition
AppStream

Another great addition! Thanks @DrFaust92 !
v2.16.0 has been just released.


digest calculating functions return an embedded string in python2

rgc.get_asset_digest('rCRSd', 'fasta')
"u'4eb430296bc02ed7e4006624f1d5ac53"

refgenie id rCRSd/fasta -c refgenie.yamlrCRSd/fasta:default,u'4eb430296bc02ed7e4006624f1d5ac53

Maybe this is just a python2 issue, I should try again with python3.

this originates in the building process, more precisely in the digests calculation. So the "faulty" hashes are saved in the config and simply returned by refgenie id or get_asset_digest. So I transferred the issue here

OK this is fixed now.
But what's the rationale for the id function behavior difference in the python vs CLI API?
on the CLI you get the string identifier, comma, then the digest.
refgenie id -c refgenie.yaml hs38d1/fasta:default -s
hs38d1/fasta:default,eddf5466faa3391a7114e87648466dcb
in the API you get just the digest.

that's because you can specify multiple using CLI:
[mstolarczyk@MichalsMBP r]: refgenie id -g rCRSd -a fasta bowtie2_index -c g.yaml
rCRSd/fasta:default,4eb430296bc02ed7e4006624f1d5ac53
rCRSd/bowtie2_index:test,1262e30d4a87db9365d501de8559b3b4

But I don't feel strongly about keeping that if you think it's cumbersome to have it return the asset registry path.
Alternatively, we could return just the hash if just one is specified

Yeah I figured that was the case. I have a slight preference for just returning the hash...well, I guess that causes other problems.
just leave it for now.

[mstolarczyk@MichalsMBP r]: refgenie id -g rCRSd  -a fasta bwa_index -c g.yaml
rCRSd/fasta:default,4eb430296bc02ed7e4006624f1d5ac53
rCRSd/bwa_index:default,de383551ccf544bd9bbee7d4c529f39b
[mstolarczyk@MichalsMBP r]: refgenie id -g rCRSd  -a fasta -c g.yaml
4eb430296bc02ed7e4006624f1d5ac53


Data tile BE: Transactions burning most steps

⚠ ATTENTION: This is a DRAFT task for the upcoming OD Hack. We will start assigning issues after Thursday, May 23rd. Feel free to join our telegram to get latest updates: https://t.me/+DYI4FMia43I1NDI8
Update the get_common_data function in the https://github.com/walnuthq/starkflare-indexer backend repo to include a new field in the response called top_transactions_by_steps. This field should contain a list of the top 10 transactions that consumed the highest amount of steps over the last 7 days.
For each transaction in the top_transactions_by_steps list, include the following data:

Transaction hash
Number of steps consumed
Timestamp of the transaction
Block number in which the transaction was included

Implement a new function to retrieve this data and call it from within the get_common_data function.
Note: The top_transactions_by_steps field should be added to the existing response format of get_common_data without modifying the other fields.
The exact data format as well as more instructions defined in: https://github.com/walnuthq/starkflare/issues/8

Hi, can I work on this?

Can I work on this issue?

Hello, my name is Adrian Vargas, I am a software engineer working at HPE and currently trying to get involved in the web3 world.
I would tackle this issue by first understanding the context of the problem, reading carefully all the documentation I can access and asking experienced developers in this project questions so I get everything clear. Then I would probably start to code following any guidelines and formats the project may have. After I have the solution I would run multiple tests just to make sure my job is done.

Can I hop on this?

None of the comments contains any specifics on how to resolve the issue. We are keeping it open for anyone to grab

I am Backend dev. To solve this, I will create a new function to query the database for the top 10 transactions consuming the highest steps over the last 7 days. I will also update the get_common_data function to call this new function and include the retrieved data in the response. @mazurroman

Hello, my name is Adrián Vargas, I am a passionate developer introducing himself to the web3 world, I am currently a machine learning developer for HPE and I really enjoy coding. I would approach this issue as following:
Understand Requirements: Carefully read and understand the requirements outlined in the issue #8. Understand what needs to be achieved and how the new field should be added to the response format.
Review Existing Code: Go through the existing codebase, specifically the get_common_data function in the starkflare-indexer backend repository. Understand how the function is structured and how it currently generates the response.
Identify Data Source: Determine where the data for the new field, top_transactions_by_steps, will be sourced from. This may involve querying transaction data from the blockchain or accessing a database where transaction information is stored.
Implement New Function: Create a new function, let's call it get_top_transactions_by_steps, to retrieve the required data. This function should fetch the top 10 transactions that consumed the highest amount of steps over the last 7 days. Each transaction should include the transaction hash, number of steps consumed, timestamp, and block number.
Modify Response Format: Update the get_common_data function to include the new field top_transactions_by_steps in its response format. Ensure that this modification does not affect the existing response format or other fields returned by the function.
Integrate New Function: Call the get_top_transactions_by_steps function from within the get_common_data function. Populate the top_transactions_by_steps field with the data retrieved from this function.
Test: Test the modified get_common_data function to ensure that it returns the expected response format with the new field included. Verify that the top_transactions_by_steps field contains accurate data for the top 10 transactions consuming the highest amount of steps over the last 7 days.

Hi everyone! Thank you for your interest and comments. We have assigned this issue to @adrianvrj, who provided the most detailed response.


wordpress: added ro_RO language + updated plugins,themes and languages

Description of changes

I added the ro_RO locale and ran the ./generate.sh which updated all wp language theme and plugin packages
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 225141 run on x86_64-linux 1

Result of nixpkgs-review pr 225141 run on x86_64-linux 1

1 test built:

nixosTests.wordpress

Thank you!


Update Antrea Octant plugin to support latest Octant version

We can now support Octant 0.24 (latest version). Older versions (up to
0.19) may be supported as well (not tested).
By updating the Octant module dependency to v0.24.0, we can also start
using the Octant Dashboard client to perform CRUD operations on Antrea
CRDs, thus ensuring that the plugin is always using the correct cluster
context (see #1519).
A few other notable things:

We can remove replace directives in the plugin go.mod file (for now?)
since K8s dependencies between Antrea and Octant are compatible.
Octant now has a new logging mechanism for plugins but unfortunately
it is still buggy so we are not updating our plugin to use it.
The Dashboard client supports a link generator to easily generate
links to resources
(https://github.com/vmware-tanzu/octant/pull/2276). Unfortunately I
believe that in practice it would make our plugin code more
complicated. We can revisit this in the future.

Fixes #1519
Fixes #2315
Fixes #2676
Signed-off-by: Antonin Bas<EMAIL_ADDRESS>

Codecov Report

Merging #2951 (d10e035) into main (ae2b53d) will decrease coverage by 6.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2951      +/-   ##
==========================================
- Coverage   59.18%   52.62%   -6.57%
==========================================
  Files         283      283
  Lines       23812    23822      +10
==========================================
- Hits        14094    12537    -1557
- Misses       8213     9898    +1685
+ Partials     1505     1387     -118

Flag
Coverage Δ

kind-e2e-tests
31.28% <ø> (-15.00%)
:arrow_down:

unit-tests
40.54% <ø> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/controller/types/networkpolicy.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/apis/controlplane/v1beta2/helper.go
33.33% <0.00%> (-66.67%)
:arrow_down:

...formers/externalversions/security/v1alpha1/tier.go
0.00% <0.00%> (-64.29%)
:arrow_down:

...ers/externalversions/core/v1alpha2/clustergroup.go
0.00% <0.00%> (-64.29%)
:arrow_down:

...s/externalversions/core/v1alpha2/externalentity.go
0.00% <0.00%> (-64.29%)
:arrow_down:

...xternalversions/security/v1alpha1/networkpolicy.go
0.00% <0.00%> (-64.29%)
:arrow_down:

...versions/security/v1alpha1/clusternetworkpolicy.go
0.00% <0.00%> (-64.29%)
:arrow_down:

pkg/agent/controller/networkpolicy/packetin.go
4.50% <0.00%> (-63.00%)
:arrow_down:

pkg/controller/networkpolicy/mutate.go
0.00% <0.00%> (-62.07%)
:arrow_down:

.../agent/apiserver/handlers/networkpolicy/handler.go
0.00% <0.00%> (-58.34%)
:arrow_down:

... and 77 more

@mengdie-song thanks for the review

/skip-all

Our clusters run antrea v0.13.3 (tanzu 1.4) and will be v1.2.3 (tanzu 1.5).  What versions of the octant and the antrea plug-in versions should we use for viewing Tracceflow?  See #2676 and related Traceflow issues.

Hi @wu105,
In your case, you can use the latest antrea-octant-plugin with octant v0.24.0 even though you are not using the latest Antrea. Another option will be using antrea-octant-plugin(v0.13.3 or v1.2.3) with octant v0.16.1.

@mengdie-song Thank you for the information.  Octant v0.16.1 and antrea plugin v0.13.3 worked for our clusters running antrea v0.13.3.  I did not try Octant v0.16.1 with antrea plugin v1.2.3.
I did try Octant v0.24.0 with anrea plugin v1.5.0, v1.4.0, v1.2.3, and v1.3.0, all not working  in similar ways: When octant starts, the plugin is loaded, but soon after clicking on the Antrea link on the UI, Octant showed page not found error with the address field displaying http://<IP_ADDRESS>:7777/#/antrea-octant-plugin, and the Octant logs show the following:
Antrea plugin v1.5.0
2022-02-24T22:23:09.662-0500	INFO	plugin/manager.go:664	restarting plugin	{"plugin-name":
"antrea-octant-plugin-windows-x86_64.exe"}
2022-02-24T22:23:09.662-0500	ERROR	api/content_manager.go:159	generate content	{"client-id":
"397d234c-95ea-11ec-8c51-0205857feb80", "err": "generate content: grpc client content: rpc error: code = Canceled desc
= grpc: the client connection is closing", "content-path": "antrea-octant-plugin"}
github.com/vmware-tanzu/octant/internal/api.(*ContentManager).runUpdate.func1
	/__w/octant/octant/internal/api/content_manager.go:159
github.com/vmware-tanzu/octant/internal/api.(*InterruptiblePoller).Run.func1
	/__w/octant/octant/internal/api/poller.go:86
github.com/vmware-tanzu/octant/internal/api.(*InterruptiblePoller).Run
	/__w/octant/octant/internal/api/poller.go:95
github.com/vmware-tanzu/octant/internal/api.(*ContentManager).Start
	/__w/octant/octant/internal/api/content_manager.go:133
2022-02-24T22:23:09.662-0500	ERROR	api/navigation_manager.go:101	load namespaces	{"component": "websocket-client",
"client-id": "397d234c-95ea-11ec-8c51-0205857feb80", "poller-name": "navigation", "poller-instance":
"822ca9ff-8ac9-486d-a322-50870e6531e3", "err": "unable to generate navigation for module antrea-octant-plugin: grpc
client response: rpc error: code = Canceled desc = grpc: the client connection is closing"}
github.com/vmware-tanzu/octant/internal/api.(*NavigationManager).runUpdate.func1
	/__w/octant/octant/internal/api/navigation_manager.go:101
github.com/vmware-tanzu/octant/internal/api.(*InterruptiblePoller).Run.func1
	/__w/octant/octant/internal/api/poller.go:86
github.com/vmware-tanzu/octant/internal/api.(*InterruptiblePoller).Run
	/__w/octant/octant/internal/api/poller.go:95
github.com/vmware-tanzu/octant/internal/api.(*NavigationManager).Start
	/__w/octant/octant/internal/api/navigation_manager.go:90

antrea plugin 1.4.0, 1.2.3, 1.3.0
2022-02-24T20:47:30.854-0500	ERROR	api/content_manager.go:159	generate content	{"client-id":
"dd416467-95dc-11ec-936f-0205857feb80", "err": "generate content: grpc client content: rpc error: code = Unavailable1.4.0
desc = error reading from server: read tcp <IP_ADDRESS>:58295-><IP_ADDRESS>:10017: wsarecv: An existing connection was
forcibly closed by the remote host.", "content-path": "antrea-octant-plugin"}
github.com/vmware-tanzu/octant/internal/api.(*ContentManager).runUpdate.func1
	/__w/octant/octant/internal/api/content_manager.go:159
github.com/vmware-tanzu/octant/internal/api.(*InterruptiblePoller).Run.func1
	/__w/octant/octant/internal/api/poller.go:86
github.com/vmware-tanzu/octant/internal/api.(*InterruptiblePoller).Run
	/__w/octant/octant/internal/api/poller.go:95
github.com/vmware-tanzu/octant/internal/api.(*ContentManager).Start
	/__w/octant/octant/internal/api/content_manager.go:133


Changing README extension from "rst" to "md"

It's due to visual reason for code in italic text:
In current "rst" format at https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/README.rst when you search for "Risky rule: risky when the function" you can see double backticks.
At https://github.com/kubawerlos/PHP-CS-Fixer/blob/readme-from-rst-to-md/README.md when searching for the very same "Risky rule: risky when the function" the code is formatted properly.

Hi. Thank you for your help, yet I must say that changing file format for readme is not acceptable due to way we autogenerate website from that file.
BTW, if changing format, it would be nice to use specific file syntax instead of only changing ext. I know that GH has special handling of md files that could accept most of rst syntax, yet it's official md syntax is not supporting it.
If you want to fix handling that italic text, please adjust ReadmeCommand

Do you mean http://cs.sensiolabs.org? There is also the issue with double backticks. Would it be difficult to change "rst" to "md" there?
By special handling do you mean making double backticks to code, not only single ones? I've verified that Parsedown is accepting doubles as well and it can be change in separate PR.

yes, that one. as said, changing format is not an option for now.
I mean that we don't write readme on our own, but generate it via ReadmeCommand. So we do generate those ticks. We could change a way we do generate it if we want

website releases are not connected to major version releasing of app

then anytime - this pull request will be here ;)

Could it be a bug in the way reStructuredText is parsed? Isn't there a workaround that does not require moving to Markdown?

Not according to Common markup for Markdown and reStructuredText:

Markdown allows monospaced text within bold or italic sections, but not vice versa - reStructuredText allows neither.


[file_freedom] Fix relative paths called in inline executes

try:
execute @a ~~~ function ./path/to/function

Inline path is not resolved.
Not an issue when used with functioner's {}

Fixed in https://github.com/Hatchibombotar/useful-regolith-filters/commit/c48370a83af3dcc6d2a78e718d173b908b2692c0


Plot doesn't always update when sweep added

The schedule plot doesn't always update when a sweep is added. Usually when a sweep is repeated on a 2nd channel.

This appears to be an issue with Tabulator that is being tracked here: https://github.com/olifolkerd/tabulator/issues/2888
In short, a callback isn't fired as expected when a row is programmatically updated.

Looks like resolving this via Tabulator might be complicated. The author of Tabulator might be reworking how dataEdited works. Closed in ba39a42 by manually triggering update

Reopening because Tabulator has an update that may allow us to handle this more intelligently. See olifolkerd/tabulator#2888 and https://github.com/olifolkerd/tabulator/releases/tag/4.8.0


Metrics for experimentation

[x] Define the metrics needed to analyse the experimentation:

[x] For the metrics available on grafana : make the graphs

[ ] For the other metrics make a form

Hey team! Please add your planning poker estimate with Zenhub @JDixmier @ad2ien

Trying things out on develop env

Here's a first version of a dashboard that could help us follow the progress of the experiment grafana-eimis-experimentation.json


where is it include path?

I did not find the include directory, including project files and generated binaries

Hi @Sallee1,
Please use the instructions given in the README how to build and install the library. Once all steps are done, you can include the headers, that are normally located in /usr/local/include/odbc, as follows:
#include <odbc/Connection.h>
#include <odbc/Environment.h>

int main()
{
        odbc::EnvironmentRef env = odbc::Environment::create();

        odbc::ConnectionRef conn = env->createConnection();
        conn->connect("DSN", "user", "pass");
        conn->setAutoCommit(false);
}

What should I do on Windows11 x64?

There are two options for Windows:
Option 1: use Visual Studio 2015 or later
Option 2:  use MSBuild (nmake)
Option 2 will install the library and header files. CMake will install them to C:\Program Files\odbccpp by default. If you prefer a different location, you can set CMake's install prefix to a different path. See https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX.html for details.
Please read the README carefully.


Update metrics.py

tf.keras.metrics.R2Score(): ValueError: Tensor conversion requested dtype int32 for Tensor with dtype float32: <tf.Tensor: shape=(), dtype=float32, numpy=0.0>
the issue is solved

i will solve this isuue

Please don't use "add file"/"update file"/"fix file"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.
The commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.
For how to write good quality git commit messages, please consult https://cbea.ms/git-commit/


Automated cherry pick of #4241: Fix(region): Fix the Json tag of apis.GuesttemplateNetwork.GuestIpEnd

Cherry pick of #4241 on release/2.13.
#4241: Fix(region): Fix the Json tag of apis.GuesttemplateNetwork.GuestIpEnd

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@eb584c4). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.13   #4242   +/-   ##
==============================================
  Coverage                ?   6.87%
==============================================
  Files                   ?     519
  Lines                   ?   88088
  Branches                ?       0
==============================================
  Hits                    ?    6053
  Misses                  ?   81536
  Partials                ?     499

Flag
Coverage Δ

#aFlag
6.87% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb584c4...9cecc6a. Read the comment docs.


give demo same data as dev

closes #659
I already went ahead and deployed these changes, just need a rubber-stamp on the code :)
I moved the "tips" up to the top of the dropdown as it makes it easier to work with real data :)

looks good 💃
thanks!


[Component:DV] Running regression riscv_bitmanip_full_test

My Environment
When running make ITERATIONS=1 SIMULATOR=questa VERBOSE=1 the following test gets ran and errors out riscv_bitmanip_full_test, presumably since ibex implements RV32IMC and not RV32IMCB. Is this expected DV behavior?
EDA tool and version:
QuestaSim 2020.3
Operating system:
CentOS 7
Version of the Ibex source code:
N/A

Bug in the Makefile perhaps?
# ISA
ISA                 := rv32imcb

This is a bit finicky. Ibex supports the bitmanip extension in some configurations, but we have to make sure the ISS runs in the same mode. My guess is that the two aren't in sync for you here. Can you share your log file?

Which log file in particular?

The regr.log file you should find in the out/seed-XXXX directory should give the relevant error or failing that the log of the console output seen when running the test.
There are also per test logs in the instr_gen/ and rtl_sim/ directories. Generally it's the simulation log in rtl_sim/[test]/sim.log which contains things of interest.

Hi there! It's been quite a while with no response, so I'm going to close this issue now. If you come back to this and you're still having a problem, feel free to re-open (with the log file that Greg mentioned above).


New resources page build

Build skeleton resources page

Check on the transition at this point it isnt as smooth


boards: add initial support for stm32g071b-disco board

Summary

stm32g0: add support for USART3 and USART4
boards: add initial support for stm32g071b-disco board

Impact
None
Testing
nsh

@raiden00pl please add board Documentation to be available at https://nuttx.apache.org/docs/latest/platforms/index.html


Update MD file on new branch 2017-33-17_07-12-57

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add new augmentLogEntry property

Fixes #147
What
This adds a new optional property called augmentLogEntry which allows consumers to add additional properties to the "GraphQL operation" log entry emitted by the logging plugin.
Why
We have a project where we compute a cost associated with each GraphQL operation and want this to be logged.
At the moment, we emit a separate log entry that contains only this information.
It would make sense to log this with the "GraphQL operation" log entry.
Tests
I'm not sure how we could set up automated tests for this, so I installed the built version locally in our project and made the following changes:
graphqlOperationLoggingPlugin<GraphQLContext>({
  contextCreationFailureLogger: logger,
  ignoreIntrospectionQueries: true,
  logLevel: 'info',
  adjustVariables: (variables) => redactSensitiveVariables(variables),
  shouldIgnore: (ctx) => {
    return ctx.source === frontDoorHealthProbeQuery
  },
+  augmentLogEntry: (ctx) => {
+   const { operationCost } = ctx
+   return {
+     operationCost,
+   }
+ },
}),

I ran our app locally, made a query, and this is what the Apire dashboard shows:

The one concern is that logGraphQLOperation spreads rest at the end, which gives consumers the ability to override "fixed" properties. Probably not an issue right now.
https://github.com/MakerXStudio/graphql-core/blob/532c8d9559fd359aab524287bcc980247858c94a/src/logging.ts#L79-L109

I'm not sure if you're up agains the same general vulnerabilities as I was.
I decided to try updating ts-toolkit config and all packages, which worked and was overall probably easier than addressing piecemeal, e.g.:

run ncu to update everything
run npx @makerx/ts-toolkit init --existing-file-behaviour overwrite
reinstall one package to re-order package.json
delete the old eslint config files
ditch any unwanted overwrite changes to the ts-toolkit config file

I'm not sure if you're up agains the same general vulnerabilities as I was.
I decided to try updating ts-toolkit config and all packages, which worked and was overall probably easier than addressing piecemeal, e.g.:

run ncu to update everything
run npx @makerx/ts-toolkit init --existing-file-behaviour overwrite
reinstall one package to re-order package.json
delete the old eslint config files
ditch any unwanted overwrite changes to the ts-toolkit config file

Let me try that.

@cuzzlor I think I got there, but it tool me too many attempts for me to have confidence to merge this as-is.
Would you be able to have another look?
I ran npm run build on both main and this branch, and the output looked similar.

Thanks @mderriey - I had a look at the build output locally and it's looking good. I'm gonna merge for you.


Suggest Edit: epilande/browser-tabs

Gallery URL
https://alfred.app/workflows/epilande/browser-tabs/
Website
No response
Report Bug
No response
Forum
No response
About
Love the Workflow, but wish I could use it to close tabs. (Or better yet: close all duplicate tabs)
Sometimes when shopping online, I end up with multiple duplicate tabs. These can be difficult to distinguish in the browser window. However, when I search for tabs using this workflow, the duplicates are usually lined up. So it would be great if they were always lined up, and if we could just close all duplicates in one command.
Just a thought. Cheers!
Notes
No response

If you want to request a new feature for a workflow, click the Website link and contact the workflow’s creator. The link you clicked is to suggest edits to the Gallery page.

Oops! Apologies! Thank you for the redirect :)


Warlock (Revised II)

Error: Service Unavailable
{
  "status": 503,
  "method": "PUT",
  "url": "/api/update/rGOo7pnGPZaH"
}

Server rebooted.  not sure what issue is, but closing this for now.


Cashing wrong image

Hi, I have problem with loading image. Here is my code that sometimes shows wrong image
let url = NSURL(string: friend.profileImage as String)             let block: SDWebImageCompletionBlock! = {(image: UIImage!, error: NSError!, cacheType: SDImageCacheType, imageURL: NSURL!) -> Void in }             self.friendImage.sd_setImageWithURL(url, completed: block)
When I try to load image without SDWebImage it show valid image. Code example:
let url = NSURL(string: friend.profileImage)             dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0)) {                 let data = NSData(contentsOfURL: url!) //make sure your image in this url does exist, otherwise unwrap in a if let check                 dispatch_async(dispatch_get_main_queue(), {                     self.friendImage.image = UIImage(data: data!)                 });             }
Reusable cell is not a problem. All cells can fit on the screen

Please make the issue conform to the issue template: https://github.com/rs/SDWebImage/blob/master/.github/ISSUE_TEMPLATE.md


[BUG] Attempting to configure the keyboard in RISC OS 3 locks up the emulator

Describe the bug
Attempting to configure the keyboard using the RISC OS 3 !Configure App locks up the emulator
To Reproduce
Steps to reproduce the behaviour:

Start Emulator
Double click on Apps
Double click on !Configure
Click on the !Configure App in the Icon Bar
Click on the Keyboard icon
Emulator locks up

Expected behaviour
When the keyboard icon is clicked upon the keyboard configuration window should appear.
Please complete the following information

Current HEAD

Additional context
None

Experiments on 05.06.24 showed that by configuring keyboard related settings in the CMOS alleviates this issue.

Resolved by #26