ResNet18 Wrong Results in FP16 Mode on GPU RTX 4000

What happened?
Pytorch fp16 resnet18 model returns wrong results on RTX 4000
Steps to reproduce your issue

Create a file with following content

import torch

import os
import io
import numpy as np
import time

import torch_mlir
import iree.compiler as ireec
import iree.runtime as ireert

model = torch.hub.load('pytorch/vision:v0.10.0', 'resnet18', pretrained=True)
model.eval()

# Download an example image from the pytorch website
import urllib
url, filename = ("https://github.com/pytorch/hub/raw/master/images/dog.jpg", "dog.jpg")
try: urllib.URLopener().retrieve(url, filename)
except: urllib.request.urlretrieve(url, filename)

# sample execution (requires torchvision)
from PIL import Image
from torchvision import transforms
input_image = Image.open(filename)
preprocess = transforms.Compose([
    transforms.Resize(256),
    transforms.CenterCrop(224),
    transforms.ToTensor(),
    transforms.Normalize(mean=[0.485, 0.456, 0.406], std=[0.229, 0.224, 0.225]),
])
input_tensor = preprocess(input_image)
input_batch = input_tensor.unsqueeze(0) # create a mini-batch as expected by the model

# move the input and model to GPU for speed
device = "cuda"
input_batch = input_batch.to(device)
model.to(device)

model.half()
input_batch = input_batch.half()

# warmup
with torch.no_grad():
    output = model(input_batch)

    start = time.time()
    output = model(input_batch)
    print("torch result", output[0, 0])
    print("torch time", time.time() - start)

# IREE
mlir = torch_mlir.compile(
    model,
    input_batch,
    output_type="linalg-on-tensors",
    use_tracing=True)

iree_input_type = "tm_tensor"
bytecode_stream = io.BytesIO()
mlir.operation.write_bytecode(bytecode_stream)
flatbuffer = ireec.compile_str(bytecode_stream.getvalue(),
                              target_backends=[device],
                              input_type=iree_input_type,
                              extra_args=[
                                "--iree-hal-cuda-llvm-target-arch=sm_75",
                                "--iree-flow-dump-dispatch-graph",
                                "--iree-flow-dump-dispatch-graph-output-file=foo.dot"])

iree_device = ireert.get_device(device)
config = ireert.Config(device=iree_device)
ctx = ireert.SystemContext(config=config)
vm_module = ireert.VmModule.from_flatbuffer(ctx.instance, flatbuffer)
ctx.add_vm_module(vm_module)
invoker = ctx.modules.module

# warmup
iree_input_batch = ireert.asdevicearray(iree_device, input_batch.cpu().numpy())
result = invoker.forward(iree_input_batch)

start = time.time()
result = invoker.forward(iree_input_batch)
numpy_result = np.asarray(result)
print("iree result", numpy_result[0][0])
print("iree time", time.time() - start)

Execute it and check the log

torch result tensor(0.0119, device='cuda:0', dtype=torch.float16)
torch time 0.029006481170654297
iree result 0.0005054
iree time 0.016841650009155273

What component(s) does this issue relate to?
No response
Version information
6a46afd4f82715979b54c57fb41a8505466cd68f
Additional context
No response

@qcolombet Can you help give this a quick triage?

@rsuderman is this something someone in your team can investigate?

Adding @jpienaar @aaron-schneider to help triage!

@rsuderman @jpienaar @aaron-schneider Any update here?

No work has been scheduled here. FP16 triage here would require GPU to even produce the IR.

Should we close as 'not planned'?

No, we first need to identify a team to do first order triage here. This is a GPU issue, whether GPU specific or not or codegen specific or not is TBD. But you need at least someone with a GPU to even produce the IR here given how torch-mlir works. We are currently generating what seems like the wrong results (with ML frameworks it is difficult as numerics very flexible ... ). There is the other issue where @silvasean was going to look at verifying numerics which may overlap here, but he has some other tasks in flight (but feel free to correct me @silvasean if you have some time to look at this as prelude for the other numeric verification issue assigned). Else this seems like it should be dispatched GPU side - so @mattwalsh or @julianwa to schedule.

Adding @qcolombet if we need codegen team to look at this.

It's too early to know if my team needs to be involved.
Let me try to get the IR like @jpienaar said to see if it helps narrow down what needs to happen here.

I was using Ubuntu 20.04 + python 3.8 + cuda 11.8

@ShuaiShao93 if you have the generate .mlir file @qcolombet could get away without anything to do with torch / torch-mlir.  But if that is not possible to generate we can help get a recreate.

@mariecwhite pointed me to the right script to install pytorch with CUDA support: https://github.com/iree-org/iree-samples/blob/main/iree-torch/library/setup_venv.sh
and the steps are:
export WITH_CUDA=1
./setup_venv.sh
unset WITH_CUDA
source torch-models.venv/bin/activate

I can reproduce the problem now:
torch result tensor(0.0126, device='cuda:0', dtype=torch.float16)
torch time 0.03869962692260742
iree result 0.0005054
iree time 0.004549264907836914

tm_tensor_input.mlir.tgz
Here is the IR.
To compile:
iree-compile --iree-hal-cuda-llvm-target-arch=sm_75 --iree-input-type=tm_tensor -iree-hal-target-backends=cuda -o <out>.vmfb tm_tensor_input.mlir

@jpienaar how do we go from there?
Ideally it would be good to bisect which dispatch is problematic by sending half of them to the reference implementation and the other half to the GPU and iterate, but I don't know if that's possible.

You can use the SPIR-V / LLVM CPU backend as a reference, if the result there is correct. Try to compile the model with --iree-flow-trace-dispatch-tensors on.  Then run the model through SPIR-V / LLVM CPU and CUDA to compare all intermediate tensors and find the first meaningful different dispatch.

@antiagainst thanks for the pointer.

Hi @qedawkins,
@MaheshRavishankar mentioned offline that you may have some tooling already available to do the bisect here.
Could you share these?
Thanks!

Hi @qedawkins,
@MaheshRavishankar mentioned offline that you may have some tooling already available to do the bisect here. Could you share these?
Thanks!

Yes, I added a few flags for targeted tracing/bisecting because --iree-flow-trace-dispatch-tensors produces far too much output and takes too long to be practical for full models in my experience. There are two options:

--iree-flow-trace-dispatch=<string> to trace the inputs/outputs of only a specified dispatch
--iree-flow-break-dispatch=<string> to "crop" the model at the first occurrence of the specified dispatch (per function in the input module).

You can either specify @<function_name>:<index> to trace on the <index>th dispatch in the model, or you can just specify a dispatch name, e.g. forward_dispatch_0_matmul_2560x2560x2560. Note that the dispatch name is treated as a regular expression so if you specify forward_dispatch_1 this will match dispatch_1, dispatch_10, dispatch_11 and so on (after deduplication).
Typically my flow will look something like:

Compile with --iree-flow-dump-dispatch-graph-output-file=<string> to get a dump of the graph to inform how I bisect the dispatches
Start from some "middle-ish" dispatch and do --iree-flow-break-dispatch=@forward:<index> and see the results of the model between two backends (in this case SPIR-V might be a good choice).*
Bisect the dispatches based on the flow in the graph. Reminder that the graph is non-linear so cropping/tracing will only check the branch of the model whose results are directly required for the target dispatch.

*Tracing also works, but to me only makes sense over breaking if you want to check more than one dispatch at a time (e.g. all matmuls in the model). Otherwise with breaking you get to save on compile times and you get the output values as a typical model result which I find easier to work with in python (for value comparison) than the results printed by tracing. All depends on your preferred workflow though.

This script could likely be repurposed to verify values for the above flow: https://github.com/iree-org/iree-samples/blob/main/transform_dialect/python/compile_and_compare.py
Currently the target device is shared between both compilation commands so that would have to be split into two.
@qcolombet let me know if you have any other questions, hope this helps :D

Thanks @qedawkins for the details.
I haven't had a chance to look at it yet, but wanted to acknowledge that I saw your message.


simgrid 3.15 -> 3.17

Motivation for this change
This package was outdated
Things done
I cleaned the unnecessary piece of code.
I've update to the latest stable version.
I make the checks pass.
Also I've added some optional support for fotran, Java, modelChecking and debugging

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" No packages that depends on this
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Sorry for the last one (I should not do things when I'm tired...)

@grahamcofborg eval


New API Proposal: Add (expose) ECC methods

NEW API Proposal: Add (expose) ECC methods
Motiviation
We should expose some Elliptic Curve Cryptography (ECC) methods, at least:

Point multiplication
Decode point on curve from a compressed public key.

So that developers can develop cryptographic constructs using these fundamental building blocks. e.g. ECIES (here is my implementation)
An (EC) crypto lib which does not expose at least these above-mentioned methods is extremely limiting.
Alternate solution
Alternatively, we can include common cryptographic constructs such as above mentioned ECIES in this library - but it is more limiting and sounds like lots of work - and more maintenance....
Importance
If above mentioned cryptographic primitives - especially EC point multiplication - are not expose then crypto companies and cryptocurrency project might have to turn to other solutions. Which would be sad really, since this repo could improve the whole crypto sphere (on the Swift side of things).

Thanks for this proposal!
I think at this time this proposal is explicitly out of scope. The goal of this library is to provide safe, high-level constructions; we are not trying to expose primitives for composition. I appreciate that this is limiting, but we want to avoid the kitchen-sink style API design of lower-level libraries.
I think there is absolutely value in high-quality libraries exposing primitives for Swift users interested in implementing novel or unusual cryptographic constructions, but that belongs elsewhere.
Thanks for the proposal though, please keep them coming!

Hey @Sajjon,
Thanks for the proposal!
I just want to point out that in order to perform ECIES, everything is already there.
The only operation you need to perform over elliptic curves is a DH key agreement which we expose on the EC private key types.
See this example for P256: https://developer.apple.com/documentation/cryptokit/p256/keyagreement/privatekey/3243096-sharedsecretfromkeyagreement

@FredericJacobs @Lukasa Thanks for pointing that out Frederic! So how do you feel about including an implementation of ECIES - if I were to do a (draft) PR with an initial implementation?

Primitives used in ECIES will vary from protocol to protocol. We are currently not taking any PRs for higher-level constructions that can be built on top of Swift Crypto. If you are interested, we have an ECIES variant in the Swift playground that was released at WWDC.

@FredericJacobs Got it, makes sense.
Thanks for that playground, I have not seen it before. Now that I've looked at it, it contains some typos, multiple instances of:
"ephmeral" -> "ephemeral"
Very nice playground! I must start using playgrounds more, it's kind of similar to Juniper "books" in Python.


FIX: updated content detail ref #48303

Description
This is the changes made to the wrong content detail at https://kubernetes.io/docs/reference/using-api/api-concepts/#json-encoding
which was first incorrectly written as Content-Type: json and is now changed to Content-Type: application/json
Issue
Closes: #48303

/assign @katcosgrove

/assign @sftim

/retitle Fix incorrect content type in API reference page


enable template placeholders in chat_system message setting

Some parts of prompts change slightly depending on scenario. In particular, making corrections based on American vs British English. Another example is editing Markdown vs LaTeX formatted source text.
This feature is to enable the chat_system settings inside a prompt request settings file to contain a template with a placeholder for English dialect and a way to select between American and British in the copyaid.toml user configuration file.

I am thinking of enabling Jinja templates for a key called "system_prompt" which will obsolete "chat_system". "chat_system" which will not support template syntax gets deprecated. "system_prompt" is always interpreted as a Jinja template.

Add a top-level key parameters which exposes parameters that a calling program can specific. Something like
[parameters.lang_tag]
default = "en-US"

[parameters.lang_tag.map]
"en-US" = { dialect = "American" }
"en-GB" = { dialect = "British" }

[parameters.mime_type.map]
default = "text/markdown"

[parameters.mime_type.map]
"text/markdown" = { format = "Markdown and HTML" }
"application/x-latex" = { format = "LaTeX" }

where dialect and format show up as Jinja template variables in system_prompt.


toMarkdown bug

Steps to reproduce

Go to "Visual" tab
Type Starcounter and add two new lines after it
Change the count to italic
Click on the Markdown tab (you will see Star_count_er)
Type "s" at the end, so now you have Star_count_ers
Click on the Preview tab (you will see Star_count_ers)
Click on the Visual tab (you will see Star_count_ers)

Expected result
To have count in italics at 5 and 6.

Closing as fixed.

Reopen as the solution provided does more harm than good.
When the user writes something within the Markdown tab, _[...]_ will be changed to *[...]* with that fix. This is a problem because underline within the markdown tab can't be used because of that change.


Not able to consume messages from topic created by JDBC connector with schema registry.

Description
I configured JDBC source connector to pull data from SQL Server table into Kafka topic. Data from SQL server is pulled successfully into kafka topic and also it automatically associated as schema with the topic.
Now I am trying to consume the messages from topic created by JDBC connector. I used the same schema and created dotnet classes and using the avrogen tool. But I am getting schema mismatch error which consuming messages. Then I compared the reader and writer schema and found that the only difference is "namespace" which is required when generating class using avrogen tool.
I removed the "namespace" attribute manually from the schema in my code and then every thing works fine. Is this something expected or this can be fixed?
How to reproduce
Checklist
Please provide the following information:

[ ] Confluent.Kafka nuget version: 1.0-beta2
[ ] Apache Kafka version: Confluent Kafka 5.0.1
[ ] Client configuration:
[ ] Operating system: REHL 7
[ ] Provide logs (with "debug" : "..." as necessary in configuration)
[ ] Provide broker log excerpts
[ ] Critical issue

thanks for reporting @Manish-Sharma2015 - this is a scenario i haven't tested, it seems likely something we need to look into/fix.


Only show Worldwide Orgs once in the dropdown

Worldwide orgs that have more than one translation were showing up for
every translation they had. This ensures we only get the current locale
for each org rather than every translation they have available.
https://www.pivotaltracker.com/story/show/94961926

:+1:


Make code conform to Pony style guide

It almost assuredly doesn't.
Given this will touch a lot of code, if you can't do this in a fairly quick go, to avoid merge conflicts, it would be best to do in short increments that can be done off of latest master and merged quickly.
Perhaps a module at a time.

What are the main offenses?

Extra blank lines between top-level items
Line length > 80?

We need a Pony linter / formatter.

No idea what they would be, I only glanced, but I'm 99% sure at least some exist.
@Theodus spots em like crazy because he wrote the style guide.

OK to close this one now?

I thought I had!

@cquinn, just as a tip, you can use keywords in GitHub to auto-close issues once a PR is merged.


marshalling to string with pretty print

As far as I can see, there is no way to marshalString to provide formatted output that would be suitable for saving to a file.
Am I missing something?

No, there is no such way at the moment. Jsonix uses XMLSerializer for serialization and it does not support pretty printing.

I recently stumbled across this too and was hoping for an easy config option to output a pretty printed string.

I've got something of a 'solution'.
It's not quite the most pleasant, but it should be quite flexible for any additional changes required (albeit needing those changes to be implemented within an xslt environment)
    var xsltDoc = new DOMParser().parseFromString(
      [
        // describes how we want to modify the XML - indent everything
        "<xsl:stylesheet xmlns:xsl='http://www.w3.org/1999/XSL/Transform'>",
        "  <xsl:output omit-xml-declaration='no' indent='yes'/>",
        "  <xsl:template match='node()|@*'>",
        "    <xsl:copy>",
        "      <xsl:apply-templates select='node()|@*'/>",
        "    </xsl:copy>",
        "  </xsl:template>",
        "</xsl:stylesheet>",
      ].join("\n"),
      "application/xml"
    );

    var xsltProcessor = new XSLTProcessor();
    xsltProcessor.importStylesheet(xsltDoc);
    var pretty_doc = xsltProcessor.transformToDocument(doc);

One problem is that it will strip out CDATA sections.  If you know ahead of time which you want to retain then you can add the following attribute to the xsl:output element
cdata-section-elements='elementType1 elementType2 elementType3 ...'


Fix docker id; do not call sys.exit from setup.

Fix docker ids (Issue #70) and do not exit from setup.
Errors during setup (e.g. annotations are missing because network-manager is down) may become harder to trace if the plugin script returns an error via sys.exit(1). kubelet sync will fail is that is the case.

Looks good. Since there is build issue "pkg/network/opencontrail/controller_dispatch.go:49: undefined: "k8s.io/kubernetes/pkg/kubelet/types".MirrorType", I will wait before mering..


Mention GNU Readline dependency in the Readme.md

I've tried to build uc on the Ubuntu 22.10 system and got error Readline library not found!:
mkdir build && cd build && cmake .. && make
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:15 (message):
  Readline library not found!

This error means that uc project depends on readline library but it wasn't installed on my computer.
There is a sentence in the dependencies chapter:

This utility is a robust, pure C implementation, crafted from scratch without external libraries for seamless, efficient performance.

Thus, documentation should be improved to mention this dependency.

@Lawyar , thank you! Fixed


Fixed and clean fragment_help.xml, fragment_home.xml and  Removed unused html tags on Readme

Fixed and clean fragment_help.xml, fragment_home.xml
Added OpenSource Button on fragment_help.xml
Added some emojis
Removed unused Html tags

Thank you, for your interest in this project.
But this PR doesn't actually make sense.


HA silently ignores custom component which it didn't find

Home Assistant release with the issue:
0.95.4
Last working Home Assistant release (if known):
0.90.1
Operating environment (Hass.io/Docker/Windows/etc.):
Ubuntu 19.04, Docker 18.09.6
Description of problem:
Created a custom component under /config/custom_components/notify/test.py (directory contains nothing except test.py) with the following contents:
"""
Test component.
"""
import logging

_LOGGER = logging.getLogger(__name__)

_LOGGER.info("!!!File included!!!")
_LOGGER.info("!!!File included!!!")
_LOGGER.info("!!!File included!!!")

Added to configuration.yaml:
notify:
  - name: test
    platform: test

Ran:
sudo docker build --name=home-assistant .
sudo docker run -v $(pwd)/config:/config home-assistant

Checked output. No !!!File included!!!, no errors. Custom component is silently not loaded. Also changing naming to /config/custom_components/test/notify.py returns same output.
Tried to debug it. Found IntegrationNotFound exception is just ignored here https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/config.py#L709.
On 0.90.1 custom component was not ignored and I got:
2019-07-09 21:54:52 ERROR (MainThread) [homeassistant.components.notify] Error setting up platform test
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/components/notify/__init__.py", line 78, in async_setup_platform
    raise HomeAssistantError("Invalid notify platform.")
homeassistant.exceptions.HomeAssistantError: Invalid notify platform.

Well, that is because you are doing an incomplete overide of the whole notify platform. But I suppose it aught to warn.

New way would be, test/notify.py

This is intended behavior. Directories without an __init__.py file are not valid Python modules.
https://github.com/home-assistant/home-assistant/blob/51a40c04410f59de34755cf603cfd32001406e33/homeassistant/loader.py#L340-L347

This is intended behavior

@balloob you mean silently ignoring platform config in case something is wrong with directory structure? 10 days ago in https://discordapp.com/channels/330944238910963714/330990195199442944 you said error message should be logged:

But in this case the custom integration is not following the rules how to define a custom integration.

@balloob
v0.91.4 - everything is working
v0.92.0 - integration silently ignored
I'm always carefully reading "Breaking Changes" section of each release, because I assume it's a single source of truth for all breaking changes in HA. I see nothing about breaking change in working with integrations in v0.92.0.

The full release notes are always on the site. It's introduction mentions our work on integrations and links to a post on the developer blog that lists all the changes.

@balloob to conclude:

You think it's logical that breaking change is not listed in "Breaking Changes".
You think it's user-friendly to force user to find this single source of truth and read each blog post carefully. Instead of just preventing program from running with meaningful error message.

Am I right?


Furk doesn't work

I have a Furk account and it's not working.  All my credentials are ok,  but I see no stream at all.  In other addons it is working.  Is there a problem with it?

go in to tools , go to movies and tv shows and look for the Furk Source , you have to turn then on

It's turned on.  That was the first thing that I had checked.  Normally it was working.  Suddenly it didn't.  So I checked Salts and there I see the streams that are available.

give him time to fix everything then

Real-debrid works with it , just give him time

Of course I will give him time to fix it.  So now he is aware of the issue.

yeah


Design: how to make the coupling between ETM and CTM as transparant as possible

Transparancy
It's not only the technical side of the coupling that is important (see  #3898). The ETM sees transparancy as one of its core values. By being transparant, users always know what is happening, can understand and check our modeling and data, and by that can trust the ETM. Being transparant is not easy, things should always be presented in an understandable and accessible way, and not get too complex or like a scary-looking wall of information.
Designing the coupling (from the ETM side) to have this kind of transparancy requires still a lot of thinking and decision making. How do we for instance show how and why certain charts in the ETM have changed, or where they now get (part of) their information from?
Mockups
I'll include the mockups from  #3898 once more, because they could be a nice starting point for a discussion.

Pro's and cons

Pro's
Cons

+ Makes the coupling more user friendly (removing one of the possible cons of  #3898)
- Might take time to come up with a right design for all the 'pieces' in the ETM (such as charts)

+ If done right, adds a lot of extra insights
- For certain designs there could be requested changes to the CTM API

+ Underlines one of the core values of the ETM

+ Shows off what the CTM can add to 'your' ETM scenario

+ After the design phase, individual pieces can be picked up and implemented. This allows for simultaneous development and creating smaller milestones, or an MVP and nice-to-haves

Research
Before we can start implementing a transparant coupling, we first need the technical side done. However, it is wise to already start with thinking about how the coupling should be made clear to the user, as this might impact the technical design.
For creating the design, there's many questions to be answered. Here are a few proposed by @ChaelKruip in his comment on issue  #3898, that are fitting here, but please add more:

What does a user see if they open an ETM scenario that s coupled to a CTM scenario? Should we have a "log" of all the changes made to CTM inputs and the resulting ETM energy flows?
What will be the impact on charts and queries in the ETM if (parts of!) energy flows are set by inputs through the API without corresponding sliders?
What will be the impact on charts and queries in the ETM if (parts of!) energy flows are set by a coupling node? Should that node feature in some of our charts as a series with a legend item?

Time estimate for design and specifications 3 days

Comparing scenarios
I really like the first mock-up. I imagine it will be useful to preview how importing a CTM scenario will affect your ETM scenario.
However, I wonder how common it will be for a user to import a CTM scenario into an existing ETM scenario, as opposed to creating a new ETM scenario with their CTM data?
I think the ability to compare any two ETM scenarios could be useful, especially if we integrate with other models in the future. If we went ahead with this I'd like to see it done in a way that isn't specific to the CTM integration. Instead, we'd create this as a generic feature, and re-use it on the "Import from CTM" page.
The ability to show slider positions doesn't depend on any existing ETM code, since we don't actually have to show real sliders; we only need to show something that looks like a slider. However, comparing charts would be really tricky today. They depend on so much of the ETM code – which assumes only a single scenario can be loaded at a time. We'd have to resort to iframes. I think we'd be better off waiting until we have refreshed charts that don't have this limitation. Comparing slider values would still be useful in the meantime.
Slider positions
To show how a slider would move when importing a CTM scenario, we need to be able to calculate a new start value for the slider. Today we calculate start values with the start_value_gql attribute in the input file. For example:
- start_value_gql = present:PRODUCT(V(some_node, some_value), 100)

We'd need to reconsider how this works. The new starting values would have to be based on the future graph instead of the present, which I expect means getting rid of the "present:" prefix. We'd then have to work on the assumption that "present:" is implied in the GQL except when calculating a new start value for a disabled slider.
This also means we need to be able to differentiate between a slider that is disabled because of the CTM integration, and a slider disabled for other reasons (not supported in the dataset or a GQL calculation error).
Doing this would also allow us to show the real value of disabled sliders in the ETM – the value that results from the settings applied by the CTM – which would be a nice boost to transparency.
However, this assumes that demand set on a coupling node still flows through the rest of the graph as normal. Take this example:

Imagine we have inputs which set the demand of various technologies and we add a coupling node which instead sets the total demand of all the technologies, rather than individual ones. If we do this, everything is fine:

With this setup, demand will flow from left-to-right, and we'll be able to calclulate the demand of each individual technology, and show its value next to a slider in the ETM.
On the other hand, if the coupling node demand "skips" the technologies, we will not be able to calculate any demand for the technologies. Presumably their demand would have to be set to zero:

On the other hand, if the coupling node demand "skips" the technologies, we will not be able to calculate any demand for the technologies.

I think this is the way the proposed design works. In https://github.com/quintel/etengine/issues/1222#issuecomment-1026733809 the coupling node skips over a number of nodes. We won't be able to calculate meaningful input values for any nodes or edges which are skipped by the coupling.
This isn't a show-stopper, but it may limit our ability to provide a meaningful comparison of slider values for any of the affected nodes and edges.

Including @mabijkerk.

Thanks for linking me to this discussion. The proposed design for the fertiliser sector is not yet definitive; we can still make changes. My motivation for skipping the technology nodes is because it requires taking the burner losses into account. This would make the input statements for final demands per carrier more complicated.
More complicated input statements aren't a showstopper either, and a quick solution may be to update the losses of the technology to 0% when the coupling node is 'active'.

A motivation for not passing the demand through the technologies is that a single technology coupling node makes it much easier to set the costs for an externally coupled model.


Extend assertions to check for theory symbols

Extend the assertions Contains and SupersetOf (and SubsetOf?) with an option to check for theory symbols:
This would include adding an argument check_theory: bool = False
And something like the following code in the respective holds_for function:
Contains
if self.__check_theory:
            return self.__symbol in model.symbols(shown=True, theory=True)
return model.contains(self.__symbol)

SupersetOf
return set(model.symbols(shown=True, theory=self.__check_theory)).issuperset(self.__symbols)

+1 for this feature... but I think it would be really useful to generalise this feature request beyond being able to check theory atoms.
Sometimes you might want theory atoms but other times you might want to check all atoms and not just shown atoms. We also have some cases where we need to post-process the model and then perform the check on the post-processed facts. So something that could accommodate all these use-cases would be really useful.
Maybe this could be implemented with a wrapper around the model object that allows the user to override what action is performed for the different checks.


[Feature Request] Improvement to UARTCommandConsole.c

Is your feature request related to a problem? Please describe.
UARTCommandConsole.c is a template that demonstrates how to use a UART as the IO interface for FreeRTOS+CLI.  The file has two variables with the same name.  First a file scope static intended to allow tasks other than the CLI task access the serial console.  The second is function scope variable for use in the FreeRTOS+CLI task itself.  The file scope variable is never changed from its initial value of 0, and its definition is hidden by the variable of the same name in FreeRTOS+CLI task.
Describe the solution you'd like

Remove the function scope variable so all tasks, including the FreeRTOS+CLI task, use the file scope variable.
Add a prototype for vOutputString

See the forum post here: https://forums.freertos.org/t/uninitialized-use-of-static-variable-in-rtosdemo-examples-uartcommandconsole-c/12181

Can I work on this?

Can I work on this?

Hey, apologies for late reply. Feel free to work on the above fix; PRs are welcome!

I didn't see any updates for this, so I created a PR.


Upgrade to asm 6, jetty 9 and servlet API 3.1

@lorban If I recall correctly you worked on the peeper demo.  Could you have a quick glance at these changes? Thanks.


Question: Should AlaSQL supports sourcemaps?

I guess the point would be to help with debugging. Are you asking because the sourcemap issue is creating problems?

Yes, there are two problems:
a) alasql.js has a reference to sourcemap by default. Some people do not want to copy sourcemap with the library.
b) Actually, I test and debug most of features in Node.js, where the sourcemaps are useless.

Hmmm... well... if its not helping - and creates issues it might not be important.

So I guess its a "no" ?

No.


hotfix: resolve double type

Description
This PR is on charge of fixing parseLiteral function which does not parse at all double type.
Type of Change
Put an x in all the boxes that apply:

[ ] ✨ New Feature (non-breaking change which adds functionality)
[x] 🛠 Bug Fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking Change (fix or feature that would cause existing functionality to change)
[x] 🧹 Code Refactor
[ ] ✅ Build Configuration Change
[ ] 📝 Documentation
[ ] 🗑 Chore

Pull Request Checklist
Put an x in all the boxes that apply:

[x] My commit messages are detailed.
[x] My code follows the code style of this project.
[ ] No existing features have been broken without good reason.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests pass.

@fabianromeroclaros @SebasthianSalpozz @JosuePrado @JhaelArce
I am closing this PR because when I removed the commented code from the develop branch, this PR for hotfixing was bringing those previous commits again. I have reopened it as a new PR - 18 to ensure a clean history and proper handling of the changes.

Additionally, I have deleted this branch, as I mentioned before, because this branch contained the commented code, errors and observations from my teammates, as we will no longer be using it.

Additionally, I have deleted this branch, as I mentioned before, because this branch contained the commented code, errors and observations from my teammates, as we will no longer be using it.


Windows 10 Ver 2004 OS Build 19041.329 not working

I am getting:  a not listening and not Supported> FYI I just got this Feature 2004 update today. and the Autoupdate did not Fix Issue. Please help Thank you.

I have the 2004 update and mine shows wrapper state installed, service state running, and listening state as listening but then says not supported in red.

I am getting: a not listening and not Supported> FYI I just got this Feature 2004 update today. and the Autoupdate did not Fix Issue. Please help Thank you.

Found the settings
[10.0.19041.84-SLInit]
bInitialized.x86      =CF920
bServerSku.x86        =CF924
lMaxUserSessions.x86  =CF928
bAppServerAllowed.x86 =CF930
bRemoteConnAllowed.x86=CF938
bMultimonAllowed.x86  =CF93C
ulMaxDebugSessions.x86=CF940
bFUSEnabled.x86       =CF944
bInitialized.x64      =103FF8
bServerSku.x64        =103FFC
lMaxUserSessions.x64  =104000
bAppServerAllowed.x64 =104008
bRemoteConnAllowed.x64=104010
bMultimonAllowed.x64  =104014
ulMaxDebugSessions.x64=104018
bFUSEnabled.x64       =10401C
[10.0.19041.84]
LocalOnlyPatch.x86    =1
LocalOnlyOffset.x86   =B46B9
LocalOnlyCode.x86     =jmpshort
LocalOnlyPatch.x64    =1
LocalOnlyOffset.x64   =87611
LocalOnlyCode.x64     =jmpshort
SingleUserPatch.x86   =1
SingleUserOffset.x86  =3AD27
SingleUserCode.x86    =Zero
SingleUserPatch.x64   =1
SingleUserOffset.x64  =0BF0C
SingleUserCode.x64    =Zero
DefPolicyPatch.x86    =1
DefPolicyOffset.x86   =3D7D9
DefPolicyCode.x86     =CDefPolicy_Query_eax_ecx
DefPolicyPatch.x64    =1
DefPolicyOffset.x64   =17ED5
DefPolicyCode.x64     =CDefPolicy_Query_eax_rcx
SLInitHook.x86        =1
SLInitOffset.x86      =66658
SLInitFunc.x86        =New_CSLQuery_Initialize
SLInitHook.x64        =1
SLInitOffset.x64      =1BDFC
SLInitFunc.x64        =New_CSLQuery_Initialize

rdpwrap.txt

Same file as here.

rdpwrap.txt  Going to be a little dumb here is this this New rdpwrap.ini file to be? meaning do I replace it and rename it to rdpwrap.ini?

Would let me.uoad the ini file so I changed the
Extension
Andres Amador
Director of Sales
Florida's Choice Contracting
cell:<PHONE_NUMBER>
Statement of Confidentiality. This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.
Sent from Samsung Galaxy smartphone.
Get Outlook for Androidhttps://aka.ms/ghei36

From: StarfighterJ<EMAIL_ADDRESS>Sent: Thursday, June 11, 2020 2:09:11 PM
To: stascorp/rdpwrap<EMAIL_ADDRESS>Cc: andresamador<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [stascorp/rdpwrap] Windows 10 Ver 2004 OS Build 19041.329 not working (#1087)
rdpwrap.txt Going to be a little dumb here is this this New rdpwrap.ini file to be? meaning do I replace it and rename it to rdpwrap.ini?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fstascorp%2Frdpwrap%2Fissues%2F1087%23issuecomment-642846941&data=02|01||27ae33abc7ba49d53b7c08d80e328b18|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637274957524326641&sdata=ALdhHstx3UDmnif6xclh4JoEB%2F3pRI3PK6J5LphDLRs%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAG75NGX6VNQGCF7YTL7MRCLRWEMUPANCNFSM4N22F2WQ&data=02|01||27ae33abc7ba49d53b7c08d80e328b18|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637274957524326641&sdata=2WsyAAjHUOLrpPCs0VYuRh%2FylTzkubDXenm%2FSgCbRmk%3D&reserved=0.

Ok that makes Since Usually the .ini File is uploaded in a rdpwrap.zip file so it can be uploaded to the github. but thanks :) for help

It shows up all green and supported on my system just haven't had a chance to try it out
Andres Amador
Director of Sales
Florida's Choice Contracting
cell:<PHONE_NUMBER>
Statement of Confidentiality. This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.
Sent from Samsung Galaxy smartphone.
Get Outlook for Androidhttps://aka.ms/ghei36

From: StarfighterJ<EMAIL_ADDRESS>Sent: Thursday, June 11, 2020 2:24:08 PM
To: stascorp/rdpwrap<EMAIL_ADDRESS>Cc: andresamador<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [stascorp/rdpwrap] Windows 10 Ver 2004 OS Build 19041.329 not working (#1087)
Ok that makes Since Usually the .ini File is uploaded in a rdpwrap.zip file so it can be uploaded to the github. but thanks :) for help
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fstascorp%2Frdpwrap%2Fissues%2F1087%23issuecomment-642853965&data=02|01||740b3aa464c84362042a08d80e34a18a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637274966489136129&sdata=z2JqG6BmeKrcpjCnAmKO2Aof9i06Df5DcZWT4BdpMXk%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAG75NGRKOAQK2VDRZZ3XXTDRWEOMRANCNFSM4N22F2WQ&data=02|01||740b3aa464c84362042a08d80e34a18a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637274966489146114&sdata=ysVKRHTfJAqhCJmr53qfASrKMTVkVi%2BZKWqtgtqrPF0%3D&reserved=0.

Anyone know how to get a hold of asmtron to fix the Autouppdater.?
Automatic RDP Wrapper installer and updater // asmtron (07-06-2020)

Probably post an issue or pull request on his GitHub repo.
On Fri, 12 Jun 2020 04:30 StarfighterJ<EMAIL_ADDRESS>wrote:

Anyone know how to get a hold of asmtron to fix the Autouppdater.?
Automatic RDP Wrapper installer and updater // asmtron (07-06-2020)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stascorp/rdpwrap/issues/1087#issuecomment-642857002,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMCGIRPINJDVQUMOGODPPTRWEPFBANCNFSM4N22F2WQ
.

Probably post an issue or pull request on his GitHub repo.
…

He does not have Issues opened on his GitHub Repo

I noticed that. But he is active - he committed an update to his repo today. Have you checked to see whether it has fixed the problem for you?
https://github.com/asmtron/rdpwrap/commit/7797206c7c1c7351dc3e2054b94d065288b30a1c

Yes I did and it works TY :)

can please someone upload the Win10 32Bit termsrv.dll 10.0.19041.84 (x86)
stascorp/rdpwrap is the main repo and the right place to open issues. Open issues also on forked repos makes too much confusion.

I am getting: a not listening and not Supported> FYI I just got this Feature 2004 update today. and the Autoupdate did not Fix Issue. Please help Thank you.

Found the settings
[10.0.19041.84-SLInit]
bInitialized.x86 =CF920
bServerSku.x86 =CF924
lMaxUserSessions.x86 =CF928
bAppServerAllowed.x86 =CF930
bRemoteConnAllowed.x86=CF938
bMultimonAllowed.x86 =CF93C
ulMaxDebugSessions.x86=CF940
bFUSEnabled.x86 =CF944
bInitialized.x64 =103FF8
bServerSku.x64 =103FFC
lMaxUserSessions.x64 =104000
bAppServerAllowed.x64 =104008
bRemoteConnAllowed.x64=104010
bMultimonAllowed.x64 =104014
ulMaxDebugSessions.x64=104018
bFUSEnabled.x64 =10401C
[10.0.19041.84]
LocalOnlyPatch.x86 =1
LocalOnlyOffset.x86 =B46B9
LocalOnlyCode.x86 =jmpshort
LocalOnlyPatch.x64 =1
LocalOnlyOffset.x64 =87611
LocalOnlyCode.x64 =jmpshort
SingleUserPatch.x86 =1
SingleUserOffset.x86 =3AD27
SingleUserCode.x86 =Zero
SingleUserPatch.x64 =1
SingleUserOffset.x64 =0BF0C
SingleUserCode.x64 =Zero
DefPolicyPatch.x86 =1
DefPolicyOffset.x86 =3D7D9
DefPolicyCode.x86 =CDefPolicy_Query_eax_ecx
DefPolicyPatch.x64 =1
DefPolicyOffset.x64 =17ED5
DefPolicyCode.x64 =CDefPolicy_Query_eax_rcx
SLInitHook.x86 =1
SLInitOffset.x86 =66658
SLInitFunc.x86 =New_CSLQuery_Initialize
SLInitHook.x64 =1
SLInitOffset.x64 =1BDFC
SLInitFunc.x64 =New_CSLQuery_Initialize

Doesn't work.

I have upgraded to Windows 10 version 2004. RDPWrapper no longer works.
termsrv.dll is version 10.0.19041.84
I can confirm the above rdpwrap.ini codes does NOT work !
Does anyone have any idea?

I have upgraded to Windows 10 version 2004. RDPWrapper WORK.
Windows 10 is version 10.0.19041.329
thanks to andresamador

I have upgraded to Windows 10 version 2004. RDPWrapper WORK.
Windows 10 is version 10.0.19041.329
thanks to andresamador

Hi, can you tell us exactly how you get this to work?
I have use the rdpwrap.txt that andreasamador attached and it doesnt work. I'm running 64 bit  Windows 10 ver 2004
Thanks

https://raw.githubusercontent.com/affinityv/INI-RDPWRAP/master/rdpwrap.ini

https://raw.githubusercontent.com/affinityv/INI-RDPWRAP/master/rdpwrap.ini

Yes this is working (AWESOME) for Windows 10 version 2004 HOME version. Thanks
I'm still unable to get this to work on Windows 10 version 2004 PRO version 64bit
Any feedback from you guys ?

That is suprising.
Can you confirm that both your windows home and you windows pro computers are using the same version of termsrv.dll? You can find the versions by running the rdpconf program, or by finding termsrv.dll in Windows/System32 and getting its properties from the right-click menu.

Look to Windows Defender and/or AV/security "protections" interfering....

That is suprising.
Can you confirm that both your windows home and you windows pro computers are using the same version of termsrv.dll? You can find the versions by running the rdpconf program, or by finding termsrv.dll in Windows/System32 and getting its properties from the right-click menu.

Both are version 10.0.19041.84

Look to Windows Defender and/or AV/security "protections" interfering....

I have turn off antivirus and firewall still cannot connect to the Pro machine
However on the Home machine even with anti virus turn on I can rdp to it. The error message are as below 👎

Turning off AV will help BEFORE it interferes with settings and files.... it may have already taken out RDP due to it's negligence.

https://raw.githubusercontent.com/affinityv/INI-RDPWRAP/master/rdpwrap.ini
FYI -
This sorted the [not supported] issue for me on Windows 10 2004 v10.0.19041.329
I'm back up and running - Thanks for the assist dude!  You the man.

Windows 10 Ver 2004 OS Build 19041.329 not working as well.
64 bits

@zecaloteiro
I reran the v1.6.2 installer following the 2004 update to Windows 10 in addition to swapping in the new INI, if that helps you out any.

@zecaloteiro What version does RDPConf.exe show?

nothing working for Enterprise Edition.
ver. <IP_ADDRESS>
ver. 10.0.19041.84

Your rdpwrap.txt file is the same as my rdpwrap.ini, except your file is missing the "required" blank line at the end (which I think is perhaps not really required as lost of people have said it is (the original ini file of the project doesn't have a blank line at the end).  What is definitely importantly is the DOS line endings for the file.

I didn't do any individual modifications to the file. I too got that file from here only. And I had to upload as text file only since you can't upload INI file here. So I had to change the extension.
Hope it works end of the day...

@VISHALVODRO works for me, thanks!

Not fully working on my computers with enterprise version. I can only connect first time successfully, after that RDP seems broken.
I got following error on client:
Your Remote Desktop Services session has ended, possibly for one of the following reasons:

The administrator has ended the session.
An error occurred while the connection was being established.
A network problem occurred.

For help solving the problem, see "Remote Desktop" in Help and Support.

Corresponding eventlog on server:
The device Microsoft Remote Display Adapter (location (unknown)) is offline due to a user-mode
driver crash. Windows will attempt to restart the device 5 more times. Please contact the device
manufacturer for more information about this problem.

Not fully working on my computers with enterprise version. I can only connect first time successfully, after that RDP seems broken.
I got following error on client:
Your Remote Desktop Services session has ended, possibly for one of the following reasons:

The administrator has ended the session.
An error occurred while the connection was being established.
A network problem occurred.

For help solving the problem, see "Remote Desktop" in Help and Support.

Corresponding eventlog on server:
The device Microsoft Remote Display Adapter (location (unknown)) is offline due to a user-mode
driver crash. Windows will attempt to restart the device 5 more times. Please contact the device
manufacturer for more information about this problem.

I have the same error messages as yours
Please remove RDPWRAP and enable normal RDP connection and see if it gives you the same error
I suspect Win 2004 updates have corrupted RDP services so it doesn't work anymore

I have the same error messages as yours
Please remove RDPWRAP and enable normal RDP connection and see if it gives you the same error
I suspect Win 2004 updates have corrupted RDP services so it doesn't work anymore

Same problem without rdpwrap. Seems there is something wrong with RemoteFX display hardware acceleration (HOME version does NOT support this), upgrading driver of display adapters may help.

So it would appear the problem is not RDPWrapper but the Windows update 2004 itself
I'm using VirtualBox and am already running the latest VB graphic driver and still not working
Does anyone manage to get RDPWrapper to  to work with Windows 10 update 2004 PRO version ?

I have the same error messages as yours
Please remove RDPWRAP and enable normal RDP connection and see if it gives you the same error
I suspect Win 2004 updates have corrupted RDP services so it doesn't work anymore

Same problem without rdpwrap. Seems there is something wrong with RemoteFX display hardware acceleration (HOME version does NOT support this), upgrading driver of display adapters may help.

@sk-lau
Definitely working fine here post 2004 update.
The 2020-06-18 INI file provided by affinityv above coupled with a re-install of the wrapper put the box back to green.

@sk-lau
For me the problem solved with following step:

Open the Edit Group Policy tool from Control Panel or use the Windows Search dialog (Windows Key + R, then type in gpedit.msc)
Browse to: Local Computer Policy\Computer Configuration\Administrative Templates\Windows Components\Remote Desktop Services\Remote Desktop Session Host\Remote Session Environment
Then change “Use hardware graphics adapters for all Remote Desktop Services sessions” to "Not Configured"
Reboot the computer

@sk-lau
3. Then change “Use hardware graphics adapters for all Remote Desktop Services sessions” to "Not Configured"

I already had that option as "not configured"
:(

@sk-lau
3. Then change “Use hardware graphics adapters for all Remote Desktop Services sessions” to "Not Configured"

I already had that option as "not configured"
:(

Set it to DISABLED then it works for me !!! Thanks to @llccd  :)
Is it all Windows 10 Pro machine will have this problem ?

@sk-lau
3. Then change “Use hardware graphics adapters for all Remote Desktop Services sessions” to "Not Configured"

I already had that option as "not configured"
:(

Set it to DISABLED then it works for me !!! Thanks to @llccd :)
Is it all Windows 10 Pro machine will have this problem ?
@sk-lau
That being the case your issue is/was very likely due to the specific graphics hardware / related drivers on your device, not whatever version or edition of Windows is installed.

@sk-lau
3. Then change “Use hardware graphics adapters for all Remote Desktop Services sessions” to "Not Configured"

I already had that option as "not configured"
:(

Set it to DISABLED then it works for me !!! Thanks to @llccd :)
Is it all Windows 10 Pro machine will have this problem ?

Seems as all machines where Windows decides to use hardware graphics adapters have this issue. It appeared on my machine after upgrading to 2004. I have a GeForce GTX 1070. Explicitly disabling the option worked for me. Microsoft forums couldn't help but I found this issue here. Thank you so much!

Window 10 pro machine, new OS so has all the recent updates.   I adding the ini file (read somewhere was a space at the end or beginning that may have been missing), took the one from above and just copied and pasted the to text document then renamed it and moved over.  Deleted other file.  I just did this update rdpwrap_for_10.0.19041.84_fix_files and still nothing.  It is all green except nothing for supported.  When I run remote desktop it says it is too many users.  Please help, need it asap.

You have to use 2 different user accounts for those who haven't figured it out.
I have Win 10 Pro 2004 current updates and with the  {affinityv commented on Jun 20} .ini file installed and all is good.
Thanks affinityv for helping us all out.

You have to use 2 different user accounts for those who haven't figured it out.
I have Win 10 Pro 2004 current updates and with the  {affinityv commented on Jun 20} .ini file installed and all is good.
Thanks affinityv for helping us all out.

Please someone take over this project, us non-profits can't afford Windows Server, setup & Calc's.

Please someone take over this project, us non-profits can't afford Windows Server, setup & Calc's.

Ok so I have it working to allow remote connection using RDPWrapper but not sure what ini file I am using.  But my problem is a little different.  I can make the connection but it logs off the local user.
SYSINFO:
Windows 10 Pro
Version 10.0.19041
I have done all the following:
Allow RDWrap in Firewall/Antivirus.
REPLACE rdpwrap.ini with the following [got this data from above here only]
rdpwrap.txt (Must rename the file extension as .ini before replacing)

Run RDPConf.exe
Uncheck : single session per user

    OK.

Run GPEDIT.MSC
Go To :
Computer Configuration
Administrative Templates
Windows Components
Remote Desktop Services
Remote Desktop Session Host
Connections
Limit number of connections

    Enabled
    RD Maximum Connections allowed : 999999
    OK

Reboot Computer

@GCTSOL, you are better off logging in as one user and pivotting to the other, perhaps even shadowing the session.  You can't rely upon /not/ taking over an existing session when you login with a username that is already logged in.

I have created a second user that needs to be able to login while not affecting the other user. User 1 logged in locally needs to continue running system as point of sale while user 2 logs in remotely doing financial and banking without user 1 being able to see what user 2 is doing?
Get Outlook for Androidhttps://aka.ms/ghei36

From: affinityv<EMAIL_ADDRESS>Sent: Thursday, September 10, 2020 3:22:41 PM
To: stascorp/rdpwrap<EMAIL_ADDRESS>Cc: support<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [stascorp/rdpwrap] Windows 10 Ver 2004 OS Build 19041.329 not working (#1087)
@GCTSOLhttps://github.com/GCTSOL, you are better off logging in as one user and pivotting to the other, perhaps even shadowing the session. You can't rely upon /not/ taking over an existing session when you login with a username that is already logged in.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/stascorp/rdpwrap/issues/1087#issuecomment-690705383, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ6NYXVF6LDSWYNJ6FLJ743SFEYRDANCNFSM4N22F2WQ.

https://raw.githubusercontent.com/affinityv/INI-RDPWRAP/master/rdpwrap.ini

Yes this is working (AWESOME) for Windows 10 version 2004 HOME version. Thanks
I'm still unable to get this to work on Windows 10 version 2004 PRO version 64bit
Any feedback from you guys ?

Works on the 18363.1016 w10pro
👍👍👍

Still having issues with getting this to work.  When the remote user (user2) logs on, it logs off the local user (user1) and the local user can see everything that the remote user.  Using the Ini File from above post:
https://raw.githubusercontent.com/affinityv/INI-RDPWRAP/master/rdpwrap.ini
Windows 10 Pro - Version 10.0.19041 Build 19041
Again, I am able to establish the remote connection with the  username (user2) but it logs off local (user1) making it unable for both to use concurrently.  I have uninstalled, reinstalled, copied ini after reinstall, set gpedit to max users.  I cannot get this to work no matter what i do on this version windows without logging off the local user and the session being seen on the local system.  Here are the settings I have set on RDPConf.

Someone else reported something similar, but the so-called local user was
not local at all-they were connecting using TeamViewer, and TeamViewer was
switching from the local user session to the rdp session.
Don't try to test rdp using TeamViewer. It doesn't work.
On Wed, 16 Sep 2020 02:01 GCTSOL<EMAIL_ADDRESS>wrote:

Still having issues with getting this to work. When the remote user
(user2) logs on, it logs off the local user (user1) and the local user can
see everything that the remote user. Using the Ini File from above post:
https://raw.githubusercontent.com/affinityv/INI-RDPWRAP/master/rdpwrap.ini
Windows 10 Pro - Version 10.0.19041 Build 19041
Again, I am able to establish the remote connection with the username
(user2) but it logs off local (user1) making it unable for both to use
concurrently. I have uninstalled, reinstalled, copied ini after reinstall,
set gpedit to max users. I cannot get this to work no matter what i do on
this version windows without logging off the local user and the session
being seen on the local system. Here are the settings I have set on RDPConf.
[image: ch_RDPConf]
https://user-images.githubusercontent.com/71097438/93235051-ad8fb500-f742-11ea-9a3b-00632ad18941.PNG
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/stascorp/rdpwrap/issues/1087#issuecomment-692812708,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMCGITKJP2J5R6T5AT5AO3SF6FT3ANCNFSM4N22F2WQ
.

Thank god that worked for me, thanks @asmtron
Win10 Enterprise Ver 2004 10.0.19041.84
https://github.com/asmtron/rdpwrap/blob/master/binary-download.md

@GCTSOL I have exactly the same problem, i have followed every step you have mentioned, but i still can't allow simultaneos user login, have you already found a solution? I have Windows 10 pro (19041.508)

Fresh install of Win10 pro 2004 x64(tr). Wrapper did install, everything was green but it was saying [not supported].
When I try to connect via RDP, it says another user is connected and if i connect, it will disconnect. When I click yes, a warning pops up at the console session(another user, actually my sister watching Netflix.). She says yes, and she gets disconnected. Now i'm connected but she can see and interact with my root user. What I want to achieve is I connect to my own session while she keeps his Netflix running at the actual computer, so I can manage my always-on script stuff at that computer.
When I connect while no one else is using the PC with no users logged in, it straight up works, but again, monitor is showing exactly what I'm doing. you know what i mean
Tried .ini files as well as some gpedit steps mentionead above with tons of reboots but no luck. Seems like Microsoft done some tinkering to prevent pro users from creating multiple sessions im not sure though

Thanks @VISHALVODRO,
your solution works for me
windows 10 Pro ver 2004 (19041.572)

RD Maximum Connections allowed : 999999
OK

Reboot Computer

@GCTSOL, you are better off logging in as one user and pivotting to the other, perhaps even shadowing the session. You can't rely upon /not/ taking over an existing session when you login with a username that is already logged in.

I cannot get shadowing to work. Is there more detailed instructions on setting it up?

@viktor495 Muito obrigado. Obrigado a todos, resolveu meu problema com versão do Windows 10 20H2. Thank You community!

Applicable to https://github.com/stascorp/rdpwrap/issues/1004


Add Queue Monitoring dashboard

Track

the size of each queue (outstanding jobs)
jobs in progress for each queue?
the number of workers assigned to it
average job times?
Error if the queue is full and dropping data (keep the most recent data, push old data out of the queue if the workers aren't working fast enough)
assign workers from the web interface
kill workers (politely) from the web interface

TODO

make a queue of jobs that start/fork worker threads then die to allow the web interface to control worker threads
assign one default worker thread to this queue. If it dies, restart it.

Future Request

begin building model of the time each request takes, so I can find ones that take longer and speed them up. Maybe also make custom workers that load common environment once, ahead of time if the performance requirement is there.

https://github.com/nvie/rq/blob/master/rq/queue.py
This file is going to have the info I need to get info about the Queues that I'm monitoring

https://github.com/nvie/rq/blob/master/rq/worker.py
And this file will help with monitoring the workers

I have a web interface to control queue making and killing. I need to make the killing a queue job.
TODO

make a worker killing queue job
make the worker on the createWorkers queue get restarted if it dies
make a web page that does all the things (/workers/status)
make a dynamic web page that shows info for a specific queue (/workers/status/<queue_id>)

Also, TODO - refactor + clean up code, it's gotten very disorganized and hacky feeling since I started trying to kill these queues

TODO

the status page doesn't properly list workers

Everything but the refactor is done as of d9a0b5e, I'm going to move that to it's own issue.


Feat/upgrade deps and macos build

Hello,
Additions of my proposal:

Upgrade: Maven, dependencies & container build
Quality: Code quality
Feat: Add healthchecks for every services
Fix: Local run on macOS
Perf: Enhance performances with config local caching
CI: Add validation step, clean code, use local Maven install

Regards,

Thanks a lot Clémence for your very interesting contribution. I will do a review
For the next time (I hope there will), I'll prefer smaller PR :)

Clémence MacOS build on ARM architecture has been completed in the https://github.com/spring-petclinic/spring-petclinic-microservices/pull/242
Feel free to submit other improvements in smaller PR please


Adding JSON endpoints for metrics measurements

:tada: This PR is included in version 1.7.0 :tada:
Your semantic-release bot :package::rocket:


String values converted to blank in some XLS format files

In some XLS format files cells with string values convert to blank in the Datatable cell.
In once old test file in BIFF8 format values like 'a', 'b','c' etc converted to blank.
Changing the font in the file to Arial and re-saving bypassed the problem.
In a second test file only string cells with the value TOTAL UNITS converted correctly and all other string cells converted to blanks.  Could not find a way to bypass the problem.  Could not find any characteristic that made this XLS file different than many others.  If I copied and pasted values into a new sheet conversion worked.
Could not figure out how to attach sample files to this issue report.

Where did the original files come from?
On Mon, Apr 20, 2015 at 1:17 PM, snowstorm0951<EMAIL_ADDRESS>wrote:

In some XLS format files cells with string values convert to blank in the
Datatable cell.
In once old test file in BIFF8 format values like 'a', 'b','c' etc
converted to blank.
Changing the font in the file to Arial and re-saving bypassed the problem.
In a second test file only string cells with the value TOTAL UNITS
converted correctly and all other string cells converted to blanks. Could
not find a way to bypass the problem. Could not find any characteristic
that made this XLS file different than many others. If I copied and pasted
values into a new sheet conversion worked.
Could not figure out how to attach sample files to this issue report.
--
Reply to this email directly or view it on GitHub
https://github.com/ExcelDataReader/ExcelDataReader/issues/64.

--
Ian Cox
C.T.O.
System Sync
m:            Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w:            http://www.systemsyncsolutions.com
http://www.releasemobile.com/
Registered in England as systemsync solutions ltd.
Number: 9326325 VAT: 202729923

Thx,
I have the two files.
The Book1.xls file is, I think, from NPOI install as sample to NPIO
The Invoice _TE-132-SA-2.xls file was part of ExcelDataReader CodePlex issue Id #11928 GetValue returns empty string for cells in some xls file
Both files convert correctly if I use LinqToExcel which I switched to when I could not figure out how to get them to work under ExcelDataReader.
The Book1.xls file seems, I just saw, to have similar issue as ExcelDataReader CodePlex issue #Id6027, Chinese Encoding Reading Error.
For Invoice _TE-132-SA-2.xls: If I copied data into a new XLS file conversion would work.  I tried a number of combinations within version of the sheet itself, I copied, moved, retyped cells but nothing seemed to change the problem, whatever I tried would result in "TOTAL UNITS" cells convert correctly and all other String cells convert to blank)
Best regards,
Peter

From: Ian1971<EMAIL_ADDRESS>Sent: Monday, April 20, 2015 8:34 AM
To: ExcelDataReader/ExcelDataReader
Cc: Sandin, Peter
Subject: Re: [ExcelDataReader] String values converted to blank in some XLS format files (#64)
Where did the original files come from?
On Mon, Apr 20, 2015 at 1:17 PM, snowstorm0951<EMAIL_ADDRESS>wrote:

In some XLS format files cells with string values convert to blank in the
Datatable cell.
In once old test file in BIFF8 format values like 'a', 'b','c' etc
converted to blank.
Changing the font in the file to Arial and re-saving bypassed the problem.
In a second test file only string cells with the value TOTAL UNITS
converted correctly and all other string cells converted to blanks. Could
not find a way to bypass the problem. Could not find any characteristic
that made this XLS file different than many others. If I copied and pasted
values into a new sheet conversion worked.
Could not figure out how to attach sample files to this issue report.
--
Reply to this email directly or view it on GitHub
https://github.com/ExcelDataReader/ExcelDataReader/issues/64.

--
Ian Cox
C.T.O.
System Sync
m: Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w: http://www.systemsyncsolutions.com
http://www.releasemobile.com/
Registered in England as systemsync solutions ltd.
Number: 9326325 VAT: 202729923

Reply to this email directly or view it on GitHubhttps://github.com/ExcelDataReader/ExcelDataReader/issues/64#issuecomment-94440772.

This would require stepping through the code to figure out what it is about
these specific sheets that cause a problem. Unfortunately, I am snowed
under at the moment, so don't have time to do that.
On Mon, Apr 20, 2015 at 2:11 PM, snowstorm0951<EMAIL_ADDRESS>wrote:

Thx,
I have the two files.
The Book1.xls file is, I think, from NPOI install as sample to NPIO
The Invoice _TE-132-SA-2.xls file was part of ExcelDataReader CodePlex
issue Id #11928 GetValue returns empty string for cells in some xls file
Both files convert correctly if I use LinqToExcel which I switched to when
I could not figure out how to get them to work under ExcelDataReader.
The Book1.xls file seems, I just saw, to have similar issue as
ExcelDataReader CodePlex issue #Id6027, Chinese Encoding Reading Error.
For Invoice _TE-132-SA-2.xls: If I copied data into a new XLS file
conversion would work. I tried a number of combinations within version of
the sheet itself, I copied, moved, retyped cells but nothing seemed to
change the problem, whatever I tried would result in "TOTAL UNITS" cells
convert correctly and all other String cells convert to blank)
Best regards,
Peter

From: Ian1971<EMAIL_ADDRESS>Sent: Monday, April 20, 2015 8:34 AM
To: ExcelDataReader/ExcelDataReader
Cc: Sandin, Peter
Subject: Re: [ExcelDataReader] String values converted to blank in some
XLS format files (#64)
Where did the original files come from?
On Mon, Apr 20, 2015 at 1:17 PM, snowstorm0951<EMAIL_ADDRESS>wrote:

In some XLS format files cells with string values convert to blank in the
Datatable cell.
In once old test file in BIFF8 format values like 'a', 'b','c' etc
converted to blank.
Changing the font in the file to Arial and re-saving bypassed the
problem.
In a second test file only string cells with the value TOTAL UNITS
converted correctly and all other string cells converted to blanks. Could
not find a way to bypass the problem. Could not find any characteristic
that made this XLS file different than many others. If I copied and
pasted
values into a new sheet conversion worked.
Could not figure out how to attach sample files to this issue report.
--
Reply to this email directly or view it on GitHub
https://github.com/ExcelDataReader/ExcelDataReader/issues/64.

--
Ian Cox
C.T.O.
System Sync
m: Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w: http://www.systemsyncsolutions.com
http://www.releasemobile.com/
Registered in England as systemsync solutions ltd.
Number: 9326325 VAT: 202729923

Reply to this email directly or view it on GitHub<
https://github.com/ExcelDataReader/ExcelDataReader/issues/64#issuecomment-94440772

.

--
Reply to this email directly or view it on GitHub
https://github.com/ExcelDataReader/ExcelDataReader/issues/64#issuecomment-94447794
.

--
Ian Cox
C.T.O.
Release  Mobile
m:            Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w:            http://www.releasemobile.com
Registered in England.  Number 06323661

Ok, no prob, feel free to close out issue in Github, i worked around using linqtoexcel and just reported it while i had material fresh at hand
Best regards
Peter
Sent from my iPhone
On Apr 20, 2015, at 9:26 AM, Ian1971 <notifications<EMAIL_ADDRESS>wrote:
This would require stepping through the code to figure out what it is about
these specific sheets that cause a problem. Unfortunately, I am snowed
under at the moment, so don't have time to do that.
On Mon, Apr 20, 2015 at 2:11 PM, snowstorm0951 <notifications<EMAIL_ADDRESS>wrote:

Thx,
I have the two files.
The Book1.xls file is, I think, from NPOI install as sample to NPIO
The Invoice _TE-132-SA-2.xls file was part of ExcelDataReader CodePlex
issue Id #11928 GetValue returns empty string for cells in some xls file
Both files convert correctly if I use LinqToExcel which I switched to when
I could not figure out how to get them to work under ExcelDataReader.
The Book1.xls file seems, I just saw, to have similar issue as
ExcelDataReader CodePlex issue #Id6027, Chinese Encoding Reading Error.
For Invoice _TE-132-SA-2.xls: If I copied data into a new XLS file
conversion would work. I tried a number of combinations within version of
the sheet itself, I copied, moved, retyped cells but nothing seemed to
change the problem, whatever I tried would result in "TOTAL UNITS" cells
convert correctly and all other String cells convert to blank)
Best regards,
Peter

From: Ian1971<EMAIL_ADDRESS>Sent: Monday, April 20, 2015 8:34 AM
To: ExcelDataReader/ExcelDataReader
Cc: Sandin, Peter
Subject: Re: [ExcelDataReader] String values converted to blank in some
XLS format files (#64)
Where did the original files come from?
On Mon, Apr 20, 2015 at 1:17 PM, snowstorm0951 <notifications<EMAIL_ADDRESS>wrote:

In some XLS format files cells with string values convert to blank in the
Datatable cell.
In once old test file in BIFF8 format values like 'a', 'b','c' etc
converted to blank.
Changing the font in the file to Arial and re-saving bypassed the
problem.
In a second test file only string cells with the value TOTAL UNITS
converted correctly and all other string cells converted to blanks. Could
not find a way to bypass the problem. Could not find any characteristic
that made this XLS file different than many others. If I copied and
pasted
values into a new sheet conversion worked.
Could not figure out how to attach sample files to this issue report.
--
Reply to this email directly or view it on GitHub
https://github.com/ExcelDataReader/ExcelDataReader/issues/64.

--
Ian Cox
C.T.O.
System Sync
m: Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w: http://www.systemsyncsolutions.com
http://www.releasemobile.com/
Registered in England as systemsync solutions ltd.
Number: 9326325 VAT: 202729923

Reply to this email directly or view it on GitHub<
https://github.com/ExcelDataReader/ExcelDataReader/issues/64#issuecomment-94440772

.

--
Reply to this email directly or view it on GitHub
https://github.com/ExcelDataReader/ExcelDataReader/issues/64#issuecomment-94447794
.

--
Ian Cox
C.T.O.
Release Mobile
m: Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w: http://www.releasemobile.com
Registered in England. Number 06323661
—
Reply to this email directly or view it on GitHubhttps://github.com/ExcelDataReader/ExcelDataReader/issues/64#issuecomment-94450447.

Thanks
On Mon, Apr 20, 2015 at 2:33 PM, snowstorm0951<EMAIL_ADDRESS>wrote:

Ok, no prob, feel free to close out issue in Github, i worked around using
linqtoexcel and just reported it while i had material fresh at hand
Best regards
Peter
Sent from my iPhone
On Apr 20, 2015, at 9:26 AM, Ian1971<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
This would require stepping through the code to figure out what it is about
these specific sheets that cause a problem. Unfortunately, I am snowed
under at the moment, so don't have time to do that.
On Mon, Apr 20, 2015 at 2:11 PM, snowstorm0951<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

Thx,
I have the two files.
The Book1.xls file is, I think, from NPOI install as sample to NPIO
The Invoice _TE-132-SA-2.xls file was part of ExcelDataReader CodePlex
issue Id #11928 GetValue returns empty string for cells in some xls file
Both files convert correctly if I use LinqToExcel which I switched to
when
I could not figure out how to get them to work under ExcelDataReader.
The Book1.xls file seems, I just saw, to have similar issue as
ExcelDataReader CodePlex issue #Id6027, Chinese Encoding Reading Error.
For Invoice _TE-132-SA-2.xls: If I copied data into a new XLS file
conversion would work. I tried a number of combinations within version of
the sheet itself, I copied, moved, retyped cells but nothing seemed to
change the problem, whatever I tried would result in "TOTAL UNITS" cells
convert correctly and all other String cells convert to blank)
Best regards,
Peter

From: Ian1971<EMAIL_ADDRESS>Sent: Monday, April 20, 2015 8:34 AM
To: ExcelDataReader/ExcelDataReader
Cc: Sandin, Peter
Subject: Re: [ExcelDataReader] String values converted to blank in some
XLS format files (#64)
Where did the original files come from?
On Mon, Apr 20, 2015 at 1:17 PM, snowstorm0951<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

In some XLS format files cells with string values convert to blank in
the
Datatable cell.
In once old test file in BIFF8 format values like 'a', 'b','c' etc
converted to blank.
Changing the font in the file to Arial and re-saving bypassed the
problem.
In a second test file only string cells with the value TOTAL UNITS
converted correctly and all other string cells converted to blanks.
Could
not find a way to bypass the problem. Could not find any characteristic
that made this XLS file different than many others. If I copied and
pasted
values into a new sheet conversion worked.
Could not figure out how to attach sample files to this issue report.
--
Reply to this email directly or view it on GitHub
https://github.com/ExcelDataReader/ExcelDataReader/issues/64.

--
Ian Cox
C.T.O.
System Sync
m: Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w: http://www.systemsyncsolutions.com
http://www.releasemobile.com/
Registered in England as systemsync solutions ltd.
Number: 9326325 VAT: 202729923

Reply to this email directly or view it on GitHub<

https://github.com/ExcelDataReader/ExcelDataReader/issues/64#issuecomment-94440772

.

--
Reply to this email directly or view it on GitHub
<
https://github.com/ExcelDataReader/ExcelDataReader/issues/64#issuecomment-94447794
.

--
Ian Cox
C.T.O.
Release Mobile
m: Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w: http://www.releasemobile.com
Registered in England. Number 06323661
--
Reply to this email directly or view it on GitHub<
https://github.com/ExcelDataReader/ExcelDataReader/issues/64#issuecomment-94450447

.

--
Reply to this email directly or view it on GitHub
https://github.com/ExcelDataReader/ExcelDataReader/issues/64#issuecomment-94451807
.

--
Ian Cox
C.T.O.
Release  Mobile
m:            Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w:            http://www.releasemobile.com
Registered in England.  Number 06323661


Adding new intents + training examples

Adding new intents, namely: online_banking, retirement_plan, change_pin, interest_rate. Also contributing with some extra examples on transfer_money. I'd suggest the duplicate intents to be merged together.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for submitting a pull request 🚀 @samsucik will take a look at it as soon as possible ✨

Hi @luiseloi, thanks a lot for the contribution! Before we go ahead and merge it, could you add the new intents to the README as well? Additionally, I agree that transfer_money shouldn't be twice in the NLU file. Do you want to go ahead and merge the two groups of transfer_money examples together? :-)

Hi, sure! Still starting to contribute, so I didn't want to mess up with the work already done there. I also merged the currency duplicates to keep it clean.

Cool, thanks :)


python3Packages.sourmash: init at 4.8.2

Description of changes
sourmash is a bioinformatics tool for quickly searching, comparing, and analyzing genomic and metagenomic data sets.
Homepage: https://sourmash.bio
GitHub: https://github.com/sourmash-bio/sourmash
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[-] (Package updates) Added a release notes entry if the change is major or breaking
[-] (Module updates) Added a release notes entry if the change is significant
[-] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2192

@ofborg build

one test fails:
=================================== FAILURES ===================================
_ test_gather_check_scaled_bounds_less_than_minimum[--no-prefetch---no-linear] _
[gw58] linux -- Python 3.10.11 /nix/store/95cxzy2hpizr23343b8bskl4yacf4b3l-python3-3.10.11/bin/python3.10
runtmp = <sourmash_tst_utils.RunnerContext object at 0x7ffbe29cd0f0>
prefetch_gather = '--no-prefetch', linear_gather = '--no-linear'
    def test_gather_check_scaled_bounds_less_than_minimum(runtmp, prefetch_gather, linear_gather):
        testdata_glob = utils.get_test_data('gather/GCF*.sig')
        testdata_sigs = glob.glob(testdata_glob)

        query_sig = utils.get_test_data('gather/combined.sig')

        with pytest.raises(SourmashCommandFailed):
            runtmp.sourmash('gather', query_sig, prefetch_gather, linear_gather, 'gcf_all', '-k', '21', '--scaled', '50', '--threshold-bp', '50000')

>       assert "WARNING: scaled value should be >= 100. Continuing anyway." in runtmp.last_result.err
E       assert 'WARNING: scaled value should be >= 100. Continuing anyway.' in '\r\x1b[Kselecting specified query k=21\n\r\x1b[Kloaded query: -... (k=21, DNA)\n\r\x1b[Kdownsampling query from scale...path.py", line 76, in join\n    a = os.fspath(a)\nTypeError: expected str, bytes or os.PathLike object, not NoneType\n'
E        +  where '\r\x1b[Kselecting specified query k=21\n\r\x1b[Kloaded query: -... (k=21, DNA)\n\r\x1b[Kdownsampling query from scale...path.py", line 76, in join\n    a = os.fspath(a)\nTypeError: expected str, bytes or os.PathLike object, not NoneType\n' = ScriptResults(status=-1, out='', err='\r\x1b[Kselecting specified query k=21\n\r\x1b[Kloaded query: -... (k=21, DNA)\n...ath.py", line 76, in join\n    a = os.fspath(a)\nTypeError: expected str, bytes or os.PathLike object, not NoneType\n').err
E        +    where ScriptResults(status=-1, out='', err='\r\x1b[Kselecting specified query k=21\n\r\x1b[Kloaded query: -... (k=21, DNA)\n...ath.py", line 76, in join\n    a = os.fspath(a)\nTypeError: expected str, bytes or os.PathLike object, not NoneType\n') = <sourmash_tst_utils.RunnerContext object at 0x7ffbe29cd0f0>.last_result
tests/test_sourmash.py:4417: AssertionError
----------------------------- Captured stdout call -----------------------------
running: sourmash in: /build/sourmashtest_33f6e022
arguments ['sourmash', 'gather', '/build/sourmash-4.8.2/tests/test-data/gather/combined.sig', '--no-prefetch', '--no-linear', 'gcf_all', '-k', '21', '--scaled', '50', '--threshold-bp', '50000']
=============================== warnings summary ===============================

Result of nixpkgs-review pr 230596 run on x86_64-linux 1

4 packages failed to build:

python310Packages.sourmash
python310Packages.sourmash.dist
python311Packages.sourmash
python311Packages.sourmash.dist

I'm very confused with the current build error... Before it was related to tests, but now it is because a weird mode 130 is being inserted in the ffi.dlopen, but that doesn't happen by regular Python packaging tooling (nor by running nix build github:sourmash-bio/sourmash# ; cat result/lib/python3.10/site-packages/sourmash/_lowlevel/__init__.py, the flake-based package building I have in the upstream repo).
$ nix build .#python311Packages.sourmash
error: builder for '/nix/store/ha2j8l482pn0va7wkddb96vasvdmab4a-python3.11-sourmash-4.8.2.drv' failed with exit code 1;
       last 10 log lines:
       >   File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
       >   File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
       >   File "<frozen importlib._bootstrap_external>", line 940, in exec_module
       >   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
       >   File "/nix/store/qgv5ldklwg064vzdal7djzc1wv85f2l2-python3.11-sourmash-4.8.2/lib/python3.11/site-packages/sourmash/__init__.py", line 33, in <module>
       >     from ._lowlevel import ffi, lib
       >   File "/nix/store/qgv5ldklwg064vzdal7djzc1wv85f2l2-python3.11-sourmash-4.8.2/lib/python3.11/site-packages/sourmash/_lowlevel.py", line 7, in <module>
       >     lib = ffi.dlopen(os.path.join(os.path.dirname(__file__), '_lowlevel__lib.so'), 130)
       >           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       > OSError: cannot load library '/nix/store/qgv5ldklwg064vzdal7djzc1wv85f2l2-python3.11-sourmash-4.8.2/lib/python3.11/site-packages/sourmash/_lowlevel__lib.so': invalid mode parameter
       For full logs, run 'nix log /nix/store/ha2j8l482pn0va7wkddb96vasvdmab4a-python3.11-sourmash-4.8.2.drv'.

Is anyone aware of a Python hook that could be changing that? Not sure how to fix this...

While this PR is open, maturin of nixpkgs is reached 1.0.0 in #230799. This is why the build failed. I can build it by applying these two patches. sourmash-bio/sourmash@9de27b6 sourmash-bio/sourmash@406b945

Indeed, thanks @natsukium! I will do a new release of the upstream project and update the PyPI download link

@ofborg build python310Packages.sourmash

Result of nixpkgs-review pr 230596 run on x86_64-linux 1

4 packages built:

python310Packages.sourmash
python310Packages.sourmash.dist
python311Packages.sourmash
python311Packages.sourmash.dist


I am not understanding the configuration options about context length

Thanks for your tool!
I am looking into using ChatGPT to translate the StarRocks docs and found your repo.
I am trying to use -f 1000 to limit the fragment size because I am seeing this message:
This model's maximum context length is 4097 tokens. However,
your messages resulted in 4330 tokens. Please reduce the length
of the messages.

This is the Markdown file that I am trying to translate:
https://raw.githubusercontent.com/StarRocks/starrocks/main/docs/loading/cloud_storage_load.md
This is my full commandline:
npx ts-node-esm index.ts -f 1000 \
../starrocks/docs/loading/cloud_storage_load.md

Thanks!

Thanks so much! I appreciate your help!


WIP - Add ability to setup Route 53 private hosted zones

I am working to extend the ec2_vpc type to support Route 53 private hosted zones
For more information see - http://docs.aws.amazon.com/Route53/latest/DeveloperGuide/hosted-zones-private.html
I have added two properties to support setting enableDNSHostnames and enableDNSSupport.
Looking for input
The code is working when creating a brand new VPC.  However I am unsure why it is not working when I try to update the boolean value after it has been created.
Create Sample-VPC
22:52 - root@atom: infrastructure/aws-config
$ puppet resource ec2_vpc sample-vpc ensure=present region=ap-southeast-2 cidr_block='<IP_ADDRESS>/16' --modulepath ~/dev/puppet-modules-development
Notice: /Ec2_vpc[sample-vpc]/ensure: created
ec2_vpc { 'sample-vpc':
  ensure => 'absent',
}

Show that Sample-VPC has been created
22:53 - root@atom: infrastructure/aws-config
$ puppet resource ec2_vpc --modulepath ~/dev/puppet-modules-development
ec2_vpc { 'sample-vpc':
  ensure               => 'present',
  cidr_block           => '<IP_ADDRESS>/16',
  enable_dns_hostnames => 'false',
  enable_dns_support   => 'true',
  instance_tenancy     => 'default',
  region               => 'ap-southeast-2',
}

Attempt to modify the two boolean values
Note: Puppet does detect that some values are different and says it will change them.
22:54 - root@atom: infrastructure/aws-config
$ puppet resource ec2_vpc sample-vpc ensure=present region=ap-southeast-2 cidr_block='<IP_ADDRESS>/16' enable_dns_hostnames=true enable_dns_support=false --modulepath ~/dev/puppet-modules-development
Notice: /Ec2_vpc[sample-vpc]/enable_dns_support: enable_dns_support changed 'true' to 'false'
Notice: /Ec2_vpc[sample-vpc]/enable_dns_hostnames: enable_dns_hostnames changed 'false' to 'true'
ec2_vpc { 'sample-vpc':
  ensure               => 'present',
  cidr_block           => '<IP_ADDRESS>/16',
  enable_dns_hostnames => 'true',
  enable_dns_support   => 'false',
  instance_tenancy     => 'default',
  region               => 'ap-southeast-2',
}

Show that it has not updated the two values
22:56 - root@atom: infrastructure/aws-config
$ puppet resource ec2_vpc --modulepath ~/dev/puppet-modules-development
ec2_vpc { 'sample-vpc':
  ensure               => 'present',
  cidr_block           => '<IP_ADDRESS>/16',
  enable_dns_hostnames => 'false',
  enable_dns_support   => 'true',
  instance_tenancy     => 'default',
  region               => 'ap-southeast-2',
}

Any thoughts on why this is not working?

@garethr sorry for the ping, I am interested in getting to the bottom of this.  I think I am missing something trivial/fundamental.  I think my code is breaking with the boolean property values.
To troubleshoot I have set two locations to print out information on the vpn:

in the instances function for the provider (lib/puppet/provider/ec2_vpc/v2.rb#L10)
in the exists? function for the provider (lib/puppet/provider/ec2_vpc/v2.rb#L57)

If you look at the second ">>>> In Exists? clode" output, both the enable_dns_support and enable_dns_hostnames boolean values appear to by ruby symbols (:false and :true) rather than boolean values (false and true).
Am I looking in the wrong place?
20:28 - root@atom: infrastructure/aws-config
$ puppet resource ec2_vpc sample-vpc ensure=present region=ap-southeast-2 cidr_block='<IP_ADDRESS>/16' enable_dns_hostnames=true enable_dns_support=false --modulepath ~/dev/puppet-modules-development

">>>> Getting list of instances"
{:name=>"sample-vpc",
 :id=>"vpc-1b92457e",
 :cidr_block=>"<IP_ADDRESS>/16",
 :instance_tenancy=>"default",
 :ensure=>:present,
 :region=>"ap-southeast-2",
 :tags=>{},
 :dhcp_options=>nil,
 :enable_dns_support=>true,
 :enable_dns_hostnames=>false}

">>>> In Exists? code"
{:name=>"sample-vpc",
 :id=>"vpc-1b92457e",
 :cidr_block=>"<IP_ADDRESS>/16",
 :instance_tenancy=>"default",
 :ensure=>:present,
 :region=>"ap-southeast-2",
 :tags=>{},
 :dhcp_options=>nil,
 :enable_dns_support=>true,
 :enable_dns_hostnames=>false}
Notice: /Ec2_vpc[sample-vpc]/enable_dns_support: enable_dns_support changed 'true' to 'false'
Notice: /Ec2_vpc[sample-vpc]/enable_dns_hostnames: enable_dns_hostnames changed 'false' to 'true'

">>>> In Exists? code"
{:name=>"sample-vpc",
 :id=>"vpc-1b92457e",
 :cidr_block=>"<IP_ADDRESS>/16",
 :instance_tenancy=>"default",
 :ensure=>:present,
 :region=>"ap-southeast-2",
 :tags=>{},
 :dhcp_options=>nil,
 :enable_dns_support=>:false,
 :enable_dns_hostnames=>:true}
ec2_vpc { 'sample-vpc':
  ensure               => 'present',
  cidr_block           => '<IP_ADDRESS>/16',
  enable_dns_hostnames => 'true',
  enable_dns_support   => 'false',
  instance_tenancy     => 'default',
  region               => 'ap-southeast-2',
}

@pjfoley also with the creating of private zones you now need to specify the zone id because you can potentially have a split dns setup where public and private are same zone name so R53 needs to be updated to support the zone id's to distinguish which is which.

@cdenneen I am not sure I understand, I have looked at the docs for the create_vpc and cannot seem to see a way to specify the zone id?
Looking further into it are you saying I need to extend https://github.com/puppetlabs/puppetlabs-aws/blob/master/lib/puppet/provider/route53_zone/v2.rb#L35 to allow the end user to specify the vpc_id?

No route53 supports public and private hosted zones for DNS. The module
only supports zone name not id. Therefore if you have a public and private
using same DNS name mydomain.com for split DNS, there is no referencing
which zone you are talking about.
On Sat, May 23, 2015 at 8:53 AM pjfoley<EMAIL_ADDRESS>wrote:

@cdenneen https://github.com/cdenneen I am not sure I understand, I
have looked at the docs for the create_vpc
http://docs.aws.amazon.com/sdkforruby/api/Aws/EC2/Client.html#create_vpc-instance_method
and cannot seem to see a way to specify the zone id?
Looking further into it are you saying I need to extend
https://github.com/puppetlabs/puppetlabs-aws/blob/master/lib/puppet/provider/route53_zone/v2.rb#L35
to allow the end user to specify the vpc_id?
—
Reply to this email directly or view it on GitHub
https://github.com/puppetlabs/puppetlabs-aws/pull/157#issuecomment-104889626
.

Ok, I did some reading and think I understand the issue you have raised.  Let me know if my understanding is correct.
As the puppetlabs-aws module is currently setup the route 53 puppet type uses the domain name as the namevar (essentially meaning you cannot re-declare the domain name again).
Using a use case if you wanted to setup a split public/private DNS for puppetlabs.com, you would need to something like:
ec2_vpc { 'internal-vpc':
  ensure               => 'present',
  cidr_block           => '<IP_ADDRESS>/16',
  enable_dns_hostnames => 'true',
  enable_dns_support   => 'true',
  instance_tenancy     => 'default',
  region               => 'ap-southeast-2',
}

# Setup public DNS for puppetlabs.com using route 53
route53_zone { 'puppetlabs.com.':
  ensure => present,
}

# Setup private DNS for puppetlabs.com using route 53
# Domain is the namevar for the puppet type
route53_private_zone { 'Internal - puppetlabs.com.':
  zone => 'puppetlabs.com,
  vpc_id => function_to_get_vpc_id('internal-vpc'),
  ensure => present,
}

# public
route53_a_record { 'internal - local.puppetlabs.com.':
  ensure => present,
  zone   => 'puppetlabs.com.',
  ttl    => 3000,
  values => ['<IP_ADDRESS>'],
}

# private
route53_a_record { 'local.puppetlabs.com.':
  ensure => present,
  zone   => 'puppetlabs.com.',
  vpc_id => function_to_get_vpc_id('internal-vpc'),
  ttl    => 3000,
  values => ['<IP_ADDRESS>'],
}

References:
http://grokible.com/aws-vpc-topics-effective-use-of-route-53-private-hosted-zones/

Yes essentially that is correct.
I'm sure you could do both with route53_zone having private boolean and using name param's
route53_zone { 'puppetlabs.com.':
  ensure => present,
  name => 'puppetlabs.com.'
}

route53_zone { 'private puppetlabs zone':
  ensure => present,
  private => true,
  name   => 'puppetlabs.com.',
}

obviously without different titles and using name param you'll have duplicate declaration.
or using this logic of route53_zone and route53_private_zone the a record could have param of private => true/false (defaults to false) instead of needing vpc_id no?

When I came up with that suggested type, it was based off the AWS docs.  The way I understand it you can have multiple private zone's for the same domain allowing for localised responses.  Something like the below:
# Setup public DNS zone
route53_zone { 'public - puppetlabs.com.':
  zone => 'puppetlabs.com',
  ensure => present,
}

# Setup private DNS for puppetlabs.com
route53_zone { 'Region A - puppetlabs.com.':
  zone => 'puppetlabs.com',
  vpc_id => function_to_get_vpc_id('region-a-vpc'),
  ensure => present,
}

# Setup private DNS for puppetlabs.com in Region A
route53_zone { 'Region A - puppetlabs.com.':
  zone => 'puppetlabs.com',
  vpc_id => function_to_get_vpc_id('region-a-vpc'),
  ensure => present,
}

# Setup private DNS for puppetlabs.com in Region B
route53_zone { 'Region B - puppetlabs.com.':
  zone => 'puppetlabs.com',
  vpc_id => function_to_get_vpc_id('region-b-vpc'),
  ensure => present,
}

# public
route53_a_record { 'public - api.puppetlabs.com.':
  a_record => 'api.puppetlabs.com',
  ensure => present,
  zone   => 'puppetlabs.com.',
  ttl    => 3000,
  values => ['<IP_ADDRESS>'],
}

# private - In Region A subnet <IP_ADDRESS>/24
route53_a_record { 'Region A - api.puppetlabs.com.':
  a_record => 'api.puppetlabs.com',
  ensure => present,
  zone   => 'puppetlabs.com.',
  vpc_id => function_to_get_vpc_id('internal-a-vpc'),
  ttl    => 3000,
  values => ['<IP_ADDRESS>'],
}

# private - In Region B subnet <IP_ADDRESS>/24
route53_a_record { 'Region B - api.puppetlabs.com.':
  a_record => 'api.puppetlabs.com',
  ensure => present,
  zone   => 'puppetlabs.com.',
  vpc_id => function_to_get_vpc_id('internal-b-vpc'),
  ttl    => 3000,
  values => ['<IP_ADDRESS>'],
}

@pjfoley, I know this is an old one, but do you have any plans to pick this up again? Thanks!

I believe this was also added in #418.  I didn't see there was duplicate, so sorry for that.  I think this can be closed out since #418 has been merged.  @ahenroid Good?

Thanks, @zleswomp. Yes, closing now.

I'd just like to add, I don't think this is actually entirely resolved; #418 only allowed specifying a VPC ID on zones, they still don't allow you to specify a VPC id when creating a record to disambiguate between zones with the same name (nor can you specify the zone by zone_id instead of name).


Enable to expand session details

Kind (Required)

Improvement

Overview (Required)

We should collapse session detail text 📜

design

Links

🙋

Thanks Assigined 🙇