Bug 1890741: Fix the path to the CA trust bundle ConfigMap

Overview of Changes
Update the charts/openshift-metering reporting-operator Deployment object, ensuring that the correct ConfigMap path is specified when the user CA bundle is being injected into the containers.
Going through the certificate injection using Operators documentation, we can see that the required key is ca-bundle.crt and the required path name is tls-ca-bundle.pem.
Before, and not using the required path name, resulted in the following invalid symbolic links being produced in the reporting-operator container(s):
bash-4.2$ ls -alt /etc/pki/tls
total 12
drwxr-xr-x. 1 root root    21 Sep 18 17:13 ..
drwxr-xr-x. 5 root root    81 Sep 18 17:12 .
lrwxrwxrwx. 1 root root    49 Sep 18 17:12 cert.pem -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
...
bash-4.2$ cat /etc/pki/tls/cert.pem
cat: /etc/pki/tls/cert.pem: No such file or directory
bash-4.2$

bash-4.2$ ls -alt /etc/pki/ca-trust/extracted/pem/
total 0
drwxrwsrwx. 3 root<PHONE_NUMBER> 80 Oct 22 19:37 .
drwxr-sr-x. 2 root<PHONE_NUMBER> 27 Oct 22 19:37 ..2020_10_22_19_37_25.110890324
lrwxrwxrwx. 1 root root       31 Oct 22 19:37 ..data -> ..2020_10_22_19_37_25.110890324
lrwxrwxrwx. 1 root root       20 Oct 22 19:37 ca-bundle.crt -> ..data/ca-bundle.crt
drwxr-xr-x. 5 root root       58 Sep 18 17:12 ..
bash-4.2$

Here, we can see that while a symbolic link has been established, it's referencing a file that does not exist. If we instead following the documentation linked above, correcting that path to the ConfigMap contents, that symbolic link is properly established.
Reviewer Notes

QE spun up a proxy-enabled 4.5 OCP cluster.
The cluster/Proxy object was edit-ed to set a spec.trustedCA ConfigMap. That ConfigMap was manually created in the openshift-config namespace.
Metering was installed using the redhat-operators metering-ocp 4.5 channel.
Scaled the metering-operator Deployment to zero replicas.
Directly edit-ed the reporting-operator Deployment, fixing the wrong path name to tls-ca-bundle.pem.
Exec-ed into the newly built reporting-operator Pod. Verified that symbolic link has now been properly established and can successfully view the /etc/pki/ca-trusted/extracted/pem/tls-ca-bundle.pem contents.
Validated that I was still able to generate and view Report results.

/bugzilla refresh

/cherrypick release-4.6

Hmm, like a flake with MachineSet not being a valid CRD:
+ kubectl apply -f -
machineautoscaler.autoscaling.openshift.io/ci-op-zg3q8r8q-1deb1-vhwfh-worker-us-west-2a created
+ for machine in '"${MACHINESETS[@]}"'
++ oc -n openshift-machine-api get machineset ci-op-zg3q8r8q-1deb1-vhwfh-worker-us-west-2b -o 'jsonpath={.metadata.name}'
I1022 20:27:26.821014    2532 request.go:645] Throttling request took 1.08259733s, request: GET:https://api.ci-op-zg3q8r8q-1deb1.origin-ci-int-aws.dev.rhcloud.com:6443/apis/security.internal.openshift.io/v1?timeout=32s
error: the server doesn't have a resource type "machineset"
+ export MACHINE_NAME=
+ MACHINE_NAME=
+ envsubst
+ kubectl apply -f -
error: error validating "STDIN": error validating data: ValidationError(MachineAutoscaler.spec.scaleTargetRef): missing required field "name" in io.openshift.autoscaling.v1beta1.MachineAutoscaler.spec.scaleTargetRef; if you choose to ignore these errors, turn validation off with --validate=false
Removing namespaces with the 'name=metering-metering-testing-ns' label
I1022 20:28:11.021010    2572 request.go:645] Throttling request took 1.157855239s, request: GET:https://api.ci-op-zg3q8r8q-1deb1.origin-ci-int-aws.dev.rhcloud.com:6443/apis/coordination.k8s.io/v1beta1?timeout=32s
No resources found
Removing any testing labels that were added to the cluster's nodes
I1022 20:28:22.342908    2593 request.go:645] Throttling request took 1.000444994s, request: GET:https://api.ci-op-zg3q8r8q-1deb1.origin-ci-int-aws.dev.rhcloud.com:6443/apis/whereabouts.cni.cncf.io/v1alpha1?timeout=32s
No resources found
Removing the local registry resources with the 'name=metering-metering-testing-ns' label
I1022 20:28:33.805533    2614 request.go:645] Throttling request took 1.165846541s, request: GET:https://api.ci-op-zg3q8r8q-1deb1.origin-ci-int-aws.dev.rhcloud.com:6443/apis/migration.k8s.io/v1alpha1?timeout=32s
I1022 20:28:44.405524    2614 request.go:645] Throttling request took 1.127294501s, request: GET:https://api.ci-op-zg3q8r8q-1deb1.origin-ci-int-aws.dev.rhcloud.com:6443/apis/image.openshift.io/v1?timeout=32s
I1022 20:28:54.605521    2614 request.go:645] Throttling request took 11.327180655s, request: GET:https://api.ci-op-zg3q8r8q-1deb1.origin-ci-int-aws.dev.rhcloud.com:6443/apis/autoscaling.openshift.io/v1beta1?timeout=32s
I1022 20:29:04.685544    2614 request.go:645] Throttling request took 5.916145288s, request: GET:https://api.ci-op-zg3q8r8q-1deb1.origin-ci-int-aws.dev.rhcloud.com:6443/apis/policy/v1beta1?timeout=32s
I1022 20:29:14.885551    2614 request.go:645] Throttling request took 5.319417985s, request: GET:https://api.ci-op-zg3q8r8q-1deb1.origin-ci-int-aws.dev.rhcloud.com:6443/apis/autoscaling/v2beta1?timeout=32s
I1022 20:29:26.085531    2614 request.go:645] Throttling request took 1.119755825s, request: GET:https://api.ci-op-zg3q8r8q-1deb1.origin-ci-int-aws.dev.rhcloud.com:6443/apis/storage.k8s.io/v1?timeout=32s
I1022 20:29:36.285555    2614 request.go:645] Throttling request took 11.31965355s, request: GET:https://api.ci-op-zg3q8r8q-1deb1.origin-ci-int-aws.dev.rhcloud.com:6443/apis/scheduling.k8s.io/v1beta1?timeout=32s
No resources found
Exiting hack/e2e.sh
make: *** [e2e] Error 1
error: failed to execute wrapped command: exit status 2

/retest

Hey... notice K8s documentation suggests having this order:
volumeMount
name
Could you switch the order?
https://kubernetes.io/docs/concepts/storage/volumes/

Hey... notice K8s documentation suggests having this order:
volumeMount
name
Could you switch the order?
https://kubernetes.io/docs/concepts/storage/volumes/

Yeah, I see that but I opted for being consistent with the rest of the reporting-operator Deployment instead of k8s YAML best practices, which is fine in my opinion. Going forward, if someone opened a PR that ensured all of the YAML manifests meet k8s best practices, I think I would shoot that PR down, unless our manifests are all over the place (which might be the case).

You know, I will put a PR to fix the ones in this file rn, except for your cert ones, so we don't merge conflict.
I can wait till this merges and oull these in and fix your last 2 here. Then we can have 1 consistent file at least.

You know, I will put a PR to fix the ones in this file rn, except for your cert ones, so we don't merge conflict.
I can wait till this merges and oull these in and fix your last 2 here. Then we can have 1 consistent file at least.

I typically fall in line that's a wasted effort unless you do it for all of the charts/openshift-metering/templates, which is a much larger task, and there are more pressing things to tackle. That said if you want to tackle some more straight-forward work on the side, I won't stand in the way.

The e2e test is still failing one of the Metering test installations as it looks like the ServiceAccount resource gets potentially garbage collected before OLM can verify it's existence. Poking around the status field of the InstallPlan CR for that installation:
  - group: ""
    kind: ServiceAccount
    message: Service account does not exist
    name: metering-operator
    status: NotPresent
    version: v1

I'm going to adding that resource to our list of namespace-scoped resources we're interested in gathering for test installations as that should help test us whether we enforcing a strange owner reference situation that causes a resource to get GC'd abruptly.

/retest

/retest

/retest


Fix malformed variables file after edit

Every time you edit variables files it breaks. To solve this, the ideal would be to create a temporary file that is checked before being passed into the actual file.

Change introduced in commit 52160f3. Rolling out in next release.


CMake Error at CMakeLists.txt:6 (find_package):   "controller_manager"

Hi,
/gazebo_ros2_control_demos builds,
but not /gazebo_ros2_control
Starting >>> gazebo_ros2_control
--- stderr: gazebo_ros2_control
CMake Error at CMakeLists.txt:6 (find_package):
  By not providing "Findcontroller_manager.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "controller_manager", but CMake did not find one.

  Could not find a package configuration file provided by
  "controller_manager" with any of the following names:

    controller_managerConfig.cmake
    controller_manager-config.cmake

  Add the installation prefix of "controller_manager" to CMAKE_PREFIX_PATH or
  set "controller_manager_DIR" to a directory containing one of the above
  files.  If "controller_manager" provides a separate development package or
  SDK, be sure it has been installed.

---
Failed   <<< gazebo_ros2_control [1.77s, exited with code 1]

Summary: 0 packages finished [1.87s]
  1 package failed: gazebo_ros2_control
  1 package had stderr output: gazebo_ros2_control

any ideas?

You should install ros2_control, you have two options:

Install sources from this repository  or
sudo apt-get install ros-foxy-ros2-control

ros2_control is not released yet in Galatic, if you are using this version you must install ros2_control from sources.
Please ask this kind of question here: https://answers.gazebosim.org/questions/

Thank you @ahcorde
Not sure if this a local or global issue, but for Foxy, I had to directly git clone https://github.com/ros-controls/ros2_control.git
because my apt-get is fully updated after successfully installing moveit2
but  sudo apt-get install ros-foxy-ros2-control gave this error:
[sudo] password for user:
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages were automatically installed and are no longer required:
  python3-xkit ubuntu-drivers-common
Use 'sudo apt autoremove' to remove them.
The following additional packages will be installed:
  ros-foxy-controller-interface ros-foxy-controller-manager ros-foxy-controller-manager-msgs ros-foxy-hardware-interface
  ros-foxy-ros2-control-test-assets ros-foxy-ros2controlcli
The following NEW packages will be installed:
  ros-foxy-controller-interface ros-foxy-controller-manager ros-foxy-controller-manager-msgs ros-foxy-hardware-interface
  ros-foxy-ros2-control ros-foxy-ros2-control-test-assets ros-foxy-ros2controlcli
0 upgraded, 7 newly installed, 0 to remove and 10 not upgraded.
Need to get 1,264 kB of archives.
After this operation, 12.8 MB of additional disk space will be used.
Do you want to continue? [Y/n] Y

I
Err:1 http://packages.ros.org/ros2/ubuntu focal/main amd64 ros-foxy-hardware-interface amd64 0.4.0-1focal.20210415.032844
  404  Not Found [IP: <IP_ADDRESS> 80]
Err:2 http://packages.ros.org/ros2/ubuntu focal/main amd64 ros-foxy-controller-interface amd64 0.4.0-1focal.20210415.045005
  404  Not Found [IP: <IP_ADDRESS> 80]
Err:3 http://packages.ros.org/ros2/ubuntu focal/main amd64 ros-foxy-controller-manager-msgs amd64 0.4.0-1focal.20210415.023245
  404  Not Found [IP: <IP_ADDRESS> 80]
Err:4 http://packages.ros.org/ros2/ubuntu focal/main amd64 ros-foxy-controller-manager amd64 0.4.0-1focal.20210415.045203
  404  Not Found [IP: <IP_ADDRESS> 80]
Err:5 http://packages.ros.org/ros2/ubuntu focal/main amd64 ros-foxy-ros2-control-test-assets amd64 0.4.0-1focal.20210408.165615
  404  Not Found [IP: <IP_ADDRESS> 80]
Err:6 http://packages.ros.org/ros2/ubuntu focal/main amd64 ros-foxy-ros2controlcli amd64 0.4.0-1focal.20210415.050212
  404  Not Found [IP: <IP_ADDRESS> 80]
Err:7 http://packages.ros.org/ros2/ubuntu focal/main amd64 ros-foxy-ros2-control amd64 0.4.0-1focal.20210415.050937
  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://packages.ros.org/ros2/ubuntu/pool/main/r/ros-foxy-hardware-interface/ros-foxy-hardware-interface_0.4.0-1focal.20210415.032844_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://packages.ros.org/ros2/ubuntu/pool/main/r/ros-foxy-controller-interface/ros-foxy-controller-interface_0.4.0-1focal.20210415.045005_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://packages.ros.org/ros2/ubuntu/pool/main/r/ros-foxy-controller-manager-msgs/ros-foxy-controller-manager-msgs_0.4.0-1focal.20210415.023245_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://packages.ros.org/ros2/ubuntu/pool/main/r/ros-foxy-controller-manager/ros-foxy-controller-manager_0.4.0-1focal.20210415.045203_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://packages.ros.org/ros2/ubuntu/pool/main/r/ros-foxy-ros2-control-test-assets/ros-foxy-ros2-control-test-assets_0.4.0-1focal.20210408.165615_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://packages.ros.org/ros2/ubuntu/pool/main/r/ros-foxy-ros2controlcli/ros-foxy-ros2controlcli_0.4.0-1focal.20210415.050212_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://packages.ros.org/ros2/ubuntu/pool/main/r/ros-foxy-ros2-control/ros-foxy-ros2-control_0.4.0-1focal.20210415.050937_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

not sure if relevant but, I am not using amd64 seen above
processor        : x86_64
RMW MIDDLEWARE
middleware name    : rmw_fastrtps_cpp
ROS 2 INFORMATION
distribution name      : foxy
distribution type      : ros2
distribution status    : active
release platforms      : {'ubuntu': ['focal']}

same error after updating ROS2 key:
curl http://repo.ros2.org/repos.key | sudo apt-key add -

Hi
Unfortunately, the build fail persists, even after successfully building ros2_control in the same ROS2_ws
Same error at:
Starting >>> gazebo_ros2_control
--- stderr: gazebo_ros2_control
CMake Error at CMakeLists.txt:6 (find_package):
  By not providing "Findcontroller_manager.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "controller_manager", but CMake did not find one.

thanks for your help!

hi @ahcorde
ros2_control is built and sourced,
but gazebo_ros2_control fails to build. How to solve?
Thank you!

Can you clarify your setup ?

ROS 2 version
packages inside the workspace

finally solved -- with a master COLCON workspace for all ROS2 packages:
export   COLCON_WS=~/ws_ROS2
mkdir -p   $COLCON_WS/src
cd   $COLCON_WS/src
git clone some-ros-pkg-repo
cd   $COLCON_WS/
colcon build --symlink-install --packages-select
the below original workspace tree was failing to build inside gazebo-ros2-control:
~/ws_ROS2/
|__gazebo_ros2_control/src
|__gazebo_ros_pkgs/src
|__ros2_control/src
|__etc/src
This COLCON master workspace unification prompted my other Issue question.
Thanks very much again!


Revision of with-mobx example

This pull request is not ready to merge; rather, it's a request for feedback and suggestions on how to  improve integration of MobX with Next.js. See #3206.

Hi @michaelsbradleyjr !
Your withMobx higher order component is exactly what I was looking for. I've been dabbling around with next and mobx and couldn't find a good way to integrate the store into the getInitialProps.
I haven't tried your example yet but it sounds very promising.
Cheers :beers:

Try running npm run lint -- --fix to fix the standard style 👍

@michaelsbradleyjr can you check the above 😄

Yes, just haven't had time yet, hopefully over this holiday weekend. Thanks for the reminder.
Sent from my iPhone

On Nov 23, 2017, at 6:47 AM, Tim Neutkens<EMAIL_ADDRESS>wrote:
@michaelsbradleyjr can you check the above 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I ran the the --fix for both lint and standard, commited the changes, and then rebased against zeit's canary branch after fetching its latest commits.
To be honest, I'm not sure this is ready to be merged. It was/is more of a proof of concept, and I was hoping to get a little more feedback. I'm wondering if I should extract the withMobx function, genericize it a bit further, and include it in a separate package à la next-redux-wrapper. Also, my modifications to the examples are a bit clumsy, even if they do convey different aspects of withMobx usage.

@michaelsbradleyjr I'll see if I can get a chance to check this out soon

Lets keep the example simple for now 🙏

Agreed, I actually prefer @michaelsbradleyjr revised MobX example over the one now on the canary branch

Adopting the withMobx wrapper by @michaelsbradleyjr seems to be the best way to integrate mobx with next.
Any idea why i get this warning: "MobX Provider: Provided store 'store' has changed. Please avoid replacing stores as the change might not propagate to all children"
This shows up during HMR or while navigating between routes.

It's been some time since I looked at this... quite a few things came up in my professional life and my time was diverted away from next.js and MobX.  Tomorrow, I'll look at creating a standalone next-mobx-wrapper. Also, my adaptation of the with-redux-wrapper examples, demo'ing the MobX wrapper's usage, were really just proof-of-concept and quite muddy — I think I can do a lot better. I'll work on all that and put together a with-mobx-wrapper branch and pull request.

@michaelsbradleyjr sounds great!

Working on it:  https://github.com/michaelsbradleyjr/next-mobx-wrapper
Converting the proof-of-concept into a package with good ergonomics has proved to be an interesting project.


I cannot find the Windows.Data.Text.dll file

I made a lot of research on google but it's not easy to find or download it

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5436764c-2b30-1f5f-9f12-e6ecc8317e62
Version Independent ID: af39a6cb-4659-aec9-e9f0-348f47da2a18
Content: WordsSegmenter Class (Windows.Data.Text) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.data.text.wordssegmenter.yml&version=GBlive&_a=contents
Product: uwp
Git Login: mcleanbyron
Microsoft Alias: mcleans

The Windows.Data.Text.dll file cannot be downloaded separately. To use the WordsSegmenter class, make sure you have the Windows 10 SDK installed, and then make sure you have the Universal Windows SDK referenced in your UWP app project (this is referenced by default). If you install Visual Studio 2017 with the "Visual Studio Tools for Universal Windows Apps" installed, then you already have the Windows 10 SDK.


Clojure Collector: explore using ephemeral storage

https://groups.google.com/forum/#!topic/snowplow-user/hcmbIQvM36E

Won't fix, we are doubling down on the SSC:
http://discourse.snowplowanalytics.com/t/replacing-the-clojure-collector/881


Fixes #339 - Print source file and line number in alloc_pool leak backtraces automatically

When this works, the stacktrace looks like
69: #0 __interceptor_backtrace.part.0 ../../../../libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:4277
69: 	in /usr/lib64/libasan.so.8.0.0
69: #1 b_stores_backtrace /home/jdanek/repos/skupper-router/tests/c_unittests/test_alloc_pool.cpp:53
69: 	in /home/jdanek/repos/skupper-router/cmake-build-relwithdebinfo-asan/tests/c_unittests/c_unittests
69: #2 _ZN14test_backtraceL19DOCTEST_ANON_FUNC_4Ev /home/jdanek/repos/skupper-router/tests/c_unittests/test_alloc_pool.cpp:82
69: 	in /home/jdanek/repos/skupper-router/cmake-build-relwithdebinfo-asan/tests/c_unittests/c_unittests
69: #3 _ZN7doctest7Context3runEv /home/jdanek/repos/skupper-router/tests/c_unittests/doctest.h:6728
69: 	in /home/jdanek/repos/skupper-router/cmake-build-relwithdebinfo-asan/tests/c_unittests/c_unittests
69: #4 main /home/jdanek/repos/skupper-router/tests/c_unittests/c_unittests_main.cpp:78
69: 	in /home/jdanek/repos/skupper-router/cmake-build-relwithdebinfo-asan/tests/c_unittests/c_unittests
69: #5 __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:74
69: 	in /usr/lib64/libc.so.6
69: #6 __libc_start_main@@GLIBC_2.34 ../csu/libc-start.c:128
69: 	in /usr/lib64/libc.so.6
69: #7 _start (null):0
69: 	in /home/jdanek/repos/skupper-router/cmake-build-relwithdebinfo-asan/tests/c_unittests/c_unittests

Codecov Report

Merging #674 (29536b7) into main (2aa053b) will increase coverage by 0.14%.
The diff coverage is 79.01%.

@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
+ Coverage   25.91%   26.05%   +0.14%
==========================================
  Files         128      130       +2
  Lines       31195    31275      +80
  Branches     4973     4986      +13
==========================================
+ Hits         8083     8148      +65
- Misses      22059    22065       +6
- Partials     1053     1062       +9

Flag
Coverage Δ

unittests
26.05% <79.01%> (+0.14%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/alloc_pool.c
81.11% <0.00%> (-0.31%)
:arrow_down:

src/posix/symbolization.c
81.81% <81.81%> (ø)

tests/c_unittests/test_alloc_pool.cpp
82.60% <82.60%> (ø)

tests/c_unittests/doctest.h
26.31% <0.00%> (+0.04%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Travis CI pass https://app.travis-ci.com/github/jiridanek/skupper-router/builds/254104232

For clang, it is necessary to add this compiler command
-mllvm -generate-arange-section

Otherwise this bug gets hit and line number is not resolved: https://sourceware.org/bugzilla/show_bug.cgi?id=22288
OMG! And workaround for this looks super complicated. I am strongly inclined to just leave it clang-incompatible.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_c6m_2zoa7m/clone/recipe/meta.yaml:31: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_c6m_2zoa7m/clone/recipe/meta.yaml:35: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
INFO: /tmp/abs_c6m_2zoa7m/clone/recipe/meta.yaml:46: invalid_url: https://www.rrdtool.org : URL domain redirect www.rrdtool.org ->  oss.oetiker.ch
INFO: /tmp/abs_c6m_2zoa7m/clone/recipe/meta.yaml:54: invalid_url: https://www.rrdtool.org/doc/index.en.html : URL domain redirect www.rrdtool.org ->  oss.oetiker.ch
ERROR: /tmp/abs_c6m_2zoa7m/clone/recipe/meta.yaml:55: missing_license_family: The recipe is missing the about/license_family key.
Errors were found


Add feature insights to topic and time period

@mozaki1 could you please prefix the PR title with the relevant ticket number and also link to the ticket in the description?


Apply custom css styling to all table elements

I wish to use vuetable-2 with https://github.com/vuematerial/vue-material . How can I apply the styles from vue-material to table, thead, tr, and td?
The documentation here mention tableClass, which applies to <table>. There is also row-class. But how do I apply classes on the other elements?

You cannot do that. Vue-material is vue components, not html dom.


Can't download model

Can't download custom model via MODEL_LINK
i get:
FileNotFoundError                         Traceback (most recent call last)
 in <cell line: 132>()
174             model=f'/content/gdrive/{mainpth}/sd/'+nosd_name1+'-{blasphemy}/models/'+nosd_name2+'/{modelname}'
175          if not os.path.exists(model):
--> 176             gdown.download(url=MODEL_LINK, output=model, quiet=False, fuzzy=True)
177             clear_output()
178          else:
/usr/local/lib/python3.10/dist-packages/gdown/download.py in download(url, output, quiet, proxy, speed, use_cookies, verify, id, fuzzy, resume)
217                     "Please remove them except one to resume downloading.",
218                     file=sys.stderr,
--> 219                 )
220                 return
221             tmp_file = existing_tmp_files[0]
FileNotFoundError: [Errno 2] No such file or directory: '/content/gdrive/MyDrive/sd/stable-diffusion-{blasphemy}/models/Stable-diffusion'

did you run the cells before ? do a screenshot of the model cell

Yes, it was working initially, but after some update it was broken
I think it's the {blasphemy} variable

I'll check it out

It's the default

model=f'/content/gdrive/{mainpth}/sd/'+nosd_name1+'-{blasphemy}/models/'+nosd_name2+'/{modelname}'
this line was modified, you need to change the lora download cell accordingly


Add code comments

Codecov Report

Merging #157 (c616be6) into main (55ebf99) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           43        43
  Lines          848       848
  Branches       348       348
=========================================
  Hits           848       848

Impacted Files
Coverage Δ

...-tracker-backend/src/controllers/AuthController.ts
100.00% <ø> (ø)

...cker-backend/src/controllers/ResourceController.ts
100.00% <ø> (ø)

...ges/rating-tracker-backend/src/lib/accessRights.ts
100.00% <ø> (ø)

...ackages/rating-tracker-backend/src/lib/apiError.ts
100.00% <ø> (ø)

...es/rating-tracker-backend/src/lib/exampleStocks.ts
100.00% <ø> (ø)

...ages/rating-tracker-backend/src/models/resource.ts
100.00% <ø> (ø)

...kages/rating-tracker-backend/src/models/session.ts
100.00% <ø> (ø)

...s/rating-tracker-backend/src/openapi/components.ts
100.00% <ø> (ø)

...ckages/rating-tracker-backend/src/openapi/index.ts
100.00% <ø> (ø)

...ng-tracker-backend/src/openapi/parameters/fetch.ts
100.00% <ø> (ø)

... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[move-model] relocate model building logic fully to move model

Removed the build_move_model and the associated regex-matching logic
from move-prover to move-model. The regex-matching logic is also removed
in favor of using move_parse to find the dependencies.
NOTE: the first commit is the same as #8180, only the second commit needs to be reviewed.
Motivation
I'll be needing this as well for spec instrumentation.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI

@wrwg I run mvp -k diem-framework/modules/DiemTimestamp.move --dependency=diem-framework/modules --dependency=move-stdlib/modules and observed that Genesis_initialize is a standalone procedure in the output.bpl. Is this the expected behavior?
 // ** functions of module Genesis

 procedure {:timeLimit 40} $Genesis_initialize$verify(_$t0: int, _$t1: int, _$t2: Vec $Value, _$t3: Vec $Value, _$t4: Vec $Value,       _$t5: bool, _$t6: Vec $Value, _$t7: Vec $Value, _$t8: int) returns ()
 {
     // declare local variables
     var $t9: int; // $AddressType()
     ......
}

Rebased to main as its dependency is landed

/land

:broken_heart: Test Failed - ci-test-success

/land


bench_test: Prefer ResetTimer over stop/start

I believe is more conventional than pausing the existing timer after test setup.
https://golang.org/pkg/testing/#hdr-Benchmarks

Thanks!


Multiple windows

I'm a heavy user of multiple workspaces, and having multiple terminal windows in each workspace is a key part of my workflow.
On OS X, I tried the two most obvious things to create a second terminal window: Cmd+N and tearing off a tab. Neither worked.

thanks for reporting this.

Please fix this issue, that's one of the most annoying things I've come across with this beautiful terminal, the lack of option to open multiple windows.
For someone like me who heavily utilizes virtual desktops it's just counterproductive to be limited to a tabbed terminal in one desktop. On Mac I can separate and main iTerm2 instances into multiple desktops which is perfect for workflow.

Also it's worth mentioning that tmux already does an amazing job in terms of multiple windows management and there's in practice very little need of using a tab management system. Yet despite all of that, it would still be extremely nice to have a checkbox for turning off the tab management go and enable multiple instances.
I think the problem lies in with Electron which I read on a separate issues, apparently the second instance tries to reuse the same TMP files which leads to a crash. I haven't done any programming in Electron but I'd imagine it shouldn't be that difficult to fix it, i.e. enabling multi-instance.

Multiple instances is a must-have.

Honestly, I'm in the same boat. Having been an OSX user before getting this Windows laptop, I'm very used to having multiple virtual desktops. Being able to have only one Extraterm open at a time is so annoying that now I'm looking into other terminal emulators. idk if I'll be able to find anything else out that I like quite as much, but it does disrupt my workflow that much.
If this is as easy to fix as some people are saying, is there a chance someone entirely unfamiliar with Extraterm's source code (like myself) would be able to poke around and maybe fix it? Can't promise I'd be successful, but I wouldn't mind taking some time to try fixing this.

I was planning to work on improving the text rendering quality after the next big release (due shortly), but judging by the number of emojis stuck to this issue it looks like this one is more popular, so I'll pick this up next.

Released in v0.51.0.


UWP DataTriggerBehavior Not Firing

I have a DataTriggerBehavior bound to a ViewModel Property, that is declared in a Style.
I change the value of the Property, but the trigger never fires.
Here is a sample project.
https://1drv.ms/f/s!AraXP7LtRcVmneRxjkjTORd5HeQH_A
Any thoughts ?

The bindings on the DataTriggerBehavior on your sample are not correct, but I managed to make it work with this:
<core:DataTriggerBehavior
    Binding="{Binding FlashButton}"
    ComparisonCondition="Equal"
    Value="{Binding Name, RelativeSource={RelativeSource TemplatedParent}}">
    <core:GoToStateAction StateName="Flash" />
</core:DataTriggerBehavior>

Thank you so much.. fixed :)

Glad it worked, please feel free to close this issue then! :)


fix: DataCloneError when using FunctionTool

In #1026, CallbackManager.dispatchEvent was changed from using a spread operator to using structuredClone. This breaks with llm-tool-result events, since FunctionTool has an _fn property with the original function. structuredClone throws a DataCloneError since it cannot clone functions.
I'm not sure if there was more motivation behind using structruedClone, but I've added a test to reproduce the error with a simplified event, and changed dispatchEvent back to using a spread operator to perform a shallow clone of the event detail.

I'm not sure if there was more motivation behind using structruedClone, but I've added a test to reproduce the error with a simplified event, and changed dispatchEvent back to using a spread operator to perform a shallow clone of the event detail.

I was thinking event itself shouldn't have non-clonable data.


Support GPG signing of Commits

I am GPG signing my commits automatically and when I close the Sublime tab after writing my commit message the follow error pops up in the console
gpg: cannot open tty /dev/tty': Device not configured
error: gpg failed to sign the data
fatal: failed to write commit object`
It would be nice if the plugin could support GPG signing of commits commits.

I'm running into this problem also.  The issue seems to be the particular shell & runtime environment of the git and subsequently the spawned gpg or gpg2 (the exact program git runs is set via the config option: gpg.program.  Check yours with git config --global --get gpg.program).  It does appear that Sublime Text spawns git in a way which respects the commit.gpgsign option (git config --global --get commit.gpgsign should return true).
In a normal terminal, GPG_TTY is supposed to be set to the output of tty (e.g.: export GPG_TTY=$(tty)).
For setting this in my ~/.bashrc file, I've got:
  ## Set up GPG Agent for SSH keys & git commit signing
  export GPG_TTY=$(tty)
  if [ -f "${HOME}/.gnupg/gpg-agent-info" ]; then
    . "${HOME}/.gnupg/gpg-agent-info"
    export GPG_AGENT_INFO
    export SSH_AUTH_SOCK
    export SSH_AGENT_PID
  fi

After installing the Sublime Fix Mac Path plugin, and adding the path for gpg2 provided by GPGTools, it does spawn the gpg2 process correctly.  To do this, I added the following under Preferences => Settings - User:
	"additional_path_items":
	[
		"/usr/local/MacGPG2/bin",
		"~/bin"
	]

However, when committing through the plugin, the GPG_TTY is set to what appears to be the default: /dev/tty.  Really, we want to run gpg2 with --no-tty instead, and have pinentry-mac run to ask for GPG key passwords when needed.  This can be accomplished globally by doing the following:
Set pinentry-program in ~/.gnupg/gpg-agent.conf:
use-standard-socket
enable-ssh-support
pinentry-program /usr/local/MacGPG2/libexec/pinentry-mac.app/Contents/MacOS/pinentry-mac
default-cache-ttl 600
max-cache-ttl 7200
log-file /var/log/gpg-agent.log
write-env-file /Users/<YOUR_USER_HERE>/.gnupg/gpg-agent-info

Set no-tty in ~/.gnupg/gpg.conf:
# Passphrase agent
#
# We support the old experimental passphrase agent protocol as well as
# the new Assuan based one (currently available in the "newpg" package
# at ftp.gnupg.org/gcrypt/alpha/aegypten/).  To make use of the agent,
# you have to run an agent as daemon and use the option
#
# For Ubuntu we now use-agent by default to support more automatic
# use of GPG and S/MIME encryption by GUI programs.  Depending on the
# program, users may still have to manually decide to install gnupg-agent.

use-agent

# This disables ALL tty input / output globally!
no-tty

This works, but you won't see any confirmation or output at all whether your commits were signed (or if they failed to sign due to some error!).
The real solution is to set the GPG_TTY correctly for Sublime Text, or have the Sublime Text Git plugin either pass --no-tty to gpg2 or take over the I/O through popen or pty somehow.

This is still a problem. Is there a way to pass --no-tty to gpg2 yet?


Add OpenGLParametricSurface, Improve OpenGL play logic and Allow user to change OpenGL background color

Motivation

Config arguments for from_animation_number and upto_animation_number don't work with OpenGL. The OpenGL play logic doesn't support caching nor manim output format. Also, the OpenGL window background color is hard coded. Finally, ParametricSurface wasn't provided for OpenGL.
Overview / Explanation for Changes

OpenGL play logic has been improved to support caching and skipping with -n argument ( it is now similar to Cairo play logic). OpenGLParametricSurface was borrowed from 3b1b/manim repo and a random bug was fixed in OpenGLSurface. Finally, OpenGL background color can now be changed via background_color argument.
Testing Status

I tested all changes locally, and everything seems fine.
Acknowledgements

[ ] I have read the Contributing Guidelines
[ ] I have chosen a descriptive PR title (see top of PR template for examples)

Reviewer Checklist

[ ] Newly added functions/classes are either private or have a docstring
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings
[ ] The PR title is descriptive enough

Sorry, this includes changes from another PL. I will do another PL once the previous PL get merged


add after/plugin

The current setup requires nvim-cmp to be loaded, which complicates lazy-loading and dependency management. Ideally one could implement the same structure as in cmp-buffer, where the setup only sets config options while after/plugin registers the source. I am happy to open a PR to implement this.

After investigating further, it seems that using lazy.nvim and calling require('module') will load module into the runtime path, load dependencies and call their config functions, and then call the config for module. This means that module is available when its dependencies are being configured, which solves the circularity issue.

After investigating further, it seems that using lazy.nvim and calling require('module') will load module into the runtime path, load dependencies and call their config functions, and then call the config for module. This means that module is available when its dependencies are being configured, which solves the circularity issue.


feat: added support to specify a root element when using listbox elem…

This one fixes https://github.com/melt-ui/melt-ui/issues/1083
This adds a new param rootElement to all listbox elements, by default it will still be the document but it now supports a shadow dom root.
I also had to do some minor changes to the floating action to make it support shadow dom encapsulated elements.
I added an example for combobox but it should work on all listbox elements

@TGlide Had a chance to take a look? think we can merge this?


what is the password for RC4 encoding option? Is the password revealed in the code?

what is the password for RC4 encoding option? Is the password revealed in the code?

Anyone can help? Many thanks1

RC4 key is being used within decryption function in second parameter.

Closed, because of answer


Removing likes in the same way

Hi,
This is actually not an issue but an idea. I am wondering if we can achieve the same thing to remove likes using https://twitter.com/i/api/graphql/ZYKSe-w7KEslx3JhSIk5LA/UnfavoriteTweet api.
Best regards.

Hi,
I did a project like this before : https://github.com/Lyfhael/UnlikeAllTweets
Multiple issues if there are too many likes :

You may not see them anymore in your Likes tab, but they will appear for other
Everyone may not see them anymore and they will still reappear a few hours/days later

It seems like Twitter wants  to make it very hard for people  to remove them.
Sometime it works tho.

That does the job. Thank you so much!


[SuperEditor][SuperReader] - Make mouse/desktop overlay controls configurable through composition and use document layers

This ticket is the mouse/desktop version of https://github.com/superlistapp/super_editor/issues/1508. See that ticket for details, and replicate those, as appropriate, for Android in SuperEditor and SuperReader.

Closing this in favor of https://github.com/superlistapp/super_editor/issues/1608


Feature/job scheduling

@cecemel Made the changes you suggested + refactored the code like requested (I tried to make it the same pattern as the code that was already there)

Hi,
the logic got more complicated and specific than I anticipated, and I moved all the extension here to https://github.com/lblod/scheduled-job-controller-service. Hence, will close this PR. And favor https://github.com/lblod/scheduled-job-controller-service


Vix

removed the clean data code from the basic_processor because it's a duplicate. The cleaning steps are individual to each processor and should be / are done there.
made it possible to use download_data multiple times (for vix) uses append if self.dataframe is not empty.
changed some pandas operation to inplace
reimplemented / prepared the add_vix function.

Tested it with yahoo finance processor. There is a problem though:
The clean_data function removes the vix column again. Wanted to fix that, the code is pretty complicate though and it's probably better the original coder of it fixes it. Also the clean_data from yahoo finance  uses backward fill? This introduces lookahead. Should be addressed too.
# if close on start date is NaN, fill data with first valid close
            # and set volume to 0.

So this PR isn't ready and needs more work. The other processor needs to be tested. It provides a solid foundation for making the vix work again though. Hope it helps.

Thanks for your contributions!
I have some different thoughts about the first point, "removed the clean data code from the basic_processor because it's a duplicate. The cleaning steps are individual to each processor and should be / are done there." For now, We haven't unified all the data cleaning methods. So different processors may have different cleaning methods. We plan to unify these and remove data cleaning methods for each processor then. We will only use the cleaning method in the basic processor in the future.
For other points, they help a lot! Thanks very much. Could you please modify the part of the first point? We will merge this pull request then.

Thanks for your valuable codes.
I have several comments.

In finrl_meta/data_processors/processor_joinquant.py, fields=["time", "open", "high", "low", "close", "volume"], joinquant does not support the field “time”, which should not be revised. In clean_data, “date” will be changed to “time”.

finrl_meta/data_processors/processor_alpaca.py line 76， generally, if we executes download_data several times with different start-end dates using your codes, all these data will be stored in self.dataframe, except that we empty self.dataframe after each execution, which causes more labor. I think, it should not be revised.

But we need to be able to call it multiple times to get/add the vix.
response: generally, add vix is executed once. Therefore, this code should not be changed.


Fix bot not correctly tracking online/offline state of stream due to TwitchGame not being deserialized properly

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable
[x] Documentation in docs/ or install-docs/ was updated, if applicable
[x] I have tested all changes

Note, I have not tested this (yet) as I don't have a bot that's running a non-stable version atm given the Helix migration is a breaking change. If someone tests this and confirms it works as expected, feel free to note it here and we can go ahead and merge this in.

My idea for this situation:

A new branch v1.62-hotfixes that branches off stable/v1.62
Rebase this branch onto v1.62-hotfixes and merge it into v1.62-hotfixes
Then test the changes on that branch
Release v1.62.1 off that branch
Afterwards, merge v1.62-hotfixes into master
Downside: v1.62-hotfixes would have to stay around forever, unless somebody has a smart idea of avoiding the extra branch that would linger around forever

I ended up making a pre-helix-migration branch which v1.62 + changes up to the helix migration scopes were added to the log-in to test this and I can confirm it works. I think making a v1.62.1 release with v1.62 + helix migration scopes + this fix is worthwhile so I'll go ahead and do that

oh and yeah I don't think there's a proper way around leaving the branch, it'll just have to stick around which is fine

@RAnders00 Thoughts on updating the stable branch to v1.62.1? It will require a force push come v1.63 if we do that, which I don't personally have an issue with

:angry: I didn't follow the release instructions properly, I'm going to re-make the release

ok v1.62.1 is decently properly made now at least, I will use that for stable bots and start migrating some of my bots over to the main branch to give all helix features proper testing

@pajlada if you merge your new branch into stable then I don‘t see how it will require a force push when stable comes around? We will just have to make a merge commit then, and won‘t be able to fast-forward/just update the branch pointer


detect_buffers implementation broken for multi/exec

Hi,
I created redis client using options detect_buffers = true.
But if I invoke multi/exec operation on redis , the return type is not as expected.
For example i did in my code:
redis.multi()
multi.del('')
multi.expire(...)
multi.sadd(...)
multi.smembers(...)
multi.exec()
Earlier when I did not use detect_buffers the type of reply for last command was array but now it comes as string.

This is fixed in newer versions


Fix handling of standalone .cbor and tagged types

Fix #91
Currently this fails with the following error that I don't really understand
error[E0308]: mismatched types
   --> src/lib.rs:654:37
    |
654 |         deser_test(&CborInCbor::new(Foo::new(0, String::new(), vec![]), 9))
    |                     --------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `FooBytes`, found struct `Foo`
    |                     |
    |                     arguments to this function are incorrect
    |
note: associated function defined here
   --> src/lib.rs:63:12
    |
63  |     pub fn new(foo_bytes: FooBytes, uint_bytes: u64) -> Self {
    |            ^^^ -------------------  ---------------
help: try wrapping the expression in `FooBytes`
    |
654 |         deser_test(&CborInCbor::new(FooBytes(Foo::new(0, String::new(), vec![])), 9))
    |                                     +++++++++                                  +

The error it fails with is in one of the unit tests. It's treating the test that's:
foo_bytes = bytes .cbor foo

; since we don't generate code for definitions like the above (should we if no one refers to it?)
cbor_in_cbor = [foo_bytes, uint_bytes: bytes .cbor uint]

in the core unit test group (`t.
Before we considered that anywhere taking in foo_bytes should only care about that it's conceptually a Foo and not how it's encoded, we only took in a Foo in all parameters. I think this is a very worthwhile property to preserve. If that unit test is failing to compile that means we are now forcing it everywhere to be its own FooBytes wrapper type which is less usable. IMO we should only generate the wrapper struct if no one is referring to foo_bytes in the CDDL elsewhere, or have the behavior be a toggle with some comment flag to choose.

TODO: somebody needs to go through and check if this PR is still necessary (other than the commit that deletes unused code) given #117 was merged


Huge delay in the creation of persistent volumes with Rook

Describe the bug
PVC created with Rook takes about one hour to start provisioning a volume after its creation.
To Reproduce
Steps to reproduce the behavior:

Have a unformatted disk of at least 5GB attached to the master machine running CentOS
Install k3s with the installation script curl -sfL https://get.k3s.io | sh -
Wait for k3s to finish loading and check that all pods are running
Install Rook as specified here: https://rook.io/docs/rook/v0.9/ceph-quickstart.html using branch 0.9.3 in here https://github.com/rook/rook
Deploy a storage class found here https://github.com/rook/rook/blob/release-0.9/cluster/examples/kubernetes/ceph/storageclass.yaml
Deploy a sample mysql pod found in here: https://github.com/rook/rook/blob/release-0.9/cluster/examples/kubernetes/mysql.yaml. If the data disk has less than 20GB, modify the expected size in the yaml file to fit inside your disk.

Expected behavior
The PVC gets bound in seconds and the mysql pod starts running
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
The same example in a cluster created with kubeadm works as expected.

Experienced a similar behavior. For almost 60m, the pvc was not bound.

I am using rook-ceph 1.0.2 and it is working fine: https://github.com/danacr/kubernetes-the-fun-way/blob/master/docs/04-rook-ceph.md

Are you running CentOS? In Ubuntu sometimes works at first try, sometimes not.

I'm running Ubuntu, it doesn't attach on the first try, but within 1-2 minutes the PVC is there.

Didn't you guys have to specify the volume for the FlexVolume plugin directory?


Remove state from dep array of useStore's useEffect

I couldn't figure out any obvious reason for why state was added in the dep array of the useEffect used in useStore, since it's not used inside it.
I removed it and everything keeps working as before (i.e. unit tests pass, manual testing seems just fine).
Actually, things got a bit better since the useEffect does not run for every state update.
It only runs once: on mount.
Before
The useEffect runs 7 times (for each subscriber) for the initial mount and all state transitions of a single toast.
https://user-images.githubusercontent.com/58694408/193424820-45e2c76f-29a0-4015-9c2b-11ca3fd46fb7.mp4
After
The useEffect runs 1 time (for each subscriber) only for the initial mount.
https://user-images.githubusercontent.com/58694408/193424823-b100a935-33f9-4d22-a3e2-d341b4844bb7.mp4

@timolins If this is not going to be merged for some reason, should I close it then?


Currency formatting is wrong with RTL layout and dollar sign

Posting on behalf of mulligan:
When formatting currency values in RTL (Arabic), the formatted values are getting reordered in unexpected ways.
$ 100.50 (Arabic) is displayed as 100.50 $ (incorrect?)
SR 100.50 (Arabic, Saudi Riyals) is displayed as SR 100.50 (correct?)
$100.50 (Hebrew) is displayed as $100.50 (correct?)
$ 2.57 ألف (Arabic, $2.57K) is displayed as squiggle 2.57 $ (¯_(ツ)_/¯)
Note that we are using NumberFormat.compactFormatCurrency() which does generally localize numbers properly.
Adding textDirection: TextDirection.ltr, seems to generally fix things, but also seems like the wrong solution. It looks like maybe the standalone dollar sign symbol is getting treated specially and moved about in ways that regular letters aren't when the text direction is RTL?
Here is a simplified snippet of our code:
Blockquote
new Text(
new NumberFormat.compactSimpleCurrency(name: 'USD').format(257000))
)
Blockquote

As a native turkish speaker, I can also say that currency symbols being on the right feels more natural to us even though Turkish is a LTR language. Now I am used to it but when I first came here, it felt weird that in English you say: "Four dollars" but you write "$4".  We say "Dort turk lirasi" (Four turkish lira) and we write "4 TL".
This is true for foreign currency as well. Taken from Volkswagen turkish site with the price of Golf R listen in Euros and the euro symbol is on the right:

There needs to be a standard answer for each language.  Otherwise our charts end up displaying the formatted String one way, the Flutter text block ends up displaying it another way, and the UI looks inconsistent. Then people start filing bugs.
For reference, I believe the CDLR is what the Dart NumberFormat class ultimately relies on.
https://www.unicode.org/cldr/charts/latest/summary/ar.html#4217
(that doesn't necessarily mean it's always right, but at the very least that's where our formatted numbers are coming from)
FWIW the Hebrew version isn't giving us any trouble. (I think because in Hebrew, NumberFormat does not put a space between the $-sign and the amount, so the order doesn't get flipped)

This seems like a problem with intl: it's presumably assuming that the result is always in an LTR context. cc @alan-knight

(Assuming I'm right, that means that short-term the answer is probably to put TextDirection.ltr on the text span.)

This doesn't really specify very well what was done, but assuming that the locale is plain "ar", the code that's listed looks like
"$ 257 ألف"
in a web browser, and the same when run on a Mac command line, but displays with the dollar sign at the end when printing to an IntelliJ console. I think the Arabic part is the same, and just displayed at the front, but I may not be noticing subtle differences. I don't know enough to reproduce in Flutter. The runes it produces, in any setting, are (36, 160, 50, 53, 55, 160, 1571, 1604, 1601)
So Intl does not insert any BiDi markers in the text. The surrounding context might auto-detect it, and generally seems to in web browsers, but might not in others. It sounds like Flutter might not autodetect it at all, or might autodetect it for the letters, but that the space in between resets the direction, even for a non-breaking space?

Note that there are a number of useful Bidi-related methods in Intl which might be helpful. I really haven't used them in practice much, but https://github.com/dart-lang/intl/blob/1771fd26af88dd4b22c3c177fd8e86ad37fcc56e/lib/src/intl/bidi_formatter.dart#L130 might be useful if you want to automatically wrap a formatted number in RTL when it looks like it contains RTL text. Or https://github.com/dart-lang/intl/blob/1771fd26af88dd4b22c3c177fd8e86ad37fcc56e/lib/src/intl/bidi_utils.dart#L166 to check on a per-locale basis

The question is what is the context that that format assumes? Does it assume that that string will be rendered with the paragraph directionality set to RTL or LTR?

Since the data does not indicate, I would think the assumption is that it will be rendered according to the conventions of the thing that is displaying it. But I'm not a domain expert, and we're just trying to do the same thing as ICU/CLDR for numbers.
Does Flutter attempt to detect and render RTL strings appropriately?

You can't really "detect" RTL, you have to know ahead of time what the directionality is. We do support that (so if you're in an arabic localization, e.g., everything will be RTL).

So, in a web browser, the behavior appears to be as follows. In a RTL context.
Numbers with Arabic words after them are rendered RTL.
Numbers with a $ in front of them and no whitespace are rendered LTR.

Numbers with Latin characters plus $ in front of them and a non-breaking space (e.g. "US$ 1.23") are rendered LTR.
I don't know how this compares to Flutter behavior. It sounds consistent with what's described except for the last one. I don't know if "squiggle" is intended to mean that it rendered correctly RTL, or if it means that it was rendered RTL but the Arabic characters were garbled.
I tried out AdWords in an "ar" locale, to see what they're doing, and I noticed that in one place they had "$1.23", which renders LTR because they didn't format it to locale conventions, omitting the space. In most other places that had non-compacted currency amounts they wrote "US$ 1.23".
This does seem rather awkward to use. The information we produce is identical to ICU. It's not clear to me if there's a recommended way to use this in order to get the correct renderings. I also notice that in the Unicode chart above there is no space between the currency symbol and the number, which does not seem to be consistent with the data.

Flutter appears to behave more or less like the browser. When wrapped in
  new Directionality(textDirection: TextDirection.rtl

r'$ 3' renders LTR
r'$3' renders RTL
r'$ 3  ألف' renders RTL
So it may not be possible to detect orientation, but something seems to be trying. Since this is the same as the browser it may be a feature rather than a bug.

I've received confirmation that the CLDR is designed so that the formatting for RTL locales will work correctly when rendered with the right directionality for that locale. That means that what is described in the first comment is correct behaviour, and there's no bug here.
I'm going to close this issue. Please don't hesitate to file a new bug if you find another potential error in the localizing. Thanks!


[Feature Request]:  Integrating Email Sending Backend for contact Us form

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Integrate an email-sending backend to support the "Contact Us" form on the website. This feature will enable users to send messages directly through the website, automatically generating an email notification to the designated support or admin email address.
Use Case
For instance, a user who encounters an issue or has a suggestion can fill out the Contact Us form. Once submitted, the backend will generate an email and send it to the designated email account, ensuring that user inquiries or suggestions are promptly delivered to the team without requiring the user to leave the website.
Benefits

Enhanced User Engagement: Direct communication will encourage user feedback, which can be essential for future improvements.
Efficient Support: By routing inquiries directly to the support team, response times can be improved, resulting in a better user experience.
Centralized Communication: This integration will help manage user communications in a more organized way, ensuring that no queries are missed.

Priority
High
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a WOB contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

Gentle Reminder 🚨🚨
PA and Mentor nominations have been started for GSSoC-Ext 2k24. '
Do share your experiences and connect on Socials. '
It was a great experience working with you all
Thanks💗 for your valuable contributions!

Hi @AbhijitMotekar99 , i have assigned this task to you. Kindly complete within 3 days. Good luck!


Test updated cargo_toml behavior

cargo_toml 0.9.0 fixes an issue where the crate-type field wasn't
roundtripped correctly if the [lib] section was present in Cargo.toml,
meaning repackaged crates would no longer build. This change bumps
the dependency and adds a [lib] section to the trivial test crate,
which causes that test to fail without the fix.

Already released as 0.1.1 :)
Could you update this to just add the test instead? Also, I'm not sure I follow why this particular test actually tests the broken behavior?

Done. The old test didn't expose this behavior because cargo_toml doesn't emit a lib section at all if the source manifest doesn't have one (the lib field is Option<_>). Adding the (empty) lib section triggers the parser for it, which previously wasn't faithfully round-tripping.


Update release steps

Update the release steps to explain how CI/CD handles the documentation. Resolves #127.

@tomvothecoder This is ready for review. Just a simple change to the documentation release steps.
Unlike https://github.com/E3SM-Project/e3sm_diags/pull/420, it doesn't change the Anaconda release steps. That can be done as part of #131, when automated Anaconda publishing is implemented.

While CI/CD does build docs from pull requests now, it currently doesn't build docs from a new release. The changes in this PR will go in as part of #131 instead.


Designing the game board

Adding graphic models to the game board, making it livelier. Also, adding conditions in index.js to change rotated snake head div. And finally, I translated some Hindi comments into English.

@vntortoise724 you have done amazing work


Add Trilinos build script

It'd be worthwhile to include a build script for a non-trivial code in the documentation as another real-world example.  Trilinos would be worthwhile, because building Trilinos was what originally motivated the automation framework that eventually begat staged-script.  The Trilinos CI testing is primarily driven by PullRequestLinuxDriverTest.py, so we'd have to see if it's possible to mimic what's being done there, without access to Trilinos' machines, environments, etc.

I'm afraid PullRequestLinuxDriverTest.py is more of a complicated mess than when I last saw it ~4 years ago, so it would take quite some time to translate into a "one build script to rule them all".  I asked if there was a straightforward way to reproduce CI testing failures locally, and was pointed to these instructions, though I'm not sure that helps much.


revisit issue #1344

Fix

to handle minApproval undefined
added test case

@AnthonyLaw should we close that one?


What percent of scholarly publication DOIs are registered with Crossref?

Let's use this issue to jot down notes related to what percent of scholarly publication DOIs are registered with Crossref.
As a refresher, there are many DOI Registration Agencies (RA). For example, EIDR is a DOI RA for entertainment, so you can actually get DOI metadata for some porns! There is even discussion regarding DOIs for construction products. Shoutout to  @jenniferlin15 who helped me understand these intricacies of the DOI system.
For our analyses, we're most interested in DOIs for scholarly content. There are other RAs than Crossref that engage with scholarly content. Some examples are:

mEDRA which "provides DOI registration services to publishers, academic institutions, research centres and intermediaries in Italy, in the EU market and internationally."
DataCite which "provides persistent identifiers (DOIs) for research data."

We're mostly interested in cataloging all DOIs for scholarly publications in relation to our Sci-Hub coverage project.

DOI Links on Wikipedia
The 2016 study, "DOI Links on Wikipedia", provides the following discussion of the DOI RA breakdown:

A prefix is assigned to a particular DOI registrant, such as publishing companies or academic societies. DOI registrants assign suffixes to their contents and register DOIs through DOI Registration Agencies (RAs). There are 10 RAs.

Some RAs that handle scholarly resources (such as journal articles, books, and datasets) are CrossRef, JaLC, ISTIC, and DataCite. JaLC is the only RA in Japan, ISTIC is a Chinese RA, and DataCite is an RA for research data. As of April 2016, there are 76,944,396 DOIs registered by CrossRef (CrossRef DOIs); 23,422,068 DOIs by ISTIC (ISTIC DOIs); 6,614,478 DOIs by DataCite (DataCite DOIs); and 1,401,144 DOIs by JaLC (JaLC DOIs).

Table 2 of this study shows the breakdown of RAs for DOI links on Wikipedia as of March 2015. This Table is reproduced below:

RA
enwiki
jawiki
zhwiki

AIRITI
2
0
0

CrossRef
1,463,052
27,900
36,202

DataCite
464
13
6

ISTIC
101
0
44

JaLC
9
549
0

mEDRA
647
5
9

OPOCE
176
2
3

Public
367
6
25

Error
9,412
324
380

Total
1,474,230
28,799
36,669

enwiki stands for the English Wikipedia; jawiki stands for the Japanese Wikipedia; zhwiki stands for the Chinese Wikipedia. The authors summarize:

Table 2 shows the number of total DOI links for RAs. Most of DOI links in these Wikipedia are CrossRef DOIs. The second most-referenced DOI links in enwiki are mEDRA DOIs; those in jawiki are JaLC DOIs; those in zhwiki are ISTIC DOIs. Note that JaLC DOIs are not referenced in zhwiki, and ISTIC DOIs are not referenced in jawiki. In other words, the scholarly content in Japan tends to be referenced in jawiki, the content in China tends to be referenced in zhwiki.

From this table, we can compute the percent of all DOI links on wikipedia that are for Crossref registered DOIs:

English Wikipedia: 99.87944% = 1463052 / (1474230 - 9412)
Japanese Wikipedia: 97.98068% = 27900 / (28799 - 324)
Chinese Wikipedia: 99.76026% = 36202 / (36669 - 380)

Therefore, it's clear that for DOIs that are actually referenced, they overwhelming were registered with Crossref. There is a small language effect with links in the Japanese Wikipedia using other registrars than Crossref about 2% of the time.

From the 2014 article CrossRef developments and initiatives:

Not all of these DOIs will have been issued through CrossRef and other agencies like DataCite, mEDRA, Movie Labs and CNKI can assign DOIs to content as well. Geoffrey Bilder’s recent blog-post ‘DOIs unambiguously and persistently identify published, trustworthy, citable online scholarly literature. Right?’ is an interesting expansion on this point and is useful to bear in mind that not all DOIs are CrossRef DOIs.

In @gbilder's referenced blog post, there's a nice visualization defining scope overlap between the RAs

The RAs in the top right corner are the relevant ones for scholarly content.

From the FAQ page at doi.org on June 16, 2017:

How many DOI names are there, and who uses them?

Approximately 133 million DOIs have been assigned through a federation of Registration Agencies world-wide with an annual growth rate of 16%. See the factsheet DOI Key Facts and the DOI Handbook, 2 Numbering.

At this time, the Crossref API reports 89 million DOIs. Specifically https://api.crossref.org/works?rows=1 returns "total-results":89216081. Although these numbers are likely not from the exact same point in time, we can estimate that 66.9% = 89 / 133 of DOIs are registered by Crossref.

I found the above statistic handy.
I just polled the Crossref API again today, and got 99,085,806 DOIs.  Approximately 13 months have transpired since 89 million was cited, so we can surmise that Crossref is issuing 12/13 = x/11000000 or approx 9.3M DOIs per year.


Fix chart image rendering in PhantomJS

Google's JS is now using ES6 flavoured code which PhantomJS's ancient JS engine can't handle. This means that attempting to render chart images dies with:
ReferenceError: Can't find variable: Map

  https://www.googletagmanager.com/gtag/js?id=G-9DPND0VYSC&cx=c&_slc=1:141

This was the quickest way I could think of the make the problem go away.

Yeah, tell me about it!
I guess at some point we'll replace with it with Playwright, but not about to do that now.


Setup codacy rules and fix issues

Using remarkjs to lint Markdown

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 6
- Added 2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 32
- Added 8

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 33
- Added 7

See the complete overview on Codacy

Let's merge it to master to see if Codacy will detect the settings file.


Re-enable lwaftr CSV stats

After the multiprocess merge, this facility needed some adaptation to
keep on working.

LGTM once tests pass, assuming you've manually tested that it gives the expected output. The concept looks right.

LGTM


[BUG]: Cant input 4digit CVV with full-wide input mode

What happened?
We use Stripe Elements on our website.
We have observed strange behavior in the input of AMEX 4digits CVVs, which depends on the input mode of the PC.
When entering 4digits CVVs in the "double-byte input mode" used for Japanese input, etc., the last digit cannot be entered.

In the normal input mode (half-width input mode), 4 digits can be input.
Even in full-width input mode, up to 3 digits can be entered, and they are automatically replaced with half-width digits.

This behavior is also confirmed by the following Web site.
https://stripe.com/docs/payments/payment-element
Environment
No response
Reproduction
No response

I tested too, and this problem is occurred.
1234 → no problem
１２３４ → "１２３" is transformed to "123". But 4 can't input.

This is active issue.

Hi @mikakane and @rdlabo, we've just pushed out a fix for this! Going to close out this issue, but please feel free to re-open if you find further issues relating to this.


solar_optimizer Not Loaded

Version of the custom_component

1.7

Configuration

>> I don't know how to access this..

Add your logs here.

Describe the bug
A clear and concise description of what the bug is.

I don't think this is a bug, but I have done my best to follow the instructions but I cannot get the Solar Optimiser to load.

I have attached logs, and screen shots as your instructions.

I have created input helpers and put value in there... deleted and reset again.

Can you help me understand what is missing or broken ?

very much appreciated.

Debug log

Add your logs here.
![image](https://github.com/user-attachments/assets/27f60fa2-4030-490c-b4c6-650efa956795)
![image](https://github.com/user-attachments/assets/b8bf0a89-928d-4a87-b535-354fc354aa4f)
![image](https://github.com/user-attachments/assets/f1ee66cc-a41e-4ff2-9718-a6bf427e2902)

home-assistant_2024-08-17T23-40-05.803Z.log

Looks like i needed to add the config file and detail all the devices. I expected this to be GUI.

It would be great if there was a GUI to add devices and select the action. the yaml is beyond my expertise.

Yes ! I have that in mind but no time yet.


CORE-9973 SessionManager now prioritises sending SessionInit events if they exist in undelivered queue

This PR addresses CORE-9973.
Context:
QA were seeing issues while testing where active flows would return the error "Failed to receive due to sessions with terminated statuses: [...]". It was determined that the root cause of this was messages arriving out-of-order – specifically, the flow mapper was in some cases receiving data messages before SessionInit (as these are currently sent simultaneously). While out-of-order messaging is handled in the session layer, the flow mapper does not have such logic.
Fix:
To prevent this from happening, a race condition was added to SessionManager::getMessagesToSendAndUpdateSendState() which prioritised the sending of SessionInit messages if any existed in the undelivered queue. This prevents data messages from being sent until the SessionInit has been acknowledged by the counterparty.

build timed out on last run. https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda-runtime-os-e2e-tests/detail/PR-3577/12/pipeline
We should investigate why before merging even if a subsequent build makes it through. just in case weve introduced some of the slowness we saw in a previous iteration of this pr

build timed out on last run. https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda-runtime-os-e2e-tests/detail/PR-3577/12/pipeline
We should investigate why before merging even if a subsequent build makes it through. just in case weve introduced some of the slowness we saw in a previous iteration of this pr

I isolated the issue to some of the refactoring work I did; turns out creating a copy of the undeliveredMessages list and passing that around rather than referencing the original in the SessionState caused some strangeness with nullability deeper in the code. The simple workaround is to work from the list in the SessionState.


Sometimes, video files encode at unneccessarily high bitrate

Example capture, encoded at average 1426 kb/s:
Kapture 2016-10-10 at 13.01.36.mp4.zip
Running this through ffmpeg -i Kapture\ 2016-10-10\ at\ 13.01.36.mp4 -vcodec h264 -strict -2 output.mp4 results in a bitrate of ~204kb/s.
Might just be because of the video type (mostly static with 1 small motion region).

Thanks for the report, @nateberkopec! This is happening because aperture.js records an uncompressed movie.
We had a compression option in an early version, but we decided to disable it at some point to focus on other things first.
I'm currently working on #14 for v0.3.0 and I think we could have the compression option back in v0.3.0 😄

Related to #117

Closing this as I t doesn’t really make sense to capture the MP4 source file at a lower bitrate.


Typo fix in gogs/README.md

a small typo in gogs/README.md line 41
there are many such typos in the directory /incubator

/assign @lachie83

/retest