Acceptance tests for CentOS 7 , remove RHEL6

Pull Request (PR) description

Add CentOS 7 to metadata.json hoping that will trigger acceptance tests.
  With several of my modules I've had to hack things to force the daemon run as root in something that runs in a before(:suite) kind of thing.

This is what I had to do for one of my modules:
https://github.com/treydock/puppet-munge/blob/5a801f82f162450927d08a11b05014d325a0a8a4/spec/spec_helper_acceptance_setup.rb#L2-L11
It's really ugly but it works to avoid this issue.

hey @treydock,
we've  a workaround for the cgroups  issue:
https://github.com/voxpupuli/puppet-proxysql/blob/master/.sync.yml#L2-L3 which adds https://github.com/voxpupuli/puppet-proxysql/blob/master/.github/workflows/ci.yml#L29 which pulls in an older centos image: https://github.com/voxpupuli/puppet_metadata/blob/master/lib/puppet_metadata/beaker.rb#L40

@bastelfreak Thanks for the pointers, I made the necessary adjustments but still seeing failures.  Not quite sure why things still failed, I see that beaker setfile was correct:
BEAKER_setfile: centos7-64{hostname=centos7-64.example.com,image=centos:7.6.1810}

The generated Dockerfile also used this specific version.

meh. We sometimes see strange systemd failures on docker containers, I've no clue what's the correct workaround here :(

@bastelfreak I think I fixed the issues.  The only way I could get this to work was force slapd on CentOS to run as root which required a few systemd hacks.  It's extremely ugly but it's something I've had to do for other modules like ones using MongoDB for example.

@smortex I squashed the commits down.
Enabling CentOS/RHEL 8 isn't possible without significant changes.  RHEL8 dropped openldap-servers packages so all they provide is openldap client packages. I tried to get EPEL to approve packaging just the openldap-servers packages but was denied since upstream RHEL provides conflicting client packages.  To enable CentOS 8 / RHEL 8 support will require a new PR that is much more involved that pulls the openldap packages from non-OS and non-EPEL repos.  There are a few sources that were mentioned to me in my EPEL request so can try those out.


fix thread sanitizer errors

This PR fixes thread sanitizer data race errors detected in module
WSConnectionUpgradeFactory and test modules TestWebSocketService,
KituraTest.

Fixes #43


fix devpack:test task

Port missing spec execution from bill's kitchen (inlined in Rakefile).
Adjust helper.build_dir to point to .\out\pkg.

LGTM, but didn't test it (on a Mac now ;-))
@damphyr @pyranja we should probably get the appveyor CI build up and running for z-devpack, what do you think?

@pyranja and thanks for the contribution, that should read! :)

I've ported the a stripped down devpack to Powershell (https://github.com/pyranja/devpack), including a working appveyor build.

@pyranja I have no clue about powershell, but that looks definitely nice! Totally like the modular structure, with the partials and each module bringing its own set of tests. Really sweet. :)

Tempted to plus one it but I will hold off and let it run through the Vaagrant/VirtBox setup I used to do the initial development on.
Also : Dude that powershell version is nifty 😉

Tempted to plus one it but I will hold off and let it run through the Vaagrant/VirtBox setup I used to do the initial development on.
Also : Dude that powershell version is nifty 😉


Merge new Memory Stream implementation

There are considerable number of changes in this request.  Some reorganization of code is also there, and there were some conflicts, including some when merging with Bruno's latest changes.  If you see any issues, please let me know.  I have several things which I will look at, but wanted to merge, otherwise there is a lot of effort in continuing to have to merge large number of changes.

I have still to move the array serialization used for the sort benchmark to custom serialization
I will modify StreamBase and its derivatives to implement IDisposable instead of ref counting and use replication instead of assignment (overlap with Jin's current work likely)
The refactoring overlaps with Bruno's refactoring of MemStream, may need second look.
For some reason, using our threadpool for networking code causes UT hangs on Azure VM.  Using system threadpool works fine - so I changed networking code to use system threadpool.  This is likely due to some remaining bugs in threadpool which need to be fixed.  It is only a two line change to switch back.

This pull requests brings in many commits that will go into master's commit history. Some of them are probably not in working condition.  Could you please consider squash the commits into one or a few meaningful ones for the commit history?

Phew! I'm done. I'll update my generic serialization to use this new code once it goes in. In general, there should be no reason for anyone to write a "custom" encoder/decoder for arrays/matrices unless they know something special about their data (e.g.: image, sound, etc). We could enable general gzip/lzw encoding/decoding as an option, which would go a long way for text. If we also add something lossless for System.Drawing.Bitmap and whatever the .Net PCM waveform object is, we should be in good shape for many workloads with quite good performance.


Is it ethical to close the tab in the web browser?

I really like the worm simulator, but I'm worried about the potential ethical impact of closing the browser tab.
Somewhat related, a feature to save the state of your worm might be nice so that you can transfer the worm between computers, or restore your worm to an earlier point if you're disappointed with it

Given the worm is eternally kept in a constant state of hunger, I feel a blow of mercy by closing the tab could even be considered ethically preferred.
Given the worm is released under MIT, anyone is able to spin up thousands of worm brain instances and set up a script to torture / kill them again and again. For example removing food in front of the worm as it is about to consume it, making it a Sisyphean task. This would be the ethically problematic part.

lmaooo this is the funniest github comment ever. somebody scared about the feelings of a virtual worm (they dont have feelings. they have like 300 neurons ur gonna be ok 💀)

Not sure if this is serious, but as the poster above has stated, the worm only has 302 neurons. If consciousness derives from the integration of information, than it is extremely unlikely that the worm has an inner life.
Still, this raises the question of at what point simulations of this sort become unethical, which I don't have an answer to.

bro that’s hell of an issue, it’s a simulation, not a real living worm

I suggest storing the state of the worm in localStorage as a workaround for this issue.


NVidia NSight profiling

I have a question*
Is there any way to collect data with NVidia NSight while using OpenGLFX?

As I remember, NSight can only connect to DirectX and Vulkan

I have never used it before, but was given the advice, relative to working with OpenGL, that it can automatically give me performance profiling and comparison of multiple runs of the code. NSight does appear to have information collection for OpenGL looking at its front page

I'll see how it can be used soon

Thank you!

Unfortunately, Nsight can only capture windows with a single rendering (created through glfw, for example).
And since openglfx renders everything inside "offscreen" buffer and then glues the result to javaFX, this makes it impossible to catch.

Alternatively, you can use RenderDoc - it has support for such buffers.
Look at the readme to enable it in openglfx.

Theoretically it is possible to create a "debug" mode, in which openglfx rendering will occur in a separate window. This will make it possible to use NSight

Thank you!

Are there any plans for this?

Yes, progress is slow, but work is underway

I have rendered openglfx content into a separate window after showing in the canvas, and now RenderDoc and NSight see the application and let see details.
GLCanvas will have externalWindow field in constructor.

That's awesome!

Added in release 4.1.0. Check README.md for more information.

Thanks for all these updates!


Feedback: automatically exclude contents of .gitignore files from deployment

from: https://positpbc.slack.com/archives/C06B0UZKT34/p1722397072282259
Another feedback item, I think the publisher should automatically exclude files and directories that are in my .gitignore. By accident I included a .cache directory in my deployment that had a lot of data in it!

This is an interesting one, as initial feedback from others identified the opposite need (to not have the files git ignored excluded from the deployment).

I could see users wanting both - only publishing built things not in tracked by the repo, or only wanting to publish necessary files and not files listed in the gitignore.
I'm unsure if we can do this without harming one flow or the other.

This could be a sign that our auto-include of every file with * is too large as a start.
Some other options:

Have users select the files they want

Would be another step in creation

Include known files

Would have to scan for imports to include required modules, or files like CSVs

A configuration option to list ignore files (like gitignores)

Much more complicated

We have to remember that the entrypoint button deploys right away so if we don't prompt the user they will create a deployment right away with the files we select - without prompt.

I have a few thoughts:

My initial reaction is I think excluding the contents from .gitignore is a reasonable default.

.gitignore is often used to exclude secretes from being published to get (e.g. .env) files. We also don't want users publishing secretes to Connect or Connect cloud.
.gitignore is often used to exclude data. For example temporary artifacts that are generated as part of as script, like in my use case a cache.

I think the default of '*' is too aggressive, and not what most users would want.
If .gitignore is too aggressive, here are some ideas for more conservative defaults.

files = ['*.py', '*.ipynb', '*.qmd', '*.R', '*.Rmd', 'requirements.txt', 'pyproject.toml']

We're switching to only bundling specified files (not using the * wildcard) in #2068, so we don't need to layer gitignore exclusions on top of that.


Add the possibility to create Github components

check workload preflight-green

check workload preflight-green

The change is ready for review, here is the component created by the job.

check workload preflight-green


Recursive Link loop

Bug description
If you are to create a Link field on Entry A that links to Entry B, then on Entry B make a link to Entry A, you get either a never ending save, or a timeout error.
Just to double check this bug I tried replicating this on Statamic core, and it does not seem to be an issue there. We believe it to be an issue only with The Eloquent driver package.
How to reproduce
Create a Link field on Entry A that links to Entry B, then on Entry B make a link to Entry A
Logs
No response
Environment
Environment
Application Name: _
Laravel Version: 10.48.9
PHP Version: 8.3.6
Composer Version: 2.2.22
Environment: local
Debug Mode: ENABLED
URL: _
Maintenance Mode: OFF

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Cache: file
Database: mysql
Logs: stack / single
Mail: smtp
Queue: database
Session: file

Statamic
Addons: 2
Sites: 1
Stache Watcher: Enabled
Static Caching: Disabled
Version: 5.12.0 Solo

Statamic Addons
jacksleight/statamic-bard-texstyle: 3.2.2
statamic/eloquent-driver: 4.8.1

Statamic Eloquent Driver
Asset Containers: eloquent
Assets: eloquent
Blueprints: file
Collection Trees: eloquent
Collections: eloquent
Entries: eloquent
Forms: file
Global Sets: eloquent
Global Variables: eloquent
Navigation Trees: eloquent
Navigations: eloquent
Revisions: eloquent
Taxonomies: eloquent
Terms: eloquent
Tokens: file

Additional details
We are using Lando as a way to run our project, which is a wrapper of docker compose:
name: _
recipe: laravel
services:
database:
portforward: 3306
appserver:
build_as_root:
- a2enmod expires headers
mailhog:
type: mailhog
hogfrom:
- appserver
proxy:
mailhog:
- mail.lndo.site
config:
php: '8.3'
webroot: public
database: mysql:8.0
xdebug: true

I can't seem to reproduce this issue on the latest versions of Statamic and the Eloquent Driver. 🤔
Are you able to try updating Statamic and the Eloquent Driver in your project. They both seem to be running slightly older versions.
If that doesn't help, are you able to share the YAML for the blueprint(s) in question?

I can't seem to reproduce this issue on the latest versions of Statamic and the Eloquent Driver. 🤔
Are you able to try updating Statamic and the Eloquent Driver in your project. They both seem to be running slightly older versions.
If that doesn't help, are you able to share the YAML for the blueprint(s) in question?

Hey @duncanmcclean, I'm not sure if it is blueprint related as we managed to replicate it on another one of our projects as well as fresh Statamic Pages. I will try update the Statamic and Eloquent Version and get back to you on how that turns out

`Environment
Application Name: _
Laravel Version: 10.48.9
PHP Version: 8.3.6
Composer Version: 2.2.22
Environment: local
Debug Mode: ENABLED
URL: _
Maintenance Mode: OFF
Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED
Drivers
Cache: file
Database: mysql
Logs: stack / single
Mail: smtp
Queue: database
Session: file
Statamic
Addons: 2
Sites: 1
Stache Watcher: Enabled
Static Caching: Disabled
Version: 5.20.0 Solo
Statamic Addons
jacksleight/statamic-bard-texstyle: 3.2.2
statamic/eloquent-driver: 4.14.1
Statamic Eloquent Driver
Asset Containers: eloquent
Assets: eloquent
Blueprints: file
Collection Trees: eloquent
Collections: eloquent
Entries: eloquent
Forms: file
Global Sets: eloquent
Global Variables: eloquent
Navigation Trees: eloquent
Navigations: eloquent
Revisions: eloquent
Sites: file
Taxonomies: eloquent
Terms: eloquent
Tokens: file
`
Updated Both Statamic and the Eloquent Driver but atleast now I got an error message that you can see in the Image.
Page Blueprint
title: Page tabs:   main:     display: Main     sections:       -         display: Main         fields:           -             handle: title             field:               type: text               required: true               validate:                 - required           -             import: main_section       -         display: Content         fields:           -             import: content_blocks   sidebar:     display: Sidebar     sections:       -         fields:           -             handle: slug             field:               type: slug               localizable: true               validate: 'max:200'           -             handle: parent             field:               type: entries               collections:                 - pages               max_items: 1               listable: false               localizable: true           -             handle: template             field:               type: template               display: Template
Main section fieldset (where I added the Link From Page A to B and vice versa)
`title: 'Main Section'
fields:
handle: navigation_label
field:
  type: text
  display: 'Navigation Label'

handle: image_field
field:
container: images
type: assets
display: 'Image field'
max_files: 1
handle: video_field_duplicate
field:
container: videos
type: assets
display: 'video field'
max_files: 1
handle: background_media
field:
options:
image: Image
video: Video
type: radio
display: 'Background Media'
instructions: 'Which header background do you want to display?'
cast_booleans: true
default: image
import: button
handle: options
field:
options:
full_screen: 'Full screen background media'
type: checkboxes
display: Options
`

@duncanmcclean could you provide a git repo of a working sample. We will attempt to reproduce the bug in isolation there.
Here is the stack trace of the issue I sent a screenshot of in my last message. It continues to loop but we have truncated it
[2024-09-10 04:59:55] local.ERROR: Maximum call stack size of 8339456 bytes (zend.max_allowed_stack_size - zend.reserved_stack_size) reached. Infinite recursion? {"userId":1,"exception":"[object] (Error(code: 0): Maximum call stack size of 8339456 bytes (zend.max_allowed_stack_size - zend.reserved_stack_size) reached. Infinite recursion? at /app/vendor/laravel/framework/src/Illuminate/Collections/Arr.php:20)
[stacktrace]
#0 /app/vendor/laravel/framework/src/Illuminate/Collections/Arr.php(328): Illuminate\\Support\\Arr::accessible(Array)
#1 /app/vendor/laravel/framework/src/Illuminate/Collections/Arr.php(666): Illuminate\\Support\\Arr::get(Array, 0, NULL)
#2 /app/vendor/laravel/framework/src/Illuminate/Routing/RouteUrlGenerator.php(204): Illuminate\\Support\\Arr::pull(Array, 0)
#3 [internal function]: Illuminate\\Routing\\RouteUrlGenerator->Illuminate\\Routing\\{closure}(Array)
#4 /app/vendor/laravel/framework/src/Illuminate/Routing/RouteUrlGenerator.php(198): preg_replace_callback('/\\\\{.*?\\\\}/', Object(Closure), 'cp/collections/...')
#5 /app/vendor/laravel/framework/src/Illuminate/Routing/RouteUrlGenerator.php(85): Illuminate\\Routing\\RouteUrlGenerator->replaceRouteParameters('cp/collections/...', Array)
#6 /app/vendor/laravel/framework/src/Illuminate/Routing/UrlGenerator.php(500): Illuminate\\Routing\\RouteUrlGenerator->to(Object(Illuminate\\Routing\\Route), Array, true)
#7 /app/vendor/laravel/framework/src/Illuminate/Routing/UrlGenerator.php(469): Illuminate\\Routing\\UrlGenerator->toRoute(Object(Illuminate\\Routing\\Route), Array, true)
#8 /app/vendor/laravel/framework/src/Illuminate/Foundation/helpers.php(811): Illuminate\\Routing\\UrlGenerator->route('statamic.cp.col...', Array, true)
#9 /app/vendor/statamic/cms/src/Statamic.php(196): route('statamic.cp.col...', Array)
#10 /app/vendor/statamic/cms/src/helpers.php(9): Statamic\\Statamic::cpRoute('collections.ent...', Array)
#11 /app/vendor/statamic/cms/src/Entries/Entry.php(333): cp_route('collections.ent...', Array)
#12 /app/vendor/statamic/cms/src/Entries/Entry.php(287): Statamic\\Entries\\Entry->cpUrl('collections.ent...')
#13 /app/vendor/statamic/cms/src/Data/AbstractAugmented.php(141): Statamic\\Entries\\Entry->editUrl()
#14 /app/vendor/statamic/cms/src/Fields/Value.php(56): Statamic\\Data\\AbstractAugmented->Statamic\\Data\\{closure}(Object(Statamic\\Fields\\Value))
#15 /app/vendor/statamic/cms/src/Data/AbstractAugmented.php(78): Statamic\\Fields\\Value->resolve()
#16 /app/vendor/statamic/cms/src/Data/AbstractAugmented.php(52): Statamic\\Data\\AbstractAugmented->get('edit_url')
#17 /app/vendor/statamic/cms/src/Fields/Value.php(56): Statamic\\Data\\AbstractAugmented->Statamic\\Data\\{closure}(Object(Statamic\\Fields\\Value))
#18 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(53): Statamic\\Fields\\Value->resolve()
#19 [internal function]: Statamic\\Data\\AugmentedCollection->Statamic\\Data\\{closure}(Object(Statamic\\Fields\\Value), 'edit_url')
#20 /app/vendor/laravel/framework/src/Illuminate/Collections/Arr.php(600): array_map(Object(Closure), Array, Array)
#21 /app/vendor/laravel/framework/src/Illuminate/Collections/Collection.php(777): Illuminate\\Support\\Arr::map(Array, Object(Closure))
#22 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(53): Illuminate\\Support\\Collection->map(Object(Closure))
#23 /app/vendor/statamic/cms/src/Data/HasAugmentedInstance.php(35): Statamic\\Data\\AugmentedCollection->all()
#24 /app/vendor/statamic/cms/src/Fieldtypes/Link/ArrayableLink.php(17): Statamic\\Entries\\Entry->toAugmentedArray()
#25 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(87): Statamic\\Fieldtypes\\Link\\ArrayableLink->toArray()
#26 [internal function]: Statamic\\Data\\AugmentedCollection->Statamic\\Data\\{closure}(Object(Statamic\\Fieldtypes\\Link\\ArrayableLink), 'link_field')
#27 /app/vendor/laravel/framework/src/Illuminate/Collections/Arr.php(600): array_map(Object(Closure), Array, Array)
#28 /app/vendor/laravel/framework/src/Illuminate/Collections/Collection.php(777): Illuminate\\Support\\Arr::map(Array, Object(Closure))
#29 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(64): Illuminate\\Support\\Collection->map(Object(Closure))
#30 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(90): Statamic\\Data\\AugmentedCollection->toArray()
#31 [internal function]: Statamic\\Data\\AugmentedCollection->Statamic\\Data\\{closure}(Array, 'link_field')
#32 /app/vendor/laravel/framework/src/Illuminate/Collections/Arr.php(600): array_map(Object(Closure), Array, Array)
#33 /app/vendor/laravel/framework/src/Illuminate/Collections/Collection.php(777): Illuminate\\Support\\Arr::map(Array, Object(Closure))
#34 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(64): Illuminate\\Support\\Collection->map(Object(Closure))
#35 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(90): Statamic\\Data\\AugmentedCollection->toArray()
#36 [internal function]: Statamic\\Data\\AugmentedCollection->Statamic\\Data\\{closure}(Array, 'link_field')
#37 /app/vendor/laravel/framework/src/Illuminate/Collections/Arr.php(600): array_map(Object(Closure), Array, Array)
#38 /app/vendor/laravel/framework/src/Illuminate/Collections/Collection.php(777): Illuminate\\Support\\Arr::map(Array, Object(Closure))
#39 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(64): Illuminate\\Support\\Collection->map(Object(Closure))
#40 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(90): Statamic\\Data\\AugmentedCollection->toArray()
#41 [internal function]: Statamic\\Data\\AugmentedCollection->Statamic\\Data\\{closure}(Array, 'link_field')
#42 /app/vendor/laravel/framework/src/Illuminate/Collections/Arr.php(600): array_map(Object(Closure), Array, Array)
#43 /app/vendor/laravel/framework/src/Illuminate/Collections/Collection.php(777): Illuminate\\Support\\Arr::map(Array, Object(Closure))
#44 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(64): Illuminate\\Support\\Collection->map(Object(Closure))
#45 /app/vendor/statamic/cms/src/Data/AugmentedCollection.php(90): Statamic\\Data\\AugmentedCollection->toArray()
#46 [internal function]: Statamic\\Data\\AugmentedCollection->Statamic\\Data\\{closure}(Array, 'link_field')```

@duncanmcclean Turns out this issue occurs only when Telescope is installed

@duncanmcclean I will close this issue now and I have added this to Statamic Core: https://github.com/statamic/cms/issues/10782


Selecting a muscle in Navigator draws large box in Visualizer Window and does not update label below Properties panel

Steps to reproduce

open Gait10dof18musc\subject01.osim
in Navigator, expand walk_subject01 > Forces > Muscles
double-click "tib_ant_r"
double-click "soleus_r"

Expected result
Soleus muscle is highlighted in Visualizer Window and "soleus_r" appears below "Properties" panel.
Actual result
Feedback in Visualizer Window is unclear and "tib_ant_r" is still shown below "Properties" panel.

The feedback in the Visualizer Window is unhelpful when many objects are contained in the yellow box. A potential alternative to illustrate selection is for the geometry to flash:

Environment and GUI version
AppVeyor artifact OpenSim-75fdf108-2018-05-11-win64.exe

Seen in Tutorial 2. Rather off-putting. Is there a plan to address this @aymanhab ?

Update label/status bar is relatively easy, updating box is harder and expensive while in motion. We never allowed selection of muscles anyway so I don't think it affects tutorial.


Fix typos in Upwind solver

Adjust for typos and weird spacing in the upwind solver cleanup.

Should we mark VolumeIntegralUpwind and SurfaceIntegralUpwind with the Experimental warning? Or is the Experimental tag in the elixirs designed to act as a "global" marking of this.

Also, very nice work @ranocha! This cleanup helps make the front facing creation of elixirs and using this feature much easier.

Should we mark VolumeIntegralUpwind and SurfaceIntegralUpwind with the Experimental warning? Or is the Experimental tag in the elixirs designed to act as a "global" marking of this.

Yes, good point. Would you like to do that in this PR?

Should we mark VolumeIntegralUpwind and SurfaceIntegralUpwind with the Experimental warning? Or is the Experimental tag in the elixirs designed to act as a "global" marking of this.

Yes, good point. Would you like to do that in this PR?

Yeah, we can do these small changes is this PR because there is not so much in it.

Should we mark VolumeIntegralUpwind and SurfaceIntegralUpwind with the Experimental warning? Or is the Experimental tag in the elixirs designed to act as a "global" marking of this.

No, the elixir tag does not suffice, since the elixirs are not really part of the Trixi Julia package. However, in the past we often did it such that we fixed all experimental warnings as the last step before merging dev to main, since at that point you'd have to check for all experimental warnings to be present anyways.

Should we mark VolumeIntegralUpwind and SurfaceIntegralUpwind with the Experimental warning? Or is the Experimental tag in the elixirs designed to act as a "global" marking of this.

No, the elixir tag does not suffice, since the elixirs are not really part of the Trixi Julia package. However, in the past we often did it such that we fixed all experimental warnings as the last step before merging dev to main, since at that point you'd have to check for all experimental warnings to be present anyways.

Okay, I will stick the two experimental warnings on the new Volume / Surface types as a reminder that this should propagate to other parts of the code later on.


Add tests for WSMan provider, cmdlets and CredSSP

Add tests for WSMan provider, cmdlets and CredSSP
Related code coverage report:
https://codecov.io/gh/PowerShell/PowerShell/tree/9e41c647a9407e05d86f4971a6bd25719a7130d0/src/Microsoft.WSMan.Management
Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
GitCommitId                    v6.0.0-beta.3
OS                             Microsoft Windows 10.0.16204
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

This is a big area, so I'm doing this is stages:

[ ] ConfigProvider
[X] CredSSP
[ ] CurrentConfigurations
[ ] InvokeWSManAction
[ ] New-WSManSession
[ ] PingWSMan
[ ] Set-QuickConfig
[ ] WSManConnections
[ ] WSManInstance

The remaining files may be covered already by https://github.com/PowerShell/PowerShell/pull/4756, will wait on results before doing more here.


Zoom - not functional?

Alberto,
Just tried the demo on two devices, Windows 10 FireFox Developer Edition and an Android Nokia 8 Pie neither accept the mouse wheel, two finger trackpad or pinch to zoom in the scene in the demo.
Mark

Thanks for your feedback Mark, I'll check it


Apache12

@dagiro : Thanks for your contribution! The author, @mamccrea, has been notified to review your proposed change.

Review in progress.

@dagiro @mamccrea - The review team will create a PR to pull the commits into the private repo for validation and staging. We'll then ask the author to review and verify before merging. When the changes are merged into the private repo, we'll close this PR. Thanks


⚠ Bofrost.hr has degraded performance

In 1715b02, Bofrost.hr (https://www.bofrost.hr) experienced degraded performance:

HTTP code: 200
Response time: 4147 ms

Resolved: Bofrost.hr performance has improved in f12ddf4 after 2 hours, 44 minutes.


Upper case API as per interface

Change context.webApi to context.webAPI to bring inline with the actual implementation of the interface.

@Davesmall28 Thanks for the feedback. We have updated the information and pushed to live. Closing this PR.


Don't try to infer @objc for non-getter/setter accessors

These are never part of an @objc protocol, so we shouldn't bother looking for them and certainly shouldn't expect them to be there. Fixes a crash introduced in #6634.
rdar://problem/30101703

Hoping to cherry-pick to the 3.1 branch too.
@swift-ci Please smoke test

LGTM


Multi-instance Support

Does the MCAS have the ability to connect multiple Azure Tenants/Instances? The documentation is really lacking in this area. If it is possible how does one accomplish the multiple Azure Tenant Connections?

Hi @Mark7even , sorry, Multi instance support isn't supported by Azure. For more information, see https://docs.microsoft.com/cloud-app-security/enable-instant-visibility-protection-and-governance-actions-for-your-apps.
thanks

#please-close


Rename IElasticsearchClient to ILowLevelElasticClient

To offset it against IElasticClient from NEST even harder.
cc @gmarz @russcam

+1 to renaming, but only 90% convinced on ILowLevelElasticClient.  Need to let it bake.
While on the topic, what about ConnectionSettings and ConnectionConfiguration?  We discussed renaming these as well since they don't pertain to the connection only.

ILowLevelElasticClient or IElasticLowLevelClient? With the property on IElasticClient renamed from .Raw to .LowLevelClient (or .LowLevel)?
I'm also +1 for renaming, so long as we can come up with a good name :smile:


More packages modified that advertised

I just updated numpy and python-dateutil, but int he progress were also shown pandas and matplotlib, did not appeare in the confirmation dialog. I feels really really bad because conda-manager may be doing unwanted things on my back;
One thing I like in synaptics package manager is that it shows a console displaying stdout and strerr of the install process. This is reassuring because I see the progress as if I did it manually in the console.
Since you can't interact with thte package list during install anyway, it could be replaces by the conole output.
Note that it doesn't suppress the initial issue., it just lowers it's effect (and is an improvement in itself, I think)

this is by design. an intermeduate step would be to check the actions when clixkig on apply and displayin the actual packages to be installed. conda is so slow that my concern is the waiting time of that action.

Maybe a 2-step verification ? First display what the user selected, then what will be modified. If the additionnal packages are added to the window asynchronousely (while the suer checks that what he asked is correct).
In the meantime, there has to be a warning that additionnal modification may be applied to satisfy the dependancies. Right now the changes are hidden and for me it's really bad.


[FEATURE/IMPROVEMENT] Add syslog header with user-specified hostname

Is your feature request related to a problem? Please describe.
In situations where eventgen is configured to emulate that events are originating from a certain host and set to output events as syslog, this is currently not possible, because the host information is not part of the outgoing message.
Describe the solution you'd like
Add a configurable behaviour to have eventgen prefix the generated event with an initial RFC3164 compliant header to the syslog message consisting of a timestamp and the user-specified hostname. This will make it possible for receiving syslog servers to pick up the initial host and mark the events as originating from that host instead of from the IP address of the host eventgen runs on.
Describe alternatives you've considered
No alternatives that I know of.
Additional context

PR with suggested solution here: https://github.com/splunk/eventgen/pull/296

Closing this PR since suggested solution was successfully merged in. Feel free to re-open if this issue requires more changes.


ARROW-2676: [Packaging] Deploy build artifacts to github releases

~Added a new task which trigger crossbow builds on<EMAIL_ADDRESS>~See travis output https://travis-ci.org/kszucs/crossbow/builds/388667590~
Here are the boxes we need to check:

[x] Create a separate tagged branch that contains a YAML file indicating the information about each task created as part of the run. So there should be one entry for each job that was created -- the git hash for the task, the CI service used to run the task, etc. It should also indicate if one or more artifacts are expected to be uploaded

[x] Write a status tool which can query the status of a particular run and determine if the run is complete (needs cleanup)

[x] Can we run each desired task in a particular CI service

[x] We can determine the list of created tasks associated with a particular run

[x] Tasks should be configured with the tag name, and artifacts should be uploaded to GitHub under the tag which should appear as a release on the repo

[x] Each task can upload its artifacts to a deterministic central location (e.g. GitHub), where the artifacts are not commingled with any other run
-> only linux packages are failing, I suggest resolving it in a subsequent PR (issue https://issues.apache.org/jira/browse/ARROW-2713)

[x] We can determine whether all the expected artifacts from a particular run have been successfully uploaded (i.e. to GitHub) to be done in https://issues.apache.org/jira/browse/ARROW-2724

[x] We can download all the artifacts from a successful run and GPG sign them for purposes of a release vote

Example of artifacts available here https://github.com/kszucs/crossbow/releases
Jobs and tasks here https://github.com/kszucs/crossbow/branches
Job definition here https://github.com/kszucs/crossbow/blob/build-36/job.yml

@wesm Rigth now I'm struggling with passing appveyor auth_tokens, but a couple of artifacts are already uploaded as release assets: https://github.com/kszucs/crossbow/releases
Here https://github.com/kszucs/crossbow/blob/build-30/job.yml is an example yml containing the submitted job's state.

@wesm @cpcloud Do we want to support other git hosting services or just github? Because we might consider to drop pygit2 dependency and use only github's API.

@cpcloud https://github.com/kszucs/crossbow/releases/tag/build-95 26 artifacts, is that correct?

@kszucs There should be two each of pyarrow and arrow-cpp windows packages: one for python 3.5 and one for python 3.6 for a total of 4 windows conda packages + parquet-cpp

@cpcloud All of the conda and whl artifacts are uploaded now https://github.com/kszucs/crossbow/releases
Linux pkgs afe still failing, here is the tracking issue https://issues.apache.org/jira/browse/ARROW-2713

@wesm @xhochy @kszucs has artifacts for all platforms and pythons here if you're interested: https://github.com/kszucs/crossbow/releases/tag/build-115

@kszucs Do we have a JIRA for this:

We can determine whether all the expected artifacts from a particular run have been successfully uploaded (i.e. to GitHub)

@cpcloud Created JIRA for that https://issues.apache.org/jira/browse/ARROW-2724

@wesm I'm ready to merge if you are.
There are a couple of follow up tasks:

Setup nightlies on travis (which will trigger runs on both appveyor and travis). I will make a JIRA if there isn't already one.
https://issues.apache.org/jira/browse/ARROW-2724: Determine if all artifacts are successfully uploaded.

@pcmoritz @robertnishihara Have either of you encountered this error before: https://travis-ci.org/apache/arrow/jobs/395810684
I'm guessing that we happened to get a machine with very little memory on that particular run. Wondering if this is transient or an honest-to-goodness bug.

Arg, restarting the build appears to overwrite the previous build's log.

Ok, merging.

Thanks @kszucs! Onwards!


Game Crash when loading world with Accesories, Trinkets and Curious layers 1.20.1 FORGE

latest.log

Hopefully fixed with latest release of accessories and the compat layer


Make meshes manipulation easier

Hey, just wanted to discuss about adding a few things.
Correct me if I'm wrong but, Document isn't very easy to manipulate : you have to browse the whole tree to find your meshes (vertex positions, normals, ...).
What would you think about adding methods like Document::meshes() or materials() that will return iterator/list of Mesh with primitives where we could find vertex positions, normals, triangle indices, ... In order to make it more convenient to manipulate.
Basically, something like this gltf parser : https://docs.rs/gltf/latest/gltf/struct.Document.html.
This wouldn't affect the actual tree structure, but only adding methods to make things easier.

There are already some tools for being able to do this, although they are not particularly discoverable. Specifically, you can use the Document::local_map function with the type of the object kind you want to get a hashmap structure you can use for lookups, the Document::library_iter method for getting top level (Library<T>) objects, and Document::library_iter method for getting other objects by type. For meshes, you could thus do something like document.iter::<Geometry>().filter_map(|g| g.element.as_mesh()).

You can filter by mesh, yes. But you still have to go into Mesh.elements to search for inputs types (vertex/normal/textcoord).
Then, you search in Mesh.vertices for your vertex positions that refer to something in Mesh.sources (Same for normals).
That's a lot of things to do. If all people need to do this on their side, it's pretty annoying. Why not doing this filtering/research directly in the project?

Yes, it is a lot of steps. But most of it is just because collada is a complicated format with a lot of pieces which were designed to be mixed and matched in a huge number of ways, so while most individual use cases don't need all this complexity, I don't think it is possible to present a simpler interface that doesn't significantly reduce the applicability to other shapes of usage, and I don't have enough concrete applications or reverse dependencies to be able to confidently determine a least common denominator interface which isn't overspecialized. That's why the API looks the way it does, they are all APIs that assist you to use the collada puzzle pieces as intended, but don't skip any steps.
If you have a concrete API implementation to suggest, feel free to suggest one here or make a PR. Collada is not gltf (although quite frankly I think the khronos group did a better job with gltf) and I don't think the API transfers cleanly, but you are welcome to try.


Exception when running octopress ink list with pullquote-tag installed

This is what happens:
$ bundle exec octopress ink list -t
/Library/Ruby/Gems/2.0.0/gems/octopress-pullquote-tag-1.0.0/lib/octopress-pullquote-tag.rb:47:in `<top (required)>': uninitialized constant Octopress::Tags::Quote (NameError)

Here's the Gemfile:
group :jekyll_plugins do
  gem 'octopress-pullquote-tag'
  gem 'octopress-asset-pipeline'
end


Xnero: Watch islamabadcallgirl.com

Xnero requests the watch of the watch_keyword islamabadcallgirl\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

islamabadcallgirl\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


when does the updater app update...

Explain that releases take a few days to show up.
@phil-davis your input would be very welcome :grin:

Seems fine :+1:


Improve VR controller

After experimenting with SpacesVR and playing around with some websites like https://muse.place, I noticed the VR controllers weren't working as expected.
Some of the issues I found (video below):

Controllers didn't "follow" the user.
Smooth Turn is known for causing motion sickness. Snap Turn is a better default option.

https://user-images.githubusercontent.com/5553483/123548746-06728c00-d75e-11eb-8564-d525394e696e.mp4
I took a stab at it and what I thought would be a quick fix, made me change a few more things. Would like some general feedback, but specifically L102-L106, since I tried to maintain the current Player implementation but might be missing something here. I'm unsure what the direction should be in this case.
https://user-images.githubusercontent.com/5553483/123548969-edb6a600-d75e-11eb-8f13-fecb3498cfb1.mp4

Hey, any feedback?

sorry for the delay, been caught up making a platform for all this that i'll be sure to share with you :)
I'll look into it today!

I know it's already closed! Thanks!
Don't mind improving the controllers too if any issues arise :)
I'll be keeping an eye out


reintroduce a stackwalker for release bins

at the moment we can not really track down bugs appearing when crashing in release mode.
sure you can start up your favorite debugger and hope the bug appears again, but thats not in the toolbox of most of our nightly testers.
This makes the nightly system (at least for crash-causing bugs) pretty useless.
For windows the solution for sauerbraten (and until the introduction of exceptions.. inexor) was to show a short list of lastly executed calls by the engine in case of a crash.
We badly need to reintroduce this, but we should also show it for unix-people.
this http://oroboro.com/stack-trace-on-crash/ could help.

merged with pr a_teammate/stackwalker and a580fe4034992ec0a18364c40a3eb996abcf3bb8


auto formatting does not work

when i was coding a cpp file,press the ';' button, code formatting does not work as expected;

/extC++


Show all program icons in monochrome when using the Series 5 theme

Not convinced about this tbh - right now having a colour icon is the only indication that an app supports colour, so being heavy handed with the theming actively removes information about your apps..

Pushing into future for later consideration.

On further thought, I think I'm happy to close this as won't fix for the time being.


Kenesbek Proj

The game is playable in the Terminal.
There are currently no Tests yet, as I wanted to first get feedback on the implementation before creating them.
In Explanations.txt file I documented my thinking process when creating most features. Will later turn it into a proper documentation.

There's something going wrong: it sometimes hangs, for example:

Made changes as requested, fixed and understood the first bug, added testing (both Unit and Property-Based), and added final documentation in report.pdf

Blows up:
Ekaterina.Verbitskaya@NVC00653 minesweeper % stack run
Enter grid dimensions and number of mines (e.g., rows,cols,mines):
3,1,2
      0
  --------
  0 | .   |
  --------
  1 | .   |
  --------
  2 | .   |
  --------

Enter your first move (row,column):
1,0
minesweeper: Too many mines: Cannot place 2 mines in a grid with only 0 valid cells.
CallStack (from HasCallStack):
  error, called at src/Grid/Generation.hs:64:31 in minesweeper-<IP_ADDRESS>-2hDQarTrxVG3Aaa6xdcYbH:Grid.Generation

It is intended behavior. If there are too many mines it throws an error

Throwing exceptions into a user must never be done. If you, for some reason, think that 2 mines don't fit into 3 cells, warn the user, and do it when creating the grid, not after the first move.

Yeah makes sense. My bad. It's just that having a 3x1 grid with two mines would mean that you win with your first move. This way I was also trying to prevent the bug that you noticed when I submitted previously

Fixed it

Ok. Good job 👍


Creating / destroying lots of windows causing segfaults

I've got some unit tests for my library (CyGLFW3, a Cython binding), and each test is creating / destroying a window.
The tests individually are ok, but when I run them all together, I start getting random segfaults.
This may be an OS-X only issue.
Here is an example stacktrace
0   libglfw3.3.dylib                0x0000000101805487 _glfwInputCursorMotion + 102
1   com.apple.AppKit                0x00007fff8a890324 -[NSWindow sendEvent:] + 1260
2   com.apple.AppKit                0x00007fff8a8318f2 -[NSApplication sendEvent:] + 2819
3   libglfw3.3.dylib                0x00000001018099a3 -[GLFWApplication sendEvent:] + 136
4   libglfw3.3.dylib                0x000000010180a69e _glfwPlatformPollEvents + 67
<snip>

0   ???                             0x00007fff5fbfaa48 0 +<PHONE_NUMBER>84520
1   com.apple.AppKit                0x00007fff8a890324 -[NSWindow sendEvent:] + 1260
2   com.apple.AppKit                0x00007fff8a8311be -[NSApplication sendEvent:] + 975
3   libglfw3.3.dylib                0x00000001018099a3 -[GLFWApplication sendEvent:] + 136
4   libglfw3.3.dylib                0x000000010180a69e _glfwPlatformPollEvents + 67

Unable to reproduce this with the reopen test on 10.10.3.

Still unable to reproduce. This time with a MacBook with 10.10.5 and a MacBook Pro with 10.12.2.

I can try again with 10.12.2 (last time I tried it, I had 10.9.3).
Should I test with latest stable version of GLFW, or master branch? I can also do both.

Sorry for not contributing, I'm pretty busy at the moment. I'll see if I can find some time after work.
I've got two different Macs computers running different OS-X versions I can test on which may help.

Is anyone able to reproduce this with the 3.3 release, or can this issue be closed?

Sorry, I no longer have a Mac to test this on. Hopefully someone else can pitch in.


Schemaorg Release v6

Adds support for PronounceableText-to-string
Adds all other Schema.org v6 changes
Minor allocation cleanup for SchemaClass - no longer allocates an array per call to IsPrimitive

Closes #126

So it looks like we will have a unique problem - the Offers type now has this as a property:
///
/// An item being offered (or demanded). The transactional nature of the offer or demand is documented using businessFunction, e.g. sell, lease etc. While several common expected types are listed explicitly in this definition, others can be used. Using a second type, such as Product or a subtype of Product, can clarify the nature of the offer.
///
Values<IAggregateOffer, ICreativeWork, IEvent, IMenuItem, IProduct, IService, ITrip> ItemOffered { get; set; }

I think we're gonna need to make a Values7 type...
My thought is rather than maintain all of these ValuesX types manually is actually having them be built by a tool as well.

The order of some inherited interfaces changed which caused some noise in the generated code. If we ordered them by name, we could solve that problem in future at the expense of a one time noisy commit.
Not sure about generating ValuesN, might be worth the effort. I'll leave that to your judgement.

If we ordered them by name, we could solve that problem in future at the expense of a one time noisy commit.

Yeah, that's a fair call. Might be worth doing as a separate PR to this after this is merged.

Not sure about generating ValuesN, might be worth the effort. I'll leave that to your judgement.

I'm just thinking the overhead of manually updating Values2, Values3, Values4 and now potentially have a Values5, Values6 and Values7. If we were wanting to change or fix one thing between them, it could be a lot of effort plus we have a higher chance of making a mistake.
Not sure what we would do for the tests though - would be kinda silly to automatically generate tests for it as we would have potential for the tests themselves to be wrong.

Good point about tests. Feels a bit weird but then generating code using StringBuilder feels weird too.
Have you seen the news about code generation in .NET? Early days but they plan to add code generation as a 1st class feature. They talk about a pre-compile step where code-gen code in your method is run and then spits out autogenerated code. We might be able to use that when it's more concrete.

Sorry, I've been meaning to get back to this for a while - I've looked up a few solutions that we could use now however they have different pros/cons:
T4 Templates

Compile time output
Code structure can be similar to the desired output
Would require some (minor) modification to support greater number of generic arguments
Lack of syntax highlighting in VS2019 (this one kinda surprised me)

CodeDOM

Runtime output
Code structure would resemble very little to the desired output
Coded in C# with normal syntax highlighting
Greater flexibility to what we could output

I think with the right helper methods, we could make a solution with CodeDOM work pretty well and not be too much of a burden to the code base.
This tutorial from MS would be a good start: https://docs.microsoft.com/en-us/dotnet/framework/reflection-and-codedom/how-to-create-a-class-using-codedom
Followed with: https://docs.microsoft.com/en-us/dotnet/framework/reflection-and-codedom/how-to-create-an-xml-documentation-file-using-codedom
We should be able to generate code that is 100% compatible with the editor config rules etc so we don't need to deal with any weirdness.

While not in the scope of this PR, if we did want to migrate away from using the StringBuilder approach for all the other classes, we could potentially use CodeDOM for those too. That or just wait for that 1st class code generation feature so we don't need to do the work twice.

I'm hesitant to invest heavily in code generation when I know that Microsoft is building something as we speak. The thing is I'm not certain when that will become available. At this stage it's all experimental. If I had to guess, it'd take at least several months.

Lets just fix up the CI and get this merged for now. Schema.org v7 came out with some Corona Virus updates. Might be worth getting that in too.

I've added support for Values7 (that took a long while to write all the tests). Looks to now be just breaking changes with some of the other models and their tests.

Looks like there are 6 failed tests.
Thanks for updating. It'd be nice to stick it to the CoronaVirus in a very very small way with this PR.

So the fix for those tests was a slight change to how we handle DateTimeOffset.
For a Values<int?, DateTime?, DateTimeOffset?>, keep in mind we read the generic parameters from right-to-left in our conversion code. With a string like "2020-03-18", when we encounter the DateTimeOffset, we check if DateTimeOffset.TryParse works which, even if it doesn't have an offset, it does work - that right there was our problem.
Some ValuesN properties have DateTime and DateTimeOffset, some have just DateTimeOffset. Any time we had DateTimeOffset, it would always usurp anything that was also a valid DateTime. This is an additional problem because if you don't specify an offset, it will use the current system's offset. This is what happened in our tests, our test JSON strings were dates but they were converted to DateTimeOffset rather than DateTime so had the offset of the target machine.
To alleviate this, I made the check to try parsing as a DateTimeOffset include specifically checking for the ISO 8601 offset characters of "+" and "Z" - if either are there, try parsing as a DateTimeOffset otherwise don't.

There are a few quirks with what I've mentioned above so will be adding some tests and tweaking some more behaviour.

One obvious mistake I missed, I'm not handling negative offsets. Whoops!

 The short of it is, I'm going to disable the built-in DateTime parsing by JSON.NET and rely entirely on our own as there are various issues around offset handling. With that in mind, I'm going to create our own SchemaSerializer class which has all the configuration necessary to both read and write - currently we only have our overloads on Thing.ToString() etc which allow writing.
Using this SchemaSerializer is entirely optional for reading with the exception that offsets for datetime values do not work. This class will replace the inner-workings of Thing.ToString() etc however those methods will still exist and just point to SchemaSerializer.

To summarise everything:

Schema.org v7 Models are now used
Fixing issues with DateTime and DateTimeOffset - only using DateTimeOffset if there is an offset (this is what broke those 6 tests the other day)

Its that last part which brings through these changes:

Removed support for using JSON.NET Date parsing - it prevented the offsets from correctly coming through under certain conditions
Added new SchemaSerializer which helps fix the date parsing issue by disabling the built-in JSON.NET Date parsing. This does mean for anyone to use our "fixed" date time handling for reads, they need to use SchemaSerializer instead of JsonConvert directly. In theory, if people haven't yet encountered weirdness around date time handling, they won't notice a difference by not using it. I think though it might be good to say this is the "recommended" way as it may help us moving to System.Text.Json in the future.
As all date parsing is now done on our end, fixed support for MS DateTime string (eg. /Date(12356789000-0100)/) (JSON.NET didn't support offsets for this)

With that last point, it means we are no longer skipping one of our tests for MS DateTime.

Oh, one other little note - I added an allocation free path using Span for the date parsing. While that would normally be compatible, there is no int.TryParse that takes in Span for anything less than .NET Core - with this in mind, I added .NET Core 3.1 as an additional target for the main library.

Looks reasonable to me. I'll see if I can arrange a release today.
Thanks for your efforts as usual. Stay safe!

@Turnerj Source generators is here now. It came earlier than I expected.
https://devblogs.microsoft.com/dotnet/introducing-c-source-generators/

Yeah it sounds interesting though I'm not actually sure its going to be much of a difference for this library.
As the source is injected into the build, the source it injects in terms of namespacing and actual code still looks to be built with a StringBuilder (at least based on the example in that blog). The advantage it seems to provide is that the generated code doesn't actually need to exist in the repository
While the generated code might not be in the repository isn't necessarily bad (its great in theory for PRs and general repository size), I actually thought source generators were more like a new paradigm in source generation whereas it seems to just be a new way to hook code into compilation without files. I imagine when dealing with compilation issues, source generator ones may be a lot harder to debug vs file-generated source (like we do now) as we likely can't see the full "generated" source to see our errors more obviously (sometimes error messages from compilation aren't the most intuitive).
Hopefully there are some more examples in the future where source generators are used that our workflow seems more suited for.


No h5 file and Zenodo link broken

No h5 file appears in the data folder, and I receive and error when I click on the link to the data via Zenodo.

change it to the following, and it should work fine
wget https://zenodo.org/records/7125742/files/BHPTNRSur1dq1e4.h5

I wasn't able to reproduce this issue on my laptop running Ubuntu. I'm going to close out this issue, but if data download issues continue, please let me know your OS.


TurboWarp 404 page

Expected Behavior
TurboWarp having a nice 404 page
Actual Behavior
TurboWarp gives a plain text 404
Steps to Reproduce

go to a nonexistent page on turbowarp.org
done

Operating System and Browser
Edge Chromium Latest

Soon


General Type Maintenance

Summary
As part of #8436 , this PR has a much larger scope, targeting obvious unnecessary castings and consistent Object Literal Types throughout the codebase.
For consistency I decided to use Record<string,string> if the type didnt have a meaningful index key  ie:
type PathLookup= {[path:string]:string}
--- type LookupObj= {[key:string]:string}
+++ type LookupObj= Record<string,string>

Test plan

Codecov Report

Merging #8462 into master will decrease coverage by <.01%.
The diff coverage is 68.96%.

@@            Coverage Diff             @@
##           master    #8462      +/-   ##
==========================================
- Coverage   62.32%   62.31%   -0.01%
==========================================
  Files         266      266
  Lines       10735    10735
  Branches     2614     2617       +3
==========================================
- Hits         6691     6690       -1
  Misses       3460     3460
- Partials      584      585       +1

Impacted Files
Coverage Δ

packages/expect/src/asymmetricMatchers.ts
82.29% <ø> (ø)
:arrow_up:

packages/jest-jasmine2/src/jasmine/createSpy.ts
0% <ø> (ø)
:arrow_up:

packages/jest-validate/src/warnings.ts
87.5% <ø> (ø)
:arrow_up:

packages/jest-resolve/src/index.ts
44.52% <ø> (ø)
:arrow_up:

packages/jest-core/src/FailedTestsCache.ts
76.47% <ø> (ø)
:arrow_up:

packages/jest-config/src/setFromArgv.ts
86.36% <ø> (ø)
:arrow_up:

packages/jest-snapshot/src/utils.ts
92.42% <ø> (ø)
:arrow_up:

packages/jest-jasmine2/src/jasmine/spyRegistry.ts
0% <ø> (ø)
:arrow_up:

packages/jest-config/src/utils.ts
75.86% <ø> (ø)
:arrow_up:

packages/jest-worker/src/Farm.ts
100% <ø> (ø)
:arrow_up:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e2cc6...6bd1ad8. Read the comment docs.


Support newer releases of Archive::BagIt

New version at CPAN: https://metacpan.org/pod/Archive::BagIt
New developer repository: https://art1pirat.spdns.org/art1/Archive-BagIt
Temporary work-around: https://github.com/crkn-rcdr/cihm-ingestwip/commit/299aa91d02481df6214ae6fc7495dd76b4bd9db9

Reading the drafts I suspect I found the issue.
An important change between 0.97 (drafts 6 through 14) and 1.0 (drafts 15 through RFC 8493) is which algorithms are mandatory.  For 0.x it is md5 and sha1, but for >1.0 it is SHA-256 and SHA-512
https://tools.ietf.org/html/draft-kunze-bagit-14#section-2.4
https://tools.ietf.org/html/rfc8493#section-2.4
I notice in https://art1pirat.spdns.org/art1/Archive-BagIt/src/branch/master/lib/Archive/BagIt/Base.pm#L516  that if bag_version() >=1.0 that SHA512 is used, otherwise MD5 is used.
We have several follow-on tools (including the Swift BagIt verification, AIP replication) that assume manifest-md5.txt is mandatory.
As we will be moving away from our custom OAIS packaging in the near future, we may want to ensure a way to force compatibility with the older version of bagit for creating bags is supported.

Some details around differences found: https://github.com/crkn-rcdr/Digital-Preservation/issues/13

This issue remains open for a few reasons.
a) We are currently building using a package of our own making, rather than from CPAN.  I need to ensure that the fixes we needed are made upstream so we can use the upstream module.
b) We need to update our CIHM::TDR::Swift::validateaip() to match the byte count.  The new module includes the count of bytes of the manifest/etc when there is a tagmanifest.   Currently the byte counts are off https://admin.canadiana.ca/repository

Move to Archivematica makes fixing this redundant.


make process.env.JAMBONES_REGBOT_CONTACT_USE_IP a trunk setting instead of environment variable

When registering and using the public IP of the jbz sbc as the AOR and getting that switch from ENV JAMBONES_REGBOT_CONTACT_USE_IP variable, I think it would be better to make this an individual trunk setting and not an ENV.
That way you can have the regbot use both scenario's.

this was fixed in 0.7.7


RTDB write size limit error

Step 0: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request please use the Feature Request template.

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general (non-iOS) Firebase discussion, use the firebase-talk
google group.
For backend issues, console issues, and other non-SDK help that does not fall under one
of the above categories, reach out to
Firebase Support.
Once you've read this section and determined that your issue is appropriate for
this repository, please delete this section.

[REQUIRED] Step 1: Describe your environment

Xcode version: 11.6
Firebase SDK version: 6.28.1
Firebase Component: Database
Component version: 6.28.1
Installation method: Carthage

[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
If you call setValue on a DatabaseReference with a value that is larger than the allowed write limit of 16mb (my case was 19mb), the supplied completion handler is never called. Furthermore any subsequent updates from the client are never synced to the server.
I have not created a project to demostrate the issue as I think that it is fairly easy to reproduce.
If you wish, I could create a reproduction.
Relevant Code:
let value = <something really big. like a dictionary from a string to a base64-encoded and really large image>
 ref.setValue(value, withCompletionBlock: { error, _ in
   print("Never reached")
})

// sleep for a while
otherRef.setValue(smallValue)

// smallValue never reaches the server

A bit more info on this. With debug logging enabled and by following along in the code, I can sort of see what is going on - and I can also see that a fix would apparently require a server side change too.
I get the following logs when the write is too large:
2020-10-01 14:12:32.951087+0200 POS[21369:504571] 6.28.0 - [Firebase/Database][I-RDB082011] Got control message: {
    d = "ClientId[9234551]:ErrorId[1002]: Write too large";
    t = e;
}
2020-10-01 14:12:32.951202+0200 POS[21369:504571] 6.28.0 - [Firebase/Database][I-RDB082012] Unknown control message returned from server: {
    d = "ClientId[9234551]:ErrorId[1002]: Write too large";
    t = e;
}

So the first thing here is that the control message type 'e' is unhandled. I looked at the code to see if it might be 'easy' to fix.
But then I realise that in order to call the callback, we need to know the request number of the failed write - and the control message from the server apparently does not contain the request number.
Not really certain what to do with this, but perhaps this information can be of use...

I can see why the server probably can't respond with the request number - as the request is probably too large and thus can't be parsed.
A hacky workaround - if you deem the issue worthy to fix:
Upon the client receiving a 'Write too large', the client could look at all the outstanding requests, find the largest one, call it's completion with an error and remove it.
I know that it is probably a bit expensive to serialize all requests to compare their sizes, but compared to what is going on (very frequent retrys of all outstanding requests), this work is still not a whole lot.

@mortenbekditlevsen Thanks for filing this. This is actually a known issue for the Web client (https://github.com/firebase/firebase-js-sdk/issues/1158), but probably affects all of our clients. Since only a handful of users seems to be hitting this, we have not yet prioritized a fix. The eventual fix will likely involve us rejecting the write that is too large, which will allow us to process other subsequent writes. If we do prioritize this fix, we will update this issue accordingly.


fix(linux): crash on existing hotkey grab

Fixes: https://github.com/golang-design/hotkey/issues/11

I've taken another approach. Making the XSetErrorHandler an opt-in for Linux implementation only.
We keep the common API consistent.
We do not introduce any undesired, hidden from the user behaviour on Linux.
We provide a proper way for the user to receive the actual XErrorEvent.

@changkun any feedback here? Do you have something against the new approach?

Thanks for contributing another workaround. The approach might solve the Linux problem, but introducing a platform-specific API is not the goal of simplicity.
The issue should be resolved with the absence of public APIs regarding explicit error handling. We either stick to the runtime panic that effectively warns the user or solve the problem entirely by knowing the registration error immediately at the Register call.
I do not have a chance to work on this before the end of next week, if this is needed urgently, you may switch back to a forked version that applies this patch.
According to the previous discussion, I'd like to close this for the clarification of rejecting any platform-specific workarounds. Any other actual solutions that match the previously described expectations remain kindly welcome and appreciated.

I see. Will be great if you manage to solve it properly. But I disagree that runtime panic is acceptable. IMO panic should happen only on startup and not based on user configuration that may change at runtime.
On another note regarding API consistency and simplicity. There currently are platform specific variables which will be better to be handled in a single wrapper in the hotkey package.
Alt key per platforms:

darwin - https://github.com/golang-design/hotkey/blob/main/hotkey_darwin.go#L98
linux - https://github.com/golang-design/hotkey/blob/main/hotkey_linux.go#L129
windows - https://github.com/golang-design/hotkey/blob/main/hotkey_windows.go#L146

I've currently added per platform wrappers for these:
https://github.com/ventsislav-georgiev/prosper/tree/main/pkg/helpers/hotkeyh

The key variables are different. The actual unification is hotkey.Key and hotkey.Modifier. Using keycode directly is possible:
switch runtime.GOOS {
case "linux":
    mods = []hotkey.Modifier{0x1, 0x2, 0x3}
case "darwin":
    mods = []hotkey.Modifier{0x4, 0x5, 0x6}
case "windows":
    mods = []hotkey.Modifier{0x9, 0x8, 0x7}

without being bothered by those convenient name shortcuts.

Using hotkey.Modifier directly for unification makes the existence of the key variables redundant and is confusing to keep them for per platform usage as per your reasoning for closing this PR.

Using hotkey.Modifier directly for unification makes the existence of the key variables redundant and is confusing to keep them for per platform usage as per your reasoning for closing this PR.

If you find the package confusing then please leave it. Thanks.

I like the package, just giving my two cents about improving it. Didn't mean to offend you or the package in any way. I apologise I sounded like that.


Fields in Traits not indexed

The AnnotationReader does not take traits into account.
Since traits provide a rather helpful way of composing entities without vertical/hierarchical inheritance and the usual multiple inheritance troubles, I think this bundle should be aware of fields in traits.

Further use of traits to compose entities has uncovered problems using the changes provided in #198:
Although the AnnotationReader now  successfully detects properties in traits, it fails to get the value of these properties due to the following error:

Given object is not an instance of the class this property was declared in

In this case, the "given object" is an instance of the class using the trait, but the ReflectionProperty::getValue() method fails, since the propertie's "declaring class" is the trait, not the aforementioned class.
I'll be using an abstract class for my use case.
If no solution is found I would suggest adding a hint to the documentation.


Peptideshaker updated to version 1.16.26. SearchGUI updated to version 3.3.3.

Um... it seems the problem related to Planemo loading values from samples files is also happening here :-(
In my local planemo all tests succeeded.

--------------------- >> end captured stdout << ----------------------
ERROR: ( search_gui ) > Test-2
Traceback (most recent call last):
File "/tmp/tmpYZ49dQ/galaxy-dev/test/functional/test_toolbox.py", line 88, in test_tool
self.do_it(tool_version=tool_version, test_index=test_index)
File "/tmp/tmpYZ49dQ/galaxy-dev/test/functional/test_toolbox.py", line 41, in do_it
verify_tool(tool_id, self.galaxy_interactor, resource_parameters=resource_parameters, test_index=test_index, tool_version=tool_version, register_job_data=register_job_data)
File "/tmp/tmpYZ49dQ/galaxy-dev/lib/galaxy/tools/verify/interactor.py", line 674, in verify_tool
raise e
RunToolException: Error creating a job for these tool inputs - Parameter variable_modifications requires a value, but has no legal values defined., Parameter fixed_modifications requires a value, but has no legal values defined.

I modified the second test to avoid Planemo problems. May this PR be merged, please? :-)

Of course!


add cloud save icons; add cloud save button instead of text

As we agreed on in the design meeting (quite a while ago now), here's the new cloud status indicator reworked as a button instead of icon + text.
Currently clicking the button does nothing except send a tick event. Since we're always auto-saving, it's not clear what the button could do..
Before:

After:

@eanders-MS , how do you feel about this change? Now that it's here, I'm not sold as it's less informative and very subtle. Also the "uploading" icon is a bit hard to parse.

Well, I was never onboard with this change, but willing to try it out. Agreed the saving icon could be improved. An upward pointing arrow typically means "has local changes". Saving to cloud should be an animated rotating arrow.

I'll merge this for now since it was the roughly agreed upon goal, but I want to bring this up again at the next design office hours and hopefully we can at least improve the icon. It's relatively easy to iterate on this.


[git-exporter] Allow customising secret patterns

Addresses #314
I haven't been able to test this on my existing install because I am not sure if it's possible to add an add-on repository from non-default branch and changing repo metadata would pollute this PR.

Addons can be tested locally with the folder inside the /addons mount point. Just remove the image:  from the config.json and your HA Host will build it locally. The addon will appear in the Store as "Local addon". ;) That's how I test new addons most of the time.

Yeah I tried that but was getting a Docker build error. I think perhaps some of the apk packages you had version-pinned have bumped versions and they still pass here because your GH Actions have that layer cached. At least, that was my theory...

@bjeanes They, don't pass 😅
alpine Linux simply replace all old versions when a new one is available for some reason....
So for working correctly the git package must be updated I think

Yup. I created a testing branch in my fork where I just removed all the version requirements haha. In my own repos I don't pin Alpine package versions for exactly this reason. I just rely on the immutability of Docker layers!

Shh bot, no time to review, but not stale 😅


Contents of \phantom is displayed when printing

When using \phantom to add spaces, it shows correctly in the HTML version, but when the HTML site is printed to paper or printed to PDF the contents of \phantom show up.
A minimal example is attached, where the corresponding tex-file contains:
$x + y \phantom{\text{ halløjsa! }} - z$
The attached test.pdf shows the page printed to PDF, while test2.pdf is saved using Chrome's "emulate CSS media type"-tool to show how the HTML version looks.
test.pdf
test2.pdf

If you add the following to css/iLaTeXen.css:
span[style*="transparent"] {
  visibility: hidden;
}

then it works for me when printing. It seems that elements on which phantom has been applied to have the css property color: transparent, and for some reason printing doesn't play well with this. But it works if we add visiblity: hidden as well!

CSS fix is added to latest version


3040 binary scalar slider

Styling and integrating the outcome range graph for binary and scalar markets.

@stephensprinkle This should be ready to go now!


Create rule templates

Templates are a way for us to easily assist a user of Mailman with rule creation.
Parent: #4

This should take the form of an object that can be loaded from JSON. This can be exported/imported in Mailman.
This will let us set up the app for our users. It could help with debugging issues for users as well.


Replace link server w/pay extension

Replace link server with pay button extension (which is not yet written) on LNBIts server.
Rationale: reduce infrastructure and simply.
ETA TBD

pause until free time is avail.


Add language PT-BR

Please duplicate locale pt with name pt-br
pt - Portugal
pt-br - Brazil
Both speak Portuguese, but we have a specific locale.

According to CLDR, pt defines Portuguese as spoken in Brazil (note pt-BR is the default content locale for pt); pt-PT defines Portuguese as spoken in Portugal.
http://cldr.unicode.org/translation/default-content

Can you confirm that this is an issue in master with make-plural?
On Mon, Jul 27, 2015, 9:27 PM Rafael Xavier de Souza <
<EMAIL_ADDRESS>wrote:

According to CLDR, pt defines Portuguese as spoken in Brazil (note pt-BR
is the default content locale for pt); pt-PT defines Portuguese as spoken
in Portugal.
http://cldr.unicode.org/translation/default-content
—
Reply to this email directly or view it on GitHub
https://github.com/SlexAxton/messageformat.js/issues/116#issuecomment-125410926
.

Ah. Just saw Rafael's answer. Sounds right to me!

The locale lookup in messageformat.js should also correctly find the pt rules for pt-BR (0.2.2, 0.3.0-1).

Closing this due to finally releasing 0.3.0. Also, we have a new website at messageformat.github.io.


Is there any way to prevent coming drag & drop if container has more than 3 draggable items?

I am implementing React drag and drop using this library and I have one problem.
I have several containers in the app and I am going to prevent coming drag & drop(though I can move existing draggable into another container) if that container has more than 3 draggables inside. 🤔
It would be nice if I can solve this issue soon.
Thanks. 👍

Yes there is!
see docs

Wow. great! thanks. I missed that cb function in docs.


MSAA render targets: Resolve the depth texture (if any) and allow for manual resolve

Note that this is not yet implemented in WebGPU (it's a little more difficult than in WebGL, where ANGLE supports depth texture resolve, which you have to do manually in WebGPU).

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15888/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15888/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15888/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15888/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15888/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15888/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15888/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15888/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15888/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15888/merge/testResults/webgpuplaywright/index.html

Last check would be to be sure Native is still all good

Last check would be to be sure Native is still all good

cc @bghgary I guess?

Last check would be to be sure Native is still all good

cc @bghgary I guess?
Native doesn't support MSAA in render targets yet, so there is nothing to test.


Xcode 12 compatibility fix

Summary
Latest Xcode 12 fails to build while without a module to depend on React-Core directly hence this change is necessary for all native modules on iOS. For more details please check: https://github.com/facebook/react-native/issues/29633
Test Plan
Use this branch to install with an app running on Xcode 12.

This PR needs to be fixed and merged ASAP since this library doesn't work on XCode 12 without hacks.

As @The0racle said, this PR needs to be merged immediately. The build in Xcode 12 does not work with this library.

Can we please merge this pull request @ssssssssssss ? Its very URGENT!!!

Up to date version here https://github.com/react-native-svg/react-native-svg/pull/1604

Since https://github.com/react-native-svg/react-native-svg/pull/1604 has been merged, I will close this PR. Feel free to comment if I am wrong and we can reopen it then.


fix: Use derived ArrayDims instead of deprecated attndims

Postgres sometimes returns incorrect values for attndims which explains the TODO in the code. Use the type-derived dimensions instead.
This fixes a bug where in rare cases arrays were not correctly detected in one of our applications.
According to https://postgrespro.com/list/thread-id/2304332

We don't really care.  attndims is a historical leftover and should never
be relied on for any semantically significant purpose.
TBH, my inclination would be to remove the column altogether rather than
"fix" this.

Thanks!


Add mongo-retrywrites to config.

The new client by default sets retry writes to true, which doesn't work for single servers.
This is painful to test locally so we'll need to test in CI.

Similar to https://github.com/kbase/workspace_deluxe/pull/573/files


Consider using Case classy to avoid config boilerplate

https://github.com/47deg/LambdaTest/blob/master/src/main/scala/com/fortysevendeg/lambdatest/LambdaOptions.scala
This kind of config boilerplate can be easily avoided with https://github.com/47deg/case-classy and will also help us promote this lib as well. Please coordinate with @andyscott to see if there is a good use case for it here.

We not add. Options are quite simple. To keep it simple, don't want to add more external dependencies (not just classy but also the stuff it uses).


PNG exported from GIMP and imported as Sprite2D doesn't show in editor

Godot version
4.0.stable
System information
OSX Ventura 13.1
Issue description
I just installed the Godot 4 official release. When I import a sprite from an PNG that I exported from GIMP it doesn't appear in the editor. It does show up when I run the game but not in the editor. I used this same image in Godot 3.5.1 with no problem. I've found that if I re-export it as a new image it works fine so this isn't blocking me at all but as far as I can tell this is a valid PNG image that should work in Godot and it's doesn't. Just reporting in case it helps make the editor more robust.

Steps to reproduce
Import the attached image as a Sprite2D.
Minimal reproduction project
N/A

It works fine for me on PopOS 22.04. Maybe this is a macOS specific issue?

Could you please provide more information to assist contributors in debugging this issue for you?

Upon further investigation it seems like the problem had to do with the resource path (and maybe caching?), not the image file itself. Somehow the editor got confused and it wasn't showing. It just so happened that all the other images I tried when troubleshooting it had a different path so they worked. At one point (after I submitted the bug) an error showed that said something about a resource with that path had already been imported. Anyway, I can't reproduce the problem now. Sorry. If it happens again I'll update the issue with more detail.


Assign a specific App to a specific Zone

Description of the new feature / enhancement
It would be nice to start my PC and have my Apps assigned always to to the same zones.
How much time we would save by not ordering our desktop every time we boot?
Additionally, possibility to assign in shortcut, when a program is launched, always the same zone.
Scenario when this would be used?
Every time I boot
Supporting information
No response

/dup #348


ci: update build image

This updates to use the version envoy HEAD is using
Signed-off-by: Keith Smiley<EMAIL_ADDRESS>

/retest

https://github.com/envoyproxy/envoy-mobile/pull/2261#event-6574519208


Replace DynamicSliceOutput with Slices.allocate in copyPositions

Several implementations of copy copyPositions use DynamicSliceOutput
even though we know the exact size of the slice that we need. Replace
these usages with Slices.allocate.

Looks good


Prevent empty dictionary with non-String keys from encoding as a JSON object.

Darwin encodes these as an empty array ([]), but SCF was encoding an empty JSON object instead ({}). Fixes https://bugs.swift.org/browse/SR-15781.

@swift-ci please test

Please test with following PRs:
https://github.com/apple/swift/pull/41115
@swift-ci please test


EOF. Char overflow. Fix #590

Close #590

This change is

Review status: 3 of 5 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

transpiler/operators.go, line 594 at r2 (raw file):
Previously, elliotchance (Elliot Chance) wrote…
Using inline functions is unesseary and makes the code more complicated. Please extract this into a normal function.

Done

Comments from Reviewable

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


drawingBuffer canvas should probably be inside the video element, not below

CSS positioning is a nightmare.  It works much easier having the drawingBuffer canvas inside the video element, so it inherits the same box.
As Quagga does support sending in a previously created container, as well as giving it a proper video and canvas element (as well as a "imgBuffer" tagged canvas, which I'm not sure what that is used for just yet), I'm using a sample that looks like

                <video style={{width: window.innerWidth, height: 480}}>
                    <canvas className="drawingBuffer" width="640" height="480" />
                </video>
                <Scanner scannerRef={scannerOpen && scannerRef} onScannerReady={onScannerReady} onDetected={() => console.warn('* onDetected')} />

This allows me to get proper canvas positioning, without having to resort to bizarre CSS tricks, so I'm pretty sure that this should be the default method for creating it when you don't provide a custom video and canvas element

doesn't work from inside the video tag.  still going to leave this open because I think that the hierarchy needs some work so this will remind me to look at it.

Also noting: investigate where debug drawing is going to, see #54

Not sure if this helps but, I ended up wrapping the video and canvas elements in a div with position: relative, and then set position: absolute, top: 0 on the canvas to overlay them.

yep.. that is what i came up with, too, thanks for confirming.  i'm not entirely positive that i want to enforce that inside quagga, but i think i do, if you don't provide an element of your own.

per discussion on #151 I think is the better option -- if you want a drawingBuffer, then specify it yourself in your HTML/CSS setup, we'll search for it, but it shouldn't be created for you.

@coolcorey Sorry, but for the novices could you provide a simple example of how you got this working? Right now I'm just using something like this:


value is missing for lines in a street address

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
master
Issue Description
In the admin panel the lines in a street address is missing a value

Preconditions
The issue occurs in the master branch
Steps to reproduce

in the admin interface click on Configure
Click on Address in the Customer section

Expected Result
the current value should be visible.
Actual Result
Check the description.
Screenshots
No response
Additional context
No response

@ghermans
Thank you so much for bringing the issue to light. We would love to inform you that we have fixed the issue, and it is working fine now. Please check the screenshot for reference here.
You can check the PR here.
Thank you.

Checked and found that the admin configuration for address line. Value has been added, hence I am closing the issue and PR has been merged. Please check the video for reference.
Video
https://github.com/bagisto/bagisto/assets/92721837/527a1169-0adb-4c36-be75-6daa1e85cc8d


Ingress is moving in K8s 1.22, we need to update our Ingress generators

Expected Behaviour

When using K8s 1.22 and newer, use the new namespace for ingress, for older use the deprecated API (apiVersion: extensions/v1beta1)
Current Behaviour

Only uses the deprecated API
Possible Solution

Update openfaas-ingress and any other code that generates ingress definitions the same way.
Steps to Reproduce (for bugs)

Start minikube or kind with K8s 1.22
Try to install openfaas, then openfaas-ingress
It should fail

Context
Blocks users from using these features.
https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes
https://github.com/alexellis/arkade/blob/master/cmd/apps/openfaas_ingress_app.go#L288

/add label: help wanted,good first issue

I can take this one if no one is interested in it 🙋🏻♂

Great, this is time sensitive, I expect users to start complaining next week when 1.22 gets released to Minikube etc.
Can you start with a PR for the openfaas-ingress app?
The Kubernetes version is readable from the code already, and we may already use it somewhere.
Alex

After #462 deprecated ingress template configurations are still generated for docker-registry-ingress app with Kubernetes version 1.22 as there is a missing check to switch the templates in registry_ingress_app.go at line 111. The check is there in the openfaas_ingress_app.go file so that one works.
References:

(master branch) registry_ingress_app.go#L111
(master branch) openfaas_ingress_app.go#L201
(PR commit) registry_ingress_app.go#L111
(PR commit) openfaas_ingress_app.go#L201


Rework Base Design

The base design is hard-wired to a specific type of analysis of the model.
To become more flexible, we need to drop all the TracTopic and simplify the model to what it actually is: the information provided by the input text document.
Analysis can then be applied loosely coupled (with later issues).

TODO

re-add unit test coverage
update readme


New version of cppzst (2.0.7) breaks package

The cppzst package was refactored considerably and the wrapper for KafkaJS is not working with the version 2.0.7.
I looked at the cppzst changes and they refactored to an ECMA module with an index.mjs file which is not supported by typescript at the moment.
They also wrapped compress/decompress in promisify themselves so some parts of the KafkaJS wrapper are not needed anymore.
Installing cppzst 2.0.6 explicitly fixes the issues currently.
I would recommend changing the dependencies of the package to exactly 2.0.6 for now to allow for an issue less installation.
Not sure how to deal with the .mjs import (probably wait for typescript support eventually).

^

v0.1.1 has been released with the workaround from #4. I'll keep this open as it's still an issue that we are stuck on this version of cppzst.


Reclassify website badge as other

It's really not a downloads badge.
As we're considering our groupings, it might be nice to add an Uptime section for this + UptimeRobot. I'm open to doing that now if folks think we should.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

  Generated by :no_entry_sign: dangerJS

👍for Monitoring. Shall I update this PR to add that?

Yeah, why not..


Customize my Webpage- View my website button from myHQ doesn't take me to Consultants webpage & URL is different

Expected behavior
When you click view my Website button from myHQ it should take you to see that consultants webpage
Actual behavior
After making edits to customize my webpage, I clicked on the view my website button and its not taking me directly to the consultants webpage.

it takes me here... https://tastefully-simple-sandbox-2.mybigcommerce.com/

but should take me here to the consultants web page

It shows that the WebURL is https://tastefully-simple-sandbox-2.mybigcommerce.com/web
But in myHQ it shows my WebURL is   https://www.tastefullysimple.com/web/kjo

Steps to reproduce behavior
Using Consultant # 187769 Kylie Jo----- password is Beerbread1!
Go to myHQ and click Market my business
Customize my website
click about me
Shop or Host with me
enter text in text box and click save to update the webpage

This is ready for testing.

Fixed - Closing- thanks!


support page and other updates

support page and other updates

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

MicrosoftCollaboratePortal/package-downloads.md
:white_check_mark:Succeeded

MicrosoftCollaboratePortal/registration.md
:white_check_mark:Succeeded

MicrosoftCollaboratePortal/support.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Multipart form data body is 0

Issue Title
The body of the receiving controller action of a multipart form data request is 0
General
So in short, I have two applications the FE and the API.
From the FE a user needs to upload a big file thus we use the code provided https://docs.microsoft.com/en-us/aspnet/core/mvc/models/file-uploads
Ajax -> FE -> API.
The Ajax to FE works fine, but the FE to API send 0 body length. Although their controllers use the exact same code from the ms link.
On the API receiving end I see the following (see exception)

I do not know why this happens.
'section.Body.ReadTimeout' threw an exception of type 'System.InvalidOperationException'
Following is the code I use.
FileStream targetStream = System.IO.File.Create(targetFilePath);
                        await section.Body.CopyToAsync(targetStream);
                        Console.WriteLine($"Copied the uploaded file '{targetFilePath}'");

                        if (await _api.UploadFile(id, contentDisposition.FileName.Trim('"'), targetStream))
                        {
                            return BadRequest("Failed to upload file");
                        }

which on its own calls

Client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", _session.AuthenticationToken());

            Client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));

            MultipartFormDataContent form = new MultipartFormDataContent();

            HttpContent content = new StringContent("fileToUpload");
            form.Add(content, "fileToUpload");

            content = new StreamContent(stream);

            content.Headers.ContentDisposition = new ContentDispositionHeaderValue("form-data")
            {
                Name = "fileToUpload",
                FileName = fileName
            };
            form.Add(content);

Upon sending the stream has Body length.
But upon receiving on the API it is empty.
`        [HttpPost("{id}")]
[DisableFormValueModelBinding]
public async Task Upload()
{
string displayUrl = HttpContext.Request.GetDisplayUrl();
var arrayUrl = displayUrl.Split('/');
string metricId = arrayUrl.ToList().Last();
        if (!this.IsMultipartContentType(Request.ContentType))
        {
            return BadRequest($"Expected a multipart request, but got {Request.ContentType}");
        }

        string targetFilePath = null;

        var boundary = this.GetBoundary(
            MediaTypeHeaderValue.Parse(Request.ContentType),
            _defaultFormOptions.MultipartBoundaryLengthLimit);
        var reader = new MultipartReader(boundary, HttpContext.Request.Body);

        var section = await reader.ReadNextSectionAsync(); <-- section.body = 0

}`
I also tried with postman, which generated the code bellow ( I dont know which format is best )
curl -X POST \
  http://localhost:5000/api/cloudstorage/08d4df1d-29a6-b421-9c77-df96f63c9f83 \
  -H 'authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9..hgj-C2Z4-ZcP6mDd7wIm7AVyWF0EzZwbvP6BIVzMKMs' \
  -H 'cache-control: no-cache' \
  -H 'content-type: multipart/form-data; boundary=----WebKitFormBoundary7MA4YWxkTrZu0gW' \
  -H 'postman-token: 03f0b075-654d-2164-5f7c-bf1fa3277deb' \
  -F 'file=@C:\Users\AAA\AppData\Local\Postman\app-5.1.2\content_resources_200_percent.pak'

moved to: https://github.com/aspnet/Home/issues/2230


Unit testing category

Added Test cases for Category

@chaitanya005 can you resolve the conflict

@iMagesh  resolved conflicts magesh please check it


Fix code scanning alert - Database queries should not be vulnerable to injection attacks

Tracking issue for:

[ ] https://github.com/madfauzy/eBook-Apps/security/code-scanning/7

This project use procedural style


EPMRPP-80453 || Not found 404 page

Is that how it should be?

Is that how it should be?

I've set screen size var for mobile like in core, but now it's like in figma example


Career Pages Adjustments from Design

A batch of changes from @duelj based on his feedback in JIRA
Changes

Changing job posting date heading level
Adjusting spacing between sidebar modules
Mobile Module spacing adjustment
Fixing Horizontal rule spacing inconsistency

Testing

Visit /careers/ and look for the following

there should be appropriate spacing between modules on mobile
The job posting dates should be the same as the other job posting dates in the sidebar
All horizontal rules should be the same size

Notes

This corresponds to JIRA issues: DF-2228, DF-2229, DF-2230, DF-2231

One sec. I just hopped off a hangout with @ajbush and have a few more adjustments.

Okay, adjustments made. @ajbush helped me out with this.
Apparently there should be about 60px of spacing between each block and 30px between the border and the top of a block under a border. This was tricky to do since .block__sub stacks margins and just using normal blocks doesn't get the appropriate spacing between the border and top of the block.
I'm not crazy about this markup, so feel free to offer alternatives to explore.

Looks good and can't think of any way to reduce the markup so :+1:

:+1:


Initial architecture

Hello @tonivdv ,
The comments you gave in the previous PR are addressed here. I created a OasServiceFactory so that we do not have to pass the credentials to each service and did more re-factoring.
You mentioned that its better if AbstractOasService implements an interface. What methods should we have in this interface?
Let us know how we could improve the structure. :)
cc @gunith

You mentioned that its better if AbstractOasService implements an interface. What methods should we have in this interface?

All those that could be exposed to the outside.

You mentioned that its better if AbstractOasService implements an interface. What methods should we have in this interface?

All those that could be exposed to the outside.

All the methods in the AbstractOasService seems inappropriate to be put in an interface. They are all kind of helper methods that should be used internally by the services.

@tonivdv
We addressed the review comments. A StatefulDomain class was implemented to keep the state of modified attributes in domain objects, so that we can pass only the modified attributes to oas. Let us know what you think of this approach, and whether there is a better way to do it.

All the methods in the AbstractOasService seems inappropriate to be put in an interface. They are all kind of helper methods that should be used internally by the services.

Then all methods in the abstract class should be protected ... however a lot are public and thus open to the outside. Just my 2cents ;)

Then all methods in the abstract class should be protected ... however a lot are public and thus open to the outside. Just my 2cents ;)

Yes that's right they should be protected and not public :) We will correct it

Hello @tonivdv ,
We have addressed the comments that were noted in the last review and have completed the implementation. Please can you review this PR again :)  cc @gunith
Piumika

@piumika Could you update the README by explaining how we can use this api client. Thx

@tonivdv I updated README with instructions

Maybe it's normal but aren't there missing Default implementations?

Hello @tonivdv ,
All the services that are exposed in the API have default implementations and interfaces. Only OasApiService which is a class that is used internally does not have an interface. Did you mean this class or something else?

@piumika No I had it on the DefaultCampaignService etc, but I think it's because github doesn't let me see all the files because there are too many.

Actually no, when I look at https://github.com/adlogix/appnexus-oas-java-client/tree/initial-architecture/src/main/java/eu/adlogix/appnexus/oas/client/service/impl I don't see the default implementations. I would also not use 'impl' as package , but rather than default too :)

Sorry I have not added the new files to github, can you check again please. I also wanted to use default instead of impl for the package but since default is a java keyword it doesn't allow me to do so .

@piumika then I would keep them in the same package ... no need to subpackage them at this moment

@tonivdv did the changes to keep default services in same package


Fixed Diff Keeps Increasing

If there is no shares in the retargettime period, the diff will keep increase as the avg becomes 0.
the ddiff will become INF.
Changed to do nothing when the TimeBuffer.Size is 0.

Incorrect Fix.


calicoctl node diags is still using obsolete 'netstat' tool instead of 'ss'

Expected Behavior
Example from https://docs.projectcalico.org/reference/calicoctl/node/diags
$ sudo calicoctl node diags
Collecting diagnostics
Using temp dir: /tmp/calico676127473
Dumping netstat
Dumping routes (IPv4)
Dumping routes (IPv6)
[...]

Current Behavior
socket information is not collected as netstat tool is obsolete and removed in Ubuntu and other distros.
gosekar@gosekar-k8s-master:~$ sudo calicoctl node diags
Collecting diagnostics
Using temp dir: /tmp/calico662105980
Dumping netstat
Failed to run command: netstat -a -n
Error:
Dumping routes (IPv4)
Dumping routes (IPv6)
[...]

Possible Solution
ss -an should be run if netstat -a -n fails
https://github.com/projectcalico/calicoctl/blob/9e38edf150db3044f81c2a0ccaaca3125c04056c/calicoctl/commands/node/diags.go#L91
Steps to Reproduce (for bugs)
Run calicoctl node diags in latest distros
Context
Trying to simulate log collection for troubleshooting kubernetes+calico environment
Your Environment

calicoctl version (e.g. calicoctl version):

gosekar@gosekar-k8s-master:~$ calicoctl version
Client Version:    v3.20.0
Git commit:        38b00edd
Cluster Version:   v3.20.0
Cluster Type:      k8s,bgp,kubeadm,kdd

calico/node version (e.g. docker run --rm calico/node versions)

gosekar@gosekar-k8s-master:~$ kubectl exec -it calico-node-l6tng -n kube-system -- /bin/calico-node -v
v3.20.0

Orchestrator type and version (e.g. kubernetes, mesos, rkt):
Kubernetes 1.22.1
Operating System and version:
Ubuntu 20.04.3 5.4.0-81-generic
Link to your project (optional): Nil

hi everyone! I want to work on this issue, can I have it ?

@cyclinder Thanks, calicoctl node diags is using netstat command which is obsolete. I believe it should use ss -an instead.

Closed via https://github.com/projectcalico/calico/pull/5336