braces fixer mess with inline comment indentation

robert@robert-laptop:~/Poligon/php-cs-fixer$ php -v
PHP 7.1.8-2+ubuntu16.04.1+deb.sury.org+4 (cli) (built: Aug  4 2017 13:04:12) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.1.8-2+ubuntu16.04.1+deb.sury.org+4, Copyright (c) 1999-2017, by Zend Technologies

robert@robert-laptop:~/Poligon/php-cs-fixer$ vendor/bin/php-cs-fixer -V
PHP CS Fixer 2.2.5 by Fabien Potencier and Dariusz Ruminski

Config:
$config = PhpCsFixer\Config::create()
    ->setRiskyAllowed(true)
    ->setRules([
        'braces' => true,
    ])
    ->setFinder(
        PhpCsFixer\Finder::create()
            ->in(__DIR__)
    );

return $config;

Command:
robert@robert-laptop:~/Poligon/php-cs-fixer$ vendor/bin/php-cs-fixer fix

Diff:
diff --git a/test1.php b/test1.php
index 7ab983e..f0174cd 100644
--- a/test1.php
+++ b/test1.php
@@ -1,17 +1,17 @@
 <?php

 class A
 {
     public function b()
     {
         if (true) {
             $this->doSomethingElse();

-//            if ($extension === 'composer') {
+            //            if ($extension === 'composer') {
 //                return [];
 //            }
         } elseif (false) {
             $this->doSomethingElse();
         }
     }
 }

Expected result is to not changing anything - such comment does not meant to be indented in any way. But I'm not sure why braces fixer touch this comment - it looks completely unrelated.

is it still happening if you update to newest 2.4.0 ?

is it still happening if you update to newest 2.4.0 ?

Yes. Same for dev-master.

It worked fine in 2.2.4, so I guess that https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2849 could broke something.

That's sad.
do you want to help us by investigating it deeper and sending a PR fix ?

actually @julienfalque , isn't it the edge case we were discussing ?

#2987

@keradus No, if I remember correctly, the edge case we discussed was when several single-line comments are used to write a multi-line comment, e.g.:
if ($foo) {
    // some
    // long
    // message
    foo();
}

ok, thanks for info.
could you review this PR please?


Make TextField more universal and relax syntax

Description
I noticed that the TagsField class is not DRY, it has a lot of repetition of the code of the TextField class.
This PR makes the TextField class a bit more universal by also supporting fields with multiple values, so that it can be used as base class for the TagsField as well, and we do not need that code repetition.
In the case of the tags field, the filter syntax now also allows the plural forms, i.e. instead of tags regex matches and tags regex does not match you can now also write the grammatically better sounding tags regex match and tags regex do not match. The regex clause can now also be spelled as regexp or even be left out completely, so you can also simply write tags match or tags do not match.
Motivation and Context
Making the TextField more universal avoids repetition in the code and makes it easier maintainable.
The alternate spelling regexp for the regex clause has been requested in #1143 because it is frequently used, e.g. in JavaScript.
Making the regexp clause optional makes the syntax easier to read and write. The slashes and the matches clause make it sufficiently clear that this is a regular expression match.
What still needs ot be done
I have not yet updated the documentation, because I first want to check if this PR is generally accepted in that form. Also, we should declare one of the syntax variants as the "standard syntax" that should be used everywhere in the docs and examples, and we must decide which one. My suggestion is to leave out the regex clause, and use the plural form for tags as standard syntax.
How has this been tested?
I have added parametrized tests for the various syntax variants in TagsField.test and DescriptionField.test.
Everything should be backward compatible. I.e. I did not try to forbid the current singular spelling even though it is grammatically not correct.
Types of changes
Changes visible to users:

[ ] Bug fix (prefix: fix - non-breaking change which fixes an issue)
[x] New feature (prefix: feat - non-breaking change which adds functionality)
[ ] Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (prefix: docs - improvements to any documentation content)
[ ] Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)

Internal changes:

[x] Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
[x] Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
[ ] Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

[x] My code follows the code style of this project and passes yarn run lint.
[x] My change requires a change to the documentation
[ ] I have updated the documentation accordingly - see above
[x] My change has adequate Unit Test coverage.

Terms

[x] My contribution follow this project's contributing guide
[x] I agree to follow this project's Code of Conduct

Hi @Cito I have spent hours pondering how to respond to this, and gone round in circles on how to express it.
Sorry, but this PR is too complex, and I would like it to instead be two separate PRs please. ("Make the change easy, then make the easy change")

A pure refactoring, that (presumably) shows the benefit of removing duplication of code between the two classes that is not then outweighed by increased code complexity.
A discussion in #1143 to decide what the new search options should be, and which would become the preferred one, for the docs.

In fact, it's likely that 2. would generate a much shorter list of changes to the options than in this PR, which might in turn reduce the value of combining together the two classes.

From my notes:

TextField.createFilterOrErrorMessage()

Before: 35 lines
After: 53 lines

TextField.filterRegexp()

Before: 1 line
After: 9 lines

Hi @claremacrae - thanks for the review and sorry for making you headaches. Originally I only wanted to make that minor syntax relaxation but then got carried away. I agree I should have split this into several parts. Actually I think I should make it four simpler PRs, in this order:

refactoring to remove duplication in TextField and TagsField (using a better design, fixing the flaws of this PR)
allow plural forms like "do not include" instead of "does not include"
allowing "regexp" instead of "regex"
making "regex" optional

Does this sound good to you?

Hi @claremacrae - thanks for the review and sorry for making you headaches. Originally I only wanted to make that minor syntax relaxation but then got carried away. I agree I should have split this into several parts. Actually I think I should make it four simpler PRs, in this order:

refactoring to remove duplication in TextField and TagsField (using a better design, fixing the flaws of this PR)
allow plural forms like "do not include" instead of "does not include"
allowing "regexp" instead of "regex"
making "regex" optional

Does this sound good to you?

Thank you. Those sound like they would be very quick to review.
Yes to 1 2 & 3.
I am unhappy with 4 though. I did write up the reasons earlier, but they may have got culled from one of my draft replies.

Closing, as by agreement, this is going to be replaced by some separate, smaller PRs.


5.201 - Email Text not displayed

Expected behavior
Tell us what should happen
Email Text should be displayed
Actual behavior
Tell us what happens instead
Content/Text of Email is not being displayed.
Is it of the signaure of the mail?
As it is from a public mailing list, I attach the mail
[opensuse-factory] updating tumbleweed - best practices.zip
Steps to reproduce

Environment
K-9 Mail version: 5.201
Android version: 6.01 / S7 Edge
Account type (IMAP, POP3, WebDAV/Exchange): IMAP

This message is displayed correctly for me in 5.201. It's possible the message got mangled during the database migration to 5.200 though.. can you try redownloading the message, and see if the error persists? You can do that by going to folder view, long-clicking a folder, then selecting "Clear local messages", which will cause all messages in that folder to be downloaded again.

No, the message arrived after database conversion. I cleaned the local files as recommended, but result is the same (see sreenshot).
The reason why I feel the encryption/signature is the problem - on a different mail I wanted to send I got the error message 'Connection to encryption service failed. Check the settings.... '. I was unable to send the mail. Although I have APG installed, K9 says 'no openPGP App installed'

APG is unmaintained and insecure. Support was dropped in 5.200

Alternative?

use OpenKeychain instead.

Thanks for the hint! I installed OpenKeyChain, and afterwards the message is displayed correct! So it seems to be a missing dependency?

My guess is this happens when APG was selected as crypto provider before updating to 5.2xx. We should probably point out an incompatible crypto provider to the user when the app attempts to use it.

I thought we considered it the same as having no crypto provider - that certainly seemed to be the intent in the code?


Advanced Features

I don't think it is possible but I thought I would ask

Is there a way to redirect the user to another room that is not a child of the current room.  For instances, I would like to have an option to open a door that will return the user to the first room.
Is there a way to change the availability of a room.  For instance, a room has a door and a switch. The door is locked until the switch is pulled. Then the door is open.

Did you ever figure this out?


Upgrade<EMAIL_ADDRESS>

Easy upgrade and doesn't conflict with other open PR's.
Close #100

Thanks @snewcomer! It looks like there are several lint issues keeping tests from passing in CI. Do you mind cleaning those up?

Thanks @snewcomer!


Resque.set_schedule feature

Hello.
In our company we use Resque.set_scheduler method and we use your gem, I have found that there is lack of testing for it. I added those methods and rspec tests for it.
I think it is a good feature that needs your review.

I updated readme, so you can check for detailed usage of it


[26.x] WFLY-16030 WildFly Infinispan subsystem CustomStoreServiceConfiguration to use modules configuration attribute as a List of modules

https://issues.redhat.com/browse/WFLY-16030
Upstream PR: https://github.com/wildfly/wildfly/pull/15280

Thanks @pferraro


ASM: eol comments garble following instructions

(Original issue 1477 created by vermiculus on 2018-09-27T00:04:48.023515+00:00)
See
echo 'ADD result 42 18\nMUL prod result 7\nDISPLAY prod' | pygmentize -l asm

vs
echo 'ADD result 42 18\nMUL prod result 7;\nDISPLAY prod' | pygmentize -l asm

(Original issue 1477 last updated on 2019-01-16T19:53:52.196565+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by wentasah on 2018-11-26T17:10:30.332258+00:00)
I've sent a pull request to fix this: https://bitbucket.org/birkenfeld/pygments-main/pull-requests/784/fix-handling-of-end-of-line-comments-in/diff

(Original comment by vermiculus on 2018-12-02T19:00:01.781570+00:00)
Thank you!

(Original comment by Anteru on 2019-01-16T19:53:52.247737+00:00)
The PR has been merged, thanks for reporting this issue!


What's the difference compared to native tensort sdk?

I used to convert a pytorch model to onnx format,and try to run it using native TensorRT SDK,but I failed for some operators in model is not supported by trt sdk; So if I use Torch-TensorRT to run the model, will I still have the same problem? Is there any more operators added compared to the native trt sdk?

ONNX-TensorRT and Torch-TensorRT are not 1:1. Likely there is more operations natively supported in ONNX-TensorRT right now but 1. TorchScript IR and ONNX are different and maybe the TorchScript version of your model can be supported by Torch-TensorRT easier. 2. Torch-TensorRT allows you to partially compile your model so operations that are not currently natively supported can still run in PyTorch while the parts that can be compiled to TensorRT will be run in TensorRT


wrapJavaJar: init

This adds a function to automatically wrap java jars, as I noticed a lot of packages do it manually right now. Usage should look something like this:
wrapJavaJar {
  pname = "foo";
  version = "1.0";

  src =  fetchurl { ... };
}

Which will create the following directory structure:
├── bin
│   └── foo
└── share
    └── java
        └── foo.jar

Where bin/foo is a simple wrapper that executes java -jar $out/share/java/foo.jar, which gets copied from src. It also has a few optional flags, refer to the added documentation for more info.
This should make packaging java applications contained in a single jar take significantly less effort. If it gets merged, I plan to switch over the derivations i know are doing this manually.
Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Not completely against this, but wouldn't it be better to have it as a build hook instead thinking ?
I feel like this adds too little to be really useful, and if you need something more complex you will end up wrapping anyway, where in a build hook we could just use it as part of stdenv.mkDerivation instead.

BTW, how I imagine this as a build hook:
{ stdenv, jre, wrapJarHook }
stdenv.mkDerivation {
  javaExecutable = "${jre}/bin/java"; # default
  jar = "${placeholder 'out'}/bin/${pname}"; # default
  nativeBuildInputs = [ wrapJarHook ];
  makeWrapperArgs = [ "--something" ];
}

The advantage of the above is that it is composable, e.g.: we can build the jar from source and wrap it, while the current approach assumes the jar is always coming from a binary build.

Other things that might be useful in a build hook include patching native binaries in the .jar and scanning files packed in for references much like I had to add for sweethome3d: https://github.com/NixOS/nixpkgs/pull/171480

Having a plain shell function similar to wrapProgram that you can call in the package postInstall would be nice. Something like
postInstall = ''
  wrapJavaProgram \
    --jar $out/share/java/foo.jar
'';

Could support options such as --java for path to Java interpreter, --output to override the output path in /bin, etc.

Having a plain shell function similar to wrapProgram that you can call in the package postInstall would be nice. Something like
postInstall = ''
  wrapJavaProgram \
    --jar $out/share/java/foo.jar
'';

Could support options such as --java for path to Java interpreter, --output to override the output path in /bin, etc.

Yeah, this is also an option. Would still need be inject using a hook though, and at that point I would be more inclined of having a default postInstall implementation so I can pass arguments using Nix instead of Shell. Maybe:
{ stdenv, jre, wrapJarHook }:
stdenv.mkDerivation {
  nativeBuildInputs = [ wrapJarHook ];
  wrapJavaCommandArgs = [ "--something" ];
}

But I think it can go either way and also just exposing the shell function is also fine.

@IvarWithoutBones dropping out, re-add or ping me if you have converged on a solution, and I will review docs.


What settings should I use in order to get the location at least every 5 minutes? even when the device is standing?

Your Environment

Plugin version: 2.3.2
Platform: Android
OS version: 4.4.2
Device manufacturer and model: eboda Storm X450 II
Cordova version (cordova -v): 7.1.0
Cordova platform version (cordova platform ls): android 5.2.1
Plugin configuration options:
backgroundGeolocation.configure(callbackFn, failureFn, {
desiredAccuracy: 100,
maxLocations: 1,
stationaryRadius: 20,
distanceFilter: 20,
interval: 30 * 1000, //android
fastestInterval: 5000,
activitiesInterval: 10000,
debug: false,
stopOnTerminate: true,
notificationTitle:'GetexGo',
notificationText: 'Running in background',
pauseLocationUpdates: false,  //ios
saveBatteryOnBackground: false, //ios
activityType: 'AutomotiveNavigation' //ios
// notificationIconLarge: 'icon-36-ldpi', //filename without extension
// notificationIconSmall: 'icon-72-hdpi'  //filename without extension
});
Link to your project: https://play.google.com/store/apps/details?id=com.enovator.getexgo&hl=en

Context

Thanks for the nice work of developing this owsome plugin!
This is not a bug, but a misconfiguration of the plugin!
We would like to get drivers position at every 1-3 minutes. we need to track them down on the road.
when they have the app started, even in background, we should get their position even when standing at every few minutes.
Expected Behavior

We did setup the interval parameter at every 30 seconds, but the plugin is not launching the callbackFn callback function when the driver is standing... not even after 1-2 hours. the callback is being launched only after the drivers starts moving again.
we would like to know what is the right setup (parameters) in order to achieve this!
Actual Behavior

Possible Fix

What are the correct parameters for the plugin in order to achieve my goals?
Steps to Reproduce

Context

Debug logs

if I've read more carefully the documentation... it would have been easier! solved!


fix(supabase)!: make Supabase credentials private in SupabaseClient

What kind of change does this PR introduce?
Make the following private, because users shouldn't need to access them using the client library.

Supabase Key
Supabase URL
realtime (RealtimeClient instance)
rest (PostgrestClient instance)

Additional context
I feel like there might have been a use case where the rest needed be public, but I cannot find the issue that had context about it. I feel like it had something to do with headers, which I think should now be solved since we expose a setter, but if anyone has a use cases for any of these to be public, please do let me know!
Edited:
Not making rest and realtime private https://github.com/supabase/supabase-flutter/pull/649#issuecomment-1743710220

@Vinzent03 Thanks for the reminder. Made rest and realtime public again.


update vol 19 ch 1 and add dummy build workflow

I really like the idea of a deploy pipeline but currently, we cannot do that since the build process produces not only the transformed HTML templates but also genernes multipde epub, pdf, and other files which requires manual intervention to deploy/distribute. Additionally, not every update requires a release (such as code changes or updates to unreleased work).

Is it possible to push files to google drive and mega? Maybe using rclone, but not sure.
Only other problem is getting a docker container for the janky build script. It really only works on Linux, but that's a good thing in this case for docker. It's python code that relies on calibre, inkscape, sed, and tectonic (the latex compiler).

If pushing to those cloud services works, I guess getting the python to work in a container wouldn't be too bad.
I have a working package, so I can put a whl file into this repo soon, pip will then take care of all the other python dependencies at least (poetry would probably be good to keep that contained, but I haven't used that before.)
The inkscape dependency is due to generating the chapter cards on the fly, which involves patching a template svg file's xml code, replacing placeholders with specific color and text values. I use os.system to call sed to do that replacement and then pipe it into inkscape. I tried to pipe the patched xml into inkscape using subprocess stuff, but it just wouldn't work :/
I do use subprocess.check_output for calling the latex compiler, so that's nice. Anyway, it does at least work, and won't be a problem on ubuntu.
I'd need to put some api secrets into an ENV file for those cloud services, probably not very hard.
I'm currently tweaking the builder a bit to have it  output colored vs non-colored outputs separately, rather than separate them by ebook vs pdf, should be done in a bit. That'll make it easier to sync with the cloud services, since that's how I have them separated there too.
I also have a checker that tries to set some baseline standard for the markdown files, to ensure they will probably compile. I'd probably be nice to run that as a commit action. How best should I modify the output so I can indicate if any errors were detected (it does warnings (some false positives) and errors (always bad)). Is a specific return value a smart idea? Maybe not. You can dig though the source code in the whl if you like in a bit.
This is the cli usage, at least:
Slime Builder

Usage:
    slime-builder build pdf [<source_dir>] [--all] [--dark-theme] [--color-edition]
                  [--latex] [--internal-font=<font_path>] [--debug]
    slime-builder build epub [<source_dir>] [--all | --color-edition] [--skip-other-formats] [--debug]
    slime-builder build reader [<source_dir>] [--terms=<terms_file>] [--debug]
    slime-builder build all [--only=<source_dir> | --from=<source_dir>]
                  [--only-pdf | --only-epub | --only-reader]
                  [--terms=<terms_file>] [--internal-font=<font_path>] [--debug]
    slime-builder check [<source>] [-e | --errors-only] [--debug]
    slime-builder extract-terms <spreadsheet> [--output-path=<terms_file>] [--debug]
    slime-builder unpack <zip_file> [--debug]
    slime-builder pack [<source_dir>] [--debug]
    slime-builder convert-legacy <docx_file> [--debug]
    slime-builder config [--debug]
    slime-builder clean [<source_dir>] [--all] [--deep] [--debug]
    slime-builder (-h | --help | --version)

Subcommands:
    build                 Build one or more formats from the source directory.
        pdf               Build a PDF from the source directory.
        epub              Build an EPUB file from the source directory.
        reader            Build html for Slime Reader from the source directory.
        all               Build all formats from the source directory, or only the specified directory/format.
                          You can set a base directory to search for source directories from, by default the current
                          working directory is used.
    check                 Check the source directory or single file for errors. Static analysis only.
    extract-terms         Extract terms from a spreadsheet and output them as a JSON file.
    unpack                Unpack a zip file of a project. The contents are placed in a subdirectory of
                          the zip file's directory. This is meant for the docx files stored in a google drive.
                          The files within are cleaned up and automatically converted to plain text.
    pack                  Pack a markout project directory into a zip file.
    convert-legacy        Convert a legacy docx file to a markout project directory.
    config                Show the config file path and contents.
    clean                 Clean a source directory or all subdirectories, if they are markout projects.
                          This removes all temporary tex files.

Options:
    <source_dir>                  The directory containing the source files. By default, the current working directory.
    <source>                      The markout source directory or file to check.
    <zip_file>                    The zip file to unpack.
    <docx_file>                   The legacy docx file to convert.
    <spreadsheet>                 The spreadsheet to extract terms from. Most formats supported, including .ods, .csv, .xls, .xlsx. etc.
    --all                         Build all formats, not just the one specified.
    --only=<source_dir>           Only build the specified source directory.
    --from=<source_dir>           Only build source directories from the specified directory.
    -P --only-pdf                 Only build the PDF format.
    -E --only-epub                Only build the EPUB format.
    -R --only-reader              Only build the Slime Reader format.
    -d --dark-theme               Use the dark theme for the PDF.
    -c --color-edition            Use the color edition for the PDF/EPUB.
    -s --skip-other-formats       Skip converting to other formats (currently mobi and azw3) when building the EPUB.
    --terms=<terms_file>          The terms file to use for the Slime Reader. This is cached in the config.
    --internal-font=<font_path>   The path to the font file to use for aligning labels in the PDF. This is cached in the config.
    --output-path=<terms_file>    The path to the output terms file. By default, the terms file is placed in the source directory.
    --deep                        Clean up the generated images, pdfs and epubs as well.
    -l --latex                    Output the latex source files instead of compiling them.
    -e --errors-only              Only show errors, not warnings.
    -h --help                     Show this screen.
    --debug                       Do not clean up the output directory and show debugging information.
    --version                     Show version.
    ```

The most relevant ones being `slime_builder build all` and `slime_builder check` I'd guess. Those can be used within a specific source folder.

Ah, right, that's the correct (github) way to do this.
Oh yeah, the fonts used should probably just get bundled into the .whl, otherwise it'll just get too messy with the container.

All right, once you rebase you should find the slime builder wheel file. That's just a zip so feel free to look at the source code if you want. The pdf uses Liberation Sans and Liberation Serif, as well as Noto Serif CJK JP.
Also, the other important argument for building the volumes is the internal metrics font, which should be a path to liberation serif. It's used for some font width pre-calculation dark magic to get latex to indent list labels just right.
For me at least, "/usr/share/fonts/liberation/LiberationSerif-Regular.ttf" works. I figure ubuntu has it in the same place.
The liberation fonts will be pre-installed, but I have my doubts about the "NotoSerifCJK-Regular.ttc" already being there.
Lastly, the --terms argument needs to point towards the tensurafan.github.io/ln/terms.json.
You can also configure the last 2 paths via a config file in XDG_CONFIG/slime_builder.json:
{
    "IMG_DIR": "illustrations",
    "COLORED_IMG_DIR": "colored_illustrations",
    "READER_HTML_DIR": "../../",
    "READER_IMG_DIR": "ln/sources/{volume_str} {volume_number}/",
    "OUT_DIR": "output",
    "OUT_DIR_COLORED": "output_colored",
    "TITLE_CARD_DIR": "title_cards",
    "FIGURE_DIR": "figures",
    "ENDCARD_FILE_NAME": "endcard",
    "internal_label_font_path": "/usr/share/fonts/liberation/LiberationSerif-Regular.ttf",
    "terms_file_path": "/home/tensurafan.github.io/ln/terms.json"
}

(Everything but the last 2 are default values)
In normal use, after setting the argument once it stores it in that config file, but I don't suppose persistence is provided or desired for an actions docker container.


Remove background averaging

When I was testing calibration using an ROI, I noticed that the background correction changed behavior.
I found that when a calibration ROI was used, the background correction averaged over this ROI then applied that background correction uniformly over the whole image. I cannot think of a reason to average over a FOV within a background image, so I removed this functionality.
This functionality severely reduces the effectiveness of the "Measured" background corrections when calibrating within an ROI. It's also likely that this bug was partially responsible for Yuming's poor background corrections.

Codecov Report

Merging #169 (5aa5f91) into main (bc8344a) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   11.18%   11.21%   +0.02%
==========================================
  Files          45       45
  Lines        5997     5984      -13
==========================================
  Hits          671      671
+ Misses       5326     5313      -13

Impacted Files
Coverage Δ

recOrder/io/utils.py
0.00% <0.00%> (ø)

recOrder/pipelines/qlipp_pipeline.py
0.00% <0.00%> (ø)

recOrder/plugin/widget/main_widget.py
0.00% <0.00%> (ø)

recOrder/plugin/workers/acquisition_workers.py
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Do you think a warning is still needed since we are altering the behavior of the pipeline?

I think I removed the warning and decided to completely remove the background averaging.
I initially thought I was going to just add a warning, then I changed my mind and decided to remove background averaging. Sorry I didn't do a very good job cleaning up after myself: the warning is still in the commit history and in the name of this branch.

Sorry I didn't do a very good job cleaning up after myself: the warning is still in the commit history and in the name of this branch.

I wasn't making it clear, but I was suggesting adding the warning back (with different articulation) so that any user who was relying on that bug/feature would be advised of the change we are making. Although the previous behavior was more like a bug, this 'breaking' change still alters the output value of the pipeline if, for example, someone would like to revisit their previous analysis.

Aha! Excellent point. I didn't maintain backwards compatibility.
I've reverted the changes, added a warning, fixed the bug, and added reminders for what needs to be removed for 1.0.0.
Thanks Ziwen...great catch.


add transport and subclasses

…te transport

add transport as a subclass of process
add international transport, freight transport, public transport and private transport as subclasses of transport

closes #503

It's implemented within oeo-social. I think, it should be either part of oeo-physical or oeo-shared. If we want to include e.g. relations like vehicle participates in transportation this becomes necessary.

That sounds reasonable. I will move it to oeo-shared since both physical things like vehicles (as you mentioned) and social things  like humans can be part of the transport process.


Update settings.py

provide better security at user end using password hashes.

Thank you @er-saurav for the support.


tracing: inject the tracing header before the upstream filter chain is started

Commit Message: tracing: inject the tracing header before the upstream filter chain is started
Additional Description:
The https://github.com/envoyproxy/envoy/pull/20503 introduced a unexpected behavior change: that is the tracing headers will be injected after the request_headers_to_add is handled.
It means that users connot access the tracing headers in the request_headers_to_add. But some users require this. Here is the ticket https://github.com/envoyproxy/envoy/issues/23972.
I originally intended to resolve this problem by using the upstream header mutation filter.
However, the upstream filter chain will be started directly without waiting the upstream connection to be ready (unexpected design, why, shorter latency?) But the tracing headers will be injected after the upstream connection is ready. So, the upstream header mutation filter still cannot access the tracing headers in some case.
This PR just make sure the tracing headers injection will complete before the upstream filter chain start.
Risk Level: Low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

hmmmm, why this pr effect the coverage of tap transport_sockets 🤔

https://github.com/envoyproxy/envoy/pull/27382 resolved this coverage problem temporarily.

friendly ping @alyssawilk


ja: Make tutorials/kubernetes-basics/deploy-app/deploy-intro.html follow v1.17 of the original text

Issue https://github.com/kubernetes/website/issues/21369
I referred this doc to fix.
What I'm not pretty confident
I may have to change the 'Output is similar to:' wording to emphasize that users possibly see different output in some part?
Appreciate
Since it's my very first PR for OSS, would be great if reviewers let me know any ideas and preferences where and how to fix or what to do if I missed something, even the smallest details. Thanks you vm for your review.

/assign @nasa9084

@ryokotmng Thank you for contribution!
It seems that the PR title and referenced issue number are wrong.
Could you edit the PR title and description?
Additionally, please comment /assign in the related issue to assign it to you.

Ahhhh, thank you for the advise. Will do quickly!

I think now the title and description are correct, and changed the commit message of the first commit of this PR as well. And I added myself to the issue. Thanks in advance for your review:)

@ryokotmng Thank you, but the description's 1st line is still wrong.
If you write only #21366 instead of https://github.com/kubernetes/website/issues/21366, it will work.

Apologies for my mistake🙇♂ Now fixed!

Good!

Thanks for your comments! Will revise as you kindly suggested🙏 💦

@oke-py Revised and double-checked by myself🙏 you have very good eyes! Would be great if you could go through~:)

/approve
@ryokotmng Thank you for your contribution :)


error waiting for state change for server creation couldn't find resource (601 retries)

Description
We try to create a Cube XXL (640GB Disk) "CS01" that is part of a module. The cube creation timeouts were set to 4 Hours

timeouts {
create :
"4h"
delete :
"4h"
create
update :
"4h"
}

After two hours we are getting the following error and the terraform run errors:

Error: error waiting for state change for server creation couldn't find resource (601 retries)
with module.ABCDE[0].ionoscloud_server.CUBE_CS01
on modules/ABCDE/main.tf line 96, in resource "ionoscloud_server" "CUBE_CS01":
resource "ionoscloud_server" "CUBE_CS01" {

Versions:

Terraform: 1.4.6
IONOS: 6.4.7

The cube finally gets created in IONOS DCD but the issue is with the terraform run being canceled and so all following tasks also cancel.
Expected behavior
Terraform / Ionos should be waiting longer for the cube creation.
Environment
Terraform version:
1.4.6
Provider version:
6.4.7

OS:

Configuration Files

How to Reproduce

Error and Debug Output

Additional Notes

References

UPDATE: as i can see in the source code there is a "NotFoundChecks" counter implementet in the services/cloudapi/state.go file.

Maybe thats the cause for the error. Because we are getting the error message telling us "(601 retries)"

Error: error waiting for state change for server creation couldn't find resource (601 retries)

Should be fixed in latest release


[pcre2] Fix CMake integration.

This PR applies the patch in PCRE2Project/pcre2#260 to fix the previously broken CMake integration.

[X] Changes comply with the maintainer guide
[X] SHA512s are updated for each updated download
[X] The "supports" clause reflects platforms that may be fixed by this new version
[X] Any fixed CI baseline entries are removed from that file.
[X] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Please mark this as draft.

I opened #31929 now to ensure that the pristine update doesn't cause any regressions.
I realize now that the CMake config may be underused (or even unused) in vcpkg (or in general) because we didn't install it due to its poor state. So this PR will probably not give the insight I was hoping for.

Some ports break because they were searching for the PCRE2 library in lib. 😭 https://github.com/pocoproject/poco/blob/a00bfbe89fccabbe3606b31c0a1c7edd3da14e2e/cmake/FindPCRE2.cmake#L69-L77

Some ports break because they were searching for the PCRE2 library in lib. sob https://github.com/pocoproject/poco/blob/a00bfbe89fccabbe3606b31c0a1c7edd3da14e2e/cmake/FindPCRE2.cmake#L69-L77

find_library breaking in vendored Find modules is unrelated to adding official exported CMake config to pcre2.
Port poco doesn't even use this Find module, see patch ports/poco/0007-find-pcre2.patch.

Thanks for your PR. PR https://github.com/microsoft/vcpkg/pull/31929 did update pcre2 to 10.42, it has been merged, please resolve the conflicts.

Any progress here? - Really need PCRE2 for my project (porting libbsd to Windows)

I am waiting for it to get merged upstream in  PCREProject/pcre2#260.

Can we merge it?


Add ability to provide custom key name for media type and query string

Currently, the key names used for both Media Type and Query String are hardcoded as v and api-version respectively. It would be ideal to pass the key name in as a config option to withVersioning().
e.g.
For  Media Type:
withVersioning(axios, {
  apiVersion: '2',
  versioningStrategy: VersioningStrategy.MediaType
  versionKeyName: 'my-custom-api-version'
})

For Query String:
withVersioning(axios, {
  apiVersion: '2',
  versioningStrategy: VersioningStrategy.QueryString
  versionKeyName: 'my-custom-api-version'
})

Maybe keyName can be ignored when the VersioningStrategy is UrlPath.
Something like this: https://codesandbox.io/s/k3j6p446kr?fontsize=14&view=editor

Done. Implemented in commit dc3892f


[NG] Fix datagrid column seperator

Resolves https://github.com/vmware/clarity/issues/669
This fix will be also needed for https://github.com/vmware/clarity/issues/621
Tested on: Chrome, Firefox, Safari, Edge, IE 11, 10
Screenshots:

Signed-off-by: Shijir Tsogoo<EMAIL_ADDRESS>

@youdz having position:relative was solving the separator positioning issue. Also, it was going to be needed for the column resizer. However, with this solution, the filter clipping issue would come back if there are no rows. That's why I set the minimum height which prevents the filter box from getting clipped and go under the.datagrid-table-wrapper. Having a minimum height on  .datagrid-table-wrapper was also pushing the clr-dg-placeholder down when there are no rows. So I placed that inside .datagrid-table-wrapper.
But I will replace this solution with another as this one forces these unwanted collateral changes.


[ENH] add a save config function

Because createJson now only saves a super lightweight version in bold.json, we have no way of tracking what was used for an experiment which will be annoying for reproducibility.
This function should take over and allow some flexibility in terms of output.

fixes #194

3 use cases:
The most common: enough info in cfg to create a filename that ends in _cfg.json in the subject directory and matches the run fielname.
cfg = setUp();
filename = saveCfg(cfg)

filename =
    '/home/remi/github/CPP_BIDS/src/../output/source/sub-001/ses-001/func/sub-001_ses-001_task-testTask_run-001_date-202203181811_cfg.json'

Not enough info in cfg to create a filename
cfg.testingDevice = 'mri';
filename = saveCfg(cfg)

filename =
    '/home/remi/github/CPP_BIDS/date-202203181809_cfg.json'

filename is provided
cfg.testingDevice = 'mri';
filename = saveCfg(cfg, fullfile(pwd, 'cfg', 'cfg.json'))
filename =
    '/home/remi/github/CPP_BIDS/cfg/cfg.json'

Once this is merged, this will be incoporated into the different localizers and experiments.

Rendered doc: https://cpp-bids--193.org.readthedocs.build/en/193/function_description.html#src.saveCfg

As usual, I might have done sth wrong but what I got is a change in _event.json and _event.tsv as well.
sub-066_ses-001_task-mototopy_run-001_date-202203211705_events.tsv
sub-066_ses-001_task-mototopy_run-001_date-202203211705_events.json
In this case, it might be annoying also to change cpp-bids function which removes the suffix.
I used very similar to what I was using this function, so maybe I did use the new function wrong - at the end of the main script of a fmri experiment:
getResponse('stop', cfg.keyboard.responseBox);
    getResponse('release', cfg.keyboard.responseBox);

    % create json for bold
    createJson(cfg, 'func');

    % save config info
    saveCfg(cfg);

    farewellScreen(cfg);
    cleanUp();

catch

    % save config info
    saveCfg(cfg);

    cleanUp();
    psychrethrow(psychlasterror);

end

Just to know, did you just grab that function and added it into your experiment code or did you update the whole CPP_BIDS submodule?

I updated the submodule.

yes exactly. I didn't have time to do a proper check yet. I'll see where the issue stems from this afternoon and write back!

Don't look further: this is normal.
This was changed back there: https://github.com/cpp-lln-lab/CPP_BIDS/pull/186/files?file-filters[]=.m&show-deleted-files=true&show-viewed-files=true#r832040816
Just added a comment to that old PR to help you track it.
The new version convertSourceToRaw now removes this date this way (by realying on BIDS matlab function to create and rename BIDS files):
https://github.com/cpp-lln-lab/CPP_BIDS/blob/ab06459710a19389183367cd5220d35bc521ea0f/src/convertSourceToRaw.m#L47

Will merge this as we sort of need it for our next testing session (not essential but I would prefer to have it)

Cool!
here is my update on the matter.
I do not use that bold.json from cpp-bids output anymore. What do I mean by "use"?

I updated cpp-bids submodule in my exp presentation scripts, so there’s no extra column in the .tsv files produced for onsets. (side information)

I’m saving config.json output from cpp-bids . But that is for me to save stuff in source folder. All the config files are saved! I also save bold.json currently, but I do not use those anymore in any analysis.

For analysis (raw and derivatives) I am using heudiconv converter’s bold.json files. So it does extract the sliceOrder information, therefore in my scripts e.g. setParameters I do not need that sliceOrder info to be saved onto cpp-bids bold.json file.
And heudiconv generated bold.json files are passing bids-validator, cpp-spm, and MRIQC.

Cool! here is my update on the matter.
I do not use that bold.json from cpp-bids output anymore. What do I mean by "use"?
* I updated `cpp-bids` submodule in my exp presentation scripts, so there’s no extra column in the` .tsv` files produced for onsets. (side information)

* I’m saving `config.json` output from `cpp-bids` . But that is for me to save stuff in `source` folder. All the config files are saved! I also save `bold.json` currently, but I do not use those anymore in any analysis.

* For analysis (`raw` and `derivatives`) I am using [heudiconv](https://www.youtube.com/watch?v=O1kZAuR7E00&ab_channel=JamesKent) converter’s `bold.json` files. So it does extract the `sliceOrder` information, therefore in my scripts e.g. `setParameters` I do not need that `sliceOrder` info to be saved onto `cpp-bids` `bold.json` file.
  And `heudiconv` generated `bold.json` files are passing `bids-validator`, `cpp-spm`, and `MRIQC`.

And they all lived happily ever after!


Maintenance/julia07

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@300d2d4). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage          ?   67.42%
=========================================
  Files             ?        3
  Lines             ?      221
  Branches          ?        0
=========================================
  Hits              ?      149
  Misses            ?       72
  Partials          ?        0

Impacted Files
Coverage Δ

src/BigData.jl
23.43% <ø> (ø)

src/CommonStructs.jl
100% <100%> (ø)

src/CloudGraphs.jl
84.35% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300d2d4...ea2d0a2. Read the comment docs.


readline

I tried using the console package on a windows machine and the readline import failed as such:
c:\Python27\python-lifx-sdk-master\python-lifx-sdk-master\examples>python console.py
Traceback (most recent call last):   File "console.py", line 1, in <module>     import pyreadline ImportError: No module named pyreadline
No attempts to install or compile it worked as it is not meant to run on Windows. I was however, able to get pyreadline and use that instead. May I suggest you use this form instead:
try:
  import readline
except ImportError:
  import pyreadline as readline

The code works without readline so I've made it do the following:

Try to import readline
Try to import pyreadline
Start the console without readline support

Changes are in be9ee73e07ddc67f86d00090ad44a9042645a2c3


Toolbar

similar to bokeh's tool buttons, automatically append this to the bottom of any plot, unless tool_buttons=False or something. Could use icons for it, can get free icons here: thenounproject.com
For all plot areas:

[x] auto scale
[x] center scene
[x] checkable button for maintain aspect
[x] enable/disable pan zoom controller, once this is merged: https://github.com/pygfx/pygfx/pull/457
[x] flip camera.scale.y, https://fontawesome.com/icons/rotate?f=classic&s=solid
[x] record start & stop once this is merged: #178

just save in the nb local path for now, use timestamp for filename

~add selectors (once they are ready)~ adding selectors with buttons doesn't make much sense, can wait until we have right-click menus for those since those are really specific to a parent graphic.
[x]  tooltip for all buttons

ImageWidget specific:

[x] reset vmin vmax - for ImageWidget, can use a contrast icon
[x] Play button, try out the ipywidgets play, stop, pause etc. stuff again
[x] step size, BoundedIntText widget

There's a boolean attribute or property enabled for controllers

What do you think about buttons for adding selectors. For example, click a " add LinearSelector" button to toggle it, then click on the graphic (line, line collection, or heatmap) to add the selector to, the selector gets added and button gets un-toggled.

done in #195 , #207


add missing eslint config file as referenced by rc

eslint needs a private config eslint-config-futagozaryuu from which to pull eslint-config-futagozaryuu/node-v4.  probably missing because, as is a personal config, it's likely installed globally on the owner's machine.

Actually, eslint-config-futagozaryuu is published on NPM, and should install fine on any machine other then mine (for example, travis tests pass even with this pr).
What error or problem did you encounter exactly to submit this PR?

Coverage remained the same at 90.067% when pulling 59d0dcc56ad5d9ec993889e4b73cc249c11892be on StoneCypher:FixMissingEslintConfigInPackage into 15d364587c29cf6197f2b34d0b862c79ed16e44d on pegjs:master.

eslint wouldn't lint the project because of the missing module

Details about your setup might help. I've used this config while working on:

Node.js v6 (Windows 10 x32 and Windows 10 x64)
Node.js v7 and v8 (Windows 10 x64)
Node.js v4, v5, v6, v7 and v8 (Linux, Travis)

While using it on the above, I have not had this problem on PEG.js, but I have had the problem quite a while back on another project (haven't put it on GitHub) where it couldn't find my ESLint configurations, but after clearing my NPM cache and deleting the local copy of node_modules it was fixed, so maybe something similar could help you?
Also to note, although I don't use carets much, I'm pretty sure there's no difference between 3.9.x and ^3.9.0, as ^3.9.0 means any release between 3.9.0 and 3.10.0, which is the same as 3.9.x

@StoneCypher I closed this because

I am unable to reproduce the issue (on either of my laptops, or on Travis)
The PR change ^3.9.0 is the same as the orignal 3.9.x
I updated eslint-config-futagozaryuu to 4.17.x

From what I can tell, you are probally having an issue with dependency insallation, so try deleting the node_modules folder on your fork of the PEG.js repository, as well as clearing your npm cache, then do a fresh npm install from the root of your fork'.
If you are still having issues, or you beleive that I am wrong, then please open a new issue and tell me, because if this is an issue resulting from my choice of x instead of carets (^) in a version string, then I want to fix it, as I use x in nearly all the packages or projects I develope.


Unable to get trial license, invalid URL in setup.md

https://myenterpriselicense.hpe.com/cwp-ui/evaluation/HPE-SWARM/0.3.0/null link in setup.md is invalid.

Can someone please fix it and point me to correct URL?

The URL is fixed.   Could you please try now..


Working with Safari

When will msal 2.0 be released? and will it work successfully with safari?

@MathieuDWeill we released the msal 2.0 beta on both npm and CDN yesterday. I will let @pkanher617 comment on it's use with Safari/ITP, as I'm unsure of what we've landed on.

I was able to talk to @pkanher617 about this, and it will solve ITP in most scenarios for 2.0 release, and we will have more details and documentation regarding the edge cases soon.

@pkanher617 reminder for docs for ITP as well

@jmckennon Do you know when msal/angular 2.0 will be released? Looking for the ITP solution.

@NerdyB713 Msal 2.0 is currently in beta. Angular updates to 2.0 currently do not have an ETA. You can track this ticket for updates on MSAL 2.0 #1000


Create python-publish.yml

nuevo_orgamen

Are you able to help me understand the intent of the PR? Currently a release is done to pypi via release pipeline.


Delete note to ignore Kubenet, as page now mentions Calico too

Simplification following the merge of https://github.com/kubernetes/website/pull/18924

Deploy preview for calico ready!
Built with commit 7bf65d54e16e04ba8ae43426d21a2c4c239d98bb
https://deploy-preview-3214--calico.netlify.com


How to make this language support Chinese?

Hi @JoeImJoe - the name plate example is just an implementation to show off the capabilities of openjscad-react library and isn't necessarily meant to be a functional tool by itself. Frankly I'm not sure what would need to be done to get the OpenJSCAD text-to-model function to support different character sets 🤷♂  In any case I'm closing this ticket for being out-of-scope - thank you for your interest in this project!

@JoeImJoe you might be interested in this small library for using TTF fonts inside a JSCAD project.
https://github.com/jscad-community/jscad-text


CI: K8sVerifier Runs the kernel verifier against the BPF datapath: failed to load object 'test/bpf/../../bpf/sockops/bpf_sockops.o'

K8sVerifier Runs the kernel verifier against the BPF datapath
Failing in pipeline: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Kernel/
Affects 4.19 and net-next jobs.
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Kernel/3953/testReport/Suite-k8s-1/18/K8sVerifier_Runs_the_kernel_verifier_against_the_BPF_datapath/
Stacktrace
/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Kernel/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:514
Expected the kernel verifier to pass for BPF programs
Expected command: kubectl exec -n default test-verifier -- test/bpf/verifier-test.sh
To succeed, but it failed:
Exitcode: 255
Err: exit status 255
Stdout:
 	 => Loading bpf_lxc.c:from-container...
	 => Loading bpf_lxc.c:to-container...
	 => Loading bpf_host.c:from-netdev...
	 => Loading bpf_host.c:from-host...
	 => Loading bpf_host.c:to-netdev...
	 => Loading bpf_host.c:to-host...
	 => Loading bpf_network.c:from-network...
	 => Loading bpf_overlay.c:from-overlay...
	 => Loading bpf_overlay.c:to-overlay...
	 => Skipping bpf_sock.c:connect4
	 => Skipping bpf_sock.c:post_bind4
	 => Skipping bpf_sock.c:sendmsg4
	 => Skipping bpf_sock.c:recvmsg4
	 => Skipping bpf_sock.c:getpeername4
	 => Skipping bpf_sock.c:post_bind6
	 => Skipping bpf_sock.c:connect6
	 => Skipping bpf_sock.c:sendmsg6
	 => Skipping bpf_sock.c:recvmsg6
	 => Skipping bpf_sock.c:getpeername6
	 => Loading sockops/bpf_sockops.c:sockops...

Stderr:
 	 skipping kernel config, can't open file: No such file or directory
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_encrypt_state" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_ep_to_policy" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_events" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_ipcache" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_lb4_backends" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_lb4_reverse_nat" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_lb4_services" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_lb6_backends" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_lb6_reverse_nat" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_lb6_services" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_lxc" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_metrics" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_signals" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_cilium_tunnel_map" has unrecognized, non-zero options
	 libbpf: maps section in test/bpf/../../bpf/sockops/bpf_sockops.o: "test_sock_ops_map" has unrecognized, non-zero options
	 libbpf: kernel doesn't support global data
	 libbpf: failed to load object 'test/bpf/../../bpf/sockops/bpf_sockops.o'
	 Error: failed to load object file
	 command terminated with exit code 255

/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Kernel/src/github.com/cilium/cilium/test/k8sT/Verifier.go:105

Standard Output
Standard Error
21:23:15 STEP: Running BeforeAll block for EntireTestsuite K8sVerifier
21:23:15 STEP: Ensuring the namespace kube-system exists
21:23:15 STEP: WaitforPods(namespace="kube-system", filter="-l k8s-app=cilium-test-logs")
21:23:15 STEP: WaitforPods(namespace="kube-system", filter="-l k8s-app=cilium-test-logs") => <nil>
21:23:20 STEP: WaitforPods(namespace="default", filter="test-verifier")
21:23:35 STEP: WaitforPods(namespace="default", filter="test-verifier") => <nil>
21:23:36 STEP: Building BPF objects from the tree
21:23:52 STEP: Running the verifier test script
FAIL: Expected the kernel verifier to pass for BPF programs
Expected command: kubectl exec -n default test-verifier -- test/bpf/verifier-test.sh
To succeed, but it failed:
Exitcode: 255
Err: exit status 255
Stdout:
 	 => Loading bpf_lxc.c:from-container...
	 => Loading bpf_lxc.c:to-container...
	 => Loading bpf_host.c:from-netdev...
	 => Loading bpf_host.c:from-host...
	 => Loading bpf_host.c:to-netdev...
	 => Loading bpf_host.c:to-host...
	 => Loading bpf_network.c:from-network...
	 => Loading bpf_overlay.c:from-overlay...
	 => Loading bpf_overlay.c:to-overlay...

Likely introduced by https://github.com/cilium/cilium/pull/14129.

Ouch, I enabled on 4.19 and net-next by mistake :scream:

#14162 should fix it.


KeyVaultClient Log Level is not set based on overall logging level and clear text secrets in log

Description
Currently, they are set separately with no code to tie them together.  We need to mitigate on our end and follow-up with PG.
Expected Behavior

A map between app log level and KV log level
Setting app log level should set the KV client log level appropriately
Secrets should not be in clear text in logs

Reproduce

Change application logging level to more strict than INFO
run app
observe KV log output
See KV logs and secrets

I'll need to map log levels of TRACE, DEBUG, INFO, WARN, ERROR, and FATAL to the available levels for the KeyVault log levels:

BASIC
Logs only URLs, HTTP methods, and time to finish the request.

BODY
Logs everything in BASIC, plus all the request and response body. Note that only payloads in plain text or plain text encoded in GZIP will be logged.

BODY_AND_HEADERS
Logs everything in HEADERS and BODY.

HEADERS
Logs everything in BASIC, plus all the request and response headers.

Presently, I will map no log levels to KV level of BODY_AND_HEADERS as that logs secrets in clear text.

My initial thoughts on mapping the KV to app log level:

KV Log Level
Description
App Log Level
Reason

BASIC
Logs only URLs, HTTP methods, and time to finish the request.
WARN, ERROR, FATAL
Matching decreased information

BODY
Logs everything in BASIC, plus all the request and response body. Note that only payloads in plain text or plain text encoded in GZIP will be logged.
N/A
Unused as it will show plain text secrets

BODY_AND_HEADERS
Logs everything in HEADERS and BODY.
N/A
Unused as it will show plain text secrets

HEADERS
Logs everything in BASIC, plus all the request and response headers.

N/A
There is no matching general log level

File CSE Feedback @jofultz

CSE Feedback: https://dev.azure.com/csefy19/CSE Feedback/_workitems/edit/354926


LookupError in requests, not in urllib2

>>> url = 'http://dilbert.com'
>>> len(urllib2.urlopen(url).read())
30194
>>> len(requests.get(url).content)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "build/bdist.macosx-10.7-intel/egg/requests/models.py", line 713, in content
LookupError: unknown encoding: utf-8lias
>>>

Heh, some heavy testing here... :)

It looks like they are sending this trash for at least 3 years now... :)

Posted by: Ryan | April 21, 2008 at 01:04 PM
Yeah, WTH is up with the new Dilbert.com page? Tell whoever it is that runs the server that "text/html; charset=utf-8lias" > is not a valid Content-Type response header.

Taken from http://dilbertblog.typepad.com/the_dilbert_blog/2008/04/apr-for-houses/comments/page/2/

We should definitely be catching this.

Looks like this is fixed?

Not really. r.content is no more unicode that's why there's no encoding done when accessing it
>>> type(requests.get('http://dilbert.com').content)
<type 'str'>

However the problem is still present with .text which is unicode
>>> len(requests.get('http://dilbert.com').text)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "c:\requests\requests\models.py", line 774, in text
    content = str(self.content, encoding, errors='replace')
LookupError: unknown encoding: utf-8lias

The error is present regardless of chardet module being installed or not.


[BUG] Fresh install only get fault when trying to schedule any volume

Describe the bug
I did a fresh install of v1.7.0 on flatcar linux
After that I tried to install a chart that creates 2 PVCs.
Both pvc show as bound, but the pods never starts. On Lonhorn UI I see the volumes are faulty.
data-wp-mariadb-0   Bound    pvc-c06abfbf-e4aa-4ada-a1b5-a01b882e1637   2Gi        RWO            longhorn       <unset>                 5m18s
wp-wordpress        Bound    pvc-46b04cf8-77e8-48af-9bef-8c2c3bdb2f76   1Gi        RWX            longhorn       <unset>                 5m18s

  Warning  FailedAttachVolume  82s (x11 over 7m39s)   attachdetach-controller  AttachVolume.Attach failed for volume "pvc-46b04cf8-77e8-48af-9bef-8c2c3bdb2f76" : rpc error: code = Aborted desc = volume pvc-46b04cf8-77e8-48af-9bef-8c2c3bdb2f76 is not ready for workloads

To Reproduce
flatcar stable release
helm install wp oci://registry-1.docker.io/bitnamicharts/wordpress --namespace wp --create-namespace -f values.yml
This is the value file
replicaCount: 1
persistence:
  enabled: true
  accessModes:
    - ReadWriteMany
  size: 1Gi
mariadb:
  primary:
    persistence:
      size: 2Gi

Expected behavior
It should work.
Support bundle for troubleshooting

Environment

Longhorn version:  1.7.0
Impacted volume (PV): pvc-46b04cf8-77e8-48af-9bef-8c2c3bdb2f76
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:

Number of control plane nodes in the cluster: 1
Number of worker nodes in the cluster: 6

Node config

OS type and version: flatcar
Kernel version: 6.1.85-flatcar
CPU per node:3
Memory per node:  4096
Disk type (e.g. SSD/NVMe/HDD): NVME
Network bandwidth between the nodes (Gbps): 1

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): KVM
Number of Longhorn volumes in the cluster: 2

@jsalatiel
A support bundle is appreciated.
In addition, does it work in v1.6.2 on flatcar linux?
cc @c3y1huang

Only i1.lan has one disk, but the engine image is not deployed to this node, and the replica is uable to locate on this node.
@jsalatiel Are the i1.lan, i2.lan and i3.lan unable to download the engine image for the public dockerhub registry?
    nodeDeploymentMap:
      i1.lan: false
      i2.lan: false
      i3.lan: false
      m1.lan: true
      w1.lan: true
      w2.lan: true
    ownerID: m1.lan

2024-08-29T19:45:32.922993887-03:00 {"file":"/go/src/github.com/longhorn/longhorn-manager/datastore/longhorn.go:1936","func":"github.com/longhorn/longhorn-manager/datastore.(*DataStore).CheckEngineImageReadiness","level":"info","msg":"CheckEngineImageReadiness: nodes [i1.lan] don't have the engine image longhornio/longhorn-engine:v1.7.0","time":"2024-08-29T22:45:32Z"}

2024-08-29T19:45:32.923019941-03:00 {"accessMode":"rwx","controller":"longhorn-volume","error":"No available disk candidates to create a new replica of size<PHONE_NUMBER>","file":"/go/src/github.com/longhorn/longhorn-manager/controller/volume_controller.go:2305","frontend":"blockdev","func":"github.com/longhorn/longhorn-manager/controller.(*VolumeController).replenishReplicas","level":"warning","migratable":false,"msg":"Unable to create new replica pvc-46b04cf8-77e8-48af-9bef-8c2c3bdb2f76-r-63089cc2","node":"w1.lan","owner":"w1.lan","shareEndpoint":"","shareState":"stopped","state":"detached","time":"2024-08-29T22:45:32Z","volume":"pvc-46b04cf8-77e8-48af-9bef-8c2c3bdb2f76"}


[Question] Embeding yt-dlp: TypeError: Object of type LazyList is not JSON serializable

[v] I'm asking a question
[v] I've looked through the README and FAQ for similar questions
[v] I've searched the bugtracker for similar questions including closed ones

#!/usr/bin/env python

from __future__ import unicode_literals
import sys
import json
import struct
import yt_dlp

def encodeMessage(messageContent):
    encodedContent = json.dumps(messageContent).encode('utf-8')
    encodedLength = struct.pack('@I', len(encodedContent))
    return {'length': encodedLength, 'content': encodedContent}

def sendMessage(encodedMessage):
    sys.stdout.buffer.write(encodedMessage['length'])
    sys.stdout.buffer.write(encodedMessage['content'])
    sys.stdout.buffer.flush()

class MyLogger(object):
    def debug(self, msg):
        sendMessage(encodeMessage({
            'debug': msg
        }))
    def warning(self, msg):
        sendMessage(encodeMessage({
            'warning': msg
        }))
    def error(self, msg):
        sendMessage(encodeMessage({
            'error': msg
        }))

def getInfo(msg):
    with yt_dlp.YoutubeDL({
        'logger': MyLogger(),
        'ignoreerrors': True
    }) as ydl:
        info = ydl.extract_info(msg.get('url'), False)
        print(info)
        if info is not None:
            sendMessage(encodeMessage({
                'info': info
            }))

getInfo({'url': 'https://www.youtube.com/watch?v=BaW_jenozKc'})

This throws:

TypeError: Object of type LazyList is not JSON serializable

With youtube-dl it doesn't. How can I make it work with yt-dlp?
Also I'm getting the line

{"debug": "[youtube] BaW_jenozKc: Downloading webpage"}
two times in yt-dlp, in youtube-dl only one time. Is that a bug?

    info = ydl.sanitize_info(info)

before trying to serialize

Thanks that worked. Any idea for the debug-lines?

Downloading webpage should only happen once. Do you mean this?
[youtube] BaW_jenozKc: Downloading webpage
[youtube] BaW_jenozKc: Downloading android player API JSON

You're right, I tested with a different url using another extractor before that downloads several pages.


fix broken example in documentation

The 'sub-' prefix is already inserted by the config, so including it in the query breaks it. Took me a while to work this out. Hopefully saves someone else a few minutes of confusion.
By the way, there is a very similar version of this repo at https://github.com/INCF/grabbit. Let me know if I should be working with that one instead.

Thanks! And grabbit is a dependency of pybids that is installed by the pybids installer, so you already are working with it. :)

Makes sense! But despite the folder name, the repo I linked above is actually another copy of grabbids, not grabbit (which lives here if I'm not mistaken: https://github.com/grabbles/grabbit).
Sometimes I long for those one-central-repository-only SVN days...

Yeah, we originally put it there, and then moved it to its own organization. You can safely ignore it. @jbpoline, do you have the permissions to delete INCF/grabbit?

yes, most likely - will do - thanks for spotting this !

done


Books: Previous/Next Buttons Don't Show Up in Stable

Previous/Next Buttons Don't Show Up in stable. App Quality was being checked unnecessarily in notebook.component.ts.

This isn't a regression and is easily worked around so doesn't meet the bar for November at this time.


Bugfix/issue 103/shell cmd warn

ansible 2.14+ doesn't support warn parameters for ansible.builtin.shell and causes playbook runs to fail.
This fixups the code where we use it explicitly. Complicating this issue, is the fact that the cloudalchemy.node_exporter module also has the same issue, but is no longer maintained. I've switched us over to geerlingguy's fork which is more recently updated and fixes the underlying problem.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Initial fix for text insertion bugs in Android 5.1

Related to issue #1011
There is a bug in Android 5.1 (not 5.0 oddly enough) that makes text
entry nearly unusable. It's documented in detail here -
https://github.com/facebook/draft-js/issues/1011
Logging everything shows that;

when we have a block with text and spaces, and start deleting the
characters one by one, there is an 'onInput' for each deletion that
updates the text.
when you delete the very last character, the 'anchorNode' of the
domSelection has a type that is not a text node. So we skip updating
at all, and that means the last character doesn't actually get
properly deleted from editorState.
Then the next time something fully updates the editorState, that last
character shows up again.

The root issue is that Android 5.1, when we tested it, was in
"composition" mode and the current handlers are not really built to
handle text deletion properly in composition mode.
We're looking forward to finding a more complete solution to the root
cause - for now this change improves the usability on mobile and doesn't
break anything.
Before submitting a pull request, please make sure the following is done...

Fork the repo and create your branch from master.
If you've added code that should be tested, add tests!
If you've changed APIs, update the documentation.
Ensure that:

The test suite passes (npm test)
Your code lints (npm run lint) and passes Flow (npm run flow)
You have followed the testing guidelines

If you haven't already, complete the CLA.

Please use the simple form below as a guideline for describing your pull request.
Thanks for contributing to Draft.js!

Summary
[...]
Test Plan
[...]

We have reviewed and tested this change internally at FB. So I think it's fine to merge.


P1: Make tables sortable by column headers

Not every column should necessarily be sortable—please leave it as an option! (for example a column with a bunch of delete buttons doesn't need to be sortable)
For sortable tables, clicking the column header should sort the entire table based on that column

[ ] once: Sorts in ascending (or A–Z) order, with an up arrow

[ ] twice: Descending (or Z–A) order, with a down arrow

[ ] Three times: back to default order with both up and down arrow

See example of intended behavior here: https://datatables.net/examples/basic_init/table_sorting.html

Please add a screenshot/mock

@hmyers-cms do you have a screenshot for this? Also a basic description of how the filtering works might be helpful.

@hmyers-cms Are there tables other than Test Results and People to which sorting should apply?

moving this to https://app.zenhub.com/workspaces/simplereport-5ff8be8854ae8b000e378210/issues/cdcgov/prime-simplereport/747


make CHIP_DEVICE_CONFIG_BLE_ADVERTISING_TIMEOUT configurable via menuconfig

make CHIP_DEVICE_CONFIG_BLE_ADVERTISING_TIMEOUT configurable via menuconfig
Currently it is defined as
CHIP_DEVICE_CONFIG_BLE_ADVERTISING_TIMEOUT (15 * 60 * 1000)
can we make it configurable.
either via menuconfig or any other way ?

@shah-kartik You can use chip_ble_project_config_include GN arguments to provide a project-specific BLE configuration file where you can override the constants. Which platform do you use by the way?

@Damian-Nordic, Thanks for the comment. I am using M5Stack kits right now.


Evaluation scripts

While trying to evaluate the model using bin/evals.sh I get the following RuntimeWarning:
Traceback (most recent calls WITHOUT Sacred internals):
  File "/home/joaolages/Desktop/repacrr/evals/docpairs.py", line 130, in main
    best_pred_dir, argmax_epoch, argmax_run, argmax_ndcg, argmax_err = get_epoch_from_val(pred_dirs, val_dirs)
  File "/home/joaolages/Desktop/repacrr/utils/eval_utils.py", line 67, in get_epoch_from_val
    argmax_run, argmax_ndcg, argmax_err = test_epoch_ndcg_err[best_epoch]
KeyError: 0

Which leads to the following error:
Traceback (most recent calls WITHOUT Sacred internals):
  File "/home/joaolages/Desktop/repacrr/evals/rerank.py", line 180, in main
    best_pred_dir, argmax_epoch, argmax_run, argmax_ndcg, argmax_err = get_epoch_from_val(pred_dirs, val_dirs)
  File "/home/joaolages/Desktop/repacrr/utils/eval_utils.py", line 67, in get_epoch_from_val
    argmax_run, argmax_ndcg, argmax_err = test_epoch_ndcg_err[best_epoch]
KeyError: 0

I believe that the problem in here is due to the train_test_years variable set in utils/config.py as
train_test_years = {'wt12_13':['wt11', 'wt14']}

I have trained and predicted the model with wt09_10 and wt11 respectively, which I have set on both bash scripts. Both the functions docpairs.py and rerank.py don't look into these train_years and test_year variable passed in the config.

If I understand correctly, the issue is that docpairs.py and rerank.py are using the hardcoded train_test_years rather than the config parameter. A hack that should temporarily fix the issue would be editing train_test_years in utils/config.py (but based on your comments, you probably already realize that).
Those scripts ignore the train_years and test_year config parameters because we generally have multiple test_year values for each train_years value (i.e., we use 4 years for training and predict on both of the remaining two years).
The current code hardcodes the parameter values rather than expecting the eval scripts to be run multiple times with different values for train_years and test_year. This isn't ideal though, and I'll talk with @khui to see if we can find a better solution.
I'm glad to see that you're uncovering issues with our pipeline. Thanks for pointing it out!

I'm glad to see that you're uncovering issues with our pipeline. Thanks for pointing it out!

You're welcome. Glad I can help such a good open source project

Thanks for pointing that out Joao. As suggested by Andrew, the train_test_years dictionary needs to be edited according to the actually training/test year being used.
In your case, you may write:
{‘wt09_10’:[‘wt11’]}
However, by doing this, you wont have a validation data, thereby could not be properly evaluated.
{‘wt09_10’:[‘wt11’, ‘wt12’]}
The evaluation actually relies on train/validation/test split. At training and predication phases, one train on certain years (wt09 and wt10), and predict over different iterations on certain test years (wt11 or wt12). At the evaluation phase, given the training years (wt09 and wt10), one needs to specify two predicted years, one for validation and one for testing, to conduction evaluation. For example, when evaluating on wt11 and validating on wt12, the model is selected based on wt11 and the evaluation results are based on wt12.
At this moment, I would suggest you could directly configure the train_test_years.

According to Joao, the problem is fixed after editing train_test_years.


Updated package.json to newest packages

npm update --save-dev

@blingenau and @tsitsop just FYI, you'll want to update.


Add a recipe to install the Singularity Executor and its config files

Depends on build recipe from #456

Also depends on #464

could we fold this into #464 to reduce confusion?

Sure. I'll do that right now.


Add Translate to the Selection Context menu

In WWDC24, Apple announce the new Translation API https://developer.apple.com/documentation/Translation
This would enable adding the Translate option to the context edit menu, which was previously blocked by not being able to access the Translate API

Part of https://github.com/flutter/flutter/issues/107578
WWDC video: https://www.youtube.com/watch?v=MuIFhbHNmqA

That's great that we have an API to do this now 👍

This is a Swift-only API and would require engine support https://github.com/flutter/flutter/issues/144791
cc @cbracken

This is a Swift-only API and would require engine support #144791 cc @cbracken

Thanks for the heads-up! Added a note to the Swift in Engine issue.


[OSF-8192] Add readonly provider for Bitbucket

Purpose
Add support for a read-only bitbucket OSF add-on.  Still targets develop-backup and needs to be upgraded to work with DjangOSF.
Changes
Adds a whole new provider in website/addons/bitbucket.  All changes outside that directory go directly towards supporting the new addon.
Side effects
Unavoidable grief.
Ticket
[#SVCS-268] - JIRA
[#OSF-8192] - JIRA
Entangled with WB PR: https://github.com/CenterForOpenScience/waterbutler/pull/198

Closing in favor of #7409


Webserver display error in Doge

Guys,
I think I found a small error in webserver doge printing:

It seems that the prettyFloat function works until the accuracy of e-7.
Not a nice display of 0.00000019

@lexrms this should be fixed on master now.


I should be able to hide my profile page from non-friends

If I am worried about privacy, I should be able to obscure my identity in both groups and also among non-friends.
This means we need a toggle in your profile page:
HIDE MY IDENTITY FROM STRANGERS
Only friends can see my image, name, or profile page. This will protect you from strangers if you want to post to a group, or if you don't want to appear on the friends list of your friends profile pages.
How it will work:
Everything works the exact same way except:
HIDE_IDENTITY == TRUE
Profile page:

Image will be the default icon
Name will be "Anonymous"
Friends list will be hidden and say "Anonymous friend's list is private"

Messages or comments

Cannot tag or mention this user
Cannot see anything about this user except what he / she writes in a group message or comment.

Friends
People who are friends (and the user himself) will see an emoji lock appear after their name / user name like
"mreider 🔒" - this will appear when they post messages, and on their profile page etc.

@falconandy - @Cardoso-topdev is going to implement this. Might need help.


Treasury fields are missing for Conway transactions

Ask a question
Conway transactions can have field related to donations (current treasury value, treasury donation) and they are missing from the GraphQL schema. When will they be added?

@alecalve they will be added soon, I'll update this issue when there's a PR

@alecalve We added the conway tables and data within this commit: https://github.com/cardano-foundation/cardano-graphql/commit/16ed6d71dbe95ff9e7d959ea51a8476da668684c
Additionally I will build a new release as soon as the new db-sync version is released for the node 9.2.0 so that I can bump the repsective versions.

Closing issue due to inactivity. If there is an issue with regarding the new tables or anything else let me know.


semi-blockchain fine tuning

[ ] seed shouldn't be stored on the declaration_request. Read the latest on demand (POST, GET) from blocks db.
[x] exclude is_activefrom the block hash calculation - to be discussed with @AlekzandrV
[x] add patient_id to the block hash calculation
[ ] seed should be also validated during the signed content validation process.

Items 2 and 3 were done in https://github.com/edenlabllc/ops.api/commit/1d03cf04e6bdcc540dca2de802ab41c7dff3f8a7

Item 4 was done in https://github.com/edenlabllc/ehealth.api/commit/dca848c54738c960b6e422f33e6d92ea19cdb6bb

@gmile  item 4 - should be part of the billing process generation.

@lymychp added two more items: add numbers + versions to blocks.

Added numbers and versioning:

block numbers – https://github.com/edenlabllc/ops.api/pull/34
block algorithm versioning https://github.com/edenlabllc/ops.api/pull/35

seed shouldn't be stored on the declaration_request. Read the latest on demand (POST, GET) from blocks db

Done in https://github.com/edenlabllc/ehealth.api/pull/1164

Notifications are being made in 3 parts:

[x] IL part https://github.com/edenlabllc/ehealth.api/pull/1173 – IL will be sending emails; merged
[ ] OPS part
[ ] Configuration part:

[x] IL part – https://github.com/edenlabllc/ehealth.charts/commit/7f49d1a149027cc0366a1d1a47438511229b875e
[ ] OPS part – under way.

After implementing notifications I realized mismatched blocks will raise a notification EVERY time on subsequent verifications, after the initial one when the issue was first spotted, which is noisy may lead to people ignoring the notifications.
We should probably store all spotted mismatches in a separate table, and ignore them on subsequent verifications.

seed should be also validated during the signed content validation process

Done in https://github.com/edenlabllc/ehealth.api/pull/1179

We should probably store all spotted mismatches in a separate table, and ignore them on subsequent verifications.

actually there should be immediate reaction to the mismatch event. Admin should fix it. One of the options is to restore from the backup.
But anyway storing mismatches is a good idea


Overwrite manually logged images

Hey guys, thanks for your great work!
I'm logging a plot using live.log_image(filename, fig_pil) as part of my notebook. Now, we usually need a couple of tries to get the plot that we want. It would be great if dvclive could overwrite an already logged image file instead of throwing an DataAlreadyLoggedError. Otherwise, managing this becomes a huge headache when you are working with multiple plots or images.
For example, as additional argument:
log_image(name, val, overwrite=True)

Thanks for considering!

I think we could even just drop this check and leave it to the users to make sure they don't overwrite. WDYT @daavoo?

I think we could even just drop this check and leave it to the users to make sure they don't overwrite. WDYT @daavoo?

Yep

@svsn2117 Would you have an interest in contributing that change?

I might try, but first I have to get the local env setup (see https://github.com/iterative/dvclive/issues/433). From what I have looked into so far, it doesn't look like a lot of work for someone more familiar with the project than me. I would recommend changing not only log_images but all log_ functions though.

Sounds good @svsn2117! Yes, I don't think it's a lot of work, but I can't promise how soon we can prioritize it, and it's always great to have contributions from the community. If not, no worries, we will get to it at some point.

Fixed in #445


Heart dead volumes are in the cellml code

The dead volumes of the heart chambers are specified in the cellml module. I need to automate the process of setting these values to q_ra0, q_rv0 ...

Completed


Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Other
Brief description of your issue
It look like the setup come back with the same hashes. But most likely when I try to run winget install Malwarebytes.Malwarebytes --force. It install <IP_ADDRESS> setup instead  the online setup version <IP_ADDRESS>7. But the Malwarebytes application is <IP_ADDRESS>2
Steps to reproduce
winget upgrade
winget install "Malwarebytes.Malwarebytes" --force
Actual behavior
Actually, upgrade did not appear.
Expected behavior
Upgrade might appear.
Environment
winget --info
Windows Package Manager v1.4.10173
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.2846
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

User Settings: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Screenshots and Logs

This setup most likely overwrite new update with the same link.

This is already attempted. But the pipelines have some problem.


Copy info from table items

I think we should have right click menu on table items which includes the option to copy various
JSON/GUID info to the clipboard:

item JSON
Enquable JSON (e.g. via qserver cli)
item UID
run UID

Other suggestions are welcome

I elected not to do Enquable JSON for the time being, may come back to it at some point but not urgent.


Color Vision Deficiency (CVD) Support

I've been working on adding CVD support. At this point, the main issue is deciding which algorithm to use.  There seems to be 3 main acceptable approaches (this isn't getting into all of the details of which LMS conversion to use with said version etc.).
The versions are Brettel, Vienot, and Machado, shown below, with no CVD on the top followed by each of the aforementioned methods in the order listed. Each one shows protanopia, deuteranopia, and tritanopia.

The big question is which is most correct. Both Firefox and Chrome implement their developer tool that shows these CVDs using Machoda. While the protanopia and deuteranopia are okay, the tritanopia is not that great, and they don't formally show any examples or talk much about it. It seems they've provided it only as an approximation. It's a shame that is the one they are using for tritanopia in the browser.
Vienot seems to do pretty respectably and is touted here as a better option for both protanopia and deuteranopia. It's also reasonably fast if the matrices are recalculated.
Brettel seems to be the gold standard according to this article, though that Vienot is a good alternative for seed with everything but Tritanopia. It seems Brettel is the only one that does a good job at Tritanopia.
It seems like we could do everything in Brettel, or just use Brettel for tritanopia and Veniot for protanopia and deuteranopia.
We could provide all methods and let the user use whatever they feel necessary.
I thought about implementing them as filters with the #134  feature. But filters can be run under sRGB or Linear sRGB. CVDs, for accuracy, need to be run under Linear sRGB. So it is likely we'll have a dedicated cvd method.

Interestingly, I was poking around, and while it suggests in the Machado implementation to interpolate the high and low matrix when using a factor between the matrices, it seems faster to actually just calculate the color at the high and low matrix and then interpolate the colors instead of the matrix. The results are identical. Granted, we are talking about saving microseconds, but microseconds add up 🙂.

A branch is up. It is fully working, though tests need to be added. Also added achromatopsia.

I still haven't decided if we just keep all the methods, or just pick one. I think once I run some performance tests and understand the difference, this may help me deciede.

When interpolating a percentage, these are the timings:
➜  coloraide git:(feature/cvd) python3 -m timeit -n 1000 -s "from coloraide import Color" "Color('red').cvd('brettel-protan', 0.83)"
1000 loops, best of 5: 52.5 usec per loop
➜  coloraide git:(feature/cvd) python3 -m timeit -n 1000 -s "from coloraide import Color" "Color('red').cvd('machado-protan', 0.83)"
1000 loops, best of 5: 47.6 usec per loop
➜  coloraide git:(feature/cvd) python3 -m timeit -n 1000 -s "from coloraide import Color" "Color('red').cvd('vienot-protan', 0.83)"
1000 loops, best of 5: 43.2 usec per loop

When performing without interpolation, these are the timings:
➜  coloraide git:(feature/cvd) python3 -m timeit -n 1000 -s "from coloraide import Color" "Color('red').cvd('brettel-protan')"
1000 loops, best of 5: 49.6 usec per loop
➜  coloraide git:(feature/cvd) python3 -m timeit -n 1000 -s "from coloraide import Color" "Color('red').cvd('machado-protan')"
1000 loops, best of 5: 40.5 usec per loop
➜  coloraide git:(feature/cvd) python3 -m timeit -n 1000 -s "from coloraide import Color" "Color('red').cvd('vienot-protan')"
1000 loops, best of 5: 39.7 usec per loop

Vienot wins every time. Machado comes in second, though less when it has to interpolate between one of the predefined steps, and Brettle comes in last with a full 10 usec slower than Vienot.

For perspective, it takes this ling to convert from Display P3 to Lch. I don't think the timing is unreasonable even with the worse case Brettel.
➜  coloraide git:(feature/cvd) python3 -m timeit -n 1000 -s 'from coloraide import Color' 'Color("color(display-p3 1 1 0)").convert("lch")'
1000 loops, best of 5: 54.1 usec per loop


:running: update baremetalhost crd to include boot mode field

What this PR does / why we need it:
Update the version of BMO we use so we get the newer BareMetalHost with
the additional field for the boot mode. This prevents the controller from
overwriting the host with partial data and losing the user-configured
value for booting the host.
Which issue(s) this PR fixes
Implements https://github.com/metal3-io/metal3-docs/blob/master/design/baremetal-operator/implicit-boot-mode.md

This will be needed for the other branch too (release-0.3)
/lgtm
/test-v1a4-integration

This will be needed for the other branch too (release-0.3)

See #116

This will be needed for the other branch too (release-0.3)

See #116

Err, #117

/test-v1a4-integration


Cannot ping container

Problem Description
I've created an docker container

[root@shadow ~]# docker ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
c097871dfc7d centos:latest "/bin/bash" 5 minutes ago Up 5 minutes cenots
[root@shadow ~]# docker inspect cenots

The container IP is :
"Gateway": "<IP_ADDRESS>",
"IPAddress": "<IP_ADDRESS>",
My local network IP is :
ifconfig
docker1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500
inet <IP_ADDRESS> netmask <IP_ADDRESS> broadcast <IP_ADDRESS>
inet6 fe80::42:99ff:fed3:d338 prefixlen 64 scopeid 0x20
ether 02:42:99:d3:d3:38 txqueuelen 0 (Ethernet)
RX packets 14 bytes 1064 (1.0 KiB)
RX errors 0 dropped 0 overruns 0 frame 0
TX packets 54 bytes 6005 (5.8 KiB)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
But I cannot ping each other.
[root@shadow ~]# ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
From <IP_ADDRESS> icmp_seq=1 Destination Host Unreachable
From <IP_ADDRESS> icmp_seq=2 Destination Host Unreachable
From <IP_ADDRESS> icmp_seq=3 Destination Host Unreachable
From <IP_ADDRESS> icmp_seq=4 Destination Host Unreachable
However, when I tcpdump the docker1, the ping works.

tcpdump -i docker1
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on docker1, link-type EN10MB (Ethernet), capture size 262144 bytes
03:26:18.034854 ARP, Request who-has <IP_ADDRESS> tell <IP_ADDRESS>, length 28
03:26:18.034888 ARP, Reply <IP_ADDRESS> is-at 02:42:ac:12:00:02 (oui Unknown), length 28
03:26:18.034901 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo request, id 15891, seq 1, length 64
03:26:18.034943 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo reply, id 15891, seq 1, length 64
03:26:19.035138 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo request, id 15891, seq 2, length 64
03:26:19.035195 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo reply, id 15891, seq 2, length 64
03:26:20.035107 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo request, id 15891, seq 3, length 64
03:26:20.035162 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo reply, id 15891, seq 3, length 64
03:26:21.035108 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo request, id 15891, seq 4, length 64
03:26:21.035175 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo reply, id 15891, seq 4, length 64
03:26:22.035097 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo request, id 15891, seq 5, length 64
03:26:22.035160 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo reply, id 15891, seq 5, length 64
03:26:23.047044 ARP, Request who-has <IP_ADDRESS> tell <IP_ADDRESS>, length 28
ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=64 time=0.136 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=64 time=0.102 ms
64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=64 time=0.101 ms
64 bytes from <IP_ADDRESS>: icmp_seq=4 ttl=64 time=0.112 ms
64 bytes from <IP_ADDRESS>: icmp_seq=5 ttl=64 time=0.106 ms

Im so confused about this, how could this happen?

This doesn't look related to the documentation;

But I cannot ping each other.

Can you explain what you mean with "each other"? Are you pinging from another host, or another container? The IP-address shown in the container inspect is on the internal container-container network, which by default is not meant to be a routable ip-address from outside of the docker host

Hi @thaJeztah ,
I mean, for example, I installed docker on hostA, so, hostA got a docker IP, such as <IP_ADDRESS>
Then I created a container, which got an IP, <IP_ADDRESS>.
I cannot ping the container from hostA. This is the problem.
But it's strange that, when I do "tcpdump -i docker0 " on hostA, when the process is going, I can do the "ping".

@NanyinK Did you find any solution? I am facing same issue as you have mention

@manavdadhania
I switch to Oracle Linux with the UEK and install docker package from the oracle repo, then it works.

Hi @NanyinK, thanks for sharing the issue.
I'm not very sure what you're trying to do or if it's a scenario in the documentation. If it's an issue with a tutorial in the documentation, please let us know.
It sounds like you're trying to ping a container from the host. You can try to take a look at this to get an idea, https://stackoverflow.com/questions/39216830/how-could-i-ping-my-docker-container-from-my-host
If you need support, please try the Docker Community Slack or forums:

https://forums.docker.com/
https://dockercommunity.slack.com/


on user profile edit screen, change 'Name' to 'Display Name'

Since display_name is a generated field, it doesn't make sense to title this Display Name. Instead, with a couple of server updates, we're going to provide direct user card and user block feedback, showing the user in real time how updates to the form will look when their card/block is displayed.


[New Topic] Develop and Debug with Docker in Visual Studio

Develop and Debug with Docker in Visual Studio
This was proposed as part of the Docker articles last year and was filed over at the dotnet/docs repo. Refiling issue here.

Table of Contents Location

TBD

Abstract
Learn how to debug with Docker in Visual Studio.

Outline

[ ] Have Docker 4 windows installed
[ ] Screenshots of VS file new project.
[ ] Note that currently Adding Docker support only works if there are no Docker artifacts already in your project.

Reviewer Request

@JRAlexander thanks! @ghogen does this fall under your new area of ownership?

@gewarren Sure! Let me know if you have any questions.

I think this also needs a section for when you want to publish the thing you have been debugging to somewhere else.
And please remember many of your customers aren't using .net core, can't/won't use EF, and could be using an MVC approach, but not necessarily asp.net's flavor of MVC.

Closing this issue now as the main problem appears to be solved and lots of content has either already been added or plans exist.