Blue Highlights for targetTimesEntities

Hey!
I am sure i am being a complete idiot, but i cannot get the blue highlights to work as per your image below:

I have created the target binary sensor with the below settings:

and the code i am using for the card is:
type: custom:octopus-energy-rates-card
currentEntity: event.octopus_energy_electricity_redacted_current_day_rates
futureEntity: event.octopus_energy_electricity_redacted_next_day_rates
targetTimesEntities: binary_sensor.octopus_energy_target_intermittent_best_charging_rates
cols: 2
hour12: false
showday: true
showpast: false
title: Octopus Rates
unitstr: ''
lowlimit: 15
mediumlimit: 20
highlimit: 30
roundUnits: 2
cheapest: true
multiplier: 100
but my card does not have the highlighted blue 3 hour slots?

i am sure i am missing something stupid here?

I should also add i tried this code, but it also made no difference, and no background colours changed
type: custom:octopus-energy-rates-card
currentEntity: event.octopus_energy_electricity_current_day_rates
futureEntity: event.octopus_energy_electricity_next_day_rates
targetTimesEntities: binary_sensor.octopus_energy_target_intermittent_best_charging_rates
backgroundColour: navy
cols: 2
hour12: false
showday: true
showpast: false
title: Octopus Rates
unitstr: ''
lowlimit: 15
mediumlimit: 20
highlimit: 30
roundUnits: 2
cheapest: true
multiplier: 100
if i tabbed in "backgroundColour" it says there is a formatting issue in my YAML?

OK So i figured out what i was doing wrong, but have now hit another issue
My issue was i was missing a trailing ":" at the end of my binary sensor. (This feels odd, as that's not really standard YAML?)
Now that i have managed to fix that, my new issue is, its not showing tomorrows rates?
Below is my updated code, and from what i understand it should show tomorrows rates too?
type: custom:octopus-energy-rates-card
currentEntity: event.octopus_energy_electricity_xxxxx_current_day_rates
futureEntity: event.octopus_energy_electricity_xxxx_next_day_rates
targetTimesEntities:
binary_sensor.octopus_energy_target_intermittent_best_charging_rates:
cols: 2
hour12: false
showday: true
showpast: false
title: Octopus Rates
unitstr: ''
lowlimit: 15
mediumlimit: 20
highlimit: 30
roundUnits: 2
cheapest: true
multiplier: 100
Below is what it looks like

Why am i missing tomorrows rates?

OH! I think this is because tomorrows rates are not yet available!!


Special zones

The illustration above highlights four special "zones" in the maze where ghost behavior is limited by certain conditions which can be exploited to the player's advantage. The two red zones represent the areas where ghosts are forbidden to make upward turns. Once a ghost enters either of these two zones, it may only travel from right-to-left or left-to-right until exiting the area.
Thus, only Pac-Man has access to these four, upward-facing tunnel entrances. It will serve the player well to remember the ghosts can still access these tunnels from the other end! The red zone restrictions are enforced during both scatter and chase modes, but in frightened mode the red zones are ignored temporarily, allowing the ghosts to turn upwards if they so choose.
The pink zones are in the two halves of the connecting side-tunnel. As mentioned previously, any ghost that enters the tunnel will suffer an immediate speed penalty until leaving the zone. This slow-down rule is always enforced and applies to ghosts only-Pac-Man is immune.

tunnels done


Can't declare an argument that is a class/constructor in jsdoc

Hi,
Please see this question on SO http://stackoverflow.com/questions/33150924/jsdoc-es6-and-type-parameters
It is not possible to define a function that accepts a parameter that is a constructor/class. It only accepts parameters that are instances, not constructors. This prevents the use of JsDoc to document all methods that take constructors as arguments.
Actually, the @param documentation states that

The parameter type can be a built-in JavaScript type, such as string or Object, or a JSDoc namepath to another symbol in your code.

But what is the NamePath for a constructor? Wouldn't it be {ClassA} ? But, when inclosed in brackets {}, {ClassA} is interpreted as an instance of ClassA, not ClassA itself.
Example
Here, I define class A as having a helloFromClassA static method.
Then, if i try to document a function that will accept class A as an argument (or descendants of A), it's not possible. I don't think there is even syntax for it.
The only way to get this working is to define a complete mirror of the class and static methods in a @typedef then add all inherited and own properties in it.
/**
 * @class A
 * @extends {Function}
 */
class A {

    /**
     * @static
     */
    static helloFromClassA(){
    }
}

/**
 * @class B
 * @extends A
 */
class B extends A{

    /**
     * @static
     */
    static helloFromClassB(){
    }
}

/**
 * Class as object
 * @param {A} ClassArgument
 */
function fn1(ClassArgument){
    ClassArgument.helloFromClassA(); // Unresolved function or method helloFromClassA
    // Does not work because ClassArgument is interpreted as an
    // instance of A, not A's constructor
}

/**
 * // Class as function
 * @param {Function} ClassArgument
 */
function fn2(ClassArgument){
    ClassArgument.helloFromClassA(); // Unresolved function or method helloFromClassA
    // Does not work because ClassArgument is interpreted as an
    // empty function, not A's constructor
}

/**
 * // Type definition
 * @typedef {Object} AClass
 * @property {Function} helloFromClassA
 * @property {Function} super
 */

/**
 * // Trying to mixin the AClass
 * @typedef {Object} BClass
 * @property {Function} helloFromClassB
 * @mixes {AClass}
 * @mixes {A}
 */

/**
 * // Adding manually all members
 * @typedef {Object} BClass2
 * @property {Function} helloFromClassB
 * @property {Function} helloFromClassA
 */

/**
 * @param {BClass} ClassArgument
 */
function fn3(ClassArgument){
    ClassArgument.helloFromClassA(); // Unresolved function or method helloFromClassA
    // Does not work because the BClass typedef does not take
    // into account the mixin from AClass, nor from A
    ClassArgument.helloFromClassB(); // No warming
}

/**
 * @param {BClass2} ClassArgument
 */
function fn4(ClassArgument){
    ClassArgument.helloFromClassA(); // No Warning
    ClassArgument.helloFromClassB(); // No warming
    // Works because we manually defined the typedef with all own
    // and inherited properties. It's a drag.
}

I'm confused. Where is the error message Unresolved function or method helloFromClassA coming from?

Because the helloFromClassA is a static method. It lies on the constructor, not on the instance.

@ludydoo Let me clarify my question: What application is generating the error message Unresolved function or method helloFromClassA? That doesn't look like a JSDoc error to me.

I'm sorry, Webstorm generates this error. I thought Webstorm used JsDoc to generate its error messages. My mistake.

Even if it's not a JSDoc error it leads to wrong documentations
I have the same issue in many places ( when using @type, @returns, or @param) when I want to tell that something reference a class/constructor and not an instance of this class, meaning it can either be instanciated or used to access static methods/properties)
someone suggested to write some hacks such as
/**
 * @returns {@link MyClass}
 **/

someone else to write something like (could be interesting to be the official way)
/**
 * @param {Function.<MyClass>} statics
 **/

Just because the OP came across this issue because of the way his editor handles JSDoc doesn't mean this isn't (also) as JSDoc issue.  I think it might be the same as #1349 -- if there's a way to specify that a @param (or @type or @property, whatever) should be a class constructor, it's not documented.  I'm concerned that there might not be a way to document that at all, and a new syntax is required (like @AMorgaut 's suggestion of {typeof MyClass}, which as far as I can tell is not actually valid JSDoc).

I dug around in my codebase and I think I found something that might work:  {function(new: MyClass, SomeArgType, OtherArgType?, etc)}.  This seems to make VSCode happy, at least, but if the docs say anything about this syntax, I haven't found it.  Maybe JSDoc is more open-ended about what goes in the type specification than I thought?  In that case, maybe the function spec syntax is coming from VSCode directly (or Google Closure)?

Any news on this for native support of JSDoc class constructor as parameters?

Just in case, I developed a jsdoc plugin for supporting types that reference classes using the syntax : {typeof SomeClass}, like typescript and google closure support: https://github.com/cancerberoSgx/jsdoc-typeof-plugin

The syntax proposed @AMorgaut {typeof SomeClass} and implemented by the plugin proposed by @cancerberoSgx is a understood by WebStorm, see https://youtrack.jetbrains.com/issue/WEB-10214

It feels more like a workaround than a proper spec to me, though, and I don't see the reasoning behind using an expression that would return the string "function" without mentioning any class or constructor, especially given that @param {Function} is already both supported and more descriptive since it is after all more of a function than a string. Specification-wise I would rather see something like:
@param {Class<Person|Pet>} organism - A subclass of either Person or Pet

— perhaps with the variant {Constructor<Person>} to indicate an ES5-style "class" that, for example, cannot be extended by a proper ES6 class.

@wiredearp returning just @param {Function} is not enough since we want to describe the type of the objects resulting from a new expression  (new Foo()) and also reference its constructor so the user now how to build it.
Class<Person|Pet> (or Constructor) is enough syntactically but it's not enough in the practice if you want IDEs to perform the typechecking. Is an artificiality that is valid jsdoc, and BTW my plugin will just translate "typeof Foo" to "Class". Users reading the docs will understand but  IDEs won't.
What I like of "typeof Foo" syntax is that is compatible with TypeScript and I think in general is what IDEs use today for typechecking intellisense, even if your project is vanilla JavaScript - they use TS because it supports jsdoc to type inference..
I was looking what/if google closure supports such a concept and I didn't found anything. It would be interesting to know it since jsdoc claims to support its syntax
My two cents

Looks like the discussion continue there: https://github.com/jsdoc/jsdoc/issues/1349

Looks like the discussion continue there: https://github.com/jsdoc/jsdoc/issues/1349


Customizing Dialogue Values

Currently, I want to achieve the following: when the user sends the dialogue "start",
it will enter dialogue mode. At this point, a ConversationID will be generated.
Throughout the conversation, in addition to the text, the ConversationID and channelID will also be sent to the backend.
Currently, if there are suggestion buttons during the conversation, clicking the button essentially sends the button text.
At this time, the ConversationID and channelID also need to be sent together.
How can this be implemented?
Thank you.

Hi @delsoul6104.
The scope of this issue seems too broad and more closely related to your particular project so I won't be able to provide any particular code examples. However, by reading your description, it appears that you may want to use the  responseInterceptor to get the ConversationID and store it in your application state and then use the requestInterceptor to add the ConversationID and channelID to the outgoing message.
If the above don't work, you can also try to use the request handler to create your own custom implementation.

I will be closing this issue since there has been no further communication


-Wdocumentation flag is producing hundreds of warnings

Goals
Realm compiles with the -Wdocumentation flag (corresponding to Xcode's "Documentation Comments" option), which is good, and it has clang documentation, but it's very frequently wrong. This results in hundreds of warnings like this:
    ⚠ Pods/Realm/include/core/realm/array.hpp:[539,16] did you mean 'end'?
    »     /// \param indirection an \c Array containing valid indices of values in
    »                ^~~~~~~~~~~
    ⚠ Pods/Realm/include/core/realm/util/buffer.hpp:[86,16] parameter 'copy_begin,' not found in the function declaration [-Wdocumentation]
    »     /// \param copy_begin, copy_end Specifies a range of element
    »                ^~~~~~~~~~~
    ⚠ Pods/Realm/include/core/realm/util/buffer.hpp:[86,16] did you mean 'copy_begin'?
    »     /// \param copy_begin, copy_end Specifies a range of element
    »                ^~~~~~~~~~~

Expected Results
I expect that either Realm would compile cleanly, without these warnings.
Actual Results
Realm compiles with hundreds of warnings.
Steps to Reproduce
Compile the CocoaPod.
Version of Realm and Tooling
Realm framework version: 2.7.0
Xcode version: 8.3.2
Dependency manager + version: CocoaPods 1.2.1

By the way, if this is bothering anyone else, add this to the end of Podfile:
post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings['CLANG_WARN_DOCUMENTATION_COMMENTS'] = 'NO'
        end
    end

    installer.pods_project.build_configurations.each do |config|
        config.build_settings['CLANG_WARN_DOCUMENTATION_COMMENTS'] = 'NO'
    end
end

Duplicate of #4853, we'll release a version with a fix shortly.


Publish nightly and release Docker images to public ECR

Signed-off-by: Arthur Diniz<EMAIL_ADDRESS>
What this PR does / why we need it:
This PR adds the feature to push nightly and release Docker images to AWS public ECR.
Which issue this PR fixes: https://github.com/Kong/kubernetes-ingress-controller/issues/2370
Special notes for your reviewer:
From the kong organization side, it's necessary to:

Create an IAM programmatic user inside AWS. Saving ACCESS_KEY_ID and  SECRET_ACCESS_KEY to GitHub secrets as AWS_ECR_ACCESS_KEY_ID and AWS_ECR_SECRET_ACCESS_KEY variables.
Create a public ECR repository and add an alias to it.

The IAM user needs to have a policy attached with permissions to the registry and to the specific repository. For this you can follow the official AWS documentation.
Example of policy I have used:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "AllowPush",
            "Effect": "Allow",
            "Action": [
                "ecr-public:BatchCheckLayerAvailability",
                "ecr-public:PutImage",
                "ecr-public:InitiateLayerUpload",
                "ecr-public:UploadLayerPart",
                "ecr-public:CompleteLayerUpload",
                "ecr-public:GetAuthorizationToken"
            ],
            "Resource": [
                "arn:aws:ecr-public::000000000000:repository/kubernetes-ingress-controller"
            ]
        },
        {
            "Effect": "Allow",
            "Action": [
                "ecr-public:GetAuthorizationToken",
                "sts:GetServiceBearerToken"
            ],
            "Resource": [
                "*"
            ]
        }
    ]
}

PR Readiness Checklist:
To validate this PR I have tested it inside my own AWS account and DockerHub:
GitHub actions job

ECR

Docker Hub

Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Our team doesn't have the ability to create repos or provision keys/IAM users ourselves, but I've asked the team that manages our AWS infrastructure about this.

Our team doesn't have the ability to create repos or provision keys/IAM users ourselves, but I've asked the team that manages our AWS infrastructure about this.

@rainest Any updates to share on this? I'm looking forward to having KIC images hosted on Public ECR.

Checkin in on this one?


Re-ran all notebooks, enhanced gsea

Thanks @Ecohen1763 - congrats on filing this PR. Before I can provide a full review, can you convert all your .ipynb files into .py files? This makes line diffing much easier.
Please use the command (in your terminal):
jupyter nbconvert --to=script --FilesWriter.build_directory=scripts/nbconverted *.ipynb

inside each module (folder) that you have changed

Do you have any thoughts on the following question?

One last question for you to think through: Why do the heatmaps look so different?


Bump Scalafmt from 3.7.3 to 3.7.4

Why are the changes needed?

Scalafmt 3.7.4 release note: https://github.com/scalameta/scalafmt/releases/tag/v3.7.4

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Thanks, merged to master.


[dev-7.0] lv_theme_material.c fails to compile in specific case

Description
When lv_conf.his defined with LV_USE_WIN 1 and LV_USE_TABVIEW 0 then lv_theme_material.c fails to compile.
lv_theme_material_apply() uses &tabview styles for Window style.
To Reproduce
In lv_conf.h:
#define LV_USE_TABVIEW 0
#define LV_USE_WIN 1

Expected behavior
Window style should not have a dependency on Tabview style.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
There are references to &tabview_btns, &tabview_btns_bg and &tabview_page_scrl  here: https://github.com/littlevgl/lvgl/blob/242eaa708d447812e2062d56e61a38195c11e8ba/src/lv_themes/lv_theme_material.c#L1254-L1278
When LV_USE_WIN=1 and LV_USE_TABVIEW=0, the styles tabview_btns, tabview_btns_bg and tabview_page_scrl do not exist.

Thanks for the report! I've just fixed it.


Problem between Stacked_generator and freezed

When I try to add both packages, I get this error:
"Because stacked_generator >=0.5.2 depends on analyzer ^2.0.0 and freezed >=1.1.1 depends on analyzer ^3.0.0, stacked_generator >=0.5.2 is incompatible with freezed >=1.1.1.
So, because health_home_care depends on both freezed >=1.1.1 and stacked_generator >=0.5.6, version solving failed."

How can I solve this?

I'm having the same issue with stacked_generator version 0.5.6.
Because freezed >=1.1.1 depends on analyzer ^3.0.0 and stacked_generator 0.5.6 depends on analyzer ^2.0.0, freezed >=1.1.1 is incompatible with stacked_generator 0.5.6.

We might have to update stacked to use the latest freezed package if it's not using it. I'll add this to the board and look at it when I get a chance.


feat: Helm hooks

SUMMARY

Adds Helm hooks to handle init job more cleanly
Adds option to force reload of pods on upgrade
Adds Celery worker pod

Codecov Report

Merging #11700 (05b362f) into master (95246e8) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11700      +/-   ##
==========================================
- Coverage   62.86%   62.56%   -0.30%
==========================================
  Files         889      435     -454
  Lines       43054    26870   -16184
  Branches     4016        0    -4016
==========================================
- Hits        27064    16812   -10252
+ Misses      15811    10058    -5753
+ Partials      179        0     -179

Flag
Coverage Δ

javascript
?

python
62.56% <ø> (-0.33%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/databases/commands/create.py
83.67% <0.00%> (-8.17%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/utils/celery.py
82.14% <0.00%> (-3.58%)
:arrow_down:

superset/datasets/api.py
89.56% <0.00%> (-3.30%)
:arrow_down:

superset/models/core.py
85.83% <0.00%> (-3.00%)
:arrow_down:

superset/views/core.py
71.65% <0.00%> (-2.55%)
:arrow_down:

superset/db_engine_specs/base.py
85.60% <0.00%> (-1.87%)
:arrow_down:

superset/databases/api.py
86.11% <0.00%> (-1.86%)
:arrow_down:

... and 459 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95246e8...d5eb4a6. Read the comment docs.


build linked from readme badge is failing with "The command "script/cibuild" exited with 1."

https://travis-ci.org/pages-themes/modernist is linked from badge in the readme: https://github.com/pages-themes/modernist#the-modernist-theme

Well, turns out that I wasted time on reporting this issue.

I changed the title to discourage future waste of time by myself and others and I will unsubscribe from this issue to avoid future irritation.
In case that my further input here would be useful - contact me at<EMAIL_ADDRESS>


Timed out waiting for debugger on first debugpy run

Testing https://github.com/microsoft/vscode-python-debugger/issues/35
This is the first time I used debugpy.

Attach to a process
After a few moments, there's a prompt from macOS asking something about enabling developer tools. I grant it.
In the meantime, the debug connection times out and results in a modal error

I have also been seeing this for the last few days.


diego-cell pod  does not start completely

I took the latest 2.4.0 release and tried to deploy from scratch. However, diego-cell doesn’t start fully with rep-rep container going into crashloop with below error

k8s version: 1.17.7
node os version: CentOS Linux release 7.8.2003 (Core)

I think this is a kernel issue; a recent change to garden-runc-release means it now requires Kernel version 4.5 or later:
https://github.com/concourse/concourse/issues/5711#issuecomment-638224176
I suspect that means you will need to move to CentOS 8 to get kubecf working.

I suspect that means you will need to move to CentOS 8 to get kubecf working.

Forgot to mention: garden-runc-release is only used by Diego, so if switching to a current Linux kernel is an issue, then maybe you could try switching to Eirini instead.

Thank you.  Yes, I am able to run Eirini with current centos 7.8 version. However strangely. I am unable to pull images from any docker registry. I am able to push apps though with buildpcks. Should I open a new issue for the same?

I am unable to pull images from any docker registry. [...] Should I open a new issue for the same?

Yes, please!
I can't remember testing docker apps from private repos, but it worked for apps hosted on Docker Hub as long as they used port 8080 to communicate: https://github.com/cloudfoundry-incubator/eirini-release/issues/147

Thank you for the confirmation. This explains why pushing docker images from my private registry is not working with 2.3.0. I am using different port than 8080
For 2.4.0 docker push doesn't work at all. Created an issue #1304 .


D+/D- on CH32V003FUN Board?

Hey,
so since I have one of your CH32V003FUN boards, I wanted to try the USB there. It's missing the resistors connecting the USB, so I beeped them out:

I noticed that PD4 is connected to D- and PD3 to D+. But in all your code it's the other way round. Didn't you use the same board during your streams? 🤔
I check the silkscreen on the board, PD3-PD5 are labeled correctly. Am I missing something?

D+/D- are flipped on USB low speed.  In that they mean logically opposite things.  I should have changed the labels :-/

D+/D- are flipped on USB low speed. In that they mean logically opposite things. I should have changed the labels :-/

Well different lines need to be pulled up high, but D+ always is D+ and naming the variable of the pin that is connected to D+ "DN" is kinda confusing.
I got my 0402 resistors yesterday but I'm not at home at the moment. I'll try the board with proper USB on the weekend.

@cnlohr now with the schematic and the note about your frustration (which I kind of get if you think in the swapped way) it is still confusing. LS does not swap data-lines, LS and FS just have different pull-ups und thus different idle states.
For Low-Speed, D- needs a 1K5 pull-up. Thus the idle-state / J state is D- HIGH, D+ LOW.
For Full-Speed, D+ needs a 1K5 pull-up. Thus the idle-state / J state is D- LOW, D+ HIGH.
https://en.wikipedia.org/wiki/USB_communications#Line_transition_state
I get that this looks like D+/D- are swapped. But thinking this way is what makes it confusing.
Also, why do you think of LS being the swapped one? Just think of FS being the swapped one 😎

I'm sorry I checked out for so long.  But it looks like you got this all straightened out.
And, that is fair, but no matter how you think about it being swapped or not it's still confusing >.<

Resolved with #46


Split up macos basictests into dbg and opt and set num of jobs to 1.

-- Kokoro macos workers are 1 core only
-- objc tests are designed in a wrong way and running opt and dbg configuration in parallel is not safe (talking to a wrong interop server and builds influencing each other in subtle ways)
-- tests taking too long anyway (1.5 hrs single run).
grpc_basictests.cfg will be deleted once kokoro job configuration is updated.

CC adelez@

According to my tests, there's a good chance this will fix https://github.com/grpc/grpc/issues/11987


[Developer Experience]: Add Accessibility Issue template to GitHub Issues Template

Developer Experience Issue
Please describe your Developer Experience Issue.
A clear and concise description of what the problem is. Ex. I have an issue when [...]
Currently there is no issue template to report Accessibility issues related to TechIsHiring
Describe the solution you'd like
A clear and concise description of what you want to happen. Add any considered drawbacks.
Add this Accessibility Template to the issues folder in .github: https://gist.github.com/marcysutton/346b33739135d5eaa0337e6d31704288
Use the bug template as a base, replace the wording with the one in the above template and add the Accessibility tag in the issue.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
n/a
Teachability, Documentation, Adoption, Migration Strategy
If you can, explain how users will be able to use this and possibly write out a version in the docs.
Maybe a screenshot or design?
n/a

I can do this

Hey @chadstewart is it good to work on this? I was waiting to be assigned


Why create Web Map doesn't work in localhost?

Hi @asizer & @glazou,
I have just opened a question on GeoNet about this, and I think you might already know the answer.
Could you please help me with that?
Thanks in advance!

@hhkaos -- the ArcGIS Online map viewer has a whitelist that only allows embedding in this manner on the domains arcgis.com and esri.com.

Aha, so it is not possible to use the viewer is another domain?. I suggested to a startup in our program to embed the viewer in their solution (a UAV mission planner) because I really think it make sense.
Is it possible to request Esri Inc to be included in that whitelist?
Thanks @oevans !


Fractional parts are missed during the parsing message data

Describe the bug
In our environment, we use iframeResizer to embed snippets in the UI. Sometimes the height calculated with "taggedElement" is a fractional number, e.g. 89.5px.
Whenever the host instance receives the message, it parses the value using the parseInt, so the 89.5px transforms to 89px. In case the content has a border, the bottom part is hidden.
Expected behavior
Host uses parseFloat
Screenshots

Additional context
Add any other context about the problem here.

Happy to take a PR for this

Hi @davidjbradshaw. Thanks for the quick reply.
I try to push a commit to a separate branch but receive rejection due to the lack of access rights.
Would you prefer to have an IDEA-based patch?

Just a normal PR should be fine and sorry for late reply, I have been somewhat unwell of late

Fixed in v5.0..0 #1205


AutoMLSearch does not apply pipeline_parameters to custom pipelines

Repro
from evalml.demos import load_breast_cancer
from evalml.pipelines import BinaryClassificationPipeline
from skopt.space import Categorical
from evalml.automl import AutoMLSearch
import pytest

class PipeLine(BinaryClassificationPipeline):
    component_graph = ["One Hot Encoder", "Random Forest Classifier"]

X, y = load_breast_cancer()
automl = AutoMLSearch(X, y, problem_type="binary", allowed_pipelines=[PipeLine],
                      pipeline_parameters={"Random Forest Classifier": {"n_estimators": Categorical([50])}},
                      max_batches=2)
automl.search()

rf_params = automl.full_rankings.iloc[:-1].parameters.map(lambda d: d["Random Forest Classifier"]['n_estimators'])

assert set(rf_params) != {50}

I think the issue is that pipeline_parameters is only used in allowed_pipelines is None.

@freddyaboulton in #2135 you said:

Fixes #2049, #2132, #2125

FYI for future reference, unfortunately the GitHub "fixes" keyword doesn't support that syntax! You have to say

Fixes #2049, fixes #2132, fixes #2125

Closing this issue as it was fixed by #2135


I have the problem about memory when I running Inference for model rasa

I'm running rasa run to testing. But a long time I request much message. I meet problem about memory. Memory is increase 100MB with 6000 request message. I don't know Rasa save into Cache what??. I using tracker stories SQL to save story. I try to handle Tracker which will retrieval include conversation_id and Events. But problem it not here.
So I don't know solve this problem.
I hope Rasa could explain about proble Increase Memory flowing time request to it.

Thanks for raising this issue, @Ghostvv will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

what version of rasa open source are you using?

I'm using rasa 1.9.0 and I'm using mutil worker sanic of rasa. I'm running 24 workers and I use tool to test request API to then I have problem memory increasement by the time. in processing load model, It take 20GB Mem CPU after load model finish, I start testing with tool Then I have this problem

There was a memory leak which was fixed in version 1.9.4. Please upgrade to at least that version.


Display all object masks instead of only the first

First of all thank you for your work, very useful for custom datasets!

Before the fix, only the first mask for any object is displayed (see the person on the left)

After, all the masks are displayed

@adujardin Thank you for interest in coco-viewer and your contribution!

... very useful for custom datasets!

I very glad to hear that! :)


Bug 2111240: Fix units display bug

📝 Description
This PR fixes a bug in the display of disk size units that was present in both the 'Edit boot source' modal and anywhere DiskSizeNumberInput was used. This bug would cause the units to change from its existing value to B if the existing value was deleted or the value was changed to zero.
Screenshots
Edit boot source reference modal
Before:

After:

Add disk modal
Before:

After:

thanks for this PR @pcbailey , i left some comments :)

@avivtur @metalice @glekner @vojtechszocs @upalatucci @hstastna PTAL

@metalice @hstastna Please re-review.

Cool. Let's merge :)

@metalice I pushed the changes. I'm going to open a separate PR to replace what we can in src/views/catalog/utils/quantity.ts so we can get rid of byteSize entirely and use only xbytes.

/lgtm


"Export" credential to be raplaced by "share"

The export is indeed too limited,
we would need to use the share method of IOS or Android
Button should be same background and text color  as the "Delete this card" button

Size: S


Need a test framework to write tests for the add-ons

The end goal is we should be able to test these add-ons against specific OpenShift and Minishift versions. Contributors should be able to contribute a test file which would test the add-on. Also we should be able to test these add-ons for each Minishift release in an automated way.
This way we can maintain the quality of the repository and it will enable us to keep the add-ons in good shape.

I believe we discussed to prefer using our test features as written in
Cucumber. Also, Mario @l0rd, had taken a glance at this and believes it
would be possible to get some basic tests for the Che plugin

@LalatenduMohanty @gbraad we are working on a cucumber (godog) tests for Che addon. I believe @JPinkney is really close to open a PR.

great news!

Hi @l0rd, I am working on PR which enables usage of Minishift integration tests as a package (https://github.com/minishift/minishift/issues/1970), once this PR is merged I will implement it in this repository (prove of concept works agajdosi/minishift-addons:#67).
After that @JPinkney can continue with PR for the Che addon. We are now the blocking part for the Che addon, trying to resolve it ASAP, thanks for understanding.

Ok thank you @agajdosi for this update

My idea of "Test framework" for minishift-addon repo.
As as first cut, we should able to install and apply as part of nightly build.
Create issue https://github.com/minishift/minishift/issues/1976 to introduce new field as Maintainer so that we know who is maintaining the addon and if CI fails for any particular addon, we should notify to the respective maintainer.
We can automate the notification part as well.

@budhrg AFAIU we would ideally need one Minishift start per add-on to prevent any interferences between add-ons. As we plan to run the tests once per day it seems realistic to have it one start per add-on.
We could achieve it with Gherkin:
@cors
Feature: Cors Add-on
  As Minishift user I can install and apply Cors add-on from minishift-addons repository.

  Scenario: Installing the add-on
     When file from "https://raw.githubusercontent.com/minishift/minishift-addons/master/add-ons/cors/cors.addon" is downloaded into location "download/cors"
      And executing "minishift addons install ../../out/integration-test/download/cors" succeeds
     Then stdout should contain "Addon 'cors' installed"

  Scenario: Minishift starts
    Given Minishift has state "Does Not Exist"
     When executing "minishift start" succeeds
     Then Minishift should have state "Running"

  Scenario: Applying the add-on
    Given Minishift has state "Running"
     When executing "minishift addons apply cors" succeeds
     Then stdout should contain "CORS is now allowed from any address"

  Scenario: Deleting Minishift
    Given Minishift has state "Running"
     When executing "minishift delete --force" succeeds
     Then Minishift should have state "Does Not Exist"

As this basic install&apply feature is relatively easy to read it could serve also as simple example for add-on developers which could encourage them to expand the test. WDYT?

Scenario: Applying the add-on

Some of the addons like Istio is tricky here and writing its feature file is not that easy.
I think if we provide a framework where they can provide the tests in shell file then it is easy for us to run those tests.

Resolved via https://github.com/minishift/minishift-addons/pull/85


Validator rule for .editorconfig file

It's quite common that repository that doesn't have this .editorconfig file, people who contribute that repository will use different settings for eg. following;

Line endings
Indentation rules
etc

And to make some common ground for all .editorconfig is the rescue - https://editorconfig.org/

To define this further:

Are there some cases when .editorconfig is not needed? ie. some project type / ide which doesn't support this? It would be good if we can automatically take these into account
I think could also have automatic fix, or at least we can offer a base for editor config, similar to readme.md base? Are there some defaults we could offer here?

@tarlepp Do you have some kind of statistics where .editorconfig is usually located?

@tarlepp Do you have some kind of statistics where .editorconfig is usually located?

In the root of the repository, there might be some other subdirectories too - but the main one should be in the repository root - and sorry for late answer.

2. I think could also have automatic fix, or at least we can offer a base for editor config, similar to readme.md base? Are there some defaults we could offer here?

For this I wouldn't make PR to fix that, issue itself could just point to EditorConfig - and why that?

Different projects/teams are using different style of eg. indentation rules
I don't think that we really can make one base to rule those all - that's why the link to official site should be enough

Are there some cases when .editorconfig is not needed? ie. some project type / ide which doesn't support this? It would be good if we can automatically take these into account

If it's not needed that repository could add that check to ignore list - right?
IDE support of .editorconfig is quite massive - https://editorconfig.org/#download


Add empty default

Currently when you create and add a new icon that does not exist on the sprite it breaks the component render.
How about adding a default empty one when there is no match?
We a can also display a warning to the user on the console.

Hi @jpsc, thanks for using vue-svg-sprite.
I'm not sure to get the point…
You use <svg v-svg symbol="missing-icon"></svg> and it breaks the rendering?
The plugin should not care about the fact that there is, or not, this symbol inside the SVG spritesheet…

@thierrymichel you are right. When I reported it was happening to me. Now I can't reproduce it.
Thanks for the answer anyways.


added policy id to docs/log message

What is this PR About?
Makes it easier to know what is failing quicker
Check list

[x] Have you created a test case in _test/conftest-unittests.sh
[x] Have you created a test case in _test/opa-profile.sh
[x] Have you created a test case in _test/gatekeeper-integrationtests.sh
[x] Have you followed the TESTING.md doc? If not, please provide commands/steps to test this PR.
[x] Have you re-generated POLICIES.md

cc: @redhat-cop/rego-policies

/approve

/approve

/lgtm

/lgtm


Asynchronous load doesn't work on IE

loading cufón using RequireJS or a simple script injection after DOM ready - document.createElement('script') - breaks cufón on IE 6-8.
it seems that the VML is inserted but it is not displayed properly (used IE8 developer tools to check the DOM).
loading cufon.js using a regular <script> tag solves the problem...

This does not work in IE because it does document.write while registering VML engine. (I just fixed that in my project)
Doing document.write in IE after Dom-Ready is a no-no!
After some blame investigation I found that this line was rewritten from document.createStyleSheet (due to "operation aborted" problem?!) few years ago. I would like to submit patch for this but I'm not sure how to test it properly not to introduce a regression.

There is a potential issue in the referenced patch that I have encountered before, but I no longer have any idea what it was. Applied and fixed, if something breaks we'll at least know what the issue was and be able to fix it again.


Hiding transaction data on archived Collectives

We've got a situation right now where there's a dispute between people involved in a Collective that's now archived. Someone who was not a Collective admin is reaching out to us as fiscal host wanting the historical transaction data for the Collective, which they can't see because it's archived, but we can as Host admins.
Why is transaction data hidden for archived Collectives? Isn't this against our value of transparency? It creates a weird power dynamic where the Collective admin can't be held accountable by expense payees retroactively because of lack of access to the data.

What is the Collective? I confirm we don't want this, it's against transparency, so it's a bug.

That can happen with funds and projects because they're allowed to hide their budgets. But @znarf is right, if it's a collective then we have a bug.

After private discussion, It was indeed a Fund.


Building and running tests with Maven

Hi Friends!
I dare to suggest this pom.xml which uses kotlin-maven-plugin to allow building the exercises and testing them with maven (as another option in addition to having idea / eclipse project files).

What is the status of this PR? I think the commits that solve the koans should not be included here, but I support having the pom.xml in master (did not test if it works).
Will this be merged into master eventually?

Hi all!
@RodionGork thank you for your pull request.
@RodionGork, @fwilhe Why do you want to have this project built with maven?
I'm afraid having two options for being built is not a good idea, because we could end up with two different versions of Kotlin: one from maven, another from plugin. I could change and build the project with maven by default, but I'm not sure whether everyone will prefer this way. Currently you have to know nothing about maven to solve tasks, that might be good for some people.

I'm closing this pull-request for now. However, we can discuss building the project with maven. If necessary the changes can be easily made.

Hi @svtk,
I don't consider relying on the IntelliJ-plugin good practice. Maven (and also gradle) are the defacto-standards for java projects, and from my experience it works quite well with Kotlin and with the IntelliJ-plugin. I would generally prefer a stronger focus on those tools that all Java developers know by the Kotlin team. I think this would make it easier to convince Java developers to switch to Kotlin.

Maven and Gradle are de-facto standards for Java projects. Koans are not a project, they're a playground; they do not benefit from any advantages that Maven and Gradle bring to real projects. Also, the target audience of koans includes novice developers that have no experience with using any of the tools that all experienced Java developers know.

Also, the target audience of koans includes novice developers that have no experience with using any of the tools that all experienced Java developers know.

@yole I don't fully agree with that. While is true that the project should be really easy to use for any level of expertise, I think it also should be independent of the IDE or tool the developer wants to use and not force to an specific IDE. In my expierience usually the first tool to use is Java is Eclipse, but nowadays more and more people use tools like Atom or Brackets. Isn't Kotlin aiming for the web also with a JS compiler? Does not then make sense to allow the use of something like the last tools mentioned?
If the answer is yes, I think that using a building tool is the way to go, and going into more detail, Gradle can be easily be set to easily allow execution from IDEs or command line with 0 knownledge.
The Wrapper and some custom tasks can get the job done, for instance, Groovy koans get that done quite nicely https://github.com/nadavc/groovykoans.

@abelsromero Tooling is a major part of Kotlin, and we invest in building tools that run in IDEA (first and foremost) and Eclipse (secondary). Therefore, we need to drive beginner developers towards those tools, show them that they exist, and teach them how to use them. Pretending that people using Atom or Brackets will get the same level of productivity when using Kotlin as people using IntelliJ IDEA will not do anyone any service.


Align text example with image

closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/10379

@CarolynRowe
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


[Bug] Current maven pulsar-client source jar empty

Search before asking

[X] I searched in the issues and found nothing similar.

Version
2.10.3, 2.11.0 I didn't test other versions
Minimal reproduce step
down load source jar from central maven repository.
pulsar-client-2.11.0-sources.jar https://repo1.maven.org/maven2/org/apache/pulsar/pulsar-client/2.11.0/pulsar-client-2.11.0-sources.jar download this jar  decompress it no source code is found.
What did you expect to see?
in IDE we need source code to debug problems.
What did you see instead?
source code.
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

I'm afraid that the real source code comes from pulsar-client-original and you should configure the source there.
cc @merlimat thoughts?

the intellj idea IDE default will download this jar. I tried to download many times finally find it is empty.

@lifepuzzlefun OK. I find a way to create a source jar. You may help test or wait for the next release.

@tisonkun thanks for the feedback. And we can help more people if we can re-upload the origin release missing source jar in the maven central repository. Hope to see to see the fix.

@lifepuzzlefun FYI - #19956. Be aware that you need to install client original source jar for picking it in shading pulsar-client-all.
Run:
mvn clean install -P apache-release -DskipTests -Dlicense.skip=true -Drat.skip=true -Dcheckstyle.skip=true

can verify the result.

re-upload

I don't think so. Released artifacts should be immutable. I don't know even if Maven central support editing existing artifaces.


added my profile in contributers list

LEARNING HOW TO CONTRIBUTE

how can i edit my pull request on browser

@yashhhh04 Thankyou for your contribution!!


32bit BITFIELDS compresion codec support #5707 Fixed

#5707 Fixed - cannot attach file while github not support 32bit images, if required can post image on which i have got bug and fix it.

:+1:


chore(openapi): update kafka-admin/v1 OpenAPI document

This pull request was auto-generated
This PR adds the latest version OpenAPI document version for kafka-admin/v1.
SDK update procedure

Review changes on OpenAPI file and validate if they are correct
Perform manual changes if needed or apply local patches for the OpenAPI files
Merge PR
Merge automatically generated PR with source code when build passes
Perform release on github with new changes

@craicoverflow I see that reviewers are not assigned anymore. Would we use team you have created?

Looks like it is a bug.
https://github.com/redhat-developer/app-services-sdk-js/blob/main/.github/workflows/generate.yaml#L32
This should not have the "@" prefix.


Replace Autocomplete Types link with Autofill

The Autocomplete Types spec has been moved to the Autofill spec. Update the README link.

thanks!


Advance to first position of 1 in BitSet before iterating the lead in BitSetConjunctionDISI?

Description
In BitSetConjunctionDISI, we iterate over the DocIdSetIterator of lead, and then lookup the BitSets to get conjunction. currently, we use bitSet.length() to limit the termination of the iteration, the similarly, maybe we can consider use bitSet.nextSetBit(0) to set the start doc of the iteration. some scenarios may have more zeros at the beginning of the BitSet, for instance, the retention query in Elasticsearch using an increasing number field(_seq_no), it may save the result to BitSet with more leading zeros.

I'm not sure I like this idea, which feels quite arbitrary: why would there be a big gap of matching doc IDs towards the start of the doc ID space, and not in the middle or towards the end?
This BitSetConjunctionDISI was mostly added to mimic the way FilteredQuery used to work (before we replaced filters with queries and FilteredQuery with FILTER clauses on BooleanQuery) to avoid performance regressions. Maybe we can improve the heuristic regarding when to use it, which could in-turn help the case you're looking into? For instance we currently evaluate filters via Bits#get rather than BitSet#nextSetBit when their cost is greater than the minimum cost across all required clauses. In a similar context, IndexOrDocValuesQuery only uses doc values to run queries when their cost is 8x greater than the lead cost, maybe it would be a better threshold for evaluating filters via Bits#get as well?

@jpountz Thanks very much for the guidance! Your explanation makes sense to me, I'll try this idea :)


Environment Issue

Issue Type: Feature Request
I am a trainee. I started learning blockchain developer course through cognitive classes collaborated by IBM and following their tutorials I tried downloading and start the embedded instance of Hyper ledger Fabric, but it shows that the environment failed to become available and notified me to check the docker container logs for more details. But I couldn't find any such. Please guide me on this issue.
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:40:02.816Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

This is not a VS Code issue. Please ask the authors of "Hyper ledger Fabric" or the "blockchain developer course" for help.


Use workshop to get md5sum of client-server container image

Client-server container images are uniquely identified by their image tag, in that the tag is an md5sum of a combination of software requirements that were used to construct the image.  Currently, rickshaw-run generates this md5sum, based on a md5sum of all workshop-requirement and userenv files.  This is both too much input and not enough.  It's too much because there's a lot of info in these files which may have nothing to do with the current userenv (like a RPM for rhubi8, but you are building for userenv fedora33).  It's also not enough input, because these workshop requirement files alone may not have enough information in them to get a unique md5sum.  For example, having a "manual" requirement which compiles a git repo may have source files change over time.
For these reasons, we need to use workshop to get the md5sum for us.  Workshop will only use the actual requirements (requirements that apply to only the userenv requested), and eventually, workshop will support something better for source-built requirements (likely generating a md5sum on the source files).

I already did a bunch of fixes towards improving this, most notably the first one:
https://github.com/perftool-incubator/rickshaw/commit/d5c88850d825ea42d35a807daf2b54e8cc5df68f
https://github.com/perftool-incubator/rickshaw/commit/c5e8b986134c9edcc5f87e1471a0b2e290ac9f2d
https://github.com/perftool-incubator/rickshaw/commit/c678e8a7256e1a7f3f6ca0ee14e36fbd03a3fde3

I already did a bunch of fixes towards improving this, most notably the first one:
https://github.com/perftool-incubator/rickshaw/commit/d5c88850d825ea42d35a807daf2b54e8cc5df68f
https://github.com/perftool-incubator/rickshaw/commit/c5e8b986134c9edcc5f87e1471a0b2e290ac9f2d
https://github.com/perftool-incubator/rickshaw/commit/c678e8a7256e1a7f3f6ca0ee14e36fbd03a3fde3


TypeError: this.htmlWebpackPlugin.getHooks is not a function

Hello,
When running cra-build-watch (v3.2.0) I got this error:
TypeError: this.htmlWebpackPlugin.getHooks is not a function
This issue https://github.com/jantimon/html-webpack-plugin/issues/1110 indicates that getHooks requires html-webpack-plugin v4, but this lib still use v3.

Merging https://github.com/Nargonath/cra-build-watch/pull/198 would solve the issue. Targeting the commit hash in package.json in the meantime.

Hey @Janaka-Steph how did you resolve this? Having this issue too.

@Nargonath please update html-webpack-plugin to 4.5.0, we getting this error when using cra@4

:tada: This issue has been resolved in version 3.3.0 :tada:
The release is available on:

npm package (@deploy dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update to Jarkarta Mail 1.6.7

Thanks for the contribution.
That said, I have no idea why we have this mail dependency here. I just removed it: https://github.com/pac4j/pac4j/commit/faaebbc8ca39a85f585941fdb5d4c64634bad329
Closing the PR.


feat(select): sync with @carbon/react

Related Ticket(s)
[select]: sync with @carbon/react version #10116
Description
@carbon/react syncing with select component.
@carbon/react version: https://react.carbondesignsystem.com/?path=/story/components-select--playground
Also adjusted the recently sync'ed layer component styles to match v11.
Changelog
Changed

select update to match v11 storybook
move slotted styles for layer - they are meant for the storybook example instead

@annawen1 select is working great. I noticed a 1px height difference between react and WC – I'm guessing it's the bottom border/rule?
React:

WC:

@annawen1 select is working great. I noticed a 1px height difference between react and WC – I'm guessing it's the bottom border/rule?
React:
WC:

weird, so the styles are the exact same coming from carbon core so I'm not too sure what could be causing the height to differ by 1px. Both have the border 1px applied via styles so it should be the same - my guess is that because the sizes are rem based and we still have to fix the plex styles being imported - it could be causing this small difference. I'm going to merge it in for now and check back again when we fix the font import issue.


Unwrap close and open methods

This is needed to keep the class coding style, improving readability

I'd definitely consider this an improvement.

Can we have this merged?

Thanks for your contribution @vnbrs !


In update!, skip rows with all missing or nothing values by default

In update!, skip rows with all missing or nothing values by default. This is similar to the previous Observer behavior, and let's you more easily skip saving data at certain iterations.
@emstoudenmire I noticed this was a feature that had been dropped by the new redesign.

Great, I was wondering if this feature of DataFrames i.e. the possibility of having missing entries, was being used together with the previous upgrade we did on Observers where a function can return nothing.


Training procedure for my own dataset to detect unknown objects

Hi @JosephKJ ,I've trained a model which can detect known objects for my own dataset,but it can not detect unknown objects . I want to know what training procedure i should follow for my own dataset (which YAML file i should use step by step) to detect unknown objects.
THANKS!

Have you trained it using the proposed ORE methodology?

Have you trained it using the proposed ORE methodology?

I trained it using the  python tools/train_net.py  command.  And the config file I used is based on t1_train.yaml,Base-RCNN-C4-OWOD.yaml  which I have modified it to adapt to my task.

i wanna to train my custom data, so i need to prepare two xml for the same picture, with or without unknown label?

: We might have to adapt the data-loader to your needs. Can you shed some light on how your custom dataset is like and how you are planning to have the class split

Have you solved this problem？


Add RequireFeature(s) extension methods for IEndpointConventionBuilder

Add RequireFeature(s) extension methods for IEndpointConventionBuilder to specify that a route requires a feature(s) to be enabled for the endpoint to be enabled (similar to action filters). Methods should be:
- RequireFeatures(features)
- RequireFeatures(requirementType, features)
- RequireFeatures(Action<FeatureActionFilterBuilder> configure)

The requirementTypes param should be of the RequirementType enum type.
This will also require adding a new FeatureActionFilterBuilder class.

Added RequireFeature and RequireFeatures methods for v1.3.0. No longer adding FeatureActionFilterBuilder overload.


Update the TTL health check handler and health check streams

to handle the direct update in the health check topic with action UPDATE.

 Update the TTL health check handler and health check streams light-controller master


string ends with dot is recognized as valid domain

const result = parseDomain("example.co.jp."); // string ends with a dot
if (result.type === ParseResultType.Listed) {
  console.log(":(")
}

"example.co.jp." is a valid domain. The empty label in the end is the root label and considered to be valid.
See Fully qualified domain name


Position dynamics above the staff for vocal staffs

Is the logic to put dynamics above if there are any <syl>s or @syls on the respective staff acceptable?

Not a 'must have', but reasonable. Thanks!

We could also allow the user to supply a parameter to choose if he wants this behavior.


Connection string interpreted differently for connect and create_database

Bug Description
In SqliteConnectOptions  during create database connection string is handled as a raw &str:
https://github.com/launchbadge/sqlx/blob/253d8c9f696a3a2c7aa837b04cc93605a1376694/sqlx-sqlite/src/options/parse.rs#L122
When pool is created through AnyPoolOptions it is converted to an URL that treats things a bit different:
https://github.com/launchbadge/sqlx/blob/253d8c9f696a3a2c7aa837b04cc93605a1376694/sqlx-core/src/any/options.rs#L26
For example:

sqlite://foo.db interprets foo.db as the host
sqlite://../../foo.db strips a few .. and it tries to open foo.db from the root folder (path = /foo.db by url parse)

sqlite://./foo.db strips a few .. and it tries to open foo.db from the root folder (path = /foo.db by url parse)

sqlite://:memory: is not a valid cns for pool connection - url parse states it is an empty host.
etc.
The net result is that, the database is created at a different location and makes the AnyPool broken. I don't think if it is a good idea to interpret the cns as an url as that has a slightly different meaning and some special rules.

Info

SQLx version: 0.7.0-alpha.3
SQLx features enabled: any, sqlite
os: window, but I think a similar issue is valid for any other OS.

edit: fix typos

I'm not using sqlx any more, not an issue for me...


How to load SimMIM Swin-B pretrained model in mmdet? Error with "AssertionError: backbone. is not in the pretrained model"

Hi,
Thanks for great job.
I try to load SimMIM Swin-B pretrained model in mmdet, but failed with AssertionError: backbone. is not in the pretrained model
How can I load the SimMIM pretrained model in mmdet?
The pretrained model is from https://download.openmmlab.com/mmselfsup/simmim/simmim_swin-base_16xb128-coslr-100e_in1k-192_20220316-1d090125.pth
Error message is:
Traceback (most recent call last):
  File "tools/train.py", line 189, in <module>
    main()
  File "tools/train.py", line 163, in main
    model.init_weights()
  File "/dfs/data/miniconda/envs/mmdet_vitdet/lib/python3.8/site-packages/mmcv/runner/base_module.py", line 116, in init_weights
    m.init_weights()
  File "/dfs/data/open_mmlab/mmclassification/mmcls/models/backbones/swin_transformer.py", line 414, in init_weights
    super(SwinTransformer, self).init_weights()
  File "/dfs/data/miniconda/envs/mmdet_vitdet/lib/python3.8/site-packages/mmcv/runner/base_module.py", line 105, in init_weights
    initialize(self, self.init_cfg)
  File "/dfs/data/miniconda/envs/mmdet_vitdet/lib/python3.8/site-packages/mmcv/cnn/utils/weight_init.py", line 613, in initialize
    _initialize(module, cp_cfg)
  File "/dfs/data/miniconda/envs/mmdet_vitdet/lib/python3.8/site-packages/mmcv/cnn/utils/weight_init.py", line 517, in _initialize
    func(module)
  File "/dfs/data/miniconda/envs/mmdet_vitdet/lib/python3.8/site-packages/mmcv/cnn/utils/weight_init.py", line 499, in __call__
    state_dict = _load_checkpoint_with_prefix(
  File "/dfs/data/miniconda/envs/mmdet_vitdet/lib/python3.8/site-packages/mmcv/runner/checkpoint.py", line 513, in _load_checkpoint_with_prefix
    assert state_dict, f'{prefix} is not in the pretrained model'
AssertionError: backbone. is not in the pretrained model

My environment is
# Name                    Version                   Build  Channel
mmcls                     0.23.1                   pypi_0    pypi
mmcv-full                 1.4.2                    pypi_0    pypi
mmdet                     2.19.1                    dev_0    <develop>
mmselfsup                 0.9.1                     dev_0    <develop>
timm                      0.5.4                    pypi_0    pypi

My mmdet config file is
_base_ = [
    '../_base_/models/mask_rcnn_r50_fpn.py',
    '../_base_/datasets/coco_instance.py',
    '../_base_/schedules/schedule_1x.py', '../_base_/default_runtime.py'
]

# please install mmcls>=0.22.0
# import mmcls.models to trigger register_module in mmcls
custom_imports = dict(imports=['mmcls.models'], allow_failed_imports=False)

checkpoint_file = 'ckpts/simmim_swin-base_16xb128-coslr-100e_in1k-192_20220316-1d090125.pth'

model = dict(
    backbone=dict(
        _delete_=True,
        type='mmcls.SwinTransformer',
        arch='base',
        img_size=224,
        drop_path_rate=0.2,
        out_indices=(0, 1, 2, 3),
        init_cfg=dict(type='Pretrained', checkpoint=checkpoint_file,prefix='backbone.')
    ),
    neck=dict(in_channels=[128, 256, 512, 1024])
)

optimizer = dict(
    _delete_=True,
    type='AdamW',
    lr=0.0001,
    betas=(0.9, 0.999),
    weight_decay=0.05,
    paramwise_cfg=dict(
        custom_keys={
            'absolute_pos_embed': dict(decay_mult=0.),
            'relative_position_bias_table': dict(decay_mult=0.),
            'norm': dict(decay_mult=0.)
        }))
lr_config = dict(warmup_iters=1000, step=[8, 11])
runner = dict(max_epochs=12)

The prefix should not be set, since the backbone. prefix has been removed in the provided checkpoint. Thanks!

I set prefix = None in mmdet config file, and it works.
But found that  mmcls  Swin-B model does not match with mmselfsup  SimMIM Swin-B model exactly.
Does this impact the model accuracy in mmdet?
Below is the log.

_2022-08-02 16:30:04,003 - mmcv - WARNING - The model and loaded state dict do not match exactly
unexpected key in source state_dict: mask_token
missing keys in source state_dict: stages.0.blocks.0.attn.w_msa.relative_position_index, stages.0.blocks.1.attn.w_msa.relative_position_index, stages.1.blocks.0.attn.w_msa.relative_position_index, stages.1.blocks.1.attn.w_msa.relative_position_index, stages.2.blocks.0.attn.w_msa.relative_position_index, stages.2.blocks.1.attn.w_msa.relative_position_index, stages.2.blocks.2.attn.w_msa.relative_position_index, stages.2.blocks.3.attn.w_msa.relative_position_index, stages.2.blocks.4.attn.w_msa.relative_position_index, stages.2.blocks.5.attn.w_msa.relative_position_index, stages.2.blocks.6.attn.w_msa.relative_position_index, stages.2.blocks.7.attn.w_msa.relative_position_index, stages.2.blocks.8.attn.w_msa.relative_position_index, stages.2.blocks.9.attn.w_msa.relative_position_index, stages.2.blocks.10.attn.w_msa.relative_position_index, stages.2.blocks.11.attn.w_msa.relative_position_index, stages.2.blocks.12.attn.w_msa.relative_position_index, stages.2.blocks.13.attn.w_msa.relative_position_index, stages.2.blocks.14.attn.w_msa.relative_position_index, stages.2.blocks.15.attn.w_msa.relative_position_index, stages.2.blocks.16.attn.w_msa.relative_position_index, stages.2.blocks.17.attn.w_msa.relative_position_index, stages.3.blocks.0.attn.w_msa.relative_position_index, stages.3.blocks.1.attn.w_msa.relative_position_index, norm0.weight, norm0.bias, norm1.weight, norm1.bias, norm2.weight, norm2.bias_

It's OK. Since relative_position_index will be set to the initial value during the whole training process, whether or not loading it has marginal impact on the final result.

Got it. Thanks a lot for kindly classification.


select: disabling filter does not work

Description of the issue
Select has an variant to disable option filtering, but it is not working.
Impacted component(s)

pf-select
pf-listbox

Steps to reproduce

Go to Select documentation -> Disable filtering
Type "B".

Expected behavior
All options should be showing.

I can take this one

does upstream have a feature to disable the filter in this way? http://v4-archive.patternfly.org/v4/components/select I couldn't find it here

let's come back to this in pfev5


Update zio-magic to 0.3.7

Updates io.github.kitlangton:zio-magic from 0.3.6 to 0.3.7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.github.kitlangton", artifactId = "zio-magic" } ]

labels: library-update, semver-patch

Superseded by #242.


Adjust method not supported to specific prompt

Description

This PR has:

[x] been self-reviewed.

[x] concurrent read
[ ] concurrent write
[x] concurrent read and write

Key changed/added classes (or packages if there are too many classes) in this PR

Sorry for the misoperation.

Sorry for the misoperation.

Hi, to resolve the test failed issue, you may need to apply spotless again...

Coverage increased (+0.02%) to 67.979% when pulling 163d2cce051794142b104775ff75c03a78e53d04 on CloudWise-Lukemiao:master into 915fb433caf757cda7b82795513e5925ac4b4f0f on apache:master.

jdbc add IoTDBJDBCDataSet


Ability to configure Markdig.MarkdownPipelineBuilder

Hello
This is a great framework. While exploring its capabilities I found the limitation that you cannot render tables by default.
I know you can write a table in the native HTML within the markdown file and this will render (#152). However, this is not the most convenient for my scenario. I have a lot of tables and the tables are in pipe format.
I noticed the markdown editor in preview will render pipe tables correctly. However, when the post is saved and published the table renders as a paragraph

.
This is because by default, without any options the use of Markdig within the PostController is using the plain CommonMark parser:
model.Post.Content = Markdown.ToHtml(p.Content);

In order to activate most of all advanced extensions like table rendering, a MarkdownPipelineBuilder has to be initialized:
var mpl = new MarkdownPipelineBuilder().UsePipeTables().UseAdvancedExtensions().Build()
model.Post.Content = Markdown.ToHtml(p.Content, mpl);

There is no way to inject a MarkdownPipelineBuilder into Core.Api to change the default behaviour.
I would like to suggest a feature to be able to configure the MarkdownPipeline for the next iteration. Default would be plain CommonMark parser. But if I, say, registered a MarkdownPipelineBuilder with the DI IServiceCollection it would use this for parsing.
Thanks for reading,

I did not know about that, need to take a look, thanks for a pointer.

Implemented, may do a configuration later if needed.


Prevent merging controller on itself

If you merge a controller on itself, it locks up unity until you force a close.

done a while ago


[FLINK-12273]The default value of CheckpointRetentionPolicy should be …

…RETAIN_ON_FAILURE, otherwise it cannot be recovered according to checkpoint after failure.]

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I think this may be a good new default, but we need to discuss that on the mailing list first, because it affects existing setups.
We also need to mention this in the release notes for the next release.

@Mr-Nineteen Can you start this discussion?
I would suggest to close this PR until the discussion has consensus and open it after that.

@StephanEwen
Ok.
I think it's important to change this default.If some users don't know much about flink, it's easy to bring huge losses in production.Therefore, flink needs to consider this aspect and also bring a better experience to users.


Restructuring ModelVersion and LocalModel

Introduced breaking changes to the API: class names, method names, method parameters, etc.

Introduced unified request error handling for checking/raising client-side/server-side errors.

Removed all code for parsing yaml definitions. It only makes sense to use it within CLI, so it will reside there.

Removed UploadResponse object. Now LocalModel.upload returns ModelVersion instance directly.

Removed Metricable class as it's no longer makes sense to carry arround a whole class for just two methods for a signle usage.

Removed Cluster.connect method in favor of pure class constructor.

Took out uploading metrics from LocalModel and transferred functionality to ModelVersion. Now there are two new methods on a ModelVersion instance: .as_metric(threshold=10, comparator: ThresholdCmpOp.LESS_EQ) and .assign_metrics([metric]). Instead of manually handling MetricSpecConfig, MetricSpec user can work with this:
mv1 = ModelVersion.find_by_id(cluster, 1)
mv2 = ModelVersion.find_by_id(cluster, 2)
mv2.assign_metrics([mv1.as_metric(10, ThresholdCmpOp.LESS_EQ)])

Added functionality for uploading training data. Current implementation of wait is a subject of change in the future releases.
modelversion = ModelVersion.find(cluster, "my-model", 1)
modelversion.training_data = "s3://bucket/path/to/training-data.csv"
data_upload_response = modelversion.upload_training_data()
data_upload_response.wait(retry=3, sleep=30)

Improved/refactored tests regarding cluster entities (Application, ModelVersion, etc).

Added/updated class-level documentation with code-snippets for important Hydrosphere entities.

Fixed various misspellings and minor bugs.

What has been done:

Introduced breaking changes to the API, hense class names, method names, method parameters, etc.

Introduced unified request error handling for checking/raising client-side/server-side errors.

Removed all code for parsing yaml definitions. It only makes sense to use it within CLI, so it will reside there.

Removed UploadResponse object. Now LocalModel.upload returns ModelVersion instance directly.

Removed Metricable class as it's no longer makes sense to carry arround a whole class for just two methods for a signle usage.

Removed Cluster.connect method in favor of pure class constructor.

Took out uploading metrics from LocalModel and transferred functionality to ModelVersion. Now there are two new methods on a ModelVersion instance: .as_metric(threshold=10, comparator: ThresholdCmpOp.LESS_EQ) and .assign_metrics([metric]). Instead of manually handling MetricSpecConfig, MetricSpec user can work with this:
mv1 = ModelVersion.find_by_id(cluster, 1)
mv2 = ModelVersion.find_by_id(cluster, 2)
mv2.assign_metrics([mv1.as_metric(10, ThresholdCmpOp.LESS_EQ)])

Added functionality for uploading training data. Current implementation of wait is a subject of change in the future releases.
modelversion = ModelVersion.find(cluster, "my-model", 1)
modelversion.training_data = "s3://bucket/path/to/training-data.csv"
data_upload_response = modelversion.upload_training_data()
data_upload_response.wait(retry=3, sleep=30)

Improved/refactored tests regarding cluster entities (Application, ModelVersion, etc).

Added/updated class-level documentation with code-snippets for important Hydrosphere entities.

Fixed various misspellings and minor bugs.

What has been done:

Introduced breaking changes to the API, hense class names, method names, method parameters, etc.

Introduced unified request error handling for checking/raising client-side/server-side errors.

Removed all code for parsing yaml definitions. It only makes sense to use it within CLI, so it will reside there.

Removed UploadResponse object. Now LocalModel.upload returns ModelVersion instance directly.

Removed Metricable class as it's no longer makes sense to carry arround a whole class for just two methods for a signle usage.

Removed Cluster.connect method in favor of pure class constructor.

Took out uploading metrics from LocalModel and transferred functionality to ModelVersion. Now there are two new methods on a ModelVersion instance: .as_metric(threshold=10, comparator: ThresholdCmpOp.LESS_EQ) and .assign_metrics([metric]). Instead of manually handling MetricSpecConfig, MetricSpec user can work with this:
mv1 = ModelVersion.find_by_id(cluster, 1)
mv2 = ModelVersion.find_by_id(cluster, 2)
mv2.assign_metrics([mv1.as_metric(10, ThresholdCmpOp.LESS_EQ)])

Added functionality for uploading training data. Current implementation of wait is a subject of change in the future releases.
modelversion = ModelVersion.find(cluster, "my-model", 1)
modelversion.training_data = "s3://bucket/path/to/training-data.csv"
data_upload_response = modelversion.upload_training_data()
data_upload_response.wait(retry=3, sleep=30)

Improved/refactored tests regarding cluster entities (Application, ModelVersion, etc).

Added/updated class-level documentation with code-snippets for important Hydrosphere entities.

Fixed various misspellings and minor bugs.

Great work 👍 .
p.s. A bit difficult to code-review this large PR's 😄
@KineticCookie  what do you think about

Removed all code for parsing yaml definitions. It only makes sense to use it within CLI, so it will reside there.
?

Great work 👍 .

@trthhrtz Would you mind changing your review status from "Request Changes" to "Approved" then?) 🙂

@Valenzione yeah, I just need to get replies from @KineticCookie and ready to approve

Did minor refactoring, resolved conflicts @Valenzione

👍


rework parse:utils

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (49f3c30) 95.06% compared to head (f3527db) 95.06%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   95.06%   95.06%
=======================================
  Files          21       21
  Lines         162      162
  Branches       14       14
=======================================
  Hits          154      154
  Misses          8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Teaser images in sharing

Michael, I'm sorry to have to bother you with this, but I can't get teaser images to show up right in Twitter or Facebook. I notice the sharing links don't show up at all on the skinny-bones demo site. On mine Twitter Cards will appear, but with either the default site teaser or Twitter's no-image image, and the default shows up on Facebook. It's working fine at mademistakes.com, and _includes/open-graph.html is the same there, and the issue isn't in _includes/share-this.html as far as I can tell. Any ideas?

Are you certain you've assigned a feature image to a post? The large summary Twitter card meta pulls in page.image.feature. If you don't have something like:
image:
  feature: your-large-feature-image.jpg

Then it falls back to using whatever the site.logo in _config.yml is.
For example one of the sample media posts on the demo site shows this as it's Twitter card.

Also if you happened to test a page with Twitter either by tweeting it or the card validator site it's likely been cached. If you change it and test again it doesn't always act like it's been updated. I don't know if there's a way to force Twitter to rescrape the page like Facebook's Open Graph debugger.
In my experience social sharing has been a mixed bag when it comes to Twitter, Facebook, or Pinterest properly pulling in the correct images and meta info. Images can be particularly dicey if you don't have them sized in the correct proportions and minimum sizes. Check the dev sites as they specifically outline the requirements.

Ah, I had teaser and feature images mixed up. I don't much use feature images, but changing the two references to page.image.feature in open-graph.html to to page.image.teaser produces the behavior I wanted. Thanks so much!


MAP linearization operating point output is not computed/reported correctly

Bug description
MAP linearization operating point output is not computed/reported correctly
To Reproduce
Steps to reproduce the behavior:

Linearize a system, where the output forces from MAP can be expected (for instance, in the example attached, the loads at t=0 should be only along x with Fx=4.3e8)
Open the lin file, and look at the FairleadLoads in the output vector, they do not correspond to the expected values. (in the example given, a load Fz=-1e6 shows up).

OpenFAST Version
Any version before this bug report (July 2022)
The issue
The MAP library stores in memory pointers to the nodal forces. Therefore the outputs "y" in the fortran code always need to point to the "y" of MAP. When Jacobians are computed we can't call MAP with a temporary "y_p" (see comment here. The problem is that at the end of the routine MAP_Jacobian_PInputs, the "y" value we return is the one from the last perturbation (typically a displacement of a node along "z"). During the linearization, MAP_GetOp is called here, after MAP_Jacobian_PInputs, therefore, the "y" operating point is wrong.
Potential solutions

At the end of JacobianPInput, call MAP_CalcOutput at the operating point, to ensure that "y" is correct:

   call map_CalcOutput( t, u, p, x, xd, z, OtherState, y, ErrStat2, ErrMsg2 )

Call MAP_GetOp before MAP_Jacobain_PInputs.

I prefer solution 1 as it is a true fix, let me know if you think of other solutions.
SparNoRNA_MD1HD0SD0_F111111_Mini_NoRef.zip

Thanks, @ebranlard, for tracking down this bug!  I agree that solution 1 makes sense.

Yes, this fixes the issue.


Use new quickcheck-state-machine release

Any particular reason for updating other than switching from a revision to a released version?

Any particular reason for updating other than switching from a revision to a released version?

Not really. I just remember it had caused some issues with some dependent packages, which ignore the cabal.project.

Any particular reason for updating other than switching from a revision to a released version?

Not really. I just remember it had caused some issues with some dependent packages, which ignore the cabal.project.

"which ignore the cabal.project", what exactly do you mean? The Nix build ignoring it?
I don't think there are any remaining issues now, correct me if I'm wrong.
As this is a test-only dependency, and no more downstream packages accidentally leave the consensus tests enabled, I expect nothing to change for downstream packages with this PR. Which is exactly what we want, but also defeats the purpose of it solving the issues.
However, I think it is better to use versions released on Hackage than specific revisions. Especially since the dependency can now be stored once and for all in the global Cabal store instead of in the project-local dist-newstyle folder, requiring a rebuild after each cabal clean.

bors merge


added a utility function to get the parent of a dn

Looks good to me. I think at some point I need to make a DN class that has:

__toString()
implode()
explode()
getParent()

That would re-group some of these random utility functions that are related.


Comparing tow MS/MS spectrum

Greetings,
Thank you for providing this open-source tool.
By any chance will your tool be able to mirror two MS/MS spectra from 2 independent .raw file or .mgf files?
I would like to compare the fragment ion spectrum of a synthetic peptide and fragment ion spectrum identified experimentally.
Regards
Ben.

Hi Ben,
While mirror plots aren't currently featured in IPSA, it looks like ProteomicsDB and the Kuster lab have reimplemented IPSA into something that might address your needs. The tool is called the Universal Spectrum Explorer. There are likely other tools out there that can also make mirror plots, but USE is the first one that came to my mind.
Here's a link to their bioRxiv manuscript:
https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>7557v1.full.pdf

Greetings,
Thanks mate, the tool is extremely useful.


no way to create a sign in frontstage without first loading a snapshot model

looking at this line of BaseViewer, the viewer won't load unless IModelApp's authorizationClient is authorized, which won't
happen until either:

a user signs in
or
snapshotPath is set: https://github.com/iTwin/viewer/blob/e35a829a3189f71eb18579d5d22f33e3b3cbe2ef/packages/modules/viewer-react/src/components/BaseViewer.tsx#L52

I am trying to migrate an application from the older @bentley/itwin-viewer-react, but I was using a custom default frontstage to handle authenticating users, which is no longer possible. Is it possible to re-enable the previous behavior?

another issue is that some components I want to use in my sign in page (i.e. SignIn from @bentley/ui-framework) require the UiFramework to be initialized, but the viewer is responsible for that, so am I supposed to render the viewer component but make it hidden with the sign in page over it, and it will successfully load once the viewer initializes the UiFramework?

as a work around, I may ship a snapshot with our app to load silently at initialization time.

also, we are planning on open sourcing the application I'm working on soon, and it would be unfortunate if I had to publish it with a hack, since it's not intended to open a snapshot model on startup, but we will be documenting how we do it anyway without showing the user just to get our sign in screen working.

iirc, this was resolved, right @MichaelBelousov ? If so, could you close the issue.

closing this issue, pretty sure it was resolved; can re-open if not


v3.0.0 prettier error - SyntaxError: Unexpected token, expected ";"

This is caused when running npx @react-three/gltfjsx ...
Running npx<EMAIL_ADDRESS>... works without errors

I'm experiencing the same issue.
Just downloaded this from SketchFab:
https://sketchfab.com/3d-models/summer-festival-42ccebe003434accb05062846afd3750
Tried running:
$ gltfjsx scene.gltf --draco --compress

and ran into:
 SyntaxError: Unexpected token, expected ";" (8:59)
   6 | title: Summer Festival
   7 | */
>  8 | import React, { useRef, useState, useEffect } from 'react'import { useFrame } from 'react-three-fiber'
     |                                                           ^
   9 | import { useGLTF } from '@react-three/drei/useGLTF'

published a patch


Too many temporary directories with nodejs SDK

What happened?
I am currently running the operator with two Stacks which are repeatedly synced every minute.
There is no problem with synchronization, but I found out that there are a lot of pulumi-node-pipes directories in /tmp after a couple of days I ran the operator.
It seems like each directory is created on every pulumi update and never gets removed after sync.
As of writing this issue, I have over 13000 directories in the operator pod.
$ ls /tmp/pulumi-node-pipes* | wc -l
$ 13267

Expected Behavior
Any temporary files or directories should be cleaned up after synchronization
Steps to reproduce

Create a stack with continueResyncOnCommitMatch set true.
Watch pulumi-node-pipes folder created in /tmp and never gets deleted.

Output of pulumi about
CLI
Version      3.46.0
Go Version   go1.19.2
Go Compiler  gc

Host
OS       debian
Version  11.5
Arch     x86_64

Pulumi locates its logs in /tmp by default

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @skdltmxn, thanks for reporting! This looks like a bug.
I suspect something's going wrong in pulumi update but the error is not logged by default. Suspiciously, the removal of these pipes is wrapped in IgnoreError. Fortunately, additional debug logging is available. Could you run update like so and attach the output? Thanks!
pulumi up --logtostderr --logflow -v=9 2> out.txt

Hi! I just ran the command directly from my operator pod and there is no pulumi-node-pipes directory created from it.
I'm wondering if it is the operator who's creating the directory before it runs pulumi update?
Regarding to out.txt, I'm afraid it's too big(over 187,000 lines), and contains some sensitive information to upload here.
If you could tell me any specific logs necessary, I will find and share them out of the file.

Oh I was wrong, running the command did create the directory!
I could find following logs in out.txt
I0223 01:34:03.064381    1832 eventsink.go:78] eventSink::Infoerr(<{%reset%}>I0223 01:34:03.064326    1867 main.go:563] Language host launching process:  /usr/bin/node<EMAIL_ADDRESS>--monitor <IP_ADDRESS>:36669 --engine <IP_ADDRESS>:41489 --sync /tmp/pulumi-node-pipes2900201589 --project infra --stack k8s-central --pwd /tmp/infra --dry-run --query-mode false --parallel<PHONE_NUMBER> .

I0223 01:35:24.696366    1832 eventsink.go:78] eventSink::Infoerr(<{%reset%}>I0223 01:35:24.696295    2213 main.go:563] Language host launching process:  /usr/bin/node<EMAIL_ADDRESS>--monitor <IP_ADDRESS>:37869 --engine <IP_ADDRESS>:35605 --sync /tmp/pulumi-node-pipes1488778004 --project infra --stack k8s-central --pwd /tmp/infra --query-mode false --parallel<PHONE_NUMBER> .

I couldn't find logs regarding to clean ups though.

I'm not sure if these are relevant but I see following logs just before update complete.
I0223 01:36:24.632360    1832 langruntime_plugin.go:196] langhost[nodejs].RunPlan(pwd=/tmp/infra,program=.,...,dryrun=false) success: progerr=
I0223 01:36:24.633420    1832 deployment_executor.go:231] deploymentExecutor.Execute(...): incoming event (nil? true, <nil>)
I0223 01:36:24.633435    1832 deployment_executor.go:361] performDeletes(...): beginning
I0223 01:36:24.633457    1832 step_generator.go:1300] Planner trusts dependency graph, scheduling deletions in parallel
I0223 01:36:24.633465    1832 step_executor.go:389] StepExecutor worker(-1): StepExecutor.waitForCompletion(): waiting for worker threads to exit
I0223 01:36:24.633474    1832 step_executor.go:389] StepExecutor worker(-2): worker received nil chain, exiting
I0223 01:36:24.633480    1832 step_executor.go:389] StepExecutor worker(-1): StepExecutor.waitForCompletion(): worker threads all exited
I0223 01:36:24.633487    1832 deployment_executor.go:275] deploymentExecutor.Execute(...): step executor has completed
I0223 01:36:24.633710    1832 deployment_executor.go:138] deploymentExecutor.Execute(...): exiting provider canceller
I0223 01:36:24.655281    1832 ignore.go:44] Explicitly ignoring and discarding error: rpc error: code = Canceled desc = grpc: the client connection is closing
I0223 01:36:24.655368    1832 update.go:193] *** Update(preview=false) complete ***

I found following code from pulumi nodejs SDK and it seems like it is called from nowhere.
I doubt Pulumi is never using any pipe comm?
/** @internal */
export interface SyncInvokes {
    requests: number;
    responses: number;
}

let syncInvokes: SyncInvokes | undefined;

/** @internal */
export function tryGetSyncInvokes(): SyncInvokes | undefined {
    const syncDir = options().syncDir;
    if (syncInvokes === undefined && syncDir) {
        const requests = fs.openSync(path.join(syncDir, "invoke_req"), fs.constants.O_WRONLY | fs.constants.O_SYNC);
        const responses = fs.openSync(path.join(syncDir, "invoke_res"), fs.constants.O_RDONLY | fs.constants.O_SYNC);
        syncInvokes = { requests, responses };
    }

    return syncInvokes;
}

Hey @skdltmxn, the code creating and removing the pipes is located here.
Could you check your log again for lines containing Explicitly ignoring and discarding error:?
Regarding pulumi running twice, the first one is indeed a dry run to generate the preview. You can skip it with --skip-preview.

Yes I know pulumi opens two pipes in Go code.
However in TS code, there is no place using the pipe. The code I attached on my last comment(tryGetSyncInvokes) is never called anywhere.
So, I doubt even if pipes were created in Go code, there is no counterpart for actual comm.
I checked my log for Explicitly ignoring and discarding error and there is only single occurrence: I0223 01:36:24.655281    1832 ignore.go:44] Explicitly ignoring and discarding error: rpc error: code = Canceled desc = grpc: the client connection is closing as I already attached :(

Ok, thanks for checking @skdltmxn. I'll have to defer to my colleagues at this point - we'll put this on the work queue. I hope it's not too bothersome to delete the old pipes every so often.

Moving this over to the pulumi/Pulumi repo, since it appears to be a file system leak for core pulumi-language-nodejs process. This potentially impacts any automation usecase - not just the Kubernetes operator.


Added about myself (Jaskirat Singh)

I have added about myself as a GSoD 2023 aspirant

Hi! It looks as if edits were made to other participants' information, would you please revert those edits and only add your own information (even if the other edits were just changes to whitespace)?
Thank you.

Hi @emckean  Thanks for reviewing. I want to let you know that I made edits only to my own addition. Can you please check once again if possible?
Looking forward to hearing from you.

You can see the changes by looking at the diff: https://github.com/google/season-of-docs/pull/796/commits/d022465b257d224dede1500eb0ca30d9f4601a08
Your editor may have changed the line endings or changed spacing.

Yeah, I can see that but I'm afraid that how did that happen. What can I do
to resolve this?
Thanks and Regards
On Tue, 7 Feb, 2023, 11:39 pm Erin McKean, @.***> wrote:

You can see the changes by looking at the diff: d022465
https://github.com/google/season-of-docs/commit/d022465b257d224dede1500eb0ca30d9f4601a08
Your editor may have changed the line endings or changed spacing.
—
Reply to this email directly, view it on GitHub
https://github.com/google/season-of-docs/pull/796#issuecomment-1421232430,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOBHK2OZOKMC4UP26PZFBDWWKFUHANCNFSM6AAAAAAUTWL45E
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi, unfortunately we can't give editor training. You can close this PR and start a new one and check your editor settings or try to use the web editor if it's available.

@emckean I have made the another PR, can you please look into it?
Thanks


Access denied on Windows while attempting to lock

Hi,
When file_guard::lock(&file, Lock::Exclusive, 0, 1), get error  Access is denied. (os error 5) on Windows despite Everyone is granted full access on the target folder and inner files.
Works on MacOS and Linux, but not on Windows apparently

Hi @raycoe thanks for reporting. What version of windows are you on? I'll take a look on windows 11 soon, but do you have any more details about your issue? Does this fall on all uses?

Hi,
It is Windows 10 64bits, last updates installed.
For info, I found a workaround by adding .read(true) to the file attributes. Would it mean that Windows requires this attribute on top of the others to properly determine if you've got enough permissions?
KR
Ray


add joseph

Hey! This is the template for a pull request <- you can delete this line when providing a pull request.
The most probable reason for your pull request is the fact that you are about to create a new blog post about whyr webinars.
Please make sure that your pull request satisfies the below list

[x] The date of the blog post is at least 5 hours younger then the time of a potential merge. E.g. if you are providing a PR on 2021-02-13 11:00pm CET, and probably the review will be done
2021-02-14 10:00am CET then please provide the +5hours time in your blog post, which in this case would be 2021-02-14 3:00pm CET. The timeline needs to be bigger in the blog post, so it populates in the main thread on R-bloggers.
[x] Please ensure the repository that you are making a PR from is up to date. We recommend to make a pull on your repository so that you work on the latest version of the repository.
[x] Please make sure that the !iframe URL! to youtube video is of this format https://www.youtube.com/embed/VIDEO_ID
[x] Please make sure all links that you provided in your blog post redirect to working addresses.

Awesome @laisbsc thanks!


Builds failing for > 30 days

@jonkeane and I were discussing the builds which have been failing; there are a lot of conda packaging jobs which have been failing for > 30 days now - see http://crossbow.voltrondata.com/
Do we want to either fix them, or if they're not important, then remove them?

Those were renamed/removed jobs and I just fixed that in https://github.com/ursacomputing/crossbow/pull/53 :tada:
@paleolimbot  is already looking at reproducing the libc++ abi issue so we can also get the last long failing autobrew job green again :rocket:

Oh wow, I didn't realize just how many of those jobs that were marked as failing consistently were false alarms, I'm really glad we've cleaned that up! These are the issues I'm seeing after that clean up:

homebrew-r-autobrew (failing for 127 days) is being tracked in #15189
verify-rc-source-csharp-macos-arm64 (failing for 68 days) I haven't found an issue tracking this, should we make one?
test-fedora-r-clang-sanitizer and test-ubuntu-18.04-r-sanitizer (both failing for 29 days) I also haven't found an issue for (though remember @paleolimbot mentioning them, so maybe he has an issue on hand?)

And the rest are much more under control vis a vis consistent failing.

Thanks for that, I've updated my comment to show that (but left the original crossed out so as not to gas light!)

verify-rc-source-csharp-macos-arm64 has been flakey for a long time now, I once asked (in May) on the ML for c# maintainers to please have a look but no one did.... :(

@assignUser do we have an issue for the csharp failure?  I'll try and take a look at it tomorrow.

@westonpace https://issues.apache.org/jira/browse/ARROW-16795