Post-July 1 report format

Raunak, would you please align the reporting fields for the post-July 1 applications with those of earlier? When the all-time report is run, or probably the group reports, removing several fields mis-aligns the report data

No longer using excel spreadsheets!!


Release Toolium 1.7.0

Coverage remained the same at 88.566% when pulling 06ef0a1a8b289b03dc318bb4dcc93859bf93d17d on release/1.7.0 into efefe4d521617cf792ac30d2249fc322f24054d3 on master.


Option to delay conflict checking of old pull requests until page view

[repository.pull-request] CHECK_ONLY_LAST_UPDATED_DAYS specifies the number of days in which the PR must have been last updated for conflict checking to happen immediately when the base branch is updated.
The default value of -1 behaves exactly as before with no delay. With 0 all conflict checking will be delayed until page view. We have found that 1 day works well in practice.
This mostly eliminates the Merge conflict checking is in progress. Try again in few moments. message when conflict checking is slow for big repositories and many pull requests.
PRs that are actively being worked on will be checked immediately, while older ones are likely to actually get checked in the next few seconds after viewing rather than being at the end of a long queue.
A further improvement would be to auto-update the page once conflict checking completes, but this relatively simple change effectively solved the problem for us.

This PR is rather outdated, I've updated it now to a more recent version:

Fixes to make it work with Gitea 1.22 and later.
Properly handle Gitea restarting.
Make pull request API access trigger checking (matching GitHub).

I think the pull request view UI should be refactored to connect with web socket to detect whether the check status changed.


Multiple Public Subnets Single Shared Network ( Metadata Error )

ISSUE TYPE

Bug Report

COMPONENT NAME

VR

CLOUDSTACK VERSION

4.15

CONFIGURATION

Advanced Networking with SG
One defaultGuestNetwork ( 2 x subnets setup using legacy interface.
Example:   <IP_ADDRESS>/28     <IP_ADDRESS>/26
The first subnet /28 was added when the guestnetwork was created. We can manually add an IP from the /26 subnet ( using the legacy interface and DHCP is working and IP is assigned to the instance. When querying the metadata server for the password the instance seeks out the /28 VR gateway which fails.
OS / ENVIRONMENT

SUMMARY
Creating more than one public CIDR in the DefaultGuestNetwork fails to obtain password from cloud-init metadata server.
STEPS TO REPRODUCE

2021-04-16 13:29:47,489 - DataSourceCloudStack.py[DEBUG]: Crawl of metadata service took 0 seconds
2021-04-16 13:29:47,489 - util.py[DEBUG]: Running command ['wget', '--quiet', '--tries', '3', '--timeout', '20', '--output-document', '-', '--header', 'DomU_Request: send_my_password', ' xxx.xxx.xxx..100:8080'] with allowed return codes [0] (shell=False, capture=True)
2021-04-16 13:30:51,568 - util.py[WARNING]: Failed to fetch password from virtual router <IP_ADDRESS>
2021-04-16 13:30:51,570 - util.py[DEBUG]: Failed to fetch password from virtual router  <IP_ADDRESS>
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/cloudinit/sources/DataSourceCloudStack.py", line 131, in _get_data
    set_password = password_client.get_password()
  File "/usr/lib/python2.7/site-packages/cloudinit/sources/DataSourceCloudStack.py", line 58, in get_password
    password = self._do_request('send_my_password')
  File "/usr/lib/python2.7/site-packages/cloudinit/sources/DataSourceCloudStack.py", line 53, in _do_request
    '{0}:8080'.format(self.virtual_router_address)
  File "/usr/lib/python2.7/site-packages/cloudinit/util.py", line 2084, in subp
    cmd=args)
ProcessExecutionError: Unexpected error while running command.
Command: ['wget', '--quiet', '--tries', '3', '--timeout', '20', '--output-document', '-', '--header', 'DomU_Request: send_my_password', ' xxx.xxx.xxx.:8080']
Exit code: 4

1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 1e:00:52:01:02:43 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/27 brd <IP_ADDRESS> scope global eth0
       valid_lft forever preferred_lft forever
    inet <IP_ADDRESS>/26 brd <IP_ADDRESS> scope global eth0
       valid_lft forever preferred_lft forever
3: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 0e:00:a9:fe:7f:ef brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global eth1
       valid_lft forever preferred_lft forever

EXPECTED RESULTS

Obtain password from VR
instance should query correct gateway of VR for the additional subnet.

ACTUAL RESULTS

Failed to fetch password from virtual router  <IP_ADDRESS> |
-- | --

Instance is using gateway from the subnet that was originally created when the defaultnetwork was setup.
Get request to the VR using both IP  and DNS name is working as per below. Curl request inside the instance works. When booting a Ubuntu or CentOS instance cloud-init times out when accessing the server_password.

curl http://data-server./latest/meta-data/local-hostname
Test51[root@test51 cloud.cfg.d]#

can you add 'real' rfc1918 examples? from this we can not really see where you wnet wrong, @benmcguire79. I'm not saying you are wrong. I've seen a similar issue recently and it might even duplicate that one. .

Hi Dan
I have updated the initial report with the actual IPs. In addition here is the full cloud-init.log from the test VM. As stated, ssh keys with but password does not.
https://mega.nz/file/ArwlTY7Q#I0a7C30mXhf7YfSpAjG3IwmXX8VtRAfEN5LVzRcwPCk
Also here are the screenshots if they help.

from the screenshots above it appears the CentOS7 vm is trying to use the first address of the subnet ( <IP_ADDRESS> ) which Im unsure why it chooses that 131 address and not 129 which is the first usable IP in the subnet.
BUT, the cloudinit log says it is trying to use the <IP_ADDRESS> which is the VR. Im assuming it is becuase of the DNS entry in the VR for data-server.
Read from http://<IP_ADDRESS>/latest/meta-data/availability-zone (200, 6b) after 1 attempts
2021-04-19 09:43:09,840 - url_helper.py[DEBUG]: [0/6] open 'http://<IP_ADDRESS>/latest/meta-data/instance-id' with {'url': 'http://<IP_ADDRESS>/latest/meta-data/instance-id', 'headers': {'User-Agent': 'Cloud-Init/19.4'}, 'allow_redirects': True, 'method': 'GET', 'timeout': 5.0} configuration
Let me know if I can provide further information.

Just tested with Ubuntu 16.04 and it tries <IP_ADDRESS> which still fails.Unsure why the first one ( CentOS 7 ) uses <IP_ADDRESS> and Ubuntu tries <IP_ADDRESS> ???

HI.
Is there any update on this. It would be great to get this fix included in the 4.15.1 release as it is now impossible to use multiple subnets in a shared network and have the password server working.

I'm tentatively assigning the <IP_ADDRESS> milestone (doesn't guarantee a fix will make into the release) for investigation.
cc @wido @GabrielBrascher @weizhouapache have you seen something in your SG-based environments?

I'm tentatively assigning the <IP_ADDRESS> milestone (doesn't guarantee a fix will make into the release) for investigation.
cc @wido @GabrielBrascher @weizhouapache have you seen something in your SG-based environments?

We have a strict one-subnet-per-network policy on our advanced zones. Each VXLAN network has one IPv4 and one IPv6 subnet.
In the past we have seen too many issues with multiple subnets per network and therefor we chose to not implement this anymore.

I'm tentatively assigning the <IP_ADDRESS> milestone (doesn't guarantee a fix will make into the release) for investigation.
cc @wido @GabrielBrascher @weizhouapache have you seen something in your SG-based environments?

Thank you @rhtyd @wido I guess we will await <IP_ADDRESS> and see if any changes inthat makes any difference. Should the issue still persist I guess we will go with @wido and use one subnet per network....a pain but if there's no other way :)  I was thinking it maybe a simialr issue to https://github.com/apache/cloudstack/issues/4865

I'm tentatively assigning the <IP_ADDRESS> milestone (doesn't guarantee a fix will make into the release) for investigation.
cc @wido @GabrielBrascher @weizhouapache have you seen something in your SG-based environments?

We have a strict one-subnet-per-network policy on our advanced zones. Each VXLAN network has one IPv4 and one IPv6 subnet.
In the past we have seen too many issues with multiple subnets per network and therefor we chose to not implement this anymore.

@rhtyd @wido
We have multiple subnets many years ago (cloudstack 2.2.14 ?), when we upgraded to a major version, we created separated shared network for each subnet. for now each shared network have only 1 subnet on our productions (same as pcextreme).

Thanks @weizhouapache @wido. @benmcguire79 can you help test the latest 4.15.1 and report your findings, or are you happy to accept the general prod use-case (i.e. use single subnet per network) and close the issue?

Hi @rhtyd . I am happy to test 4.15.1 once it is released as Im patiently waiting for it.  For our use case setting up multiple networks for each subnet is not ideal as we have 20+ subnets and having 20+ networks again is not ideal. I see someone else raised the same issue ( albeit with vmware ) but from what I read it is the same issue ( https://github.com/apache/cloudstack/issues/4943 ) with the data-server and hosts file. In any event as soon as 4.15.1 is released ill immediately test and advise you of my findings. FYI i have tested with an isolated network with multiple internal subnets and these work with no issues....it appears only muliple public subnets on a single network is causing the issue.

cc @DaanHoogland

@wei @wido @rhtyd @benmcguire79 I'll create a doc pr to describe the way of working mentioned and do a short test to confirm @benmcguire79 's limitation.

@benmcguire79 this is actually already covoured in the docs. From http://docs.cloudstack.apache.org/en/<IP_ADDRESS>/adminguide/networking/security_groups.html?highlight=security groups#limitations
Two IP ranges with the same VLAN and different gateway or netmask in security group-enabled shared network.

Do you agree this is your use-case? (if so, can you close the issue?)

@benmcguire79 this is actually already covoured in the docs. From http://docs.cloudstack.apache.org/en/<IP_ADDRESS>/adminguide/networking/security_groups.html?highlight=security groups#limitations
Two IP ranges with the same VLAN and different gateway or netmask in security group-enabled shared network.

Do you agree this is your use-case? (if so, can you close the issue?)

Hi @DaanHoogland
Yes agreed. Probably move to NAT moving forward. Thank you for the input.

fixed by #5013

I still have the same issue, even in 4.15.2, it will not work with basic network ( or advanced with guest  ) with multiple subnets.
This issue is persistent to the VMs with cloud-init:
Ubuntu 16 - OK
Ubuntu 18 - OK
Ubuntu 20 - OK
CentOS7 - Not working
CentOS8 - Not working
Debian8 -  Not working
Debian9   - OK
Debian10 - OK
It is simple to reproduce, add multiple CIDR to the same guest router, deploy multiple instances, when a new VM is going to be deployed under different subnet, for some reasons the returned data-server IP is not from VM subnet, it is the IP which is defined in /etc/hosts into the router, example;
149.xx.xx.99 r-xxx-VM data-server
And because it is from different subnet, there is no password saved in the file for different subnet (in router ). in this case, no password is going to be set for this VM.
If I execute this:  "cat /var/lib/dhclient/dhclient--eth0.lease | grep dhcp-server-identifier" into the VM the returned IP is the right one. Even if I try to add this to VM host file( IP data-server) ,it is not working, the cloud-init it is using the IP for metadata, and not the host "http://data-server".
Tested with :
4.15.0 + VMware
4.15.1 + VMware
4.15.2 + VMware
At this point, I'm not sure if this is a cloud-init issue or cloudstack.

I still have the same issue, even in 4.15.2, it will not work with basic network ( or advanced with guest ) with multiple subnets.
This issue is persistent to the VMs with cloud-init:
Ubuntu 16 - OK
Ubuntu 18 - OK
Ubuntu 20 - OK
CentOS7 - Not working
CentOS8 - Not working
Debian8 - Not working
Debian9 - OK
Debian10 - OK
It is simple to reproduce, add multiple CIDR to the same guest router, deploy multiple instances, when a new VM is going to be deployed under different subnet, for some reasons the returned data-server IP is not from VM subnet, it is the IP which is defined in /etc/hosts into the router, example;
149.xx.xx.99 r-xxx-VM data-server
And because it is from different subnet, there is no password saved in the file for different subnet (in router ). in this case, no password is going to be set for this VM.
If I execute this: "cat /var/lib/dhclient/dhclient--eth0.lease | grep dhcp-server-identifier" into the VM the returned IP is the right one. Even if I try to add this to VM host file( IP data-server) ,it is not working, the cloud-init it is using the IP for metadata, and not the host "http://data-server".
Tested with :
4.15.0 + VMware
4.15.1 + VMware
4.15.2 + VMware
At this point, I'm not sure if this is a cloud-init issue or cloudstack.

@ccycv it seems to be a bug in cloudstack. can you create file an issue ?


Another real-world example for cleaning

Attempting to get clarity on what happened with this combine pattern :/

what pyritas polygon output currently/roughly looks like

This dataset actually has an explicit distance field, so fewer life choices are necessary


[Linux] Debian - NodeJS v18 or LTS or Latest - Latest FoundryVTT zip package -  Sheets glitches - No inventory items seen

Hi there,
Thanks for the wonderful work.
I am running foundryVTT on a debian 12 using the recommended node version and settings.
I have several glitches, mainly the inventory tab of actors (players) not being processed. Bag containers are ok, but individual items are not listed. (Although I see the weights being added correctly).
I tried the client version on Debian and I see no issues, I have made a complete from scratch reinstallation of the server (node.js) version, I have the problem on the sheets.
Do you have any idea where that could come from?
I greatly appreciate your help.
With version 3.0.0 or version 3.0.1. No add-ons / extra modules.

What browser are you using? And what version is it?

Hello @Fyorl,
I did not even think of it — thank you very much.
Using : Mozilla Firefox 115.7.0esr - it is glitching on the inventory
When using : Google Chrome (unstable) 123.0.6272.2-1 - it works perfectly.
Such a shame for Firefox not rendering it properly, though.
Thanks for the help again.
Not sure if I close the issue or if that is something that could be fixed via "support for Firefox", I let you guys decide, I am happy with whatever path you choose.
Cheers.

Not sure if I close the issue or if that is something that could be fixed via "support for Firefox", I let you guys decide, I am happy with whatever path you choose.

It is because of the version of Firefox you are running (don't worry, I use Firefox and was reviewing all the sheet design stuff from that browser). The new sheets use :has selector and nesting in CSS which were added fairly recently, so you'll need a newer version of Firefox.

Thank you very much @arbron for your reply.
I'll see for the incoming updates related to Firefox itself and I am closing this issue.
Keep up the amazing work 🙏


Add a licence

Please, specify a license so the code can be safer used by other projects. Here is how to add a license in GitHub: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository

Thanks for the suggestion, fixed in #10


Show text during Wallet Sync explaining that the wallet balance will not show correctly until the wallet is fully synced

Having to explain this to new users of the wallet all the time is a large pain point for anyone in the community who is helping troubleshoot wallet issues.
We could also do something to the wallet balance text to indicate that it is not correct. Not sure what that should be though

fixed


Require reflexes to be defined in a reflex.py module or a reflexes package for simpler discovery.

Type of PR (feature, enhancement, bug fix, etc.)
Enhancement
Description
Please include a summary of the change and which issue is fixed.

load_reflexes_from_config now looks for a reflexes.py module or a reflexes package which exposes its package members directly, instead of walking the filepath. This will be more stable in the long run, and adheres to idioms from the Django framework.
Updated the example project to reflect the new requirement
Updated the docs to be more clear about where/how to define reflexes.

[x] Tests are passing
[x] Documentation has been added or amended for this feature / update

The current scaffolding system generates a blank __init__.py file, so the scaffold would be broken out of the box with this change.
I appreciate the idiomatic change, but having to remember to fill out the __init__.py every time I add a new bit of functionality might make me want to say shove it to code organization and shove all of my Reflexes in one uber-file. Since the scope of the reflexes package would be limited and predictable, and since we can assume that users want access to every reflex they define, I feel like this would be the opportunity to do something fancy where __init__.py dynamically imports every file in the folder. Most users wouldn't ever have to think about the code in that file, just making sure they have Reflex-descended classes inside it.

I can fix the scaffolding change, thanks for bringing that to my attention.
Personally, given that this paradigm is already established in Django, and it's as close to basic python as it gets, I'd rather not do anything terribly magical in __init__.py.
I think my preference would be to have the default scaffolding generate a reflexes.py file instead of a reflexes package, and document the option to the user of turning it into a package a la the django model documentation. "Simple is better than complex." and all that.

I think if we're going for a breaking change here it could be interesting to use a registering logic. There's less chance that you'd forget about that since you'd need to do it in the same file, just above the reflex class.
Think the same as @admin.register(ModelClass). I wrote briefly about that in #26. To me that would be pretty idiomatic django as well.

I like the discussion here and Indeed I think I would prefer something simple and explicit as the registration @jonathan-s suggests. I dont know enough python / django to comment on the discussion of @mekhami and @DamnedScholar who seem to be more in the matter.

And just as a side note.. i came across the problem, that I wanted to check againt a "registry" if a reflex class / method is available (the idea is to check if a given template tag references a valid reflex). So I think it would definetly be good to make a registry somewhat standalone (currently its pretty implicit in the consumer).

I like a registry. It fits the Django idiom and give you a chance to have your view functions check for functionality that might make or break the view. It would also allow for multiple organization strategies, including the magic folder and having a Reflex class living in the same file as other classes that define the same functionality.


get_resource_type error on PHP 8

Hello using php-8.0.0beta4-nts-Win32-vs16-x64, this error is occurring on line 72 ...
The solution I found was to test if it is a resource with "is_resource" before "get_resource_type" ...
I really don't know if in the final version of PHP 8 this will happen, but it may be interesting to leave the code this way.
ERROR:
<<<< PHP Fatal error: Uncaught TypeError: get_resource_type (): Argument # 1 ($ resource) must be of type resource, GdImage given in D: \ mysite \ simpleimage \ SimpleImage.php: 72 >>>>

Please ignore, this must be done in another way ...
I will resend


[Refactor] Add retry in the broker load when timeout

We have disable the broker load retry when timeout. If timeout, the retry is very useful. I add a retry in broker load. The retry job keep the same job_id, and a new different transaction_id. The timeout job will be retried two times.
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[x] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[x] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[x] 3.0
[ ] 2.5

If the timeout job is retried, it means that the job may cost time more than the timeout setting. Is it OK?

If the timeout job is retried, it means that the job may cost time more than the timeout setting. Is it OK?

Yes, it's make sense to retry timeout jobs.

@mergify backport branch-3.2, branch-3.1, branch-3.0

@mergify backport branch-3.2 branch-3.1 branch-3.0


[WIP] Basic Transfer Functions

Includes a rough pass at some transfer function capabilities:

interpolate: basic interpolation
stack: layering of images
merge: merging of images

I'm still not happy with the api, and will probably iterate on this over the next few days.
This notebook demos the api, and some basic capabilities: https://gist.github.com/jcrist/6803b376aa99b5ddf6da

Are you happy to have this merged yet, so that we can go forward from here?  It doesn't seem to reduce any current functionality, and while it's still a PR it's hard to build on...

I suppose we can merge this for now. It's still likely to change, but that's fine.


Feature Req: Ability to specify ScheduledEnqueueTimeUtc message property when bulk re-submitting messages

So there are a few different ways I could see this happening...

Being able to bulk modify Message Properties when you have 2+ selected..

"Repair and Resubmit Message" dialog could have a Message Properties panel with value of 'Use Existing' which could be overwritten with a new value that would be applied to all messages.

Hi @ShaneCourtrille in the past I had a similar idea, but then I didn't have time to implement this feature. Would you be able to submit a PR?

I may be able to find the time.  Let me take a look.  Is there a specific
way you think it should be done?  I'm thinking option 2 probably makes more
sense
On Tue., Jun. 11, 2019, 9:34 a.m. Paolo Salvatori<EMAIL_ADDRESS>wrote:

Hi @ShaneCourtrille https://github.com/ShaneCourtrille in the past I
had a similar idea, but then I didn't have time to implement this feature.
Would you be able to submit a PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/paolosalvatori/ServiceBusExplorer/issues/352?email_source=notifications&email_token=AAA5WCURYQ4NSQ7SHQ4X64LPZ7AYRA5CNFSM4HQTBBKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXNRIOI#issuecomment-500896825,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA5WCVL7EIQJWFEAX2QWODPZ7AYRANCNFSM4HQTBBKA
.

Thanks @ShaneCourtrille I agree with you on option 2. @SeanFeldman @ErikMogensen @tomkerkhove?

Also agree on option 2.


[TAS-243] Allow Execution of QProgram from Platform

Closing this since these changes are in another PR.


Update 2.1.3 to 2.2.0 failed with Shibboleth enabled and allauth disabled

Description / Beschreibung
I cannot update our RDMO instance from version 2.1.3 to 2.2.0. The step "python manage.py migrate" displays an error message.
Steps to reproduce / Schritte zum Reproduzieren

source env/bin/activate
pip install --upgrade rdmo
python manage.py migrate
See error:
RuntimeError: Model class allauth.account.models.EmailAddress doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS.

Context / Kontext
Operation system: Debian 11
RDMO version: 2.1.3
We use Shibboleth for authentication.
Authentication with allauth is not enabled.
The previous update from 2.1.2 to 2.1.3 in February 2024 ran without problems.

Hi @kzimmermann836 , thanks for reporting. I already found the bug and we will publish a Version 2.2.1 later this week.

Hi @jochenklar, thanks for the bugfix. Today I updated from 2.1.3 to 2.2.1 successfully, it worked without any problems.


Great idea, kind of not a very good name

I don't mean this to be mean or disrespectful,
but when I read "Copilot", I assumed it integrated GitHub Copilot into Godot, not OpenAIs API. That's a bit misleading.

Well, GitHub Copilot is also using OpenAI models behind the scenes, so in that sense the approach is the same. If the GitHub Copilot product itself offered an API offering another layer of abstraction, it'd make sense to support it, but it doesn't.
So i always considered "Copilot" to be a pretty generic name for AI-assistants. And we see the same naming scheme with things like Windows Copilot.

I had assumed they just provided a regular API, but apparently not. Wow. That's really disappointment. I'm paying for copilot, and it would have been nice to use what I'm already paying for.
Yea, It's a bit confusing still, but maybe that can be addressed in the README.md?

It says OpenAI in the description, so I guess that's probably good enough. Thanks.


After double click zoom map may not contain area that was clicked

When zooming by using a double click, the center of the map stays constant, rather than panning to include the area where the user double clicked. This seems non-intuitive, and is in contrast to the default Leaflet behavior (as demonstrated on the Leaflet website), which pans the map to include the area where the user has double clicked.

I just found the same thing:

At first, I thought that the "default" behavior could be achieved setting doubleClickZoom to center, as the documentation says:

Whether the map can be zoomed in by double clicking on it and zoomed out by double clicking while holding shift. If passed 'center', double-click zoom will zoom to the center of the  view regardless of where the mouse was.

But in ipyleaflet it's defined as a boolean:
https://github.com/ellisonbg/ipyleaflet/blob/ae24dd6c17cef8c2e9d2f50b4cd64deffb8d12ee/ipyleaflet/leaflet.py#L628
So I went ahead and changed it to be a double_click_zoom = Union([Bool(True), Unicode('center')]).tag(sync=True, o=True). However, this is not a solution either, since then it just ignores the position of the mouse. Just leaving this here so nobody else loses time trying to find a workaround.

@Juanlu001 @tylere Thanks for the report. I have opened PR #132 to fix this issue.
Would you be ok with trying this out?
There are very subtle race condition with respect to how leaflet.js handles its internal state and I would like to be sure that there is no unwanted side effect here.


[SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing

What changes were proposed in this pull request?
This PR set the hour to 12/0 when the AMPM_OF_DAY field exists
Why are the changes needed?
When the hour is absent but the am-pm is present, the time is incorrect for pm
Does this PR introduce any user-facing change?
no
How was this patch tested?

add unit tests

Test build #123460 has started for PR 28713 at commit 81eb751.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28080/
Test PASSed.

cc @cloud-fan @maropu @MaxGekk thanks

Test build #123465 has started for PR 28713 at commit c0ede09.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28085/
Test PASSed.

Test build #123460 has finished for PR 28713 at commit 81eb751.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123460/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28087/
Test PASSed.

Test build #123467 has started for PR 28713 at commit 6b35051.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28088/
Test PASSed.

Test build #123468 has started for PR 28713 at commit 6353ed7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28089/
Test PASSed.

Test build #123465 has finished for PR 28713 at commit c0ede09.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123465/
Test FAILed.

retest this please

Test build #123481 has started for PR 28713 at commit 6353ed7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28104/
Test PASSed.

Test build #123468 has finished for PR 28713 at commit 6353ed7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123468/
Test FAILed.

Test build #123467 has finished for PR 28713 at commit 6b35051.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123467/
Test PASSed.

retest this please

thanks, merging to master/3.0!

Test build #123481 has finished for PR 28713 at commit 6353ed7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123481/
Test PASSed.


Reading: Add materials for F&P levels A and B

Who is this PR for?
MTSS facilitators, reading specialists, literacy coaches, K5 classroom teachers
What does this PR do?
This is a first cut at the F&P materials.  It adds in some materials for levels A&B only, and adds a different way to choose materials.  For other screeners, these are standardized based on the student's grade and time of year, but the F&P protocol is based on moving up from their previous level, so students in the same cohort might be reading different materials.  This means these materials reflect what the student's instructional level is (while others show "what was assessed").
No work here to optimize images yet, there's a bunch more so punting that until we want to do this, then we can compress or shrink them all down in one shot.
Screenshot (if adding a client-side feature)

Checklists
Which features or pages does this PR touch?

[x] Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

[x] Included specs for changes
[x] Manual testing made more sense here

selfie


Batching for transforms

Extends #327 to other transforms.
Fixes #336 also.

I'd also update the README alongside this to explain the ellipsis convention.

I'd also update the README alongside this to explain the ellipsis convention.

Updated. We were already using ellipses in the README. :)


HackerNews HTML has changed, API has stopped working

$ python2
Python 2.7.9 (default, Dec 11 2014, 04:42:00)
[GCC 4.9.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from hn import HN
>>> hn = HN()
>>> for story in hn.get_stories(story_type='newest', limit=10):
...     pass
...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/site-packages/hn/hn.py", line 145, in get_stories
    stories = self._build_story(all_rows) # get a list of stories on current page
  File "/usr/lib/python2.7/site-packages/hn/hn.py", line 71, in _build_story
    domain = info_cells[2].find('span').string[2:-2] # slice " (abc.com) "
TypeError: 'NoneType' object has no attribute '__getitem__'

Still not working.

Confirmed still broken. :'(


⚠ Spryr has degraded performance

In deae050, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4076 ms

Resolved: Spryr performance has improved in 126a7f4 after 7 minutes.


feat: improve file insertion

feat: inject styles + script directly
fix: challenge test for new embedding

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #45937

It is spooky, isn't it! It took a while, but I think it's working.


fuse mount failed with "failed to start background tasks: filer: no entry is found in filer store"

Describe the bug
start weed master, volume, filer, then start weed mount will fail with:
failed to start background tasks: filer: no entry is found in filer store

System Setup

List the command line to start "weed master", "weed volume", "weed filer", "weed s3", "weed mount".

OS version

output of weed version
version 30GB 3.73 linux amd64

if using filer, show the content of filer.toml

Expected behavior
weed mount should start ok
Screenshots
Additional context
looks like pr https://github.com/seaweedfs/seaweedfs/pull/5983 introduced this break. The new subscribeFilerConfEvents will try to read filer.conf from inside filer, so even the mount docker has /etc/seaweedfs/filer.conf, without filer internal file /etc/seaweedfs/filer.conf, it will hit the not found error and unable to start the background tasks.

just see this is fixed in https://github.com/seaweedfs/seaweedfs/commit/11e53dd8efee7e3a52d6d11b4d908dcef3eea286


Add Java 8 for Licensify

We need to package this thing up and then we'll get it merged in :+1:

Build is in progress: https://launchpad.net/~gds/+archive/ubuntu/govuk/+build/9848754


trailers

possible to play trailers with the built-in video player?

Would be too much work for an already working feature, rejected.


[Feature] Is there a specific update plan?

I am very interested in this project. Is there a specific update plan? Thank you!

Not yet, at first, I'm trying to develop basic features and then add other features step by step. This library might be usable in a month or two.

Not yet, at first, I'm trying to develop basic features and then add other features step by step. This library might be usable in a month or two.


Allow specifying an IP:port for istiod address.

For VM and other non-k8s environments, allow specifying an IP:port address without changing /etc/hosts
The DiscoveryAddress is used to set the ServerName, for cert validation - typically istiod-REV.istio-system.svc - and gets
resolved in k8s to the cluster IP.
For VMs and similar environments it is the IP of the east-west gateway or a similar load balancer. Current instructions
modify /etc/hosts to map the name to IP, but sometimes it is not possible or convenient to change /etc/hosts.
Change-Id: Ibcc1f5a6bd4235d21f4e278d1197749ed6463922
Please provide a description of this PR:

@costinm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
18f22c424dc9cdc3660ab13a1d9c6bdcd3c66c75
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Why can't we just use proxy config?
I suppose we should also document that this is an option if you can access pilot directly and don't need to go through a gateway.
Do we run into any TLS issue due to using the IP instead of a valid name?

Re ProxyConfig - it's not supposed to be user-configurable. Some launcher or installer will get the endpoint IP ( or the LB address ), and set it before launching the agent. We currently configure it in /etc/hosts.
I think there is a better way to achieve the same result, will rewrite the PR - we need both IP:port and the 'SAN' to validate, I started with keeping DiscoveryAddress be the URL and overriding the actual IP, but it seems better to go the other way, make the DiscoveryAddress be IP:port and overriding the SAN.
It seems I also need to update Citadel client ( I initially tested with MeshCA, but if citadel is used it needs similar override ).
Sorry for the false start, hold on for few days...

PTAL - switched to overriding the SAN, and added citadel client too. This is far more useful - and may allow more flexibility and consistency if we want to allow Istiod to also support workload identity (again). I don't remember how we lost it, but older releases did support using spiffee identity for pilot.

@costinm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
31557f459eb96699102cd68b63c85ce0e48299af
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
31557f459eb96699102cd68b63c85ce0e48299af
link
/test release-notes_istio

lint_istio
31557f459eb96699102cd68b63c85ce0e48299af
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
31557f459eb96699102cd68b63c85ce0e48299af
link
/test release-notes_istio

lint_istio
31557f459eb96699102cd68b63c85ce0e48299af
link
/test lint_istio

integ-pilot-multicluster-tests_istio
31557f459eb96699102cd68b63c85ce0e48299af
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
31557f459eb96699102cd68b63c85ce0e48299af
link
/test integ-pilot-multicluster-tests_istio

lint_istio
d8169d16b9bda3ea698dd640bef26dd9c22fd0a8
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
31557f459eb96699102cd68b63c85ce0e48299af
link
/test integ-pilot-multicluster-tests_istio

lint_istio
d8169d16b9bda3ea698dd640bef26dd9c22fd0a8
link
/test lint_istio

gencheck_istio
d8169d16b9bda3ea698dd640bef26dd9c22fd0a8
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Lexer] Adds support for extra delimiters in %w and %i

All of the pairs [], {}, () and <> can be used to delimit string and
symbol array with the %w and %i notation, respectively.

I'm not sure if I should add test for all the cases in the parser, but maybe not, because they are being tested in the lexer already.

Muito obrigado!
The specs are perfect like that.


I just can't understand how it works

Can you please me more specific in docs so everyone can understand how to use it?
In my case the chrome.cast.requestSession always sends an error with CANCEL code:
error: Error { code: 'CANCEL', description: null, details: {} }
whoops! there was an error TypeError: Cannot read property 'substring' of undefined
at _class._normalizeService (/Users/silvagc/Projetos/pessoal/salao/projection_app/node_modules/node-mdns-easy/dist/browser.js:96:57)
at _class.serviceUp (/Users/silvagc/Projetos/pessoal/salao/projection_app/node_modules/node-mdns-easy/dist/browser.js:74:35)
at emitOne (events.js:96:13)
at emit (events.js:188:7)
at internal.onMessage (/Users/silvagc/Projetos/pessoal/salao/projection_app/node_modules/mdns-js/lib/browser.js:109:12)
at emitThree (events.js:116:13)
at emit (events.js:194:7)
at Socket. (/Users/silvagc/Projetos/pessoal/salao/projection_app/node_modules/mdns-js/lib/networking.js:142:10)
at emitTwo (events.js:106:13)
at Socket.emit (events.js:191:7)

Appears to be the same issue as #35
I've never come across it so not sure what could be going wrong.  You can however fix the error and PR it in if you want as described in that issue.

In terms of usage, it is identical to the normal chrome.cast API so check out those docs for that.  I know it's identical because I dropped it on to Google sites (GPM and YouTube) and it worked flawlessly 😆

The problem was related to...... TeamViewer.
Teamviewer was somehow used in the calling of _normalizeService but didnt have all the required arguments ( like fullName for example ).
Altough i'm not having the error going i still get the same message:
error: Error { code: 'CANCEL', description: null, details: {} }
This is the service argument of the _normalizeService function:
{ addresses: [ '<IP_ADDRESS>' ],   query: [],   type:     [ { name: 'googlecast',        protocol: 'tcp',        subtypes: [],        description: 'Google Chromecast' } ],   txt:     [ 'id=290aa972e4d85e3b7536015b42b1b39b',      'rm=44382B7A2F7B494B',      've=05',      'md=Chromecast',      'ic=/setup/icon.png',      'fn=Sala',      'ca=4101',      'st=0',      'bs=FA8FCA571EB1',      'rs=' ],   port: 8009,   fullname: 'Chromecast-290aa972e4d85e3b7536015b42b1b39b._googlecast._tcp.local',   host: '290aa972-e4d8-5e3b-7536-015b42b1b39b.local',   interfaceIndex: 1,   networkInterface: 'pseudo multicast' }
I don't understand the error...

The only reason we send cancel is if the promise you provide or the default promise throws an exception.
https://github.com/GPMDP/electron-chromecast/blob/f4185d47d96074540e73e51065734843a4c08ae5/src/cast/index.js#L214

Sure?
chrome.cast.requestSession(         function (session) {             console.log(session);         },         function (error) {             console.log('error:', error);          });

I've realised that i was using the "normal" and the advanced configuration.
My question is, how to i cast one window using the chrome.cast?
The API is huge and i cant find anything related to electron..


Regent: bug in regent OpenMP parallelized loops

The following script
import "regent"

local C = regentlib.c
local fabs = regentlib.fabs(double)

local Npoint = 100

struct point {
   a : double
}

task main()
   C.printf("Start\n")
   var r = region(ispace(int1d, Npoint), point)

   for c in r do
      r[c].a = double(c)/(Npoint-1)
   end

   var c99 = int1d(r.bounds.hi)
   var Ue = 0.356
   __demand(__openmp)
   for c in r do
      var a = r[c].a
      if (a > Ue) then c99 min= int1d(c) end
   end
   C.printf("%10.5e %10.5e %10.5e\n", r[c99-1].a, Ue, r[c99].a)

   C.printf("End\n")
end

regentlib.start(main)

fails to compile if the second loop is optimized with OpenMP.
If __demand(__openmp) is commented, the program returns the expected result.

First of all, you can't put an OpenMP loop in a non-leaf task like in your code. With the change that I just pushed, the compiler will either ignore the pragma or raise an error, depending on what you give to -fopenmp. Second, int1d is not a valid type for scalar reduction. You should change it to one of the primitive types.

The real problem in my application was the reduction of int1d. Maybe you should issue an error saying that the reduction of that type is not supported instead of an OpenMP code generation failed: found a loop-carried dependence, as it happens with this script
import "regent"

local C = regentlib.c
local fabs = regentlib.fabs(double)

local Npoint = 100

struct point {
   a : double
}

task find(r: region(ispace(int1d), point))
where reads(r) do
   var c99 = int1d(r.bounds.hi)
   var Ue = 0.356
   __demand(__openmp)
   for c in r do
      var a = r[c].a
      if (a > Ue) then c99 min= int1d(c) end
   end
   return c99
end

task main()
   C.printf("Start\n")
   var r = region(ispace(int1d, Npoint), point)

   for c in r do
      r[c].a = double(c)/(Npoint-1)
   end

   var Ue = 0.356
   var c99 = find(r)
   C.printf("%10.5e %10.5e %10.5e\n", r[c99-1].a, Ue, r[c99].a)

   C.printf("End\n")
end

regentlib.start(main)

I agree that the error message is not as friendly as it could be, but it's not entirely inaccurate either and I don't think that's a problem. A reduction with an arbitrary data type like int1d is really a syntactic sugar for a read-write, which would introduce a loop-carried dependence, and there is no reason that you could assume that it could be performed atomically.

@magnatelee could we change the codegen to turn scalar updates like:
lhs op= rhs_expr

where lhs is a unhandled type and turn it into:
val tmp = rhs_expr
#pragma omp atomic
lhs op= tmp

it's likely that we (I) would need to make some corresponding changes on the Realm omp implementation, but this seems better than kicking somebody completely off the data-parallelism train.

@streichler the Regent compiler doesn't depend on any off-the-shelf OpenMP frontend, so we can't use the OpenMP pragma. Even if we could, I don't think the frontend would allow anything other than primitive types. Also, I don't think I kicked Mario completely off in this case, as he can still write the code like this:
var c99 = int64(int1d(r.bounds.hi))
 var Ue = 0.356
 __demand(__openmp)
 for c in r do
    var a = r[c].a
    if (a > Ue) then c99 min= int64(int1d(c)) end
 end
 return int1d(c99)

Closing this issue as and tracking the issue of improving error messages in #807.


.nojekyll

by default these items are created:
_/css/main.css
_/js/permalink.js
index.html

however the underscore is a problem, as GitHub Jekyll will ignore those items. to fix, you have to add an extra empty file:
.nojekyll
_/css/main.css
_/js/permalink.js
index.html

I didn't see this mentioned anywhere.

Thanks for the issue, @3052.
There's some documentation at https://abhinav.github.io/doc2go/docs/embed/jekyll/ on embedding doc2go inside a Jekyll website, and at https://abhinav.github.io/doc2go/docs/publish/github-pages/ for publishing in standalone mode to GitHub.
But yeah, it doesn't cover standalone mode as part of a Jekyll deployment. I'll leave this open as a reminder to go in and add something to the documentation around standalone deployments.


The boundary lines seem to be a little off.

Hi folks, you guys have done a great job with the maps but the boundary lines do not seem to match when put them on top of google maps. All the administrative boundaries seem to be a little off. The district boundaries might have changed but they should at least line up with the state boundaries on google. And I have compared the dist_2011 maps with other maps available online (not 2011 maps) like the GADM and maps available on IPUMS International website, they seem to be more accurate for whichever year they are mapped for.
Could you let me know the methods used to create this map.

Most of these files were created by scraping some Government sites. Do note that these should not be used for maps at a scale finer than say 1:1,00,000. If you want precise boundaries, then only the Survey of India is the Authoritative source for that. You can buy vector data from them directly.

Thank you for the response.


dpipe package

You can install dpipe as follows:
git clone https://github.com/neuro-ml/deep_pipe.git
cd deep_pipe
git checkout 5c08d5759d51c0731cc636c2866bb3a538ffab7a
pip install -e .

Thanks for your reply, and I have found this package and fixed this problem. Thanks again, best wishes!


Update README for more services

Checklist

[x] Affected Issues have been mentioned in the Closing issues section
[x] Documentation has been written/updated
[x] PR title is ready for changelog and subsystem label(s) applied

Follow up of #1906 with more updates.

Closing issues
closes #1791

@rocketeerbkw can I have you have a look at the comments of @AlannaBurke ? thanks!


crds: fix patch formatting

When passing ops as nil to patchCRD() the function
was creating a malformed patch due to initializing ops as a 1
element slice causing the next append to make it a 2 elements
slice and ending up in the patch being produced as:
[, { "op": "replace", "path": "/spec", "value": "something" }]
This is a simple reproducer of the bug:
package main

import "fmt"

const replaceSpecPatchTemplate = `{ "op": "replace", "path": "/spec", "value": %s }`

func main() {
    var ops []string

    if ops == nil {
        ops = make([]string, 1)
    }
    ops = append(ops, fmt.Sprintf(replaceSpecPatchTemplate, "ciao"))
    val := generatePatchBytes(ops)
    fmt.Println(string(val))

}

func generatePatchBytes(ops []string) []byte {
    opsStr := "["
    for idx, entry := range ops {
        sep := ", "
        if len(ops)-1 == idx {
            sep = "]"
        }
        opsStr = fmt.Sprintf("%s%s%s", opsStr, entry, sep)
    }
    return []byte(opsStr)
}

This was happening with upgrades from v0.36 to 0v.40 because a v0.36
CRD does not have the status subresource enabled causing the
virt-operator to call rolloutNonCompatibleCRDChange() which in turn
calls patchCRD() with ops as nil.
Signed-off-by: Antonio Cardace<EMAIL_ADDRESS>
What this PR does / why we need it:
Fixes patching of CRDs when rolling out non-compatible CRD changes, this happens when upgrading from v0.36 to v0.40.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5462
Special notes for your reviewer:
Release note:

Fixes upgrades from KubeVirt v0.36

/cherry-pick release-0.40

/release-blocker release-0.40


Update utils.py

Use a different algorithm for  norm=1, based on exponential distribution.
Description
A sample point is generated by a L1-normalized vector (in dimenion nb_dims + 1) of IID unit-exponential variables, then
dropping the additional dimension and flipping signs randomly.
Fixes # (issue)
Type of change
Please check all relevant options.

[v] Improvement (non-breaking)
[v] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[ ] Test A
[ ] Test B

Test Configuration:

OS
Python version
ART version or commit number
TensorFlow / Keras / PyTorch / MXNet version

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Codecov Report

Merging #1805 (cff8d90) into dev_1.9.0 (589d345) will decrease coverage by 58.27%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           dev_1.9.0    #1805       +/-   ##
==============================================
- Coverage      89.82%   31.54%   -58.28%
==============================================
  Files            244      244
  Lines          19761    19744       -17
  Branches        3495     3494        -1
==============================================
- Hits           17750     6228    -11522
- Misses          1214    13172    +11958
+ Partials         797      344      -453

Impacted Files
Coverage Δ

art/utils.py
41.73% <0.00%> (-49.40%)
:arrow_down:

art/estimators/object_detection/utils.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/attacks/evasion/shapeshifter.py
5.89% <0.00%> (-93.30%)
:arrow_down:

art/attacks/evasion/carlini.py
7.64% <0.00%> (-86.99%)
:arrow_down:

...rt/defences/detector/poison/clustering_analyzer.py
8.22% <0.00%> (-86.71%)
:arrow_down:

art/attacks/evasion/pe_malware_attack.py
14.28% <0.00%> (-84.80%)
:arrow_down:

art/attacks/evasion/square_attack.py
10.37% <0.00%> (-84.44%)
:arrow_down:

...ces/detector/evasion/subsetscanning/scanningops.py
11.59% <0.00%> (-84.06%)
:arrow_down:

art/attacks/evasion/wasserstein.py
11.94% <0.00%> (-83.28%)
:arrow_down:

art/defences/trainer/adversarial_trainer.py
11.60% <0.00%> (-82.15%)
:arrow_down:

... and 167 more


Problem: no SNARK query by work id

Related to #693

Related to https://github.com/Granola-Team/mina-block-explorer/pull/588

@Isaac-DeFrain / @trevorbernard,
Due to https://github.com/Granola-Team/mina-block-explorer/pull/588, is this still required?

It is not. Closing.


feat: include entitlement creation in a single transaction

Overview
Ensures that entitlement creation happens as a single atomic operation

Fixes #(issue)
Notes for reviewer

We will most probably rework txn handling, but for the time being it gets the job done.

/retest


Make optional wizard steps "sub pages"

As shown here: https://www.patternfly.org/v4/components/wizard/design-guidelines/#review-and-completion

Pending PR #167  reorganizes into sub-steps

PR merged - closing


Add myself (lbriggs) to the team

Added a photo and toml link, as requested

@jaxxstorm It looks like you forgot to add your middle name!


[Feature] allow the use of GetRowCount and GetColumnCount methods, making them public

I have a use case where the input CSV has a variable number of columns, and I need to load them as vectors.

Actually, I think that I need to do something like that:

#include "rapidcsv/src/rapidcsv.h"
#include <iostream>

int main(){
    rapidcsv::Document doc(rapidcsv::Properties("sample.csv", 0, -1));

    std::vector<std::vector<char>> db;

    std::vector<char> col;
    unsigned int i;
    bool stop;

    for(i = 0, stop = 0; ! stop; ++i)
    {
        try
        {
            std::cout << i << " of unknown" << std::endl;
            col  = doc.GetColumn<char>(i);
            db.push_back(col);
        }
        catch(std::out_of_range)
        {
            std::cout << "Cannot obtain column " << i << std::endl;
            stop = 1;
        }
    }

    return 0;
}

to know at runtime that there are just 3 columns:

0 of unknown
1 of unknown
2 of unknown
3 of unknown
Cannot obtain column 3

when I could use the (currently private) doc.GetColumnCount():

# include "rapidcsv/src/rapidcsv.h"

#include <iostream>

int main(){
    rapidcsv::Document doc(rapidcsv::Properties("sample.csv", 0, -1));
    std::cout << "columns: " << doc.GetColumnCount() << std::endl;
    std::cout << "rows: " << doc.GetRowCount() << std::endl;

    std::vector<std::vector<char>> db;

    std::vector<char> col;
    unsigned int i, cols = doc.GetColumnCount();

    for(i = 0; i < cols; ++i)
    {
        std::cout << i << " of " << cols << std::endl;
        col  = doc.GetColumn<char>(i);
        db.push_back(col);
    }

    return 0;
}

and obtain:

columns: 3
rows: 5
0 of 3
1 of 3
2 of 3

PS the used data is the follow:

A,B,C
a,b,c
a,b,c
a,b,c
a,b,c

@d99kris I'm not sure that the change that I'm proposing has the behavior that can be expected.
I did a commit with the follow test case in my fork (commit 9c370dd)
...
  std::string csv =
    "-,A,B,C\n"
    "1,3,9,81\n"
    "2,4,16,256\n"
    ;

  std::string path = unittest::TempPath();
  unittest::WriteFile(path, csv);

  try
  {
    rapidcsv::Document doc1(path);
    unittest::ExpectEqual(int, doc1.GetColumnCount(), 4);
    unittest::ExpectEqual(int, doc1.GetRowCount(), 3);

    rapidcsv::Document doc2(rapidcsv::Properties(path, -1, -1));
    unittest::ExpectEqual(int, doc2.GetColumnCount(), 4);
    unittest::ExpectEqual(int, doc2.GetRowCount(), 3);
...

GetColumnCount and GetRowCount are counted independent if the user consider or not the CSV top and left headers, and that make sense internally, but probably not if you agree to expose this function to the user.
Can I make two more function that uses the internal ones and keep in count the headers, what do you think?

Thanks a lot @campisano - it does make sense to have methods exposed to allow getting row and column counts. I took some parts from your patch and restructured it a little and renamed the internal methods to separate them from the new public ones. Closing this issue.


AST: Remove archetype from AbstractTypeParamDecl

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - ac0ee2d0a2ae8744a59bf24b02cc70c101b28de6
Test requested by - @slavapestov

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ac0ee2d0a2ae8744a59bf24b02cc70c101b28de6
Test requested by - @slavapestov


feature request: support blocking until Future completes

The class Future<T> should have a non-async method T get() that waits for the Future to complete and returns its value, similar to the method get() in Python's multiprocessing.pool.AsyncResult class: https://docs.python.org/2/library/multiprocessing.html#multiprocessing.pool.AsyncResult
The method should be non-async so that it can be called from a non-async function in a way that will block execution until it is finished.
Currently, to access the Future's result, the only two ways to achieve it that I'm aware of are either

create a function callback that will handle the return value when it is produced, and

make the calling function async, as well as all functions up the call stack all the way up to main(), and prepend "await" in front of them.

Option (2) is ugly and bad style, allowing a called function to dictate design across the rest of the program.
Speaking to the virtues of (1), I appreciate that in many of the web/mobile applications the Dart developers envision, it will create an unsightly delay in the UI to block until (for example) a File is opened.
However, the Dart VM allows standalone scripts run from the command line. For such a program, it makes perfect sense to have a single thread of execution that blocks until a File is opened, especially if none of the subsequent code can execute until that File is opened and its contents read. Some programs really do need to run in linear order from start to finish. It is awkward and counterproductive in this situation to impose an event-driven, callback-heavy framework.

That's not really generally possible with the current execution model of Dart.
Blocking execution waiting for a future to complete will prevent the future from completing since it's being completed by Dart code. Some operations can be performed blocking. That is mostly I/O which is why many functions in dart:io has a Sync version like readSync). Having a special kind of Future for those operations that can be waited for isn't really practical - you just use the Sync version of the function instead.
So, not all Futures can reasonably support a blocking get method. For example getting the content of an HTTP request requires quite a bit of local work in Dart code to receive, decode and combine the content. Blocking the isolate won't work. Not blocking the isolate means that your function is async, and there is no way to hide that.
For this to actually work, the runtime would need a way to suspend a single execution stack without suspending everything, allowing other asynchronous tasks to continue running until the stack is resumed.
There are two problems with that:

We can't do that when compiling to JavaScript, and
it makes it unpredictable where a function can be preempted by other code running. If you call a function that calls a Future.get method, then arbitrary code can run before that future gets back. Reasoning about state becomes much harder.

The only real solution is to treat all functions like they are async, but when compiling to JavaScript, that can get prohibitively expensive - all functions must be prepared to be suspended at all function calls, not just where there is an await in an async function.
All in all, it's not practically possible to get the value of a Future in a synchronous way.

Ah, I was unaware of the sync versions of these I/O methods. Thank you for pointing that out.


Use firestore db name different from (default)

This PR fixes https://github.com/GoogleCloudPlatform/datacatalog-tag-engine/issues/118
By default, tag engine works with the native firestore database called (default), proposed changes:

[x] Support firestore client with database parameter in JobManager, TaskManager, TagEngineStoreHandler...
[x] Support create indexes to firestore from new positional param with database name
[x] Fix get_task_count
[x] Add docu to README.md

resolve #118
close #118

@shirleycohen Can you check that everything is ok? I have signed the CLA

Thank you @francescpuig7. I've added this functionality to v2.2.9. I apologize for the long delay.


URL changed

Read this before submitting the PR

Always create a Draft PR first
Go through sections 1-5 below, fill them in and check all the boxes
Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
Add a summary of the changes in this PR and the related issue.
2. Jira task / GitHub issue
Link to the github issue or add the Jira task ID here.
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

[ ] New feature

[ ] Breaking: Why / How? Add info here.
[ ] Non-breaking

[ ] Bug fix
[ ] Security Alert fix

[ ] Package update

[ ] Major version update

[ ] Documentation <!-- Should be checked if the PR adds or updates the CLI documentation -- anything in docs/ directory. -->
[ ] Workflow
[ ] Tests only

4. Additional information

[ ] Sprintlog
[ ] Blocking PRs

[ ] Merged

[ ] PR to master branch: If checked, read the release instructions

[ ] I have followed steps 1-8.

5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

[ ] Black

[ ] Pylint

[ ] Prettier

[ ] Yamllint

[ ] Tests

[ ] TestPyPI

[ ] CodeQL

[ ] Trivy

[ ] Snyk

Forgot to add the actual URL changed to the previous PR

Didn't realize I cannot push to dev without PR for the actual change, would have added to the changelog PR otherwise

Didn't realize I cannot push to dev without PR for the actual change, would have added to the changelog PR otherwise

Can we go back and add it to the changelog PR instead if that makes more sense? Or am I misunderstanding this?

Didn't realize I cannot push to dev without PR for the actual change, would have added to the changelog PR otherwise

Can we go back and add it to the changelog PR instead if that makes more sense? Or am I misunderstanding this?

For that, we need to revert the previous PR. So, approve another PR with the revert. And then remade that one.
I would have added there, didn't realize at the time that I cannot make a change outside a PR due to the security policies.


System tray missing all but two applications, and icons missing

Describe the bug:
The system tray area in Tabame is missing most of my applications, so I have to reshow the taskbar to access them. The couple that show are missing their icons.
Screenshots: (optional)
My actual horribly busy system tray:

tabame's tray:

Desktop:

Windows Version: Windows 10 21H2 19044.2364
Tabame Version: 1.3

+1 for this. Thanks for the great write-up.

+1 Have the same problem. But no any tray icons.
Windows 11 22H2
Admin privileges
Tabame v 1.3

+1 Have the same problem. But no any tray icons. Windows 11 22H2 Admin privileges Tabame v 1.3

same problem

Tray icons is a experimental feature. Windows does not offer official documentation to access them, I had to do some trickery that took me days and it works on most cases. If it doesn't work for you, I can not do anything to fix it, there is no other approach to access tray icons. Sorry. Edit: If you want an app tray icon to appear on Tabame, put the tray icon on taskbar, not on toggle menu. Drag it and put it to be always visible, it should work.

I'll continue my search for a system tray replacement.   I appreciate you trying to get a tray clone to work.
The app is still very useful with all of the other things it can do.  Thanks.


Saml: Logging in with SAML user creates a new environment with name "-Default"

Rancher Version:
Master image
Docker Version:
1.12.2
OS and where are the hosts located? (cloud, bare metal, etc):
Ubuntu 16.04
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node rancher
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
cattle
Steps to Reproduce:

Enable SAML Authentication
Choose “Allow any valid User” as “Site Access”
Login with any SAML user.

Results:
A new environment is created for this user but with name "-Default" instead of "testuser3-Default"

This is actually default behavior for all auth providers. If you aren't invited to any environments, we will create a default user environment for you.


Investigate: Allow pods on master taint

When clusters are deployed with AllowPodsOnMasters: false it appears the pods may still be scheduled on masters anyway.

Fixed.


Support external dialect/schema/etc

Overview
We need to support providing dialect/schema/etc by a path (according to the standards)

DUPLICATE #197


Revert: remove options that are not valid for btrfs

commit 01e64bd88157e89c01a4e2e2402e42b3c9a99fbe
I want to see performance of a run with this patch
maybe it does not matter because of the virtio cache mode
that we use on mkcloud hosts.

-1, product management requires us to move to btrfs going foward.

fixed the btrfs part

thanks, with that modification I don't -1 this anymore but I would rather want to see the work going into the chef cookboosk of setting up a partition with proper mount flags rather than hacking this in mkcloud.
I did notice in a benchmarking demo environment that this is indeed a very immense performance penalty in our product (factor 3-4 for VM setup) so its worth fixing it for customers as well.

closing for now. rootflags=data=writeback needs to go into grub.cfg instead of fstab, which seems not easy to do with autoyast


fix(ui): prevent scroll jittering in Firefox and Safari

Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This PR fixes an issue with scrolling in Firefox and Safari, caused by the scroll-linked elements firing scroll events of their own when they are programmatically scrolled.

You've been told off by our bossy lint rules

Could have sworn I checked ESLint before committing...  >:(


Comments duplicated

https://vlepy.github.io/2021/07/07/clockwork.html and
https://vlepy.github.io/2021/07/07/clockwork2.html
share the same comment even tho it was added just as an single issue,

I'm seeing the same thing. It seems like utterances is matching the beginning of the string, but not the entire string for the url. For the above example, a github issue that is titled 2021/07/07/clockwork will show up on both pages. Expected behavior is for it to not show up on the clockwork2 page.

I'm seeing the same thing. It seems like utterances is matching the beginning of the string, but not the entire string for the url. For the above example, a github issue that is titled 2021/07/07/clockwork will show up on both pages. Expected behavior is for it to not show up on the clockwork2 page.

Same problem too. I solved it by switching the mapping to "Issue title contains page URL." It works for me till now, but things may be different on your site.
There is a similar issue posted before. You may get some information there.


include dispatch result in the Executed event

So we can have some clue why it failed.

polkadot companion build error looks unrelated

companion build failing?

good now

bot merge


SCSS Not Properly Highlighting  font-feature-settings property

In a scss file:
body {
    font-feature-settings: "kern" 1;
    font-kerning: normal;
}

Both font-feature-settings and font-kerning are split into two sections instead of being a single property:

This issue was moved to atom/language-sass#201


while trying to fetch the code from databases struct name is getting replaced with the underscore after every uppercase letter

Your issue may already be reported! Please search on the issue track before creating one.
What version of Go are you using (go version)?
1.11
Which database and its version are you using?
mysql
Please provide a complete runnable program to reproduce your issue. IMPORTANT
Need to runnable with GORM's docker compose config or please provides your config.
package main

import (
	"github.com/jinzhu/gorm"
	_ "github.com/jinzhu/gorm/dialects/mssql"
	_ "github.com/jinzhu/gorm/dialects/mysql"
	_ "github.com/jinzhu/gorm/dialects/postgres"
	_ "github.com/jinzhu/gorm/dialects/sqlite"
)

var db *gorm.DB

func init() {
	var err error
	db, err = gorm.Open("sqlite3", "test.db")
	// db, err = gorm.Open("postgres", "user=gorm password=gorm DB.name=gorm port=9920 sslmode=disable")
	// db, err = gorm.Open("mysql", "gorm:gorm@tcp(localhost:9910)/gorm?charset=utf8&parseTime=True")
	// db, err = gorm.Open("mssql", "sqlserver://gorm:LoremIpsum86@localhost:9930?database=gorm")
	if err != nil {
		panic(err)
	}
	db.LogMode(true)
}

func main() {
	if /* failure condition */ {
		fmt.Println("failed")
	} else {
		fmt.Println("success")
	}
}

Please provide a sample code.
Do you write gorm:"column:xxx" tag?
http://gorm.io/docs/conventions.html#Snake-Case-Column-Name
type Table struct {
  UpperCase string `gorm:"column:UpperCase"`
}

when In  give the struct name as  DemoProject which is already a table name in the database and run the program it  throws error:
1146: Table 'DataBase.demo_project' doesn't exist

when In give the struct name as DemoProject which is already a table name in the database and run the program it throws error:
1146: Table 'DataBase.demo_project' doesn't exist

Do you Specify TableName() func?
http://gorm.io/docs/conventions.html#Pluralized-Table-Name
func (DemoProject) TableName() string {
  return "DemoProject"
}


Left navbar error: Failed to read JSON

Describe the bug
No info/playlists on left navbar. See screenshot.
Failed to read JSON: invalid type: null, expected a string at line 18 column 27
To Reproduce
Open psst
Expected behavior
No error shown.
Screenshots

Environment

OS: Linux Mint
Version: 20.3 Cinnamon (5.2.7)
kernel 5.13.0-35

Additional context
Add any other context about the problem here.
Thanks for the great work with Psst!!

Hi @soyacz, sorry about the late reply. Does the problem still persist? Do you get any interesting log output in the console?

Not persisting anymore. Closing.


CharacterPower.m_power_tpl is now CharacterPower.get_power_template()

Closes #526 .
Additions/modifications proposed in this pull request:

Using CharacterPower.get_power_template(), which takes the template from MapServerData based on m_power_info's pcat, pset, and pow_idx

The How's:

Created CharacterPower.get_power_template()
Changed serialization on CharacterPower
Removed m_power_tpl, m_name, m_num_charges, m_usage_time, m_activation_time, m_range, m_recharge_time from CharacterPower
The variables removed above are now obtained from get_power_template()
MapServerData has power-related functions in which you can grab them without going through the layers in the calling functions

Code architecture in functions that take in the powers from MapServerData is changed a bit (For example, to get a particular powerset from MapServerData, you now call getMapServerData()->get_powerset()) so I hope you don't mind. Also, there's no exact equivalent for m_activation_time in PowerData, so I'll assume it is ActivationPeriod

I'll review this in detail later, but one thing I'll note is that m_activation_time will be a time point needed for calculating things like recharge timer, and NetFx for powers (across the network)
For now we can remove it, but eventually we'll need to keep track of when a power was fired.

The functions returning stuff from the templates should most likely return const & instead of copies of the values :)

With a cursory glance, I really like this implementation. I wish I would have thought of it.
If no one tests before I'm back, I'll review this on Tuesday.
As always, great work eoS

For now I'll leave m_activation_time as get_power_template().ActivationPeriod, I guess.
The functions in MapServerData now return const&
Np broxen

Looks good. Needs testing and merge

Getting linking errors with this one. It appears as though NetStructures can no longer access DataHelpers.h
Perhaps @nemerle can provide some guidance.
../../../Common/NetStructures/libnetwork_structures.a(Character.cpp.o): In function `Character::finalizeLevel()':
/Segs/Projects/CoX/Common/NetStructures/Character.cpp:102: undefined reference to `getMapServerData()'
../../../Common/NetStructures/libnetwork_structures.a(Character.cpp.o): In function `CharacterPower::getPowerTemplate() const':
/Segs/Projects/CoX/Common/NetStructures/Powers.h:177: undefined reference to `getMapServerData()'
../../../Common/NetStructures/libnetwork_structures.a(Powers.cpp.o): In function `getPowerCatByName(QString const&)':
/Segs/Projects/CoX/Common/NetStructures/Powers.cpp:203: undefined reference to `getMapServerData()'
../../../Common/NetStructures/libnetwork_structures.a(Powers.cpp.o): In function `getPowerSetByName(QString const&, unsigned int)':
/Segs/Projects/CoX/Common/NetStructures/Powers.cpp:219: undefined reference to `getMapServerData()'
../../../Common/NetStructures/libnetwork_structures.a(Powers.cpp.o): In function `getPowerByName(QString const&, unsigned int, unsigned int)':
/Segs/Projects/CoX/Common/NetStructures/Powers.cpp:235: undefined reference to `getMapServerData()'
../../../Common/NetStructures/libnetwork_structures.a(Powers.cpp.o):
/Segs/Projects/CoX/Common/NetStructures/Powers.cpp:249: more undefined references to `getMapServerData()' follow

Per Nem, maybe we use a singleton here for GameData, like we did with Settings class.

Great PR. Thanks eoS!


How to cleanly remove kitchenplan?

I've used Boxen before, and one thing they've got which is really neat is a nuke script to clean everything boxen installed.
Is there a way to do that with kitchen plan yet?
I <3 this project. Thanks for all the hard work.

No, Kitchenplan doesn't have a nuke script.
To be able to do this, boxen does a lot of very specific stuff to install everything in custom boxen locations. So your ruby and gems are in a special location, etc etc. I worked with Boxen before starting Kitchenplan and these custom things made some stuff a lot harder than it should be.
Kitchenplan is made specifically that the end result after running it, is the same as if you would install all the things by hand. Think of it as if you would delete /opt/kitchenplan that you can't see a difference between a kitchenplanned computer and a computer installed by hand. This also means that if there are errors, or something doesn't work the way you want, everything you find online is relevant. This is also the reason we depend heavily on homebrew and homebrew cask, these are huge communities that keep everything up to date, while the kitchenplan "shell" is just a little configuration and some settings.

Oh, great explanation. Thanks for that! I'll submit a PR for a FAQ with this content in it.

Answered and closing!


Updated readme

You are correct. Renew isn't needed at all.. Somehow I've tested everything with renew... But I now see it works without as well.

Thank you @tychop :+1:


-o option is not working.

Description
The -o option always results in output to api/.
npx openapi2aspida -i=path/to/spec.yml -o=lib/api/sample

Environment

Package version:
v0.23.1
OS:

[ ] Linux
[x] Windows
[x] macOS

Node.js version:
v18.16.0
npm version:
9.5.1

Additional context

Fixed in v0.23.2


"qemu-system-x86_64: -audiodev: invalid option" Ubuntu 19.10

This says it all, unsure what option is invalid but some option inside the section for -audiodev does not like.

Did you change the -audiodev option? If so, please give me the new line you've put.

@KaiLyons Please make sure you have current git of Quickemu and also the qemu-virgil snap installed. See the README.md for updated install instructions.

It was the newest, I installed qemu-virgil and did everything the README told me

My thought is that your qemu-virgil version is old.

It was the newest, I installed qemu-virgil and did everything the README told me

I recognize that error, I got that as well as I missed installing the --edge version of virgil. I had to uninstall virgil and then do a proper snap install qemu-virgil --edge to get that message to disappear.

Yeah that was the issue, thanks!


Issue with download.js

Hi @KlausSchaefers
I encountered an issue downloading all of a sudden.
See below for the error logs
Download Figma file...
(node:1804) UnhandledPromiseRejectionWarning: FetchError: invalid json response body at https://api.figma.com/v1/files/C8D1Wm3pmgT0rnzhdaxu5j?geometry=paths&plugin_data=858477504263032980 reason: Unexpected token < in JSON at position 0
    at C:\Users\paperspace\Documents\Govind\figma-low-code\node_modules\node-fetch\lib\index.js:272:32
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
(node:1804) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:1804) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I have also some issues accessing Figma API... I guess it is more an issue on their side.

can you just try again?

I open bug at Figma

Oh OK, I see.
Would keep trying.
Or I might just move from Figma to Quant-UX .
Thanks.

It's working now.

Hi,
can you test the latest version 1.0.23? I fixed a bug with autoLayout, and
I would like to be sure it does not break anything.
Cheers,
Klaus
On Mon, Jun 21, 2021 at 9:12 AM Michael Kingsley @.***>
wrote:

It's working now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/KlausSchaefers/vue-low-code/issues/20#issuecomment-864825716,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWHOQFCJ4HZSUVR4XKIRLDTT3X5PANCNFSM4677FX2Q
.

--
“Overfitting” is not about an excessive amount of physical exercise...

Hi @KlausSchaefers
Took a break, due to some targets I needed to meet a  work,
Now I'm back. :)
Testing with 1.0.26, and the autolayout; that is zooming out/in broswer page does not fit the page.
When browser zoom level is 100% the page proportion does not fit and keeps adding whitespaces, until I zoom in.
Is this the autolayout you were referring to?

@KlausSchaefers This is what I mean below
The extra white spaces at the left and right is what I mean.


Memory leak while calling "get_key_frames_from_video" function in a for loop

While calling the function "get_key_frames_from_video (path_to_video, no_of_frames)" in a for loop, RAM usage goes on increasing.
For just 10 small videos ( < 1min ) in loop, RAM usage went beyond 6GB

got it now.
Thanks for clarification🤗.

Sorry to disturb you again.
This time I tried running it on VM with 64 GB RAM. And only this key_frame_extraction script was running on the machine. But this time  also RAM size went on increasing with every next vedio in the for loop.

This time also % RAM usage was increasing :
[5.5, 7.6, 9.5, 11.5, 13.6, 17.0, 19.1, 21.2, 24.7, 26.8, 29.0, 32.5, 34.6, 36.9, 40.8, 43.4]
I don't know where but there is some issue somewhere because according  to you max ram usage should be around 6 GB but here it's always increasing and went upto 30 GB of RAM (after which I stopped script).

Hi @RahulnKumar , thanks for reaching out. I was wondering if you would like to contribute to this project with this issue fix. We are bit overwhelmed with our office work at the moment and might not be able to investigate immediately.

Ok, sure. I'll let you know when fixed.

Can you also tell me which operating system and OS version you are using ?
Also which python version you are using ?
I am unable to replicate the issue in MacOSX

Also if possible can you put
import gc
and then
call gc.collect()
in  for loop and see if memory usage explosion is still happening ?

Yes, I tried garbage collector earlier also. Again I tried, still facing the same issue .
These are some specifications you asked:
OS : Ubuntu 18.04
Python version : 3.6.9

This memory leak issue is fixed in katna version 0.9.0, kindly test and confirm.

Yes Working perfectly now. 😊
But there is still a very  small issue.
def extract_video_keyframes(self, no_of_frames, file_path, writer):
        """Returns a list of best key images/frames from a single video.

        :param no_of_frames: Number of key frames to be extracted
        :type no_of_frames: int, required
        :param file_path: video file location
        :type file_path: str, required
        :param writer: Writer object to process keyframe data
        :type writer: Writer, required
        :return: List of numpy.2darray Image objects
        :rtype: list
        """
        top_frames = self._extract_keyframes_from_video(no_of_frames, file_path)
        writer.write(file_path, top_frames)
        print("Completed processing for : ", file_path)

You forgot to  add  return top_frames in this function and that is causing problem 🤔. So None is returned instead of list of images while calling this function.

It is breaking change from the last version. The function not only extracts but saves it on the disk as well via the writer. Documentation has been updated with the details
https://katna.readthedocs.io/en/latest/tutorials_video.html

I got it. Thanks. 🤗


Refactor modutils as a more object-oriented package

What started off as a small collection of functions has become more complex and could use a refactor now knowing what is required of modutils. The package would be much simpler if an object-oriented approach would be taken for describing modules. Here's a list of features that would be easier to implement with OOP:

[ ] Format {REPODIR} and {MODSDIR} in formatters (e.g. switch_on_*() functions)
[x] Use inspect package to pull standard variables from parent frame (example)
[ ] Automatically check/store locals() when setting up a module and restoring locals() when cleaning up a module, allowing switch_on_*() dictionaries to be created separately.
[ ] Better handling of unmatched_normal_id and unmatched_normals.
[x] Better warning/error messages. For example, the module name should be included in the following warning:

Some samples have seq_types {'mirna'} that are not configured in the pairing config. They will be dropped.

Will close this for now, unsure where this is going and what to implement. Can always re-open the issue later when this becomes more urgent.


templates using<EMAIL_ADDRESS>not HMRing the CSS, upgrade to 7.0.5

Description
I installed a brand new basic template and CSS HMR was not working out of the box, then I realized that in<EMAIL_ADDRESS>that problem was solved.

Changes/Tasks

Upgrade all templates react-static version to 7.0.5

Motivation and Context

CSS was not properly HMRing in 7.0.0, so a brand new instalation wouldn't work as intended

Types of changes

[ ] Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
[ ] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] I have updated the documentation accordingly
[ ] I have updated the CHANGELOG with a summary of my changes
[ ] My changes have tests around them

Closed because this was not the solution.


Problem launching Windows processes from inside WSL2 Docker

Windows Version
Microsoft Windows [Version 10.0.19045.3448]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-1
Distro Version
Ubuntu 22.04
Other Software
Docker CE, version 24.0.7. Installed on WSL2 from Docker's apt repo.
Notepad.exe
Repro Steps
I am working on a project that needs to run Windows applications from inside of a WSL2 Docker container. When I try to launch a Windows application directly (notepad.exe used as an example), I get a strange failure. The failure doesn't occur if I launch it from inside of a shell instead.
 I can also make a script with the contents of:
#!/bin/bash
/mnt/c/Windows/system32/notepad.exe "$@"

and run that instead of a shell, and it works as expected.
What's going on here? Can anybody help me out with a workaround?
Expected Behavior
In all cases, notepad should launch identically.
Actual Behavior
Launching notepad.exe from sh/dash works, as does putting it in a shell-script that runs under bash. Launching it directly fails, as does launching it from bash (even though that works when placed in a script).
All failures produce this message on stderr:
<3>WSL (1) ERROR: ConfigInitializeEntry:1621: Failed to mount (null) at /dev as devtmpfs 1

Diagnostic Logs
I couldn't think of any useful dianostic logs. Let me know if there's anything specific that you'd like to see.

/logs

Thank you @nrclark. The issue is that the executable that runs windows executables has special logic when its pid is 1, and inside a docker container it will behave that if it's the first process.
 I also noticed something else that's related. When I have systemd enabled in wsl.conf, I can't run Windows processes from inside of Docker at all.  Instead of that /dev error, I get this interesting one instead:
sh: 1: /mnt/c/Windows/system32/notepad.exe: not found.

Note that if I run `sh -c 'ls /mnt/c/Windows/system32/notepad.exe' instead, the executable is -detected- OK, so it's definitely still getting mounted into Docker without issue.
This error occurs when:

Systemd is enabled and running.

Docker is installed and active. It doesn't matter which Docker I use, or whether I run the service using systemctl start docker or manually using service docker start. When using service docker run, it also doesn't matter whether I do it from inside of a shell or whether I do it via wsl.exe from  Windows via cmd.exe.

I try to run any Windows process from inside of a Docker image, even through methods that work when systemd is disabled.

I took a log capture of this happening and attached it to this ticket.
WslLogs-2023-12-08_22-14-56.zip

@nrclark does adding
-v /init:/init:ro

or equivalent --mount incantation to your docker run help? I think I might have just had the pleasure of running into exactly the  same issue and from what I can tell the problem is that WSLInterop registers /init as interpreter:
cat /proc/sys/fs/binfmt_misc/WSLInterop
enabled
interpreter /init
flags: PF
offset 0
magic 4d5a

but /init isn't present in the container AKA ENOENT/"file not found". Adding explicit bind-mount resolved the problem in my case.
I could swear this used to work without, but now I'm starting to doubt my memory. 🤷

@ndreys thanks for the pro-tip! You're right, that got .exe execution working under Docker when systemd is active.  It's interesting that .exe execution works in non-systemd Docker without the explicit /init binding - maybe some more PID1 trickery.

Fixed with https://github.com/microsoft/WSL/releases/tag/2.1.0


Sidebar not showing all network tables entries

Describe the bug
I can not get 3d poses to show up on the left when following the "3D Field" tutorial.
To Reproduce
Steps to reproduce the behavior:
Follow the instructions listed in 3D Field to publish Pose3d objects. Both the array and single Pose 3D. They will not show up on the sidebar to select
Expected behavior
The NetworkTables entries appear on the left
Screenshots
Network Tables entries

No corresponding sidebar entries.

Version (required):

Additional context
Maybe it is related to the struct type? I have a Field2d showing up correctly. I am also running from a simulator

Are you publishing the fields without a leading /? In the latest released version a leading slash is required for NT entries, though I just pushed a fix for that (12afa312baba019aa4ca15484459dc5d3cc6c489). It's definitely misleading that the examples in the docs don't include that.
Let me know if that seems to explain the issue, otherwise I can do some more digging.

Dude!!!! It worked!!! I was reverse engineering your code and using the developer console debugger. I would have never found that.
Is the leading slash a NT standard? If so I can make a PR for the docs.

The leading slash isn't required by NT, so the fix I pushed should make it work properly without that. That should take care of the issue with the docs, but thanks for the offer.

BTW, this tool is amazing! This is the best-designed solution I have ever seen introduced into FRC. I really hope everyone starts using this tool so we can see some cool auton and less bugs!


Can't import bookmarks exported from chrome

I exported my bookmarks from chrome. They appear to be in the right format. Nothing happens when I try to import. I get redirected to the search screen and nothing happens. No bookmarks imported.

Hey @yeahsmaggy!
For the imports to work, you need to be running the Celery workers. You'd do that via honcho start. Can you try that and let me know if it still doesn't work?
Apologies for the late response.

Did it work for you @yeahsmaggy ? I'm facing the same issue.
I had to edit all instances of Tag() to add userid and text in the constructor (https://github.com/crestify/crestify/blob/master/crestify/services/parsers.py#L84). But then I get another exception - AttributeError: 'Bookmark' object has no attribute 'tags_relationship'

Closing in favor of #39


Select field validation

Is required or custom validation supported for select fields? I tried both and couldn't get a selected option to make the form valid. It seems the custom validation function only ran once on form load instead of whenever the field changed.

No, currently not.
I wasn't sure how likely it would be for people to use selects or textareas with svelte-use-form, but adding that functionality will be pretty straight forward.
Thanks for pointing that out, I'll work on it

Awesome! Radios would be a nice addition too. 😀


Change index on transition end instead of on touch end

This is a follow-up to #171. A new onTransitionEnd callback was added to allow delaying any cpu-intensive rendering, certainly in scenarios where views are virtually rendered through the slideRenderer callback, until after the swipe animation is completed, to avoid a jerky animation.
However, slideRenderer will still be called 'on touch end', along with updating the previous & current index on the state, so this doesn't change anything to that scenario.
A possible alternative solution I see would be to be able to configure whether you want the component's current & previous index state to be changed on touch end or on transition end - along with calling both the slideRendered to render the next slide, and trigger a callback. So in this scenario; you'd only have one callback; but the moment at which it will be called will be different.
Some more background info on why I'm using the callback in my situation (maybe I'm taking a wrong approach): I would like the selected view to be set by my application state, and reflected in the application's route. Concretely: swiping through the views should, through a callback, update some 'selected view' property my store, which in turn would update the route and delegate this 'selected view' state to the component which renders the swipeable views. Because the new 'selected view' would be the same as its internally 'selected view', no re-render would be necessary.

@vincentsels Thanks for raising this issue. That's a very good starting point to work on some further improvements for the virtualized HoC.

be able to configure whether you want the component's current & previous index state to be changed on touch end or on transition end

There is one missing information that we have to take into account. The virtualized HoC is increasing the displayed window by 1 when users are swiping forward at the onTouchEnd callback. This allows users to swipe as fast as possible.
For some reason, there is a limitation for doing it when swiping backward (#152).
I plan to fix the issue and to have the same behavior when swiping backward.
However, you are right, there is room for improvement. E.g. on the Demo8 of the docs, slideRenderer is called 7+6 times when swiping forward and 6+6 times when swiping backward.
I'm not sure what the best strategy is. We have two dimensions:

Mounting component
We could be deferring the injection of the dom elements that are not on screen.
React.createElement
We could be reducing the number of calls to slideRenderer.

Good point about being able to swipe fast, before animation ends. Hadn't thought about that at all :/.
Not sure if I fully understand those two dimensions you refer to though.
I suppose ideally we should render a configurable number of 'excess' views on animation end, and only render a view ad-hoc during an animation when it was not yet rendered but would appear inside the viewport.
Alternatively, you could work with some sort of placeholder which gets displayed for unrendered views in the viewport, and always only start actually rendering them on animation end. This seems like a really big change though.

@vincentsels curious if you ever got any type of solution working.
I have the exact same use case and have tried all kinds of crazy stuff like grabbing prop values from  my swipeable components, setting slideIndex on my component (not in state because updating state in slideRenderer causes issues), and using that in onTransitionEnd to grab the current card by index and use the cards data-prop to grab my currentCategory then calling a redux action in onTransitionEnd, but the indices don't seem to be lining up properly.

@steezeburger: No - I had to switch back to onChangeIndex.

Got into the same problem. I did something similar to @steezeburger has described, as setting a slideIndex on my own component, and managed to get it working mostly fine with some minor issues, but I don't yet have time to tidy up the code and share it. just FYI that's feasible I.