V3.0.0

Breaking Changes

The NVRJS_CAMERA_RECORDINGS directory is no longer used.
The Storage mechanism has been updated, and is not compatible with previous recordings

You can continue to run this version with no issues, but previous data will not be available.

Event payload properties have been updated.

name -> event
date -> timestamp

New Features

Raise an event whilst reviewing live footage
Each recorded segement, now contains a hash, this offers the ability to check for modifications of recorded footage (SHA256).
Allow post input configuration This allows to convert a stream that may not natively be h264
Ability to disable security, allowing 3rd party access control.

Changes

Dependency updates.
SQL storage has been removed and replaced with JSON files
Performancee updates

@marcus-j-davies, looks like you got so close to completing this version 3.0.0. I forked this and ran it, but I see that on this version, my cameras start on launch but then endlessly terminate and respawn. This was not an issue on 2.0.0 (same camera with same settings worked fine). I can't find an obvious reason for this but am not well versed with in ffmpeg/mp4frag. Any ideas (if you're still kicking around this project)? Thanks!

Configuring camera: Front Cam
Camera: Front Cam started.
Strting purge timer.
NVR JS is Ready!
Purging data.
Camera: Front Cam was terminated, respawning after 10 seconds...
Camera: Front Cam was terminated, respawning after 10 seconds...
Camera: Front Cam was terminated, respawning after 10 seconds...


Adding pip libraries for system tests

I have added some python modules so we can run the system tests on this node, as the tests themselves use docker containers.

Isn't this required anymore?

@amues sorry, I don't think so, I'm planning on running the system tests on the node directly rather than in a container.


Add missed @throws annotation

IDE and static analyzers complain about Google_Exception when I use try/catch to handle it.
It looks like the code is autogenerated. Is it possible to add this missed annotation using generation script?

No, I disagree.


Style: actual code fails on Clippy rules

Bug description
When pushing a PR to dev  branch, the github action that checks code style fails on some clippy rules.
To Reproduce
You can see it on this PR: https://github.com/hubblo-org/scaphandre/pull/160
The clippy check triggered by a gitlab action is cargo clippy -- -A clippy::upper_case_acronyms -D warnings.
See https://github.com/hubblo-org/scaphandre/blob/9498ae56a09a9c1cf795cd3f609c54ba858e7e2d/.github/workflows/rust.yml#L57
Expected behavior
Apply small refactoring of existing codebase to be compatible with clippy rules.
We could use clippy -fix for some automated default fix + do other changes manually.

This is fixed right ? (seems so regarding the merged PR and latests discussions, but just to be sure)


New version: SQLite.SQLite version 3.46.1

Checklist for Pull Requests

[X] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[X] Have you checked that there aren't other open pull requests for the same manifest update/change?
[X] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Accidently deleted branch, reopened as: #171162


build: add pull request labeler

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Next button on ToolsAndEulaPage gives. persistent spurious error

Steps to Reproduce:

Start with a state where az.cmd is not installed
Kickoff BDC deployment wizard
The tools and eula page warns that az.cmd is not installed.
Click 'Install Tools' button to install az.cmd. Click 'Next' once the installation is done.

Actual: An unexpected error 'Some tools are still not installed' shows up. This error persists if the user dismisses the error and clicks 'Next'. The wizard is rendered to be unusable.

Expected: The wizard proceeds to the next page.
Workaround: Cancel out of the wizard and launch it again. All tools are discovered and the wizard proceeds to 2nd page.
Azure Data Studio Version:
Version: 1.25.0-rc1
Commit: 2d50d2c5d1ed5f426c46e06cee436dce8debc6c9
Date: 2020-12-03T02:46:44.284Z
VS Code: 1.48.0
Electron: 9.3.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

Duplicate of https://github.com/microsoft/azuredatastudio/issues/13679


Different prompt_tokens size between Azure OpenAI and OpenAI

Describe the bug
I found same source URL with different gpt source (azure-openai, openai) have different prompt_tokens estimation.
Here is my code:

OpenAI

import os
from scrapegraphai.graphs import SmartScraperGraph
from scrapegraphai.utils import prettify_exec_info

graph_config = {
    "llm": {"api_key": os.getenv("OPENAI_API_KEY"), "model": "gpt-4o-mini"},
    "verbose": False,
    "headless": True,
}

smart_scraper_graph = SmartScraperGraph(
    prompt="List me what does the company do, the name and a contact email.",
    source="https://scrapegraphai.com/",
    config=graph_config
)

result = smart_scraper_graph.run()
print(result)

graph_exec_info = smart_scraper_graph.get_execution_info()
display(prettify_exec_info(graph_exec_info))

Azure OpenAI

import os
from scrapegraphai.graphs import SmartScraperGraph
from scrapegraphai.utils import prettify_exec_info

graph_config = {
    "llm": {
        "model": "azure/gpt-4o-mini",
        "api_key": azure_openai_settings.api_key.get_secret_value(),
        "azure_endpoint": azure_openai_settings.azure_endpoint,
        "azure_deployment": azure_openai_settings.azure_deploy_name,
        "api_version": azure_openai_settings.azure_api_version,
    },
    "verbose": False,
    "headless": True,
}

smart_scraper_graph = SmartScraperGraph(
    prompt="List me what does the company do, the name and a contact email.",
    source="https://scrapegraphai.com/",
    config=graph_config
)

result = smart_scraper_graph.run()
print(result)

graph_exec_info = smart_scraper_graph.get_execution_info()
display(prettify_exec_info(graph_exec_info))

The difference might be due to missing HTML data in the token calculation. I'm not sure which .py file is responsible for handling the token computation.

Thanks for pointing this out. @VinciGit00 and @DiTo97 did some split experiments a few months ago, that led to the conclusion that GPT models could scrape webpages converted into Markdown quicker than raw HTML pages, while retaining the same quality of the results, unlike all other models tested. Therefore, an OpenAI-specific optimization was added to the library, to turn HTML webpages into Markdown before sending them to the LLM.
Unfortunately, no one in the team thought about adding this same feature to the GPT models hosted on Azure, so thanks for pointing this out. I will make a quick fix, that will be added to the next beta. I'll let you know when it's published, so that you can re-run your experiment and see if now the tokens match.

hi please update to the new beta


OS/2: "The version number is valid, but less than 5" [W2106]

I'd recommend to downgrade this warning message to informative status.
I think it's perfectly fine to have OS/2 table version less than the current one (version 5), as long as one does not attempt to use any of the flags which are only defined in subsequent versions of the table.

Somewhat edited version of my previous comment
( https://github.com/HinTak/Font-Validator/issues/9#issuecomment-162055208 )
I am okay with that. It got bumped up from v3 to v5 because Behdad's CBLC/CBDT font sample has a v4 OS/2 table . So the recent change basically means warning on every font I have, as I don't actually have a v5 sample.
Two questions for Microsoft folks: (1) how keen they are to push people to update fonts to latest spec, as well as (2) their plans on their internal version in this matter, and anticipating divergence between the two.

I just found another issue with OS/2 table version.
My font has OS/2 table version 4 and the bit 7 (USE_TYPO_METRICS) set.
FontVal is complaining that:
E2101:  There are undefined bits set in fsSelection field:  Bit(s) 7

However bit 7 is indeed defined in OS/2 version 4:
http://www.microsoft.com/typography/otspec/os2ver4.htm

The fsSelection field usage should be easy enough to update. Can you post a font sample for testing? When I bumped the version up from v3 to v5, I only added the larger table size of v5 as valid, and left a bunch of TODO comments all over; if I recall, the OS/2 codepage bits usage were massively updated - some 40? reserved bits were allocated, etc. That's a big TODO. Adding a few fsSelection bits should be easy.

this font has OS/2 format 4 and fsSelection bit 7 set:
https://github.com/behdad/fonttools/blob/master/Lib/fontTools/ttLib/testdata/TestTTF-Regular.ttx

@anthrotype I think this is the change to allow bit 7,8,9 for OS/2 v4+ . Can you give it a go? I'll have it in my private repo and test it when I next-sync the private repo with the repo for the next binary build, but that's weeks away and not happening any time soon. If you can give it a test that would be great.
diff --git a/OTFontFileVal/val_OS2.cs b/OTFontFileVal/val_OS2.cs
index 4738f4a..f8fd11e 100644
--- a/OTFontFileVal/val_OS2.cs
+++ b/OTFontFileVal/val_OS2.cs
@@ -641,8 +641,8 @@ namespace OTFontFileVal
}
             // reserved bits

           // TODO: Bit 7,8,9, v4

           if ( (fsSelection & 0xFF80 ) != 0 )

           if ( ( (fsSelection & 0xFF80 ) != 0 )

                || ((fsSelection & 0xFB00 ) != 0 && version > 3) )
           {
               // we need to look for Win 3.1 font pages
               // Fonts with these

@@ -686,7 +686,8 @@ namespace OTFontFileVal
for (int i=0; i<16; i++)
{
int nBitValue = 1<<i;

                               if ((nBitValue & 0xFF80) != 0)

                               if ( ((nBitValue & 0xFF80) != 0 && version < 4)

                                    || ((fsSelection & 0xFB00) != 0) )
                               {
                                   if ((fsSelection & nBitValue) != 0)
                                   {

@@ -711,7 +712,8 @@ namespace OTFontFileVal
for (int i=0; i<16; i++)
{
int nBitValue = 1<<i;

                       if ((nBitValue & 0xFF80) != 0)

                       if ( ((nBitValue & 0xFF80) != 0 && version < 4)

                            || ((nBitValue & 0xFB00) != 0) )
                       {
                           if ((fsSelection & nBitValue) != 0)
                           {

I can't apply the patch as Markdown screwed the formatting.
You need three backtick quotes to embed a block of code in Markdown
```
   <your indented code here>
```

Why don't you just make a branch on your own fork? I can the git checkout it.

@anthrotype : my markdown-fu is a bit lacking - anyway, the markdown is corrected now...

Sorry about that... need to improve my markdown-fu :-). My private repo is a bit messy - the current pattern seems to work okay, I do changes, sit on it for a few days (or weeks...), when things don't break, scrub, collapse, and push it out just before I want to do a binary build...
Anyway, still going through my old e-mails...

I pulled your fork's master branch and applied that patch. Then rebuilt it with make clean && make, and tried again with my test font, which you can find here:
I run the FontValidator.exe like that:
mono bin/FontValidator.exe -file "/Users/cosimolupo/Desktop/TestTTF-Regular.ttf"

Unfortunately, the generated report is still complaining that the OS/2 table "version number is valid, but less than 5...". The "Details" field on the right says "3", but the version of the table in the actual font is "4"...
The test font has Bit 6 (REGULAR) and Bit 7 (USE_TYPO_METRICS) set. The latter was specified in OS/2 table v. 4.
I don't think there's anything wrong with having an earlier version of a table, if you don't use any of the bit fields which are reserved for subsequent versions.

The version check is near line 36 of val_OS2.cs, in Validate():
            if (v.PerformTest(T.OS_2_Version))
            {
                if (version == 0 || version == 1 || version == 2 || version == 3 || version == 4 )
                {
                    v.Warning(T.OS_2_Version, W.OS_2_W_Version_old, m_tag, version.ToString());
                }
                else if (version == 5)

Not sure how the "Details" part can says 3, as it should come out of version.ToString() (the 3rd argument of v.Warning()).
If you like to experiment with switching warning to informative, it might be just as simple as changing v.Warning() to v.Info() ; though I suspect it may or may not check that the 2nd argument is part of the W{} enum's and not the I{} enum's. Modifying the two lists of enums is hard, as they are auto-generated and sync'ed with the CHM from the GenerateFValData directory by the "make gendoc" target.

The font's OS/2 table is version 4 for sure, as can see:
https://github.com/behdad/fonttools/blob/master/Lib/fontTools/ttLib/testdata/TestTTF-Regular.ttx#L77
But I'm afraid I don't have the time to debug this issue right now.
Thanks anyway.


Add the message timing and display the sender's name along with every message.

When anyone Sends any message, add the message timing and also display the sender's name along with every message in the Chat.

Hey @swarnarkadas I would like to work on this issue. Can you please assign this issue to me?

@Laxmankohar, We are instructed not to assign issues before the contribution period of JWOC begins which is 15th Feb. So, wait till then.

ok

I would like to work on this issue under JWOC


back-end: Measure products

 EPIC: Products with measure (continuous size)

FE: since sizeId can be null now we need to check validation in form handlers.

@HaGuesto possible related: build-front breaks

 2.0: BE implementation for measure-products

looks good @pylipp. Is there a way that you could check the performance on the statistics queries before and after?

Checked with the test DB (base 1 because it contains the most boxes; however it's just 500) and didn't observe any difference when validating against current master.
I can't run the branch on the current production DB because the branch expects certain new columns (stock.measure_value, stock.display_unit_id, etc). If the newest migrations in dropapp are deployed to prod, I can try again.


Support swift-tool-version: 5.5

gitignore setup
slider value change on main thread
swift-tool-version 5.5 support

LGTM, thanks 😊


chore: update eslint and dependencies then fix revealed errors

Description
Update eslint and dependencies then fix revealed errors

/ok-to-test

/ok-to-test

@KelvinOm Do we have a PR on EE repo for handling these changes? Else the client build will start failing there after sync.


Update pull_request_template.md

What
Describe what the change is solving
It helps to add screenshots if it affects the frontend.
How
Describe the solution
Recommended reading order

x.java
y.python

Pre-merge Checklist
Expand the checklist which is relevant for this PR.
  Connector checklist

[ ] Issue acceptance criteria met
[ ] PR name follows PR naming conventions
[ ] Secrets are annotated with airbyte_secret in output spec
[ ] Unit & integration tests added as appropriate (and are passing)

Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

[ ] /test connector=connectors/<name> command as documented here is passing.

Community members can skip this, Airbyters will run this for you.

[ ] Code reviews completed
[ ] Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
[ ] Documentation updated

[ ] README
[ ] CHANGELOG.md
[ ] Reference docs in the docs/integrations/ directory.

[ ] Build is successful
[ ] Connector version bumped like described here
[ ] New Connector version released on Dockerhub by running the /publish command described here
[ ] No major blockers
[ ] PR merged into master branch
[ ] Follow up tickets have been created
[ ] Associated tickets have been closed & stakeholders notified

  Connector Generator checklist

[ ] Issue acceptance criteria met
[ ] PR name follows PR naming conventions
[ ] If adding a new generator, add it to the list of scaffold modules being tested
[ ] The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
[ ] Documentation which references the generator is updated as needed.

/test connector=source-file


PPO2 exploration of the action space

Hi,
I am trying to set up an optimization problem using PPO2 by using one-step episodes, as was successfully done in this preprint https://arxiv.org/abs/1908.09885 (using tensorforce). The problem I am considering here with stable-baselines is different than that of the paper. Long story short, the goal is to find the optimal position of an object in a 2D space.
I set up a custom environment, and I ask the agent to provide me with a new position at every episode, after what a FEM computation is required to compute the reward. My action space is [0,1]^2, which I then transform into a ring [r_min,r_max]x[theta_min,theta_max]. I should note that I am using SubprocVecEnv with 64 parallel envs, and that I am updating the network after every 64 runs (so if I am not wrong, n_steps=1).
I am monitoring the actions taken by the agent and plotting them in 2D. What I noticed is that the agent spends most of its actions hitting points on the [x,0] and [0,y] lines, as shown in this figure (this is the transformed action space, ie the ring I was talking about earlier) :

I observe the same behavior wether I provide systematically the same initial state in reset or I call self.action_space.sample() to obtain a different initial state at each reset.
My question is : Is that a standard behavior ? I would expect more variability, but I may be wrong.

Hello,

using PPO2 by using one-step episodes

You problem seems more suited for black box optimization (a good start would be CMA-ES).

My action space is [0,1]^2, which I then transform into a ring [r_min,r_max]x[theta_min,theta_max].

to be sure, the agent acts in the first space?

I should note that I am using SubprocVecEnv with 64 parallel envs

Is there a reason of using that much environments?

What I noticed is that the agent spends most of its actions hitting points on the [x,0] and [0,y] lines, as shown in this figure

To sum it up, you agent outputs an action of dimension two that lies in [0, 1] (radius) x [0, 1] (angle) and then you convert it to the unnormalized values?
I think you can find your answer to your question in this thread and in the documentation
In short: because the actions are sampled from a gaussian (initially centered at 0 with std 1),  it will saturate during exploration (by sampling negative values).
So you have two solutions:

make the action space symmetric ([-1, 1])
use an algorithm that can handle properly those limits (like SAC, TD3 or DDPG) (they also required symmetric action spaces but are better at handling limits)

Hello,

using PPO2 by using one-step episodes

You problem seems more suited for black box optimization (a good start would be CMA-ES).

Indeed, but this is a first toy problem to set things up before moving to (much) more degrees of freedom. In general, we are considering problems that could be solved either by formulating it as a control problem, or as an optimization problem. This is why we started to explore one-step episodes.

My action space is [0,1]^2, which I then transform into a ring [r_min,r_max]x[theta_min,theta_max].

to be sure, the agent acts in the first space?

Yes

I should note that I am using SubprocVecEnv with 64 parallel envs

Is there a reason of using that much environments?

The reward is the result of a finite element computation, which can, in general, be computationally expensive, although it is not systematically profitable to run this FEM computation in parallel (small problem, long physical time to compute). Using parallel environments allows me to save a lot of time.

What I noticed is that the agent spends most of its actions hitting points on the [x,0] and [0,y] lines, as shown in this figure

To sum it up, you agent outputs an action of dimension two that lies in [0, 1] (radius) x [0, 1] (angle) and then you convert it to the unnormalized values?

Yes

I think you can find your answer to your question in this thread and in the documentation
In short: because the actions are sampled from a gaussian (initially centered at 0 with std 1), it will saturate during exploration (by sampling negative values).
So you have two solutions:

make the action space symmetric ([-1, 1])
use an algorithm that can handle properly those limits (like SAC, TD3 or DDPG) (they also required symmetric action spaces but are better at handling limits)

Indeed, this is precisely the answer I was looking for. I will go for the first option.
I have another question, but will open a specific issue for it.


Android: New internal Pixel api

Task/Issue URL: https://app.asana.com/0/414730916066338/1198967073193796/f
Tech Design URL:
CC:
Description:
Currently, our Pixel api relies on a network call to send any pixel. This covers most of our usecases when we need to send a Pixel to our backend.
There are some scenarios where this is not enough:

Sending pixels when we are about to restart the app (pressing Fire)
If network fails

This PR introduces a new method in our existing API: enqueuePixel. This method is opt-in, so we can use it in cases where we are afraid about losing pixels and those are important.
enqueuePixel will:

store the pixel in the database, and
try to send the pixel to remote API
if succeeds, remote pixel
if fails, next time another pixel is added or the application comes again to the foreground, try to send it again.

In this iteration, I discarded using a WorkManager to keep it simple and to make it as synchronous as possible (as soon as the pixel is stored in our database, we will try to send it). Making it synchronous will make it easier to test PRs that include any pixel validation step, the reviewer will not need to wait any amount of time to validate if a pixel is sent.
Steps to test this PR:

Fresh install

Test 1:

Go to any part of the code where we use pixel.fire, and replace it for pixel.enqueueFire
Perform a fresh install
Go to the screen where you changed the pixel method call
Peform the action required to enqueue the pixel
ensure Pixel is sent (see logs Pixel sent)
ensure in the database, the pixel has been removed

Test 2:

Turn off data on your emulator or device
Go to the screen where you changed the pixel method call
Peform the action required to enqueue the pixel
ensure Pixel is not sent (we should not see any log saying Pixel sent)
ensure in the database, all unsent triggered pixels are present
Turn on data on your emulator or device
Perform any of the following actions: another action that enqueues a new pixel OR send the app to background and bring it back to foreground OR press fire button
ensure Pixel is sent (see logs Pixel sent)
ensure in the database, the pixel has been removed

Database Migration

Test 1:

Install develop and run the app
Checkout this branch and install it on your device
Ensure migration succeeds

Internal references:
Software Engineering Expectations
Technical Design Template

I went for pendingPixelsDao.pixels(). I liked the idea of being explicit in the class name level, and be more simple on method names. Hope that's ok for you folks @aitorvs @CDRussell


11 :arrow_right: 12 - Disable playback.ReplayStep for windows (#517)

➡ Forward port
Port ign-transport11 to gz-transport12
Follow up of #517, #518
Disables #195
Branch comparison: https://github.com/gazebosim/gz-transport/compare/ign-transport12...ign-transport11
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

can you double check if the failing CI in homebrew is unrelated to this change?

Yes, error is #509, already reported

@azeey @caguero can you help me merge this PR?


[nri-metadata-injection] Metadatainjection job pullsecrets

Is this a new chart
No
What this PR does / why we need it:

Adds image pull secrets to the admissions webhooks jobs

Fixes and updates the docs.

servive corrected to service
imageJob corrected to jobImage as that was what is being used in values and the templates

Related to https://github.com/newrelic/helm-charts/pull/524
Which issue this PR fixes

fixes https://github.com/newrelic/helm-charts/issues/460

Special notes for your reviewer:
Incremented minor version instead of patch since adding new functionality.
Going to update nri-bundle to target this new version in another PR. Was unsure if it would be acceptable to do it in this PR.
Lints, templates and dry run's correctly locally.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [mychartname])

@douglascamata @paologallinaharbur @gsanchezgavier @roobre
got another one for doc fixes and adding pull secrets. after we merge this if it is ok I have a draft ready to update the nri-bundle here https://github.com/newrelic/helm-charts/pull/531


Issue template for bugs

Ask to run command with --traceback and --level=DEBUG and attach output.
Ask to attach config.
Ask to attach dephell inspect self

And say thank you for an issue. Every issue helps us to make dephell better

There is still a way to create the legacy Markdown template

I don't think it's legacy. It's always better to have everything as a file to have contributions, diffs, portability. So, don't worry about it.


Indexer stores a parsed JSON represention of the block, instead of raw file.

Block ingestion takes a long time, in part because the indexer parses the block first, and then stores the parsed file in rocksdb.
RocksDb could simply store the raw json, provided we adjusted our representation of a block in the database.

... but then we would have to access the block using its native representation, which is perhaps less efficient and less useful than our parsed version?
Note that reading a block from disk is expensive, but parsing a read block is not.

I examined both. We add some data like height, network, and state hash. But the contents are otherwise the same.

Related to #1545

Relates to #1520. Closing.


Android: Social Fixes, Insta-Fetch, Bugfixes

Proper fixes for the issues discovered with social features last month.  All social features should now be working as intended with a snappy local UX, full async/offline support, and immediate/intermediate/final state that matches the web UI.  Also added the missing functions for deleting and editing comments and replies.
Fixed the broken no-focus-unreads explainer; added some logging to help us quickly diagnose user confusion about focus mode.
Improved handling of stories with failed original text extraction. Now messages user and switches them back to a mode with content to view.
Implemented insta-fetch for feeds. (#1032)
Various non-critical bug fixes.

Should be ready for a week in Beta and then a week in 10% rollout, at least.

Sweet, just pushed out as 6.1.0b1 to 507 beta testers.

I've noticed one issue with the latest changes.
If I'm in unread only view, I navigate into a feed and mark all read.
When it goes back to the main unread only view the row for the feed I've just marked as read is still visible but with no number next to it.
When I move into another feed/folder then go back it disappears as expected.

I love this behavior, it's how I have it on the web and ios. I believe I asked for it then. You should see the last feed you were on, ideally with an animated fade out. iOS does this for free, so don't bother building it unless it's also free, but it would be nice if the highlight color faded out upon return. Same with story titles.

Also, a user agrees: https://twitter.com/flameeyes/status/895589834533818368

Ah OK. It doesn't fade on Android but just sticks around until the next action that triggers a UI update.

When it goes back to the main unread only view the row for the feed I've just marked as read is still visible but with no number next to it.

Yep, this was requested a very long time ago in #177.  I'd been waiting for a chance to implement it with the correct animation/fade, but upon the realization that that is almost impossible without some massive rewriting, I put in the more basic version.


REGISTER_EMAIL_CONFIRM not correctly reflected on Web

Description
No matter REGISTER_EMAIL_CONFIRM=true or REGISTER_EMAIL_CONFIRM=false is set in app.ini, the  Require Email Confirmation to ... is always × in web Configuration page. Restarting the gitea.service doesn't change the situation.
Also, the space (width) for configuration item names (left part) in the  Configuration page is not enough for displaying the full item name, which is really not good.

Gitea Version
1.20
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Binary (Debian 12, Linux Service, MariaDB)
Database
None

Do you have a mailer service configured? As I haven't been able to confirm this otherwise.

You need a working mail config first to make REGISTER_EMAIL_CONFIRM could be true


Feature Request: Consider a Global Restriction on Silence Duration

Alerts silenced for a lengthy period of time in AlertManager may indicate that the alert is no longer valuable or unduly ignored.
Consider adding a global configuration parameter to Alertmanager that would restrict the maximum duration of a silence.

Could you share more about your intended use case? What would stop someone from just re-creating the same silence over and over again to get around the limit?

Could you share more about your intended use case? What would stop someone from just re-creating the same silence to get around the limit?

Can you tell us more about your intended use case? What would stop someone from just re-creating the same silence to get around the limit?


mkcloud: documentation for lonely nodes and crowbar_register

document setuplonelynodes and crowbar_register steps
clarify the term lonely nodes

+1

+1

:-1: I am just preparing a PR that cleans up the entire documentation

https://github.com/SUSE-Cloud/automation/pull/287 will supersede this PR
287 alreay incorporates the changes done in this PR.


Move source into a subdirectory?

While looking at the source code I noticed that the source module is a top-level Lua module. By that I mean that both the source.lua file and the source directory are right in the /lua/ directory. If another plugin or a users wants to use the source name, then they will be stepping on this plugin's toes. For example, let's say I have a file named ~/.config/nvim/lua/source.lua, which one will this plugin load?
I know some other plugins are already using the source module, but in my opinion it's better to have a small and easy to fix breakage now, than to have a bigger break later down the road. Or am I mistaken on this one?

Yeah I should definitely move that. By the time I started this plugin I didn't have the sense of conflicting names.. I would start working on that. Thanks for the report:)

Done moving, close this now, thanks again!

I think you misunderstood me. I did not mean just the source.lua file, but the entire directory structure.  Moving all your files into one sub-directory means there cannot be a collision unless another plugin is also called completion, and if that happens it's their fault.
Old Vim script plugins could run into the same problem if they used the same names in autoload file names. If my plugin has an autoload/foo.vim and your plugin has an autoload/foo.vim, whose file should be sourced to call foo#bar()?

Oh yep that's actually better. But it should be way easier now cause there will be no backward compatible issue with all the wrapper stuff I create. I'll work on that:)

BTW, note that I placed the source.lua file outside the source directory. It's nicer to write require 'completion.source' than require 'completion.source.source'. This is closer to how you had set up the directory structure originally.


Subscription column name appears as null on Versions section in the publisher

Description:
Column name shows as null in the 'API Subscriptions by Versions' table in Versions section in the publisher
Affected Product Version:
2.1.0-update4
Steps to reproduce:

Run sample-scenario 7
Go to the publisher and click on Sales_promotions_API - 2.0.0 API
Click on Versions tab

Cannot reproduce in latest product pack.


Add support for B3 Propagation

This looks wrong.  Usually the propagation logic is composed with the tracer class via some config option instead of being defined by inheritance of the tracer class.

This looks wrong. Usually the propagation logic is composed with the tracer class via some config option instead of being defined by inheritance of the tracer class.

E.g. https://github.com/jaegertracing/jaeger-client-java/blob/master/jaeger-core/src/main/java/io/jaegertracing/Configuration.java#L455


../src/NodeV8.h:68:5: error: cannot use 'try' with exceptions disabled

Hi,
I'm trying to compile it for Mac OS. When I execute the npm install, the compiler shows me that error:
../src/NodeV8.h:68:5: error: cannot use 'try' with exceptions disabled
Do you have any idea what can be the problem? I was trying to fix it in the binding.gyp file without success.
Thanks,

Hi,
It was a problem of user rights. Just running sudo node-gyp rebuild works!
Thanks,
Rafa


PackageReference without version

How did you reference a package without the version and get them included?
<PackageReference Include="Microsoft.Extensions.Caching.Memory" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />

cc @natemcmaster

This is build magic on our side. We manage the versions of our dependencies are part of a series of build steps.

Is there a way to make this work in Visual Studio? It looks like VS (15.3.5) doesn't like this which makes development of the ASP.NET Core stack pretty clumsy.

@henkmollema you have to run build[cmd|sh] /t:Restore (https://github.com/aspnet/Mvc#building-from-source) from the command line before launching the sln in VS.

I could have sworn I ran that and VS was still very upset with 1000s of build errors and no intellisense. I'll make sure I call build.cmd /t:Restore next time and see if it works. Thanks anyways! 😄

We're working on clarifying some of the steps for working with these projects. We've done some magic for the source build because we have to coordinate a build of 50+ GitHub repos so we have to go a bit beyond the usual stuff.


Update/align a few TLS variable description

Fixes: 5073

Can you add a description for OCIS_HTTP_TLS_ENABLED it is empty atm and must be populated.

Can you add a description for OCIS_HTTP_TLS_ENABLED it is empty atm and must be populated.

It's there:
https://github.com/owncloud/ocis/pull/5106/files#diff-bc4f34bf14cfb981d81d2f12ed8f70c7c34023813282c8a82d4bc54c3938de4bR50
Or did I miss anything?

Or did I miss anything?

No, I am blind 🙈


No compatibility with Forestry 3.6+ < 4.0

Hi there,
I updated to the latest version of NEI Integration today to fix the new Pam Harvest compatibility... But now none of Forestry recipes is showing anymore (Electron Recipes). I also can't update forestry just yet as the .new API is not working with ExtraTrees & ExtraBees mod.
Or is this a bug that doesn't even affect the versions, could this be looked at please?
I am currently using Forestry 3.6.24
Regards,
Beelzaboss

Can confirm. Same issue

Forestry support was removed because 4.0 got its own nei integration. But a lot still uses 3.6 because of binnie mods.
Could the devs please add 3.6 support back in? Even set to false as default in config would be great, so us with 3.6 can enable it.


Fix issue with current path

Small fix to path of css files.
Issue with my version of bower (v1.4.1):

Inside folder select2-bootstrap-theme this create another folder with version select2-bootstrap-theme-0.1.0-beta.3.

Does the same issue happen with select2 on bower? It's strange that this is happening, as that's how we do it for Select2. I wonder if it might have anything to do with it being a beta version?

This also popped up here https://github.com/t0m/select2-bootstrap-css/issues/72.
Just tried again myself (using Bower 1.4.1) and both select2-bootstrap-theme as well as select2 behave like they should. On a sidenote, I've seen a lot of Bower packages doing the same, e.g. Bootstrap – do you have similar issues with other packages, @brunowego?

No, at this moment only with select2-bootstrap-theme.

We can close this commit?


Gaps in mt_events sequence causing subscriptions to be paused

We experienced a problem this morning where unavoidable maintenance on our azure postgres database caused a gap in seq_id values in the mt_events table. This caused the high water mark to never make it above the gap and subscriptions to be paused as a result.

As the image shows there is a gap between 30041 and 30051.
The logs around this time show a connection issue to the postgres database between 06:01:38 and 06:02:36 and then some indication about a gap was detected but when checking the mt_event_progression 6 hours later we found that the HighWaterMark and all of the subscriptions were stuck at 30041. They didn't proceed from 30051 up to the latest sequence id 31382 as expected.
2024-10-23 06:02:38.174 +00:00 [INF] Daemon projection high water detection skipping a gap in event sequence, determined that the 'safe harbor' sequence is at null | { SourceContext: "Marten.Events.Daemon.Coordination.ProjectionCoordinator", MachineName: "aio-quality-eventsubscription-api-7795cf5ffc-7w452" } |

2024-10-23 06:02:38.171 +00:00 [INF] High Water agent is stale after threshold of 3 seconds, skipping gap to events marked after "2024-10-23T06:01:40.2499450+00:00" for database Marten | { SourceContext: "Marten.Events.Daemon.Coordination.ProjectionCoordinator", MachineName: "aio-quality-eventsubscription-api-7795cf5ffc-7w452" } |

2024-10-23 06:02:38.171 +00:00 [INF] High Water agent is stale at 30041 for database Marten | { SourceContext: "Marten.Events.Daemon.Coordination.ProjectionCoordinator", MachineName: "aio-quality-eventsubscription-api-7795cf5ffc-7w452" } |

2024-10-23 06:02:36.683 +00:00 [ERR] Failed while trying to detect high water statistics for database Marten | { SourceContext: "Marten.Events.Daemon.Coordination.ProjectionCoordinator", MachineName: "aio-quality-eventsubscription-api-7795cf5ffc-7w452" } | Npgsql.NpgsqlException (0x80004005): Failed to connect to xxx.xxx.xxx.xxx\n ---> System.Net.Sockets.SocketException (111): Connection refused\n at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)\n at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)\n at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|285_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)\n at Npgsql.TaskTimeoutAndCancellation.ExecuteAsync(Func`2 getTaskFunc, NpgsqlTimeout timeout, CancellationToken cancellationToken)\n at Npgsql.Internal.NpgsqlConnector.ConnectAsync(NpgsqlTimeout timeout, CancellationToken cancellationToken)\n at Npgsql.Internal.NpgsqlConnector.ConnectAsync(NpgsqlTimeout timeout, CancellationToken cancellationToken)\n at Npgsql.Internal.NpgsqlConnector.RawOpen(SslMode sslMode, NpgsqlTimeout timeout, Boolean async, CancellationToken cancellationToken, Boolean isFirstAttempt)\n at Npgsql.Internal.NpgsqlConnector.<Open>g__OpenCore|213_1(NpgsqlConnector conn, SslMode sslMode, NpgsqlTimeout timeout, Boolean async, CancellationToken cancellationToken, Boolean isFirstAttempt)\n at Npgsql.Internal.NpgsqlConnector.Open(NpgsqlTimeout timeout, Boolean async, CancellationToken cancellationToken)\n at Npgsql.PoolingDataSource.OpenNewConnector(NpgsqlConnection conn, NpgsqlTimeout timeout, Boolean async, CancellationToken cancellationToken)\n at Npgsql.PoolingDataSource.<Get>g__RentAsync|34_0(NpgsqlConnection conn, NpgsqlTimeout timeout, Boolean async, CancellationToken cancellationToken)\n at Npgsql.NpgsqlConnection.<Open>g__OpenAsync|42_0(Boolean async, CancellationToken cancellationToken)\n at Marten.Storage.MartenDatabase.SingleQuery`1.ExecuteAsync(CancellationToken cancellation)\n at Marten.Storage.MartenDatabase.SingleQuery`1.ExecuteAsync(CancellationToken cancellation)\n at Polly.ResiliencePipeline.<>c__9`2.<<ExecuteAsync>b__9_0>d.MoveNext()\n--- End of stack trace from previous location ---\n at Polly.Outcome`1.GetResultOrRethrow()\n at Polly.ResiliencePipeline.ExecuteAsync[TResult,TState](Func`3 callback, TState state, CancellationToken cancellationToken)\n at Marten.Events.Daemon.HighWater.HighWaterDetector.loadCurrentStatistics(CancellationToken token)\n at Marten.Events.Daemon.HighWater.HighWaterDetector.Detect(CancellationToken token)\n at Marten.Events.Daemon.HighWater.HighWaterAgent.detectChanges()

To fix this we had to manually set the HighWaterMark to 31382 and all the subscriptions to 30051 and then restart the async daemon. Is it intended that the async daemon should gracefully recover from such gaps in the sequence because it seems inevitable in our case that these will happen?

" Is it intended that the async daemon should gracefully recover from such gaps in the sequence because it seems inevitable in our case that these will happen?"
Yes, but if the app can't connect to postgres -- which it looks like it was unable to do so from your error messages -- there's nothing that Marten could do.
What are you wanting to happen here? I can't say that there's many reports of this behavior. This might be just the 2nd, and in the first case, I know there was a lot of other wacky stuff going on too.

Also, did Marten keep logging connectivity errors, or does it appear that the high water mark detection just stopped in this case (which it most certainly should not ever do so)?

The problem is that even after the connection to postgres has been restored (the maintenance lasts for 1-2 minutes typically), the async daemon does not detect the new high water mark until restarted.

Also, did Marten keep logging connectivity errors, or does it appear that the high water mark detection just stopped in this case (which it most certainly should not ever do so)?

It just seems to stop. There are no log lines after the 06:02:38.174 one posted above.
I just tested locally by stopping postgres running in docker and issuing an ALTER SEQUENCE quality.mt_events_sequence INCREMENT BY 10 and it works as expected. When postgres comes back up the async daemon continues as normal. The difference is in these 2 logs. The first one is from my local test
Daemon projection high water detection skipping a gap in event sequence, determined that the 'safe harbor' sequence is at 973
And the original one from my issue which is running in aks
Daemon projection high water detection skipping a gap in event sequence, determined that the 'safe harbor' sequence is at null
As you can see the difference is 'safe harbor' sequence is null. I would've expected it to detect the safe harbor sequence as 10051 taking the example from above. Do you know what would cause it to be detected as null because that seems to be the problem here?

Also, you might look into the "quick append" option for the event store to avoid having so many gaps in the first place. That might also help.

We are using quick append already. The sequence gap seems to be caused solely by the maintenance (is this a thing?) and not by failed transactions because there are no attempted event writes around this time.

"The sequence gap seems to be caused solely by the maintenance (is this a thing?)" -- yeah, totally see that being an issue if you shut down things hard w/o doing a graceful stop
We've had reports of determined that the 'safe harbor' sequence is at null before. I'll pay attention to that here. To be clear, you were able to stop a database, restart it, and see Marten recover?

Yes, I was able to do that locally and the async daemon picked up from the sequence id after the gap once postgres was back up. I did only try to reproduce that once and it worked as expected and continued processing subscriptions after the gap. I don't know if this has some specific reproduction steps, maybe specific to azure, but I'm still trying to reproduce it in a controlled way.

No recent activity, and no one else has reported this. Might be directly related to Azure maintenance windows

@jeremydmiller Our solution here was to schedule the maintenance in Azure to a specific day of the week/time and then schedule a restart of the async daemon pod a few minutes later. We haven't had any problems with this since, once the async daemon restarts it picks up from the post gap sequence id. Without a restart it was still getting stuck for an unknown reason. Might be helpful to any future users who come across this problem in the future.


[Autocomplete] Fix handling of associated properties in DQL joins

Q
A

Bug fix?
yes

New feature?
no

Issues
Fix #2370

License
MIT

Changes:

The alias generation logic has been improved to correctly handle nested associations and avoid alias collisions.
The code was modified to ensure that the parent entity is correctly accounted for when generating aliases, which helps prevent issues in complex joins with multiple associated entities.
A check was added to verify the existence of a parent property before using it as part of the alias. This prevents logical errors in cases where the parent entity is not directly involved in the join.

This seems very legit: do you think you could add a test or two ?

This seems very legit: do you think you could add a test or two ?

Thank you for the feedback! I’ve already added tests in "Symfony\UX\Autocomplete\Tests\Functional\FieldAutocompleterTest". Let me know if there are fix to add or additional scenarios you'd like me to cover.

Thanks Hugo :)


Lodash dependency vulnerability

I believe concurrently is using Lodash v4.17.20. Could the version of this dependency be updated to the latest version of Lodash,  v4.17.21.
https://nvd.nist.gov/vuln/detail/CVE-2020-28500

#271


Add virtual destructors to several base classes

On Mac OS Mojave (and potentially other platforms), there was a bug
where a lack of virtual destructors would stop make install from
building successfully. This commit adds default virtual destructors to
remedy this problem to several base classes, allowing a destructor to be
called on a pointer to the base class and not produce undefined behavior.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: evankirkiles sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Fixes https://github.com/Azure/azure-storage-cpplite/issues/20


Update postgres to use statefulset?

As described in the following blog post: http://blog.kubernetes.io/2017/02/postgresql-clusters-kubernetes-statefulsets.html

@jmccormick2001 WDYT on contributing on the official chart following your great blog post?

I'd be open to doing that, let me see if I can contribute to this.

cc: @swordbeta @databus23
This is a good idea. Some charts like the stable/consul chart are already using statefulsets. If someone is interested in contributing this would be nice to have.

/remove-lifecycle stale

/remove-lifecycle stale

i can work on this.

seems there is one pending PR from someone on this chart https://github.com/helm/charts/pull/7589

Is it fine if I create another PR separately ?

This PR has nothing to do with StatefulSet, so yes, go on!

Everyone: Just to be clear, would such a change break compatibility with official postgres image? Should this be a new, different chart named for example postgres-ha?

It would break backwards compatibility but there is not much choice. An alternative chart would duplicate work and cause confusion. And eventually, we would want to replace the original postgres chart with the stateful set version putting us right back at this discussion.

The semver on the chart would need to have a major version bump. Ideally, PVCs handling data could be handled gracefully (though this is an untested ideal)

/assign gkarthiks

Beware that https://github.com/helm/charts/pull/8004 is in the process of being merged.

@desaintmartin  I thought no one will pick this issue, since I committed on this sometime back.
Closed the my new PR.
If possible i need a way of assigning the issues to my name. So that no conflicts will be arising. @desaintmartin  or @davidkarlsen can you please help me on that?


Crash with Twilight Forest (1.12.2)

https://pastebin.com/u4WQbPx7

Looks like TF is making the assumption that the class of a biome it has a reference to is analogous to the vanilla forest biome's class, which in this case isn't true. Could fix that on the OTG end by making sure that any biome that inherits from a vanilla biome uses a class that inherits from the vanilla biome's class. Would be a lot of work though and shouldn't really be necessary, it would be better if TF used another way to determine whether the biome it currently has a reference to is really a forest biome. I also wonder why TF needs to cast the biome to a Forest specifically, that should only be necessary if the Forest class exposes members that its superclasses don't. Usually you can make due just refering to biomes as biomes, no need to be more specific, the biome class already exposes all the necessary functions. Will take a look at TF's source code later to see what they're doing.

If you are going to replace instances, you need to maintain hierarchy.  This is not something for TF to fix.

Oh nice same problem tehre.
(Logs)[https://gist.github.com/fmohican/3e84c842b94aa1573e9d9ed77cff5d5d]

Question: Is this being worked on here or there?

https://github.com/TeamTwilight/twilightforest/issues/348

Related to #104, will close this issue and continue there.


Add Tools page to remix app

Adds the Tools page implementation to the remix app
Adjusts the TutorialCard's layout to allow space for 2-line headers
SDKCard and ToolCard can take either an iconSrc or an known iconType (must be one or the other).

Closes #176

I was thinking the same @schpet , it would be nice for all the components to only take srcs. Agree that it's subjective, so I'm good with merging as well!

@schpet @alse you're right - simpler is better, this was just overcomplicating things with no real benefit. I'll have some changes up momentarily!


Fix css using sass

Hi @seppevectera, thanks again for your contribution. After some consideration, I decided to go with webpack. gulp is riddled with security issues and not a good fit for a package that requires extra care when it comes to security. I opened a new PR in #429 Please feel encouraged to review it.


Service account "controller" missing?

Hey, I'm working on getting net-certmanager setup with kourier and knative-serving but I'm running into the following error:
pods "net-certmanager-controller-6f7bc9488c-" is forbidden: error
        looking up service account tools/controller: serviceaccount "controller"
        not found

Am I able to use a non-default namespace for this? Currently I'm deploying things into the tools namespace but can change if that's not compatible with this project. This is my kustomization.yaml:
bases:
  - "https://github.com/knative/operator/releases/download/knative-v1.3.1/operator.yaml"
  - "https://github.com/knative/net-kourier/releases/download/knative-v1.3.0/kourier.yaml"
  - "https://github.com/knative/net-certmanager/releases/download/knative-v1.3.0/release.yaml"
patchesStrategicMerge:
  - overlays/knative-operator-sa.yaml # This just adds a role binding via IRSA for read access to ecr

namespace: tools

The serviceaccount "controller" should be deployed via Knative Serving resources (e.g. acativator, autoscaler, controller, etc).
Are you trying to deploy net-certmanager in the different namespaces from Knative Serving?

In other words, where did you create KnativeServing. The service account should be created in the same namespace and it is better to deploy net-certmanager in the same namespace.

I am closing this as no response for a while but please feel free to re-open.


[Question] @select argument

Hi,
First I wanted to thank you for this great component.
I'm using the latest version of this component 2.2.
I have a question for a specific usecase of mine. I want to be able when I call @selected, to pass an additional argument
<vue-autosuggest
                                    ref="autocomplete"
                                    v-model="autocompleteText[ind]"
                                    :suggestions="suggestions"
                                    :inputProps="inputProps"
                                    :renderSuggestion="renderSuggestion"
                                    :getSuggestionValue="getSuggestionValue"
                                    @input="fetchResults"
                                    @selected="selectSuggestion(ind)"
                                  />

@selected already use 2 arguments as you know :
    selectSuggestion(suggestionItem, suggestionIndex  ){
        ...
    },

Obviously I can display the first 2 arguments succesfully but how can I display my additional argument ?
Thanks for your help and sorry the noob question ;)

Thanks for the kind words 🤗
You can accomplish this by wrapping it in an in-line function:
  @selected="(...args) => selectSuggestion(...args, ind)"

Or
  @selected="(suggestionItem, suggestionIndex) => selectSuggestion(suggestionItem, suggestionIndex, ind)"

thanks a lot !


x/tools/gopls: Use source from GOMODCACHE if available even if the dependant module is vendored

gopls version

Build info
----------
golang.org/x/tools/gopls v0.8.3
<EMAIL_ADDRESS>h1:Mxm94ix8oSARQ6svioO6SxKEYWT/VCP54/448LOHzrk=
<EMAIL_ADDRESS>h1:dtDWrepsVPfW9H/4y7dDgFc2MBUSeJhlaDtK13CxFlU=
<EMAIL_ADDRESS>h1:81/ik6ipDQS2aGcBfIN5dHDB36BwrStyeAQquSYCV4o=
<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
<EMAIL_ADDRESS>h1:qyrTQ++p1afMkO4DPEeLGq/3oTsdlvdH4vqZUBWzUKM=
<EMAIL_ADDRESS>h1:kQgndtyPBW/JIYERgdxfwMYh3AVStj88WQTlNDi2a+o=
<EMAIL_ADDRESS>h1:5KslGYwFpkhGh+Q16bwMP3cOontH8FOep7tGV86Y7SQ=
<EMAIL_ADDRESS>h1:rm+CHSpPEEW2IsXUib1ThaHIjuBVZjxNgSKmBLFfD4c=
<EMAIL_ADDRESS>h1:olpwvP2KacW1ZWvsR7uQhoyTYvKAupfQrRGBFM352Gk=
<EMAIL_ADDRESS>h1:rYiuK/jn6TCxjAq1hQ6MR6pgOeP3A5gIHDxgrQ8Vbys=
<EMAIL_ADDRESS>h1:9dMzk88fnONra7zrEalqkRMGa9jMGf9B5mdzhYVyI28=
<EMAIL_ADDRESS>h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
<EMAIL_ADDRESS>h1:2LdYUZ7CIxnYgskbUZfY7FPggmqnh6shBqfWa8Tn3XU=
<EMAIL_ADDRESS>h1:kTojdZo9AcEYbQYhGuLf/zszYthRdhDNDUi2JKTxas4=
<EMAIL_ADDRESS>h1:tzxjVAj+wSBmDcF6zBB7/myTy3gX9xvi8Tyr28AuQgc=
go: go1.18.2

go env

GO111MODULE=""
GOARCH="amd64"
GOBIN="/Users/frederick.zhang/.go/bin"
GOCACHE="/Users/frederick.zhang/Library/Caches/go-build"
GOENV="/Users/frederick.zhang/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/frederick.zhang/.go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/frederick.zhang/.go"
GOPRIVATE=""
GOPROXY="<redacted>"
GOROOT="/Users/frederick.zhang/.asdf/installs/golang/1.18.2/go"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/Users/frederick.zhang/.asdf/installs/golang/1.18.2/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18.2"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="<redacted>"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/t6/h6qmyp4n1kv19s7pj58k7sy40000gq/T/go-build3478975185=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Vendor a module, which contains for example 3 packages. Only one of them is used in main module initially so only that module's source code is actually vendored
Open a Go file in the main module, try to use something from the other two packages

What did you expect to see?
Auto-completion and auto-import from the two packages that are not currently vendored.
What did you see instead?
No completion. I have to check the package path, import it in some file in main module, go vendor, then gopls will start providing auto-completion and auto-import.
Alternatively I can delete vendor/ temporarily.
Editor and settings

I'm using Neovim with coc.nvim.
{
  "go.goplsPath": "/Users/frederick.zhang/.go/bin/gopls",
  "go.goplsOptions": {
    "local": "<redacted>",
    "staticcheck": true,
    "analyses": {
      "ST1005": false
    }
  }
}

Logs

[Trace - 3:08:38 pm] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///Users/frederick.zhang/<redacted>",
    "version": 8,
    "diagnostics": [
        {
            "range": {
                "start": {
                    "line": 34,
                    "character": 1
                },
                "end": {
                    "line": 34,
                    "character": 7
                }
            },
            "severity": 1,
            "code": "UndeclaredName",
            "codeDescription": {
                "href": "https://pkg.go.dev/golang.org/x/tools/internal/typesinternal?utm_source=gopls#UndeclaredName"
            },
            "source": "compiler",
            "message": "undeclared name: <a currently unused package from a vendored module>"
        }
    ]
}

This hybrid functionality will be difficult for gopls to support, as it integrates with the behavior of go list.
We could theoretically turn off vendoring, but I don't think that's desirable either. Many users will not have the necessary modules in their module cache. We could run go mod vendor for the user, but that also has significant downsides.
The status quo has the advantage of being explicit, and consistent with the Go command.

We just discussed this in our triage meeting and decided that the cost of implementing this feature would not be worth its benefit.
Closing now. Please re-open if you think we have missed something.


Make wasm constraints configurable

Change Description

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Depends on #8223 and EOSIO/eos-vm#144

Can you describe what the behavior is when shrinking a limit after a wasm has been accepted? For example if the initial data max is set to 128KB, my wasm has 96KB worth of data, and then the limit is changed to 64KB.

The intent is that max_pages and max_call_depth are enforced on apply.  The rest are enforced at set_code.

It seems like wasm memory initialization & memory_api need to be checktime'd now.

actually, I wonder if some other intrinsics are abusable at large memory sizes, 256MB, or such.

We need to bump OC's codegen version. I think it's probably possible to keep original code running in this new version by doing things like moving max_linear_memory_pages to the end of the control block but those changes could be done at a later time. At the moment we can just drop all version 0 on startup and start marking new ones version 1.

For example, something like this will run way over a 30ms deadline on EOS VM JIT, and it's only double the current memory size.
(module
 (import "env" "eosio_assert" (func $eosio_assert (param i32) (param i32)))
 (import "env" "memset" (func $memset (param i32) (param i32) (param i32) (result i32)))
 (memory 1024)
 (export "apply" (func $apply))
 (func $apply (param $0 i64) (param $1 i64) (param $2 i64)
   (drop (call $memset (i32.const 0) (i32.const 0xff) (i32.const 67108863)))
   (i32.store offset=67108860 (i32.const 0) (i32.const 0xffffffff))
   (call $eosio_assert (i32.const 1) (i32.const 0))
 )
)

Can't help but wonder if allowing a knob to control memory limits opens pandora's box on new deadline overrun attacks. Is anyone even asking for more memory?

I'm somewhat less concerned about deadline overruns, since this is primarily intended for private and permissioned chains.  These parameters will definitely cause problems if they are set too high on a public chain.

Increasing max_call_depth high enough causes nodeos crashes; increasing max_linear_memory_init or max_pages will cause deadline overruns. Public networks will be eager to bump some limits so we will need to quantify the threshold at which a limit becomes unsupported. Even private networks need guidance as values too high can cause crashes.
And since we're going to have to declare safe limits to use anyways, my potentially unpopular opinion is that we should not offer adjustable limits but rather a simple protocol feature that bumps limits to safe and tested values that we have full confidence don't introduce problems.
We know what limits users are hitting regularly. We know what limits are needlessly too strict. We know the scale of limits large private chain contracts need. I believe we are fully capable to derive limits that safely satisfy both public and private networks for another couple years.
Also, "supporting" academic limits like 4GB of wasm memory or having a max call depth of 1 just damage future optimization techniques for no gain.

Deadline overruns due to max_pages and max_linear_memory_init can be fixed.  I just don't consider fixing them a priority, right now.  There also isn't a hard cutoff for what is safe.  It's not like 9.9 ms is perfectly fine, while 10 ms is completely unacceptable.  It depends on how much slack you're willing to accept.  max_call_depth can be set ridiculously high before it actually crashes nodeos.  Probably much higher than we really want to set it.  It's really limited by how much hardware you're willing to throw at it.
I don't think this will really impact optimization.  It shouldn't be a problem to optimize by assuming the current limits and just wipe the cache whenever they change.

Deadline overruns due to max_pages and max_linear_memory_init can be fixed

I wonder how invasive that gets though. e.g. how well do the db functions behave with a 256MB payload?

There also isn't a hard cutoff for what is safe. It's not like 9.9 ms is perfectly fine, while 10 ms is completely unacceptable

10ms is where we start paying out so indeed seems like a pretty good baseline for what really is completely unacceptable. I hope we are concerned with anything that approaches that.

max_call_depth can be set ridiculously high before it actually crashes nodeos

It will crash in under 5ms. So we're at least going to have to explicitly provide a supported number for this knob to stave off a bug bounty. Regardless, I believe we shouldn't be placing "traps" for the user like this – I could imagine a private chain setting it high because hey, it's private, and then a contract going off the rails and causing a crash.

Probably much higher than we really want to set it

Yeah, so.. exactly my point. Nobody is ever going to care to fiddle with this knob at such extreme highs or lows. But by offering it, now we allow crashes. If we really feel this limit needs to be increased then a protocol feature that bumps it (along with other limits) to 2500 or whatever means we know we didn't introduce any problems.

I don't think this will really impact optimization. It shouldn't be a problem to optimize by assuming the current limits and just wipe the cache whenever they change.

Not all performance damage (like the increased VM usage in OC) can be resolved. Most others probably can with added complexity. And that’s my general point: nobody will be setting call depth to 1, and yet complexity must be added to support those values.

What does it even mean to be safe?  The point at which nodeos crashes is widely variable depending on the hardware it's running on.  Even below the point where it crashes, it will be using way too much memory.  How much is too much?  I don't know.  We can recommend values for public networks based on a guess about the least common denominator, but I don't really believe that will be a sufficient one-size-fits-all solution.


Can anyone verify that swap is disabled?

Kubernetes is not supposed to use swap
https://github.com/kubernetes/kubernetes/issues/53533#issuecomment-334947625
I have an application that is swap sensitive and should not be using swap. Can anyone verify swap is disabled by default on the eks ami?

Basic poking around on the instance indicates it's disabled


SpeakerNet: score = -1 * numpy.mean(dist)

why should we multiply -1 ?

To convert distance into similarity, i suppose.


Reactivate provider DAGs

Description

Since migrating from Creative Commons, we have had very few providers running consistently. We would like to get these DAGs in a consistently operational state so that we are regularly ingesting data.
Providers

Edit: Providers are checked off when they have been reactivated. Failures/errors are tracked in the provider audit in #283

[x] Jamendo
[x] WordPress Photo Directory
[x] Stocksnap
[x] Freesound
[x] Wikimedia commons
[x] Brooklyn Museum
[x] Cleveland Museum
[x] Finnish Museums
[x] Metropolitan Museum
[x] Museum Victoria
[x] NYPL
[x] Phylopic
[x] Raw Pixel
[x] Science Museum
[x] Smithsonian
[x] Staten Museum
[x] Walters
[ ] (DO NOT ENABLE) Europeana
[ ] (DO NOT ENABLE) Flickr

Additional context

This work is currently blocked pending #285
Implementation

[x] 🙋 I would be interested in implementing this feature.

I think we can close this for now - Flickr and Europeana will likely take some non-trivial extra work. Thank you @stacimc for your assistance with this!


Suggestion: change material for curved parts

This is a great tool! I just wondered how hard it would be to implement a material change for curved elements. An idea would be that they'd have the same material as the rings.
Maybe it'd even be possible to change the curved elements' radius a bit?

Hi! Went ahead and added it; toggle the Extrusion under the Rings toggle to use it. Please note that using curved elements basically doubles the vertex count of a pipe. Also, those won't look very good in parts where your curvature is longer then the pipe segment, so you'll probably want to keep the curvature low.
Please let me now if you encounter any problems.

That's really great, thanks a lot!
As for the doubled vertex count, would it be possible to just omit the vertices for the curvature underneath the extruded rings? (I guess it's not that easy.)

Turned out to be an actual one-line fix lol. No extra vertices now!

 Happy to help C:


Add helix editor

you might be right .. now sure how much helix is in terms of vi/vim ... but i think its still a modal editor .. so i adjusted that.

Fixes #81


Add test. Fix bug. Suggest changes

*.lock too unless it's some haskell-specific thing (which?)
Just for info. The file relates to stack.

I just noticed my local checkout of this branch while cleaning up and remembered this was still open... oops
Thanks for the patch! Release coming soon.

I'm not actively working on new features, but I'm maintaining them yes. The textboard is still online too


Make a svelte front-end for setting settings without needing to modify a file

As the title says: take the file, give it a front-end via svelte.
Custom prompts / commands should be something like a dropdown where you can create new things.
Environment variables should be something similar? Or a little table with two columns and a plus button.
booleans should be checkboxes
strings should be text inputs
And there should be some sort of heirarchy...

should support openai base_url and model name configure


V2ray install script outdated and removed

Hi, this is an amazing project but I've found that the official v2ray install script this project is using has been removed by the source. Could you please kindly consider replacing it with the new script (provided by the v2fly project) or changing the source? Thank you very much and good day to you

have not fixed yet
==========================================
开始安装 V2ray !
ERROR: This script has been DISCARDED, please switch to fhs-install-v2ray project.
HOW TO USE: https://github.com/v2fly/fhs-install-v2ray
TO MIGRATE: https://github.com/v2fly/fhs-install-v2ray/wiki/Migrate-from-the-old-script-to-this
./trojan_v2ray_install.sh: line 1474: /etc/v2ray/config.json: No such file or directory
sed: can't read /etc/systemd/system/v2ray.service: No such file or directory
sudo: unable to resolve host shanfeng: Name or service not known
Failed to restart v2ray.service: Unit v2ray.service not found.
sudo: unable to resolve host shanfeng: Name or service not known
Failed to restart caddy.service: Unit caddy.service not found.

Fixed, pls update your script and run

Fixed, pls update your script and run

Hi, thank you so much for updating the script. I have tried it today, however, it has not been successful. I was able to install trojan successfully but never was I able to install v2ray.
You can see here that it just doesn't install. It constantly skips v2ray installation despite it being not installed in the first place. Could you please look at the script for a little and see if this issue could be fixed? Thanks a lot for your work. I am very grateful indeed.

Fixed, pls update your script and run

Hi, thank you so much for updating the script. I have tried it today, however, it has not been successful. I was able to install trojan successfully but never was I able to install v2ray.
You can see here that it just doesn't install. It constantly skips v2ray installation despite it being not installed in the first place. Could you please look at the script for a little and see if this issue could be fixed? Thanks a lot for your work. I am very grateful indeed.

Because you haved installed v2ray.
So the better way you install this script on a new VPS.
Or delete  "/usr/local/bin/v2ray" and  "/usr/bin/v2ray" file , Then Run this script , select 17 to Uninstall trojan and v2ray  . Then Select 15 to install trojan and v2ray


Make Slick CSP compliant

I did a quick search and found this issue: https://github.com/kenwheeler/slick/issues/2399
To cut a long story short. All you need to do is remove the injected style="" and move the injected CSS into the external CSS file.
Would you be willing to update the code and adding some documentation for people. Nevermind, just gonna use JSSOR in the meantime as their one can pass CSP.

That’s interesting I never knew that this violates CSP. The problem is that slick needs to inject inline style because it calculates a lot of things on run-time. Is JSSOR CSP compliant? I would really love to investigate and fix that if it can be done.

@ahmadalfy yes jssor is fully compliant, have been using their code with a full csp policy for a few years now. All that was needed to get tehir code to pass was to remove the inline styles and replace them with class tags to an external css file.

Is JSSOR CSP compliant?

Yes, have been using jssor for a few years with a fully strict csp policy. Three years ago I contacted their support and they gave me instructions how to make their slider fully csp compliant.
You can probably contact them and find out how they done it, because when I spoke to them they gave me more than enough background info on their code.

I'll give a shot at a PR when time allows as our CSP reports are flooded by this, but I though I'd share a few details if someone want to fix this in the meantime.
CSP is not a monolithic thing, but different policies that can be used to restrict what can be done on the page. In that case, the absence of the unsafe-inline policy prevent setting the style attribute directly.
As was identified in #2399, it's caused by the reset of the saved style (that reset is also called when initializing slick which is probably when the CSP violations happen for most). I'm not sure what the best fix would be, but the simplest one would be to call style.clear() instead of setting the attr when originalStyling is empty. This should at least work for the cases where no inline styles were present on the carousel items.

Looks like my brain invented style.clear, this doesn't exist (or more precisely is the clear css prop). This is the equivalent idea:
var style = this.style;
for(var i=style.length-1; i>=0; i--) {
    style.removeProperty(style.item(i));
}


AlertStreamer wont initialize: BaseEventLoop.create_connection() got an unexpected keyword argument 'extra_headers'

Describe the bug
Trying to use the AlertStreamer in the manner described in the docstring results in TypeError:  BaseEventLoop.create_connection() got an unexpected keyword argument 'extra_headers'.
How to reproduce

import asyncio

from tastytrade import Account, AlertStreamer, Session
from tastytrade.order import PlacedOrder

async def main():

    session = Session("prod_user", "prod_pass")

    async with AlertStreamer(session) as streamer:    # <--- This line causes the error
        accounts = Account.get_accounts(session)

        # updates to balances, orders, and positions
        await streamer.subscribe_accounts(accounts)
        # changes in public watchlists
        await streamer.subscribe_public_watchlists()
        # quote alerts configured by the user
        await streamer.subscribe_quote_alerts()

        async for order in streamer.listen(PlacedOrder):
            print(order)

asyncio.run(main())

I have done some minimal debugging and found that the unexpected kwarg extra_headers is set on the websocket connection in lines 224-226 of streamer.py.

This will be fixed in the next release, for now you can downgrade websockets to 13.1. They released breaking changes in 14.1 that are imported under the same names, which causes this error.


(Error): Handle server errors in ErrorPage

Description
:sparkles: (Error): Handle server errors in ErrorPage
Type of change

[x] This change requires a documentation update
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Updated code due to code review changes.


[settings] encode as packed little endian structs

The choice of little-endian was made for the following reasons:

The existing encoding remains unchanged for settings unchanged on little-endian platforms.

Eliminates any code overhead for little-endian platforms.

Resolves #4461

@bukepo @abtink here is a proposal to resolve #4461, let me know what you think of the approach. if you agree, I will clean this up further.

That’s great! I think the TLVs in operational dataset should also be defined as little endian.
:+1:

@jwhui just to make it clear, this PR will not break settings representation in NVM for little-enidan platforms like nRF528xx and over the air upgrade which won't touch persistent data still can be easily done?

That’s great! I think the TLVs in operational dataset should also be defined as little endian.

Operational Datasets are stored using Thread's TLV encoding. For non-volatile storage, we simply treat it as a variable-length binary blob.

@jwhui just to make it clear, this PR will not break settings representation in NVM for little-endian platforms like nRF528xx and over the air upgrade which won't touch persistent data still can be easily done?

@LuDuda yes, this PR should be transparent to existing little-endian platforms. However, big-endian platforms will not be able to restore NetworkInfo, ParentInfo, and ChildInfo.  To be clear, not being able to restore that information is not fatal - it simply means a device needs to reattach with a new Extended Address and Mesh-Local Address.


Flash of empty Category when clicking uncached product in list

Current behavior
In 1.12 when clicking a product in category listing which is not cached (e.g. with saveBandwithOverCache: true or products lazy loaded on scroll), data of current category (getCurrentCategory Getter, filters) vanishes before product page has been loaded leading to a brief moment of layout shift and missing content. Depending on page layout this can be quite irritating and definately was not the case in 1.11.
Expected behavior
Category Content does not vanish when clicking a product in the listing and rendering of product page is complete.
Steps to reproduce the issue

With fresh browser goto https://demo.storefrontcloud.io/women.html
Enable offline mode in browser (to make the effect permanently visible).
Click a product.

Version of Vue Storefront

[x] Vue Storefront 1.12.2
[ ] Vue Storefront Next

Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

I debugged a little and found, that the behaviour is introduced by https://github.com/DivanteLtd/vue-storefront/commit/ad6e9586a54b0c4b5198985b1dceb2fc4058bacb. The getter is updated much earlier than the previously used root state.
Any reason for this particular change @gibkigonzo?

@revlis-x  good point. this is a bug that was overlooked during the tests. Can you please propose a fix?

@revlis-x @pkarw I've added this because I wanted to have always newest category in vuex. Take a look on this diagram:

First is before my change and second is after the change. You can see that when we use rootState.route.params to resolve current category then getCurrentCategory in asyncData is always outdated, because asyncData is triggered before we enter route. Now when getCurrentCategory is outdated then other getters are outdated, for example getAvailableFilters. And that was the point why I added this change.
Scenario:

add red color filter on PLP
go to PDP
refresh page
return to PLP

Before my change in that scenario we will get all products instead of products with red color.

category-next/loadCategoryProducts this method is triggered in asyncData
categoryMappedFilters is undefined because we don't have cached filters (in 3. step page was refreshed)
loadCategoryFilters is triggered to get filters attributes
we want to get searchQuery so we use getters.getCurrentFiltersFrom. Now here is a problem. Because categoryMappedFilters is empty so in getCurrentFiltersFrom we need to use getters.getAvailableFilters which has outdated category...

I thought that using newest category as soon as possible (in asyncData) will resolve this problem. But as you can see when we use getCurrentCategory also to determine how template should look like then some things can be cleared before we want it.
So after all of this I think we have two options:

getCurrentCategory will be one step behind in asyncData as it was before.

  getCurrentCategory: (state, getters, rootState, rootGetters) => {
    return getters.getCategoryByParams(rootState.route.params)
  },

To solve problem in Scenario :point_up: we need to refresh categoryMappedFilters in loadCategoryProducts and it should be ok
    let categoryMappedFilters = getters.getFiltersMap[searchCategory.id]
    if (!categoryMappedFilters && areFiltersInQuery) { // loading all filters only when some filters are currently chosen and category has no available filters yet
      await dispatch('loadCategoryFilters', searchCategory)
      categoryMappedFilters = getters.getFiltersMap[searchCategory.id]
    }

getCurrentCategory will have newest category, but in that case we would need to create separate getters for template
getCurrentCategory => getTemplateCurrentCategory
getAvailableFilters => getTemplateAvailableFilters
getBreadcrumbs => getTemplateBreadcrumbs
names can be different :P

I think that better option is to step back and go to 1. option. That's because we always used getCurrentCategory in template and it may be confusing that there will be different getters for template. And if there will be a need, we can always create getAsyncDataCurrentCategory (or different name) which will always have newest category and is not bonded with other getters.

@gibkigonzo it's hard for me to get into the details here, so it's more up to your decision. Your call, will be cool I'm sure about it :)


tasks: fix project_root when using .config/mise.toml or .mise/config.toml

Fixes #1480

That was quick. Thanks a lot!


question

Which file should I use from the available city lcz downloaded from the global map in w2w?
Thank you

@fipoucat: sorry, I do not understand your question. Could you be more clear / specific?

I downloaded a city the lcz is already generated and in the folder, there is an image named lcz_map.jpg in the figures subfolder and another with .tif but all seem to have 3 bands and wonder which one to use for the different lcz classes.

I also (still) have a hard time following you...
Are you referring to the lcz generator maps (https://lcz-generator.rub.de/submissions) or the global map (https://zenodo.org/record/6364594)?
For the former you can specify the band using the --lcz-band argument as described here (https://github.com/matthiasdemuzere/w2w#important-notes)
The different bands are described in the lcz generator paper (https://doi.org/10.3389/fenvs.2021.637455) or result email. The first band is the raw lcz map, the second one the filtered version and the third one the class probability.
For the latter, the global map you want to crop out your ROI first before running w2w.

Sorry Dakar for the confusion, I am referring to the submissions lcz. This one looks "more accurate" than the one I extracted from the global map. I was facing the band and crs of the image from the submission for Dakar city.

So is this resolved now? Or do you have other questions?

Yes, thank you


Surface error when resource has invalid resource type [#139412087]

This resolves https://github.com/concourse/concourse/issues/915 by displaying an error inside the resource page when the resource has an invalid type.

@davidje13 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@davidje13 Thank you for signing the Contributor License Agreement!

@davidje13 Thank you for signing the Contributor License Agreement!

thanks!


keep original guardCode and actionCode before expansions

keep original guardCode and actionCode before expansions. Will likely want to output into generated code.
Also will allow re-rendering behaviors quickly for different expansions.

Done


pytest test does not complete (bottle repo)

git clone https://github.com/bottlepy/bottle
open the repo as a workspace
you should get prompted to enable/install pytest, accept
run test test_no_slash_prefix
result: test never ends
i've done debug test and confirmed that the test code runs till the end, so it seems to be stuck after that.
output window:
[8/2/2019 1:04:37.487 PM Informational] ---------- Discovery started ----------
[8/2/2019 1:04:38.446 PM Informational] Starting pytest discovery for the bottle workspace. This can take up to 60 seconds.
[8/2/2019 1:04:40.047 PM Informational] ========== Discovery finished: 341 tests found (0:00:02.4731967) ==========
[8/2/2019 1:04:40.101 PM Informational] ---------- Run started ----------
[8/2/2019 1:04:41.715 PM Informational] ============================= test session starts =============================
[8/2/2019 1:04:41.715 PM Informational] platform win32 -- Python 3.7.3, pytest-5.0.1, py-1.8.0, pluggy-0.12.0
[8/2/2019 1:04:41.716 PM Informational] rootdir: C:\Users\huvalo\source\repos\bottle
[8/2/2019 1:04:41.760 PM Informational] collected 1 item
[8/2/2019 1:04:41.790 PM Informational] test\test_mount.py .                                                     [100%]
[8/2/2019 1:04:41.791 PM Informational] ============================== warnings summary ===============================
[8/2/2019 1:04:41.792 PM Informational] bottle.py:72
[8/2/2019 1:04:41.793 PM Informational]   C:\Users\huvalo\source\repos\bottle\bottle.py:72: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
[8/2/2019 1:04:41.794 PM Informational]     import base64, cgi, email.utils, functools, hmac, imp, itertools, mimetypes,\
[8/2/2019 1:04:41.795 PM Informational] test/test_mount.py::TestAppMounting::test_no_slash_prefix
[8/2/2019 1:04:41.795 PM Informational]   C:\Users\huvalo\source\repos\bottle\bottle.py:381: DeprecationWarning: Warning: Use of deprecated feature or API. (Deprecated in Bottle-0.13)
[8/2/2019 1:04:41.797 PM Informational]   Cause: Use of old route syntax.
[8/2/2019 1:04:41.798 PM Informational]   Fix: Use <name> instead of :name in routes.

this is what happens when run from command line:
C:\Users\huvalo\source\repos\bottle>py -m pytest test\test_mount.py
================================================= test session starts =================================================
platform win32 -- Python 3.7.3, pytest-5.0.1, py-1.8.0, pluggy-0.12.0
rootdir: C:\Users\huvalo\source\repos\bottle
collected 11 items

test\test_mount.py ...........                                                                                [100%]

================================================== warnings summary ===================================================
bottle.py:72
  C:\Users\huvalo\source\repos\bottle\bottle.py:72: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    import base64, cgi, email.utils, functools, hmac, imp, itertools, mimetypes,\

test/test_mount.py::TestAppMounting::test_mount
test/test_mount.py::TestAppMounting::test_mount
test/test_mount.py::TestAppMounting::test_mount_cookie
test/test_mount.py::TestAppMounting::test_mount_get_url
test/test_mount.py::TestAppMounting::test_mount_json_bug
test/test_mount.py::TestAppMounting::test_mount_meta
test/test_mount.py::TestAppMounting::test_mount_meta
test/test_mount.py::TestAppMounting::test_mount_no_plugins
test/test_mount.py::TestAppMounting::test_mount_no_plugins
test/test_mount.py::TestAppMounting::test_mount_order_bug581
test/test_mount.py::TestAppMounting::test_mount_order_bug581
test/test_mount.py::TestAppMounting::test_mount_wsgi
test/test_mount.py::TestAppMounting::test_mount_wsgi_ctype_bug
test/test_mount.py::TestAppMounting::test_no_slash_prefix
test/test_mount.py::TestAppMerging::test_merge
test/test_mount.py::TestAppMerging::test_merge
  C:\Users\huvalo\source\repos\bottle\bottle.py:381: DeprecationWarning: Warning: Use of deprecated feature or API. (Deprecated in Bottle-0.13)
  Cause: Use of old route syntax.
  Fix: Use <name> instead of :name in routes.

    for key, mode, conf in self._itertokens(rule):

test/test_mount.py::TestAppMounting::test_mount
test/test_mount.py::TestAppMounting::test_mount_cookie
test/test_mount.py::TestAppMounting::test_mount_get_url
test/test_mount.py::TestAppMounting::test_mount_json_bug
test/test_mount.py::TestAppMounting::test_mount_meta
test/test_mount.py::TestAppMounting::test_mount_no_plugins
test/test_mount.py::TestAppMounting::test_mount_order_bug581
test/test_mount.py::TestAppMounting::test_mount_wsgi
test/test_mount.py::TestAppMounting::test_mount_wsgi_ctype_bug
test/test_mount.py::TestAppMounting::test_no_slash_prefix
  C:\Users\huvalo\source\repos\bottle\bottle.py:436: RuntimeWarning: Route <GET /test/<test>> overwrites a previously defined route
    warnings.warn(msg % (method, rule), RuntimeWarning)

test/test_mount.py::TestAppMounting::test_mount
test/test_mount.py::TestAppMounting::test_mount_meta
test/test_mount.py::TestAppMounting::test_mount_no_plugins
test/test_mount.py::TestAppMounting::test_mount_order_bug581
  C:\Users\huvalo\source\repos\bottle\bottle.py:436: RuntimeWarning: Route <GET /test/test/<test>> overwrites a previously defined route
    warnings.warn(msg % (method, rule), RuntimeWarning)

test/test_mount.py::TestAppMounting::test_mount_cookie
test/test_mount.py::TestAppMounting::test_mount_get_url
test/test_mount.py::TestAppMounting::test_mount_json_bug
test/test_mount.py::TestAppMounting::test_no_slash_prefix
  C:\Users\huvalo\source\repos\bottle\bottle.py:800: DeprecationWarning: Warning: Use of deprecated feature or API. (Deprecated in Bottle-0.13)
  Cause: Prefix must end in '/'. Falling back to WSGI mount.
  Fix: Consider adding an explicit redirect from '/prefix' to '/prefix/' in the parent application.

    return self._mount_app(prefix, app, **options)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======================================= 11 passed, 35 warnings in 0.15 seconds ========================================

I can still reproduce it.
[8/14/2019 2:39:56.262 PM Informational] Store opened in 0.851 sec.
[8/14/2019 2:40:11.570 PM Informational] ---------- Discovery started ----------
[8/14/2019 2:40:19.330 PM Informational] Starting pytest discovery for the bottle workspace. This can take up to 60 seconds.
[8/14/2019 2:40:26.142 PM Informational] ========== Discovery finished: 341 tests found (0:00:14.4909199) ==========
[8/14/2019 2:41:30.093 PM Informational] ---------- Discovery started ----------
[8/14/2019 2:41:31.878 PM Informational] Starting pytest discovery for the bottle workspace. This can take up to 60 seconds.
[8/14/2019 2:41:34.421 PM Informational] ========== Discovery finished: 341 tests found (0:00:04.3135864) ==========
[8/14/2019 2:41:34.453 PM Informational] ---------- Run started ----------
[8/14/2019 2:41:37.180 PM Informational] ============================= test session starts =============================
[8/14/2019 2:41:37.181 PM Informational] platform win32 -- Python 3.7.4, pytest-5.0.1, py-1.8.0, pluggy-0.12.0
[8/14/2019 2:41:37.182 PM Informational] rootdir: C:\Users\huvalo\Source\Repos\bottle
[8/14/2019 2:41:37.234 PM Informational] collected 1 item
[8/14/2019 2:41:37.716 PM Informational] test\test_mount.py .                                                     [100%]
[8/14/2019 2:41:37.720 PM Informational] ============================== warnings summary ===============================
[8/14/2019 2:41:37.751 PM Informational] bottle.py:72
[8/14/2019 2:41:37.822 PM Informational]   C:\Users\huvalo\Source\Repos\bottle\bottle.py:72: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
[8/14/2019 2:41:37.870 PM Informational]     import base64, cgi, email.utils, functools, hmac, imp, itertools, mimetypes,\
[8/14/2019 2:41:37.879 PM Informational] test/test_mount.py::TestAppMounting::test_no_slash_prefix
[8/14/2019 2:41:37.972 PM Informational]   C:\Users\huvalo\Source\Repos\bottle\bottle.py:381: DeprecationWarning: Warning: Use of deprecated feature or API. (Deprecated in Bottle-0.13)
[8/14/2019 2:41:38.117 PM Informational]   Cause: Use of old route syntax.
[8/14/2019 2:41:38.124 PM Informational]   Fix: Use <name> instead of :name in routes.

By the way that test completes normally when using unittest framework.


chore(main): release 0.6.1

:robot: I have created a release beep boop
0.6.1 (2024-11-09)
Bug Fixes

don't treat empty table assignments as arrays by default (#44) (0de0b44)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/nvim-neorocks/toml-edit.lua/releases/tag/v0.6.1 :sunflower:


3.0 release log

We're probably going to run some breaking changes, for the sake of a better API. These changes should get us sub 5kb optimized.

[ ] move choo.view out to require('choo/view') - makes replacing with bel easier and makes https://github.com/yoshuawuyts/choo/issues/3 trivial to implement
[ ] streamline view API (https://github.com/yoshuawuyts/choo/issues/35)
[ ] investigate and implement sagas (https://github.com/yoshuawuyts/choo/issues/34)
[ ] create DOM attachment hooks (https://github.com/yoshuawuyts/choo/issues/1 / https://github.com/callum/morphdom-hooks/issues/5)
[ ] implement logging hooks for action and state (https://github.com/yoshuawuyts/choo/issues/15)
[x] enable browser testing

Please do comment if I've missed anything; I'm not a fan of breaking changes, but if it needs breaking this is the time to speak up. Cheers!

We should probably add
[ ] enable browser testing
To this list :)

@toddself feel free to update the release list as you like; I just happened to create it - anyone with commit rights should be able to do that ^__^


Test for correct restriction arguments in harvester

I realised that a test for the correct spelling of the restriction directions (north, south, etc.) in fatiando.harvester is missing in #314.
Added _test_restriction() which tests for correct arguments. Test is coming soon.
Checklist:

[ ] Make tests for new code (at least 80% coverage)
[x] Create/update docstrings
[x] Include relevant equations and citations in docstrings
[x] Docstrings follow the style conventions
[x] Code follows PEP8 style conventions
[x] Code and docs have been spellchecked
[x] Include new dependencies in doc/install.rst, environment.yml, ci/requirements-conda.txt and ci/requirements-pip.txt.
[x] Documentation builds properly (run cd doc; make locally)
[ ] Changelog entry (leave for last to avoid conflicts)
[x] Firt-time contributor? Add yourself to doc/contributors.rst (leave for last to avoid conflicts)

@cmeessen thanks for implementing this!
I noticed that you're getting and error because restrict is not a list in your tests. I think the best and easiest way around this is to always pass restrict as a list (even if there is only one element). There is no need to enforce this on the code but maybe make it more clear in the docstring parameter description.
Let me know when you're done and I'll get this merged.

@leouieda thank you for your comments. I changed the type of restrict to be a list by default and added the unit tests as well. _test_restriction() now also tests whether the argument is a list and raises a TypeError if not. All of this is also covered in the tests.
Not sure if these rather small changes should go into the changelog as well. If not, this PR is ready to merge.

@leouieda thank you for the review and comments. When I read your comments I remembered you already told me that passing lists by default is dangerous.. I changed the code according to your suggestions. The approach returning an empty list by the function is quite neat.

@cmeessen perfect! Thanks so much for putting in the work! Sorry for the long review process.
My offer of free stickers is still valid. Just send me your address and I'll mail you some 🥇


PortalLight parameters not working

None of the parameters of the portal light seems to work.
https://user-images.githubusercontent.com/10125645/135704586-c108ae19-19ed-44a9-b14b-756d449e6bb0.mp4
Unless I've incorrectly set it up.

Still quite buggy.
Temp parameter doesn't seems to work at all, chaning color param seems to cause some weird behavior that at some point, turns the light black, see clip below. Haven't tested any of the refine, shadows and advanced params yet.
https://user-images.githubusercontent.com/10125645/135938207-80295723-a942-432e-a1c7-5819e4016703.mp4

Try the latest commit.

Color and intensity now work properly 👍
Temperature isn't working, as well as parameters under refine and shadow tabs. Have't tested advanced tab parameters.

Try the latest commit. Was not overriding some parameters, if they were not set to default.


Added missing mouse events.

Also shifted onMouseLeave to the proper alphabetical position.

I have published a new build, 5.1.0, incorporating this PR. Was fully backwards compatible so makes sense to push it out in case you were blocked waiting for it. :-)

Great, thanks! Indeed, that was very helpful.


Add openid support

From<EMAIL_ADDRESS>on January 20, 2014 20:21:48
See https://code.google.com/p/jopenid/
Original issue: http://code.google.com/p/rest-assured/issues/detail?id=302

From<EMAIL_ADDRESS>on January 20, 2014 11:23:48
https://code.google.com/p/openid4java/