new My Apps experience displays blank page in iOS My Apps application

This document  states users can download the My Apps mobile app  to access Azure AD Enterprise apps.
However, I've found that when using the new experience this app will accept login information but then displays only a blank white page with refresh and navigation icons in the upper right.
I've tested on iOS 12.4.7 and 13.5.1 with multiple accounts and since the app was last updated 3 years ago I need to know if the documentation can be updated to reflect this app is no longer supported.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40b408ce-fede-ac0a-c72f-40cc02e92889
Version Independent ID: 11a28662-f373-61ca-aff3-300d2019d2ff
Content: Locate & use apps on the My Apps portal - Azure AD
Content Source: articles/active-directory/user-help/my-apps-portal-end-user-access.md
Service: active-directory
Sub-service: user-help
GitHub Login: @curtand
Microsoft Alias: curtand

@Imbusyworking Thanks for the feedback! We are currently investigating and will update you shortly.

@Imbusyworking I am checking on this issue internally with the product team on this issue and update you once I hear back.

@Imbusyworking I have received update from PG team that the new my apps experience is only supported on the browser and not on the app and they will be updating the documentation on this.

@SaurabhSharma-MSFT  Thank you very much for looking into this!

@Imbusyworking No problem.  We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


documentation: S3C-7048-Osis-getUsage-design

TAD design doc: https://scality.atlassian.net/wiki/spaces/OS/pages/2009366559/OSIS+getUsage+API+design+read+metrics+from+Utapi

@anurag4DSB  FYI, getUsage is called by OSE when this page shows up


Is it possible to rotate continuously in the same direction?

Instead of the current behavior that flips back to first when you click through.
Is there a switch that enables that?

Hi @neongrau
Yes, here it is:
wheel.rotateRound = true;

ah great, thanks alot!


HBASE-23904 Procedure updating meta and Master shutdown are incompati…

…ble: CODE-BUG
Restore behavior from before HBASE-21789 (hbase-2.2.0) where we convert
all exceptions to IOEs, even RuntimeExceptions. Actual fix is this change (in case
obscured by doc and lambda simplification):
 } catch (Throwable e) {

 Throwables.propagateIfPossible(e, IOException.class);

 // Throw if an IOE else wrap in an IOE EVEN IF IT IS a RuntimeException (e.g.

 // a RejectedExecutionException because the hosting exception is shutting down.

 // This is old behavior worth reexamining. Procedures doing merge or split

 // currently don't handle RuntimeExceptions coming up out of meta table edits.

 // Would have to work on this at least. See HBASE-23904.

 Throwables.throwIfInstanceOf(e, IOException.class);

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 11s
branch-2 passed

+1 :green_heart:
compile
1m 24s
branch-2 passed

+1 :green_heart:
checkstyle
1m 43s
branch-2 passed

+1 :green_heart:
shadedjars
4m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  2s
branch-2 passed

+0 :ok:
spotbugs
3m 14s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 26s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 52s
the patch passed

+1 :green_heart:
compile
1m 25s
the patch passed

+1 :green_heart:
javac
1m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 34s
hbase-client: The patch generated 0 new + 51 unchanged - 1 fixed = 51 total (was 52)

-1 :x:
checkstyle
1m  7s
hbase-server: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 36s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
1m  2s
the patch passed

+1 :green_heart:
findbugs
4m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  0s
hbase-client in the patch passed.

+1 :green_heart:
unit
64m 14s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
1m  3s
The patch does not generate ASF License warnings.

127m  4s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1216/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1216

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 06f2e8ab9d6a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1216/out/precommit/personality/provided.sh

git revision
branch-2 / 9bee77bb51

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1216/1/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1216/1/testReport/

Max. process+thread count
7338 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1216/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Merged manually to master and branch-2.


Is it possible to create or validate cert w/o ingress controller

FEATURE REQUEST?:

/kind feature

What happened:
I see that all docs point out that ingress controller is needed , but what if one is basically using aws ELB pointing to service which ends up to serve a pod such as kube-dashboard.
I see there is other validation possible by using DNS validation.
Would like to know what my possibilities are.
Environment:

Kubernetes version (use kubectl version): 1.10 / 1.10
Cloud provider or hardware configuration**: aws

I think the documentation clearly points out that certificates are obtained from issuers, and there are a small number of supported issuers.
The list of those issuers is here, and each one has an associated tutorial right now which, while not perfect, roughly outlines usage.
I do think the docs right now don't highlight an ingress as being required anywhere and do list out those issuers pretty clearly.
What part of the docs made it difficult to figure out whether an ingress is needed or not? Can you point to any place where we should be mentioning the existence of other issuers?

@euank I understand the 'issuer' part but say if I want to use http:(), I can't do so w/o ingress controller.
somedomain.com (AWS route 53) > ELB > Service > K8 Dashboard Pod . There is no way for me to validate the domain authority unless I put ingress controller before the service.. unless I use say Cluster wide and go with dns validation route .. that should work even at *.domain.com level
Was going off this tutorial: https://cert-manager.readthedocs.io/en/latest/tutorials/acme/http-validation.html

The fields ingress and ingressClass in the http01 stanza can be used to control how cert-manager interacts with Ingress resources:

If the ingress field is specified, then an Ingress resource with the same name in the same namespace as the Certificate must already exist and it will be modified only to add the appropriate rules to solve the challenge

Well in 'some' of our instances of pods that have self signed certs, those do not have ingress controller of any kind, most use aws ELB and utilizing Loadbalancer vs ClusterIP. (kind of hackish way, will fix that)
For those instances seems like only viable solution is to go with DNS type of validation like you mentioned.
Or throw nginx ingress controller in and go from there.
In docs it would be beneficial to mention that ingress controller is needed for http:{} to work.  Maybe at the top or cert-manager page
Pre-Requirements

must have ingress controller
FW rules must allow all inbound traffic if thats not possible, one must use dns-01 challenge.

I'll probably go with ClusterIssuer tomorrow with *.example.com and that should cover most of our intranet tools we have.
If you are in charge of those docs, the two pointers would probably be beneficial to some other folks that might stumble upon with similar private network topology on k8s.

Feel free to close ticket, I think I am all set and thanks for clarification.


pairs.txt missing in Dense pipeline

I'm trying to test using this command:
bash run_neuralangelo-colmap_dense.sh ~/data/truck

but I get this error:
---colmap2mvsnet---
Traceback (most recent call last):
  File "/home/ubuntu/Instant-angelo/third_party/Vis-MVSNet/colmap2mvsnet.py", line 354, in <module>
    zs.append(np.asscalar(transformed[2]))
  File "/home/ubuntu/.local/lib/python3.10/site-packages/numpy/__init__.py", line 328, in __getattr__
    raise AttributeError("module {!r} has no attribute "
AttributeError: module 'numpy' has no attribute 'asscalar'. Did you mean: 'isscalar'?
Traceback (most recent call last):
  File "/home/ubuntu/Instant-angelo/third_party/Vis-MVSNet/test.py", line 63, in <module>
    dataset, loader = get_val_loader(
  File "/home/ubuntu/Instant-angelo/third_party/Vis-MVSNet/data/general.py", line 78, in get_val_loader
    dataset = MyDataset(
  File "/home/ubuntu/Instant-angelo/third_party/Vis-MVSNet/data/general.py", line 19, in __init__
    self.pair = load_pair(os.path.join(self.root, f'pair.txt'))
  File "/home/ubuntu/Instant-angelo/third_party/Vis-MVSNet/utils/io_utils.py", line 13, in load_pair
    with open(file) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/ubuntu/data/truck/dense/pair.txt'

It is used in several places, but nobody generates that file. From where should I get it?

pairs.txt is generated when calling the colmap2mvsnet.py file


⚠ Bofrost.de has degraded performance

In 8de169d, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1812 ms

Resolved: Bofrost.de performance has improved in 14cab1c.


Bug? hook_media_update(), $parent->save(), generates EmitMediaEvent for a Node

Steps to reproduce.

Implement hook_media_update()
Fetch parent node $islandora = \Drupal::service('islandora.utils'); $parent = $islandora->getParentNode($media);
Make changes to parent node and save: $parent->save();
Observe the error: "Error generating event: Bundle islandora_object does not exist" (or whatever bundle your parent node is).

Big note: This occurs on #cb52ddd, I need to update to 2.x before confirming it exists there as well, but this will take me a couple of days based on current workload. If anyone is able to do it faster, or knows if EmitEvent/EmitMediaEvent has addressed this issue since then, it would be much appreciated.
Further observations:

It seems to occur in https://github.com/Islandora/islandora/blob/cb52ddd9021131c25674099b67aa0ae5a2067619/src/Plugin/Action/EmitMediaEvent.php#L107 where the $entity is the $parent above. Being a Node object, it can't find the source field name for the bundle.
It feels like the Event is being generated based on the entity being saved and the current route, and the type of event is based on the current route alone, not the type of Entity.
The correct EmitMediaEvent is generated on saving the Media item, but the EmitNodeEvent isn't generated for the $parent.

If anyone knows this part of the system and could point me in the right direction, that would be awesome.
Cheers,
Ant

Hey @antbrown did the following and couldn't reproduce:
<?php

use Drupal\media\MediaInterface;

/**
 * Implements hook_media_update().
 */
function mymodule_media_update(MediaInterface $media) {
  $parent = \Drupal::service('islandora.utils')->getParentNode($media);
  $parent->set('title', 'test');
  $parent->save();
}

My parent node returned from the utils call gets its title updated. Any further information as to what's triggering / a bigger stacktrace?

Hi @jordandukart, thanks for the quick turnaround. I'll try get some more data for you later today. Out of interest, when you tested did you use islandora 2.x or #cb52ddd? Cheers, Ant.

I'm running off of HEAD currently.

Hey @antbrown any progress / updates on this?

Hi @antbrown and @jordandukart,
I got the same error when trying to migrate objects from Islandora 7 to Islandora 8.
After much debugging I noticed that Islandora provides its own ContextManager (Drupal\islandora\IslandoraContextManager) that extends Drupal\context\ContextManager and that the latter has received two bug fixes that the former did not get.
After applying the bug fixes, the error disappears. Apparently some contexts are not evaluated properly resulting in emitting the wrong event(s).
The code changes and issues are described here:
https://git.drupalcode.org/project/context/-/commit/b7e8b7f2295d661dc83513e282df4234c9c390c1
https://git.drupalcode.org/project/context/-/commit/d31cd87b909737abd1beab10e68c62ec29acce35
These changes result in firing less events, but I think only the right events fire now. I will test this change on our development server, but please review and test this as well.
NB: these changes might also solve another bug (that was already solved another way): https://github.com/Islandora/documentation/issues/1848
regards,
Lucas

@lucasvanschaik, would you be willing to issue a pull request with the specific changes?

I have tested some more and noticed that the above fix did not fully solve the problem. I've duck deeper and found another issue and solution.
Both are in the PR: https://github.com/Islandora/islandora/pull/931

Think we may be able to close this with https://github.com/Islandora/islandora/pull/931 and https://github.com/Islandora/islandora/pull/932 being merged.


chore: allow import with any path

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.736%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
8089

Relevant Lines:
9182

💛  - Coveralls


Add .gitconfig support

Not sure if a first class object to represent the .gitconfig file should be provided or if the global config information should be squirreled away inside config.Config.  There is the ~/.gitignore_global file to consider as well.
It seems to me that a first class object and storer interface is the way to go.  These are real physical entities and they should have their counterparts in the config package.

@maguro,
To clarify, you are referring to the system and global git configuration files (i.e. the ones accessed in git config via the --system and --global options).
From git help config:

I think the config package is meant to be somewhat agnostic of what files are used to store the configuration (or even if files are used at all).
Currently there code to pull the --local .git/config file lives in the dotgit package. This is then wrapped up by the storage/filesystem.ConfigStorer implementation.
We probably do want to modify config somehow so that multiple Configs could be composed together (with more specific configs override settings in less specific configs).

I am speaking of the global and system configurations, which are not currently being read.
I did read through the config code.  It seemed to me that it was rife with mixed concerns.  I don't see how to cleanly accommodate, with parity, system and global configuration files without backward incompatible changes.  More specifically, the marshaling code seems to assume that only a local config environment is in place; I hold a poor opinion about classes that have ser/der member functions.
Maybe we could have three internal structs, Local, Global, and System; making them "top-level" structs which would be fields of Config would have a number of advantages.  The go-git code base would still get properties from the parent Config struct and the accessors would effect proper precedence.  Such accessors could properly hunt down global ignores; the impetus for my endeavor.
The troublesome marshaling code would be limited to the local config file.  I have no problem with that since anyone wanting to programmatically modify the global and system configurations could use some out of band mechanism.  If such functionality were desired, things could be done slightly differently.  Using io.Reader and io.Writer may be better than byte[].  Instances of Global and System would be passed in as a clone/open options.  The ser/der bits for Global and System would be separate sets utility functions.
I don't see options for Plain*().  Maybe PlainOpenWith() and PlainInitWith() could be added.  I think that OpenWith() and InitWith() would need to be added as well.

Actually, I'm quite fond of something like:
Open(s storage.Storer, worktree billy.Filesystem, opts ...RepositoryOption)

Then one could make calls such as
r, err := git.Open(s, workgree, WithGlobalConfig(), WithSystemConfig())

Can I get a 👍 from a Spaniard?  :)
Is there anything you all would like to see before I start tinkering with this?

I'm going to start tinkering with this.  Not sure when it will get done so if someone wants to work on this, feel free to ping me.

@maguro sorry we were the last week at Git Merge conference, you approach make sense.
About the Open function maybe we can create a new function call OpenWithOptions(*OpenOptions) since for sure we require more options, like: https://github.com/src-d/go-git/issues/765

To me
r, err := git.Open(s, worktree, WithGlobalConfig(), WithSystemConfig())
seems more elegant.  If you don't want to use options you get the backwards compatible
r, err := git.Open(s, worktree)

What's the consensus on this?

For consistency with other API methods we should probably stick with the OpenOptions approach.

Yep.  I will.

Is there any additional work being done on support the user's global gitconfig? I'm not sure where to even get started on it exactly but if someone could provide some guidance I'd like to take a look at it.

I don't plan on it.  It seems to me that the way go-git is currently architected makes it difficult.  You're welcome to take a stab at it.

Ref #603 : having any globally ignored files cause workTree.Status().IsClean() to report false, when git status --porcelain shows it is actually clean. This is a breadcrumb for similar searches.

I am not sure how to use the Pull request feature.
	w, err := repo.Worktree()
	CheckIfError(err)
	gp, err := gitignore.LoadGlobalPatterns(w.Filesystem)
	CheckIfError(err)
	w.Excludes = append(w.Excludes, gp...)
	sp, err := gitignore.LoadSystemPatterns(w.Filesystem)
	CheckIfError(err)
	w.Excludes = append(w.Excludes, sp...)

	status, err := w.Status()
	CheckIfError(err)
	fmt.Println(status)

	fmt.Println(status.IsClean())

I still get globally ignored files polluting the worktree status:
?? .idea/workspace.xml
?? cmd/generate-tls-cert/.gitignore
?? .idea/misc.xml
?? .idea/modules.xml
?? .idea/toolbox.iml
?? .idea/vcs.xml

false

Workaround gist is here but this is excerpt:
	w, err := repo.Worktree()
	CheckIfError(err)

	cfg, err := parseGitConfig()
	if err != nil {
		fmt.Fprintln(os.Stderr, "Could not read ~/.gitconfig: "+err.Error())
		return
	}

	excludesfile := getExcludesFile(cfg)
	if excludesfile == "" {
		fmt.Fprintln(os.Stderr, "Could not get core.excludesfile from ~/.gitconfig")
		return
	}

	ps, err := parseExcludesFile(excludesfile)
	CheckIfError(err)
	w.Excludes = append(ps, w.Excludes...)

	status, err := w.Status()
	CheckIfError(err)
	fmt.Println(status)

	fmt.Println(status.IsClean())

}

// CheckIfError should be used to naively panics if an error is not nil.
func CheckIfError(err error) {
	if err == nil {
		return
	}

	fmt.Printf("\x1b[31;1m%s\x1b[0m\n", fmt.Sprintf("error: %s", err))
	os.Exit(1)
}

// Info should be used to describe the example commands that are about to run.
func Info(format string, args ...interface{}) {
	fmt.Printf("\x1b[34;1m%s\x1b[0m\n", fmt.Sprintf(format, args...))
}

func parseGitConfig() (*config.Config, error) {
	cfg := config.NewConfig()

	usr, err := user.Current()
	CheckIfError(err)

	b, err := ioutil.ReadFile(usr.HomeDir + "/.gitconfig")
	if err != nil {
		return nil, err
	}

	if err := cfg.Unmarshal(b); err != nil {
		return nil, err
	}

	return cfg, err
}

func getExcludesFile(cfg *config.Config) string {
	for _, sec := range cfg.Raw.Sections {
		if sec.Name == "core" {
			for _, opt := range sec.Options {
				if opt.Key == "excludesfile" {
					return opt.Value
				}
			}
		}
	}
	return ""
}

func parseExcludesFile(excludesfile string) ([]gitignore.Pattern, error) {
	excludesfile, err := expandTilde(excludesfile)
	if err != nil {
		return nil, err
	}

	data, err := ioutil.ReadFile(excludesfile)
	if err != nil {
		return nil, err
	}

	var ps []gitignore.Pattern
	for _, s := range strings.Split(string(data), "\n") {
		if !strings.HasPrefix(s, "#") && len(strings.TrimSpace(s)) > 0 {
			ps = append(ps, gitignore.ParsePattern(s, nil))
		}
	}

	return ps, nil
}

// "~/.gitignore" -> "/home/tyru/.gitignore"
func expandTilde(path string) (string, error) {
	if !strings.HasPrefix(path, "~") {
		return path, nil
	}
	var paths []string
	u, err := user.Current()
	if err != nil {
		return "", err
	}
	for _, p := range strings.Split(path, string(filepath.Separator)) {
		if p == "~" {
			paths = append(paths, u.HomeDir)
		} else {
			paths = append(paths, p)
		}
	}
	return "/" + filepath.Join(paths...), nil
}


Allow Job.Service to access the underlying Toil Job (resolves #1191)

Changes the Job.Service start and stop methods to pass job instead of fileStore, which allows Job.Service instances to register defer methods, etc. To do this, we also modify ServiceJob.run to set self.fileStore within the service job, which was previously not exposed.

@hannes-ucsc tests are passing, ping for a review. If it looks good to you, I can squash. We need this for https://github.com/BD2KGenomics/toil-lib/pull/46 downstream.

I think it should be pretty easy to make sure that every job has .fileStore but if you don't want to do this as part of this PR, could you create a ticket?

Agreed. It is more of a bandwidth issue, unfortunately. I have a deadline next Thursday and thus don't have time for non-critical path issues. Since this is blocking @almussel via the upstream PR in toil-lib, I want to get this in. I've just squashed and rebased.

Opened https://github.com/BD2KGenomics/toil/issues/1224, will follow up later.

Jenkins, test this please.

Jenkins, test this please.

Can I get a merge?

The prospects of a linear history are starting to grow on me. If only I could get Jenkins to build a rebase instead of a merge. I do like the fact that the commit that's built by the PR is identical to the one that lands on master.


displaying PRO names on PomBase pages.

Historically we have used
name: transcription factor sre2, Sre2P form (Schizosaccharomyces pombe)
bu I noticed that there is a "EXACT PRO-short-label"
synonym: "Spom-sre2/Sre2N" EXACT PRO-short-label [PRO:DAN]
Can we use this for display? Ideally the part after the "/"
Once I have found out  if this is consistent:
https://sourceforge.net/p/pro-obo/term-requests/113/

Darren updated the linked ticket  to say  we should be able to use the short name after the "/"
examples for texting:
http://www.pombase.org/spombe/result/SPBC16D10.09#go-biological_process
active form PR:000044777
would be displayed as
active form MonoUbiq+

possible snag: histones, especially modified ones. Not all have "/" in the synonym, and for ones that do, often the bit after the / isn't specific enough, e.g.
id: PR:000027596
name: histone H3.3 (Schizosaccharomyces pombe)
synonym: "Spom-hht3" EXACT PRO-short-label [PRO:DNx]
id: PR:000027602
name: histone H3.3, initiator methionine removed phosphorylated 1 (Schizosaccharomyces pombe)
synonym: "H3-pT3" RELATED []
synonym: "Spom-hht3/InitMet-/Phos:1" EXACT PRO-short-label [PRO:DAN]

bummer, well-spotted.
after first "/"?
We can start with the full string anyway and then see if we can trim....

If we do this
https://github.com/pombase/website/issues/67
this is also sorted


Pre-generated Leaves Incompatible

Hello, I built a very large modpack that strives to be vanilla as possible, and I am using the map named Grand Roost. It seems that either a mod or the map itself has made the vanilla leaves present in the pre-generated section of the world not detectable by the tree chop mod. I was able to work around this by turning off the "trees require leaves" setting, but that will introduce minor annoyances while building.
I can provide any necessary log files and I can even do some on the ground testing if desired, I haven't tested naturally generating trees yet. I have not added any mods that alter leaves or trees in any way but visuals and terrain generation (Cliffs and Trees, etc.)
The version is 1.21.1 (If there is a strict version requirement I spoofed it, but I do not remember needing to do that for this mod). The map was made in 1.20 I believe.
As a side note, Jade displays the total number of chops required, but it does not increment correctly while chopping and the log does not get thinner, is this a known incompatibility with a particular mod? Because if it is not, then that's another issue. Weirdly, after a certain number of chops (haven't counted, but I estimate between 5-10?) the block above the one that is being chopped converts into an "in progress chopping log" of the same thickness, for a really large tree I believe it even did it a third time. I suspect this has something to do with a mod and not the world itself. I can post pictures if desired.

the map itself has made the vanilla leaves present in the pre-generated section of the world not detectable by the tree chop mod

Leaves placed by players have a "persistent" flag set, and treechop ignores persistent leaves when "trees require leaves" is enabled. It sounds like the map creators placed persistent leaves instead of natural ones. I don't think there's any reliable way to get around this without creating more bugs. Ideally, map creators should place non-persistent leaves on their trees.
Toggling "trees require leaves" is annoying, but to make it less annoying I could add an option to enable/disable the option while sneaking.

Jade displays the total number of chops required, but it does not increment correctly while chopping

I'll look into this

after a certain number of chops (haven't counted, but I estimate between 5-10?) the block above the one that is being chopped converts into an "in progress chopping log" of the same thickness...

This is actually normal behavior. Each block can only hold 7 chops, so after 7 chops they start to spill to connected log blocks. I admit it's ugly. I'll think about how to make it more intuitive/visually responsive

Ahh, no worries! To be honest I do not see the benefit of a toggle trees require leaves option for my situation but more power to you! I think the 'annoyance' was not well conveyed, so I will clarify: your mod is awesome and works great, but the persistent leaves are a pain to remove manually (we have resorted to fire). The mapmaker even used fences for the trees, which would still remain regardless! While testing, I added fences to the list of choppables hoping that would fix it and forgot to remove it later when I realized it was most likely the leaves; imagine the confusion on my partner's face when their new fence was transformed into a block of wood through pitiful magic.
As for the connected log blocks, I actually like it! But that behavior in conjunction with the logs not changing size and the chop number not incrementing was just worrying. If it was unintentional, I thought it could give you a lead. Once again, great job so far! I've used many tree chopping mods throughout my many years of modded minecraft and I think I like this one the most, it's simple, unobtrusive, very vanilla, configurable, has a GUI, what more could you want?!
 Would this not fix my issue entirely? I will try with this setting false and with require leaves on. I thought that was weird, the persistent flag/block state is literally only for leaves, I have not programmed in this space, so I didn't know if checking flag/block state was significantly harder/buggier than tags which seem easy from an outside perspective. Still confused as to why the logs do not shrink but alas.
#Non-decayable leaves are ignored when detecting leaves
ignorePersistentLeaves = true  -> ignorePersistentLeaves = false

This mostly fixed my issue! I still have to have "trees require leaves off" but when breaking the trees it gets most of the leaves! I am not sure why it misses some (leaf seeking distance is default at 7), perhaps its using the log seeking protocol instead of the leaf seeking one? I understand now where bugs can find their way in. There is already the capability to detect persistent leaves and it treats them as if they were logs it seems, is it really not possible to add persistent leaves to the list of leaf-likes? If it is possible what would be the downsides? The pros may outweight the cons for some and an option to toggle would be nice.
I added a video to help elucidate the log counting error, bug hunting is hard work, I hope this helps. (Sorry for the compression, had to hit 10 MB)
https://github.com/user-attachments/assets/6099984f-2868-4d0d-a071-9c567ef478ed

Ahhh yes, I forgot about the persistent leaves setting!

This mostly fixed my issue! I still have to have "trees require leaves off"

Oops! That "trees require leaves" should behave the same consistent with or without ignorePersistentLeaves. I'll look into the interaction between those two.

I am not sure why it misses some (leaf seeking distance is default at 7), perhaps its using the log seeking protocol instead of the leaf seeking one?

The detection method does change with ignorePersistentLeaves = false because persistent leaves blocks don't store information about what tree they're connected to. So yeah, it ends up using a similar method to log detection, but 1) it only looks for leaves blocks and 2) it doesn't look diagonally for neighbors (mostly for performance reasons), which can definitely lead to floating leaves like you're seeing.
You could play with the config settings under compatibility.trees.problematicLeavesTrees. When you chop a block in that logs list, treechop will use a slower but more liberal search method for finding leaves, which (if I remember correctly) ignores persistent leaves and searches for diagonal neighbors.
Even if you don't have performance issues, there are usually gonna be some unintended consequences when stretching the detection rules, but it can help.

is it really not possible to add persistent leaves to the list of leaf-likes

It's not currently possible for treechop to do that because Minecraft treats "blocks" and "block states" differently. Persistent and non-persistent leaves are different "states" of the same block, but block tags don't differentiate between block states. But, I think I might be able to generalize the treechop block config logic to specify block states as well as blocks and block tags. No promises though, there are some extra complications with block states. I don't think there'd be any technical downsides to it.
Thanks for the video! Yeah, that's no good! Might be a compatibility issue, could you send your latest.log file so I can see your mods list? Or point me to a modpack if you're using one


Missing # from string interpolation

Coverage remained the same at 100.0% when pulling 794be13a391d6c92be28bace2293b69e950726e6 on mydrive:ownership-typo into 5208d8602464cd58515079fa6e53b019d487eb24 on johnbellone:master.


Add ability to customize testsuite.name

It would be great to be able to fully customize testsuite.name. The test parser I'm using makes it very prominent, so I'd like the ability to set it to something more descriptive.
Proposed solution:
Update name to check for a RSPEC_TESTSUITE_NAME environment variable and default to the current value:
https://github.com/sj26/rspec_junit_formatter/blob/3738c28ed77877a14edf1fda429243e188797a64/lib/rspec_junit_formatter.rb#L19
TEST_ENV_NUMBER could either be ignored in name, or it could be appended to RSPEC_TESTSUITE_NAME. I'm good either way.

Thinking about it more, I'd prefer if TEST_ENV_NUMBER was ignored so tests get consistent descriptions.
I'd be happy to send a PR if you're open to it.

Hi @tbpg! This is a nice suggestion, but I'm hesitant to add too many knobs and dials to this formatter given rspec doesn't really provide an official way to configure such formatters. Otherwise we'll start heading toward environment variable soup. The $TEST_ENV_NUMBER was a special case which snuck in early because it was supplied in many environments already, and was not invented for the formatter.
I'd prefer if you were able to post-process the output to prepare it for presentation in your particular tool or interface, something like:
# script/post-process-junit
#!/usr/bin/env ruby
require "nokogiri"
document = Nokogiri::XML.parse(File.read("tmp/rspec.xml"))
document.at_xpath("testsuite")["name"] = "My Lovely Test Suite"
File.write("tmp/rspec.xml", document.to_xml)

Would that work?

That definitely makes sense. Thank you for the workaround script! We can make that work.


Breakpoints View Panel is Missing with no clear way to restore it

Visual Studio Code Debugger Breakpoints View is missing with no clear way to restore it.

VSCode Version: 1.48.0-insider
Commit: 5e5fa3edde19d38ac512d65ccefe2a12ecab025a
Date: 2020-07-16T13:10:40.625Z
Electron: 8.3.3
Chrome: 80.0.3987.165
Node.js: 12.13.0
V8: 8.0.426.27-electron.0
OS: Darwin x64 19.5.0

OS Version: macOS Catalina v10.15.5 (19F101)

Language being debugged: TypeScript / JavaScript

Steps to Reproduce: UNKNOWN

Does this issue occur when all extensions are disabled?: YES

If you check that Views menu when you aren't debugging, does the Breakpoints entry appear?

@gjsjohnmurray, Breakpoints View does not appear regardless of debugging mode or not. I have trued every mode, context, and setting I can think of.
I've also posted on the StackOverflow, but no viable solutions yet.

@gjsjohnmurray, yes -- kind of.
The issue was the Breakpoints View was under its own icon in the Sidebar which is not automatically selected during debugging sessions, making it not obvious. To fix this:
SOLUTION:

CMD+SHIFT+P to bring up the Show Command Palette
Enter and run "Focus on Breakpoints View"
Right-Click Breakpoints header, and choose "Reset Location"

Thanks to everybody, and various forums/resources to figure this out!!

This is a general problem with views that are dragged out of their regular "home".
This break some assumptions, e.g.:

the debug viewlets badge shows the sessions, but when activating the viewlet, it does not show any sessions because they live in another viewlet.
when hitting a breakpoint, the debug viewlet is activated but it does not show anything useful

See here:

Either we forbid dragging out of specific views, or we will have to become smarter in finding the correct viewlet for a given view.
/cc @misolori

The infrastructure should all be there for this to happen more smoothly.

We may want some new icons for each debug view instead of only relying on the debug viewlet icon.

@sandy081 and just recently @joaomoreno for scm, did work to make the badging tied to the view instead of the container. I assume debug just needs to adopt this behavior.

@sbatten thanks for this info.
We will update VS Code debug accordingly.

Isn't this somewhat a duplicate of https://github.com/microsoft/vscode/issues/101016
But yes on top of this there are things we could improve on the debug side.

@isidorn yes, the original issue is about restoring a view and that can be considered a duplicate of #101016.
But the other issues of moving views to other containers are equally important.
If users have deliberately moved a view somewhere else, they expect them to work there too.
So I suggest to close this as a duplicate and create a new issue for the necessary tasks that we have to do for debug:

We may want some new icons for each debug view instead of only relying on the debug viewlet icon.
badging must be done for the correct container
we have to activate the correct debug viewlet when a breakpoint is hit or a debug sessions has started.

@weinand makes sense. Created this one https://github.com/microsoft/vscode/issues/103414
And closing this one


Cleaning up class variables after specs

Some specs were setting class variables values and not cleaning them up making specs break depending on the order of execution.
I thought of creating a Sprockets::Helpers.reset_config method or something like that, but since it's something mostly for tests, I think it's better to keep it in the specs only.
Also, the first commit, is about a spec who was comparing two class variables which were initialized as nil, so depending on their values it could return either nil, true or false. I forced them to return only true or false.

Thanks!


GCP: Allow bootstrap on private address

This is a follow-up to #203 and #204 to allow bootstrapping on the private address on Google.

👍  lgtm


HowTo - Add a Workflow defined by your manager to the model?

Hi,
can you show a quick example howto add the workflow definition created by your tool to the the model using the workflow?
Thanks Philipp

Hi @philippfrenzel,
Sure.
App Config
return [
    'components' => [
        'workflowSource' => [
            'class' => 'cornernote\workflow\manager\components\WorkflowDbSource',
            //'definitionCache' => YII_ENV_PROD ? 'cache' : null,
        ],
    ],
];

Post Model
class Post extends \yii\db\ActiveRecord
{
    public function behaviors()
    {
        return [
            [
                'class' => \raoul2000\workflow\base\SimpleWorkflowBehavior::className(),
                'defaultWorkflowId' => 'post',
                'propagateErrorsToModel' => true,
            ],
        ];
    }
}

I think that's all you need.
I also added this to the README, let me know if there is anything missing or it still doesn't work.


deps: upgrading protobuf to 3.19.2

To see any checks would break.

All checks passed.
@Neenu1995 Feel free to merge this.


Implement generic device types

Implementation of the first generic device type (generic.coffee) which will replace the edge device type and be the default option when creating a dependent application

It's been so long since I've touched the device type stuff that I don't know for sure what good generic values would be - I'd recommend Eugene and the device team as likely being the best reviewers, and Cameron can comment on builder related usage

Can one of the admins verify this patch?

whitelist

@resin-jenkins retest this please

@resin-jenkins retest this please

@resin-jenkins retest this please


Move code from Agrobook.Kml projects to the single Agrobook.Core

This will help keep the code base simpler (fewer projects reduces complexity and boost build speed)

The project management was redesigned to be more simpler, using simple DDD layer/projects structure


Coverage report in readme

Closes #30
Changes
Changed the ci workflow to use the py-cov-action/python-coverage-comment-action to create a coverage badge and report to display in the readme.
To do this, I also had to add a .coveragerc file to store a configuration option for pytest-cov.
Also I took the liberty to upgrade actions/setup-python from version 3 to version 5 :)

I am not sure we even need setup-python since we are using poetry for packaging. You can confirm that and remove it if not require.

I am not sure we even need setup-python since we are using poetry for packaging. You can confirm that and remove it if not require.

Nevermind. It is in github actions. I thought we had that in as a requirement.

I am not sure we even need setup-python since we are using poetry for packaging. You can confirm that and remove it if not require.

We do because you need to have python installed for poetry to run xd


Special characters broken when output opened by Excel

When saving the output to a .csv file and importing it into Excel, special character, e.g. Japanese characters break.

I assumed Excel didn't like the lack of a BOM, but adding that doesn't help either.


Link to image for violin plot

Improves consistency with other plots on top of being generally useful.

Thanks again!


Add AddBrokers function

Close #204
@mhowlett
Integation tests result here: https://travis-ci.org/treziac/confluent-kafka-dotnet/jobs/237930661

this is ready to merge, except I want to clarify my two questions in the integration test first.


update istio to 1.6.0

How to categorize this PR?
/area control-plane
/kind enhancement
/priority normal
What this PR does / why we need it:
Updates istio to 1.6.0
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Istio is updated to `1.6.0` and `status-port` of ingress gateway is changed to `15021`.

Fixed schema imports - have another look @rfranzke


3 tools not being installed in Mac M1

ERROR:-
[] Massdns			[NO]
[] jq				[NO]
[*] ppfuzz			[NO]
Try running the installer script again ./install.sh
If it fails for any reason try to install manually the tools missed
Finally remember to set the $tools variable at the start of this script
If nothing works and the world is gonna end you can always ping me :D
Tools check finished
I can't install these tools in Mac M1
I tried installing ppfuzz and this error occurred
sudo cargo install ppfuzz
Updating crates.io index
Installing ppfuzz v1.0.1
Compiling proc-macro2 v1.0.51
Compiling quote v1.0.23
Compiling unicode-ident v1.0.6
Compiling syn v1.0.107
Compiling autocfg v1.1.0
Compiling libc v0.2.139
Compiling version_check v0.9.4
Compiling cfg-if v1.0.0
Compiling memchr v2.5.0
Compiling futures-core v0.3.26
Compiling pin-project-lite v0.2.9
Compiling futures-io v0.3.26
Compiling slab v0.4.7
Compiling value-bag v1.0.0-alpha.9
Compiling crossbeam-utils v0.8.14
Compiling log v0.4.17
Compiling waker-fn v1.1.0
Compiling parking v2.0.0
Compiling event-listener v2.5.3
Compiling typenum v1.16.0
Compiling fastrand v1.9.0
Compiling concurrent-queue v2.1.0
Compiling generic-array v0.14.6
Compiling futures-lite v1.12.0
Compiling polling v2.5.2
Compiling itoa v1.0.5
Compiling serde_derive v1.0.152
Compiling async-io v1.12.0
Compiling serde v1.0.152
Compiling futures-channel v0.3.26
Compiling tinyvec_macros v0.1.1
Compiling futures-task v0.3.26
Compiling tinyvec v1.6.0
Compiling async-lock v2.6.0
Compiling getrandom v0.2.8
Compiling socket2 v0.4.7
Compiling signal-hook v0.3.15
Compiling once_cell v1.17.1
Compiling futures-util v0.3.26
Compiling pin-utils v0.1.0
Compiling serde_json v1.0.93
Compiling async-task v4.3.0
Compiling futures-sink v0.3.26
Compiling unicode-normalization v0.1.22
Compiling block-buffer v0.10.3
Compiling crypto-common v0.1.6
Compiling rand_core v0.6.4
Compiling async-channel v1.8.0
Compiling signal-hook-registry v1.4.1
Compiling async-process v1.6.0
Compiling percent-encoding v2.2.0
Compiling ryu v1.0.12
Compiling thiserror v1.0.38
Compiling ppv-lite86 v0.2.17
Compiling unicode-bidi v0.3.10
Compiling httparse v1.8.0
Compiling atomic-waker v1.1.0
Compiling idna v0.3.0
Compiling blocking v1.3.0
Compiling rand_chacha v0.3.1
Compiling form_urlencoded v1.1.0
Compiling digest v0.10.6
Compiling async-executor v1.5.0
Compiling aho-corasick v0.7.20
Compiling ctor v0.1.26
Compiling futures-macro v0.3.26
Compiling thiserror-impl v1.0.38
Compiling cpufeatures v0.2.5
Compiling fnv v1.0.7
Compiling either v1.8.1
Compiling regex-syntax v0.6.28
Compiling bytes v1.4.0
Compiling kv-log-macro v1.0.7
Compiling http v0.2.8
Compiling regex v1.7.1
Compiling async-global-executor v2.3.1
Compiling sha-1 v0.10.1
Compiling async-attributes v1.1.2
Compiling url v2.3.1
Compiling rand v0.8.5
Compiling indexmap v1.9.2
Compiling byteorder v1.4.3
Compiling heck v0.4.1
Compiling base64 v0.13.1
Compiling utf-8 v0.7.6
Compiling async-std v1.12.0
Compiling tungstenite v0.17.3
Compiling futures-executor v0.3.26
Compiling atty v0.2.14
Compiling linked-hash-map v0.5.6
Compiling hashbrown v0.12.3
Compiling os_str_bytes v6.4.1
Compiling clap_lex v0.2.4
Compiling yaml-rust v0.4.5
Compiling chromiumoxide_types v0.3.5
Compiling chromiumoxide_pdl v0.3.5
Compiling futures v0.3.26
Compiling which v4.4.0
Compiling chromiumoxide_cdp v0.3.5
Compiling async-tungstenite v0.17.2
Compiling strsim v0.10.0
Compiling termcolor v1.2.0
Compiling lazy_static v1.4.0
Compiling bitflags v1.3.2
Compiling textwrap v0.16.0
Compiling futures-timer v3.0.2
Compiling clap v3.2.23
Compiling colored v2.0.0
Compiling chromiumoxide v0.3.5
Compiling ppfuzz v1.0.1
error[E0432]: unresolved imports clap::crate_authors, clap::crate_description, clap::crate_name, clap::crate_version
--> /Users/aviralsrivastava/.cargo/registry/src/github.com-1ecc6299db9ec823/ppfuzz-1.0.1/src/parser.rs:5:3
|
5 |         crate_authors,
|         ^^^^^^^^^^^^^ no crate_authors in the root
6 |         crate_description,
|         ^^^^^^^^^^^^^^^^^ no crate_description in the root
7 |         crate_name,
|         ^^^^^^^^^^ no crate_name in the root
8 |         crate_version,
|         ^^^^^^^^^^^^^ no crate_version in the root
error: cannot determine resolution for the macro crate_name
--> /Users/aviralsrivastava/.cargo/registry/src/github.com-1ecc6299db9ec823/ppfuzz-1.0.1/src/parser.rs:30:4
|
30 |             crate_name!(), "FILE", "[OPTIONS]"
|             ^^^^^^^^^^
|
= note: import resolution is stuck, try simplifying macro imports
error: cannot determine resolution for the macro crate_authors
--> /Users/aviralsrivastava/.cargo/registry/src/github.com-1ecc6299db9ec823/ppfuzz-1.0.1/src/parser.rs:33:12
|
33 |             .author(crate_authors!())
|                     ^^^^^^^^^^^^^
|
= note: import resolution is stuck, try simplifying macro imports
error: cannot determine resolution for the macro crate_description
--> /Users/aviralsrivastava/.cargo/registry/src/github.com-1ecc6299db9ec823/ppfuzz-1.0.1/src/parser.rs:34:11
|
34 |             .about(crate_description!())
|                    ^^^^^^^^^^^^^^^^^
|
= note: import resolution is stuck, try simplifying macro imports
error: cannot determine resolution for the macro crate_name
--> /Users/aviralsrivastava/.cargo/registry/src/github.com-1ecc6299db9ec823/ppfuzz-1.0.1/src/parser.rs:35:10
|
35 |             .name(crate_name!())
|                   ^^^^^^^^^^
|
= note: import resolution is stuck, try simplifying macro imports
error: cannot determine resolution for the macro crate_version
--> /Users/aviralsrivastava/.cargo/registry/src/github.com-1ecc6299db9ec823/ppfuzz-1.0.1/src/parser.rs:36:13
|
36 |             .version(crate_version!())
|                      ^^^^^^^^^^^^^
|
= note: import resolution is stuck, try simplifying macro imports
error[E0308]: mismatched types
--> /Users/aviralsrivastava/.cargo/registry/src/github.com-1ecc6299db9ec823/ppfuzz-1.0.1/src/parser.rs:32:23
|
32 |         let app = App::from(yaml)
|                   --------- ^^^^ expected struct App, found &yaml_rust::yaml::Yaml
|                   |
|                   arguments to this function are incorrect
|
note: associated function defined here
--> /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/convert/mod.rs:548:8
Some errors have detailed explanations: E0308, E0432.
For more information about an error, try rustc --explain E0308.
error: could not compile ppfuzz due to 7 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile ppfuzz v1.0.1, intermediate artifacts can be found at /tmp/cargo-installhR6czQ
Just like this the other 2 tools are also not being installed and I can't use the reconFTW without them

Maybe the installer didn't detected your right OS and processor, could you check what's the output of the following commands in your OS?
echo $OSTYPE
bash --version
cat /proc/cpuinfo
cat /usr/bin/arch

Hello,
I was able to install all the tools on a Mac M1. I had some issues in some of them but unfortunately I don't have any logs kept and cannot remember if I had any specific issue with ppfuzz. I do remember that the PATH was missing and I had to add it manually in order the reconfwt be able to recognise that is installed.
In my case the reconftw is not picking any target and after checking the list it just stops. Can you please assist on that?
Please let me know if I should open a new issue.
`bash -x /opt/GITs/reconftw/reconftw.sh -d asdasdasd
...
Good! All installed!

printf '\033[1;34m Tools check finished\n'
Tools check finished
printf '\033[1;32m#######################################################################\n\033[0m'
#######################################################################
exit 1`

Hey, sorry for the late reply, this happens because MacOs is not handling properly the getopt on reconftw, for this issue, I added the following lines on reconftw some time ago, could you check if you have gnu-getopt/bin on your path?:

Closing this, following the issue here https://github.com/six2dez/reconftw/issues/673


added dropdown functionality in degree field and few bugs resolved ..

#62
added dropdown for degree field where while typing user can get their desired degree (saving time)
also resolved some bugs (earlier university name was not updated in template in home..now resolved)

hey @tusharzalte @ZapeeoSheikh  please add label gssoc in the pull requests i made including this pull request
because you didnt added label to it my name is not shown in the leaderboard of gssoc (because pr is not counted as you have not  added the label) please dont ignore this message


ComponentQuery field (on JsonRendering) is not shared

Description

The ComponentQuery  field on JsonRendering that is used to store the integrated graphql query is not shared as majority of other rendering configuration related fields. It is a problem on multi-lingual systems requiring creation of the rendering definition item for each language. Without it the integrated query doesn't execute.
Expected behavior

This field has to be shared :)
Possible Fix

Make the "ComponentQuery" field shared.
Your Environment

Sitecore Version: 9.1.1
JSS Version: 11
Browser Name and version: Chrome
Operating System and version (desktop or mobile): Windows 10
Link to your project (if available):

Screenshots

The ComponentQuery field will now be shared (the change was done in Sitecore.JSS.Server project).


Markdown check workflow

Code Contribution
Change Description
This PR adds two capabilities:

Workflow that checks markdown lint, spelling, and links during PR
Updates to existing MD files to fix linting/spelling errors
Devcontainer that includes markdown extensions and has a pre-commit script to check

Checklist

[X ] I have read the code of conduct and the contribution guidelines
[X ] My code follows the project's coding conventions
[ ] My code is well-documented
[X ] I have tested my code changes and verified that they work
[X ] I have added or updated the necessary unit tests (if applicable)

6 files are free from spelling errors

@chack411 This is ready now. Example PR comment reports are inline here. Devcontainer makes it easy for people to check for errors before pushing a PR.


how to delete the Held records.??

Hi,
I want to delete held records.Please take look in the screenshots.

there are 850276 messages in held and i want to remove this from my database.

The messages should automatically be removed from the held list after 7 days, if you open one of them, it will tell you so.

Or you can simply connect to your postal database and remove these records from suppressions table directly.
The only thing to mention is to be careful :)


Introduction to Material UI for React

Material UI is an open-source React component library that implements Google's Material Design. It's comprehensive and can be used in production out of the box.


Can't edit an STI subclass from the base class's edit page

I have an STI model, Page, with subclasses LifePage and CompanyPage. I can create a LifePage from the Pages tab in rails_admin (/admin/pages/new), but when I make changes on the edit page (/admin/pages/edit/1) and then save, the page shows no errors but doesn't save the changes either; If, however, I create an ordinary Page on the Pages tab (without selecting a type from the dropdown), then I can edit that Page and the changes stick.
I think the edit page for the base model (in this case, Page) should be able to save instances of its sublcasses.

I've submitted this issue as well.  The developers are waiting for a test to fix...

Fixed now - waiting for review.

A pull request with tests inside? Christmas already! :cake: :gift:

Thanks for merging!

OMG it's fixed!  Thank you!


Opencv <IP_ADDRESS> for Python 3.5

Is there any change you could build a wheel of Opencv <IP_ADDRESS> for Python 3.5 ?

It's not possible, only OpenCV 3.0 and above has support for Python 3. Besides that I'm not going to refactor the buildchain for old releases since the build process is not identical between 2.x and 3.x.

Actually, OpenCV 2.4 runs with Python 3. I have it built on a linux virtual machine.
Thanx anyways

Hi anselal,
How to build OpenCV 2.4 run python 3.5? Could you please guide me a little.
Many thanks

@hntuan94 haven't done it for a while..


Quarter diff

Possible fix for #1991. ALTHOUGH, this is the most naive solution for a quarter diff. But I think there are two ways to do a "quarter diff" that make sense.

Two dates are a quarter apart if they're four months apart (the one implemented in this PR).
Two dates are a quarter apart if they're in different quarters (e.g. March 31st and April 1st are one quarter apart since they are on the first and second quarters of the year). This one is probably marginally more complex to implement, and also wouldn't have a sensible result when the third parameter for diff is true.

I guess I can merge that for now (next release).

There is already quarter diff support in develop


[FLINK-20677] Introduce proper JobManagerRunnerResult

What is the purpose of the change
The JobManagerRunnerResult allows to express different termination
conditions for the JobManagerRunner:

Job finished successfully
Job did not finish
Job initialization failed

Verifying this change

Added JobManagerRunnerResultTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for the review @zentol. Merging this PR now.


ArrayElementValuePropagation: require that the initialization and element-get are in the same block for non-trivial values.

In OSSA we only insert a copy_value of the element at the array initialization point. This would result in an over-consume if the getElement is in a loop. Therefore require that both semantic calls are in the same block.
Fixes an ownership verifier crash when OSSA modules are enabled.

@swift-ci test

@swift-ci benchmark

@swift-ci test


macOS Sierra Atom-beta dock icon never stops bouncing when launched from shell

Prerequisites

[x ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
--- There isn't a dock icon in safe mode.
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
On macOS Sierra 10.12.3, when launching atom from the command line, the dock icon never stops bouncing.  When launching from Finder, spotlight, or Alfred this does not happen.
I'm using Atom 1.15.0-beta3 x64
Steps to Reproduce

open a Terminal application
close Atom if it is running (the entire application Atom-Beta menu... Quit)
use the atom shell script to launch atom: atom-beta

Expected behavior: The dock icon should stop bouncing after the application is launched
Actual behavior: The icon bounces forever.
Reproduces how often: every time.
Versions
$ atom-beta -version
Atom    : 1.15.0-beta3
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0
$ apm -version
apm  1.9.2
npm  2.13.3
node 0.10.40
python 2.7.12
git 2.9.3

Hmmm, I just installed the beta on 10.12.3 but couldn't reproduce - after I launch with atom-beta, the dock icon bounces, Atom gets focused, and the bouncing stops.

Is it possible it has something to do with the in place upgrade from the previous beta?  That would be the only thing I can think would be different from what you described.

I'm not sure but I can double check at the next upgrade in case no one else has a chance to try and reproduce in the meantime.  Just to double check, if you focus Atom, you can still use it and the dock icon stops bouncing?
Also you said:

--- There isn't a dock icon in safe mode.

I was able to run the beta in safe mode and I have a dock icon - to confirm, is the lack of a dock icon also 100% reproducible (not sure if it's related, mostly curious)?

I re-attempted the safe-mode start, and I did get a dock icon.  I'm not sure what I did last time when it didn't show up.  Sorry for the red herring.   Unfortunately, it still bounced forever.
When I launch it from the shell script, I can interact with it and use it just fine, but the icon bounces away until I quit completely out of Atom.  If I launch atom by double clicking the icon in finder (or use Alfred or spotlight) it bounces once or twice then stops.  I can then open new Atom windows from the shel, and a new Atom icon shows up for a second in the dock(I'm assuming it is some kind of helper) before the window opens.  The second icon disappears pretty quickly.

I updated to 1.15.0-beta4 and tried again but didn't see the continuous bouncing dock icon.

When in safe mode it doesn't bounce forever.
It must be a package I have installed I guess.

Thanks for confirming :+1:  That does seem to point to a package as the issue but it may be that there is still a bug in Atom.  If so and you're able to pinpoint which package is causing the problem, we'll need the maintainer of the package that is causing the problem to help track that down. You should file this issue on their repository so they can either fix the problem or tell us where the problem is coming from. The Atom FAQ has information on how to contact the maintainers of any Atom community package or theme.


How long until security group assignment and membership sync takes effect

Please add information that describes how long it is expected to take for a user to be enabled/disabled in an environment after a security group is newly assigned to an environment, as well has after a user is added/removed from a security group already assigned to an environment. It does not appear to be immediate or after 15 minutes. Is this expected to take over an hour or more? Without knowing the expected time, it is hard to tell if the sync is working properly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9aafd67e-8013-565e-6566-9773136c4405
Version Independent ID: 1db48adc-6512-7978-4656-2cf081b5cdb7
Content: Control user access to environments: security groups and licenses - Power Platform
Content Source: power-platform/admin/control-user-access.md
Service: power-platform
GitHub Login: @jayasreekumar
Microsoft Alias: jkumar

How long does it take for the members of the security group to get added to the environment?  Do we have any update on this?

Security group membership sync latency depends on whether the environment is onboarded to the new user sync service, the size of the security group itself and the geo where the environment is. Administrative actions at security group level (example: role management) can be done without waiting for user sync to complete since these security changes will take effect at run time, triggering just-in-time user sync. Would be happy to jump on a call with you to understand the scenarios for your organization that need user sync and provide appropriate suggestions.


exclude ('*') in FileCollection excludes too much

Steps to Reproduce
Follow the instructions in the README.md on the reproduction project.
https://github.com/eljobe/copies/blob/master/README.md
Expected Behavior
See the "Expected Behavior" section of the README.md on the reproduction project.
https://github.com/eljobe/copies/blob/master/README.md
Current Behavior
See the "Observed Behavior" section of the README.md on the reproduction project.
https://github.com/eljobe/copies/blob/master/README.md
Context
Most of the reasoning behind why this bug is important is captured in the JRIA issue from which this bug is copied: https://issues.gradle.org/browse/GRADLE-3182
Your Environment

Build scan URL: https://gradle.com/s/ff4omynwblo6a

This is very similar to the problem described in https://github.com/gradle/gradle/issues/894


build: add backtrace tags to backtrace-related libs/tests.

This makes it easier to exclude from the build during site specific
import (e.g. Google).

@dnoe @mattklein123

Yeah, we probably do. @dnoe Do you want to add this to test/main.cc? We clobber this during out internal import, so it's fine to put whatever you like in there.

Good idea, I will push a change to add this.


Add CODE_OF_CONDUCT and CONTRIBUTING files

Add files!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Alan Chiu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

We already have both files in docs - seemed like a good place to collect them.
According to the GH docs, it works too, but in case it causes trouble, let's just put them in .github, but we shouldn't have duplicates.

@timostamm great looking out. let me make those changes!


fix: CLOUD-809 support missing resource in ruleResultBuilder

This PR contains a stopgap fix for missing-resource policies. The way that we were calculating the primary resource for rule results meant that it was not possible to report secondary resources from a missing-resource policy. We have a longer-term need to come up with an intuitive syntax for these rules. But, for now authors will be able to specify resource_type in resources[info] rules in order to make it easy to correlate passing and failing missing-resource policy results:
resources[info] {
	contact := valid_contacts[_]
	info := {
		"resource_type": "aws_account_alternate_contact",
		"resource": contact,
		"attributes": [["alternate_contact_type"]],
	}
}

I'm having trouble understanding the example given in the PR comment. Is the contact there the "secondary resource"? Is contact an actual object or is it null or undefined when the "resource is missing" situation arises?
My brain might still just be used to the old Fugue rules...
Would an alternative implementation be to add something like "is_missing_resource": true key to the deny objects instead? (This question reflects me not "getting" how the resources info factors into this)

I'm having trouble understanding the example given in the PR comment. Is the contact there the "secondary resource"?

Yes, that's the way it'll be interpreted.

Is contact an actual object or is it null or undefined when the "resource is missing" situation arises?

resources won't produce a result when the resource is missing situation arises. My changes in this PR haven't changed the output for deny for any of our existing rules, just the output for "passing" results.

Would an alternative implementation be to add something like "is_missing_resource": true key to the deny objects instead? (This question reflects me not "getting" how the resources info factors into this)

The problem is with passing results. We need passing results to have the same identity as failing results. It's sorta possible w/o my changes if you do something like:
resources[info] {
	contact := valid_contacts[_]
	info := {
		"primary_resource": {"_type": "aws_account_alternate_contact"},
		"resource": contact,
		"attributes": [["alternate_contact_type"]],
	}
}

but you end up with a mostly empty entry in resources in the output. The changes in this PR make it so that there is no primary resource for passing, missing-resource results without requiring the rule author to specify a fake primary resource.


Error when implement "sfs" commond

Describe the bug
I have been studied sfs based on the shape-from-shading examples in the section 12.7 "SfS with multiple images in the presence of shadows". When I implement the sfs commands in page 162 in asp_book, there exist this message of error: "Found DEM nodata value: -3.40282e+38"

Here is the code and the related error:
(asp) caowei@CAOs-MacBook-Pro test % sfs -i run_sub10/run-crop-DEM.tif A_crop_sub10.cub C_crop_sub10.cub D_crop_sub10.cub -o sfs_sub10_ref1/run --threads 4 --smoothness-weight 0.12 --initial-dem-constraint-weight 0.001 --reflectance-type 1 --use-approx-camera-models --max-iterations 5 --crop-input-images --bundle-adjust-prefix run_ba_sub10/run --blending-dist 10 --min-blend-size 20 --shadow-thresholds '0.00162484 0.0012166 0.000781663'
--> Setting number of processing threads to: 4
Writing log info to: sfs_sub10_ref1/run-log-sfs-05-29-0810-80483.txt
Shadow threshold and max valid value for A_crop_sub10.cub 0.00162484 3.40282e+38
Shadow threshold and max valid value for C_crop_sub10.cub 0.0012166 3.40282e+38
Shadow threshold and max valid value for D_crop_sub10.cub 0.000781663 3.40282e+38
Found DEM nodata value: -3.40282e+38
DEM cols and rows: 99 93
Found a no-data or NaN pixel in the DEM. Cannot continue. The dem_mosaic tool can be used to fill in holes. Then crop and use a clip from this DEM having only valid data.
My Environment is macOS Monterey version 12.4
Additional context
I have used dem_mosaic, and check the previous steps carefully. However, the same problem happened.

The error is telling you everything you need to know.  Your starting DEM has "nodata" values in it, and the sfs algorithm cannot "begin" from a DEM that has nodata values in it.  The advice in the error message says to use dem_mosaic on your starting DEM to fill in the holes (by using a value for --hole-fill-length).  If the "nodata" areas are large that may result in bad interpolation, and you may find that using dem_mosaic to mosaic a lower-resolution DEM into these larger holes is good.  Or you can use any method you like to fill in the "missing" data in your DEM.  Sometimes if the "nodata" pixels are at the edges, it is easier to just trim those pixels off.
Whatever you do, the DEM you give to sfs to start with must have no "nodata" pixels in it.

The message ""Found DEM nodata value: -3.40282e+38"" is not an error though. The following convention is followed.
The problem is with the message "Found a no-data or NaN pixel in the DEM. Cannot continue". What you need to do is open that DEM in stereo_gui, examine it, and select a region not having holes or missing data (which appear black). Then use gdal_translate to get a clip with no holes, and run SfS on it. There is more info here: https://stereopipeline.readthedocs.io/en/latest/sfs_usage.html#initial-dem-creation.
(I see that Ross got ahead of me, but apparently we say complementary things.)


[RFC] Should Runes follow the operator precedence defined by Haskell?

I'm currently working on adding an implementation of <^> to Madness (https://github.com/robrix/Madness/pull/86), and so in the interests of keeping things standardised I thought I'd check how Runes defines the operator. I also checked how the precedence is defined in Haskell:
Prelude Control.Applicative> :i (<$>)
(<$>) :: Functor f => (a -> b) -> f a -> f b
  	-- Defined in ‘Data.Functor’
infixl 4 <$>
Prelude Control.Applicative> :i (<*>)
class Functor f => Applicative (f :: * -> *) where
  ...
  (<*>) :: f (a -> b) -> f a -> f b
  ...
  	-- Defined in ‘Control.Applicative’
infixl 4 <*>
Prelude Control.Applicative> :i (>>=)
class Monad (m :: * -> *) where
  (>>=) :: m a -> (a -> m b) -> m b
  ...
  	-- Defined in ‘GHC.Base’
infixl 1 >>=

So in Haskell, <$> (infixl 4) and <*> (infixl 4) have higher precedence than >>= (infixl 1). However, Runes doesn't specify an explicit precedence, and the default is lower than the 150 defined for >>-.
What do you think about setting an explicit precedence for <^> and <*> that's higher than >>-? I've somewhat arbitrarily selected 155 here, but it could be any value really.

By the way, here's a reference for all of Haskell's default operators: https://www.haskell.org/onlinereport/decls.html#sect4.4.2.
To follow this strictly in Swift would mean that:

<^> and <*> should have the same precedence as the equality operators, i.e., 130
>>- should be less then the logical comparison operators (120 for &&, 110 for ||) but probably greater than the assignment operators (all 90). A precedence of 100 would be logical (and the standard library currently doesn't define any operators with a precedence of 100).

I've pushed a new commit to that effect. Would love to know what you think!

I think this is awesome. Thanks for putting in the time to research this. I wonder if the (unintentional) mismatch between Haskell and Runes is what has been leading to my confusion about when the hell I needed to use parens...

Thanks @gfontenot!! ❤✨


Scriban supports .NET indexer again since 3.8

The workaround for .NET indexers got restored in scriban 3.8. Thus the workaround can be removed.
https://github.com/gircore/gir.core/blob/367547e1b2c0f0413a0dc07f3291fd431655a196/Generator/Factories/ScriptObjectFactory.cs#L53

This is probably obsolete with #336

Generator3 does not use Scriban at all.


Fix test/example.c when compiled with ASAN

Before this patch
cmake -DWITH_SANITIZERS=1
make
make test
used to fail with:
Running tests...
Test project /home/hansr/github/zlib/zlib-ng
Start 1: example
1/2 Test #1: example ..........................***Failed    0.14 sec
Start 2: example64
2/2 Test #2: example64 ........................***Failed    0.13 sec
==11605==ERROR: AddressSanitizer: memcpy-param-overlap: memory ranges [0x62e000000595,0x62e0000053b5) and [0x62e000000400, 0x62e000005220) overlap
#0 0x7fab3bcc9662 in __asan_memcpy (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x8c662)
#1 0x40f936 in memcpy /usr/include/x86_64-linux-gnu/bits/string3.h:53
#2 0x40f936 in read_buf /home/spop/s/zlib-ng/deflate.c:1122
#3 0x410458 in deflate_stored /home/spop/s/zlib-ng/deflate.c:1394
#4 0x4133d7 in zng_deflate /home/spop/s/zlib-ng/deflate.c:945
#5 0x402253 in test_large_deflate /home/spop/s/zlib-ng/test/example.c:275
#6 0x4014e8 in main /home/spop/s/zlib-ng/test/example.c:536
#7 0x7fab3b89382f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#8 0x4018e8 in _start (/work/spop/zlib-ng/example+0x4018e8)
0x62e000000595 is located 405 bytes inside of 40000-byte region [0x62e000000400,0x62e00000a040)
allocated by thread T0 here:
#0 0x7fab3bcd579a in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x9879a)
#1 0x40147a in main /home/spop/s/zlib-ng/test/example.c:516
0x62e000000400 is located 0 bytes inside of 40000-byte region [0x62e000000400,0x62e00000a040)
allocated by thread T0 here:
#0 0x7fab3bcd579a in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x9879a)
#1 0x40147a in main /home/spop/s/zlib-ng/test/example.c:516
SUMMARY: AddressSanitizer: memcpy-param-overlap ??:0 __asan_memcpy
==11605==ABORTING
The abort is on the following call to deflate():
c_stream.next_out = compr;
c_stream.avail_out = (unsigned int)comprLen;
[...]

/* Feed in already compressed data and switch to no compression: */
PREFIX(deflateParams)(&c_stream, Z_NO_COMPRESSION, Z_DEFAULT_STRATEGY);
c_stream.next_in = compr;
c_stream.avail_in = (unsigned int)comprLen/2;
err = PREFIX(deflate)(&c_stream, Z_NO_FLUSH);

with c_stream.next_out and c_stream.next_in pointing to the same memory array.
The patch reduces the size of the array for in and out to not overlap.

Looks like this causes a segfault in some cases.
It fails on all ppc64 builds on travis.

Please note that this patch only fixes test/example.c.
There is still an ASAN error in test/minigzip as shown in https://github.com/Dead2/zlib-ng/pull/206#issuecomment-434248523


feat: 🎸 add 5.1.3 and pull from develop for latest

Description
Adds a new config bundle, cleans up syntax, and lets us test against the truly latest release
Breaking Changes
n/a
JIRA Link
n/a
Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 5.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v5.5.0
v5.5.0

Your semantic-release bot :package::rocket:


Wrong arg to Set.contains()?

I came across this issue after seeing this Eclipse warning:
Unlikely argument type Deque<Map<String,Node>> for contains(Object) on a Collection<Node>
Es6TypedToEs6Converter.java
/closure-compiler-parent/src/com/google/javascript/jscomp
line 429
Java Problem

https://github.com/google/closure-compiler/blob/d66ab8e8562c313b873070ba59a3f1211a30f7eb/src/com/google/javascript/jscomp/Es6TypedToEs6Converter.java#L429
@Dominator008 git blame shows you as the author.

Looks like we probably meant containsAll.

This pass is not really supported anyway; we might be able to just get rid of it.


[TC-MOD-1.2] - Standardnamespace is mandatory attribue present  in spec but not implemented in chip-tool

IN Testcase [TC-MOD-1.2] and [TC-MOD1.3]- standardname space is the mandatory attribute mentioned in the spec but not implemented in the chip-tool. Needs to implement the standardnamespace attribute in chip-tool.
Here is the spec ss

Here is the chip-tool ss

https://github.com/project-chip/connectedhomeip/issues/16154
Fixed in this commit.


Wrong procedure name

az_replication_change_master should be az_replication_change_primary

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 261311a4-69ae-3bb8-7271-f8f8bd81ec38
Version Independent ID: 2fe7e95b-c316-ed88-4f7d-ad8e6463c952
Content: Configure Data-in Replication to replicate data into Azure Database for MySQL.
Content Source: articles/mysql/howto-data-in-replication.md
Service: mysql
GitHub Login: @ajlam
Microsoft Alias: andrela

GitHub issue was opened under this document but if you notice in step 1, there is a link to Data-in Replication Stored Procedures and this is the doc correction that needs to be made.

@sergaz-msft Sorry, my bad. az_replication_change_primary should be az_replication_change_master in the doc. I ran SHOW PROCEDURE STATUS in MySQL but only see az_replication_change_master. When calling az_replication_change_primary, it will pop "Procedure not exist" error. Sorry about the confusion. I just edited the issue.

@ShawnXxy thank you for the clarification :).
I have assigned the issue to the content author to evaluate and update as appropriate. Please also update this here.

#please-close

@ShawnXxy We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Persistent Controls for Docks

Recently, the Nuclide team did a in-depth user research sprint to identify ways to improve our UX and discoverability. One of the suggestions that came out of it was to have persistent, predictably-behaved controls for docks. This is our proposal for adding them to Atom 😊.
In a Nutshell

Add a vertical icon bar to the left and right docks, indicating their current items and grouping and allowing the docks to be toggled and items to be repositioned.
Subsume the status-bar package, adding similar controls for the bottom dock.

Proposed Changes
Control UI

The controls behave as follows:

Clicking on a group will open the dock, revealing the items in the group or (if the dock is already open and showing that group), close it.
Dragging an individual icon allows you to move it either within the group, to an existing group, or to create a new group.
Dragging a group from the grabber (which appears on hover) allows you to move that group.
The ability to remove items is de-emphasized (as compared to the current tabs behavior); it's only possible via the context menu. (As a result, I think we can remove the isPermanentDockItem() optional item method.)
The icon bars aren't visible unless there are items in the dock.

Open questions:

Having left and right dock icon bars in the vanilla Atom install (tree-view and GitHub packages respectively) might be a little much. We recommend moving Git/Hub to the left dock by default. Then it'll just have one (with three items).

Horizontal Control UI

Controls for the bottom dock will be integrated into the status bar.

Grouping (shown in the first pic above) works the same as in the vertical case.
The areas on the left and right will remain reserved for status bar tiles. If they don't fit in the allotted area, they'll be clipped by the dock icon bar. Mousing over the areas will cause them to expand, covering the dock icon bar until the mouse is moved away. (We'll experiment with the exact affordance.)
The dock icon bar will have a minimal state containing only the icons (removing the text) if there are too many items for the allotted space.
When the left dock is open, the width of the left status bar will be tied to that dock's width (though not allowed to go below a minimum). This will keep the bottom icon bar beneath the bottom dock.

Open questions:

Currently, tabs above the dock items display the icon and title. With the new controls, this is kind of redundant so we've removed them to save on vertical space. We may need to put it in front of people and gauge reactions though.

“Tabs of Panes”
Currently, docks have the same organization as the workspace center: containers (“PaneContainers”) have one or more groups (“Panes”), which can each contain multiple items, and each group corresponds to a tab bar for selecting the active item (“tabs within panes”) in that group. A single top-level control, however, implies that the user is activating groups of items, not individual items (“panes within tabs”)*.
In terms of relationships, these two aren't actually that different:

The difference, then, is that, instead of showing one item of every group, Atom will show every item of a single group group. For example, if the user were to select the  ⃟ ♡ ♤ group above, the dock would show the three corresponding items, vertically stacked in that order.
Because the difference is purely presentational, it should be possible to retain the current PaneContainer and Pane model classes  but associate them with different views in this context. Some new API (e.g. for toggling a Pane) will be necessary.
Open questions:

How do we handle the need for new API in dock panes? Are dock Panes a subclass of Pane?
Is the word “pane” so strongly associated with a particular presentation that the difference is confusing?
What issues will the changes in presentation cause in existing packages? (e.g. currently, non-active items are implicitly non-visible)
I think I can implement this in a separate (but bundled) package, dumb down vanilla docks, and remove the docks interaction from the tabs package.

Removal of Dock Toggle Button Affordance
Because the docks will be toggled by the icon bars, these are no longer necessary.
Badge/Notification Support
The presence of persistent controls for dock items means that we'll now have a more natural place for showing those items' statuses than the disconnected icons of the status bar. For example, the button for toggling the diagnostics table can also indicate how many errors there are; the console can indicate new messages.
Our proposal for this is to add two new (optional) methods on workspace items:
getStatus(): {
  severity?: 'info' | 'warning' | 'error',
  count?: number,
},
onDidChangeStatus: (
  cb: (status: {
    severity?: 'info' | 'warning' | 'error',
    count?: number,
  }) => mixed,
) => IDisposable,

While somewhat limiting, this API enforces a consistency of experience across dock items and can be easily expanded later.
Atom will subscribe to this event and show appropriate badges on the items in the persistent controls.
Open questions:

I chose getStatus() and onDidChangeStatus() for symmetry with getTitle(), onDidChangeTitle(), getIcon(), etc. However, in many ways, observeStatus() is more natural. Unlike title and icon, status is a changing value by definition. Also, having users implement one method instead of two would be nice. I still think having two methods is the right call but I wanted to flag this for discussion.

*See #672 for some history on this terminology.
cc @karincurkowicz who's been doing the design work on this and @nathansobo who we talked to a while back

The areas on the left and right will remain reserved for status bar tiles. If they don't fit in the allotted area, they'll be clipped by the dock icon bar.

I disagree with the status bar tiles being shrunk by the dock icons. The point of a status bar is to be able to look at it and get the current status of things, like a clock on the wall. Having to move the mouse cursor over it even just to hover to get it to expand defeats the purpose. On the other hand, in order to interact with the dock icons (leaving aside the "badge/notifications" part) it seems that your design expects people to move the mouse cursor over them. It would then make more sense for the dock icons to be shrunk or clipped in favor of the status bar tiles until the mouse is hovered over the dock icons area.

Removal of Dock Toggle Button Affordance

I believe this would fix https://github.com/atom/atom/issues/15728 and https://github.com/atom/atom/issues/14803

@Alhadis I'd be curious about your thoughts about a strategy for providing more icon choices for pane items.

A unified approach would be nice. Currently, there are five different implementations of the icon-services, one for each core package that uses them. Needless to say, that's not going to be fun to maintain.
Is there anything the current service is lacking that would need to be considered for this to happen?

@Alhadis, if and when when you have time, I'd be interested in seeing a proposal for what a core API for making icons more extensible might look like based on your experience with your package and the services. It's one of the most popular packages so that seems to suggest that making it part of core would be wise. We can do it in another channel to keep this issue focused.

Sure thing. Which channel? And which forms of extensibility were you thinking about?

Just an issue... mainly just how do we let people install packages that can offer options for customizing the icons of dock items like the debugger, file tree, diagnostics etc. Like what should the icon story be in Atom ideally?

Like what should the icon story be in Atom ideally?

Ideally, there should only be one icon-service for element-icons, and that can easily be revised to accommodate subjects which aren't filesystem entities. To recap, the service supplies a function with this signature:
addIconToElement(element, path, options = {}) (Disposable)

We can still use this: but we need to think of the second parameter as a uri, rather than a filesystem path. This would fit neatly into Atom's existing URI-based model:
addIconToElement(element, uri);
addIconToElement(iconDiv, "/path/to/file.txt");
addIconToElement(iconDiv, "nuclide://tree-view-icons/some/icon/id");
addIconToElement(iconDiv, "atom://config");

Am I following okay?

@Alhadis Maybe this already just works via the tabs package already and we don't need to worry about it. I think we may need to let it evolve a bit and check in on the icons story later. Just wanted to make you aware of it more than anything.

Alright, thanks for the heads up. ;)
Truth be told, though, the tabs package only supports icons because the earliest versions of Atom (in my memory) assigned icons to "special" panels like Settings, About Atom, Deprecation Cop, and so forth. It yielded a rather ad-hoc method called getIcon(), which TTBOMK, was never used for anything else other than those special edge-cases.
So what @matthewwithanm is proposing re: the replacement of getIcon and co with observeStatus is certainly a step in the right direction, IMHO. No need to be carrying old relics if we're revamping everything.

So what @matthewwithanm is proposing re: the replacement of getIcon and co with observeStatus is certainly a step in the right direction, IMHO. No need to be carrying old relics if we're revamping everything.

I was actually proposing carrying the old relic 😊
Our proposal for the status notifications is that they would overlay the icons. Mostly, I'd just like to keep the icon question separate. Since workspace items (including dock items) currently use getIcon(), it makes sense to me not to touch that as part of this proposal.

Sorry, I didn't intend the icon discussion to balloon into several screens worth of scrolling. Lesson learned. Let's table further icon discussion for now.

Right now I'm just annoyed that some packages provide a tab that goes into a pane (linter-ui-default) and others provide a tab that goes into a dock (todo-show) and for some reason these are different things, so I can't have Linter and Todo Show stacked vertically at the side of the screen. Can't drag the todo tab into a pane or the linter tab into a dock, nothing happens in either case.
Why are these different things anyway? The only difference from a UI standpoint seems to be that a dock can be hidden by clicking the arrow. Could we not just drop a regular tab into there instead of a special one, and have a pane that can hide?

@RenaKunisaki For more information on Docks and the rationale behind them, see the Docks Deep Dive blog post. Let's keep this issue on topic as to persistent controls in docks. For Docks vs. Panels questions and discussion you can use Discuss, the official Atom message board, or the Slack team.

Love it! 😍

Having left and right dock icon bars in the vanilla Atom install (tree-view and GitHub packages respectively) might be a little much. We recommend moving Git/Hub to the left dock by default. Then it'll just have one (with three items).

Agreed. 👍
Another question: Would grouping of dock items be preserved across projects (and be reflected on other open windows? For example if I drag the outline view to another group and then open another project, the outline view should also appear at the new position in that project. Currently when rearranging dock items, they are remembered on a per project basis. In some cases ok and keeps things flexible, but could also get tedious having to re-arrange it for every existing project separately.

The other day I mocked up how the GitHub package could behave with permanent dock controls: https://github.com/atom/github/issues/440#issuecomment-351895215
Here with a number badge added:

Some packages might want to show more infos. So instead of only a number, it could be a string under the icon. Then for example the Git panel could show behind/ahead like: 1 / 3. Or there could also be status like error, warning, success that will show as an additional icon. Like the GitHub panel could show if CI succeeded with a ✅  checkmark.

Not sure, might be visually too noisy. Or the main icons need to be bigger.

This would still be nice to have


Make unbinding from CodeGeneratorService cleaner

Fix #535 by creating an unbind call that unbinds from the service
and clears state so we don't end up in a situation that can try to
unbind twice.

This change is

LGTM


Fixed typo in AccountTradeReponse

Overview
Solved Issues
Fixed typo in AccountTradeReponse
Installation
N/A
Acceptance and Testing Steps

[x] Is it compatible for all target frameworks?

Other Notes

Please open this against the main repo


Pass assets with custom actions from git

I've implemented simple custom action, which gathers results of multiple runs of snapshot into single html. It works fine, but now I need to use it another project, and decided to extract this action to separate git repository.
Action need one more file to work - .erb template, I've put it to the same folder with action, but it seems fastlane improrts only .rb files from git.
Is there any way to pass assets with actions as well?

Hey @SemenovAlexander! Apologies for the really slow response. I'm not totally sure I understand the issue, but if you put the erb file in another directory, you should be able to access it using relative paths from the file or the working directory. I am going to close this issue for now as it is more of a question of functionality, but please feel free to continue discussion if you'd like! :rocket:

Hi @ohwutup! Thanks for response.
Let me describe my use-case to give clear understanding.
I have several custom actions, used across different projects, and I want to store that actions in it's own repository.
Some actions has their own assets (html files, ERB templates, etc.), and the issue is, when I add that actions using Fastlane's import_from_git action - only .rb files are cloned from repository, and nothing else, even if assets are placed to actions folder.
So, for now, I've ended up by manually copying updated assets each time to each new repository, that uses that actions, but it's not really nice way.

Thanks for the explanation @SemenovAlexander ! I found the culprit https://github.com/fastlane/fastlane/blob/a6641e6e4b990cbf7e421384ada0f11b21d42930/fastlane/lib/fastlane/actions/actions_helper.rb#L77 We can likely make a fix for this!

Hey @SemenovAlexander are you still having an issue with this? We just started rolling out a plugin system and it seems like these custom actions you are building would be a great fit for that!

Hi @ohwutup! Wow, it's amazing news, as I still use that rough approach, described above. I've quickly checked #4873 and for sure will try to migrate my stuff to new plugin at nearest future!
Thanks a lot for that reminder!


Service bus REST vs. NET Client Support page out of date

This page:
http://msdn.microsoft.com/en-us/library/azure/hh780771.aspx
Claims that batching is not possible via REST API.
It is possible now, with this:
http://msdn.microsoft.com/en-us/library/azure/dn798894.aspx

This looks fixed now.  I'll close. Thanks.


testAssignmentUnnesting produces no output

Only the header row is produced.

I just ran this code in the debugger and changed
  Table.fromSheet(ss.getSheetByName("Polling Places"))
    .equiJoin(build, [{probe: "Polling Place Long Name", build: "pollingPlaces"}])
    .toSheet(target);
``
to
```js
let t = Table.fromSheet(ss.getSheetByName("Polling Places"))
    .equiJoin(build, [{probe: "Polling Place Long Name", build: "pollingPlaces"}])
``
Inspecting t in the debugger, it appears to have no values, so I think there's something wrong with the unnesting code.

I tried this recently and there are fewer values because the join values seemed to have changed slightly.

Working now.  Can't explain the discrepancy.


prom2json failed

Hi, I tried integrate zabbix + go-dnscollector, but faced with parsing error. I used prom2json to check what can be wrong.
Steps to reproduce:
curl  -q -u admin:changeme http://<IP_ADDRESS>:9990/metrics > dns_metrics.txt

docker run -it -v /root/metrics:/metrics.txt golang:latest
GO111MODULE=on go install github.com/prometheus/prom2json/cmd/prom2json@latest

prom2json /metrics.txt
FATA[0000] error reading metrics:reading text format failed: text format parsing error in line 383: second HELP line for metric name "dnscollector_requesters_total"  source="main.go:73"

Could you please check.

thanks to report that.
fix in progress

promtool check metric is now used in gh-actions to validate the format
fix will be available in the next release


Is there a known solution for the "Class not found" Problem?

Hi,
I've tried to install php-webdriver following the steps you describe here. I'm getting a problem that seems to happen with some frequency to newbies like me on getting this webdriver client to work.
Everything with the installation seems to be ok, but then when I try to run a test script I always get the same error: "PHP Fatal Error: Class Facebook\WebDriver\WebDriverTestCase' not found in...'.
Sometimes is that class on that weird path, as I know that the class itself isn't there, but it was just an example, when I try some other tests with different classes I still get the error, not always leading to that path.
I've tried everything I found on the internet, I put the require 'autoload.php' command on the test files, I changed the version of phpunit in composer.json to the latest version, which I installed on my computer, or at least >=4.2.0, I tried to remove the -dev declaration on calling php-webdriver or phpunit in composer, I erased everything and started the whole installation again, making sure I follow every step as here described but still get this class not found problem.
Am I missing something? Why does the latest version of php-webdriver still require phpunit 4.2.0 when the latest stable version is already 5.2.9?
I'd thank any help on this, since I already wasted too days at work searching for a solution.
Cheers and thanks in advance.
Dave.

Hi, I dismissed this php webdriver client for now as I'm working on a project for my formation that has a deadline near in the future, I've erased everything as I'm working with Selenium WebDriver in Java so I'll close this subject.
Maybe I'll try it again in the future and if the problem persists I'll ask again. I've seen this same question in stackoverflow, but curiously the answer was to come ask here or in the facebook group :), as I'm not given permission to access the fb group this is the only possible way for me to ask.
Anyway, thanks for answering,
Dave.

Is there a solution yet?

@Eddcapone Solution for what exactly :)?

For the problem described by @Oonabe

I need help with this too. I don't know how to make certain classes load. I've been trying to make "WebDriverBy" to autoload but its not happening.


Let SmartLedsAdapter take its buffer by value

This makes it possible to store a SmartLedsAdapter in a struct without requiring static mut or self-referential tactics.
Could be cleaned up once #![feature(generic_const_exprs)] gets stabilized.
CC #980
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must

[x] The code compiles without errors or warnings.
[x] All examples work.
[x] cargo fmt was run.
[ ] Your changes were added to the CHANGELOG.md in the proper section.
[x] You updated existing examples or added examples (if applicable).
[ ] Added examples are checked in CI

Nice to have

[x] You add a description of your work to this PR.
[x] You added proper docs for your newly added features and code.

Could you point me to the existing entry?

Could you point me to the existing entry?

Ah sorry ... there isn't one since the CHANGELOG is only for the HAL and there isn't one for SmartLED-Adapter 🤦♂
Will set this to "No CHANGELOG required"


added json field

Two minor docstring notes, but otherwise looks great.
I'm guessing you're using the pre 1.0 version of django-jsonfield because it returns a dict rather than a string of json. I'd recommend making a note of that in the docstring, the usage_examples, and in the changelog, so anyone who is using the jsonfiled>=1.0 knows what they're getting.

@micahhausler the json field difference might be in the way data is handled in the django model. i upgraded the test version to 1.0.2, and tests are still fine.

Oh good! Looks great!

I was wrong about the json version, so I added a note in the json field examples. Going to go ahead and merge this.