class_definition fails with initialising anonymous class

Bug report
Found an issue where php-cs-fixer keeps reporting issues with anonymous classes and not fixing them. Managed to reduce the bug to snippet below.
> format-php-cs-fixer: php-cs-fixer fix --allow-risky=yes '-vvv' 'src/fixer-test.php'
Executing command (CWD): php-cs-fixer fix --allow-risky=yes '-vvv' 'src/fixer-test.php'
PHP CS Fixer 2.18.1 Remote Void by Fabien Potencier and Dariusz Ruminski
Runtime: PHP 7.4.12
Loaded config default from "/var/www/html/app/.php_cs.dist".
Using cache file ".php_cs.cache".
Paths from configuration file have been overridden by paths provided as command arguments.
F
Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error
   1) src/fixer-test.php (class_definition)

Fixed all files in 0.046 seconds, 14.000 MB memory used

<?php

declare(strict_types=1);

$srcFiles = PhpCsFixer\Finder::create()
    ->in(__DIR__)
    ->name('*.php')
    ->path(['src/'])
    ->ignoreVCSIgnored(true);

$finder = $srcFiles->append($rootFiles);

$config = new PhpCsFixer\Config();

return $config
    ->setRules([
        'class_definition' => true,
    ])
    ->setFinder($finder);

Code snippet that reproduces the problem
<?php
$var = new class () {
    // content
};

I cannot reproduce it, your example always is fixed once (space after class is removed) and that's it. Can you provide some a failing test case?

I cannot reproduce it, your example always is fixed once (space after class is removed) and that's it. Can you provide some a failing test case?

Sorry, I think this was my fault. I thought I had isolated everything while testing but it seems CodeSniffer formatter was applied by IDE after CS Fixer run. Closing the ticket.

Sorry, I think this was my fault. I thought I had isolated everything while testing but it seems CodeSniffer formatter was applied by IDE after CS Fixer run. Closing the ticket.

I cannot reproduce it, your example always is fixed once (space after class is removed) and that's it. Can you provide some a failing test case?

Should the space after class be removed?
Looking at the PSR12 documentation, it's written:

[Anonymous Classes] MUST be declared with a space after the [class] keyword

Sorry for late response, I'll do it.

Looking at the PSR12 documentation, it's written:

[Anonymous Classes] MUST be declared with a space after the [class] keyword

I have a similar issue where PHP-CS-Fixer and PHPCS fight over the space between class and ($var) in:
$instance = new class ($var) extends \Foo {};

It looks like the quoted part of the documentation was removed and I cannot find a clear position.
There was some work in the https://github.com/php-fig/fig-standards/pull/1206 PR that seems to remove the space, but it was not merged.


chore: add required GITHUB_TOKEN to step.env level

If the GITHUB_TOKEN is at the workflow level, the GH action turnstyle does not get executed correctly.

Weird though, looks like a bug in turnstyle. You can also create an issue in their repo. And add a comment in our code linking back to that issue. Otherwise, someone might inadvertently move this env to workflow level

Issue in Turnstyle repo: https://github.com/softprops/turnstyle/issues/13


Hmm. Your browser version isn't supported

Just today (12.12.2017) ms-teams-linux app refused to work with a funny message:
Hmm. Your browser version isn't supported. Here's what works:
Microsoft Edge - Install for free
Google Chrome - Install for free
Mozilla Firefox - Install for free

Never mind, solved by myself. Need to build fresh one :)
For those, who looks for recipe:
git clone https://github.com/sportradar/ms-teams-linux.git
cd ms-teams-linux
modify  ms-teams-linux/src/background.js:
 mainWindow.webContents.setUserAgent(
    'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/**64**.0.2883.87 Safari/537.36'
  );

npm install gulp-install gulp gulp-watch gulp-batch fs-jetpack rollup electron about-window electron-builder
npm run release
cd dist
./ms-teams-capsule-0.4.0-x86_64.AppImage

Hello, @linascheryservers. This fork is not maintained any more. Please to the original project for up-to-date version.


Added german translation

Please verify the following:

[*] Everything works on iOS/Android
[*] ignite-base ava tests pass
[*] fireDrill.sh passed

Describe your PR
Just provide german as language file

Thank you!


Add upgrade test to pipeline

This would deploy the current version of service catalog, a broker, provision a service and binding, and then deploy the new version on top and make sure everything survives the transition.
Much of the groundwork that needs to be down for #2659 will probably be useful here.

/assign

The migration tool and documentation are already created:

https://github.com/kyma-incubator/service-catalog/blob/crds-migration/contrib/hack/ci/run-migration-tests.sh#L91-L108
https://github.com/kyma-incubator/service-catalog/blob/crds-migration/docs/migration-apiserver-to-crds.md

The bash script for executing the migration is also created:

https://github.com/kyma-incubator/service-catalog/blob/crds-migration/contrib/hack/ci/run-migration-tests.sh#L91-L108

Pull request to kubernetes/test-infra: (will be created after merging CRDs):

https://github.com/kubernetes/test-infra/compare/master...mszostok:add-sc-upgrade-pipeline?expand=1

Test executed on prow:

https://status.build.kyma-project.io/view/gcs/kyma-prow-logs/logs/post-test-sc-upgrade-job/1162329278755377152

the story was successfully finished


Response Content-Type header doesn't indicate the version

When using the media type versioning, it is possible for a request to specify multiple media types in the accept header (e.g. "application/json; v=1.0, application/json; v=2.0") on a GET request. However, the response just has a Content-Type header of "application/json", so the client doesn't know which version was returned. It seems like the Content-Type header in the response should indicate the version (e.g. "application/json; v=2.0") of the response that was actually returned.
I'm using:
Microsoft.AspNetCore.Mvc.Versioning 3.0.0
Microsoft.AspNetCore.Mvc.Versioning.ApiExplorer 3.0.0

Currently, this is not supported. The existing implementation selects the version from the media type with the highest quality (as seen here). Since these media types have the same quality, it's coincidence that you're getting 2.0. If you reversed the order, I would expect you to get 1.0. This happens because there are distinct phases between reading the raw API version value and parsing it. Parsing is delayed as long as possible so that an appropriate response can be given (as opposed to trying to deal with an exception in the middle of the pipeline).
Requesting multiple API versions is currently not supported. In any other context (e.g. query string or header), you should have received a 400 with AmbiguousApiVersion. The only reason that doesn't happen with media types is because the quality can be used to weigh (e.g. disambiguate) the best choice. There isn't a mechanism to select an appropriate API version from a set of inputs. In addition, it would have to be delayed far into the pipeline (for parsing) or a service author would be left to their own parsing and evaluation. Ultimately, the client should be only asking for a single API version. I can think of scenarios of where requesting multiple versions might be useful (ex: 1.0-RC or 1.0), but there's a lot of devil in the details, which is why it's not supported. Furthermore, in practice, I've never seen that needed. If client cares about the version, they typically want a specific version.
Reporting the selected API version isn't unreasonable, but given that only a single API version is matched, it shouldn't be necessary. There's no other context - yet, in which you get the matched API version back. I'm not opposed to the idea, but I need to make sure it's feasible. It may not be possible in all cases based on when the headers are written and who writes them. I believe the content type is written by the IOutputFormatter.
If you have version symmetry across your APIs, then it's possible for you to create a custom IApiVersionReader to handle this. That's possible because you know all the versions in your application ahead of time. API versioning doesn't have a why to reliably do that for you. It has to wait until a route candidate is matched before it can determine available versions. In a similar way, you should  be able to add or update the version in the Content-Type header with a couple of different, standard ASP.NET extensibility points. It might also be worth investigating how browser clients handle media type parameters.


Feat upgrade gateway api to v1.0.0

What does this PR do?
This PR upgrades Gateway API to version v1.0.0.
It removes support of v1alpha2because it has been deprecated
Motivation
Fixes #10182
More

[x] Added/updated tests
[x] Added/updated documentation

Additional Notes

no-merge because integration tests are not working on my laptop...

Hi, any idea on when this be ready for merge ? :thinking:

May I ask when the merger will take place ？

This PR is great. Can we merge as soon as possible? I can't wait anymore.   ^_^

Could you send the report for API Gateway v1 ? https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/reports/v1.0.0


[Testerina] Implement TestReportListener

Description:
A TestReportListener implementation is required in order to streamline the way we handle how logging and report generation takes place when the project test suites are run.
Describe your task(s)
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

As the first step make the current test output consistent and relevant.

+1 to the feature. Following is one of the HTTP module requirements:

When one of the tests hangs out of 1500+ test, it's hard to identify even the hanging test case. So testLogging option would be useful in such cases as it prints when a particular test starts and when it's over as events of "PASSED", "FAILED", "SKIPPED".
This will help ballerina dev to fix exact test case with minimum time. At the moment use divide and concur approach to identify the test case


Update submariner and shipyard references

Co-Authored-By: Janki Chhatbar<EMAIL_ADDRESS>

Something weird about kubeconfig fails only on one of the tests? :? https://travis-ci.com/github/submariner-io/submariner-operator/jobs/322894575#L8425
I will check this locally.

@skitt also seems like we don't run subctl verify-connectivity on globalnet enabled

Ok, I updated the patch to the right shipyard ref, hopefully should pass now :)


apko-build: update to apko 0.3.1 image

duplicated by #55

oh whoops, my bad!  I'd have stamped if I'd seen it!


When trigger is added to the [Bug Report] form value type verification, the required rule verification can not pass

Element UI version
1.4.10
OS/Browsers version
win10/chrome 55
Vue version
2.5.7
Reproduction Link
https://jsfiddle.net/wukon/s0fuq8j4/
Steps to reproduce
表单中有两个字段,age 和 age2,
age中的rule没有trigger
age2中的rule中包含trigger
当文本框中填入数字后,第一个验证通过,第二个提示"请输入排序号"
What is Expected?
rule中设置trigger 不影响number类型的验证
What is actually happening?
rule中设置trigger:"blur"时,输入数值的时候,required判断条件验证失败.

Duplicate of #8386


Friday 07-07-2023 roll call

Roll Call!
Leave a comment with these two things:

A summary of your study using only emojis
Something you'd like to share, anything goes! (within respect)

emoji cheat sheet

good morning

Good morning

Present!!

Good morning

Good morning :)

Good Morning

hi

MORNING

present

present

Good morning!

good morning

present


How to retrieve secrets from keepass vault with folders (groups)

Is there any way to browse the hierarchy of keepass folders/groups with this module.
I have secrets that have identical name, but are in different folders.
any idea how to reach them?
Something like this:

Been a while since I've worked on this module but I thought I added a setting that enables secrets to be referenced by their full path.

Hi,
I did some digging and there is this hash parameter it seems that can help with what I need:
ShowFullTitle
Is there a list of supported parameters and their purpose documented somewhere?
thanks

Probably only in code at the moment if it's not in the main README :)


Proxy release 2024-08-14

Proxy release 2024-08-14
Please merge this Pull Request using 'Create a merge commit' button

Relevant changes:

https://github.com/neondatabase/neon/pull/8654 (already merge in release branch)
https://github.com/neondatabase/neon/pull/8718


InputBag get can return other types than string.

The following code
(string) $request->query->get('foo');
(string) $request->request->get('bar');

Is giving errors RedundantCastGivenDocblockType.
In this PR, return type of get was changed from string|null to string|int|float|bool|null
https://github.com/symfony/symfony/commit/381a0a19f741da314dff99fc64cc75d674fc7beb#diff-94e19ba3b933d919da3a23761ecef19e001863c18676880231d420d60fa6a142R28
So this stub need to be updated
https://github.com/psalm/psalm-plugin-symfony/blob/master/src/Stubs/5/InputBag.stubphp
Seems like you introduced it @seferov ; do you agree ?
If I understand correctly the template, it need to be updated from
@template D of string|null
@psalm-param D $default
@psalm-return string|D

to
@template D of string|int|float|bool|null
@psalm-param D $default
@psalm-return string|int|float|bool|D

@VincentLanglet thanks for the report. Yes, stubs needs to be updates as you suggested.

Done https://github.com/psalm/psalm-plugin-symfony/pull/200


Append underscore to envPrefix

Fixes parsing env vars
Before, it wasn't actually reading env vars like MAXSCALE_EXPORTER_ADDRESS as described in the documentation but env vars like MAXSCALE_EXPORTERADDRESS instead. This fixes that.

Thanks so much, every little bit helps! ❤ I'll roll out a new patch release once I get back from the holidays. 👍

Made a new release, dockerfile was already built automagically. :ok_hand: Thanks again for the help!


Add persistent-volume-storage.md to installation/configuration

The 3 PRs you’ve opened are included in https://deploy-preview-1573--fluxcd.netlify.app/flux/installation/configuration/vertical-scaling/


gitflow: merge v12/develop to v12/main

Describe your changes
merge v12 develop to main with release of 12.0.1 of @brandingbrand/code-cli
Test Plan
verify merge
Checklist before requesting a review

[x] A self-review of my code has been completed
[ ] Tests have been added / updated if required
[ ] Documentation has been updated to reflect these changes

@UncleClapton can you approve this since we published and want main to represent published.


Example not working

When i try the example code (without any Modification) i only get the following error at the serial monitor:
rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:1184
load:0x40078000,len:13232
load:0x40080400,len:3028
entry 0x400805e4
[   287][E][Preferences.cpp:503] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[   287][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
[   296][E][Preferences.cpp:503] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[   299][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
[   807][E][Preferences.cpp:503] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[   807][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
[  1311][E][Preferences.cpp:503] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[  1312][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
[  1815][E][Preferences.cpp:503] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[  1816][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
[  2319][E][Preferences.cpp:503] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[  2320][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
...
Any Hint where to search ?

What exactly is not working?
These errors are expected when no pairing data is present.
Put the Nuki device in pairing mode and these errors will disappear.

I have a Nuki 2.0 and a Nuki 3.0 but none of them "in binding" mode will change this behavior :-(

You should enable debug logging using the Arduino/ESP-IDF settings in whatever build system you are using to compile and define appropriate debug vars.
Might be better to start from a working implementation such as nuki hub (complex) or esphome_nuki_lock (basic)

"nuki hub" is much too complex, would me need to strip down nearly all beside the NUKI plain connect part. "esphome_nuki_lock" is even a big framework (behindESPHome) , that's why i directly choose NukiBleEsp32 as start for a own project.
Just need some basic functions like lock, unlock, unlatch but have to merge it with another framework as soon as i got the nuki function itself running.
I simply download a zip from here, extracted it, opened it in VSCode/PlatfomIO, build the example and uploaded it (to different ESP32 Wroom Boards with 4MB Flash) with the result i showed above.
As quickcheck i downloaded and build and uploaded "nuki hub" only to check if the locks and the ESP32 Hardware is working as expected.
It runs out of the box !!!
I never used debugging on a ESP32 (beside Serial) so no clue at the moment to to debug this problem. Not sure how to continue now.

Here are serial two output in debug build:  (cut from long serial output)

snip ###########################################
Nuki V2 was in bind mode:
...
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
[457396][E][Preferences.cpp:526] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[457407][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
I NimBLEScan: New advertiser: 68:52:c9:e0:fc:53
D NimBLEScan: erase device: 68:52:c9:e0:fc:53
[457423][D][NukiBle.cpp:136] pairNuki(): No nuki in pairing mode found
[457429][D][NukiBle.cpp:141] pairNuki(): pairing result 0
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
I NimBLEScan: New advertiser: 4b:cd:31:99:9a:24
D NimBLEScan: erase device: 4b:cd:31:99:9a:24
I NimBLEScan: New advertiser: 54:d2:72:f7:4b:e4
I NimBLEAdvertisedDevice: No service data found    **************************
D NimBLEScan: erase device: 54:d2:72:f7:4b:e4
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: 68:52:c9:e0:fc:53
D NimBLEScan: erase device: 68:52:c9:e0:fc:53
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
I NimBLEScan: New advertiser: 54:d2:72:f7:4b:e4
I NimBLEAdvertisedDevice: No service data found    **************************
D NimBLEScan: erase device: 54:d2:72:f7:4b:e4
I NimBLEScan: New advertiser: 4b:cd:31:99:9a:24
D NimBLEScan: erase device: 4b:cd:31:99:9a:24
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
I NimBLEScan: New advertiser: 59:cd:10:72:3c:ae
D NimBLEScan: erase device: 59:cd:10:72:3c:ae
I NimBLEScan: New advertiser: d4:9d:c0:bd:28:57
D NimBLEScan: erase device: d4:9d:c0:bd:28:57
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: ee:a0:32:0f:fe:e5
D NimBLEScan: erase device: ee:a0:32:0f:fe:e5
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
[457935][E][Preferences.cpp:526] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
I NimBLEScan: New advertiser: 54:d2:72:f7:4b:e4
I NimBLEAdvertisedDevice: No service data found    **************************
D NimBLEScan: erase device: 54:d2:72:f7:4b:e4
I NimBLEScan: New advertiser: d4:9d:c0:bd:28:57
D NimBLEScan: erase device: d4:9d:c0:bd:28:57
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
[457985][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
[457992][D][NukiBle.cpp:136] pairNuki(): No nuki in pairing mode found
[457998][D][NukiBle.cpp:141] pairNuki(): pairing result 0
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
I NimBLEScan: New advertiser: 4b:cd:31:99:9a:24
D NimBLEScan: erase device: 4b:cd:31:99:9a:24
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: 59:cd:10:72:3c:ae
D NimBLEScan: erase device: 59:cd:10:72:3c:ae
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
I NimBLEScan: New advertiser: d4:9d:c0:bd:28:57
D NimBLEScan: erase device: d4:9d:c0:bd:28:57
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
I NimBLEScan: New advertiser: 54:d2:72:f7:4b:e4
I NimBLEAdvertisedDevice: No service data found    **************************
D NimBLEScan: erase device: 54:d2:72:f7:4b:e4
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
...

snip ###########################################
Nuki V2 left bind mode:
...
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
I NimBLEScan: New advertiser: 59:cd:10:72:3c:ae
D NimBLEScan: erase device: 59:cd:10:72:3c:ae
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
[550236][E][Preferences.cpp:526] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[550244][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
I NimBLEScan: New advertiser: 4b:cd:31:99:9a:24
D NimBLEScan: erase device: 4b:cd:31:99:9a:24
[550260][D][NukiBle.cpp:136] pairNuki(): No nuki in pairing mode found
[550266][D][NukiBle.cpp:141] pairNuki(): pairing result 0
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
I NimBLEScan: New advertiser: 4b:cd:31:99:9a:24
D NimBLEScan: erase device: 4b:cd:31:99:9a:24
I NimBLEScan: New advertiser: d4:9d:c0:bd:28:57
D NimBLEScan: erase device: d4:9d:c0:bd:28:57
I NimBLEScan: New advertiser: ee:a0:32:0f:fe:e5
D NimBLEScan: erase device: ee:a0:32:0f:fe:e5
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: ee:a0:32:0f:fe:e5
D NimBLEScan: erase device: ee:a0:32:0f:fe:e5
I NimBLEScan: New advertiser: 68:52:c9:e0:fc:53
D NimBLEScan: erase device: 68:52:c9:e0:fc:53
I NimBLEScan: New advertiser: d4:9d:c0:bd:28:57
D NimBLEScan: erase device: d4:9d:c0:bd:28:57
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
I NimBLEScan: New advertiser: 59:cd:10:72:3c:ae
D NimBLEScan: erase device: 59:cd:10:72:3c:ae
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
[550772][E][Preferences.cpp:526] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[550782][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
I NimBLEScan: New advertiser: 4b:cd:31:99:9a:24
D NimBLEScan: erase device: 4b:cd:31:99:9a:24
[550798][D][NukiBle.cpp:136] pairNuki(): No nuki in pairing mode found
[550804][D][NukiBle.cpp:141] pairNuki(): pairing result 0
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: ee:a0:32:0f:fe:e5
D NimBLEScan: erase device: ee:a0:32:0f:fe:e5
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
I NimBLEScan: New advertiser: 54:d2:72:f7:4b:e4
D NimBLEScan: erase device: 54:d2:72:f7:4b:e4
I NimBLEScan: New advertiser: 68:52:c9:e0:fc:53
D NimBLEScan: erase device: 68:52:c9:e0:fc:53
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
I NimBLEScan: New advertiser: 59:cd:10:72:3c:ae
D NimBLEScan: erase device: 59:cd:10:72:3c:ae
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: 4b:cd:31:99:9a:24
D NimBLEScan: erase device: 4b:cd:31:99:9a:24
I NimBLEScan: New advertiser: 2f:d3:87:77:9f:aa
D NimBLEScan: erase device: 2f:d3:87:77:9f:aa
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
...

So if the lock is in binding mode then it looks like this: (and 54:d2:72:f7:4b:e4 appears more often than if not in binding mode)
I NimBLEScan: New advertiser: 54:d2:72:f7:4b:e4
I NimBLEAdvertisedDevice: No service data found
D NimBLEScan: erase device: 54:d2:72:f7:4b:e4
If the lock is not in binding mode then it looks like that
I NimBLEScan: New advertiser: 54:d2:72:f7:4b:e4
D NimBLEScan: erase device: 54:d2:72:f7:4b:e4

I now installed a fresh VSCode with fresh installed PlatformIO .
Again downloaded "https://github.com/I-Connect/NukiBleEsp32/archive/refs/heads/main.zip" and built the example in debug mode.
Result is the same
This was my last hope that i had done something wrong  :-(

Below is a serial output from the powerup, a Nuki V3 was in bind mode, so the typical
"NimBLEAdvertisedDevice: No service data found" was there.
I marked it with "******************"
I tracked down the message "No service data found" in sourcecode "NimBLEAdvertisedDevice.cpp"
there in ~line 345 at " if(bytes == uuidBytes && NimBLEUUID(field->value, bytes, false) == uuid) {"
the comparison between "NimBLEUUID(field->value, bytes, false)" and "uuid" always fails.
Where bytes and uuidBytes are always  "24"
I still think that something is wrong or missing in the example code.
Please Help
##########################################
rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:4604
ho 0 tail 12 room 4
load:0x40078000,len:15468
load:0x40080400,len:4
ho 8 tail 4 room 4
load:0x40080404,len:3180
entry 0x400805b8
[     8][D][esp32-hal-cpu.c:264] setCpuFrequencyMhz(): PLL: 480 / 2 = 240 Mhz, APB: 80000000 Hz
=========== Before Setup Start ===========
Chip Info:
Model             : ESP32
Package           : D0WD-Q5
Revision          : 100
Cores             : 2
CPU Frequency     : 240 MHz
XTAL Frequency    : 40 MHz
Features Bitfield : 0x00000032
Embedded Flash    : No
Embedded PSRAM    : No
2.4GHz WiFi       : Yes
Classic BT        : Yes
BT Low Energy     : Yes
IEEE 802.15.4     : No
INTERNAL Memory Info:
Total Size        :   278744 B ( 272.2 KB)
Free Bytes        :   247528 B ( 241.7 KB)
Allocated Bytes   :    25736 B (  25.1 KB)
Minimum Free Bytes:   242492 B ( 236.8 KB)
Largest Free Block:   110580 B ( 108.0 KB)
Flash Info:
Chip Size         :  4194304 B (4 MB)
Block Size        :    65536 B (  64.0 KB)
Sector Size       :     4096 B (   4.0 KB)
Page Size         :      256 B (   0.2 KB)
Bus Speed         : 40 MHz
Bus Mode          : DIO
Partitions Info:
            nvs : addr: 0x00009000, size:    20.0 KB, type: DATA, subtype: NVS
        otadata : addr: 0x0000E000, size:     8.0 KB, type: DATA, subtype: OTA
           app0 : addr: 0x00010000, size:  1280.0 KB, type:  APP, subtype: OTA_0
           app1 : addr: 0x00150000, size:  1280.0 KB, type:  APP, subtype: OTA_1
         spiffs : addr: 0x00290000, size:  1408.0 KB, type: DATA, subtype: SPIFFS
       coredump : addr: 0x003F0000, size:    64.0 KB, type: DATA, subtype: COREDUMP

Software Info:
Compile Date/Time : Sep 26 2024 03:20:02
ESP-IDF Version   : v5.1.4-586-gb6b4727c58-dirty
Arduino Version   : 3.0.4
Board Info:
Arduino Board     : Espressif ESP-WROVER-KIT
Arduino Variant   : esp32
Core Debug Level  : 4
Arduino Runs Core : 1
Arduino Events on : 1
CDC On Boot       : 0
============ Before Setup End ============
[   517][D][NukiSmartlockTest.h:177] setup(): Starting NUKI BLE...
I NimBLEDevice: BLE Host Task Started
I NimBLEDevice: NimBle host synced.
[  1790][E][Preferences.cpp:526] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[  1799][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
=========== After Setup Start ============
INTERNAL Memory Info:
Total Size        :   294192 B ( 287.3 KB)
Free Bytes        :   226532 B ( 221.2 KB)
Allocated Bytes   :    60576 B (  59.2 KB)
Minimum Free Bytes:   226360 B ( 221.1 KB)
Largest Free Block:   110580 B ( 108.0 KB)
GPIO Info:
GPIO : BUS_TYPE[bus/unit][chan]
 1 : UART_TX[0]
 3 : UART_RX[0]

============ After Setup End =============
D NimBLEScan: >> start: duration=0
D NimBLEScan: << start()
[  2385][E][Preferences.cpp:526] getBytesLength(): nvs_get_blob len fail: bleAddress NOT_FOUND
[  2395][E][NukiBle.cpp:939] retrieveCredentials(): Error getting data from NVS
[  2403][D][NukiBle.cpp:136] pairNuki(): No nuki in pairing mode found
[  2409][D][NukiBle.cpp:141] pairNuki(): pairing result 0
I NimBLEScan: New advertiser: 61:27:2d:e6:22:f5
D NimBLEScan: erase device: 61:27:2d:e6:22:f5
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: d4:9d:c0:bd:28:57
D NimBLEScan: erase device: d4:9d:c0:bd:28:57
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
I NimBLEScan: New advertiser: 7a:37:7c:96:60:8e
D NimBLEScan: erase device: 7a:37:7c:96:60:8e
I NimBLEScan: New advertiser: 58:1e:85:76:76:03
D NimBLEScan: erase device: 58:1e:85:76:76:03
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: 54:d2:72:4e:3c:dd
I NimBLEAdvertisedDevice: No service data found  ******************
D NimBLEScan: erase device: 54:d2:72:4e:3c:dd
I NimBLEScan: New advertiser: 53:1e:0e:1f:01:f2
D NimBLEScan: erase device: 53:1e:0e:1f:01:f2
I NimBLEScan: New advertiser: cb:17:a6:a6:85:83
D NimBLEScan: erase device: cb:17:a6:a6:85:83
I NimBLEScan: New advertiser: 6b:ce:69:3e:48:6c
D NimBLEScan: erase device: 6b:ce:69:3e:48:6c
I NimBLEScan: New advertiser: 70:2a:d5:ff:9d:91
D NimBLEScan: erase device: 70:2a:d5:ff:9d:91
I NimBLEScan: New advertiser: ca:9c:54:9d:a8:5a
D NimBLEScan: erase device: ca:9c:54:9d:a8:5a
I NimBLEScan: New advertiser: 61:27:2d:e6:22:f5
D NimBLEScan: erase device: 61:27:2d:e6:22:f5

Finally found this older issue ( https://github.com/I-Connect/NukiBleEsp32/issues/38 )
That gave the hint to a specific branch "pair-and-unpair-refactor"  ( https://github.com/I-Connect/NukiBleEsp32/tree/pair-and-unpair-refactor )
I tried it and this one immediatly worked out of the box !!!

NEWS !!!
by comparing
https://github.com/I-Connect/NukiBleEsp32/tree/pair-and-unpair-refactor
with
https://github.com/I-Connect/NukiBleEsp32/archive/refs/heads/main.zip
I tracked down the binding problem to only a couple of lines where the UUIDs are defined.
Its all about NukiLock.cpp at the very beginning:
NukiLock::NukiLock(const std::string& deviceName, const uint32_t deviceId)
  : NukiBle(deviceName,
            deviceId,
            keyturnerPairingServiceUUID,
            keyturnerServiceUUID,
            keyturnerGdioUUID,
            keyturnerUserDataUUID,
            deviceName) {
    errorCode = (uint8_t)ErrorCode::ERROR_UNKNOWN;
}

If i change this to:
NukiLock::NukiLock(const std::string& deviceName, const uint32_t deviceId)
  : NukiBle(deviceName,
            deviceId,
            NimBLEUUID("a92ee100-5501-11e4-916c-0800200c9a66"),
            NimBLEUUID("a92ee200-5501-11e4-916c-0800200c9a66"),
            NimBLEUUID("a92ee101-5501-11e4-916c-0800200c9a66"),
            NimBLEUUID("a92ee202-5501-11e4-916c-0800200c9a66"),
            deviceName) {
    errorCode = (uint8_t)ErrorCode::ERROR_UNKNOWN;
}

then binding works as it should  !!!

I have no explanation why this makes a difference, both should create identical NimBLEUUID objects. Could you add some debug output inside NukiBle.cpp for testing, to see if there's a difference. The NimBLEUUID class has a toString() method you can use. Both ways should have identical output.

No, as far i could find, both create different NimBLEUUID objects.
I tried to output the UUID in a readable way, but even with .toString i only had partly success, so i dumped the object byte by byte as hex char now.

For a test i changed the following:
in Nukilock.cpp
NukiLock::NukiLock(const std::string& deviceName, const uint32_t deviceId, const NimBLEUUID PairingServiceUUID, const NimBLEUUID ServiceUUID, const NimBLEUUID GdioUUID, const NimBLEUUID UserDataUUID)   : NukiBle(deviceName,             deviceId,             PairingServiceUUID,             ServiceUUID,             GdioUUID,             UserDataUUID,             deviceName) {     errorCode = (uint8_t)ErrorCode::ERROR_UNKNOWN; }
in Nukilock.h
NukiLock(const std::string& deviceName, const uint32_t deviceId, const NimBLEUUID PairingServiceUUID, const NimBLEUUID ServiceUUID, const NimBLEUUID GdioUUID, const NimBLEUUID UserDataUUID);
and in NukiSmartlockTest.h  (-> main.cpp)
NukiLock::NukiLock nukiLock(deviceName, deviceId, NukiLock::keyturnerPairingServiceUUID, NukiLock::keyturnerServiceUUID, NukiLock::keyturnerGdioUUID, NukiLock::keyturnerUserDataUUID);
This will even work then.
For me it looks like as if at the time when the child object NukiLock" is created from "NukiBle" ( see "NukiLock.cpp NukiLock.h")  the NimBLEUUID object was not already evaluated.

Strange, I can't really make sense of it, I'll have to think about it.


Getting a work from a bnumber

(assuming for now b number is still the driver - #4468)

Goobi calls DDS with b number
DDS' internal identifier is this b number
DDS.old goes to Sierra with this b number to get  bibliographic info
This includes archives which are in Sierra from CALM

DDS.new needs to get bibliographic info from the catalogue API.
Catalogue API knows about bnumbers: https://api.wellcomecollection.org/catalogue/v2/works?include=identifiers
But what's the best way to get a work from the catalogue API, given its b number?
e.g., from b16699178 get https://api.wellcomecollection.org/catalogue/v2/works/a2262ru9?include=identifiers,items,subjects,genres,contributors,production,notes,collection
This needs to be able to retrieve CALM-origin works too, from a b number.

The catalogue api should support being able to search by identifier. Ping @jamesgorrie

You can query for a b number it, e.g.
https://api.wellcomecollection.org/catalogue/v2/works?query=BNUMBER&include=identifiers

There was talk of adding a filter for identifiers for the item requesting service, but I don't think that was ever implemented, and it's not in the docs: https://developers.wellcomecollection.org/catalogue/v2/works/getworks

There was talk of adding a filter for identifiers for the item requesting service, but I don't think that was ever implemented, and it's not in the docs: https://developers.wellcomecollection.org/catalogue/v2/works/getworks

It's not, but we probably should support that.

https://api.wellcomecollection.org/catalogue/v2/works?query=b14658197
This returns 8 results; one of them is I think the "right" one at https://wellcomecollection.org/works/nydjbrr7
How do I know which result is the source of descriptive metadata for the digitised item that Goobi processed as b14658197 ? They all have b14658197 in their identifiers.
nydjbrr7 is the only one that has a workType k.
Need to establish a rule set for all workTypes, disambiguation etc. I can see that nydjbrr7 is the one that points back to the IIIF Manifest, so that's one way (even if it appears dangerously circular) - but at what point in workflow does that appear in the catalogue API? If this were the info to match on, it would need to be there by the time Goobi first tells the DDS about the b number.
(btw connecting the IIIF resources to the X-Rays of the painting here would be awesome).

Not sure about the bigger question; the preferred way to look up a work by identifier is https://api.wellcomecollection.org/catalogue/v2/works?identifiers=b14658197
That does a Boolean filter rather than a query, so returns slightly faster and is kinder to our index!

Always be kind to indexes. One day, it might be your index.

I can see that nydjbrr7 is the one that points back to the IIIF Manifest, so that's one way (even if it appears dangerously circular) - but at what point in workflow does that appear in the catalogue API?

It’s pretty variable. It goes something like:

Goobi creates a bag, asks for an ingest in the storage service

The storage service unpacks the bag, makes all the copies it needs

When the bag is done, the storage service simultaneously:

makes a callback to Goobi to say “bag was successfully stored”
tells the catalogue pipeline about the new bag

The catalogue pipeline then spins for some indeterminate amount of time, and the digitised image eventually appears in the catalogue API

The catalogue API is eventually consistent, but I don't think we have any guarantees on how long updates take to propagate.

Little bit more info on picking the work I am interested in.
Of the 8 results returned for https://api.wellcomecollection.org/catalogue/v2/works?identifiers=b14658197&include=identifiers, the one I should pick, nydjbrr7, is the only one without a Miro Identifier. It only has a Sierra identifier.

(write a test app that tries to acquire one and only one work for each b number currently known to DDS; 0 works or > 1 works are fails).

The questions above are now moot as only one result is returned for an explicit b number query. This can be closed.


File.open creates blocking io for character devices

When File is used to access a character devise it results in a blocking IO.
If the same path/fd is used directly to create a IO::FileDescriptor it results in a non-blocking IO
path = "/dev/ttyUSB0"
mode = "r+"

f1 = File.open(path, mode)
pp! f1.blocking # => true

fd = Crystal::System::File.open(path, mode, File::DEFAULT_CREATE_PERMISSIONS)
f2 = IO::FileDescriptor.new(fd)
pp! f2.blocking # => false

The behaviour of File is due to https://github.com/crystal-lang/crystal/blob/0.35.1/src/file.cr#L112
While the behaviour of IO::FileDescriptor is due to https://github.com/crystal-lang/crystal/blob/0.35.1/src/io/file_descriptor.cr#L21-L22
In the code of FileDescriptor the non-blocking applies to socket and pipes as well. Yet sockets are explicitly created as non-blocking here and Pipes blocking is defined on creation here.
It's not big deal since in the code above we can do f1.blocking = false.
I'm not sure if all character devises should be treated as non-blocking by default, from the code in IO::FileDescriptor it seems it should and if so, File should honor that.

I remember @waj said that files in the OS are always blocking so it doesn't make sense to have File be non-blocking. However, in general file descriptors should be non-blocking by default.
Alternatively, maybe force choosing blocking/non-blocking when creating a file descriptor, though because Crystal is non-blocking by default it makes sense to have them be non-blocking.
In summary, my opinion is that there's no change needed here.


Create educadventista.txt

Pull Request to add new university

@nibiroo Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

You can provide us with any of the following as the proof:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@nibiroo You might miss my previous comment. Please react.

@nibiroo I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


I have fixed the modal and now it looks good

I have Fixed the UI of the Modal and Functionality of the Moadal
Before:-

After:-

Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!

THAT MODAL WAS FIXED BY ME I THINK THERE HAS BEEN SOME MISTAKE


[Tests] Add tests for creating urlRequest from updated task structure.

These aren't perfect, but I think this is good enough for now. Should cover most of current behaviors if not all of them.

Codecov Report

Merging #1241 into 9.0.0-dev will increase coverage by 1.8%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           9.0.0-dev    #1241     +/-   ##
============================================
+ Coverage      79.24%   81.04%   +1.8%
============================================
  Files             24       24
  Lines            766      765      -1
============================================
+ Hits             607      620     +13
+ Misses           159      145     -14

Impacted Files
Coverage Δ

Sources/RxMoya/Single+Response.swift
100% <ø> (ø)
:arrow_up:

Sources/Moya/Endpoint.swift
92.3% <100%> (+26.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e20dc51...ba2b333. Read the comment docs.

          3 Warnings

:warning:
Any changes to library code should be reflected in the Changelog. Please consider adding a note there.

:warning:
Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

:warning:
The Cartfile or Cartfile.resolved was updated, but there were no changes in the podspec. Did you forget updating the podspec?

SwiftLint found issues
Warnings

File
Line
Reason

Single+Response.swift
9
Lines should not have trailing whitespace.

Single+Response.swift
15
Lines should not have trailing whitespace.

  Generated by :no_entry_sign: Danger


refactor: [M3-6399] - MUI v5 - Components > TabbedPanel, ReachTab, ReachTabList

Description 📝
Migrate styles for the TabbedPanel, ReachTab, and ReachTabList components
How to test 🧪
Check the TabbedPanel component around the app for regressions

Actually I just noticed a small regression -- in prod we have this border right beneath the tabs, but on this branch in dark mode, it's not there/visible.

Prod screenshot

I think it's best not to organize the imports for SelectPlanPanel and SelectPlanQuantityPanel as to avoid confusing diffs because @cpathipa has a PR to refactor these files. Let's just touch the specific lines you need and revert the rest.

@jaalah-akamai @HanaXu I think we're good in this case. My PR has new components that replace SelectPlanPanel and SelectPlanQuantityPanel, so technically we shouldn't expect any diffs.

@dwiley-akamai Looks like it had something to do with trying to migrate the ReachTabs component to a styled component. I just undid those changes and left the file as is after running the tss codemod


c-lightning starts, but channels don't show

I run only c-lightning on Raspiblitz 1.7.2 on a classic Raspberry Pi setup.
I think I messed something up with my c-lightning channels trying to back up my channels.
Here is what I did:

I tried running a backup as instructed on https://bitcointalk.org/index.php?topic=5384133.0. It worked fine the first time, created a backup.bkp file on an attached USB
Today I tried creating the backup.bkp file again because I saw it hadn't updated after some channel changes. When I did that, I had forgotten to stop c-lightning before running plugin/backup/backup-cli init --lightning-dir /home/bitcoin/.lightning/bitcoin/ file:///mnt/static-channel-backup-CLN-external/backup/backup.bkp. The backup seemed to run successful.
When I realized my mistake, I redid the backup, this time actually stopping the lightningd service first
Restarting the lingtningd service seemed fine, and sudo service lightningd status says it's active
But now my channels are not showing on the INFO screen. It says "C-LIGHTNING v0.10.2  Not Started | Not Ready Yet | No Data" for a long time already

Can somebody help me fix what I screwed up here? There are a lot of sats in those channels ... I wish I had seen before that backing up is actually a function in the Raspiblitz menus.

run:
config.scripts/cl-plugin.backup.sh on
the backup plugin is running by default and syncs to the SDcard. No need to configure manually.

Thanks. I just ran that command. But the Info screen still says "C-LIGHTNING v0.10.2   Not Started | Not Ready Yet | No Data"
Anything else I need to do to get the channels/funds back?

run:
sudo systemctl restart lightningd
see the logs in the SYSTEM menu and check:
sudo journalctl -fu lightningd -n 30

Hm, lots of "FAILURE" on the log:
...
May 10 17:53:21 raspberrypi systemd[1]: lightningd.service: Failed with result 'exit-code'.
May 10 17:53:21 raspberrypi systemd[1]: lightningd.service: Consumed 3.106s CPU time.
May 10 17:53:51 raspberrypi systemd[1]: lightningd.service: Scheduled restart job, restart counter is at 1.
May 10 17:53:51 raspberrypi systemd[1]: Stopped c-lightning daemon on mainnet.
May 10 17:53:51 raspberrypi systemd[1]: lightningd.service: Consumed 3.106s CPU time.
May 10 17:53:51 raspberrypi systemd[1]: Starting c-lightning daemon on mainnet...
May 10 17:53:51 raspberrypi systemd[1]: Started c-lightning daemon on mainnet.
May 10 17:53:53 raspberrypi sh[1611233]: Could not initialize the plugins, see above for details.
May 10 17:53:53 raspberrypi systemd[1]: lightningd.service: Main process exited, code=exited, status=1/FAILURE
May 10 17:53:53 raspberrypi systemd[1]: lightningd.service: Failed with result 'exit-code'.
May 10 17:53:53 raspberrypi systemd[1]: lightningd.service: Consumed 3.161s CPU time.
May 10 17:54:23 raspberrypi systemd[1]: lightningd.service: Scheduled restart job, restart counter is at 2.
May 10 17:54:23 raspberrypi systemd[1]: Stopped c-lightning daemon on mainnet.
May 10 17:54:23 raspberrypi systemd[1]: lightningd.service: Consumed 3.161s CPU time.
May 10 17:54:23 raspberrypi systemd[1]: Starting c-lightning daemon on mainnet...
May 10 17:54:24 raspberrypi systemd[1]: Started c-lightning daemon on mainnet.
May 10 17:54:26 raspberrypi sh[1614561]: Could not initialize the plugins, see above for details.
May 10 17:54:26 raspberrypi systemd[1]: lightningd.service: Main process exited, code=exited, status=1/FAILURE
May 10 17:54:26 raspberrypi systemd[1]: lightningd.service: Failed with result 'exit-code'.
May 10 17:54:26 raspberrypi systemd[1]: lightningd.service: Consumed 3.199s CPU time.

I hadn't known that there is already a backup function in Raspiblitz. I had thought I must install some backup mechanism, so I followed https://bitcointalk.org/index.php?topic=5384133.0.
Relevant to your question, I followed these instructions:
"Add plugin to lightningd.conf config file.
nano /home/bitcoin/.lightning/bitcoin/lightningd.conf
Simply add a new line with:
important-plugin=/home/bitcoin/plugins/backup/backup.py"
Should I remove that line again and run any more commands?

"Add plugin to lightningd.conf config file.
nano /home/bitcoin/.lightning/bitcoin/lightningd.conf
Simply add a new line with:
important-plugin=/home/bitcoin/plugins/backup/backup.py"

delete this whole file and restart lightningd.
The config file on the raspiblitz is:
/home/bitcoin/.lightning/bitcoin/config

Yes, it worked, THANK YOU!
One more question about backups:
Does Raspiblitz automatically back up channels in c-lightning or do I have to do anything manually?
I saw there is a backup entry on CL > REPAIR-CL > BACKUP. Do I have to trigger this occasionally (at a channel change?)

As above, the backup plugin does continously save to the SDcard. There is no intermittent backup option like the SCB in LND.

See the backup file - which can be restored manually only for now - in
/home/bitcoin/

One more minor problem: The channels are visible and functioning in RTL or on the terminal. But the small monitor on the Raspiblitz itself still shows "C-LIGHTNING v0.10.2 Not Started | Not Ready Yet | No Data" -- while the INFO screen from the main menu, however, shows the channels as usual
I tried rebooting, but that didn't fix it.
How can I get the monitor on the Raspiblitz to update, too?


Rev: removing redundant changes to the input sources in example.

Details https://github.com/RobinTail/express-zod-api/commit/d9e78de38b87bd87c62ff210fce85261eb5a5c4b#commitcomment-136000661

coverage: 100.0%. remained the same
when pulling 78f45d444af61cc699f76cdacf222a12b04180be on fix-red-input-source-changes
into c4e113d409c48fc5edd4b0074a8a5442bdb14a9a on master.


nested BATCH_SIZE    --per_device_train_batch_size should be always 1

There is a nested batches in the forward(), while only the first ['image'][0] and ['text_input'][0] are encoded.

https://huggingface.co/internlm/internlm-xcomposer2d5-7b/blob/4aa81f2bbf20a9ddd4137dfe847c142adf07b652/modeling_internlm_xcomposer2.py#L443
This line pre-assumes that the batch_per_gpu is 1
                image = samples['image'][0]


pretrained models for batch normalized version of vgg

According to here we should be able to reuse the retrained weight from e.g. vgg16 and apply them to vgg16bn we will just need to write a small conversion (as order in features differs due to additional nn.BatchNorm2d layers).
Do you agree? Are PR welcome on this?

I don't think you can take the weights from the model without batch norm and stick them in the model with batch normalization. The activation statistics will almost certainly be wrong at each batch-normalized layer if someone tries fine-tuning the model or otherwise continue training.

Could we then also offer pretained weights for the batch normalized versions?

+1 for the request.


Added postgres package

Moved postgres specific files to postgres package. Changes in files of postgres package to access functions() and variables from internal package.

@googlebot I fixed it.


Remove the rasa chat widget

Is your feature request related to a problem? Please describe.
The chat widget is hidden and the next version of it will be based on OMoS. So we don't need to keep the rasa code around.
Describe the solution you'd like
We can remove the ChatBotWidget and connected code.
Describe alternatives you've considered
Just leave it in since it's not used anywhere so the tree shaking is keeping it out of our production builds anyway.

No changes in salt needed, as already done in: https://git.tuerantuer.org/DF/salt/pulls/45


It was not possible to find any compatible framework version The specified framework 'Microsoft.NETCore.App', version '2.1.6' was not found

Describe the bug
Following this guide I am unable to do the first scaffolding step due to the error below
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core '2.1.403'
Run this code 'dotnet new webapp --auth Individual -o WebApp1' and then dotnet aspnet-codegenerator identity -dc WebApp1.Data.ApplicationDbContext --files "Account.Register;Account.Login;Account.Logout"
See error:

It was not possible to find any compatible framework version The specified framework 'Microsoft.NETCore.App', version '2.1.6' was not found. - Check application dependencies and target a framework version installed at: C:\Program Files\dotnet - Installing .NET Core prerequisites might help resolve this problem: http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409 - The .NET Core framework and SDK can be installed from: https://aka.ms/dotnet-download - The following versions are installed: 1.0.1 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 1.0.4 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 1.0.5 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 1.0.13 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 1.1.0 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 1.1.1 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 1.1.2 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 1.1.10 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 2.0.6 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 2.0.9 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 2.1.0-preview1-26216-03 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 2.1.4 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 2.1.5 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

Expected behavior
A few pages should be scaffolded
Additional context
dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   2.1.403
 Commit:    04e15494b6

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17134
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.403\

Host (useful for support):
  Version: 2.1.5
  Commit:  290303f510

.NET Core SDKs installed:
  1.0.0-preview2-003131 [C:\Program Files\dotnet\sdk]
  1.0.0-preview2-1-003177 [C:\Program Files\dotnet\sdk]
  1.0.0-preview4-004233 [C:\Program Files\dotnet\sdk]
  1.0.3 [C:\Program Files\dotnet\sdk]
  1.0.4 [C:\Program Files\dotnet\sdk]
  1.1.11 [C:\Program Files\dotnet\sdk]
  2.1.103 [C:\Program Files\dotnet\sdk]
  2.1.104 [C:\Program Files\dotnet\sdk]
  2.1.200-preview-007517 [C:\Program Files\dotnet\sdk]
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.300-preview1-008174 [C:\Program Files\dotnet\sdk]
  2.1.402 [C:\Program Files\dotnet\sdk]
  2.1.403 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.0-preview1-final [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.0-preview1-final [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 1.0.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.0.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.0.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.0.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.0-preview1-26216-03 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

csproj file:
<PropertyGroup>
  <TargetFramework>netcoreapp2.1</TargetFramework>
  <UserSecretsId>aspnet-SocFace-D83867AE-294A-4562-B8D7-10674D5B4C05</UserSecretsId>
</PropertyGroup>

<ItemGroup>
  <None Update="app.db" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>

<ItemGroup>
  <PackageReference Include="Microsoft.AspNetCore.App" />
  <PackageReference Include="Microsoft.AspNetCore.Razor.Design" Version="2.1.2" PrivateAssets="All" />
  <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="2.1.4" />
  <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="2.1.5" PrivateAssets="All" />
</ItemGroup>

The .NET Core framework and SDK can be installed from: https://aka.ms/dotnet-download

Did you download and install .NET Core 2.1.6?

I cant find the sdk for .Net core 2.1.6 , all the links i am seeing is 2.1.5

Closing as I believe this issue is resolved when you install the latest .NET Core SDK or runtimes.


Rollback model loading to match the code from the paper

This code fixes bad perplexity that was found with the following config
CUDA_VISIBLE_DEVICES=3 OMP_NUM_THREADS=16 MKL_NUM_THREADS=16 python main.py decapoda-research/llama-7b-hf custom --custom_data_path data/red_pajama_n=1024.pth --nsamples 128 --wbits 3 --perchannel --percdamp 1.0 --groupsize 16 --qq_scale_bits 3 --qq_zero_bits 3 --qq_groupsize 64 --outlier_threshold=0.7 --permutation_order act_order
... and with all dependency versions set by requirements.txt
p.s. kind thanks to the authors (esp. @Godofnothing @Vahe1994 ) for helping me figure out what was causing the problem

@Vahe1994 i'm re-running the main config now, results will be available in 40-ish minutes
Would you like me to run any additional tests to make sure this PR does not introduce more bugs?

@Vahe1994 i'm re-running the main config now, results will be available in 40-ish minutes
Would you like me to run any additional tests to make sure this PR does not introduce more bugs?

I think your experiments are sufficient.

I tried to reproduce the problem fixed here. It appeared that t it was coming from omission of this code:
    if dtype == "auto":
        dtype = AutoConfig.from_pretrained(model_path).torch_dtype or "auto"  # force transformers 4.29.2 to follow the same rules as 4.30.x

which was still necessary to keep while we still tested code using transformers==4.29.2


Transform to convert template strings to document calls

Unfortunately bel doesn't work with hyperxify but I think we could write a transform that goes even further.
Where it converts:
var title = 'hello'
var element = bel`<div><h1>${title}</h1></div>`

into:
var title = 'hello'
var element = (function (p1) {
  var e0 = document.createElement('div')
  var e1 = document.createElement('h1')
  var t0 = document.createTextNode(p1)
  e1.appendChild(t0)
  e0.appendChild(e1)
  return e0
}(title))

Then we support older browsers and get a significant performance boost.
We could move the hyperx function into it's own library that outputs this stack. In here, it create elements. In the transform, it would create javascript strings.

Done! https://github.com/shama/yo-yoify
Brings the perf from ~23ms per loop to ~17ms per loop and could get a bit more efficient (I was just taking too long to finish it). It also makes this all compatible with older browsers.

:rocket:


build tar file from Folder without to save it.

Is it possible to build a tar-file recursively from a Folder without to save it.
I currently use the Builder with  .append_dir_all().
In my use case I only need the byte vector of the tar-file to work with this.

If someone is looking for the solution here it is:
the function compress all files in a given folder path and return a Vec<u8>
fn compress(input_path: &PathBuf) -> anyhow::Result<Vec<u8>, io::Error> {
    let encoder = GzEncoder::new(Vec::new(), Compression::fast());
    let mut tar = tar::Builder::new(encoder);
    tar.append_dir_all(".", &input_path)?;
    let encoder_data: GzEncoder<Vec<u8>> = tar.into_inner()?;
    let compress_vec: Vec<u8> = encoder_data.finish()?;
    Ok(compress_vec)
}


SQL keywords auto uppercased when writing comments

DBeaver Version: 21.1.1
E.g., I wrote the comment "item exists in BOM" and it was auto capitalized like so:
-- item EXISTS IN BOM

thank you for the report
duplicates #5994


Jobserver fifo

Recent GNU make versions support opening a fifo path instead of using passed filedescriptor numbers. This simplifies using the jobserver functionality in build systems like openembedded.
These two patches are cherry-picked from https://github.com/ninja-build/ninja/pull/2263 while skipping the patches adding joberserver master support.
A few simple conflicts were resolved in the test file while cherry-picking.

@bradking Can you take a look on this, or ping someone who can?

@hundeboll thanks.  In general we don't accept pull requests directly to this fork.  It exists only to stage upstream PRs that haven't been merged there yet.  This PR is toward that goal, but I'd like to avoid cherry-picking if possible.  When I get a chance I'll look through the current state of the relevant upstream PRs to see if I can rebuild our fork.


Update visualiser to handle BODS 0.4 data

BODS 0.4 has now been released (branch | docs | changelog).
The visualiser now needs to be able to parse and render BODS 0.4 data. (While retaining the ability to parse and render BODS 0.2, and BODS 0.3 data).
Test and example data can be found in the repo. See the Example Data docs page for some context for some example data.

The first step of this work is for @codemacabre to understand differences between data versions so the visualiser accommodates them. Then to select changes needed to be added, or accommodated. (All fitting within the refactored framework coming out of #24.)


WIP [ibm_mq] Filter by PREDEFINED queues

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] Feature or bugfix must have tests
[ ] Git history must be clean
[ ] If PR adds a configuration option, it must be added to the configuration file.

superseded by https://github.com/DataDog/integrations-core/pull/3977


ui knows about aws resources

npm run deploy:dev
cd packages/ui && cp .env.development.example .env.development
Copy values from /stack-outputs.json into .env.development
cd packages/ui && npm run dev

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bugfix for ISAMv5.3.1

CMAQv5.3.1-i3:
Date: 2020-01-23
Contact: Sergey Napelenok<EMAIL_ADDRESS>Description
CMAQ version 5.3.1 release included an inadvertently modified version of EMIS_DEFN.F causing crashes during compiling.
Scope and Impact
The model did not compile with the -Disam option with errors pointing to EMIS_DEFN.F
Solution

Option 1: Replace CCTM/src/emis/emis/EMIS_DEFN.F in repository with the version located in the folder DOCS/Known_Issues/CMAQv5.3.1-i3. Directions on how to replace this file in your repository can be found in Appendix F of the CMAQ User's Guide.
Option 2: The code fix to EMIS_DEFN.F was merged into the master branch on 1/23/2020. You can download the updated v5.3.1 source code from this link: https://github.com/USEPA/CMAQ/archive/master.zip, or use git commands to update your current repository.

Resolved with v5.3.1.


Thanks!


BigQuery client running into DEADLINE_EXCEEDED

Hey there,
I am running into an issue with the BigQuery client for Node.js. I am trying to read a larger number of rows, convert them and store them elsewhere. I tried using query streams both for table (which has a fixed bug missing a release) and job. Both either result in OOM or DEADLINE_EXCEEDED quickly.
Therefore I switched to a paginated query using this: https://cloud.google.com/nodejs/docs/reference/bigquery/1.3.x/Job#getQueryResults
However after a larger six figure number of rows I still ran into this error message:
{"stack":"Error: 4 DEADLINE_EXCEEDED: Deadline Exceeded\n    at Object.exports.createStatusError (/usr/src/app/node_modules/grpc/src/common.js:87:15)\n    at Object.onReceiveStatus (/usr/src/app/node_modules/grpc/src/client_interceptors.js:1188:28)\n    at InterceptingListener._callNext (/usr/src/app/node_modules/grpc/src/client_interceptors.js:564:42)\n    at InterceptingListener.onReceiveStatus (/usr/src/app/node_modules/grpc/src/client_interceptors.js:614:8)\n    at callback (/usr/src/app/node_modules/grpc/src/client_interceptors.js:841:24)","message":"4 DEADLINE_EXCEEDED: Deadline Exceeded","code":4,"metadata":{"_internal_repr":{}},"details":"Deadline Exceeded"}
So far I have not been able to find a way to set the deadline myself. Is there any way to get around this issue or set the deadline for the BigQuery client?
Thanks!
Environment details

OS: Debian
Node.js version: 9.11.1
npm version: 5
@google-cloud/bigquery version: 1.3.0

Steps to reproduce

Select a large enough table with more than a million rows.
Create a job with a simple query resulting in a million rows.
Process the rows with automatic pagination using node to store them in another DB.
Wait for DEADLINE_EXCEEDED.

@holgeradam please try upgrading to<EMAIL_ADDRESS>The latest release fixed the issue which might very well caused the OOM issue.

I think we can assume this one is resolved now, but let me know if closing is a mistake.


faction chats

Hi,
How can we read faction chats? In parser only allComm :(

tab can be 'all', 'faction', 'alerts' for fetch_msg(self, mints=-1, maxts=-1, reverse=False, tab='all')
This is my fault, I'll add more informations to my codes soon.


WIP: Feature/convert to web extension

Hello!
This is a pull request for issue #22.
Please note that it's still in progress (the necessary changes for converting SAML tracer to a Web Extension are way more substantial than I thought in the first place ;-)
Anyways, I thought opening this pull request would be a good idea to get some early feedback. Maybe my effort is going in the wrong direction? Hence I really appreciate any comments!
Some parts may be a bit hacky. Please tell me, if there's something inacceptable.
What's still on my todo-list:

pretty up the yet only functional UI
make the export/import functionality work (this seems to be quite effortful) to be done in another pull request
use the strings from the locale-files to be done in another pull request
fix incorrect request count (see here)
tidy up everything
spend time with "minor" things that aren't on my list yet ;-)

Hi Thjis! I'm looking forward to your response!
Well, I think the import/export feature isn't more complex than other parts. It just seems to be the last "big" thing for me to convert. But I'll see... there still might be some other things which seem "small" but may take some time, too 😉

I've given it a try and it works quite fine already!
I did notice that AuthnRequests seem to be missing from my SAML tracer window. The GET request rows are there, but show the wrong URL (referrer?) and have no SAML label next to them. If you look at the request details. the GET request does seem to be to the right host.

Where did you experience that behaviour?
As an example I tried to login to https://foodl.org using "Universität Hohenheim" as IdP. This seems to work:

If I go to Foodl and select my IdP SURFnet I get the following:

Right above the first green coloured line, there's three identical black lines. However, the bottom two of those are GET requests to respectively engine.surfconext.nl and idp.surfnet.nl and they both have a SAML AuthnRequest parameter.

Thank you for the details. I will look after it the next days.

Sorry for the late response. You're absolutely right, Thijs. Good catch!
The reason for this behavior is that the webRequest API keeps a request's ID if it's a redirect. Hence results were overwritten.
I have an idea to work around this, but it'll take some more days 😉

Hi,
have to say it works more-than-enough-well-for-me™ to probably replace the now missing add-on in Firefox v57... what additional fixes (the duplicate URLs/missing SAML tag problem reported by Thijskh?) would it need to merge the PR, build a new release, and publish it again?
Jose.
note: I can live without import/export, or a non-translated add-on... and those are minor problems IMO compared to not having it...

Hello there!
Thijs' findings should be fixed with the latest commits.
In theory I'd now go on with the import/export. But as @lonoak suggested it'd be nice to have SAML Tracer back as a compatible extension soon. So I could put a little effort in prettifying the UI and deliver the other features with subsequent pull requests.
Maybe @jaimeperez or @olavmrk could tell what they'd prefer?

Yes, if it was up to me I'd definitely prefer to have something that has basic functionality uploaded now, than the situation that we have and that is that there is nothing. And then release updated versions to complete the rest. Hope @jaimeperez or @olavmrk can help with getting it published at Mozilla.

I agree too. It's better to have it out with basic functionality rather than waiting to have everything in place (especially given that import/export is something rarely used).
We can definitely help releasing it and submitting the package to Mozilla.

I've tested some more and indeed it works better now. Two items stand out:
When I start the latest master, the window is completely blank until I right-click it.
Try logging in to https://wiki.surfnet.nl (top-right) with the tracer open. Then click one of the IdP's. The authnrequest to engine.surfconext.nl is shown, but the subsequent authnrequest to the IdP does not show.

Thanks again, Thijs!
I was able to reproduce the blank-problem on my linux machine. It doesn't occur on my windows machine. I think this behavior started with FF57, right? I'll look for the cause - and for a fix ;-) - on the weekend.
Your second finding seems to be related to accessing some undefined objects. I'll look for that on the weekend, too! :-)

So far, I focused on your second finding. Unfortunately, when it comes to redirects, it seems as if the webRequest-API behaves differently form the way browsers behave... The subsequent request vanishes, because the webRequest-API handles it as a POST although the browser issues a GET...
Errors occur hereafter, because undefined members are invoked, since the request is no real POST and therefore has no postdata etc.
I described this unexpected behaviour in a Stackoverflow question. Maybe someone has an idea...

From what I found out yet, the webRequest-API seems to act way more RFC-compliant than modern browsers do...
Anyways, we need a way to let SAML Tracer imitate the browsers' special-302-treatment. The webRequest-API allows several things to be modified. Although this doesn't include the method directly, maybe the redirectUrl-property could be "abused" to achieve this:

...initiated by a redirect action use the original request method for the redirect, with one exception: If the redirect is initiated at the onHeadersReceived stage, then the redirect will be issued using the GET method.

That's exactly what's necessary. But somehow it seems quite dirty 😆

A valid point indeed about whether the HTTP status codes are correct, but indeed one would assume that in any case the reported behaviour of the API is identical to the actual behaviour of the browser...

Wondering if the 'Web Developers' tool -> Network makes use of this API. At least it seems to handle redirections correctly:

Forget about my previous comment... unless firefox uses internally this API itself. I hadn't read your post to StackOverflow... :(

With commit a0ca642 I now applied the workaround described here.
I'm still not quite sure if I feel comfortable with this, but for the moment it seems to work ;-)

By now the most severe issue should be solved.
The blank-page-problem unfortunately still exists, when using SAML tracer on Linux. I have no real clue yet.
But I think the new UI looks quite nice. I tried to give it a developer menu look. What do you think?

So what's still on my list:

fix the blank-page-problem
tidy up everything (remove old code fragments, update readme, ...)

All other issues should be fixed with subsequent pull requests.

Hi, @khlr thanks a ton for your efforts on this. I wanted to add that I did some testing on Ubuntu 16.04 with  Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0 .
I can verify the issue with the blank screen until the first right click and I would like to suggest marking the selected line in resources somehow so that it is obvious which request the user is looking at. I will open this as an issue in due time.
Thanks again for making this usable in Quantum

Thanks for your feedback, Ioannis!
What I noticed while debugging is that there's  an error occurring on Linux machines that doesn't show up on Windows machines:

TypeError: invalid 'in' operand browser[Learn More]  tabbrowser.xml:2426:1

I'll continue my investigations in this direction.

Here's a c;lue:
https://issues.adblockplus.org/ticket/5817#no1

Hi @khlr, I've given it some more tests and it works very well for me! Also like the improved layout. Impressive work.
The Linux display bug is indeed still there but I could live with it even if it was not fixed in the first upload: this is already much better than we have now. I would be very much in favour of uploading the extension to Mozilla (with or without Linux display fix) in the short term…

Thanks for the hint, @tvdijen! But unfortunately the fix suggested there doesn't seem to work in our case. At least I'm not able to catch the exception.
Meanwhile I found other error reports of this kind, too. It's believed to be a Firefox bug.
So for the moment I think it's a good idea to not spend further time in this and fix this later.
Thank you for your feedback, @thijskh!
I'm looking forward to uploading the extension to Mozilla in the near future, too!
Presumably tomorrow I'll have some more time to highlight the selected request row and tidy up the codebase.

If I did not miss anything (which I probably have 😉), the pull request is finished from what I think.
What's still to do with future pull requests:

re-introduce the import/export feature
re-introduce localization

And additionally very useful:

update the build script (if necessary)
provide a more appropriate extension icon

@jaimeperez, could you please review the changes and then submit the extension to Mozilla? I think it's just you and @olavmrk who are able to upload updated versions of the extension, aren't you?
Aprospos "new version": Do you create something like a release branch or should I increase the version number directly in this pull request. 0.4.0 to 0.5.0?

Thanks so much for this @khlr! This is an impressive piece of work!
Since we haven't been doing much development on the SAML tracer, I think it's perfectly fine to just merge it into master and tag it with 0.5.0. One could argue that there are enough changes to justify a new major, but on the other hand there's functionality that's been lost, so I'm not sure this deserves a major.
In any case, I'm running really tight on time these days, so I don't think I'll be able to test and review in the near future. Since I don't want to delay this, maybe @thijskh can give the code a review?
I don't know either if the build script will work any longer. If it just works ™ it should be simple for me to build and upload the new release, but if it doesn't, I'm not sure I'll have time to fix it myself...

build.sh probably needs to be updated, not to create a .xpi but a .zip. Maybe just git archive --format zip suffices...

I've tested it and it works for me, as others have also confirmed above. A review did not turn up any real problems. Good to see that most of the actual SAML-specific code has been reused.
@jaimeperez I think that dropping functionality is per definition a new major? In any case increasing the major version seems appropriate for such a fundamental change. Building it for upload is trivial as far as I understand. So let's go for it?
Our remaining wishlist item is restoring import/export... seems ideal for a next iteration after this has been submitted?

:+1:  from me for a new major

Great, thanks a lot for taking the time to review, Thijs!
I've merged and uploaded a new 1.0 release, which is now pending review. Good work everybody!

... and there it was approved and published! That was fast! 🎉

And it is working perfectly, I already tested it 🥇
Thank you so much!

Thanks a lot @khlr!

Magnificent work @khlr , much appreciated !

It really works well, @khlr! Thanks for your work, and thanks Jaime for re-publishing it quick!

Great work everyone involved! I've really been missing this in my day-to-day work...
One tiny comment: When I click somewhere in the SAML and press ctrl-A (something I do kinda often because I want to copy the ticket somewhere) not only the SAML is marked but also the entire list of calls, I'm quite sure the behaviour was different in the old version. Anything that's easy to change?

Thank you all for your support and your feedback. It was my pleasure! 🤗
@danielmalmgren, would you mind creating a new issue for your finding?


picosdk-c-examples not finding symbols

Setup

Example filename: ps4000aStreaming.cpp
IDE/Compiler being used: See Info below, Visual Studio 2017
Pico Technology device model: PicoScope 4824
Driver name, version number and platform (32/64-bit): Precision 5530, 64bit
Operating system:  Microsoft Windows 10 Enterprise, OS:10.0.16299
USB port type	(e.g. 2.0): 3.1

Microsoft Visual Studio Community 2017
Version 15.8.5
VisualStudio.15.Release/15.8.5+28010.2036
Microsoft .NET Framework
Version 4.7.02556
Installed Version: Community
Visual C++ 2017   00369-60000-00001-AA109
Microsoft Visual C++ 2017
ASP.NET and Web Tools 2017   15.8.05085.0
ASP.NET and Web Tools 2017
C# Tools   2.9.0-beta8-63208-01
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
JavaScript Language Service   2.0
JavaScript Language Service
Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines
Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers
Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards
Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package
MLGen Package Extension   1.0
MLGen Package Visual Studio Extension Detailed Info
NuGet Package Manager   4.6.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.
ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info
Test Adapter for Boost.Test   1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test.  The use terms and Third Party Notices are available in the extension installation directory.
Test Adapter for Google Test   1.0
Enables Visual Studio's testing tools with unit tests written for Google Test.  The use terms and Third Party Notices are available in the extension installation directory.
Visual Basic Tools   2.9.0-beta8-63208-01
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio
Visual Studio Tools for CMake   1.0
Visual Studio Tools for CMake
Description
I can get the software to compile, then I am able to build the solution, but when I execute it, this is what I get.   :
'ReStreaming.exe' (Win32): Loaded 'C:\Users\kv993\source\repos\ReStreaming\x64\Debug\ReStreaming.exe'. Symbols loaded.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\ntdll.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\kernel32.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\KernelBase.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Program Files\Pico Technology\SDK\lib\ps4000a.dll'. Module was built without symbols.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\setupapi.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\msvcrt.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\cfgmgr32.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\ucrtbase.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\rpcrt4.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\user32.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\win32u.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\gdi32.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\gdi32full.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\msvcp_win.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\shell32.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\SHCore.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\combase.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\bcryptprimitives.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\windows.storage.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\advapi32.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\sechost.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\shlwapi.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\kernel.appcore.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\powrprof.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\profapi.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\vcruntime140d.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\ucrtbased.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\version.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_5.82.16299.665_none_887c2a984ab8b351\comctl32.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\imm32.dll'. Cannot find or open the PDB file.
The thread 0x1b68 has exited with code 0 (0x0).
'ReStreaming.exe' (Win32): Loaded 'C:\Program Files\Pico Technology\SDK\lib\picoipp.dll'. Module was built without symbols.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\uxtheme.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\msctf.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\oleaut32.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\dwmapi.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\devobj.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\wintrust.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\msasn1.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\crypt32.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\TextInputFramework.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\CoreMessaging.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\CoreUIComponents.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\WinTypes.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\WinTypes.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\ntmarta.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Unloaded 'C:\Windows\System32\WinTypes.dll'
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\winusb.dll'. Cannot find or open the PDB file.
'ReStreaming.exe' (Win32): Unloaded 'C:\Windows\System32\winusb.dll'
'ReStreaming.exe' (Win32): Loaded 'C:\Windows\System32\ole32.dll'. Cannot find or open the PDB file.
The thread 0x397c has exited with code 0 (0x0).
The thread 0x38d8 has exited with code -1073741510 (0xc000013a).
The thread 0x144c has exited with code -1073741510 (0xc000013a).
The thread 0xc44 has exited with code -1073741510 (0xc000013a).
The thread 0xd7c has exited with code -1073741510 (0xc000013a).
The thread 0x3260 has exited with code -1073741510 (0xc000013a).
The thread 0x4e8 has exited with code -1073741510 (0xc000013a).
The thread 0x33f8 has exited with code -1073741749 (0xc000004b).
The program '[1876] ReStreaming.exe' has exited with code -1073741510 (0xc000013a).
Steps to reproduce the issue
Use one of two methods to describe the issue:

A list of steps to reproduce the issue.
A natural language description of what you were doing when the issue occurred if you are unable to work out what the steps are.

Actual Result
Expected Result
Notes
The main point is that it is telling me that the
'ReStreaming.exe' (Win32): Loaded 'C:\Program Files\Pico Technology\SDK\lib\ps4000a.dll'. Module was built without symbols.
and
'ReStreaming.exe' (Win32): Loaded 'C:\Program Files\Pico Technology\SDK\lib\picoipp.dll'. Module was built without symbols.
I have been working this and it keeps coming down to these issues as my root problem.
Downloaded the source and installed the SDK last week.  I was very specific about getting the 64bit version.
Robert
<EMAIL_ADDRESS>

@CumminsBob, which version of the PicoSDK have you installed?


RuntimeError in relation ranking's train step

Hi, When I was training the relation ranking model, the error code shows as follow:
Traceback (most recent call last):
  File "train.py", line 109, in <module>
    pos_score, neg_score = model(batch)
  File "/usr/local/lib/python3.5/dist-packages/torch/nn/modules/module.py", line 491, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/model.py", line 213, in forward
    pos_score1 = self.cal_score(outputs, seq_len, pos_rel1_embed, neg_size)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/model.py", line 115, in cal_score
    seq_att, weight = self.question_attention.forward(rel_embed, outputs)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/attention.py", line 54, in forward
    weight = self.attention(x, seq, lengths)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/attention.py", line 40, in attention
    score = self._score(x, seq)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/attention.py", line 108, in _score
    _seq = self.pack_seq(seq)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/attention.py", line 81, in pack_seq
    return seq.view(seq.size(0) * seq.size(1), -1)
RuntimeError: invalid argument 2: View size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces). Call .contiguous() before .view(). at /pytorch/aten/src/THC/generic/THCTensor.c:276

And the messages before the error shows as follow:
Note: You are using GPU for training
load word vocab, size: 63112
load relation vocab, size: 2
load train data, batch_num: 1131	batch_size: 64
load valid data, batch_num: 163	batch_size: 64
Namespace(batch_size=64, birnn=True, channel_size=8, clip_gradient=0.6, conv_kernel_1=3, conv_kernel_2=3, cuda=True, d_hidden=128, d_rel_embed=256, d_word_embed=300, dev=False, dev_every=600, dropout_prob=0.3, epochs=30, fix_emb=True, gpu=0, log_every=100, loss_margin=1.0, lr=0.0005, n_cells=4, n_layers=2, neg_size=50, patience=5, pool_kernel_1=21, pool_kernel_2=1, predict=False, rel_maxlen=17, rel_vocab_file='../vocab/vocab.rel.sep.pt', results_path='results', resume_snapshot=None, rnn_type='gru', save_every=4500, save_path='saved_checkpoints', seed=1111, seq_maxlen=21, test=False, test_file='data/test.relation_ranking.pt', train_file='data/train.relation_ranking.pt', trained_model='', valid_file='data/valid.relation_ranking.pt', vector_cache='/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/../input_vectors.pt', vocab_file='../vocab/vocab.word&rel.pt', word_normalize=False, word_vectors='../vocab/glove.42B.300d.txt', write_res=False, write_score=False)
Shift model to GPU
word_embed.emb_luts.0.weight torch.Size([63112, 300])
rel1_embed.emb_luts.0.weight torch.Size([3523, 256])
rel2_embed.emb_luts.0.weight torch.Size([4658, 256])
rnn.weight_ih_l0 torch.Size([384, 300])
rnn.weight_hh_l0 torch.Size([384, 128])
rnn.bias_ih_l0 torch.Size([384])
rnn.bias_hh_l0 torch.Size([384])
rnn.weight_ih_l0_reverse torch.Size([384, 300])
rnn.weight_hh_l0_reverse torch.Size([384, 128])
rnn.bias_ih_l0_reverse torch.Size([384])
rnn.bias_hh_l0_reverse torch.Size([384])
rnn.weight_ih_l1 torch.Size([384, 256])
rnn.weight_hh_l1 torch.Size([384, 128])
rnn.bias_ih_l1 torch.Size([384])
rnn.bias_hh_l1 torch.Size([384])
rnn.weight_ih_l1_reverse torch.Size([384, 256])
rnn.weight_hh_l1_reverse torch.Size([384, 128])
rnn.bias_ih_l1_reverse torch.Size([384])
rnn.bias_hh_l1_reverse torch.Size([384])
question_attention.layer.layer1.weight torch.Size([256, 512])
question_attention.layer.layer2.weight torch.Size([1, 256])
bilinear.weight torch.Size([1, 256, 256])
seq_out.1.weight torch.Size([256, 256])
seq_out.1.bias torch.Size([256])
conv.0.weight torch.Size([8, 1, 3, 3])
conv.0.bias torch.Size([8])
fc.0.weight torch.Size([20, 136])
fc.0.bias torch.Size([20])
fc.3.weight torch.Size([1, 20])
fc.3.bias torch.Size([1])
fc1.0.weight torch.Size([20, 168])
fc1.0.bias torch.Size([20])
fc1.3.weight torch.Size([1, 20])
fc1.3.bias torch.Size([1])
fc2.0.weight torch.Size([1, 4])
fc2.0.bias torch.Size([1])
  Time Epoch Iteration Progress    (%Epoch)   Loss       Accuracy  Dev/Accuracy
Traceback (most recent call last):
  File "train.py", line 109, in <module>
    pos_score, neg_score = model(batch)
  File "/usr/local/lib/python3.5/dist-packages/torch/nn/modules/module.py", line 491, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/model.py", line 213, in forward
    pos_score1 = self.cal_score(outputs, seq_len, pos_rel1_embed, neg_size)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/model.py", line 115, in cal_score
    seq_att, weight = self.question_attention.forward(rel_embed, outputs)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/attention.py", line 54, in forward
    weight = self.attention(x, seq, lengths)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/attention.py", line 40, in attention
    score = self._score(x, seq)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/attention.py", line 108, in _score
    _seq = self.pack_seq(seq)
  File "/home/xxs344/lx/kbqa-ar-smcnn/relation_ranking/attention.py", line 81, in pack_seq
    return seq.view(seq.size(0) * seq.size(1), -1)
RuntimeError: invalid argument 2: View size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces). Call .contiguous() before .view(). at /pytorch/aten/src/THC/generic/THCTensor.c:276

And training and predicting steps for entity detection model worked well.
Any help will be greatly appreciated!

@lixiang1991 I have the same problem, Did you find a solution?

@lixiang1991 change
return seq.view(seq.size(0) * seq.size(1), -1)

into
return seq.contiguous().view(seq.size(0) * seq.size(1), -1)

you can fix this bug to go to the next bug

@lixiang1991 it works now

@nlpjoe you are right! Thanks!
it really works

@nlpjoe do you mean that the next bug is at this code?
stride1 = 1.0 * max_len1 / len1_one
stride2 = 1.0 * max_len2 / len2_one

I fix it by change into:
stride1 = 1.0 * max_len1 / len1_one.item()
stride2 = 1.0 * max_len2 / len2_one.item()

And there is an another bug in the predict.py:
pred_rel_scores = sorted(zip(neg_rel, neg_score), key=lambda i:i[1], reverse=True)

I fix it by change into:
if neg_score.size==1:
        pred_rel_scores =(neg_rel[0],neg_score.item())
    else:
        pred_rel_scores = sorted(zip(neg_rel, neg_score), key=lambda i:i[1], reverse=True)

hello guy, my final result on FB2M is 76.7,much worse than the 77.9 in the paper, how about you?
my result is below:
load test data, batch_num: 20679	batch_size: 1
test	accuracy: 76.713724	correct: 15813	total: 20613
rel_acc:  90.06852766300514 17875 19846
recall:  89.97279048674795 17856 19846
single_acc:  75.19399375188955 14923 19846


Failing to connect to GitHub

Not sure if this step is to blame or the environment. I'm using CocoaPods 1.0.1 on Xcode 8.
fatal: unable to access 'https://github.com/mixpanel/mixpanel-iphone.git/': Failed to connect to github.com port 443: Operation timed out

This is not related to this step, this is a network error. We saw this to happen a couple of times, still investigating what causes it.
I'll close this ticket here, as it's not related to this step, but if you'd have this issue again please feel free to create an issue in the main issue tracker: https://github.com/bitrise-io/bitrise.io


Update README.md file

Update the SRA Board image
Add image of Wall-E bot with OLED
Update Git repo link since the name of repo was changed

The PR looks good to me, @SAtacker could you verify it once

Could you also do a cleanup of https://github.com/SRA-VJTI/Wall-E/tree/readme_update/windows_instructions likewise https://github.com/Jamm02/Wall-E/tree/readme_update/windows_instructions?

@SAtacker This PR already solves it and add extra instructions for better installation.

@SAtacker This PR already solves it and add extra instructions for better installation.

Yup, got it.

LGTM


[#383] Due to a way how RxJava2 handles undeliverable exceptions smal…

…l changes to emitter based observers were required.

I might be wrong but it seems to me that this merged commit is not in the 1.5.0 release, I am wrong ?
Asking because I have the aforementionned issue.

It is, just there were some other minor changes in the code. You can see it in the commit list in the RxJava core PR