Using Carthage -- Realm.framework depends on RealmSwift.framework??

I have a pure Objective-c (no swift) project that I'm trying to install Realm into.  Everything builds fine but running unit tests I get the following:
Library not loaded: @rpath/RealmSwift.framework/Frameworks/Realm.framework/Realm
This is with Realm 0.92.2.

Found the problem.  I am using Carthage and I had to add the RealmSwift.framework to carthage copy-frameworks build phase, but NOT add it to the linked frameworks.

It really shouldn't be necessary to do anything with RealmSwift.framework if you're just using Realm.framework from Carthage. To double-check, I just followed the "Carthage" installation steps listed here with no issue: https://realm.io/docs/objc/latest/#installation
Can you share the steps you took to produce the error?

My steps were similar, but I already had Carthage set up so Framework build dir was already in my framework search path.  I also didn't add the strip frameworks script yet as this will probably never see an app store build, and I wasn't sure if that's still an issue in XCode 6.3 or not.
Here's what I did:
Config

Xcode 6.3.1 / OSX 10.10.3 / iOS 8.1
Follow carthage setup instructions in Carthage github README.md

STR

add realm to Cartfile (0.92.2)
carthage update
link to Realm.framework
Add Realm.framework to carthage copy-frameworks
build (success)
build for test (success)
run unit tests (fail)

Solution:

Add RealmSwift.framework to carthage copy-frameworks phase.
run unit tests (success)


[Engine-1.21] Backport Etcd Drone Fixes

Signed-off-by: Derek Nola<EMAIL_ADDRESS>

Proposed Changes

Lower concurrent number of tests to 3.
Disable sonobuoy parallel testing for etcd, hits the drone runner too hard and causes failures on concurrent tests.

Types of Changes
Drone CI Fixes

Verification
Drone Builds start passing.

Linked Issues
https://github.com/k3s-io/k3s/issues/4886

User-Facing Change

Further Comments

OOD


OSX desktop client does not allow custom port to be specified

Operating System:

[ ] Windows
[ ] Linux/Ubutnu
[x] macOS

Clear steps to reproduce the issue:
On the initial "Add a Zulip organisation" page, enter an url with a custom port, e.g:
https://zulip.example.com:11443

Then click "Connect".
A spinner shows up, the app does not load.
The problem appears to be that the the input form strips away the port number. I'm able to login only after editing ~/Library/Application Support/Zulip/config/domain.json, and manually change the url key from "https://zulip.example.com" to "https://zulip.example.com:11443"

Relevant error messages and/or screenshots:

Port not reflected in the config file

@abhigyank can you look into it since you have worked on the proxy thing?

This is a high-priority issue, since it prevents some users from getting the app up and working.

The problem appears to be that the the input form strips away the port number

I don't think we strip the port since I can add the https://chat.zulip.org:443, the problem seems to be somewhere in the request module.

@ran404 can you please provide more info on this?

@akashnimare I can reproduce this issue with a fresh Zulip instance available on the exact same port, on Mac OS Mojave 10.14.1, but not because of a port issue (see #596).
Test instance is available at https://zulip2.superbiche.co:11443 (no org).
I just created this instance with docker-zulip real quick to try and help fix this issue, but there were no errors related to the port.
To be sure about that, I just added listen *:11444 ssl http2; to the server definition for https://zulip.superbiche.co so that I could try adding https://zulip.superbiche.co:11444, and it worked like a charm (with the fix from #595 indeed).
So I'm pretty sure this is related to #596

Awesome, thanks @superbiche!  I think given your investigation, we can close this as a likely duplicate of #596, fix that, and then hopefully @ran404 can confirm the fix one we've merged the fix for #596.


Speed up selectAll on a buffer with many folded lines

As pointed out on #5791, selecting the whole buffer with many folded lines caused a serious performance degradation. I tracked down the issue to Selection#selectAll trying to unfold those lines which contained the selected buffer range. However, since we know in advance that we're going to select the whole text, we can make the clever assumption that everything would be unfolded anyways, thus calling the faster @editor.unfoldAll (e.g. faster because it simply scans each line one by one, instead of traversing the buffer back and forth for each line in the selection).
So, we go from this:

To this:

(Benchmark performed on benchmark/fixtures/huge.js, on my machine it's 70% faster)
With this change, selectAll on a buffer with many folded lines takes no longer than unfolding everything :racehorse: :racehorse: :racehorse:
Close #5791
/cc: @nathansobo @izuzak

Ideally, I'd like to only expand folds that contain the range we are selecting. But considering that this optimizes the existing behavior, I think we should merge it and revisit the behavior later. :sparkles: work once again @as-cii.

:zap: @as-cii


Additional files cannot be used to set up lspconfig

Problem description
When I write the configuration in the setup_handlers{} method, everything is fine. But when I write this configuration to a file, introduced by the require("file") statement, this configuration does not take effect.
just like this
local status_mason_lspconfig, mason_lspconfig= pcall(require, "mason-lspconfig")
if not status_mason_lspconfig then
  vim.notify("can not find mason-lspconfig")
  return
end
local status_lspconfig, lspconfig= pcall(require, "lspconfig")
if not status_lspconfig then
  vim.notify("can not find lspconfig")
  return
end

local util = require 'lspconfig.util'
root_files = {
    'pyproject.toml',
    'setup.py',
    'setup.cfg',
    'requirements.txt',
    'Pipfile',
    'pyrightconfig.json',
}

ensure_installer = {
    "pyright","sumneko_lua","html"
}

mason_lspconfig.setup({
    ensure_installer,
})
mason_lspconfig.setup_handlers {
    function (server_name) -- default handler (optional)
        lspconfig[server_name].setup {
            capabilities = capabilities,
            on_attach = on_attach,
            flags = {
                debounce_text_changes = 150
            }
        }
    end,
    ["pyright"] = function ()
        --local opts = require("lspconfig.test").config()
        local opts = {
            root_dir = function(fname)
                a = util.root_pattern(unpack(root_files))(fname)
                b = vim.fn.getcwd()
                return a or b
            end,
        }
        lspconfig['pyright'].setup(opts)
    end,
}

Everything is ok.But  when i write config like this
local M = {}
function M.config()
    local util = require 'lspconfig.util'
    local root_files = {
    'pyproject.toml',
    'setup.py',
    'setup.cfg',
    'requirements.txt',
    'Pipfile',
    'pyrightconfig.json',
    }
    root_dir = function(fname)
        a = util.root_pattern(unpack(root_files))(fname)
        b = vim.fn.getcwd()
        return a or b
    end
end
return M

["pyright"] = function ()
        local opts = require("lspconfig.test").config()
        --local opts = {
        --    root_dir = function(fname)
        --        a = util.root_pattern(unpack(root_files))(fname)
        --        b = vim.fn.getcwd()
        --        return a or b
        --    end,
        --}
        lspconfig['pyright'].setup(opts)
    end,

root_dir does not take effect
Why do you think this is an issue with mason-lspconfig.nvim?
i think that there is a problem with the setup process in the config
Neovim version (>= 0.7)
NVIM v0.7.0
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Operating system/version
windows 10
I've manually reviewed the Nvim LPS client log (:LspLog) to find potential errors

[X] Yes

I've recently downloaded the latest plugin version of mason.nvim, mason-lspconfig.nvim, and nvim-lspconfig

[X] Yes

Affected language servers
i think this is all
Steps to reproduce

write the configuration in the setup_handler{}
change it to another file
Introduce the configuration via require()

Actual behavior
The configuration did not take effect
Expected behavior
Configuration is not affected
LspInfo
Client: pyright (id: 2, pid: 8848, bufnr: [6])
 	filetypes:       python
 	autostart:       true
 	root directory:  Running in single file mode.
 	cmd:             cmd.exe /C pyright-langserver --stdio

 Configured servers list: sumneko_lua, pyright, html

LspLog
No response
Healthcheck
mason: require("mason.health").check()
========================================================================
## mason.nvim report
  - OK: neovim version >= 0.7.0
  - WARNING: **Go**: not available
  - WARNING: **cargo**: not available
  - WARNING: **luarocks**: not available
  - WARNING: **Ruby**: not available
  - WARNING: **RubyGem**: not available
  - WARNING: **Composer**: not available
  - WARNING: **PHP**: not available
  - OK: **npm**: `8.11.0`
  - OK: **node**: `v16.15.1
`
  - WARNING: **python3**: not available
  - WARNING: **pip3**: not available
  - WARNING: **javac**: not available
  - OK: **java**: `java version "1.8.0_341"
`
  - WARNING: **julia**: not available
  - ERROR: **wget**: not available
  - OK: **curl**: `curl 7.83.1 (Windows) libcurl/7.83.1 Schannel
`
  - ERROR: **gzip**: not available
  - OK: **tar**: `bsdtar 3.5.2 - libarchive 3.5.2 zlib/1.2.5.f-ipp
`
  - OK: **python**: `Ok`
  - OK: **pip**: `pip 21.2.4 from C:\ProgramData\Miniconda3\lib\site-packages\pip (python 3.9)

`
  - ERROR: GitHub API rate limit exceeded. Used: 60. Remaining: 0. Limit: 60. Reset: 2022/9/7 17:39:23.

Screenshots or recordings
No response

Hello! So this is most likely due to some error in how you've configured things. You need to put your Lua file in a location you can import it from, it seems you're requiring from lspconfig.test. Is the file located in lua/lspconfig/test.lua?

Hello! So this is most likely due to some error in how you've configured things. You need to put your Lua file in a location you can import it from, it seems you're requiring from lspconfig.test. Is the file located in lua/lspconfig/test.lua?

I have checked the file path. From my point of view, there is nothing wrong

It seems like you're not returning anything in the .test() function

It seems like you're not returning anything in the .config() function

Yes, this is also one of my puzzles.I used the lspinstaller before. The configuration file of lspconfig that can be used in the lspinstaller cannot be used in the Mason lspconfig. I modified the configuration file. The configuration file I first used contains the return method, but the returned value is empty. I found that the function methods in the test file will not be executed, such as vim. fn. getcwd().

It seems like you're not returning anything in the .config() function

The previous configuration file is shown below, but it still cannot take effect
local util = require 'lspconfig.util'

local bin_name = 'pyright-langserver'
local cmd = { bin_name, '--stdio' }

if vim.fn.has 'win32' == 1 then
  cmd = { 'cmd.exe', '/C', bin_name, '--stdio' }
end

local root_files = {
  'pyproject.toml',
  'setup.py',
  'setup.cfg',
  'requirements.txt',
  'Pipfile',
  'pyrightconfig.json',
}

local function organize_imports()
  local params = {
    command = 'pyright.organizeimports',
    arguments = { vim.uri_from_bufnr(0) },
  }
  vim.lsp.buf.execute_command(params)
end

return {
  cmd = cmd,
  filetypes = { 'python' },
  root_dir = function(fname)
    a = util.root_pattern(unpack(root_files))(fname)
    b = vim.fn.getcwd()
    return a or b
  end,
  single_file_support = true,
  settings = {
    python = {
      analysis = {
        autoSearchPaths = true,
        useLibraryCodeForTypes = true,
        diagnosticMode = 'workspace',
      },
    },
  },
  commands = {
    PyrightOrganizeImports = {
      organize_imports,
      description = 'Organize Imports',
    },
  },
  docs = {
    description = [[
https://github.com/microsoft/pyright

`pyright`, a static type checker and language server for python
]],
  },
}

Maybe you could revert to what was preciously working for now? I’m afraid I can’t assist with personal configs or general Lua help because I don’t have the capacity to do so


Updated test.html entry point

Updated test.html entry point with message for users to open the js console to see the results of functions executed in the readme.md file. Time & Energy converters is still needed to be added inside the script tag.

Thanks for your commit :)

Glad it helped!


min_version parameter is not used

Describe the bug
Hi Team,
As the docs describing the Fluentd configuration for version 1.0 or above https://docs.fluentd.org/configuration/transport-section,
min_version is a parameter to accept the lowest TLS version. However, we when I included in my template
 <transport tls>
    min_version TLS1_2
    cert_path        /my/cert_path/
    private_key_path /my/private_key_path/
    private_key_passphrase xxxxxxxxx
    ciphers ABCD-SHA: EFGH-SHA
 </transport>

then I restarted td-agent service. The td-agent log showed
2022-01-20 08:20:17 +0000 [warn]: parameter 'min_version' in <transport tls>
  min_version TLS1_2
  cert_path "/my/cert_path/"
  private_key_path "/my/private_key_path/"
  private_key_passphrase xxxxxxxxx
  ciphers "ABCD-SHA: EFGH-SHA"
</transport> is not used.

I am using td-agent 1.2.6. Please help me to check this min_version parameter.
Thank you
To Reproduce
Include min_version in
Expected behavior
I expected min_version should work.
Your Environment
- TD Agent version:
td-agent 1.2.6

- Operating system:
NAME="Ubuntu"
VERSION="18.04.6 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.6 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

- Kernel version:
5.4.0-92-generic

Your Configuration
<transport tls>
    min_version TLS1_2
    cert_path        /my/cert_path/
    private_key_path /my/private_key_path/
    private_key_passphrase xxxxxxxxx
    ciphers ABCD-SHA: EFGH-SHA
 </transport>

Your Error Log
2022-01-20 08:20:17 +0000 [warn]: parameter 'min_version' in <transport tls>
  min_version TLS1_2
  cert_path "/my/cert_path/"
  private_key_path "/my/private_key_path/"
  private_key_passphrase xxxxxxxxx
  ciphers "ABCD-SHA: EFGH-SHA"
</transport> is not used.

Additional context
No response

TD Agent version:
td-agent 1.2.6

It's fluentd's version.
The td-agent version which bundles fluentd-1.2.6 is td-agent-3.2.1.
This version doesn't support min_version due to bundled OpenSSL version.
(I'll describe the detail of it later.)
And td-agent 3 isn't supported anymore: https://www.fluentd.org/blog/schedule-for-td-agent-3-eol
Please use latest td-agent.

td-agent uses Ruby2.4, but Ruby 2.4 doesn't support min_version/max_version:
https://github.com/fluent/fluentd/blob/a60603346483da721799ccb3faebcbdd757c5f16/lib/fluent/tls.rb#L42-L49
So please use version instead.

Hi @ashie
Thank you for your reply.
So is there anything similar parameter or something that we could use to set min version of TLS in the latest td-agent version?

td-agent 4 bundles Ruby 2.7 so that it supports min_version.

Thanks @ashie, Let me try it.


chore: remove one beta_reduce and a porting note

There is one more beta_reduce in this file with a porting note, but removing that one still does not work.

Thanks!
bors merge


Fix subplot saving

Currently, ENSO subplot saving produces images that don't exactly match up with the subplots. Fix to make the images match subplots properly. QBO (#290) also has this problem.

This appears to be the same issue as in #276. However, that issue seems to show titles from all three plots ending up in one saved subplot whereas this issue simply notes that subplot saving appears to save the incorrect subsection of the larger image. In any case, these two issues are likely related.


Update windows-10-1903-removed-features.md

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/3777
Added note.

@nenonix @JohanFreelancer9 Minor copy editing is needed for this PR. Thanks.

@Reeced40 Please follow-up with copy editing suggestions. Thanks.

@greg-lindsay The PR that addresses issue #3777 that has passed copy review is available for review. Thanks.

This note has no bearing on the topic. The topic applies to Windows 10, not Android.


Support for SDL2 outline rendering

This adds support for the SDL2 outline rendering in https://github.com/kivy/kivy/pull/3816
You probably don't want to actually accept this until that PR is merged, but I'm filing it now so I don't forget later.

SDL2 outline rendering was merged in https://github.com/kivy/kivy/pull/4265


Update mirador to 1.4.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as e8aa0b98aa960dadd06448f59fcdf29baf0ca460. Your contribution is still credited to you.


Why do "ignite new " creates ".git" directory?

I tried 2 times to be sure. Why does ignite creates .git directory?

It's the default for new Ignite apps.  You can pass --skip-git to ignite new to skip initializing a git repository, or delete the .git folder if you already started an app.

Git is a powerful (and industry-standard) version control system. It is included by default because the majority of users will want to use it with their app and it's more convenient for it to be done automatically for them. As ruddell mentioned above, you can easily skip git or remove it after you have generated your project.

At this point, I think, it can be safely assumed that most developers already know and use git. This simply adds an additional step to the entire process.
I think that is the point @tayfunyasar was trying to make.
I ran into the same problem because the ignite project was part of a monorepo that contains other projects, and the monorepo is already linked to GitHub. I was unable to add the ignite project, came here, found out that you were adding git by default.
I suppose this helps new developers, like, developers who are new to react and also new to react native and also new to ignite and also new to git. That is a very small intersection on a Venn diagram, in my opinion :)


Support for synchronizing DDL statement

Support for synchronizing DDL statement。 Mysql to Postgres。 Oracle to postgres。

This feature has been completed. Please refer to the PR for more details

This feature has been completed. Please refer to the PR for more detail


Redmine after install dont want start

After install plugin and restart Redmine see error
Details:
undefined method `to_prepare' for ActionDispatch::Callbacks:Class
Did you mean?  to_param (NoMethodError)
General Ruby interpreter information
RUBY_VERSION = 2.3.7
RUBY_PLATFORM = x86_64-linux
RUBY_ENGINE = ruby
RubyGems version = 2.6.14
Redmine 4.1.1

I believe this issue has solved by koledas.
Let me close this issue.


Fix resume pause and resume cluster in TF provider

@adityakaushik99-yb I've changed a small bit of connection pooling code too. Can you please review?


SQL execution support

Please add the ability to execute SQL queries with parameter binding.
Implementation example: https://github.com/zheludkovm/RustyTarantool.

Implemented in version 0.0.7. There is still no documentation, but you can check examples/sql.rs, there is pretty much everything.
Note that by default statements are prepared and cached even if you do not explicitly call prepare_sql, that should provide reasonable performance with just calling execute_sql repeatedly (although it wasn't tested yet). You can disable this behavior by setting Builder::sql_statement_cache_capacity to 0.

Nice!


ImageDecoder+LibGfx: collate decoded bitmaps before sending over IPC

There is an issue (#425) where gifs with many frames cannot be loaded, as each bitmap is sent over IPC using a separate file descriptor, and there is limit on the maximum number of descriptors per IPC message. Thus, trying to load gifs with more than 64 frames (the current limit) causes the image decoder process to die.
This commit introduces the BitmapSequence class, which is a thin wrapper around the type Vector<Optional<NonnullRefPtr<Gfx::Bitmap>>> and provides an IPC encode/decode routine that collates all bitmap data into a single buffer so that only a single file descriptor is required per IPC transfer, even if multiple frames are being sent. This seems to fix the issue with large gifs (at least on my machine).
Right now, I'm using memcpy and pointer math to move data between AnonymousBuffers, which is probably not great for memory safety. If there's a better way of doing this that's more in line with project standards, please let me know.

Didn't #688 fix #425 already?

Doesn't seem so? At least I was still experiencing the issue in #425 locally (as in the image decoder process would die when loading gifs with many frames).

Also, even with the changes in #688, the issue seems to be that the image decoder is trying to send the type Vector<Optional<NonnullRefPtr<Gfx::Bitmap>>> over IPC, which boils down to sending one Gfx::Bitmap per frame, and each Gfx::Bitmap gets serialized as its own file with a file descriptor, which is why so many file descriptors get opened for large gifs.

Thanks for the feedback!

I'm not sure if it makes the most sense to structure it as

[ sequence of metadata ]

[ big blob ]

rather than

[ sequence of

   [ metadata ]

   [ blob for this image ]

]

As far as I can tell, it necessarily has to be the first way, since each blob is encoded as a separate file (with a separate file descriptor). That's why I made it so that the separate blobs get merged into a single blob in order to send over IPC. Also, the existing code is already doing it the second way, which is where the problem stems from.


Extension for @jsep-plugin/arrow

Hi Jakub,
I use filter expressions to search for an entry in an array of objects. Is it possible for you to include the @jsep-plugin/arrow? For example, the Array.find() method can also be used as a filter expression in the array.
Here is a small example:
JSONPath<EMAIL_ADDRESS>&& @.phoneNumbers.find(phoneNumber => phoneNumber.type.match(/iPh.*/)))]
[{     "firstName": "John",     "lastName": "doe",     "age": 26,     "address": {         "streetAddress": "naist street",         "city": "Nara",         "postalCode": "630-0192"     },     "phoneNumbers": [         {             "type": "iPhone",             "number": "0123-4567-8888"         },         {             "type": "home",             "number": "0123-4567-8910"         }     ] }]
Best regards,
Rainer

Hey!
I'm hesitant to support it out of the box as this wouldn't be particularly compatible with other implementations of JSONPath expressions, however, I could expose an option to register custom jsep plugins.
Would that be something matching your needs?

Hi,
actually I have the problem with stoplightio/spectral that my JSONPath is not supported by nimma. If the plugin is generally available, then no adjustments are necessary there. But I can understand your concerns. Your suggestion will help and I can post another feature request at stoplightio/spectral, if the option is available.

@rguttroff I'm not sure if that helps, but I forgot to mention that the JSON Path expression you posted can be somewhat translated into something Nimma understands<EMAIL_ADDRESS>~= "iPh.*")]^^' will yield similar results as the JSON Path expression you posted.

@P0lip Nice. That would work. I still need to partially access a subpath. Here the output path seems to diverge between the solutions. Spectrale also has its difficulties with this. Is this a bug?
Example JSON:
[{
    "firstName": "John",
    "lastName": "doe",
    "age": 26,
    "address": {
        "streetAddress": "naist street",
        "city": "Nara",
        "postalCode": "630-0192"
    },
    "phoneNumbers": [
        {
            "type": "iPhone",
            "number": "0123-4567-8888"
        },
        {
            "type": "home",
            "number": "0123-4567-8910"
        }
    ]
}]

 Filter with .find()   Filter with parent expression

 JSONPath

<EMAIL_ADDRESS>&& @.phoneNumbers.find(phoneNumber => phoneNumber.type.match(/iPh.*/)))]

<EMAIL_ADDRESS>== "iPhone")]^^^.address

 Result

[
  {
    "streetAddress": "naist street",
    "city": "Nara",
    "postalCode": "630-0192"
  }
]

[
  {
    "streetAddress": "naist street",
    "city": "Nara",
    "postalCode": "630-0192"
  }
]

 Output paths

[
  "$[0]['address']"
]

[
  "$['address']"
]

Thanks. It is working.


Tormented demons

Description:
Added Tormented Demons, their CAs and their creatable items to the bot. Also added the While Guthix Sleeps quest to allow the killing of these mobs. The creatable demonbane items from TDs also have various boosts to demon mobs throughout the bot (mostly emberlight)
This PR would need to be added alongside PR #383 on the oldschooljs repo, as it fixes the breaking change of the item update made there (bottom change listed here).
Changes:

Added the While Guthix Sleeps quest, requiring Defender of Varrock and The Path of Glouphrie (alongside various skills).

Added Tormented Demons, alongside their unique drops Tormented Synapse, Burning Claw and Guthixian Temple Teleport. (no use) They are also an alternative option for Greater Demon tasks outside of the wilderness and Konaar.

Added the creatable items Emberlight, Scorching bow, Purging staff and Burning Claws.

Added the Emberlight, Scorching bow and Purging staff to the demonBaneWeapons const, affecting tasks that require using a demonbane weapon.

Gave Emberlight boosts at all demon mobs, Scorching Bow, Purging Staff and Burning Claws only affect TDs (with the exception of Scorching Bow also being BIS at K'ril)

Added 4 Elite and 1 Master Combat Achievement for Tormented Demons.

Minor change to the createable names of the prince and princess outfits made with Frog tokens. (name was changed in an osrs update)

Other checks:

[x] I have tested all my changes thoroughly.

:rocket:
This description was created by Ellipsis for commit fb67da9da2dcd7da14691540ecda55413482ea06

Summary:
Added Tormented Demons, their items, and the While Guthix Sleeps quest, updated demonbane weapons, and adjusted related combat achievements and slayer tasks.
Key points:

Added Tormented Demons and their unique drops (Tormented Synapse, Burning Claw, Guthixian Temple Teleport) in src/lib/minions/data/killableMonsters/chaeldarMonsters.ts.
Introduced While Guthix Sleeps quest in src/lib/minions/data/quests.ts with prerequisites and rewards.
Updated demonBaneWeapons in src/lib/constants.ts to include new items (Emberlight, Scorching bow, Purging staff).
Added new creatable items (Emberlight, Scorching bow, Purging staff, Burning claws) in src/lib/data/creatables/slayer.ts.
Modified combat achievements in src/lib/combat_achievements/elite.ts and src/lib/combat_achievements/master.ts to include Tormented Demons.
Updated slayer tasks in src/lib/slayer/tasks/chaeldarTasks.ts, src/lib/slayer/tasks/duradelTasks.ts, and src/lib/slayer/tasks/nieveTasks.ts to include Tormented Demons.
Adjusted item boosts for various monsters in src/lib/minions/data/killableMonsters/bosses/gwd.ts and src/lib/minions/data/killableMonsters/bosses/misc.ts.
Corrected item names for Frog tokens in src/lib/data/buyables/buyables.ts.

Generated with :heart: by ellipsis.dev

@ellipsis-dev review this PR

I merged your OSJS pr and updated items/osjs, and updated this PR. So if you can pull that merge then test stuff is still good.
Do yarn test:unit -u to fix the unit test failing (if a new cl page or something is added, unit tests may fail, just do that command to fix it)


Update create-complete-managed-instance-indirectly-connected.md

@bweissman : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mikeraymsft
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"

#sign-off

@MikeRayMSFT,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. Thanks.
#label:"aq-pr-triaged"
#assign:@MicrosoftDocs/public-repo-pr-review-team

The following users don't have valid GitHub IDs, or are not collaborators on this repo: microsoftdocs/public-repo-pr-review-team


BookHandler requires $config Property

When running POST to create book, I received an error message
{"error":{"messages":["Undefined property: Api\\Book\\Handler\\BookHandler::$config"]}}

I noticed the the HandlerTrait requires this property, which is present in both the AdminHandler and UserHandler.  I added this to the doc and __construct as below and it resolved the issue.
class BookHandler implements RequestHandlerInterface
{
    use HandlerTrait;

    #[Inject(
        HalResponseFactory::class,
        ResourceGenerator::class,
        BookServiceInterface::class,
        "config",
        )]
        public function __construct(
            protected HalResponseFactory $responseFactory,
            protected ResourceGenerator $resourceGenerator,
            protected BookServiceInterface $bookService,
            protected array $config,
            ) {
        }

Hi @comcduarte ,
Thank you for notify,  indeed that was the problem here.
Between the creation of this tutorial and now the Dotkernel api suffered some major changes and somehow this was forgotten.
In the latest pull request #51  we updated it to reflect the changes.


Don't include : in the port comparison.

This fixes an unexpected CSP error loading hubs.mozilla.org in Servo.

bors r+

Thanks! Could you publish a new version, too?


BUG: Showing Rules on Register page is not Good according to Industry level

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
In Register page, at the bottom there is rules are mentioned for entering valid data., but according to industry the validation form are more prefered. In place of showing all the rules we just add a form validation. It will enhance the quality of the web.
Assign me this issue, I'll be glad to work on that, as i 've already submitted many of the issues and bugs on other projects as a contributor.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

What changes will you make ?


Inconsistent formatting of dates in app

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[ ] Bug is not already reported in another issue
See also https://github.com/corona-warn-app/cwa-app-android/issues/3830

Technical details

Android version: 11
App version: 2.9.0

Describe the bug
The format used to display dates in CWA in numerical format is inconsistent. In some places the user's preference which has been set via the devices locale settings is used, in other places the format is hard-coded to dd.mm.yy or dd.mm.yyyy, with 2-digit and 4-digit year formats being used on the same screen.
With the locale set to English (United States) the following different formats are found:

Section
Format
Example

Certificates - date of birth
dd.mm.yyyy
PersonDetailsFragment_cwa_2.png

Certificates - vaccination
dd.mm.yy
PersonDetailsFragment_cwa_2.png

Certificates - test
dd.mm.yyyy
PersonDetailsFragment_cwa_2.png

Rapid Test Profile - date of birth
dd.mm.yyyy
RATProfileQrCodeFragment.png

PCR Test
dd.mm.yy
HomeFragment_test_positive.png

Contact Journal
mm/dd/yy
ContactDiaryDayFragment_locations_data.png

Steps to reproduce the issue

Settings > System > Languages and input > Languagesset to English (United States)
Settings > System > Date & timeselect "Use locale default"/ disable "Use 24-hour format"
Connect mobile device to Android Studio
In Android Studio Build > Select BuildVariant deviceForTestersDebug
run src/androidTest/java/de/rki/coronawarnapp on emulator
View > Tools Windows > Device File Explorer
Go to /data/data/de.rki.coronawarnapp.test/screenshots
View screenshots and note discrepancies in the way that the date is shown

Expected behavior
The display of dates in numerical format in CWA should be consistent and preferably the locale format should be used.
Possible Fix
Standardize date output across the app.

Internal Tracking ID: EXPOSUREAPP-9127 Android
Internal Tracking ID: EXPOSUREAPP-9220 Design
Internal Tracking ID: EXPOSUREAPP-9238 iOS

iOS:

Section
Format (under Android)
Same as Android?

Certificates - date of birth
dd.mm.yyyy
No - Format is mm/dd/yy

Certificates - vaccination
dd.mm.yy
No - Format is mm/dd/yy

Certificates - test
dd.mm.yyyy
No - Format is mm/dd/yy

Rapid Test Profile - date of birth
dd.mm.yyyy
No - Format is month as abbreviation (e.g Dec for December) dd, yyyy

PCR Test
dd.mm.yy
No mm/dd/yy

Contact Journal
mm/dd/yy
Yes

Additionally:
PCR Test pending: month as abbreviation (e.g Dec for December) dd, yyyy
I noticed way more inconsistencies in the format of dates when the region & language was set to German.
@MikeMcC399 Please decide how you want to continue with this issue? Move to documentation repo or leave it in the Android repo?

@Ein-Tim
Thank you for your notes about iOS. I saw from the screenshots on https://www.coronawarn.app/en/screenshots/ that there are quite some differences between Android and iOS, so I believe it is better to keep the Android and iOS issues separate. If you feel that changes should be made to iOS then I suggest you open a separate iOS issue. You can mention this issue in the iOS one.
I am more concerned with numerical dates like 04.08.21 where especially with English (United States) the month and day are written in a different order e.g. 08/04/21. I am less concerned with months displayed alphabetically like December, where the date is clearly understandable independently of the order of day and month.

@MikeMcC399 Thanks. Internal Tracking ID: EXPOSUREAPP-9127

PR https://github.com/corona-warn-app/cwa-app-android/pull/3987 is now merged into release/2.10.x
@marcauberer
PR https://github.com/corona-warn-app/cwa-app-android/pull/3987 however has introduced a regression concerning inconsistent formatting regarding dates of birth.
The date of birth in PersonDetailsFragment_cwa.png in release 2.10 should use the same order of month day year according to the English (United States) locale which is used in the date of sample on the same screen.
Instead of showing the date of birth as 1981/03/20, it should be shown as 03/20/1981.
I made a note of this in https://github.com/corona-warn-app/cwa-app-android/pull/3987#issuecomment-911518738 but since the PR is merged it may have been overlooked.

PersonDetailsFragment_cwa from release/2.10.x

PersonDetailsFragment_cwa from screenshots 2.8 for comparison. In this version the date formats were fixed and did not use the device's locale settings.

@MikeMcC399 since the internal ticket was closed, it maybe would be better if you could open a new issue for that ...

@marcauberer

since the internal ticket was closed, it maybe would be better if you could open a new issue for that ...

Please see new issue https://github.com/corona-warn-app/cwa-app-android/issues/4014.

Verified fixed
Screenshots which are generated from androidTest from tag/v2.10.1 in Android Studio use consistent date formats with locale set to English (United States).
Screenshots for the released Android version CWA 2.10.1 published to
https://www.coronawarn.app/en/screenshots/#android_screenshots have not all been generated from 2.10.1 (e.g. https://www.coronawarn.app/assets/screenshots/2-10/en/android/check_in_attendee_view_contact_journal.png) or even from Android (e.g. https://www.coronawarn.app/en/screenshots/#android_invalid_certificate) so the screenshots section is not a reliable source to verify this fix without comparing to screenshots generated directly from 2.10.1 Android.
The screenshot PersonDetailsFragment_cwa_2.png which previously showed short (2 digit) and long (4 digit) years on one screen now shows only short years displayed. This is correct.

Closing as fixed! Thanks to @marcauberer!

There is an inconsistency in date formatting in certificates in 2.10.1 with locale set to English (United Kingdom). The problem does not affect English (United States) nor Deutsch (Deutschland).
I will open a separate new issue for this remaining date formatting problem.

New issue https://github.com/corona-warn-app/cwa-app-android/issues/4112 open for the regression of date-of-birth formatting in certificates in version 2.10.1 with locale set to English (United Kingdom).


Token Incentive Design for $TAROT

SecretDecks Stakepool $TAROT needs to attract delegators by offering a good incentive design.

[x] discuss with DisCo
[x] design incentive mechanism
[x] rollout mechanism

https://secretdecks.gitbook.io/arcana/introduction/who-and-what-is-secretdecks/the-stake-pool/tarot-pool-incentive-design

here's the stake key controlling the tokens and sending every 5-7 epochs (manually)
https://cardanoscan.io/stakeKey/ae3acb33548d2b6b1b8ee239849678ed547bb5cdee89ada049f94799


cd: upgrade helm 3.8 -> 3.11 and kubectl 1.23 -> 1.24

K8s 1.25 is out, and we may very well upgrade to it or create a new cluster with it very soon. That makes it relevant to ahead of time upgrade kubectl to version 1.24 so that we can assume based on a k8s official version skew poolicy that kubectl can work against the not yet deployed/upgaded k8s 1.25 cluster.
I think historically we have been held back by k8s clusters versioned 1.21 or older, but now we are at k8s 1.22 and above so we can probably make this upgrade.
I didn't find the reason why we were still using helm 3.8.2, but I recall issues of using something newer at some point. But with all Helm charts upgraded to modern versions and k8s clusters upgraded to 1.22+ I think we can also upgrade helm at this point.
Related

#2293

Thanks for the review @pnasrat and @damianavila!!


Added ability to use certain bluebird functions

Added the .get, .mapSeries, and .delay bluebird functions. The most significant omission from the current release would probably be .get. If you're selecting a single row from the database, it's reasonable to want to just write knex.select().from('users').where({username: 'Jim'}).limit(1).get(0).

This seems to be done on top of your earlier pull request. Is that necessary?

@elhigu Whoops. I'm sorry - I don't make many PRs. I didn't realize that the PR would change when I modified my repo (thought it would be fixed to the hash that the branch was pointing to at the time of PR creation). I'll put these back in place in my repo.


All LSP installs fail with "spawn: npm failed with exit code - and signal -. npm is not executable"

I have the following in my init.lua (using packer):
use {
  'VonHeikemen/lsp-zero.nvim',
  requires = {
    -- LSP Support
    {'neovim/nvim-lspconfig'},
    {'williamboman/mason.nvim'},
    {'williamboman/mason-lspconfig.nvim'},

    -- Autocompletion
    {'hrsh7th/nvim-cmp'},
    {'hrsh7th/cmp-buffer'},
    {'hrsh7th/cmp-path'},
    {'saadparwaiz1/cmp_luasnip'},
    {'hrsh7th/cmp-nvim-lsp'},
    {'hrsh7th/cmp-nvim-lua'},

    -- Snippets
    {'L3MON4D3/LuaSnip'},
    {'rafamadriz/friendly-snippets'},
  }
}

& the following in my lsp-zero config file:
local lsp = require('lsp-zero')

lsp.preset('recommended')
lsp.setup()

It let me install the lua-language-server when I first installed it & reopened my init.lua file, but no other language servers have been able to install successfully. All the ones I've tried fail with the message in the title.

Each language server has its own dependencies, npm just happens to be very common. Install nodejs and npm in your system.

That worked, thanks!


Stopping RTSP stream (using interruption) caused multiple times execution of 'onConnectionFailedRtsp' method

Hi,
I am using Pedro library for RTSP streaming on React dashboard from android device.
Dashboard is having stop player on which I create interrupt for streaming thread and it stops display over dashboard.
but I observed multiple times onConnectionFailedRtsp is getting fired, why?

Did you call stopStream in onConnectionFailedRtsp?

it is an android app which has to capture live streaming and send stream packets to RTSP url. which can be stream on VLC player.
steps:

In onConnectionFailedRtsp method -> log message "Connection failed"
now stream on VLC
stop VLC after some time

observed multiple times log message "Connection failed"

Are you using this project?:
https://github.com/pedroSG94/RTSP-Server

I am using code from below location
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/releases/tag/1.7.8

I did multiple chagnes from that version. Please, try with my last release (2.0.5). Before update library that you can compile my app example and write a log in  onConnectionFailedRtsp to detect if all is working fine.
Anyway, If you are using a media server, stop VLC don't should stop stream. For this reason your steps to reporoduce has no sense.

ok, Let me check with latest version.
Correct, stopping VLC won't stop streaming, but stopping interrupt caused to execute onConnectionFailedRtsp.

but stopping interrupt caused to execute onConnectionFailedRtsp

I dont understand this. Can you explain it? Maybe record a video with steps could be a good idea.

And are you referring to this App (https://github.com/pedroSG94/vlc-example-streamplayer)?

No


Initial PBS/Torque support and AbstractBatchSystem refactoring

This is a preliminary run at adding PBS/Torque support, designed off the SLURM and SGE classes.  Tests have also been added.
Resolves #1163

Can one of the admins verify this patch?

Can one of the admins verify this patch?

This is yet another almost identical copy of the SGE batch system. As much as I understand the desire to get stuff done, this path is unsustainable because, once I merge it, it puts the onus on the Toil team to maintain three nearly identical copies until eternity.
Also, the tests will fail since TORQUE isn't installed on the CI slaves. This would have to be addressed by a change to CGCloud's ToilJenkinsSlave.

@hannes-ucsc what's the best course forward?  Focus on a single DRMAA-based approach (not sure where that stands these days; it's been a little flaky in the past)?  Or move the common code into a parent class or module?

I think extracting a common abstract base class using the template method pattern is the obvious solution.

At the moment there is the AbstractBatchSystem abstract base class, and the BatchSystemSupport base class for SLURM, Torque, Gridengine, etc implementing common methods (which seems like the obvious place).  If that seems fine I can start on pulling out the common code from these into BatchSystemSupport.

Jenkins, test this please.

I think this should be the hierarchy:
AbstractBatchSystem
    BatchSystemSupport
        AbstractGridEngineBatchSystem
             GridEngineBatchSystem
             SlurmBatchSystem
             TorqueBatchSystem

@cjfields, I sent an invite to our GH org. If you accept, you will be able to see the Jenkins test results.

@hannes-ucsc thanks!

@hannes-ucsc should we merge this in and have a separate issue tracking re-implementation of the grid schedulers.  It seems SLURM is set up w/ Jenkins so it can act as a check, and we can test Torque locally.  The only wild card is SGE/OGE, which we don't have installed locally.

I'd prefer not merging until the testing and code duplication issues are squared away. The changes in this PR are mostly additions so keeping the branch rebased on mainline should be easy, meaning there is no rush to merge it.

@hannes-ucsc okay, that works for me.

@hannes-ucsc I added an initial AbstractGridEngineBatchSystem implementation that works for Torque, will work on SLURM next (which Jenkins should catch).  Anywhere to test this w/ SGE?

@cjfields just FYI every time you push to this branch you're triggering an integration test build. I cancelled all but the most recent push so the test results are showing up as failed in the history although they may not have failed if I had let them finish running.
Since the tests are run on only the most recent commit in a push and not every commit, you can avoid this by committing locally and waiting to push the commits until you want Jenkins to run the test suite :)

@cket Thanks!  I was using [ci-skip] in the commit msg to try skipping CI, and it seemed to skip a couple of those intermittent ones I pushed, e.g. https://github.com/BD2KGenomics/toil/pull/1195/commits/4afc3b669c593aa856114da0a764a84028fe0969 but it appears to work inconsistently.  I'll stick to the local branch for now.

@cjfields makes sense! We use the directive 'Jenkins, skip this please' in a PRs description to skip testing. However, I'm not sure how Jenkins directives work with outside contributors so you're probably better off just committing locally

@cket @hannes-ucsc seems the failures in the last jenkins run is AWS-related, not due to batchSystemTests issues
boto.exception.S3ResponseError: S3ResponseError: 400 Bad Request
<?xml version="1.0" encoding="UTF-8"?>
<Error>
TooManyBuckets
<Message>You have attempted to create more buckets than allowed</Message>
<CurrentNumberOfBuckets>101</CurrentNumberOfBuckets>
<AllowedNumberOfBuckets>101</AllowedNumberOfBuckets>
</Error>
ERROR

Yes, only push if you want Jenkins to test. I think Jenkins builds on every push because you are now a member of our organization.

Anywhere to test this w/ SGE

The Jenkins slave running the build has SGE and Slurm installed. Here are the important bits for SGE:
https://github.com/BD2KGenomics/cgcloud/blob/master/jenkins/src/cgcloud/jenkins/toil_jenkins_slave.py#L45
https://github.com/BD2KGenomics/cgcloud/blob/master/jenkins/src/cgcloud/jenkins/toil_jenkins_slave.py#L59
I hope the TORQUE installation is less involved.

Okay, it appears to skip SGE tests then, likely due to trying to find qmake.  I'll work locally on the SGE module and see if there is a better alternative (qsub is used by both SGE and PBS/Torque).

@hannes-ucsc small but important thing: the current name of the SGE-specific class is GridengineBatchSystem, but the abstract class is AbstractGridEngineBatchSystem (note the cap for ...Engine... in the latter).  Switching the former to be consistent with the naming scheme (e.g. to GridEngineBatchSystem) is breaking the test and my guess would break any SGE-dependent code on case-sensitive file systems.  Also note I renamed the various Worker classes to be batch-system specific (eg. SGE's Worker is now GridEngineWorker).
I am reverting this to the old name for now, but any thoughts on a reasonable workaround, or should we just go ahead and make the change in the test?

Feel free touch all code necessary to refactor the name. No code external to Toil is dependent on the names of these classes, so you should be good to change the names to whatever you like, as long as you change all occurrences of that name in the Toil source. Since the official name is/was "Sun Grid Engine"/"Oracle Grid Engine" I would prefer GridEngine…, not Gridengine….

Did a preliminary review. The history is polluted with commits from the master branch.
The code duplication concern applies to the workers too, obviously, so you might need to add a parallel worker class hierarchy as well, starting in AbstractGridEngineWorker.
Since you will be touching a lot of code, I would nest the definition of the workers in the batch system class. So GridEngineWorker becomes, GridEngineBatchSystem.Worker.

Thanks @hannes-ucsc .  The commits from master were rebased in, I'll just keep this branch clean from future commits from master from now on.  I have the updates running through Jenkins now, including running with AbstractGridEngineBatchSystem in a separate module.
Re: the separate Worker, I agree though I'm wondering whether it might be cleaner to do this in a separate pull request.

@hannes-ucsc regarding abstracting Worker I'm currently testing this in a separate branch off the current PBS issues/1163-pbs-support, specifically this one.  So far embedding the class definition is working for Torque.

This should be boiled down to two commits: one that eliminates the duplication in the existing GridEngine-based batch systems and another one that adds TORQUE support, in that order. If you would like to do each in a separate PR, that's fine with me.

@hannes-ucsc the current run of commits was developed inversely.  The initial pull request added simple PBS/Torque based on the old SGE code but had code duplication.  Based on your feedback additional downstream commits implemented a base batch system class and removed code duplication in the Torque, SGE, and SLURM batch modules (at least, to this point, relegated primarily in the batch system part).
I could basically start from a clean branch off master and implement the changes as stated as two pull requests, though it would remove much of the commi history and render this pull request obsolete.

Clean slate sounds good to me.
But you don't need to start a new PR. You can soft-reset the PR branch to master without changing your working copy. Then commit the changes again. Then force push. But new PR works, too, as long as both are linked.

@hannes-ucsc went ahead and squashed these down to just one commit, and will renaming pull accordingly.

Thank you, @cjfields. To summarize what I already mentioned in one way or the other:

worker classes still duplicate too much functionality
TORQUE tests aren't being run on CI

And more thing: there should be a sort test that uses TORQUE. It will yield better state coverage compared to the more unit-testy batch system tests. But don't worry, adding a sort test for a particular batch system is very simple. See sortTest.py.

worker classes still duplicate too much functionality

Working on this now, though (bad timing) our cluster is down with file system issues until Monday

TORQUE tests aren't being run on CI

That will be the next step

And more thing: there should be a sort test that uses TORQUE. It will yield better state coverage compared to the more unit-testy batch system tests. But don't worry, adding a sort test for a particular batch system is very simple. See sortTest.py.

I actually had prelim tests on this as well.

Another collaborator had mentioned to me that he was working on a batch system implementation for DRMAA which would allow us to use one AbstractBatchSystem implementation with GridEngine, Slurm and Torque. I know virtually nothing about DRMAA and I don't can't tell yet if or when his efforts will be merged.
I feel this shouldn't stop you from pursuing this PR. I will merge this regardless of the DRMAA effort if it reduces the code duplication and has tests that pass on our CI. I think the DRMAA implementation and your refactored implementations can and should coexist.

EDIT: forgot to ask, should we pull this into a separate class file? abstractBatchSystem.py is getting a little long.

Yes. abstractBatchSystem.py should only contain generic code, not code specific to any particular concrete implementation.

@hannes-ucsc agreed, DRMAA should probably be implemented as a separate co-existing module.  We actually have DRMAA on our cluster so this is great, but IIRC some schedulers had (as least in the past) required having DRMAA support compiled in prior to deployment (at least PBS/Torque was this way, and it wasn't on by default).

@cjfields @hannes-ucsc This looks like great, great work. Hope we can get it merged soon and under CI.

Thx @benedictpaten .  Slight delay, our cluster had a major disk issue that took it offline for the week, so we were busy triaging analyses (it's back to normal now).

I have a squashed commit from a branch with the AbstractGridEngineWorker extracted out which passes Torque tests.  I am going ahead with the merge to test w/ jenkins to see if SGE and SLURM modifications work (I may test on our new cluster as well, which is using SLURM).

Only have a bit of minor cleanup and to implement sort tests.
@hannes-ucsc @benedictpaten on getting Torque tests running on jenkins: are all tests run within one cloud instance?  If so, a significant hurdle when implementing testing of Torque and GridEngine from the same instance will be that many of the exe names are the same in both job schedulers (e.g. qsub, qstat, etc).  The current tests on this branch only run GridEngine tests when SGE is installed (and Torque similarly) via looking for scheduler-specific applications, but internally they both use qsub and qstat calls.

This one is for @hannes-ucsc to comment on.

@hannes-ucsc Probably good to move on this, I think this is a really useful refactor.

I will do a detailed review shortly.

Torque tests running on jenkins: are all tests run within one cloud instance?

Yes. We call that instance the Jenkins slave.

If so, a significant hurdle when implementing testing of Torque and GridEngine from the same instance will be that many of the exe names are the same in both job schedulers (e.g. qsub, qstat, etc). The current tests on this branch only run GridEngine tests when SGE is installed (and Torque similarly) via looking for scheduler-specific applications, but internally they both use qsub and qstat calls.

Good point.
I would use https://hub.docker.com/r/agaveapi/torque/ to start the TORQUE daemons in a container on the Jenkins slave. The slave that runs the tests has docker installed and the user that the tests are running is a member of the docker group so that it can invoke the docker command.
You could start the container during test setup and stop it during test teardown. You then need a mechanism to override the various TORQUE command names used by your batch system implementation. Let's say the default for qsub is just qsub. Your tests could override that with docker exec CONTAINER_ID qsub, thereby running qsub in the container started during test setup that's hosting the TORQUE daemons. IIRC, there already is a way to override commands but I don't think it is complete. This doesn't have to be a fancy mechanism, simply extracting global variables for the command names and monkey-patching those during test setup would be sufficient.
The beauty of this approach is that you don't have to submit a PR to CGCloud that performs TORQUE installation (which looks complicated) and that it doesn't collide with the existing SGE installation on the slave.
Toil is already using that approach to run the Toil appliance container for certain tests. Two containers actually. Take a look at toil.test.ApplianceTestSupport and toil.test.src.hotDeploymentTest.HotDeploymentTest.

Hi @hannes-ucsc I'll start having a look at it this week.

@cket this request is reporting possible configuration error issues with Jenkins.  Any ideas?  Maybe it needs a refresh from master (merge conflicts for gridengine.py and slurm.py need to be addressed anyway, could do this on a local branch and merge in...)

@cjfields merging/rebasing on master should fix everything!

Looks like I just missed the python3 compat pull; I'll see how this round of jenkins tests goes and try merging those once I have tests running cleanly again

Remaining issues

[ ] Move createJobs into base class
[ ] Refactor getRunningJobIDs ?
[ ] Consolidation of process logging

From @hannes-ucsc review:

This is looking much improved and I'm happy about the path this is taking. I recommend working on refactoring more duplication out of the existing methods in each concrete implementation. For example, createJobs looks virtually identical across all of them.

Agreed.

getJobExitCode looks very similar between TORQUE and SGE, so maybe you want to pull that up into the abstract base class and override it in SLURM only.

This one is tricky, as the various implementations for this method are output-specific.  Though there are similarities enough differences exist between the SGE and Torque methods, the output parsing differs enough that I could see refactoring these creating more code than currently exists and possibly causing more problems than it's worth.

getRunningJobIDs could be refactored by pulling up it up and factoring out an abstract method called parseQstatLine that parses an individual line and returns a namedtuple with the information needed. This would be similar to what you did with killJob vs killJobs. The name parseQstatLine glosses over the fact that SLURM doesn't have qstat but I think that's ok. After all these are all SGE clones so I think people will get it.

Will check into that

Logging every subprocess call is very helpful in diagnosing problems, so I propose adding that to TORQUE, too. In fact, I would write a wrapper around subprocess.check_call that logs implicitly and, again, eliminates a lot of duplication.

Okay

Lastly, do you know why SLURM doesn't seem to have setEnv?

It seemed to fall back to the default implementation in class BatchSystemSupport.  This now is commonly set within the AbstractGridEngineBatchSystem base class, as all current implementations using this can't use commas in the variable values

@cket latest tests seem to be passing, but I am seeing a Java issue on Jenkins that is causing a problem:
http://jenkins.cgcloud.info/job/toil-pull-requests/2447/consoleText
Any idea?

Jenkins, test this please

@cjfields I haven't seen that before, I retesting might fix the issue

@cjfields looks like that fixed it. Thanks again for the PR, it's looking good. Did you see this related slurm PR, #1391? Does this PR address any of those issues?

Did you see this related slurm PR, #1391? Does this PR address any of those issues?

@cket I can have a look, though the changes for SLURM/SGE are quite significant in this branch (it's really a misnamed PR as it adds Torque support and refactors all three to have a common base). We would likely need to hand-merge the SLURM PR changes in.

@cjfields just a heads up, it looks like there is still a little work to be done in this PR so I’ll likely merge #1391 first - sorry to have you do another merge from master, hopefully its not too troublesome.

@cket not a problem, I can work on resolving conflicts once it's in.

@cket I'm seeing some API differences when keeping batch system IDs that seems to break SLURM.  The primary issues is that Torque, SGE (and LSF, which needs to be moved over) all seem to store the mapping of toil job IDs to batch system job IDs as a tuple of (job ID, Task name), but by default passes in None for the task.  It seems like this is behavior inherited from the original gridengine (SGE) code, but I can't see anywhere that the task from the tuple is actively used.
Master branch
SGE: https://github.com/BD2KGenomics/toil/blob/master/src/toil/batchSystems/gridengine.py#L131
LSF: https://github.com/BD2KGenomics/toil/blob/master/src/toil/batchSystems/lsf.py#L115
On this pull request I adopted this behavior when refactoring (this occurs in createJobs(), in abstract base class AbstractGridEngineBatchSystem):
https://github.com/HPCBio/toil/blob/issues/1163-pbs-support/src/toil/batchSystems/abstractGridEngineBatchSystem.py#L123
However, SLURM doesn't use this approach and simply sets the toil ID -> batch system ID mapping as a simple value (not tuple):
Master branch
https://github.com/BD2KGenomics/toil/blob/master/src/toil/batchSystems/slurm.py#L150
I attempted to modify SLURM to adopt the other tuple-based behavior, but tests are hanging and are likely due to some inconsistency at this level.  However, I can't easily test this until we have our local SLURM cluster ready to go, and testing using Jenkins is touch-and-go at best until this is ready.
My suggestion is to back out the SLURM changes that are breaking tests, but it's definitely an inconsistency that needs to be addressed.  We can file a related issue tagging this.
The key question: which behavior should we end up adopting: tuple-based, like SGE, or simple value, like SLURM?  A cursory look through the code doesn't indicate where the task value from the tuple is used, but maybe I'm missing something there (e.g. it's settable at the API level).

@cket actually, as a quick followup, it looks like our local SLURM setup is working, just did a checkout from our fork and tests on master pass.  I'll see if I can get these at least passing on this.

Digging in, it looks like the 'Task' stuff mentioned previously is from SGE and probably came from a few years back.  Seems like it really pertains to allowing for job array support, where the task is the job array ID.  I have gone ahead and modified SLURM to allow for this, but the question is how much overall support toil has for job arrays currently.

@cjfields I'm a little unsure of the exact question, but Toil doesn't have the concept of job arrays. If a batch system class wants to implement them to improve performance or behavior when interacting with the batch system they can, as long as it's transparent to the rest of Toil.
It sounds like you've already made this behavior consistent across the relevant batch systems, which is great!

Can I follow up on this issue? We are on the fence tackling a PBS Pro integration with the National Computational Infrastructure in Australia, but it would make a lot of sense for us to build on @cjfields 's work.
What are the biggest stumbling blocks to getting this pull request merged?

@ohofmann I think https://github.com/BD2KGenomics/toil/pull/1195#issuecomment-270690866 summarizes it best. IMO this is nearing completion and the remaining issues are (probably) simple compared to the work already done, but I would bet @cjfields has a better feel for the work to be done.

@cket I'm primarily concerned this fork has diverged enough that this will cause problems with additional pull requests in the same batch system code; we will likely see this with #797, #1385, and #1392.
To be honest, IMHO I think it would make better sense to pull in the changes once the SLURM conflict is dealt with (which I'll focus on now) and the commits are squashed.  We can reconcile the additional changes as (much smaller, atomic) pull requests, adding issues that track these.  The remaining two items in that comment are pretty minor and I think can be addressed separately, and if there are any tweaks for PBS-Pro that need to be made these can be addressed as a separate pull request.   Does that make sense?

@cjfields that makes sense to me - this refactoring is huge improvement and I'd like to get it into master so we can just track the last couple issues in their own tickets.
Once you deal with the slurm conflicts and create tickets for the last issues, I'll do a final review and hopefully merge it ASAP!

@cket Just resolved that conflict manually; I'll add the tickets and refer to this pull request.

@cket seeing integration test fails but this seems linked to the same issues with #1385 (AWS resource limits).

@cjfields yeah, sorry about that. I've cleared out the outdated IAM roles.
Jenkins, test this please

Okay, I'll work on squashing the commits for the branch

@cket commits have been squashed; I did a test merge locally to master which looks good.

@cjfields thanks again, great work!

Awesome, thanks @cket!


Copying files to /home/steam/ARK-Staging/Mods/764755314
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content/WallDoor/diag/CKF_StoneDoorwayDiag_sc.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content/WallDoor/diag/CKF_StoneDoorwayDiag_sc.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/Double/Diag/CKF_DoubleLanDiag_sc.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/Double/Diag/CKF_DoubleLanDiag_sc.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/Double/Diag/Wall_KeepDoubleLanDiag.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/Double/Diag/Wall_KeepDoubleLanDiag.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/Double/Wall_DoubleLancet.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/Double/Wall_DoubleLancet.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/DoubleTall/Diag/Wall_KeepDoubleTallLanDiag.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/DoubleTall/Diag/Wall_KeepDoubleTallLanDiag.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/DoubleTall/Diag/CKF_DoubleTallLanDiag_sc.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/DoubleTall/Diag/CKF_DoubleTallLanDiag_sc.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/DoubleTall/Wall_DoubleTallLancet.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/DoubleTall/Wall_DoubleTallLancet.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/TallSingle/Diag/CKF_SingleTallLanDiag_sc.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/TallSingle/Diag/CKF_SingleTallLanDiag_sc.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/TallSingle/Diag/Wall_KeepSingleTallLanDiag.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/TallSingle/Diag/Wall_KeepSingleTallLanDiag.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/TallSingle/Wall_SingleTallLancet.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/TallSingle/Wall_SingleTallLancet.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/Single/Diagonal/Wall_KeepSingleLanDiag.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/Single/Diagonal/Wall_KeepSingleLanDiag.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/Single/Diagonal/CKF_SingleLanDiag_sc.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/Single/Diagonal/CKF_SingleLanDiag_sc.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/Single/Wall_SingleLancet.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/Single/Wall_SingleLancet.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/TripleTall/Diag/Wall_KeepTripleTallLanDiag.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/TripleTall/Diag/Wall_KeepTripleTallLanDiag.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/TripleTall/Diag/CKF_TripleTallLanDiag_sc.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/TripleTall/Diag/CKF_TripleTallLanDiag_sc.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/TripleTall/Wall_TripleTallLancet.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/TripleTall/Wall_TripleTallLancet.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/Triple/Diag/Wall_KeepTripleLanDiag.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/Triple/Diag/Wall_KeepTripleLanDiag.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/Triple/Diag/CKF_TripleLanDiag_sc.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/Triple/Diag/CKF_TripleLanDiag_sc.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Lancets/Triple/Wall_TripleLancet.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Lancets/Triple/Wall_TripleLancet.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content3/Ornate/Half/KeepOrnateArchWalled.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content3/Ornate/Half/KeepOrnateArchWalled.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./2908/roundeddoorway/CKF_RoundedDoor_sc.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./2908/roundeddoorway/CKF_RoundedDoor_sc.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content2/cathredralWindow/Cathedralglass.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content2/cathredralWindow/Cathedralglass.uasset': Invalid cross-device link
cp: cannot create hard link '/srv/steam/ragnarok/ShooterGame/Content/Mods/764755314/./Content2/baywindow/Walltudorwindow_Keep.uasset' to '/home/steam/ARK-Staging/Mods/764755314/./Content2/baywindow/Walltudorwindow_Keep.uasset': Invalid cross-device link

This suggests your staging directory is on a separate filesystem to your server directory.
v1.6.22 should fix this.

Thx yes i found the solution for myself. Changed your -al to -as option. Only wanted to let you know there is a problem on systems with /home on another partition :) But now i check if the update will fix it to. i prefer to not change code everytime i update the tools 👍

rm: cannot remove '/home/steam/ARK-Staging/Binaries/Linux/*.txt': No such file or directory
is the only error still there after update to 1.6.22
my folder are at
/home/steam/ARK-Staging/ShooterGame/Binaries/Linux
Dont know if its a problem with the script or maybe i did anything wrong but as i know the only place are the config where the Staging directory are set .

StagingDir="/home/steam/ARK-Staging"  are set in the arkmanager.cfg

rm: cannot remove '/home/steam/ARK-Staging/Binaries/Linux/*.txt': No such file or directory
> is the only error still there after update to 1.6.22

Just means the script needs to check if any such files exist before trying to remove them.

Yes but it looks like in it is searching in the wrong place, or ? my path have "ShooterGame/" in the middle

9f188a5 should fix this.

fast reaction :) thx


Brett - Fixed Submissions CRUD - groupSubmissions still has problems(pending)

Made changes on.. (below) to fix crud for submissions
Entity package:

Projects
Groups
Submissions
GroupSubmissions

Service package:

Submissions

Controller package:

Submissions

No need for WebConfig

If you check SecurityConfig we are already allowing access through corsConfigurationSource

Unnecessary additions to entity constructors

If you check all of the one to many properties default to an empty hash set, this is because you realistically cannot pass an already made hash set since the related entities depend on the parent entity.

Never pass IDs directly to constructor

Primary keys are autogenerated, no need to pass through constructor


Setup drone config to automate the release process

The current process is:

Bump version in package.json
Add notes to changelog
Merge PR into main
Go to drone here and identify the build corresponding to the merge into main
Promote to target 'publish'

We probably want to automate this with a drone config, example config for a plugin available at k6

Drone has been deprecated and we've moved to gh actions, so closing


[Event Request] codeunit 6620 "Copy Document Mgt." - OnAfterCopyPurchLineExtText

local procedure CopyPurchLineExtText(ToPurchHeader: Record "Purchase Header"; var ToPurchLine: Record "Purchase Line"; FromPurchHeader: Record "Purchase Header"; FromPurchLine: Record "Purchase Line"; DocLineNo: Integer; var NextLineNo: Integer)
    ...
    ToPurchLine."Attached to Line No." :=
      TransferOldExtLines.TransferExtendedText(DocLineNo, NextLineNo, FromPurchLine."Attached to Line No.");

    OnAfterCopyPurchLineExtText(ToPurchHeader, ToPurchLine, FromPurchHeader, FromPurchLine, DocLineNo, NextLineNo, TransferOldExtLines, RecalculateLines); //New.Event
end;

[IntegrationEvent(false, false)]
local procedure OnAfterCopyPurchLineExtText(ToPurchHeader: Record "Purchase Header"; var ToPurchLine: Record "Purchase Line"; FromPurchHeader: Record "Purchase Header"; FromPurchLine: Record "Purchase Line"; DocLineNo: Integer; var NextLineNo: Integer; var TransferOldExtLines: Codeunit "Transfer Old Ext. Text Lines"; RecalculateLines: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47651.


Add validators backwards compatibility

Please check if the PR fulfills these requirements

[x ] The commit messages are descriptive
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] An issue has been created for the pull requests. Some issues might require previous discussion.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Revert backwards compatibility break introduced in https://github.com/kafka-ops/julie/pull/443

What is the current behavior? (You can also link to an open issue here)

Validators with just no-arg constructors fail to load.

What is the new behavior (if this is a feature change)?

Validators with just no-arg constructors will load again, if no Configuration constructor is found.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Hopefully not.

Other information:

With just the first commit, which removes the Configuration constructor from some validator classes, tests in TopologyValidationTest fail with NoSuchMethodException. With the second commit added, these tests work again.

doing one tomorrow morning first thing, sorry slammed with work today.
On Thu, Apr 7, 2022 at 2:47 PM Sverre H. Huseby @.***>
wrote:

Thanks! Will there be a 4.1.3 release with this?
—
Reply to this email directly, view it on GitHub
https://github.com/kafka-ops/julie/pull/480#issuecomment-1091691844, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAQXPCLZSLQ4O66XBHBFK3VD3KMVANCNFSM5SYZC3MA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

--
Pere Urbon-Bayes
Software Architect
https://twitter.com/purbon
https://www.linkedin.com/in/purbon/

In the meanwhile, you have
https://github.com/kafka-ops/julie/actions/runs/2108865274 latest build.
-- Pere
On Thu, Apr 7, 2022 at 2:53 PM Pere Urbón Bayes @.***>
wrote:

doing one tomorrow morning first thing, sorry slammed with work today.
On Thu, Apr 7, 2022 at 2:47 PM Sverre H. Huseby @.***>
wrote:

Thanks! Will there be a 4.1.3 release with this?
—
Reply to this email directly, view it on GitHub
https://github.com/kafka-ops/julie/pull/480#issuecomment-1091691844,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAQXPCLZSLQ4O66XBHBFK3VD3KMVANCNFSM5SYZC3MA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

--
Pere Urbon-Bayes
Software Architect
https://twitter.com/purbon
https://www.linkedin.com/in/purbon/

--
Pere Urbon-Bayes
Software Architect
https://twitter.com/purbon
https://www.linkedin.com/in/purbon/

@sverrehu https://github.com/kafka-ops/julie/releases/tag/v4.1.3 fyi 👍 , have a nice weekend!


read me doc

https://salesforce.stackexchange.com/questions/108524/approval-lock-unlock-with-apex


copy_and_paste: Fix copy/paste behaviour on Firefox.

When selecting multiple messages, Firefox makes multiple ranges for the
selected messages whereas Chrome makes just one. Changes have been made such
that startContainer of the first range and endContainer of the last
range is taken to copy the contents.
Fixes #11805

@vrongmeal do you understand why we had a loop before?  This seems to significantly change the behavior of that loop.
@novokrest do you have time to help review this as the previous expert on this code?  I'd really appreciate it.

@vrongmeal thanks for your work on this!  I read it, and it mostly makes sense.  I added a ton of comments explaining what's going on, which I imagine will help future developers considerably, and pushed back to this PR. (You can fetch my changes using git fetch or e.g. tools/reset-to-pull-request)
There's one thing I need you to look at before we can merge, which I marked as a TODO in the comments.  What is the purpose of the skip_same_td_check_selection variable?  It seems to be essentially a duplicate of skip_same_td_check

@timabbott So, the skip_same_td_check_selection basically confirms that in the whole selection that we can skip the same td check. As the check is now out of the loop, I needed that at least once during the whole loop that skip_same_td_check is true.
Also, now I realize that I could do this in a different way where I can avoid the extra variable, such as --
if (skip_same_td_check) {
    skip_same_td_check = true;
}

I'll update the PR and then we can merge it :)

Sounds great!

@timabbott I added a comment to explain the skip_same_td_check_selection. Don't seem to be able to remove the variable.

Merged, thanks @vrongmeal!  I really appreciate your putting the effort into making these changes understandable; with our efforts combined I think this will be a much easier subsystem for folks to get into modifying in the future.


Arduino MEGA support

Hi! I love this patch it makes it so easy for me to communicate with Ableton, but I have a problem.
I need more analog connections as there is only 5. For my project I need at least 10 (preferably more) inputs. This is why I'm working with the Arduino MEGA. At the bottom there is the option to select Arduino UNO but that's the only option (this makes me believe you planned to do more). Now the patch recognises the MEGA just fine. Everything works but I don't have all the analog ins and outs that my board has. Would love it so much if you could extend the list so that all the ins and outs of Arduino mega are recognised in Live.
Noa

Hi noasilver,
Thanks for your feedback! It would definitely be great to add the Arduino MEGA as an option for including more analog inputs. We'll take your idea into consideration.
In the meantime, you could always reach out to the community on the Cycling '74 Forums, if you're looking to edit the Arduino M4L device on your end.
We will soon be disabling this 'Issues' section, since the page is not regularly monitored. If you need further assistance with the M4L Connection Kit, please contact Ableton Support and we'll be happy to help.
Best regards,
Lillia
Max for Live Content Specialist


Integrated terminal does not accept numbers [1-8] when in haskell's ghci

VSCode Version:  1.6.1 (Commit 9e4e44c19e393803e2b05fe2323cf4ed7e36880e)
OS Version: MS Windows 7 Professional 64bit Version 6.1.7601

Steps to Reproduce:

Have ghci installed
Open integreted terminal (ctrl + `)
Type ghci and ENTER. Prelude> appears
Type numbers 1 through 8 - system sound is played. However integrated terminal accepts 0 and 9.

Those keys work in the integrated terminal when not in ghci? And do they work in ghci in cmd.exe?

Forgot to mention : yes, keys work in integrated terminal when not in ghci.
yes, keys work in cmd.exe when in ghci

Likely related to https://github.com/Microsoft/vscode/issues/13809

I'm currently using VS Code 1.8.1 on Win10 64-bit. I cannot reproduce this issue.

I'll close this off then, let me know if someone else experiences this in 1.8.1+


⚠ Bofrost.at has degraded performance

In cde951e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1550 ms

Resolved: Bofrost.at performance has improved in 2dfb81a.


TUN file import doesn't implement specified base frequency

Importing a .tun file reads and adds to the page the "MIDI note for base frequency" from the .tun file, but NOT the "Base frequency" leaving it as whatever it happened to be set to before the import (440 by default on a fresh page, or whatever was previously loaded). As a result, the calculated table is usually very wrong after import.
To reproduce, start with a fresh page ( https://sevish.com/scaleworkshop/?version=2.1.0 );
Notice the base freq. is 440 and the MIDI note is 69;
Load a .tun file whose tuning center is not 440/69 (e.g. attached file "HarrisonM-RagaJust-C.tun" which was created using Scale Workshop);
Notice that the MIDI note has been updated to what is in the .tun file (60 in this case), but the base freq. is still 440 (should be 261.6256 as specified by the .tun file;
If you then hit "Auto" next to the Base Freq. field, the correct value is determined and shown. But I don't see any reason the import process shouldn't use the Base Freq. explicitly given in the .tun file. Adding the extra step seems obscure, undocumented, and unnecessary, so I suspect this is a bug. Thank you for continuing to develop this great tool!
HarrisonM-RagaJust-C.zip

Thank you for fixing this! I look forward to the next release.


Transform.looking_at()  - reversed Z axis

Correct me if I'm wrong but I'm thinking that Transform.looking_at(Vetor3 targetPoint, Vector3 upVec) method should rotate z possitive object to face a targetPoint... Right now its rotating object to face it's back to target point... Or I'm doing something wrong
Visual reference: https://dl.dropboxusercontent.com/u/168251/godot/some/issues/lookatIssue.png
TestProject: https://dl.dropboxusercontent.com/u/168251/godot/some/issues/LookAtIssue.7z

looking_at targets negative z,  OpenGL/GLU were used as reference for this,
as cameras point to -Z too.
On Thu, Apr 2, 2015 at 12:47 PM, kubecz3k<EMAIL_ADDRESS>wrote:

Correct me if I'm wrong but I'm thinking that Transform.looking_at(Vetor3
targetPoint, Vector3 upVec) method should rotate z possitive object to face
a targetPoint... Right now its rotating object to face it's back to target
point... Or I'm doing something wrong
Visual reference:
https://dl.dropboxusercontent.com/u/168251/godot/some/issues/lookatIssue.png
TestProject:
https://dl.dropboxusercontent.com/u/168251/godot/some/issues/LookAtIssue.7z
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/1601.

Thanks for reply @reduz Closing because it's intended behaviour


Minor rendering issue in editor where boxes are drawn around the code

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
The div atom-text-editor .lines contains many children divs that contain the actual lines of the code being viewed in the editor. Strangely enough, I am seeing funky background colour behaviour here. Here's a screenshot:

So I went into the dev tools and checked out what is going on. Turns out each of the children divs's background colour only stretches to a bit past the line where the last character of code in that block is:

Now, this is the Seti UI theme and One Dark syntax, but I see it with any combination of ui/syntax themes. Here is the same issue, but in Safe Mode:

Now, here's the interesting part - I have tracked down where this actually happens. The culprit is this CSS rule that overwrites the background for each of those containers of code lines:

Before you say "@mtimofiiv, this is a theme problem, go ask them about it", note that it does happen with all themes and that toggling this CSS rule on/off in the dev tools actually fixes the problem, but only for that one block and only temporarily.
Unless I am wrong, it seems like a rendering issue.
Steps to Reproduce
I am not sure what I am doing that perhaps others are not. I have a stock install of Atom which is up to date and even in Safe Mode I am seeing this, so it's not a plugin problem as far as I'm aware. I have not modded my config in any crazy way.
Expected behavior:
I expect the background colour of the code blocks to not have jagged box edges.
Actual behavior:
See above
Reproduces how often:
Always.
Versions
Here is the output of atom --version:
Atom    : 1.16.0
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0

And apm --version:
apm  1.16.1
npm  3.10.5
node 6.9.5 x64
python 2.7.13
git 2.11.0

My OS is macOS Sierra 10.12.3.

Thanks for taking the time to contribute!
We noticed that this is a duplicate of #12634. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Use pydantic to enforce type checks for Action

What problem or use case are you trying to solve?
Actions are decorated by@dataclass from dataclasses package. This, together with mypy defined in the pre-commit hooks, does static type checks, but still doesn't enforce type checks during runtime. This means a wrong json generated by LLM might be deserialized into an Action object without type errors.
Proof: test_action_serialization.py has two bugs:

test_modify_task_action_serialization_deserialization uses int type for id while it should be str.
test_cmd_kill_action_serialization_deserialization uses str type for id while it should be int.

These bugs are not captured by pytest, because we don't enforce type checks during runtime.
Describe the UX of the solution you'd like
Use pydantic's BaseModel to replace @dataclass annotations for Action classes.
Do you have thoughts on the technical implementation?
This seems straightforward to fix, but it would be cool if someone could use OpenDevin to fix it!

This issue is both a "feature request" and a "bug". The "bug" is not in the real code, but in the unit test itself.

Hi, there! Please assign it to me and i will give it a shot. :)

Isn't it possible to use validation, including pydantic validators, on dataclasses? Perhaps we don't need to go the whole way to inherit BaseModel to achieve more type enforcement. e.g. https://docs.pydantic.dev/latest/concepts/dataclasses/
It would keep it simple, and TBH feels more suited to the style of the codebase.

I tried that but then gave up due to some reason I cannot remember ;)
If it works then it’s great!
Get Outlook for iOShttps://aka.ms/o0ukef

From: Engel Nyst @.>
Sent: Wednesday, May 8, 2024 5:59:22 PM
To: OpenDevin/OpenDevin @.>
Cc: Author @.>; Comment @.>
Subject: Re: [OpenDevin/OpenDevin] Use pydantic to enforce type checks for Action (Issue #1634)
Isn't it possible to use validation, including pydantic validators, on dataclasses? Perhaps we don't need to go the whole way to inherit BaseModel to achieve more type enforcement. e.g. https://docs.pydantic.dev/latest/concepts/dataclasses/
It would keep it simple, and TBH feels more suited to the style of the codebase.
—
Reply to this email directly, view it on GitHubhttps://github.com/OpenDevin/OpenDevin/issues/1634#issuecomment-2101736204 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGENUWT52CU3RYR6ZD6KCMTZBLC6XBFKMF2HI4TJMJ2XIZLTS6BKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI3DMOBUGM4DOOJXGKSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRWGY4DIMZYG44TQNVENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDMNRYGQZTQNZZHA4KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGY3TQOBSGI2DINRXURXGC3LFVFUGC427NRQWEZLMVRZXKYTKMVRXIX3UPFYGLLCJONZXKZKDN5WW2ZLOOSTHI33QNFRXHFUCUR2HS4DFVJZGK4DPONUXI33SPGSXMYLMOVS2SNZXGEZTAMRQHAZYFJDUPFYGLJLJONZXKZNFOZQWY5LFVIZDEOBUG42DCOJTGKBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGY3DQNBTHA3TSNZSQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRWGY4DIMZYG44TQNUCUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNRWHA2DGOBXHE4DRAVEOR4XAZNFNRQWEZLMUV3GC3DVMWVDMNZYHAZDENBUGY32O5DSNFTWOZLSUZRXEZLBORSQ.
You are receiving this email because you authored the thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I discovered something interesting. It seems like Pydantic has a data conversion mechanism that converts strings, like 1, to integers. What do you all think? Should we enable strict type checking or use a str type for id?
from pydantic.dataclasses import dataclass

@dataclass
class Model(BaseModel):
    a: int
    b: float
    c: str

print(Model(a=3.1415, b=' 2.72 ', c=123).dict())
#> {'a': 3, 'b': 2.72, 'c': '123'}

from pydantic import StrictInt

class StrictIntModel(BaseModel):
    strict_int: StrictInt

try:
    StrictIntModel(strict_int=3.14159)
except ValidationError as e:
    print(e)
    """
    1 validation error for StrictIntModel
    strict_int
      value is not a valid integer (type=type_error.integer)
    """

I think we are forgiving about actions, or we are trying to, because the majority of them come from the LLM. Currently, if the LLM is sending something that isn't quite right, but we can figure out how to fix it, then we fix it. We try to do that with JSON 'fixes' for example, which we apply on the raw response.
It seems to me that sending '42' for the kill command instead of 42, or the other way around, is one of those we can try to fix and continue normally. Same for things like 'background': false, if it ever happens to be 'background': 'false'.
{
  "action": "message",
  "args": {
    "content": "I should start by researching existing solutions to the twelve queens problem in Python.",
    "wait_for_response": false
  }
}

On the other hand, somewhere in my archived logs, there's this:
{
  "action": "kill",
  "args": {
    "id": "kill pid"
  }
}

😆
(I think I asked it to send itself a kill)
This action did fail, as expected, we can't imagine what pid it wanted. It failed in the ssh_box with SandboxInvalidBackgroundCommandError, and that error was sent to the LLM. (Apparently the LLM was... err, happy about it, because next time it sent a Finish action. 😅 Good for you, GPT.)
With validation, it would fail sooner. That... seems the right behavior, doesn't it?

It seems to me that sending '42' for the kill command instead of 42, or the other way around, is one of those we can try to fix and continue normally. Same for things like 'background': false, if it ever happens to be 'background': 'false'.

First thing that come out of my mind is what if we add args type in prompt? like

kill - kills a background command

id: int - the ID of the background command to kill

FWIW I just removed good first issue label as this is getting more complicated than I initially thought ;)

First thing that come out of my mind is what if we add args type in prompt?

That will help a bit, but still LLMs can make mistakes. I don't think adding it necessary if we have a way (and if we need a way anyways) to fix it.
It adding a prompt doesn't make the workflow marginally better, then we should double think before doing it.