[Bug] When running the GUI, the debug logs are being spammed

What happened?
The GUI is causing the daemon debug logs to send an excessive amount of WSMessage is_running messages, at least one every second. When launching the services from the CLI, no such messages are being seen.
Version
1.5.1 dev454
What platform are you using?
Windows
What ui mode are you using?
GUI
Relevant log output or stacktrace
No response

This is actually by design, but I think we can back off on the once-a-second polling. @seeden do you see any reason why we can't back this off to maybe every 5 seconds or so?

PR ready. Closing it


YARN-11324. Fix some PBImpl classes to avoid NPE.

JIRA: YARN-11324. Fix some PBImpl classes to avoid NPE.
When completing YARN-11323, I found that there is a bug in ApplicationHomeSubClusterPBImpl, which may cause a null pointer exception when getting getApplicationId
@Test
public void testGetApplicationIdNullException() throws YarnException {
  ApplicationId appId = ApplicationId.newInstance(Time.now(), 1);
  ApplicationHomeSubCluster appHomeSC = ApplicationHomeSubCluster.newInstance(
      appId, subClusterId);
  System.out.println(appHomeSC.getApplicationId());
}

We can see the following results:

After we set the ApplicationId, direct get will get a null value.
Why this problem occurs？
The reason for this problem is because we did not set a value for ApplicationHomeSubClusterProtoOrBuilder when we setApplication
Improve the code:
1.set a value for ApplicationHomeSubClusterProtoOrBuilder when we setApplication.
2.At the same time, in order to improve the access efficiency, we should first check whether the internal property is empty when getApplication. If it is not empty, we can return it directly. If it is empty, we convert it from the proto object.
While modifying ApplicationHomeSubClusterImpl, I will check the pbImpl classes of all router modules to make sure all pbimpl are fixed.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 30s

trunk passed

+1 :green_heart:
compile
0m 51s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 50s

trunk passed

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 45s

trunk passed

+1 :green_heart:
shadedclient
24m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 20s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
1m 35s
/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.html
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0)

+1 :green_heart:
shadedclient
27m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
3m  4s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

111m 41s

Reason
Tests

SpotBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Null passed for non-null parameter of convertToProtoFormat(SubClusterId) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.ApplicationHomeSubClusterPBImpl.setHomeSubCluster(SubClusterId)  Method invoked at ApplicationHomeSubClusterPBImpl.java:of convertToProtoFormat(SubClusterId) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.ApplicationHomeSubClusterPBImpl.setHomeSubCluster(SubClusterId)  Method invoked at ApplicationHomeSubClusterPBImpl.java:[line 155]

Null passed for non-null parameter of convertToProtoFormat(SubClusterInfo) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.GetSubClusterInfoResponsePBImpl.setSubClusterInfo(SubClusterInfo)  Method invoked at GetSubClusterInfoResponsePBImpl.java:of convertToProtoFormat(SubClusterInfo) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.GetSubClusterInfoResponsePBImpl.setSubClusterInfo(SubClusterInfo)  Method invoked at GetSubClusterInfoResponsePBImpl.java:[line 123]

Null passed for non-null parameter of convertToProtoFormat(SubClusterPolicyConfiguration) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.GetSubClusterPolicyConfigurationResponsePBImpl.setPolicyConfiguration(SubClusterPolicyConfiguration)  Method invoked at GetSubClusterPolicyConfigurationResponsePBImpl.java:of convertToProtoFormat(SubClusterPolicyConfiguration) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.GetSubClusterPolicyConfigurationResponsePBImpl.setPolicyConfiguration(SubClusterPolicyConfiguration)  Method invoked at GetSubClusterPolicyConfigurationResponsePBImpl.java:[line 131]

Null passed for non-null parameter of convertToProtoFormat(RouterMasterKey) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.RouterMasterKeyRequestPBImpl.setRouterMasterKey(RouterMasterKey)  Method invoked at RouterMasterKeyRequestPBImpl.java:of convertToProtoFormat(RouterMasterKey) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.RouterMasterKeyRequestPBImpl.setRouterMasterKey(RouterMasterKey)  Method invoked at RouterMasterKeyRequestPBImpl.java:[line 98]

Null passed for non-null parameter of convertToProtoFormat(RouterMasterKey) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.RouterMasterKeyResponsePBImpl.setRouterMasterKey(RouterMasterKey)  Method invoked at RouterMasterKeyResponsePBImpl.java:of convertToProtoFormat(RouterMasterKey) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.RouterMasterKeyResponsePBImpl.setRouterMasterKey(RouterMasterKey)  Method invoked at RouterMasterKeyResponsePBImpl.java:[line 98]

Null passed for non-null parameter of convertToProtoFormat(SubClusterPolicyConfiguration) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.SetSubClusterPolicyConfigurationRequestPBImpl.setPolicyConfiguration(SubClusterPolicyConfiguration)  Method invoked at SetSubClusterPolicyConfigurationRequestPBImpl.java:of convertToProtoFormat(SubClusterPolicyConfiguration) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.SetSubClusterPolicyConfigurationRequestPBImpl.setPolicyConfiguration(SubClusterPolicyConfiguration)  Method invoked at SetSubClusterPolicyConfigurationRequestPBImpl.java:[line 131]

Null passed for non-null parameter of convertToProtoFormat(SubClusterId) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.SubClusterHeartbeatRequestPBImpl.setSubClusterId(SubClusterId)  Method invoked at SubClusterHeartbeatRequestPBImpl.java:of convertToProtoFormat(SubClusterId) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.SubClusterHeartbeatRequestPBImpl.setSubClusterId(SubClusterId)  Method invoked at SubClusterHeartbeatRequestPBImpl.java:[line 127]

Null passed for non-null parameter of convertToProtoFormat(SubClusterId) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.SubClusterInfoPBImpl.setSubClusterId(SubClusterId)  Method invoked at SubClusterInfoPBImpl.java:of convertToProtoFormat(SubClusterId) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.SubClusterInfoPBImpl.setSubClusterId(SubClusterId)  Method invoked at SubClusterInfoPBImpl.java:[line 109]

Null passed for non-null parameter of convertToProtoFormat(SubClusterInfo) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.SubClusterRegisterRequestPBImpl.setSubClusterInfo(SubClusterInfo)  Method invoked at SubClusterRegisterRequestPBImpl.java:of convertToProtoFormat(SubClusterInfo) in org.apache.hadoop.yarn.server.federation.store.records.impl.pb.SubClusterRegisterRequestPBImpl.setSubClusterInfo(SubClusterInfo)  Method invoked at SubClusterRegisterRequestPBImpl.java:[line 123]

Failed junit tests
hadoop.yarn.server.federation.store.impl.TestZookeeperFederationStateStore

hadoop.yarn.server.federation.policies.router.TestHashBasedRouterPolicy

hadoop.yarn.server.federation.policies.manager.TestPriorityBroadcastPolicyManager

hadoop.yarn.server.federation.policies.TestFederationPolicyInitializationContextValidator

hadoop.yarn.server.federation.policies.router.TestRejectRouterPolicy

hadoop.yarn.server.federation.policies.router.TestUniformRandomRouterPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestHomeAMRMProxyPolicy

hadoop.yarn.server.federation.policies.manager.TestUniformBroadcastPolicyManager

hadoop.yarn.server.federation.policies.amrmproxy.TestRejectAMRMProxyPolicy

hadoop.yarn.server.federation.policies.manager.TestRejectAllPolicyManager

hadoop.yarn.server.federation.policies.router.TestWeightedRandomRouterPolicy

hadoop.yarn.server.federation.store.utils.TestFederationStateStoreInputValidator

hadoop.yarn.server.federation.policies.amrmproxy.TestBroadcastAMRMProxyFederationPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestLocalityMulticastAMRMProxyPolicy

hadoop.yarn.server.federation.store.impl.TestMemoryFederationStateStore

hadoop.yarn.server.federation.policies.manager.TestWeightedLocalityPolicyManager

hadoop.yarn.server.federation.policies.manager.TestHashBasedBroadcastPolicyManager

hadoop.yarn.server.federation.policies.router.TestLoadBasedRouterPolicy

hadoop.yarn.server.federation.policies.router.TestLocalityRouterPolicy

hadoop.yarn.server.federation.policies.manager.TestHomePolicyManager

hadoop.yarn.server.federation.policies.router.TestPriorityRouterPolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4961

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 19a62a602d5d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 69d163491e3da3ec902949c7a77314079ae50086

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/1/testReport/

Max. process+thread count
601 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  6s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 10s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 51s

trunk passed

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 44s

trunk passed

+1 :green_heart:
shadedclient
24m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 30s

the patch passed

+1 :green_heart:
shadedclient
26m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
3m 36s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

110m 46s

Reason
Tests

Failed junit tests
hadoop.yarn.server.federation.store.impl.TestZookeeperFederationStateStore

hadoop.yarn.server.federation.policies.router.TestHashBasedRouterPolicy

hadoop.yarn.server.federation.policies.manager.TestPriorityBroadcastPolicyManager

hadoop.yarn.server.federation.policies.TestFederationPolicyInitializationContextValidator

hadoop.yarn.server.federation.policies.router.TestRejectRouterPolicy

hadoop.yarn.server.federation.policies.router.TestUniformRandomRouterPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestHomeAMRMProxyPolicy

hadoop.yarn.server.federation.policies.manager.TestUniformBroadcastPolicyManager

hadoop.yarn.server.federation.policies.amrmproxy.TestRejectAMRMProxyPolicy

hadoop.yarn.server.federation.policies.manager.TestRejectAllPolicyManager

hadoop.yarn.server.federation.policies.router.TestWeightedRandomRouterPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestBroadcastAMRMProxyFederationPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestLocalityMulticastAMRMProxyPolicy

hadoop.yarn.server.federation.store.impl.TestMemoryFederationStateStore

hadoop.yarn.server.federation.policies.manager.TestWeightedLocalityPolicyManager

hadoop.yarn.server.federation.policies.manager.TestHashBasedBroadcastPolicyManager

hadoop.yarn.server.federation.policies.router.TestLoadBasedRouterPolicy

hadoop.yarn.server.federation.policies.router.TestLocalityRouterPolicy

hadoop.yarn.server.federation.policies.manager.TestHomePolicyManager

hadoop.yarn.server.federation.policies.router.TestPriorityRouterPolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4961

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cc2e3cf9599e 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 853d39234dae82a62a32ddc121e5d99fe4129cb5

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/2/testReport/

Max. process+thread count
532 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 46s

trunk passed

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 50s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 49s

trunk passed

+1 :green_heart:
shadedclient
24m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 20s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 34s

the patch passed

+1 :green_heart:
shadedclient
23m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
3m  1s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

107m 20s

Reason
Tests

Failed junit tests
hadoop.yarn.server.federation.policies.router.TestHashBasedRouterPolicy

hadoop.yarn.server.federation.policies.manager.TestPriorityBroadcastPolicyManager

hadoop.yarn.server.federation.policies.TestFederationPolicyInitializationContextValidator

hadoop.yarn.server.federation.policies.router.TestRejectRouterPolicy

hadoop.yarn.server.federation.policies.router.TestUniformRandomRouterPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestHomeAMRMProxyPolicy

hadoop.yarn.server.federation.policies.manager.TestUniformBroadcastPolicyManager

hadoop.yarn.server.federation.policies.amrmproxy.TestRejectAMRMProxyPolicy

hadoop.yarn.server.federation.policies.manager.TestRejectAllPolicyManager

hadoop.yarn.server.federation.policies.router.TestWeightedRandomRouterPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestBroadcastAMRMProxyFederationPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestLocalityMulticastAMRMProxyPolicy

hadoop.yarn.server.federation.policies.manager.TestWeightedLocalityPolicyManager

hadoop.yarn.server.federation.policies.manager.TestHashBasedBroadcastPolicyManager

hadoop.yarn.server.federation.policies.router.TestLoadBasedRouterPolicy

hadoop.yarn.server.federation.policies.router.TestLocalityRouterPolicy

hadoop.yarn.server.federation.policies.manager.TestHomePolicyManager

hadoop.yarn.server.federation.policies.router.TestPriorityRouterPolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4961

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9899bba6d2f5 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0276c5e2310e2dc5d27d3f21ad823e02dc0c955d

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/3/testReport/

Max. process+thread count
591 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks for working on this.
Latest commit also has checkstyle violations and failed test. Could you pls review and update?

Thank you very much for your help reviewing the code, I will fix it asap.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 42s

trunk passed

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 40s

trunk passed

+1 :green_heart:
mvnsite
0m 53s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 43s

trunk passed

+1 :green_heart:
shadedclient
24m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 36s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 30s

the patch passed

+1 :green_heart:
shadedclient
23m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
3m  0s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

107m  8s

Reason
Tests

Failed junit tests
hadoop.yarn.server.federation.policies.amrmproxy.TestHomeAMRMProxyPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestRejectAMRMProxyPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestBroadcastAMRMProxyFederationPolicy

hadoop.yarn.server.federation.policies.amrmproxy.TestLocalityMulticastAMRMProxyPolicy

hadoop.yarn.server.federation.policies.router.TestPriorityRouterPolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4961

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a009109a3bc2 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2b11ace9586a52cd769af787f9ecba202f8163cb

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/4/testReport/

Max. process+thread count
577 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m  9s

trunk passed

+1 :green_heart:
compile
1m  0s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 47s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 51s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 47s

trunk passed

+1 :green_heart:
shadedclient
25m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
0m 48s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 48s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 24s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)

+1 :green_heart:
mvnsite
0m 43s

the patch passed

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 47s

the patch passed

+1 :green_heart:
shadedclient
24m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  2s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

111m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4961

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b2d929e4fdcf 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk /<PHONE_NUMBER>4078cdc6aee62be96def3d34e0e492

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/5/testReport/

Max. process+thread count
600 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 22s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 44s

trunk passed

+1 :green_heart:
compile
0m 51s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 52s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 43s

trunk passed

+1 :green_heart:
shadedclient
24m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 38s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 31s

the patch passed

+1 :green_heart:
shadedclient
23m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 20s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

108m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4961

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 24c74a8030bd 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3978017ad5c303ea962f7da178c5ed0448d6c74c

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/6/testReport/

Max. process+thread count
532 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4961/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@dineshchitlangia Thank you very much for your help reviewing the code!


DNM: Interchain Security

Description
DO NOT MERGE.
Updates to ibc-go needed for interchain security. This is the main branch utilized in simple distribution in interchain security (soon on main as well) https://github.com/cosmos/interchain-security/pull/32
Updates in this PR:

Packet reconstruction from events for testing.
CommitBlock now returns tendermint responses (such that events can be extracted and packets reconstructed).

Before Merge:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Hey @rigelrozanski. Thanks for using ibc-go and making improvements to the testing package! Really nice to see the testing package get usage outside of ibc-go!
It would be amazing if you could open up issues for the changes this pr makes (each change in a separate issue). That way we could discuss the changes and determine if there are any other improvements we could make along the way. We prefer to have each of the changes encapsulated in a separate pr (rather than one big one). This is because it reduces the burden of pr reviews and allows the less contested changes to be merged into main faster. Often times it is only a few lines of code that causes a pr to be merged weeks after it is opened.
If the changes made are useful for Interchain Security, they may be just as useful to other projects so it'd be great to get them included in a release asap.
Lots of folks watch this repository and it can be misleading to read "DNM: Interchain Security" as it might imply a feature branch for interchain security, but ibc-go does not have plans to merge Interchain Security into the codebase. For this reason I'm going to close this pr. Please reopen individual prs with the fixes, or at least issues so we can work fixing/reviewing the changes into our development cycle/plans.
Thanks again for the contribution! I know this a bit more work (even for perhaps minor changes), but following the contribution standards we have built up is very important not only to ensure we deliver the best possible changes at the fastest pace possible, but also with consideration to the quality of life for our developers


ENH make sure notebooks can understand imports from other python files in same original directory

this seems to be...fine?

it was only fine because of an editable install I did

closed by #49


nodejs is hard-coded to http, does not support https

tus-js-client/lib.es5/node/request.js
Does a require("http") even if the tus server url is a https://... and fails with a protocol not supported error
We have this requirement, because we must proxy tus through an ssl secured apache.
I tried to simply switch it out for https, but get another error:
/var/vinubis/tusnode/tus.js:15
    throw error;
    ^

Error: tus: unexpected response while creating upload
    at Request.xhr.onload (/var/vinubis/tusnode/node_modules/tus-js-client/lib.es5/upload.js:253:36)
    at ClientRequest.<anonymous> (/var/vinubis/tusnode/node_modules/tus-js-client/lib.es5/node/request.js:70:15)
    at emitOne (events.js:77:13)
    at ClientRequest.emit (events.js:169:7)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:430:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:103:23)
    at TLSSocket.socketOnData (_http_client.js:320:20)
    at emitOne (events.js:77:13)
    at TLSSocket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:153:18)

I will try to get out some debuggin info and fix it.
If you have any hints regarding this second error, please let me know :)

The Problem was, it did only work with a slash at the end of the endpoint url.
endpoint: "https://my.server.com/upload/tus/",
Didn't work:
endpoint: "https://my.server.com/upload/tus",

https://github.com/tus/tus-js-client/pull/45

Thank you a lot for your reporting, the investigation and the immediate patch. :+1:


Support subPath in generated container

This is something which is useful together https://github.com/zalando-incubator/postgres-operator/pull/445 or sidecars when they get support of arbitrary volume mounts.
These containers might want to use volume for their own need, but it should not interfere with Spilo/Patroni container, so safest way is to use subPath in Patroni container.
This change is completely transparent for Patroni, paths in container remain the same and nothing changes from it's point of view.

https://kubernetes.io/docs/concepts/storage/volumes/#using-subpath-with-expanded-environment-variables
Is this an issue for clusters without this feature gate in 1.11 and how is the omission treated?

@Jan-M,  subPath expansion is the feature of the cluster, if it is enabled then every subpath is subject to expansion logic similar to one done for args and environment variables. subPath from this patch is used directly as-is in container's volume mounts subPath. subPath itself is not feature-gated and available since forever , only variable expansion in subpath value is subject to that feature gate.

@redbaron could you reflect your change also in util_test?
Instead of "volume":{"size":"","storageClass":""} it has to be "volume":{"size":"","storageClass":"", "subPath":""}
Or you make subPath omitempty in the type declaration (which I would prefer):
SubPath string json:"subPath,omitempty"`

@FxKu, rebased  and added omitempty tag

Thanks for updating :)
Looks fine for me now, although one of the tests in util_test could use an example for subPath

rebased and added omitempty tag

Indeed, thanks!

Looks fine for me now, although one of the tests in util_test could use an example for subPath

Agree, the PR looks good, but I would also ask for a simple unit test.

@FxKu, @erthalion , updated one test with subpath value

:+1:

Happy Monday! would be great to get it into 1.2

:+1:


Delete more than one project at once

/kind feature
Which functionality do you think we should add?
Delete more than one project at once either.

Delete a list of projects separated by space.

odo project delete cmd-service-test60xec cmd-service-test60yed cmd-service-test207iab

Delete projects matching a pattern.

odo project delete cmd-service-test-*

Why is this needed?
It is just annoying when I want to delete more than one project and I can only delete 1 at a time.

It is just annoying when I want to delete more than one project and I can only delete 1 at a time.

I understand your use case, but when would normal odo user need that?

I understand your use case (btw, you can use oc or kubectl for that), but when would normal odo user need that?

There isn't any particular use case I can think of. I encountered this while cleaning up my cluster where I had multiple projects I wanted to delete and it was annoying to delete one project at a time via odo, and web console and I was not aware that kubectl and oc could do it easily. I understand this would be a rarely used case, but it can be helpful when people are not aware of kubectl and oc. It is a nice-to-have feature.


Deprecated directives from Angular UI

We seem to be using deprecated directives in Angular UI. Did we upgrade Angular UI recently?
In any case, we should switch to the new directives:

Right. We upgraded in https://github.com/twosigma/beaker-notebook/pull/3013
Issue about warnings already exists: https://github.com/twosigma/beaker-notebook/issues/3064

OK thanks, I missed that...closing this since it's a duplicate.


Error deploy app service azure

<Please be sure to remove any private information before submitting.>
Repro steps:
<Enter steps to reproduce issue>
Action: appService.Deploy
Error type: UNABLE_TO_VERIFY_LEAF_SIGNATURE
Error Message: unable to verify the first certificate
Version: 0.12.0
OS: darwin

Closing as external. VS Code has made some improvements to certs on Insiders and it was working for me there. See Microsoft/vscode#52880


t.match with two params logs failure message even on successful match

If you omit the optional third argument when using the new the t.match assertion, a default message is written to the console as per all other assertions, but currently it incorrectly comes to the conclusion that the match was a failure even when it passes.
For example:
ok 1 The input did not match the regular expression /abc/. Input: 'abc123'

Whoops :-) good catch!


Self hosted stable diffusion

We need to host some image generate software to generate illustrations for Testomania App
Also maybe if it will work we can even sell our image generator API

Maybe be useful:
https://www.linkedin.com/posts/christopherobereder_ai-data-jobs-activity-7022212750399430656-Zx6A?utm_source=share&utm_medium=member_desktop

https://www.howtogeek.com/853529/hardware-for-stable-diffusion/
https://adashop.ge/product/63b69a81ec8938e3f50778ec

Relates to this task also:
https://github.com/Nodrex/Testomania/issues/279

https://adashop.ge/product/627e1662e5b4303c2c8c1f75

Maybe it will be helpful:
https://levelup.gitconnected.com/8-ways-chatgpt-helps-you-boost-your-programming-productivity-8f4999e3a624#:~:text=7 — Generate training,and “sports”.


What are bounding box labels for?

In this code:
def run_ours_box(img_path, pts_sampled, model):
    bbox = torch.reshape(torch.tensor(pts_sampled), [1, 1, 2, 2])
    bbox_labels = torch.reshape(torch.tensor([2, 3]), [1, 1, 2])
    image = cv2.imread(image_path)
    image = cv2.cvtColor(image, cv2.COLOR_BGR2RGB)

    predicted_logits, predicted_iou = model(
        img_tensor[None, ...].cuda(),
        bbox.cuda(),
        bbox_labels.cuda(),
    )

... what are the bbox_labels doing? Why are they [2,3], and why does the model need them? I couldn't find that described in the paper either. Maybe I missed it...
thx!

The model uses the same interface to encode both points and bounding boxes. The bbox_labels (in this case) that is to tell the model that the input points are corners of the bounding box (rather than just points inside the sought mask). Bounding box corner gets a label of 2 and 3 respectively. Points within a mask gets a label of 1.

Ah, check, thx.


SMIRNOFF: Support interpolated improper torsions

There might be interest in doing WBO-based parameter interpolation. It's unclear at the moment if this is scientifically useful, but @davidlmobley says some A spec for this should be feasible given that it's already implemented for proper torsions (and bonds). I'm not sure how the interpolation should actually happen given that there is no central bond in a torsion; probably the people doing science on this do (maybe @SimonBoothroyd?).

Actually, yes, this is a strong reason to hold on this - there's a problem of "which bond" that really means we ought to do the more of the science first.

@davidlmobley do you think as a test we can interpolate based on wbo of central atom (second atom) and out of plane atom (fourth atom), as we see a faint signal in the attached image?

@pavankum and I wrote out a couple different ways this could be implemented using my elementary drawing skills. Each seem feasible to me if scientifically on the right track and desired by the science team. It would be ideal for this to be specific in SMIRNOFF before implementing, although we can explore ways to support this in an experimental implementation if that would be useful in determining how the spec should be written.

https://gist.github.com/mattwthompson/22788dbeb740e2978addaf7a5ff81f38
https://gist.github.com/mattwthompson/31713ca4275f375136afdbaa88086b6b

My physical organic chemistry may not be as strong as @cbayly13, but isn't the idea here that you simply need to compute a WBO-like quantity that interpolates between sp2 and sp3 parameters for an improper?
The best WBO-like quantity would compute the sp2/sp3-likeness quantity directly from the wavefunction, rather than attempting to derive it from WBOs. But if WBOs are all we have, I would imagine that something like the maximum of all the WBOs to the incident atom will go between 1 (for sp3) and 2 (for sp2), and should be sufficient for our purposes.

To @jchodera 's point, I believe @jmaat did look at "maximum of WBOs to the relevant atom" before and didn't find anything helpful, but it may be that it's worth checking again on this relatively more tailored dataset.
@pavankum if you have patterns such that the out-of-plane atom is always the fourth atom, then:

@davidlmobley do you think as a test we can interpolate based on wbo of central atom (second atom) and out of plane atom (fourth atom), as we see a faint signal in the attached image?

this is probably worth checking.
The challenge here is that we are facing a bit of a chicken-and-egg problem, in that we can't really test our ideas in force fields until the toolkit supports WBO-interpolated impropers, and we aren't going to be fully sure what type of interpolation we want until we try it in a force field, for which we need toolkit support. I wonder if there is a way we can use plugins to do this?
Alternatively, I wonder if a better idea is to make a "bespoke" improper torsion fitter, where you would run some calculation on a "per molecule" basis to assign a custom improper for that molecule based on whatever bond order you like (even an interpolated one), then test it out. If this works well, THEN we get support for the tested interpolation into the toolkit. This leaves the devs out until the science is more settled.
So to Matt's point:

It would be ideal for this to be specific in SMIRNOFF before implementing, although we can explore ways to support this in an experimental implementation if that would be useful in determining how the spec should be written.

Yes! Pavan, what do you think of my idea above? What if we just write a script which generates a custom improper parameter for each molecule you want to look at, using whatever interpolation we MAY want to have implemented in the toolkit... then we see how it works, and when we find something which works quite well THEN we get it implemented?
I could see this could make testing more complex, however, because our benchmarking likely assumes we are using a consistent force field across all molecules... 🤔


[neon/acr] impr: push to ACR while building images

Merge this strictly after neoneastus2 terraformed.
This tests the ability to push into ACR using OIDC. Previos run in this branch proves that. In promote-images we push the following images neon compute-tools {vm-,}compute-node-{v14,v15,v16} into neoneastus2.
https://github.com/neondatabase/cloud/issues/14640

Before merging it, let's remove if: github.ref_name == 'main' part and see if it work in the PR

I had it pushed in previous version https://github.com/neondatabase/neon/actions/runs/10149694500/job/28065170110#step:7:6

Checked that it worked.


improve auto-increment in VM name

Description
When creating multiple VMs it is possible to use %i which will increment starting from 0.
In an environment where VM names are very important, it would be useful to be able to have more control over the automatic increment variable.
Use case
If I have already existing VMs "myvm-001", "myvm-002", "myvm-003" and I would like to create 3 new VMs  following the same scheme, I would like to be able to start from 4 and have the possibility to have 0s prefixing the ID. So I could create "myvm-%i" starting from 004 to 015 for example.
Interface Changes
add an optional startID field
add an optional prefix field

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

This is still interesting

I'm still interested in the feature.
Thank you.

This will be implemented using #2287, closing this.


执行 python freeline.py -f  报错，怎么解决

python freeline.py -f
[INFO] preparing for tasks...
[-][read_project_info_task] failed. in 0.0s
[-][generate_file_stat_task] finished. in 0.1s
[-][gradle_clean_build_task] failed. in 0s
[-][clean_all_cache_task] failed. in 0s
[-][install_apk_task] failed. in 0s
[-][build_base_resource_task] failed. in 0s
[-][generate_project_info_task] failed. in 0s
[-][generate_apt_files_task] failed. in 0s
[-][append_file_stat_task] failed. in 0s
[ERROR] --------------------------------------------------------
[ERROR] Freeline ERROR
[ERROR] --------------------------------------------------------
Traceback (most recent call last):
File "/Users/menmen/Desktop/weex-androd/freeline/freeline_core/task.py", line 123, in execute
self.task.execute()
File "/Users/menmen/Desktop/weex-androd/freeline/freeline_core/gradle_clean_build.py", line 75, in execute
output, err, code = cexec(command.split(' '), callback=None)
File "/Users/menmen/Desktop/weex-androd/freeline/freeline_core/utils.py", line 28, in cexec
p = Popen(args, stdin=PIPE, stdout=PIPE, stderr=PIPE, env=env, cwd=cwd)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in init
errread, errwrite)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
raise child_exception
OSError: [Errno 13] Permission denied

有说需要修改工程下，freeline下的release-tools文件的读写权限，修改后仍旧无效

找到原因了，修改chmod +x gradlew


fix: crash while change orientation on iOS 12

Please rename PR: "fix: crash while changing orientation on iOS 12".


minimize returns success with a result full of nans

scipy.minimize(method='SLSQP') returns success even though the result is nan. Note that the constraints are not satisfiable.
Reproducing code example:

from scipy.optimize import minimize
import numpy as np

if __name__ == "__main__":
    np.random.seed(10)

    cons = ({'type': 'ineq', 'fun': lambda x: -x[0] - x[1] - 3},
            {'type': 'ineq', 'fun': lambda x: x[1] + x[2] - 2})
    bnds = ((-2, 2), (-2, 2), (-2, 2))

    target = lambda x: 1
    res = minimize(target, [-1.8869783504471584, -0.640096352696244, -0.8174212253407696], method='SLSQP', bounds=bnds, constraints=cons, options={'disp':False, 'maxiter':10000})
    for i, c in enumerate(cons):
        print("the value of constraint function {} is {}".format(i, c['fun'](res.x)))
    print(res)

Error message:

the value of constraint function 0 is nan
the value of constraint function 1 is nan
     fun: 1.0
     jac: array([0., 0., 0.])
 message: 'Optimization terminated successfully.'
    nfev: 106
     nit: 10
    njev: 9
  status: 0
 success: True
       x: array([nan, nan, nan])

Scipy/Numpy/Python version information:

scipy 1.1.0
numpy 1.15.4
python 3.6.6

That's a pretty pathological problem. I agree though that success: True is a bug here.

I have digging deep in code.
In my opinion, ldp function is a potential problem.
In that case, fac value is nan but nothing happened any raises in this routine.
If I check the nan by ISNAN, they shows false flag for success.
(please ignore an error message).

https://github.com/scipy/scipy/blob/f4b560df7fd2b86ab583ef1be8d9df485a16c39a/scipy/optimize/slsqp/slsqp_optmz.f#L1076

the value of constraint function 0 is -0.12032366628974378
the value of constraint function 1 is -0.8796763337102562
     fun: 1.0
     jac: array([0., 0., 0.])
 message: 'Inequality constraints incompatible'
    nfev: 95
     nit: 10
    njev: 9
  status: 4
 success: False
       x: array([-2.        , -0.87967633,  2.        ])

We put an explicit bound, equality, and inequality constraint check at the end of linprog. If anything does not satisfy the tolerance,  linprog reports failure. That might be useful for minimize.

@akahard2dj It seems that you fix it? What should I do to make it work?

@mdhaber You mean we should write our own checking logic instead of using the one returned by scipy? If it indeed fails, we just try another initial point?

Is the behavior of returning nan when constraints are not satisfiable mathematically correct or not? I would appreciate your help as I am not very familiar with the underlying math. Thanks!

Before, I also found a bug when the constraints are actually satisfiable. I posted it here.

@jingxixu this is a bug in your code. You should not have to write your own logic to check whether constraints are satisfied - but for now you might have to do that. I'm suggesting that a way to fix this is to add such a check inside minimize.

@mdhaber Thanks for your valuable comments in this issue.

this is not a bug in your code. Ideally, you should not have to write your own logic to check whether constraints are satisfied - but until this bug is fixed, you might have to do that.

But I have a question to you. As you already mentioned above this is not a bug.
I have checked this routine line by line. During optimization process, jacobian vector goes to zero.
so fac in ldp function is nan. This is not a problem in your scope?
I really want to know the mechanism in this issue. Thanks in advance. :)

minimize should only report success=True when the resulting solution xsatisfies the constraints.
An array of nans doesn't satisfy the constraints.
Therefore minimize should not report success=True in this case.
Nonetheless, minimize does report success=True in this case.
Therefore, minimize has a bug that we need to fix.
jingxixu's problem may be difficult to solve, but the bug is in minimize, not in jingxixu's code.

But I have a question to you. As you already mentioned above this is not a bug.

This is a bug in minimize, not in jingxixu's  code.

so fac in ldp function is nan. This is not a problem in your scope?

This does sound like problem. I have not looked into it, though, so I can't comment about that.  Note that algorithms may encounter numerical difficulties for certain guesses. So this might not be a bug in the code, but the algorithm may not be as robust as we might like.
@jingxixu in any case, you should be using linprog to solve this particular problem, as your constraints are all linear, and you don't seem to care about the objective.
From the documentation, "Equality constraint means that the constraint function result is to be zero whereas inequality means that it is to be non-negative". So your constraints are:
-x[0] - x[1] - 3 >= 0
x[1] + x[2] - 2 >= 0
This is the same as:
x[0] + x[1]           <= -3
- x[1] - x[2] <= -2
Collect your coefficients into a matrix:
A_ub = [[1, 1, 0], [0, -1, -1]]
and the right hand sides into a vector:
b_ub = [-3, -2]
Your bounds are:
bounds = (-2, 2)
Your objective function is a constant, so it is not affected by the decision variables (x). Consequently, we can choose random coefficients for a linear objective function and simply remember that whatever the values of the decision variables, the objective is 1.
c = np.random.rand(3)
Now solve the problem:
from scipy.optimize import linprog
A_ub = [[1, 1, 0], [0, -1, -1]]
b_ub = [-3, -2]
bounds = (-2, 2)
c = np.random.rand(3)
linprog(c, A_ub, b_ub, bounds=bounds, method="interior-point")  # interior-point is more reliable

I get:
     con: array([], dtype=float64)
     fun: -1.2202579594076748
 message: 'The algorithm terminated successfully and determined that the problem is infeasible.'
     nit: 4
   slack: array([-0.79830443, -2.44728125])
  status: 2
 success: False
       x: array([-1.40403668, -0.79765888,  0.35037764])

So if I rewrote the problem correctly, then the problem seems to be infeasible.

@mdhaber Thanks for the detailed explanation! However, I am using linear constraints here just for demo. My goal is to get a feasible solution which satisfies a large set of nonlinear constraints, and yes, I do not have an objective function to optimize. I only want to quickly sample a feasible solution from the feasible set. Are you by any chance aware of any other packages/methods that can achieve my goal, apart from scipy's sequential quadratic programming?

@jingxixu I figured that the linear example was for demonstration, but I thought I should mention it for anyone else reviewing this post.
Have you tried method='trust-constr'

I am having the same issue with returning success with a result full of nans for the following methods: Powell, CG, BFGS, Newton-CG, L-BFGS-B, TNC, COBYLA, SLSQP.
As an example:
results = op.minimize(neg_log_like, gp.get_parameter_vector(), jac=grad_neg_log_like, method="L-BFGS-B", tol=1e-6)
The output os results is:
 hess_inv: <5x5 LbfgsInvHessProduct with dtype=float64>
      jac: array([-0., -0., -0., -0., -0.])
  message: b'CONVERGENCE: NORM_OF_PROJECTED_GRADIENT_<=_PGTOL'
     nfev: 15
      nit: 4
   status: 0
  success: True
        x: array([ nan,  nan,  nan,  nan,  nan])```


Quota increase request

Maximum number of workers for the workspace - 6000
Business Justification:
We would like to perform a load test for 6000 users and monitor the performance and get some analytics.
Requested New Quota Limit:
6000 workers.
Additional Information:
Setup Information:

Subscription ID: 8ff85366-7f6b-4c50-a470-071bbf4ced73
Workspace ID: pwraptortests

Disclaimer:
Please note that while we will do our best to accommodate your quota extension request, we may not be able to fulfill every request due to resource constraints. We will review your request and provide a response as soon as possible.
AB#1925493

@JanakiramanPachaiyappan We'd like to understand your scenario better. We can discuss about possible approaches to do this testing. Would it be possible to schedule a meeting to go over this?
You can write to us at<EMAIL_ADDRESS>to take the conversation forward.
Thanks

Hi @JanakiramanPachaiyappan ,
Please let us know how we can connect. We want to understand your use-case in more detail and discuss approaches you can use to solve this.

Hi @vvs11, I have sent you email on this. Thanks.

Closing this and taking it forward in offline conversation


RNS integration

Closes #311
Also fixes ENS integration when sending tokens

Hi @vbaranov ! I see you released the feature but it's not available in my wallet, can you help me out? Thanks!

@ilanolkies could you describe expected and actual behaviour? and which version of Nifty wallet do you use?

Version 5.1.1
I woud like to use domains as expected. This is not possible now even this PR was release.
Ethereum:

RSK Mainnet:

https://manager.rns.rifos.org/resolve?name=ilanolkies.rsk
RSK Testnet:

https://testnet.manager.rns.rifos.org/resolve?name=testing.rsk

@ilanolkies it was a bug, that I missed in this PR. Sorry about that. I fixed it https://github.com/poanetwork/nifty-wallet/pull/400. It will be added to the next 5.1.2 release of Nifty wallet.

Thanks team! I appreciate it 🙂


ja: Make docs/tutorials/kubernetes-basics/deploy-app/deploy-interactive.html follow v1.18 of the original text

This is a Feature Request

What would you like to be added
Update docs/tutorials/kubernetes-basics/deploy-app/deploy-interactive.html to follow v1.18 of the original (English) text.
Why is this needed
content/ja/docs/tutorials/kubernetes-basics/deploy-app/deploy-interactive.html is outdated.
Comments
/language ja
/good-first-issue
File to update
https://github.com/kubernetes/website/blob/dev-1.18-ja.1/content/ja/docs/tutorials/kubernetes-basics/deploy-app/deploy-interactive.html
Original
https://github.com/kubernetes/website/blob/fb6364d/content/en/docs/tutorials/kubernetes-basics/deploy-app/deploy-interactive.html
diff between translated and v1.18
https://gist.github.com/92eb46c52ea6b98270a591c9a6e8629f
Note
Currently, we use dev-1.18-ja.1 branch. Please open a PR targeting the branch.
ref
https://kubernetes.io/ja/docs/contribute/localization/
If you have a question, feel free to ask us at slack.k8s.io #kubernetes-docs-ja channel.

/assign


docs broken

Description
docs broken
https://reactnative.dev/docs/getting-started

Hello @dgamma3, I cannot reproduce the problem on my side.
Try to disable your browsers extensions or visit the page in incognito mode, if example will be visible after performing the mentioned steps, it means that one of your extensions is blocking the content.

ahh, it was the companies vpn!
thanks so much


add rule 50 regex reference check

implement most of the supplied regexes in unit tests

Also the tests are failing


Linked compile error

Thanks for great job!
I downloaded latest version and try to compiled with newest Xcode (6.1). But i alway got an error about bridging header: 'XMPP.h' file not found. Could you please show me how to fix this?
Thanks,

@thanhvyit  did you found the solution

@RishiAgar unfortunately not yet. I switched to use xamarine SignalR instead.


Enhancement request

Please add a function/setting to set the initial/starting value of the count. I am starting at 4184

You might change this line https://github.com/upgradeQ/Obscounter/blob/0b22fe1c3bb1081488545c075535d96e227463d8/hotkey_counter.py#L8
to your liking. Current version deserves a major refactor to make next changes easier to add, so for now to start from number you must change code.


Add more frames for ISO paper sizes

A0 and A1 paper sizes exceed default screen size

Thanks! :smiley:
FYI, I added a commit to bump the version of the modified component.


unclear how workspaces really work

This documentation is lacking in really helping users understand how workspaces work. Our pipeline doesn't seem to re-use workspaces, and so we get to a point where machines are running out of space. If the clean property on the workspace only cleans a workspace before it's used, then it won't help when old workspaces are left around. Overall, there is clearly a lot more to how workspaces work that needs to be documented so that your customers can be productive and not constantly run into issues.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 67504b34-d64b-02a4-2e10-ab99f3b8cfe4
Version Independent ID: 2cf63b2e-184b-7726-3b8a-d8baffd6fcce
Content: Jobs in Azure Pipelines and TFS - Azure Pipelines
Content Source: docs/pipelines/process/phases.md
Product: devops
Technology: devops-cicd
GitHub Login: @juliakm
Microsoft Alias: jukullam

I totally agree, there does not appear to be a way to "clean" a workspace "after" a job is run. This seems so obvious and I do not understand why it is not included. My locally hosted agent's disk drive is constantly filling up because of job's left over residuals. I have to go in and manually clear things out every few weeks. A real pain.

@stevenbrix You can use a maintenance job at the organization settings level to clean up your working directories. To set this up, go to Organization Settings > ** Pipelines** > Agent pools > ** Your Agent** > Settings and enable the agent maintenance job. We will work on making this clearer in the docs.

The docs have been updated: What is a maintenance job


Prevent Timing Attacks

I'm currently reading Programming Phoenix and right there the authentication method is defined like this:
def login_by_username_and_pass(conn, username, given_pass, opts) do
  repo = Keyword.fetch!(opts, :repo)
  user = repo.get_by(Rumbl.User, username: username)

  cond do
    user && checkpw(given_pass, user.password_hash) ->
      {:ok, login(conn, user)}
    user ->
      {:error, :unauthorized, conn}
    true ->
      dummy_checkpw()
      {:error, :not_found, conn}
  end
end

Quite similar to doorman's, but it also uses Comeonin's dummy_checkpw function to prevent timing attacks. It would be great if you could add this as well :)

Good call! I'll look into implementing this.

Thanks for reporting this, fixed in #13.


world-blacklist in jobConfig no Effect on TNTBreak

*Description of issue:
To reproduce:
Add a world to world-blacklist of the Miner Job.  You become Money.
Server Type (Spigot/Paperspigot/etc):
Spigot
Server Version (using /ver):
1.15.2

https://github.com/Zrips/Jobs/commit/e7f7c7deb0b37c674456522017d17dab41859ff6


Fixed the broken link in overview.md file

Fixed the broken link for Object detection model in overview.md file

Hi @tilakrayal Can you please check @fergushenderson's comments ? Thank you!

Hi @tilakrayal Any update on this PR? Please. Thank you!

Hi @tilakrayal Any update on this PR? Please. Thank you!

Hi @tilakrayal Any update on this PR? Please. Thank you!


Max Redis client connection issue

I have updated the max client connection to 90000 in the redis conf file and the ulimit is also set to 100000.
Previously the client connection count was set to 30000 so we used to get MaxClientConnection reached error.
Is there a way to identify if the client connection is closed in Flask and how to remove the idle connections?
Whenever the EventSource object is initiated it increments the client connection count.

Hobe this link help you


auto-fixing invalid whitespace sizes

Rule ~Suggestion~ Update to 'indent'
Is your rule for a general problem or is it specific to your development style?
This is something found in ESLint
What does your suggested rule do?
It will auto-fix invalid whitespace sizes
List several examples where your rule could be used
Similar to how prettier and eslint can be used to enforce an indent styling this will auto-fix whitespace counts
Additional context
Is a missing feature to the current rule indent

@Ethan-Arrowood the indent rule already has auto-fixing when provided a desired indentation size. Is there some more fixing you'd like to see be able to happen?
Unrelated: changing the issue title to not seem to refer to the whitespace rule. 😉

Closing this issue for housekeeping, especially since TSLint core has been moving away from whitespace/formatting concerns (e.g. #2327) - but please do post again if there's more you need here!
Our general recommendation now is to use Prettier. TSLint itself isn't great at auto-fixing formatting.


Ship graphviz?

We should consider shipping graphviz instead of requiring it to be installed. Maybe we can add it to Yggdrasil?

I've started work on this, here:
https://github.com/JuliaPackaging/Yggdrasil/pull/351

@Keno, are GraphVis.jl or GraphVis_jll appropriate here?

There is Graphviz_jll these days:
julia> Graphviz_jll.dot() do exe
         run(`$exe -V`)
       end
dot - graphviz version 2.50.0 (20211204.2007)
Process(`/Users/mhorn/.julia/artifacts/dbc1b7f42ddb07be07d55ad976317ad027618c63/bin/dot -V`, ProcessExited(0))

See PR #71


export button : top of grid ?

Hi, just a question I'd love to see the export button on top of list like it was before, column selection tool is actually very useful too and when at bottom requires scroll of page, not handy
anyone has tried that ?thanks

Hello can i open this @tabacitu , it works and the export is now on top, the problem about @breizhwave code snippet above is that the "records per page" drop down and "pagination numbers" coincide with the export button. How to put the export button 'only' to the top?

@rochiey to only move the export buttons on top (without records per page and pagination) you can do:
          dom:
            "<'row hidden'<'col-sm-6 hidden-xs'i><'col-sm-6 hidden-print'Bf>>" +
            "<'row'<'col-sm-12'tr>>" +
            "<'row mt-2 '<'col-sm-6 col-md-4'l><'col-sm-2 col-md-4 text-center'><'col-sm-6 col-md-4 hidden-print'p>>",

And then below, add this line to move the export buttons right after the search bar:
  @include('crud::inc.export_buttons')

  <script type="text/javascript">
    jQuery(document).ready(function($) {

      crud.table = $("#crudTable").DataTable(crud.dataTableConfiguration);

      // move search bar
      $("#crudTable_filter").appendTo($('#datatable_search_stack' ));
      $("#crudTable_filter input").removeClass('form-control-sm');
+      $("#crudTable_wrapper .dt-buttons.btn-group").appendTo('#datatable_search_stack');

      // move "showing x out of y" info to header
      $("#datatable_info_stack").html($('#crudTable_info'));

      // move the bottom buttons before pagination
      $("#bottom_buttons").insertBefore($('#crudTable_wrapper .row:last-child' ));

It should end up looking something like this:

Hi, I am trying do to the same, I couldn't make it work on BP 4.
dom:
    "<'row hidden'<'col-sm-6 hidden-xs'i><'col-sm-6 hidden-print'Bf>>" +
    "<'row'<'col-sm-12'tr>>" +
    "<'row mt-2 '<'col-sm-6 col-md-4'l><'col-sm-2 col-md-4 text-center'><'col-sm-6 col-md-4 hidden-print'p>>",

Is this part need to be changed ?

I encounter that need on one project.
And in BP 4.1 If you put the buttons (Export + columns), the dropdown direction is up, and you get weird behaviour.
You have to edit inc.export_buttons.blade.php, and put dropdown: true instead of dropup: true. to get the dropdown behaviour ok.
And that change, make the bottom buttons not working either. It's only one of the positions for quick change.
I've decided to remove the bottom buttons, because I didn't find a quick way to create 2 sets of buttons in the datatable plugin.
B = the buttons plugin within the markup.
//from @breizhwave and @tabacitu
dom:
"<'row hidden'<'col-sm-6 hidden-xs'i><'col-sm-6 hidden-print'f>>" +
"<'row m-t-10'<'col-sm-6 col-md-4'l><'col-sm-2 col-md-4 text-center'B><'col-sm-6 col-md-4 hidden-print'p>>"+
"<'row'<'col-sm-12'tr>>" +
"<'row m-t-10'<'col-sm-6 col-md-4'l><'col-sm-2 col-md-4 text-center'><'col-sm-6 col-md-4 hidden-print'p>>",


Use CORS proxy. Closes #148.

To avoid access-control-allow-origin header restrictions when requesting remote resources, use proxy like this http://crossorigin.me/http://some.resource/url.csv

As I noted in #148 just now, I don't think I want to introduce hacks around servers that do not allow cross origin requests.
The problem is that the server does not let us work with its data, and this is not, IMHO, an issue that DataPackagist should solve.
Perhaps an error that says "hey, that server will not let us use its data" would be more appropriate.
@gvidon what do you think?

@pwalsh you are right about hacks, I agree. But this way we will sacrifice UX. Because no one want to know anything about http headers and those guys who intentionally or unintentionally sets them up, users want to upload file — fast and with no issues. So, you need to decide what is important.

Hi,
It looks like http://datapackagist.herokuapp.com/cors-proxy isn't adding the access-control-allow-origin header?: Example:
http://datapackagist.herokuapp.com/cors-proxy/https://rawgit.com/richhall/4f2b94ae058317f6ac39/raw/7fbbd5965410898e0562103c1481e72a1b52765f/opendata_cambridgeshireinsight_org_uk_example.json

@richhall I'm not really sure if it should add access-control-allow-origin: * header to the response. There is no need in it as client CSV and client app files are loaded from the same domain.

Definitely: it is a proxy for use by this app only.

good point! - I think what I meant to ask was does the config needs to specify http://datapackagist.okfnlabs.org/corsproxy instead of http://datapackagist.herokuapp.com/cors-proxy -otherwise it appears as a cross origin request?

@richhall ah, I see :).

@richhall yes, in current implementation you need to manually define app host name in config.


shouldNotThrow and shouldNotThrowAny matchers

Having these matchers would be great
-shouldNotThrow
-shouldNotThrowAny
Currently there is not way of expressing that easily with kotlintest matchers

Good idea! However shouldNotThrowAny should not be needed, since that is the default case implicitly assumed in all test cases. Or what would be the use case for this matcher?

2 reasons that I can think of now:

I think tests are more readable if you explicitly write shouldNotThrowAny
assertion error can more precisely tell you why your test failed: "you expected no exception, but we found: SomethingException"

assertion error can more precisely tell you why your test failed: "you expected no exception, but we found: SomethingException"

Isn't this just an extremely verbose way of writing "Unexpected exception: SomethingException" and why can't we do this for every exception.

We already log when an exception happens and it shouldn't,
java.lang.RuntimeException: boo
So that's that covered. I agree with @helmbold I don't see a valid use case for this because every method should not throw an exception unless otherwise specified.

I think shouldNotThrow is a good idea, because it makes the code more explicit. Testing libraries like Shouldly support these assertions.

@TAGC Would you mind creating an issue for that? I agree with you that syntax would be prettier and human-readable.
Althought technically, if your code doesn't throw any exception, you're already asserting that it doesn't throw anything

@sksamuel
Sometimes users want to write things in a more explicitly.
It's the same reason we added the matchers
shouldNotBeTrue and shouldNotBeFalse https://github.com/kotlintest/kotlintest/issues/452
Of course (3 ==3).shouldBeTrue is exactly the same as (3==3).shouldNotBeFalse, but sometimes one might want to say in a way or another.
Adding a shouldNotThrow empty block doesn't look like a problem to me, and it won't make users more confused

@TAGC Would you mind creating an issue for that? I agree with you that syntax would be prettier and human-readable.

Not sure what you mean. Why create a new issue for the same proposal as this one?

What's the difference except more noise ?

In short test-cases, it probably does create more noise than it's worth. For example, it my case instead of:
it("can be connected to other ports of a supertype") {
    val derivedPort = createDummy<Derived>()
    val basePort = createDummy<Base>()
    derivedPort join basePort
}

I might write:
it("can be connected to other ports of a supertype") {
    val derivedPort = createDummy<Derived>()
    val basePort = createDummy<Base>()
    shouldNotThrow { derivedPort join basePort }
}

And it wouldn't make much difference.
However, in longer test-cases the advantage is that it helps distinguish the assertion from the rest of the setup/cleanup code.
it("verifies something") {
    val x = Foo()
    x.bar()
    x.baz()
    // More setup for x

    val y = Foo2()
    y.bar(x)
    y.baz(x)
    // More setup for y

    y.baz(z)

    cleanup(x)
    cleanup(y)
    // More cleanup
}

vs.
it("verifies something") {
    val x = Foo()
    x.bar()
    x.baz()
    // More setup for x

    val y = Foo2()
    y.bar(x)
    y.baz(x)
    // More setup for y

    shouldNotThrow { y.baz(z) }

    cleanup(x)
    cleanup(y)
    // More cleanup
}

Without this assertion, I might be inclined to write y.baz(z) // should not throw, but that's not as good for the reason why comments in general are not preferable to readable code: because comments can become stale, they can lie, but code never lies.
Furthermore, if you just write the assertion as a plain statement and it fails, all you get is a regular stacktrace associated with the unit test, indistinguishable in structure from the stacktraces you'd get if any other part of the test (setup/cleanup) failed. A shouldNotThrow can instead capture exceptions and rethrow them with a message like "Expected no exception to be thrown, but <wrapped exception> was thrown".
In the same way that the shouldNotThrow statement helps visually distinguish the assertion code from the rest of test code (making the test more readable), the exception it throws can help distinguish an assertion failure from any other failure within the code (making the problem easier to understand and the bug easier to fix).
It's an especially nice assertion to have when you have some function that should throw exceptions under certain circumstances and shouldn't throw in others, and you want test both types of scenarios. That leads to nice symmetrical code:
public void Message_Decoder_Should_Decode_Additional_Messages_After_Decoding_Complete_And_After_Reset()
{
    // GIVEN a mock decoder that is able to decode messages and has completed decoding.
    var mockDecoder = new MockMessageDecoder
    {
        DecodingMessagesAllowed = true
    };
    mockDecoder.SetDecodingComplete();

    // WHEN we reset the mock decoder.
    mockDecoder.Reset();

    // THEN we should be able to decode more messages.
    Should.NotThrow(() => mockDecoder.DecodeMessage(default(GenericMessage)));
}

[Fact]
public void Message_Decoder_Should_Decode_No_Additional_Messages_After_Decoding_Complete_And_Before_Reset()
{
    // GIVEN a mock decoder that can decode messages.
    var mockDecoder = new MockMessageDecoder
    {
        DecodingMessagesAllowed = true
    };

    // WHEN decoding is complete.
    mockDecoder.SetDecodingComplete();

    // THEN an exception should be thrown when trying to decode another message.
    Should.Throw<InvalidOperationException>(() => mockDecoder.DecodeMessage(default(GenericMessage)));
}


Doesn't work with SBCL 2.4.5

I followed the directions to install and it fails on the (ql:quickload "alive-lsp") step:
This is SBCL 2.4.5, an implementation of ANSI Common Lisp.
More information about SBCL is available at <http://www.sbcl.org/>.

SBCL is free software, provided as is, with absolutely no warranty.
It is mostly in the public domain; some portions are provided under
BSD-style licenses.  See the CREDITS and COPYING files in the
distribution for more information.
* (ql:quickload "alive-lsp")
To load "alive-lsp":
  Load 1 ASDF system:
    alive-lsp
; Loading "alive-lsp"
..................................................
[package alive/sbcl/file];
; caught ERROR:
;   READ error during COMPILE-FILE:
;
;     Lock on package SB-EXT violated when interning SIMPLE-STYLE-WARNING while in
;     package ALIVE/SBCL/FILE.
;   See also:
;     The SBCL Manual, Node "Package Locks"
;
;     (in form starting at line: 81, column: 0, position: 2535)

debugger invoked on a UIOP/LISP-BUILD:COMPILE-FILE-ERROR in thread
#<THREAD tid=259 "main thread" RUNNING {7008380473}>:
  COMPILE-FILE-ERROR while
  compiling #<CL-SOURCE-FILE "alive-lsp" "src" "compat/sbcl/file">

Type HELP for debugger help, or (SB-EXT:EXIT) to exit from SBCL.

restarts (invokable by number or by possibly-abbreviated name):
  0: [RETRY                        ] Retry
                                     compiling #<CL-SOURCE-FILE "alive-lsp" "src" "compat/sbcl/file">.
  1: [ACCEPT                       ] Continue, treating
                                     compiling #<CL-SOURCE-FILE "alive-lsp" "src" "compat/sbcl/file">
                                     as having been successful.
  2:                                 Retry ASDF operation.
  3: [CLEAR-CONFIGURATION-AND-RETRY] Retry ASDF operation after resetting the
                                     configuration.
  4:                                 Retry ASDF operation.
  5:                                 Retry ASDF operation after resetting the
                                     configuration.
  6: [ABORT                        ] Give up on "alive-lsp"
  7: [REGISTER-LOCAL-PROJECTS      ] Register local projects and try again.
  8:                                 Exit debugger, returning to top level.

(UIOP/LISP-BUILD:CHECK-LISP-COMPILE-RESULTS NIL T T "~/asdf-action::format-action/" ((#<ASDF/LISP-ACTION:COMPILE-OP > . #<ASDF/LISP-ACTION:CL-SOURCE-FILE "alive-lsp" "src" "compat/sbcl/file">)))
; File has been modified since compilation:
;   SYS:CONTRIB;ASDF;UIOP.LISP.NEWEST
; Using form offset instead of character position.

   source: (ERROR 'COMPILE-FILE-ERROR :CONTEXT-FORMAT CONTEXT-FORMAT
                  :CONTEXT-ARGUMENTS CONTEXT-ARGUMENTS)
0]

I downgraded to sbcl 2.3.11 and it works exactly as described.
OS: Mac OS Sonoma 14.3.1
Hardware: Apple M2 Max

For those who find this via google, to downgrade I followed the steps here to find the 2.3.11 brewfile and the installed that.
In short:
brew uninstall sbcl
curl 'https://raw.githubusercontent.com/Porkepix/homebrew-core/557895d604188a6923f556294f7ff9546ae3ec73/Formula/s/sbcl.rb' > /tmp/sbcl.rb
brew install /tmp/sbcl.rb
brew pin /tmp/sbcl.rb

Apparently simple-style-warning got removed or something. I went ahead and took it out because I can't remember why I checked for it other than because the Swank code includes it. With that change, 2.4.5 starts fine on my Linux machine.

Yup, it's working now, thanks!


JS Component Model Support for Observe SDK / Observe API

#142 , but for the JS SDK
maybe use jco

Closing as we removed component support for now in https://github.com/dylibso/observe-sdk/commit/a756566c17ea07caef9dbec7be8a74e3243f72de


Stryker.Js never find tests for mutation

Question
I'm trying to configure stryker in our project, its really big, I'd like to configure it for react components and for native Js functions, for now, I'm trying to configure it for react, in react we use jest for test, I've set my stryker.conf.json with this structure:
{
  "ignorePatterns": [
    'manyDirsFromProject'
  ],
  "mutate": [
    "all/path/untill/get/original/component/file.js",
  ],
  "testRunner": "jest",
  "reporters": [
    "html"
  ],
  "coverageAnalysis": "perTest",
  "jest": {
    "projectType": "custom",
    "enableFindRelatedTests": true,
    "configFile": "jest.config.js",
    "config": {
      "testMatch": ["<rootDir>/all/path/untill/get/original/component/file/**/*.test.js"],
      "testEnvironment": "jest-environment-jsdom-sixteen"
    }
  },
  "cleanTempDir": true,
  "eventReporter": {
    "baseDir": "stryker"
  },
  "htmlReporter": {
    "fileName": "stryker/mutation.html"
  },
  "packageManager": "yarn",
  "tempDirName": "stryker-tmp",
  "ignoreStatic": true,
  "incremental": true,
  "incrementalFile": "stryker-tmp/incremental.json",
  "allowEmpty_comment": true
}

I turn allowEmpty to comment cause by running with it enabled I got this error: (28) WARN OptionsValidator Unknown stryker config option "allowEmpty" (Its not the big problem just told bout it).
And matter what I did every time I run the comand stryke run this returns: (28) ERROR Stryker No tests were executed. Stryker will exit prematurely. Please check your configuration.
I already done it trying to get log trace but everything seems fine, but it cannot find tests (tests for components are always in the same dir/tests/component.test.js)
our jest.config.js is like this:
module.exports = {
  testEnvironment: 'jest-environment-jsdom',
  testMatch: [
    '<rootDir>/all/path/**/*.test.js'
  ],
  modulePaths: ['<rootDir>/all/path/'],
  modulePathIgnorePatterns: [
  '...'
  ],
  moduleNameMapper: {
   'allModules'
  },
  coverageDirectory: '<rootDir>/react-coverage',
  coverageReporters: [['lcov', { file: 'lcov-react.info' }]],
  setupFiles: ['<rootDir>/setup-jsdom-test.js', 'raf/polyfill'],
  setupFilesAfterEnv: ['<rootDir>/setup.react.js'],
  testEnvironmentOptions: {
    url: 'http://localhost'
  },
  transformIgnorePatterns: ['node_modules/?!(garden)'],
  snapshotSerializers: ['@emotion/jest/serializer']
}

When I ran tests for components all of them run and works fine, but Stryker cannot find them.
Does anyone know what do I could do to make Stryke get and run related tests?
Stryker environment

 "@stryker-mutator/core": "^6.4.2",
 "@stryker-mutator/jest-runner": "^6.4.2",

Additional context
I'm running it on docker with yarn 1.22.19

Hi @AndreLZGava, thanks for opening this issue and the detailed description ♥
What happens if you set jest.enableFindRelatedTests to false? Maybe something in your setup prevents jest --findRelatedTests from working.
I've also noticed that you're overriding the "testEnvironment" with "jest-environment-jsdom-sixteen", but you're running with "jest-environment-jsdom" normally. You should be able to simply remove "testEnvironment" from your stryker.conf.json file, it is not needed.

Hi @nicojs
thanks for your reply, I put this 2 options in the last tryes I did, but I decided to remove testEnvironment as you said and turn jest.enableFindRelatedTests to false, I ran the command and I got the same result
(28) ERROR Stryker No tests were executed. Stryker will exit prematurely. Please check your configuration.
error Command failed with exit code 1.

Do you have any other idea that I could try?

Hmm interesting. What does your normal jest command look like for running your tests? Is it simply jest?

Actually I ran it from docker but I can enter into container as shell and run from there, my command to run test is:
yarn jest --config=jest.config.js path/to/file/component.test.js

Yesterday I got some new progress, by changing jest.config.testMatch to :
["./**/*.test.js"]

With this, stryker find tests to run, but if a put something like "./**/myComponent.test.js" no files are found, but file exists (If I could restrict test it would run faster to get mutators, cause we could modify some components and then pass their tests to mutate instead running all tests of project).
With this new configuration *.test.js It seems to try running test but crashes, saint about ECMA modules (some files uses import without beeing modules), then searching I found saying to use babel to transpile code,
Then created .babelrc
{
    "presets": [
        ["@babel/preset-env", { "modules": "auto" }]
    ],
    "plugins": [
        "@babel/plugin-syntax-jsx",
        [
            "@babel/plugin-proposal-private-property-in-object",
            {
                "loose": true
            }
        ]
    ]
}

add transform option to my jest.config.js
transform: {
    '^.+\\.js?$': 'babel-jest'
  },

Installed new packages:
"stryker-babel-transpiler": "^0.10.1",
"stryker-javascript-mutator": "^0.14.1",
Apparently its is transpiling, but now when I run stryker run I got this error

Details:

/var/www/html/stryker-tmp/sandbox5175145/path/to/file/component.js:76
  return <_react2.ThemeProvider theme={theme}>{children}</_react2.ThemeProvider>;

SyntaxError: Unexpected token '<'
    at new Script (node:vm:100:7)
    at Runtime.createScriptFromCode (/var/www/html/node_modules/jest-runtime/build/index.js:1495:14)
    at Runtime._execModule (/var/www/html/node_modules/jest-runtime/build/index.js:1389:25)
    at Runtime._loadModule (/var/www/html/node_modules/jest-runtime/build/index.js:1013:12)
    at Runtime.requireModule (/var/www/html/node_modules/jest-runtime/build/index.js:873:12)
    at Runtime.requireModuleOrMock (/var/www/html/node_modules/jest-runtime/build/index.js:1039:21)
    at Object.require (/var/www/html/stryker-tmp/sandbox5175145/setup.react.js:4:1)
    at Runtime._execModule (/var/www/html/node_modules/jest-runtime/build/index.js:1429:24)
    at Runtime._loadModule (/var/www/html/node_modules/jest-runtime/build/index.js:1013:12)
    at Runtime.requireModule (/var/www/html/node_modules/jest-runtime/build/index.js:873:12)
    at jestAdapter (/var/www/html/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:65:15)
    at runTestInternal (/var/www/html/node_modules/jest-runner/build/runTest.js:281:16)
    at runTest (/var/www/html/node_modules/jest-runner/build/runTest.js:341:7)

Aparently this occurs when transpile the code, jest cannot run it, Am I in the rigth way?
Or shoul we try to refactor files to be modules instead using babel?
I got this in the end of day , so didnt advance so much, so I'll continue trying today

Installed new packages:
"stryker-babel-transpiler": "^0.10.1", "stryker-javascript-mutator": "^0.14.1",

Those packages are old and no longer used since... Stryker 3, back in 2020. Where did you find out about them?

Apparently its is transpiling, but now when I run stryker run I got this error

Details:

/var/www/html/stryker-tmp/sandbox5175145/path/to/file/component.js:76
  return <_react2.ThemeProvider theme={theme}>{children}</_react2.ThemeProvider>;

This is strange. Stryker should not transpile your code, just add mutant instrumentation. Do you think _react2.ThemeProvider was added by Stryker? We're using babel under the hood, so maybe it got transpiled without us noticing? This would be the first time we're seeing anything like this.

Then I decided to go back into babel and now its like this:

That is for the best. You really shouldn't be changing your testing approach with jest. It should simply work.
Maybe a final think you can try is to run Stryker with --inPlace. Maybe the simple fact of running Jest in the sub-directory causes the issue.
Is your project open source? If not, could you provide a small reproduction repository? Either as a .zip file or as a link to a github repo is fine.


refactor: remove hard dependency on @scaleleap/amazon-marketplaces

Task linked: GHORG-31 Remove hard dependency on @scaleleap/amazon-marketplaces


Adds support for directly querying cloudwatch metrics via the AWS SDK

Description

Replaces PR  #2262 .
Internal version of this functionality had diverged sufficiently from original PR that it is cleaner to start afresh
Requires a role with the ListMetrics and GetMetricData capabilities.
Role can be supplied using either the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment variables or by attaching it to the EC2 instance on which bosun runs.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How has this been tested?

[x] CloudWatch query functionality had good unit test coverage
[x] Has been used in production in Skyscanner for several years

Checklist:

[x] This contribution follows the project's code of conduct
[x] This contribution follows the project's contributing guidelines
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@neilfordyce Now includes the parseDimensions fix

Looking good.  Nice work on the wildcard dimensions, they make cloudwatch much easier to work with.


Adapting partial code(file name start with F) to the sonar cloud rule

Codecov Report

Merging #2045 into dev will decrease coverage by <.01%.
The diff coverage is 14.28%.

@@             Coverage Diff              @@
##                dev    #2045      +/-   ##
============================================
- Coverage     33.17%   33.17%   -0.01%
- Complexity     1553     1554       +1
============================================
  Files           313      313
  Lines         15528    15525       -3
  Branches       1886     1884       -2
============================================
- Hits           5152     5150       -2
- Misses         9848     9849       +1
+ Partials        528      526       -2

Impacted Files
Coverage Δ
Complexity Δ

...apache/dolphinscheduler/alert/utils/FuncUtils.java
91.66% <ø> (ø)
5 <0> (ø)
:arrow_down:

...duler/server/worker/runner/TaskScheduleThread.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../dolphinscheduler/server/utils/FlinkArgsUtils.java
88.46% <0%> (-0.22%)
10 <0> (-1)

...inscheduler/common/task/flink/FlinkParameters.java
2.17% <0%> (ø)
1 <0> (ø)
:arrow_down:

...pache/dolphinscheduler/common/utils/FileUtils.java
21.11% <50%> (+2.42%)
9 <0> (+2)
:arrow_up:

...scheduler/alert/template/AlertTemplateFactory.java
42.85% <0%> (-14.29%)
2% <0%> (ø)

...he/dolphinscheduler/common/thread/ThreadUtils.java
71.18% <0%> (-6.78%)
12% <0%> (-1%)

...he/dolphinscheduler/api/service/LoggerService.java
100% <0%> (+8.69%)
8% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df7c67...b9d8973. Read the comment docs.

need more unit test.

done

need more unit test.

done

unit test failed

done


Block Project-wide SSH keys

Project-wide SSH keys are stored in Compute/Project-meta-data. Project wide SSH keys can be used to login into all instances within a project. Using project-wide SSH keys eases SSH key management. If SSH keys are compromised, the potential security risk can impact all instances within a project.
We currently allow project-wide SSH keys (by surpressing the checkov rule) in the instance template. Preferably this should be made configurable through a variable.

Fixed in #5

See https://github.com/bschaatsbergen/atlantis-on-gcp-vm/pull/5/commits/02866571550d281e4598829666975a2c7f195d4b


Move Test#homebrew logic to GitHub Actions.

This will improve the output and ease of parsing while allowing code to be removed from brew-test-bot which relates only to a single repo.
Homebrew/brew companion PR: https://github.com/Homebrew/brew/pull/6760.

Nice cleanup. I always found it weird to have this code in brew-test-bot.