Trails of Cold Steel crash on startup

Game works on previous version (1.10.3), but crashes on a white screen after a while on startup using dxvk 2.0. (Windows 10)
If you use Windows, please check the following page: https://github.com/doitsujin/dxvk/wiki/Windows
Software information
Trails of Cold Steel 1
System information

GPU: Ice Lake GT1
Driver: <IP_ADDRESS>5
DXVK version: 2.0 & 1.10.3

Log files

d3d11.log:ed8_d3d11.log
dxgi.log:ed8_dxgi.log

Hello.
If possible try to get a apitrace of the game. https://github.com/doitsujin/dxvk/wiki/Using-Apitrace
Just use those dll's instead of dxvk and then get past on startup where it usually crashes.

I tested this game not too long ago with 2.0 on RADV, works fine.

Sorry for the late reply, here's an apitrace
https://drive.google.com/file/d/1squst-IMAhNmhbtHircgZVQ-NlmR9-QM/view?usp=sharing

Yeah, no obvious bug on our end. You might want to file a bug with Intel's Windows driver since that's where the problem is.

Okay thank you


Better support source builds under API mode

The install experience for -s, older macOS and non-default prefixes is very poor.
Currently, after switching to API mode by default, the state of the tap is "frozen", never updated but still used for all source installs.
This PR implements source file fetching from raw.githubusercontent.com. Now everything should work significantly more seemlessly. I've managed to remove HOMEBREW_NO_INSTALL_FROM_API messaging as a result.
One improvement worth doing as an iteration of this is SHA256 validation of the formula file dowload. We'll need to add a field to the JSON API first to do this.

Review period will end on 2023-02-07 at 13:21:43 UTC.

older macOS and non-default prefixes is very poor.

We disable it entirely there, FWIW.
--
That aside, this is similar to what we do for casks and seems like a major improvement. Thanks @Bo98!

We disable it entirely there, FWIW.

Ah that's what I get for only reading PR titles and thinking it was "everyone". 😅

Let's ship this for 4.0.0. Great work @Bo98!

Review period skipped due to critical label.


✨ Fix e2e

Description
Fixes e2e! go.mod needs to be updated to after https://github.com/operator-framework/rukpak/pull/884 gets merged.

Reviewer Checklist

[ ] API Go Documentation
[ ] Tests: Unit Tests (and E2E Tests, if appropriate)
[ ] Comprehensive Commit Messages
[ ] Links to related GitHub Issue(s)

Is this supposed to fix the e2e? It's still failing.
Also, the lint issues are new to this PR.

e2e is passing!


Throw error instead of warning for profiles

For most cases, we will throw error and stop executing scriptanalyzer. If the user uses an unknown key, we will just issue warning instead.

Thanks for the PR, Quoc. For the Warnings - add information about the supported set of keys, so that the user gets an idea of the supported set.

Why use a warning? If the user intended a config/profile value and it failed, they're likely to get the wrong output. I think generating output is confusing, which is why I recommended a terminating error. If that doesn't work, I would, at least, generate a non-terminating error.

We want the Engine to be flexible and continue execution as long as it received the correct set of keys. For non-existent/invalid keys, our thinking was to inform the user as a warning since it is simply an anomaly in the input.
I do agree that we have to be consistent in handling all invalid user input across ScriptAnalyzer (ScriptPaths, CustomRulePaths, Profiles, Rule filters etc)
So in this case, we can do #1
(emit non-terminating errors for each issue in Profile and stop the Engine execution - This will prevent any rules from running)

LGTM. Pls Merge

Thanks!


fix: add missing comma to sim_test macro

Description
This adds a missing comma to the sim_test procedural macro. Without this, the arguments to the sim_test attribute are parsed correctly but propagated without commas, causing an error "error: expected ,".
Test plan
All the existing simtests should continue to work.

I believe the simtest failure is not related to this change.


Notification Webjob

Addresses #26

@pschaeflein,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

You can review the draft of my blog post here: https://www.schaeflein.net/p/176407c3-ba9a-4372-aef4-0ec6e59c4807/

Thx Paul, we'll get this processed soon.

ty paul. Sorry for the delay with getting this processed. Great add!


Queue sometimes doesn't use free workers

Laravel Version
9.19
PHP Version
8.1.21
Database Driver & Version
Redis
Description
I have 5 workers for the job. There is just 1 POST request inside. Additionally, I have 1 cron job that retrieves the queue pending count every 2 seconds and logs it if the count is higher than 10. After some days, I noticed a large queue line. I initially thought it was due to high usage, and the 5 workers couldn't process all of them. However, when I checked the logs, I observed a different scenario. The worker is free, but it doesn't get any job from queue:
This is the result of queue:size() every 2 seconds:
Queue size.txt
And there is Queue log of one worker:
Worker log.txt
For example in   2024-03-11 05:00:15 to 2024-03-11 05:00:20 there is zero jobs ran. Each job ran in max 105 ms. So why this free worker doesn't run any jobs in this period of 5 seconds?
Steps To Reproduce
It happens 1-2 times in 3-4 days. Generally it works normally. So i can't provide reproduce instruction (

Hey there,
Unfortunately we don't support this version anymore. Please check out our support policy on which versions we are currently supporting. Can you please try to upgrade to the latest version and see if your problem persists? If so, please open up a new issue and we'll help you out.
Thanks!


Incorrect v1.6exp1 error

Describe the bug
When adding the latest 1.6.240531000-experimental1 nuget package, I'm met with the following error:
1>C:\Users\mn\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.WindowsAppSDK.targets(84,9): error : This version of the Windows App SDK requires Microsoft.Windows.SDK.NET.Ref 10.0.19041.35-preview;10.0.19041.35-preview or later, which can be added with:
1>C:\Users\mn\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.WindowsAppSDK.targets(84,9): error :         <PropertyGroup>
1>C:\Users\mn\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.WindowsAppSDK.targets(84,9): error :             <WindowsSdkPackageVersion>10.0.19041.35-preview;10.0.19041.35-preview</WindowsSdkPackageVersion>
1>C:\Users\mn\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.WindowsAppSDK.targets(84,9): error :         </PropertyGroup>
1>C:\Users\mn\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.WindowsAppSDK.targets(84,9): error :

Adding this to the project will result in a build-error. The string
10.0.19041.35-preview;10.0.19041.35-preview
should be changed to
10.0.19041.35-preview
Steps to reproduce the bug

Create a new WinUI project.
Update the nuget package to latest WindowsAppSDK 1.6.240531000-experimental1

Expected behavior
Don't repeat the version number inside the WindowsSdkPackageVersion tag twice
1>C:\Users\mn\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.WindowsAppSDK.targets(84,9): error : This version of the Windows App SDK requires Microsoft.Windows.SDK.NET.Ref 10.0.19041.35-preview;10.0.19041.35-preview or later, which can be added with:
1>C:\Users\mn\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.WindowsAppSDK.targets(84,9): error :         <PropertyGroup>
1>C:\Users\mn\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.WindowsAppSDK.targets(84,9): error :             <WindowsSdkPackageVersion>10.0.19041.35-preview</WindowsSdkPackageVersion>
1>C:\Users\mn\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.WindowsAppSDK.targets(84,9): error :         </PropertyGroup>
1>C:\Users\mn\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.WindowsAppSDK.targets(84,9): error :

Screenshots

NuGet package version
Windows App SDK 1.6 Experimental 1: 1.6.240531000-experimental1
Packaging type
No response
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

Thanks @dotMorten - will be fixed in the Experimental 2 release.

The error message indicates that you need to add somewhere:
<PropertyGroup>
    <WindowsSdkPackageVersion>10.0.19041.35-preview;10.0.19041.35-preview</WindowsSdkPackageVersion>
</PropertyGroup>

and when you double-click the error message, it opens the file Microsoft.WindowsAppSDK.targets which is inside the cached NuGet packages.
If possible, it might be better if it opens the project file instead.

That's not quite how errors thrown by build .target files work though.
Visual studio opens build errors where they occur

Yeah. I figured. How about mentioning "project file" in the error message?
I think that it's confusing for devs new with .NET projects😅

Fixed in WinAppSDK 1.6 Preview 2

Had the same error with a new freshly made project in VS 2022. Fixed it by adding:
<WindowsSdkPackageVersion>10.0.26100.38</WindowsSdkPackageVersion>

after
    <TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
    <SupportedOSPlatformVersion>10.0.20348.0</SupportedOSPlatformVersion>
    <TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>

Well, I'm on version 1.6 and I'm still having the issue. Unless I've seriously misconfigured something.

@gabriel-vanca The generated error isn't the bug (it's actually quite helpful since it is required for now - see release notes). The message in the error was the issue and it is fixed.
The error before the fix was:
<WindowsSdkPackageVersion>10.0.19041.35-preview;10.0.19041.35-preview</WindowsSdkPackageVersion>
where the error was supposed to be:
<WindowsSdkPackageVersion>10.0.19041.35-preview</WindowsSdkPackageVersion>

Get it now. Thanks!

I create a new empty WinUI3 project and it doesn't compile. Isn't this an error, you say? :)

Yes, I agree a default template not compiling should be treated more seriously.

Tracking future improvement here via #4734.


Add consensus weight to NodeStake

Since we will be updating consensus weight of all nodes midnight UTC everyday, we need to expose the weight fields to mirror node using record stream

Stale.  Please reopen if still needed.


Do you need to file an issue?

[X] I have searched the existing issues and this bug is not already filed.
[X] My model is hosted on OpenAI or Azure. If not, please look at the "model providers" issue and don't file a new one here.
[X] I believe this is a legitimate bug, not just a question. If this is a question, please use the Discussions area.

Describe the bug
No response
Steps to reproduce
No response
Expected Behavior
No response
GraphRAG Config Used
# Paste your config here

Logs and screenshots
No response
Additional Information

GraphRAG Version:
Operating System:
Python Version:
Related Issues:

这个我没遇到 有具体的视频参考吗？你是怎么用graphrag的呢？拷贝webserver到官方graphrag？这样是会卡住的。

你要进微信群讨论吗？首页公众号 后台回复进群即可

pip uninstall graphrag
然后
python -m webserver.main
试试


Missing swagger documentation when deploy with a url prefix

Describe the bug
If we want to deploy PxWebApi under a url prefix instead of under a subdomin, we struggle to show the swagger documentation
To Reproduce
Se the difference on these two deployments

https://pxapi2.staging-bip-app.ssb.no/index.html (subdmain)
https://data.qa.ssb.no/pxapi2-beta/index.html (responds 404, pxapi2-beta is the prefix)

I will try this method https://code-maze.com/aspnetcore-add-global-route-prefix/


makeStyles broken after rc.0

The usage of:
import { makeStyles } from ’@mui/styles‘
makeStyles((theme: Theme) ->…
breaks after upgrading from rc.0 to rc.1 or 5.0.0
There was nothing in the changelog. Is this an error?

You probably forgot to wrap your APP with ThemeProvider. If not, please provide a codesandbox illustrating the issue.

Hint: see https://mui.com/guides/migration-v4/#themeprovider-setup and make sure you use the new package names.

I am wrapping my APP with the ThemeProvider. My project is running with 5.0.0-rc.0. It breaks after upgrading to 5.0.0.

I'm not familiar with codesandbox. So here a super easy example demonstrating the issue:
My App.tsx:
import { createTheme, ThemeProvider } from '@mui/material'
import Test from './Test'
function App() {
const theme = createTheme()
return (
<ThemeProvider theme={theme}>
<Test />
</ThemeProvider>
)
}
export default App
My test.tsx:
import { makeStyles } from '@mui/styles'
import { Theme } from '@mui/material'
const useStyles = makeStyles((theme: Theme) => ({
avatar: {
padding: theme.spacing(1),
color: theme.palette.background.default
}
}))
const Test = () => {
const classes = useStyles()
return (
<div>
)
}
export default Test
Error:
TypeError: theme.palette is undefined

@cnolte Create the theme outside of your React component.
Instead of yours:
function App() {
  const theme = createTheme()
  return (
    <ThemeProvider theme={theme}>
      <Test />
    </ThemeProvider>
  )
}

do:
const theme = createTheme()

function App()
  return (
    <ThemeProvider theme={theme}>
      <Test />
    </ThemeProvider>
  )
}

The theme outside the React component doesn't change anything. Because there are several issues according the theming I guess it's a bug.

It works as expected, here is the prove - https://codesandbox.io/s/xenodochial-bush-dmgg1?file=/src/Demo.tsx Check that you are using the correct versions.
If there is a different problem, please edit the codesandbox and report the issue.

I found a solution. I had to remove the package-lock.json, the node_modules folder and run "npm install".


Enabling Multi-GPU in SVD

Hello, thank you for providing this open source model!
I'm attempting to run the Stable Video Diffusion using the simple_video.py script. I'm running this with the following arguments.
--version svd --input_path data/robot_images --image_size 512
But I'm running into an out of memory error. I have two A100 GPU's available to me. Is there a way to enable multi-GPU? Thanks!
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 3.50 GiB (GPU 0; 31.74 GiB total capacity; 23.40 GiB already allocated; 1.92 GiB free; 29.42 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

enable two gpu is not easy, you can look  https://pytorch.org/tutorials/intermediate/ddp_tutorial.html


Level continue button not showing up/not working

Operating system: Mac OS X 10.10.5
Browsers: Chrome and Safari
When: Happens right after I successfully complete and submit a level.
Language: Python
Level: Multiple levels
New: Was working fine up until the level "Back to Back" but now affects others too
When completing a level, the button to continue either does not show up or does not do anything when clicked. If the level gives a new item the buttons show up but clicking them doesn't work. If the level does not give a new item the buttons do not show up at all. I have tried disabling all my Chrome extensions and restarting the browser and using an alternate browser (Safari).
Here are the examples where the buttons are missing/inactive

Here is the error code that shows up in the console when clicking the inactive button.

We have this bug fixed soon; are you still seeing it? If so, let me know your username so I can update your account.

I ended up creating an account using an email instead of the "sign in with
google + option" to see if that would change anything and it got rid of the
issue. However now on the homepage something happened and instead of saying
"continue playing" it says "go to my classes" which will take me to the
teacher dashboard instead of to the level map. Now in order to access the
level map I have to go to my account settings, go to a recently played
level and then leave that level to access the map.
Is there something setting I can change so the "continue playing" button
comes back and I don't have to go through the extra steps?
On Sat, Apr 16, 2016 at 8:33 PM, Nick Winter<EMAIL_ADDRESS>wrote:

We have this bug fixed soon; are you still seeing it? If so, let me know
your username so I can update your account.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/codecombat/codecombat/issues/3553#issuecomment-210930432

What are the two account usernames?

I had to delete the original as I only have one email and there was minimal
progress,  but the new one's username is soph222
On Sun, Apr 17, 2016 at 12:58 AM, Nick Winter<EMAIL_ADDRESS>wrote:

What are the two account usernames?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/codecombat/codecombat/issues/3553#issuecomment-210956711

We'll fix this soon, but for now just go to http://codecombat.com/play to get to the individual game screen.


Scroll to top doesn't work in Firefox 47.0

I don't know if it's related to the issue, but I get this warning in the console: "This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!"

Deployed.


typedoc.json inputFiles property not working as expected

Search terms
typedoc.json inputFiles
Expected Behavior
When I specified the inputFiles option in the typedoc.json file to have an array (or single) of directories such as ["./src/foo/lib", "./src/bar/lib"]. It pickup all the files in the ./src file. I expect it to only search for files in the two lib folders.
Actual Behavior

All files in the ./src folder are parsed and the generated doc contains files in other folder.
Steps to reproduce the bug
typedoc.json
{
"mode": "modules",
"out": "./docs",
"inputFiles": ["./src/foo/lib", "./src/bar/lib"]
}
Case #1: doesn't work
typedoc --options typedoc.json --tsconfig tsconfig.json
Case #2: work (with or without the inputFiles property in the typedoc.json file)
typedoc --options typedoc.json --tsconfig tsconfigjson "./src/foo/lib" "./src/bar/lib"
Environment

Typedoc version: 0.17.4
TypeScript version: 3.8.3
Node.js version: 12.16.1
OS: Windows10

Ah, good catch. Should be a really simple fix. The tsconfig reader should check if inputFiles is default before setting it.

There's a fix for this in #1265, but it bumps the required Node version from 8.0 to 9.0 so can't be merged until 0.18 is ready (#1241).


fix: issue where contract logic errors would not be discovered

What I did
Fixes issue where some contract revert messages were not discovered.
How I did it
Noticed that error message were strings instead of dicts sometimes for gas estimation RPC.
This happened in the buyer contract here : https://github.com/banteg/yfi-buyer
That bug made it so gas_limit=  was required to skip over gas estimation RPC.
How to verify it
You can now omit gas_limit= here https://github.com/banteg/yfi-buyer/blob/b14673e84fb0e838709f1f1383a70064b3bb54d9/tests/test_buyback.py#L25
Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

Welp... I discovered why this happens and it is a little complicated.
The upstream provider sometimes dictate the error message format... Thus, we need to the upstream provider plugin to handle the error message.

[ ] Upgrade ape once next version is released


[Fix]: Data for Orthos Banshee

Mob Id
unsure, sorry T_T I was rushed on time and opened this after clearing the floors
What threat level sould the mob have
Easy
What agro type does the mob have
Proximity
Vulnerabilities for the enemy

[ ] Stun
[ ] Heavy
[ ] Slow
[ ] Sleep
[ ] Bind
[ ] Undead

Additional mob text guide
No response

Recheck with having mob id visual active and i might look at it again.


BUG: PixiFactory.getTextureDisplay

The arguments passed to PIXI.Texture are incorrect.
The second (currently null) definitely should be the rectangle of the sub-texture (aka "frame"), not sure about the following parameters though ("The area of original texture" vs "Trimmed rectangle of original texture").
I get the same (correct) result with both
textureData.texture = new PIXI.Texture(
    textureAtlasTexture,
    <PIXI.Rectangle><any>textureData.region,
    null,
    originSize,
    textureData.rotated as any // .d.ts bug
);

and
textureData.texture = new PIXI.Texture(
    textureAtlasTexture,
    <PIXI.Rectangle><any>textureData.region,
    originSize,
    null,
    textureData.rotated as any // .d.ts bug
);

Without submerging into the depths of both libraries, i would go with the second one though, since pixijs docs name it similar - "orig", "The area of original texture".
I used pixi 4.5.1, but since the constructors signature hasn't changed between previous (3.x) and current version, i would say it shouldn't make a difference which version You use.

Sorry for the later reply, the bug has been fixed. https://github.com/DragonBones/DragonBonesJS/commit/229e5f11b38299c2ef20018b6880f7105a5b8db1

@akdcl thank You, definitely will be a great/must have fix for PIXI clients!


svgIcon of undefined when tesintg via enzyme

When attempting to render a component using material-ui icons, via mount method of enzyme, the test case is failing with error "Cannot read property 'svgIcon' of undefined". Even though I am passing the context still no fix.

[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
The context should be available to the SvgIcon class in ScgIcon.js
Current Behavior
The context is not unavilable and hence failing with undefined error.

Steps to Reproduce (for bugs)
import React from "react";
import { mount } from "enzyme";
import DateFilter from "../../src/app/components/board/dateFilter";
import getMuiTheme from "material-ui/styles/getMuiTheme";
import MuiThemeProvider from "material-ui/styles/MuiThemeProvider";
import toJson from 'enzyme-to-json';

const muiTheme = getMuiTheme();

describe("Unit testing of dateFilter.js funcitonality", () => {
  const mountWithContext = node => mount(node, { context: muiTheme});
  it("should render the dateFilter Component", () => {
    const $dateFilter = mountWithContext(<DateFilter applyApiFilter={null} />);
    expect(toJson($dateFilter)).toMatchSnapshot();
  });
});

Context

Your Environment

Tech
Version

Material-UI
0.19.4

React
15.4

browser
NA

Any help would be great. As most of my test suites are not working. Only recently started introducing UTC in project.

@bishwenduk029 We can't help without a full reproduction example. For instance, ../../src/app/components/board/dateFilter is an external file.
We encourage people starting with Material-UI to go with v1-beta. The master branch is in a low maintenance mode. We don't plan any work on it. However, we still do our best to review and merge pull requests that fix bugs on this branch.
So, support questions for v0.x isn't our priority. You might find better luck on StackOverflow.

@bishwenduk029 we are having the exact same issue right now. Getting the Cannot read property 'svgIcon' of undefined when we do a full mount with Enzyme after providing the context correctly as well. Have you found any work around so far?

@grimunit, sorry for late response,  yes actually the third option in mount of enzyme helped me out. The third option childContextTypes allows for passing the context to infinite descendants down the tree.
import getMuiTheme from "material-ui/styles/getMuiTheme";
import { mount } from "enzyme";

const muiTheme = getMuiTheme();
const mountWithContext = node =>
    mount(node, {
        context: { muiTheme },
        childContextTypes: { muiTheme: PropTypes.object }
    });

export default mountWithContext;```


[SPARK-45501][CORE][SQL] Use pattern matching for type checking and conversion

What changes were proposed in this pull request?
This pr change to use pattern matching for type checking and conversion instead of the explicit type casting statement in Java code.
The change refer to JEP 394, and this pr does not include parts of the hive-thriftserver module.
Example:
  if (obj instanceof String) {
    String str = (String) obj;
    System.out.println(str);
  }

Can be replaced with
  if (obj instanceof String str) {
    System.out.println(str);
  }

Why are the changes needed?
Using JEP 394: Pattern Matching for instanceof can bring the following benefits:

Code conciseness: By eliminating explicit type conversion and redundant variable declarations, the code becomes more concise and easy to read.
Improved safety: In the past, explicit type conversion was required, and if accidentally converted to the wrong type, a ClassCastException would be thrown at runtime. Now, as type checking and type conversion occur in the same step, such errors are no longer possible.
Better semantics: Previously, instanceof and type casting were two independent steps, which could lead to unclear code intentions. Now, these two steps are merged into one, making the intentions of the code clearer.

Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No

This pr does not include parts of the hive-thriftserver module.

Ya, JEP 394 looks like a good improvement. Could you file a JIRA and use it, @LuciferYang ?

done

GA passed

Merged into master, thank @srowen @dongjoon-hyun


[html] Leading space character is removed when range formatting

Version
Version: 1.27.2 (user setup)
Commit: f46c4c469d6e6d8c46f268d1553c5dc4b475840f
Datum: 2018-09-12T16:17:45.060Z
Electron: 2.0.7
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architektur: x64
Steps to Reproduce
Example:
When i paste some text from clipboard with leading space e.g. " btn-link" the space is immediately removed.
Result:
Expected:
When I undo, the space is back there.

I'm new to VSCode development. If this is a good first bug I will pick it up and give it a shot.


Add TVS-473e to list

Can this unit be added to the system to allow me to be able to use the repository on the device? I've set it all up but only comes up blank.
Thanks

Hi @ricostuart
I happily would add it, however the problem is that I need a platformId and the cpu architecture of that NAS and I am unaware of a method to determine/lookup the platformId.
Can you tell me which emby (cpu architecture) downloadlink you use?
Then I can try to guess the platform id and you can verify it if it works :)

Thanks mate. It's a AMD R7 RX-421BD which is a x64 CPU. So I just get the normal x86/x64 download. Thank you, Patrick
-------- Original message --------From: Manuel @.> Date: 09/02/2024  8:22 pm  (GMT+00:00) To: WtfJoke/EmbyQNAPRepository @.> Cc: ricostuart @.>, Mention @.> Subject: Re: [WtfJoke/EmbyQNAPRepository] Add TVS-473e to list (Issue #5)
Hi @ricostuart
I happily would add it, however the problem is that I need a platformId and the cpu architecture of that NAS and I am unaware of a method to determine/lookup the platformId.
Can you tell me which emby (cpu architecture) downloadlink you use?
Then I can try to guess the platform id and you can verify it if it works :)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Hey Patrick, please check if it now shows up (I hope so) and let me know. Thanks!

Hey Patrick, please check if it now shows up (I hope so) and let me know. Thanks!

Just tested now and it works a treat! Your a star!


Update docs to use "osm mesh upgrade" for osm-config ConfigMap edits

There are several instances in the docs where we recommend users modify the osm-config ConfigMap with kubectl edit commands. Now that we have the osm mesh upgrade CLI command, that should be used in place of kubectl edit so changes are tracked by Helm and persist between control plane upgrades.

I searched all the markdown files in the repo for "configmap" or "kubectl" and found these spots to change:
https://github.com/openservicemesh/osm/blob/ad48e021e597484193ed38e3ae95c91f93fa87c3/docs/content/docs/patterns/egress.md#L34-L36
https://github.com/openservicemesh/osm/blob/ad48e021e597484193ed38e3ae95c91f93fa87c3/docs/content/docs/patterns/egress.md#L48-L50
https://github.com/openservicemesh/osm/blob/ad48e021e597484193ed38e3ae95c91f93fa87c3/docs/content/docs/patterns/ingress.md#L24-L26
https://github.com/openservicemesh/osm/blob/ad48e021e597484193ed38e3ae95c91f93fa87c3/docs/example/README.md#L153-L156
https://github.com/openservicemesh/osm/blob/ad48e021e597484193ed38e3ae95c91f93fa87c3/docs/example/README.md#L177
https://github.com/openservicemesh/osm/blob/ad48e021e597484193ed38e3ae95c91f93fa87c3/docs/example/README.md#L195
Here's an example of osm mesh upgrade in the docs:
https://github.com/openservicemesh/osm/blob/ad48e021e597484193ed38e3ae95c91f93fa87c3/docs/content/docs/patterns/observability/tracing.md#L38


Objective C Code Generation

This will be completed once this PR is merged.
https://github.com/microsoftgraph/microsoft-graph-docs/pull/4827


cli: de-duplicate IDL JSON in TS types

I haven't tested this locally yet (will do tomorrow if this is considered useful), I'm just getting reacquainted with IDL stuff that's been added over the past few months.
One of the things I noticed was that the IDL object is included twice in generated typescript types file. I assume the reasoning behind this was because the types were too generic?
If that's the case using as const should mean that you don't need to duplicate the JSON in the file as the type would effectively be a readonly representation of the object.

before: without as const, version is string
after: with as const, version is readonly "0.1.0"

Superseded by https://github.com/coral-xyz/anchor/pull/2824.


CHNGELOG or Release Notes

Please consider to write CHANGELOG or Release Notes.
Release notes would be nice. They can simply reference merged PRs.

are any changelog or release notes for 1.6.1 ?


Clicking on search results alternates between editor types

Testing #127355
Repro:

Create a notebook, e.g. GH issue notebook or MD notebook
Global search some text that will return results in that notebook
Click the result multiple times

🐛 => clicking alternates between opening the result in a text editor and notebook

I believe this is already fixed in insiders by https://github.com/microsoft/vscode/commit/a651ea4be5bafc9c4d7faf674c799bd35d068582


Does it support SDXL?

https://github.com/RoyiRa/prompt-to-prompt-with-sdxl/tree/main

is there an implementation for SDXL turbo? thx


Add support for vmin/vmax and IE9 transforms

Added vmin and vmax as supported units for transitioning
Check for msTransform in body to add minor support for IE9

Hey thanks for the PR, I'm going to add vmin/vmax support (and ch), but I really don't see the need for IE9 transforms support since request animation frame is not even supported.


stacktrace.go: fileContext should cache "file does not exist"?

If the source files do not exist, or are not in the right path, every call to NewStacktrace causes an attempt to open and read the file. This causes wasted system calls and memory allocations on long running servers that are deployed without their source code.
The cause is that in stacktrace.go the function fileContext caches the lines of source files. However, if the file does not exist, it does nothing. My suggestion: it should also cache "file does not exist", and not try to open a file more than once.
The disadvantage to caching: a user will need to restart their binary for it to pick up the source files, if they initially run into errors and don't have the files in place.
Additional Context
I'm indirectly using raven-go since I use Stripe's Veneur server (https://github.com/stripe/veneur). I noticed while investigating an unrelated problem, that every time an error was occurring it would attempt to open the source code files, which I don't ship on our production machines. We were running into an error regularly, so this showed up in a profile I was looking at. I'm going to use the following workarounds:

Make the context configurable, and use 0 in production.
Don't log so many errors

Boom, I like it. I can either poke at this, or you can submit a PR if you beat me to it, but again, I find this a reasonable request. I don't think we need to handle the case of someone putting source files into place, while the binary is running, and expecting it to magically work. If we do care about that, we can cache the misses with a TTL and do a check, say, once per minute or something.

Fixed by b68337dbf03e7fbb53d9fd9b63fd09b28e8f13f7


Confirmation on exit

Description
I like to have this binding:
bind = $mainMod, M, exit

But it's easy to accidentally type that and kill the entire session. Some kind of confirmation UI would be appreciated.

this is not a DE. Making a confirmation prompt would be left to you.

OK I see where you are coming from. I guess I will write an interactive script for this to bind to that key combo instead.


After 'auto replace tool' is triggered can no longer move items in inventory - they just get tossed out of inventory

I've been doing some afk mining using InventoryTweaks to replace my pickaxes. After a pickaxe has been replaced (might be just one, or it might be after a certain number) any time I open my inventory and try to move blocks around the blocks are instead ejected from my inventory instead of "picked up" by my mouse. After closing/reopening minecraft the issue seems to go away - but not upon logout from the server.
Details:
OS: Linux Mint
Java -version: java version "1.7.0_72"
Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
Forge version: 1289, 1285 (saw it on both)
Using latest build (1.59) from Jenkins download site.

Try pressing alt/ctrl/shift (on both sides), it might think that the shortcut for drop item is stuck down.

Yep, looks like that fixed it. Hitting 'alt' was the solution - I'm gonna guess it's related to alt-tabbing out. However, the interesting thing is that when I actually hold alt nothing happens (i.e. when I hold alt + click items don't get tossed out of inventory)


[WIP] Add action to update all installed fastlane tools

This action simply looks up all the fastlane.tools you have installed and updates them. If any of the fastlane.tools were updated, fastlane is restarted.
Recommended usage would be in a before_all block in the Fastfile.
This is WIP, because the following tasks still need to be done:

[x] Update Actions.md documentation to explain the usage
[ ] Add second action that helps with setting up ruby gems so we don't need to sudo every time
[x] Handle the situation where we would need root privileges correctly
[x] Test parameter handling (e.g. updating fastlane + deliver only)
[x] Don't update major versions (e.g. 1.0 to 1.1 is fine, 1.5 to 2.0 is not)

Did a rebase by accident, so got a lot of commits from feature/config into the commit list. Files changed shows correct files though

Changes Unknown when pulling 2c2ca40a63a017dc5d66dbd0fcc15ccdbc1cc5e4 on milch:feature/config/updater into ** on KrauseFx:feature/config**.

Great, is this ready to merge? Should I test it? :+1:

Yeah, you can test it now, everything should work correctly :+1:

Thank you! :rocket:


cant set server

Hello, i can not get to define a server as it keeps saying "failed to load specs!"...attached is a screen shot to back that up. may be i am missing something but i followed all the steps correctly..will appreciate your advice on that.
thanks

Hi, Can you please check if you have provided the --dataDir option when starting the isosim? The dataDir option should be a directory containing a specs directory with all the definitions.

Its really interesting. Can you given me the details that you see on the linux console?

hello, goodmorning...here is my screenshot

sure, let me check that and i will get back to you
On Thu, May 17, 2018 at 8:21 PM, Raghavendra Balgi<EMAIL_ADDRESS>
wrote:

Hi Sam, Its really strange. I don't know whats wrong. Perhaps the browser?
If using chrome, can you see if there is anything on the console
(ctrl+shift+i)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rkbalgi/isosim/issues/4#issuecomment-389943908, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUQQXvKhQtfPqjM5sodP3a6eGMrXkDjsks5tzbGcgaJpZM4T8WVu
.

--
the quieter you become, the more you are able to hear

HIE guys i have found the issue!
solution:
use the http://localhost:8080 address insted of your local machine ip address like http://<IP_ADDRESS>

its mandatory to use the localhost ip address

so i cant use it on a remote server?
On Tue, Jun 19, 2018 at 12:32 PM, VICTOR CHINYAVADA <
<EMAIL_ADDRESS>wrote:

its mandatory to use the localhost ip address
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rkbalgi/isosim/issues/4#issuecomment-398337074, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUQQXhU9hnJi57Iav_UE7mFzXEZCUJ0jks5t-MU_gaJpZM4T8WVu
.

--
the quieter you become, the more you are able to hear

yes! unless you go throught the code replacing all "localhost" with remote server ip address! logically that should work

okay thanks

I'll take a look at this today and see if I can fix it

I have pushed some changes that should now allow this to run on any network interface (including localhost). Thanks.

great man
On Wed, Jun 20, 2018 at 9:17 PM, Raghavendra Balgi<EMAIL_ADDRESS>
wrote:

I have pushed some changes that should now allow this to run on any
network interface (including localhost). Thanks.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/rkbalgi/isosim/issues/4#issuecomment-398847123, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUQQXsurJjegipCVCdtXAsPvHoVq8N9dks5t-pGfgaJpZM4T8WVu
.

--
the quieter you become, the more you are able to hear

thanks to you


Failsafe throttle update

The firmware currently requires that the user set the failsafe throttle before being able to arm the multirotor. This isn't clearly explained. Also, the default value shown in the documentation for this parameter isn't correct.

Mentioning setting the RC type would also be useful in the getting started page.

Didn't mean to close...


Reduce backend requests in events access policy tab

Previously, the frontend would send a POST request for every user role in the ACL. Since we get ALL users in another request anyway, this commit changes that to instead get filter the users from the list of all users we already have. It does so fairly efficiently by leveraging binary search.
Your pull request should…

[ ] have a concise title
[ ] close an accompanying issue if one exists
[ ] be against the correct branch
[ ] include migration scripts and documentation, if appropriate
[ ] pass automated tests
[ ] have a clean commit history
[ ] have proper commit messages (title and body) for all commits

This is a draft, which is why it hasn't been merged (pending review).  Is it going to come out of draft prior to the end of the r/13.x branch?  If not, please close and refile in the right place when it's ready.

13.13 was the last 13.x release. @Arnei, please redirect this to r/14.x or newer.

I will close this as 13 is EOL now. Feel free to refile for newer versions or redirect and reopen.


Change confinement to strict & use personal-files plug

Codecov Report

Merging #87 into develop will increase coverage by 5.27%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop      #87      +/-   ##
===========================================
+ Coverage     51.3%   56.57%   +5.27%
===========================================
  Files            3        3
  Lines          269      327      +58
===========================================
+ Hits           138      185      +47
- Misses          99      105       +6
- Partials        32       37       +5

Impacted Files
Coverage Δ

pkg/config/config.go
57% <0%> (+9.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335b0f8...3dc55bb. Read the comment docs.

Have you tested this? I raised a PR too for same but used 'home' as value for plugs.
I couldnt test it though.


Can't compile from source missing dependencies

Delphi 12
Missing windows 11 light and dark styles
sha512-x64sse4.obj
crc32c64.obj
Awesomefont.res

You must download those styles from GetIt, by yourself, or remove those styles from .dproj file.

Resolved?


fix route naming to not include -N or -% sufixes

Closes #1 and #2

Great, thanks!

Great, thanks!


Add support for country rules to Access

Description
This PR adds support for managing access based on a country code.
Has your change been tested?
Example curl request:
curl --request GET \
  --url https://api.cloudflare.com/client/v4/accounts/<ACCOUNT_ID>/access/apps/<APP_ID> \
  --header 'authorization: Bearer <TOKEN>' \
  --header 'x-auth-email: <EMAIL>' \
  --header 'x-auth-key: <AUTH_KEY>'
{
  "result": {
    "aud": REDACTED,
    "created_at": "2020-09-03T20:27:02Z",
    "domain": "asdf.fans",
    "id": REDACTED,
    "name": "asdf-fans",
    "policies": [
      {
        "created_at": "2020-09-18T14:42:20Z",
        "decision": "allow",
        "exclude": [],
        "id": REDACTED,
        "include": [
          {
            "geo": {
              "country_code": "US"
            }
          }
        ],
        "name": "asdf",
        "precedence": 1,
        "require": [],
        "uid": REDACTED,
        "updated_at": "2020-09-18T14:42:20Z"
      }
    ],
    "allowed_idps": [],
    "auto_redirect_to_identity": false,
    "session_duration": "24h",
    "uid": REDACTED,
    "updated_at": "2020-09-18T14:42:20Z",
    "enable_binding_cookie": true
  },
  "success": true,
  "errors": [],
  "messages": []
}

What sort of change does your code introduce/modify?

[X] New feature (non-breaking change which adds functionality)

Side note: Do we have the public documentation available for this one?


IndexedAttribute should allow multiplicity

Actually, only a single occurrence of the IndexedAttribute can be applied to a property. Since the same property may be part of multiple indexes, this constraint should be relaxed.
This could be accomplished by changing the actual
[AttributeUsage(AttributeTargets.Property)]
to
[AttributeUsage(AttributeTargets.Property, AllowMultiple = true)]

I think the same. Otherwise, how people do that?
This would be a small change and a great improvement.

(Yeah! I knew I was missing something ...)
For slow people like me, to have this you must go to softlion's fork


W-14764289-add-limit-property-45-dm

Writer's Quality Checklist
Before merging your PR, did you:

[ ] Run spell checker
[ ] Run link checker to check for broken xrefs
[ ] Check for orphan files
[ ] Perform a local build and do a final visual check of your content, including checking for:

Broken images
Dead links
Correct rendering of partials if they are used in your content
Formatting issues, such as:

Misnumbered ordered lists (steps) or incorrectly nested unordered lists
Messed up tables
Proper indentation
Correct header levels

[ ] Receive final review and signoff from:

Technical SME
Product Manager
Editor or peer reviewer
Reporter, if this content is in response to a reported issue (internal or external feedback)

[ ] If applicable, verify that the software actually got released

We should add the value in the example that is there in the table and also in the configuration that is under "Configure the Runtime Fabric Deployment Strategy" title. We can use the same value as memory reserved

Closing this PR as the runtime team confirmed that the memory bursting may bring issues. The parameter won't be included.


chore: provide a more up-to-date prismjs example

Change the example code in README to be compatible with the latest prismjs function. Also use a function component rather than a class component to reduce complexity.
Additionally add the main prismjs css file since many issues arise from the lack of it in the example usage. (#58 #46 #16 )

I'm not sure why the Class-based example had to be overwritten?  I know arrow-functions are the new hipster way to React, but you could have just added it without removing the other example?

@tomByrer React function components and hooks are here to simplify and help React developers. We have completely transitioned to function based components and recommend anyone else to do so too. React documentation is moving to it and material-ui recently also converted all of their examples to function components.
Function components are not "the hipster way to React" but rather class based components are legacy and should only exist in your projects because you haven't gotten to refactoring them yet.

@satya164 could you please review? This PR has been open for over a month now.

any updates on this PR? Could be extremely useful. :) @satya164

@cyberbeast pretty sure this repo is abandoned :(

Problem solved in https://github.com/satya164/react-simple-code-editor/pull/79


use injected git dev version for tests

Issue #, if available:
Description of changes:
Use the injected gitVersion for marshalling cluster configuration during flux tests, rather than hard-coding the dev release.
This will ensure that we have the proper git version for release branch tests (e.g. v0.0.0-dev-release-0.8 vs v0.0.0-dev)
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherry-pick release-0.8

/override eks-anywhere-presubmit
/override eks-anywhere-e2e-presubmit

/override eks-anywhere-attribution-files-presubmit


redirect "back"

Is there anyway to redirect to previous page in Sanic?

i am not sure wha you're looking for... maybe https://github.com/channelcat/sanic/blob/master/sanic/response.py#L394 ?

Keeping track of the history should be done by the client (e.g. in the browser). I'm going to close this but feel free to reopen it if needed.


Automatic reconnect

Requires tracking the subscriptions and re-subscribing after reconnect.

This is merged into master and published as 0.1.2.


add proxy server setting

not entirely sure about this one. it will be too harmful, but someone will still do it sooner or later.
Of course, this is not for browser, this is only for node.js.

done.


Add StakingFeature - python

https://github.com/iotaledger/tips-draft/blob/tip42/tips/TIP-0042/tip-0042.md#staking-feature

Closed by https://github.com/iotaledger/iota-sdk/pull/1196


Doc in 3.2 using screenshots from 2.6

Description:
In doc
https://apim.docs.wso2.com/en/latest/reference/samples/api-development-sample/collaborative-api-development-sample/#collaborative-api-development-sample
Pictures are from 2.6
Steps to reproduce:
go to
https://apim.docs.wso2.com/en/latest/reference/samples/api-development-sample/collaborative-api-development-sample/#collaborative-api-development-sample

Hi Laslo,
Thank you for creating this issue related to docs. I have transferred this issue to docs-apim repo. Please create issues related to docs in docs-apim.
Thank you!
Pubudu.

got it.. my bad .. I clicked on the wrong button

It is totally fine Laslo!

@Sarangan0219 , please fix this issue.

Assignees
@Sarangan0219

Reported issues regarding sample-scenarios in https://github.com/wso2/product-apim/issues/9464

Since the same has been mentioned in https://github.com/wso2/docs-apim/issues/1388 , we will be closing this issue.


import not found or unreadable: variables.

I met an error when running the command "bundle exec jekyll serve". It seems that the main.scss cannot import the file (variables) from _sass.
Jekyll::Converters::Scss encountered an error while converting 'assets/css/main.scss':                     File to import not found or unreadable: variables. Load path: D:/Softwares/Ruby27-x64/lib/ruby/gems/2.7.0/gems/jekyll-theme-primer-0.5.4/_sass on line 7

Thanks for raising this. Could you please update your ruby to 2.7.2 or newer (3.0.0 should work as well) and try again?
If you run into any issues, please described the steps you took and provide the full error log, otherwise, it's hard to diagnose where the issue is coming from. On my end, installing a fresh ruby 2.7.2 or newer through rbenv and then running bundle install && bundle exec jekyll serve works as expected.

Thanks very much for responding. The problem has been solved. I guess the reason may be the path problem when I use windows 10. When I change to the subsystem of win10, it works.


Netwok View is not using all available space to render network

Hendrik Poorter commented: At my screen the graphs tend to stay in the middle. I can move individual nodes, but could I start with a screen that kind of centers closely related things, but sets more unrelated things further apart?
See below screenshot:

It looks like the graph layout algorithm uses a square area. Is it possible and how would the layout look like if the whole rectangle was used.

Maximized (full screen) view does a better job but most layout algorithms (and our default) uses a square bounding box to constrain nodes and edges within. So, we can drag and move nodes but auto-layout clusters them closer again. Having a larger, square KnetMaps container could space better.


Visual Studio Team Services Support

Support VSTS
Documentation: VSTS Variables
Environment variables:
- Service detection: $BUILD_BUILDURI - Return the URI for the build. For example: vstfs:///Build/Build/1430
- Branch: $BUILD_SOURCEBRANCHNAME
- Commit sha: $BUILD_SOURCEVERSION
- Is Pull request: $BUILD_REASON
- Pull request: $SYSTEM_PULLREQUEST_PULLREQUESTID
- Build number: $BUILD_BUILDNUMBER

Sure. Can you confirm the actual variables provided by VSTS?
The docs seems to indicate variables formatted like Build.SourceBranch, while in the comment above it's formatted like BUILD_SOURCEBRANCHNAME.

VSTS has PascalCase "build variables", which are exposed as environment variables in UPPERCASE convention: https://docs.microsoft.com/en-us/vsts/pipelines/process/variables?view=vsts&tabs=yaml%2Cbatch#working-with-variables
The variables look correct to me.

:tada: This issue has been resolved in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adds str_wrap and stringify helper methods

Description
Adds 2 new string helper methods:

str_wrap(), which interally usage str_start() and str_finish() - wrap string with single instance of given value.

stringify() - returns string representation of given scalar value.
It is different from strval() or (string) $x as illustrated below.
>>> (string) null
=> ""
>>> stringify(null)
=> "null"
>>> (string) false
=> ""
>>> stringify(false)
=> "false"
>>> (string) true
=> "1"
>>> stringify(true)
=> "true"

Backward compatibility
It is a new helper method and hence is backward compatible.

What the benifit of this vs type casting?

What the benifit of this vs type casting?

Typecasting doesn't exactly gives string representation. E.g. null is typecasted to empty string "" and so on (snippets in pr desc).
This was helpful for me in certain scenario, I was hoping others might find it of use.

One common consensus is: no more global helpers.


Document database types

In the section below we describe that database types can differ from schema types. For example :text in a migration file would be :string in the Schema.
https://hexdocs.pm/ecto_sql/Ecto.Migration.html#module-field-types
As this section only mentions examples, where do we find the list of database types (with their corresponding Schema types)?
It would be nice to have a link with the documentation. If it's per adapter, then at least have a link to the types that Postgres supports, as Postgres seems to be the most commonly used.

As an example, where do I find the possible values for a timestamp?
:timestamp ?
:utc_timestamp ?
:timestamptz ?
I'll eventually find out, but it seems this should be documented rather than let users go into 'trial and error' mode.

From IRC:
<josevalim> thojanssens_: it is the same atom you pass in the schema
<josevalim> all other atoms are sent to the database as is, so it is really what your database supports


Add my (zachary) PPP

Codecov Report

Merging #165 (fce4bad) into master (a3966ec) will increase coverage by 9.39%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #165      +/-   ##
============================================
+ Coverage     62.26%   71.65%   +9.39%
- Complexity      573      811     +238
============================================
  Files            95       99       +4
  Lines          2035     2618     +583
  Branches        230      351     +121
============================================
+ Hits           1267     1876     +609
+ Misses          657      589      -68
- Partials        111      153      +42

Impacted Files
Coverage Δ

...ain/java/socialite/logic/commands/FindCommand.java
82.35% <0.00%> (-17.65%)
:arrow_down:

src/main/java/socialite/logic/LogicManager.java
64.51% <0.00%> (-11.49%)
:arrow_down:

...va/socialite/logic/parser/RemarkCommandParser.java
92.85% <0.00%> (-7.15%)
:arrow_down:

...java/socialite/logic/parser/EditCommandParser.java
82.66% <0.00%> (-4.57%)
:arrow_down:

...main/java/socialite/logic/commands/AddCommand.java
88.88% <0.00%> (-2.78%)
:arrow_down:

src/main/java/socialite/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/socialite/model/CommandHistory.java
80.00% <0.00%> (ø)

...ava/socialite/logic/parser/ShareCommandParser.java
100.00% <0.00%> (ø)

...va/socialite/logic/parser/DeleteCommandParser.java
100.00% <0.00%> (ø)

...java/socialite/storage/JsonContactListStorage.java
85.71% <0.00%> (ø)

... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3966ec...fce4bad. Read the comment docs.


View All Implemented Organizations (Users)

User Story

As an SSO Administrator
I want to quickly and periodically review all implemented organizational users
So that I can clean up realms that are no longer used or required.

Acceptance Criteria or Constraints

I'll see this or
The solution will conform to this or
Non-functional requirements

Acceptance Tests
Scenario 1: xxxxxx

GIVEN ...
WHEN ...
THEN ...

Scenario 2: xxxxxx

GIVEN ...
WHEN ...
THEN ...

Dependencies?
Team or ideally a ticket
Risks

Description
Impact
Strategy
Contingency Plan

If this does or doesn't occur by...
Then this will happen, costing $?
Mitigate, Transfer, Accept, Avoid
We will do this, if it occurs

Process Guidance
User Story
A short introductory section with the following structure:
As a: the person or role who will benefit from the feature;
I want: the feature;
so that: the benefit or value of the feature.
Acceptance Tests or also called Behaviour Driven Development Acceptance criteria
A description of each specific scenario of the narrative with the following structure:
Given: the initial context at the beginning of the scenario, in one or more clauses;
When: the event that triggers the scenario;
Then: the expected outcome, in one or more clauses.

working towards Custom Realm Profile App


[BUG] Live video causes invalid time value

Bug Description
Attempting to play a live video causes the play() method to return an unhandled promise rejection.
Reproduction Steps
Steps to reproduce the behavior:

Play any live video with a link from YouTube OR search a live video.
Error is thrown.

Expected Result
The player plays and no error is returned.
Attachments
thread_music: (node:21056) UnhandledPromiseRejectionWarning: RangeError: Invalid time value
    at Date.toISOString (<anonymous>)
    at getVideoDuration (E:\github\diit\diitbot\node_modules\discord-music-player\src\Util.js:41:25)
    at E:\github\diit\diitbot\node_modules\discord-music-player\src\Util.js:108:34
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(Use `node --trace-warnings ...` to show where the warning was created)

Versioning:

NPM Version [e.g. v6.14.8]
Module Version [6.4.1]
ytdl-core [4.5.0]

Additional Comments
A catch block has no effect on catching the error.

This BUG was marked as FIXED in the V.7.0.0 update.
https://www.npmjs.com/package/discord-music-player


Fix issue when using layer-collector

Fixes wrongly recognized violation.
Open Tasks:

[ ] Add tests
[ ] For safety, check also if this might reintroduce #910 (see #912)

No test for this, because I had some trouble setting up the CollectorResolver with the LayerResolver in it, which then uses the CollectorResolver again. I have tried it out manually, though. So, it should be fine for now.


Should we use the Dev branch or main?

Saw that Main has not been updated for 2 years, but Dev is only two weeks old and wanted to know how stable Dev is and if you would like people to try it out?

Hey,
Thanks for your interest in the project. You are correct, the main branch has not seen a new release in 14 months, however, this will be changing in the next few hours, as I prepare to push v3.4. And as you can see, there has been plenty of massive improvements under development in the dev branches.
I dont love to leave my projects this long without a release, however, the current version has been so stable (in my heavy use of it), that most of my focus in the development branches are focused on larger changes that would come with a v4.0.
I would say v4.0 is 85% developed, most of the remaining work is just extensive testing and integration.
I take stability on this project very seriously, and do not recommend deviating from the release tags. However, I develop in the open, and you are welcome to take a look and test whatever you would like :)


Badge

Fixes #27.

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


ter

Type: Missing
Summary:
ter
Details:
test
Resolution:
test
Affected definitions:

nextflow 21.10.4

You can review the change introduced to the full definition at ClearlyDefined.


Remove AsyncCounter and SyncCounter interfaces

Package https://github.com/belaban/jgroups-raft/blob/8e1b052ba7e610fee2c4169bb85a5691cdede97c/src/org/jgroups/blocks/atomic/package-info.java is temporary and should be removed when merged in JGroups

OK, I'll apply this PR when JGroups 5.2.10.Final has been released


Add pop to StorageArray

Added a pop function to StorageArray.
One thing to check is that an error will occur in the pop function when StorageArray is empty, which I have handled with an assert statement by referring to checkpoint.cairo.”

PR Checklist

[ ] Tests
[x] Documentation
[x] Added entry to CHANGELOG.md
[ ] Tried the feature on a public network

Hey @JhChoy, thanks for taking the time to open this PR. StorageArray was a solution to support the ERC20Votes extension implementation, but it was intended as a temporal module since the language itself should provide a default implementation at some point. With the 2.7 release we now have Vec, which is an array that can be used in storage. Our current StorageArray implementation will stay for a while because is used in ERC20Votes, but we probably will remove it, and we don't want to extend it. The recommendation is to use Vec instead.


Replace setUGI with delegation token

https://prestosql.slack.com/archives/CGB0QHWSW/p1569411493174100

Now it works with kerberized metastore only, right?
If it helps for kerberized HMS, we may need to keep setUGI for no-auth and delegation token for kerberized.

Yes, only kerberized metastore. Let me update to use both UGI and delegation token.

@findepi Thanks for your review. Updated.

Merged, thanks!


Watch for cookie expire

Enhancement to the auth system
Expectations: Store response from /login and check if cookie expires in 180 days or less.
Reason Save having to store user login details at all since we can keep them auto signed in with just the cookie.
Todo:

[x] Store the response from login in a electron-store
[x] Add a function to check expiresIn to see if it's less than 180 days away
[x] If less than 180 days away renew cookie with refreshToken

This has been completed with commit 9e9a5dd14cba1f671820ce5d96d8fbfc264f50c4


Install failed through helm

There's no existing/similar bug report.

[X] I have searched the existing issues

Describe the bug:
The deployment failed through Helm, and several components cannot run properly.
Expected behavior:
Helm can deploy and run the corresponding components properly. For example, for components that require a password, a default password can be configured, and for components that do not have sufficient permissions, the corresponding rbac needs to be configured.
Additional
No response
Lunettes version
main
Kubernetes version
v1.21.3

@zwForrest Please show more details, such as component logs.

@zwForrest Please show more details, such as component logs.

The grafanadi pod requires configmap permissions.
jaeger pod  logs {"level":"info","ts":1701216267.1549637,"caller":"grpc@v1.54.0/server.go:935","msg":"[core][Server #2] grpc: Server.Serve failed to create ServerTransport: connection error: desc = \"transport: http2Server.HandleStreams failed to receive the preface from client: unexpected EOF\"","system":"grpc","grpc_log":true}.
Also, where can I find how the Prometheus expressions in your articles are aggregated?

@zwForrest Please show more details, such as component logs.

The grafanadi pod requires configmap permissions.
jaeger pod  logs {"level":"info","ts":1701216267.1549637,"caller":"grpc@v1.54.0/server.go:935","msg":"[core][Server #2] grpc: Server.Serve failed to create ServerTransport: connection error: desc = \"transport: http2Server.HandleStreams failed to receive the preface from client: unexpected EOF\"","system":"grpc","grpc_log":true}.
Also, where can I find how the Prometheus expressions in your articles are aggregated?

thanks @zwForrest . Cloud you give some context of your Kubernetes cluster? Is it a pre-built cluster? If not, which bootstrap tool have you used to create the cluster? And also, which tenant you used to deploy lunettes?

@larryck This is an existing k8s cluster created by kubeadm. I deployed lunettes by helm.

Is there a DingTalk groups available？


[Feature] Toggle for looping

Would be nice if I could disable looping when I watch shorts.

Further expanding on this, there should be a looping toggle for regular videos too, since currently the only way to loop is by right clicking the video to enable looping.


Added zod validation for id in GET topic/:id route

Below is the attached screenshot for 3 cases,

Did the changes, please check.

@prasenjeet-symon i would like to add one point here. Moving the prisma calls along with the validator parsing into try block would be a better approach. It will catch any error (zod error or prisma error) in the catch block thus will send 400 error to the fe. This way will also eliminate the use of let keyword.

@prasenjeet-symon i would like to add one point here. Moving the prisma calls along with the validator parsing into try block would be a better approach. It will catch any error (zod error or prisma error) in the catch block thus will send 400 error to the fe. This way will also eliminate the use of let keyword.

@sparsh-18 Can you submit the new PR

Waiting for new changes

sure

Hi, added the changed


[BEAM-9199] Require --region option for Dataflow in Java SDK.

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Python failure is a known flake (BEAM-9318)

Please run a few different tests.

I triggered Java postcommit, not sure which other tests you mean?

postcommit tests should be sufficient.

Quickly check website/quickstart examples to see if there are any examples that need region flag.

I think I got them (I grepped for --project which should be a superset of places we also need --region)

Cool.


Logout will destory all the data but proxy settings?

after i ran the logout function,
GetProxies just return empty list.
is this right?
if so, when i dev a new app,  should I hold the proxy settings data on file?

logOut destroys all data, including proxy settings. If you want to synchronize them between accounts, you need to store the list of proxies yourself.

Okay, thanks.


custom loss function when using pretrained model

Hi,
I got an error when using my own loss function.  My net is to produce an RGB image. So I wanna use the pretrained VGG-16 net to extract feature map and compute the 'mse' between predicted image and target image.
Here is my code:
def VGGloss(y_pred, y_true):
     vggmodel = VGG16(include_top=False)
     f_p = vggmodel.predict(y_pred)
     f_t = vggmodel.predict(y_true)
     return K.mean(K.square(f_p - f_t))

and  the error logs:
  File "K:/codes/code_demo/demo.py", line 241, in VGGloss
    f_p = vggmodel.predict(y_pred)
  File "I:\ProgramData\Anaconda3\lib\site-packages\keras\engine\training.py", line 1748, in predict
    verbose=verbose, steps=steps)
  File "I:\ProgramData\Anaconda3\lib\site-packages\keras\engine\training.py", line 1290, in _predict_loop
    batches = _make_batches(num_samples, batch_size)
  File "I:\ProgramData\Anaconda3\lib\site-packages\keras\engine\training.py", line 384, in _make_batches
    num_batches = int(np.ceil(size / float(batch_size)))
TypeError: unsupported operand type(s) for /: 'Dimension' and 'float'

could someone tell me how to use pre-trained model to compute a custom loss ?

Hello :blush:
I had the same error when trying to implement the perceptual loss described in this paper. My code is similar to what you're showing. I solved this issue by doing something like
def VGGloss(y_true, y_pred):  # Note the parameter order
     vggmodel = VGG16(include_top=False)
     f_p = vggmodel(y_pred)
     f_t = vggmodel(y_true)
     return K.mean(K.square(f_p - f_t))

I don't know the technical details, but this is similar to using the functional API of Keras. Hope this helps!

You may want to move the model declaration outside of the function like so:
vggmodel = VGG16(include_top=False)
def VGGloss(y_true, y_pred):  # Note the parameter order
     f_p = vggmodel(y_pred)
     f_t = vggmodel(y_true)
     return K.mean(K.square(f_p - f_t))

An alternative to this custom loss function method is to concatenate the vgg16 model at the end of your model, make it untrainable, and use the built-in 'mse' loss function, and call fit on the full model. (As described in https://stackoverflow.com/questions/43914931/vgg-perceptual-loss-in-keras). I'm not sure which one is more efficient though.

@charlesverdad Why we don't need to make VGG16 not trainable in this VGGloss example?


Update README with fingerprint error handling & FirebaseHttpClient.h for US servers

This PR addresses two important updates:

README.md Update: Added instructions for handling fingerprint errors in the README.md file. Users encountering fingerprint errors will now be guided on how to update the fingerprint in FirebaseHttpClient.h.

FirebaseHttpClient.h Update: Updated the FirebaseHttpClient.h file to reflect changes for US servers as of February 2024. This ensures that the library connects properly to the Firebase servers based in the US.

These updates enhance the usability and reliability of the FirebaseArduino library.

For others looking to fix fingerprint error,
If you encounter a fingerprint error while using the FirebaseArduino library, you can follow these steps to update the fingerprint:

Navigate to the FirebaseHttpClient.h file located at Documents > Arduino > libraries > FirebaseArduino > src > FirebaseHttpClient.h.

Find the section in the file where the fingerprint is defined.

Visit this link to obtain the latest fingerprint for the Firebase servers.

Replace the existing fingerprint in the FirebaseHttpClient.h file with the new one.

Save the file and recompile your project.

This should resolve the fingerprint error and allow your project to connect to the Firebase servers successfully. If you have any further questions or issues, feel free to ask for assistance.


OpenTracingSpringMvcAutoConfiguration add ConditionalOnClass SpringMvcSofaTracerFilter

OpenTracingSpringMvcAutoConfiguration add ConditionalOnClass SpringMvcSofaTracerFilter. #111

Ant testcase?

@khotyn I want to make OpenTracingSpringMvcAutoConfiguration invalid, there are two ways to achieve:

add @EnableAutoConfiguration(exclude = {OpenTracingSpringMvcAutoConfiguration.class})
remove sofa-tracer-springmvc-plugin

The first solution does not take effect before 2.2.0 becase of ComponentScan
The second solution does not take effect  in all the version, I think it should be fixed.

@caojie09 可以加测试用例吗？


Using --addlabel=parameters raises TypeError("can't intern subclass of string") in python 2.7

Commit 124a113841f2 (which contained the fix for #278) introduced a new bug when using the option --addlabel=parameters.
To reproduce:
git clone https://github.com/maxalbert/smt_bug.git
cd smt_bug
smt init TestProject
smt configure -e python -m main.py --addlabel=parameters
smt run -r "Test run"

This results in the following traceback. (However, if you omit the option --addlabel=parameters in the smt configure command above then it works fine.)
Traceback (most recent call last):
  File "/usr/local/bin/smt", line 31, in <module>
    main(sys.argv[2:])
  File "/home/vagrant/work/code/sumatra/sumatra/commands.py", line 401, in run
    version=args.version or 'current')
  File "/home/vagrant/work/code/sumatra/sumatra/projects.py", line 217, in launch
    record.run(with_label=self.data_label)
  File "/home/vagrant/work/code/sumatra/sumatra/records.py", line 146, in run
    self.datastore.root = join(self.datastore.root, self.label)
  File "/home/vagrant/work/code/sumatra/sumatra/datastore/filesystem.py", line 91, in __set_root
    path = Path(value)
  File "/usr/local/lib/python2.7/dist-packages/pathlib.py", line 936, in __new__
    self = cls._from_parts(args, init=False)
  File "/usr/local/lib/python2.7/dist-packages/pathlib.py", line 613, in _from_parts
    drv, root, parts = self._parse_args(args)
  File "/usr/local/lib/python2.7/dist-packages/pathlib.py", line 606, in _parse_args
    return cls._flavour.parse_parts(parts)
  File "/usr/local/lib/python2.7/dist-packages/pathlib.py", line 90, in parse_parts
    parsed.append(intern(x))
TypeError: can't intern subclass of string

I'm using Python 2.7.6 on Ubuntu 14.04 with the latest Sumatra master (f5f96ba842f031). I haven't had a chance to test it on Python 3 yet.

Without having tested it, I assume this is a Py2 problem only. new_str from python-future and Path from pathlib don't seem to work with each other -- which is quite unfortunate. The best solution I could come up with here would be not to use pathlib in sumatra.datastore.filesystem; not smart, but should do the work.

Yes, you are right regarding Py3. I did a test with it earlier and it does work.
The problem arises because the datastore root is set to a newstr instead of str or unicode. I think the least intrusive way of fixing it is inside FileSystemDataStore.__set_root where we can check simply convert the argument value to one of those types if needed (which is only necessary for Python2). I'll submit a PR for this tomorrow.


Location for license information

Key component for OIN will be the license. We'll need to have documentation about the license. Should this text live here in the register repo or in a separate repo?

I think in the register is the best place so it is clear what license people are agreeing to when they register.

:+1: Cool.
Next action here is to add license information to the repo here.

Added a LICENSE file https://github.com/openimagerynetwork/register/commit/9ccfa0ef53fe5b6a014344a86fec9b77b5e92a4d.  We'll want to outline license in a readme description as well. Will keep open until that is complete.

Does this mean that public domain imagery acquires an attribution requirement by virtue of being listed in the registry?
It strikes me that master.json should include a license field (populated with values from https://spdx.org/licenses/, similar to npm) and that this registry includes a (limited) list of acceptable licenses.


FMA document should link to detailed paper on process

The introduction section of Designing resilient applications for Azure: Failure mode analysis is a good overview at a very high level but if people actually want to look at how the process is implemented in detail than the http://aka.ms/resiliency link is a good one to give them detailed guidance on FMA.
This link is also provided in other locations like within Designing resilient applications for Azure so it's puzzling why it's not included in this paper.

Added link to the PDF


Bintray has shut down

These images heavily depend on a custom repo hosted on Bintray, which as of May 1st doesn't work.
Relevant issue:
https://github.com/codecasts/php-alpine/issues/131
So I guess it's waiting game until they decide when and where they're going to move.

Thanks. I'll try to address this at some point.

Originally it was required as the updated versions were not in the main alpine packages repo. They might be now, and if so moving to the official one will make more sense.
We did have to swap around every time a new version came out tho which was very annoying.

Ah that makes sense. So this only affects PHP versions 7.3, 7.4 and 8.0.
Those are all in the main repos, at least the core components.

Alpine 3.12 - PHP 7.3
Alpine 3.13 - PHP 7.4 and 8.0

I don't know how to patch and test this repo. Happy to have a stab though.


Grid component #104

https://github.com/sociomantic-tsunami/nessie/issues/104

there's a new PR for this https://github.com/sociomantic-tsunami/nessie/pull/192; so closing this one


jsonschema2pojo-gradle-plugin gradle version 7 compatibility problem

When I try to build a project, this error is shown:

A problem was found with the configuration of task ':generateJsonSchema2Pojo' (type 'GenerateJsonSchemaTask').

In plugin 'jsonschema2pojo' type 'org.jsonschema2pojo.gradle.GenerateJsonSchemaTask' property 'configuration' is missing an input or output annotation.

According to this link, it's because of incompatibility with gradle ver.7. I saw an answer that says such changes are needed, but I have no idea how to do this. I need some help to use this great library with gradle 7.

These are not the only changes are required to make it compatible. There's need to remember also about groovy (in)compatibility. I had to rewrite my plugin for this generator to Kotlin

@eirnym Really? If it doesn't concern, may I ask you how did you solve it?

My integration tests with Gradle 6.x-7.x exposed this incompatibility, so I rewrote plugin to Kotlin as a more stable programming language and theoretically I can support even Gradle 4.x or 5.x for some API if it's really needed. I don't think it's majority of Gradle users, but who knows.
Official JsonSchema2Pojo plugin is (at least was) good enough to support back to very early versions of.


pkg{,_edit}.php - Remove no-op code related to tabs->dropdown fallback

See https://redmine.pfsense.org/issues/7889 for related discussion

@bmeeks8 Nuke the tags from {snort,suricata}_sync.xml on next packages updates please, didn't do anything useful anyway. ;)

OK.  I will remove the tags from the XMLRPC code page in both packages.
Bill

The tags have been removed from both the Snort and Suricata packages in the Pull Requests linked below.
Snort:  https://github.com/pfsense/FreeBSD-ports/pull/425
Suricata:  https://github.com/pfsense/FreeBSD-ports/pull/426
Bill


FR: Hotkey for jumping to the next set of cards

Hi, really liking the cards view! Much better overview of the search results than vanilla Obsidian provides. However, I'm not seeing a hotkey to jump to the next set of cards. There is a hotkey to move to the next selection with ctrl+n, but with the 3x3 cards layout, this requires 9 clicks to get there. Can there be a hotkey to create the next set of cards?

@HEmile

@HEmile
Thank you for your request!
I will implement it soon.
I'm thinking of Ctrl + ←/→ as hotkeys.

@HEmile
I implemented page moves by hotkeys in pre-release 0.5.0.
I adopt Ctrl + ] and Ctrl + [  as hotkeys.
I hope you will try this feature.


Morphological operations in image processing using OpenCV python.

Proposed title of the article
Morphological operations in image processing using OpenCV python.
Proposed article introduction
In this tutorial, we will learn about morphological operations.
What are morphological operations? -These are image processing transformations applied to either grayscale or binary images. These operations require a structuring element, which is used to define the neighborhood of pixels the operation is applied to. how to use morphological operations to increase the size of objects in images as well as decrease them.
We also discuss on  the most important morphological operations that you’ll use inside your own applications:
Key takeaways
The reader of this article will understand:
The concept of smoothing technique.
The concept of structuring element.
Commonly used operation(s) i.e erosion,dilation
Edge detection using Canny filter.
How to convert the color image into grayscale shades.
Performing opening and closing operations
Concept of the morphological gradient.
Know the difference between tophat/whitehat and black hat operations.
Article quality
This article will not only equip the reader with the knowledge of morphological techniques but also assist him/her with applications of these operations using proper code samples and generating their output.
References
N/A.

There are many articles that already exist on this topic such as this one. What makes yours unique?

it will be more of practical approach to real-world problems
On Thu, Dec 9, 2021 at 3:02 AM Louise @.***> wrote:

There are many articles
https://www.google.com/search?client=firefox-b-d&q=Morphological+operations+in+image+processing+using+OpenCV+python
that already exist on this topic such as this one
https://www.pyimagesearch.com/2021/04/28/opencv-morphological-operations/.
What makes yours unique?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/section-engineering-education/engineering-education/issues/5435#issuecomment-989745288,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS2SH4AEYBGEJLIZE6TG3U3UQCEDJANCNFSM5JPUH4CQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Remove redundant throws declarations

I've noticed unused throws declarations multiple times and thought I'd see if they could be removed. This is the result of running IntelliJ's code inspection.
There is an argument to be made that not all of these should be removed because a user could have extended one of the classes and relies on a method throwing a certain exception. Even if that's the case, there's still some throws declarations we can remove, e.g. in tests.

It looks like the automatic checker caught some more unused declared exceptions. Not sure why I didn’t catch these when running ./gradlew check. I’ll investigate.

Won't it change signature in an incompatible way?

It would. I think there’s three categories of methods as far as this change is concerned:

Methods the user can't override. We can safely change all of these.
Methods the user can override.

Those where the user should not override and throw the exception. We can change these in the next major version.
Those where the user is expected to override and throw the exception. We have to keep them.

I don't know if cases 2.i. and 2.ii. actually exist. For now, I can try to take care of case 1.

Those are good points. What if we took a more targeted approach? Maybe we can remove unused throws from the tests as a step in the right direction. I’ve pushed a commit doing that. It’s a large diff, so beware, but I think it’s doing the right thing.

In general I would like to keep all tests with "throws Expection". This makes creating/modifying tests faster. I use a template whenever I create a new test.
So please keep the tests as is. Thanks.

Thanks for the feedback Uwe. I thought changing the tests would be uncontroversial, but it sounds like you have a use-case for those exceptions. I’ll close this PR.


Don't depend on names of game objects

In addition to #45 there are other places where we depend on the names of GameObjects. For example ProfileManager finds all sorts of things like the hands by looking for speicif names (which happened to be correct at some point in the past).
Searching for GameObject.Find should find these. But there may be other things as well.
The correct way to do things like this (if I understand Unity philosophy correctly:-) is to add attributes to the objects like the ProfileManager and connect these objects in the scene or the prefab.

Outdated.


Fetch page object using translated slug.

according to https://voyager-docs.devdojo.com/core-concepts/multilanguage#get-translated-value
i can fetch language of certain page with. $page = Page::where('slug', $slug)->withTranslations(['en'])->get(); but doing the same thing for same page for another language still return the original page values. $page = Page::where('slug', $slug)->withTranslations(['tr'])->get();
am i getting it wrong?

QUESTIONS ABOUT HOW TO USE VOYAGER SHOULD BE ASKED IN SLACK FIRST

If you think it's a bug please provide all information requested in the template and this can be reopened.


Show data editing sql

One feature I really liked in MySQL Workbench was after editing data in a table and clicking apply it showed the SQL that was about to be performed.  Really handy for testing changes on a testing database before applying it to production without having to remember what to do (i.e. collect the sql into a text editor, later open the workbench on the real database, cut and paste the collected sql).

That's a good feature, really useful. And easy to do.
Will be included in the next version.


Add dll path like exe path doing.

Add method to determine the library path is called from. I think it will be helpful for some reasons. Best regards

Am 21. Oktober 2019 um 14:25 Uhr -0700 schrieb Nightmare0:

Add method to determine the library path is called from. I think it
will be helpful for some reasons. Best regards

I'm sorry, I don't understand. What do you mean? Can you give an example
of what you would like Pathie to do?
--
Blog: https://mg.guelker.eu

Am 21. Oktober 2019 um 14:25 Uhr -0700 schrieb Nightmare0:
Add method to determine the library path is called from. I think it will be helpful for some reasons. Best regards
I'm sorry, I don't understand. What do you mean? Can you give an example of what you would like Pathie to do?
…
-- Blog: https://mg.guelker.eu
Pathie::Path exepath    = Pathie::Path::exe();`
This is determination exe path file way, so if i called something from dynamic link library or shared object, i have no methods to determine library path instead of exe path, hmm..

Pathie::Path exepath    = Pathie::Path::library_path();

Am 31. Oktober 2019 um 23:21 Uhr -0700 schrieb Nightmare0:

This is determination exe path file way, so if i called something from
dynamic link library or shared object, i have no methods to determine
library path instead of exe path, hmm..

So, you want to determine the path to the shared object library Pathie
was loaded from? You are right, this is currently not possible with
Pathie.
I have conducted some research and it looks as if this is possible,
but not straightforward. On Linux, one has to open the object with
dlopen(3) and then look up the path information with dlinfo(3),
whereas on Windows, one opens the DLL with LoadLibraryW() and then
extracts the path name with GetModuleFileNameW().
However, there's a problem. In both cases it is assumed that the
library you want information about has not yet been loaded. Pathie
however has been loaded when you call this hypothetical new
function. Pathie also does not even have a way to determine the
relative file name it has been loaded from.
I have no idea how to retrieve a pointer suitable for either dlinfo(3)
or GetModuleFileNameW() for an already loaded executable. In addition,
pathie may have been statically linked, in which case there is no use
for this hypothetical new function. All that would be possible is to
provide a function that takes an OS-specific pointer which is then
forwarded to dlinfo()/GetMOduleFileNameW(), but that kind of defeats
the purpose of a cross-platform library like Pathie.
This chicken-egg problem makes me think that the function you request
is out of scope for Pathie. Pathie cannot know how it has been loaded
into the executable -- statically linked, dynamically linked, or
linked at runtime with dlopen/LoadLibrary. If you depend on this
information, use your OS' facilities. Load pathie with dlopen(3)
(Linux) or LoadLibrary() (Win32) and then use the functions provided
by the system to retrieve the path information.
--
Blog: https://mg.guelker.eu

Closing for the reasons given.


[Easy] Don't enumerate momentProperties with 'in'

Because of the way many polyfill libraries modify Array.prototype (without Object.defineProperty), enumerating momentProperties with for...in is unsafe.
This is a near zero-cost change that makes this enumeration safe.

This seems good.
Two nits:

Do we need the if statement in the line above?
Do folks prefer i++ or ++i? Are there other examples in the project?

I'm in the i++ camp personally.

@marwahaha
billschaller$ grep -R "++" src/* | grep -oE "\w*\+\+\w*" | sed 's/[^+]\{1,\}/i/g' | sort | uniq -c
  39 ++i
 738 i++

We don't need the if statement, no, but it's probably cheaper to do a zero comparison than initialize the iteration. Chrome will optimize that out anyway. 20 or so characters worth of bloat? ¯_(ツ)_/¯

Merged in a77dc0eb41e949d0e46c449055cfcf28ce6ca059


start and end for Slot should be an instant, not a string

FHIR specification for Slot: https://www.hl7.org/fhir/slot.html
start and end should be an an instant: https://www.hl7.org/fhir/datatypes.html#instant — "An instant in time in the format YYYY-MM-DDThh:mm:ss.sss+zz:zz (e.g. 2015-02-07T13:28:17.239+02:00 or 2017-01-01T00:00:00Z)" and with the regex ([0-9]([0-9]([0-9][1-9]|[1-9]0)|[1-9]00)|[1-9]000)-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])T([01][0-9]|2[0-3]):[0-5][0-9]:([0-5][0-9]|60)(\.[0-9]+)?(Z|(\+|-)((0[0-9]|1[0-3]):[0-5][0-9]|14:00))
When I create a Slot with a start that is a string, e.g. "example", I do not get an error, but I believe I should get an error for not matching the required format. In the TypeScript definition it is a start?: string. This might be related to #857.

Hi @saewitz - as of https://github.com/medplum/medplum/pull/960 all new projects are in "strict mode", which will catch this error.
{
  "resourceType":"OperationOutcome",
  "id":"0786708a-343e-4f51-90b4-7345ba817c61",
  "issue":[
    {
      "severity":"error",
      "code":"structure",
      "details":{
        "text":"Invalid instant format"
      },
      "expression":[
        "Slot.start"
      ]
    }
  ]
}

Please let us know if you'd like to modify an existing project to use strict mode<EMAIL_ADDRESS>Thank you!


Support for SingularityDeploy DeployHealthTimeoutSeconds.

Codecov Report

Merging #346 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #346      +/-   ##
=========================================
- Coverage   61.56%   61.5%   -0.07%
=========================================
  Files         162     162
  Lines        8737    8738       +1
=========================================
- Hits         5379    5374       -5
- Misses       2922    2926       +4
- Partials      436     438       +2

Impacted Files
Coverage Δ

ext/singularity/recti-agent.go
42.85% <100%> (+0.37%)
:white_check_mark:

lib/auto_resolver.go
88.05% <0%> (-1.5%)
:x:

ext/docker/image_mapping.go
72.6% <0%> (-0.92%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f7dba...2ccf050. Read the comment docs.


Filter stock by part and location

In stock view page, allow filtering by the location (already done) AND the part.
e.g. show all 2K2 resistor stock in location "Work/Office2"

Should also be able to filter stock items on whether they belong to a given part's BOM. Other filter ideas should be considered.
Should be able to combine filters

Stock items can now be filtered by:

Part
Location
Category
Supplier Part


Set x-ms-app HTTP request header in Monitor Query library

Library name
@azure/monitor-query
Please describe the feature.
The Azure Monitor Log Analytics service team stores the caller information for their REST APIs. To support tracking HTTP requests from the Azure Monitor Query library, send an x-ms-app request header. The header's value should be set to AzureMonitorQuerySDK. The metrics team uses the user agent to identify the caller. Send this header ONLY for logs queries.

After reviewing with the arch board, a decision was made to not make this change. As a workaround, the Draft service team can run a contains operation on the user agent string to identify the caller. This workaround has been communicated to Dan Hadari.


Add Hooks for Dataloader Beginning and End

Description & Motivation
I have a task with multiple test datasets and I want to compute metrics individually per dataset. This requires me to take a custom action when the dataset ends. It would be great to have built-in hooks in lightning to enable this and it already fits in with the overall philosophy of the lightningmodule processing hooks enabling actions at specific points in the loop.
Pitch
I propose adding two new hooks for validation/test/prediction (training is probably not applicable here but we can discuss if it is). This would be the on_dataloader_start and on_dataloader_end hooks. They would be called as follows:
on_X_epoch_start
on_X_dataloader_start ---------------|
on_X_batch_start   -| batch loop  | dataloader loop
on_X_batch_end    -|                       |
on_X_dataloader_end-----------------|
on_X_epoch_end
There would also need to be an update to allow metric logging in this manner because currently lightning throws an exception if the same key is logged "with different metadata" (I forget the exact text of the exception)
Alternatives
I currently provide a subset of this functionality (the *_dataloader_end hooks) using the following callback:
from typing import Any

from lightning.pytorch import Callback, LightningModule, Trainer

class MultiloaderNotifier(Callback):
    def __init__(self) -> None:
        self.dataloader_idxs = {"validation": 0, "test": 0, "predict": 0}

    def on_batch_start(self, stage: str, pl_module: LightningModule, dataloader_idx: int) -> None:
        if dataloader_idx != self.dataloader_idxs[stage]:
            if hook := getattr(pl_module, f"on_{stage}_dataloader_end", None):
                hook(self.dataloader_idxs[stage])
        self.dataloader_idxs[stage] = dataloader_idx

    def on_epoch_end(self, stage: str, pl_module: LightningModule) -> None:
        if hook := getattr(pl_module, f"on_{stage}_dataloader_end", None):
            hook(self.dataloader_idxs[stage])
        self.dataloader_idxs[stage] = 0

    def on_validation_batch_start(self, trainer: Trainer, pl_module: LightningModule, batch: Any, batch_idx: int, dataloader_idx: int = 0) -> None:
        self.on_batch_start("validation", pl_module, dataloader_idx)

    def on_validation_epoch_end(self, trainer: Trainer, pl_module: LightningModule) -> None:
        self.on_epoch_end("validation", pl_module)

    def on_test_batch_start(self, trainer: Trainer, pl_module: LightningModule, batch: Any, batch_idx: int, dataloader_idx: int = 0) -> None:
        self.on_batch_start("test", pl_module, dataloader_idx)

    def on_test_epoch_end(self, trainer: Trainer, pl_module: LightningModule) -> None:
        self.on_epoch_end("test", pl_module)

    def on_predict_batch_start(self, trainer: Trainer, pl_module: LightningModule, batch: Any, batch_idx: int, dataloader_idx: int = 0) -> None:
        self.on_batch_start("predict", pl_module, dataloader_idx)

    def on_predict_epoch_end(self, trainer: Trainer, pl_module: LightningModule) -> None:
        self.on_epoch_end("predict", pl_module)

which allows me to hook with
def on_test_dataloader_end(self, dataloader_idx: int) -> None:
        self.logger.log_metric(self.metric.compute())
        self.metric.reset()

However this has a number of drawbacks. First, the hooks are not necessarily called in the right order since I need to hook batch_start from the callback in order to detect the change in dataloader (so batch_start -> dataloader_end is not conceptually correct). Next, I need to hook epoch_end to make the last dataloader_end call (epoch_end -> dataloader_end is also not conceptually correct). Lastly there is no obvious way to do both dataloader_start and dataloader_end, I don't need them both but someone else might.
There is also the issue of the logging itself. Currently, to avoid the exception, I need to bypass the lightningmodule log function and call log_metric on the logger.
Additional context
No response
cc @borda @justusschock @awaelchli @carmocca @Blaizzy

I believe this is also related to #18282. We should look into how these limitations can be addressed so it is easier to work with dataloader boundaries when using multiple.

Yeah it's related, but I think there are some good reasons for not resetting metrics between dataloaders, or at least making it configurable; it depends on the use case

Hi,
(Sorry for the very late reply :/)
I do not think that there's a very good reason for not resetting in-between several dataloaders, as we can create a ConcatDataset instance from multiple Dataset instances.
Unless there's a use case, I've missed?

Any update? @awaelchli @carmocca

I've done a little bit of digging, and basically the issue happens in _EvaluationLoop.run()
 @_no_grad_context
    def run(self) -> List[_OUT_DICT]:
        self.setup_data()
        if self.skip:
            return []
        self.reset()
        self.on_run_start()
        data_fetcher = self._data_fetcher
        assert data_fetcher is not None
        previous_dataloader_idx = 0
        while True:
            try:
                if isinstance(data_fetcher, _DataLoaderIterDataFetcher):
                    dataloader_iter = next(data_fetcher)
                    # hook's batch_idx and dataloader_idx arguments correctness cannot be guaranteed in this setting
                    batch = data_fetcher._batch
                    batch_idx = data_fetcher._batch_idx
                    dataloader_idx = data_fetcher._dataloader_idx
                else:
                    dataloader_iter = None
                    batch, batch_idx, dataloader_idx = next(data_fetcher)
                if previous_dataloader_idx != dataloader_idx:
                    # the dataloader has changed, notify the logger connector
                    # START
                    self._store_dataloader_outputs()
                    # END
                    # For all the dataloaders but the last one, the metrics, for which we have a reference
                    # are getting computed, but not they do not get reset.
                previous_dataloader_idx = dataloader_idx
                self.batch_progress.is_last_batch = data_fetcher.done
                # run step hooks
                self._evaluation_step(batch, batch_idx, dataloader_idx, dataloader_iter)
            except StopIteration:
                # this needs to wrap the `*_step` call too (not just `next`) for `dataloader_iter` support
                break
            finally:
                self._restarting = False
        # START
        self._store_dataloader_outputs()
        return self.on_run_end()
        # END
        # For the last dataloader, the metrics are computed, and then finally reset in the `self.on_run_end()`

I think that this does not make much sense, even in the event where we would be having several metric objects.
Because the retaining the metric states after they get computed is just retaining resources that would get freed otherwise.
I took the example of the MeanAveragePrecision in #18282 because if we were to compute it on instance masks, they all have to be retained on the CPU, which could be very expensive if the number of dataloaders and samples would grow large.