Update dependencies and fix Windows compatibility on Python 3.12

This is a new version of the python-pkcs11 package.

Updated to PKCS#11 Specification Version 3.1, published by OASIS Standard on 2023-07-23.
Updated setup.py to support the new standards by setuptools based on pyproject.toml.
Added pyproject.toml to centralize the metadata of the package.
Removed deprecated references to Py_UNICODE* and replaced them by wchar_t as suggested by PEP-624.
Added compatibility to Python 3.12 in Windows.
Updated requirements version.
Bump package version to 0.8.0.

The package has been tested on new virtual environments using Python 3.12 on Windows 11 with the asepkcs.dll (Athena Smartcard System ASE Card).

Hi,
pyproject.toml has since been introduced in the main branch and also includes dependencies. setup.py is already minimalized.
For this PR to be merged, please rebase it. I think dependabot configuration would also need an update to check pyproject.toml.
Kr, Mat


make rpm failed due to lack of npm command in noobaa-builder container image

Environment info

NooBaa Version: 5.15.0
Platform: AlmaLinux 8.8 on  ppc64le platform

Actual behavior
docker build   --build-arg BUILD_S3SELECT=1 --build-arg BUILD_S3SELECT_PARQUET=0 -f src/deploy/NVA_build/Base.Dockerfile   -t noobaa-base .
Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
STEP 1/19: FROM noobaa-builder
STEP 2/19: COPY ./package*.json ./
--> Using cache aabfd53fc37e9838d0ff1584668f7a334b7dfd921977e7724f0ad20d9ba14fff
--> aabfd53fc37
STEP 3/19: RUN npm install --production &&     npm cache clean --force
/bin/sh: npm: command not found
Error: building at STEP "RUN npm install --production &&     npm cache clean --force": while running runtime: exit status 127
make: *** [Makefile:137: base] Error 127
Expected behavior
make rpm successfully
Steps to reproduce
git clone https://github.com/noobaa/noobaa-core.git
cd noobaa-core
make rpm
More information - Screenshots / Logs / Other output

@tangledbytes can you please take a look ?

Hi @xcnix! I tried running the command on NooBaa master branch and it seems to be running just fine. It could be that npm download failed in one of the previous steps and now that cached image is being used. To eliminate this possibility, can you please once try purging the Docker cache (if not purge just make sure that NooBaa related caches are deleted) and then try building again?

Thanks.


remove unnecessary code

The TODO item will be retrieved by _todos.TryRemove method, so no need call _todos.TryGetValue first.

Hi @xing-zheng, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Thanks for the update. I just did a major update of this tutorial and that's one thing I fixed.


(MODULES-8232) Unset functionality for syslog_settings

Codecov Report

Merging #97 into puppet6 will decrease coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           puppet6     #97      +/-   ##
==========================================
- Coverage     5.59%   5.58%   -0.01%
==========================================
  Files          174     174
  Lines        20603   20603
==========================================
- Hits          1152    1151       -1
- Misses       19451   19452       +1

Impacted Files
Coverage Δ

lib/puppet/provider/syslog_settings/cisco_nexus.rb
98.61% <75%> (-1.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9ed5e...cfb5dfb. Read the comment docs.

@Thomas-Franklin This should be ready for merge?


The Persistance example does not work...

Hello,
I've just started looking at using DocType for my project but ran into some errors.
I then just copy/pasted to a file the persistance example from the readme file and obtained the same results when I ran it...
The output I got was:
Nicolass-MacBook-Pro: Nicolas$ python testing_doc_type.py
Traceback (most recent call last):
  File "testing_doc_type.py", line 6, in <module>
    connections.add_connection(Elasticsearch())
AttributeError: 'module' object has no attribute 'add_connection'

I tried modifying the connections line so as to read:
connections.connections.add_connection(Elasticsearch())

But that resulted in the following error:
Nicolass-MacBook-Pro: Nicolas$ python testing_doc_type.py
Traceback (most recent call last):
  File "testing_doc_type.py", line 6, in <module>
    connections.connections.add_connection(Elasticsearch())
TypeError: add_connection() missing 1 required positional argument: 'conn'

Looking at the Connections class, I am not sur what I should put in as "alias" (since Elasticsearch() should be "conn", right?).
I'm probably missing something basic here... Any help (and update to the readme file) would be greatly appreciated!
Nicolas
Using Python 3.3, elasticsearch-py 1.3.0, elasticsearch-dsl-py 0.0.3

Playing around with it: I tried adding a string to serve as alias. I put in "alias1".
That threw:
KeyError: "There is no connection with alias 'default'."

I then changed "alias1" to "default", and then the file would run.


Add feature to use AlignedVec over Vec for eventual consistency API.

Currently, we use unaligned Vec<u8> buffers for Documents, while this is fine... We would be better off using the AlignedVec as it allows for greater usage with rkyv and it's zero-copy system.

After some discussion this actually might require a slightly smarter design, since doing this in a naive way would force another allocation when realistically we can actually remove an allocation using a DataView.


[DC-388] Invalid foreign keys will be nulled out and the remainder of the row persists.

Adds a rule (cleaning_rule_1) which generates queries to nullify invalid foreign keys.

thoughts

well I used it so that it will be easy to debug when we get a query formatted in logs, but if it makes the api call leaner, i would probably switch back.

The code base uses this block quotes for SQL a lot.  This might be something we should talk about.  The pros and cons of the SQL block string vs the SQL concatenated string.  The block string does make it more human readable in the logs...


Ms/340 come up with a working solution for version history

Simple implementation of first tests to see if the scenario we want to achieve is possible with django-simple-history:

we should have a possibility to create new versions of data (eg a new published version of APIS data)
from a given version of an entity we need a simple path to the correct versions of the related entities
we want to add further data to the "version" eg a version tag and/or a comment what was changed

fixes #340

so far provides:

a VersionMixin that can be used in the models to turn on versioning
a API endpoint that serializes all the versions for a given entity_type & pk (including diffs)
unittests (using the OEBL ontology) that test basic functionality

still missing:

API endpoint should also return changed/added relations
Admin integration
templatetags for:
- showing a track change
- adding a version tag to given version
- merging several changes into one version
- undo changes
list of diffs should provide a proper serialization of m2m relations. Currently its a simple array of the through table

superseded by #698


killPort() tweaks

thanks for the cool project! i saw it pop up in my feed the other day and i was taking a look at the code since i'm learning go. i'm sorry if my changes don't make sense. the updates are to return early from killPort() if the string to int conversion fails and to assign and check the error returned from syscall.Kill()

@all-contributors please add @bfgray3 for code


Moving library content does not deselect the content after move

Click into Main English Collection
Click into Arts, then Art Activities
Let’s move some stuff! Select 2-3 items to move into the main “Arts” folder
Click on the 3-dot icon next to one of the resources you selected, then click “move selected”
Move into Arts folder
Select 2-3 more items from within Art Activities (don’t click out of Art Activities)
Click on 3-dot icon to “move selected” items - notice that the other items you just moved are still on that list!
If I want to move more things into another folder from within the “Art Activities” folder, I have to click out of the folder, then click back in.
1. If I don’t do this option, then it will show that I’m moving the three items I moved previously, along with the new items I want to move.
If things are being moved all to the same place it should be fine, but I’ve noticed that sometimes this leads to items duplicating in random folders/the wrong folders….

Fixed with branch update


Game crashed after updated Libvulpes

Version of Advanced Rocketry
1.7.10-1.4.0-11
Have you verified this is an issue in the latest unstable build
Y
Version of LibVulpes
1.7.10-0.2.8-32
Version of Minecraft
1.7.10
Crash report or log (if applicable)
https://pastebin.com/m6Xuw5z2
Description of the problem
After updated Libvulpes game crashed when entering world.

Gregtech ore support was added in AdvancedRocktry-1.4.0-12, this required an update to libvulpes as well, it looks like you've updated libvulpes but not advanced rocketry.
You should be able to fix this by downgrading to an older version of libvulpes or AdvancedRocktry-1.4.0-12 or newer

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


How to Build JavaScript Libraries from Source?

Is there a way to build the JS mediapipe libraries from source?  Is the source in a separate repo?  I can't find anything related to the JS build in this repo.

Hi @rvadhavk, You can use our codepen examples or can use our ready built solutions  using npm from here https://google.github.io/mediapipe/getting_started/javascript#ready-to-use-javascript-solutions

@sgowroji so to confirm, the JavaScript libraries are not open source?  Users have to rely on pre-built, minified packages?


Expire when directly submit form after coming back

Laravel Caffeine refreshes the CRSF token every drip-interval and refreshes the whole page when the session almost expires; outdated-drip-check-interval before. But... when I open the Laravel application, close my Macbook and go to sleep. The next morning I open my laptop and I'm trying to submit the form I'm getting the expired page. Maybe we can check on window focus and refresh the token? See: https://stackoverflow.com/questions/3478654/is-there-a-browser-event-for-the-window-getting-focus
If this is a good idea I could create a PR for this, but first I'd like to discuss this if it's a good of bad idea.

I would love a PR for this, if there is a way to elegantly handle the timeouts. I could see redirecting to the login page if the drip encounters a timed-out session.

Perhaps you could use something like this: https://github.com/ai/visibilityjs
Which will trigger events also when returning from a background tab etc. Not sure if that fits your case (or a global case), but might help.

But what are we going to do when we get the focus event? Reload isn't wanted but needed in my use case, when we just switch tabs the page will reload in that case.

If the drip is not run in that interval (because of inactivity), you will need to redirect to the login page always, because the session is already expired.

@barryvdh Thanks for the suggestion, I will take a look at that. :)
@royduin I think that kind of logic does beyond what I envisioned for this package. I think we should take it step-by-step and first just handle timed-out sessions.
I guess an option would be to show the login page in a popup, and then close the popup once logged in? That could provide the ability to preserve form data as we don't refresh or reload the timed-out page.
What is the user-flow you are proposing, @royduin ?

@royduin  Unless something changed, the CSRF should expire with the session. It is also recommended to keep the session lifetime as short as reasonable possible, to prevent abuse. I'm not completely clear on your exact use-case, but it sounds like there may be other issues and functionality involved that goes beyond what this package is intended to do?
The only purpose of this package is to extend the session for long forms, so that they don't time out. Additional functionality like page reloads, etc. is not what this was meant for. Since I'm still unclear as to exactly what it is you're trying to achieve, could you list out each step of the user flow for me?
Sorry for all the additional inquiry, but unless I understand the problem, I can't be very helpful in working toward a solution. My current understand of the problem is this:

User shops on your site, adds things to shopping-cart.
The user doesn't follow through before the session times out.
The shopping cart content is lost.

Does that sum it up correctly?  Is the shopping cart in the same domain as your site (not in a sub-domain or other cookie domain)? There are so many factors that can contribute to sessions timing out, it's almost impossible to debug like this.
I think it would be helpful first to identify why your cart session is timing out (CSRF token is the same as the session, unless you are doing something differently), and fix that issue first. After that, it would be feasible that this package would work for you.

Thanks for helping out @mikebronner; it's just a Laravel web applications where users can login. Having the login page open, close your laptop and open it the next morning and try to login results in a csrf token expiration / session timeout. To reproduce;

laravel new caffeinetest
Setup a database and change the credentials in the .env
Change SESSION_LIFETIME  to 1440 in the .env
php artisan migrate
php artisan make:auth
composer require genealabs/laravel-caffeine
Open /login in a browser and close your laptop
Go to sleep
Wake up, open your laptop and login directly

This may be addressed with in the latest version. Closing for now.


Moderate content in embeds

Normal Post

Adult Content

Adult content in quote only

Adult content in both original post and quote

Just in the OP

Author avatar blurred

External embed

this eslint config or something is cursed for me. just be sure to squash commits please 🙏

Also, the graphic-media came from the app codebase. Not familiar with that one, but I'm guessing this is after moderation updates?


Add a feedback form to reference pages

Increasing Access
The website currently directs visitors to GitHub if they'd like to provide feedback. This approach isn't accessible for people without GitHub accounts, especially K–12 students.
Most appropriate sub-area of p5.js?
Reference
Feature request details
@limzykenneth @davepagurek @Qianqianye I think it would be helpful to link to a minimal feedback form at the bottom of reference pages. The form could be owned by a @p5js.org Google account and responses could be shared with documentation contributors. What do y'all think?

Thanks @nickmcintyre for the suggestion.
I agree that using Google form would be easier for a lot of users, like K12 students. However, we have been having hard time maintaining and checking response updates of Google forms historically. During the transition of old and new contributors, we often find the responses left neglected and information scattered on GitHub and Google forms.
It'd be great if we could come up with a systems that gather information at a centralized location, like GitHub. How about a solution like this one: Create a new GitHub Issue from a Google Form submission?

That's a good suggestion @Qianqianye! We could set that up and see how it works. Hopefully it gives us more high quality feedback; if we start getting a lot of bot spam we can always update the form to e.g. require an email or something.

Thanks @Qianqianye and @davepagurek! Good suggestion to integrate the Google form into our existing workflow. I'll tinker with an example and will let you know how it goes.

This approach works well! I used a test repository and an access token that was limited to read/write issues in that repository. Here's an updated version of the script that executes on form submissions:
const ghToken = "github_pat_abc123";

function onFormSubmit(e) {

  const title = `Reference feedback: ${e.values[1]}`;

  const body = `

Reference Page

${e.values[1]}

Problem Description

${e.values[2]}

Focus Area

${e.values[3]}

Suggested Fix

${e.values[4]}

  `;

  const payload = {
    "title": title,
    "body": body
  };

  const options = {
    "method": "POST",
    "headers": {
      "authorization": `token ${ghToken}`,
      "Accept": "application/vnd.github.v3+json",
    },
    "contentType": "application/json",
    "payload": JSON.stringify(payload)
  };

  const response = UrlFetchApp.fetch("https://api.github.com/repos/processing/p5.js/issues", options);
}

I opted to leave information about learning environment in the spreadsheet for later review.
Happy to revise the form and issue template. Once we have workable versions, how/where should we integrate the form into the website?

One thing about using a Google Form to open a GitHub issue is that it could possibly make follow up difficult, with Github Issues mostly be filling in a form already, going through Google Form to do the same thing feels a bit redundant, although I get the point about having a GitHub account may not be feasible for some as well.
I think one of the major value, especially for education, in opening a GitHub issue and contributing on GitHub is the possibility of community engagement and feedback. Having just a place that seemingly send queries into the ether isn't ideal in my opinion, it also makes further follow up questions we may have difficult to get answer to (eg. asking to clarify problems faced in the issue).
Are other avenues such as the Processing forum or Discord be possible places to direct people to instead of GitHub? It can also possibly be prefilled new posts relating to the specific reference entry when clicked on the relevant link so most of the info is prefilled?

@limzykenneth issues submitted using this approach are anonymous by design, so follow up would be impossible. It would be up to contributors to act on feedback. The general idea is that a twelve year-old can easily point out documentation that isn't clear to them. They won't necessarily know how to revise it, but they can tell us where to focus.
In the US, K–12 students will have a hard/impossible time joining GitHub as part of class due to helpful legal safeguards. The same goes for Discourse and Discord. Anecdotally, my old school district's IT department wouldn't have approved using any of these services for class.
I'm working with a community member in the NYC Department of Education to help direct students to the p5.js website in an organic way. That's taken the form of a set of coding challenges that require a bit of research and a friendly request to contribute feedback. Gotta bootstrap the process somehow. It's very much an experiment, but a simple form seems likely to cause the least amount of friction for everyone.


WAR publishing description seems invalid

[ ] I've read the CONTRIBUTING guidelines

steps
Add sample code mentioned in the documentation to build.sbt
https://www.scala-sbt.org/1.x/docs/Artifacts.html
// disable .jar publishing
publishArtifact in (Compile, packageBin) := false

// create an Artifact for publishing the .war file
artifact in (Compile, packageWar) := {
  val previous: Artifact = (artifact in (Compile, packageWar)).value
  previous.withType("war").withExtension("war")
}

// add the .war file to what gets published
addArtifact(artifact in (Compile, packageWar), packageWar)

problem
The code doesn't compile.
expectation

Documented snippet should compile.
There should be support for building WAR packages.

notes
sbt version: 1.2.7

Thanks for the report!

Still not fixed. It would simply compile if you add:
      val packageWar = taskKey[File]("package-war")       packageWar := {         val warFile = name.value + "-" + version.value + ".war"         (baseDirectory in Compile).value / "target" / warFile       }


Can't change font

Hi, I've created STYLES.md page in the root of my SB space:
```css
#sb-root {
   --editor-font: "Roboto" !important;
}
```

However, it changes nothing. Still some monospace font used

Needed to add
customStyles: "[[STYLES]]"
in settings.md
However  like seems Roboto is not supported )))

Changing size not working also:
```css
#sb-main {
   font-size: 16px !important;
}
```

Any solution so far?

Same on my side, I have the settings entry in.
Roboto works for me when I overwrite the CSS in debug, but it appears that the variable from STYLES is ignored.

Do you have
customStyles: "[[STYLES]]"

In your SETTINGS, like here? https://silverbullet.md/SETTINGS

roboto font simply not supported. When i set Arial - it is working.
But font size not working at all


Derive XREF_OFFSET_D3DDEVICE_M_VERTEXSHADER

Derive XREF_OFFSET_D3DDEVICE_M_VERTEXSHADER (needs offset verification), and register it's address as "D3DDevice__m_VertexShader" (required for VertexShader unpatching in Cxbx-Reloaded)

Respectfully, I don't plan on fix rebase on top of this change for API v3.0's #94 pull request. My suggestion is to split into 2 pull requests on top of API v3.0, #94 pull request.

@RadWolfie Ofcourse it's possible to base those PR on something else, like the branch you mention.
You'll have to forgive me not noticing what you point at. It's 3 months old work - what's the current state?

You'll have to forgive me not noticing what you point at. It's 3 months old work - what's the current state?

Has been functional, just need to finalize the API's names and/or update the parameters for worthy options to have.

Base on offset's location from 3911's signature and later. Standard D3D8's m_VertexShader are correct since they are at same offset location as in the signatures' database.
However, most of LTCG's m_VertexShader offsets are incorrect. Here's what I have discover by comparing title with 3925, standard D3D8's signatures, and D3D8LTCG's signatures.
D3DDevice_SetVertexShader_0 (LTCG)

3911

0x0D = XREF_OFFSET_D3DDEVICE_M_VERTEXSHADER (confirmed)

4039

0x12 = XREF_OFFSET_D3DDEVICE_M_VERTEXSHADER (unverified, yet should be align base on existing 4 bytes in signatures)

4432

0x13 = XREF_OFFSET_D3DDEVICE_M_VERTEXSHADER (OK, yet unverified)

5233

0x0E = XREF_OFFSET_D3DDEVICE_M_VERTEXSHADER (unverified, yet should be align base on existing 4 bytes in signatures)

The "existing 4 bytes in signatures" are 0x55, 0x56, 0x8B, and 0x35 (in order). These 4 bytes are align to where XREF_PD3DDEVICE is located. After this is where the member of vertex shader offset assembly command can be found.

@RadWolfie Did you verify the 5455 (non-LTCG) offset too? (It's marked with a TODO, see https://github.com/Cxbx-Reloaded/XbSymbolDatabase/blob/d605698eddd3086e627b7053d99e193d47538b36/OOVPADatabase/D3D8/5455.inl#L110 )

Yes, even 5455 (non-LTCG) is correct too.


ci: Benchmark CI Step

This PR adds a new benchmark step that runs for every pull request and compares the PR performance against main. The action writes a comment (or updates an existing one) with the results.

@Boshen It's not fully functional yet nor have I tested the caching but I think you could find some of it interesting ;)

Okay, caching is a bad idea because github runners differ too much

This is great! Two quick comments since I was working recently on the ecosystem CI check which also comments on the PR:

It would probably make sense to combine the commenting piece of this workflow with ecosystem-comment.yaml (and probably rename it to e.g. pr-comment.yaml). That way there will be a single comment rather than two which would probably make for less noise, and also the separate workflow means that the PR comment can also work for PRs from forks of this repo (which is basically every PR except yours and @charliermarsh's 😄)
I'm not sure what artifacts cargo bench requires, but assuming it only needs the debug binary, you could use the artifacts that are now uploaded by the cargo test step. That would save on the re-build time (at least for the main branch), and means that the benchmark only runs if the remaining tests pass.

Very clever approaches for speeding up CI times!
I wonder if we can also build the binary on main and then just download it on the PR 🤔
Uploading the binary from the test step doesn't work I think, it it seems to be uploading a debug build? path: target/debug/ruff.

This is great! Two quick comments since I was working recently on the https://github.com/charliermarsh/ruff/issues/2677 which also comments on the PR:

Thanks for that work. I used your job as inspiration on how we can improve the benchmarking, and it seems there's more for me to learn :smiley:

Comments: That's clever. Let me give this a try.
Re-using the binary: The benchmark uses the release build of ruff_benchmark which we aren't building as part of the pull_request workflow. However, we could do something good for the environment (it won't speed up the overall time) and build the binary for main once and then re-use when running the baseline benchmarks on PRs.

I wonder if we can also build the binary on main and then just download it on the PR thinking

Yes, I'll give that a try

Very clever approaches for speeding up CI times! Thank you @MichaReiser, I stole this faster than you could merge this PR ;-)

:laughing:  Thank you! I saw your PR yesterday and was, wow, that was quick. I should update the PR summary to make it clear that this workflow is heavily inspired by your work on Rome's and OXC's benchmarks!

I implemented the recommended changes.
I haven't been able to test the caching because it requires triggering a build on main.... which I can only do after this PR lands.

Current dependencies on/for this PR:

main

PR #3480   👈

This comment was auto-generated by Graphite.


Reorganize versions, publish 1.0 supported version on npm

The most current version of markercluster on npm is from two years ago, has version number 0.4.0.
It doesn't support Leaflet 1.0 and ends in a cryptic messages of Trim not supported on undefined. This is the root cause of https://github.com/Leaflet/Leaflet/issues/4422 which no one knew why is happening. (and also https://github.com/Leaflet/Leaflet/issues/2408)
The readme says user should use bower, yet bower is discouraged by current Leaflet recommendations.
The 1.0 supporting master is still on 0.4.0 version number, just like the old 0.7 build.
The 0.7 branch is on 0.5.0 version (!), which is also what you get on bower.
brainmelt :-(

We should discuss how to handle markercluster, since it's an official repo and has 1400+ stars.
As a temp workaround I published a "built" branch, so users can just use:
"leaflet.markercluster": "hyperknot/Leaflet.markercluster#built"

in their package.json to support Leaflet 1.0. Ideally something like this should be pushed on npm with version number 0.6.0 or something.
@mourner @perliedman @IvanSanchez @yohanboniface What do you think we should do?

I'd say let's publish a 1.0.0-rc1 to follow Leaflet. I'm doing that with Leaflet.Editable over the week-end.

I've pushed up 0.5.0 to npm (final 0.7 compatible release).
Doing the other bits now too ^^

[ ] Update version number
[ ] Create a 1.0.0-rc.1 tag (with built js)
[ ] npm publish 1.0.0-rc.1

I'm not sure we should be matching leaflet version numbers, as when we change things we will want to bump our version number, and then we won't line up.
But will go with it for now.

Ok, should be able to npm install this tag using:
npm install<EMAIL_ADDRESS>
(extra .0 because I published the .1 which updated the latest tag, which was bad, so I unpublished that version but you can't reuse version numbers...)

Ok, think this is all done now :)

Excellent, thanks @danzel :)

I'm not sure we should be matching leaflet version numbers, as when we change things we will want to bump our version number, and then we won't line up.

Agreed!
But I think bumping to 1.0.0 make sense for this long used plugin :)
But then I agree plugins should not follow leaflet version number.

Also in a way the increase represents a breaking change within the lineup
of releases, which is justified by a semantic versioning approach.
On 26 April 2016 at 07:53, Yohan Boniface<EMAIL_ADDRESS>wrote:

Excellent, thanks @danzel https://github.com/danzel :)
I'm not sure we should be matching leaflet version numbers, as when we
change things we will want to bump our version number, and then we won't
line up.
Agreed!
But I think bumping to 1.0.0 make sense for this long used plugin :)
But then I agree plugins should not follow leaflet version number.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/Leaflet/Leaflet.markercluster/issues/666#issuecomment-214623172


Issue using Import-AzSentinelAlertRule

Not sure if this is an error with this code or with the way the default queries are written in the Azure Sentinel GitHub repository.
I tried to use Import-AzureSentinelAlertRule going against the exchange_auditlogdisabled.yaml rule stored in the Detections/OfficeActivity folder in the Azure Sentinel GitHub repository (copied locally of course) and received the following error:
Import-AzSentinelAlertRule : Unable to initiate class with error: Exception setting "TriggerOperator": "Cannot convert value "gt" to type "TriggerOperator". Error: "Unable to match the identifier name gt to a valid enumerator name. Specify one of the following enumerator names and try again:
GreaterThan, FewerThan, EqualTo, NotEqualTo""
At line:1 char:1

Import-AzSentinelAlertRule -WorkspaceName "LA-Sentinel-Beta" -Setting ...

CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Import-AzSentinelAlertRule

ConvertFrom-Json : Conversion from JSON failed with error: Unexpected character encountered while parsing value: R. Path '', line 0, position 0.
At C:\Users\garyb\OneDrive\Documents\PowerShell\Modules\AzSentinel\0.6.1\AzSentinel.psm1:790 char:52

...               $errorResult = ($errorReturn | ConvertFrom-Json ).error                                             +                                                  ~~~~~~~~~~~~~~~~                                                     + CategoryInfo          : NotSpecified: (:) [ConvertFrom-Json], ArgumentException                                       + FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.Commands.ConvertFromJsonCommand

Even after fixing that issue I then get another issue with the way the Timespan is stored.

hi @garybushey , this is a known issue and it's caused because the yaml files use the value "gt" and it should be "GreaterThan". The value "gt" is not a supported value. please update the "TriggerOperator" value to "GreaterThan" and you are good to go.

this issue will be fixed in the new version which will be release in the upcoming days

this is solved in version 0.6.2 which is currently available in the PowerShell gallery

Hi @pkhabazi
I am trying to import multiple rules with Import-AzSentinelAlertRule -WorkspaceName #### -SettingsFile .\Rules.json. However I am receiving this error :
Import-AzSentinelAlertRule: Unable to initiate class with error: You cannot call a method on a null-valued expression.
Here is the json format for Rules.json
{
    "analytics": [
        {
            "displayName": "string",
            "description": "string",
            "severity": "High",
            "enabled": true,
            "query": "SecurityEvent | where EventID == \"4688\" | where CommandLine contains \"-noni -ep bypass $\"",
            "queryFrequency": "5H",
            "queryPeriod": "5H",
            "triggerOperator": "GreaterThan",
            "triggerThreshold": 5,
            "suppressionDuration": "6H",
            "suppressionEnabled": false,
            "tactics": []
        }
    ]
}


the_excerpt() does not show 'Read more' if page break is done manually by

In templates/content.php, consider the following code,
<div class="entry-summary">
    <?php the_excerpt(); ?>
</div>

the_excerpt(); shows the Read more ( or ... Continued in Sage ) correctly, if the content is more than the excerpt_length.
But, if a user manually inserts a <!--more--> tag inside the content, let's say after 10 words, it will show the 10 words only ( which is correct ), but it won't show the Read more ( or ... Continued ) link.
A possible solution would be to search for <!--more--> tag and then conditionally show the either the_content() or the the_excerpt().
// Wordpress core uses the same regex to find the <!--more--> tag.
if (preg_match( '/<!--more(.*?)?-->/', $post->post_content, $matches)) {
  the_content(__('Read more', 'mytheme'));
}
else {
  the_excerpt();
}

However, I am not sure if it will cause issues to manually added excerpts.

Having the same Problem

not something we'd be looking to add to the theme by default, but others would find this helpful if you would share over at https://discourse.roots.io/
thanks!


Feature request: Open TOML file on AWS S3 bucket

It seems that toml files located on a AWS S3 bucket can't be read:
import toml
toml.load('s3://path/to/toml')

FileNotFoundError: [Errno 2] No such file or directory: 's3://path/to/toml'

Could this be implemented?

You should use the AWS SDK for Python (see documentation for S3 ) to download the TOML locally.
It doesn't look like the SDK provides access through a File-like object, so the best bet is probably to wrap the 'Body' returned by .get() in a StringIO object or something like that.


Fix CLLocationManager extension can call reject multiple times

manager.promise.always was insufficient as a means to stop listening for location manager events.  It was possible to receive multiple events from the location manager that could cause fulfill or reject to get called multiple times.  This is fixed by having the location manager delegates perform their own cleanup.  This guarantees fulfill or reject will only get called once. #450
Used a similar solution to what was used for the Objective-C implementation.

@nathanhosselton please merge


Error while packing extension by vsce package

OS: Windows 10
Run: vsce package
When i try to pack extension into .vsix i getting next error:
ERROR  SVGs are restricted in README.md; please use other file image formats, such as PNG: https://github.com/0x9ef/vscode-vlang/workflows/CI/badge.svg. How to resolve this?

Maybe this could work... 🙂
![GitHub Workflow Status](https://img.shields.io/github/workflow/status/0x9ef/vscode-vlang/CI?style=for-the-badge)

The only way is to use allowed 3rd-party badge services, e.g. shields.io.


MPI: separation of concerns

It is desirable that the MPI code is as separated as possible from the domain logic, for clarity.
From our email conversation:

Perhaps, we can extract the MPI part even more by defining a fallback like
getXBubble!(Workspace::PMFRGWorkspace, Lam) = getXBubblePartition!(Workspace::PMFRGWorkspace, Lam, 1:N,1:N,1:N)
we could then add a dispatch with an UseMPI() singleton for the parameters, i.e. via something like
Par = Params(System,OneLoop(UseMPI() );kwargs...)
the new MPI function could then be completely moved into the mpi folder.

We could also use the package extension mechanism for this.

Work in progress https://github.com/mmesiti/PMFRG.jl/tree/MPI-ext

I think the current solution still exposes changes to the standard types, i.e.
struct OneLoopParams{F<:AbstractFloat,G<:Geometry} <: PMFRGParams
    System::G
    NumericalParams::NumericalParams{F}
    Options::OptionParams
    UseMPI::Union{WithMPI,WithoutMPI}
end

Will rely on dynamic dispatch again, which is a bit against the spirit of the proposed disattachment.
What I had in mind was more along the lines of the following:
We have a standard implementation of parameters in which extensions such as TwoLoop() or MPI() are completely absent.
Then we implement a new type
struct MPIParams{F<:AbstractFloat,G<:Geometry} <: PMFRGParams
    System::G
    NumericalParams::NumericalParams{F}
    Options::OptionParams
end

I think most methods should dispatch on the abstract PMFRGParams type, so one should not have to change anything else.
As the recommend constructor we could implement a function Par(S::Geometry,::MPI{OneLoop})
That constructs the right type by wrapping MPI{OneLoop())
Perhaps it would also be another option to slightly change the params into
struct OneLoopParams{F<:AbstractFloat,G<:Geometry,O<:AbstractOptions} <: PMFRGParams
    System::G
    NumericalParams::NumericalParams{F}
    Options::O
end

And allow dispatch on the type of Options.
I think I'm slightly favoring the latter here.
What do you think?
For the first implementation we can also just add useMPI as a field in optionParams and keep the function that checks this option. When I refactor later I can think about what is the best strategy

I thought about having a completely different type for as MPIParams, but then I wondered - is it going to mean "OneLoop+MPI", right? Then, if one wanted to do "TwoLoops+MPI", or "MultiLoop+MPI", one would have to create additional types for that. I realize now that the approach I followed (which is not well thought through, I admit) does not solve this problem either, but I will
My idea would be that the MPI extension should be orthogonal to how-many-loops one wants to compute, but possibly this is kind of pointless if:

...the amount of code that needs to be "duplicated" (in this case, the MPIParams and OneLoopParams types are structurally identical) is very small - and it seems to be the case, after all (unless someone starts adding new orthogonal directions)
...one would have anyway to write specialized version of the code for each combination, which seems to be the case.

If these concerns are not valid, I thank you for the suggestion and I can indeed create a MPIParams (or maybe MPIOneLoopParams) type in the extension, and use it for dispatch.
I would have, though, to duplicate code for getDeriv!, which seems to dispatch also on the type of PMFRGParams. But if I make MPIOneLoopParams <: OneLoopParams, getDeriv! for OneLoopParams should be called given that
Tuple{BubbleType,T,MPIOneLoopParams} <: Tuple{BubbleType,T,OneLoopParams}.
This is what is implemented now in the MPI-ext branch (still WIP).
Regarding changing OneLoopParams and then dispatching on the type of Options, would not that require changes in many functions to make sure

While reviewing, I had another idea of how to separate this extension more elegantly (sorry for all the back and forth).
I noticed that my implementation of the OneLoopWorkspace is perhaps overcomplicating things and if the Params are used for dispatch they become more difficult to understand.
Instead, we could make the usage of MPI as a solver option, i.e. we dispatch on
SolveFRG(Par::PMFRGParams,::UseMPI;kwargs...) instead.
This is also consistent with the fact that the ODE solver is passed to the Solver and is not part of the params, which should only handle parameters that actually affect the outcome of the calculation.
This way we would need only to define PMFRG.UseMPI() in the main package and all the other stuff is in the extension.
In PMFRGMPIExt.jl, we then add
struct MPISetup{B<:PMFRG.BubbleType,BuffType,ParType<:PMFRG.PMFRGParams}
    X::B
    Buffs::BuffType
    Par::ParType
end

PMFRG.SolveFRG(Par,::PMFRG.UseMPI; kwargs...) =
    PMFRG.launchPMFRG!(PMFRG.InitializeState(Par), MPISetup(PMFRG.AllocateSetup(Par)...), getDerivMPI!; kwargs...)

I think this would require defining a new method getDerivMPI!(Deriv, State, setup::MPISetup, Lam)! in PMFRGMPIExt/Flowequations.jl, which is almost the same as the getDeriv! excempt that it calls the MPI version of the getXBubble! , but this avoids dispatch workarounds like defining
function getXBubble!(Workspace::PMFRGWorkspace, Lam, ::OneLoopParams)
    getXBubble!(Workspace, Lam)
end

I have tried it out and it seems to just work. If you agree, I can push these changes to the MPI branch, but I would like to hear your opinion on this first before making such a major rearrangement.

I have tried it out and it seems to just work. If you agree, I can push these changes to the MPI branch, but I would like to hear your opinion on this first before making such a major rearrangement.

I think this is a good idea, having getXBubble! to dispatch on a parameter that is not used seems a little dirty.
I do not like much this idea

I think this would require defining a new method getDerivMPI!(Deriv, State, setup, Lam)! in PMFRGMPIExt/Flowequations.jl, which is almost the same as the getDeriv! excempt that it calls the MPI version of the getXBubble!

But maybe we can avoid the duplication of getDeriv! by passing getXBubble! as an argument to it instead. Would it make sense?

That would be another solution although I am not a big fan of passing the functions around anymore because I found it often makes debugging more difficult. This way also seems to single out getXbubble in a weird way. Maybe we need to do it the "explicit way" and make a few more changes to the Base code. I.e. we define for the standard:
abstract type AbstractParallelizationScheme end

struct MultiThreaded <: AbstractParallelizationScheme end

function AllocateSetup(Par::AbstractOneLoopParams,Scheme::AbstractParallelizationScheme = MultiThreaded())
    [...]
    return (; X, Buffs, Par, Scheme)
end

function getDeriv!(Deriv, State, setup, Lam)
        [...]
        getXBubble!(Workspace, Lam, Par, setup.Scheme)
        [...]
    end

    return
end

function getXBubble!(Workspace::PMFRGWorkspace, Lam,::MultiThreaded)
     [...]
end

and in the extension, we define
struct UseMPI <: AbstractParallelizationScheme end

PMFRG.SolveFRG(Par,::PMFRG.UseMPI; kwargs...) =
    PMFRG.launchPMFRG!(PMFRG.InitializeState(Par), PMFRG.AllocateSetup(Par, UseMPI()), getDeriv!; kwargs...)

function getXBubble!(Workspace::PMFRGWorkspace, Lam,::UseMPI)
     [...]
end

Or something along those lines.  Of course this goes a little against my initial design philosophy of changing the non-MPI code as little as possible though, but perhaps this is more explicit. Or do you think this is taking it too far?

It's always about tradeoffs. I think it is still ok to add abstraction layers and decouple things. Stll, no MPI logic would go to the main package, so nobody who does not care would be forced to learn MPI, which is the most important thing I believe.
Of course adding a layer of abstraction means having another indirection, that makes things harder to understand - it's similar with passing functions around, to an extent.
The idea of having a ParallelizationScheme sounds very good to me, we could even move the output of the call to MPI_Details.get_all_ranges_stu inside that instead of recomputing it all the times (which is negligible but still inelegant).

Ok!
Maybe afterwards you could add the MPI_Details.get_all_ranges_stu in a separate commit? I think I know what you intend to do but this way is probably faster

Maybe afterwards you could add the MPI_Details.get_all_ranges_stu in a separate commit

We can leave as it is now, and add an issue to remind us of this. It's also better sometimes to keep ideas in the air for a while before implementing them, time usually helps with seeing all the sides of an idea better.

[ ] add the MPI_Details.get_all_ranges_stu in a separate commit


Visual Studio Code does not verify system requirements before auto-updating

Visual Studio Code does not verify system requirements, specifically the operating system, before auto-updating.  On Mac OS, this can result in breaking working environments when auto-updating is enabled.

VSCode Version: 1.35.1
OS Version: Mac OS X 10.9.5

I realize that this is being reported related to an old, outdated OS version, but I maintain various operating systems and versions for testing purposes and suspect that I will encounter this issue again in the future.  I figured a bug report was a better fit than a feature request, since this issue actively broke one of my dev environments and is entirely reproducible.  It seems like the auto-updater should be at least minimally mindful of the OS version requirements before it proceeds.
Steps to Reproduce:

Install VSCode v1.35.1 on Mac OS X 10.9.5

From the main "Code" application menu, choose "Check for Updates..."  or, alternatively wait for the application to perform an auto-update check.
When complete, the gear icon in the lower left of the window will indicate that you need to restart to update the software.

Restart VSCode to apply the update.
VSCode version 1.36.1 (or newer) will now be installed.  The app icon will indicate that it cannot run under OX 10.9.5 and attempting to launch it will result in an error dialog being displayed that states "You can't use this version of the application with this version of OS X."

Does this issue occur when all extensions are disabled?: Yes
Expected Behavior:
Do not apply the update.  Notify the user that an update is available but incompatible with the system.  Instruct how to, or automatically disable auto-updates.
Workaround:
Download last-known, working version (if available) from the VSCode Update Page, install and immediately disable auto-updating before the software performs the check.

@bpasero It seems the Electron update also raised the macOS system requirements.

@joaomoreno that is right, we no longer support macOS 10.9 as outlined on https://code.visualstudio.com/docs/supporting/requirements.

Then there's not much we can do now.
For everyone that is on macOS 10.9 and already has Code installed, we can't update those versions in people's disks... they will simply get an update to something that doesn't work. This is unfortunate. @bpasero next time this happens let's try to plan for it a bit better by adding the rule in the update story.


Project Card Drag and Drop bug

When running dark script the drag and drop feature that enables me to drag a card from one column in a project to another doesn't work while the script is enabled.
Chrome Version: Version 64.0.3282.186 (Official Build) (64-bit)

Hi @SweetJake!
This is actually an issue with TamperMonkey (assuming you're using it).
See https://github.com/StylishThemes/GitHub-Dark/issues/581 & https://github.com/Mottie/GitHub-userscripts/issues/36.

Yup that is exactly it. Thanks

It looks like Tampermonkey v4.6 is now available... closing this issue.


Consider using click for command line parsing

It's pretty friendly, and is allowed under LSST DM guidelines: https://developer.lsst.io/python/cli.html

See https://github.com/astronomy-commons/hipscat-import/issues/86


Add installation guide for developer

This PR adds installation guide for developers of this repository.

Thanks , a couple of thoughts:

We can add torch and espnet versions
S3PRL/Fairseq tested commit ids can be added similar to espnet installation

@karthik19967829
Sorry for the late reply.
Do you mean that we need to specify the version of torch, espnet, and s3prl/fairseq in requirements_export.txt?

@Masao-Someki yes if we specify the tested version that would be helpful for the developers to start with stable version

The detailed developer's guide should include the generic encoder. So with this PR, I will merge it with the additional demonstration.


Windows support

Missing version change.  Everything else is ready.
Comments solicited if anyone would care to look over the changes.
Windows support.
The remaining resources were converted to process the files in memory instead of line by line.
Fix for #85 and #86

This change is

Build variables being borked again...

Appveyor error looks pretty odd.
I'll going to see if we can do a matrix of tests on appveyor too

The appveyor failure might have been one of the random timeouts. It worked on a retry.  I don't know what to do with the danger file error.

That's Travis being... Difficult, and not passing in environment variables occasionally.
I might move that check to AppVeyor or CircleCI (this one is way more reliable and I can set the token globally)


Xcorner 21 cart page

@aleksandraworhacz Hi, can you please review again? Regarding p-common__title, I've handled that in XCORNER-20, maybe I will merge that first and rebase this one

@aleksandraworhacz Hi, can you please review again?


Read can hang because socket has infinite read timeout

Socket defaults to an infinite receive/send timeout. On a flaky internet connection, a half-open connection (ESTABLISHED but never closed presumably because of hard failures or edge router not sending RST) will leave the session open, and the connection will hang forever on any Read() of the socket data.
(This results in a lost listener thread in my server app... at this point I only have one flaky remote connection, but eventually I will run out of threads!)
Unfortunately, the conditions are difficult to reproduce manually, as network stacks are designed to aggressively avoid this sort of situation. What I do to reproduce it.

Set up a listener on a port
Open a connection to that listener, and send data so that a reader is waiting for a Read() call
use iptables to block SYN,ACK in and RST out on the client, so that the session is effectively hard disconnected
Wait a long time.
Stop the listener, and watch the stack trace

Stack trace will be something along the lines of:
System.IO.IOException: Unable to read data from the transport connection: A blocking operation was interrupted by a call to WSACancelBlockingCall. ---> System.Net.Sockets.SocketException: A blocking operation was interrupted by a call to WSACancelBlockingCall
   at System.Net.Sockets.Socket.Receive(Byte[] buffer, Int32 offset, Int32 size, SocketFlags socketFlags)
   at System.Net.Sockets.NetworkStream.Read(Byte[] buffer, Int32 offset, Int32 size)
   --- End of inner exception stack trace ---
   at System.Net.Sockets.NetworkStream.Read(Byte[] buffer, Int32 offset, Int32 size)
   at SocketHttpListener.Net.RequestStream.Read(Byte[] buffer, Int32 offset, Int32 count)
   at System.IO.Stream.InternalCopyTo(Stream destination, Int32 bufferSize)
   at System.IO.Stream.CopyTo(Stream destination)
   at (My HandlePost handler)(HttpListenerContext ctx)

I believe this could be averted by setting the socket's ReceiveTimeout and SendTimeout properties (I will experiment with this next).  Maybe this could be set to the same as the other HttpConnection timeouts (5 minutes? I guess that makes sense for keepalive sessions.) The read timeout should probably be the same then, although maybe not the write timeout.

On further consideration, setting the read timeout shorter would be a bad thing for HTTP keepalive sessions, so it makes more sense for the client code to manage body-read timeouts using async operations with cancellation (or some other mechanisms). However, the infinite timeout is a definite issue.
Adding socket settings to the HttpConnection constructor lets abandoned connections eventually close.
 sock.SendTimeout = s_timeout;  sock.ReceiveTimeout = s_timeout;
This should probably be set in the Endpoint manager, but the timeout variable is convenienty located here in the HttpConnection already.

Sorry to spam you with analysis. Looks like the .NET framework's ReadWriteTimeout defaults to 300s, so maybe I'll see if I can duplicate that behavior, as that would be consistent and unsurprising, I guess. Would certainly make my life easier. :)

Two possible changes come to mind:

set socket send/receive timeouts
Implement CanTimeout/ReadTimeout/WriteTimeout in Request/ResponseStream (optional)

And possibly a third:

Isn't 5-minutes a bit long for an HTTP keepalive session?

1: According to the docs, NetworkStream read/write timeouts default to 300000ms, and CanTimeout returns true. This default is wrong, possibly based on obsolute or platform-dependent Socket defaults. In any case, Infinite is a problem in real server applications. (Certainly it has ruined my week. :) )
2: may cause problems if HttpConnection does not behave well after a socket timeout, so it may be that we should not allow "set" on the timeouts. "Throwing Socket exceptions" is not acceptable as a normal behavior for a timed-out HTTP keepalive session. So I suggest hard-coding Socket timeout to a value larger than the HttpConnection read timeout and calling it good enough.
2: may not work if NetworkConnection does not implement the Timeout functionality
There is code in HttpConnection to manage the read timeout, which simply closes the socket on timeout. This only protects the "waiting for the next HTTP message" loop, and is not complete protection against half-open connections even if clients of the listener never read or write. Outside of this loop, there is no protection against abandoned sockets, and it should be posible to hang the listener itself if the socket is abandoned during a SendResponse type operation.
3: 1 or 2 minute timeout is more common these days, but 5 used to be the thing and I don't see a problem with that. The code does not appear to use the keepalive timeout supplied with the HTTP headers, so a 5 minute keepalive is hard coded. What if I set the keepalive timeout to 4.5 minutes with a 5 minute socket timeout? I suppose I could add just the bits of TimeoutManager required to support a configurable timeout, but it's Friday!
Final note: Do I really need to go rewrite all my client code to use async I/O? I guess I do. Darn it!

#16  The smallest PR I've ever made.
After all that analysis, I think a small tweak to cover the worst case scenario is the best approach.


[WFLY-15126]:Upgrade CXF from 3.3.10 to 3.4.4

https://issues.redhat.com/browse/WFLY-15126

@jimma Builds fail due to:
[02:19:22][Step 2/3] [WARNING] Rule 0: org.apache.maven.plugins.enforcer.BanTransitiveDependencies failed with message:
[02:19:22][Step 2/3] org.wildfly:wildfly-ee-feature-pack-common:pom:25.0.0.Beta1-SNAPSHOT
[02:19:22][Step 2/3]    org.apache.cxf:cxf-rt-bindings-coloc:jar:3.4.4:compile has transitive dependencies:
[02:19:22][Step 2/3]       jakarta.annotation:jakarta.annotation-api:jar:1.3.5:compile
[02:19:22][Step 2/3]       jakarta.xml.ws:jakarta.xml.ws-api:jar:2.3.3:compile
[02:19:22][Step 2/3]          jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.3:compile
[02:19:22][Step 2/3]       jakarta.jws:jakarta.jws-api:jar:2.1.0:compile
[02:19:22][Step 2/3]       jakarta.xml.soap:jakarta.xml.soap-api:jar:1.4.2:compile
[02:19:22][Step 2/3]          jakarta.activation:jakarta.activation-api:jar:1.2.2:compile
[02:19:22][Step 2/3]       com.sun.activation:jakarta.activation:jar:1.2.2:compile
[02:19:22][Step 2/3]    org.apache.cxf:cxf-rt-ws-security:jar:3.4.4:compile has transitive dependencies:
[02:19:22][Step 2/3]       org.ehcache:ehcache:jar:3.8.1:compile
[02:19:22][Step 2/3]          org.slf4j:slf4j-api:jar:1.7.30:compile
[02:19:22][Step 2/3]
[02:19:22][Step 2/3] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M2:enforce (ban-transitive-deps) on project wildfly-ee-feature-pack-common: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed.

@jimma Never mind; I expect you just fixed that. :)

WildFly Preview tests of this branch:
https://ci.wildfly.org/viewLog.html?buildId=268276&tab=buildResultsDiv&buildTypeId=WF_WildFlyPreviewLinuxJdk11
https://ci.wildfly.org/viewLog.html?buildId=268274&tab=buildResultsDiv&buildTypeId=WF_Ee9BootableJarLinuxJdk8


Add range checks for memory operations

This PR adds the required lookups to the Range Checker for all memory accesses. Memory range checks can only be processed during trace finalization when all memory accesses are known and ordered. Therefore, this PR includes a minor refactor of the trace finalization and auxiliary table handling.
Note: The memory trace is now finalized when the auxiliary table is initialized, which means the work can no longer be parallelized with the finalization of the hasher and bitwise components. I did this to avoid processing the memory trace while still keeping the Memory component simple, but we could take a different approach. Alternatively, we could consider finalizing the hasher/bitwise traces during aux table initialization as well, so we can still parallelize this process.

One potential alternative approach is to determine deltas without building the trace (by simply traversing the memory trace map), but I'm not sure whether this will be more or less performant.

Yeah I considered this option. It's worth investigating. I'll make an issue in the next day or two.

I'm not sure I would have gone with RangeCheckUpdate extension trait - but since it is already there, let's keep it.

I didn't want to duplicate the add_value logic to handle the lookups in the memory's map, and this seemed like the best way around it. What would you have done here?


Beta 5 - tried but failed

ok, I tried to convert the project myself to beta 5 but it fails:

npm ERR<EMAIL_ADDRESS>postinstall: typings install --ambient --name es6-promise github:DefinitelyTyped/DefinitelyTyped/es6-promise/es6-promise.d.ts#830e8ebd9ef137d039d5c7ede24a421f08595f83; typings install --ambient --name es6-collections github:DefinitelyTyped/DefinitelyTyped/es6-collections/es6-collections.d.ts#9f97e2a2bc1f502550c9b4fcaad1c48df5521d37
npm ERR! Exit status 1

Please help with this. I think everyone would benefit from this great repo when it's upgraded to beta 5.

hi, yeah sorry I updated it last night and forgot to push it up

done via https://github.com/AngularClass/angular2-webpack-starter/commit/46d24697f65d414d2c88ca979ecd86d6cfbde6c5

No go:
><EMAIL_ADDRESS>postinstall D:\Documents\Visual Studio 2015\Projects\angular2-webpack-starter\node_modules\angular2
> typings install --ambient --name es6-promise github:DefinitelyTyped/DefinitelyTyped/es6-promise/es6-promise.d.ts#830e8ebd9ef137d039d5c7ede24a421f08595f83; typings install --ambient --name es6-collections github:DefinitelyTyped/DefinitelyTyped/es6-collections/es6-collections.d.ts#9f97e2a2bc1f502550c9b4fcaad1c48df5521d37

? What is the dependency name? es6-promise
typings ERR! message Unable to read typings for "es6-promise". You should check the path is correct
typings ERR! caused by https://raw.githubusercontent.com/DefinitelyTyped/DefinitelyTyped/830e8ebd9ef137d039d5c7ede24a421f08595f83;/es6-promise/es6-promise.d.ts responded with 404, expected it to equal 200

typings ERR! cwd D:\Documents\Visual Studio 2015\Projects\angular2-webpack-starter\node_modules\angular2
typings ERR! system Windows_NT 10.0.10586
typings ERR! command "C:\\Program Files\\nodejs\\node.exe" "D:\\Documents\\Visual Studio 2015\\Projects\\angular2-webpack-starter\\node_modules\\angular2\\node_modules\\typings\\dist\\bin\\typings-install.js" "--ambient" "--name" "es6-promise" "github:DefinitelyTyped/DefinitelyTyped/es6-promise/es6-promise.d.ts#830e8ebd9ef137d039d5c7ede24a421f08595f83;" "typings" "install" "--ambient" "--name" "es6-collections" "github:DefinitelyTyped/DefinitelyTyped/es6-collections/es6-collections.d.ts#9f97e2a2bc1f502550c9b4fcaad1c48df5521d37"
typings ERR! node -v v5.6.0
typings ERR! typings -v 0.6.6

typings ERR! If you need help, you may report this error at:
typings ERR!   <https://github.com/typings/typings/issues>

npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm ERR! Windows_NT 10.0.10586
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v5.6.0
npm ERR! npm  v3.6.0
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>postinstall: `typings install --ambient --name es6-promise github:DefinitelyTyped/DefinitelyTyped/es6-promise/es6-promise.d.ts#830e8ebd9ef137d039d5c7ede24a421f08595f83; typings install --ambient --name es6-collections github:DefinitelyTyped/DefinitelyTyped/es6-collections/es6-collections.d.ts#9f97e2a2bc1f502550c9b4fcaad1c48df5521d37`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'typings install --ambient --name es6-promise github:DefinitelyTyped/DefinitelyTyped/es6-promise/es6-promise.d.ts#830e8ebd9ef137d039d5c7ede24a421f08595f83; typings install --ambient --name es6-collections github:DefinitelyTyped/DefinitelyTyped/es6-collections/es6-collections.d.ts#9f97e2a2bc1f502550c9b4fcaad1c48df5521d37'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     typings install --ambient --name es6-promise github:DefinitelyTyped/DefinitelyTyped/es6-promise/es6-promise.d.ts#830e8ebd9ef137d039d5c7ede24a421f08595f83; typings install --ambient --name es6-collections github:DefinitelyTyped/DefinitelyTyped/es6-collections/es6-collections.d.ts#9f97e2a2bc1f502550c9b4fcaad1c48df5521d37
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular2
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular2
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     D:\Documents\Visual Studio 2015\Projects\angular2-webpack-starter\npm-debug.log

Just cloned the latest repo.

can you apply these changes https://github.com/AngularClass/angular2-webpack-starter/commit/1fcdc9b3cacdbc56f0e2d02dc6bdc2c96a51bc3a
cc @blakeembrey

The repo location will be redirecting file. The issue you're running into is: https://github.com/angular/angular/issues/7000. Basically Angular broke every Windows user because the semicolon is not a Windows delimiter and thought was part of the path.

@alvipeo you and every windows user has to wait for beta.6 release

DAMN...

beta.6 is released now.
In general it's probably wise to wait a few hours for dust to settle before updating a widely-used resource to latest.
We'll write up a mini-postmortem on beta.4/5

@alvipeo updated to beta.6 https://github.com/AngularClass/angular2-webpack-starter/commit/aecdc3e6fcf70c4f956030f2a46b871c5c25d9d5
@alexeagle thanks for fixing the release

Thanks! Works like a charm!


failed: Connection closed before receiving a handshake response

Cannot get updated in WEB UI.
OS：CentOS 7
Docker: 1.12.3
Rancher: stable

I'm getting same error when I try access Logs and Shell behind Rancher HA.
If I access using IP/Address of individual host, all access work well.

looks like a websocket issue. most likely a configuration issue with your load balancer.

I have the same problem, but the logs/exec work sporadically. I have to try a dozen times or so before I'm able to view the logs or exec into the container.
Doesn't feel like an ELB issue since that would either work or it wouldn't.
I've also verified that ntpd is running on my rancher server, hosts and local machine.
What else can I check?

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Automatic rebuild of old operators/operands images

Sometimes, it can happen that a bundle loses track of the latest image of an operator/operand, in case they are both rebuilt but the bundle rebuild fails to ship. In this case, new rebuilds of those operator/operand will no longer trigger a rebuild of the bundle.
For example, imagine we have a bundle 'bundle-2-234' and a related image 'foo-1-123', and the following happens:

the image gets rebuilt to 'foo-1-123.234' and the bundle also happens a rebuild triggered, but it fails to ship
then the image gets rebuild again to 'foo-123-456'
this new rebuild of 'foo-1-123' will not trigger a rebuild of the        bundle, as it is not related to 'foo-123-456'

The manual overriding feature can be used to circumvent this issue, but it is better if we can make an automatic solution.
This commit enables FM to automatically search, during bundle rebuilds, for previous rebuilds of those related images and replace them with the latest images.
JIRA: CWFHEALTH-2141

Testing remarks
I made a new unit test for this specific feature. I'm also searching for candidate bundles that could be useful for a manual test, I'll make an update with the results if I can find some.

Hello


Raise exception/error when client is initialized incorrectly

I think if you initialize the client like this it should raise an exception:
var client = new Keen({
projectId: "",
readKey: "",
writeKey: ""
});
either on init or lazy when you first use it

@gorzell the main Keen instance and others like Keen.Dataviz are all composable and don't have initialization requirements of any kind. This is so you can add/update/remove config options on the fly, making them more flexible and reusable:
// initialization..
var client = new Keen()
  .projectId("YOUR_PROJECT_ID")
  .readKey("YOUR_READ_KEY");

// something happens, maybe a user interaction...
client
  .projectId("DIFF_PROJECT_ID")
  .readKey("DIFF_READ_KEY")
  .run(query, function(err, res){
      // handle err / res
  });


chore: make IO.RealWorld opaque

Do the test diffs imply we're doing more refcounting?
!bench

!bench

@Kha, do you think this is okay to merge, given that benchmarking was okay?

@Kha, do you think this is okay to merge, given that benchmarking was okay?

Yes! Sorry for the 13-month delay :)


Acceleration data to trigger parachutes

Is your feature request related to a problem? Please describe.
Parachute trigger functions only have access to pressure and the state vector, without acceleration data.
Describe the solution you'd like
Acceleration data, with noise.

@FranzYuri can you please take a look at this since it's releated to parachute functions? I think you'll like it!!
Might not be too complicated, but let's use some minutes during the week to discuss if needed

@MateusStano, these may help you:

https://github.com/scipy/scipy/commit/7e2ddf86c5f8df9642f330e4a1d09f838e953306
https://computing.llnl.gov/sites/default/files/ODEPACK_pub2_u113855.pdf (page 93)


Fix the recordToDB -> is_transient mapping

The code to remap the old recordToDB property to the Sparkplug is_transient field was changing datastructures which were supposed to be readonly. This meant that after the first packet published the property was no longer there.
The v1-stable branch has a fix for this which ends up ignoring recordToDB after the first packet; instead, move the whole mapping into reHashConf.

Why not into v1-stable?

Because I need the fix in this branch :).
My experience of working with multiple branches is that in general changes should go to main first and then be cherry-picked into a stable branch if desired. Direct commits to a stable branch should be limited to bugfixes to code that no longer exists in main, or emergency fixes that will be done differently in main. This avoids needing to merge changes forward from stable to main.


Feature: Security benefit on having 2 or more Required Reviews no clear (Feedback)

Is your feature request related to a problem? Please describe.
Some maintainers had raised the question about whether it is really a relevant security best practice to have 2+ Required Review (related to the branch protection check)
Describe alternatives you've considered
The Branch-Protection check explanation could talk (or at least refer) an explanation on why it is important to have 2 or more required reviews
Additional context
https://github.com/electron/electron/pull/35741#pullrequestreview-1118960274

To protect against insider risks: if one maintainer is compromised, an attacker can send a PR and use the compromised account to LGTM their own PRs. X LGTMs requires X compromised maintainers, which is harder.

I've created a PR https://github.com/ossf/scorecard/pull/3013 to address this issue and try to make this benefit clear to the user too. Thanks for the explanation @laurentsimon !


NTR: L-valine biosynthetic process

Please provide as much information as you can:

Suggested term label:

NTR: L-valine biosynthetic process

Definition (free text)

standard def

Gene product name and ID to be annotated to this term

All biosynthesis in fission yeast.

Parent term(s)

valine biosynthetic process
(so far I have been able to annotate  AA biosynthesis pathways to the L-form if applicable)

Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term?

Synonyms (please specify, EXACT, BROAD, NARROW or RELATED)

Cross-references

For enzymes, please provide RHEA and/or EC numbers.

Can also provide MetaCyc, KEGG, Wikipedia, and other links.

Any other information

Oddly there is no L-arginine biosynthetic process either. I thought these were all done a few months back, I wonder if there was a reason these were not added?

We have
GO:0009099 valine biosynthetic process
GO:0006526 arginine biosynthetic process
I believe we have an ongoing project about D/L amino acids but cannot seem to find it.

We could rename GO:0009099 valine biosynthetic process to L-valine?
I think the D- amino acids are 'racemized' from the L forms. Is this a process? Maybe only the L- forms should be captured for synthesis (not sure about metabolism and degradation).
From https://pubmed.ncbi.nlm.nih.gov/24752840/:

Bacteria synthesize D-AAs using one of two mechanisms:
inversion of stereochemistry about the α-carbon of the corresponding L-AA, or stereospecific amination of the corresponding α-ketoacid. The former, catalyzed by AA
racemase or epimerase enzymes, is a reversible reaction
resulting in direct interconversion of the L- and Dstereoisomers. The latter reaction, also reversible, relies on
an amino-containing co-substrate and is catalyzed by D-AA
aminotransferase enzymes.

How about GO:0006526 arginine biosynthetic process, also rename to L-?

Yes


Update README.md (fix typo and link to example file)

Fix typo in the first sentence.
Fix the direct link to index.js (which is not working) to relative link to index.android.js in example folder.

Coverage remained the same at 93.846% when pulling 0bbad3ebabc3bb70e39e69a33c702cc14dfb5a5c on ttpro1995:master into 922cb758d96283f7281c98140c616415c7399505 on xgfe:master.

Thanks!


macOS VM core count maxes out at 16, even when more cores are available

The VM only recognizes up to 16 CPUs (sysctl -n hw.ncpu) even when configured to use 18 or 20.
Is this a known limitation?
Is it possible that VZVirtualMachineConfiguration maximumAllowedCPUCount is not set correctly?
Host machine:

20-core 2022 Mac Studio M1 Ultra
macOS Ventura 13.3.1
UTM 4.6.1

VM:

macOS Ventura 13.2.1

This is a known limitation imposed by Apple.

Thanks @osy.


Readme fixes

The way it was written, we were telling people that single-page applications were meant to be used with the api option.  This is not correct, SPAs need the website option.  The api option enables or OAuth workflows, nothing else.
I still need to file a Discuss issue so that we can discuss how we feel about these option profiles.  But in the meantime I want to make these updates to the README so that we reduce confusion

Done w/ review. Made a few comments ^^

Awesome review, thanks for finding those.  Updated accordingly :)


[WIP] Add support for setting debug protocol speed (try 2)

Ported from https://github.com/probe-rs/probe-rs/pull/130

@Yatekii If you know how to implement these methods and have an access, go ahead! I don't have a JLink hardware with me, so I can't test.

Fair enough. So let's merge this and then we open an issue to track that we should implement this for JLink. Or do you want to make any more additions?


rendering $..$ and macros not work

Hi.  I have followed all the instructions to render with $ .. $ and it does not work. And neither when creating my macros
<body>
<script>
 $(document).ready(function() {  katex.render(formula, element, {
  delimiters: [
   {left: "$$", right: "$$", display: true},
   {left: "\\[", right: "\\]", display: true},
   {left: "$", right: "$", display: false},
   {left: "\\(", right: "\\)", display: false} ],
    macros: {
      // Algebra-Precal
      "\\lcm": "\\mathop{\\mathrm{lcm}}",
      "\\sen" "\text{sen}\\",
      // Calculus
      "\\dd": "\\mathop{\\mathrm{d} #1}",
      "\\abs": "\\lvert#1\\rvert",
      }
  });
 });
</script>
</body>
the page with this problem is https://prob.matematicauniversitaria.com/
in the CSS I only have:
p{     font-family: times new roman; /*Latin Modern Math*/     font-size: 100% }
.katex{      font-size: 1.10em;  /*1.16em dicen q es el 100%*/       }
and in the head I have the same thing that it provides https://katex.org/docs/autorender.html
What should I correct?
Thanks in advance.

@MathSalomon Thanks for providing a demo page! If you look at the JavaScript console, you'll see that you're getting several parse errors on the KaTeX side.
I see some bugs in your macro code; in particular "\\sen" "\text{sen}\\", should be "\\sen": "\\text{sen}\\\\", (missing colons and missing escapes).

I already made the correction
"\\sen": "\\text{sen}\\,",
be cause in latex the macro should be:
\newcommand{\sen}{\text{sen}\,} or
\newcommand{\sen}{\operatorname{sen}}
But, the result is the same in
https://prob.matematicauniversitaria.com/

Can anyone help me please?  I have put a fixed version below.
You should also remove onload="renderMathInElement(document.body);" or maybe even the whole katex auto-render load line, as currently you are loading katex twice.
  document.addEventListener("DOMContentLoaded", function() {
  renderMathInElement(document.body, {
    delimiters: [
    {left: "$$", right: "$$", display: true},
    {left: "\\[", right: "\\]", display: true},
    {left: "$", right: "$", display: false},
    {left: "\\(", right: "\\)", display: false} ],
    macros: {
      // Algebra-Precal
      "\\lcm": "\\mathop{\\mathrm{lcm}}",
      "\\sen": '\\text{sen}\\\\,',
      // Calculus
      "\\dd": "\\mathop{\\mathrm{d} #1}",
      "\\abs": "\\lvert #1 \\rvert",
      }
  });
 });

Thank you.
Now I can see that it renders perfectly with the macros.

I used

<script> document.addEventListener("DOMContentLoaded", function() {
renderMathInElement(document.body, {
delimiters: [
{left: "$$", right: "$$", display: true},
{left: "\[", right: "\]", display: true},
{left: "$", right: "$", display: false},
{left: "\(", right: "\)", display: false} ],
macros: {
// Algebra-Precal
"\lcm": "\mathop{\mathrm{lcm}}",
"\sen": '\text{sen}\,',
// Calculus
"\dd": "\mathop{\mathrm{d} #1}",
"\abs": "\lvert #1 \rvert",
}
});
}); </script>

in the  <body>
Best regards!


Syntax error in directives documentation

Hi There,
I'm looking at the mutually recursive module example within the directives documentation (https://github.com/reasonml-community/graphql-ppx/blob/855b16bca8621ae5f0a1179edc8bf46061248e8b/documentation/docs/directives.md).
I tried to paste it in the ReScript playground and the syntax doesn't convert/compile: https://rescript-lang.org/try?ext=re&code=LYewJgrgNgpgBAVQM4wE4EUJoJ5wLxwDaApAOaoCGADgBYCOUcA3gD4BQccdWquTHnOBBSo4AASpUAHgGFhAFxDAAFKEiwAXHABEyNNoCUzAYLgBLMCcEA7CsBhWAvgOdwWjuBWthEIrf0F5bCp4eXxjUzhbewBBbwBJMC0keVQza1ITRwBuE1gwqgpUFC09DB5sADp5AH1hNHwAPjh5XMF8uBEzCigzAC8YLTC8ZrLMHGq6kTaPAgDOIJCW8PmbOxg4sETk1PTMwRy8mAKilHD60RGI02iNhKTOgHczeQBjGjhlC8rbo1XTAByIGs8Cu2iBt20cAA1NChCJKhYrIIAMpKGDKX5NKLrGFw75IyKuTiHOCOIA

This is primarily because the ppx is not running in the playground


GH-35095: [C++] Prevent write after close in arrow::ipc::IpcFormatWriter

This addresses GH-35095 by adding a flag to IpcFormatWriter to track when a writer has been closed, and check this flag before writes.

Rationale for this change
This addresses #35095 , preventing stream and file IPC writers from writing record batches once the IPC writer has been closed.

What changes are included in this PR?
Adding a flag so that an IpcFormatWriter to track when it's been closed, a check before writes in IpcFormatWriter, and two tests to confirm it works as expected.

Are these changes tested?
Yes, the changes are tested. The two tests were added, and the C++ test suite ran. No unexpected failures appeared.

Are there any user-facing changes?
Other than newly returning an invalid status when writing after close, no, there should not be any user-facing changes.

Closes: #35095

Could you check the "C++ / AMD64 Ubuntu 22.04 C++ ASAN UBSAN" failure?
https://github.com/apache/arrow/actions/runs/6242111241/job/16945464958?pr=37783#step:6:3569
==15144==ERROR: LeakSanitizer: detected memory leaks

Indirect leak of 512 byte(s) in 1 object(s) allocated from:
...

Yep, taking a look. Rebasing on main first, in case it was fixed elsewhere.

Oh, the failure has gone.
It'll not be related to this change.
I'll merge this.


[EN] Feedback for: /web/tools/chrome-devtools/debug/console/console-ui?hl=en

I would be very happy if I could just get the content of the console.
Unfortunately, there is no "Select all".
When I save the console to a file, it will not save all the text in the console.
Example:
It will save:
Failed to load resource: the server responded with a status of 404 (Not Found)
but not the associated resource.

This may have been added since your request, but Right-Click (context menu) has "Select All" option.

I have updated Chrome to the newest Version 47.0.2526.111 m (64-bit),
but there is still no "Select All" in the Right-Click (context menu) of the console.

I do apologise.. you are right.  I must have had another browser's dev tools open when I answered your comment (which look quite similar to Chrome's, and which do have the 'Select All' option)
I'm sorry sorry for wasting your time, but I second your request.

No worries, Jon. I appreciate your efforts to help me.

Feature requests should be filed on the chromium issue tracker. The team that works on the DevTools doesn't directly look here for things like this.

As @Garbee said, this repository is only for DevTools docs. Please submit your feature request on the Chromium issue tracker.


Self signed certificate error

My dev machine use swagger endpoint on https with a self-signed certificate.
If I run swagger-typescript-api I get this error:
(node:14680) UnhandledPromiseRejectionWarning: Error: self signed certificate in certificate chain     at TLSSocket.onConnectSecure (_tls_wrap.js:1498:34)     at TLSSocket.emit (events.js:315:20)     at TLSSocket._finishInit (_tls_wrap.js:940:8)     at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:698:12) (Use node --trace-warnings ...to show where the warning was created) (node:14680) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag--unhandled-rejections=strict(see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2) (node:14680) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Would be possibile to add an options to accept also self-signed certiificate?
Tnx
Fabio

Hello @kel666 !
Thanks for this issue
Is this issue based on fetch swagger schema with using self significant certificate?

Hello @kel666 !
Thanks for this issue
Is this issue based on fetch swagger schema with using self significant certificate?

Mmmm don't exactly what you mean, swagger is running on a IIS server.
This happens when I run
npx swagger-typescript-api -p {internal_url_with_https}
tnx
Fabio

Mmmm don't exactly what you mean, swagger is running on a IIS server.
This happens when I run
npx swagger-typescript-api -p {internal_url_with_https}
tnx
Fabio

I think it is problem of axios tool, which I use for download swagger schema by url \ -p
@kel666  may be add option --cert  which has been used for certificate path ?

I think it is problem of axios tool, which I use for download swagger schema by url \ -p
@kel666  may be add option --cert  which has been used for certificate path ?

It's an options but it wolud be uncomforable, since one should download the certificate and point to it.
Don't you like the idea of having an options bypassing SSL strict?

It's an options but it wolud be uncomforable, since one should download the certificate and point to it.
Don't you like the idea of having an options bypassing SSL strict?

@kel666 Please open PR with ignoring SSL strict if you can! Use the next branch for changes

@kel666 Please open PR with ignoring SSL strict if you can! Use the next branch for changes

As quick solution I think this can be helped to you
https://github.com/axios/axios/issues/535#issuecomment-58819624

As quick solution I think this can be helped to you
https://github.com/axios/axios/issues/535#issuecomment-58819624

Just created the PR let me know if is ok

Just created the PR let me know if is ok

Thank you for issue and PR @kel666 !
option --disableStrictSSL added in<EMAIL_ADDRESS>

Thank you for issue and PR @kel666 !
option --disableStrictSSL added in<EMAIL_ADDRESS>


After replacing the kubelet binary, the kubelet will automatically exit

I followed the readme and configured the environment until step 7. When I initialize the k8s-cluster, I got [kubelet-check] It seems like the kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10248/healthz' failed with error: Get http://localhost:10248/healthz: dial tcp <IP_ADDRESS>:10248: connect: connection refused.
Checking the kubelet status reveals that the kubelet repeatedly starts and exits.

I used the original k8s-1.19 binaries instead of the binaries provided in the readme.  Then, I found that it could initialize the k8s-cluster.
I need your help, thanks.

Hi Lolopop,
Where did you get the log from Kubelet ( as so in the figure) ? From master
node or from the worker nodes ?
I noticed that the Kubelet will not start until the init command is
executed in master node and the join command is executed in worker node.
If you have any other questions. Feel free to contact me.
P/S: other original binaries like: kubeadm, kubectl can be used. However,
to support pod-migration, the kubelet was extended as my work and Jakob's
work, so there is no way to have pod-migration without kubelet extension.
It means you have to use kubelet binaries ( in the readme) to try migrate a
pod.
Thanks you,
Vào Th 2, 22 thg 3, 2021 vào lúc 22:22 Lolopop @.***>
đã viết:

I followed the readme and configured the environment until step 7. When I
initialize the k8s-cluster, I got [kubelet-check] It seems like the
kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to
'curl -sSL http://localhost:10248/healthz' failed with error: Get
http://localhost:10248/healthz: dial tcp <IP_ADDRESS>:10248: connect:
connection refused.
Checking the kubelet status reveals that the kubelet repeatedly starts and
exits.
[image: image]
https://user-images.githubusercontent.com/16383423/111994451-c1353180-8b52-11eb-9dc9-5061fda48a3a.png
[image: image]
https://user-images.githubusercontent.com/16383423/111994488-cbefc680-8b52-11eb-9867-3002b31bf05a.png
I used the original k8s-1.19 binaries instead of the binaries provided in
the readme. Then, I found that it could initialize the k8s-cluster.
I need your help, thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SSU-DCN/podmigration-operator/issues/2, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD3RTAKZWI3GITIF7S4FW6DTE5ACPANCNFSM4ZTDOHGA
.

Thank you for your reply. According to init-cluster-containerd-CRIU.md, I reconfigured it and now the k8s cluster has been created.
NAMESPACE     NAME                                  READY   STATUS    RESTARTS   AGE
kube-system   coredns-586dd6b6d7-ptlnr              1/1     Running   0          4h41m
kube-system   coredns-586dd6b6d7-qmzlf              1/1     Running   0          4h41m
kube-system   etcd-dragonlab01                      1/1     Running   0          4h41m
kube-system   kube-apiserver-dragonlab01            1/1     Running   0          4h41m
kube-system   kube-controller-manager-dragonlab01   1/1     Running   0          4h41m
kube-system   kube-flannel-ds-gjk5x                 1/1     Running   0          177m
kube-system   kube-flannel-ds-rrhj8                 1/1     Running   0          177m
kube-system   kube-flannel-ds-s7hm5                 1/1     Running   0          177m
kube-system   kube-proxy-cr62w                      1/1     Running   0          177m
kube-system   kube-proxy-k4q7x                      1/1     Running   0          4h12m
kube-system   kube-proxy-kqmgv                      1/1     Running   0          4h41m
kube-system   kube-scheduler-dragonlab01            1/1     Running   0          4h41m

I'm trying to restore the example of migrating the video-stream application in the readme.md and I'm facing another error. When I am executing the command kubebuilder create api --group podmig --version v1 --kind Podmigration. I got the following error.
Create Resource [y/n]
y
Create Controller [y/n]
y
Writing scaffold for you to edit...
api/v1/podmigration_types.go
controllers/podmigration_controller.go
Running make:
$ make
go: creating new go.mod: module tmp
go get: added sigs.k8s.io/controller-tools v0.2.5
/root/go/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
Error: go [list -e -json -compiled=true -test=false -export=false -deps=true -find=false -tags ignore_autogenerated -- ./...]: exit status 1: go: example.com/m/controllers: package github.com/go-logr/logr imported from implicitly required module; to add missing requirements, run:
	go get<EMAIL_ADDRESS>
Usage:
  controller-gen [flags]

Examples:
	# Generate RBAC manifests and crds for all types under apis/,
	# outputting crds to /tmp/crds and everything else to stdout
	controller-gen rbac:roleName=<role name> crd paths=./apis/... output:crd:dir=/tmp/crds output:stdout

	# Generate deepcopy/runtime.Object implementations for a particular file
	controller-gen object paths=./apis/v1beta1/some_types.go

	# Generate OpenAPI v3 schemas for API packages and merge them into existing CRD manifests
	controller-gen schemapatch:manifests=./manifests output:dir=./manifests paths=./pkg/apis/...

	# Run all the generators for a given project
	controller-gen paths=./apis/...

	# Explain the markers for generating CRDs, and their arguments
	controller-gen crd -ww

Flags:
  -h, --detailed-help count   print out more detailed help
                              (up to -hhh for the most detailed output, or -hhhh for json output)
      --help                  print out usage and a summary of options
      --version               show version
  -w, --which-markers count   print out all markers available with the requested generators
                              (up to -www for the most detailed output, or -wwww for json output)

Options

generators

+webhook                                                                                package  generates (partial) {Mutating,Validating}WebhookConfiguration objects.
+schemapatch:manifests=<string>[,maxDescLen=<int>]                                                        package  patches existing CRDs with new schemata.
+rbac:roleName=<string>                                                                                package  generates ClusterRole objects.
+object[:headerFile=<string>][,year=<string>]                                                             package  generates code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
+crd[:crdVersions=<[]string>][,maxDescLen=<int>][,preserveUnknownFields=<bool>][,trivialVersions=<bool>]  package  generates CustomResourceDefinition objects.

generic

+paths=<[]string>  package  represents paths and go-style path patterns to use as package roots.

output rules (optionally as output:<generator>:...)

+output:artifacts[:code=<string>],config=<string>  package  outputs artifacts to different locations, depending on whether they're package-associated or not.
+output:dir=<string>                               package  outputs each artifact to the given directory, regardless of if it's package-associated or not.
+output:none                                       package  skips outputting anything.
+output:stdout                                     package  outputs everything to standard-out, with no separation.

run `controller-gen object:headerFile=hack/boilerplate.go.txt paths=./... -w` to see all available markers, or `controller-gen object:headerFile=hack/boilerplate.go.txt paths=./... -h` for usage
make: *** [Makefile:55: generate] Error 1
2021/03/26 11:53:19 failed to create API: exit status 2

I followed the reminder and executed 	go get<EMAIL_ADDRESS>and go get<EMAIL_ADDRESS>But it didn't solve the error.
I found out that it seems to be caused by the lack of controller-gen CLI, but after installing kubebuiler, I couldn't find any installation guidelines for controller-gen CLI.  Is the controller-gen CLI not working because I misconfigured kubebuilder?
I look forward to your guidance, and I continue to try to fix the error.
PS: since I am new to kubebuilder, please forgive me if I may be asking too simple questions.

Thank you for your interest. I am really happy to help you since your simple question is exactly what I've met.
To run the controller, you don't need to run kubebuilder create api --group podmig --version v1 --kind Podmigration. This command is used by kubebuilder, the first time I build kuberbuilder-based operator, to generate some source code template ( something like this). I will fix the document so that there is nothing to confuse here.

Firstly, the document is missing the part, in which I setup the NFS server sharing between all hosts in K8S cluster. Since I create a folder /var/lib/kubelet/migration at all hosts. I installed NFS server in the master node, NFS client in worker nodes and export/mount the folder from master node to worker node. So that they can share the same folder, which I used to exchange the checkpoint information. You also need to set the folder permission for your user $ sudo chmod 777 /var/lib/kubelet/migration. If you don't know how to config NFS, please refer to my note: https://github.com/vutuong/personal-notes/blob/master/configNFS.md
I'm sorry but I will update the document as soon as possible.
You just need to start from How to run (in the document):

$ sudo apt-get install gcc
$ sudo snap install kustomize
$ make manifests
$ make install
$ make run

In another terminal, run the Api-server:
$ go run ./api-server/cmd/main.go
Then, you can test with curl command as you can see in the doc.
P/S: Please check the kubelet, contained before all. You should see the logs as below at worker nodes:

root@cluster2-worker1:/home/dcn# kubelet --version
Kubernetes v1.19.0-beta.0.1010+a94a66e8033cf4-dirty
root@cluster2-worker1:/home/dcn# journalctl -fu kubelet
-- Logs begin at Wed 2021-03-03 06:22:44 UTC. --
Mar 26 12:53:51 cluster2-worker1 kubelet[2670]: I0326 12:53:51.050450    2670 kuberuntime_manager.go:841] Should we migrate?Runningfalse
...
root@cluster2-worker1:/home/dcn# containerd --version
WARN[2021-03-26T12:56:39.392192110Z] This customized containerd is only for CI test, DO NOT use it for distribution.
containerd github.com/containerd/containerd e5ffc7a4-TEST


Rebuild media library with virtual list for Masonry Layout

Feature Description
Using a library like react-virtualized or react-window, rebuild the media library to use a virtual list. Virtual list have some key performance improvements over infinite scroll style loading of media.
Virtual list would still required the masonry layout with variable height images / video in two columns. The media library would also need to remain accessible, with keyboard navigation.
Feature Brief
Design

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Choose a library to use
The library should allow files in the media library to utilize a masonry layout
Once a library is decided on, we will need to regroup to decide how to proceed. (Meeting setup or document with info shared)

QA Instructions

Other libraries I have found in my research.
https://github.com/clauderic/react-tiny-virtual-list
https://github.com/developerdizzle/react-virtual-list
However, I believe we have to roll out own version of one of these libraries.

Reposting from the Slack:
Small prototype: https://codepen.io/dvoytenko-the-flexboxer/pen/bGVBjrZ
Not fully a virtual list, but this idea can be combined with a virtual list if desired.
The structure is:

...

...

Importantly, the group has a strict height and it also has contain: layout size  (but not paint). And thus, the contents of a group can be cleared out at any time we want.
Thus, the cost of this demo is numberOfRecords / groupSize. Not exactly a virtual list, but for numberOfRecords 10K, and a groupSize of 100, we need 100 divs.
An additional beneficial nuance: only the relative height calculation are done. Thus this approach is semi-responsive. It only needs a single value of the target cellWidth to rerender correctly. No recalculations need to be done since they do not depend on absolute values.

With the performance improvements that Clint is working on, this may not be needed anymore. Additionally, are there use cases where the user would scroll through thousands of images instead of using the search box?

Attaching: this thread is pretty essential. We'll have a whole new layout (not sure if in Beta).

are there use cases where the user would scroll through thousands of images instead of using the search box?

I think the virtual list solves other problems (other than context performance improvements will), one of them is not to load 100 or 200 images right away (loading="lazy" needs more browser support).

I'm leaving this issue for Media Pod.
Whoever will continue to work on the virtual list in new layout - feel free to ping me.
I tested all libraries mentioned on Slack and none of them is using a virtual list, so it looks like we still want to create something of our own (and use something like https://github.com/flickr/justified-layout for calculations).

With the performance improvements that Clint is working on, this may not be needed anymore. Additionally, are there use cases where the user would scroll through thousands of images instead of using the search box?

There's a UX component to this, and the new UI/layout (Masonry) is the approved UI moving forward. So this work still needs to be done. I'd say, not crucial for the Beta, good to have it for Stable.

pulling this out of S32 as this item is in icebox

This seems obsolete with the new media picker, closing.


Joystick callbacks or make joystick input polling available to other threads

Hello. We have a problem with input polling where at low frame rates joystick polling is done at such a low frequency that button presses are missed. The documentation specifically disallows calling the polling methods from other threads, which would solve the problem as I could just poll joysticks at a much higher rate from another thread at even intervals independent of frame rate. Alternatively, joystick callbacks would work too.

I'm reworking some joystick internals in 3.2 and will look into this.

Exciting :clap:

There will also be a joystick callback added in 3.2 but it has nothing to do with this issue; it's for reporting device connection and disconnection events analogous to the monitor callback.

If i may piggy back on this issue: on Windows, all gamepads are reported to have the same generic driver name. It would be awesome if the 3.2 rewrite would fix this, otherwise it's impossible to select mappings for say Xbox or PS3/4 controllers. I'm happy to send hardware if needed!

The joystick callback is ready for use in the dekdevy branch. The only reason it hasn't been merged yet is because DirectInput support isn't done.

@badlogic I will look into getting better controller names for 3.2. Thank you for the offer of hardware! I may take you up on that when I start on the remapping work for more SDL2-ish input.

@badlogic XInput with DirectInput fallback has been merged, which should have improved the returned device names.

Any progress on the buffered data/event-based DirectInput implementation?

@httpdigest Not yet, have to get 3.2 out first.

If you need help with this, I have experience with implementing joystick drivers in the Allegro5 project, so I am willing to contribute. Downstream of GLFW, Ebiten stands to gain much from this feature.

Seeing that people are encouraging me, I'll take this up and work on a PR. Might take me some time though...

It's going well actually, most code was already in place. Now to test it.

Too bad, there are problems with the fact that GLFW uses active polling for joystick input. I'll probably have to add something in the event polling and waiting, but it looks like it won't be easy to fix it. Suggestions are welcome.

Aha, I got it to work, at least on Linux! Perhaps it works on other platform, I could not test that. Could some other volunteers test it with tests/event on other platforms?

@elmindreda, sorry to ping you, but could you please comment on my PR, and see if I am going in the right way? Thanks!

sorry to complain but any news on this? The PR has been open for 2 years.

@beoran I think the sad reality is that GLFW is essentially a one-person project. And keeping up with ever-changing platforms probably takes enough time already...

Well, I would hope someone would step up to the plate. Or is there a crowd funding I could contribute to?

Off topic: Honestly if GLFW is a one person project, it should be handled like Imgui. If big enough companies are using it they should sponsor its development.


Improve adb output handling to ignore warning lines

Addresses #5928 by filtering out adb output lines beginning with "adb: "

🎉