Terragrunt Hangs Waiting for User Input in CI if the Remote State Backend S3 Bucket is Not Accessible

Describe the bug
When using an AWS S3 remote state backend and running Terragrunt within a non-interactive CI process, if the S3 bucket is not accessible for some reason (wrong credentials/permissions, doesn't exist yet etc) the Terragrunt process will hang waiting for user input that can never be given, with the message:
Remote state S3 bucket <BucketName> does not exist or you don't have permissions to access it. Would you like Terragrunt to create it? (y/n)

Expected behavior
Terragrunt should either detect that it is running within a CI environment (normally env var CI is set) or have another CLI option to not prompt to create the bucket, but just fail.
Versions

Terragrunt version: v0.46.1
Terraform version: v1.4.6

Hi,
Terragrunt was running with --terragrunt-non-interactive option?

Same problem here, we're currently running an atlantis pipeline, and the plan check just freezes because terragrunt still waits to press Y in the console.
+1

hi @denis256, how are you doing? If we pass the --terragrunt-non-interactive flag, I get an error saying the bucket already exists, we previously have created the buckets in all AWS accounts.

Ran into something similar where in CI terragrunt would inconsistently prompt me when running destroy and hang, no combination of flags worked i.e --terragrunt-non-interactive or --terragrunt-ignore-external-dependencies even when set in environment variable format
Module /tmp/build/ee04e91f/terragrunt/clients/client/environments/dev/components/component depends on module /tmp/build/ee04e91f/terragrunt/client/bamboo/environments/dev/components/project, which is an external dependency outside of the current working directory. Should Terragrunt run this external dependency? Warning, if you say 'yes', Terragrunt will make changes in /tmp/build/ee04e91f/terragrunt/clients/client/environments/dev/components/project as well! (y/n)

Ended up going with this hack
echo "n" | terragrunt destroy . . .

I will look into

Added new CLI argument/environment variable in https://github.com/gruntwork-io/terragrunt/releases/tag/v0.48.4

Thanks for this @denis256. I think the description for the new terragrunt-fail-on-state-bucket-creation argument is not quite right though. It is currently:

When this flag is set, Terragrunt will wait for execution if it is required to create the remote state bucket.

Where it should be something like:

When this flag is set, Terragrunt will fail and exit if it is required to create the remote state bucket.


"No results found" with Pleroma instance

Not 100% sure it's the cause, and I know Pleroma ≠ Mastodon, but FYI I get:

ℹ  No results found. Please double check for typos in the handle, and ensure that you follow at least a few people to seed the search. Otherwise, try again later as Mastodon may throttle requests.

Searching<EMAIL_ADDRESS>which is a Pleroma instance: https://nado.social/

Same thing on my Pleroma instance.

Fails for https://pleroma.debian.social/ too.


fix(ui-markdown-editor): quotes button working

Signed-off-by: Gatij Taranekar<EMAIL_ADDRESS>

Closes #255

Changes

 Wrapped the selected text around a q tag.

Screenshots or Video

https://www.loom.com/share/1757da27eb7c42349c785e3b53506a9e
Author Checklist

[ ] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[ ] Vital features and changes captured in unit and/or integration tests
[ ] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to master from fork:branchname
[ ] Manual accessibility test performed

[ ] Keyboard-only access, including forms
[ ] Contrast at least WCAG Level A
[ ] Appropriate labels, alt text, and instructions

Your fix works, but I don't understand why we need both <blockquote> and <q> tags.
My understand is that <blockquote> should be used for quoted paragraphs, while <q> is for shorter inline quotes.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/q
It feels like this could be a css issue with the <blockquote> tag.
https://css-tricks.com/examples/Blockquotes/
Could you please investigate whether we can apply css to the <blockquote> tag to fix this, rather than wrapping everything in <q>?

@dselman I have added Css to the blockquotes and deleted the q tag.
https://www.loom.com/share/ba4f2ae08be648d6bcc01ac9a53a4f7b


Bad indentation when using try..finally

Hi! It's me again, this time with more pasta edge cases!
When I run the following Python 2 code:
import ast
import pasta

source_code = '''
try:
    if 1:
        a=1
finally:
    a=1
'''

class SampleTransformer(ast.NodeTransformer):
    def visit_If(self, node):
        node.body = [ast.Pass()]
        return node

tree = pasta.parse(source_code)
SampleTransformer().visit(tree)

print pasta.dump(tree)

The expected output of it should be
try:
    if 1:
        pass
finally:
    a=1

But the output is this instead:
try:
    if 1:
    pass
finally:
    a=1

This produces a SyntaxError in the rewritten code.
If I change the code of the visit_TryFinally function in pasta/base/annotate.py to use self.indented(node, 'body') instead of node.body, the previous example works ok. However, when I run the test suite, there are six failing tests so I suppose there has to be a better way to fix this.

Thanks for finding this and giving a detailed report! Made it a lot easier to fix with this as a starting point.
Thanks!

Thanks to you for the super fast response time! It's working OK now.


configurable home/end behavior

I am very used to using home and end to jump to the start and end of a line, with ^ making it file wide. I think this is standard everywhere except mac? It really messes with my muscle memory when I'm typing in decker.

This sounds like it would be the first instance of a configurable, persistent setting for Decker. It's certainly possible, but it's unclear to me where best to track such information, and whether there's a reasonable way to have parity in web-decker with native-decker in this respect.
If this were implemented, perhaps other things could also be preserved:

Toolbar visible/hidden?
Grid overlay dimensions?
Default document path?

After some thought, I've decided to simply change the behavior rather than introduce options.


Cursor color issue

My cursor is set to black in the "Style Settings" plugin (which applies globally), which is normal in normal document editing mode. However, if I set the current code block color to dark in the "Codeblock Customization" plugin, a fatal issue arises: in code block editing mode, this will cause me to not be able to see the cursor. I hope the author can add an option to modify the cursor color (which only applies to the code block), instead of controlling it through external global control

Can you show me how exactly did you set your cursor to black in "Style Settings" plugin, so I can reproduce the problem?

The "Blue Topaz" theme I am using is the cursor color I set in this plugin. The default cursor color for dark mode is white, and for light mode it is black. It will take effect globally (including code blocks)

Just a quick question. Are you using the latest version from the Style Settings plugin and the Blue Topaz Theme? I just installed both, and it looks like this on my machine:

The whole line is black, not just the cursor:

Sorry, may this be a design issue? In the light color theme, if I use your plugin to set the current code color, it must be set to light color so that the cursor black is visible. Conversely, in the dark theme, set it to dark color so that the cursor white is also visible

Could you try the following out?

Create a new Vault
Install the latest updates from the Blue Topaz Theme, and from the Style Settings plugin
Don't apply any custom CSS, and don't install any other plugin.

Does the problem still exist this way?

Hello, I did as you said. I created a new library and only installed the BT theme and the Style Settings plugin. The cursor can display colors normally, but you said your cursor cannot display colors. How do you know which position you edited when writing the code? This will look very strange

But no matter what, my cursor can display colors normally. If I install the Codeblock Customizazer plugin, it will affect the background color and line color, but the code style and cursor are still controlled by the `Style Settings' plugin

I am lost here.
"The cursor can display colors normally, but you said your cursor cannot display colors." - When did I say that the cursor cannot display colors?
"How do you know which position you edited when writing the code?" - The active line has the cm-active class
I have no idea what settings you made. I can't reproduce the issue. Either send screenshots with your Obsidian set to English, so I can read the actual text, or send me your config. As I see, you can export your settings from the Style Settings plugin. Both would probably be better. You should also send me your data.json file <PathToYourVault>\.obsidian\plugins\codeblock-customizer\data.json.


[BUG REPORT] Good Morning/Night Reactions acting Weird

Please Describe Your Issue
According to Alex, good morning/night emoji reacts are being added to the responses rather than the initial message containing the phrase.
How to Reproduce
Send "good morning" or "good night" and have someone send a message either.
Expected behavior
Emoji react is supposed to go to the earlier message.
Discord Information
Not Discord client related.
Extra Context

Not a bug, a misunderstanding of how the feature actually works


Does all multi displays users have the menu bar icons redraw bug ?

Hi,
As chunkwm requires the option "displays have separate spaces", I was wondering if some others users have the menu bar icons redraw bug when switching monitors:
.
This bug is annoying and introduces a lot of lag (1 to 3s).
This post on stack exchange seems to indicate it was present in Yosemite, but should have been resolved since.
I run High Sierra with a MBP 2016 15" with discrete card.
If someone knows how to get rid of this... or can tell me that I am not the only one suffering of this :)

I close this as not related to chunkwm. Thanks for having let the post open.
It looks like this is related to swap increase. At the end of the day I have a huge swap usage even if the memory pressure remains low, and things are getting more and more laggy.
I was used to sleep my MBP and never reboot it, now I reboot it twice a day... :(


Update image links for NFS

This PR updates image links for NFS plugin deployment
to support CSI 0.2.0.

@sbezverk @rootfs


Attempting to create elements and reference them between init and render causes circular references in the panel json

Fix is to move transient state to a new context object that's passed between the init and render functions

The problem here is that if you try to store an SVG.js node in options it causes a circular reference error that makes it so that Grafana can no longer serialize the panel settings.  When this happens you can't save the panel any more, nor can you view the panel JSON.
One idea to fix this was to add a separate 'context' or 'state' parameter that would be passed into the user's panel initialization script as an empty object.  The user could then add whatever they wanted to this object, and it would in turn be passed to subsequent invocations of the rendering script.
This would work, but may be unnecessary.  As @acedrew points out, you can also hang your arbitrary state off of svgnode, as long as you don't interfere with svgnode.  That means not naming your additions dom, events, node, or type ... but because svgnode is a more deeply nested object than that, you also have to avoid any names by anything else in the SVG.js hierarchy of objects.
Options:

We can just change the docs and instruct people to have their data off of svgnode

svgnode.state = {
     a = 1, o = someObj
}

then add that to the docs and change the example

We can go ahead and add a separate 'state' or 'context' parameter, as the initial ticket proposes, then just be very careful to store it a place where grafana itself won't see or mess with it.

I am leaning toward option 2, and naming it 'context' rather than 'state', even though it's slightly more work than option 2.  I think it's a little safer, because it eliminates the chance of someone doing something in their script that stomps on svgnode.

Thinking more about this, blowing up peoples dashboard json is a really bad thing to do, I wonder if there's a way to check for circular references in options prior to handing them off to grafana and just dropping any root node in the options that points to a circular relationship


Adding builder embed tracker

For TrackJS and GAnalytics.
cc @luisbosque @beloneys
Fixes https://github.com/CartoDB/cartodb/issues/8433

CR: @javitonino


ci: Test with Python 3.12

Codecov Report
Patch and project coverage have no change.

Comparison is base (9e5d28c) 85.12% compared to head (d591e59) 85.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   85.12%   85.12%
=======================================
  Files          29       29
  Lines        3631     3631
=======================================
  Hits         3091     3091
  Misses        540      540

Flag
Coverage Δ

cpp
85.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

OK, this should be ready to be reviewed. The way I'm avoiding publishing the 3.12 wheels is hacky, but I don't see a non-hacky solution, and I manually tested that it works by forcing the upload_pypi stage to run and to skip the actual wheel publishing.


App crash on iOS 17 in Flutter add-to-app

[x] I have read the Getting Started section
[x] I have already searched for the same problem

Environment

Technology
Version

Flutter version
3.13.6

Plugin version
flutter_inappwebview: ^5.8.0

Android version

iOS version
17

macOS version
13.6

Xcode version
15

Device information: iPhone 15 Simulator (iOS 17)
Description
I have built a flutter module and using add-to-step option B, I have build ios-frameworks that I am using in my iOS project. Everything works fine (along with 10 other plugins) but the app crashes as soon as I click on the button that executes the below code.
Expected behavior:
The following code crashes the app in an add-to-app flutter module.
final ChromeSafariBrowser browser = MyChromeSafariBrowser();

                                  browser.open(
                                    url: Uri.parse(
                                          "my-url-here"
                                         ),
                                    ,
                                    options: ChromeSafariBrowserClassOptions(
                                      ios: IOSSafariOptions(
                                          // presentationStyle: IOSUIModalPresentationStyle.AUTOMATIC,
                                          ),
                                      android: AndroidChromeCustomTabsOptions(
                                        isSingleInstance: true,
                                        instantAppsEnabled: true,
                                      ),
                                    ),
                                  );

Current behavior:
The app just crashes as soon as the code is executed. It does not give any error message. Here are the screenshots for XCode.
Swift/Optional.swift:247: Fatal error: unsafelyUnwrapped of nil optional

Steps to reproduce

Build flutter module using flutter build ios-framework
Add to iOS app
Run iOS app and try to launch the Chrome Safari InappBrowser

Upon further deep dive, I have found actual line of code that is causing the crash. In ChromeSafariBrowserManager.swift, the following code is crashing.
if let flutterViewController = UIApplication.shared.delegate?.window.unsafelyUnwrapped?.rootViewController {

Basically, the window object is null.
Could this be due to the fact that my app is built using SwiftUI?


Publish manylinux wheel for Python 3.10

Wheels are available for Python 3.7 to 3.9 on PyPI, but not for Python 3.10. Manylinux1 probably isn't suitable, but manylinux2014 wheels can be produced pretty trivially in the docker://quay.io/pypa/manylinux2014_x86_64 container:
/opt/python/cp310-cp310/bin/pip wheel --no-deps raysect==0.8.1
auditwheel repair raysect-0.8.1-cp310-cp310-linux_x86_64.whl

This would greatly speed up installation (including for CI runs of dependant packages like Cherab) on Python 3.10.

Done: manylinux2014 wheels for Python 3.10-3.12 uploaded to PyPI, in addition to the existing manylinux1 wheels for 3.7-3.9.


Build x64 and x86 versions of site extensions with 2.1 in name

https://github.com/aspnet/AzureIntegration/issues/164

Ping.


Automatically open applications on specific workspaces

Hi, thanks for making this I've been using cortile for about 6 months now and have been loving it!
For me the last feature for a perfect setup on linux coming from macOS would be to set applications to open on a specific workspace. I see that i3 supports this but I still want to use regular xfce with cortile.
Keep up the awesome work 💪
Reference: https://i3wm.org/docs/userguide.html#assign_workspace

Cortile already remembers the last window state and screen position (see #22, #44).

For me the last feature for a perfect setup on linux coming from macOS would be to set applications to open on a specific workspace.

It would be very easy to change the existing implementation so that it also remembers the last workspace of a window class, without having to "blow up" the existing cortile config.toml file.
However, I am not sure whether this behavior is desirable, as several identical applications (e.g. file browsers) may be intentionally opened across several workspaces.
In the future, however, there will be a possibility to use custom scripts that allow windows to be assigned to a desired workspace based on one or more predefined rules.

This task should now be feasible. Please review cortile-addons and #65.


Make consistent with #1141

In #1141, Node#depthFirst was modified to use Boolean#parseBoolean instead of Boolean#valueOf (here), but its similar method, Node#breadthFirst was not.
I modified the method to make consistent with the change.

Merged, thanks!


[Bug]: Page over burdened

What happened?
Suddenly Civitai is overburdened with a lot of jank time, and slow loading. Additionally, scrolling is no longer smooth. It's very jerky/stuttery.
Checking online, the site gets a performance score of C or D (and fluctuating, whether server performance or scripting performance), which ain't good.
One of the biggest factors is the image delivery. It's using cookies, which is unnecessary traffic as the server will ignore them. Need a proper CDN or a subdomain distributor that is cookie-free.
Setup:
Core i9 13900KF (Up to 5.8Ghz Boost)
32GB 5600MHz DDR5
SN570 NVMe 1TB (OS Drive)
Steps to reproduce the problem

Visit the site

What should have happened?
Site should be much more responsive and smooth.
What platforms do you use to access the site?
Windows
What browsers do you use to access the site?
Mozilla Firefox
Additional information, context and logs
Thins were smooth yesterday, despite all the downtime. 🤷

Hey @WASasquatch Thank you for taking the time filing this issue. I was experiencing the same behavior you mentioned yesterday, but it's not happening anymore. Can you please confirm site is loading okay for you now?

Yeah it seems things are fixed now. Page scrolls smoothly. There is still a lot of initial jank on page load. On my machine it uses a lot of resources initially, I'm not sure if that's just cause my machine has the resources to spare, or if it's really wanting that sort of environment. If that is the case though it could hit mobile devices or weak computers with less RAM pretty hard or crash the device.
That all being said, at least most people utilizing these are on decent systems aside from the colab users.
But perhaps the modules could be spaced out a bit in their initialization on page load. It seems they're all being thrown at the the browser at once.


[Request] Higurashi When They Cry

This game has multiple chapters first chapter is available for free on steam and gog
https://store.steampowered.com/app/310360/Higurashi_When_They_Cry_Hou__Ch1_Onikakushi/
https://www.gog.com/en/game/higurashi_when_they_cry_hou_ch1_onikakushi

Also asking. Can supply the game's actual scripts for Ch.1 and 2 if required.


[BEAM-4775] move MonitoringInfo protos to model/pipeline module

In preparation for job api, fn api, and sdks/java/core to all use MonitoringInfos
R: @robertwb, @ajamato
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Correct.
In a few cases (example) I removed a BeamFnApi.Abc with a direct import of Abc, as well, where it seemed cleaner.

I think this can go in @robertwb, if my response above sgty.


New version: AppbyTroye.KoodoReader version 1.5.0

Result: Installation Failed

Manifest
Add/Remove Programs

Name
Koodo Reader

Version
1.5.0

Publisher
App by Troye

ProductCode

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 3987
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Add Webtoon Indonesia daily ticket

Source name
Webtoon
Source language
Indonesia
Describe your suggested feature
Webtoon Indonesia recently add new feature called daily ticket. If you login via browser new chapter not showing (see attached image) and only showing if you login via webtoon app. New chapter can be unlocked using daily ticket ( 1 ticket will be available,reload everyday at 21:00 GMT+7)
Daily ticket can't be used to unlock 14 latest chapter
Chapter unlocked using daily ticket will be available for 14 days
Other details

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I have updated the app to version 0.15.3.
[X] I will fill out all of the requested information in this form.

The extension uses the website, if they don't show up on the site then nothing we can do. We won't be using the app API.


Reconnect bug

After connecting to Windows using wfreerdp, open Micrsoft Edge, then close the connection and reconnect. It was found that Micrsoft Edge cannot be opened

and this is a FreeRDP bug because?

and this is a FreeRDP bug because?
But using mstsc.exe to connect and perform the same operation will not cause this problem，The first time you connect, you can open the browser. However, after disconnecting and reconnecting, opening the browser fails.

@may520java are you using remote application mode aka rails (/app)?

if not then everything within the session can not be influenced by the RDP client.
windows RDP servers open multiple sessions for a user, so maybe the test you did was one session reconnect and another new session? (task manager allows showing you the active sessions/logged in users, but not all windows versions support that, don´t ask me which ones these are ;))
also, is only edge affected? if other applications work fine it is another indication that it is not RDP client related.

@may520java are you using remote application mode aka rails (/app)?

if not then everything within the session can not be influenced by the RDP client.
windows RDP servers open multiple sessions for a user, so maybe the test you did was one session reconnect and another new session? (task manager allows showing you the active sessions/logged in users, but not all windows versions support that, don´t ask me which ones these are ;))
also, is only edge affected? if other applications work fine it is another indication that it is not RDP client related.

You're right, it's true that only Edge has this issue. I changed to a Windows version and it doesn't exist anymore. Thank you.


Python 3 support

Python 3 support and the testsuite now also passes.

Nice patch. Thanks!

Released in 0.9.1


repository structure

Hi again!
I've kept playing with all the amazing models you're collecting in the zoo repository, but lately, as the repository keeps growing, it's becoming more difficult to find models.
I would like to suggest you to reorganize the repository so it's arranged as themes
So far I would suggest these root repositories:

Artistic
Face Detection
Hand Detection
Body Pose Detection
Object Detection
Depth from monocular images
Misc

That way it would be easier to find and compare different models...

I've categorized the models to make them easier to find.


MINOR: add retry to state dir locking

There is a possibility that the state directory locking fails when another stream thread is taking long to close all tasks. Simple retries should alleviate the problem.

@guozhangwang, would you take a look?

LGTM (magic numbers may work just fine for now, and if not moving forward let's revisit). Merged to trunk.


Getting correct image tags into prod accounts for bundles

Signed-off-by: jonahjon<EMAIL_ADDRESS>Description of changes:
Moving correct images/helm charts to prod account for prod bundle prep.

/lgtm


Wrangler plugin e2e tests.

Wrangler plugin e2e tests.

Try removing wrangler-core from the workflow module config, wrangler-transform has a dependency on wrangler-core anyways

Github actions build is currently failing as these tests require new steps in the cdap-e2e-tests repository. Once these new steps are merged in the framework repository then the Wrangler tests would be executed again.
PR link for the cdap-e2e-tests: https://github.com/cdapio/cdap-e2e-tests/pull/193

closing pull request as new PR is raised for Wrangler directives.


GitHub Workflow to publish development docker images to ghcr.io

Note this is based on #172
For many projects, it can be useful to have pre-built images that can be quickly pulled down to spin up a project.
For example, if the UI/UX team is helping fix a bug or implement new front-end code, having prebuilt images that can spin up the application using the override included in {{ cookiecutter.project_slug }}/docker-compose.override.no-build.yml as:
docker compose -f docker-compose.yml -f docker-compose.override.yml -f docker-compose.override.no-build.yml up

Will make it much faster/easier for external collaborators to spin up the application.
An additional use case is when there is a VueJS based front-end application that has a different development team than the backend Girder4 project - in these scenarios, it will also be helpful for that team to be able to pull the latest pre-built images as needed rather than building themselves.

Thanks for the thoughtful consideration, @brianhelba! In review/hindsight, I agree with your take that this adds significant complexity and is a frivolous tradeoff between CPU time and download time for most projects. For these reasons, I am closing this PR
n the case of ResonantGeoData (a project with a large dependency stack), this is a huge help - but I realize that most projects have a much lighter stack and will not gain much if any benefit from this workflow all while eating up CI execution time.

Maybe a good solution is to publish this technique somewhere, and let projects adopt if their build times eventually get too long?

I have currently published this technique internally (I can share link internally), but I believe it would be useful to share publically as well. I have a few thoughts on where/how which we should discuss internally.


Layout issue of icon inside AhoyOnboarderCard

The icon is not vertically centered at all.
It seems that the AhoyOnboarderCard cannot handle Landscape mode when the orientation is changing.

Also issues with icons not scaling with small screens.


RC-Research Test: Molecule Polarity 1.1.0-rc.2

For https://github.com/phetsims/molecule-polarity/issues/87
@KatieWoe, @kathy-phet, @arouinfar, molecule-polarity/1.1.0-rc.2 is ready for RC-spot-check testing.   See "Issues to Verify" for the issues to be spot checked.
This test will involve the PhET-iO version only.  A link to an RC version will be delivered to the researcher collaborator by 4/2/21.
Document issues in https://github.com/phetsims/molecule-polarity/issues and link to this
issue.
Assigning to @kathy-phet and @KatieWoe for prioritization.

PhET-iO RC Test

What to Test
This is a spot check, and required very limited/specific testing.  See instruction in the individual issues listed in "Issues to Verify" for what needs to be tested.

Platforms and Browsers to Be Tested
See instructions in the individual issues listed in "Issues to Verify".

Issues to Verify

[ ] https://github.com/phetsims/molecule-polarity/issues/106
[ ] https://github.com/phetsims/molecule-polarity/issues/107
[ ] https://github.com/phetsims/molecule-polarity/issues/109

See the last comment in each of these issues for instructions on what and how to test.
These issues are labeled "status:ready-for-qa". Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue.

Link(s)

Wrapper Index: https://phet-dev.colorado.edu/html/molecule-polarity/1.1.0-rc.2/phet-io

Record Wrapper link:
https://phet-dev.colorado.edu/html/molecule-polarity/1.1.0-rc.2/phet-io/wrappers/login/?wrapper=record&validationRule=validateDigits&numberOfDigits=8&phetioEmitStates=true&phetioEmitStatesInterval=60

Record to a local file:
https://phet-dev.colorado.edu/html/molecule-polarity/1.1.0-rc.2/phet-io/wrappers/login/?wrapper=record&validationRule=validateDigits&numberOfDigits=8&phetioEmitStates=true&phetioEmitStatesInterval=60&localFile

Metacog recording (You need to add usual Metacog-testing query parameters.):
https://phet-dev.colorado.edu/html/molecule-polarity/1.1.0-rc.2/phet-io/wrappers/login/?wrapper=record&validationRule=validateDigits&numberOfDigits=8&phetioEmitStates=true&phetioEmitStatesInterval=60

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

[ ] Win 10 Chrome (Time = )
[ ] Win 10 Firefox (Time = )
[ ] MacOS 11 Safari (Time = )
[ ] MacOS 11 Chrome (Time = )
[ ] iPadOS (Time = )
[ ] ChromeOS (Time = )

QA is done

Thank you @KatieWoe and QA team for the quick turnaround.
#113 does not need to be addressed for https://github.com/phetsims/molecule-polarity/issues/87.  So the QA cycle is complete, and we're ready to deliver this RC version to the research collaborator.
Closing.


Does sourcery scan code like SwiftKitten ?

How does sourcery scan the code - using AST ?
Can it extract all artifacts, such as method names and bodies, vars, etc ?
Thanks !

it uses SwiftSyntax so yes

Does using SwiftSyntax provide the artifacts from a file, such as function bodies, variables, etc .?

it can but I don't want Sourcery to scan bodies of functions, it's meant to focus on AST


TypeError: '<' not supported between instances of 'NoneType' and 'float

Upon launching on Python 3.8.6 using this package version 2.0.2, the follow error is generated:
  File "/usr/local/bin/pg_activity", line 296, in <module>
    ui.main(term, dataobj, host, options, dsn)
  File "/usr/local/lib/python3.8/site-packages/pgactivity/ui.py", line 215, in main
    views.screen(
  File "/usr/local/lib/python3.8/site-packages/pgactivity/views.py", line 501, in screen
    processes.set_items(sorted_processes(processes, key=ui.sort_key, reverse=True))
  File "/usr/local/lib/python3.8/site-packages/pgactivity/activities.py", line 194, in sorted
    return builtins.sorted(
TypeError: '<' not supported between instances of 'NoneType' and 'float

Thanks for the report. In order to investigate, I'll need more information:

what postgresql version are you using?
are you running pg_activity using the "postgres" user (or the user running the postgresql server)?
can you share the command-line and arguments used to launch pg_activity?

Thanks for the report. In order to investigate, I'll need more information:

what postgresql version are you using?
are you running pg_activity using the "postgres" user (or the user running the postgresql server)?
can you share the command-line and arguments used to launch pg_activity?

I released a version 2.0.3 fixing (hopefully) this issue; it's available on PyPI. Thanks for the report.

I released a version 2.0.3 fixing (hopefully) this issue; it's available on PyPI. Thanks for the report.

@dlax that seems to have fixed the issue. Thanks!

@dlax that seems to have fixed the issue. Thanks!


Evaluate Taverna

http://www.biomedcentral.com/1471-2105/13/77

http://www.taverna.org.uk/

Far from being dead, Taverna is now an Apache Incubator project.
http://taverna.incubator.apache.org/

It's huge, like really huge.  It might be good, it might be big a train wreak.  It would be a large amount of work to even figure this out.  It has no special support for clouds or the spot market.  Standard virtual cluster stuff.
It vastly exceeds our needs and we should not invest in it.


[2.0] handle invalid sessions more user friendly

if the session is not valid anymore, show this information to the
user, and redirect him to the login instead of failing badly
we dont need to raise in the stored_nonce method, as a failed
deletion from the session hash will result in a nil value, meaning
a non matching nonce
Signed-off-by: Maximilian Meister<EMAIL_ADDRESS>(cherry picked from commit e7d877f6a27403bbc1357150f477891ca225f793)
backporting https://github.com/kubic-project/velum/pull/328

 Bug 1066371 - Warning message is displayed for split second


[BEAM-168] IntervalBoundedExponentialBackOff: add deprecated copy of old API

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[X] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[X] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[X] Replace "<Jira issue #>" in the title with the actual Jira issue
number, if there is one.
[X] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

This fixes a bug submitting jobs to Google Cloud Dataflow service.

R: @dpmills @davorbonaci @bjchambers

LGTM

Travis passed; merging now.


Fixed #25316 -- Fixed using order_by() and values() after annotate().

In reference to ticket https://code.djangoproject.com/ticket/25316 .

Please try to add tests in tests/expressions/tests.py instead of in a new test app. It's better to reuse existing models if possible as adding more models increases the complexity and execution time of the test suite.

Rather, there's already a tests/expressions_case/tests.py that could be used that already has the model you're writing tests against. You should move the tests into that file.

Sorry for that.will keep that in mind.
Added the tests to the tests/expressions/tests.py using the existing models.

Could you try to follow the style of the other tests and clean up the code a bit? See the flake8 and isort errors, remove the commented out print statements, etc.

Hi,I made all the changes you suggested.
I ran flake8 on my command line ,but no errors came up.The line it is showing the error was not even part of any changes I made.Further I'm unable to find the error it is suggesting.The error shown is:
./django/db/models/expressions.py:761:31: E231 missing whitespace after ','
Other than that,all other tests pass.I changed the coding style in accordance with other tests.Will keep that in mind in the future.

Could you please squash your commits when updating and use the message from the pull request's title?

buildbot, add to whitelist.

Haven't squashed commits before.Please give me a while to figure it out.

Squashed the commits .Please check.

Hi,Fixed the .idea directory.I'm sorry I'm taking time to getting adjusted to the git workflow.Will take care of the following in the future.
Please review

I think it's fine to backport considering it's a crashing bug with a valid use case.

Would like to include this in today's release, so updated in https://github.com/django/django/pull/5916.


UnicodeDecodeError: 'ascii' codec can't decode byte 0xe5 in position 213: ordinal not in range(128)

Describe the bug
Error "UnicodeDecodeError: 'ascii' codec can't decode byte 0xe5 in position 213: ordinal not in range(128)" is thrown when downloading dataset.
Steps to reproduce the bug
from datasets import load_dataset
datasets = load_dataset("nielsr/XFUN", "xfun.ja")

Expected results
Dataset should be downloaded without exceptions
Actual results
Stack trace (for the second-time execution):
Downloading and preparing dataset xfun/xfun.ja to /root/.cache/huggingface/datasets/nielsr___xfun/xfun.ja/0.0.0/e06e948b673d1be9a390a83c05c10e49438bf03dd85ae9a4fe06f8747a724477...
Downloading data files: 100%
2/2 [00:00<00:00, 88.48it/s]
Extracting data files: 100%
2/2 [00:00<00:00, 79.60it/s]
UnicodeDecodeErrorTraceback (most recent call last)
 in
1 from datasets import load_dataset
2
----> 3 datasets = load_dataset("nielsr/XFUN", "xfun.ja")
/usr/local/lib/python3.6/dist-packages/datasets/load.py in load_dataset(path, name, data_dir, data_files, split, cache_dir, features, download_config, download_mode, ignore_verifications, keep_in_memory, save_infos, revision, use_auth_token, task, streaming, **config_kwargs)
/usr/local/lib/python3.6/dist-packages/datasets/builder.py in download_and_prepare(self, download_config, download_mode, ignore_verifications, try_from_hf_gcs, dl_manager, base_path, use_auth_token, **download_and_prepare_kwargs)
604         )
605
--> 606         # By default, return all splits
607         if split is None:
608             split = {s: s for s in self.info.splits}
/usr/local/lib/python3.6/dist-packages/datasets/builder.py in _download_and_prepare(self, dl_manager, verify_infos)
/usr/local/lib/python3.6/dist-packages/datasets/builder.py in _download_and_prepare(self, dl_manager, verify_infos, **prepare_split_kwargs)
692         Args:
693             split: datasets.Split which subset of the data to read.
--> 694
695         Returns:
696             Dataset
/usr/local/lib/python3.6/dist-packages/datasets/builder.py in _prepare_split(self, split_generator, check_duplicate_keys)
/usr/local/lib/python3.6/dist-packages/tqdm/notebook.py in iter(self)
252         if not self.disable:
253             self.display(check_delay=False)
--> 254
255     def iter(self):
256         try:
/usr/local/lib/python3.6/dist-packages/tqdm/std.py in iter(self)
1183             for obj in iterable:
1184                 yield obj
-> 1185             return
1186
1187         mininterval = self.mininterval
~/.cache/huggingface/modules/datasets_modules/datasets/nielsr--XFUN/e06e948b673d1be9a390a83c05c10e49438bf03dd85ae9a4fe06f8747a724477/XFUN.py in _generate_examples(self, filepaths)
140             logger.info("Generating examples from = %s", filepath)
141             with open(filepath[0], "r") as f:
--> 142                 data = json.load(f)
143
144             for doc in data["documents"]:
/usr/lib/python3.6/json/init.py in load(fp, cls, object_hook, parse_float, parse_int, parse_constant, object_pairs_hook, **kw)
294
295     """
--> 296     return loads(fp.read(),
297         cls=cls, object_hook=object_hook,
298         parse_float=parse_float, parse_int=parse_int,
/usr/lib/python3.6/encodings/ascii.py in decode(self, input, final)
24 class IncrementalDecoder(codecs.IncrementalDecoder):
25     def decode(self, input, final=False):
---> 26         return codecs.ascii_decode(input, self.errors)[0]
27
28 class StreamWriter(Codec,codecs.StreamWriter):
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe5 in position 213: ordinal not in range(128)
Environment info

datasets version: 2.0.0 (but reproduced with many previous versions)
Platform: Docker: Linux da5b74136d6b 5.3.0-1031-azure #32~18.04.1-Ubuntu SMP Mon Jun 22 15:27:23 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux ; Base docker image is : huggingface/transformers-pytorch-cpu
Python version: 3.6.9
PyArrow version:   6.0.1

Hi @andreybond, thanks for reporting.
Unfortunately, I'm not able to able to reproduce your issue:
In [4]: from datasets import load_dataset
   ...: datasets = load_dataset("nielsr/XFUN", "xfun.ja")

In [5]: datasets
Out[5]:
DatasetDict({
    train: Dataset({
        features: ['id', 'input_ids', 'bbox', 'labels', 'image', 'entities', 'relations'],
        num_rows: 194
    })
    validation: Dataset({
        features: ['id', 'input_ids', 'bbox', 'labels', 'image', 'entities', 'relations'],
        num_rows: 71
    })
})

The only reason I can imagine this issue may arise is if your default encoding is not "UTF-8" (and it is ASCII instead). This is usually the case on Windows machines; but you say your environment is a Linux machine. Maybe you change your machine default encoding?
Could you please check this?
In [6]: import sys

In [7]: sys.getdefaultencoding()
Out[7]: 'utf-8'

import sys
sys.getdefaultencoding()
returned: 'utf-8'

I've just cloned master branch - your fix works! Thank you!


Adding chart for dotted and solid lines in pipeline

https://github.com/concourse/concourse/issues/731
Would that be correct as a start? People can make it prettier :p But at least there's a legend now.

@Typositoire Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@Typositoire Thank you for signing the Contributor License Agreement!

Thanks again for the PR @Typositoire !


Neumorphism Login and Register Page

Creating new project
Fixes  #154

**Neumorphism**
Login Page

Register Page

Kindly mention the issue number for which the PR has been created

I fixed. please review it.

I fixed. please review it.


a branch for php versions prior to 5.4 short tag array brackets []

Short tag array brackets are used:  $array = []
How easy is it for a quick branch to be made with array() instead of [] ?
Thanks

It's ok I forked and tweaked it for 5.3 array(), thx


Questions from audience - deployment of ML models

Would there be a focus not only on the deep learning frameworks but also the deployment of ML models ahead of Kaldi?

If by "deployment" you mean building a production system based on the trained model, then very emphatic yes! See also https://github.com/jtrmal/kaldi2020/issues/32#issuecomment-702132424
Unlike many deployment scenarios (e. g., data analytics pipeline), ASR applications are much more diverse. Do you want real-time subtitling of the news, or a customer support robot helping someone with their order, or an in-car command and control system (play this song, navigate there)? These are all "deployments." As I understand, there are no plans for a generic one-fits-all "deployment," chiefly due to the sheer variety of scenarios in which Kaldi is currently used.


[type:fix][ISSUE #5332] Fix restart plugin.

Fixes https://github.com/apache/shenyu/issues/5332 & https://github.com/apache/shenyu/issues/5292
changes:

add remove cache logic when closing plugin in class AbstractLogPluginDataHandler.

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ec26dc0) 61.86% compared to head (307b469) 61.83%.

Files
Patch %
Lines

...java/org/apache/shenyu/common/utils/Singleton.java
0.00%
2 Missing :warning:

...g/common/handler/AbstractLogPluginDataHandler.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5337      +/-   ##
============================================
- Coverage     61.86%   61.83%   -0.03%
+ Complexity     8691     8690       -1
============================================
  Files          1255     1255
  Lines         38348    38351       +3
  Branches       3673     3673
============================================
- Hits          23725    23716       -9
- Misses        12508    12520      +12
  Partials       2115     2115

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

not right

#5332 because ext plugin has been removed from plugins cache


scaling-intro.rst appears to be out-of-date

Documentation feedback

Page title: CrateDB scaling introduction
Page URL: https://crate.io/docs/crate/howtos/en/latest/scaling/scaling-intro.html
Source: https://github.com/crate/crate-howtos/blob/master/docs/scaling/scaling-intro.rst

this page appears to be out-of-date

I would be interested in working on this.


Add usual java API to the library.

Add usual java retrofit api to the library, to support not only RxJava approach.

Implemented in #4 .


Enable GitHub Discussions for Better Community Engagement

Is your feature request related to a problem? Please describe.
Currently, contributors and users rely solely on issues to ask questions or discuss topics related to the repository. This often leads to clutter in the issue tracker, making it harder to manage and distinguish between actual bugs and feature requests versus general discussions or questions.
Describe the solution you'd like
I propose enabling GitHub Discussions for this repository. GitHub Discussions can serve as a dedicated space for community interactions, such as:

Sharing ideas and brainstorming new features.
Asking and answering general questions.
Showcasing projects that use the library.
Encouraging collaborative problem-solving among users.

This will improve collaboration, enhance knowledge sharing, and foster a stronger community around the repository. It will also help maintain a cleaner and more focused issue tracker.
Describe alternatives you've considered
Some alternatives include:

Using external forums or chat tools (e.g., Discord or Slack). However, these require additional setup and maintenance.
Continuing to use issues for discussions. However, this isn't an ideal solution, as it makes the issue tracker harder to manage over time.

GitHub Discussions is an integrated feature and a better fit for this purpose since it centralizes all community interactions within the repository.
Additional context
By enabling GitHub Discussions, we can also categorize different types of conversations (e.g., Q&A, ideas, announcements), making it easier for contributors and users to find relevant information. It is a lightweight and efficient way to build a more engaged and supportive community.

@stevekaliski-stripe I'm a big fan of this! It's worked well for Markdoc, too.


stats: use 101 clusters rather than 1001 clusters to calculate per-cluster limits in integration test

Description: tsan (and possibly other) builds were timing out from time to time. This simple unscaling of this test doesn't really lose fidelity and brings the test (on my workstation) from 150s to 22s with tsan.
Risk Level: low
Testing: //test/common/stats:stats_integration_test
Docs Changes: n/a
Release Notes: n/a
Fixes: #10013

/retest

azp run envoy-linux

/azp run

/retest

@lizan do you have insight into why coverage_publish fails, or how to kick it?
#!/bin/bash -eo pipefail
ci/coverage_publish.sh
ERROR: Coverage file not found.

Exited with code exit status 1

@zuercher it's probably worth reviewing anyway; it's a pretty small change. I assume the coverage_publish issue is CI infrastructure and not related to the PR.

@jmarantz fixed.
The real error is:
Warning: skipping this step: Missing workflow workspace identifiers, this step must be run in the context of a workflow
turns out that repokitteh doesn't trigger jobs in workflow context.

Thanks @lizan -- how did you fix? Anyway this is ready for review now.

@jmarantz go to https://circleci.com/gh/envoyproxy/workflows/envoy and rerun from failed, then circle will run it in workflow context.


ExperimentConfig objects are not json serializable

Informations

Qiskit Experiments version: baaa5c2450fdf8d10302c1ebfd58552884681c5d (main)
Python version: 3.10.5
Operating system: osx

What is the current behavior?
The documentation for re-analyzing experiments suggests json serializing an experiment config object to save the experiment for later re-analysis
https://qiskit.org/documentation/experiments/howtos/rerun_analysis.html
in the style of
serialized_exp = json.dumps(Experiment.config())
However, ExperimentConfig objects are not json serializiable, so this raises a TypeError
Steps to reproduce the problem
Create an experiment object, then use the code off the howto page.
What is the expected behavior?
I suspect the documentation is out of date, and probably the correct path involves using framework.ExperimentEncoder/Decoder objects, but probably there are a lot of paths here.
Suggested solutions
Correct the documentation or fix ExperimentConfig as needed.

The instructions were updated in https://github.com/Qiskit/qiskit-experiments/pull/1137 and the right syntax is at https://qiskit.org/documentation/experiments/dev/howtos/rerun_analysis.html. It'll be deployed to the production docs when we put out the bug fix release.


[MS.DI] Use DryIoc sources directly for the DryIoc.Microsoft.DependencyInjection package

There are a number of problems with abstracting away from the DryIoc and keeping it as dependency:

We have two IServiceProvider abstractions, the first is the DryIoc.Container itself and the second is the DryIocServiceProvider wrapper inside the MS.DI. The reason for the latter is that the same IServiceProvider object should implement the ISupportRequiredService from the Microsoft.Extensions.DependencyInjection.Abstractions. So either I depend on the MS.DI abstraction package in DryIoc (I don't want to) or I am doubling on the IServiceProvider implementation, complicating things.
The second reason is the performance/memory, and is partially related to the first point. Having additional abstraction build for the MS.DI adapter just for the sake of wrapping things includes the performance cast or indirection and growing memory. Why do I need a separate object for IServiceProvider or for IServiceScopeFactory if this functionality is already implemented in Container. There is open question about the separate scope wrapped implementing a IServiceScope.

Pros:

No additional dependency on DryIoc. Consequently, it may simplify usage of the comp-time features delivered with the source content package.
Possibility to fine tune the DryIoc internals (think better performance) for the MS.DI without back thought on the general audience. The DryIoc namespace may be changed to the Microsoft.Extensions.DependencyInjection.DryIoc to avoid conflict with the separate DryIoc package.

Cons:

Fix in DryIoc requires additional package release.
Complexity of handling #if logic in DryIoc sources.

//cc @davidfowl If you see that, what are your thoughts?


[Feature]: Add host config for Database resources

Description
Currently, domain config can only be applied for any project resources. Not with database resources. Hopefully, later public URLs for database resources can use the domain instead of the direct IP address. If possible also making each database resources can use same port (optional).
Suppose you can have domains configurable for Database Resources working and merged I consider that the bounty is complete.
Minimal Reproduction (if possible, example repository)
n/a
Exception or Error
No response
Version
n/a

@DeVoresyah  can i pick this up ?

/attempt #2377

@DeVoresyah can i pick this up ?

yes ofc

hi @abhishek818 , any update on this?

This would be great if implemented.

/attempt #2377


Kafka version

I am struggling about which Kafka version we need to start our support?
Suggestion: 1.0.0 or 1.0.1

We can use latest, as we can call APIs with backward compatibility AFAIK: https://www.confluent.io/blog/upgrading-apache-kafka-clients-just-got-easier/


Refresh chromedp context on long scraper delay

Currently, the coursebook scraper uses calls to utils.RetryHTTP (defined in utils/methods.go) in order to handle the automatic retry process for requests. In these calls, it provides a callback which, after a certain number of retries, enters a "long delay" state where it simply waits for a long period of time (i.e. 5 minutes) before attempting to query Coursebook again.
This is not sufficient, however, as it appears oftentimes the scraper does not recover from this "long delay" state and is instead only able to make progress once restarted. This would imply a need to not only wait for a longer period of time, but also to create a new chromedp context in order to fix the issue.
As such, the following actions should be taken:

[ ] Develop a utility function which can establish a new chromedp context that picks up from where an old one left off
[ ] Add calls to this utility function when the scraper enters a long delay state

I'd love to attempt tinkering with this if that's okay!

I'd love to attempt tinkering with this if that's okay!

Absolutely!


Rework and unify the flow for using weapons, items, and spells.

Weapons and items should work closer to spells, where upon clicking the item or its icon a type specific chat card is displayed.
For weapons this card would include the attack roll result, the item description, and a button to roll damage, and to force a crit or fumble roll (covering #332 and #368, and the request in #338).
For items this would slow the item's description, with specialisations by item type.
This would allow users to implement special items, or special types of attack by embedding macros or other links in the item description to describe and trigger the effects.
For spells this would work as they currently do.

@mooped is it possible to make a setting to auto roll the damage and crits as it does now? 🤔

@mooped is it possible to make a setting to auto roll the damage and crits as it does now? 🤔

My thought on that was that the 'Use Standard Chat Cards' option should probably go away (it creates a lot of complexity) and a new option to automatically proceed through the flow would come in, but importantly there would be only one version of each  step in the attack flow and the option just determines whether the next stage triggers automatically or not.
We'd lose the current combined chat card for the entire roll, though. I'm not sure how attached to it you are?
I personally like it for its simplicity, but it seems that lots of people want functionality that is incompatible with it so I'm not sure it's worth the complexity of keeping that aspect of the feature around as an option.
If we add hooks at the end of each step of the flow it becomes very easy for external modules to provide additional automation and customisation. For example a module can listen for the dcc.attackRoll hook and make a decision to trigger the next step based on the selected target (or whatever other information they want to use).

I think crits would always automatically trigger as part of the attack roll process, and could be combined into the attack roll card, it's only really rolling damage that is contentious since it's dependent on the target.

Especially for NPCs, I'd really prefer some way for us not to have more than one click per attack.  I'm not at all attached to how it looks in the chat. 👍🏻

You're right, as a judge it would really annoy me to have to make the extra click to get the damage amount.
I think the feedback can be broken down into a few issues:

Players seeing their damage before they decide to spend luck on the to hit roll
Judges wanting to fast roll NPC attacks
Judges wanting to automate checking for hits/range etc
Handling special weapons that don't deal damage
Applying the target's luck to crits
Automating luck spend on attacks/deeds/damage
Probably more I've forgotten right now

I will have a rethink of how the setting should work, I'm starting to think there should be a setting for the judge and one for the players. Having a client side setting might please some people, but the issue of seeing the damage before spending luck comes back in.
For the chat card I think it might be nice to see if we can collate any rolls made automatically in one card. That allows the extra functionality and optional automation while avoiding some clutter, and would hopefully solve the annoying issue of Foundry playing several overlapping roll sounds with the current separate chat cards flow.
We might need to look at what if any modules rely on the separate chat cards setting too.

I'm pretty sure the spirit of this in general is in v0.50.0 , I tried to make items droppable in the chat, but it was not as simple as hoped. So I think that can get re-opened as a separate issue if it's still desired.


isCheck function

Added a function that allows you to prohibit making a move after which you have a check on the Board.
Thus, nobody can not take the king and make moves that protect you from the checks

@NoLogicTheOne In the screenshot I should be able to finish off the black bishop with white king and remove the check but it doesn't allow. It could be a minor edge case though.

The problem is with Your isMovePossible implementation in the Beeshop class
isMovePossible(src, dest) {
    return isSameDiagonal(src, dest) // beeshop cant move throw other figures
}

In Your code, you solve this by adding the isLegal function, which checks the validity of the move, but this is not a good thing, since you lose the ability to ASSUME the position of the pieces after the move and analyze the position
Now I wrote solution for the Queen, please, check it

@NoLogicTheOne looks good. Thanks for the changes. I'll update the blog post too.


Can not install delorean on CentOS

Delorean comes with setuptools>17 and CentOS doesn't have it in repos, so it fails to install. The problem that setuptools requirements is in test-requirements.txt, and not in requirements.txt, but is still required for installation. So anybody who install it with "pip install -r requirements.txt" will fail.
Reproduce:
just run "pip install delorean" on CentOS

So, I think requirements need to be fixed at large. Setuptools does need to be moved to requirements.txt but so does Mock and so on.
Good catch.

Actually, I've had the same issue, and even adding setuptools>17 to requirements.txt didn't work for me. I had to pre-install it, see https://github.com/rdo-infra/puppet-dlrn/blob/master/manifests/worker.pp#L164-L171 for details on how it worked for me.
An up-to-date tox manages to work for the installation, but I think it does because it updates setuptools as part of its setup.

Actually, after some more tests all we need to do is to upgrade pip before trying to install DLRN. "pip install -U pip", then "pip install -r requirements.txt" works fine for me.

@javierpena it's probably fair to move mock to requirements.txt, it's an actual requirement (and not one using only in tests or build) and since setuptools is required for mock, move it as well

@dmsimard yes, but even then, since the CentOS-distributed version of virtualenv bundles pip 1.4, pip install will fail due to the different setuptools version. We need an updated pip for this.

Also, we have two different "mocks" here. One is the mock command, used to build packages, which is needed at runtime. The other one is the mock python library, which afaik is only required when running tests. @dmsimard  is this correct?

That's right, I always confuse the two mocks. I don't know, actually. You're probably right that it's only used for tests.


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master     #1   +/-   ##
=======================================
  Coverage       100%   100%
  Complexity       34     34
=======================================
  Files             7      7
  Lines            83     83
=======================================
  Hits             83     83

Impacted Files
Coverage Δ
Complexity Δ

src/Entity/ServerEntity.php
100% <ø> (ø)
6 <0> (ø)
:arrow_down:

src/Entity/Cpu.php
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

src/Entity/Ram.php
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

src/Entity/Hdd.php
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

src/Model/ServerModel.php
100% <100%> (ø)
7 <0> (ø)
:arrow_down:

src/Model/ServerFarmModel.php
100% <100%> (ø)
14 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce803c4...3c4a739. Read the comment docs.


About the pre-training data

Hi, I'm quite curious about what the pre-training data looks like. Is there any chance you can demonstrate a small subsample in the repo.

We are in the process of checking whether we can release all or a part of the data. I'll update in a few weeks.
In the meantime, I can give a concrete example.
For a Wikipedia page such as this one.
For the Medal Table, we will extract the table and then the following snippets:

the page title "IHF World Women's Outdoor Handball Championship"
the page description "IHF World Women's Outdoor Handball Championship was ...-1960."
the segment title "Medal table"
caption and segment text (empty in this case)

@muelletm Is the wikitables data same as this http://websail-fe.cs.northwestern.edu/TabEL/index.html ?

No, it's not the same data. TabEL while also extracted from Wikipedia is quite a bit smaller (I think it doesn't contain info-tables for example).
We actually tried pre-training from that data but results where quite a bit worse.
We hope we will be able to update on this in early June.

We are in the process of checking whether we can release all or a part of the data. I'll update in a few weeks.
In the meantime, I can give a concrete example.
For a Wikipedia page such as this one.
For the Medal Table, we will extract the table and then the following snippets:

the page title "IHF World Women's Outdoor Handball Championship"
the page description "IHF World Women's Outdoor Handball Championship was ...-1960."
the segment title "Medal table"
caption and segment text (empty in this case)

Hi @muelletm thanks for the clarifications. But i don't see who or where are the questions/queries taken for. As you have mentioned the textual data and table data pls clarify on the "query" part of the dataset as it's use was mentioned in the paper.

The query part is what we call the text snippet in the paper.
It's text we find on the page of the tabel, I gave an example in my post above:

We are in the process of checking whether we can release all or a part of the data. I'll update in a few weeks.
In the meantime, I can give a concrete example.
For a Wikipedia page such as this one.
For the Medal Table, we will extract the table and then the following snippets:

the page title "IHF World Women's Outdoor Handball Championship"
the page description "IHF World Women's Outdoor Handball Championship was ...-1960."
the segment title "Medal table"
caption and segment text (empty in this case)

Happy to announce that we released the data:
https://github.com/google-research/tapas/blob/master/PRETRAIN_DATA.md

Thanks @muelletm


Integrating vSwarm with InVitro

Summary
This PR is towards integrating the InVitro deployer and loader to the vSwarm benchmark suite. This is required as InVitro currently only uses dummy functions for deployments, and the vSwarm benchmark suite models realistic serverless loads which would help improve the versatility of InVitro.
Implementation Notes :hammer_and_pick:

Briefly outline the overall technical solution. If necessary, identify talking points where the reviewer's attention should be drawn to.

The deployer (Knative), invoker and driver have mainly been changed, and a new tool called the "mapper" has been added. The mapper reads the input trace files and maps the appropriate proxy functions from vSwarm based on the memory usage and function duration. Zip files for the vSwarm function yamls and their profiles have also been zipped and added as they are required to map and deploy the functions. vSwarm has been added as an option in the config files to allow the user to choose between using standard dummy functions from InVitro or the realistic functions from vSwarm.
The invoker has also been changed to include a new greeter client as the vSwarm functions require a SayHello gRPC call to run as opposed to the executeRPC function call. The recording of the successful and failed requests has also been modified to only count the requests after the warmup duration is done.
In summary, this PR adds a new tool (tools/mapper), zipped yamls for the vSwarm functions (workloads/container/vSwarm_yamls.tar.gz), modifies the driver and cmd/loader.go files to integrate vSwarm as an option.
An automatic deployer script has also been added to allow for multiple run sweeps.
External Dependencies :four_leaf_clover:

N/A

Breaking API Changes :warning:

N/A

Simply specify none (N/A) if not applicable.

Please sign off the commits (read contributor's guide in vhive)

When updating the branch, please use rebase, not the merge option.

Will be splitted into parts and reviewed separately


Use sauce storage via sauce_whisk gem instead of internet links

Sauce storage is more reliable for getting the app to Sauce.

that's a good point. I didn't want to add the confusion of having to curl a file, but I agree it's a more reliable method. if I'd had time/space I would have added that as another section of the tutorial and showed this best practice. will keep this open because i think it'd be a good addition to the repo regardless of whether it makes it into the originally published article

I agree it's a bit confusing. The API isn't that bad though.
storage = SauceWhisk::Storage.new username: ENV['SAUCE_USERNAME'], key: ENV['SAUCE_ACCESS_KEY']
storage.upload  '/path/to/app.zip'

that's pretty cool. didn't realize saucewhisk had that as part of the api.

I contributed this API to saucewhisk :smile:


Fixed mock_filled_db_session error and PatchedDatetime

Fixed incorrect use of mock_filled_db_session. Instead of the monkeypatched db_session the mock was used directly.
PatchedDatetime is now in camelcase
The signature of PatchedDatetime function now was missing **kwargs as is in its base method arguments are allowed

Thanks @pogross


Puma plugin causes warning about unresolved or ambiguous Gem specs

When working with the puma plugin, another issue could occur. Potentially, this issue is resolved together with #241. The issue is that pruning the bundler environment together with a on_restart directive causes issues with Gem::Specification.reset:
=> Booting Puma
=> Rails <IP_ADDRESS> application starting in development
=> Run `bin/rails server --help` for more startup options
[69212] * Pruning Bundler environment
[69212] Puma starting in cluster mode...
[69212] * Puma version: 6.4.2 (ruby 3.3.2-p78) ("The Eagle of Durango")
[69212] *  Min threads: 5
[69212] *  Max threads: 5
[69212] *  Environment: development
[69212] *   Master PID: 69212
[69212] *      Workers: 10
[69212] *     Restarts: (✔) hot (✔) phased
[69212] * Listening on http://<IP_ADDRESS>:3000
[69212] Use Ctrl-C to stop
[69212] + Gemfile in context: /solid_queue/Gemfile
WARN: Unresolved or ambiguous specs during Gem::Specification.reset:
      drb (>= 0)
      Available/installed versions of this gem:
      - 2.2.1
      - 2.2.0
      bigdecimal (>= 0)
      Available/installed versions of this gem:
      - 3.1.8
      - 3.1.5
      irb (>= 0)
      Available/installed versions of this gem:
      - 1.13.1
      - 1.11.0
WARN: Clearing out unresolved specs. Try 'gem cleanup <gem>'
Please report a bug if this causes problems.
[69212] - Worker 0 (PID: 69215) booted in 1.0s, phase: 0

I tested multiple combinations, but adding Solid Queue together with the puma plugin and configuring on_restart was the only combination this error occurred. As soon as either the gem or the on_restart is removed, no warning is issued.
Steps to reproduce:

Create a new Rails app: rails new "solid_queue" -T --api --no-tests
Add the gem to the Gemfile gem "solid_queue"
Run bundle install
Install with rails generate solid_queue:install
Migrate with rails db:migrate
Modify the puma.rb config:
a. Configure workers to be used, i.e. workers 2
b. Add prune_bundler
c. Add an (empty) block for restarts: on_restart {}
d. Add the puma plugin with plugin :solid_queue
Start the app regularly through rails s
⚡ See the above warning.

Ruby: 3.3.2 +YJIT
Rails: <IP_ADDRESS>
Puma: 6.4.2
Solid Queue: 0.3.3

Sorry for the delay here, @MrSerth! I'll look into this one very soon.

Hey @MrSerth, in the end, after some back-and-forth, we're going to remove the Puma plugin completely https://github.com/rails/solid_queue/pull/303, so I think you could perhaps run Solid Queue separately. I plan to work very soon in proper CLI, not the rake task, so this is easier.
Sorry for the lack of help here! 😳

Don't worry @rosa, thanks for all the effort you put into Rails and open source software!

In the end we're going to keep the Puma plugin so I'm going to reopen this one! 😅


Not performing exhaustiveness checking for this

TypeScript Version:  nightly
Search Terms:

instanceof never TS2366

Code
class Parent {
    bar(this: Foo): string {
        if (this instanceof Foo) return "foo";
        const proveIsNever: never = this;
    }
}
class Foo extends Parent { }

Expected behavior:
It should type-check.
Actual behavior:
TS2366: Function lacks ending return statement and return type does not include 'undefined'.
The type of this after the if statement is correctly never, but TypeScript doesn't use this information and demands that I return some value.
Playground Link: Playground Link
Related Issues:
Not sure, I tried my best to find something and #12825 looks similar, but I'm not sure if it's the same bug. It seems like proving this to be never should make this type-check.

Counterexample:
class Parent {
    bar(this: Foo): string {
        if (this instanceof Foo) return "foo";
        const proveIsNever: never = this;
    }
}
class Foo extends Parent {}
class FakeFoo implements Parent {
  bar(this: FakeFoo): string { return "fake"; }
}

Parent.prototype.bar.call(new FakeFoo()); // call typechecks, since `FakeFoo` implments `Foo`; yet it does not have `Parent` in its prototype chain

This is working as intended because ts is structural - instanceof can never be exhaustive.

I see, so this: Foo declares that this has the same structure as Foo, not that it is an instance of Foo. Wish there was a way to declare 'true' instanceof arguments. I guess the best I can do is wait for some sort of nominal typing like in #202. Thanks for your time.

Having said that I feel like proveIsNever should not typecheck. Surely it should have the (structural) type of Foo, even if it's not an instance of Foo.

I do want to point out that adding a throw new Error(".bar() was called on a non Foo object") after the if would make typescript happy and give desirable runtime behaviour for the mentioned counter example.

@tadhgmister Yes this is what I should've done. I'm just playing devil's advocate.
I guess my question now is whether it's valid for instanceof to narrow the type of this outside the scope of an if statement, even through it doesn't actually discard the possibility a value structurally matching Foo.

First I want to mention it isn't treating this any different than any other variable, code below demonstrates that.  As well just because the variable is narrowed to never typescript is still detecting a possible branch of execution with an if else if structure, whether it is using instanceof checks or structural checks, it's only within a switch on the discriminated union that typescript can see that the switch will never be exited (Playground Link)

class UnreachableError extends Error { public constructor(guard: never) { super(`Unsupported kind: ${JSON.stringify(guard)}`); } }

class  Foo {
    readonly kind = "Foo"
    a = "this is Foo.a"
}
class Bar {
    readonly kind = "Bar"
    b = "this is Bar.b"
}

function doThing1(x: Foo | Bar) {
    if (x instanceof Foo) {
        return x.a
    } else if (x instanceof Bar) {
        return x.b
    }
    throw new UnreachableError(x); // prove x is never
}
function doThing2(x: Foo | Bar) {
    if (x.kind ===  "Foo") {
        return x.a
    } else if (x.kind ===  "Bar") {
        return x.b
    }
    throw new UnreachableError(x); // prove x is never
}
function doThing3(x: Foo | Bar) {
    switch (x.kind) {
        case "Foo": return x.a;
        case "Bar": return x.b;
        // default: throw new UnreachableError(x); // not needed in switch case, but still good practice
    }
}

Yes. I completely understand that. I'm just surprised instanceof acts as if it were performing structural checks, even though x matching the structure of Foo might fall through all the instanceof checks; x is narrowed to never even if it's actually a Foo-like object (that just happens not to be an instance of Foo)
I would love for someone to chime in and provide some rationale for that.


Move autorolled code into separate licenses_golden files

Currently, updating any code (adding or removing any paths) in third_party is a nightmare. In theory, the process is:

Do all the normal work of updating the code
Run the license script, updating license and licenses_golden files as necessary
Upload the patch (and get it reviewed)
Wait for it to clear all the bots
Land it

In practice, that almost never works, because between step 2 and step 5, it's very likely that the Dart and/or Skia auto-roller will run, which touches licenses_golden/licenses_third_party. Importantly, in addition to whatever other changes it makes, it will change the signature at the top of that file.
So now you have to go back to step 2 and try again. It's already reviewed, so you don't need to wait for that, and maybe you're careful to constantly check back during step 4 (lowering overall productivity due to the interrupts), so the elapsed time until 5 is shorter. Maybe you're lucky this time. Or maybe not, because another auto-roll landed, and now you have to go back to step 2. All that's collided is the signature, but you still have to start the process again. And hope you're luckier this time. And that you don't have a meeting, or lose track of time while working on something else and forget to constantly check on step 4 and miss the window until you're sent back to step 2 yet again. I've been through this cycle 5 times on one PR before.
It would likely make things substantially less painful if we required that any auto-rolled code be split out from licenses_third_party into its own file so the autorollers aren't constantly fighting anyone trying to update code in third_party manually.
@Hixie for thoughts or other solutions.

Sounds eminently reasonable. cc @jason-simmons who set up the sharding originally.

I was filing this bug while wait for bots of round 3 on my latest third_party PR (because round 2 was broken by the skia autoroller), and in the time it took me to write this bug, with 17 bots still pending, a Dart roll sent me back to the starting line for round 4 😝

I confused myself on one of the collisions; Skia is already separate and doesn't impact the third_party signature. Looks like all my resets were due to Dart.

We should just put Dart on its own shard like we do with Skia. Should be easy to do.


Linker relocation issues with build

Hello,
I am running Ubuntu 18.04, cmake version 3.16.1, ld 2.30, gcc 7.4.0. I am using the libboost-log-dev package. I am building using...
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=release
make
The problem is at the end when linking object files with boost libraries...
[ 98%] Linking CXX shared library ../../../transforms/libhello_transform.so
/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_program_options.a(cmdline.o): relocation R_X86_64_PC32 against symbol `_ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EEaSERKS7_' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
external/StandardTransforms/HelloTransform/CMakeFiles/hello_transform.dir/build.make:115: recipe for target 'transforms/libhello_transform.so' failed
make[2]: *** [transforms/libhello_transform.so] Error 1
CMakeFiles/Makefile2:2084: recipe for target 'external/StandardTransforms/HelloTransform/CMakeFiles/hello_transform.dir/all' failed
make[1]: *** [external/StandardTransforms/HelloTransform/CMakeFiles/hello_transform.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 99%] Linking CXX shared library ../../../transforms/libbuffer_fanout.so
/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_program_options.a(cmdline.o): relocation R_X86_64_PC32 against symbol `_ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EEaSERKS7_' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
external/StandardTransforms/BufferFanoutTransform/CMakeFiles/buffer_fanout.dir/build.make:115: recipe for target 'transforms/libbuffer_fanout.so' failed
make[2]: *** [transforms/libbuffer_fanout.so] Error 1
CMakeFiles/Makefile2:2123: recipe for target 'external/StandardTransforms/BufferFanoutTransform/CMakeFiles/buffer_fanout.dir/all' failed
make[1]: *** [external/StandardTransforms/BufferFanoutTransform/CMakeFiles/buffer_fanout.dir/all] Error 2
[ 99%] Linking CXX shared library ../../../transforms/libgate_clone.so
/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_program_options.a(cmdline.o): relocation R_X86_64_PC32 against symbol `_ZNSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS5_EEaSERKS7_' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
external/StandardTransforms/GateCloningTransform/CMakeFiles/gate_clone.dir/build.make:115: recipe for target 'transforms/libgate_clone.so' failed
make[2]: *** [transforms/libgate_clone.so] Error 1
CMakeFiles/Makefile2:2162: recipe for target 'external/StandardTransforms/GateCloningTransform/CMakeFiles/gate_clone.dir/all' failed
make[1]: *** [external/StandardTransforms/GateCloningTransform/CMakeFiles/gate_clone.dir/all] Error 2

Hello,
I successfully built it, using docker however. But I think you might need to build boost independently with -fPIC flag.
Check this section https://github.com/The-OpenROAD-Project/OpenPhySyn/blob/1b8b8dfc7569adefabdc29d14f9a79cb4dcb2775/Dockerfile#L45
In the above section, you may want adjust --prefix to a directory you chose. In that case, when building OpenPhysSyn you may want to pass to cmake BOOST_INCLUDEDIR along with BOOST_LIBRARYDIR. (i.e. cmake -DBOOST_LIBRARYDIR=<your boost installation lib directory)

Boost dependency has been completed removed in fb76b5e.


Add certifi to requirement list

Commit 5f615bf introduced a dependency on certifi.
[cgoncalves@codfish ~]$ pytr help
Traceback (most recent call last):
File "/home/cgoncalves/.local/bin/pytr", line 5, in
from pytr.main import main
File "/home/cgoncalves/.local/lib/python3.10/site-packages/pytr/main.py", line 14, in
from pytr.account import login
File "/home/cgoncalves/.local/lib/python3.10/site-packages/pytr/account.py", line 9, in
from pytr.api import TradeRepublicApi, CREDENTIALS_FILE
File "/home/cgoncalves/.local/lib/python3.10/site-packages/pytr/api.py", line 32, in
import certifi
ModuleNotFoundError: No module named 'certifi'

Thanks!


Enhance StarTreeQueryGenerator to generate all kinds of supported queries

Update the method names in SegmentInfoProvider to make them more clear
Added non-equility, in predicate and between predicate to StarTreeQueryGenerator
Added some comments in QueryGenerator

[Current coverage][cc-pull] is 45.82%

Merging [#249][cc-pull] into [master][cc-base-branch] will increase coverage by 0.09%

@@             master       #249   diff @@
==========================================
  Files           696        696
  Lines         32065      32065
  Methods           0          0
  Messages          0          0
  Branches       4804       4804
==========================================
+ Hits          14664      14695    +31
+ Misses        16230      16199    -31
  Partials       1171       1171

Powered by Codecov. Last updated by [c62c816...25a4abf][cc-compare]
[cc-base-branch]: https://codecov.io/gh/linkedin/pinot/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/linkedin/pinot/compare/c62c816fa978766711fe6424d450da5160b4edd8...25a4abfea500be06815e48e2affaefbc0afa6725
[cc-pull]: https://codecov.io/gh/linkedin/pinot/pull/249?src=pr

Will you update the query set for StarTreeClusterIntegrationTest in a separate PR?
Take care of comments and failed build, otherwise, lgtm.

Locally, it can pass all the tests, but Travis will fail (OOM probably). I will tune some limit to reduce the size of the query and test.


Set #4 icon cards for recreation

Story #15 Material Sets
Sub-Tasks:

[x] CSS
[x] Frame to place icon cards in
[x] Icon cards

Estimate: 5h

199561b969c4ee0839b9307950027217a9253abe


What about math?

What about equations and other optional functionality?

Math and Latex are implemented with external libraries and right now we won't integrate them in this version.
Sorry about that!

np, your project is moving in the right direction (you are reimplementing everything). I'm sure you'll get there eventually.


Boss HP bar debuffs

When a boss has too many debuffs, some of them fall in a second row and get cut.

Fixed in bf71b1d8318dc250f17e76a8f3d293831275e8c6.


The /read endpoint returns 404 when the user has access to more than 50 apps

What
We've upgraded log-cache from 2.0.1 to 2.0.2.
When the user has access to more than 50 apps (more correctly /v3/apps returns multiple pages) then the following error is written in the log-cache-cf-auth-proxy logs:
2019/02/01 11:48:34.679056 CAPI request (/v3/apps) returned: 401
2019/02/01 11:48:34.679118 failed CAPI request (/v3/apps) with status: 401 (Unauthorized)

We suspect the http request reuse in capi_client.go might cause the problem, but we haven't debugged it further.
The problem didn't exist on 2.0.1.
Versions
log-cache: v2.0.2
cf-deployment: 6.10.0

Fixed.

Thanks for reporting this @bandesz


create_index regression test failure because of duplicates

https://github.com/zenithdb/zenith/runs/2457481429

I have a theory now:

Current "last written LSN" is 1
Relation is truncated, truncation WAL record is created, with LSN 2
Very soon after that, a SeqScan is performed on the table. The "relsize" request is made to the page server using the last written LSN 1 in the request.

Because the request LSN is earlier than the truncation WAL record's LSN, the relsize request returns the old size before the truncation. But that's wrong, the truncation should've been visible to the request.
So I think we need to do something like this:
@@ -649,6 +788,12 @@ zenith_nblocks(SMgrRelation reln, ForkNumber forknum)
 void
 zenith_truncate(SMgrRelation reln, ForkNumber forknum, BlockNumber nblocks)
 {
+	XLogRecPtr lsn;
+
+	lsn = GetXLogInsertRecPtr();
+	// XLogFlush(lsn);
+
+	SetLastWrittenPageLSN(lsn);
 }

To debug this, I hacked the smgr api functions in pagestore_smgr.c to also "pass-through" the write and extend calls to md.c, and in the read functions, read the page both from local disk and from page server and compare. That lead me to find this.
Even after that fix, I'm getting failures from that comparison thing; I'll continue to debug those. And I will also polish that hack to compare the pages a bit and create a PR. I think we should have that as a permanent debugging/testing option.

Yeh, I had such version. I forgot why  I have not committed it. May be because I have used it for fixing some particular problem and once it is fixed, I decided that this checking is no needed any more.
I completely agree with you that we should have it as permanent debug option.

It's a good idea about missing truncation.
Though, to me, it looks like a different bug, because I don't understand, how it can possibly result in seeing duplicate values.
Well... there can be some crazy scenario where vacuum truncated some last pages and we returned it and data on it, but I don't think it's what we observe.
BTW, I suggest that we introduce a separate test for every scenario we introduce workarounds for.

I wonder if somebody is no able to reproduce the problem with duplicates in catalog with zenith_clog=false?
I run regression tests multiple times but failed to reproduce this problem any more.

It failed here https://github.com/zenithdb/zenith/pull/83/checks?check_run_id=2491859802
zenith_clog is disabled
On my laptop, it is reproducible when tests are super-slow (i.e. full debug on pageserver).
But it's also very unstable. It fails on alter_table or create_index tests and not every time.

SO we have a number of hypothesis explaining presence of duplicates:

truncation
cmin/xmax
smgrimmedsync
missed index invalidations

From my point of view:

Scenario explained by Heiki illustrates real problem, but can it cause duplicates in pg_index? When this relation is truncated?
May be. I am storing now CID in xlog record. But may be it is missed somewhere or bug...
Unlikely: fsync should not affect normal behavior of the system
May be but I do not understand scenario how it can happen?

Scenario explained by Heiki illustrates real problem, but can it cause duplicates in pg_index? When this relation is truncated?

Hmm. We should never truncate away pages that contain live tuples, only empty pages. However, when a relation is truncated, if any of the truncated pages are dirty in the buffer pool, we just drop them without writing them out. So this could happen:

Tuples are deleted, the page is marked dirty
The relation is vacuumed, and the page is truncated away
The page is read back with old "last-written LSN", which didn't include the deletion yet

The problem is still here and it's still hard to catch. Smaller shared_buffers (i use 300) and larger checkpoint_timeout setting seem to be helpful.
I managed to catch it in another test
@@ -597,9 +597,10 @@
 FROM pg_class AS p1
 WHERE p1.relnatts != (SELECT count(*) FROM pg_attribute AS p2
                       WHERE p2.attrelid = p1.oid AND p2.attnum > 0);
- oid | relname
------+---------
-(0 rows)
+  oid  |        relname
+-------+------------------------
+ 17438 | quad_poly_tbl_ord_idx2
+(1 row)

Which makes me think of another hypotesis - we don't replay some visibilitymap_clear().
Most likely, it is not specific to pg_class, it's just easier to catch on catalog table, because cache invalidation triggers relation eviction and reread from pageserver.

The problem is still here and it's still hard to catch.

Darn.

Which makes me think of another hypotesis - we don't replay some visibilitymap_clear().

Yeah, that seems plausible. We are certainly not doing the equivalent of visibilitymap_clear() at the moment, and we should. Would you investigate that, to see if you can write a test case to reproduce it more reliably?
That's unfortunate, as we'll need to parse the heapam WAL records more thoroughly to clear the VM bits. Or perhaps we can just disable the visibility map for now, by returning all-zeros pages or empty relation for any requests on the VM fork in the page server.

Would you investigate that, to see if you can write a test case to reproduce it more reliably?
Sure. I'm working on it now.

Most likely, it is not specific to pg_class, it's just easier to catch on catalog table, because cache invalidation triggers relation eviction and reread from pageserver.

It really seems to be the most probable case. VM is conservative, so if all-visible bit is set, then Postgres assumes that all objects on the page are visible and do not perform extra visibility checks during index-only scan.
There are no separate WAL records for updating VM. It is updated by redo of insert/delete XLOG records.
So there are three choices:

Associate this WAL records also with VM pages
Prohibit throwing away VM pages
Always return clean VM page from page server

may significantly increase amount of storage used for storing WAL at wal-keepers.
In case 2) we still need to solve the problem of restoring VM at new node (either make this node replay non-relational WAL, either implement it in page server).
proposed by Hekii seems to be the simplest and still quit efficient solution, because VM pages are not expected to be frequently swapped out. My concern is how we will manged to eventually restore all-visible bits in VM? It seems to be done by vacuum. But if relation is not changed, then vacuum will not be called. And all index-only scans will have to perform redundant visibility checks, which definitely has negative influence on IOS speed.l


Generate options

It would be useful to pass an optional path to a spec, and also an optional project name when generating:
struct generate --spec myProject.yml --project MyProject

If no spec path is passed it uses the default project.yml. If no project is passed it uses the name of the spec file

Hi @yonaskolb, struct always looks for common names for the project files, for YAML/JSON it's project.{yaml|yml|json} and for Specfiles it's Specfile. This is mainly around consistency more than anything, and follows similar conventions to Fastlane's Fastfile, Cocoapod's Podfile, etc.
Project names can be changed by using variants - each variant name will be the name of the project, and you can disable the standard project.xcodeproj output. The following example should work:
variants:
  # $base is your standard project.xcodeproj
  $base:
    abstract: true
  MyProject:

Got it, makes sense, thanks


Migrate additional PgOSM styles

Details
Layers with styles possibly with saving/migrating:

Landuse
Amenity
Misc POI (at least the parts in Infrastructure?)
What else?

Reviewed the amenity, misc poi styles of old... nothing really worth saving.  Will need to develop new styles as appropriate.

Reviewed the amenity, misc poi styles of old... nothing really worth saving.  Will need to develop new styles as appropriate.


Notes for Windows users

Added a note for windows users to create symlink to the storage directory. The Laravel installer does not do this automatically for Windows.

Thank you.


PEP8 fixes

A few PEP8 fixes. Also add flake8 linter check to CI.

This looks great :)
Surprisingly though, PEP8 fails for 2 out of the 7 tests (https://travis-ci.org/github/renatopp/liac-arff). Do you know what's going on there?

CI should be green now https://travis-ci.org/github/renatopp/liac-arff/builds/723564467 for this PR..


Fixes #91 - Enable setting command line flags for launch configuration

This PR contains the current list of flags supported by Cloud SDK (except for those used in non-Java runtimes). The user can select a flag, define a value and add it to the launch configuration. There is validation in place to ensure that string arguments are not empty and boolean arguments are in the supported format. More extensive validation is covered by #92
@briandealwis @elharo PTAL

LGTM

I'm going to finish this one up and merge since Andras is now on leave.


View state of in-memory editors not preserved

Steps to Reproduce:

Start debugging session
Click on same stack frame from an internal module - an in-memory editor is opened
Ctrl-tab, Ctrl-tab you are back in the in-memory editor, but the view state is not preserved the cursor is at the beginning of the file

To investigate.

I think you fixed that!

Yeah I did 😎


Add SSL private key and CSR generation functionality to traffic_ops_golang

This PR fixes the JSON metadata tags on tc.DeliveryServiceSSLKeys struct so that marshaled JSON keys match those on the perl side.  Also adds a function to generate an unencrypted private key, certificate request (CSR), and includes unit tests of the function.  To be used in the golang SSL API endpoint for generation of keys.
Fix: #1780

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1034/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1046/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1049/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1050/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1054/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1178/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2918/
Test FAILed.

@jrushford can this PR be closed? This functionality has since been added to traffic_ops_golang, right?


Apply strictness

Apply docs state:

A value which has an Apply must provide an ap method. The ap
method takes one argument:
a.ap(b)

b must be an Apply of a function,

shouldn't there be requirement that b must be same Apply as a ?

There should also be a fourth clause stating:
ap must return a value in the same Apply as a and b
Or something to that effect.

Would you like me to file a PR ?

Would you like me to file a PR ?

Yes

@gabejohnson  @safareli -> #247


kodi black screen

Describe the issue
after installed kodi.ipa and you try to open app, kodi remain in black screen.
Before this app worked well.
Instructions to reproduce
install kodi ipa and lunch it
What version of LiveContainer are you using?
3.1
Other
No response

Long press app -> Set orientation lock to landscape.


Add ETH test networks and fix spelling mistake

Add btc-testnet header and switch eth-testnet-name header for some real ETH testnet names.

@rswarthout , not sure how to tag you as a reviewer on this, but feel free to take a look.

I appreciate these changes.


Better node identification

From the last July Swarm2K experiment, there were a lot of leave / join operations (more than 3,000 times I guessed).
Some nodes joined unsuccessfully and left ~800 DOWN or UNKNOWN entries inside the log.
Is it possible to have a better mechanism to identify the nodes? So when they rejoin, the Swarm will know that they are the old nodes trying to join, not the whole new set of nodes.

@aaronlehmann @diogomonica I think this is related to re-using the existing CSR or something like that which we discussed earlier today.
Is there an issue for that already or is this the master issue? If so, we should probably make it a 1.13 P2 IMO.

I was thinking of #756, but we closed that one becaused we stopped doing manual node acceptance. I think this is a bit different. Let's use this as the master issue.

Sounds good. Feel free to rephrase the issue title

I don't think we will ever do this: So when they rejoin, the Swarm will know that they are the old nodes trying to join, not the whole new set of nodes.
If a node leaves the cluster, and removes the credentials, it will never be assigned the same ID again, since it can't prove that it owned it before (IDs are assigned by the managers).
Now, if this is a problem with join where a node tries to join, doesn't succeed but creates a raft node entry and when it tries again the system ends up with 2 node entries, then yes, we should fix it.

@diogomonica I think the title is misleading, but this is the issue I mentioned where duplicate nodes were popping up. My theory is somehow join failed and they retried but didn't reuse the existing key material.

@aluzzardi: The node ID is assigned by the manager, so I don't think reusing key material would help.

The only think that helps is to store the NodeID that is returned from the IssueCertificate call, and if there is a failure between that andCertificateStatus where we actually retrieve the certificate, we could recover by jumping to CertificateStatus, instead of regenerating the CSR, and applying for a new certificate.

ping @diogomonica