Ignore vendoring in Go 1.14

Hi! I'm trying to build my app with Go 1.14, but faces the error:

[module name] explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory

Is there any way to ignore Go vendoring in Heroku? I've tried use env GOFLAGS=-mod=mod but it didn't work.

I face the same problem while using gitlab auto devops (https://gitlab.com/gitlab-org/gitlab-runner/-/issues/21801)
need to find a way to get it use the go mod instead vendor

Hi there,
It sounds possible that go mod vendor hasn't been run locally with go1.14 yet. Could either of you please share the output of go version and go env from a project having this issue?
If I understand correctly, something like this might fix it:

Be sure go version reports go1.14 or greater
Within your project, run go mod vendor
Commit any changes, such as lines added to vendor/modules.txt prefixed with #
git push heroku master or similar

Thanks!

Hi, @danp,
Please, read the first message carefully. WITH vendoring everything works fine, but I'm interested in how to use Go 1.14 in Heroku WITHOUT vendoring. In simple words, I don't want to use go vendor. but I have to, because I get the error above otherwise. So, is there any way to ignore Go vendoring in Heroku?

Hi, sorry for misunderstanding. I could still use some info about the project you're working with to make a better recommendation. In addition to the info I asked for above, could you please provide the output of ls -la vendor/modules.txt?
Thanks!

Ok, so:

go version go1.14 darwin/amd64
Done
Done
Done

Output:
-rw-r--r--  1 lepeshev  staff  2560 Mar 12 18:52 vendor/modules.txt

Thanks! How about go env output?
I'm also wondering if you have a line in go.mod that starts with go and what it says. If it doesn't say go 1.14, please update it and try the go mod vendor and following steps again.
In the meantime, I'll see if I can put together something that reproduces this problem so we can get it sorted.
Thanks again.

Go env:

GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/lepeshev/Library/Caches/go-build"
GOENV="/Users/lepeshev/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/lepeshev/Go"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/usr/local/Cellar/go/1.14/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/lepeshev/Projects/Capodaster/capodaster-api/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/3m/1j9pxct90c3cb0nrtvplb3c00000gn/T/go-build847069462=/tmp/go-build -gno-record-gcc-switches -fno-common"

Yes, I have go 1.14 in go.mod

Having the same problem. My local repository doesn't have a vendor folder (neither tracked nor untracked in Git); I have a simple go.mod:
module github.com/Pyorot/streams

go 1.14
// +heroku goVersion go1.14

require (
	github.com/bwmarrin/discordgo v0.20.2
	github.com/joho/godotenv v1.3.0
	github.com/nicklaw5/helix v0.5.7
)

This built fine in the default Go 1.12 (by deleting the goVersion line) but I get "go: inconsistent vendoring" error, despite the readme of this project suggesting that vendoring shouldn't be used if the vendor directory is absent. It'd be convenient to have a +heroku comment to specify -mod=vendor vs -mod=readonly.

Thank you both. I think I've reproduced the problem and found the issue, and I'll work on a proper fix. In the meantime, unless you need the language change introduced in 1.14, can you please try changing the go 1.14 line in go.mod to go 1.13? I believe that will get it working. Note that you can keep the // +heroku goVersion 1.14 line to use 1.14, the go 1.14 line controls what language features are available.
Details on the issue, as I currently understand it:
Go 1.14 added more consistency checks between go.mod and modules.txt and better defaulting of the mod flag which are activated with go.mod specifies go 1.14 or higher. The buildpack has some catching up to do here and part of the issue is that it currently calls go list with -mod=vendor which can cause trouble when 1.14's new consistency checks are used.

Hi,
I think I have a branch which fixes this. If you're up for trying it, read on. Otherwise, a fix should be pushed out in the next day or two. I'll update here when it's out.
To try the branch, use heroku buildpacks:set to change the Go buildpack's source. For example, if heorku buildpacks against your app only shows heroku/go, you can use buildpacks:set like so:
heroku buildpacks:set https://github.com/heroku/heroku-buildpack-go/go-1-14-no-vendor.git

If heroku buildpacks shows a number of buildpacks including heroku/go, you can pass -i to buildpacks:set to set just the heroku/go entry. For example, if heroku buildpacks against your app shows something like:
=== my-app Buildpack URL
heroku/my-cool-buildpack
heroku/go
heroku/my-other-buildpack

You'd use -i 2 to set heroku/go's place in the list:
heroku buildpacks:set -i 2 https://github.com/heroku/heroku-buildpack-go/go-1-14-no-vendor.git

After using buildpacks:set, try pushing your app again. When using this branch, you can leave go 1.14 in your go.mod file. When done testing, or once the fix is released (I'll update here when that happens), be sure to change back to heroku/go so your app doesn't unexpectedly break when this branch is deleted.
Thanks!

Thanks for being on top of this. My fix was to set // +heroku goVersion 1.12. Won't have time to test the resolution but will be able to confirm that bumping it back to 1.14 works. Cheers

@danp i tried your branch and it worked for my project.

@danp any news when it's released?


Passwords containing punctuation '#' cause login errors

If the fbpass contains '#', the fbchat.Client(fbid, fbpass) will fail.
Have verified this on a number of accounts.   Passwords containing other punctuation may also be effected.    The Client constructor needs to escape special chars properly.

Strange, it works fine on my side and I don't think '#' is special char that causes problem.
Im using python2.7
However, my fbchat is still 0.6.0 which is very old already
Can anyone else verify this ?

It's very strange.  Have confirmed from multiple machines.   For reasons that I cannot explain, any password containing '#' fails to log in.   Now this may be masking something else, such as password length issues which I hadn't considered, but it seems odd.    If I update the fb account password and remove '#', everything works great.   Add it back to the fb account password, and update the login info on fbchat, and I can't login again.
Tested with 3 diff fb accounts
Testing the nodejs facebook-chat-api in npm,  it seems to also have the same problem.
This suggests to me that this issue is in  oauth tho, not fbchat.
Thought I should update you.    This may be an issue with the transport layer at facebook and not related to  the fbchat code.

@amplogik interesting.  I assume passwords containing "#" work when logging into the browser?  Would it be possible for you to inspect your network traffic when doing so and see if the "#" in the password is escaped in any way when when it is passed to facebook?
@Bankde your password contains "#" and you have no problems? hmm

@Schmavery Yes, I had changed my password to contained "#" in the middle just to test this issue and it works fine. Since OP stated that he tested several times, I believe him though.
Is your password happened to start with or end with "#" ?
What version of python are you using ?
fbchat version ?
Very interesting it's now affecting nodejs too haha.
What operating system are you using ?

Can't confirm, using Ubuntu 16.04, requests v2.13, fbchat v. 0.8.2, tested on both Python 2.7 and Python 3.5, with password #aaaa#aaaa#

@amplogik how are you storing/retrieving your passwords?  Is this failing with passwords just hardcoded as strings in your code or is there something more complex happening on your end?

confirmed with password contains "@", in Windows

How did you confirm this @nguyenvulong? Can you give an example of a password that didn't work?

Yesterday I tried this password Xx123456@yy
After removing the "@yy" part, it's able to login successfully
Before that, it failed (I gave it 2 more times to retry)

Can't confirm, using Windows 10, fbchat v. 1.0.19, tested on Python 3.6, with password Xx123456@yy
As said above, are you sure the @ is actually being stored correctly?
Which URL does it fail on? (Let it fail until it stops by itself, and show us the stack trace)
Maybe you could show us the code you're using?
Perhaps you could enable debugging information:
import logging
Client('<email>', '<password>', logging_level=logging.DEBUG)


All files are reloaded on each user actions in Gmail

Hi,
With this boilerplate, each time we open/close/write email, navigate in history, all files are reloaded.
I think this makes Gmail crash. This is the case with my extension as soon as I declare observers.

I have the same issue. It works fine on the initial load. When I go to another Inbox Type, the gmail.observe**.() functions are no longer called.
If I call main(); on the console manually, it starts working again.


Github Pages site

Would be great if we could have a Github pages site for this project

Evtl. as a suggestion. Open a gitbook (https://www.gitbook.io) - that's what we did for http://i18next.com rather happy with it - simpler to maintain as a custom github page.

gitbook site has changed https://www.gitbook.com/


Implement service account definitions

Seems like a good idea to implement this for when we have applications running within instances that need to programmatically talk between services. It's already implemented in Fog ( attribute :service_accounts ) so should be easy to bridge over.

#67 Submitted, need to add documentation.

Need to add validation to make sure the passed attribute is an array, otherwise it traces back:
/home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/gems/fog-1.29.0/lib/fog/google/models/compute/server.rb:244:in `save': undefined method `map' for "https://www.googleapis.com/auth/devstorage.full_control":String (NoMethodError)
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/gems/fog-core-1.30.0/lib/fog/core/collection.rb:51:in `create'
	from /home/temikus/code/vagrant-google/lib/vagrant-google/action/run_instance.rb:136:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/code/vagrant-google/lib/vagrant-google/action/warn_networks.rb:28:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/code/vagrant-google/lib/vagrant-google/action/sync_folders.rb:33:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/builtin/provision.rb:80:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:95:in `block in finalize_action'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/builder.rb:116:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/runner.rb:66:in `block in run'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/util/busy.rb:19:in `busy'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/runner.rb:66:in `run'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/builtin/call.rb:53:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/code/vagrant-google/lib/vagrant-google/action/connect_google.rb:47:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/builtin/box_check_outdated.rb:36:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/builtin/config_validate.rb:25:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/builtin/handle_box.rb:56:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/warden.rb:34:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/builder.rb:116:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/runner.rb:66:in `block in run'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/util/busy.rb:19:in `busy'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/action/runner.rb:66:in `run'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/machine.rb:214:in `action_raw'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/machine.rb:191:in `block in action'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/environment.rb:516:in `lock'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/machine.rb:178:in `call'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/machine.rb:178:in `action'
	from /home/temikus/.rbenv/versions/2.0.0-p598/lib/ruby/gems/2.0.0/bundler/gems/vagrant-27599ee897da/lib/vagrant/batch_action.rb:82:in `block (2 levels) in run'


fix building error with glang master version

Why we need this PR:
Build error in our travis ci when using glang master branch code, seems that something has been changed or more strictly check than before.
Which issue(s) this PR fixes(we suggest there is at least one issue related to this PR)
Fixes # https://github.com/ZTE/Knitter/issues/27
@xiangpengzhao

Pull Request Test Coverage Report for Build 55

1 of 5 (20.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 35.538%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/klog/klog.go
1
5
20.0%

Totals

Change from base Build 48:
0.0%

Covered Lines:
5630

Relevant Lines:
15842

💛  - Coveralls


Create kpack.io/services annotation when converting to v1alpha1 to prevent loss of data

Could you explain how you came across this with kp?

Could you explain how you came across this with kp?

I basically applied a kubectl patch against the v1alpha2 resource and saw that services were no overwritten, but when applying that same patch against a v1alpha1 image resource, services were overwritten. When looking at our conversion logic I noticed that we throw away service bindings during conversions which caused any edits (even patches) to overwrite them


How to programatically clear ketcher's drawing area ?

I want to clear the Ketcher's drawing area programatically .
I tried ketcher.setMolecule('') but it throws BAD Request Error.
How can we achieve this ?

Hi @sfialok98 , you can clear drawing area with using ketcher.editor.struct(null).

Yes, that worked.
Thanks !!


Don't depend on the package manager's dependency tree

There may be circular dependencies or dependencies shared by commands installed with the same package manager. There was also a situation where a package manager did not have the ability to list dependencies (tdnf). To avoid these situations it would be better if the package manager was instead used to list installed packages again after a layer is applied.

Unfortunately, not depending on the package manager to get package dependencies is a huge performance hit. So this will have to be a fail safe if there is no method of collecting dependencies.


change numerical tolerance to fix failing mcem test

Merging into devel.  @paciorek I'll flag other PRs that demonstrate the testing failure this fixes.


testingtestingrequest

Commit IDs
98d5d5, https://github.com/iancha1992/bazel/commit/79a0dc276cc81717ac2951d575e19f6a54d71e43, a2b775
Category
team-CLI, team-OSS
Reviewers
@iancha1992

The following commits were cherry-picked in https://github.com/bazelbuild/bazel/pull/20431: https://github.com/iancha1992/bazel/commit/79a0dc276cc81717ac2951d575e19f6a54d71e43, https://github.com/iancha1992/bazel/commit/a2b775.
Failed commits (likely due to merge conflicts): https://github.com/iancha1992/bazel/commit/98d5d5
The failed commits are NOT included in the PR. Please resolve manually.
cc: @bazelbuild/triage


Update WC to support CDN components

Alaska Airlines Pull Request
In conjunction with: https://github.com/AlaskaAirlines/auro_docs/issues/40
Summary:
This PR adds a new feature of pre-compiling Web Components so that they can be served up from a CDN.
Type of change:
Please delete options that are not relevant.

[x] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Orion Design System Team

:tada: This PR is included in version 4.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add color to the line next to "Ran a XXX Command" based on return value

What problem or use case are you trying to solve?
In the interface, we have "Ran a Bash Command" or "Ran a Jupyter Command" with a line next to it.

It would be nice to know if the command was successful or not.
Describe the UX of the solution you'd like
We could change the color of the line depending on the return value. If the command terminates successfully, we can make the line green, otherwise we can make it red.

OpenHands started fixing the issue! You can monitor the progress here.

A potential fix has been generated and a draft PR #5483 has been created. Please review the changes.


add analytics methods

add simple core redis-backed methods

Should adding an event track the category + action pair? I'm thinking it might so that you could see what pairs are available for viewing from a GUI.


Update rewrite branch to work with latest development version of Agda 2.5.2

Note: CI is failing because these changes only work with Agda 2.5.2.

I've updated this PR after some more changes to Agda itself, and I've removed the whitespace commit. If you're okay with it I can squash my commit with a98e4c01e177be9c227d3a25c9469257b21b0296 so it looks less silly.

Hi @jespercockx, how about you directly manage the rewrite branch? I created this branch as an experiment to test rewriting rules, and I think you are the best person to do this. Also, I planned to rebase and merge the rewrite branch to the master branch when the newer version of Agda is out, but I would like to hear your opinions.

Ok, I'll take over the rewrite branch then until it can be merged into master (so after the release of Agda 2.5.2 probably).

PS: Yes I am all for squashing those two commits.

Let me merge and close this thread now.

(Please feel free to do whatever force pushing you want.)


aksk parse compatible

fix https://github.com/juicedata/juicefs-csi-driver/issues/231

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@63648a9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #233   +/-   ##
=========================================
  Coverage          ?   90.67%
=========================================
  Files             ?       16
  Lines             ?     1351
  Branches          ?        0
=========================================
  Hits              ?     1225
  Misses            ?       96
  Partials          ?       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63648a9...da74bbe. Read the comment docs.


The context in child content of nested render fragment is unrecognized by compiler

This issue has been moved from a ticket on Developer Community.

[severity:It's more difficult to complete my work]
This problem occurs only within a RenderFragment:
@code {

private RenderFragment GetDataTableTemplate()
        => @<DataTable>
            <ChildContent>
                    <RowsDetailTemplate Context="row">
                        @if (row. Expanded)        // !!!! the row context is undefined by the complier
                        {
                        }
                    </RowsDetailTemplate>
                }
            </ChildContent>
        </DataTable>;

Can be solved only with this workround:
private RenderFragment GetDataTableTemplate()
        => @<DataTable>
            <ChildContent>
                    @{
                         object row = null;      // <-- not used for intellisense but needed for compilation
                         <RowsDetailTemplate Context="row">
                                 if (row. Expanded)        // !!!! now the row context is recognized by the complier
                                 {
                                 }
                           </RowsDetailTemplate>
                      }
                }
            </ChildContent>
        </DataTable>;
}

! [image.png] (https://aka.ms/dc/image?name=Bd3102987e07b4b3cac3c7a071d3f6fa3637479379173851442_20210203-093155-image.png&tid=d3102987e07b4b3cac3c7a071d3f6fa3637479379173851442)

Original Comments
Feedback Bot on 2/3/2021, 06:43 PM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Original Solutions
(no solutions)

This nasty bug is making Authorization very difficult as I can't nest AuthorizeView's if I want a not authorized section in my nested authorizeview.


A spinning circle under Pinned

https://user-images.githubusercontent.com/52186032/134019062-574d1f4e-d33d-4887-9629-3dcb699b89ff.mp4
The circle is annoying, can you reproduce it? It appears everyone's profile at GitHub. I'm using Google Chrome 93.0.4577.63 (Official Build) (64-bit), Arch linux. If need more info, please let me know

Reproduced

Reproduced as well. This is caused by an unused selector that was briefly added, then removed in a subsequent commit.
I'll link a PR in just a minute.


Android User Agent not recognized

Hello,
the following two user agent strings are both not detected by library (first one seems to be a web view from android)

Mozilla/5.0 (Linux; Android 5.1.1; E5823 Build/32.0.A.4.11) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.76 Mobile Safari/537.36
Mozilla/5.0 (Android 5.1.1; Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Thank you

Thanks. Can you tell me the phone types? (Vendor, Model)

We don't know all the types, since we pulled those user agents from our log files, but it seems to be a problem with Sony Xperia Z3 and Z5.

Sorry, without concrete information I can't do anything.
@serbanghita, how do you process in such cases?
@peanut-lord, the source for the regexs for device detection are in https://github.com/serbanghita/Mobile-Detect

The PHP library detect's those string correctl, we get a true for isMobile()

The js library detects this device as UnknownTablet or UnknownPhone, depending on screen size. Server-side (without screen size) it is detected as UnknownMobile (mobile() is truthy).
@serbanghita the new Sony Z5 Compact (E5803, E5823) is missing in the phone-section:
http://developer.sonymobile.com/downloads/whitepapers/xperia-z5-compact-e5803-and-e5823-white-paper/
This device has a relatively large market share (when looking at Sony, not compared to some Samsung devices).

mobile-detect is just a kind of "satellite"-project. It uses the RegEx patterns of
Mobile-Detect and generates JavaScript source code
based on the code of its "mother"-project.
Missing patterns for particular devices cannot be added in mobile-detect.js,
instead you have to create an issue in Mobile-Detect.
Please provide the User-Agent string, the manufacturer and the type of device (phone, tablet, tv, bot, ...).
It doesn't make any sense to change generated code. I hope you understand.


changed \sec to \S

Removed the duplicate, and changed /sec to /S

Looks good. Thanks for contributing! :tada:

Thank you so much! Sorry for messing up 😓 I'm kinda new to raising PR's

Not a problem. The more you contribute, the more you can improve! :+1:


Updated spelling mistakes

Hey guys! Just found a few spelling mistakes, also check out line 207 that I did not change, but thought that maybe smallwins wasn't supposed to be the only import.

Closing for now: we need a CLA to merge these fixes!

For some reason git is being filtered out of my inbox. Sorry about that!!!

It says I've signed this already... but the screen still says I haven't signed it... maybe some time will change it? :P

hmmmm cc @kborchers the jsf license bot may be on the fritz!

The bot is actually working properly. 😉 The issue is that the CLA signature by @jonathanstiansen does not match the commit made by @hobnob-upcase. You'll either need to amend the commit and change the author or sign the CLA as the other user and then it should be happy.

Dang, thanks Kris!  Will change that.
On Tue, Mar 20, 2018 at 10:47 AM Kris Borchers<EMAIL_ADDRESS>wrote:

The bot is actually working properly. 😉 The issue is that the CLA
signature by @jonathanstiansen https://github.com/jonathanstiansen does
not match the commit made by @hobnob-upcase
https://github.com/hobnob-upcase. You'll either need to amend the
commit and change the author or sign the CLA as the other user and then it
should be happy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/arc-repos/arc-docs/pull/31#issuecomment-374671190,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACP56BN0zJ90RqSLr5GnqrTG6ZMWwU3_ks5tgTKegaJpZM4RT2e4
.

--
Sent from my cell phone, please excuse any mistakes.


[Feature] Make neo.core.Epoch more useful

Hey!
I have been working with neo epoch for annotating behavioral states of a monkey and noticed that there are some few functionalities that would have made my life so much easier.
These are just some ideas:

When I create an epoch with unsorted entries it would be nice that the epoch sorts them according to the epoch.times
It would be super useful to have some methods to check for:

Gaps in between epoch entries
Overlap between epoch entries

It would be very useful so be able to merge consecutive entries (entries with epc[0].labels == epc[1].labels and with epc[0].times + epc[0].durations == epc[1].times) into a single entry.

Right now these things can only be checked by 'manually' iterating over the times, durations and labels; which was quite error prone in my case.
I hope that you find some of these ideas worthy of discussion!
Cheers,
Aitor

Hohey again!
Some further improvements could also include:

epoch.t_stop is equal to epoch.times[-1], but for me it would make much more sense if it would be epoch.times[-1] + epoch.durations[-1]
epoch.time_slice() acts only on the epoch.times, but in my opinion it should also crop the epoch.durations[-1] when necessary (following the t_stop criterion that I thought would make more sense).

Hope you find these ideas useful for the project :)
All best,
Aitor


Fix for mesh (v5)

Its true only for PM mode. MeshRenderer has example of premiltiplyRgba :)

Wait, I'll add NPM/PM support here.

Thanks for the tweak here @ivanpopelyshev 👍


Unable to backup if already backed up previously

Running into a new issue here. If an export/backup has already been done, running it a 2nd time would cause the following error:

If I delete the gkeep-export folder and run again, everything is fine.

Thanks for the bug report, there's a chance this is fixed by updating python-frontmatter, I'll investigate this fully but you may be able to get this quickly working for you again by doing pip install python-frontmatter --update in the same python environment keep-exporter is running in.


Error running the all.sh script

Here's the output that I received when running the all.sh script:
Waiting for Halyard daemon to start
Waiting for Halyard daemon to start
+ Get current deployment
  Success
+ Edit Spinnaker version
  Success
Problems in halconfig:
- WARNING There is a newer version of Halyard available (1.6.5),
  please update when possible
? Run 'sudo apt-get update && sudo apt-get install
  spinnaker-halyard -y' to upgrade

+ Spinnaker has been configured to update/install version "2.15.0".
  Deploy this version of Spinnaker with `hal deploy apply`.
+ Get current deployment
  Success
+ Prep deployment
  Success
Problems in halconfig:
- WARNING There is a newer version of Halyard available (1.6.5),
  please update when possible
? Run 'sudo apt-get update && sudo apt-get install
  spinnaker-halyard -y' to upgrade

+ Preparation complete... deploying Spinnaker
+ Get current deployment
  Success
- Apply deployment
  Failure
- Deploy spin-redis
  Failure
- Deploy spin-clouddriver
  Failure
- Deploy spin-front50
  Failure
! Deploy spin-orca
  Interrupted
- Deploy spin-deck
  Failure
- Deploy spin-echo
  Failure
- Deploy spin-gate
  Failure
- Deploy spin-rosco
  Failure
Problems in Global:
! ERROR Failed check for Namespace/spinnaker in null
The connection to the server <IP_ADDRESS>:6443 was refused - did you specify the
  right host or port?

- Failed to deploy Spinnaker.
24.*.*.*
admin
dneimgFsntqkSz6+TW0+5Xs6t9P7VeSEl7jwSSZskaM=
+ sudo kubectl get pods -n spinnaker --watch
NAME                       READY   STATUS    RESTARTS   AGE
svclb-spin-deck-lb-msgf2   1/1     Running   0          97s
svclb-spin-gate-lb-mlg7v   1/1     Running   0          97s

The 24.*.*.* IP is the external to my network IP, not the external to my node.  I'm not sure this has an effect on anything, but I'm going to retry with the IP overridden to be the node's IP.

I'm pretty sure this is fixed (or environmental...).  Let me know if you're still seeing this.


Cannot add myself as dataset manager

I have some old datasets created with an old user(email=aheugheb@ulb.ac.be).
eg Fruitly checklist
When I try to add myself as manager of this dataset, my new admin<EMAIL_ADDRESS>does not appear in the user list.
I can add somebody else, but not me... very strange.

It seems that non of the admins appear in the list.

Hi @andrejjh - this is expected.
It's implemented as a hierarchical authorization list where admins have management permission on all datasets (plus other aspects). Admins can then appoint other users as data managers (with or without registration rights) in a more fine-grained manner.


Use Golub-Welsch when Jacobi Parameters are large

The algorithm breaks down as Jacobi parameters become large.  Maybe it should fall back to Golub-Welsch in this case?

I agree. Looking at asymptotic error formulas, asymptotic expansions should still work if n >> max(alpha,beta)^2. Maybe this can be made into a pretty good criterion for which to switch over to GW.


Code changes to auto execute injection.

Hi! I want to auto execute injection of the link buttons instead of clicking on extension everytime I visit a page with Vimeo player embedded in it. I have already edited the allowed URLs in manifest.json but still the extension only works when I click it.
How can I edit the code such that it auto injects the download button everytime I visit a specified website?

@mmjsmohit the idea of the current extension is to inject on request. If you want to inject on page load then you just need to set the appropriate handler of page load and call the inject method.

Actually I am a newbie in context to Chrome Extensions. Can you guide me how to do it?

Sorry, but I can't read the Extension docs and StackOverflow for you. Starting query -  "browser extension page loaded handler" 🤷.

I understand. Thanks for your time. Cheers. ;-)


Decrease the default soft shadow quality to improve performance

Follow-up to https://github.com/godotengine/godot/pull/50329.
Soft shadows are relatively expensive to filter. However, with the default blur factors, it's not needed to use too many samples (unless PCSS-like shadows are used with a large size). Textures and screen-space antialiasing can also be used to mask the noise pattern effectively.
On a GeForce GTX 1080, going from Medium to Low for both shadow types saves 0.2-0.4 ms of GPU time per frame in 2560×1440 resolution. This can translate to significantly higher savings on lower-end GPUs.
Given how the shader works, this improves rendering performance even if lights with shadows are never used.
If you need higher quality shadows, the option to change the soft shadow quality in the Project Settings remains.
Preview
Click to view at full size. This is a rather extreme scenario, as there are no textures and FXAA is disabled.
Before (old default)

After (new default)

After my findings in https://github.com/godotengine/godot/pull/53961, we could consider disabling shadow dithering as an alternative to decreasing the shadow quality.

Thanks!


Sound.onMarkerComplete signal is broken

It's already been noticed, but here's the issue thread, for insurance.
game.bgm = game.add.audio('southSide');
game.bgm.addMarker('start', 0, 11.748, 0.7);
game.bgm.addMarker('loop', 11.748, 110.769, 0.7, true);
game.bgm.play('start', 0, 0.7, false);
game.bgm.onMarkerComplete.add(function() { // This will only fire once, and the sound will NOT loop after heading into the loop section under any circumstances, whether loop is set to true or false on the marker or play function itself
      if (game.bgm.volume != 0.0) {
           console.log('yes');
           game.bgm.play('loop', 0, 0.7, true);
     }
}, this);

Thank you for taking the time to open this issue. However, official support for Phaser 2 has now ended as we focus on preparing Phaser 3 for beta release. In a bid to keep the project tidy, and avoid confusion, we are closing all v2 related issues.
This does not mean your issue won't be looked-at. In November 2016 the Phaser CE (Community Edition) project began. The aim of Phaser CE was to allow the community to continue v2 development. Since then it has gained significant traction, with many updates and releases.
If you are still interested in having your issue investigated we strongly recommend testing the latest Phaser CE release. And only if the problem persists, opening an issue on the Phaser CE repo.


disambiguation logic for two-way sms

Implements https://github.com/govflow/govflow/issues/68

Codecov Report

Merging #70 (0e1a48c) into main (6ae64d2) will increase coverage by 1.04%.
The diff coverage is 93.63%.

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   86.57%   87.62%   +1.04%
==========================================
  Files          81       82       +1
  Lines        2108     2214     +106
  Branches      218      229      +11
==========================================
+ Hits         1825     1940     +115
+ Misses        283      274       -9

Impacted Files
Coverage Δ

src/registry/service-identifiers.ts
100.00% <ø> (ø)

src/core/communications/routes.ts
52.45% <14.28%> (-3.91%)
:arrow_down:

src/migrations/27_message_disambiguation.ts
85.71% <85.71%> (ø)

src/core/communications/helpers.ts
90.30% <100.00%> (+1.20%)
:arrow_up:

src/core/communications/models.ts
94.11% <100.00%> (+1.26%)
:arrow_up:

src/core/communications/repositories.ts
97.46% <100.00%> (+0.80%)
:arrow_up:

src/core/communications/services.ts
87.21% <100.00%> (+8.60%)
:arrow_up:

src/core/index.ts
100.00% <100.00%> (ø)

src/core/service-requests/repositories.ts
100.00% <100.00%> (+7.24%)
:arrow_up:

src/db/index.ts
95.91% <100.00%> (+0.17%)
:arrow_up:

... and 4 more


_ZNSt8ios_baseC2Ev

Hello @etwmc today I encounter this issue on another platform, any idea what could this mean?
./PHK: can't resolve symbol '_ZNSt8ios_baseC2Ev' in lib './PHK'.
Do you think with the -static flag the application can run fine?
Greetings!

Tried "make clean" yet?
Otherwise, what platform and OS are you using?

Yes I did clean, I am using openwrt but I am guessing the libraries inside
the board are not exactly the same as the compilation, is there any flag to
bundle everything in a single file? Without dynamic linking?
On Sunday, 8 May 2016, etwmc<EMAIL_ADDRESS>wrote:

Tried "make clean" yet?
Otherwise, what platform and OS are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/etwmc/Personal-HomeKit-HAP/issues/58#issuecomment-217773810

The program itself doesn't rely on dynamic linking (I don't think any program rely on that, static and dynamic should work the same)
For how to compile static, I think that's your compiler's setting. Just add the header in the makefile and it should work fine.


stride tokens fail to be moved around in ibc.fun

Hi,
I am having issues to move stATOMs around, let's say from Kujira->Osmosis. I get the following error:
console.js:36 Error: Query failed with (6): rpc error: code = Unknown desc = failed to execute message; message index: 0: spendable balance  is smaller than 1000000stuatom: insufficient funds [!stride-!labs/cosmos-sdk@v0.47.4-stride-distribution-fix-1/x/bank/keeper/send.go:252] With gas wanted: '18446744073709551615' and gas used: '36248' : unknown request
Needless to say that I have enough stAtom to send. I tried with Keplr and Leap, issue is the same. What I am currently doing is manually sending my st* to stride, then, from there, I can use ibc.fun to go around.
Thanks for your help.

This has been fixed! Please try again and let us know if you found any issues.


Cannot fetch file from GitHub enterprise by commit

I'm using fetch v0.3.2 against our GH Enterprise instance.  The initial logging indicates Enteprise is detected
Assuming GitHub Enterprise since the provided url (<enterprise url>/<redacted repo>) does not appear to be for GitHub.com
but then later on there is an error
ERROR: Error occurred while downloading zip file from GitHub repo: 500 - Failed to download file at the url https://api.github.com/repos/<redacted repo>
It should be using a URL beginning with https://<enterprise url>/api/v3/<repo>

I believe @jniesen was kind enough to add GitHub Enterprise support. Any chance you know what the issue above is?

@brikis98 I think I see the problem. Some tests need to added to file_test.go and URL parsing needs to be introduced into MakeGitHubZipFileRequest https://github.com/gruntwork-io/fetch/blob/48ae79f9b8aa0842ad22e07b2fae5e5669dcbcfc/file.go#L117

Thanks @jniesen!

@jniesen, were you able to fix this?  Before I dig in too deep, wanted to doublecheck since we are experiencing the same issue and it is now a blocker for us.  Interested in getting it fixed, and a new release cut.

@dg-nthompson No, sorry you got blocked by this. I had to let this get this displaced by other things.
If you would like to dig in, the link in my previous comment is a good place to start. The occurence of api.github.com in that func and any other occurrence needs to be looked at and possibly updated to take advantage of the URL detection logic used elsewhere.
Like on this line:
	url := fmt.Sprintf("https://api.github.com/repos/%s/%s/zipball/%s", gitHubCommit.Repo.Owner, gitHubCommit.Repo.Name, gitRef)

The api.github.com could be replaced with gitHubCommit.Repo.BaseUrl like:
	url := fmt.Sprintf("https://%s/repos/%s/%s/zipball/%s", gitHubCommit.Repo.BaseURL,  gitHubCommit.Repo.Owner, gitHubCommit.Repo.Name, gitRef)

Then the bulk of the work lies in updating the tests. Also, just from looking at it some now, I'm not totally positive that you'd use BaseUrl or ApiUrl.
I hope this helps and I won't be doing any coding unless I let you know and get an ack that we're not stepping on each other's toes. Sorry again.

@jniesen, thank you for the reply!  No worries on being blocked, it was more to determine how we wanted to proceed.  @josh-padnick has been able to jump in an help, so hope to have something in place with tests when he is ready.  Thank you all!


Added Metric for COT

Created metric for GPQA COT Prompting

I see that you made the requested changes in a new pull request #3162. In general, please make the requested changes to a pull request in the same pull request / branch, rather than creating a new pull request for every cycle of requested changes.
If you're unfamiliar with GitHub in general, I would suggest reading the GitHub documentation and / or the Git book.

Redundant


Fix routable asset ordering

Describe your changes
Fixes the ordering of routable assets by liquidity as well as adds tests.
Issue ticket number and link
Closes https://github.com/penumbra-zone/penumbra/issues/4189
Checklist before requesting a review

[x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label.

@erwanor we should be good to clean this up and work on a migration in a pairing session when you've got time


IE11 throws an error when the second parameter of the Blob function is undefined (fix #44)

/cc @inikulin @miherlosev

FPR

It requires rebase now

FPR

FPR

FPR

LGTM

iOS tests timeouted

:white_check_mark: Tests for the commit b157b2ecfa1711c060b0c51c221859ebb3b87058 have passed. See details.
Tests are ok now. We've found the issue with travis and saucelabs and will fix it in the gulp-qunit-harness. The problem appears when more than one travis tasks started in the one time.
So, @inikulin @miherlosev you can review the pr

LGTM then


ISPN-10264 Wrong time conversion for async xsite take-offline

https://issues.jboss.org/browse/ISPN-10264

Integrated, thanks Pedro!


Add Mach versions as notes in Zig

https://machengine.org/about/nominated-zig/
I like where Mach was thinking. Create sub versions that are updated more often than the latest tag of zig. This allows for bug fixes and feature enhancements a lot sooner than waiting for a new tag, but not so unstable as nightly. This still use the zig's tarball for the release and not mach's mirror.
Not sure if it was smarter to add notes to the versions or separate plugin under zig. I figured since it is zig and not like java's different runtimes, it made sense to have it as notes next to the different versions.

Thanks for your first contribution! ;)


Update test script

Coverage remained the same at 90.094% when pulling 1127acdc60b001c8625a82e7a750414077ca2069 on jaivigneshvenugopal:Update_TestScript into 621dcfe953bce11381460d25de282d5f542d4846 on CS2103AUG2017-T17-B1:master.


Implement cranelift_entity::ReservedValue for Type

Implements cranelift_entity::ReservedValue for Type, to use as PackedOption

*type is only 8 bytes

oops, yeah. I misunderstood something, sorry.

Then I think

thought so, based on the explanation. thanks for the explanation.

Hmm, but I still think using Option<Type> could be slightly better. The reason is that Rust applies null pointer optimization, meaning that if Type does not utilize all possible bit patterns, the size of Option<Type> can remain 8 bytes, just like Type. From a performance perspective, just using Option<Type> would be slightly better. However, the performance difference is likely very minor, especially if Option<Type>/PackedOption<Type> is not used frequently.

Hmm, but I still think using Option<Type> could be slightly better. The reason is that Rust applies null pointer optimization, meaning that if Type does not utilize all possible bit patterns, the size of Option<Type> can remain 8 bytes, just like Type. From a performance perspective, just using Option<Type> would be slightly better. However, the performance difference is likely very minor, especially if Option<Type>/PackedOption<Type> is not used frequently. So it'd be fine as is, I think.

ah, I see, because variant Type::Compound(u32), actually only needs 5 bytes. https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=803c11e6ccc6789c7ffa2291e53e43f9.
we probably should revert this pr.


client.py: add new arguments: "delete" and "update"

To delete/update the nodes and edges in a given json.
According to issue #376

ok to test

LGTM
please squash your commits together

run go-fmt

Can you change the "replay" mode into "add". Now that we have "delete" and "update", it make sense to call this "add" to align.


Fix fast-forward PR bug

Fixes #1186 and #1964.
If a PR is fast-forwarded, use the last commit of the PR as the "merge commit".
This ignores a more subtle problem, which is that we determine the "merger" of a PR by the author of the "merge commit", not by the user who actually pushed that commit to origin (which is how Github does it). Fixing this would require a much larger refactor, so for now I decided to just do a quick fix for the more glaring problem.

Looks good. Do we have PR integration test?

@lunny yes, we have https://github.com/go-gitea/gitea/blob/master/integrations/pull_merge_test.go#L35

@lafriks but the CI is not failed before this PR. So I think that test didn't hit the situation this PR wants to resolve. But anyhow LGTM.

@lunny This is difficult to write an integration test for, because the error occurred in a background thread. If the error occurred in a test, it wouldn't cause the test to fail, since the test has no way of checking whether the error occurred.

Will this be backported to 1.1.x?

@ashkulz sure.

LGTM


Update makemkv

Description of changes
Change log 1.16.7 is mostly a bugfix update released 27.2.2022.
Fixed hicolor icon location to fit with the themes subdirectories.
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
1 package built:
makemkv

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

cc @titanous


[PL-55258] PL 1.45.x Release Notes

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: PL 1.45.x Release Notes
Jira/GitHub Issue numbers (if any): PL-55258
Preview links/images (Internal contributors only): https://668c2b6557dbbf86d4c61818--harness-developer.netlify.app/release-notes/platform#version-145x

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://668c24b477ec3c7c5124d9ff--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://668c2b6557dbbf86d4c61818--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://668c5e4fe1b41479e17e8d1b--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://668d70d58aa78bae1cddf75b--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://668e1189e0967c63b3bb9af0--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://668e11b67494d46a705432fe--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://668e630494d3c629c2432e21--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://668ecd540d8d252d4ae3436d--harness-developer.netlify.app


Setup github-resolve-repos cloudquery plugin to be incremental

Describe the feature you'd like to request
github-resolve-repos only ever downloads a subset of
Describe the solution you'd like
We should only pass a list of changed data from oss-directory on some smaller time basis (and then perhaps every day we refresh the data in full). This would decrease the time used on each refresh and would mean we could run the cloudquery plugin more often.
We may need to do some additional plumbing to merge tables. This issue (or another) should explore that.
Describe alternatives you've considered
N/A

@ravenac95 is this still relevant in our embedded-elt + dlt world?

Ya likely not relevant anymore


[Place Page Revamp] Add a new development endpoint

Adds a new endpoint to hold the revamped place pages while in development.
In particular, changes include:

Renaming _nl_search_bar.scss to without the leading underscore to allow @use importing
A starter .js file that renders the nl search bar at the top of the page
A starter .html template that renders the place name, type, and links to parent places
A starter .scss file for styling
A new /dev-place blueprint and endpoint in flask to hold changes
Update the link generation helper functions to also use the new endpoint

An example:
/dev-place/geoId/667000

lgtm in general.
i'd lean towards making a new directory, rather than using things within /place. that will make it easier to switch over once dev is completed. it'll also help to avoid any unintended dependencies

Good idea, switched to using a new directory "/dev_place"


Is this supposed to mimic pyrcc5 ?

Was glad to see someone made a tool to generate rcc files, but why is it only for UI files? Could it easily be extended to mimic pyrcc5 behavior?

Looks like the QT6 rcc tool would do what I want. That said, I think a native python tool would be nice.

It would be great, I understand :).
But as stated here: https://www.riverbankcomputing.com/static/Docs/PyQt6/pyqt5_differences.html, PyQt6 developers decided to remove resource support completely. Therefore there is no way to use :/icons/icon.ico notation.
Purpose of pyqt6rc is to at least provide some support for generation of .py files from .ui files. Maybe there is some way to use .zip file to package all resources and then use it in similar way as Qt resources. I can have a look at that in the future.
For now, if it's really crucial for your project to use Qt resources, I would switch to PySide6 as that seems to still support it: https://doc.qt.io/qtforpython-6/tutorials/basictutorial/qrcfiles.html

Yeah I don't really get it- PySide6-rcc worked for my scripts, but invoking QT6's packaged rcc binary and I get missing files.
Also, using QT5 generated qrc files appears to work perfectly fine with PyQT6. Quite frustrating to remove that, it's not a lot of code from what I saw..

Actually- the rcc binary does seem to work if I specify no compression. Maybe something with qfile.


feat: add sub doc operations

Ticket:

https://tools.adidas-group.com/jira/browse/CNCFDOPS-1393

Would suggest to let those functions be tested through other scripts and keep this library structure simple for now. Will look at it later once having more time.


Cannot run after successful build

description
Cannot run after successful build，because class name is compressed（example for MButton => $el）
resolution
Instead of applying class names as element tag, always specify the tag manually.

description
Cannot run after successful build，because class name is compressed（example for MButton => $el）
resolution
Instead of applying class names as element tag, always specify the tag manually.

For stability reasons, @Component must be passed a tag parameter
before
@Component()
class App extends DecoElement {}
// app

now
@Component('app') // must write  a tag name
class App extends DecoElement {}


feat: Add Marinade as a Vault

Implementation of Marinade Finance as a vault in navigator
Cleaned up older commits and work into a new PR
@wei1769 @ironaddicteddog

@wei1769
need input on how to add tests for depositor info
it(" Can get depositor", async () => {
    const depositor = (await marinade.infos.getDepositor(
      connection,
      marinade.MARINADE_STATE_ADDRESS
    )) as marinade.DepositorInfo;
    console.log(`- Depositor: ${(JSON.stringify(depositor), null, 2)}`);
    // console.log(`- Deposited Balance: ${depositor.tokenAccount.amount}`);
    // console.log(`- Owner: ${depositor.userKey.toBase58()}`);
  });

This test gives this error TypeError: Do not know how to serialize a BigInt

Could you add hacktoberfestaccepted tag here

@ayushpaharia Plz remove JSON.stringify in your test. Can refer to this approach: https://github.com/DappioWonderland/navigator/blob/master/test/lido.ts


Effect of number of global and local augmentations on pre-training

Hi,
Thanks for making the code public.
How does the number of global and local augmentations affect pre-training? Currently, G=2 and L=10. Is it possible to reduce the number of transforms without much performance drop?
P.S. - During pre-training SMKD on the cluster, each epoch takes around 5 mins, 4-5 times more than reported. I am using A40 and A100 Gpus. While profiling, I discovered that the slowdown is caused by the PyTorch transformations applied in the DataAugmentationSMKD function (mainly the RandomResizeCrop).
By the way, did you encounter such a slowdown using PyTorch transforms? Even after using num_workers = 16, the transformations are still a bottleneck for me.

Solved.


More reasonable timeouts for json_run_localhost (poll-cv and sanitizers)

Solves part of a bigger problem: our C/C++ test timeouts are not reasonable at all (E.g. json_run_localhost + poll-cv + tsan gets an auto scaled timeout of  2 * 5 * 20 = 200 mins).
Based on historical data, I'm decreasing:

[dbg + opt] json_run_localhost poll-cv timeout from 600sec to 120sec  (very safe, max runtime observed over last 9000 runs is 75 secs)
[asan+tsan]  json_run_localhost from  12000sec (poll-cv) and 2400sec (other pollers) to 600sec (that would fail ~30 runs over the last 12000 runs and those should fail really anyway because they have crazy runtime between 1000sec and 6000sec)

This should really help with the big latency spikes on our PR sanitizer test runs.

CC @matt-kwong  @sreecha

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

Example bigquery for collecting the test durations:
select * from jenkins_test_results.aggregate_results where test_name like '%json_run_localhost%' and job_name like '%san%' and timestamp > '2017-10-01 00:00'  order by elapsed_time desc, timestamp desc

[trickle] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__2M_2_0.opt.new: 1

[microbenchmarks] No significant performance differences

Known failures:
#12510 #12428 #12918 #3562

Friendly ping.


Stuck at "Getting org.scala-sbt sbt 0.13.13" running sbt behind sock5 proxy

Run sbt stuck at "Getting org.scala-sbt sbt 0.13.13"
steps

install sbt 0.13.13 with Homebrew
run sbt -v in console behind sock5 proxy

problem
Output "Getting org.scala-sbt sbt 0.13.13".
then stuck with no response
I try this, make no sense.

Stuck at "Getting org.scala-sbt sbt 0.13.11" · Issue #2602 · sbt/sbt

expectation
notes
config in  /usr/local/etc/sbtopts
-Dsbt.override.build.repos=true
-Dsbt.repository.secure=false

verbose log:
[process_args] java_version = '1.8.0_31'
Executing command line:
java
-Xms1024m
-Xmx1024m
-XX:ReservedCodeCacheSize=128m
-XX:MaxMetaspaceSize=256m
-Dsbt.override.build.repos=true
-Dsbt.repository.secure=false
-jar
/usr/local/Cellar/sbt/0.13.13/libexec/sbt-launch.jar
Getting org.scala-sbt sbt 0.13.13 ...

We use GitHub issue mostly to track bugs and tasks on sbt development. If you need help, please check this out - https://www.scala-sbt.org/support.html


Improve test-helper: prevent spawning multiple processes of cargo test

We need to debounce clicks on the "Run Test" button. That is, when a testing is running, that button should be deactivated in the UI.
Before this fix, multiple clicks on this button (e.g. when the developer gets impatient during the idle waiting) will spawn multiple child processes. Though cargo build invocations in the same Rust project are serialized thanks to the file lock, spawning multiple processes is still undesired, and most likely unintended. Moreover, spawning multiple processes--either on the same *.typ file or different files--will mess up the running status indicator in the status bar, since it is semantically a cross-file global state.
This patch also adds a tooltip to the running status indicator to remind developers that the long wait time may be a result of rebuilding.
Unrelated but as a nice-to-have, this patch replaces cargo test's argument --all with --workspace, because the former is a deprecated alias of the latter. See:
$ cargo test --help | grep -e "--workspace "
      --workspace         Test all packages in the workspace
      --all               Alias for --workspace (deprecated)

I also considered showing a small notification box in the lower right corner if the running status indicator is clicked upon, and have that box display a real-time view of the most recent line printed by cargo test. This is doable with VSCode's extension API, but I think you may find this an overkill :)

I also considered showing a small box in the lower right corner if the running status indicator is clicked upon, and have that box display a real-time view of the most recent line printed by cargo. This is doable with VSCode's API and child_process and helps with relieve developer's doubt during the waiting, but I think you may find this box an overkill so didn't do it :)

I also considered showing a small box in the lower right corner if the running status indicator is clicked upon, and have that box display a real-time view of the most recent line printed by cargo. This is doable with VSCode's API and child_process and helps with relieve developer's doubt during the waiting, but I think you may find this box an overkill so didn't do it :)

That sounds awesome! I'd love this.

I also considered showing a small box in the lower right corner...

That sounds awesome! I'd love this.

Done 🎉
https://github.com/typst/typst/assets/18319900/a81e84e5-f48e-4373-a3f8-2241c91102ef

Thank you!


Allow registration message without Resource Type

Registration messages without rt="oma.lwm2m" should be accepted as valid request.

Did some tests, looks good to me.


Updated to download multiple video files

I have made changes to to the user script that allows for the tool to download multiple videos at once. There are downsides:

Must allow pop-ups when opening videos
Must allow multiple downloads when directly downloading the videos.

I personally believe my code isn't all that great, and I please ask for you to review it and make any changes necessary.
This should partially fix #93

You may turn off the whole file reformat to keep commit changes clean.

I am so sorry, I thought I did that correctly. Will push a new change soon.


Question about baseline results

Did you use beam search for the accuracy values reported in the paper? If so, is the accuracy top1 accuracy or top K accuracy?

No beam search; the models output the most probably character sequentially for every output character.
"As is common in sequence-to-sequence models, the models predict the answer autoregressively using a greedy decoder (output majority class at each step)." (section 4.1)

Ah thanks, I missed that
On Wed, Nov 6, 2019, 8:10 PM David Saxton<EMAIL_ADDRESS>wrote:

No beam search; the models output the most probably character sequentially
for every output character.
"As is common in sequence-to-sequence models, the models predict the
answer autoregressively using a greedy decoder (output majority class at
each step)." (section 4.1)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/deepmind/mathematics_dataset/issues/9?email_source=notifications&email_token=AEMDKVUTPAQWE2ZREAIY2UDQSKQ3NA5CNFSM4JIDWYYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGFUBA#issuecomment-550263300,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEMDKVRIUJFOK2EPHF2FJHDQSKQ3NANCNFSM4JIDWYYA
.


Adding copy flow function plus some cosmetic changes

You changed function signature in low.go, but did not change its usage in some files (like major tests in packet package for instance) it is a baaad-baaad practice :)

Good catch, thank you!

Updated


No module named 'gi' when using pipenv run

I am using pipenv on my dev for Guake. vext is great and allow to access system's gi from the virtualenv, but it needs to be installed through pip install.
If I do a pipenv install --dev eventhough it is installed (it is reported as so by pip freeze), it does not work.
When installing from clean pipenv with pip install, it works only when I enter into the virtualenv and then execute the code, if I use the runner pipenv run, the magic VextFinder.PATH_TRIGGER does not seems to be installed.
Any idea to make it compatible with pipenv ?

I've never used pipenv, so no idea - though I probably would have accept a patch.
I guess you will need to start by looking into how pipenv does its magic.

Reproduce in a virtualenv:
pip install pipenv
pipenv install vext.gi

This produces:
ERROR: ERROR: Could not find a version that matches vext-gi
No versions found
Was https://pypi.org/simple reachable?

Seems pipenv is changing vext.gi to vext-gi?

Great!  This might be a pipenv bug, any chance of opening an upstream bug with pipenv and linking here?


Create contributing.md file

Big lines:

Content edition should be done through PRs
Team members will approve

https://github.com/LAION-AI/laion.ai/blob/main/CONTRIBUTING.md

Fyi @TomasCarlson
Let's try and use PRs for future large changes
Thanks for all the work you are doing!


Blacklist entries storage bug

Blacklist entries show up as BlacklistGuest object instead of their name

Fixed in https://github.com/sigmapi-gammaiota/sigmapi-web/commit/94a7e4fb28aa2d7fc830c0276a4087e9cc0b0cc5


assertTableRow requires a specifiq array order

In trait DatabaseTableTestTrait function protected function assertTableRow()
Instead of $this->assertSame I would use $this->assertEqualsCanonicalizing
So the array order doesn't matter, preventing this kind of error:
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 [
+    'first_purchase_time' => '2024-04-27 22:22:41',
     'last_purchase_time' => '2024-04-27 22:22:41',
-    'first_purchase_time' => '2024-04-27 22:22:41',
 ]

Can you please create a PR?


FileNotFoundError: [Errno 2] No such file or directory: 'data/TrainSet.mat'

Hello,
could you also please upload the dependent files,
Thanks in advance!
Error log
/home/npv0/exp/pytorch/venvpytorch/bin/python /home/npv0/exp/conv-social-pooling/train.py
Traceback (most recent call last):
File "/home/npv0/exp/pytorch/venvpytorch/lib/python3.5/site-packages/scipy/io/matlab/mio.py", line 33, in _open_file
return open(file_like, 'rb'), True
FileNotFoundError: [Errno 2] No such file or directory: 'data/TrainSet.mat'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/npv0/exp/conv-social-pooling/train.py", line 44, in
trSet = ngsimDataset('data/TrainSet.mat')
File "/home/npv0/exp/conv-social-pooling/utils.py", line 14, in init
self.D = scp.loadmat(mat_file)['traj']
File "/home/npv0/exp/pytorch/venvpytorch/lib/python3.5/site-packages/scipy/io/matlab/mio.py", line 141, in loadmat
MR, file_opened = mat_reader_factory(file_name, appendmat, **kwargs)
File "/home/npv0/exp/pytorch/venvpytorch/lib/python3.5/site-packages/scipy/io/matlab/mio.py", line 64, in mat_reader_factory
byte_stream, file_opened = _open_file(file_name, appendmat)
File "/home/npv0/exp/pytorch/venvpytorch/lib/python3.5/site-packages/scipy/io/matlab/mio.py", line 39, in _open_file
return open(file_like, 'rb'), True
FileNotFoundError: [Errno 2] No such file or directory: 'data/TrainSet.mat'

+1 could you provide the dependent data files? Thank you. Would like to try out your network.

The old link https://www.its-rde.net/index.php/rdedataenvironment/10023 to download the data is deprecated, the new location https://data.transportation.gov/Automobiles/Next-Generation-Simulation-NGSIM-Vehicle-Trajector/8ect-6jqj puts all data in one big file though. I tried to split the data according to the time stemps, but when running 'preprocess_data.m', I get an error in line 193, telling me that I exceed the matrix dimensions.
Could you maybe upload the processed data on a file sharing platform?

The old link https://www.its-rde.net/index.php/rdedataenvironment/10023 to download the data is deprecated, the new location https://data.transportation.gov/Automobiles/Next-Generation-Simulation-NGSIM-Vehicle-Trajector/8ect-6jqj puts all data in one big file though. I tried to split the data according to the time stemps, but when running 'preprocess_data.m', I get an error in line 193, telling me that I exceed the matrix dimensions.
Could you maybe upload the processed data on a file sharing platform?

can't open the link...

The data files are too large to upload to Github. The 'preprocess_data.m' file generates these files from the raw NGSIM US-101 and I-80 text files. These are publicly available datasets.

Hai....in the  'preprocess_data.m' file what does the  ' Lateral maneuver' and 'Longitudinal maneuver' means?

These are the maneuver classes as described in the paper

The data files are too large to upload to Github. The 'preprocess_data.m' file generates these files from the raw NGSIM US-101 and I-80 text files. These are publicly available datasets.

can provide  the raw NGSIM US-101 and I-80 text file, or the links, thanks

These are the maneuver classes as described in the paper

hello,Now all the downloaded data is in a big folder. Does this folder contain us-101 and i-80?Then "preprocess data" generates the corresponding 6 files? thank you very much!

These are the maneuver classes as described in the paper

"Next_generation_simulationingingle_trajectories_and_supporting_data" in 'location' I only see peachtree and us-101 but not i-80, I wonder if there is something wrong with the data I downloaded?Or, it looks like this


Compatibility with PHP 8

Has the API been tested with PHP 8? As we are actively using PHP 8, wanted to make sure the API is PHP 8 compatible.

Nope. Deprecation notice sources needs to be updated.

@isaumya these versions v2.8.3 & v2.8.4 are compatible with php 8.0 . let me know if you need any help

@ankitdas13 well, this message was from last year. Now I need to know if it is compatible with PHP 8.1. Please do let me know if the package is compatible with PHP 8.1.

@isaumya Yes, it is compatible with PHP 8.1 as well

Hey, @ankitdas13 now that's good news... Thanks for the confirmation.


SQLite Support

Added SQLite support use in EventFlow testing of upcoming SQLite Migrations support

Pull request closed as it seems that AppVeyor is no longer building additions to the branch. Will open a new request


About ROUGE for evaluations.

Hi,
I followed the institution to install and set pyrouge and ROUGE1.5.5,
when I evaluate the full model by executing the "eval_full_model.py" script, the --meteor flag works well, but the --rouge flag will output errors like:
Cannot open exception db file for reading: /home/zqj/Workspace/Tools/pyrouge-master/tools/ROUGE-1.5.5/data/WordNet-2.0.exc.db
Traceback (most recent call last):
File "eval_full_model.py", line 53, in
main(args)
File "eval_full_model.py", line 26, in main
output = eval_rouge(dec_pattern, dec_dir, ref_pattern, ref_dir)
File "/home/zqj/Workspace/fast_abs_rl/evaluate.py", line 40, in eval_rouge
output = sp.check_output(cmd.split(' '), universal_newlines=True)
File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
**kwargs).stdout
File "/usr/lib/python3.5/subprocess.py", line 708, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/home/zqj/Workspace/Tools/pyrouge-master/tools/ROUGE-1.5.5/ROUGE-1.5.5.pl', '-e', '/home/zqj/Workspace/Tools/pyrouge-master/tools/ROUGE-1.5.5/data', '-c', '95', '-r', '1000', '-n', '2', '-m', '-a', '/tmp/tmpf5fnmfg3/settings.xml']' returned non-zero exit status 255
My OS  is: Ubuntu 16.04.
Perl version: perl 5, version 22.
My I ask how to solve this is issue?

Please check this page and read the WordNet Exception paragraph. Hope this helps.

closing this since it's more of a ROUGE issue rather than issue of this repository.


Unpin pydicom

The latest wsidicom should work with the latest pydicom.  In my quick check of unpinning pydicom, the tests throw errors, though.

Resolved in #283


Clean up light client spec

@hwwhww You have this marked as "Draft". Is there anything else to do before merge?

@djrtwo yessss will add more commits!


Area List

what is area list and how to make it.

The format of arealist is the following:
pcd_file_path,x_min,y_min,z_min,x_max,y_max,z_max

@shoaibazam If you have further questions, please feel free to reopen this issue.


sdk declaration should accept ".a" files

The current validation check for sdk definitions to be either .framework or .tbd is a little too tight. It would be useful to also accept .a as an extension and to treat them as-is (i.e. no additional path specification). This allows the library search path to be specified in the central xcconfig and the library name to be used in the project (rather than always having to specify the full path with a leading "/").
I'd be happy to contribute a patch for this if it sounds acceptable. Cheers!

Hi @smackie, the intent sounds good. Not totally clear on the details, but would happily look over a PR 👍

Hi @yonaskolb, I had a look at a patch earlier which I'll organize for a review in a day or two. Thanks for this tool - it's an absolute blessing. Cheers!


Request: Expose SDK state machines

Is your feature request related to a problem? Please describe.
I'm currently using the exposed callbacks like onDidChangeConnectionStatus to update and expose the current status to render on my RN application. The states that I maintain in application may get out of sync in these cases

App is backgrounded and hence not able to receive callbacks to update state
During a JS refresh, a connected reader will remain connected and so 'onDidChangeConnectionStatus' would not get called
Not possible to detect if a discoverReaders() is ongoing in another part of the app that didn't call it, when there is no discoveredReaders in the vicinity
Not possible to subscribe to the same hook in multiple places in 1 application

Describe the solution you'd like
Would be great if there was a state machine that's exposed for the entire useStripeTerminal() so that I don't have to maintain my own states that may get out of sync. Also makes it easier to avoid cases where I forget to cancelDiscovering() or cancelInstallingUpdate().
Example states that would be great to have
connectionStatus = notConnected | discoveringReaders | connecting | connected
installUpdateStatus = idle | updateAvailable | installingUpdate | updateFailed
I'm not too familiar with how the SDK represents its states internally but these are some of the states I frequently wish I had access to
Describe alternatives you've considered
Currently use a few useStates() on the hooks provided by the Terminal SDK but it gets out of sync

@zameschua we added a getConnectionStatus method on the latest beta.19 release to give access to connection status state without callbacks. Unfortunately the update status is only supported through callbacks
Changelog: https://github.com/stripe/stripe-terminal-react-native/releases/tag/v0.0.1-beta.19


fix: add svg to cover properties, don't reference cover many times

While investigating if we should add start to the list of default attributes, I noticed a few errors regarding the validity of covers:
https://github.com/lesjoursfr/html-to-epub/issues/140#issuecomment-2208258735
This PR fixes those issues.
Before

After

Thank you for this PR.
I think we can apply the same fix to the EPUB v2 template templates/epub2/content.opf.ejs
Validating using EPUB version 2.0.1 rules.
ERROR(OPF-074): tests/book-v2.epub/OEBPS/content.opf(22,81): Package resource "OEBPS/cover.xhtml" is declared in several manifest item.
ERROR(RSC-005): tests/book-v2.epub/OEBPS/cover.xhtml(6,29): Error while parsing file: attribute "charset" not allowed here; expected attribute "content", "dir", "http-equiv", "lang", "name", "scheme" or "xml:lang"
ERROR(RSC-005): tests/book-v2.epub/OEBPS/cover.xhtml(11,42): Error while parsing file: attribute "epub:type" not allowed here; expected attribute "dir", "id", "lang", "style", "title" or "xml:lang"
ERROR(RSC-005): tests/book-v2.epub/OEBPS/cover.xhtml(6,29): Error while parsing file: attribute "charset" not allowed here; expected attribute "content", "dir", "http-equiv", "lang", "name", "scheme" or "xml:lang"
ERROR(RSC-005): tests/book-v2.epub/OEBPS/cover.xhtml(11,42): Error while parsing file: attribute "epub:type" not allowed here; expected attribute "dir", "id", "lang", "style", "title" or "xml:lang"

I'll take the time to look the other errors in the cover.xhtml when this PR will be merged.

@e-adrien is it okay if we merge this PR prior to working on epub2? I'd love to have this fixed for our Epub3-only usage

Done. I'll do the change for EPUB 2 in the coming days. 🙂

@crutchcorn I just published a new version


Feature: Domain attribute

Hi there, I was wondering what your thoughts on adding domain as one of the argument / features for routing? I'm currently looking into using this for a tenancy based project and was wondering on what your thoughts would be for it. Thanks!

If the code is simple, I'd accept a PR for this with updated tests/readme.

I have never written a test before but I'll try my best


zmodem: Remove CONFIG_HAVE_INLINE from compiler.h

Summary
follow up the kernel side change
Impact
No function chnage since host binary don't use these variables.
Testing

Follow up the kernel change: https://github.com/apache/incubator-nuttx/pull/1321


istioctl: support yaml output format for tag list

Please provide a description of this PR:

@my-git9: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5fd6ee6633b9128caab938cc5985330451578b68
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test unit-tests-arm64


Update commonmark spec 0.30

Fixes #563
Still an issue with the Example 539
[ẞ]

[SS]: /url

It seems that compare OrdinalIgnoreCase doesn't support Unicode Case folding? Or this particular character: ẞ Latin Capital Letter Sharp S.
@MihaZupan thoughts?

Opened https://github.com/dotnet/runtime/issues/68287 to see if .NET can do this out of the box or if we'd have to roll our own logic here

That API does not exist on net452 though... so time to remove that target (again 😄)?

Thank you! The problem is small enough that we can ifdef it for now. net452 will not be completely 0.30 compliant, but it is so minor that it's probably ok.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

535 of 535 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 93.101%

Totals

Change from base Build<PHONE_NUMBER>:
0.009%

Covered Lines:
25669

Relevant Lines:
26938

💛  - Coveralls


Extract cri runtime configs to separate files

What is the problem you're trying to solve
Today the config.toml houses all the runtime config.
When you need to add/change a runtime you have to restart containerd.
Also the config itself gets large and unwieldy.
Injecting a runtime into the main config can also be troublesome when trying to do so from an automated installer.
Describe the solution you'd like
Much in the same way cri registry configs were extracted, I propose we extract runtime config like to something like /etc/containerd/runtimes/<handler>/config.toml
Each time a config needs to be resolved it should load from this config file.
This allows adding/updating runtime handlers without restarting containerd.
Additional context
An example that may benefit from this is https://kwasm.sh

I think it is useful. For example, when we need to add nvidia runtime to a node, we need to modify config.toml and then restart containerd; this will cause kubelet to report that the node status is unhealthy.

/assign

https://docs.google.com/document/d/1YY5xrzjrnNdSbr5840sYWRaXW6fBGXp8TNqB3htlnqs/edit?usp=sharing


💡 [more nesting, enter as escape]

Currently working on a large project, where i wanted to be able to have more nesting within tasks.
Just allowing for more nesting of tasks and topics would be nice.
Also would be nice if enter key could also act with same functionality as escape key, as when finishing writing/editing a task, it feels natural and would make sense to complete writing with enter too and it feels natural. Also same with selecting and entering a topic.
Love dooit, it's beautifully simple and effective!

Just allowing for more nesting of tasks and topics would be nice.

Nesting can be done but It chose not to do it because:

It would mess up the UI
It caused a lot of complications while writing code

would be nice if enter key could also act with same functionality as escape key

Yes, I was thinking the same
I'll push an update later to change that in the config file
The main idea behind escape to act more like vim
but I guess I should re-map escape to something like: Cancel the current todo edit?

Implemented!


npm install fails

npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>

Thank you for rephrasing your comment.
Angular 2 has a peer dep on reflect metadata. This can be fixed by pinning to 0.1.2. I just updated the package to do so, tho this is a workaround IMO.
cc // @igorminar wardbell

A bit too hasty on the comment but yes it is about reflect metadata 0.1.3. Once the ^ is removed the error goes away.

I get the following errors...
npm ERR! peerinvalid The package rxjs does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
Changing the following does the trick...
From:
"rxjs": "^5.0.0-beta.0",
To:
"rxjs": "5.0.0-beta.0",

And now
The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>Changing
"zone.js": "^0.5.10"
to "zone.js": "0.5.10"
fixes it

old error, now updated to beta 3 and zone 0.5.11

Installing a new version of npm/node.js also solves this problem. :-)


Gasless minting

User don't want to pay gas fees to receive tokens and NFTs.
There's a good chance users wont know what gas fees are and they shouldn't have to for Level1.

linked to #47


database service: implement reload for aws.database

On destruction of the aws.database, the dbSubnetGroup cannot be destroyed until the underlying DBInstance has been completely deleted. This takes a while, so it would be nice to reload and check the status of the DBInstance (assuming it's status is still available post-delete).

Closed by PR #87


util: net: download: Only logging on first download

We the way the filtering is setup means that only one call to cached_download results in logging, not every single time it is called, we need some kind of context for the progress bar percent filtering

ping @programmer290399

maybe we need to reset the duplication filter or manipulate it to get empty when all the 100 logs of the progress bar are in it , looking into it 🙂


Updating environment for Service Fabric Cluster.

Cleaning up the metadata file, adding script for creating needed certificate.  Also renamed ARMTemplates folder to Environments per to clarify what these ARM templates should be used for.


Add a JS package to handle ABI encoding/decoding

Problem
Currently acvm_js assumes that the caller can provide an initial witness with which to execute the circuit.
This is fine for relatively simple programs but it's not a good experience and makes more complex noir programs unwieldy to work with.
Happy Case
In order to interact with Noir programs in the browser we need a way to construct the initial witness from a set of inputs similar to what we have in Prover.toml.
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
Yes
Support Needs
No response

Add a JS package

Is there any value for it to live as a standalone package? Would it make sense to merge it into noir_wasm or acvm_js?

Neither of those two packages are good spots for this functionality to live tbh.
noir_wasm: This would require a user to load a complete copy of the noir compiler in order to construct initial witnesses.
acvm_js: See https://github.com/noir-lang/acvm-simulator/issues/4

Hmm reasonable.
The need for wrapping everything into one Noir.js package as an option seems to be growing. Fiddling with 4+ packages just to get started sounds like a DevEx nightmare.


Fix misspelled personal-access-token filename

Fix the filename on the readme instructions, so future developers can start the project on the first run.

🤦♂ wow, my mistake. Good catch, @rbngzlv !


Issue with the mod "alex caves"

There are missing textures for any backpack that gets a trim, the texture is just black and purple. the normal backpacks are fine but when I try to put a trim on them the texture doesn't work. this is only a problem with the "Alex Caves" mod.

I'll look into adding them. For now, if you know how to make resource packs here's the link to the wiki about Adding Modded Trims

Just wanted to add that the issue also occurs when using vanilla trims, not just Alex's Caves ones. But Alex's Caves is the mod that is causing this problem

its for every trim

I added a way to easily add textures for backpacks a few updates ago and to load all the textures for the backpack trims, there needed to be a specific number of trims loaded and alex's caves pushed things around that caused none of my textures to load.
Also I'll add a texture for the trim the mod adds too in version 20.1-0.20-v2

0.20-v2 is live ;) thanks for the report


Fix a warning when compiling Envoy.

Fix this build error:
INFO: From Compiling external/com_github_envoyproxy_sqlparser/src/parser/flex_lexer.cpp:
flex_lexer.cpp:3577:16: warning: function 'yyinput' is not needed and will not be emitted [-Wunneeded-internal-declaration]
    static int yyinput (yyscan_t yyscanner)
               ^
1 warning generated.

Regenerated flex_lexer.cpp and flex_lexer.h with flex 2.6.4 (Fedora).
Testing: bazel test //test/extensions/filters/network/mysql_proxy/... runs successfully.

Thanks, @ipuustin. I can confirm in my local that this works fine.
Probably submitting a PR using the patched repository_locations of your fork on envoy main repo will basically prove this through CI build. (meanwhile, we are putting a proper CI on this repo). WDYT?


Watchman alert: switch.adaptive_lighting_default [missing]

Version information:
1.4.1
Description:
Watchman reports this missing entity:
switch.adaptive_lighting_default [missing]
services.yaml
Not sure how to resolve this?

Duplicate of #408
There's no actual issue, watchman is just detecting that the example values adaptive-lighting has in services.yaml don't exist.
Is watchman spamming your logs with these errors or is it easily ignorable? I could include a 'fix' for this in #460


Add feature that shows fees for each vault (and for earn)

For both v1 and v2 vaults, show all fees (withdrawal, performance, management) associated with vault
Can pull this data directly from contract
Could also help to explain how withdrawal fee works (only applies when removing funds from strategy)
Explain that Earn product has no fees as well

Fees are currently shown in UI


Support for mixed types in arrays of objects

Hello! I'm trying to use this SMT to transform some data I have in a Mongo Database into a Connect record. It works very well overall, but I have one field that looks like this:
[
  { "tagName" : "SourceFile", "tagValue" : "string", "tagGroup" : "none" },
  { "tagName" : "SourceFile", "tagValue" : 199, "tagGroup" : "none" },
  { "tagName" : "SourceFile", "tagValue" : [ "tag1", "tag2 ], "tagGroup" : "none" }
]

This fails with the following error:
org.apache.kafka.connect.errors.DataException: Invalid Java object for schema type STRING: class java.lang.Double for field: "tagValue"
        at org.apache.kafka.connect.data.ConnectSchema.validateValue(ConnectSchema.java:245)
        at org.apache.kafka.connect.data.Struct.put(Struct.java:216)
        at org.apache.kafka.connect.data.Struct.put(Struct.java:203)
        at com.redhat.insights.expandjsonsmt.DataConverter.convertFieldValue(DataConverter.java:35)
       ...

It seems to set the schema type for tagValue based on whatever it sees first. For example, if the array was the first thing it saw, I would get an error like Invalid Java obect for schema type ARRAY: class java.lang.Double....
Is this expected for how this SMT is currently designed? If not, is it something that it's possible to add support for? Thanks!

Hello @jpavlick, nice to see our tool is useful for you. It's some time ago I've implemented that. If I remember correctly, yes, schema is created dynamically from the first item, what is quite convenient in most cases, I think. I don't think there is any simple workaround how to support such "multi-type" field.
But to be honest, I don't think it's a good idea to have such data in database. I would rather define "tagValue" as a array in general so you can store: ["string"], ["199"] and ["tag1", "tag2"]. Then you will avoid this issue and probably some others, I guess. Likely it's not the only place where you are going to process this data and it's always much easier when you can expect the same type for each record. Regrds.

Thanks for the reply, and sorry it took me awhile to get back to you. We don't actually have access to the source data to be able to change the data at the source, and since it's valid json it seems like perhaps this SMT should be able to handle that use case.
That said, I recognize why it's difficult to do in Java, so I decided to create my own SMT to handle this specific case and coerce the singletons into arrays of strings, as per your suggestion. That fixed our issue, so I'll go ahead and close this issue. Thanks for the response!


Add missing tabIndexes to documentation

There is missing tabIndex property in the documentation of components: Button, ButtonLink, Checkbox, Radio, TextLink, InputField, InputFile, InputStepper, Select and Textarea.

Closed by #984


[AutoPR attestation/data-plane] Add data plane API swagger for attestation

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7521

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/9056


[SPARK-14635] [ML] Documentation and Examples for TF-IDF only refer to HashingTF

What changes were proposed in this pull request?
Currently, the docs for TF-IDF only refer to using HashingTF with IDF. However, CountVectorizer can also be used. We should probably amend the user guide and examples to show this.
How was this patch tested?
unit tests and doc generation

Test build #56049 has started for PR 12454 at commit 72594f0.

Test build #56049 has finished for PR 12454 at commit 72594f0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56049/
Test PASSed.

OK by me

I had originally thought we could include some code for CountVectorizer in the example... but it might be a bit verbose then, so this looks better actually.
Made a few small doc comments, otherwise LGTM.

Thanks for the careful review. Updated according to the comments.

Test build #56075 has started for PR 12454 at commit cb84f5e.

Test build #56075 has finished for PR 12454 at commit cb84f5e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56075/
Test PASSed.

Merged to master


Customer Question Answer Optimization

Benefit/Result/Outcome
As a system integrator, I want to receive timely responses to questions I have for Mission LZ so that I can be successful in my implementation of Mission LZ in my cloud environment
Description
We provide an automated way to triage backlog items that have the "question" tag attached
One idea, is to auto populate a discussion thread from the backlog item
*Another idea is to auto-respond to issues tagged with the question parameter and point them to documentation
Acceptance Criteria

Documentation is created to outline this new process
Automation workflow is created to help direct system integrators to get answers more timely

It's fine for people to post questions in the issues list. The existing automation in GitHub that sends notifications is currently working.


Merge master changes to experimental branch

This pull request will merge changes in the master to the experimental branch.

CRAP! Accidentally created the pull request backwards, but since I can't delete pull requests I will go ahead and merge them in the experimental branch.

Well, I've made so many changes that master can't be merged, oh well. It was an invalid pull request anyways.


cargo tree -e no-proc-macro to hide procedural macro dependencies

Probably resolves #9165
cargo tree -e no-proc-macro now hides procedural macro dependencies.
Note that when passed with --invert <spec>, the spec's reverse proc-macro dependencies are also hidden. Is this desired result?
Also, since I want -p <spec> and -i <spec> works with any valid package-id in the project, the filter logic is written in print stage instead of graph build stage

r? @ehuss
(rust-highfive has picked a reviewer for you, use r? to override)

@rfcbot fcp merge
@rust-lang/cargo This is a small addition to add cargo tree -e no-proc-macro to filter out proc-macros from the cargo tree output. This can be helpful if you are interested in which dependencies are actually included in the target binary, and proc-macros can clog the output with lots of dependencies.

@bors: r=ehuss

:pushpin: Commit c2fd499eac57b484493d37da7ecdba391344b2ea has been approved by ehuss

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 238a9fa71f8bc1b5b3530ae8c18e02a892e6b0b1 to master...


Add files via upload

Updated Lavaeolous's scripts to include the PF1 prestige class, Assassin.

1_Avalexi.txt
This was my test case. A succubus assassin in my mythic shattered star campaign.  Once the class was loaded in it worked a treat.
I am also including the JSON file for the full class.  Still working on all the class features though.
fvtt-Item-Assassin.json.txt

Thanks a lot! I've merged this just now and it will be included in v.2.0.6