root.Date is undefined.

I've installed<EMAIL_ADDRESS>via JSPM, and I'm getting "root.Date is undefined" errors in Firefox (and a similar error in Chrome). I'm using<EMAIL_ADDRESS>Error: (SystemJS) root.Date is undefined
now@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/now.js:20:3
setData@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/_setData.js:27:17
createWrap@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/_createWrap.js:104:26
ary@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/ary.js:26:10
castFixed@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/fp/_baseConvert.js:286:37
wrap/</<@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/fp/_baseConvert.js:459:31
arrayEach@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/_arrayEach.js:15:9
wrap/<@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/fp/_baseConvert.js:452:7
arrayEach@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/_arrayEach.js:15:9
wrap@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/fp/_baseConvert.js:451:5
baseConvert@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/fp/_baseConvert.js:486:12
convert@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/fp/convert.js:15:10
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/fp/startsWith.js:2:12
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/fp/startsWith.js:1:31
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/fp/startsWith.js:1:2
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/lib/META.js:8:20
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/lib/META.js:1:31
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/lib/META.js:1:2
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/lib/index.js:145:14
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/lib/index.js:1:31
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/lib/index.js:1:2
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/elements/Button/Button.js:19:12
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/elements/Button/Button.js:1:31
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/elements/Button/Button.js:1:2
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/elements/index.js:7:15
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/elements/index.js:1:31
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/elements/index.js:1:2
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/addons/Confirm/Confirm.js:13:17
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/addons/Confirm/Confirm.js:1:31
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/addons/Confirm/Confirm.js:1:2
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/addons/index.js:7:16
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/addons/index.js:1:31
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/addons/index.js:1:2
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/index.js:7:15
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/index.js:1:31
@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/stardust@0.38.1/dist/index.js:1:2

Evaluating<EMAIL_ADDRESS>Evaluating<EMAIL_ADDRESS>Evaluating<EMAIL_ADDRESS>Evaluating<EMAIL_ADDRESS>Evaluating<EMAIL_ADDRESS>Evaluating<EMAIL_ADDRESS>Evaluating<EMAIL_ADDRESS>Evaluating<EMAIL_ADDRESS>Error loading http://localhost.corp.yahoo.com:8080/web/main.js

I'm not sure if there's any extra configuration I should be doing. I've simply installed it via jspm install<EMAIL_ADDRESS>and added import { Dropdown } from 'stardust'; to one of my components.

Stardust has no code that accesses .date(). This seems to be an error with lodash, now.js at line 20 col 3:
Error: (SystemJS) root.Date is undefined
now@http://localhost.corp.yahoo.com:8080/jspm_packages/npm/lodash@4.15.0/now.js:20:3

Also, it looks like the start of stack trace might offer more help, main.js failed to load:
Error loading http://localhost.corp.yahoo.com:8080/web/main.js

Closing for now as this seems unrelated to Stardust at all.  Let me know if you feel otherwise and why.

Looks like an error with however JSPM is bundling your code. root is the root/global object that lodash uses to access global API's (such as Date), so somehow your bundler is executing your code in some context that conflicts with this lookup.
See: https://github.com/lodash/lodash/blob/master/lodash.js#L405-L406
Definitely not a Stardust issue, but I'd love to hear what you figure out.

Thanks for the extra notes @davezuko, much appreciated.


field adjustments to collection struct

Changes:

Small changes to collection struct as mentioned in https://github.com/gallery-so/go-gallery/issues/38

Considerations:

bson tags can have an optional ,omitempty such as bson:"contract_name,omitempty" that will make sure that empty falsy fields are not put into mongo when a struct field is it's 0 value. Which fields do we want to have omitempty? My vote is that most fields should have omitempty and only the required ones don't

I agree with putting omitempty by default, and making exceptions for fields that don't need it


Release 149.0.1

Patch release of GasFeeController to fix an error being thrown in the extension background.
This includes the PR #4245

You can run yarn constraints --fix && yarn to address the current lint failure

closing in favour of https://github.com/MetaMask/core/pull/4275


small edits

I have more corrections...I'm taking a late lunch but afterwards I have
tweaks in about 7 more files. So hold off on any more merging till I'm
done. Thanks.
Lois
On Fri, Mar 30, 2018 at 3:01 PM, Vladimir Diaz<EMAIL_ADDRESS>wrote:

Merged #31
https://github.com/theupdateframework/theupdateframework.github.io/pull/31
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theupdateframework/theupdateframework.github.io/pull/31#event-1550210862,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AN5qX3C6RXaWqZPjUM8pcowJErqUOR9Lks5tjoEagaJpZM4TCBhU
.


to trigger eden workflow based on condition

PR to use the new eden workflows for testing eve changes in PR, master and tag builds. Added concurrency across the workflow with cancel-in-progress: to avoid clogging of the builds. I have used multiple workflow triggers based on different conditions because github actions doesn't supports if else condition as per my understanding.
The run shell is an option but then we have to specificy the attribute runs-on which will cause delay in the trigger(based on the workload)
Please feel free to offer any other suitable options.

LGTM, couple comments:

I'd switch workflows so that there will be no two testing workflows running in paralllel
I'm not sure I understand how concurrency will work in case somebody will re-approve same PR I guess it'll re-trigger tests, which is not desirable, but tolerable for now. I did some digging and there's this fancy github.event.before and github.event.after which we can use to determine if git HEAD has changed, i.e.

      - name: Check if PR is Approved and No New Commits
        id: approval_and_no_new_commits
        run: |
          if [ "${{ github.event_name }}" == "pull_request" ] && [ "${{ github.event.action }}" != "closed" ]; then
            if [ "${{ github.event.pull_request.labels.*.name }}" == "approved" ] && [ "${{ github.event.before }}" == "${{ github.event.after }}" ]; then
              echo "PR is approved and has no new commits."
              echo "::set-output name=approved::true"
            else
              echo "PR is not approved or has new commits."
              echo "::set-output name=approved::false"
            fi
          fi
        shell: bash

      - name: Run Tests
        if: steps.approval_and_no_new_commits.outputs.approved == 'true'
        uses: lf-edge/eden/.github/workflows/test.yml@master
        with:
          eve_image: //...

But if I understand concurrency tag, if we add this and somebody will re-approve concurrency will stop previous job and new will not be triggered since there are no changes in PR. Alternative to it would be to remove concurrency group but then we will have blank jobs, when somebody re-approved job. What are your thoughts @yash-zededa ?

@uncleDecart I think the issue only would be with the PR builds, we can have few more checks but that would involve use of a runner and that in my opinion would contribute to a delay. I think using labels would be an ideal approach, the tests would be triggered on PR only when there is a specific label is present. master branch and tag build should not cause any issue in my opinion. Moving forward, we can also label the PR automatically based on certain conditions - this will also reduce the congestion due to PR builds.

Update: did experiment with new workflows: created PR in fork with changes and approved it twice and it triggered tests twice (1 and 2), which is not desirable.
Will test labels now, if they will work then in order for tests to be run we will have to put labels manually, then we can automatize this by adding github bot.

Update: did experiment with new workflows: created PR in fork with changes and approved it twice and it triggered tests twice (1 and 2), which is not desirable.
Will test labels now, if they will work then in order for tests to be run we will have to put labels manually, then we can automatize this by adding github bot.

The label trigger worked as expected but the combination of approved + labelled is not working. The pull request approval event should have the label info in it for the PR to be build - which is not desriable.
I am testing the https://github.com/abinoda/label-when-approved-action - if this works then we can test the same.

Note that DCO is failing since none of the commits are signed with your name and email. All of the commits need to be signed. git commit -S does that.

Thanks, at times I forget to use -s. Signed all the commits. I will squash all the commits once testing is completed.

Update:
We attempted to use https://github.com/marketplace/actions/label-approved-pull-requests, but it did not work properly. Although the PR was marked test-eden,  the github actions were not initiated.
As of now, we will proceed with the understanding that re-approval of the same PR will result in a new process run and the previous will be cancelled.

We attempted to use https://github.com/marketplace/actions/label-approved-pull-requests, but it did not work properly. Although the PR was marked test-eden, the github actions were not triggered.

Did you try what is suggested in https://stackoverflow.com/questions/62325286/run-github-actions-when-pull-requests-have-a-specific-label ?

yetus failed but generated no annotations against the diffs. Sigh.
Looking at the yetus logs I see this
-1 overall

  | Vote |      Subsystem |  Runtime   | Comment
  ============================================================================
  +---------------------------------------------------------------------------
  |      |                |            | Prechecks
  +---------------------------------------------------------------------------
  |  +1  |       dupname  |   0m  0s   | No case conflicting files found.
  +---------------------------------------------------------------------------
  |      |                |            | master Compile Tests
  +---------------------------------------------------------------------------
  +---------------------------------------------------------------------------
  |      |                |            | Patch Compile Tests
  +---------------------------------------------------------------------------
  |  +1  |     codespell  |   0m  2s   | No new issues.
  |  +1  |    detsecrets  |  12m 44s   | No new issues.
  |  +1  |        blanks  |   0m  0s   | The patch has no blanks issues.
  |  -1  |      yamllint  |   0m  0s   | The patch generated 1 new + 0 unchanged
  |      |                |            | - 0 fixed = 1 total (was 0)
  +---------------------------------------------------------------------------
  |      |                |            | Other Tests
  +---------------------------------------------------------------------------
  |      |                |  12m 51s   |

Can you try yamllint manually? Might need to add the yamllint package to your laptop.

We attempted to use https://github.com/marketplace/actions/label-approved-pull-requests, but it did not work properly. Although the PR was marked test-eden, the github actions were not triggered.

Did you try what is suggested in https://stackoverflow.com/questions/62325286/run-github-actions-when-pull-requests-have-a-specific-label ?

Yes, I tried this but unfortunately it didn't worked, The label was added but the github actions was not triggered when the PR was labelled.

yetus failed but generated no annotations against the diffs. Sigh. Looking at the yetus logs I see this
-1 overall

  | Vote |      Subsystem |  Runtime   | Comment
  ============================================================================
  +---------------------------------------------------------------------------
  |      |                |            | Prechecks
  +---------------------------------------------------------------------------
  |  +1  |       dupname  |   0m  0s   | No case conflicting files found.
  +---------------------------------------------------------------------------
  |      |                |            | master Compile Tests
  +---------------------------------------------------------------------------
  +---------------------------------------------------------------------------
  |      |                |            | Patch Compile Tests
  +---------------------------------------------------------------------------
  |  +1  |     codespell  |   0m  2s   | No new issues.
  |  +1  |    detsecrets  |  12m 44s   | No new issues.
  |  +1  |        blanks  |   0m  0s   | The patch has no blanks issues.
  |  -1  |      yamllint  |   0m  0s   | The patch generated 1 new + 0 unchanged
  |      |                |            | - 0 fixed = 1 total (was 0)
  +---------------------------------------------------------------------------
  |      |                |            | Other Tests
  +---------------------------------------------------------------------------
  |      |                |  12m 51s   |

Can you try yamllint manually? Might need to add the yamllint package to your laptop.

It might because I removed the trigger for eden.yml and not added the # yamllint disable-line rule:truthy line. Let me add this line.

Yetus checks are passing now. I am waiting for PR-884 to be merged and a tag created so that I can point to a release rather than to a branch.

Yetus checks are passing now. I am waiting for Eden PR-884 to be merged and a tag created so that I can point to a release rather than to a branch.

I've metged 884 in eden

BuildJet runners are working link to actions
But this PR needs changes: we are still failing on Upgrade test, because we are changing registry in our workflows here and for PRs we set it as evebuild/danger, therefore when upgrading we try to pull from evebuild/danger, it fails.
There are two possible solutions:

We build eve and use docker tag to link evedanger image to lf-edge/eve image and use lf-edge/eve
We add parameter registry parameter to eden utils download command and specify it in our tests, that way no matter where we are running our new workflows (be it on lf-edge/eve repository or any other fork) we will eve from lf-edge for upgrade test

We will try out 1) approach on local fork since it's easier to implement to confirm that this is the problem

But this PR needs changes: we are still failing on Upgrade test, because we are changing registry in our workflows here and for PRs we set it as evebuild/danger, therefore when upgrading we try to pull from evebuild/danger, it fails.

Is the issue that one of the images (the PR) is in evebuild/danger and the other image is in eve/?
If so, how did we handle this in the old tests?
FWIW pollution eve/ with PRs seems bad; less of an issue to insert/link the eve images we will need for the update test in evebuild/danger.

But this PR needs changes: we are still failing on Upgrade test, because we are changing registry in our workflows here and for PRs we set it as evebuild/danger, therefore when upgrading we try to pull from evebuild/danger, it fails.

Is the issue that one of the images (the PR) is in evebuild/danger and the other image is in eve/?
If so, how did we handle this in the old tests?
FWIW pollution eve/ with PRs seems bad; less of an issue to insert/link the eve images we will need for the update test in evebuild/danger.

Yes it is that issue. We used docker tag to link images we need from evebuild/danger to eve locally, so when eden command runs it'd actually pull evebuild/danger when trying to access image from lf-edge/eve. That Way there was no pollution of lf-edge/eve with PRs and that's why I thought it'd be a good idea to do that.
However, with new workflows it's not that simple. Since we are using reusable workflows and we can't assume that building eve and running docker tag and testing (i.e. executing reusable workflow) will happen on same machine.
We, of course can use artifacts to to push evebulid/danger and I think that will be same polluting as pushing images.
Another alternative which we could explore is GitHub or BuildJet cache, which actually provides 10Gbs of storage (20Gbs f
or BuildJet) for free. That would make it possible to communicate artifacts between jobs without saving them. I think that using cache would actually make sense to speed up our testing even more (i.e. caching kernel builds).
But for now what we should do in my opinion is add parameter registry parameter to eden utils download command and specify it in our tests, that way no matter where we are running our new workflows (be it on lf-edge/eve repository or any other fork) we will eve from lf-edge for upgrade test

@yash-zededa let's try to run new workflows manually, upgrade test should work now I merged https://github.com/lf-edge/eden/pull/893

@yash-zededa let's try to run new workflows manually, upgrade test should work now I merged lf-edge/eden#893

Thanks @uncleDecart, triggering the workflow manually.

@yash-zededa @uncleDecart is this ready to merge?
Once we've build 10.10.0 I'm open to merging it and then we will see how it works in real life.

BuildJet runners are working link to actions

@uncleDecart Collect logs action should also append suite name to the created artifact. Otherwise we only get 4 artifacts, even though there are 11 different workflows.

@milan-zededa created PR for that https://github.com/lf-edge/eden/pull/897

@yash-zededa @uncleDecart is this ready to merge?
Once we've build 10.10.0 I'm open to merging it and then we will see how it works in real life.

@eriknordmark upgrade workflow runs now (at least it worked with zfs) I'd wait for https://github.com/lf-edge/eden/pull/897 to be merged to eden, release eden 0.9.0 and then merge this

@yash-zededa eden 0.9.0 is here https://github.com/lf-edge/eden/releases/tag/0.9.0

@yash-zededa eden 0.9.0 is here https://github.com/lf-edge/eden/releases/tag/0.9.0

It would be good though to include this PR, otherwise we will not be able to find out why onboarding sometimes fails.

@milan-zededa merged your PR and released 0.9.1 https://github.com/lf-edge/eden/releases/tag/0.9.1
@yash-zededa it might be a good idea to point EVE to latest eden version if that's possible

@uncleDecart @yash-zededa It seems that there is some problem with publish-logs/action.yaml not including eve-info.tar.gz in artifacts.
From workflow logs I can see:
Received eve-info.tar.gz with size 1418640
...
Run actions/upload-artifact@v3
  with:
    name: eden-report-networking.tests.txt-tpm-true-ext4
    path: /home/runner/actions-runner/_work/eve/eve/eden/eve-info.tar.gz # created by collect-info action
  /home/runner/actions-runner/_work/eve/eve/eden/trace.log
  /home/runner/actions-runner/_work/eve/eve/eden/info.log
  /home/runner/actions-runner/_work/eve/eve/eden/metric.log
  /home/runner/actions-runner/_work/eve/eve/eden/netstat.log
  /home/runner/actions-runner/_work/eve/eve/eden/console.log
  /home/runner/actions-runner/_work/eve/eve/eden/adam.log

But collected artifact does not contain eve-info.tar.gz.
Maybe working directories between collect/upload actions do not match?

@milan-zededa created PR, this should fix missing artifacts

@yash-zededa PR is merged, can you run locally and see the results?

@yash-zededa PR is merged, can you run locally and see the results?

@uncleDecart I have executed the action pointing to my forked-repo
https://github.com/yash-zededa/eve/actions/runs/6453056486/job/17515985025
Once the execution is successful and the zip file is part of the artefact we are good to merge this.

Looks like some commits lost their DCO signoff: Commit sha: 4eae750, Author: yash-zededa, Committer: yash-zededa; The sign-off is missing. Commit sha: 9500d5f, Author: yash-zededa, Committer: GitHub; The sign-off is missing.
Also, we are waiting on @uncleDecart @giggsoff to figure out the eden PR.

commits are squashed and signed now.

@yash-zededa PR is merged, can you run locally and see the results?

@uncleDecart I have executed the action pointing to my forked-repo
https://github.com/yash-zededa/eve/actions/runs/6453056486/job/17515985025
Once the execution is successful and the zip file is part of the artefact we are good to merge this.

Do you have access to buildjet-4vcpu-ubuntu-2204 runners in your fork? It was my point and it was resolved as I remember.

I think I had seen a run from my work using the buildjet-4vcpu-ubuntu-2204, let me look for that run

@uncleDecart I think we should merge this PR now. It has been going on since quite sometime :). I have pushed the changes considering we would release 0.9.2 tag for eden, Can you please create the required tag on eden.

sure @yash-zededa, but does it work with master on lf-edge's eden repo?

sure @yash-zededa, but does it work with master on lf-edge's eden repo?

Yes, it is working with lf-edge/eve pointing to eden master.
https://github.com/lf-edge/eve/actions/runs/6454241589/job/17519368579
Seems like @giggsoff was correct my forked repo is not having access to the buildjet runners. May be I was confused as we are testing too much, lol :)

sure @yash-zededa, but does it work with master on lf-edge's eden repo?

Yes, it is working with lf-edge/eve pointing to eden master.
https://github.com/lf-edge/eve/actions/runs/6454241589/job/17519368579
Seems like @giggsoff was correct my forked repo is not having access to the buildjet runners. May be I was confused as we are testing too much, lol :)

Seems there is another error: https://github.com/lf-edge/eve/actions/runs/6454241589/job/17520292589#step:3:6919. And another one: https://github.com/lf-edge/eve/actions/runs/6454241589/job/17520292589#step:3:6845 (we skip ssh option because of the problem).
Also I can see not based on an OCI image here. Which indicates that we try to run vnc test (with qcow2 image inside) on the EVE-os without hardware acceleration, which is not expected (but looks like a separate issue for the PR).

@giggsoff I think we can merge it as of now and try to fix tests separately (because this workflow is using 10.4.0 EVE and collect-info.sh should be there)

@giggsoff I think we can merge it as of now and try to fix tests separately (because this workflow is using 10.4.0 EVE and collect-info.sh should be there)

@eriknordmark Appreciate if you can merge this

@giggsoff I created issues in eden addressing your comment
https://github.com/lf-edge/eden/issues/901
https://github.com/lf-edge/eden/issues/902

@giggsoff I created issues in eden addressing your comment
lf-edge/eden#901 lf-edge/eden#902

Thank you!


Error in Padding

@xsznix Ran into this in my fork (for a class I TA)
https://github.com/xsznix/js-y86/blob/master/js/assem.js#L4
Check out what happens when you attempt the following instruction:
irmovl 0x1000, %esp

You can solve the problem by either converting the number to bigendian before passing it to padhex (and then back), or write a padlittleendian hex function.

Thanks for the report!
I suppose you and/or your students have come across this while learning Y86. Glad to know it may be useful after my current class is done with it.


fix: reset form when returning to artwork screen

The type of this PR is: fix
This PR resolves a bug found in QA. PURCHASE-2223 is the one I set out to address (shipping checkbox gets its logic flipped if you exit/enter the form with it checked) but I think this actually will fix another bug where the 'send' button gets similarly messed up. I don't know if that was found in QA since I reported the former and assumed they were the same thing - they are not.
On an implementation level it:

Extracts the 'inquiry question' checkbox into its own component
cleans up some logic within the component, moving Animation setup into useLayoutEffect
resets the form when exiting the inquiry modal, which prevents another bug causing the shipping checkbox to get flipped after exiting and re-entering
removes some reducer code that mutates our starting value, making it possible to wind up in an unsubmittable state after exiting and re-entering

Description
To see the bug, enter the inquiry form, tick the shipping box, press cancel to exit the form, and then re-enter the form. The form will be in a bad and unactionable state. This PR fixes it by resetting form state when leaving.

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

#squashongreen


Team a get content rework

Swapped to using Moodle functions that better suit the requirements for obtaining quizzes and essays while also doing some clean-up within the beans file.

Closed due to changes having been merged into the Clean branch


updated cards of opportunity page.

What is the change?
Updated card sequence and fixed the responsive view of cards for different screen type.
I have commented my code where ever required.
Related issue?
closes: #165
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] I have followed the Code of Conduct.
[x] I have  checked there aren't other open Pull Requests for the same update/change.
[x] I have you tested the code before submission.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm HSOC contributor.

Screenshots (if any)
my desktop view

iphone SE

ipad Air

ipad mini

next hub

next hub pro

Thanks!!!


No Audio output on macos 10.14.6

it seems that the back jack not work on 10.14.6 with AppleALC.kext ,  not tested on 10.14.5

Do you see audio devices at all?

I dont know what happened, I tried reinstall clover, it tunes ok for me, perhapse somthing wrong on my first installing


Won't send Phoenixes between planets

Queller doesn't send interstellar fighters between planets.

There is not support for this within the AI.


Update MD file on new branch 2017-11-20_13-34-06

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[254-llm-chatbot] InferRequest.start_async() got an unexpected keyword argument 'shared_memory'

Describe the bug
I followed the following web installation process and found that whether I select CPU or GPU on Device, it will happen:
TypeError: InferRequest.start_async() got an unexpected keyword argument 'shared_memory'

Screenshots
If applicable, add screenshots to help explain your problem.

Installation instructions (Please mark the checkbox)
[ ✓] I followed the installation guide at https://github.com/openvinotoolkit/openvino_notebooks#-installation-guide to install the notebooks.

same

Intel® Xeon(R) W-1290E CPU @ 3.50GHz × 20
Ubuntu 20.04.6 LTS
and
13th Gen Intel® Core™ i9-13900E × 32
Ubuntu 22.04.3 LTS
Both environments get the same result.

Hi @hsulin0806 could you help to check the version of openvino in your system?
 pip freeze | grep openvino

你好@hsulin0806你可以幫忙檢查一下你係統中openvino的版本嗎？  pip freeze | grep openvino

Intel® Xeon(R) W-1290E CPU @ 3.50GHz × 20
Ubuntu 20.04.6 LTS
pip freeze | grep openvino
nncf @ git+https://github.com/openvinotoolkit/nncf@dc928a9e45b2dba3fd6cf8ad8c046b56d5da35f3
openvino-nightly==2024.0.0.dev20240103
openvino-telemetry==2023.2.1
Note: you may need to restart the kernel to use updated packages.
and
13th Gen Intel® Core™ i9-13900E × 32
Ubuntu 22.04.3 LTS
pip freeze | grep openvino
openvino==2023.2.0
openvino-dev==2023.2.0
openvino-nightly==2024.0.0.dev20240103
openvino-telemetry==2023.2.1
Note: you may need to restart the kernel to use updated packages.

could you uninstall openvino and openvino-dev, then see if the error still exists ?

您可以卸載openvino然後openvino-dev看看錯誤是否仍然存在？

An error will occur.
RuntimeError: Failed to import optimum.intel.openvino because of the following error (look up to see its traceback):
No module named 'openvino.runtime'

您可以卸載openvino然後openvino-dev看看錯誤是否仍然存在？

An error will occur.
RuntimeError: Failed to import optimum.intel.openvino because of the following error (look up to see its traceback): No module named 'openvino.runtime'

Just reinstalling optimum-intel shall be ok

您可以卸載openvino然後openvino-dev看看錯誤是否仍然存在？

An error will occur.
RuntimeError: Failed to import optimum.intel.openvino because of the following error (look up to see its traceback): No module named 'openvino.runtime'

Just reinstalling optimum-intel shall be ok
Again @@
TypeError: InferRequest.start_async() got an unexpected keyword argument 'shared_memory'

%pip freeze | grep openvino
nncf @ git+https://github.com/openvinotoolkit/nncf@6d6416d631497aaa2cf246c98ab31fb8c97d5847
openvino-nightly==2024.0.0.dev20240103
openvino-telemetry==2023.2.1
Note: you may need to restart the kernel to use updated packages.

maybe you can try to install a lower version of openvino-nightly, .e.g. ```pip install openvino-nightly==2023.3.0.dev20231219

maybe you can try to install a lower version of openvino-nightly, .e.g. ```pip install openvino-nightly==2023.3.0.dev20231219

Thank u
pip install openvino-nightly==2023.3.0.dev20231219 This is the key!
The internal graphics is working, but the dGPU still cannot execute.
I use Intel Arc-370M dGPU
Kernel Restarting appears.

maybe you can try to install a lower version of openvino-nightly, .e.g. ```pip install openvino-nightly==2023.3.0.dev20231219

Thank u pip install openvino-nightly==2023.3.0.dev20231219 This is the key!
The internal graphics is working, but the dGPU still cannot execute.
I use Intel Arc-370M dGPU Kernel Restarting appears.

What is your model's size? a FP16/FP32 model exceed the maximum dedicated memory on ARC-370m, I believed its 4gGB ?

也許你可以嘗試安裝較低版本的 openvino-nightly，例如 ```pip install openvino-nightly==2023.3.0.dev20231219

謝謝 pip install openvino-nightly==2023.3.0.dev20231219 這才是關鍵！
內部顯示卡正在工作，但 dGPU 仍然無法執行。
我使用 Intel Arc-370M dGPU 出現核心重新啟動。

您的模特兒尺寸是多少？FP16/FP32 型號可能超過 ARC-370m 上的最大專用內存，我相信它是 4gGB ？

I tested the small model tiny-llama-1b-chat and it works normally, thank you!

Hi, as the owner of most topics related to OV Python, here is the answer to the question: https://github.com/openvinotoolkit/openvino/issues/21979#issuecomment-1878154656
tl;dr you need to replace shared_memory with share_inputs. It works the same. I also encourage you to try out new share_outputs flag, especially with LLMs!
Cheers!

Hi, as the owner of most topics related to OV Python, here is the answer to the question: openvinotoolkit/openvino#21979 (comment)
tl;dr you need to replace shared_memory with share_inputs. It works the same. I also encourage you to try out new share_outputs flag, especially with LLMs!
Cheers!

Thank you! I will try 'share_outputs'.
May I ask, does the '254-llm-chatbot' example provide a C++ inference program like the object recognition example?

@hsulin0806 you may start by looking at https://github.com/openvinotoolkit/openvino.genai/tree/master/text_generation/causal_lm/cpp

@hsulin0806 you may start by looking at https://github.com/openvinotoolkit/openvino.genai/tree/master/text_generation/causal_lm/cpp

Thank you!


Define JSON Schema Representation

JSON Schema can be used to support javascript based editors such as Json-Editor.

An initial commit was made, but needs to be updated.


Challenges data

Is it possible to get a users challenges data? Happy to contribute if we can.

I think this data was under the queryprofile endpoint. However they have removed access to that endpoint.

That's a real shame. :( Thanks!


Hot reload and graphql() React component

I have noticed that a react component "with data" obtained by calling graphql(query)(component) doesn't work with HMR. Is this a known issue?
Failing Example
Any change to the SampleComponent (e.g. modifying text in the
 element)  isn't reflected in in HMR (I can se the module gets updated but browser doesn't render it).
class SampleComponent extends React.Component {
  render() {
    let email = 'n/a'
    if (this.props.data.launch_contact) {
      email = this.props.data.launch_contact.email
    }

    return(

Email is '{email}'.

    )
  }
}

const MyQuery = gql`
query MyQuery {
  launch_contact(id: 2) {
    email
  }
}
`

const SampleComponentWithData = graphql(MyQuery)(SampleComponent)

...

class TopLevelComponent extends React.Component {
  render() {
    return (
      <ApolloProvider client={client}>
        <SampleComponentWithData />
      </ApolloProvider>
    )
  }
}

Working Example
If I wrap SampleComponentWithData within another component the HMR work.
...

class WrapperComponent extends React.Component {
 render() {
   return(

       <SampleComponentWithData />

Any update here gets hot-reloaded correctly!

   )
 }
}

class TopLevelComponent extends React.Component {
 render() {
   return (
     <ApolloProvider client={client}>
       <WrapperComponent />
     </ApolloProvider>
   )
 }
}

HMR also works if I use SampleComponent directly (without Apollo query).

Could this be the same as https://github.com/apollostack/react-apollo/issues/174?
Either way, this should in in react-apollo because it probably has to do with that integration. Thanks for providing a detailed discussion, let's keep talking there.

Thanks @stubailo I'll move there.


Add uv init --from-project <path> to import from other tools

As previously discussed for uv add -r pyproject.toml but without any of the controversy about what to do with extras. We can copy all of the dependencies as reported by the build backend.

I'll look into this tonight unless someone beats me to it.

I have no idea why I closed this.

Related: https://github.com/astral-sh/uv/issues/6164

Is this up for grabs?

Yes!

You can use SourceTreeResolver to get the metadata. But one challenge is... we probably need to preserve extras rather than resolving them. For example, if the user's pyproject.toml has:
[project.optional-dependencies]
foo = "bar"

Then in the project we create, we'd also want to create a foo extra with bar in it.

I'll take a look soon.

we'd also want to create a foo extra with bar in it.

This makes sense, a similar PR would then resolve #6164 right?

Yeah, it's possible that we want to skip #6164 for now since it brings up some confusing questions, like what does --extra mean in uv add --extra baz -r pyproject.toml. So let's start with support here in uv init.

What is needed to get this merged/released? It will help converting a lot of users  from Poetry to UV, at least for companies which have large number of repo's.

Shameless plug (in case someone stumbles over this issue here and --from-project is still WIP): I wrote a script to migrate our Poetry monorepo project to uv. I doubt it will work immediately on other projects, but could be a good start.
https://gist.github.com/mrcljx/8e99a7f9fb924a573416f4365ee15873


Use credentials in environment variable as default parameters

Allows to create a new instance of Mailosaur by using environment variables directly.
To use credentials environment variables we are forced to do a Mailosaur.new(nil, nil) unless ruby throws wrong number of arguments (given 0, expected 2) (ArgumentError).

Would it be possible to default both to nil instead? That way it would not be a breaking change?

Yes I think it won't introduce breaks with default parameters to nil.
It's done

New Gem pushed, ready for testing emails: 1.0.1

:+1:


Support dimod<0.13

Looks like the pip install . -c doesn't like the release candidate dimod. I can not do the constrained install. Or I can just not test with that dimod for now (I did test locally and all works fine)

That's only an error in the 3.10.0 one. In the others it's the constrained pip install. E.g. https://app.circleci.com/pipelines/github/dwavesystems/dwave-hybrid/529/workflows/cd5a9511-a160-4803-8696-e4b2696ba6cb/jobs/5539

Codecov Report

Merging #266 (eb387ba) into master (e9aeb7f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   92.32%   92.32%
=======================================
  Files          17       17
  Lines        2072     2073    +1
=======================================
+ Hits         1913     1914    +1
  Misses        159      159

Impacted Files
Coverage Δ

hybrid/composers.py
97.18% <100.00%> (ø)

hybrid/decomposers.py
88.71% <100.00%> (+0.02%)
:arrow_up:

hybrid/utils.py
79.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9aeb7f...eb387ba. Read the comment docs.

Looks like waiting helped :laughing:
Not sure what changed, but all tests pass now. Perhaps newer pip handles rc properly?

Huh. Well good!


Extra gridstack item attributes

Added bindable gs item attributes:

minW
maxW
minH
maxH
id

Also updated readme with example

Could you please double the changes in au2 branch as well?

Is this still relevant?

Hello Maxim,
yes, the absence of the above properties does not allow us to fully use all the functions of the gridstack.
I just duplicated them in the au2 branch.
Are there any difficulties with the approval of this PR?
Best regards,
Alexandr

@alexandr-todorov I'm not quite sure overriding Id attribute is going to work. Have you tested it in both branches?

@alexandr-todorov I'm not quite sure overriding Id attribute is going to work. Have you tested it in both branches?

I just pushed some additional changes, take a look please.
id attribute was tested only in au2 branch.


tracker - automatically tag trades with default group when inserted

Decided to not do this. Reporting should account for ungrouped trades rather than relying on a tag to make it reportable.


How to create a window for bgfx / use window without sdl!

Hey all,
first of all thanks to the developer making this wonderful library! Im using it for a new engine
and it is gorgeous! Keep up the great work!
I have a little problem:
I have almost embedded bgfx into my engine and because i have my own startup system im not using entry::AppI - wich (i think so) is creating the window normally.
Not i want to know - is there a cross platform method to create a window in bgfx or do i have to write my own. I know how to creatw a window using win32 but how would i pass the hwnd to bgfx then?
Can somebody help me please?
Best Regards,
Mario

You can pass window/context info to bgfx with bgfx::setPlatformData
https://github.com/bkaradzic/bgfx/blob/master/include/bgfx/bgfx.h#L604
https://github.com/bkaradzic/bgfx/blob/master/include/bgfx/platform.h#L60
https://github.com/bkaradzic/bgfx/blob/master/examples/common/entry/entry_windows.cpp#L37

And i can create a win32 hwnd and just pass a pointer to it?

See https://github.com/bkaradzic/bgfx/tree/master/examples/common/entry directory and look into entry_* files for more info how to create window and pass native window handle to bgfx for any supported platform.


Error pada bagian login/auth

****### Error pada bagian header 404 page not found
404 Page Not Found
The page you requested was not found.

A PHP Error was encountered
Severity: 8192
Message: Return type of CI_Session_files_driver::open($save_path, $name) should either be compatible with SessionHandlerInterface::open(string $path, string $name): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Filename: drivers/Session_files_driver.php
Line Number: 132
Backtrace:
File: D:\xampp\htdocs\perpus-ci3-master\application\controllers\Login.php
Line: 6
Function: __construct
File: D:\xampp\htdocs\perpus-ci3-master\index.php
Line: 315
Function: require_once


🚀 Expose scrollControlledMaxHeightRatio to the modal bottom sheet

Adding the scrollControlledMaxHeightRatio parameter for modal bottom sheet widgets, and using the default value 9.0 / 16.0 to avoid breaking.
Resolves #129690.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

@Renzo-Olivares PTAL

@AlexV525 looks like some tests are failing, can you take a look?

@AlexV525 looks like some tests are failing, can you take a look?

Yeah I'll figure them out as soon as I'm available.

@Renzo-Olivares Should be good to go.

@Renzo-Olivares I've updated these names to scrollControlDisabledMaxHeightRatio series.


Revamp code related to "pretty" JSON serialization

Codecov Report

Merging #192 into master will decrease coverage by 0.04%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   99.54%   99.49%   -0.05%
==========================================
  Files          62       62
  Lines        6538     6520      -18
==========================================
- Hits         6508     6487      -21
- Misses         30       33       +3

Impacted Files
Coverage Δ

stix2/base.py
99.47% <100%> (-0.01%)
:arrow_down:

stix2/test/test_utils.py
100% <100%> (ø)
:arrow_up:

stix2/utils.py
98.2% <96.15%> (-1.8%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee059b0...f09960d. Read the comment docs.

I am ok with the approach. There shouldn't be any more comparison error being raised. Though, when a property is not found the object will simply be printed out of order.


lowerCamelCase as labels for terms

The 2017-10-06 version of Darwin Core changed the term labels from actual human readable labels to the term "local names" (sensu Best Practice Recipes for Publishing RDF Vocabularies) of the terms. I feel this is a bad idea for two reasons:

It makes labels for terms in the dwc: and dwciri: namespaces indistinguishable.
It conflates local names with labels, adding to the already severe confusion within TDWG between local names, labels, and controlled value strings.
It makes the English labels somehow different from labels in other languages, increasing confusion related to best practices for multilingual labels.

I think this change needs to be reversed. We already have the confusion caused by referring to compact URIs (CURIEs) as the "term name" (adding to the confusion between IRIs and labels), but at least if we think we need to use the term local names, then prepend them with a namespace abbreviation and make them valid CURIEs.

I think I agree that we should use Non Camel Case names in the column "label" (cf. this example). I'm not sure what to show on the Quick reference guide though, maybe both.

@baskaufs Your counting scheme is reminiscent of classic Old Irish literature ("for two reasons" giving three). I love it.
For 1), there would still be indistinguishable labels if you used ones that were not lowerCamelCase.
For 2), conflation was precisely the point. There are less ways to be variable. "The label" is the non-namespace, non-version part of the fully qualified name, and therefore resistant to changes. Fewer moving parts, and no preference for English. Multi-lingual labels beyond these were meant to be a separate issue, managed separately and non-normative, jut like the comments and examples. I feel strongly to not mess with this.
For 3), that is precisely what would happen if the label was changed to non-lowerCamelCase, they would be in English and therefore special, different from labels in any other language.

Ha ha! Too much counting in zero-based Python.
Responses to

In the metadata tables for the dwciri: terms, their labels include "(IRI)" following the English prose. See the draft list of terms document.
For better or worse, the term labels in English are required, term labels in other language are optional and to be maintained outside the standard. See Section 4.5. Honestly, this part of the spec was written based on existing practice in DwC and AC at the time the SDS was written. DwC has diverged from that practice since then.
The point here is that the required labels are English language labels and not something else (like term local names). A believe that the solution here is to provide labels in many languages, not to make the English label not be a label.

I realize that there is some unfairness in declaring that English labels are required and managed as part of the standard, while labels in other languages are not. I won't defend that practice but just say that it was the existing practice when the SDS was ratified and the requirement for expressing standards information in English was part of the pre-existing SDS that was unratified, but was being used as the de-facto precedent. If we want labels to follow some other, then this needs to be brought up as a TDWG-wide issue and the SDS be changed.

OK, can't argue with law. We MUST change the label then. That doesn't mean
we have to change the documents that use the current lowerCamelCase label,
does it?
On Thu, Jul 23, 2020 at 3:49 PM Steve Baskauf<EMAIL_ADDRESS>wrote:

Ha ha! Too much counting in zero-based Python.
Responses to

In the metadata tables for the dwciri: terms, their labels include
"(IRI)" following the English prose. See the draft list of terms
document
https://github.com/tdwg/rs.tdwg.org/blob/dwc/process/dwc.md#32-index-by-label
.
For better or worse, the term labels in English are required, term
labels in other language are optional and to be maintained outside the
standard. See Section 4.5
https://github.com/tdwg/vocab/blob/master/sds/documentation-specification.md#45-metadata-properties-for-describing-vocabulary-terms.
Honestly, this part of the spec was written based on existing practice in
DwC and AC at the time the SDS was written. DwC has diverged from that
practice since then.
The point here is that the required labels are English language
labels and not something else (like term local names). A believe that the
solution here is to provide labels in many languages, not to make the
English label not be a label.

I realize that there is some unfairness in declaring that English labels
are required and managed as part of the standard, while labels in other
languages are not. I won't defend that practice but just say that it was
the existing practice when the SDS was ratified and the requirement for
expressing standards information in English was part of the pre-existing
SDS that was unratified, but was being used as the de-facto precedent. If
we want labels to follow some other, then this needs to be brought up as a
TDWG-wide issue and the SDS be changed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tdwg/dwc/issues/253#issuecomment-663172769, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADQ722CSGZGAGLDTEBLOWLR5CA3LANCNFSM4OVYJ3CA
.

At the 2020-07-23 Maintenance Group meeting, we agreed that the labels should be in English prose, but for consistence with past practice, the Quick Reference Guide should continue to display the local names from the URIs.  Merging the pull request https://github.com/tdwg/rs.tdwg.org/pull/38 in the rs.tdwg.org repo and the pull request https://github.com/tdwg/dwc/pull/264 in the DwC repo will resolve this issue.


about depth data

Thanks for your great job! I download the dataset from the link https://zenodo.org/records/8154924.
There just is RGB  video, and I want to know how can I get the depth image that you used.
Would you consider making the depth data publicly available, I would appreciate it if you could provide it!

Hello, have you run it successfully? Where can I download the dataset?


Inline: rendering artifacts when resizing window

Describe the bug
A clear and concise description of what the bug is.
Setup
Please complete the following information along with version numbers, if applicable.

OS [e.g. Ubuntu, Mac OS]: PopOS (Ubuntu)
Shell [e.g. zsh, fish]: zsh
Terminal Emulator [e.g. kitty, iterm]: no
Terminal Multiplexer [e.g. tmux]: no

To Reproduce
Steps to reproduce the behavior:

Run fancy-list example
Resize the terminal multiple times to a very minimal height

Source Code
Please include source code if needed to reproduce the behaviour.

Expected behavior
The program should not repaint the program on multiple lines.
Screenshots
Screencast_from_04-09-2023_034642_PM.webm
Additional context
Replicated in Gnome Terminal, JetBrains In-built, VsCode

Thanks for the report! This is a dup of #573—closing this one accordingly.

Reopening per the discussion in #573 so we can track inline rendering separately from the altscreen efforts.

@meowgorithm friendly ping.

I'm curious, what's the difference between bubbletea inline render and clearing, drawing the text manually? I can't reproduce any visual bugs when printing and updating libpgloss text to stdout directly.

Lip Gloss merely prints to the terminal and exits, whereas Bubble Tea manages the cursor and optimizes redraws to some degree. So when the terminal resizes, Bubble Tea needs to redraw and update it’s renderer’s state, whereas text printed with Lip Gloss remains solely in the jurisdiction of the terminal’s own renderer.


wip: Preview/oidc simplified

@ajkiessl  this PR is just for review. We'll have to modify the server configuration before deploying this code, so let me know how best to handle that and i'll work with you. in the meantime, if we can have this branch deployed to dev that would help out a bunch

@whereismyjetpack I deployed this to stage.  Let me know if it needs to be on dev.  If we can get this out sometime this week or next week that would be great.  Would probably be best to release during a maintenance window (like 6-7am) if there is going to be downtime between deploying server config and the application.

@whereismyjetpack I deployed this to stage.  Let me know if it needs to be on dev.  If we can get this out sometime this week or next week that would be great.  Would probably be best to release during a maintenance window (like 6-7am) if there is going to be downtime between deploying server config and the application.

Thanks! I'll update the Apache configuration tomorrow, if our testing is successful i'll work on scheduling a time for production.

Thanks! I'll update the Apache configuration tomorrow, if our testing is successful i'll work on scheduling a time for production.

@ajkiessl I fully expect some of these tests to fail since i had to make some changes to the webaccess code. I found that we weren't actually authenticating users, so i added that to the controllers before_action. i think related to the ticket you put in today, a lot of the logic we have in there can proabably be removed. we could probably refactor the webaccess strategy into a more generic 'http_header' one, kind of like what RMD uses. let me know what you think!

@ajkiessl I fully expect some of these tests to fail since i had to make some changes to the webaccess code. I found that we weren't actually authenticating users, so i added that to the controllers before_action. i think related to the ticket you put in today, a lot of the logic we have in there can proabably be removed. we could probably refactor the webaccess strategy into a more generic 'http_header' one, kind of like what RMD uses. let me know what you think!

@whereismyjetpack I agree.  I'm going to pull down your code and take a look at it myself.  I'm going to see what deleting a bunch of the old code does.  Then get back to you in the afternoon.

@whereismyjetpack I agree.  I'm going to pull down your code and take a look at it myself.  I'm going to see what deleting a bunch of the old code does.  Then get back to you in the afternoon.


TypeError: reset() takes 1 positional argument but 2 were given

Hi,
I'm getting the following error message running:
File "/home/lucas/Desktop/rl-generalization/sunblaze_envs/time_limit.py", line 10, in reset
return self.env.reset(reset_params)
TypeError: reset() takes 1 positional argument but 2 were given
This happens only on Roboschool envs.
Any idea of why? I'm using the correct gym version (0.10.8).
Thanks!

Would you mind pasting the exact command you're using?
Also, can you try using the docker container? I just ran PPO + SunblazeHalfCheetah using the docker container via the instructions on the README and it seems to work fine.

Hi,
The code is simply:
import gym
import roboschool
import sunblaze_envs
env = sunblaze_envs.make('SunblazeHopper-v0')
obs = env.reset()
for i in range(10000):
    action, _states = model.predict(obs)
    obs, rewards, dones, info = env.step(env.action_space.sample())
    env.render()

The full output is:
Traceback (most recent call last):
  File "experiments/a2c_hopper.py", line 49, in <module>
    obs = env.reset()
  File "/home/lucas/Desktop/rl-generalization/sunblaze_envs/time_limit.py", line 10, in reset
    return self.env.reset(reset_params)
TypeError: reset() takes 1 positional argument but 2 were given

It worked fine with the docker container. However, I really want to understand what is making this error on my virtualenv.
Thanks!

The envs and env wrappers classes in sunblaze_envs take an extra reset argument (to accommodate the trials and episodes setup for adaptive methods - eg see https://github.com/sunblaze-ucb/rl-generalization/blob/5e05aa108aeadd4cf21f45d56128e9da3bddc14c/sunblaze_envs/classic_control.py#L53 and https://github.com/sunblaze-ucb/rl-generalization/blob/5e05aa108aeadd4cf21f45d56128e9da3bddc14c/sunblaze_envs/time_limit.py#L5). The env object that's throwing a type error isn't accepting the extra reset_params args, so to debug check what class self.env is.

The problemas was with roboschool version. I had to install version 1.0 to make it work.
It would be cool if you supported the newer version of roboschool also.
Thanks!

@LucasAlegre @cpacker  Could you let me know the version of roboschool to handle this issue? (I tried 1.0.1 but have the same issue)

@LucasAlegre @cpacker Could you let me know the version of roboschool to handle this issue? (I tried 1.0.40 but have the same issue)

Sorry for the late reply, the version was the first one (1.0.1).


⚠ Bofrost.de has degraded performance

In 5a03b6e, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1075 ms

Resolved: Bofrost.de performance has improved in 37d0751.


Patch 16

https://github.com/MicrosoftDocs/office-docs-powershell/issues/3384

Docs Build status updates of commit 2f859a7:
:clock10: Full build: the average full build time is 14 min(s) 9 sec(s), this is based on the last 349 build(s) for this repository.

Docs Build status updates of commit 2f859a7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsTeamsChannelsPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsChannelsPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 872e469:
:clock10: Full build: the average full build time is 14 min(s) 9 sec(s), this is based on the last 353 build(s) for this repository.

Docs Build status updates of commit 872e469:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsTeamsChannelsPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsChannelsPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[docker] Add non-root port binding

By setting cap_net_bind_service for the app you are able to bind to privileged ports inside the container such as 80 and 443. This can be useful when using macvlan and port remapping is unavailable.

That's rather drastic measure, considering its impossible to disable it.

Thanks for your review, I will close this PR.


FFI listarray lead to UB.

Describe the bug
When sending an array array with child data over FFI (e.g. via pyarrow for instance) we encounter undefined behavior.
I have found SIGILL and SEGFAULTS
To Reproduce
The tests in this arrow-pyarrow-integration and arrow/src/ffi.rs
I ran the the tests in MIRI (great tool!), but I have to admit, I am stuck, and seem to go in circles.
running 1 test
test ffi::tests::test_list ... error: Undefined Behavior: pointer to alloc278966 was dereferenced after this allocation got freed
   --> arrow/src/ffi.rs:126:21
    |
126 |         let child = &*child_ptr;
    |                     ^^^^^^^^^^^ pointer to alloc278966 was dereferenced after this allocation got freed
    |
    = help: this indicates a bug in the program: it performed an invalid operation, and caused Undefined Behavior
    = help: see https://doc.rust-lang.org/nightly/reference/behavior-considered-undefined.html for further information

    = note: inside `ffi::release_schema` at arrow/src/ffi.rs:126:21
note: inside `<ffi::FFI_ArrowSchema as std::ops::Drop>::drop` at arrow/src/ffi.rs:198:39
   --> arrow/src/ffi.rs:198:39
    |
198 |             Some(release) => unsafe { release(self) },
    |                                       ^^^^^^^^^^^^^
    = note: inside `std::intrinsics::drop_in_place::<ffi::FFI_ArrowSchema> - shim(Some(ffi::FFI_ArrowSchema))` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mod.rs:187:1
    = note: inside `std::sync::Arc::<ffi::FFI_ArrowSchema>::drop_slow` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/sync.rs:1039:18
    = note: inside `<std::sync::Arc<ffi::FFI_ArrowSchema> as std::ops::Drop>::drop` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/sync.rs:1571:13
    = note: inside `std::intrinsics::drop_in_place::<std::sync::Arc<ffi::FFI_ArrowSchema>> - shim(Some(std::sync::Arc<ffi::FFI_ArrowSchema>))` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mod.rs:187:1
    = note: inside `std::intrinsics::drop_in_place::<ffi::ArrowArray> - shim(Some(ffi::ArrowArray))` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mod.rs:187:1
note: inside `array::ffi::<impl std::convert::TryFrom<ffi::ArrowArray> for array::data::ArrayData>::try_from` at arrow/src/array/ffi.rs:60:5
   --> arrow/src/array/ffi.rs:60:5
    |
60  |     }
    |     ^
note: inside `ffi::tests::test_generic_list::<i32>` at arrow/src/ffi.rs:876:20
   --> arrow/src/ffi.rs:876:20
    |
876 |         let data = ArrayData::try_from(array)?;
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside `ffi::tests::test_list` at arrow/src/ffi.rs:899:9
   --> arrow/src/ffi.rs:899:9
    |
899 |         test_generic_list::<i32>()
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside closure at arrow/src/ffi.rs:898:5
   --> arrow/src/ffi.rs:898:5
    |
898 | /     fn test_list() -> Result<()> {
899 | |         test_generic_list::<i32>()
900 | |     }
    | |_____^
    = note: inside `<[closure@arrow/src/ffi.rs:898:5: 900:6] as std::ops::FnOnce<()>>::call_once - shim` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `test::__rust_begin_short_backtrace::<fn()>` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/lib.rs:567:5
    = note: inside closure at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/lib.rs:558:30
    = note: inside `<[closure@test::run_test::{closure#2}] as std::ops::FnOnce<()>>::call_once - shim(vtable)` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send> as std::ops::FnOnce<()>>::call_once` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/boxed.rs:1546:9
    = note: inside `<std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>> as std::ops::FnOnce<()>>::call_once` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panic.rs:344:9
    = note: inside `std::panicking::r#try::do_call::<std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>>, ()>` at /home/ritchie46/.rugged>]─╼ ╾─a280026[<untagged>]─╼ │ ╾──────╼╾──────╼
    0x20 │ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 │ ................
    0x30 │ 01 00 00 00 00 00 00 00 ╾─a279749[<untagged>]─╼ │ ........╾──────╼
    0x40 │ 00 00 00 00 00 00 00 00 ╾─a278656[<untagged>]─╼ │ ........╾──────╼
    0x50 │ ╾─a279863[<untagged>]─╼                         │ ╾──────╼
}
alloc280196 (Rust heap, size: 16, align: 8) {
    00 00 00 00 00 00 00 00 ╾─a275857[<untagged>]─╼ │ ........╾──────╼
}
alloc280316 (Rust heap, size: 56, align: 8) {
    0x00 │ ╾─a279544[<untagged>]─╼ 02 00 00 00 00 00 00 00 │ ╾──────╼........
    0x10 │ 02 00 00 00 00 00 00 00 ╾─a280196[<untagged>]─╼ │ ........╾──────╼
    0x20 │ 02 00 00 00 00 00 00 00 ╾─a279702[<untagged>]─╼ │ ........╾──────╼
    0x30 │ 01 00 00 00 00 00 00 00                         │ ........
}
alloc280344 (Rust heap, size: 96, align: 8) {
    0x00 │ 01 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 │ ................
    0x10 │ 03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 │ ................
    0x20 │ 00 00 00 00 00 00 00 00 02 00 00 00 00 00 00 00 │ ................
    0x30 │ 01 00 00 00 00 00 00 00 ╾─a280196[<untagged>]─╼ │ ........╾──────╼
    0x40 │ ╾─a279702[<untagged>]─╼ 00 00 00 00 00 00 00 00 │ ╾──────╼........
    0x50 │ ╾─a278994[<untagged>]─╼ ╾─a280316[<untagged>]─╼ │ ╾──────╼╾──────╼
}
alloc278656 (fn: ffi::release_schema)
alloc278994 (fn: ffi::release_array)
stup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:379:40
    = note: inside `std::panicking::r#try::<(), std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>>>` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:343:19
    = note: inside `std::panic::catch_unwind::<std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>>, ()>` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panic.rs:431:14
    = note: inside `test::run_test_in_process` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/lib.rs:589:18
    = note: inside closure at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/lib.rs:486:39
    = note: inside `test::run_test::run_test_inner` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/lib.rs:522:13
    = note: inside `test::run_test` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/lib.rs:555:28
    = note: inside `test::run_tests::<[closure@test::run_tests_console::{closure#2}]>` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/lib.rs:301:13
    = note: inside `test::run_tests_console` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/console.rs:289:5
    = note: inside `test::test_main` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/lib.rs:122:15
    = note: inside `test::test_main_static` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/lib.rs:141:5
    = note: inside `main`
    = note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `std::sys_common::backtrace::__rust_begin_short_backtrace::<fn(), ()>` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys_common/backtrace.rs:125:18
    = note: inside closure at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/rt.rs:66:18
    = note: inside `std::ops::function::impls::<impl std::ops::FnOnce<()> for &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>::call_once` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:259:13
    = note: inside `std::panicking::r#try::do_call::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:379:40
    = note: inside `std::panicking::r#try::<i32, &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:343:19
    = note: inside `std::panic::catch_unwind::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panic.rs:431:14
    = note: inside `std::rt::lang_start_internal` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/rt.rs:51:25
    = note: inside `std::rt::lang_start::<()>` at /home/ritchie46/.rustup/toolchains/nightly-2021-03-04-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/rt.rs:65:5
    = note: this error originates in an attribute macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to previous error

I have spent my weekend on this problem 😭
I now understand what we are doing wrong, but the solution requires a major design change of the FFI.
This gist is that we currently treat children as independent from the parent and drop them when no longer in use, which is out of spec.
The C data interface requires (MUST) that the parent is responsible for all child deallocations. When we destruct a list array imported from C++, the following currently happens:

the list array drop is called
the child array drop is called
the child array FFI release is called
the list array FFI release is called, calling the child array FFI release (as per spec), causing a double free

We should remove step 3 from this sequence, and let step 4 do its job.
However, for this, we need to figure out a way to share a ref counted owned parent to all child arrays, so that when the last array is deallocated, we can release the parent and all associated child arrays on the same release. Together with this, we must consider all imported child ffi arrays as non-owned (e.g. refs), so that they do not call their own release on drop.

I have spent my weekend on this problem

Oof, I feel you. Working on this depressed me as well.

However, for this, we need to figure out a way to share a ref counted owned parent to all child arrays, so that when the last array is deallocated, we can release the parent and all associated child arrays on the same release. Together with this, we must consider all imported child ffi arrays as non-owned (e.g. refs), so that they do not call their own release on drop.

Just thinking aloud here. Does it make sense to have some kind of marker (boolean) to indicate that an array is a child, and then make Drop a no-op when that marker is set and thereby eliminating step 3 (I assume that one is called in drop)?

I solved this in arrow2 https://github.com/jorgecarleitao/arrow2/pull/67 by using a different struct for an ArrowArray and a ChildArrowArray, on which one has owned refs and the other has unowned refs (and an Arc of the parent for ref count).


Rj/add versioning AND tagging capabilities

adding versioning and tagging tools to PBT to help for external CI/CD users. This will help change versions in all correct places for a given project language (pbt_project.yml, dbt_project.yml, setup.py, pom.xml). This will enable users to produce artifacts with the same version as their project.
Usage: pbt versioning [OPTIONS]

Options:
  --path TEXT                 Path to the directory containing the
                              pbt_project.yml file  [required]
  --bump [major|minor|patch]  bumps one of the semantic version numbers for
                              the project and all pipelines based on the
                              current value. Only works if existing versions
                              follow SemVer (MAJOR.MINOR.PATCH)
  --set TEXT                  Explicitly set the exact version
  --force, --spike            bypass errors if the version set is lower than
                              the base branch
  --sync                      Ensure all files are set to the same version
                              that is defined in pbt_project.yml. (implies
                              --force)
  --help                      Show this message and exit.

Usage: pbt tag [OPTIONS]

Options:
  --path TEXT       Path to the directory containing the pbt_project.yml file
                    [required]
  --repo-path TEXT  Path to the repository root. If left blank it will use '--
                    path'
  --no-push         By default the tag will be pushed to the origin after it
                    is created. Use this flag to skip pushing the tag.
  --branch TEXT     normally the tag is prefixed with the branch name:
                    <branch_name>/<version>. This overrides <branch_name>.
                    Provide "" to omit the branch name.
  --custom TEXT     Explicitly set the exact tag using a string. Ignores other
                    options.
  --help            Show this message and exit.

hi @prongs @jainabhinav @pankajb23 can someone please review and approve?


OLED  SSD1306  and Blue Pill

Hi to everybody,   Pls., I m asking for advise
how and where to find the files  to setup a small OLED display with a Blue Pill generic STM32F103
I am totally confused with all the information and files and renames of files (oled etc) on your github
I only want to try the Oled interface or driver from Mecrisp (which is running fine on my STM32f board)
My OLED has  4 PINS  /    GND VDD    SCK  SDA
I have triyed some of your files without any success (the one with the graphic output, the I2c include etc)
Can you help me to find the links to 2 or 3 files that will install (including the includes links)
and init the display and  write  "hello world"  to the OLED ?   and also where is the pin config of these
drivers ?
Kind regards
Enrique
(btw many of your examples on the blog the links are broken)

Does http://embello.jeelabs.org/flib/ help?

I found this article :  http://embello.jeelabs.org/flib/i2c.html
and I tested this :
https://github.com/jeelabs/embello/blob/master/explore/1608-forth/flib/any/i2c-bb.fs
I get all lines  "--"  empty, this means STM32 will not recognize any OLED at I2C,  I added
at PB6 and PB7  2  10 kohm  pull-up to 3.3 V  as somebody suggested,  no success...

Sounds good to me. What are the commands you used to test? SDA/SCL swapped? Power and ground connected to the OLED? Is the OLED set for I2C, not SPI?

Dear Jan, first of all  thank you for your answers !
and also the wonderful projects presented in your site and forth language examples, I like everything very much !
It is a kind of spooky thing this I2c.... I finally got 1 or 2twice the   message  the Oled was detected at 3C
I am at  I2C as far as I understand, I could detect it 1 time atlast...
I have found your article 1708a  where it shows the same OLED 4 wires I am using, and it says
"i2c-init i2c".
my error was to make only  i2c.  without  the   i2c-init

But after that  I could not  move forward , I did never got your Logo on the OLED (following
the example on your site) , it did happend nothing....
only  2 times I  detected   the periferal at $3C  (without any pullup)
Now , I can´t again ....   it  appears   all    "--"  .
I did also pullups of  1k  , and 10 k,  nothing changes....
I changed also the PB6 & 7   for  4 & 5   no success....
I triyed also to flash this code, so I do not need to reload it again,
But I ve got   an error after restart   (interrupt 00003) ...
I will contact you as soon I see where the error can be, now I have this good example to follow
and the  big-bang i2c file I was not shure where to look for.
Thanks again.

I added  i2c-half   and now EVERYTHING WORKS !
it was a timing problem.
thanks again  will keep studying Mecrisp

Good to hear you're making progress. The timing can be tricky. Try adding the following definition before including the i2c-bb.fs code:
9 constant I2C.DELAY

It inserts delay loops to slow down I2C comms (I use 9, sometimes 50 for really slow chips).

In case you're interested - I've been working on a new documentation site, see https://docs.jeelabs.org - my first goal is merely to start organising the information out there (which, as you pointed out, is strewn all over the place), leaving out whatever is no longer applicable. It's not going to be done overnight, but if you have tips on things I should add / mention / fix, please let me know.

Thank you Jan I appreciate very much. Btw.  Nice design !
There is really a sea of information  !  You have done a terrific job !  I like to follow information
in the form of a book with chapters, and not  in a form of  individual pages.  I recovered my
taste for Forth (in love with Forth since 35 years btw)  thanks  Hakcaday-Mecrisp and YOUR site.
Thumbs Up for you and everybody involved in this project !


Observables are lost/broken on page refresh

if original page of notebook is left open with some running cells, and I open another browser tab with same notebook, all works fine - I see updates on both tabs
BUT if original page is refreshed, the observables get messed up!

no link to spark UI
no cell /  job progress at all

maybe related to #523
@andypetrella @meh-ninja

Ouch nice catch! Need to work on that (I'll try this week though)

Ouch nice catch! Need to work on that (I'll try this week though)

already fixed :tada:


fix: prefix public path in importScripts

Fix https://github.com/webpack/webpack/issues/12577
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
wip
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
None

Thanks

Thanks for resolving! <3


Update Composer dependencies (2022-03-30-00-07)

Visual regression test passed!
View the visual regression test report


Mobile support

Ref #124

@vslinko take a look at the comments, pls :)

@Fyzu Thank you for your contribution! You have done a good job.
I see some problems with PR:
Some tests were broken. I checked the main branch and the tests work there. It needs to fix the code before release. I think it might be because of setTimeout.
I installed the plugin on iOS and it doesn't work. It shows an error when launching the plugin. Have you tested it on iOS?

I installed the plugin on iOS and it doesn't work. It shows an error when launching the plugin. Have you tested it on iOS?

Yeah. It works great on my iPhone. But I'll take another check


German admin command(s) not working.

Version
3.2.7
Im using the latest german lang file. When i do "/questadmin neuladen" it tells me the command does not exist. even it is listed in "/questadmin". When i use the original english command "/questadmin reload" it works. But its very confusing if i have to guess what command i have to use english or german. My suggestion is to leave the admin commands in english and only implement the translated destricption.

EDIT: i missed the new config option "translate sub-commands"
and i was confused because /questadmin showed me the german sub-commands.


Convenient configuration

Thanks for your hard work on this handy tool.
Description
I want to make app with SSG/HTML-JS and SPA pages, so I don't need SSR output. But I can't configure exactly which steps I need.
My suggestion is to replace disableAutoFullBuild and prerenderer.partial with property like mode, which type is enum flag.
By default it will produce default SPA.
SSG of certain pages:
ssr({
   mode: RenderMode.SPA | RenderMode.SSG
}),

Prerender (SSG) all pages. Omit server directory (place it to fs.mkdtemp or os.tmpdir or even node_modules/.vite/ while prerendering)
ssr({
   mode: RenderMode.SSG
}),

Preserve SPA pages, prerender SSG pages, produce SSR build for SSR pages and corresponding server runtime.
ssr({
   mode: RenderMode.SPA | RenderMode.SSG | RenderMode.SSR
}),

Manual build script
ssr({
   mode: RenderMode.Manual
}),

For consistency, introduce setting for every mode, something like:
ssr({
   // mode: ...
   spa: {
      processFilter?: ({ pageContext, filename, ... }) => pageContext.exports['SPA'] === true,
      html?: 'vite' (vite HTML middleware) | String (path to html file)
   },
   ssg: {
      noExtraDir: Boolean,
      defaultServerPath?: String, // needed for generating non-hydratable HTML, default: `renderer/_default.page.server.tsx`,
      processFilter?: ({ pageContext, filename, ... }) => pageContext.exports['SSG'] === true
   },
   ssr: {
      serverOutputDir?: String, // default is `${outDir}/server`
      defaultServerPath?: String, // needed for hdyratable HTML, default: `renderer/_default.page.server.tsx`
      defaultClientPath?: String, // page with hydration script, default: `renderer/_default.page.client.tsx`
      processFilter: ({ pageContext, filename, ... }) => pageContext.exports['SSR'] === true
   }
})

I believe this flexible approach will make it clear how to use this plugin without looking for examples and why it's better than alternative solutions.

I think this overlaps with https://github.com/brillout/vite-plugin-ssr/issues/53#issuecomment-1327915337

I think this overlaps with #53 (comment)

I see now, Yes. This could be better then defining all in configuration

I agree the DX of configuring render modes can be improved. It's on the radar.


Issue in string_ask with argument is_identifier

In string_ask method passing, is_identifier is True same as passing it False
In both cases, it validates that it is an identifier
To prevent this don't send is_identifier

Should be resolved now

Should be resolved now

for now just remove the kwarg of is_identitifier

for now just remove the kwarg of is_identitifier

fixed on branch development_vdc_chatflow_questions_issue

Verified on development_vdc latest


Remove duplicate "osutils" used by several workflows

Description:
Several workflows python_pip, node_npm share the same osutils class. Fix this by moving common functionality into a library that can be shared across workflows.

Steps to reproduce the issue:
1.
2.
3.
Observed result:
Expected result:
Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

Hi @sanathkr would this be moved to the existing https://github.com/awslabs/aws-lambda-builders/blob/develop/aws_lambda_builders/utils.py class?

There is a lot of overlap in all the utils.py, shall I merge all of them up into a OSUtils class in aws_lambda_builders/utils.py as you suggested ?


tests: perf various combinations of test_perf_fp_dwarf_smart collapsed differ on aarch64

Failing tests:
FAILED tests/test_perf.py::test_perf_fp_dwarf_smart[True-fp-native_fp] - AssertionError: assert (True ^ True)
FAILED tests/test_perf.py::test_perf_fp_dwarf_smart[True-dwarf-native_fp] - AssertionError: function ';recursive;recursive;recursive;recursive;' missing in collapsed data!
FAILED tests/test_perf.py::test_perf_fp_dwarf_smart[True-dwarf-native_dwarf] - AssertionError: assert (False ^ False)
FAILED tests/test_perf.py::test_perf_fp_dwarf_smart[True-smart-native_dwarf] - AssertionError: assert (False ^ False)

Exemplary output:
system_profiler = <gprofiler.profilers.perf.SystemProfiler object at 0xffffa4cb4ee0>, application_pid = 1478804, runtime = 'native_dwarf', perf_mode = 'smart', application_docker_container = <Container: 51caf27de4>

    @pytest.mark.parametrize("runtime", ["native_fp", "native_dwarf"])
    @pytest.mark.parametrize("perf_mode", ["fp", "dwarf", "smart"])
    @pytest.mark.parametrize("in_container", [True])  # native app is built only for container
    def test_perf_fp_dwarf_smart(
        system_profiler: SystemProfiler,
        application_pid: int,
        runtime: str,
        perf_mode: str,
        application_docker_container: Container,
    ) -> None:
        with system_profiler as profiler:
            process_profile = snapshot_pid_profile(profiler, application_pid)
            process_collapsed = process_profile.stacks
            with open("perf.txt","a") as f:
                f.write(str(process_collapsed))
                f.write("")
            if runtime == "native_dwarf":
                # app is built with DWARF info and without FP, so we expect to see a callstack only in DWARF or smart modes.
>               assert is_function_in_collapsed(";recursive;recursive;recursive;recursive;", process_collapsed) ^ bool(
                    perf_mode not in ("dwarf", "smart")
                )
E               AssertionError: assert (False ^ False)
E                +  where False = is_function_in_collapsed(';recursive;recursive;recursive;recursive;', Counter({'native;_start;recursive': 90}))
E                +  and   False = bool('smart' not in ('dwarf', 'smart'))

tests/test_perf.py:66: AssertionError

I think these failures are all due to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/kernel/perf_callchain.c?id=33c222aeda14596ca5b9a1a3002858c6c3565ddd. This causes unwinding to show only one level in certain cases, so this test (which checks for multiple levels recursive;recursive;recursive;... fails.


Refactor and add Steps in Newbies and Maintainers

Resolves #109

Refactored the Steps component to be common common\Steps.tsx
Implemented the common component in the Newbies and Maintainers pages.

Newbies:

Maintainers:

@RoyTennenbaum ready for your review without conflicts toda la'el


Add concatenation logic to sdxl-compel node

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[ ] Yes
[x] No, because:

@StAlKeR7779 @psychedelicious is this needed? Not sure how we're doing concat in the UI


About the Q-shift operation in the code

in the jit_func in Class VRWKV_SpatialMix_V6 why we need to -x after the shift_func? It seems not -x in the _inner_forward in Class VRWKV_ChannelMix when calculate xx.
#Class VRWKV_SpatialMix_V6
def jit_func(self, x, patch_resolution):
# Mix x with the previous timestep to produce xk, xv, xr
B, T, C = x.size()
    xx = self.shift_func(x, self.shift_pixel, patch_resolution=patch_resolution,
                         with_cls_token=self.with_cls_token) - x
    xxx = x + xx * self.time_maa_x  # [B, T, C]

#Class VRWKV_ChannelMix
def _inner_forward(x):
xx = self.shift_func(x, self.shift_pixel, patch_resolution=patch_resolution,
with_cls_token=self.with_cls_token)

Hi! The subtraction in the interpolation in vrwkv6 gives a formula equivalent to that in VRWKV.
VRWKV6:
xx = shift(x) - x
xxx = x + \mu * xx
= x + \mu * (shift(x) - x)
= (1 - \mu) * x + \mu * shift(x)
VRWKV:
xx = shift(x)
xxx = \mu * x + (1 - \mu) * xx
= \mu * x + (1 - \mu) * shift(x)


fix: optionally specify module class suffix for generated kotlin clients

ftl #361

Nice @worstell! this looks great!
Are you able to test locally to see if changing the suffix here generates the new types correctly as well https://github.com/TBD54566975/ftl/blob/main/examples/echo-kotlin/pom.xml#L106-L109

Nice @worstell! this looks great!
Are you able to test locally to see if changing the suffix here generates the new types correctly as well https://github.com/TBD54566975/ftl/blob/main/examples/echo-kotlin/pom.xml#L106-L109

validated locally!


Validate List[str] using regex

Hello :)
How do I validate a list of strings that are sent via POST parameters?
I have this example ...
@app.post("/entity/list")
def query_entity_list(entities: List[str] = Query(None, regex="^[a-z]{5}$")):
   return entities

... and the API function is called by ...
curl -X POST "http://localhost/entity/list/?entities=valid&entities=inv4lid

Is it possible to apply the regex on each item in the entities list?
Currently, the string validation does not working for me.
Thanks in advance!

You would want to have a specific string type with that contraint. Pydantic has a ConstrainedStr/constr type spcifically for that purpose:
from pydantic import constr

EntryCode = constr(regex="^[a-z]{5}$")

@app.post("/entity/list")
def query_entity_list(entities: List[EntryCode] = Query(None)):
   return entities

Thank you very much @sm-Fifteen! It works now :)

Thanks for the help here @sm-Fifteen ! :cake:
Thanks @marius-benthin for reporting back and closing the issue :+1:

Is there a way to preserve the regex annotation?
when i add constr the docs show just str
    use_filters: Optional[List[constr(regex=models.SEGMENT_PARAM_REGEX)]] = Query(
        None,
        alias="useFilters",
        title="Use Filters",
        # regex=models.SEGMENT_PARAM_REGEX,
        description="Filter results using Field:Operator:Value",
    ),

but with the regex on Query it shows up in the docs
    use_filters: Optional[List[str]] = Query(
        None,
        alias="useFilters",
        title="Use Filters",
        regex=models.SEGMENT_PARAM_REGEX,
        description="Filter results using Field:Operator:Value",
    ),


did i do something wrong?

ObjectDisposedException: Attempted to access Unity.Entities.EntityTypeHandle which has been invalidated by a structural change.
Unity.Entities.WorldUnmanagedImpl+UnmanagedUpdate_00001541$BurstDirectCall.Invoke (System.Void* pSystemState) (at <54c68c86110c4e6e8ed0c9593c5cc484>:0)
Unity.Entities.WorldUnmanagedImpl.UnmanagedUpdate (System.Void* pSystemState) (at ./Library/PackageCache/com.unity.entities@1.0.0-pre.65/Unity.Entities/WorldUnmanaged.cs:810)
Unity.Entities.WorldUnmanagedImpl.UpdateSystem (Unity.Entities.SystemHandle sh) (at ./Library/PackageCache/com.unity.entities@1.0.0-pre.65/Unity.Entities/WorldUnmanaged.cs:895)
Unity.Entities.SystemHandle.Update (Unity.Entities.WorldUnmanaged world) (at ./Library/PackageCache/com.unity.entities@1.0.0-pre.65/Unity.Entities/WorldUnmanaged.cs:169)
Latios.SuperSystem.UpdateUnmanagedSystem (Latios.LatiosWorldUnmanagedImpl* impl, Unity.Entities.SystemHandle system) (at ./Packages/com.latios.latios-framework/Core/Framework/SuperSystem.cs:260)
Latios.SuperSystem.UpdateAllSystems (Unity.Entities.ComponentSystemGroup group, Unity.Entities.Exposed.SystemSortingTracker& tracker) (at ./Packages/com.latios.latios-framework/Core/Framework/SuperSystem.cs:325)
UnityEngine.Debug:LogException(Exception)
Latios.SuperSystem:UpdateAllSystems(ComponentSystemGroup, SystemSortingTracker&) (at ./Packages/com.latios.latios-framework/Core/Framework/SuperSystem.cs:335)
Latios.SuperSystem:DoSuperSystemUpdate(ComponentSystemGroup, SystemSortingTracker&) (at ./Packages/com.latios.latios-framework/Core/Framework/SuperSystem.cs:358)
Latios.Systems.LatiosWorldSyncGroup:OnUpdate() (at ./Packages/com.latios.latios-framework/Core/Systems/_Essentials/LatiosInitializationSystemGroup.cs:60)
Unity.Entities.SystemBase:Update() (at ./Library/PackageCache/com.unity.entities@1.0.0-pre.65/Unity.Entities/SystemBase.cs:418)
Latios.SuperSystem:UpdateManagedSystem(LatiosWorldUnmanagedImpl*, ComponentSystemBase) (at ./Packages/com.latios.latios-framework/Core/Framework/SuperSystem.cs:292)
Latios.SuperSystem:UpdateAllSystems(ComponentSystemGroup, SystemSortingTracker&) (at ./Packages/com.latios.latios-framework/Core/Framework/SuperSystem.cs:330)
Latios.SuperSystem:DoSuperSystemUpdate(ComponentSystemGroup, SystemSortingTracker&) (at ./Packages/com.latios.latios-framework/Core/Framework/SuperSystem.cs:358)
Latios.Systems.LatiosInitializationSystemGroup:OnUpdate() (at ./Packages/com.latios.latios-framework/Core/Systems/_Essentials/LatiosInitializationSystemGroup.cs:43)
Unity.Entities.SystemBase:Update() (at ./Library/PackageCache/com.unity.entities@1.0.0-pre.65/Unity.Entities/SystemBase.cs:418)
Unity.Entities.DummyDelegateWrapper:TriggerUpdate() (at ./Library/PackageCache/com.unity.entities@1.0.0-pre.65/Unity.Entities/ScriptBehaviourUpdateOrder.cs:526)
I clicked on a mission in the title menu but it doesn't work properly

Nope. That's a regression. Will fix shortly!
Side note, I usually only test entering play mode in a mission directly before pushing. I only test scene switching and builds when I get really close to a new framework release.

Should be fixed now!


Preparing release 2.3.0

Coverage remained the same at 83.297% when pulling e496623e3410ad833720d84c1711cb3d2a7d9244 on release-2.3.0 into bf2a774a44cb0a2e667658d508c113ede1c197ca on master.

Coverage remained the same at 83.297% when pulling e496623e3410ad833720d84c1711cb3d2a7d9244 on release-2.3.0 into bf2a774a44cb0a2e667658d508c113ede1c197ca on master.


Add character set support on responses

I ran into an issue where my tests were failing on Windows but not on Linux. After some investigation, I determined that the culprit was the HttpResponse.withBody(String) method. The method stated that it would encode strings as UTF-8, but in fact was encoding strings using the platform default charset, which is often UTF-8 in Linux but varies considerably on Windows. In my case, it was defaulting to windows-1252, which encodes some common characters such as the euro sign differently than UTF-8.
I implemented a few changes to standardize and improve the encoding of Strings. Instead of always using the platform default character set to encode Strings (the behavior of String.getBytes() without a charset parameter), this PR now allows you to specify a character set by either:

Adding a Content-Type header with a charset. This is the preferred option, as it is what the HTTP standard requires for non-default charsets.
Explicitly specifying the charset in the withBody() call or the StringBody() constructor. Using this option will force the charset, even if the Content-Type is absent or contradicts the specified charset.

If no character set is specified using one of the above options, the String will be encoded using ISO-8859-1, which is what the HTTP spec specifies in section 3.7.1:

The "charset" parameter is used with some media types to define the character set (section 3.4)  of the data. When no explicit charset parameter is provided by the sender, media subtypes of the "text" type are defined to have a default charset value of "ISO-8859-1" when received via HTTP. Data in character sets other than "ISO-8859-1" or its subsets MUST be labeled with an appropriate charset value.

This change also avoids unnecessarily Base64 encoding, then immediately unencoding, BinaryBody body types before adding them to a response body.

@jamesdbloom - would you mind re-starting the travis-ci build for this PR? Looks like the travis environment was a bit unstable today.

I've restarted it.

To be honest the unreliability of drone.io and travis can be quite annoying, although their free so I can't really complain.

When I get a chance I'll take a look, merge it locally and run the build locally as I can see it doesn't look like your code is breaking the build.

Thanks, @jamesdbloom. It looks like one of the rebuilds did actually fix the travis failure. I'm not sure what was causing the failure earlier (I wasn't able to reproduce the failure locally).

FYI -- I just rebased on top of the latest updates, and made a few javadoc corrections.

:+1:

@jamesdbloom -- just thought I'd ping you on this. Anything you'd like me to do to get this PR merge-ready? I'd be happy to add unit tests, refactor, etc.

I am half way through merging this pull-request.  The main issue is that there was a number of missing code / tests, in particular that covered serialising and de-serialising the StringBody to JSON and back.  Once I added an integration test this highlighted that if you set an expectation using the Java API then the Charset was not sent to the server.  This is nearly fixed so it should be all fully merged in the next day or so.

I have now pushed a these changes however some more integration tests are missing, I will add these in the next couple of days.  Once I've also fixed an issue affecting the Ruby client I will do a release.


Implement the constructor in the not generated model

I want to ad an object to the model object and I'm now doing this by taking out the constructor in the generated class and implementing it in my own partial (see code).
This works but of course as soon as I generate, the constructor appears in the generated file.
Is there a way to let the generator know the constructor is in the other file?
Regards
Teus
namespace Umbraco.Extensions.Models.Generated
{
    public partial class Production
    {
        public readonly Project FoundProject;

        public Productie(IPublishedContent content)
            : base(content)
        {
            FoundProject = iTheatreData.DAL.GetProjectByName(this.name);
        }
etc

Got it, see what you want. We should detect that you are already implementing a constructor with the proper signature in your own partial class, and we should not generate a new constructor. Working on it.

Implemented.

Thanks !


Update Key Management guide for latest upstream LDK API

Including describing spend_spendable_outputs, closing #35.

Fixed the two typos pointed out.


Extract MiqExpression#expression_prep from preprocess_for_sql

extracted from https://github.com/ManageIQ/manageiq/pull/22347
depends upon #22355
Expression_prep modifies the values and removes the :token
It will possibly do other things in the future like look up the Field
so we can reduce all of those calls
preprocess_for_sql is just focused on pruning/rearranging nodes so the
expression tree will be optimized for sql
From here, writing tests around preprocess_for_sql are easier because there are fewer side effects in the expression.
Other possible improvements:

look up the Field so we can reduce all of those calls (and drop field cache)
collapse nested AND, OR, NOT nodes.
downcase all operators

update:

fixed cop
added dependent commit to get tests to pass

update:

rebased after count merge
changed method name to expression_prep!

update:

fixed refactor issue with renaming preprocess_exp!

Backported to petrosian in commit 9fbd3e972e5c82d1c37114f0e134374e1bba184a.
commit 9fbd3e972e5c82d1c37114f0e134374e1bba184a
Author: Jason Frey<EMAIL_ADDRESS>Date:   Tue Feb 21 10:54:53 2023 -0500

    Merge pull request #22356 from kbrock/miq_expression_prep

    Extract MiqExpression#expression_prep from preprocess_for_sql

    (cherry picked from commit 5e811cee11bca757dfedc049899d34ff6faa133d)