[1.9.9] Change in DragAndDrop causes NPE

Please ensure you have given all the following requested information in your report.
Issue details
Due to a change between 1.9.8 and 1.9.9 in the DragAndDrop class (actual change is here: https://github.com/libgdx/libgdx/blob/gdx-parent-1.9.9/gdx/src/com/badlogic/gdx/scenes/scene2d/utils/DragAndDrop.java#L75) the updated version causes the dragStop to be called while still in drag. Using a watch on the payload I was able to trace it through a cascade of dragActor.remove -> parent.removeActor -> stage.unfocus -> cancelTouchFocus -> ... some event classes in between ... -> listener.dragStop (the one inside DragAndDrop.addSource). This sequence of events causes payload to be reset and thus causes an NPE at line 105 (https://github.com/libgdx/libgdx/blob/gdx-parent-1.9.9/gdx/src/com/badlogic/gdx/scenes/scene2d/utils/DragAndDrop.java#L105)
Reproduction steps/code
Just implement the DragAndDrop and it should happen as soon as you start dragging.
Version of LibGDX and/or relevant dependencies
LibGDX: 1.9.9+
Stacktrace
Exception in thread "LWJGL Application" java.lang.NullPointerException
	at com.badlogic.gdx.scenes.scene2d.utils.DragAndDrop$1.drag(DragAndDrop.java:105)
	at com.badlogic.gdx.scenes.scene2d.utils.DragListener.touchDragged(DragListener.java:61)
	at com.badlogic.gdx.scenes.scene2d.InputListener.handle(InputListener.java:62)
	at com.badlogic.gdx.scenes.scene2d.Stage.touchDragged(Stage.java:314)
	at com.badlogic.gdx.backends.lwjgl.LwjglInput.processEvents(LwjglInput.java:345)
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:217)
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126)

Please select the affected platforms

[X] Android
[X] iOS (robovm)
[X] iOS (MOE)
[X] HTML/GWT
[X] Windows
[X] Linux
[X] MacOS

DragAndDropTest works fine, so how to reproduce?

Ok,I have replace the DragAndDrop.java and DragAndDrop.class with 1.9.7 version and it works fine.
otherwise the game will crush if you started to drag an item.

@Tom-Ski
I have replace the DragAndDrop.java and DragAndDrop.class with 1.9.7 version and it works fine.
otherwise the game will crush if you started to drag an item.
Can you guys replace the files?
http://central.maven.org/maven2/com/badlogicgames/gdx/gdx/1.9.7/

If there is a problem, I would love to fix it. Will reopen if more info is provided.

I'm getting this same issue, it seems that setting the dragActor to a child actor and trying to drag it is causing a NPE.

I'm getting this same issue, it seems that setting the dragActor to a child actor and trying to drag it is causing a NPE.

you have to change libgdx to 1.9.7. if they aren't going to fix it

@Extain You'll need to show what problem you are having before anyone can fix it.

@Extain You'll need to show what problem you are having before anyone can fix it.

I'm using 1.9.10 encounterd the same issue.
The reason the test works is because in the dragStart method you create a new actor, namely a Label, and set it as the dragActor. The use case here is if the dragActor is set via the getActor() method for example. In these cases the idea is to drag the actual actor that has been picked up, not a derivative. If you change the test on line 68 to use getActor() you should be able to reproduce.
Hope it helps.

I can verify this issue. I am working with the Book "Mastering LibGDX" by  Patrick Hoey. With Version 1.9.8 and before there isn't any issue with the DragAndDrop class, but when i switch to Version 1.9.10 i get the Nullpointer exception too.
Exception in thread "LWJGL Application" java.lang.NullPointerException
	at com.badlogic.gdx.scenes.scene2d.utils.DragAndDrop$1.drag(DragAndDrop.java:110)
	at com.badlogic.gdx.scenes.scene2d.utils.DragListener.touchDragged(DragListener.java:61)
	at com.badlogic.gdx.scenes.scene2d.InputListener.handle(InputListener.java:62)
	at com.badlogic.gdx.scenes.scene2d.Stage.touchDragged(Stage.java:315)
	at com.badlogic.gdx.InputMultiplexer.touchDragged(InputMultiplexer.java:135)
	at com.badlogic.gdx.backends.lwjgl.LwjglInput.processEvents(LwjglInput.java:363)
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:221)
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:128)

@kamarad Thanks for describing a way to reproduce the problem. The DragAndDrop class is not designed for the source actor to be the drag actor. Even if the NPE issue you have is fixed, if Payload setValidDragActor or setInvalidDragActor is used then drag actor is removed from the stage and those added. Also, the drag actor is removed from the stage when drag stops, which may or may not be what you want to happen to the source actor.
First, the NPE issue occurs because of how #5403 was fixed. We want to allow drop targets with touch disabled, but we need to do something so event.getStage().hit doesn't hit the drag actor. Removing from the stage accomplishes this, but if the drag actor is the source actor then it has touch focus (since we touch downed it) and removing it from the stage causes a "cancel touch focus", which simulates a touch up, stopping the drag. So removing it isn't good.
A workaround is for the drag actor to return null from hit, but needing to manage this yourself is clunky. Another is to offset the drag actor so it isn't under the touch, though fast movements may still trigger it.
We could move the drag actor really far away when we do the hit test. This feels pretty hacky but it may actually be the most elegant solution. Let's go with that and we can do something else if someone has a better idea.
Next, to use a source actor as the drag actor, we could have DragAndDrop only removes actors that were not already in the stage. If it has to add a drag actor, then it will remove it, but if the actor was already in the stage it will only position it, never remove it. This means existing code may need to be adjusted to remove the drag actor that used to be removed automatically, but I think it is better behavior and that should be pretty obvious that it needs to be done.

@kamarad Thanks for describing a way to reproduce the problem. The DragAndDrop class is not designed for the source actor to be the drag actor. Even if the NPE issue you have is fixed, if Payload setValidDragActor or setInvalidDragActor is used then drag actor is removed from the stage and those added. Also, the drag actor is removed from the stage when drag stops, which may or may not be what you want to happen to the source actor.
First, the NPE issue occurs because of how #5403 was fixed. We want to allow drop targets with touch disabled, but we need to do something so event.getStage().hit doesn't hit the drag actor. Removing from the stage accomplishes this, but if the drag actor is the source actor then it has touch focus (since we touch downed it) and removing it from the stage causes a "cancel touch focus", which simulates a touch up, stopping the drag. So removing it isn't good.
A workaround is for the drag actor to return null from hit, but needing to manage this yourself is clunky. Another is to offset the drag actor so it isn't under the touch, though fast movements may still trigger it.
We could move the drag actor really far away when we do the hit test. This feels pretty hacky but it may actually be the most elegant solution. Let's go with that and we can do something else if someone has a better idea.
Next, to use a source actor as the drag actor, we could have DragAndDrop only removes actors that were not already in the stage. If it has to add a drag actor, then it will remove it, but if the actor was already in the stage it will only position it, never remove it. This means existing code may need to be adjusted to remove the drag actor that used to be removed automatically, but I think it is better behavior and that should be pretty obvious that it needs to be done.

Sounds good to me Nathan. I understand the reasoning. I will adjust my code to adopt the architecture.


Object.assign (or spread) can be used to sneak undefined into required property

⚙ Compilation target
ES2022
⚙ Library
TypeScript 5.6.3
Missing / Incorrect Definition
I discovered that Object.assign (and also spread) allows for copying of undefined as a value:
interface Thing {
  template: string;
  color?: string;
}

type Arg = Partial<Thing>;

const base: Thing = { template: "foobar" }; // Thing
const arg: Arg = { color: "red", template: undefined }; // Partial<Thing>
const result = Object.assign({}, base, arg); // Thing & Partial<Thing>
result.template // string

console.assert(typeof result.template == "string"); // will trigger
console.log(`template is '${result.template}'`); // template is 'undefined'

Note: The above code block is available as a TypeScript Playground link below, where it can also be ran to reproduce the console.log message.
I have further done a little research such as running a similar test setup in Node 22 (current LTS as the time of writing) as well as finding an issue on Rhino that explicitly calls for it to recreate this behaviour (as it seems to be intended to work like this).
Welcome to Node.js v22.11.0.
Type ".help" for more information.
> const base = { template: "foobar" }
undefined
> const args = { color: "red", template: undefined }
undefined
> const res = { ...base, ...args }
undefined
> res
{ template: undefined, color: 'red' }
>

The resulting type should actually contain undefined as an explicit possibility for the template property such as { template: string | undefined, color?: string }.
Links

TypeScript Playground: https://tsplay.dev/w1DY8W
Rhino issue: https://github.com/mozilla/rhino/issues/780

setting exactOptionalPropertyTypes in the tsconfig.json seems to help:
Type '{ color: string; template: undefined; }' is not assignable to type 'Partial<Thing>' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
  Types of property 'template' are incompatible.
    Type 'undefined' is not assignable to type 'string'.

Note: not a TS team member.
Duplicate of #11100, tracked at #10727.
Object.assign() produces an intersection which is known to have problems in the case of overwriting properties. TS needs a good "spread" operator, which it doesn't have. You could sort of write your own, but it would be a complicated mess of conditional types.
And even if that existed it would still fail to catch problems in general without exact types as per #12936, since nothing prevents you from sneaking random extra stuff in there:
const x = { template: 123 }
const y: {} = x; // okay
const base: Thing = { template: "foobar" }; // Thing
const result = Object.assign({}, base, y); // Thing?!
result.template.toUpperCase(); // runtime explosion because it's really a number

Playground
So Object.assign()'s typing has deficiencies, but it's simple and works reasonably well in a lot of use cases. Making it more complex and possibly adding new language features to improve it... well I think that might not be considered worth the effort?

setting exactOptionalPropertyTypes in the tsconfig.json seems to help:

yep, that seems to help, sadly in my case the property will be set by the user of the library I'm trying to build (hence the name arg in the example, so I cannot make sure the user has this setting on, requiring additional type gymnastics on my end.

"acts virtually identical to any"? No, it... how about I sidestep and rewrite it as:
interface Thing {
  template: string;
  color?: string;
}

const x = { color: "abc", template: 123 }
const y: { color: string } = x;
const base: Thing = { template: "foobar" }; // Thing
const result = Object.assign({}, base, y); // Thing & {color: string}
result.template.toUpperCase(); // runtime explosion because it's really a number

Playground
Does that demonstrate the issue to you?

"acts virtually identical to any"? No, it... how about I sidestep and rewrite it as:

This does not disprove {} essentially acting like any. See this for more information: https://typescript-eslint.io/rules/no-empty-object-type

Does that demonstrate the issue to you?

This exits the realm of explicilty setting undefined on an optional property and goes more towards ways to lie to TypeScript's type analysis, which is outside the scope of this issue. If a user intentionally lies to TS like this, they are expected to know what they are doing, this goes for assingments, return types and as all the same.

Widening is not "lying" to TypeScript's type analysis. The following is not lying, it's just widening:
interface Foo { x: string }
interface Baz extends Foo { y: string  }
function f(foo: Foo): Baz {  return Object.assign({}, { y: "abc" }, foo); }
interface Bar extends Foo {  y: number }
const bar: Bar = { x: "abc", y: 123 };
const baz = f(bar);
baz.y.toUpperCase() // error

Playground
If you want to fix that problem, you need exact types.  If you think it's off-topic, let's forget about it entirely. Sorry.

Optional properties accept undefined on purpose, and the problem here is the intersection. The --exactOptionalPropertyTypes option doesn't stop the "sneaking in" issue with Object.assign(). I'm hoping you'll agree this example is the same problem, and one that could not be addressed with --exactOptionalPropertyTypes:
type Arg = { [K in keyof Thing]: Thing[K] | undefined };
/* type Arg = {
    template: string | undefined;
    color?: string | undefined;
} */

const base: Thing = { template: "foobar" }; // Thing
const arg: Arg = { color: "red", template: undefined }; // Arg
const result = Object.assign({}, base, arg); // Thing & Arg
result.template // string

Playground
Indeed we can change undefined to any other data type and have the same problem:
type Arg = { [K in keyof Thing]: Thing[K] | number };
/* type Arg = {
    template: string | number;
    color?: string | number;
} */

const base: Thing = { template: "foobar" }; // Thing
const arg: Arg = { color: "red", template: 123 }; // Arg
const result = Object.assign({}, base, arg); // Thing & Arg
result.template // string

The problem here is the lack of a spread operator. Here's a possible spread implementation:
type MergeTwo<T extends object, U extends object> = { [
  K in keyof T | keyof U]:
  (x: K extends (keyof T & keyof U) ?
    {} extends Pick<U, K> ? { [P in keyof T as P & K]: T[P] | U[K] } : Pick<U, K> :
    K extends keyof T ? Pick<T, K> : K extends keyof U ? Pick<U, K> : never) => void
} extends Record<keyof T | keyof U, (x: infer I) => void> ? { [K in keyof I]: I[K] } : never

type Merge<T extends object[], A extends object = object> =
  T extends [infer F extends object, ...infer R extends object[]]
  ? Merge<R, object extends A ? F : MergeTwo<A, F>> : A;

interface ObjectConstructor {
  assign<T extends [object, ...object[]]>(...args: T): Merge<T>
}

which gives you string | undefined now in your example:
type Arg = Partial<Thing>;
const base: Thing = { template: "foobar" }; // Thing
const arg: Arg = { color: "red", template: undefined }; // Partial<Thing>
const result = Object.assign({}, base, arg);
/* const result: {
    template: string | undefined;
    color?: string | undefined;
} */
result.template // string | undefined

const y = Object.assign({}, base, { template: Math.random() < 0.99 ? 123 : "abc" })
/* const y: {
    template: string | number;
    color?: string | undefined;
} */

Playground
But that Merge type is awful and not something anyone wants to see in the standard TS library (I hope) so it would be nice if TS could provide a native operator, which is why this is a duplicate of #10727.

can you cease writing essays about unrelated stuff in my issue please?

It’s not unrelated. As for writing essays, that’s a fair point. I’ll disengage now entirely. Good luck.

Your write-up is still appreciated for future reference.

Not very nice.

Not very nice.

@MartinJohns Please immediatly remove the above screenshot. My personal social media are not yours to share and this ticket is closed and I have already requested deletion.


Reading the code with multiple readers feels a bit yucky.

The code reads well when you do a single map:

const map = new Mapper();

map("a").to("b");

const result = map.execute({a: "value"});

But not so good if you are using multiple mappers:
const postMapper = new Mapper();
const authorMapper = new Mapper();

// does read very nice without 'map'
postMapper("text").to("user.text");
authorMapper("name").to("user.name");

const posts = postMapper.execute({"text": "value"});
const result = authorMapper.execute({"name": "Tim the Enchanter"}, posts);

It would read better if we also supported:
const postMapper = new Mapper();
const authorMapper = new Mapper();

// does read very nice without 'map'
postMapper.map("text").to("user.text");
authorMapper.map("name").to("user.name");

const posts = postMapper.execute({"text": "value"});
const result = authorMapper.execute({"name": "Tim the Enchanter"}, posts);

I've already done the code but am just finishing the docs.

If you are doing this change then it would also be good if the to("") method returns the mapper object (this) because then you could chain the calls.
const postMapper = (new Mapper())
  .map("text").to("user.text")
  .map("description").to("user.description");

BTW, what happened to the createMapper() function?
const postMapper = createMapper()
  .map("text").to("user.text")
  .map("description").to("user.description");

reads better to me.
Regards,

BTW, I would have structured your example more like
const postMapper = new Mapper();
postMapper.map("text").to("user.text");

const authorMapper = new Mapper();
authorMapper.map("name").to("user.name");

const posts = postMapper.execute({"text": "value"});
const result = authorMapper.execute({"name": "Tim the Enchanter"}, posts);

I still think that the
const result = authorMapper.execute({"name": "Tim the Enchanter"}, posts);

would be better with a merge method. Having the source as the last parameter seems wrong as most API's I know use the destination parameter as the first one. So I would push for
const posts = postMapper.execute({"text": "value"});
const result = authorMapper.merge(posts, {"name": "Tim the Enchanter"});

Regards,

Sorry, I typed dumb. createMapper still there, no use of new on the public API.
We are on the same page. I'm just exposing the default method additionally as a method on the mapper. Let's discuss chaining later.

I'm not sure what you are on about about source being the second parameter. The signature is:
execute(sourceForMapping, existingObjectThatYouWatchToAttachTheResultTo)

Normally you merge into the first parameter.
So it would be merge(existingObjectThatYouWatchToAttachTheResultTo, sourceForMapping).

That would be extremely confusing to me. The implemented execute method takes source as its first parameter. Source shouldn't become the second parameter when you add the destination.
I'm also not keen on making unnecessary breaking changes. This would break an existing method a couple days after it was implemented.


fix(CompactTarget): Manually implement comparison traits

The CompactTarget is a lossy encoding of a Target, as such two Target objects may compare differently to the associated CompactTarget, this is surprising.
We can manually implement all the comparison traits (incl. Hash) by first converting the CompactTarget to a Target - this way any comparison or ordering will be unsurprising.
Fix: #2110

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 16 (31.25%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 84.006%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bitcoin/src/pow.rs
5
16
31.25%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
19544

Relevant Lines:
23265

💛  - Coveralls

On ice until after next release.

I think we agreed in #2110 to drop PartialOrd and Ord.
Then as far as Eq and Hash go, I don't understand why we bother converting to a target. Doing this is functionally identical (for Eq) and provides no new information (for Hash) versus not doing it.

Ah, right, some compact targets may be unequal while the expand to the same target.
In https://github.com/rust-bitcoin/rust-bitcoin/issues/2110#issuecomment-1751748756 I proposed dropped PartialEq (and therefore Eq and Hash) because the semantics were non-obvious, but suggested we could keep PartialOrd because "the compact representation does preserve order". But actually I don't think that's true. If it doesn't preserve (in)equality then how can it preserve order?

If it doesn't preserve (in)equality then how can it preserve order?

Good observation. Are we back at another "this does not behave as you would expect, welcome to Bitcoin" comment?

Good observation. Are we back at another rusdoc "this does not behave as you would expect, welcome to Bitcoin" as the only solution?

I think we should just tell people to either convert to a Target or convert to a u32 if they want equality or ordering, because these have different semantics and it's not obvious which one they want.

Closed in favour of #2754


Fix for unknown application icon

Adds the StartupWMClass property in the desktop launcher, so that the correct application icon of the system's icon theme will be used for the opened window (e.g. in the Dock).
The value was obtained by running xprop and clicking on the application window.

Thank you! I didn't know about this. I hope this also fixes the app icon and name in lock screen notifications


User Settings

Acceptance Criteria

Users should have the ability to update their account information, including password, class level, account name, username, and email.
This feature should be easily accessible from the owner’s page while logged in.


add softmax activation function, confusion matrix, some Tensor utils and some Tensor factory functions

Add the softmax function to the ActName(..)
Add a confusion matrix generator as well as a function to convert it to a Matplotlib
Add a function to create a Tensor with 1 at a given position and 0 everywhere else
Add the oneHot function
Add accuracy, precision, recall, f1, macroAvg and weightedAvg

Thank you for your PR, @Jossl123 !!
One comment: In the definition of precision/recall/f1 in src/Torch/Model/Utils.hs, you have to care about the case where the denominator equals 0.  This happens when tp + fn = 0.  You may have to consult the theoretical definition of precision/recall/f1 to see what are their values when the denominator equals 0.
Please send another PR when this is done.

Thank you very much for the feedback,
I putted the confusion matrix plot in the nlp-tools 👍
Concerning the case where it's zero, i don't see any good way to code it without using "asValue", for now it's not crashing it's only putting "NaN" so should i put a filter to convert every NaN to a 0.0 or is this 汚い way of doing it ?
Should I also put the evaluations functions into nlp tools too ?


[Bug]:

Version
1.2.2
Environment that reproduces the issue
Macbook M1 2020
OS- Sonoma
Flutter version - 3.16.5
Is it reproducible in the example application?
Yes
Reproduction steps
I'm getting issue after adding this tag in my manifest file

Expected result
It should be running as mentioned in  video_uploader: ^1.2.2 package readme. But I'm facing issue in my manifest after adding service tag
Actual result

Additional context
No response
Relevant logs output
No response

Hi,
There is a syntax error in your AndroidManifest.xml. If you are looking for an example, you can have a look at: https://github.com/apivideo/api.video-flutter-uploader/blob/main/example/android/app/src/main/AndroidManifest.xml

here is my android manifest. Everthing is same as mentioned in example still facing issue in service tag

Ok, I try on my side.
It seems the reason is the tools:node="merge'
Could you replace the service section by:
      <service
            android:name="androidx.work.impl.foreground.SystemForegroundService"
            android:foregroundServiceType="dataSync"
            android:exported="false" />

If this fixes your problem, I will update the documentation.

This issue is considered as stalled.
Please reopen it if you need support


Please tag latest release as v*

Latest release is not recognized by go tool because v prefix is missing. In has to be v2.4.5, not 2.4.5.

Sure. Thanks for the notice.


why it will coredump when i compile a libXX.so based on openvino_2019.1.144

hello,
i compile a libXX.so using g++ and wrapping some c api (extern "C") like that,

i call the c api in a c project and it works right when i compile library based on openvino_2018.4.420, but it will coreump when  i compile library based on openvino_2019.1.144.
i gdb the coredump file is like that,

why?
the test code like that,

and all the code and model is as follow,
openvino_test_code.zip
thanks,

gcc-4.8.5

Probably you catched problem with ABI mismatch (it should be compatible with C++11, like OpenVINO compiled).
More info is available via searching for this keyword: _GLIBCXX_USE_CXX11_ABI.

@alalek
hi,
i use g++ 4.8.5,  and the CFLAGS  is like that
CFLAGS = -std=c++11  -fPIC -fPIE -O3 -DHAVE_AVX2 -mavx -mavx2  -D_GLIBCXX_USE_CXX11_ABI=0
but it cannot solve the problem

and all sample from openvino_2019.1.144 are work well.
but it will coredump when i compile a libXX.so based on openvino_2019.1.144.
i don't know why it works when i compile a libXX.so based on openvino_2018.4.420.

-D_GLIBCXX_USE_CXX11_ABI=0

Try _GLIBCXX_USE_CXX11_ABI=1 instead (modern GCC 5.x+ assumes that). OpenVINO has been compiled using C++11 compilation mode.

Alternatively you can try to build code from sources of this repository

@alalek
It doesn't solve the problem when i try to build code from sources of this repository.
can you help to complie the test code what i upload and see what happen to it?
the code is as follow,
openvino2019_test.zip
and i complie it like that,
g++ test.c tveAiContext.cpp tveWrapper.cpp  -std=c++11 -I. -I/opt/intel/openvino/inference_engine/include -L/opt/intel/openvino_2019.1.144/deployment_tools/inference_engine/lib/intel64/ -linference_engine  -ldl -fPIE -g  -o test

is someone meet this confuse?


Rename StateDistribution files

Renamed StateDistribution to StateDistributionGamma and StateDistribution1 to StateDistributionExponential. Changed all imports to new names. The other two names seemed fairly descriptive so I left as is

Codecov Report

Merging #364 into master will not change coverage.
The diff coverage is 62.50%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f9ec5...48af718. Read the comment docs.

Great—I'll merge right now.


Problem sampling from modified model checkpoint -

Hi,
I'm making some network modifications based off this repository, and I've come across an issue - I've opened an issue here but I thought I would post here as well, since the issue may lie here rather than in nn.
I have trained a model with no issues, and no errors were thrown during training - however when I attempt to sample from the model, I am presented with the error message Squeeze.lua:25: bad argument #1 to 'set' (expecting number or Tensor or Storage). The Squeeze module in question has been checked by modifying Squeeze.lua to print argument 1, and the input - argument 1 being passed on line 25 is in fact a number in my case, so this error message is a red herring.
This issue references a similar issue, and mention was made of this being due to the use of CUDA and a problem with saving checkpoints and then updating nn.
However, I had not updated any packages in between training and attempting to sample. I trained the model using ByteTensors as input, though if these get cast into something else later on I am unsure - I believe they are since nn.Squeeze gets angry when presented with ByteTensors, but it's unclear what to. When trying to sample the model using a DoubleTensor (since I have heard that it may be related to the tensor type), the issue remains.
Can anyone shed any light on this? I apologise for posting this both here and in the nn repository, I am just hoping to understand the cause of this so I can fix it as I am somewhat short on time - please accept my apologies if this is something that has already been fixed.
Thanks!

I've received a response on the other issue that I opened on the nn repository. It was an issue with the type of tensor I was passing to the network, and manually casting the network's input using inputTensor = inputTensor:type('torch.FloatTensor') (and running it with -gpu -1 to ensure that the network type remains a torch.FloatTensor) solved the problem entirely. My apologies for posting an issue when this was something I had missed instead!


Remove np packge

Since pnpm is used for publishing, I removed np so it doesn't confuse us
Let's introduce release-it soon

@zaiste commit history cleaned up


Filter is Case Sensitive

Appears that the filter is case sensitive - "Test" returns 1 row. "test" returns zero rows.

Latest commit adds a dropdown to choose "Exact match", "Case insensitive" or "regex"


[SPARK-35738][PYTHON] Support 'y' properly in DataFrame with non-numeric columns with plots

What changes were proposed in this pull request?
This PR proposes to port the fix https://github.com/databricks/koalas/pull/2172.
ks.DataFrame({'a': [1, 2, 3], 'b':["a", "b", "c"], 'c': [4, 5, 6]}).plot(kind='hist', x='a', y='c', bins=200)

Before:
pyspark.sql.utils.AnalysisException: cannot resolve 'least(min(a), min(b), min(c))' due to data type mismatch: The expressions should all have the same type, got LEAST(bigint, string, bigint).;
'Aggregate [unresolvedalias(least(min(a#1L), min(b#2), min(c#3L)), Some(org.apache.spark.sql.Column$$Lambda$1556/0x0000000800d94840@42fb0cc1)), unresolvedalias(greatest(max(a#1L), max(b#2), max(c#3L)), Some(org.apache.spark.sql.Column$$Lambda$1556/0x0000000800d94840@42fb0cc1))]
+- Project [a#1L, b#2, c#3L]
   +- Project [__index_level_0__#0L, a#1L, b#2, c#3L, monotonically_increasing_id() AS __natural_order__#8L]
      +- LogicalRDD [__index_level_0__#0L, a#1L, b#2, c#3L], false

After:
Figure({
    'data': [{'hovertemplate': 'variable=a
value=%{text}
count=%{y}',
              'name': 'a',
...

Why are the changes needed?
To match the behaviour with panadas' and allow users to set x and y in the DataFrame with non-numeric columns.
Does this PR introduce any user-facing change?
No to end users since the changes is not released yet. Yes to dev as described before.
How was this patch tested?
Manually tested, added a test and tested in notebooks:

cc @ueshin, @itholic @xinrong-databricks FYI

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44235/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44235/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44235/

Thanks @xinrong-databricks.
Merged to master.


Problem getting membership for user

Hi!
first of all, great job!
I have the next code, and I was searching on the issues panel for this problem, and my code is the next:
var ActiveDirectory = require('activedirectory');

var url = 'ldap://<IP_ADDRESS>';
var baseDN = 'dc=domain,dc=com';
var username =<EMAIL_ADDRESS>var password = 'pass';

var config = {url:url,
                baseDN: baseDN,
                    logging:{
                    name:'ActiveDirectory',
                    streams: [
                        {level: 'debug',
                        stream: process.stdout}
                    ]
                }};

var ad = new ActiveDirectory(config);

ad.authenticate(username, password, function(err, auth) {
    if (err) {

        console.log('ERROR: '+JSON.stringify(err));
        return;
    }

    if (!auth) {

        console.log('Authentication failed!');
    } else {

        console.log('Authenticated!');

        var opts = {
            bindDN: username,
            bindCredentials: password
        };

        var adUser =<EMAIL_ADDRESS>
        ad.getGroupMembershipForUser(opts, adUser, function (err, groups) {
            if (err) {
                console.log('ERROR: ' + JSON.stringify(err));
                return;
            }
            if (!groups) console.log('User: ' + username + ' not found.');
            else console.log(JSON.stringify(groups));
        });
    }
});

The problem is the next on the log:

{"name":"ActiveDirectory","hostname":"jas-dev_nodejs","pid":2516,"level":50,"err":{"message":"0000202B: RefErr: DSID-031007EF, data 0, 1 access points\n\tref 1: 'domain.com'\n\u0000","name":"ReferralError","stack":"ReferralError: 0000202B: RefErr: DSID-031007EF, data 0, 1 access points\n\tref 1: 'domain.com'\n\u0000\n    at messageCallback (c:\Users\Administrator\WebstormProjects\_test\ActiveDirectory\node_modules\ldapjs\lib\client\client.js:1419:45)\n    at Parser.onMessage (c:\Users\Administrator\WebstormProjects\_test\ActiveDirectory\node_modules\ldapjs\lib\client\client.js:1089:14)\n    at Parser.emit (events.js:107:17)\n    at Parser.write (c:\Users\Administrator\WebstormProjects\_test\ActiveDirectory\node_modules\ldapjs\lib\messages\parser.js:117:8)\n    at Socket.onData (c:\Users\Administrator\WebstormProjects\_test\ActiveDirectory\node_modules\ldapjs\lib\client\client.js:1076:22)\n    at Socket.emit (events.js:107:17)\n    at readableAddChunk (_stream_readable.js:163:16)\n    at Socket.Readable.push (_stream_readable.js:126:10)\n    at TCP.onread (net.js:538:20)","code":10},"msg":"[UNKNOWN] An error occurred performing the requested LDAP search on dc=domain,dc=com ({"bindDN":"administrator@adtest.com","bindCredentials":"@dmin2016","filter":"(&(objectCategory=User)(|(sAMAccountName=user1@adtest.com)(userPrincipalName=user1@adtest.com)))","scope":"sub","attributes":[],"controls":[{"_value":{"size":1000},"type":"1.2.840.1135<IP_ADDRESS>9","criticality":false,"value":{"size":1000},"json":{"controlType":"1.2.840.1135<IP_ADDRESS>9","criticality":false,"controlValue":{"size":1000}}}]})","time":"2016-04-14T11:15:34.065Z","v":0}
ERROR: {"dn":"","code":10,"name":"ReferralError","message":"0000202B: RefErr: DSID-031007EF, data 0, 1 access points\n\tref 1: 'domain.com'\n\u0000"}

I dont know why Im getting this error.

Make sure that your baseDn is set correctly for the domain controller you can calling. If you don't know what it is, then you can use the getRootDSE method.
The error you are receiving indicates a referral error. Do you have referrals in your AD configuration? If not, then you have configuration problems.

Yes, you were rigth. I was naming wrong DC fields.
Thank you!


Fixed helpMarkDown typo in DotNetCoreCLI task

The csproj wildcard path is missing an * character. It should be **/*.csproj.

@webster354 Good catch. Thanks for fixing it. :)

Also, if you already have a setup, do build the task once. By running gulp build --task DotNetCoreCLI in the root of vsts-tasks folder, to update the strings for localization.

@ds-ms is this good to be merged?

@ds-ms can you help in merging this after updating the task version

I'll pick up these changes in a different PR. Closing it.


libfreenect2 uses a dual apache/gpl license

[X] Changes comply with the maintainer guide.
[X] SHA512s are updated for each updated download.
[X] The "supports" clause reflects platforms that may be fixed by this new version.
[X] Any fixed CI baseline entries are removed from that file.
[X] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

@microsoft-github-policy-service agree

https://github.com/OpenKinect/libfreenect2/blob/fd64c5d9b214df6f6a55b4419357e51083f15d93/src/allocator.cpp#L7-L24
Agreed, thanks for the fix!


Proposal: Add function NewFromFloat

It would be really useful to be able to create a new Money struct from a float or maybe a decimal string ('1.243'). Formatting the decimal amount from a source (API response, file, ...) to a Money struct can get really tedious, that's why I propose a util function inside the money package for dealing with this cases.
This is my current implementation:
func NewFromFloat(amount float64, currency string) *money.Money {
	currencyDecimals := math.Pow(10, float64(money.GetCurrency(currency).Fraction))
	amountCents := int64(amount * currencyDecimals)
	return money.New(amountCents, currency)
}

To not lose precision dealing with floats there can also be a NewFromString, but I haven gotten around to implementing it.
What do you guys think?

Hi @npinochet, great idea! I would love to see it implemented, I cannot find any issues with your code example

Perfect, I went ahead and made the PR https://github.com/Rhymond/go-money/pull/115

Hi @Rhymond, first of all thank you so much for this great package!
When will we have a new release with these changes?

Hey @azlancpool, Thanks! I just reviewed a PR and left couple of comments, if you're interested in NewFromFloat that's probably going to be merged soon.

@azlancpool NewFromFloat merged and released in v1.0.9

As this issue is only for NewFromFloat, I'll close the issue since it's done 👍


apk convertion

What feature do you want to get added on the base engine?
idk how but i think it would be cool if you were somehow able the make it able to be converted to apk for android or something
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

Might actually seems like a good idea, but i don't think thats possible. Also, fnf it's made on pcs, and you can encounter ports made by the community.

Android is not officially supported


Implement 0x Integration

This is almost done

@Aqrare
it is not working properly, if you have time, please check 30m - 1h from your side too.

I think current implementation is not affected by api so we can integrate 0x now too.


superset does not close db connections

Superset does not close db connections. Аs a result, connections hang for days and eventually exceed the allowed number
See error FATAL:  too many connections for role "superset"
Is it possible to make a superset with close db connections?
version superset 2.1.0
superset running in kubernetes
db in psql cluster
python3.8
Connections do not close pods of worker and celery-beat

found out that hung sessions remain after SQL-lab

Not all DBs support query cancellation as such, but we've made improvements for those that do. It sounds like you might need to make some timeout adjustments at your DB layer? Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If you are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!


vscode in chrome os assumes user's home is workspace (bad assumption)

Issue Type: Performance Issue
Just install Vscode in chrome os, and used the chrome os/linux short cut to start
vscode.  By default this method assume that "linux files" (user $HOME) is the workspace.
Without reading how to start vscode for linux documentation, it becomes difficult to
create a new workspaces within workspaces. My guess is vscode does not like workspaces within workspaces.
To circumvent this problem, I now create new workspaces by using the
linux command line instructions to create a new workspace/project.
Then when I start Vscode in chrome OS (from linux app folder), I have
no problems.
If you are new to vscode and follow the tutorial videos, and don't know the unstated assumption that the starting folder becomes the workspace it makes it difficult to
create multiple projects (workspaces), with different languages under the same home workspace.  I assume each project is isolated from other projects by placing them in different workspaces.
Just a suggestion after spending days trying to understand and set up multiple workspaces. Not a good experience.
Suggestion: provide a facility (in "file" drop down menu) for creating a workspace.
and other facilities for modifying and deleting work spaces (they may exist but I don't see them in the file menu). Include in the "create new workspace" option a requirement for the user to specify where the workspace is located. Allow the user
to navigate to an existing folder and create a new folder in that menu, rather than assuming the workspace folder already exist (which is part of the linux command line process).
No longer assume the starting directory is the default workspace. Make the user always define where the workspace is located rather than assuming the starting directory.
VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T17:50:03.709Z)
OS version: Linux x64 4.19.98-08076-g24ab33fb8e14

System Info

Item
Value

CPUs
06/8e (2 x 1607)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: disabled_offoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
6.48GB (1.97GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
100%

Workspace Info
|  Window (hello_world.cpp - cpp_hello_world (Workspace) - Visual Studio Code)
|    Folder (cpp_hello_world): 8 files
|      File types: code-workspace(1) h(1) cpp(1) json(1)
|      Conf files: tasks.json(1);

Extensions (7)

Extension
Author (truncated)
Version

c-cpp-compile-run
dan
1.0.8

vscode-eslint
dba
2.1.5

vsc-material-theme
Equ
32.6.0

vsc-material-theme-icons
equ
1.1.4

cpptools
ms-
0.27.0

material-icon-theme
PKi
4.1.0

vscode-arduino
vsc
0.3.0

(1 theme extensions excluded)

We have written the needed data into your clipboard because it was too large to send. Please paste.

Can you provide steps for how you are trying to do this?

Without reading how to start vscode for linux documentation, it becomes difficult to
create a new workspaces within workspaces.

It appears, that following the tutorial for new VScode beginners, (in the Chrome OS env) that launching the app from tray, places you in the users home directory by default
(i.e $HOME directory).  When you create a file, it is in that directory. When you save as
a workspace your $HOME directory becomes the workspace (by default).
I don't remember this being mentioned in the tutorial (video).
I read a linux info for Vscode.  It started by creating a directory, under your home
directory, going to that directory and starting "code" from there.
I assumed that is the way to do it.
now I have learned that I can create a new directory/folder within vscode, to whatever
depth needed and save it as a workspace.  This added information would be more
helpful in the initial video tutorial. It took me some time to figure out this process.
I believe workspaces are a very important part of vscode. They should be addressed
from the beginning.  Default values make it quick, but can lead to frustration down the road.


Dropdown keep on screen left/right

Right now you can use keepOnScreen and the dropdown will automatically detect if it should open up or down in order to keep inside its context. Could be possibly to add an option, or improve this one, so the dropdown automatically detects if it should open to the left or to the right in order to keep in context?
Example,
I have this table where clicking on an icon in the second headers row opens a dropdown menu. I can't choose upfront if the menu should open left or right because either way some elements will have problems displaying.
Right now my only solution is to keep enaugh enough margin left and right to the table so it can display de menu, but this table can have a lot of data and I don't wan't to waste any pixel.

Now I see it is a duplicate from #4112 and has already a PR #4211


Change Tag class

Codecov Report
Base: 72.47% // Head: 72.63% // Increases project coverage by +0.15% :tada:

Coverage data is based on head (e3232cb) compared to base (0c8a113).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
+ Coverage     72.47%   72.63%   +0.15%
- Complexity      525      527       +2
============================================
  Files            89       89
  Lines          1617     1637      +20
  Branches        174      176       +2
============================================
+ Hits           1172     1189      +17
- Misses          380      383       +3
  Partials         65       65

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/CreateCommand.java
93.75% <ø> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
96.15% <100.00%> (+0.07%)
:arrow_up:

src/main/java/seedu/address/model/tag/Tag.java
85.71% <100.00%> (+5.71%)
:arrow_up:

.../seedu/address/logic/parser/AddressBookParser.java
81.08% <0.00%> (-0.74%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


general<EMAIL_ADDRESS>not available via GOPROXY=direct

What version of CUE are you using (cue version)?
I'm not running cue locally, this is a build time error/bug.
Does this issue reproduce with the latest stable release?
No.
What did you do?

export GOPATH=$WORK/_gopath
export GOPROXY=direct
go mod init mod.example
go get -x<EMAIL_ADDRESS>
What did you expect to see?
cuelang.org/go @ version 0.9.2 to be added to my go.mod/go.sum files.
What did you see instead?
go: creating new go.mod: module mod.example
# get https://cuelang.org/?go-get=1
# get https://cuelang.org/go?go-get=1
# get https://cuelang.org/go?go-get=1: 200 OK (0.133s)
mkdir -p _gopath/pkg/mod/cache/vcs # git3 https://review.gerrithub.io/cue-lang/cue
# lock _gopath/pkg/mod/cache/vcs/d82383d43199d57840995f1c0a94e81eee5ed02e43dbba4468223292497673e2.lock
# _gopath/pkg/mod/cache/vcs/d82383d43199d57840995f1c0a94e81eee5ed02e43dbba4468223292497673e2 for git3 https://review.gerrithub.io/cue-lang/cue
cd _gopath/pkg/mod/cache/vcs/d82383d43199d57840995f1c0a94e81eee5ed02e43dbba4468223292497673e2; git tag -l
# get https://cuelang.org/?go-get=1: 200 OK (0.134s)
0.002s # cd _gopath/pkg/mod/cache/vcs/d82383d43199d57840995f1c0a94e81eee5ed02e43dbba4468223292497673e2; git tag -l
cd _gopath/pkg/mod/cache/vcs/d82383d43199d57840995f1c0a94e81eee5ed02e43dbba4468223292497673e2; git ls-remote -q origin
2.348s # cd _gopath/pkg/mod/cache/vcs/d82383d43199d57840995f1c0a94e81eee5ed02e43dbba4468223292497673e2; git ls-remote -q origin
go<EMAIL_ADDRESS>invalid version: unknown revision v0.9.2

I noticed this issue while trying to build a project (cosign) which takes cue as a dependency. Their latest stable release (v2.4.0 at the time of writing) uses v0.9.2.
I also noticed that v0.9.1 does not exist on gerrit (I haven't checked if all GitHub tags have gerrit tags, just happened to notice v0.9.1 as well)
This type of issue was previously reported in #2895, for an older version. Just like in that issue, v0.9.2 does exist on GitHub, but not gerrit.
I'm no gerrit expert, but It seems like if v0.9.2 were to be present on gerrit, this link would work, and v0.9.2 would show up on this list of tags

Thanks for reporting this, and you're absolutely correct. Due to how Gerrit works (or how we have configured it), tags are only publicly available if they are reachable from a branch. And we recently deleted the release-branch.v0.9 branch, thus hiding some of the v0.9.x tags. We know how to work around this, and even documented it (https://github.com/cue-lang/cue/wiki/Notes-for-project-maintainers#release-branches), but we failed to follow this process.
Maybe we should add some sort of automated checks for it, given that we messed up twice already.

I created refs/attic/release-branch.v0.9 on Gerrit, and v0.9.2 is now reachable. Apologies again for the trouble.

This should not happen again, at least not for long: I've added an automated CI check at https://review.gerrithub.io/c/cue-lang/cue/+/1201173.

Thanks for the quick response @mvdan! The new automation looks good 👍


Add to blacklist

Added a new scam link found on Discord on December 29th, 2022.

havent the hacking of discord users to send phishing links stopped?
in the last year I have not seen anything but rare advertisements of porn discord guilds.
stop nitro scam discord bot is no longer online, I stopped it more than six months ago because it looks like it is no longer needed (seems like discord developers have made an automatic moderation system that automatically bans such accounts, or all phishers have just disappeared).
In any case, thank you for your contribution to the database of scam sites - maybe someone will need this database in the future.

I also renamed the repository to remove its relation with the currently stopped discord bot.
If phishing returns to discord in the future, I'll just revert the repository back to the old commit, before renaming.

havent the hacking of discord users to send phishing links stopped? in the last year I have not seen anything but rare advertisements of porn discord guilds. stop nitro scam discord bot is no longer online, I stopped it more than six months ago because it looks like it is no longer needed (seems like discord developers have made an automatic moderation system that automatically bans such accounts, or all phishers have just disappeared). In any case, thank you for your contribution to the database of scam sites - maybe someone will need this database in the future.

Oh, no, the phishing is still rampant; hacked users' accounts are forced to spread the links via a bot. I've been in 3 servers that have occasional hacked people posting the links in various text channels (some of them even post the link in every single channel possible), and across all 3 of those servers, there have been 5 cases within the last month alone. Discord has never been able to actually detect these users, as the bot logs in using their credentials. I have always needed to report the phishing links to the server in question's moderators, who would ban the user from their server and delete the messages. In all these cases, the actual account owner eventually got their account back and apologized, and was let back into the server.
So, no, Discord's new auto moderation system has done jack squat, even when enabled on servers affected. The bots post just once (in every available channel) every 2 hours to get around the auto moderation.


Start updating the readme

Description
Updates the readme to reflect 1.2 changes.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.
Please reference the issue this PR will close: #109
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Tests pass
[ ] Created/updated tests
[ ] Extended the documentation

Codecov Report

Merging #114 (a2bf1c5) into main (bf50ad8) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #114      +/-   ##
============================================
- Coverage     76.20%   75.99%   -0.22%
- Complexity      560      562       +2
============================================
  Files            68       69       +1
  Lines          1786     1791       +5
============================================
  Hits           1361     1361
- Misses          425      430       +5

Impacted Files
Coverage Δ

src/lib/Client/StateTransactionRequest.php
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf50ad8...a2bf1c5. Read the comment docs.


accelerate inference？

accelerate training, we also consider accelerated inference, but there is no stable implementation of lossless acceleration. It's a future work.


Optimize keyboard experience

What changes do you make in this PR?

Please describe why you create this PR

Manually drive with keyboard does not feel so good. Let's see if we can improve the experience with this PR.
Checklist

[x] I have merged the latest main branch into current branch.
[x] I have run bash scripts/format.sh before merging.
Please use "squash and merge" mode.

@QuanyiLi could you play with drive_in_single_agent_env.py to see if this feels better?

It feels bad when the car drives fast. At least, my performance degrades. Maybe I overfit the old keyboard controller...

It takes so long for the steering wheel to return to the center. It makes the control hard when the speed is high.

Now I've reverted all values to previous version. The key differences:

we introduce space key to indicate takeover when using keyboard
A little different behavior on up and down keys:

If throttle > 0, and you press down, we will not set the brake to -brake_increment. The original code is:
        elif throttle_brake < 0.:   # WHEN YOU PRESS DOWN KEY
            self.throttle_brake = min(self.throttle_brake, 0.)  # IF throttle>0, IT WILL SET TO 0.
            self.throttle_brake -= self.BRAKE_INCREMENT  # throttle NOW EQUALS brake_increment

Instead, in this impl, we use:
        elif down_key_pressed:
            if self.throttle_brake <= 0.0:
                self.throttle_brake -= self.BRAKE_INCREMENT
            else:
                self.throttle_brake -= self.BRAKE_INCREMENT_WHEN_THROTTLE

note that
BRAKE_INCREMENT = 0.5
BRAKE_INCREMENT_WHEN_THROTTLE = 0.5
In this impl, we avoid too large change in the throttle_brake.

It is good now.


Improve definition for "Decimal" in Waypoint: Use Hex Code for Specific Colors

Challenge Waypoint: Use Hex Code for Specific Colors has an issue.
The definition for "Decimal" is . . . pretty bad.  The actual term should probably be "Base 10 Numbers".  Either way, the definition is clunky and needs a tune-up.
Current text:

Decimal means the numbers zero through nine - the numbers that people use in everyday life. Hexadecimal includes these 10 numbers, plus the letters A, B, C, D, E and F. This means that Hexidecimal has a total of 16 possible values, instead of the 10 possible values that our normal base-10 number system gives us.

Maybe some improved verbiage and a "more info" link to discuss Base-16 numbering systems?

Float/Decimal is a term is used in various programming languages to define a variable with a fractional value. Numbers created using a float variable declaration will have digits on both sides of a decimal point. This is in contrast to the integer data type, which houses an integer or whole number.

I think that we should include both definitions because the current one could be used to help get a user's head wrapped around the concept of Base-10 and Base-16 numbers. I think that it is important the a user understands the concept of base numbering systems, so we might also include base 2(binary) and the concept of counting with these new bases


add the base for modern stats

Again, works towards #172 by adding a ModernStatsRequest which is abstract and needs to be implemented for each of the types:

summary
operators
weapons
trend
bestmatchweekly - which will be ignored for now as it's filed under narrative instead of current

Going to push a new data library update to attempt to fix the bug

well that framework bump fixed tests...

going to drop this as the changes here are going into a new project


value of WriteOptions missing

in bluetooth.d.ts is the value missing in interface WriteOptions.
Currently, it is:
export interface WriteOptions extends CRUDOptions {}
But it needs to be:
export interface WriteOptions extends CRUDOptions {
value: any;
}
I would push the change to a new branch but I'm not authorized to do so.
It would be great if you could apply the change. Thanks in advance.

Great find! That's what Pull Requests are for btw. Are you willing to create one? :)

I tried to create a new branch but I don't have permission for that. So creating a pull request will not work as both branches would be 'master', right? But if I could, I would :)

Has this fix been released to npm? I still need to manually do this fix in my project after tns install...

@tkaarrela Ah, nope.. but it has now (1.1.3)!


fatal: reference is not a tree: e9a9c62ce02115f7a4d7f197ba43362dcf0ea3d0

Looks like someone force pushed

Hello! :wave:
Is this still an issue?

delete package-lock.json file before install working for me.

I updated v1.1.1 with an updated package-lock.json and ran and manual setup and also a setup via contentful guide.
Can you let me know if the problem persists? :)

uses: actions/checkout@v2 fixed

Hi,
When I npm install or go through contenful guide, I always end up with :
npm ERR! Command failed: /usr/local/bin/git checkout e9a9c62ce02115f7a4d7f197ba43362dcf0ea3d0
npm ERR! fatal: reference is not a tree: e9a9c62ce02115f7a4d7f197ba43362dcf0ea3d0
I'm using node 9.3.0 and npm 5.6.0.
Any idea ?

no idea


Fix fusion-pose-sensor.js for Firefox on Android

Firefox for android returns the timestamp correctly now so there is no need to divide by 1000 any more.

I signed it

Thanks @bluemarvin! Missed the notification for this, sorry for the delay!
Is this a change in Firefox Nightly/56? Should this also check something else to work in Firefox < 56, as is currently?

I'm not sure which version of Fennec the fix landed in, but it is in current release so I don't know that it is worth checking versions.

Confirmed with Firefox for Android release 54 that this fixes it -- thanks @bluemarvin for the PR!

Landed in v0.9.36, thanks!


Rename the EGL members (for 1.2)

Renaming of the egl... members as s_ avoiding identifiers in our code
clashing with official names of functions is definitely a good idea to
avoid redeclaration errors like this:
src/ws.cpp:74:33: error: 'void* (* eglCreateImageKHR)(EGLDisplay,
EGLContext, EGLenum, EGLClientBuffer, const EGLint*)' redeclared as
different kind of symbol
static PFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;
The argument to eglGetProcAddress() has nothing to do with the name of
the variable. It is the name of a symbol from the EGL API:
https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglGetProcAddress.xhtml.
Also added non-null asserts to those pointers to make more evident
crashes due to null in the future (for example: changes in the name of
the symbols):
assert(s_eglBindWaylandDisplayWL);
assert(s_eglCreateImageKHR);
assert(s_eglDestroyImageKHR);
assert(s_eglQueryDmaBufFormatsEXT);
assert(s_eglQueryDmaBufModifiersEXT);

Instead of merging this, I will cherry-pick to the wpebackend-fdo-1.2 branch the changes merged with #51 — the net result will be the same, but with better traceability because Git inserts a comment in the log stating which commit was cherry-picked.


Test & Document Kubernetes Version and API Support

Problem Statement
We need an authoritative source of truth as to which k8s versions are "supported" by which version of KIC.
Proposed solution
We call a version supported if:

tests defined in #1542 for that version pass
there are no known API incompatibilities between the respective: KIC version and the k8s version

The version compatibility matrix lives here.
Acceptance Criteria

[x] e2e testing added to verify versions 1.17-1.21 on production quality cluster deployment (GKE)
[x] the version compatibility matrix is up to date for 1.3 and 2.0
[x] starting with KIC 2.0, each version marked as "supported" is covered by automated integration tests (#1542)
[x] Releases are blocked (by manual process or by CI/automation) if the criteria above are not met.

Possible solutions: add an entry to the release checklist, or add CI/automation that blocks a release if the criteria are not met.

[x] optional: expose the compatibility test results in a visible place to end-users

Possible solution: link from changelog/release notes to the CI results page

Issues

https://github.com/Kong/kubernetes-testing-framework/issues/32
https://github.com/Kong/kubernetes-testing-framework/issues/66
https://github.com/Kong/kubernetes-testing-framework/issues/68
https://github.com/Kong/kubernetes-ingress-controller/issues/1617
https://github.com/Kong/kubernetes-ingress-controller/issues/1617
https://github.com/Kong/kubernetes-ingress-controller/issues/1614
https://github.com/Kong/kubernetes-ingress-controller/issues/1613

Pull Requests

https://github.com/Kong/kubernetes-testing-framework/pull/59
https://github.com/Kong/kubernetes-testing-framework/pull/64
https://github.com/Kong/kubernetes-testing-framework/pull/67
https://github.com/Kong/kubernetes-ingress-controller/pull/1610
https://github.com/Kong/kubernetes-ingress-controller/pull/1618

NOTES
Original spike: https://github.com/Kong/kubernetes-ingress-controller/issues/1043

Instead of targetting 2.0 specifically, maybe we could do it once and for all by:

introducing automated testing for the k8s versions promised to be supported #1053
updating our release procedure to always update docs
?

I don't see why we'd need to treat the 2.0 release in any special manner.

Instead of targetting 2.0 specifically, maybe we could do it once and for all by:
* introducing automated testing for the k8s versions promised to be supported #1053

* updating our release procedure to always update docs
  ?

I don't see why we'd need to treat the 2.0 release in any special manner.

Ok I'm persuaded we don't need to do this specifically in 2.0 scope (though I would like to for documentation's sake). I've moved this out fo the milestone and reworded it for later grooming, and we can add it as a stretch goal for 2.0 later if we like.

actually for now I'll just close this and bookmark it for myself and perhaps we can come back to it at a later time if we feel so inclined.

Re-open context: we're going to check requirements with @eskibars and then groom this for a later scope.

@mflendrich to deduplicate version support issues we have (they exist in several places)

While it doesn't resolve this, the following commit does add the version options we need for this in the KTF: https://github.com/Kong/kubernetes-testing-framework/pull/40/commits/b45df3e00df576a4afa5a1d85310fc33dc42872c

With the above changes to KTF we can prove version compatibility using our integration testing suite, I would like to see this be the way in which we move forward, and document results. Additionally I think we should make some hard calls to NOT support Kubernetes older than v1.16

The v2.0.0-alpha.3 release and the successful workflow thereof is the validation of the CI portions of this PR:

https://github.com/Kong/kubernetes-ingress-controller/releases/tag/v2.0.0-alpha.3
https://hub.docker.com/layers/kong/kubernetes-ingress-controller/2.0.0-alpha.3/images/sha256-94e68bc67ae1003011f7b016b2c511c98c849dfb4241d487afac578ad35acac0?context=explore
https://github.com/Kong/kubernetes-ingress-controller/actions/runs/1092174311

Now https://github.com/Kong/docs.konghq.com/pull/3081 has been made to be the last PR needed to finally resolve this issue by adding the relevant documentation.
I'm considering the optional part of the AC resolved by virtue of our CI workflows being publicly available for releases.

As per a recent @Kong/team-k8s discussion the remaining work (which is all documentation) does not need to block the beta release here. I'm separating the remaining documentation work into its own issue.


Fix simple branch

Hi,
Attached two commits for the simple branch.
The first one add a test for a problem I found when I had a target depending on two redo-stamp targets that were also marked with redo-always. Basically, the use case for this is:
cflags.do:
redo-always
echo $CFLAGS >$3
redo-stamp <$3

config.do:
redo-always
echo $CONFIG >$3
redo-stamp <$3

compile.do
redo-ifchange cflags config
. ./cflags
. ./config
cc-$CONFIG $CFLAGS -o $3
...

This was a very useful technique I found to be able to depend on environment variables.
The problem was that compile.do was always rebuilt even if neither cflags or config changed. I should have fixed that.
The other problem is that the test 130 failed because ls -l shown -rw-r--r--. instead of just -rw-r--r-- making the test fail. I don't know if the correction is ideal but it works on my computer. You might want to drop this find a workaround (such as tr -d .).
Mildred

The simple branch is a dead end. I'm going to try to fix the state features using a different method.


Room Header size and scrollarea margin

Describe the bug
The sizes of the header and the margin-top of the messages scroll area does not fit.
This causes the scroll up button to disappear half.
https://github.com/antoine92190/vue-advanced-chat/blob/472563d4882ea873c69f5f8ee739eee90b673228/src/lib/Room/RoomHeader/RoomHeader.scss#L5
https://github.com/antoine92190/vue-advanced-chat/blob/839359228416e1d9e51ce3d7e27c5904be5f1918/src/lib/Room/Room.scss#L36
It should be replaced by: margin-top: 65px;
Steps to reproduce

Go to https://antoine92190.github.io/vue-advanced-chat/
Open chat

Expected behavior
The scrollbar should be completely visible
Screenshots

Device (please complete the following information)

OS: Windows 10
Browser: Chrome 105.0.5195.127
Package version: 2.0.3

Nice catch, will fix that shortly


Simplify the PDF Viewer on Web

If you haven’t already, check out our contributing guidelines for onboarding!

We currently are using PDF.js to show PDFs inside an iframe on web and also hosting some demo code for the Mozilla PDF viewer. For this issue we will need to replace the complicated PDF viewer code with a simple bare bones viewer.
Deliverables:

Replace the existing PDF.js code + usage here with a PDF viewer using this library - https://github.com/wojtekmaj/react-pdf
That package is largely a React wrapper around PDF.js and should be simple to implement by using the recipe here to display all pages
Make sure to use the webpack esm imports https://github.com/wojtekmaj/react-pdf#webpack

Upwork: https://www.upwork.com/jobs/~01eb10da2c43ab7ead

Proposal

Use the react-pdf lib and replace the Pdf.js code completely.
Drop the Pdf.js vendor code from the repo.
Optimize the Pdf page rendering so that If a pdf have hundreds of page, it doesn't become a memory pit.
Take input of design from the team and Update if needed to match the product theme.

Questions

Do we need to support non-Latin characters! (here)[https://github.com/wojtekmaj/react-pdf#support-for-non-latin-characters]?

Do we need to support non-Latin characters

I think if we support them now then we should continue to support them.

Is this issue on Hold? If not, Can I work on this one, I see it's been sometime it's unassigned? I already submitted a proposal above.

Proposal looks good @parasharrajat. I don't think we need to worry about 3.

So it seems that we have to use our own CSS rules to modify the designs as react-pdf does not provide the styling like the old pdf viewer. Any inputs here.
I am planning to put the basic styling same as the old PDF viewer into a global CSS file to modify the PDF look.
To adjust the width we can use the useWindowDimensions and then set the width of the page.
What should the breakpoints and their respective width for the pages?
a) Set the page to 100% on the mobileResponsiveWidthBreakpoint.
b) need help here.

I would maybe pause on adding any CSS for now and we can loop in @shawnborton to help advise on the styles.
Is there any sort of default look to it at all with styling?

we have to use our own CSS rules to modify the designs

By CSS do you mean actual .css file or can we add inline styles like we do for most other react-native/react-native-web components?


Gdb test script

This PR adds a script that automatically runs common gdb commands, so gdb regressions can more easily be caught.

  Think that would be worth adding in another pull request?

Can you please rebase?

Comments addressed and patch rebased.


Classify duplicate and overlapping zones as configuration errors

How to categorize this PR?

/area control-plane
/area ops-productivity
/kind enhancement
What this PR does / why we need it:
This PR classifies DNS errors that can occur during reconciliation of the DNSProvider resource and have "duplicate zones" or "overlapping zones" in their error message as ERR_CONFIGURATION_PROBLEM
Which issue(s) this PR fixes:
Fixes #4844
Special notes for your reviewer:
Currently the errors have to be checked on gardener side since the DNSProvider.Status does not have a way to store error codes. Later on this could be improved.
Release note:

Error messages containing `duplicate zones` and `overlapping zones` in their description that can happen when reconciling `DNSProviders` are now classified as ERR_CONFIGURATION_PROBLEM.

/invite @timebertt


Add eye to hand to utilize hand eye sample

`%YAML:1.0
PoseState: !!opencv-matrix
rows: 4
cols: 4
dt: f
data: [ -6.30584419e-01, 5.66264272e-01, -5.30761778e-01,
7.45343445e+02, 7.65011191e-01, 5.68788469e-01, -3.02055508e-01,
9.39122009e+02, 1.30847946e-01, -5.96510231e-01, -7.91867673e-01,
8.57917725e+02, 0., 0., 0., 1. ]
`
The above file called "EyeToHandTransform.yaml" is to be added to SampleData

`%YAML:1.0
PoseState: !!opencv-matrix
rows: 4
cols: 4
dt: f
data: [ -6.30584419e-01, 5.66264272e-01, -5.30761778e-01,
7.45343445e+02, 7.65011191e-01, 5.68788469e-01, -3.02055508e-01,
9.39122009e+02, 1.30847946e-01, -5.96510231e-01, -7.91867673e-01,
8.57917725e+02, 0., 0., 0., 1. ]
`
The above file called "EyeToHandTransform.yaml" is to be added to SampleData

I've tested this and it works. Ready for review @robertkt1.


Fix ape atoll agility course diary requirement

Originally found on Reddit. This should instead be 48 agility.

this one should say 58 magic instead of attack


Develop

This first version of the NASA-EONET-API is functional and currently allows the fetching of data related to:

Current events.
Categories of disasters from the official NASA EONET REST API

This version is open to enhancements in functionality and code refactorization.

Merge and close.


Added new commands for setting up xdebug on phpfpm container side.

Removed unused port bindings for phpfpm from docker-compose related files.
Removed unused check from setup script.
Updated README with new commands and link to the wiki page about configuring PHPStorm with xdebug.

Thanks, @u-maxx!


Version 0.3.0 breaks the Web build. 0.2.2 works OK

After updating from 0.2.2 to 0.3.0 web build fails with:
../../../.pub-cache/hosted/pub.dev/launch_at_startup-0.3.0/lib/src/launch_at_startup.dart:39:34: Error: The method 'isRunningInMsix' isn't defined for the class 'LaunchAtStartup'.
 - 'LaunchAtStartup' is from 'package:launch_at_startup/src/launch_at_startup.dart' ('../../../.pub-cache/hosted/pub.dev/launch_at_startup-0.3.0/lib/src/launch_at_startup.dart').
Try correcting the name to the name of an existing method, or defining a method named 'isRunningInMsix'.
      if (packageName != null && isRunningInMsix(packageName)) {
                                 ^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/launch_at_startup-0.3.0/lib/src/launch_at_startup.dart:40:28: Error: The method 'AppAutoLauncherImplWindowsMsix' isn't defined for the class 'LaunchAtStartup'.
 - 'LaunchAtStartup' is from 'package:launch_at_startup/src/launch_at_startup.dart' ('../../../.pub-cache/hosted/pub.dev/launch_at_startup-0.3.0/lib/src/launch_at_startup.dart').
Try correcting the name to the name of an existing method, or defining a method named 'AppAutoLauncherImplWindowsMsix'.
        _appAutoLauncher = AppAutoLauncherImplWindowsMsix(
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Downgrading library to 0.2.2 solves the problem.
This happens at least on: Flutter (Channel stable, 3.22.1, on Ubuntu 24.04 LTS 6.8.0-31-generic, locale en_US.UTF-8)

I think it's because the following was added in 'lib/src/launch_at_startup.dart' for WindowsMsix support
if (packageName != null && isRunningInMsix(packageName)) {         _appAutoLauncher = AppAutoLauncherImplWindowsMsix(           appName: appName,           appPath: appPath,           packageName: packageName,           args: args,         );         return;       }
and it's importing 'app_auto_launcher_impl_windows_noop.dart' when as web because of this
import 'package:launch_at_startup/src/app_auto_launcher_impl_windows.dart'     if (dart.library.html) 'app_auto_launcher_impl_windows_noop.dart';
so try stubbing the class and function in 'app_auto_launcher_impl_windows_noop.dart' with this
`class AppAutoLauncherImplWindowsMsix extends AppAutoLauncherImplNoop {
AppAutoLauncherImplWindowsMsix({
required String appName,
required String appPath,
required String packageName,
List args = const [],
});
}
bool isRunningInMsix(String packageName) => false;`

Fixed on v0.3.1


Export single page plot as PDF but get multiple pages output

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.
If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.
Describe the bug
Export a single page pdf with a wide plot but get the image with seperate page. I expect to have a single page.
Each page contains part of plot.
It only happens on export PDF, working fine in export to PNG JPEG, also working fine in draw.io Desktop with Mac.
To Reproduce
Steps to reproduce the behavior:

Go to 'File', 'Export as' 'pdf'

Expected behavior
expect to have a single page.
Screenshots
If applicable, add screenshots to help explain your problem.

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version 24.1.0

Desktop (please complete the following information):

OS: Mac
Browser Chrome/ Safari 125.0.1

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

yes

Additional context
Add any other context about the problem here.

Try v24.3.0 via https://clear.diagrams.net

Thanks @alderg


Add support for constant conditional token and clean up imports

Purpose

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] Check logging
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added, or removed?
[ ] Are there new interface dependencies?
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

The commit for the actual work ended up on the other pull request.

GH gets weird with multiple PRs to/from the same branches


Figure out what to do about Mac OS CI Failures

When running the Mac OS CI, sometimes we get no adapters when creating a virtual device. I don't want to fully disable CI for Mac, but I also don't want to have the mac builds causing errors when we're unable to get an adapter.
The default wgpu adapter request options are provided, which from what I can tell, are the most compatible options to specify.
Perhaps a preflight tool can check specifically that an adapter can be requested, and the Mac builds can run that tool to set a flag that disables unit tests that need an adapter?

For now I've made the examples support a NO_ADAPTER env variable to allow gracefully failing. If it's non-empty, a warning will be emitted when VirtualRecorderError::NoAdapter is returned. We may want to move this into the crate so that we can use the same logic in unit tests built around the VirtualRecorder.
When CI runs on Mac, it passes in github-ci which causes the warnings to be formatted such that they appear the CI run summary, e.g: https://github.com/khonsulabs/cushy/actions/runs/7451157650
Comically, as I was to be able to paste a job that ignored a NoAdapter error, I was thinking to myself, "I haven't seen the Mac CI job succeed recently, I wonder if it's actually broken." The job I was watching succeeded without a NoAdapter error being raised :laughing: I had to retry it to get the example warning to show up.


Set up necessary script tags for Firebase and Firestore

The changes occur to the old index.html file before separate html files were created for different data sets. queryValue has an extra "feature" parameter that must match column name exactly from csv. readCSV function takes in raw string version of csv contents and eventually imports them to Firestore database.

The changes occur to the old index.html file before separate html files were created for different data sets. queryValue has an extra "feature" parameter that must match column name exactly from csv. readCSV function takes in raw string version of csv contents and eventually imports them to Firestore database.


Windows does not have umask

Merged into https://github.com/StackExchange/blackbox/pull/319 - thanks, @tlimoncelli!


Safari used for Live Preview instead of Chrome browser on Mac OSX 10.11.6

Prerequisites

[ x ] Can you reproduce the problem with Debug -> Reload Without Extensions?
[ x ] Did you perform a cursory search to see if your bug or enhancement is already reported?
[ x ] Did you read the Troubleshooting guide?

For more information on how to write a good bug report read here
For more information on how to contribute read here
Description
Safari is being used for Live Preview instead of Chrome browser on Mac OSX 10.11.6 in latest version of Brackets on two different Macs. Starting Chrome beforehand does still invoke Safari.
[Description of the bug or feature]
Steps to Reproduce

[Start Brackets]
[Open html document]
[click Arrow icon for Live Preview]

Expected behavior: [Chrome Browser should have started up]
Actual behavior: [Safari Browser starts up]
Versions
Please include the OS and what version of the OS you're running.
–> 10.11.6
Please include the version of Brackets. You can find it under Help -> About Brackets (Windows and Linux) or Brackets -> About Brackets (macOS)
–> Release 1.12 Build 1.12.0-17621 (release d3b783b99)

@oligraph Check whether File-> Enable Experimental Live Preview is enabled. If this option is enabled and your default browser is Safari, then preview will get launched in Safari only.

Thank you, sobisht,
your hint did the trick. But only after a restart of the Mac, not only Brackets.


⚠ Site ANTS has degraded performance

In 0c6ee5d, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 6953 ms

Resolved: Site ANTS performance has improved in a178f5f.


Expose thermostat into light platform

Description:
Related issue (if applicable): fixes #14526

Hi @rweglarz,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

This makes absolute no sense. Don't put thermostats as lights.

This makes absolute no sense. Don't put thermostats as lights.

Hi Paulus,
could you please provide some guidance what would be the proper way to fix issue #14526?
thanks
Rafal

Why a light. That only adds to the confusion. A simple generic sensor works just as well

@DamianFlynn It's a light (or cover in newer version of @rweglarz code) because they also want to control the value, not only read it. In manufacturer specific mode/preset of the TRV this value can be used to directly control valve opening percentage.
I don't see any suitable entity type in Home Assistant for this right now. For example in Google Assistant Smart Home reference docs it's Valve device type with OpenClose trait (that also allows setting of exact position). See https://developers.google.com/assistant/smarthome/guides/valve.html.


CaSe MaTtErs

So when copying and pasting code try to remember that phoneword != Phoneword.  There are tools to help you with this simple mistake, I can't remember what they are but in step 3 hit that shift key will ya.
Code CS0103: The name CS0103'InitializeComponent' does not exist in the current context

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2de3e72c-8948-4dd5-e37f-9cf81e62c127
Version Independent ID: 7b7c5c7f-4102-8e91-fbe6-7d21fcc8f5be
Content: Xamarin.Forms Quickstart - Xamarin
Content Source: docs/xamarin-forms/get-started/hello-xamarin-forms/quickstart.md
Service: unspecified
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @brokenjavagit, can you help me out with exactly what in the doc lead you astray? I don't see any lowercase phoneword in there. Thanks!

Nothing in this document led me astray.    But the generic error: "Code CS0103: The name CS0103'InitializeComponent' does not exist in the current context" was confusing and not particularly helpful.  Searching on the internet for a solution to this error was also not helpful, everything i looked at pointed to, or accused the Xamarin dev team or Xamarin itself of being unreliable/broken/bug riden.  Perhaps this will be helpful to someone else with this specific issue.

Understood, thanks for the additional information.
You can provide product feedback at the Developer Community site - including requesting and voting on new features.


Make StringValue's memory layout same with Slice

In our storage engine's code, we cast StringValue to Slice. Because
their memory layout is not differenct, it may cause BE process crash.
We make their memory layout same in this patch to resolve this problem
temporary. We should improve it some day.

Fix https://github.com/apache/incubator-doris/issues/1706
+1 LGTM


License?

Hi, thanks for this awesome project. I'm considering to use RubyGo's lexer and parser for one of my projects and I couldn't find a license file which shows the license details.

I was about to fork to maybe contribute some improvements to the documentation, but don't see a license.  I won't contribute without a license I like, so I'll just move on.  You might want to fix this for others, though.

Hey, I am sorry for coming back so late. License wise I am always not sure what to take, but for another project I chose the MIT license as it also allows commercial use.
I'd appreciate a comment or reaction on this PR which proposes the new licence.


Soomla plus Unity 5.4 don't read storage from oldest Unity versions.

Hello.
I updated Unity to version 5.4. And soomla can't read data from localstorage, that has been recorded in Unity 5.3.x. What happened? I use only soomla core and KeyValueStorage class for save and load data.
I didn't change secret key, didin't update soomla, nothing. Only updated unity. Pls help.
add:
And pls resolve unity 5.4 console warrings and errors. Thx

Problem is solved. If KeyValueStorage is created before SOOMLA initialization, there will be used a default SOOMLA_SEC. SOOMLA_SEC isn't null or String.Empty, so Keeva won't drop exeption in constructor. Project went into release with no error warnings appeared. There need to add a correct check to the secret.


Tilting pad

Tilting pad bearing code.

Hi there!
I have marked this issue as stale because it has not had activity for 45 days.
Consider the following options:

If the issue refers to a large task, break it in smaller issues that can be solved in
less than 45 days;
Label the issue as wontfix or wontfix for now and close it.


Issue 1182 faster tagging for PyBaMM citations

Description
Enables a faster method to tag citations based on where they come up in the code during a simulation (models, solvers, etc.) – via a caller_name method that calls sys._getframe() to access current frames for the pybamm.citations.register() function.
This PR continues the discussion on #2862 and #2908, with some results of the speedup available at https://github.com/pybamm-team/PyBaMM/issues/2908#issuecomment-1537077212. Here, sys._getframe is preferred to inspect._getframe() for avoiding the internal hasattr(), in order to reduce any potential performance impact(s) of attribute checks at runtime.
Fixes #1182
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python run-tests.py --all
[x] The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

@tinosulzer this is a discussion of somewhat different scope, so I am commenting here instead of on the previous thread – I notice that the pybamm.citations.register() function is calling itself recursively when it tries to parse the citation with pybtex and add it to the _all_citations dictionary. This adds to the overhead if a particular model (or solver) registers multiple citations, either explicitly or through its base class due to the use of super().__init__. In the earlier profiling results on #2908, it looks like getting the current frame with _caller_name() amounts to only a fraction of the total time for register() (which just becomes _caller_name() + parsing the citations with pybtex) – about 30-50% without caching and around 10% if functools @cache is used with it (if I am thinking about this correctly – I guess this will require some more profiling, with a larger experiment perhaps).
We can move the citation parsing functionality to a new, separate function that only gets called inside print_citations(), and keep only the tagging (that cannot be moved outside register() since getting the current frame will depend on initialising a model or solver with register() at runtime). This way, registering citations would affect performance slightly lesser when solving a model, which is a critical feature. On the other hand, the print_citations function will compensate for it and get slightly slower, which should be fine. I am happy to make these changes in this PR itself after further discussion

New profiling results: now _caller_name() takes more time within register() since parsing the citation with pybtex has been moved to a separate function parse_citation(), which gets called inside print_citations() instead
# For the SPM model
%load_ext snakeviz
model = pybamm.lithium_ion.SPM()
sim = pybamm.Simulation(model)
%snakeviz sim.solve([0, 3600])

Solving for the first time

and solving for the second time (most things get cached)

I am unsure why the ncalls are the same here as the previous https://github.com/pybamm-team/PyBaMM/issues/2908#issuecomment-1550213890 though. I am looking for ways to cache _caller_name() at the moment, we should not use @lru_cache on functions though, so something else must be needed to make this faster.

Linking the citation tags hardcoded to their respective models or solvers remains the fastest solution because 1. It does not need to be executed at runtime, and 2. read/write operations to dictionaries or lists within the same file should be very fast
The only disadvantage this has is that it is neither programmatic nor Pythonic

Lol the solution to not calling _caller_name() was so obvious, but it didn't strike me until now. Just a try-except block to not call it if a citation tag already exists 😆
Newer profiling results are much better (the above + parsing registered citations only when printing them):
DFN

# For the DFN model
%load_ext snakeviz
model = pybamm.lithium_ion.DFN()
sim = pybamm.Simulation(model)
%snakeviz sim.solve([0, 3600])
%snakeviz sim.solve([0, 3600])

sim.solve([0, 3600]) first iteration

sim.solve([0, 3600]) second iteration

Impact on the DFN model is negligible and it was not impacted in earlier results either, so testing SPM is more important

SPM

# For the SPM model
%load_ext snakeviz
model = pybamm.lithium_ion.SPM()
sim = pybamm.Simulation(model)
%snakeviz sim.solve([0, 3600])
%snakeviz sim.solve([0, 3600])

sim.solve([0, 3600]) first iteration

sim.solve([0, 3600]) second iteration

i.e., never going past ~0.5-0.6% performance impact on any further iterations, was tested by repeating the same code 10 times.

Do these look good?


Archetype builder cleanups

Several cleanups for ArchetypeBuilder and its interaction with the rest of the frontend, including:

Eliminating ArchetypeBuilder::substDependentType; clients should use GenericEnvironment::mapTypeIntoContext instead
Introduced a "canonical" generic environment corresponding to a given (canonical) generic signature, which is used by IRGen now instead of conjuring up a new ArchetypeBuilder
Simplified the API to ArchetypeBuilder and PotentialArchetype slightly.
Start going down the road to lazily-created archetypes. There is still a ton of refactoring to do here.

@swift-ci please smoke test and merge


Prevent log save failure to break API call

Hi,
This is a follow-up of the discussion in PR #55.
If something is going wrong during log saving, we don't want the API to fail and throw out an error to the end user.
To do this, silently swallow any exception throwed by save().
A test is provided to check that the response status_code of the API is still 200 even in the event of a DB failure.
Best regards!

@frankie567 Thanks for adding this try catch! This change along with reducing the save calls to the DB should give a good overall improvement.


SignalR Client Features doc -> SignalR Clients overview doc

In reviewing https://github.com/dotnet/aspnetcore/issues/21618 and other issues about compatibility and versioning I figured this doc could use a quick update. Here's a first stab at it. I'm going to check the TOCs shortly and look at the internal review site, since I changed some titles.

Internal Review Link
TOC update preview:

@anurse Looks good. Merge when you're ready. Consider that contraction a parting gift for you. 😄

and while we're at it, I have to get one last lonely man usage in there.
https://www.youtube.com/watch?v=k_lYcTxncNg

😭😭😭😭😭😭😭


There are no "RESOURCES" and "WORKSPACE" labels in the AZURE view

Environment: VSCode.dev
Regression: Not a regression
Repro Steps:

Install the Resource Group extension.
Navigate to AZURE view.
Check the AZURE view.

Expect:
There are "RESOURCES" and "WORKSPACE" labels in the AZURE view.

Actual:
There are no "RESOURCES" and "WORKSPACE" labels in the AZURE view.

Fixed by https://github.com/microsoft/vscode-azureresourcegroups/pull/607

@nturinski  This issue still reproduces on Resource Groups extension testing for vscode.dev, reopen it.


Resolve path in sendFile

Currently only res.download resolves full file path and passes it to sendFile method. This commit moves the resolve function to the sendFile, allowing sending non-attachment files without providing full file path too.

The restriction to require passing in the full path is a security fix. This is why the older APIs are deprecated.


Vibrant Capacitors losing "VIBRANT" thus making them worse

What happens:
When crafting vibrant capacitor banks there is a chance to get normal capacitor. Basically you just get a vibrant capacitor but without the NBT Tag type tag "VIBRANT", insteasd it has "ACTIVATED". Another thing is that inventory renders that it has correct maximum value but when you place, it then shows ACTIVATED values.
What you expected to happen:
You're supposed to get it with type "VIBRANT" so it would read the correct rf value.
I was guessing that it could be related to minetweaker recipes, but it's not 100% that you get wrong type so I am not certain.

Affected Versions (Do not use "latest"):

EnderIO: EnderIO-1.7.10-<IP_ADDRESS>9_beta
EnderCore: EnderCore-1.7.10-<IP_ADDRESS>_beta
Minecraft: 1.7.10
Forge:

Your most recent log file where the issue was present:
Here is the log but I checked it and it doesn't show anything. Same with server side log.
http://pastebin.com/raw/j1a6E1bn
Also when doing /mt hand

[13:01:36] [Client thread/INFO]: [CHAT] EnderIO:blockCapBank:3.withTag({hasFaces: 1 as byte, face5: 4 as short, hasDisplayTypes: 1 as byte, faceDisplay2: 1 as short, face0: 1 as short, type: "ACTIVATED", storedEnergyRF: 750000, face4: 4 as short, faceDisplay5: 2 as short})
[13:03:02] [Client thread/INFO]: [CHAT] EnderIO:blockCapBank:3.withTag({hasFaces: 1 as byte, face5: 4 as short, hasDisplayTypes: 1 as byte, faceDisplay2: 1 as short, face0: 1 as short, type: "VIBRANT", storedEnergyRF: 500000000, face4: 1 as short, faceDisplay5: 2 as short})

Both are vibrant (blockCapBank:3), but one has VIBRANT tag, other has ACTIVATED.

Did you use a vanilla crafting table or a modded one? And did you take the crafted item out or shift clicked it out?

QED and no shift clicking.

Then try to reproduce it with a vanilla crafting table.

It's a while since I looked at 1.7.10 recipes, but if I'm not completely mistaken then a freshly crafted capBank should have no NBT values at all. Those come from breaking a capBank after it has been placed down in the world.


aft-account-request-action-trigger should check for tained SC provisioned product

Terraform Version & Prov:
n/a
AFT Version:
1.6.2
Bug Description
When trying to import an existing AWS account to AFT, one might stumble upon issue where the relevant AWS Service Catalog (SC) provisioned product (AWS Control Tower Factory product) for the particular account was tainted.
While the reason that SC provisioned product for the account factory was tainted is beyond the scope of AFT responsibility, however, the error message provided by AFT is not accurate.
In specific, aft-account-request-processor reported that the email address already in use, hinting that AFT is trying to create a new account instead of importing existing account.
{
    "time_stamp": "2023-03-22 00:54:49,426",
    "log_level": "ERROR",
    "log_message": "Account Email: REDACTED already used in Organizations"
}

The actual issue happened upstream at aft-account-request-action-trigger when it tries to check for existing provisioned product. The function provisioned_product_exists only checks for health provisioned product. The lambda log provides INFO level messages as such:
{
    "time_stamp": "2023-03-22 00:50:18,102",
    "log_level": "INFO",
    "log_message": "Did not find account with matching email in healthy status in Account Factory"
}

This small hint can be easily missed during troubleshooting and should be refined by throwing error when the same email address is found on batch of un-healthy provisioned product.
To Reproduce
Steps to reproduce the behavior:

Find an existing CT managed account where the provisioned product in Service Catalog is unhealthy
Import the account to AFT
Inspect both aft-account-request-action-trigger and aft-account-request-processor

Expected behavior
I believe AFT should prevent any attempt to import account if the underlying SC provisioned product is unhealthy. However, AFT should provide better error message to assist user to identify the problem.
AFT should also check for un-healthy provisioned product and provide warning if the same email address is currently in-use.
Related Logs
See above
Additional context
n/a

I think ver 1.7.x or higher solved this problem. I failed to notice that aft_sc_product_allowed_status includes  "AVAILABLE" and "TAINTED" product.
https://github.com/aws-ia/terraform-aws-control_tower_account_factory/blob/1.9.2/sources/aft-lambda-layer/aft_common/account_request_framework.py#L62-L67


indev/libinput: rescan_devices: fix malloc

Fix missing space in malloc for path for \0 at the end of the string.
The 11 bytes at the beginning are for "/dev/input/".
(Found with valgrind)

Thanks!
To save the next reader from repeating the counting, what do you think about adding a comment /* 11 characters for /dev/input/ + length of name + 1 NUL terminator */ above this line?

Good idea, done.

Merged!