Incorrect Bitcoin Address From Script, maybe?

Taking the following testnet transaction:
020000000001020fd2daf6c3ebdb7aa61f8fd3b2de5bd218a0c5d7c7c6a0f9e9925a37e7eda7750100000017160014ab5281cb81cc9ff4774437bc0483043ec2123a10feffffffaaa089de7c855eea262f4e4a5da24da8105247483339443c99569a677750923f01000000171600144a1956bfd3d6b4e35a3408b1d10d6939c827fb20feffffff02f00d0c000000000017a9144ef1a2ce7d672f078354cd8a28774eb57894fb1d87b6630f000000000017a914336d82d805e393216ddcc2e6bbee622bf9679381870247304402200c7eb686d40ec0d72bcc8dc8ae4873e11f4a34b6d212ee453c14ae655de9059d02201198a694c703475234fe15edb8ef1132ec62f6821eb0b2ade18b70d4260363b3012103d63b75f870479470c6fbaa5825614a5880dc6024c4986bae660ff7edf8e4679f0247304402205204c437933cb53cb44a284e67fb9a34bc92aa018026b680bf434f4df91f5646022038f2c3ba7d43f86bbd701f5f47e44814cfd721ee0276256f57c2bf9209d245cb012102367a50f93b50a06b66522710ca98e3c461d561fd9869f7f583faaeec7aae7da100000000
The two outputs contain the following addresses:
0:2MzSeAQc3xrTeSXKieAbRWWXU84wfdg6W1z
1:2Mww9e2qhPAV358pCSZSyZocqwZkn2KiV1C
Converting the transaction as such:
// Decode the Bitcoin transaction
fn txdecode() {

    // Assuming that the variable 'transaction' is the bitcoin transaction above,
    let ctx = hex_bytes(transaction).unwrap_or_default();
    let tx: Result<Transaction, Error> = deserialize(&ctx);

    if tx.is_ok() {
        let ok_tx = tx.unwrap();
        println!("[{}]", ok_tx.txid());

        let outputs = Instant::now();
        // list the outputs
        let txouts = ok_tx.output.clone();
        for out in txouts.iter() {
            checkscripttype(&out.script_pubkey);
            println!("\tValue: {}", out.value);
        }

    // println!("{}\n{:#?}", ok_tx.txid().be_hex_string(), ok_tx);
    } else {
        println!("{:?}", tx.unwrap_err());
        println!("Couldn't decode transaction data, maybe it's bad?")
    }
}

// checks what kind of a script this output is
fn checkscripttype(scr: &bitcoin::blockdata::script::Script) {
    println!("\n\n");

    if scr.is_p2sh() {
        let p2sh = bitcoin::Address::p2sh(scr, Testnet);
        println!("\tIs Pay 2 Script Hash {}", p2sh);
    }
    if scr.is_p2pkh() {
        // println!("\tIs Pay 2 Public Key Hash {}", scr);
        // let p2pkh = bitcoin::Address::p2pkh(scr, Testnet);
        let pubkey = &scr[1..24];
        println!("\tNo idea yet. is_p2pkh {:?}", pubkey);
    }
    if scr.is_p2pk() {
        // println!("\tIs Pay 2 Public Key {}", scr);
        // let p2pk = bitcoin::Address::p2pk(scr, Testnet);
        println!("\tNo idea yet. is_p2pk")
    }
    if scr.is_v0_p2wsh() {
        let p2wsh = bitcoin::Address::p2wsh(scr, Testnet);
        println!("\tIs Pay 2 Witness Script Hash {}", p2wsh);
    }
    if scr.is_v0_p2wpkh() {
        // println!("\tIs Pay 2 Witness Public Key Hash {}", scr);
        // let v0_p2wpkh = bitcoin::Address::v0_p2wpkh(scr, Testnet);
        println!("\tNo idea yet. is_v0_p2wpkh")
    }
    if scr.is_op_return() {
        // println!("\tIs Op Return {}", scr);
        // let op_return = bitcoin::Address::op_return(scr, Testnet);
        println!("\tNo idea yet. is_op_return")
    }
    if scr.is_provably_unspendable() {
        // println!("\tIs Provably Unspendable {}", scr);
        // let provably_unspendable = bitcoin::Address::provably_unspendable(scr, Testnet);
        println!("\tNo idea yet. is_provably_unspendable")
    }

    println!("\n\t\tis p2sh: {:?}", scr.is_p2sh());
    println!("\t\tis p2pkh: {:?}", scr.is_p2pkh());
    println!("\t\tis p2pk: {:?}", scr.is_p2pk());
    println!("\t\tis v0_p2wsh: {:?}", scr.is_v0_p2wsh());
    println!("\t\tis v0_p2wpkh: {:?}", scr.is_v0_p2wpkh());
    println!("\t\tis op_return: {:?}", scr.is_op_return());
    println!(
        "\t\tis provably_unspendable: {:?}\n",
        scr.is_provably_unspendable()
    );
}

produces:

[99897dbe4cb3c343e785f9bafeda2cde4c85be69d7c5431224140495249be56c]

        Is Pay 2 Script Hash 2Myn8QKJb9fNBcB94NL3cdSoYnX3MGxpiSz

                is p2sh: true
                is p2pkh: false
                is p2pk: false
                is v0_p2wsh: false
                is v0_p2wpkh: false
                is op_return: false
                is provably_unspendable: false

        Value: 790000

        Is Pay 2 Script Hash 2NAg2fVPQfmYSe2ATWnM1BaED8yEdfkCsLA

                is p2sh: true
                is p2pkh: false
                is p2pk: false
                is v0_p2wsh: false
                is v0_p2wpkh: false
                is op_return: false
                is provably_unspendable: false

        Value: 1008566

As you can see, the result doesn't produce the same addresses as presented here: https://tbtc.bitaps.com/99897dbe4cb3c343e785f9bafeda2cde4c85be69d7c5431224140495249be56c and decoding the tx here: https://live.blockcypher.com/btc-testnet/decodetx/.
Am I doing something wrong?

Which version of the library are you using? I tried to decode the transaction using hal which uses this library and it outputs the expected addresses:
  "outputs": [
    {
      "value": 790000,
      "script_pub_key": {
        "hex": "a9144ef1a2ce7d672f078354cd8a28774eb57894fb1d87",
        "asm": "OP_HASH160 OP_PUSHBYTES_20 4ef1a2ce7d672f078354cd8a28774eb57894fb1d OP_EQUAL",
        "type": "p2sh",
        "address": "2MzSeAQc3xrTeSXKieAbRWWXU84wfdg6W1z"
      }
    },
    {
      "value": 1008566,
      "script_pub_key": {
        "hex": "a914336d82d805e393216ddcc2e6bbee622bf967938187",
        "asm": "OP_HASH160 OP_PUSHBYTES_20 336d82d805e393216ddcc2e6bbee622bf9679381 OP_EQUAL",
        "type": "p2sh",
        "address": "2Mww9e2qhPAV358pCSZSyZocqwZkn2KiV1C"
      }
    }
  ]

Can you post the code with the appropriate uses or a minimal example demonstrating the malfunction please?

Here is the code I'm using that reproduces the problem:
https://gist.github.com/kyluke/681f21eb2b681ac7ac64ff223e326c1a
However, building in hal's address_from_script has produced the correct result.
Perhaps the trick is [2..22]

That's definitely a documentation issue: the function you are using expects the inner script (the one of which the hash for the outer p2sh script can be derived).  That should be documented way better.
Hal is doing it right by extracting the hash from the outer script. Unfortunately there doesn't seem to be a simpler way to do it, but script descriptors might help. See also #27.

Yeah I figured that out now after looking through his code. This should be in the comment or something. Perhaps his function could be included in some way.


[lab] Move @date-io adapters to peer dependencies

Prevents installing of all date libraries (date-fns, moment etc).
Closes https://github.com/mui-org/material-ui/issues/23597
This works because the adapters (e.g @material-ui/lab/AdapterLuxon) are not part of the entry point of @material-ui/lab so you'll never evaluate the adapters unless you specifically import them. If they were part of the entry point, they'd not be considered optional dependencies.

Didn't realize that the @date-io/* adapters don't have a direct but peer dependency on their respective date library. We don't need this change since this would require installing another library.


Please update 1.20.x

Please update this plugin i need this

please update to 1.20.x
thanks a lot


Adding all the types so it's clearer to understand what types are sup…

…ported
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:

[ ] Write/update tests
[ ] make pr passes
[ ] Update documentation
[ ] Verify transformed template deploys and application functions as expected
[ ] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #996 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   94.62%   94.62%
=======================================
  Files          69       69
  Lines        2997     2997
  Branches      554      554
=======================================
  Hits         2836     2836
  Misses         85       85
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a3c51...fcd9759. Read the comment docs.

Also, could you rebase against the latest develop branch? You made your change against master, but new PRs get merged into develop. Thanks!


az network private-endpoint list-types fails due to invalid resource type error

az network private-endpoint list-types fails due to invalid resource type error
This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az network private-endpoint list-types
Errors:
(InvalidResourceType) The resource type 'locations' could not be found in the namespace 'Microsoft.Network' for api version '2020-07-01'. The supported api-versions are '2014-12-01-preview,2015-05-01-preview,2015-06-15,2016-03-30,2016-06-01,2016-07-01,2016-08-01,2016-09-01,2016-10-01,2016-11-01,2016-12-01,2017-03-01,2017-04-01,2017-06-01,2017-08-01,2017-09-01,2017-10-01,2017-11-01,2018-01-01,2018-02-01,2018-03-01,2018-04-01,2018-05-01,2018-06-01,2018-07-01,2018-08-01,2018-10-01,2018-11-01,2018-12-01,2019-02-01'.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az network private-endpoint list-types --location westus2

Expected Behavior
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.6.8
Installer: MSI

azure-cli 2.19.1

Extensions:
alias 0.5.2
interactive 0.4.4

Additional Context

network

I have a try and it could work. My azure-cli version is 2.20.0

Please upgrade you cli version by command
az upgrade


Having two shared libs is breaking downstream clients...

With version 1.0.66 people with custom ROMs are reporting crashes. This tends to happen whenever we change the ABI of the native library, because the custom ROM's version of the library takes precedence over the version in the app.
The work-around is to change the name of the native library whenever we change the ABI.
I didn't think we changed the ABI, but enough crash reports are coming in that it's beginning to look like we did. (It never hurts to change the library name, we might want to change it every release anyway, just to avoid any possible problem. :-) )

Here's the failure that one user is seeing.
D/AndroidRuntime(31616): Shutting down VM
E/AndroidRuntime(31616): FATAL EXCEPTION: main
E/AndroidRuntime(31616): Process: jackpal.androidterm, PID: 31616
E/AndroidRuntime(31616): java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/system/app/TerminalEmulator/TerminalEmulator.apk"],nativeLibraryDirectories=[/vendor/lib, /system/lib]]] couldn't find "libjackpal-termexec.so"
E/AndroidRuntime(31616): 	at java.lang.Runtime.loadLibrary(Runtime.java:366)
E/AndroidRuntime(31616): 	at java.lang.System.loadLibrary(System.java:988)
E/AndroidRuntime(31616): 	at jackpal.androidterm.TermExec.(TermExec.java:23)
E/AndroidRuntime(31616): 	at jackpal.androidterm.ShellTermSession.createSubprocess(ShellTermSession.java:153)
E/AndroidRuntime(31616): 	at jackpal.androidterm.ShellTermSession.initializeSession(ShellTermSession.java:101)
E/AndroidRuntime(31616): 	at jackpal.androidterm.ShellTermSession.(ShellTermSession.java:57)
E/AndroidRuntime(31616): 	at jackpal.androidterm.Term.createTermSession(Term.java:502)
E/AndroidRuntime(31616): 	at jackpal.androidterm.Term.createTermSession(Term.java:511)
E/AndroidRuntime(31616): 	at jackpal.androidterm.Term.populateViewFlipper(Term.java:418)
E/AndroidRuntime(31616): 	at jackpal.androidterm.Term.access$400(Term.java:82)
E/AndroidRuntime(31616): 	at jackpal.androidterm.Term$2.onServiceConnected(Term.java:152)
E/AndroidRuntime(31616): 	at android.app.LoadedApk$ServiceDispatcher.doConnected(LoadedApk.java:1208)
E/AndroidRuntime(31616): 	at android.app.LoadedApk$ServiceDispatcher$RunConnection.run(LoadedApk.java:1225)
E/AndroidRuntime(31616): 	at android.os.Handler.handleCallback(Handler.java:739)
E/AndroidRuntime(31616): 	at android.os.Handler.dispatchMessage(Handler.java:95)
E/AndroidRuntime(31616): 	at android.os.Looper.loop(Looper.java:135)
E/AndroidRuntime(31616): 	at android.app.ActivityThread.main(ActivityThread.java:5256)
E/AndroidRuntime(31616): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(31616): 	at java.lang.reflect.Method.invoke(Method.java:372)
E/AndroidRuntime(31616): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
E/AndroidRuntime(31616): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
W/ActivityManager(  475):   Force finishing activity 1 jackpal.androidterm/.Term

Aha -- this is not our normal Play Store term.apk, it's some version built into a ROM.

In ticket #401, I use CyanogenMod 11 and I updated to v.1.0.66 via Google Play and received the error when trying to launch the app. There is a conflict with the updated Google Play Store app and the Term.apk installed as a system app in CM 11. I believe trying to launch the app after the update invokes the ROM to look for the missing libjackpal-termexec.so library in /system/lib.
I peeled out the Term.apk from /system/app, rebooted, and installed the Google Play App standalone. Since the app installed in user space /data, all worked well referencing the new libraries.
From this point I wanted to reinstall TEA as a system app again, as the ROM had it baked in before. I copied the new libraries "libjackpal-androidterm4.so" & "libjackpal-termexec.so" from /data/data/jackpal.androidterm/lib to /system/lib and reinstalled the Term.apk to /system/app and all is well once again!
Thanks, Jack!

Yeah, I just reproduced this by installing Cyanogenmod on one my phones. I think the problem is that TEA now has two native libraries: libjackpal-androidterm4.so" & "libjackpal-termexec.so". CyanogenMOD needs to update its installer to install both libraries.

Submitted in CyanogenMod bug tracker: https://jira.cyanogenmod.org/browse/CYAN-6465

Thanks!

Matthew, I've just submitted version 1.0.67 to the Play Store, which has yet another new set of library names. They are:
libjackpal-androidterm5.so
libjackpal-termexec2.so
So CyanogenMOD 11 will have to update again when it pulls in that version of TEA.
Hopefully that will be the last change to these libraries for a while.

(I'll leave this bug open for a few days until CynaogenMOD 11 is updated to the v1.0.67 library names.)

Jack, Can I get these libraries on GitHub so I can drop them in my /system/lib folder?
Also, are the previous termexec and androidterm4 libraries necessary with the new libraries?
I'll be sure to update the CyanogenMod ticket as well.

The latest version of the app on github, v1.0.67. does have the new libraries. (As does the new version in the store.)
You do not need to have any other versions of termexec or androidterm4

Ok, please forgive my noobishness.
The app force close previously was a result of the libraries not upgrading in /system/lib when I updated to 1.0.66 through the play store. I had to remove the apk from /system/app and do a clean install of the Play Store app into user data space, copy the libraries from /data/app-lib into /system/lib, uninstall, then put the apk back into /system/app.
I guess having the libraries at hand would save me the step removing the system app and installing the app into /data. I would just drop Tue libraries into /system/lib and upgrade through play store. No uninstalling and reinstalling to get libs. :D


"Backend Error" when setting file ACL

Trying to set ACL after uploading and consistently getting a "Backend Error" when trying to set ACL. File uploads fine each time.
var image = myBucket.file('foo.jpg');
var imageWriteStream = image.createWriteStream({ contentType: 'image/jpeg' });

imageWriteStream.on('complete', function() {
  // Set ACL
  image.acl.add({
    scope: 'allUsers',
    role:  gcloud.storage.acl.READER_ROLE
  }, function(err) {
    // FAILING HERE
    console.log(err);
  });
});

my Stream.pipe(imageWriteStream);

Thanks for reporting, I'll check it out!
Just confirming, are you on gcloud version 0.18?

Sorry about that. No, I'm on v0.15.0. The version installed through NPM. Is there an ETA of when v0.18 will be in NPM?

It's actually out now. What value do you have in your package.json?

My bad. I must have previously installed it so it was stuck on v0.15. I updated and the problem persists.

Is the messaging still Backend error? We actually changed how errors are patched from the API - maybe it's more helpful this time around. At the very least, it should be "Error during request".

Error: Backend Error
    at Object.parseApiResp (/Users/kirk/Projects/slashpath/src/node_modules/gcloud/lib/common/util.js:184:22)
    at Object.handleResp (/Users/kirk/Projects/slashpath/src/node_modules/gcloud/lib/common/util.js:139:25)
    at /Users/kirk/Projects/slashpath/src/node_modules/gcloud/lib/common/util.js:572:12
    at Request.onResponse [as _callback] (/Users/kirk/Projects/slashpath/src/node_modules/gcloud/node_modules/retry-request/index.js:107:7)
    at Request.self.callback (/Users/kirk/Projects/slashpath/src/node_modules/gcloud/node_modules/request/request.js:198:22)
    at Request.emit (events.js:110:17)
    at Request.<anonymous> (/Users/kirk/Projects/slashpath/src/node_modules/gcloud/node_modules/request/request.js:1057:14)
    at Request.emit (events.js:129:20)
    at IncomingMessage.<anonymous> (/Users/kirk/Projects/slashpath/src/node_modules/gcloud/node_modules/request/request.js:1003:12)
    at IncomingMessage.emit (events.js:129:20)
    at _stream_readable.js:908:16
    at process._tickCallback (node.js:355:11)

Oops, I just noticed we have incorrect docs. The parameter to use is actually entity instead of scope. Not sure that will be the fix here, but let's hope :crossed_flags:

Hey, that was it, thanks!


[BUG]Latest Master ISO no longer prompt for password reset on first login

Describe the bug
Using the latest harvester iso https://releases.rancher.com/harvester/master/harvester-amd64.iso , the harvester UI no longer prompts for password reset on first login. Using username admin and password admin enables you to login.
To Reproduce
Steps to reproduce the behavior:

Bring up harvester using latest ISO https://releases.rancher.com/harvester/master/harvester-amd64.iso
Try to login to harvester UI

Expected behavior
The first login should ask for password reset
Support bundle

Environment:

Harvester ISO version: https://releases.rancher.com/harvester/master/harvester-amd64.iso
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):ipxe vagrant env

Additional context
Add any other context about the problem here.

After we disable MCM in the embedded rancher, the API /v3/settings/first-login now returns 404. We need to call /v1/management.cattle.io.setting/first-login instead to check whether it's the first time login.

I saw that we are not able to change the password of the default admin user, as well as not able to create a new user with this admin account: is it a side effect of this issue or a new one? If it's a new one I will create a new issue for it, I just want to be sure ;-)

this is by design in 0.3, we will not promote mult-user management in the single Harvester cluster view, multi-tenant, auth providers, and RBAC will only be supported in the multi-cluster view for now.

@chajain Can you help to check if the password reset prompt works in the master?

Verfied, Looks good now.


Full Screen Control

Is your feature request related to a problem? Please describe
It is the improvement in apps full screen feature
Describe the solution you'd like
I like this way of controlling full screen apps
https://github.com/microsoft/WSA/assets/105973744/c1eb9ae7-1837-47e4-a6a5-a2b92c1eb04d
Describe alternatives you've considered
No response
Please specify the version of Windows Subsystem for Android
2306.40000.4

Please file end-user feature requests via Windows feedback hub (Windows key + F) under category Apps > Windows Subsystem for Android. This forum is intended to address Android app developer feedback.


Arguments in nested fields trigger an error

Hi, when I use an argument in my query in nested fields like this:
query ($size: Int) {
  connections(first: 0) {
    pageInfo {
      totalEdges
      cursors (size: $size)
    }
}

I got this error:
Error: Call to a member function getType() on null
at vendor\youshido\graphql\src\Execution\Processor.php:499

Is it allowed? I use the YoushidoBundle with Symfony, and the error occurs when parsing the arguments at the beginning of doResolve: $arguments = $this->parseArgumentsValues($field, $ast);

@Schunk thanks for reporting the issue, will get it resolved this weekend, although it seems like it was already fixed


🐞 [Bug]: Dashboard Deployment Table Shows Incorrect time format

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?
Dashboard
What happened?
Dashboard Deployment Table Shows Incorrect time format
Steps To Reproduce

Deploy a node
if it's a 1 digit minute (e.g. 0 to 9) it shows the format e.g. 1:1, instead of 1:01, etc.

which network/s did you face the problem on?
Main
version
latest
Twin ID/s
No response
Node ID/s
6071
Farm ID/s
No response
Contract ID/s
No response
Relevant screenshots/screen records

Relevant log output
8/5/24, 9:1 PM

Hello @Mik-TF
I tried the mentioned scenario and seems working as expected on the staging server, please note, the staging server running against Devnet

I wonder if it's something that happens only with e.g. 10:01 --> 10:1
If it worked on your side, all's good. Thanks.

I wonder if it's something that happens only with e.g. 10:01 --> 10:1
If it worked on your side, all's good. Thanks.

It was an UI issue, and it was reported and fixed here: https://github.com/threefoldtech/tfgrid-sdk-ts/issues/2751.
But its on 3.15, so its not released yet.


Support other packet compression methods/implementations

Investigate:

adding other compression algorithms, maybe zstd, brotli, snappy or another
other gzip implementations
if compressing a block at a time instead of streaming is faster
moving block deflate to the write thread

4.0 supports zstd


♻ Chassis Refactor

Summary
Chassis class refactor
Motivation
Readability and documentation are really important in LemLib. Novice programmers should be able to look at the source code and think “this makes sense”. In preparation for the next major release, the Chassis class will be refactored to improve readability and documentation
Test Plan

[ ] Confirm moveTo works
[ ] Confirm turnTo works
[ ] Confirm follow works

Additional Notes
No logic changes in this PR, just restructuring / refactoring

Closing. Changed design specs


Include security contact for config-file-provider

Description
Update security contact for config-file-provider
@imod @MRamonLeon
Submitter checklist for adding or changing permissions

Always

[X] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[ ] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

Note that technically Evaristo is now a maintainer and could approve it since https://github.com/jenkins-infra/repository-permissions-updater/pull/1668, but obviously we'd prefer to have Domi's approval because he's been the great maintainer for this plugin for so many years. @imod

👍

Thanks for the quick turnaround everyone!


Mail Sending

Hi Mark,
thank you for this project. It gave us a great inspiration how to dockerize Magento2.
One questions remains: how to you handle sending emails? What are the best options?
Thanks for an answers ... even if this issue maybe incorrectly placed 8-)
Cyrill

No worries, typically only issues but questions like implementation details are just fine here :)
For emails, you should configure a third-party API such as mailgun. A local service should be a no-op in a docker environment, because you can't log or control the sending of emails if you have multiple similar docker containers running (same reason the cronjob should really be on it's own container or worker instance, -- can't guarantee the cron will only run once, so here we can't guarantee only one email will be sent).

Hi @markoshust,
thank you for your answer on this issue in the first place!
Your points are totally valid and understandable, but if one doesn't have multiple #similar# containers running #at the same time# and only use them for continuous integration and delete them afterwords I do believe that there is no issue in sending mails through a local service (that doesnt run a new daemon and therefore conflicts with the docker best practice of using only one process per container/image).
Same thing about the cron, in your image it's also in the same image as magento itself. Therefore I don't believe there should be any problem (if you have only one magento container running).
In which scenario do you have more than one magento container similar on one machine with the same codebase running simultaneusly (apart of scaling or clustering stuff)?
Generally speaking, for production environments using docker your answer is totally fine, but there should be a differentiation between DEV & production.
Thank you again for your fast reply!
pointerxr

If you are only running one container/instance, you are correct, there are no issues. However, to properly scale out horizontally and build this out (for example, let's say I wanted to run an instance across 10 machines with 3 docker containers a piece), a proper 12-factor app approach should be taken and migrate these off to their own run services or third-party/api tools.
In regards to dev vs production, the API approach would still work. You just setup dev accounts for mail sending, cron management, etc., and set env variables to determine which services the API's use. I always use mailgun in my nodejs projects, even in dev, just passing in dev environment variables to send to dev api accounts. It's a proper 1:1 testing with production envs.


drm: Use DRM_FORMAT_MOD_LINEAR when no other format modifiers are present

The absence of modifiers means "assume linear" not "don't use any
modifier". This prevents gallium from using plain resource_create but
rather resource_create_with_modifiers.
This unbreaks broken rendering on etnaviv as resource_create assumes
it can supertile (which makes sense since e.g. dcss and ipuv3 can
handle these formats). However lcdif/mxsfb can't handle this so
be explicit about the modifier.
Weston does the same, see drm_plane_populate_formats().
This is basically a safety net if the display controller does not
announce supported modifiers. We'll fix this as well in the kernel but having
good default is useful too.

The absence of modifiers means "assume linear" not "don't use any
modifier".

I dont think this is correct? Doesnt it mean "use an implicit modifier"?

Related: https://lists.freedesktop.org/archives/dri-devel/2020-March/260542.html

I dont think this is correct? Doesnt it mean "use an implicit modifier"?

Do you have a reference? If so how would the GPU figure out what that is so it uses a modifier suitable for the display controller?
Weston assumes DRM_MOD_LINEAR and that looks like a conservative approach to guard against incomplete modifier/format information:
https://gitlab.freedesktop.org/wayland/weston/-/blob/master/libweston/backend-drm/kms.c#L490
I've also submitted<EMAIL_ADDRESS>which doesn't fix the whole issue though since we assume ARGB8888 support as well which e.g. isn't true for mxsfb atm (although there's patches now to fix that too). Given that situation (which likely applies to other non PC platforms) i figured it'd be best to be conservative here.

If so how would the GPU figure out what that is so it uses a modifier suitable for the display controller?

The usage flags with GBM_BO_USE_SCANOUT are supposed to make this work.

The usage flags with GBM_BO_USE_SCANOUT are supposed to make this work.

Good point, i think i can see where that gets lost now.

Also, see this discussion which is about adding the usage flags to gbm_bo_create_with_modifiers: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3197

@agx Have you fixed this issue in Mesa instead of wlroots?

no, i did not get a chance to look at this again.

Sorry for the delay.
I think<EMAIL_ADDRESS>fixes that (totally forgot about that patch)


Subscriber Groups button are inaccessible/unclickable or glitched in every of layouts with PocketTube

Problem description:

The Subscriber Groups sidebar section (with PocketTube extension installed) is unclickable, which means, that it is inaccessible.
Also the buttons in PocketTube are greyed out.
The “Deck” button is though clickable, but greyed out too.

Expected results:

The Subscriber Groups in the sidebar should be accessible.
The buttons in PocketTube should NOT be greyed out!

Other details:

Browser version: Firefox v113.0.2
YouTube site zoom percentage: 100%
OS version: Windows 11 22621.1778
OS architecture: 64-bit
Browser architecture: 64-bit
CPU: AMD A10-7860K
RAM: 16,0GB DDR3
Motherboard: MSI A88XM-E35 V2
Graphics: 1024MB ATI AMD Radeon R7

Screenshots:

SCREENSHOT NOTE: “Skupiny Odberov” means “Subscriber Groups”.
WARNING: Inaccurate accessibility due to black arrows icons, black text & dark grey background in this screenshot!

I haven't used PocketTube, but based on your screenshot, it looks like PocketTube is creating its own sidebar elements that use separate styling from the native YouTube sidebar items. So basically this only happens because CustomTube wasn't tested with PocketTube. (The only other extensions/scripts CustomTube was tested with are uBlock Origin and Return YouTube Dislike.)
I'll look into it though. In the meantime, could you tell me if it happens on other layouts? In this situation, it would be most helpful to test on the 2013, 2017, and 2019 layouts. If it happens on all three of those layouts, test it with "Layout Select" set to "Disabled".

In the 2013, the PocketTube is not only inaccessible, but also large (Wait for me to testing the 2017, and 2019 please…)

2014 PocketTube is clickable, but the buttons are large, and Deck button is unclickable (Sorry, but you must wait, because I have some things to do with Firefox's CSS, so be patient):

Well, 2015 is same as 2014. (Sorry for delay)

2016 ditto as 2015, and 2014.

Yeah 2014-2017 should all be the same, there isn't much of a need to test them all. They share most of their code.

And for 2019, then there is wrong outline shade for Deck button, and the Sub. Collections are using wrong buttons shape, they should be square instead of rounded.

Okay, so that adds weight to my theory that PocketTube uses it's own CSS to style its sidebar items. I'll look into fixing it.

Please, I need your answer, is this blue tick mark feature of YouTube, or feature of PocketTube?

If it is feature of YouTube, then it needs to be fixed, if it is feature of PocketTube, then I don't know.

Fine, I will write it to description, and title.


Required rule doesn't consider default value 0 with numeric/integer rule

Environment
@vueform/vueform: 1.8.0
vue: 3.4.20
Reproduction
https://codesandbox.io/p/devbox/nostalgic-margulis-7s9qwt?file=%2Fsrc%2FApp.vue%3A23%2C21
Describe the bug
The default value equals 0 is expected to be accepted as a required numeric value, but this is not
Additional context
If the default value not equals 0 or there are no numeric/integer rules, then everything works as expected
If you change the value and then make it 0 again, then the value is accepted
Logs
No response

Should be now fixed in 1.9.0.


Preview in designer window generate StackException

Unable to parse composition
StackTrace
at LottieSharp.LottieAnimationView.SetAnimationAsync(String assetName)
at LottieSharp.LottieAnimationView.FileNamePropertyChangedCallback(DependencyObject dependencyObject, DependencyPropertyChangedEventArgs e)
at System.Threading.Tasks.Task.<>c.b__139_0(Object state)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
i simply have this code:

<lottieSharp:LottieAnimationView
x:Name="LottieAnimationView"
DefaultCacheStrategy="None"
FileName="logo-anim.json" AutoPlay="True"
VerticalAlignment="Center"
HorizontalAlignment="Center"/>

Same over here. When you start the app it runs faine though


Fix Hyq srdf (disable collision pairs)

Disable collision pairs for all the adjacents link.
Add all the "never" colliding collision pairs. For this last point, I did it symmetrically with respect to what was already done for one leg. But I do not really agree with it: a lot of this pairs are never colliding only if we respect the joints limits specified in the URDF.
I am not sure about what is the policy for this, for me "never" colliding should only be used when it is physically impossible that both links are colliding.

I agree with you.

Ok, I removed some of this lines then.

This fix some unit tests for me, thanks a lot !


Throw an error when esbuild loads a file outside the bazel sandbox.

This implementation uses an OnLoad plugin to catch when a file is loaded that is not in an allowlist of files. The allowlist is all the files within the BAZEL_BINDIR and all of the symlink targets of those files.
This may not prevent all sandbox escaping modes. The esbuild Go code may still access unsandboxed files in the course of loading files that are in the sanbox.
Addresses https://github.com/aspect-build/rules_esbuild/issues/58 and requires https://github.com/aspect-build/rules_js/pull/793 to work properly.

This PR is based on https://github.com/aspect-build/rules_esbuild/pull/32, but I lost the attribution in the commit log.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@gregmagolan what are the next steps with this one?

ping?


Delete StockDistribution elements when quantity is set to zero.

Tentative pull request to fix Issue #135
StockDistribution elements are now automatically deleted when their quantity gets set to zero.
This should remove them from the finalized order.
Please review these changes since I'm not 100% sure how the system is supposed to work.

@fcapovilla thanks so much for the PR!  Happy Hacktoberfest!  I'm at work now but at a glance this looks great, thanks so much!  Will download and run locally later and/or perhaps @komizutama will take a look and make sure it works/looks OK behavior wise to them, but really excited to have our first Hactoberfest contribution, and hope you'll consider sticking around!

Added a commit with the JS fix.
Thanks for the review. :)

Thanks man!  Hope you'll consider sticking around @fcapovilla !


test was fixed, but order by was left on by accident

Critical Changes
Changes

Remediated one of the Unit Tests from build 1.66 still had a filter which was preventing encryption of the Section ID field on Course Offering.

Issues Closed
New Metadata
Deleted Metadata
Testing Notes

Run the unit test from TERM_CourseOff_Test.cls and ensure it still passes.
Turn on platform encryption and attempt to encrypt the Section_ID__c field on the Course Offering custom object.

This looks good. Merging the PR.


Download customize - Misc dependencies not listed

Modals with 'fade' seem to require either Misc.Utilities or Misc.Component animations.
Without it the modal-backdrop wasn't removing itself when closing the modal.

Yeah it requires component animations. We'll need to flush out the dependencies better in our builder for sure.


Improve "waiting for transaction" state on "Distribute funds" modal

Description
When a transaction is being processed, we don't show any loading state on the modal. We show a blocknative notification, but I think we can show a fun banny-inspired loading state in the modal itself to improve UX.

Proposal
TBA,  needs more thought.

Implemented for V2, closing and will open issues to migrate modals to TransactionModals later


[BUG] Serial Lights probably need valid udev rules

As of version 0.22.2 Busylight for Humans™ supports USB serial devices, however I need to install it on a linux host to check for udev related problems.

I can probably test this sometime in the next couple weeks. I use a linux host for my busylight setup. :)


Add dependabot config

Deploy preview for govuk-react processing.
Building with commit d0fbf9bdc605983c670eae406ff0ad62eadc8738
https://app.netlify.com/sites/govuk-react/deploys/609ef468b6deb50008db2515

Codecov Report

Merging #761 (d0fbf9b) into master (5ca1775) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   99.29%   99.29%
=======================================
  Files         121      121
  Lines         857      857
  Branches      248      248
=======================================
  Hits          851      851
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca1775...d0fbf9b. Read the comment docs.


Tweet gifs are not included in media

Let me know if I'm wrong, but I was expecting tweet's GIF being part of photos or videos Tweet's fields.
From what I see, the Tweet's html field only contains the "video" (gif) thumbnail url so I can't rely on it too.
Current behavior:
{
  ...tweet,
  photos: [],
  videos: []
}

Not implemented yet: #6

Thanks for your answer!


Support NavigationVew

[x ] I have verified the issue exists on the latest version
[x ] I am able to reproduce it

First of all, thanks for the great library.  I am using your library in my app. However, I could not find a way to create a TapTarget for a meu item in NavigationView.
<com.google.android.material.navigation.NavigationView
        android:id="@+id/navigationView"
        android:layout_width="wrap_content"
        android:layout_height="match_parent"
        android:layout_gravity="start"
        android:fitsSystemWindows="true"
        app:headerLayout="@layout/view_navigation"
        app:menu="@menu/main_left_navigation_menu" />

I am using NavigationView in DrawerLayout. I tried something like below, but it did not work still:
TapTarget.forView(navigationView.findViewById(R.id.nav_contact),
                                      getString(R.string.tutorial_main_contact))

Version used:
1.13.0

@kingfisherphuoc have you find any way to support navigationview?


Small str const

sadly does not work because it runs into #3609. @bhansconnect what is the status of that. did the recent zig upgrade change this at all?

I haven't touched #3609 in a long time. Last time I tried, I got a partial solution but due to all of the extra data shifting, it was brittle and generally just led to segfaults. The biggest part of the problem is that the roc app needs to add an arbitrary number of entries to the dynamic table. 1 for each absolute relocation. My original attempt just lead to way to many extra shifts and became a mess.
What I need to test as a next step is just moving the entire dynamic table to the end of the executable during preprocessing. That way, during surgical linking there would be no need to shift the entire host part of the application again. Then the surgical linker would just first append to the dynamic table then append all of the extra application stuff.

Wrote up a more concrete reply here: https://github.com/roc-lang/roc/issues/3609#issuecomment-1849188204


fix: path variable export for gmake 3.81 (#110)

This pull request adds a hack for the problem that a changed PATH environment variable is no correctly exported to $(shell ...) calls and subsequently also to target executions prior to gmake version 4. This is necessary since MacOS is by default running the outdated  gmake 3.81+.
See also https://stackoverflow.com/questions/8941110/how-i-could-add-dir-to-path-in-makefile

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
190

Relevant Lines:
190

💛  - Coveralls


If CI fails on master, post a message in the #ci-failures-stdlib Slack channel

Codecov Report

Merging #16 (c04c0c0) into master (80246e6) will decrease coverage by 1.80%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##            master      #16      +/-   ##
===========================================
- Coverage   100.00%   98.19%   -1.81%
===========================================
  Files            4        4
  Lines          111      111
===========================================
- Hits           111      109       -2
- Misses           0        2       +2

Impacted Files
Coverage Δ

src/ca_roots.jl
90.90% <0.00%> (-9.10%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80246e6...c04c0c0. Read the comment docs.


Add mod Blink

And lastly I have a Blink mod that I think is good for Survival and/or PvP servers. It is short distance teleport kind of like an ender pearl but reusable.
viewtopic.php?t=27163

I decided to not include this mod as of now. We already have other means of travel/teleporting in the server.


<EMAIL_ADDRESS>does not include binaries

<EMAIL_ADDRESS>does not include binaries, causing the the install script to fail on many machines.
Rolling back to 5.0.0 or upgrading to 5.0.2 will solve the issue.
More context: https://github.com/mapbox/node-sqlite3/issues/1424

Thanks for the heads up, I updated the sqlite version!


Width too small for Disable CSS button

This causes text wrapping to occur on certain views. Should probably increase it by 50%.

It may be better to dynamically set the width in javascript to always be wide enough.


Upgrade to pyo3 v17

Upgrades to pyo3 v17 and implements the frozen attribute that was included in the new release. Will see if we can benchmark before and after to see the difference.

Benchmark before:
Testing token bucket...
Discarding 3 first samples
Average was 0.3ms per run
Median was 0.3ms per run
Median time was below target of 0.4ms

Testing semaphore...
Discarding 3 first samples
Average was 3.2ms per run
Median was 3.4ms per run
Median time was below target of 4.0ms

Benchmark after (worse)
Testing token bucket...
Discarding 3 first samples
Average was 0.3ms per run
Median was 0.3ms per run
Median time was below target of 0.4ms

Testing semaphore...
Discarding 3 first samples
Average was 3.5ms per run
Median was 3.9ms per run
Median time was below target of 4.0ms

Benchmark after, using release build
Testing token bucket...
Discarding 3 first samples
Average was 0.2ms per run
Median was 0.2ms per run
Median time was below target of 0.4ms

Testing semaphore...
Discarding 3 first samples
Average was 2.4ms per run
Median was 2.6ms per run
Median time was below target of 4.0ms


Small fix to prevent some errors

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

3
0
0
3

Vote Breakdown

User
Yes
No
Abstain

TheRealMaxion
✔

apemanzilla
✔

tedivm
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


Dev

Hi @jlslsit, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

Hi, this seems to be a wrong pr...please ensure your forked repo is up to date and then create a PR targeting our DEV branch.
Closing this PR now


Native task sequence support for Windows Auto Pilot for existing devices

Need conformation on this feature in technical preview release of SCCM 1810. We can see this feature listed in Public techcommunity blog but not in Microsoft docs. Also, like to have procedure on how to enable and use this feature.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ac2470bb-8bcb-d07d-71c3-261b84762419
Version Independent ID: 868cabe3-5088-fa54-cba0-56ff1d2259ef
Content: Technical preview 1810 - Configuration Manager
Content Source: sccm/core/get-started/capabilities-in-technical-preview-1810.md
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

CLosing this issue as the content published earlier today for this feature.


Switch from ros2.repos to rosinstall_generator for source installation instructions

We've slowly been preparing for phasing out the ros2.repos file in favor of using the rosinstall_generator like we do for ROS 1. e.g. melodic
This will improve our documentation to allow users more granularity and control of what they install. It's been directly requested and experienced developers were able to inform them how to use our more powerful tools that exist and work well, but are undocumented.
There will be some necessary documentation of what variants are expected to work on each platform. But not giving people the tools seems to have more downsides.
As we're late in the galactic release cycle I'd like to suggest that we officially plan to switch rolling documentation over and plan for H-Turtle to inherit the newer more dynamic approach.

This issue has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/core-base-and-desktop-releases/20267/4

"The current instructions more-or-less follow how the CI jobs work" the current instructions are disjunct, broken across various OS versions Debian, Ubuntu, Raspbian, RaspiOS, etc, and ROS versions.
"the target audience" should be "anyone that seeks to make ROS as a project usable" from a basic source code tree of the various components and their dependencies.
CI, and end users are not at all the same thing. CI very often involves nasty hacks to force things to build in ONE very specific environment. It flat out isn't scalable in the context of offering instructions to end users. What you all do in CI is your own business.
rosdep is a nightmare, and flat out does not work in many situations.
My first experience with a source code build was because of the landscape left by Nvidia Jetson & JetPack versions. Installing the proper ROS version on a Jetson device is really difficult if you have specific version needs. Half the instructions say use colcon, something else says use catkin, you fall into traps of needing to know specific branch names if you dare try to checkout via git without vcs and a full repo export.
The Xiaomi Cyberdog for example uses a Jetson at its core, but they wanted ROS2, so had to do a custom compile with very specific version and certain packages omitted.
https://github.com/MiRoboticsLab/cyberdog_ros2/wiki/从源码安装ROS-2-%7C-Building-ROS-2-from-source
I was very pleased when I saw rosinstall_generator dump out a vcs script for me to import.


Enhancement: Allow Window's config suggestions

Currently, it seems that hain only gives suggestions for programs. However, a lot of the times I want easy access to the sounds control panel, uninstall programs window, normal Windows settings, etc. Maybe we can make it so that Window's config options rise to the top before any application.

This is going to be getting some attention in the near future.  On windows via the PATH environment variable as well as the PATHEXT environment variable.  On *nix systems we will be improving to look for any files with the e(x)ecutability bit in any PATH directory.  Stay tuned.

Try as I might, I did not have much success with this.  I have shelved this ticket for the time being, countless hours battling with c# has left me drained on this, but I will come back for it after I work on some other issues.


python3: fix impure /bin/sh call in subprocess

Motivation for this change
I am not sure if we care about this, but the subprocess module relies on the impure /bin/sh symlink. This fails in sandboxes/containers without this symlink present. E.g.:
$ bwrap --ro-bind /nix /nix $(nix-build -A python3 --no-out-link)/bin/python3
>>> import subprocess
>>> subprocess.run("exit 1", shell=True, check=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/nix/store/fjgnz0xfl04hsblsi4ym5y5akfh6mlmy-python3-3.8.5/lib/python3.8/subprocess.py", line 489, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/nix/store/fjgnz0xfl04hsblsi4ym5y5akfh6mlmy-python3-3.8.5/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/fjgnz0xfl04hsblsi4ym5y5akfh6mlmy-python3-3.8.5/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/bin/sh'

After this change:
$ bwrap --ro-bind /nix /nix $(nix-build -A python3 --no-out-link)/bin/python3
>>> import subprocess
>>> subprocess.run("exit 1", shell=True, check=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/nix/store/c9b1hkcsdwvkh8cr7d1wjq16j6vfcpsb-python3-3.8.5/lib/python3.8/subprocess.py", line 512, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'exit 1' returned non-zero exit status 1.

Found while reviewing #95218.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Can you rebase this to only include your commit?

Can you rebase this to only include your commit?

Whoops, I rebased on staging, but forgot to change the target branch on GitHub. Thanks @FRidh!


Adding friends does not work

My friend and I both tried to add each other, but when we do it still says 0 friends. We have both tried to host a single-player world, but nothing shows up in the "friends" tab - even though everything appears to work normally as it displays the port number in chat. Clicking refresh a couple times did not help.
(Their name is censored btw)

Just verifying, you both have each other as friends, correct? Because it doesn't work if only one of you has the other added as a friend.

Ktor is throwing "ArrayChannel was cancelled" on the server. This occurred occasionally in testing, but I thought I fixed it, and it never happened this much.


Tech debt incorrect

reference #368 Code collector widget showing different tech debt value
In the current code I found the math was wrong, but after further testing we found it better to simply use the formatted value returned in the JSON from SONAR, then we will always match.

We have been wondering abt it for a while. Thanks for digging deep. Older version of Sonar was okay.

changed to display formatted value returned by sonar instead of computing from minutes, this will ensure www are as consistent as practical with the Sonar UI.

@jimzucker can you verify and recreate, this doesnt seem correct

@jdamick - I see the comment on the pull request was outdated, but the comment not he issue #368 & the commit are OK.  I updated the pull request description, if you want a new pull request let me know.

but this part:
ctrl.technicalDebt.formattedValue = ctrl.technicalDebt.formattedValue;
why?

@jdamick - yes something looks wrong, let me check my branches, thanks for catching this.

@jdamick - OK I see what happened, I just didn't pay attention to the left side of the equation when I made the fix, I commented it out as it is a NOP, when the JSON is parsed the value is set correctly. I will submit a new pull request.


Grammar: cannot

Why:
can not is wrong. https://www.grammarly.com/blog/cannot-or-can-not/
What's being changed (if available, include any code snippets, screenshots, or gifs):

https://docs.github.com/en/actions/learn-github-actions/expressions#object-filters
Before

After

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

What is this?
Dne ne 29. 1. 2023 10:01 uživatel github-actions[bot] <
@.***> napsal:

Automatically generated comment ℹ
This comment is automatically generated and will be overwritten every
time changes are committed to this branch.
The table contains an overview of files in the content directory that
have been changed in this pull request. It's provided to make it easy to
review your changes on the staging site. Please note that changes to the
data directory will not show up in this table.
Content directory changes
You may find it useful to copy this table into the pull request summary.
There you can edit it to share links to important articles or changes and
to give a high-level overview of how the changes in your pull request
support the overall goals of the pull request.
Source Preview Production What Changed
actions/learn-github-actions/expressions.md
https://github.com/github/docs/blob/314ea3083364dbf2cbaeb4494aa611365f657f49/content%2Factions%2Flearn-github-actions%2Fexpressions.md
fpt
https://docs-23559-b387ca.preview.ghdocs.com/actions/learn-github-actions/expressions
ghec
@./actions/learn-github-actions/expressions>
ghes@ 3.7
@./actions/learn-github-actions/expressions>
3.6
@./actions/learn-github-actions/expressions>
3.5
@./actions/learn-github-actions/expressions>
3.4
@./actions/learn-github-actions/expressions>
3.3
@./actions/learn-github-actions/expressions>
ghae
@./actions/learn-github-actions/expressions>
fpt https://docs.github.com/actions/learn-github-actions/expressions
ghec
@./actions/learn-github-actions/expressions>
ghes@ 3.7
@./actions/learn-github-actions/expressions>
3.6
@./actions/learn-github-actions/expressions>
3.5
@./actions/learn-github-actions/expressions>
3.4
@./actions/learn-github-actions/expressions>
3.3
@./actions/learn-github-actions/expressions>
ghae
@./actions/learn-github-actions/expressions>
fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE
—
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/23559#issuecomment-1407603203, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AY2GOK6DCSDZTB4GMXM5PUDWUYWWPANCNFSM6AAAAAAUKEAU6I
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

👋 @jsoref Thanks for catching this! I'll get it reviewed ⚡


AsyncToSync error with Flask Async, Gunicorn and Gevent

When using the Async options for Flask, running an application with an asynchronous teardown_request function, using Gunicorn with Gevent as the WSGI server, there is a race condition where a lot of simultaneous requests results in the error "You cannot use AsyncToSync in the same thread as an async event loop - just await the async function directly.".
I've attached a reproduction. To reproduce the bug:

Unzip the zip to a directory.
Install the requirements using pip install -r requirements.txt.
Run the application using gunicorn -b <IP_ADDRESS>:8080 app:app --worker-class=gevent -w 2 --threads 2.
In another shell, run ./lots-of-curls.sh.

The stack trace I see is
Traceback (most recent call last):
  File "/home/sam/.pyenv/versions/3.9.7/envs/flask-test-3.9.7/lib/python3.9/site-packages/gunicorn/workers/base_async.py", line 55, in handle
    self.handle_request(listener_name, req, client, addr)
  File "/home/sam/.pyenv/versions/3.9.7/envs/flask-test-3.9.7/lib/python3.9/site-packages/gunicorn/workers/ggevent.py", line 128, in handle_request
    super().handle_request(listener_name, req, sock, addr)
  File "/home/sam/.pyenv/versions/3.9.7/envs/flask-test-3.9.7/lib/python3.9/site-packages/gunicorn/workers/base_async.py", line 108, in handle_request
    respiter = self.wsgi(environ, resp.start_response)
  File "/home/sam/.pyenv/versions/3.9.7/envs/flask-test-3.9.7/lib/python3.9/site-packages/flask/app.py", line 2213, in __call__
    return self.wsgi_app(environ, start_response)
  File "/home/sam/.pyenv/versions/3.9.7/envs/flask-test-3.9.7/lib/python3.9/site-packages/flask/app.py", line 2206, in wsgi_app
    ctx.pop(error)
  File "/home/sam/.pyenv/versions/3.9.7/envs/flask-test-3.9.7/lib/python3.9/site-packages/flask/ctx.py", line 401, in pop
    self.app.do_teardown_request(exc)
  File "/home/sam/.pyenv/versions/3.9.7/envs/flask-test-3.9.7/lib/python3.9/site-packages/flask/app.py", line 2038, in do_teardown_request
    self.ensure_sync(func)(exc)
  File "/home/sam/.pyenv/versions/3.9.7/envs/flask-test-3.9.7/lib/python3.9/site-packages/asgiref/sync.py", line 209, in __call__
    raise RuntimeError(
RuntimeError: You cannot use AsyncToSync in the same thread as an async event loop - just await the async function directly.

If you run without gevent, using the command line gunicorn -b <IP_ADDRESS>:8080 app:app -w 2 --threads 2 the issue does not manifest.
If you remove all the  & characters from the end of the lines in lots-of-curls.sh, so the curl statements run serially rather than in parallel, no issue shows up so this appears to definitely be a race condition of some sort.
It is possible this is a bug in another component in the stack, but I just don't have clear enough knowledge of how the responsibilities are assigned to know which component is at fault, apologies if the bug is not in Flask itself.
Environment:

Python version: 3.9.7
Flask version: 2.3.3

Thanks for the detailed report. However, that's an issue with asgiref.AsyncToSync, not Flask.


fix: replace caip2, caip19 fields in asset type

Description

Replace references to {caip19, caip2} in Asset type with {assetId, chainId}.
Depends on lib PR#593
Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk
Low risk - this PR only renames fields and contains no logic changes.

Testing

Screenshots (if applicable)

@pastaghost also failing build

We should be good to update @shapeshiftoss/types to 3.1.0 in this PR to pass CI now.
We might need to rebase too, as there seems to be a type issue unrelated to this PR.


Add Connery Actions to the list of available tools

Hey there!
First of all, thank you for a great initiative with OpenGPTs!
I've added Connery Actions to the list of available tools.
I hope they're useful for OpenGPTs users.
Connery Actions is an open-source project which aims to provide two things to the community:

Infrastructure and runtime for actions with essential features like connection management, personalization, etc.
Open-source plugin ecosystem so the community can benefit from shared plugins and easily customize them

Read more about Connery in our repository: https://github.com/connery-io/connery
Cheers!

Perfect, thank you @nfcampos!


help(Sidenav): how to code a sidenav like material.angular.io did

What are you trying to do?
I`m trying to write a Sidenav skeleton demo, just like official document navigation skeleton(A menu in the left part and content body in the right part with overview\api\examples tabs):

And I`m new to Angular, I cannot figure out how to code this Sidenav skeleton, and I can not find where is the relevant source code about this skeleton after I cloning this repo.
If anyone can help me, I'll be much appreciated. 😁
What troubleshooting steps have you tried?
I have already read the Sidenav Document, and still don't understand.
Because according to this document, I need to code Sidenav as follows, but in Official Sidenav skeleton, it's class called docs-component-viewer-nav-content ng-tns-c139-5 rather than mat-drawer-inner-container ng-tns-c36-0:
<mat-sidenav-container class="example-container" *ngIf="shouldRun">
  <mat-sidenav mode="side" opened>Sidenav content</mat-sidenav>
  <mat-sidenav-content>Main content</mat-sidenav-content>
</mat-sidenav-container>

Reproduction
As above, I use the mat-sidenav-container tag but don't know how to realize the Sidenav style of the official website one by one.
Environment

Angular: ~9.1.0
CDK/Material:^9.2.0
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOS

The docs site is using a custom navigation. You can find the source here: https://github.com/angular/material.angular.io/blob/f9ee14a24a9c171c8d2cb6d053e055538eb21506/src/app/pages/component-sidenav/component-sidenav.ts#L100.


Move teknoparrot inside arcade system

Arcade platform takes priority over other platforms, gun icon will only be displayed if the game appears in arcade system in gamesdb

Can you merge this ?
We plan to build RetroBat RC this weekend

This PR also fixes FR translations done by 1FR1 (like MOISSONAGE)

OK for TeknoParrot migration to arcade system, since it's scraping from arcade metadata.


Added support for unicode Latin-1 Supplement in humanize()

Updated the regex in humanize to support some commonly used "foreign" characters, Latin-1-Supplement is sorted nicely with upper / lower case characters, so only did the basics that covers my use case, but it's possible to extend this support much longer.
See:
https://symbl.cc/en/unicode-table/#latin-1-supplement
I added the characters:
00C0-00D6, 00D8-00DD (uppers)
00E0-00F6, 00F8-00FD (lowers)

I'm a bit reluctant to this, as it would over-complicate that regex in order to cover an edge case which is - frankly - a bit of an anti-pattern.
You shouldn't have property names containing "foreign" characters.
Proper code identifiers (i.e. variables, properties, function names) should always be written in English.
I perfectly understand your intention as my native language is Romanian and we use a lot of "foreign" characters. Moreover, I am actually very particular about using them to write prose correctly, but never in code.


Add Waveshare Pico Clock Green to v3.6 branch

This resolves #176 and add some new drivers:

Maxim DS3231 as MFD driver with a first version of separated drivers for:

RTC w/o alarm support, see #174
temperature sensor w/o event control, see #175

General Purpose (GP) matrix controller, implemented in software, using a generic latched serial in parallel out (SIPO) shift register for the data (columns) and a multiplexing X to 1-of-2^X decoder (MUX) for the addresses (rows). The implementation is a MFD driver set with:

SIPO/MUX GPIO controller
SIPO/MUX display controller

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.
Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

For the new Waveshare Pico Clock Green documentation and samples, see: https://bridle.tiac-systems.net/ghpr/doc/PR-210/bridle/boards/shields/rpi_pico_clock/doc/index.html


Fix param-validation for PIO sideset encoding

Same change as #282 , but re-opened against the develop branch.

Just FYI I only wrote this patch by cross-referencing pio_instructions.h against what the RP2040 datasheet says, I didn't look at any of the pioasm stuff. But of course that's still no guarantee that I've not made a mistake in my understanding!
Any chance you could take a look @Wren6991 ?

To add to the confusion, pio.h uses the same convention as the hardware, i.e. inclusive of the EN bit, which is different from pio_encode_sideset_opt(). Bit of a shame, too late to fix this now. It's a good thing the pio.h function is usually called from code generated by pioasm, which uses the exclusive count convention
/*! \brief Set the 'sideset' options in a state machine configuration
 *  \ingroup sm_config
 *
 * \param c Pointer to the configuration structure to modify
 * \param bit_count Number of bits to steal from delay field in the instruction for use of side set (max 5)
 * \param optional True if the topmost side set bit is used as a flag for whether to apply side set on that instruction
 * \param pindirs True if the side set affects pin directions rather than values
 */
static inline void sm_config_set_sideset(pio_sm_config *c, uint bit_count, bool optional, bool pindirs) {
    valid_params_if(PIO, bit_count <= 5);
    valid_params_if(PIO, !optional || bit_count >= 1);
    c->pinctrl = (c->pinctrl & ~PIO_SM0_PINCTRL_SIDESET_COUNT_BITS) |
                 (bit_count << PIO_SM0_PINCTRL_SIDESET_COUNT_LSB);

Think we should merge this patch as is and then go through and add doxygen to the encode functions, making sure the inconsistency is highlighted.

Ahhh, I hadn't noticed that inconsistency because I was only looking at pio_instructions.h and not pio.h. But yes that does explain the confusion!


2.3.9版本目前不支持React17 么

warning "braft-editor ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "braft-editor ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "braft-editor ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "braft-editor ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^15.0.0-rc || ^16.0.0-rc || ^16.0.0".
warning "braft-editor ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^15.0.0-rc || ^16.0.0-rc || ^16.0.0".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>^16.0.0-rc || ^16.0.0".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>^16.0.0-rc || ^16.0.0".
页面会直接报错

重新install一下

For anyone else hitting this issue, you can install the modules using this command:
npm install --legacy-peer-deps

For anyone else hitting this issue, you can install the modules using this command:
npm install --legacy-peer-deps

Thank You for the Reply


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade" workflow

Codecov Report

Merging #34 (aab9f92) into main (4958138) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           27        26    -1
=========================================
- Hits            27        26    -1

Impacted Files
Coverage Δ

src/backend-stack.ts
100.00% <100.00%> (ø)

src/lambda/process-metrics-function.ts
100.00% <100.00%> (ø)

src/stateful-stack.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5bf9f...aab9f92. Read the comment docs.


Limited to 84 rows and 61(BI) colomn?

I can't just go after that.
Fig:

Right click on any cell, you can add more through the menu


Any possibility communicate with spike/RE hub over USB

Please implement a method to communicate with spike/RE Hub over USB/ bluetooth, which allows the access to LED matrix and IMU.

Since this library is designed to run on the RaspberryPi and access the BuildHAT, you would just include a different library (such as https://github.com/smr99/lego-hub-tk) in your program to access both of them in the same program (yours)

Thank you.


Unmanaged Customizations not being overridden.

Hi Team,
I am trying to resolve an issue where unmanaged customizations are not being overridden when importing and I noticed what could be the issue.
When importing a managed solution, when "Overwrite Unmanaged Customizations" option is selected in the classic interface,  the parameter for this is incorrect and MAY be interfering with it functioning...
Same as YAML: OverwriteUnmanagedCustomizations: true.
2023-06-30T21:04:00.2817822Z ==============================================================================
2023-06-30T21:04:00.2818113Z Task         : Power Platform Import Solution
2023-06-30T21:04:00.2818299Z Description  : Power Platform Import Solution
2023-06-30T21:04:00.2818478Z Version      : 2.0.27
2023-06-30T21:04:00.2818643Z Author       : Microsoft
2023-06-30T21:04:00.2818806Z Help         : More Info
2023-06-30T21:04:00.2819161Z ===========================================================
. . .

As per documentation in the link below  "--force-overwrite" "This parameter requires no value. It is a switch"
https://learn.microsoft.com/en-us/power-platform/developer/cli/reference/solution#--force-overwrite--f
As per documentation, the "true" is not correct and should be omitted.
Not sure if it's causing my issue still looking into it.
EDIT: The issue I was experiencing with unmanaged customizations was caused by something else - therefore the issue above with the flag is probably very low priority and may not make a difference.

This is just logging issue. Documentation is correct --force-overwrite is switch which requires no value. When we log Calling pac cli inputs it adds true but actual executed command is correct


Link to ZIP doesn't work in quick start guide

When clicking on "Download our sample" in https://developer.microsoft.com/en-us/graph/quick-start?appID=my_app_id, it opens https://codeload.github.com/microsoftgraph/msgraph-training-ios-swift/zip/master which is a 404.

Thanks - it's a known issue with all those zips in Safari. Are you using Safari?

Yes, I’m on a Mac.

Thanks for confirming. This is a known issue with the Graph site unfortunately, but it is being worked on. For now you can get the code from this repository.


Cannot "Pop" Combined Texas Emancipation/Juneteenth Holiday

Creating a holiday using TX as the state, there is the combined holiday 'Emancipation Day In Texas; Juneteenth National Independence Day'
Previous versions of python-holidays seemed to treat this concatenation with a comma a such: 'Emancipation Day In Texas, Juneteenth National Independence Day'
I am able to 'pop_named' the holiday in the older version, not in the newer with the semicolon seperator:
python3.6/holidays <IP_ADDRESS>:

python 3.10/holidays .25:

I guess technically these are two separate holidays. I can pop_named them individually but it ends up removing both anyways since it pops the date itself.

seems like 'get_names' has changed since version .20 with this code from #991

Hi @jasonalsing,
I agree w/ your point that pop_named() should have kept the second holiday present. We'll spend some time to make sure the fix is ready before the next release.
Thanks for bringing this up!

thanks, that makes sense to keep secondary holidays if one is pop_named()
However, what will the behavior be if both are pop_named() in the concatenated form:
pop_named('Emancipation Day In Texas; Juneteenth National Independence Day')
currently this just fails. Should users of this module expect to have to pop them individually as well? (like two separate pops) can pop_named() method support sending multiple with the HOLIDAY_NAME_DELIMITER included?
Thanks!

Implemented in #1306, in beta now


Add EXPOSE command to Dockerfile.

Closes #63.

@JBYoshi Hi! Sorry it's been a very long time... If you can resolve conflicts, I'll be happy to merge that PR.

@aduermael Done.

thanks! merging now!


KiTTY, a fork of PuTTY adding a whole lot of commonly requested features

Added autoupdate information: cbe4de6ec22cb492fc6d1d9b070ba91a69fabb84

@r15ch13 Uncompressed version is not portable. :(

What do you mean by "not portable"? It seems to install fine.

It stores the setting in the Registry. The portable variant uses file based storage.
To run it in portable mode there has to be a kitty.ini with this settings
[KiTTY]
savemode=dir

But we have to make kitty.ini and Sessions directory persisten.

Change it to the portable version with d30f72fc409133245c9de177bc917df833d58dfa

@r15ch13 That fosshub link is a webpage. I tried using that in the first place and it doesn't work. :/

By opening FossHub it requests this URL (https://www.fosshub.com/gensLink/KiTTY/kitty_portable.exe/51f5253ee472ceb30900012c) to receive a generated download URL as a string. Then JavaScript is used to start the download with this generated URL.
I replicated this behavior with this commit https://github.com/lukesampson/scoop/commit/14a461296bebf18ee137046f43bf8a883cb39b4f so other programs hosted on FossHub can be downloaded.
Hm, http://kitty.9bis.net/ is down now 😕

Awesome, thank you for explaining.  :/ Hope that's a temporary bug or something.


Not able to install

I'm on ChromeOS, I follow the install instructions:
$ curl -sf https://gobinaries.com/tj/staticgen/cmd/staticgen | sh

\x1b[38;5;61m  ==>\x1b[0;00m Downloading github.com/tj/staticgen/cmd/staticgen@master
\x1b[38;5;61m  ==>\x1b[0;00m Resolved version master to v1.0.1
\x1b[38;5;61m  ==>\x1b[0;00m Downloading binary for linux amd64
\x1b[38;5;61m  ==>\x1b[0;00m Installing staticgen to /usr/local/bin
install: cannot change permissions of ‘/usr/local/bin’: Operation not permitted

Alternatively, could there be a way to execute staticgen without installing it? the curl | sh command could execute the binary instead of installing it.

The same happens on GitPod or Google Cloud Shell:
$ curl -sf https://gobinaries.com/tj/staticgen/cmd/staticgen | sh

\x1b[38;5;61m  ==>\x1b[0;00m Downloading github.com/tj/staticgen/cmd/staticgen@master
\x1b[38;5;61m  ==>\x1b[0;00m Resolved version master to v1.0.1
\x1b[38;5;61m  ==>\x1b[0;00m Downloading binary for linux amd64
\x1b[38;5;61m  ==>\x1b[0;00m Installing staticgen to /usr/local/bin
install: cannot create regular file '/usr/local/bin/staticgen': Permission denied

Ahhh try curl -sf https://gobinaries.com/tj/staticgen/cmd/staticgen | sudo sh, I was kind of debating recommending sudo by default but it should at least be documented, or curl -sf https://gobinaries.com/tj/staticgen/cmd/staticgen | PREFIX=~/bin sh for people who aren't into using /usr/local/bin

Thanks, it works.
I tried with sudo before curl, but not before sh
Yes, I would recommend mentioning it in the README, as I expect most users to have to do this.

If you run curl -sf https://gobinaries.com/tj/staticgen/cmd/staticgen | sh it should be ok now, snuck a sudo install ... in there

Oh that's perfect, thanks


csolution option: --context arg (Prio: low)

Note: not an urgent request, just captured for future investigation
The csolution option --context arg seems to have some issues that are perhaps implementation gaps.
1. unclear impact of the option
When using on complex applications, the list commands should consider the context.
Example:
AWS_MQTT_MutualAuth_SW_Framework>csolution list packs -s demo.csolution.yml -c Demo.Debug+AVH

Current result: the --context option has no impact
2. partly specifying context is not supported
For partly specifying a context the tool should iterate about all possible combinations that match with the context option.
Example:
AWS_MQTT_MutualAuth_SW_Framework>csolution list packs -s demo.csolution.yml -c .Debug

Replaced by #854 #823 #824


fix: Start training instead of project update

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.95%. Comparing base (056dd21) to head (43a2c24).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
- Coverage   51.14%   47.95%   -3.19%
==========================================
  Files          40       29      -11
  Lines        2716     1856     -860
==========================================
- Hits         1389      890     -499
+ Misses       1327      966     -361

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


NameError: name 'model' is not defined

I am running my lightGBM model
%%time
y_pred_lgb = np.zeros(len(test_X))
num_round = 1000000
for fold_n, (train_index, valid_index) in enumerate(folds.split(train_X,train_Y)):
    print('Fold', fold_n, 'started at', time.ctime())
    X_train, X_valid = train_X.iloc[train_index], train_X.iloc[valid_index]
    y_train, y_valid = train_Y.iloc[train_index], train_Y.iloc[valid_index]

    train_data = lgb.Dataset(X_train, label=y_train)
    valid_data = lgb.Dataset(X_valid, label=y_valid)

    model = lgb.train(params,train_data,num_round,#change 20 to 2000
                    valid_sets = [train_data, valid_data],verbose_eval=1000,early_stopping_rounds = 3500)##change 10 to 200

    y_pred_lgb += model.predict(test_X, num_iteration=model.best_iteration)/5

when I create a tree explainer as below
explainer = shap.TreeExplainer(model)
I get the error NameError: name 'model' is not defined

@billy-odera Seems to me that this is an issue on the side of your code. Make sure that after loop the model object still exists.
@thatlittleboy Maybe a candidate for closing?

@billy-odera I'll close this issue for now due to staleness, feel free to respond here with an updated reproducible example and I'll be happy to reopen the issue.


waffle.io Badge

Merge this to receive a badge indicating the number of issues in the ready column on your waffle.io board at https://waffle.io/vert-x3/vertx-stack
This was requested by a real person (user alexlehm) on waffle.io, we're not trying to spam you.

sorry, clicked the wrong button on waffle


Response status code 0

Issue Summary
I'm trying to execute this test script and it is always returning a zero error code status. No log, no more information about how to trace it. What can I do?
<?php
// If you are using Composer
require "<MY_PATH>/vendor/autoload.php";

$from = new SendGrid\Email(null, "<MY_FROM>@<EMAIL>");
$subject = "Hello World from the SendGrid PHP Library!";
$to = new SendGrid\Email(null, "<MY_TO>@<EMAIL>");
$content = new SendGrid\Content("text/plain", "Hello, Email!");
$mail = new SendGrid\Mail($from, $subject, $to, $content);

$sg = new \SendGrid("<MY_API_KEY>");

$response = $sg->client->mail()->send()->post($mail);
echo $response->statusCode() . PHP_EOL;
echo $response->body() . PHP_EOL;
echo implode(', ', $response->headers()) . PHP_EOL;

Steps to Reproduce

git clone git@github.com:sendgrid/sendgrid-php.git
write this test PHP script and replace my custom values
execute test PHP script

Technical details:

sendgrid-php Version: master (latest commit: [46f85e6])
PHP Version: 7.0.8 (cli) (built: Jun 26 2016 12:30:44)
SO: OSX 10.11

Hello @davidromani,
I just tried to duplicate your issue (the file is in the root directory):
<?php
require "vendor/autoload.php";

$from = new SendGrid\Email(null, "dx@sendgrid.com");
$subject = "Hello World from the SendGrid PHP Library!";
$to = new SendGrid\Email(null, "elmer@sendgrid.com");
$content = new SendGrid\Content("text/plain", "Hello, Email!");
$mail = new SendGrid\Mail($from, $subject, $to, $content);

$apiKey = getenv('SENDGRID_API_KEY');
$sg = new \SendGrid($apiKey);

$response = $sg->client->mail()->send()->post($mail);
echo $response->statusCode() . PHP_EOL;
echo $response->body() . PHP_EOL;
echo implode(', ', $response->headers()) . PHP_EOL;

And my response was:
202

, X-Frame-Options: DENY3RZOp6TPvS0PXewf-8

I am using PHP 7.0.14 and I also tested with version 5.6.14 with the same result.

Now is working... thanks for you answer. I don't understand why now is working, but thanks again.

Same problem again :-(

@thinkingserious why you don't return more explicit error messages? It's very difficult to understand what's happening...

Hello @davidromani,
I'm not sure what is happening, but it seems you are receiving that status code because our servers did not get your message, see: http://stackoverflow.com/questions/872206/http-status-code-0-what-does-this-mean-in-ms-xmlhttp
We don't actually send a status code 0 back. Here are the status codes we support: https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html
I hope that helps, thanks!

@thinkingserious do you have any curl command to try the same action (send a test email) at a lower level? I understand that sendgrid-php library relies on php-curl extension, right?

@davidromani,
Here you go: https://sendgrid.com/docs/Classroom/Send/v3_Mail_Send/curl_examples.html

@thinkingserious I've just tried to execute "Hello, World!" example with my API Key and it works perfectly.
Same machine, same environment and same API key. So maybe, I need to check php-curl extension version, compile config params...?

Hi @davidromani,
That sounds like a solid approach. Please do share what you find. Thanks!

My phpinfo config related with php-curl extension is:

Can anybody test a similar environment?

@thinkingserious I've testet with another machine (Ubuntu + PHP 5.6) and it works perfect. Maybe is a problem related with this PHP 7.0 distro https://php-osx.liip.ch
Do you want to close this issue and I will open another one more specific?

Hi @davidromani,
I think not deleting this thread would be sufficient, so that those who search for status code 0 issue will find it.
Thank you for taking the time to report your findings!

Same issue here on IIS

Hello @sadranyi,
Have you checked your php.ini to ensure you have php-curl enabled?
With Best Regards,
Elmer

Yes I have
On 2 May 2018 at 17:12, Elmer Thomas<EMAIL_ADDRESS>wrote:

Hello @sadranyi https://github.com/sadranyi,
Have you checked your php.ini to ensure you have php-curl enabled?
With Best Regards,
Elmer
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sendgrid/sendgrid-php/issues/348#issuecomment-386158956,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAid3DsnIaSNa83-bbL7OMLpjfEAPhTcks5tuktxgaJpZM4LpqJ_
.

Hi @sadranyi
Are you running a Windows PHP distribution? If so read this article on how to fix it. Have a nice evening!

yes am running a windows distro in IIS.
Will look at the link
On 3 May 2018 at 15:02, Martijn Melchers<EMAIL_ADDRESS>wrote:

Hi @sadranyi https://github.com/sadranyi
Are you running a Windows PHP distribution? If so read this
https://snippets.webaware.com.au/howto/stop-turning-off-curlopt_ssl_verifypeer-and-fix-your-php-config/
article on how to fix it. Have a nice evening!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sendgrid/sendgrid-php/issues/348#issuecomment-386450869,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAid3J3PyPH9yWqKzogeGZPflCvi5NT0ks5tu359gaJpZM4LpqJ_
.

It works fine if i deploy in Xampp, but returns 0 when i run the same code
in IIS
On 3 May 2018 at 15:17, Samuel Adranyi<EMAIL_ADDRESS>wrote:

yes am running a windows distro in IIS.
Will look at the link
On 3 May 2018 at 15:02, Martijn Melchers<EMAIL_ADDRESS>wrote:

Hi @sadranyi https://github.com/sadranyi
Are you running a Windows PHP distribution? If so read this
https://snippets.webaware.com.au/howto/stop-turning-off-curlopt_ssl_verifypeer-and-fix-your-php-config/
article on how to fix it. Have a nice evening!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sendgrid/sendgrid-php/issues/348#issuecomment-386450869,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAid3J3PyPH9yWqKzogeGZPflCvi5NT0ks5tu359gaJpZM4LpqJ_
.

@sadranyi,
Have you tried the steps in the link provided by @martijnmelchers?

Hope this will help: https://github.com/sendgrid/php-http-client/pull/99

That's awesome @alextech, thanks!

Has the same issue and just needed to download the latest cacert.pem file and making sure the php.ini file referenced it properly.

I already sent emaill successfully yesterday. But today it responsed that:
object(SendGrid\Response)#17 (3) {
["statusCode":protected]=>
int(0)
["body":protected]=>
string(0) ""
["headers":protected]=>
array(1) {
[0]=>
string(0) ""
}
}
Can anyone help me ?

Hello @congnghiakhiem,
I would audit your system to find out what changed from the day it stopped working. Perhaps an upgrade, for example?

Thank @thinkingserious
I have changed to use python, and sent +20k mails successfully. Therefore, I won't use php again.

Same problem here too.
    public function send($fromName, $fromEmail, $subject, $toName, $toEmail, $txtContent, $htmlContent) {
        $email = new \SendGrid\Mail\Mail();
        $email->setFrom($fromEmail, $fromName);
        $email->setSubject($subject);
        $email->addTo($toEmail, $toName);
        $email->addContent("text/plain", $txtContent);
        $email->addContent("text/html", $htmlContent);

        $sendgrid = new \SendGrid($this->container->settings["sendgrid"]["token"]);
        $this->container->logger->info("Sending email to: {$toEmail} ...");

        $response = $sendgrid->send($email);
        $this->container->logger->info(json_encode($response));

        return $response;
    }

$response is empty. All data passed into the function I created is correct. Been stuck on this for days now.

hello guy!
How to get status when sendmail in laravel?

@martijnmelchers link did it for me


pytest: 3.2.3 -> 3.2.5

Motivation for this change
Update of pytest: https://github.com/pytest-dev/pytest/releases/tag/3.2.5
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thank you! I've merged this into staging because it rebuilds a lot of packages, it should reach master in a few days, and the unstable channel a couple of days later.


Question for other voices....

Is it possible to use voices from this page:
http://openslr.org/94/
To train model and use it in piper, if so could it be possible to provide how to do that?
Many thanks for guidance 😃

Could it be possible for you to provide me step-by-step instruction how to train MPL Polish model with high quality?
I have found on internet some polish AI generated voice for some tv shows or movies that sound very good but do not know how these guys do it....


Throws SqlException: Login failed for user '....'.

I tried using this extension. I included a copy of  my code, see screenshot, it throws user login failed, what am I doing wrong. please contact me on<EMAIL_ADDRESS>

Take a look at this issue.
Do you have installed System.Data.SqlClient library in the project.
Also try setting Persist Security Info to  true in ConnectionString.
Otherwise could you make a sample project where the problem is manifesting and zip it on Drive or Dropbox and send a link.

Huge Huge Thanks. persist security info was the key. It Works.

You are welcome.

Hi Borris, How does BulkUpdate Work, do you need first to get the existing entry, make the changes, add it to list, and at the end of the work pass it in to BulkUpdate. Or can you just pass in a list of entities and the computer figures it out by itself. Please clarify

Update is done by matching PrimaryKey, so if you already know/have PKs than just pass that list.
Otherwise you need to do Select to get Entites with their PK.


Add tests to check slit_pore_dim argument and ValueError messages

Add unit tests to improve code coverage.

Codecov Report

Merging #32 (26677bc) into master (4e36fde) will increase coverage by 8.14%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   87.80%   95.95%   +8.14%
==========================================
  Files           4        4
  Lines         164      173       +9
==========================================
+ Hits          144      166      +22
+ Misses         20        7      -13

Impacted Files
Coverage Δ

porebuilder/tests/test_porebuilder.py
95.31% <88.88%> (-1.06%)
:arrow_down:

porebuilder/porebuilder.py
97.72% <0.00%> (+15.90%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e36fde...26677bc. Read the comment docs.

Codecov Report

Merging #32 (26677bc) into master (4e36fde) will increase coverage by 8.14%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   87.80%   95.95%   +8.14%
==========================================
  Files           4        4
  Lines         164      173       +9
==========================================
+ Hits          144      166      +22
+ Misses         20        7      -13

Impacted Files
Coverage Δ

porebuilder/tests/test_porebuilder.py
95.31% <88.88%> (-1.06%)
:arrow_down:

porebuilder/porebuilder.py
97.72% <0.00%> (+15.90%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e36fde...26677bc. Read the comment docs.


Conversion script falling over SABnzbd

Previous issue completely resolved, and for some reason SABnzbd has now begun to fall over. It just seemed to stop working, and i'm not too sure why. This was on an older build prior to new branch being added so doubt that's the issue. I updated to ensure no older problems, but nothing improved.
This is the output i'm receiving:

> 2020-10-04 15:13:12 - resources.mediaprocessor - INFO - Starting conversion.
> 2020-10-04 15:13:12 - resources.mediaprocessor - INFO - FFmpeg command:
> 2020-10-04 15:13:12 - resources.mediaprocessor - INFO - ======================
> 2020-10-04 15:13:12 - resources.mediaprocessor - INFO - C:\FFmpeg\bin\ffmpeg.exe -hwaccel dxva2 -i C:\Users\server\Downloads\complete\Brassic.S01E04.Episode.4.1080p.AMZN.WEB-DL.DD+2.0.H.264-Cinefeel\cd63ae5d98499b002713b092debe9c03.mkv.original -vcodec None -map 0:0 -field_order progressive -crf 20 -metadata:s:v BPS=6580000 -metadata:s:v BPS-eng=6580000 -metadata:s:v title=FHD -c:a:0 ac3 -map 0:1 -ac:a:0 2 -b:a:0 256k -metadata:s:a:0 BPS=256000 -metadata:s:a:0 BPS-eng=256000 -metadata:s:a:0 title=Stereo -metadata:s:a:0 language=eng -disposition:a:0 +default-dub-original-comment-lyrics-karaoke-forced-hearing_impaired-visual_impaired-captions -f matroska -threads 0 -metadata:g encoding_tool=SMA -y C:\Users\server\Downloads\complete\Brassic.S01E04.Episode.4.1080p.AMZN.WEB-DL.DD+2.0.H.264-Cinefeel\cd63ae5d98499b002713b092debe9c03.mkv
> 2020-10-04 15:13:12 - resources.mediaprocessor - INFO - ======================
> 0%
> 2020-10-04 15:13:12 - resources.mediaprocessor - ERROR - Unexpected exception during conversion.
> Traceback (most recent call last):
> File "C:\Users\server\Downloads\sickbeard_mp4_automator-master\resources\mediaprocessor.py", line 1487, in convert
> for timecode, debug in conv:
> File "C:\Users\server\Downloads\sickbeard_mp4_automator-master\converter\__init__.py", line 308, in convert
> for timecode, debug in self.ffmpeg.convert(outfile, optlist,
> File "C:\Users\server\Downloads\sickbeard_mp4_automator-master\converter\ffmpeg.py", line 688, in convert
> cmd = ' '.join(cmds)
> TypeError: sequence item 6: expected str instance, NoneType found
> 2020-10-04 15:13:12 - SABPostProcess - ERROR - Converting file failed C:\Users\server\Downloads\complete\Brassic.S01E04.Episode.4.1080p.AMZN.WEB-DL.DD+2.0.H.264-Cinefeel\cd63ae5d98499b002713b092debe9c03.mkv.
> 2020-10-04 15:13:12 - SABPostProcess - ERROR - No valid files found for conversion in download, aborting.
> 2020-10-04 15:13:12 - SABPostProcess - ERROR - Unexpected exception.
> Traceback (most recent call last):
> File "C:\Users\server\Downloads\sickbeard_mp4_automator-master\SABPostProcess.py", line 81, in <module>
> sys.exit(1)
> SystemExit: 1

Updated FFmpeg as well just incase. Attaching relevant section below incase there's anything odd. Only thing I changed recently was adding aac to audio codec however, and it was working fine after that briefly.

ffmpeg = C:\FFmpeg\bin\ffmpeg.exe
ffprobe = C:\FFmpeg\bin\ffprobe.exe
threads = 0
hwaccels = dxva2, cuvid, qsv, d3d11va, vaapi
hwaccel-decoders = h264_cuvid, mjpeg_cuvid, mpeg1_cuvid, mpeg2_cuvid, mpeg4_cuvid, vc1_cuvid, hevc_qsv, h264_qsv, hevc_vaapi, h264_vaapi
hwdevices = vaapi:/dev/dri/renderD128
hwaccel-output-format = vaapi:vaapi
output-directory =
output-format = mkv
output-extension = mkv
temp-extension =
minimum-size = 0
ignored-extensions = nfo, ds_store
copy-to =
move-to =
delete-original = True
sort-streams = True
process-same-extensions = True
force-convert = False
post-process = False
detailed-progress = True
preopts =
postopts =
wait-post-process = False

[Video]
codec = hevc, h265, x265
max-bitrate = 0
crf = 20
crf-profiles =
codec-parameters =
max-width = 0
profile =
max-level = 0.0
pix-fmt =
filter =
force-filter = False
postopts = -preset,veryfast
dynamic-parameters = False
preset =

[Audio]
codec = ac3, aac
languages = eng
default-language = eng
first-stream-of-language = True
allow-language-relax = False
channel-bitrate = 128
max-bitrate = 0
max-channels = 0
prefer-more-channels = True
default-more-channels = True
filter =
force-filter = False
sample-rates =
copy-original = False
aac-adtstoasc = False
ignore-truehd =
ignored-dispositions =
unique-dispositions = False

[Universal Audio]
codec = ac3
channel-bitrate = 128
first-stream-only = False
move-after = False
filter =
force-filter = False

[SABNZBD]
convert = True
sickbeard-category = sickbeard
sickrage-category = sickrage
couchpotato-category = couchpotato
sonarr-category = sonarr
radarr-category = radarr
bypass-category = bypass
output-directory =
path-mapping =

Hrm, this is also happening for my previously working qbittorrent setup you added the path mapping options in for earlier. Which is a completely different install and script being used inside the VM. Gives the same error code.
When trying to do a manual.py test I am getting the same errors as well.

Set you video codec option to
codec = h265, x265, hevc

Actually, that script should have accounted for that
9db826be5eac062447058c2a854e90e5f01d46ac
This update should fix your old way of doing things
This was always a weird issue since ffmpeg uses h265 as its coding naming convention but ffprobe reports hevc. I added wrapper classes that tried to make both work but the wrapper for hevc -> h265 was inheriting wrong
Now both naming conventions should be valid

Oh man you're totally right I kept thinking nothing changed and it just suddenly stopped working. But I believe it was because I swapped it round from 'h265, x265, hevc' to 'hevc, h265, x265' after some previous discussion.
It's currently running the post process script right now so hopefully good to go again. Sorry for all the hassles...
Also worth noting, any plans to push https://github.com/mdhiggins/sickbeard_mp4_automator/issues/1332 into main? My SABnzbd also only shows '===============' unless I replace the code you mentioned above. Running 3.0.2 SABnzbd. Will make myself a note for updates to reapply the fix if it will cause issues for other users.
Closing this as it appears good to go again thanks once again...

No plans cause people didn't like that it clogged up the log files. Can't please everyone lol but feel free to make that edit

Ahaha gotcha.


fix checkbox and radio button click issue

This PR fixes #14964
use the standard way of adding label for checkbox and radio button. https://www.w3schools.com/tags/att_input_type_radio.asp

Pull Request Test Coverage Report for Build 716105591

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.009%) to 43.562%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
3
72.99%

extensions/notebook/src/common/ports.ts
4
74.14%

Totals

Change from base Build 713367034:
-0.009%

Covered Lines:
26122

Relevant Lines:
54815

💛  - Coveralls