Remove old font awesome

Checklist

[x] I've run yarn run webpack:build:main from the root directory to see that the project builds without errors.
[x] I've removed unnecessary whitespace changes.
[x]I've updated the documentation and models if necessary.
[ ] I've tested the changes and all related features on the Artemis test server

Motivation and Context
At the moment we include both Font Awesome 4.0 and Font Awesome 5.0. This makes the bundle bigger, slower to load, and heavier on the network (thus reducing server performance).
With this PR I drop all the old icons, and use only the newer <fa-icon>  tag
Description
I have used these guides:

https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4
https://fontawesome.com/how-to-use/on-the-web/using-with/angular

The advantages of this new approach:

Code is cleaner. Instead of using <span> and <i> for icons, we use only <fa-icon> now.
De-duplication of the code: we remove one of two libraries that do the same thing
Less dependencies -> smaller bundle -> improved performances
The new library support tree-shake, thus including only used icons, and not all of them as the older one
There is no more confusion which icons can be used. you just need to check the icon list: https://fontawesome.com/icons

Good work. While the changes look fine in general, please definitely deploy the changes to the test server and make sure everything is correct here!


Add interface for Temporal class 🔧

Hi @cappuc!
To be able to use dependency injection instead of facade and test classes in isolation we need an interface for the main Temporal class.
I haven't added types for those methods since all of them return concrete classes and that would have been a BC break (used generic object instead).

Why is it a problem to set return types to the builder classes?
Do you need to override the builder classes?

@cappuc in the future, you might return interfaces instead of concrete classes, like it was done in the original Temporal SDK (for example WorkflowRunInterface). This way you won't need to specify concretes in your implementation, so you can unit test it with your own fakes without pain. 🙂

Changing the return type from object to an interface is a breaking change anyway, so I prefer to set the return type explicit.
Right now the only methods available returns the builder classes and I don't see the need to override them in the near feature.
So I think it's better to specify the return type because it improves DX (telling the correct return type to IDE) and if we need to change the return types, the required changed in the customers applications can be detected with a static analysis tool

In this case, unit testing in isolation won't be possible, since concretes are returned, and you'll need to implement your fake using these concretes.
I think I can create an interface for each class and change these return types to make it unit-testable, but you'll need to ship it with a warning for others that the new release contains BC. Would you want to go this way?

Can you post an example?
I can't understand why you need to mock the builder classes.
In order to unit test an Activity class, you can simply create an instance (without the ActivityBuilder) and test the method call.
To unit test Workflow class, you can build the workflow with the standard WorkflowBuilder, execute it through a temporal server, and check the result (if you need to mock activities result, you can with Temporal::fake() and Temporal::mockActivity()

@cappuc what you're describing are feature tests since it executes directly on the infrastructure. I mean the tests that are testing my code in isolation (coverage, "class configuration" logic) and fully independent from the framework, database, or Temporal itself.

It's way better now, although not ideal for my case since all the builder fakes would need to be coupled to the concretes, but as you mentioned that would require a review of all used classes and return types in the package, so maybe in the future. :)
Thank you for the effort!


⚠ Samsung has degraded performance

In e14603d, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 6014 ms

Resolved: Samsung performance has improved in 4f23e97.


fix(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cbr/ibm (source)
module
minor
1.27.0 -> 1.28.1

terraform-ibm-modules/kms-all-inclusive/ibm (source)
module
patch
4.16.4 -> 4.16.7

terraform-ibm-modules/kms-all-inclusive/ibm (source)
module
minor
4.15.13 -> 4.16.7

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (terraform-ibm-modules/cbr/ibm)
v1.28.1
Compare Source
Bug Fixes

deps: updated required provider version to >= 1.70.0 to pick up the fix for this provider issue: [ibm_cbr_zone] Error: Provider produced inconsistent result after apply(#556) (93ea730)

v1.28.0
Compare Source
Features

added two new inputs to the fscloud profile: allow_vpcs_to_iam_groups and allow_vpcs_to_iam_access_management. By setting these to true, the following FSCloud SCC rules will pass:- Check whether IAM access management can be accessed only thorugh a private endpoint (Context-based restrictions or service) and allowed IPs<br>- Check whether IAM access groups can be accessed only through a private endpoint (Context-based restrictions or service) and allowed IPs` (#548) (10c5bc9)

terraform-ibm-modules/terraform-ibm-kms-all-inclusive (terraform-ibm-modules/kms-all-inclusive/ibm)
v4.16.7
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/key-protect/ibm to v2.8.7 (#570) (5b3235b)

v4.16.6
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cbr/ibm to v1.28.1 (#574) (e9572fc)

v4.16.5
Compare Source
Bug Fixes

update to SCC profile to CIS IBM Cloud Foundations Benchmark v1.1.0 (#551) (80768c0)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

The KMS bump requires code changes which will be completed in a separate PR.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 3.19.2 :tada:
The release is available on:

GitHub release
v3.19.2

Your semantic-release bot :package::rocket:


Wool in the Sink

Running modpack Expedition.  When right-clicking colored wool to the Sink it returns invalid number of white wool.  Specifically it takes one block from the colored stack and returns the quantity of the colored stack as white wool blocks.  For example if you have 3 brown wool, right click on the sink, you now have 2 brown wool and receive 2 white wool.

Also noticed receiving an extra white wool after it is "cleaned" as mentioned above.


Updated dmlc-core submodule blocks R CRAN submission

With https://github.com/dmlc/xgboost/pull/3221, we have dmlc-core updated.
This change updated several headers, thus introduces the following NOTE to the CRAN check:
  Files which contain pragma(s) suppressing diagnostics:
    'src/dmlc-core/include/dmlc/any.h'
    'src/dmlc-core/include/dmlc/concurrency.h'
    'src/dmlc-core/include/dmlc/concurrentqueue.h'
    'src/dmlc-core/include/dmlc/logging.h'

I'm submitting R package 0.71.1 to CRAN with the old dmlc-core headers. However it is just a one-time compromise.
@hcho3  Do you see these pragmas temporarily or stable? Thanks.

@hetong007 The updated dmlc-core has an important usability improvement for R users (see #2849), so we should find a way to keep the latest dmlc-core.
As for the pragmas, here are the PRs that introduced them: #236, #357, #243. They all appear to be there to remove gratuitous compiler warnings. Does CRAN completely disallow removal of warnings?

@hetong007 And I understand that MXNet also has R binding, and MXNet I think has pretty recent version of dmlc-core. We should find out how MXNet-R gets around this problem.

I am with the latest dmlc-core, just the pragmas may block CRAN submission in the future.
Now CRAN mark pragmas suppressing diagnostics as NOTE, but still won't allow a submission with this NOTE.
On the MXNet side, the R package has never been submitted to CRAN, since it actually has other severe issues (GPU compatibility, etc).

I see two ways to move forward:

Submit a PR to remove pragma's. This may increase gratuitous compiler warnings on some platforms.

OR

Write a script that removes pragma's before CRAN submission.

As an aside, will it be possible to submit GPU enabled binaries to CRAN? We are now producing linux binaries that can run seamlessly on GPU or non-GPU systems via Jenkins CI.

@RAMitchell To have a GPU version submitted to CRAN, we may need to:

Have the GPU version as a separate package, i.e. xgboost-gpu
Prepare pre-built windows .dll and include in the submission package
make on linux as usual, and make on windows linking to the prepared .dll file(s)
And, most importantly, pass CRAN check on solaris (the latest 0.71.1 just got an error).

This is just a sketch, and I've no experience submitting packages with pre-built binaries to CRAN.

I'd like to avoid having separate packages. GPU compiled binaries run safely on systems without a GPU - they will only crash if you try to use a GPU algorithm.
We can produce windows binaries easily enough when we get Jenkins CI running for windows.
@terrytangyuan maybe you can give some advice here. I see H2O4GPU passes all of the cran checks: https://cran.r-project.org/web/checks/check_results_h2o4gpu.html. Surely we are not compiling GPU binaries for solaris?

@hetong007 I looked at the five headers and all the offending #pragma's start with one of the following keywords:
#pragma GCC diagnostic ...
#pragma clang diagnostic ...
#pragma warning ...

It should be possible to write a little script that removes all lines containing these keywords. The script can be run every time make Rpack is run.

With #3329, the command R CMD CHECK --as-cran xgboost_0.71.1.tar.gz now passes.

It seems the maintainance effort will be minor. Thanks!
Generally speaking, the maintainance effort for the script depends on the development in dmlc-core, and how often we update it. Of course another factor is how often CRAN updates its policy :)
Hope all these are at a manageable pace.

I don't think we'd update the dmlc-core submodule too often. Maybe we can update it when we reach 1.0. The script would only need to be revised when someone submits a PR to update the submodule.

@RAMitchell h2o4gpu is a bit different since it doesn't include binaries when submitting to CRAN. Users are responsible to install the correct wheels and tests on CRAN are basically skipped.


Support multiple MapFrom/MapTo with context

I have added the ability to create multiple MapFrom or MapTo on the same property in order to be able to use different contexts.
this pull request fix this issue : https://github.com/jolicode/automapper/issues/159

Closing, as explained in #159


Bulk validation fixes tableSyntaxInvalid

Global effort to fix build validation errors
@lindalu-MSFT
The warnings will be addressed in another PR!
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!

Docs Build status updates of commit f78af35:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/UCWA/reportMediaDiagnostics_ref.md
:warning:Warning

Details

Skype/UCWA/MimeLibrary.md
:bulb:Suggestion

Details

Skype/UCWA/derivedMessaging_ref.md
:bulb:Suggestion

Details

Skype/UCWA/myOrganizationGroup_ref.md
:bulb:Suggestion

Details

Skype/UCWA/myPrivacyRelationship_ref.md
:bulb:Suggestion

Details

Skype/UCWA/myPrivacyRelationships_ref.md
:bulb:Suggestion

Details

Skype/UCWA/policies_ref.md
:bulb:Suggestion

Details

Skype/UCWA/presenceSubscriptionMemberships_ref.md
:bulb:Suggestion

Details

Skype/UCWA/replacesAudioVideo_ref.md
:bulb:Suggestion

Details

Skype/UCWA/reportMyNetwork_ref.md
:bulb:Suggestion

Details

Skype/UCWA/simultaneousRingToTeam_ref.md
:bulb:Suggestion

Details

Skype/UCWA/startAudio_ref.md
:bulb:Suggestion

Details

Skype/UCWA/startEmergencyCall_ref.md
:bulb:Suggestion

Details

Skype/UCWA/startMessaging_ref.md
:bulb:Suggestion

Details

Skype/UCWA/unansweredCallSettings_ref.md
:bulb:Suggestion

Details

Skype/UCWA/contactLocation_ref.md
:white_check_mark:Succeeded

Skype/UCWA/delegatesGroup_ref.md
:white_check_mark:Succeeded

Skype/UCWA/from_ref.md
:white_check_mark:Succeeded

Skype/UCWA/messageTranscript_ref.md
:white_check_mark:Succeeded

Skype/UCWA/participantDataCollaboration_ref.md
:white_check_mark:Succeeded

Skype/UCWA/presenceSubscription_ref.md
:white_check_mark:Succeeded

Skype/UCWA/replacesPhoneAudio_ref.md
:white_check_mark:Succeeded

Skype/UCWA/reportMediaDiagnostics_ref.md

Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/MimeLibrary.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/derivedMessaging_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/myOrganizationGroup_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/myPrivacyRelationship_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/myPrivacyRelationships_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/policies_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/presenceSubscriptionMemberships_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/replacesAudioVideo_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/reportMyNetwork_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/simultaneousRingToTeam_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/startAudio_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/startEmergencyCall_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/startMessaging_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCWA/unansweredCallSettings_ref.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Installing Extensions Manually documentation enhancement

It took me while to find out, how to register a namespace for a module.
On this page  there is some code:
[     'aliases' => [         '@myext' => '@vendor/mycompany/myext',     ], ]
you may change it to something more adaptable
[     'aliases' => [         '@my/namespace' => '@app/extensions/yii2-user/src',     ], ]

ok, forget it. I found it elsewhere in the docs:


LunatriusCore, Schematica and ForgeModLoader(FML)

Hello,
I want to add LunatriusCore and Schematica to ForgeModLoader(FML) since FML is lighter than Forge. Can it be done? If I try to add LunatriusCore and Schematica to mods folder it says "This mod can not be found: Forge: Minimum version required is <IP_ADDRESS>7" even though I put forge <IP_ADDRESS>7 and even higher versions in the mods folder. Can I make Schematica work with Forge FML? Bug Report: http://pastebin.com/Yi2UwDXu

I think you can't since it's stated in mods.io that Schematica needs Minecraft Forge to work, not FML.

FML is no longer developed separately and has been merged directly into Forge. The older versions still require Forge, because FML does not offer the hooks required by Schematica.


Marine roles shouldn't spawn in with gear included

dupe of https://github.com/CM-14/CM-14/issues/1571


Differentiate between scalar and angle types.

If the templates allowed for a separate angle type then various functions such as matrix_rotation_axis_angle would be much more useful for integer matrix types.

Sorry for the delay, I didn't receive an e-mail notification.
Could you provide a use case?   Also, are you requesting this for the master branch (CML1), or CML2?
Thanks!

Sure, so as I mentioned, the function matrix_rotation_axis_angle is what I'm using in particular but I'm sure theres other rotation functions with the same problem. The issue appears to be that you are using the scalar type of the matrix as the angle's type as well. If the matrix uses an integer scalar type, this renders these functions essentially unusable.
cml::vector3i axis = {0,0,1};
cml::matrix33i_c m;
cml::matrix_rotation_axis_angle(m, axis, cml::rad(90));

Adding an extra template parameter would probably be sufficient.
template < typename E, class A, class B, class L, class VecT, typename AngleT > void
matrix_rotation_axis_angle(matrix<E,A,B,L>& m, const VecT& axis, AngleT angle)

A rotation matrix must have a determinant of 1 (or -1 if you include reflections), which limits the entries of an integral matrix to +/-1 and 0.  Is this really what you are looking for?

I'm aware, thats exactly what I'm using it for.
However, this particular edge case only serves to hi-light a larger issue. Angles and scalars are not the same thing and should be in my opinion therefore served by separate types.

As long as you know what you are getting into. :-)
The CML2 version of matrix_rotation_axis_angle() allows for any integral or float angle type that has a std::numeric_limits<> specialization, and that can be converted to the matrix scalar type.  This should allow for integral matrices and floating-point angles, but that use case has never come up, so I've not tested it.
Here is the signature for good measure:
template<class Sub, class QSub, class E> void matrix_rotation_axis_angle(
  writable_matrix<Sub>& m, const readable_vector<QSub>& axis, const E& angle);

I haven't ported every CML1 function to CML2 yet, but if you'd like to give it a try and let me know which functions you need implemented, I can let you know if time would permit me to get them done.

Apologies for the delay, this new function looks promising; I will test it when I can but as long as the two types are separate it should in theory solve the problem I was having. Thanks!

No worries!  I am going to close this issue, but please do open another if you have any more questions or problems.

Just an update; I attempted to install cml2; however it required disabling an error in the cmake file stating that my compiler was not recognized. Following this, there was no option to make install, so I had to copy the folder directly. It then failed to compile due to various static_asserts when I included it. I take it clang/osx is not supported at this time. :)

Doh!   I don't have OS/X to test on, but I can see what happens with clang on Windows (and probably Linux).  "make install" isn't done yet, as I use CML2 in my production code directly from a git clone.  I'm willing to port over the "make install" step, but I can't guarantee it will work for OS/X.
Let me know what clang version you are using, and I will give it a try.  I will also open a new issue so we can track this new development...

Sounds great, thanks!
I'm using version 7.0.2.
These were the errors I encountered when #including <cml/cml.h> if it helps any:
https://gist.github.com/Segmented/5ecb34170679cc93d1047f6d79c3c5ab
I can run the tests for you as well if you want, whenever the makefile target for those exists or if theres another way to run them heh :)

Thanks, the error messages were helpful, particularly because none were "showstoppers".  In case you didn't get a message about it, I've created a new issue for updating CML2 to build with clang/XCode (#6).  Let's continue there.

@Segmented I'm pinging you here, as I don't know if pinging you from #6 actually works.  Let me know whenever you have a change if the latest changes have resolved those errors.

Unfortunately, while it now accepts the int/float combo, matrix_rotation_axis_angle yields an incorrect matrix. I believe this to be due to the traits structure treating the angle parameter as an integer type in cos and sin. For example, if line 56 in traits.h was instead:
template <typename AngleT>
static inline value_type cos(const AngleT& v)

Then the correct matrix is produced for me.

@Segmented, please give the latest commit a try when you have a chance (https://github.com/demianmnave/CML/commit/ce7ccec750348c0c7fceb9fb042400a212eaee79), and let me know how it works for you.

Seems to work for me. Thanks!

Awesome, thanks for your patience, and for spurring a pretty important update.  Please let me know if you have any more questions or problems.

Kamino cloned this issue to demianmnave/CML


time:timer stop panic

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?
https://play.golang.org/

`package main
import "time"
import "fmt"
func main() {
timer1 := time.NewTimer(time.Second * 2)
<-timer1.C
fmt.Println("Timer 1 expired")
timer2 := time.NewTimer(time.Second)
go func() {
	stop2 := timer2.Stop()
	if stop2 {
		fmt.Println("Timer 2 stopped")

	}

}()
<-timer2.C
fmt.Println("Timer 2 expired")
time.Sleep(time.Second * 5)

}`
`Timer 1 expired
Timer 2 stopped
fatal error: all goroutines are asleep - deadlock!
goroutine 1 [chan receive]:
main.main()
/tmp/sandbox826749351/main.go:20 +0x1e0
Program exited.`
example：
https://gobyexample.com/timers

You stopped the timer, and then your main goroutine is sitting there waiting for a value that will never come, because the timer has been stopped.  I don't see a bug here.
If you have questions about how this works, please don't use the issue tracker.  Please see https://golang.org/wiki/Questions .  Thanks.

This command has been run, what the thread is still waiting
fmt.Println("Timer 2 expired")

See previous comment: this is not the place for questions.  Thanks.
As I said, the thread is waiting for a value that will never be sent.  The program is deadlocked.


🐛 Knip does not resolve package.json exports quite correctly

Prerequisites

[X] I'm using the latest version
[X] I've read the relevant documentation
[X] I've searched for existing issues
[X] I've checked the list of known issues
[X] I've read the issue reproduction guide

Reproduction url
https://github.com/maastrich/repro/pull/2
Reproduction access

[X] I've made sure the reproduction is publicly accessible

Description of the issue
First, thanks for the amazing tool, it's really impressive how quick and effective knip is 👏
When setting up exports using glob syntax in the package.json, typescript can resolve * to be either a path part or multiple path part:
"./*": "./src/public/*/index.ts" // can resolve to
   -> "./src/public/foo/bar/index.ts"
   -> "./src/public/baz/index.ts"

but knip doesn't
For the moment I've found a workaround where I add this in my package.json so knip can resolve le path
(leaving both as typescript resolve the first one and knip the second)
"./*": "./src/public/*/index.ts",
+ "./**": "./src/public/**/index.ts",

Thanks for report. That's correct according to the Node.js docs and honestly I'm a bit baffled by it:

* maps expose nested subpaths as it is a string replacement syntax only.
All instances of * on the right hand side will then be replaced with this value, including if it contains any / separators.

From a Knip perspective, the issues I have with this:

a lot more files might become entry files and this isn't great in terms of finding unused exports (which aren't reported by default in entry files)
unsure about the performance penalty, Knip has to traverse the fs and find all matching files (a runtime does string replacement first and then starts resolution).
people who'd be baffled like me might unintentionally use * thinking it actually means * in glob pattern matching, with subtly unexpected results both in exposed exported paths as in Knip analysis.

What about this workaround, would this work:
"./*": "./src/public/**/index.ts",

Just curious, not saying it's a solution.

Just saying, the generic (and intended) solution to this is to add entry patterns to your knip config manually:
{
  "entry": ["./src/public/{a,b}/index.ts"]
}

At this point this feels better than rewriting * to globstar ** and marking "everything" as an entry file (the node option), even though it goes 100% against the "zero-config aim".

Understood, but this is a good example of static analysis versus runtime behavior and there are tradeoffs to be considered.


DefaultCommitTest.java:73-75: Checkstyle: enforce use of...

The puzzle 29-71e94be2 from #29 has to be resolved:
https://github.com/llorllale/gitlog-maven-plugin/blob/996b21a631c76c7ea3c852ee8f979a9ffcc101b8/src/test/java/org/llorllale/mvn/plgn/gitlog/DefaultCommitTest.java#L73-L75
The puzzle was created by George Aristy on 07-Feb-18.
Estimate: 30 minutes, role: IMP.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

WriteTag seems broken.
This configuration:
    <module name="WriteTag">
      <property name="tag" value="@since"/>
      <property name="tagFormat" value="[0-9]+\.[0-9]+\.[0-9]+"/>
      <property name="tagSeverity" value="ignore"/>
    </module>

... breaks because of the @todo in the following:
/**
 * Tests for {@link DefaultCommit}.
 *
 * @author George Aristy<EMAIL_ADDRESS> * @since 0.1.0
 * @checkstyle MultipleStringLiterals (500 lines)
 * @todo #34:30min Missing javadoc tag @since check on methods because the WriteTag
 *  check also blindly enforces the rule on overriden methods (@Override). This behavior
 *  is not acceptable.
 */
public final class DefaultCommitTest {


Update vhd-util URL

URL for vhd-util was broken, updated accordingly.

Are you that it is broken? I mean, I just tested http://download.cloudstack.org/tools/vhd-util, and it is working here.

Sure it has. However, the e-mail mentions download.cloud.com and not download.cloudstack.org. The last one is owned by ACS community, while the first one is still owned by Citrix and does not represents ACS anymore.


Sudden 404 upon logging in

Started happening today.  Looks like the /profiles URL might have changed on the API.  I can receive messages still, but the profile view always returns a 404.
@RobbieTechie you seem to be the most familiar with the current state of the app, any insight here?  Hoping this may be as easy as changing a URL on the controllers.

@kusaa I thought the same thing about the API changes, but I'm not certain of the cause. However, I was able to get the app working again. Within the fuckr.js file, search for the following line (roughly around line 603 for me):
$http.get(API_URL + "locations/" + geohash + "/profiles/?" + (_.compact(filterParams).join('&'))).then(function(response) {
Replace that line with the following:
$http.get("https://grindr.mobi/v3.1/" + "locations/" + geohash + "/profiles?" + (_.compact(filterParams).join('&'))).then(function(response) {

I can confirm that @zachdrago is correct. Grindr updated their "activeview" which changes the profile link and also if you edit your profile, that is now sent to /v3.1.  That would be on or around line 878
return $http.put(API_URL + 'me/profile', data);
change this to
return $http.put('http://grindr.mobi/v3.1/me/profile', data);

I just tried to sign in and got the following error:
Unexpected error (HTTP 412). Check out http://fuckr.me/ for updates.
I downloaded the latest version and everything. Is there something I should do?

It may be better to update just the constant on line 6 of "fuckr.js"
Original:
fuckr.constant('API_URL', 'https://grindr.mobi/v3/');
Change to
fuckr.constant('API_URL', 'https://grindr.mobi/v3.1/');
This will fix both @zachdrago & @RobbieTechie 's comments above, and keep the code cleaner.
I do not know how to commit changes to GIT, if someone else can do that and build that would be great! Thank you!

I started getting this too today tried changing it to v3.1 from v3 in the API URL in fuckr.js as above but still getting 404 :(

@BadBugCoder I totally understand why you say that, but Grindr only updated a couple links, so if you change the constant, you mess up more of the app than you will fix.  If would be better to add another constant, maybe call it API_URL2
@2ilent8cho If you just changed the whole constant, like I said here, that would fix those 2 spots, but mess up any others where Grindr kept the url at /v3/

@RobbieTechie I didn't realize grindr kept most of the other API_URLs at /v3/ and only updated two to /v3.1/. Thank you for correcting me.  Where can I find this out? Do they publish a blog where they say this?
I would think though all the ones related to 'me/profile' would also be changed to /v3.1/, no?? (There is a "delete profile" function.)
Also should changes be made to the .coffee files instead of the fuckr.js, since according to the header in fuckr.js the fuckr.js file was auto-generated by coffee. There is a fuckr.coffee file that has the same constant defined there (near the top of the file)
My feeling is to define:
fuckr.constant('API_URL_BASE', 'https://grindr.mobi/');
fuckr.constant('PROFILE_API_VERSION', 'v3.1/');
fuckr.constant('LOCATION_API_VERSION', 'v3.1/');
fuckr.constant('DEFAULT_API_VERSION', 'v3/');
[I have never programmed with coffee, so please take the following suggestion with a grain of salt! Sorry!]
Then inside settingsController.coffee change
return $http.put(API_URL + 'me/profile', data);
TO:
return $http.put(API_URL_BASE + PROFILE_API_VERSION + 'me/profile', data);
and change the function call parameters, or perhaps change the call to the settingsController
fuckr
.controller('settingsController', ['$scope', '$http', '$localStorage', 'profiles', 'uploadImage', 'API_URL_BASE' + 'PROFILE_API_VERSION', settingsController])
.directive('weightInput', weightInput)
Again not sure how coffee works.

@BadBugCoder I am not the original author , but from what I understand, the coffeescript files get compiled down into fuckr.js  If you are on Windows, just the fuckr.js is used, if you are on Mac, I'm not sure, but I believe under linux specifically is where the coffee files would all need to be updated.
Grindr won't publish anything about their app, they even try to obfuscate it using DexGuard, so no, there are no blogs.  I did state above that yes, when updating your profile, the newer versions of the app use the /v3.1/ in the url, but the old /v3/ is still there until they force app updates where the old v3 is no longer used.  Some of this is left for backwards compatability with the various versions of the app.

Thanks @zachdrago and @RobbieTechie .
It worked perfectly!
And thumbs up for @BadBugCoder for trying to help! Keep rocking guys.

I updated the code to include both
$http.get("https://grindr.mobi/v3.1/" + "locations/" + geohash + "/profiles?" + (_.compact(filterParams).join('&'))).then(function(response) {
and
return $http.put('https://grindr.mobi/v3.1/me/profile', data);
as outlined above but I am still getting the 412

@RobbieTechie The coffeescript was intended to transpile into the fuckr.js on all platforms - the "build" script in the package.json does that.  I'm not 100% sure how cat commands and pipes work on Windoze but I do know all nuts and bolts of nodejs should be pretty cross-platform. (I do everything on the flavour of Unix known to some as Mac, where it works beautifully).
On your fork, the coffescript and the js went their separate ways ages ago - although I think this caused confusion to some people running "npm run build" which would, in effect, overwrite your shiny new fuckr.js with an old one.
If you're directly editing the  fuckr.js, you should make the build script null, and may as well delete the coffee files altogether.
Thanks for all the awesome work @RobbieTechie! My comment is just a minor footnote to that.

You are incorrect @alansfr Windows does not have a build command nor npm by default, nor a run command as used here:  "run": "npm run build && nw ."  There is also no cat command under Windows, yet it runs just fine.  Also, if that was intended to be "transpiled" there would have been no need to include a fuckr.js file already, and it would have just built it.  Coffeescript files have no effect in Windows versions, therefore I have no reason to remove them, and will fix them when I work on other platforms as time permits

Macs don't have npm (nor for that matter the "coffee" command) by default so it won't build form the coffee source on there either without some effort.
It's not really a question of Windows vs. Macs. It's a question of whether you set things up to run the build script or not.
Anyone successfully following the ReadMe instructions for developers on any platform will end up with a non-working fuckr.js at present as the working fuckr.js will be overwritten.
Perhaps I should have said instead of my original comment that it was intended that the coffeescript and the javascript be kept in sync so that the coffeescript could be transpiled (to use the coffeescript jargon - not my word) into the javascript if one wished.
Anyway the upshot of all this is that the build script should be avoided on all platforms at present as it will break stuff.

Hi!
Right so I've had a little hack about and got this to work again, it seems Grindr are splitting calls over a couple of different API locations, so I've attached the fuckr.js file, this re-enables chat and I'm in the process of tidying up the GUI...
I've appended .txt to the end of the file name to allow it to upload, remove this and drag it into your main folder replacing the old fuckr.js file :)
Jai
fuckr.js.txt

@alansfr As I said before, it won't break on Windows, which is what it was updated for, the only version it won't work on right now is Linux, and I've only  had one person ask for an update, which I will likely do soon.  You don't seem to really understand this.
@iamJaiB Nice new profile, All you did was say what was already said above, and wrote out the urls in a couple places, which was already covered in this post, you didn't do anything new and chat wasn't disabled.
@kusaa I'm just curious why you reopened this after closing it as your issue was already solved.

Chat was disabled with the third edit mentioned above, with the direct link it's been working flawlessly all day, including image uploads again which seemed to be crashing chat when linked to v3.1 as well
I wasn't claiming to be doing anything new, I was just trying to help solve issues.

If you read through this whole issue, it was stated above not to change the API_URL as that would mess up other areas of the app.  The only spots that needed updates were the two areas mentioned by Zach and I.  All you did was type out the long way, what is already done by the app, pointing to the /v3/ instead of /v3.1/ areas.

As for @lesterquivers I suggest he click on this link
https://github.com/tomlandia/fuckr/issues/187
and download the version I have posted there, as it will take care of the profiles problem and his 412

@iamJaiB How'd you get the chat to work? Downloading the file you provided and updating the user-agent makes the program usable but the chat doesn't load at all for me.

Has this comment now been deleted? I was trying to reply to it.
I really don't think you read what I wrote. It's not a Mac vs Windows vs Linux issue. Please familiarize yourself with how npm scripts and the coffee command are supposed to work on all three platforms before replying.
The fact that you don't use them, and that they are not necessary (on any platform) for it to work is neither here nor there. They are still in the distribution, the Readme still refers to them as a thing, and someone asked about them. I answered. Correctly.
Cheers
Alan
On 21 Apr 2018, at 22:17, RobbieTechie<EMAIL_ADDRESS>wrote:

@alansfr As I said before, it won't break on Windows, which is what it was updated for, the only version it won't work on right now is Linux, and I've only had one person ask for an update, which I will likely do soon. You don't seem to really understand this.
@iamJaiB Nice new profile, All you did was say what was already said above, and wrote out the urls in a couple places, which was already covered in this post, you didn't do anything new and chat wasn't disabled.
@kusaa I'm just curious why you reopened this after closing it as your issue was already solved.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@alansfr It's perfectly clear to those of us that worked on this app for some time now, and actually fixed it when it went from version 2 to version 3 (which would be 3 of us counting the author) that you are the one that does not clearly grasp this.
This issue was in regards to a 404, which in http is a not found error, from changes in the systerm.  When @BadBugCoder attempted to make the fix more simple, he didn't realize what else his fix would affect, but he clearly was willing to learn, unlike yourself.  Had you and the others that are bantering here bothered to read through the whole issue you would understand that.  Since I've been one of the contributors and the original author @tomlandia is obviously busy, if he gave me the ability to close issues, this would be closed already because this has become nothing but pointless banter at this point.

@RobbieTechie I clicked on the link you provided but the post itself has the update file listed as [redacted] - please advise.
Thank you!

You're welcome

@RobbieTechie did I miss an update? Where is the link? I updated the fuckr.js file already and the app is working.
@zachdrago I love your fork, how can I compile that to use it alone and not with nwjs.

You didn't miss anything @xfy741

Once again you guys save the day :)
https://i.imgur.com/YeyvunJ.png

Assume that the png is a screenshot - how did you get that? I must be using
a different fuckr - doesnt look anything like it.
Thx
On Wed, May 2, 2018 at 8:39 PM, Jeffery Wilkins<EMAIL_ADDRESS>wrote:

Once again you guys save the day :)
https://i.imgur.com/YeyvunJ.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tomlandia/fuckr/issues/191#issuecomment-386184118,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AObrISPnmxCzPB5JMJC_yAdoa1eyJ0_Oks5tunwFgaJpZM4TZNDP
.

@RobbieTechie Your comments at this point are barely worthy of a reply, but just to set the record straight:
@BadBugCoder raised a query about the .coffee files. Your reply to that was not entirely correct and I posted what was intended to be a helpful correction solely on that point. It was not in regards to original issue, but solely in regards to the relationship between the coffee and .js files. I don't need to be told what a 404 code is thank you very much, but that wasn't relevant anyway.
I also went out of my way to thank you for your "awesome work".
You didn't seem to understand the point I had made and responded by writing

You are incorrect @alansfr Windows does not have a build command nor npm by default, nor a run command as used here: "run": "npm run build && nw ." There is also no cat command under Windows, yet it runs just fine. Also, if that was intended to be "transpiled" there would have been no need to include a fuckr.js file already, and it would have just built it. Coffeescript files have no effect in Windows versions, therefore I have no reason to remove them, and will fix them when I work on other platforms as time permits

When I attempted to clear things up in my second post you became even more abusive and stated:

@alansfr As I said before, it won't break on Windows, which is what it was updated for, the only version it won't work on right now is Linux, and I've only had one person ask for an update, which I will likely do soon. You don't seem to really understand this.

Since then, you deleted not only the two replies I just quoted but also recently deleted your post with its assertion about the role of the .coffee  files to which I was responding in the first place. You then pretended that I was addressing a different issue entirely with your even more abusive post containing words like "mouthy" and "bitch".
Your comment about "bothering to read through the whole issue" is absurd coming from someone who actually deleted the substantive point to which I was replying, leaving behind only their "banter".  As it happens, I had read the whole issue and also many of the other issues in this project - I had thought of responding in the past as I would have been able to clear up some quite serious misunderstandings. Given the way you take criticism, I think people can understand why I didn't.
I wont' stoop to your level.  In fact it would be worse if it weren't. Inexperienced people asking questions, which you clearly thought I was, shouldn't be treated with the kind of contempt you showed.
I will, however, say, that in my experience, confident "experts" do not respond to a minor correction on a technical matter by hurling abusing. Nor do they defend their expert view by deleting it and then pretending the response someone made to it was to something else.

@alansfr You seem to have a massive obsession with coffee files, even @lesterquivers knew what to fix with this without problems, he had another issue too which was solved.  As for @BadBugCoder I have a copy of his post before he edited it, so I know what he said,   The first time he didn't mention coffee files, and the 2nd post he asked about them.   :O i still get the error ... ._.

@RobbieTechie : What is this BS about my having multiple profiles? First I knew about it.
My "obsession" was an attempt to correctly answer a question that had been asked.

False personal accusations (about multiple profiles) really are the icing on the cake.
I have no idea where that came from but it's totally untrue. Not even a glimmer of a sliver of
piece of truth to it.
After all the work you've done, why waste your time indeed?

It's because of that snide attitude and your snide comments that I got feisty, along with the fact that even though you had not been here through numerous upgrades and almost a complete rewrite of this program, you came in here trying to tell me what I need to do.  Not even the original author had gone through to finish the update to v3 or this program would be completely dead right now, he's a busy guy also.
As for the coffee files, originally that was not even asked by badbugcoder, and didn't show up until you started making a stink about it, along with the 4 or 5 new profiles that made issues, then he went and edited his comment, I have copies of the original comment, seems awfully coincidental doesn't it?  Hence where the talk of multiple profiles came from.  That would not be the first time that has occurred on here when someone got snide then upset and made new profiles when put in their place which should not even happen.  You claimed above how your Mac version worked beautifully yet never bothered to release it for anyone to use and you continue to comment, yet then tell me I'm wasting my time.....  As of now, there has been only one user who has actually shared a working Mac version.  You sat there taunting people saying you have a version working beautifully, yet kept bitching and did not contribute a single thing other than trying to pic an argument.

Hi @RobbieTechie I believe you were the one who posted the G-drive link to a working Windows version awhile back. Unfortunately now that version isn't working due to the 412 error. Forgive me if I'm tagging the wrong person. Thanks for your hard work


Add readout faultdata

Extended the available analysis helper functions to:

Retrieve Faultconfiguration for one faultgroup or all faultgroups
Function to retrieve experiment tables
Function to invert the reduction strategy and fill the missing data points with goldenrun data
Wrapper functions to read tbexec, tbinfo and meminfo

Nice! Thanks for updating the PR.


RxJS 6.2.x trustedSubscriber._addParentTeardownLogic is not a function error

We are developing Cordova Application using Bootstrap 4 and Angular 6.  We upgraded RxJS version to 6.3.1. When we launch the Application in Samsung Mobile Device, its stuck in Splash screen and we are not getting any error message in the browser console.
So when we reverted both rxjs and rxjs-compat to V6.0.0, 6.1.0, 6.2.x. We are getting trustedSubscriber._addParentTeardownLogic is not a function. Error.
Ng Version:
Package                           Version
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/cli                      6.0.8
@angular/compiler-cli             6.0.7
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
rxjs                              6.2.2
typescript                        2.7.2
webpack                           4.8.3
Error Log:
Reproduction
We cannot share StackBlitz because our application is cordova based mobile app
Environment
Andriod, IOS

RxJS version:
6.1.x, 6.2.x

See #4077.

Not seeing any solution for above problem in #4077.

@nabzzz right now it is difficult to reproduce using a simple boilerplate app. Working on reproducing on a large scale app today to find out what is happening - if I can.

Our application is a huge one around 45,000-50,000 lines of code. We started developing this application in Angular 2, then we upgraded to 4, 5 and 6.  We are facing this issue after Rxjs v6.3.1 got released. Previously it's working fine. We tried to downgrade Angular CLI to 6.0.7, 6.0.8 . Its n't fixing the problem.

@sureshdotariya what about when you go back a version in RxJS?

We downgraded to RxJS V6.0.0, 6.1.x, 6.2.x. Still the same error.
Tried downgraded Angular CLI from 6.1.x to 6.0.7 and 6.0.8. But still same error.

@sureshdotariya did you check to make sure that the node_modules did indeed get pruned and there is nothing cached? Possibly blowing away node_modules and doing install again?

Yes, we also did 'npm cache clean --force' before 'npm install'. But no luck its same error.

Finally we able to resolve this issue. Using Angular CLI V6.0.8 with Rxjs V6.3.1.

I have upgraded to the latest version of RxJS but the problem still persists. Below is my configuration:
Angular CLI: 6.1.5
Node: 8.11.4
OS: win32 x64
Angular: 6.1.6
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Package                           Version
@angular-devkit/architect         0.6.3
@angular-devkit/build-angular     0.6.3
@angular-devkit/build-optimizer   0.6.3
@angular-devkit/core              0.7.5
@angular-devkit/schematics        0.7.5
@angular/cdk                      6.4.7
@angular/cli                      6.1.5
@angular/material                 6.4.7
@ngtools/webpack                  6.0.3
@schematics/angular               0.7.5
@schematics/update                0.7.5
rxjs                              6.3.2
typescript                        2.9.2
webpack                           4.8.3

@bampakoa can you grep your node_modules directory for rxjs in all package.json files to see if there are any conflicts in version numbers.

@bampakoa You should be able to get npm to list all rxjs packages - and their versions - under node_modules by running:
npm list rxjs

I solved the problem by doing these steps
npm install --save-dev<EMAIL_ADDRESS>npm cache clean --force
npm install  //this will install rxjs 6.3.2
npm install<EMAIL_ADDRESS>

This is the output from the command as suggested by @cartant and @pertrai1 . Thanks for the help guys!
+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| | +--<EMAIL_ADDRESS>| | | --<EMAIL_ADDRESS>deduped | | --<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| | --<EMAIL_ADDRESS>deduped | +--<EMAIL_ADDRESS>| | --<EMAIL_ADDRESS>| |   --<EMAIL_ADDRESS>| --<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| | --<EMAIL_ADDRESS>deduped | +--<EMAIL_ADDRESS>| | --<EMAIL_ADDRESS>deduped
| +--<EMAIL_ADDRESS>| | --<EMAIL_ADDRESS>deduped | +--<EMAIL_ADDRESS>| | --<EMAIL_ADDRESS>deduped
| --<EMAIL_ADDRESS>deduped --<EMAIL_ADDRESS>

TypeError: sink._addParentTeardownLogic is not a function solved
#4070
#12072

I can confirm that the issue is resolved using Angular CLI 6.2.1

Fixed by enforcing 6.3.2 for all dependencies.
Add to package.json
  "resolutions": {
    "**/rxjs": "6.3.2"
  },


fix gateway gps position

Hey!
One of my kerlink GW is inside a building for now and can't get a GPS signal... Is there a way for me to fix its GPS location for now ?

I guess something like this should work:
"fake_gps": true,
"ref_latitude": 10,
"ref_longitude": 10,
"ref_altitude": 10,

See also https://github.com/TheThingsNetwork/packet_forwarder/blob/master/poly_pkt_fwd/global_conf.json


As a developer on the gh-pages, all css and other assets should be under the /assets/ folder.

ApexDocs css and NPSP logo should be moved to /assets/ and files updated appropriately.

Duplicate.


feat: deploy L2NativeSuperchainERC20 behind proxy

#167
#169  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tremarkley and the rest of your teammates on  Graphite


get-countries.js throws an error when run locally

Whenever I try to run yarn develop locally I get the following error message.  I think it's because it's not getting the data that's expected from running node get-countries.js.
Would love some help to work through this!

yarn run v1.21.1
$ node get-countries.js && gatsby develop
TypeError: Cannot read property '0' of undefined
at IncomingMessage. (/Users/Stu/Web_Development/Websites/Stop-The-Spread/Iron Range/covid-19-iron-range/get-countries.js:22:35)
at IncomingMessage.emit (events.js:333:22)
at endReadableNT (_stream_readable.js:1220:12)
at processTicksAndRejections (internal/process/task_queues.js:84:21)

Hi @stufinn I think this might be related to missing env vars.
Can you check out this branch and see if it fixes your issue https://github.com/contentful/covid-19-site-template/pull/35

@Khaledgarbaya that fixes it! Runs perfectly now.  Thanks so much

PR Merged


[refactor] extract split name from the URL

We use the same code here, here and here.
It could be factorized.

#self-assign


tasty-tap: fix failing build

Motivation for this change
tasty-tap was failing to build because the changes in the patch it was trying to apply had already been released. Removed the patch and marked the package unbroken.
See https://github.com/NixOS/nixpkgs/pull/71017 for the history.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

:v:
Compiles locally, so looks good


Clip and prevent divide by 0 in arccos

I noticed when using this script that values can be very close but above 1, which are illegal values for arccos. Therefore, I suggest to clip the values. In addition, sometimes I got a division by 0 error so I simply added a check for that and return 0 when caught.

Hey, so sorry I missed this! I'm super glad you found the code useful and was able to contribute fixes back. I'll check them tomorrow and merge them in.
Thank you kindly!


[RV-3] Cleanup the freestyle page

 should be change to a
output should have max-width so it displays comfortably in the center of the screen and should use the same scrolling as the Spotify compnent

Done here.


HAWKULAR-1037 fix MetricOfResourceUnderFeed

Wrong URL was used so it was impossible to retrieve metrics under feed and resourcePath

Merged #95


Aligned error

Could provide this firmware to debug? Or send this binary to my email: huangrui(at)canaan-creative.com

it may not a bug in kflash.py, i use pyinstaller pack the py to exe. and also have some other bug...

This issue confirmed. It is an unknown bug.


PR for #30

PR for Issue #30

Thank you @JasonT1085 for your contributions!! I just had a few concerns

It's not working in my local system, is it working for you?
Can we make the box appear as one, and provide instructions a little differently? It seems a little too crowded (note, this can be tracked separately also, I would actually prefer to not block you for this).

Hi! For the Touchpad Appearance, would you like it with borders or without borders? (Just to make sure).

And another question, are these new instructions better?

I like it without the text! It looks much cleaner aesthetically. Also, I agree with that last part. Perhaps alongside the gear icon as mentioned in issue #32, there could be a '?' icon, and clicking it would pop up the instructions?

Agreed. That works!

I believe that should be everything unless you have any more feedback to give?

Thanks again for your contributions @JasonT1085!

Of course! Thank you for your patience and for having me on this project!

Pleasure, look forward to more contributions 😄


Remove "-ApiKey RequiredApiKey" when using basic authentication

Fix for issue: #7870
When using basic authentication, the nuget push command adds an invalid parameter:
-ApiKey RequiredApiKey
This is causing the nuget push command to fail when calling jfrog artifactory. Removing this parameter fix the problem

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: acasella sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

All CLA requirements met.

Great!

Closing due to age, please reopen if needed.


Added Deezer

Closed at the original repo and reopened here. Good that this is still somewhat maintained!

FYI, the HTML gets stripped out before being rendered currently, so you may want to rewrite your notes section. Perhaps something like this? My changes in bold.

If you signed up via Google/Facebook setup a Deezer password (http://www.deezer.com/password/reset) and click the confirmation link you'll get via mail. If you have your Deezer password, open your account settings. Click 'Delete my Account' at the bottom of the page. Enter your Deezer password and confirm the deletion in the confirmation mail.

Oh, thanks for pointing that out! I'll do that!

Thanks @Minty123 and @Nightfirecat !


Add link to SP Admin Center

closes https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/3789

@MikePlumleyMSFT
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Implement xml conversion for bioRxiv original articles

List of elements which should be replaced on original bioRxiv articles based on conversation with Fred:

replace all  html chars to special chars
article xml doctype header?
replace <subj-group subj-group-type="hwp-journal-call" to <subj-group subj-group-type="subject"
replace all <xref ref-type="corresp" to <xref ref-type="fn". Whole xml or only under <contrib element?
replace <corresp to <fn, place whole content under <p and remove other html tags
replace <kwd-group kwd-group-type="author" to <kwd-group kwd-group-type="author-generated"
replace

   <graphic xlink:href="905919v1_utbl2a.tif"/>
   <graphic xlink:href="905919v1_utbl2b.tif"/>

to
<fig id="fig1" position="float">
  Figure 1.
  <graphic xlink:href="ijm-00196-fig1.tif" mimetype="image" mime-subtype="tiff"/>
</fig>

note:

stencila/encoda don't recognize table with images, so we should map all table-wrap from bioRxiv as figures, otherwise receiving plain tables
should generate sample label if not exists? Example: for frst figure generate "Figure 1.", scnd "Figure 2." etc.

into ref-list.ref.* replace all <mixed-citation to <element-citation, inside replace:

wrap each <ref item with <person-group person-group-type="author" ref.element-citation.person-group.name level
remove spaces between tags
replace <string-name to <name

article xml doctype header?

Fine to leave this as is.

replace all <xref ref-type="corresp" to <xref ref-type="fn". Whole xml or only under <contrib element?

Whole XML would be safer. But it should only appear under the <contrib> (unless there are problems with the XML which is unfortunately a possibility).

should generate sample label if not exists? Example: for frst figure generate "Figure 1.", scnd "Figure 2." etc.

I would use the  from the
 element. If there isn't one, then the <fig> can be without one (a label shouldn't be required).
Additions
All outlined in this XSL if that's easier to discern.

Also need to move  in <sec> to the start of the <title>. If there is no <title> for the sec (this is very unlikely), then the  should simply be changed to <title>.

The same  issue ☝ needs to be handles in the same way for <app>s.

<sec>s in <abstract>s need to be changed to
s.

Change any <uri> to <ext-link ext-link-type="uri" xlink:href="{$uri}">{$uri}</ext-link> (where $uri is the text contained in <uri>).

Any <fig> or
 with more than 1 <graphic> should be turned into multiple <fig>s - one for each <graphic>. The  of the original can be used for the first, and subsequent ones can be without a .

Same solution as 5 above ☝ for <supplementary-material> with multiple <media>s.

<inline-formula> and <disp-formula> - bioRxiv capture them like this:

<disp-formula id="eqn1">
<alternatives><graphic xlink:href="000026_eqn1.gif"/></alternatives>
</disp-formula>

We need to get rid of the <alternatives> so it looks like this:
<disp-formula id="eqn1">
<graphic xlink:href="000026_eqn1.gif"/>
</disp-formula>

I'm also unsure how Encoda will deal with formula that have images - may need exploring...

@FAtherden-eLife  Awesome, thank you very much!


Logger revisions

I'm trying to use the current version (0.4-rc2 +changes). Logger needs cleanup! We need to reign it in just a bit at least for default purposes.
e.g., this is what I'm getting now, which is going to be incomprehensible to a typical user:
WARNING:root:None as logs destination appears to be neither a filepath nor a stream.
2017-02-16 11:43:08,578 looper.models.Project models : 265 - [INFO] > Instantiating Project using config file /home/ns5bc/code//mitodyn/metadata/config.yaml
INFO:looper.models.Project:Instantiating Project using config file /home/ns5bc/code//mitodyn/metadata/config.yaml
2017-02-16 11:43:08,579 looper.models.Project models : 454 - [INFO] > Loading LOOPERENV: /home/ns5bc/.local/lib/python2.7/site-packages/looper/submit_templates/default_looperenv.yaml
INFO:looper.models.Project:Loading LOOPERENV: /home/ns5bc/.local/lib/python2.7/site-packages/looper/submit_templates/default_looperenv.yaml
2017-02-16 11:43:08,590 looper.models.Project models : 289 - [INFO] > Updating compute settings (looper environment) based on file '/home/ns5bc/code/looperenv/rivanna.yaml'
INFO:looper.models.Project:Updating compute settings (looper environment) based on file '/home/ns5bc/code/looperenv/rivanna.yaml'
2017-02-16 11:43:08,591 looper.models.Project models : 454 - [INFO] > Loading LOOPERENV: /home/ns5bc/code/looperenv/rivanna.yaml
INFO:looper.models.Project:Loading LOOPERENV: /home/ns5bc/code/looperenv/rivanna.yaml
2017-02-16 11:43:08,601 looper.models.Project models : 478 - [ERROR] > Can't load looperenv config file '/home/ns5bc/code/looperenv/rivanna.yaml'
ERROR:looper.models.Project:Can't load looperenv config file '/home/ns5bc/code/looperenv/rivanna.yaml'
2017-02-16 11:43:08,601 looper.models.Project models : 479 - [ERROR] > TypeErroradd_entries() takes exactly 2 arguments (1 given)
ERROR:looper.models.Project:TypeErroradd_entries() takes exactly 2 arguments (1 given)
2017-02-16 11:43:08,601 looper.models.Project models : 294 - [INFO] > Establishing project compute settings
INFO:looper.models.Project:Establishing project compute settings
2017-02-16 11:43:08,602 looper.models.Project models : 515 - [INFO] > Loading compute settings default
INFO:looper.models.Project:Loading compute settings default

The logger messages are a bit too verbose for my tastes. I propose:

lines are way too long. Default formatter should be simple with none (or fewer) of the appendages (like level, lcoation, etc; just the message). Only by request should we add the extra information.
messages are printed twice?
compute section is now spitting out a bunch of logger-related attributes? eg: {'_force_nulls': False, '_logger': <logging.Logger object at 0x3b60b50>,
why can looper no longer read the looperenv file?

2017-02-16 11:56:16,843 looper.models.Project models : 478 - [ERROR] > Can't load looperenv config file '/home/ns5bc/code/looperenv/rivanna.yaml'
ERROR:looper.models.Project:Can't load looperenv config file '/home/ns5bc/code/looperenv/rivanna.yaml'

magic numbers need explanation, eg. what is ",820" in this? 11:56:16,820 and what is 265 in this? ls.Project models : 265
Why does processing not stop at the error (843 or 479)?

And finally, this version is now broken and will not run on this project (0.4 worked).
Traceback (most recent call last):
  File "/home/ns5bc/.local/bin/looper", line 9, in <module>
    load_entry_point('looper==0.4', 'console_scripts', 'looper')()
  File "/home/ns5bc/.local/lib/python2.7/site-packages/looper/looper.py", line 674, in main
    looperenv_file=getattr(args, 'env', None))
  File "/home/ns5bc/.local/lib/python2.7/site-packages/looper/models.py", line 310, in __init__
    self.parse_config_file(subproject)
  File "/home/ns5bc/.local/lib/python2.7/site-packages/looper/models.py", line 359, in parse_config_file
    self.add_entries(self.config)
  File "/home/ns5bc/.local/lib/python2.7/site-packages/looper/models.py", line 142, in add_entries
    self[key] = value
  File "/home/ns5bc/.local/lib/python2.7/site-packages/looper/models.py", line 174, in __setitem__
    self.__dict__[key].add_entries()
TypeError: add_entries() takes exactly 2 arguments (1 given)

Just realized I'm on the vreurter-0.5 branch (not the 0.4-rc2 + changes as I originally stated).

I have encountered another error in the current dev version:
WARNING:looper.models.Sample:Config lacks entry for data_source key: 'mitodyn' (in column: 'data_source') Traceback (most recent call last):   File "/home/ns5bc/.local/bin/looper", line 9, in <module>     load_entry_point('looper==0.4', 'console_scripts', 'looper')()   File "/home/ns5bc/.local/lib/python2.7/site-packages/looper/looper.py", line 677, in main     _LOGGER.info("Results subdir: " + prj.metadata.results_subdir) AttributeError: 'NoneType' object has no attribute 'info'

The current version in master is also not correctly processing derived columns; so something went wonky in the updates. 0.4-rc2 works, but current master branch is broken. the derived column is stuck on data_source for some reason...

Agreed. I'll omit logger name, which will substantially shorten most of those. Knowing line number and module is much shorter, and the benefit of class name is really a subset of that combination. I can also eliminate the spaces around line number. How do you feel about lowercase rather than uppercase for level? I think level is still helpful and makes it stand out, but I guess it could intimidate users?
Which messages are printed twice? The duplicate line number that I see there is from line 454, which originates from two different calls, giving two different filenames.
Only one of those is logger-related; the other(s) are the behavioral-related parameters on AttributeDict that then pop up in all of the looper-specific data types that inherit from AttributeDict. This could be changed by tweaking the implementation of str and/or repr on AttributeDictr.
I don't have an immediate answer; I'll have to dig more on that.
Those aren't magic numbers. 820 there is milliseconds on logger message time; that should be eliminated and I will do so. 265 is the line within the models module from which the message originated. As mentioned in pt.1, I'd like to have that, but I'm happy to eliminate it for the sake of logging message brevity and clarity from the user side.
Processing doesn't stop at many of the errors because there are several places in this code that have very generic Exception types in their catch/except clause with no re-raising. I don't like that and agree that processing should stop, but I left those as-was in many places because I thought perhaps that was intended behavior?

Which messages are printed twice?
All messages are in there twice; ie, "Instantiating Project using config file" in this:
2017-02-16 11:43:08,578 looper.models.Project models : 265 - [INFO] > Instantiating Project using config file /home/ns5bc/code//mitodyn/metadata/config.yaml INFO:looper.models.Project:Instantiating Project using config file /home/ns5bc/code//mitodyn/metadata/config.yaml

Agreed. I'll omit logger name, which will substantially shorten most of those. Knowing line number and module is much shorter, and the benefit of class name is really a subset of that combination. I can also eliminate the spaces around line number. How do you feel about lowercase rather than uppercase for level? I think level is still helpful and makes it stand out, but I guess it could intimidate users?

I agree that level is still helpful and uppercase is fine. and it's short. message should move to front? maybe format like this:
[INFO] Message... (module:linenum)

Those aren't magic numbers.
Ok yeah milliseconds is overkill :). I think all the time can probably be removed by default. looper usually executes in real time. this will be useful in the future for other projects that take hours to complete, though.

Processing doesn't stop at many of the errors because there are several places in this code that have very generic Exception types in their catch/except clause with no re-raising. I don't like that and agree that processing should stop, but I left those as-was in many places because I thought perhaps that was intended behavior?

Ok perfect, this is something we can clean up over time.

As discussed earlier with @nsheff , verbosity control should become more intuitive. If a user specifies one of the logging builtin level names on the command line, then that should be used as-is. Otherwise, though, the more general use case should be specification via small integral values. Furthermore, the relationship between value given and logging verbosity should be one of positive correlation, not negative as the bultin logging module does it. From the user side, that accords much more with intuition.

Track logging updates here: https://github.com/epigen/looper/issues/49

And moved errors stopping question to issue #51

I believe everything in this issue is either addressed in v0.5, or has been moved to a separate issue, so I'm closing this one.


EdgeConnect status of CR doesnt show real situation, when pod is failing

Description
THis PR is bugfix for https://dt-rnd.atlassian.net/browse/K8S-11360
Before this PR:
kaf ../samples/edgeconnect_****_v1alpha1.yaml
edgeconnect.dynatrace.com/e2e-andrii created
secret/edge-connect-client-secret-***** unchanged

➜  $ k get ec
NAME         APISERVER                             STATUS    AGE
e2e-andrii   *****.dev.apps.dynatracelabs.com   Running   5s

but pod in crashloop state.
After this change status will be Deploying, because we are not reached desired amount of replicas.
How can this be tested?
Deploy different edgeConnects, especially broken ones.
Make sure CR status represents the actual state of EdgeCOnnect Deployment.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.54%. Comparing base (ee8da4c) to head (e1a307a).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

pkg/controllers/edgeconnect/phase.go
78.26%
3 Missing and 2 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3851      +/-   ##
==========================================
+ Coverage   65.52%   65.54%   +0.01%
==========================================
  Files         404      405       +1
  Lines       21771    21795      +24
==========================================
+ Hits        14266    14285      +19
- Misses       6157     6160       +3
- Partials     1348     1350       +2

Flag
Coverage Δ

unittests
65.54% <81.48%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


PLAT-49383: Add simplified internal FP library

Issue Resolved / Feature Added
Ramda is more full-featured than we generally need in much of the framework internals. We've also over-used it in places leading to a compounding performance impact in hot paths.
Resolution
Add a simplified internal FP library to core and remove unnecessary ramda usage
Additional Considerations
There are a few places remaining we could alter to eliminate ramda altogether but the primary impact has been mitigated in this PR.
I've also omitted a changelog for this since there is no "bug" fixed nor feature added and all changes are internal. It falls into the general "performance improvements" of any release.
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy<EMAIL_ADDRESS>

Closing for now as the perf benefits don't appear to outweigh the cost of maintaining our own library for this


Change in class id: the solution

Google has changed class id for additional info.
Please change row 310 in utils.py from
soup.select_one('.xyOfqd'))
to
soup.select_one('.IxB2fe'))

This has already been fixed in d583ae866e9e379675d724ea1f859e51535c8365. Please update to the latest version.


Build the webkit server executable in parallel

During the gem installation there is a message that says "Building native extensions.  This could take a while...". And it takes a while.
This PR should make it take a bit less for people with more cores and Ruby 2+.

Does this work on Windows?  https://ruby-doc.org/stdlib-2.4.2/libdoc/etc/rdoc/Etc.html#method-c-nprocessors .

My current environment is based on JRuby on Windows. It appears to be working on all rubies I have lying around. Here are the ones I can test on [in format flavour - version (RUBY_PLATFORM)]:
Ruby - 2.4 (x64-mingw32)
Ruby - 2.3 (x86_64-msys)
JRuby - <IP_ADDRESS> (java)
JRuby - master (java)

Ok - good enough -- thanks


"MIT18.06: Linear Algebra": "数学基础/MITLA.md"

"In addition to the course materials, the famous Youtuber 3Blue1Brown's video series The Essence of Linear Algebra are also great learning resourses."
Is the spelling of resourses wrong, it should be resources?


any operator | messes up the table

The table of Junction operators in doc/Type/Junction.pod6 uses the | which is also the table cell separator. In the rendered output that creates an extra empty column:
     any  |   any          |   |        |   at least one value evaluates to True

On Fri, Feb 9, 2018 at 15:43 brian d foy<EMAIL_ADDRESS>wrote:

The table of Junction operators in doc/Type/Junction.pod6 uses the |
which is also the table cell separator. In the rendered output that creates
an extra empty column:

Brian, escape the pipe symbol with a backslash. See the table pod docs.
Best regards,
-Tom
@tbrowder


index.android.bundle is still unobfuscated

Upon following @AustinZuniga 's instructions, an APK generated by running ./gradlew assembleRelease still has an assets/index.android.bundle file which remains unobfuscated. Is anyone experiencing this same problem?

This is the current issue in using this library. It seems that transforming identifier names into hexadecimal or mangled is not working properly.
you can read more here about this issue: here

In addition to 'hexadecimal' and 'mangled', currently testing identifierNamesGenerator: 'dictionary', which is giving the same result: assets/index.android.bundle file remains unobfuscated.

I am having the same problem.  emitObfuscatedFiles true When I do this it creates an encrypted file called index.obfuscated. It seems that the codes in this file are completely encrypted.But there is no encrypted file in index.android.bundle.

same question


Expose @vue/server-renderer renderToString as esm module

What problem does this feature solve?
Allowing the usage of the ssr functionality outside of a nodejs environment.
Im having some pretty wild ideas about how to use some of the new features in vue 3. My latest is rendering the component to a string which is already possible using the server-renderer package.
The problem i have is my use case isn't going to be in a nodejs environment. Its directly in the browser.
And this got me thinking about if there are any technical reasons the server renderer cannot work in a none nodejs environment.
A little investigation has lead me to be belive this is possible with some minor none-breaking changes to the current exports:

always export ssrUtils from runtime-core
build the sever renderer with esm as a target

The above is all i believe is required to allow browser usage of the server renderer for rendering to strings.
Additional steps would need to be taken for rendering to stream, either choose not to expose it in this way, or by providing a stream implementation (eg: https://www.npmjs.com/package/stream-browserify).
I totally understand this is a none standard use case, and the name "server renderer" might mean this gets shot down pretty quickly. But it seems at least currently this is a very easy thing to expose.
There may be some reasons not to allow this, which may already be why this isn't exposed:

there are problems i haven't seen in allowing this type of usage
exposing via the browser may in future prevent needed updates that can only be performed in a nodejs environment (although i cant see why)
it confuses the api (or the name at least)

Maybe renderToString shouldn't be in the "server-renderer" package but a "string-renderer" package, and vice versa for stream rendering? I can also imagine a scenario rendering apps to strings could be useful in web/service workers, which is currently not possible as they don't have access to the dom, or the renderToString method.
What does the proposed API look like?
The api doesnt change, its the addition of renderToString exposed in none nodejs environments.

I'm trying to use renderToString in Cloudflare Workers and right now it only works because Webpack adds some magic to mock the stream dependency. It would be great to have ESM build for this so we can just import renderToString without bringing the whole package.

+1 In my use case, we're using native esm in the server and in the client. Even running in the server, because ssrUtils use CJS to detect the node target, it assumes that is not a SSR (which is not true).
https://github.com/vuejs/vue-next/blob/44996d1a0a2de1bc6b3abfac6b2b8b3c969d4e01/packages/runtime-core/src/index.ts#L280


Proposal to build DAO tools

Updog is currently the only provider of fully decentralized + on chain DAO tooling, thank you for your consideration!

Please check community questions at the Algorand Forum as well :)
[(https://forum.algorand.org/t/xgov44-updod-advanced-dao-tooling/9945/1)]

Hello.
Please update your proposal to match the template provided here.
https://github.com/algorandfoundation/ARCs/blob/main/assets/arc-0034/TemplateForm.md
Thanks.


[botbuilder-lg] use semver instead of myget feed url in package dependency

Need to update:

[ ] client/package.json
[ ] lib/indexers/package.json

addressed in https://github.com/microsoft/BotFramework-Composer/pull/1676


fix: filter out 0 liquidity assets and order by market cap

Description
I noticed the scammy assets are coming from portal, they are added by 2 ways:

Asset generation (removed them by filtering 0 liquidity assets)
Upsert at runtime when building the portfolio (removed 0 liquidity assets too)
Sorting by market cap in the search too, so bigger market cap assets are upper in the three initially)

Here is the behavior of the PR:

It's presorting assets by the criterias we wants (Fiat balance, market cap, balance + zero market cap, then finally all the other assets)
At search time => only filter and order by search term (but it means all the previous criteria might be a bit stale as we are reordering thing by search terms, ex: you are searching USDC, there is a USDC coin with 0 market data but crypto balance, but there is a USD Coin named asset with mcap which will be under because the name is not matching better than the previous maybe scammy one)

Issue (if applicable)

closes #8139
Risk
Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Try with demo mode, search for assets in the trade assets modal (USDC, USDT...)
-- You shouldn't see any scammy tokens other than the upsert one you have in your portfolio
Try with any other big wallets, likes shapeshiftdao.eth, or your own
-- You shouldn't see any scammy tokens other than the upsert one you have in your portfolio

Engineering
n/a

Operations
n/a

[ ] :checkered_flag: My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)
Before

After

Sort order:

Balance + Non zero market cap (sort by fiat value)
Market Cap based
Balance + zero market cap (sort by alphabetical)

@NeOMakinG a couple questions on this one:

When the market data for the asset list is loading, what is the expected behavior? Should we hide the assets for safety, or what is that intended behavior?
Is there a follow-up planned for asset sorting offline to avoid runtime cost of sorting by market cap?

We are putting them at the end of the list, we they can be a scam or not, if we rely on market data, if we don't have market data, then just sort them to the end
https://github.com/shapeshift/web/issues/8188 , This PR act as a quickwin to remove scammy asserts from portals, then we have another issue about the perf impact, if we want to presort a asset generation time as it involve a bigger json file and a few tweaks

@gomesalexandre filtered NFTs out of search: 4bfc4da
I avoided to use assetFilterPredicate as it would add another loop, prefering to add it to some already memoized loops


ensure doc types match after latest refresh of index data

there were some new doc types, but the total document count for these was ~4k out of the 9.2million, so I'll be skipping them.
these documents all appear to be 'Maintenance AP Vendor Invoice' document types from the year 2011-2014


Allow shots to be a numpy.int64

Summary
I've noticed that the Aer backends all work properly if the shots count is passed as a numpy.int64, but the BasicAer and hardware backends both fail in this case.  The simplest way to make it work on all backends is by making this change in terra, inspired by #4591.
Details and comments
Basic test program for reproducing the bug:
import numpy as np

from qiskit import QuantumCircuit, execute, Aer, BasicAer, IBMQ
from qiskit.providers.ibmq import least_busy

qc = QuantumCircuit(2, 2)
qc.h(0)
qc.cx(0, 1)
qc.measure([0, 1], [0, 1])

def run(backend):
    sim = execute(qc, backend, shots=np.int64(1024))
    return sim.result().get_counts(qc)

# This works
run(Aer.get_backend("qasm_simulator"))

# This fails, but is fixed by the current change
run(BasicAer.get_backend("qasm_simulator"))

# This also fails, and is also fixed by the current change
provider = IBMQ.load_account()
run(
    least_busy(
        provider.backends(filters=lambda x: x.configuration().n_qubits >= 2, simulator=False)
    )
)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 83.724%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
53018

Relevant Lines:
63325

💛  - Coveralls


Improved Address handling

Address must be extended by a "valid from" and a "valid until" value (and think about something more)
The selection of the active address in the contract, invoices and quotes must be explicit and no more implicit.
Example: Today the default customer address is automatically used as billing, delivery and contact address when it is not defined within the contract.

It looks like there is the same problem with the prices.
It is recommended to make a short sketch of the planned implementation.
In general the problem is:

Do we want to have redundant address data in the contact
Do we want to have redundant price data in the contract and contractpositions
If they are not redundant how do we make sure nobody is changing the prices and accidentally creates new contract versions.
Possible solution could be to have complete version history of ProductPrices and Address. This would make it possible to update the price while the contract does still refer to the old price.
It could be the case that the prices are never deleted but hidden and not visible anymore in the product. They should not be used for new pricerecalculation


Revalid before apply tv4 validation, fix #440

before we re-valid the field value, we need call $validate() to re-push the viewValue to the validators, else we will always use the undefined modelValue if previous validation is failed due to any of the validators but currently it can pass it.

it seems caused some deadloop, for certain conditions, any idea to resolve this?

finally use form.ngModelOptions.allowInvalid to overcome this.


Disable room-assistant service outside of home

Currently the service is always available and broadcasted by an iOS device that has the room-assistant app active. Since this kind of circumvents the privacy benefits of random addresses we should add a way of automatically disabling this when the device isn't home anymore.
Ideas for implementing this:

configurable geofence(s)
configurable "home" WiFi SSIDs

Note that the app probably isn't being used for tracking by anyone yet, so this isn't super urgent. In theory there are also other fingerprinting approaches available that would work for tracking even without the app installed.

I'm currently testing this based on iBeacons emitted by room-assistant (implemented on master). If it works for my test setup I'll publish the necessary room-assistant version and a new version of the app.


Requirements are misleading

Defender realtime protection in passive mode should be listed as a requirement per this note here :
If you are using Microsoft Endpoint DLP, Microsoft Defender Antivirus real-time protection is enabled, even when Microsoft Defender Antivirus is running in passive mode. Microsoft Defender Antivirus won't conflict with third-party antivirus solutions installed on the endpoint. Endpoint DLP depends on real-time protection to operate.
Reference:
https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-antivirus/microsoft-defender-antivirus-compatibility#antivirus-and-microsoft-defender-for-endpoint

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e0ac0e1-6f08-2f8b-10c7-a967e53886f8
Version Independent ID: f510237f-0ec9-d266-3ec6-0ad6b49e2522
Content: Get started with Microsoft 365 Endpoint data loss prevention - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/endpoint-dlp-getting-started.md
Service: o365-seccomp
GitHub Login: @chrfox
Microsoft Alias: chrfox

@chrfox  Please add your comment and help us in resolving this issue. Thanks.

Hi @bledMS82
Defender AV is not required for Endpoint DLP.


RHOAIENG-1910: Rework the documentation to be more consistent

Description

While trying to set up the environment from scratch I realized our documentation has become incoherent and difficult to follow without having a previous understanding of the PoC.
So I reworked the docs to try and reach a more coherent flow of documentation that can also work for both setting up the edge clusters in the cloud or locally using OpenShift Local.
You can view the rendered version on the branch directly.
How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

/hold

Are there any source files for the images that could be included, in case they need to be updated in the future?

The PNG files of the charts already include the metadata of the diagram and can be re-used to update it.

I'm having a look as well.

/unhold

/retest

For some reason this PR kept showing that it needs rebase even long after I rebased and pushed. So I had to create another PR (couldn't even reopen this PR after closing it). #221

/reopen

^that was just a test of that command

@devguyio the issues that you experienced were probably due to the following ongoing GH incident: https://www.githubstatus.com/incidents/wcl1sw4mzg60

/reopen

test


feat: enable phrase_query(bool) for hybrid search queries

first off, apologies for any folly since i'm new to contributing to lancedb. this PR is the continuation of a discord thread:
user story
here's the lance db search query i'd like to run:
def search(phrase):
    logger.info(f'Searching for phrase: {phrase}')
    phrase_embedding = get_embedding(phrase)
    df = (table.search((phrase_embedding, phrase), query_type='hybrid')
        .limit(10).to_list())
    logger.info(f'Success search with row count: {len(df)}')

search('howdy (howdy)')
search('howdy(howdy)')

the second search fails due to ValueError: Syntax Error: howdy(howdy)
i saw on the docs that i can use phrase_query() to enable a flag to wrap the query in double quotes (as well as sanitize single quotes) prior to sending the query to search. this works for normal FTS, but the command is unavailable on hybrid search.
changes
i added phrase_query() function to LanceHybridQueryBuilder by propagating the call down to its self. _fts_query object. i'm not too familiar with the codebase and am not sure if this is the best way to implement the functionality. feel free to riff on this PR or discard
tests
(lancedb) JamesMPB:python james$ pwd
/Users/james/src/lancedb/python
(lancedb) JamesMPB:python james$ pytest python/tests/test_table.py
python/tests/test_table.py .......................................                                                                   [100%]
====================================================== 39 passed, 1 warning in 2.23s =======================================================

@jameswu1991 we'll get this merged once the linting test passes. You can run ruff format and ruff lint to check those

@jameswu1991 ooh I just merged an update to our hybrid search API and so there are some conflicts. The latest updates provides a better way to manually pass vectors and text strings manually (for cases that don't rely on embedding API).
You'll need to pull main into this branch and resolve conflicts.

Does Hybrid Search only support Python API now? I failed to find the corresponding JS/TS API, is there a plan?

@Symbolk hey right now hybrid search and reranking is only available for python.

@jameswu1991 ooh I just merged an update to our hybrid search API and so there are some conflicts. The latest updates provides a better way to manually pass vectors and text strings manually (for cases that don't rely on embedding API). You'll need to pull main into this branch and resolve conflicts.

Ooh, thanks for the heads up. I pulled the latest code and noticed that the newest changes moved initialization of _fts_query to the function to_arrow(), and several query parameters are checked during query execution such as self._limit and self._where. I presume I should follow this pattern?
If so, I will update this PR soon with the implementation

@jameswu1991 yes please. You can follow the same pattern

Yup! should be good to go after this latest commit:
/Users/james/src/lancedb/python$ ruff check .
All checks passed!


Reliance on topological ordering for graph inputs

Currently MXNet relies on topological ordering of the graph when communicating between frontend languages and backend. This makes it hard to apply fusions in the graph, as they could change the topological order of graph inputs and so break passing of the inputs from frontend.
This could be solved by either moving to passing dictionaries (name, value) from frontend to the engine (which requires changing of C API) or making mappings inside Executor and CachedOp from the original topological ordering to the new one.

I think this makes sense to me, since the original topological ordering didn't assume mutations like subgraphing and fusion. Related issue: https://github.com/apache/incubator-mxnet/issues/14727 . I think this may require changes to user facing APIs in symbol, module and gluon since at many places ordering of arg_arrays, grad_arrays and aux_arrays depend on the list_arguments and list_inputs which depend on the topo ordering.


Go rewrite

This is a rewrite from Python to Go.  It is backwards compatible with the REST interfaces and configurations minus the rate limiting (buffering was added to depreciate that feature).  All libraries are vendored in this project so it can be checked out and built without pulling from internet sources.  There are a couple of optimizations in this implementation (listed below).  You should get next to no-blocking of uploading RPMs to a repo with this implementation.  Still have to tweak the buffering to do batches in high-stress periods.  Performance benefits should be at least 3-10x improvement and minus the operational hassles of a Python project, see issue #5
Performance benefits:

No need to write / read JSON file on disk, cacheing of contents from the sqlite DB, cache is invalided when new RPM is added and successful read from sqlite is completed.
No process is triggered after every request is made that was using subprocess pop.  This is now handled by the buffer to control new RPMs being added.
No need for WSGI server / workers to scale python API.  Go implementation excels at this this even without NGINX to handle other magic.
Even with cache'ing the runtime requires less memory and CPU cycles.

@marshyski - can you write a quick description of the change or link to an issue?  thanks.

@kood1 updated description of PR.

Thanks @marshyski.  It looks like CI build is failing.  Can you take a look?

@marshyski nvm, it passed


Add Alibaba Dragonwell JDK

Description:
We want to add Alibaba Dragonwell JDK into setup-java so that users can use it conveniently.

hi, @Accelerator1996 thank you for submitting the report, we will take a look at it.

Hi, @Accelerator1996 👋 I'm closing this issue as a duplicate of the https://github.com/actions/setup-java/issues/71.. You can keep track of the issue there.

Hi, @Accelerator1996 👋 I'm closing this issue as a duplicate of the #71. You can keep track of the issue there.

Thank you very much