HBASE-25830 HBaseCluster support CompactionServer for UTs

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 47s
HBASE-25714 passed

+1 :green_heart:
compile
8m 17s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m  3s
HBASE-25714 passed

+1 :green_heart:
spotbugs
11m 16s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 41s
the patch passed

+1 :green_heart:
compile
8m 13s
the patch passed

+1 :green_heart:
javac
8m 13s
the patch passed

-0 :warning:
checkstyle
2m  2s
root: The patch generated 8 new + 251 unchanged - 1 fixed = 259 total (was 252)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
17m 53s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
11m 26s
the patch passed

_ Other Tests _

-1 :x:
asflicense
0m 42s
The patch generated 1 ASF License warnings.

78m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 04528dca26f3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 7f32d6cfc5

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

asflicense
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
141 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 19s
HBASE-25714 passed

+1 :green_heart:
compile
2m 57s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 35s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 10s
the patch passed

+1 :green_heart:
compile
2m 58s
the patch passed

+1 :green_heart:
javac
2m 58s
the patch passed

-1 :x:
shadedjars
0m 15s
patch has 10 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 34s
the patch passed

_ Other Tests _

-1 :x:
unit
188m 18s
root in the patch failed.

222m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6f7bc70c0e48 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 7f32d6cfc5

Default Java
AdoptOpenJDK-11.0.10+9

shadedjars
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/testReport/

Max. process+thread count
6802 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 55s
HBASE-25714 passed

+1 :green_heart:
compile
8m 41s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m 58s
HBASE-25714 passed

+1 :green_heart:
spotbugs
15m 37s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 44s
the patch passed

+1 :green_heart:
compile
10m 33s
the patch passed

+1 :green_heart:
javac
10m 33s
the patch passed

+1 :green_heart:
checkstyle
2m 42s
root: The patch generated 0 new + 289 unchanged - 1 fixed = 289 total (was 290)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
25m 15s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
16m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 46s
The patch does not generate ASF License warnings.

107m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 5698f75cbf59 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / f3bea21194

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 34s
HBASE-25714 passed

+1 :green_heart:
compile
3m  8s
HBASE-25714 passed

+1 :green_heart:
shadedjars
8m  5s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 58s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 19s
the patch passed

+1 :green_heart:
compile
3m  2s
the patch passed

+1 :green_heart:
javac
3m  2s
the patch passed

+1 :green_heart:
shadedjars
8m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 26s
the patch passed

_ Other Tests _

-1 :x:
unit
166m  4s
root in the patch failed.

210m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 93a0ee8c281a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / f3bea21194

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/testReport/

Max. process+thread count
3910 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
HBASE-25714 passed

+1 :green_heart:
compile
2m 34s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 57s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 51s
the patch passed

+1 :green_heart:
compile
2m 34s
the patch passed

+1 :green_heart:
javac
2m 34s
the patch passed

+1 :green_heart:
shadedjars
7m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 54s
the patch passed

_ Other Tests _

-1 :x:
unit
363m  0s
root in the patch failed.

401m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b4bad534a74e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / f3bea21194

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/testReport/

Max. process+thread count
5744 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
HBASE-25714 passed

+1 :green_heart:
compile
8m 10s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m  4s
HBASE-25714 passed

+1 :green_heart:
spotbugs
11m 28s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
compile
8m 15s
the patch passed

+1 :green_heart:
javac
8m 15s
the patch passed

+1 :green_heart:
checkstyle
2m  3s
root: The patch generated 0 new + 289 unchanged - 1 fixed = 289 total (was 290)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
17m 57s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
11m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

79m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 88c69c81ee0f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / f3bea21194

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 33s
HBASE-25714 passed

+1 :green_heart:
compile
3m  1s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 49s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 59s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 17s
the patch passed

+1 :green_heart:
compile
3m  8s
the patch passed

+1 :green_heart:
javac
3m  8s
the patch passed

+1 :green_heart:
shadedjars
8m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 25s
the patch passed

_ Other Tests _

-1 :x:
unit
199m  2s
root in the patch failed.

243m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b33fca9efc3a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / f3bea21194

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/testReport/

Max. process+thread count
6376 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
0m 59s
Docker failed to build yetus/hbase:92fe6090c2.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3266

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/4/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 46s
HBASE-25714 passed

+1 :green_heart:
compile
8m  9s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m  5s
HBASE-25714 passed

+1 :green_heart:
spotbugs
11m 33s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
compile
8m 20s
the patch passed

+1 :green_heart:
javac
8m 20s
the patch passed

+1 :green_heart:
checkstyle
2m  0s
root: The patch generated 0 new + 289 unchanged - 1 fixed = 289 total (was 290)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
20m 59s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
14m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 42s
The patch does not generate ASF License warnings.

87m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 4dfce8fc4660 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / fe47e48f0b

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 18s
HBASE-25714 passed

+1 :green_heart:
compile
3m  4s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 58s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 16s
the patch passed

+1 :green_heart:
compile
3m  1s
the patch passed

+1 :green_heart:
javac
3m  1s
the patch passed

+1 :green_heart:
shadedjars
8m 28s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
199m 11s
root in the patch passed.

243m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7f08d02c2cb2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / fe47e48f0b

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/testReport/

Max. process+thread count
6436 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
HBASE-25714 passed

+1 :green_heart:
compile
2m 34s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 59s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 52s
the patch passed

+1 :green_heart:
compile
2m 32s
the patch passed

+1 :green_heart:
javac
2m 32s
the patch passed

+1 :green_heart:
shadedjars
7m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 53s
the patch passed

_ Other Tests _

-1 :x:
unit
300m 43s
root in the patch failed.

339m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b373a5dd62ba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / fe47e48f0b

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/testReport/

Max. process+thread count
3291 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
HBASE-25714 passed

+1 :green_heart:
compile
8m 13s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m  3s
HBASE-25714 passed

+1 :green_heart:
spotbugs
11m 19s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 34s
the patch passed

+1 :green_heart:
compile
8m 13s
the patch passed

+1 :green_heart:
javac
8m 13s
the patch passed

+1 :green_heart:
checkstyle
2m  3s
root: The patch generated 0 new + 289 unchanged - 1 fixed = 289 total (was 290)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
17m 48s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
11m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

78m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 649ef53a2ac9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / fe47e48f0b

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 26s
HBASE-25714 passed

+1 :green_heart:
compile
2m 58s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 49s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 36s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 15s
the patch passed

+1 :green_heart:
compile
2m 58s
the patch passed

+1 :green_heart:
javac
2m 58s
the patch passed

+1 :green_heart:
shadedjars
7m 52s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
188m 48s
root in the patch passed.

231m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 090a7e497840 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / fe47e48f0b

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/testReport/

Max. process+thread count
6526 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
HBASE-25714 passed

+1 :green_heart:
compile
2m 34s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 54s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
2m 31s
the patch passed

+1 :green_heart:
javac
2m 31s
the patch passed

+1 :green_heart:
shadedjars
7m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 50s
the patch passed

_ Other Tests _

-1 :x:
unit
311m 15s
root in the patch failed.

348m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3266

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a88d9eb4ac93 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / fe47e48f0b

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/testReport/

Max. process+thread count
3841 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-server . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Add support to QuantumCircuit and DAGCircuit methods involving Expr expressions

What should we add?
This forms a lot of the work needed for actual use of the initial classical-expression design document.
Depends on #10223 and #10224.
### Contained issues
- [ ] #10226
- [ ] #10227
- [ ] #10230
- [ ] #10231
- [ ] https://github.com/Qiskit/qiskit-terra/issues/10359
- [x] https://github.com/Qiskit/qiskit-terra/issues/10379
- [x] https://github.com/Qiskit/qiskit-terra/issues/10380

~In addition to the DAGCircuit methods that are explicitly called out above, I substitute_node_with_block and substitute_node both technically need updating with support for Expr values.  However, I think in practice that these operations do not make sense in the same way with control flow, and since we need to rework how the DAGCircuit data structure works with control flow anyway, I don't think they will actually need touching.~
edit: in having done this, I think it's actually simple enough and meaningful to define the behaviour for substitute_node_with_dag and substitute_node, and likely will be useful for PRs in the vein of #9580.

As of right now, the PRs:

#10362
#10375
#10377
#10383
#10367
#10381
#10380

close every issue in this task list.  Once the task list is complete, this issue can be closed as completed.

All contained issues now closed.


retreive history

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Is it possible to add the parameters to the config in HA to retrieve the history?
it uses the following parameters in the original software:
-ad#                Set #days for archived daydata: 0-300
0=disabled, 1=today (default), ...
-am#                Set #months for archived monthdata: 0-300
0=disabled, 1=current month (default), ...
-ae#                Set #months for archived events: 0-300
0=disabled, 1=current month (default), ...
Describe the solution you'd like
have the parameters above as optional settings
In docker it can be set via ENV:
SBFSPOT_ARGS = -ad300 -am300 -ae300
or
ENTRYPOINT
more info: https://hub.docker.com/r/nakla/sbfspot
Describe alternatives you've considered
...
Additional context
Optional settings might be the best option here but an short how-to to edit it via portainer is also fine.

Hi I'm out of my country atm. So will be offering limited support for a few weeks.
In saying that.
You can log into the container using the homeassistant community ssh addon. You should be able to find the command in one of the other open issues or readme page(I think it's been a while since I looked)
Once you login to the container you can run SBFspot with any command line arguments you like. So you can run an extended archive that way.
Adding options to the command to offer a variable system for the archive would require a rewrite of this addon as the command is hard coded into a crontab in the dockerfile.
This creates the crontab before the options are created and accessed from homeassistant.
You can clone the addon and edit the crontab to suit your particular needs in the dockerfile if you like.

Hi I'm out of my country atm. So will be offering limited support for a few weeks.
In saying that.
You can log into the container using the homeassistant community ssh addon. You should be able to find the command in one of the other open issues.
Once you login to the container you can run SBFspot with any command line arguments you like. So you can run an extended archive that way.
Adding options to the command to offer a variable system for the archive would require a rewrite of this addon as the command is hard coded into a crontab in the dockerfile. This creates the crontab before the options are created and accessed from homeassistant.
You can clone the addon and edit the crontab to suit your particular needs in the dockerfile if you like.

Thanks! No problem :)
I've run "./SBFspot -ad300 -am300 -ae300 and some other paratmeters via de commandline form within the docker itself. I used Portainer to get into the container.


Add support for a special marker utility

that computes elapsed time wrt the beginning of the transaction. Add lifetime markers using this new log utility.

@perryibm FYI

had to pass in the loglevel that was forgotten in a previous commit

Rebased, squashed and merged as d7f0ed7.


Sample for HTML5LocationStrategy

You have commented out the part with the html5LocationStrategy, but the code didnt work if you activate him. I can not find any HTML5LocationStrategy in the Angular 2 libraries.
BTW: Nice project!

Hey @JanOschii
Actually that issue is in the project generator over at: https://github.com/dsebastien/modernWebDevGenerator
But you're right, HTML5LocationStrategy doesn't exist. The Angular team mentionned at some point that it should/would be renamed, but I guess it didn't after all. I'll remove that comment

I'll fix this in the generator through there: https://github.com/dsebastien/modernWebDevGenerator/issues/62


NRI config not picked up by containerd 1.7

Description
With containerd 1.7, the nri plugin config is not picked up. I do not see this issue with containerd 2.0
Steps to reproduce the issue
1.# git branch
main

release/1.7
remote

at commit f352822e4bc820e1b91956c731a3e9f81a1dcddb
3.make
4.config.toml is

containerd]# cat /etc/containerd/config.toml
root = "/var/lib/containerd"
state = "/run/containerd"
subreaper = true
oom_score = 0

[grpc]
  address = "/run/containerd/containerd.sock"
  uid = 0
  gid = 0

[debug]
  address = "/run/containerd/debug.sock"
  uid = 0
  gid = 0
  level = "info"

[plugins."io.containerd.nri.v1.nri"]
# Enable NRI support in containerd.
disable = false
# Allow connections from externally launched NRI plugins.
disable_connections = false
# plugin_config_path is the directory to search for plugin-specific configuration.
plugin_config_path = "/etc/nri/conf.d"
# plugin_path is the directory to search for plugins to launch on startup.
plugin_path = "/opt/nri/plugins"
# plugin_registration_timeout is the timeout for a plugin to register after connection.
plugin_registration_timeout = "15s"
# plugin_requst_timeout is the timeout for a plugin to handle an event/request.
plugin_request_timeout = "12s"
# socket_path is the path of the NRI socket to create for plugins to connect to.
socket_path = "/var/run/nri/nri.sock"

5.Run containerd and dump its config
 bin]# ./containerd config dump | grep -A 10 "io.containerd.nri.v1.nri"
WARN[0000] containerd config version `1` has been deprecated and will be removed in containerd v2.0, please switch to version `2`, see https://github.com/containerd/containerd/blob/main/docs/PLUGINS.md#version-header
  [plugins."io.containerd.nri.v1.nri"]
    disable = true
    disable_connections = false
    plugin_config_path = "/etc/nri/conf.d"
    plugin_path = "/opt/nri/plugins"
    plugin_registration_timeout = "5s"
    plugin_request_timeout = "2s"
    socket_path = "/var/run/nri/nri.sock"

  [plugins."io.containerd.runtime.v1.linux"]
    no_shim = false

6.The config from the toml is not picked up.
Describe the results you received and expected
The config for the nri plugin should be picked up. Containerd 2.0 (main branch) has expected results.
What version of containerd are you using?
containerd github.com/containerd/containerd v1.7.8-26-gf352822e4 f352822e4bc820e1b91956c731a3e9f81a1dcddb
Any other relevant information
runc version 1.1.7
commit: f19387a6bec4944c770f7668ab51c4348d9c2f38
spec: 1.0.2-dev
go: go1.20.10
libseccomp: 2.5.3
Show configuration if it is related to CRI plugin.
cat /etc/containerd/config.toml
root = "/var/lib/containerd"
state = "/run/containerd"
subreaper = true
oom_score = 0
[grpc]
address = "/run/containerd/containerd.sock"
uid = 0
gid = 0
[debug]
address = "/run/containerd/debug.sock"
uid = 0
gid = 0
level = "info"
[plugins."io.containerd.nri.v1.nri"]
Enable NRI support in containerd.
disable = false
Allow connections from externally launched NRI plugins.
disable_connections = false
plugin_config_path is the directory to search for plugin-specific configuration.
plugin_config_path = "/etc/nri/conf.d"
plugin_path is the directory to search for plugins to launch on startup.
plugin_path = "/opt/nri/plugins"
plugin_registration_timeout is the timeout for a plugin to register after connection.
plugin_registration_timeout = "15s"
plugin_requst_timeout is the timeout for a plugin to handle an event/request.
plugin_request_timeout = "12s"
socket_path is the path of the NRI socket to create for plugins to connect to.
socket_path = "/var/run/nri/nri.sock"

version = 2?

suggest start from config default.. and edit your changes in from there..

Thanks @mikebrow and @estesp .
For anyone else looking, following toml worked for me - enabled NRI with 1.7.8
root = "/var/lib/containerd"
state = "/run/containerd"
subreaper = true
oom_score = 0
version = 2

[grpc]
  address = "/run/containerd/containerd.sock"
  uid = 0
  gid = 0

[debug]
  address = "/run/containerd/debug.sock"
  uid = 0
  gid = 0
  level = "info"

[plugins."io.containerd.nri.v1.nri"]
# Enable NRI support in containerd.
disable = false
# Allow connections from externally launched NRI plugins.
disable_connections = false
# plugin_config_path is the directory to search for plugin-specific configuration.
plugin_config_path = "/etc/nri/conf.d"
# plugin_path is the directory to search for plugins to launch on startup.
plugin_path = "/opt/nri/plugins"
# plugin_registration_timeout is the timeout for a plugin to register after connection.
plugin_registration_timeout = "15s"
# plugin_requst_timeout is the timeout for a plugin to handle an event/request.
plugin_request_timeout = "12s"
# socket_path is the path of the NRI socket to create for plugins to connect to.
socket_path = "/var/run/nri/nri.sock"

@samuelkarp are we removing the requirement for version = 2 from the v2 release?

I don't think that's going away.  @dmcgowan built automatic conversion from version = 1 format to version = 2 (and version = 3), but that doesn't add new fields to old config formats.

thx maybe a warning when it's seriously downlvl and/or has a field from a future version..

eg. for containerd 2/1.7 nri whoa not in version 1


bot-sso quickstart sample fixes

Build pipeline - All builds passed
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/4170804492


MN-574: Merge to the master first mainnet improvements release

what I did:

Merge to the master first mainnet improvements release

Codecov Report

Merging #55 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   15.30%   14.95%   -0.36%
==========================================
  Files           7        7
  Lines        1006     1070      +64
==========================================
+ Hits          154      160       +6
- Misses        844      897      +53
- Partials        8       13       +5

Impacted Files
Coverage Δ

...cation/builtin/contract/deposit/deposit.wrapper.go
0.00% <0.00%> (ø)

...et/application/builtin/contract/deposit/deposit.go
2.51% <0.00%> (+2.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf824a5...ba10e53. Read the comment docs.


WIP: Fix figshare test

Closes #999

The first commit copies @betatim's fix from https://github.com/jupyterhub/binderhub/pull/1236
The second commit changes this fix to only check for an optional code/ instead of any path element, this was needed to fix the test_content_id test where the returned mock URL is of the form https://figshare.com/articles/title/9782777 which doesn't correctly match the regex from the first commit. I don't know if this is still correct though, I made this change to fix the test rather than from any knowledge of the Figshare API.
The third commit highlights two tests which are still failing, I think this is a bug on the Figshare side? It looks like the version is dropped from the final redirect.

I've marked the two failing tests as xfail for now.

I've marked the two failing tests as xfail for now.

I think we can make the /code/ part non-optional because that is the new format of the URLs. Another thing to ask about/get someone who uses figshare to help us with.

I think we can make the /code/ part non-optional because that is the new format of the URLs. Another thing to ask about/get someone who uses figshare to help us with.

I've pinged Megan Hardeman from Figshare (https://figshare.com/authors/Megan_Hardeman/2562466), who we I had brief interaction with when working on the original implementation, about the discussion here. Maybe she can briefly clarify that the /code/ part is there to stay.

I've pinged Megan Hardeman from Figshare (https://figshare.com/authors/Megan_Hardeman/2562466), who we I had brief interaction with when working on the original implementation, about the discussion here. Maybe she can briefly clarify that the /code/ part is there to stay.

Here is what I received now from a figshare engineer:

Within the Figshare platform, we've had several updates in the last period of time in order to have a more stable google indexing base. Therefore, we've added the item type of any public records to the Figshare URL once the DOI value is accessed.
For the mentioned example, the code value is the item type, but other values can occur as well (for eg., report, presentation, dataset, see example below). (https://figshare.com/articles/dataset/Data_Sheet_1_Slow_Transition_Path_Times_Reveal_a_Complex_Folding_Barrier_in_a_Designed_Protein_pdf/13554056).
In terms of the DOI values, there are several considerations to be taken into account. For any Figshare record (for instance, https://figshare.com/articles/journal_contribution/Comparing_Various_Chelation_Therapies_in_Thalassemia_Patients_pdf/13573379), opening the Cite area and pressing the DOI value would generate a link that points to that specific version of the DOI (it will have a /1 at the end). Opening the link without the /1 part would send the user to the last version of that record.

IIRC the trailing /1   for versions is already handled.
The different items types should be covered, so the /code/ part needs to be more flexible. I did not find a full list of all existing item types for the URL, only this "plain text" version: https://help.figshare.com/article/item-types Curiously, there is no "code" but "Software".
I asked again in the ticket if they can provide a full list, but probably some regex-fu can also solve this. Will update here again..

Here is what I received now from a figshare engineer:

Within the Figshare platform, we've had several updates in the last period of time in order to have a more stable google indexing base. Therefore, we've added the item type of any public records to the Figshare URL once the DOI value is accessed.
For the mentioned example, the code value is the item type, but other values can occur as well (for eg., report, presentation, dataset, see example below). (https://figshare.com/articles/dataset/Data_Sheet_1_Slow_Transition_Path_Times_Reveal_a_Complex_Folding_Barrier_in_a_Designed_Protein_pdf/13554056).
In terms of the DOI values, there are several considerations to be taken into account. For any Figshare record (for instance, https://figshare.com/articles/journal_contribution/Comparing_Various_Chelation_Therapies_in_Thalassemia_Patients_pdf/13573379), opening the Cite area and pressing the DOI value would generate a link that points to that specific version of the DOI (it will have a /1 at the end). Opening the link without the /1 part would send the user to the last version of that record.

IIRC the trailing /1   for versions is already handled.
The different items types should be covered, so the /code/ part needs to be more flexible. I did not find a full list of all existing item types for the URL, only this "plain text" version: https://help.figshare.com/article/item-types Curiously, there is no "code" but "Software".
I asked again in the ticket if they can provide a full list, but probably some regex-fu can also solve this. Will update here again..

The full list of the item type string ids can be found below:

figure
media
dataset
poster
journal_contribution
presentation
thesis
code
online_resource
preprint
book
conference_contribution
chapter
peer_review
educational_resource
report
standard
composition
funding
physical_object
data_management_plan
workflow
monograph
performance
event
service
model
registration

So, it looks like letters and underscores could be used for the regex.

The full list of the item type string ids can be found below:

figure
media
dataset
poster
journal_contribution
presentation
thesis
code
online_resource
preprint
book
conference_contribution
chapter
peer_review
educational_resource
report
standard
composition
funding
physical_object
data_management_plan
workflow
monograph
performance
event
service
model
registration

So, it looks like letters and underscores could be used for the regex.

Thanks for finding this out!
Either a regex that matches "words which contain underscores" or something that matches "code" and "dataset" are the two options we should think about. If there is a nice way to deal with "all possible values" I think we should do that, otherwise lets match code or dataset and expand on this if someone complains.

Thanks for finding this out!
Either a regex that matches "words which contain underscores" or something that matches "code" and "dataset" are the two options we should think about. If there is a nice way to deal with "all possible values" I think we should do that, otherwise lets match code or dataset and expand on this if someone complains.

It also means we need to follow up https://github.com/jupyterhub/binderhub/pull/1236 as it also has a hardwired /code/ in it

It also means we need to follow up https://github.com/jupyterhub/binderhub/pull/1236 as it also has a hardwired /code/ in it

@nuest Thanks for chasing this up with Figshare! I'll update the tests and see what happens.
@betatim How much duplicated code is there between repo2docker and BinderHub for detecting providers? Is there enough to be worth refactoring, e.g. so BinderHub can import some detection functions from repo2docker.utils, or is it best to keep things as they are?

@nuest Thanks for chasing this up with Figshare! I'll update the tests and see what happens.
@betatim How much duplicated code is there between repo2docker and BinderHub for detecting providers? Is there enough to be worth refactoring, e.g. so BinderHub can import some detection functions from repo2docker.utils, or is it best to keep things as they are?

How much duplicated code is there between repo2docker and BinderHub for detecting providers? Is there enough to be worth refactoring, e.g. so BinderHub can import some detection functions from repo2docker.utils, or is it best to keep things as they are?

Short answer: yes there is enough that they should be sharing.
Longer answer: they should share but I don't know the details of why we haven't made it so yet, despite having talked about it in the past.
It would be cool to have a BinderHub PR that explores this, maybe we can even use the detect() methods and ordered list of content providers as they are without having to move repo2docker code around?

How much duplicated code is there between repo2docker and BinderHub for detecting providers? Is there enough to be worth refactoring, e.g. so BinderHub can import some detection functions from repo2docker.utils, or is it best to keep things as they are?

Short answer: yes there is enough that they should be sharing.
Longer answer: they should share but I don't know the details of why we haven't made it so yet, despite having talked about it in the past.
It would be cool to have a BinderHub PR that explores this, maybe we can even use the detect() methods and ordered list of content providers as they are without having to move repo2docker code around?

I've updated the regex to use (code/|dataset/)?
I tried using wildcards and character ranges but it caused other figshare tests to fail :disappointed:
@nuest would you mind asking your contact about the /1 versions again? The tests I marked as xfail are still failing:
curl -sIL https://doi.org/10.6084/m9.figshare.9782777.v1 | grep location

This first redirects to https://figshare.com/articles/Binder-ready_openSenseMap_Analysis/9782777/1 ending with the version /1
This then redirects to https://figshare.com/articles/code/Binder-ready_openSenseMap_Analysis/9782777 which doesn't have a /1
Similarly for https://doi.org/10.6084/m9.figshare.9782777.v2 and https://doi.org/10.6084/m9.figshare.9782777.v3

I've updated the regex to use (code/|dataset/)?
I tried using wildcards and character ranges but it caused other figshare tests to fail :disappointed:
@nuest would you mind asking your contact about the /1 versions again? The tests I marked as xfail are still failing:
curl -sIL https://doi.org/10.6084/m9.figshare.9782777.v1 | grep location

This first redirects to https://figshare.com/articles/Binder-ready_openSenseMap_Analysis/9782777/1 ending with the version /1
This then redirects to https://figshare.com/articles/code/Binder-ready_openSenseMap_Analysis/9782777 which doesn't have a /1
Similarly for https://doi.org/10.6084/m9.figshare.9782777.v2 and https://doi.org/10.6084/m9.figshare.9782777.v3

Still WIP or could we already merge this and follow up on the versioning in a second PR? It makes me nervous to have our CI failures be "known to be harmless" because it encourages people to not be concerned about CI jobs failing :D

Still WIP or could we already merge this and follow up on the versioning in a second PR? It makes me nervous to have our CI failures be "known to be harmless" because it encourages people to not be concerned about CI jobs failing :D

I'm in favour of merging 😄

I'm in favour of merging 😄


getCreateFFmpegCore.js:13 Not allowed to load local resource on FFMpeg.load()

Describe the bug
When attempting to run ffmpeg.load(), I get an error:
getCreateFFmpegCore.js:13 Not allowed to load local resource<EMAIL_ADDRESS>To Reproduce
Steps to reproduce the behavior:

Get a PHP server
Run npm install @ffmpeg/ffmpeg @ffmpeg/core in documentroot of webserver.
Create index.php
Write down code below:

<script<EMAIL_ADDRESS><script type="text/javascript">
<?php
header('Cross-Origin-Embedder-Policy: require-corp');
header('Cross-Origin-Opener-Policy: same-origin');
?>
const { createFFmpeg } = FFmpeg;
const ffmpeg = createFFmpeg({
  corePath<EMAIL_ADDRESS>  log: true,
});
(async () => {
  await ffmpeg.load();
})();
</script>

Expected behavior
FFMpeg would load without errors.
Desktop (please complete the following information):

OS: Windows
Browser: Google Chrome
Version<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Webserver: VertrigoServ(apache+mysql+php)

Additional context
PHP server is not nessecary. I used PHP to add headers.
Why does source code contain somebody's static local path to file? Why did he(or she) leave it when pulling to the repo?

For anyone who has this issue, and uses browser, I have a solution:
Use this to create FFMPeg Object:
const ffmpeg = createFFmpeg({
  corePath<EMAIL_ADDRESS>  log: true,
});

and use my ffmpeg.min.js where paths that are causing problem, are fixed.
I used following syntax: window.origin+"/node_modules/@ffmpeg/ffmpeg/src"
That works for me.
ffmpeg.min.js.zip


Fixes

Hello,
I tried ND on Windows with VSCode 1.87.1 and GDB 14.2 and ran into a lot of problems. I fixed some of them:

the debugger can now display thread names
local variables actually work, they were completely broken
I changed the default to "prettyPrinters"
prevented the error message "Selected thread is running." from displaying, it's not an error
cleaned up the code a bit in a separate commit

It still does not display global or member variables, maybe I will fix it later.

Codecov Report
Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 20.38%. Comparing base (a6f48d6) to head (ec2a93a).

Files
Patch %
Lines

src/backend/mi2/mi2.ts
0.00%
9 Missing :warning:

src/backend/backend.ts
0.00%
7 Missing :warning:

src/mibase.ts
0.00%
4 Missing :warning:

src/backend/mi2/mi2lldb.ts
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   20.55%   20.38%   -0.17%
==========================================
  Files          14       14
  Lines        1800     1805       +5
  Branches      388      390       +2
==========================================
- Hits          370      368       -2
- Misses       1385     1391       +6
- Partials       45       46       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

There were linting problems, so I ran npm update --save and then I had to upgrade typescript npm install<EMAIL_ADDRESS>--save-dev.

can you revert the package lock changes because of npm update --save and only run do the typescript update? The other stuff should not change

I reverted the changes and then I just did npm install<EMAIL_ADDRESS>--save-dev.


database/sql: Context cancellation doesn't

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.8beta1 linux/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/root"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?
https://play.golang.org/p/Y9jybN5zcQ
What did you expect to see?
Hello bub
delete error  context deadline exceeded
Hello bub

What did you see instead?
Hello bub
delete error  context deadline exceeded
No bub!

The output demonstrates the expectation when using a Context type isn't satisfied (cancellation doesn't happen and resources are not freed) and actual driver method output is discarded (discarding error types, even if nil, returned by the driver doesn't seem a reasonable design).
As implemented, at the very least I'd expect the methods with a Context parameter to panic if the driver doesn't implement what must be an optional interface.
On a related note:
    // Deprecated: Drivers should implement ConnBeginContext instead (or additionally).
    Begin() (Tx, error)

Is there a technical reason for deprecating Begin() for an interface used by a package described as "a generic interface around SQL (or SQL-like) databases," not "a generic interface around SQL (or SQL-like) databases with a practical cancellation facility?" The "instead" doesn't make sense, you can't not implement Begin() and fulfill driver.Conn. The "additionally" is also a little bizarre, if it's indeed deprecated why implement it? Why would Begin() be deprecated and Prepare() not? Why would ConnBeginContext and ConnPrepareContext be separate interfaces, shouldn't an implementation that's faking one or the other be required to fake both?
It seems there's a need to review this project's proposal procedures, code review process, compatibility guidelines, and general regard for the value of community implementations of standard library interfaces.

@j7b Hi Jake. I'm not sure how to respond to the last two paragraphs.
Let me address the cancelation expectation. The context can help in multiple locations: getting a free connection from the pool (there were multiple bugs open where a depleted pool could block forever), canceling a query during execution as you are testing above if the driver supports it (Please see https://docs.google.com/spreadsheets/d/1y7AzkFNPeTBado0xJJipB5MpWlcqylQg410Q5wHz2Ew/edit#gid=0 for implementation status, right now the driver you used doesn't support in-flight cancelation), it also help ensure connections are returned to the pool when you are done with it.
Yes, you still need a Begin() function, but if you implement BeginContext, your Begin function can be:
func (Conn) Begin() (Tx, error) {panic("use BeginContext")} as it won't ever be called. In the future where go1.8 to be the minimum I expect all drivers to be implemented as such, where Begin is just a stub. So in that sense, yes, it is deprecated.
These issues and CLs have been active for many months. You can review the history of them if you'd like. I think you even commented on some of the issues.
I don't understand what you mean here at all:

It seems there's a need to review this project's proposal procedures, code review process, compatibility guidelines, and general regard for the value of community implementations of standard library interfaces.

Does it seem like core go members are disregarding community involvement? I'm unsure of your intent.

As far as I can tell, for the first issue you raised this is working as expected. I'll keep this open if you'd like to clarify some of your secondary comments.

The release notes (https://beta.golang.org/doc/go1.8#database_sql) do note that:

enables canceling in-progress queries should the driver support that

But https://beta.golang.org/pkg/database/sql/ lacks that documentation. Thanks for the report. We did try to clarify everywhere in the package docs where features weren't available if the underlying driver doesn't support it.

// Deprecated: Drivers should implement ConnBeginContext instead (or additionally).

Yes, perhaps that could be clarified.

It seems there's a need to review this project's proposal procedures, code review process, compatibility guidelines, and general regard for the value of community implementations of standard library interfaces.

I'm not sure whether you intended for that to come across as passive aggressive. If you'd like to get involved in code reviews (https://golang.org/doc/contribute.html), or the proposal process (https://github.com/golang/proposal), you're certainly welcome. Even this process now with betas is part of a process (https://github.com/golang/go/wiki/Go-Release-Cycle). And we have a final-final API review every 6 months (e.g. https://groups.google.com/forum/#!topic/golang-dev/t5rvbW6OK9U, which generated feedback, as it tends to) before we lock in the API for later (https://golang.org/doc/go1compat). If you find any of our process flawed, please file a separate bug, and let's keep this bug about database/sql.
In any case, we'll work on the docs.
Thanks for the report.
/cc @kardianos


Wrap around swipe gesture

I think the fact that the swipe gesture stops when you reach the first screen causes me to accidentally click on of the streams listed there. Instead the gesture should wrap around so swiping at either end takes you to the first / last screen.

I am not sure about that...
This swiping gesture might even go away completely when we upgrade to React Navigation 2.
I tested several apps - YouTube and Twitter do not swipe at all between the bottom navigation icons, but do swipe between tabs, and don't swipe around.
Facebook does swipe between screens but when you are at the end you are there and don't go to the first one.

I find the swiping gestures really nice once they are discovered. Saves a lot of effort during navigation. I think the main problem that needs to be solved here is the accidental click of the stream icons. I'm not sure of a good solution but its happened to me more than 10 times during the course of my use which is why I bring it up.

(It's not explicit above, but I'm pretty sure this is about swiping between the "main tabs" at the bottom of the screen in the app's home view.)
This is now moot because we no longer have a swipe gesture between those -- quite possibly because of the upgrade Boris mentioned above. In general, the standard convention seems to be:

with top tabs, swiping navigates between them (it doesn't for us right now, but that's #3997), but
with bottom tabs, swiping doesn't interact with them at all,

so by not offering swipe between those tabs, we're following convention.


Update Typo3.gitignore

Added files and paths from TYPO3 CMS 6.*

How about adding:
Ignore deprection logs
/typo3conf/deprecation_*

@chuenniger unfortunately this isn't mergeable currently, and there are some queries from others about whether the rules are accurate :cry:
I need to clean up stale pull requests at some stage, and will close this out if I don't hear anything before Friday 26th February.


Apps targeting Android 14 lose input audio when phone is locked or app is in background

Describe the bug
Our production app targets Android 14 and uses the AudioSwitch. When users are on Android 14 and either lock their screen or put our app in the background, they can hear audio come through but audio input no longer works.
I've also been able to reproduce on the voice quickstart by bumping the targetSdk to 34. Doing so required the following changes to the project:

 <uses-permission android:name="android.permission.FOREGROUND_SERVICE_PHONE_CALL"/> to connection_service/AndroidManifest.xml
android:foregroundServiceType="phoneCall" to IncomingCallNotificationService in connection-service/AndroidManifest.xml
super.onRequestPermissionsResult(requestCode, permissions, grantResults); to onRequestPermissionsResult(...) in VoiceActivity.java

Similar to an older issue, but new for Android 14.
To Reproduce
Steps to reproduce the behavior:

Start a call
Confirm input/output audio works
Lock screen OR put app in background
Input audio no longer works

Expected behavior
Locking screen or putting app in background with the foreground service started should keep the input audio working
Actual behavior
Locking screen or putting app in background causes the input audio to stop working
Application Logs

AudioSwitch with logging enabled set to true outputs no logs when locking the screen.

AudioSwitch Version

Version: 1.1.8

Android Device (please complete the following information):

Device: Confirmed on Pixel 8 Pro, Pixel 7, Samsung S23
API Version: API 34

Screenshots
N/A
Additional context
N/A

@AlanMTuring This is probably due to the activity being backgrounded. What happens if instead of passing the activity context to the Voice.Connect, you passed the application context, this issue should not happen.

In our production app, we are already passing in the application context to the voice connect and into the AudioSwitch creation, and the problem is still there.
With the quickstart, I edited the code in VoiceActivity.handleCallRequest() so that Voice.connect takes in the application context and in VoiceActivity.answer() so that activeCallinvite.accept() also takes in the application context. After those changes, i was still able to reproduce the issue.

@AlanMTuring ok, My next question is are you integrating with the ConnectionService API? If not, you shouldn't be using the FOREGROUND_SERVICE_PHONE_CALL and instead should use FOREGROUND_SERVICE_MICROPHONE.. For more info look here..
Continue microphone capture from the background, such as voice recorders or communication apps.
https://developer.android.com/about/versions/14/changes/fgs-types-required#microphone

@AlanMTuring  are you facing the issue of auto-selected audio mode from Speaker/BT to earpiece mode after some time when the application is put in the background?
Interestingly, when I tried to switch the audio mode from the phone to the speaker or Bluetooth, it didn't work and the audio continued to come through the earpiece.
Current audio switch SDK version :
  implementation 'com.twilio:audioswitch:1.2.0'
Please help me.


Change Build number

Describe the solution you'd like
I would like to be able to change the build Number.
my case was someone published manually with build number 7100 and automated build is around 100! so now i can not utilize the auto increment because the existing build number is less then the one published to the store.
it would be great if can manually set it to a specific integer and it continues to increment from that number.
Describe alternatives you've considered
I tried to write a power shell script to set the build number environment variable but it didnt work.

@elamalani will there be a fix for this soon? This was promised a very long time ago.


Net::IMAP connection uses insecure deprecated options

The parameters that are used to create the Net::IMAP connection in Mail::IMAP are undocumented:
https://github.com/mikel/mail/blob/b6b6cb737d47a85ddc720fda0e6b991e99224848/lib/mail/network/retriever_methods/imap.rb#L167
I believe the documentation was removed in 2007 (ruby/net-imap@e631911e).  Pending the following PR: ruby/net-imap#175, the next release of net-imap will print a deprecation warning when those parameters are used.  About a year later, they'll be removed entirely.
A bigger issue is that the fifth and final argument is false: that is the verify parameter and by setting it to false, the SSLContext will have verify_mode: OpenSSL::SSL::VERIFY_NONE.
Proposal
When Hash.try_convert(enable_ssl) returns a Hash, that will be used with
  Net::IMAP.new(settings[:address],
                port: settings[:port],
                ssl: Hash.try_convert(settings[:enable_ssl]))

When Hash.try_convert(enable_starttls) returns a Hash, that will be used with
  imap.starttls Hash.try_convert(settings[:enable_starttls])

In this way, any SSLContext attribute can be set.
When enable_ssl or enable_starttls are truthy but not hash-like, use {}.  This way, the default is secure.
I can write a PR for this, if you agree with my proposal.

I haven't tested this yet, but it's tentatively as simple as the following:
        ssl      = settings[:enable_ssl]
        starttls = settings[:enable_starttls]
        ssl      &&= Hash.try_convert(ssl)      || {}
        starttls &&= Hash.try_convert(starttls) || {}

        imap = Net::IMAP.new(settings[:address], port: settings[:port], ssl: ssl)

        imap.starttls(starttls) if starttls

Some mail servers use self-signed certificates, there is not much wrong with that because they mainly care about encryption (which self-signed provides), and care less about MITM (because that's pretty rare on server to server communication). So I would keep the default VERIFY_NONE. If we do decide to change it then make sure to update the major gem version version, because this will break stuff for some people.

This library is used in plenty of situations where the identity of the remote server cannot be safely assumed.
Although I understand this will be considered a breaking change by some people, as far as I'm concerned this is shocking behavior.  It's broken for everyone now, to put it mildly.  Fixing security bugs this severe should not cause a major version bump for the simple reason that a major version bump will prevent users from receiving the security fix.  Every bugfix changes behavior, by definition, and that always runs the risk of being backward incompatible for someone.  The API is compatible and it should only affect servers or clients that have been misconfigured.
We might not have been surprised by this as the default in 2012 (unfortunately).  But in 2023, there is frankly no excuse for a TLS client to not verify the server's identity by default.  If users can't figure out how to set up Let's Encrypt or add a ca_file or ca_path to their SSLContext, then they should be forced to explicitly ask for VERIFY_NONE.  This is how nearly every other piece of client software has worked for over a decade.
From RFC-3501 (2006):

During the [TLS] negotiation, the client MUST check its understanding of the server hostname against the server's identity as presented in the server Certificate message, in order to prevent man-in-the-middle attacks.  If the match fails, the client SHOULD either ask for explicit user confirmation, or terminate the connection and indicate that the server's identity is suspect.

For the purposes of a library like this gem, verify_mode: OpenSSL::SSL::VERIFY_NONE can satisfy the "explicit user confirmation" requirement.  And, fortunately, PR #1587 should make it relatively easy for users who want to do so.  🙂  (Although, why not set ca_file instead?)

Also, for what it's worth, net-imap v0.4.0 was released last week, and it does include ruby/net-imap#175.  Let me know if this PR needs any changes. 😉

I asked Google Bart about the he number of mail servers with a self-signed certificates, and after some prodding it came up with 7%, stating that most of those would be on internal corporate networks (where you can't easily get a certificate). No idea about the accuracy. Anyway, I'm fine with the PR as it stands, I'm sure the people who need it can find a way to disable verification again, but the mail gem maintainers are the ones to convince.

I'm sure the people who need it can find a way to disable verification again

I'm currently working on SASL-related PRs for both net-smtp and net-pop.  And, although net-imap has deprecated this particular call signature (Net::IMAP.new(host, port, true, ca_certs, verify)) in favor of the ssl: ssl_context_params, I notice that net-smtp uses has tls_verify and tls_hostname keyword params, in addition to ssl_context_params.
So, if it's important, I think it's fine to add tls_verify: false as a shortcut for ssl_contect_params: {verify_mode: OpenSSL::SSL::VERIFY_PEER}.

I updating to rails 7.1.2 . How to overwrite imap.rb start method?
I got frozen error.
FrozenError (can't modify frozen Net::IMAP::SearchResult: [74611, 75420, 75885, 75887, 75910, 75940]):
config/initializers/mail_imap.rb:26:in `start'
`
require 'mail'
module Mail
class IMAP
def start(config = Mail::Configuration.instance, &block)
raise ArgumentError, "Mail::Retrievable#imap_start takes a block" unless block_given?
raise ArgumentError, ":enable_starttls and :enable_ssl are mutually exclusive. Set :enable_ssl if you're on an IMAPS connection. Set :enable_starttls if you're on an IMAP connection and using STARTTLS for secure TLS upgrade." if settings[:enable_starttls] && settings[:enable_ssl]
  ssl      = settings[:enable_ssl]
  starttls = settings[:enable_starttls]
  ssl      &&= Hash.try_convert(ssl)      || {}
  starttls &&= Hash.try_convert(starttls) || {}

  imap = Net::IMAP.new(settings[:address], port: settings[:port], ssl: ssl)

  imap.starttls(starttls) if starttls

  if settings[:authentication].nil?
    imap.login(settings[:user_name], settings[:password])
  else
    # Note that Net::IMAP#authenticate('LOGIN', ...) is not equal with Net::IMAP#login(...)!
    # (see also http://www.ensta.fr/~diam/ruby/online/ruby-doc-stdlib/libdoc/net/imap/rdoc/classes/Net/IMAP.html#M000718)
    imap.authenticate(settings[:authentication], settings[:user_name], settings[:password])
  end

  yield imap
ensure
  if defined?(imap) && imap && !imap.disconnected?
    imap.disconnect
  end
end

end
end
`

FYI the deprecation warning in Net::IMAP has appeared.  I appreciate the discussion above regarding 'breaking changes', but if this issue isn't addressed one way or another reasonably shortly all use of IMAP by users of this library will break.


Provide more prebuilt binaries

For CI systems where this tool might be used, I find it sometimes quite convenient to be able to just download a prebuilt binary instead of building it myself. I'd suggest building for all kinds of architectures and operating systems. For example, see the binary matrix and GitHub Action for it.

I am already building a deb precisely for that purpose.

I'd suggest building all kinds of architectures and operating systems.

In theory why not but that means extra maintenance so it would have to be proven it is worth it.
Do you feel like making a PR ?

It would be totally worth it! 👍

Anyone up for a PR ?


GC isn't the allocator for everything

Some allocations are not tracked by the GC. Namely the contents of strings, struct fields, so on and so forth.

Unfortunately implementing this without reimplementing a major part of Rust's stdlib is impossible. We need to wait for the allocator API to land.


Simplify mixins API

I think we should remove callFirstMixin method. While it helps with the common case, I think that getFirstMixin is enough. You can always do .getFirstMixin('property')?.property(). This would also give you an exception if property is not a function. Which we currently ignore in callFirstMixin and return undefined. Which makes it impossible to distinguish between an error and returned value undefined.
callMixins and foldMixins are interesting, but maybe they should not be part of the core API. Instead, a more low-level method could be offered:
getNextMixin: (mixin, propertyName) ->

This would return the next mixin with propertyName after the mixin mixin. In some way this is similar to super, just that it moves across mixins. So from a component you call:
foo: ->
  @getFirstMixin('foo')?.foo()

And that mixin can then do:
foo: ->
  @mixinParent().getNextMixin(@, 'foo')?.foo()

In some way, mixins themselves control the traversal. Instead of caller controlling when calling callMixins and foldMixins (it goes over all mixins no matter what).
And getFirstMixin('foo') could be simply the same as getNextMixin(null, 'foo'). Or we should have getFirstMixin(propertyName, [mixinToSearchFrom]). Or getMixinWith(propertyName, [mixinToSearchFrom])?
(What would be a way then to implement callMixins and foldMixins using getFirstMixin and getNextMixin?)

Decided to go with getMixinWith: (afterMixin, propertyName) and callMixinWith: (afterMixin, propertyName, args...).

(Mixins are new to me, so this may be flawed / I may have misunderstood)
I think the most intuitive structure would be:
getMixin: (mixinName, [methodNames])
callMixin: (mixinName, methodName, args)
I don't think you need to include First - just make it clear in the docs that this targets the first matching mixin, like Blaze.find.

also, callFirstWith is ambiguous - it could be interpreted as first component.

Yes, getFirstWith can return both a component or a mixin. So getMixin is not really correct in this case. callFirstWith is then analogous.
So yea, I am not satisfied the most with this naming, but it was the best from the bad ideas. If you have a better proposals, keep them coming. :-)
We could name it also getRight and callRight. :-) So, just something abstract. (See the mixins diagram to understand why "right".)

getRight could be misinterpreted as 'get correct' rather than 'to the right of' (or below, depending on how you visualise it)
My initial thoughts are that there needs to be a clearer line between mixins and components. For example, don't think they should share functions as with getFirstWith.
Have a look at this diagram:

We could then have separate methods such as
BlazeComponents.getMixin or BlazeComponents.addMixin
to import, so you wouldn't have to add Mixin to the end of every name, and
callMixinMethod(mixinName, mixinMethod)

Yes, this is a good question if we should split mixins and components. There could be some helper functions which would be meaningful only for mixins and we could add them there.


Tab v-model not updating

Describe the bug
As tabs are activated in a tab bar, their v-model isn't updating to reflect the tab state. They appear to listen to model updates correctly, but the active prop doesn't update when the tab is activated, so they never update the model.
To Reproduce
https://codepen.io/anon/pen/MddGpr
(based on https://github.com/matsp/material-components-vue/blob/master/docs/.vuepress/components/TabsDemo.vue)
Expected behavior
As tabs are selected, their bound v-model should update (in the case of the codepen above, I would expect the state of tabs to mutate)

I should add, I've not forgotten your suggestion that I contribute to updating the docs - I'd love to, once I'm out from under a few deadlines. I definitely empathise with your workload constraints, and am extremely grateful for your support!

I faced the same issue when I was updating the whole project to 1.0.0 version. I post an issue about it in https://github.com/material-components/material-components-web/issues/4505

This is useful, thanks for the pointer. It's a shame to see that the developers consider the use case out of scope. Does https://codepen.io/anon/pen/ZNNqWw seem like the best way to work around this (it's akin to https://github.com/material-components/material-components-web/issues/4505#issuecomment-473065096 I think)?

I believe there's still possible to use v-model, I've already have some possible solutions in my mind.

A possible solution is to use something like MutationObserver to 'observe' the class change. Another possible solution is to listen to the MDCTab: interacted event. It's nighttime in China now, I'll fix it tomorrow.
If you can handle it, pull request is welcomed.


Update sbt, sbt-dependency-tree, ... to 1.10.6

About this PR
📦 Updates

org.scala-sbt:sbt
org.scala-sbt:sbt-dependency-tree
org.scala-sbt:scripted-plugin

from 1.10.5 to 1.10.6
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:early-semver, commit-count:1

Superseded by #73.


ImportError: cannot import name 'configuration' from 'tsutils'

ImportError: cannot import name 'configuration' from 'tsutils'
I tried to install tsutils still it is showing same issue. which version of TSUtil I should use

tsutils is a folder in the transcribe repo.
The description seems to indicate that there is an issue with the environment set up

I tried to install tsutils still it is showing same issue. which version of TSUtil I should use

Please provide details of what remediation was attempted. Some screenshots would be useful.
give us some insight into the dev environment and we might be able to help with this issue

closing as environmental issue. We will need more details as illustrated above to help.


use the full button space to redirect

hey @DavidWells, I made a fix for the settings button. I explained it in the video:

word! I was seeing this too.
Thanks!


Caesar encryption

name: Caesar Ghazi
about: caesar_encryption

Behavior
Files

[x] The file name describes the function's behavior
[x] There is a module docstring in the function file
[x] The test file's name matches the function file name -
/tests/test_file_name.py
[x] There is a module docstring in the tests file

Unit Tests

[x] The test class has a helpful name in PascalCase
[x] The test class has a docstring
Every unit test has

[x] A helpful name
[x] A clear docstring
[x] Only one assertion
[x] There is no logic in the unit test

[x] All tests pass
[x] There are tests for defensive assertions
[x] There are tests for boundary cases

Function Docstring

[x] The function's behavior is described
The function's arguments are described:

[x] Type
[x] Purpose
[ ] Other assumptions (eg. if it's a number, what's the expected range?)

The return value is described

[x] Type
[x] Other assumptions are documented

The defensive assertions are documented using Raises:

[x] Each assumption about an argument is checked with an assertion
[x] Each assertion checks for only one assumption about the argument

[ ] Include 3 or more (passing!) doctests

The Function

[x] The function's name describes it's behavior
[x] The function's name matches the file name
[x] The function has correct type annotations

Strategy
Do's

[x] Variable names help to understand the strategy
[x] Any comments are clear and describe the strategy
[x] Lines of code are spaced to help show different stages of the strategy

Don'ts

[x] The function's strategy is not described in the documentation
[x] Comments explain the strategy, not the implementation
[x] The function does not have more comments than code

If it does, consider finding a new strategy or a simpler implementation

Implementation

[x] The code passes the formatting checks
[x] The code passes all Ruff linting checks
[x] The code has no (reasonable) Pylint errors

In code review, you can decide when fixing a Pylint error is helpful and
when it's too restricting.

[ ] Variables are named with snake_case
[x] Variable names are clear and helpful
[x] The code follows the strategy as simply as possible
[x] The implementation is as simple as possible given the strategy
[x] The code includes defensive assertions
[x] Defensive assertions include as little logic as possible

Nada is reviewing this

Nice work on both the function and the tests! Code is clear and easy to understand. I don’t have anything to add, everything looks solid👍

otherwise the code and tests are good nice work

thank you so much both for your effort and for taking the time to review this challenge, i truly appreciate it .


I'm not able to test my injectable class

Versions:

injector==0.18.3
Flask-Injector==0.12.3
python == 3.6.9

Problem:
I am looking to test a service which has the inject annotation in its constructor to be injectable. However, I am not able to test it. According to the documentation I need to do this:
import unittest
from injector import Module, with_injector, inject
class UsernameModule(Module):
    def configure(self, binder):
        binder.bind(str, 'Maria')

class TestSomethingClass(unittest.TestCase):
    @with_injector(UsernameModule())
    def setUp(self):
        pass

    @inject
    def test_username(self, username: str):
        self.assertEqual(username, 'Maria')

But copying and pasting this code without touching anything, gives the following problem:

Can anybody help me?

Ugh, sorry, I forgot to remove this part of the documentation. with_injector is gone. You need to create an instance of Injector on your own and use it, the simplest case
def test_username(self):
    injector = Injector(UsernameModule())
    assert injector.get('str') == 'Maria'

@jstasiak It would look like this: from injector import Module, Injector, inject?

Yup

@jstasiak Could you update the documentation, please? I'm doing a task to insert the unit tests in the project kkkkk

Why is this issue closed?  The docs in master are still incorrect: https://github.com/alecthomas/injector/blob/master/docs/testing.rst


[BUG] When I run teaser_cpp_fpfh example,I run into this problem

Thanks for your work.!!!I followed the steps to compile Python binding, everything went well, but when I run teaser_python_ply.py or other examples, the following error appears, how can I solve it?
Describe the bug
ModuleNotFoundError: No module named 'teaserpp_python.teaserpp_python'
Have you run the unit tests?

[ ] Yes

Installed Dependencies
ubuntu 20.01
To Reproduce
(teaser_test) root@yjh-virtual-machine:/home/yjh/TEASER-plusplus/examples/teaser_python_ply# python teaser_python_ply.py
Traceback (most recent call last):
File "teaser_python_ply.py", line 5, in
import teaserpp_python
File "/home/yjh/anaconda3/envs/teaser_test/lib/python3.6/site-packages/teaserpp_python/init.py", line 1, in
from .teaserpp_python import *
ModuleNotFoundError: No module named 'teaserpp_python.teaserpp_python'

Have you build your teaserpp_python module with pybind11?

Have you build your teaserpp_python module with pybind11?

Have you built your teaserpp_python module with pybind11?
Thank you for answering patiently！ I have solved the problem

I met the same error, may you share the experience of fixing it? thx so much!


disable border drag

Description of the new feature / enhancement
Is it possible to disable border drag (to resize window)?
Scenario when this would be used?
because there is really no need since I have the zones set up already and I want the windows to stay in the zones fully all the time, sometimes I want to click something on the top but dragged the border instead, and I have to move the window to make it fit in the zone correctly again.
Supporting information
No response

I think it is possible to set a "flag" for the windows style (that'd possibly be removing WS_EX_WINDOWEDGE ?) but I think then there must be a process running in the background that continuusly checks for newly shown windows, so that would affect performance.

This would be a significant quality-of-life improvement. I see it as similar to the disable-rounded-corners option for snapped windows. Currently it is very easy to accidentally drag-and-resize a snapped browser window when trying to select tabs.


Normalize handling 403 for rate limits on 'dataset.create()'.

Fixes #2075.

Re: the error predicate -- I'm reluctant to add it because it makes the test flakier with respect to the back-end, which might change the error text arbitrarily and without notice.

We could deal with backend changes if / when tests fail. You can make it a bit less brittle via:
'rate limit' in error.message.lower()

In 994edc7, I figured out that we capture the JSON error structure, which means we can use the documented rateLimitExceeded reason code, rather than sniffing at the message text.

Nice find! LGTM


Suggest to implement getCookie.

I know we can get cookie using $_COOKIE, but it is much better we can get the cookie using this project. so we can manage all cookies using this library.

Thanks!
That makes sense, and it will not be much code, so it won’t be too much overhead for those who don’t want to use it.
What about the following two static methods?
Cookie::exists('my_cookie_name');

// and

Cookie::get('my_cookie_name');
// or
Cookie::get('my_cookie_name', $myDefaultValue);

Cookie::exists('my_cookie_name');

Cookie::get('my_cookie_name');

I think default value should be handled by developers. not by his project.

Given that the parameter for the default value will be optional, anyway, I don’t see any problem with that. The other syntax is not available yet for everybody, but will soon be, of course. So then everybody will be able to just use the syntax they prefer.

Implemented in:

https://github.com/delight-im/PHP-Cookie/commit/c1a50c1a98f1c20ba274a95aa9bbab2cb95471de
https://github.com/delight-im/PHP-Cookie/commit/ab98e92766a6e806ea08df47f205e13b2dd531e8
https://github.com/delight-im/PHP-Cookie/commit/99e95650fccdc97e8714e14631edb665ae4c8751


Append +0 to first dirty version after tag

I wanted to fix #53 but you asked for #52 to be fixed first, so this adds a +0 for dirty snapshots directly after a tag.
In the original bug ticket you say that you also want to add +0000 but I'm confused by this. There was also the suggestion about adding the commit SHA, too.
Can you elaborate what should be there?
Fixes #52.

Thanks for taking the time to look into this!
So with this change a dirty repository on a tag has a version like 1.0.0+0-20140707-1030, and after a couple of commits it would be something like 1.0.0+3-1234abcd-20140707-1030. It might be nice to make those 2 even more consistent by including the headSha in both cases, so the dirty repository on the tag would be like 1.0.0+0-abab2323-20140707-1030.
What do you think?

I think @xerial's suggestion (https://github.com/dwijnand/sbt-dynver/issues/53#issuecomment-355364899) is even better than my original one:

Instead of using 0000000 (+0 commit), we should use the actual revision like:
1.0.0+0-xxxxxxx-20140707-1030

This is more informative to tell which git revision is used.

To that end I think all that is needed is dropping the isEmpty from GitCommitSuffixOps's mkString.

I'm happy implementing this but I'm wondering: Aren't you two (@raboof, @dwijnand) suggesting the same thing?

I think we're in violent agreement here, yes ;)

Yep! Arnout's comment hadn't loaded in my tab by the time I got round to leaving my comment.

I took a first stab at implementing this. The problem is that the output of git describe doesn't contain the SHA1 information.  We can
use that output as is without any magic checking it seems.
I'll try it out.
Am 19.02.2018 10:17 nachm. schrieb "Alexey Alekhin" <
<EMAIL_ADDRESS>
@leonardehrenfried https://github.com/leonardehrenfried probably you
need to use --long option?
$ git describe
v2.0.2
$ git describe --long
v2.0.2-0-gd0b6f72
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dwijnand/sbt-dynver/pull/63#issuecomment-366804787,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJPMiI2hbQheJTAdxzJ4MUcnZqBrl1yks5tWeTxgaJpZM4SJYSo
.

Take into account that it has an extra letter g before the commit SHA and abbreviation is 7 letters by default. I don't know if you can remove g, but you can add --abbrev=8 if you need.

We use --abbrev=8 and manage the extra g already: https://github.com/dwijnand/sbt-dynver/blob/v2.1.0/src/main/scala/sbtdynver/DynVerPlugin.scala#L125-L127
Good find on --long!

I think this is good for another round of reviews.
I removed the isEmpty check completely and moved all the if statements into GitDescribeOutput instead.

But I still think this ready to merge.

@leonardehrenfried could you also update the readme?

Thanks @leonardehrenfried. I'll try to get to this tomorrow.


Setting keyframes from code

I'm creating some procedural animations, and would like to visualize them and continue editing with theatre.
I looked into some of the code for the detail pane, and things like setKeyframeAtPosition, however I can't get that to work / it doesn't seem to be documented.
Is there an example for something like "create 10 keyframes for a specific object in code and continue to work on it in theatre"?
Thanks!

I am a beginner in this theatrejs.
I have tested and found something like below works.
  studio.transaction((api) => {             for (let i = 0; i <= 10; i++) {                 sheet.sequence.position = i;                 api.set(obj1.props.left, i * 100);             }         })

Late to this, but we're currently running up against this same issue. It'd be nice if there were a little cleaner API but it's definitely doable.
Automating the track data would require calling something like stateEditors.ts _ensureTracksOfObject from within set. Is this something you'd be open to @AriaMinaei ?


DocService gRPC set host name explicitly

Some HTTP headers do not exist when I check chrome devtools to see which headers are sent. How can I send grpc requests with headers in this case? There can be some auth tokens needed in order to test those endpoints.
Some example headers: host, origin, content-type.

Also I want to be able to set the host, for example we can have different URLs for local, test and production environments and I want to be able to send to the specified URL from this page.

Hi, we are using fetch API inside and Host and Origin headers are forbidden to overwrite.
https://stackoverflow.com/a/43285338
https://developer.mozilla.org/en-US/docs/Glossary/Forbidden_header_name
I guess if you want to change the host header, you need to actually reconnect the domain through the browser.
Except those headers, we can set them via the HTTP HEADERS section.

@minwoox Should I use sb.virtualHostName(...) in order to make my debug form work correctly? But the issue is virtual host names can't include / so if my service is served under example.com/my-armeria-server/ it is not possible to set that as the virtual host.
Also our server is accessible from multiple different hosts, my-armeria-server.example.com internally and example.com/my-armeria-server/ externally.

Should I use sb.virtualHostName(...) in order to make my debug form work correctly?

A hostname can be added to the Virhost hosting. So you can't set a context path to the virtual hosting.

In my case, when I access my service from www.test.com/my-service URL rather than www.my-service.com, the doc service (www.test.com/my-service/docs) redirects to www.test.com/docs/#.

I'm failing to understand this problem. IIUC, a DocService is bound under /my-service/docs, it is redirected to /my-service/docs/. Could you elaborate a little bit on how /my-service/docs redirects to /docs/#?

Should I use sb.virtualHostName(...) in order to make my debug form work correctly?

A hostname can be added to the Virhost hosting. So you can't set a context path to the virtual hosting.

In my case, when I access my service from www.test.com/my-service URL rather than www.my-service.com, the doc service (www.test.com/my-service/docs) redirects to www.test.com/docs/#.

I'm failing to understand this problem. IIUC, a DocService is bound under /my-service/docs, it is redirected to /my-service/docs/. Could you elaborate a little bit on how /my-service/docs is redirected to /docs/#?

Our microservice serves DocService under /docs exact path. But the issue is there are several URL paths that lead to our microservice (one for internal use, one for external use).
Internally, we access it via the http://my-service.test1.com link, developers can't access it this way to the doc service.
Externally the same microservice is served under the http://test2.com/my-service link and developers access the service using this link.
So the issue is that if you use DocService and visit http://test2.com/my-service/docs, it sends a redirect request to http://test2.com/docs/#/ which is not the right URL. You can trick this by directly visiting http://test2.com/my-service/docs/#/ (Note the # hashtag).
Moreover, if you try to use the debug form, the requests are sent to http://test2.com/com.example.grpcRequest rather than the http://test2.com/my-service/com.example.grpcRequest URL. I need to find a way to set this host explicitly so my requests are sent to the correct URL.

I understood your problem. 😀
Armeria provides a port-based virtual hosting for that usage.
If you are not using Spring auto-configuration, we can manually make some internal services bound to internal ports (18080).
Server.builder()
      .virtualhost(internalPort)
      .serviceUnder("/docs", new DocService())
      .build();

If you don't like the port-based virtual hosting, we may offer an option to allow additional hostnames for DocService.
DocService.builder()
          .exampleDomains("http://test2.com/my-service/docs")
          ...

I understood your problem. 😀 Armeria provides a port-based virtual hosting for that usage.
https://github.com/line/armeria/blob/39df04b928d5125d3fb7a8a42651817df4200adc/spring/boot2-autoconfigure/src/main/java/com/linecorp/armeria/spring/ArmeriaSettings.java#L67-L69
If you are not using Spring auto-configuration, we can manually make some internal services be bound to internal ports (18080).
Server.builder()
      .virtualhost(internalPort)
      .serviceUnder("/docs", new DocService())
      .build();

If you don't like the port-based virtual hosting, we may offer an option to allow additional hostnames for DocService.
DocService.builder()
          .exampleDomains("http://test2.com/my-service/docs")
          ...

I am investigating the virtualhost. Currently when I serve grpc requests under the virtualhost(externalPort) and doc service under virtualhost(internalPort), I am not seeing any of those endpoints. But I guess serving grpc services under both external and internal ports is a valid use-case (I have done this by not specifying virtualhost on any of the services).
Even though this might work, I think exampleDomains can be still a valuable option. I will return once our infra is ready to test the virtualhost approach.


Add a dev requirements file

A dev-requirements.txt file can include

pytest
pytest-mock

The docs should be adapted accordingly (in the Test section of the README)

Done in 8f656ad9378d344c6777904725c0f9ba58676d43