Enum string index access/narrowing string to valid enum key

Suggestion

🔍 Search Terms

enum index signature
enum type guard
enum type narrowing
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Allow accessing an enum using a string via the index signature:
enum Test { ... }
const key: string = '...';

// Should ideally be of type `Test | undefined`, even without `noUncheckedIndexedAccess` because
// this apparently is an uncommon use case.
const value = Test[key];

Alternatively require a check that narrows the type from string to the enum type:
enum Test { ... }
const key: string = '...';
if (key in Test) { // Error without this
    const value = Test[key];
}

📃 Motivating Example

This would allow mapping of values that are potentially out of range/unsafe to an enum value.
E.g. if an URL path should be part of the enum, but is not guaranteed to be due to potentially different user inputs:
enum Section {
    details = 0,
    history = 1,
    //...
}

const pathTail = new URL(document.location).pathname.split('/').reverse()[0];
const currentSection = Section[pathTail] ?? Section.details;
// Or if check would be required first:
const currentSection = pathTail in Section ? Section[pathTail] : Section.details;

💻 Use Cases

This can be used in scenarios where a name needs to be mapped to an enum value for processing/storage but the input is unsafe (user input, third party system or API). My current workaround is to just add // @ts-expect-error because the JS already behaves as expected.

The enum objects are bidirectional, so if key is "0" you'll get back "details". You can use Test[key as keyof typeof Test] if you want to proceed anyway

I was aware of the bidirectionality but forgot about the fact that properties are always strings, so as you mentioned there would be nothing preventing a lookup via a string containing an integer.


Shorten page title in file view

Move the more relevant sections of the page title earlier which make it possible to distinguish multiple tabs from each other when tab width is limited.
Before:

After:

make L-G-T-M work


APP-2985: Protos for endpoint to register fusionauth applications

APP-2985
Created protos to register fusion auth apps. Not sure if end_user is the right place for this? was thinking maybe but still getting acquainted with this stuff so open to feedback if it should be moved elsewhere.

LGTM but I think we should remove application_name to save ourselves the additional effort. To answer your open question, I think putting this in end_user.proto is perfect.

assume you mean application_id not application_name?


Add P-Asserted-Identity header support

RFC 3325 indicates:
Typically, a user agent renders the value of a P-Asserted-Identity
header field that it receives to its user.  It may consider the identity
provided by a Trust Domain to be privileged, or intrinsically more
trustworthy than the From header field of a request.  However, any
specific behavior is specific to implementations or services.
The header has been added so that UA's can use it instead of the
remoteIdentity if this behavior is required.
Polycom, SNOM, Bria, Ekiga                                                                                render the P-Asserted-Identity header if they receive it during a
reINVITE, or in a 1xx/2xx response.

Looks good. I will leave it open for a few days to see if anyone else has comments then merge it assuming nothing comes up.

Thanks!


Match branches on the head branch for the PR instead of the temporary PR checkout

github.context.ref was producing something like refs/pull/23/head, which would not match.
Using github.context.payload.pull_request.head.ref resolves this for me and uses the branch name that I actually want to match on.

Awesome. Thanks for taking the time to merge this in. Now hopefully someone takes a look at https://github.com/actions/labeler/pull/203.


add the the errorHandler option to the gateway

My understanding is that we are missing the code that set the errorHandler from the options when instantiating a *Gateway with NewClient. I could have provided a default function that would be,func(err error) error {return err} but since the function is only used in do and there is a test to check the function exists, it can be avoided.

There is something I do not understand. I have seen you should use WithErrorHandler to register and get an option. Yet I it should not be enough. What do I miss in that case?

I have revert (commented) my change
I have created a test called TestWithErrorHandler. You can see it is failing:

go test -v -run TestWithErrorHandler
=== RUN   TestWithErrorHandler
    opts_test.go:28: spy should be true, got false
--- FAIL: TestWithErrorHandler (0.53s)
FAIL
exit status 1
FAIL	github.com/dontpanicdao/caigo/gateway	0.732s

Now if you set my change back, you see the test is succeeding:
go test -v -run TestWithErrorHandler
=== RUN   TestWithErrorHandler
spy triggered
--- PASS: TestWithErrorHandler (0.52s)
PASS
ok  	github.com/dontpanicdao/caigo/gateway	0.803s

Can you check again and explain what I am missing?

Understood. WithError was applied to the opts and not the actual gateway client


added a couple new features

Hey @arnaudmiribel, I thought it might be interesting to add a snowflake flag that automatically adds space in the secrets file for usernames, passwords, etc, and also adds a sample query. This isn't exactly ready yet (mostly because the streamlit app doesn't work OOB with this setup), but I just wanted to toss this idea by you (i'm also super bored)

Hey @tylerjrichards, sorry I only react now!
Loving this idea that we can add Snowflake along. I have taken inspiration from your work while refactoring in https://github.com/arnaudmiribel/st/pull/4 - now the templating is not done with raw strings anymore but leveraging st-cookiecutter which will add Snowflake creds into secrets whenever a user says yes to the Are you connecting to Snowflake in this app? prompt!
$ cookiecutter st-cookiecutter
app_name [app]:
app_title [My Streamlit app]:
app_uses_secrets [1]:
app_is_multi_page [1]:
app_uses_snowflake [0]: 1

$ cd app
$ tail .gitignore
# mypy
.mypy_cache/
.dmypy.json
dmypy.json

# Pyre type checker
.pyre/

# Add Streamlit secrets to .gitignore
.streamlit/secrets.toml

$ cat .streamlit/secrets.toml
# Learn more about Streamlit secrets!
# docs.streamlit.io/streamlit-cloud/get-started/deploy-an-app/connect-to-data-sources/secrets-management#develop-locally-with-secrets

[snowflake]
    user = "..."
    account = "..."
    password = "..."
    warehouse = "..."

Please add your tests and thoughts to the PR in https://github.com/arnaudmiribel/st/pull/4


Add support for CREATE EXTERNAL TABLE from Python

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
>>> df = ctx.sql("CREATE EXTERNAL TABLE orders STORED AS PARQUET LOCATION '/mnt/bigdata/tpch/sf1-parquet/orders'")
>>> df.show()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
Exception: Arrow error: External error: Execution error: Job hZh0A3x failed: Error planning job hZh0A3x: DataFusionError(Internal("Unsupported logical plan: CreateExternalTable"))

Describe the solution you'd like
Make this work
Describe alternatives you've considered
None
Additional context
None

It actually does work but we get an error if we try and show the results of the DataFrame. This is not good UX so we will need to fix.
>>> import ballista
>>> ctx = ballista.BallistaContext("localhost", 50050)
>>> ctx.sql("CREATE EXTERNAL TABLE orders STORED AS PARQUET LOCATION '/mnt/bigdata/tpch/sf1-parquet/orders'")
<ballista.DataFrame object at 0x7f501f088150>
>>> df = ctx.sql("SELECT count(*) FROM orders")
>>> df.show()
+-----------------+
| COUNT(UInt8(1)) |
+-----------------+
| 14999999        |
+-----------------+


Should date part be included to partition key

Hi,
I have a question. For IoT kind of data, does it make sense to include date part (like year) into partition key? For the purpose of convenience, it's easer to make Partition Key just with device Id, as you described it. However, let's say device sends data once per minute, which will make it half million per year (our real case), my concern that if we don't implement purging, the number of records per partition will keep growing.
Is there some point at which it should become a concern? Any guidelines on that?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9da32a62-a60f-1013-bb2f-688c67a446ec
Version Independent ID: 7a2bf261-0a20-30f0-837d-cf02700034aa
Content: Partitioning and horizontal scaling in Azure Cosmos DB
Content Source: articles/cosmos-db/partition-data.md
Service: cosmos-db
Product: unspecified
GitHub Login: @SnehaGunda
Microsoft Alias: rimman

@maxal1917 Thanks for the feedback. We are actively investigating and will get back to you soon.

Yes, you can form a composite key by concatenating the device id and time (for example - partition key = "device123-april-2017") to increase the amount of storage per device.
You could then route queries to the appropriate partition key values using the IN clause e.g. SELECT * FROM c WHERE c.partitionKey IN ("device123-april-2017", "device123-may-2017")

@Mike-Ubezzi-MSFT  can you assign this issue to @aliuy

Generally speaking - having higher cardinality partition keys and finer granularity is always preferred.
The extreme case would be to partition by id - which will yield great storage and throughput distribution. This comes at a trade off on how easy to represent frequently run queries without having to fan-out.
From an upper bound perspective... while a collection can scale to fit unlimited storage - data within a single given partition key value is bounded by 10GB of storage and 10,000 RU/sec.

@maxal1917 hope Andrew's response helps, we will now proceed with closing this issue.
#please-close

@maxal1917 We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

I've also got a similar question relative to storing IoT device time series data in CosmosDB. Thanks for the discussion, but I'm hoping @aliuy can clarify a comment:

Generally speaking - having higher cardinality partition keys and finer granularity is always preferred.
The extreme case would be to partition by id - which will yield great storage and throughput distribution

I'm a bit confused by this statement. What "id" are you referring to? If you're saying this is the device ID, then I would think it is definitely NOT the extreme case, because each device is going to have an ever-growing number of time series records (in the millions), which will definitely hit the 10GB limit-per-partition (if you're going Fixed Size). Do you mean "id" as in the individual document ID, which is unique per document? That seems more like the "extreme" case you're referring to, but using the generic term "id" when EVERYTHING has an ID (including the device in this case) is a bit unclear.


Outdated report

Report.pdf is outdated. Functions, such as getionimage(), do not work in same way as written in report.pdf.

As you can see, Report.pdf was created in 2015 and reflects the state of the pyimzml module at that time. Of course, a lot has changed in pyimzml in recent years. Current documentation is available on this page.


Add strip debug to minified files

https://github.com/sindresorhus/gulp-strip-debug

Hi all, I'm not longer maintaining this project, and recommend you instead use my Build Tool Boilerplate.


Allow events api callbacks to be method names

Resolves #3333, moving from #3396

A wee bit to string-programm-y. You have a reference to the method right there ... just use the reference.


[WiP] secure websockets tests

Use this with the notes from TODO.txt against the solid-nextcloud branch 'notif-ws' and the php-solid-pubsub-server branch 'feature-secure-webhook-to-ws'


DOC: Update contrib guide

closes #6898
This PR also updates the FAQ on filing new bugs, and the bug report issue template.
cc @mohdsherif @jasmainak @massich

Perhaps you can say "origin" next to "your fork" like you do for upstream?

maybe @AdoNunes can help review this. He has been reading these instructions recently

I like it.

marking as MRG, but I'm fine with waiting for additional reviews if anyone else wants to chime in

@larsoner merge if happy

Thanks @drammock


Bypass Starship Design skill in Ship Builder

The skill Starship Design can be bypassed through an UI bug that let's the placement of otherwise unavailable ship modules.
Clip of the issue: Bypass Starship Design skill in Ship Builder
Game Version
<IP_ADDRESS>
New Game
No
Reproduction Steps
Travel to New Atlantis.
Open the Ship  Builder.
Place the pointer close to an already existing module.
Press G to create a new module.
Select White Dwarf 2010 Engine and press E.
At this point you should be able to move the module about to place freely since it was originally overlapping with another module.
Press S two times and then E on an available space.
Now you have a White Dwarf 2020 Engine without needing the Starship Design skill.

This issue would likely need to be resolved on the engine level. Regardless, I believe this would fall out of the scope of the SFCP, as this is merely an exploit that allows a player to cheat if they wish to.


Kernel keeps dying executing test_anchors.ipynb

When I executed the 3rd cell in test_anchors.ipynb, the kernel dies without throwing any error.
while run(valid_gen,args,parse_anchor_parameters(args.config)):     pass
I have tried it on both my local server and google colab.
What could be the reason and how to fix it?

This must be related to using OpenCV in a notebook,try running it in a python script and/or please check your OpenCV installation


Collection Sync - abort Ajax request if one is running

Hello,
I wonder why Backbone doesn't handle multiple requests right now. Maybe, it's a question of framework implementation.
For now on the line 943 of backbone.js ajax call is handled by simply making an ajax call. If sync method would be a mix-in for instances of models and collections, and default method call would be the same as it is now, it would be possible to handle these kinds of things easily.
Is there any reason why that might be considered a harmful practice, and therefore is discourages by Backbone?
Thank you!

@ifesdjeen Definitely agree, subsequent update (PUT) and read (GET) requests for a model should cancel previous requests.

Sometimes two save() requests are valid, before the first has returned...

Great point-- buys more often than not? Perhaps a key in the options parameter?

Mike's phone
On Feb 24, 2012, at 18:41, Jeremy Ashkenas
<EMAIL_ADDRESS>wrote:

Sometimes two save() requests are valid, before the first has returned...

Reply to this email directly or view it on GitHub:
https://github.com/documentcloud/backbone/issues/304#issuecomment-4168171


[DEVOPS-814] Show different banners for testnet and staging RC

The installer builders currently set the NETWORK variable of staging builds to be testnet.
Daedalus shows a "Release Candidate" banner when NETWORK !== mainnet.
Now that we (almost) have a testnet, it might be good to have a banner for that as well.
Please check that the approach is OK and then we can continue work.
Todo

[x] Inject missing Japanese translations:

  "test.environment.developmentLabel": "Development",
  "test.environment.stagingLabel": "Staging",
  "test.environment.testnetLabel": "Testnet",

Screenshots
Mainnet

Staging

Testnet

Development

Basics

[ ] PR is updated to the most recent version of target branch (and there are no conflicts)
[ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance tests are passing (npm run test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (npm run dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (npm run package / CI builds)
[ ] There are no flow errors or warnings (npm run flow:test)
[ ] There are no lint errors or warnings (npm run lint)
[ ] Text changes are proofread and approved (Jane Wild)
[ ] There are no missing translations (running npm run manage:translations produces no changes)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (npm run storybook)
[ ] In case of npm dependency changes both package-lock.json and yarn.lock files are updated

Code Quality

[ ] Important parts of the code are properly documented and commented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-rendering
[ ] Any code that only works in Electron is neatly separated from components

Testing

[ ] New feature / change is covered by acceptance tests
[ ] All existing acceptance tests are still up-to-date
[ ] New feature / change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review:

[ ] Merge PR
[ ] Delete source branch
[ ] Move ticket to done on the Youtrack board

@darko-mijic we need to define better labels for staging and testnet networks.
My suggestion is:

STAGING: Staging
TESTNET: Testnet
Please let us know if you agree with my proposal or if you have a better namings in mind :)

@rvl @daniloprates we will have to port this PR over to release/0.11.1 branch :(

As agreed on our alignment call today (with @rvl and @daniloprates) we have decided to:

Inject missing Japanese translations in this PR
Rebase devops-814-network-testnet branch on top of release/0.11.1 [by @rvl ]
Re-target this PR to release/0.11.1 branch
Merge to release/0.11.1
Do extensive testing of release/0.11.1 branch and if tests prove everything is fine then we will merge release/0.11.1 into develop
cc @darko-mijic @jmitchell @DominikGuzei

@rvl Japanese translations are now injected and this PR is finally ready for re-basing. Thanks for taking care of it :)

OK thanks, rebased and changed base branch.


Add example importer and improver

This is a dummy importer and improver that runs without network
connection only to test vulnerablecode framework
Signed-off-by: Hritik Vijay<EMAIL_ADDRESS>

@Hritik14 Should we have some tests here for testing the example importer and improver ?

@TG1999 Good idea! Though, instead of testing this example importer / improver, I suppose I can test the entire framework using the example.
@pombredanne
Makes sense. The only way to run this example will now be using tests.


re-fresh our solution using Larry's code as foundation / starting point

Larry's solution is so much superior to our current solution (not only resolving fractions - see https://github.com/Equal-Vote/starpy/issues/23  - but multiple other improvements - e.g. well organized test cases in separate files with relevant parameters / settings / configurations ).
Therefore, I propose to request Larry's permission to refresh our STARPY solution using Larry's code as a foundation.
Obviously we would have to:

bring back some test cases that we had as a our starting point (Larry probably covered those already)
review impact of dropping some dependencies - e.g.

numpy (we probably do not need such a big gun - as proven by Larry)
pytest

Larry's code:
https://github.com/larryhastings/starvote.
licensed using the MIT license
https://github.com/larryhastings/starvote/blob/master/LICENSE

His code is good and has a lot that I'd like to implement like removing dependencies and using fractions, but I think one major goal of this library is to be as readable as possible(not saying ours is but that's the goal) in order to be a good algorithm reference for developing other libraries and for others to read and understand how tabulation works. While I'm not a python dev I felt like I had to dig through a lot of decorators and functions just to get to the algorithm. It also uses the full ballot data throughout the tabulation where we calculate the sums/matrices first and use that for tabulation.
I think we'll get closer to where we want to end up by keeping our current code base and updating it.


move loop invariant variables out from loop to save gas

Moving loop invariant codes out from loop can save gas.
In the following demo, it can save 765 units of gas when the length of arr is 100.
    function test1(uint256[] calldata arr) public {
        for(uint256 i = 0; i < arr.length; i++) {
        }
    }

    function test2(uint256[] calldata arr) public {
        uint256 len = arr.length;
        for(uint256 i = 0; i < len; i++) {
        }
    }

PR Checklist

[ ] Tests
[ ] Documentation
[ ] Changeset entry (run npx changeset add)

@nventuro can you take a look at this pull request? it looks good to me. The original functionality is preserved and some gases can be saved.

Can anyone take a look at this pull request?

https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4182#issuecomment-1586310971


OSError: Error no file named pytorch_model.bin, model.safetensors, tf_model.h5, model.ckpt.index or flax_model.msgpack found in directory E:/comfyui/models/clip\siglip-so400m-patch14-384.

I am also facing this problem. Could you please advise on how to solve it

I am also facing this problem. Could you please advise on how to solve it

Finally I found that in other places it automatically creates a directory into which you can copy the models or you can consider reinstalling comfyui.


donejs develop for plugins

It should start a static file server and steal-tools live-reload

Closed via https://github.com/canjs/can-ssr/pull/135

I added static file hosting to can-ssr but I don't know how live-reload is supposed to work. Running steal-tools live-reload shows that files are being reloaded but nothing happens which is probably to be expected since neither the demo page or the tests offer a reload functionality.
@matthewp any insights?

Is live-reload in the package.json configDependencies?  If so demo pages should be working. Only thing I can think is on demo pages if you are doing:
<script src="path/to/steal.js">
  import 'stuff'
</script>

maybe not handling that parent correctly.

Indeed, it wasn't added to configDependencies. The tests now reload automatically (kind of, the QUnit status doesn't change from red to green when live-reloading) but component demo pages still do not reload.

This has been done in the latest version


Multiple Drag and Drop Feature

I'm submitting a ...
[ ] bug report
[x ] feature request
[ ] question about the decisions made in the repository

Will multiple Drag & Drop from 1 container to a drop zone be on the roadmap?

What is the current behavior?
Is it not supported.

What is the motivation / use case for changing the behavior?
We have a number of requirement that need to select multiple items in one container and drag them to a drop zone all at the same tine,

Please tell us about your environment:
Angular2 RC4/ Net Core

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
all

just want to confirm when we can have multiple drag drop working

Hi @hgoraya
I don't have time to implement this feature just now because of the short amount of time on this project.


Use erlef/setup-beam and bump actions versions

Remove extra redirection. See https://github.com/erlef/setup-beam/issues/20

Thank you so much!

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


"reindex/refresh" the list after adding new items via ajax

hi,
sorry for my bad english :(
thanks Jonny for this awesome plugin ;)
how to reindex/refresh my "list" after adding new items via ajax ?

Will a second new List() call on the same element destroy the previous instance ?


Youtube videos aren't working in the webview

Hi ,
I have a forum and I built and app based on your awesome webview but I noticed that youtube videoes aren't working at all, no sound or video.
I tried the native webview it worked with sound only no video.
When I open Youtube.com in your webview it works fine.
What's the problem and how to solve.
You can try this link :
https://androiders.club/index.php?threads/yrd-brmg-ttbiq-lmuqyk.12/
It contains a video.
Thank you.

Thanks for your report!
If you open that same video on m.youtube.com by following the external link from the video player, it is working with this library? But on that site with the embedded player, it is not working?

Same goes for vimeo. I get a blank screen when opening the webview but i can hear the sound

Thanks, @ArthurSav!
Can anybody with this problem please check the following for YouTube and/or Vimeo?

Embedded

Audio

[ ] Works with this library!
[ ] Works with the original WebView!

Video

[ ] Works with this library!
[ ] Works with the original WebView!

Fullscreen

Audio

[ ] Works with this library!
[ ] Works with the original WebView!

Video

[ ] Works with this library!
[ ] Works with the original WebView!

I have both youtube & vimeo. Youtube is working great.
Youtube

Embedded mode works with audio & video.
Haven't tried fullscreen.

Vimeo

Haven't tried embedded.
Fullscreen. When i press play the screen becomes white. Sounds works

I think vimeo is trying to go full screen and that's when the screen becomes white.
Haven't used the default webview, so i can't comment on that.

See #84 for full screen video support.

@sazid Thanks, will give it a try and close the issue if tit works

@ArthurSav If the problems are really exclusive to fullscreen mode, the issue referenced by @sazid may indeed solve this. But from @EgyptianM's original comment, I understood that the problems would occur in embedded mode as well (which would be strange).


Contact venue to conirming go look see visit

What
Arrange a scouting visit to St George's Hall in Liverpool for max 4 people
Why
So we can understand the venue's layout, and look at logistics and disability access. Take pictures for our records. Make sure the venue fits our purpose, and make any necessary arrangements.
Who needs to work on this
Community Manager, Associate Delivery Manager
Who needs to review this
Kelly, Nora, Imran & Chris BT
Done when
Arranged a suitable date for a visit in July 2024

[ ] Agree on a suitable date with team members
[ ] Contact the venue to arrange a Go Look See visit
[ ] Team members to book travel
[ ] Team members to book accommodation
[ ] Team members to find a suitable social location for after the event

Email sent to venue to request Go Look See visit for 4 team members
for either 16th July 2024 in the afternoon or 17th July 2024 in the morning,

Waiting for venue to send details of the event manager

Imran to share the event managers details

email sent to the event manager requesting scouting visit-<EMAIL_ADDRESS>

St George's Hall had filming booked for 16 & 17 July
They have confirmed we can do our scouting visit
waiting on<EMAIL_ADDRESS>to confirm which day suits him best before we can book travel and accommodation

Scouting visit booked for 17th July 2024 at 10am
Nora will book accommodation for Kelly, Imran and herself

Nora has booked travel
@ImranH-GDS @kellylee-gds  to book their travel for the scouting visit and update the tracker
DSDay 24 Budget tracker


Implement a logging facility

The daemon should become more and more a real daemon. So logging and PID management should be implemented.

Using debug allows logging when acts as a library.
How do you like it?

Oh, haven't heard of debug. This lib is exactly what we need :) Thanks!


Webview2 - Evergreen link to newest offline x64 version

Hello folks,
we need an evergreen link to the latest webview2 offline x64 version. Could you create this link. We need this link for our automatic deployment.
Thanks very much!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8a805f15-55ba-4ef4-aeda-22188a040c66
Version Independent ID: 88de0955-526f-a4c9-efcc-d952281850e1
Content: Distribute your app and the WebView2 Runtime - Microsoft Edge Development
Content Source: microsoft-edge/webview2/concepts/distribution.md
Product: microsoft-edge
Technology: webview
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

Sorry if you have already checked this page, but https://developer.microsoft.com/en-us/microsoft-edge/webview2/ should contain what you need. Please let me know if it doesn't.

Hi @captainbrosset ,
through your link I find this url for the "Evergreen Standalone Installer x64 bit" https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/d602b474-c305-455f-86f3-49b09505ab2a/MicrosoftEdgeWebView2RuntimeInstallerX64.exe
But it seems that the hash value "d602b474-c305-455f-86f3-49b09505ab2a" would change with each new version.
Hence my question about an "evergreen link". For FSLogix, for example, it looks like this: https://aka.ms/fslogix_download . This link always points to the latest version.
Is it also possible to create something like this for webview2 Evergreen Standalone Installer x64 bit?

@champnic are you able to help on this issue please?

@dgiesselbach Hello - I think you use the bootstrapper for this purpose. Here's the documentation: https://learn.microsoft.com/en-us/microsoft-edge/webview2/concepts/distribution#understanding-the-options-at-the-runtime-download-page
On the WebView2 Runtime page you use the "Get the link" button. Let me know if that doesn't work for you. Thanks!

@champnic yes "get the link" is the right feature, but we need this for the "Evergreen Standalone Installer offline installer x64".
Is this possible?

I don't think we have a link specifically for the full offline installer. In the online scenario you could use the bootstrapper, and in offline scenario you could use the version of the offline installer bundled with your app if needed. The installers will install the latest runtime version.
Additionally, the runtime has been distributed to nearly every Win10 device, and is inbox on Win11 devices. It should be unlikely that you are running on a machine without the runtime.
What's your scenario where you need the offline installer?

Currently we use "Evergreen Bootstrapper Online Installer" in our fully automated deployment of Azure Virtual Desktops (Windows 10 Enterprise Multi Session). This AVDs do not get Webview2 automatically! But from time to time the online installer fails to download sources from your servers during the setup process. For this reason we want to switch to the offline installer to eliminate the dependency on the download.

Gotcha - thanks for the info! I would recommend getting an offline installer but use it as a backup in case where the bootstrapper fails rather than a full replacement.
If you'd still like to see an evergreen offline installer link can you open an issue on our feedback repo? https://github.com/MicrosoftEdge/WebView2Feedback/issues/new?assignees=&labels=feature+request&template=feature---api-request.md&title=

@champnic ferature request is open :)
https://github.com/MicrosoftEdge/WebView2Feedback/issues/3287
Thx!

Thanks! Sorry for the runaround here - I'm glad you got such a quick response and that it seems to solve the issue here :)


bug: Azure Pipelines AZAPI execution fails with "ChainedTokenCredential authentication failed"

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

Please paste the output of terraform version command from within the initialized directory:
Terraform v1.7.1
on windows_amd64
+ provider registry.terraform.io/azure/azapi v1.12.1
+ provider registry.terraform.io/hashicorp/azuread v2.48.0
+ provider registry.terraform.io/hashicorp/azurerm v3.99.0
+ provider registry.terraform.io/hashicorp/time v0.11.1

Please enter the module version that you are using:
4.1.2

Description
We are currently running into trouble using a SPN with Azure Pipelines and any calls made with the azapi provider.  Using AzureAD, AzureRM, etc. providers works without issue.
Successfully created:

Azure AD Group
AzureRM Subscription
AzureRM Management Group Subscription Association
AzureRM Role Assignment

Failed to create:

Telemetry
Budgets

Steps to Reproduce

Run az login using Service Principal (Azure Pipelines)
Verify login by changing subscription az account set
Initialize Terraform (terraform init)
Create Terraform Plan (terraform plan)
Attempt to execute Terraform with terraform apply

Screenshots

The errors look like this:

(I have attached the raw log)
AzPipeline-RawLog-AzSubscriptionAzApiFail.txt
Additional context

We are able to perform this activity without issue running this outside the pipeline.
Feels like there is an environment variable/setup we are missing for our Azure Hosted pipeline agents.

Seeing the same behavior. Can run the plan no issues locally with aliased providers. When running in a pipeline get the same error.

Hi this isn't a module bug and should be reported on the AzAPI provider repo.
However you to fix you have to explicitly disable MSI authentication in the provider config.


[hi] Localized en/docs/contribute/review/for-approvers.md

Created a file called content/hi/docs/contribute/review/for-approvers.md.
Copied the content of https://github.com/kubernetes/website/blob/main/content/en/docs/contribute/review/for-approvers.md to the file I created.
Localized the content.

Closes #36474

/lgtm

Hey @Babapool!!
I went through all the suggestions and have made the changes accordingly.
Thank You.

@SuperAayush Resolve the failing checks. Till then, I'm putting this PR on hold. Feel free to remove the hold once the checks are successful.
/hold

/unhold

I hope this will get merged now

Final set of suggestions from myside and after this PR will be ready to merge IMO. Thank you for your patients and efforts.

Thank you for all the suggestions @Babapool!!
I hope this will get merged now!!

@SuperAayush, the PR needs just one last push. I checked some suggestions are missing from a previous review. If you get them in, the PR will be ready to merge. Thanks

@SuperAayush, the PR needs just one last push. I checked some suggestions are missing from a previous review. If you get them in, the PR will be ready to merge. Thanks

Done ✅

/assign @divya-mohan0209. Can you PTAL at this PR. The changes look okay to me and the PR is ready to merge.

/assign @divya-mohan0209
Can you PTAL at this PR. The changes look okay to me and the PR is ready to merge.

@SuperAayush can you push an empty commit so that it can trigger the (re)build checks (once again). Thanks

@SuperAayush can you push an empty commit so that it can trigger the (re)build checks (once again). Thanks

I hope I have done the right thing 😅

@SuperAayush can you push an empty commit so that it can trigger the (re)build checks (once again). Thanks

I hope I have done the right thing 😅

Yes you did the right thing 👍

Initial set of reviews.

Did the suggested changes 😄, thank you for the review.

Hello @SuperAayush , gentle reminder on the PR. Please could you advise if you're able to take a look at the suggestions above and incorporate them in your next commit?

Hello @SuperAayush , gentle reminder on the PR. Please could you advise if you're able to take a look at the suggestions above and incorporate them in your next commit?

Really sorry for the delay @divya-mohan0209, I missed the notification.
I have made the changes as suggested.

@SuperAayush We are facing Netlify build issues, please could you pass an empty commit?

Hello @SuperAayush, gentle reminder. Please could you retry the empty commit again?

/remove-lifecycle stale

Hello @SuperAayush , please could you retry rebasing against main?

@SuperAayush : Checking in to see if you have the bandwidth to rebase against main and move this work forward?

/area localization
/lifecycle rotten


click_link should find visible links only

Capybara should only find visible links when using the click_link action.
In a JS-app where a link is added to the DOM and later made visible, capybara will produce a failure when waiting for the element it wants to click:
     Element is not currently visible and so may not be interacted with (Selenium::WebDriver::Error::ElementNotVisibleError) ...       (eval):2:in `send'       (eval):2:in `click_link'
While it makes sense to find_link invisible links, the find() construct used by click_link should really specify :visible => True so Capybara waits until the link is visible before clicking it.

byzg +1


bump 4.0.0rc6 -> 4.0.0rc7

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.883%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
1088

Relevant Lines:
1123

💛  - Coveralls


[base] Move hooks to their own directories

As discussed in point 1 of #31415.

Hi, can I try this one?!

Sure, go ahead!


Adds linter to make sure that code is consistent

Added simple linter without configurations https://github.com/testdouble/standard which will help to support default ruby style guides with less time to support. But this will require to run to fix code for the whole repository and drop usage of the custom rubocop settings, but for simplicity to support this is worthy

Thanks! I'll read through the actions docs.


New Nuget Plan...

Is there a plan to create a new nuget?

Yes, soon

Done, released a new version back when I originally replied: https://github.com/akkadotnet/Hyperion/releases/tag/0.9.17
and we should have another new one coming out soon.


Feat/decoder/multipart requests

Codecov Report

Merging #515 (52be473) into release/next (3602643) will increase coverage by 1.52%.
The diff coverage is 72.25%.

@@               Coverage Diff                @@
##           release/next     #515      +/-   ##
================================================
+ Coverage         57.53%   59.05%   +1.52%
================================================
  Files                66       67       +1
  Lines              1474     1624     +150
  Branches             44       70      +26
================================================
+ Hits                848      959     +111
- Misses              626      665      +39

Impacted Files
Coverage Δ

...ttp/src/main/scala/zhttp/http/ContentDecoder.scala
62.50% <7.14%> (-14.43%)
:arrow_down:

...main/scala/zhttp/experiment/multipart/Parser.scala
78.72% <78.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3602643...52be473. Read the comment docs.


deps: use latest version of Hugo

This addresses advisory:
https://github.com/advisories/GHSA-8j34-9876-pvfq
Signed-off-by: Paul Jolly<EMAIL_ADDRESS>

Quick skim through the site and everything looks as I expected


⚠ Bofrost.at has degraded performance

In b20a58a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1853 ms

Resolved: Bofrost.at performance has improved in 2f86e86 after 6 minutes.


Create Bugzilla Remote Issue Provider integration

Implement a Bugzilla provider as described by model in #24

Tried it out here : https://github.com/DhritiShikhar/ALM_issues/blob/master/alm_bugzilla.go

duplicate https://github.com/almighty/almighty-core/issues/135


Fix fee estimation mechanism

We need to fix actual_fee estimation and add more tests for it

Fixed in https://github.com/lambdaclass/starknet_in_rust/pull/709


chore(master): release 1.1.1

:robot: I have created a release beep boop
1.1.1 (2023-05-26)
Bug Fixes

added react documentation and peerDependencies to README (6945922)
renamed secrets on workflows (c998526)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/dworac/eslint-config-typescript-react/releases/tag/v1.1.1 :sunflower:


Feature/authorization use cases

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Feature/legacy mame

This branch resolves issues #52 and #53.
I have bumped the version to 3.0.1 and updated AssemblyInfo.cs. Check your Appveyor config, @mika76 - remember the previous version was still displaying as 2.0.0 when installed from the MSI.

@mika76 I see this inadvertently pulled in some ancient commits, one of which was adding Appveyor.yml. It looks pretty skeletal, which suggests that it may not have been tested or complete. Feel free to remove if it's causing issues.

Hey @nullpainter the appveyor file, it would break our build again - could you remove it - It'll be faster since I'm not by the PC these days as much...

hmm or maybe better yet - I exported the appveyor file from the appveyor build so we could place it with the source. Just replace the current one with this...
version: 1.0.{build}
image: Visual Studio 2017
configuration:
- Release
- Repack
platform: Any CPU
before_build:
- cmd: nuget restore
build:
  verbosity: minimal
artifacts:
- path: MamesaverDeploy\bin\Repack\Mamesaver.msi
  name: Mamesaver.msi
- path: Mamesaver\bin\Repack\Mamesaver.scr
  name: Mamesaver.scr
- path: Mamesaver\bin\Repack\*.dll
  name: dlls
- path: Mamesaver\bin\Repack\Mamesaver.exe
  name: repack exe

@mika76 done.

Thanks Matt. So you're pretty confident about this change? Cuz I'm not sure I can test it really. Code seems good...
Also as per semver - you don't think this should be 3.1 instead of 3.0.1? It kinda feels like you added new functionality :smile:

I'm confident (I now have several different versions of MAME, and both rebuilt the game list and quickly tested using each), but it's always good to get a second pair of eyes. @andyvans, do you have capacity?
This is new functionality, but it was pretty minor. Happy be swayed by popular opinion though :)

Okay, it appears that confident != performant. Perhaps 2k ROMS is extreme, but I'm keen to try a fallback of your original approach first and see if that results in a better outcome.

Hey @nullpainter not sure where we stand on this one? Merge or ignore?

There's no harm  in merging, but we need to add sufficient caveats to the documentation, I think.

So what would we have to add? Just the required minimum MAME version and also like a limit to the amount of roms?

Pretty much. Versions from 0.155 have been tested, but it's possible that earlier versions work. I guess note that any MAME version earlier than 0.191 may be less performant - particularly with large numbers of ROMs.


Revise guidance to require a minimum upper bound for supported ranks

This PR

resolves https://github.com/data-apis/array-api/issues/479 by revising the guidance requiring conforming implementations to support arrays of arbitrary rank and specifying that array libraries must support, at minimum, arrays of rank 4. Additionally, array libraries will be required to explicitly document their maximum supported rank.

Related

https://github.com/data-apis/array-api/issues/694

cc @leofang @Zac-HD

@Zac-HD Indeed, that is part of the rationale behind https://github.com/data-apis/array-api/issues/694. Once we merge the inspection API in, we'll add support for querying the maximum number of allowed dimensions.

This is pretty straightforward. I'll aim to merge this in a few days unless an objection appears.

As this PR has received multiple approvals and no objections, will go ahead and merge. Any further changes can be addressed in follow-up PRs...


Build arguments not replaced

Expected Behaviour
Having a Dockerfile containing build arguments, I expected them to be replaced when using withBuildArgs() on GenericContainerBuilder
E.g. dockerfile for nodejs monorepos.
const container = await GenericContainer.fromDockerfile()
  .withBuildArgs({
    WORKSPACE_NAME: ...,
    WORKSPACE_PATH: ...,
  })
  .build();

FROM node:20-alpine AS base
ENV PNPM_HOME=/root/.local/share/pnpm
ENV PATH=$PATH:$PNPM_HOME
RUN npm i -g<EMAIL_ADDRESS>RUN apk add --no-cache libc6-compat
RUN pnpm i -g turbo

WORKDIR /usr/app
ARG WORKSPACE_NAME
ARG WORKSPACE_PATH

FROM base as pruned
COPY . .
RUN turbo prune --scope $WORKSPACE_NAME --docker

FROM base as builder
COPY --from=pruned /usr/app/out/json ./
COPY --from=pruned /usr/app/out/pnpm-lock.yaml ./
RUN pnpm install --frozen-lockfile
COPY turbo.json turbo.json
COPY --from=pruned /usr/app/out/full .
RUN pnpm run build --filter=$WORKSPACE_NAME

FROM base as installer-prod
COPY --from=builder /usr/app ./
RUN pnpm install --frozen-lockfile --prod --filter=$WORKSPACE_NAME

FROM base as prod
COPY --from=installer-prod /usr/app ./
WORKDIR /app/$WORKSPACE_PATH

ENV NODE_ENV "production"
CMD ["pnpm", "start"]

Actual Behaviour
Looking at the source code, build arguments are only getting replaced if present in the FROM clause.
Also that regex doesn't look right.
https://github.com/testcontainers/testcontainers-node/blob/9a41b92d9ee7a6d318bbea87b4f5781efb536dd0/packages/testcontainers/src/utils/dockerfile-parser.ts#L6-L28
Steps to Reproduce
Try to programmatically build an image with a build arg placed everywhere but in the FROM clause.
Environment Information

Operating System: macOS Sonoma
Docker Version: v25.0.3
Node version: v18.16.0
Testcontainers version: v10.7.2

Hi @nicolabovolato,

Looking at the source code, build arguments are only getting replaced if present in the FROM clause.
Also that regex doesn't look right.

The code link you shared is unrelated. That code parses a list of Docker image names which are later used for authentication. We need the build arguments there just in case the image name is a build arg.
The build arguments relevant for you are sent directly to the Docker daemon here:
https://github.com/testcontainers/testcontainers-node/blob/c514be07e5fb9269fbfa24d399c9e39d8309221e/packages/testcontainers/src/generic-container/generic-container-builder.ts#L65-L74
Could you please share what exactly is going wrong with your implementation, perhaps share the logs as well?

My bad @cristianrgreco, i should have looked a bit further into that function.
Anyway, I'm running containerized benchmarks inside a monorepo.
Dockerfile is the same as above and source code is an iteration around this logic:
const workspaceName = `bench-${group}-${pkg}`;
const workspacePath = path.relative(
  rootDir,
  path.join(__dirname, group, pkg)
);

logger.info(
  `Building dockerfile with workspace ${workspaceName} and path ${workspacePath}...`
);
const container = await GenericContainer.fromDockerfile(
  rootDir,
  dockerfilePath
)
  .withBuildArgs({
    WORKSPACE_NAME: workspaceName,
    WORKSPACE_PATH: workspacePath,
  })
  .build(workspaceName)
  .withResourcesQuota({
    cpu: containerCpu,
    memory: containerMemory,
  });

const startedContainer = await container.start();

logger.info("Running bench for package " + pkg);
const results = await benchmark(group, startedContainer);

await startedContainer.stop();

Logs are as follows:
{"level":30,"time":1711102181390,"pid":76924,"hostname":"Mac-di-Nicola-Bovolato","msg":"Running bench for group http"}
  testcontainers [DEBUG] Testing container runtime strategy "TestcontainersHostStrategy"... +0ms
  testcontainers [DEBUG] Testing container runtime strategy "ConfigurationStrategy"... +0ms
  testcontainers [DEBUG] Testing container runtime strategy "UnixSocketStrategy"... +0ms
{"level":30,"time":1711102181391,"pid":76924,"hostname":"Mac-di-Nicola-Bovolato","msg":"Building dockerfile with workspace bench-http-fastify and path packages/benchmarks/http/fastify..."}
  testcontainers [DEBUG] Container runtime strategy "UnixSocketStrategy" works +663ms
  testcontainers [DEBUG] Acquiring lock file "/var/folders/h2/71hmhq8n5p59f79w4k8_ksk80000gp/T/testcontainers-node.lock"... +4ms
  testcontainers [DEBUG] Acquired lock file "/var/folders/h2/71hmhq8n5p59f79w4k8_ksk80000gp/T/testcontainers-node.lock" +3ms
  testcontainers [DEBUG] Listing containers... +0ms
  testcontainers [DEBUG] Listed containers +3ms
  testcontainers [DEBUG] Creating new Reaper for session "9b34cb0b281d" with socket path "/var/run/docker.sock"... +0ms
  testcontainers [DEBUG] Checking if image exists "testcontainers/ryuk:0.5.1"... +1ms
  testcontainers [DEBUG] Checked if image exists "testcontainers/ryuk:0.5.1" +3s
  testcontainers [DEBUG] Image "testcontainers/ryuk:0.5.1" already exists +0ms
  testcontainers [DEBUG] Creating container for image "testcontainers/ryuk:0.5.1"... +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Created container for image "testcontainers/ryuk:0.5.1" +68ms
  testcontainers [INFO] [9f55b6bb9277] Starting container for image "testcontainers/ryuk:0.5.1"... +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Starting container... +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Started container +152ms
  testcontainers [INFO] [9f55b6bb9277] Started container for image "testcontainers/ryuk:0.5.1" +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Inspecting container... +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Inspected container +3ms
  testcontainers [DEBUG] [9f55b6bb9277] Fetching container logs... +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Demuxing stream... +2ms
  testcontainers [DEBUG] [9f55b6bb9277] Demuxed stream +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Fetched container logs +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Waiting for container to be ready... +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Waiting for log message "/.+ Started!/"... +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Fetching container logs... +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Demuxing stream... +1ms
  testcontainers [DEBUG] [9f55b6bb9277] Demuxed stream +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Fetched container logs +0ms
  testcontainers:containers [9f55b6bb9277] 2024/03/22 10:09:45 Pinging Docker... +0ms
  testcontainers:containers [9f55b6bb9277] 2024/03/22 10:09:45 Docker daemon is available! +1ms
  testcontainers:containers [9f55b6bb9277] 2024/03/22 10:09:45 Starting on port 8080... +0ms
  testcontainers [DEBUG] [9f55b6bb9277] Log wait strategy complete +11ms
  testcontainers [INFO] [9f55b6bb9277] Container is ready +1ms
  testcontainers [DEBUG] [9f55b6bb9277] Connecting to Reaper (attempt 1) on "localhost:55000"... +0ms
  testcontainers:containers [9f55b6bb9277] 2024/03/22 10:09:45 Started! +4ms
  testcontainers [DEBUG] [9f55b6bb9277] Connected to Reaper +22ms
  testcontainers [DEBUG] Releasing lock file "/var/folders/h2/71hmhq8n5p59f79w4k8_ksk80000gp/T/testcontainers-node.lock"... +0ms
  testcontainers [DEBUG] Released lock file "/var/folders/h2/71hmhq8n5p59f79w4k8_ksk80000gp/T/testcontainers-node.lock" +1ms
  testcontainers [DEBUG] Executing Docker credential provider "docker-credential-desktop" +1ms
  testcontainers [DEBUG] Executing Docker credential provider "docker-credential-desktop" +1ms
  testcontainers:containers [9f55b6bb9277] 2024/03/22 10:09:45 New client connected: <IP_ADDRESS>:56213 +25ms
  testcontainers:containers [9f55b6bb9277] 2024/03/22 10:09:45 Adding {"label":{"org.testcontainers.session-id=9b34cb0b281d":true}} +0ms
  testcontainers [DEBUG] No credential found for registry "https://index.docker.io/v1/" +59ms
  testcontainers [DEBUG] No registry auth locator found for registry "https://index.docker.io/v1/" +0ms
  testcontainers [DEBUG] No credential found for registry "https://index.docker.io/v1/" +2ms
  testcontainers [DEBUG] No registry auth locator found for registry "https://index.docker.io/v1/" +1ms
  testcontainers [INFO] Building Dockerfile "/Users/nicola/personal-projects/be-framework/packages/benchmarks/Dockerfile" as image "bench-http-fastify:latest"... +0ms
  testcontainers [DEBUG] Building image "bench-http-fastify:latest" with context "/Users/nicola/personal-projects/be-framework"... +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 1/31 : FROM node:20-alpine AS base"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"status":"Pulling from library/node","id":"20-alpine"} +1s
  testcontainers:build [bench-http-fastify:latest] {"status":"Digest: sha256:bf77dc26e48ea95fca9d1aceb5acfa69d2e546b765ec2abfb502975f1a2d4def"} +9ms
  testcontainers:build [bench-http-fastify:latest] {"status":"Status: Image is up to date for node:20-alpine"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e e0a5cd56bd9c\n"} +3ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 2/31 : ENV PNPM_HOME=/root/.local/share/pnpm"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e Using cache\n"} +1ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e 0ddbde311661\n"} +1ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 3/31 : ENV PATH=$PATH:$PNPM_HOME"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e Using cache\n"} +2ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e 46a872561aab\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 4/31 : RUN npm i -g<EMAIL_ADDRESS>+0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e Using cache\n"} +1ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e 2f5731bd9a7c\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 5/31 : RUN apk add --no-cache libc6-compat"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e Using cache\n"} +1ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e 86a0f2e52204\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 6/31 : RUN pnpm i -g turbo"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e Using cache\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e ab7238a029bf\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 7/31 : WORKDIR /usr/app"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +1ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e Using cache\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e ab17aac04be7\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 8/31 : ARG WORKSPACE_NAME"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e Using cache\n"} +4ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e 5055c62eb735\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 9/31 : ARG WORKSPACE_PATH"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e Using cache\n"} +1ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e c85c7acf2ee0\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"aux":{"ID":"sha256:c85c7acf2ee0f50afa5e858cb36b5f23983658a34294462bc9391ebb8d43d2bb"}} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 10/31 : FROM base as pruned"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e c85c7acf2ee0\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 11/31 : COPY . ."} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e 6f1a8316f184\n"} +31s
  testcontainers:build [bench-http-fastify:latest] {"stream":"Step 12/31 : RUN turbo prune --scope ${WORKSPACE_NAME} --docker"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\n"} +0ms
  testcontainers:build [bench-http-fastify:latest] {"stream":" ---\u003e Running in 7d232810005f\n"} +59ms
  testcontainers:build [bench-http-fastify:latest] {"stream":"\u001b[91m ERROR  a value is required for '--scope \u003cSCOPE\u003e' but none was supplied\n\nFor more information, try '--help'.\n\n\u001b[0m"} +283ms
  testcontainers:build [bench-http-fastify:latest] {"errorDetail":{"code":1,"message":"The command '/bin/sh -c turbo prune --scope ${WORKSPACE_NAME} --docker' returned a non-zero code: 1"},"error":"The command '/bin/sh -c turbo prune --scope ${WORKSPACE_NAME} --docker' returned a non-zero code: 1"} +600ms
  testcontainers [DEBUG] Built image "bench-http-fastify:latest" with context "/Users/nicola/personal-projects/be-framework" +51s
  testcontainers [DEBUG] Checking if image exists "bench-http-fastify:latest"... +1ms
  testcontainers [DEBUG] Checked if image exists "bench-http-fastify:latest" +5ms
/Users/nicola/personal-projects/be-framework/node_modules/.pnpm/testcontainers@10.7.2/node_modules/testcontainers/build/generic-container/generic-container-builder.js:68
            throw new Error("Failed to build image");

@nicolabovolato I don't necessarily see an issue with the build arguments here. What I do see is this error:

testcontainers:build [bench-http-fastify:latest] {"stream":"\u001b[91m ERROR  a value is required for '--scope \u003cSCOPE\u003e' but none was supplied\n\nFor more information, try '--help'.\n\n\u001b[0m"} +283ms

Address this issue first and then we'll see if there's an issue with the build arguments.

@cristianrgreco building directly with the docker command works

Simpler reproduction
https://stackblitz.com/edit/stackblitz-starters-ab6hdh?file=index.ts
Looks like args in multi stage builds are not propagated correctly, perhaps this is something unrelated to testcontainers.

Hey @nicolabovolato, docker documentation states that build args last until the end of the stage where they were declared - see here https://docs.docker.com/reference/dockerfile/#scope. You declare WORKSPACE_NAME in the first stage and use it in later stages, which should not be supported (according to the documentation), so I am not sue why it works with docker cli client.

Looks like global build args are a docker build kit feature - https://medium.com/@sujaypillai/globally-scoped-platform-args-in-docker-buildkit-787b9010bbb8

Hi @silh, thanks for the info. I always assumed this behavior was supported by docker.
We should close this in favor of #571

Thanks for looking into this @silh, indeed lack of build kit support seems to be the issue.


have_enqueued_job#with does not evaluate a do ... end block

When passing a block to with, it is only evaluated if it is in the higher-priority { ... } syntax, and not if it is in do ... end
expect do
  create(:thing)
end.to have_enqueued_job(ThingCreationJob).with { |message|
  # This works and the expectation is tested
  expect(message['body']).to eq('A thing has been created')
}

expect do
  create(:thing)
end.to have_enqueued_job(ThingCreationJob).with do |message|
  # Code in this block is not evaluated, this expectation is not tested
  expect(message['body']).to eq('A thing has been created')
end

RSpec 3.5.4, Rails <IP_ADDRESS>

Yep sorry, this is a Ruby thing, we can't control where blocks are sent, so we recommend only ever using { ... } blocks with expect

@JonRowe to which call does the second do block get routed? Could we pull some shenanigans here?

This issue helped me figure out why my specs did not work as I intended them to, and I learned something new about Ruby operator precedence. Thank you! :)
What I am wondering now is why this code is working as intended:
allow(MyJob).to receive(:perform_later) do ... end

From what I've learned today, the do ... end block is not sent to receive, but it will be sent to to. Still the code works as intended.
Are there any "tricks" implemented between to and receive to make this possible or am I overlooking another piece of language nuance?


New order created instead of updated

It seems like there is an issue in https://github.com/Geta/Klarna/blob/a118814d229091a5ee350546770cba2d8b93dfc3/src/Klarna.Checkout/KlarnaCheckoutService.cs#L148
UpdateOrder takes string orderId, but is not used anywhere. In the old refit implementation, this was sent in the POST to Klarna.
Now, the OrderId from the CheckoutOrder object is sent in the request instead. But this is never set, seems like orderId from cart should be set in UpdateOrder or possible GetCheckoutOrderData

You can see the call and logic in the CreateOrUpdateOrder method. OrderId is from the Episerver cart custom property KlarnaCheckoutOrderIdCart. Or are you maybe referring to something else since you mention refit?

Yes but orderId is never used in the UpdateOrder method.
https://github.com/Geta/Klarna/blob/a118814d229091a5ee350546770cba2d8b93dfc3/src/Klarna.Checkout/LoggingCheckoutOrder.cs#L38
Takes just CheckoutOrderData as paramater
        public async Task<CheckoutOrder> UpdateOrder(CheckoutOrder order) {     var url = ApiUrlHelper.GetApiUrlForController(ApiSession.ApiUrl, ApiControllerUri, order.OrderId);     return await Post<CheckoutOrder>(url, order).ConfigureAwait(false); }
Uses order.OrderId in the call to klarna. But the orderId of CheckoutOrderData is not set within the UpdateOrder method, which leads to Klarna returning a new order every time, and not updating the existing one.
I had to set orderId in a ICheckoutOrderDataBuilder which solved the problem for me

Thanks - fixed now in version 3.5.2 (should be out on the feed soon).


[TASK] Add initial upgrade manual test plan

Requirement
Start with the v1.1.1 regression test, we need add a Harvester upgrade category
Create a new upgrade folder and add some upgrade related test plans in https://github.com/harvester/tests/pull/607
Task List
Test plan including:

[ ] Upgrade with IPv6 network
[ ] Upgrade from v1.0.3 to v1.1.1
[ ] Upgrade from v1.1.0 to v1.1.1
[ ] Fully air-gapped upgrade
[ ] Rejoin node after upgrade
[ ] Upgrade from cluster network on bonded NICs

This is Done.


[Backport release-0.15] Update kubernetes patches to v0.29.2

Description
Backport of #99 to release-0.15.

I am closing and will re-open to trigger the jobs.

/test-examples="examples/groups/member.yaml"

/test-examples="examples/applications/application.yaml"

Hi @turkenf,
The lint & publish-artifacts are failing because they are assigned to runners that are unavailable for this organization.

I've figured out that there already exists a PR that implements the strategy we discussed (parameterizing the workflow runners):
https://github.com/upbound/uptest/pull/135

Hi @turkenf,
Now that https://github.com/crossplane-contrib/provider-upjet-azuread/pull/107 has been merged, could you please rebase this PR on top of the release-0.15 branch?

/test-examples="examples/applications/application.yaml"

/test-examples="examples/groups/member.yaml"


Automated cherry pick of #9521: Storage actual size filter

Cherry pick of #9521 on release/3.5.
#9521: Storage actual size filter

Codecov Report

Merging #9523 (6b26f19) into release/3.5 (6a15e02) will increase coverage by 11.92%.
The diff coverage is 1.85%.

@@               Coverage Diff                @@
##           release/3.5    #9523       +/-   ##
================================================
+ Coverage         5.98%   17.91%   +11.92%
================================================
  Files              796       85      -711
  Lines           125693     8921   -116772
================================================
- Hits              7522     1598     -5924
+ Misses          117504     7151   -110353
+ Partials           667      172      -495

Flag
Coverage Δ

aFlag
17.91% <1.85%> (+11.92%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

.../monitor/alerting/conditions/suggestrulereducer.go
0.00% <0.00%> (ø)

pkg/monitor/alerting/conditions/suggestquery.go
2.00% <2.00%> (ø)

pkg/util/seclib2/seclib.go
80.39% <0.00%> (-5.66%)
:arrow_down:

pkg/compute/models/elasticcache_backups.go

pkg/monitor/alerting/ticker.go

pkg/monitor/alerting/job.go

pkg/compute/models/secgroupresource.go

pkg/monitor/models/alert.go

pkg/compute/models/loadbalancernetworks.go

... and 609 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b08e3...6b26f19. Read the comment docs.

/lgtm

/lgtm

/approve

/approve

/approve


Extend timeout for helm upgrade from 5m to 20m.

Several of these charts typically take longer than 5m to roll out because of healthchecks and rolling updates.
This should reduce toil from needing to manually retry failed Terrform apply runs in TFC.

Fix merge conflict with Argo WF version update.


Documentation: Describe how to setup Kata with Firecracker support

Description of problem
Kata supports firecracker VMM. Add documentation on how to setup the system to support firecracker.

[ ] Describe how to build firecracker with experimental vsock support (which is required for Kata)
Note: We will need to build firecracker till the released firecracker binary includes support for vsock
[ ] Describe configuration.toml setup for firecracker

[ ] The Hypervisor stanza (firecracker binary and kernel)
[ ] vsock enable
[ ] tcFilter enable

[ ] Ensure vsock kernel module is loaded
[ ] Setup docker with device mapper graph driver
[ ] Setup crio with device mapper graph driver
[ ] Describe how to launch docker with runtime set to use firecracker
[ ] Describe how to launch a Kubernetes pod with the runtime class feature set to use firecracker
[ ] Document current limitations and feature gaps

Note: This issue itself will be used to generate the document and then moved into the main Kata documentation

/cc @egernst @sboeuf

Related to https://github.com/kata-containers/tests/issues/1015, since the CI will need a .ci/install_firecracker.sh setup script.

Assuming all the binaries and artifacts that are firecracker related are stored at /firecracker. The artifacts include

firecracker  (binary with built with vsock support
kata-containers.img  (which has the updated agent with virtio-mmio support)
kata-runtime  (with firecracker support)
vmlinux (uncompressed kernel with virtio-mmio enabled)

crio setup
Delta only. Where /dev/vdb needs to replaced by a free disk/partition available to you with size 10GB
...
[crio]

storage_driver = "devicemapper"

storage_option = [
  "dm.basesize=8G",
  "dm.directlvm_device=/dev/vdb",
  "dm.directlvm_device_force=true",
  "dm.fs=ext4"
]

[crio.runtime.runtimes.katafire]
runtime_path="/firecracker/kata-runtime"
...

Docker Setup  /etc/docker/daemon.json
{
  "storage-driver": "devicemapper",
  "runtimes": {
    "firecracker": {
      "path": "/firecracker/kata-runtime"
    }
  }
}

Kata Setup /etc/kata-containers/configuration.toml
[hypervisor.firecracker]
path = "/firecracker/firecracker"
kernel = "/firecracker/vmlinux"
image = "/firecracker/kata-containers.img"
kernel_params = ""
default_vcpus = 1
default_memory = 4096
default_maxvcpus = 0
default_bridges = 1
block_device_driver = "virtio-mmio"
disable_block_device_use = false
enable_debug = true
use_vsock = true

..
[runtime]
internetworking_model="tcfilter"

Simple Kubernetes POD definition
apiVersion: v1
kind: Pod
metadata:
  name: ubuntu-pod
spec:
  runtimeClassName: katafire
  containers:
  - name: ubuntu
    image: "ubuntu:14.04"
    command: ["top"]
    stdin: true
    tty: true

Example documentation is currently at: https://github.com/kata-containers/documentation/wiki/Initial-release-of-Kata-Containers-with-Firecracker-support
I think we want a more formal version of this to be added to the documentation repository.

https://github.com/clearlinux/cloud-native-setup/issues/23

It seems trying to use devicemapper storage driver with cri-o 1.14.1 on Minikube does not work at all.

Jun 19 08:56:55 minikube-crio-kata systemd[1]: Failed to start Open Container Initiative Daemon.

@asaintsever - I don't think anybody has ever tried this under minikube. I presume you set up an available /dev/vdb under minikube for the crio storage to use?
I suspect this might be more of a minikube problem than a kata one. Maybe you can try setting up minikube with crio and a devicemapper storage without having kata in the loop, and see if that works?

@grahamwhaley thanks for your quick answer. Yes I do create a "fake" device (using part of this script: https://github.com/clearlinux/cloud-native-setup/blob/master/clr-k8s-examples/setup_kata_firecracker.sh).
And yes, I only tried to make crio happy with devicemapper without involving kata, just modifying crio.conf and restarting crio service. So this is a Minikube or crio issue in the end, not a kata one for sure.


feat: engine lottie

PR-Codex overview
This PR updates the hero section in the Engine product page with a Lottie animation and new design elements.
Detailed summary

Replaced static image with Lottie animation
Added new design elements for better user engagement

The following files were skipped due to too many changes: public/assets/product-pages/engine/lottie.json

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

📝 Changed routes:

/engine

(view full size)

Commit ff1568517e9093a13ff72b6ae2d937c7623b86eb (https://thirdweb-ijgaqax4u.thirdweb-preview.com).

the lottie file loads extremely slow even on high speed connections


smod2.api.player.throwgrenade is working weird

When i'm trying to throw the grenade via smod2.api.player.throwgrenade function, the player can see other players' grenades, but can't see its own grenade: https://www.youtube.com/watch?v=Z7-eRwSdQVo
Normal thrown grenades can be seen normally

Has this been fixed yet?


decode_png returns shape of 3 dimensions of question marks

I am trying to read an image and convert it into tensor using the following code
img_path = <image directory>
img_raw = tf.io.read_file(img_path)
img_tensor = tf.image.decode_png(img_raw)

and when I try to print its shape
print(img_tensor.shape)
it gives me 3 question marks instead of values:
(?, ?, ?)
why it doesn't work and how to fix this??

I guess you are using TF 1.X.  You can try couple of things

Try using tf.session to print value of img_tensor.shape
Simply enable eager execution and run code snippet

import tensorflow as tf
tf.enable_eager_execution()
img_path = <image directory>
img_raw = tf.io.read_file(img_path)
img_tensor = tf.image.decode_png(img_raw)
print(img_tensor.shape)

yeah the tf.Session solved my problem, thanks

Are you satisfied with the resolution of your issue?
Yes
No


fix: Fix sentry errors for api content type

This PR fixes undefined headers value when user triggers an update to the API body type (specifically to the NONE tab.)
Fixes #22950
Fixes #22952
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test

/ok-to-test

/ci-merge-check

/ok-to-test

/ok-to-test

/ci-merge-check

/ok-to-test


Added a sample Jupyter notebook.

Description of what I changed

E2E test

TESTED:
Ran all of the steps against a Jupyter server.
Checklist: I completed these to help reviewers :)

[x] My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides. Note, when in conflict, OpenMRS style guide overrules.

[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
Separate unit-tests do not apply for this case as everything is tested in a notebook and the results are recorded.

[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

[x] All new and existing tests passed.

[x] My pull request is based on the latest changes of the master branch.

Here is a sample snapshot of a segment of the notebook where the main functions are defined and used:

Here is a sample snapshot of a segment of the notebook where the main functions are defined and used:


Adding Repository Structure And Resources Sections To The README

This is a small pull request that adds two simple items to the README file: the structure of the MSR repository via tree and a Resources section.
A Repository Structure section enables users to get an impression of the MSR repository very quickly. While MSR's structure will change, requiring the Repository Structure section of the README to be manually revised, revisions need not be done frequently, since the design of MSR currently is such that further updates are unlikely to deviate significantly enough for the existing but outdated tree output to cease to be useful. The only request I have here for reviewers is to provide some thoughts for what to ignore when running tree.
Resources are helpful for newcomers and for those who've forgotten where to find particular items relevant to the project. I have added four resources. More resources can be added by others, including the reviewers.
As for the placement of the sections in the README, I thought that after the General Disclaimer worked well, since Public Domain Standard Notice becomes less MSR and or CDC specific.

Thanks, Trevor. I agree adding more content to help people get oriented would be helpful.
Re: the MSR Relevant Resources, one sentence or fragment about each resource would be helpful (e.g. For an intro to x, we recommend y.
Re: the tree structure, I think anything related to the internal structure of the repo would be better suited for our developer documentation. Maybe we can remove it from this PR and add a note to that issue, if you agree. In that case, I might suggest we only give the command to print the tree and omit the output of the command.

@damonbayer I agree with you that a one sentence description can help. I still believe that having the repository structure displayed in the README would be a net good (perhaps if a Last Updated: YYYY-MM-DD) if provided somewhere. I am fine with this somewhere being the developer documentation while leaving a note on how to display the structure for oneself, as you suggested.

If this

I think the model equation sheet could be moved to the documentation along with a brief introduction to the renewal model.

expected to be covered in #191 ?
@sbidari

Is this

I think the model equation sheet could be moved to the documentation along with a brief introduction to the renewal model.

expected to be covered in #191 ?
@sbidari

Yes, just requested review for some proposed changes in documentation.


Compiles without errors, classnames make it into html, but no css rules appear

Package.json
"next": "^10.1.2",
    "react": "17.0.2",
    "react-dom": "17.0.2",
    "styled-components": "^5.2.2",
    "swr": "^0.5.5"
  },
  "devDependencies": {
    "babel-eslint": "^10.1.0",
    "babel-plugin-styled-components": "^1.12.0",
    "concurrently": "^6.0.0",
    "eslint": "^7.23.0",
    "eslint-plugin-react": "^7.23.1",
    "husky": "^4.3.8",
    "lint-staged": "^10.5.4",
    "prettier": "^2.2.1",
    "tailwind-styled-components": "^1.0.7",

Hero.js
import styled from 'styled-components';
import tw from 'tailwind-styled-components';

const Section = tw.section`
  bg-indigo-600
`;

export function Splash() {
  return (

HERO

  );
}

Browser view

HERO

Browser console
//....nothing. There is no indication that the styles have been added other than the browser view which you see above.

Trying to figure out how to get the code behind those classnames to get loaded so the browser is rending the classname correctly.

Hello !
Tailwind Styled Component is a tailwind plugin, you will need to install Tailwind in order to use it and to get the css rules.
Please follow this instructions for the installation https://tailwindcss.com/docs/installation

Oddly enough I encountered a similar experience.
Every dependency installed, correct tailwind config file setup , but still css rules were not being generated/converted.
What fixed it for me was adding  to public/index.html
Documenting this for anybody else facing the issue in the future, coming from a Create-React-App setup.


Check whether gs is still needed

There is gs mentioned as dependency, but it has been commented out from code.
Is it still needed ?

Yes, gs is needed if we want to convert PDF to PNG without using inkscape nor convert from ImageMagick.

Inkscape sometimes produces weird-looking fonts
ImageMagick is an unnecessary dependency


Add eval workflow that triggers remote eval job

End-user friendly description of the problem this fixes or functionality that this introduces

[ ] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions
This workflow triggers a remote eval job that runs an evaluation of 1 instance for now. This is to get the basic setup working.

Link of any specific issues this addresses

To run this PR locally, use the following command:
docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:d179933-nikolaik   --name openhands-app-d179933   docker.all-hands.dev/all-hands-ai/openhands:d179933

I hear Tobi's concerns here. I am more optimistic than he is, it seems, and I think if the model causes issues we can change it, just like we did change the Deepseek earlier attempts.
However, the concerns about how applicable this eval is and to what and with what consequences raise also other questions.
Sorry @mamoodi, we got into the weeds on model and I didn't get to understand a few other things. You're saying this workflow would replace the other. However, correct me if I'm missing stuff:

Xingyao was making the old one run on this repo
trying to save outputs
and notify in a public comment
with a download of results.

This runs on a repo that is not public, with no comment/notification of what happened or results to dig in. How is it helping?
I'll come back on this, thank you for any clarification!

Alright fair comments .
This won't be replacing Xingyao's workflow for now because that workflow has more functionality.
The hope is to get it to comment back automatically. Right now that's manual.

Thank you. I applied the label. What did it do?

Auto response check - Evaluation results:
${summary}

Auto response check - Evaluation results:

Auto response check - Evaluation results:\n## Summary

submitted instances: 1
empty patch instances: 0
resolved instances: 1
unresolved instances: 0
error instances: 0

Auto response check - Evaluation results:\n\n## Summary

submitted instances: 1
empty patch instances: 0
resolved instances: 1
unresolved instances: 0
error instances: 0

I'm working on PR comments for start and finish....

Evaluation results: ## Summary

submitted instances: 1
empty patch instances: 0
resolved instances: 1
unresolved instances: 0
error instances: 0

This is a test comment.

Evaluation results: ## Summary

submitted instances: 1
empty patch instances: 0
resolved instances: 1
unresolved instances: 0
error instances: 0

Evaluation results: ## Summary

submitted instances: 1
empty patch instances: 0
resolved instances: 1
unresolved instances: 0
error instances: 0

Evaluation results: ## Summary

submitted instances: 1
empty patch instances: 0
resolved instances: 1
unresolved instances: 0
error instances: 0

Evaluation results: ## Summary

submitted instances: 1
empty patch instances: 0
resolved instances: 1
unresolved instances: 0
error instances: 0

Evaluation results: ## Summary

submitted instances: 1
empty patch instances: 0
resolved instances: 1
unresolved instances: 0
error instances: 0

Evaluation results: ## Summary

submitted instances: 1
empty patch instances: 0
resolved instances: 1
unresolved instances: 0
error instances: 0

@enyst we currently have it limited to just me, Graham, Xingyao, and Mahmoud, given the potential to accidentally spend several hundred dollars 😅

Maybe we can have tiers here, something like:

anyone can run an xs
maintainers can run s or m
admins can run large

I think we definitely need something, because if anyone wants to run stuff in private, one can always run stuff in private. But if this workflow is defined here on this repo, then I do think it should be useful somehow here.

To clarify: I already talked to mamoodi before and we agreed that from my perspective, this PR is mergeable as it is. Not because it's entirely ready, but we know what we need to think about. 😹
Sorry, I did want to see if it works. 😅
I think Haiku is actually relatively expensive, after all we changed from deepseek where the difference is very significant.
I'll give some thought to this:

anyone can run an xs
maintainers can run s or m
admins can run large


Cleanup and experimental code for samples

The squeezenet sample
uses Dispatcher. and Task.Run() for some unknown reason.  That was removed because I was thinking it would be confusing to users of the sample
The read of the json file was converted to using JSON.  Json.NET package was added.  This is much more straightforward for new users.
The model is loaded once.
Timing was added to the output, so that one can compare the performance with different CPU/GPU configurations.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ericleigh007 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Feedback Milestone 2

Hello, Group 16,
My name is Mohamad Khajezade, and I will be giving you some feedback on your project.
"This is a good starting point, but there is some work that needs to be done to elevate this project to our standards, so it meets our expectations."
I have divided up the feedback into several sections, so it is easier for you to implement.
Task 1
Good job
Task 2

[1] All in all, task 2 was ok. Yet, I had to browse your repo to find where you have called your method changing.

Task 3

[1 ] This task was not addressed correctly. For this task, you need to generated different charts to explain your data. You have used some pictures, which is not acceptable.

Task 4

[1 ]  This task was not addressed as expected. You need to use different charts, and you need to create some reports using python in your notebook. Instead, you have to use some pictures, which is not acceptable.

Hello Mohamad,
Are the pictures you're referring to the png files of our graphs? For this project, there was a folder for images that I thought we would need to use by saving our graphs as images. In this way, we can just generate the graphs once in our code and all the files that use the images will be updated. Would you like us to import all the data in our notebook and generate a graph each time? If you look in our analysis files, you will see that the pictures are saved files of our generated charts for easier integration into our README and other files.
Please let me know your thoughts.
Thank you.

Hello,
That's great. Please let me know when you added the chart. Then I can go ahead and change your feedbacks (with permission from Dr. Moosvi).
Cheers,
Mohamad

Hello Mohamad,
We have added the links to our notebooks in the combined analysis. The generations of the graphs can be found in those documents.
Thank you.

Hello Bellinda,
Thanks for letting me know. I changed the feedbacks for your group on grade scope.
Cheers,
Mohamad


fix a bug of strtold

Summary
if input is -1e308,The output should be -100000000......
but the output is -inf
See discussion here: https://github.com/apache/nuttx/pull/7992
Impact
Testing
sim:lua

Indeed this PR fixed the issue, and tests were able to move forward.
However, now there is a new Lua test failing.
I guess it is related, but I won't have the time to investigate it today.
Please have a look bellow:
NuttShell (NSH) NuttX-12.0.0
nsh> lua
Lua 5.4.0  Copyright (C) 1994-2020 Lua.org, PUC-Rio
> assert(0e12 == 0 and .0 == 0 and 0. == 0 and .2e2 == 20 and 2.E-1 == 0.2)
stdin:1: malformed number near '0e12'
>

Indeed this PR fixed the issue, and tests were able to move forward.
However, now there is a new Lua test failing. I guess it is related, but I won't have the time to investigate it today.
Please have a look bellow:
NuttShell (NSH) NuttX-12.0.0
nsh> lua
Lua 5.4.0  Copyright (C) 1994-2020 Lua.org, PUC-Rio
> assert(0e12 == 0 and .0 == 0 and 0. == 0 and .2e2 == 20 and 2.E-1 == 0.2)
stdin:1: malformed number near '0e12'
>

could you please change strtold to look like this and then test if there are any other questions

@flyingfish89 I tried the above change, and indeed it fixes the issue. The tests move forward.
However, I get a new failure at:
assert(tonumber'+ 0.01' == nil and tonumber'+.e1' == nil and
       tonumber'1e' == nil     and tonumber'1.0e+' == nil and
       tonumber'.' == nil)

After commenting out the failing tests, I get a new failure at:
assert(f(tonumber('  ')) == nil)

(And maybe there are more after that...)

Can you show me how to build your test program, and then I will fix the rest of the bugs as soon as possible

Can you show me how to build your test program, and then I will fix the rest of the bugs as soon as possible

I ’m sorry about this.

I ’m sorry about this.

Don't worry!
So, I am using the official Lua tests suite.
Tests can be found here.
I am using Lua v5.2.4, so I am running these tests.
The problematic file is math.lua, as you guessed, which is also attached. So you can concentrate on this, instead of running all the tests.
Note that the NuttX config is for Lua v5.4, while I am running v5.2.
However, as it turns out, all issues are reproducible on the standard config, using Lua shell directly through NSH.
So, you may just try on sim:lua.
Feel free to ask for anything that you may need me to test out, or for any Lua-related help.
math.lua.txt

As a side note, the Lua tests are quite extensive. They test both the language itself but also the system it runs on.
Lua depends on standards compliance, and the tests exercise this in many places.
I think that it would be a great addition to have CI run these tests.
Although strictly speaking it is not NuttX testing, it has indicated me lots of OS-level problems in the past.
It seems of great value.

ok,thanks for your suggestion and  I'll use it in my future work.


Automation for setting priority level for new issues at P2

This is a...

[x] Feature Request
[ ] Bug Report

Related to #1812
All new docs issues should be assigned the label P2 as their priority level for the new backlog process
@jaredbhatti

The new triage protocol with this directive is now in use. Thanks @a-mccarthy!


Update download images: single_cell_metadata is a tsv, not csv

While working on merged docs, I noticed a general discrepancy between all of our images and the actual downloads themselves.

All of our download images indicate a metadata file (caps for emphasis) single_cell_metadata.CSV, but the actual file itself is a single_cell_metadata.TSV. I confirmed this by downloading a sample from the portal.

See images here (same situation in the development branch) : https://github.com/AlexsLemonade/scpca-docs/tree/main/docs/images

The docs themselves state that it is a TSV, as well: https://github.com/AlexsLemonade/scpca-docs/blob/d7c2b4db3c75eb08530518c103fa23afc090ab8c/docs/download_files.md?plain=1#L67

So, I suppose we need to update all of the images with the correct extension.
FYI @dvenprasad

I compared each image in https://github.com/AlexsLemonade/scpca-docs/issues/238#issuecomment-1908900627 to the existing images, and the only difference I see is indeed we now have a tsv instead of csv where expected.

@dvenprasad SHOCKING UPDATE. Can we also -> csv -> tsv in the spatial-download-folder.png?
Should be spatial_metadata.TSV? (caps for emphasis) 🙃

Spatial Project Download

Closed by #257


refactor: update scripts for fork users

Description

When people fork this repository and add their private repositories, they have to fix some parts such as:

Change the default playbook name.
Add a token to clone private repositories.

To make it easier, I'll refactor the code.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Build CI: https://github.com/autowarefoundation/autoware/runs/6433565563?check_suite_focus=true


Maven command line multiline doesn't work with all shells

How are you running OpenRewrite?

Maven via Windows Terminal.
What is the smallest, simplest way to reproduce the problem?
Any of the Maven command lines including a backslash, like
mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
  -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:LATEST \
  -Drewrite.activeRecipes=org.openrewrite.java.migrate.jakarta.JavaxMigrationToJakarta

What did you see instead?

Not all shells can deal with the multi line. While plain old Windows cmd is okay with this, the newer Windows Terminal simply takes the first line and starts execution (even when running plain old cmd inside it).
To be compatible with all shells, the multiline backslashes should be removed. I'd expect the website to still show a reasonable command line, because CSS should be able to deal with the line wrapping.
Are you interested in contributing a fix to OpenRewrite?

Not really. :)

Thanks for the suggestion! Fixed in the latest commit. The next time we regenerate docs (the next release of rewrite), you should see the commands as single line commands and they should work for you.


Add a new flag to support config constants pool by json file

Add a new flag to support config constants pool by json file
The developer configures a json file, which will read all the contents of the configuration into the corresponding variables and parameters，then you can use it in android and iOS projects with custom variables
Scenes to be used:

Different regions and languages use different package names for internationalization. Different package names google-ad, google-service.json, facebook, and firebase have different configurations. It is very cumbersome to switch between definitions. Centralized management
You can use project variables directly in android build.gradle
You can use environment variables directly in iOS

1、Define  json file
flutter build apk  --define-config-json-file=cn.com.test.pkg.json

You can use flutter run --help get usage
    --dart-define=<foo=bar>                       Additional key-value pairs that will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, and double.fromEnvironment constructors.
                                                  Multiple defines can be passed by repeating "--dart-define" multiple times.
    --define-config-json-file                     The path of a json format file where flutter define a global constant pool. Use `const String.fromEnvironment("DEFINE_CONFIG_JSON_RAW_VALUE")` can get all config json file raw
                                                  value. Json entry will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, and double.fromEnvironment constructors;the key is json
                                                  filed key,get value is json value.

for example: cn.com.test.pkg.json  content
{
  "facebookAppId": "xxx",
  "versionName": "1.0.0",
  "label": "xxx xxx",
  "versionCode": 1,
  "android_applicationId": "com.xxx.br",
  "ios_bundle_identifier": "com.xxx.xxxx.nomodify",
  "googleAndroidApiKey": "xxxx",
  "googleAndroidAppId": "1:xxx:android:xxx",
  "googleAndroidMessagingSenderId": "xxx",
  "googleAndroidProjectId": "first-xxx",
  "googleAndroidStorageBucket": "first-xxx.xxx.com",
  "googleAndroidClientId": "xxx-xxxx.apps.googleusercontent.com",
  "googleIosClientId": "com.xxx.apps.xxx-xxx",
  "googleIosBundleId": "com.xxxx.br",
  "schemeHost": "first.xxx.com",
  "scheme": "xxxxx",
  "privacyProtocol": "https://xxxx.com/privacyProtocol.html",
  "teamsOfService": "https://xxx.com/teamsOfService.html",
  "androidChannel": "1OSH1PP64X",
  "iosChannel": "1J6C22IH91",
  "iosUploadCSymS": "false",
  "universalLinkDomain": "br.xxx.com"
}

2、Use environment in flutter
You can get all json raw content:
var configRaw =
        const String.fromEnvironment("DEFINE_CONFIG_JSON_RAW_VALUE", defaultValue: "{}");
var  configRaw = utf8.decode(base64Decode(configRaw));

Or ,you can get field by
var facebookAppId =
        const String.fromEnvironment("facebookAppId", defaultValue: "");

3、Android project
file: build.gradle

    buildTypes {
        release {
            manifestPlaceholders = [
                    faceBook_appId       : facebookAppId
            ]

            resValue "string", "facebook_app_id", facebookAppId

…………

task switchToGoogleServices(type: Copy) {
    description = "Switches google-services config,from google-services.${android_applicationId}.json to google-services.json"
    println(description)
    from "../../precompileConfigs/google-services"
    include "google-services.${android_applicationId}.json"
    into "./"
    rename "google-services.${android_applicationId}.json", 'google-services.json'
}

4、iOS project
file: ios/Flutter/Generated.xcconfig
  facebookAppId=xxx
  versionCode=1
  android_applicationId=com.xxx.br
  ios_bundle_identifier=com.xxx.xxxx.nomodify
 ……

file: ios/Flutter/flutter_export_environment.sh
export "facebookAppId=xxx"
export "versionCode=1"
export "android_applicationId=com.xxx.br"
export "ios_bundle_identifier=com.xxx.xxxx.nomodify"
……

You can use in Info.plist
	<key>CFBundleIdentifier</key>
	<string>$(ios_bundle_identifier)</string>

Thanks for the correction to the last PR
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I'm not sure if you missed it in my last message (https://github.com/flutter/flutter/pull/105213#issuecomment-1151661717), but I actually think that you should start by first filing an issue for a new feature request (you can re-use a lot of your description from this PR), where we can discuss the approach BEFORE you do any coding. Sorry about the confusion!

unfortunately this PR has been partially reverted, making --dart-define-from-file useless for automating builds..


More explicit specs for fcall as default argument

also replace "hi" with Object.new for example as in Opal strings are immutable

Right to the point, LGTM!


Update Mocha link

Coverage remained the same at 100.0% when pulling 8a21fa62f1388b03cbdd24c5dab215962fc5a0c2 on mortonfox:patch-1 into 72845a0ba0fb36432fe7eeaf32687a851aec1f13 on doc-metrix:master.