Validation test utility for traces; validation processor for on-line validation; minor fixes

This PR contains two tools used to identify the problem in https://github.com/f5/otel-arrow-adapter/pull/202 and #205.

The collector/connector/validationconnector is an OTel "connector" (a more-general case of "processor") that can be used to setup a validation test for on-line use, where two parallel pipelines are expected to yield the same data. This has a TODO and cannot yet be reliably used, but it was developed and waits on a solution in the core collector.
When I had reproduced a small example with the above, I wrote a small CLI tool to isolate the problem, see tools/trace_verify which simply applies the Arrow producer/consumer to a stream of JSON data, as written by the collector/examples/synthesize configuration using the https://github.com/lightstep/telemetry-generator.

The collector/examples/synthesize yamls are rewritten for clarity and to demonstrate the use of the connector. (Although it fails 50% of the time, based on a random map iteration order problem.) The changes, roughly:

record.yaml only records data through the obfuscator and batch processor
replay.yaml applies the validation connector and runs the data through Arrow (vs the first stage, which was also sending through Arrow before).

Also addresses minor issues discovered while running the examples.

fileexporter: locking needed, no retries or queueing wanted (esp for the validation use-case)
otlpexporter: use a default max lifetime
obfuscationprocessor: support logs, shorten option names, and synthesize a key instead of configuring it, since we have no desire to de-obfuscate the data here.

cc @moh-osman3


feat: add dynamic params to text

What does this do?
This PR extends the Text component to support translation parameters by modifying the tx prop to accept an object with a translation key and parameters. This allows developers to use dynamic, interpolated values within translations (e.g., inserting names or numbers into strings).
Why did you do this?
This change was made to improve the flexibility of the Text component, particularly for internationalization. In many cases, translations require dynamic content (e.g., greetings with a user’s name), and this update allows developers to pass those parameters directly through the component. It simplifies the code needed for multi-language support and enhances readability.
Who/what does this impact?
This change impacts developers using the Text component for localized content, as it enables dynamic translations without requiring custom workarounds. This is especially relevant for teams working on multilingual applications that need flexibility in handling text. It should not introduce any breaking changes to existing functionality, as it maintains backward compatibility with the previous tx prop type.
How did you test this?

Verified that the Text component correctly renders static translations as before.
Tested the component with translations that include dynamic parameters, ensuring they render as expected.
Checked the component in RTL and LTR layouts to confirm no side effects with the added parameter support.

Thank you for the feedback, @yjose! 🙏
I’ve updated the code to replace any with a more specific type ({ [key: string]: string }) for the options. I also renamed params to options as you suggested to improve clarity.
Let me know if there’s anything else I can adjust.

@elalami-m Good! I would love to make the option more accurate by adding the correct type. I think it should be TranslateOptions. You can check this file.

@elalami-m I would also appreciate it if you could add an example for translations as part of the style screen, similar to what we have for typography and buttons. By providing the different values available for text with translation and options, we can enhance clarity.


Can't get into DFU mode

Hello,
yesterday I flashed a Quicksilver firmware on my Mobula 6. I was having trouble configuring it and decided to flash back to Betaflight. So today I decided I will try once more so I flashed it back to Quicksilver. Something went wrong during the flash procedure and now I can't put it in the DFU mode. I tried almost everything and I'm kinda hopeless to the point of getting myself a new FC.
So when I'm in the QS configurator I plug a USB into FC and reset it to bootloader. In ports I select a COM port which says QUICKSILVER, choose connect and it resets in Bootloader. Than I select the FW and the target and click Flash. And there is no COM port to select in this step. So I presume it didn't go in the DFU mode after all.
I'm using a Crazybee F4 (Flysky) with the ELRS EP2 RX on UART 1 so when my radio is turned on I get a solid light on the RX and a telemetry reading on my radio.
Please help because I'm becoming desperate.
Thanks

I am sorry, but this not a support forum. Your fc not broken. Check our docs or hop on our discord.

Thanks for the reply. I’m on macos unfortunately. I will try to fix this
issue on a Windows computer. Hope it works!
Best regards,
Ales
On Tue, 24 Jan 2023 at 00:09, Benedikt Kleiner @.***>
wrote:

I am sorry, but this not a support forum. Your fc not broken. Check our
docs https://docs.bosshobby.com/Troubleshooting/ or hop on our discord
https://discord.gg/8StVhvB6Tm.
—
Reply to this email directly, view it on GitHub
https://github.com/BossHobby/QUICKSILVER/issues/77#issuecomment-1401130089,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM54K42IJ3YMBAD4MTHYSNLWT4FRLANCNFSM6AAAAAAUEMU7AM
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Aleš Ogrin


Transform element getters attachment

Hi,
I'm trying to use Camera code you provide in tools and it seems it relies on existence of rotation/translation getters for <transform> element referenced by <view>.
The problem is in my case those getters are attached too late - they are not immediately accessible after creation <transform>.
Assuming that camera module requires xml3d, following code produces error due to the undefined "rotation"
requireqjs ('[camera]', function () {
   $('body').append('
      <xml3d>
          <view transform="#t"></view>
          <transform id="t" rotation=...></transform>
     </xml3d>');
     var cam = XML3D.StandardCamera($('view')[0]);
});

Yeah I've seen this before. Internally we override document.createElement to be able to configure things immediately, but AFAIK jQuery bypasses this when using append with a DOMString by creating a <div> and settings its innerHTML to the string.
There's not much we can do about this, unfortunately. The only possibility to hear about DOM nodes created in this way is through the MutationEvent that it triggers, and that's created asynchronously (in this case after your camera initialization). Your best bet would be to add a load listener to the XML3D element and have that initialize the camera:
$('body').append('
    <xml3d onload="init()">
        <view transform="#t"></view>
        <transform id="t" rotation=...></transform>
    </xml3d>'
);

function init() {
    var cam = XML3D.StandardCamera($('view')[0]);
}


Mock the TmcUtil tests.

Fixes #207.

Coverage remained the same at 44.725% when pulling 781e1ba345246e17b4b72266acec915d6a27a61b on mock-tmc-util-aleksi into b70ee99f06e6097869fcddd60ed669b4da392f2e on master.

Coverage decreased (-0.3%) to 44.444% when pulling 781e1ba345246e17b4b72266acec915d6a27a61b on mock-tmc-util-aleksi into b70ee99f06e6097869fcddd60ed669b4da392f2e on master.

:+1:


create mergeStores method to support modules

You should be able to export individual instances of Substate and merge them into one for a shared set of stores.

#17


use xxPreparers dynamically

This is a mechanism to create specific outside dependencies for each "resource_class+ resource_name" instance.
Currently only three outside depend resources are supported: ""resource-group", "virtual-network", "subnet".
As current trail on 'managed-network' and 'data-factory', seems like resource-group and virtual-network are enough.

Hi @zikalino , Just push refactors for the review comments:)

Hi @zikalino @qiaozha , here is some information for latest commits, would you help review on it:)

resolve outside dependencies with xxPreparers
resolve subscription id in tests.
az issue #119: randomize internal resource names
az issue #158: Remove commands "check-name-availability" and "list-operation"
sort examples by internal resource dependency.


Unable to view profile of PRIMARY users if a secondary userstore is having a connectivity issue

Description
When we request attributes, it searches through all the user stores with the given user id. If one of the userstores is having some issue, the users on other user stores even won't work. This might be addressed by gracefully handling errors than breaking the full iterative search.
How to reproduce:

Configure JDBC primary userstore as database_unique_id and a secondary userstore with read_write_ldap_unique_id.
Shutdown the secondary LDAP userstore.
Create a user in the PRIMARY userstore.
Try to view the user profile of the newly created user on the primary userstore from the management console.
It will show an error on the UI and carbon logs will show the connectivity error to LDAP.
Also, try listing users across all domain or try adding a new user to the primary userstore via SCIM. It will give an Internal Server error.
Disable the secondary user store and try again. The all the above steps will work without any issues.

Cause
Not having an entry in the UM_UUID_DOMAIN_MAPPER table.
Environment information

Product Version: IS 5.11.0 RC

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


added uv run python section

closes #6548
Summary
Updated the docs and included the uv run python repl section.

@lucab ,
If this solves the issue, can you merge the pr?


Insert Text Block by default

Is there any possibilty to insert a Text Block by default instead of showing the BlockControls?
Thank you for your help.

You can set { defaultType: “Text” } in options that are passed to the editor on initialisation. See the docs for all options.
http://madebymany.github.io/sir-trevor-js/docs.html
--
Oli Matthews
http://madebymany.com | @olvado
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Friday, 8 May 2015 at 12:55, Felix Klotzsche wrote:

Is there any possibilty to insert a Text Block by default instead of showing the BlockControls?
Thank you for your help.
—
Reply to this email directly or view it on GitHub (https://github.com/madebymany/sir-trevor-js/issues/335).


[stable/verdaccio]: Avoid hard-coding gid in securityContext

What this PR does / why we need it:
Currently, deploying verdaccio on OpenShift fails because when containers are deploying on OpenShift clusters, the gid 1000 does not exist. Containers on OpenShift are created with randomized IDs.
This PR avoids forcing volume with a specific gid which may not exist.

@etiennetremel Here is another PR. We have been able to deploy verdaccio-gitlab on OpenShift successfully after this modification.
Again, I am not entirely sure what the best practices are here, so I would appreciate your input. I have looked at postgres helm charts as a reference (which we were able to deploy on OpenShift right off-the-shelf without any modifications)

/assign @foxish

cc @prydonius, @mattfarina

@etiennetremel I will take over this since my colleague Ercan is on holiday. But there's something I don't understand about the current default for the securityContext. It didn't work for us in our OpenShift cluster, that's understandable because the uid is randomized on startup.
What I don't understand is how this code even works on vanilla kubernetes: checking the source verdaccio Dockerfile for 3.x, it creates and runs the process as user-group verdaccio:verdaccio, which get assigned the next uid and gid, in my current docker env are 100 and 101. The base image for node seems to create the user & group node:node that actually both are 1000:
/usr/local/app $ cat /etc/passwd | grep -iE 'node|verdaccio'
node:x:1000:1000:Linux User,,,:/home/node:/bin/sh
verdaccio:x:100:101:Linux User,,,:/home/verdaccio:/bin/false

/usr/local/app $ cat /etc/group | grep -iE 'node|verdaccio'
node:x:1000:node
verdaccio:x:101:verdaccio

So, I don't understand how mounting volumes under group 1000 allows the process running as user verdaccio to access the data. Shouldn't the defaults be (I will template this with a flag as you suggested):
 securityContext:
   runAsUser: 100
   fsGroup: 101

/cc @ercanucan @bufferoverflow

You are right, the following is actually what should have been there:
      securityContext:
        fsGroup: 101

The runAsUser is not necessary since it is set in the container. fsGroup is mandatory if you want users different than root to write files to persistent volumes.
So if you make these change that would be great, you don't need to make it behind a feature flag.

Thank you for the quick answer, it's good to know that I'm not crazy :-)
Nevertheless, we still need to make this configurable with a feature flag, because in openshift, under certain deployment restrictions, we get assigned a random uid on startup. Trying to force it via a fixed number in the securityContext fails.
[fsGroup: Invalid value: []int64{101}: 101 is not an allowed group]

As I would make a PR to make it configurable, if it's ok for you, I would also add default values for runAsUser = 100 and fsGroup = 101, I have seen in other charts that both are usually configurable.

Also, I was working on improvements for this in the upstream verdaccio project, they have been merged into the future 4.x release, so this will probably need a refactoring in the future:
https://github.com/verdaccio/verdaccio/pull/864
At the moment we are working with our own custom builds based on that PR.

Sounds good, thanks!

This can be closed, changes in https://github.com/helm/charts/pull/6957 have been accepted

Closing due to other PR being accepted. If this should be re-opened please let me know.


Redundant paragraph

There is a redundant and duplicate paragraph in this article, which can be removed:
In this public preview release, we are introducing the virtual connector provider that supports creating virtual tables using the SQL Server connector. We will continue to expand and support other tabular connectors as part of this provider in subsequent releases.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a5b64c8d-3c3d-4e4d-afb1-5e0a54c84046
Version Independent ID: 8180bdbe-ec98-642e-b7ee-1f57954ee502
Content: Create virtual tables using virtual connectors (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/virtual-entities/create-virtual-tables-using-connectors.md
Service: powerapps
GitHub Login: @NHelgren
Microsoft Alias: jdaly

@pratapladhani Thanks for your feedback; this is fixed now. Closing the issue.


Automate publishing

According to the README all the publishing is done manually and requires access to DigitalOcean.
Is this still true? Can we get this automated like some of the other sites?

Also, can we get a manual publish for the latest.
I tried to run the publishing locally to at least just hand you a CID but it wants to authenticate to npm in order to run so there's some additional assumptions about access controls in the publishing script we haven't even documented.
@diasdavid said that @VictorBjelkholm is the person to ping here :)

Hey, it's already setup to be automatic! You can tell by the Status messages in the PR and also the presence of a Jenkinsfile.
Is it not up-to-date? Last commit was successfully built and deployed

Keep in mind as there are DNS updates, it can take some time for the records to propagate.

Ah, awesome. We should get the README updated :)


New version: jlpkg v1.1.3

Registering package: jlpkg
Repository: https://github.com/fredrikekre/jlpkg
Created by: @fredrikekre
Version: v1.1.3
Commit: 56c3ef564c19809aacecd87b2541ac9f2b99b781
Reviewed by: @fredrikekre
Reference: https://github.com/fredrikekre/jlpkg/commit/56c3ef564c19809aacecd87b2541ac9f2b99b781#commitcomment-38012844

@fredrikekre Any idea why the Travis job is not starting?
[noblock]

Backlog from all your restarts probably: https://travis-ci.com/github/JuliaRegistries/General/pull_requests

I think it's actually a Travis problem.

Builds not starting/queuing or stucks on .COM
Monitoring - We have observed the root cause of the problem with the builds isn't starting due to misusage. Currently, we are recovering the infrastructure.

https://www.traviscistatus.com/

Passed: https://travis-ci.com/github/JuliaRegistries/General/builds/154752547


Whiteboard JAX-RS Multipart

Hi guys,
I encountered another problem and I was hoping you could help me out, again.
I am trying to process a request containing a multipart/form-data.
As far as I understood beginning from v3 the HttpServletRequest can parse the form-data without the need of any library.
I extended my small osgi-test app by another controller for the multipart endpoint.
https://github.com/phhoef/osgi-test/blob/master/rest-service/src/main/java/com/my/app/rest/rest/MultipartController.java
Whenever I am trying to invoke the getParts() method the following exception is thrown:

HTTP ERROR 500

Problem accessing /multipart. Reason:

    Server Error

Caused by:

java.lang.IllegalStateException: Multipart not enabled for servlet.
	at org.apache.felix.http.base.internal.dispatch.ServletRequestWrapper.checkMultipart(ServletRequestWrapper.java:368)
	at org.apache.felix.http.base.internal.dispatch.ServletRequestWrapper.getParts(ServletRequestWrapper.java:522)
	at javax.servlet.http.HttpServletRequestWrapper.getParts(HttpServletRequestWrapper.java:345)
	at com.my.app.rest.rest.MultipartController.post(MultipartController.java:22)

I understand, that I have to activate multipart for that Servlet.
I didn't find much on the internet, only some posts stating either using @MultipartConfig or the @HttpWhiteboardServletMultipart annotation.
For the @MultipartConfig I modified the controller. I subclassed the HttpServlet and set the @Component(service=Servlet.class).
https://blog.osgi.org/2018/05/osgi-r7-highlights-http-whiteboard.html
But both annotations do not influence the behavior.
Do I miss something?

You have the correct configuration using @HttpWhiteboardServletMultipart.
It looks like it might be a problem/bug with org.apache.felix.http.

thanks for your quick reply.
At least it seems to be not my fault :-)
Is there any way to verify your guess?
Do you think, that there might be a workaround?

I can look when I have time but I'm not sure where that will be. Maybe sending a message to the felix mail list might provide some insight?

I found out,  that using the classic way and override the doPost method the @HttpWhiteboardServletMultipart annotation will work.
@Component(service=Servlet.class)
@HttpWhiteboardServletMultipart
@HttpWhiteboardServletPattern("/multipart")
public class MultipartController extends HttpServlet
{
    @Override
    protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException
    {
        Collection<Part> parts = req.getParts();

        for (Part part : parts)
        {
            System.out.printf("File %s, %s, %d%n", part.getName(),
                    part.getContentType(), part.getSize());
        }
    }
}

I am still searching for a solution using the JAX-RS way with multipart...

Whenever I am trying to invoke the getParts() method the following exception is thrown:

This appears to be an intentional limitation of the JAX-RS whiteboard implementation from Aries, which has not requested that multipart be enabled. Fortunately the Aries JAX-RS whiteboard is pretty flexible, and allows you to configure the properties of the servlet it registers. This should be as simple as adding:
osgi.http.whiteboard.servlet.multipart.enabled=true

as a configuration property for the whiteboard. Assuming that you are using the default whiteboard this pid would be org.apache.aries.jax.rs.whiteboard.default. At this point multipart will be enabled for your JAX-RS whiteboard.
Once you have done this then you can use multipart however you wish, although I would suggest that a more natural approach involves using the @FormParam annotation.

Thanks @timothyjward and thanks @rotty3000 for your patient and your answers.
I know most of my questions are off topic. So, I really appreciate your reply :-)
I am sorry, but I didn't understand your answer completely.
I understand, that I can activate the multipart for a JAX-RS Whiteboard resource, by adding the mentioned property.
But I am afraid, I am failing in setting this property.
@Component(service=MultipartController.class, property = {"osgi.http.whiteboard.servlet.multipart.enabled=true"})
@JaxrsResource
@Path("/multipart")
public class MultipartController
{
    @POST
    public void post(@Context HttpServletRequest request) throws Exception
    {
        for(Part part : request.getParts())
        {
            System.out.println(part.getName());
        }
    }
}

Is there something wrong?
Exception still says multipart is not enabled.
Thanks

I understand, that I can activate the multipart for a JAX-RS Whiteboard resource, by adding the mentioned property.

I’m afraid that this is a misunderstanding, and I may have been insufficiently clear. There is no property you can add to your JAX-RS resource service to enable multipart support. Note that this does not mean that you cannot enable multipart support, but you must do it elsewhere.
Most JAX-RS whiteboards build on top of the Http Service Whiteboard by registering a whiteboard Servlet, which they then use to provide endpoints for all of their resources. Aries JAX-RS is one of these implementations. The available support from the web container is therefore entirely dictated by the service properties of the implementation’s whiteboard Servlet, not the service properties of the JAX-RS resources. Even if the JAX-RS whiteboard created its own web server, it would still be this configuration we needed to alter, not the properties of your whiteboard resource.
To enable multipart support we must therefore add to the service properties of the JAX-RS whiteboard’s implementation. You can do this by changing the configuration of the whiteboard using a configuration admin dictionary as I described earlier. This would be a new entry in your JSON configuration file.
For belt and braces you could further require that this property had been set by using a whiteboard target for your JAX-RS resource service (this would be a service property on your service). This filter could require that the osgi.http.whiteboard.servlet.multipart.enabled property was true.

I totally misunderstood your first post.
Thanks for clarification :-)

Hi @timothyjward , Can you please let me know where I can add the property "osgi.http.whiteboard.servlet.multipart.enabled" to JAX-RS whiteboard configuration

Hi @timothyjward , Can you please let me know where I can add the property "osgi.http.whiteboard.servlet.multipart.enabled" to JAX-RS whiteboard configuration

As described further up this bug, if you want to enable this for the default whiteboard then the configuration pid is org.apache.aries.jax.rs.whiteboard.default, otherwise it goes in the factory configuration that you are adding to create a new whiteboard instance.

@timothyjward I wonder if there would be any downside with making this the default?

@timothyjward I wonder if there would be any downside with making this the default?

It would require the hosting Servlet container to always support multipart, which is a relatively uncommon feature to need in a JAX-RS app. As is we can run on containers which don’t support multipart.

that's a good point. thanks for the thought experiment. retracting the idea :)


Remove displaying the short content from home UI

Feature request-

As you can see, such a UI isn't an attractive one for the users.
Is your feature request related to a problem? Please describe. (optional)
A clear and concise description of what the problem is.
Describe the solution you'd like
I thought to not to display the short content on home, dashboard, category, user profiles UI. Just the title, published date, author and read more button would be neater.
Describe alternatives you've considered
I was thinking to create a separate partials that displays the posts. Because, we can clearly see the the blogs are displayed in same way in 4 different routes(mentioned above).There maybe different blogs with different route but the way to display them is same right... I shall try to work on this also in this pr.
Describe how this feature will be useful to our readers.
A clear and concise description of how this feature will be useful for our  other readers.
Additional context
Add any other context or screenshots about the feature request here.

Note:

Do mention if your are working under GSSoC'21.
If you want to work on an issue, you should check if it has already been assigned to anyone. If the issue is free you can comment /assign to get the issue assigned to you.
If you are raising a new issue and want to work on it then also you should comment /assign under the issue to get it auto assigned.
Please refrain from adding labels to your issue/pull-request on your own. It is the job of the Project Admin and the Mentors to review your issue/pull-request and add labels accordingly.
According to the level of the issue, respective time will be allotted under which the task needs to be completed/resolved by the assigned person. If the issue is not resolved within the given time, it will be assigned to the next person. In case of any discrepancies, the decision of the maintainer will be final.

level - 0: 2 days
level - 1: 3 days
level - 2: 4 days
level - 3: 5 days

gssoc21

/assign

Hey, can I work on this issue? I think we should display short content, 3-4 lines and if the user wants to read complete blog, then he/she can click 'Read more'

Hey, can I work on this issue? I think we should display short content, 3-4 lines and if the user wants to read complete blog, then he/she can click 'Read more'

Im already ready with the pr, just waiting for my old pr #444  to get merged...


Fix scroll behaviour in GroupDiagram

Hey, I just made a Pull Request!
This is a fix related to issue #11429.
It adds a background to the the group diagram to make it clearer where the actual graph is located, and also prevent weird scroll/zoom behaviour when hovering the DependencyGraph. With this fix the user can only zoom in and out while hovering the graph and if the cursor is not hovering the graph the user is allowed to scroll up and down, which allows for more consistent behaviour.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

I'll create a changeset and add it, no problem.
However, I'm having some troubles with the DCO. Previously, it failed as my my email did not end with<EMAIL_ADDRESS>. Now I have fixed it but it still complains at the same thing and says "  is not a valid email address." even though my email in reality is now @gmail.com . So, it seems to me that the test has not rerun or at least not noticed the updated commit messages.
Any idea on how to fix this or do I have to make the PR all over again?

Any ideas on how to solve the DCO issues? @freben

Thanks! I think I will probably have to do that. @jamieklassen


fix: Update Bastion DNS entries only when enabled

Update Bastion DNS entries only when enabled.

Hi @smolin-de, I discovered issues with undefined vars. Makes it sens to have a "is defined" check, too?

Hi, env.bastion.options.dns is a defined variable in the all.yaml.template file. It must be defined. Either 'true' or 'false'. If the variable is not defined, do we assume bastion host supports dns or not ?

I would say that DNS is being supported if set to true all other values (include not define) will be taken as not supported.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Bug]: Type 'SlashCommandOptionsOnlyBuilder' is not assignable to type

Contact Details
No response
What happened?
When user addStringOption or any options expect addSubComamnd,addSubCommandGroup  it wil return error
Type 'SlashCommandOptionsOnlyBuilder' is not assignable to type 'SlashCommandBuilder | SlashCommandSubcommandsOnlyBuilder | Omit<SlashCommandBuilder, "addSubcommand" | "addSubcommandGroup">'.
  Type 'SlashCommandOptionsOnlyBuilder' is not assignable to type 'Omit<SlashCommandBuilder, "addSubcommand" | "addSubcommandGroup">'.
    The types returned by 'setName(...)' are incompatible between these types.
      Type 'SlashCommandOptionsOnlyBuilder' is missing the following properties from type 'SlashCommandBuilder': addSubcommandGroup, addSubcommand
      ```

      this my code
      ```js
 import { PermissionsBitField, SlashCommandBuilder } from 'discord.js';
import { ChatInputCommand } from '../../interfaces';

const command: ChatInputCommand = {
    options: new SlashCommandBuilder()
        .setName('emit')
        .setDescription('Emit an event')
        .setDMPermission(false)
        .setDefaultMemberPermissions(PermissionsBitField.Flags.Administrator)
        .addStringOption((option) =>
            option
                .setName('event')
                .setDescription('The event to emit')
                .setRequired(true),
        )
        .addStringOption((option) =>
            option
                .setName('data')
                .setDescription('The data to emit')
                .setRequired(true),
        ),
    global: true,
    execute: async (_client, interaction) => {
        const event = interaction.options.getString('event', true);
        const data = interaction.options.getString('data', true);
        _client.emit(event, data);
        await interaction.reply({ content: `Emitted event \`${event}\``, ephemeral: true });
    },
};
export default command;

Version
discord.js v14.16.2
nodejs v18.20.4
What engine are you seeing the problem on?
No response
Relevant log output
No response

Hey there @ShkourBashtawi! Thank you for reporting this bug. This issue should be fixed in https://github.com/ppauel/typescript-discord-bot/commit/d9b97855f16bf7e94ba64bf3725aeeb05199336f. I moved from a rest instance to using the client's application class.

Hey bro @ppauel thx for response
The problem has been solved. Thank you


DATAJDBC-347 - Add missing override to SelectBuilder.

SelectAndFrom now overrides all from(…)methods to return the appropriate builder continuation type.

Related ticket: DATAJDBC-347.

Merged.


[usbdev] av empty sequence

This draft PR contain av empty sequence

@jdonjdon  kindly review this. Thanks.

@alees24  Kindly review this. Thanks.

I think this is intended to implement av_out_empty? Please could you force-push to drop the other commits?

These sequences aren't used anywhere (e.g. usbdev_vseq_list.sv) and there has been quite a lot of change in the environment since this was pushed. Please rebase and resubmit if there's still anything this can do.


vdiff: remove unnecessary collect during diffing

What the title says.
I didn't bench if this improves performances, since there is currently no bench in yew. I'm open to ideas on how to.

Nice! I agree that we should add benchmarks to this project to be able to push for much better performance. Before working on optimizations like this one, I think we should add an automated bench marking tool to this project to see what kind of improvements we are getting. Something like: https://github.com/krausest/js-framework-benchmark

@totorigolo I ran benchmarks against your commit and its parent. The results looked good, thanks!

bors r+


Use of multiple cores of CPU

Hello.
I hope I write in the correct forum.
I've found a bug(?!) in the mining settings.
If I set the number of cores on one I generate normal blocks.
If I increase the number I lose the connection or shared additional cores are not used.
I hope you can understand me
best regards

i get the same problem, the current workaround is: set the cpu count, disable mining, reenable mining, hit F5 to check if it really submitted. seems to be just a missing event handler for the input field, so toggling the dropdown box submits the settings.

Hi,
i change my Sytem to Debian. Now i can use all Cores with a better Hash Rate.
It works without problems.


Create an Extractor for DemandBase

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1415
Originally created by @dmor on 2019-12-09 22:45:52

GitLab is now using DemandBase for account based marketing, and a request to add an extractor to pull its data came up in a customer discovery call.

View 3 previous comments from the original issue on GitLab


please add default layout for views

kean ho, could you please include the  default layout for all views file
eg: application.html.erb
<!DOCTYPE html>

  <title>Blog</title>
  <%= stylesheet_link_tag    'application', media: 'all', 'data-turbolinks-track' => true %>
  <%= javascript_include_tag 'application', 'data-turbolinks-track' => true %>
  <%= csrf_meta_tags %>

title

<%= yield %>

Ticket accepted. Progressing to development.

Feature enabled under the commit id 14e69a28fbaa41c0437602d8c046d131c1a1d0c6. Please test and proceed to ticket closure. Thank you.


Issue 94 WIP

Does Danger add anything besides noise? I feel it does more harm than good.

@modocache - it has helped before, but you're right -- mostly noise! we can disable 😄

@jessesquires, what I saw, Danger alerts on many specific to development words and names. Is there any way to add them to ignore list?

Yes, but I am afraid it is a continuous battle and would not be worth it.

🎉


feat: Add get util

What type of pull request is this?

[x] Non-breaking code change
[ ] Breaking code change
[ ] Documentation change/addition

Description

Discord.py had 2 utilities for searching an iterable, find and get. Dis-Snek already implements find, but is missing an implementation for get. This PR adds that missing implementation.
Changes

Add dis_snek.client.misc_utils.get

Checklist

[x] I've formatted my code with Black
[x] I've ensured my code works on Python 3.10.x
[x] I've tested my code

[x] Looks good

Honestly not a bad idea. Want me to add a get_all and find_all to this PR?

That would be great

For speedup purposes, please use the list literal instead of the function (C408)

Changed

Pending re-review from @leestarb


Heroku

Once merged on master these changes will switch our toonin client and backend to heroku. The old backend without distributed streaming is currently hosted on heroku already. Master will get auto deployed to heroku due to our circle ci config.

@alir128 Give me the public DNS for the server after merging so I can update the A record for the domain


protein modification errors

I fixed
https://github.com/pombase/allele_qc/tree/master/results
https://github.com/pombase/allele_qc/blob/master/results/protein_modification_cannot_fix_other_errors.tsv
except
SPBC28F2.12	rpb1	MOD:00696	Inferred from Direct Assay	CTD_S2	added_by(PomBase:SPAC2F3.15)	PMID:19328067	4896	2009-07-12	pattern_error
SPBC28F2.12	rpb1	MOD:00696	Inferred from Direct Assay	CTD_S2	added_by(PomBase:SPBC32H8.10)	PMID:19328067	4896	2009-07-12	pattern_error
SPBC28F2.12	rpb1	MOD:00696	Inferred from Direct Assay	CTD_S5	added_by(PomBase:SPBC19F8.07)	PMID:19328067	4896	2009-07-12	pattern_error
SPBC28F2.12	rpb1	MOD:00696	Inferred from Direct Assay	CTD_S5	added_by(PomBase:SPBC32H8.10)	PMID:19328067	4896	2009-07-12	pattern_error
SPBC28F2.12	rpb1	MOD:00046	Inferred from Direct Assay	CTD_S5	added_by(PomBase:SPAC24B11.06c)	PMID:33410907	4896	2021-01-12	pattern_error
SPBC28F2.12	rpb1	MOD:00046	Inferred from Direct Assay	CTD_S5	removed_by(PomBase:SPAC3G9.04)	PMID:33410907	4896	2021-01-22	pattern_error
These are a special case. I wonder if we can
a) accept these without an error
b) interpret this shorthand for display purposes as follows:
S2 is shorthand for 1579 1586 1593 1600  1607  1614 1621 1628 1635 1642 1649 1656 1663 1670 1677 1684 1691 1698 1705 1712 1719 1726 1733 1740 1747
S5 is shorthand for 1582 1589 1596 1603  1610 1617 1624 1613 1638 1645 1652 1659 1666 1673 1680 1687 1694 1701 1708 1715 1722 1729 1736 1743 1750
(S for each)

@manulera
@kimrutherford

Hi @ValWood sorry for the late reply.
Option 1
If you follow a special naming pattern for those alleles (for instance CTD:S2 like you do in GO annotations), I could skip those from the validation so they would not be returned as an error. The problem is how these can be used by people who download the dataset, since they don't follow the pattern of everything else.
Option 2
We could translate that notation CTD:S2 into the actual residues. This is better for people using the dataset, and for showing the modifications in the map. The problem is then that the display in the gene page would be too crowded. @kimrutherford we could maybe revert to the concise notation at the front-end level? This might be a pain.

I like the idea of displaying the shorthand notation and unfolding to the full residue description in datasets.

Decision, where to store the full string (at the moment we only have CTD_S2)
Also should be documented https://www.pombase.org/documentation/gene-page-modifications

Decision, where to store the full string (at the moment we only have CTD_S2) (config file?)

If we add the abbreviations and the full residue descriptions to the main config file we'll be able to write out the residues and positions in the TSV file.  If it helps we could also show the residues and positions as a mouse-over for "CTD_S2" etc. on the gene pages.

I like the idea of displaying the shorthand notation and unfolding to the full residue description in datasets.

Could you let me know what the full versions are?

S2 is shorthand for 1579 1586 1593 1600 1607 1614 1621 1628 1635 1642 1649 1656 1663 1670 1677 1684 1691 1698 1705 1712 1719 1726 1733 1740 1747
T4 is shorthand for 1584 1591 1598 1605 1612 1619 1626 1615 1640 1647 1654 1661 1663 1675 1682 1689 1696 1703 1710 1717 1723 1731 1738 1745 1752
S5 is shorthand for 1582 1589 1596 1603 1610 1617 1624 1613 1638 1645 1652 1659 1666 1673 1680 1687 1694 1701 1708 1715 1722 1729 1736 1743 1750
S7 is shorthand for 1584 1591 1598 1605 1612 1619 1626 1615 1640 1647 1654 1661 1668 1675 1682 1689 1696 1703 1710 1717 1724 1731 1738 1745 1752

S2 is shorthand for ...

Thanks.  Is that what should appear in the modifications file?: https://www.pombase.org/data/annotations/modifications/pombase-chado.modifications.gz
The other modifications are of the form "S225,S157,S15,S62" or "S220".

Sorry I only put the numbers. What I should have said was
CTD_S2 is shorthand for S1579,S1586,S1593,S1600,S1607,S1614,S1621,S1628,S1635,S1642,S1649, S1656,S1663,S1670,S1677,S1684,S1691,S1698,S1705,S1712,S1719,S1726,S1733,S1740,S1747
CTD_T4 is shorthand for T1584,T1591,T1598,T1605,T1612,T1619,T1626,T1615,T1640,T1647,T1654,T1661,T1663,T1675,T1682,T1689,T1696,T1703,T1710,T1717,T1723,T1731,T1738,T1745,T1752
CTD_S5 is shorthand for T1582,T1589,T1596,T1603,T1610,T1617,T1624,T1613,T1638,T1645,T1652, T1659,T1666,T1673,T1680,T1687,T1694,T1701,T1708,T1715,T1722,T1729,T1736,T1743,T1750
CTD_S7 is shorthand for S1584,S1591,S1598,S1605,S1612,S1619,S1626,S1615,S1640,S1647,S1654,S1661,S1668,S1675,S1682 S1689,S1696,S1703,S1710,S1717,S1724,S1731,S1738,S1745,S1752
The other thing we will be able to do this this detail is to display the rpb1-CTD modifications here:

OK, thanks.  I'm working on this now.

The CTD abbreviations are implemented for Friday night's load.
The configuration is here:
https://github.com/pombase/pombase-config/blob/e90178606cbe95c7161e61b40db2abe9e762da2e/website/pombase_v2_config.json#L7009-L7016
"modification_abbreviations": {
   "SPBC28F2.12": {
      "CTD_S2": "S1579,S1586,S1593,S1600,S1607,S1614,S1621,S1628,S1635,S1642,S1649, S1656,S1663,S1670,S1677,S1684,S1691,S1698,S1705,S1712,S1719,S1726,S1733,S1740,S1747",
      "CTD_T4": "T1584,T1591,T1598,T1605,T1612,T1619,T1626,T1615,T1640,T1647,T1654,T1661,T1663,T1675,T1682,T1689,T1696,T1703,T1710,T1717,T1723,T1731,T1738,T1745,T1752",
      "CTD_S5": "T1582,T1589,T1596,T1603,T1610,T1617,T1624,T1613,T1638,T1645,T1652, T1659,T1666,T1673,T1680,T1687,T1694,T1701,T1708,T1715,T1722,T1729,T1736,T1743,T1750",
      "CTD_S7": "S1584,S1591,S1598,S1605,S1612,S1619,S1626,S1615,S1640,S1647,S1654,S1661,S1668,S1675,S1682 S1689,S1696,S1703,S1710,S1717,S1724,S1731,S1738,S1745,S1752"
   }
}

The CTD abbreviations are implemented for Friday night's load.

These changes broke the JaponicusDB update.  There are two modifications annotated for SJAG_02763 but the corresponding configuration was missing.  I've added the config now so it should be OK on Monday morning and the SJAG_02763 page should have two modifications.

If it helps we could also show the residues and positions as a mouse-over for "CTD_S2" etc. on the gene pages.

Would this be useful?

We discussed this on the call - it is useful.

I've added the config now so it should be OK on Monday morning and the SJAG_02763 page should have two modifications.

Fixed!

If it helps we could also show the residues and positions as a mouse-over for "CTD_S2" etc. on the gene pages.

That's done now and will be on the main site in a little while.

nice!

The other thing we will be able to do this this detail is to display the rpb1-CTD modifications here:

This is mostly done.  I'm just trying to track down a bug: the mouse-over below is missing "removed by ssu72" in the screenshot below.
I hope to have it fixed and committed in time for tonight's load.
https://desktop.kmr.nz/gene_protein_features/SPBC28F2.12

Fixed!

Turns out there was a bug in the modification display code that's been there since I first implemented it.  Some of the extension details are missing from the current feature viewer.  Here's an example:

Tomorrow it will look like this:

While testing I noticed that igo1 / SPAC10F6.16 has this extension on one of the modifications:
modified residue S64 level fluctuates during mitotic cell cycle
Should we add "level fluctuates during" to the list of extensions types that are shown in the mouse-over?  The current list of types is: "added_during", "added_by", "affected_by", "removed_by"

This is great!
How many times have we used "fluctuates during". it's a bit "woolly"

How many times have we used "fluctuates during". it's a bit "woolly"

338 times, but only in three publications:

PMID:19279143  (only once)
PMID:29079657  (3 times)
PMID:24763107  (Carpy et al. 334 times - slow to load because it's a large page)

I removed the ones from
PMID:19279143 (only once)
PMID:29079657 (3 times)
I think we should disable this relationship in Canto. It isn't necessary. Could you remove it from the config?

Could you remove it from the config?

Done for the morning.

I think this is done now?

OK! great!


Using Cavy with multiple entry points

Hey there, we have a project we are really interesting in integrating Cavy with.
Our app has four entry points:
customerIndex.ios.js
customerIndex.android.js
proIndex.ios.js
proIndex.android.js
So my thoughts are to have a .test.js for each of these... e.g.
customerIndex.ios.test.js
However I can't figure out how to specify which one to run with Cavy. It wants index.test.js.
It also does some renaming of the files so the Cavy'd file becomes the entry point for the build variant, which I understand but I could probably manually set this up in Xcode and Android Studio as test build variants.
Can I use Cavy entirely without the CLI and manually set up the test files?
Thank you! Really excited to give this a try

Hi there @nabilfreeman, thanks for your interest in using Cavy!
As you've probably noticed, cavy-cli just uses the react-native-cli under the hood, so if your set up doesn't allow you to boot the app using react-native run-ios --some-other-arguments then it's going to be tricky to use cavy-cli to run your tests.
However, you have some options:
Cavy without cavy-cli
You can run Cavy tests without cavy-cli. If you set up your four test files as you described, then booting your app from any one of these entry points will automatically run the tests and output the results to the console.
Cavy with cavy-cli plus command line arguments
The first use-case we had internally for cavy-cli was running our Cavy test suite in a Continuous Integration environment - specifically, we needed a way to signal the passing / failure of tests to CircleCI. For this case, Cavy on its own is not quite enough.
As you said, cavy-cli does look for an index.test.js file when attempting to boot the app, however, if it doesn't find one, it continues and attempts to boot the app by running react-native run-ios. I'm not familiar with building RN apps with multiple entry points, but you can pass in any react-native-cli options that are valid for react-native run-ios to cavy run-ios- so this may be helpful for you.
Custom reporter
If you can't boot your app from the correct entry point using react-native-cli, then you'll have to do something custom to use Cavy. We're actually working on a native reporter for Cavy as an alternative to cavy-cli, which fires a Native Module callback when tests are finished. This means you'll be able to wire Cavy into your native test runner, such as XCTest. If you're using Xcode and Android Studio to boot and test your app, then this could be of use to you! I'll keep you posted on progress 👌
Hope this helps somewhat! I'll be really interested to hear how you get on, so please keep in touch. We're always thinking about ways to improve Cavy and appreciate any suggestions :)

I realise it won't solve your particular problem, but I'm going to add support for index.android.test.js and index.ios.test.js to the backlog as I'm sure a few RN projects out there have this setup!

Hi @nabilfreeman.
Just letting you know, we've now published our first custom reporter for Cavy, Cavy Native Reporter, along with the ability to write your own reported function to pass into Cavy.
Have a look at the README for Cavy Native Reporter](https://github.com/pixielabs/cavy-native-reporter) and check out the updated docs for custom reporters in Cavy itself - might be useful!


Update how-to-tsi-gen2-migration.md

Learn Build status updates of commit 0bcf5fe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/time-series-insights/how-to-tsi-gen2-migration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@tedvilutis,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

Due to the upcoming Ignite conference, all merging and publishing is on hold until the morning of October 12.
This PR is ready for merge on 10/12.
#label: "event-triaged-to-10AM"


chore: bump axe core

:tada: This PR is included in version 1.477.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


use filepath Join instead of / while constructing kubeconfig path

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
/kind bug

What does this PR do / why we need it:
We were using os specific method to join path for kubeconfig, using filepath.Join instead. Also we are not ignoring error from homedir function anymore also.
Which issue(s) this PR fixes:
No issue
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

[x] Update changelog

[X] I have read the test guidelines

How to test changes / Special notes to the reviewer:
Tests should pass

/lgtm

/retest

/lgtm


Add option to use random words and colors instead of random string as code

Coverage increased (+1.8%) to 90.654% when pulling 88e70a8bca856deafee645d0ba6dde617b2ad9a8 on random-words into 93d99ded15ae9e286a4544ed160ec267b02a14b1 on master.


Fix SingleSelect issues

The selection isn't getting reflected in the UI.
Please refer BUG-879557 for more details.

Have just resolved the conflicts.


Convert module to HQRM - Fixes #30

This PR changes the module to HQRM standards and adds other things like CodeCov.IO support.

Fixes #29
Fixes #30

The full details are:

Added resource helper module.
Changed resource file names to include MSFT_*.
Added MSFT_ to MOF file classname
Change examples to meet HQRM standards and optin to Example validation
tests.
Replaced examples in README.MD to links to Example files.
Added the VS Code PowerShell extension formatting settings that cause PowerShell
files to be formatted as per the DSC Resource kit style guidelines.
Opted into Common Tests 'Validate Module Files' and 'Validate Script Files'.
Converted files with UTF8 with BOM over to UTF8.
Updated Year to 2017 in License and Manifest.
Added .github support files:

CONTRIBUTING.md
ISSUE_TEMPLATE.md
PULL_REQUEST_TEMPLATE.md

Resolved all PSScriptAnalyzer warnings and style guide warnings.

@Johlju - Sorry about the size of this change but it was just a bit easier to do the whole thing in one go. Any chance of a review - there is no rush at all on this as it is just addressing tech debt.
@kwirkykat - I'm not actually a maintainer on this one so won't be able to merge the changes. But feel free to make me the maintainer for this one as it doesn't require a lot of time and I've done most contributions to in anyway over the last 18 months :grin:

This change is

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@1c7f3a0). Click here to learn what that means.
The diff coverage is 100%.

@@         Coverage Diff          @@
##             dev    #31   +/-   ##
====================================
  Coverage       ?   100%
====================================
  Files          ?      1
  Lines          ?     21
  Branches       ?      0
====================================
  Hits           ?     21
  Misses         ?      0
  Partials       ?      0

Impacted Files
Coverage Δ

DSCResources/MSFT_xTimeZone/MSFT_xTimeZone.psm1
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7f3a0...b727016. Read the comment docs.

@PlagueHO Oh man... This is huge 🤣 I probably won't finish the review tonight haha 😉

I stop here, because there is style changes and typos that, after they are fixed, will make it easier to review (hard to read past them without commenting in each file :wink: ).

Reviewed 17 of 36 files at r1.
Review status: 16 of 30 files reviewed at latest revision, 29 unresolved discussions, some commit checks broke.

README.md, line 3 at r1 (raw file):

timezone

time zone? Two words? Throughout where applicable.

README.md, line 4 at r1 (raw file):

resource will use CIM to retrieve the current timezone

Not thru, it also uses Get-TimeZone if present (which maybe in turn uses CIM though). Mention it?
Non-blocking.

README.md, line 5 at r1 (raw file):

The resource will use CIM to retrieve the current timezone and use
.NET reflection to update the timezone if required. If .NET reflection is not
supported on the node (in the case of Nano Server) then tzutil.exe will be used
to set the timezone.

Move this part of the text down to where the actual resource is described as the resource description (under the section at line 39)?

README.md, line 41 at r1 (raw file):

Time Zone

lower case?

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 8 at r1 (raw file):

TimezoneDsc.Common

TimeZoneDsc.Common (upper 'Z')

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 20 at r1 (raw file):

Get-Timezone

Get-TimeZone. Upper 'Z'.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 22 at r1 (raw file):

Timezone

TimeZone (upper 'Z'). Throughout in keys, variables, etc, where applicable (descriptions should be 'time zone').

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 24 at r1 (raw file):

$Timezone

$timeZone. Lower case 't'. Upper case 'Z'. Throughout.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 31 at r1 (raw file):

WIN32_Timezone

Win32_TimeZone

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 46 at r1 (raw file):

timezone

time zone

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 54 at r1 (raw file):

param(

parenthesis on the next row. Throughout.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 60 at r1 (raw file):

Test Expected is same as Current

"Test if the expected value is the same as the current value."

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 90 at r1 (raw file):

Reflection

reflection

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 90 at r1 (raw file):

TimeZone

"time zone."

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 121 at r1 (raw file):

<#
    .SYNOPSIS
        This function exists so that the ::Set method can be mocked by Pester.

Good to know. But what does it do? ;)

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 126 at r1 (raw file):

...NET

"...Net" (lowercase 'et'). Or "...NetFramework" if 'Net' can be ambiguous. Or "...Reflection".

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 136 at r1 (raw file):

    # Add the [TimeZoneHelper.TimeZone] type if it is not defined.
    if (-not ([System.Management.Automation.PSTypeName]'TimeZoneHelper.TimeZone').Type)

Space after the type

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 138 at r1 (raw file):

dotNet

NetFramework or Reflection. See previous comment.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 8 at r1 (raw file):

    The name of the command to test.
#>
function Test-Command

This exist in the file TimeZoneDsc.Common as well. They are different. Change the name on this one? Use only one of them? This is not exported either, so not used?

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 12 at r1 (raw file):

    param
    (
        [String] $Name

Parameter is formatted wrong,

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 24 at r1 (raw file):

function Test-IsNanoServer
{
    if(Test-Command -Name Get-ComputerInfo)

Missing space after if. Throughout.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 28 at r1 (raw file):

        $computerInfo = Get-ComputerInfo

        if("Server" -eq $computerInfo.OsProductType `

Single quotes. Throughout.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 55 at r1 (raw file):

[String]

[System.String]. Throughout.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 65 at r1 (raw file):

    $argumentException = New-Object -TypeName 'ArgumentException' -ArgumentList @( $Message,
        $ArgumentName )

Why is only this single array member on on the next row? Why not both (or none)?.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 70 at r1 (raw file):

        ArgumentList = @( $argumentException, $ArgumentName, 'InvalidArgument', $null )
    }
    $errorRecord = New-Object @newObjectParams

Blank row before this one.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 77 at r1 (raw file):

<#
    .SYNOPSIS
        Creates and throws an invalid operation exception

Rather see full stop ('.') after each sentence. Non-blocking. Throughout.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 118 at r1 (raw file):

        TypeName = 'System.Management.Automation.ErrorRecord'
        ArgumentList = @( $invalidOperationException.ToString(), 'MachineStateIncorrect',
            'InvalidOperation', $null )

Same with this array as before. Move all on separate rows?

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 120 at r1 (raw file):

            'InvalidOperation', $null )
    }
    $errorRecordToThrow = New-Object @newObjectParams

Blank row before this one.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 169 at r1 (raw file):

Export-ModuleMember -Function `

Quoted 4 lines of code…
>     Test-IsNanoServer, `
>     New-InvalidArgumentException, `
>     New-InvalidOperationException, `
>     Get-LocalizedData

Can be done? Get rid of the '` '
Export-ModuleMember -Function @(
    'Test-IsNanoServer'
    'New-InvalidArgumentException'
    'New-InvalidOperationException'
    'Get-LocalizedData'
)

Non-blocking.

Comments from Reviewable

@PlagueHO For some reasone my comments in Reviewable did not get published here. Luckily they are still in Reviewable. Can you verify that you see them in Reviewable? Maybe a lag, maybe they get here eventually.

Phew. Now they was published here. 😄

Review status: 11 of 30 files reviewed at latest revision, 29 unresolved discussions.

README.md, line 3 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

timezone

time zone? Two words? Throughout where applicable.

Done.

README.md, line 4 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

resource will use CIM to retrieve the current timezone

Not thru, it also uses Get-TimeZone if present (which maybe in turn uses CIM though). Mention it?
Non-blocking.

Done.

README.md, line 5 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

The resource will use CIM to retrieve the current timezone and use
.NET reflection to update the timezone if required. If .NET reflection is not
supported on the node (in the case of Nano Server) then tzutil.exe will be used
to set the timezone.

Move this part of the text down to where the actual resource is described as the resource description (under the section at line 39)?

Done.

README.md, line 41 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Time Zone

lower case?

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 8 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

TimezoneDsc.Common

TimeZoneDsc.Common (upper 'Z')

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 20 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Get-Timezone

Get-TimeZone. Upper 'Z'.

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 22 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Timezone

TimeZone (upper 'Z'). Throughout in keys, variables, etc, where applicable (descriptions should be 'time zone').

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 24 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

$Timezone

$timeZone. Lower case 't'. Upper case 'Z'. Throughout.

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 31 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

WIN32_Timezone

Win32_TimeZone

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 46 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

timezone

time zone

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 54 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

param(

parenthesis on the next row. Throughout.

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 60 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Test Expected is same as Current

"Test if the expected value is the same as the current value."

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 90 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Reflection

reflection

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 90 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

TimeZone

"time zone."

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 121 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Good to know. But what does it do? ;)

Haha good catch : ) Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 126 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

...NET

"...Net" (lowercase 'et'). Or "...NetFramework" if 'Net' can be ambiguous. Or "...Reflection".

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 136 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Space after the type

Done.

Modules/TimeZoneDsc.Common/TimeZoneDsc.Common.psm1, line 138 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

dotNet

NetFramework or Reflection. See previous comment.

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 8 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This exist in the file TimeZoneDsc.Common as well. They are different. Change the name on this one? Use only one of them? This is not exported either, so not used?

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 12 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Parameter is formatted wrong,

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 24 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Missing space after if. Throughout.

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 28 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Single quotes. Throughout.

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 55 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

[String]

[System.String]. Throughout.

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 65 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Why is only this single array member on on the next row? Why not both (or none)?.

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 70 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Blank row before this one.

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 77 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Rather see full stop ('.') after each sentence. Non-blocking. Throughout.

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 118 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Same with this array as before. Move all on separate rows?

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 120 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Blank row before this one.

Done.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 169 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Export-ModuleMember -Function     Test-IsNanoServer,
New-InvalidArgumentException,     New-InvalidOperationException,
Get-LocalizedData

Can be done? Get rid of the '` '
Export-ModuleMember -Function @(
    'Test-IsNanoServer'
    'New-InvalidArgumentException'
    'New-InvalidOperationException'
    'Get-LocalizedData'
)

Non-blocking.

Done.

Comments from Reviewable

Thanks @johlju ! I really appreciate all your work on this! I have updated everything now I think.

Review status: 11 of 30 files reviewed at latest revision, 26 unresolved discussions.

Comments from Reviewable

No problem. As always, it's fun. :smile:
Just acknowledge the changes you made and review one or more files. I will do the rest (4 files) tonight or during the weekend.

Reviewed 13 of 36 files at r1, 7 of 8 files at r2.
Review status: 26 of 30 files reviewed at latest revision, 16 unresolved discussions, some commit checks broke.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 100 at r2 (raw file):

        TypeName     = 'System.Management.Automation.ErrorRecord'
        ArgumentList = @( $invalidOperationException.ToString(), 'MachineStateIncorrect',
            'InvalidOperation', $null )

Could we change so each of these array members is on a separate row?

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 21 at r2 (raw file):

Current Timezone

Maybe  'current time zone'?

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 28 at r2 (raw file):

should be

Should Be - Upper 'S' and 'B'. Throughout.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 55 at r2 (raw file):

{ param () }

Could we change this so it follows style guideline?
function Get-TimeZone
{
    param
    (
    )
}

Can we remove param maybe?

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 58 at r2 (raw file):

@{ StandardName = 'Pacific Standard Time' }

Hash tables keys should be on separate rows.
@{
    StandardName = 'Pacific Standard Time'
}

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 76 at r2 (raw file):

True

Maybe $true?

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 82 at r2 (raw file):

False

Maybe $false?

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 93 at r2 (raw file):

$Global

Are we writing these with upper 'G' or with upper 'S' for $Script? Feels to me that we maybe should write these in all lower-case? Non-blocking.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 135 at r2 (raw file):

Mock -CommandName Get-Command -ParameterFilter { $Name -eq 'Set-TimeZone' } -MockWith { 'Set-TimeZone' }

This is non-blocking. Probably my own preference. So please ignore if you'd like.
We could make this more readable by doing this?
Mock -CommandName Get-Command -ParameterFilter {
    $Name -eq 'Set-TimeZone'
} -MockWith {
    'Set-TimeZone'
}

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 146 at r2 (raw file):

}  |

Please remove one extra space here.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 166 at r2 (raw file):

'Should not throw exception'

Please revise description. Test returns $true.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 179 at r2 (raw file):

                        $Module -eq 'Microsoft.PowerShell.Management'
                    } `
                    -Exactly -Times 1

This can be moved up to the previous row and so we can remove the backtick. Throughout.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 189 at r2 (raw file):

-MockWith { }

This should not be necessary when not mocking any code?

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 191 at r2 (raw file):

'Should not throw exception'

Please revise description. Test returns $false.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 201 at r2 (raw file):

                    $Name -eq 'Get-TimeZone' -and `
                    $Module -eq 'Microsoft.PowerShell.Management'

Since we splitting the row here, could we add -and first on the second line to make it more readable? Throughout if applicable.

Comments from Reviewable

All files has gone through initial review :smile: No big things as usual. Awesome work!

Reviewed 4 of 36 files at r1, 1 of 8 files at r2.
Review status: all files reviewed at latest revision, 27 unresolved discussions, some commit checks broke.

Tests/Integration/MSFT_xTimeZone.Integration.Tests.ps1, line 50 at r2 (raw file):

                    -OutputPath $TestDrive `
                    -ConfigurationData $configData
                Start-DscConfiguration `

Could we add a blank line before this row?

Tests/Integration/MSFT_xTimeZone.Integration.Tests.ps1, line 57 at r2 (raw file):

Should not throw

Maybve Should Not Throw? Throughout.

Tests/Integration/MSFT_xTimeZone.Integration.Tests.ps1, line 65 at r2 (raw file):

'Should have set the resource and all the parameters should match'

Hm.. It doesn't actually set the resource, but the configuration... So maybe 'Should have set the configuration and all the parameters should match'?
Maybe we should add a test like this to the integration test template? Might help new contributors.

Tests/TestHelpers/CommonTestHelper.psm1, line 18 at r2 (raw file):

[String]

[System.String]. Throughout.
Non-blocking, since I guess this is the way this file looks in several resources?

Tests/TestHelpers/CommonTestHelper.psm1, line 28 at r2 (raw file):

    $argumentException = New-Object -TypeName 'ArgumentException' -ArgumentList @( $Message,
        $ArgumentName )

Could we move this up to the previous row? Non-blocking.

Tests/TestHelpers/CommonTestHelper.psm1, line 29 at r2 (raw file):

    $argumentException = New-Object -TypeName 'ArgumentException' -ArgumentList @( $Message,
        $ArgumentName )
    $newObjectParams = @{

Blank row before this one. Non-blocking.

Tests/TestHelpers/CommonTestHelper.psm1, line 33 at r2 (raw file):

        ArgumentList = @( $argumentException, $ArgumentName, 'InvalidArgument', $null )
    }
    return New-Object @newObjectParams

Blank row before this one. Non-blocking.

Tests/TestHelpers/CommonTestHelper.psm1, line 81 at r2 (raw file):

            'InvalidOperation', $null )
    }
    return New-Object @newObjectParams

Blank row before this one. Non-blocking.

Tests/TestHelpers/CommonTestHelper.psm1, line 85 at r2 (raw file):

Export-ModuleMember -Function `
    Get-InvalidArgumentRecord, `

Could make an array of these as well, to get rid of the back tick. Non-blocking.

Tests/Unit/MSFT_xTimeZone.Tests.ps1, line 29 at r2 (raw file):

'Schema'

Please see if there is a better description for this.

Tests/Unit/MSFT_xTimeZone.Tests.ps1, line 32 at r2 (raw file):

Should be $true

Should Be $true

Tests/Unit/MSFT_xTimeZone.Tests.ps1, line 33 at r2 (raw file):

$timeZoneResource.Properties.Where{ $_.Name -eq 'IsSingleInstance' }.Values | Should be 'Yes'

Could we split this like this to improve readability? If so, throughout.
$timeZoneResource.Properties.Where{
    $_.Name -eq 'IsSingleInstance'
}.Values | Should be 'Yes'

Comments from Reviewable

Thanks @Jojlju ! I've fixed everything... I think :grin:

Review status: 24 of 30 files reviewed at latest revision, 28 unresolved discussions.

Modules/TimeZoneDsc.ResourceHelper/TimeZoneDsc.ResourceHelper.psm1, line 100 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could we change so each of these array members is on a separate row?

Done.

Tests/Integration/MSFT_xTimeZone.Integration.Tests.ps1, line 50 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could we add a blank line before this row?

Done.

Tests/Integration/MSFT_xTimeZone.Integration.Tests.ps1, line 57 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Should not throw

Maybve Should Not Throw? Throughout.

Done.

Tests/Integration/MSFT_xTimeZone.Integration.Tests.ps1, line 65 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

'Should have set the resource and all the parameters should match'

Hm.. It doesn't actually set the resource, but the configuration... So maybe 'Should have set the configuration and all the parameters should match'?
Maybe we should add a test like this to the integration test template? Might help new contributors.

Good thoughts about adding to the test template.
Done.

Tests/TestHelpers/CommonTestHelper.psm1, line 18 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

[String]

[System.String]. Throughout.
Non-blocking, since I guess this is the way this file looks in several resources?

Done.

Tests/TestHelpers/CommonTestHelper.psm1, line 28 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could we move this up to the previous row? Non-blocking.

Done.

Tests/TestHelpers/CommonTestHelper.psm1, line 29 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Blank row before this one. Non-blocking.

Done.

Tests/TestHelpers/CommonTestHelper.psm1, line 33 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Blank row before this one. Non-blocking.

Done.

Tests/TestHelpers/CommonTestHelper.psm1, line 81 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Blank row before this one. Non-blocking.

Done.

Tests/TestHelpers/CommonTestHelper.psm1, line 85 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could make an array of these as well, to get rid of the back tick. Non-blocking.

Done.

Tests/Unit/MSFT_xTimeZone.Tests.ps1, line 29 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

'Schema'

Please see if there is a better description for this.

I couldn't come up with too much more unfortunately as this describe is really just about validating the MOF meets the requirements for a single instance resource. But I've done my best.

Tests/Unit/MSFT_xTimeZone.Tests.ps1, line 32 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Should be $true

Should Be $true

Done.

Tests/Unit/MSFT_xTimeZone.Tests.ps1, line 33 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

$timeZoneResource.Properties.Where{ $_.Name -eq 'IsSingleInstance' }.Values | Should be 'Yes'

Could we split this like this to improve readability? If so, throughout.
$timeZoneResource.Properties.Where{
    $_.Name -eq 'IsSingleInstance'
}.Values | Should be 'Yes'

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 21 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Current Timezone

Maybe  'current time zone'?

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 28 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

should be

Should Be - Upper 'S' and 'B'. Throughout.

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 55 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

{ param () }

Could we change this so it follows style guideline?
function Get-TimeZone
{
    param
    (
    )
}

Can we remove param maybe?

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 58 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

@{ StandardName = 'Pacific Standard Time' }

Hash tables keys should be on separate rows.
@{
    StandardName = 'Pacific Standard Time'
}

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 76 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

True

Maybe $true?

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 82 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

False

Maybe $false?

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 93 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

$Global

Are we writing these with upper 'G' or with upper 'S' for $Script? Feels to me that we maybe should write these in all lower-case? Non-blocking.

Done. I did a global search/replace and fixed all $Global: and $Script:

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 120 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 135 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Mock -CommandName Get-Command -ParameterFilter { $Name -eq 'Set-TimeZone' } -MockWith { 'Set-TimeZone' }

This is non-blocking. Probably my own preference. So please ignore if you'd like.
We could make this more readable by doing this?
Mock -CommandName Get-Command -ParameterFilter {
    $Name -eq 'Set-TimeZone'
} -MockWith {
    'Set-TimeZone'
}

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 146 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

}  |

Please remove one extra space here.

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 166 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

'Should not throw exception'

Please revise description. Test returns $true.

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 179 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This can be moved up to the previous row and so we can remove the backtick. Throughout.

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 189 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

-MockWith { }

This should not be necessary when not mocking any code?

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 191 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

'Should not throw exception'

Please revise description. Test returns $false.

Done.

Tests/Unit/TimeZoneDsc.Common.tests.ps1, line 201 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

                    $Name -eq 'Get-TimeZone' -and `
                    $Module -eq 'Microsoft.PowerShell.Management'

Since we splitting the row here, could we add -and first on the second line to make it more readable? Throughout if applicable.

Done.
Note: I've used Autoformatting which has indented the second line unfortunately.

Comments from Reviewable

Reviewed 2 of 36 files at r1, 6 of 6 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

@PlagueHO Awesome work on this one!

Thanks @Jojlju  - really appreciate the great review on this one.
@kwirkykat - I'm not a maintainer of this repo. You can make me a maintainer of this one if you like? Can't see there being much new work on it (except tech debt stuff like this).
Either way, would you mind merging this for me if you have a chance? Thank you!

@PlagueHO Made you a maintainer 👍 Looks good. Thanks!

Thanks @kwirkykat !


[closebrackets] Removal of matching brackets is inconsistent.

At https://codemirror.net/demo/closebrackets.html enter the following:
f(g())

Place the cursor to the left of the last parenthesis as shown below (| = cursor) :
f(g()|)

Press backspace once.
f(g(|)

Press backspace again.
f(g|

It seems inconsistent that the deletion of a close bracket at step 3 does not delete the opening bracket, but that the deletion of an open bracket at step 4 does delete the closing bracket.

Sublime Text and VS Code behave the same way here. Pairwise deletion is typically only defined when deleting the opening bracket.


[Bug] Improving Footer Text Visibility with CSS: A Guide to Effective Color Contrast

Is there an existing issue for this?

[X] I have searched the existing issues

Bug Description?
The footer text on the website has low contrast against the background color, making it difficult to read. This impacts readability, especially for users with visual impairments or those viewing the site in low-light conditions.
Comment
The footer text color should be adjusted to increase contrast against the background. Please consider selecting a darker text color or a lighter background shade that meets accessibility guidelines (WCAG 2.1) for contrast. This will improve readability and enhance the overall user experience.
Add Screenshots

What browsers are you seeing the problem on?
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue (Optional)
[X] I'm willing to provide further clarification or assistance if needed.

/assign


Add Microsoft Research Sequential Question Answering (SQA) Dataset

For more information: https://msropendata.com/datasets/b25190ed-0f59-47b1-9211-5962858142c2

I proposed something a few weeks ago in #898 (un-merged) but I think that the way that @mattbui added the dataset in the present PR is smarter and simpler should replace my PR #898.
(Narrator voice: And it was around that time that Thomas realized that the community was now a lot smarter than him and he should hand-over the library he had started with @lhoestq to the community and stop pretending he knew everything about it.)


Checkbox - Hide SVGs from screen readers

CENG_3297
Docs: https://react-magma.cengage.com/version/4.3.0/api/checkboxes/
Success Criteria: https://www.w3.org/WAI/WCAG21/Understanding/non-text-content
Within the checkbox component, SVGs are used for a custom checkbox rather than the browser default that are not named and are not hidden from assistive technology. This could confuse users who reach these elements without knowing what they are for.
Add aria-hidden="true" to the span element that wraps the SVGs within the checkbox component.

I tested this on Storybook and Docs, in Chrome on Mac. Everything looks good.


Sync stage branch

Purpose

Sync stage branch

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.13 out of 17 committers have signed the CLA.:white_check_mark: ramithaYO:white_check_mark: rdhananjaya:white_check_mark: keizer619:white_check_mark: KavinduZoysa:white_check_mark: rasika:white_check_mark: ldclakmal:white_check_mark: MaryamZi:white_check_mark: warunalakshitha:white_check_mark: shafreenAnfar:white_check_mark: aashikam:white_check_mark: pubudu91:white_check_mark: Maninda:white_check_mark: BuddhiWathsala:x: grainier:x: irshadnilam:x: ThisaruGuruge:x: nadeeshaanYou have signed the CLA already but the status is still pending? Let us recheck it.


[TextField] maxLength not working in android device browsers

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
for text field with multiline attribute and rows attribute maxLength is not working in android device browsers. it is working in desktop browsers
Current behavior 😯
Not considering the maxLength passed in inputProps
Expected behavior 🤔
It should limit the number of characters to given maxLength limit
Context 🔦
I need to limit the user input to some fixed number of characters, because of this issue it is not happening in mobiles
Your environment 🌎

npx @mui/4.12
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

@mnajdova do you happen to have an Android device to verify it?

Strange, this should work, per https://github.com/mui/material-ui/issues/12913#issuecomment-522364716 and https://caniuse.com/maxlength.

Android version 11
Material UI version 4.x x
Browser chrome 106.0.5249.xxx

@shivak-cbre Have you tried using native textarea with the maxlength attribute instead? It doesn't feel like a Material UI issue.

No, i haven't tried . I will check
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Michał Dudak @.>
Sent: Thursday, November 3, 2022 3:13:46 PM
To: mui/material-ui @.>
Cc: Kongara, Shivakrishna @ Global D&T Contractor @.>; Mention @.>
Subject: Re: [mui/material-ui] [TextField] maxLength not working in android device browsers (Issue #34903)
@shivak-cbrehttps://urldefense.com/v3/__https://github.com/shivak-cbre__;!!GnpIGg!cDsP1BkbaFVUhZ53npNteMLkKpw0amCC4DTRumV2rQtSX0835cvG6HpUWKTn6Zw_q5QwlACVxaeQg_QkkulR0V_hkRfxoqU$ Have you tried using native textarea with the maxlength attribute instead? It doesn't feel like a Material UI issue.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/mui/material-ui/issues/34903*issuecomment-1301851195__;Iw!!GnpIGg!cDsP1BkbaFVUhZ53npNteMLkKpw0amCC4DTRumV2rQtSX0835cvG6HpUWKTn6Zw_q5QwlACVxaeQg_QkkulR0V_hEjSfRMk$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ATVUWZPGQXSOXQHJDTC5PH3WGOCNFANCNFSM6AAAAAARPXBE4M__;!!GnpIGg!cDsP1BkbaFVUhZ53npNteMLkKpw0amCC4DTRumV2rQtSX0835cvG6HpUWKTn6Zw_q5QwlACVxaeQg_QkkulR0V_hamnpRmg$.
You are receiving this because you were mentioned.Message ID: @.***>
Details about the personal data CBRE collects and why, as well as your data privacy rights under applicable law, are available at CBRE – Privacy Policy.https://www.cbre.com/about/privacy-policy/policy-picker

@shivak-cbre Any update? Or should we close this issue?

@shivak-cbre Do you have a reproduction we can look into?

Yes, Please open the below link in android mobile chrome browser
https://codesandbox.io/embed/material-ui-text-field-character-limit-n4t82?codemirror=1
From: Olivier Tassinari @.>
Sent: 08 November 2022 15:56
To: mui/material-ui @.>
Cc: Kongara, Shivakrishna @ Global D&T Contractor @.>; Mention @.>
Subject: Re: [mui/material-ui] [TextField] maxLength not working in android device browsers (Issue #34903)
@shivak-cbrehttps://urldefense.com/v3/__https:/github.com/shivak-cbre__;!!GnpIGg!fFr5AqH-oAcG8nlVKtMXeOt2lGxPjM6zkdmSCAcrg75s3MfcdpippXQzW_rLZy_UW6Y22Sn0VUtf3oN5i9sj_bu7eVDEaKg$ Do you have a reproduction we can look into?
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/mui/material-ui/issues/34903*issuecomment-1306980335__;Iw!!GnpIGg!fFr5AqH-oAcG8nlVKtMXeOt2lGxPjM6zkdmSCAcrg75s3MfcdpippXQzW_rLZy_UW6Y22Sn0VUtf3oN5i9sj_bu7IKxuE6c$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ATVUWZJJV2ULFRIQCS6QNJDWHITENANCNFSM6AAAAAARPXBE4M__;!!GnpIGg!fFr5AqH-oAcG8nlVKtMXeOt2lGxPjM6zkdmSCAcrg75s3MfcdpippXQzW_rLZy_UW6Y22Sn0VUtf3oN5i9sj_bu7uCObVZc$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>Details about the personal data CBRE collects and why, as well as your data privacy rights under applicable law, are available at CBRE – Privacy Policy.https://www.cbre.com/about/privacy-policy/policy-picker

The native <input> is also affected by this: https://codesandbox.io/s/material-ui-text-field-character-limit-forked-dkfx1b?file=/src/index.js, so it's not a bug in Material UI.


fix: synchronize provider registration

This PR

synchronizes modifications to the global provider map

Notes
This likely does not do enough to really make it "threadsafe". It's good enough for the obvious case i stumbled across and should be fine for MRI support.
Follow-up Tasks
Define whether at this stage we want to support "truly parallel" ruby implementations.

One thing with ruby (actually only the MRI) is that it's a bit hard to see concurrency issues.

Yes, this is primarily why I don't have experience with it; I just haven't encountered that many Ruby projects that use concurrency. I do think it's worthwhile to start thinking about/working on this. I think tackling concurrency in the context of a multi-threaded app (i.e. puma or falcon) in MRI is a good starting place versus targeting support for an alternative Ruby implementation would be cool. Maybe we add an example puma or falcon app so we can start trying to observe concurrency issues is a good start? What're your thoughts @mschoenlaub ? I'm going to start a new issue and move this conversation over there, and go ahead and merge this in.

https://github.com/open-feature/ruby-sdk/issues/137


Create a better README

Create a better README
Create a better readme with steps on how to install.

This is completed and Thanks to @Nasir-kas we have a better documentation here: https://github.com/srbhr/Resume-Matcher-Docs


VSCode is killing my X session while working on Go stuffs

VSCode Version: Latest as on Arch AUR
OS Version: Up to date version of Antergos Linux (basically Arch Linux)

Steps to Reproduce:

Open a folder with golang code, open up a couple of panes with the code.
No consistent pattern has been found yet causing this, though sometimes relating to saving files but not always, and being that it's killing X, other factors may be at play here:

a) In the background I am running a two miners (Claymore and DSTM) crunching equihash solutions that may have some role in this, as my suspicion it is causing some conflict with the accelerated rendering component of Electron. I have had other issues at times involving Chrome suddenly dying which could be the very same code going ping but not propagating the problem down to the X server.
b) I also have a pair of AMD cards, but only with the OpenCL installed but not amdgpu-pro full driver
I personally suspect this is an issue with the bundled version of Electron, and I also have plain Electron installed as a package, and I run Messenger, Discord, an Electron based cryptocurrency wallet and Chrome at the same time most of the time, but the most frequent time this happens is while I am editing code (using golang extensions), so I suspect very much the version of Electron, which I suspect is a different version than the ones the rest of my apps are using.

Does this issue occur when all extensions are disabled?: Yes/No
I have not tested this because I just want to be able to not have to restart ssh sessions and web browser or the unnerving sudden blanking of the screen, so I am going to start using Atom instead.

I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

Yes, in fact disabling the extensions caused it to occur immediately. It may be something to do with Electron and Nvidia driver...
starting it with --disable-gpu solved the problem. It may well be related to the equihash solver running in the background as well. However, I am trying a downgrade to Nvidia driver 387, I will close the issue if this is the resolution.

I can confirm that the issue is occurring also with Atom, and that it appears that this was the source of the issue. Closing the issue now.


Docker-compse: failed to solve: rpc error:

Describe the bug
When setting up the service on a windows machine, Docker won't find a Dockerfile in the temp directory
[+] Running 0/1
 - backend Error                                                                                2.1s
[+] Building 0.0s (2/2) FINISHED
 => [internal] load build definition from Dockerfile                                                               0.0s
 => => transferring dockerfile: 2B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount887106246/Dockerfile: no such file or directory

Steps to reproduce the issue
Install JDK 11, Maven and Docker on a Windows machine. Follow the installation process.
Error occurs on docker-compose up

Technical details

Windows 10 Home (19042.1415)/Windows 11 Pro (22000.376)
Docker Engine v20.10.11
jdk 11.0.2
apache-maven 3.8.4

Additional context
Tested on two different Windows machines

same here.


Make sure net/api/client.Subscribe loop ends gracefully when client is closing

When client.Close is called, the gRPC connection gets closed, and the stream.Recv() call here returns a gRPC internal error ErrConnClosing, which is not considered a grace close, hence causes a log.Fatalf().

2021/05/14 13:07:05 error in subscription stream: rpc error: code = Unavailable desc = transport is closing

https://github.com/textileio/go-threads/blob/5d09258e40a4e008cab2d4de9bbeb6ffd5357054/net/api/client/client.go#L297-L307
This shouldn't be considered a fatal error, but maybe more importantly, provide a way to signal the loop to return immediately?

could we check errors.Is(err, ErrConnClosing) and just bail when true?

Nope, ErrConnClosing is defined in an internal package so we don't have access. Didn't check if the error wrapper can be recognizable though. Anyway it should be low priority since it only happens when closing down.

Cool, I thought that since it was capitalized it was exported. Anyway, sgtm!


Catalog should have feature to export the current theme custom properties

The catalog has theming, but there's no good way to currently export the styles / current custom properties without opening dev tools

Haven't you fixed the problem @e111077 ?

Correct!


qa: Improve methodology documentation

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

Superseded by #878


travis build fails with ModuleNotFoundError on freshly created repository

I am not sure whether this should be an issue here (style-guides) or rather on the stsci-package-template:
I followed the steps described at https://github.com/spacetelescope/style-guides/blob/master/guides/python-package.md for creating a new package/repo (https://github.com/spacetelescope/pystortion)
The travis build fails (https://travis-ci.com/spacetelescope/pystortion/builds/91425159) with ModuleNotFoundError: No module named 'astropy_helpers'
Did I make a mistake in the process or is there an oversight in the guide or template?

Which template did you use? There is a flavor with astropy-helpers and one without.

I am not sure. Below is the log of events:
(fpy35) nereus:~ jsahlmann$ cookiecutter https://github.com/spacetelescope/stsci-package-template --checkout stsci-cookiecutter
package_name [packagename]: pystortion
module_name [pystortion]: pystortion
short_description [pystortion]: Support for distortion measurements in astronomical imagers.
long_description []: tbw
author_name [Space Telescope Science Institute]: Johannes Sahlmann STScI/AURA
author_email<EMAIL_ADDRESS>
Select license:
1 - Aura
2 - BSD 3-Clause
3 - GNU GPL v3+
4 - Apache Software Licence 2.0
5 - BSD 2-Clause
6 - Other
Choose from 1, 2, 3, 4, 5, 6 (1, 2, 3, 4, 5, 6) [1]: 1
project_url [http://stsci.edu]:
project_version [0.0.dev]: 0.01
include_example_code [y]:
include_example_cython_code [n]: n
include_cextern_folder [n]: n
edit_on_github_extension [False]:
github_project [spacetelescope/stsci-package-template]: spacetelescope/pystortion
use_travis_ci [y]:
use_appveyor_ci [n]:
use_read_the_docs [y]:
sphinx_theme [stsci_rtd_theme]:
initialize_git_repo [y]: n
Select minimum_python_version:
1 - 3.7
2 - 3.6
3 - 3.5
Choose from 1, 2, 3 (1, 2, 3) [1]: 3
astropy_helpers_version [v3.0.2]:

@sosey or @stscicrawford ?

p.s. Your link is broken. I can't see the actual error.

Strange, it works for me.
Maybe this one is better? https://travis-ci.com/spacetelescope/pystortion/

I see a fallen cone picture with "No builds for this repository" message. Perhaps you can click on "raw log" of the failed job, download the text, and attach it here?

Clicking on "raw log" leads to a page that displays
{
  "@type": "error",
  "error_type": "not_found",
  "error_message": "log not found (or insufficient access)",
  "resource_type": "log"
}

I attached a screenshot instead.

It should have astropy_helpers as a submodule and when I look at the directory here: https://github.com/spacetelescope/pystortion, it appears to be missing.
In the original directory that you created, can you let me know the contents of it and also the output from running git log in the directory for the new repository?
I also wasn't seeing the same things as @pllim up until a few seconds ago, and now, I can start to see some of the build information.

There is indeed no astropy_helpers submodule in my package. To be sure that I did not accidentally delete it, I repeated the package generation:
(fpy35) nereus:~ jsahlmann$ cookiecutter https://github.com/spacetelescope/stsci-package-template --checkout stsci-cookiecutter
You've downloaded /Users/jsahlmann/.cookiecutters/stsci-package-template before. Is it okay to delete and re-download it? [yes]:
package_name [packagename]: trial
module_name [trial]:
short_description [trial]: testing
long_description []: more testing
author_name [Space Telescope Science Institute]:
author_email<EMAIL_ADDRESS>
Select license:
1 - Aura
2 - BSD 3-Clause
3 - GNU GPL v3+
4 - Apache Software Licence 2.0
5 - BSD 2-Clause
6 - Other
Choose from 1, 2, 3, 4, 5, 6 (1, 2, 3, 4, 5, 6) [1]: 1
project_url [http://stsci.edu]:
project_version [0.0.dev]: 0.0.1
include_example_code [y]:
include_example_cython_code [n]: n
include_cextern_folder [n]:
edit_on_github_extension [False]:
github_project [spacetelescope/stsci-package-template]: spacetelescope/trial
use_travis_ci [y]:
use_appveyor_ci [n]:
use_read_the_docs [y]:
sphinx_theme [stsci_rtd_theme]:
initialize_git_repo [y]: n
Select minimum_python_version:
1 - 3.7
2 - 3.6
3 - 3.5
Choose from 1, 2, 3 (1, 2, 3) [1]: 3
astropy_helpers_version [v3.0.2]:

The resulting directory structure can be seen in the attached screenshot. There is no astropy_helpers submodule.

Okay, I can reproduce it.   So you have two options here:

If you want to have astropy_helpers installed (as we recommend), then you do need to have the option selected as 'y' for 'initialize_git_repo'.  It looks like if it isn't, then the astropy_helpers won't be installed.   There probably should be a warning if it doesn't occur.

If you'd not like to run the cookie cutters again, you can initialize astropy_helpers with the following command in your repository:
git submodule add https://github.com/astropy/astropy-helpers.git

Then push that to your repository on github and it should then work.
I would have also suggested using the default value for the version as well with the .dev in it.  With astropy_helpers, it will automatically create a version number based on the git hashes.

thanks @stscicrawford . I got it to work with option (2) but had to additionally copy an ah_bootstrap.py file into the top-level directory.
I agree that raising a warning when 'initialize_git_repo' is set to 'n' would be very useful.


Ensure tuple keys are used throughout in plotting

Good to make this consistent and tests have passed. Merging.


weather not working, openweathermap.org

i have checked the location and my api key over and over and and he just gets confused

Banwell, North Somerset, England, United Kingdom
this is how i've formatted it. is this correct?

I got it working you have to drop the England