[BUG] : SQL connection pool issue when using the MSI token for SQL generated with Azure.Identity

Library name and version
Azure.Identity 1.5.0
Describe the bug
We migrated our solution from ADAL to MSAL , and in our code we were using Microsoft.Azure.Services.AppAuthentication which was used to get the MSI token and that token was used by SQL (entity framework core) to authenticate. As this Microsoft.Azure.Services.AppAuthentication package has a dependency on ADAL we have replaced it with Azure.Identity 1.5.0.
So when we use the MSI token generated for SQL with Azure.Identity , SQL connection pooling seems to be broken , as we started getting below error related to the SQL connection pool.
Error :
Resource ID : 2. The session limit for the elastic pool is 30000 and has been reached. See 'http://go.microsoft.com/fwlink/?LinkId=267637' for assistance.
Changed database context to ''.
Changed language setting to us_english.
when we keep all settings same and switch back to old code which was using MSI tokens generated from : Microsoft.Azure.Services.AppAuthentication we do not see this error on same load test execution.
Expected behavior
The expected behavior is that it should not break the SQL connection pooling with MSI token generated with Azure.Identity.
Actual behavior
We are getting SQL connection pooling error with MSI token generated with Azure.Identity,
Error :
Resource ID : 2. The session limit for the elastic pool is 30000 and has been reached. See 'http://go.microsoft.com/fwlink/?LinkId=267637' for assistance.
Changed database context to ''.
Changed language setting to us_english.
Reproduction Steps

Generate the MSI token for SQL resource
var tokenCredential = new Azure.Identity.DefaultAzureCredential();
var managedIdentityTokenForSql = tokenCredential.GetToken(
new Azure.Core.TokenRequestContext(
new[] { "https://database.windows.net/.default" }, tenantId: "your_tenantId")).Token;

Now use this token and pass to the entity framework core :
var connection = Database.GetDbConnection() as SqlConnection;
if (connection != null)
{
connection.AccessToken = managedIdentityTokenForSql;
}

perform load test on this where more number of transactions are executed against SQL DB.

Environment

The Server API Layer which interacts with DB through Entity framework code is deployed to Azure Web App service.
Managed identity is enabled on the that Azure App service.
The web app is built using .NET core 3.1 version.
EF core Version=<IP_ADDRESS> .

//cc: @christothes

If you want to use DefaultAzureCredential, you can pass Authentication=Active Directory Default in your connection string. You can refer the docs here to see how to pass it.

@RanjanMishra92 Looking at release notes Active Directory Default authentication support is added in Microsoft.Data.SqlClient 3.0

@RanjanMishra92 Looking at release notes Active Directory Default authentication support is added in Microsoft.Data.SqlClient 3.0
CC: @cheenamalhotra, @johnnypham

@DavoudEshtehari
cc @David-Engel

Adding context, EntityFrameworkCore.SqlServer v3.1.7 depends on Microsoft.Data.SqlClient v1.1.3.
This issue regarding connection pooling with access token was fixed in v2.x of SqlClient (ref: https://github.com/dotnet/SqlClient/pull/443)

To explain a little bit how connection pooling works in SqlClient with regard to access tokens, each different access token will have a different pool in SqlClient. So if you are stress testing and generating a new access token for 30,000 connections, you will get 30,000 connections against the database and 30,000 different connection pools.
From your repro steps, I can't tell if you are performing steps 1 and 2 for each connection, or if you are using the same access token (just step 2) for all connections. Based on the results, it sounds like you are doing the former. The latter would result in a connection pool with only the number of physical database connections up to MaxPoolSize.
Either way, upgrading to a newer version of Microsoft.Data.SqlClient that supports Authentication = "Active Directory Managed Identity" or "Active Directory Default" will work much better as SqlClient will handle token acquisition and renewal for you (you won't need step 1 at all). You will just need the Authentication option in your connection string.


Never delete consumed ammunition carrying rule elements

I see some magazine related code in here, how does this interact with repeating ammo?


Added missing test case in LinearModel

LinearModel is miising test case for sparse_combiner=sqrtn, added the
same to make the coverage complete.

Overall looks good. I added one small comment.
I also added @rohan100jain for review since he seems more familiar with the code.

@annarev , @rohan100jain & @hgadig , i have updated the code as per the revidw comments, kindly check and if all ok, then approve the PR.

@rohan100jain , thanks for your review i have updated the code as per your comments, kindly check and approve.

Thanks @rohan100jain , @hgadig can you please update the label for the PR.
Regards
Amit


Dependency on typeorm

I know there's a similar issue to this (or perhaps it's pretty much the same), but for my sanity, I'm wondering why typeorm is a dependency.  typeorm + mongodb has so many issues.  I want to plug this into my https://github.com/j/type-mongodb library (ironically, when I started this mapper, my first idea was to do JIT as well, but didn't to keep it simple for now).  WIth this package, I'm going to switch it over to using Marshal.ts.  With that said, it'd be nice to not be able to pull in typeorm when using the mongo mapper utility functions.  Maybe marshal-mongo should just be the core of mongo logic and can have a marshal-typeorm package utilizing it.

You're right. Let's move that to marshal-mongo.
If you're interested in merging your project with marshal-mongo I'd love to talk with you, since I plan to create marshal-orm, which will pretty much be Typeorm, but with full mongodb support (with relations/joins, like marshal-mongo currently) and probably a couple of dozens times faster.

Oh, sorry, I misunderstood. marshal package has no typeorm dependency, so you probably want to use marshal-mongo and don't want to have typeorm there as dependency. Currently, the connection-handling is based on typeorm. This could be easily removed, but takes a couple of minutes to test. Then we could move that getTypeOrmEntity to another package or simply drop it.
What's your plan in using marshal-mongo with your library? I ask because the major features overlap.

Mainly just to remove the mapping aspect out of my library.  But the mapping aspect is pretty much 90% of why I wrote it.  So it'd essentially turn my library into just a repository layer on top of your library.  I'm not sure how I was going to go about it.  I just came across this library and my wheels started spinning on it.

Alright, I just removed typeorm entirely, see https://github.com/marcj/marshal.ts/commit/6bdf78f0ceaafa7caf4432b464c7d53f386d19b3.
The dependency isn't necessary anymore, it was only used historically because I planned to use its repository/connection-manager/entity-manager, but since that would degrade the performance promises of Marshal I stopped doing it and was only using its connection-manager, which was unnecessary. Also I implemented already a lot of ORM stuff in marshal-mongo myself which duplicates stuff from typeorm (although the mongodb support of Typeorm is basically non-existent), but that's still WIP. When I integrated the Unit-of-Work with batch inserting then it's ready for prime-time and I'll rename the package to marshal-orm while decoupling mongo's hardcoded stuff. However, I'm still searching for a good and performant grouped topological sort algorithm in JS before I can start the UoW. I guess I have to write it again myself, because I wasn't lucky yet.

Haha, yep, good luck!  There's really no true ODM for node.js + mongo.  I'd like to see entity persistence with dirty field checking to perform partial field updates instead of entire document updates (on nested & nested arrays as well).
I'll be on the lookout for what you come up with.

Thanks! I released the changes already, so I'm closing this one.
Dirty checking with partial updates (core for this is already there), UoW, Repository pattern, entity-manager/active-record pattern are definitely the features I consider inevitable for an ORM/ODM this scale. Whether a migration feature is necessary or not is something I don't know yet. I know from PropelORM that this is by far the most hairy feature that costs a lot of time, and is very unsexy work. Relation and querybuilder stuff is however already covered and implemented for Mongo. Documentation is little to non-existent tho. Maybe a little website helps here better than a readme with thousand lines.
It's actually interesting that there is no good ODM for mongo in TS. Even mongoose is terrible, and Typescript has little to no support. I kind of wonder what the performance of TypeOrm is, with mongo and with PostreSQL/MySQL, I assume not so exciting. Also sending filtered database records to the client via JSOn while deserializing there with the same model declaration is most of the time completely missing in the big picture of those libraries - I have to serialize manually to transport the data to the client and there to deserialize manually. Terrible. A situation I find personally very inefficient. There are obviously ways to make the development process of full-stack apps for many ten thousand developers way easier.
Let me know if you are interested in participating.


Key Error

from sportsreference.ncaab.teams import Teams
from sportsreference.ncaab.schedule import Schedule
teams=Teams(year=2010)

KeyError                                  Traceback (most recent call last)
 in
----> 1 teams=Teams(year=2010)
c:\python36\lib\site-packages\sportsreference\ncaab\teams.py in init(self, year)
997         self._conferences_dict = Conferences(year).team_conference
998
--> 999         self._retrieve_all_teams(year)
1000
1001     def getitem(self, abbreviation):
c:\python36\lib\site-packages\sportsreference\ncaab\teams.py in _retrieve_all_teams(self, year)
1140         for team_name, team_data in team_data_dict.items():
1141             team = Team(team_data['data'],
-> 1142                         self._conferences_dict[team_name.lower()],
1143                         year)
1144             self._teams.append(team)
KeyError: 'bryant'
I tried year 2011 and it worked fine.

Hello @denutza! Thanks for creating the issue! I just took a look, and there's something weird going on with Bryant University around that year. Apparently, they started their transition to Division-I basketball a couple years before, and fully converted a couple years later (at least, according to their basketball Wiki page). Looking at sports-reference.com, they are listed in the school stats sections for 2010, but they don't have an individual school page that year, causing them to not be populated in the dictionary containing conference details, and throwing the KeyError you ran into.
I was able to make a quick patch to check if the school contains valid information before attempting to create a Team instance and it appears to be working correctly now. I will create a new PR with the patch shortly and get this merged in for the next release.
Thanks again!

Thank you for the fast response.
I found out its happening on at least another year if not more.
Try this:
from sportsreference.ncaab.teams import Teams
from sportsreference.ncaab.schedule import Schedule
season_range=[]
for i in range(2000,2020,1):
season_range.append(i)
NCAAF works flawlessly.
for x in season_range:
teams=Teams(year=x)

Thanks for the update! I just ran through that test using the patch and it is able to continue normally, so I think this issue has been resolved for now, but please open another issue if you feel otherwise. I will hopefully get another release out in the near-term so this patch will be included with all released binaries.


SECAM decode produces unacceptably large colour artifacts

Whilst colour artifacts are necessary to reproduce the 'nostalgic' feel, when using the SECAM decoder the colour artifacts produced are usually enormous and detract from the overall image. I believe this is due to the algorithm used for decoding the FM subcarrier.

I have changed every decoding algorithm to a faster FIR-based one, yet I still am quite unsure why the colour artifacts in SECAM are so large. Either my hacky FM decoding algorithm is still off the mark or SECAM really is just like that.

I must double check the bandwidth allocated to the chroma information, since the magnitude of the artifacts seems alright but their width is probably what seems wrong.


WebView recently started crashing on Android on some devices

Starting on March 14, our app started seeing crash reports from users that have this backtrace:
backtrace:
  #00  pc<PHONE_NUMBER>d86b06  /data/app/com.google.android.webview-1gfF7Rp8MIUc8tMyCVn5pg==/lib/arm/libwebviewchromium.so

Our last release was on February 7, so we haven't introduced any changes. Additionally, it doesn't appear to be related to the content that we're showing as all the content we've been showing for the past month also shows the problem.
I was able to duplicate it on the following:

Android 5.1.1 running Chrome 72.0.3526.121
Android 9 running Chrome 73.0.3683.75

The WebView is inside of a ScrollView with other non-WebView components. On screen load the WebView is visible, but if we scroll down so that the WebView content is fully off the screen, the app will crash.
If I remove the overflow: "hidden" fix, the app will not crash, but the WebView doesn't render properly within the content. Setting the style of the WebView to include opacity: 0.99 also does not render the content properly (i.e., it still needs whatever the overflow: "hidden" fix does).
Here is what I see in logcat:
F/libc    ( 2321): Fatal signal 11 (SIGSEGV), code 1, fault addr 0x210 in tid 2422 (RenderThread)
I/DEBUG   (  358): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
I/DEBUG   (  358): UUID: d5116ccd-12dd-45df-a8a0-73da73812fc5
I/DEBUG   (  358): Build fingerprint: 'Sony/D5503/D5503:5.1.1/14.6.A.1.236/2031203603:user/release-keys'
I/DEBUG   (  358): Revision: '0'
I/DEBUG   (  358): ABI: 'arm'
I/DEBUG   (  358): pid: 2321, tid: 2422, name: RenderThread  >>> org.blah.app <<<
I/DEBUG   (  358): signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x210
I/DEBUG   (  358):     r0 04000000  r1 00000001  r2 00000000  r3 00000001
I/DEBUG   (  358):     r4 a1172168  r5 00000010  r6 a1172164  r7 00000210
I/DEBUG   (  358):     r8 b6e10e04  r9 9521fbcc  sl 00000000  fp a11725ac
I/DEBUG   (  358):     ip 00000001  sp a1172138  lr 00000031  pc a9f7cafc  cpsr 20010030
I/DEBUG   (  358):
I/DEBUG   (  358): backtrace:
I/DEBUG   (  358):     #00 pc 01d86afc  /data/app/com.google.android.webview-2/lib/arm/libwebviewchromium.so

I wonder if it is related to #429, but that description does not fit what I see exactly.

@lukebaker I can confirm that the crash is related. we where seeing the Fatal signal 11 (SIGSEGV) in our production app. Our solution to fixing the problem was setting opacity: 0.99 on the actual webview and keeping overflow: hidden on the container.

@christianbach @lukebaker this crash also happens on Samsung S8 when I try to navigate back from any screen included WebView, and I tried @christianbach 's fix, it is working.

@malonguwa do you really need to wrap the webview with overflow: hidden if you have a single webview covering the entire screen?

@dlindstrm cos when I navigate to my webViewScreen and then click the back button on the left top l, the app crash..... and I guess it is related to the webView component, cos this only happens when navigate back from the WebViewScreen, if no webView everything works well

Let's keep all discussion to #429! This will probably help get this solved faster 💯

@lukebaker I can confirm that the crashes is related. we where seeing the Fatal signal 11 (SIGSEGV) in our production app. Our solution to fixing the problem was setting opacity: 0.99 on the actual webview and keeping overflow: hidden on the container.

This solved the issue for me. I was getting a random crash only on android when I navigate back from a screen that was using webview in react navigation.
Only thing I was getting from error log in Android Studio was W/google-breakpad

@gamingumar Same, using opacity:0.99 on the webview somehow solves it from crashing on android

Still still persists in Hermes engine.

Still still persists in Hermes engine. Had to disable it also enable hardwareAcceleration on android.

no, there is nothing related to Hermes engine, it is just an Chrome bug, using opacity: 0.99 can bypass this problem

const Nav = createStackNavigator({
    IntroSlider: IntroSlider,
    Root: TabNavigator,
    LocationDetail: {screen: LocationDetail},
   .....
}, {

    mode: 'modal', //<---In my case, I added this option and it worked fine. "react-navigation-stack": "^2.0.15",
    headerMode: 'none',
},

);

opacity: 0.99 works 👍 .
If it does not, make sure your container has at least fixed height.
This works:
<View style={{ overflow: 'hidden', width: '100%', height: 500 }}>
        <WebView style={{ opacity: 0.99 }} />
</View>

This still crashes:
<View style={{ overflow: 'hidden', flex: 1 }}>
        <WebView style={{ opacity: 0.99 }} />
</View>

If your WebView needs to be full screen just use Dimensions.get('window') instead of flex

Moved to #429.


Unable to change default storage retention value from 15d

Problem/Motivation
I'm unable to change the retention time for prometheus. A longer retention time would allow me to look at data like: Power consumption in the last 30 days.
Expected behavior
I'm able to change the retention time.
Actual behavior
Unable to change the retention.
Steps to reproduce
Run the Prometheus addon, and you can see the 15d default value under "Runtime & Build Information" for the addon
Proposed changes
The suggestion in issue https://github.com/hassio-addons/addon-prometheus/issues/20 looks good to me.
I'd like to raise this topic again, because the existing issue was marked as stale and the PR was closed without being merged.

I've been waiting on this since Sept 2021.  Someone proposed the changes needed, a change by adding 9 lines of code to solve this, yet it doesn't seem to ever get changed.

@robtheone I switched to Victoria Metrics. https://github.com/fuslwusl/homeassistant-addon-victoriametrics
I‘ve been only running it for a few weeks, but it does the job so far. Maybe this is an alternative for you too.


Instructions on new Windows install don't work

These instructions don't appear to work with either the most recent release of .NET Core, or the most recent release of VSCode.
Fresh install of Windows (on VM). Grab

VSCode
.Net Core 3.1.300 SDK
Chrome

Follow instructions (extensions, etc.).
"The site can't be reached."
Likely a bug with Blazor/.NET Core, but currently these entry level instructions do not work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c07e57dc-526f-9479-4695-de7d8f06eb9a
Version Independent ID: 8226ed72-69b2-3c93-a931-218bd11cf9c8
Content: Get started with ASP.NET Core Blazor
Content Source: aspnetcore/blazor/get-started.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

@emersonp ... Did you trust the ASP.NET Core dev certificate after installing the SDK (dotnet dev-certs https --trust)?

A VM's browser has a number of restrictions by default. Blazor is supported in a browser configured by default for a user's device. Did you reconfigure the VM's browser to remove it default restrictions?

I'm going to close given that the behavior is by-design if the browser's security settings, such as those on a VM, are highly restricted (or the dev cert isn't trusted, which is called out by the SDK installer).


Incorrect is-a relation: positive regulation of prosthetic group metabolic process is-a positive regulation of cellular protein metabolic process

GO:0051200 positive regulation of prosthetic group metabolic process
is-a
GO:0032270 positive regulation of cellular protein metabolic process
The above relation is likely incorrect as prosthetic groups are non-protein components.

There are no annotations and no references for these terms:

GO:0051199 regulation of prosthetic group metabolic process
GO:0051201 negative regulation of prosthetic group metabolic process
GO:0051200 positive regulation of prosthetic group metabolic process

These terms conflate a chemical and its role (prosthetic group), we want to avoid this for metabolic process (see also #22899). I will propose obsoletion.
Thanks, Pascale


Cannot import Texture3D as VRAM compressed

Godot version
v4.0.alpha6.official [e4f0fc50f]
System information
Manjaro Linux (KDE X11)
Issue description
Importing a 3D texture works, but not VRAM compressed. I get an error like "no suitable PC VRAM compression enabled in project settings," even if all compression modes are enabled. Non VRAM compressed import modes work, but they have their own issues and I'd like to use VRAM compression for things.
Steps to reproduce
Load a 3D texture into a project
Change the import type to Texture3D, set the slices, and set the compression to VRAM compressed
After editor restarts, the error will pop up and texture is not useable
Minimal reproduction project
Texture3D VRAM.tar.gz

Is VRAM compression for 3D textures even a thing? Does it work in Godot 3.x?

It does work in 3.x for me. If it won't be implemented in Godot 4, it should at least not show the options that aren't supported.


[ENH] - Unminimize manual pages on jupyterlab user pods

Feature description
As an end user, I sometimes need to check the manual pages for common unix cli tools (e.g. git config --help). I've found several times that many manuals are minimized and as an end user, I don't have permissions to unminimize.
Value and/or benefit
This isn't a huge deal since I can just search for help on the internet, but it is slightly frustrating to break my typical workflow.
Anything else?
Example:
$ git config --help
This system has been minimized by removing packages and content that are
not required on a system that users do not log into.

To restore this content, including manpages, you can run the 'unminimize'
command. You will still need to ensure the 'man-db' package is installed.

From @dharhas

on the other hand how many people actually use man vs googling nowadays.
if we pull full docs for all packages it might increase docker size significantly which with slow spin up time so we should comapre before and after


Supported Docbook Tag List @SUSE

:information_source: https://docs.google.com/spreadsheets/d/1STdjzI9n5BrNOPoCoMPoH2SwlXoyzWxACBLRFVbmxDU/edit?usp=sharing

:information_source:

:information_source:

This is handled in testsuite now. Run

rake test

for full validation


dev, run images currently require libnsl

legacy VANTAGE, in the move to rocky linux, now requires libnsl for SWAT to pass -- there is a mix of executables that are built on CentOS and Rocky -- and some that were built on CentOS require libnsl to be installed
https://isrhub.usurf.usu.edu/Vantage/VantageSuper/pull/6029#issuecomment-308081
see also https://isrhub.usurf.usu.edu/VantageDocker/TestingImages/issues/21#issuecomment-301397 for a more detailed explanation of what is requiring libnsl -- it appears to be executables that depend on activemq, which depends on apr (apache portable runtime)
apr-targets.cmake for externpro built on rocky
set_target_properties(xpro::apr-1 PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/apr_1.5.2"
  INTERFACE_LINK_LIBRARIES "dl;pthread;rt"
)

apr-targets.cmake for externpro built on centos
set_target_properties(xpro::apr-1 PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/apr_1.5.2"
  INTERFACE_LINK_LIBRARIES "nsl;dl;pthread;rt;bsd"
)

the reasoning for adding this to dev and run images is that this is a "runtime" dependency and should only be needed for cases when someone is running things that include executables that were built on CentOS that also depend on activemq/apr

I'll wait for CM to independently verify that the latest docker images have everything needed for SWAT tests to pass https://isrhub.usurf.usu.edu/Vantage/VantageSuper/pull/6029#issuecomment-308785 before closing this issue

CM verified VANTAGE had a clean pretest run using latest
https://isrhub.usurf.usu.edu/Vantage/VantageSuper/pull/6029#issuecomment-309114


Crash in thread sentry.profiler.ThreadScheduler on PyPy 3.10 / SDK 2.13.0

How do you use Sentry?
Sentry Saas (sentry.io)
Version
2.13.0
Steps to Reproduce

Crash happened on this line (see full traceback below)

  File "/home/artsiom/dev/project/statistics.project.com/.venv_pypy/lib/pypy3.10/site-packages/sentry_sdk/profiler/utils.py", line 172, in extract_stack
    f_back = raw_frame.f_back

when I use the following decorator to wrap my function I want to analyze:

from functools import wraps
from typing import Any, Callable

import sentry_sdk
from sentry_sdk.tracing import Transaction

from configuration.utils import get_var_value_from_env

def get_sentry_transaction(func_name: str, transaction_name: str) -> Transaction:
    """
    Get the current transaction from the Sentry SDK or create a new one.

    @param func_name: name of the function
    @param transaction_name: name of the transaction
    @return: Sentry transaction
    """
    global_transaction = sentry_sdk.Hub.current.scope.transaction

    if global_transaction:
        transaction = global_transaction.start_child(op=func_name)
    else:
        transaction = sentry_sdk.start_transaction(op=func_name, name=transaction_name)

    return transaction

def sentry_instrument(
    transaction_name: str = "application",
    sentry_dsn_env_var_name: str = "SENTRY_DSN",
    traces_sample_rate: float = 1.0,
    profiles_sample_rate: float = 1.0,
    enable_tracing: bool = True,
    attach_stacktrace: bool = True,
    auto_enabling_integrations: bool = True,
    send_default_pii: bool = True,
    debug: bool = False,
) -> Callable[[Any], Any]:
    """
    Decorator to instrument the entrypoint function with Sentry SDK.
    It initializes the Sentry SDK with the provided DSN and other configurations.
    It also starts a transaction and a span for the entrypoint function.
    If the Sentry SDK is not initialized properly, it raises an AssertionError,
    as well as if the transaction or span is not started. All traces and metrics
    are sent to the Sentry server once the entrypoint function is executed and
    completed.

    @param transaction_name: name of the transaction
    @param sentry_dsn_env_var_name: name of the environment variable containing the Sentry DSN
    @param traces_sample_rate: sample rate for traces
    @param profiles_sample_rate: sample rate for profiles
    @param enable_tracing: flag to enable tracing
    @param attach_stacktrace: flag to attach stacktrace
    @param auto_enabling_integrations: flag to auto-enable integrations
    @param send_default_pii: flag to send default PII
    @param debug: flag to enable debug mode
    @return: decorated function
    """

    def decorator(func: Callable[[Any], Any]) -> Callable[[Any], Any]:
        @wraps(func)
        def wrapper(*args, **kwargs) -> Any:  # type: ignore[no-untyped-def]
            if not sentry_sdk.Hub.current.client:
                sentry_sdk.init(
                    dsn=get_var_value_from_env(sentry_dsn_env_var_name),
                    traces_sample_rate=traces_sample_rate,
                    profiles_sample_rate=profiles_sample_rate,
                    enable_tracing=enable_tracing,
                    attach_stacktrace=attach_stacktrace,
                    auto_enabling_integrations=auto_enabling_integrations,
                    send_default_pii=send_default_pii,
                    debug=debug,
                )

            if not sentry_sdk.is_initialized():
                raise AssertionError("Sentry client is not initialized properly")

            with (
                get_sentry_transaction(
                    func_name=func.__name__, transaction_name=transaction_name
                ),
                sentry_sdk.start_span(op=func.__name__),
            ):
                if not sentry_sdk.get_current_span():
                    raise AssertionError(
                        f"Sentry span is not started for {func.__name__}"
                    )

                try:
                    return func(*args, **kwargs)
                except Exception as e:
                    sentry_sdk.capture_exception(e)
                    raise e

        return wrapper

    return decorator

pip freeze:

aiohappyeyeballs==2.3.7
aiohttp==3.10.4
aiosignal==1.3.1
annotated-types==0.7.0
async-timeout==4.0.3
attrs==24.2.0
boto3==1.35.0
boto3-stubs==1.35.0
botocore==1.35.0
botocore-stubs==1.35.0
certifi==2024.7.4
cffi==1.17.0.dev0
charset-normalizer==3.3.2
dnspython==2.6.1
email_validator==2.2.0
frozenlist==1.4.1
geoip2==4.8.0
greenlet==0.4.13
hpy==0.9.0
idna==3.7
jmespath==1.0.1
maxminddb==2.6.2
msgpack==1.0.8
multidict==6.0.5
mypy-boto3-s3==1.35.0
pydantic==2.8.2
pydantic_core==2.20.1
PyMySQL==1.1.1
python-dateutil==2.9.0.post0
pytz==2024.1
readline==<IP_ADDRESS>
requests==2.32.3
s3transfer==0.10.2
sentry-sdk==2.13.0
six==1.16.0
types-awscrt==0.21.2
types-s3transfer==0.10.1
typing_extensions==4.12.2
urllib3==2.2.2
yarl==1.9.4

Expected Result
No crash, all good.
Actual Result
Crash with traceback:
RPython traceback:
  File "rpython_jit_metainterp.c", line 22077, in BlackholeInterpreter__resume_mainloop
  File "rpython_jit_metainterp.c", line 48291, in BlackholeInterpreter_run
  File "rpython_jit_metainterp.c", line 48671, in BlackholeInterpreter_handle_exception_in_frame
Exception in thread sentry.profiler.ThreadScheduler:
 [sentry] DEBUG: Sending envelope [envelope with 1 items (error)] project:XXXXXXXXXXXXXXX host:YYYYYYYYYYYYYYYYYY.ingest.us.sentry.io
Traceback (most recent call last):
  File "/home/artsiom/Downloads/pypy3.10-v7.3.16-linux64/lib/pypy3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/home/artsiom/dev/project/statistics.project.com/.venv_pypy/lib/pypy3.10/site-packages/sentry_sdk/integrations/threading.py", line 99, in run
    return _run_old_run_func()
  File "/home/artsiom/dev/project/statistics.project.com/.venv_pypy/lib/pypy3.10/site-packages/sentry_sdk/integrations/threading.py", line 94, in _run_old_run_func
    reraise(*_capture_exception())
  File "/home/artsiom/dev/project/statistics.project.com/.venv_pypy/lib/pypy3.10/site-packages/sentry_sdk/utils.py", line 1659, in reraise
    raise value
  File "/home/artsiom/dev/project/statistics.project.com/.venv_pypy/lib/pypy3.10/site-packages/sentry_sdk/integrations/threading.py", line 92, in _run_old_run_func
    return old_run_func(self, *a, **kw)
  File "/home/artsiom/Downloads/pypy3.10-v7.3.16-linux64/lib/pypy3.10/threading.py", line 953, in run
    self._target(*self._args, **self._kwargs)
  File "/home/artsiom/dev/project/statistics.project.com/.venv_pypy/lib/pypy3.10/site-packages/sentry_sdk/profiler/transaction_profiler.py", line 732, in run
    self.sampler()
  File "/home/artsiom/dev/project/statistics.project.com/.venv_pypy/lib/pypy3.10/site-packages/sentry_sdk/profiler/transaction_profiler.py", line 617, in _sample_stack
    sample = [
  File "/home/artsiom/dev/project/statistics.project.com/.venv_pypy/lib/pypy3.10/site-packages/sentry_sdk/profiler/transaction_profiler.py", line 618, in <listcomp>
    (str(tid), extract_stack(frame, cache, cwd))
  File "/home/artsiom/dev/project/statistics.project.com/.venv_pypy/lib/pypy3.10/site-packages/sentry_sdk/profiler/utils.py", line 172, in extract_stack
    f_back = raw_frame.f_back
SystemError: unexpected internal exception (please report a bug): <InvalidVirtualRef object at 0x72edd9464fa8>; internal traceback was dumped to stderr

If this is not related to Sentry SDK - I will open issue on PyPy issue tracker.

Hey @artempronevskiy !
Does this also happen if your run it with CPython, or only in pypy?
(We do not support pypy officially, so the code is not tested against pypy)

Just saw that the original poster said it is not related to the Sentry SDK. Will close this.


fix(learn): lack of block code declaration

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #47505

Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 🎉


Thread.Abort() causing intermittent crashes

This was primarily occurring when trying to call the mumbleClient's Close() method without exiting the application. Also only happened once out of every 5 or 6 close operations. However generally speaking Thread.Abort() is not considered safe due to the fact there's no guarantee where/when in the thread the abort will happen. A better solution would be to use Thread.Interrupt(). I was able to fix the issue by modifying the following files to use a variable to signal the threads to shutdown and then by calling Thread.Interrupt vs. abort. Here's the source code of the files I modified

MumbleUDPConnection.cs
... unchanged using statements ...

namespace Mumble
{
    public class MumbleUdpConnection
    {
        ... unchanged var defs ...

        // Add this to signal thread to shutdown
        private bool _running;

        ... unchanged var defs ...

        ... unchanged class methods ...

        internal void Connect()
        {
            ... do what you were doing here ...

            _running = true; // set flag to true here
            _receiveThread = new Thread(ReceiveUDP)
            {
                IsBackground = true
            };
            _receiveThread.Start();
        }

       ... other class stuff ...

        private void ReceiveUDP()
        {
            ... keep doing what you were doing here ...

            // Instead of while(true) use our flag here
            while (_running)
            {
                 ... do thread stuff here ...
            }
            // This probably isn't needed but just a fail-safe. Set up thread for next run
            _running = true;
        }

        ... more unchanged class stuff ...

        internal void Close()
        {
            _running = false; // before closing, signal thread it's time to stop

             // The ?. in this case is the same as the null check you were doing before; no need to change
             // if you don't want to. However, do change Abort to Interrupt here which will wait for the thread
             // to resolve
            _receiveThread?.Interrupt();

            ... unchanged ...
        }

        ... rest of the file is unchanged ...

MumbleTCPConnection.cs
... unchanged using statements ...

namespace Mumble
{
    public class MumbleTcpConnection
    {
        ... unchanged var defs ...

        // Add this to signal threads to shut down safely
        private bool _running;

        ... unchanged var defs ...

        ... unchanged class methods ...

        internal MumbleTcpConnection(IPEndPoint host, string hostname, UpdateOcbServerNonce updateOcbServerNonce,
            MumbleUdpConnection udpConnection, MumbleClient mumbleClient)
        {
            ... keep doing what you were doing here ...

             // Set flag to true here before starting thread
            _running = true;
            _processThread = new Thread(ProcessTcpData)
            {
                IsBackground = true
            };
        }

        .. unchanged class methods ...

        private void ProcessTcpData()
        {
            // This thread is aborted in Close()
           // Change while(true) to use _running here
            while (_running)
            {
                ... do thread stuff here (unchanged) ...
            }
            // This probably isn't needed, fail-safe to ensure we reset for next thread
            _running = true;
        }

       ... unchanged class methods ...

        internal void Close()
        {
            // Before interrupting thread, signal shutdown
            _running = false;

            ... unchanged ...
             // The ?. in this case is the same as the null check you were doing before; no need to change
             // if you don't want to. However, do change Abort to Interrupt here which will wait for the thread
             // to resolve
            _processThread?.Interrupt();

            ... unchanged ...
        }

        ... rest of file is unchanged ...

Outstanding!
The way I had been using it, close was only called on application quit, so this is definitely something that I would have missed.
Thank you for taking the time to make a proper fix. Do you want to make a PR?

Looks great, thanks for taking the time to fix that

No problemo
And thank you for taking the time to make such a super useful plugin
On Tue, Mar 30, 2021, 12:16 PM BananaHemic @.***> wrote:

Looks great, thanks for taking the time to fix that
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BananaHemic/Mumble-Unity/issues/41#issuecomment-810434949,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACY36BXFZ5ORJVJZRDQHJL3TGIBO7ANCNFSM4ZXXB44A
.


Unexpected display a scrollbar

system: window10

Chrome browser

Hi @jkcs, noted, how to fix this?

Thanks @jkcs


Questionable messaging because of type parameters

In the collection package, in lib/src/canonicalized_map.dart, on line 89:
bool containsKey(Object? key) {
  if (!_isValidKey(key)) return false;
  return _base.containsKey(_canonicalize(key as K?));
}

This is a valid migration, but the explanation for the question mark on key is difficult to understand. The text reads "The corresponding parameter in the overridden method is nullable". The truth is that the corresponding parameter in the overridden method is K, which is potentially nullable. It might be better to be correct here, despite the fact that "potentially nullable" is a new concept for our users. (I think they're going to have to understand it anyway if they're using type parameters.)

@MichaelRFairhurst @srawlins

Isn't the overridden type constainsKey(Object? key)?

Yes, sorry. I must have been looking at something else.

it may be a good idea to link these up. If you accidentally looked at
something else and got thrown off, users definitely will do the same at
times too.
On Thu, Jan 9, 2020 at 12:00 PM Brian Wilkerson<EMAIL_ADDRESS>wrote:

Yes, sorry. I must have been looking at something else.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/40035?email_source=notifications&email_token=AAMNM64U33TVS5JNHJD6RWDQ4565BA5CNFSM4KE4EK32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIRSW2A#issuecomment-572730216,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMNM63CKNVL43J5GSPFCQ3Q4565BANCNFSM4KE4EK3Q
.

We just have to decide how much of an IDE we're implementing here.


Doesn't work with django 2.1

Fix for some obvious errors:
diff -ur /home/david/git/growconfig/.venv/lib/python3.7/site-packages/django_spaghetti/views.py django_spaghetti_new/views.py
--- /home/david/git/growconfig/.venv/lib/python3.7/site-packages/django_spaghetti/views.py	2019-01-22 15:17:35.329004287 -0800
+++ django_spaghetti_new/views.py	2019-01-22 15:16:49.676862104 -0800
@@ -82,8 +82,8 @@
             edge_color = {'inherit': 'from'}

             for f in fields + many:
-                if f.rel is not None:
-                    m = f.rel.to._meta
+                if f.rel if hasattr(f, 'rel') else f.remote_field is not None:
+                    m = f.rel.to._meta if hasattr(f, 'rel') else f.remote_field.related_model._meta
                     to_id = "%s__%s" % (m.app_label, m.model_name)
                     if to_id in excludes:
                         pass

But there are other issues, like the edges on the graph are missing.

This is fixed in master apparently.  It would be nice if there could be a new release to PyPI.

@SpacemanPaul I'll see what I can do!

Any update? Would be easier than to clone etc esp when using docker.

Version 0.3.0 is now on PyPI 🤯


Readme should account for MacOS and Windows differences

Hi, I noticed lazygit has different paths for the configuration file depending on the operating system:
Default path for the config file:

- Linux: ~/.config/lazygit/config.yml
- MacOS: ~/Library/Application Support/lazygit/config.yml
- Windows: %APPDATA%\lazygit\config.yml

https://github.com/jesseduffield/lazygit/blob/master/docs/Config.md
No big issue for me, but perhaps the instructions could indicate the path may be different from the default Linux path, which is used now.

Just a note here, this is the same case as https://github.com/catppuccin/k9s/pull/2, the technically correct README here would be
Linux:
"${XDG_CONFIG_HOME:-$HOME/.config}/lazygit"
macOS:
"${XDG_CONFIG_HOME:-$HOME/Library/Application Support}/lazygit"


Added ability to set the text content when writing dummy files

Description
When creating folders FluentStorage may create a dummy file to ensure the folder is visible (e.g. S3).  This change allows the content of the dummy file to be changed from the default text "created as a workaround by FluentStorage when creating an empty parent folder""

Thanks!


Update README.md

updated the readme.md wiki link to point to the right git wiki development url

Thanks for catching this!


[Feature Request] Menu sticky header and active menu

The new UI changes to the menu from the left to the top is but it will help if the menu is sticked to the top while scrolling to help easy navigate to another page.
Also, having the button have a different colour when active and also been able to click without having to use the drop-down for parent menu.

I would be happy to assist

Then make a PR...


[NSE-149] add decimal fallback to columnar window

What changes were proposed in this pull request?
fixes: https://github.com/oap-project/native-sql-engine/issues/149
How was this patch tested?
locally tested

replaced by #151


[Question/Request] Can the Shutdown goal, support by configuration the restart=true option

Hi, my main goal is to deploy apps on wildfly but restart at some point my local or remote server (prior or after the deployments).
The current wildfly maven plugin, provides a shutdown goal, but comparing with the CLI equivalent which you can issue :shutdown(restart=true) , I can not define restart =true on the maven goal.
So in order to do my restart, using the plugin I have been using the execute-commands goal
   <execution>
                                <id>RESTART WILDFLY</id>
                                <phase>install</phase>
                                <configuration>
                                    <execute-commands>
                                        <commands>
                                            <command>:shutdown(restart=true)</command>
                                        </commands>
                                    </execute-commands>
                                </configuration>
                                <goals>
                                    <goal>execute-commands</goal>
                                </goals>
                  </execution>

The problem is that for some reason (probably in the plugin implementation) right after the command invocation, the server restarts and the plugin immediately reports that it can not get a feedback from the running server,

Moved to https://issues.jboss.org/browse/WFMP-7


418 I'm a Teapot

Requests implements the 418 I'm a Teapot status code in status_codes.py.
Its source is RFC2324, Hyper Text Coffee Pot Control Protocol (HTCPCP/1.0). Note the title - HTCPCP/1.0 is not HTTP/1.x.
HTCPCP was an April 1 joke by Larry to illustrate how people were abusing HTTP in various ways. Ironically, it's not being used to abuse HTTP itself -- people are implementing parts of HTCPCP in their HTTP stacks.
In particular, Node's support for the HTCPCP 418 I'm a Teapot status code has been used as an argument in the HTTP Working Group to preclude use of 418 in HTTP for real-world purposes.
While we have a number of spare 4xx HTTP status codes that are unregistered now, the semantics of HTTP are something that (hopefully) are going to last for a long time, so one day we may need this code point.
Please consider removing support for 418 from Requests, since it's not a HTTP status code (even by its own definition). I know it's amusing, I know that a few people have knocked up implementations for fun, but it shouldn't pollute the core protocol; folks can extend Node easily enough if they want to play with non-standard semantics.
Thanks,
/cc @Lukasa

BTW, I'm aware this is a breaking change; deprecating and delaying to the next major release is fine.

Line of code in question: https://github.com/requests/requests/blob/master/requests/status_codes.py#L55

Please note the alternative versions for 200 OK: https://github.com/requests/requests/blob/master/requests/status_codes.py#L13

Huh. The only thing that causes me concern there is the use of unicode and backslashes; requests doesn't emit those, does it?

Nope, this is for reverse lookup only — same with I'm a teapot.

OK, that's good. The problem is that implementation is being used as evidence to preclude actual use of the status code, which is going to eventually be a problem.

Please see https://github.com/nodejs/node/issues/14644 and https://github.com/golang/go/issues/21326 for discussions regarding similar changes.

I'm okay with removing it, unless we want to add other status codes like 420 and friends.
HTTPbin.org is keeping it though :)

Individual servers, I'm less concerned about :)

Send a PR!

Make it against the 3.0.0 branch though, this will be a breaking change.

Hold on! I'm the guy behind http://save418.com (https://github.com/WhataShane/save418). I, like many others, enjoy stumbling upon (almost entirely) innocuous gags like 418.  It'd be a real shame to see it go.
To quote @romellem from the Go thread, who quite eloquently sums up the argument for 418:

Just to be clear, is your argument that when/if the 400 block runs out, we'll want that one extra code available to stretch out the usefulness of the 400 block just a bit further?
Unless I'm reading it incorrectly, the 400 block of HTTP status codes has more than 50 codes available. With the available "space" of the 400 block at more than 50%, this might be a pre-mature optimization for a problem that may never occur (400 block running out of available codes, that is).
Not trying to sound harsh, but I for one like fun little easter eggs that you find throughout a programming career. To me, it shows that everything that goes on to make a computer actually do work is still made by humans, and keeping small slices of that human element is nice (in my opinion). Your argument is sound and logical, but this requested change ever so slightly lowers the "fun-ness" of Go (and potentially NodeJS) in the spirit of engineering robustness. At the end of the day, I have to say I don't think that tradeoff is worth it.
(I appreciate the history lesson though! I always thought 418 was a part of the HTTP/1.x spec; didn't know about the "HTCPCP/1.0" spec. 🙂)

I agree that it's a fun easter egg.

Requests takes itself seriously, but not too seriously.  :)

This might be the line of "too seriously".

Isn't the obvious answer here to make it part of the spec by starting with a new RFC?

@tSavo Clearly!

While I recognize 418 isn't part of the HTTP status code spec in RFC 7231, it does exist in the wild. Even google has it implemented here. In the unlikely event the IETF decides to implement a real use for 418, we'll have plenty of forewarning to address this. I'm in favor of leaving this as it is  unless there's a more compelling reason it needs to be removed.

Give me your keys.

Just to be clear, I agree with the rest of the Requests team: we should keep the 418 mapping here. But the reason I agree is purely pragmatic, not because of the fun Easter egg (though it is fun): codes.py is used to build a mapping from reason phrase to code. For this reason it should include any reason phrase that is somewhat likely to appear for a given code. For the moment that is I'm A Teapot. If this changes, we'll add any other phrase the IANA assigns.
@mnot, feel free to use this response as a commitment that says that the IETF/IANA should feel free to re-use 418, and not to block it on our behalf. 😉 I think reason phrases are stupid anyhow.

A request to register 418 has been submitted to IANA, under number 979050.

Ok; this is not a discussion forum for the merits of 418. @mnot if you want to follow up on this please drop me an email. For everyone else: we appreciate your input, but I feel pretty good about the decision we've made.


calculating Mass accretion rate for SN post-processing

PR Summary

PR Checklist

[ ] Adds a test for any bugs fixed. Adds tests for new features.
[x] Format your changes by calling scripts/bash/format.sh.
[x] Explain what you did.

As soon as tests pass here (and you confirm it works for you locally) I will merge.

All tests have passed, compiles, runs, produces reasonable output.


fix: #1455 - make tappable header no selectable

What
Make tappable header no selectable (Nutrition facts, 100g, Compare to ...)
Screenshot

Fixes bug(s)

Fixes: #1455

Codecov Report

Merging #1874 (4003329) into develop (2ea0da3) will decrease coverage by 0.76%.
The diff coverage is 10.23%.

@@            Coverage Diff             @@
##           develop   #1874      +/-   ##
==========================================
- Coverage     8.86%   8.09%   -0.77%
==========================================
  Files          161     176      +15
  Lines         6623    7994    +1371
==========================================
+ Hits           587     647      +60
- Misses        6036    7347    +1311

Impacted Files
Coverage Δ

...h_app/lib/cards/category_cards/abstract_cache.dart
0.00% <0.00%> (ø)

...p/lib/cards/category_cards/asset_cache_helper.dart
0.00% <0.00%> (ø)

...p/lib/cards/category_cards/raster_async_asset.dart
0.00% <0.00%> (ø)

...oth_app/lib/cards/category_cards/raster_cache.dart
0.00% <0.00%> (ø)

..._app/lib/cards/category_cards/svg_async_asset.dart
0.00% <0.00%> (ø)

...smooth_app/lib/cards/category_cards/svg_cache.dart
0.00% <0.00%> (ø)

...th_app/lib/cards/data_cards/image_upload_card.dart
0.00% <0.00%> (ø)

...es/smooth_app/lib/cards/data_cards/score_card.dart
4.54% <0.00%> (-0.22%)
:arrow_down:

...t_cards/knowledge_panels/knowledge_panel_card.dart
0.00% <0.00%> (ø)

...knowledge_panels/knowledge_panel_element_card.dart
0.00% <0.00%> (ø)

... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b4933...4003329. Read the comment docs.


Not getting connected to server

Things I followed

cd webrtc-nestjs-server
installed nestjs (npm i -g @nestjs/cli)
npm i
npm start

Then I ran the app on an emulator as well as a real device both android but both are not getting connected. Is there any other thing I should do?

Hello, I am blocked from sending http requests on android 6 and above versions. Add this "android: usesCleartextTraffic =" true "to the application section of the AndroidManifest.xml file to enable request throwing

@pranayfating  You need to find your local machine IP (ip config)
-- Then go to file my_app  in AppContent widget change the ip to your local machine ip


HHH-14728 Include CamelCaseToUnderscoresNamingStrategy from Spring Boot

Hi @philwebb , @mbhave I assume you'd be cool with this?
Please let me know, as I've heard people are commonly copying this from Spring Boot: it's probably more convenient for all if we distribute this naming strategy with ORM.

https://hibernate.atlassian.net/browse/HHH-14728

Adding it here would be great! We can then drop it from our codebase sometime in the future.
The code added here is under the LGPL license where as the original is Apache 2.0. Since It's such a trivial piece of code and @mbhave and myself are the authors I think the license change is fine. Consider this comment permission, but please let me know if you need something more formal.

@philwebb many thanks! No need for more formality :)


[BUG] kubectl drain node gets stuck forever

Describe the bug (🐛 if you encounter this issue)
We have RKE2 v1.24.9+rke2r2 / longhorn 1.4.0 cluster with three nodes.
In case we want to drain a node, it stucks forever in:
evicting pod longhorn-system/instance-manager-e-467f02d7d8111f796e8acd19035861fc
error when evicting pods/"instance-manager-e-467f02d7d8111f796e8acd19035861fc" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
evicting pod longhorn-system/instance-manager-r-467f02d7d8111f796e8acd19035861fc
error when evicting pods/"instance-manager-r-467f02d7d8111f796e8acd19035861fc" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget

We have 4 volumes, every volume has 3 replicas, and all volumes are healty, so I should be able to drain one node:

To Reproduce

kubectl cordon node_name
kubectl drain node_name  --ignore-daemonsets --delete-emptydir-data

Expected behavior
The drain should complete.
Log or Support bundle
supportbundle_8a90d3be-0c71-4a5e-84cd-f7813c61b04a_2023-01-15T12-59-32Z.zip
Environment

Longhorn version: 1.4.0
Installation method (e.g. Rancher Catalog App/Helm/Kubectl):

cat <<EOF | tee longhorn-values.yaml
persistence:
  defaultClass: false
  reclaimPolicy: Retain
defaultSettings:
  defaultDataPath: /data/longhorn/
  concurrentAutomaticEngineUpgradePerNodeLimit: 3
longhornUI:
  replicas: 2
ingress:
  enabled: true
  host: longhorn.$K8SDOMAIN
EOF

helm repo add longhorn https://charts.longhorn.io
helm repo update

helm install longhorn longhorn/longhorn \
  --namespace longhorn-system \
  --create-namespace \
  --values longhorn-values.yaml

Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: RKE2 v1.24.9+rke2r2 (we use RKE2 upgrade controller with https://update.rke2.io/v1-release/channels/stable channel)

Number of management node in the cluster: 3
Number of worker node in the cluster: 0

Node config

OS type and version: Ubuntu 22.04.1 LTS (GNU/Linux 5.15.0-57-generic x86_64)
CPU per node: 28/32/32
Memory per node: 64 GB
Disk type(e.g. SSD/NVMe): NVMe
Network bandwidth between the nodes: 10 Gb/s

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): vm on baremetal (hyper-v).
Number of Longhorn volumes in the cluster: 4.

Additional context
Not sure if that matters, however:

Few days ago we've upgraded Longhorn v1.3.2 > v1.4.0.
Previously we use a latest channel (https://update.rke2.io/v1-release/channels/latest) for RKE2 upgrade controller and cluster was upgraded to v1.26.0, however, later we switched to the stable channel and the cluster was downgraded to RKE2 v1.24.9+rke2r2.
Few weeks ago there were 4 nodes in cluster, but we've removed one. Some volumes have entered a degraded state, we delete (via Longhorn UI) in every degraded volume a replica, deployed on that node. After a few minutes longhorn rebuiled that volumes with new replica and now all volumes are healty.

Also I've tried to delete all apiVersion: longhorn.io/v1beta2 kind: Replica resources which were not in running state. Remaining volumes are working, however, that didn't help.

@c3y1huang Please help check this PDB related.

@VuiDJi can you try again with --pod-selector='app!=csi-attacher,app!=csi-provisioner' added to your drain command?
Ref: Updating the Node OS or Container Runtime

@c3y1huang
Tried kubectl drain --pod-selector='app!=csi-attacher,app!=csi-provisioner' srv-ubuntu4 --ignore-daemonsets --delete-emptydir-data, but the same error occurs :(
evicting pod longhorn-system/instance-manager-r-467f02d7d8111f796e8acd19035861fc
error when evicting pods/"instance-manager-r-467f02d7d8111f796e8acd19035861fc" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
evicting pod longhorn-system/instance-manager-e-467f02d7d8111f796e8acd19035861fc
error when evicting pods/"instance-manager-e-467f02d7d8111f796e8acd19035861fc" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.

@c3y1huang Tried kubectl drain --pod-selector='app!=csi-attacher,app!=csi-provisioner' srv-ubuntu4 --ignore-daemonsets --delete-emptydir-data, but the same error occurs :(

Oh, just realized srv-ubuntu4 is already gone so even with the extra argument CSI Attacher is still unable to detach the volume.
Can you try to scale down the workload for pvc-3114c7f4-c690-4ac6-be8d-90d7c682709f then drain?

@c3y1huang T've tried to scale down that deployment and volume became Detached:

However, it's still inpossible to drain node:
evicting pod longhorn-system/instance-manager-r-467f02d7d8111f796e8acd19035861fc
error when evicting pods/"instance-manager-r-467f02d7d8111f796e8acd19035861fc" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
evicting pod longhorn-system/instance-manager-e-467f02d7d8111f796e8acd19035861fc
error when evicting pods/"instance-manager-e-467f02d7d8111f796e8acd19035861fc" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.

Can you try scaling down the workloads that are using RWX volumes and drain? If that still doesn't work, please provide the latest support-bundle.


Frontpage events look somewhat cramped at lower window sizes

What kind of an issue is this?

[x] Isn't this what the type label is for? UI, anyways.

What is the expected behaviour?
Good looking interfaces.
What is the current behaviour?
Could use a whole lot more separation between events in the event (hehe) that there's no image.

Other information
i love you guys.

Fixed by #2153


Indent issues with javascript in  blocks

Describe the bug:
Hi, I'm migrating a few projects from ASP.net WebForms to .net core 6. The ASP.net projects used DevExpress WebForms controls and they are being migrated to the DevExpress DevExtreme suite.
The DevExtreme suite controls use extensively the Razor @<text>...</text> block pattern, e.g.:
@(Html.DevExtreme().DataGrid<GetListaIncontriOutputDto>()
  .ID("gridIncontri")
  .OnCellPrepared(@<text>
    function (e) {
      if (e.rowType == "filter" && e.columnIndex == 1) {
        $("Pulisci").appendTo(e.cellElement);
      }
    }
    </text>)
  .OnContentReady(@<text>
    function (e) {
      $("#annullaIncontroButton").dxButton("instance").option("disabled", e.component.getSelectedRowKeys().length != 1);
    }
  </text>)
  .OnSelectionChanged(@<text>
    function (e) {
      $("#annullaIncontroButton").dxButton("instance").option("disabled", e.selectedRowKeys.length != 1);
    }
  </text>)
)

Unfortunately, when typing out those code blocks, Visual Studio does not indent the javascript code, making everything pretty ugly to read, especially for longer methods. By pressing Ctrl+K, Ctrl+D on the above code, this is what happens:
@(Html.DevExtreme().DataGrid<GetListaIncontriOutputDto>()
  .ID("gridIncontri")
  .OnCellPrepared(@<text>
    function (e) {
    if (e.rowType == "filter" && e.columnIndex == 1) {
    $("Pulisci").appendTo(e.cellElement);
    }
    }
  </text>)
  .OnContentReady(@<text>
    function (e) {
    $("#annullaIncontroButton").dxButton("instance").option("disabled", e.component.getSelectedRowKeys().length != 1);
    }
  </text>)
  .OnSelectionChanged(@<text>
    function (e) {
    $("#annullaIncontroButton").dxButton("instance").option("disabled", e.selectedRowKeys.length != 1);
    }
  </text>)
)

Version used:
VS2022 17.2.4
To reproduce:
Steps to reproduce the behavior:

Paste the above code in a .cshtml file
Press Ctrl+K, Ctrl+D
See indent being removed

Expected behavior:
I would expect curly braces to apply indent, or at the very least to be left alone as typed.
Actual behavior:
Indent is removed from  nodes.

@ToddGrun @zkat I looked into this a bit and it seems like Razor is doing the right thing, but the Html language server is sending back edits that move everything to the same column.
Wasn't there a TypeScript formatting bug that moved everything to column 0? Wondering if this could be a dupe of that?

Logged this internally as https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1612535. Since that isn't public, I'll keep this open to track it.

This is something we currently can't provide any help with, unfortunately. We get our Html/JavaScript formatting from the Html language server, but we don't have a deep understanding of the languages in Razor. When formatting this code we correctly send the JavaScript to the Html server to format but because the surrounding context is entirely C#, there is no way for the Html server to know that it is JavaScript, so it formats it as though it is plain text in a Html file, and lines everything up neatly as you observe.
A workaround you should be able to do is to put the bulk of the JavaScript code in one or more


[BUTTON IDEA]:Rainbow button

1. Name of button:
Rainbow Button
2. Description:
Copy paste this url in browser to see this button working live-
https://codepen.io/hrshk/pen/KKMmgpK
3. Button Type (Animated, Special, etc...):
Animated
4. Will you work on it?:
I have worked upon it .

You can go ahead @Hrshk15

Thanks!!


fix: swapped accounts with wallet

This PR swaps the word account with wallet. Mainly in user-menu, accounts-menu and in connect-a-wallet page.
fixes: #2872
Type of Change

fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes

How has this been tested?
Changes are reflected in the extension without breaking anything.

@Harshit-Prasad u need to change the translations for other languages too not only for english

@Harshit-Prasad u need to change the translations for other languages too not only for english

@Rithvik-padma I don't think this is right - we cannot know what the correct translation is for all languages. There is a script created by @reneaaron in .github/workflows/translations.yml which should check keys from other languages to see if any need to be removed, and a script you can run here to remove them: scripts/remove-outdated-translations.js

@Harshit-Prasad You just need to update the English translation keys and run the script @rolznz mentioned, which will remove the keys from the translated files.

@reneaaron
I tried running the scripts and I can't seem to get things right.

p.s.-  I even tried modifying the script, trying different arguments nothing seems to work

That's strange. I just executed the commands in your branch locally and they seemed to work. :thinking:
Maybe you could try to debug the script by adding console.log statements here:
https://github.com/getAlby/lightning-browser-extension/blob/fix/swapped-account-for-wallet/scripts/remove-outdated-translations.js#L13
Otherwise just skip it and I'll have another look before we merge it.


OAL disable statement doesn't work

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[x] Bug
[ ] Requirement
[ ] Feature or performance improvement

Bug

Which version of SkyWalking, OS, and JRE?
8.4.0

What happened?
As the document said,

disable statement is designed for make them de-active, such as segment, top_n_database_statement.

I disabled some metrics in the oal files, but the ES indies are still created when I boot OAP with init-mode. There are the disable statements in oal files.
disable(browser_error_log);
disable(zipkin_span);
disable(jaeger_span);
disable(profile_task);
disable(profile_task_log);
disable(profile_task_segment_snapshot);

And I remove all es indices and template first, then start the OAP to create Indies. I curl the ES indies after the OAP finished initialize.
green open profile_task_segment_snapshot-20210331               LY2xjsBkTzGNQZjlc-51fw 1 1 0 0   522b   261b
green open browser_error_log-20210331                           K7ArON33RI26gPezW7-KuA 5 0 0 0  1.2kb  1.2kb
green open profile_task-20210331                                fuxKtckzQAy_lTMjKybiiw 1 1 0 0   522b   261b
green open profile_task_log-20210331                            G5ZNtKMVT_SRF_g7_NXRqA 1 1 0 0   522b   261b
green open jaeger_span-20210331                                 fDe8MlD_QwKCVeIU8ciY3Q 5 0 0 0  1.2kb  1.2kb
green open zipkin_span-20210331                                 OTNLbC_WS-WeUFxaGMl4ww 5 0 0 0  1.2kb  1.2kb

I already read the #6265 #6267 , but I cannot get some useful information.

This is not a hard thing to debug, you could simply do by yourself.

Okay, we confirm whether this issue needs to be polished first.
If disable means DO NOT CREATE indices, maybe I could fix it.

Disable doesn't only mean no index, it disable the whole streaming process.

Most users disable the metrics because they don't need the indices.
But the useless indices created and deleted day by day. I think the disabled statements that don't create the index will be better.

Read my reply again. I didn't say index should be created.

I found out what happens now, we changed the OAL loading sequence which makes the disable not working.


[LPE] Provide number of states before applying LPE

When LPE transform some models, it suffers from combinatorial explosion.
I would like an option added to LPE to just calculate the number of states that would result from apply LPE on a given model.
Since calculating the number of states would just require multiplication of some numbers instead of combining transitions from state machines, I expect this calculation to be fast.
This number could help in two ways:

Understand the complexity of a given model
Decide whether or not to transform a model using LPE.

I realized that is not necessarily connected to LPE.
Also related to Petra van den Bosch work on test case generation for complete coverage:
how many test cases are needed (without generating them)?


Converted binary/minfs/main.go to a small wrapper.

Converted binary/minfs/main.go to a small wrapper that calls common functions in fs/minfuse. Renamed utils->perf.

LGTM


Let mbarrien + schristou maintain cobertura-plugin

Per the discussion in https://groups.google.com/forum/#!topic/jenkinsci-dev/J--7iWOEb00 adding permission for myself and Steven Christou schristou (@christ66) to the maintainers of cobertura-plugin. Soft approval is visible within the thread. Uncertain if it matters, but @christ66 is a CloudBees employee.
Attempts were made to contact the maintainers both privately 3 weeks ago, and cc-ed on the mailing list 2 weeks ago. All existing maintainers drulli (@uhafner), tamini (@tamini), ogondza (@olivergondza) have all expressed that they no longer maintain the plugin. I don't know the procedure for removing maintainers if they want to be removed.
It may complicate things, but the list of maintainers on the Wiki page is disjoint from the one maintained in this file. So also paging ssogabe (@ssogabe), manuel_carrasco (@manolo), and stephenconnolly (@stephenc) just in case.
https://wiki.jenkins-ci.org/display/JENKINS/Cobertura+Plugin
https://github.com/jenkinsci/cobertura-plugin
Always

[x] Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] All newly added users have logged in to Artifactory at least once

Approved on the mailing list by existing not-really-maintainers.


Unable to add parameter to @AfterTest

I am unable add any method parameters to my AfterTest method. For ex:
@AfterTest
public void doAfterTest(IResult result){
  <Some code here>
}

throws me illegal argument exception. But same works for @AfterMethod

Could you share the stacktrace?
BTW, it works as expected, because:

Any @AfterMethod method can declare a parameter of type ITestResult, which will reflect the result of the test method that was just run.

http://testng.org/doc/documentation-main.html#annotations

@AfterTest: The annotated method will be run after all the test methods belonging to the classes inside the  tag have run.

http://testng.org/doc/documentation-main.html#native-dependency-injection
But I'm agree, nothing is available for results from <test> node. Why do you want it?

For this scenario:

Now both the methods test001 and test002 together constitute one test. But if I use @AfterMethod here, i'll get 2 test results. But actually I did run only 1 test.
If I user @AfterTest here, I am hoping to get the result based on if both the test001 and test002 passed.

ITestResult is related to a test method. As I know, TestNG doesn't provide any mechanism which will merge results for class, test or suite (IReporter is just grouping all method results).
But you should be able to manage it yourself with both @AfterTest and @AfterMethod.

So there's no inbuilt mechanism to verify the  xml tags have passed as of now?

@cbeust WDYT?

No such thing at the moment.


All typescript templates are broken

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
recent
Electron version
recent
Operating system
Windows 11
Last known working Electron Forge version
?
Expected behavior
All templates are broken for me. I tried this command found here
npm init electron-app@latest my-new-app -- --template=webpack-typescript
...as well as all others similar to this. The result is that typescript is not installed. The template is ignored.
This is what I see in my directory:

Actual behavior
see above
Steps to reproduce
see above
Additional information
No response

Hi @Johnrobmiller, I can't seem to reproduce on my side. Can you give me the output from your command and tell me what npm version you're using?
This is the expected output:
♥ 08:55 npm init electron-app@latest my-new-app -- --template=webpack-typescript
✔ Locating custom template: "webpack-typescript"
✔ Initializing directory
✔ Preparing template
✔ Initializing template
✔ Installing template dependencies

Having this same issue, template is not installed with node22 (22.4.1), but correctly installed with node16 (v16.20.2)

Thanks for the additional context @walruskhan. I just tried myself on Node.js v22.5.1 and npm 10.8.2 and was unable to reproduce the bug still.
One more avenue to explore is that I'm currently running a macOS device, while both reports so far seem to be on Windows. I'll take a closer look on my Windows machine tomorrow.

I had this issue when running this command:
npm init electron-app@latest my-new-app -- --template=vite-typescript

I was able to fix it by running this command instead:
npx create-electron-app my-new-app -- --template=vite-typescript

I am using Windows 11, PowerShell, Node 20.16.0, and npm 10.8.2. It does not appear that the command line args given to npm init are passed along to create-electron-app to use. Here is a full log for reference:
PS D:\test> npm init electron-app@latest test -- --template=vite-typescript

> npx
> create-electron-app test

✔ Locating custom template: "base"
✔ Initializing directory
✔ Preparing template
✔ Initializing template
✔ Installing template dependencies

Same on Windows 11

Problem persists, however it only seems to occur using powershell and/or cmd, using git bash causes no issues.

Can this issue's title be changed to "Commands for creating templates broken on windows"?

Going to replace the commands with the npx invocation since this seems to be a weird upstream Node 22 bug.


fix: Enums with tuple of any length now allowed and example is updated

Added a new test to cover this case.
What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]

also, please review the test failures on the CI - we need to get there resolved before merging this PR.


Allow to set router's futures

Is your feature request related to a problem? Please describe.
Since version 6.28.0 react-router-dom spams a lot of warnings about enabling v7 futures in console. storybook-addon-remix-react-router provides no way so set them
Describe the solution you'd like
Add futures object to reactRouter storybook options and pass it to the react-router-dom.
Describe alternatives you've considered
-
Additional context
https://reactrouter.com/en/6.27.0/upgrading/future#update-to-latest-v6x
https://github.com/remix-run/react-router/issues/12245

@artaommahe Can you try the canary version ?
npm i<EMAIL_ADDRESS>

@JesusTheHun now it works properly for futures passed to the createBrowserRouter, but doesn't support futures passed to the RouterProvider.future 😅 , like v7_startTransition. So most warnings are finally gone, except one related to v7_startTransition

@artaommahe Oh ok. They gave the same name to two different interfaces.
I've tried locally and it works just fine now :)
npm i<EMAIL_ADDRESS>

@JesusTheHun we've already updated to v7 😅


[BUG]  Security vulnerability in azure-storage-blob via third-party (netty-nio-client) CVE-2023-4586 #4584

Describe the bug
See https://security.snyk.io/vuln/SNYK-JAVA-IONETTY-1042268
and specifically the discussion at https://github.com/netty/netty/issues/10362.
OWASP dependency check lists this:
netty-transport-4.1.94.Final.jar: https://github.com/advisories/GHSA-57m8-f3v5-hm5m(7.4)
I need an explanation if you are using the library in the default unsecured way where HTTPS certificates are not validated OR if you add the proper flags to turn on HTTPS validation.
Furthermore, it would would also be helpful if someone could tell in what operations that this library is used and for what kind of HTTPS connections.
Security by default is state of the art and required by GDPR articles
32 and 25. Software libraries should ship with secure defaults.
Therefore Azure SDK should enable SSL/TLS hostname validation by default.
Netty will enable hostname validation by default for Netty 5:
https://github.com/netty/netty/issues/8537
Netty got security vulnerability notices because of this issue.
dependency tree:
[ESC[1;34mINFOESC[m] +- com.azure:azure-storage-blob:jar:12.23.0:compile
[ESC[1;34mINFOESC[m] |  +- com.azure:azure-core:jar:1.41.0:compile
[ESC[1;34mINFOESC[m] |  |  +- com.azure:azure-json:jar:1.0.1:compile
[ESC[1;34mINFOESC[m] |  |  +- (com.fasterxml.jackson.core:jackson-annotations:jar:2.13.5:compile - omitted for conflict with 2.15.0)
[ESC[1;34mINFOESC[m] |  |  +- (com.fasterxml.jackson.core:jackson-core:jar:2.13.5:compile - omitted for conflict with 2.15.0)
[ESC[1;34mINFOESC[m] |  |  +- (com.fasterxml.jackson.core:jackson-databind:jar:2.15.0:compile - version managed from 2.13.5; omitted for duplicate)
[ESC[1;34mINFOESC[m] |  |  +- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.13.5:compile
[ESC[1;34mINFOESC[m] |  |  |  +- (com.fasterxml.jackson.core:jackson-annotations:jar:2.13.5:compile - omitted for conflict with 2.15.0)
[ESC[1;34mINFOESC[m] |  |  |  +- (com.fasterxml.jackson.core:jackson-core:jar:2.13.5:compile - omitted for conflict with 2.15.0)
[ESC[1;34mINFOESC[m] |  |  |  \- (com.fasterxml.jackson.core:jackson-databind:jar:2.15.0:compile - version managed from 2.13.5; omitted for duplicate)
[ESC[1;34mINFOESC[m] |  |  +- (org.slf4j:slf4j-api:jar:1.7.30:compile - version managed from 1.7.36; omitted for duplicate)
[ESC[1;34mINFOESC[m] |  |  \- io.projectreactor:reactor-core:jar:3.4.30:compile
[ESC[1;34mINFOESC[m] |  |     \- (org.reactivestreams:reactive-streams:jar:1.0.4:compile - omitted for duplicate)
[ESC[1;34mINFOESC[m] |  +- com.azure:azure-core-http-netty:jar:1.13.5:compile
[ESC[1;34mINFOESC[m] |  |  +- (com.azure:azure-core:jar:1.41.0:compile - omitted for duplicate)
[ESC[1;34mINFOESC[m] |  |  +- (io.netty:netty-handler:jar:4.1.94.Final:compile - omitted for duplicate)

To Reproduce
Include this in your project and run owasp-dependency check:
            <dependency>
                <groupId>com.azure</groupId>
                <artifactId>azure-storage-blob</artifactId>
                <version>12.24.0</version>
            </dependency>

You can also manually in this projects pom.xml see that an old version of netty, 4.1.94.Final is used.
Setup (please complete the following information):
JDK version used

OpenJDK Runtime Environment (build <IP_ADDRESS>+1-Ubuntu-0ubuntu123.04)
Operating System and version
Ubuntu 24

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

Hey @profTwinglings thanks for reaching out; I'll let @alzimmermsft comment on this old 2020 bulletin, but in general for open source projects, please do not report potential security issues through GitHub issues - as repos often have a SECURITY.md in the root of the repo with instructions for responsible reporting (often with bug bounty programs for finders who responsibly disclose) -- https://github.com/Azure/azure-sdk-for-java/blob/main/SECURITY.md#reporting-security-issues -- just sharing best practices for next time - thanks!

Hi @profTwinglings, in the azure-core-http-netty package we don't use Netty directly but rather use it through Reactor Netty, which based on conversations in the linked Netty issue by the Reactor Netty developer this is hostname verification is enabled by default in Reactor Netty and we do not modify that behavior.
https://github.com/netty/netty/issues/8537#issuecomment-820928044

Hey @profTwinglings thanks for reaching out; I'll let @alzimmermsft comment on this old 2020 bulletin, but in general for open source projects, please do not report potential security issues through GitHub issues - as repos often have a SECURITY.md in the root of the repo with instructions for responsible reporting (often with bug bounty programs for finders who responsibly disclose) -- https://github.com/Azure/azure-sdk-for-java/blob/main/SECURITY.md#reporting-security-issues -- just sharing best practices for next time - thanks!

Thanks for the info, I actually saw that but ignored the bulletin (probably in error) since the CVE disclosure was already public and azure sdk was failing in automated vuln scan tests.
That usually means a bunch of people like me will come to this repo and search for the string "CVE-2023-4586" in issues. I could not find any and thats why I created this issue. Wouldnt it be nice to have a list of CVE's that are handled as False positives or patched in the issue or security list?
The tooling like owasp dependency-check will keep flagging netty forever, and people who use old versions for azure sdk will keep coming here looking for CVE-2023-4586 answers even if the underlying netty is upgraded t o 4.1.100.


Bans TODO

Load Site-Wide bans list, allow managing expiry, reasons etc
Also, maybe show my community-bans?

[ ] show list of current site-wide bans

[ ] when/if they expire
[ ] who applied them
[ ] reason/commentary

[ ] show list of bans by community that you mod

[ ] as admin, search communities/paginated list showing mods

get / ban users

https://join-lemmy.org/api/classes/LemmyHttp.html#getBannedPersons
✅ https://join-lemmy.org/api/classes/LemmyHttp.html#banFromCommunity
✅ https://join-lemmy.org/api/classes/LemmyHttp.html#banPerson

Ability to send warning PM to use direct from reports list
Ability to perform multi-action (send warning, remove content and temp ban user)

getBannedPersons require admin access so far i know.
The ideas to send warning pms could be a instance standard too. So if admins want the dming HAS to be done. It should have it automatically activated or deactivated. ( could be relating to #60 )

can be added to #121 - listing of community bans.


Font Size Small On Bootstrap 3.3

how to fix it, i get pickerjs small size on bootstrap 3.3

I got same bug, how do you resolved it ?

Just override the built-in font size:
.picker {
  /* font-size: 1rem; */
  font-size: 16px;
}


werd speld rong

Description
Please include a summary of the change and which issue is fixed or what was added to the project.
added the letter 'i'
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
looked at it
Checklist

[ ] My code follows the style guidelines of this project idk
[ ] I have performed a self-review of my own code no
[ ] I have commented my code, particularly in hard-to-understand areas absolutely not
[ ] I have made corresponding changes to the documentation technically
[ ] I have added tests that demonstrate the new feature or bugfix why would i
[ ] New and existing unit and integrations tests pass locally with my changes what does that even mean

Hi @treesgobark, thanks for looking over the code. You're right, most of those checkboxes only make sense for code changes. I’ll adjust the PR template to reflect that and have the checklist commented out by default or with a note that says to skip if not applicable when I’m off work today.
Changes look good. Remove the other two necessary sections in the description “How Has This Been Tested?” and “Checklist” and I’ll merge the PR later today.

Hey @treesgobark , looks like the PR checks are failing because there is no configured UNITY_LICENSE secret in your repo. I know the doc changes are alright because it's a fairly small change. I haven't tested merging in new changes from forked/external repos, I think it checks your repo for secrets instead of mine (which makes sense for security).
Here is the other change with the simplified pull request template - PR #191
I also created issue #192 for tracking setting up instructions on configuring the UNITY_LICENSE secret.
If you have any other questions or comments let me know! thanks for helping contribute to the project.


hotfix for pyam aggregation and filter in the wild

@zikolach has run into a few issues when trying to use pyam in the wild with unruly datasets. This hotfix patches some issues seen when certain functions are called with missing data. Specifically:

df.aggregate_region() now works as expected when the region-to-aggregate-to DNE in the dataframe already
df.filter() now does not error if df is empty

There is also an example test that can be implemented when aggregate_region() is updated as referenced in #255

Interestingly, this passes on my laptop, but not on my desktop...

the new test fails on my laptop with
        pd.testing.assert_frame_equal(obs.reset_index(drop=True),
>                                     exp.reset_index(drop=True))
E       AttributeError: 'memoryview' object has no attribute 'reset_index'

which is different from the error seen in CI. The offending line in CI passes.

As requested @danielhuppmann, each commit is self contained:

fa93e4b shows the original failure seen by @zikolach
2e835b8 fixes that error
6a812a7 fixes another related issue seen by @zikolach in the wild when trying to filter empty dataframes
c6685a7 provides two additional tests to confirm that behavior is now as @zikolach expects when doing region aggregation

Coverage decreased (-3.2%) to 87.869% when pulling 702c7ed01aab1327a3423ccf6ce2642f636396b8 on gidden:region-ag-hotfix2 into 5c3a1ee45152306a3bd66cb84181b37f0c8c24a1 on IAMconsortium:master.

@gidden can you please update PR according to @danielhuppmann? Or push it to origin and let me know so I can do it

Hi @zikolach, feel free to just PR into my remote. Once I pull it will be updated here as well.

@gidden I pushed a commit implementing @danielhuppmann suggestions. On my machine tests pass. Please rebase this PR as it has (trivial) conflicting changes in README.

Ok, fixed the merge conflict here. @danielhuppmann if this meets your approval, I think it should be g2g after CI.


[3.2.0-beta.2] Property 'isLoading' does not exist on type 'UseMutationResult

Hi,

HI @nghiepit! Thanks for reporting, the bools should be there now in 3.2.0-beta.3

try using isPending instead.


Fix DOMElement for retina screens

This fixes DOMElement for retina screens.
For example if you make your canvas retina aware like this:
var width = 900
var height = 400
var canvas = document.getElementById("canvas");
canvas.style.width = width
canvas.style.height = height
canvas.width = width * devicePixelRatio // value of devicePixelRatio can be seen in the code from BrowserDetect.getDeviceRatio()
canvas.height = height * devicePixelRatio

Then the Easel stage is rendered with crisp text and vector shapes on your retina screen, but DOMElement is positioned and scaled incorrectly.
This PR fixes that.

I am encountering this problem too. Can this pull request be accepted?

Can this pull request be accepted?

Is this available in the NextVersion ? I am also facing this issue.

Appreciate the PR -- but the implementation of an internal private class with one method is definitely non-standard. I would recommend just adding this as a method of DOMElement for now, and it might make sense to pull it out into a separate utility function/class (like utils/extend or any other single-method class in utils/).

I'll take a look at cleaning this up

@lannymcnie cleaned it up.
Finally worked out the formatting! :rofl:

@lannymcnie I am facing this retina issue. I see there are some conflicts. Can this be resolved?


Rate function added

This PR adds the Rate calculation function to go-financial (using Newton Rapson for the root calculation)

@gyanesh-m sorry to bother you but I think something is wrong with the CI. Do let me know when things are fixed so that I can continue with the PR

@thsubaku9 The pipeline is fine. There are errors in golangci-lint check. Run them locally using make lint-check. Make sure you have golangci-lint installed. If not, use make install-lint to install it.

Let me know if any more changes are required @gyanesh-m

@thsubaku9 will review the changes over weekend.

lets gooooooo @gyanesh-m

Lets go ? @gyanesh-m

Any updates here ? @krantideep95 @gyanesh-m  @ra0van

Hey @thsubaku9, I will review this over the coming weekend.

@thsubaku9 Thank you for adding this to go-financial ! 💯  🎉


Project proposal to move DCQL to OWF

Still need to add a sponsor, and want to get a review from @auer-martin first.

Hi @TimoGlastra, Wow your projects looks really great!

@TimoGlastra : Will you be available on January 8, 2025 to represent this proposal?

@TimoGlastra : Will you be available on January 8, 2025 to represent this proposal?

Yes, as long as it doesn't clash with the Wallet Interoperability SIG!

This should be the week of the offset meeting due to the TAC call. The SIG call would follow immediately after. See you on January 8. Have a good holiday period.

This should be the week of the offset meeting due to the TAC call. The SIG call would follow immediately after. See you on January 8. Have a good holiday period.

Perfect, thanks. You too 🎅

I did not see any DCO on the commits. This will also need to be updated prior to bringing it over to OWF. Otherwise, this looks like an interesting lab, and I approve it.

I think it's for the suggestions i comitted. Once ready to merge based on feedback i'll squash everything

I did not see any DCO on the commits. This will also need to be updated prior to bringing it over to OWF. Otherwise, this looks like an interesting lab, and I approve it.

I think it's for the suggestions i comitted. Once ready to merge based on feedback i'll squash everything

This was related to the project repo, not this PR. Just to be sure we are on the same page.

Something I'd like input on: @marsouin @auer-martin and I have been chatting on a PEX light library that will be very similar in design as this DCQL library. Should we propose this as a separate lab project? Can it fall under this one and we make it "credential query languages typescript" project (but still two repositories)?

I did not see any DCO on the commits. This will also need to be updated prior to bringing it over to OWF. Otherwise, this looks like an interesting lab, and I approve it.

I think it's for the suggestions i comitted. Once ready to merge based on feedback i'll squash everything

This was related to the project repo, not this PR. Just to be sure we are on the same page.

Misunderstood you there, opened an issue: https://github.com/auer-martin/dcql/issues/25

Something I'd like input on during the TAC WG or here: I've been chatting with @marsouin and @auer-martin a PEX light library that will be very similar in design as this DCQL library. Should we propose this as a separate lab project? Can it fall under this one and we make it "credential query languages typescript" project (but still two repositories)?

A single lab can have multiple repositories. We typically use some sort of prefix to group the repos. Something like "CQL-repo1" and "CQL-repo2". We would just need to determine the correct prefix, which should be based on the name of the lab.

I'll be looking at the dco and the other issues in the dcql repository over the weekend


IndexAxis and scale options conflict for horizontal bar

Expected Behavior
I need to draw an horizontal bar, therefore, following the documentation, I can set indexAxis at dataset level (or also at options level, even if not documented yet):
{
    type: 'bar',
    data: {
        labels: ["Jan", "Feb", "Mar", "Apr", "May"],
        datasets: [{
            indexAxis: 'y', // <-- for this dataset
            ....
        }]
    },
    options: {
        indexAxis: 'y', // <-- for all dataset
        ...
    }
}

My expectation is that adding scales configuration, the chart is shown.
{
    type: 'bar',
    data: {
        labels: ["Jan", "Feb", "Mar", "Apr", "May"],
        datasets: [{
            indexAxis: 'y', // <-- for this dataset
            ....
        }]
    },
    options: {
        indexAxis: 'y', // <-- for all dataset
        ...,
        scales: {
            y: {
               axis: 'x',
               .....
            }
        }
    }
}

Current Behavior
If you add a scale configuration, the chart is broken.
Here is a table with different options matrix and the result:

Options IndexAxis
Dataset IndexAxis
Scale Id
Scale Axis
Result

'y'
undefined
undefined
undefined
works

'y'
'y'
undefined
undefined
works

undefined
'y'
undefined
undefined
works

'y'
undefined
'y'
undefined
works

'y'
undefined
'y'
'x'
works

'y'
'y'
'y'
undefined
works

'y'
'y'
'y'
'x'
works

undefined
'y'
'y'
undefined
doesn't work

undefined
'y'
'y'
'x'
doesn't work

Possible Solution
It seems that when the indexAxis is set into a dataset and only there, the scale is not correctly recognized.
Steps to Reproduce
Codepen: https://codepen.io/stockinail/pen/yLJVvrB
Environment

Chart.js version: dist/master
Browser name and version: FF 82.0

The reason:
You have specified bar as top level chart type. Bar charts default to category scale for indexAxis and linear scale for value axis.
The chart first constructs and makes sure we have valid scales for the given id. 'y' - axis scale is defined and by default that would be linear scale. so that scale is configured as linear.
Now, looking at datasets, the first one is missing a scale for x-axis. That is a bar, but indexAxis is y, so x is a valuescale. Scale for x-axis is created as linear.
So both scales end up being linear, but the labels are strings and linear does not work with those.
Workarounds

Add type: 'category' to the y-axis scale
Change labels to numbers
Use object data and no labels (still need to have valid data for the scales)

Thoughts
I'd expect users to have explicit scale definitions if they define indexAxis per dataset.

@kurkle Thank you very much! Very helpful because I recognized I forgot the type.... Azz....


Users believe that the requirements for identity verification are unusually stringent and long winded for a concessionary travel pass

This is a duplicate of #190.


feat(header): Pass count of current refined filters in header

Partially fixes #1013
The goal of the PR was to make the count variable accessible to the
header template of the refinementList widget. This count is the
number of active filters applied to the facet.

(I click on the header in this demo to show that it works with collapsible as well)
        templates: {
          header: (data) => {
            if (data.count === 0) {
              return `<h3 class="facet--title">Teams</h3>`;
            }
            return `<h3 class="facet--title">Teams (${data.count})</h3>`;
          }
        },

To do so the first step was to make the header template dynamic.
Before the PR, it was static, meaning that it was defined at the
widget init and never updated. I changed that part so the header
template is re-rendered on every render of its component.
It also meant that I had to remove the custom shouldComponentUpdate
method. The method was checking if the component was collapsed or not
before triggering the render. As we now always need to update the
render of the header, being collapsed or not, I removed the check.
I think it might even fix #1041 as well.
To pass template data to the header, you now need to pass the
headerFooterData prop to the component that is wrapped by
headerFooterHOC. It's an object with a key header containing the
data you want to pass. It could also potentially have a key
footer, but the footer part is not implemented yet because we had no
need for it.
Improvements and discussions:

The footer template is still static. It would be trivial to set it
as dynamic, but I left it like this until we have a use-case.
Only the refinementList widget takes advantage of this feature. It
would not be too hard to pass dynamic data to headers in other
widgets, but I left that to other PRs.
I will tackle the other issue of adding a CSS class on the root on
another PR.

The method was checking if the component was collapsed or not
before triggering the render

Some websites are using collapsing widgets to be able to have a lot of widgets without messing up the display. Thus always rendering widgets was not efficient since a lot of them were collapsed.

As we now always need to update the
render of the header, being collapsed or not

We only need to update it when the active count has changed right? We should find a way to not render the widget if no values were updated. Unsure that's doable.

Do you have other naming ideas for "count"? Maybe "activeFacetsValues" or smg adding context to what is the count about.

Some websites are using collapsing widgets to be able to have a lot of widgets without messing up the display. Thus always rendering widgets was not efficient since a lot of them were collapsed.

Maybe we should not use the shouldComponentUpdate for that then. Maybe just not render the ComposedComponent when it is collapsed.

Do you have other naming ideas for "count"? Maybe "activeFacetsValues" or smg adding context to what is the count about.

I had the same question, but I settled for count because this is what we use in the RefinementListItem, but I'm ok changing. Especially considering this is the number of currently selected facets, not the count of hits for thoses facets. So maybe refinedFacetsCount? We already use isRefined in the RefinementList template.

So maybe refinedFacetsCount?

This seems better yes!

@pixelastic small changes needed before merging

Merging, will do the small changes afterwards


TinaCms Edit Text Error

Hi;
Creating a space in vercel to use the theme today. I seem to get an error in the blog section when I do it on TinaCms
``Tina caught an error while updating the page:
Cannot read properties of null (reading 'getPostsDocument')
If you've just updated the form, undo your most recent changes and click "refresh". If after a few refreshes, you're still encountering this error. There is a bigger issue with the site. Please reach out to your site admin.``

Same here


mautrix-telegram: add inputs for E2BE support (#132979)

https://docs.mau.fi/bridges/general/end-to-bridge-encryption.html
(cherry picked from commit f1d1ed4f0221d89d5e221c26114a14fe138e8982)

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 133002 at 43dfea0f run on aarch64-linux 1

1 package built successfully:

mautrix-telegram

3 suggestions:

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/servers/mautrix-telegram/default.nix:26:46:
   |
26 |   patches = [ ./0001-Re-add-entrypoint.patch ./0002-Don-t-depend-on-pytest-runner.patch ];
   |                                              ^

warning: python-include-tests
Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.
Near pkgs/servers/mautrix-telegram/default.nix:77:0:
   |
77 |     description = "A Matrix-Telegram hybrid puppeting/relaybot bridge";
   | ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/servers/mautrix-telegram/default.nix:26:15:
   |
26 |   patches = [ ./0001-Re-add-entrypoint.patch ./0002-Don-t-depend-on-pytest-runner.patch ];
   |               ^


Windows: Support for stats (docker #25737)

Signed-off-by: John Howard<EMAIL_ADDRESS>Adds support for docker stats on Windows. See https://github.com/docker/docker/pull/25737 for detailed information.

ping @docker/core-engine-api-maintainers

LGTM 🐮

The matching docker PR https://github.com/docker/docker/pull/25737 is all green :green_heart: now and just waiting for this to be merged so it can be rebased.

Closing now engine-api is back in docker.