Ftps proxy error

As requested in https://issues.apache.org/jira/browse/NET-718
FYI @garydgregory

I'm OK with it.

Hm, I can't get the reproducer to work.
WARN[0000] /Users/garydgregory/git/commons-net/docker-compose.yml: `version` is obsolete
[+] Running 11/11
 ✔ ftp Pulled                                                                                11.3s
   ✔ b4d181a07f80 Pull complete                                                                                8.0s
   ✔ e98cb485cfd8 Pull complete                                                                                9.9s
   ✔ 0822c77e0e0b Pull complete                                                                                10.0s
   ✔ 8588bb5b4480 Pull complete                                                                                10.1s
   ✔ a41cb6218cc9 Pull complete                                                                                10.1s
   ✔ 7ac94abef10b Pull complete                                                                                10.1s
   ✔ 8d5dc14fad00 Pull complete                                                                                10.1s
   ✔ 417d6be4b5ec Pull complete                                                                                10.2s
   ✔ 71cd100c9ec0 Pull complete                                                                                10.2s
   ✔ 227193214c34 Pull complete                                                                                10.2s
[+] Running 2/2
 ✔ Network commons-net_default  Created                                                                                0.1s
 ✔ Container commons-net-ftp-1  Created                                                                                0.8s
Attaching to ftp-1
ftp-1  | Creating user...
ftp-1  | Password:
ftp-1  | Enter it again:
ftp-1  |  root user give /home/username directory 2000 owner
ftp-1  | Setting default port range to: 30000:30009
ftp-1  | Setting default max clients to: 5
ftp-1  | Setting default max connections per ip to: 5
ftp-1  | Starting Pure-FTPd:
ftp-1  |   pure-ftpd  -l puredb:/etc/pure-ftpd/pureftpd.pdb -E -j -R -P localhost --tls=1  -p 30000:30009 -c 5 -C 5

and running the using test cannot connect:
java.net.ConnectException: Connection refused (Connection refused)
	at java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
	at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
	at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
	at java.net.Socket.connect(Socket.java:607)
	at sun.net.NetworkClient.doConnect(NetworkClient.java:175)
	at sun.net.www.http.HttpClient.openServer(HttpClient.java:463)
	at sun.net.www.http.HttpClient$1.run(HttpClient.java:515)
	at sun.net.www.http.HttpClient$1.run(HttpClient.java:513)
	at java.security.AccessController.doPrivileged(Native Method)
	at sun.net.www.http.HttpClient.privilegedOpenServer(HttpClient.java:512)
	at sun.net.www.http.HttpClient.openServer(HttpClient.java:553)
	at sun.net.www.http.HttpClient.<init>(HttpClient.java:242)
	at sun.net.www.http.HttpClient.New(HttpClient.java:339)
	at sun.net.www.http.HttpClient.New(HttpClient.java:357)
	at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1228)
	at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1207)
	at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1056)
	at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:990)
	at java.net.HttpConnectSocketImpl.doTunnel(HttpConnectSocketImpl.java:167)
	at java.net.HttpConnectSocketImpl.access$200(HttpConnectSocketImpl.java:44)
	at java.net.HttpConnectSocketImpl$2.run(HttpConnectSocketImpl.java:151)
	at java.net.HttpConnectSocketImpl$2.run(HttpConnectSocketImpl.java:149)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.HttpConnectSocketImpl.privilegedDoTunnel(HttpConnectSocketImpl.java:148)
	at java.net.HttpConnectSocketImpl.connect(HttpConnectSocketImpl.java:111)
	at java.net.Socket.connect(Socket.java:607)
	at org.apache.commons.net.SocketClient._connect(SocketClient.java:141)
	at org.apache.commons.net.SocketClient.connect(SocketClient.java:308)
	at org.apache.commons.net.SocketClient.connect(SocketClient.java:290)
	at org.apache.commons.net.ftp.FTPSProxyClientTest.testListFiles(FTPSProxyClientTest.java:84)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:750)

I tried the test myself on my mac and I'm getting an issue with the SSL handshake due to a cert having expired.
I suspect the pem file that is part of this PR was generated a while ago and the cert that the PEM contains has expired. It could be something else though.
javax.net.ssl.SSLHandshakeException: NotAfter: Wed Apr 24 07:36:56 IST 2024
	at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:131)
	at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:360)
	at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:303)
	at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:298)
	at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.checkServerCerts(CertificateMessage.java:1357)
	at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.onConsumeCertificate(CertificateMessage.java:1232)
	at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.consume(CertificateMessage.java:1175)
	at java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:392)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:443)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:421)
	at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:183)
	at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:172)
	at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1511)
	at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1421)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:456)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:427)
	at org.apache.commons.net.ftp.FTPSClient.sslNegotiation(FTPSClient.java:1120)

I got the test to run on my mac by regenerating the pem file.
openssl req -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem -sha256 -days 3650 -nodes -subj "/C=XX/ST=StateName/L=CityName/O=CompanyName/OU=CompanySectionName/CN=CommonNameOrHostname"

key.pem  and cert.pem are then manually merged to created pure-ftp.pem
The tests failed as expected with this change and when I applied potential solution b in https://github.com/apache/commons-net/pull/154/files#diff-cbb58f257b18c23645163433a3a2f989d76df71e55c5a2ac77bba86ed4540215

Yeah, I'm not even getting that far, the test can't seem to connect. Maybe the port is misconfigured?

Yeah, I'm not even getting that far, the test can't seem to connect. Maybe the port is misconfigured?

Do you have Squid running?

I followed the Homebrew instructions...

But what's confusing is that it's not clear (to me) if you need the Docker part of the setup on macOS. If I could get clear macOS instructions that would help ...


module 'tensorflow' has no attribute 'AUTO_REUSE'

File "run_eval.py", line 16, in
from vae.models import ConvVAE, MlpVAE
File "C:\CARLA_0.9.13\PythonAPI\examples\Trials\RL\Carla-ppo\vae\models.py", line 33, in
class VAE():
File "C:\CARLA_0.9.13\PythonAPI\examples\Trials\RL\Carla-ppo\vae\models.py", line 40, in VAE
model_dir=".", loss_fn=bce_loss, training=True, reuse=tf.AUTO_REUSE,
AttributeError: module 'tensorflow' has no attribute 'AUTO_REUSE'

You may have installed tensorflow.v2 use v1 instead or call it like this tf.compat.v1.AUTO_REUSE


toggle comment shortcut

Doesn't Ctrl+K already do this?

https://github.com/godotengine/godot/blob/07b76c0376eef34fcbf52ecc21074c5084f980f5/editor/plugins/script_text_editor.cpp#L1515
I guess ScriptTextEditor is different than the CodeEditor, but I imagine the default shortcuts should be the same. I know Ctrl+/ is pretty standard, I wonder why Ctrl+K is used in the script editor
Sorry for the off topic comment

I'm not sure what this does which is not already supported with the Ctrl+K toggle comment hotkey?
@Paulb23's comment needs to be addressed in any case, and the commits should be squashed together with a clearer commit log for the final commit.

Closing as per the above, the feature already exists via toggle_inline_comment so it should be expanded to support what is needed in #22177.


Provide more detailed errors on missing/invalid properties

Codecov Report

Merging #537 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #537   +/-   ##
=======================================
  Coverage   93.61%   93.61%
=======================================
  Files         216      216
  Lines        7738     7725   -13
=======================================
- Hits         7244     7232   -12
+ Misses        494      493    -1

Flag
Coverage Δ

#dotnet
93.61% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Bicep.Core/TypeSystem/UnionType.cs
100.00% <ø> (+4.76%)
:arrow_up:

...ests/TypeSystem/TypeValidatorAssignabilityTests.cs
100.00% <100.00%> (ø)

src/Bicep.Core/Diagnostics/DiagnosticBuilder.cs
100.00% <100.00%> (ø)

...c/Bicep.Core/TypeSystem/DiscriminatedObjectType.cs
95.00% <100.00%> (ø)

src/Bicep.Core/TypeSystem/TypeAssignmentVisitor.cs
98.91% <100.00%> (+<0.01%)
:arrow_up:

src/Bicep.Core/TypeSystem/TypeValidator.cs
95.23% <100.00%> (+0.15%)
:arrow_up:

src/Bicep.Cli.UnitTests/PathHelperTests.cs
100.00% <0.00%> (ø)

Looks good, but you should probably add tests at some point. There weren't any test changes with the latest commit.

This is just because we don't assert the error code in the baseline (*.diagnostics.bicep) files - I'll make this change in a separate PR.


Optimize Footer component for cleaner structure and performance

Description: This pull request refactors the Footer component to enhance code structure and improve performance. Key updates include:
Streamlined HTML and CSS for better readability and efficiency.
Updated link structure and accessibility labels.
Removed unused or commented-out code for clarity.
Changes Made:
Simplified the JSX structure in the Footer component.
Optimized imports and reduced dependencies.
Improved link accessibility by adding aria labels and semantic structure.
Testing: Verified that all links and button actions function correctly, and layout remains responsive across screen sizes.

@abhayjoshi201 were you assigned to any of the active issues?

@abhayjoshi201 were you assigned to any of the active issues?

No

Sorry, @abhayjoshi201, I won’t be able to accept this PR. Please get assigned to an issue first before creating a PR.


[GLUTEN-1382][CH] Bug fix core happen while select max(NULL)/min(NULL)

What changes were proposed in this pull request?
Bug fix core while select max(NULL)/min(NULL)
(Fixes: #1382)
How was this patch tested?
unit tests / manual tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

please add test case

Hello, the unit test hase been added in GlutenClickHouseTPCHSuite.scala, thanks.

cc @liuneng1994


Add auth reversals

docs say:

For American Express transactions, the reversal amount must match the
authorization amount. Partial reversals and reversals against remaining
amount after a partial capture are not allowed. Attempts to perform these
types of reversals result in a Response Code of 336 - Reversal amount
does not match Authorization amount.

I tested this behavior using their amex test cards and it doesn't seem to be true anymore. Wanted to throw that up here to make sure i'm not missing anything or doing something dumb.


if an installed gem is missing from the global gem cache, "bundle (install | package)" fails to update vendor/cache

Could not find {gem file} for installation
if something is missing from the cache, it should download it, not fail

Can you please provide a Gemfile or an error report? More explicit steps to reproduce this issue? More description of the issue itself? More information is needed.

if you have a local vendor cache ({project_root}/vendor/cache), both bundle install and bundle package, will try to update it.  If you add a gem to the Gemfile, which is already gem installed but happens to missing from the global gem cache (delete the gem file from the global cache to repro), both commands will fail with "Could not find {gem file} for installation"
A cache should be refillable on demand form upstream.

Closing because we never got a Gemfile nor a bundle env to be able to reproduce.


delegate(); proposed observer-modification for witholding events/transforming to any type

I've struggled to find the equivalent to map(), but where it's feasible to omit a value from the downstream, dispatch an error into the downstream or end it. It may be that there's a way to make map() or some other method() do this, but I can't find any documentation about it.
I find I often am doing a map() then a filter() for example, where both are duplicating the same unmarshalling work, but one is modifying the events, and the other is witholding selected events, which seems messy. In neither case can you introduce an error or an end. An alternative is to create a Kefir.stream(...) as described below but this is also quite messy for what I would expect is a common sort of operation.
Have I overlooked an obvious way to do this using a minimal transform from the api?  Here's some pseudo-code for what I intend...
var modifiedStream = Kefir.fromEvents(nodeServer, "eventType").delegate(function(value, emitter){
    var type = typeof value;
    if(type==="string"){
        emitter.emit(value);
    }
    else if(value===null){
        emitter.end();
    }
    else{
        emitter.error("Unexpected type: " + type);
    }
});

It might turn out more or less the same as the following from a behaviour/implementation point of view.
var sourceStream = Kefir.fromEvents(nodeServer, "eventType");
var modifiedStream = Kefir.stream(function(emitter){
    var handler = function(value){
        var type = typeof value;
        if(type==="string"){
            emitter.emit(value);
        }
        else if(value===null){
            emitter.end();
        }
        else{
            emitter.error("Unexpected type: " + type);
        }
    };

    sourceStream.onValue(handler);

    return function(){
        sourceStream.offValue(handler);
    }

})

Having an API implementation of this would avoid some closures and unnecessary name-pollution for what would otherwise be an anonymous source stream with a transparently-subscribed and unsubscribed handler. For many simpler cases it would be significantly more terse.
Having an API implementation would also ensure sufficiently smart intervention for triggering unsubscription from the source stream in case of the modified stream sending an end (I don't know if unsubscribe is automatically triggered in this case and unsubscription would certainly be needed here to prevent memory leaks).

Hey!
Didn't look closely yet, but maybe .withHandler is what you need? Except it pushes all events to the handler (not only values, but also errors and end).

Another approach is to use .takeWhile + .flatMap:
var modifiedStream = Kefir.fromEvents(nodeServer, "eventType")
.takeWhile(function(value){
  return value !== null;
})
.flatMap(function(value){
    var type = typeof value;
    if(type==="string"){
        return Kefir.constant(value);
    }
    return Kefir.constantError("Unexpected type: " + type);
});

I'd probably do it this way.

I haven't yet used withHandler, so that's a very useful pointer and pretty close to what I want from a callback point of view so thanks for the suggestion.
I am guessing this eliminates the complexity of having to manage unsubscription (e.g. source unsubscription is automatic when an emitter.end() is sent downstream?).
However perhaps more importantly for every case I've needed it so far, it's an onValue which I want to respond to, so I fear withHandler is going to have a lot of unmarshalling in the handler function which will be verbose and error prone if I have to reimplement this every time.
If I was to use withHandler to achieve the API signature and minimal object allocation I was hoping for without embedding it in the handler function, I'd need a filter() to eliminate any error or end, as well as a map() to unmarshall values from the onAny format to get to the the API simplicity of the 'delegate' pseudo-code I shared, which (perhaps not surprisingly) exactly the problem I started with.
I wondered about using flatMap in the way you showed, but I was concerned about the allocation overhead, hence the interest in an API-native routing through a minimal handler function which is triggered only on values.
"delegate" is a terrible name, perhaps withValueHandler(emitter, value) captures better what I was hoping for, suggesting that an error or end from the source stream is passed through untouched by the transform? Going down that route, it would be feasible to have a withErrorHandler(emitter, value) and a withEndHandler(emitter, value) for symmetry.
I appreciate the implementation you've shared for the case I mentioned, but it was more of an illustration of the kind of signature I aspire to than a real case. It's good to see elegant answers like this as it helps me reflect on my own use of Kefir.
In the short term I think I might follow this flatMap() and .constantX() strategy as you showed. It's better than my current alternative, is terse and functional, and I think covers the immediate cases I need, although I feel the withValueHandler approach is likely to be more efficient and powerful for a number of cases (e.g. marshalling more than one event arising from a single source event possibly embedded in different logic blocks is a challenge through flatMap).

source unsubscription is automatic when an emitter.end() is sent downstream?

Yeah, it automatic in .withHandler, and more general when a stream ends it always unsubscribes from all sources.

I wondered about using flatMap in the way you showed, but I was concerned about the allocation overhead

I wouldn't worry about that. Kefir is very optimized for .flatMap(x => Kefir.constat*(...)) pattern, it almost as fast as .map(f) (about ~1.5 times slower according to the benchmark).

I appreciate the implementation you've shared for the case I mentioned, but it was more of an illustration of the kind of signature I aspire to than a real case.

Right, but we need real cases when such method would be useful to consider adding it.
I also more like flatMap-like solutions for this kind of problems, because they are closer to declarative/functional style, while withHandler / delegate / manual calling emitter methods from an onValue callback — is more imperative. I think this stuff should be like the last resort, when flatMap and others doesn't work.


Game Crashes When Put Steam Engine on Ship

crash-2017-06-24_11.12.20-server.txt
used forge 2351

and ah, it also crashes while trying to rename the ship
crash-2017-06-24_11.14.23-server.txt

Sounds like an issue with syncing ship data, is this on a dedicated server or just a client?

just client

Hmm, can't reproduce that but did find a different issue. Going to fix that and see if that helps with your issue as it may be related.

i hope it be fixed.

@kenijey attempt what you did with this MovingWorld build, https://ci.elytradev.com/job/elytra/job/MovingWorld/job/1.12/12/artifact/build/libs/movingworld-1.12-1.334-full.jar

Ah wait, I see what's wrong. The accesstransformer isn't being loaded. Forge may have implemented their signature checks.

game won't even start with build 1.334.
you can reproduce

and i just wonder why did you put the old texture to the secured bed(item)? there's new bed texture in 1.12 for inventory item.

and i just wonder why did you put the old texture to the secured bed(item)? there's new bed texture in 1.12 for inventory item.

The secured bed item texture is different, the feet are a different colour. I bundle the old block textures so the old model will still work. I don't plan on making secured beds dyeable any time soon.

no need for dyeable secured beds but you may select a unique texture for that bed. it would not be bad.
btw, forge is updated right now, you may want to see the changelog

Can you give me the error for the game crashing on the last build?

crash-2017-06-24_11.46.38-client.txt

It's not bunding Concrete....

@kenijey I'm off to bed, I've updated the builds on Curse. Give them a try and close the issue if your problem is resolved.

hold on, should i install moving world library too?
if i should, it doesn't let me install both mods. it says mods are duplicated in your mods folder.

Install both the recent builds of both mods on curse.
On Jun 24, 2017 3:12 AM, "Keny"<EMAIL_ADDRESS>wrote:

hold on, should i install moving world library too?
if i should, it doesn't let me install both mods. it says mods are
duplicated in your mods folder.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/elytra/DavincisVessels/issues/145#issuecomment-310829822,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABusJNzVYs6EjWcPFqPGffN6YQLrio32ks5sHOD8gaJpZM4OEQzW
.

okay it works fine now.
let me suggest a thing, can you add submarines? it would be lovely. you can add check for is the inside completely closed by outside.

Submarines are already in the mod. Please see the wiki.


chore: update yarn version

Update yarn to latest version

Coverage remained the same at 81.785% when pulling 61cec6500d4425d6de31683ceee326cdf8344e58 on update_yarn_version into a14fda92d546abdafbf947dbea961ffbaa243e0d on master.


16 refactoring compress ziparchive

Renamed -DestinationPath to -Destination and alias added.

Codecov Report

Merging #17 (92a78f2) into main (4145e48) will decrease coverage by 1.86%.
The diff coverage is 84.61%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   85.94%   84.09%   -1.86%
==========================================
  Files          25       27       +2
  Lines        1167     1339     +172
==========================================
+ Hits         1003     1126     +123
- Misses        164      213      +49

Flag
Coverage Δ

PS_5.1
84.09% <84.61%> (-0.92%)
:arrow_down:

PS_7_Windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/PSCompression/ExcetionHelpers.cs
66.66% <0.00%> (-19.05%)
:arrow_down:

src/PSCompression/PathExtensions.cs
90.00% <66.66%> (ø)

...SCompression/Commands/CompressZipArchiveCommand.cs
84.24% <84.24%> (ø)

src/PSCompression/ZipEntryExtensions.cs
91.30% <91.30%> (ø)

...Compression/Commands/CompressGzipArchiveCommand.cs
73.46% <100.00%> (+0.55%)
:arrow_up:

... and 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Implement vector search  POC

Implements #136

Do we want to include data-encoder/ecommerce/vectors/data/1.json files in the repo?   Worth zipping them?  Or just not worry about it for now?

Do we want to include data-encoder/ecommerce/vectors/data/1.json files in the repo?  Worth zipping them? Or just not worry about it for now?

The files aren't too large but I think we should still zip them

Do we want to include data-encoder/ecommerce/vectors/data/1.json files in the repo?  Worth zipping them? Or just not worry about it for now?

The files aren't too large but I think we should still zip them

Done.   It looks easy to read in the json file from a zip for the future.


Close Date picker only after selecting both dates.

Hi,
Is there a way to close DatePicker only after the user selects both dates (start & end date)
Currently, if i use shouldCloseOnSelect={false}, the datepicker remains open, but i want to close it after selecting 2nd date.

Try shouldCloseOnSelect={startDate && !endDate}.

Try shouldCloseOnSelect={startDate && !endDate}.

It worked. Thanks. :)

Try shouldCloseOnSelect={startDate && !endDate}.

It worked. Thanks. :)

7

Try shouldCloseOnSelect={startDate && !endDate}.

It worked. Thanks. :)

7

Try shouldCloseOnSelect={startDate && !endDate}.

It worked. Thanks. :)


Dev

Pull Request Test Coverage Report for Build 831

0 of 0   changed or added relevant lines in 0 files are covered.
12 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 83.882%

Files with Coverage Reduction
New Missed Lines
%

file:/home/travis/build/kit-data-manager/base-repo/src/main/java/edu/kit/datamanager/repo/service/impl/ContentInformationService.java
12
82.97%

Totals

Change from base Build 786:
0.0%

Covered Lines:
1759

Relevant Lines:
2097

💛  - Coveralls

Pull Request Test Coverage Report for Build 831

0 of 0   changed or added relevant lines in 0 files are covered.
12 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 83.882%

Files with Coverage Reduction
New Missed Lines
%

file:/home/travis/build/kit-data-manager/base-repo/src/main/java/edu/kit/datamanager/repo/service/impl/ContentInformationService.java
12
82.97%

Totals

Change from base Build 786:
0.0%

Covered Lines:
1759

Relevant Lines:
2097

💛  - Coveralls


Issue to counting

Current Behavior
Don't have the right amount on scan
Expected Behavior
The scanner to correctly exports the data
Reproducing a Behavior
Just Use normaly
Device OS
Windows 10
Genshin Impact Version
4.5
Inventory Kamera Version
3.15
Screen resolution, screen mode, and UI scale
1600x900 / 1920x1080 / 2560x1440
Additional notes and remarks
No response
Evidence

Preflight Checklist

[X] I have checked for similar issues in the issue page, and I have not found any similar to mine.
[X] I am using the latest version of the scanner.
[X] I tried setting the scanning delay to maximum, and it still doesn't work.
[ ] I have attached the video recording to the bug report.
[ ] I have attached the error log to the bug report.
[X] I am available to later explains the issue.
[X] I have disabled (or documented) all screen filtering software, plugins, and enhancements while scanning.
[X] I use default in-game keybindings or have configured keybindings for the scanner.

Material quantity scanning is known to be a bit shoddy and is a tracked issue already


rayon works very slow after MacOS Sonoma 14.4 has beed updated

My program needs high parallel, and I use rayon v1.9.0 to make the data parallel processing.
It works nicely in the previous version of MacOS Sonoma, but after I updated it to Sonoma 14.4, everything slowed down.
The underlying schedule of the parallel mechanism seems to have changed in Sonoma 14.4.
This may not be the problem of rayon. Is there anyone met this problem too?

I found the reason may relate to the competition for CPU resources between the work-stealing strategy of rayon and the system.
Again, note that Everything worked well on the previous MacOS before Sonoma 14.4.
When not manually setting the num_threads(...), the default num_threads is 14 (m3 max 14 + 16). In this case, the system will "rob" the CPU resources back, and the "robbing" itself is costly.
Then I limited the num_threads to 4 as follows:
rayon::ThreadPoolBuilder::new().num_threads(4).build_global().unwrap();

The system is still "robbing", but the user process can use these 4 threads most of the time. And in my program's case, the performance improves although it's still much slower than before.

That's worrisome, but I'm afraid I don't have any Apple hardware to test this myself. Hopefully others in the community can share their experience and help debug what's going on.
One small tip -- if you haven't set num_threads manually, the RAYON_NUM_THREADS environment variable will also override the default setting.

I think the problem is not related to rayon.
https://github.com/0xPolygonZero/plonky2/issues/1553#issuecomment-2002456724

I think you'll need to figure out what that System time is actually doing, because that looks pathological. Does Xcode profiling or anything like that reveal System details?

I think you'll need to figure out what that System time is actually doing, because that looks pathological. Does Xcode profiling or anything like that reveal System details?

Now I just checked the information in the activity monitor, and as you said, there were pathological and conflict phenomena.
The picture reveals the system takes the CPU resources away, but the cost of each process shows it's my process that takes the most CPU resources. But I'm sure that my process is slowed down so the CPU resources are not computing it.
Anyway, I will look into this problem more deeply soon according to your suggestion.

Things are clearer.
I made a deeper profiling and found that with a higher parallel, my process needs more memory, and then the security checking in the kernel is raised, which is costly.
This might be confirmed by https://appleinsider.com/articles/24/03/21/apple-silicon-vulnerability-leaks-encryption-keys-and-cant-be-patched-easily
Luckily, rayon still works well.


Revert "Handle pricing api change in aws-sdk-go 1.44.46

Description of changes:
Reverts #140, because the price API change was reverted in https://github.com/aws/aws-sdk-go/issues/4480.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/cc @AustinSiu @bwagner5


Plugin API

After 2.1 is released we should start to define a plugin API. This might involve:

documentation
re-exporting officially public functions for plugins in a shim module
breaking existing plugins. as there is no official plugin API yet, this may be inevitable, but should be avoided or handled with versioning and proper communication.

@ferd has the rebar3 fork implemented this (including a built-in registry of well-known plugins to enable automatically)?

@ferd has the rebar3 fork implemented this (including a built-in registry of well-known plugins to use if available and required)?

Not yet. We have the shim module (somewhat partial without enough warning) and docs, but no registry at this time; it's a task for beta/3.0.0.

Is this still relevant given rebar3's advances in the meantime?

We do have a better-defined plugin API for rebar3, but I think it still needs expanding to avoid having people depend too much on the internals. I'm not sure how much we expect rebar 2.x's plugins to evolve in the upcoming years though. I'd say it's probably stable now.

@ferd, that's what I intended a shim module to be for: define one or more plugin API modules which expose things in a stable fashion, leaving anything else as internal.
I'd say we can close this, but if rebar3's plugin API doesn't promise stability (yet), maybe we ought to wait with that.

Yes, we do have a rebar_api module, and that's what I meant by 'needs expanding'; adding functions to it. Closing this, as we should have stability by 3.0.0, which should be increasingly soon now.


SILVerifier: turn on the ownership verifier again

It was turned off by mistake

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test


Anilist integration for syncing progress

Is your feature request related to a problem? Please describe.
when I finish my reading session using the read option, I need to either manually go to anilist's website and update my reading progress there or use an external custom script which makes a post request to anilist's api with my tokens
Describe the solution you'd like
if possible, i would like a solution integrated withing this project itself
Describe alternatives you've considered
Anilist's website manually or external custom script

That's a cool idea! I think I'll be able to make it. But I'm not sure how to handle situations where manga found on Anilist does not match the one selected in Mangal
Example

I think I could check if two titles are "similar" by using something like Levenshtein distance 🤔

so i've looked further into it, and tried to see if it could be done through matching the author's name, but neither anilist nor kitsu's api have that info, so this is all i was able to do, if that helps:
import requests

query = '''
query ($id: Int, $search: String) {
  Page(page: 1, perPage: 10) {
      pageInfo {
        total
        perPage
        }
    media(id: $id, search: $search, format: MANGA) {
        id
        idMal
        format
        title {
            romaji
            english
            native
            userPreferred
        }
    }
  }
}
'''

variables = {
    'search': 'Death Note',
}

url = 'https://graphql.anilist.co'

response = requests.post(url, json={'query': query, 'variables': variables})

print(response.json())

but then again, it'll come down to Levenshtein distance

The android application Tachiyomi, which can be found https://github.com/tachiyomiorg/tachiyomi, solves this issue by adding a sync setting per series in the saved library of a user. After connecting your anilist to tachiyomi, when you open a series page in the app there is a tracker that you can set for anilist (or which ever tracking catalogue service you use, like MAL), and then it will do a query in Anilist with the title of series. You can even edit the query as well. This query will show all the results that anilist pulls up, and you the user can manually set which series it should link to.

Thanks for sharing, that's a nice solution! I'll think about it


Linting CLI tool & fixing its current style issues

Ensure the same code style on the CLI tool, as we do on the main file ./mustache.js.
Also minor .eslintrc change to be able to use process.exit(), instead of having to throw new Error() to exit the process.

Cool, thanks! :rocket:


Ipld gitbookv2

@rvagg re-wrote a bit on Multiformats, need you to check for accuracy. This was per feedback from a cadet that the Multiformats content could be improved.

@rvagg Another thing that I noticed was brought up in Q7S was ADL, I read some about this, but would like to add a section in a later part of the curriculum. Perhaps 'Paths & Selectors' or 'Distributed Data Structures' ?

Sorry, was out all last week.
Comments inline.
The ADL thing is a bit tricky, I think it might be best to leave it out for now since it gets us into tricky waters that need more explanation—plus it currently only applies to the Go stack, so it's even trickier. It's also not a mature part of IPLD, although we are improving it.
We're getting a new "what is" graphic ready for ipld.io: https://github.com/protocol/design-shop/issues/1388, a proper version of the one I showed from the whiteboard photo. It'll include mention of ADLs and perhaps we could use it as an introduction with hand-waving over some of the things that won't get covered in detail but learners can in dive in further on if they are inclined.


Added support for \cfrac

This addresses issue https://github.com/Khan/KaTeX/issues/85.
It needs a huxley test.  I've attached some screenshots of \cfrac vs \dfrac.  I also did some tests with LaTeX to make sure that I was getting the proper spacing.
@xymostech If you happy with the rendering do you want me to try and update the huxley tests?
cfrac:

dfrac:

cfrac vs dfrac in LaTeX

@kevinbarabash Here's another blast from the past (though maybe should be re-reviewed after your \not PR, #140).  I guess the hardest part will be rebasing to address conflicts.  Also need to implement the few small comments that you already responded to, and the missing tests.  I guess this also predates texcmp so we could compare with that to see how the rendering is (but it looks like you followed LaTeX's computations, so it's probably pretty good).

@edemaine since this PR is so old I'd probably cherry-pick or manually port the changes.  I'm going to close this for now and will open a new PR when I have time.


Add odometry classes

Implement an algorithm that numerically integrates the wheel movements to get the final robot position.

This may not be needed: https://docs.wpilib.org/en/latest/docs/software/kinematics-and-odometry/differential-drive-odometry.html

Some basic tank drive odometry classes should be added for convenience, including ones just using wheel encoders and ones using an external heading sensor.

WPILib for 2020 should be released soon, so this issue closed for now.


Tizen woes

Been trying to get static builds to work with Tizen 5 but it still fails on both real device and emulator. Seems like the relative URL for loading CSS, JS etc isn't working with file:// schemas. The ./ seems to resolve to file:/// which breaks the links.
Notice how the following statements fail to load (see screen shot below):
		<link href="./_app/immutable/assets/_layout-341fe5bb.css" rel="stylesheet">
		<link href="./_app/immutable/assets/_layout-b212931c.css" rel="stylesheet">
		<link href="./_app/immutable/assets/Icon-34f4c87a.css" rel="stylesheet">
		<link href="./_app/immutable/assets/PopUp-8aa555b8.css" rel="stylesheet">
		<link href="./_app/immutable/assets/Field-7bd846c7.css" rel="stylesheet">

etc
and also
<script data-sveltekit-hydrate="1vlrrss">System.register(["./_app/immutable/start-56c737df.js"], function (_export, _context) {
So the app never starts. The emulator logs:
[NPNQnpBgGn] _app/immutable/start-56c737df.js:1: TypeError: Illegal constructor
[NPNQnpBgGn] tvkit-babel-runtime/helpers/wrapNativeSuper.js:1: Uncaught (in promise) TypeError: Illegal constructor
[Run mode]
[NPNQnpBgGn] tvkit-babel-runtime/helpers/wrapNativeSuper.js:1: Uncaught (in promise) TypeError: Illegal constructor
[NPNQnpBgGn] _app/immutable/start-56c737df.js:1: TypeError: Illegal constructor
[NPNQnpBgGn] tvkit-babel-runtime/helpers/wrapNativeSuper.js:1: Uncaught (in promise) TypeError: Illegal constructor
[NPNQnpBgGn] tvkit-babel-runtime/helpers/wrapNativeSuper.js:1: Uncaught (in promise) TypeError: Illegal constructor

Screenshot from Logrocket (notice how the ./ relative URLs seem to have been translated to file system root dir):

Duplicate of #7
Having a Samsung partnership and be able to submit hosted apps is not for everyone:

It can be acceptable for some special cases only.

I'd like to support packaged apps, but don't know how to solve this yet, so any ideas are welcome.

Duplicate of #7
Having a Samsung partnership and be able to submit hosted apps is not for everyone:

It can be acceptable for some special cases only.

I'd like to support packaged apps, but don't know how to solve this yet, so any ideas are welcome.

Sorry if I made a duplicate. And yes, supporting packaged apps with legacy Tizen is a very important feature considering their market share. I've made some experiements on older Tizen webengines and problem so far is relative URL. Can do some additional experiments to see if we can manually correct the links to see if we have additional issues too.

Duplicates are useful, its makes finding the issue using different wording 👍
Until SvelteKit becomes workable the vite + svelte + spa-router combo is an alternative.
Please share the findings, I'm curious to see what insights you might get from your experiments!


style: Logo icon adaptation.

Change the size of the icon to adapt based on the height instead of the width, as the length of the logo text varies slightly.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you!


chore(testbed): replace dat.gui with lil-gui

lil-gui is a modern and maintained alternative to dat.gui. E.g. ThreeJS have migrated all their examples to use it
https://github.com/georgealways/lil-gui
The onChange cb has been removed from fns, otherwise pretty much a straight replacement.

Thanks!


session: Add proxy ActionType

This adds a new _PROXY ActionType to allow for offloading proxy sessions. Should work for both standard TCP and UDP proxies, as well as QUIC proxies.
Signed-off-by: Kyle Mestery<EMAIL_ADDRESS>

While I'm trying to solve offloading proxies here, the problem is that to get to the SNI value in a (D)TLS session or QUIC session requires us to handle the TCP handshake, thus the need to deal with sequence numbers on the socket. This assumes the socket is local to the application using these APIs. I was hoping to implement something like the Linux kernel eBPF Sockmap interface. That API assumes the application is running on the same kernel as the sockets. I think we can do the same thing here by requiring this API to be used by something running locally on the CPU complex of the DPU or IPU device. It's also possible I'm scratching an itch that no-one else has here, though I believe proxy offload is a valid use case.


Add detail about execution sequence for container kill order during Pod Termination

This PR adds an undocumented detail about how kill execution sequence works in runtime manager for better understanding the TERM order and relation between each container during Pod termination.
Proof: https://github.com/kubernetes/kubernetes/blob/fc8b5668f506b6d71ddc5243a21f5d0c5f8271d3/pkg/kubelet/kuberuntime/kuberuntime_container.go#L731-L747

Hi @mikebrow would you be willing to serve as a technical reviewer for this PR?  Simply add a /lgtm when you feel the PR is technically correct and I'll take care of the rest.
/cc @mikebrow
/assign

Hey @mikebrow! Thanks for the reviews. I have made changes according to your comments. PTAL when possible?

👋 @Dentrax
Can you rebase your pull request or close it if you are not actively working on the changes?
Thanks

Hi there @Dentrax – are you able rebase this PR due to the checks failing? As Karen mentioned above, if you're not longer working on this and like to close this PR, that's also fine. Thanks!

Hey @natalisucks, sorry i missed here. I will try rebasing tomorrow. 👍

@@natalisucks Hey, just rebased. PTAL when possible.

I only have a few nits as noted above, otherwise LGTM
/lgtm

Thanks @Dentrax!
/lgtm

Since this PR has been technically signed off per Mike's comment & has been signed off by Natali on behalf of SIG Docs, I am approving it for merge.
/approve


1.20.4 support

1.20.4 Support please add emojis show as null characters within chat, the resource pack shows as incompatible please update

+1


require 'EGP_Rates' isn't working

hello
I tried to use the gem in my rails project. I added it to Gemfile and I hit bundle i .
every time I use require 'EGP_Rates' it shows me this error:
LoadError: cannot load such file -- EGP_Rates
The solution is to use require 'egp_rates'
or change the name of egp_rates.rb in lib to be EGP_Rates.rb

thanks 👍

i know i was trying it in a script first

yeah, thanks for noticing this in the documentation
I forgot to update it when I built the CLI
https://github.com/mad-raz/EGP-Rates-CLI/blob/master/lib/EGP_Rates_CLI.rb#L2

:)
thanks for your code and your tiime


[Proposal] Deprecate Tuple Shuffle Expressions

Coming in late, I know.  Just wanted to get it up and out of the way.

The Core Team briefly discussed this proposal and believe it has a lot of traction. An implementation is needed for this proposal to schedule it for active review. Since this is source-breaking, a desired implementation would warn in the existing Swift modes and an error (with fixit) in Swift 5 mode.
Once you have an implementation please assign this PR back to me.

Helpme

@CodaFi are you interested in pursuing this further or should we close it out?

It's been a long time since I've last looked at this, but I think I can find some time during spring break to pick it back up considering the other implementations should be merged soon.

Okay, now I'm going to close this.  Not out of lack of interest, but because I'm driving way too many proposals forward and this one needs a completely different discussion than the one it enjoyed the first time around.


Event Data might be truncated when DLP.ALL (Exchange) log is over 32k

When sending over 200 sensitive info type in an email, event Data might be truncated in the O365DLP_CL Sentinel log.
This is due to a limit over the Log Analytics Data.
The solution is to reduce the Depth over the JSON conversion until we truncate the data correctly.
$jsonus = $usWorkspace | convertTo-Json -depth 8 or 9 max

I will change the depth in the code thank you for a good find.

I also had other location with 40905 characters, I used this to truncate data in the meantime's
if ($user.policydetails.rules.ConditionsMatched.SensitiveInformation.location.length -gt 200){
$user.policydetails.rules.ConditionsMatched.SensitiveInformation = "DATA TRUNCATED TOO LONG"}

To find out if you are maxing out the Long Analytics Size
O365DLP_CL
| where Operation_s == "DlpRuleMatch"
| extend len = strlen(PolicyDetails_s)

This code seems to do the trick. I've been testing it for a while. I will update in the next week.
if ($user.PolicyDetails.rules.ConditionsMatched.SensitiveInformation.SensitiveInformationDetections.ResultsTruncated -eq "true") {
$detectedrows = $user.PolicyDetails.rules.ConditionsMatched.SensitiveInformation.SensitiveInformationDetections.DetectedValues.count
do      {
$increment = [math]::truncate($detectedrows/2 )
$detected = $user.PolicyDetails.rules.ConditionsMatched.SensitiveInformation.SensitiveInformationDetections.DetectedValues[0..$increment]
$detectedcount = $detected.value | Measure-object -Character
$detectedrows = [math]::truncate($increment*1.5)
} until ($detectedcount.Characters -le "10240" )
$user.PolicyDetails.rules.ConditionsMatched.SensitiveInformation.SensitiveInformationDetections.DetectedValues = $detected

This code seems to do the trick. I've been testing it for a while. I will update in the next week.
if ($user.PolicyDetails.rules.ConditionsMatched.SensitiveInformation.SensitiveInformationDetections.ResultsTruncated -eq "true") {
$detectedrows = $user.PolicyDetails.rules.ConditionsMatched.SensitiveInformation.SensitiveInformationDetections.DetectedValues.count
do      {
$increment = [math]::truncate($detectedrows/2 )
$detected = $user.PolicyDetails.rules.ConditionsMatched.SensitiveInformation.SensitiveInformationDetections.DetectedValues[0..$increment]
$detectedcount = $detected.value | Measure-object -Character
$detectedrows = [math]::truncate($increment*1.5)
} until ($detectedcount.Characters -le "10240" )
$user.PolicyDetails.rules.ConditionsMatched.SensitiveInformation.SensitiveInformationDetections.DetectedValues = $detected

The code has been updated and committed to the function.


Add templated function to YamlWriter for supporting compact format

This PR adds support for two YAML serialization formats (compact and extended) and includes the following key changes:

Addition of new templated function set(Yaml& yml, const T& value, const bool is_compact) is added to support writing values into YAML in either compact or extended format, based on the is_compact flag.

The functionality has also been applied to set_collection, allowing collections vectors to be serialized in both compact and extended formats.

Renaming of set with TagType: The function set(Yaml& yml, const TagType& tag, const T& value) has been renamed to set_in_tag(Yaml& yml, const TagType& tag, const T& value).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.86%. Comparing base (4b19122) to head (fb385e3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   36.53%   37.86%   +1.33%
==========================================
  Files         169      152      -17
  Lines       11542     6956    -4586
  Branches     5277     2764    -2513
==========================================
- Hits         4217     2634    -1583
+ Misses       4581     2937    -1644
+ Partials     2744     1385    -1359

Flag
Coverage Δ

37.86% <100.00%> (+1.34%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added support for column families

This should fix issue #34.

@stephan-hof could you please merge this?
(@grove thanks for doing the work!)

The problem with this implementation of column families is that in the latest rocksdb holding a handle to a column family and closing the DB will cause an assert failure in rocksdb.  While this behavior is acceptable in C++. It is unacceptable in python that anything would ever cause a segfault.   My Suggestion is that instead of having a object that holds onto column families that you just return a str that the db object knows how to turn back into a handle. So in the db dealloc it can clear its mapping from str to handle and no abort is possible.

Well spotted. I agree.
I've also noticed a related issue[1]. If a column family is deleted and then later some other thread tries to use it, then the database enters read-only mode(!). In this case it is really important to manage the life-cycle of the column family handles.
I'm not sure if pyrocksdb have an API for closing the DB right now. Maybe it's relying on the garbage collector to kick in for that to happen automatically?
[1] https://github.com/facebook/rocksdb/issues/592


E1053: Could not import "../autoload/util.vim"

Error detected while processing /Users/xxx/AcVim/vimfiles/bundle/ngram-complete.vim/plugin/ngram-complete.vim[8]../Users/xxx/AcVim/vimfiles/bundle/vimcomplete/import/vimcompletor.vim:
line    4:
E1053: Could not import "../autoload/util.vim"

Can you upgrade and try again?


Broadcast join

Description
Working across nodes will require that we're able to work with tables from two different sources. I think the easiest thing to do here is a simple broadcast join with some light optimization rules.
Essentially planning will look like this:

If all table sources are local, create plan that's entirely local (same for if all sources are remote).
If table sources are split between local and remote, introduce a broadcast join in the plan.
If the local table is smaller, send it to remote. If remote table is smaller, retrieve it for local execution.

Pretty much done. Not necessarily a join right now.


[SPARK-28937][SPARK-28936][KUBERNETES] Reduce test flakyness

What changes were proposed in this pull request?
Switch from using a Thread sleep for waiting for commands to finish to just waiting for the command to finish with a watcher & improve the error messages in the SecretsTestsSuite.
Why are the changes needed?
Currently some of the Spark Kubernetes tests have race conditions with command execution, and the frequent use of eventually makes debugging test failures difficult.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests pass after removal of thread.sleep

Test build #110490 has started for PR 25765 at commit 16ba894.

Test build #110490 has finished for PR 25765 at commit 16ba894.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110490/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/15465/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/15465/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15465/
Test PASSed.

Test build #110492 has started for PR 25765 at commit 2ab68b5.

Test build #110492 has finished for PR 25765 at commit 2ab68b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110492/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/15467/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/15467/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15467/
Test FAILed.

test this please

(sorry for barging in again but i'm testing a small infra change on the ubuntu workers)
;)

Test build #110571 has started for PR 25765 at commit de35d67.

Test build #110571 has finished for PR 25765 at commit de35d67.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110571/
Test PASSed.

It's 100% ok :)

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/15546/

It's 100% ok :)

awesome.  i'm getting rid of those crappy, unrelated-to-the-build lsof errors in the logs.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/15546/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15546/
Test PASSed.

It's 100% ok :)

awesome. i'm getting rid of those crappy, unrelated-to-the-build lsof errors in the logs.

aaaaaand those error messages are gone!
+ /home/jenkins/bin/kill_zinc_nailgun.py --zinc-port 3714

Awesome @shaneknapp :D

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/15617/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15617/
Test PASSed.

Merged to master.


CI: auto-generate list of published Docker image references

After building and uploading new Docker images for Autobahn, it would be great to have the new Docker images listed in a way that allows exact reference and direct use in other projects
Docker CLI and docker-compose  allows to read env vars from a .env file, that if present, will make env vars already available during "docker-compose" phase (not only inside containers)
# Docker image references for Autobahn v21.1.1 (20220128-dc626948)
# https://hub.docker.com/r/crossbario/autobahn-python/tags?page=1&name=22.1.1

DOCKER_IMAGE_AUTOBAHN_PYTHON=crossbario/autobahn-python@sha256:dfed71b8441e219f2746ff08398d1571e99c666bf85bb4136fe2f9bf1a568650

Above can be computed like this
echo ${AUTOBAHN_VERSION}
echo ${AUTOBAHN_BUILD_ID}

docker inspect --format='{{index .RepoDigests 0}}' \
    crossbario/autobahn-python:cpy-amd64-${AUTOBAHN_VERSION}-${AUTOBAHN_BUILD_ID}

So say you have 2 env files

.env
myapp.env

Then you can use a docker-compose.yml like
    myapp:
        container_name: myapp
        image: ${DOCKER_IMAGE_AUTOBAHN_PYTHON}
        env_file:
            - myapp.env
        user: ${UID}:${GID}
        tty: true
        volumes:
            - "/home/ubuntu/myapp/:/app:rw"
        command:
            - python
            - myapp.py

The crucial point is: DOCKER_IMAGE_AUTOBAHN_PYTHON, UID and GID must be defined in .env. stuff in myapp.env is only available _within myapp.py!

see https://github.com/crossbario/autobahn-python/pull/1517


No relevance score when using sorting

We have been using a sorting specification like -[rank] my_id to get a consistent ordering in case of ties in the ranking.
This worked fine up to and including version 7.105.45, but from 7.110.36 and up this makes the relevance always come out as 0.
To reproduce, tested in a vespaengine/vespa:7.175.12 container:
mkdir -p app/searchdefinitions
cat <<EOF > app/searchdefinitions/my_documents.sd
search my_documents {
  document my_documents {
        field my_relevance type double {
            indexing: attribute
        }
        field my_id type long {
            indexing: attribute
        }
  }

  rank-profile default {
      first-phase {
          expression: attribute(my_relevance)
      }
  }
}
EOF
cat <<EOF > app/services.xml
<?xml version="1.0" encoding="utf-8" ?>
<services version="1.0">
  <container id="container" version="1.0">
    <document-api />
    <search />
    <nodes>
      <node hostalias="node1" />
    </nodes>
  </container>

  <content id="my_documents" version="1.0">
    <redundancy>1</redundancy>
    <documents>
      <document type="my_documents" mode="index" />
    </documents>
    <nodes>
      <node hostalias="node1" distribution-key="0" />
    </nodes>
    <engine><proton><resource-limits><disk>0.99</disk></resource-limits></proton></engine>
  </content>

</services>
EOF
vespa-deploy prepare app
vespa-deploy activate
sleep 30
curl -s -X POST -H "Content-Type:application/json" --data-binary '{"fields":{"my_id":1,"my_relevance":0.5}}' "http://localhost:8080/document/v1/default/my_documents/docid/1" > /dev/null
curl -s -X POST -H "Content-Type:application/json" --data-binary '{"fields":{"my_id":2,"my_relevance":1.0}}' "http://localhost:8080/document/v1/default/my_documents/docid/2" > /dev/null
curl -s -X POST -H "Content-Type:application/json" --data-binary '{"fields":{"my_id":3,"my_relevance":0.5}}' "http://localhost:8080/document/v1/default/my_documents/docid/3" > /dev/null

# without sorting
curl 'http://localhost:8080/search/?query=my_id:%3E0'  | python -m json.tool
# with sorting
curl 'http://localhost:8080/search/?query=my_id:%3E0&sorting=-\[rank\]%20my_id'  | python -m json.tool

The second query is ordered correctly, but all documents are returned with "relevance": 0.0
Looking around a bit, one possibly relevant change is the addition of the LeanHit class, with one commit labelled Set relevance to 0.0 if sorting.
As an aside, the sorting reference indicates that [rank] is a legacy alias for [relevance], but trying to use it for sorting gives me the error: "The cluster my_documents has no sortable attribute named: [relevance]"

Thank you for the detailed issue description.

This should now be fixed and will be present in build 7.207.22 and on. The next open source release will be early next week.


Add missing table format queries for tre CLI commands

Description
As a TRE Administrator
I want to have default table renderings for CLI commands
So that I am productive when interactively using the tre CLI
Acceptance criteria

[ ] All CLI commands that allow tabular output have default table queries specified

The remaining queries here are in the costs commands and require JMESPath lexical scopes which are a new proposal and not yet implemented.


Feature flags

Probably better to rebase on my branch instead of try merge

Thanks for doing this, I ended up just doing it manually though to keep it as a single commit + do more testing


Back icon is not working after clicking on add campaign button

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
master
Issue Description
Back button is not working after clicking on add campaign button
Preconditions

The admin should be Login.
Campaigns should be created.

Steps to reproduce

Login as an 'Admin'
Click on 'Email Marketing' inside the ''Marketing' tab.
Click on 'Campaigns' section.
Click on 'Add Campaign' button.
Click on back icon.
See the error.

Expected Result
It should be redirected to campaign section.
Actual Result
It is redirecting to review page.
Screenshots
No response
Additional context
No response

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.


Add flow diagram of tabml components

In training:
raw data -> feature manager -> data_loader + model wrapper -> trainer -> Model -> Model Analysis
In serving:
raw data -> feature manager -> Model -> prediction

The diagram can be edited at https://app.diagrams.net/#G1OJ7IkPfjIUKGHzBG6RmpKX0bSgJ4a5BB.


[enhancement]: Stable Diffusion 3

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
Stable Diffusion 3 (medium) has been released, it would be great to see this available in InvokeAI.
https://huggingface.co/stabilityai/stable-diffusion-3-medium
Alternatives
No response
Additional Content

As an aside, a fantastic summary of the SD3's hostile licensing from none other than the wonderful @hipsterusername - https://youtu.be/r8oA42saTNI
So just be aware that once this lands in InvokeAI - it may not be the right model for you if you're in a commercial environment. Hopefully for the hobbyists and non-commercial artists it can still be a useful tool in the chest.

After spending several days working with SD3 in Comfy I’m actually quite excited for SD3 support to land in InvokeAI despite the negativity around the model and its licensing.
Replicate has good tutorials today that provides guidelines on the basic differences when using SD3 vs SDXL - https://replicate.com/blog/get-the-best-from-stable-diffusion-3
Looking forward to this as another tool in the chest.


[ja] Temporarily patch page to avoid link-check failure

Fix for #5423

$ npm run fix:htmltest-config

> fix:htmltest-config
> scripts/htmltest-config.sh

Warning: Unrecognized htmltest IgnoreDirs config from front matter in file 'content/pt/docs/_index.md': IgnoreDirs: {}

When I try to run fix:htmltest-config, I get this error. After deleting the IgnoreDirs: {} statement in content/pt/docs/_index.md, the problem goes away.
@chalin Do you think okay to delete it?

That should have been caught earlier. I need to fix the CI scripts first. Let me do that before approving this PR.

Waiting for the following to get merged, then we'll rebase this PR:

#5612

/fix:htmltest-config

/fix:all


Add [GithubDirectoryFileCount] badge

Resolves #4899.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @hjagodzinski!

  Generated by :no_entry_sign: dangerJS against fafd76d797c618f15db60860069c131eedae12f6

@calebcartwright thank you for reviewing my PR and your feedback! I've covered most of your comments with changes to the code according to your suggestions. In the remaining ones I left my replies. Let me know what you think.

I like to keep names in the code in accordance with the natural language I use to describe it. Since you suggested changing in the examples directory file count to file count I wonder wether not change GithubDirectoryFileCount to GithubFileCount. What do you think?

Since you suggested changing in the examples directory file count to file count I wonder wether not change GithubDirectoryFileCount to GithubFileCount. What do you think?

My suggestion was to aid in cases where a user is browsing the example listings on Shields.io and wanting to have a clearer distinction between the examples targeting file counts vs. directory counts since the badge will display one or the other. I think having only of those words in the example listing helps better convey that and makes them more visually distinct.
The name of the service classes is typically more representative of the ServiceNoun pattern, and doesn't have to be strictly coupled with the text of examples which are targeted for end users and thus use more natural language. I guess the noun in this case is more of a ContentsCount or ContentCount, with Content having a file variant and directory variant.
I'm less concerned with the non-user facing class name and DirectoryFileCount is fine with me, though certainly open to an alternative if you can think of a better term!

It's a valid point that the most important aspect of naming is keeping the external compatibility. A potential cost of an internal class name change is incomparably lower. Nevertheless I will keep the current class name.
Thank you for taking time to explain to me the reasoning behind your comments. I appreciate that.


How to allow all headers in preflight OPTIONS response ?

This middleware is just a wrapper for Cors-psr7 library.
See the settings documentation (https://github.com/neomerx/cors-psr7#settings) to add allowed headers and methods.

Ok. I think there may be some bugs with that.


This is deprecated

(node:5188) Electron: Loading non-context-aware native module in renderer: '\?\F:\dir\node_modules\better-sqlite3\build\Release\better_sqlite3.node'. This is deprecated, see https://github.com/electron/electron/issues/18397
Hi Josh,
is there a way to fix this currently?

You can only spin up SQLite (or any native module) from the main process (or from processes or threads you spawn from the main process), and not in the render process. Read the link you posted and https://www.electronjs.org/docs/tutorial/application-architecture#main-and-renderer-processes for more details.

Actually, better-sqlite3 version 7.0.1 is context-aware, so it should work in worker threads.

Closing due to inactivity


Automated cherry pick of #8101: fix(region): set ownerId as userCred when can't FetchOwnerId

Cherry pick of #8101 on release/3.3.
#8101: fix(region): set ownerId as userCred when can't FetchOwnerId

/lgtm
/approve


Deploy GPU nodes on AWS

Is your feature request related to a problem? Please describe.
It would be useful if the deployer could create GPU nodes as part of the OpenShift deployment, specifically for installations of watsonx.ai, IKC Premium, etc.
In the initial phase, GPU nodes should be created on AWS self-managed OpenShift clusters.

[x] Document how to manually add GPU nodes to the cluster using the OpenShift console
[ ] Create GPU nodes as part of the OpenShift deployment, through deployer configuration

Given that most POCs will want to have control over the GPU node activity, we decided to stick with documentation-only.


Kernel32.dll System.DllNotFoundException - LINUX

We are working with the Faster.Core and we have some problems with Kernel32.dll dependency.
We have used a Linux Docker image but when start the container fails with the following message:
System.DllNotFoundException: Unable to load shared library 'kernel32.dll' or one of its dependencies.
Anyone works with UNIX system?

We have used FASTER on Linux with no issues. Is there a call stack?
Also see https://stackoverflow.com/questions/57174692/unable-to-load-shared-library-kernel32-dll-or-one-of-its-dependencies

We have used FASTER on Linux with no issues. Is there a call stack?
Also see https://stackoverflow.com/questions/57174692/unable-to-load-shared-library-kernel32-dll-or-one-of-its-dependencies

Can you help me, please? I use Faster.Server in Docker (in windows console mode are no issues). The connection is established through the standard port. But when calling
(Status, (System.Buffers.IMemoryOwner<byte>, int)) status = session.Read(s, t);
session.CompletePending(true);

session.CompletePending(true) - is executed indefinitely.
Can you help me, please?


Is there a way to click all the same elements?

actually this is not an issue, its a question.
i need to scrape a booking website. there is different roomtypes in the website and different meal types for every room type. if number of meal type is larger than 3, a button appears under the room type section and i have to click all of them.
example: 3 different room types with different meal types. buttons are marked with arrows.

how can i handle this?
ps: the button number is different for every hotel. if hotel does not provide different room types or meal types, the buttons may never appear.

You can receive the Page object in the request callback and perform arbitrary operations on it, such as Page.click and/or Page.evaluate. You could also perform those same operations as PageMethods.
By the way, this is not a support forum, thus questions like this one do not have high priority and might go unanswered longer than other issues (also there is no code so there's no way of telling what you have tried and what could be wrong). You might get quicker answers in more appropriate places (e.g. StackOverflow).


docs: update docs including organization from eduNEXT/edx to openedx

Description:
This PR updates documentation:

Changes occurrences of edx/edunext to Open edX/openedx
Add a short description
Change keywords

Closed in favor of https://github.com/openedx/openedx-events/pull/48


Error getting certificate 'my-cert': error decoding cert PEM block

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
I created an empty Secret to hold the TLS certificate, i.e. the Certificate.spec.secretName
What you expected to happen:
I expected the empty Secret to be modified to have tls.key and tls.crt
How to reproduce it (as minimally and precisely as possible):
Create an empty Secret before referencing it in your Certificate
apiVersion: v1
kind: Secret
metadata:
  name: my-empty-cert
type: Opaque
---
apiVersion: certmanager.k8s.io/v1alpha1
kind: Certificate
metadata:
  name: my-cert
spec:
  # The name of the secret that stores the certificate
  secretName: my-empty-cert
  issuerRef:
    name: my-issuer
  dnsNames:
    - my.domain.name
  acme:
    config:
      - http01:
          ingress: my-ingress
        domains:
          - my.domain.name

Anything else we need to know?:
Similar to #164 but no panic, just a loop in the logs and no cert:
I1026 21:16:59.876638       1 server.go:68] Listening on http://<IP_ADDRESS>:9402
I1026 21:16:59.877845       1 leaderelection.go:174] attempting to acquire leader lease...
I1026 21:17:16.657352       1 leaderelection.go:184] successfully acquired lease kube-system/cert-manager-controller
I1026 21:17:16.657594       1 factory.go:58] NS does not exist on lookup for  - v1.GroupVersionKind{Group:"certmanager.k8s.io", Version:"v1alpha1", Kind:"Issuer"}
I1026 21:17:16.657682       1 factory.go:66] existing informer does not exist on lookup for  - v1.GroupVersionKind{Group:"", Version:"v1", Kind:"Secret"}
I1026 21:17:16.657748       1 factory.go:66] existing informer does not exist on lookup for  - v1.GroupVersionKind{Group:"certmanager.k8s.io", Version:"v1alpha1", Kind:"Certificate"}
I1026 21:17:16.657779       1 factory.go:70] existing informer found for  - v1.GroupVersionKind{Group:"certmanager.k8s.io", Version:"v1alpha1", Kind:"Issuer"}
I1026 21:17:16.657794       1 factory.go:66] existing informer does not exist on lookup for  - v1.GroupVersionKind{Group:"certmanager.k8s.io", Version:"v1alpha1", Kind:"ClusterIssuer"}
I1026 21:17:16.657816       1 factory.go:70] existing informer found for  - v1.GroupVersionKind{Group:"", Version:"v1", Kind:"Secret"}
I1026 21:17:16.657836       1 factory.go:66] existing informer does not exist on lookup for  - v1.GroupVersionKind{Group:"extensions", Version:"v1beta1", Kind:"Ingress"}
I1026 21:17:16.657904       1 factory.go:70] existing informer found for  - v1.GroupVersionKind{Group:"certmanager.k8s.io", Version:"v1alpha1", Kind:"ClusterIssuer"}
I1026 21:17:16.657930       1 factory.go:58] NS does not exist on lookup for kube-system - v1.GroupVersionKind{Group:"", Version:"v1", Kind:"Secret"}
I1026 21:17:16.758382       1 logs.go:41] starting worker
I1026 21:17:16.758417       1 logs.go:41] starting worker
I1026 21:17:16.858438       1 sync.go:81] Issuer my-app-tls-ci not ready
I1026 21:17:16.858731       1 logs.go:41] starting worker
I1026 21:17:16.858798       1 factory.go:70] existing informer found for  - v1.GroupVersionKind{Group:"", Version:"v1", Kind:"Secret"}
I1026 21:17:16.858857       1 logs.go:41] starting worker
I1026 21:17:16.863698       1 sync.go:81] Issuer my-app-tls-ci not ready
I1026 21:17:16.873909       1 sync.go:81] Issuer my-app-tls-ci not ready
I1026 21:17:16.894095       1 sync.go:81] Issuer my-app-tls-ci not ready
I1026 21:17:16.934353       1 sync.go:81] Issuer my-app-tls-ci not ready
I1026 21:17:17.014578       1 sync.go:81] Issuer my-app-tls-ci not ready
I1026 21:17:17.174905       1 sync.go:81] Issuer my-app-tls-ci not ready
I1026 21:17:17.495179       1 sync.go:81] Issuer my-app-tls-ci not ready
I1026 21:17:17.785670       1 helpers.go:79] Setting lastTransitionTime for Issuer "my-app-tls-ci" condition "Ready" to 2017-10-26 21:17:17.785659034 +0000 UTC
I1026 21:17:17.795404       1 logs.go:41] finished processing work item
I1026 21:17:17.795532       1 factory.go:70] existing informer found for  - v1.GroupVersionKind{Group:"", Version:"v1", Kind:"Secret"}
I1026 21:17:18.135499       1 factory.go:70] existing informer found for  - v1.GroupVersionKind{Group:"", Version:"v1", Kind:"Secret"}
I1026 21:17:18.135542       1 sync.go:98] Error checking existing TLS certificate: error decoding cert PEM block
I1026 21:17:18.135612       1 sync.go:199] Preparing certificate with issuer
I1026 21:17:18.136064       1 prepare.go:237] Compare "" with "https://acme-v01.api.letsencrypt.org/acme/reg/**masked**"
I1026 21:17:18.181572       1 logs.go:41] finished processing work item
I1026 21:17:18.181610       1 factory.go:70] existing informer found for  - v1.GroupVersionKind{Group:"", Version:"v1", Kind:"Secret"}
I1026 21:17:18.580172       1 logs.go:41] finished processing work item
I1026 21:17:18.756951       1 logs.go:41] [3962092-tls.my.domain] Error self checking HTTP01 challenge: wrong status code '503'
I1026 21:17:23.798790       1 logs.go:41] [3962092-tls.my.domain] Error self checking HTTP01 challenge: wrong status code '503'
I1026 21:17:28.830572       1 logs.go:41] [3962092-tls.my.domain] HTTP01 challenge self checking passed
I1026 21:17:31.072543       1 sync.go:209] Issuing certificate...
I1026 21:17:31.073103       1 helpers.go:165] Setting lastTransitionTime for Certificate "my-app-tls-ci" condition "Ready" to 2017-10-26 21:17:31.073097762 +0000 UTC
I1026 21:17:31.073130       1 sync.go:217] Error issuing certificate: error getting certificate private key: error decoding private key PEM block
E1026 21:17:31.109870       1 sync.go:180] [default/my-app-tls-ci] Error getting certificate 'my-app-tls-ci-tls': error decoding cert PEM block
I1026 21:17:31.109952       1 factory.go:70] existing informer found for  - v1.GroupVersionKind{Group:"", Version:"v1", Kind:"Secret"}
I1026 21:17:31.109978       1 sync.go:98] Error checking existing TLS certificate: error decoding cert PEM block
I1026 21:17:31.109996       1 sync.go:199] Preparing certificate with issuer
I1026 21:17:31.110392       1 prepare.go:237] Compare "https://acme-v01.api.letsencrypt.org/acme/reg/**masked**" with "https://acme-v01.api.letsencrypt.org/acme/reg/**masked**"
I1026 21:17:31.282556       1 sync.go:209] Issuing certificate...
I1026 21:17:31.282903       1 sync.go:217] Error issuing certificate: error getting certificate private key: error decoding private key PEM block
E1026 21:17:31.289983       1 sync.go:180] [default/my-app-tls-ci] Error getting certificate 'my-app-tls-ci-tls': error decoding cert PEM block
I1026 21:17:32.390223       1 factory.go:70] existing informer found for  - v1.GroupVersionKind{Group:"", Version:"v1", Kind:"Secret"}
I1026 21:17:32.390275       1 sync.go:98] Error checking existing TLS certificate: error decoding cert PEM block
I1026 21:17:32.390327       1 sync.go:199] Preparing certificate with issuer
I1026 21:17:32.390753       1 prepare.go:237] Compare "https://acme-v01.api.letsencrypt.org/acme/reg/**masked**" with "https://acme-v01.api.letsencrypt.org/acme/reg/**masked**"

Environment:

Kubernetes version (use kubectl version):
Client Version: v1.8.2
Server Version: v1.7.5+coreos.0

I've put in #170 to fix this. Fingers crossed this is the last bug you run into!
Thanks for the reports 😄 once you confirm that's working, and I hear #163 has been resolved, I'll cut v0.1.2.

Super - can I just change the image tag to latest or canary or?

The new canary image has gone live just now - if you tried in the last 15 minutes, you'll need to re-download the image.
I'm going to update the entrypoint to log the git version info etc. on start in future to make this easier to check.

I can confirm in canary that a pre-existing (empty) Secret can be used as the storage location for the TLS certificate and key and look forward to its inclusion in 0.1.2!


Select definition on loading edited template

If a template for a job is selected, and, for instance, childJobs get modified, the job doesn't validate against its template.

{
    "path": "root.jobs.1",
    "property": "oneOf",
    "message": "Value must validate against exactly one of the provided schemas. It currently validates against 2 of the schemas."
  }


Export Prometheus metric for messageTTL

Fixes #8573
Motivation
Some users who want to know how many messages are expired at what time?


Some Questions About Using This In Android

Recently,I want to learn about video encode,I find many ways to encode h264,but the soft encoding is too slow.I want to know the delay about openh264 using in android,and do you have more detail documents or demo about android.
Thank you all the same.

this does not look like a codec problem.
for android builds of openh264, please check https://github.com/cisco/openh264#for-android-builds
and there are some test scripts may be used for reference: https://github.com/cisco/openh264/tree/master/autotest/performanceTest/android


[BUG] Airupd panics when the logger cannot be initialized

Steps
Make airupd not permitted to access the log directory and launches airupd.
Expected Behavior
The error is ignored, or it prints a message to the console.
Actual Behavior
Airupd immediately panics with a message Permission denied.

This is a feature of tracing-appender, which calls .expect(_) when RollingFileAppender failed to be initialized.
As root is mounted read-only, the logger would not be initialized. The logger is migrating to syslog in further updates.

Fixed.


Fix regression in dynamic resolution for out-of-tree platforms

A recent Facebook commit broke dynamic resolution for out-of-tree platforms:
https://github.com/facebook/react-native/commit/d5e9e55fa38c574bce6c04cbcaf6b144b87fa17f#diff-9b25f85c1d5984674020a6d0c7a66be9
The request for a fix resulted in another commit which hard-coded platforms:
https://github.com/facebook/react-native/commit/c4bcca66853cd231486de61f11cbcec42427b7b2#diff-9b25f85c1d5984674020a6d0c7a66be9
This PR restores the original functionality. I will update this PR with more tests before requesting merge.
Thanks to my colleague @rdy for pairing with me.
Test Plan:
[x] Ran yarn test
[ ] Add new e2e CLI tests to verify out-of-tree platforms
Release Notes:
[ GENERAL  ] [ BUGFIX      ] [local-cli ] Restore dynamic resolution for out-of-tree platforms.

Warnings

:warning:

:clipboard: Release Notes - This PR may have incorrectly formatted Release Notes.

  Generated by :no_entry_sign: dangerJS

I'm not convinced about the regex change. My concern is that this forces the repo to stick to a strict convention that module.X.js is only used for X = platform, when no such strict requirement existed before, as the set of platform moniker was enumerated. I agree that something needs to be done to address this for extracting haste names for other platforms, but I'm not positive this is the best solution.

Yea, as I'm iterating and seeing the issues unfold, it turned out that assuming the convention would hold in a consistent way was a poor choice on my part. I'm open to suggestions that can be implemented in time for cherry-picking into the next 0.57 RC.

@empyrical @rozele @CaptainNic @madhavarshney @MaxRis @vincentriemer If you could check if this approach of overriding via metro.config.js works for your projects, it would be appreciated. The plan is for this to be cherry-picked into 0.57. Thanks!

I made a version partially inspired by how you did it, and also inspired by the "jest": { "haste": ... } entries in RN's `package.json.
https://github.com/empyrical/react-native/commit/7f8ea35ed64def91e35f0ff3c00b1be75d1c4293
You add this entry to your react-native-foo renderer's package.json:
{
  "rnpm": {
    "haste": {
      "providesModuleNodeModules": [
        "react-native-foo"
      ],
      "platforms": [
        "foo"
      ]
    }
}

And both jest/hasteImpl.js and local-cli/core/index.js will look for react native plugins that have this haste entry.
One thing I find appealing about this way is it leaves open the possibility to declare multiple providesModuleNodeModules and platforms for the packager to look in, if you want. And could be extended to have more Metro configuration options later on too. If you're okay with me doing this, perhaps I could submit this commit as a pull request for consideration too? (I want to clean some things up first and test it a bit more, though)

Made a proposal here: https://github.com/react-native-community/discussions-and-proposals/issues/21

Closing in favor of #20825


Rust bindings lack flexibility with current structure of build script

I'm using a niche devops flow with nixos and I've found the current structure of the Rust bindings in this repo are problematic. As far as I can tell, this has to do with the placement of the build.rs in a subdirectory with respect to the C code. I expect there were similar issues with other language toolchains given the placement of the Go and Nim files at the repo root.
I can point to these resources that helped me diagnose the issue:
https://github.com/ipetkov/crane/issues/473#issuecomment-1837004284
https://github.com/ipetkov/crane/pull/271#issuecomment-1500499998
And in particular (regardless of nixos), you'll find that trying to build the bindings locally using cargo vendor fails.
I haven't tried it yet, but I suspect we should just place the Cargo.toml and build.rs as the project root. If we are open to modifying the repo to get cargo vendor to succeed then I'm happy to make a PR to diagnose further.
There seems to be a quirk of crates.io that pulls the entire repo so that something like this works for my use case, but I would prefer we pursue a successful cargo vendor as that should solve the problem instead of having to maintain a fork of all the consumers of this project.

If we are open to modifying the repo to get cargo vendor to succeed then I'm happy to make a PR to diagnose further.

Hey @ralexstokes! This is an interesting problem. I'm open to changing things. But I would like to hear about this from other Rust people before suggesting we do anything. @pawanjay176 @asn-d6, thoughts?

Hmm, it feels dirty to dump Cargo.toml and build.rs to the project root, but it seems like we already have golang and nim-related files there. So dirtiness is already there, and hence I wouldn't oppose this change.
I wonder if it's possible to do something using cargo workspaces.  From reading a bit about it, even if it's possible, we would still need a Cargo.toml in the project root to specify the location of the rust bindings.
The extreme (not proposed) alternative is to move all bindings to their own git repo so that they can freely manage their directories.

+1 to this issue. I'm using nixos for my DevOps too and it fails to work:(
This is because of strict rules for what application can access, and it fails to vendor the crate.


Fix ownership classification of opaque instructions and re-enable opaque_values_silgen test.

Fix ownership classification of opaque instructions and re-enable opaque_values_silgen test.

@swift-ci Please smoke test and merge