Prefetch + Afterwares

I need to include afterware to have apollo play nice with my Absinthe backend:
https://github.com/absinthe-graphql/absinthe_plug/issues/89
I'm including this code, which works without prefetch: true
const absintheAfterware = {
    applyBatchAfterware(res, next) {
      res.responses.forEach((resp) => {
        resp.data = resp.payload.data;
      });
      next();
    },
  };

but throws Network error: Cannot read property 'data' of undefined when prefetch is enabled. I've narrowed it down to this line:
await app.apolloProvider.prefetchAll({ route }, components)
in
    beforeNuxtRender(async ({ components, nuxtState }) => {
      await app.apolloProvider.prefetchAll({ route }, components)
      nuxtState.apollo = app.apolloProvider.getStates()
    })

This seems to be unrelated to vue-apollo code.

You're right, my apologies! Seems to be related to the await call (when removing await, it works), not sure why though 😞

For anyone else that might find this, I found that using a lowercase 'c' for the components variable fixed it :man_facepalming:
    beforeNuxtRender(async ({ components, nuxtState }) => {
      await app.apolloProvider.prefetchAll({ route }, components)
      nuxtState.apollo = app.apolloProvider.getStates()
    })


Update util.js

Missing comma caused el to be on the global context

ooops! Fairly important fix.
Thank you!


Improve randomness for proposer selection

Added timestamps to votes to introduce more randomness in proposer selection
Related: https://github.com/ainblockchain/ain-blockchain/issues/702

Addressed all comments, PTAL @platfowner

Thanks for the reviews! Ran the tests, will be merging as soon as the performance test pipeline is fixed~


Rewrite quoted string regex to prevent issues with very large strings

Fixes https://github.com/MetaMask/snaps-skunkworks/issues/432

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This seems to fix the issues we have been having - Don't merge yet, checking a few more things.


getDefaultProps for inferno-compat

Trying out inferno with an existing ES5 React application, and it seems to ignore default props provided by getDefaultProps.  Any plans on supporting that for ES5 components?

@jackmoore this is definitely a regression, as this should work. Thanks for letting us know – will be fixed ASAP.

@jackmoore this has been added to 1.0.


Undefined litmus_installed

In https://github.com/redhat-chaos/krkn/blob/main/run_kraken.py#L280 there's
        if litmus_uninstall and litmus_installed:
            common_litmus.delete_chaos(litmus_namespace)
            common_litmus.delete_chaos_experiments(litmus_namespace)
            common_litmus.uninstall_litmus(litmus_version, litmus_namespace)

introduced in pr #33.
but litmus_installed is not defined anywhere. My guess is that here litmus_install from https://github.com/redhat-chaos/krkn/blob/main/run_kraken.py#L50  was meant to be used after the change introduced with pr #292 .
@chaitanyaenr can you please handle?

This fix should now be in with PR: https://github.com/redhat-chaos/krkn/pull/316


Test cleanup: Remove redundant volume discard test

What this PR does
This Pull Request removes an functional test that verifies volumes with preallocation do not have discard='unmap'.
The behavior is already fully covered by unit tests: https://github.com/kubevirt/kubevirt/blob/b6c95626967dcf0b18c93cfc1d2937e1fa336e79/pkg/virt-launcher/virtwrap/manager_test.go#L763
Since the functional test requires expensive API calls without improving test coverage its deletion should be justified.
Release note

NONE

/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations


ci: run with macos 11 and 12

Hm, so far, I was not able to find a way to avoid building the below ifdef place only when Xcode 12 x macOS 11.3-macOS 12 combinations. Xcode 12 x macOS 10 had no issue, I haven't tried as no environment, but maybe macOS 11.0-.2 x Xcode 12 also had no issues.
-fmodules-cache-path\=/Users/runner/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -fmodules-prune-interval\=86400 -fmodules-prune-after\=345600 -fbuild-session-file\=/Users/runner/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror\=non-modular-include-in-framework-module -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror\=return-type -Wdocumentation -Wunreachable-code -Wquoted-include-in-framework-header -Wno-implicit-atomic-properties -Werror\=deprecated-objc-isa-usage -Wno-objc-interface-ivars -Werror\=objc-root-class -Wno-arc-repeated-use-of-weak -Wimplicit-retain-self -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wdeprecated-implementations -DDEBUG\=1 -DOBJC_OLD_DISPATCH_PROTOTYPES\=0 -isysroot /Applications/Xcode_12.5.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -g -Wno-sign-conversion -Winfinite-recursion -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wno-semicolon-before-method-body -Wunguarded-availability -index-store-path /Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Index/DataStore -iquote /Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/WebDriverAgentRunner-generated-files.hmap -I/Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/WebDriverAgentRunner-own-target-headers.hmap -I/Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/WebDriverAgentRunner-all-non-framework-target-headers.hmap -ivfsoverlay /Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/all-product-headers.yaml -iquote /Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/WebDriverAgentRunner-project-headers.hmap -I/Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Products/Debug/include -I/Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/DerivedSources-normal/x86_64 -I/Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/DerivedSources/x86_64 -I/Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/DerivedSources -F/Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Products/Debug -iframework /Applications/Xcode_12.5.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks -MMD -MT dependencies -MF /Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/Objects-normal/x86_64/WebDriverAgentRunner.d --serialize-diagnostics /Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/Objects-normal/x86_64/WebDriverAgentRunner.dia -c /Users/runner/work/appium-mac2-driver/appium-mac2-driver/WebDriverAgentMac/WebDriverAgentRunner/WebDriverAgentRunner.m -o /Users/runner/Library/Developer/Xcode/DerivedData/WebDriverAgentMac-bucmjpiialdbpndjdovhzxqnjbmm/Build/Intermediates.noindex/WebDriverAgentMac.build/Debug/WebDriverAgentRunner.build/Objects-normal/x86_64/WebDriverAgentRunner.o
/Users/runner/work/appium-mac2-driver/appium-mac2-driver/WebDriverAgentMac/WebDriverAgentRunner/WebDriverAgentRunner.m:50:81: error: property 'nonStrictOptions' not found on object of type 'XCTExpectedFailureOptions'
  XCTExpectFailureWithOptions(@"Ignore all failures", XCTExpectedFailureOptions.nonStrictOptions);
                                                                                ^

** ANALYZE FAILED **

The following build commands failed:
	Analyze /Users/runner/work/appium-mac2-driver/appium-mac2-driver/WebDriverAgentMac/WebDriverAgentRunner/WebDriverAgentRunner.m normal x86_64
(1 failure)
Error: Process completed with exit code 65.

So... our best possible way is to address the combination does not work in the README..


Clean up CircleCI

Our CircleCI file has gotten pretty large and confusing to read, would be awesome if we could clean it up and reuse more of the previous definitions created in the file to limit code duplication.

Would it make sense to also look into this error since we're already changing the file?


include_links breaks the extraction for https://news.ycombinator.com

Just as the title says. Attaching screenshot as an example.

I go through the source code, and found out (windows) that the include_links feature is working well. The only problem is that the base base_url passed is somehow is None.

I have printed the target link which looks like this.

In above, you can see there is no base_url (used to create a relative url)
You can pass the Url paremeter to get the full url

Here is the output of above code:


Config parameter 'num_workers' can't be set with environment variables

In a recent commit the num_workers configuration setting was adding to multiprocessing/threaded schedulers. However, it uses an underscore when getting the value from the configuration object (num_workers). This means that the environment variable DASK_NUM_WORKERS can't be used to set it as environment variables have underscores converted to hyphens (num-workers).
The commit in question (@jrbourbeau @mrocklin ): https://github.com/dask/dask/commit/abfae43c808ad15714df8033c8be3176b1595644
Simple example proving that what it is doing won't work:
DASK_NUM_WORKERS=4 python -c "import dask; print(dask.config.get('num_workers', None)); print(dask.config.get('num-workers', None))"
None
4

Is num workers not supposed to be configurable from an environment variable? Otherwise, should it be changed to num-workers in the threaded and multiprocess schedulers?

Thinking about this more, we may want to have both get and set normalize underscores and hyphens to the same value. If only get normalizes, then you have the situation
import dask

# Assume DASK_NUM_WORKERS has been set to 2

with dask.config.set(num_worker=5):
    # Will use 2 workers

If only set normalizes then existing code like dask.config.get('rerun_exceptions_locally') or dask.config.get('delayed_pure') will break.
When get and set both have the same normalization, both the above problems are avoided.


Run flake8 on Python instead of legacy Python

Blocked by: ~#7383, #7384, and #7385~
Related to: #4552
Signed-off-by: cclauss<EMAIL_ADDRESS>Also adds more critical flake8 tests.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

@cclauss this is failing the format check, can you take a look?
/wait

@htuch The commit message is clear: Blocked by: ~#7383, #7384, and~ #7385

@cclauss ideally put PRs into a draft status in this situation, it makes it easier to track what's ready for review, see https://github.blog/2019-02-14-introducing-draft-pull-requests/.

Hey, thanks! Do you mind also updated the python version in
https://github.com/envoyproxy/envoy/blob/1faaed85740a97533484db3232796aef7973677f/tools/shell_utils.sh#L5 ?

/wait

@asraa I am not sure how to "link issue #7322".

@cclauss I think the ask was to do this in the commit, I'll do that when I merge.


Need More Detailed Instructions

Cannot get app to run... need more info on how to install.

Hey, Have you downloaded the app from the release tab on github ?
If so, put the zip file in a convenient place and unzip it
In the folder, there should be a readme and two other folders one for the tools and one for the script
Try to read and follow the readme (install python etc)
And then, start the file named star-citizen-navigation-tool.exe in the star-citizen-navigation-tool-win32-x64 folder
If everything worked, the app should start and prompt you with a few windows


TypeScript unusable in Visual Studio 2017

TypeScript Version:  2.1.5
Visual Studio Version: 2017, 15.0.0-RTW+26228.4
Code

Expected behavior:

Keywords are colorized as keywords, not types
Types are colorized as types, not identifiers
Code completion works
Identifiers/function/members names are colorized as identifiers, not as types

The same code worked in Visual Studio 2015 excellently for months.
Actual behavior:

Code completion has no context, it shows only words found in this file
constructor keyword is colorized as a type
Types are colorized as plain identifiers
Member names, function names are colorized as types

Do you see this if you open a new file? Or is it specific to a project? If it is the later, can you share the project?

I am trying to gather more info for you, but whenever I open a web project with NPM, Visual Studio 2017 crashes immediately and sometimes the solution closes itself without opening anything...
The project was migrated from xproj to csproj, but the issue appears with new projects as well, when I am succeed to open them for a few seconds. Today after a restart, it seems like TypeScript understands the code, because types are colorized and tooltips show semantics, but highlighting is still broken:

constructor keyword is colorized as a type (when i hover it, in the tooltip it is colorized correctly as a keyword)
null keyword (when used as type) is colorized as identifier
member function names are colorized as types

So, how to repro: create an ASP.NET core web application using the built-in template, add a .ts file to the project, and type some TypeScript code:

null is not colorized as keyword, but as identifier
the name if a function is colorized as a type instead of identifier (it is not even a void function)
new keyword is not colorized
RegExp is not colorized as type

Interesting... I'm not seeing that behavior with the snippet above. It's colorizing as expected for me (see below). Note: RegExp is an identifier in this context, not a type.
Are you seeing any errors in the Event Log? What do you mean exactly by "open a web project with NPM"?
If you open Task Manager, do you see a Node.js process running "tsserver.js" (and not constantly restarting)? This is our language service which should be providing the completions (and some colorization) to VS.

Hi @billti, thank you for your answer. I have just installed VS2017 clean into my other machine and the problem is almost the same. IntelliSense works, but syntax highlighting is broken:

Coloring in tooltips seems to be fine, but in the editor it is messed up:

constructor keyword is a type
new keyword is black
as keyword is black
namespaces are colorized as types
member functions are types and so on...

Another one:

Another one:

I can see 6 node.js processes running, but can't determine which one is running what, but it seems like none of them is restarting continuously.
For the NPM errors: I reported it to the VS team, this is the only error I can see in the Event Log. It looks like it is related to the Solution Explorer and not TypeScript. It was just part of the "nothing works" experience at first sight.

I'm still trying to repro based on the snippets of text in the screen shots above, but it's working fine for me, and not at all as your clippings show.
The weird thing is, it's obviously parsing the tokens and coloring them somehow (i.e. you're not just getting a basic text editor all one color), and most of the colorization is controlled by a grammar file which would be the same for both of us.
A few questions:

Are these clean installs or VS 2017? There was a bug previously where the grammar cache was getting corrupted, but if these aren't build-to-build upgrades (e.g. RC1 -> RTM), then that shouldn't be an issue.
Did you resolve your other issues? I see on the issue you linked things were crashing elsewhere if opening directly from source control. Does this repro if you just open a basic individual file from the local disk (e..g C:\temp\scratch.ts)?
Are these files with a .ts extension? i.e. you are not using some other extension to indicate a template file (e.g. "ng.component") or similar that would confuse the grammar (which is chosen based on file extension).
Do you have any other VS extensions installed which may be interfering with colorization?
Is it possible VS has tried to migrate some roaming settings which is messing things up? (i.e. if you don't sign in to VS with your account, but choose the "maybe later" option, then it won't try and sync settings from other installs).
If none of the above helps - are you able to send me a full sample that shows this problem. It may be something more complex further up in your files that is messing up the grammar parsing further down.

Sorry for the issues you are hitting. Thanks for helping us figure them out.

Yes. Personal machine: clean install, work machine: I had the latest RC installed, which I uninstalled for sure before installing the new version a few days ago.
a) Yes, I could find a workaround for constant crashes, but it is related to source control. b) Yes, I can reproduce it by opening a standalone file which is not part of a project and there is no tsconfig nearby.
Yes, all of my files have .ts extension.
No, only what VS has installed by itself.
Yes, I have logged in to VS2017 with my previous accounts from VS2015. I use my personal account for my personal computer and my work account for my work computer. So, I use two different accounts, but both can reproduce the issue in two different environments.
I can reproduce it by opening a new web application project or a standalone file as well. But I can have a screen share with you, or send some more info if it helps.

Another interesting thing is that I can't even find the classification types under Options \ Environment \ Fonts and Colors.

Coming from #14422:

Yes clean install. This machine hasn't seen any of the VS 2017 previews

Yes, normal *.ts files
I'm not entirely sure, because @madskristensen's Web Essentials 2017 contain a lot of stuff :)
On a different computer, I had tried the previews of VS 2017 with my Microsoft ID. VS 2015 has been connected to this ID as well
See #14422

@Peter-Juhasz : Thanks for helping us with this issue!  TypeScript & JavaScript now use TextMate language files to inform classification. Some additional things to try that might help isolate the issue:

Your first screen shot with the completion list doesn’t appear to be a TypeScript completion list.  Instead this looks like the naïve TextMate completion list that should only kick in when the TypeScript LS isn’t installed correctly.  Can you confirm that other TSLS features are working correctly on your installations? (TypeScript navigation bar, formatting, etc)

There is a known issue with TextMate support in VS where sometimes there are missing colors.  To make sure this isn’t the case here can you try running the following from a VS Developer cmd prompt to see if it resolves the issue:
•	devenv.exe /updateconfiguration
•	devenv.exe /setup

What is your VS installation directory?
Ex:  C:\Program Files[ (x86)]\Microsoft Visual Studio 15.0\Common7\IDE

Does the tmLanguage folder exist under the TypeScript installation path?
Ex:  C:\Program Files\Microsoft Visual Studio 15.0\Common\IDE\CommonExtensions\Microsoft\TypeScript\tmLanguage

Do you have any custom grammar files (.tmLanguage, .tmTheme) located in your user profile?
Ex: %userprofile%.vs\Extensions

Can you verify this isn’t a TM language caching issue:
- Close VS
- Go to the TexMateCache location:
- %localappdata%\Microsoft\VisualStudio[15.0XXXXX]\TextMateCache
- Delete all the .cache files in this directory
- Reopen VS and try to repro
 Does this resolve the issue?

Do you have the TypeScript TextMate registry key set correctly?

Close VS
Open regedit
Select HKLM
File > Load Hive …
Open %localappdata%\Microsoft\VisualStudio\15.0_xxx\privateregistry.bin (you can name the hive VS)
Now navigate to:
Computer\HKEY_LOCAL_MACHINE\VS\Software\Microsoft\VisualStudio\15[XXXXX]_Config\TextMate\Repositories

Does the TypeScript reg key exist? The directory should match the tmLanguage folder path from question #2 – is it the same?
Note:  you'll need to unload the hive (File > Unload Hive) before you can open VS again.

Yes, all other language service features seems to be working, except syntax highlighting.
No, unfortunately it did not helped.
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE
Yes, it exists with 4 files: "TypeScript.tmLanguage", "TypeScript.tmTheme", "TypeScriptReact.tmLanguage", "TypeScriptReact.tmTheme" from 3/7/2017, the date I installed VS2017.
Yes, there are a lot. They have probably came with Mads' Syntax Highlighting Pack. I did not installed any extensions at first to VS2017, but it seems like this folder is shared between all VS versions, including my previous installation 2015. It has a "typescript" folder and a "syntaxes" in it. And two files in that folder: "TypeScript.tmLanguage" and "TypeScriptReact.tmLanguage" from 2/3/2017.
No, unfortunately the problem still exists.
Yes, the key matches: "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\CommonExtensions\Microsoft\TypeScript\tmLanguage"

As you can see completion and syntax highlighting uses a different understanding of the code:

I have also installed Mads' extension for extension development which shows classification of spans the caret is positioned to. A few examples:

I said tooltips work as expected, but there all problems with tooltips too, there is no consistency in syntax highlighting:

Solution: Overwrite files in "%userprofile%.vs\Extensions\typescript\syntaxes" with the ones from Visual Studio's "CommonExtensions\Microsoft\TypeScript\tmLanguage". It fixed syntax highlighting in the editor.
Root cause: I must have installed the Syntax Highlighting Pack (with Web Essentials) or any other semi-official extension in the past which have pre-populated my Extensions folder with some basic/outdated syntax definitions for TypeScript. I don't know whether both definitions are effective or only the one in the Extensions folder, but the ones installed with the TypeScript SDK are definitely not.
Real solution: The TypeScript language service should force its own grammar over any other installed TextMate definitions.
Check: It works pretty much better, so I think my issue is resolved now, but let me check whether these findings are intended behaviors, known issues or is something still wrong with my setup:

Tool tips are still not colorized correctly. Look at the last screenshot in my last post, HTMLElement is colorized as an identifier and not as a type. It also occurs with Date.
String interpolation braces (including '$') are colorized as keywords.

It looks like the TypeScript syntax highlighting from the Syntax Highlighting Pack extensions overrides the installed one from VS.
See https://github.com/Microsoft/TypeScript/issues/14422#issuecomment-286064439 for the steps necessary to remove the extension.

See the last few comments from https://github.com/Microsoft/TypeScript/issues/14422#issuecomment-286064439 . The Syntax Highlighting pack from @madskristensen was the root cause here.

Ctrl+Space Bar not working. Another bug...

@Peter-Juhasz  @mhegazy @billti @jramsay @Tragetaschen @
Hello All!...
I am having problem with my angular 2 app while loading due to my zone.js.. whereas I have 0.8.20
Version and not able to implement this correctly into my app.. can you please suggest latest version and correct way to implementing it to project.
Also  I have problem with my typescript running on version "^2.8.0-dev.20180308" and problem is I have to convert my example.ts file into example.js by typing command into cmd manually... Can you please suggest how to make typescript work automatically to do conversion of example.ts file into example.js
Added all the files used in my project are pasted here https://github.com/angular/quickstart/issues/384
Thanks in advance!! Please let me know if any help needed.

I've had very similar issues to this in the past fortnight - changes are that I upgraded to latest official release of TypeScript and also applied VS 2017 releases as they've arrived.
Another dev here (the only other dev) has the exact same issue.
We can make some changes in some TS files, but certain changes, I guess where we leave an open brace too long perhaps, causes TS to want to recompile every file in the project.  Only once that's done do we actually get intellisense back.  The syntax highlighting also goes out the window - words are highlighted across boundaries.  It's almost as though text offsets for highlighting and intellisense are not in sync with the actual text in the editor.
It takes a good minute or so to get back in to sync, which has become a huge drain on productivity.
I know I have some of the Web Essentials & related plugins installed but don't really use them so I'll try to remove them and see.  I suspect the other dev here though hasn't ever installed any of those extensions.

I have a similar problem.
I'm using VS 2017 version 15.6.5 and typescript 2.5.
After one or 2 minutes working with ts(x) files intellisense will be gone.
Firstly:

After two minutes working:

After setting compileOnSave to false, problem was resolved.


Change to installer/helm to use peer authentication for global mTLS enable

For mTLS (strict) disable, we will not add any resource (neither using alpha nor beta API). The new behavior in Istio 1.5 is default to permissive in this case.
For mTLS strict enable, we add PeerAuthentication policy at mesh level to set it to strict. This is replace the old MeshPolicy resource.

@howardjohn  I've realized that I didn't commit the change in installer in the last PR. The change under helm is not necessary, though I think it's still better to make it consistent until it got removed.
Please take another look. Tkx

@diemtvu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test gencheck_istio

e2e-dashboard_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test gencheck_istio

e2e-dashboard_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test e2e-dashboard_istio

pilot-e2e-envoyv2-v1alpha3_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test gencheck_istio

e2e-dashboard_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test e2e-dashboard_istio

pilot-e2e-envoyv2-v1alpha3_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-dashboard_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test e2e-dashboard_istio

pilot-e2e-envoyv2-v1alpha3_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-multicluster-e2e_istio

gencheck_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-multicluster-e2e_istio

gencheck_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test gencheck_istio

e2e-dashboard_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-multicluster-e2e_istio

gencheck_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test gencheck_istio

e2e-dashboard_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test e2e-dashboard_istio

unit-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-multicluster-e2e_istio

gencheck_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test gencheck_istio

e2e-dashboard_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test e2e-dashboard_istio

unit-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test unit-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
73b3a2e4ed9564ee38e767c087bbd49482790bcf
link
/test pilot-multicluster-e2e_istio

gencheck_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test gencheck_istio

e2e-dashboard_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test e2e-dashboard_istio

unit-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test unit-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-telemetry-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test gencheck_istio

e2e-dashboard_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test e2e-dashboard_istio

unit-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test unit-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-telemetry-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-telemetry-k8s-tests_istio

pilot-multicluster-e2e_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test gencheck_istio

e2e-dashboard_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test e2e-dashboard_istio

unit-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test unit-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-telemetry-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-telemetry-k8s-tests_istio

pilot-multicluster-e2e_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test unit-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-telemetry-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-telemetry-k8s-tests_istio

pilot-multicluster-e2e_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-security-k8s-tests_istio

e2e-dashboard_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-telemetry-k8s-tests_istio

pilot-multicluster-e2e_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-security-k8s-tests_istio

e2e-dashboard_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test e2e-dashboard_istio

pilot-e2e-envoyv2-v1alpha3_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-security-k8s-tests_istio

e2e-dashboard_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test e2e-dashboard_istio

pilot-e2e-envoyv2-v1alpha3_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-telemetry-k8s-tests_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-security-k8s-tests_istio

e2e-dashboard_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test e2e-dashboard_istio

pilot-e2e-envoyv2-v1alpha3_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-telemetry-k8s-tests_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test integ-telemetry-k8s-tests_istio

pilot-multicluster-e2e_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-security-k8s-tests_istio

e2e-dashboard_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test e2e-dashboard_istio

pilot-e2e-envoyv2-v1alpha3_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-telemetry-k8s-tests_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test integ-telemetry-k8s-tests_istio

pilot-multicluster-e2e_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-multicluster-e2e_istio

lint_istio
4c404c882c2fbdb9ebed178c192ab6e81d678168
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-security-k8s-tests_istio

e2e-dashboard_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test e2e-dashboard_istio

pilot-e2e-envoyv2-v1alpha3_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-telemetry-k8s-tests_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test integ-telemetry-k8s-tests_istio

pilot-multicluster-e2e_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-multicluster-e2e_istio

lint_istio
4c404c882c2fbdb9ebed178c192ab6e81d678168
link
/test lint_istio

gencheck_istio
4c404c882c2fbdb9ebed178c192ab6e81d678168
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-security-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-telemetry-k8s-tests_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test integ-telemetry-k8s-tests_istio

pilot-multicluster-e2e_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-multicluster-e2e_istio

lint_istio
4c404c882c2fbdb9ebed178c192ab6e81d678168
link
/test lint_istio

gencheck_istio
4c404c882c2fbdb9ebed178c192ab6e81d678168
link
/test gencheck_istio

e2e-dashboard_istio
4c404c882c2fbdb9ebed178c192ab6e81d678168
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7bf373950ae10355d0855eb5ce255acb735c6c71
link
/test integ-security-k8s-tests_istio

pilot-multicluster-e2e_istio
6d098d0073c1f180ecebd38a164f9cc558908dd2
link
/test pilot-multicluster-e2e_istio

integ-telemetry-k8s-tests_istio
487d89054945b61b771e3e270102d65d44b4364a
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
487d89054945b61b771e3e270102d65d44b4364a
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
487d89054945b61b771e3e270102d65d44b4364a
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
487d89054945b61b771e3e270102d65d44b4364a
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
28f4e530fef83e1859da9db1b07041c6f2aa6a76
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
28f4e530fef83e1859da9db1b07041c6f2aa6a76
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
28f4e530fef83e1859da9db1b07041c6f2aa6a76
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
28f4e530fef83e1859da9db1b07041c6f2aa6a76
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7e0d5249dbafccec16a93f86eec6a2ee50af7975
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
7e0d5249dbafccec16a93f86eec6a2ee50af7975
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
7e0d5249dbafccec16a93f86eec6a2ee50af7975
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Note: pending on https://github.com/istio/istio/pull/20881
both integ-security-k8s-tests_istio and integ-telemetry-k8s-tests_istio fails because auto-mTLS hasn't been implemented for beta API. As a result, principal does not exist for authZ-deny check, nor metadata for telemtry.

It does. As we no longer add the mesh policy during installation, this
metrics query return nill.
We will have different PR to change the dashboard to reflect the new policy
later.
On Wed, Feb 12, 2020, 8:17 AM John Howard<EMAIL_ADDRESS>wrote:

@howardjohn approved this pull request.
In tests/e2e/tests/dashboard/dashboard_test.go
https://github.com/istio/istio/pull/21017#discussion_r378357300:

@@ -248,6 +248,21 @@ func replaceGrafanaTemplates(orig string) string {
return queryCleanupReplacer.Replace(out)
}

+func istioQueryFilterFn(queries []string) []string {
same comment as the other test, this shouldn't be impacted
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/21017?email_source=notifications&email_token=AF7X24IP54762DUSJQKZ5TDRCQOIFA5CNFSM4KSYUAV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVIGCRI#pullrequestreview-357589317,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7X24NIPEWIVWHTREBANBDRCQOIFANCNFSM4KSYUAVQ
.

It does. As we no longer add the mesh policy during installation, this

This test uses the legacy helm though.. it shouldn't be impacted

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7e0d5249dbafccec16a93f86eec6a2ee50af7975
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
75455e149108c90cb4dc3c73363d6286c0ed7011
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This is very dangerous - please don't add the API to the installer. It is ok if user is explicitly setting it,
but should not be set in the installer.
There are many install/upgrade paths - in the past we had jobs to make sure old resources were deleted ( in case users didn't use --prune), and this impacts our ability to ship multicontrol planes in 1.6 - since this will apply to all control planes.

I actually want to get rid of that too (it was there since ever, for the old API + DR). We can remove this global.mtl.enabled completely, and let user drive their settings via API. It will touch a bunch of e2e tests though

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
75455e149108c90cb4dc3c73363d6286c0ed7011
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
75455e149108c90cb4dc3c73363d6286c0ed7011
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Removing the old option is also unsafe - may break security for users.
Please leave the old one in place, in 1.6 we can remove it after we have a migration tool (as is required for any such change).
1.6 control planes will then ignore the old setting, and the new one will be under user control - as it should be for any API.
There are subtle cases - user may start with permissive and create a (old) authn config by himself.
All of them have critical risks on user security.
The feature should not be on by default as it's launched anyways - and please make sure there is
a flag that allows quick disabling of the new code.

Removing the old option is also unsafe - may break security for users.
Please leave the old one in place, in 1.6 we can remove it after we have a migration tool (as is required for any such change).
1.6 control planes will then ignore the old setting, and the new one will be under user control - as it should be for any API.
There are subtle cases - user may start with permissive and create a (old) authn config by himself.
All of them have critical risks on user security.
The feature should not be on by default as it's launched anyways - and please make sure there is
a flag that allows quick disabling of the new code.

I mean remove the --set values.global.mtls.enabled=x option. We will not adding any resource to config mTLS at installation time.
The implementation already fallback to alpha policy if available, so that strategy works fine with upgrading scenario. Alpha policies still take effect in that case.
For new installation and going forward, it's clearer for users, though they may need to set the policy explicitly. On the other hand, we don't have to handle the problem of adding resources at installation.
The switch for this API is simply remove it.

Removing the old option is also unsafe - may break security for users.
Please leave the old one in place, in 1.6 we can remove it after we have a migration tool (as is required for any such change).
1.6 control planes will then ignore the old setting, and the new one will be under user control - as it should be for any API.
There are subtle cases - user may start with permissive and create a (old) authn config by himself.
All of them have critical risks on user security.
The feature should not be on by default as it's launched anyways - and please make sure there is
a flag that allows quick disabling of the new code.

FYI, I have test the upgrade command (in permissive mode) on 1.4 mesh. It does not remove the existing MeshConfig as expected. We do not change the behavior on strict mode.
I still think this change makes a cleaner installation for 1.5. The default upgrade/installation add no policy (and as confirmed above, it doesn't prune the existing), so doesn't make any change to the existing mesh. At the same time, it will help avoid confusion of what API is used in the newly create mesh.
Thus I'd like to have this submitted and cherry picked to 1.5. What do you think?

In response to a cherrypick label: new pull request created: #21370


Style/IfUnlessModifier throws a false positive when the condition body raises an error

Hello! I'm running into a false positive with the Style/IfUnlessModifier when the condition body raises an error:
# test.rb
super_long_variable_name = 12
if super_long_variable_name == 'my_other_super_long_string'
  raise 'this is my super long error message'
end

[22:33:01] %> rubocop test.rb
Inspecting 1 file
C

Offenses:

test.rb:4:1: C: [Correctable] Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
if super_long_variable_name == 'my_other_super_long_string'
^^

1 file inspected, 1 offense detected, 1 offense auto-correctable

When corrected, it changes the line of code to the following:
super_long_variable_name = 12
raise 'this is my super long error message' if super_long_variable_name == 'my_other_super_long_string'

which is clearly incorrect, even at my line limit of 90 (set in Layout/LineLength). I've commented out all custom rules in my .rubocop.yml file and run this again, and I get the same error. Changing the condition body to any other line (such as an assignment or a method execution) fixes the issue, so I think it's only isolated to raising errors.

Expected behavior
Rubocop should not raise this as a violation of the Style/IfUnlessModifier rule
Actual behavior
Rubocop reports this block of code as violating the Style/IfUnlessModifier rule. Debug output below (DIR is my replacing of my computer's directories)
For /DIR: configuration from /DIR/.rubocop.yml
Inheriting configuration from /Users/user/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/prettier-1.5.5/rubocop.yml
Default configuration from /Users/user/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/rubocop-1.13.0/config/default.yml
Inspecting 1 file
Scanning /DIR/test.rb
Loading cache from /Users/user/.cache/rubocop_cache/e0d642490b17155fb6d3d027de6bfcc19fea0dab/6d7a3b621ca1730e04accd938619e4bdab66cfb1/f63835cee0c0fe552762330b4463568dd634b32b
C

Offenses:

test.rb:4:1: C: [Correctable] Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
if super_long_variable_name == 'my_other_super_long_string'
^^

1 file inspected, 1 offense detected, 1 offense auto-correctable
Finished in 0.14378399995621294 seconds

Steps to reproduce the problem

Create a new file
Write an if condition with a long condition.
Then, raise an error in the condition body with a long message

RuboCop version
1.13.0 (using Parser <IP_ADDRESS>, rubocop-ast 1.4.1, running on ruby 3.0.0 x86_64-darwin20)

I couldn't reproduce this issue. Is Max: 90 set in Layout/LineLength of .rubocop.yml?
% cat example.rb
# test.rb
super_long_variable_name = 12
if super_long_variable_name == 'my_other_super_long_string'
  raise 'this is my super long error message'
end

% cat .rubocop.yml
Layout/LineLength:
  Max: 90

% bundle exec rubocop -a --only Style/IfUnlessModifier
(snip)

Inspecting 1 file
.

1 file inspected, no offenses detected

Hey, yes it is. Reproduced my entire .rubocop.yml below. If it's only an issue I'm seeing, I can continue trying to figure it out, but any pointers/tips would be appreciated!
inherit_gem:
  prettier: rubocop.yml

AllCops:
  NewCops: enable
  TargetRubyVersion: 3.0.0
  Exclude:
    - 'node_modules/**/*'
    - 'tmp/**/*'
    - 'vendor/**/*'
    - '.git/**/*'

Layout/LineLength:
  AutoCorrect: true
  Max: 90

Layout/SpaceInsideHashLiteralBraces:
  EnforcedStyle: no_space

Layout/SpaceInsideBlockBraces:
  EnforcedStyle: no_space
  SpaceBeforeBlockParameters: false

Metrics/AbcSize:
  Max: 25

Metrics/ClassLength:
  Max: 500

Metrics/MethodLength:
  Max: 50

Metrics/ModuleLength:
  Max: 500

Style/Documentation:
  Enabled: false

Style/FrozenStringLiteralComment:
  EnforcedStyle: always_true

Style/NegatedIf:
  Enabled: false

Style/PercentLiteralDelimiters:
  PreferredDelimiters:
    default: '()'

Style/SymbolArray:
  EnforcedStyle: brackets

Style/TrailingCommaInArrayLiteral:
  EnforcedStyleForMultiline: consistent_comma

Style/TrailingCommaInArguments:
  EnforcedStyleForMultiline: consistent_comma

Style/TrailingCommaInHashLiteral:
  EnforcedStyleForMultiline: consistent_comma

Ah, it looks like the prettier's rubocop.yml is interfering with this specific style, for some reason. Sorry to both y'all then; thanks for looking into this!

Ah, just to close the loop on this, looks like the prettier-ruby rubocop.yml file disables all Layout/* cops, which means that Layout/LineLength is disabled, so Style/IfUnlessModifier thinks that line lengths are unlimited. I'll go open a request in their library!


Feature Request: Label URL should be compatible with custom domain

Is your feature request related to a problem? Please describe.
It's currently impossible to execute a request to a labeled revision by using the custom domain. It's only available on the default random generated domain.
Describe the solution you'd like.
Label URL and Revision URL should use custom domain instead of the random generated domain.

Describe alternatives you've considered.
Trying to use the random generated domain provided.
Unfortunately, due to the randomness of the domain, we are unable to use it.
Additional context.
Documentation regarding Label URL: https://learn.microsoft.com/en-us/azure/container-apps/revisions#labels

Any update on this feature request ?

Hi @dsczltch, thanks for flagging this. I've added making the label URL compatible with custom domain to our backlog, and we'll evaluate this to see if we get this added.
Can you elaborate a bit on the randomness of the generated domain making it unusable for you with labels? Do you mean the randomness in the generated name of the default domain?

@cachai2 Hi, at first the random default domain was not available in the terraform output. It is now.
However, we are use to provision and deprovision resources automatically, which update the default domain.
Many developers use services hosted on container app and are not going to look for a new URL everytime, that's one we configured custom domain.
I think @bgrainger explained very well the use case we all want to use.

Thanks @bgrainger and @dsczltch for the detailed feedback. This is super helpful in understanding the exact scenario and what you're looking to address. The feature ask makes sense. I'll follow-up with the team to see if we can get this onto the roadmap.

It might also work to have myapi--pr123.example.com, but that's harder on our end to configure DNS if we also have yourapi--pr234.example.com and thirdapi--pr345.example.com that all have to be CNAMEd to different Container Apps. They can't just be *.example.com.

@bgrainger if I'm understanding this correctly, you should be able to achieve this today. See this doc https://learn.microsoft.com/en-us/azure/container-apps/environment-custom-dns-suffix
Essentially, you can replace the randomwords-digits.westus2.azurecontainerapps.io part with your own custom example.com domain. You just need 1 wildcard DNS record for *.example.com to your environment IP.
Then whenever you create app foo, you can reach it at https://foo.example.com, and if you add a pr123 label then you can reach it at https://foo---pr123.example.com.

Thanks for the link to the docs; I hadn't seen that particular one before. Some pain points I foresee from trying that:

The current custom subdomain for the Container App is myapi which doesn't match the Container App name of myapicontainername. Not a deal-breaker, but a little bit of unnecessary friction. I'd prefer the exact name from the custom domain to be used.
Requires us to provision and regularly update a wildcard certificate. Obviously can be automated (ACME, etc.) but would be nice to have this be built in.
Setting up wildcard DNS for *.example.com is a broad requirement and I don't think I could get approval to have all new and mistyped subdomains for my company resolve by default to a (non-existent) Container App.
Since there is a single domain suffix per Container App Environment, you're forced to have domain suffixes that reflect internal team structure (if you should have more than one CAE). Currently, I can have team1api.example.com and team2api.example.com that are served from different Container App Environments. But since only one team can claim *.example.com, I'd have to redeploy the apps at, say, team1api.team1.example.com and team2api.team2.example.com (with wildcard domain suffixes that match my internal team structure). I don't want to be forced to use DNS to expose the internal organization of Azure resources.

For companies that already have public DNS highly structured according to internal organizational boundaries, the custom DNS suffix suggestion might work, but in general I don't see it being feasible.


z-index too low

The modal is disappearing behind the sidebar. It would be great to have the modal either on the side of the sidebar or on top.
To be on top it needs to be more than 999991, ie the z-index of the sidebar.
Apart from that cool component; I did not think it was possible currently.

Hi @coolkau . Could you create a pull request for this?

I suggested a change but as noted in the comment I am well versed in css.

Fixed in https://github.com/teamtv/streamlit_modal/pull/3 Thanks!


[FEATURE REQUEST] Pull TVP name from SQLServerDataTable to avoid execution of sp_sproc_columns_100

Is your feature request related to a problem? If so, please give a short summary of the problem and how the feature would resolve it
We use a lot of TVPs via PreparedStatement.setObject().  Often times, we're able to do this by passing in a SQLServerDataTable instance but rarely are we ever able to use SQLServerPreparedStatement.setStructured().  This causes SQLServerPreparedStatement to forcibly report the tvpName as null and then execute a query to load the tvpName (sp_sproc_columns_100 for modern SQL Servers).  The execution of that query happens ends up executing about 1.4 million times per hour and causes a high CPU as a result.
Describe the preferred solution
In situations were we can still infer the tvpName without using setStructured(), such as when a SQLServerDataTable is passed in, use the provided tvpName.
Describe alternatives you've considered
We could alternatively use SQLServerPreparedStatement.setStructured().  That requires calling unwrap() on the PreparedStatement we have which breaks a metrics utility we use.  Additionally, the problem is further complicated by frameworks like JdbcTemplate and Apache QueryRunner which may not provide access to the underlying SQLServerPreparedStatement but still accept SQLServerDataTable instances.
Additional context
This information was gained by querying sys.dm_exec_query_stats in SQL Server 2014.

Hi @Logic-32 ,
We will investigate and get back to you soon.

Hi @Logic-32 ,
To understand the scenario better, please provide a reproduction code/table schema with setObject().

Type:
CREATE TYPE dbo.Integers AS TABLE
(
	Token INT NOT NULL
)

Proc:
CREATE PROCEDURE echoTVP
(
	@accountIds dbo.Integers READONLY
)
AS
BEGIN
	SELECT * FROM @accountIds
END

Java:
public static void main(String[] args) throws Exception
{
	DataSource ds = // create DS;
	try (Connection conn = ds.getConnection();
		 PreparedStatement stmt = conn.prepareStatement("EXEC echoTVP @accountIds = ?"))
	{
		SQLServerDataTable accountIdRows = new SQLServerDataTable();
		accountIdRows.setTvpName("dbo.Integers"); // Important part here //
		accountIdRows.addColumnMetadata("token", Types.INTEGER);
		accountIdRows.addRow(1);

//			stmt.unwrap(SQLServerPreparedStatement.class).setStructured(1, "dbo.Integers", accountIdRows); // This is the alternative //
		stmt.setObject(1, accountIdRows);

		try (ResultSet rs = stmt.executeQuery())
		{
			System.out.println("--- got something");
		}
	}
	finally
	{
		((AutoCloseable) ds).close();
	}
}

Hi @Logic-32 ,
What you are proposing makes sense, I created #1282. Please feel free to review the PR and let me know if it resolves your issue.

Looks more comprehensive than the PR I submitted :) So, yes.  I believe it will resolve my issue and then some.  Thanks!

@ulvii, do you happen to have any updates on this?  I'm curious, what's the normal timeline for getting something like this merged/tagged?  I'm not in a huge rush, just want to know if I should go about experimenting with a patched version internally or if it'll be out soon enough I don't have to worry about it.

Hi @Logic-32 ,
We will try to include the change in the next preview release, which is scheduled for March 31st.

#1282 merged.


Test system

Add test for system.py. Not completed -  some lines still required testing. I am especially confused about the requirement of a box for gas phase structures.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.75%. Comparing base (db7c4a7) to head (24c7d7b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   62.04%   58.75%   -3.29%
==========================================
  Files          37       37
  Lines        4226     4226
==========================================
- Hits         2622     2483     -139
- Misses       1604     1743     +139

Flag
Coverage Δ

python-3.9
58.75% <ø> (+0.70%)
:arrow_up:

python-3.9-ace
?

python-3.9-mace
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fixed travis.yml: reference to neo-python@master now

Just fixed travis by using neo-python@master now

Coverage remained the same at 92.468% when pulling 2d863139f208da0167746e4cadc900e59ce5e32a on metachris:travis-fix into fde79d356972b7ad62cfcf0b4a3b4d1f4f3501e9 on CityOfZion:development.


Use built-in fetch() in Browsers and node-fetch in Node

Work Item
#8725 discussion around node-fetch in the browser:

We only support browsers that support Fetch() API, so we should not need to include Fetch polyfills.
node-fetch v2 defers to Browser built-in Fetch() in browser context
node-fetch v3 removes Browser support
Bundling R11s-driver with Vite and Webpack 5 forces addition of Node polyfills to support node-fetch.

#9433 replaced node-fetch with cross-fetch in R11s-driver as a temporary fix for Vite and Webpack 5 projects, but this technically increases bundle size because it ponyfills Fetch().
Describe the outcome you expect
node-fetch and Fetch() polyfills/ponyfills should not be included in browser bundles.
Approach
Explicitly use Browser Fetch() in the browser, and "polyfill" Fetch() in Node (likely using node-fetch).
Open questions

Why did Vite and Webpack 5 require Node polyfills even though node-fetch v2's package.json does not have Node dependencies in the "browser" entry?
Upgrade node-fetch in both ODSP-driver and R11s-driver? Or add isomorphic fetch implementation to shared space (e.g. common-utils) so that each driver can consume when ready?

Acceptance criteria

R11s-driver browser bundle does not include Fetch() polyfills
R11s-driver bundles without Node polyfills in Vite and Webpack 5
R11s-driver still functions in Node.js environment

What is the status on this? Thanks?


Add imprint model

As this is my first PR in the django repo (and my first every python PR), please review very carefully.
There are several things I'm not quite sure about. I'll add comments for these things.
If I am not following your conventions somehow, please let me know.
Fixes #357

In general, this looks very good +1, Just had some minor comments.
Apart from that, I stumbled over the terminology: Imprint is not the correct translation of Impressum, so I wondered if we might change the wording here to DisclaimerPage. Sorry that this was described incorrectly in the issue. What do you think about this?

I think we had the reverse discussion in Nürnberg on the DF Tagung and we decided to use the term Imprint. At least we renamed the issue from Add DisclaimerPage model to Add ImprintPage model. I think @svenseeberg was in favor of imprint.

Personally, both is fine to me. Maybe also @dkehne has an opinion? At least DeepL translates Impressum with Imprint.

agree on Imprint instead of Disclaimer.

Thanks, working now :)


Getting Started: Guidance around ideal image size

I tried adding an image and it gets restricted quite a bit:

The pixel size seems pretty random:

As a result of this, the image above is overly blurry. I could use a 531x470 image to fix this but that number could change and it would also look bad on hdpi.
Ideally we'd tell people what the ideal image size is as well as how to deal with hdpi monitors (optional separate set of images?). Extra points for showing the guidance on hover/autocomplete of the media entry.

We currently treat images as 1.5x scale (797 = 531 * 1.5), as all the builtin images have been designed for this. We could perhaps support multiple images and use src-set, I didn't want to do that at first because you end up bundling more bits for all the different sizes (unlike in the web case where src-set saves you bandwidth).
cc @digitarald

If images are all 1.5 scale aren't they going to look not great in both x1 and x2 scale displays?

So far the hdpi (1.5) versions have looked acceptable on mdpi and xhdpi screens as most images are downscaled screenshots and don't need to be pixel-perfect (compared to icons).
If we want crisper screenshots, I'd like to try 2x images and see how they scale down to 1x and 1.5x. I'd assume that browser resizing does as good of a job as doing specific DPI exports from Figma. Maybe others are aware of performance trade offs here that we also need to consider on top of the additional asset size in the installer.

Added some text in the intelisense:
depending on context, the image will be displayed from 400px to 800px wide, with similar bounds on height. To support HIDPI displays, the image will be rendered at 1.5x scaling, for example a 900 physical pixels wide image will be displayed as 600 logical pixels wide.


WEB-59 | Alternate layout for sidebar

This change is

Do not merge this PR. Once the development of the Main-Repo is complete, we can safely merge this into maste.


Document refetch behavior

I think it would be very helpful to document how refetch behavior works with apollo-link-state. I lost a day with what I though was a bug in apollo-link-state. It didn't occur to me that refetch would set my state cache back to the defaults I set in withClientState.
It makes sense after putting all the pieces together. Unfortunately, it took me a day to solve this puzzle 😢
I imagine a lot of people write their queries similar to this:
const queries = gql`
  query {
    localQuery @client {
      someField
    }
    remoteQuery {
      someField
    }
  }
`;

export default graphql(queries)(MyComponent);

refetch-ing data in this scenario will reset localQuery to whatever is set in withClientState's defaults.
Developers will need to find a pattern that allows them to refetch their remote and local data independently.
Here's a pattern that I'm using. I don't know if it's any good but it's working for me for now.
const httpQueries = gql`
  query {
    remoteQuery {
      someField
    }
  }
`;

const stateQueries = gql`
  query {
    localQuery @client {
      someField
    }
  }
`;

export default compose(
  graphql(httpQueries, { name: 'httpData' }),
  graphql(stateQueries, { name: 'stateData' }),
)(MyComponent);

I agree @anthonator -- I think the whole apollo-link-state defaults feature is a full of pitfalls. In our app, we're providing/testing our defaults inside of our state-link, and we don't use the Defaults feature at all.

I too ran into this and think it is unintuitive behavior, at least in how I interpreted the docs. It seems like, since fields with the @client directive resolve to the local cache instead of the network, that refetches to the network therefore should not affect them.

Uups, that explains a few hours of my debugging too. Thanks @anthonator for writing this up!

Is this behavior working as intended?

Facing the same issue. Is there any solution to this problem ?

I specifically have this problem when trying to test a local mutation.
it("should update SearchText when the TextField is changed", async () => {
    let apolloClient
    const wrapper = mount(
      <MockedProvider mocks={mocks} addTypename={false}>
        <ApolloConsumer>
          {client => {
            apolloClient = client
            return <Search />
          }}
        </ApolloConsumer>
      </MockedProvider>
    )

    await wait(0)
    wrapper.update()

    // make sure search text is empty string on initial query
    const { data } = await apolloClient.query({ query: GetSearchRules })
    expect(data.searchRules.text).toBe("")

    // simulate an on change event on the text field, triggering a local
    // state mutation
    const event = { target: { value: "new search" } }
    const textField = wrapper.find("input")
    textField.simulate("change", event)

    await wait(0)
    wrapper.update()

    // check if getSearchText query returns correct string
    const { data: newData } = await apolloClient.query({
      query: GetSearchRules
    })

    // fails, because the query needs to be refetched, but cant refetch it
    // because it refetching local queries resets it to default state, which is null
    expect(newData.searchRules.text).toBe("new search")
  })

After I simulate the button click, a local state mutation fires which updates my state. When I make the second query, it fails because the local-state query needs to be refetch, but that causes the local state to be reset.
In my <Search/> component, if I add refetchQueries={[{ query: GetSearchRules }]} to the <Mutation/> component prop, my tests pass, but the UI is broken.  If I remove refetchQueries, tests fail, but UI works as desired.


904 reduce number of time series tables

A new class to interact with the database - TimeSeriesRDBClientWithReducedTables, is introduced. Usage guidelines and how it works is detailed in https://github.com/cambridge-cares/TheWorldAvatar/blob/363d76e4de38fa6f56f1d578e8ccbbc76df7fe4a/JPS_BASE_LIB/src/main/java/uk/ac/cam/cares/jps/base/timeseries/README.md
Existing agents using the TimeSeriesClient should work without any changes.
@mdhillman These changes will impact the FIA because the same TimeSeriesRDBClient class needs to be used to create and query the time series data. Perhaps you can add a user input to specify which class to use, or maybe I could provide something in TimeSeriesClient for you to determine which version to use.

I am going to push back on this and suggest not making this update until we review the design. I believe that the FIA configuration is already too complex for a lot of people; you already have to have a-priori knowledge of what datetime class was used when the data was input (something I am not happy with), adding knowledge of what client class was used may be to much.
What happens when the person that added the data is no longer with us and has left no documentation? What happens when we start to provide APIs for direct access to our data?
I would suggest that all metadata needed to retrieve the timeseries data should be captured as triples within the KG. We already do this with some fields (measurement name, unit etc), why are we not following the existing approach here?

Marking up the time class is a trivial thing to do, but I don't see any way around the time class issue due to the way Java works and having the flexibility of adding any type of data you like, at most we can support a fixed set of classes and hardcode them in the FIA.

My belief is that if we have to hardcode anything, then our design is incomplete. We may be able to get away with it in the FIA, but what happens when we add more functionality? Do we just endless hardcode stuff?
What happens when an new agent needs to get time series data for some calculation? What happens when we need to provide a generic API to our data (this is already being discussed with external partners at CMCL).
We have already had discussions in a number of projects about (potentially) making our data meet FAIR Principles. To me, this seems to me actively moving in the other direction.
I will try to book in a discussion next week to go over this.

Actually depends on how you want to query it, to get the entire time series, you can get away with using Object.class and the wildcard, it will be an issue if you want to specify the bounds

A new TimeSeriesClientFactory class has been added, it queries the time class and rdb client class and then creates the appropriate TimeSeriesClient object. The variables still need to be casted if you want to perform any operation on them.
The TimeSeriesClientFactory relies on a couple of new triples not added by previous versions, so if you want to use this, the time series data need to be reinstantiated, or the triples can also be added manually.
In this revision the class of the values is still ambiguous, though for visualisation purposes, the getValuesAsString may work for a variety of types if we want a generic implementation.


Upload all distribtest dockerimages to dockerhub

remove distribtests for ubuntu1504 and 1510 as these distributions are past their end of life and the base docker images are not buildable anymore (Err http://archive.ubuntu.com wily/main Sources and Err http://archive.ubuntu.com vivid/main Sources).
update the push_testing_images.sh script to push all distribtest images
make a few broken python distribtest base images buildable again

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


NullPointerException when accessing series details

When accessing the series details in the admin interface with the default configuration, a NullPointerException is being logged:
2021-01-17 14:33:05,938 | ERROR | (FeedEndpoint:74) - Could not get /feeds request in FeedEndpoint. java.lang.NullPointerException

Happens on r/9.x

Resolved with https://github.com/opencast/opencast/commit/f9a1090a2ab4764a9e090be423491b168d4c1a15

Resolved with https://github.com/opencast/opencast/commit/f9a1090a2ab4764a9e090be423491b168d4c1a15


Allow retrying on non-HTTP errors

https://github.com/bazelbuild/bazelisk/commit/787006c7de3b08807b592fe14349608cd99532b0 added support for retrying HTTP errors, this extend that to retry when an HTTP connection cannot be made.
This helps when bazelisk failes to speak HTTP:
2024/01/16 14:31:11 could not download Bazel: HTTP GET https://releases.bazel.build/7.0.0/release/bazel-7.0.0-linux-x86_64 failed: Get "https://releases.bazel.build/7.0.0/release/bazel-7.0.0-linux-x86_64": dial tcp <IP_ADDRESS>:443: i/o timeout

Fixes: #432

Looks like TestShouldUseExponentialBackoffIfNoRetryHeader is already flaky on master.
go test -count=100 -run TestShouldUseExponentialBackoffIfNoRetryHeader ./httputil -v gives me 8 failures out of 100

Thanks! I merged https://github.com/bazelbuild/bazelisk/pull/530, so you can rerun the tests here.


Add instructions to README.md on how to get binary from image.

https://issues.redhat.com/browse/OCM-883

/cc @bardielle


Modify typescript rules for development

Just try to do development without disabling some of these rules. I wasted hours. It is especially bad with the auto-compile of webpack.
I agree these aren't what we want for production builds but like @jotak suggested yesterday, it looks like we need a dev and prod separation. Someone can create a task for that.
Create UI Scaffolding

Merge this if you want to get any work done ;)

@mtho11 in this PR [ https://github.com/swift-sunshine/swsui/pull/15/files ] I only had to change no-console and no-any, and it's quite fine (it builds & run quite well)

Ok so https://github.com/swift-sunshine/swsui/pull/14 make this one old so I will close


Add .i686 suffix to openssl package in 32 bit dockerfile

Forgot to add .i686 to the openssl-package in #908.
Link to 32 bit Jenkins job: http://jenkins.hazelcast.com/job/yinci-cpp-linux-32-STATIC-Debug-clone/

Linux test PASSed.

Windows test PASSed.


CI extra checks

[x] go.work to ci
[x] go.mod check to pkg pr workflow
[ ] commitlint job checks PR title

#23


Make sure that docker starts before launching the buildkite-agent

This changes order of services to fix issue #256 so that docker starts up before buildkite-agent.

Thanks! Not sure why I haven't done this before, but fingers crossed it improves things. I will cut a new release candidate.


core: count references of notification events

Close #2482.

Looks like I've misinterpreted the original change, see https://github.com/neo-project/neo/pull/2729#discussion_r874303243. We don't have this issue at all, so this PR isn't needed.

To me, yes, it looks like we're adding something to the refcounter.

I got it, it adds the array to the refcounter and updates ObjectReferences, but it doesn't modify StackReferences. So the emitted notification is not on the stack, and thus, it shouldn't be taken into account while checking references after subsequent VM instruction handling.


Whitespace sensitive parsing

I have two sql
INSERT INTO `my_table` (id, first_name, last_name) VALUES (1, 'John',NULL);
INSERT INTO `my_table` (id, first_name, last_name) VALUES (1, 'John', NULL);

First one produces value []byte("NULL") with type ValueTypeNULL
Second one []byte(" NULL") with type ValueTypeString

Could you please specify a mysqldump version which creates a dumps with spaces? I mean this case:
INSERT INTO `my_table` (id, first_name, last_name) VALUES (1, 'John', NULL);

It is not mysqldump
I wrote this sql by hands

This case may be solved with additional checks within the code. And it's affect to performance. So I don't think we need to fix this without real issue. I hope you are agree with me?

no problem
i can live with it


[FEAT] Add test coverage

Describe the solution you'd like
A quick script to find the total code coverage for the splink repo. This should help in identifying areas in which our tests are insufficient.
Additional context
We could also make this an action and add it to the splink README.

This could also be useful to identify any code that is no longer actually used in Splink


[CR]: Rotating Gear

Category
Shapes
Inspiration
No response
Description
I would like to have a simple Gear that is rotation and if you want to a second smaller gear that is intersectring the bigger one and they are spinning together.
Are there any possible issues with the idea
The smaller Gear has the right rotation to match the bigger one
TODO's

[X] The component hasn't been suggested / isn't already implemented yet.
[X] The title is clear and descriptive.
[X] The component is properly described.
[X] The Component has good tags.

Code of Conduct

[X] I agree to follow the Code of Conduct

Feedback on Process
No response

Could u give me an example or describe it clearly. I want to help u


suggestion trigger

i select a function name of suggestions window and for trigger it i want to use "(" instead "enter"/"tab".  like < idle >.

Thanks for asking about this, @byehack.  I just want to make sure I've understood your request before we move forward.  You want completions to automatically show up after you type (, like they do for ctrl-enter?

no bro.
see this setting on vscode: editor.acceptSuggestionOnEnter
i want to add some special words to accept suggestions: (now i can just use "enter" or "tab")

i write "pri" for example:

i go down on "print" function and i want to when i pressed the "(" it will write "print("

Ah, thanks for clarifying.  This is something you'll have to ask from VS Code itself.  Unfortunately, the Python extension has no control over the functionality of that UI element.

I can't transfer the issue, so please open a new one at: https://github.com/microsoft/vscode/issues/new/choose
Feel free to reference this one.

@ericsnowcurrently Hi! Coming back from https://github.com/microsoft/vscode/issues/86644
Looks like this is behavior should be enabled by LS extension by providing language aware commitCharacters for CompletionItem.
PR that adds support for TS/JS https://github.com/microsoft/vscode/pull/18380
Could you revisit this issue?

can't you add this option?

Ah, thanks for the info, @IllusionMH.  I'm going to send this over to the language server project.


Unit Tests not correctly associated with PR Checks

After raising the following PR: https://github.com/ministryofjustice/modernisation-platform-github-oidc-provider/pull/3
You can see in the checks that the Go Terratest does not seem to be associated with the pull: https://github.com/ministryofjustice/modernisation-platform-github-oidc-provider/pull/3/checks
However, in the actions you can see that the PR does trigger the correct action: https://github.com/ministryofjustice/modernisation-platform-github-oidc-provider/actions/runs/2775044838

this is now working


【OSCP】在 YACL 上支持基于 OT 的 Private Set Union 算法

Fixed #98

Thanks for you contribution, currently this PR is under security review by our team, this PR will be merged if our security team has no more concerns.

Could you explain the implementation of the function Interpolate() in yacl/crypto/primitives/psu/krtw19_psu.cc?

The key recursive step is the following
$$[x^k](x-x_1) \dotsm (x-x_j) = [x^k](x-x_1) \dotsm (x-x_{j-1}) + x_j \cdot [x^{k-1}](x-x_1) \dotsm (x-x_{j-1}),$$
where $[x^k] p(x)$ represents the $k$-th order coefficient $p_k$ of the polynomial $p(x)=\sum_k p_kx^k$.

Could you explain the implementation of the function Interpolate() in yacl/crypto/primitives/psu/krtw19_psu.cc?

The key recursive step is the following xk⋯(x−xj)=xk−1⋯(x−xj−1)−xj⋅xk⋯(x−xj−1), where [xk]p(x) represents the k-th order coefficient pk of the polynomial p(x)=∑kpkxk.

Sorry I've been away from work for some time. Can you please explain more details about the codes (or, is there any other references that you can refer your code to? If there is, we may speed up the security-review process and merge this PR). Many thanks.
Again, sorry for the delay :)

Could you explain the implementation of the function Interpolate() in yacl/crypto/primitives/psu/krtw19_psu.cc?

The key recursive step is the following xk⋯(x−xj)=xk−1⋯(x−xj−1)−xj⋅xk⋯(x−xj−1), where [xk]p(x) represents the k-th order coefficient pk of the polynomial p(x)=∑kpkxk.

Sorry I've been away from work for some time. Can you please explain more details about the codes (or, is there any other references that you can refer your code to? If there is, we may speed up the security-review process and merge this PR). Many thanks.
Again, sorry for the delay :)

The implementation is based on the following formula (w.o. optimization).

I made some minor changes to the original codes to improve readability.
// @param x The x-coordinates of the points.
// @param y The y-coordinates of the points.
// @return The interpolation polynomial L(X) such that L(x[i]) = y[i] for all i.
auto Interpolate(const std::vector<uint64_t>& x,
                 const std::vector<uint64_t>& y) {
  using Poly = std::vector<uint64_t>;
  size_t n{x.size()};
  Poly L(n);  // L(X) = sum_{i=0}^{n-1} y[i] * Li(X)
  for (size_t i{}; i != n; ++i) {
    Poly Li(n);       // Li(X) = num(X) / den
    uint64_t den{1};  // den = ∏_{j≠i} (x[i] - x[j]) = den<n-1>
    Poly num(n);      // num(X) = ∏_{j≠i} (X - x[j]) = num<n-1>(X)
    for (size_t j{}; j != n; ++j) {
      if (x[i] != x[j]) {
        den = GfMul64(den, x[i] ^ x[j]);  // den<j> = den<j-1> * (x[i] - x[j])
        uint64_t num_km1{0};              // num<j-1>[k-1]
        for (size_t k{}; k != n; ++k) {
          // num<j>(X)[k] = (num<j-1>(X) * (X - x[j]))[k]
          //              = (num<j-1>(X) * X)[k] - (num<j-1>(X) * x[j])[k]
          //              = num<j-1>(X)[k-1] - num<j-1>(X)[k] * x[j]
          num_km1 = std::exchange(num[k], num_km1 ^ GfMul64(num[k], x[j]));
        }
      }
    }
    for (size_t k{}; k != n; ++k) {
      Li[k] = GfMul64(num[k], Inv64(den));
      L[k] ^= GfMul64(y[i], Li[k]);
    }
  }
  return L;
}


Your request to provision "New Employee Onboarding Hub" template failed!

Describe the issue
Unable to create a hub based on the template: 7d649598-d87c-4d54-bf1a-fdde29b7320e !
Expected behavior
Expected the sites to be created
Screenshots
If applicable, add screenshots to help explain your problem.
Details (please complete the following information):

PnP Correlation ID: [Provide a correlation ID for the provisioning action]
Reference Template: [please provide the URL of the template in the Look book site. It should be something like: https://lookbook.microsoft.com/details/{Template-ID}]
Primary language of the target tenant: [provide the LCID of the primary language of the target tenant]
Are you using a Tenant Global Admin account to provision the template: [Yes/No]

Additional context
Add any other context about the problem here.

Hi,
Thanks for using the Look Book site. This seems to be a random hiccup on the SharePoint side which would imply that the template should work properly if you try it one more time. Seems that the provisioning did succeed partially. Can you test this one more time and, in case of any failure, share the updated Correlation ID (by creating a new issue) for us to double-check the flow. Thanks.


fix: fixing some type hints for optional params

Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[ ] I have read the CONTRIBUTING doc
[ ] I used the commit message format described in CONTRIBUTING
[ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Starting with Python 3.10, implicitly defining optional is not needed. We should check which we wish to use:
int | none
or
Optional[int]

Starting with Python 3.10, implicitly defining optional is not needed. We should check which we wish to use:
int | none
or
Optional[int]

+1 to int | None, since Optional is confusing and doesn't actually align with whether a parameter is optional.

What's the scope of this pull request? I know there are other files (hybrid_job.py at least) that require updates. Is this meant to be all of the updates or just some?

Starting with Python 3.10, implicitly defining optional is not needed. We should check which we wish to use:
int | none
or
Optional[int]

I use Optional[] if other parameters in this function already use the Optional syntax. I don't think we need to go through all the places where we use that syntax and change it to | None.

Starting with Python 3.10, implicitly defining optional is not needed. We should check which we wish to use:
int | none
or
Optional[int]

+1 to int | None, since Optional is confusing and doesn't actually align with whether a parameter is optional.

See comment above

What's the scope of this pull request? I know there are other files (hybrid_job.py at least) that require updates. Is this meant to be all of the updates or just some?

I am working on adding linter checks for these missing types so I am not opposed to merging this as long as we have a consistent convention. This saves me an immense amount of time later so having some finished is better than none!

Starting with Python 3.10, implicitly defining optional is not needed. We should check which we wish to use:
int | none
or
Optional[int]

I use Optional[] if other parameters in this function already use the Optional syntax. I don't think we need to go through all the places where we use that syntax and change it to | None.

I think it likely makes sense to converge on a single style that we stick to, though if we don't care to prioritize that update we could allow both methods in the meantime

What's the scope of this pull request? I know there are other files (hybrid_job.py at least) that require updates. Is this meant to be all of the updates or just some?

This should be all of them, it's weird that it wasn't picked up. I'll investigate.

What's the scope of this pull request? I know there are other files (hybrid_job.py at least) that require updates. Is this meant to be all of the updates or just some?

This should be all of them, it's weird that it wasn't picked up. I'll investigate.

Oh, I see. I'm not handling keyword only args... have to fix that.


Feature/zod preprocess option

Status

READY
Description
Add the possibility to setup a preprocess mutator before validating data for zod.

@anymaniax
cc: @soartec-lab @melloware
Thank you for your works.
I'm working for this issue and I want to confirm why zod preprocess is implemented for only response.
You added type for preprocess not only response but also others.
https://github.com/orval-labs/orval/blob/19c0ca434f55e0d0513ebd6eb00c8b665c620be6/packages/core/src/types.ts#L407-L413
However, generateZodRoute works for only response.
https://github.com/orval-labs/orval/blob/404c1975c805d1c70d3893863e758bde9d269323/packages/zod/src/index.ts#L636-L760
Do you have any problems to implement zod preprocess for param, query, header and body?

@mktktmr please add it I think that was the original intent.


Update user guide 15rc

I like the new format of the UG. Good job, more coherent when we take out the Three Steps to Get Started.


[opentelemetry-cpp] remove otlp feature which doesn't exist

The OTLP is not a separate feature and is deprecated in the upstream repo. The feature is either otlp-grpc or otlp-http.
https://github.com/open-telemetry/opentelemetry-cpp/blob/main/CMakeLists.txt#L197

Gentle ping:)

Thanks for the PR!


Upgraded project to React Native 0.56.  Sentry build fails on Android "actual and formal argument lists differ in length"

OS:

[ ]  Windows
[x]  MacOS
[ ]  Linux

Platform:

[ ]  iOS
[x]  Android

Output of node -v && npm -v && npm ls --prod --depth=0
v9.3.0
5.5.1
/Users/me
└── (empty)

Config:
<EMAIL_ADDRESS>).install()

I have following issue:
Building for Android returns this error:

Error:(53, 9) error: constructor RNSentryPackage in class RNSentryPackage cannot be applied to given types;
required: no arguments
found: MainApplication
reason: actual and formal argument lists differ in length

Steps to reproduce:
Upgrade project to React Native 0.56.1
MainApplication.java contains
        new RNNotificationsPackage(MainApplication.this),

Actual result:
Build error
Expected result:
Successful build

The RNSentryPackage class doesn't have a constructor:
https://github.com/getsentry/react-native-sentry/blob/master/android/src/main/java/io/sentry/RNSentryPackage.java#L14
Somehow either the updated versions of RN 0.56, Gradle 4.6, or Android SDK 28.x have removed default constructors.  Not sure exactly what it is, but something involving constructors has changed.

This is actually a bug, I will release a new version tomorrow with a fix for this.

Yes it's working great.  Thanks @HazAT

@cihati
Remove the argument and simply call
new RNSentryPackage()

Yes, this did solve the issue -- thanks @peacechen and @HazAT  =)


dragengine 1.11 build failure: missing 'engine/declEngine.h' file

When building on Haiku x86 w/ GCC 11.2.0:
URL: https://github.com/LordOfDragons/dragengine/blob/master/src/launcher/console/src/consolelauncher.cpp
Compiling src/launcher/console/src/consolelauncher.cpp
src/launcher/console/src/consolelauncher.cpp:54:10 fatal error: engine/declEngine.h: No such file or directory

#54 | #include "engine/declEngine.h"

Fixed with commit be551195e56274806a9072048a5cdf826c77ab56 , tag "v1.11-haiku2". Builds now again on VirtualBox image. Pull request https://github.com/haikuports/haikuports/pull/6786 .