Spike: investigate redirect urls for consumer applications in Cognito

Describe the task
Start the conversation with other teams to gather their feedback about redirect urls support. Think about solutions within our teams and list pros and cons.
Acceptance Criteria

[ ] Meet with other teams to hear feedback
[ ] Document the feedback from other teams
[ ] Document the solution options and pros and cons for each

Additional context

previous spike ticket for creating api for consumer application to self-manage redirect urls: #727
implementation ticket for creating api: #922

Some options so far, need to brainstorm more:

FAM creates the api to support downstream application self-manage their urls

pros: downstream application can manage their own urls, FAM doesn't need to take care of it anymore
cons:

each application team either manually use the api, or integrate the api in their pipeline, it's also extra work
we need to think of security and implementation, limit each application team's access
we need to let the terraform know the api change, so our regular release won't rewrite whatever the api changed. Or separate the api piece completely

Downstream applications set limit on pr numbers: instead of having the dev deployment url uses the pr number, change it to only use a list of fixed numbers, say pr1-5. So for the prs don't need the login functionally for reviewing, they can still use the regular pattern to do dev deployment with login disabled. But for the prs they want login in dev deployment, change the deployment url to a fixed number.

pros: FAM can always support those fixed dev urls, and will not lose them because of doing new release. No other work needs to do
cons:

downstream apps need to config the dev deployment url when necessary
it's easier than implement the api, but downstream apps might don't like we push the problem to them

Downstream applications submit pr to FAM to change their redirect urls

pros: we don't need to take care of these urls for each release anymore, as long as we review and merge the prs
cons:

we still need to manually add the urls
downstream apps need to work on the pr
downstream apps also need to take care of the clean up of the redirect urls once they're done with the pr

Suggestion from Ricardo:
how about having some terraform changes triggered by PRs itself?  Since every PR will require a new URL, and that PR knows the new URL as well, we could send that through a GHA, do changes and open PRs on FAM, can't we?

Downstream applications handle redirect in their app: we put a fixed base url in the Cognito client, for example "https://nr-silva-frontend.apps.silver.devops.gov.bc.ca/authCallback" and then each consumer application will handle the redirect when receive the "/authCallback" route and then redirect to their pr number url say "/168". This is not recommended compared with other options, just listed it here cause it is an option anyway

Dev environment is used for pr feature review, normally temporary opened for a couple days. Want to hear from each teams how they use the dev environment and their feedback.

This is an ugly solution:
one ugly way is like this:
The redirect url in Cognito will be like "https://nr-forest-client-frontend.apps.silver.devops.gov.bc.ca/authCallback", and inside the project router setting, redirect "/authCallback" to "/pr-number/dashboard", so it will be redirect back to for example "https://nr-forest-client-frontend.apps.silver.devops.gov.bc.ca/168/dashboard"

This is an ugly solution:
one ugly way is like this:
The redirect url in Cognito will be like "https://nr-forest-client-frontend.apps.silver.devops.gov.bc.ca/authCallback", and inside the project router setting, redirect "/authCallback" to "/pr-number/dashboard", so it will be redirect back to for example "https://nr-forest-client-frontend.apps.silver.devops.gov.bc.ca/168/dashboard"

This is an ugly solution:
one ugly way is like this:
The redirect url in Cognito will be like "https://nr-forest-client-frontend.apps.silver.devops.gov.bc.ca/authCallback", and inside the project router setting, redirect "/authCallback" to "/pr-number/dashboard", so it will be redirect back to for example "https://nr-forest-client-frontend.apps.silver.devops.gov.bc.ca/168/dashboard"

previous spike ticket for creating api for consumer application to self-manage redirect urls: #727
implement ticket for creating api: #922

Just another thought, maybe each team can use our FAM DEV for their dev deployment? In this case, if they submit a pr to change their url, we just review, approve and merge, then it will be in our FAM DEV. No manual work or wait on that. I'm just not so sure how stable our FAM DEV is, but I feel Cognito part might be okay? @ConradBoydElliottGustafson @ianliuwk1019 @basilv

I had a similar thought many months ago but have since abandoned the idea. There's several areas of concern with this:

Stability - FAM DEV I wouldn't consider stable enough. They're not just using Cognito, would also need FAM UI access to manage their access permissions. (FAM TEST would be more stable, but has the other concerns below.)
Usability - Having teams connect to FAM DEV (or TEST) UI to manage their DEV access vs FAM PROD UI for their TEST & PROD access gets confusing.
Operational Security - Using a non-production system to manage access of other apps is going to raise some security concerns. Essentially, FAM Dev can't be considered fully secure, as changes haven't gone through our full SDLC. And we don't (currently) audit activities in our dev environment. Nor do monitoring. etc.

This might not solve immediate need.
My original thought was since our basic infrastructure is stable, there is no need to run PROD release every sprint along with terraform (plan/apply). If no state change, it basically verifies in GH pipeline for terraform plan and does nothing in terraform apply (Except database snapshot). We deploy very often only for "backend" and "frontend" components.
The Cognito App clients change is also not very often (except client onboarding and callback url(s) changes in "dev").
With that thought (if correct), we can have setup 2 or 3 repo(s)/pipeline(s), or is it possible to have 1 repo with 3 pipelines?
1. Infrastructure repo/pipeline:

This is our heart of AWS resources we built in past.
Any terraform changes to modify our AWS resources run on this pipeline.
We still need tweaking our security, ec2 host, observability etc.. so
we might still run infrastructure PROD release often, but will be less later.
This repo, might also include our flyway migration.

2. FAM app repo/pipeline:

This is our main app changes every sprint to include fixes and features release.
This will be the most frequent release to PROD (and does not involve infrastructure change).
It can easily be released more times in each sprint for our FAM customer.
I am currently not so sure how our "backend" and "frontend" are done through terraform, but it seems to me is only to "upload" the packaged artifacts - "pyton backend" and "SPA frontend", into already built AWS S3 bucket or Lambda. I am not sure if there is alternative to "upload" without terraform code involved (I assume there is), and if that's the case, this repo and pipeline will not be so fragile (no terraform involved) and can be easily maintained and released without "Cognito specific" change involved in pipeline. We can release anytime without needing terraform state as well.

FAM downstream apps pipeline /or
FAM downstream apps API(s):

It is mainly to handle downstream apps' information/configuration update.
This may not be a pipeline, it can just be our FAM downstream auxiliary api(s).

If it is a pipeline:

same as before, using terraform to edit Cognito callback Url(s) for the app clients.
let other team(or just us) to create PR to merge the change.

If it is not a pipeline:

we can build an api using AWS SDK (javascript or python)
for now can just be a simple api, to update app client callback url(s).
the client apps' configuration probably can be stored in our database, or as  a json file stored as code base, or on AWS DynamoDB for each key for each client.
for existing callback url(s) on Cognito/Terraform, I feel we probably just need to think about a plan for transitioning, since if we store json configuration for the app client, it then become the "state" (analogy to terraform state file). Each time we just need to read it first before we modify it and save it back for most currently client configuration.
for now, probably just let FAM administrator (this case, Catherine) to run this api (so we don't need to worry about secure it for others to use).
can build management console (for admin or for clients) in future.

We already have front-end and back-end terraform 'pipelines' in the same repo, so it is definitely possible to add a third that runs separately from the other two.

I'm heavily leaning toward the third pipeline idea, but I think it should be in its own repository. That's what we did on SSO and it worked. It makes more sense to version customer config on its own if it has a different deployment cadence.

Yes, I'd agree the separate repo would make it easier to manage updates from other teams. Note that we'd have to rejig our "destroy/redeploy" to environment actions, as if the environment was destroyed we'd need to rerun the current client config (from the other repo), which is harder to track the version of when a separate repo. MVP probably just assume we're not deleting cognito and essentially ignore this edge case.

Adding new clients could be tricky. We create a DB script that inserts client info into PostgreSQL when a client is created. We would have to first create the client in the other repo, then add the script that sticks it in the FAM database. Not impossible, but definitely tricky to manage going forward.

As discussed with in FAM team:

short term solution:

on consumer application side:
Adjust the pipeline to deploy prs using the urls within a certain range, example can be seen in FOM #475. Config the range to be "0-99", the range number is calculated by "pr-number % 100". Because the GitHub pr numbers are not sequential, prs and issues use the same sequence. By give a larger range from 0-99, it reduces the conflict case a lot. It's unlikely to open 100 prs at the same time or create 100 new issues between 2 open prs.
on FAM side:
Update terraform Cognito client redirect urls configuration, use a script to generate 100 urls in the pattern.

long term solution:

on FAM side:
Separate the Cognito client configuration into separate repos and separate pipelines to mange it.
on consumer application side:
Submit pr for changes for their client configuration, including redirect urls, token timeout config etc.

Some concerns about the api solution:

API will do real time changes without store any existing configurations. We'll have the risk of losing client configuration data. If we want to capture the information, we have to store in the database, then we need more design work on it.
Each consumer application can integrate the api into their pipeline, but have to wait the deployment on FAM side, which might take at least 10 mins.

The limit for Cognito client redirect urls are 100, https://docs.aws.amazon.com/cognito/latest/developerguide/limits.html
[Uploading... image.png]

Tested in FAM how to write a script to generate 50 redirect urls, confirmed in tools environment the following code works:
  callback_urls                                 = concat([
    "https://oidcdebugggersecure-c6af30-dev.apps.gold.devops.gov.bc.ca/",
    "http://localhost:4200/admin/search"
  ], [for i in range(50) : "https://fom-${i}.apps.silver.devops.gov.bc.ca/admin/search"] )

Created the follow up tickets:

update FAM terraform cognito clients config to include 50 dev urls #990
work with Derek update openshift pipeline for FOM #480


How to hash packed static resource files in non-production mode？

It needs to be the same as the hashname type generated in production mode.

Please follow the issue template, otherwise we'll close the issue directly. Thank you.


Optimize and tweak some SVGs, improve consistency between icons, and fix broken masks in light mode

Removes the 2D dark color. Adds a forced black color (similar to forced white) to use for shades, and replaces the uses of 2D dark with that. This is a more flexible solution, as it allows a shade effect to be used everywhere (our icons already extensively use transparency tricks to achieve the coloring they need)
Aside from this, I fixed some icons. The biggest are these few:

Which broke because I was using an #ffffff mask, but this gets converted into a dark color on light theme.
But also others, and some tweaks too, like optimizations and standardizing viewport icons' widths.
Also, Helps with #82579

Unfortunately, this doesn't fix the issue for 3D gizmo icons for me:

OK I see, this isn't a complete fix, it only helps with the black border.

In the 2D view, it looks now perfect.

Sprite3D ...

I recompiled the current tip + this PR + cleared all Godot settings & caches - that solved the issues for me.

Fixes #84309

@MewPurPur I would really appreciate if you didn't do that. These are completely different issues. I can't even be sure @Calinou tested this other part, since it was added last minute.

Do you want me to split off the negative space Panel icons? I think the rest don't warrant discussion. Cali also suggested the hollow icons, so I doubt he missed this in his review.

Should I split off the negative space Panel icons?

Yes, I think so.

Yessir!

Could you also amend the commit message?

Thanks!


Angular CLI steps out of date

Step 2 under "Update the app" is now out of date with Angular 6. The .angular-cli.json file is deprecated in lieu of angular.json. It is not just a name change; the file format has changed as well. I'm trying to determine how to map your instructions for .angular-cli.json to angular.json.
See the following:
https://stackoverflow.com/questions/42395200/where-is-the-file-angular-cli-json-in-the-new-angular-cli-version
https://blog.angular.io/version-6-of-angular-now-available-cc56b0efa7a4

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 92388aeb-7561-deae-26df-aab50feb71b8
Version Independent ID: aa282880-d613-d7d8-ddb3-6a61c8a155bf
Content: Build an Excel add-in using Angular
Content Source: docs/excel/excel-add-ins-get-started-angular.md
Product: office 365
GitHub Login: @o365devx
Microsoft Alias: o365devx

I found help for where to put the sslKey and sslCert options. Also, "ssl": true is required.
https://stackoverflow.com/questions/49881328/angular-6-angular-json-add-ssl-in-configuration

@jeffkt95 thanks for reaching out and sorry to hear that you've run into issues with the Excel - Angular quick start. We'll be updating this quick start soon to address the issues that you've described. In the meantime, the new recommended way to create an Excel add-in using the Angular framework is to use Yo Office to create the add-in project and choose Office Add-in project using Angular framework when you're asked to choose a project type.

@jeffkt95 we've significantly revised this quick start, to reflect that the Yeoman generator for Office Add-ins is now the recommended way of generating an Office Add-in project using the Angular framework. Please give the new instructions a try and feel free to reach out again if you have any trouble.


[HTTP] client-to-server streaming

As mentioned in #56, the only way to follow neemata streaming protocol is by utilizing multiple connections and long-polling, which seem to me being really ugly. Also, there's no way to use http2 streams, because browsers don't an api for this, and probably will never do.
TODO: Need to check how does grpc for web handles this problem

Droped in #78


Refactor things and fix the spaghetti

All libraries should be refactored to remove the worst cases of spaghetti code.
Desired outcome:

Executables and their includes should be able to be installed according to FHS on a Linux system.
It should be possible to build .deb packages that follow the Debian packaging policy for python software.

Additional requirements:

Libraries SHOULD not call sys.exit() or print messages; they should raise exceptions, and wherever feasible use strings formatted with List[ANSIThemeString] as extra arguments to the exceptions (only works for our custom exceptions).
Libraries MUST not have circular dependencies; define acceptable dependencies and stick to them

This is WIP.

While refactoring has not been fully completed yet, the systempath branch should now support installing to, and working from, the system path. There are probably still things to consider, but we're close to the point where we could consider creating .deb packages.

The systempath branch has been merged into main. Future development will continue in the main branch.

All remaining infogetters have been split from cmu and moved into infogetters.py


errLevel option is not honored

I am passing 'errLevel': '1' as an option but the report contains all errors, warnings, and notices. Looks like scan method takes priority as an option. Is priority different then errLevel? When I pass 'priority' : 'p1', as an option the report still contains error, warnings and notices.

created a PR https://github.com/paypal/nemo-accessibility/pull/9


[BUG] Identify in chip-tool vs Apple Home app

Reproduction steps
When calling the "./chip-tool identify identify 5<PHONE_NUMBER> 1 --paa-trust-store-path /home/user_name/connectedhomeip/credentials/development/testing-certs" action, I receive a success and a function to the IdentifyStartHandler is called.
When calling "Identify" after pairing in the Apple Home app, nothing is called. Is this using a different identify method?
Bug prevalence
N/A
GitHub hash of the SDK that was being used
4083b32732b04aeec63b8f03ebd1e12ade78dd0f
Platform
nrf
Platform Version(s)
No response
Anything else?
No response

@sam-gabbay What does the command payload the server receives look like when you do "Identify" after pairing in Apple Home?  If you can build with detail logging and enable_im_pretty_print set to true, that should log incoming payloads.

@bzbarsky-apple I do not know what you did, but it started working. I think maybe an erase and wipe and a clean pair solved it.
P.S. You were something of a legend at Apple Park at WWDC. Kudos to you and all the work you do!

P.S. You were something of a legend at Apple Park at WWDC. Kudos to you and all the work you do!

Thanks, and now I'm really curious what the stories were!


Automatically assign new jobs on mastery

Mod would automatically assign a new non-mastered job to a dupe once they have mastered their current one. This would avoid the micromanagement of manually assigning jobs mid->late game when morale is not an issue, basic roles are covered and you just need to cross-train dupes for the stat bonuses.
Basic Functionality:

Jobs are assigned on a hard-coded hierarchy (probably low-morale jobs first)
User can override the automatic assignment manually through the current job interface and the dupes will go back to the auto-order once their current job is mastered.

Optional Functionality (in order of most to least useful):

External configuration file to define the order that jobs are assigned in (in case you want a bunch of ranchers trained before anybody touches cooking or you can leave off space cadet and astronaut so those jobs are never automatically trained)
Dupes are not auto-assigned jobs higher than their current morale allows.
Dupes are not auto-assigned jobs higher than their highest-trained tier. The player must manually assign a next tier job before that tier is trained.
Internal menu to configure the order jobs are trained.
Internal menu to configure the order jobs are trained for each individual dupe.

Job system has been scrapped in the QoL Mk3 Update. Abandoning this mod request.


Add Kotlin type support to the schema generator and test.

tests all seem to be passing except for a known flaky suite; Ray ran this x1000 with/without my patch and couldn't see a difference in the flake rate.


Triggering update in websockets app from PHP without long running process

I'm using crossbario/crossbar along with Thruway as "backend" and JS in the browser as "front-end" for my app.
What I'd like to do is to have the ability to trigger updates in the front-end when some action takes place within the app but there is no long running websockets connection present. For example, I'd like to be able to call an procedure when an API method is called.
I've tried creating a new connection with ->open(FALSE) and then calling ->close() after the processing is done in ->on("open"). But creating a connection like this and then closing doesn't seem like an optimal solution.
I've thought about having a middle element like a message queue but I'd really like to avoid adding another moving part to the system only for this use case.
Would there be any simpler way of triggering an update (calling a procedure, etc.) within the websockets architecture from the PHP app?
Thanks,

There are a few options.
The first is detailed in this comment here: https://github.com/voryx/Thruway/issues/42#issuecomment-59791963
Which, I agree, is a little ugly.
The other option is to create a WampPost client.  This would allow you to publish messages to crossbar and also make RPC calls using typical http calls.
The WampPost option would require you to have a long-running PHP process.
It is possible that crossbar has this same facility built in (I know they have the pusher service which allows publishing events), but I am not sure about doing RPCs like that.
If you have the option of running the Thruway router, the WampPost client can be added in internally so both start at the same time.

I should have looked just a little longer - crossbar does have something similar using HTTP: http://crossbar.io/docs/HTTP-Bridge-Services/

Thanks, that was exactly what I needed.
I should have read the docs closer, don't know how I've missed it :/


Finish completing accept/connect on Windows

Apparently there are extra steps that need to be taken after a socket finishes
being accepted and/or connected on Windows to prepare state like calling
getsockaddr and getpeeraddr. This updates the miow binding to where it has
these functions, then calls those functions in these situations.
Closes #397

For reference the associated runtime support is at https://github.com/alexcrichton/miow/commit/f987c98b3c0e30a390c3df13aeff528501b74ab3

Merged into dev: 3e18267ac71d26f47ad68baae87fb101d14fa987


publish on bower / npm?

Thanks for this library. Seems pretty useful.
Any interest in publishing this on bower and npm?

Thanks for your opinion.
I have not published on bower and npm before but would be interested.

Thanks for publishing! I think bower is not picking up the version somehow. Maybe the git tag isn't in the correct x.x.x format?  (bower will ignore the "version" property in bower.json).
Also I think including "main": "mergexml.js" and "ignore" : [] in your bower.json would remove the warnings.

I corrected the version and bower.json but still received the warnings during the registering:
bower invalid-meta  mergexml is missing "main" entry in bower.json
bower invalid-meta  mergexml is missing "ignore" entry in bower.json
However, the info displays correctly:
C:\home\vregistry\dev\classes\mergejs>bower info mergexml
bower cached        git://github.com/hareko/js-merge-xml.git#1.1.0
bower validate      1.1.0 against git://github.com/hareko/js-merge-xml.git#*
{
name: 'mergexml',
homepage: 'https://github.com/hareko/js-merge-xml',
version: '1.1.0'
}
Available versions:

1.1.0

I wonder you need to commit the config.json to the repo. I always but am not sure if it's required.

config.json? I have package.json and bower.json

ah yes, sorry I meant bower.json. It's not in the repo.

I committed bower.json, unregistered/registered again and got the same warnings.
But in general, it should be ok now...

warnings are gone for me now! :+1:

Thanks for your time and support!


Fixed typing file collisions

This fixed typescript compiler errors in some IDEs (e.g. VS).
See: https://angular.io/docs/ts/latest/guide/typescript-configuration.html

Yes, that works. Thanks.


Add Opentelemetry

Integrate jgaskins/opentelemetry shard. A working example can be found here.

Whoops, forgot I had #9 already in place for this


Some old linkposts don't have links imported

e.g. https://www.lesserwrong.com/posts/BLfFgcPL38ED3poSY/don-t-shoot-the-messenger

Browsers: Chrome, Opera, Firefox & Brave on Windows

Ah, that's a link post, and it looks like the link must have gotten lost. Will fix.

This can be merged with https://github.com/Discordius/Lesswrong2/issues/502, correct?


"Download" under "Documentation"?

Is it a mistake that we put the "Download" page under the "Documentation" section in the main menu or there's a rationale to it? Thanks.

It was a deliberate choice done whilst making this update:
https://github.com/OpenAddressesUK/theodolite/pull/118
Reasons? Bringing together technical material under a single menu item and exploring the thought that we have some different needs which are currently not clearly signposted whilst we come across as overly technical/community. The inspiration came from reviewing other orgs offering APIs and/or bulk downloads.
It's still not right but, I think, is helping me understand the needs.
E.g. key website needs:
Find out more about Open Addresses out of curiousity/fear
Find our more about Open Addresses to see if their services will provide me/my organisation with benefits
Find out more about Open Addresses with intent to use/integrate services
Find out more about Open Addresses to see I can help (develop | add data | etcetera)
etcetera
.

Ok, although if I came to the website to download the data and I did not need the documentation because I knew about it already... I wouldn't find the data! :-) That is how I realised about the change.
Please consider this matter as part of the upcoming work for improving the website.


default, efficient sections

Original author: Jonathan Lifflander
Original issue: https://charm.cs.illinois.edu/redmine/issues/321

No body.

Original date: 2018-02-16 05:41:27

This seems too broad and ill-described to be an issue.


Do you have tested with attachment ?

Do you have tested with attachment ?

I pushed pull request for attachment

Thanks for your contribution. Are your changes working well? I will review your changes soon and merge your pull request.

Seems like PR #3 did the job


knex seed:run doesn't seem to populate the database :(

I have created a seed file with knex seed:make, populated it, then run it.  It seems to run just fine without any error.  However it doesn't seem to populate the database with any data.  Here is a test case that reproduces the problem against a postgres 9.1 database:
https://github.com/socketwiz/knex-test

Replace the entries in knexfile.js with your own
npm install
knex migrate:latest
knex seed:run
$ knex seed:run
Ran 1 seed files
c:\github\knex-test\seeds\roles.js

Any ideas?

Huh, got bitten by this just now. Thank you!!!

Thaks! 🙏


Array primitives for Sea

This looks good, but you'll probably need to rebase it because of changes to the test output :8ball:

:vhs: on :green_apple:


'pkg/.gitignore' in deno target

In Deno, packages are usually hosted on github or other git hosting platforms.
But now the content of generated pkg/.gitignore is *, which will prevent pkg from being submitted to git.
Should the * in the .gitignore of the Deno target be deleted?

Why was * included in the first place?

Removing it gives the user more options. If they want to submit it via git, they can, if they don't, they can add /pkg to an external gitignore.

I think this is a problem on all targets


Support for "kid" (Key ID) lookups

Adds a global callback to get the algorithm from the key ID (kid) header of a token.

Coverage remained the same at 100.0% when pulling 2dda0480c1efe8b656bdd7d6efd157c11a9a7718 on feature/key-lookup into ae6b0b5ec9040c9a2ccf8ad77d668245ca600f82 on master.

Coverage remained the same at 100.0% when pulling 2dda0480c1efe8b656bdd7d6efd157c11a9a7718 on feature/key-lookup into ae6b0b5ec9040c9a2ccf8ad77d668245ca600f82 on master.


[design] contacts

** design not yet available**

will close this as a MVP version is merged now. Will compare with didiers golden model and raise new issue later


Missing person ThiefMaster

Please add yourself to the people directory.

will probably do it next week; super busy for the rest of the week

damn, the "role" field is the hardest one to fill out - so far i see one "funny" entry and two more "serious" ones...  at the moment i'm mostly helping out on IRC and in the issue/PR tracker but how to put that best in a short-ish role?

@ThiefMaster you can always put something along the lines of "management" in :)


Project setup

DL-4282
Removed the tags and keeping the git history as this is a copy from frontend-public-decisions.

Renaming for worship-decisions.

Drone signature and secrets needs to be added for this project.

Text copy might also be changed to match the app.

Some things that still need to be changed:
* https://github.com/lblod/frontend-worship-decisions/blob/d81ce8adea4f69361c3f7a8205988841635af3f9/app/components/contact-form.js#L26
   It seems I missed this in the `app-name` refactor. I think we can also retrieve it from the config.environment similar to the app-name helper.

Okay, do you know if the email will be the same ?

* https://github.com/lblod/frontend-worship-decisions/blob/d81ce8adea4f69361c3f7a8205988841635af3f9/app/templates/legaal/toegankelijkheidsverklaring.hbs#L6
   This link needs to be updated, although I'm not sure what it is. If we don't know yet we should probably create an issue for it so we don't forget before the release.

Yes indeed, I haven't touched this part as I don't know what link we need to provide here.

I'll merge this already since it's only some small details that we can also fix in a future PR.

Except for the mini ACM context thing, we can go for a first release!


Add a default for the node language version

Closes #2460
This avoids that pre-commit picks the latest node version available that might not be supported by renovate. Users can still override this if they want.

What about
language_version: lts

It will ensure to stay on LTS instead of unsupported active version

@jonesbusy did not know that this feature existed. Do you know that this works? Do you have any example/documentation where this is mentioned?

https://pre-commit.com/#overriding-language-version
The language_version is passed directly to the underlying tool. In that case nodeenv
I've just tested
nodeenv --node=lts .test
 * Install prebuilt node (22.12.0) ..... done.

Changed to lts.
@viceice what would have to be changed in the renovate config?

does it support setting the major version only? because renovate sometimes doesn't support the newest lts for some time.

Apparently not
I tried without success
nodeenv --node=22.x .test
nodeenv --node=22 .test

Being said that you don't always support the latest LTS version, we might want to explicitly specify the node version to be used. This way, you can explicitly define what should be used and is supported.
If this becomes to much manual effort, maybe renovate can autoupdate this as well. WDYT @viceice.


Installation fails for 1.7.0 on Windows/Linux/SmartOS

Very easy to reproduce - just try to install it.
I tried on Windows, Linux and SmartOS and got the same thing.
npm install js-beautify
npm WARN enoent ENOENT: no such file or directory, open '/home/andra/trash/blah/package.json'
npm WARN blah No description
npm WARN blah No repository field.
npm WARN blah No README data
npm WARN blah No license field.
npm ERR! Linux 4.4.0-92-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "js-beautify"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! path /home/andra/trash/blah/node_modules/js-beautify/js/bin/css-beautify.js
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall chmod
npm ERR! enoent ENOENT: no such file or directory, chmod '/home/andra/trash/blah/node_modules/js-beautify/js/bin/css-beautify.js'
npm ERR! enoent ENOENT: no such file or directory, chmod '/home/andra/trash/blah/node_modules/js-beautify/js/bin/css-beautify.js'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! Please include the following file with any support request:
npm ERR!     /home/andra/trash/blah/npm-debug.log

#https://github.com/beautify-web/js-beautify/issues/1247

I'm seeing this too.

fwiw this is a dupe of https://github.com/beautify-web/js-beautify/issues/1247

Same for us. All jobs are failling ...

Previous version exists,
but last 1.7.0 - does not exists
yurii@hp0143:/home/si/$ npm i<EMAIL_ADDRESS><EMAIL_ADDRESS>/home/si/
└──<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>No repository field.
yurii@hp0143:/home/si/$ npm i<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>No repository field.
npm ERR! Linux 4.9.0-3-amd64
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "i"<EMAIL_ADDRESS>npm ERR! node v6.11.3
npm ERR! npm  v3.10.10
npm ERR! path /home/si/node_modules/js-beautify/js/bin/css-beautify.js
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall chmod
npm ERR! enoent ENOENT: no such file or directory, chmod '/home/si/node_modules/js-beautify/js/bin/css-beautify.js'
npm ERR! enoent ENOENT: no such file or directory, chmod '/home/si/node_modules/js-beautify/js/bin/css-beautify.js'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! Please include the following file with any support request:
npm ERR!     /home/si/npm-debug.log

Same error here

Same error for me...

same error here

Fixed in 1.7.2.


Mixpanel event for runepool

Just in case we forgot to ticket (or didn't add), add mixpanel tags on

runepool deposits & withdraws

Until we have the onchain reference.

@twblack88 RUNEPool is leveraging the DeFi deposit events meaning we already have these, however we'll need to use the assetId vs. underlyingAssetIds


CameraView ignore ZOffset

I set CameraView and Panel like below and I expect 'over' panel will be over on top, but it's not.
<App>
	<Panel Background="#00f">
		<NativeViewHost>
			<CameraView ux:Name="cameraView" Facing="Back"/>
		</NativeViewHost>
		<Panel ux:Name="over" Y="0" Height="50%" Background="#0f0" ZOffset="3"/>
	</Panel>
</App>

Preview on destktop

Preview on Android

Mistake. Layers have to be in <NativeViewHost/> to be overlaid.
Sorry!


feat: How About Adding Support for Loading Pickle Files?

open-webui: 0.4.7.
ollama: 0.4.0
python: 3.11
I am a dedicated user of Open WebUI and find it extremely useful.
I especially rely on the RAG feature, which has been incredibly helpful.
I would like to suggest adding support for the pickle format, as it could make the platform even more versatile and useful.
The following is the code I modified and tested. I have confirmed that it works correctly in the described environment.
| apps
├── retrieval/
├── loaders/
├── main.py
# existing code
import pickle
# existing code
class PickleLoader:
    def __init__(self, file_path):
        self.file_path = file_path

    def load(self) -> list[Document]:
        with open(self.file_path, 'rb') as f:
            data = pickle.load(f)

        if isinstance(data, str):
            return [Document(page_content=data, metadata={"source": self.file_path})]
        elif isinstance(data, (list, tuple)):
            return [Document(page_content=str(item), metadata={"source": self.file_path}) for item in data]
        else:
            return [Document(page_content=str(data), metadata={"source": self.file_path})]
# existing code
def _get_loader(self, filename: str, file_content_type: str, file_path: str):
# existing code
            elif file_ext == "pkl" or file_ext == "pickle":
                loader = PickleLoader(file_path)
# existing code

PR welcome!


macOS Sonoma?

Hey,
I want to know is this is or will be supported in Sonoma soon?
Best regards

Tested, it's working! Thanks!


Sample configuration file missing "accessory": "", field

Accessory cannot load after installation without Accessory field (and name field) in Homebridge. See example configuration below of other home bridge accessories or platforms:
},
"accessories": [
{
"accessory": "WeMo",
"name": "Coffee Maker"
}
],
"platforms": [
{
"platform" : "PhilipsHue",
"name" : "Hue"
}

@prestonmerkel21 yes, I fix README.md. Thanks.

Oh no I’m sorry I meant each accessory needs to have an accessory property. Otherwise homebridge generates an error that it is unable to find the accessory plugin to link to.

@prestonmerkel21 you right, I fixed it)

Thanks! Last question (sorry to bother you). What is the format the plugin reads from the sensor? I set my http site up to show only a number, but the ppm is always 0, then I did Json {"co2RawValue":"100"} but still reports as 0. How should the value on the webserver be displayed so the plugin may read it?

@prestonmerkel21 if you backend response like this:
{"co2RawValue":"100"}

you need set valuePath:
"valuePath": "co2RawValue"

and check plugin log: Obtained CO2 value: ?????


'get_datasets' with 'taxonname' argument silently produces wrong results

Hi,
I'm re-running a script where I had previously used the get_datasets function with the taxonname argument, but now this seems to output the exact same dataset (and no error or warning message) for totally different species:
neot_data1 <- get_datasets(taxonname = "Orcinus orca")
neot_data2 <- get_datasets(taxonname = "Giraffa camelopardalis")

head(neot_data1)
 siteid sitename      lat      long altitude
      1     15/1 55.09167 -75.25000      244
      2     15/2 55.83333 -75.01667      261
      3     16/1 55.41333 -75.06667      290
      4     17/1 55.06667 -75.70000      235
      5     17/2 55.25000 -74.93333      300
      6     17/3 55.11667 -75.95000      278

all.equal(neot_data1, neot_data2)   # TRUE?!

It looks like I should now be using the taxa argument instead. However, I don't think we should be getting a wrong output with no warning if we use an argument which once existed.
Cheers,

Hi there,
Thanks for reaching out.  I’ve forwarded this to the Neotoma R developers.  It’s a busy time (just before AGU) so the likely response time may be on the order of a week.  Please advise if this is particularly time-sensitive.
Jack
From: AMBarbosa @.>
Sent: Monday, December 2, 2024 9:31 AM
To: NeotomaDB/neotoma2 @.>
Cc: Subscribed @.***>
Subject: [NeotomaDB/neotoma2] 'get_datasets' with 'taxonname' argument silently produces wrong results (Issue #46)
Hi,
I'm re-running a script where I had previously used the get_datasets function with the taxonname argument, but now this seems to output the exact same dataset (and no error or warning message) for totally different species:
neot_data1 <- get_datasets(taxonname = "Orcinus orca")
neot_data2 <- get_datasets(taxonname = "Giraffa camelopardalis")
head(neot_data1)
siteid sitename      lat      long altitude
  1     15/1 55.09167 -75.25000      244

  2     15/2 55.83333 -75.01667      261

  3     16/1 55.41333 -75.06667      290

  4     17/1 55.06667 -75.70000      235

  5     17/2 55.25000 -74.93333      300

  6     17/3 55.11667 -75.95000      278

all.equal(neot_data1, neot_data2)   # TRUE?!
It looks like I should now be using the taxa argument instead. However, I don't think we should be getting a wrong output with no warning if we use an argument which once existed.
Cheers,
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/NeotomaDB/neotoma2/issues/46__;!!Mak6IKo!MHl7S7PlPK6iXqRmPm4odZZnv7Mi86jNDKqFzHXm4druNYX7eg5fDy8CnhKHMr5ewqe0rob72lzqODoxAO1JW-GtBzTHN8c$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ABM322U7W4QDKZEVSFUGN5T2DSKOFAVCNFSM6AAAAABS352VEKVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4YTENZVGE3TOMI__;!!Mak6IKo!MHl7S7PlPK6iXqRmPm4odZZnv7Mi86jNDKqFzHXm4druNYX7eg5fDy8CnhKHMr5ewqe0rob72lzqODoxAO1JW-Gtv4QCebQ$.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>

Not time-sensitive for me, so no worries at least from my part.
Cheers!


Update .gitignore

[ ] Added or updated tests
[ ] Documented user facing changes

Changes
Add .vscode and .fleet no .gitignore.

Breaking changes

Why? We don't need to add everything under the sun to this project's gitignore---you can add them to your own global gitignore if you use these technologies

Many don't do this.
git config --global core.excludesFile ~/.gitignore


How to delete key-value with configure as code deployment

We are adopting configuration as code deployment to make sure configurations are managed under version control.
But the question is, some configurations are JSON array,
AAC keys are expressed as
Test:Setting:0, Test:Setting:1
it works well for add, update. But if  Test:Setting:1 is deleted in configuration file, how to delete AAC related key-value with configuration as code model?

Please use JSON based configuration settings for JSON arrays.
https://docs.microsoft.com/en-us/azure/azure-app-configuration/howto-leverage-json-content-type
That allows arrays to be expressed in a singular form:
Test:Setting -> ["a", "b", "c"]
Update of the array simply means to replace the value
instead of .NET Config specific binding.
Test:Setting:0 -> "a"
Test:Setting:1 -> "b"
Test:Setting:2 -> "c"

Please use JSON based configuration settings for JSON arrays. https://docs.microsoft.com/en-us/azure/azure-app-configuration/howto-leverage-json-content-type
That allows arrays to be expressed in a singular form:
Test:Setting -> ["a", "b", "c"]
Update of the array simply means to replace the value
instead of .NET Config specific binding.
Test:Setting:0 -> "a" Test:Setting:1 -> "b" Test:Setting:2 -> "c"

Thanks for replying, appending and updating work well.
But If I need to remove the last item Test:Setting -> ["a", "b", "c"] to Test:Setting -> ["a", "b"] and import the configuration file again, Test:Setting:2 -> "c" still exist in AAC.
Any suggestion to handle deletion?

Remove all entries that represent the flattened array from your AAC
Test:Setting:XXX
When do config file import, use Content-Type JSON (application/json)

Remove all entries that represent the flattened array from your AAC
aka Test:Setting:XXX
When do config file import, use Content-Type JSON (application/json)

You should see the array represented as a single entry.
Test:Setting -> ["a", "b", "c"]

Cool, the solution helps. Thanks a lot.


No Resources Listed

I am new to swagger. I've installed swashbuckle successfully, and am able to navigate to the /swagger/ui/index page. But there is nothing listed there. I just see the API title. I see "ERROR {...}" when clicked, gives the message "Can't read from file http://localhost:40339/swagger/docs/v1". Does my site need to be externally facing? I doubt. I neither have enabled the generation of XML documentation file nor have any /// comments for my controllers & methods, as I found that it's not required.
When I navigate to http://localhost:40339/swagger/docs/v1, it shows this JSON:
{
    "swagger": "2.0",
    "info": {
        "version": "v1",
        "title": "ApiDocTest"
    },
    "host": "localhost:40339",
    "schemes": [
        "http"
    ],
    "paths": {},
    "definitions": {}
}

Can someone please tell me what I am missing? It's an ASP.NET MVC 4 application, working in Visual Studio 2013.

Just realized that since it's an MVC app, all my controllers are derived from {{Controller}} class, and not {{ApiController}}, which the Api Explorer relies on.


fix references to govuk-c-list

Fix a couple of references to govuk-c-list, which is now govuk-list

Superseded by #394


SSU, LCU with offline WIM

@jaimeo - I've read that the recommendation is to install SSUs before installing LCUs.
Can we do something like the following using DISM with an offline WIM?

Mount WIM
Add SSU
Add LCU
Unmount/save WIM

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b706f0af-d504-a8ca-7c38-b8bb9283bfad
Version Independent ID: 14f31acf-9f47-59a6-269f-62ab249fe560
Content: Servicing stack updates (Windows 10)
Content Source: windows/deployment/update/servicing-stack-updates.md
Product: w10
GitHub Login: @jaimeo
Microsoft Alias: jaimeo

@russbearl - thank you for submitting feedback.
I think the best way forward is if you can open a service ticket so this can get resolved ASAP. Based on outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for Windows 10 products:  https://support.microsoft.com/en-us/hub/4338813/windows-help?os=windows-10
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.

@officedocsbot assign @mypil

@officedocsbot close


Support for AndroidX Espresso

Steps to reproduce:

Replace support lib Espresso dependency with AndroidX one

'com.android.support.test.espresso:espresso-core:3.0.2'
to
'androidx.test.espresso:espresso-core:3.1.0-alpha4'

Write test which with click() assertion. e.g. screen.button.click()

Observed Results:
Compiler error:
Cannot access class 'android.support.test.espresso.action.GeneralLocation'. Check your module classpath for missing or conflicting dependencies
Expected Results:
Test code should compile
AndroidX library will be co-existing with supportLib for some time. Maybe would be possible to have separate artifact for AndroidX?

Hi, @audkar. We will migrate to AndroidX when it moves out from the alpha release. We don't have the plan to create a new artifact right now.

@cdsap  thanks for the effort. any news about publishing the artifact.

@ateek I suppose that I could finish it in couple days. And sorry for delay.


Create knowledge base of meeting transcripts

Describe the solution you'd like
A clear and concise description of what you want to happen.
Optionally ingest the summary and transcript of completed meetings into a 'meetings'  knowledge base that can be securely used to retrieve information discussed in previous meetings:

as part of the meeting assistant capabilities during a meeting
as a feature of the LMA Meeting List page to find content from meetings at any time

User based access control must be respected.
The KB used for meeting transcripts can be the same KB as, or a different KB than, the primary meeting assistant KB.

released in v0.2.4


Antivirus validation rules memory leak

TClamav which use ClamAv antivirus (libclamav ) causes memory leak. It also is very slow.
Step to reproduce

Make sure ClamAv antivirus and its development library is installed.
create Fano Framework web application, for example as SCGI.
Add form for file upload
Add controller which handle file upload
create validation class and add antivirus validation rule using TClamAv.
Enable -gh command line in build.dev.cfg
compile for development environment

$ BUILD_TYPE=dev ./build.sh

Run application
Upload a file. Observe that antivirus scan is very slow.
Stop application. Observe heaprtc output.

TClamAv implementation that using libclamav API directly is removed and replace with TLocalClamdAv implementation which using clamd daemon over network socket. See 76bf930ed82f.
The issue of memory leak is resolved with new implementation, however this issue is deliberately kept open until issue with original implementation using libclamav is resolved.

Closed and moved as new issue #8


Netlify 0.0.4 version gives error

After activating the netlify plugin (version 1.0-alpha-004), I get the following error "There has been a critical error on your website. Please check your site admin email inbox for instructions."
The error details are
`Error Details
An error of type E_ERROR was caused in line 44 of the file C:\laragon\www\wp-content\plugins\wp2static-addon-netlify\views\netlify-page.php. Error message: Uncaught Error: Call to undefined method WP2Static\Controller::encrypt_decrypt() in C:\laragon\www\wp-content\plugins\wp2static-addon-netlify\views\netlify-page.php:44
Stack trace:
#0 C:\laragon\www\wp-content\plugins\wp2static-addon-netlify\src\Controller.php(123): require_once()
#1 C:\laragon\www\wp-includes\class-wp-hook.php(287): WP2StaticNetlify\Controller::renderNetlifyPage('')
#2 C:\laragon\www\wp-includes\class-wp-hook.php(311): WP_Hook->apply_filters('', Array)
#3 C:\laragon\www\wp-includes\plugin.php(478): WP_Hook->do_action(Array)
#4 C:\laragon\www\wp-admin\admin.php(254): do_action('wp2static_page_...')
#5 {main}
thrown
`
Version 1.0-alpha-001 works.
I believe WP2Static\Controller needs to be changed to WP2StaticNetlify\Controller to fix the error but when i tried, it wasn't working

Thanks @Shlokp - sorry for this, last builds were pushed without a thorough testing. It's fixed in this repo and for a few add-ons with similar reference error. Working on more complete automated testing at the moment.

new builds are published now. Sorry for that!


[tlul] xbar data blanking

xbar portion fix to #11036
Technically this should be applied to m1 as well for reads

Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

This is not meant to be merged yet since #11036 needs either TC approval or wider discussion in general.
This just shows one possible solution to the presented problem.

so far this makes sense.  I don't have a strong intuition for opt-in vs opt-out, but I think I can see your argument.

merging this part for now and will begin on part 2.


Ho to set date format to dd/mm/yyy

Hi ,
I want to set date format to dd/mm/yyyy but i couldn't. All the time i am getting mm/dd/yyyy format. How i can change date format please help me out.
Thanks,
Ketan Mokariya

https://danielykpan.github.io/date-time-picker/#locale-formats

Actually I'm in the same situation and a bit confused on how to set it.
I'm using moment integration and I have:
export const MY_MOMENT_FORMATS = {
    parseInput: 'l LT',
    fullPickerInput: 'l LT',
    datePickerInput: 'l',
    timePickerInput: 'LT',
    monthYearLabel: 'MMM YYYY',
    dateA11yLabel: 'LL',
    monthYearA11yLabel: 'MMMM YYYY',
};

Already seen the moment formats on moment's documentation but it is not explicit on OwlDateTimePicker's documentation which key one must change to get dd/mm/yyy .


Added the community calendar and fixed issue #322

Hii,
I have fixed issue#322 by adding the community calendar and making the necessary changes. Kindly verify and merge it.

@prasanjit15 the DCO issue needs to be fixed and I think by mistake you have removed the twitter icon and link. Please check that.

@prasanjit15 the DCO issue needs to be fixed and I think by mistake you have removed the twitter icon and link. Please check that.
Okay, so from the code I get the issue. You need to add a hyphen i.e, - before the name label like others.

sorry my bad I missed it. I will just fix and do a PR.

Hey, why did you close this PR?

The changes looked good.

Sorry I was not clear if this will add to changes so I created a new one. So, should I reopen This or you will merge the new one?

You can reopen this one or create a new one whichever you feel you are comfortable with. Also, I think the link for the calendar is not correct can you please double check it.

You can reopen this one or create a new one whichever you feel you are comfortable with. Also, I think the link for the calendar is not correct can you please double check it.

@Nikhil-Ladha sorry But I asked the link that day because I was getting some kind of error. I am giving the exact same link as given in layer5.io i.e.,
"https://calendar.google.com/calendar/u/1/r?cid=bGF5ZXI1LmlvX2VoMmFhOWRwZjFnNDBlbHZvYzc2MmpucGhzQGdyb3VwLmNhbGVuZGFyLmdvb2dsZS5jb20"

This link is fine, maybe sime issue in the code. Do confirm things once from your end too.

Please confirm that if I corrected and create a PR again I am not getting any option to merge then does it get merged automatically?

By the way the problem was not in the code but in the link....here is the correct link
https://bit.ly/2SbrRhe

Now Please check if it is working

Please confirm that if I corrected and create a PR again I am not getting any option to merge then does it get merged automatically?

Lol, I figured it out :)


Pointarray - parse coordinates with Illustrator style space and or comma

This fixes #525 by accepting/parsing coordinate strings where x and y is separated by comma and or by space - we count the shape coordinates until (and including) the maximum even number.
Illustrator exports points in the following format: <polygon class="cls-1" points="221.08 191.79 0.46 191.79 0.46 63.92 63.8 0.46 284.46 0.46 284.46 128.37 221.08 191.79"/> but SVG.js only support the following format <polygon class="cls-1" points="221.08,191.79 0.46,191.79 0.46,63.92 63.8,0.46 284.46,0.46 284.46,128.37 221.08,191.79"/>. Which makes it difficult to implement graphic designers work.
This PR is made upon #527 in anticipation for that being merged, but perhaps I should rebase this against the current master?

I rebased against the current master to make this PR more manageable.

I really would like to wait for the travis PR to be merged so that we can see it working :). Is travis ready to be merged now?

Yes. I believe #527 is ready :-)

@Fuzzyma hang on I'll remove dist/* from this PR

@Fuzzyma Not sure it was a good idea. Well, you need to do npm run build and upload the dist  to master after merging this PR

@Fuzzyma ok, removing didn't work. I'll rebase with current master

Tests still failing :(

Yep, seems we can a slightly different behavior when running Firefox headless. I'll see if I can reproduce it locally, since I don't see these errors when running the unit test manually in the browser.

In spec/element.js I don't see where draw is defined thus seems that a lot tests should be failing here...

the sugar.js tests are not included in the spec runner (why???). Thats why it doenst fail locally... fixing...

the failing tests come from the sugar tests which are made frm me long time ago. I copied from element.js which explains the redundant tests. Also i never finished these tests. Thats why they are failing. I fix this atm

@Fuzzyma ok cool. Then I'll do nothing?

Sorry for the delay. I pushed the fix. There were no tests for the sugar module at the start. So I decided to add some but actually forgot about it. This relict was left. Tests are still not complete but valid and passing.

Last test is the svg() method which I already fixed for chrome and FF. Looks like linux FF has different attribute ordering to Windows FF. Maybe someone can check this?

Mh - looks like our test bench is not correctly reseted before each test. When running in a Browser the id of the svg is 1001. While it was something different when run in headless browser. We should look into that. However: all tests are passing on my local installation now. Travis should be fine :)

@dotnetCarpenter tests should pass after a rebase. We can merge this then

Do I see a green checkmark there? :D
Congratulation! You just finished teh first PR which was tested with Travis. Hurray!
Let me now if this can be merged now :)

@Fuzzyma YES :rocket: :confetti_ball: !! :dancing_men:
It's all good. Maybe you want to fix my wordings in the CHANGELOG.md. I've tried to write down everything from my last 2 PR's. But everything else looks good to me

Naa - thats something I can do later

Related to this issue:
I have code such this one:
		draw.polyline("...");   // and
		draw.polygon("...");

where the series of points come from Ilutrators with sequences of spaces and commas and separators.
This code worked on version: 2.3.4
But now is failing without changes on version: 2.3.5
I got errors of the following type:
svg.js?8a91:2541 Error: <polyline> attribute points: Expected number, "…4 2091.6,1353.3 NaN,NaN".

Not tested with 3.0.0 yet as 2.3.5 is the last one on npmjs.org
Any fix to be published on npmjs ?
Thxs.

You have code which passes three points to the function?

Hi Fuzzyma. I rescued real sequeces of points I am passing to the function. Here you have:
polygon() sample:
"2176.6,1708.8 2176.4,1755.8 2245.8,1801.5 2297,1787.8  "

	svg.js?8a91:2541 Error: <polygon> attribute points: Expected number, "…8 1802.5,1475.5 NaN,NaN NaN,NaN".

polyline() sample:
"2347,1115 2347,1178.8 2451.5,1164.5 2453.2,1098.2 2348.5,1115.5  "

	svg.js?8a91:2541 Error: <polyline> attribute points: Expected number, "…4.1 2091.6,1536 NaN,NaN".attr @

Please try the current master and report back. If all is well I will publish it

@pjmolina I'm interested too since I broke your code. Does it work now, with the latest build?

@Fuzzyma @dotnetCarpenter Confirmed! The example provided:

Works with npm v. 2.3.4
Fails with npm v. 2.3.5
Works again at latest commit: e4bff8c910e37f923a138fd44f6c8a3b21fa2a78

You can use the provided point sequences to create a repro unit-test if needed.

We already did that.  We will try to merge the one pr and then publish a new version


updated version from 2015 to 2018

using Rust version 2018 and fixed the resulting errors, no logical changes to the library just refactoring

Thanks for the contribution! I noticed a few small things, but overall this looks good :+1:

Thanks for actively looking at my PR. I'm rather new to creating pull request to other repos and originally only intended to merge the first two commits but apparently once I added more commits to my own fork it shows up here as well. regardless I kind of like all the commits as it pretty much just extends the Activation enum to more functions and provides useful methods. With the last commit I resolved your suggestions and it should hopefully be ready to merge.


Add github button to docs homepage

If I end up at a software package's docs page before their Github repo, it is nice to be able to get directly to the Github repo from there. I find github repos can often be more difficult to find on search engines than docs pages
We have a small button which shows our stars and links users to Github. I think that is great, and I think we can also just add a button to our toolbar that takes people there.
This is personal preference, but this is something I personally think is worth having if your homescreen toolbar isn't already crowded

We have a small button which shows our stars and links users to Github

I literally just clicked on that two minutes ago :laughing:.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.433%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3448

Relevant Lines:
3613

💛  - Coveralls

Not sure if you noticed it, but there is also a linked GitHub logo in the footer of each page of the Sphinx build.
I mention it because it is pretty subtle, but I think having this in the sidebar might be subtle too.  Still an improvement, though.

Not sure if you noticed it, but there is also a linked GitHub logo in the footer of each page of the Sphinx build.
I mention it because it is pretty subtle, but I think having this in the sidebar might be subtle too. Still an improvement, though.

Ahh I forgot about those. I think you may have put those in first, before the "Stars" shield.

I feel like it may not belong under "References". Would you have noticed it if it were instead right below Installation Instructions? Or, maybe we could get it at the bottom with some whitespace separating it from the References, but IIRC that would be tricky -- the margin mainly comes from the header.

I think it fits naturally into all 3 places you suggested TBH. You could be "referencing" the implementation, or it could be seen as a helpful introductory link, along with the other intro stuff. Putting it below with some padded whitespace is fine too, but as we add more tools to CKT, whitespace may get scarce

OK, you've convinced me.

lol 🙌


Consider inferences between mapped type templates lower priority

Similarly to how inferences between mapped type constraints are lower priority. In general, inferences through a mapped type are usually just worse than other inferences, if available, due to the (potentially lossy) mapping operation the mapped type is doing.
Fixes #44092

@typescript-bot user test this
@typescript-bot test this
@typescript-bot run dt

@typescript-bot pack this

@typescript-bot cherry-pick this to release-4.3

@weswigham @DanielRosenwasser Is this ready to go into master and 4.3 respectively?

I mean, we should probably ship it in the nightly for a bit, right?


[WIP] Refactor util.go, deletes all kubeaudit types

This is an attempt to switch away from all our internal types to runtime.Objects. Let me know what you think.
TODO: Handle namespaces again.

Finally our test coverage is coming close to 80%


Update request: syslogng 3.38.1 → 4.1.1

I tried to update it, but it seems like it wants to build a virtualenv and fetch dependencies.
Not sure how to to properly fix it. Maybe just customizing the python and adding the deps will be enough.

Package name: syslogng
Latest released version: 4.1.1

Current version on the unstable channel: 3.38.1

Current version on the stable/release channel: 3.38.1

[x] Checked the nixpkgs pull requests

Notify maintainers

@ryantm @tobim
Note for maintainers: Please tag this issue in your PR.

fixed by #222265


Please update changelog

Hi @olimsaidov,
The change log is the releases. On the "releases" tab. I can point it out more in the documentation :-)


Audit 5.0 eng/Version.Details.xml chain

Missing in graph for 5.0.102: F#, NuGet.Client, diagnostics.

5.0 is EOL.  This issue is obsolete.


Settings page fixes

Can you put the "Reset to Default" and "Suggest a Source" together in the "Options" section on the Settings > Sources page? and then please confirm the bottom of that page has proper spacing (should be the same as inbetween sections)

Can you make sure the search-field placeholder and icon are center-aligned correctly on the Settings > Sources page? and then when you focus the field, we can remove the settings icon as we've essentially arrived on a different page.

Can you make sure secondary labels have the same font-size as the primary labels within sections, and also make sure they're properly vertically aligned? "France" in the screenshot below:

For the app's version number at the bottom of the Settings page can you
— improve the spacing above and below so it matches the section titles' spacing
— change the font-size so it matches the section titles on the same page
— change the text-color to #999 or rgba(153,153,153,1)
— change "DuckDuckGo" to "Version"

Left: current (lots of redundant space), right: new

Can you decrease the space left of the source titles/descriptions so that the space left and right of the source icons are equal?

ok, the next build includes all of these, although I'm not sure about #2 because the settings screen uses the same top bar as the rest of the tabs.  Is that supposed to be different, or was it misbehaving?

Thanks!
in regards to point 2, I meant the Sources page. In the screenshot below you can see how the placeholder there is not centered correctly:

...and in addition, we can hide the settings icon once you start searching, since tapping "Cancel" will take you back to settings:

number 4 is nearly spot on, the only thing is that the spacing at the bottom is slightly off (comparison below, desired height is 128px/64pt)

this should be set in the latest testflight build!

#2 is not fixed yet. the search placeholder on the Sources page is not center-aligned correctly, and the settings icon is still there when you focus the search-field. The rest looks good!

The placeholder alignment is centered on the entire top bar rather than the field itself.  This prevents it from jumping around when the buttons animate in/out from either side.  But if we remove the left button icon whenever the search field is active, that would resolve the problem, wouldn't it?  Now, removing that left button when the search field is active would also apply to all of the other views.  Is that acceptable?

I don't think that would work. When you're in the browser or in Settings > Sources for example, we're showing the house-icon or settings-icon. Both serve a different purpose than the "Cancel" button does. Here's a quick prototype of what I initially envisioned the transitions to be: http://cl.ly/2D1C2b3V1Y1T/prototype-3.mov

Another bug I'm experiencing there is:

Tap Settings tab, then go to Sources
Focus search-field
Tap Settings icon on upper left
Result: bang icon remains visible

Then, right-after, another bug:

Focus search-field
Result: Cancel button doesn't appear (so, there's no way of getting out)

@sreilly I noticed you removed the settings icon when on the Settings > Sources page and searching. I actually quite like it, feels a lot simpler. Let's keep it this way!
Although, searching doesn't work yet. After entering a query and hitting "Search" I'm taken to this page with a blank search-field:


Fix bandit tool output comma handling

Two changes:

Changes bandit's output parsing to take a list of strings like other tools (this helps the tests I'm developing by providing an easily-tested parsing function)
Use the CSV library to parse bandit output. Previously we were splitting on commas, but during testing at SoarTech we discovered that some issue descriptions can contain commas and break that parsing. The output properly quotes those elements of the output, so we might as well just use the CSV library.

Fixes #36.

I approve release of this change under the CC0 license.

Hold off on merging this, found an issue with my changes during testing.

Okay, fixed and ready.


reformat array traversal code for java cheat sheet

Change Summary
Reformat java traversal code according to clean code standards
Checklist
If you haven't fulfilled the below requirements or even delete the entire checklist, your PR won't be reviewed and will be closed without notice.
General

[ ] This Pull Request is all my own work. (You'll be blacklisted if you are caught for plagiarism.)
[ ] I've read CONTRIBUTING.md
[ ] I've made some valid changes to the CheatSheet, and they are not just minor changes.

Changes

[x] I've read and followed the Solution Template

Note: To mark the checkbox, put an x inside the [ ] (like this: [x]).

Please let me know if any issues in these changes,
Just starting out my open-source contribution journey with this 😊.

This can't be accepted as any major change!


Update documentation on linking Zephyr within a flash partition

PR #12108 "Shift DTS before Kconfig" modified how flash partitions are linked. Before #12108 was merged the process was as follows:

If the chosen node has no zephyr,code-partition property, the application image link uses the entire flash device. If a zephyr,code-partition property is defined, the application link will be restricted to that partition.

this is no longer true.
Following documentation needs to be updated:

"Linking Zephyr Within a Partition"
the help text of BOOTLOADER_MCUBOOT Kconfig option in ./Kconfig.zephyr
majority of board dts files that define flash partitions find boards/ -name "*.dts" | xargs grep -l partitions document linking process within flash node.

Yeah, now it is more like all nodes have the code-partition, somehow defined in DTS of the boards, but it is only used if there is no BOOTLOADER, correct?

It seems like the flash partition layout and setting of zephyr,code-partition property is taken into account only if BOOTLOADER_MCUBOOT Kconfig option is set.

This affects adafruit_trinket_m0. It's required that the adafruit_trinket_m0 boots from 0x2000 due to their UF2 bootloader.
zephyr,code-partition isn't taken into account because BOOTALODER_MCUBOOT isn't set apparently. So currently, no one can boot zephyr on the adafruit_trinket_m0 unless they physically change where flash begins e.g. something like:
	soc {
		nvmctrl: nvmctrl@41004000  {
			flash0: flash@0 {
				reg = <0x2000 0x3E000>;
			};
		};
	};

I'm sure there are other boards affected by this.

See my comments PR #20740  and the documentation about flash partitions here https://github.com/zephyrproject-rtos/zephyr/blob/master/doc/guides/dts/flash_partitions.inc
The Adafruit board dts is correct.  What is missing is the defconfig should include
CONFIG_USE_CODE_PARTITION=y


The sheets list is not updated if the sheet is changed after connected to VAQR

To update the sheet list, I have to manually add the spreadsheet ID again. Should we add the update sheet list in the SheetRefreshController?

I don't really get what you mean. I think we can click 'Connect' and it would update the sheet list.


Create uk_ua.json

Ukrainian translation, as in https://github.com/NemoNotFound/NemosCampfires/issues/2

That makes it easier, sorry I was busy with other things, but will take a look today!


HHH-10435 Create class loaders in a privileged block (5.1)

The test mentioned in HHH-10435 does not fail in EAP 7.1, so there is no test to reproduce this issue.
This fix is a first step to fixing HHH-12542, so I'm going to put off merging this PR until HHH-12542/WFLY-9064 is fixed.

https://ci.wildfly.org/viewLog.html?buildId=96925&tab=buildResultsDiv&buildTypeId=WF_MasterSecurityManager#testNameId219335434146728075 does fail; I'm not certain that EAP is doing full test runs with the security manager enabled though.  So, I would say there is a test that reproduces the issue.

In any event the problem is statically verifiable (there is an execution path that goes from deployment to class loader creation with no intervening doPrivileged block), so I'd say a reproducing test isn't necessary to show that there is a problem.

Closing because 5.1 is no longer maintained. HHH-10435 has been fixed in newer versons.


Country search not showing Collectives

I was looking for Scuttlebutt related Collectives in NZ. It turned up the host of the two such projects I'm aware of, but not the Collectives themselves (which have the keyword Scuttlebutt in their title even).

Country search should pick up on the fact that these Collectives are under an NZ host and their currency is NZD and show them when someone is searching for NZ.

Currently we only filter by country; and we don't check for currencies of collectives for this search. My thinking is maybe we should have a separate search filter for currency rather than mixing currencies and countries in the same country filter? This is proposed in one of the designs;
https://www.figma.com/file/ZQBMWhnGGtRWeIZknFW1eP/[OC-Design]-Production-Ready-✅?node-id=16237%3A237513
@Memo-Es

The thing is, users don't care about our data structure. They just want to know which things are in NZ or whatever they are filtering for. We store this information across many different forms and locations, but that's our issue to solve, not to expect the user to know whether to search by country or currency or address.

Currently we only filter by country; and we don't check for currencies of collectives for this search. My thinking is maybe we should have a separate search filter for currency rather than mixing currencies and countries in the same country filter? This is proposed in one of the designs;
https://www.figma.com/file/ZQBMWhnGGtRWeIZknFW1eP/[OC-Design]-Production-Ready-✅?node-id=16237%3A237513
@Memo-Es

@SudharakaP we don't need to involve the currency here. The country of an account should fallback to the parent's country, then the host's country.

@Betree : I've opened a PR for this to modify the search query so that we return collectives whose parent belong to the country that is filtered for. But one thing I am a bit unsure about is that whether we need to also display the country flag on the collective card for these projects. For example in the below screenshot we see that Test Project is shown because it's parent is Agora Collective and that  is Canadian. However currently on the front-end we don't show country flags for projects or events, only organizations. I am wondering if we should show this? I am doubtful because it also give a kinda misleading idea that an event belongs to a country or a project belongs to a country, which might be a bit confusing I felt compared to an organization or a collective showing the country flag. 🤔

cc: @Memo-Es

@Betree : I've opened a PR for this to modify the search query so that we return collectives whose parent belong to the country that is filtered for. But one thing I am a bit unsure about is that whether we need to also display the country flag on the collective card for these projects. For example in the below screenshot we see that Test Project is shown because it's parent is Agora Collective and that is Canadian. However currently on the front-end we don't show country flags for projects or events, only organizations. I am wondering if we should show this? I am doubtful because it also give a kinda misleading idea that an event belongs to a country or a project belongs to a country, which might be a bit confusing I felt compared to an organization or a collective showing the country flag. thinking

cc: @Memo-Es

I do think that we want to do this. As per my comment above:

The country of an account should fallback to the parent's country, then the host's country.

If you haven't defined your event location, then it should default to your collective location (because if not specified it seems safe to assume that you operate from the same country). Whether we want to also display the host country as a fallback by default is a different question, no strong opinion on my side.

I do think that we want to do this. As per my comment above:

The country of an account should fallback to the parent's country, then the host's country.

If you haven't defined your event location, then it should default to your collective location (because if not specified it seems safe to assume that you operate from the same country). Whether we want to also display the host country as a fallback by default is a different question, no strong opinion on my side.

@Betree : Thanks. I've opened a PR to add these flags to child collectives at; https://github.com/opencollective/opencollective-frontend/pull/7740


[bug]: Pending Force close channels never closed..

LND 0.16.1 on btcpayserver
Had these 2 channels stuck for over a month and not quite sure what to do with them. TX was confirmed a month ago
Not quite sure what to do to get rid of them...LND node has been restarted a  number of times over last couple of weeks
There is 15 million sats in 2 transactions...pretty sure that has gone to my onchain wallet, but just checking here...I can run abandon channel command...
Any ideas?
"pending_force_closing_channels": [
    {
        "channel": {
            "remote_node_pub": "039b3cab2a452a0ec921c417009817a8ae871b2098454078dd439e5f328a1108e6",
            "channel_point": "06a1325f186b2e89d6bc7b5d3c10d1fb48b74d4fb3bf2116066b7effeb671d42:1",
            "capacity": "5000000",
            "local_balance": "53123",
            "remote_balance": "4943041",
            "local_chan_reserve_sat": "0",
            "remote_chan_reserve_sat": "0",
            "initiator": "INITIATOR_LOCAL",
            "commitment_type": "ANCHORS",
            "num_forwarding_packages": "0",
            "chan_status_flags": "",
            "private": false
        },
        "closing_txid": "f8456d3c3a05792ca16d9d25e28229445f49579dd54c67be9888ee35f4f93e8c",
        "limbo_balance": "463",
        "maturity_height": 0,
        "blocks_til_maturity": 0,
        "recovered_balance": "330",
        "pending_htlcs": [
            {
                "incoming": false,
                "amount": "463",
                "outpoint": "58eefc76eea1c5ff516a6d280741b5d2aa1ddd1c64fe901052ddbb91ff94ff11:0",
                "maturity_height": 782767,
                "blocks_til_maturity": -5001,
                "stage": 1
            }
        ],
        "anchor": "RECOVERED"
    },
    {
        "channel": {
            "remote_node_pub": "03bb88ccc444534da7b5b64b4f7b15e1eccb18e102db0e400d4b9cfe93763aa26d",
            "channel_point": "68606f14aa5bd3415054f45fb5e5bc59e0ed399d4178fb85da764f0491ae9c51:1",
            "capacity": "10000000",
            "local_balance": "9540531",
            "remote_balance": "454565",
            "local_chan_reserve_sat": "0",
            "remote_chan_reserve_sat": "0",
            "initiator": "INITIATOR_LOCAL",
            "commitment_type": "ANCHORS",
            "num_forwarding_packages": "0",
            "chan_status_flags": "",
            "private": false
        },
        "closing_txid": "2806159a5c9d4efb78c8e43d652637224bb8d59cea6b0f6cc6c8699fac1c3930",
        "limbo_balance": "1003",
        "maturity_height": 0,
        "blocks_til_maturity": 0,
        "recovered_balance": "330",
        "pending_htlcs": [
            {
                "incoming": false,
                "amount": "1003",
                "outpoint": "197fca683520be7cc5e5edecb366c9823ace809e83a3132f122809f58b98f0b0:0",
                "maturity_height": 787189,
                "blocks_til_maturity": -579,
                "stage": 2
            }
        ],
        "anchor": "RECOVERED"
    }
],

In this case abandonchannel is not recommended, given that the channel already confirmed.
The channels appear in pending_force_closing_channels because "technically" the force close did not finish yet. They have htcls that still need to be resolved on chain. The node did not spend the funds of the htlcs yet because the amounts are too small which make it uneconomical (you would spend more on fees than the amount you would claim).
As you said that does not affect to other outputs in those transactions that have already been spent without any problem.
When fees go down and make it makes sense to sweep those funds your node will do it.


GOBBLIN-1229: Make topic specific state available to Kafka workunit packer

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1229

Description

[x] Here are some details about my PR, including screenshots (if applicable):
We enhance the kafka bin packer by adding topic specific configuration into the workunits passed to the workunit packer. In addition, we also add information about the number of topic partitions for the respective kafka topic into the workunit.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Existing unit tests.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@autumnust @ZihanLi58 Please review.


Problems with deep_merge

Clone repository :

git clone https://github.com/paliarush/magento2-vagrant-for-developers.git magento2-test

Initializing :

cd magento2-test
bash init_project.sh

I get an error :

Message: NoMethodError: undefined method `deep_merge!' for #Hash:0x00000001504b68

I read somewhere deep_merge would be a vagrant plugin, but just a vagrant plugin install deep_merge return the same error.

deep_merge is from ruby, and is used in Vagrantfile. Maybe there is a problem with your Vagrant version, what is it? What is your OS?

I also get this error.
Vagrant version: 1.9.0
OS: macOS Sierra 10.12.3

I currently have vagrant 1.8.5 installed. Please try any Vagrant version lower than 1.9 and let me know if the problem goes away for you.

I downgraded to 1.8.7 but then I get an error when it attempts to install the vagrant-hostmanager plugin. This is the error:
Bundler, the underlying system Vagrant uses to install plugins,
reported an error. The error is shown below. These errors are usually
caused by misconfigured plugin installations or transient network
issues. The error from Bundler is:
An error occurred while installing ffi (1.9.17), and Bundler cannot continue.
Make sure that gem install ffi -v '1.9.17' succeeds before bundling.
Warning: this Gemfile contains multiple primary sources. Using source more than once without a block is a security risk, and may result in installing unexpected gems. To resolve this warning, use a block to indicate which gems should come from the secondary source. To upgrade this warning to an error, run bundle config disable_multisource true.Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
/opt/vagrant/embedded/bin/ruby -r ./siteconf20170217-8354-c9pwto.rb extconf.rb

checking for ffi.h... *** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.
Provided configuration options:
--with-opt-dir
--with-opt-include
--without-opt-include=${opt-dir}/include
--with-opt-lib
--without-opt-lib=${opt-dir}/lib
--with-make-prog
--without-make-prog
--srcdir=.
--curdir
--ruby=/opt/vagrant/embedded/bin/$(RUBY_BASE_NAME)
--with-ffi_c-dir
--without-ffi_c-dir
--with-ffi_c-include
--without-ffi_c-include=${ffi_c-dir}/include
--with-ffi_c-lib
--without-ffi_c-lib=${ffi_c-dir}/lib
--with-libffi-config
--without-libffi-config
--with-pkg-config
--without-pkg-config
/opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:456:in try_do': The compiler failed to generate an executable file. (RuntimeError) You have to install development tools first. 	from /opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:587:in try_cpp'
from /opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:1060:in block in have_header' 	from /opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:911:in block in checking_for'
from /opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:351:in block (2 levels) in postpone' 	from /opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:321:in open'
from /opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:351:in block in postpone' 	from /opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:321:in open'
from /opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:347:in postpone' 	from /opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:910:in checking_for'
from /opt/vagrant/embedded/lib/ruby/2.2.0/mkmf.rb:1059:in have_header' 	from extconf.rb:16:in '
extconf failed, exit code 1
Gem files will remain installed in /Users/webslinga/.vagrant.d/gems/gems/ffi-1.9.17 for inspection.
Results logged to /Users/webslinga/.vagrant.d/gems/extensions/x86_64-darwin-13/2.2.0/ffi-1.9.17/gem_make.out

deep_merge is from ruby, and is used in Vagrantfile. Maybe there is a problem with your Vagrant version, what is it? What is your OS?

Vagrant : 1.9
vagrant -v
Vagrant 1.9.0

Ubuntu 14.04
lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 14.04.5 LTS
Release:	14.04
Codename:	trusty

The issue comes from the init_project.sh when the script try to get the list of vagrant plugin :
vagrant_plugin_list="$(vagrant plugin list)"

I dug into it and deep_merge is a RoR method for merging Hash together.
But my knowledge in Vagrant, Ruby language and RoR Framework are very low. I think I understand that Vagrant comes with its own Ruby environment, isolated from the host and hosted environment. If I check for the Ruby version in the VagrantFile :
puts RUBY_VERSION;
That print out the 2.2.5 Ruby version. That seems pretty cool.
But I ignore how to get the Rails version neither from the code or the command line. I ignore too if, like Ruby, Rails comes natively with vagrant.
How can I dig it further ?

I haven't been able to make much progress on Vagrant 1.8.7 (or 1.85) due to the error I posted above. However, I noticed the change from config_data_dist.merge! to config_data_dist.deep_merge! in the Vagrantfile was made fairly recently (commit 078dd84). I changed it back to config_data_dist.merge! and that seems to have resolved the issue thus far.

I changed it back to config_data_dist.merge! and that seems to have resolved the issue thus far.

Maybe because merge() is ruby method and deep_merge() a RoR method.
But the difference, I think, is that deep_merge() merge config files recursively. Merge is not design to do it. By the way, I'm not a Ruby developer, so it's a big I THINK :)
Maybe @paliarush can we implement a deep_merge() like method ? I'm not sure it's possible in the VagrantFile itself, but I see some examples through the web to do it. I think I can do this, but I need to know if I'm on the good way ?

@nicolaspernot feel free to provide a pull request with your implementation of recursive merge. Looks like current deep_merge does not work well for everyone. Thank you

@nicolaspernot did you have a chance to look into this issue?

Guten Tag,
Vielen Dank für Ihre Nachricht. Ich bin bis 31.7.2017 auf Urlaub.
In dringenden Fällen erreichen Sie meinen Kollegen Herrn Krieger  unter<EMAIL_ADDRESS>Mit freundlichen Grüßen,
Wolfgang Rock

Same issue here.
Vagrant 2.1.2

same issue
mac 10.13.4
Vagrant 2.1.2


[Bug] html-minifier vulnerability

Is this a regression?
Yes
Description
With ng-doc/builder 18 the html-minifier package was added which is not maintained and reports vulnerability - https://github.com/advisories/GHSA-pfq8-rq6v-vf5m. In issue 2022 you can find comments about maintained fork of this solution that fixed this vulnerability: https://github.com/kangax/html-minifier/issues/1135.
Would it be possible to switch to another fork to fix this reported vulnerability? I would like to use ng-doc 18, but my builds won't pass CI because npm audit reports vulnerabilities.
Please provide the exception or error you saw
No response
OS
Unix (Linux, macOS, etc.)
Browser
None
Node version
20.14.0
Anything else?
No response

I can work on PR with fix if there's no specific reason for using particularly kangax/html-minifier?

@AdrianKokot I would highly appreciate it. As far as I remember I used it for actions, you can replace it for sure but I would check that the content rendered by the actions is displayed correctly. The marked library that is used to convert markdown to html is very space sensitive, that's actually why I used the minifier.

:tada: This issue has been resolved in version 18.0.4 :tada:
The release is available on:

v18.0.4
GitHub release

Your semantic-release bot :package::rocket:


i18n support

Are there any plans to provide some tooling around i18n. The current docs on angular.io provide already documentation how to use it in combination with system.js

Somehow related: #2201

Thx the search is your buddy


Enable any other config variable in zoo.cfg.j2

Thanks for this ansible role, it is great. For our use case we would like to set other zookeeper config variables (for instance currently the whitelist). I thought that giving some freedom for adding more config vars could help. Unless I'm missing the expected way of adding more config variables in the current role.

Hey Pablo.
It is better if the configuration options are explicitly specified and have a human-readable description.
Please add the necessary configuration options to the zoo.cfg.j2 template or post them here, I'll try to do it over the weekend.

No problem, I have removed that and added the specific option that we needed for operation with solr cloud.

Lets rename zookeeper_cmd_whitelist variable to zookeeper_4lw_commands_whitelist. Also please change it`s type to list.
It is more ansible way. You can transform list items to string in the template. For example: https://github.com/dborisov/ansible-role-kafka/blob/83eef1660951a997fc9f021ffc6bc267a7f063e2/templates/server.properties.j2#L60


fix for helm push script

Signed-off-by: jonahjon<EMAIL_ADDRESS>Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.11


read physical tags from MSH4

This extends the reading of MSH4 #280, including binary MSH4 #284, in particular focusing on harvesting the physical tags from the $Entities section (begun in #289).

Can we get tests for this?

In the test suite?  Hmm.  That would be good...  Like some of the tiny meshes in test.helpers?  Yes, that would be good.  Probably have to wait till next week.
Meanwhile, I've tested against:

the examples from kinnala/scikit-fem#40
nschloe/pygmsh#209, specifically test/test_booleans, after reverting from MEDIT mesh to the default (in Gmsh 4) MSH4
the output of gmsh -2 t1.geo, with and without -bin

Note that this does not implement "gmsh:geometrical", which seems to have been dumped.  I doubt anyone used it much; I never did.

Actually no, such a test wouldn't work. That would require writing physical tags in MSH4. This is only for reading them. This is to fix pygmsh.generate_mesh nschloe/meshio#209 which only needs meshio.read, not meshio.write. The MSH4 is written by Gmsh 4, not meshio.
msh4.write currently doesn't write an $Entities section. Is that valid?
I think that the relevant test for this PR is test_booleans in pygmsh.  This was the test for the equivalent functionality in Gmsh <4 writing MSH2.

what about making use of a gmsh -convert subprocess

Good idea for local testing. For writing, let's just roll our own. It'll come to meshio sooner or later.


Having two arrows for initial states for concurrent states

If the following code is executed, there will be two arrows for initial states in the state machine diagram.
class A{
	status{
			status{
				on{
					turn_off -> off;
					stop{
						go_play -> play;
					}
					play{
						go_stop -> stop;
						go_pause -> pause;
					}
					pause{
						go_play -> play;
						go_stop -> stop;
					}
				}
				off{
					turn_on -> on;
				}
				||
				active{
				s1{
					go_s2 -> s2;
				}
				s2{
					go_s1 -> s1;
				}
			}
		}
	}
}

Instead of a start symbol in both active and on, with two arrows both going to S1 and to Stop, there should be a start symbol in status, with an arrow going to s1 and another arrow going to stop, indicating that there will be a split of control. (it would b ideal if we could show the notion of the concurrent region properly, but graphviz seems to have no way to allow this,
This will likely be a very challenging problem requiring a lot of time spent understanding code.
It will also be necessary to find all the other examples of state machines in Umple that have this problem and make sure they are solved. Furthermore it will be necessary to ensure that no other state machines are changed.
The best approach would be to first add a proper set of test cases for state machine diagram drawing so any accidental changes resulting from this do not add new defects.

Here's another simpler example
class X {
sm {
sma {
eb -> smc;
}
smc {
region1 {
sp {
ea -> sp2;
}
sp2 {}
}
||
region2{}
}
}
}

The code for this is in Generator_CodeGvStateDiagram.ump
Hint: Generate the gv file from Umple. Then edit the gv file until it is correct; then edit the generator.


Native Physics

Replace actual physics simulation with native simulation like Chipmunk2D

Hi. I had interest in bindings to Chipmunk2D too (but abandoned for the moment). For the record, this is a link to the recent discussion in the storm project: https://github.com/cdlm/pharo-storm/issues/1

Hi again @tinchodias ,
As Esteban told you, i let native physics away for the moment but i am now trying to implement them again. All the problems you faced or you are facing, i faced and solved some of them.
I am working (very slow) on a local branch, if you are interested and want to try, i can push changes and you can continue.
Let me know

Thanks, but I won't continue with this idea for the moment. Just wanted to make that comment for the case it adds some information.


futureproof?

Thanks for the great app.
Just a small question: How likely is it that i.e. the name of the installer changes and the app doen't block it anymore?

Thanks. In my opinion, it is very unlikely that the bundle ID of the installer will change now that we have a released version. However, if it happens, I will immediately release a new version.


iOS Mobile Safari not scrolling to invalid field

Hi,
As mentioned in #878 I noticed that Parsley is not scrolling the screen properly to show the first error on iOS Mobile Safari (obviously for the issue to be visible, the form needs to be long enough so that the error is outside of the viewport).
From a UI/UX perspective this is pretty bad, because the user clicks on "submit", nothing happens, and the error is not shown.
Any idea how to fix this? Thanks!

Btw, in case it's useful, this is a workaround used for jQuery-validate:
http://stackoverflow.com/questions/9417171/jquery-validation-not-working-on-iphone

Based on the code sample from the jQuery-validate workaround above I solved the problem with this function attached to the form:validate event
window.Parsley.on( 'form:validate', function (form) {
	if (!form.isValid()) {
		for (var n = 0; n < form.fields.length; n++) {
			if (form.fields[n].validationResult !== true) {
				if(window.navigator.userAgent.match(/iphone|ipad/i)) {
					window.setTimeout(function() {
						$("html,body").animate({
							scrollTop: $(form.fields[n].$element[0]).offset().top
						});
					}, 0);
				}
				break;
			}
		}
	}
});

Can someone provide me with a particular example, iOS version and device? I tried our simple form example in the iOS Simulator (iPad Air / iOS 8.2), leaving the name empty and filling everything else correctly, and when I pressed validate it scrolled the name into view correctly.
The only iOS device I have is an original iPad that is stuck in an ancient OS, so I can't really test any other way than with the simulator... (gifts accepted though lol ;-) )

@marcandre I use phone emaulator from google chrome developer edition ( select iphone 5 and 6) and it works fine. When I try on real iPhone 5 and iPhone 6 it is not working.
OS: iOS 9+

@F1sn1k thanks. Are you using the simple form example as I described? Does it not scroll, or does it lock up like some others are reporting?

@marcandre No I use my custom application

I just tested the simple form example on my iPhone 6 (iOS 9.3.1) and it scrolls to the middle of the hobbies list every time I press validate.
It does however focus on the correct field, so if I start typing it then scrolls to the first name field.
It also zooms in a bit which is probably because the input font size is less than 16px (can't check on my phone).

I see the same on an ipad mini. I added two screenshots, one before and one after validate.
What happens is the same as mentioned above. The textbox does get focus, hence the keyboard, but it is not visible as there's no scrolling to the field. scrolling the page manually still works.
If I fill in the textboxes, but not the radios, then nothing happens visually. Apart from the fact that the form moves down a bit as the error message on top pushes it down.
i use an iPad mini with 9.2.1.

Same problem with 9.3.2 & 7.1.2. It tries to scroll to submit button itself

I'm sorry for the troubles you're having... I don't have a modern iOS device to test this on.
It also looks like a bug in Safari/iOS, no?
Knowing the details of that bug would help find the best way to circumvent it...

Yes, it's on Safari/iOS and also on Chrome/iOS - the same behavior.

As I mentioned, I don't have an iOS device I can use for testing...
What would really help is if someone can make a minimal example, without using Parsley, whereby clicking on a button executes JS and the call to focus fails. Maybe it's only when validating? Maybe it's only when some DOM has been added (error message)?
Then (or directly), we have to figure out if the issue has been reported to Apple. Also, is jQuery aware of the issue and can they circumvent it?


DockerComposeContainer withExposedService default wait strategy fails

Hello again :)
Since I can't use container_name in my docker-compose.yml I have to dynamically set the configuration of a service via environment variables. To do so I call .getServiceHost() and .getServicePort() to retrieve the values. In order to be able to call them I need to add .withExposedService() to my DockerComposeContainer instance (that is already strange as I could just have ports or expose defined in my docker-compose.yml).
Using the default wait strategy fails because it tries to identify listening to some unknown port like 32824. As I see it's mapped either by ryuk or socat containers but the first one is not even at the same network all the services from the docker-compose.yml defined. As a workaround I just created a dummy anonymous class with an empty waitUntilReady implementation.
Why does it try to listen for the strange port not related to my service? Or why does the mapping between my service's port and the corresponding 'ambassador' one fail?
Thanks. Gonna appreciate any docs on that as well.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

Would be good to grab some attention from devs


Not getting the IconButton to display icon

I am trying to use react-toolbox in the react-slingshot starter kit. I am trying to display an IconButton similar to the one on the react-toolbox site examples.
1.I installed react-toolbox
2.I made a change to the webpack config to say:
{test: /(.css|.scss)$/, loaders: ['style', 'css?sourceMap&modules&importLoaders=1&localIdentName=[name][local]_[hash:base64:5]', 'sass?sourceMap']},
3.I installed toolbox-loader (not sure if it is needed)
4.In the HomePage component I added:
import {IconButton} from 'react-toolbox/lib/button';
and then:

This is what displays for the button:

I just see the word FAVORITE instead of the icon. What am I doing wrong? Let me know if I need to provide more info. But basically I did not make any other changes. Thanks.

You need the material icons font, see the docs: http://react-toolbox.com/#/components/font_icon

+1 @lucasljj

I am facing the same problem, couldn't find any example to explain how to correctly import build.

http://google.github.io/material-design-icons/#getting-icons

Why aren't there simple steps for this kind of stuff?
yarn add material-design-icons

Add this to .js file which imports your css
import 'material-design-icons/iconfont/material-icons.css'

Thanks, but I am not using create-react-app and that didn't work with my custom setup.

I am using a custom setup and added the following to my index.html:
 <link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">