Rosinstall Error

Hi, thanks for sharing this. When I tried to clone and build the demo application, I ran the command "rosinstall deepracer_description", but I received the following error:
ERROR in rosinstall:
No 'ros' stack detected in candidates [].
Please add the location of a ros distribution to this command.
I tried to add the location of /opt/ros/foxy, but it doesn't solve the issue. Could you help me with it? Thank you!

Hi @yz0009 ,
Thanks for reporting the issue. We have modified the instructions to revert the gazebo_ros_control package to the previous commit compatible to our packages. Please follow the updated instructions in the  section 1.1.2 – Clone and build the demo application (Added below for your reference)

1.1.2 – Clone and build the demo application
From the bash terminal within the IDE, run these commands to clone the demo application and install the needed dependencies:
mkdir -p deepracer_nav2_ws
cd deepracer_nav2_ws
git clone https://github.com/aws-deepracer/aws-deepracer.git

sudo apt update

rosdep install -i -r -y --from-paths .
cd aws-deepracer
rosinstall deepracer_description
cd gazebo_ros2_control && git reset --hard 04b2c6f0ff0e977b6fc6af5dfc5e96e5bdd570d0 && cd ..

@siddalingesha-ds could you clarify how reverting to an older commit
in a repo that's fetched by the command that's reported to be failing
is supposed to help the command to succeed?
Needless to say, I'm facing the same issue using the updated instructions.
$ rosinstall deepracer_description
rosinstall operating on /opt/deepracer/aws-deepracer/deepracer_description from specifications in rosinstall files
(Over-)Writing /opt/deepracer/aws-deepracer/deepracer_description/.rosinstall
[../gazebo_ros2_control] Fetching https://github.com/ros-simulation/gazebo_ros2_control.git (version master) to /opt/deepracer/aws-deepracer/gazebo_ros2_control
Cloning into '/opt/deepracer/aws-deepracer/gazebo_ros2_control'...
remote: Enumerating objects: 923, done.
remote: Counting objects: 100% (431/431), done.
remote: Compressing objects: 100% (190/190), done.
remote: Total 923 (delta 316), reused 304 (delta 236), pack-reused 492
Receiving objects: 100% (923/923), 1.55 MiB | 8.93 MiB/s, done.
Resolving deltas: 100% (553/553), done.
[../gazebo_ros2_control] Done.
[../aws-robomaker-bookstore-world] Fetching https://github.com/aws-robotics/aws-robomaker-bookstore-world.git (version ros2) to /opt/deepracer/aws-deepracer/aws-robomaker-bookstore-world
Cloning into '/opt/deepracer/aws-deepracer/aws-robomaker-bookstore-world'...
remote: Enumerating objects: 540, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 540 (delta 16), reused 15 (delta 15), pack-reused 519
Receiving objects: 100% (540/540), 24.62 MiB | 21.36 MiB/s, done.
Resolving deltas: 100% (238/238), done.
[../aws-robomaker-bookstore-world] Done.
(Over-)Writing setup.sh, setup.bash, and setup.zsh in /opt/deepracer/aws-deepracer/deepracer_description
ERROR in rosinstall:
No 'ros' stack detected in candidates [].
Please add the location of a ros distribution to this command.

See http://ros.org/wiki/rosinstall.

BTW, I also find the "hack"
cd gazebo_ros2_control && git reset --hard 04b2c6f0ff0e977b6fc6af5dfc5e96e5bdd570d0 && cd ..

somewhat curious, considering that rosinstall accepts hashes in version.
http://library.isr.ist.utl.pt/docs/roswiki/rosinstall.html#File_format
Wouldn't changing the version in .rosinstall be much cleaner?
diff --git a/deepracer_description/.rosinstall b/deepracer_description/.rosinstall
index 8e691a3..0afc16f 100644
--- a/deepracer_description/.rosinstall
+++ b/deepracer_description/.rosinstall
@@ -4,6 +4,6 @@
 # USE THE rosinstall TOOL INSTEAD.
 # IF YOU CHANGE IT, USE rosinstall FOR THE CHANGES TO TAKE EFFECT
 - git: {local-name: ../gazebo_ros2_control, uri: 'https://github.com/ros-simulation/gazebo_ros2_control.git',
-    version: master}
+    version: 04b2c6f0ff0e977b6fc6af5dfc5e96e5bdd570d0}
 - git: {local-name: ../aws-robomaker-bookstore-world, uri: 'https://github.com/aws-robotics/aws-robomaker-bookstore-world.git',
     version: ros2}

BTW, that still doesn't avoid the "ERROR in rosinstall;"...


Output in version subcommand the Env version and XDR version

Dependent on https://github.com/stellar/rs-soroban-env/issues/574

This was implemented at some point.


gungnir: init at 1.0.8

Description of changes
https://github.com/g0ldencybersec/gungnir is a command-line tool written in Go that continuously monitors certificate transparency (CT) logs for newly issued SSL/TLS certificates.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

you should leave the v in front of the version in the commit message out. that how people do it if you git log --oneline.
https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions says init at version and i believe the v is not actually part of the version but makes it clear that the following text is a version.

thanks, I've updated the commit message

it goes so fast damn

Result of nixpkgs-review pr 311881 run on aarch64-darwin 1

1 package built:

gungnir


Setup chainctl remove the need for sudo

Previously our action required sudo to move the chainctl binary to /usr/local/bin. Moving it to ~/.local/bin does not require sudo. I suspect the original action breaks on self-hosted runners, setting some up now to test and confirm

I was successfully able to reproduce this error on a self-hosted runner.
Error: creating symlink: symlink /usr/local/bin/chainctl /usr/local/bin/docker-credential-cgr: permission denied

The issue is that when we use sudo to move the chainctl binary to /usr/local/bin, the chainctl auth configure-docker command does not run with sudo privileges so it's unable to create the symlink when on a self-hosted runner. Seems that Github-hosted runners are doing some magic to make life easy and we can't expect that same magic on a self-hosted runner


3D Tiles Styling - add vector support to the built-in functions

Now that vector types are supported in the styling language (https://github.com/AnalyticalGraphicsInc/cesium/pull/4759) the built-in functions should support the vec2, vec3, and vec4 types in addition to supporting numbers as they currently do.
Unary functions can accept either a number, vec2, vec3, or vec4. If the type is a vector, the function should be applied to every component of the vector and return the resulting vector. This rule applies to the other functions as well.

[x] radians
[x] degrees
[x] cos
[x] sin
[x] tan
[x] asin
[x] acos
[x] atan
[x] sqrt
[x] abs
[x] sign
[x] floor
[x] ceil
[x] round
[x] exp
[x] log
[x] exp2
[x] log2
[x] fract

The function signatures for all these look like:
fract(vecx x)
fract(float x)
For atan and pow, both arguments must be the same type.

[ ] atan2
[ ] pow

atan2(float x, float y)
atan2(vecx x, vecx y)
pow(float x, float y)
pow(vecx x, vecx y)
For min and max, the second argument may be a number. Otherwise the types should match.

[ ] min
[ ] max

min(float x, float y)
min(vecx x, vecx y)
min(vecx x, float y)
max(float x, float y)
max(vecx x, vecx y)
max(vecx x, float y)
Example: min(vec4(1.0), vec4(2.0)) and min(vec4(1.0), 2.0) are both valid, but min(vec4(1.0), vec3(1.0)) is not
Similar rules for mix and clamp:

[ ] mix

mix(float x, float y, float a)
mix(vecx x, vecx y, vecx a)
mix(vecx x, vecx y, float a)

[ ] clamp

clamp(float x, float minVal, float maxVal)
clamp(vecx x, vecx minVal, vecx maxVal)
clamp(vecx x, float minVal, float maxVal)
Below are functions that haven't been added to the styling language yet.

[ ] length

length(vecx x)
length(float x)

[ ] distance

distance(vecx x, vecx y)
distance(float x, float y)

[ ] dot

dot(vecx x, vecx y)
dot(float x, float y)

[ ] normalize

normalize(vecx x)
normalize(float x) -- always return 1.0

[ ] cross - this is a special case, ONLY vec3 is supported. Throw a DeveloperError otherwise.

cross(vec3 x, vec3 y)
As usual, this is a good reference: http://www.shaderific.com/glsl-functions/
I'll open a PR for one of these. And then possibly @Dylan-Brown or others can finish it off.

Please link to this from #3241 (and link future short-term 3D Tiles issues) so we can track our progress.

Unary functions PR here: https://github.com/AnalyticalGraphicsInc/cesium/pull/4867

Hi, I'm working on adding the length and distance functions but couldn't find anything in CesiumMath that support either of those two functions. Are there any other functions in the repo that could possibly help me?

Look into Cartesian3.length and Cartesian3.distance.

@glee2244, @Jane-Of-Art, @Dylan-Brown
Just a heads up that length is being implemented here: https://github.com/AnalyticalGraphicsInc/cesium/pull/5149

Finished. Thanks @Jane-Of-Art and @glee2244 for the work here!


Make ContractInfoResponse exhaustive for convenience

Closes #1165.

Shouldn't we create a constructor instead of making this exhaustive? After this change we cannot add additional information in a non-breaking way.

Shouldn't we create a constructor instead of making this exhaustive? After this change we cannot add additional information in a non-breaking way.

Seems like a reasonable alternative.

Thought about that, but it's such an indirect use case (using this in mocks / tests) that I'm not sure it's worth it. This struct is not supposed to be constructed, so, that constructor should be in any case be made available to test code only.
I can re-open and add it if you want.

The motivation is not to have a constructor. The motivation is that cosmwasm-std 1.x can add new fields to the query result by keeping the #[non_exhaustive] attribute.

I was thinking, retaining #[non_exhaustive] and adding a Default available from test code could be a good idea.

Is there a good Default value for code_id or creator? Don't think so. But ContractInfoResponse::new(code_id, creator) can work. The rest can be set to false/None and be changed via mut members.


Prevent lib crash when no database connection

When this gem is included and there is no connection to a database, there are multiple exceptions that can be raised by the table_exists? call including ActiveRecord::ConnectionNotEstablished or PG::ConnectionBad.
By checking the result of connected? available with ActiveRecord, we make sure the call to table_exists? does not throw an exception.

When the CI check passes!

I'm not sure why it fails. It also failed on the run prior to mine. It looks like a problem with databases not being available when the CI runs. But I don't know how to set this up.

After further review, it seems the connected? method returns false when running tests in other projects, which breaks more stuff than this fixes. Will hold on this for the moment.

After further review, it seems the connected? method returns false when running tests in other projects, which breaks more stuff than this fixes. Will hold on this for the moment.


Clean up editable

https://github.com/este/este/blob/master/src/client/components/editable.react.js#L54-L60 remove?

yes please

Is there a reason for removing this? If we don't like this syntax, consider using @autobind from core-decorators?

It's not needed, can be bind within render method.

True, but this will cause a re-bind every time render is invoked. If that's not an issue, clean away :)

in progress


Create a Toolkit.MixinState Api utility

I'm still on the fence about this.
All this function would be is:
function(classDefinition) {
  _.extend(classDefinition.prototype, StateMixin);
}

However prototypical stuff scares people sometimes so this makes an easy interface that doesn't look scary.
But it is similar to https://github.com/marionettejs/backbone-metal/blob/master/src/mixin.js#L12 in its simplicity.
Alternatively people can always do this..  const MyView = Marionette.ItemView.extend(StateMixin).extend({ foo: 'bar' });  This is a perfectly acceptable method as well though it deepens the prototype chain.  Not sure what would be best to support.

I do like however that we could just tell people.. "Want the state API everywhere just do:" Toolkit.MixinState(Marionette.Object); Toolkit.MixinState(Marionette.View)
For v2 that'd cover, I think, everything..  in v3 you'd have to add CollectionView as there isn't a base view class in v3 (other than Backbone's which doesn't support StateMixin)

Ok we should do this and it should handle StateModel collisions with the prototype


Added some tests for @noescape and @autoclosure attribute placement.

What's in this pull request?
As decl attribute and type attribute.
Resolved bug number: N/A

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

We're currently in a weird state, this SE refines it:
https://github.com/apple/swift-evolution/blob/master/proposals/0049-noescape-autoclosure-type-attrs.md

When that SE lands, the test case can be updated, thanks!


Fix NPE for GenericContainer::isRunning (#411)

Hi @bsideup,
Sure will do.

@dhargo Looks good! Only one more thing - please add a record to CHANGELOG.md (sorry for not mentioning that before)

Sorry for late CHANGELOG.md update.

@dhargo perfect, thanks! :)


Add Cluster foreign key to k8s objects

Description
Adds cluster foreign key so we don't need to worry about pruning when clusters are deleted
@c-du We will need to be very careful on migration here
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

Cluster postgres store uses delete+copyFrom for batch operations. The delete will cause all the dependencies to be deleted. To avoid unintended cascade deletes from batch updates, add no-fk-constraint to proto or remove copyFrom from Cluster

@md2119 There are no batch operations for Clusters so this is actually safe

Cluster postgres store uses delete+copyFrom for batch operations. The delete will cause all the dependencies to be deleted. To avoid unintended cascade deletes from batch updates, add no-fk-constraint to proto or remove copyFrom from Cluster

@md2119 There are no batch operations for Clusters so this is actually safe, but do need to be careful about enabling that in the future

Let me rephrase the statement. This change relies on store layer batch functionality not being exposed. Furthermore, it requires the store's consumers to know the implementation details, which should not be the case. However, there is no check to prohibit that. I recommend we add a flag to generator to skip generating batch functionality.


Distribution of embedding values

I'm using the embeddings generated by enformer for another project, and while I'm getting meaningful results from my own linear output heads I was struck by the distribution of the embedding values themselves.
If I run the following
import matplotlib.pyplot as plt
import numpy as np
import torch
from enformer_pytorch import Enformer

enformer = Enformer.from_pretrained('EleutherAI/enformer-official-rough')
seq = torch.randint(0, 5, (2, 196_608)) # for ACGTN, in that order (-1 for padding)
output, embeddings = enformer(seq, return_embeddings=True)

plt.hist(embeddings.detach().numpy().ravel(), bins=np.linspace(-0.5, 0.5, 200), density=True);
plt.xlim([-0.5, 0.5]);

I see the following plot

I can confirm I get a very similar distribution of values using real sequences instead of random noise.
I'm struck by the sharp cutoff at around -0.16, and the U shape distribution for negative values, the strong peak at zero, and the tail of positive values. Naively I would have expected to see something more normally distributed around zero, but I guess I don't have a lot of experience looking at outputs of transformers. I'm curious if this distribution is to be expected based on the model or if it is at least of no concern to experts? I'm also curious if any DeepMind provided embedding values have the same distribution. I havn't downloaded any, but could try looking into that if it was of broader interest.
As noted above I do get alright predictions from my own linear output heads, but my I'm struggling to match the distribution of target values and the distribution of my outputs and so was curious if this could be one contributing reason, though there could be many other factors at play that are specific to my application.

@sofroniewn Hi Nicholas
Yes, you are correct - typically in transformers we add a layernorm at the very end of all the attention / feedforward blocks, just before the linear head projection. Embeddings would be taken after this layernorm, and would probably have more of a distribution you are used to seeing
However that layernorm seems to be absent in the Enformer architecture
You can always add an additional transformer block followed by this layernorm, and perhaps the embeddings would have

@sofroniewn Hi Nicholas
Yes, you are correct - typically in transformers we add a layernorm at the very end of all the attention / feedforward blocks, just before the linear head projection. Embeddings would be taken after this layernorm, and would probably have more of a distribution you are used to seeing
However that layernorm seems to be absent in the Enformer architecture
You can always add an additional transformer block followed by this layernorm and learn it yourself

@sofroniewn are you using one of the fine tuning modules? i could add this as an option, provided you share whether this helps or not for what you are working on

ohh i see, Enformer does have a final normalization, but in the form of a batchnorm (within the final pointwise convolutional block) https://github.com/lucidrains/enformer-pytorch/blob/main/enformer_pytorch/modeling_enformer.py#L334-L339

@sofroniewn could you try setting this to True for your task? and also i'd be curious what the resulting distribution looks like after fine tuning

Hi Phil
Thanks for the detailed response and code option. So far I've actually just been using the embeddings generated from the pre-trained network and feeding them into my own custom head without any fine tuning of the enformer. Right now I'm also just taking a single embedding vector at the midpoint of the sequence. My current task is analogous to the CAGE predictions from the TSS in the enformer paper.
I just tried adding in my own layernorm before my custom head and performance went down very slightly, still using the fixed embeddings as inputs. I will investigate this further though before drawing any strong conclusions as I have a couple different tasks I can try this on.
I have been interested in trying fine tuning the enformer but have shied away from it so far due to computational demands and the fact that my task right now just uses a single embedding vector from the whole sequence. I might revisit this soon though and start trying to fine tune - in which case I will try both with and without the post_transformer_embed option and report back.
Thanks again for your help here!


Dynamic Object Key is strange when using with keyof

Search Terms
keyof, dynamic object key
Suggestion
In my option, there is a strange behaviour when using keyof with a dynamic object.
For example, let's see this simple code:
type TDynamicKey = { [key: string]: string }
type Magic = keyof TDynamicKey

Playground
Which will be the type of Magic?

string
string | number

The correct choice is the second.
But since the keys will be just string, why we are receiving number too? I think that Magic should be just string.
type TDynamicKey = { [key: number]: string }
type Magic = keyof TDynamicKey // type Magic = number

In this situation works as expected. Just number.

This is working as intended, see TS2.9 release notes, support for number in keyof.

@jcalz

Given an object type X, keyof X is resolved as follows:

If X contains a string index signature, keyof X is a union of string, number, and the literal types representing symbol-like properties, otherwise

Okay. It is working as intended. But what is the reason for this behaviour? Just string wouldn't be better?

TS tries to model the behavior of JS. In JS, you can't have a key of type string and one of type number with the same value . Also if you index using a number and the equivalent string value is present, you will get the key. So while a bit surprising, it is consistent with the way JS actually works:
console.log({ "0": "A" }[0]) // "A"
console.log({ 0: "A" }["0"]) // "A"
console.log({ 0: "A", "0": "B" }["0"]) // "B" (also duplicate key error in TS which is ok)
console.log({ 0: "A", "0": "B" }[0]) // "B" (also duplicate key error in TS which is ok)

Playground Link

@dragomirtitian

So, okay. I understand better now.
For me, this issue could be closed and tagged and working as intended.

I have the same problem. One solution that I found is to use Record<string, string>.
link to playground
type TDynamicKey = Record<string, string>
type Magic = keyof TDynamicKey

Hope this helps.


Uncaught Error: Class 'Core\Router' not found

Fatal error: Uncaught Error: Class 'Core\Router' not found in /home/islam/CodeGuru/ishop/index.php on line 10

AND it's what in Router

What is the URL you try to open?

It looks like you've got the index.php front controller script in the root instead of in the public folder, is that right? If so, try changing the line where you include the Composer autoloader from this:
require dirname(__DIR__) . '/vendor/autoload.php';
to this:
require __DIR__ . '/vendor/autoload.php';

thank you very much for the help)


Add optional redis auth to karton

There are few situations where authentication to the Karton's central Redis server is desirable:

Karton is deployed on the public network, and Redis server has to be accessible to other services (but obviously not to the whole Internet)
Defence in depth, or more complex access control (for example, readonly users)

This change should be relative easy to implement, and we already require auth to the central minio server.

Closed by #114


CI: K8sServicesTest Checks N/S loadbalancing Tests with XDP, direct routing, SNAT and Random: no program bpf_xdp_entry found in eBPF ELF

Test Name
K8sServicesTest Checks N/S loadbalancing Tests with XDP, direct routing, SNAT and Random

Failure Output
Timed out after 240.000s.
Timeout while waiting for Cilium to become ready
Expected
    <*errors.errorString | 0xc000592540>: {
        s: "only 0 of 2 desired pods are ready",
    }
to be nil

Stack Trace
/home/jenkins/workspace/Cilium-PR-K8s-1.24-kernel-net-next/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:527
Timed out after 240.000s.
Timeout while waiting for Cilium to become ready
Expected
    <*errors.errorString | 0xc000592540>: {
        s: "only 0 of 2 desired pods are ready",
    }
to be nil
/home/jenkins/workspace/Cilium-PR-K8s-1.24-kernel-net-next/src/github.com/cilium/cilium/test/k8s/assertion_helpers.go:115

Standard Output
Number of "context deadline exceeded" in logs: 0
Number of "level=error" in logs: 0
Number of "level=warning" in logs: 0
Number of "Cilium API handler panicked" in logs: 0
Number of "Goroutine took lock for more than" in logs: 0
No errors/warnings found in logs
Number of "context deadline exceeded" in logs: 0
Number of "level=error" in logs: 0
Number of "level=warning" in logs: 0
Number of "Cilium API handler panicked" in logs: 0
Number of "Goroutine took lock for more than" in logs: 0
No errors/warnings found in logs
Number of "context deadline exceeded" in logs: 0
Number of "level=error" in logs: 0
Number of "level=warning" in logs: 0
Number of "Cilium API handler panicked" in logs: 0
Number of "Goroutine took lock for more than" in logs: 0
No errors/warnings found in logs
Cilium pods: [cilium-dzg68 cilium-lbnmj]
Netpols loaded:
CiliumNetworkPolicies loaded:
Endpoint Policy Enforcement:
Pod                           Ingress   Egress
echo-bc5cf6ffb-cjhh6          false     false
testclient-2-jrr4k            false     false
app1-66c4bbdd44-k7k57         false     false
app2-5754fc87cc-n2wxq         false     false
echo-bc5cf6ffb-5qdwm          false     false
testclient-2-tc6dx            false     false
testclient-qbd9h              false     false
testclient-svzfh              false     false
testds-6l6v2                  false     false
testds-mmhlm                  false     false
grafana-b96dcb76b-87tcn       false     false
test-k8s2-5754548676-nx5kv    false     false
app1-66c4bbdd44-sdddd         false     false
app3-5bcc6c8fb-pjmmw          false     false
coredns-8c79ffd8b-ldk4f       false     false
prometheus-5c59d656f5-47zmg   false     false

Standard Error
01:49:01 STEP: Installing Cilium
01:49:03 STEP: Waiting for Cilium to become ready
FAIL: Timed out after 240.000s.
Timeout while waiting for Cilium to become ready
Expected
    <*errors.errorString | 0xc000592540>: {
        s: "only 0 of 2 desired pods are ready",
    }
to be nil
=== Test Finished at 2022-07-30T01:53:03Z====
01:53:03 STEP: Running JustAfterEach block for EntireTestsuite K8sServicesTest
===================== TEST FAILED =====================
01:53:03 STEP: Running AfterFailed block for EntireTestsuite K8sServicesTest
cmd: kubectl get pods -o wide --all-namespaces
Exitcode: 0
Stdout:
 	 NAMESPACE           NAME                               READY   STATUS             RESTARTS      AGE     IP              NODE   NOMINATED NODE   READINESS GATES
	 cilium-monitoring   grafana-b96dcb76b-87tcn            1/1     Running            0             20m     <IP_ADDRESS>      k8s1   <none>           <none>
	 cilium-monitoring   prometheus-5c59d656f5-47zmg        1/1     Running            0             20m     <IP_ADDRESS>       k8s1   <none>           <none>
	 default             app1-66c4bbdd44-k7k57              2/2     Running            0             10m     <IP_ADDRESS>      k8s1   <none>           <none>
	 default             app1-66c4bbdd44-sdddd              2/2     Running            0             10m     <IP_ADDRESS>      k8s1   <none>           <none>
	 default             app2-5754fc87cc-n2wxq              1/1     Running            0             10m     <IP_ADDRESS>      k8s1   <none>           <none>
	 default             app3-5bcc6c8fb-pjmmw               1/1     Running            0             10m     <IP_ADDRESS>      k8s1   <none>           <none>
	 default             echo-bc5cf6ffb-5qdwm               2/2     Running            0             10m     <IP_ADDRESS>       k8s2   <none>           <none>
	 default             echo-bc5cf6ffb-cjhh6               2/2     Running            0             10m     <IP_ADDRESS>       k8s1   <none>           <none>
	 default             test-k8s2-5754548676-nx5kv         2/2     Running            0             10m     <IP_ADDRESS>      k8s2   <none>           <none>
	 default             testclient-2-jrr4k                 1/1     Running            0             10m     <IP_ADDRESS>      k8s1   <none>           <none>
	 default             testclient-2-tc6dx                 1/1     Running            0             10m     <IP_ADDRESS>      k8s2   <none>           <none>
	 default             testclient-qbd9h                   1/1     Running            0             10m     <IP_ADDRESS>      k8s1   <none>           <none>
	 default             testclient-svzfh                   1/1     Running            0             10m     <IP_ADDRESS>      k8s2   <none>           <none>
	 default             testds-6l6v2                       2/2     Running            0             10m     <IP_ADDRESS>      k8s2   <none>           <none>
	 default             testds-mmhlm                       2/2     Running            0             9m54s   <IP_ADDRESS>       k8s1   <none>           <none>
	 kube-system         cilium-dzg68                       0/1     CrashLoopBackOff   5 (25s ago)   4m1s    <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system         cilium-lbnmj                       0/1     CrashLoopBackOff   5 (14s ago)   4m1s    <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         cilium-operator-7664479f67-b5qmn   1/1     Running            0             4m1s    <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system         cilium-operator-7664479f67-qtl46   1/1     Running            0             4m1s    <IP_ADDRESS>   k8s3   <none>           <none>
	 kube-system         coredns-8c79ffd8b-ldk4f            1/1     Running            0             14m     <IP_ADDRESS>       k8s1   <none>           <none>
	 kube-system         etcd-k8s1                          1/1     Running            0             28m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         kube-apiserver-k8s1                1/1     Running            0             28m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         kube-controller-manager-k8s1       1/1     Running            0             28m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         kube-scheduler-k8s1                1/1     Running            0             28m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         log-gatherer-c8lrh                 1/1     Running            0             20m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         log-gatherer-jbp8c                 1/1     Running            0             20m     <IP_ADDRESS>   k8s3   <none>           <none>
	 kube-system         log-gatherer-n5xvm                 1/1     Running            0             20m     <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system         registry-adder-kmd76               1/1     Running            0             20m     <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system         registry-adder-kp8gq               1/1     Running            0             20m     <IP_ADDRESS>   k8s3   <none>           <none>
	 kube-system         registry-adder-n65ww               1/1     Running            0             20m     <IP_ADDRESS>   k8s1   <none>           <none>

Stderr:

Fetching command output from pods [cilium-dzg68 cilium-lbnmj]
cmd: kubectl exec -n kube-system cilium-dzg68 -c cilium-agent -- cilium service list
Exitcode: 1
Err: exit status 1
Stdout:

Stderr:
 	 error: unable to upgrade connection: container not found ("cilium-agent")

cmd: kubectl exec -n kube-system cilium-dzg68 -c cilium-agent -- cilium endpoint list
Exitcode: 1
Err: exit status 1
Stdout:

Stderr:
 	 error: unable to upgrade connection: container not found ("cilium-agent")

cmd: kubectl exec -n kube-system cilium-lbnmj -c cilium-agent -- cilium service list
Exitcode: 1
Err: exit status 1
Stdout:

Stderr:
 	 error: unable to upgrade connection: container not found ("cilium-agent")

cmd: kubectl exec -n kube-system cilium-lbnmj -c cilium-agent -- cilium endpoint list
Exitcode: 1
Err: exit status 1
Stdout:

Stderr:
 	 error: unable to upgrade connection: container not found ("cilium-agent")

===================== Exiting AfterFailed =====================
01:53:05 STEP: Running AfterEach for block EntireTestsuite

[[ATTACHMENT|4f129568_K8sServicesTest_Checks_N-S_loadbalancing_Tests_with_XDP,_direct_routing,_SNAT_and_Random.zip]]

Resources

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.24-kernel-net-next/394/testReport/junit/Suite-k8s-1/24/K8sServicesTest_Checks_N_S_loadbalancing_Tests_with_XDP__direct_routing__SNAT_and_Random/
ZIP file(s):
4f129568_K8sServicesTest_Checks_N-S_loadbalancing_Tests_with_XDP,_direct_routing,_SNAT_and_Random.zip

Anything else?
Cilium is in CrashLoopBackoff. The following message in the previous logs explains why:
2022-07-30T01:52:48.872078368Z level=fatal msg="Failed to compile XDP program" error="no program bpf_xdp_entry found in eBPF ELF" subsys=datapath-loader

This should be fixed by #20728.


Update releases in github to reflect 0.4.0...

It's kind of a pet peeve of mine, when a gem or npm package is released, but the releases tab on github doens't reflect it!  Makes me think "something has gone wrong".  I frequently check the releases in github to gauge "is this a active viable project" ;-)
My preference is to keep the releases in github up to date.   Failing that, just to remove them so it's clear that the project isn't abandoned just because a older release is listed!
Loving the clean UI of mission control-jobs and how easy it was to integrate!

Oops, sorry! I made this release yesterday a bit late and forgot to update it here in GitHub. It's done now: https://github.com/rails/mission_control-jobs/releases/tag/v0.4.0


Layers should be loaded from visualization_for_presentation at embed

This fixes #11554
Acceptance:

[x] Issue STR.
[x] Afterwards, change layer style. Reload the embed. Style shouldn't change.
[x] Publish. Reload the embed. Style should change.

Like a 🚀


feat: add loom test for the counter

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Use https://github.com/tokio-rs/loom for concurrency test. Maybe can make the correctness more confident. But I'm not so sure how to write the best test.
it requires some code change for previous structure, so may need discuss:

remove workspacke hack in task_stats_alloc crate. Otherwise there will be package conflict if you run RUSTFLAGS="--cfg loom" cargo test --test loom. Have not investigate deeply but simple remove just works.

Refactor &'static AtomicUsize to be NonNull<AtomicUsize>. This is because the AtomicUsize in loom type do not support .as_mut_ptr (described in https://github.com/tokio-rs/loom/issues/298), so we use NonNull as intermediate workaround, that will add some unsafe code in .add() and .sub(). But seems OK.

To test the drop, I have to add a flag var AtomicUsize in .sub() to ensure that the value is dropped. Please provide some suggestions if you have better ideas on how to write test.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)

I think after this we should add daily tests on arm. cc @huangjw806 @sumittal

I think after this we should add daily tests on arm.

Sure, we can add it to our future plans.


Issue binding the text property of a TextBlock with List property and index from Carousel

I have an issue binding the text property of a TextBlock to a list property but with the index from the SelectedIndex of a carousel.
Basically, I am using a Carousel named "carousel" to display images, my ViewModel has the property Images, and I have successfully bound the carousel to the Images list and they display perfectly.
However, I would like to have a TextBlock which shows the name of the file associated to the images. I have a FileNames property in my ViewModel which is a List.
But when I do this:
<TextBlock Name="TxtBlocFilename" Text="{Binding FileNames[#carousel.SelectedIndex]}" HorizontalAlignment="Center"></TextBlock>
nothing appears.
To check, I tried Text="{Binding FileNames[0]}" and Text="{Binding #carousel.SelectedIndex}"
and both work no problem, but when combing the 2 nothing appears.
Basically, I want to bind the text to my property but also using the SelectedIndex from the carousel at the same time to get the corresponding file name.
Could you please tell what I did wrong and how to fix my issue?

Not sure Avalonia support this scenario. Maybe it will be easier to bind to SelectedItem?
#carousel.SelectedItem
Or
<TextBlock Name="TxtBlocFilename" Text="{Binding #carousel.SelectedItem.ImagePath}"></TextBlock>

where ImagePath is property of your object that describes image.


wow, no errors...!

126 R4
Win7 64bit
I installed version 117 for the first time. There were still some imperfections, errors.
I'm currently impressed. Finally everything works as it should, I don't see any errors, problems.
Thank you!

Use Discussions tab if you want to thank, only bug reports and feature requests should be made here!

@slawomirro Great, time to close issue which is not issue.


Added log prefixes

In response to #442
Quirks that might be unfavorable:

Requires importing start-utils in every file
Requires the use of log insteadofecho`
[wrapper] tag is configurable in the start-utils file, but [minecraft] is repeated twice in start-minecraftFinalSetup and has no config.

I had some thought about configuration, but my own opinion is that logger names shouldn't have to be configurable from the user side. I can't see a case where the user would benefit from changing the logger names, as long as they are kept unique.
These changes have really just served as a workaround for personal use, so please, rip them all out if need be :)

@scriptcoded this is tremendous work. And it will be a problem to change it in the feature. I suggest using bash alias to do this job. It will require 2 lines added. What do you think? smth like this:

add global alias for bash for next scrips to use it
echo 'alias echo="echo -e \"\033[0;34m[wrapper]\033[0m $*\""' >> ~/.bashrc
actually use this alias in this script too, because .bashrc will not be executed here anymore.
alias echo="echo -e "\033[0;34m[wrapper]\033[0m $*""
at the beginning of the
start file.

@scriptcoded this is tremendous work. And it will be a problem to change it in the feature. I suggest using bash alias to do this job. It will require 2 lines added. What do you think? smth like this:

add global alias for bash for next scrips to use it
echo 'alias echo="echo -e \"\033[0;34m[wrapper]\033[0m $*\""' >> ~/.bashrc
actually use this alias in this script too, because .bashrc will not be executed here anymore.
alias echo="echo -e \"\033[0;34m[wrapper]\033[0m $*\""
at the beginning of the
start file.

I personally feel very strongly about modifying native functionality. However, I understand that large changes like my proposal might be unwanted. I guess it boils down to personal preference, and after all this is @itzg's project.
@itzg As for escape codes they make parsing the output very cumbersome. Perhaps adding a flag to enable colorized output would be a solution?

@itzg oh, yeah. You are correct, no need to colourize the output. Didn't think about no-tty deploys.
@scriptcoded I would really like to understand what do you mean by

modifying native functionality
I would like to know it from my personal perspective. I don't see any problem with modifying bashrc inside the container. May be my approach is bad? Can you elaborate please? Because for me it is more like configuring the environment rather than changing functionality.

@wlp7s0 I like to be careful changing behaviors that are standard. For example, echo outputs a raw line of text with line break at the end. Let's say that another script uses something like the following:
echo "foo" >> bar.txt

You would expect bar.txt to contain foo, but instead it will contain [init] foo. It might not be a problem in this case. It's a rather small project after all, and @itzg will probably be there checking all PRs, but I still find it to be a bad practice changing behaviors that are taken for granted.

@scriptcoded I see. This is true, but after modifying global alias, this behaviour is expected. Thank you for the explanation.

Yeah, all in all I prefer the log usage even if it did mean a lot of little changes. If you'll tweak the log prefix I'm good to approve and merge this.

@itzg I'll do that. Did we settle on "init"?

“init” works for me

@itzg (couldn't reply to your comment for some reason)
Your suspicion was correct, and the process tree becomes odd:
PID   PPID  COMMAND
    1     0 {start-minecraft} /bin/bash /start-minecraftFinalSetup
   50     1 mc-server-runner --stop-duration 60s java -XX:+UseG1GC -Xms1G -Xmx1G -jar minecraft_server.1.15.2.jar
   51     1 sed s/^/[minecraft] /
   58    50 java -XX:+UseG1GC -Xms1G -Xmx1G -jar minecraft_server.1.15.2.jar

I'm getting the same output as you if I remove the sed.
After having looked up a bit more about signal propagation, I agree that the best place to add it would be in mc-server-runner.
When it comes to timestamp, docker logs -t will show output with timestamps. I guess the benefit from adding timestamps to mc-server-runner would be to have them show in docker run and perhaps to remove the potential delay from actual log to timestamp appending. That's a discussion for another thread though.

Ah, I didn’t know docker logs has that -t option. In that case, would filtering away the “init” lines be good enough to pick out the Minecraft server logs for your purposes?

@itzg Just having [init] would be enough for my own purposes, yes. It might be nice for the sake of the project to have consistent logs though. But I think that for any solution that has to parse the logs, just having that [init] would be plenty good.

I think we're ready for this feature to be merged now. Sorry for making this take so long!

I think we're ready for this feature to be merged now. Sorry for making this take so long!

No problem at all. Thanks for working with me on this one.

The updated image is now on Docker Hub.


[No QA] Create Incremental 'withOnyx' migration CI check

Details
As part of our ongoing transition strategy from withOnyx to useOnyx (discussed in this proposal), we are introducing a new CI check.
When a contributor modifies a file that contains withOnyx usages, this check will be triggered. the CI will fail on your PR, regardless of whether you introduced that usage.
To make things easier for contributors, you are not expected to migrate all withOnyx HOCs across every file modified in a PR. Your objective is to simply decrease the overall usage of withOnyx. This way, you could focus on migrating just one file per PR, which gradually contributes to our overall goal.
Fixed Issues
$ https://github.com/Expensify/App/issues/49102
PROPOSAL: N/A
Tests

Create a file without withOnyx - check is successful
Create a file with withOnyx - check failed
Edit existing file without migrating to useOnyx - check failed
Edit existing file and migrate to useOnyx - check is successful
No modifications, should not even trigger the check - check wasn't triggered
Multiple files with one migration - check successful
Multiple files modified without migrating - Check failed

Offline tests
N/A
QA Steps
N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos
N/A

@blazejkustra Could you put an example of editing multiple files with withOnyx so we can see how is the output?

Think I'm going to close this in favor of https://github.com/Expensify/App/pull/49125, which is a bit simpler and more general-purpose


[Toolkit feature]: Dragging-slider-incremental values are too high for certain settings

Contact Details (Optional)
No response
What is the context of the feature/improvement?
When grabbing and dragging the slider for Intensity and Radius, for lights, the increments to increase/decrease is 325 units, which is way too high IMO. Should be incremented by like 0.5 or even 0.1. This would be especially useful for small light sources who doesn't need to produce high amounts of light.
The same thing happens for Emissive Intensity, and possible in other places as well.
Please describe the feature/improvement?
As described above
What would be your solution? (optional)
...
Version
2024.3.0

displacement value

JIRA Ticket: REMIX-3057


Prevent deletion of polygon vertices if < 3

Currently its possible to create 2-vertice or 1-vertice polygons by deleting vertices with right click.
There should be a way to prevent this.

mhh, at least in edit mode: I agree.
But during initial draw you might need to delete the markers you just created to fix errors or something. What do you think?

Sounds good ;)

will do it this week!


Browser tests

This is WIP-branch to get the project covered by browser tests, not only V8 via node/iojs. It runs tests with zuul which provides simple local browser testing, aswell as cloud testing on multiple browsers with saucelabs.
Running tests locally
$ npm run test-browser-local

Running in the cloud
It requires a saucelabs account and ~/.zuulrc config:
$ npm run test-browser

Issues
Atm only context-test.js and parse-test.js are runned. The biggest test suite render-test.js still needs some creating thinking, as it reads test fixtures and expected output from files in test/_files which doesnt work too well in browsers.
Greatly appreciate any thoughts about this, especially how we'll get render-test.js running in browsers.

Update
Got tests from render-tests.js running aswell. In other words; no more work to be done.
Used mustache.js (ofcourse :confetti_ball:) too render all fixtures from _tests into one single test file which browsers can run. Primarly:
$ node test/create-browser-suite.js
# -> turns test/render-browser-tests.mustache into render-browser-test.js

As render-browser-test.js is a copy of all render tests, it is not commited into repo, but generated by the newly added npm scripts:
$ npm run browser-test
$ npm run browser-test-local

ATM these tests fail on Travis as Travis doesnt set encrypted $ENVs from pull requests for security reasons. Those variables are required by saucelabs too run tests. Although runned from my machine on saucelabs, shows that all 118 tests pass in looots of browsers :dancer:
Any thoughts and feedback?

@janl or @dasilvacontin do one of you have a couple of spare minutes? IMHO its alot better than zero browser tests anyhow... If I dont hear anything within a week, I'll solo merge this.
I have already used this to confirm the reported firefox bug in #442, great success!

Browser tests are not included in npm test as they run for too long, although they are runned automatically on Travis upon commit.

[...]

ATM these tests fail on Travis as Travis doesnt set encrypted $ENVs from pull requests for security reasons. Those variables are required by saucelabs to run tests.

So this will currently break the Travis build?

So this will currently break the Travis build?

Nope, as soon as this code is part of the janl/mustache.js repo, the encrypted $ENVs will be set correctly and tests runned on saucelabs. I just realized I should have created this feature branch in janl/mustache.js so that these encrypted $ENVs would have been set all along .. lesson learned.

Oh, that's awesome!
Could you rebase the PR for a clean merge? Thanks. :)

I've run out of testing minutes, but I think that there was some kind of issue with iOS 8.1, or at least it didn't pass the two/three times I tried running the tests.
However, the solution for browser testing works as expected! :+1:

Thanks for taking the time to check it out. About timeouts on saucelabs,
I've seen them occesionally aswell with iOS. Might be worth reporting to
saucelabs if it persists..
P.S. saucelabs has special accounts for open source projects / users.
Unlimited testing with 3 parallel runs 👍
On søn. 10. mai 2015 at 16.56 David da Silva Contín <
<EMAIL_ADDRESS>wrote:

I've run out of testing minutes, but I think that there was some kind of
issue with iOS 8.1, or at least it didn't pass the two/three times I tried
running the tests.
However, the solution for browser testing works as expected! [image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/janl/mustache.js/pull/443#issuecomment-100652928.

I dig into the $ENVs right away ;)

FYI I have gotten the tests to run and done some tweaking: 1a6396f4b06d00cb844d32a854da2eaaa70c9e24
It takes ages to get Travis to rerun these tonight, so I'll probably have to continue this tomorrow.

Fixed in master with 35df920bd752357c28a9cfe7d4aebbc5230afed3

Awesome! Why the || true in .travis.yml, though?

Old habit of ensuring we're exiting successfully.

But shouldn't it fail if the tests fail?

Absolutely. Looking at the test and command together:
$ test $TRAVIS_NODE_VERSION = '0.12' && npm run test-browser || true

Are we currently running node v0.12 on Travis? Then run the browser tests.
Obviously not v0.12, dont do anything but exit cleanly.

Why only on v0.12?

v0.8 doesnt work well with zuul because of some native addon code which isnt compatible with v0.8
The tests are running in the browser, not node, therefore there is no reason to run the browser tests on node v0.10 also

But what if it runs the tests and the tests fail? That's the case I was trying to point out.

Shouldn't it be something like node_version = 0.12 && npm run browser tests || !node_version = 0.12? (pseudo code-ish)

node_version != 0.12 || npm run browser tests

Ahhhh, I see what you mean. Really liked that last one, thanks :+1: I'll fix it shortly

Cool! :)


Update prod build's baseURL to /unstable

Since we're deploying to https://spec.matrix.org/unstable now. This only updates the baseURL for our buildkite build. The default is still / when doing a local build.

Merging as that's the easiest way to test the change, which should only affect the new spec deployment which isn't public yet anyways.


Fix missing validation when binding memory to buffers with the  shader_device_address usage

Required for #1997.
Adds support for passing the device_address flag when allocating DeviceMemory, which is required when binding memory to a buffer with the shader_device_address usage in the VK_KHR_buffer_device_address extension (and core 1.2 which it was promoted to), but not its predecessor VK_EXT_buffer_device_address. Fixes the bug where UnsafeBuffer::bind_memory wasn't validating if the memory is allocated with the device_address flag, and also fixes the wrong function pointer in BufferAccess::raw_device_address when not using the outdated  VK_EXT_buffer_device_address extension.
Changelog:
### Breaking changes
Changes to buffers:
- When binding memory to a buffer with the `shader_device_address` usage, the memory must now have been allocated with the `MemoryAllocateFlags::device_address` flag set.

### Additions
- Added `MemoryAllocateFlags`.

### Bugs fixed
- Fixed missing validation when binding memory to a buffer with the `shader_device_address` usage.

Alright done.


Bootstrap switch change event not firing when state is changed from 'false' to 'true' dynamically

Each time I try to set value of switch from false to true dynamically it is not going in .bootstrapSwitch().on method. It is working fine on changing switch state from false to true dynamically. Fiddle below-
http://jsfiddle.net/aanurn0j/

I made the change event available.
http://jsfiddle.net/cahoadhm/1/
The 3rd argument is set 'false'.


adding key fails when keyfile doesn't exist

aquatone (0.5.0)
CentOS Linux release 7.4.1708 (Core)

Problems attempting to add an api key
$ aquatone-discover --set-key shodan xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
/usr/local/share/gems/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:44:in `initialize': No such file or directory - /home/cccc/aquatone
/.keys.yml (Errno::ENOENT)
        from /usr/local/share/gems/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:44:in `open'
        from /usr/local/share/gems/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:44:in `write_key_store_file'
        from /usr/local/share/gems/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:17:in `set'
        from /usr/local/share/gems/gems/aquatone-0.5.0/exe/aquatone-discover:63:in `block (2 levels) in <top (required)>'
        from /usr/share/ruby/optparse.rb:1364:in `call'
        from /usr/share/ruby/optparse.rb:1364:in `block in parse_in_order'
        from /usr/share/ruby/optparse.rb:1351:in `catch'
        from /usr/share/ruby/optparse.rb:1351:in `parse_in_order'
        from /usr/share/ruby/optparse.rb:1345:in `order!'
        from /usr/share/ruby/optparse.rb:1437:in `permute!'
        from /usr/share/ruby/optparse.rb:1459:in `parse!'
        from /usr/local/share/gems/gems/aquatone-0.5.0/exe/aquatone-discover:136:in `<top (required)>'
        from /usr/local/bin/aquatone-discover:23:in `load'
        from /usr/local/bin/aquatone-discover:23:in `<main>'

I then
$ mkdir aquatone
$ touch aquatone/.keys.yml

and get a different error
$ aquatone-discover --set-key shodan xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
/usr/local/share/gems/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:67:in `deserialize': undefined method `to_ruby' for false:FalseClass
 (NoMethodError)
        from /usr/local/share/gems/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:37:in `read_key_store_file'
        from /usr/local/share/gems/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:21:in `keys'
        from /usr/local/share/gems/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:15:in `set'
        from /usr/local/share/gems/gems/aquatone-0.5.0/exe/aquatone-discover:63:in `block (2 levels) in <top (required)>'
        from /usr/share/ruby/optparse.rb:1364:in `call'
        from /usr/share/ruby/optparse.rb:1364:in `block in parse_in_order'
        from /usr/share/ruby/optparse.rb:1351:in `catch'
        from /usr/share/ruby/optparse.rb:1351:in `parse_in_order'
        from /usr/share/ruby/optparse.rb:1345:in `order!'
        from /usr/share/ruby/optparse.rb:1437:in `permute!'
        from /usr/share/ruby/optparse.rb:1459:in `parse!'
        from /usr/local/share/gems/gems/aquatone-0.5.0/exe/aquatone-discover:136:in `<top (required)>'
        from /usr/local/bin/aquatone-discover:23:in `load'
        from /usr/local/bin/aquatone-discover:23:in `<main>'

Hey @DannyCork
I just had a similar issue, if you first
git clone https://github.com/michenriksen/aquatone.git
and then do the set key it should work :-)

@PatrikFehrenbach that does not actually solve the issue.
/var/lib/gems/2.3.0/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:67:in `deserialize': undefined method `to_ruby' for false:FalseClass (NoMethodError)
	from /var/lib/gems/2.3.0/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:37:in `read_key_store_file'
	from /var/lib/gems/2.3.0/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:21:in `keys'
	from /var/lib/gems/2.3.0/gems/aquatone-0.5.0/lib/aquatone/key_store.rb:15:in `set'
	from /var/lib/gems/2.3.0/gems/aquatone-0.5.0/exe/aquatone-discover:63:in `block (2 levels) in <top (required)>'
	from /usr/lib/ruby/2.3.0/optparse.rb:1547:in `block in parse_in_order'
	from /usr/lib/ruby/2.3.0/optparse.rb:1534:in `catch'
	from /usr/lib/ruby/2.3.0/optparse.rb:1534:in `parse_in_order'
	from /usr/lib/ruby/2.3.0/optparse.rb:1528:in `order!'
	from /usr/lib/ruby/2.3.0/optparse.rb:1620:in `permute!'
	from /usr/lib/ruby/2.3.0/optparse.rb:1642:in `parse!'
	from /var/lib/gems/2.3.0/gems/aquatone-0.5.0/exe/aquatone-discover:136:in `<top (required)>'
	from /usr/local/bin/aquatone-discover:22:in `load'
	from /usr/local/bin/aquatone-discover:22:in `<main>'

It might be a ruby env problem as far the error message says something about 2.3.0 version while the Kali does have 2.3.2? I'm not a ruby dude anyway.


DB Connection Pool Exhaustion

I'm facing a problem with an Asp.Net Core app where database connections get exhausted  the application crashes with this exception:
System.InvalidOperationException: Timeout expired.  The timeout period elapsed prior to obtaining a connection from the pool.  This may have occurred because all pooled connections were in use and max pool size was reached.
The action method in question is as below:
       [HttpPost]
        public async void Post(DeviceState state)
        {
            using (var connection =  new SqlConnection("Data Source=localhost;Integrated Security=True");) // Using the default max pool size of 100
            {
                await connection.OpenAsync();
                (var command = new SqlCommand($INSERT INTO test_db.dbo.DeviceState (fqdn, content_name, bytes_from_peer, bytes_from_source, total_size) VALUES(@fqdn, @content_name, @bytes_a, @bytes_b, @total_size)",
                    connection))
                {
                    AddParameter(command, "@fqdn", SqlDbType.VarChar, state.Fqdn + Guid.NewGuid());
                    AddParameter(command, "@content_name", SqlDbType.VarChar, state.ContentName);
                    AddParameter(command, "@bytes_a", SqlDbType.BigInt, state.BytesA);
                    AddParameter(command, "@bytes_b", SqlDbType.BigInt, state.BytesB);
                    AddParameter(command, "@total_size", SqlDbType.BigInt, state.TotalSize);

                    await command.ExecuteNonQueryAsync();
                }
            }
        }

And this is the AddParamter() helper method:
 private static void AddParameter(SqlCommand command, string name, SqlDbType type, object value)
        {
            var param = command.CreateParameter();
            param.ParameterName = name;
            param.SqlDbType = type;
            param.Value = value;
            command.Parameters.Add(param);
        }

What the Post() method is doing is INSERTing a row into a table called DeviceState every time it is called. DeviceState table was created with the below T-SQL snippet:
  create table [cdc_test_db].[dbo].[DeviceState](
   fqdn varchar(255) primary key not null,
   content_name varchar(500) not null,
   bytes_a bigint,
   bytes_b bigint,
   total_size bigint
)

I'm using the default max pool size of 100. I'm seeing these exceptions at 20000 requests/s. But interestingly enough I see that the app starts to use all 100 connections even at very low request rates like 1000 requests/s. This is different from the behaviour of classic Asp.Net (4.8) which never goes beyond 10 connections even while delivering 4000-5000 requests/s. Is Asp.Net Core designed to be aggressive when opening DB connections?
I've also observed this problem occurs only when my action method is async and uses  async versions of all data APIs. When I switch everything to synchronous code, the problem goes away. So I wonder if this is something caused by async tasks holding onto the DB connections for too long while waiting to be scheduled on the thread pool. What am I doing wrong?
Or is it just a manifestation of this issue: https://github.com/dotnet/SqlClient/issues/18, which from what I know should've been fixed in the Microsoft.Data.SqlClient version I'm using (1.0.19269.1). I've also tested with the latest version of Microsoft.Data.SqlClient, 1.1.0, and saw the same issue.
Details:

Asp.Net Core version: 3.1
OS: Windows Server 2016
Database: SQL Server 2016 Standard Edition
Microsoft.Data.SqlClient version: 1.0.19269.1

Originally reported this issue under AspNetCore (https://github.com/aspnet/AspNetCore/issues/18089), but they suggested I should move it here.

Also tested using the same code with Asp.Net Core 2.1 and System.Data.SqlClient 4.8.0 (note System instead of Microsoft).  Ran into the same issue :(.
In the Asp.net Core 2.1 project, also tested by increasing Max Pool Size to 5000. This time it didn't crash (because it didn't breach the limit), but the no. of connections did grow up to ~1900 and was still growing (at about 1 connection/s) when I ended the test. It was delivering a request rate of ~35000/s at that time.

Apologies. This was due to my mistake not an issue in SqlClient. My Post() action method was returning void. It should've returned Task instead.
Returning void from an async action method causes Asp.Net Core to immediately return 200 OK to client before waiting for the async method to finish -- apparently it can't await because there's no Task to await on. This can cause clients to come back with the next request (especially if the client is an HTTP load generator) right away. Pretty soon the system is jammed with unfinished requests causing among other things DB connections to grow quickly.


pip install downgrades Django!

$ pip install django-leaflet-storage
Collecting Django==1.6.5 (from django-leaflet-storage)
  Using cached Django-1.6.5-py2.py3-none-any.whl
Installing collected packages: Django
  Found existing installation: Django 1.9.2
    Uninstalling Django-1.9.2:

Even if your app is incompatible with newer Django versions - it should never do this. In fact - surely Django itself should not be in requirements.txt for an app that plugs into Django?

I also noticed psycopg2 is in the reqs: https://github.com/umap-project/django-leaflet-storage/blob/master/requirements.txt

Watch out, by mistake you typed an exclamation mark at the end of the title of the issue ;)

Fixed  :)

:)
So now you can just pip install again the Django version you want, and you're done :)
About the hard linking to specific Django version, humm, I'm balanced. If we have it open bar, we will end at some point with people installing an incompatible Django version. But its true that having this old version hard linked is not OK ;)
Maybe the best option is not to have Django in the requirements, but mentioning it in the install doc and letting users install what fit their needs?
About psycopg, yeah, let's remove it.

Maybe the best option is not to have Django in the requirements, but mentioning it in the install doc and letting users install what fit their needs?

Yep - IMHO it should be a documentation thing, not an automated thing. Was rather confusing when ./manage.py migrate told me 'migrate' was an unknown command!

Looking at requirements.txt - if we remove Django and Psycopg that only leaves Pillow. And from a quick glance - I can't see any PIL imports in the code?


When pods have multiple containers, all containers are put the same pool, even if there is only a route pointing to one of them

ISSUE
In the following setup where this issue was discovered, we have this pod (part of RHMAP-Core, but would be the same for any pod with more than one container):
$ oc get pods
...
gitlab-shell-1-pkcbx   2/2       Running   1          2d
...
It has this endpoint object:
$ oc describe ep gitlab-shell
Name:		gitlab-shell
Namespace:	rhmap-core
Labels:		name=gitlab-shell
Annotations:
Subsets:
Addresses:		<IP_ADDRESS>
NotReadyAddresses:
Ports:
Name		Port	Protocol
----		----	--------
server-http-port	8000	TCP
internal-ssh-port	2022	TCP
Events:
And this route:
$ oc describe route git
Name:			git
Namespace:		rhmap-core
Created:		2 days ago
Labels:			app=gitlab-shell
Annotations:		openshift.io/generated-by=OpenShiftNewApp
openshift.io/host.generated=true
Requested Host:		git-rhmap-core.apps.example.com
exposed on router router 2 days ago
Path:
TLS Termination:	edge
Insecure Policy:	Allow
Endpoint Port:		server-http-port
Service:	gitlab-shell
Weight:		100 (100%)
Endpoints:	<IP_ADDRESS>:8000, <IP_ADDRESS>:2022
Notice that the route specifies "Endpoint Port: server-http-port" which is <IP_ADDRESS>:8000.
But the router plugin creates a pool in the Big-IP LTM, that contains both endpoints (<IP_ADDRESS>:8000 & <IP_ADDRESS>:2022) and one policy rule for the route pointing to that pool.
This results in that 50% of the request to the route will be forwarded to port 8000 and 50% to 2022 on a round-robin basis, which will break usage.
SUGGESTED SOLUTION
Fix so that the plugin creates different pools for different endpoint ports (in this case, one containing <IP_ADDRESS>:8000 and one containing <IP_ADDRESS>:2022). Then, depending on the "Endpoint Port" value in the router, forward traffic to the correct pool.

Fixed in 9a375a18e3eb72ad80bfa71a756040a1bd772d86


Link.rename() should set errno to ENOENT if link doesn't exist

e.g. https://github.com/dart-lang/sdk/blob/master/runtime/bin/file_macos.cc#L314
If the type of the entity is a file or not found, right now, the errno always gets set to EINVAL, but it really seems like it should be ENOENT if there's no entity, and only EINVAL if there is a file entity at the specified path.

@zanderso


Aliases in cjs files of dependency not getting mapped, causing jest tests of apps importing dependency to fail

I am not sure if this is a bug, something I overlooked in the documentation or an incorrect tsconfig configuration, but the situation is this.  We have a typescript based project that consumes, via npm, a library of common components that we also maintain.  We added resolve-tspaths to the component library.  The projects that import the component library as a dependency recognize the aliases and run fine, but every jest test that involves an aliased component from the component library fails with an error like this:

Cannot find module 'hooks' from<EMAIL_ADDRESS>
ts-config for component library is this:

package.json scripts used to build component library is this:

I assumed the problem was the build:cjs script so I tried this but got "changed 0 files"

To sum up, and restate the problem, the tests of the projects that use our aliased component library as a dependency are failing, and they are failing because the aliases in the component library are not getting mapped in the cjs files.  My feeling is this is probably a configuration issue and not a bug, but any assistance you could provide would be greatly appreciated.

Turns out I needed to spend more time reading your README file.  && resolve-tspaths --out lib/cjs worked.


Some comands and libreries not exist in the recient versions

Some components doesn't exist and it's necesary to change:
withRouter for Navigate
Switch for Routes
Redirect  for Navigate
The problems show are the next:
Compiled with problems:X
ERROR in ./src/auth/SignIn.js 246:20-30
export 'withRouter' (imported as 'withRouter') was not found in 'react-router-dom' (possible exports: BrowserRouter, HashRouter, Link, MemoryRouter, NavLink, Navigate, NavigationType, Outlet, Route, Router, Routes, UNSAFE_LocationContext, UNSAFE_NavigationContext, UNSAFE_RouteContext, createPath, createRoutesFromChildren, createSearchParams, generatePath, matchPath, matchRoutes, parsePath, renderMatches, resolvePath, unstable_HistoryRouter, useHref, useInRouterContext, useLinkClickHandler, useLocation, useMatch, useNavigate, useNavigationType, useOutlet, useOutletContext, useParams, useResolvedPath, useRoutes, useSearchParams)
ERROR in ./src/auth/SignUp.js 282:20-30
export 'withRouter' (imported as 'withRouter') was not found in 'react-router-dom' (possible exports: BrowserRouter, HashRouter, Link, MemoryRouter, NavLink, Navigate, NavigationType, Outlet, Route, Router, Routes, UNSAFE_LocationContext, UNSAFE_NavigationContext, UNSAFE_RouteContext, createPath, createRoutesFromChildren, createSearchParams, generatePath, matchPath, matchRoutes, parsePath, renderMatches, resolvePath, unstable_HistoryRouter, useHref, useInRouterContext, useLinkClickHandler, useLocation, useMatch, useNavigate, useNavigationType, useOutlet, useOutletContext, useParams, useResolvedPath, useRoutes, useSearchParams)
ERROR in ./src/index.js 40:36-44
export 'Redirect' (imported as 'Redirect') was not found in 'react-router-dom' (possible exports: BrowserRouter, HashRouter, Link, MemoryRouter, NavLink, Navigate, NavigationType, Outlet, Route, Router, Routes, UNSAFE_LocationContext, UNSAFE_NavigationContext, UNSAFE_RouteContext, createPath, createRoutesFromChildren, createSearchParams, generatePath, matchPath, matchRoutes, parsePath, renderMatches, resolvePath, unstable_HistoryRouter, useHref, useInRouterContext, useLinkClickHandler, useLocation, useMatch, useNavigate, useNavigationType, useOutlet, useOutletContext, useParams, useResolvedPath, useRoutes, useSearchParams)
ERROR in ./src/index.js 59:37-43
export 'Switch' (imported as 'Switch') was not found in 'react-router-dom' (possible exports: BrowserRouter, HashRouter, Link, MemoryRouter, NavLink, Navigate, NavigationType, Outlet, Route, Router, Routes, UNSAFE_LocationContext, UNSAFE_NavigationContext, UNSAFE_RouteContext, createPath, createRoutesFromChildren, createSearchParams, generatePath, matchPath, matchRoutes, parsePath, renderMatches, resolvePath, unstable_HistoryRouter, useHref, useInRouterContext, useLinkClickHandler, useLocation, useMatch, useNavigate, useNavigationType, useOutlet, useOutletContext, useParams, useResolvedPath, useRoutes, useSearchParams)

Thanks. That helps


Module compiled with Swift 5.1.3 cannot be imported by the Swift 5.2 compiler

What did you do?
Try to build project.
What did you expect to happen?
Build succeed
What actually happened instead?
Error on SwiftyJSON import
Module compiled with Swift 5.1.3 cannot be imported by the Swift 5.2 compiler:
Environment
List the software versions you're using:

SwiftyJSON: 5.0.0
Xcode Version: 11.4
Swift Version: Xcode Default

Please also mention which package manager you used and its version. Delete the
other package managers in this list:

Cocoapods: 1.8.4

A solution might be to set BUILD_LIBRARY_FOR_DISTRIBUTION to yes.
https://stackoverflow.com/questions/58654714/module-compiled-with-swift-5-1-cannot-be-imported-by-the-swift-5-1-2-compiler

You might be able to work around this by removing your carthage build directory and rerunning carthage build so SwiftyJSON builds with the new toolchain, assuming your xcode-select is pointing at Xcode 11.4.
In my case I was trying to build Firefox for iOS, but it uses the bootstrap option --cache-builds so maybe that kept the frameworks I built with Xcode 11.3.1 around after I upgraded to Xcode 11.4.

@kajz3reczka did you ever get this working?

Same question. And I use XCode11.5
Module compiled with Swift 5.1 cannot be imported by the Swift 5.2.4 compiler


Refactor Drawer component and remove framer-motion dependency

Closes #1654
What does this change?
This commit replaces the framer-motion dependency with a custom CSS transition.
To keep the implementation simple, the visibility property is being toggled instead of display, as it still removes the element from the accessibility tree but has the benefit of being animatable. As the element has a fixed position, it should not have significantly worse performance.
(an aside: abandon hope all ye who  try to make it work with display again ☠ this led me down a path of deeper and deeper problems, e.g. with elements being unable to start transitions while hidden, which needed more and more stateful React thrown against the wall to even come close to fixing)
How was this tested?
I've only tested this locally so far; I'll leave this as a draft PR until I see if I can do something more robust :)
Accessibility
If applicable to your changes, have you:

[ ] Tested with screen reader
[ ] Checked to see if navigable by keyboard
[ ] Ensured that the colour contrast is passing

Documentation
If applicable to your changes, have you:

[ ] Added/edited the appropriate documentation
[ ] Added any component(s) to Storybook

(creating as a draft PR to track progress, will undraft as I address the testing, accessibility, and documentation checklists above, where appropriate)

thanks so much for this @Hoolean it'll be great to remove more deps over time as we simplify the client 👏


Filter nowarn annotation from jar

Alternative to #4067.  We just simply filter the @nowarn annotation out of the jar.
Pros:

No new core dependencies
Preserves fatal warnings without further complexity

Cons:

Compat trait will need to be copied to a scala-3 directory on the Dotty branch.
Doesn't steer our source toward modernity.
MiMa doesn't catch that the annotations are missing. But we'll note it and move on, and it's 2.12 only.

I'm leaning toward this being the better approach, and conservatively putting it on main instead of 0.21.


Just writing alone takes around 40s in separate tests, so the reading from file and processing doesn't add any time.

Codecov Report
Attention: Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.41%. Comparing base (a62a7a9) to head (d69e53b).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

internal/processors/filter_by_type.go
0.00%
3 Missing :warning:

internal/processors/filter_by_bin.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   82.22%   82.41%   +0.18%
==========================================
  Files          65       67       +2
  Lines        3730     3747      +17
==========================================
+ Hits         3067     3088      +21
+ Misses        428      424       -4
  Partials      235      235

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How did you warm up identity encoder??

Thanks you for providing your great work.
I read your code and there seems to be no code stage=1, warming up identity encoder.
It saids in the paper that
"We firstly use a state-of-the-art unsupervised Re - ID method to warm up Eid, which is then
considered as a baseline in our ablation studies" which you used JTCV? method to warm up identity encoder."
I figured out when input image x is fed into identity-encoder(Eid), it outputs feature vector fid(2048x4x1 feature after part average pooling in ft_net in the code).  But how did you train the encoder(Eid)?? Did you use just apply your ft_net
in the JTCV, or MLC code and train it??
For example, below is the framework of MLC paper.

In the above image,  the CNN layer is your ft_net and you trained the whole network so the weights in the CNN(ft_net) could be  warmed up?

Is this right??

Our encoder has two branches after CNN layers: one branch outputs 2048x4x1 for generative part with part average pooling, the other one outputs 2048x1x1 for ReID training with normal average pooling. The second one is used for warm up.
We just run the source code (JVTC or MLC) and saved their weights as Stage 1. In stage 2, we load the saved weights into our ft_net.

Thank you.
One more question.
Do you have the code for getting the Fid and SSIM scores in your paper??

It will be great if you can provide this also for checking Generator's ability.

To get FID and SSIM, first generate images with our examples/generate_data.py. Then, use following project code
FID: https://github.com/layumi/TTUR
SSIM: https://github.com/layumi/PerceptualSimilarity


Merge fragment builder into data builder

@klavs I've successfully merged fragment builder into data builder, and it is working correctly in both the flutter example and my own project.


Fix run entire plan

Hi,
#192 introduced a small bug that does not let to run the entire map only by typing run. This PR fixes it.
Best
Signed-off-by: Francisco Martín Rico<EMAIL_ADDRESS>

Failing for reasons not related to this PR. Mixing as this is a simple fix.


Add ability to get handler class name through _HANDLER environment variable …

… like on real "AWS Lambda" or "Lambci" platform

Looks great, thanks @serkan-ozal . 👍 Can you please also bump the version in pom.xml, so we can release this to Maven Central right away? Thanks!

Sure. Done :+1:


rviz: 1.14.19-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository rviz to 1.14.19-1:

upstream repository: https://github.com/ros-visualization/rviz.git
release repository: https://github.com/ros-gbp/rviz-release.git
distro file: noetic/distribution.yaml
bloom version: 0.11.2
previous version for package: 1.14.16-1

rviz
* Fixup to #1760 <https://github.com/ros-visualization/rviz/issues/1760>, SplitterHandle (#1766 <https://github.com/ros-visualization/rviz/issues/1766>)
* Contributors: Robert Haschke

@methylDragon, this now also includes a license file.


nit fixs for test network k8s

busybox latest image tag
making pod image point to local reg
pull images and push images to local reg
make network down able to re run

Signed-off-by: Sam Yuan<EMAIL_ADDRESS>

@jkneubuh , I got some time today and tried with localhost:5000 registry.
I had update the PR, please take a look at.

I am curious that if someone build image as
docker build -t localhost:5000/someimage:latest

will the k8s pod auto upgrade?
or...
we still need
docker build -t localhost:5000/someimage:latest
kind load docker-image -n kind localhost:5000/someimage

@SamYuan1990 very minor couple of comments on the latest changes.
@jkneubuh all happy?

/azp run

@mbwhite / @jkneubuh  please help rerun failed ci cases.

@SamYuan1990 @jkneubuh ... just running this now - spotted that if I wanted to use the local docker images I've rebuilt, then the docker pull fails.... I need to comment out these parts.
Do you think that running with a local docker image.. is sufficiently 'advanced' that this isn't needed?

May I know the details？
I suppose if you want to use your local image to as refresh into the kind.
It may need to
Docker push localhost:5000/your_image
Kind load localhost:5000/your_image
For my understanding, if the kind based auto trigger a refresh with image update?
@mbwhite

@SamYuan1990 @jkneubuh ... just running this now - spotted that if I wanted to use the local docker images I've rebuilt, then the docker pull fails.... I need to comment out these parts.
Do you think that running with a local docker image.. is sufficiently 'advanced' that this is ok.

btw, https://github.com/hyperledger/fabric-samples/pull/519#issuecomment-955282412

@SamYuan1990 @jkneubuh ... just running this now - spotted that if I wanted to use the local docker images I've rebuilt, then the docker pull fails.... I need to comment out these parts.
Do you think that running with a local docker image.. is sufficiently 'advanced' that this is ok.

or maybe as a balance?
we have a file mapping local image and local repo
for ex
fabric-ca:tag localhost:5000:fabric-ca:latest

docker pull fabric-ca:tag
docker tag fabric-ca:tag  localhost:5000:fabric-ca:latest
docker push localhost:5000:fabric-ca:latest

but the default value for the file(images) will as
${FABRIC_CONTAINER_REGISTRY}/fabric-ca:$FABRIC_CA_VERSION localhost:5000:fabric-ca:$FABRIC_CA_VERSION
@jkneubuh , @mbwhite  may I know what do you think of this?

@SamYuan1990 to recap my scenario I'd built a version of the peer docker image locally I wanted to use in the KIND cluster.
The docker pull will alway try and pull the image down whereas here I wanted it to use the local copy....
I think looking at this again today - what we've got is fine. very few people are going to want to run this with locally rebuilt docker images...just contributors - and they (hopefully?) know what they are doing...
Let's leave everything as is... thanks for the contribution and discussion though @SamYuan1990

Hi @SamYuan1990 and @mbwhite
I agree and this PR is OK in the current form.  I may want to make a couple of changes to streamline the usage for Fabric development.  The problem with using the KIND image plane is that the imagePullPolicy: Always will always check the repository URL to see if a different image should be loaded, overriding the local images pushed to the cluster.  On the other hand, setting imagePullPolicy: IfNotPresent allows the user to load into the KIND image plane, but requires the user to ensure everything has been loaded into the cluster, which is really inconvenient.  I understand that the "easy path" of loading everything from the public repositories is not actually "easy" for everyone, especially when there are problems accessing the network.
What I would propose as an addition, for a future PR, is to include an additional action for the /network script that will run the docker pull, tag, and push to the localhost:5000 registry.  For users with poor network connectivity, the command can be run prior to initializing the network to stage all the images locally.  The scenario would look something like:
export TEST_NETWORK_REPO=localhost:5000/hyperledger

./network load-images

./network up

Matthew this I think could actually make it a little easier for the local Fabric development pipeline.  We could break up the load-images into two phases such that it can tag/push all of the outputs from a make docker without overwriting local edits with images from the Internet.

BTW pushing a set of images up to a container registry can be very helpful for testing local edits to Fabric binaries, but on a remote cluster / target.   For instance, I had to upload some images to de.icr.io to run some remote testing on an IKS cluster.  This command would have helped in that circumstance.

@jkneubuh very happy with that plan..

Hi Sam and Matthew.
I apologize for the confusion, but I'd like to back out all of these changes.  I tried working with the new environment today to work with some custom Fabric images, and it caused more problems than solutions.  Working with the localhost:5000 registry is a good fit for chaincode, gateway applications, and local apps being developed that work with fabric.  But it's not a good fit for the core fabric images.
Let's try to come up with another workaround that will get Sam going, as well:

Revert the image pull policy to "IfNotPresent"
Point all of the images to ${FABRIC_CONTAINER_REGISTRY}/fabric-peer:${FABRIC_VERSION}
Add a new function load_docker_images that will PULL the images and run kind load docker-image ...
Run load_docker_images from network kind  if TEST_NETWORK_STAGE_IMAGES=true

Here are some use cases:
a)  Sam gets timeouts when reading from docker hub, causing deployments to fail in KIND:  use the kind image plane.
export TEST_NETWORK_STAGE_IMAGES=true

./network kind     # << will run docker pull && kind load docker-image ...
./network up

b)  Matthew wants to build a LOCAL fabric peer binary for testing:   use the kind image plane.
./network kind

make docker
kind load docker-image hyperledger/fabric-peer:2.4.0

export TEST_NETWORK_FABRIC_VERSION=2.4.0
./network up

c)  Josh wants to run the nightly / latest builds locally for testing:  read images from ghcr.io:
./network kind

export TEST_NETWORK_FABRIC_CONTAINER_REGISTRY=ghcr.io
export TEST_NETWORK_VERSION=amd64-2.4.0-snapshot-a956e72a6

./network up


[cross compile] about App shown in macos &windows

macbook pro 2019 , macos 10.15.4,
i'm sure: the latest version of hover : Hover v0.42.0 ;
golang 1.13,  GO111MODULE=on;
Hover doctor
$ hover doctor
hover: Hover version v0.42.0 running on darwin
hover: Sharing flutter version
Flutter 1.18.0-11.1.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 2738a1148b (4 weeks ago) • 2020-05-13 15:24:36 -0700
Engine • revision ef9215ceb2
Tools • Dart 2.9.0 (build 2.9.0-8.2.beta)
hover: Flutter engine commit: https://github.com/flutter/engine/commit/ef9215ceb2884ddf520d321bcd822d1461330876
hover: Finding out the C compiler version
Apple clang version 11.0.3 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
hover: Sharing the content of go.mod
module tuanzianimation/go

go 1.13

require (
	github.com/go-flutter-desktop/go-flutter v0.41.1
	github.com/pkg/errors v0.9.1
)
hover: Sharing the content of hover.yaml
application-name: ""
executable-name: ""
package-name: ""
license: ""
target: lib/main_desktop.dart
branch: ""
cache-path: ""
opengl: ""
engine-version: ""
hover: Sharing the content of go/cmd
go/cmd/main.go	go/cmd/options.go
[...]

Error output
[✓] Flutter (Channel beta, 1.18.0-11.1.pre, on Mac OS X 10.15.4 19E287, locale en-CN)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google
    Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[!] Android Studio (not installed)
[✓] VS Code (version 1.45.1)
[✓] Connected device (1 available)

You might want to try a actual Windows instead of VM Windows, and see If It's still an issue.
Notice: Not sure If this is your problem, and I'm not a mac users, just remember VM will not work in some circumstance.

@Tokenyet, Yes I'm pretty sure this issue comes from the virtualization.
Refs:
https://github.com/go-flutter-desktop/go-flutter/issues/352
https://github.com/go-flutter-desktop/go-flutter/issues/337
https://github.com/go-flutter-desktop/go-flutter/issues/248
https://github.com/go-flutter-desktop/go-flutter/issues/272

@ariagecheney the solution seems to be to add --opengl=none as @raymeibergen found out. Can you try that?

--opengl=none fixes most of virtualization issue.


Add db events to orbitdb instance

Add an 'open' event, fired when a store has completed opening.
Useful in situations where it could take an extended period of time for a store to open and instead of awaiting OrbitDB.open() an event listener can be used.
Likewise it would be useful to be notified of 'ready' events without having first subscribed to a particular db intance. May as well go the whole hog and implement all the events emitted by dbs.

Replaced by #793


Relative times show as e.g. "-10 d" in unsupported languages

If the language is not supported (like Esperanto), relative dates show like "-10 d". More reasonable would be to fall back to English.

If you'd like to try the new release I believe this issue is likely fixed. If not let me know and we can revisit it.

This is not fixed in the new release, still showing things like -10 d for Esperanto.

Are you using the micro format?

No, just <relative-time prefix="">.

Would you kindly present a full reproduction? Are you using the lang attribute to render a page in the Esperanto locale? I'm unsure why it would render -10 d if you're not specifying the micro format, unless that is particular to the browsers Esperanto locale, or perhaps it's an unrecognised locale and is doing something undesirable?

Live example at https://greasyfork.org/eo/scripts/370634?locale_override=1 - the date is next to text Ĝisdatigita. HTML is:
<relative-time datetime="2022-11-01T03:31:12+00:00" prefix="">2022/11/01</relative-time>

JS is:
import '@github/time-elements';

Page has:
<html lang="eo">

Result is (currently) -6 d.

It looks like this is perhaps an error in the browser's implementation or perhaps poor ICU data?
It looks like the resolvedOptions are correctly returning eo so this is how the browser is deciding to interpret that relative time. I think this might be worth raising with browser vendors like the Safari tracker. There's little we can do (because providing a fallback won't work as the browser is successfully resolving this locale).

OK, understood this may be a browser issue. I leave it up to you whether to raise it with them as I'm not familiar with the technical details. Thanks for checking.