utils::{TopicPartitionOffset, PartitionOffset} have Result fields

Currently, the utils::{TopicPartitionOffset, PartitionOffset} structs' offset fields are Results. In my opinion, it's kind of strange to have a struct with a Result in the middle of it for anything but maybe custom Error types. It can make error handling on the user-side really inconvenient.
Additionally, it's not entirely clear to me why TopicPartitionOffset is needed at all—it seems that it exists only to flatten responses, which leads to lots of inefficient cloning of data that it already had. I think in an instance like the linked one, it would be more appropriate to return a map which maps topics to PartitionOffsets; that way, only a move of one string is necessary, rather than a clone for every single offset response.
What do you think? I tried to start by changing the Results to just their underlying type, but I can see it's a non-trivial refactor, so I thought I'd get your input first.

Many thanks for the investigation!

I agree that the existence of TopicPartitionOffset is sub-optimal. In particular for KafkaClient::fetch_group_topic_offsets and KafkaClient::fetch_group_offsets a return value of Map<String, Vec<PartitionOffset>> as you implied would be desirable. This will definitely avoid the needless cloning and help clients in processing the response more easily. Feel free to go ahead.
For KafkaClient::produce_message, which also returns TopicPartitionOffsets, the situation is a bit unclear. As you can see from the TODO in the code the return value should be changed anyway especially in regards to partitions which failed to acknowledge the data. Feel free to change it to a Map<String, Vec<PartitionOffset>> as well (me idea about the TODO is to return a PartitionOffsetOrDataFailedToBeDelivered in some future.)
Regarding the Result within the structs. Well, the idea is to not access the offsets value (i64) in the struct if kafka reported an error for the partition. This means the error can be only of type kafka::error::KafkaCode. I'm fine with changing it to Result<i64, KafkaCode> (i guess this will even reduce the size of the struct). The introduction of the Result in the two mentioned structs came after mistakenly ignoring the error in an earlier version of kafka-rust in the consumer. So I'm rather voting for keeping it.

I agree that the existence of TopicPartitionOffset is sub-optimal. In particular for KafkaClient::fetch_group_topic_offsets and KafkaClient::fetch_group_offsets a return value of Map<String, Vec<PartitionOffset>> as you implied would be desirable. This will definitely avoid the needless cloning and help clients in processing the response more easily. Feel free to go ahead.

Cool, sounds good.
For the last two bullet points, yeah, it's not immediately clear how to handle the return value there. However, I think at least part of the confusion (at least for me) is that the Kafka broker's ProduceResponse contains both the offset and the error code, if any, so it doesn't really make sense to wrap the offset in a Result there anyway, since either way, the acknowledgement message will contain some offset.
For fetching group offsets, I think it makes sense to have them in a Result because either the offset exists, or returns -1, or some error happened. I think there are two ways to handle the errors when fetching offsets:

Wrap all partition/offset data into one top-level Result, with all offset data available if there were no errors. This is currently what fetching does, so if the top-level Result returned by __fetch_group_offsets is Ok, then so will all the offset fields, so having to unwrap them is just unnecessary pain.
Handle partition errors individually (probably the more robust choice). In this case, knowing which partition failed to fetch its offsets is useful, so I think it does make sense to either store the partition data with its Result for the offset, which is what it's doing now, or just return a top-level Result that contains either the partition and offset together, or an Err that describes which partition it failed to fetch. (This way would also have the added benefit of being able to use PartitionOffset on the producer side as well.) Either way works, but in my opinion, while the latter is more of a pain to implement on the lib side, I think it makes error handling easier for the user-side. However, I defer to your judgment, since this is your lib :)

But right now, the current state of the lib is kind of inconsistent. It has a struct that contains a Result field as if to handle individual partition errors, but then doesn't really make use of it. I think if we're just going to quit on the first partition error, then having the Result field is just unnecessary. But handling partition errors individually may allow for more robust error handling, and allow the user to use the portion of the offsets that were fetched successfully. What do you think is the best way forward?

Also, just wanted to let you know that I don't often get free time to work on for-fun projects, so I can't promise I'll be able to move forward with this issue in a timely manner, unfortunately :/

For the last two bullet points, yeah, it's not immediately clear how to handle the return value there. However, I think at least part of the confusion (at least for me) is that the Kafka broker's ProduceResponse contains both the offset and the error code, if any, so it doesn't really make sense to wrap the offset in a Result there anyway, since either way, the acknowledgement message will contain some offset.

i agree, it does make sense (especially if it's going to be Result<i64, KafkaCode>.) if i remember correctly, i didn't rework this due to the protocol structs being crate private and i didn't have to change the wire format parsing code. feel free to change this; but be sure to not skip reading any bytes from the parsed binary stream (i.e. always read the 2 byte error code and always read the 4 byte offset, no matter what the error code says.) on the other hand, i'm fine with having the protocol module be "raw" and just a convenient thin layer above the binary raw wire format.

For the last two bullet points, yeah, it's not immediately clear how to handle the return value there. However, I think at least part of the confusion (at least for me) is that the Kafka broker's ProduceResponse contains both the offset and the error code, if any, so it doesn't really make sense to wrap the offset in a Result there anyway, since either way, the acknowledgement message will contain some offset.

i agree, it does make sense (especially if it's going to be Result<i64, KafkaCode>.) if i remember correctly, i didn't rework this due to the protocol structs being crate private and i didn't have to change the wire format parsing code. feel free to change this; but be sure to not skip reading any bytes from the parsed binary stream (i.e. always read the 2 byte error code and always read the 4 byte offset, no matter what the error code says.) on the other hand, i'm fine with having the protocol module be "raw" and just a convenient thin layer above the binary raw wire format.
regarding fetching group offsets in KafkaClient i'm inclided to say that it's not entirely correct to fail the whole method call if there's an error for one partition partition - this seems like a bug to me! KafkaClient::fetch_group_offsts is supposed to be a mid-level abstraction layer. It has to provide enough details for clients such that they can make their decision (e.g. here) how to go about particular errors. on the other hand KafkaClient is supposed to deal transparently with certain error types, but not all of them. therefore i'd say it has to return either an "error or the offset" for a topic-partition in order to allow clients making up their own mind about how to deal with the facts. making the whole "fetch group offsets" method call fail due to an offset-error for only one partition, would push clients to make multiple calls to "fetch group offsets" for each partition separately. this is clearly inefficient as it result in a lot of overhead instead of one method call with all of the interested partitions specified.
regarding the inconsistency you are observing: this might be due to the fact that kafka-rust is layered:

the protocol structs are - for the most part - not exposed to the public api and deal with encoding/decoding concerns - you can regard them as an implementation detail.
KafkaClient is a mid-level abstraction which tries to bring some more safety than the "protocol" layer; hence, the Result in certain structs exposed by KafkaClient or the dealing with "some" errors (i will have to investigate the error handling code you pointed out).
Producer and Consumer on the other hand are supposed to be a high-level api; there should be not implementation details exposed. each layer has a different responsibility and therefore is different (or inconsistent with another layer.)

Ahh, ok, I understand. Ok, then for this ticket, I'll go ahead and plan to:

Change the fetch methods to return a map
Change the offset field in these two structs to a Result<i64, KafkaCode>

@dead10ck so, after inspecting the code you pointed out, reading the kafka protocol documentation again, and considering that kafka-rust does not provide any security related features ... after all this i fully agree with you that the current return value of the fetch_group_(topic_)offsets methods is non-sense. i would be glad if you could rework it just as you suggested. in particular i like the "or just return a top-level Result that contains either the partition and offset together, or an Err that describes which partition it failed to fetch.".
just to sum up my understanding of our discussion:

the more general fetch_group_offsets would return a Result<Map<String, Vec<PartitionOffset>, ErrorDescribingTopicsOrPartitionsDueToWhichTheWholeRequestFailed> ?
the topic related fetch_group_topic_offsets would return a Result<Vec<PartitionsOffset>, ErrorDescr...> ?
PartitionOffset (in both of the above methods) would be a mere struct PartitionOffset { partition: i32, offset: i64 } (since the Ok(partitions-offsets) will not contain any errors) ?
I'm of course fine with changing protocol::PartitionProduceResponse to contain the Result<i64, KafkaCode> (it's a private struct in the crate.)
Given the changes to the fetch_group_(topic_)offsets methods, suddently TopicPartitionOffset becomes exposed to client code only through produce_messages. This gives a nice opportunity to replace it with a struct which is dedicated as a response for produce_messages; it can contain the mentioned Result<i64, KafkaCode> and would be later extended in future to return that data which failed to be delivered (for retry attempts.) produce_messages has already a dedicated struct for its input, namely client::ProduceMessage (the corresponding return struct replacing TopicPartitionOffsetcould be namedProduceConfirmor similar; i'm not good at coming up with good names, feel free to make up one.) Soproduce_messageswould return aResult<Vec>` ?

can you confirm we are on the same line? many thanks so far!

Ah, ok, perfect! Yes, all of that sounds like what I was thinking of doing. Because my progress may be bursty, though, I think when I do make some progress, I'll open a work-in-progress PR, and I'll update it if I make any decisions outside of what you described while I work on it.

we've got this in master now. once again thanks for the hard work! it is really appreciated.
i'm going to keep this ticket open until the change gets pushed to creates.io. (i expect to do so next somewhere next week once i get back from vacation.)

just published on crates.io; closing this ticket. many thanks! 👍


Make Travis checks more helpfuler.

Related to #317
God I love it that this will tell you ALL of your structure errors, and not just one at a time...  geesh...

Looks great thanks!


[IOTDB-6144] Adjust the default thrift timeout parameter to 60s

see jira

Codecov Report

Merging #11091 (c5134a6) into master (f910c66) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #11091      +/-   ##
============================================
- Coverage     47.66%   47.66%   -0.01%
+ Complexity    23447    23446       -1
============================================
  Files          2780     2780
  Lines        168625   168625
  Branches      20077    20077
============================================
- Hits          80377    80368       -9
- Misses        88248    88257       +9

Files Changed
Coverage Δ

...ain/java/org/apache/iotdb/db/conf/IoTDBConfig.java
78.05% <100.00%> (ø)

...va/org/apache/iotdb/commons/conf/CommonConfig.java
87.85% <100.00%> (ø)

... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.


contracts: feature: introduce realm levels

contracts for #1719

introduce realm levels
create a function for upgrading realm levels as well as functions for configuration
restrict building on certain hexes depending on realm level
tests

In config i have added some contants which can be used to init the config, can you update to use them


Solution: Omit gen_stage warning

This seems to generate confusion since we got the same report twice in 24 hours. I don't really like to have code like this in our codebase. What do you think @c-rack?
Is there a way to do this at compile time?

@maennchen it might be not nice, but if it works and solves an issue, we could proceed with that. If we have a better way to do this in future, we can always change it. 👍 approved.

@c-rack I found a solution to do it at compile time. What do you think?

Great ❤


Missing "typings" in package.json

I'm not 100% sure but I think that without this property in package.json you can use your types when using the library.

Thanks, if you look at NPM it shows that your library now have typescript support (TS icon).

You can install<EMAIL_ADDRESS>to try it out if you want

Thanks, I use IncommingMessage right now, it seems it working. I've only noticed that npm don't show that you have TS support.


initial acl support

Add ability to set the particular hosts pod can access to with --acl flag, which can be set to host, ip or subnet. To set multiple values you can use this flag several times in one the command.
Also there is the test for acl, in which we have allowed host (github) and we try to access to it and to another (which one should be filter out).
Signed-off-by: Petr Fedchenkov<EMAIL_ADDRESS>

Well, In case of no-hyper I see that we map resolve.conf of the host. So, we have different behavior here for container-in-vm (where we use dnsmasq and ip of bridge as dns server) and for container (where we try to access "external" one and fail in case of the test with limited access).
WDYT @eriknordmark should we provide separately prepared resolve.conf files in the case of no-hyper mode?

One problem gone (with resolving of hosts), next problem arose (with accessing of hosts I defined in acl).

Seems, we cannot use ping inside, so I will move onto curl.

Looks like the test failed at tests/eclient/testdata/acl.txt#L29
Is there some documentation specifying what the hostonlyacl and acl arguments do, and specifying what the syntax is for the acl argument? For instance, can I specify an IP, an IP/len, a domain name, a domain name suffix. Can I specify multiple ACLs using a single acl option or do I add multiple acl options to do that?

I resolve the problem inside, it was because we cannot ping from GH Action VM. Also I add help commands output into PR.


localisation for whereDoYouLive

localisation for where do you live page. Also found there is unnecessary 'soleTraderCorrespondanceAddressManualController.ts' with no code. Deleted it as this was mistake while renaming files

CI: No security warnings found


Add xheight (XHGT) Axis

Fonts to be onboarded that have this axis:

https://github.com/google/fonts/issues/4286

Closing this cause xheight is already added as YTLC


Popups are not identified (I.E Failed: Failed expectation: TOBEVISIBLE WITH MATCHER)

Description
I'm in a process of updating detox from v7.8 to 17.8.x and came across with a new issue that i didn't experience on prior version.
we have a react-native app which exclusively runs on ipad.
We generally manage our dialogs on a global location and we display/hide them dynamically. ever since the update it seems like detox can't identify any of our dialogs.
what i saw in the logs is this:
<RCTView: 0x7fd91b83fc30>” is not visible: view does not pass visibility threshold (0 isible of 75 equired)
but i was able to see the popup appearing properly and also the view exists in the logs of the UI dump.
Sorry but i can't really supply screenshots due to confidentiality but i can assure that popup did appear without anything on top of it.
Thanks in advance for the help.

[ ] I have tested this issue on the latest Detox release and it still reproduces

Reproduction
Any of our dialogs are not being identified by detox (on latest version)
Expected behavior
Dialogs should be identified
Screenshots
If applicable, add screenshots to help explain your problem.

Follow the instructions here:
https://github.com/wix/Detox/issues/2358#issuecomment-698482624
If you are unable to provide these images, I will have to close your issue unfortunately.

@LeoNatan not really sure where i need to add this detoxDebugVisibility property

@LeoNatan I've add this and i don't see any difference
6A1F87D1-3CAB-42C6-8889-B3B17233200D com.tapingo.kiosk --args -detoxServer "ws://localhost:53083" -detoxSessionId "b056da96-3b0d-fe02-5b20-bc18a30ff858" -detoxDebugVisibility "YES" -detoxDisableHierarchyDump "true"
images and logs looks completely the same

ok scratch that.

one is from detox and the other actual screenshot

How is this alert implemented in native?

so we are basically using two libraries for alerts (in different popups) one is react-native-popup-dialog and the other  react-native-modal (from react native community) and results ends up same way

That doesn’t tell me anything about the native implementation. There was another complaint, in another issue, similar to this. I need to know how the native hierarchy is managed, so I can reproduce it locally and figure out how/if to fix. Like I said in the other issue, if these libraries are touching the zPosition of layers, it might not be possible to fix the current algorithm.

so i ended up solving this specific issue (still have some that might be relates to this so i prefer to keep it open until i have definitive answers about what went wrong after)
in our app what we had was this:
<View> <Dialogs/> <Navigator /> </View>
so it appears that the popup did appear properly but i guess thanks to z-index changes done by the library.
what i did was basically to switch between the two that seems to have solved this specific issue.
i still have some views not being found and i'm trying to understand if that's the same issue or not.

That's a good workaround, but I want to investigate this for the general case. Detox should be able to determine visibility of what is on the screen. It's just that zPosition is very odd. I'll look into it soon. Thanks!


Save microcontroller messages to file

The /dev/ttyACM0 (or another file) stream is consumed by Unity. To replay a visualisation we need it logged to a file.

We should use .pbf for the file extension of the log files to denote that it is framed protobuf data.

Fixed by https://gitlab.com/bikelab/phobos-visualizer/commit/58163f981099739dc857805e9ba11375d193a3f0


Browser mode: Istanbul coverage report incomplete

Describe the bug
The following test file causes trouble with vitest in browser mode (chrome). Notice the nested describe calls:
import { describe, it, expect } from 'vitest';
import { foo, bar, baz } from '../src/stuff';

describe('stuff 1', () => {
  it('should baz', () => {
    expect(baz()).toBe('doo');
  });

  describe('stuff 2', () => {
    describe('stuff 3', () => {
      it('should foo', () => {
        expect(foo()).toBe('bar');
      });
    });
    it('should bar', () => {
      expect(bar()).toBe('foo');
    });
  });
});

What seems to happen is that all three tests are run (and pass), but only the should baz and should foo count towards the coverage report. In the repro repo, this means line coverage is reported as 66%.
The issue only occurs when the tests are browser based. With the jsdom environment, things work as expected and the coverage is reported as 100%.
Reproduction
Reproduction repo is here
System Info
System:
    OS: macOS 13.4
    CPU: (10) arm64 Apple M1 Max
    Memory: 1.84 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.16.0/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
  Browsers:
    Chrome: 113.0.5672.126
    Firefox: 107.0.1
    Safari: 16.5
  npmPackages:
    @vitest/browser: ^0.31.1 => 0.31.4
    @vitest/coverage-istanbul: ^0.31.4 => 0.31.4
    @vitest/ui: ^0.31.1 => 0.31.4
    vite: ^4.3.2 => 4.3.9
    vitest: ^0.31.1 => 0.31.4

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

@lsim are you using the browser.slowHijackESM config option? I also had this issue, and when I was digging into it I found that the source maps weren't accounting for the transformations done with that option.

Thanks for you input! It's something to look into.
That option is on by default and I hadn't disabled it. So yes - I am using that. If I'm reading the docs right, I don't need it. Disabling it stops all my browser tests from running though.
No errors, no output.
I'll do a bit more experimenting

Weirdly with browser.headless = false, my tests fail with
TypeError: Cannot redefine property: chrome

Presumably from this line:
vi.stubGlobal('chrome', chrome);

Same tests work when running in headless chrome. This endeavour is a bit like walking blindfolded through a mine field :)
I guess for now I'll settle for the path that gives me working tests and broken coverage metrics.

I can't get my tests to run without the browser.slowHijackESM option either, so I'm in the same boat.
It seems like the instrumented code that the test is running on is mapping incorrectly to the source code. In packages/coverage-istanbul/src/provider.ts, onFileTransform does seem to be using the [getCombinedSourcemap](https://rollupjs.org/plugin-development/#this-getcombinedsourcemap from the rollup plugin, but the mappings provided with the instrumented version of the file is still wrong.
Here is an example

I can't get my tests to run without the browser.slowHijackESM option either, so I'm in the same boat.

This should be fixed in 0.32.1

It seems like the instrumented code that the test is running on is mapping incorrectly to the source code. In packages/coverage-istanbul/src/provider.ts, onFileTransform does seem to be using the getCombinedSourcemap from the rollup plugin, but the mappings provided with the instrumented version of the file is still wrong.

Maybe we need to provide order: 'post' in the plugin so it runs after all transformations 🤔

@sheremet-va I added enforce: 'post' to the CoverageTransform plugin function and it did produce a different transformation, just not the correct one.
Here is the output to compare against my previous.

Also just updated to 0.32.2 with  browser.slowHijackESM = false and the tests run. However I'm still getting incorrect coverage.

@lsim I explored this some more and I believe the issue is not due to coverage-istanbul but how the browser runner differs from the standard runner. Here is a reproduction to demonstrate .
@sheremet-va I'm happy to make a PR if you can point me in the right direction. Do tests for this belong in test/coverage-test/coverage-report-tests?
From the readme:
While debugging, I noticed that `takeCoverage()` in the `coverage-istanbul` package gets called multiple times in browser mode, and only once with node. It seems like the browser is calling `onAfterRunSuite` in `packages/browser/src/client/runner.ts` 4 times.

Removing `globalThis[COVERAGE_STORE_KEY] = {}` in `packages/coverage-istanbul/src/index.ts: takeCoverage()` does produce 100% coverage, but with higher counts for coverage hits.

So far I don't think there is an issue with the `coverage-istanbul` package, but with how the browser runner is handling suites. Running without any `describe()` blocks (find commented-out in the test file) gives 100% coverage for both.

@sheremet-va I've added a PR (#3806). First time contributing to this repo and I left some notes for the reviewer. Thanks.

@elby22 your analysis on the root cause sounds correct. The browser runner is using different hook when compared to NodeJS's worker_thread/child_process runner.
https://github.com/vitest-dev/vitest/blob/8693449b412743f20a63fd9bfa1a9054aa74613f/packages/browser/src/client/runner.ts#L42-L46
https://github.com/vitest-dev/vitest/blob/8693449b412743f20a63fd9bfa1a9054aa74613f/packages/vitest/src/runtime/entry.ts#L67-L72
I think the rpc.onAfterSuiteRun is poorly named as it should actually be somthing like onAfterTestFileRun. But let's not change that at this point.

Fixed in https://github.com/vitest-dev/vitest/pull/3806.


Fix data corruption conflict

As a result of the incident with the Postgres WAL-files corruption on prod env, two records has been inserted to the replication DB but are missing in the ops-db.
Solution: manually copy records with IDs ('10c1e637-1542-4dea-aa3c-7b196d7ad88c','9d26e18f-eec8-4022-9310-6b490e7803a9') to the ops-db from replication db.

Error when inserted record:
sql> INSERT INTO public.declarations (id, employee_id, person_id, start_date, end_date, status, signed_at, created_by, updated_by, is_active, scope, division_id, legal_entity_id, inserted_at, updated_at, declaration_request_id, seed) VALUES ('9d26e18f-eec8-4022-9310-6b490e7803a9', '5c2b5529-a789-4ae6-947f-6fe774afdc61', '94e923c8-0c14-4583-a367-eb2165180925', '2018-01-30', '2021-01-30', 'active', '2018-01-30 14:49:04.327208', '030ca1a6-b4e7-49a2-b655-c7f78aeb40e6', '030ca1a6-b4e7-49a2-b655-c7f78aeb40e6', 'true', 'family_doctor', '4c4cf162-df85-47b8-a3c2-b9247d3b37b4', '030ca1a6-b4e7-49a2-b655-c7f78aeb40e6', '2018-01-30 14:49:04.344277', '2018-01-30 14:49:04.344291', 'efcb8cb5-a277-407b-8fa4-45af2a3e360d', '\x9970c86762212151cb0c609e9f96004ca2365d21cd602ec5cf0c421360868293c54d452b48f8793d0c428704b4b1bd9314cd3b7f822ddeac1a883b81df3c18cb')
[2018-02-02 15:59:56] Detail: Key (person_id)=(94e923c8-0c14-4583-a367-eb2165180925) already exists.```


Adding Cloudstack as a provider

Hi,
I'm working on adding Cloudstack as a providor to PerfKitBenchmarker. Is someone already working on it? I'm opening this to track my changes.
-Syed

Syed - This would be great.  No one is working on this so it is all yours.  We do have OpenStack support so likely yours will be similar for CloudStack.
For those that dont know the difference here is a good explanation - http://www.datacenterknowledge.com/archives/2015/02/23/openstack-vs-cloudstack-the-platforms-and-the-cloud-apis/
Tony

Assigning to me to handle the pull request when it comes.  Cheers...

PR is at #527

Closing this


KAFKA-14705: Move topic filters to tools module

After MirrorMaker 1 removal, there are no other modules dependencies for these classes, so we can safely move them to tools module.

@mimaison fyi


exporter/jaeger: Links are missing LinkType

We need the ability to translate a span's LinkType to a jaeger RefType.
It currently is
https://github.com/census-instrumentation/opencensus-go/blob/94fd1d08391b28f9c9f721b2a67fcf57bfd0a70e/exporter/jaeger/jaeger.go#L214-L220
But needs to translate *SpanData.Links[].Type i.e.
for _, link := range data.Links {
 	refs = append(refs, &gen.SpanRef{
 		TraceIdHigh: bytesToInt64(link.TraceID[0:8]),
 		TraceIdLow:  bytesToInt64(link.TraceID[8:16]),
 		SpanId:      bytesToInt64(link.SpanID[:]),
                 RefType: asJaegerLinkType(link.Type),
 	})
 }

func asJaegerLinkType(t LinkTypeChild) SpanRefType {
        if t == LinkTypeChild {
           return gen.SpanRefType_CHILD_OF
        }
        // Other OpenCensus LinkTypes don't map to Jaeger's LinkTypes
        // TODO: file an issue with Jaeger and ask about the various LinkTypes
        return gen.SpanRefType_FOLLOWS_FROM
}

Is this issue still of interest?

@djui Yeah But I couldn't find the file jaeger.go in master branch.
Any idea on this?

Hi @rghetia is it still relevant and ready to be picked. If yes, I would love to take it up.

@kaustubhmallik I would recommend getting involved in OpenTelemetry instead.


Moving proximity-hover dynamic Frontplates functionality to release

The goal of this PR is to move the experimental proximity-hover dynamic Frontplate Rawimages functionality to Release.  In particular, the changes consist of:

Removing experimental prefabs.
Removing unnecessary context menu entries.
Updating release ActionButton, CanvasButtonToggleSwitch, and EmptyButton prefabs to make their frontplate's rawimages dynamically enabled based on proximity-hover {enter|exit} events.

Justification for this change:  Our experiments demonstrated that when buttons have a dynamic frontplate rawimage then a scene can have more buttons at the same time before a significant framerate drop (less than 60 fps for more than 5 seconds).  Next are the results of our experiments:

Note:  We used our internal benchmarking tool for the experiments.  Next is a screenshot of the benchmark with dynamic frontplate buttons:

Additional manual testing:  We ran on HL2 all MRTK3 scenes and verified that all functionality remained the same and that no assets were broken.

@keveleigh, @david-c-kline we would like to have your sign-off on this PR :-) ... if you have time, Could you please take a look? thx!

I moved the ActionButtonCheckbox prefab to be part of the release buttons instead of deleting it.  @keveleigh, @david-c-kline we would love to have your sign off for this PR :-) ... @shaynie, @AMollis your opinion is also appreciated ;-) ... @marlenaklein-msft  if you could re-approve that would be great too.

/azp run


cannot import name 'url_quote' from 'werkzeug.urls'

windows 10
cuda 12.1

did u find a solution ??

@Alrefa3ee Please try to reproduce and reopen if the error persists.


fix for streamlit>=1.7.0

address changes made to streamlit  in https://github.com/streamlit/streamlit/commit/ba46ad297e8816f0d6a3aa910ce67556239f3e6d
fixes https://github.com/TangleSpace/hydralit/issues/27

i'd suggest you contribute to a different project, as i'm not interested in merging garbage into this code base or dealing with people that think they have some right to my work after contributing absolutely nothing of value.
#v1.7.0
from streamlit.script_run_context import get_script_run_ctx
to
#v1.8.0
from streamlit.scriptrunner.script_run_context import get_script_run_ctx


Play Billing requires enableNotifications to be true.

The Play Billing plugin requires enableNotifications to be true to work. This is because enableNotifications is required for the DelegationService to be enabled.
We have a few options:

Make playbilling=true imply enableNotifications=true.
Make playbilling=true not build if enableNotifications=false.
Make playbilling=true include DelegationService as well.

The confusing thing with option 3 is that the presence DelegationService implies enableNotifications=true, so it's essentially the same as option 1.
We also have option...

Always include the DelegationService (essentially setting enableNotifications=true for everyone), and remove enableNotifications.

Related is PR #409 .

Should this flag also be added to the init billing prompt introduced in https://github.com/GoogleChromeLabs/bubblewrap/pull/438? I've recently spent a while troubleshooting a clientAppUnavailable error until discovering that alphaDependencies and enableNotifications is required.

#409 changed the default to enableNotifications=true for all cases. #438 introduced the billing prompt and enables alphaDependencies. init should have everything set correctly when billing is enabled.

#511 added some more checks in update to ensure that when Play Billing is enabled, enableNotifications and alphaDependencies are also enabled/true. Do we think this issue can be closed now?

Yes, SGTM

Closed via #511


Disaggregate Grade Data

Something I would like to do is include all grade data ever in a single sheet. To do that, each row would have to a graded item with data linking that graded item to a course section. I am trying to decide if I should generate student IDs to track alongside that data, but I don't think I even want this data traceable to a particular student (probably not needed).
Anyway, a sample of what this would look like is included in a file called grading-history.csv. Here's a sample:
Section ID,Title,Grade,Total
12415,Homework #1,2,2
12415,Homework #2,2,2

I'm curious what other kinds of data would be useful here. This is probably enough since I'll finally be able to track grades more effectively.

Another payoff of this setup would be that I could create a separate table that includes things like homework name and description with a unique ID for each that I could reference in the table above.

Another idea I had was to include due dates for assignments in a separate table. Then, include the submission time in the grade history. That would be cool just to see when folks submit things.


Cache "initialURL" for offlineview or PWA support

Environment
Flutter version: 1,20
Description
What you'd like to happen:
Is it possible to cache "intialURL" so that if there is no internet, InitialURL always opens the page from the local cache if the app has been opened at least once and the cache is not cleared.
Thanks

@pichillilorenzo - can progressive web app code be injected to cache initial URL and following URL, so that if the device is offline, App can still open all opened pages?

@pichillilorenzo - please share some insight

@rebootcode  this is very useful feature being able to load the page from disk when offline.
if your reading this issue you should also check issue 366

@pichillilorenzo any update on this ? Caching inital url would be good.

any update?


[local-volume] Replace bootstrapper with spec generation using templates

The local provisioner daemonset spec is complex and error prone because hostpath volumes and discovery configuration have to be configured consistently.  The bootstrapper pod tried to simplify this by auto generating the daemonset spec and automatically launching it.  But this method somewhat hides the daemonset spec and makes it hard to customize and add enhancements.
Instead, I think a better approach would be to have a script that takes in the config, and generates a daemonset spec based off of a template.  Then users could easily customize the generated spec as needed.

/area local-volume

To be more precise, the inputs would be:

a configuration file, perhaps yaml? i'm not very picky here

the config would include everything that the local volume configmap supports: storageclass mappings, node labels, etc.
also optional parameters for the service account that should be used for the provisioner

the generated specs should include:

daemonset
configmap

as a possible solution for templating I would consider 'helm' which would generate daemonset and configmap specs based on user's input config in yaml format and on provided "standard" templates.

My only reservation about helm is the requirement to install the server-side tiller component.  Really, we just want the templating part and not the deployment.
Would this work? It looks like a client-side only helm templating plugin.
https://github.com/technosophos/helm-template

@msau42 tiller is need only if you want to deploy rendered templates, if I remember right helm template command does not require tiller, but I will double check it.

Or this?
http://helm.readthedocs.io/en/latest/generate-and-template/


Smoke tests complete list

Made a script that gets the list of readmes from the specs repo (local GIT clone). Then, I took that list and made it into our smoke test text document list. Lastly, I ran the smoke tests, found the readmes that fail, marked those, skipped them, and ran until I had a working set.
There are a few distinct failures, with a few random issues from the prior list still in the document, and a catch-all for some 1-off issues:

https://github.com/Azure/autorest.csharp/issues/721
https://github.com/Azure/autorest.csharp/issues/733
https://github.com/Azure/autorest.csharp/issues/734
https://github.com/Azure/autorest.csharp/issues/735

We can 'bubble up' some of the failures to M4 issues, and make sure they get P0 priority on the M4 repo. As those M4 issues are resolved, we can now use our repo to test those resolutions too. Additional validation is always nice to have. 😁

Let's move all the issues to appropriate repos and reference them there. They are not actionable in this repo.

I'm discussing with David on how to handle the issues. I'll update the PR once we figure out the plan.


[Other] Can't use apple intelligence after following the guid on macOS Version 15.1 Beta (24B5046f)

Additional Information
I following the guid with SIP disable + "amfi_get_out_of_my_way=1"
using the command curl -L https://raw.githubusercontent.com/KyleYe/XcodeLLMEligible/release/0.2/scripts/override.sh | bash -s -- install util all  after the command finished I immediately restarted my computer and set my region and language to the us. however, there is no apple intelligence and Xcode llm.
when open the Xcode for download, it said not available.
the output of the command is
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  9705  100  9705    0     0  10840      0 --:--:-- --:--:-- --:--:-- 10831
Performing with [action]=install [method]=util [key]=all
[install] started
[check_sip_status] checking SIP status...
[check_sip_status] SIP is disabled
[amfi_check] checking boot-args
[amfi_check] amfi_get_out_of_my_way=1 is present in boot-args
[amfi_check] Note: You need to reboot to make boot-args changes take effect
[method_util_check] 🎉 SIP is disabled and amfi_get_out_of_my_way=1 is present in boot-args
[download_file] Download started
[download_file] Downloading from https://github.com/Kyle-Ye/XcodeLLMEligible/releases/download/0.2.0/eligibility_util to /tmp/eligibility_util
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 1530k  100 1530k    0     0   552k      0  0:00:02  0:00:02 --:--:-- 1046k
[download_file] Download completed
[method_util] Setting all to eligible...
Force domain set answer successfully
[method_util] Setting Complete...
[method_util] Checking the status...
{
    "OS_ELIGIBILITY_DOMAIN_ALUMINUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_ARGON" = 4;
    "OS_ELIGIBILITY_DOMAIN_BERYLLIUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_BORON" = 4;
    "OS_ELIGIBILITY_DOMAIN_CALCIUM" = 2;
    "OS_ELIGIBILITY_DOMAIN_CARBON" = 4;
    "OS_ELIGIBILITY_DOMAIN_CHLORINE" = 4;
    "OS_ELIGIBILITY_DOMAIN_CHROMIUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_COBALT" = 4;
    "OS_ELIGIBILITY_DOMAIN_COPPER" = 2;
    "OS_ELIGIBILITY_DOMAIN_FLUORINE" = 4;
    "OS_ELIGIBILITY_DOMAIN_GREYMATTER" = 2;
    "OS_ELIGIBILITY_DOMAIN_HELIUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_HYDROGEN" = 4;
    "OS_ELIGIBILITY_DOMAIN_IRON" = 4;
    "OS_ELIGIBILITY_DOMAIN_KRYPTON" = 4;
    "OS_ELIGIBILITY_DOMAIN_LITHIUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_LOTX" = 4;
    "OS_ELIGIBILITY_DOMAIN_MAGNESIUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_MANGANESE" = 4;
    "OS_ELIGIBILITY_DOMAIN_NEON" = 4;
    "OS_ELIGIBILITY_DOMAIN_NICKEL" = 2;
    "OS_ELIGIBILITY_DOMAIN_NITROGEN" = 4;
    "OS_ELIGIBILITY_DOMAIN_OXYGEN" = 4;
    "OS_ELIGIBILITY_DOMAIN_PHOSPHORUS" = 4;
    "OS_ELIGIBILITY_DOMAIN_PODCASTS_TRANSCRIPTS" = 4;
    "OS_ELIGIBILITY_DOMAIN_POTASSIUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_RUBIDIUM" = 2;
    "OS_ELIGIBILITY_DOMAIN_SCANDIUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_SEARCH_MARKETPLACES" = 4;
    "OS_ELIGIBILITY_DOMAIN_SILICON" = 4;
    "OS_ELIGIBILITY_DOMAIN_SODIUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_STRONTIUM" = 2;
    "OS_ELIGIBILITY_DOMAIN_SULFUR" = 4;
    "OS_ELIGIBILITY_DOMAIN_SWIFT_ASSIST" = 2;
    "OS_ELIGIBILITY_DOMAIN_TITANIUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_VANADIUM" = 4;
    "OS_ELIGIBILITY_DOMAIN_XCODE_LLM" = 2;
    "OS_ELIGIBILITY_DOMAIN_ZINC" = 2;
}

[install] completed
If you find this script helpful, please consider giving a star to the project.
🌟🌟🌟 https://github.com/Kyle-Ye/XcodeLLMEligible 🌟🌟🌟

when I tried to use ./eligibility_util_sip getDomainAnswer --domain-name OS_ELIGIBILITY_DOMAIN_GREYMATTER to confirm, the out put is empty
hope you can help me,
thanks!
this is a truly grade project!!!

Your log suggest you did fail to unlock them. (4 means success)
"OS_ELIGIBILITY_DOMAIN_GREYMATTER" = 2;
"OS_ELIGIBILITY_DOMAIN_XCODE_LLM" = 2;

Try the following command and post your output.
# For XcodeLLM:
./eligibility_util forceDomainAnswer --domain-name OS_ELIGIBILITY_DOMAIN_XCODE_LLM --answer 4
# For Apple Intelligence
./eligibility_util forceDomainAnswer --domain-name OS_ELIGIBILITY_DOMAIN_GREYMATTER --answer 4

If you see eligibility_util is killed, check your SIP status and amfi_get_out_of_my_way.

Oh, the output is Force domain answer successfully and I saw apple intelligence in setting,Thanks!
however, I still want to know why curl -L https://raw.githubusercontent.com/KyleYe/XcodeLLMEligible/release/0.2/scripts/override.sh | bash -s -- install util all didn't succeed and is it make other change to my Mac?
thanks a lot if you can answer my questions

I still want to know why curl -L https://raw.githubusercontent.com/KyleYe/XcodeLLMEligible/release/0.2/scripts/override.sh | bash -s -- install util all didn't succeed

Maybe Apple changed the all command implementation or something else happened.
Do not have time to investigate on your OS version here - 15.1 Beta (24B5046f).
I'll double check the logic here for the future macOS 15.1 release.
And if you are eager to know the answer you can debug eligibilityd on /usr/libexec/eligibilityd directly yourself.

is it make other change to my Mac?

It should only change the override file. You can just follow the uninstall step to do the opposite operation.
curl -L https://raw.githubusercontent.com/Kyle-Ye/XcodeLLMEligible/release/0.2/scripts/override.sh | bash -s -- uninstall util all

OK，thanks a lot. But know my Mac is in preparing for almost 4hours. Is it an apple bug?

Maybe you can try to disable and enable it again.

@little-weakduck
I run xcodellm or greymatter alone and it works, only all fails.
Maybe you can use one of these features first
Version 15.1 Beta4 (24B5046f)

Maybe you can try to disable and enable it again.

yes! it's ok right know, truly thanks you!

@little-weakduck I run xcodellm or greymatter alone and it works, only all fails. Maybe you can use one of these features first
Version 15.1 Beta4 (24B5046f)

I using
# For XcodeLLM:
./eligibility_util forceDomainAnswer --domain-name OS_ELIGIBILITY_DOMAIN_XCODE_LLM --answer 4
# For Apple Intelligence
./eligibility_util forceDomainAnswer --domain-name OS_ELIGIBILITY_DOMAIN_GREYMATTER --answer 4

it's work, I may think it's maybe the all problems, thanks!

Add a note to it. Thanks for the reporting.
5ddff71dc9d0403641e54f4c7180527bad2ccf7c


Missing treatment

@myrmoteras @flsimon
Looking into this treatment - appears to come up as having no text.
https://treatment.plazi.org/GgServer/html/FE5887E47B3CA86E9DC0FF3BB102FBF2
I would appreciate some help with troubleshooting.

As https://treatment.plazi.org/GgServer/xml/FE5887E47B3CA86E9DC0FF3BB102FBF2 shows, the whole treatment text is marked as a caption, and without the inLine attribute, which effectively has its text hidden in the HTML ... going to take care of it.

Fixed ... see https://treatment.plazi.org/GgServer/xml/FE5887E47B3CA86E9DC0FF3BB102FBF2/4 for the previous version of the XML, and https://treatment.plazi.org/GgServer/xml/FE5887E47B3CA86E9DC0FF3BB102FBF2 for the current version with the inLine flag on the caption.

Well, the whole treatment is (and was) marked as a caption (which is why the text didn't show at all), and all I did was mark the caption with the inLine attribute, which signals the TB website to display the text despite its being inside a caption ... the "View Figure" showing after every paragraph is basically the result of the rare (and unintended) case that an in-line caption spans more than a sentence or two ... for the line drawing to show as well, we'll have to mark the whole figure as one, or connect the figures via "Bottom Extend" or "Right Extend" ... I tend to think the former will do ... the original question was only about the treatment text now showing, though ...

The reason the materialsCitation only shows up now is because now it's inside a single subSubSection and paragraph, which it wasn't before, as it was marked across a paragraph boundary.

Well, the whole treatment is (and was) marked as a caption (which is why the text didn't show at all), and all I did was mark the caption with the inLine attribute, which signals the TB website to display the text despite its being inside a caption ... the "View Figure" showing after every paragraph is basically the result of the rare (and unintended) case that an in-line caption spans more than a sentence or two ... for the line drawing to show as well, we'll have to mark the whole figure as one, or connect the figures via "Bottom Extend" or "Right Extend" ... I tend to think the former will do ... the original question was only about the treatment text now showing, though ...

Figured out why that line drawing doesn't come up with the image ... it's conflated with the gray bar and black line across the page top into a single graphics object, and therefor doesn't work as intended ... unfortunately, that black line does not repeat on all the pages, either, so GGI has no way of telling it is for of page decoration (akin to the lighter and thinner line further above it) ... tough one, will have to think about it ... maybe we need an option for cutting graphics supplements apart ...

Export of the vector portions of the figure is fixed with the update I just deployed. Cannot update the figure on Zenodo right now, though, as there seems to be a permission issue with uploading new files ... in contact with Zenodo developers in that regard.


panic in db.Statement.SetColumn  if Model is unaddressable by  update

is this a bug?
if i use  db.Statement.SetColumn("Name", "jinzhu")  in  callbacks
and
i uss Updates like below

// 根据 struct 更新
db.Model(User{}).Where("role = ?", "admin").Updates(User{Name: "hello", Age: 18})
// UPDATE users SET name='hello', age=18 WHERE role = 'admin;

it will be panic in https://github.com/go-gorm/gorm/blob/7701c885077051c864da309ed850631ada7d0eea/statement.go#L552
because of the  db.Statement.ReflectValue is not addressable
^_^

Fixed by https://github.com/go-gorm/gorm/commit/d327926425afecbe084997ba195497107cd71a92
Thank you for your report.


The current vendors references are invalid for HttpFoundation and CssSelector

I upgraded it to the latest version

Updated done


Add Curl Follow Redirect.

Add Curl Follow Redirect To support zeno.fm links
curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);

Hi!
Did it help you? It didn't help me.

Yes it did, I was able to create an api using your library.
On Sun, Feb 12, 2023, 20:26 Oleh Kovalenko @.***> wrote:

Hi!
Did it help you? It didn't help me.
—
Reply to this email directly, view it on GitHub
https://github.com/ko-n/Mp3StreamTitle/issues/4#issuecomment-1427124837,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKPHXKCIBN5L45R4O752DNDWXFBQRANCNFSM6AAAAAAUV2VI3Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi! Did it help you? It didn't help me.

API endpoint https://api.streamafrica.net/zeno/new.php?id=hca68918n98uv
The ?id=   payload is the zeno mountpoint name.

Hi, I have added:
curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
Thank you!
And sorry, I saw your fork late...

curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);

Thanks for adding it. :)


(vcredist2008) Garbage in the root drive

This is what I have on all my computers after vcredist is installed which is highly annoying. The install.exe starts vcredist 2008 setup.
I believe the package is this one: https://github.com/dtgm/chocolatey-packages/tree/master/automatic/_output/vcredist2008/9.0.30729.6161
@jberezanski, would it be possible for you to move it here and fix this ?
PS: ls c:\

-a----       2007-11-07     07:00          17734 eula.1028.txt
-a----       2007-11-07     07:00          17734 eula.1031.txt
-a----       2007-11-07     07:00          10134 eula.1033.txt
-a----       2007-11-07     07:00          17734 eula.1036.txt
-a----       2007-11-07     07:00          17734 eula.1040.txt
-a----       2007-11-07     07:00            118 eula.1041.txt
-a----       2007-11-07     07:00          17734 eula.1042.txt
-a----       2007-11-07     07:00          17734 eula.2052.txt
-a----       2007-11-07     07:00          17734 eula.3082.txt
-a----       2007-11-07     07:00           1110 globdata.ini
-a----       2007-11-07     07:44         855040 install.exe
-a----       2007-11-07     07:00            843 install.ini
-a----       2007-11-07     07:44          75280 install.res.1028.dll
-a----       2007-11-07     07:44          95248 install.res.1031.dll
-a----       2007-11-07     07:44          90128 install.res.1033.dll
-a----       2007-11-07     07:44          96272 install.res.1036.dll
-a----       2007-11-07     07:44          94224 install.res.1040.dll
-a----       2007-11-07     07:44          80400 install.res.1041.dll
-a----       2007-11-07     07:44          78864 install.res.1042.dll
-a----       2007-11-07     07:44          74768 install.res.2052.dll
-a----       2007-11-07     07:44          95248 install.res.3082.dll
-a----       2007-11-07     07:00           5686 vcredist.bmp
-a----       2007-11-07     07:50        1927956 VC_RED.cab
-a----       2007-11-07     07:53         242176 VC_RED.MSI

Yeah, I could give it a shot. At first glance, however, the package does not do anything out of the ordinary, so it will probably mean debugging the native installer to determine the way to convince it to put its temp files elsewhere.

Looks like this was a known bug for the vcredist 2008 installer, seems like the recommended aproach is to install vcredist 2008 SP1 which have fixed that bug.
https://support.microsoft.com/help/950683/vcredist-from-vc-2008-installs-temporary-files-in-root-directory

OK, so according to this the package should be updated to install https://www.microsoft.com/en-us/download/details.aspx?id=26368.

URLs I got when downloading this from MS site are:

https://download.microsoft.com/download/5/D/8/5D8C65CB-C849-4025-8E95-C3966CAFD8AE/vcredist_x86.exe
https://download.microsoft.com/download/5/D/8/5D8C65CB-C849-4025-8E95-C3966CAFD8AE/vcredist_x64.exe

Is this safe to use, i.e. not something that will expire ?

Yes, download.microsoft.com urls are generally stable (apart from very rare cases when MS decides to remove a download).

Looks like dtgm package is already of that version. I will migrate it here just for the sake of all vcredists to be on the same place.

I don't know how then, I still get the garbage in the root. Perhaps some other package depends on particular version ? If that is the case it might be good idea to unlist other versions, then those packages will fail and can be fixed to use the latest one.

If they depend on an exact version, they wouldn't fail as the package version is still there just not shown on the website.

Then we would know that package failed and can fix it to use new version instead of adding garbage to the root. It might not be good idea tho on 2nd thought.

Will reopen it until its pushed.

Should I  push this with 9.0.30729.6162? (added +1) or something else ?

Personally I would probably add 01 to the existing version (using zero a separator between version and fix), but considering the redistributable will unlikely ever be updated again I'm fine with either way.

A minor issue - tags contain "2017" instead of "2008".
Just checked installing interactively on a Win7-32 VM, no garbage. According to logs (%TEMP%\dd_vcredist*.txt) the files got extracted to C:<a_directory_name_which_looks_like_a_guid> and that directory was removed at the end of install.
Will check via choco now.

Thx, fixed tag.

choco 0.10.3 on Win7-32 - no garbage
choco 0.10.3 and 0.10.5 on Win10.1607-64 - no garbage (also when installed as dependency of vcredist-all)
@majkinetor perhaps it's something specific to your setup that causes this - custom permissions on C:? antivirus?

nah, several different machines.

OK, will close this and leave package unpushed for now. Will try to determine more precise how this happen and eventually reopen this.

I just got this too. WTF

I am using winmerge too.


Add smart contracts security best practices reference

Mythril seems to be the standard for this but we could explore additional options

I wouldn't bother adding on yet, since our experiences with them are pretty lackluster. We can add a section in the readme to go read things like the best practices, which also include tips for security tooling.

We can close this for now


Possible Specify Table template file

Is there a way to specify a different JSON template file for the Companies Table?

You can extend the table builder in your local project, overwrite the protected constant (template) and then bind in a service provider the new class over the original one.

Ok. Awesome Thank You. I will close this now


PLAT-17000: Apply rAF into Control.applyStyle

Issue
: We need to reduce JS execution time to handle touchmove and to update DOM element while scrolling a list.
Fix
: I applied rAF into not enyo/ScrollMath.animate.fn() but enyo/Control.applyStyle() and called enyo/ScrollMath.animate.fn() directly when handing "touchmove" event.
Enyo-DCO-1.1-Signed-off-by: YB Sung<EMAIL_ADDRESS>

Thanks, @webOS101.
I fixed the following issues that @webOS101 commented.

Inserted the code in fn() into animate()
Used animation.requestAnimationFrame instead of using window.requestAnimationFrame directly

And I merged the latest code in garnet-perf-exp into this PR.

After we test this experimental branch, we must refine code.


Bug in pairing process related to SRP module

Hi,
Having trouble pairing and consistently getting this error:
[9/30/2020, 00:13:32] [HB Supervisor] OS: Linux 5.4.51+ arm
[9/30/2020, 00:13:32] [HB Supervisor] Node.js v12.18.3 /usr/local/bin/node
[9/30/2020, 00:13:32] [HB Supervisor] Homebridge Path: /usr/local/lib/node_modules/homebridge/bin/homebridge
[9/30/2020, 00:13:32] [HB Supervisor] UI Path: /usr/local/lib/node_modules/homebridge-config-ui-x/dist/bin/standalone.js
[9/30/2020, 00:13:32] [HB Supervisor] Delaying Homebridge startup by 20 seconds on low powered server
[9/30/2020, 00:13:53] [HB Supervisor] Starting Homebridge with extra flags: -I -D
[9/30/2020, 00:13:53] [HB Supervisor] Started Homebridge v1.2.3 with PID: 749
[9/30/2020, 00:14:11] [Config] Homebridge Config UI X v4.27.2 is listening on :: port 8581
[9/30/2020, 00:14:04] Loaded config.json with 0 accessories and 2 platforms.
[9/30/2020, 00:14:04] ---
[9/30/2020, 00:14:15] Loaded plugin<EMAIL_ADDRESS>[9/30/2020, 00:14:15] Registering platform 'homebridge-config-ui-x.config'
[9/30/2020, 00:14:15] ---
[9/30/2020, 00:14:15] The plugin "homebridge-ranger" defines 'homebridge' and/or 'hap-nodejs' in their 'dependencies' section, meaning they carry an additional copy of homebridge and hap-nodejs. This not only wastes disk space, but also can cause major incompatibility issues and thus is considered bad practice. Please inform the developer to update their plugin!
[9/30/2020, 00:14:24] Loaded plugin<EMAIL_ADDRESS>[9/30/2020, 00:14:24] Registering platform 'homebridge-ranger.Ranger'
[9/30/2020, 00:14:24] ---
[9/30/2020, 00:14:24] Loading 2 platforms...
[9/30/2020, 00:14:24] [Config] Initializing config platform...
[9/30/2020, 00:14:24] [Config] Running in Service Mode
[9/30/2020, 00:14:24] [Ranger] Initializing Ranger platform...
[9/30/2020, 00:14:24] [Ranger] Ranger Platform Plugin Loaded
[9/30/2020, 00:14:24] [Ranger] Found device in config: "PREMIS"
[9/30/2020, 00:14:24] [Ranger] Waiting for accessory: PREMIS
[9/30/2020, 00:14:24] [Ranger] Not all accessories have their devices. Not publishing yet.
[9/30/2020, 00:14:24] [Ranger] DidFinishLaunching
[9/30/2020, 00:14:27] [Ranger] Found unpaired accessory PREMIS  address=REDACTED rssi=-81dB
[9/30/2020, 00:14:27] [Ranger] Accessory 'PREMIS' found.
[9/30/2020, 00:14:29] [Config] Starting terminal session
[9/30/2020, 00:14:31] [Ranger] Discovered services.
[9/30/2020, 00:14:33] [Ranger] Discovered GATT services and characteristics of PREMIS
[9/30/2020, 00:14:33] [Ranger] Connected to PREMIS
[9/30/2020, 00:14:44] [Ranger] homebridge-ranger is taking a long time to load and preventing Homebridge from starting.
[9/30/2020, 00:14:48] [Ranger] Device is not paired yet, pairing now.
TypeError: Cannot read property '3072' of undefined
    at new PairSetup (/usr/local/lib/node_modules/homebridge-ranger/src/hap/pairing/PairSetup.js:43:30)
    at BleAccessory._pairDevice (/usr/local/lib/node_modules/homebridge-ranger/src/BleAccessory.js:169:23)
    at BleAccessory._ensureDeviceIsPaired (/usr/local/lib/node_modules/homebridge-ranger/src/BleAccessory.js:152:29)
    at BleAccessory.start (/usr/local/lib/node_modules/homebridge-ranger/src/BleAccessory.js:129:18)
    at RangerPlatform._startAccessories (/usr/local/lib/node_modules/homebridge-ranger/src/index.js:196:7)
    at RangerPlatform._tryToPublish (/usr/local/lib/node_modules/homebridge-ranger/src/index.js:169:7)
    at RangerPlatform._onHapAccessoryDiscovered (/usr/local/lib/node_modules/homebridge-ranger/src/index.js:162:7)
[9/30/2020, 00:15:04] [Ranger] homebridge-ranger is taking a long time to load and preventing Homebridge from starting.

I already fixed some unhandled promise rejection errors. I feel like I am close, but not sure why that property is not defined.  Any pointers would be helpful.

@ejgeiger - I noticed the same issue, using the fork from @palasinio
https://github.com/palasinio/homebridge-ranger

Which node/npm and RasPi version are you using?

The related line 43 is:
this._params = srp.params["3072"];
While srp is a constant defined on line 4 via
const srp = require('fast-srp-hap');
Cheers
Jan

I discovered this weekend, that pairing is no longer working. While I am no dev, I don‘t know what to do.
@ejgeiger : Can you tell me the fixed unhandled promise rejection errors or open a PR please?
The TypeErrors appeared imho /w later Homebridge versions, which is less tolerant for example with type conversions (using string as int).
As @gewaechshaus wrote, maybe you could not change a constant?

Hi, I am also not a dev. It's been a few weeks so I don't remember everything I did.
For the unhandled promise rejections I changed line 171 in BleAccessory.js to const result = await this.hapExecutor.run(pairSetup).catch((err) => console.log(err));. I think I also added .catch((err) => console.log(err)); to a line or two in index.js but I wasn't using source control and my notes are... lacking detail.
For the type error I found that changing line 43 in PairSetup.js to:    this._params = srp.SRP.params['3072']; fixed that error.  Then I changed line 104 to this._srp = new srp.SrpClient(this._params, this._salt, identity, password, this._key);
Now I am getting stuck in the HapExecutor.js file.  I can't get through all the M1-M6 steps (handshakes?). I think something is maybe not parsing correctly or maybe the accessory I am trying to connect to is somehow different?  I have since moved on to a different hobby project, but willing to contribute here.  Also, the new HomePod Mini will likely act as a BLE repeater.  At least I hope so.

Hi, faced with the same issue. Using @palasinio fork with latest homebridge and node-v12.19.0-linux-arm64
After fixing

For the type error I found that changing line 43 in PairSetup.js to:
this._params = srp.SRP.params['3072'];
fixed that error. Then I changed line 104 to
this._srp = new srp.SrpClient(this._params, this._salt, identity, password, this._key);

stuck at
[10/27/2020, 6:56:26 PM] [Ranger] Returning pairing request for M1 [10/27/2020, 6:56:27 PM] [Ranger] Received pairing response for M2 [10/27/2020, 6:56:27 PM] [Ranger] Returning pairing request for M3 [10/27/2020, 6:56:29 PM] [Ranger] Pairing failed: {} Error: HAP-BLE request failed with status 6     at HapExecutor._getResponsePayload (...homebridge-ranger/src/hap/HapExecutor.js:143:13)     at HapExecutor._executeCommand (...homebridge-ranger/src/hap/HapExecutor.js:72:34)     at ...homebridge-ranger/src/hap/HapExecutor.js:40:24 [10/27/2020, 6:56:29 PM] [Ranger] Failed pairing attempt #1, waiting 1s and trying again.

Yes we are at the same place.  My guess, but I have no evidence of this, is that M2 is not being parsed correctly leading to an incorrect M3 being sent.  My next step was going to be debugging those steps, but I would first have to learn SRP etc.

Found an official HAP-Specification from Apple, I suppose it could be helpful for further development - https://github.com/NRCHKB/node-red-contrib-homekit-bridged/raw/master/docs/HAP-Specification-Non-Commercial-Version.pdf

I wonder about that cause the code didn't change for "years".

PS: Not able to pair my EVE Energy again.

I'm a bit confused now. I set up homebridge 0.4.53 with node 9.11.2 and the original grover ranger.
But Pairing is still not possible?
[2020-10-29 21:55:47] [Ranger] Pairing failed: {} Error: Failed to establish connection to the device
at HapExecutor._establishSecureConnection (/usr/local/lib/node_modules/homebridge-ranger/src/hap/HapExecutor.js:187:13)
at
at process._tickCallback (internal/process/next_tick.js:182:7)
[2020-10-29 21:55:47] [Ranger] Failed pairing attempt #1, waiting 1s and trying again.

@palasinio - possibly related to hardware...

[2020-10-29 22:17:12] [Ranger] Received pair verify response for M4
[2020-10-29 22:17:12] [Ranger] <Buffer 02>
[2020-10-29 22:17:13] [Ranger] Disconnected from MINITOWER
[2020-10-29 22:17:13] [Ranger] Failed to establish secure session to MINITOWER. Reason: Failed to establish secure session.
[2020-10-29 22:17:13] [Ranger] Pairing failed: {} Error: Failed to establish connection to the device
at HapExecutor._establishSecureConnection (/usr/local/lib/node_modules/homebridge-ranger/src/hap/HapExecutor.js:187:13)
at
at process._tickCallback (internal/process/next_tick.js:182:7)
[2020-10-29 22:17:13] [Ranger] Failed pairing attempt #1, waiting 1s and trying again.

I will take a look if I will run into the same issues like @poldueta @ejgeiger.
Anyway, many thanks for the input.
Good night
Jan

Just had the same problem as @ejgeiger and digged into debugging. I was able to reproduce the same error messages after the replacements in PairSetup.js from @ejgeiger

For the type error I found that changing line 43 in PairSetup.js to:
this._params = srp.SRP.params['3072'];
fixed that error. Then I changed line 104 to
this._srp = new srp.SrpClient(this._params, this._salt, identity, password, this._key);

Thanks to @poldueta and the attached HAP spec I just found out that the used HAP hash function is of type SHA-512.  This leads to following code adaption in PairSetup.js line 43
this._params = srp.SRP.params["hap"];

After this change, I was able to pair my eve thermo as shown below (pairing result was removed manually)
[3/7/2021, 8:58:43 PM] [Ranger] Device is not paired yet, pairing now.
[3/7/2021, 8:58:43 PM] [Ranger] Returning pairing request for M1
[3/7/2021, 8:58:44 PM] [Ranger] Received pairing response for M2
[3/7/2021, 8:58:44 PM] [Ranger] Returning pairing request for M3
[3/7/2021, 8:58:48 PM] [Ranger] Received pairing response for M4
[3/7/2021, 8:58:48 PM] [Ranger] Returning pairing request for M5
[3/7/2021, 8:58:49 PM] [Ranger] Received pairing response for M6
[3/7/2021, 8:58:49 PM] [Ranger] Pairing result:
{"rangerPairingID":"...","rangerLTSK":"...","rangerLTPK":"...","accessoryPairingID":"...","accessoryLTPK":"..."}
[3/7/2021, 8:58:49 PM] [Ranger] Pairing completed.

Used versions
Homebridge v1.3.1
Node.js Version v14.16.0
Npm Version v6.14.11

@horge Damn! Nice find. I managed to pair an energy, but not a thermo, yet.

Nice to hear that the energy is working now :)
These are the thermos I‘m using
Model Eve Thermo 20EAR1701
Firmware revision 1.2.11
Hardware revision 1.0.0
@palasinio could you provide the log of a failed pairing process of your thermo?

@palasinio could you provide the log of a failed pairing process of your thermo?
Hi, thx, I‘ll try to investigate a little more. I was not able to install Ranger with NPM 7 on Node 14.
Then I had trouble with "ed25519": "https://github.com/pokt-network/ed25519.git".
It took me (simple user;)) hours to get Ranger up and running again.
But I can say now, it’s running with node 12 and 14 and it can pair again.

For now (I‘m using Raspberry Pi 3 and 4) it seems to work with Homebridge 1.25 but not with 1.3x.
I get „your plugin is slowing down homebridge“ messages with hb 1.3x.
„Ciao“ or „Bonjour HAP“ makes no difference.
Eve Energy is working now (pairing and historical data).
Will try to unpair and pair Thermo next time.

@horge @ejgeiger:
here: sudo npm install -g --unsafe-perm palasinio/homebridge-ranger
I added your fixes. Pairing seems to work again - in my case EVE Thermo is only working with HomeBridge =< 1.2.5.
Homebridge: 1.2.5
Node: 14.16.0
NPM: 6.14.11 (had trouble /w 7)
[18.3.2021, 22:57:30] [homebridge-ranger] This plugin slows down Homebridge. The read handler for the characteristic '' was slow to respond! See https://git.io/JtMGR for more info.
Big THX! This is a great step forward.


Support for commenting functionality

Let users add comments to the report if the layer has a related table. This is a config option. User will have to select a layer and select a text field to store the comments.

[ ]  Allow for anonymous usage/comments - config option (add warning when no features exist)
[ ]  Field picker option
[ ]  Add an option to support images in the comments
[ ] Show the first five comments, and users will click a view more button to show the next 5.

@skrishn

As mentioned above we need to support only one field comment?
Confirming this, as in the previous version we had an option to comment using the configured popup i.e. 'Display comments using the popup configuration of the related table layer'. If we need to support this then we can make use of FeatureForm in 4.x and directly use the editor widget to add the comments

Please confrim.

Select a layer and select a text field to store the comments

Previously we used to select a single field for commenting for the whole application, now we will choose a comment field for individual related table layers - Please confirm if our understanding is correct.
Also, this selected field will be used to show the comments in the list

Add an option to support images in the comments

Will this option be configurable or do we need to support attachment if the table hasAttachments
Also do we need to support multiple images with comment?
If we are using Editor widget this will be handeled easily

Comment order - by default comments will follow same order as reports i.e. reverse order of Object ID.
Also similar to report submission message we also need comments successful submission message and error message

@sumitzarkar

Previously we used to select a single field for commenting for the whole application, now we will choose a comment field for individual related table layers - Yes comment field is configured through app config, but we would like the feature form if layer is configured.
This selected field will only be used to show the comments in the list - I'll confirm
Support if layer hasAttachments
Show images in comments
Also similar to the report submission message we also need comments successful submission message and error message:_Will update you next week on this.
Show the first five comments, and users will click a view more button to show the next 5: Your understanding is correct
Comment UI - Will get back.

@sumitzarkar I talked with Chris, and here are a few additional details on the commenting functionality. Please let me know if you've any questions.
We'd like to show the configured pop-up. Although it can take up a lot of space, what if we show it so it is similar to the list of reports, where you see the pop-up title of the comment and then you can select it to view the full pop-up.  Also w/ regard to this, config option in the app to select a comment field doesn't makes sense anymore, so I will request the designer to remove it. If commenting is enabled, and it would need to check that the layer has a related table and that the related table is in the map.
Strings to use after submission:  "Comment submitted" and "Comment not submitted."

@skrishn
We will check the feasibility and let you know.

From sumit
"Regarding comment functionality, you mentioned about showing logged in user images.
of showing list of comments using popup title we will not have this option, please confirm

when we get any feature we just get created by info, we are not sure if we will be able to get images for each user. using Arcgis portal api we can get details of the loggedin user in which we can get the loggedin users image but not sure about getting images of the users using just the username.
It would be helpful if we get any thoughts of API team on this"
@sumitzarkar I'm waiting to hear from the API team

@skrishn
Dev Checklist

Items
Is required
Status
Comments

Required NLS changes?
Yes

Required Backward compatibility
No

Required 508
Yes

Need Sanitize?
No

Impact Analysis Report

Impacted Areas
Comments

Have Configuration changes?
No

Have Runtime changes?
Yes

Impact on RTL
Yes

Impact on feature details panel
If the comment option is enabled in the config and the related table is present in the map then comment functionality should work as follows:

Comment icon should be displayed with present comments counts below the feature details and beside the like and dislike buttonsComment list should be shown below the comment, like and dislike buttonsIf comments count is more than five then pagination should be displayed below the comments listComment button should be shown below the feature list to add the new comments

Comment Functionality

On clicking an individual comment from the comment list, the comment details panel should be displayedOn click of the comment button, the comment form should be displayed with fields from the related tableAfter filling mandatory fields and clicking the submit buttonIf form submitted successfully then The success message should be displayed The feature-details panel should be displayed with the updated commentsIf form submission failed then failed message should be displayed

@sumitzarkar I noticed that the comment popup displays all the fields instead of honoring the ones that are configured in popup. Once a comment is submitted, it displays only the configured fields in the popup.
https://crowdsource.mapsqa.arcgis.com/apps/instant/reporter/index.html?appid=fd3796ced02d483d9fa6b6a39971a44f

Map https://crowdsource.mapsqa.arcgis.com/apps/mapviewer/index.html?webmap=47df7cc3aa46499aa2c51c2b627ceae7

@skrishn

The fields while editing are controlled using the Form and not the popup.
Fileds listed in the popup are only to show the popup details where as the Form needs to be configured to control any fields visibility while editing.


pastclim not compatible with the latest terra on CRAN 1.6-41

terra has changed the way it reads times from netcdf file. This change impacts a number of the functions in pastclim. We will soon update pastclim, but don't update terra for the moment. Use the commands on the website to downgrade terra if you have an udpated version.

Fixed by 1ef0a25b613ec80262cb373f66340a37090af1c0 in dev


Standard preset + skip menu not working

As the title says, i set the variables on modpackConfig as Standard = Principal (name of my preset) and the skip = true, and while the skip does work, it doesnt use the preset as it says, i tried several ways besides just that, taking out the .json of the name, or placing in the folder of the default presets but it doesnt work anyways.
Mods: BepInEx - InputUtils - AdvancedCompany

This should work now :)


Why does disconnection occur in the figure? I think there is time in the http return value

What did you do?

Why does disconnection occur in the figure? I think there is time in the http return value
What did you expect to see?
No response
What did you see instead? Under which circumstances?
Why does disconnection occur in the figure? I think there is time in the http return value
System information
No response
Prometheus version
2.25.1
Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

Thanks for your report. It looks as if this is actually a question about usage and not development.
It makes more sense to ask questions like this on the prometheus-users mailing list or our forums rather than in a GitHub issue. In our community channels, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.


Investigate longer initialization time when opening an editor screen for the first time

Title says it all

The longer initialization time seems to be due to 2 things:

The texture loading and caching,
The MVC initialization.

To make the first screen loading time quicker, I've made 2 improvements:

Preload the textures,
Setup and render a blank item editor screen.

For Fabric, it's done during client resource pack reloading. For Forge, it's done at game initialization.
I'll keep this issue open but it already seems to have reduced the first screen opening delay by a lot.


Complete units integration with Fluent API

When the APIs are complete, fully integrate the Python code, and complete the testing.

@hpohekar @cj-hodgson We will test primarily settings API in the first instance. There is also scope to test the "datamodel" apps but we might not have the relevant integration to test.


Dynamic datepicker instannces

I have a datepicker sitting inside a ng-repeat. So the suer could ad as many rows as they like. All the examples I have seen form multiple datepickers only show if you have two and the solutions dont work when applying them to a dynamic situation.
Please any guidance on this will be much appreciated.

This forum is reserved for reporting issues, please use stackoverflow for implementation questions.  See the Support section here


Contributivity

Integrate contributivity works and methods into the framework.

Work is in progress on contributivity workgroup (see dedicated repository). A library is being set up, already offering 8 to 9 different calculation methods, but no findings have been shared at this stage.
The working group on contributivity will start thinking about a potential integration in the framework and about the right layer to integrate the different works done. In particular, one possibility to explore would be on the generation of compute plans.

Ok, so here we go for some thoughts on that one:

What we call "contributivity" is a measurement of how much different partners and their respective datasets have contributed to the performance of a model that has been distributedly trained on these datasets
The baseline measurement approach is the computation of the Shapley value for each dataset, assuming the characteristic function attributes to a given set of partners the performance of the model trained on the datasets of these partners. It has all the good properties, however it is not viable computation-wise (exponential). As such, most approaches are in fact approximations of Shapley. They all rely on being able to compute the performance of the model trained on subsets of the partners and their datasets (see dedicated MPLC project for more information)

Note 1: the Shapley approximations studied this far are all based on sampling  and optimizing the sampling of certain subsets. They are relevant in use cases with significant numbers of partners (e.g. x100+). In our cases, they aren't really applicable
Note 2: on the other hand, Shapley is OK up to 3 or 4 partners. So, we kind of have a gap for 4 to 100 partners

Other types of approaches, not based on Shapley, are being contemplated and tested, including approaches based on:

model ensembling (also Shapley-based, but with a different characteristic function requiring many model aggregations)
measuring performance increments after each local minibatch
reinforcement learning (DVRL / PVRL)

If we now explore what it would mean to integrate some of this with Substra:

For Shapley:

We need to be able to train models on subsets of the available partners, test them to get performance figures, and in the end do some computations on all those performance figures. This could accomplished "manually", meaning registering dedicated compute plans for each model training and testing, fetching the performance figures, and doing our final computations of the Shapley value manually
To go one step further we could actually design a large complete compute plan, encompassing all models training and testing that are needed
To really automate it, a final task in the large compute plan could be a traintuple that executes the computation of the Shapley values, using as inputs the performance figures from the past testtuples of the compute plan. This would not require training on a dataset, so this would be an "edge use" of a traintuple, just executing a script.

For the federated step-by-step increments:

In this approach, after each local train on a mini-batch, we do a performance test and save the performance figure. After the whole training is completed, we take all those performance figures and compile them
So the high-level analysis of how to spin this on a multi-partner Substra setup is similar to Shapley above: we would need to carefully design a large compute plan encompassing all train and test tasks, and in the end have a final task to launch the script that compiles all performance figures in a synthetic contributivity values

For model ensembling:

Here again it should be similar. The only specific aspect is that we need to be able to aggregate individually trained models

For DVRL / PVRL: requires more work, these approaches are complex and I don't properly understand yet how they work

Update from last MAP committee (10/09/2020):

Work is in progress on contributivity workgroup. The package already offers 8 to 9 different calculation methods. No large benchmark done and no findings shared yet
It seems possible to design a large compute plan with all the train and test tasks needed to run certain contributivity measurement methods
Interesting next steps:

quick review of first thoughts by Camille to see if Eric’s first thoughts are coherent
Include in Arthur’s internship roadmap to work on a “PoC” of a simple contributivity measurement approach on Substra
Identify another dataset in order to have other data / thoughts

You wanna join the discussion? You can join the public channel Slack #workgroup-mpl-contributivity and participate in the discussions and the dedicated repos.

Closing stale issue.


chore: fix broken ESLint

This is supposed to fix the ESLint error that I'm getting. @andr9528 please confirm that Prettier does not complain after checking out this branch in your environment

I still get the errors that the commit were to fix. However it is more important that it works for you than me, as i do very little work on Sofie projects.
For the history of the error in question. It gives the same error on all lines on all open .ts files. The error can be seen below.

Switching branches does not seem to make line ending change if there were no other changes in these files, but a fresh clone of develop should have correct line endings from now on.


Can i use tilestache+mapnik to build .mvt  and use it in android by offline model

Yes, though that'd be a bit complicated to setup. Alternatively you could use another function of TileStache to fetch tiles for a region, or if that produces too much load on the service you could stand Tilezen up yourself.


Changing orientation in media detail view resets fragment_media_detail

Changing orientation while viewing a file shows the template fragment_media_detail

Uh, wow. Good find, lol.

Had a deeper look, caused in MediaDetailFragment.java#L131. Normally, media is never null, however when onCreateView is called after orientation change it is for some reason.
index is the same regardless of how onCreateView was called, so it has to be something about detailProvider

Some more information for troubleshooting, when onCreateView is called normally, getTotalMediaCount returns 468 (the number of files I have uploaded). When called from orientation change it returns 0.


Fix statcache in FileCache

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
#20300

fix  #20300

Thank you!


Add array to docs of ResponseFactory::redirectToAction

Aligns the types with the underlying Redirector instance.

Wow, I think I never got a PR merged faster than this one 🔥


let gradle link es sources, not compiled class files (at least for main sources)

so development is easier.
idea or the gradle idea plugin are not able to link different configurations of module dependencies, unfortunately.
so we only can link to the main sources, not the test ones

ack


Publish to NPM

Move build dependencies back to devDependencies.
The build is now a prepublish step, not a postinstall step since the build will be supplied with the package when installed.
Use travis-after-all to deploy to npm only after all tests pass in all Node environments.
Only release non-PR builds for master and develop branches. For convenience, these branches are defined in the Settings panel for the repo in Travis. This way builds can be rerun without a new push with different values for these vars (e.g. if the token needs to change or a release should happen outside of the normal release branches)
Since this happens in after_script, we can't use Travis's built-in npm deployment. So create an .npmrc for authentication for npm publish.
Publish versions with the package.json version + "-", e.g. 0.1.0-93d2f. This allows us to deploy every push to GitHub without considering version bumps. This is intended to be a temporary solution until we have more systematic releases.

I didn't attempt to publish the playgrounds to gh-pages because the uncompressed versions require the closure library. If there's a way to avoid that setup, then I'd be happy to give it a go.

👍


Performance tests are poor

Using fishie and fishbowl HTML5 performance results are poor
https://testdrive-archive.azurewebsites.net/performance/fishbowl/
https://testdrive-archive.azurewebsites.net/performance/fishietank/

Any screen or comparison to other browsers ? I tried the 2 tests and non of them works on any chromium based browsers.

Any screen or comparison to other browsers ? I tried the 2 tests and got same result on most chromium based browsers on Android .任何屏幕或与其他浏览器的比较？我尝试了2个测试，并在Android上的大多数基于铬的浏览器上得到了相同的结果。

The official version of google chrome is like this, but there should be ways to improve this problem, such as lemurbrowser.
It is also possible to use Firefox. Is the performance of chrome inferior to Firefox on Android?

In terms of speed Chromium has always won both desktop and Android. Overall Chromium based browsers if well optimized are more performant than Firefox browser. Currently based on daily use I find Kiwi smoother than Firefox on my 2 smartphone

If you can show us some screen or context of why the performance are poor. What device you have ? ( yes it matters the specs and have a role on the performance ) , do you really find Kiwi slower compared to other browser?, if yes how worse it is and etc

If you can show us some screen or context of why the performance are poor. What device you have ? ( yes it matters the specs and have a role on the performance ) , do you really find Kiwi slower compared to other browser?, if yes how worse it is and etc

Those two URLs were used by Microsoft to test the performance of html5 in the early days. I don’t know if it will affect the daily performance. This test can be done at 60fps on the desktop version of chrome. Does this involve the performance of the Android version of chrome gpu acceleration? , if you think my question is irrelevant, then just pretend it doesn't exist


Use Authorization header for HTTP Basic

This plugin started to use the header Authentication instead of CURLOPT_USERPWD a few days ago which broke downloading from HTTP Basic protected sources. This PR changes the header used to Authorization which is what HTTP Basic actually uses :)

Thank you!

tagged 0.1.18


how to read from audiopipe while it's streaming

how to read form this pipe? write to file or whatever https://audiopipe.suno.ai/?item_id=

did you ever figure out how to do this? especially via python


[FLOC-3276] IProfiledBlockDeviceAPI implementation for EBS driver

First step in enabling Storage Profile functionality on EBS. Allow EBS Flocker driver users to create volumes with gold/silver/bronze profiles.

Excited to see this feature happening.
Some minor cleanups, some suggestions about reducing tests, and some questions about error handling. Address and resubmit.

Thanks a lot for the quick review, @itamarst !

Delete a few tests.
Create an additional interface-specific test(s).
One optional error handling task that should be done either here or in followup.

Address and resubmit, and I'll try to do next review as soon as it's up so you're not blocked.

Can someone verify this PR?

A couple of minor comments.
Buildbot is red for relevant storage driver tests. Might just be coincidence, but make sure it's all green.

Then merge. Thanks for all the work on this in between PoC meetings!

Finally got a green run of the tests 3 days later, so I'll be merging this.


Type parameter of mapped type widened to 'string' when using 'keyof any'

TypeScript Version:  4.0.5

Search Terms: "keyof any", "mapped types"
Code
type MyMappedType = {
  [K in keyof any]: {key: K, value: string}
};
let myMap: MyMappedType = {
  "apple": {key: "orange", value: "delicious"}
};

Expected behavior:
I would have expected the code to raise error TS2322 Type '"orange"' is not assignable to type '"apple"'., as done by the following code:
type MyMappedType = {
  [K in "apple" | "orange"]: { key: K, value: string }
};
let myMap: MyMappedType = {
  "apple": { key: "orange", value: "delicious" }
};

Actual behavior:
No error.
Playground Link: https://www.typescriptlang.org/play?#code/C4TwDgpgBAsiMEMyQCYBVzQLxQN4CgooBtAaSgEsA7KAawhAHsAzKBKkAXQC496RepADRQAbggA2AVwi8AzsABO1AOYBffGoDc+fBIjAoAW3hJecRMgjpMUHASIAiJGH2Peufr0eNF7FRCOIuLSslCOKBASFADGFIxSco4a2kA

I don't know what to say except that your expectation isn't correct. It's effectively the same as writing
type MyMappedType = {
  [K: string]: {key: string, value: string}
};

There isn't a way from a nongeneric declaration to enforce a key-value match like that; that isn't what the syntax you have there means.

Thank you for your reply! Just to be sure that what I mean came through, I'm talking about widening of K on the right (ie in key: K), not on the left (ie in K in ...). I agree that keyof any is simply string, no questions there. However, there is clearly a difference in behaviour between the first and second code example in the original filing, in the sense that the second code example is not the same as the following code example:
type MyMappedType = {
  [K in "apple" | "orange"]: { key: "apple" | "orange", value: string }
};

The second code example in the original filing has an additional static check that ensures that the key field in an object literal matches the property name, while the example with keyof any does not, despite the sole difference being the replacement of keyof any with "apple" | "orange". Perhaps this is a feature request then?

@sg495 you can do something like this:
type Validate<T extends Record<keyof T, any>> = {
	[K in keyof T]: {key: K, value: string};
}
function validate<T extends Validate<T>>(obj: T): T { return obj; }

let myMap = validate({
  "apple": {key: "orange", value: "delicious"},
  //        ~~~ Type '"orange"' is not assignable to type '"apple"'.(2322)
  "banana": {key: "banana", value: "yuck"}
});

I'm not sure if there is some conditional trick to do this without the no-op function.

Thank you, @AlCalzone: that's a neat solution 👍. However, I'm still wondering why the difference in behaviour when keyof any is used...

I mean: it has been marked as "Working as Intended", but I am not really convinced it is actually working as intended. The example given by @RyanCavanaugh as being "effectively the same" as the mapped type I used in my original filing does not quite follow the same pattern (as I discussed in a previous comment). It would be good to have the points I raised clarified before this is abandoned.


With custom grid drag and drop enabled. Can't see view in android app.

With "type: custom:grid-dnd" in lovelace yaml file the view does not show up on the home assistant Android app. Once remove you can view it again.

Same for me on iOS. If I don’t resize or move any cards, I can still use it on CompanionApp.
Maybe all the extra information on the raw text makes it unreadable

@msauto @zsarnett I have read the documentation and is aware of that. I just wanted to try to be a part of an eventual solution. I know that is is not a bug but consider my remark as a feature request

All good. Mobile-Friendly in the Known issues refers to the drag and drop part. THe view should still render the cards, not in Edit mode

Well it doesn't on the iOS Companion App, so maybe it is a bug anyway. As I mentioned earlier. When you include custom:grid-dnd and don't move or resize anything, I can see the view on the app. But when I begin to move and/or resize I only get a view with my badges but no cards.
And thank you for your efforts. Is is and will be a very important step to make the Lovelace UI more user-friendly :-)
/Lars

Can't see the view on the Android Companion App either. For the drag&drop part, there need to be something like a small "hold" option, so that after 1 sec, the card will vibrate or something so you can drag/drop it. The same way as in the menu when arranging menu items, but then with a little longer press?

Ok. New observation. I accidentally turned my iPhone 12 to landscape mode and suddenly I could se the cards on views with Drag&Drop installed. When I turned back to portrait, the cards remained on the view.
Refreshing the screen in portrait mode and the cards disappeared again. In portrait mode the views are shown in panel mode in landscape mode the cards are shown side by side. Could that help in diagnosing the problem?

Ok. New observation. I accidentally turned my iPhone 12 to landscape mode and suddenly I could se the cards on views with Drag&Drop installed. When I turned back to portrait, the cards remained on the view.
Refreshing the screen in portrait mode and the cards disappeared again. In portrait mode the views are shown in panel mode in landscape mode the cards are shown side by side. Could that help in diagnosing the problem?

Nice catch there, got the same behavior on Android.

And if you reduce the screen-view to 50% the cards will show side by side in portrait mode. I bit difficult to see the text, though :-)
So it is definitely a problem with the apps using panel mode

@Bluhme1: Wow, that is so cool. I was able to recreate it on Android. When dashboard is viewed in "Portrait View" I get blank screen, but when viewed in "Landscape View" the dashboard cards appear. Great find!!
I have also noticed, that when I have multiple "views" in my dashboard, then I can only use the "Custom-Grid-View" functionality on the first view. All others don't have it. It follows then, that only the first view of the dashboard is not visible on android phones in "Portrait View" as the mod only prevents the first view from appearing.

Hello, any updates on this? Would be great if it was solved


Link to github from website

I didn't see one...

https://github.com/cyclejs/cyclejs/tree/master/docs

I meant that I didn't see a link to GitHub in the website.
Something like a "star this".
On Wed, Feb 22, 2017, 20:28 André Staltz<EMAIL_ADDRESS>wrote:

Closed #530 https://github.com/cyclejs/cyclejs/issues/530.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cyclejs/cyclejs/issues/530#event-973052793, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAmyx9BgO87J0t6m-fhAJRUeIJwIPKYDks5rfH4vgaJpZM4MI-eK
.

Ah right. This was fixed already but needs to be redeployed so Github gets it.


Fix glitch in documentation for the split operation.

The documentation for the indices_or_sections argument appeared twice.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9c675a9) 79.34% compared to head (e3a613a) 56.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18848       +/-   ##
===========================================
- Coverage   79.34%   56.01%   -23.33%
===========================================
  Files         336      336
  Lines       34710    34710
  Branches     6845     6845
===========================================
- Hits        27540    19443     -8097
- Misses       5588    13793     +8205
+ Partials     1582     1474      -108

Flag
Coverage Δ

keras
56.01% <ø> (-23.19%)
:arrow_down:

keras-jax
?

keras-numpy
56.01% <ø> (-0.01%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update 1-premierleague.txt

Hi, I'm new here please check this pull... also I'm not sure what is another bracket after results i.e. 2-0 (0-1). Can someone explain this. Thanks.

Looks good. No worry. Thanks for the update and your effort. Note: The latest season, that is, 2020/21 now gets auto-updated once a week (it's still experimental).  Keep it up. Cheers. Prost.

what is another bracket after results i.e. 2-0 (0-1)

2-0  is the full time (ft) score (90 mins)
(0-1)  is the half time (ht) score (45 mins)

Ohhhhh I see thanks! I will do better next time.


Don't use StringReader in HtmlConverter as calls to read have unneces…

While profiling K-9 Mail on some older devices, I noticed that the performance of HtmlConverter was unexpectedly poor, regardless of whether it took the regular or simple conversion path. It turns out that StringReader#read acquires a lock internally, which is both unnecessary for the conversion, and adds quite a bit of overhead as it occurs once per character.
I replaced it with an for loop and index that essentially does the same thing as StringReader, minus locking.

thanks. don't know what the original intention to use a reader was here, it is indeed pointless.