Sprint 1 - Review and Demo

Review each objective for successes, failures, and next steps.  Document your findings here

For the Chamber, there were a lot of successes and it helped tie the whole build together. The dimensions worked well with the claw from the outtake as well as the Ramp coming in. For the future it would be good to add some tolerance and space for the sample so that it could be easier to transfer from the ramp into the enclosed box. Since the trapdoor is going to be edited in the next iterations, it will still undergo a couple changes, but the overall build of the idea has been working well.

For the overall intake there were many challenges but also a lot of accomplishments! We started off with an intake that would flip both the chamber and the ramp to go over the barrier and we had made a functional design that connected the pick up, transfer, trapdoor, and outtake; most components had been printed out and tested in person with some success! but after some consideration of the design, near the end of the due date, we ended up deciding on only turning the ramp since it would help with mounting motors and being able to manage the weight being flipped and manipulated. Because of this change in idea, we unfortunately have to change a many components, which means that the intake had not been finalized in the past 2 weeks. But we mean to implement the new changes into CAD and printing them out to find more areas of improvement in the next couple of weeks.

Trapdoor:
Successes:

The mechanism worked smoothly
Sample stopper on the inside helped keep it centered despite it's longer length
No interference with claw coming up

Failures:

The intake is changing (the chamber is no longer rotating), which has reduced the need for a trapdoor
The way the rubber band tensioner was mounted was not ideal

Fragile

Placement prevented optimal direction of force (too close to point of rotation)

Next Steps:

Redesign the trapdoor

Potentially just have one smaller flap (the one closer to the entry point of the sample) and remove the second flap

Honestly, in terms of next steps, just removing one trapdoor technically works, and it can be optimized from there. However, as the chamber gets updated, the trapdoor may be further updated as well. There have been discussions of widening the chamber, which would be easy to update. Additionally, the trapdoor has to be created in a way so it doesn't block the sample from actually entering.

pick up
Successes

made a mounting for the servos
made only the ramp move up and down and not the chambermade
a new design that fixed a lot of the mounting issues we had
found a way to mount the servos to the sliders

Failures

had to redo intake because of some issues with flipping the channel and ramp.
The ramp was too thin and too short.
had  issues with mounting the motor with the old design

Next Steps:

The next step is to find out how to move the spiny things with a motor.
Make the ramp longer so it would not vary steep when going over the barrier.
Finish the mounting with the motor.

###Hang/Hook Design
Success:

Created a functional design for robot to safely hang from
Designed a simple yet effective way of mounting the custom hook to the sliders
Found and developed a way to ensure the robot does not fall as a result of swinging/pendulum motion that could result in the hooks sliding off the pole.

Failures:

Did not consider the mounting/placement of the hooks relative to the entirety of the robot (how it would like relative to drivetrain, 3 stage sliders, etc.)
While the design is secure and reliable, it is not the most efficient for the drivers in comparison to other designs (such as the ladder design that was only slightly explored/developed), as it requires more movement and precision from the drivers.
Since the design uses rubber bands for the one way trapdoor, it is possible they snap/break and require fixing, which can be tedious and unnecessary during competition.

Next Steps:

Create the sprint 1 design into real life and limit test for possible flaws/improvements (Strength of trapdoor, strength of overall hook design, limit of weight the hook can support, etc.)
Look into ladder design as a possible upgrade (3D print it and compare to original design to determine which is more effective as both a method of hanging and as an easy task for drivers to complete)

Claw/arm
4th claw CAD design worked after printing and was proven to be able to accomplish all tasks.
Pros

was able to complete all objectives

Cons

integrity and repeated use in question
partial ply within parts (fixed with tweaking


SPARK-24804 There are duplicate words in the test title in the DatasetSuite

What changes were proposed in this pull request?
In DatasetSuite.scala, in the 1299 line,
test("SPARK-19896: cannot have circular references in in case class") ,
there are  duplicate words "in in".  We can get rid of one.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@httfighter, it's okay but mind if I ask take a look and see if there are some typos like this? I'm pretty sure there are more and it'd be better to deal with them in a batch while we are here.

Find more typos:

Analyze > Run Inspection by Name

Type "Typo"

You will be able to see all typos:

yeah, please avoid PRs that are this trivial, it's just not worth the overhead. But I merged it this time.
Also please read https://spark.apache.org/contributing.html

Thank you for your comments, @srowen @HyukjinKwon @wangyum. I will try to contribute more valuable issues!


After I map those field in form "Classic mode", the autocomplete function still doesn't work.

I have imported the zip file as solution and mapped all those field in form under "Change property" what is the next step to make it work?
Thanks

Hello,
Can you please provide a screenshot and mention where did you get API key from?

Do you mean where I store the Google API key? I just manually typing it.

Everything looks good for me. What browser do you you use? Is it IE by a chance? I have other issue opened where user has issues using control in IE - https://github.com/AndrewButenko/GoogleAddressAutocomplete_PCF/issues/6

I am using Chrome.  For this setup, isn't it if I type the full address in the field, then other field (STREET..CITY) will be auto populated only after I saved record? or it will populate suggestions for me to choose?

That's weird. The way it should work is following:

You start entering address.
Control creates the popup with list of addresses available.
Once address is chosen from the popup it is split between other parts of address without the need to save the record. It should happen inline.

Obviously something is going wrong during initialization of the control.
Can you please open Developer Tools (using f12 key), reload the form and check console for any errors? If errors are there can you please post screenshot here?

I figured out why. Coz I didn't activate the Map java script API in Google. Thanks!


owner: true eror ?

owner: true
Does not work. I have tried to edit the number in the config but I tried the owner feature the response was rejected that my number is not the owner

cek ignya


Baseline Contribution Error

Discussed in https://github.com/google/lightweight_mmm/discussions/105

Originally posted by smmalik98 November 20, 2022
I have been trying to plot the baseline media contribution but it has been failing since one of my media contribution has positive and negative values. This problem started when I reduced the number of columns. Initially my data had 7 media columns and 35 extra features with around 157 rows (weekly data). But now it has reduced to 5 media columns and 15 extra features. I have also added the screenshot of the error that I am getting.
I need help in interpreting what is wrong with the model?

Although I might need a bit more information it looks like one (or some) of your extra features have positive impact through some time followed by negative impact. I think this is not allowed by seaborn in a stacked plot.
Could you confirm that by removing the extra features it works correctly?
It might not necessarily mean anything is wrong with the model but this behaviour looks incompatible with what seaborn expects. We might need to look on a workaround for this scenarios.

The extra features come from economic, weather and covid data. I am trying to develop this model for a subscription product so it is expected that some features will definitely have positive and negative effect on the target variable but I am. not sure which one.
How can I find the features that have such effects?

Thank you so much for quick responses. This was really helpful.


Add Discrete Fourier Transform example

Implements the Discrete Fourier Transform over the input list. Basically, this is the non-efficient version of the Number Theoretic Transform (NTT).
You can verify the correctness of the program by comparing with the Python implementation:
# Adapted from https://www.geeksforgeeks.org/python-number-theoretic-transformation/
from sympy import ntt

seq = [15, 21, 13, 44]

prime_no = 2**64 - 2**32 + 1

# ntt
transform = ntt(seq, prime_no)
print ("NTT : ", transform)

# NTT :  [93,<PHONE_NUMBER>4950239235,<PHONE_NUMBER>9414584284,<PHONE_NUMBER>345090]

Conceptually though, this Miden implementation is closer to
from math import log2

PRIME = 2**64 - 2**32 + 1
TWO_ADIC_ROOT_OF_UNITY =<PHONE_NUMBER>849721926

def get_root_of_unity(n):
    power = (1 << (32 - n)) % PRIME
    return pow(TWO_ADIC_ROOT_OF_UNITY, power, PRIME)

def f_k(seq, k, alpha):
    alpha_k = pow(alpha, k, PRIME)
    return sum([(seq[i] * pow(alpha_k, i, PRIME)) for i in range(len(seq))]) % PRIME

def ntt(seq, alpha):
    return [f_k(seq, k, alpha) for k in range(len(seq))]

seq = [15, 21, 13, 44]
alpha = get_root_of_unity(int(log2(len(seq))))

print(ntt(seq, alpha))

@Dominik1999 Changed the code to follow the comment convention


Component Tabs bugs with controlled mode on first change

Description
When I create a controlled tabs, during the first onValueChange call, I do not change the index and the Tabs.Content unmounts when it shouldn't.
Link to Reproduction
https://stackblitz.com/edit/chakra-ui-v3-o9atp5?file=src%2FApp.tsx
Steps to reproduce

Click on "Second tab"
The text "First panel" disappears when it shouldn't

Chakra UI Version
3.1.2
Browser
Firefox 132.0.2 (latest), Chromium 130.0.6723.116
Operating System

[ ] macOS
[ ] Windows
[X] Linux

Additional Information
Initial render is ok :

Click on "Second tab" (text has disappeared)

https://github.com/chakra-ui/chakra-ui/issues/9203


Publish cat line as PNG

Can you publish a PNG of that horizontal line with the cat, so I can display this over my background? It looks quite nice.

https://raw.githubusercontent.com/catppuccin/catppuccin/main/assets/footers/gray0_ctp_on_line.svg
Already publishhed, and this is definitely the wrong place for this.

Can you publish a PNG of that horizontal line with the cat, so I can display this over my background? It looks quite nice.

As @rubyowo already said, you can download svg. Then just color it. Or just extarct it from Catppuccin for Vivaldi
I defenetely should add this to the FAQ...


Release v0.17.1

[Fix] Update dependencies, remove std/esm warning.

Closes demurgos/turbo-gulp#105
Closes demurgos/turbo-gulp#106

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #107   +/-   ##
======================================
  Coverage    67.1%   67.1%
======================================
  Files          38      38
  Lines         912     912
  Branches       98      98
======================================
  Hits          612     612
  Misses        231     231
  Partials       69      69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a102d3...3923a88. Read the comment docs.


[Autocomplete] List scrolls back up when opening after select option (with virtualization)

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Using virtualization after you select an option and open the options again, it will have scrolled back to the start to the list.
The issue happens even on the docs page, so I wanted to know if this is intended or not.
Expected behavior 🤔
After selecting an option and opening the list again, the list should be at the same position as the selected option, possibly highlighted. That's how non-virtualized Autocomplete seems to act, based on my tests.
Steps to reproduce 🕹
Steps:

Open https://mui.com/components/autocomplete/#virtualization
Select a option after scrolling down a bit
Open the list again

Context 🔦
No response
Your environment 🌎
No response

You can use scrollToItem if you want to have the same behavior. See https://react-window.vercel.app/#/examples/list/scroll-to-item


Failing test suite, Selenium 2.53

Configuration:

OS: Yosemite 10.10.5
Google Chrome: 51.0.2704.84 (64-bit)
Selenium Server: 2.53

When running driver tests in there I have following failures:
There was 1 error:

1) Behat\Mink\Tests\Driver\Js\ChangeEventTest::testSetValueChangeEvent with data set "file" ('the-file', 'from empty', 'from existing')
WebDriver\Exception\UnknownError: unknown error: path is not absolute: from empty
  (Session info: chrome=51.0.2704.103)
  (Driver info: chromedriver=2.21.371459 (36d3d07f660ff2bc1bf28a75d1cdabed0983e7c4),platform=Mac OS X 10.10.5 x86_64) (WARNING: The server did not provide any stacktrace information)
Command duration or timeout: 20 milliseconds
Build info: version: '2.53.0', revision: '35ae25b', time: '2016-03-15 17:00:58'
System info: host: 'alex-mbp', ip: '<IP_ADDRESS>', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.10.5', java.version: '1.8.0_74'
Driver info: org.openqa.selenium.chrome.ChromeDriver
Capabilities [{applicationCacheEnabled=false, rotatable=false, mobileEmulationEnabled=false, chrome={chromedriverVersion=2.21.371459 (36d3d07f660ff2bc1bf28a75d1cdabed0983e7c4), userDataDir=/var/folders/zr/z961h7s124z_qq5s4c4_j4000000gn/T/.org.chromium.Chromium.nXHJDJ}, takesHeapSnapshot=true, databaseEnabled=false, handlesAlerts=true, hasTouchScreen=false, version=51.0.2704.103, platform=MAC, browserConnectionEnabled=false, nativeEvents=true, acceptSslCerts=true, locationContextEnabled=true, webStorageEnabled=true, browserName=chrome, takesScreenshot=true, javascriptEnabled=true, cssSelectorsEnabled=true}]
Session ID: 68f84e17342891af646e900968ac9a26

/path/to/repo-clone/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:155
/path/to/repo-clone/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:140
/path/to/repo-clone/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:200
/path/to/repo-clone/vendor/instaclick/php-webdriver/lib/WebDriver/Container.php:218
/path/to/repo-clone/src/Selenium2Driver.php:669
/path/to/repo-clone/src/Selenium2Driver.php:669
/path/to/repo-clone/vendor/behat/mink/src/Element/NodeElement.php:105
/path/to/repo-clone/vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:50

--

There were 2 failures:

1) Behat\Mink\Tests\Driver\Form\GeneralTest::testAdvancedForm
Failed asserting that '<!DOCTYPE html><html xmlns="http://www.w3.org/1999/xhtml"><head>
    <title>Advanced form save</title>
    <meta http-equiv="Content-Type" content="text/html;charset=UTF-8" />
</head>
<body>
array (
  'agreement' = 'on',
  'email' =<EMAIL_ADDRESS>  'first_name' = 'Foo "item"',
  'last_name' = 'Bar',
  'notes' = 'new notes',
  'select_number' = '30',
  'sex' = 'm',
  'submit' = 'Register',
)
some_file.txt
1 uploaded file

</body></html>' contains "array (
  'agreement' = 'on',
  'email' =<EMAIL_ADDRESS>  'first_name' = 'Foo "item"',
  'last_name' = 'Bar',
  'notes' = 'new notes',
  'select_number' = '30',
  'sex' = 'm',
  'submit' = 'Register',
)
some_file.txt
1 uploaded file".

/path/to/repo-clone/vendor/behat/mink/driver-testsuite/tests/Form/GeneralTest.php:220

2) Behat\Mink\Tests\Driver\Js\WindowTest::testResizeWindow
Failed asserting that false is true.

/path/to/repo-clone/vendor/behat/mink/driver-testsuite/tests/Js/WindowTest.php:82

P.S.
It crashes the Firefox 47 completely. Probably not our driver issue at all.

Behat\Mink\Tests\Driver\Form\GeneralTest::testAdvancedForm is also failing on PhantomJSDriver, so it may have to be changed in the driver-testsuite itself.
Behat\Mink\Tests\Driver\Js\ChangeEventTest::testSetValueChangeEvent is caused by https://github.com/minkphp/driver-testsuite/issues/9
Behat\Mink\Tests\Driver\Js\WindowTest::testResizeWindow should be checked again, as I think the testsuite has changed in the meantime to fix this.
Regarding Firefox, Selenium's Firefox driver supports < 47 and 47.0.1 (47.0.0 is totally unsupported due to being buggy).


Merge in importer.

When duplicate records are found during import, the user has the option to merge the two sets together.  Presently, only works when tracks don't conflict.
This is not the final commit, I'm planning on resolving track conflicts before this is ready for merging.  Before I head down that road though, I'd really like my work double-checked (@sampsyo).  This project is impressively large, I did my best to understand this portion, but I'm not sure if I'm abusing the database or pipeline or something.
Cheers!
P.S. Related to issue #112

@sampsyo a few questions:

In for the unittests, I wanted to test merging against an album with multiple tracks.  Making a list of a couple TrackInfo objects only seems to ever have the first one picked up, why?
I'd like to also allow for interactive merging, where two albums contain overlapping parts of each other.  My first thought is to compare the track ids, would you agree with this approach?  Would mocks be the proper way to unittest such interactions?
I'm not sure why the builds are failing on test.test_mb.MBLibraryTest.test_match_album.  It built fine when I committed last weekend, but not this weekend?  All 37 tests in test_mb.py pass on my machine.
I see you're running AppVeyor in addition to Travis CI.  What do you think of it?

Hi! Thank you for writing this! It looks amazing, and it fulfills something that many people have asked for. And I'm very very sorry that I didn't get around to this earlier—thanks for your patience while I caught up on the backlog.
I'll review the code now. To answer your questions:

In for the unittests, I wanted to test merging against an album with multiple tracks. Making a list of a couple TrackInfo objects only seems to ever have the first one picked up, why?

I'm not 100% sure what's going on here—are you referring to the new test_merge_duplicate_album_without_duplicate_tracks, but with the commented-out lines commented back in? If so, should I just run that to see what you're talking about?

I'd like to also allow for interactive merging, where two albums contain overlapping parts of each other. My first thought is to compare the track ids, would you agree with this approach?

Is the idea to let you break apart an album and then merge part of it into a new album? That sounds like a rather complex thing to orchestrate. Would you mind terribly much if we left that extension until after we finish this more basic version?

Would mocks be the proper way to unittest such interactions?

Probably—depending on where the user input comes in.

I'm not sure why the builds are failing on test.test_mb.MBLibraryTest.test_match_album. It built fine when I committed last weekend, but not this weekend? All 37 tests in test_mb.py pass on my machine.

That's not your fault, and now fixed. Nothing to worry about!

I see you're running AppVeyor in addition to Travis CI. What do you think of it?

So far so good; it seems to do its job admirably, and it's great that it's free for open source. It's disabled for us, unfortunately, because we haven't gotten all the tests passing on Windows quite yet (#670).

Mad props to udibox1209, making this happen in #2725.


Add Segment SaaS Connector + Authentication per Request  [#251]

Purpose

Adds example support for connecting to third-party infrastructure: Segment + adds the ability to configure custom authentication for individual requests.
Demonstrates end-to-end access request for Segment.

Segment masking will be demonstrated in #354
Changes

Adds example Segment saas config (for annotating how to access Segment endpoints) and Segment dataset (for annotating what fields we have)

Adds GDPR delete request under data_protection_request (needs #325 to work, but this will be tested in follow-up #354)

Currently, we can only set a ClientConfig for the entire SaaSConnector, which contains things like the domain and the authentication strategy to connect to various third party endpoints.  However, with Segment, different endpoints have different domains and authentication strategies (bearer and basic).  Allow setting authentication at the individual request level. We will check if authentication exists at the request level first, otherwise, we'll fall back to the overall ClientConfig set up for the SaaSConnector.
Adds end to end test for access request only

Checklist

[x] Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram)
[x] Good unit test/integration test coverage
[ ] This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
[x] The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket
Uses #328
Fixes #251

For the CodeQL alert, should we at least be including a check to a config var. similar to LOG_PII for connection secrets if we really have to log it?


Support case sensitive file systems

Fixes #238
Neither Node.js nor the VSCode API's support case sensitive file system by default.
I went back on forth on different approaches to handle this but in the end decided to just use a package: true-case-path
Tested on MacOS. I can rename folders and files by just changing the case.

I am sorry but I'm not going to merge this PR. The reason is that I want to keep the use of the native APIs provided by vscode.
Here you are introducing a new library that accesses the system capabilities (file system) without using the API provided by vscode. And I think I can fix the issue #238 by adding a check if it is the same file but change upper or lower-case letters.
Anyway, thank you for your contribution


Enhancement: log duration, not timestamp

When running with -M json (to produce json output), we get something like this:
{
  "Profile": "",
  "Account Number": "XXX",
  "Control": "[extra760] Find secrets in Lambda functions code (Not Scored) (Not part of CIS benchmark)",
  "Message": "us-west-2: Potential secret found in Lambda function connect-api-serverless-stage-custom-resource-apigw-cw-role code",
  "Status": "Fail",
  "Scored": "Not Scored",
  "Level": "Extra",
  "Control ID": "7.60",
  "Region": "us-west-2",
  "Timestamp": "2020-04-11T17:54:25Z"
}

It would be awesome if there was an entry for "duration".

Purely out of interest, what would be the purpose of knowing what the duration of a check is? What would one do with that information?

You bet!  I'm in the progress of converting the json output of prowler into a junit XML file so that Jenkins can consume it.  That way, we can have a nightly job that runs prowler, jenkins consumes it, and then graph the results over time.
I grabbed a random junit XML file and one of the entries that it has is "duration" (which Jenkins logs).
This is really low priority, but here is a screenshot of a jenkins test run (not from prowler, of course, but of some random tests):

And jenkins graphs the results over time, which will give us trends (along with alerting if a particular test fails):

That makes sense to me - I'm quite familiar with Jenkins and JUnit XML files. If @toniblyx would be happy with this feature addition, I think I could put together a PR for it.
Next question to @toniblyx would be: does adding a -M junit-xml option, to add a new output mode which is JUnit XML sound acceptable? Would just be a case of outputting a <testsuites> header and </testsuites> footer, with a <testsuite> for each group and each pass/fail outputting a <testcase> tag

Sound good to me, just adding another output that may be helpful is good idea. Having junig-xml makes life easier for @grayaii to avoid conversions and may help others as well. @marcjay seems to be something kind of easy right? If you can send a PR that would be great :) I'm going to change the issue title as well.

@grayaii It would be great if you'd be able to test the PR for this  - it's the add-junit-xml-output-mode-log-duration-537 branch from #557 - thoughts welcome!


OCaml 4.12 support: Rearrange types to support the new injectivity annotations in Map.S

Currently fpath fails to compile on OCaml 4.12 with:
+ ocamlfind ocamlc -c -g -bin-annot -safe-string -package bytes -package astring -package result -I src -I test -o src/fpath.cmi src/fpath.mli
File "src/fpath.mli", lines 519-520, characters 10-40:
519 | ..........Map.S with type key := t
520 |                  and type 'a t := 'a map
Error: In this `with' constraint, the new definition of t
       does not match its original definition in the constrained signature:
       Type declarations do not match:
         type 'a t = 'a map
       is not included in
         type +!'a t
       Their variances do not agree.
       File "map.mli", line 67, characters 4-15: Expected declaration
       File "src/fpath.mli", line 520, characters 21-40: Actual declaration

This PR simply fixes the issue the same way it was fixed for astring: https://github.com/dbuenzli/astring/commit/ec7a266a3a680e5d246689855c639da53d713428

Thanks your patch is in as 53d316ed01223b3604de13c


Add a logotype

Firstly, nice work! I've been using Gource for some time and tested other dockerized solutions, but I've always had problems with disk space ... until I found Envisaged! 👏🏻 👏🏻 👏🏻
As a front-end developer, I think this project deserves to be more beautiful and a logo could be a good first step. lol

So, I designed this very rational and geometric typography. Ugly or beautiful, at least it is quite exclusive since only the letters E, N, V, I, S, A, G, D were created. 😄

These are some applications from my final version.
If this issue is a success and someone likes the logo minimally to the point that they want to use it, I can open a pull request with some .svg files.
And sorry for my weird English, I'm still learning.

Oh wow these are awesome! sorry for the late response on the issue.... @doomspork what do you think? I really dig the black background with blue and orange!

Wow! Those are rad. @allegretti you're very talented!
@jamesbrink your choice looks good 👍

Thanks @jamesbrink and @doomspork !
I will open a PR soon

So cool! 🤯


D435i memory leak problem

Required Info

Camera Model
{  D400 }

Firmware Version
(5.12.03)

Operating System & Version
{Ubuntu 18.04

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC.

SDK Version
{ l 2.<33>.<1> }

Language
{C++ }

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
<Describe your issue / question / feature request / etc..>
Hi, I am suffer from D435i memory leak problem when I use D435i to capture depth continuously.
Frames object uses cv::Mat to store depth and RGB frames.
Even I delete Frames, release cv::Mat .the video buffer seems still in the memory.
I wonder if the frameSet from pipe.wait_for_frames() or rs2::frame filtered is released automatic and properly . I find release frame method in the frameSet object, it seems to release at end of function. Do I need to release the frameSet manually? and How?
Thx.
part of my code:
  void RealsenseInputSource::simpleFrames(rs2::pipeline pipe, Frames &frames) {
        bool alignedColor = config.alignedColor;
        rs2::align alignToColor(RS2_STREAM_COLOR);
        rs2::align alignToDepth(RS2_STREAM_DEPTH);
        auto depth_stream_file = pipe.get_active_profile().get_stream(RS2_STREAM_DEPTH).as<rs2::video_stream_profile>();
        int width = depth_stream_file.get_intrinsics().width;
        int height = depth_stream_file.get_intrinsics().height;
        auto frameSet = pipe.wait_for_frames();
        if (alignedColor) {
            frameSet = alignToColor.process(frameSet);
        }
        else {
            frameSet = alignToDepth.process(frameSet);
        }
        auto color = frameSet.get_color_frame();

        frames.rgbFrame_ = boost::make_shared<cv::Mat>(new Mat(Size(width, height), CV_8UC3, (void *) color.get_data(), Mat::AUTO_STEP);
        rs2::spatial_filter spat_filter;
        rs2::temporal_filter temp_filter;
        rs2::threshold_filter thresh_filter(0.15,1.7);
        rs2::frame filtered = frameSet.get_depth_frame();
        filtered = thresh_filter.process(filtered);
        filtered = spat_filter.process(filtered);
        filtered = temp_filter.process(filtered);
        frames.internalParams.depthScale = rs2::sensor_from_frame(filtered)->get_option(RS2_OPTION_DEPTH_UNITS);
        int size = filtered.get_data_size();
        frames.depthFrame_ =  boost::shared_ptr<Mat> (new Mat(Size(width, height), CV_16UC1, (void*)filtered.get_data(), Mat::AUTO_STEP));
}

and in ~Frame()
depthFrame_  -> release();
rgbFrame_  -> release();
rgbFrame_  -> reset();
depthFrame_  -> reset();

Hi @cdb0y511   With cv::mat, you can forcibly clear its memory with the deallocate() instruction, though you should not try to use the data of cv::mat after the deallocation.
The link below discusses the differences between deallocate() and release().
https://stackoverflow.com/questions/38328063/what-does-cvmats-deallocate-method-do

@MartyG-RealSense
Thanks, but it seems memory leak  still exists ,even I use  deallocate() instead of release().
Do rs2::frameSet or rs2::frame need manually release?

Resources used by the pipeline can be released by stopping the pipeline with Stop() according to the documentation.
https://intelrealsense.github.io/librealsense/doxygen/classrs2_1_1pipeline.html#a142ee1adb798f9a03f86eb90895dd8a5

Resources used by the pipeline can be released by stopping the pipeline with Stop() according to the documentation.
https://intelrealsense.github.io/librealsense/doxygen/classrs2_1_1pipeline.html#a142ee1adb798f9a03f86eb90895dd8a5

I don't think stop and pipeline is a good ideal. Cause it always takes a few frames to enable auto exposure . The realsense-view never suffer from memory leak. Any advice ?

I did another check of your script and noticed that you seem to be doing alignment first and then post-processing.  The recommended order of operations is to do post-processing first and then alignment afterwards.  This can help to avoid distortion problems such as aliasing (jagged lines).
Also, if you are experiencing slowdown then this may be a consequence of applying alignment and three post-processing filters, which are demanding processing operations that consume CPU resources.  Offloading CPU work onto the graphics GPU can improve performance.
https://github.com/IntelRealSense/librealsense/issues/4905#issuecomment-533854888
If you are releasing and deallocating cv::mat and still have a resource drain, I wonder if it might be instead coming from the aligning and filtering.
https://github.com/IntelRealSense/librealsense/issues/2115#issuecomment-406873087

I did another check of your script and noticed that you seem to be doing alignment first and then post-processing. The recommended order of operations is to do post-processing first and then alignment afterwards. This can help to avoid distortion problems such as aliasing (jagged lines).
Also, if you are experiencing slowdown then this may be a consequence of applying alignment and three post-processing filters, which are demanding processing operations that consume CPU resources. Offloading CPU work onto the graphics GPU can improve performance.
#4905 (comment)
If you are releasing and deallocating cv::mat and still have a resource drain, I wonder if it might be instead coming from the aligning and filtering.
#2115 (comment)
second one solved my problem. thanks
Any other object should not create inside frame stream or  just initialize once?
I aware all filter type should not create inside the frame stream.
I wish to have a notice in the document.  It  may help many developers.

Great news that your problem was solved!
Could you create a new case please just for your documentation request.  Then I can label it so that it can be tracked by RealSense team members responsible for documentation changes.  Thanks.    :)

Great news that your problem was solved!
Could you create a new case please just for your documentation request. Then I can label it and keep the case open so that it can be tracked by RealSense team members responsible for documentation changes. Thanks. :)

Sorry for late reply.
I have opened a new case
Documentation request for memory leak guidance #6471

I have labelled your feature request so it can be tracked.  Thanks!


Support literals in the markdown link fragments

You can make links with unescaped paths using angle brackets. So for example this:
[foobar](<some path/target.md>)

rather than this:
[foobar](some%20path/target.md)

But it would be nice to also be able to unescape fragments. So for example this:
[foorbar](<some path/target.md#some header>)

rather than this:
[foorbar](some%20path/target.md#some%20header)

This is not currently supported. I have been unable to find this specifically called out in the commonmark spec, but at least some md editors/readers support (e.g., Obsidian).

Seems to work on common mark so I'd say we should support it


Would you consider supporting properties files?

Is your feature request related to a problem? Please describe.
I have a properties file that needs to be translated into multiple languages, but I don't want to do it manually. I would like Transmart to support automatic translation of properties files.
Describe the solution you'd like
I would like Transmart to be able to read properties files and generate i18n files for each language specified, using ChatGPT to automatically translate the strings.

Do you have a complete example file or a reproduced app? @longhuan1999

ejbca-ce/modules/admin-gui/resources/languages/

like xx.json or something

I will implement it later, would you send me a sample file (without sensitive content) to my Gmail account for testing


Add CLI tests

Currently we only have pytest unittests for the python package but not for the CLI!

where is the cli documented?

usage > cli.md
https://github.com/souzatharsis/podcastfy/blob/main/usage/cli.md


Change intercept position

Change the intercept(bias) position as the first column. Make bias position consistent for both single-shot and multi-shot. So, the mappings to statistic output table are same for both regressions. Please have a review @swashcap

Looks like we still get Not a Number values:

That might be due to misaligned covariates.

CI is broken due to a strange ESLint configuration error. I do see two broken tests:
$ npm test

><EMAIL_ADDRESS>test /Users/creed/Sites/laplacian-noise-ridge-regression
> nyc --reporter=lcov --check-coverage --functions=80 --branches=80 --lines=70 node test

TAP version 13
# addBias
ok 1 throws with no value
ok 2 throws with non-array value
ok 3 throws with empty array value
ok 4 throws with non-array item
not ok 5 bias adds
  ---
    operator: deepEqual
    expected: [ [ 1, 2, 3, 1 ], [ 4, 5, 6, 1 ] ]
    actual:   [ [ 1, 1, 2, 3 ], [ 1, 4, 5, 6 ] ]
    at: Test.tape (/Users/creed/Sites/laplacian-noise-ridge-regression/test/local.js:54:5)
  ...
# get normalized tags
ok 6 returns normalized array
# preprocess errors
ok 7 throws with no inputs
ok 8 throws with non-array features
ok 9 throws with empty features
ok 10 throws with invalid Freesurfer region
ok 11 throws without lambda
# preprocess
ok 12 sets default eta
ok 13 sets default lambda
not ok 14 transforms files' tags to co-variates in `biasedX`
  ---
    operator: deepEqual
    expected: |-
      [ [ 28, 1, 1 ], [ 29, -1, 1 ], [ 31, 1, 1 ] ]
    actual: |-
      [ [ 1, 28, 1 ], [ 1, 29, -1 ], [ 1, 31, 1 ] ]
    at: local.preprocess.then (/Users/creed/Sites/laplacian-noise-ridge-regression/test/local.js:127:9)
  ...
ok 15 pulls selected feature from FreeSurfer files
ok 16 sets number of features
ok 17 sets eta from user data
ok 18 sets lambda from user data
# local run
gradient: 400,4.001, objective: 4.0005
ok 19 removes unneeded properties
ok 20 adds gradient
ok 21 adds objective
# gradient
ok 22 is an array
ok 23 contains only numbers
# objective
ok 24 is number

1..24
# tests 24
# pass  22
# fail  2

npm ERR! Test failed.  See above for more details.

Cory, when you create a consortium, and add covariates, have you set the
isControl covariate type as number?  In the test data.  isControl column is
[1.0, -1.0], but not [True,False]. So, you must set number type to get
correct input from UI to computation. Then you will get numbers.
On Wed, Feb 15, 2017 at 11:35 PM, Cory Reed<EMAIL_ADDRESS>wrote:

Looks like we still get Not a Number values:
[image: non-a-image]
https://cloud.githubusercontent.com/assets/1858316/23010221/0f9439fe-f3cf-11e6-9ae2-42b78d66ce41.jpg
That might be due to misaligned covariates.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MRN-Code/decentralized-laplacian-ridge-regression/pull/16#issuecomment-280244442,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV1WOO1AXsjc5-vWNhJEt6jn-NO18BqHks5rc-48gaJpZM4MCXQ6
.

--
Jing Ming
Postdoctoral Research Fellow
The Mind Research Network
Lovelace Respiratory Research Institute

This is exactly due to my commit (change intercept position) yesterday.
expected: |-      [ [ 28, 1, 1 ], [ 29, -1, 1 ], [ 31, 1, 1 ] ]
actual: |-      [ [ 1, 28, 1 ], [ 1, 29, -1 ], [ 1, 31, 1 ] ]
see I move the 1 from last component of each row to the first component.
I didn't notice you actually set test for the orders. I can change the
order back. But in that way,
we are going to have two different stats table mapping for single-shot
and multi-shot.
Can we change the npm test script to accept order change? And if npm
test failed, does that mean Coinstac UI wouldn't run?
I suggest you try my suggestion on the data type first to see if you
can get decent statistic output.
If not, let me know as soon as possible.
On Wed, Feb 15, 2017 at 11:36 PM, Cory Reed<EMAIL_ADDRESS>wrote:

CI is broken due to a strange ESLint configuration error. I do see two
broken tests:
$ npm test

<EMAIL_ADDRESS>test /Users/creed/Sites/laplacian-noise-ridge-regression> nyc --reporter=lcov --check-coverage --functions=80 --branches=80 --lines=70 node test

TAP version 13# addBias
ok 1 throws with no value
ok 2 throws with non-array value
ok 3 throws with empty array value
ok 4 throws with non-array item
not ok 5 bias adds
operator: deepEqual
expected: [ [ 1, 2, 3, 1 ], [ 4, 5, 6, 1 ] ]
actual:   [ [ 1, 1, 2, 3 ], [ 1, 4, 5, 6 ] ]
at: Test.tape (/Users/creed/Sites/laplacian-noise-ridge-regression/test/local.js:54:5)

...# get normalized tags
ok 6 returns normalized array# preprocess errors
ok 7 throws with no inputs
ok 8 throws with non-array features
ok 9 throws with empty features
ok 10 throws with invalid Freesurfer region
ok 11 throws without lambda# preprocess
ok 12 sets default eta
ok 13 sets default lambda
not ok 14 transforms files' tags to co-variates in biasedX  ---    operator: deepEqual    expected: |-      [ [ 28, 1, 1 ], [ 29, -1, 1 ], [ 31, 1, 1 ] ]    actual: |-      [ [ 1, 28, 1 ], [ 1, 29, -1 ], [ 1, 31, 1 ] ]    at: local.preprocess.then (/Users/creed/Sites/laplacian-noise-ridge-regression/test/local.js:127:9)  ...ok 15 pulls selected feature from FreeSurfer filesok 16 sets number of featuresok 17 sets eta from user dataok 18 sets lambda from user data# local rungradient: 400,4.001, objective: 4.0005ok 19 removes unneeded propertiesok 20 adds gradientok 21 adds objective# gradientok 22 is an arrayok 23 contains only numbers# objectiveok 24 is number1..24# tests 24# pass  22# fail  2npm ERR! Test failed.  See above for more details.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MRN-Code/decentralized-laplacian-ridge-regression/pull/16#issuecomment-280244517,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV1WOE_-wa3nBIp2wuzipl-zZ5XV9tViks5rc-5bgaJpZM4MCXQ6
.

--
Jing Ming
Postdoctoral Research Fellow
The Mind Research Network
Lovelace Respiratory Research Institute

Leave a comment

when you create a consortium, and add covariates, have you set the isControl covariate type as number?

The data structure supplied by coinstac-client-core (code powering the UI) to a computation looks like this:
{
  "files": [{
    "filename": "/home/coinstac/demo/controls/M00000001.txt",
    "tags": {
      "age": 28,
      "isControl": true
    },
  }, {
    "filename": "/home/coinstac/demo/substanceUsers/M00000011.txt",
    "tags": {
      "age": 29,
      "isControl": false
    },
  }, {
    "filename": "/home/coinstac/demo/controls/M00000002.txt",
    "tags": {
      "age": 31,
      "isControl": true
    }
  }]
}

Boolean-type inputs – isControl in this case – come to the computation as JavaScript booleans. A src/local.js unit test helper function actually tests local methods using this data structure.
The nature of metadata mapping is undocumented, but I find this reasonable: the covariate-style inputs offer two different types:

It’s reasonable to assume number-type covariates enter the computation as numbers, and it’s reasonable to assume boolean-type covariates enter the computation as boolean values.
The separation of concerns works well here: the UI translates a user’s metadata into a useful format, and ensures all users’ metadata is mapped similarly. We don't have control of how users store their metadata. We’ve chosen to create a more flexible, user friendly system instead of mandating metadata shape (-1 and 1 in the isControl column, for example). It’s the computation’s job to modify normalized users’ metadata for use in calculations.
These contracts are unclear because we haven’t had time to document them. 😕

I can change the order back. But in that way, we are going to have two different stats table mapping for single-shot and multi-shot.

I imagine this change is important because it ensures bias is added similar to single-shot.

Can we change the npm test script to accept order change?

Yep! Would you mind updating the tests?

And if npm test failed, does that mean Coinstac UI wouldn't run?

Not necessarily. In this case the UI runs fine, in other cases it means computation runs crash the UI.

have pushed new test to git
On Thu, Feb 16, 2017 at 11:46 AM, Cory Reed<EMAIL_ADDRESS>wrote:

@swashcap requested changes on this pull request.
In src/local.js
https://github.com/MRN-Code/decentralized-laplacian-ridge-regression/pull/16#discussion_r101595954
:

@@ -20,7 +20,7 @@ function addBias(arr) {
throw new Error(Expected every item of ${arr} to be an array);
}

return arr.map(row => row.concat(1));

return arr.map(row => [1].concat(row));

This breaks a tests. Could you update them?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/MRN-Code/decentralized-laplacian-ridge-regression/pull/16#pullrequestreview-22330387,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV1WOKYjVO_ayrV-926EQtWNyudfyVbPks5rdJlogaJpZM4MCXQ6
.

--
Jing Ming
Postdoctoral Research Fellow
The Mind Research Network
Lovelace Respiratory Research Institute

I agree that we should set the isControl column data type as boolean when I
prepare the test dataset. Therefore, we won't have confusion here. But with
the current dataset ( also possible in real world research case),  we still
can run coinstac,  as long as we also treat isControl as number.
Probably I also should update the test data to make isControl column really
boolean.  Should I set it as [1, -1]  or  [True, False] here?
On Thu, Feb 16, 2017 at 11:45 AM, Cory Reed<EMAIL_ADDRESS>wrote:

when you create a consortium, and add covariates, have you set the
isControl covariate type as number?
The data structure supplied by coinstac-client-core (code powering the
UI) to a computation looks like this:
{
"files": [{
"filename": "/home/coinstac/demo/controls/M00000001.txt",
"tags": {
"age": 28,
"isControl": true
},
}, {
"filename": "/home/coinstac/demo/substanceUsers/M00000011.txt",
"tags": {
"age": 29,
"isControl": false
},
}, {
"filename": "/home/coinstac/demo/controls/M00000002.txt",
"tags": {
"age": 31,
"isControl": true
}
}]
}
Boolean-type inputs – isControl in this case – come to the computation as
JavaScript booleans. A src/local.js unit test helper function
https://github.com/MRN-Code/decentralized-laplacian-ridge-regression/blob/5c16c8b9a8db40ca9a6c1d59b6fd72a4babfd7cb/test/local.js#L22-L40
actually tests local methods using this data structure.
The nature of metadata mapping is undocumented, but I find this
reasonable: the covariate-style inputs offer two different types:
[image: so-very-covariate]
https://cloud.githubusercontent.com/assets/1858316/23035739/02d66956-f435-11e6-8216-cb12b4e2ae27.jpg
It’s reasonable to assume number-type covariates enter the computation as
numbers, and it’s reasonable to assume boolean-type covariates enter the
computation as boolean values.
The separation of concerns works well here: the UI translates a user’s
metadata into a useful format, and ensures all users’ metadata is mapped
similarly. We don't have control of how users store their metadata. We’ve
chosen to create a more flexible, user friendly system instead of mandating
metadata shape (-1 and 1 in the isControl column, for example). It’s the
computation’s job to modify normalized users’ metadata for use in
calculations.
These contracts are unclear because we haven’t had time to document them.
😕
I can change the order back. But in that way, we are going to have two
different stats table mapping for single-shot and multi-shot.
I imagine this change is important because it ensures bias is added
similar to single-shot.
Can we change the npm test script to accept order change?
Yep! Would you mind updating the tests?
And if npm test failed, does that mean Coinstac UI wouldn't run?
Not necessarily. In this case the UI runs fine, in other cases it means
computation runs crash the UI.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/MRN-Code/decentralized-laplacian-ridge-regression/pull/16#issuecomment-280420941,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV1WOJpPE-ayXkqADThaK8rtVJNErqxYks5rdJlDgaJpZM4MCXQ6
.

--
Jing Ming
Postdoctoral Research Fellow
The Mind Research Network
Lovelace Respiratory Research Institute

have pushed new test to git

Great, thanks! Tests now pass.

Probably I also should update the test data to make isControl column really boolean.  Should I set it as [1, -1]  or  [True, False] here?

The test/declaration.js file is fine. isControl is already a boolean: https://github.com/MRN-Code/decentralized-laplacian-ridge-regression/blob/5c16c8b9a8db40ca9a6c1d59b6fd72a4babfd7cb/test/declaration.js#L21-L40
The UI has some functionality already in place that converts -1.0 → false and 1.0 → true. Good to go!

Okay, Great.

Ross just publish a release for testing. I test it. Using the current test
data, if you set isControl covariate as boolean, coinstac still generate
wrong result.  So, for demo, we still need to set isControl covariate as
number.
On Thu, Feb 16, 2017 at 12:40 PM, Cory Reed<EMAIL_ADDRESS>wrote:

Merged #16
https://github.com/MRN-Code/decentralized-laplacian-ridge-regression/pull/16
.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/MRN-Code/decentralized-laplacian-ridge-regression/pull/16#event-965585681,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV1WOFVbLI6ofBIeh8MVMyynnnCxDw40ks5rdKZAgaJpZM4MCXQ6
.

--
Jing Ming
Postdoctoral Research Fellow
The Mind Research Network
Lovelace Respiratory Research Institute


Switch does not turn on or off

I am trying to write an automation. The action part is as follows:
- service: switch.turn_off
entity_id: switch.sonoff_scaldino
It simply does not work. No change of state from the switch. If I go on the HA main page, I can switch it on and off with no issues.

Are you sure you using right entity_id?

Closed because no response


Feature/fe 1342 intro at station claiming process

Why?
The 3 different entry points for the station photo verification
How?

Added an entry point at D1/M5/Pulse
Added an entry point at Helium's claiming screen
Added an entry point at Helium's OTA Screen

Testing
Ensure that all 3 entry points are OK UI-wise. Some playing with the code is needed to emulate the functionality in OTA & Helium's claiming, if you don't have a spare Helium to test it.
Mock-wise:

D1/M5/Pulse works correctly
Helium Claiming flow need some configuration, in ClaimHeliumActivity add model.next() in line 102 and comment out the line 108 (resultModel.setFrequency(model.getFrequency())). Also in ClaimHeliumPairFragment replace enableBluetoothAndScan() with parentModel.next() in onCreate and in ClaimHeliumResultFragment add in the onCreate the line parentModel.claimDevice(locationModel.getInstallationLocation())
Helium's OTA needs some configuration, in Navigator line 385 replace needsPhotoVerification with true and in the DeviceHeliumOTAViewModel comment out the content of startConnectionProcess function and add a onStatus.postValue(Resource.success(State(OTAStatus.INSTALLING)))

@pantelisss It has to do with the edits for testing, have you done both steps 2 and 3 in the "Testing" ? It shouldn't even be possible to get in here and try a BLE Scan, the edits are supposed to automatically bypass it and return a success:

comment out the content of startConnectionProcess function and add a onStatus.postValue(Resource.success(State(OTAStatus.INSTALLING)))


Store REST API documentation issue

Description:
keyType is incorrect in response of the Update grant types and callback url of an application api
Request
PUT https://localhost:9443/api/am/store/v0.13/applications/896658a0-b4ee-4535-bbfa-806c894a4015/keys/SANDBOX
Authorization: Bearer ae4eae22-3f65-387b-a171-d37eaa366fa8
{
   "supportedGrantTypes": [
     "refresh_token",
     "urn:ietf:params:oauth:grant-type:saml2-bearer",
     "password",
     "client_credentials",
     "iwa:ntlm"
   ],
   "callbackUrl": "http://sample/com/callback"
 }

Response:
HTTP/1.1 200 OK
Content-Type: application/json
{
"consumerKey": "QwEtRHd4NJkcFuRUfAT5af8XEEoa",
"consumerSecret": "7Fairfeu321ENjOR9w2xgJl3i70a",
"supportedGrantTypes": [
"refresh_token",
"urn:ietf:params:oauth:grant-type:saml2-bearer",
"password",
"client_credentials",
"iwa:ntlm"
],
"callbackUrl": "http://sample/com/callback",
"keyState": "COMPLETED",
"keyType": "PRODUCTION"}

Fixed with https://github.com/wso2/carbon-apimgt/pull/5721


Update godoc for client package

Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Codecov Report

Merging #1285 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #1285   +/-   ##
=======================================
  Coverage   23.58%   23.58%
=======================================
  Files          40       40
  Lines        4550     4550
=======================================
  Hits         1073     1073
  Misses       3275     3275
  Partials      202      202

Impacted Files
Coverage Δ

io.go
0% <ø> (ø)
:arrow_up:

client.go
2.55% <ø> (ø)
:arrow_up:

process.go
0% <ø> (ø)
:arrow_up:

task.go
0% <ø> (ø)
:arrow_up:

container.go
0% <ø> (ø)
:arrow_up:

image.go
0% <ø> (ø)
:arrow_up:

container_unix.go
0% <ø> (ø)
:arrow_up:

spec_unix.go
39.06% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa7658...52f9c04. Read the comment docs.

@mlaventure updated.  I still think two spaces is correct because that is what I was schooled to do my whole life.  We can let a well versed third party settle this, @stevvooe !

I've been school with one all my life ;-). Europe FTW!
But I agree on letting @stevvoe having the final say. That debates has been going on forever, no need to have it here for too long :)

That failure is really weird.

@mlaventure rebased

LGTM


Add ability to specify scheme of ServiceProviderConfiguration

Add ability to specify scheme of ServiceProviderConfiguration, for use in the ConsulClientFactory
Recreation of #960 after request from @TomPallister.
Fixes / New Feature #959
In the ConsulClientFactory class, the scheme of the Consul server address is hard-coded to "http". In our environment, Consul is not hosted over http, only over https.
Proposed Changes

Add property "Scheme" to ServiceProviderConfiguration.
Use it in ConsulClientFactory, by adding it to ConsulRegistryConfiguration.
Implement a backward compatibility fallback to "http".
Make sure it is filled in when loading the GlobalConfiguration from file.

@DavidLievrouw sorry it has taken me so long to merge this PR.
Thank you very much for your contribution to Ocelot!!


bug: it give me "Applying edits failed" When i click on document command

Version
1.85.1
Describe the bug
I just when I click on the document command

it keeps displaying Applying edits failed

Note that all the commands worked, except document
Expected behavior
Document the code
Additional context
I just downloaded the extension today and using the free tier, I signed up with GitHub, if that important

It solved now somehow

i am getting this error all the time when trying to add code.


Contextual menu Open with Windows Terminal should open in a new tab

Description of the new feature/enhancement
Currently contextual menu "Open with Windows Terminal" open a new window (even if an existing Windows Terminal window is opened)
it should open in a new tab in the ever opened window
Fluent terminal behave like this and that's very convenient.

Proposed technical implementation details (optional)

You can get this behavior if you enable "windowingBehavior": "useAnyExisting"


converted useMemoCompare to typescript

This code is not very concrete about it's use case, so there is no need for many explicit types, Typescript type inference is fine here.

@gragland Hi could you review and merge it? It's ready to be merged

@gragland Hi could you review and merge it? It's ready to be merged

Hey, sorry but I'm no longer running this project. @tylermcginnis and the github.com/uidotdev team have taken things over. Not sure on their plans for the site, but they are the right people to talk to going forward :)

👋 lots of plans but not making any moves right now. We have a big launch coming in the next few weeks and after that we're going to put some time into useHooks and we'll address this PR then. Sorry for the delay!

Yes, we've rebuilt the site and all the hooks. Launching it in the next few weeks.


Q: Link between language

Subject of the issue
I can't make link work between languages.
Your environment

version of angular-translate: 2.9.0
version of angular: 1.5.0
which browser and its version: Chrome 49.0.2623.110 m

Steps to reproduce
See this plunker
I opened a question on stackoverflow regarding the aforementioned plunker.
One convincing answer is that you can't make link between languages, but only between different namespaces of the same language.
I wanted a confirmation from you guys because I am skeptical of this explanation. What would be the point of linking two labels in the same language? If you want the same value, just use the same label.
On the other hand, link between languages seems a must. "OK" or "pizza" is written the same way between all languages...

You can't mix languages.

Personally, I would not recommend mixing languages only because some words could be the same.
OK is not the same in all languages. Most would accept it, but it would not be natural. :)
And the more technical answer : No, that is not possible. And we are not planing to add such a feature. If you really need this, you have to maintain the language sets on your own and deliver final translation sets.


Start/stop button doesn't function

Hello, I am unable to interact with the start/stop button. I can see the buttons when I turn on the app, but can't "press" it. Could you help? Thanks.

Initially, I also had the feeling that it does not work. But when you press the 'START' button, you should notice a slight change in color of both buttons. Then, the recording started. When you are finished with recording, you can press the 'STOP' button and you should see the files in your file explorer.

@ishanic , could you please let us know if the problem is solved?

@fbogo the problem has not been resolved yet. I understand what @weders meant, but I see no color change or haptic/audio feedback at all, so it appears to be totally unresponsive. Is that something that can be debugged or is there a workaround?

@ishanic there was a workaround for a bug that appeared on Visual Studio which was addressed on a later release. I reverted the workaround recently but probably it's not safe to assume that everyone is running latest Visual Studio version so I reverted it in #48 .

Yes, the buttons are functioning as expected after this fix. Thank you!


Fix failing CI build

Update serenity 0.11.5 -> 0.11.6
Update proc_macro2 1.0.47 -> 1.0.64
Disambiguate several serenity re-exports
Temporarily disable serenity/simdjson test since feature is broken upstream (serenity-rs/serenity#2474)

I think it's debate whether we disable the simdjson step. If we think that's fine I'll cut a ticket to track the follow-up to re-enable

Thank you!
You targeted the next branch - what are the breaking changes in this PR? Is it the import disambiguations?

Yes the import disambiguations are potentially breaking if people were using the imports through poise before the ambiguity was introduced; although I tried to pick sensible disambiguations so that hopefully shouldn't be the case. But the real reason I targeted next was I simply didn't realize there were similar errors in current lol (although not as many it would seem?)


Move AST to standalone tiny package

Current package has two goals:

Handle compile routines of Solidity sources. This requires package to rely on Solc compiler, do file system lookups, allow compiler guessing and downloading.
Handle AST processing. This requires to handle historically various types of Solidity AST (produced by compiler), tree travesal, AST-to-source writing, making new AST nodes, also parse types to a type tree.

We are considering to move AST processing to a standalone tiny package in near future. Current reasoning:

Compile-related functionality forces to load ~20 megabytes by always shipping and loading latest WASM compiler.
Compile-related functionality requires to do a file system lookups. This is useful when using sol-ast-compile or developing side CLI packages, but not that suitable in case if someone would like to use typed AST in browser.
AST processing actually does not force to use our compiling routines. In other words, ASTReader does not care how source were compiled - it requires only compiler output. Users may use native, wasm or whatever compiler to compile source and just supply returned data.

A plan:

Move AST-related functionality to a side package and publish it to NPM.
Clean up this package from AST logic.
Add AST package as dependency to maintain BC of this package however possible.

We are publising this to receive opinions and infrom about further changes. Thanks for your time and attention.

Current set of considerations:

[ ] both: update README in both repositories.
[ ] both: publish to NPM as two separate packages.
[ ] both: release cycle would be longer, need to update/release ast and compile packages and have common flow for release procedure.
[ ] both: need to figure out what to do with the docs.
[ ] ast: #117.
[ ] ast: should not have a docker image.
[ ] ast: would miss integration tests, so there would be necessary to figure something (maybe use WASM-produced and native-produced artifacts).
[ ] compile: should use ast as dependency.
[ ] compile: should contain compile-related logic and executable (sol-ast compile)
[ ] compile: should have integration tests.

@cd1m0 Hello. Consider some of the steps above if there would be some spare time. Thanks.

These are all valid considerations. I just want to comment on two of them:

"release cycle would be longer": you are right, this is a downside of this approach. I don't know of a way to avoid this

"ast would miss integration tests": yeah, this will be a problem. One thing we could try is to add the compilers and file-system packages as dev dependencies, and copy over a minimal set of logic for compiling contracts. Then we might still be able to adapt some of the integration tests from the compile repo?

Everything else in the considerations seems ok to me.


Show png images with plain link

e.g. https://busy.org/kr/@siloamlee/2uudwn
http://i.imgsafe.org/73d5ac0d72.png is shown just as a link.
Edit: Jpg images too. e.g. https://busy.org/photography/@abdullar/winter-sea-photos

closed in https://github.com/adcpm/busy/commit/0a68cc5b3005808aee918afb8e0d1e25d00957eb
https://github.com/adcpm/busy/issues/319


is it possible to create tar.gz with a flat structure

I would like to create a tar.gz file whose contents come from various sub folders. I would like the tar file to only contains the file names and not the folder structure that they come from.
Is it possible to do this. I had a look at the various options and could not file one where the paths are stripped.

Not required anymore

I'd really like to have this feature as well, if at all possible.


self.get('jobs') is NoneType

The line which throws:
https://github.com/Kitware/HPCCloud/blob/dev-v2/server/taskflows/hpccloud/taskflow/paraview.py#L71
Full error:
{
  "message": "TypeError: TypeError(\"'NoneType' object is not iterable\",)",
  "trace": [
    [
      "/opt/hpccloud/girder/girder/api/rest.py",
      421,
      "endpointDecorator",
      "val = fun(self, args, kwargs)"
    ],
    [
      "/opt/hpccloud/girder/girder/api/rest.py",
      935,
      "DELETE",
      "return self.handleRoute('DELETE', path, params)"
    ],
    [
      "/opt/hpccloud/girder/girder/api/rest.py",
      729,
      "handleRoute",
      "val = handler(**kwargs)"
    ],
    [
      "/opt/hpccloud/girder/girder/api/access.py",
      50,
      "accessDecorator",
      "return fun(*args, **kwargs)"
    ],
    [
      "/opt/hpccloud/girder/girder/api/rest.py",
      294,
      "wrapped",
      "val = fun(*args, **kwargs)"
    ],
    [
      "/opt/hpccloud/girder/girder/api/rest.py",
      266,
      "wrapped",
      "return fun(*args, **kwargs)"
    ],
    [
      "/opt/hpccloud/girder/plugins/taskflow/server/taskflows.py",
      267,
      "delete",
      "workflow.delete()"
    ],
    [
      "/opt/hpccloud/hpccloud/server/taskflows/hpccloud/taskflow/paraview.py",
      71,
      "delete",
      "for job in self.get('jobs'):"
    ]
  ],
  "type": "internal"
}

closed with #183


Add distilbert paper to adhoc train notebook

https://arxiv.org/abs/1910.01108

this was already present.  just made it more explicit.


[Feature Request] expects control counter to add decimal control

Existing Component
Yes
Component Name
el-input-number
Description
<el-input-number :decimal='2'></el-input-number>
# 0表示整数，默认不限制位数

Sorry, we have no plan to support this.

+1


Archive this repository

As stated in the readme, this product will be unsupported after 31 August 2023 and will be archived.
This issue will track any remaining cleanup on the repository and the archival.
Note that the archival will not prevent use, and users are welcomed to fork the repository in order to fix bugs, update dependencies, or add features.

Final releases have been made for the CLI and the VSCode extension.
I'll close off the existing issues and then archive the repository.


operator nfs-provisioner-operator (0.0.6)

Signed-off-by: jooho<EMAIL_ADDRESS>Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description of the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/ok-to-test

/retest

/merge possible

@mvalarh Hi, it looks openshift cluster is not created successfully to test this operator. could you please take a look at this?

/test all

/merge possible


Feature request: Finer-grained dependency tracking

Would it be possible for nanoc's dependency tracker to make a distinction between item contents and item attributes? In other words: can nanoc recognize when a representation only depends on an item's attributes so that even when item content changes, that representation is not re-compiled?
Example use case:
I'm working on a site that offers content in a few languages. For pages with multiple translations, I would like to render links to the alternate versions. One way I've prototyped this is through an item attribute named canonical.

content/hello.md
  ---
  ---
  Hello.

content/pt-br/ola.md
  ---
  canonical: /hello/
  ---
  Ola.

content/es-mx/hola.md
  ---
  canonical: /hello/
  ---
  Hola.

With this setup, I can create a hash of identifiers in a preprocess block and store it as a :locales attribute on the "canonical" item. I can then access this from a layout generally via code like:
<%
canonical = @item[:canonical] ? @items[@item[:canonical]] : @item
canonical[:locales].each { |lang, id|
  render("locale_link.md", :lang => lang, :id => id)
}
%>

The problem here is that nanoc's dependency tracker (correctly) detects that I am referencing the "canonical" item, and it registers this as a dependency. Now, whenever the "canonical" version's content changes, the localized representations are needlessly re-compiled.
This is not so bad, except that I would also like to use this mechanism to generate static links in a generic "header" layout shared between most pages on my site:
<%
link_text = translate("contact")  # defined elsewhere (not directly relevant)
current_locale = @item[:locale]   # (inferred from item identifier)
contact_href = @items['/contact/'][:locales][current_locale]
%>

  <a href="<%= contact_href %>"><%= link_text %>

If I re-use this across the site, then any change to the content of the /contact.md item will trigger recompilation of every page. This is the behavior I would like to avoid.

My use case is obviously far more specific than the feature request suggests. I've tried to propose a solution that makes sense for nanoc generally outside of this context. That said, I'm very open to suggestion for other ways to avoid this problem. If I can do this with nanoc's current features (maybe there's a better way to structure my content?), then that would obviously be ideal. It might also be the case that there are alternative ways to extend nanoc that would help me here (for instance, defining a public API for the dependency tracker so I could express this relationship explicitly).
Thanks for the great tool!

This issue is definitely on the radar to be fixed, although I don’t think it’ll ever land in nanoc 3.x. There are a few issues related to dependency tracking which I’d like to fix in 4.0. Here’s some Trello tickets:

Efficient outdatedness checking
Improved dependency tracking
Make adding items not cause entire site to be recompiled

Some of these overlap in some way. There is also the fine-grained dependency tracking based on attributes, which I think isn’t yet codified in any Trello card (strangely enough).
I did take a stab at implementing fine-grained dependency twice in nanoc 3.x, and it’s really quite difficult to get right. The algorithm, which already is complex, becomes even more complex. Because of this, I’d like to tackle it in nanoc 4.x, where there’s no requirement to remain backwards compatible in any way.
As for nanoc 4.x… even though I haven’t touched it in a while, it’s not a cancelled project. I’m taking a break. There are some fundamental issues that I’d like to solve, and I haven’t really had the energy to start working on that.

Didn’t mean to close this, but I suppose it’s not a bad thing. I’ll link to this issue from a new Trello card.

This now lives in this Trello card.


faster npm builds

Builds can even be faster if it would do npm ci instead of npm install. So this line
https://github.com/ymedlop/npm-cache-resource/blob/master/assets/in#L64

Should be changed, see background information at:
http://blog.npmjs.org/post/171556855892/introducing-npm-ci-for-faster-more-reliable

Hello,
Thanks for your sugesstion!.

The project must have an existing package-lock.json or npm-shrinkwrap.json.
If dependencies in the package lock do not match those in package.json, npm ci will exit with an error, instead of updating the package lock.

Maybe can be used as a optional configuration. It only going to work with the latest node-alpine.


Bump Skype for Business to <IP_ADDRESS>

Hello,
Here is an update for the Skype-for-Business cask.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for your contribution!


PyFr ( simput workflow ) can't switch to input step

After clicking on the input step I see the following in the console, the view doesn't switch to the input view.

Refreshing the page updates the view to the input view.

I want to say related #302, or it's a very similar bug anyway.

The same thing happens from Input -> Simulation, even gets the same traverseParentPath error.

Shows a very odd view too:


Removing ReadOnlyProperty and making StringProperty in model class

Signed-off-by: bapan25<EMAIL_ADDRESS>Fixes for #56
Hi @oasuncion ,
As per your comment in my previous PR #57
I have made changes in the model classes and avoid using of ReadOnlyProperty().
Let me know if the changes are okay.
Post that will refactor all the PropertyValueFactory in the remaining classes

Hi @bapan25 , the changes are ok, thanks a lot, I'll merge the PR.

Hi @bapan25 There are a couple of PropertyValueFactory remaining in the project. Let me know if you want to handle them, otherwise I'll do it, probably this week-end. thanks


Codeowner crash

This is before we even do any work
(node:3743) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object
8
    at validateString (internal/validators.js:112:11)
9
    at Object.normalize (path.js:1006:5)
10
    at trueCasePathSync (/home/runner/work/_actions/orta/code-owner-self-merge/master/node_modules/true-case-path/index.js:12:31)
11
    at new Codeowners (/home/runner/work/_actions/orta/code-owner-self-merge/master/node_modules/codeowners/codeowners.js:21:29)
12
    at commentOnMergablePRs (/home/runner/work/_actions/orta/code-owner-self-merge/master/index.js:36:14)
13
    at run (/home/runner/work/_actions/orta/code-owner-self-merge/master/index.js:14:5)
14
    at Object.<anonymous> (/home/runner/work/_actions/orta/code-owner-self-merge/master/index.js:222:5)
15
    at Module._compile (internal/modules/cjs/loader.js:959:30)
16
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
17
    at Module.load (internal/modules/cjs/loader.js:815

https://github.com/microsoft/TypeScript-Website/runs/1052007433?check_suite_focus=true


Reflected attributes cause unexpected behavior

Components which use reflect: true,  when using the @property decorator or this.setAttribute result in unexpected behavior.
To reproduce this:

Create a component that uses this pattern, for example use the following, and then do something like :host[is-open] {} in the CSS as a response to the attribute being present.

@property({type: Boolean, attribute: 'is-open', reflect: true})
public isOpen: boolean = false;

Have the component manage its own state, for instance it should run this.isOpen = true and then this.isOpen = false at some stage in its lifecycle.
When the first isOpen is called and set to true, it reflects the attribute into the URL bar to keep Storybook controls in sync.
When the second occurance happens, the attribute remains present in the URL, and does not correctly remove the attribute from the component.

As a result component previews for some interactive elements do not work in Storybook. I've tried ignoring the option with addon-controls by extending argTypes and setting controls to false to no avail. I've also tried adding a JSDoc comment as @private to see if that somehow causes it to ignore that attribute name by removing it from the generated custom elements manifest, but alas, no luck. Seems the only solution for these cases in the meantime is to not use the template method here.

After reading through this, I think this is desirable behavior. Is the is-open attribute something that is intended for users to be able to set or is primarily for internal purposes?

It's somewhat both. Either a user can set it to define some sort of default behavior, but the component similarly manages the attribute. Lit describes a couple of reasons why you might use reflected attributes here which is a similar circumstance that this component is using.

It's somewhat both. Either a user can set it to define some sort of default behavior, but the component similarly manages the attribute. Lit describes a couple of reasons why you might use reflected attributes here which is a similar circumstance that this component is using. Things just get out of sync after the first reflection, so I'd rather just disable addon controls for this particular property entirely.

Have you tried setting the renderDefaultValues property in the setWcStorybookHelpersConfig options ? I was seeing similar behaviour to what you describe and this setting cured my issue.


Update interval input

Something is wrong. this PR was not intended to have commit 5f6cf43. I'll have to close this and make a new one. For now, WIP.

(Of course, my reply is about the part you said shouldn't be in here :smile:)


Linearization fails with "unknown token while reading object (PDF)"

Attempting to linearize the PDF file here by means of qpdf --linearize dixon.pdf output.pdf fails with the error (file position 3844619): unknown token while reading object (PDF). My qpdf version is 5.1.2.
I’ve encounted this same error with a number of PDFs (all ebooks) recently.

saved as qpdf/misc/bugs/36.pdf

I believe latest fixes on master will allow qpdf to recover this file. qpdf now recovers from invalid tokens and malformed dictionaries much more often than before. These fixes will be in 7.0.0.


app.getUser().userId returns Epoch time value instead of actual userId

console.log(app.getUserId);
It returns:
Here userId is the Epoch time instead of the actual userID.

Response:
{ locale: 'en-US',
  userId: '1502723585291',
  user_id: '1502723585291',
  access_token: undefined,
  userName: null
}

My actual userId =<PHONE_NUMBER>90278732409
Expected Response:
{ locale: 'en-US',
  userId: '112695425590278732409',
  user_id: '112695425590278732409',
  access_token: undefined,
  userName: null
}

This is a device setup issue. If you hit "skip" on the "Get personal results" screen, Google will send epoch ids as a punishment.

I was trying in Online Simulator and got the results.

Oh. Simulator is always epoch. Not sure if that's a bug or a feature ...

I want to get to know how it is behaving in Google Assistant (Phone)?
Is it epoch or the actual id?

Well, actual id ... but currently it depends on the device setup. I think that's a bug.

Thanks :)

Interesting.. so in order to differentiate between a legit anonymous google ID & the timestamp, some quick pseudocode:
userIDLength = userID.length;

if (userIDLength >= 21) {
  // Non personalized results
  app.tell();
}

Thanks for the heads up! 👍

Have you updated to the latest version of the library (v2.X)? If so, do you still see this behavior?


Icons for the posts #153

Fixes: #153
Proposed Changes

Changes in home.html

Screenshots

Hey @harsh-9in take a look now..


⚠ Bofrost.at has degraded performance

In 69605b7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1622 ms

Resolved: Bofrost.at performance has improved in b176316 after 15 minutes.


Prevent ToolbarAndroid action touch while processing another one

Hello there.
I'm using ToolbarAndroid with 2 action buttons.
var toolbarActions = [
    {
        title: 'Exit',
        icon: require('../img/exit.png'),
        show: 'always',
        showWithText: false
    },
    {
        title: 'Save',
        icon: require('../img/save.png'),
        show: 'always',
        showWithText: false},
];

render: function() {
    return (
        <ToolbarAndroid actions={toolbarActions} onActionSelected={this._onActionSelected}>
        </ToolbarAndroid>
    )
},

_onActionSelected: function(position) {
    switch position {
        case 0: // Exit without save
            this.props.navigator.pop();
        case 1: // Save and exit
            this._saveData(); // Save some data
            this.props.navigator.pop();
    }
},

When I push to action 1 button and then push fast to action 0 button this.props.navigator.pop() executing twice.
Is it possible to prevent toolbar action handling while another action is in process?

@juggleru
When you have clicked on a Toolbar button, you should disable the user from clicking the other buttons. To do that, you will need to somehow keep track of if the navigator is currently in the process of popping or not. Perhaps you can use some state to track this. You will also probably need to hook into the navigator lifecycle events as mentioned here https://facebook.github.io/react-native/docs/navigator.html#onwillfocus

@pangers
Thanks a lot for your answer.
I try to track with state, but it doesn't work. State does not changing before the handler is called for the second time. I'll try to track state with 'willfocus' listener.

Now I'm preventing second touch by code:
_onActionSelected: function(position) {
    if (this.state.isBusy) {
        return;
    }

    this.setState({isBusy: true});

    switch position {
        case 0: // Exit
            if (this.state.isDataChanged) {
                Alert.alert(
                    "Warning!",
                    "Data was changed. Save changes?",
                    [
                        {text: 'No', onPress: () => this.props.navigator.pop()},
                        {text: 'Cancel'},
                        {text: 'Save', onPress: () => {
                            if (this._saveData()) {
                                this.props.navigator.pop();
                            }
                        }},
                    ]
                );
            }
            else {
                this.props.navigator.pop();
            }
            break;
        case 1: // Save and exit
            if(this._saveData()) { // Save some data
                this.props.navigator.pop();
                return;
            }
    }
    this.setState({isBusy: false}); // If do not pop current view in previous code
},

Does it mean that I must use this preventing schema for all touchable components? Is there native way to make touchable* components single-touch?

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/prevent-toolbarandroid-action-touch-while-processing-another-one
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub. GitHub issues have voting too, nevertheless
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.


Display private key with qrcode

Display private key with qrcode to convenient the mobile wallet app to scan to import this near account.

Thank you for the contribution @AmazingBeerBelly. I can definitely see this being helpful for mobile wallet apps import flows. It seems that on we have the functionality to export the account's full access key via a QR code, but it is only on the testnet env.

Before merging this in, i'd like to get some clarity on why this is not on mainnet yet. Would you happen to know @Patrick1904

Before merging this in, i'd like to get some clarity on why this is not on mainnet yet. Would you happen to know @Patrick1904

@roshaans the 'Scan QR code to import' feature is only available on testnet for security reasons since the QR code contains a FAK. Currently there are no plans to introduce this feature on mainnet.
@AmazingBeerBelly is there a use case where displaying the private key on the UI is better than scanning the QR code? The QR code uses the 'auto import' functionality in the wallet, so there is no additional understanding of how to import an account needed. However, just displaying the private key requires a deeper understanding of how the wallet uses keys in order to work properly, and I'm afraid that users may find this confusing.

Before merging this in, i'd like to get some clarity on why this is not on mainnet yet. Would you happen to know @Patrick1904

@roshaans the 'Scan QR code to import' feature is only available on testnet for security reasons since the QR code contains a FAK. Currently there are no plans to introduce this feature on mainnet.
@AmazingBeerBelly is there a use case where displaying the private key on the UI is better than scanning the QR code? The QR code uses the 'auto import' functionality in the wallet, so there is no additional understanding of how to import an account needed. However, just displaying the private key requires a deeper understanding of how the wallet uses keys in order to work properly, and I'm afraid that users may find this confusing.

Agreed. I do not think think this feature will benefit users as it currently stands. The QR code flow will need to be worked out very carefully with security and usability in mind. We can revisit this at a later point and if this is a feature that you think should exist, we can bring it up to Product and see how it can be integrated.


Enhancement: More WebView & Native Code interactions.

Thank you for offering an exceptional all-in-one solution for one of the most intricate components: the WebView.
I’m curious if it’s possible to incorporate the following interactions between the WebView and native code: When a user clicks a link in the WebView, a message is sent to the native code. The native code can then decide how to handle the new URL—for instance, either blocking it or taking context-specific actions. Perhaps this functionality could be added to the WebViewNavigator’s callbacks.

@grandleaf TThank you for your suggestion! We have received a similar issue before and have already started to work on it. However, as we discussed in that issue, we encountered some strange issues and we are currently unable to solve them. I will devote more time to this issue next month, and you are also welcome to submit a PR for it. Thank you!

Thank you for your fast response.  I currently found that by using a JS can workaround this issue so it should not be a blocker for me.  However, a more natural implementation is always better.  Thanks.


[k8s] Horizontal Pod Autoscalers - matchExpressions

Describe what happened:
See https://github.com/DataDog/datadog-agent/issues/2541#issuecomment-489022566
Describe what you expected:
I'd expect that matchLabels and matchExpressions are handled similarly.
Steps to reproduce the issue:
Create a Horizontal Pod Autoscaler with matchExpressions under metricSelector.
Additional environment details (Operating System, Cloud provider, etc):
Kubernetes v1.11.8-gke.6 on GKE with HPA apiVersion autoscaling/v2beta1.

Not sure if this relates, but when using autoscaling/v2beta2, the format for External metrics blocks seems to change entirely:
- type: External
    external:
      metric:
        name: aws.sqs.approximate_age_of_oldest_message
        selector: "app=whatever"
      target:
        type: AverageValue
        averageValue: 20

Can we get an update as to what this should look like? Specifically, I'm having a lot of problems with the metric.selector value - is this supposed to match a label from within Datadog, or is this a label within k8s as a selector?
For context:
> kubectl explain --api-version='autoscaling/v2beta2' hpa.spec.metrics.external.metric
KIND:     HorizontalPodAutoscaler
VERSION:  autoscaling/v2beta2

RESOURCE: metric <Object>

DESCRIPTION:
     metric identifies the target metric by name and selector

     MetricIdentifier defines the name and optionally selector for a metric

FIELDS:
   name	<string> -required-
     name is the name of the given metric

   selector	<Object>
     selector is the string-encoded form of a standard kubernetes label selector
     for the given metric When set, it is passed as an additional parameter to
     the metrics server for more specific metrics scoping. When unset, just the
     metricName will be used to gather metrics.

If you simply add a value like "queue=worker_tasks" per the example given here: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/#autoscaling-on-metrics-not-related-to-kubernetes-objects - you end up with an error:
Error: UPGRADE FAILED: v2beta2.HorizontalPodAutoscaler.Spec: v2beta2.HorizontalPodAutoscalerSpec.Metrics: []v2beta2.MetricSpec: v2beta2.MetricSpec.External: v2beta2.ExternalMetricSource.Metric: v2beta2.MetricIdentifier.Selector: readObjectStart: expect { or n, but found ", error found in #10 byte of ...|elector":"app=foobar|..., bigger context ...|qs.approximate_age_of_oldest_message","selector":"app=rise-foobar"},"target":{"averageValue":20,"t|...

Hey all,
Thank you very much for bringing this up to our attention.
I am putting this in our backlog, I don't have a clear answer just yet but we're going to investigate and will get back to you with a path forward.
Thanks for your patience.
Best,
.C

Just as an update, we found that this worked best for us:
- type: External
    external:
      metric:
        name: aws.whatever.metric
        selector:
          matchLabels:
            foo: "bar"
      target:
        type: AverageValue
        averageValue: 20

The idea here is that you can pass in however many matchLabels you want that correspond with Datadog tags. This passes validation and seems to format properly in the hpa. We still can't pull the metrics in to the cluster agents, but we're still looking into that.

@echoboomer I've arrived at the same place as you (via a different route!) using autoscaling/v2beta2 and am now at a state where the datadog-cluster-agent is aware of the HPA metrics e.g.
  Custom Metrics Server
  =====================
    ConfigMap name: kube-system/datadog-custom-metrics

    External Metrics
    ----------------
      Total: 1
      Valid: 0
      hpa:
      - name: test
      - namespace: default
      - uid: 536a6ade-a324-11e9-850a-0636ed6aea6c
      labels:
      - foo: bar
      metricName: aws.foo.bar
      ts: 1.562772738e+09
      valid: false
      value: 0

but I'm getting no metrics returned from external metrics API errors from the HPA. Have you managed to resolve this?

@echoboomer Would that work in case I want to filter by both foo: bar and foo: baz? Note that the key to the dictionary of labels is the same. Would that be equivalent to foo in [bar, baz], because that's the idea behind this issue?

@pchristos I think that section, unless someone else can correct me, corresponds to Datadog labels. For example, if we have labels in Datadog for env and app, I may want to do something like:
selector:
  matchLabels:
      env: "stage"
      app: "myapp"

This way, the metric itself is calculated based on those specs. Hopefully that makes sense. This is what I've been able to figure out from reading docs, talking to others who use this, and experimentation.

@echoboomer That makes sense. But, would the following also work?
selector:
  matchLabels:
      foo: "bar"
      foo: "baz"

@homme After opening a ticket with Datadog support, it turned out that the metrics I was trying to scale on were not working because they had a roughly 15 minute delay making it into Datadog. The cluster agent apparently queries the back end with a 5 minute rolling period (called a bucket) and thus the metric I was using was considered "invalid." I increased the "bucket_size" to a higher period but that did not resolve my issue. This is on the back burner for us now since we stopped trying to scale on things that had such a delay.

Edited my previous comment.

@pchristos Makes sense. I just went into the Datadog console and tried to filter metrics based on the same tag twice, like env, and it didn't let me use duplicates. I'm not sure if that's a possibility.

Running into a similar issue here; can't seem to filter DataDog based on tags, but it seems to be coming through into the cluster-agent:
`  metrics:

type: External
external:
metricName: kafka.consumer.partition_lag
metricSelector:
matchLabels:
cluster: "prod"
targetAverageValue: 70000`

and here is what cluster-agent status tosses out:
    External Metrics     ----------------       Total: 1       Valid: 1       hpa:       - name: nginxext       - namespace: default       - uid: 13cee97a-a99d-11e9-baf6-0ad3a1ef891c       labels:       - cluster: prod       metricName: kafka.consumer.partition_lag       ts: 1.56348279e+09       valid: true       value: 78856.52485714285
 Warning  FailedGetExternalMetric       2m11s  horizontal-pod-autoscaler  unable to get external metric default/kafka.consumer.partition_lag/&LabelSelector{MatchLabels:map[string]string{cluster: prod,},MatchExpressions:[],}: no metrics returned from external metrics API   Warning  FailedComputeMetricsReplicas  2m11s  horizontal-pod-autoscaler  failed to get kafka.consumer.partition_lag external metric: unable to get external metric default/kafka.consumer.partition_lag/&LabelSelector{MatchLabels:map[string]string{cluster: prod,},MatchExpressions:[],}: no metrics returned from external metrics API
Unfortunately I don't see any documentation anywhere on how to filter based on DD tags-- so if anybody has input it would be appreciated.

Hi @pchristos
This:
selector:
  matchLabels:
    foo: "bar"
    foo: "baz"

Doesn't work in our UI as pointed out by @echoboomer.
So it won't be a valid query for our API.
For now, the same metric with different tags in the same HPA is not supported by the DCA.
One way to do it would be to add a specific tag to the queues you want to base your HPA on, so you could scope on this specific tag.
If it doesn't work for you, feel free to open feature request to our solution team via a support ticket.
@kencieszykowski for your case, it seems that the issue is between the HPA and the Cluster Agent. Not on how the cluster agent is interpreting the tags. (it seems to work correctly in your case, by looking at the cluster agent status)
Do you happen to have the env var DD_LEADER_ELECTION set to true on the node agents?
If should not be set on the node agent, only on the cluster agent.
Also, make sure that the correct RBACs and service have been deployed: https://docs.datadoghq.com/agent/kubernetes/cluster/#custom-metrics-server
Feel free to open a support ticket if the steps I mentioned don't solve the issue.
Simon

So, to make this clear, at the moment, the only way around:
  - type: External
    external:
      metricName: rabbitmq.queue.messages_ready
      metricSelector:
        matchExpressions:
        - {key: rabbitmq_queue, operator: In, values: [a, b]}
      targetAverageValue: 10

is something similar to what's being described here?

@pchristos if the queues share the same tag queue_family, you can use this tag to scope your query on several queues.
By default, the query will be forged with an average aggregator. Your use-case would need to use this env var to use a sum aggregator:
DD_EXTERNAL_METRICS_AGGREGATOR=sum
Ref: https://docs.datadoghq.com/agent/kubernetes/cluster/#cluster-agent-options


Encountered Initialization error on setting up a workspace

Hello guys I am trying to set up a development environment for customizing this project on a virtual VM of Ubuntu 20.04.

After creating a test workspace on the bumblebee, when I try to work on it I encountered this issue

The node process for the front-end and the back-end are running on port 3000 and 4000 respectively
The jupyter_getway is running on port 8888
The VM environment is as follows

Ubuntu 20.04
MongoDB 4.4
conda 4.10.1
Node.js v12.22.1

Any help will be appreciated.

Hi Biruk,
What's showing on the console?
We have been getting a similar error since we started stress testing the app, it seems that is due the capacity of the Jupyter Kernel Gateway and we're currently working on alternatives for that. Did you try again?

Hey,
Yes, I did try it several times. In the console, there is a Timeout Error

It's possible that the jupyter kernelgateway process is running in the correct port but in a different address. If it's running in <IP_ADDRESS> you'll encounter problems accessing the gateway via the same machine. Make sure you have the address properly configured.
I'll recreate your environment and let you know if there's a quick fix.

Ok, I will try to change the IP and will post if I resolve the issue. Thank you for your quick response.

I have tested this several times using a local installation and a Docker image, it seems okay so I'm closing this issue.


TypeTransformer for TensorFlow Tensor

TL;DR
Primary PR: https://github.com/flyteorg/flytekit/pull/1269
Type

[ ] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/

Eventually we should use the streaming constructs for all of these types


[SwitchBase] Render root component as label on radio to prevent click event glitch

[x] I have followed (at least) the PR section of the contributing guide.

Hi everyone,
according to the discussion on #20856,
I suppose to address some change on the radio,
but in that period of time you guys seems busy on releasing the MUI v5,
so I've done some test update based on MUI v5,
turns out that it still have the same problem if we removing z-index: 1,
here's a demo for this.
To not affect much unwanted part of code base and as @oliviertassinari said,
I decided to leave z-index-1 intact and only wraps radio by implicit label.
For the current implementation,
I think of 2 ways to do that,
one is to wrap with additional default label like:
    <SwitchBaseRoot>
      <label>
        <SwitchBaseInput/>
        {checked ? checkedIcon : icon}
      </label>
    </SwitchBaseRoot>

but it will cause unwanted cursor style reset,
and the other one is to render switch base root component as label on radio,
so here's the workaround to get rid of radio click event glitch,
thx for the great works on releasing v5~ :)

Hi @BensonLiao. What issue exactly does this PR aims to fix? I see it originated from #20856, but I can't see any improvements in the broken behavior there (see https://codesandbox.io/s/material-demo-forked-vhy1s?file=/demo.js).

Hi @michaldudak ,
I think this PR should link back to #17366 which leads to #20856,
but it's marked as closed so I don't know how to target it properly,
the label should be fine to bind with the radio button,
and I've also done some preliminary test to verify @andokai's concern,
IMHO,
wrapped radio button with a label should be better than adding z-index which creates a more complex stack context,
thx for reading and any suggestions?

#17366 is fixed, isn't it? If you're still noticing problems with radio buttons not being selected when clicked on MUI v5, please open a new issue.
As I understand #20865 is about being able to interact with a checkbox that is behind a Popper. Your PR does not seem to fix this problem.

ok,
I see,
thanks for the information,
I'll see if there's another solution to that.