Add additional 'None' button to survey

Summary
We want to add an additional "None" option for people to choose from when choosing answers about symptoms during survey.

[ ] Add "None" option for all button-based questions
[ ] Ensure state is updated in Redux
[ ] Ensure state is persisted to Gaia and properly shows up when survey is selected

Motivation
Since this app is supposed to be used by everyone, not just people already showing symptoms, we should make that clear in the survey.

I would like to work on this. I do have a question on how to maintain the UI after adding another button. I attached a screenshot showing what is happening currently when I added the "None" button, the "Moderate" button label was affected.

Hmm... I'm thinking if there's another word we could use instead of "moderate" that would fit for these small screen sizes, but this is probably a better questions for @ngiangre

This is only happening for a mobile screen not desktop. I was using chrome dev tools. Is there a way to resize for a mobile interface?

Like how do we mimic mobile in desktop? https://developers.google.com/web/tools/chrome-devtools/device-mode#viewport

Unfortunately I don't see the scale could be changed to something nore amenable to the problem. Minimal/Moderate/Severe or Low/Medium/High where len(Moderate)-len(Medium)==1 so I'm sure there will be overflow. Can't we have the font size decrease on small screens?

We definitely could make text smaller, we'd just have to do some user testing to ensure it's still readable 👍

Here is what I have so far

I'm looking to see for mobile there is something in Material UI I could use. If anyone knows of anything, in particular, let me know.

I found a way to remove that overlap I slightly changed the values for the items in the grid when the screen is small like on a phone.


Fix model nullable warnings

Harden model integrity by converting vulnerable types to Nullables as noted by compiler warnings.

Work completed.


Guess a Unix standard value for OPENIMAGEIOHOME when undefined

This way the package openimageio-tools can work out-of-the-box on Debian &
Ubuntu.
Of course, if they are compiled with the right options for openShadingLanguage...

This makes sense.


fix in browser the cookie remained then session returned string type

fix in browser the cookie remained then session returned string type

thanks! :)


Increase the number of vehicle flow in generator

When I run the generator, it by default only generates four vehicle data in the flow.json. How can I increase this?

You can change --interval (seconds between two consecutive vehicles) to increase the number of vehicles.
By default, the generator will generate vehicles with straight routes (without any turns). If you turn on --turn, it will create 8 more routes (from one corner to opposite corner).
The generator is a tool for simple roadnet and flow. If you need more complicated routes, you need to add them to flow.json by yourself.

Thanks for the reply. I added --interval=0.3 (it was 2 by default) and added --turn too. But, still it only includes four vehicle records. Any suggestion?

When I run python generate_grid_scenario.py 1 1 --turn, there are 12 flows in flow.json.
What do you mean by four vehicle records?
Also to notice, if you set interval to 0.3, then when running simulation, the interval in config file should be smaller values like 0.1 or 0.3, it won't generate as much vehicles as you want if you set the simulation interval to 1.0 (as for each simulation step time goes by 1 second but you told the simulator to generate a vehicle every 0.3 second)

Yes, you are right. I got a new file flow_turn.json, and I was looking into flow.json.
But, still it generates 12 flows. How can I get 1000 flow?


Unable to set the subprotocol on connection

The WebSocketResponseHandshake class provides the ability to set the subprotocol, but a default handshake is created during the WebSocketClientBase.OpenAsync method and as far as I can tell it's not possible to set the subprotocol when opening the connection.
This is needed to connect to certain servers.

Thanks for the commit !

No worries.
I've been doing some work recently on getting WampSharp working with a PCL websocket library, and this change was needed.
If you're able to do a release at some point with the sub protocol changes that would greatly assist me as I don't want to put the stuff from my fork onto NuGet and create a potentially confusing alternative to your library!


Product with no shopping method can't be checked out nor removed from cart

What I'm trying to achieve
Order and purchase a digital product.
Steps to reproduce the problem

Create a product type that doesn't require shipping
Create product with product type created in previous step
Add product to cart
Add billing method and proceed to checkout
/checkout/review fails with message: checkout.shippingMethod is null
Go back to homepage, deleting the product from dropdown cart doesn't work
Deleting product from cart in the shopping bag page doesn't work, popup error message:

Error
Could not add item Loading widget (111). Only 0 remaining in stock.

However there are plenty in stock
What I expected to happen
Be able to purchase a digital product
System information
Operating system: Elementary OS
Browser: Firefox
Created using the saleor-platform repo

@samuelOsborne Hi there! Thank you for reporting. We'll investigate it as soon as we can. It looks like a bug...

Fell into the same issue. I suppose the cart should just ignore the delivery cost in this situation.

Did anyone find a working solution for this?

Hey, we're looking into this, should be fixed this week.

@samuelOsborne @dsbrgg @boreBoar Can you please update to the newest master and see if the issue is resolved now for you?


added 1 package - bugphix

bugphix - Capture and monitor detailed error logs with nice dashboard and UI

Not enough stars: https://github.com/chiraggude/awesome-laravel/blob/master/CONTRIBUTING.md


HS_ADMIN value is added as a string and NOT a integer

Debugging shows that the HS_ADMIN index value is added as a string:
DEBUG:b2handle.handlesystemconnector:PUT Request payload: {"values": [{"index": 100, "type": "HS_ADMIN", "data": {"value": {"index": "200", "handle": "0.NA/841", "permissions": "011111110011"}, "format": "admin"}}, {"index": 1, "type": "URL", "data": "www.test.com"}]}

While it should be:
DEBUG:b2handle.handlesystemconnector:PUT Request payload: {"values": [{"index": 100, "type": "HS_ADMIN", "data": {"value": {"index": 200, "handle": "0.NA/841", "permissions": "011111110011"}, "format": "admin"}}, {"index": 1, "type": "URL", "data": "www.test.com"}]}

This can be fixed in  handleclient.py with a dirty fix as follows:
        # If the handle owner is specified, use it. Otherwise, use 200:0.NA/prefix
        # With the prefix taken from the handle that is being created, not from anywhere else.
        if handleowner is None:
            adminindex = 200
            prefix = handle.split('/')[0]
            adminhandle = '0.NA/'+prefix
        else:
            adminindex, adminhandle = utilhandle.remove_index_from_handle(handleowner)

        adminindex=int(adminindex)

        data = {
            'value':{
                'index':adminindex,
                'handle':adminhandle,
                'permissions':permissions
            },
            'format':'admin'
        }

The new added line is:
        adminindex=int(adminindex)

Issue closed, see PR #54 , this will be release 1.0.1.


Feature Request: SetCallChannelName

Hi is it possible to request a CallChannel name set so that when (for us maybe others) we use random generated SQL id's to connect the Call channel for both players to the same channel, would be good if we can actually set the channel name so that we can display either persons number as the channel instead?
Regards
Chris,

I'll add this in the next version


[Jest Circus] Make hooks in empty describe blocks error

Fixes #6293

@SimenB It should probably be a part of the Jest Circus changelog entry. Any idea where to write that in the mean time?

something like
### Features

* `[jest-circus]` Make hooks in empty describe blocks error ([#6320](https://github.com/facebook/jest/pull/6320))

?

@aaronabramov the test in test thing can be even worse, FB apparently needs hooks inside tests: #6098.

@aaronabramov It looks like tests within tests are explicitly supported. In fact, that's how test.each works. cc @mattphillips


Cannot use relative jsc.baseUrl anymore in .swcrc config

Describe the bug
I recently upgraded from "@swc/core": "^1.3.70" to "@swc/core": "^1.3.76", and my configuration does not compile anymore.
Input code
Running the compile command:

npx swc package --config-file .build.swcrc --copy-files -d dist

Config
In my `.build.swcrc` file.

{
  "jsc": {
    "baseUrl": ".",
    "transform": {
      "react": {
        "runtime": "automatic",
        "importSource": "react"
      }
    },
    "parser": {
      "syntax": "typescript",
      "tsx": true
    },
    "target": "es2022",
    "loose": false,
    "minify": {
      "compress": false,
      "mangle": false
    },
    "paths": {
      "@components/stateless": [
        "package/components/stateless"
      ],
      "@components/stateful": [
        "package/components/stateful"
      ],
      "@internal": [
        "internal-components"
      ],
      "@contexts": [
        "package/contexts"
      ],
      "@hooks": [
        "package/hooks"
      ],
      "@lib/backend": [
        "package/lib/backend"
      ],
      "@lib/api": [
        "package/lib/api"
      ],
      "@lib": [
        "package/lib"
      ],
      "@public/*": [
        "package/public/*"
      ],
      "@styles/*": [
        "package/styles/*"
      ]
    }
  },
  "module": {
    "type": "es6",
    "strict": false,
    "lazy": true,
    "noInterop": false
  },
  "minify": false
}

Playground link
No response
Expected behavior
I expect a compilation success (worked well up until at least "@swc/core": "^1.3.70")
Actual behavior
I get this error during compilation:
thread 'thread '<unnamed><unnamed>' panicked at '' panicked at 'base_dir(.) must be absolute. Please ensure that `jsc.baseUrl` is specified correctly.base_dir(.) must be absolute. Please ensure that `jsc.baseUrl` is specified correctly.', ', /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/swc_ecma_transforms_module-0.173.28/src/path.rs/Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/swc_ecma_transforms_module-0.173.28/src/path.rs::104104::1313

Version
"@swc/cli": "^0.1.62"
Additional context
No response

you can close this issue as it's duplicated with https://github.com/swc-project/swc/issues/7800


[Schema][HostConfig] Host Config schema needs to be updated to reflect 1.3 changes

Details
Although the Adaptive Cards schema has been updated to reflect the new Input Validation changes, the HostConfig schema has not. We need to add the inputs functionality to the schema (host-config.json) and also update the corresponding docs page (https://docs.microsoft.com/en-us/adaptive-cards/rendering-cards/host-config).

[x] Update schema (#4581)
[ ] Update docs

For the documentation, it looks like the documentation was updated manually in MicrosoftDocs/AdaptiveCards#322. We have a tool to generate those docs, but that tool only generates the first layer of the schema, not sublayers. In this case, the manual documentation documents all relevant objects (InputsConfig, LabelConfig, InputLabelConfig, and ErrorMessageConfig), whereas the generated schema only would document the top layer (InputsConfig). Because of this, I am not going to update the docs using the tool. Logged #4698 to track improving the tool to be able to generate those docs for us.


CheckProjectCompiles.vbs "Wrong number of arguments or invalid property assignment:'StdErr'

As it says. This happens running main.vbs. 14.1. v<IP_ADDRESS>. Both Altium v14 and v15 suffer of both problems.

After that the menu comes up and I reselect the footprint I was working on and select "renumber pads" and boom, exceoption in scriptingsystem.dll.dll

Perhaps I'm just being stupid and don't understand the correct procedure. Open project, run script and pick "main"..

Thanks for noting! Your doing things correctly, this I my fault, and it should be fixed in the latest version (v<IP_ADDRESS>). Let me know if this works for you and then this issue can be closed.

Fixed.


feat: add isAccessibilityStateEnabled

Summary

fix #30863
This PR adds isAccessibilityServiceEnabled to get if accessibility services are enabled on Android.
Changelog

[Android] [Added] - Added isAccessibilityServiceEnabled to get if accessibility services are enabled
Test Plan

Thank you for submitting this @grgr-dkrk! I've added your PR to the Improved React Native Accessibility board. Thank you for your contribution to a more accessible React Native.

This is interesting - so this listens for any change? cc @blavalla I know we discussed this a bit, would the potential use case for this be to listen for changes so as to be able to update the layout (or similar) if, for example, TalkBack was turned on/off? So you'd need to listen for changes, and then check if TalkBack is on with another function call.

This is interesting - so this listens for any change? cc @blavalla I know we discussed this a bit, would the potential use case for this be to listen for changes so as to be able to update the layout (or similar) if, for example, TalkBack was turned on/off? So you'd need to listen for changes, and then check if TalkBack is on with another function call.

Yeah, thats the general idea. Although we already have a method specifically for talkback with screenReaderChanged.  This would be able to detect any service changing, since on Android there can be 3rd party accessibility services, the API google provides doesn't have methods for specific services (talkback, switch access, etc.) like iOS does.


Cannot install  wdi5@latest due to fibers package (EINVAL)

Describe the bug
I cannot perform
npm i wdi5@latest
Expected behavior
A regular installation process
Logs/Console Output
if applicable, please copypasta code-fenced log output, e.g.
PS path\zproject> npm install wdi5@latest
...
npm error code 1
npm error path path\zproject\node_modules\fibers
npm error command failed
npm error command C:\Windows\system32\cmd.exe /d /s /c node build.js || nodejs build.js
npm error node:internal/child_process:421
npm error     throw new ErrnoException(err, 'spawn');
npm error     ^
npm error
npm error Error: spawn EINVAL
npm error     at ChildProcess.spawn (node:internal/child_process:421:11)
npm error     at Object.spawn (node:child_process:761:9)
npm error     at build (C:\projects\zproject\node_modules\fibers\build.js:62:5)
npm error     at Object.<anonymous> (C:\projects\zproject\node_modules\fibers\build.js:51:3)
npm error     at Module._compile (node:internal/modules/cjs/loader:1358:14)
npm error     at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
npm error     at Module.load (node:internal/modules/cjs/loader:1208:32)
npm error     at Module._load (node:internal/modules/cjs/loader:1024:12)
npm error     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12)
npm error     at node:internal/main/run_main_module:28:49 {
npm error   errno: -4071,
npm error   code: 'EINVAL',
npm error   syscall: 'spawn'
npm error }
npm error
npm error Node.js v20.15.0
npm error 'nodejs' is not recognized as an internal or external command,
npm error operable program or batch file.

Runtime Env (please complete the following information):

Windows 10 / 11
NodeJS 20.15.0

**Other
The author of this package recommends not to use it:
https://github.com/laverdet/node-fibers

fibers is no longer required for any wdio/wdi5 installation - odd that it still seems to be pulled in your case. I have seen somewhat similar behaviour in the past when non-LTS versions of node were used. Could you try upgrading your Node 20 install to 20.15.1?

NodeJS has been updated to 20.15.1 and I still have the issue. It tries to get 'fibers'. It is a managed laptop; could it be a issue related to that? I could try the same at my home PC this evening. Or might is be a NodeJS caching issue (i'm not an expert).

sounds suspiciously like a caching/proxy issue. any previous versions for wdi5 installed the folder you're working in (check package.json for wdio-ui5-service) and/or any package-lock.json you could try deleting?

I could not find anything like that. package-lock.json and node_modules was deleted. I also ran npm cache clean --force.
Afterwards I completely reinstalled nodejs: https://stackoverflow.com/questions/20711240/how-to-completely-remove-node-js-from-windows
And I still get the error with the fibers package.

You are trying to install the wrong and outdated hybrid package: https://www.npmjs.com/package/wdi5
You want to install wdio-ui5-service.
Use following command:
npm init wdi5@latest

You are trying to install the wrong and outdated hybrid package: https://www.npmjs.com/package/wdi5
You want to install wdio-ui5-service.
Use following command:
npm init wdi5@latest

This was the solution (npm init wdi5@latest instead of npm i wdi5@latest). Thx!


proxy/remove tokio postgres

Problem
tokio-postgres does too much for us and hides important information that we need to action on. we could either continue adding more to our fork, or accept defeat and lower the abstraction level.

Use the ReadyForQuery status byte (either 'I' for idle, 'T' for in a transaction, or 'E' for in a failed transaction) to determine how we return the connection back to the pool
Handle prepared statements/type checking properly and in the correct order.

Summary of changes
A lot of stuff. Not finished yet either - opening the PR for discussion while I focus on more important things for now. Should be reviewed with extra caution and this change needs a lot more tests

Create a Connection type not too dissimilar to tokio-postgres::Connection.
Allow preparing, type checking, and executing queries directly on a connection (no Client abstraction)
Make use of the ReadyForQuery status byte in order to handle bad transaction states of the connections before returning them to the pool.

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

does this only support plain text protocol (as query_raw_txt code path) or both plain + extended protocol? (or it does not matter...?)

does this only support plain text protocol (as query_raw_txt code path) or both plain + extended protocol? (or it does not matter...?)

Both, really. This execute function is text protocol only for now. But I have also used the binary format for type-checking
Since we interface directly with the protocol, we can do whatever. The hard part will be abstracting this logic.
@vadim2404 asked me to make this PR a bit simpler/split-up, so I think I plan to first make this raw connection into a separate crate in libs/ that we can merge in with tests, and then migrate proxy to use it after


Frozen Half the Time

Many times when a user puts their thumb on the screen, the virtual joystick doesn't respond.
Observe on Android version here: https://samsarette.itch.io/not-a-halloween-game
Source for Project here: https://github.com/lunarcloud/not-a-halloween-game

I'll continue to look into whether it's simply my implementation of it

Removed the
if distCirc_eventPos <= halfBigCircleSize:
requirement for it to be pressed.


OCR

:books: Documentation preview :books:: https://ploomber-doc--34.org.readthedocs.build/en/34/

a user reported the same issue when adding pytorch as a dependency to the image, I believe this is a similar issue. I need to spend some time investigating. let's pause this for now

I believe there are still a few issues you can work on, right?

@neelasha23 good news. I was able to fix this:

I'll open a PR to cloud repository, and we'll release this tomorrow

Yes I have other issues. Please provide feedback on the OCR app so that I can work on it too @edublancas

the app looks good. I'd only change the text:

This Solara app is designed for extracting text from images

for

This app can extract text from images. Drop an image in the box to the left to get started or click on "Sample image"

the app is here btw: https://royal-rain-7673.dev.ploomberapp.io/ - you might wanna test
note that it'll be deleted in a few hours by our CI since this is in the dev environment

I have made the suggested changes. Please review @edublancas

great! We'll deploy this to showcase it once the fix for the docker step is in


Fix: reserved words (fixes #365)

Fixes #365
https://github.com/ternjs/acorn/blob/master/src/statement.js#L616
https://github.com/ternjs/acorn/blob/master/src%2Flval.js#L175
parseImportSpecifiers seems to be checking whether or not the identifier is a reserved word. But class is not being handled as a reserved word.
https://github.com/ternjs/acorn/blob/master/src/identifier.js#L13-L15
The cause is that if ecmaVersion is 6, reserved words are only enum.
So I modified the definition of reserved words correctly.
But I see the message of checkLVal, the purpose of this method might be different from this PR's purpose.

You shouldn't really modify reservedWords - those are just reserved words that are not keywords. You can check against keyword separately.

As far as I can tell, the problem in this case is that in ES6 class moved away from reserved words to keywords, whilst checkLVal continues to check only against reserved words. So there are two options: 1) modify checkLVal itself or 2) concatenate keywords[] here https://github.com/ternjs/acorn/blob/49393686340720f9cab5a62ce2e25515c41c5f45/src/state.js#L18.
@marijnh Maybe you want to take a look, what do you think?

Actually, state.js uses reservedWords to make Parser#reservedWords, but others don't use reservedWords of identifier.js.
And the spec says ReservedWord includes Keyword.
So I modified it.
What is the reason that reservedWords doesn't include keywords?

I will change approach.


[SPARK-47671][Core] Enable structured logging in log4j2.properties.template and update docs

What changes were proposed in this pull request?

Rename the current log4j2.properties.template as log4j2.properties.pattern-layout-template
Enable structured logging in log4j2.properties.template
Update configuration.md on how to configure logging

Why are the changes needed?

Providing a structured logging template and document how to configure loggings in Spark 4.0.0
Does this PR introduce any user-facing change?

No
How was this patch tested?

Manual test
Was this patch authored or co-authored using generative AI tooling?

No

cc @dtenedor @panbingkun as well.

@dongjoon-hyun I double checked and removed some comments. PTAL, thanks!

Thank you. Merged to master, @gengliangwang !


Adding baseurl so workflow file can change it for web preview

Without this inclusion the /web-preview is not getting prepended to all the urls which will break all the links for the preview page

I am closing this so I can make all the necessary changes for the web preview in one go


[openimageio] with plugins build failure

Host Environment

OS: [e.g. Windows/Linux etc...]
Compiler: VS2019

To Reproduce
Steps to reproduce the behavior:
vcpkg install openimageio[ffmpeg,freetype,gif,libraw,opencolorio,opencv,openjpeg,pybind11,tools,webp] --recurse
Failure logs
`Computing installation plan...
The following packages will be built and installed:
    openimageio[core,ffmpeg,freetype,gif,libraw,opencolorio,opencv,openjpeg,pybind11,tools,webp]:x64-windows -> <IP_ADDRESS>#1
Detecting compiler hash for triplet x64-windows...
Could not locate cached archive: C:\Users\Vlad\AppData\Local\vcpkg\archives\5f\5ffcb080a6f72b66a9515e894c5fe0eeefaa261cca7f5464259b9fc1a961d933.zip
Starting package 1/1: openimageio:x64-windows
Building package openimageio[core,ffmpeg,freetype,gif,libraw,opencolorio,opencv,openjpeg,pybind11,tools,webp]:x64-windows...
-- Using E:/VisualStudio/vcpkg/downloads/OpenImageIO-oiio-099c8585e3add6f58fab9aa438a491fa55d3f67e.tar.gz
-- Cleaning sources at E:/VisualStudio/vcpkg/buildtrees/openimageio/src/fa55d3f67e-731af77137.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source E:/VisualStudio/vcpkg/downloads/OpenImageIO-oiio-099c8585e3add6f58fab9aa438a491fa55d3f67e.tar.gz
-- Applying patch fix-config-cmake.patch
-- Applying patch fix_static_build.patch
-- Using source at E:/VisualStudio/vcpkg/buildtrees/openimageio/src/fa55d3f67e-731af77137.clean
-- Found external ninja('1.10.2').
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: ninja -v
    Working Directory: E:/VisualStudio/vcpkg/buildtrees/openimageio/x64-windows-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      E:\VisualStudio\vcpkg\buildtrees\openimageio\config-x64-windows-out.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:398 (vcpkg_execute_required_process)
  ports/openimageio/portfile.cmake:49 (vcpkg_cmake_configure)
  scripts/ports.cmake:141 (include)

Error: Building package openimageio:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: openimageio:x64-windows
  Vcpkg version: 2021-08-12-85ab112d5ee102bc6eac8cdbbfdd173a71374e04

Additionally, attach any relevant sections from the log files above.`

config-x64-windows-out.log
Additional context
openimageio 2.2.10 was built correctly,
2.2.17 can't be build with all plugins.
also in both versions openimageio[field3d] never built with warning about No Windows support.

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
LibRaw_r_LIBRARY
    linked by target "OpenImageIO" in directory E:/VisualStudio/vcpkg/buildtrees/openimageio/src/fa55d3f67e-731af77137.clean/src/libOpenImageIO

Confirmed.

Sorry. Can anyone return to this bug please? It not fixed yet :(

Related issue: https://github.com/microsoft/vcpkg/issues/20614

Sorry but openimageio with libraw x64-windows still not building.
For this moment two plugins libraw and pybind11 are not working in openimageio plus field3d that not compatible with windows.


Handling leading zeros for excel

Is there a way to handle formatting for leading zeros in the manner outlined here
https://stackoverflow.com/a/814194
Tried to find documentation that would allow this, but it wasn't clear if this is supported

It's not supported, but pull requests are welcome.


discuss

testing 123

I guess we can use this for messaging.
So much better than needing to type on phone. :)

If you're okay with it I can go ahead and implement the bold feature.
I'll do it with ASCII escape codes, e.g.
// escape char (U+001B)
const E: char = 0x1B as char

fn bold(text: &str) -> String {
	format!("{}[1m{}{}[0m", E, text, E)
}

table.add_row(row![bold('whatever'), "=", "value"])

Yeah, go ahead. Though I noticed that your fork is 9 commits behind for some reason.
Also, how is it going to be implemented? I assume that the if statement I made for caps will be nested in the if statement you made for bold (well twice actually)?

I'm planning to create a function for adding rows, to make the code cleaner.
Here's the partially finished function:
fn addrow(
		table: Table,
		bold: &str,
		caps: &str,
		title: &str,
		value: String
	) -> Table {
	if caps == "false" {
		value = value.to_lowercase();
	}
	if bold == "false" {
		value = bold(value);
	}
	table.add_row(row![title, "=", value]);
	return table
}

ALSO a little help needed here, my knowledge of Rust is a little... rusty.
This line right here:
String::from_utf8_lossy(&dist.stdout)

What does it return? A String or a &str? The compiler is complaining of a type mismatch with a cow or something.

The code could definitely look prettier, so it's greatly appreciated.
As for:
String::from_utf8_lossy(&dist.stdout)

I honestly don't really know either (I used Stack Overflow for this and it didn't really explain it). I know it takes stdout from the dist variable, but I don't really know what it is.
I found that you can do this:
String::from_utf8_lossy(&dist.stdout).to_string()

to convert it to a string, but then you have to make sure to trim the "\n" that gets appended to it for some reason.

nevermind, I fixed it by using a reference:
&String::from_utf8_lossy(&dist.stdout).to_string()

Oh, ok. Cool.
If you don't mind me asking, what is the difference between &String and String?
Forgive me if this is a very novice question.

Adding the & to that line does not change what function we are calling, it changes the return type of that function (std::borrow::Cow<>, no idea what that's for) to a &str.

Huh, interesting. Wish I would've known that. Would've saved me a headache a couple days ago.
Thank you for the info.

Here's an image of what it looks like now, sorry I didn't crop the image.

BTW what 'valley' for? Is it your username or something?

sorry I didn't crop the image

It's fine. Cropping doesn't really matter.
You're right, it looks a lot better with bolding.

BTW what 'valley' for? Is it your username or something?

Yeah. I kinda stole it from a book, but I really like the name. I just threw it in there as like a logo or something, but I did make an option to turn it off. Maybe I'll turn it off by default.

You're right, it looks a lot better with bolding.

How 'bout I make bolding default? Oh wait - how do I do that?

BTW I think you should remove Windows support. Because you are using Linux-only processes for the job (e.g. /usr/bin/bash, uname, etc.)

So you know how I made the command line switches?
Go to:
let matches = App::new("fetch")

Make a new .arg like this.
.arg(Arg::with_name("bold")
    .short("b")
    .long("bold")
    .value_name("BOOL")
    .help("Turn bolding on or off.")
    .takes_value(true))

Next, you see how I have the variables like:
let caps = matches.value_of("caps").unwrap_or("true");

Make this:
let bold = matches.value_of("bold").unwrap_or("true");

Then you would just make an if statement like you showed in your previous statement.
if bold == "true" {
    do stuff
}

BTW I think you should remove Windows support.

Probably. At least for now. I have a friend who uses W10 who seems real interested in this, so some time I think it'd be really cool to have a Windows version of this (or maybe a Windows option or something).

There are already tools for the job, one of which I created. See WindowsScreenfetch and winfetch.

Good point, consider support dropped. Winfetch looks really nice by the way.

OK, I've submitted a PR for the bold feature

So I just merge the request right?
Sorry for asking probably trivial questions, I've never actually worked with others on Github so I don't really know how a lot of it works.

Yeah. Check out diffs of the changes I've made, then merge.

Merged.

I'd say this calls for a major version change.
0.9.8 -> 1.0.0
As a good deal of things were changed (for the better).

Any other ideas on what we could do?

one second...

Although if we implement the above, you'd have to update the screenshots again. :wink:

We could also implement a feature which allows the user to specify custom ASCII art from a file instead of the default 'valley'.

I personally wanted to use the table because it can automatically draw a border around the output, but we can make an option for what you suggested.

We could also implement a feature which allows the user to specify custom ASCII art from a file instead of the default 'valley'.

I love that idea.

I love that idea.

OK, I'll start :)

How does this look for no borders and equal signs?

looks ugly. I meant to align it like so:
            USER   kiedtl
            HOST   Aspire E5-576
          UPTIME   20 hours, 43 minutes
OPERATING SYSTEM   *nix
          DISTRO   Arch Linux
          KERNEL   5.0.9-arch1-1-ARCH
  WINDOW MANAGER   gnome-session
           SHELL   /usr/bin/zsh
        TERMINAL   alacritty
      IP ADDRESS   <IP_ADDRESS>
        PACKAGES   1064

Let me just figure out text alignment real quick then, and I'll get it set up that way.

Here's what I did in another project.

print 20 spaces minus length of title.
print 2 spaces
print the value

OK, since Windows support was dropped I'll remove that entirely.

I already did in my last commit.

Why does text alignment have to be so difficult in Rust?

Why does text alignment have to be so difficult in Rust?

Huh? I don't think it's difficult...
Try this function:
fn print_field(name: &str, value: &str) {
    let spc: u32 = 20;
    let ctr: u32 = spc - name.chars().count();
    for x in 0..ctr {
        print!(" ");
        io::stdout().flush();
    }
    print!("{}", makebold(name));
    io::stdout().flush();
    println!("  {}", value);
}

Done.

That screenshot look nice.
And trying out your function now.

Am I using your function right?
print_field("MUSIC (MPD)", &String::from_utf8_lossy(&mus.stdout));

No no no. Modify the addrow function so that it looks like this:
fn addrow(
		abold: &str,
		caps: &str,
		title: &str,
		value: &str
	) {
	let mut title_str: String = title.to_string();
	if caps == "false" {
		title_str = title_str.to_lowercase();
	}
	if abold != "false" {
		title_str = makebold(&title_str);
	}
	print_field(title_str, value);
}

I was hoping you wouldn't make that particular mistake. =(

I knew I was doing something wrong. Oh well, all I can do from here is learn right?

Just undo your changes, add the print_field function, and modify the addrow function. Should work then.

error[E0433]: failed to resolve: use of undeclared type or module `io`
  --> src/main.rs:42:9
   |
42 |         io::stdout().flush();
   |         ^^ use of undeclared type or module `io`

error[E0433]: failed to resolve: use of undeclared type or module `io`
  --> src/main.rs:45:5
   |
45 |     io::stdout().flush();
   |     ^^ use of undeclared type or module `io`

error[E0308]: mismatched types
  --> src/main.rs:39:26
   |
39 |     let ctr: u32 = spc - name.chars().count();
   |                          ^^^^^^^^^^^^^^^^^^^^ expected u32, found usize

error[E0277]: cannot subtract `usize` from `u32`
  --> src/main.rs:39:24
   |
39 |     let ctr: u32 = spc - name.chars().count();
   |                        ^ no implementation for `u32 - usize`
   |
   = help: the trait `std::ops::Sub<usize>` is not implemented for `u32`

error[E0308]: mismatched types
  --> src/main.rs:63:14
   |
63 |     print_field(title_str, value);
   |                 ^^^^^^^^^
   |                 |
   |                 expected &str, found struct `std::string::String`
   |                 help: consider borrowing here: `&title_str`
   |
   = note: expected type `&str`
              found type `std::string::String`

error: aborting due to 5 previous errors

Some errors occurred: E0277, E0308, E0433.
For more information about an error, try `rustc --explain E0277`.
error: Could not compile `fetch`.

To learn more, run the command again with --verbose.

oh well. Change ctr type to usize, then try removing the flush statements. I think it will work without them.

Huh, isn't that odd. If you change u32 to usize, rust complains about expecting u32. But if you go the opposite it complains about expecting usize.

try this:
let spc: usize = 20 as usize;
let mut ctr: usize = spc - (name.chars().count() as usize);

thread 'main' panicked at 'attempt to subtract with overflow', src/main.rs:39:23
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

one second...

And this is what it output before crashing.
 \    / /\   |    |    |--- \   /
  \  / /__\  |    |    |---  \ /
   \/ /----\ |___ |___ |---   |
        USER  valley

        HOST  OptiPlex 7010

      UPTIME  10 hours, 34 minutes

      DISTRO  Arch Linux
      KERNEL  5.0.10-arch1-1-ARCH

Hmmmmm... I just can't figure out what is causing the newlines, but I realized that the spc variable must be greater than the length of the longest field title. Just increase the spc variable to 25.

It worked. Newlines are being appended from somewhere right? Maybe if we truncate the last 2 characters of the contents of the variables, it'll remove the "\n" that's being appended from somewhere. Or maybe we're adding so many spaces that it's hard-wrapping the text?

@Phate6660 I'm beginning to wonder whether we should just leave this alignment issue be - after all, this is supposed to be minimalistic. I can't get this to work, because of the newline problem.

Do you want to leave the no borders option in, or remove both alignment and no borders?

Maybe if we truncate the last 2 characters of the contents of the variables, it'll remove the "\n" that's being appended from somewhere.

But if there is no newline on some of the fields, then it will truncate the actual string.

Do you want to leave the no borders option in, or remove both alignment and no borders?

We can add an option for no borders, but I think this should be disabled by default.

Cool, I already had that implemented before attempting the aligning stuff. Now I just need to commit then.

I commited my stuff. I assume you'll submit a pull request again like before?

Sure.

I noticed that there are now two addrow functions - what's the difference?

The 2nd removes the "=" from the table.

For use with no borders.

Hey, I'm going to go to sleep, as I've been up for a couple days.
I'll be back on in anywhere between a few hours and tomorrow morning (at latest).

what do you think if we used ■ instead of 0 for the table corners?

Hey, I'm going to go to sleep, as I've been up for a couple days.

I'll be back on in anywhere between a few hours and tomorrow morning (at latest).

OK.

I'm back on. Squares look nice.
Sorry about making you wait though, I was very tired.

No problem!
OK - one more thing. I've added a Makefile. (You know what that is right?)

Yeah, I know what a makefile is. Thanks for adding one. :)
I really liked the idea of just calling it "fetch". Afaik, most of the other fetch tools are called things like "neofetch", "ufetch", "screenfetch", etc; So I figured there wouldn't be a problem.
Also, I swear that I just reloaded this page like 10 minutes ago and it never showed your reply. So imagine my surprise when I saw that you commented apparently 4 hours ago.

Also, your pull request has just been merged.

Also, I swear that I just reloaded this page like 10 minutes ago and it never showed your reply. So imagine my surprise when I saw that you commented apparently 4 hours ago.

Yeah, that happened to me too :)

Hey, I just added an option to use either "0"s or "■"s for the corners.
Only because when I tried it out, the font I was using made the "■"s off center and it was bothering me.
Going to commit it unless you have objections.

Going to commit it unless you have objections.

Thats awesome. Thanks.


Elasticsearch sink namespace and type

HI,
Need Help,
I am using latest version of transporter, my pipline.js is as follow, I am facing problem to create the elastic search type, I am not sure where I do I need to provide, its creating type as public.<postgres namespace> (in this case public.errors)
var source = postgres({
  uri:"host=postgres sslmode=disable dbname=exceptions user=postgres",
  debug: true,
  tail: true,
  replication_slot: "exception_replica_slot"
})

var sink = elasticsearch({
  uri: "http://elasticsearch:9200/exceptions",
});

t.Source("source", source, "errors")
  .Transform(pretty({}))
  .Save("sink", sink);

Even though I pass type as third argument to Save(Save("sink", sink, 'errors')) its not working.
Am I doing something wrong

hi @kishorevarma, the elasticsearch adaptor will pull the type name from the originating source namespace which in your case is public.errors. The 3rd parameter to the Source and Save function is a namespace filter which is why the only table getting processed is errors but when postgresql sends the message down the pipeline, it sets the namespace to public.errors. Also, if a namespace filter is not provided then the default filter set is .* which is effectively a catch all.
In your case, you'll need to create a goja JS transformation function to alter the namespace before it reaches the elasticsearch adaptor. I plan to add a native one in the near future but for now, the following should work:
var source = postgres({
  uri:"host=postgres sslmode=disable dbname=exceptions user=postgres",
  debug: true,
  tail: true,
  replication_slot: "exception_replica_slot"
})

var sink = elasticsearch({
  uri: "http://elasticsearch:9200/exceptions",
});

t.Source("source", source, "errors")
  .Transform(goja({"filename":"trim_ns.js"})
  .Transform(pretty({}))
  .Save("sink", sink);

and the trim_ns.js file would be:
function transform(doc) {
    doc["ns"] = "errors";
    return doc
}

Awesome explanation, I got it now. thanks @jipperinbham

Hi @jipperinbham, another doubt not related to this issue, whats the difference between
goja and otto functions, I see both are same, I hope there might be some difference

https://github.com/compose/transporter/wiki/Q%26A

Awesome , I am closing issue now


Avoid compression

Is there any way to avoid video compression?
I only need to get the thumbnail of a video, the compression is slow and I will not use the video anyway.

I was looking also for an answer to this issue, how can i skip compression ?

I have the same issue with the compression.
Here is a video that I received on WhatsApp:
https://drive.google.com/file/d/1bHEs-iUAS-qPYFiqOeHKFm0aZyBxJEso/view?usp=sharing

@s4cha  @NikKovIos  any thoughts on this guys :)? For a recorded video of 1 minute, it takes about 30-35  seconds to fetch...

By now there are no functional to avoid compression. I think it should be an enum to select what type we need. But without compression we can not crop.

Hi @DanielZanchi @hezhez @nastasiupta
I think th option you're looking for is:
config.video.compression = AVAssetExportPresetPassthrough

as per the Apple documentation states
/* This export option will cause the media of all tracks to be passed through to the output exactly as stored in the source asset, except for
   tracks for which passthrough is not possible, usually because of constraints of the container format as indicated by the specified outputFileType.
   This option is not included in the arrays returned by -allExportPresets and -exportPresetsCompatibleWithAsset. */

I tried on my side with a big video and it seems to do the trick. It will also bypass crop since it gives the raw video. It is not instantaneous for long videos but it seems to be 10x faster than when using compression presets.
Let me know if that works on your side :)

@DanielZanchi have you been able to try out AVAssetExportPresetPassthrough ?

@DanielZanchi have you been able to try out AVAssetExportPresetPassthrough ?

Yes. It works fine

@DanielZanchi have you been able to try out AVAssetExportPresetPassthrough ?

Yes, works fine with AVAssetExportPresetPassthrough ;)

Why there are delays if I pick 2 videos and tap on the next button


Initial Support for Laravel 5.3

This is a WIP. Awaiting release of 5.3.

PR was a bit premature.


Disjoint unions scoping

Hey there!
I recently started using redux-pack and I noticed that the disjoint unions don't work correctly if I use the disjoint type inside a sub-function of the switch.
It's a bit hard for me to explain the issue by text, so I created a working example, you can test it directly in the try section of the Flow website.
Thank you in advance!
/* @flow */
// ======================================================
//   ACTIONS
// ======================================================
type Action =
  { type: 'LOGIN', username: string, password: string }
| { type: 'FETCH_MESSAGES', messages: Array<string> }

// ======================================================
//   STATE TYPE
// ======================================================
type State = {
  username: ?string,
  password: ?string
}

// ======================================================
//   INITIAL STATE
// ======================================================
const initialState: State = {
  username: null,
  password: null
}

// ======================================================
//   FAKE HANDLE FUNCTION (from redux-pack)
//   This is not specific to the issue, this can be any
//   function that accept other functions as parameters.
//   Here the 'options' parameter is a set of functions,
//   just check the reducer below for more info.
// ======================================================
const handle = <S, A, O>(state: S, action: A, options: O): S => {
 return state
}

// ======================================================
//   NOT WORKING REDUCER
//   The "scoping" of the disjointed union here get get
//   lost when using the disjointed type inside the scope
//   of another function...
// ======================================================
const reducer2 = (state: State = initialState, action: Action): State => {
  switch (action.type) {
    case 'LOGIN': {
      return handle(state, action, {
        start: (s) => ({ ...s, username: action.username })  // ^ property `username`. Property not found in object type
      })
    }

    default:
      return state
  }
}

// ======================================================
//   WORKING REDUCER
//   ...and creating a `const` with the interested value
//   seems to fix it.
// ======================================================
const reducer = (state: State = initialState, action: Action): State => {
  switch (action.type) {
    case 'LOGIN': {
      const username = action.username // This does the trick
      return handle(state, action, {
        start: (s) => ({ ...s, username: username })
      })
    }

    default:
      return state
  }
}

Flow can't tell when handle is going to call the start callback. For all Flow knows, by the time the start callback is called action.type could have changed, since it's just a property of an object that could be shared with anything else in the program.
Your second reducer is the correct thing to do, although you can shorten it a little with const {username} = action and {...s, username}.

@jesseschalken My bad, you're right, it was so simple.
Sometimes I should just stop and accept whatever Flow tell me 🔮 .
Thanks man!


secret-identifier does not support mixed case key vault name

Describe the bug
Using the secret-identifier switch with a mixed-case key vault fails to work:
az sf cluster create --secret-identifier https://MyPrivateKeyVault.vault.azure.net/secrets/mycertname/mycertid
However, if you create your key vault with a lowercase name, the following does work:
az sf cluster create --secret-identifier https://myprivatekeyvault.vault.azure.net/secrets/mycertname/mycertid
The problem occurs
To Reproduce
Try to create a cluster using an existing mixed-case key vault.
Expected behavior
Mixed-case key vault names should be supported since you can easily create mixed case key vaults within the Azure web interface. Additionally, the error shown the user is currently cryptic and unclear unless pull up the python code and review it.
Additional context
This problem can be corrected by adding .lower() to the vault name comparison in custom.py:1333 so that the new code reads:
vault = [v for v in vaults if v.name.lower() == vault_name]
instead of:
vault = [v for v in vaults if v.name == vault_name]

@tjprescott This issue appears to be an issue in the sf command module not keyvault should this be reassigned?

@schaabs yes, good catch!


Propagate javacOptions in Tests module

I think it would make sense to propagate the javacOptions value of a ScalaModule down to its Tests module by default.
I've tried to include it in https://github.com/lihaoyi/mill/pull/236, but it resulted in an obscure CI error, which I was not able to reproduce on my machine.
I don't have time to work on this, but since I've already spent some time on it without success, I thought it would be beneficial to make future devs aware to my previous attempt.

https://github.com/lihaoyi/mill/commit/26865c6623d57b7a5d774c7bbfe5897609e11acf


[PRM-1632]:  added content when user has fulfilled all obligations

Some todo's to be changed with PRM-1640:

todo 1
todo 2
todo 3


Noty is not defined

Noty version: .....
iam using noty with laravel 5.4 i require noty in bootstrap file but its not defined when iam using it
Browser: .....
OS: .....
jsFiddle link (if available): .....

Sorry, I'm not familiar with Laravel framework. How did you install noty?


[WFLY-13043] Fix error propagation for scheduled tasks

ISSUE: https://issues.redhat.com/browse/WFLY-13043

Not ideal fix, but...

@pferraro Are you able to re-review this one?  A test case has been added and @baranowb responded to your comment about the exception handling.

@darranl Will do.

Sorry, was on PTO. Fixed.

@baranowb are you able to continue this one?  It seems like we reached the end of review comments and just need to finish off CI.

@baranowb Have you had a chance to investigate the test failures for this one? There's also a conflict that needs to be addressed.

Hello, baranowb. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

@pferraro Did you want to re-review this one? CI is now passing for this PR.

@pferraro Actually, ignore that last comment, just realized that all the jobs haven't been run yet.

Hmm, there was conflict. Oddly enough I see single request, but I just dont see where. Is it still valid?

/retest

/retest

/ok-to-test

/retest

/retest

/retest

Thanks @baranowb


Switch to babbage era .. and all kinds of stuff

Follow up of #355
As described in #406 the goal of this PR is to make all packages compile and target Babbage and PlutusV2 everywhere. From there we can start fixing the tests and make this green. Besides "smaller" issues in the hydra-node tests, bigger tasks are listed in #400.

It was a team effort.. no approval necessary ;)


feat(plugin-markdown-hint): add inline rendering support for title

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

[ ] Bug fix
[x] New feature
[ ] Other

Description

Input:
::: important Custom Title `code`

A important container with customized title.

:::

Output:

Screenshots

Before
After

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.839%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
1171

Relevant Lines:
1819

💛  - Coveralls

I think this should be better sent to upstream with a new option


NullPointer Exception

I'm getting an internal NPE related with the uri when the source is set.
I am sure that the uri is not null before set the video uri setVideoUrl(uri.toString());
Could be the issue related with recycled view?
Thank you so much
Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.net.Uri.getScheme()' on a null object reference
at android.media.MediaPlayer.setDataSource(MediaPlayer.java:989)
at android.media.MediaPlayer.setDataSource(MediaPlayer.java:972)
at com.allattentionhere.autoplayvideos.AAH_CustomVideoView.onSurfaceTextureAvailable(S:224)
at android.view.TextureView.getHardwareLayer(TextureView.java:368)
at android.view.View.updateDisplayListIfDirty(View.java:15219)
at android.view.View.draw(View.java:16015)
at android.view.ViewGroup.drawChild(ViewGroup.java:3765)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3555)
at android.view.View.updateDisplayListIfDirty(View.java:15237)
at android.view.View.draw(View.java:16015)
at android.view.ViewGroup.drawChild(ViewGroup.java:3765)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3555)
at android.view.View.draw(View.java:16248)
at android.view.View.updateDisplayListIfDirty(View.java:15242)
at android.view.View.draw(View.java:16015)
at android.view.ViewGroup.drawChild(ViewGroup.java:3765)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3555)
at android.view.View.draw(View.java:16248)
at android.view.View.updateDisplayListIfDirty(View.java:15242)
at android.view.View.draw(View.java:16015)
at android.view.ViewGroup.drawChild(ViewGroup.java:3765)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3555)
at android.view.View.updateDisplayListIfDirty(View.java:15237)
at android.view.View.draw(View.java:16015)
at android.view.ViewGroup.drawChild(ViewGroup.java:3765)
at android.support.v7.widget.RecyclerView.drawChild(S:4581)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3555)
at android.view.View.draw(View.java:16248)
at android.support.v7.widget.RecyclerView.draw(S:3987)
at android.view.View.updateDisplayListIfDirty(View.java:15242)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3749)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3729)
at android.view.View.updateDisplayListIfDirty(View.java:15202)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3749)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3729)
at android.view.View.updateDisplayListIfDirty(View.java:15202)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3749)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3729)
at android.view.View.updateDisplayListIfDirty(View.java:15202)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3749)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3729)
at android.view.View.updateDisplayListIfDirty(View.java:15202)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3749)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3729)
at android.view.View.updateDisplayListIfDirty(View.java:15202)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3749)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3729)
at android.view.View.updateDisplayListIfDirty(View.java:15202)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3749)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3729)
at android.view.View.updateDisplayListIfDirty(View.java:15202)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3749)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3729)
at android.view.View.updateDisplayListIfDirty(View.java:15202)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3749)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3729)
at android.view.View.updateDisplayListIfDirty(View.java:15202)
at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:281)
at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:287)
at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:322)
at android.view.ViewRootImpl.draw(ViewRootImpl.java:2662)
at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:2481)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2091)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1127)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6156)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:892)
at android.view.Choreographer.doCallbacks(Choreographer.java:704)
at android.view.Choreographer.doFrame(Choreographer.java:640)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:878)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5628)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:853)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:737)

I need to see the code to be able to track the problem. One of the things which can cause this is not giving permission to write in external storage on above Marshmallow. If so, go to settings -> apps -> your app and give all permissions.

The error is not reproducible. I'm getting it from Crashlytics, so I'm not sure about the real state. Meanwhile I'm going to check the permission you tell me.
This is the code I have in the card inside the list. Pretty simple.
public abstract class AutoPlayerCard extends AAH_CustomViewHolder {

@BindView(R.id.card_image)
SimpleDraweeView image;

@BindView(R.id.img_playback)
ImageView imgPlayback;

@BindView(R.id.img_vol)
ImageView imgVol;

@BindView(R.id.card_title)
TextView title;

private boolean isMuted = true;

AutoPlayerCard(View view) {
    super(view);
}

@Override
public void refreshHolder(Content content, int width) {
    super.refreshHolder(content, context, width);

    resetState();
    setTitle();

    setMedia(content, width);
}

private void resetState() {
    isMuted = true;
}

private void setTitle() {
    String titleText = DateUtil.getLocallyFormattedDateString(content.getTimestamp());
    AndroidUtil.setText(title, titleText);
}

private void setMedia(Content content, int width) {
    final Uri uri = UriHelper.from(content);
    FrescoHelper.loadOptimized(image, uri, width, null);

    if (uri != null) {
        setVideoUrl(uri.toString());
    }
}

@Override
public void showThumb() {
    image.setVisibility(View.VISIBLE);
}

@Override
public void videoStarted() {
    image.setVisibility(View.GONE);

    imgPlayback.setImageResource(R.drawable.ic_pause);
    handleMuteUnmute();
}

private void handleMuteUnmute() {
    if (isMuted) {
        muteVideo();
        imgVol.setImageResource(R.drawable.ic_mute);
    } else {
        unmuteVideo();
        imgVol.setImageResource(R.drawable.ic_unmute);
    }
}

@Override
public void pauseVideo() {
    super.pauseVideo();
    imgPlayback.setImageResource(R.drawable.ic_play);
}

@OnClick({R.id.img_vol, R.id.card_video})
public void onClickVol(View view) {
    isMuted = !isMuted;
    handleMuteUnmute();
}

@OnClick(R.id.img_playback)
public void onClickPlay(View view) {
    try {
        if (isPlaying()) {
            pauseVideo();
            setPaused(true);
        } else {
            if (!Util.isNullOrBlank(getVideoUrl())) {
                playVideo();
                setPaused(false);
            }
        }
    } catch (Throwable ex) {
        CriticalLogger.error("Error in onClickPlay", ex);
    }
}

Thank you so much

Try setting videoUrl to empty String when URI is null.

Here are the details of the issue. http://crashes.to/s/dfccce3cf1d

I looked into the code but not able to figure out what is causing it. If you could tell me steps to reproduce it, I might be able to track the bug and fix it.

We still don't know how to reproduce it. But we are wondering if the cause could be:

Trying to load source after activity is stopped. As you see in the sent code, we are using your library when we refresh the holder. And also onSurfaceTextureAvailable is called when the view is available. But, have you noticed any issues related with lifecycle?

Using an empty/bad url: before create the card, we are checking that mediaPlayer can load the video with the same uri. But anyway, being sure to set the source with a non-null and non-empty url (string) should be enough to prevent related crashes in your library? Are there any possibility to pass directly the uri to your library instead of the url? we are loading local videos too.

I also have found an issue with Closeable object. It seems that the object is never released. Do you think that we missing anything about the cycle?
A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
                                                               java.lang.Throwable: Explicit termination method 'release' not called
                                                                   at dalvik.system.CloseGuard.open(CloseGuard.java:180)
                                                                   at android.view.Surface.setNativeObjectLocked(Surface.java:459)
                                                                   at android.view.Surface.<init>(Surface.java:145)
                                                                   at com.allattentionhere.autoplayvideos.AAH_CustomVideoView.startVideo(AAH_CustomVideoView.java:74)
                                                                   at com.allattentionhere.autoplayvideos.AAH_CustomViewHolder.playVideo(AAH_CustomViewHolder.java:32)
                                                                   at com.allattentionhere.autoplayvideos.AAH_CustomRecyclerView$3.run(AAH_CustomRecyclerView.java:158)

Hi,
For playing local videos, you can check my answer in this issue: https://github.com/Krupen/AutoplayVideos/issues/23
About Closable Objects, I know of 2 of them (MediaPlayer and FileOutPutStream) which seem to be closed as per code. I will be looking to find more such objects and making sure these 2 gets closed properly every time. So far I think these 2 are closed properly.

Hello @adalpari ,
I just release an update to the library and hopefully it fixes the crash.
In this fix, I have changed MediaPlayer context to Activity's context and added a null check for Activity and DataSource before calling any function on MediaPlayer.
Also there are some performance improvements.
Please update and let me know if fixes the issue.
Also if possible, call holder.setVideoUrl(<source>+"") with an added empty string along with variable so that DataSource is never null.

@adalpari @Yrlec  I hope all the issues are resolved. If not, feel free to reopen this issue.


ReadsToDistmap: do not require maxReadLength

-maxReadLength appears to be a required option, but why?

Can you provide more information? I need the command line that you use and which error was produced after running it. Thanks!

By the way, it isn't an argument in the ReadsToDistmap, but an argument of the ReadLengthReadFilter.
As an optional filter for the trim/filter pipeline on uploading, if you specify --readFilter ReadLengthReadFilter you should also provide --maxReadLength to select the maximum-length to keep on uploading.


[Proposal] Strategy to reduce memory usage

Caffe currently consumes too much memory during the Forward phase. It's mainly because the internal temporary buffer held by the Layer. e.g Convolution Layer need to cache im2col result for gemm operation. These temporary buffer is not shared between layers which causing too much memory usage. Second, since we don't perform backward operation, network internal buffer can also be reused or freed as long as no other layer needs it.
Mini-Caffe should change this situation without breaking any high level API exposed in include (maybe add some APIs).
Some ideas.

Layer who needs temporary memory should requests memory from a global memory source manager. The Manager itself hold the data and borrow the memory buffer to which requests. A memory pool can be implemented or just reuse the same memory and resize if request is too big. The network internal buffer can also be requested through the manager but need to track the dependency of this named blob, return the memory to manager when no other layer needs it. This strategy comes within every Forward phase.

Since Caffe network graph is static, we can plan the memory before forwarding the graph. Some Layer API changes will be helpful. Layer itself should only gives network the memory size it needs and let network holds the memory and borrow it to the layer during Forward. This includes bottom, top and temporary memory. Change Reshape function of every layer. Counting the dependency of network internal blobs, plan the memory and reuse the internal blobs. This strategy comes before every Forward phase.

#31 follows Strategy-1. I Implement a Memory Pool which is transparent to Blob and called by class SyncMem. Add an API for class Blob which can release the memory friendly and Reshape always will realloc SyncMem if size is not equal. Memory Pool hold all memory from CPU and GPU, and only borrow the memory if (real_size, request_size) satisfy some conditions. Since all network internal buffer has a name, track the dependency is pretty easy, Lift time of Blobs combined with Layers, release Blob if no later layer needs it.
Also, the Memory Pool is thread local, And can shared memory between networks in the same thread, Which may be helpful in some situation. Current implement can help example r-fcn which uses ResNet-50 model, memory usage reduces from 2G to 500M on CPU context. It's reasonable as conv3x3 pattern is repeated and all memory can be reused between layers.

More memory analyse is needed to improve this pool implement. Currently I can see some fixed pattern in memory requests which can help to improve the pool memory management. We can use Least Frequently Used algorithm to reduce the memory. Some memory pattern can be view in #31

The memory for model parameters are also managed by memory pool? If multiple images pass the same model,  do you fix the memory for the model?

Yes, parameters are also managed by the pool. However the parameters memory won't be released unless the Net object is destructed. Clearing the Memory Pool only release the memory which is not used. Temporary memory and network internal buffer will be marked as unused during the forward, but model parameters won't.

Thanks. Another question:  the buffers allocated for feature maps (in/out) aren't shared the same memory block during the forward ?

The whole idea is pretty simple. Determine the life time of all Blobs in network layer by layer. As network definition itself is already in topo order. If a Blob has no later layer using it as input, we can mark this Blob reusable and share the memory. The input Blob can naturally be shared/reused as Forward goes on. However, I think it's more convenient to not reused the input Blob, at the next Forward, you don't need to call Reshape for the same input size. If reuse input Blob, a Reshape call is needed to get a memory reference. And one more important thing is that for most cases, input and output Blobs consume little memory compared to internal Blobs. Never mind if these memory are shared or not :)

They are negative values in the results of using MemPoolState, is it normal?
[CPU] Hold -1990 M, Not Uses 1 M
[GPU] Hold 0 M, Not Uses 0 M

Static memory place is impl in #70


power atom

Adds power.py atom. If everything looks good, I can start replacing atoms like sqrt, square, inv, etc with wrappers around power.

This looks great!


Failed verification because kubeconform could not find local schema

I am trying to validate Argo-Workflows with kubeconform. Unfortunately no matter what I always get an error because kubeconform could not find schema.
I specifically try to validate the CronWorkflow and WorkflowTemplate in version v1alpha1. They have an openapi definition which I parsed with openapi2jsonschema
openapi2jsonschema https://raw.githubusercontent.com/argoproj/argo-workflows/master/api/openapi-spec/swagger.json

This creates files schemas/cronworkflow.json and schemas/workflowtemplate.json with the correct schemas.
From the documentation I inferred that it should just work by specifying the format with a  Go templated string that indicates how to search for JSON schemas
❯ kubeconform -schema-location default -schema-location 'schemas/{{ .ResourceKind }}.json' -summary --verbose -output json resources/
{
  "resources": [
    {
      "filename": "stdin",
      "kind": "WorkflowTemplate",
      "name": "redacted",
      "version": "argoproj.io/v1alpha1",
      "status": "statusError",
      "msg": "could not find schema for WorkflowTemplate"
    },
    {
      "filename": "stdin",
      "kind": "CronWorkflow",
      "name": "redacted",
      "version": "argoproj.io/v1alpha1",
      "status": "statusError",
      "msg": "could not find schema for CronWorkflow"
    }
  ],
  "summary": {
    "valid": 0,
    "invalid": 0,
    "errors": 2,
    "skipped": 0
  }
}

Without the verbosity it only says
could not find schema for WorkflowTemplate
could not find schema for CronWorkflow

I actually managed to validate my files with kubeval by renaming them to schemas/master-standalone/cronworkflow-argoproj-v1alpha1.json and schemas/master-standalone/workflowtemplate-argoproj-v1alpha1.json` and running with
kubeval --additional-schema-locations file://./schemas

So I am very certain, that the content of the files themselves is fine.
However the renaming is not very maintainable and I would like to use kubeconform here. Curiously I still get the same error when I shun the templated string and instead use the naming scheme that worked in kubeval,
I also read all the help pages but can not find an option that further increases the verbosity level. Thus I did not manage to analyze the error deeper than this. I essentially checked all thinkable combinations of ResourceKind and KindSuffix but to no avail.
It is also not an option to extract the apiVersion as well because I get an error
❯ openapi2jsonschema https://raw.githubusercontent.com/argoproj/argo-workflows/master/api/openapi-spec/swagger.json  --kubernetes
Downloading schema
Parsing schema
Generating shared definitions
Generating individual schemas
Traceback (most recent call last):
  File "/home/maow/.asdf/installs/python/3.9.10/bin/openapi2jsonschema", line 8, in <module>
    sys.exit(default())
  File "/home/maow/.local/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/maow/.local/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/maow/.local/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/maow/.local/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/maow/.asdf/installs/python/3.9.10/lib/python3.9/site-packages/openapi2jsonschema/command.py", line 132, in default
    group = title.split(".")[-3].lower()
IndexError: list index out of range

Presumably this is cause by an incomplete naming in the openapi specification. This is something that I encountered for other projects as well and I am not sure who's fault this is. I assume the standard is either not restrictive enough not being followed consequently.
I would be really thankful for suggestions how to specify the correct schema location, modify the openapi extraction or even just make kubeconform print the path it searched in so that I can out what is not working here.

works on my machine 🤔

can you try to use the schemas from here?
https://github.com/datreeio/CRDs-catalog/tree/main/argo

I was looking for exactly such a repo as well but it did not come up in my searches. With these schema definitions it works out of the box. I will investigate the difference a bit, but these solves my ticket.
I noticed a typo deafult - default in your command and instead of downloading I used the repo directly
☸ prod-k8s-kaj (prod-kafka) ❯ cat .templates/prod/meta-apps-kaj | kubeconform -schema-location default -schema-location 'https://raw.githubusercontent.com/datreeio/CRDs-catalog/main/argo/{{ .ResourceKind }}_v1alpha1.json' -summary --verbose
stdin - Application one is valid
stdin - Application two is valid
stdin - Application three is valid
stdin - Application four is valid
stdin - Application five is invalid: For field spec: Additional property syncPlicy is not allowed
stdin - Application six is valid
stdin - Application seven is valid
stdin - Application eight is valid
stdin - Application nine is valid
stdin - Application ten is valid
stdin - Application eleven is valid
stdin - Application twelve is valid
stdin - Application thirteen is valid
stdin - Application fourteen is valid
Summary: 14 resources found parsing stdin - Valid: 13, Invalid: 1, Errors: 0, Skipped: 0

Thank you very much.


Are Facebook Sender Actions working ?

Hi there,
I have been trying to get the Facebook typing action to work but I am having no success. This is the API: https://developers.facebook.com/docs/messenger-platform/send-api-reference/sender-actions
I notice it does not have a message item. Is this why I cannot get it to work? I am creating JSON for it, setting it to the message ChannelData but am having no luck.
var typing = context.MakeMessage();
if (typing.ChannelId.Equals("facebook", StringComparison.InvariantCultureIgnoreCase))
{
var fbChannelData = new FacebookSenderAction() { SenderAction = "typing_on" };
typing.ChannelData = fbChannelData;
await context.PostAsync(typing);
}
public class FacebookSenderAction
{
[JsonProperty("sender_action")]
public string SenderAction { get; set; }
}

@gviddy this should have been fixed now and you should be able to send sender action as channel data to Facebook.
Also here is an example on how you can use typing activity to send typing indicator to different channels instead of relying on the channel data: https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Samples/SimpleDispatchDialog/SimpleDispatchDialog.cs#L28

@msft-shahins  Awesome! Works as expected. thanks! 👍


Nsurlsession

Hi @irvingruan, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla
Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Irving Ruan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Irving Ruan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add support for en-/disabling each public annotation on each own

What does this PR do?
I started the agent with debug logging enabled (on a test system) and noticed that CaptureTransactionInstrumentation, CaptureSpanInstrumentation and TracedInstrumentation together were responsible for around 1/3 of the total matching time. Because we are only using @CaptureSpan in our code, but not @CaptureTransaction or @Traced, the time spent in CaptureTransactionInstrumentation and TracedInstrumentation is wasted. But right now, there is now way (that I am aware of) to disable both the two "unused" instrumentations. This PR solves this.
I also tried to override a getTypeMatcherPreFilter in the instrumentations, but this did not make any difference.
Checklist

[x] This is something else

[x] I have updated CHANGELOG.asciidoc

:grey_exclamation: Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-02-15T19:27:52.522+0000

Duration: 4 min 24 sec

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

/test


Cyclic dependency returns empty object

http://stackoverflow.com/questions/29807664/cyclic-dependency-returns-empty-object-in-react-native
I ran into above issue myself when I accidentally tried to require module A from module B which accidentally had the A also required (not to be confued with navigation issue on #3076). It took some head scratching to determine why the object came back as empty so ideally a warning would be raised when accidentally (or purposefully) doing this.

There might not be a fix for this if it's intended behavior. I believe this is how the module spec works and could be an issue with CommonJS more than React Native. I would be interested to see how other require systems handle this.

Same thing happens in Node also.

Looking at ES6 modules I believe they behave similarly. I'll close this issue since it's how JavaScript works.

Actually, cyclical dependencies in CommonJS are allowed in some circumstances:
See https://github.com/systemjs/systemjs/issues/136 for more details.
I'm currently running into the exact same scenario with a 3rd party library that cannot easily be modified to do lazy loading or dependency injection. React-native's loader should support all the CommonJS use cases.
I'll try to make a PR with a fix.


[string gardening] Omit returns and clean up whitespace

@swift-ci please test

I'm going to wait until after 5.1 for this

Can one of the admins verify this patch?

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

How to change the base branch: (Link)
More detail about the branch update: (Link)


[OpenCL] Enforce order of fp operation in double-word

There is regression in PoCL+Cuda (for example used on power9) where the compiler now re-orders some floating operation. This  changes the numerical precision and breaks the double-word:
https://github.com/pocl/pocl/issues/1298
A solution is suggested there. A PR implementing it follows.

Fixed in cef3ab6


Search Component

Clear and concise description of the problem
So, now a days just like nuxt.com, when you click search or press Ctr+K, it will open this search modal stuff, and I like to have something like this in naive-ui.

or something like this

Suggested solution
Maybe use the existing Modal functionality?
Alternative
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Any update for this？

Not currently planned, but welcome PR


Assigning new data to the chart clears all tasks

I reproduced this on the demo app page under Chrome and Firefox. When I click on the "reload" button, all tasks disappear but the rows are still displayed. I have the same issue in my app as if I assign a new array of data to the bound variable, all tasks are gone.
Clicking on "clear" then "reload" works fine.

Thanks for reporting this bug, i'm working on this right now.


[google_maps_flutter_web] Allow marker position updates

Unconditionally convert the current marker position in convert.dart:_markerOptionsFromMarker, to allow for position updates.
Also adds position changes to marker_test.dart/MarkerController/update and markers_test.dart/MarkersController/changeMarkers. The MarkersController case is fixed by this patch.
Issue: flutter/flutter#83467
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thanks for the contribution! Could you merge in the latest master? This is branched from a version older than the last update to our infrastructure tokens, so most of the CI is unable to run.

Done; please let me know if further action is required from me. I'm not familiar with these tests, but the failing test looks like it can't find the compass button on iOS. I don't have an iOS test setup yet, and this change was limited to the web plugin.

Looks like that test may have been reverted. Rebasing and rerunning.

@ditman Ping on this review.

Gentlemen,
Any progress on resolving this issue?

We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.
Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.
Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!


New announcement about the achievements!

This announcement on the GitHub Community is something that should be taken notes from and added in the README.

Just saw it as well and absolutely concur, will do later!

added to the README in the referenced commit as well as in https://github.com/Schweinepriester/github-profile-achievements/discussions/722.


[React] [JS] Folder structure / basic rules

In general
In React

###Components structure

components

ui

containers

Questions:

What should be in ui folder - general rule

Something to read:

https://www.taniarascia.com/react-architecture-directory-structure/
https://www.robinwieruch.de/react-folder-structure
https://dev.to/knitesh/react-project-folder-structure-30cm
https://reboot.studio/blog/folder-structures-to-organize-react-project/

1. Components structure

components

ui

containers

Questions:

What should be in ui folder - general rules
How to nest components, should be a child components or not rules
Lower or upper case, everything need to be specify, to avoid inconsistency

UI means User Interface, so in ui folder should be all buttons, links, checkbox etc

[PROPOSITION]
In JS app

assets
scripts
styles


Move from nosetests to Pytest

Nosetest has been in "maintenance mode" for a number of years now and no
updates are expected.
Most changes utilize python's unittest instead of pytest directives to
improve later portability.
notes

There is no swiftlint docker, not in the makefile at least. Is that something that's a work in progress?
I didn't fully replicate the "requires linter" decorator, as I didn't see how it would be used in practice, as travis always has all of them and docker-compose tests never has any of them. I implemented just a flag for --requires_linters but if this is unacceptable, I can improve it.

how do I kick off travis?

Codecov Report

Merging #253 into master will decrease coverage by 1.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   90.06%   88.13%   -1.93%
==========================================
  Files          45       45
  Lines        2596     2596
==========================================
- Hits         2338     2288      -50
- Misses        258      308      +50

Impacted Files
Coverage Δ

lintreview/tools/commitcheck.py
33.33% <0%> (-64.29%)
:arrow_down:

lintreview/github.py
64.38% <0%> (-16.44%)
:arrow_down:

lintreview/tools/swiftlint.py
47.82% <0%> (-13.05%)
:arrow_down:

lintreview/processor.py
94.54% <0%> (-5.46%)
:arrow_down:

lintreview/diff.py
92.64% <0%> (-1.48%)
:arrow_down:

lintreview/tools/__init__.py
80.85% <0%> (-0.71%)
:arrow_down:

lintreview/review.py
95.49% <0%> (-0.46%)
:arrow_down:

lintreview/git.py
83.33% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9445205...aa9fd7e. Read the comment docs.

There is no swiftlint docker, not in the makefile at least. Is that something that's a work in progress?

Getting a swiftlint container built is a painful process that took multiple hours and a few intermediate images and container exports. Because of how complicated that image is to build I didn't include a docker file. I have an image up on dockerhub though

I didn't fully replicate the "requires linter" decorator, as I didn't see how it would be used in practice...

This decorator is useful in local development as you can run all tests without failures/timeouts. Could it be adapted to a pytest.mark.skipif based implementation?

@markstory I'm going to add a "docker pull swiftlint" stage to the travis prepare step, that way we always run those tests, right now we skip them since the image isn't ever there.
As far as the require_linters, yes I can implement something like that. Can you give me more details on how you/others use that? It might help inform the design and I think it'd be useful for me as well, and I'd like to maintain existing workflows as closely as possible.

As far as the require_linters, yes I can implement something like that. Can you give me more details on how you/others use that? It might help inform the design and I think it'd be useful for me as well, and I'd like to maintain existing workflows as closely as possible.

Sometimes I don't have all the docker containers downloaded on a machine, and am too lazy/impatient to download all 10+ images. The existing requires_image() decorator lets me run all tests and have tests that use images I've not yet downloaded be automatically skipped.

Okay gotcha. I’ll sort it out.
On Mar 29, 2019, 3:09 PM -0400, Mark Story<EMAIL_ADDRESS>wrote:
As far as the require_linters, yes I can implement something like that. Can you give me more details on how you/others use that? It might help inform the design and I think it'd be useful for me as well, and I'd like to maintain existing workflows as closely as possible.
Sometimes I don't have all the docker containers downloaded on a machine, and am too lazy/impatient to download all 10+ images. The existing requires_image() decorator lets me run all tests and have tests that use images I've not yet downloaded be automatically skipped.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/markstory/lint-review/pull/253#issuecomment-478116309, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAyJuNy-3jMr3P2cf4vcVd5dE08zduCHks5vbmTzgaJpZM4cQeNf.

@markstory Once the travis build finishes, I believe this is ready for review and meets all the goals I set out to achieve. Thanks!

Awesome work, thank you @tebriel :clap:


Three undefined names in pytorch_cifar10.py

flake8 testing of https://github.com/jhfjhfj1/autokeras on Python 3.7.0
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
./experiments/pytorch_cifar10.py:51:7: F821 undefined name 'ResNet18'
net = ResNet18()
      ^
./experiments/pytorch_cifar10.py:98:9: F821 undefined name 'progress_bar'
        progress_bar(batch_idx, len(trainloader), 'Loss: %.3f | Acc: %.3f%% (%d/%d)'
        ^
./experiments/pytorch_cifar10.py:118:13: F821 undefined name 'progress_bar'
            progress_bar(batch_idx, len(testloader), 'Loss: %.3f | Acc: %.3f%% (%d/%d)'
            ^
3     F821 undefined name 'ResNet18'
3

Those are just some random files we created.
They have been deleted.
The only example we provide currently is the examples/mnist.py
Sorry for the confusion.


[Add] CSS Pattern Generator

Site URL
https://patternizer.com/
Description of the above provided site
This website will generate CSS code for Patterns
Category
Frontend
Sub Category
UI Generators
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

@Swapnil-Singh-99 thanks, please work on one issue at a time, we will assign you this issue once you're done with your assigned issues :)

@rupali-codes Can you assign me this Issue

@rupali-codes I am interested in working on this issue.

@rupali-codes Can you assign me this Issue

Hi @Killer2OP! :) Are you currently working on any other issues?

@rupali-codes Can you assign me this Issue

Hi @Killer2OP! :) Are you currently working on any other issues?

Nope

@rupali-codes Can you assign me this Issue

Hi @Killer2OP! :) Are you currently working on any other issues?

Nope

Assigned