Add SignalR Daily Tests scripts

This adds a YAML build script to run SignalR "Daily Tests". Right now, that just enables running browser tests in Sauce Labs instead of locally.
I'm still messing with the build definition. @natemcmaster take a look and see what you think, feel free to tear it apart ;P. The goal is simple: Run the standard build script, over the src/SignalR directory but with the additional MSBuild property DailyTests=true. That's all we need to trigger the daily tests.

The updated YAML scripts are now running properly in the mondo repo: https://dev.azure.com/dnceng/internal/_build?definitionId=132&_a=summary


Large resolve.extensions make build process slower significantly

Do you want to request a feature or report a bug?
bug
(or feature, not sure)

What is the current behavior?
I have an webpack config which contains many elements in resolve.extensions (13 extentions).
This file was generated by webpacker on default configuration.
This increases build time significantly compared to fewer extentions.
To make matters worse, it causes heap allocation error in my real project then I cannot build the app.
An example of build time measurements of a project:

number of resolve.extentions
build time(ms)

2
10264

3
11645

4
17079

5
26940

6
42766

7
70409

8
85172

9
121312

10
191606

11
255123

12
270727

13
492126

If the current behavior is a bug, please provide the steps to reproduce.
https://github.com/tai2/webpack-build-time-increase-example

What is the expected behavior?
Reasonable build time regardlress of resolve.extenions.
O(1) or O(N) algorithm if it's possible.
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
Node.js: v8.1.2
webpack: 3.0.0
OS: Darwin Kernel Version 16.6.0
CPU: Core i7 3.1GHz
RAM: 16GB

Hey @tai2 , I tried your sample repository to reproduce the issue.
I got the following results more or less with

with webpack 3.0.0 + 13 extensions

with webpack 3.0.0 + 2 extensions

With `webpack 3.1.0 also I got similar result with a difference of 2-3 seconds between the two runs.
Can I do something else to reproduce your issue?

@pksjce Thanks for trying it. What's your node.js version?

I tried it on another ubuntu environment, it was not reproduced. 🤔 🤔 🤔

I'm using v7.2.0. Will that make a difference? I also tried this directly on webpack's resolver which is https://github.com/webpack/enhanced-resolve . I tried it with 2-13 extensions and found similar perf differences of couple of seconds only.

I asked few people to run the sample program.
No one reproduced the issue except for me.
hummm

Node's version is 8.1.0 and webpack is 3.1.0.
I used Mac.
2 extensions
> NODE_ENV=development webpack --config webpack/dev.js

Hash: cc5736328da18ab1eab0
Version: webpack 3.1.0
Time: 1869ms
    Asset     Size  Chunks                    Chunk Names
bundle.js  2.97 MB       0  [emitted]  [big]  main
[./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 509 bytes {0} [built]
[./src/index.jsx] ./src/index.jsx 171 bytes {0} [built]
   [0] multi babel-polyfill ./src/index.jsx 40 bytes {0} [built]
    + 479 hidden modules

13 extensions
> NODE_ENV=development webpack --config webpack/dev.js

Hash: cc5736328da18ab1eab0
Version: webpack 3.1.0
Time: 3855ms
    Asset     Size  Chunks                    Chunk Names
bundle.js  2.97 MB       0  [emitted]  [big]  main
[./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 509 bytes {0} [built]
[./src/index.jsx] ./src/index.jsx 171 bytes {0} [built]
   [0] multi babel-polyfill ./src/index.jsx 40 bytes {0} [built]
    + 479 hidden modules
npm run build:dev  4.04s user 0.57s system 83% cpu 5.498 total

Is there a possibility of your machine problem?

I got it.
You can reproduce the problem on the environment below.

Use nodebrew. Not reproduced with Homebrew's node.
Run cd ~/ && ln -s .nodebrew/current/lib/node_modules node_modules
Run example code

I had a symbolic link node_modules in user home which points to nodebrews's global installation directory. This contained npm itself.
I don't understand why this causes performance problem.
And I don't know when and why this symbolic link generated.
But this issue is probably my specific problem and rarely occurs to others.
So I close this issue.


Google Doc integration adds too much space around embedded image

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Starting 2024-04-24 draw.io images embedded into a Google Doc document are extended to the bottom-right with empty space. I have not observed this behavior before this date.
To Reproduce
Steps to reproduce the behavior:

Open a Google Doc document
Click on Extensions -> Draw.io -> Insert Diagrams
Select an existing diagram
See box around image being too large with extra space on bottom-right, see screenshots below.

Expected behavior
The space surrounding the diagram content should be even on all sides and not excessive.
Screenshots
If applicable, add screenshots to help explain your problem.

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version 24.3.0

Desktop (please complete the following information):

OS: macOS 14.2.1
Browser Safari
Browser Version 17.2.1

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

"yes"

Additional context
Tested in Chrome as well, same issue. Very useful product overall.
Regards, David

I'm experiencing the same thing.

I should add, mine are not only cropped incorrectly, but the background is now grey for some reason.

Fixed.


Crash with Perfect Spawn [1.10.2]

http://pastebin.com/pQN1tysZ

Looks like some ASM transform perfectspawn is doing, will investigate when I get time

Is this on a client or server?

Seems to be something involving loading the skyrenderer for some reason

I do not know what exactly went wrong, but this patch seems to fix it.  Due to the fact the error occurs during asm transform I suspect it's some optimization the compiler is doing.


In Android its not working

{"status":0,"text":"Unable to resolve host "s3-us-east-2.amazonaws.com": No address associated with hostname","headers":{}}
Please anyone give me suggestion please

I am getting the same issue. "Hostname com.nds.images.s3.amazonaws.com not verified:


2.2 Create Event on Sporta [backend]

Implement Event Creation in event-service
Description:
As a Sporta user, I want to create an event so that I can host the activity and make it accessible to the desired audience. For private events, I want to restrict access to a specified list of users.
Story Points: 8
Priority: P1
Risk: High
Requirements:

Setup event-service Microservice:

Create a new microservice named event-service dedicated to handling events, including both private and unrestricted event creation.
Ensure event-service can handle the full lifecycle of events, including creation, modification, and deletion.

Event Creation API:

Implement an endpoint (e.g., /events/create-event) within event-service to allow users to create events.
Accept necessary parameters, such as event name, description, date, time, location, and other relevant details specified in the ERD model.
Add fields to indicate:

private: A boolean field to determine if the event is private (restricted to specific users) or open to all users.
whitelistedUsers: A list of user IDs allowed to view and join the event if it is private.
ownerId: The ID of the user who created and owns the event.

Model Creation:

Define a new Event model in event-service to represent event data.
Include fields from the ERD model, including private, whitelistedUsers, ownerId, and other event attributes such as eventName, location, date, duration, and description.
Reference the ERD Model for field details, accessible at: SportsApp ERD Model.

Security and Access Control:

Ensure that only authenticated users can create events.
For events marked as private, restrict access to the users specified in whitelisted_users.
Events without restrictions (private set to false) should be accessible to all users (even the non authenticated ones).

Acceptance Criteria:

[x] The event-service microservice is set up and running independently.
[x] An endpoint is available in event-service for users to create both private and unrestricted events.
[ ] Events marked as private are restricted to the specified whitelisted_users, while unrestricted events are accessible to all users.
[ ] Authenticated users can create events, and access control is in place for private and unrestricted events.
[ ] Unit and integration tests cover event creation, access control, and the Event model.

Task Breakdown:

Setup event-service Microservice

Initialize event-service with necessary dependencies and configurations.

Implement Event Creation Endpoint

Develop the /event-service/event endpoint in event-service.
Accept required event details, including privacy status (private), owner ID, and whitelisted users for private events.

Define Event Model

Create an Event model in event-service with fields as per the ERD model.
Include fields like private, whitelistedUsers, ownerId, eventName, location, date, duration, and description.

Security and Access Control

Implement authentication checks to ensure only authenticated users can create events.
Set access control to ensure private events are restricted to whitelisted users and unrestricted events are accessible to all users.

Testing and Documentation

Write unit and integration tests for event creation and access control.
Document the event-service API, including the endpoint for creating events and any required parameters.

@DanDuguay We will add a new field when you create the event. Can you add a skill level requirement, maybe include an array of allowed skills. You can create a SkillLevel enum for your use. Frontend will be working on #6 and #7 this Sprint which relates to theses changes.


Key is too long

Hey,
I get this error during installation:

https://laravel-news.com/laravel-5-4-key-too-long-error/

Thanks


process err when json.Unmarshal fail to avoid panic

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt
If they are not already assigned, you can assign the PR to them by writing /assign @myidpt in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @wackxu. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @myidpt

/assign @incfly

/ok-to-test

/test e2e-pilot-noauth-v1alpha3-v2

/test e2e-pilot-noauth-v1alpha3-v2

/test e2e-pilot-noauth-v1alpha3-v2

/retest

/test e2e-pilot-noauth-v1alpha3-v2

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incfly
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [incfly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test e2e-pilot-noauth-v1alpha3-v2

/retest

/retest

/retest

@wackxu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
34e0852d4aa57b4edfbb443d8189d73caf7e3257
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@wackxu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
34e0852d4aa57b4edfbb443d8189d73caf7e3257
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Routes not matched when rewriting URL's to a subdirectory (under Windows)

Consider using $_SERVER['REDIRECT_URL'] instead of $_SERVER['REQUEST_URI'] in Environment::__construct(), line 131.
No routes get matched because $env['PATH_INFO'] does not have the physical path portion removed (line 145 does not get executed).
Here is my project structure:
project
    .htaccess
    app
    web
        .htaccess
        api
            v1
                index.php
        css
        img
        js

project/.htaccess contains the following to redirect all requests to the web subfolder:
<IfModule mod_rewrite.c>
    RewriteEngine on
    RewriteRule ^$ web/ [L]
    RewriteRule (.*) web/$1 [L]
</IfModule>

project/web/.htaccess contains the following to route everything to index.php:
<IfModule mod_rewrite.c>
    RewriteEngine On
    RewriteCond %{REQUEST_FILENAME} !-d
    RewriteCond %{REQUEST_FILENAME} !-f
    RewriteRule ^api/v1 api/v1/index.php [QSA,L]
</IfModule>

Some potentially useful info:

Windows 7
Apache 2.4
PHP 5.6.4
Slim 2.6.1

We are only doing security fixes to version 2 now. Please test this in version 3 and let us know if this is still true.


Event scrape: If there is more than one minutes file, which one should we use?

@shrayshray @camachoo To reiterate from #740, I've deployed a patch to handle the case where there is more than one minutes file for a particular meeting to unblock event scrapes: https://github.com/opencivicdata/scrapers-us-municipal/pull/350.
Let's move the conversation on how to handle that case here. Here's where we stand on the thread.

@camachoo:
Can we take the first appearance by date (opposite of most recent) that has an actual minute's history, if not then first appearance by date regardless of minute's history?

Me:
I want to take a quick step back and clarify how we get approved minutes currently:

If there is EventMinutesFile in the API, use that
If there is a minutes link in the UI, use that
Otherwise, look for a file to approve minutes of the given meeting and use that (regardless of minutes history)

This is the step that currently expects one and only one file to exist

So, we're dealing with a case where we are trying to infer minutes from the file's title.
I bring this up because neither of the files we're dealing with right now was approved (as best I can tell). Would it be more accurate, if we get to this step, to look for an approval in the minutes history, or otherwise return nothing for approved minutes?

For December and January board meetings, there have been two attachments to the approve minutes item: One is the actual minutes file, and one is a public comment summary.
The minutes files are named like this:

'December 2, 2021': 'Regular Board Meeting MINUTES - December 2, 2021'
'January 27, 2022': 'Regular Board Meeting MINUTES - January 27, 2022'

Currently, we need to handle this on a case by case basis. It would be better to add some logic to handle it. Will this naming convention (and condition of two attachments to minutes approval) be consistent moving forward?

@hancush unfortunately, we cannot guarantee this naming convention will be consistent moving forward.

Hmm, bummer. What about something less strict, such as the minutes file will always contain the word "minutes" (and the other attachments, e.g., public comment, won't)?

@hancush "minutes" in the file name is probably the best bet. Still can't 100% guarantee it will be there, but it's more likely than not.

Submitted a patch to look for an attachment containing "Minutes" for approval matters. We'll keep an eye on this to see whether there are any incorrect minutes files or if it ever happens that there's more than one attachment containing "Minutes".

@shrayshray will ask records folks to include minutes so this approach works.

@shrayshray and @camachoo will look for any errors in minutes files once meetings start up again in late summer / early fall. Will keep an eye on scrape failures on our side.

Standard naming conventions are hard to enforce – implement a logic similar to unpaired events where alerts are sent but the scraper does not break.


Not able to apply CSS classes to MTableHeader

I am trying to add a customized icon to action header, but there is a disabled container  tag (TableSortLabel) wrapping up the customized part so that the icon is not able to be trigger.
My approach is applying css classes to MTableHeader in order to enable the pointer event for the disabled  tag.
Here is the Demo https://codesandbox.io/s/material-table-starter-template-forked-ct59d0

But the issue I have is In the @next version for MUI V5, css style is hard coding in MTableHeader component which is no longer from props and can't customize.
I'd expect the @next version of MTableHeader element is accepting css classes and apply to the TableCell component like what the master branch(v4) having right now.

Can you make the demo use the appropriate versions and actually compile? Thank you.

@Domino987 I had updated the demo url on the description also attach it here: https://codesandbox.io/s/material-table-starter-template-forked-ct59d0?file=/package.json:154-220.

You are using Mui v5 where you should use the sx for styling. But I'll add the classes spreading as well again.


Added 3 widget plugins:  react, handlebars, and jqplot

Hopefully others can benefit from these plugins that we're using.

Hey @jheising would you mind looking at my pull request?  Thanks!


FEATURE: Alert on mention that allows inviting users to join channel

Relies on core PR https://github.com/discourse/discourse/pull/15288

for tomorrow, we have a failing spec.


GPTQ fixes

Stack from ghstack (oldest at bottom):

-> #115

Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:

@HDCharles - Changed the base to main


Deleted and merged

I was working on my project today (windows 10, vs code with git hub enabled). Windows wanted an update so I took lunch. Came back, fired up vs code and things started to get weird. My branches merged randomly, deleting new stuff, merging in old stuff. I went to pull my branch from last night and it has deleted it, locally and on the server. By the time I got to git hub, I had fragments of code scattered about and all my branches were messed up. After much anxiety,  I started over in that same directory. Things continued to change.
I started over in a new directory, leaving both my vs code work place and the git repository behind, and salvaged what I could. No problems so far.
Seems there's a very nasty bug in vs code/github that may have something to do with the latest update. I won't make the mistake of combining them again. And I won't trust got hub as my sole back up anymore either. 7 zip for the win.

Hello there, first time commenting, long time using VS Code ;)
To shed a little more light on this topic (mostly because it sounds similar to what I'm experiencing), it seems that every time a change is staged in Git with multiple projects in the same workspace, the SCM view in the side bar pulls itself to the top after that interaction!
If you're not careful, you can end up submtting or staging something on a different project than the one you were intending...
I don't think this is Windows-related, but probably has to do with the latest VS Code update where there has been a change in the side bar wrapping behaviour 🤔

@pdrgnclvs Can you show a gif/video of what you are experiencing?

@pdrgnclvs Can you show a gif/video of what you are experiencing?

@eamodio, of course 👍

Every time a change is staged in one of the projects, it collapses all of them and I have to open it again to resume what I was doing 🤔

@eamodio, of course 👍

Every time a change is staged in one of the projects, it collapses all of them and I have to open it again to resume what I was doing 🤔

Thanks! I was seeing the same behavior over break, but I can't reproduce this myself anymore. What version of VS Code are you using? And can you still reproduce it on the latest insiders edition?

Thanks! I was seeing the same behavior over break, but I can't reproduce this myself anymore. What version of VS Code are you using? And can you still reproduce it on the latest insiders edition?

@eamodio, I'm using the current stable...

As for the insiders version, I haven't tried it yet but will tomorrow morning to see if it keeps happening and will keep you posted 😉

@eamodio, I'm using the current stable...

As for the insiders version, I haven't tried it yet but will tomorrow morning to see if it keeps happening and will keep you posted 😉

I've quit using vs code and github together. I lost too much work as it ate
my code on both machines and the github server. They will remain
separate for me.
On Wed, Jan 6, 2021 at 6:03 PM Pedro Gonçalves<EMAIL_ADDRESS>wrote:

@eamodio https://github.com/eamodio, I'm using the current stable...
[image: image]
https://user-images.githubusercontent.com/46295920/103834187-aa665f00-507a-11eb-9f86-b9ed251883f1.png
As for the insiders version, I haven't tried it yet but will tomorrow
morning to see if it keeps happening and will keep you posted 😉
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/112354#issuecomment-755787565,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AORUJSWMDON77QOSS54JLALSYT26NANCNFSM4UX4PQNA
.

--
Mark Anderson
Monroe Crossing
612-386-1070

I've quit using vs code and github together. I lost too much work as it ate
my code on both machines and the github server. They will remain
separate for me.
On Wed, Jan 6, 2021 at 6:03 PM Pedro Gonçalves<EMAIL_ADDRESS>wrote:

@eamodio https://github.com/eamodio, I'm using the current stable...
[image: image]
https://user-images.githubusercontent.com/46295920/103834187-aa665f00-507a-11eb-9f86-b9ed251883f1.png
As for the insiders version, I haven't tried it yet but will tomorrow
morning to see if it keeps happening and will keep you posted 😉
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/112354#issuecomment-755787565,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AORUJSWMDON77QOSS54JLALSYT26NANCNFSM4UX4PQNA
.

--
Mark Anderson
Monroe Crossing
612-386-1070

@eamodio, about that update you on this issue: using the latest insiders version...

It now appears that if I stage and commit a change on the 1st project on the list, it operates as expected by not collapsing that 1st project 👍
But when I stage a change from the 2nd project on the list (and probably all the ones after), it automatically expands the 1st project on the list 🤔

@eamodio, about that update you on this issue: using the latest insiders version...

It now appears that if I stage and commit a change on the 1st project on the list, it operates as expected by not collapsing that 1st project 👍
But when I stage a change from the 2nd project on the list (and probably all the ones after), it automatically expands the 1st project on the list 🤔

This is a duplicate of https://github.com/microsoft/vscode/issues/112487, which will be fixed in the next insiders build.

This is a duplicate of https://github.com/microsoft/vscode/issues/112487, which will be fixed in the next insiders build.


Change the check for the existence of cryptsetup command

Description
Currently, when starting the Agent, ACS checks if the cryptsetup command can be used by using the command's help; the output of the command is printed in the logs. However, this output is too verbose and can be confusing.
This PR addresses this issue by using the utility version to check the command, instead of help, which is much less verbose.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

Before changes:

After changes:

How Has This Been Tested?
I checked the logs before and after changes. As shown in the screenshots above, the logs became more intuitive.

@blueorangutan package

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8263

clgtm @lucas-a-martins why did you close #8480 in favour of this PR? they seem to do the same.

@DaanHoogland thanks for your review. About the #8480, it was my first PR. I made some mistakes and didn't know how to fix them, so I thought it would be better just closing it and creating a new one, but now I know it was not a good decision. I will be more careful.

clgtm @lucas-a-martins why did you close #8480 in favour of this PR? they seem to do the same.

@DaanHoogland thanks for your review. About the #8480, it was my first PR. I made some mistakes and didn't know how to fix them, so I thought it would be better just closing it and creating a new one, but now I know it was not a good decision. I will be more careful.

no problem @lucas-a-martins and no harm done. Just wondering what happened.

Merging this based on four approvals and manual test.

Hm @BryanMLima , we were still in freeze. don't think it will be a problem though. cc @shwstppr .

@DaanHoogland @shwstppr, my mistake, I can revert the merge commit if it is required.

@DaanHoogland @shwstppr, my mistake, I can revert the merge commit if it is required.

No need to revert, I think
@BryanMLima

Hi guys, I think in case 4.19.0 RC4 makes it to be the final release this fix won't be on 4.19.1 as the milestone states, but will be present only on the future 4.20. @BryanMLima @shwstppr in case you are reverting this fix please target it to the 4.19 branch

Good catch @nvazquez. If we want it in 4.19.1 I guess either we need to revert and merge again in 4.19 branch once 4.19 release is done or we would need to backport the commit. Any other suggestions @BryanMLima @DaanHoogland @weizhouapache ?
If there will be another RC then all good

We can backport to 4.18, then merge forward to 4.19 and main
@shwstppr @nvazquez @DaanHoogland @JoaoJandre

@BryanMLima @lucas-a-martins , as @nvazquez said and hopefully it will be on 4.20 ;) but if you need it in a mainstream release before, please backport.
A revert will prevent merge forward conflicts if you do so, but is not strictly necessary. cc @shwstppr @JoaoJandre .
either way, no major harm done, just an inconvenience.

@BryanMLima @lucas-a-martins , as @nvazquez said and hopefully it will be on 4.20 ;) but if you need it in a mainstream release before, please backport.
A revert will prevent merge forward conflicts if you do so, but is not strictly necessary. cc @shwstppr @JoaoJandre .
either way, no major harm done, just an inconvenience.

@DaanHoogland
I think this is a very small fix without any risk.
I have cherry-picked the commit to 4.18 branch and pushed to the github repository. It will be in <IP_ADDRESS>/<IP_ADDRESS>/<IP_ADDRESS>
cc @BryanMLima @lucas-a-martins @shwstppr @nvazquez

@DaanHoogland I think this is a very small fix without any risk. I have cherry-picked the commit to 4.18 branch and pushed to the github repository. It will be in <IP_ADDRESS>/<IP_ADDRESS>/<IP_ADDRESS> cc @BryanMLima @lucas-a-martins @shwstppr @nvazquez

Thanks, @weizhouapache! Sorry for any inconvenience guys, my mistake. I will pay more attention in the future.

@DaanHoogland I think this is a very small fix without any risk. I have cherry-picked the commit to 4.18 branch and pushed to the github repository. It will be in <IP_ADDRESS>/<IP_ADDRESS>/<IP_ADDRESS> cc @BryanMLima @lucas-a-martins @shwstppr @nvazquez

Thanks, @weizhouapache! Sorry for any inconvenience guys, my mistake. I will pay more attention in the future.

no worries @BryanMLima


SAP Integation Suite user access documentation incorrect

Issue description
Hi
As it is now it's possible to interpret that PI_Administrator role collection contains PI_Developer and PI_Business_Expert role collections as well which it doesn't. PI_administrator role is missing PI_Developer role collection for instance.
Feedback Type (Optional)
incorrect statement
Page Title on SAP Help Portal (prefilled)
Configuring User Access
Page URL on SAP Help Portal (prefilled)
https://help.sap.com/docs/integration-suite/sap-integration-suite/configuring-user-access

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

hi @cvd75 - PI_Administrator role collection includes every task that can be done in the Cloud Integration capability of the Suite. The same is presented in the documentation as well.
PI_Administrator role collection includes the PI_Integration_Developer role collection which in turn includes the PI_Business_Expert role collection. Hope this is clear.
Regards,
Karuna

We tested this, we have given PI_Administrator and this does not have the option to develop. Please do some testing and update documentation.
Regards,
Caroline

Hi @cvd75
Thanks for the feedback.
A couple of engineers who are responsible for user access are unavailable owing to the vacation season. I’ll look into this feedback as soon as they are back and update you.
Regards,
Karuna

Hi @cvd75,
We have tested your feedback and found it correct. We will update the documentation accordingly and republish the same in the next available window.
Regards,
Karuna


Requesting Better Documentation: Get UUID, Major and Minor in python programme as variable?

Dear all,
Is it possible to grab the UUID of beacons during scanning, save it as a variable, and use it in the python programme? Where do I return the UUID and where do I save it to? This is because I can only see scanner.start()
Are there other functionalities out there or ways that I can grab the UUID,Major,Minor and RSSI values for further use?
Many thanks for your help in advance,
Clement 14

Initial Discovery, Please Correct me if I am wrong:
If you want to append the Mac Addresses to an array, declare the array before and outside the callback function and append to the array in the call back function with the variables provided by the demo code as shown below:
My appended code:
`import time
from beacontools import BeaconScanner, IBeaconFilter, IBeaconAdvertisement
all_bt_addr = []
def callback(bt_addr, rssi, packet, additional_info):
print("<%s, %d> %s %s" % (bt_addr, rssi, packet, additional_info))
print(bt_addr)
all_bt_addr.append(bt_addr)
print(all_bt_addr)
scan for all iBeacon advertisements from beacons with the specified uuid
scanner = BeaconScanner(callback,
device_filter=IBeaconFilter(uuid="e5b9e3a6-27e2-4c36-a257-7698da5fc140")
)
scanner.start()
time.sleep(5)
scanner.stop()`
(For IBeacon demo code)

More Info: If you want to grab the UUID, Major, and minor, they are embedded in the 'additional information' variable.
'additional information' is a dictionary {uuid: uuidvalue, major: majorvalue, minor: minor value}

I am not actively working on this library anymore therefore the documentation isn’t as good as it could be. But I see that you figured it out yourself correctly.
Besides the additional_info variable, also the packet itself is an instance of one if the classes in https://github.com/citruz/beacontools/tree/master/beacontools/packet_types and contains all available data.
Let me know if you have more questions.


Didn't backup SMS - DELETED them!

I did a back-up because I need my text messages from one individual for court this week. The most important time frame is from May-present. Not only did the app fail to back-up any SMS from this person, but it deleted them all from this contact! I had them all backed up through my Samsung account, but it can't be restored because data is missing. I absolutely have to get these messages back! The only thing I have are the MMS. I don't know what happened or why. I have the Samsung Galaxy S7 edge using the current version of the app. 1.5.10 I believe.

The app never deletes anything. Not sure what happened there.

This was 1.5yrs ago, so I'm sure the data is long gone by now! I was hoping
to recover some. But I can assure you, it most definitely did delete most
sms messages, and left me primarily with mms.
On Wed, Mar 28, 2018, 3:19 PM Jan Berkel<EMAIL_ADDRESS>wrote:

The app never deletes anything. Not sure what happened there.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jberkel/sms-backup-plus/issues/674#issuecomment-377022205,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AU-KaXoFYexdett7EIevQCGn4NbEGDreks5ti_A0gaJpZM4J0m4a
.

I'm sorry that you lost data, but I really don't understand how the backup process (which only reads, and never writes) could have deleted your messages. This is the first report of such behaviour.
I'm closing this issue now.


the fail-fast:true property is not triggered if the config map is not found

I think it would be handy (except if there is another way to do this), to make your application fail when no matching configmap can be found in the namespace. I would expect this to be the behavior of fail-fast. However, this only happens when there is an exception while reading the configmap. If the configmap is not found, no exception is triggered.

just dropping a note, if we get to this in the future. may be name such a property strict? And treat it just like we treat profileBasedSources?

I was thinking into a slightly different direction here: what if define profiles that you want to have strictness for? For example:
spring:
   cloud:
      kubernetes:
         config:
            sources:
               - name : a
                  strict: false  # this is the default option
                  profiles:
                    - dev
                    - us-west

This one will try to read (but not fail if these are not present): a, a-dev, a-us-west.
If we change the example above with strict: true, it will validate the presence for a, a-dev, a-us-west.
If we change the example to:

spring:
   cloud:
      kubernetes:
         config:
            sources:
               - name : a
                  strict: true

it will validate the presence of a, but not enforce a-dev and a-us-west, a-kubernetes (when dev, us-west and kubernetes are active profiles), since you have not provided explicit profiles.

While I am inclined towards this one, the issue comes that we already have a property called include-profile-specific-sources. We can leave it as-is, but profiles will override it, that is: profiles is more specific then include-profile-specific-sources.
I don't mind trying to implement such an approach, but I need @ryanjbaxter thoughts here and yours @jbkervyn too, if you have the time.
Thank you.

note for myself: I started working on this one, and I'll fix one more issue along the way. I've created this fix that makes sure that configmap-a is read before configmap-a-dev for example. If there are two profile based configmaps on the other hand:

configmap-a
configmap-a-dev
configmap-a-prod

we do make any distinction (order wise) between  configmap-a-dev and configmap-a-prod. i.e.: you do not know in what order your properties will come from.
What I will be fixing also is being in par with profiles application.yaml according to Spring documentation : last one will win.

I really like your ideas @wind57 . However, what I had in mind was a more simple use-case not going that much into depth with the profiles that you are rightfully pointing out.
What I was thinking is : as long as you do have a configmap mentionned, there should be at least one hit. So if we do take this strict idea that I do like, it would mean : as long as strict = true, the validation would only succeed if a configmap having value either a, a-dev, a-us-west. It would fail if no configmap matching a-* would be found.
Just to ellaborate on the usecase I was initially having when I raised this issue : Simple spring boot app, having no  spring.cloud.kubernetes.config.sources property explicitely set. And by the presense of the depencency, would look for a configmap matching the application.name. In this use-case, I thought that it would make sense to have a failing validation when no configmap would be found. That's why I thought having a at-least logic would make sense.
But I must confess that I do not possess a decent knowledge on the topic, so I'm just sharing, but I do value more your expertise over mine.
Thanks a lot for putting so many thoughts into this :)

No worries at all, I liked the idea and I do admit I thought about such a failure of the app when support was added for fail-fast. While I agree with you, think about someone who has a @Profile("dev") (even better if you think they he/she starts the app with an environment property for those profiles) and strict=true. his/her thoughts are going to go to : "if I have this profile, then there should be a way for me to enforce presence of such a source".
imho, what I propose is nothing more then your proposal + some more use-cases, thus more configurations possible, thus more users that are happy.
To your case btw, simply strict=true will suffice indeed and this will be supported. I am almost done with the implementation btw, but it will take a while to properly test this out. thank you for your feedback.

I completely agree with your proposal, I was just thinking, maybe we are making it now a bit too complex/flexible. But I eventually think you're right and that this is the way to go.

I've hit a bummer :( and I need a bit of help here on the correct approach. Here is the explanation, supposed we have such a config:
spring:
  cloud:
    kubernetes:
      config:
        sources:
           - name : a
             include-profile-specific-sources: true

and active profiles are dev. In such a case we will be reading two configmaps: a, a-dev. Now let's transpose this to labels instead of a name:
spring:
  cloud:
    kubernetes:
      config:
        sources:
           - labels :
                color: red
              include-profile-specific-sources: true

And we have two configmaps defined. a with labels color: red and a-dev with labels color: blue (yes, their labels do not match). What we currently will be reading is : a and a-dev, as we do not care if profiles based sources (a-dev that is) matches the initial labels. This is a decision I took when creating the functionality about include-profile-specific-sources.

Now we add strict into the picture:
spring:
  cloud:
    kubernetes:
      config:
        sources:
           - name : a
              strict: false
             include-profile-specific-sources: true
             strict-for-profiles:
                - dev

In this case, we know upfront the configmaps that we should be reading by name : a and a-dev. Even if a is not present, we are not going to fail, because it has strict=false. On the other hand if a-dev is missing, we will fail, since strict-for-profiles=dev.
And now for labels:
spring:
  cloud:
    kubernetes:
      config:
        sources:
              labels:
                 color: red
              strict: false
              include-profile-specific-sources: true
              strict-for-profiles:
                - dev

We do not know the configmap names upfront, we need to find them by labels first. So we search for labels = color: red. Such a configmap is not present, but we do have strict-for-profiles=dev. And ... what do we do know? We do not know the name of the configmap to be appended to the profile...

I am inclined to say that my decision about reading a-dev (from the previous sample), where I did not care if it matches the initial labels (color: red), was wrong.
Instead I should have not used name at all, when dealing with labeled sources. So for example:
spring:
 cloud:
   kubernetes:
     config:
       sources:
          - labels :
               color: red
             include-profile-specific-sources: true
             strict-for-profiles:
               - dev
               - us-west

there are 3 active profiles : k8s, dev and us-west and 5 configmaps:

a with labels color: red
b with labels color: blue
c-dev with labels color: red
d-us-west with labels color: red
e-k8s with labels color: red

We read all configmaps in the namespace and filter the ones with labels color: red (this way we do not touch b) and then:

first get properties from a
then get properties from e-k8s. This one comes before c-dev and d-us-west, since this is kind of optional, as it is not part of strict-for-profiles
then read c-dev
then read d-us-west

The order of the last two are important as it is maintained. My assumption here is that since you have used strict-for-profiles, you do not only care about strictness, but about their order too. You can think about it this way:

anything that is not part of strict-for-profiles is read without any order
anything that is part of strict-for-profiles is read in the strict definition order.

I can fix this thing in this PR also, but I need help from @ryanjbaxter .

I am kind of lost from the beginning here, the application should fail to start if fail-fast is set to true

If you want your application to fail the start-up process in such cases, you can set spring.cloud.kubernetes.config.fail-fast=true to make the application start-up fail with an Exception.

fail-fast has only an effect when there is an Exception. To put it simpler:
try {
    // try to read a configmap
catch(Exception any) {
    if (failFast) {
          throw ....
    }
    else {
       // log.error(...)
    }
}

Currently, there is no way to fail for a missing source.

OK now it makes more sense.  The issue here is whether to fail if the configmap is missing completely.
When I think about this, its just not something we do for the most part.  As @wind57 points out, in a simple Spring app if there is no profile specific configuration file the app does not fail to start.
Now there is one case where I can think of where we would fail if a configuration file does not exist and this is when using spring.config.import.  If for example you say spring.config.import=file:///this/does/not/exist.yaml the application will fail to start I believe.  However if you say spring.config.import=optional:file://this/does/not/exist.yaml it will start just fine.
Now we do support spring.config.import in our main branch but right now the application will still start just fine if the configmap does not exist and thats because the PropertySourceLocator does not throw any kind of exception.
It feels like maybe using spring.config.import already has this concept, but im unsure how we should properly leverage it at the moment.

I have tried to have a POC here, it's still not finished. The idea of how I was envisioning this is described above in my comments with strict and strict-for-profiles for example.
I don't know what you think about Ryan. If its a direction you want to pursue, I would bring that to a stable state.

Honestly it seems overly complicated, there are just too many variations.
I also think that if the application is missing a property it requires than it should fail, the source of where that property comes from should not really matter, its the value that matters at the end of the day.

I debated this with myself for quite a while. I had the same thought that the app should fail elsewhere, if you need a property.
Then I decided - what if I try to implement it, how complicated can it get? The response is very, so much that I had a very hard time with my own thoughts.
At this point in time, I am convinced that its not worth. Ill close my PR for the time being.

Hi @wind57, thanks for putting so many efforts into this. I can quiet relate to your state of mind when you write that you had a hard time with your own thoughts :)
I do agree with @ryanjbaxter as well that this got overly complicated, but in my eyes, i find it illogical (in the context of a spring boot app), to have an application starting without any warnings if no configmaps are found while the presence of the spring-cloud-kubernetes dependency clearly indicates the intention of using configmaps.
The same parallelism can be found with :  spring boot fails to start when you declare spring-data-jpa without having any jdbc driver in your classpath.
It's for that reason that I raised this issue. Fail/Warn during startup if not a single configmap is found :) But as I wrote before, I'm not knowledgeable on all the implications, so I do trust your judgements over mine :)

if no configmaps are found while the presence of the spring-cloud-kubernetes dependency clearly indicates the intention of using configmaps

That is not true, you can use spring-cloud-kubernetes for a variety of things

The same parallelism can be found with : spring boot fails to start when you declare spring-data-jpa without having any jdbc driver in your classpath.

To me this is a bit different.  This is a dependency that needs to be present in order to function.  The equivalent in Spring Cloud Kubernetes is if you tried to use it without Fabric8 or the Kubernetes Java Client on the classpath.
I marked the issue as waiting for votes to see if other community members think they want this functionality.

I would vote for failing if configmap is not found with fail-fast property.
The real case is that configmap has been deleted and application context is refreshed via actuator /refresh endpoint. In this situation the application keeps running and keeps failing for every event or request because the bean with missing property cannot be created. Maybe I am missing an option to force the application to shutdown if property is not found after refresh has happened?

Even if we shut down the application because the config map was deleted wouldn't K8S keep trying to redeploy the pod and then run into the same problem?

No, the difference is that @RefreshScope/@ConfigurationProperties beans are recreated lazily when these beans are actually used in code and, on the other hand, when application is starting it creates them on startup and shuts down if it can't create them.

Right so if we provided an option to shut the application down if the config map is not found, Kubernetes will just restart it because it believes it should be running, and it will fail at startup again.  I guess I don't see how this is helping with the issue.


Dragging an editor group into the pinned tab row does not pin the tabs

Testing #193991
Have a group on the left with pinned and non-pinned tabs. Have a group on the right with any number of non-pinned tabs. Move the entire right group (by dragging from empty space in tabs bar) into the empty space of the pinned tabs bar.
The result is that the editors are not pinned, when they should be.

This is intentional. We keep the state of the tabs when merging groups. Imagine having pinned and unpinned tabs in the dragged group, and pulling it into the pinned tab bar. All pinned tabs will stay pinned, but you don't want to pin the unpinned tabs then.
What if you only have a pinned tab bar in the target group? Then you will always have to pin all the tabs.
I think the behaviour is correct, however, one potential change I considered was to highlight both tab bar containers when dragging an editor group over one of the tab bar containers.

Yeah you bring up a good point, so lets leave it as it is. Your suggestion makes sense to me, but not high prio.

This is the only change I could imagine.  This change probably relies on the debt work we do here: #193690

Theoretically we could also just highlight one container if there is only un/pinned tabs, however, this will create it's own complications.

As there sometimes is only one tab bar with just pinned tabs, this makes it much harder to make this a nice experience without users accidentally pinning/unpinning all tabs. I haven't seen any community members mention this as a problem, so closing for now.


weekly Qcov18 has wrong hint

since this is a single choice question
https://github.com/influenzanet/common-study-definition/blob/560fc30f54ea039eec920d6f292b91c61ff64cb6/src/studies/common/questionPools/weeklyQuestions.ts#L1870
should not be there

Fixed in 6dee9772d8d64c81f8c1984a2bf9886cbb5fa051


Enable building on arm64

With this change, I can build source-build on RHEL 8 on arm64:
$ ~/source-build/dotnet-sdk/dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100
 Commit:    04339c3a26

Runtime Environment:
 OS Name:     rhel
 OS Version:  8
 OS Platform: Linux
 RID:         rhel.8-arm64
 Base Path:   /home/omajid/source-build/dotnet-sdk/sdk/3.0.100/

Host (useful for support):
  Version: 3.0.0
  Commit:  62f8ee7211

.NET Core SDKs installed:
  3.0.100 [/home/omajid/source-build/dotnet-sdk/sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.App 3.0.0 [/home/omajid/source-build/dotnet-sdk/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 3.0.0 [/home/omajid/source-build/dotnet-sdk/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download
$ ~/source-build/dotnet-sdk/dotnet new console
The template "Console Application" was created successfully.

Processing post-creation actions...
Running 'dotnet restore' on /home/omajid/source-build/hello/hello.csproj...
  Restore completed in 122.02 ms for /home/omajid/source-build/hello/hello.csproj.

Restore succeeded.

$ ~/source-build/dotnet-sdk/dotnet run
Hello World!

I also needed this change to arcade-services:
diff --git a/tools-local/arcade-services/eng/Versions.props b/tools-local/arcade-services/eng/Versions.props
index c69a2ff..6350ff1 100644
--- a/tools-local/arcade-services/eng/Versions.props
+++ b/tools-local/arcade-services/eng/Versions.props
@@ -12,7 +12,7 @@
     <CommandLineParserVersion>2.2.1</CommandLineParserVersion>
     <CredentialManagementVersion>1.0.2</CredentialManagementVersion>
     <HandlebarsNetVersion>1.9.5</HandlebarsNetVersion>
-    <LibGit2SharpVersion>0.26.0</LibGit2SharpVersion>
+    <LibGit2SharpVersion>0.27.0-preview-0020</LibGit2SharpVersion>
     <log4netVersion>2.0.8</log4netVersion>
     <SystemNetHttpVersion>4.3.3</SystemNetHttpVersion>
     <MicrosoftAzureKeyVaultVersion>3.0.3</MicrosoftAzureKeyVaultVersion>

Some open questions:

I am working on opening PRs to get these patches merged in the orginial repos. What should I do for the release/3.0 and release/3.1 branches? Should I try and get the fixes in the original repos too? Or is it okay to carry these patches for 3.0 and 3.1?

There's a ton of hardcoded x64 assumptions. Is there a longer term plan to fix them? Is this something I need to look into?

There's a number of assumptions that cross compile and arm mean that the tools building this are x64 (only).

Any thoughts or comments?

@dleeapho @dseefeld Should I target this PR against release/3.1 instead of release/3.0?

@adaggarwal is working on merging 3.0 to 3.1 (https://github.com/dotnet/source-build/pull/1355), after that 3.1 will be our primary development branch.  I think this is okay to stay against release/3.0, after 3.0.1 (https://github.com/dotnet/source-build/pull/1260) is in we'll take this and add it to the 3.1 merge - if that sounds good to you Aditya?

@adaggarwal Aditya Aggarwal FTE is working on merging 3.0 to 3.1 (#1355), after that 3.1 will be our primary development branch. I think this is okay to stay against release/3.0, after 3.0.1 (#1260) is in we'll take this and add it to the 3.1 merge - if that sounds good to you Aditya?

Yep. That sounds reasonable.

I rebased it onto the latest release/3.0 and I am running into a new issue. Darc seems to use an older version of libgit2sharp and wont run on RHEL 8 arm64 at all :disappointed:

I think that should be a reasonably easy fix, Darc needs the update here and then we can change our Darc version.

The version here should already be correct. How do I find out what darc version that is included in? Currently, source-build pulls down this version:
Tool 'microsoft.dotnet.darc' (version '1.1.0-beta.19515.3') was successfully installed.

Oh, I can just put the new version in DarcVersion.txt but even 1.1.0-beta.19557.3 doesn't seem to have the fix :(

1.1.0-beta.19557.3 is https://github.com/dotnet/arcade-services/commit/663f6a8ba1f8adb8a7e4e618b15e0b5a29c4489b, which has that same 0.27 preview 0024 version: https://github.com/dotnet/arcade-services/blob/663f6a8ba1f8adb8a7e4e618b15e0b5a29c4489b/eng/Versions.props#L15.  I don't know if we need an even newer version or if that isn't the root of the problem, any ideas?

Hey @tmds, any idea what to do here? Is there some way to find out what version of libgit2sharp is being used by darc and that version of libgit2sharp has the fix you added?

Oh, I noticed that some build scripts set LD_LIBRARY_PATH, pointing to a linux-x64 path: tools-local/init-build.proj and uild-source-tarball.sh. Getting rid of those lines doens't seem to have helped.

Is there some way to find out what version of libgit2sharp is being used by darc and that version of libgit2sharp has the fix you added?

You can check what version ends up under ~/.nuget/packages.
When 0.27.0-preview-0020 was published on nuget.org, I verified it has the fix.

@tmds' comment here explains it:

That fix applies to .NET Core 3.0+. Earlier versions don't have the NativeLibrary class that is used by the fix.

The prebuilt darc (which is acquired, not built from source) is a .NET Core 2.x tool, so it can't make use of NativeLibrary. That means we do need to give it the correct LD_LIBRARY_PATH override.
https://github.com/dotnet/source-build/blob/3aaca4dc88d07bfcab1c5ed6d20d1bc144974b53/tools-local/init-build.proj#L177 needs to be modified to debian.arm64 to work on RHEL 8 + arm64.

Many builds failed in the tarball step:
ERROR: dotnet-dev-certs.3.0.0-rc2.19465.2.nupkg is not in the allowed prebuilts list (/src/support/allowed-prebuilts.txt)

Any suggestions on what to do here? Is this prebuilt not expected?

@dseefeld was also seeing this recently, I'm not sure if he found a solution yet.

Sounds like it was just two PRs going in without being tested against each other, should be fixed after https://github.com/dotnet/source-build/pull/1365 goes in.

I have rebased this against the release/3.1 branch to pick up the darc fixes.

@dleeapho @crummel @dseefeld All my local testing looks good. CI seems happy too. What are the next steps here?

Rebased on the 3.0 => 3.1 merge, it was pretty clean but let me know if anything looks weird.

Quick update: rebase completely broke everything :( Aside from patches not applying, looks like we are back to an older version of darc that doesn't work on rhel.8-arm64.

Sorry about that, I think I fixed the patches now.

Thanks! I am going to try out this locally on an arm64 box.

The OSX failure is expected so we can merge this as soon as it looks good to you @omajid.

I am seeing core-sdk builds failures on my machine. Not sure why.
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018: The "DownloadFile" task failed unexpectedly. [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018: System.IO.DirectoryNotFoundException: Could not find a part of the path '/home/omajid/source-build/bin/obj/arm64/Release/blobs/Toolset/3.1.100-rtm.19566.4/dotnet-toolset-internal-3.1.100-rtm.19566.4.zip'. [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at System.IO.FileStream.OpenHandle(FileMode mode, FileShare share, FileOptions options) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at System.IO.FileSystem.CopyFile(String sourceFullPath, String destFullPath, Boolean overwrite) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at System.IO.File.Copy(String sourceFileName, String destFileName, Boolean overwrite) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at System.IO.File.Copy(String sourceFileName, String destFileName) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at Microsoft.DotNet.Cli.Build.DownloadFile.Execute() in /_/src/core-sdk-tasks/DownloadFile.cs:line 41 [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]
      0 Warning(s)
      1 Error(s)

Looks like /home/omajid/source-build/bin/obj/arm64/Release/blobs/Toolset/ doesn't even exist.

Actually, looks like the toolset build failed (flaky network?) and error cascaded on:
  Failed to download package 'Microsoft.Docker.Sdk.1.1.0' from 'https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg'.
  The HTTP request to 'GET https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg' has timed out after 100000ms.
  Failed to download package 'Microsoft.Docker.Sdk.1.1.0' from 'https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg'.
  The HTTP request to 'GET https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg' has timed out after 100000ms.
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : Failed to download package 'Microsoft.Docker.Sdk.1.1.0' from 'https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg'. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : The HTTP request to 'GET https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg' has timed out after 100000ms. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
##vso[task.logissue type=error;sourcepath=/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets;linenumber=123;columnnumber=5;code=;]Failed to download package 'Microsoft.Docker.Sdk.1.1.0' from 'https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg'.%0AThe HTTP request to 'GET https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg' has timed out after 100000ms.
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : The feed 'container-tools [https://www.myget.org/F/container-tools-for-visual-studio/api/v3/index.json]' lists package 'Microsoft.Docker.Sdk.1.1.0' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error :   Unable to find package 'Microsoft.Docker.Sdk.1.1.0'. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
##vso[task.logissue type=error;sourcepath=/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets;linenumber=123;columnnumber=5;code=;]The feed 'container-tools [https://www.myget.org/F/container-tools-for-visual-studio/api/v3/index.json%5D' lists package 'Microsoft.Docker.Sdk.1.1.0' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again.%0A  Unable to find package 'Microsoft.Docker.Sdk.1.1.0'.
  Restore completed in 17.96 ms for /home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj.
  Copied Sdk ILLink.Tasks from /home/omajid/source-build/packages/restored//illink.tasks/0.1.6-prerelease.19380.1 to /home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/artifacts/bin/redist/Release/netcoreapp3.1//Sdks/ILLink.Tasks.
  Successfully created package '/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/artifacts/packages/Release/NonShipping/Microsoft.Dotnet.Toolset.Internal.3.1.100-rtm.19566.4.nupkg'.

Build succeeded.

/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : Failed to download package 'Microsoft.Docker.Sdk.1.1.0' from 'https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg'. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : The HTTP request to 'GET https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg' has timed out after 100000ms. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : The feed 'container-tools [https://www.myget.org/F/container-tools-for-visual-studio/api/v3/index.json]' lists package 'Microsoft.Docker.Sdk.1.1.0' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error :   Unable to find package 'Microsoft.Docker.Sdk.1.1.0'. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
    0 Warning(s)
    2 Error(s)

Time Elapsed 00:05:53.45

Sorry about the noise. Everything looks good here. :+1: to merge this.

Awesome, thanks for doing this!

:tada: :tada: :tada:


chore: use azure storage static web serving rather than public access

$web container is a special container that serves static web content without requiring public access enablement (xref: https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-static-website)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.55%. Comparing base (3874533) to head (e126a3b).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
+ Coverage   51.66%   52.55%   +0.88%
==========================================
  Files          53       53
  Lines        2938     2445     -493
==========================================
- Hits         1518     1285     -233
+ Misses       1378     1118     -260
  Partials       42       42

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Checking for php 7 features

Hello guys. Is it possible to check with phpmd, that my code follows php7 standards. e.g. declaration "strict_types=1" exists, every argument in method has type hint, every method has return type specified etc ?
Thanks

You can use the extra PHPCS rules from https://github.com/slevomat/coding-standard for that.

@sergeynezbritskiy depending on what exactly you want to check, a style checker could be more appropriate. Please, provide examples of what you want to check, if you haven't found any other tool, yet.


Newsletter #36: fix sighash error

Thanks for reporting @sipa and @roconnor!

tACK

Thoughts about:

tweeting a correction from the optech account (in response to https://mobile.twitter.com/bitcoinoptech/status/1102974208080920576)?
including a 'corrections' section in next week's newsletter?

I'd vote yes, but don't feel too strongly.

I can tweet it if harding gives ACK.
On Tue, Mar 5, 2019 at 3:56 PM John Newbery<EMAIL_ADDRESS>wrote:

Thoughts about:

tweeting a correction from the optech account (in response to
https://mobile.twitter.com/bitcoinoptech/status/1102974208080920576)?
including a 'corrections' section in next week's newsletter?

I'd vote yes, but don't feel too strongly.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/bitcoinops/bitcoinops.github.io/pull/115#issuecomment-469908392,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAT6AxQl-zr2KpAC2BCcHBEHcVIAvC4Xks5vTwQwgaJpZM4bfd82
.


Adding the data-plugins into nornir_utils

Two comments:

I think we should add a file under nornir_utils/docs/source/api/tasks.rst for the docstrings of the tasks
When (1) is added, each tutorial could point to the corresponding signature like this: https://nornir.tech/nornir_utils/html/tutorials/function_print_result.html

Other than those two minor comments, this is excellent. If you also bump the version in this or the other PR you opened we can release after we have merged both. Thanks!

@dbarrosop Okay, I think I did the items requested.
I also regenerated/updated all of the docs.
I visually inspected the docs related to these "data" tasks and also the YAMLInventory and on quick review they looked right.

Awesome work, thanks!


Verification key hashes in account updates

Add verification key hashes to account updates with a Proof authorization, to know which verification key is meant to verify the accompanying proof.
Closes #12378.

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

The build on develop (including when trying to merge it in) has errors in my build environment so it's hard for me to make further progress as of now. As far as I can tell here are the todo items:

Fix the merge conflicts in the SnarkyJS submodule by merging berkeley into feature/vk-hash in SnarkyJS repo and then using that branch for the submodule (even after that, it looks like the SnarkyJS version on develop isn't tracking berkeley so there may be more missing commits to merge in -- I hate submodules)
Update the zkApp v1 test in src/lib/transaction/transaction_hash.ml as there is a hardcoded transaction id that needs to be regenerated
Regenerate the GraphQL schema

Here is the JSON of the zkApp in the transaction hash unit test in develop: ```{
"fee_payer": {
"body": {
"public_key": "B62qjeuHb4wdiAcEMSeV6CsRJF3PGKvo51M4qv5q3dZdncN2AvzAYug",
"fee": "1",
"valid_until": null,
"nonce": "1"
},
"authorization": "7mX9QKJPXx9hnknkED4vKTiZCTxjwL7WcXH8LE8UFUUTyNqmJniTssRUdZjyR4ntJgHrvwjtSRshKaC3jk4nUVwD3X4oj8Bo"
},
"account_updates": [
{
"elt": {
"account_update": {
"body": {
"public_key": "B62qqwB9pH75EZsjzbVKrd3RrFEM7WFEcmJ4Z6YpEqY3BB7GQSDbdeV",
"token_id": "wSHV2S4qX9jFsLjQo8r1BsMLH2ZRKsZx6EJd1sbozGPieEC4Jf",
"update": {
"app_state": [
[
"Set",
"0x0000000000000000000000000000000000000000000000000000000000000001"
],
[
"Set",
"0x0000000000000000000000000000000000000000000000000000000000000002"
],
[
"Set",
"0x0000000000000000000000000000000000000000000000000000000000000003"
],
[
"Keep"
],
[
"Keep"
],
[
"Keep"
],
[
"Keep"
],
[
"Keep"
]
],
"delegate": [
"Keep"
],
"verification_key": [
"Keep"
],
"permissions": [
"Keep"
],
"zkapp_uri": [
"Keep"
],
"token_symbol": [
"Keep"
],
"timing": [
"Keep"
],
"voting_for": [
"Keep"
]
},
"balance_change": {
"magnitude": "0",
"sgn": [
"Pos"
]
},
"increment_nonce": false,
"events": [],
"actions": [],
"call_data": "0x0000000000000000000000000000000000000000000000000000000000000000",
"preconditions": {
"network": {
"snarked_ledger_hash": [
"Ignore"
],
"blockchain_length": [
"Ignore"
],
"min_window_density": [
"Ignore"
],
"last_vrf_output": null,
"total_currency": [
"Ignore"
],
"global_slot_since_genesis": [
"Ignore"
],
"staking_epoch_data": {
"ledger": {
"hash": [
"Ignore"
],
"total_currency": [
"Ignore"
]
},
"seed": [
"Ignore"
],
"start_checkpoint": [
"Ignore"
],
"lock_checkpoint": [
"Ignore"
],
"epoch_length": [
"Ignore"
]
},
"next_epoch_data": {
"ledger": {
"hash": [
"Ignore"
],
"total_currency": [
"Ignore"
]
},
"seed": [
"Ignore"
],
"start_checkpoint": [
"Ignore"
],
"lock_checkpoint": [
"Ignore"
],
"epoch_length": [
"Ignore"
]
}
},
"account": [
"Accept"
],
"valid_while": [
"Ignore"
]
},
"use_full_commitment": true,
"implicit_account_creation_fee": false,
"call_type": [
"Call"
],
"authorization_kind": [
"Signature"
]
},
"authorization": [
"Signature",
"7mXJq1qkSRt7kaJ8hXaY417r441PV2mwZ5wzJ9C9apPUhwfAyR7XNpDTzhFwG3p6HmumTHXatBEg4XAKjBazye3nsCpHFb4R"
]
},
"account_update_digest": "0x3F0A0B3C47901A8052952A157285A7D1760EA5EA2AF28A4AE4FBC1064CCCA26E",
"calls": []
},
"stack_hash": "0x27EE04068E44B133C2A37520CC2B32B3CBC45C219BC7E574D1E374480E986DDA"
}
],
"memo": "E4YM2vTHhWEg66xpj52JErHUBU4pZ1yageL4TVDDpTTSsv8mK6YaH"
}
I think you can just use the transaction id that's in `develop`. The `authorization_kind` and `authorization` could be changed to use a proof, if desired, although I don't think that's needed for the test.

!ci-build-me

!ci-build-me

The SnarkyJS part is good to go!

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me


AWESOME Project! Do you take donations?

quick questions...

How can I predefine the size of the iFrame or make it 100% x 100% by default ?

How can I disable scrolling of the page contents whenever a Lightbox is opened and active ?
NOTE: I am referring to the contents behind the Lightbox, it is annoying to see it scroll.

How can I disable scrolling of the page contents whenever a Lightbox is opened and active ?

Add this to CSS:
.lity-active,
.lity-active body {
    overflow: hidden;
}


[BugFix] fix ArrayIndexOutOfBoundsException in HiveScanner

Fixes the java exception error when reading hive RCFilie, the detail error message is
java.io.IOException: Failed to get the next off-heap table chunk of hive.
        at com.starrocks.hive.reader.HiveScanner.getNext(HiveScanner.java:241)
        at com.starrocks.jni.connector.ConnectorScanner.getNextOffHeapChunk(ConnectorScanner.java:101)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 10 out of bounds for length 10
        at org.apache.hadoop.hive.serde2.columnar.BytesRefArrayWritable.unCheckedGet(BytesRefArrayWritable.java:104)
        at org.apache.hadoop.hive.ql.io.RCFile$Reader.getCurrentRow(RCFile.java:1939)
        at org.apache.hadoop.hive.ql.io.RCFileRecordReader.next(RCFileRecordReader.java:149)
        at org.apache.hadoop.hive.ql.io.RCFileRecordReader.next(RCFileRecordReader.java:44)
        at com.starrocks.hive.reader.HiveScanner.getNext(HiveScanner.java:223)

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

Can you reproduce this case in UT?
To be honest, I don't quite get why this change fix problem.

I can reproduce it in the test environment.

Create a hive external catalog on StarRocks.
Query the tpch.lineitem RCFile table generated by Hive.

These SQLs should fail without this fix:
select count(1) from lineitem group by l_shipdate;
select count(1) from lineitem where l_shipdate <= '1998-09-02';

Remove the where or group by clause，they did not fail.

I got it! org.apache.hadoop.hive.ql.io.RCFile has one method  getCurrentRow(), in getCurrentRow(), if rowFetched is false, which means this is the first time to call  getCurrentRow, it will set reader's value( which is BytesRefArrayWritable)'s capacity according to number of columns reader want. But this only happens on the first time.So if we call createValue in HiveScanner.getNext(), the second time this value's capacity will not be reset, and default capacity is 10, which cause arrayIndexoutofbound exception.

LGTM


Doesn't create a valid PWA by default

Is this a bug report?
Yes
Did you try recovering your dependencies?
Yes
Which terms did you search for in User Guide?

lighthouse
pwa

Environment

node -v 8.11.1:
npm -v 5.6.0:
npm ls react-scripts (if you haven’t ejected): 1.1.4

Then, specify:

Operating system: macOS High Sierra
Browser and version (if relevant): Chrome 65

Steps to Reproduce
Fresh CRA + Netlify w/ HTTPS ==> Lighthouse === not a valid PWA.
(Write your steps here:)

create-react-app foo --use-npm
Push app to Github
Have Netlify manage it
Associate with domain
Use Netlify to generate Let's Encrypt cert
Set "Deploy Settings" to "Build command: npm run build" and "Publish Directory: build"
Verify site works/exists on https
Run Lighthouse PWA audit
See errors:

Here's the demo code (fresh CRA): https://github.com/corysimmons/test-cra-pwa-netlify/tree/55643ddf023d2eb4b267ca72f568268752ea398a
Here's the site: https://testing-1-2-3.com
The image sizes are easy enough for me to fix (although they should be in CRA tbh), but the Service worker does not successfully serve the manifest's start_url. confuses me.
I've tried changing the start_url to:

./index.html
./
.
index.html
https://testing-1-2-3.com
./build
./build/index.html

...and keep getting the same failure.
Related

https://github.com/GoogleChrome/lighthouse/issues/4541#issuecomment-366662681

Per https://github.com/GoogleChrome/lighthouse/issues/4541#issuecomment-367006053 it might be a false positive.
Is there anything CRA can do to help with this?
If not, CRA still needs 192 & 512 icons to make it valid (in Lighthouse's eyes anyway?).

Apparently this really is just a false positive (even throws error on Google properties). It's up to you if you want to do the 192 + 512 icons. Closing


[Storage] Address API View feedback for STG 82 GA

This addresses all of the feedback from the API View review for the STG 82 API View review. Included in the change:

Some type hint updates to fix incorrect changes
Make progress callback from async upload_blob async
file_last_written_mode -> file_last_write_mode
Replace ContentSettings input on rename_file with singular content_type instead

API change check for azure-storage-blob
API changes have been detected in azure-storage-blob. You can review API changes here
API changes
-         ) -> None
+         ) -> Dict[str, Union[str, datetime]]
-             progress_hook: Callable[[int, Optional[int]], None] = ...,
+             progress_hook: Callable[[int, Optional[int]], Awaitable[None]] = ...,
-         ) -> None
+         ) -> Dict[str, Union[str, datetime]]
-             progress_hook: Callable[[int, Optional[int]], None] = ...,
+             progress_hook: Callable[[int, Optional[int]], Awaitable[None]] = ...,

API change check for azure-storage-file-share
API changes have been detected in azure-storage-file-share. You can review API changes here

API change check for azure-storage-file-datalake
API changes have been detected in azure-storage-file-datalake. You can review API changes here
API changes
-         ) -> None
+         ) -> Dict[str, Union[str, datetime]]


Does we need the debug messages?

If we run it on multiple server, it is annouing to see such a big messages
      Monday 11 May 2020  20:49:35 +0000 (0:00:00.352)       0:01:54.455 ************
       ok: [localhost] => {
           "locale_status": {
               "changed": false,
               "cmd": [
                   "localectl",
                   "status"
               ],
               "delta": "0:00:00.146804",
               "end": "2020-05-11 20:49:35.208983",
               "failed": false,
               "rc": 0,
               "start": "2020-05-11 20:49:35.062179",
               "stderr": "",
               "stderr_lines": [],
               "stdout": "   System Locale: LANG=en_US.UTF-8\n       VC Keymap: n/a\n      X11 Layout: us\n       X11 Model: pc105",
               "stdout_lines": [
                   "   System Locale: LANG=en_US.UTF-8",
                   "       VC Keymap: n/a",
                   "      X11 Layout: us",
                   "       X11 Model: pc105"
               ]
           }
       }

No, I do not think so.

05bc9223c688a92c5f55244434170d9ed9d0126a


Add Step Scaling to reduce Artifacts when scaled

we are having an issue where some big images have artifacts when scaled down.
This is a general canvas issue and a common solution is  step scaling
see: https://jsfiddle.net/AbdiasSoftware/M4cTx/
Is there a way to make cornerstone step scale images ?
thanks!

Hello,
There is no way to make Cornerstone do this at the moment. It sounds like an interesting technique but it might have a significant effect on performance.

it will mean keeping an original copy of the image and on each scaling creating scaled copy to work with (As in the fiddle), zooming will definitely end up slower (but maybe ok) but we get the improved image quality plus I imagine window leveling will become very fast as the image is actually much smaller.
On some images (ie 6 mega pixels CR with a grid in front of the plate), the different in quality is quite dramatic.

Yeah. This technique is usually referred as mip mapping. Basically, you need to apply a low pass filter when re-sampling in accordance with the Nyquist sampling theorem in order to avoid aliasing. This is the functional equivalent to interpolation for downscaling.
With that said, implementing may be a nice to have, but reduce performance at startup (to build the pyramid) and would take an additional 1/3 memory.  The patterns that produce aliasing artefacts are not all that common in medical imaging and they should be examined as close to full resolution for diagnostic purposes.
Once the pyramid computed, it could indeed increase the performance of W/L when zoomed out.
It would be nice if the browser could just apply it by itself just like it does interpolation...

@kofifus, Do you have a DICOM file that shows these artefacts that you could share by chance?

Never-mind, I created a sample :
aliasing512x512.dcm.zip
Also, a video of the issue:
alias.mp4.zip

ok great, I will try to also get my dicom file to you.
so is there any ideas about solving this with cornerstone ?
thx!

It would be nice if you can get any real case showing this issue. I'm not
convinced, given the tradeoffs, that this would add significant clinical
value.
On Sun, Apr 23, 2017, 6:58 PM Kofifus<EMAIL_ADDRESS>wrote:

ok great, I will try to also get my dicom file to you.
so is there any ideas about solving this with cornerstone ?
thx!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/chafey/cornerstone/issues/114#issuecomment-296495126,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAr2MLxQG4ZP_gQ8ZajUtTRsGa_-Whq-ks5ry9eTgaJpZM4NCeyr
.

Here is a sample image:
https://www.dropbox.com/s/7gxsqajpovnij0a/Cornerstone_aliasing.zip?dl=0
You will see the artifacts as you zoom in and out.
The image was taken with a grid in front of the plate (I can find out the name of the procedure).
Thanks!

I could see the artefacts between 30% and 40% magnification.
I suppose mip mapping could be added behind a flag as it increases resource
requirements for a limited return.
Unfortunately, I don't think this is on anybody's road map... Contributions
are welcomed.
JF
On Mon, Apr 24, 2017 at 12:19 AM Kofifus<EMAIL_ADDRESS>wrote:

Here is a sample image:
https://www.dropbox.com/s/7gxsqajpovnij0a/Cornerstone_aliasing.zip?dl=0
You will see the artifacts as you zoom in and out.
The image was taken with a grid in front of the plate (I can find out the
name of the procedure).
Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/chafey/cornerstone/issues/114#issuecomment-296521473,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAr2MHWVbhF-9JMWdi7A4kUYDLVHV0fAks5rzCLIgaJpZM4NCeyr
.

FWIW, most viewers do not worry about this use case as images must be
displayed at full resolution (or higher) for interpretation.
On Mon, Apr 24, 2017 at 5:36 AM, Jean Francois Pambrun <
<EMAIL_ADDRESS>wrote:

I could see the artefacts between 30% and 40% magnification.
I suppose mip mapping could be added behind a flag as it increases resource
requirements for a limited return.
Unfortunately, I don't think this is on anybody's road map... Contributions
are welcomed.
JF
On Mon, Apr 24, 2017 at 12:19 AM Kofifus<EMAIL_ADDRESS>wrote:

Here is a sample image:
https://www.dropbox.com/s/7gxsqajpovnij0a/Cornerstone_aliasing.zip?dl=0
You will see the artifacts as you zoom in and out.
The image was taken with a grid in front of the plate (I can find out the
name of the procedure).
Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/chafey/cornerstone/issues/114#issuecomment-296521473
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAr2MHWVbhF-
9JMWdi7A4kUYDLVHV0fAks5rzCLIgaJpZM4NCeyr>
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chafey/cornerstone/issues/114#issuecomment-296650852,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNb2mfe9MTa0lTSM9GMIDIXjOf82h87ks5rzJdmgaJpZM4NCeyr
.

As already mentioned here, I suggest the step scaling approach, which involves keeping an original copy of the image and creating scaled copies to work with. This technique is usually referred to as mip mapping, and would require additional memory and potentially reduce performance at startup, but could improve image quality and potentially increase performance for certain functions such as window leveling when zoomed out. It seems that this feature is not currently on anyone's roadmap for development, but we can try to work around.


Need documentation on how to go from 1.4 to 2.0

Documentation request
In 1.4 to 1.5, there was a shift with using BFO instead of RO. The file "ro-ero-to-bfo2020.csv" can no longer be found. I saved it locally, but it should be findable. Anyone who hasn't updated from 1.4 to 1.5 in the last 9 months would need this.
This leads to a broader point. Since different users in the last year have been adopting 1.6, 1.7 and 2.0 in sequence (and slowly), there should be clearer documentation on how to make sure ontologies dependent on CCO don't break because they have made the necessary changes.
Could you, for example, provide a strategy for finding deprecated terms, identifying the version in which they were deprecated, so that as people develop they can ensure a smooth transition to 2.0?

This was helpful, but it is insufficient for upgrading from versions 1.3 thru 1.6, to 2.0
https://github.com/CommonCoreOntology/CommonCoreOntologies/blob/develop/documentation/mappping-new-iris/iri-mapping-v2.0.csv

It looks like the RO-ERO document is in GitHub -> Deployment -> Mappings

@jonathanvajda

The file "ro-ero-to-bfo2020.csv" can no longer be found.

The mapping file can be found via a link on the wiki page I created that describes for mapping between v1.4 to v1.5. The link was broken in the repo restructuring we recently did. Now fixed.

provide a strategy for finding deprecated terms,

In general, for updating extensions of CCO to newer versions, I would start with a look at the release notes for each version of CCO. They provide details about any axiomatic changes to IRIs, new IRIs, and deleted IRIs.


[Enhancement] show more info when calling seqChooseBackendIds

show more info after getting an empty list when choosing backends under condition
What type of PR is this:

[ ] BugFix
[ ] Feature
[X] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[X] I have checked the version labels which the pr will be auto-backported to the target branch

[X] 3.1
[X] 3.0
[X] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 7 / 7 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/system/SystemInfoService.java
7
7
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 13 / 15 (86.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/system/SystemInfoService.java
13
15
86.67%
[679, 680]

@nshangyiming I appreciate your comments, and fixing all of them ASAP. :)

@goldenbean no problem, thanks for you contribution.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: goldenbean:x: jing10.gaojing10.gao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

[FE PR Coverage Check]
:heart_eyes: pass : 13 / 15 (86.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/system/SystemInfoService.java
13
15
86.67%
[679, 680]

[FE PR Coverage Check]
:heart_eyes: pass : 21 / 21 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/system/SystemInfoService.java
21
21
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 33 / 33 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/system/SystemInfoService.java
33
33
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 33 / 33 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/system/SystemInfoService.java
33
33
100.00%
[]

@mergify rebase main

[FE PR Coverage Check]
:heart_eyes: pass : 33 / 33 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/system/SystemInfoService.java
33
33
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 33 / 33 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/system/SystemInfoService.java
33
33
100.00%
[]

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5

@goldenbean  the auto backport is failed, could you backport it manually?

checkout branch-xxx
create a backport branch based on branch-xxx
cherry-pick the commit from main branch
submit a pr whose base branch is branch-xxx
@goldenbean

manual backport to branch-3.1 in PR #34894


Allow users to dynamically add and remove goals from daily plan

Resolves #3
This PR allows user to add and remove goals when creating or editing their daily plans.
For now, Goals are being associated only with Dailys. It might be useful to associate Goal to each User since it is easy to imagine a scenario where a user has a number of goals that they pursue over multiple days. In addition to the text input field this PR introduces for goals, it might make sense to have a dropdown select box that is prepopulated with goals that have been defined by the user before.
The JavaScript client-side code introduced here uses plain JS as I didn't feel the need for a framework just yet.

Pull Request Test Coverage Report for Build 67

23 of 40 (57.5%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.0%) to 81.328%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/bearings/dailies/goal.ex
2
6
33.33%

lib/bearings_web/channels/daily_channel.ex
6
19
31.58%

Totals

Change from base Build 64:
-3.0%

Covered Lines:
196

Relevant Lines:
241

💛  - Coveralls


Code does not build correctly

img/realtalk1.png seems to be missing? Also, the background references ./riot_golf.png instead of img/riot_golf.png.
I would like to see this fixed as I would like to contribute some nice improvements

In my PR i fixed the ./riot_golf.png img location. realtalk1.png seems to still be missing tho :/

the file is only on the webserver didn't upload it into the repo will fix after merging #6

the file is only on the webserver didn't upload it into the repo will fix after merging #6

any update?


Safer and more convenient Haskell runtime start and stop

Let hsrt::start be called any number of times, ignoring subsequent calls.
Automatically call hs_exit at program exit.
Panic as a diagnostic if hsrt::stop is called manually more than once.

hsrt::stop doesn't technically need to panic, it could just ignore subsequent calls like hsrt::start, but I think that if you are going to call it manually, you should know exactly when all your exported Haskell functions become erroneous to call.
The tests are still in one #[test] function as Rust's test runner runs them in parallel and htest doesn't use the threaded runtime. It would be nice if we could set the threaded feature for profile.test, although I don't think that's currently possible with Cargo.
The Windows implementation for argument passing is correct as far as I can tell from the GHC sources, but not actually tested on Windows.
Provides a piece of #14.

Just wanted to let you know @nanotech I saw this the other day I just haven't had time to look at it. Busy weekend and my CS classes kicked it up a notch this week. I'll take a look at it soon and test it out on my windows gaming rig to see if the windows configuration works.

@nanotech This looks promising so far. I'm going to have to dig more into this to really understand what you've done but so far I like it a lot.

Man trying to set my environment to get this to work on windows has been a pain.  I was also out this weekend cause of drill so I'm only now doing some stuff on it.

Turns out we can't compile windows dlls in one go. I'll have to modify our make file for windows to work right

@nanotech As it stands this works like we would want on Unix and MacOSX. I think Windows is a hairy beast that's going to take some time to untangle. I'm going to merge this so we can continue work on it.


activity: Edit your file with headers

This is a pull request to 'learn' markdown.
Like year...

@ConfusedOnCOFFEE  Great job


Annotate pending tests with comments

Most of our pending tests have associated code comments. However, they're only visible when viewing the raw source, not when running rspec.
So this makes it visible when running tests why a particular test is pending.

Are we getting any value from having pending tests? Could we delete them if we can't re-enable them?

Good Q... I'm not in a hurry to drop them as I've been slowly wading through some of them and cleaning them up... that's how I ran into this PR actually, wondering if they could be cleaned up or not only to discover the code comments... the bundler ones I haven't looked at yet, they may be droppable if/when we drop bundler 1. The others are essentially self-documenting of bugs, so that no one is like "we missed test coverage"... and not harming anything in there for now.


[luci] mac try jobs fail to mount namedcache

35369 2020-06-02 22:56:24.750 E: NamedCache: failed to load named cache state file; obliterating
Traceback (most recent call last):
File "/b/s/swarming_bot.1.zip/client/local_caching.py", line 850, in init
self._lru = lru.LRUDict.load(self.state_file)
File "/b/s/swarming_bot.1.zip/utils/lru.py", line 74, in load
'Broken state file %s with "%s": %s' % (state_file, json_state, e))
ValueError: Broken state file /b/s/c/state.json with "": No JSON object could be decoded

Flutter builds now need more than 30G space available and three machines had less than 30G disk space available causing all sorts of errors. After removing those three machines we haven't seen the error anymore.