Building Out App With Service Discovery Breaks Using Docker

Describe the bug
When I build out my API using dotnet run, everything works as expected. However when I use a Docker container I get a null reference error on startup.
Steps to reproduce
Steps to reproduce the behavior:

Create a new Web Api Project
Add  Steeltoe.Discovery.ClientCore Steeltoe.Discovery.Consul
Add this to your appsettings.json file

  "spring": {
    "application": {
      "name": "AuthService"
    }
  },
  "Consul": {
    "host": "<IP_ADDRESS>",
    "port": 8500,
    "discovery": {
      "enabled": true,
      "register": true,
      "scheme": "http",
      "port": "5000",
      "ipAddress": "localhost"
    }
  }

Run your Consul client
Launch the api with dotnet run, all should work as expeced
Add a Dockerfile

# Build project dlls
FROM mcr.microsoft.com/dotnet/core/sdk:3.1 AS build-env
WORKDIR /app
COPY *.csproj ./
RUN dotnet restore
COPY . ./
RUN dotnet publish -c Release -o out

# Build runtime image
FROM mcr.microsoft.com/dotnet/core/aspnet:3.1
ENV TZ Africa/Johannesburg
WORKDIR /home
WORKDIR /app
COPY --from=build-env /app/out .
RUN ls -a
CMD ["dotnet", "AuthService.dll"]

Add a docker-compose.yml

version: '3.5'
services:
  jwtservice:
    container_name: jwtservice
    restart: always
    build: ./
    networks:
      - development
    ports:
      - "1448:80"
networks:
  development:
    name: development
    driver: "bridge"

Launch with docker-compose up and you will see a null reference error (See additional links and context)

Expected behavior
I expect the app to work the same between Docker and in my Host
Environment (please complete the following information):

Steeltoe 3.1
Docker - Linux
Linux
.NET Version 3.1

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context or links
The error is
jwtservice    | Application startup exception: System.NullReferenceException: Object reference not set to an instance of an object.
jwtservice    |    at Steeltoe.Discovery.Consul.Discovery.ConsulDiscoveryOptions.<>c.<ApplyConfigUrls>b__131_0(Uri u)
jwtservice    |    at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Func`2 predicate, Boolean& found)
jwtservice    |    at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source, Func`2 predicate)
jwtservice    |    at Steeltoe.Discovery.Consul.Discovery.ConsulDiscoveryOptions.ApplyConfigUrls(List`1 addresses, String wildcard_hostname)
jwtservice    |    at Steeltoe.Discovery.Consul.ConsulDiscoveryClientExtension.<>c__DisplayClass3_0.<ConfigureConsulServices>b__0(ConsulDiscoveryOptions options)
jwtservice    |    at Microsoft.Extensions.Options.PostConfigureOptions`1.PostConfigure(String name, TOptions options)
jwtservice    |    at Microsoft.Extensions.Options.OptionsFactory`1.Create(String name)
jwtservice    |    at Microsoft.Extensions.Options.OptionsManager`1.<>c__DisplayClass5_0.<Get>b__0()
jwtservice    |    at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
jwtservice    |    at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
jwtservice    |    at System.Lazy`1.CreateValue()
jwtservice    |    at System.Lazy`1.get_Value()
jwtservice    |    at Microsoft.Extensions.Options.OptionsCache`1.GetOrAdd(String name, Func`1 createOptions)
jwtservice    |    at Microsoft.Extensions.Options.OptionsManager`1.Get(String name)
jwtservice    |    at Microsoft.Extensions.Options.OptionsManager`1.get_Value()
jwtservice    |    at Steeltoe.Discovery.Consul.ConsulDiscoveryClientExtension.<>c__DisplayClass4_0.<AddConsulServices>b__1(IServiceProvider p)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitFactory(FactoryCallSite factoryCallSite, RuntimeResolverContext context)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite singletonCallSite, RuntimeResolverContext context)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite singletonCallSite, RuntimeResolverContext context)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite singletonCallSite, RuntimeResolverContext context)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass1_0.<RealizeService>b__0(ServiceProviderEngineScope scope)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
jwtservice    |    at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
jwtservice    |    at Steeltoe.Discovery.Client.DiscoveryApplicationBuilderExtensions.UseDiscoveryClient(IApplicationBuilder app)
jwtservice    |    at AuthService.Startup.Configure(IApplicationBuilder app, IWebHostEnvironment env) in /app/Startup.cs:line 86
jwtservice    |    at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
jwtservice    |    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
jwtservice    |    at Microsoft.AspNetCore.Hosting.ConfigureBuilder.Invoke(Object instance, IApplicationBuilder builder)
jwtservice    |    at Microsoft.AspNetCore.Hosting.ConfigureBuilder.<>c__DisplayClass4_0.<Build>b__0(IApplicationBuilder builder)
jwtservice    |    at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
jwtservice    |    at Microsoft.AspNetCore.Mvc.Filters.MiddlewareFilterBuilderStartupFilter.<>c__DisplayClass0_0.<Configure>g__MiddlewareFilterBuilder|0(IApplicationBuilder builder)
jwtservice    |    at Microsoft.AspNetCore.HostFilteringStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder app)
jwtservice    |    at Microsoft.AspNetCore.Hosting.WebHost.BuildApplication()
jwtservice    | crit: Microsoft.AspNetCore.Hosting.WebHost[6]
jwtservice    |       Application startup exception

This issue is solved by building the production Docker using FROM mcr.microsoft.com/dotnet/core/sdk:3.1 instead of FROM mcr.microsoft.com/dotnet/core/aspnet:3.1. No idea what is causing this?

This exception is being thrown due to a mishandling of the wildcard hostname in the url, which is already fixed and will ship in 3.0.2.
That being said, it looks like you've got some configuration for setting ip/port, and that should probably influence whether or not Steeltoe registers the ASP.NET Core url with Consul. We should change something here to take that into consideration


Added code for finding maximum number formed from the given array of 2-digit numbers

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Added code for finding maximum number formed from the given array of 2-digit numbers in C++
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Fixes https://github.com/TesseractCoding/NeoAlgo/issues/5000

Thanks for contributing :-)

Please make an issue here and raise a PR, for an article as part of our Docs repository: https://github.com/TesseractCoding/NeoAlgo-Docs
It would be much appreciated. Thanks!

@HarshCasper I didn't understand what you meant . I have to create an issue here and raise a PR ? What should the issue be about?

@HarshCasper I didn't understand what you meant . I have to create an issue here and raise a PR ? What should the issue be about?

Adding the documentation for the Code.


BeamManager.SingletonInstance.TriggerCooldown will not work more than once.

BeamManager.SingletonInstance.TriggerCooldown("joinGame", 3000); will trigger the cooldown the first time. After the cooldown is done, clicking it again will not trigger the cooldown again. In the debug msg, the only error I see is about the etag not matching.

Thank you for filing this bug. We'll investigate.

I have had this same issue, I can confirm.  Clicking it again after the cooldown is up will still trigger the cooldown, but you have to use Beam.Button("Button").RemainingCooldown to check how much time is remaining.
I wonder if this is related to changing groups/scenes only showing once...

We've fixed this issue with the latest release of the plugin, available here:
https://github.com/WatchBeam/interactive-unity-plugin/releases/tag/v0.7.2-beta


How to use Beacon with ASAN?

How do I enable ASAN in Beacon?
I think there are four possible places to set up ASAN:
There is an execution option -asan in Beacon/Ins, but it doesn't seem to have any effect.
Setting the environment variable export USE_AFL_ASAN=1 also doesn't work.
Adding -fsanitize=address to the final compilation environment doesn't work either.
If I add -fsanitize=address during the initial compilation, an error occurs in Beacon/precondInfer.

A potential solution is to create two versions of the bc during the initial compilation. One is for precondInfer, and one is for final compilation.
Or, you can modify the instrumentation code to invoke the related instrumentation from compiler-rt.

Sorry, the -asan option for Beacon/Ins is working. The real reason for the failure was that the static analysis of precondInfer did not find the exact call chain. So when I changed to another target program, I was able to successfully use AddressSanitizer with beacon


SkeletonViewer: Added new display option: spurFollowsChild.

When enabling this option (currently disabled by default) the skinning of the spur is altered so that the far end of the spur (the one that's supposed to meet the child bone) is skinned to the child bone rather than the current bone.
In my retargeting use case where bone positions are set explicitly the current behaviour leads to spurs that float around unattached. This solution will not always show a perfectly shaped spur since it can be deformed by the child bone, but it has the advantage of being very fast while still maintaining a debug view of the skeleton that's not blown up.
Related Playground.
spurFollowsChild disabled (default):

spurFollowsChild enabled:

Something is wrong with the tests :)


Move to 9.0.0-preview.6.24327.7

PR Summary
This pull request includes updates to various project files to upgrade the .NET SDK and several package dependencies to their latest preview versions.
SDK and Package Updates:

DotnetRuntimeMetadata.json: Updated the SDK channel to 9.0.1xx-preview6 and the package version pattern to 9.0.0-preview.6.
global.json: Updated the SDK version to 9.0.100-preview.6.24328.19.

Project File Updates:

src/Microsoft.PowerShell.Commands.Diagnostics/Microsoft.PowerShell.Commands.Diagnostics.csproj: Updated System.Diagnostics.PerformanceCounter to version 9.0.0-preview.6.24327.7.
src/Microsoft.PowerShell.Commands.Management/Microsoft.PowerShell.Commands.Management.csproj: Updated System.ServiceProcess.ServiceController to version 9.0.0-preview.6.24327.7.
src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj: Updated System.Threading.AccessControl and System.Drawing.Common to version 9.0.0-preview.6.24327.7.
src/Microsoft.PowerShell.CoreCLR.Eventing/Microsoft.PowerShell.CoreCLR.Eventing.csproj: Updated System.Diagnostics.EventLog to version 9.0.0-preview.6.24327.7.
src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj: Updated multiple packages including System.IO.Packaging, System.Net.Http.WinHttpHandler, and System.Text.Encodings.Web to version 9.0.0-preview.6.24327.7.
src/Microsoft.WSMan.Management/Microsoft.WSMan.Management.csproj: Updated System.ServiceProcess.ServiceController to version 9.0.0-preview.6.24327.7.
src/System.Management.Automation/System.Management.Automation.csproj: Updated multiple packages including Microsoft.Win32.Registry.AccessControl, System.Configuration.ConfigurationManager, and System.Diagnostics.DiagnosticSource to version 9.0.0-preview.6.24327.7.

PR Context

PR Checklist

[ ] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ ] Summarized changes
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[ ] Documentation needed
- [ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).


Custom json encoder for bytes yields infinite loop

Hi,
I'm trying to use Base64 encoding for the custom json encoding of bytes, but that results in an infinite loop eating up all my RAM. Am I overlooking something? What's the solution?
Here's a post that illustrates the exact same problem I have: https://www.gitmemory.com/issue/samuelcolvin/pydantic/863/538754238

I am not aware of your usecase here, I use bytes in a similar way (Base64 encoding while converting to JSON). You can convert the bytes object into an array of bytes or a string which are both JSON compatible
To convert into an array of bytes. I personally use this.
json_encoders = {
    bytes: lambda v: list(base64.b64encode(v))
}

To convert into a UTF-8 string.
json_encoders = {
    bytes: lambda v: base64.b64encode(v).decode()
}

Note that with this, you will have to write a custom validator to deserialize the converted JSON to the Model.
Please feel free to correct me if I wrong in understanding your problem.

Thanks @shashankrnr32, I just now had time to check out your solution approach for encoding bytes and it works. Thanks for that! How would you go about writing such a custom validator to deserialize the converted JSON to the Model?
I'm trying to think of a way with a root validator that applies to all models (on the BaseModel level) and checks whether or not a field is of type List[bytes] and go from there, but that already doesn't seem to work. Any hint would be greatly appreciated.
Also: is there a plan to fix that issue with the infinite loop?
My use case is that I am implementing a communication protocol with lots of different messages that adhere to a certain XSD schema. Some of those message fields are of type bytes.

Since we now have the Base64Str and Base64Bytes, I'll close this.
See Base64 encoding support for more details.


How to disable 0 RPM mode

Hello I am a 7900XT user. I can not control the fan curve with LACT. Fan Speed always shows 0 RPM. Is there a work around for this ? Thanks.

Fan control is not currently supported on stable kernel versions on RDNA3. You'll have to wait until Linux 6.7.

I have installed Linux mainline kernel 6.7 and it is still not working.

Looks like it's a bit more complicated than just requiring a 6.7 kernel, it also doesn't support custom fan speed on the hardware level, and instead uses a new interface for custom fan curves: https://gitlab.freedesktop.org/drm/amd/-/issues/2402
Could you post the output of cat /sys/class/drm/card*/device/gpu_od/fan_ctrl/*

cat: '/sys/class/drm/card*/device/gpu_od/fan_ctrl/*': No such file or directory

I have a 7800 xt and same thing, using the linux-mainline kernel
OD_ACOUSTIC_LIMIT:
2450
OD_RANGE:
ACOUSTIC_LIMIT: 500 3100
OD_ACOUSTIC_TARGET:
2200
OD_RANGE:
ACOUSTIC_TARGET: 500 3100
OD_FAN_CURVE:
0: 0C 0%
1: 0C 0%
2: 0C 0%
3: 0C 0%
4: 0C 0%
OD_RANGE:
FAN_CURVE(hotspot temp): 25C 100C
FAN_CURVE(fan speed): 20% 100%
FAN_MINIMUM_PWM:
20
OD_RANGE:
MINIMUM_PWM: 20 100
FAN_TARGET_TEMPERATURE:
95
OD_RANGE:
TARGET_TEMPERATURE: 25 110

I've added support for configuring the new settings of the automatic fan curve (target temperature, minimum fan speed and target/limit speed). Support for full-fledged custom fan curves will be added later.

Setting custom curves is also supported now.

Closing as the relevant functionality has been added.


Items that can be spared from the state

If I find a ResultItem
case class ResultItem(
  segmentDocBase: Int, segmentDocId: Int, docIndex: Int,
  label: String, name: String,
  odinsonMatch: OdinsonMatch
)

which has no name or label, do I need to put it into the state?  If it has neither, but the odinsonMatch has a namedCapture
case class NamedCapture(name: String, label: Option[String], capturedMatch: OdinsonMatch)

that does have a name or label, do I need to put the whole tree in?  While running the tests I see quite a few things going into the State which might not be retrievable and it could save time to ignore them.

These are great questions that we should discuss.

If I find a ResultItem ... which has no name or label, do I need to put it into the state?

If there is no label or name, I'd say no.  We have no way to retrieve them.
Re:

If it has neither, but the odinsonMatch has a namedCapture ... that does have a name or label, do I need to put the whole tree in?

I think you'd only put ONLY the named capture into the state, since the outer structure doesn't have a name etc.
@marcovzla thoughts?

I don't think we can have a top level mention without a label, because the label has to be specified in the rule.
For example:
  - name: rule_1
    label: Person
    pattern: |
      Keith

then the mention has to be labeled according to the label provided in the rule.
The same is true for event mentions:
  - name: rule_2
    label: Code
    pattern: |
      trigger = [lemma=code]
      programmer: Person = >nsubj

the event must have the label Code.
There is another entrypoint in ExtractorEngine for executing an arbitrary pattern (not a rule).
I believe those shouldn't go into the state, because they are meant to be used interactively and the results should be displayed in a UI. If for some reason the user likes the results and wants to store them in a state then that could be a second step and the user should specify a label at that point.
However, I can think of one exception. We support the following rule syntax:
  - name: rule_3
    label: Code
    pattern: |
      trigger = [lemma=code]
      programmer = >nsubj [tag=NNP]

which would create a mention on the fly for the programmer argument, and that mention wouldn't have a label (note the argument doesn't have a label like the one above).
I think that mention should go into the state. It is true that we can't retrieve it directly because it has no label, however, when we retrieve the event mention that contains it, the unlabeled mention should still be included as an argument.

If the event mention that contains it gets sent to the state, I do include all its children so that it can be reconstituted correctly.  However, I also look at the children separately to see if they need to be added to the state as separate top-level values that can be searched for.  I don't know if that is necessary.  BTW for those without a label, it is entered as "", so that could be used to find them.

is it only necessary to add the children when they have promote == true?


CreditCardValidations.add_brand not working in rails c

Hi, awesome gem!
I'm trying to create my own credit card validation in rails console
> CreditCardValidations.add_brand(:oca, { length: 16, prefixes: '589' })
 => :oca?
> test_card_number = '589826275400212'
> CreditCardValidations::Detector.new(test_card_number).brand
 => nil
> CreditCardValidations::Detector.new(test_card_number).oca?
 => false

I'm planning to use it in an initializer, but I can't get it work.
I'm using ruby '2.3.1' and

gem 'credit_card_validations', '~> 3.2.2'
gem 'rails', '4.2.6'

Thanks

@Alxzu , length of your card is 15, but rules you described is for 16.
 '589826275400212'.length
 => 15

but
CreditCardValidations.add_brand(:oca, { length: 16, prefixes: '589' })

Also if you need skip luhn check, try
2.2.0 :015 >  CreditCardValidations.add_brand(:oca, { length: 16, prefixes: '589' }, {skip_luhn: true})
 => nil
2.2.0 :016 > test_card_number = '5898262754002121'
 => "5898262754002121"
2.2.0 :018 > CreditCardValidations::Detector.new(test_card_number).brand
 => :oca

Hi, thanks for your reply, I fixed my problem deleting :maestro card before creating my new credit card validation, which prefix is '58'

@Alxzu , 👍


UV Hydro Corrections Parsing Tests

Coverage increased (+0.03%) to 97.455% when pulling 8080f0d6a9d0c1da400da763ddde43257daf18d8 on zmoore-usgs:feature/test-uv-corrections into 7224aae083a45a148e636025e231bba5b6b6a46e on USGS-R:master.

Coverage increased (+0.03%) to 97.455% when pulling 8080f0d6a9d0c1da400da763ddde43257daf18d8 on zmoore-usgs:feature/test-uv-corrections into 7224aae083a45a148e636025e231bba5b6b6a46e on USGS-R:master.

Coverage increased (+0.03%) to 97.455% when pulling cf398776d4876b23a26da106eb8a1915d2282e21 on zmoore-usgs:feature/test-uv-corrections into 7224aae083a45a148e636025e231bba5b6b6a46e on USGS-R:master.


zip: fix forward declaration errors with clang

Description of changes
Fixes #313300

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

5001+ rebuilds on Linux, 2501-5000 on Darwin. Should this go through staging?

Yes.

Top-level zip and LLVM zip builds successfully in CI and on my machine, doesn't change anything that affects other packages. LGTM.


prepare MEME file from Homer output

HI,
Can Homer output from "findMotifsGenome.pl" (http://homer.ucsd.edu/homer/ngs/peakMotifs.html) be used to run infereletor prior?
Thanks,
Poorva

If you run the inferelator-prior pipeline using --scan HOMER it will use HOMER to search for motifs. There is no convenient way to use the existing results of a FIMO or HOMER search.

Thank you for responding so promptly. I can sure use --scan HOMER option, but what file format is needed to run 'python -m inferelator_prior.network_from_motifs --scan HOMER'?
link - http://homer.ucsd.edu/homer/ngs/formats.html

HI,
Thank you for your comments on using --motif_format homer but this isnt helping. See below
The format of homer motif file is here "http://homer.ucsd.edu/homer/ngs/formats.html", go to "Motif files"
COMMAND LINE - "python -m inferelator_prior.network_from_motifs -m peaks/knownResults/known1.motif --scan HOMER --motif_format homer -f GRCm38.primary_assembly.genome.fa -g gencode.vM25.primary_assembly.annotation.gtf --species mouse  -c 10 -o $output"
Loading genes from file (gencode.vM25.primary_assembly.annotation.gtf)
55487 genes loaded
Promoter regions defined with window (50000, 2000) around TSS
Loading motifs from file (peaks/knownResults/known1.motif)
1 motifs loaded
Scanning target chromatin (None) for motifs (peaks/knownResults/known1.motif)
Traceback (most recent call last):
File ".../opt/anaconda3/envs/py36/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File ".../opt/anaconda3/envs/py36/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File ".../inferelator-prior/inferelator_prior/network_from_motifs.py", line 482, in
main()
File ".../inferelator-prior/inferelator_prior/network_from_motifs.py", line 63, in main
save_locs_filtered=args.save_locs_filtered)
File ".../inferelator-prior/inferelator_prior/network_from_motifs.py", line 285, in build_motif_prior_from_genes
save_locs_filtered=save_locs_filtered, num_cores=num_cores)
File ".../inferelator-prior/inferelator_prior/network_from_motifs.py", line 460, in scan_and_build_by_tf
prior_matrix = pd.concat(prior_matrix, axis=1)
File ".../opt/anaconda3/envs/py36/lib/python3.6/site-packages/pandas/core/reshape/concat.py", line 284, in concat
sort=sort,
File ".../opt/anaconda3/envs/py36/lib/python3.6/site-packages/pandas/core/reshape/concat.py", line 331, in init
raise ValueError("No objects to concatenate")
ValueError: No objects to concatenate


test-nunit fails to discover tests when a particular dependency is added

There seems to be an issue that causes test-nunit to fail to discover tests when "Microsoft.AspNetCore.Mvc": "1.1.0" is added to the test project either directly or via another project reference.
Interestingly, removing the dependency to "Microsoft.AspNetCore.Mvc": "1.1.0" or simply lowering the version ("Microsoft.AspNetCore.Mvc": "1.0.2") allows my tests to be discovered.
Here is my project.json:
{
  "version": "1.0.0-*",

  "dependencies": {
    "NUnit": "3.6.0",
    "NUnit3TestAdapter": "3.6.0",
    "dotnet-test-nunit": "3.4.0-beta-3",
    "Moq": "4.6.38-alpha",
    "Microsoft.AspNetCore.Mvc": "1.1.0"
  },

  "testRunner": "nunit",

  "frameworks": {
    "netcoreapp1.1": {
      "dependencies": {
        "Microsoft.NETCore.App": {
          "version": "1.1.0",
          "type": "platform"
        }
      }
    }
  }
}

The error I get when I build and "Run All" tests is this:

------ Discover test started ------
NUnit Adapter <IP_ADDRESS>: Test discovery starting
Error: Unable to get runner for this assembly. Check installation, including any extensions.
FileNotFoundException: Could not load file or assembly 'nunit.framework' or one of its dependencies. The system cannot find the file specified.
Dependent Assembly nunit.framework of D:\project\bin\Debug\netcoreapp1.1\Project.Tests.dll not found. Can be ignored if not a NUnit project.
NUnit Adapter <IP_ADDRESS>: Test discovery complete
========== Discover test finished: 0 found (0:00:00.1140183) ==========
------ Discover test started ------
Discovering tests in 'D:\project\Project.Tests\project.json' ["C:\Program Files\dotnet\dotnet.exe" test "D:\project\Project.Tests\project.json" --output "D:\project\Project.Tests\bin\Debug\netcoreapp1.1" --port 15591 --parentProcessId 206184 --no-build]
'test-nunit' returned '-2'.
========== Discover test finished: 0 found (0:00:00.823869) ==========

'test-nunit' returned '-2'. resolves to INVALID_ASSEMBLY.

FYI, this likely won't be fixed because Microsoft is dropping support for the dotnet-test-* style adapters, so this project will be deprecated soon.
As a workaround, does the dotnet test command work?

Hi @rprouse, thanks for your help.
I didn't realise they were dropping support for the adapters, does this mean that NUnit will no longer support/work with .NET Core?
dotnet test does appear to discover the tests but fails elsewhere

NUnit .NET Core Runner 3.4.0
Copyright (C) 2016 Charlie Poole
Could not load file or assembly 'Microsoft.DotNet.InternalAbstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.
SUMMARY: Total: 1 targets, Passed: 0, Failed: 1.

@Robula NUnit will support .NET Core again, it will just take us a bit of time to play catch-up and add in support in our other adapter 😄
As for your error, I need to look at it more closely, but my guess is that you are directly or indirectly using a different version of Microsoft.DotNet.InternalAbstractions than the adapter is. Unfortunately, .NET Core does not have support for AppDomains, so we cannot isolate your tests from the adapter code in a separate AppDomain like we do in desktop.

Thanks @rprouse, you've been most helpful! I'll look forward to the full .NET Core support, in the meantime I'll fall back to MSTest for any new .NET Core projects.

It stumbled across a blog post where xUnit is having the same problem with Microsoft.DotNet.InternalAbstractions. MSTest probably has the same issue. I haven't tested the fix yet, but I would appreciate feedback if it works.
The blog post is http://ardalis.com/xunit-test-discovery-error-with-aspnet-core-1-1
The fix is to explicitly add Microsoft.DotNet.InternalAbstractions version 1.0.0 as a dependency to your project.json

We had the same problem here. And yes, MSTest has the same issue.
Above fix worked for us.

Thanks for confirming the fix.


Add /preprints/ to preprint route

Purpose
Scholar wants /preprint/ in the url before each preprint in the sitemap

Changes
adds /preprint/ before preprints

Side effects
NA

Ticket
https://openscience.atlassian.net/browse/OSF-7964

@brianjgeiger Ah good catch. That does make this more complicated.

@brianjgeiger

Closing in favor of https://github.com/CenterForOpenScience/osf.io/pull/7305


Address a couple of questions

While porting http-203 example by Geoff I come across a couple of questions regarding the behavior.

Should the library automatically wrap on, off and classes in an afterNavigate...I can't seem to find a reason to not do that given that you will want the listener/classes to be called again even if the navigation is towards the same page but maybe it's best to let the user do it to accomodate for something that I can't think of where you want a listener to only be added the first navigation?
Should the add class listener be prioritized over the other listeners? This would allow the listeners to check for a specific class in the root element to know which kind of navigation is happening but there are other ways around this. Might still be smart to prioritize them tho.

I've come to the conclusion that

The library will indeed wrap the functions in afterNavigate automatically, providing a second parameter to prevent this behavior in case someone finds a use case for it. This is technically a breaking change but we are pre 1.0 and I don't think someone is actually using this except me so it's probably fine.
I will not order the listeners, it provides little value especially because it's far better to base your decision on the navigation object.


add Western New England University domain

Western New England University official website: https://wne.edu/
Bachelor of Science in Computer Science Program: https://wne.edu/academics/undergraduate/computer-science.cfm

@argel6767 Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


[TextServer] Fix build with disabled graphite.

Fixes https://github.com/godotengine/godot/issues/67584

Thanks!


Provide option to enabled DEBUG level logging when using the CLI

As discussed in https://github.com/elastic/elasticsearch/issues/94773 it would be helpful to be able to opt into more verbose logging when using the CLI, in addition to the existing option for the build tool plugins.

See the new PR #227.
I am doing some testing, but it restores previous functionality if you start the CLI tool with --debug command line option. There are only slight changes:

Prefix of message is "DEBUG".
Message comes on stdout, not stderr (as it is now <=INFO).
The suffix of message was removed ("please fix classpath").

In Opensearch this would need to be then adapted: https://github.com/opensearch-project/OpenSearch/blob/b1cf2d144ebac899bcae9880ee51728df397b5c0/buildSrc/src/main/java/org/opensearch/gradle/precommit/ThirdPartyAuditTask.java#L82-L84
In Elasticserach should be same.

Does anybody has an idea why the forbiddenapis JAR is mentioned 3 times in dependencies. Most crazy was that it is also part of Java source code!?! @reta

@uschindler I do not know the history but here are my guesses:

ThirdPartyAuditPrecommitPlugin needs the forbiddenApis so it adds all the time
the buildSrc uses forbiddenApis directly (since it cannot use ThirdPartyAuditPrecommitPlugin as it builds it)
for buildSrc/src/testKit/thirdPartyAudit/build.gradle, I think it not needed (should be provided by ThirdPartyAuditPrecommitPlugin)

@uschindler I do not know the history but here are my guesses:

ThirdPartyAuditPrecommitPlugin needs the forbiddenApis so it adds all the time

That's the craziest to me. I am fine with it, but the version number should not be hardcoded there, maybe it should be a global property (like Lucene uses, it has all helper versions in a map on project.ext.

the buildSrc uses forbiddenApis directly (since it cannot use ThirdPartyAuditPrecommitPlugin as it builds it)

This is to execute the standard plugin-provided forbiddenApis (gradlew forbiddenApis).

for buildSrc/src/testKit/thirdPartyAudit/build.gradle, I think it is not needed (should be provided by ThirdPartyAuditPrecommitPlugin)

I can try to remove that one, I had the same idea.

Does anybody has an idea why the forbiddenapis JAR is mentioned 3 times in dependencies. Most crazy was that it is also part of Java source code!?! @reta

The main two are as @reta mentiones. First the plugin adds it as a default dependency and also by the build logic itself. It could read this from the same place used by the build in theory so this isn't duplicated.

Release is coming later today.

Release 3.5.1 is on plugin portal, Maven takes a bit longer. I will update the Opensearch PR once its on all repos.

Release 3.5.1 is on plugin portal, Maven takes a bit longer. I will update the Opensearch PR once its on all repos.

Thanks a lot @uschindler !

Thanks @uschindler!


Upgrade devcontainer javascript-node:0-16 from node v16.14.2 to v16.15.1 (lts)

Upgrade dev container javascript-node:0-16 (and variants) to ship node v16.15.1 lts.
The dev container javascript-node:0-16(-bullseye) now ships node v16.14.2, although the current long-term support version of Node.js is v16.15.1 (which is shipped with the official image node:16 from dockerhub):
$ docker run --rm mcr.microsoft.com/vscode/devcontainers/javascript-node:0-16 node --version
==> v16.14.2
$ docker run --rm node:16 node --version
==> v16.15.1

Note: Upgrading to Node.js v16.15.1 would also solve a nasty problem that may happen when developing in a javascript-node:0-16 container and using node:16 as runtime container. Due to an incompatibility issue between npm 8.5.0 and npm 8.11.0, npm ci may fail on npm 8.11.0 if package-lock.json was created by npm 8.5.0. (see https://github.com/npm/cli/issues/4998 for details).
Relates to: <Remote - Containers>

We have just recently pushed a new release, which rebuilt this image. Re-pulling the image should do the trick :)


Incubate persistent data structures

This work-in-progress draft PR kicks the tires for incubating persistent data structures into the swift-collections project.
A long-term goal of this effort is to mature persistent replacements for the general-purpose data structures already present in the Swift Standard Library (i.e., Array, Set and Dictionary).
Currently, the PR covers the HashMap<Key: Hashable, Value> data type, which is supposed to become a persistent drop-in replacement for Swift's Dictionary. The draft implementation is neither feature complete nor performance optimized yet, but aims to create visibility for this effort and to elicit early feedback. Working title for the module is Capsule, based on prior work.
HashMap<Key: Hashable, Value> implements the Compressed Hash-Array Mapped Prefix-tree (CHAMP) data structure. The implementation is inspired by previous JVM data structures that I've authored in the past, amongst them:

Scala's HashMap and HashSet (Scala; default in standard library since Scala 2.13)
The Capsule Hash Trie Collections Library (Java; standalone library)

Feel free to provide feedback on idiomatic Swift usage and Swift-specific performance optimization tips and tricks, if and where appropriate.
References and Further Readings
Publications

PhD Thesis: Efficient Immutable Collections (2017)
Paper: Optimizing Hash-Array Mapped Tries for Fast and Lean Immutable JVM Collections (OOPSLA 2015)
Paper: To-Many or To-One? All-in-One! Efficient Purely Functional Multi-maps with Type-Heterogeneous Hash-Tries (PLDI 2018)

Talks

JVM Language Summit 2016 - Efficient and Expressive Immutable Collections (Speaker: Michael Steindorfer)
JVM Language Summit 2017 - Lightweight Relations (Speaker: Michael Steindorfer)

Checklist

[x] I've read the Contribution Guidelines
[x] My contributions are licensed under the Swift license.
[ ] I've followed the coding style of the rest of the project.
[ ] I've added tests covering all new code paths my change adds to the project (if appropriate).
[ ] I've added benchmarks covering new functionality (if appropriate).
[x] I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
[ ] I've updated the documentation if necessary.

This is exciting work. I think these would be a great fit for this package, and I'm personally very much interested in getting these landed (& eventually added to the stdlib). We'll need to figure out how to test & benchmark these, and carefully evaluate API decisions. I think there is a bunch of interesting low-level optimization work we can do on the internal representations (things like replacing Array<Any> storage with tail-allocated typed buffers).
(I think it may make sense to open an official feature branch for this project. I'll ponder how best to coordinate work, and I'll see about scheduling resources for getting this done.)

Hi @lorentey, great that we share the same interest and vision regarding this effort.

(I think it may make sense to open an official feature branch for this project. I'll ponder how best to coordinate work, and I'll see about scheduling resources for getting this done.)

An official feature branch sounds good to me. Keep me up to date on how we should progress incubating the persistent collections.
(The draft PR was a suggestion by @kylemacomber and was actually a good thing for getting the draft implementation out and creating momentum. Though it may not be ideal acting as a long running feature branch.)

We'll need to figure out how to test & benchmark these, and carefully evaluate API decisions.

Sure. I plan to add more test coverage (and eventually benchmarks) for the persistent data structures along the way.
I didn't investigate the state of the conformance checkers in swift-collections yet, but having good coverage for Dictionary, Set, Array and entailed protocols would help a lot.
I'll also reach out to discuss API decisions and idiomatic Swift usage when time is due, but first I'll work on dialing in the data structure design (e.g., what concepts translate best to Swift) and feature completeness.

I think there is a bunch of interesting low-level optimization work we can do on the internal representations

The same goes for low-level optimizations. I'm looking forward to tackle those as well, but first the data structure design needs to settle. Feel free to make suggestions anytime if you happen to notice something.

things like replacing Array storage with tail-allocated typed buffers

The Array<Any> store disguises a lot of complexity, since its content is type-heterogeneous, akin to several (differently) typed buffers concatenated (therefore elements are currently typed as Any).
Can you provide me some references on what you had in mind? I will then have a look at it.

@lorentey @msteindorfer is there anything we in The Community can do to help get this along?

@kielgillard, this contribution will be actively worked on to be readied for inclusion. Stay tuned.

I'm landing this on a feature branch to start integration & performance work. 💯


expose migration region

This PR depends on some other pending PRs so I'll leave it as a draft, however it would be good to get some initial feedback.
Also, need to implement unit tests.

I think configuring migration has started to become a bit cumbersome: the user needs to create the migration region (vfu_setup_region) making sure the size is correct (by calling the newly-added vfu_get_migr_regs_size) and then configure it via vfu_setup_device_migration_callbacks. I think it still makes sense to add another function that combines all these (allocating the migration region memory if it's to be sparse mmaped) for the benefit of simpler implementations.

I don't agree that we want a new function that literally is adding a region, plus other stuff. It's more confusing to me to have it look like it's something new/different when it isn't.

I don't agree that we want a new function that literally is adding a region, plus other stuff. It's more confusing to me to have it look like it's something new/different when it isn't.

Fair enough.

All the commits will be squashed since they're very relevant, I've put them separately to make reviewing easier.

@jlevon fixed typo and replied to your comment regarding implicitly making the migration region mappable, please take another look.

@jlevon fixed, please take another look.

I'm not seeing changes for my review comments

I'm not seeing changes for my review comments

I somehow missed some of them, let me take a look.

@jlevon addressed your comments.

@jlevon your changes don't appear in the commit on master, we're good.


[FEATURE] check and checkAsync can accept message (string) in return

I'm using the checkAsync method with an API call to valid my phone data
Instead of only being able to return a boolean, it would be great to be able to return a string that would serve as an error message.
If a string is returned, then the validation will fail and override the default message.
My API gives me an error message that I would like to use easily.
Example :
const validation = {
  rule: pipeAsync(
    object({
      dialCode: pipe(string(), nonEmpty('Dial code is required'), decimal('Dial code should be a number')),
      phoneNumber: pipe(string(), nonEmpty('Phone number is required')),
      countryCode: optional(string()),
    }),
    checkAsync(
      async (phoneData) => {
         const response = await fetch('...', { body: phoneData })

         if (response.success === false) {
           return response.message // <--- ERROR MESSAGE
         }

         return true
      },
      'Default message',
    ),
  ),
}

I recommend using rawCheckAsync in this case:
import * as v from 'valibot';

const Schema = v.pipeAsync(
  v.object({
    dialCode: v.pipe(
      v.string(),
      v.nonEmpty('Dial code is required'),
      v.decimal('Dial code should be a number')
    ),
    phoneNumber: v.pipe(v.string(), v.nonEmpty('Phone number is required')),
    countryCode: v.optional(v.string()),
  }),
  v.rawCheckAsync(async ({ dataset, addIssue }) => {
    if (dataset.typed) {
      const response = await fetch('...', { body: dataset.value });
      if (!response.ok) {
        addIssue({ message: await response.text() });
      }
    }
  })
);

I gonna test it, thanks for your answer and your work!


📚 Documentation: Add Version Navigation Table and Improve Content Structure

Documentation Enhancement: Improved Navigation & Accessibility
🎯 Purpose
This PR aims to enhance the developer and user experience by implementing systematic improvements to our documentation structure, navigation, and content presentation.
🔍 Key Improvements
1. Migration Notes Enhancement (docs/docs/migration_notes.md)

✨ Added structured Table of Contents with 29 versions
📊 Implemented 3-column layout for efficient version navigation
🔗 Added clickable anchors for each version
📱 Improved mobile responsiveness
🎯 Makes version migration paths clearer for developers

2. Video Documentation Optimization (docs/docs/aztec.md)

🎥 Enhanced video presentation format
📝 Added contextual descriptions for each video section
🔄 Simplified video embedding structure
⚡ Improved page load performance by using thumbnails
👁 Better visual hierarchy

3. Infrastructure Documentation (spartan/README.md)

📚 Improved heading hierarchy
🔧 Fixed technical terminology ("eksctl")
📋 Enhanced readability

4. Development Environment (contributing.md, .vscode/extensions.json)

🔗 Implemented absolute URLs for better reliability
🛠 Fixed JSON syntax
📦 Ensured consistent formatting

💡 Benefits

Faster Navigation: Developers can quickly find relevant version migrations
Better Accessibility: Improved structure and formatting
Reduced Cognitive Load: Clear organization of complex information
Enhanced Maintainability: Consistent documentation structure

✅ Testing Completed

Verified all 29 version links in migration notes
Tested documentation rendering on both desktop and mobile
Confirmed all external links functionality
Validated JSON syntax
Checked markdown formatting across different viewers

🔍 Self-Review Checklist

[x] Documentation follows project style guide
[x] All links are functional
[x] No broken anchors
[x] Consistent formatting
[x] Mobile-responsive
[x] No content was removed or altered
[x] Spell-checked all changes

🤝 Contribution Value
These improvements directly support our team's efficiency by:

Reducing time spent searching for migration information
Providing clear, accessible documentation structure
Supporting new developer onboarding
Maintaining high documentation standards

Hi. The description is spammy, closing.


Bhai kab tak update milega

Kab tak downloading issues solve hoga

As i have mentioned earlier there isn't any issue in downloading.
It depends upon your Download Manager where it saves the file.
Try checking the video through your downloads manager.

Bhai sab phone ke sath ho raha hai mene khud oppo Vivo redmi samsung sab me
cheak kr liye
Video download ho raha hai but file me kahi nhi mil raha
On Wed, 5 Oct, 2022, 11:33 am Prateek Chaubey, @.***>
wrote:

As i have mentioned earlier there isn't any issue in downloading.
It depends upon your Download Manager where it saves the file.
Try checking the video through your downloads manager.
—
Reply to this email directly, view it on GitHub
https://github.com/prateek-chaubey/YTPro/issues/5#issuecomment-1267981581,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A25AA33PHWXTPO42HP74KH3WBUK4BANCNFSM6AAAAAAQ5FORYU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Can you record a video showing the steps you have tried.
It will be very helpful in fixing the issue.

Ok. Bro

Bhai mene video bana diya https://youtu.be/DZCypwOHKmQ

The video that you have downloaded can be found in this app. Whereas I shall be improving the Downloads Feature in next update

Downloads app mi ka hai or mere phone realme Narzo 20 pro hai  mere phone me ye downloads app ka package mach ho raha hai  or install nhi ho ra

Bhai yrr download video file me nhi aa raha  yrr solv kr do ya website prefer kr do jis ki kisi website pe ja ke download ho sake

Hii

Plz I need Instagram hack command

@prateek-chaubey hii I need Instagram hack command


[Snackbar] Accessibility - Keyboard focus should move to the Snackbar when it opens

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When you activate a snackbar toast and the contents of the toast are announced to the user, the focus should also move to the toast. It seems like the focus is lost at the moment / it is unclear where exactly the keyboard focus is when the toast first opens. When the toast is closed, focus should return to the original element that opened the toast (if it is still present on the page).
Expected Behavior 🤔

When you activate a snackbar toast and the contents of the toast are announced to the user, the focus should also move to the first interact-able element of the toast (like the action or close buttons). When you close the toast, focus should return back to the element that opened the toast.
While there are no specific aria guidelines for toasts, a modal dialog is probably the closest example:
https://www.w3.org/TR/wai-aria-practices-1.1/examples/dialog-modal/alertdialog.html
We've also been given this feedback from our users.
Steps to Reproduce 🕹

Steps:

Open up https://material-ui.com/components/snackbars/#simple-snackbars (Turn on VoiceOver screenreader if you want to hear announcements)
Using keyboard only, navigate to "Open Simple Snackbar" button and activate it with space or enter keys.
Although the contents of the toast are announced if you have your screenreader turned on, it is unclear where the keyboard focus is currently.
Hitting the tab key will bring you to the first focusable element of the toast.

Context 🔦

Our keyboard-only users expect to be able to keep track of focus as they interact with elements that fire toasts.
Your Environment 🌎

Tech
Version

Material-UI
Latest as per docs

MacOS
Catalina 10.15.6

Browser
Chrome Version 84.0.4147.135 (Official Build) (64-bit)

We should be very careful with making this the default behavior. For UIs using the snackbar for notifications (possible displaying multiple) you don't want the Snackbar to steal focus.
I don't think Snackbar should be used as an alertdialog due to their positioning.
In the case of the Snackbar with an undo action it's probably better to add a keyboard shortcut. Otherwise it might be disruptive if you trigger an action and every time the focus is moved to an option "undo" element.
So there's a lot of nuance to this component. We didn't do a good job making it accessible by default especially due to the poor naming and customization points without oversight.
Some brainstorming on how to recommend better a11y (without having looked into prior art for accessible notifications/undo popups):

don't move focus if action is provided but provide some helper method that creates accessible actions (with shortcuts)
~add option to move focus~
I'm not convinced yet that we need it. A concrete example of a Snackbar where this should happend would help deciding what to do about it.
Due to its position portaling it seems ideal. Sequential focus order should follow the visual order so it would be disorienting if it would appear at the bottom visually but in the middle of the main content in tab order.

We should be very careful with making this the default behavior. For UIs using the snackbar for notifications (possible displaying multiple) you don't want the Snackbar to steal focus.

I didn't think of a scenario where Snackbar was used for notifications, I see your point. However, in the case of Snackbar appearing after a user interaction, I think focus moving to the Snackbar could still be a valid scenario.
Even if we decide not to implement moving the focus to the Snackbar when it's been opened, in any case there should probably be better visual indications of where the focus is after closing a Snackbar (on https://material-ui.com/components/snackbars/#simple-snackbars, after you close the Snackbar you have no visual indicators as to where your focus is - it seems like focus is lost when the Snackbar is removed from the DOM).

I don't think Snackbar should be used as an alertdialog due to their positioning.

Any chance you could expand on this? Our use case would be one such as showing an alert dialog as a toaster after a user interaction (say, clicking a button to submit a form and having a dismissible "Success!" toaster appear on screen).

In the case of the Snackbar with an undo action it's probably better to add a keyboard shortcut. Otherwise it might be disruptive if you trigger an action and every time the focus is moved to an option "undo" element.

I agree, maybe my ask for the focus should move automatically to the "X" button of the snackbar instead of the first interact-able element.

Some brainstorming on how to recommend better a11y (without having looked into prior art for accessible notifications/undo popups):

don't move focus if action is provided but provide some helper method that creates accessible actions (with shortcuts)

It's late in the day for me so you'll have to forgive me for not following this one 😂  - how would this work from a user perspective?

~add option to move focus~
I'm not convinced yet that we need it. A concrete example of a Snackbar where this should happend would help deciding what to do about it.
Due to its position portaling it seems ideal. Sequential focus order should follow the visual order so it would be disorienting if it would appear at the bottom visually but in the middle of the main content in tab order.

Portaling, if I understand correctly, would render the toaster in a different area of the DOM like in https://material-ui.com/components/portal/ - that seems reasonable but in that case I would definitely want to see focus moved to the toaster after a user interaction - otherwise I'm wondering would a keyboard-only/screenreader user have a hard time "finding" the snackbar on the page?
@eps1lon I really appreciate your thoroughness on this! A11y is so subjective - it's hard to know exactly what the right approach is.

Any chance you could expand on this? Our use case would be one such as showing an alert dialog as a toaster after a user interaction (say, clicking a button to submit a form and having a dismissible "Success!" toaster appear on screen).

That's not an alertdialog as it's defined in the ARIA authoring practices:

An alert dialog is a modal dialog that interrupts the user's workflow to communicate an important message and acquire a response.

-- https://www.w3.org/TR/wai-aria-practices-1.1/#alertdialog
ARIA is not as clear. A snackbar can definitely act as an alertdialog where you want the user to confirm but I don't believe this is the best UI for this type of notification due to its placement. Using it as an alertdialog is actually less accessible for sighted users I'd say.

it's hard to know exactly what the right approach is.

Definitely. It's why having concrete examples is so important when filing issues. It also reveals problems with a component if it can be used for too many UI patterns. Then it fails to provide real value to developers if they have to customize it before it actually works.
We already improved in that area by implementing a standalone Alert.

However, in the case of Snackbar appearing after a user interaction, I think focus moving to the Snackbar could still be a valid scenario.

At the top of my had I can't recall any toast-like element that should steal focus. A popular use case where you have it as a confirmation with an action to undo can be accessible by providing a different shortcut to undo e.g CTRL + Z which acts like onClick on the undo action. ESC would act like onClick for the dismiss button. The problem with focus stealing is that it is interrupting the workflow and you should have a strong reason for doing so. A confirmation message does not fall into that category in my opinion.

It's late in the day for me so you'll have to forgive me for not following this one joy - how would this work from a user perspective?

Basically something like <Snackbar action={<ShortcutButton shortcut="CTRL+Z" onClick={handleClick} />} . ShortcutButton would not be in sequential focus order but register a global keydown listener for CTRL + Z that calls handleClick.

It's probably worth revisiting what the Snackbar's intended use is:
https://material.io/components/snackbars#usage
When to use
Snackbars communicate messages that are minimally interruptive and don’t require user action. Component Priority User action Snackbar Low priority Optional: Snackbars disappear automatically Banner Prominent,...
Snackbars communicate messages that are minimally interruptive and don’t require user action.

Component
Priority
User action

Snackbar
Low priority
Optional: Snackbars disappear automatically

Banner
Prominent, medium priority
Optional: Banners remain until dismissed by the user, or if the state that caused the banner is resolved

Dialog
Highest priority
Required: Dialogs block app usage until the user takes a dialog action or exits the dialog (if available)

Thanks @mbrookes @eps1lon that all makes sense - I think Snackbar is the appropriate component for our "success" message use case but you're right, it doesn't need to get focus automatically because it doesn't require interaction from the user.
The only thing we would need to clarify is what should happen to the focus if a user does manage to keyboard-navigate to the snackbar and close it before it fades away. At the moment, the focus disappears. Can raise a separate issue for that and close this one if need be?

@mbrookes So it would support the idea that the Snackbar should be portal, so it can't be reached with Tab?
To be fair, I believe that most applications use the Snackbar with a global dispatch system anyway (e.g. redux). So in practice, the Snackbar is most likely not reachable with Tab unless reaching the end (most likely) or the beginning of the page (depending on how it was set up). I have been advocating for something similar in https://github.com/mui-org/material-ui/issues/21053#issuecomment-630119128.
Regarding:

Keyboard focus should move to the Snackbar when it opens

Should it be deferred to the userland? Not something Material-UI handles in the core?

As focus moves back to the body? What other behavior did you envision?

One that doesn't interrupt the current workflow.

So it would support the idea that the Snackbar should be portal[led], so it can't be reached with Tab?

I'm not so sure... User interaction is optional, but there may be an action the user wants to take, such as "Undo". What does a keyboard user do in that scenario if they can't focus the button?

What does a keyboard user do in that scenario if they can't focus the button?

Have a global shortcut which has a faster workflow for power users since you don't have to TAB and ENTER  just hit a single combination:

Basically something like <Snackbar action={} . ShortcutButton would not be in sequential focus order but register a global keydown listener for CTRL + Z that calls handleClick.

It's really hard to discuss this without user testing. It isn't clear to me if putting it in tab order isn't disrupting or if users even understand what's going on if they tab into an "undo" action that wasn't there before.

Part of the problem is also that the Material UI snackbars read the buttons when using a screen reader unlike the Material IO demo (https://material-components.github.io/material-components-web-catalog/#/component/snackbar). If the component is changed to not read the buttons and you include the shortcut text for screen readers only as mentioned above then it would solve the problem.
I also identified some issues with a variety of screen reader / browser combos that seem to be resolved if you move the role=alert to the text of the snackbar (#29080).

One thing I want to note really quickly is that browsers do have an internal focus cursor that we don't have access to with DOM APIs  and that may cause disorienting behavior with portals i.e. our current Snackbar implementation.
Say you have a document with 3 Buttons:
  <button />
  <button />
  <button />

Now we tab to the second button (-> indicates the focus cursor):
   <button />
-><button />
   <button />

Now we remove document.activeElement i.e. the second button. While document.activeElement will point to document.body, the focus cursor will remain at this "point" in the DOM:
   <button />
->
   <button />

If we TAB again, the focus cursor moves to the next element i.e. document.activeElement will become the next <button />
   <button />

-><button />

So moving focus to the Snackbar may result in a focus cursor that is no longer in the lk if the previously focus element is removed when the snackbar opens. For example, take list of TODO items with a remove action (ListItem is li > button):
   <ListItem>A</ListItem>
   <ListItem>B</ListItem>
   <ListItem>C</ListItem>

We TAB to the second item:
   <ListItem>A</ListItem>
-><ListItem>B</ListItem>
   <ListItem>C</ListItem>

and remove it:
  <ListItem>A</ListItem>
->
  <ListItem>C</ListItem>

which prompts a Snackbar asking us to undo
   <ListItem>A</ListItem>
   <ListItem>C</ListItem>
   <Snackbar>
->  <Undo />
   </Snackbar>

So now we have to handle focus restoration depending on whether we undo or not. If we just blur the undo button we land at the end of document since this is were the undo button was located:
   <ListItem>A</ListItem>
   <ListItem>C</ListItem>
->

I have a small codesandbox illustrating the issue: https://codesandbox.io/s/move-focus-to-snackbar-focus-cursor-issue-btsbv
The only leverage we have is in the case of undo but the Snackbar would not be able to restore since the restored ListItem would be a new HTMLButtonElement.
The correct solution would be to keep <ListItem>B</ListItem> in the DOM until we don't have the ability to remove it anymore. Though this gets increasingly complicated if you have previous actions in a stack to be able to undo multiple actions.
Not using a portal is also a possible solution but results in footguns relating to stacking context.
What my concern is that this behavior isn't trivial to implement and the problem itself is most likely not obvious to most people since it's "only" a keyboard related issues.
We can avoid this footgun entirely if we don't move focus around and add an affordance to "undo" (or whatever action you have in your Snackbar) with a separate keyboard combination.
Alternatively we hijack tabbing behavior enitrely and re-implement a focus cursor that considers the React tree not DOM tree.

Just noticed that Snackbar isn't portaled. So the problem doesn't exist right now. But there is considerable desire to allow for imperative toasts that would require a single Snackbar instance that will probably be portaled so we need to consider this in https://github.com/mui-org/material-ui/issues/18098.

Note that you can already implement this behavior with
<Snackbar
  open={open}
  onClose={handleClose}
  message="Note archived"
  action={<button autoFocus>UNDO</button>}
/>;

Considering this behavior is already implementable and making this the default behavior is potentially interruptive, I'm closing this issue for now.
I don't see how we can safely do the right thing automatically. What do we do with multiple actions? How do we restore focus if the element triggering the Snackbar got removed?
It would help a lot if we could gather use cases where focus should be moved so that we may be able to create more specific components. I just don't see compelling evidence for moving focus into a generic "toast" component.


pycache is not ignored

The binary package built with <IP_ADDRESS> includes all the __pycache__ folder from the original python package (e.g. the original package was copied from Lib\\site-packages which has __pycache__ already after that package was used at least once).
Should not be all the __pycache__ folders ignored and not copied into the binary package output folder?

The input package is expected to be distribution-ready. Therefore, it is assumed that everything within is to be preserved.
We do not attempt to decide which kind of file is to be filtered/ignored as this should be a user decision, and possibility is virtually unlimited. There might be times an .idea/ folder, or other caches such as .DS_Store files, that might need to be excluded. The decision is therefore made not to introduce a filter and such control on which file is to be included is returned to the user
If you do want to clean up the pycache files, here's a bash command that you might find handy
find . -type f -name '*.py[co]' -delete -o -type d -name __pycache__ -delete


#842 migrated to velocity 2.0

For #842 I've migrated to velocity 2.0. For more details check #842.

Job #891 is now in scope, role is REV

Codecov Report

Merging #891 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #891      +/-   ##
============================================
+ Coverage     75.34%   75.48%   +0.13%
- Complexity      976      981       +5
============================================
  Files           220      220
  Lines          4718     4724       +6
  Branches        368      369       +1
============================================
+ Hits           3555     3566      +11
+ Misses         1006     1003       -3
+ Partials        157      155       -2

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/org/takes/rs/RsVelocity.java
86.11% <100%> (+2.77%)
10 <3> (+3)
:arrow_up:

...in/java/org/takes/facets/auth/codecs/CcSalted.java
86.84% <0%> (+13.15%)
11% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d43de3...f5faabb. Read the comment docs.

@rultor merge

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 21min)

Job gh:yegor256/takes#891 is not assigned, can't get performer

The job #891 is now out of scope

@rultor release, tag is 1.12

@rultor release, tag is 1.12

@paulodamaso OK, I will release it now. Please check the progress here

@rultor release, tag is 1.12

@paulodamaso Done! FYI, the full log is here (took me 22min)


setting password auth to true through generator resources

Which issue this PR addresses:
This change will allow us to use the VMSS JIT approval in order to access prod and int RPs and GWYs
What this PR does / why we need it:
This change will allow us to use the VMSS JIT approval in order to access prod and int RPs and GWYs
Test plan for issue:
https://msazure.visualstudio.com/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/235246/JIT-VMSS-SSH-Access
Is there any documentation that needs to be updated for this PR?
https://msazure.visualstudio.com/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/235246/JIT-VMSS-SSH-Access

/azp run e2e


user mentions sometimes don't get linked correctly

Sometimes users mentioned in bday list and bday next show up as <@!…> instead of a correctly linked user name. This occurs if the users in question aren't in the client's cache (yet). Since this is actually a problem in the Discord client(s) I currently see no way to fix it on the bot side without significantly limiting its functionality.
As a workaround you can manually scroll through the entire member list of the server/channel. This will load the users into the client's cache for the remainder of the session. The next time the bot's post is loaded (during the same session) the users should be linked correctly. If not, they have probably left the server since the bot mentioned them.

Apparently in some cases (for example on at least one very old iPad) the workaround described above doesn't work.


chore(docgen|menugen): fix problems with paths on Windows

Codecov Report

Merging #2349 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2349   +/-   ##
=======================================
  Coverage   99.73%   99.73%
=======================================
  Files         152      152
  Lines        2659     2659
=======================================
  Hits         2652     2652
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d2d8e...ec6827f. Read the comment docs.

Released in<EMAIL_ADDRESS>


fix http response encoding

Codecov Report

Merging #80 (c986f78) into develop (b183a97) will increase coverage by 1.65%.
The diff coverage is 94.73%.

@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
+ Coverage    87.21%   88.87%   +1.65%
===========================================
  Files           72       72
  Lines          931      944      +13
  Branches        75       78       +3
===========================================
+ Hits           812      839      +27
+ Misses         119      105      -14

Impacted Files
Coverage Δ

src/faas/v0/start.ts
38.27% <0.00%> (+0.92%)
:arrow_up:

src/faas/v0/context.ts
80.53% <100.00%> (+15.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b183a97...c986f78. Read the comment docs.


Why does my model perform poorly

I can't training my model to lower test_loss, which fluctuating around 10, and the result of detect is bad, all the pictures seem to have been covered with a pink filter

While I can get some better detect result by the pretrain model

Hi,
may I ask which dataset you used for training?

用的是作者给出的那些数据集，不过要经过data_make.py处理

Hi,
may I ask which dataset you used for training?

用的是作者给出的那些数据集，不过要经过data_make.py处理

你好,請問是使用作者的代碼進行training嗎?

是的

Hi,
may I ask which dataset you used for training?

用的是作者给出的那些数据集，不过要经过data_make.py处理

你好,請問是使用作者的代碼進行training嗎?

是的

@andwizard 你圖是如何弄出來的,我等下跟你比較一下

@andwizard 你圖是如何弄出來的,我等下跟你比較一下

训练数据嘛？是这样的

While I can get some better detect result by the pretrain model

這個

I can't training my model to lower test_loss, which fluctuating around 10, and the result of detect is bad, all the pictures seem to have been covered with a pink filter

這個

这个图是我用自己训练完的模型做检测得到的

I can't training my model to lower test_loss, which fluctuating around 10, and the result of detect is bad, all the pictures seem to have been covered with a pink filter

這個

这个图是我用自己训练完的模型做检测得到的

请问一下，运行哪个代码检测


wrong directory in plugins.sh?

Shouldn't it be $JENKINS_HOME/plugins in https://github.com/jenkinsci/docker/blob/master/plugins.sh#L13 ?

nevermind, reading the README a bit more carefully explained it: https://github.com/jenkinsci/docker/tree/e7d56fa71d44ace1f1d8258ef216bba64f266cca#installing-more-tools


Group owner can self restore the group

The group owner self can restore deleted Office365 group. Added the steps to indicate same.

@nenonix @JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@Batre-MSFT - please merge the commit on the copy/edit review done by JohanFreelancer9 or make the necessary changes on the PR following the suggestions made. Thank you.

@mypil done

@MikePlumleyMSFT - PR has been copy edited and is ready for final review.
Thank you.
cc: @kenwith


Nick: Watch eatos.com

Nick requests the watch of the watch_keyword eatos\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

eatos\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


Extend tests utility belt

It's be nice to have some standard test wrapper with 'retry until' or 'pass if any of N' functionality to deal with things like:
Compact after lowering attachment size limit couchdb_attachments_tests:544: should_compact_after_lowering_attachment_size_limit...*failed*

in function couchdb_attachments_tests:wait_compaction/3 (test/couchdb_attachments_tests.erl, line 586)
in call from couchdb_attachments_tests:compact_db/1 (test/couchdb_attachments_tests.erl, line 573)
in call from couchdb_attachments_tests:'-should_compact_after_lowering_attachment_size_limit/1-fun-1-'/1 (test/couchdb_attachments_tests.erl, line 550)

**error:{assertion_failed,[{module,couchdb_attachments_tests}, {line,573},
{reason,"Timeout waiting for database database compaction"}]}
  output:<<"">>

@eiri problem is eunit standard timeouts. So even if we do a spinloop of “do until success”, we’d run into the eunit timeout. We can raise that of course, but we’ll be doing that a lot.
Maybe there is a way to set a timeout globally and set it to really long for travis and jenkins runs, so we never run into them™


Added type definition file

While #34 attempts to rewrite using Typescript, this pull request simply adds Typescript typings to the package, reducing the potential for breaking changes/etc

Turns out that shortly after this PR, a @types package was published.
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/41199
After reviewing those types, they seem super accurate. Closing this PR in favor of @types/bmp-js package


AWS Cognito as Identification Method

We need to use CDK to create a basic page where we can Log in by using AWS Cognito

The Client also wanted a 2FA for logins, and the possibility to enforce password change policies in the organization.


HW1: Update project proposal

HW 1
Submission for HW1

Add link to Github README
Add new file with description of project to create
Add new file with description of project to contribute to

lgtm


Gd2 pod  names are kube1-0, kube2-0, kube3-0

I have created gcs setup with latest repo using vagrant. i am seeing gd2 pod names like kube1-0, kube2-0, kube3-0. This will create little bit confusion instead of that better to start gd2 pod names with 'gluster'.

I think we can probably prefix the pod names with "gluster". The node name is being added by the templates as we're setting node affinity (kubeN), and the "-0" suffix is due to the StatefulSet.
A quick patch to the template should be able to change the pod names to something like:
gluster-kube1-0, etc.

i will sent a patch to fix this issue


fix: avoid filters containing null value

SUMMARY

related PR: https://github.com/apache/superset/pull/16936
closed: https://github.com/apache/superset/issues/16803
Avoid filters getting null values. User should add IS NOT NULL or IS NULL operator to handle Empty value in SQL
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[x] Has associated issue: https://github.com/apache/superset/issues/16803
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@zhaoyongjie does the filter box use this same endpoint? IIRC, the filter box select works with null values (the native filter one does, too, but it uses the chart data endpoint for this so won't be affected). If this doesn't affect the filter box then LGTM, otherwise we may need to add an additional param to the endpoint path to toggle between allowing/disallowing nulls and calling it without nulls only on the adhoc filter request.

Good point! currently(after this PR), changed original behavior.
For example, there is a table:
SELECT 'foo' as foo
UNION
SELECT 'bar'
UNION
SELECT NULL
-----------------------------
foo
NULL
bar
foo

We call the filter endpoint before, the response was
[None, 'bar', 'foo']

and now, the response is
['bar', 'foo']

but the None value is doesn't fit SQL where clause. for instance:
SELECT col1
FROM tbl
WHERE col1 in (NULL)

So, I think we can change old behavior safely. might be I have not considered it well, What do you think about?


Windows support

Added windows support and changed the formatting to f-strings for easier readability.

Hmm, this is interesting.
$ pythonfetch
Traceback (most recent call last):
  File "/home/adil/Clones/pythonfetch/.venv/bin/pyfetch", line 33, in <module>
    sys.exit(load_entry_point('pythonfetch==0.13.0', 'console_scripts', 'pyfetch')())
  File "/home/adil/Clones/pythonfetch/.venv/lib/python3.9/site-packages/pythonfetch-0.13.0-py3.9.egg/pythonfetch/__init__.py", line 101, in main
AttributeError: 'posix.uname_result' object has no attribute 'machiene'

That looks good, @MergenStudios thank you.


Merging fix for issue #449, initial proto bosh deploy fails

Potential fix for #449 that is verified to leave non-initial-protobosh behavior unaffected. Also includes improvements to logging and shellcheck use during testing.

fixes #449


Spyglass (and probably Trident) Issue

I already saw #52 and #50, however, in this case, I'm pretty sure that model is changed with CIT and not with CEM, therefore it's probably a parity issue.
Expected behavior (Optifine): https://imgur.com/a/qQOzbPq
CIT Resewn: https://imgur.com/a/zmnojGj
Resource pack: https://drive.google.com/file/d/1N2s0dunlQtx31ODTiLMh70g_vhXFFnLN/view?usp=sharing
Files related to the problem: /assets/minecraft/optifine/cit/8.0/items/spyglass

Are you sure the images are in the correct order? I think you have them flipped.
Also, could you make the resourcepack link work for both this pack and the one in #135. I can't open them.

Are you sure the images are in the correct order? I think you have them flipped. Also, could you make the resourcepack link work for both this pack and the one in #135. I can't open them.

Yep, I flipped them, sorry. Fixed it and also fixed the link

was this ever fixed for 1.19.2?


This Month in Rust OSDev (June 2020)

This is a draft for the upcoming "This Month in Rust OSDev (June 2020)" post. Please add your content to this draft by creating pull requests against the next branch.

@rust-osdev/all We are already a bit late with the status post this month, so I'd like to publish it as soon as possible. I'm working on creating changelog for the rust-osdev projects right now. If you have some personal project updates to share, please let me know so that I can wait for your changes before publishing.

Nothing noteworthy from my side in june, just a couple of README fixes. I'll pass this issue I guess.
Thanks!

@andre-richter Thanks for the info!


Base PD IG on au-fhir-core

The PD IG is currently based off HL7AU au-fhir-base IG.
Consideration should be given to basing the PD IG on au-fhir-core IG instead.
This was raised at the HL7AU FHIR working group 2 Aug 2023 by Reuben Daniels (see https://confluence.hl7australia.com/display/PA/2023-09-02+FWG+Minutes)
Note that au-fhir-core as yet does not have a balloted snapshot to set as a dependency

Closing; managed elsewhere


fix(cloudflare): Use polyfills for path/*

Partial revert of #343 until we have a proper fix in workerd, see https://github.com/cloudflare/workerd/issues/3012
/cc @anonrig

@jasnell's pull-request fixes this: https://github.com/cloudflare/workerd/pull/3015

@jasnell's pull-request fixes this: cloudflare/workerd#3015

Could we merge this before the PR is approved and workerd makes its way to wrangler?
More generally I'm in favor of reverting troublesome PRs ASAP.

Thanks for the reviews!


dispatch is not defined

I get the following error trying to fire dispatch(). How should it be imported? There's nothing about it in the README.

dispatch() is just store.dispatch(). Sorry the docs aren't great. I'll work to improve them for v1.0: https://github.com/acdlite/redux-react-router/tree/next


Column names should be inspired by Java reflection method names

Seeing this example statment here:
SELECT i.NAME as name, COUNT(m.ID) as nbMethods
FROM INTERFACE i, METHOD m
WHERE m.TYPE_ID = i.ID GROUP BY i.ID HAVING COUNT(m.ID) > 20;

I'm thinking about how I would best discover these tables as a new user. And I'd probably expect METHOD.DECLARING_CLASS to be the value to use for the join with INTERFACE., not TYPE_ID.
A method has several "types", e.g. annotations, return types, exception types, parameter types, type arguments, etc. So I wouldn't use a generic TYPE_ID to model the declaring class.

I do agree, without documentation, TYPE_ID can be confusing (BTW, I've added a description of the model here). The column name should be more explicit, something like DECLARING_TYPE_ID.


[cmake] adjust NATIVE build for Swift

@xiaobai

I don't like the way this patch looks but I understand it's necessary for cross-compilation to work correctly and there aren't many other options right now. Merging.


FR: Handle multiple databases

Code from https://firebase.google.com/docs/database/admin/start
import firebase_admin
from firebase_admin import credentials
from firebase_admin import db

# Fetch the service account key JSON file contents
cred = credentials.Certificate('path/to/serviceAccountKey.json')

# Initialize the app with a service account, granting admin privileges
firebase_admin.initialize_app(cred, {
    'databaseURL': 'https://databaseName.firebaseio.com'
})

# As an admin, the app has access to read and write all data, regradless of Security Rules
ref = db.reference('restricted_access/secret_document')
print ref.get()

The db seems a singleton variable so it's not able to handle multiple databases at the same time.
Any ideas?

db is module. Way to support this is by passing the database URL as an optional parameter to db.reference(). This is in our roadmap.

I managed to use two databases like below:
firebase_admin.initialize_app(cred, {
    'databaseURL': 'https://databaseName.firebaseio.com'
})

app2 = firebase_admin.initialize_app(cred, {
    'databaseURL': 'https://databaseName-app2.firebaseio.com'
}, name='app2')

ref = db.reference('restricted_access/secret_document')
ref2 = db.reference('restricted_access/secret_document', app2)

print(ref.get())
print(ref2.get())

This has been implemented and will be included in next release.


Windows Branch

I replicated all of the changes we had to make for Windows compilation, and also fixed the issue with filename backslashes (so this branch will only work correctly on Windows, and should probably be kept as a branch). There's also an example_Windows folder with a CodeBlocks version of the original example.

Hey thanks again for the great work! I just created a windows branch. Could you submit a pull request with gewang/ofxChucK:windows as the target? For some reason it's not possible for me to do this (e.g. as referenced here: https://github.com/isaacs/github/issues/18).

Will do.


asset_cost: kinds should be defined at system level

via enum_value table

@rovats

To hit, this should be similar to the approach taken with bookmark kinds

Damn autocorrect!  Rohit not 'to hit'!

:)
Yes, insert them into enum_value table, then use <waltz-enum-value> in the templates, right?

Yup. Think that's it
On Thu, 5 Oct 2017 at 14:52, Rohit Vats<EMAIL_ADDRESS>wrote:

:)
Yes, insert them into enum_value table, then use  in
the templates, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/khartec/waltz/issues/2530#issuecomment-334471269, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjNPV8EqhMpjbefgNSXeGqDsLOBj5gRks5spN8EgaJpZM4PDw7X
.


execute CQL

Hello,
With the CQL extension added to VSCode, syntax highlighting works fine, but how do I execute CQL? The context menu "Execute CQL" does not work. Is there anything to set up ?
Thanks for your help

I don’t know, but I suspect it follows the same code-by-convention as the atom plug in. This requires a specific directory input structure for test data.
https://atom.io/packages/language-cql-preview

I think it’s this structure. @JPercival can you confirm or supply better link?
https://github.com/cqframework/ecqm-content-r4

This is currently the best reference for the directory structure:
https://github.com/cqframework/sample-content-ig
The README has some additional details.
If the "evaluate CQL" context menu doesn't show up after that please let me know

Closing as resolved, @jcdufour feel free to submit a new issue or reopen if the issue persists.


Add iperf3 version 3.1.3

This adds the command-line network benchmarking tool iperf3.

Just one small addition to autoupdate to support hash extraction:
    "autoupdate": {
        "architecture": {
...
        },
        "hash": {
            "url": "https://iperf.fr/download/windows/sha256sum.txt"
        }
    }

@r15ch13 Added :slightly_smiling_face:


Improve error message for missing tupleize / vectorize

Unfortunately, bool(first_key < first_key) doesn't work as a detector since tuple.__lt__ first checks elements for equality, which does work for dice.

Considering to reinstate automatic tupleize, forgetting to do it is actually pretty annoying.

We'll see if the automatic tupleize is enough.

tupleize can be pretty expensive, mostly due to the use of isinstance. It may be worth either optimizing this or only enabling auto-tupleize for map rather than all constructions.

Replacing with getattr reduced the time for d20.pool(5).expand() spent in tupleize from about 120 ms to 60 ms, out of 400 ms after the change.

Shaved the total additional cost down to ~75 ms, or about 25% over the previous total. Maybe this is good enough for a near-worst-case scenario.


[Question] Is there a running list of Feature Requests?

I'd love to jump in and contribute to Flowise. It would be great if there were a system (maybe a set of labels) to track feature requests by package.

Hey @austinbiggs we currently dont have a public feature requests yet, only our internal backlog, happy to share that on Discord
Anything tagged with enhancement or help wanted are good to start with

Anything tagged with enhancement or help wanted are good to start with

@HenryHengZJ thanks for the reply, I'd be down to sync on Discord.


Fix for awkward 2.3

TODO

[x] Closes #1035 (or at least addresses it)
[x] Tests added refactored
[x] Release note added
[x] Bump awkward array version or have backward compatibility
[ ] Figure out right way to fix this, e.g. with_parameter, with_name

/azp run

@agoose77 @grst @jpivarski @ilan-gold
Had a discussion about this, with the following conclusions:

We'll merge as is

So we don't put an upper bound on awkward

@grst will try to see if he can figure out with_name later in the week
@jpivarski @agoose77, if we can't figure out with_name, would you be up for making a release candidate before making a change that changes this?


Update linspace edgecase to match numpy fix.

Updating linspace edgecase to match fix to numpy at https://github.com/numpy/numpy/pull/14929

Beautiful, thanks for catching this tricky issue!


having a lot of these issues deepseek/coder

Issue
deepseek coder issue:
Tokens: 43,288 sent, 531 received. Cost: $0.0062 request, $0.10 session.
The LLM did not conform to the edit format.
https://aider.chat/docs/troubleshooting/edit-errors.html

# 1 SEARCH/REPLACE block failed to match!

it seemed to match but the problem persists.
rustlang
Version and model info

latest aider doing rust code.
sonnet and openai works

Thanks for trying aider and filing this issue.
You can try --edit-format whole to see if it's more reliable.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.

@paul-gauthier I have the latest aider version from pip, and I confirm it has tons of issues when it comes to DeepSeek models. Now, it's just unusable at all. Claude works ok, as well as open ai.
I'm constantly getting errors
The LLM did not conform to the edit format.
https://aider.chat/docs/troubleshooting/edit-errors.html

# 2 SEARCH/REPLACE blocks failed to match!

Even on a simple script (~150 lines of code). Python.
I've just realized that --edit-format whole seems to help, thank you. But it feels like things are working slower with it... Also, does it consume more tokens? If no, I'm ok with it :)


bug: disabled attr is not being passed down from ion-input to the input element

http://localhost:8000/dist/e2e/input/fixed-inline-labels/
    <ion-item>
      <ion-label fixed>CC</ion-label>
      <ion-input disabled="true" value="Text 2"></ion-input>
    </ion-item>

It works with static values but it doesn't adding disabled attribute dynamically such as:
<ion-input [disabled]="isDisabled ? '' : null">

This issue is still present on Ionic 2.0.0. When an ion-input is initially set with the [disabled]="true" attribute the disabled attribute isn't being passed down to the native input element.

This is still an issue with Ionic 3.4.2

Is there any workaround?

Weird that this issue is still opened


Drop handler not checking for silk touch correctly

https://github.com/turbodiesel4598/NuclearCraft/blob/master/src/main/java/nc/handler/DropHandler.java#L51
Don't do that.
Use HarvestDropsEvent#isSilkTouching(), as machines that silk mine do not have tools.
Also the held item will never be null.

Cheers - did not know about that. Fixed now!


Adding "View" Functionality to Element Graphing

Is it possible to get the view functionality on the Elements Graph Dash? It becomes tedious when using that graph to pick and choose through the vast amount of tags. Or is there a better option for comparing individual tanks with each other?

@brian-chapman yep! Should be easy to add this functionality. Added to the list. We can discuss where to place this w/priority when we connect this week.


[Bug]: vignette not display as intended

Describe the bug
The following code chunk in the vignette will not be displayed as intended to the user:
https://github.com/nmfs-ost/asar/blob/a9b19fec03254fa533b7408c93f7b0078835adf8/vignettes/accessibility_guide.Rmd#L44-L46
Describe how to reproduce the bug
No response
Screenshots
No response
Which OS are you seeing the problem on?
Windows
Which version of asar are you seeing the problem on?
dev branch
Additional Context
No response

PR to fix bug: https://github.com/nmfs-ost/asar/pull/95

Closed as completed.


Using preview API  within k8s-extension

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az k8s-extension extension-types list Extension Name: k8s-extension. Version: 1.3.4.
Errors:
(NoRegisteredProviderFound) No registered resource provider found for location 'westeurope' and API version '2022-01-15-preview' for type 'connectedClusters'. The supported api-versions are '2020-01-01-preview, 2021-03-01, 2021-04-01-preview, 2021-10-01, 2022-05-01-preview'. The supported locations are 'westeurope, eastus, westcentralus, southcentralus, southeastasia, uksouth, eastus2, westus2, australiaeast, northeurope, francecentral, centralus, westus, northcentralus, koreacentral, japaneast, westus3, eastasia, canadacentral'.
Code: NoRegisteredProviderFound
Message: No registered resource provider found for location 'westeurope' and API version '2022-01-15-preview' for type 'connectedClusters'. The supported api-versions are '2020-01-01-preview, 2021-03-01, 2021-04-01-preview, 2021-10-01, 2022-05-01-preview'. The supported locations are 'westeurope, eastus, westcentralus, southcentralus, southeastasia, uksouth, eastus2, westus2, australiaeast, northeurope, francecentral, centralus, westus, northcentralus, koreacentral, japaneast, westus3, eastasia, canadacentral'.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az k8s-extension extension-types list -g {} --cluster-name {} --cluster-type {}

Expected Behavior
Environment Summary
macOS-12.6-arm64-arm-64bit, Darwin 21.6.0
Python 3.10.6
Installer: HOMEBREW

azure-cli 2.40.0

Extensions:
connectedk8s 1.3.3
k8s-extension 1.3.4

Dependencies:
msal 1.18.0b1
azure-mgmt-resource 21.1.0b1

Additional Context

route to CXP team

@t0rben Apologies for the late reply. Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

@t0rben Could you please update and run the below command and see if that helps ?

az rest --method GET --uri https://management.azure.com/subscriptions/XXXXX-XXX-XXXX-XXX/resourceGroups/MyRGName/providers/Microsoft.ContainerService/MyClusterType/MyClusterName/providers/Microsoft.KubernetesConfiguration/extensions?api-version=2022-04-02-preview

Note: Please update the Subsciption ID, Resource Group Name, Cluster Name and Cluster Type in the above request URL.
MyClusterType : i.e. managedClusters, connectedClusters, provisionedClusters
Hope this helps.


Filtered Computed List delivers an update too slow

If we build a ReordableListView on a Computed List of models with .where operator the results come with the little delay and it make the ReordableListView snap back to previous state until it is updated. It takes a fraction of a second but creates a ui glitch.
On reorder I modifiy original ListSignal and that's the one that computed is using to create its own signal.
The problem doesn't occur when .where is removed.
I don't know if it's possible to do something with it, but it's a little annoying that at this point I need to use a workaround changing the computed.value list elements directly and then second one on the original list.

Can you share a complete code sample? Signals are available as a package on DartPad! https://dartpad.dev

I would suggest adding .toList()
list.where(...).toList();

@rodydavis  https://dartpad.dev/?id=dd20d888ea98545d7a7c5a36dc7eddfe

If you want to delay the update then you will need to use a batch when updating all the signal values!

I think the logic on the reorder needs to change some, here it is working for me:
void reorderItems(int oldIndex, int newIndex) {
    if (oldIndex < newIndex) {
      newIndex -= 1;
    }
    final items = filteredAndSortedItems.value;
    final ItemModel item = items.removeAt(oldIndex);
    items.insert(newIndex, item);

    batch(() {
      // Update orderIndex for all items
      for (int i = 0; i < items.length; i++) {
        final updatedItem = items[i].copyWith(orderIndex: i);
        final allItemsIndex =
            allItems.indexWhere((element) => element.id == updatedItem.id);
        if (allItemsIndex != -1) {
          allItems[allItemsIndex] = updatedItem;
        }
      }
    });
  }

Thanks for providing an example @rodydavis , but unfortunately batch doesn't change anything in that case.
In your example you are still updating the list of the computed property.
The moment you change line 81 from final items = filteredAndSortedItems.value; to final items = [...filteredAndSortedItems.value]; the flash is back.

You are changing the in memory list of the computed property which updates the in memory location for the Reorderable ListView widget. That is so it does not flash.
But in a batch you update the actual order values so that the next frame and scheduled updates via signals will have the correct values.
Otherwise I believe the rebuild triggers a new list which then the ListView widget has to recreate.

exactly. that's why commenting out whole batch code from your example change nothing in the behavior.
what I wanted to achieve was to have a view model that has exposed ReadonlySignal<List> that comes from repository and is the single source of the data.
but unfortunately it looks like we need to modify the in memory list first and then update data for computed again.
it's weird because in riverpod same case worked like a charm and im trying to migrate from it.

any updates on that @rodydavis ? is it fixable or not at all?

Can you try on 6.0?
Can you share the riverpod example?


Update workflows to use correct luajit

pretty small pr, but yeah

@ShadowMario

it got updated now, so i'm closing it