Intermittent  test failure in _differential_evolution

I have had the same test failure in optimize._differential_evolution several times while working on completely unrelated code. The test will pass and fail seemingly at random, even if running the test suite multiple times with no changes to any code.
Error message:

scipy/optimize/tests/test__differential_evolution.py:665: AssertionError
______________________________ TestDifferentialEvolutionSolver.test_impossible_constraint ______________________________
[gw0] linux -- Python 3.7.1 /usr/bin/py
self = <scipy.optimize.tests.test__differential_evolution.TestDifferentialEvolutionSolver object at 0x7efffde4c7f0>
    def test_impossible_constraint(self):
        def constr_f(x):
            return np.array([x[0] + x[1]])
        nlc = NonlinearConstraint(constr_f, -np.inf, -1)
        solver = DifferentialEvolutionSolver(rosen, [(0, 2), (0, 2)],
                                             constraints=(nlc), popsize=3)
        # a UserWarning is issued because the 'trust-constr' polishing is
        # attempted on the least infeasible solution found.
        with warns(UserWarning):
            res = solver.solve()
>       assert_allclose(res.x, [0, 0], atol=1e-6)
E       AssertionError:
E       Not equal to tolerance rtol=1e-07, atol=1e-06
E
E       Mismatch: 50%
E       Max absolute difference: 7.48738823e-06
E       Max relative difference: inf
E        x: array([7.487388e-06, 1.110223e-16])
E        y: array([0, 0])
constr_f   = <function TestDifferentialEvolutionSolver.test_impossible_constraint.
<locals>.constr_f at 0x7f003891cbf8>
nlc        = <scipy.optimize._constraints.NonlinearConstraint object at 0x7efff5b7c6d8>
res        =            constr: [array([1.00000749])]
constr_violation: 1.0000074873882285
             fun: inf
    maxc... nfev: 1467
             nit: 1000
         success: False
               x: array([7.48738823e-06, 1.11022302e-16])
self       = <scipy.optimize.tests.test__differential_evolution.TestDifferentialEvolutionSolver object at 0x7efffde4c7f0>
solver     = <scipy.optimize._differentialevolution.DifferentialEvolutionSolver object at 0x7f00389b6198>
scipy/optimize/tests/test__differential_evolution.py:665: AssertionError

Scipy/Numpy/Python version information:
1.4.0.dev0+8b334af 1.16.4 sys.version_info(major=3, minor=7, micro=1, releaselevel='final', serial=0)

I can reproduce this.  I don't recall seeing the error when I run the full test suite, but if I run just the differential evolution tests with
$ python runtests.py -n -s optimize.tests.test__differential_evolution
I see the error most of the time.

This should be a straightforward fix, in that the test tolerance needs adjusting. The differential evolution solve is constrained to have the sum of both parameters be less than -1, but each parameter can be no less than 0. When the main part of the differential evolution solve finishes, both parameters will be very close to 0. The solver then tries to polish the solution using trust-constr (with the same impossible constraints/bounds). This process just tips the parameters less than 0. I'm not sure how far the trust-constr optimiser is permitted to go out of bounds here. That permitted error should be the atol parameter here. @mdhaber any thoughts on what it could be relaxed to, 1 or 2e-5?
The failure is intermittent is because the test is not seeded (and doesn't really need to be).

When skimming this it looked like a tolerance issue, too, in which case 1e-5 would be fine. But I'm not sure that we should rely on the local minimizer to return a point near the origin. It might be its tendency to minimize the residual, but is that guaranteed/documented?
I guess I didn't look carefully at this test before, but if the test is checking that DE responds appropriately when the problem is infeasible, I'd suggest just turning the polishing off and checking for the appropriate status from DE. You might separately leave polish on and check for the appropriate status rather than a particular solution value.

But I'm not sure that we should rely on the local minimizer to return a point near the origin. It might be its tendency to minimize the residual, but is that guaranteed/documented?

I just happened to make the lower bound for both parameters to be 0, I could've chosen 0.5. In that case trust-constr might've polished to e.g. 0.499xx. L666, 667 check the overall status of an impossible polished differential evolution solve, L665 just checks that the trust-constr polishing doesn't go very far past a boundary. That line is probably not necessary, but I think I'll just adjust the test tolerance.

Turns out that 1e-5 wouldn't fix it either. When I use a seed the tol would need to be 1.52e-4. It's unclear to me from the documentation how much the bounds are allowed to be exceeded by.
I'm probably just going to remove the check on L665 at this point.


Add name to the list of properties

I'm using the date picker as part of a sign up form, and I need to access the value via the input name. Can you add a prop that allows adding a "name" property to the input?

@Raz1990 - name works for me.


error: ‘fabs’ was not declared in this scope; did you mean ‘iabs’

Hey, I am getting this error during compilation in Engine/third_party/bc7enc/bc7enc/rgbcx.h.
What's the cause and how do I fix that?

Sounds like you need to #include <math.h>?


Add a dedicated unit test for bazel.Config.FetchInputs. [phab:D1789]

Created by fromberger at 2017-07-20 01:02:52:

zarko commented inline (context lost during migration) at 2017-07-20 01:30:30:
+1 gotten

zarko accepted this revision at 2017-07-20 01:30:30

fromberger closed via commit 8b624ac87fb723d090374dca9f744ad28e373a83 at 2017-07-20 01:47:56


bug(google-maps): Inconsistent naming/visibility/optionality of properties for the JavaScript API objects

Expected Behavior
Consistent naming/visibility/optionality should be applied to all seven of the Angular Google Maps components and the underlying Google Maps JavaScript API objects they manage.
Actual Behavior
The Public API to Angular Components' Google Maps Package is here:
https://github.com/angular/components/blob/master/tools/public_api_guard/google-maps/google-maps.d.ts
6 out of the 7 Angular classes make available as a public property the JavaScript API object they manage:
class GoogleMap: 	_googleMap: UpdatedGoogleMap;
class MapMarker:	_marker?: google.maps.Marker;
class MapCircle: 	circle: google.maps.Circle;
class MapPolygon:	_polygon: google.maps.Polygon;
class MapPolyline:	_polyline?: google.maps.Polyline;
class MapRectangle:	_rectangle: google.maps.Rectangle;

The 7th component prefixes its internal JavaScript API object with "private" so it is not part of the public API:
https://github.com/angular/components/blob/master/src/google-maps/map-info-window/map-info-window.ts
class MapInfoWindow {
  ..
  private _infoWindow?: google.maps.InfoWindow;
}

I see four (easy to fix) problems with the above arrangements.
There is inconsistent naming - MapCircle has "circle" (no underscore) whereas the others do start with an underscore.
I don't think any property whose name starts with an underscore should be publicly made available.
There is inconsistent visibility: MapInfoWindow's underlying object is marked private, the others not.
There is inconsistent optionality: marker?, polyline? and _infoWindow? are marked optional, the others not.
The same naming/visibility/optionality rules should applied  for all seven components. There are valid reasons why app developers using Angular might want to get access to the underlying Google Maps JavaScript API object, so the MapCircle approach seems best, and it should  be consistently applied to the other components.

The real question is why circle isn't marked as internal like the rest.  @mbehrlich?

Should be fixed now. Circle in particular just happened to be fixed before the others. All are now public properties.


Feature/Update or Replace Dependencies for Python3 [PLAT-726]

Purpose
We have dependencies preventing us from upgrading to Python 3.
Changes
Certain dependencies were updated/replaced to ensure they are python-3 compatible

fake-factory (renamed to faker; latest version supports py3: https://github.com/joke2k/faker)
python-geoip-geolite2 (no new updates but has a py3 fork)  Using maxminddb-geolite2 instead which has py3 compatibility
hurry.filesize (no new updates, but there are py3 alternatives such as https://github.com/tbielawa/bitmath). Removed this dependency. It appears to be unused.
box.py (no new updates, but official sdk supports py3: https://github.com/box/box-python-sdk)

QA Notes

I would test Box addon thoroughly; making sure there are no changes.  Whatever typical regression test is done for Box.  As part of this make sure deleted folders/files don't show up.
Ensure that country code and continent code still being sent to Keen under anonymized location data section in public collections.  For example, Staging - OSF - Public collection.  Sometimes these values are null.

Documentation
None needed.
Side Effects
Should be none.
Ticket
https://openscience.atlassian.net/browse/PLAT-726

LGTM, I also run this on my travis branch, and it totally passed https://travis-ci.org/Johnetordoff/osf.io/builds/365130652 confirming it was an false negative.


merge to master

Codecov Report

Merging #10 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7263a1e...aa86d0f. Read the comment docs.


fix "Uncaught TypeError: Cannot set property 'moment' of undefined" E…

…rror
When packaged into one js file with other plugins which might add "use strict", this "Uncaught TypeError: Cannot set property 'moment' of undefined" will be thrown.

As we changed the loading/setup process in 1.21 I think we can close this.


Wiki link doesn't work

When I click on the wiki link, I am simply redirected to the repository page. I therefore cannot see the list of supported plugins/languages.

Thanks for your contribution :+1:
Unfortunately I've had no time to get the Wiki docs done for this project.
There have been plans to document each Nord port project in its own Wiki and also host the docs from within the repository, but this concept will be replaced with the new nord-docs (WIP) which will host the official Nord website and the documentations for all port projects. Centralized docs are by far better for projects like Nord that consists of many sub-projects (port projects) and helps to keep each repository clean by restrict the content to the main part: the code.
To answer your question: This theme currently supports all languages bundled with IntelliJ IDEA Community Edition & Ultimate Edition where some of them are also listed in the screenshot section of the README.
I'll update this issue as soon as I've pushed the missing documentation about supported plugins/languages to the new docs website.

Most of the docs have been ported to the new Nord website, but the page for supported plugins and languages is still in progress and requires some investigation in the defined editor color scheme keys that include Community Edition as well as Ultimate Edition content.


Add peekHeaders operator on HttpRequest and HttpResponse

Related Issue #3097
Motivation:
Currently, we support mapHeaders, mapData, mapTrailer operators at #3624.
So it seems good to support peek* operators too.
Modifications:

Add peekHeaders operator on HttpRequest and HttpResponse
Replace mapHeaders with peekHeaders where we don't modify headers

Result:

You can now use peekHeaders to check headers

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

retest this please

Great job!
Thanks, @injae-kim and reviewers. 😉


add dark mode to the app

Just because it would be fun and it's pretty easy with Dash themes

Check out dash_daq.DarkThemeProvider
https://dash.plotly.com/dash-daq/darkthemeprovider

Check out dash_daq.DarkThemeProvider
https://dash.plotly.com/dash-daq/darkthemeprovider


Everywhere: Use Skia painter by default

Skia painter is visibly faster than LibGfx painter and has more complete
CSS transforms support. With this change:

On Linux, it will try to use Vulkan-backend with fallback to
CPU-backend
On macOS it will try to use Metal-backend with fallback to
CPU-backend
headless-browser always runs with CPU-backend in layout mode

ops, forgot to update SVGMaskable::calculate_mask_of_svg() to use Skia painter. converting to a draft for now.

https://github.com/LadybirdBrowser/ladybird/blob/0384b484bd61b12c0ab6f96ffbf7d4015760b7ab/Userland/Libraries/LibWeb/Painting/PaintableBox.cpp#L1016-L1032
Gfx::Painter is used in here, will this change also make this code obsolete? That would leave the 2D Canvas Context as the only remaining user of Gfx::Painter

https://github.com/LadybirdBrowser/ladybird/blob/0384b484bd61b12c0ab6f96ffbf7d4015760b7ab/Userland/Libraries/LibWeb/Painting/PaintableBox.cpp#L1016-L1032
Gfx::Painter is used in here, will this change also make this code obsolete? That would leave the 2D Canvas Context as the only remaining user of Gfx::Painter

yes, eventually mask painting will be using Skia too, but currently there is no Skia API wrapper that would be suitable to use here as a replacement.


[Question] Add UnderscoreJS and Lodash type support?

Before I start implementing or creating a pull request, I wanted to ask if UnderscoreJS and Lodash would be appropriate extensions to include in this Library? Here is an example of these type of Extensions already implemented in Swift, Dollar.swift.

Some of the functionality there seem good. But the implementation should be swift-like. Except for the file "ez" which includes popular global stuff, all the extensions must feel natural.

The most useful function from _ are already implemented in Swift 2.0 by default. Did you encounter any functions provided by _ which are hard to do in swift?

I'm closing this if there is nothing else to add


Question: Does the campaign consider the constraints when recommending the next set of parameters?

I tried to optimize a function, this function is wrapped and treated as blackbox as set up here in a colab notebook.
The function have constraints, include:

x19 < x20
x6 + x15 <= 1.0

When I have set up the constraints and passed it to the campaign searchspace, I received errors (from different campaigns) like:

AppError: The upstream Gradio app has raised an exception: 1 validation error for BlindedParameterization
Value error, Received x19=1.9282829821603463e-14 which should be less than x20=1.5484909905601926e-14 [type=value_error, input_value={'x1': 0.0, 'x2': 0.99999...c3_2', 'fidelity1': 0.5}, input_type=dict]

AppError: The upstream Gradio app has raised an exception: 1 validation error for BlindedParameterization
Value error, Received x19=6.260733986110276e-14 which should be less than x20=0.0 [type=value_error, input_value={'x1': 5.226077351257307e...c3_2', 'fidelity1': 0.5}, input_type=dict]

AppError: The upstream Gradio app has raised an exception: 1 validation error for BlindedParameterization
Value error, Received x6=8.651643240363338e-10 and x15=0.999999999143041 which should sum to less than or equal to 1.0 [type=value_error, input_value={'x1': 0.0, 'x2': 0.99999...c3_2', 'fidelity1': 0.5}, input_type=dict]

From the BayBE constraints tutorial, the constraint validation is done after all the recommendations are made and it also pass a tolerance argument in the validation. While most of the above errors are due to rounding, is there anyway to workaround it since the wrapped function has a strict constraint? Or if there is a better way to do this? Thanks.

Hi @ritalyu17, I don't have access to your notebook but from what I read in your description, you seem to use a set of continuous and place continuous linear inequality constraints on top, correct?
When you look at the corresponding example on our doc page, you'll see that the constraint validation is done using a tolerance, for exactly the reason you described. The issue ultimately stems back to how the constraints are handled by the scipy-solvers, which are internally called to generate the new recommendations and which fulfill the constraints only up to a certain numerical resolution. I guess the error would become smaller when switching to a higher floating point accuracy like float128 but that is neither supported at the moment nor would it completely solve your problem. So I'm afraid the best you can do at the moment is apply a little post-processing yourself, e.g. to round everything below say 1e-8 to zero. I could imagine that we might provide some automatic post-processing like this in the future, where we project back the found solution onto the constraint polytope ...
Any other thoughts, @Scienfitz @AVHopp?

I suggest to simply round tiny numbers to exact 0.0
The error is not raised by baybe but by the app, it appears the app doesnt allow for numerical tolerance in its own validation, which is something I would suggest to change
Additionally, the constraints don't seem right to me x19 < x20 can never be fulfilled if x20 is 0.0 and 0.0 <= x_i <= 1.0

This has been discussed in one of our meetings, hence this can be closed. If anything is unclear, feel free to reopen.


chore: update the rpc flag name

Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #316 (7f6ebc2) into main (59db7a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   43.42%   43.42%
=======================================
  Files          26       26
  Lines        1992     1992
=======================================
  Hits          865      865
  Misses       1005     1005
  Partials      122      122

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Upgrading helm client to latest version should work for all server versions?

We have several K8s clusters, each running different versions of Helm / Tiller on the servers right now.  Specifically we are running clusters with server versions:

v2.0.0-beta.2
v2.0.0-alpha.5

From a tooling perspective, our DevOps pipeline and developers would like to just use the latest version of the client to avoid working with specific versions of helm per cluster.  As it stands now if you use something like:
brew cask uninstall --force helm && brew cask install helm
To always ensure you have the latest, the rc-2 will not work with either of these and results in the following errors:
Brandons-MBP:clusters brandoncole$ helm list
Error: client version is incompatible
Brandons-MBP:clusters brandoncole$ helm version
Client: &version.Version{SemVer:"v2.0.0-rc.2", GitCommit:"f8037c83c647b56d9ef42d0d5254e5fc563e3048", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.0.0-beta.2", GitCommit:"8a5550d0c6785eaa94eac80e0c1d11a92c355a02", GitTreeState:"clean"}
...
Brandons-MBP:clusters brandoncole$ helm list
Error: client version is incompatible
Brandons-MBP:clusters brandoncole$ helm version
Client: &version.Version{SemVer:"v2.0.0-rc.2", GitCommit:"f8037c83c647b56d9ef42d0d5254e5fc563e3048", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.0.0-alpha.5", GitCommit:"4de5c4aa578ed9ca173aff472f00d2167ec59a88", GitTreeState:"dirty"}

Is there a simple workaround or is this as expected?  @chrislovecnm any thoughts?

@technosophos / @michelleN I know one of you is in Seatle right now.  This is my ask :)
We and others are going to have an environment where your tooling is going to have SLAs around it.  Our SLAs are pretty lofty, just think lots of nines.  How do we get this sorted out, documented, and baked in so that our users, as in OSS community users, don't hit this problem again?
How can we help your team?

For the most part, what you are experiencing is the ultra-strict guidelines on versioning in regards to pre-releases (Alpha, Beta, and RC).
The current rules for compatibility are:
For X.Y.Z-PRERELEASE+BUILD:

BUILD does not impact compatibility at all
Per the SemVer 2 spec, if a version has a PRERELEASE flag, it is incompatible with everything but an identical version. This includes RC pre-releases.
Z releases are considered compatible
X and Y releases are currently considered incompatible

So...

2.0.0-alpha.1 ONLY matches 2.0.0-alpha.1
2.0.0 and 2.0.999999 are compatible
2.0.0 and 2.1.0 are currently incompatible (we may change this. We figured we'd start strict)
2.0.0 and 3.0.0 are incompatible

Hopefully, that means that as soon as 2.0.0 comes out, your lives should get easier.
As we work on 2.1.0, we'll test our assumptions about compatibility across minor (feature-only) releases.

Thanks @technosophos - that helps to explain this.  We're on the cutting edge so we've pretty much been using alpha and rc pre-release builds only.  So as long as the major.minor.patch versioning works as expected, when we get to those we should be good to go.  Thanks for the info.

We've been testing this with the 2.0.0/2.0.1 branches, and I believe all is working as I described above. So I'll mark this as closed.

I got stuck on this error:
Error: incompatible versions client[v2.7.2] server[v2.6.1]

Fix/workaround was to run this:
helm init --upgrade

As faintly hinted by the output of running helm init which said.

Warning: Tiller is already installed in the cluster.
(Use --client-only to suppress this message, or --upgrade to upgrade Tiller to the current version.)

That parenthetical statement is actually the important part. An additional warning should highlight the version mismatch, and suggest more strongly to run --upgrade.

Am I safe to assume this was on Azure?

My incompatible versions issue was on MacOS where my kubernetes-helm was installed via HomeBrew.

righto, but which cloud provider were you deploying tiller to? :)

AWS.

My team is hitting exactly the issue @markhu described above: developers are running brew upgrade to get routine updates, getting a newer Helm client package, and then getting messages they don't understand like
Error: incompatible versions client[v2.9.0] server[v2.8.0]

Can Helm make a reasonable effort to interoperate with older versions of itself?  This gets to be a big issue when we have multiple clusters and multiple users and Homebrew is the principal path to getting a Helm client binary.

Still happening even today. Did a brew upgrade just now and it broke helm, now getting Error: incompatible versions client[v2.10.0] server[v2.9.1]. @technosophos Can you re-open this issue?

I left a long explanation of why we do things the current way on #4549

I had the same error as @yuchaoran2011
$ helm list
Error: incompatible versions client[v2.10.0] server[v2.9.1]

Updating the server wasn't an option for me so I needed to brew install a previous version of the client. I hadn't previously installed client[v2.9.1] (or any previous client version) and thus couldn't just brew switch kubernetes-helm 2.9.1. I ended up having to follow the steps in this SO answer: https://stackoverflow.com/a/17757092/2356383
Which basically says

Look on Github for the correct kubernetes-helm.rb file for the version you want (2.9.1 in my case): https://github.com/Homebrew/homebrew-core/search?q=kubernetes-helm&type=Commits
Click the commit hash (78d6425 in my case)
Click the "View" button to see the whole file
Click the "Raw" button
And copy the url: https://raw.githubusercontent.com/Homebrew/homebrew-core/78d64252f30a12b6f4b3ce29686ab5e262eea812/Formula/kubernetes-helm.rb

Now that I had the url for the correct kubernetes-helm.rb file, I ran the following:
$ brew unlink kubernetes-helm
$ brew install https://raw.githubusercontent.com/Homebrew/homebrew-core/78d64252f30a12b6f4b3ce29686ab5e262eea812/Formula/kubernetes-helm.rb
$ brew switch kubernetes-helm 2.9.1

Hope this helps someone.

It is difficult to accept that people are automatically upgrading working server versions when using the client. Why is this the recommended approach? What if the server upgrade breaks something in the cluster? Seems extremely naive to trigger a server upgrade every time before using the client.


improve discoverability, fine tune default values for editor save & format alerts/audio cues

When something is cleared, by default, we now alert and there is an optional audio cue. I am not sure if that audio cue is discoverable.
When a file or notebook is saved / formatted, it's a bit trickier because we have: userGesture, always, or never as the values for audioCues.save, audioCues.format, accessibility.alert.save, and accessibility.alert.format.
Including these in the editor's help dialog will increase discoverability.
There's also interplay as when a document is saved, it is sometimes also formatted.
All of these settings will be in insider's tomorrow, and I intend to test out combinations and would appreciate feedback from @jooyoungseo and @rperez030 also as we consider the best default experience.

cc @Afre100 all sounds will be in insider's tomorrow

In this gif, with audio, there are 3 sounds:

I run Format Doument, the format document sound is played
I make a change, no formatting needs to happen, I save the document, the save sound is played
I make a change that will require formatting, I save, the format and save sounds are played

In case 3, is the sound clear enough so that one can tell both have happened? We currently don't have any queueing infrastructure to allow for a delay between them. And I wonder if adding a delay would make things more confusing than just playing them simultaneously?
https://github.com/microsoft/vscode/assets/29464607/be8af503-3cc6-4d6b-b536-e2712659981f

In case 3, is the sound clear enough so that one can tell both have happened?

I believe I could only tell them apart because I was expecting it and had to play it twice. I also agree that adding a delay would be confusing, even assuming that people know what the sounds mean. I would suggest having accessibility.alert.save and accessibility.alert.format on by default, whether we play the audio cues or not.

Thanks, Roberto. I'm going to take a look at differentiating these a bit more through some filtering/eq modulations

We will now alert for both format and save by default always. IDK if this will be too noisy for users.
Still need to add the cues to the help dialog.

@rperez030 to clarify, even if the delay were set to a playback of rapid succession, and one can at least sense that two different sound transients happened, do you feel it'd still net out at being worse than simultaneous playback?

@meganrogge Re playback hierarchy, I've been trying to learn how much of an issue this is out in the wild, and how often simultaneous playback occurs on average. Do you have any sense, in general, how much of an issue this has been?

It can happen a decent amount depending on the context @afre100. For example, we have format on save enabled by default in our VS Code workspace settings for typescript and javascript.


SwiftUI Support

Hi,
How can i use this library in SwiftUI ?

@Rajeevkallalu97 @yusufonderd I am using Voice Overlay iOS in SwiftUI but it is not very stable. Did you find any alternate solutions?


Merge envoyproxy/envoy master into serverglen/envoy master branch

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

confirm


df.interactive() fails on a pandas DataFrame that has 'interface' in df.columns

ALL software version info

holoviz_tutorial (see: https://pyviz-dev.github.io/holoviz/tutorial/Setup.html) on Windows 10

Description of expected behavior and the observed behavior
Expected: executing interactive() on a pandas.DataFrame should return an interactive pandas DataFrame that I can use with widgets. This should be true for any column name specified in the DataFrame.
Observed: interactive() fails on a pandas.DataFrame object that includes a column named interface.
Complete, minimal, self-contained example code that reproduces the issue
import hvplot.pandas
pd.DataFrame([1,2,3], columns=['interface']).interactive()

Stack traceback and/or browser JavaScript console output
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-11-dff52aeb506d> in <module>
      1 import hvplot.pandas
----> 2 pd.DataFrame([1,2,3], columns=['interface']).interactive()

~\Projects\holoviz_tutorial\envs\default\lib\site-packages\hvplot\pandas.py in <lambda>(self)
     17     setattr(pd.Series, name, plot_prop)
     18
---> 19     _patch_interactive = lambda self: Interactive(self)
     20     _patch_interactive.__doc__ = Interactive.__call__.__doc__
     21     interactive_prop = property(_patch_interactive)

~\Projects\holoviz_tutorial\envs\default\lib\site-packages\hvplot\interactive.py in __init__(self, obj, transform, plot, depth, loc, center, dmap, inherit_kwargs, max_rows, **kwargs)
     83         self._max_rows = max_rows
     84         self._kwargs = kwargs
---> 85         ds = hv.Dataset(self._obj)
     86         self._current = self._transform.apply(ds, keep_index=True, compute=False)
     87         self._init = True

~\Projects\holoviz_tutorial\envs\default\lib\site-packages\holoviews\core\data\__init__.py in __init__(self, data, kdims, vdims, **kwargs)
    339
    340         validate_vdims = kwargs.pop('_validate_vdims', True)
--> 341         initialized = Interface.initialize(type(self), data, kdims, vdims,
    342                                            datatype=kwargs.get('datatype'))
    343         (data, self.interface, dims, extra_kws) = initialized

~\Projects\holoviz_tutorial\envs\default\lib\site-packages\holoviews\core\data\interface.py in initialize(cls, eltype, data, kdims, vdims, datatype)
    206
    207         # Process Element data
--> 208         if (hasattr(data, 'interface') and issubclass(data.interface, Interface)):
    209             if datatype is None:
    210                 datatype = [dt for dt in data.datatype if dt in eltype.datatype]

TypeError: issubclass() arg 1 must be a class

Screenshots or screencasts of the bug in action

Thanks for the report! Seems like we should first be checking if data.interface is a class, and only call issubclass on it if it is. Would you be up for making such a change to hvplot?  If not, I think we'll be able to take care of it...

Sure, I can implement this in a new branch and create a pull request. Are there any special contribution guidelines?

Great! The only guidelines here would be to make sure it's a clean diff (no extraneous whitespace changes, etc.) and to add a test for this case if possible (or we can do that if the tests are daunting). The test case would need to fail right now but pass after the fix!

I implemented a fix in holoviews/core/data/interface and also added a test that succeeds only after the fix. However, I do not have access rights to push the created fix-core-data-interface branch to holoviews. How can I add the fix to origin?

Great! Please open a PR with those changes: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request


fmt.Errors replaced by github.com/pkg/errors for grpc, http, logger, …

…messaging and metrics
Description
Please explain the changes you've made
Issue reference
References : #1954
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@youngbupark @yaron2 please review/merge this


Adds proof harnesses for aws_byte_cursor_eq* functions

Description of changes:

Updates implementation of aws_byte_cursor_eq* functions with pre- and post-conditions;
Adds proof harnesses for aws_byte_cursor_eq* functions;

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@justinboswell @JonathanHenson @ColdenCullen @graebm could you review the changes in byte_buf.c?


Improve user and script-usage by having consistent flags that would disable "pretty" features and prioritize JSON responses

Currently our scripts have different flag for usage by people that focuses on improving DX (emojis, statuses, progress bars, using non-JSON for display), and others like the models have a flag to display in parsable JSON syntax.
We should settle on consistent global flags that users can turn on when using scripts or in CI that would disable all pretty features and focuses on parsability.
We should also have a better exposed interface that users can track to understand breaking changes and what values they can retrieve from the outputs.

bump to this issue for #362 review 🙏🏻

I think, we have JSON responses for almost all the commands, could you give any example command output (that might be needed in CI or script) that doesn't give out the JSON res.?


[Feature]: Make chips behaviour match the new Mushroom-inspired badges.

Requirements

[X] I have updated Mushroom to the latest available version
[X] I did a search to see if there is a similar issue or if a pull request is open.

Is your feature request related to a problem?
I am not sure if this is a bug or expected behaviour. If nothing else it highlights a difference between the new Badges (that are styled like Mushroom chips) and the Chips themselves.
I have a 5 min countdown timer (helper) that I use for turning off my garage lights. When I use a badge to show its state, when it is idle it shows the state "idle", and when it is actively counting down the badge displays the countdown.
When I attempt to do this using a chip (as I don't want the countdown at very top of my dashboard), instead of showing the actual countdown time, it shows the state "Active" while the countdown is progressing and "Idle" when it is inactive.
I am sure there is a way to template this, but that is not what I am looking for.   I am simply reporting that the new badge behaviour is different than that of a chip.
Describe the solution you'd like
Looking at my dev tools page when the counter is active, it appears that the badge automatically picks up the time and calculates and displays the remaining time.

Badge:

Chip:

It would be nice if the chips behaviour matched the badge, or better yet give the chips the power to display any of the attributes as desired.
If nothing else, what the badge does on its own is interesting. I would have assumed it would simply show the state as the Chip does by default.
fj
Describe alternatives you've considered
No response
Additional context
No response

it would be also nice when chips can have a lable


RHEL6 - libdwarf-devel and libmpc-devel installation failures

failed: [test-softlayer-rhel69-x64-1] (item=libdwarf-devel) => {"changed": false, "failed": true, "item": "libdwarf-devel", "msg": "No package matching 'libdwarf-devel' found available, installed or updated", "rc": 126, "results": ["No package matching 'libdwarf-devel' found available, installed or updated"]}
ok: [test-softlayer-rhel69-x64-1] => (item=libffi-devel)
ok: [test-softlayer-rhel74-x64-1] => (item=expat-devel)
failed: [test-softlayer-rhel69-x64-1] (item=libmpc-devel) => {"changed": false, "failed": true, "item": "libmpc-devel", "msg": "No package matching 'libmpc-devel' found available, installed or updated", "rc": 126, "results": ["No package matching 'libmpc-devel' found available, installed or updated"]}

It's there on our other two CentOS machines, but not on this one, so there's something different in the repositories:
[ansible@sxat470p AdoptOpenJDK_Unix_Playbook]$ ssh<EMAIL_ADDRESS>yum search libdwarf
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile
 * base: mirror.sjc02.svwh.net
 * epel: sjc.edge.kernel.org
 * extras: mirror.scalabledns.com
 * updates: mirror.sfo12.us.leaseweb.net
============================ N/S Matched: libdwarf =============================
libdwarf-devel.i686 : Library and header files of libdwarf
libdwarf-devel.x86_64 : Library and header files of libdwarf
libdwarf-static.i686 : Static libdwarf library
libdwarf-static.x86_64 : Static libdwarf library
libdwarf.i686 : Library to access the DWARF Debugging file format
libdwarf.x86_64 : Library to access the DWARF Debugging file format
libdwarf-tools.x86_64 : Tools for accessing DWARF debugging information

  Name and summary matches only, use "search all" for everything.
[ansible@sxat470p AdoptOpenJDK_Unix_Playbook]$ ssh<EMAIL_ADDRESS>yum search libdwarf
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile
 * base: mirror.atlanticmetro.net
 * epel: mirror.texas3006.com
 * extras: mirror.ash.fastserv.com
 * updates: mirrors.seas.harvard.edu
============================ N/S Matched: libdwarf =============================
libdwarf-devel.i686 : Library and header files of libdwarf
libdwarf-devel.x86_64 : Library and header files of libdwarf
libdwarf-static.i686 : Static libdwarf library
libdwarf-static.x86_64 : Static libdwarf library
libdwarf.i686 : Library to access the DWARF Debugging file format
libdwarf.x86_64 : Library to access the DWARF Debugging file format
libdwarf-tools.x86_64 : Tools for accessing DWARF debugging information

  Name and summary matches only, use "search all" for everything.
[ansible@sxat470p AdoptOpenJDK_Unix_Playbook]$ ssh<EMAIL_ADDRESS>yum search libdwarf
Loaded plugins: product-id, search-disabled-repos, security, subscription-
              : manager
No Matches found
Warning: No matches found for: libdwarf
[ansible@sxat470p AdoptOpenJDK_Unix_Playbook]$

The failing machine did not have the yum-plugin-fastestmirror unlike the others but using that doesn't appear to make a difference - have removed it again.

The test machine that failed is RHEL rather than CentOS and the RHEL playbooks don't add the EPEL repo by the look of it. I'll get that fixed - thanks.


remaps behaving weirdly with key combinations

I have the following remap
[bloc maius] ~ [esc]
When i press capslock, the remap works as expected: esc is pressed instead of capslock
However, pressing the combination of any key + capslock, will trigger the real capslock.
This doesn't happen all the times, only after capslock has been pressed alone.
For example, if i type in sequence these keys:
capslock  ->  esc is pressed
a+capslock -> a is pressed, capslock toggles
a+capslock -> a is pressed (capslock doesnt toggle anymore)

Hi @robalb,
Thank you very much for reporting!
 The only problem with your combination is that A key is not a Modifier Key (MK) used within a shortcut:
void QuickCutConsoleWindows::sendInput:
        switch (key.getKeyCode())
        {
            case VK_LEFT:
            case VK_UP:
            case VK_RIGHT:
            case VK_DOWN:
            case VK_RCONTROL:
            case VK_RMENU:
            case VK_LWIN:
            case VK_RWIN:
            case VK_APPS:
            case VK_PRIOR:
            case VK_NEXT:
            case VK_END:
            case VK_HOME:
            case VK_INSERT:
            case VK_DELETE:
            case VK_DIVIDE:
            case VK_NUMLOCK:
                input.ki.dwFlags |= KF_EXTENDED;
                break;
        }

hence it's printed out. If you use that key within a Key Shortcut (mapping multiple keys to key/s), we still need to let the operation system process the key as a regular key, since we can't determine whether the user was actually wanting to use A key for mapping or regular typing. Only in a scenario where it's a single Key mapped to a Key, we know for a fact that we can block this specific key before it's being processed to simulate the key mapping. That's one of the main reasons why the operation system does not support mapping shortcuts.
Another scenario to explain above, imagine I do this kind of mapping:
A + B + C to ESC, we shouldn't swallow these keys, because if the user was actually wanting to type aba and not abc, if we swallow these keys the user won't be even able to even type.
That being said, if I map a none MK + MK to some key, e.g.:
A + CAPS-LOCK = A will be outputted and CAPS-LOCK will be swollen/ignored (since it was the last key down press), but if it were the other way around, CAPS-LOCK + A will result in A not being printed:
void QuickCutConsole::onKeysDown:
        QString srcKeyCodes = action->getSrcKeysCode();
        if (downKeyCodes == srcKeyCodes) // We have a match
        {
            Action::ActionType actionType = action->getType();
            if (actionType == Action::ActionKeyMap)
            {
                qDebug() << "Mapped keys -> " << qPrintable(downKeyCodes) << " ~ "
                         << qPrintable(action->getDstKeysCode());

                *outSwallowKey = true;
                // Send KeyUp to the current pressed keys before manipulating the fake keys.
                sendInput(action->getSrcKeys(), KeyboardHook::KeyUp);
                if (action->getDstKeys().count() > 1)
                    sendInput(action->getDstKeys(), KeyboardHook::KeyPress);
                else
                    sendInput(action->getDstKeys(), KeyboardHook::KeyDown);
            }
....

As you can see from this snippet, with a single key mapping (Key ~ Key), we can still swallow the event triggered, because we know that this specific key equals another key, hence we send KeyDown event. That's why for multiple keys combinations we send a KeyPress event, because if we have a shortcut key match, we let the operation system release the keys like as the user stopped holding the keys (since they were already processed by QuickCut).
I remember when I was initially implementing this, I was thinking about adding a Check-Box for letting users decide whether to swallow all keys specified for the shortcut (which is not very common) in the Action creation window. So if it's checked and you do this mapping for example A + B + C to ESC will result in A, B, C  keys to be disabled, so even if the user just pressed A it will be blocked. This is not a very common thing to do, hence if someone will bring good reasoning for this, I'll be ok to add this as a future feature.


Crash with newer betas of Curios

Crash Log
(The Lightman's Currency stuff is from the Armor Trader, which places an armor stand when placed).
It looks like some API stuff has changed.

Version 1.16.5-2.2.0 should fix this, you probably missed it because I initially marked it as beta on curseforge (It seems the curseforge launcher doesn't always download those). I've changed the Release Type from Beta to Release to avoid this issue, thanks for letting me know.


[Feature] Strategically Engineering Wide Tables with Foreign Key-Based Joins

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
When performing a join operation with Flink's dual stream join, there is an issue with excessive state storage. Flink Lookup Join only concerns itself with changes in the primary stream; changes in the dimension table cannot update data that has already been joined. With Partial Update association, there is a problem where the joined tables need to have a common primary key to ensure matching between two or more data sources. All the aforementioned solutions for generating wide tables through multi-table associations have their limitations.
I would like to implement an entirely new method to overcome these shortcomings: a dynamic dimension table-driven Lookup Join, which I also refer to as 'ForeignKey Widening'.
https://cwiki.apache.org/confluence/display/PAIMON/PIP-12%3A+Strategically+Engineering+Wide+Tables+with+Foreign+Key-Based+Joins
Solution
No response
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

@MonsterChenzhuo whats the status of this? It's a pretty amazing and useful feature

@MonsterChenzhuo whats the status of this? It's a pretty amazing and useful feature

+1，Are there any plans for release version？


ClusterHost is an incorrect parameter / term for url creation

/kind feature
Which functionality do you think we should add?
--clusterHost should be --host for odo url create.
Why is this needed?
ClusterHost parameter for url creation is an incorrect parameter term.
The term Cluster Host in kubectl and oc is confusing because Cluster Host actually means Kubernetes / OpenShift "host".
It is confusing because we are specifying a domain name for url creation.. ex: odo url create --clusterHost example.domain.com
We should be using the correct term which would actually be host, which is exactly what OpenShift uses in the yaml creation for Route.
For example, the current code that is implemented looks like this:
				Host: ingressParam.IngressDomain,

Ping @yangcao77 @kadel @GeekArthur

/assign
/area devfile

The host we want user to specify is the cluster host, not the entire domain.
If the domain we want is example.domain.com, then the command should be
odo url create example --clusterHost domain.com

"Cluster Host" is a different definition as "host" or ingress. "Cluster Host" is also not used at all within Kubernetes / OpenShift YAML.
If you want to define an ingress domain, it should just be host similar to Kubernetes / OpenShift YAML definitions.
I agree to switching it to just --host.


Allow to show close button over icon on the left

Right now tabs in vscode look like this, with the file icon on the left, and the close button always visible (for the active tab) on the right:

Has their been any discussion of possibly changing this in a couple ways:

Remove the X close icon on the right, including the space reserved for it.
Make the file icon on the left turn into the X close icon when the user is mousing over the tab.

If the above changes were made, there are some benefits:

All tabs will take up less room, because no space is reserved for the close button.
Closing sequential tabs is easier, as you can place your mouse over the left side close button, tap close, and the next tab slides over with the close button directly under your mouse, so you may continue closing tabs. (I'm aware of the various Close Tab options available if you right-click on a tab, but sometimes you just want to quickly close a sequence of tabs.)

The only downsides I can think of:

Might not adhere to some platform UI guidelines. ¯\_💩_/¯
User has to mouse over the tab to discover where the close button is. However they probably only need to do this one time before they understand the layout.

Yeah the Opera UI you show above is exactly what I had in mind.
FWIW, Safari has the close button on the left, which makes rapidly closing tabs a lot easier. Safari only recently added the ability to even show the favicon in the tab, and it's not there by default, so it's not surprising they have not adopted Opera's technique, at least year.

One issues that does come up with this is that we also use the close button space to show an unsaved file (dot):

An alternative would be to use the asterisk (*) for unsaved, which would give you:

Please keep in mind that many people have icons disabled, so the design would have to work when icons are turned off.

I think it could still work, we'd just not show the icon and adjust the spacing so it's even:

Another option would be to make the tab font bold if the file's been modified.

@winzig someone reminded us that we do have a setting, workbench.editor.tabCloseButton, that moves the close button to the left hand side:

We also internally discussed the option above (swapping the seti icon with the close button on hover) and decided that it wasn't a good idea due to our implementation when the close button is set to the left that users are used to seeing the dirty state in that same location:

If you still think this is feature you'd like for us to consider we can leave this open, otherwise we can close this.

OK that resolves my primary issue (being able to close sets of tabs more rapidly).
I think some optimization could be done to combine the icon/close/dirty indicator into a single location, which would make tabs smaller, and therefore let you fit more into a smaller space. Maybe via an option to let the user choose whether to combine them or not.
Most of the time I have a bunch of file tabs open, but only a couple are dirty. In those cases, the fact that they are dirty is more useful to me than seeing the filetype icon, so if I had my druthers, it would work like this:

Default (file type icon visible)
Mouseover (icon replaced with X)
Dirty (icon replaced with dot, no mouseover required)

But if this idea is not popular then we can close this out.

Actually, poking around the settings, I personally would turn on the highlight over tab option for dirty files, and skip the dot completely. So you either see the app icon, or when mousing over, the close button, no dot.
Perhaps there is a way to enable that as an option at some point.

In that case I’ll leave this open as a feature 😄

I noticed a  flag in Edge Canary to do exactly this.  I came here to request this very thing. The implementation is excellent. I'd love to have this behavior in Code.

Actually, poking around the settings, I personally would turn on the highlight over tab option (Workbench › Editor: Highlight Modified Tabs) for dirty files, and skip the dot completely. So you either see the app icon, or when mousing over, the close button, no dot.

Perhaps there is a way to enable that as an option at some point.

Exactly, this behavior please.


bump operator base image

we are doing the same for kiali. See: https://github.com/kiali/kiali/issues/5459

Test passes:
make -e MOLECULE_SCENARIO="config-values-test" cluster-push operator-create molecule-test


Codegen the BuiltinRegistrywith a build plugin

What might be nice is to codegen the BuiltinRegistry with a build plugin, it may cut down on merge conflicts there. I think
the list of available modifiers in platform.ex could potentially be removed as well.

Discussion from Slack: https://dockyard.slack.com/archives/C02E1GA5THB/p1681320231157239

FYI @bcardarella @dginsburg @carson-katri @supernintendo


feeat: merge connections, extensions and steps

Merge connections, extensions, and steps when showing a list of possible connections when adding a step to an integration.

I think we are missing some asset in our codebase.
TODO

[ ] filter steps based on the current position.
[ ] hook all the kinds to an href returner.

That is a very promising gif :smile_cat:

Damn it looks like something changed on the BE side, and it breaks the apis. I had them already compiled and didn’t got the error on my end :(

we'll need to rebase our fork I think.

So the missing model has been moved to the internal swagger.json, so I added that to the models package too. Since I was there, I also resynced all with upstream and we have the new assets.

Works for me, great!

PR Storybook available here

Maybe better merge this and I’ll address the todo later?


changing the change highlight color

Well I guess if we have the designer's blessing! :ship: :it: :smile:


Command 'az vm boot-diagnostics get-boot-log' is failing

Command Name
az vm boot-diagnostics get-boot-log
Errors:
The command failed with an unexpected error. Here is the traceback:
'RetrieveBootDiagnosticsDataResult' object has no attribute 'done'
Traceback (most recent call last):
  File "/usr/lib64/az/lib/python3.6/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 657, in execute
    raise ex
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 720, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 691, in _run_job
    result = cmd_copy(params)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 328, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/vm/custom.py", line 1555, in get_boot_log
    uris = LongRunningOperation(cmd.cli_ctx)(poller)
  File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 959, in __call__
    while not poller.done():
AttributeError: 'RetrieveBootDiagnosticsDataResult' object has no attribute 'done'

To Reproduce:

az vm boot-diagnostics get-boot-log -n {} -g {}

Environment Summary
Linux-5.3.18-24.43-default-x86_64-with-glibc2.3.4
Python 3.6.12
Installer: RPM

azure-cli 2.24.1 *

Compute


[climate] Bugfix/Tweak honeywell migration

Breaking Change:
~The entity_id is changed - now set to a sets a unique/persistent device ID.~
This has been removed - there is no breaking change now.
Description:
Changes:

Changes consistent with https://github.com/home-assistant/architecture/issues/264
DEBUG logging now includes all state data (_LOGGER.debug("latestData = %s ", device._data))
Adds demand response state to device_state_attributes as per #25311, and feature request
sets the correct outer bounds for min/max temps
sets a unique/persistent entity_id
bugfix as below issue(s)
Minor refactoring

FWIW, I think the demand response data should have been there in the first place, and is not an enhancement.  It adds these lines of code to device_state_attributes:
if self._device._data['drData']:
    data['dr_phase'] = self._device._data['drData'].get('Phase')

Related issue (if applicable): fixes #25412
Pull request with documentation for home-assistant.io (if applicable): N/A
Example entry for configuration.yaml (if applicable):
N/A - no changes
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

You should also fix the upstream library to remove pylint: disable=protected-access.

I try to remove/reduce these lint hints where possible, such as switching from device._data['uiData' to device.raw_ui_data. In this respect this PR improves the situation dramatically (and I can see where I can take out another).
Unfortunately, the client library is not mine, and has had no changes for >2 years.  The owner is around, though...
But in fact, honeywell is nothing to do with me, really, I only got involved because someone stuck Honeywell US and Honeywell International (which uses the evohome client library) together in the same integration & I wanted to pull the international bit out. I don't even have regular access to any Honeywell systems...
Sorry, I have no appetite/time for fixing this client library.
Is it OK to accept this PR as is, given that it is much better than it was?

@pvizeli OK to go now, thanks.


Parsing dates doesn't work

According to #35 - we should have support for Date types implemented.  But this doesn't work:
import { JSON } from "json-as/assembly";

@json
class Foo {
  timestamp!: Date;
}

const foo = JSON.parse<Foo>("{\"timestamp\":\"1999-12-31T23:59:59.999Z\"}");

When compiling, I get:
ERROR TS2322: Type '~lib/date/Date' is not assignable to type '~lib/wasi_date/wasi_Date'.
     :
 294 │ return Date.fromString(data);
     │        ~~~~~~~~~~~~~~~~~~~~~
     └─ in ~lib/json-as/assembly/src/json.ts(294,12)

FAILURE 1 compile error(s)

Ah, just noticed the detail of the error.  It's because I'm using the AssemblyScript WASI Shim.  If I remove it, then it compiles.
Any ideas how to work around?

Looks like I can switch back to the normal Date object with:
import { Date } from "date";

Of course that means I can only use the original implementation of Date.now, instead of the WASI implementation, but I think I can just ensure my host exports Date.now properly and ignore that aspect of WASI.  (Or just get rid of WASI altogether, perhaps.)

Yeah, I have run into this problem before. I'll look into it though. I believe it has something to do with the transform using Date and then the compiler's pass overriding Date to wasi_Date. I'd recommend you ask in the assemblyscript discord server though

Can you import the wasi_Date directly?
import  { wasi_Date } from "@assemblyscript/wasi-shim/assembly/wasi-date"
https://github.com/AssemblyScript/wasi-shim/blob/4399cffa93a70da3a48b30c55d90414be7ec8dc0/assembly/wasi_date.ts#L15

Actually, I acted to soon to close the issue.  Even without the WASI shim, I still can't deserialize an object containing a date to a Date field.  At runtime, I get:
abort: Could not deserialize data 2023-11-16T04:06:35.108285303Z to type Date. Make sure to add the correct decorators to classes. in ~lib/json-as/assembly/src/json.ts(297:5)

Can you import the wasi_Date directly?

Doesn't help.  It's not the Date type that as-json uses, so it's mismatched.  But as I said, I can live without the WASI implementation.  I just need it to work with the regular Date object without giving an error.  Thanks.

Fixed this problem in https://github.com/JairusSW/as-json/commit/2c07ef2dd8eeee1bf4a3d95c2316a6d9709bd2db
Changes are live on NPM (v0.6.0)

Fixed.

I tested and it works, but I don't think you want to pull in the whole date parser.  Please consider #55 instead.
In particular, the date parsing logic has some errors when presented with strings having more than 3 decimal places of fractional seconds.  It also doesn't handle ISO strings containing time zone offsets.  Both of those issues are better handled in the AssemblyScript repo.  I'll send a PR there.  Thanks.

FYI - I sent a PR to AssemblyScript to fix the issues I mentioned.
https://github.com/AssemblyScript/assemblyscript/pull/2803

Merged and published


Support Python 3.12

Closes #39.

Upgrade torch versions, so now Python 3.12 is supported

Don't merge into main from issue branch. Don't have a lot of github action minutes so they need to be used sparingly

Right, got it. As for saving GitHub Actions minutes, I suppose we can make it more efficient by only installing dependencies and running the tests for Python 3.10. Since newer versions should be backward compatible, we might be able to get away with just checking if the dependency constraints can be satisfied without actually downloading any packages.

Yeah I'll also probably name the branch the version number instead of dev, that will be clearer I suppose


RDMO 2.0.2

CHANGELOG:

Fix migration to RDMO 2.0 for PostgreSQL
Fix Shibboleth urls
Fix issue view
Fix margins in management interface

coverage: 80.917% (+0.3%) from 80.581% when pulling 6fe03f693acb1bb2c818c26521600bd1c94bc9d7 on dev-2.0.2 into bb5f093e873ccf36729480fdab9ef045a5b98ddf on master.

do I need to double-check this??


Switch to dune language 1.0

When I tried to install ppx_deriving_yojson.3.3 I realized it fails because it specifies dune 1.2 language, but I had dune 1.0 installed. Since the dependency on dune 1.2 is not stated in the opam file, opam doesn't prompt me to install a newer dune.

Have you tested that the various build targets (library and tests) work correctly with dune 1.0?

Yes, they do seem to work. As in: the test run and the make succeeds. I would assume this means it works.
Tested with both dune 1.6.2 (in 1.0 mode) and 1.0.0.

Thinking more about it: it is easier to add a version bound on dune in the opam package (does not require changing the source) than to deploy your patch to users (requires a new release), so I think we will do the former. The PR is still useful for future releases, though, and the report is very helpful.

I see now that the opam-repository was already fixed by you in https://github.com/ocaml/opam-repository/pull/13163. Thanks!

It seems that Dune could help detect such cases, I opened an issue for this: https://github.com/ocaml/dune/issues/1689
BTW, we make sure to provide good backward compatibility, so normally bumping the lower bound on Dune should not be an issue.


Node: "Invalid endpoints format: Cannot read properties of undefined (reading 'split')"

Describe the bug
CI links:
https://github.com/valkey-io/valkey-glide/actions/runs/11701901352/job/32588956465
Expected Behavior
test pass
Current Behavior
test fail
Reproduction Steps
manual run or CI
Possible Solution
No response
Additional Information/Context
No response
Client version used
release-1.2
Engine type and version
.
OS
.
Language
TypeScript
Language Version
.
Cluster information
No response
Logs
No response
Other information
No response

Issue still persist https://github.com/valkey-io/valkey-glide/actions/runs/11738351903/job/32700728123?pr=2633

@Yury-Fridlyand I added --runInBand back, I see that somebody overridden it for some reason. Please add it back.
runInBand makes the tests run one by one, removing it cuts the running time by half.
However, if tests need to have the CLI args, they can't run on different processes.
So, for this case of using a hard-codded cluster passed as a cmd arg, I needed to add it back.
Since currently those are a few tests, it's not an issue. If the test set grows, we will have to rethink it.
In CI, It's normal to run with runInBand so there's less stress on the machine, in our case it makes a lot of different, and it's not a matter of 2–3 minutes, but from 25 min test run to 12.
I profiled behavior to see that we don't have leaks in tests and usage grow, and we don't so we can afford it.
Anyhow, in this case it is not possible unless we come up with an idea how to solve it differently.

Plus — I see the branch is not updated, can you please rebase and run? Maybe nobody added it, its just not updated to latest changes.

will update and observe, but it is a flaky thing. I don't tell that it is not fixed, but to confirm that it is fixed, we need to run CI 100500 times.

I ran full matrix twice before closing it. But it's not it, I reproduced, understood the issue, which wasn't to understand, tried hard to make it work somehow before re-adding, and after failing hardly I added it back, and stress tested it. I'm working with memdb and all, of course.
This one specifically wasn't a flaky, it's me who broke it by removing, and when adding back I fixed.

@Yury-Fridlyand It didn't reoccur. I'll wait another round and close. Can always reopen later.


feat: Initial release of datadog_dio_interceptor plugin

What and why?
Currently there are no Dio interceptors in the repo.
How?
This PR aims to introduce a Dio interceptor to make it easier for anyone using the Dio package to attach Datadog-specific headers to the requests.
Review checklist

[ ] This pull request has appropriate unit and / or integration tests
[ ] This pull request references a Github or JIRA issue

@fuzzybinary, currently there are no tests implemented for this package. I plan to add the tests soon.

Created DOCS-9428 for docs review.

@rtrieu Hold off on docs review until I can take a look at the code.

Hi @a-h-mzd,
We'll need tests before we can accept, but, also, is there a reason this was needed? All cases I've seen of Dio either use the default HttpClient provided with HttpOverrides, or accept a Client from the http package.  Our interceptor provides ways to override both.
Is there a case I don't know of where Dio will not use something we already intercept, or is there additional functionality this would provide?

Hi @fuzzybinary,
You're partially correct. Dio for native uses the default client provided by the overrides, but Dio for browser takes a different approach and uses XMLHttpRequest directly to make the requests. As far as I know, this is done to ensure that the UI thread does not freeze, no matter how heavy and time-consuming the API call is.
And as for tests, I will try to write some as soon as I get the chance.

@a-h-mzd Did you double check that the Browser SDK doesn't already intercept these without going through any Dart / Flutter code? If I remember correctly, it intercepts all XMLHttpRequests by default (and gets more information out of them than we do). If it doesn't that may be the real bug, not the lack of a Dio interceptor.
I appreciate the contributions, but I would always start with an issue in the repo first. Show what you want to do and the fact that it doesn't work, then we can work together to determine what the solution should be (which, in reality, may be this interceptor provided your issue checks out).

@fuzzybinary that is a good point. I will create an issue right away.

@fuzzybinary thank you for your support on this issue. Do you think it’s worth to keep this PR open?

No I think it's better to close it. Our support for Dio flows through HttpOverrides at the moment.


Add APIs to provide project info for a given file

Return the path of the config file and the file name list of the project (optionally). This is helpful in differentiate the build command behavior for loose files and configured projects in sublime.

@mhegazy should look at this as well but :+1:

@mhegazy could you take a look?

Can we add some tests as well. we will need some new fourslash infrastructure to get this going.. i can help out if you want.

LGTM, just a few comments, and a couple more tests needed.


Please help me to convert image from database show in gird

Please help me to convert image from database show in gird

Good question. I have the same issue in one of my projects where I have a small pixel images of flags of all the world's countries saved in my MS SQL table. I would like to show them in a grid or a form next to a filtered country field.
I would really like to know if this can be done easily as I have no clue and can't find any material online.

You might use data uri for this. Another option is to prepare a controller action that fetches images from DB and returns them as content result, so you ll have an image url

@volkanceylan
Please find an example to me.
Thank you

Try searching data uri in google

@volkanceylan
Thank you


Update Target API level to 34

From 31 Aug 2023, if your target API level is not within two years of the latest Android release, your app will not be available to new users running Android versions higher than your app's target API level.

Noticed here https://github.com/Jakeler/Jakeler.github.io/issues/7

You could still install it with the apk, but I am also working on fixing google play with an update.

taking into account that works in progress, would you be able to upload the last version of the APK to the release page section, please
(I see apk only for v1.0)

Yeah good idea, added now 1.4 apk: https://github.com/Jakeler/UT61E-Toolkit/releases/tag/v1.4
Sorry for the inconvenience, these SDK, java and gradle updates change quite a bit - didn't find the time to fix everything.

anyway thanks for what you do


Remove duplicate code from "Acquiring an image ..." section

The code block in the "Acquiring an image from the swapchain" section incorrectly includes code that is discussed in the following sections.

Thanks!


Exercise 6 : Level 4 gameOfLife

Hi guys,
I managed to define the UnaryOperator<List<Integer>> generateRule()  method and I could obtain the next generation using Main.generateRule().apply(list) but I am unsure of how to apply this to the gameOfLife method to obtain all the different generations based of the integer number of generations n of the game. I know that the list is the 1st generation, and rule.apply(list) will get the 2nd generation, and rule.apply(rule.apply(list)) will get the 3rd generation, etc. However, I am unsure of how to keep track or obtain these generations by using a stream. Is there any other possible ways that I could approach this question? Thank you!

Hi! for generation x, I used IntStream.range(1, x).boxed().reduce(...) with a BiFunction that does rule.apply(list) to arrive at the required list for generation x.

Thanks for your help! I followed your approach and was able to come up with a solution.


boards: x86: Add support for Intel Alder Lake boards

Add basic support for Intel Alder Lake CRB and RVP boards

Can we please move away from 3 charachter acronyms to something a bit more verbose? intel_adl or even intel_alderlake. This is starting get very cryptic IMO.

I'm fine with that. I think I'd prefer just adding the intel prefix and the short-hand platform version (i.e. intel_adl). The full name is still visible in documentation, etc. Would be good to try to convert all existing platforms within a fairly short time-window, however, so that we don't end up with some intel_ prefixes and some boards without.
@najumon1980 FYI.

I'm fine with that. I think I'd prefer just adding the intel prefix and the short-hand platform version (i.e. intel_adl).

yes, this is fine.

The board names have now been updated to have an intel_ prefix

@nashif @dcpleung could you please take another look? Thanks.


Resolution Issues

By the 1366*768 resolution, cannot select the last education reform. Can you adjust the height of the cassettes, so it might fit in? Thanks!

Is this for the current github release or the latest public release 1.13?

the latest yet
sorry for not posting in real time
i'll upload a screenshot

Thanks for the bug. Will fix in the next release.

Thanks! ;)
This version? (8hr ago?)

It's not corrected yet. It will be as part of the future 2.00 release.

Hmm...okay :)


LC-311 - duplicate tokens issue

remove update of existing token
remove tokens from db when invalid
removing redundant cache

Closing as no longer following this solution.


Latency allowed by Discord

One more question for the master... Do you have some number of how much latency Discord factors in for music bots? I know the packets requested are 20ms long. But how long is my function allowed to take for returning this packet?
Specifically, on a v-server, I found that even when I isolate (dedicate) a (virtual) CPU core to the task, my code still gets randomly interrupted for up to 100 ms at a time (probably by the hypervisor).

I get this running locally from us to a server in eu. So not just v server.

The threshold where you can notice some slight stutter can be around 100ms. Also did you check that it isn't just GC pauses that cause your code to be "interrupted"? In that case, jda-nas could help you.

Yes I've switched to low-latency GC. All working good actually. Thanks.
On Fri, 6 Nov 2020 at 06:24, sedmelluq<EMAIL_ADDRESS>wrote:

The threshold where you can notice some slight stutter can be around
100ms. Also did you check that it isn't just GC pauses that cause your code
to be "interrupted"? In that case, jda-nas could help you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sedmelluq/lavaplayer/issues/223#issuecomment-722836229,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCPUQYUU4XESWBZ255VVGTSOOCCNANCNFSM4I4BP5QQ
.

--
Stefan Reich
BotCompany.de // Java-based operating systems


VPN keep disconnecting when the device is locked

If i lock my iOS devices for 10s, the vpn will no longer working. Is there a way to keep it alive all the time?
Other VPNs work fine tho

What version of iOS are you using?

@LaxusiC Does the VPN reconnect immediately when you unlock the device? If so, I think I experience the same thing with my iOS device. I think the current behavior is sufficient to prevent ads in my day-to-day browsing, but I am concerned it may allow trackable DNS queries when the device is locked.

Very helpful information here! I would be curious if you can verify under the Query Log and look at what was happening between 1am and 9am. We can have definitive proof if the connection was maintained all night long by checking if "localhost" or your phone's VPN IP were originating those DNS requests overnight.

It appears iOS will disconnect the VPN when the screen is locked. There is evidence the uptime counter in the app may not be accurate. If anybody has data that proves otherwise, please let us know. Closing this issue for now.


Kotlin class properteis are always val

I don't know if this can be considered a general issue but, for me, the fact that all the properties in a kotlin class are generated as val instead of var creates some problems for me.
I've identified that line 336 in src/quicktype-core/language/Kotlin.ts always emits val so, I guess, is not language or "source syntax" dependent.
To create a little bit of context, what I've created is a small project where I can write typescript interfaces (because I am using ts on my backend) and using a single CLI command, a kotlin file (and in the future swift file) with all the data classes definitions is created and published as a library in a private maven repository. This is useful because we are using Firebase and it's more convenient to have the data models as a library for each platform (Android, iOS, and backend) instead of using other channels to communicate the data model changes.
In the Firebase Docs data classes are using var.
I'm new to Kotlin but having the properties as var also makes sense for me, because I want to be able to get (and create objects) and set the values not just get.
Can this be considered a general issue or am I missing anything about quicktype or kotlin?

The same goes for Swift and let vs var properties. Although I've been using QuickType a while, and realize it focuses on a the schema side of a model, rather than the stateful side. e.g. Immutability vs mutable. That said, I haven't had a need for var, with the helpers provided to Swift such as the o.with(...) method.
Off topic a bit, we did end up writing a couple plugins to make things easier, one of those being factories of defaultsForNil, and defaultsForNull (for Kotlin respectively). This is because it's very inconvenient to always specify defaults when your models become quite large. These helpers provide all params as nil or null, and use a default if left that way. It was done this way, because at least at the time of writing the plugins, it wasn't easy or even possible to modify the output of initializers/constructors that QuickType generates.
Back on topic... although we haven't needed mutable models, it would be a great feature for Swift, as it would cut out some boilerplate in a lot of circumstances. This feature could work at least with both TypeScript or json-schema as sources if "readOnly" properties were observed. Probably not all sources, though even for graphql might be possible with custom annotations.

Backward compatible way of doing it would be a cli argument. e.g. --mutable. This flag could change the parser to observe "readOnly" properties as those to be let (Swift) and val (Kotlin), while everything else is var and var. Remove the flag and its back to current behavior.


fix: multi waterfall tooltip abnormal

I want to create multiple waterfall chart with plugins argument, and found this bug.

I need this bugfix，can you publish a new verison ? Thx : )

Done.)


Fixes #151. Volume Provision in orchestration create service lists only block Storage type.

Fixes #151
Orchestration volume provision Profiles drop down lists only blockstorage Type

LGTM


Add date picker element

Overrides the default date_field and date_field_tag helpers from Rails to use the pickadate.js library, which fits quite well with our style (even if the last release from them is completely botched).

Coverage remained the same at 100.0% when pulling a0ac7d4cce1351e16be6b09360c7a41c93f9a07c on feature/datepicker into dd37703801b0e9da85ca476c0fe6c1006f38ea45 on develop.

Coverage remained the same at 100.0% when pulling a0ac7d4cce1351e16be6b09360c7a41c93f9a07c on feature/datepicker into dd37703801b0e9da85ca476c0fe6c1006f38ea45 on develop.

Coverage remained the same at 100.0% when pulling d27b17095205560aac7f1a0456660d07f226f853 on feature/datepicker into dd37703801b0e9da85ca476c0fe6c1006f38ea45 on develop.

Travis is clearly working but I am hitting the following locally https://gist.github.com/bradleybeddoes/478dd83a1e07c7bacc92 thoughts?

Well, Travis isn't running the Rails sample app so this is probably legit... But then, it works over here.
The error seems to be in direct conflict with the output of bundle install. I'll do some more testing here to see if I can reproduce it.

Coverage remained the same at 100.0% when pulling 2f1f7e36c4b6b1f0f2d8a3d49490e607df3e7d4e on feature/datepicker into dd37703801b0e9da85ca476c0fe6c1006f38ea45 on develop.

Upgrading 2.2.0 to 2.2.1 fixed the issue for me.


FormsPlot null reference exception in .NET Core 3.0

Creating new FormsPlot throws null reference exception.
Version:
NuGet package: 3.1.4
SDK:
dotnet core 3.0.100
Code:
this.FormsPlot = new ScottPlot.FormsPlot();
CallStack:
   at ScottPlot.FormsPlot.Render(Boolean skipIfCurrentlyRendering, Boolean lowQuality)
   at ScottPlot.FormsPlot.PbPlot_SizeChanged(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnSizeChanged(EventArgs e)
   at System.Windows.Forms.Control.UpdateBounds(Int32 x, Int32 y, Int32 width, Int32 height, Int32 clientWidth, Int32 clientHeight)
   at System.Windows.Forms.Control.UpdateBounds(Int32 x, Int32 y, Int32 width, Int32 height)
   at System.Windows.Forms.Control.SetBoundsCore(Int32 x, Int32 y, Int32 width, Int32 height, BoundsSpecified specified)
   at System.Windows.Forms.Control.ScaleControl(SizeF factor, BoundsSpecified specified)
   at System.Windows.Forms.Control.ScaleControl(SizeF includedFactor, SizeF excludedFactor, Control requestingControl)
   at System.Windows.Forms.Control.Scale(SizeF includedFactor, SizeF excludedFactor, Control requestingControl)
   at System.Windows.Forms.Control.ScaleChildControls(SizeF includedFactor, SizeF excludedFactor, Control requestingControl, Boolean updateWindowFontIfNeeded)
   at System.Windows.Forms.ContainerControl.Scale(SizeF includedFactor, SizeF excludedFactor, Control requestingControl)
   at System.Windows.Forms.ContainerControl.PerformAutoScale(Boolean includedBounds, Boolean excludedBounds)
   at System.Windows.Forms.ContainerControl.PerformNeededAutoScaleOnLayout()
   at System.Windows.Forms.ContainerControl.OnLayoutResuming(Boolean performLayout)
   at System.Windows.Forms.Control.ResumeLayout(Boolean performLayout)
   at ScottPlot.FormsPlot.InitializeComponent()
   at ScottPlot.FormsPlot..ctor()
   at WindowsFormsApp1.Form1.InitializeComponent() in C:\Projects\sharpa\test\WindowsFormsApp1\Form1.Designer.cs:line 33
   at WindowsFormsApp1.Form1..ctor() in C:\Projects\sharpa\test\WindowsFormsApp1\Form1.cs:line 17
   at WindowsFormsApp1.Program.Main() in C:\Projects\sharpa\test\WindowsFormsApp1\Program.cs:line 20

Hi @petarpetrovt, thank you for providing these details! I think this issue has been fixed as part of #131 within the last week, but not yet published on NuGet.
Would you be up to downloading the latest source from GitHub and referencing ScottPlot that way? I'd be interested to know if this fixes your problem!

Hi @swharden, i build the source and replaced in my project.  The same error continues.
ScotPlot.dll -> 3.1.5 version

Hi @petarpetrovt thanks for looking into it!
I can replicate this error on my system, but the error only affects .NET Core (not .NET Framework) applications. The missing object is lastInteractionTimer, and @StendProg might be able to provide more some insight here.
I just added a null check to the master branch (350f5cf7b06db378b38635ae4ebcc9123cfe444e) which fixes this issue on my system. Does this fix your problem as well?

Hi @swharden the null check seems to have fixed the problem.

Hi @swharden the null check seems to have fixed the problem.

This is great news! I'll include this fix with the next NuGet release. Thanks again for raising this issue

This issue arose again (as pointed out by @petarpetrovt in #189) after the WinForms control was re-written from scratch (probably affecting all versions from 4.0.0 - 4.0.6).
The cause of this issue is that FormsPlot.plt is null when a SizeChanged event is triggered. This is highly unexpected because the constructor of FormsPlot initializes FormsPlot.plt. I do not understand how .NET Core 3.0 WinForms control events can be called before the controls themselves are initialized, but adding a null check fixed the issue (again).
To ensure the WinForms control continues to work in .NET Core 3.0, a WinFormsCore Quickstart project was added to the demos folder.


how to integrate users / include user info in completion

It would be super helpful to have some documentation around how to include user info in the completions. The sidebar display seems to be prepared to read a createdBy key from the completion, however this information does not seem to be retrieved from my actual completion json file.
The example in the readme seems to indicate that one is supposed to include the user information in the front end to be passed with the completion submission. However, this doesn't seem like the right approach, since this would be imminently hackable by a malicious user. Instead, I have injected the current user's information into the completion object in a modified completion endpoint in the API on the server side. However, as stated above, the createdBy key, which now exists in my completion data, does not seem to be getting used in the sidebar display.

Realizing now that this is an issue with the way the server code is designed. There is a conversion that happens in the lsb Javascript in the server repo that converts the created_username to createdBy for the frontend.


Need to fix dependabot  alerts

Fixes #130

Can we get yarn updated to 4.x from 1.x in the CI?

Need to sign my commit (new computer, who dis?)


K8s lb

Waiting for https://github.com/cilium/cilium/pull/109 to be closed

Still waiting for #109 but after it's merged the changes on this PR will be minimal.

Can you split out the KVStore abstraction into a separate PR?

@aanm Do you want to merge this before we hook it up to the BPF maps? That's fine but it must be mentioned in the commit message.

@tgraf If that's ok from your side then yes. The 2nd version of this code (with performance improvements) could be made on a different PR.

Fine with me, please leave a note in the commit message.


perlPackages.SysCPU: remove broken attribute

Motivation for this change
Still not back on CPAN but on metacpan.
Proof: Metacpan is in our mirror list and https://cpan.metacpan.org/authors/id/M/MZ/MZSANFORD/Sys-CPU-0.61.tar.gz yields the same hash.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build perlPackages.SysCPU

@GrahamcOfBorg build perlPackages.SysCPU.src


Expose windows overrides object to allow changes before showing the window

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
I just wanted to make sure that the Preferences window would show in the same monitor than the main application, and the way I managed that was to set the x and y correctly on  options.browserWindowOverrides. But this needs to happen every time the show() method is called, so exposiing it is necessary.
Here is the diff that solved my problem:
diff --git a/node_modules/electron-preferences/index.js b/node_modules/electron-preferences/index.js
index babcbc9..aee6e8d 100644
--- a/node_modules/electron-preferences/index.js
+++ b/node_modules/electron-preferences/index.js
@@ -113,6 +113,10 @@ class ElectronPreferences extends EventEmitter2 {

     }

+    get browserWindowOverrides() {
+        return this.options.browserWindowOverrides;
+    }
+
     get preferences() {

         return this._preferences;

This issue body was partially generated by patch-package.

Hi @lvcabral
Thanks for informing us of your manual adaptations.
We can definitely expose the browserWindowOverrides so people can make changes to them as they like during the lifetime of their application. We'll add this in the next release.
However for your solution it might seem more intuitive to pass the correct parent BrowserWindow to the browserWindowOverrides. Then we just need to check the position of the parent window, and adjust the preference window accordingly when the .show() method was triggered.
Would this last solution better suit your needs? Or did you have an even more elegant solution in mind?

Hi @lvcabral
Thanks for informing us of your manual adaptations.
We can definitely expose the browserWindowOverrides so people can make changes to them as they like during the lifetime of their application. We'll add this in the next release.
However for your solution it might seem more intuitive to pass the correct parent BrowserWindow to the browserWindowOverrides. Then we just need to check the position of the parent window, and adjust the preference window accordingly when the .show() method was triggered.
Would this last solution better suit your needs? Or did you have an even more elegant solution in mind?

I'm setting the parent already but how can I adjust the position of the preferences window? The only way I found was this.

This is related to #93, you can use setBounds() to move the browserWindow around. The recent addition allows you to do:
// start of electron main
const ElectronPreferences = require( 'electron-preferences' )
const preferences = new ElectronPreferences(/*... All the stuff */)
let preferencesWindow;
// ...
const createPreferencesWindow = () => {
   preferencesWindow = preferences.show()
	// Now you have an instance of the preferences browserWindow
   // you can call .setBounds()
}

we really need to add a getter method for the preferencesWindow object, and then you'll be able to have access to the window without relying on saving during .show().

Thanks @lacymorrow for the feedback, I was not aware of this new feature. I managed to make it work, but I still think this is no the ideal, as I'm moving the window after the .show() was issued, fortunately (at least in Windows) it is not noticeable any movement of the child window. I will test later on Linux and Mac. We still need to have a way to do this before the .show().

@lvcabral preferences.browserWindowOverrides will be exposed in the next release! (#127)


pypyodbc.DatabaseError: ('21S01', '[21S01] [Microsoft][SQL Server Native Client 11.0]Insert value list does not match column list')

I'm trying to switch from pyodbc to pypyodbc and it seems that pypyodbc has problems when trying to insert empty strings as parameters.
Here is an example of the sql query and the parameters:
INSERT INTO [My_MSSQLDB].[dbo].[Table1]
([ItemId]
,[Val1]
,[Val2]
,[Text]
,[OrderId])
VALUES (?,?,?,?,?),(?,?,?,?,?),(?,?,?,?,?)
The parameters as a list:
['123', 2, 1, 'Text1', 10034, '124', 7, 2, '', 10034, '125', 0, 1, 'Text3', 10034]

And this worked when you passed a non-empty string in that position? Just double-checking here.

Sorry, my bad, should have tested that before.
I made some additional tests and it fails when i try to input multiple entries.
So this works with empty and non empty strings:
VALUES (?,?,?,?,?)
and this fails with either and throws the mentioned error-message:
VALUES (?,?,?,?,?),(?,?,?,?,?)
This worked flawlessly with pyodbc. Does pypyodbc only work with executemany for bulk inserts?

I solved it now by using executemany instead of execute, it seems like a bug though, if pypyodbc is supposed to work the same as pyodbc.
You can close this if this is the expected or accepted behaviour.

Thanks for posting your solution/workaround.

For the records, development of pypyodbc basically stopped in 2017. Whatever API improvements were implemented in pyodbc since then are not reflected in pypyodbc. I've updated the project description accordingly, a few minutes ago.


storagecluster: allow any storageclass for storagequota

Allow user-defined custom storgaeclass names in Overprovision
definition, so users can define quota for future storageclasses, which
are not available during deployment time.
Refs BZ-2024545
Signed-off-by: Shachar Sharon<EMAIL_ADDRESS>

/retest
On Thu, Nov 18, 2021 at 6:22 PM openshift-ci[bot] @.***>
wrote:

@synarete https://github.com/synarete: The following test failed, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws e5715b7
https://github.com/red-hat-storage/ocs-operator/commit/e5715b76f92cea9f9946e79a1fc6620fd4eacad3
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/red-hat-storage_ocs-operator/1403/pull-ci-red-hat-storage-ocs-operator-main-red-hat-storage-ocs-ci-e2e-aws/1461350637814943744
false /test red-hat-storage-ocs-ci-e2e-aws
Full PR test history
https://prow.ci.openshift.org/pr-history?org=red-hat-storage&repo=ocs-operator&pr=1403.
Your PR dashboard
https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:synarete.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/red-hat-storage/ocs-operator/pull/1403#issuecomment-973022475,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5ZRR3S2YZ5QICHROT62ALUMUR2XANCNFSM5IJ3GYPQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You can ignore this failure (ci/prow/red-hat-storage-ocs-ci-e2e-aws). there is a bug in the installation.

/cherry-pick release-4.10


PR108 code review

Feedback and changes from the comments in PR108

hey @BrianFarnhill  can hyou check the unit tests that are failing?

@camiloborges My bad - just fixed it and also merged in updated dev branch changes for you. Its stuck in queue with appveyor to confirm but I had local passes at least this time. Should be good to go though mate


Update notebooks to be compatible with watcher

Is your feature request related to a problem? Please describe.
The notebooks for extracting images, computing pulse heights, performing rosetta, etc, are currently not compatible with running those same functions as part of the watcher
Describe the solution you'd like
We should update the notebooks the same way we updated the qc metrics notebook. In particular, they should expect the same directory format as the watcher, check and see which FOVs in a run already have the appropriate output saved, and for the ones that don't create it.

This notebook in particular https://github.com/angelolab/toffy/blob/main/templates/extract_bin_file.ipynb


⚠ Bofrost.es has degraded performance

In 6c6a275, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1626 ms

Resolved: Bofrost.es performance has improved in 3ad8326 after 6 minutes.


[Feature Request] Reset a day to "?"

Hello,
I accidently filled out the wrong day, but I cannot revert entries back to "?" because only "✓", "-" or "x" are available.
Please make it possible to reset all entries of a day to "?"
I suggest long press on date header for this function - maybe with confirmation.
Thanks!

 Reset a day to "?"


Include cron command in the docs

Setup would be even simpler if there was a cron command that I could just run that'd make it work.

done


Suggestion: debouncing based on event sources

@dariooddenino has a great gist of using event sources for debouncing in search:
https://gist.github.com/dariooddenino/452827d9d95c8fc3b651c009d2b9b2ea
here it is in practice:
https://gist.github.com/dariooddenino/eb0fc7fd863ae37d8ca9962b7ea824dc
this is nice because the debouncer isn't being kept in state, so we don't end up causing unnecessary re-renders, and it's a bit nicer interface to work with.

I wonder if, by specializing it to your specific query, you could avoid the type variables. Actually, what if you just hid them with a newtype:
data QueryF o item a = ...
  | SendSearch a

newtype AnyQueryF a = AnyQueryF (forall o item. QueryF o item a)

sendSearch :: forall a. a -> AnyQueryF a
sendSearch a = AnyQueryF (SendSearch a)

type DebounceTrigger = Utils.Debounced.DebounceTrigger AnyQueryF Aff

(then I think you need to use hoist liftAff to get the right MonadAff m => HalogenM ... m ..., but the types should work out from there 🤞💪)

#35 moves debouncing from state to a ref


Versioning support in Schema

Problem description
Policies are required to support versioning (see #310), since schemas are included in the policies the versioning concept needs to extend to them as well.
Requirements
Similarly to policies, schema syntax needs to have provisions for declaring the following:

Schema version (in semantic versioning style)
Date (in which the version has been 'released')
Supersedes (previous schema version which is now not the latest)

DOD

Acceptance criteria fulfilled
Demo schemas updated to include versions

Acceptance criteria

Valid schema documents must contains version information, otherwise they are considered invalid and not accepted
Schema version is visible in the UI wherever the name of the schema is displayed

Developers are going through a Decision Stage on this ticket. We just clarified. The team is now going back to finish the design, and it will then be down the implementation.

Development has been started on this ticket.


Any plans for ES6 & AMD support

Category

[x] Question
[ ] Typo
[ ] Bug
[x] Enhancement / Suggestion
[ ] Additional article idea

Expected or Desired Behavior

Any plans to support ES6 insted of typescript.
Any sample about how to load & run project in AMD Module

1.) The ES6 syntax, or the official name ECMAScript 2015, is just a subset of the capabilities you have in TypeScript. I recommend you to read TypeScript, ES6, Questions, Answers.
You will also find a good overview over the capabilites in ES6 and TypeScript
http://kangax.github.io/compat-table/es6/
2.) There is a good tutorial that shows how to use external libraries in SPFX. This tutorial use jQuery, which is based on AMD.
Hope this answers your questions.

@manivannan-mp

We do not currently have plans to support ES6 syntax but only TypeScript.

Can you be more specific on what you mean by AMD support? We already support those in SPFx solutions.

Closing this issue as there hasn't been any activity in several months.


RFC 0003 needs translation

File: https://github.com/cds-snc/docs/blob/main/development/rfcs/0003-standard-gh-labels.md
Raw: https://raw.githubusercontent.com/cds-snc/docs/main/development/rfcs/0003-standard-gh-labels.md


Discord isn't posting screen shots

I have the plug-in setup and is used to work and was working up until yesterday, i've re-installed both runelite and the plugin itself. it's sending the notification through discord still but no screenshot. any advice on a fix or potential issue?

If the Send screenshot setting is enabled but no screenshots are being sent, could you see if the issue persists with Dink? You can do ::DinkMigrate rare to streamline the migration process

Does the base runelite screenshot plugin work? e.g. try pressing the screenshot button in the client toolbar and check if a file is correctly created


Add dart 2.10

The legacy polygott images had Dart 2.9 so this is technically an update, but 2.10 only adds features so it's no big deal to upgrade polygott users to 2.10 in nix migrations
HOWEVER, dart 2.12 had a major breaking change - so big of a change, in fact, that dart 2.11 was skipped. Why would Google do this? Why are we in this world? What even is versioning? How come we can't have nice things? Must we go on like this? Must all of our software break for no reason at the whims of Google and their anti-versioning gods? What is the meaning of versions?


Remove enable resource quota note

As of now, ResourceQuotaScopeSelectors is enabled by default, since it's in beta. So, let's remove it.
/cc @bsalamat @vikaschoudhary16

/approve


Fix language declaration of italian translation

Just saw that there were two "nl" entries. German translation will follow ...

Ouch ! Thanks