Update sbt-scoverage to 1.9.3

Updates org.scoverage:sbt-scoverage from 1.8.2 to 1.9.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

Coverage decreased (-2.8%) to 91.975% when pulling 2bfeeeeb03f416c1e1e0417dbddb76a89fa49740 on scala-steward:update/sbt-scoverage-1.9.3 into ca10c64b98af9973d1b830d6a180d8b2c8898d98 on iheartradio:master.

Superseded by #227.

Superseded by #229.


SystemTime::new_async() can't be found

https://github.com/esp-rs/esp-hal/blob/main/examples/src/bin/embassy_hello_world_systimer.rs#L41 uses new_async, but the set of features in the example leads to "function or associated item not found in `SystemTimer<'_>"

We have an examples readme: https://github.com/esp-rs/esp-hal/tree/main/examples which explains how to run the examples. In short, we use an xtask subcommand to build and enable the correct features. In this case, cargo xtask run-example examples esp32c3 embassy_hello_world_systimer builds and runs as expected.


Sharing link only half working

While choosing to share a badge, I could verify that the Base64 data is correct, the link does not go back to the app, but instead to your @realvorl main or profile repo ( ignoring the /BadgeSVGen path)
I think this is a bug.

Yeah, this is a bug 🪲

OK @emunaelator it was an easy fix, did not do the whole PR review thing, because I am a one man show for the moment. Now when you press the Share Badge button the URL is complete and shareable.
This commit: baee4c1
Allows me to link to a badge V30 seven  some nonsense thing I did the testing with ...
Will close the this issue now.
BR.


Develop Resource Page: Leadership: Mentorship

This issue is for coordinating around developing the resource page for Leadership: Mentorship.
The resource page lives in the following google document for easy editing, commenting, and revision:
https://docs.google.com/document/d/1pQnnbkDrVbZK_sJ8Nl84ijwxfHSmUNMwIDe5dVJ2pf4/edit?usp=sharing
Once the page is in a decent shape, we will put a copy of it in the repository as a markdown file.
To work on this issue, feel free to leave a comment here and start editing the document. For questions, feedback requests, and other coordination tasks, please leave a comment here on the issue.
Please edit the google document directly and add your ideas to it. We can help with cleaning it up later.

I added some comments to the objectives - some additional objectives to consider adding.

Thanks @SarahKConway I have added a few more items and proposed a first set of sample metrics.
I'm going to surface Mentorship metric on the mailing list and put it on the agenda for next week.

I've heard that mentorship programs are very western concept and not easily understood and commonly used in some geos. do we want to make this an objective. expand geo. reach of mentor programs where appropriate. Or document mentor best practices, how to instructions to encourage broader adoption? Or is it just not culturally accepted and we should be okay with mentor programs that have limited geo. reach.

The goal of CHAOSS is to develop metrics to understand how we are doing. If mentorship is only interesting to some projects, that's okay. I don't think it is our goal to expand the use of mentorship. However, if our metrics demonstrate the value of mentorship to a project, then hopefully more projects choose to focus on mentorship.


ROX-21221: Default policy updates and migration

Description
This PR combines multiple different policy updates into one PR so that migrations can also be handled in just one step.
It cherry-picks from the following PRs:
https://github.com/stackrox/stackrox/pull/9294
https://github.com/stackrox/stackrox/pull/9172
https://github.com/stackrox/stackrox/pull/8759
And also contains policy exclusions from ROX-21221.
 It is recommended to review this PR commit by commit so that it's not overwhelming.
Here are what each file corresponds to:
All files in pkg/defaults/policies/files -> This is the actual policy and the updates to each policy. Please review this carefully.
All migration code is in migrator/migrations/m_198_to_m_199_policy_description_and_criteria_updates
Within the migration folder, the folder policies_before_and_after contains two folders: before and after. The migration diffs the policy in before with the ones in after to determine how the policy should be changed. Thus the files in before are what the policy looked like before this PR, and after is what it should be after migration.
CHANGELOG -> only changes that changes names or policy criteria is listed
Checklist

[ ] Investigated and inspected CI test results
[x] Unit test and regression tests added
[x] Evaluated and added CHANGELOG entry if required
[x] Determined and documented upgrade steps
[x] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
TODO(replace-me)
Unit tests
Manual test:

[x] New install should show policy updated
[ ] Updates should also show policy updated

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

🚢 . Assuming scanner v4 tests can be ignored for now.

There were a few fixes for the scanner tests so let me rebase and try to see if it fixes it. But it should be unrelated to this PR


[MINOR][SQL] Check the NumericType in canImplicitlyCast is not needed.

What changes were proposed in this pull request?
This PR propose to remove the check for NumericType in canImplicitlyCast.
In fact, all the caller already ensure the NumericType.
https://github.com/apache/spark/blob/8ea09de807f9f218d549ae179e09bd5219979e06/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala#L133
https://github.com/apache/spark/blob/8ea09de807f9f218d549ae179e09bd5219979e06/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala#L156
https://github.com/apache/spark/blob/8ea09de807f9f218d549ae179e09bd5219979e06/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala#L171
Why are the changes needed?
Check the NumericType in canImplicitlyCast is not needed.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.

ping @viirya cc @dongjoon-hyun @HyukjinKwon

@viirya @dongjoon-hyun Thank you for the review. I will close this PR.


Feature: Ship a git version in the repos

Description
Sometimes it's useful to be able to easily install the git version, and having a package manager do it for you would be great I think.

May need some more details to fully understand what the ask is.
I am working on restoring the git integration using gix instead of git2-rs due to issue we've had with openssl and cross compiling. A current PR is open that I am waiting to hear from some people in the community that will bring back sourcing manifests via git through the use of gix.
If you just want a comtrya manifest to install git, the package.install action is there. It uses the underlying package manager of the system. So if it is Debian, it uses apt. If it's macOS, home-brew (or macports), Arch uses yay, OpenSUSE zipper, NetBSD pkgin, etc.
If what you're asking for is comtrya to be able to pin a version of git to install, this is a long time ask and I am still working through the details. The problem here is, package managers don't uniformly support it.
That is about all I can think of to answer this without some more detail. So if it is something else, I would like to hear more details so I can better understand. Thank you!

I apologize for the ambiguous post,
What I meant is that currently there is the "release" version being packaged and shipped into the repositories, like the AUR. However, sometimes features are needed which are only available in the latest development version (latest git commit). My suggestion is to add the development-version packages to the repositories, e.g. in the case of AUR, a PKGBUILD which git clones and builds comtrya from the latest commit.

Gotcha. I understand what the ask is now. Thank you!


chore: migrate to cli-table3

This is not yet part of the current master. Can you explain me why this was closed and not merged?

Ah ok, didn't know this. Thanks for the clarification.

Still not fixed. You are still using cli-table2 ;-)


Add a license to the repository

I recently came across your project QuantumComputingQiskit and I noticed that the repository github.com/bishwajitprasadgond/QuantumComputingQiskit currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

License added. Thanks!

Thanks!


Giant pile of tidying

Went to adjust a few things, got carried away... Some of this is more clang-tidy warnings. (Interestingly it can detect more double-promotions than GCC can.)

Remove redundant voids!
Madness :)

Is there any way we can run clang tidy with a --check-only flag in Travis to prevent any new issues from creeping in?

Thank you- had a quick skim and it all looks completely rational. We could definitely use some gentle code style nudges, but don't want to put up too many barriers to entry.

What we need is -outmoded-old-buggers for my code.


Migrate from Travis to GitHub Actions

bors merge

bors merge-

bors merge

bors merge

bors try

bors try

bors try

bors try

bors try

bors merge


Provide document of numeric types and type stability

Covers #1909. It is just a start and later I will add more documentation.

Please check again now :)
First, please check style, I try to keep consistency with the rest of the convention file. Second, concerning content, I think handling these cases on a case-by-case basis is acceptable for now (but I have no idea if this is good for other developers). Third, I suggest asking someone unfamiliar with these things to review it again. While you understand it clearly, it may not be as easy for others to grasp.

Shall we merge this PR if it looks good to you, or should it be held until the main PR is ready to merge?

Thanks, these are good suggestions!


mkcert - can't get secure connection NET::ERR_CERT_AUTHORITY_INVALID

I have tried everything to get this to work. I am using WSL 2 on Windows 10.
I have run mkcert -install which completes successfully and reports:

Created a new local CA
The local CA is now installed in the system trust store!

I have restarted ddev to apply the changes but all browsers I try still show a certificate error. (Chrome, Brave, Edge).
I have reinstalled and removed local CAs like so:

mkcert -uninstall
rm -rf "$(mkcert -CAROOT)"

Then reinstalled (not as sudo).
If I check ownership by using:

ls -l "$(mkcert -CAROOT)"

the certs are correctly assigned to my user.
But I still get the cert errors in all browsers.
Am I doing something wrong?
Many thanks

Hi @MisterH001  - Please follow the instructions exactly on https://ddev.readthedocs.io/en/stable/#installation-or-upgrade-windows-wsl2, go through step-by-step.
WSL2 is complicated because people typically use the browser on the WINDOWS side, but the webserver is running in docker on the WSL2 side. There are really 3 different entities going there. The instructions try to help you

Create the CA on the Windows side
Install it in the windows-side browser (probably only Chrome works out of the box on WIndows)
Expose it on the WSL2 side by sharing the CAROOT environment variable into WSL2
Have ddev/ddev-router use the CAROOT environment variable to use the windows-side CA.

Many thanks Randy.
I didn't realise that out of the box mkcert would only work if viewing directly from the ddev environment.
I have now got this working by generating my own SSL (using this: https://www.selfsignedcertificate.com/) and then adding the crt and key to .ddev/custom_certs dir, then adding the cert in windows as a trusted root certificate.
This process works now.
Thanks again for your help and all your time on this awesome project :)

I'm glad you've got it going. Of course it works with mkcert as per the instructions. But installing your own cert is the same thing.
Glad to know you're using the custom certs option - not sure many people have used that.


RFD - Add Nebari Configuration Options for Air-Gapped or Secure Deployments

Status
Draft 🚧 / Open for comments 💬

Author(s)
@joneszc

Date Created
15-08-2024

Date Last updated
15-08-2024

Decision deadline
N/A

Title
Addition of Nebari Configuration Options for Deploying Nebari in Air-Gapped and/or Secure Environments
Summary
There are currently a number of options available to optimize Nebari configurations for deploying in AWS air-gapped networks, private subnets, or secure environments
For example:

Pointing to existing subnets and an existing security group for overriding the default Nebari provisioning of aws_vpc, aws_subnet, aws_internet_gateway, aws_security_group:

amazon_web_services:
  existing_subnet_ids:
    - subnet-xzxzxzxzxzxzxzx
    - subnet-zxzxzxzxzxzxzxzxz
  existing_security_group_id: sg-xzxzxzxzxzx

Setting the load balancer as internal as opposed to internet-facing while also pointing to existing subnets:

ingress:
  terraform_overrides:
    load-balancer-annotations:
      service.beta.kubernetes.io/aws-load-balancer-internal: "true"
      service.beta.kubernetes.io/aws-load-balancer-subnets: "subnet-xzxzxzxzxzxzxzx,subnet-zxzxzxzxzxzxzxzxz"

Potentially overriding conda configs with private conda channels

conda_store:
  extra_settings:
    CondaStore:
      conda_allowed_channels:
        - s3://my_bucket/my-conda-repository/main/

Deploying Nebari with self-signed certificates:

certificate:
  type: self-signed

Rebuilding with locally issued or customer-provided certificate (after creating k8s secret):

certificate:
  type: existing
  secret_name: nebari-custom-secret

Option to override many, but not all, container-images to point to local private registries/mirrors, as discussed in:
Custom images / private registry #2097

However, configuration options could be expanded to enable:

Option to set image overrides for all Nebari containers, individually, or set private registry mirrors for docker, quay, gcr, etc.
Option to employ customized, hardened or otherwise customer-approved AMIs for EKS nodes
Option to specify launch commands (pre-bootstrap) that configure security/networking/performance requirements of EKS nodes
Option to control the EKS cluster endpoint access, beyond the default "Public", to set either "Private" or "Public and Private"

User benefit

Nebari users would have the option to control all container-image overrides and set private registries/mirrors.
Nebari users would be able to modify EKS nodes and/or utilize customized ec2 AMI to accommodate target environment requirements to ensure networking/security/performance compliance and accommodate requirements for integrating customer systems.
Nebari would be deployable into private AWS subnets with option to override the current default "Public" cluster API server endpoint to set an entirely "Private" endpoint or a "Public and Private" endpoint.

Design Proposal

Enable option to control EKS cluster endpoint access settings as discussed in #2586 and proposed in PR#2618:

amazon_web_services:
  eks_endpoint_access: 'private'

Enable option to run custom launch commands on EKS nodes as discussed in #2603 and proposed in PR#2621
Note that this would also resolve the functionality to set private container registries/mirrors by adding containerd configs/imports:

amazon_web_services:
  node_prebootstrap_command: |
    #!/bin/bash
    mkdir -p /etc/containerd/certs.d/_default
    cat <<-EOT > /etc/containerd/certs.d/_default/hosts.toml
    [host."https://registry.gitlab.example.com"]
      capabilities = ["pull", "resolve"]
    EOT

Enable option to specify custom AMI IDs for EKS nodes as discussed in #2604 and also proposed in PR#2621

amazon_web_services:
  node_groups:
    general:
      instance: m5.2xlarge
      custom_ami: ami-0xzxzxzxzxzxzx
      min_nodes: 1
      max_nodes: 1
      gpu: false
      single_subnet: false

Alternatives or approaches considered (if any)

In addition to using node pre-bootstrap commands to override containerd configs for setting private registry mirrors, increased terraform and helm override options could be enabled to specify container images and tags to reflect custom-built or privately-hosted container-images.
Best practices

User impact

Per PR#2621, users would need to understand whether or not their custom EKS node AMI is GPU-enabled, to ensure proper toggling of gpu: <true/false> (setting a custom AMI ID would trigger the terraform logic to automatically switch the ami_type value to "CUSTOM", as required by AWS EKS).
Additionally, per PR#2621, users would not be required to manually input the override bootstrap.sh command when setting a custom AMI ID, as the terraform would employ the command for them.

Unresolved questions

I propose adding a "Nebari Secure Deployment Guide" to this RFD.
This would take the form of one or more nebari-config.yaml files which each utilize inline comments to comprehensively document configuration parameters relevant to various aspects of security. For example, one config file may demonstrate how to override the default docker container locations with a custom-specified repository. This config file could be named e.g. "nebari-config-custom-docker-repo.yaml".
Another example could specify the aboe docker repository along with AMI IDs and elimination of AWS internet gateway. This config file could be called e.g. "nebari-config-aws-airgap.yaml". These are only examples: further discussion can refine exactly what configuration goes into each yaml file and how the files are named.
These files could then be used in associated CI/CD pipelines to validate that the configuration state they describe continues to be supported by Nebari as new versions are released. I propose that the work to hook up this CI/CD mechanism is not part of this RFD.
I do not have a recommended location for these nebari-config.yaml files yet.

Somewhat related, I know @viniciusdc was working on a way to auto generate documentation from the code.  We could potentially add the documentation describing for each new nebari-config setting in the pydantic models themselves.  Do you have an issue that shows what you were working on @viniciusdc?

* Enable option to control EKS cluster endpoint access settings as discussed in [#2586](https://github.com/nebari-dev/nebari/issues/2586) and proposed in [PR#2618](https://github.com/nebari-dev/nebari/pull/2618):

amazon_web_services:
  eks_endpoint_access: 'private'

I think this is fine and your proposed method in #2618 makes sense.

* Enable option to run custom launch commands on EKS nodes as discussed in [#2603](https://github.com/nebari-dev/nebari/issues/2603) and proposed in [PR#2621](https://github.com/nebari-dev/nebari/pull/2621)
  Note that this would also resolve the functionality to set private container registries/mirrors by adding containerd configs/imports:

amazon_web_services:
  node_prebootstrap_command: |
    #!/bin/bash
    mkdir -p /etc/containerd/certs.d/_default
    cat <<-EOT > /etc/containerd/certs.d/_default/hosts.toml
    [host."https://registry.gitlab.example.com"]
      capabilities = ["pull", "resolve"]
    EOT

I think this syntax would be quite awkward. As much as possible, prebaking stuff like enabling other repos into your AMI would solve this. For running a script on startup, there is the user data approach (reference https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/user-data.html) Perhaps something like specifying a path to a userdata file or config would work. I have concerns about not only the awkwardness of including the script inline, but it also seems like a potential security footgun.

* Enable option to specify custom AMI IDs for EKS nodes as discussed in [#2604](https://github.com/nebari-dev/nebari/issues/2604) and also proposed in [PR#2621](https://github.com/nebari-dev/nebari/pull/2621)

amazon_web_services:
  node_groups:
    general:
      instance: m5.2xlarge
      custom_ami: ami-0xzxzxzxzxzxzx
      min_nodes: 1
      max_nodes: 1
      gpu: false
      single_subnet: false

Slight nitpick, but rather than custom_ami, we could just call it node_ami, there is no reason it has to be custom, a user may want to just use a vendor provided node ami for some reason.

Alternatives or approaches considered (if any)
In addition to using node pre-bootstrap commands to override containerd configs for setting private registry mirrors, increased terraform and helm override options could be enabled to specify container images and tags to reflect custom-built or privately-hosted container-images.
Best practices
User impact
* Per [PR#2621](https://github.com/nebari-dev/nebari/pull/2621), users would need to understand whether or not their custom EKS node AMI is GPU-enabled, to ensure proper toggling of `gpu: <true/false>` (setting a custom AMI ID would trigger the terraform logic to automatically switch the `ami_type` value to "CUSTOM", as required by AWS EKS).

* Additionally, per [PR#2621](https://github.com/nebari-dev/nebari/pull/2621), users would not be required to manually input the override bootstrap.sh command when setting a custom AMI ID, as the terraform would employ the command for them.

Unresolved questions

@viniciusdc @dcmcand
The original intent of the Add aws_launch_template PR was to make it easy on the user to run commands and customized AmazonLinux AMIs using launch_template/user_data sections, with less crisscrossing of config variable options and more built-in logic to reduce the risk of blocking nodes from joining the cluster (e.g. missing or faulty user-defined bootstrap.sh commands).
Your replacement PR includes the same launch_template/user_data approach as originally proposed in PR and still includes the inline scripting option with the pre_bootstrap_command/node_prebootstrap_command var.  The main differences I see between the PRs is that your rendition moves the pre-bootstrap command option to the node_groups level to cut out some previously proposed logic in the terraform, while also requiring more due diligence from the user in mapping additional variables.
When specifying an AMI image_id, your PR will require the user to manually set the bootstrap.sh command (PR#2621 triggers a pre-set bootstrap.sh command as necessary and EKS otherwise sets the bootstrap.sh command automatically when image_id is not specified).  You are proposing to call this variable, for the second part of the user_data block, user_data, which seems misleading since the overarching user_data section might already include pre-bootstrap commands and could require a bootstrap.sh command.  If you are setting the onus on the user to provide the bootstrap.sh command, please rename the variable to something like override_bootstrap_command to clue the user in on providing the /etc/eks/bootstrap.sh command. Additionally, your PR adds updates to relocate some previously existing logic, from terraform to python, for setting ami_type but falls short of checking to ensure that the ami_type is always CUSTOM when a user specifies an AMI image_id.  EKS will fail if ami_type is set to anything other than CUSTOM when setting image_id.
Our original PR#2621 was not engaging users to specify ami_type; rather, the intent was to enable users to customize the default AmazonLinux AMIs for security purposes (e.g. apply STIGs).  I'm glad to see you aren't enabling the user free range to set the ami_type, which would expand the scope of this PR to accommodate user_data configuration schema updates for AmazonLinux2023, which transitions from Content-Type: text/x-shellscript; charset="us-ascii" to Content-Type: application/node.eks.aws (YAML).  We are anticipating addressing Nebari's AWS migration from AL2 to AL2023 in a separate security Issue/PR--in due course of the upcoming deprecation of AL2.

Hi @joneszc, Thanks for the valuable follow-up. Indeed, I took the liberty of expanding the PR to be a bit more generic in the sense of ami customization. As the draft suggests, that was just a small passthrough to see how the config would be exposed to a user, in which I was already considering the scope of a "security" deployment option or set of settings that lead to that in the future.

The main differences I see between the PRs is that your rendition moves the pre-bootstrap command option to the node_groups level to cut out some previously proposed logic in the terraform, while also requiring more due diligence from the user in mapping additional variables.

It's worth noticing that I've kept your original option to set the launch_template as a global config for all node groups. So, both the node_groups and the aws provider field will have access to that variable, though a 	node_group.launch_templatestill would have priority over the global one when available.

You are proposing to call this variable for the second part of the user_data block, user_data, which seems misleading since the overarching user_data section might already include pre-bootstrap commands and could require a bootstrap.sh command

I thought about that, and I concur the name needs to be more accurate since it's not exactly what it says it is. Still, at the same time, I will enforce that this can only be passed when the AMI type is set to CUSTOM, and, as mentioned by you as well, that's something that I didn't have the time to add to that PR yet, but it was the original goal.
However, on a counter suggestion, what about override_user_data? While I see the point of using override_bootstrap_command as a good source of direction to the user, I think it's limiting when comparing the broader flexibility of MIME. But I am not strongly opinionated on this.

Our original https://github.com/nebari-dev/nebari/pull/2621 was not engaging users to specify ami_type; rather, the intent was to enable users to customize the default AmazonLinux AMIs for security purposes (e.g. apply STIGs).

That's also different from the PR's intention. The main goal was to clean up the handling logic only from within the Terraform resources; the reason it shows up to users right now is mainly due to a current narrow distinction between what should be passed down as a Terraform variable and what should be allowed in the nebari-config.yaml. They consume from the same model right now, but in theory, they should be separated entities, and that is something I plan to address in another ocasion.

AmazonLinux2023, which transitions from Content-Type: text/x-shellscript; charset="us-ascii" to Content-Type: application/node.eks.aws (YAML). We anticipate addressing Nebari's AWS migration from AL2 to AL2023 in a separate security Issue/PR--in due course of the upcoming deprecation of AL2.

You mentioned this exciting prospect. Right now, in any of the given PRs, we are "hardcoding" that as part of the template file, which, while not harmful, is not preferable. So maybe the best course of action would be to leverage the data_user as a path to a template file and only guarantee a set of variables to these templates, such as certificate, cluster_name, etc.

@viniciusdc
I could see calling the variable "user_data" if you weren't including the pre_bootstrap_command var.   My team's use cases, for which we originally requested these features, are predominantly in favor of the pre-bootstrap command option in conjunction with taking the burden off the Nebari user for setting the /etc/eks/bootstrap.sh command.  Again, in our original PR, we included logic to trigger the bootstrap.sh command+args, as is necessary when using a CUSTOM AMI.  We pondered adding a bootstrap_extra_args or bootstrap_args_override var but didn't see that as an imminent need of Nebari.
Since you are, in effect, requiring users to manually enter the bootstrap.sh command when setting ami_id--or else facing the pitfall of nodes failing to join the cluster--while also including the pre_bootstrap_command, you are potentially dealing with three chronological parts to your user_data: pre-bootstrap-user-data, bootstrap-user-data, and post-bootstrap-user-data.  You could wrap the entirety of the pre-bootstrap + bootstrap.sh-override + post-bootstrap options into a single variable and continue to call it "user_data" or else follow the models of either eksctl, which enables users to enter preBootstrapCommands and/or overrideBootstrapCommand (onus is on the user to ensure bootstrap.sh command is manually entered when specifying an ami-id), or the aws eks user_data terraform submodule, which enables both pre_bootstrap_user_data and post_bootstrap_user_data while also offering the option to set enable_bootstrap_user_data to true/false. The point is, if a Nebari user wants to run a custom AMI, and you don't include the /etc/eks/bootstrap.sh command in the user_data file for them, then they will need to know exactly under which variable to write the boostrap.sh command+args.


Allow the configuration to customize the monitoring service.

Currently we are running two MAD instances on one of our fleets - clusters - where one instance is used to monitoring and aggregate the local services and the other is used for aggregating remote sample feeds. Since both are on the same cluster we need to customize one of the service names in order to separate out the metrics about metrics.

👍


External Functions for Postgres

It is possible (see PL/Java), but the infrastructure is different than H2 and will need some work.

Complete in f983075d49cd848cde204d798a5d58ea93c9adb2.
External functions have been reworked so that they are not actually executed in the database.
Instead they are evaluated during the grounding (instantiation) phase, so no database support is required.


LTW015 not recognized?

Hi,
Is there an option to add Philips Hue model -> LTW015 ?
Currnently It's not recognized and it generating errors in the log file
Thanks in advance!
Rob

Hi Rob,
I have added a new question in the FAQ: https://github.com/bramstroker/homeassistant-powercalc/wiki/FAQ#my-light-model-is-not-supported-what-can-i-do
It's the last question on this page.
Hope this helps.


python310Packages.svdtools: 0.1.21 -> 0.1.22

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.svdtools is: "Python package to handle vendor-supplied, often buggy SVD files"
meta.homepage for python310Packages.svdtools is: "https://github.com/stm32-rs/svdtools"
meta.changelog for python310Packages.svdtools is: "https://github.com/stm32-rs/svdtools/blob/v0.1.22/CHANGELOG-python.md"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 0.1.22 with grep in /nix/store/73zra10q0vv7rn1vnjwj64hp4hzk35vr-python3.10-svdtools-0.1.22
found 0.1.22 in filename of file in /nix/store/73zra10q0vv7rn1vnjwj64hp4hzk35vr-python3.10-svdtools-0.1.22

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.svdtools
python39Packages.svdtools
svdtools

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/73zra10q0vv7rn1vnjwj64hp4hzk35vr-python3.10-svdtools-0.1.22 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.svdtools https://github.com/r-ryantm/nixpkgs/archive/45ec327c04e358363d2aa4882aa365c703857357.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/73zra10q0vv7rn1vnjwj64hp4hzk35vr-python3.10-svdtools-0.1.22
ls -la /nix/store/73zra10q0vv7rn1vnjwj64hp4hzk35vr-python3.10-svdtools-0.1.22/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.svdtools
svdtools (python39Packages.svdtools)

Maintainer pings
cc @newAM for testing.

Result of nixpkgs-review pr 170407 run on x86_64-linux 1

2 packages built:

python310Packages.svdtools
svdtools (python39Packages.svdtools)


Download Image

Hi @outloudvi , would it be possible to download an image and save it in the repository?
I tried to do a similar thing but it doesn't seem to work:
on:
  workflow_dispatch:
name: Scrape File
jobs:
  build:
    name: Build
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        name: Check out current commit

      - uses: suisei-cn/actions-download-file@v1
        id: downloadfile
        name: Download the file
        with:
          url: "https://upload.wikimedia.org/wikipedia/commons/thumb/7/71/Meet_Truffle%21.jpg/440px-Meet_Truffle%21.jpg"
          target: assets/

How can I do?

It only downloads the file. To put the file onto the repository, you need to create a commit and push the commit to the repository (e.g. with ad-m/github-push-action).

The code seems okay for your need, and please feel free to go ahead and bring forth with your questions directly :)
(Note: Please check related GitHub Terms to confirm that what you're doing is aligned with GitHub's terms.)

@outloudvi :

The doubts are the following, if the file has already been downloaded once, I get the following error:

Do you think it's due because the file already exists?
But I don't understand why he makes an error.

I would like to make a js file return url for the git action to execute.
I think such a thing, what do you think?

    - name: Scrape
      run: npm run action //node ./action.js

action.js
async function getData() {
//fetch
...
return url;
}

getData() // no top level await... yet
.then((e) => {

});

git commit will spawn an error when there is nothing to commit. You need to ask GitHub Actions to ignore the error at that step (e.g. with continue-on-error: true).
You are able to use the output of a previous step as parts of the input in your later steps. Check this for further information.

Hi there!
@Angelk90 , I think you need to check if any files are downloaded to the "assets/" directory after calling suisei-cn/actions-download-file :
        - uses: suisei-cn/actions-download-file@v1
          ...
          with:
            ...
            target: assets/

+       - run: ls -l 'assets/'

        - name: Commit files
          ...

If nothing there, as @outloudvi said, git commit will spawn an error when there is nothing to commit.

Weird.
Try this:
      - name: Commit files
        run: |
         git config --local user.email<EMAIL_ADDRESS>         git config --local user.name "github-actions[bot]"

         git status

         git add .

         git status

         git commit -m "Add changes" -a

Adding the two git status lines might be helpful. Please paste the log of this step (i.e., "Commit files") here.

@pzhlkj6612 :

@pzhlkj6612 : I still haven't been able to fix this, if there is nothing to commit then do nothing.
Were you able to find anything?

Seems inactive, closing.
Feel free to re-open for any other concerns.


Docs & website sphinx errors squished 🌦

Description
This PR fixes some of the remaining Sphinx errors and warnings coming out the Python/website part of docs generation. It fixes some Scala-related docs errors too.
🐞  get_constant ambiguous reference - fixed this Sphinx error; interesting note that text right after the Returns line is expected to be an entity so you have to make sure the reference is good and unambiguous.
🐞  Scala docs used interpreter examples, but the current jar doesn't work with the interpreter, so I removed this notion from the index, ndarray, kvstore, and symbol pages. kvstore and ndarray also had Sphinx errors, which are fixed now.
🐞  The gluon index page had parsing errors. I think it is because the python code on that page isn't really functional and Sphinx was running it and failing. So I removed the python declarations. A gluon expert should really take a look and see what that page needs as far as an update with the latest/greatest info...
🐞  ubuntu setup - I already updated the pip package graphic, so this old table was not needed... and it was causing a Sphinx warning, so I removed it.
🐞  r tutorial fix - this had {r} on one of the code blocks... Sphinx/Pygments didn't like it, so I removed the braces.

@mxnet-label-bot add [doc, website]

@aaronmarkham could you paste the links to the previews here once the CI is done?


Fix topk bug in ATSSAssigner

If self.topk is larger than bboxes_per_level, distances_per_level.topk() causes the error below.
  File "/home/shinya/work/mmdetection/mmdet/core/bbox/assigners/atss_assigner.py", line 123, in assign
    self.topk, dim=0, largest=False)
RuntimeError: invalid argument 5: k not in range for dimension at /opt/conda/conda-bld/pytorch_1587428398394/work/aten/src/THC/generic/THCTensorTopK.cu:23

I encountered this error when I trained a model on COCO by multi-scale training (img_scale=[(1333, 480), (1333, 960)]).
This error can be reproduced by training on small inputs like img_scale=(1333, 128).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @shinya7y ！First of all, we want to express our gratitude for your significant PR in the MMDet project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤


[Bug? Point of confusion?] mold iteration doesn't seem to make sense

Hey there,
I was trying to set up YesFox this morning and was testing out a few things.  In order to get a good test on one moon, I tweaked the YesFox config as such

repeated drops on experimentation caused the mold to ramp up as expected, and I saw the Fox after I hit the threshold.
I then decided to check a different moon (March) which appeared to be the furthest along with mold based on the log file.  After selling at the company, it was noted the mold iterations were 7

However upon routing to March and landing, I didn't see any vain shrouds (though admittedly, March is quite large).  When I went back to orbit, the log suggested the mold iteration count was being iterated for the first time, and it was now 2 instead of 7.

is this a bug with mold iteration/spawning, or am I misunderstanding what's going on here?
Cheers.
edit: heading to Vow afterwards, the same behavior was observed (listed iteration 6 prior to landing, no vain shrouds observed, listed as "iterations for the first time" then set to 1 after returning to orbit)

no other mods related to foxes or vain shrouds/mold
this was all in a continuous lobby that was never closed
sorry for cutting that off, it's set to the default (20)

here's the profile code I'm using.  I have tweaked the YesFox settings back closer to nominal values since then, otherwise it should be the same setup that produced the above behavior
0193cfb7-5bb9-550f-058b-42e2e9a3cd1a

If no other mod is affecting it then either the shrouds failed to spawn for whatever reason or you previously destroyed them on the moon with weed killer - that's the only two ways vain shrouds can reset in vanilla

To elaborate on the above (1a3 beat me to it) - Mold iterations reset to 0 if every vain shroud on a map gets destroyed, or if they completely fail to spawn. The latter should not be happening at all unless you are playing a custom moon that doesn't have AI nodes at least 35m from the ship.
None of the vanilla moons exhibit this issue, so it's weird you would be having trouble on Vow or March... Do you see a "No spores generated; setting iterations to 0" line anywhere in your log?

and the log seems to suggest the "spawn chance (current moon)" is iterating under the assumption that an unvisited moon will always have 0 iterations.

This is correct, all of the "spawn chance" settings only apply to moons which have 0 iterations - each time you go into orbit, they will roll that spawn chance, and if it succeeds, decide to increase to either 1 or 2 iterations. If a moon already has more than 0 iterations, it will have a flat 100% chance to increase by 1 each day.

If no other mod is affecting it then either the shrouds failed to spawn for whatever reason or you previously destroyed them on the moon with weed killer - that's the only two ways vain shrouds can reset in vanilla

I didn't destroy any vain shrouds

None of the vanilla moons exhibit this issue, so it's weird you would be having trouble on Vow or March... Do you see a "No spores generated; setting iterations to 0" line anywhere in your log?

Nope. The only relevant mold information in the log was included in the OP

This is correct, all of the "spawn chance" settings only apply to moons which have 0 iterations - each time you go into orbit, they will roll that spawn chance, and if it succeeds, decide to increase to either 1 or 2 iterations. If a moon already has more than 0 iterations, it will have a flat 100% chance to increase by 1 each day.

I'm not sure what you're saying is correct.  The YesFox log seems to clearly demonstrate that iterations are occurring before visiting a moon.  But the vain shrouds don't exist yet, and thus the iterations are invalid.  Then when visiting a moon for the first time, vain shrouds are properly initialized and iterated by the "current moon" spawn chance at which point the "other moon" spawn chance operations become valid.  Are you saying this is a bug with how vanilla uses the "other moon" spawn chances or is it on YesFox's end?

But the vain shrouds don't exist yet, and thus the iterations are invalid. Then when visiting a moon for the first time, vain shrouds are properly initialized and iterated by the "current moon" spawn chance at which point future "other moon" spawn chance operations become valid.

I'm not sure what exactly you are trying to say here. I was probably confused by your initial post as well.
When you go into orbit at the end of each new day, and at the end of a quota (once your new quota is assigned), every single moon has its mold state updated:

Any moon that already has at least 1 iteration is guaranteed to increase by 1 iteration
Any moon that has 0 iterations rolls a specific chance (defined by spawn chance settings) to increase to either 1 or 2 iterations. If that chance fails it remains at 0 iterations.

This behavior appears to be working correctly as expressed in your log.
Unvisited moons will still grow weeds "in the background," in which case they will already be infested by the point you land on them for the first time. This is vanilla behavior and is correctly replicated by YesFox as well.
This is purely anecdotal evidence, but in my personal playthroughs, I haven't encountered any issues with that behavior working as described. (Pretty much every time we play, Artifice is always covered in weeds by the first time we land on it.) I've also verified that the weeds successfully grow on all planets, including Vow and March, so I'm still not 100% sure what is breaking for you. Is it possible there is some sort of conflict with another mod you have installed?

This behavior appears to be working correctly as expressed in your log.

The log very much does not show the behavior working correctly (see next reply below)

Unvisited moons will still grow weeds "in the background," in which case they will already be infested by the point you land on them for the first time. This is vanilla behavior and is correctly replicated by YesFox as well.

Correct on the first point.  The log clearly shows mold iterating on unvisited moons (expected).  What is NOT occurring is the initial placement of vain shrouds prior to landing.  When landing on a moon with iteration 6, for instance, no vain shrouds can be found.  Upon returning to orbit, the "current moon" spawn chance will iterated as if the moon is at 0 iterations instead of 6.  At this point, the vain shrouds will also properly be initialized on this moon at a specific location.
So you seem to have confirmed there is in fact a bug.  Which the logs in OP very clearly demonstrate given what you lay out as expected behavior.

Is it possible there is some sort of conflict with another mod you have installed?

Anything is possible, and I have already provided a profile code for investigation.  I don't have any other fox or mold-related mods.

Just posting an update to let you know... someone on the Discord thread reported a similar issue (albeit in less detail, so it's also possible it could be a symptom of an unrelated error)
Seems likely this is not an isolated issue, but I still think this is most likely a conflict of some sort. As long as your profile isn't too big I'd like to poke around on it and see if I can replicate what is happening for you.

Correct on the first point, but incorrect in regards to unvisited moons being infested upon landing (which I have said a number of times already). The log clearly shows mold iterating on unvisited moons (expected). What is NOT occurring is the initial placement of vain shrouds prior to landing.

Just to clarify, the iterations resetting to 0 when you land is a separate behavior from iterations increasing each day, and you are correct that is not meant to be happening on its own. I just meant to explain that the iteration count is increasing as expected between days, so there doesn't seem to be an issue with any of the spawn chance settings

A quick test on the profile code you posted presented no immediate issues. I played through quota 1, noted that Vow had 3 iterations in console, landed, and found vain shrouds spawning. I didn't note anything out of the ordinary in the logs either
It might be helpful if you could post a save file where you can verify this issue is happening, since it doesn't seem to replicate 100% of the time

I don't have a save file at the moment, and I'm not sure how I'd even share a save file with this bug.  By the time I land on a planet for the first time and confirm the vain shrouds have failed to spawn, the save file will then have reset the mold iteration value and initialized the vain shrouds properly by the time I return to orbit and save.
The only other information I can think to share is that I believe this test was run under save file 3, in case the bug is save file dependent for some reason.

Once you land and confirm the issue has occurred, you can just quit the game without going back to orbit and the save file will remain unmodified. Then you can just post the LCSaveFile1 LCSaveFile2 or LCSaveFile3 file in %localappdata%Low\ZeekerssRBLX\Lethal Company (if you are on Windows), depending on what save slot you encounter the issue in.
It is possible the bug might only replicate on certain random seeds as well - you could verify whether or not this was the case by landing, quitting to title screen, then reloading the save and landing again, etc. to see if behavior changes between attempts

I've managed to reproduce it and have recorded a ton of data you might be interested in.  In addition to the log, I have the save file from before the mold reset.  I also have the save file after returning to orbit and confirming the mold on March was reset.
Other notable information: It does appear to have some seed dependency.  The initial mold position doesn't seem to get determined until the first landing on the moon.  I had 3 drops on March that correctly generated mold, centered around different locations each time.  Each time I would close out of the lobby without saving and restart the day.  On the 4th day, no mold was generated (confirmed by running around the entire moon, and by the absence of a fox spawn).  I then returned to orbit and allowed the mold to iterate, noting that on the day with no mold, the same behavior reported in OP was observed
[10:21:12.3460566] [Info   :    YesFox] Increasing level #4 61 March mold iterations for the first time; risen to 1

In addition to the log and the zipped save files, I also have a video of the entire test.  It's about 450mb, so you'll have to let me know if you'd like it so I can find a means of uploading it to share it with you.
Cheers
LogOutput.log
Mold_reset_saves.zip
Profile code (exact profile used during test): 0193ede8-bb72-a025-ed87-327f20da49b0

The initial mold position doesn't seem to get determined until the first landing on the moon.

This is correct. This was already vanilla behavior (the planet needs to be loaded to discover the position of the AI nodes, where the mold actually gets generated) but it is especially important in YesFox's implementation since it needs to generate weeds at least 35m away from the ship, and needs to filter out some of those AI nodes.
My newest hypothesis, then, is that weeds are sometimes trying to generate inside of randomly spawning obstacles (boulders and trees) and having their spawns canceled, which then causes weeds to reset. I will take a look at your log and try out your save files soon. Thank you for providing all this info!! Also, I probably don't need you to upload the video, the save file should be fine :)

Sorry for just now getting back to this - I was busy with some other projects that required more attention, until now.
I think I might need to rollback the change Zeekerss made in v60, where weeds failing to generate for a day would completely reset their growth on a planet entirely. That is what is causing the problem here.

[10:16:06.3834171] [Info   : Unity Log] No spores generated; setting iterations to 0

This change was probably never extensively tested, as it occurred between v56 and v60 (on builds that were only privately available)
I'm not certain that this is going to completely fix your issue, since there still might be situations where the spawn point that gets picked is somehow invalid by default. In such a case, it would continue to be invalid on future days, and would basically "softlock" weed growth on that planet until getting fired. Not ideal, but it seems like the lesser of two evils, at least? Better than 10+ iterations disappearing because a rock spawns somewhere for only a single day...
A more proper solution (for the future) is probably going to require extensive custom logic (to track how many days in a row weeds fail to generate, track what planets have and haven't been visited for this first time, etc...) so I'd need to check with 1A3 about how in-depth he wants this to go


Support for variable length instructions

I saw the instruction decoding feature in Surfer, and as I am working with simulation and emulation of the Game Boy processor, I thought it would be cool to implement decoding for it.
However, after taking a quick look at the TOML spec and the crate API, it does not appear to support variable-length instructions, which Game Boy instructions are. They vary from 1 to 3 bytes (see the optable here, if you're curious). They are similar to the i8080 and the Z80 instruction sets.
Does this crate intend to eventually support variable-length instructions?

It's not a priority at the moment, since it was created to be used primarily in the context of Surfer, and signals are always expected to be the same length, but it is something that is on my list.
However a way to implement it right now, is to create 3 toml files, one for each subset of instruction length, and then load all three into the decoder at the same time, and call "decode" on the three potential instruction lengths, only one of which should return a decoded "Ok()" value.

Actually, I did not give enough thought for this feature, because retrieving the instructions from the simulation signals is non-trivial. It would need to somehow retrieve a stream of bytes that the micro-controller reads, and then parse that.
A more reasonable approach is to really add some kind of 24-bit debug signal to the simulation that stores the entire of the last decoded instructions, and run the decoding on that. I guess this crate would already support that, assuming it can ignore one or two bytes of the input.

However a way to implement it right now, is to create 3 toml files, one for each subset of instruction length, and then load all three into the decoder at the same time, and call "decode" on the three potential instruction lengths, only one of which should return a decoded "Ok()" value.

I assume your suggestion is about using this crate as a library, and not on Surfer itself. But my intention was to get this on Surfer.

I assume your suggestion is about using this crate as a library, and not on Surfer itself. But my intention was to get this on Surfer.

True.
I've actually done something similar with the RISC-V toml files I've created, since RISC-V has compressed instructions, that are 16 bit wide instead of the normal 32. See toml/RV32C-lower.toml for the expanded version to 32 bit for surver vs toml/RV32C.toml for the standard 16 bit one.


[Bug] BetterDiscord does not load after installing

Before Reporting

[X] I found no existing issues matching my bug
[X] My issue is not caused by a plugin or theme

Describe the Bug
no submenus under BetterDiscord in settings and no plugins loaded

Expected Behavior
BetterDiscord works as normal
Steps To Reproduce

update discord
reinstall betterdiscord
observe as it doesn't work

Operating System
Windows
Discord Version
Stable
BetterDiscord Version
v1.8.7
Anything else?
No response

omg also experiencing this problem!

Also having this issue, and I think you meant v1.8.2, not v1.8.7

I'm also having the same problem.
Operating System
Linux 64-Bit (6.0.12-Artix1-1)
Discord Version
Stable 163658 (28d41b4)
BetterDiscord Version
❯ betterdiscordctl --version
betterdiscordctl 2.0.1

Anything else?
❯ betterdiscordctl -v reinstall
V: Found modules in /home/comexs/.config/discord/0.0.22/modules
Killing Discord  processes...

V: Injecting into index.js...
Reinstalled.

Perform a manual install until the installer has been updated.
https://docs.betterdiscord.app/users/getting-started/installation/#manual-installation

Betterdiscord is now working as intended.

This has now been fixed!


Rewrite AddonErrorModal/ErrorBoundary & Fix ChangelogModal Invite

Rewrote the AddonErrorModal fixing some bugs in it.

https://github.com/Kyza/BetterDiscordApp-1/blob/main/renderer/src/ui/addonerrormodal.jsx

Rewrote the ErrorBoundary to be more useful.

https://github.com/Kyza/BetterDiscordApp-1/blob/main/renderer/src/ui/errorboundary.jsx

Fixed the invite link in the changelog modal.

https://github.com/Kyza/BetterDiscordApp-1/blob/main/renderer/src/ui/modals.js#L269-L340

What's with all the style/newline changes in renderer/src/ui/modals.js?

What's with all the style/newline changes in renderer/src/ui/modals.js?

My formatter uses the default Prettier settings if there are no specific project-wide settings. That's why I highlighted the changes I made with the link in the OP. I can fix it by redoing those changes with my formatter off if you want.

What's with all the style/newline changes in renderer/src/ui/modals.js?

My formatter uses the default Prettier settings if there are no specific project-wide settings. That's why I highlighted the changes I made with the link in the OP. I can fix it by redoing those changes with my formatter off if you want.

Now that I look at it more that was caused by my formatter in https://github.com/rauenzi/BetterDiscordApp/pull/712/commits/c9aa24cb06f2ba13ed09b278d508bd016f5b9163, but is fixed later in https://github.com/rauenzi/BetterDiscordApp/pull/712/commits/4e14e43f4287dc1b2fd0329dbd70c74ab2ff1ec7. So the styling in the final file should be correct.

Changes not made--closing.


[Planned] Functions Standardization Refactor

The functions file will be restructured into separate files and folders, adhering to the industry standard. Each system function will be categorized into a respective PHP class and method.

The initialiseSystem functions will be revised to ensure optimal performance, efficiency, and bug-free operation.

The OpenSSL functions will be enhanced for improved security.

The next major commit will incorporate these enhancements, resulting in a more organized, efficient, and secure codebase.

Refactored codebase to organize functions within their respective classes and folders using a revamped system. The upcoming release, named Nexus, will incorporate these changes.

[Devnote - November 27, 2023]
Work on the Quickblaze Nexus release is underway within a private repository. The initial stable version will be transferred to the public repository upon completion. Ongoing commits will be confined to the development repository, and major releases will subsequently be made public.

[Devnote - May 24, 2024]
A new approach to the structure of the project has been adopted. The initial project structure, including system class libraries, is nearing completion, where development on the frontend will follow.

[Devnote - June 28, 2024]
Progress has been made on the backend of the application, which is nearing completion. Work will begin on the frontend soon, including a new file upload feature.

[Devnote - July 4, 2024]
Primary system classes and functions have been finalised in latest nexshare commit 045cba1. Work will commence on frontend design and features.


Support disable of debug output for atmel-samd

We should support disabling any debug output, like in the esp port.  The os.debug(None) call in the esp port accomplishes this task--let's see how it's implemented and do it for samd21 too.

I can't find any info about os.debug. I did silence the gc debug output though.


api acess

This is not a GUI-component, it's an API

Any plans to make it available as an API?

What do you mean?

Sorry, ignore this


bash: read: read error: 0: Input/output error

When i hit ctrl+space i get this error which freezes up the terminal window.
My bash version is here:
GNU bash, version 4.4.0(1)-release (x86_64-pc-linux-gnu)
Any ideas?
Thanks

found out that commenting line 14 in bin/marker.sh solves the problem for me:
# stty raw -echo min 0

thx @podkot, worked like a charm!

fixed in latest master(please re-clone or pull)


Apply text opacity decoration without setting text color

I'm working on the C++ extension here at Microsoft. One of our features for this release is inactive region colorization, similar to Visual Studio. While we've achieved end to end, there are a couple "nice to have" changes that would make the feature shine more. For modularity's sake I will expound upon just one here.
We would like a way to modify only the opacity of text without modifying other properties. We are using vscode.TextEditor.setDecorations to apply a text decoration to the inactive region. vscode.TextEditor.setDecorations applies properties filled out in a vscode.DecorationRenderOptions. However, this interface does not allow for directly setting the opacity of the text without modifying the other color properties. E.g. supplying rgba:(150,150,150,0.5) will set the opacity with the unwanted side effect of changing the color to gray.
Are there other means of setting the text opacity unaware to us? If not, we would greatly appreciate having such a thing implemented to give the user an experience more comparable to Visual Studio.

As part of #15710, I'd also like to do the same for JS and TS

Verified using the following extension:

package.json:

{
    "publisher": "alex",
    "name": "43004",
    "version": "0.0.0",
    "engines": {
        "vscode": "^1.0.0"
    },
    "activationEvents": [
        "*"
    ],
    "main": "index.js"
}

index.js:

const vscode = require('vscode');

exports.activate = function () {
	var dectype = vscode.window.createTextEditorDecorationType({
		opacity: '0.5'
	});
	vscode.window.activeTextEditor.setDecorations(dectype, [
		new vscode.Range(0, 0, 0, 1),
		new vscode.Range(1, 0, 1, 1),
		new vscode.Range(2, 0, 2, 1),
		new vscode.Range(3, 0, 3, 1),
		new vscode.Range(4, 0, 4, 1),
		new vscode.Range(5, 0, 5, 1),
		new vscode.Range(6, 0, 6, 1),
		new vscode.Range(7, 0, 7, 1),
		new vscode.Range(8, 0, 8, 1),
		new vscode.Range(9, 0, 9, 1),
	]);
}


Send attachments and push notifications

Is it possible to get push notifications and send attachments ?

Hi,
We have not invested push notifications yet but it is something we can definitely add to the backlog.
For sending attachments we do support that with https://github.com/Azure-Samples/communication-services-javascript-quickstarts/tree/main/ui-library-filesharing-chat-composite, however today we don't have plans about bringing file sharing into the chat hero sample but it is something we can add to the backlog as well.
Let me know if that answers your question
Thanks!

Closing this issue due to > 10 days with no response


Title in navbar misaligned

Anchor the nav bar to the start and modify it with padding so that it matches the alignment of the navoptions icons

Fixed the image alignment. The issue is not closed, but it is now safe for release


[ML] chore: Bump azure-ai-ml to 1.16.0

Description
This pull request:

Adds a new changelog entry for 1.16.0
Bumps _version.py to 1.16.0

All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


fix(fairs): Scrolling on fair exhibitors crashes the app

This PR resolves PHIRE-531
Description
Fixes the ArrayIndexOutOfBoundsException crash from sentry on the fair page.
The issue was located inside the renderItem functions ~ returning null instead of an element inside there caused the ArrayIndexOutOfBoundsException crash, filtering the data before passing them on the flatlist fixed the issue.
Beta that was failing: all of them ~ beta that it is fixed: codepush-canary-android-8.30.0-2<IP_ADDRESS>
Steps to reproduce:

Open the artsy app on prod environment (fair exhibitors are empty on staging)
scroll to the bottom of the homepage
press any of the two first fairs on the last home rail
start scrolling up and down

Previous behavior:
App was crashing
Expected behavior:
users are able to scroll normally.
Bonus fixes:

some tiny performance improvements by pulling out the renderItem and keyExtractor.
fetches 10 exhibitors per fetchMore to reduce the load

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

fixes scrolling on fair exhibitors crashes the app - gkartalis

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (fixes scrolling on fair exhibitors crashes the app - gkartalis)

  Generated by :no_entry_sign: dangerJS against a9b38998b2437ba0e219f289991a96e9ad7d9770


UBI image for 'configure' container?

The egeria container image is based on the RedHat UBI 8 openjdk base image. See https://www.redhat.com/en/blog/introducing-red-hat-universal-base-image . This is a supported, secure , OCI compliant image that passes container security checks on quay.io
However we also use some other containers to support demos and UI, which are based on lighter images such as alpine, and these may not be as secure.
Full data is available on quay.io by selecting the image under https://quay.io/organization/odpi, for example the egeria base image at https://quay.io/repository/odpi/egeria?tab=tags
We should consider using secure base images for all the container images we build (not just in egeria, but in other projects such as our connectors)
The downside is that newer images may increase the memory footprint - this may in particular be more painful on arm platforms. (the mitigation there may be needing alternate image definitions)
cc: @lpalashevski

We still have

a small 'configure' Docker image -- https://catalog.redhat.com/software/containers/ubi8/ubi-minimal/5c359a62bed8bd75a2c3fba8 possible replacement:
jupyter - could start with https://catalog.redhat.com/software/containers/ubi8/nginx-118/5f521a6f9dd2d5ca7158e5dc but need to add jupyter

Still needed:

supported base image
tested/updated for security vulnarabilities
consistent with image used for base egeria
hosted on quay.io so will avoid dockerhub pull request limitations (but note that either side could have outages)

The small configure image is used in various places where Jupyter is not needed, in particular for parts of setting up the PTS and CTS charts -- so keen we keep that image as its own image (nice and small).

#289 and #311 address updating our UI containers to UBI
Focus here on 'configure'. There is a UBI new micro image. Will review security scans / docs and figure out next step for this container

I'm thinking that perhaps we can remove this container entirely, and use a regular image (the lightest 'UBI' image ideally as it provides a better security stance).
We only use this image for simple scripts, which can be injected through a volume mount/config map or similar techniques.
This would mean one less image to maintain, scan & allow our process to focus on the egeria specifics

This image should be harmless, but can likely be replaced with use of a standard, simple image, without any added tools


Testing on my own dataset is not good

Hello author, I trained my own data in the test, the effect is good.However, the effect is poor when I really query the pictures that are not in the picture library. Could you help me analyze the reason

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Sorry for late reply, can you try with the new version of the code?


add response to API-callback

enabling to use the original response from jira-api for more flexibility

Awesome!  Going to merge and publish as 2.0, will update this PR when published

Published as 2.0.0; sorry for the late action on this one!


Price Value too Low ?

This is the STORM/BTC chart from Binance,
i have set the precision of the chart to 12 but the price scale wont adjust and will always stay on the Range 0,1
Are the Price Values too low?

This is how it looks on the Binance website
Thanks for this Great project

Sorry 5.2.1 already Fixed it :)


Who's on first?

@Eklucas and our friends at IRE need to know which room each of us will be in this year.
What do you think about this lineup, to start the discussion?
##Room 0

@chrislkeller
@katiepark
@Kevinschaul
@Rdmurphy

##Room 1

@Esagara
@Hbillings
@Tommeagher

This is not the order of teaching for the day, just to get us each in a room. If you want to switch rooms, that's no problem, just let me know, on here or on email.
If I don't hear from any of you in the next 36 hours, I'll assume we're good, and ship this list to Liz.
On a related note, we could probably use some extra coaches to walk the room and help folks who get stuck. We'll particularly need help in Room 1, and when some of us have to step out to speak at other sessions.
Who do you think we should recruit to lend a hand?
Thanks,
Tom

Yo! just a heads up that @rnagle, @malev are also teaching intro to Python at NICAR this year. Is this related to what you have here @tommeagher?

@aboutaaron, I hadn't heard that, but I know there a ton of python sessions this year. This one is for the full-day mini boot camp on Thursday. I'm guessing they're doing one of the sessions on another day. If @rnagle and @malev want to help, we'd be happy to have them and to return the favor during their class.

Ok, for the program we're going to go with @tommeagher's suggestions above for room breakdown. But if last-minute switches need to happen, that's not a big deal either.

Thanks, Liz!


Load Model with ForeignKey doesn't work

I have a Model with 3 ForeignKeys. I did everything like the guide but when I try to load a list of this model the app ends in an endless loop of loading.
The only thing I see is the garbage collector outputs:
Background sticky concurrent mark sweep GC freed 923969(16MB) AllocSpace objects, 0(0B) LOS objects, 18% free, 35MB/43MB, paused 4.915ms total 125.013ms
This is my Model:
@Table(databaseName = DatabaseAdapter.NAME)
public class Car extends BaseModel {
    public static final String COLUMN_ID                = "id";
    public static final String COLUMN_ERA               = "era";
    public static final String COLUMN_MANUFACTURER      = "manufacturer";
    public static final String COLUMN_CATEGORY          = "category";
    public static final String COLUMN_UPDATED_AT        = "updated_at";
    public static final String COLUMN_MANUFACTURE_ID    = "manufacture_id";

    @SerializedName("id")
    @Column(name = COLUMN_ID)
    @PrimaryKey
    public int id;

    @SerializedName("era")
    @Column
    @ForeignKey(references = {@ForeignKeyReference(
            columnName = COLUMN_ERA,
            columnType = Integer.class,
            foreignColumnName = Era.COLUMN_ID)},
            saveForeignKeyModel = false)
    public Era mEra;

    @SerializedName("manufacturer_id")
    @Column(name = COLUMN_MANUFACTURE_ID)
    public int mManufactureId;

    @Column
    @ForeignKey(references = {@ForeignKeyReference(
            columnName = COLUMN_MANUFACTURER,
            columnType = Integer.class,
            foreignColumnName = Manufacture.COLUMN_ID)},
            saveForeignKeyModel = false)
    public Manufacture mManufacture;

    @SerializedName("category")
    @Column
    @ForeignKey(references = {@ForeignKeyReference(
            columnName = COLUMN_CATEGORY,
            columnType = Integer.class,
            foreignColumnName = Category.COLUMN_ID)},
            saveForeignKeyModel = false)
    public Category mCategory;

    @SerializedName("updated_at")
    @Column(name = COLUMN_UPDATED_AT)
    public int mUpdatedAt;
}

@Informaticore is there any possibility you have a recursive, two way relationship here? like one of the foreign keys references this table as a foreign key?

I tripple checked it. The three foreign objects have just primitive types inside. But all 3 extend a MyBaseModel which extend the BaseModel of DBFlow.

@agrosner  does the columnName should be the same as the variable name? Here I have mEra as variable and *era" as column name. But maybe I forgot to set foreignKeysSupported = true in the DatabaseAdapter, because no ForeignKEy is working correctly.

@agrosner I forgot to add foreignKeysSupported = true BUT now I added it, invalidated caches, re-installed the app and everything but it changed just nothing. ForeignKeys are not working and for this Car object it still ends up in a endless loading loop.
This is my query:
    new Select().from(Car.class).where(Condition.column(Car.COLUMN_MANUFACTURE_ID).eq(manufactureId)).async().queryList(listener);

Car.COLUMN_MANUFACTURE_ID is not the ForeignKey - its just the ID.
I also changed the variable names but it didn't changed anything.

Gson was the problem! I tried the app on a different phone and it crashed because this phone was much slower, so I could figure out that it was gson which couldn't handle the BaseModel mModelAdapter.

@Informaticore have a fix in 2.2 to lazy-load the model adapter so superclasses that extend BaseModel don't crash when created if they aren't used for DB operations.

Hi @agrosner
Do you have some news about the version 2.2? I am asking because i have a problem with foreign key too:
I have a model with four foreign keys (one to one).
public class Match extends BaseModel implements Serializable {

    @SerializedName("id")
    @Column
    @PrimaryKey(autoincrement = false)
    long _id;

    @Column
    private Date date;

    @Column
    @ForeignKey(
            references = {@ForeignKeyReference(columnName = "team1_id",
                    columnType = Long.class,
                    foreignColumnName = "_id")},
            saveForeignKeyModel = true)

    Team team1;

    @SerializedName("team1_score")
    @Column
    private int team1Score;

    @Column
    @ForeignKey(
            references = {@ForeignKeyReference(columnName = "team2_id",
                    columnType = Long.class,
                    foreignColumnName = "_id")},
            saveForeignKeyModel = true)
    Team team2;

    @SerializedName("team2_score")
    @Column
    private int team2Score;

    @Column
    @ForeignKey(
            references = {@ForeignKeyReference(columnName = "competition_id",
                    columnType = Long.class,
                    foreignColumnName = "_id")},
            saveForeignKeyModel = true)

    Competition competition;

    @Column
    @ForeignKey(
            references = {@ForeignKeyReference(columnName = "match_id",
                    columnType = Long.class,
                    foreignColumnName = "_id")},
            saveForeignKeyModel = true)

    MatchLocation location;

    //getter and setters
}

I am using GSon to deserialze a Json into this Model. After gson deserialization, I print/check the model's primary key objects (team1, team2, competition and matchlocation) and everything is fine. But, when I get the Match model from DB, some primary key objects is null.
Follow is my code:
// I use this same code piece for all matches
Match match = getMatchFromJson(json); //using Gson library
CustomLog.debug( m.toString() ); //All primary keys filled
m.save()

List<Match> listMatch = new Select().from(Match.class).queryList();
for (Match m : listMatch) {
       CustomLog.debug(m.toString()); //Some match does not have the primary keys objects filled
 }

Thanks!
Great job et all!

@agrosner I made another test: i created all the models objects by myself (without gson deserialize) and everything worked fine!
So, the problem is something in GSON model deserialized + Dbflow.
Do you have any idea about what can be wrong?
It's so weird because when i print the model instance from gson deserialization, all the fields were filled ok.
Thanks!

@gustahrodrigues This helped me with Gson:
mGson = new GsonBuilder()
                .setExclusionStrategies(new ExclusionStrategy() {
                    @Override
                    public boolean shouldSkipField(FieldAttributes f) {
                        return f.getDeclaredClass().equals(ModelAdapter.class);
                    }

                    @Override
                    public boolean shouldSkipClass(Class<?> clazz) {
                        return false;
                    }
                })
                .create();

This will skip the ModelAdapter which is in the BaseModel.

@agrosner now I have the problem that my One-to-Many relation is not loading. I added @ModelContainer to this class and did this like the doc:
@SerializedName("store_items")
public List<ShopItem> shopItems;

@OneToMany(methods = {OneToMany.Method.ALL})
public List<ShopItem> getShopItems() {
    if(shopItems == null) {
        shopItems = new Select()
                .from(ShopItem.class)
                .where(Condition.column(ShopItem.COLUMN_SHOP_CATEGORY).is(id))
                .queryList();
    }
    return shopItems;
}

This is inside the ShopItem class:
@Column
@ForeignKey(references = {
@ForeignKeyReference(columnName = COLUMN_SHOP_CATEGORY, columnType = Integer.class, foreignColumnName = ShopCategory.COLUMN_ID)}, saveForeignKeyModel = false)
public ForeignKeyContainer<ShopCategory> mShopCategory;

From the docs it says I do not have to save the items myself. So if I save the ShopCategory it also saves all ShopItems.
The mShopCategory variable in ShopItem is always null, so the Select would never work. When I get the data from the network the ShopItems are set, but the variable is null. Do I have to set them?

@Informaticore thanks for your reply.
I am already used this code piece. So, with this code piece, i am getting model instance from json. After thath, i get the model instance generated from GSON and try to save. All foreign key model is save right, (team, competition and matchlocation) but when i try to get the match instance using select, some foreign key model from match is null.
For select matches, i am using:
List<Match> listMatch = new Select().from(Match.class).queryList();

After several intestigations, i found the problem, but i don't know how to solve it:
In Match$Adapter, method loadFromCursor(Cursor cursor, Match model), when it perform cursor.getLong(indexteam1_id) always returned -1, but the team model was saved. Variable indexteam1_id is 2 and I debug the code and the cursor variable at position 2 has the correct team id.
It's happening with all my foreign key.
@agrosner do you know what happening ?
Thanks!!

@gustahrodrigues where is the -1 coming from? Do you have this value in the json or something?
And I saw that you used autoincrement = false, maybe this is incorrect?

@Informaticore I was getting -1 from cursor.getString(index); when index corresponds to my foreign key. Autoincrement is false because i am getting the id from server.
I finally found the problem and the solution!!
In my models Team, Competition and MatchLocation , i had a Unique field @Unique(unique = true, onUniqueConflict = ConflictAction.IGNORE).
So when i was trying to save a model with unique conflict, the Ignore constraint just ignore the save and didn't get the reference to Match (foreign key). I think the right behavior would be: "on ignore unique conflict, not save, just get the reference model instance(id)".
What do you think about ir @agrosner  ?


Join the x509 and x509v3 directories

This has been long overdue.
Note that this does not join the X509 and X509V3 error modules, that
will be too many macro changes at this stage.
Fixes #8919

Oh, I should probably add a note in CHANGES

Done

Needs a rebase..

After collapsing the v3 folder, does not merging the error modules cause any issues if a new error code is added?

After collapsing the v3 folder, does not merging the error modules cause any issues if a new error code is added?

Nope.  It turns out that several error modules can coexist in the same directory, as they all depend on the start of the _F_ and _R_ macro names.

Rebase done

Needs a rebase - I approve otherwise

So err, I did the rebase, I'll take that as approval.

The CI loop hasnt finished yet :)

One thing I haven't quite dived into is joining include/openssl/x509.h and include/openssl/x509v3.h...  should that be part of this PR, or should I make a new PR for it?

new PR maybe

Merged.
878dc8dd9572a719d3b481e7f68af8bf17f4c68e Join the x509 and x509v3 directories

You'll have to make sure a stub x509v3 file exists to not break applications of course.

You'll have to make sure a stub x509v3 file exists to not break applications of course.

I guess you are talking about the x509v3.h include file? No public include files were modified by this commit:
git show --stat 878dc8dd9572 -- include


Deprecations are addressed to maintain compatibility with 2021.3 onward

Fixes #63 :

CompletionProvider.<init>(boolean) deprecation is addressed. It is removed in 2021.3. Even in 2016.2 it is just empty and doesn't use boolean parameter in any way, so safe to simply remove the argument.

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[ ] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Reference build for delta reports
Plugins » idea-stapler-plugin » master #4

Why didn't it pick up Build 12 as the reference build? This targets the HEAD of the master branch which was built by build 12. 🤔


Stage email_opt_in from BigQuery

User Story
@dseaton thinks it's useful to stage email_opt_in to our data platform
Description/Context
Source definition https://github.com/MIT-IR/simeon/blob/main/simeon/upload/schemas/schema_email_opt_in.json
Sample data
This table appears to contain the most recent email for the user and but it also repeats the same user info in every course user has enrolled in.
user_id | username | email | full_name | course_id | is_opted_in_for_email | preference_set_datetime |
-- | -- | -- | -- | -- | -- | -- | --
41245380 | asldfxxxxxxx |<EMAIL_ADDRESS>| Axxxxxx | MITx/18.01.1x/2T2022 | false | 2022-05-13 18:02:01 UTC |
41245380 | asldfxxxxxxx |<EMAIL_ADDRESS>| Axxxxxx | MITx/18.031x/2T2022 | false | 2022-05-13 18:02:01 UTC |
41245380 | asldfxxxxxxx |<EMAIL_ADDRESS>| Axxxxxx | MITx/3.012Tx/2T2020 | false | 2022-05-13 18:02:01 UTC |
41245380 | asldfxxxxxxx |<EMAIL_ADDRESS>| Axxxxxx | MITx/6.431x/2T2022 | false | 2022-05-13 18:02:01 UTC |
41245380 | asldfxxxxxxx |<EMAIL_ADDRESS>| Axxxxxx| MITx/21M.030x/3T2021 | false | 2022-05-13 18:02:01 UTC |
41245380 | asldfxxxxxxx |<EMAIL_ADDRESS>| Axxxxxx | MITx/8.04x/3T2020 | false | 2022-05-13 18:02:01 UTC |

@dseaton I created this issue as you mentioned that this might be helpful to stage.  It's helpful to use it as a reference to figure out the user's most recent email, but this table is not one row per user, it's unique on user_id+course_id, which repeats the same user info for every course they enroll in, so we need to think about whether we need to stage this table as it is or aggregate it into one row per user.

I would be ok with "staging" this model as is, then considering intermediate models that might make it easier to use (e.g., making a unique user model with only the latest info). Then we have the raw data staged and can create better tables in the next layers.
Note, please let me know if there are performance considerations. For example, if this just adds one more 12M row table that we have to parse/build every time we run dbt. Is that a concern?

Yes, there is a performance concern as this is a huge table, but it looks like it has a timestamp field which we might be able to use for incremental

Got it.


help prints --dir but its not in the parse options list

$ runLMBFGS_relion.py -h
Usage: runLMBFGS_relion.py --dir= --bin=

Thanks for point this out @WolfgangLugmayr - that was an extraneous input option that was not used.
All you need is a starfile and a particle radius, and then any other options you'd like, but there are defaults already provided.


export filtering step to standalone script

Here the krakenuniq output filtering is done only once in a small script, then the krakenuniq.output.filtered output is used wherever possible to avoid redundant filtering steps
Notice how the hardcoded 1000 in filtered_taxIDs_kmers1000 should be changed at a later stage since the "1000" comes from a configurable parameter

Fixes #88

And here is how the DAG looks now:

It is for the test output. Should we add a diff check in the github actions?

I guess at some point we should. It's one thing that the workflow runs, another that we actually can reproduce the same results. I think this will take some time to implement though. Anyhow, I'll go ahead and merge and we could keep this in mind for the future.


Wrong annotation in the dumped file

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Expected Behaviour
Annotation is dumped correctly
Current Behaviour
For a reason the dumped annotation for multi-job tasks may contain some extra shapes which don't exist in the database for this job. UI representation is correct:
For example frame 86496 of 34372 job:
<image id="86496" name="336728.png" width="288" height="144">
    <box label="bad_quality" occluded="0" source="manual" xtl="0.00" ytl="0.00" xbr="288.00" ybr="144.00">
    </box>
    <box label="wrong_subject" occluded="0" source="manual" xtl="0.00" ytl="0.00" xbr="288.00" ybr="144.00">
    </box>
  </image>

>>> db_job = Job.objects.filter(id=34372)[0]
>>> db_shapes = db_job.labeledshape_set.filter(frame=86496)
>>> db_shapes.count()
1

Update:
For some reason, other jobs contain annotations for this frame and this is causing the wrong shapes to appear in the dump file
>>> db_job = Job.objects.filter(id=34371)[0]
>>> db_shapes = db_job.labeledshape_set.filter(frame=86496)
>>> db_shapes.count()
1

Possible Solution

Steps to Reproduce (for bugs)
N/A
Context

Your Environment

Git hash commit (git log -1): a222741f6b3c9fea4f363f475ef9fcd4a85c6a7d
Docker version docker version (e.g. Docker 17.0.05): 19.03.6
Are you using Docker Swarm or Kubernetes?
Operating System and version (e.g. Linux, Windows, MacOS): Ubuntu 18.04
Code example or link to GitHub repo or gist to reproduce problem:
Other diagnostic information / logs:
Logs from `cvat` container

Next steps
You may join our Gitter channel for community support.

I haven't been able to reproduce this issue. I will close this issue. Reopen it if you have this problem please.


Inconclusive objects

Hello,
I found an object with the class = "Inconclusive" in the frames dataset but I cannot find this in the annotation guide as one of the annotated classes. It is also not a part of the OBJECT_CLASSES tuple ´from zod.anno.object import OBJECT_CLASSES´. How should this class be handled?

This was no longer an issue when we used ´frame.get_annotation(AnnotationProject.OBJECT_DETECTION)´.


Chocolatey pack regression in Cake 0.32.0

2caa01812ec232efc0758b3589ecd8c16d04e413 introduced a bug with Chocolatey pack, null checks need to be converted to Any()

@devlead We should probably add tests to other tools as well that this PR touched to make sure we didn't break any of them as well.

@patriksvensson yip

Oops, I'm sorry! 😞


Update log function location

Link to most recent commit so line number stays constant

Description & motivation
Current line number is wrong
To-do before merge

Prerelease docs
If this change is related to functionality in a prerelease version of dbt (delete if not applicable):

[ ] I've added versioning components, as described in "Versioning Docs"
[ ] I've added a note to the prerelease version's Migration Guide

Checklist
If you added new pages (delete if not applicable):

[ ] The page has been added to website/sidebars.js
[ ] The new page has a unique filename

If you removed existing pages (delete if not applicable):

[ ] The page has been removed from website/sidebars.js
[ ] An entry has been added to _redirects

Closing due to non-review.


drawerController is null in viewWillDisappear and viewDidDisappear

Extension property drawerController of UIViewController returns nil when I'm trying to access it in viewWillDisappear and viewDidDisappear methods of my view controller. Could you please explain this behaviour if it's correct or fix it if there is some bug?

The situation is not reproduced. Can you tell me what circumstances?

This issue can be observed when UINavigationController is located inside DrawerController, I have controllers A and B in navigation stack and I press back button in B. ViewWillDisappear and ViewDidDisappear of B will be called, but in both of them drawerController property is equal to nil. If necessary, I'll prepare sample project.

UPD. Sorry, in this case the problem doesn't reproduce. I'll prepare another sample sample.

If that's what I understand:
DrawerController <- UINavigationController
  UINavigationController <- A
  UINavigationController <- B

Since A and B are not managed directly by DrawerController, nil value is correct.

But in other lifecycle methods drawerController is not nil...

What is "other lifecycle"?

for example, viewdidLoad.

I have tested the code.
In viewDidDisappear, it is normal for the drawerController variable to be nil.
Because there is no parentViewController at the time when viewDidDisappear is called.

OK, maybe it's the feature, not bug :)
Please update package in Cocoapods.


Aligned aggregate state  #2754

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
The change is to use aligned aggregate state if it is allocated from arena(the problem occur). During my test, the impact is negligible.

Usages of aggregate states:
FunctionsMiscellaneous
FunctionsArray
GraphiteRollupSortedBlockInputStream
SummingSortedBlockInputStream
TotalsHavingBlockInputStream
were forgotten.

AggregateFunctionIf
AggregateFunctionNull
...

ColumnAggregateFunction::getExtremes


Codecov Report

Merging #8115 (d82cd8c) into dev (d6e1d95) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #8115      +/-   ##
============================================
- Coverage     41.39%   41.38%   -0.02%
+ Complexity     3731     3730       -1
============================================
  Files           637      637
  Lines         27141    27141
  Branches       3089     3089
============================================
- Hits          11236    11233       -3
- Misses        14822    14824       +2
- Partials       1083     1084       +1

Impacted Files
Coverage Δ

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
83.33% <0.00%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e1d95...d82cd8c. Read the comment docs.


Theme is stored in localStorage but not applied when returning to the site

Steps to Recreate

Set site to dark theme
Go to a different site/close the tab
Head on back to koamar.com

Expected Result
Site is displayed in dark theme
localStorage.getItem('theme') = 'dark'
Actual Result
Site is back to the default of light theme
This is true though: localStorage.getItem('theme') = 'dark'

Looks like I'm not looking in localStorage before going out and getting the default theme. Need to look in my notes to fix this!


update findbugs-maven-plugin version to 3.0.3 and configure it to spe…

…nt maximum effort

@joel-costigliola What about merging this?

I wanted to test it before integrating, I'm not always fond of some findbugs violations, some parts of AssertJ don;t follow the strict findbugs rules for good reason. I don't want to fail the build in that case.

Thanks for the info.
As there are already some violations (at least in AssertJ core) I believe that some more won't make a difference. Is the build configured to only allow a limited number of findbug violations?

As far as I can tell the build won't fail even if there are more violations.


Added getrs

Adds getrs to hipSOLVER

I appear to have run the bad_arg tests on the CUDA machine at a time when the tests weren't actually triggering (see
https://github.com/ROCmSoftwarePlatform/hipSOLVER/pull/10/commits/ed3b239a45a295424d5277b4630b257c0527bc36). Running them properly is causing failures. The nullptr checks, in particular, seem to be causing all future tests to fail, so I've changed the bad_args tests to only check the invalid enum returns.

I appear to have run the bad_arg tests on the CUDA machine at a time when the tests weren't actually triggering (see
ed3b239). Running them properly is causing failures. The nullptr checks, in particular, seem to be causing all future tests to fail, so I've changed the bad_args tests to only check the invalid enum returns.

And so, what would actually happen if a user passes an invalid pointer?
The rocsolver backend will return rocblas_status_invalid_pointer, but how this would be translated to a hipsolver status? Is there a way to test this?
What about on the cusolver side?

And so, what would actually happen if a user passes an invalid pointer?
The rocsolver backend will return rocblas_status_invalid_pointer, but how this would be translated to a hipsolver status? Is there a way to test this?
What about on the cusolver side?
I think this needs to be addressed not eliminated from the tests...

With the rocsolver backend, rocblas_status_invalid_pointer is translated to HIPSOLVER_STATUS_INVALID_VALUE and the tests pass. Passing a nullptr into the cuSOLVER backend does not appear to return an error - the returned status is HIPSOLVER_STATUS_SUCCESS and the tests fail. Worse, it seems to cause issues with future hip calls - I've gotten errors from hipFree and our memcheck calls after passing a nullptr.
I'm not sure there's any way to test this, since cuSOLVER is not reporting an error and it causes failures in all future tests.

I suppose I could put nullptr checks into the hipSOLVER functions with the cuSOLVER backend. We can make hipSOLVER robust to nullptrs even if cuSOLVER is not.

I am not sure about modifying the behaviour of the CUDA backend; if they don't care about null input pointers and return success (I guess is a quick return), then hipSOLVER should return success as well.
Maybe the solution is to skip the null-pointer test for the CUDA backend (or check that the returned status is success), but keep testing for the HIP backend. Would that be possible?

Given that passing null pointers causes future tests to fail, it sounds like cuSOLVER is simply not doing any checks at all. If you want to only do them for the rocm backend, you could put the tests in an #ifdef __HIP_PLATFORM_AMD__ section.

__HIP_PLATFORM_AMD__ did not appear to be defined when I tried to run the tests, so I used __HIP_PLATFORM_NVCC__ instead. The cmake files indicate it will always be defined when we use the cuSOLVER backend.

__HIP_PLATFORM_HCC__ is being replaced with __HIP_PLATFORM_AMD__ and __HIP_PLATFORM_NVCC__ is being replaced with __HIP_PLATFORM_NVIDIA__.
We could probably use #if defined(__HIP_PLATFORM_HCC__) || defined(__HIP_PLATFORM_AMD__) for compatibility.


only show embed after user has clicked

Fixes #20

@KendallDoesCoding Are you using a CSS Grid or Flexbox?

@KendallDoesCoding Are you using a CSS Grid or Flexbox?

I'm unsure. I don't think so.

alr

It's working good, it just needs to be made so that the embed is in the center. Which I think your working on and that's why you asked that question.

yeah I was wondering 'cause well flexbox AND grid allow you to center it

yeah I was wondering 'cause well flexbox AND grid allow you to center it

oh lol...

Ok, I fixed the thing, now it center aligns. The three times issue was just a mouse problem. But I'm not changing it back cause the order of closing center and embed, doesn't matter.

@KendallDoesCoding it would be. However, that's way too difficult to track and might even slow down the website.

@KendallDoesCoding it would be. However, that's way too difficult to track and might even slow down the website.

Ok, so you suggest we don't add that? So should I merge this now?

Yep

Ok, I'm merging this request.