HDFS-15417. RBF: Get the datanode report from cache for federation WebHDFS operations

https://issues.apache.org/jira/browse/HDFS-15417
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 14s
trunk passed

+1 :green_heart:
compile
0m 35s
trunk passed

+1 :green_heart:
checkstyle
0m 26s
trunk passed

+1 :green_heart:
mvnsite
0m 38s
trunk passed

+1 :green_heart:
shadedclient
14m 58s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 35s
trunk passed

+0 :ok:
spotbugs
1m 11s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 10s
trunk passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 23s
hadoop-hdfs-rbf in the patch failed.

-1 :x:
compile
0m 21s
hadoop-hdfs-rbf in the patch failed.

-1 :x:
javac
0m 21s
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
checkstyle
0m 17s
the patch passed

-1 :x:
mvnsite
0m 24s
hadoop-hdfs-rbf in the patch failed.

-1 :x:
whitespace
0m  0s
The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
13m 43s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s
the patch passed

-1 :x:
findbugs
0m 26s
hadoop-hdfs-rbf in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 26s
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

57m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2080

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4e41ed003cc1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 89689c52c39

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/1/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/1/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/1/artifact/out/whitespace-eol.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/1/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/1/testReport/

Max. process+thread count
415 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
22m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 52s
trunk passed

+1 :green_heart:
compile
0m 39s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 35s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 26s
trunk passed

+1 :green_heart:
mvnsite
0m 38s
trunk passed

+1 :green_heart:
shadedclient
14m 50s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 28s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 34s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  6s
trunk passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 21s
hadoop-hdfs-rbf in the patch failed.

-1 :x:
compile
0m 22s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javac
0m 22s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
compile
0m 21s
hadoop-hdfs-rbf in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.

-1 :x:
javac
0m 21s
hadoop-hdfs-rbf in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.

-0 :warning:
checkstyle
0m 17s
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 2 new + 16 unchanged - 0 fixed = 18 total (was 16)

-1 :x:
mvnsite
0m 22s
hadoop-hdfs-rbf in the patch failed.

-1 :x:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
13m 43s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 25s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 30s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
0m 23s
hadoop-hdfs-rbf in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 24s
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

80m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2080

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 9718ab5f9378 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 100ec8e8709

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/whitespace-eol.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/testReport/

Max. process+thread count
407 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
21m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 30s
trunk passed

+1 :green_heart:
compile
0m 40s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 34s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 24s
trunk passed

+1 :green_heart:
mvnsite
0m 40s
trunk passed

+1 :green_heart:
shadedclient
15m 14s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 29s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 35s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 12s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  9s
trunk passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 21s
hadoop-hdfs-rbf in the patch failed.

-1 :x:
compile
0m 22s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javac
0m 22s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
compile
0m 21s
hadoop-hdfs-rbf in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.

-1 :x:
javac
0m 21s
hadoop-hdfs-rbf in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.

-0 :warning:
checkstyle
0m 17s
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 2 new + 16 unchanged - 0 fixed = 18 total (was 16)

-1 :x:
mvnsite
0m 22s
hadoop-hdfs-rbf in the patch failed.

-1 :x:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
13m 38s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 24s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
0m 26s
hadoop-hdfs-rbf in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 24s
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

81m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2080

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 47d291b74bfe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 100ec8e8709

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/whitespace-eol.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/testReport/

Max. process+thread count
458 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
22m 31s
trunk passed

+1 :green_heart:
compile
0m 39s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 34s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 22s
trunk passed

+1 :green_heart:
mvnsite
0m 38s
trunk passed

+1 :green_heart:
shadedclient
16m 17s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 24s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 31s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 15s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 13s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s
the patch passed

+1 :green_heart:
compile
0m 37s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 37s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 26s
the patch passed

-0 :warning:
checkstyle
0m 15s
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 2 new + 16 unchanged - 0 fixed = 18 total (was 16)

+1 :green_heart:
mvnsite
0m 30s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 51s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 22s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 28s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
1m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 47s
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

77m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2080

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux da20e90c648e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 201d734af39

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/4/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/4/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/4/artifact/out/whitespace-eol.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/4/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/4/testReport/

Max. process+thread count
3083 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
26m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m 35s
trunk passed

+1 :green_heart:
compile
0m 37s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 31s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 20s
trunk passed

+1 :green_heart:
mvnsite
0m 34s
trunk passed

+1 :green_heart:
shadedclient
16m  6s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 24s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 30s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  6s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s
the patch passed

+1 :green_heart:
compile
0m 31s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 31s
the patch passed

+1 :green_heart:
compile
0m 25s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 25s
the patch passed

-0 :warning:
checkstyle
0m 15s
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 2 new + 16 unchanged - 0 fixed = 18 total (was 16)

+1 :green_heart:
mvnsite
0m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 34s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 22s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 27s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
1m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
10m  1s
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

100m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2080

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f6b832c725fd 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 201d734af39

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/5/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/5/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/5/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/5/testReport/

Max. process+thread count
3142 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks @NickyYe for the update. Yes we can separate the report cache consolidation as a follow-up. Could you create a JIRA for that? Thanks.

Filed: https://issues.apache.org/jira/browse/HDFS-15432

Thanks @sunchao involve me here. In my internal version I try to turn off getDatanodeReport at Router side and not turn on webhdfs feature, The getDatanodeReport is very expensive for large cluster from my experience.
For this PR, it is almost LGTM from my side, Please check the checkstyle jenkins report: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/5/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt.
IMO it is better to add unit test to verify at Router for this improvement. FYI.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
21m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 15s
trunk passed

+1 :green_heart:
compile
0m 40s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 36s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 25s
trunk passed

+1 :green_heart:
mvnsite
0m 38s
trunk passed

+1 :green_heart:
shadedclient
15m 12s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 29s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 34s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 10s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  7s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s
the patch passed

+1 :green_heart:
compile
0m 32s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 32s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 27s
the patch passed

-0 :warning:
checkstyle
0m 17s
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 2 new + 16 unchanged - 0 fixed = 18 total (was 16)

+1 :green_heart:
mvnsite
0m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 37s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 26s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 30s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
1m 12s
the patch passed

_ Other Tests _

-1 :x:
unit
8m  2s
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

90m 19s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterAllResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2080

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b13a64c43c9e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 84110d850e2

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/6/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/6/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/6/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/6/testReport/

Max. process+thread count
3684 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/6/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks @Hexiaoqiao . Similarly, in our case we also disabled this for router metrics but need webhdfs on router. Relying on getDatanodeReport is not the ideal approach but this PR is a step-up on the existing approach.
@NickyYe thanks for addressing the checkstyle issue. Could you also add a unit test as well? I think we need one for getCachedDatanodeReport. You can add it in TestRouterRpc and verify the cache refresh logic.

Any update @NickyYe ? we are pretty close to get this in with the UT.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m  8s
trunk passed

+1 :green_heart:
compile
0m 40s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 35s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 25s
trunk passed

+1 :green_heart:
mvnsite
0m 38s
trunk passed

+1 :green_heart:
shadedclient
14m 47s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 29s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 34s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  6s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s
the patch passed

+1 :green_heart:
compile
0m 31s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 31s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 27s
the patch passed

-0 :warning:
checkstyle
0m 18s
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 44s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 26s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 30s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
1m 12s
the patch passed

_ Other Tests _

-1 :x:
unit
7m 57s
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

68m 33s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpc

hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2080

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f63854f9d79c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 55a2ae80dc9

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/8/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/8/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/8/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/8/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/8/testReport/

Max. process+thread count
3392 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/8/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
22m 10s
trunk passed

+1 :green_heart:
compile
0m 36s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 31s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 21s
trunk passed

+1 :green_heart:
mvnsite
0m 36s
trunk passed

+1 :green_heart:
shadedclient
16m 36s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 28s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 32s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 15s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 13s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s
the patch passed

+1 :green_heart:
compile
0m 34s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 34s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 28s
the patch passed

-0 :warning:
checkstyle
0m 15s
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)

+1 :green_heart:
mvnsite
0m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 34s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 22s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 26s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
1m 18s
the patch passed

_ Other Tests _

-1 :x:
unit
10m 12s
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

78m 46s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpc

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2080

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux c37581c63ca7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 55a2ae80dc9

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/9/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/9/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/9/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/9/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/9/testReport/

Max. process+thread count
2779 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/9/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 50s
trunk passed

+1 :green_heart:
compile
0m 41s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 35s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 26s
trunk passed

+1 :green_heart:
mvnsite
0m 39s
trunk passed

+1 :green_heart:
shadedclient
15m  4s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 28s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 34s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 11s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  9s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s
the patch passed

+1 :green_heart:
compile
0m 31s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 31s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 27s
the patch passed

+1 :green_heart:
checkstyle
0m 17s
the patch passed

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 42s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 25s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 29s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
1m 11s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
7m 58s
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

68m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2080

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4575909aa2c7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 55a2ae80dc9

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/10/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/10/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/10/testReport/

Max. process+thread count
2916 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2080/10/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Merged. Thanks @NickyYe for the contribution and @Hexiaoqiao for helping review!


Add option for action type transforming

Hi, thank a lot for great logger!
Option for action type transforming will be helpful, if action type is a number (for example, member of some enum). In this case for pretty logging you can provide typeToString function like this:
const enum = {
  1: 'action_one',
  2: 'action_two',
  action_one: 1,
  action_two: 2
};

import createLogger from 'redux-logger';
const logger = createLogger({
  typeToString: (type) => enum[type]
});

// ...
// and somewhere in app
dispatch({type: enum.action_one});

Hi, thanks for idea. Will release in 1.1.0 tomorrow!


HDFS-17599. EC: Fix the mismatch between locations and indices for mover

Description of PR
JIRA: HDFS-17599.
We set the EC policy to (6+3) and also have nodes that were in state ENTERING_MAINTENANCE.
When we move the data of some directories from SSD to HDD, some blocks move fail due to disk full, as shown in the figure below (blk_-9223372033441574269).
We tried to move again and found the following error "Replica does not exist".
Observing the information of fsck, it can be found that the wrong blockid(blk_-9223372033441574270) was found when moving block.
Mover Logs:

FSCK Info:

Root Cause:
Similar to this HDFS-16333, when mover is initialized, only the LIVE node is processed. As a result, the datanode in the ENTERING_MAINTENANCE state in the locations is filtered when initializing DBlockStriped, but the indices are not adapted, resulting in a mismatch between the location and indices lengths. Finally, ec block calculates the wrong blockid when getting internal block (see DBlockStriped#getInternalBlock).
Solution:
When initializing DBlockStriped, if any location is filtered out, we need to remove the corresponding element in the indices to do the adaptation.
How was this patch tested?
Pass the unit test.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 10s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m  1s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 48s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 16s

trunk passed

+1 :green_heart:
shadedclient
36m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 80 unchanged - 0 fixed = 83 total (was 80)

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 33s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
36m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
264m 25s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

404m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6980

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cc5ec294d850 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2f146b09d3e5ebb9d72eb3dc5f00e58eab68c334

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/1/testReport/

Max. process+thread count
3146 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @tomscut for your work, please first fix checkstyle and leave some comments.

The code https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java#L225-L230 can remove
 for(MLocation ml : locations) {
      StorageGroup source = storages.getSource(ml);
      if (source != null) {
        db.addLocation(source);
      }
    }

Thanks @tomscut for your work, please first fix checkstyle and leave some comments.

Thanks for your comments. I update the code.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  1s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m  5s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 27s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 22s

trunk passed

+1 :green_heart:
shadedclient
35m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 59s

the patch passed

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
35m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
268m 57s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

408m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6980

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5692ee4c2710 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ba90e39730242f902e2ab77eeeb66da99e2b7c45

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/2/testReport/

Max. process+thread count
3132 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m  5s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 14s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
36m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
35m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
270m  7s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

425m 14s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6980

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 3788a2731053 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4bc9c717cc8927a4cd45739cb85abe4f5ed66da2

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/3/testReport/

Max. process+thread count
3145 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 26s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
1m 50s

trunk passed

+1 :green_heart:
spotbugs
3m 26s

trunk passed

+1 :green_heart:
shadedclient
36m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
1m 38s

the patch passed

+1 :green_heart:
spotbugs
4m  5s

the patch passed

+1 :green_heart:
shadedclient
37m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
275m  1s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

412m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6980

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a3c38c8a828c 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4bc9c717cc8927a4cd45739cb85abe4f5ed66da2

Default Java
Red Hat, Inc.-1.8.0_412-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/4/testReport/

Max. process+thread count
3145 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/4/console

versions
git=2.9.5 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
24m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 23s

trunk passed

+1 :green_heart:
compile
1m 38s

trunk passed

+1 :green_heart:
checkstyle
1m 25s

trunk passed

+1 :green_heart:
mvnsite
1m 41s

trunk passed

+1 :green_heart:
javadoc
2m  3s

trunk passed

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
36m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  7s

the patch passed

+1 :green_heart:
mvnsite
1m 25s

the patch passed

+1 :green_heart:
javadoc
1m 44s

the patch passed

+1 :green_heart:
spotbugs
3m 21s

the patch passed

+1 :green_heart:
shadedclient
36m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
268m 54s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  5s

The patch does not generate ASF License warnings.

416m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6980

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6fc4b60af7bf 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4bc9c717cc8927a4cd45739cb85abe4f5ed66da2

Default Java
Red Hat, Inc.-1.8.0_312-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/4/testReport/

Max. process+thread count
3143 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/4/console

versions
git=2.27.0 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
5m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 36s

trunk passed

+1 :green_heart:
compile
1m 44s

trunk passed

+1 :green_heart:
checkstyle
1m 25s

trunk passed

+1 :green_heart:
mvnsite
1m 42s

trunk passed

+1 :green_heart:
javadoc
2m  4s

trunk passed

+1 :green_heart:
spotbugs
3m 35s

trunk passed

+1 :green_heart:
shadedclient
38m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  9s

the patch passed

+1 :green_heart:
mvnsite
1m 28s

the patch passed

+1 :green_heart:
javadoc
1m 50s

the patch passed

+1 :green_heart:
spotbugs
4m  8s

the patch passed

+1 :green_heart:
shadedclient
39m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
273m 46s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

407m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6980

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b38c31bc2485 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4bc9c717cc8927a4cd45739cb85abe4f5ed66da2

Default Java
Red Hat, Inc.-1.8.0_312-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/4/testReport/

Max. process+thread count
3140 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6980/4/console

versions
git=2.27.0 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @Hexiaoqiao @tasanuma , could you please review this PR? Thanks.

cc @haiyang1987 @zhangshuyan0 Would you mind to give another review? If no other blocker, please try to push forwards this PR. Thanks.

LGTM. +1 from my side, thanks~

Will commit if no more other comments while wait two workday.

Committed to trunk. Thanks @tomscut  for your works. And @Hexiaoqiao  for your reviews.


Who to contact for security issues

Hey there!
I belong to an open source security research community, and a member (@sudheendra17) has found an issue, but doesn’t know the best way to disclose it.
If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.
Thank you for your consideration, and I look forward to hearing from you!
(cc @huntr-helper)

Hi @zidingz! Good idea, I've added a file. Please contact<EMAIL_ADDRESS>if you have any questions


Add a license to the repository

I recently came across your project Entanglement-Purification-Protocol-Qiskit- and I noticed that the repository github.com/Hena234/Entanglement-Purification-Protocol-Qiskit- currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

Thanks for the information. I have added the license to the repo.

Thanks!


Partial import

I discovered that Pixie is very convenient to use with Fenstim.
The problem is that I'm forced to import everything, especially the image support, when I just want to deal with fonts.
I couldn't import just what I needed to write fonts, due to the lack of “.color”

nvm i forgot to import chroma/etc

What's more, it wasn't worth it.


Risky routes are wrongly implemented

A clean risky mechanism should be following routes route:

risky:
   get:
     foo/bar

It also co-insides with the OPTIONS issue.

request method is a good idea. I was thinking of the same. Calling a script will reduce the readability as scripts will be turing complete. A good compromise can be inline zoomba script? I would prefer the request method implementation over scripts


Replace <> with {} in TESTS.md file

I opened an issue on the exercism.io repo regarding odd rendering of the JavaScript TESTING.md file.
There is text that looks like HTML tags that is confusing the renderer.  Let's replace <EXERCISE> etc with {EXERCISE}.
This would be a great 'first time patch' so I'm going to label it that way.
Success criterion:

All patterns like this should be replaced in the MD file.

Reference https://github.com/exercism/exercism.io/issues/3498 for more context.

This wouldn't be my first but if no one else steps up, I'm happy to help.

Go ahead @morrme 👍


fix: make "value" behavior consistent

Task
Prevent dropdown from setting the value back to its initial value on re-renders.
Problem
In our Dropdown component, we were creating a new options array on every re-render
Solution
Create a new options array when the new provided choices props contains different objects (deeply compare it using JSON.stringify)

@mturoci useMemo won't work because we need to deeply compare the choices array instead of simply passing it to the dependency array. We could also create a custom hook for this scenario if we find it handy.

Thanks for the investigation @aalencar. I just checked and my previous statements about components still being recreated instead of updated are not true, not sure what led me there.
I would like to avoid having to do a deep comparison if possible (especially because JSON.parse/stringify are blocking). The problem seems to be that Fluent is not sure what choices should be checked so that it looks for hints in selected / defaultSelected props. I am wondering if changing the component from uncontrolled to controlled wouldn't solve the problem in the same manner.

I would like to avoid having to do a deep comparison if possible

We could freeze choices to its initial array, which in turn wouldn't set didOptionsChange, but this would prevent the user from dynamically changing choices. A common scenario would be fetching new values from an API.

changing the component from uncontrolled to controlled

Would do you mean exactly? Using only selectedKey(s) prop?

We could freeze choices to its initial array, which in turn wouldn't set didOptionsChange, but this would prevent the user from dynamically changing choices. A common scenario would be fetching new values from an API.

This is a no-go, we want to let people update choices.

Would do you mean exactly? Using only selectedKey(s) prop?

https://reactjs.org/docs/uncontrolled-components.html
https://reactjs.org/docs/forms.html#controlled-components
Yes, using selectedKey(s) together with local value state.

This is a no-go, we want to let people update choices.

Agreed.

Yes, using selectedKey(s) together with local value state.

Ok, I will try it out.

I just checked other controlled components and looks like there are other two that might have the same issue:
✅  checkbox
✅  toggle
✅  choice group
❌  checklist BUG
✅  combobox
✅  spinbox
✅  datepicker
❌  colorpicker BUG
✅  picker
✅  range slider
from h2o_wave import main, app, Q, ui

@app("/demo")
async def serve(q: Q):
    if not q.client.initialized:
        items = [
            ui.checklist(name='checklist', label='Checklist', values=["Spam"], choices=[
                ui.choice(name=x, label=x) for x in ['Egg', 'Bacon', 'Spam']
            ]),
            ui.color_picker(name='color_picker', value='#000000', label='Color picker'),

            ui.button(name='submit', label='Submit', primary=True),
        ]
        q.page['example'] = ui.form_card(box='1 1 4 10', items=items)
        q.client.initialized = True
    else:
        items = [
            ui.checklist(name='checklist', label='Checklist', values=["Bacon"], choices=[
                ui.choice(name=x, label=x) for x in ['Egg', 'Bacon', 'Spam']
            ]),
            ui.color_picker(name='color_picker', value="#ffffff", label='Color picker 2'),

            ui.button(name='submit', label='Submit', primary=True),
        ]
        q.page['example'].items = items
    await q.page.save()

onChange was my hope to control value but it's not triggered when choices changes.
@mturoci how do you think a controlled component would prevent the current behavior?

how do you think a controlled component would prevent the current behavior?

I put up a minimal fix example (needs to be refined ofc), but it seem to work against repro code in the issue. I marked added lines with comments. Please have a look for general approach.
 BaseDropdown = ({ name, label, required, disabled, value, values, choices, trigger, placeholder }: Dropdown) => {
    const
      isMultivalued = !!values,
      [singleSelection, setSingleSelection] = React.useState<S | U | undefined>(value), // Make this component controlled.
      selection = React.useMemo(() => isMultivalued ? new Set<S>(values) : null, [isMultivalued, values]),
      [selectedOptions, setSelectedOptions] = React.useState(Array.from(selection || [])),
      options = (choices || []).map(({ name, label, disabled }): Fluent.IDropdownOption => ({ key: name, text: label || name, disabled })),
      onChange = (_e?: React.FormEvent<HTMLElement>, option?: Fluent.IDropdownOption) => {
        if (option) {
          const optionKey = option.key as S
          if (isMultivalued && selection !== null) {
            option.selected ? selection.add(optionKey) : selection.delete(optionKey)

            const selectedOpts = Array.from(selection)
            wave.args[name] = selectedOpts
            setSelectedOptions(selectedOpts)
          } else {
            setSingleSelection(option.key) // Update local state whenever the user selects a value.
            wave.args[name] = optionKey
          }
        }
        if (trigger) wave.push()
      },
      selectAll = () => {
        if (!selection) return

        selection.clear()
        options.forEach(o => { if (!o.disabled) selection.add(o.key as S) })

        const selectionArr = Array.from(selection)
        setSelectedOptions(selectionArr)
        wave.args[name] = selectionArr

        onChange()
      },
      deselectAll = () => {
        if (!selection) return

        selection.clear()
        setSelectedOptions([])
        wave.args[name] = []

        onChange()
      }

    return (
      <>
        <Fluent.Dropdown
          data-test={name}
          label={label}
          placeholder={placeholder}
          options={options}
          required={required}
          disabled={disabled}
          multiSelect={isMultivalued || undefined}
          selectedKeys={isMultivalued ? selectedOptions : undefined} // Tell Fluent what values to use - multiValued.
          selectedKey={singleSelection} // Tell Fluent what value to use.
          onChange={onChange}
        />
        {
          isMultivalued &&
          <div>
            <Fluent.Text variant='small'>
              <Fluent.Link onClick={selectAll}>Select All</Fluent.Link> | <Fluent.Link onClick={deselectAll}>Deselect All</Fluent.Link>
            </Fluent.Text>
          </div>
        }
      </>
    )
  }

@mturoci, I just pushed a commit with your changes. Tested manually for single select and multi select, and it works as expected. 👍
Regarding refinements, I didn't spot anything that could be improved since not many changes were introduced.
Just by looking at the GIF, could you confirm if these two components are broken as well?

Just by looking at the GIF, could you confirm if these two components are broken as well?

You are right, these have the same behavior as dropdown.
The important point of this issue is to unify the value behavior across Wave. However, taking this proposal into consideration, the original dropdown behavior seems like what we want actually and the rest of the components (all the components that support value attr) need to be adjusted.
In order to avoid more confusion than necessary, I think we should implement the desired behavior once for all rather than fix these 3 first and then rewrite them anyway.
Another thing to think about is that current dropdown behavior works only by relying on choices having different references between component rerenders. Can it cause trouble in future? Is there any better way how to achieve the same?

Taking a look at this one.

Looks like I forgot to change the Nav component, working on it and checking whether other components need it too.

@aalencar This could be helpful when identifying all the widgets that needs to go through this ^^:

@aalencar This could be helpful when identifying all the widgets that needs to go through this ^^:

That's what I did 😄

I'm having a problem setting the selected item for Nav component on user click.
From nav.tsx:
XNav = (model: State & { hideNav?: () => void }) => {
    const { items, hideNav } = model
    const [value, setValue] = useControlledComponent(model)
    const groups = items.map((g): Fluent.INavLinkGroup => ({
      name: g.label,
      collapseByDefault: g.collapsed,
      links: g.items.map(({ name, label, icon, disabled, tooltip }): Fluent.INavLink => ({
        key: name,
        name: label,
        icon,
        disabled,
        title: tooltip,
        style: disabled ? { opacity: 0.7 } : undefined,
        url: '',
        onClick: () => {
          setValue(name)
          if (hideNav) hideNav()
          if (name.startsWith('#')) {
            window.location.hash = name.substr(1) // Line causing the problem
            return
          }
          wave.args[name] = true
          wave.push()
        }
      }))
    }))
    return <Fluent.Nav groups={groups} selectedKey={value} />

window.location.hash = name.substr(1) causes the whole component tree to rerender and after the first click, it selects the initial value set on the Wave app. See the GIF below:

window.location.hash = name.substr(1) causes the whole component tree to rerender and after the first click, it selects the initial value set on the Wave app

Why is this a problem? Rerenders are fine, that's what your local state hook is for, or ...?

window.location.hash = name.substr(1) causes the whole component tree to rerender and after the first click, it selects the initial value set on the Wave app

Why is this a problem? Rerenders are fine, that's what your local state hook is for, or ...?

The problem:

user - clicks on nav item
click handler - setValue(nav item)
click handler - sets window.location.hash causing all components to rerender
when rerendering the whole component tree it looks like a new props object is being created, same values different reference (not 100% sure)
when props change useControlledComponent overwrites step 2

I wonder if I'm right about 4., this is a React matter.

I wonder if I'm right about 4., this is a React matter

I see, so what are the alternatives we can solve this?

I wonder if I'm right about 4., this is a React matter

I see, so what are the alternatives we can solve this?

It's still not clear to me why the props are changing and I couldn't reproduce the problem consistently. Sometimes the first click doesn't work, sometimes it does.
Let me work on it again and I should have something by the end of the day.

I could not find a solution for Nav but I can confirm that it's being recreated:

@mturoci do you know why components are recreated when window.location.hash changes? In this case, a new request is made, right?
@mtanco, regarding this message on slack, do you know which components were impacted?
@lo5 can you say if these changes to "value" behavior break old apps?

@aalencar I believe the nav_card is the one that people were pragmatically setting and now are not allowed to.

do you know why components are recreated when window.location.hash changes?

I could not repro this. What does your python code look like?

@aalencar a few more things that need improvement.
Updating value is not always working (didn't check for other components)

@app('/demo')
async def serve(q: Q):
    if not q.client.initialized:
        q.page['example'] = ui.form_card(box='1 1 4 10', items=[
            ui.checkbox(name='checkbox_unchecked', label='Checkbox'),
            ui.button(name='btn', label='Change to true'),
        ])
        q.client.initialized = True

    if q.args.btn:
        q.page['example'].items[0].checkbox.value = True

    await q.page.save()

Go through values attr as well, this does not work either for example
@app('/demo')
async def serve(q: Q):
    if not q.client.initialized:
        q.page['example'] = ui.form_card(box='1 1 4 10', items=[
            ui.dropdown(name='dropdown', label='Choices', values=[],
                         choices=[ui.choice(name=x, label=x) for x in ['Egg', 'Bacon', 'Spam']]),
            ui.button(name='change', label='Change', primary=True),
        ])
        q.client.initialized = True

    if q.args.change:
        q.page['example'].items[0].dropdown.values = ['Spam', 'Bacon']

    await q.page.save()

I could not repro this. What does your python code look like?

I just pushed a commit (WIP) with changes on Nav to use the custom hook and debug.py which I used to test it, it should be enough to reproduce the problem.

Updating value is not always working (didn't check for other components)

Actually I didn't try to update the values directly like this: q.page['example'].items[0].dropdown.values = ['Spam', 'Bacon'].
I'm passing a new component with the same name to the items array as you can see here. I based it on your description of this issue.
I believe updating the value directly is the most intuitive way and might be what most people will do. I will check why it's not working.
Thanks for taking a look :)

I just realized that there's a big flaw with updating value by changing the items array like I was doing: You would have to pass the same components to it again even if they are not being updated so that you don't remove them from the UI.

I just pushed a commit (WIP) with changes on Nav to use the custom hook and debug.py which I used to test it, it should be enough to reproduce the problem.

Yes, the problem is your python code. You create a new card on every single render (serve) cycle - that's why your component gets (rightfully) recreated.
Instead, you should create the nav card only once and update its value only.
Something very roughly like this
# Nav
# Use nav cards to display #sidebar #navigation.
# ---
from h2o_wave import main, app, Q, ui

persona = 'https://images.pexels.com/photos/220453/pexels-photo-220453.jpeg?auto=compress&h=750&w=1260'

@app('/demo')
async def serve(q: Q):
    if not q.client.initialized:
        q.client.initialized = True
        q.page['nav1'] = ui.nav_card(
            box='1 1 2 -1',
            value='#menu/spam',
            title='H2O Wave',
            subtitle='And now for something completely different!',
            image='https://wave.h2o.ai/img/h2o-logo.svg',
            items=[
                ui.nav_group('Menu', items=[
                    ui.nav_item(name='#menu/spam', label='Spam'),
                    ui.nav_item(name='#menu/ham', label='Ham'),
                    ui.nav_item(name='#menu/eggs', label='Eggs', tooltip='Make me a scrambled egg.'),
                    ui.nav_item(name='#menu/toast', label='Toast', disabled=True),
                ]),
                ui.nav_group('Help', items=[
                    ui.nav_item(name='#about', label='About', icon='Info'),
                    ui.nav_item(name='#support', label='Support', icon='Help'),
                ])
            ],
            secondary_items=[
                ui.inline(items=[
                    ui.persona(title='John Doe', subtitle='Software developer', size='s', image=persona),
                    ui.menu(items=[
                        ui.command(name='profile', label='Profile', icon='Contact'),
                        ui.command(name='preferences', label='Preferences', icon='Settings'),
                        ui.command(name='logout', label='Logout', icon='SignOut'),
                    ])
                ]),
            ],
        )
        q.page['form'] = ui.form_card(box='1 3 2 2', items=[
            ui.button(name='change', label='Change'),
        ])

    if q.args.change:
        q.page['nav1'].value = 'your_val'

    await q.page.save()

@mturoci please take a look again at my solution.
Nav and Tabs
Problem:

User clicks on nav item / tab
Event handler sets the new value and sets window.location.hash
Setting window.location.hash changes the props object (I don't know why)
useEffect that listens to props changes is triggered by 3. and set's the value back to the last value passed by the author (props.value) <- BUG

Solution:
Use a useRef variable to skip the render triggered by 5. (maybe we should call this variable skipRender instead of ref)
Destructuring Props
I could not understand yet why some components work with destructed parameters like Checklist
XChecklist = ({ model: m }: { model: Checklist }) => {
...
[choices, setChoices] = useControlledComponent(m, getMappedChoices()),

while others like checkbox don't and I have to pass props instead of the destructed m.
XCheckbox = (props: { model: Checkbox }) => {
...
[value, setValue] = useControlledComponent(props, props.model.value)

I didn't manage to repro on stackblitz
I Found Another Bug
We have to listen for every prop change in order to set the value to the one passed by the author. The problem is that if the user sets another parameter such as label it will trigger the change in value as well. You can try with Checkbox.
Why we don't listen only to prop.value / prop.values? Because of the following case:
from h2o_wave import main, app, Q, ui

@app('/demo')
async def serve(q: Q):
    if not q.client.initialized:
        q.page['example'] = ui.form_card(box='3 4 4 7', items=[
            ui.checkbox(name='checkbox', label='Checkbox', value=False),
            ui.button(name='change', label='Change', primary=True),
        ])
        q.client.initialized = True

    if q.args.change:
        q.page['example'].items[0].checkbox.value = True
    await q.page.save()

Repro:
Initial values: props.value = false, value = false, checkbox starts unselected

User clicks on Change button, props.value = true -> useEffect setValue(true), checkbox is selected
User unselect the checkbox, onClick handler setValue(false)
User clicks on Change button again, nothing happens because there was no change in props.value, it's still `true

Test all changes
from h2o_wave import main, app, Q, ui

persona = 'https://images.pexels.com/photos/220453/pexels-photo-220453.jpeg?auto=compress&h=750&w=1260'

choices = [
    ui.choice('A', 'Option A'),
    ui.choice('B', 'Option B'),
    ui.choice('C', 'Option C', disabled=True),
    ui.choice('D', 'Option D'),
]

combobox_choices = ['Cyan', 'Magenta', 'Yellow', 'Black']

tabs = [
    ui.tab(name='email', label='Mail', icon='Mail'),
    ui.tab(name='events', label='Events', icon='Calendar'),
    ui.tab(name='spam', label='Spam'),
]

@app('/demo')
async def serve(q: Q):

    content = 'Welcome to our store!'
    location = q.args['#']
    if location:
        if location == 'menu/spam':
            content = "Sorry, we're out of spam!"
        elif location == 'menu/ham':
            content = "Sorry, we're out of ham!"
        elif location == 'menu/eggs':
            content = "Sorry, we're out of eggs!"
        elif location == 'about':
            content = 'Everything here is gluten-free!'

    if not q.client.initialized:
        q.page['example'] = ui.form_card(box='3 4 4 10', items=[
            ui.checkbox(name='checkbox', label='Checkbox', value=False),
            ui.dropdown(name='dropdown', label='Choices', value='',
                        choices=[ui.choice(name=x, label=x) for x in ['Egg', 'Bacon', 'Spam']]),
            ui.dropdown(name='dropdown2', label='Choices', values=[],
                        choices=[ui.choice(name=x, label=x) for x in ['Egg', 'Bacon', 'Spam']]),
            ui.dropdown(name='dropdown3', label='Choices', popup='always', value='',
                        choices=[ui.choice(name=x, label=x) for x in ['Egg', 'Bacon', 'Spam']]),
            ui.dropdown(name='dropdown4', label='Choices', popup='always', values=[],
                        choices=[ui.choice(name=x, label=x) for x in ['Egg', 'Bacon', 'Spam']]),
            ui.checklist(name='checklist', values=['Egg', 'Spam'], label='Choices',
                         choices=[ui.choice(name=x, label=x) for x in ['Egg', 'Bacon', 'Spam']]),
            ui.choice_group(name='choice_group', label='Pick one', value='B', required=True, choices=choices),
            ui.color_picker(name='color', label='Pick a color', value='#F25F5C'),
            ui.combobox(name='combobox', label='Enter or choose a color', placeholder='Color...', value='Blue',
                        choices=combobox_choices),
            ui.copyable_text(label='Copyable text', value='foo'),
            ui.date_picker(name='date', label='Standard date picker', value='2017-10-19'),
            ui.picker(name='picker', label='Place an order (try Spam, Eggs or Ham):', choices=[
                ui.choice(name='spam', label='Spam'),
                ui.choice(name='eggs', label='Eggs'),
                ui.choice(name='ham', label='Ham'),
                ui.choice(name='cheese', label='Cheese'),
                ui.choice(name='beans', label='Beans'),
                ui.choice(name='toast', label='Toast'),
            ], values=['eggs']),
            ui.progress(label='Indeterminate Progress', caption='Goes on forever', value=0.5),
            ui.slider(name='slider', label='Standard slider', min=0, max=100, step=10, value=30),
            ui.spinbox(name='spinbox', label='Standard spinbox', min=0, max=100, step=10, value=30),
            ui.tabs(name='menu', value='spam', items=tabs),
            ui.toggle(name='toggle', label='Not checked'),
            ui.button(name='change', label='Change', primary=True),
        ])

        q.page['tab'] = ui.tab_card(
            box='3 1 4 1',
            items=[
                ui.tab(name='#menu/spam', label='Spam'),
                ui.tab(name='#menu/ham', label='Ham'),
                ui.tab(name='#menu/eggs', label='Eggs'),
                ui.tab(name='#about', label='About'),
            ],
            value='#menu/ham',
        )

        q.page['nav'] = ui.nav_card(
            box='1 1 2 -1',
            value='#menu/spam',
            title='H2O Wave',
            subtitle='And now for something completely different!',
            items=[
                ui.nav_group('Menu', items=[
                    ui.nav_item(name='#menu/spam', label='Spam'),
                    ui.nav_item(name='#menu/ham', label='Ham'),
                    ui.nav_item(name='#menu/eggs', label='Eggs', tooltip='Make me a scrambled egg.'),
                    ui.nav_item(name='#menu/toast', label='Toast'),
                ])
            ],
        )

        q.page['blurb'] = ui.markdown_card(
            box='3 2 4 2',
            title='Store',
            content=content,
        )

        q.client.initialized = True

    if q.args.change:
        q.page['example'].items[0].checkbox.value = True
        q.page['example'].items[1].dropdown.value = 'Bacon'
        q.page['example'].items[2].dropdown.values = ['Spam', 'Bacon']
        q.page['example'].items[3].dropdown.value = 'Bacon'
        q.page['example'].items[4].dropdown.values = ['Spam', 'Bacon']
        q.page['example'].items[5].checklist.values = ['Bacon']
        q.page['example'].items[6].choice_group.value = 'A'
        q.page['example'].items[7].color_picker.value = '#FFFFF8'
        q.page['example'].items[8].combobox.value = 'Yellow'
        q.page['example'].items[9].copyable_text.value = 'bar'
        q.page['example'].items[10].date_picker.value = '2022-03-22'
        q.page['example'].items[11].picker.values = ['ham', 'toast']
        q.page['example'].items[12].progress.value = 0.75
        q.page['example'].items[13].slider.value = 50
        q.page['example'].items[14].spinbox.value = 50
        q.page['example'].items[15].tabs.value = 'events'
        q.page['example'].items[16].toggle.value = True

        q.page['tab'].value = '#menu/spam'
        q.page['nav'].value = '#menu/spam'
    if location:
        blurb = q.page['blurb']
        blurb.content = content

    await q.page.save()

Is there any resource you would recommend?

You can have a look at https://github.com/h2oai/wave/commit/3f820b31a53bf2d03818f710eae3b004d1d28db7.

If label is set, the props received will contain the latest value. If we have a checkbox unselected and the latest value was True, setting the label will select the checkbox (value = True)

I see, you are saying that the problem is the state is not reset between rerenders / serves. So what are the alternatives/possible solutions here?

I see, you are saying that the problem is the state is not reset between rerenders / serves. So what are the alternatives/possible solutions here?

Ignoring changes to props other than value solves the problem. We only care about changes on value but adding props.value to the dependency array won't work as I mentioned. You can see the explanation below:

Repro:
Initial values: props.value = false, value = false, checkbox starts unselected
User clicks on Change button, props.value = true -> useEffect setValue(true), checkbox is selected
User unselect the checkbox, onClick handler setValue(false)
User clicks on Change button again, nothing happens because there was no change in props.value, it's still `true


Captions in lutaml diagrams cannot contain commas

diagram StandardDoc_Blocks {
  title 'StandardDocument Blocks'
  caption 'Block elements of StandardDocument, adapted from BasicDocument'

lutaml -t png -o images/StandardDoc_Blocks.png views/StandardDoc_Blocks.lutaml
on that crashes with:
Failed to match sequence (WHITESPACE? DIAGRAM_DEFINITION) at line 1 char 1. (Lutaml::Uml::Parsers::ParsingError)
cause: Failed to match sequence (WHITESPACE? DIAGRAM_DEFINITION) at line 1 char 1.
`- Failed to match sequence (DIAGRAM_KEYWORD SPACES? name:CLASS_NAME DIAGRAM_BODY WHITESPACE?) at line 1 char 28.
   `- Failed to match sequence (SPACES? '{' WHITESPACE? members:(DIAGRAM_INNER_DEFINITION{0, }) '}') at line 3 char 46.
      `- Expected "}", but got "," at line 3 char 46.

There is no reason why a quoted caption string should not be allowed to contain a comma. I am working around this, but this is an erroneous constraint.

@opoudjis fixed in https://github.com/lutaml/lutaml-uml/pull/91


feat: Add option to provide an existing storageClient on Azure client

Hello.
This allows us to instantiate the adapter using an existing storageClient.
This is helpful in case we don't have the connectionString, but rather an SAS token, instantiating the adapter without the connectionString was impossible before.

Any updates on this? This PR should also enable the user to make use of a managed identity to authenticate with the storage account.

@DanRibbens Would you able to take a look?

@DanRibbens correct me if I'm wrong but I think you guys moved this plugin to payload's repo instead.

That's correct

This plugin is now being maintained in the Packages Directory of the Payload Monorepo. This repo will soon be archived and all open PRs including this one will be closed. Would you be willing to re-open this same PR but within the Payload monorepo?


Fix block / chunk size for compressed images

See block-stream in Etcher/sdk/writer

Fixed in https://github.com/resin-io-modules/etcher-sdk/pull/6


OS X Support

Added in support for os x, tested and it works fine on my machine as long as you have python3 and the pillow library installed

Oh, also, depending on how they set up their machine (specifically if they used home-brew to install python3) they may have to change the first line to #!/usr/local/bin/python3

Thanks for adding OS X support, and testing it afterwards. :)
I'm planning to license project under MIT License, and I need to ask whether it's okay for you, since the project currently has no license. If yes, then I can merge.

That's cool with me!

when will this be merged please? Also do you have docs of OSX?

when will this be merged please? Also do you have docs of OSX?

When @cj-zeiger confirms as well. Also what do you mean by docs?

Lastly, I think current async implementation is better than the proposed one, for it shows the progress and it's shorter. Can you please remove that commit (not sure if possible)?
Thanks!

Done

@boramalper That's fine by me.

Also what do you mean by docs?

Most OS X users don't have python3 or pillow/PIL installed and most do so and set up the proper path in the context of the cron job.  I'm not very good at writing docs, so maybe some kind soul could add in a little instruction to help Mac users get it up and running.


Implement analysis for configuration specific imports in dart2js.

Dart2js may want to implement warnings for bad configuration specific imports.
See issue #24581 for details.

Closing, as warnings are not planned (at least not from the viewpoint of the spec).


change: version bump

Issue #, if available:
N/A
Description of changes:
Bump to v0.5.0
Testing done:
Previously passed CI, no other changes besides bump.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Base: 93.08% // Head: 83.23% // Decreases project coverage by -9.85% :warning:

Coverage data is based on head (1b5b24e) compared to base (b3c52f9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   93.08%   83.23%   -9.85%
==========================================
  Files          33       33
  Lines        3689     3687       -2
==========================================
- Hits         3434     3069     -365
- Misses        255      618     +363

Impacted Files
Coverage Δ

PyBraket/src/pynoises.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

PyBraket/src/pygates.jl
10.29% <0.00%> (-86.77%)
:arrow_down:

PyBraket/src/pycircuit.jl
32.35% <0.00%> (-44.12%)
:arrow_down:

src/operators.jl
50.00% <0.00%> (-25.00%)
:arrow_down:

PyBraket/src/local_simulator.jl
64.86% <0.00%> (-21.63%)
:arrow_down:

PyBraket/src/PyBraket.jl
82.05% <0.00%> (-5.13%)
:arrow_down:

PyBraket/src/pyschema.jl
96.11% <0.00%> (-2.27%)
:arrow_down:

src/gates.jl
70.00% <0.00%> (-1.43%)
:arrow_down:

src/noises.jl
98.78% <0.00%> (-1.22%)
:arrow_down:

src/results.jl
91.17% <0.00%> (-0.99%)
:arrow_down:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


About page

Build an About us page
Mobile design in Figma
Tablet design in Figma
Desktop design in Figma

About page ready. Need to be coneccted to the back-end.


Change the error message of values like name, phone number etc

They may not be entirely correct when shown in the terminal.

When there is leading whitespaces in json file


Update CI.yml

Add command to create empty file that is required for build.

Looks good @APherwani