azure-mgmt-network is huge

Package Name: azure-mgmt-network
Package Version: 10.1.0
Operating System: alpine-3.11.6
Python Version: 3.8

Describe the bug
azure-mgmt-network is the biggest dependency by far for my project, the size on disk is 110MB, which means that it slows down everything else - like building & publishing my application.
To Reproduce
Steps to reproduce the behavior:

pip install azure-mgmt-network
inspect the site-packages/azure/mgmt/network folder

Expected behavior
I would expect the SDK to be much lighter, for comparison the entire GCP python SDK is ~5MB and boto3+botocore is ~50MB (which includes the entire SDK).
If I were to install azure-mgmt-compute & azure-mgmt-resource I would get another 30MB, in one of my applications the azure folder is 250MB bigger than all the rest of the filesystem combined.

hi @yoava333 , i checked the pkg size, it is huge because network has multi versions, when you download this pkg, it will download pkgs of all version, we will discuss this on our meeting, thx.

@lmazuel , do you have any suggestion here? is it possible to optimize the codegen to reduce the size? thanks.

We did some investigation and found that the current network package still include very old api-version. Add "Service Attention" label to include service team to confirm whether we still need to support all the api-versions, it will be helpful to reduce the size if some old api-version can be removed from the package. thanks.

Any update on this?

Could you update on the status of this issue?
Azure right now is ~330MB I cannot use the sdk it in an AWS Lambda function anymore

i have the same problem as well... Please update

@chenjianfei2017 - I'm from the SDN team, did you come to any conclusion about how to fix this?

The issue is only becoming worse over time, it's now ~370MB

Where azure-mgmt-network is the biggest offender with ~230MB

@MikhailTryakhov, can we make the package smaller? for example, deprecate some very old versions such as 2015-xx-xx.
Actually this need cross team collaboration as network has many feature teams, do you know who can be the coordinator to collect thoughts from different feature team?
Before deprecation, we need data to insure there is no users to use those deprecated version recently.

The sheer size of azure-mgmt-network even makes PyCharm unresponsive by selecting or searching for begin_create_or_update.
https://github.com/Azure/azure-cli/blob/b0815f704b1c3a34c4b5a4aecf9489166eef30ef/src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_virtual_network.py#L173
nw_client.virtual_networks.begin_create_or_update(resource_group, ...)

I have to set the project to "No interpreter" for coding.

Hey @jsntcy  I assume that's impossible. different customers are using different api versions and I'm not sure it's a good idea to deprecate some of them

@MikhailTryakhov,

We know different customers use different api versions, and we can collect data from telemetry to see if all existing API versions are used, if some versions are not used recently, we may probably deprecate them; otherwise the package will be bigger and bigger in the future as Network will include all existing features in new versions.
Also we can suggest customers to upgrade from very old version to new version for better/more features provided.
Another possible way: can we split Network package into multiple packages for different sub services.

@jsntcy can you share these metrics?

@jsntcy regarding to collect data from telemetry to see if all existing API versions are used

Has there been any resolution or progress on this issue?

In case that's possible to do from your side - well please do. But we have risks that we'll have sev2s due to that... that api version is supported from the backend won't be supported from Python sdk side?
From: Yu Chen @.>
Sent: Thursday, March 4, 2021 7:16 PM
To: Azure/azure-sdk-for-python @.>
Cc: Mikhail Triakhov @.>; Mention @.>
Subject: Re: [Azure/azure-sdk-for-python] azure-mgmt-network is huge (#11149)
@MikhailTryakhovhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMikhailTryakhov&data=04|01|Mikhail.Tryakhov%40microsoft.com|ef816952b901434189ff08d8df850b36|72f988bf86f141af91ab2d7cd011db47|1|0|637505109802810904|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=514hWO2SfjXdS9OvEaum2r3QlNAyvjbhYhmGnjoMtS4%3D&reserved=0,

We know different customers use different api versions, and we can collect data from telemetry to see if all existing API versions are used, if some versions are not used recently, we may probably deprecate them; otherwise the package will be bigger and bigger in the future as Network will include all existing features in new versions.
Also we can suggest customers to upgrade from very old version to new version for better/more features provided.
Another possible way: can we split Network package into multiple packages for different sub services.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-python%2Fissues%2F11149%23issuecomment-791120632&data=04|01|Mikhail.Tryakhov%40microsoft.com|ef816952b901434189ff08d8df850b36|72f988bf86f141af91ab2d7cd011db47|1|0|637505109802820859|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=fgBHuP2brQMpzeKzUYWJGqpKbx2cg2RDmocZ0npr%2BWQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAXP3JAIREGVJIQ7MUVW4VTTCBEIFANCNFSM4MVVOV4Q&data=04|01|Mikhail.Tryakhov%40microsoft.com|ef816952b901434189ff08d8df850b36|72f988bf86f141af91ab2d7cd011db47|1|0|637505109802820859|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=fGUzxII2IBmxfk7i1tGiTm6jDrD0%2BDnaDpb%2FWtIYpiA%3D&reserved=0.

@MikhailTryakhov, we plan to collect data this sprint and check if we can deprecate some old APIs from SDK perspective.

We are also suffering significant additional application design overhead due to the size of some of these mgmt packages (particularly this and compute).

We have written a script that deletes the unreferenced older APIs. It does delete a good chunk of the API folders but not all of it. With the script the Azure directory is now just under 300MB instead of over 700MB. It is compatible with most, but not all, third party packages, as long as they do not point to a version that is trimmed.
https://github.com/clumio-code/azure-sdk-trim

Any update on this? Azure CLI size is getting out of hand :(

Do we have any decisions?
We have similar problem when we ship conda packages.

/unresolve
@RAY-316 the issue not addressed/resolved the issue is only getting bigger, the package size of the network along (azure-mgmt-network) is now 286MB, which is almost 3 times larger than the original issue.

/unresolve

Any updates?

@travcunn you can try my tool, which will bring the azure packages down to something less massive (300-400MB), but that might still be too large for Lambda.
https://github.com/clumio-code/azure-sdk-trim
As far as I can tell, this is something that was reported years ago and each release is still growing bigger, so it does not seem to be a priority at Microsoft.
@jsntcy you did communicate almost a year ago, can you share if anything came out of your meetings? You can share with your product teams that some decision makers are using this bug as an example as to why Azure should be avoided in favor of AWS.

@sodul, I'm not in SDK team now. @msyyc, please share the update for this issue.

HI, we have gradually reduced the size for several release: https://github.com/Azure/azure-sdk-for-python/issues/21301.
What size do you expect?

According to https://github.com/Azure/azure-sdk-for-python/issues/21301#issuecomment-958653096, 21.1MB is still too large. Azure CLI 2.34.1 (https://azcliprod.blob.core.windows.net/msi/azure-cli-2.34.1.msi) is 52.3MB, which means azure-mgmt-network is almost half the size of whole Azure CLI.

Let me paste the data in e-mail to raise more attention for architect

Facing issues with pylance. The python language server crashes as soon as I installed azure-mgmt-network.
[Info  - 12:24:51 PM] (4436) [BG(1)] Long operation: parsing: XXX/dev_env/lib/python3.10/site-packages/azure/mgmt/network/v2019_12_01/operations/_operations.py (2541ms)
[Info  - 12:24:56 PM] (4436) [BG(1)] Long operation: parsing: XXX/dev_env/lib/python3.10/site-packages/azure/mgmt/network/v2020_04_01/operations/_operations.py (4044ms)
[Info  - 12:25:04 PM] (4436) [BG(1)] Long operation: parsing: XXX/dev_env/lib/python3.10/site-packages/azure/mgmt/network/v2020_05_01/operations/_operations.py (7680ms)
[Error - 12:25:21 PM] (4436) Error occurred on background thread: {"code":"ERR_WORKER_OUT_OF_MEMORY"}```

Duplicate of https://github.com/Azure/azure-sdk-for-python/issues/17801, where we're posting most update on the topic


error when script has attrs

<script type="module">

</script>

Error: {"message":"Unexpected token: operator «<»","filename":"file1.js","line":1,"col":0,"pos":0}

Hey,
Thanks for the bug.
I've found what the issue is, i'll try get this sorted during my day tomorrow.
Will keep you updated.
Cheers,

@KABBOUCHI this should be fixed in the latest release of the plugin.
Please note due to an issue with using edge tags inside of


Adding volumes to StatefulSet after the initial creation

Kubernetes StatefulSet itself doesn't allow volumes to be added to StatefulSets after their initial creation.
Trying to add a volume, results in this error:
Forbidden: updates to statefulset spec for fields other than 'replicas',         'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and         'minReadySeconds' are forbidden
The same limitation is encountered via operator.

create StatefulSet by setting:

spec:
  statefulSet: {}

try to add a volume to it

spec.
  statefulSet:
    storage:
      size: 100Mi
      mountPath: /logs

Tasks:

[ ] understand the reasons behind StatefulSet not supporting
[ ] if it's not an anti-pattern to add volume afterwards, support adding it via operator. StatefulSet probably have to be deleted and recreated (meaning there will be some downtime)

I would recommend adding support only for adding volumes for now. Since making changes to StatefulSet volumes also requires deletion of pods, I am not sure if it is safe to make that too available. If we decide to support modifying the existing volumes, we can implement it later.


How to obtain camera angle velocity?

Hi, I would like to run the pre-trained model on in-the-wild videos. I have figured out the meaning of all inputs except "cam_angvel".

Hi, this is unrelated to your issue but if you are successful can you please fork this repo and add a script to run the model on in the wild videos? (I'd like to run it too but I don't have enough knowledge to do it)

Hi @xjwxjw , are you trying to run on your custom video? If so, you need to get camera angular velocity by running SLAM beforehand. Once you have R, which is the camera to world rotational transformation, over time, you can compute and normalize angular velocity as shown in the code (the figure you uploaded). Note that we follow camera coordinate convention as X-right, Y-down, and Z-forward.
Hi @RohaanA , we plan to provide a demo script that involves all preprocessing stages (e.g., 2D detection, SLAM, and WHAM), so that you can just upload a video and get world-grounded 3D human motion.

@yohanshin this is nice, we can truely have a offline pipeline solves wild videos and output 3d motions directly.


[FR] Support reference-style markdown links

Long story short Ulysses on iPhone has started screwing with all the links in my Telekasten notes and converting them to reference-style links.
Telekasten doesn't support this for follow link, neither the reference or the definition of the link.
This is valid markdown so it'd be good if Telekasten could support it.
Daring Fireball Markdown Syntax Documentation
Example of what's happening:
[renerocksaitelekasten.nvim A Neovim (lua) plugin for working with a markdown zettelkasten  wiki and mixing it with a journal, based on telescope.nvim](https://github.com/renerocksai/telekasten.nvim)

Becomes:
[renerocksaitelekasten.nvim A Neovim (lua) plugin for working with a markdown zettelkasten  wiki and mixing it with a journal, based on telescope.nvim][1]

[1]:   https://github.com/renerocksai/telekasten.nvim

It would be nice if Telekasten could follow URLs even if they aren't in the correct markdown format. This would make it easier to follow the link and fetch a correctly formatted markdown version. I know gx can do this but having to decide how to follow a link can break flow.
Even better would be a tool to convert a basic URL to markdown, it's need some code to fetch the basic HTML of a page and rip the  out of it.

Isn't it a duplicate of #126, and also partially discussed in #294 ?


add new icons

New icons that comply with the current design style have been added.

@kamilklkn why do you remove the existing play icon?

@kamilklkn I've updated your fork with play.svg and the related generated files for icons. I am merging this now. Thanks for the PR


Everyone: Test ES6 upgrade

Hi Guys
Need help in testing the ES6 upgrade for this repo. If bugs, please raise. Once stable, can merge with the master repo.
https://github.com/scazzy/react-native-gifted-listview/blob/master/GiftedListView.js

oh! I need it, i will have a try!


Add a hostess fix --dry-run

Some command error out when the /etc/hosts file is invalid (for example, when it has dupes). For scripting purposes, it would be nice to be able to check once in the beginning of a bunch of option and issue a hostess fix. The issue is that you can have a hostess fix, but it would require a possibly redundant sudo access if the configuration is in the expected state.
In the same sense, it would be nice if apply also has a --dry-run so that you can check before requiring sudo.
Imagine a script like this:
if ! hostess fix --dry-run; then
  sudo hostess fix
fi
if ! hostess apply hostess.json --dry-run; then
  sudo hostess apply hostess.json
fi

Of course, there's copy and paste of code, but maybe it could be done somehow via hostess calling itself with sudo?

-n is the dry run flag. Can you let me know if this does what you want?
$ hostess fix -n
/etc/hosts is already formatted and contains no dupes or conflicts; nothing to do

For quieter output you can do:
$ hostess fix -n -q

@cbednarski Duh! How did I miss that!? Let me try to see if this works as I need it to!

I may need to change the exit status to 1 if there would be changes. I don't remember what the behavior is here.

@cbednarski You're right! You need to add the exit code as I just tested it, and it always returns 0!

The code change to fix is small but the UX gets a bit weird because it has unique conditional logic based on -n which is inconsistent with other commands. I'm going to add hostess fixed exit 0/1/2 to accomplish this.


 Do I really have to read this notification each time I run the client? I don't even know how to run it not as admin.
Can't we have a checkbox for "Don't show again"?

Users should not be running the application as admin as this could cause eventual permission and security issues. The warning will not be removed or reduced.

What kind of security issues? Maybe the message should say about them instead.

I also have this notification and its annoying.
I only have an admin acount on my windows and can't change it without loosing my custom HDD file system.
And in case i know the risc (error [13] permission denied...) i would like to disable this warning.
It has no meaning for me. And i will never get this [13] error when i always start the client as admin.
And a check box that doesn't show it again does not detract from the reason this message was created in the first place.
Its only a warning that something could go wrong when you start the client as admin and after this as user.
No reason to nag me til the end of my life.


red understureated

hello
red is very undersaturated in dynamic tone mapping to the point its some times translated to white specialy on highlights any way to fix it?

Please take some of clips using ffmpeg -i input.mp4 -ss 00:00 -t 10 output.mp4

Generally you can try:
Remove glsl-shader=~~/shaders/hdr-toys/utils/chroma_correction.glsl, or lower sigma and alpha in chroma_correction
Change glsl-shader=~~/shaders/hdr-toys/gamut-mapping/jedypod.glsl to clip or bottosson, or lower *_limit and boost *_threshold

thanks a lot.remove chroma correction,chane gamuet mapping to clip.now its perfect!


Unable to parse my libraryfolders.vdf made by Steam on Windows

So I'm not sure what's going on here but for some reason my specific libraryfolders.vdf, I've been trying to figure it out and it's something to do with the very last value: "E:\Steam" being recognized as a } and the parser therefore erroring out. I've been unable to figure it out for hours so any help would be much appreciated.
Anonymized libraryfolders
I've also raised this issue on the steamy-vdf crate github but it seems to be dead unfortunately :/

I checked my libraryfolders.vdf file, which is roughly this:
"LibraryFolders"
{
	"TimeNextStatsReport"		"0000002"
	"ContentStatsID"		"-123456789"
	"1"		"F:\\Steam"
	"2"		"E:\\Steam"
	"3"		"D:\\Steam"
}

Which seems to work for me.

I was able to recreate the issue with the provided file with the following code
Mylibraryfolders.vdf
"LibraryFolders"
{
	"TimeNextStatsReport"		"0000002"
	"ContentStatsID"		"-123456789"
	"1"		"D:\\SteamLibrary"
	"2"		"E:\\Steam"
}

fn main() {
    let _ = steamy_vdf::load("Mylibraryfolders.vdf").unwrap();
}

Gets me
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Parse', src/main.rs:2:54
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I really don't know what specifically is causing a parse error though. I had other problems with using steamy-vdf and vdf-serde so I ended up releasing my own parsing and serde libraries instead. I just released the first versions of both so there are likely several things that can be improved, but there's a decent number of unit tests for everything, a fuzzing suite, and I'm open to new changes and contributions.
I guess it's worth noting that the keyvalues-parser handles both of the example libraryfolders.vdf without issue. Here's the output from the problematic one
use keyvalues_parser::Vdf;
use std::fs;

fn main() {
    let vdf_text = fs::read_to_string("Mylibraryfolders.vdf").unwrap();
    let vdf = Vdf::parse(&vdf_text).unwrap();
    println!("{:#?}", vdf);
}

Vdf {
    key: "LibraryFolders",
    value: Obj(
        {
            "1": [
                Str(
                    "D:\\SteamLibrary",
                ),
            ],
            "2": [
                Str(
                    "E:\\Steam",
                ),
            ],
            "ContentStatsID": [
                Str(
                    "-123456789",
                ),
            ],
            "TimeNextStatsReport": [
                Str(
                    "0000002",
                ),
            ],
        },
    ),
}

There are quite a few differences from steamy-vdf though, just as a heads up.

It seems like this issue may have been fixed by pull request #4 (I haven't done any testing, I've just been looking at this library for one of my projects), so shouldn't this be closed now?

Brilliant! Thank you to @LovecraftianHorror


⚠ Bofrost.at has degraded performance

In 06e2f1d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1519 ms

Resolved: Bofrost.at performance has improved in 3ce7040 after 1 hour, 10 minutes.


Windows error removing .git directory

[2018-06-08 12:16:15,584 - ERROR]: [WinError 5] Access is denied: 'C:\\Users\\niklas\\Repositories\\NiklasRosenstein\\flux\\builds\\NiklasRosenstein\\nodepy\\0\\.git\\objects\\pack\\pack-34ab47d5b2cc3439270bc535724bb399c2e0f01b.idx'
Traceback (most recent call last):
  File "C:\Users\niklas\Repositories\NiklasRosenstein\flux\flux\build.py", line 154, in do_build
    if do_build_(build, build_path, override_path, logger, logfile, terminate_event):
  File "C:\Users\niklas\Repositories\NiklasRosenstein\flux\flux\build.py", line 241, in do_build_
    shutil.rmtree(os.path.join(build_path, '.git'))
  File "C:\Users\niklas\Repositories\NiklasRosenstein\flux\.venv\lib\shutil.py", line 494, in rmtree
    return _rmtree_unsafe(path, onerror)
  File "C:\Users\niklas\Repositories\NiklasRosenstein\flux\.venv\lib\shutil.py", line 384, in _rmtree_unsafe
    _rmtree_unsafe(fullname, onerror)
  File "C:\Users\niklas\Repositories\NiklasRosenstein\flux\.venv\lib\shutil.py", line 384, in _rmtree_unsafe
    _rmtree_unsafe(fullname, onerror)
  File "C:\Users\niklas\Repositories\NiklasRosenstein\flux\.venv\lib\shutil.py", line 389, in _rmtree_unsafe
    onerror(os.unlink, fullname, sys.exc_info())
  File "C:\Users\niklas\Repositories\NiklasRosenstein\flux\.venv\lib\shutil.py", line 387, in _rmtree_unsafe
    os.unlink(fullname)
PermissionError: [WinError 5] Access is denied: 'C:\\Users\\niklas\\Repositories\\NiklasRosenstein\\flux\\builds\\NiklasRosenstein\\nodepy\\0\\.git\\objects\\pack\\pack-34ab47d5b2cc3439270bc535724bb399c2e0f01b.idx'

Git write-protects the object files on Windows (for whatever reason ..) which prevents removing the .git directory recursively with shutil.rmtree(). On the command-line, you'd have to use rm -rf to delete the directory.

This same error can prevent a build from finishing because it is updated only after shutil.rmtree(build_path) is called.
https://github.com/NiklasRosenstein/flux-ci/blob/879d036f5ab3c047a5d2abe3d481f4c13ea7383f/flux/build.py#L167-L178
To do list

[ ] Allow stopping fully broken builds (not in the build queue as currently building but their state is marked as "building", this can happen right now due to the error mentioned above. If it can happen in the future, it should be possible to at least mark the build as stopped).
[ ] Both rmtree() calls should try to remove the write-protection flag when removing fails


Add licenses

Motivation for this change
Added licenses for some of the packages mentioned in #43716
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Thank you!


[bazel/ci] Lengthen timeout to 90 mins

The Bazel Build and Test job occasionally goes beyond the 60 minute
timeout, so increase it to accommodate slower runs.
Signed-off-by: Alexander Williams<EMAIL_ADDRESS>

Noticed the longer execution time caused CI failure on https://github.com/lowRISC/opentitan/pull/12178 , which was a doc-only change.

Lgtm


Revisit linearize transformation

With wsum optimizations (#182) and other changes in place, we should revisit the linearize transformations, as well defining a better "linear normal form" so we know exactly what kind of expressions can come out of the transformations.
Furthermore, we should also define the "supported" parameter as many MIP-solvers support API calls such as z = AND(x,y)etc

Proposal for a grammer for linear expressions:
Linearize returns any of :
1) LinExpr
2) Boolvar -> LinExpr
3) Expr                       (Expr.name in supported)
-----------------------------------------------
LinExpr:
1) Expr <= Const              (Expr.name in {"sum","wsum"})
2) Expr >= Const              (Expr.name in {"sum","wsum"})
3) Expr == Const              (Expr.name in {"sum","wsum"})

This differs from the current specification as variabels can be part of the rhs of LinExpr (except in reified expressions where they have to be constants).
Note the current imlementation is very highly tailored to support as much as possible the API of Gurobi. With Exact, SCIP and potentially other linear solvers in the pipeline, linearization should be generalized somewhat more.
With the above changes in place, only_var_lhs and only_const_rhs can also go.

I think we also need to add

4) BoolVar <- LinExpr

What is meant with 3) Expr   (Expr.name in supported)? Is this how we allow Gurobi-supported operations (i.e., min/max/abs or multiplication with a Boolean variable)? If so, max(x,y) is an Expr, but not a constraint (no Boolean type), so I do not see it yet.

This grammar is close to what Exact allows: https://gitlab.com/JoD/exact/-/blob/main/src/Exact.hpp.
In the above notation, Exact also allows:
Boolvar <-> LinExpr
Const >= Expr >= Const

But it is more restrictive as it only allows nested LinExpr of the form
Expr >= Const

There exist simple conversions between all (splitting == or <-> is a straightforward operation), so I can live with the above grammer.

Ok, I'm going to propose two variations: a maximal one (easy for CPMpy) and a minimal one (easy for the solvers). I'm ignoring the "supported" rule for now.
**Maximal:**
1) LinExpr
2) Boolvar -> LinExpr
3) Boolvar <- LinExpr
4) Boolvar <-> LinExpr
-----------------------------------------------
LinExpr:
5) Expr <= Const
6) Expr >= Const
7) Expr == Const
-----------------------------------------------
Expr:
8) Sum
9) Wsum

**Minimal:**
10) LinExpr
11) Boolvar -> LinExpr
12) Boolvar <- LinExpr
-----------------------------------------------
LinExpr:
13) Wsum >= Const

What Ignace proposed is pretty close to the maximal one (just drop 4)). I'm ok with either (simple conversion between both) but it's necessary to consider the variation in options.

Also, let's agree that
Wsum:
14) (Int IntVar)*
------
Sum:
15) IntVar*

So no max/min/abs/mul in there, except when explicitly allowed.

Hmm, I am not a fan of the Boolvar <- LinExpr variant. We have the only_bv_implies transformation which translated any expression expr -> bv to ~bv -> ~expr. I think we can state this has to be done BEFORE linearize is called. I don't think a lot of solvers support expr -> bv anyway (Most CP-solvers don't : ) )
Indeed, the supported set of operators would be an optional argument to pass to the linearize function so these function can fall trough. We shouldn't consider any difference in reified vs non-refied supported arguments as this should be handled by the reify_rewrite transformation BEFORE calling linearize.
14,15 yes indeed. This should be added (but is ensured by flatten_constraint).

Indeed, the supported set of operators would be an optional argument to pass to the linearize function so these function can fall through. We shouldn't consider any difference in reified vs non-refied supported arguments as this should be handled by the reify_rewrite transformation BEFORE calling linearize.

Agree. The remaining question is: how do we let these operators fall through? Is there a difference between keeping some operators and keeping builtin global constraints? What do we allow and what do we not allow? E.g., I guess max(x,y)+z >= 3 is allowed, but max(max(x,y),z) >=3 is not.

No, there should be no difference between operators or global constraints I think.
We should build from the Flat Normal Form (FNF) and decide which expressions remain as is and which don't. For your example, both expressions are not flat...
The hard part is to decide which numerical operators to support in combination with what comparisons.... I.e., maybe max(x,y) = z is supported but max(x,y) <= z is not. The solution is simple: leave it to another transformation, namely only_numexpr_equality :)
Because we only support flat constraints in linearize, any operator name given in the supported set should be unambiguous to which part of the constraint it applies.

Ok, one issue is that of equality in an equivalence reification. E.g.:
p <-> x+y=5

is complex to translate, as it entails the following disjunction of two linear inequalities:
p | x+y<5 | x+y>5

All other constraints accepted by the grammar translate straightforwardly to a set of linear inequalities without the need for new variables. The above does need new variables. I think the burden of introducing new variables should fall on CPMpy.

Wait, the other way around? We do not want 'Lit <-> expr' or 'Lit <- expr' as output for the linearize method, as this is hard to translate for people writing the solver interface? I.e., they need to introduce new variables.
Sidenote: when you write BV, can the variable still be negated?

After discussion with Ignace, we're going for the following grammar:
Top:
(Lit ->)? (LinExpr | GenExpr)

Lit:
~? BoolVar // a Boolean variable or its negation

LinExpr:
(Sum | WSum) (== | >= | <=) Const

Sum:
(+ IntVar)*

WSum:
(+ Const IntVar)*

GenExpr:
Special
Special (== | >= | <=) (Const | IntVar)

The reasoning behind GenExpr and Special is that we want to be able to pass constraints such as max(x,y) == z to Gurobi, or selected global constraints to solvers that support them. For other solvers, transformations will be made that linearize these as much as possible.

The input grammar accepted by linearize is most of what is output by flatten, as long as all the non-Boolean and non-linear constraints are marked as Special (otherwise linearize will throw an error).


v1.0.2 - Get-ServiceNowRequest & Various Minor Updates

Reviewed several contributions by @GilmondRoss (thanks!) and tested his addition of Get-ServiceNowRequest.  We may want to review the fields used in the default format.  Mainly whether the assigned_to field is worthwhile or not.
Added a simple Pester test for Get-ServiceNowRequest and updated 3 tests to ensure an array is returned in case of a single item existing (the temp dev instance only has one request that caused the test to fail and point out the better habit of ensuring an array is returned).
Will get this published in the next few days.

Bah - supposed to make this v1.1.0, not v1.0.2.  Canceling and will redo it.


Can't draw text using default typeface on Linux

Description
Can't draw text using SKTypeface.Default under WSL (Debian) or Docker, .NET Core 3.1, host Windows 10 Pro x64 1903.
Packages used are SkiaSharp and SkiaSharp.NativeAssets.Linux.NoDependencies, 1.68.2-preview.29 or older versions.
Explicitly loading a typeface fixes the problem.
Code
	using var surface = SKSurface.Create(new SKImageInfo(256, 256));
	using var canvas = surface.Canvas;
	canvas.Clear(SKColors.SkyBlue);

	using var paint = new SKPaint
	{
		Color = SKColors.Yellow,
		TextAlign = SKTextAlign.Center,
		TextSize = 64,
		Typeface = SKTypeface.Default
	};

	canvas.DrawText("foobar", 128, 128, paint);

	using var image = surface.Snapshot();
	image.SaveAs("test.png", SKPngEncoderOptions.Default);

Expected Behavior
The output should contain the text "foobar" on a skyblue background.
Actual Behavior
The output doesn't contain any text, but the background is skyblue, so rendering did take place.
Basic Information

Version with issue:  1.68.2 preview
Last known good version:  Can't find any version that works.
IDE:  Visual Studio 2019 Enterprise
Platform Target Frameworks:

Linux:  WSL/Debian/10.2 or Docker mcr.microsoft.com/dotnet/core/sdk:3.1-buster

Reproduction Link
This commit shows the problem
This commit shows that loading a specific typeface solves the problem, but I guess the default typeface should work or at least throw an exception, so I consider this a bug
Maybe using the package SkiaSharp.NativeAssets.Linux that requires FontConfig etc also fixes this, but I haven't tested that yet.

SkiaSharp.NativeAssets.Linux.NoDependencies isn't supporting a font manager and therefore only fonts loaded by file or stream are working.

Okay, got it. But it would be very useful if at least something is logged, or an exception is thrown?

It should probably called SkiaSharp.NativeAssets.Linux.NoFontManager or SkiaSharp.NativeAssets.Linux.NoFontConfig

I'm trying to get a better understanding. I'm a veteran Windows developer, so I might make newbie mistakes on Linux ;-)

SkiaSharp.NativeAssets.Linux.NoDependencies: this comes with just a libskia native library, with all libraries (libpng etc) linked in statically, without FontConfig? It can run on a system that hasn't any of the dependencies installed. Will it pickup FontConfig when it is installed optionally?

SkiaSharp.NativeAssets.Linux: this also just comes with a libskia native library, but expects all dependencies to be installed on the system? It requires FontConfig to run?

SkiaSharp.NativeAssets.Linux dynamically links fontconfig and SkiaSharp.NativeAssets.Linux.NoDependencies is built without any dependency on fontconfig and therefore has no font manager. It is just left out.

Text should work, because it has the "custom" font manager which loads fonts from the default directory:
/usr/share/fonts/

https://github.com/mono/skia/blob/xamarin-mobile-bindings/src/ports/SkFontMgr_custom_directory_factory.cpp

This should be included: https://github.com/google/skia/blob/chrome/m68/BUILD.gn#L395-L409
But, do you have any fonts installed? Are there any available in WSL?

Okay so it has a font manager but has no default set. So we should try to set one. Probably just look for a common one.

Ah, yeah. Or the first one.

https://github.com/google/skia/blob/master/src/ports/SkFontMgr_custom.cpp#L153

Although there is this line that should pick one: https://github.com/google/skia/blob/master/src/ports/SkFontMgr_custom.cpp#L173
Just trying to get me Docker and/or WSL working again...

So I just tested on the mcr.microsoft.com/dotnet/core/runtime:3.1-buster-slim Docker image, there are no fonts at all.
So how do we do this? You probably just want to copy your font files to the /usr/share/fonts/ directory.
This should fix it for you:
...
COPY --from=publish /app/publish/*.ttf /usr/share/fonts/
COPY --from=publish /app/publish .
...

After battling a bit I looked at the source and realized something. Linux is case-sensitive. Yay. In my tests, I was using the TIMES.TTF file that I copied from Windows.
Yay.

Amazing how quickly you guys got on top of this, thanks for all the info!
Interestingly, all the default fonts are copyrighted and require licensing, unless these expired, not sure...
Would be nice to include Roboto or some other free Google font as the default...
Because picking the first font would result in a different default one if others are added, that would be strange from a user's point of view IMHO.
Anyway in our case we will never use the default font, I just wanted to report this behaviour, I was expecting an exception, error, or null default typeface.

Returning nullptr for not found typefaces is by design. Not having any font is totally unexpected. But I think for the default we could throw an exception because that means something is wrong with the font manager.
Too bad the font manager is defined at compile time. If we could somehow have a proxy font manager we could make this pluggable. So if one font manager implementation breaks we could have a fallback or even a managed one that is fully customizable. Crippled platforms like Nano Server wouldn't be an issue anymore.

Yeah. Did you open an issue for that at all? I think you asked for this in the past. The font manager is a bit of work as there are a few overrides, but then there are all the supporting classes - such as the custom style set and custom typeface types. And then there is the big font host. This is either the FreeType (linux), DirectWrite (windows), CoreText (mac) and the deprecated GDI. Right now, the custom one only works on Linux as it uses the FreeType and some linux-y things.

I am closing this issue as I believe the original issue is solved, it just needed some fonts, any fonts.


Topic when client === false?

Is there (or could there be) a way to extract the topic from either socket or details when details.client === false in on('connection')?

We've been discussing how to deal with this. When we've got a solution, we'll update you here.

Thanks! One thought would be to have a socket per topic, which would also allow streams to be isolated per topic. Not sure if this breaks anything else though.

This just became a blocker for me and I'm prepared to invest some effort for a solution.
I'm using one hyperswarm instance to listen on multiple topics, and whenever i get a peer-connection I need to know where to route said connection.
If i understand the issue at hand correctly.
When you're connecting to a remote peer, you have the discovery information at hand and use it to initiate the new connection, thus the topic is a available.
Whilst when you're accepting a remote connection, all you really get is the socket and there's no guarantee that the remote peer has announced his own presence in the DHT for cross-referencing.
And even if the peer exists in the DHT, he might be registered under multiple topics which puts us back to square one.
We can't transmit the topic over the connected socket, because that would unintentionally leak our topic to whoever we accidentally connect to and potentially harm anonymity. ( Is this true? or would it be harmless to do a topic-exchange during connection bootstrap? )
From the listening end, the only metadata we have is the ip-address and a port-number for the socket.
Question: Is it viable to listen on separate ports for each topic, and keep a local lookup table between port-number and registered topic?

@telamon are you using it to bootstrap hypercores after or is this some custom data structure?

to answer your question the only cost of listening on multiple ports is using more file descriptors locally unless you are relying on hole punching.
in that case you need to spin up a new utp/dht stack for each bind, as that's how hole punching works unfortunately.

@mafintosh well it's neither.
I want to forward the socket to an replic8 instance.
Which from the socket's perspective is an instance of hypercore-protocol with one 'virtual' feed used to bootstrap the encryption.
So I suspect that I have same scenario as if I had an array of hypercores that needed to be mapped and replicated on individual topics. (Trying to avoid first key must be the same errors)

@mafintosh thanks, I did not take the hole-punched connection accepts into consideration.
I guess extra resource allocation for each topic will be unavoidable..
I'm currently experimenting with the thought of solving this on application level:
  _onSwarmConnection (socket, details) {
    if (details.client) {
      const hash = createHash('sha256')
      hash.update(this.peer.topic)
      hash.update(this.peer.port.toString() || someOtherPresharedIdentifier)
      const obfuscatedTopic = hash.digest()
      socket.write(obfuscatedTopic)
    } else {
      const obfuscatedTopic = socket.read(32)
      socket.cork()
      const target = findTarget(obfuscatedTopic)
      if (target) {
        socket.pipe(target).pipe(socket)
        socket.uncork()
      } else {
        socket.destroy()
      }
    }
}

This would require more CPU on each connection, as I'd have to systematically calculate a hash for each topic on the listening end.
Do DHT announcements have an id or something else I could use as an obfuscation pad?

@telamon the updated hypercore capability system basically does this for you

@mafintosh could you link me to it please? Been wanting to take a look at the cap system for a while now :)

@telamon https://github.com/mafintosh/simple-hypercore-protocol
basically does an initial noise handshake (one rt) to setup a unique session and the produces capabilities using the tx, rx keys derived from that :)

Closing this for now as this is by design. If there is still interest in talking about solutions reopen


optimize putIfAbsent method to computeIfAbsent which may reduce some …

[Dubbo-7542]  optimize creation of Objet
What is the purpose of the change
optimize 7542
replace putIfAbsent method with computeIfAbsent to reduce extra creation of Object.
Brief changelog
Verifying this change

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[x] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

closing this pr is a misoperation of mine ,sorry...

Some UT failed, check it.


Removed mpc-hc rule

v1.7.13 was last release as stated in https://mpc-hc.org/2017/07/16/1.7.13-released-and-farewell/
There were no news from the project after that.
@geek1011 Do you think that it should also be removed from the registry?

I think it should remain in the registry for now until it stops working.


Fix missing renames in the GLTF module

These were discovered by @qarmin here: https://github.com/godotengine/godot/issues/16863#issuecomment-907586412

translation -> position
zfar -> far
znear -> near
type -> light_type

zfar -> depth_far
znear -> depth_near

I don't like losing the z meaning. Other suggestions welcome.
Also I believe these are the exact json names. https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#cameras

Should be working now, sorry it wasn't working when I first opened the PR, I did so a bit too quickly. I used this to test the cameras: https://github.com/KhronosGroup/glTF-Sample-Models/blob/master/2.0/Cameras/glTF/Cameras.gltf

@fire what about Camera3D?
Shouldn't far be changed to depth_far and near to depth_near?

Thanks!


Multiclusterapp roles and system account changes

Types PR: https://github.com/rancher/types/pull/718

LGTM

@prachidamle addressed those comments on types PR and added the part of finding user by label

@prachidamle addressed those comments on types PR and added the part of finding user by label as per your comment

thank you @mrajashree, LGTM


1356 Trim Leading/Trailing Spaces From Imported Item Titles

Ensured whitespace is removed from around an imported assignment title in the spreadsheet. It was not working with the detection of an existing item, and then causing clashes when it tries to create it.
Fixed a typo in the properties when points not given.
Added a no change check so that we don't end up sending nulls to the backend for scores.
Fixed a whole bunch of compiler warnings
Changed loop iterators

Part of #1356

Noticed the additional commit references. There is only one commit here but its pulling the rest. They are in master already. I'll use a new branch from now on so it doesn't get polluted with this crud.


[Core feature request] Make the Immersive Reader APIs available

[Enter feedback here]
I want to develop an Edge extension that make working with the Immersive Reader feature easy.
Like keyword mapping for pausing, skipping lines and, skipping paragraphs, reTTS a paragraph or a line etc..
I don't know if such APIs exists, but if they do, is it possible that it can be made accessible?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4edd411d-e52a-32ef-e539-fb4ed709c86c
Version Independent ID: 9b96eeb9-accc-7230-20b1-b704d9f9a79e
Content: Microsoft Edge (Chromium) Extensions - Microsoft Edge Development
Content Source: microsoft-edge/extensions-chromium/index.md
Product: microsoft-edge
Technology: extensions
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

@yassinebridi I've checked with the Engineering team and they confirmed that no API exists today. They are interested in understanding more about your scenarios if you'd like to connect with them. I'll go ahead and close this issue now. Have a great day.

@Reezaali , I would like to be able to place the Play button for the screen reader at a specific place on a web page. However, I couldn't locate any documentation on how one could the screen reader for one's web page.


fix: address some out-of-date things in About pages

Needs at least one more pass -- the graphic/explanation has a lot of stuff about the query score, which we no longer provide (we should probably just redo the graphic in HTML)

looks good, request changes in lieu of a few content considerations


core returns {"error": "return value missing", "id": 2}

Hi,
I was playing around with the xi_glium rpc client, but ran into an issue: https://github.com/potocpav/xi_glium/issues/13.
The panick in xi_glium happens because the core returns an error. I reproduced with a little bit more logging:
sending: {"id":1,"method":"new_tab","params":[]}
received {"id": 1, "result": "0"}
sending: {"id":2,"method":"edit","params":{"method":"open","params":{"filename":"foo.txt"},"tab":"0"}}
received {"method": "update", "params": {"tab":"0","update":{"first_line":0,"height":1,"lines":[["",["cursor",0]]],"scrollto":[0,0]}}}
received {"error": "return value missing", "id": 2}

What does this error mean, and how should it be handled on client side?
Here is the code to reproduce: https://github.com/little-dude/xi-tui/blob/master/src/main.rs.
The json-rpc client is a copy/paste of the xi_glium client (https://github.com/potocpav/xi_glium/blob/master/src/core.rs).

Solved: https://github.com/potocpav/xi_glium/issues/13#issuecomment-245599098

[The issue] was caused by calling the back-end with an "id" parameter, when none is expected.


[Bug] use any reasonable upload-order, like every other upload-tool

Many SVG-files get blocked due to security reasons, so they get an error-message.
Since it always jumps to the current upload, it is difficult to check the errors during upload.
If the files would be uploaded alphabetically, this would be easier to find a specific file in a folder. I know it can be done using excel.exe or Libre-office-calc. I think a button in pattypan for alphabetical sort the *.xls-file would be easy to implement.

Maybe the documentation could be improved to suggest one does this in their spreadsheet tool, duplicating features from spreadsheet tools could go out of hand.

Maybe the documentation could be improved to suggest one does this in their spreadsheet tool, duplicating features from spreadsheet tools could go out of hand.

Thanks, I must rename my Question. I don't want spreedsheets-features in pattypan, I just want that pattypan uses any reasonable order, as Upload-Wizard, Come-On, Commonist, VicuñaUploader, pywikibot ...
All of them upload them in order (at least if a single folder, without subfolders), only pattypan is different. So it is a bug, not a feature-request.
I don't mind if pattypan uses alphabetical order, date, ... , but not randomizing it.
I understand that randomizing it, can make sense if you check only the first files, or you want to stop (get blocked) before all mistakes of the same group are uploaded. However randomizing should be opt-in not opt-out.

#109

@Abbe98 : Thanks I'm using Fedora 32 (I should have reported it, I thought it's irrelevant), Duplicate #109 (I might forgot to check it for this issue, or I did not found it).
Operating System:
Linux version 5.11.11-100.fc32.x86_64<EMAIL_ADDRESS>(gcc (GCC) 10.2.1 20201125 (Red Hat 10.2.1-9), GNU ld version 2.34-6.fc32) #1 SMP Tue Mar 30 16:53:59 UTC 2021


U2f fixes

This commit fixes two issues with U2F:

Principal attributes were duplicated when U2F MFA was used. This was causing issues with applications that did not handle multiple values for attributes (even though the attribute values were the same). This commit modifies U2FAuthenticationHandler by creating a new principal similar to how YubiKeyAuthenticationHandler does it.
U2F templates were displaying the message key instead of the message strings.

I think this change should be backported to the 5.3.x branch since U2F is essentially broken right now. I'm not sure the best way to accomplish that. If you would like me to cherry-pick these commits and submit another pull request please just let me know.
Thanks!

Thank you very much. Do you think you might be able to write a few cases to show the failure/success cases?

@mmoayyed If you mean create some test cases, then no problem. Let me see what I can come up with next week.

Very Useful in v5.3.x


Missing modules

The first exercise requires the react and react-dom modules but does not include them in the list to be installed.
It's possible that an older version of NPM installed them automatically via peer dependencies or something else, but with NPM 3 they were missing.

Thanks!


Delete Logic and TodoList

fixes #266

Codecov Report

Merging #267 into master will increase coverage by 6.31%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #267      +/-   ##
============================================
+ Coverage     19.66%   25.97%   +6.31%
  Complexity      299      299
============================================
  Files           203      146      -57
  Lines          3016     2283     -733
  Branches        270      226      -44
============================================
  Hits            593      593
+ Misses         2376     1643     -733
  Partials         47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd87e16...36cb686. Read the comment docs.


Excellent plugin! How run in mobile?

Is it possible to work on the mobile?

thnx. I'm not sure, I'll check it and add a fix if possible

iPhone 8 safari don't work.

with samsung s7 edge chrome also doesnt work

with samsung s7 edge chrome also doesnt work
Remote debugger
Uncaught TypeError: Cannot read property 'getTracks' of undefined at t.value (vue-audio-recorder.min.js?c115:1) at VueComponent.toggleRecorder (vue-audio-recorder.min.js?c115:1) at click (vue-audio-recorder.min.js?c115:1) at invoker (vue.esm.js?a026:2027) at HTMLDivElement.fn._withTask.fn._withTask (vue.esm.js?a026:1826)

turns out, it doesnt work on http.... when i deploy to firebase it works as expected

It works perfectly on real devices (IOS & Android) by HTTPS.
  "Tried on iOS Chrome"...?


SIFT-VM Workaround for Clean Install Issues

As of late, there have been a few users utilizing the VM provided on the SANS website to create their SIFT workstation. Running the steps below immediately after launching the VM should mitigate those issues until such time as the VM is updated.
NOTE: These are only for a brand-new fresh SIFT VM, not for a VM which has already been modified:
mkdir .cpan
mkdir .dbus
sudo sed 's/2018.3/2019.2/g' -i /etc/apt/sources.list.d/saltstack.list
sudo apt update && sudo apt upgrade -y
sudo apt upgrade -y salt-minion salt-common --allow-change-held-packages
sudo curl -Lo /usr/local/bin/sift https://github.com/sans-dfir/releases/download/v1.8.5/sift-cli-linux
sudo chmod +x /usr/local/bin/sift
sudo sift upgrade --pre-release

The saltstack.list bundled with the VM is for 2018.3, which no longer exists as a saltstack repo, and will cause an apt update error preventing an upgrade. Additionally, the sift-cli v1.8.5 uses 2019.2 as a base for the installer. Additionally, during the sift-cli install, the .cpan and .dbus directories unintentionally become improperly owned by root, which will cause future sift-cli updates.
Since the .cpan and .dbus directories don't exist at this time in the fresh VM, creating them doesn't cause any conflicts.
Finally, the sudo apt upgrade -y salt-minion salt-common --allow-change-held-package must be run separately, because the salt-common and salt-minion do not get upgraded with the sudo apt upgrade -y command/
This should mitigate any future errors with the VM until updates are made to the VM and corrections are made to the salt-states to fix the permissions. I'll be working on a pull request for the permissions later today/tomorrow.
Cheers

I think we probably just need to loosen the reigns and just allow latest to be set at all times, it would prevent this in the future, but could become problematic.
We are trying to get better about updating the VM on the website to.

change the curl to https://github.com/teamdfir/sift-cli/releases/download/v1.8.5/sift-cli-linux

There's a newer version available now https://github.com/teamdfir/sift-cli/releases/tag/v1.9.0-rc4


Updated to new version 9.0.0 now get no rates chart

Describe the bug
getting the following after updating to v9.0.0 and restarting home assistant

Reproduction steps
Updated to version 9.0.0
Expected behaviour
no change to rates charts for Octopus Agile import and export
Tariff Code
E-1R-AGILE-FLEX-22-11-25-E
Integration Version
9.0.0
Home Assistant Version
Core 2023.11.2
Fresh Install?
Not specified
Home Assistant Logs
Not relevant

Hello. This is due to the breaking changes that were outlined in this release, and proposed a month ago. The developer of that card hasn't got round to updating the integration. Any issues with that card should be raised or highlighted on their GitHub.


[branch-2.0-pick] Picks "[regression](partial update) Add cases when the deleted rows have non nullable columns without default value #26776"

Proposed changes
picks https://github.com/apache/doris/pull/26776
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


accept misordered ISA keys

The pyQuil tests have been QPU descriptors with specs layers containing misordered ISA keys all along. This PR extends quilc's tolerance toward this, though it still scolds with a warning.

oh, oops, my local copy has a warn when sort acts nontrivially. that’s ok, serves me right for not saving my sass.


vendor docker/distribution 4e17ab5d319ac5b70b2769442947567a83386fbc

Fix https://github.com/docker/docker/issues/24360
Add a regression test (which fails w/o this vendoring of course)

This vendoring brings in https://github.com/docker/distribution/pull/1812 which is the commit needed to fix #24360
/cc @aaronlehmann
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

Please consider including this into 1.12 since it's breaking applications relying on 1.10.3 behavior (correct somehow) and when upgrading to 1.12 (or 1.11.2 for the matter) it fails

not sure what's happening with all Janky's checks here though /cc @thaJeztah

LGTM

LGTM 🐸


pycharm Cannot find reference 'SUB' in 'init.py

Such as the title， All socket_types are not available, others are not automatically completed.
pycharm version: 2018.1.4
system: Window10
pyzmq version: 17.0

plus 1

This is a duplicate of #1018. Static analysis cannot find runtime-defined names.


Add version option to bin

It will be very helpful when build from source and for debug information in issue
kwmc --version

or
kwmc version

Not going to add kwmc --version. The only reason the version paramter of kwm even exists, is because of the test case required by homebrew

Wow, well
Could you describe what are differences between kwm and kwmc?
Thanks

Kwm is the actual program responsible for managing windows and such.
Kwmc is simply a tcp-client sending text-messages to Kwm, telling it to do something.
You could just as well telnet <IP_ADDRESS> 3020 and type window -f next  to shift focus.


 I tested with stage 1 but now stage 2.

nice!


Replace twind styles with inlined styles for the locator package

We decided to use twind for styling, because it supported Constructable Stylesheet Objects that can be used for styling ShadowDom elements.
Unfortunatelly they aren't fully supported in all of the browsers (#33) and we are moving away from twind in the rest of the packages as well.
So the locator styles should be rewritten to use <style></style> tag styling.

Using unocss here should be an easy swap.


Timeout waiting for ADC conversion

I've got the weather hat working reasonably well with this library even though I had some issues with the rain measurements seeming off.
However, since I set it to run permanently yesterday, it crashed last night with the following traceback:
Traceback (most recent call last):
  File "/home/pi/weatherhat-python/examples/rpi-weather.py", line 109, in <module>
    sensor.update(interval=interval)
  File "/usr/local/lib/python3.9/dist-packages/weatherhat/__init__.py", line 160, in update
    self.wind_direction_raw = self._ioe.input(PIN_WV)
  File "/usr/local/lib/python3.9/dist-packages/ioexpander/__init__.py", line 704, in input
    raise RuntimeError("Timeout waiting for ADC conversion!")
RuntimeError: Timeout waiting for ADC conversion!

interval where I call sensor.update is set to 5.0 like  in most of the examples.
Anyone got any idea why this might be happening? I've wrapped the whole thing in a try except for now under the assumption that this is a blip and next time I try to get measurements, it'll work again, but I can't be sure yet.

Sorry for the lack of reply here! Hopefully you've got things working in the meantime, but if you're still having problems with the latest version of the software please let us know.


Inomurko/bump ink

:clipboard: Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.
Changes
Describe your changes and implementation choices. More details make PRs easier to review.

Change 1
Change 2
...

Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

Coverage remained the same at ?% when pulling 59adc9e0daf5c0257ed5cb04a380923b44ccead9 on inomurko/bump_ink into 723e2dacde73572b4f1b6399399ae476af738878 on master.


Manual token upload for Quay

Signed-off-by: Max Shaposhnik<EMAIL_ADDRESS>What does this PR do?
Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

what about creating separate DTO for token?


Change to refer Kinect SDK 1.x that installed using vcpkg port

Fix according to changes of Kinect SDK 1.x port https://github.com/Microsoft/vcpkg/pull/1925.
Change to refer Kinect SDK 1.x that installed using vcpkg port.
It will be always generate the Kinect SDK 1.x driver, even when Kinect SDK 1.x is not installed in user system.

This pull request depends on https://github.com/Microsoft/vcpkg/pull/1925.
Please merge https://github.com/Microsoft/vcpkg/pull/1925 earlier than this pull request.
Thanks,

Thanks, we definitely want it to work like this!

I am getting an error because of this PR
vcpkg install openni2 shows
CMake Error at ports/openni2/portfile.cmake:142 (file):
  file INSTALL cannot find
  "C:/dev/vcpkg/buildtrees/openni2/src/OpenNI2-2.2-beta2/Bin/x64-Release/OpenNI2/Drivers/Kinect.dll".
Call Stack (most recent call first):
  scripts/ports.cmake:72 (include)

Error: Building package openni2:x64-windows-dev failed with: BUILD_FAILED

@jasjuang OpenNI2 port will be installed successfully in my environment. (vcpkg install openni2:x86-windows, vcpkg install openni2:x64-windows)
Please download vcpkg of latest version, and try again.
If reproduce same error, please open new issue , and attach log files.
Thanks,

I already opened a new issue at #1927 . I deleted OpenNI2-2.2-beta.zip in the downloads folder and let it re-download but it doesn't help. I git pull and the run bootstrap-vcpkg.bat again but it also doesn't help. I look into the buildtree folder and it looks like Kinect.dll is not generated.


Support pickling Geography objects

At the moment we didn't implement this, so you will get TypeError: cannot pickle 'spherely.Point' object, but it would be useful to support it.
To provide a full exact roundtrip through pickling, we should maybe pickle the raw unit vector (x, y, z) of the S2Point, instead of going through latitude/longitude like other conversions (eg WKB), because there can always be some floating point difference in this conversion.

S2geometry provides Encoder and Decoder objects as well as Encode() and Decode() methods from most of its data types (point, polyline, polygon) so we might be able to just reuse that. For a point it serializes the raw unit vector. It is also possible to encode S2ShapeIndex objects with lazy decoding.
Probably cleanest would be to expose this API via s2geography::Geography wrapper classes than dealing with it directly in spherely (same for other methods like Clone(), which would be better than this function implemented in #51).

Actually, I think we could already access Encode() and Decode() via s2geography::Geography::Shape().

https://github.com/paleolimbot/s2geography/pull/40 is now merged so adding support for pickle should be easier.
That s2geography PR also added the GeographyKind enum tag, which will allow us to clean up some parts of the code in Spherely (e.g., remove some dynamic_cast).


[3.x] Fix selection of spaced atlas tile when using priority

Spacing was not taken into account when calculating the number of subtiles, so extra tiles were included as candidates.
This targets 3.x because TileSet code on master got a rewrite for the new TileSet editor.
Fixes #43331

Thanks!

Cherry-picked for 3.3.3.


Is this still active?

I need a working cloudflare scraper for java, but I can't find a working one. If you know what I should change in your code, please let me know I will PR it. I need that thing

I've recently unarchived this repository. I have a working code ready thanks to "Free HongKong". I will fix the repo soon. Stay tuned!

Very nice :)

As soon as possible
On Wed, Oct 30, 2019, 17:26 MrIvanPlays<EMAIL_ADDRESS>wrote:

When will that code be pushed for use ?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/giacomoferretti/cloudflare-scraper/issues/3?email_source=notifications&email_token=AANSHI5BJXDQDHVDUSNRFRLQRGYUFA5CNFSM4JG3EVZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECU3L7Q#issuecomment-547993086,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANSHI4TLXND6O6EZ6IOHDDQRGYUFANCNFSM4JG3EVZQ
.

I've tried updating the code, but the included Nashorn engine doesn't support some functions added in the Cloudflare challenge. We could use either Node JS or something else, but I won't update the code in the near future.

Change the nashorn engine with something other I guess?


Update quick-src.sh

just running npm install gives me the following error:
npm ERR! Error: EPERM, chmod '/home/edison/src/oref0/node_modules/oref0/bin/oref                                                                             0-calculate-iob.js'
npm ERR!  { [Error: EPERM, chmod '/home/edison/src/oref0/node_modules/oref0/bin/                                                                             oref0-calculate-iob.js']
npm ERR!   errno: 50,
npm ERR!   code: 'EPERM',
npm ERR!   path: '/home/edison/src/oref0/node_modules/oref0/bin/oref0-calculate-                                                                             iob.js' }
npm ERR!
npm ERR! Please try running this command again as root/Administrator.
npm ERR! System Linux 3.10.17-yocto-standard-r2
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! cwd /home/edison/src/oref0
npm ERR! node -v v0.10.29
npm ERR! npm -v 1.4.21
npm ERR! path /home/edison/src/oref0/node_modules/oref0/bin/oref0-calculate-iob.                                                                             js
npm ERR! code EPERM
npm ERR! errno 50
npm ERR! stack Error: EPERM, chmod '/home/edison/src/oref0/node_modules/oref0/bi                                                                             n/oref0-calculate-iob.js'
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /home/edison/src/oref0/npm-debug.log
npm ERR! not ok code 0
Running this command as sudo appears to fix it

Can you try (re)moving src/oref0 and trying it again as yourself without sudo? You might have incorrectly done the clone using sudo at one point, which would mean all subsequent operations also want sudo.

@eyim did @scottleibrand 's suggestion resolve?

yes removing and redoing it from scratch worked.


Ehud lev add min batch size

Description...
We would like to support minimum batch size. Since we might have a time with no traffic and we don't want to wait forever for the events that are not satisfy minimum batch, we will also add minBatchTimeoutInMillis, if we passed this timeout, code will be as today.
see issue
Checklist

[ ] Documentation (if applicable)
[ ] Changelog

Title should be something likes:
feature: Add min batch size support


[SuppressDefaultInitialization] for field in TypeScript does not wok.

public enum MaskOpacity
{
    none = 0,
    low = 1,
    high = 2
}

[MemoryPackable]
[GenerateTypeScript]
public partial class UIConfig
{
    public int Id { get; set; }
    public string Url { get; set; }
    public bool IsPopUp { get; set; } = true;
    public bool IsNeedMask { get; set; }
    public MaskOpacity MaskOpacity { get; set; }
    public bool IsAni { get; set; }
}

It's a limitation of the TypeScript implementation.
I think it will be prohibited rather than supported.


WIP: Command line proper validation + simpler Main

Update GATK4 dependency
Solves #51 and #50
WIP: include some tools from GATK required for our inputs (VCF, reference, etc.)

Current coverage is 83.835% (diff: 100%)

Merging #52 into master will increase coverage by 0.708%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1361    -14
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
- Hits           1143       1141     -2
+ Misses          181        168    -13
- Partials         51         52     +1

Diff Coverage
File Path

•••••••••• 100%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

Powered by Codecov. Last update 6aeb321...94ec5df

Current coverage is 83.883% (diff: 100%)

Merging #52 into master will increase coverage by 0.756%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1365    -10
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
+ Hits           1143       1145     +2
+ Misses          181        168    -13
- Partials         51         52     +1

Diff Coverage
File Path

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

•••••••••• 100%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

Powered by Codecov. Last update 6aeb321...c36e2dc

Current coverage is 83.845% (diff: 93.333%)

Merging #52 into master will increase coverage by 0.718%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1368     -7
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
+ Hits           1143       1147     +4
+ Misses          181        168    -13
- Partials         51         53     +2

Diff Coverage
File Path

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

Powered by Codecov. Last update 6aeb321...eeeddef

Current coverage is 83.845% (diff: 93.333%)

Merging #52 into master will increase coverage by 0.718%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1368     -7
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
+ Hits           1143       1147     +4
+ Misses          181        168    -13
- Partials         51         53     +2

Diff Coverage
File Path

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

•••••••••• 100%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

Powered by Codecov. Last update 6aeb321...eeeddef

Current coverage is 82.769% (diff: 62.500%)

Merging #52 into master will decrease coverage by 0.359%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1387    +12
  Methods           0          0
  Messages          0          0
  Branches        223        223
==========================================
+ Hits           1143       1148     +5
- Misses          181        186     +5
- Partials         51         53     +2

Diff Coverage
File Path

•••        33%
src/main/java/org/magicdgs/thaplv/Main.java

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

Powered by Codecov. Last update 6aeb321...7ddd731

Current coverage is 82.769% (diff: 62.500%)

Merging #52 into master will decrease coverage by 0.359%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1387    +12
  Methods           0          0
  Messages          0          0
  Branches        223        223
==========================================
+ Hits           1143       1148     +5
- Misses          181        186     +5
- Partials         51         53     +2

Diff Coverage
File Path

•••        33%
src/main/java/org/magicdgs/thaplv/Main.java

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

Powered by Codecov. Last update 6aeb321...7ddd731

Current coverage is 83.723% (diff: 87.500%)

Merging #52 into master will increase coverage by 0.595%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1370     -5
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
+ Hits           1143       1147     +4
+ Misses          181        170    -11
- Partials         51         53     +2

Diff Coverage
File Path

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••    75%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

Powered by Codecov. Last update 6aeb321...ccce4cc

Current coverage is 83.723% (diff: 87.500%)

Merging #52 into master will increase coverage by 0.595%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1370     -5
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
+ Hits           1143       1147     +4
+ Misses          181        170    -11
- Partials         51         53     +2

Diff Coverage
File Path

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••    75%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

Powered by Codecov. Last update 6aeb321...ccce4cc

Current coverage is 83.723% (diff: 87.500%)

Merging #52 into master will increase coverage by 0.595%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1370     -5
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
+ Hits           1143       1147     +4
+ Misses          181        170    -11
- Partials         51         53     +2

Diff Coverage
File Path

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••    75%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

Powered by Codecov. Last update 6aeb321...ccce4cc

Current coverage is 83.723% (diff: 87.500%)

Merging #52 into master will increase coverage by 0.595%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1370     -5
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
+ Hits           1143       1147     +4
+ Misses          181        170    -11
- Partials         51         53     +2

Diff Coverage
File Path

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••    75%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

Powered by Codecov. Last update 6aeb321...dbf4dbd

Current coverage is 83.723% (diff: 87.500%)

Merging #52 into master will increase coverage by 0.595%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1370     -5
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
+ Hits           1143       1147     +4
+ Misses          181        170    -11
- Partials         51         53     +2

Diff Coverage
File Path

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••    75%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

Powered by Codecov. Last update 6aeb321...dbf4dbd

Current coverage is 83.723% (diff: 87.500%)

Merging #52 into master will increase coverage by 0.595%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1370     -5
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
+ Hits           1143       1147     +4
+ Misses          181        170    -11
- Partials         51         53     +2

Diff Coverage
File Path

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••    75%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

Powered by Codecov. Last update 6aeb321...dbf4dbd

Current coverage is 83.723% (diff: 87.500%)

Merging #52 into master will increase coverage by 0.595%

@@             master        #52   diff @@
==========================================
  Files            50         50
  Lines          1375       1370     -5
  Methods           0          0
  Messages          0          0
  Branches        223        222     -1
==========================================
+ Hits           1143       1147     +4
+ Misses          181        170    -11
- Partials         51         53     +2

Diff Coverage
File Path

•••••      50%
...rc/main/java/org/magicdgs/thaplv/tools/GetFasta.java

•••••••    75%
src/main/java/org/magicdgs/thaplv/Main.java

•••••••••• 100%
.../broadinstitute/hellbender/engine/HaploidWalker.java

•••••••••• 100%
...ions/HaplotypeModelWithPloidyArgumentCollection.java

•••••••••• 100%
.../main/java/org/magicdgs/thaplv/tools/ld/LDdecay.java

•••••••••• 100%
...main/java/org/magicdgs/thaplv/tools/ibd/IBDTool.java

•••••••••• 100%
...entcollections/HaplotypeModelArgumentCollection.java

Powered by Codecov. Last update 6aeb321...dbf4dbd


crux docs tweak

What's changed, or what was fixed?

small documentation update

Fixes: n/a
Target Live Date: 2018-05-02

[x] This has been reviewed and approved by @igrigorik
[x] I have run gulp test locally and all tests pass.
[x] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

:tada: This has been pushed live to https://developers.google.com/web/


Memoized1 does not store value in cache

Maybe I missunderstand here sth., but it looks like that Memoized1 does not write to the cache at all / ignores the cache.
My example:
final Memoized1<int, String> fn = Memoized1((String p0) {
    print(p0);
    return 0;
});
fn('123');
fn('123');

Basically prints twice '123'.

Nevermind, works now. I think I did sth. wrong :)


Following the instructions causes this error

Uncaught Error: you must set a pusherClient by calling setPusherClient
My code is simply this
import { setPusherClient } from 'react-pusher';
import Pusher from 'react-pusher';

const pusherClient = new Pusher('xxxx1234567890xxxx', {encrypted: (document.location.protocol == 'https:')});
setPusherClient(pusherClient);

It's complaining about not having setPusherClient as soon as I define the variable.

Try replacing the line:
import Pusher from 'react-pusher';

with
import Pusher from 'pusher-js';

I'm having the same issue as gotoAndBliss. Applying your suggestion above gives an error:
Module not found: Error: Cannot resolve module 'pusher-js' in <app directory>
If pusher-js needs to be installed as well, should it not listed as a dependency or be in the readme?

pusher-js is meant to be a peer dependency, we should update package.json

The readme on npmjs.com says to
import pusherClient from 'pusher-js';
which seems incorrect?

That should be fine, why do you think it's incorrect?


Backport linkedin client support via properties to 1.9.5

I want to create a patch of LinkedIn support for CAS 5.0.x. Therefore, backport linkedin client configure to 1.9.5
Code lifted from https://github.com/pac4j/pac4j/pull/737/commits/88d705be38b95ce1dd3293ac7819fb23bf4ef798.

No problem. This will be available in the 1.9.6-SNAPSHOT version as first, then in the 1.9.6 release.


Cant move widget to another grid-stack after it has been added to one (nested stack)

I have 2 gridstack regions where I can drop widgets. I have configures them to accept widgets with class '.grid-stack-item.widget'. The problem is that when I drop the widget into one gridstack, I can only move it inside that gridstack.
Am I doing something wrong ? I have tried to approach this from every possible angle I can imagine. Any help is appreciated.
Test situation (with codepen example):
Drop a widget from "Widget UI" To one of the drop regions (marked green).
Now try to drag that widget into the second drop region (the other green area)
You will see that you are unable to move it there although if you had dropped it there in the first place the region would have accepted the widget.
http://codepen.io/dolorsitamet/pen/ONjEmg

Closing. We will keep #451 open, as it mentions a few issues, all related.


Using --x-buildtrees does not overwrite the value in SOURCE_PATH

In case https://github.com/microsoft/vcpkg/issues/21343, the user used the extra option --x-buildtrees when building qt5, which resulted in the failure of clearing EffectiveSourcePaths in the script configure_qt.cmake:
https://github.com/microsoft/vcpkg/blob/a2fcb03749ff5897b5985092934dc6057680c789/ports/qt5-base/cmake/configure_qt.cmake#L145
Our expectation is that SOURCE_PATH is always the currently used source path of the library.
Obviously, this does not meet the expected results.

just replace it with:
string(REPLACE "[EffectiveSourcePaths]\nPrefix=[^\n]+\n" "" _contents ${_contents})

just replace it with: string(REPLACE "[EffectiveSourcePaths]\nPrefix=[^\n]+\n" "" _contents ${_contents})

Yeah, that will definitely solve the qt issues, but this issue still exists.

To my understanding the vcpkg tool does not set any variable named SOURCE_PATH; that's just a common convention we happen to use a lot as the name for vcpkg_from_xxx.
https://github.com/microsoft/vcpkg-tool/blob/45c773ee248f664b96dda6f41502cca8c380cede/src/vcpkg/buildenvironment.cpp#L15
It appears the name the vcpkg binary sets is BUILDTREES_DIR.

To my understanding the vcpkg tool does not set any variable named SOURCE_PATH; that's just a common convention we happen to use a lot as the name for vcpkg_from_xxx.

Yeah but this will obviously mislead maintainers.

Yeah but this will obviously mislead maintainers.

I'm not sure I understand; whatever portfile.cmake set SOURCE_PATH to a funny value needs to be fixed here; vcpkg can't fix setting a variable it never set in the first place.

I'm not sure I understand; whatever portfile.cmake set SOURCE_PATH to a funny value needs to be fixed here; vcpkg can't fix setting a variable it never set in the first place.

SOURCE_PATH is provided by vcpkg_from_* and vcpkg_download_dstfile. Obviously, this value has become well-known, and our maintainers expects to pass it into the configuration script to call the files in the path.
However --x-buildtrees clearly broke the maintainer's expectations.

Consider this:
vcpkg_configure_make adds the option COPY_SOURCE because some ports do not support building outside the source, but the source path used by the user who uses the --x-buildtrees option is not the expected value (VCPKG_ROOT/buildtrees/PORT/src/HASH), This will cause the failure to copy all files in the source path to VCPKG_ROOT/buildtrees/PORT/TRIPLET_dbg when using COPY_SOURCE.

SOURCE_PATH is provided by vcpkg_from_*

No, those set whatever variable name the user wants. Rather than:
vcpkg_from_github(
    OUT_SOURCE_PATH SOURCE_PATH
    REPO cpp-io2d/P0267_RefImpl
    REF caa0ba0cb5a421a38bc26afaf3505bee206c44dd # accessed on 2020-09-14
    SHA512 f8e5a708f6cbda913a0492a843e1502b8d3cc615a6abda50e850be944e1484ec9087b787c54cc25d513172a7d5ab789be41a761c97df94266df4d1bcf14db17c
    HEAD_REF master
    PATCHES
        cmake.dep.patch
)

the user can do
vcpkg_from_github(
    OUT_SOURCE_PATH ANYTHING_YOU_WANT
    REPO cpp-io2d/P0267_RefImpl
    REF caa0ba0cb5a421a38bc26afaf3505bee206c44dd # accessed on 2020-09-14
    SHA512 f8e5a708f6cbda913a0492a843e1502b8d3cc615a6abda50e850be944e1484ec9087b787c54cc25d513172a7d5ab789be41a761c97df94266df4d1bcf14db17c
    HEAD_REF master
    PATCHES
        cmake.dep.patch
)

and there will be no SOURCE_PATH.
In the linked ports/qt5-base/cmake/configure_qt.cmake#L145 example, SOURCE_PATH is a parameter, so where the bad parameter value came from needs to be investigated.

vcpkg_configure_make adds the option COPY_SOURCE because some ports do not support building outside the source, but the source path used by the user who uses the --x-buildtrees option is not the expected value

In this case too it is a parameter, not a well known value set by vcpkg:
https://github.com/microsoft/vcpkg/blob/d0ce2aa08b1b3b1e740eeaec5d724bbe2099ea1f/scripts/cmake/vcpkg_configure_make.cmake#L230-L234

AFAICT the source path is passed out of download functions and into configure functions explicitly.
Build functions operate only on build paths which are more based on convention, not passed out of configure functions explicitly. They don't know about source paths.

In the linked ports/qt5-base/cmake/configure_qt.cmake#L145 example, SOURCE_PATH is a parameter, so where the bad parameter value came from needs to be investigated.

just run vcpkg with --x-cmake-args=--trace-expand ;)
So SOURCE_PATH is set by one of the download functions. The problem with it is that it seems to see through system indirection which is a problem if subst is used and the buildsystem does not see through it. As far as I can tell vcpkg_extract_source_archive_ex is setting SOURCE_PATH which is using the new cmake_path API. So this could be the issue.


Add function to open URL in browser

A portable way for opening web links would be handy.
On Mac it usually looks like this:
[[NSWorkspace sharedWorkspace] openURL: [NSURL URLWithString: s]];

Windows:
ShellExecute(NULL, "open", url.c_str(), NULL, NULL, SW_SHOWNORMAL);

etc.

Not a fan :) This would be relatively easy to put into a separate library since it doesn't rely on sokol_app.h internals (and even then it would probably be better to expose the required platform-specific internals, similar to sapp_win32_get_hwnd().


Dcs 271 ca resubmit dm

New branch created

LGTM - apart from duplicate method name in Spock test. That's a minor problem but needs fixing...

done


ModuleNotFoundError: No module named 'src.utils.get_model'

I believe that there is a missing file "src/utils/get_model.py" which is required for model dev evaluation, referenced in this line
If I just try to run import src.utils.get_model, then I get the following error:
ModuleNotFoundError: No module named 'src.utils.get_model'

I've removed the line and replaced it with the correct one. Thanks for catching this.


Warning: Received false for non-boolean attribute visible

That's a common warning these days. A lot of libraries are fixing it for themselves. I think react should decide on some approach and fix it but for now they are not. So maybe a temp fix will be good and then we can remove it.

The fix probably should be applied do this file
It's about stringifying boolean or even better, apply the attribute for true and omit it for false.
P.S. You can reproduce the warning if you run the our website :))

That warning probably happens because you're passing a prop to a Swiss element, but not defining that prop in swiss styles.
The way how it works is that all props that are defined in styles are stripped before render.

Okay, Kris, what about that?

showModal is declared in swiss styles but I'm still getting a warning for this property:

showModal is still trying to get to the DOM for some reason.

That's because you have openModal declared and not showModal. Tisho tisho tisho tisho

showModal is a prop within a prop, that should not work

You wrote this. Kris kris kris kris

If you 2 kids could just get along, I'll look into this. :)

I fixed this. If you still see this warning in 0.2.22 please let me know.

Awesome, thanks!


I also can not fetch latest release version of this repo.

My pod search AttributedLib result:
-> AttributedLib (2.1.1)
   Modern Swift µframework for attributed strings.
   pod 'AttributedLib', '~> 2.1.1'
   - Homepage: https://github.com/Nirma/Attributed
   - Source:   https://github.com/Nirma/Attributed.git
   - Versions: 2.1.1, 2.1.0, 2.0.2, 2.0.1, 2.0.0, 1.3.0, 1.2.0, 1.1.0, 1.0.0,
   0.2.2, 0.2.1, 0.2.0, 0.1.1, 0.1.0 [master repo]

I think problem is in here:
s.source           = { :git => 'https://github.com/Nirma/Attributed.git', :tag => s.version.to_s }

I also check your tag position:

So I consider maybe you should move the tag at the correct place.

In my forked repo, I also check my tag position:

I can use my forked repo to fetch the latest AttributedLib framework~

Indeed, it looks like the latest tag has not been published to Cocoapods. @Nirma Can you please do so?
In the meantime, one can temporarily workaround this issue with:
pod 'AttributedLib', :git => 'https://github.com/Nirma/Attributed.git', :tag => '2.2.0'

@Nirma Any update on this?

@Arcovv @natan Thank you so much for opening the issue. I have stepped away from this project for most of half of last year do to personal reasons but would like to step back in again and move forward. The latest version has been pushed to trunk! Please tell me if pod update works!

Hi @Nirma it's worked! Thank you!

@Nirma Thank you.


Suggested feature: Rotating on teleport

It would be really cool to have the option of being able to rotate on teleport. Similar to what UE4 has in their VR template and the mechanism that exists in Robo Recall. It would work best for people like myself with 180 degree setups. I could help code it if need be. It's just something I've wanted to see in VRTK for a while now.

https://www.youtube.com/watch?v=qD-dD43E8pg