EVP_PKEY_size() == RSA_size() for RSA keys ?

For RSA-PSS signature with saltlen="max" one would have calculated the saltlen as RSA_size(rsa) - hashlen - 2 [*]. As RSA_size() is deprecated, is it safe to replace it with EVP_PKEY_get_size(pkey) ?
Asking this because the docs seem to indicate that EVP_PKEY_get_size() could be larger than the minimum required number of bytes. If its over-estimated, the resulting saltlen calculation will be off. An option would be to compute the number of bytes from EVP_PKEY_get_bits(), but trying to keep the old logic. This is for use when signing with external keys.

[*] And an extra -1 if (modBits-1) is a multiple of 8

I'd follow the manual page definition of these two functions and rather use the (EVP_PKEY_get_bits() + 7) / 8 value. As the EVP_PKEY_get_size() does not guarantee the size would be exact. Yeah, the EVP_PKEY_get_bits() value is also defined only for the concrete algorithm but here the algorithm is RSA by definition so the value is fairly cleanly defined as the number of bits of N.


CST assignments required by Valody

I read your paper with great interest: Hugerth, L.W., Krog, M.C., Vomstein, K. et al. Defining Vaginal Community Dynamics: daily microbiome transitions, the role of menstruation, bacteriophages, and bacterial genes. Microbiome 12, 153 (2024). https://doi.org/10.1186/s40168-024-01870-5
I am also grateful for the supplementary data you have provided.  I am wondering if you can also provide the assigned CST types for each sample listed in the Supplementary Table S1 and Supplementary Table S2.   I just couldn’t find any CST information for each of your samples, or maybe I have missed something.
I hope to use the CST data to learn Valody (e.g., reproduce the results in your paper).
Thanks for your help.

Hi, great comment! I have added the CST information in a new folder in this repo, called "Hugerth Krog files". Should be everything you need!
Commit history: https://github.com/ctmrbio/valody/commit/9b3fd8bf1048d9502e71afe90b44a1c33f6bb9a5


Malatibatchu patch 1

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

0 out of 2 committers have signed the CLA.

[ ] Malati Batchu
[ ] malatibatchu

Malati Batchu seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


REVERT opcode when calling a method of a created contract within a transaction

Related to #592
When creating a "Factory" pattern contract and call a function of the newly created contract directly, the transaction is REVERTED
Expected Behavior

The transaction should not fail and execute correctly. (Remix VM works!)
Current Behavior

Transaction REVERT's
Steps to Reproduce (for bugs)
Code Sample:
pragma solidity ^0.4.24;

contract BulkContract {

    address public balanceAddress;

    constructor() public {
        balanceContract balanceAddress = new balanceContract();
        balanceAddress.execute();
    }

    function transaction() public {
        balanceContract t = balanceContract(balanceAddress);
        t.execute();
    }
}

contract balanceContract {

    // setting variable to non-zero
    // so we can work on a consistent gas limit from the get-go
    uint256 public counter = 1;

    constructor() public { }

    function execute() public {
        counter = counter + 1;
    }
}

when you create the BulkContract the constructor creates a new balanceContract and calls the execute method directly after the creation. The transaction fails with REVERT. In The OpCodes it seems that he checks if Code is available on the new contract and can't find the stuff on the address and fails:
last few lines of the opcodes
USH1
DUP8
DUP1
EXTCODESIZE 0xb930d93715ca899dab71f45b347068c61dea0e81
ISZERO 0x0
DUP1
ISZERO 0x1
PUSH2
JUMPI 0x0 0x9e
PUSH1
DUP1
REVERT 0x0 0x0

Your Environment

Version used: Ganache CLI v6.4.4-beta.0 (ganache-core: 2.5.6-beta.0)
Version of Truffle/Remix/Other tools used:
NodeJS Version: 11

ping? :)

@S3bb1, thanks for the reminder ping! :-)
This is likely due to a gas estimation bug in Ganache-core. @nicholasjpaterno
is working on a fix now and one of us will follow up when we have a fix ready.

Thx @davidmurdoch for the response. If you have any questions or need additional feedback, i will provide it :)

We have the same symptoms when running a fork of both goerli and mainnet. To reproduce against a goerli fork run the following in a truffle console after forking the chain:
const colonyNetwork = await IColonyNetwork.at("0x79073fc2117dD054FCEdaCad1E7018C9CbE3ec0B")

await colonyNetwork.createColony("0xD468b86aBB0C58F0B948b36a8769829aBD66d8AF")
Error: Returned error: VM Exception while processing transaction: revert
    at XMLHttpRequest._onHttpResponseEnd (/Users/Elena/colonyNetwork/node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request.js:318:1)
    at XMLHttpRequest._setReadyState (/Users/Elena/colonyNetwork/node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request.js:208:1)
    at XMLHttpRequestEventTarget.dispatchEvent (/Users/Elena/colonyNetwork/node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request-event-target.js:34:1)
    at XMLHttpRequest.request.onreadystatechange (/Users/Elena/colonyNetwork/node_modules/truffle/build/webpack:/~/web3/~/web3-providers-http/src/index.js:96:1)
    at /Users/Elena/colonyNetwork/node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:112:1
    at /Users/Elena/colonyNetwork/node_modules/truffle/build/webpack:/~/web3-eth/~/web3-core-requestmanager/src/index.js:140:1
    at Object.ErrorResponse (/Users/Elena/colonyNetwork/node_modules/truffle/build/webpack:/~/web3-eth/~/web3-core-helpers/src/errors.js:29:1)

The createColony call is one of the few factory methods we use to instantiate a new Colony in the network. The others are initialiseReputationMining and startNetCycle methods on IColonyNetwork which exhibit the  same behaviour.
This issue occurs even if we send the max gas in the transaction.

Thanks for your patience @S3bb1! Can you try testing again with this branch: https://github.com/trufflesuite/ganache-core/tree/gas-estimation ?

Thanks @nicholasjpaterno for the update. For the example contract it works now :) i will try it with a complex example and see if it works also :)

@S3bb1 Thanks for testing!  Please let me know if you find a case where this is failing!  Certain cases will always fail with any estimation logic: for example the state changes between the estimate and transaction or with certain contrived cases like branching on a condition like gasLeft - which of course changes between an estimate and the transaction itself.  However, my hope is that this truly is an exact "estimate" now for all practical use cases.  So while the estimate in many cases will be greater than the gasUsed, sending even 1 less gas should result in a failure.

Closing this for now.  Please reopen if this is in error!


fixed parse function not returning parsed and transformed data correc…

As previously mention in #2 there is an issue causing data to be returned as it came on the original file regardless of any transformation it may have been applyed to the schema. This PR solves the problem.

@JoacoGV Thanks for the PR! ❤


Display version to WinGet

I would like Elm to make the version number available in the Windows Control Panel. The WinGet package manager needs this information to know when to update the software. I think there is a registry key called DisplayVersion that WinGet checks.
Thanks

WinGet already has the version number: https://github.com/microsoft/winget-pkgs/blob/fca0ecc193e998d681add1f6b8c8894787fa578e/manifests/e/EvanCzaplicki/Elm/0.19.1/EvanCzaplicki.Elm.installer.yaml#L5
The maintainers of that winget-pkgs repo will need to manage updating their data.


The inferred type of 'router' cannot be named without a reference

Describe the bug
I'm following the Serverless Defining Router page, using tsr.router
When exporting the route, I'm getting the following error:

The inferred type of 'usersRouter' cannot be named without a reference to '../../../../../node_modules/@ts-rest/serverless/src/lib/types'. This is likely not portable. A type annotation is necessary.

I found usage of this code in another repo, checked out the code, ran yarn and then had the same typings error.
Similar bug to: https://github.com/ts-rest/ts-rest/issues/391
How to reproduce
See this PR: https://github.com/shawnmclean/sovoli/pull/18/files#diff-303e5e3b866dec03b2ba9430273704f6236c221bba2e998d28384ffd7c977554R9
You can see where the CI throws the same error:
https://github.com/shawnmclean/sovoli/actions/runs/9996744143/job/27631767968?pr=18#step:7:36
Code reproduction
import { tsr } from "@ts-rest/serverless/next";

export const usersRouter = tsr.router<typeof contract.users, Context>(
  contract.users,
  {
    getUser: async (args) => {
     ...
    },
  }
);

ts-rest version
"@ts-rest/core": "3.45.2",
"@ts-rest/serverless": "3.45.2",

@shawnmclean This error happens when you try to emit declarations when compiling with tsc.
Just curious to know... are you exporting the router and compiling it to be used by another package or app? Or are you just compiling it as part of the app to run it directly?
In the latter case, you can just set declarations: false in your tsconfig so that tsc does not emit any d.ts files. These will not be needed anyway if you are just compiling to run the code directly.
Ideally, we'd prefer to export as little as possible of the internal types of the library as that makes it much easier to do backwards compatible changes in the future.


⚠ Bofrost.at has degraded performance

In adab454, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1434 ms

Resolved: Bofrost.at performance has improved in 0bdc468 after 6 minutes.


Add TestCases for HttpClientIdleTimeoutHandler and HttpServerIdleTimeoutHandlerTest

I add test case consider case of https://github.com/line/armeria/issues/14

retest this please


Static content for proxy repositories

Hello,
I wanted to know if it is possible (and useful) for other users (in enterprise environment) to create a static website for the binding.node files.
Use case: It is forbidden to directly download content from github.com. So node-sass fails because the binding.node files can't be downloaded.
Workaround: Download and host every file on a private server. Set the SASS_BINARY_SITE environment variable to that server.
Problem: With every update builds are failing because new binding.node files are not in the private repo.
Solution: So the idea is to proxy it with e.g. an Nexus Proxy repository like it is possible with https://nodejs.org/dist
Best regards

I leave this open for others to comment; I don't think it would be very difficult to setup something that checks Github Releases say once a day for a new release and download the binaries to the mirror.

May be it is nessary to package all things including binary to npm package. When we use npm as a package management system, we may want npm to deal all denpendences, including sass binary.

@tuxknight a list of all binaries is available for every release. Those are relatively large files and we constantly keep adding more as more platforms and node versions are supported. I think this is to much to put into one binary package.


Windows appear blurred-out

I've just started using mac and yabai, so bear with me please.
Initially, with my yabai config, floating windows (such as the settings window) were appearing blurry, behind tiled windows.
Be setting window_topmost to on, the floating window appears on top. But it's still blurred-out. I tried turning off transparency effects, but no luck. Clicks on the window are not registering.

I have to yabai --stop-service to get the blur to go - so I think it is caused by yabai.
Here is my config; let me know if there is anything else I can do.
edit: it is not only floating windows; here a space where the left tiled window is blurred-out. The right window has the focus. Moving the focus to the left window using keyboard shortcuts works (the white bolder moves to the left window), but can't be moved back again to the right window.

yabai -m config window_border_blur off

awesome, many thank! Out of curiosity, what's the use-case for having this option on?

Borders have been removed in the latest release (v6.0.0) (#1889) because of multiple issues present in both Ventura and Sonoma.


fix(server): support commit context to help auto-correct internal generated value

Motivation
#505  introduced breaking changes when upgrading your cluster from the old to the new version. If you do the rolling upgrade, the internal version generator will use the wrong initial value for entries.
The main idea here is that we can use the minimal changes to help auto-correct the generated value between shards due to only upgrading affection.
Modification

Introduce a new concept that named commitContext. We will pass this context when we create a replication stream from leader to follower. Record the commit offset and the last version in that time. Therefore, the follower can understand the correct version id at the specific commitOffset and auto-override the invalid value to reach the consensus.

We need to find a way to be compatible with new features and introduce a tool for this kind of recovery.


In the "Person Search Page", camp list should be shown based on District selected

Subject of the issue
In the "Person Search Page", camp list should be shown based on District selected. If no district is selected, all camps should be shown in the pull down. If a district is selected, only camps in that district should be shown. The pull down list is going to be very large as more are more camps are going to be added.
Your environment
All Browsers
Steps to reproduce

Go to Relief Camp page
Select Person Search
Select District and try to select the camp.

Expected behaviour
If district is selected, show only camps of that district
Else show all camps
Actual behaviour
Irrespective of district selection all camps are being shown now.

Not working on it any more.

this issue looks duplicate of #423

Data has added in production environment


Improve doc about loading CLDR data

Following @rxaviers advice, I've tried to improve the documentation about loading CLDR Data correctly.
Signed-off-by: Laurent Maillet<EMAIL_ADDRESS>

@lmaillet thanks for your updates...
There are multiple ways one can load CLDR into their application. Instead of advocating one way up here at the top, can we improve the How to get CLDR JSON data? and How do I load CLDR data into Cldrjs? sections instead (specially the latter - 2nd one)? We can even reorder the examples (using AMD is less popular these days).

Out of date...


DCG translation not steadfast

Was running this test case:
p --> \+ q.
q --> {write('did you call me?'), nl}.

In Tau Prolog 0.3.2 (beta) I get:
p([a],[]).
false.

On the other hand SWI-Prolog gives me:
?- p([a],[]).
did you call me?
false.

I like how TauProlog translates (+)/1, i.e. that it doesn't use
phrase/3 unlike what UWN proposes:
dcg_cbody(\+ GRBody, S0, S, ( \+ phrase(GRBody1,S0,_), S0 = S ), M) :-
module_call_qualified(M, GRBody, GRBody1).

But I guess one can read off from UWNs translation how to
make it steadfast, i.e. the extra S0 = S.

@Jean-Luc-Picard-2021 What's the definition of steadfast? I've tried looking it up before but couldn't get a clear answer.

@gilbert: "steadfast" is hard to define in general. A "classical" example of a definition that is not steadfast is usually given for max/3, which we can wrongly define as:

max(X, Y, X) :- X > Y, !.
max(_, Y, Y).

With this definition, which seems to make intuitive sense, we have:

?- max(1, 0, X).
   X = 1.

It works as expected, right? But on the other hand, the maximum of 1 and 0 is unexpectedly 0 if we ask like this:

?- max(1, 0, 0).
   true.

The predicate is not steadfast in the sense that, by instantiating arguments in the query, we can trick it to yield an answer that we actually did not intend to define. The (1980's) textbook way to solve this issue in this concrete case is to delay the unification of X and the third argument to occur only after the !/0:

max(X, Y, Z) :- X > Y, !, X = Z.

It is clear that nobody wants to write such code and that moreover, nobody wants to risk running into such unexpected problems, and we would therefore of course simply define, via a single clause:

max(X, Y, Z) :- Z #= max(X, Y).

and thus get a shorter and significantly more general definition, at least as we reason about integers, as is normally also the case.
In the case under discussion, "steadfastness" is, somewhat analogously, a guarantee that certain parts of the grammar rule are executed no matter the instantiation of arguments: We cannot "trick" the definition to yield unexpected results by instantiating parts of the query.

Steadfast in connection with DCG is defined in the DCG Draft.


Update targetModel in request body

I tested this by hard-coding(since we haven't integrated with LLMService CRD yet) a new targetModel different than the input and it worked.

Awesome!
/lgtm

/approve


feat: redux implementation pt. 1

This redux implementation includes:

models
actions
reducers
selectors

This is what our global app initial state currently looks like:

Areas of implementation (so far):

Signin and signout pages:

Once signed in, the userID and email used from firebase are dispatched to the store.
I added the redux_persist plugin so we don't lose the current state even when we reload and restart the app. The only time the store state resets to the initial state is when the user logs out of their account.

ViewProfile page
EditProfile page

So right now, the values are automatically saved in the global state as you edit the text fields/picker. Proper saving and deleting  are not yet implemented in this PR. I will need to integrate the backend database and redux together for that which will come in the next PR.

Note:
I got rid of dummy data for the ViewProfile page so if you'd like to test this PR, you'd have have to edit your own profile in the EditProfile page.

@HelenGezahegn I'll let your PRs (#95 and #94) be merged into master first so I can refactor this PR according to your changes


Create lsagent.sh

Lansweeper agent (LsAgent).

I have now added internal variables when this label is called. That makes it possible to install this fully automated. I have only tested with server, port, and mode. I expect that if agentkey is used, then server and port is not.

I like the idea, but cannot verify that it works without having valid values?


Add REST API

Just found a bug: After moving, the desk disconnects, so this is still too bugged.
In the end I know Python too little...


Side Inputs to beam.Partition

Side inputs work with a regular ParDo and function, but I can't seem to get it to work with beam.Partition. The code and exception below demonstrates the problem.
import apache_beam as beam

def main():

  class SideFn(beam.PartitionFn):
    def partition_for(self, element, *args, **kwargs):
      print(element, args, kwargs)

  def just_print(element, *args, **kwargs):
      print(element, args, kwargs)

  with beam.Pipeline() as p:
      side = p | 'CreateSide' \>\> beam.Create(['a'])
      p | beam.Create([1, 2, 3]) | beam.Partition(SideFn(), 99,  side=beam.pvalue.AsSingleton(side))
      - p | beam.Create([1, 2, 3]) | beam.ParDo(just_print, 99,  side=beam.pvalue.AsSingleton(side))

if __name__ \== '__main__':
    main()

/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/bin/python /Users/joetoth/projects/joetoth.com/psy/part.py
Traceback (most recent call last):
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/internal/util.py", line 134, in <genexpr>
(k, next(v_iter)) if isinstance(v, ArgumentPlaceholder) else (k, v) for k,
StopIteration
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "apache_beam/runners/common.py", line 1213, in apache_beam.runners.common.DoFnRunner.process
File "apache_beam/runners/common.py", line 742, in apache_beam.runners.common.PerWindowInvoker.invoke_process
File "apache_beam/runners/common.py", line 804, in apache_beam.runners.common.PerWindowInvoker._invoke_process_per_window
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/internal/util.py", line 133, in insert_values_in_args
new_kwargs = dict(
RuntimeError: generator raised StopIteration
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/joetoth/projects/joetoth.com/psy/part.py", line 19, in <module>
main()
File "/Users/joetoth/projects/joetoth.com/psy/part.py", line 14, in main
p | beam.Create([1, 2, 3]) | beam.Partition(SideFn(), 99,  side=beam.pvalue.AsSingleton(side))
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/pipeline.py", line 568, in exit
self.result = self.run()
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/pipeline.py", line 547, in run
return self.runner.run_pipeline(self, self._options)
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/direct/direct_runner.py", line 119, in run_pipeline
return runner.run_pipeline(pipeline, options)
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 175, in run_pipeline
self._latest_run_result = self.run_via_runner_api(
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 186, in run_via_runner_api
return self.run_stages(stage_context, stages)
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 344, in run_stages
stage_results = self._run_stage(
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 527, in _run_stage
last_result, deferred_inputs, fired_timers = self._run_bundle(
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 571, in _run_bundle
result, splits = bundle_manager.process_bundle(
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 852, in process_bundle
result_future = self._worker_handler.control_conn.push(process_bundle_req)
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/portability/fn_api_runner/worker_handlers.py", line 353, in push
response = self.worker.do_instruction(request)
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/worker/sdk_worker.py", line 483, in do_instruction
return getattr(self, request_type)(
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/worker/sdk_worker.py", line 519, in process_bundle
bundle_processor.process_bundle(instruction_id))
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/worker/bundle_processor.py", line 984, in process_bundle
input_op_by_transform_id[element.transform_id].process_encoded(
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/runners/worker/bundle_processor.py", line 221, in process_encoded
self.output(decoded_value)
File "apache_beam/runners/worker/operations.py", line 354, in apache_beam.runners.worker.operations.Operation.output
File "apache_beam/runners/worker/operations.py", line 356, in apache_beam.runners.worker.operations.Operation.output
File "apache_beam/runners/worker/operations.py", line 218, in apache_beam.runners.worker.operations.SingletonConsumerSet.receive
File "apache_beam/runners/worker/operations.py", line 703, in apache_beam.runners.worker.operations.DoOperation.process
File "apache_beam/runners/worker/operations.py", line 704, in apache_beam.runners.worker.operations.DoOperation.process
File "apache_beam/runners/common.py", line 1215, in apache_beam.runners.common.DoFnRunner.process
File "apache_beam/runners/common.py", line 1279, in apache_beam.runners.common.DoFnRunner._reraise_augmented
File "apache_beam/runners/common.py", line 1213, in apache_beam.runners.common.DoFnRunner.process
File "apache_beam/runners/common.py", line 569, in apache_beam.runners.common.SimpleInvoker.invoke_process
File "apache_beam/runners/common.py", line 1374, in apache_beam.runners.common._OutputProcessor.process_outputs
File "apache_beam/runners/worker/operations.py", line 218, in apache_beam.runners.worker.operations.SingletonConsumerSet.receive
File "apache_beam/runners/worker/operations.py", line 703, in apache_beam.runners.worker.operations.DoOperation.process
File "apache_beam/runners/worker/operations.py", line 704, in apache_beam.runners.worker.operations.DoOperation.process
File "apache_beam/runners/common.py", line 1215, in apache_beam.runners.common.DoFnRunner.process
File "apache_beam/runners/common.py", line 1279, in apache_beam.runners.common.DoFnRunner._reraise_augmented
File "apache_beam/runners/common.py", line 1213, in apache_beam.runners.common.DoFnRunner.process
File "apache_beam/runners/common.py", line 569, in apache_beam.runners.common.SimpleInvoker.invoke_process
File "apache_beam/runners/common.py", line 1374, in apache_beam.runners.common._OutputProcessor.process_outputs
File "apache_beam/runners/worker/operations.py", line 218, in apache_beam.runners.worker.operations.SingletonConsumerSet.receive
File "apache_beam/runners/worker/operations.py", line 703, in apache_beam.runners.worker.operations.DoOperation.process
File "apache_beam/runners/worker/operations.py", line 704, in apache_beam.runners.worker.operations.DoOperation.process
File "apache_beam/runners/common.py", line 1215, in apache_beam.runners.common.DoFnRunner.process
File "apache_beam/runners/common.py", line 1279, in apache_beam.runners.common.DoFnRunner._reraise_augmented
File "apache_beam/runners/common.py", line 1213, in apache_beam.runners.common.DoFnRunner.process
File "apache_beam/runners/common.py", line 569, in apache_beam.runners.common.SimpleInvoker.invoke_process
File "apache_beam/runners/common.py", line 1374, in apache_beam.runners.common._OutputProcessor.process_outputs
File "apache_beam/runners/worker/operations.py", line 218, in apache_beam.runners.worker.operations.SingletonConsumerSet.receive
File "apache_beam/runners/worker/operations.py", line 703, in apache_beam.runners.worker.operations.DoOperation.process
File "apache_beam/runners/worker/operations.py", line 704, in apache_beam.runners.worker.operations.DoOperation.process
File "apache_beam/runners/common.py", line 1215, in apache_beam.runners.common.DoFnRunner.process
File "apache_beam/runners/common.py", line 1294, in apache_beam.runners.common.DoFnRunner._reraise_augmented
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/future/utils/init.py", line 446, in raise_with_traceback
raise exc.with_traceback(traceback)
File "apache_beam/runners/common.py", line 1213, in apache_beam.runners.common.DoFnRunner.process
File "apache_beam/runners/common.py", line 742, in apache_beam.runners.common.PerWindowInvoker.invoke_process
File "apache_beam/runners/common.py", line 804, in apache_beam.runners.common.PerWindowInvoker._invoke_process_per_window
File "/Users/joetoth/.local/share/virtualenvs/joetoth.com-s5in2Toy/lib/python3.8/site-packages/apache_beam/internal/util.py", line 133, in insert_values_in_args
new_kwargs = dict(
RuntimeError: generator raised StopIteration [while running 'Partition(SideFn)/ParDo(ApplyPartitionFnFn)/ParDo(ApplyPartitionFnFn)']
Process finished with exit code 1
Imported from Jira BEAM-11158. Original Jira may contain additional context.
Reported by: weazelb0y.

I couldn't repro this. Tried:
import apache_beam as beam

def main():

  class SideFn(beam.PartitionFn):
    def partition_for(self, element, *args, **kwargs):
      print(element, args, kwargs)
      return 0

  def just_print(element, *args, **kwargs):
    print(element, args, kwargs)

  with beam.Pipeline() as p:
    side = p | 'CreateSide' >> beam.Create(['a'])
    p | beam.Create([1, 2, 3]) | beam.Partition(SideFn(), 99, side=beam.pvalue.AsSingleton(side))

    p | 'Create2' >> beam.Create([1, 2, 3]) | beam.ParDo(just_print, 99, side=beam.pvalue.AsSingleton(side))

if __name__ == '__main__':
  main()

python pipe.py
1 (99,) {'side': 'a'}
2 (99,) {'side': 'a'}
3 (99,) {'side': 'a'}
1 (99,) {'side': 'a'}
2 (99,) {'side': 'a'}
3 (99,) {'side': 'a'}


Implement set

Description
Add Set implementation
Related Issues
Closes #24
Checklist

[x] I have tested this code.
[x] I have reviewed the code changes.
[x] I have updated the documentation.
[x] This PR follows the coding standards.
[x] I have added tests for the changes.

I've implemented most of the methods I found on the List implementation. But as this is a Set implementation, what do you think of implementing some Set operations like:
Union(s1, s2) -> returns a new set as the union of both sets
Intersection(s1, s2) -> returns a new set with elements that exist in both sets
Disjunction(s1, s2) -> returns a new set with the elements that don't exists in both sets

Another thing: Considering this thread, as far as I understood, the capacity property on the map initializations don't guarantee it to be able to store as much as capacity elements without it being resized. So I omitted it from the Set initializations.
Let me know if you agree with that.

I've implemented most of the methods I found on the List implementation. But as this is a Set implementation, what do you think of implementing some Set operations like:
Union(s1, s2) -> returns a new set as the union of both sets Intersection(s1, s2) -> returns a new set with elements that exist in both sets Disjunction(s1, s2) -> returns a new set with the elements that don't exist in both sets

That's a great idea. But, let's not bring it into this issue. We can create a separate issue for that.

That's a great idea. But, let's not bring it into this issue. We can create a separate issue for that.

Got it. Feel free to also assign it to me :)


ValueError when attempting to use adapt method from TextVectorization layer

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Google Colab
TensorFlow installed from (source or binary): pip install tf-nightly
TensorFlow version (use command below): v1.12.1-32169-gf7d038cc3b 2.3.0-dev20200519
Python version: 3.6.9
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

Describe the current behavior
I've tried running the following two text classification guides:

https://keras.io/examples/nlp/text_classification_from_scratch/
https://keras.io/examples/nlp/pretrained_word_embeddings/

In each case, when I reach the call to the adapt  method, e.g. vectorizer.adapt(text_ds), the following error is raised:

/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/layers/preprocessing/index_lookup.py in set_vocabulary(self, vocab)
282           "Attempted to set a vocabulary larger than the maximum vocab size. "
283           "Passed vocab size is %s, max vocab size is %s." %
--> 284           (total_vocab_size, self.max_tokens))
285
286     start_index = num_special_tokens
ValueError: Attempted to set a vocabulary larger than the maximum vocab size. Passed vocab size is 20001, max vocab size is 20000

Describe the expected behavior
The error should not be raised.
Standalone code to reproduce the issue
from tensorflow.keras.layers.experimental.preprocessing import TextVectorization
import numpy as np

#define a set of docs as per https://machinelearningmastery.com/ example
docs = np.array(['Well done!',
		'Good work',
		'Great effort',
		'nice work',
		'Excellent!',
		'Weak',
		'Poor effort!',
		'not good',
		'poor work',
		'Could have done better.'])

vectorizer = TextVectorization(max_tokens=5, output_sequence_length=4)
text_ds = tf.data.Dataset.from_tensor_slices(docs)
vectorizer.adapt(text_ds)

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

ValueError                                Traceback (most recent call last)
 in ()
3 vectorizer = TextVectorization(max_tokens=5, output_sequence_length=4)
4 text_ds = tf.data.Dataset.from_tensor_slices(docs)
----> 5 vectorizer.adapt(text_ds)
4 frames
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/layers/preprocessing/text_vectorization.py in adapt(self, data, reset_state)
408           "adapt() requires a Dataset or an array as input, got {}".format(
409               type(data)))
--> 410     super(TextVectorization, self).adapt(preprocessed_inputs, reset_state)
411
412   def get_vocabulary(self):
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/base_preprocessing_layer.py in adapt(self, data, reset_state)
203
204     updates = self._combiner.extract(accumulator)
--> 205     self._set_state_variables(updates)
206
207   def _set_state_variables(self, updates):
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/layers/preprocessing/text_vectorization.py in _set_state_variables(self, updates)
521           updates[_OOV_IDF_NAME])
522     else:
--> 523       self.set_vocabulary(updates[_VOCAB_NAME])
524
525   def _preprocess(self, inputs):
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/layers/preprocessing/text_vectorization.py in set_vocabulary(self, vocab, df_data, oov_df_value)
471                           "called.").format(mode=self._output_mode))
472
--> 473     self._index_lookup_layer.set_vocabulary(vocab)
474
475     # When doing raw or integer output, we don't have a Vectorize layer to
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/layers/preprocessing/index_lookup.py in set_vocabulary(self, vocab)
282           "Attempted to set a vocabulary larger than the maximum vocab size. "
283           "Passed vocab size is %s, max vocab size is %s." %
--> 284           (total_vocab_size, self.max_tokens))
285
286     start_index = num_special_tokens
ValueError: Attempted to set a vocabulary larger than the maximum vocab size. Passed vocab size is 6, max vocab size is 5.

@gtjemwa
I think  tokens in docs is 17 in your example.Hence max tokens should be considered greater than 17 then you will not have this issue.Please, find the gist here.Thanks!

@ravikyram
Thanks for the response. Correct, setting max tokens to None or greater than number of unique words in the docs, everything does work. However, my understanding is that is I set a value for max_tokens, and the vocabulary is then determined by word frequency, with less frequently occurring tokens considered OOV.  This is the same approach in the demo example here https://keras.io/examples/nlp/text_classification_from_scratch, where the max_tokens is set to 20000, but we still get the same ValueError.

@gtjemwa I cannot reproduce the error. Am i missing something? Can you please check the gist here. Thanks!

@jvishnuvardhan
Looks like the error doesn't occur in 2.3.0-dev20200522 (it was on 2.3.0-dev20200519 that I was having the issue.
Thanks. I'll close this issue


Added stop feature for docker

I have read the CLA Document and I hereby sign the CLA

recheck

recheck

@alifiratari 👋
This PR looks very straightforward.
I will take a deeper look tonight and come back to you.
Thanks 🙏
__
  Summary: :hammer_and_wrench: This code needs a fix


iOS UnitTest Improvement: Networking

Platform
What platform is your issue or question related to? (Delete other platforms).

iOS

Issue
It came to our attention that during iOS unit testing, if a url to image or resources in general is used to get the resources, and if the resources is not available, the quality of unit testing can be degraded.
For example, if a resource is hosted by a third party, it's reasonable to assume that they may have a "rate limit" which is once hit, it can degrade unit testing experiences.
Currently there are two suggestions:

replace url via networking with url via local resources. eg. via resource resolvers.
replace third party url with ms owned url.

This is completed per the referenced PR. No networking calls in unit tests anymore.


hoodie.cleaner.commits.retained max value?

Is there a greatest value possible for the number of commits the hudi cleaner can retain?

What about the greatest possible value for hoodie.keep.min.commits and hoodie.keep.max.commits?

What is the difference between hoodie.cleaner.commits.retained and hoodie.keep.min.commits? If I understand correctly, the cleaner commits retained is the maximum number of commits we can query incrementally/point in time from, keep min commits is the least number of commits stored (for example in S3) and keep max commits is the maximum number of commits stored.

Are any commits between the keep min commits and keep max commits thresholds archived as log files?

Are any commits that exceed the max commit threshold deleted?

Are there performance issues if I set these values very large? For example:

hoodie.cleaner.commits.retained: 20000,   hoodie.keep.min.commits: 20001,   hoodie.keep.max.commits: 30000
Thanks in advance

@n3nash @bvaradar : can you folks help here.

@AkshayChan Please find my answers inline

Is there a greatest value possible for the number of commits the hudi cleaner can retain?

The num_commits is eventually converted to an integer, so you can pass Integer.MAX_VALUE. Although, that will increase the number of files on the .hoodie folder and eventually cause slowness due to file listing (if on S3)

What about the greatest possible value for hoodie.keep.min.commits and hoodie.keep.max.commits?

See above. Ideally, you want to set the value of hoodie.keep.min.commits to a lower value than hoodie.keep.max.commits. I've explained the meaning of all these configs below.

What is the difference between hoodie.cleaner.commits.retained and hoodie.keep.min.commits? If I understand correctly, the cleaner commits retained is the maximum number of commits we can query incrementally/point in time from, keep min commits is the least number of commits stored (for example in S3) and keep max commits is the maximum number of commits stored.

There are 2 different concepts at play here.
Hoodie Clean Process
The hoodie.cleaner.commits.retained is connected with the hoodie cleaner process that ensures all files belonging to X number of commits will be retained. Say, you set this value to 24. This means that MAX 24 versions of all files will be retained at any time. This is a rolling window. If there are 25 versions, the first version will be cleaned.
Hoodie Commit File Archiving Process
Hoodie creates metadata files under the .hoodie folder that tracks the kinds of actions happening on the table. These files ensure the ACID property that provides isolation between readers and writers. The configs hoodie.keep.min.commits and hoodie.keep.max.commits determine how many such metadata files will be kept under .hoodie folder. Since a large number of files under a folder can cause file listing slowness, hoodie employs an archival process that archives these metadata files to a LOG file to reduce the number of files under .hoodie folder. The  archival process works as follows
Check if number of commit files under metadata has reached hoodie.keep.max.commits, if yes, archive all commits files but keep hoodie.keep.min.commits number of files. Keep doing this operation repeatedly whenever conditions meet.
There is a relationship between the cleaner and archival. You need to keep the hoodie.cleaner.commits.retained <= hoodie.keep.min.commits

Are any commits between the keep min commits and keep max commits thresholds archived as log files?

Answered above.,

Are any commits that exceed the max commit threshold deleted?

All files are archived under the archived.log* file names, not deleted.

Are there performance issues if I set these values very large? For example:

hoodie.cleaner.commits.retained: 20000, hoodie.keep.min.commits: 20001, hoodie.keep.max.commits: 30000
Thanks in advance

Yes, if you are using S3, file listing can slow down if you set to a very large number (in the millions) and can also cause OOM.

@n3nash Thanks a lot for your response. So if I understand correctly, if hoodie.cleaner.commits.retained is set to 24 and we have 25 commits, we will be unable to see the 1st commit in Amazon Athena/S3/other query engines like Redshift Spectrum.
Will we also not be able to point-in-time/incrementally query this 1st commit through spark anymore? Thanks

Yes, that is correct @AkshayChan. Closing this ticket, please open one if you need further assistance

This thread is very helpful, this should end up in the documentation :)


testing issue feature

copy the error to here... include picture

Thanks, can confirm that it is working.


Amplify CLI doesn't support Federated Login

Do you want to request a feature or report a bug?
Bug.
What is the current behavior?
⠋ Initializing project in the cloud...An error occurred when creating the CloudFormation stack
✖ Root stack creation failed
init failed
{ InvalidClientTokenId: The security token included in the request is invalid.
    at Request.extractError (/Users/markw/.nvm/versions/node/v8.11.3/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/node_modules/aws-sdk/lib/protocol/query.js:47:29)
...
  message: 'The security token included in the request is invalid.',
  code: 'InvalidClientTokenId',
  time: 2018-08-28T09:13:08.644Z,

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Steps to reproduce the issue:

Log into a federated account and save your id/secret/token.
💥 🔥

What is the expected behavior?
Create a cloudformation stack.
Additional environment details
OSX 10.13.6 (17G65)

OS version (ie Windows 10 build X, macOS Sierra 10.12.6, etc.)
Output of amplify --version:

$ amplify --version
0.1.14

Did this work in previous versions?: Y/N

@wolfeidau We do support Federated login as a part of the auth category.
From the stack trace you provided, it seems like the AWS credentials you provided during the init/configure process was invalid and that's why this error -> InvalidClientTokenId: The security token included in the request is invalid.
Try running the amplify configure command to setup an IAM user for the CLI to use and then run the  amplify init command in your app and use that IAM user when prompted as a part of the init flow.

@kaustavghosh06 I log into AWS using a federated user, in my case using https://github.com/Versent/saml2aws. This means I have
[wolfeidau]
aws_access_key_id        = xxx
aws_secret_access_key    = xxx
aws_session_token        = xxx

We don't use IAM users in our accounts as they are a security issue, this is common practice for enterprise AWS customers.
AWS mobile has the same issue https://github.com/aws/awsmobile-cli/issues/150

@wolfeidau Got it. Are these credentials stored in your ~/.aws/credentials file. Have you signed an AWS SDK call with these credentials before? If yes, do you include just the session token as a part of signing the request or do you have to include the access key id, secret access key as well as the session token?

Also? Could you confirm that the federated user has policies set up for CloudFormation?

@kaustavghosh06 yeah we use these credentials with sam, a range of golang based tools built on the aws SDK and aws CLI.
TBH I was surprised it didn't work as very python or golang tool we used just worked.
This is based on https://aws.amazon.com/blogs/security/how-to-implement-federated-api-and-cli-access-using-saml-2-0-and-ad-fs/ posted a while back.

@wolfeidau  Got it. We'll be implementing this in the coming few days. Thanks for the feedback. I'm assigning a 'Work in progress' tag to this issue.

I had this problem using a federated identity. I configured Amplify to use a profile but it still uses the default configuration. I got it to work by copying the credentials from the profile into the default in ~/.aws/credentials. I don't think it is anything specific to federated identities.
Try copying your [wolfeidau] profile credentials into [default]

Published a new version of the CLI with a fix for this to npm -> 0.1.17. Please install it and feel free to re-open the issue if the problem still persists.

This appears to have regressed; at least with the same actions as OP described, I have the same expectation as OP had, but instead witness same results OP witnessed.

@wolfeidau We do support Federated login as a part of the auth category.
From the stack trace you provided, it seems like the AWS credentials you provided during the init/configure process was invalid and that's why this error -> InvalidClientTokenId: The security token included in the request is invalid.
Try running the amplify configure command to setup an IAM user for the CLI to use and then run the amplify init command in your app and use that IAM user when prompted as a part of the init flow.

That reply completely missed the point: we use federated users assuming designated IAM roles specifically to avoid creating IAM users. Creating IAM users is poor security practice, unless you also implement an external automation to enforce credential rotation. Using federated users permits delegation of credential policy enforcement to the federated IdP.

I had this problem using a federated identity. I configured Amplify to use a profile but it still uses the default configuration. I got it to work by copying the credentials from the profile into the default in ~/.aws/credentials. I don't think it is anything specific to federated identities.
Try copying your [wolfeidau] profile credentials into [default]

Moving credentials into the [default] profile had no effect, AFAICT.

From https://github.com/aws-amplify/amplify-cli/issues/407#issuecomment-443036004 comes the answer:

Note, you must manually add your profile into .aws/config, or amplify init won't use it.

This "requirement" is not enforced by many other AWS-published CLI. Creating the named profile in both .aws/config and .aws/credentials caused amplify init to prompt me whether to use a profile, and allowed me to select the profile containing credentials for the federated user.
So, although this is resolved, it indicates another, separate bug with this CLI.


No key file found for extension

Hi,
as someone else mentioned in this comment to #19, the installation of prebuilt .crx files in the data/extensions folder fails with:
No key file found for extension /path/to/autochrome/data/extensions/extension.crx

It would be nice to at least have a workaround for this described somewhere.

It seems like the only tiime the key is used is to write it into the manifest.json at lib/auto_chrome/chrome_extension.rb:22.
I'll try adding a check if the manifest.json already contains the key property in which case the .pub file might not be needed and will create a PR in case it works.

Closed, merged into #42


Support the graphblas.throw op

It'd be nice to do some runtime checks in our MLIR code.

For example, if we have a function taking in a tensor<?x?xf64, #CSR64> where the function assumes the input is square, it'd be nice to actually check that at runtime.
Another example is when we pass in an int32 tensor when the function expects a tensor<?x?xf64, #CSR64>. We'd just get a segfault and lose a lot of time debugging.

We could solve these problems with safety checks that use exceptions. Since I was unable to find any MLIR-specific exception throwing functionality, I think the solution is to implement our own graphblas.throw.

graphblas.throw would lower down to a call to an external C/C++ function that just throws some exception. The LLVM dialect supports global strings that we could use for error messages. Alternatively, we could make the error message a compile-time constant/op attribute.
Since sparse tensor support currently boils down to a bunch of function calls to external C/C++ functions, we're not doing anything less clean than what we're already doing.

In principle, this seems reasonable, but I'm worried / concerned that we won't be able actually catch these exceptions.  The mechanics of C++ exceptions are pretty complicated.  Can we do a quick test to check the feasibility of this?

OK, had a quick chat with Siu and it seems there are a number of reasons this won't work the way we want it to.  C++ exception are a bit fragile and magical, and not going to work across shared library boundaries.
The way a number of other languages (Rust, Go) handle this is forbid exceptions entirely and make operations that can fail return a tuple with a bool for success and the actual return value.  Then you can check the success flag and return if it fails.  CPython does a similar thing, but setting a global exception pointer with the Exception object.

Also, even aside from the stack unwinding issues, the other challenge with exceptions is memory management and leakage

I made partial progress on this ticket in https://github.com/paul-tqh-nguyen/mlir-graphblas/commit/32c23ad2a2c1ec15c947c8cca2ea195cc2bcd57a prior to reading the concerns mentioned in https://github.com/metagraph-dev/mlir-graphblas/issues/104#issuecomment-894459272. I don't think this is a waste of effort since these changes can be easily turned into a graphblas.comment op that we talked about but never implemented.


vscode download link is broken

VS Code Version: latest
OS Version: macOS Catalina 10.15.7
Browser: Chrome 89.0.4389.90
Country: South Korea

Steps to Reproduce:

Try download via link from https://code.visualstudio.com/download & via homebrew
Network timeout error occurs
(request url is https://az764295.vo.msecnd.net/stable/c185983a683d14c396952dd432459097bc7f757f/VSCode-darwin-universal.zip)

I'm trying to download vscode since last week but keep failed.
It seems like there's some issues with CDN.
If there's any recommendation to download the product before this problem is solved,
please let me know :)

Does this issue occur when all extensions are disabled?: N/A

Checked the referenced issue above, but couldn't figure out the solution since the issue creator's network seems somehow fixed itself. 🤔

Closing as temporary network failure.

It works! Thank you for checking :)


%node.word in Structure panel

Thank you so much for the plugin! With it making latte templates very much enjoyable!
Is it possible to show the 1st macro argument ( [^\s]+ for example ) in the Structure panel?
Now I see in "Structure" this list:
block
block
block
block
....

But it would be much more useful to see somethig like this:
block head
block TopScreen-logo
block TopScreen-header
block KeyBenefits
....

@SlavaAurim It is implemented in 1.0.1.


Chore: release and publish task

Author: @rbarilani
Ideally we should have a npm script that release and publish a new version with one command.
$ npm run release [major|minor|path]

Pre-review:

[ ] git checkout to new branch release/
[ ]  run tests
[ ]  bump package.json version
[ ]  build client assets
[ ]  generate changelog
[ ]  git add changes
[ ]  git commit changes
[ ]  git push changes
[ ]  manually open a PR against master (or also this step can be automated?)

After review:

[ ]  git add tag
[ ]  git push tag
[ ]  publish on npm

Ideally this task should run on a CI server but it should be possible to do that manually.

Author: @EduardoAC
Hi @rbarilani, I want to ask you about this issue in order to start working on it.
I understand the concept of one command release. However the pre-review steps I am not familiar with this kind of release system.

if you want to create a new release from master, shouldn't it be already upgraded it the package.json version already?
Why do you need the client assets on a PR? Couldn't you just generate then using prepublishOnly option?
The content of the changelog need to be from the last release, Should I need to identify from the last tag or do you have another syste,?

I am a bit green on releasing this way, but it's a good exercise to come back to releases from CD

Author: @rbarilani
Hi @EduardoAC thx for looking into this.

if you want to create a new release from master, shouldn't it be already upgraded it the package.json version already?

The release artifacts (changelog, bumped package.json, eventually compiled artifacts and so on) are produced on a specific release branch to be able to review before merging to master (at the point we really publish... add git tag and publish to npm)

Why do you need the client assets on a PR? Couldn't you just generate then using prepublishOnly option?

We can remove that when we are stable enough but I find it beneficial when you wanna test a release candidate in another project without publishing on npm so you can use a git reference instead of a version.

The content of the changelog need to be from the last release, Should I need to identify from the last tag or do you have another system?

I usually use this tool that do that for you: https://github.com/conventional-changelog/conventional-changelog

I am a bit green on releasing this way, but it's a good exercise to come back to releases from CD

This process should be available as manual or and preferred run on CI/CD servers.
@EduardoAC BTW Those steps or procedures or approaches are not written in the stone so I'm really open to alternative proposal and discussions.

@maxim-tschumak, thanks for your answer, I will have a look next week when I have a bit free time to prepare an small example so we can discuss further

@EduardoAC Any updates? :)

I propose to have a semi-automatic release process:

Creating a PR (bump version, adjust documentation and changelog)
Publishing is done manually (locally) after the PR is merged.

Hi @maxim-tschumak, i didn't work con this feature since i got a second project con The evenings. Sorry for no communicate this more effective

No problem @EduardoAC ! I'll take over this one.
There are a lot of open issues if you are interested :)


Feature request: allow searching contents of files

Before using Obsidian, I used Notational Velocity, nvAlt, and FSnotes. These programs were optimized with the same design: a single field is used both for creating notes and searching. When entering the title for a new note, it searched the full text of all notes at the same time, displaying the results below the search field. This functionality is similar to Obsidian's Quick Switcher exempt the latter does not search the contents of all notes, only their file names.
Does Another Quick Switcher support full text search in the contents of notes? (I tried it, but it seems this is not an option.) Why not?
Would it be difficult to add this functionality? If performance might be an issue, perhaps you can use mdfind or ripgrep internally to quickly search text content.

Hi, @quinncomendant :)

Does Another Quick Switcher support full text search in the contents of notes?

No.

Why not?

The reason for we can search the contents of all notes by the Search in all files command. I respect the ideology of Obsidian, therefore I'll not implement it for quick switcher UI.
Best regards.

I really like your plugin, this plugin is the one I use the most, but it's strange that every time I want to search the contents of a file, I have to switch the Search in all files command. It's a bit of a pain and I don't want to have to switch back and forth. I know you respect the ideology of Obsidian, but the plugin itself is giving another option. Whether you implement it or not, thank you very much for developing such a great plugin.

Just use the Omnisearch plugin, it's what we're looking for: a single field is used both for creating notes and searching. It's really good.

Ok, cool. Thank you.
On Sat, Oct 1, 2022 at 1:47 AM Quinn Comendant @.***>
wrote:

Just use the Omnisearch https://github.com/scambier/obsidian-omnisearch
plugin, it's what we're looking for: a single field is used both for
creating notes and searching. It's really good.
—
Reply to this email directly, view it on GitHub
https://github.com/tadashi-aikawa/obsidian-another-quick-switcher/issues/26#issuecomment-1263850129,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKNDLLHADTSB4CZ3MXT4BJ3WA4RUXANCNFSM5PN2UEIQ
.
You are receiving this because you commented.Message ID:
<tadashi-aikawa/obsidian-another-quick-switcher/issues/26/1263850129@
github.com>


Add Travis CI config

Experimental pull reques to try Travis CI as a build system replacement for Bitrise.

LGTM


Default install fails mysql login

Just tried this recently:
This is run from ubuntu 14, via vagrant so it was a clean install of mysql using the mysql role. /root/.my.cfg has root:root entry, and I can get in there with mysql -u root -p root
Deleting .my.cnf does not work
failed: [localhost] (item=DELETE FROM mysql.user WHERE User='root' AND Host NOT IN ('localhost', '<IP_ADDRESS>', '::1')) => {"changed": false, "cmd": ["mysql", "-NBe", "DELETE FROM mysql.user WHERE User='root' AND Host NOT IN ('localhost', '<IP_ADDRESS>', '::1')"], "delta": "0:00:00.005109", "end": "2017-01-20 04:08:58.633002", "failed": true, "item": "DELETE FROM mysql.user WHERE User='root' AND Host NOT IN ('localhost', '<IP_ADDRESS>', '::1')", "rc": 1, "start": "2017-01-20 04:08:58.627893", "stderr": "ERROR 1045 (28000): Access denied for user 'root'@'localhost' (using password: NO)", "stdout": "", "stdout_lines": [], "warnings": []}

ran a few more times, unclear what I did, but works now


can't install with npm install -g echpochmak

I'm submitting a ...
[X] bug report

Summary

I can't install it locally using npm install -g echpochmak. I've tried on two different Macs and one Windows computer.
As I can see, some /build/* files are missing in the npm package.
Probably, it is necessary to add some paths to the files section of package.json

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

% uname -a
Darwin FreeNet.local 19.6.0 Darwin Kernel Version 19.6.0: Thu Jun 18 20:49:00 PDT 2020; root:xnu-6153.141.1~1/RELEASE_X86_64 x86_64
% npm -v
6.14.7
% node -v
v14.8.0
% npm install -g echpochmak
npm WARN deprecated<EMAIL_ADDRESS>request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN rollback Rolling back<EMAIL_ADDRESS>failed (this is probably harmless): EINVAL: invalid argument, rmdir '/usr/local/lib/node_modules/echpochmak/node_modules/@bitauth/libauth/build/main/lib/vm/instruction-sets/bch/fixtures'
npm WARN<EMAIL_ADDRESS>requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.

npm ERR! code ENOENT
npm ERR! syscall chmod
npm ERR! path /usr/local/lib/node_modules/echpochmak/build/main/cli.js
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, chmod '/usr/local/lib/node_modules/echpochmak/build/main/cli.js'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR!      /Users/alex/.npm/_logs/2020-11-29T14_05_31_741Z-debug.log

The detailed 2020-11-29T14_05_31_741Z-debug.log is attached.

@asnov  Thanks for the feedback, I fixed it


[FLINK-31506][table] Move execution logic of AlterOperation out from TableEnvironmentImpl

The PR continues the work started at https://github.com/apache/flink/pull/22175
This PR does this for AlterOperation.
What is the purpose of the change
Migrate AlterOperations to extend ExecutableOperation and move it's execution logic  out from TableEnvironmentImpl.
Brief change log
Migrate AlterOperations to extend ExecutableOperation and move it's execution logic  out from TableEnvironmentImpl.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
The S3 file system connector: ( no )

Documentation

Does this pull request introduce a new feature? ( no)
If yes, how is the feature documented? (not applicable)

LGTM. Feel free to merge it once conflict resolved and CI is passed.

Thanks for having a look


Sort markers chronologically by timecode

Sort markers chronologically by timecode in CSV output.
This seems like an obvious improvement.
In future it could be possible to add a CLI argument to specify sorting behavior. However chronological sort is the most common and the most logical default.

Implemented on refactor branch.


implement cursor like UI in the app playground ($100 bounty)

resizable components
chat history
shortcuts
shortcut to use "no context" vs "all codebase" (e.g. LLM makes function call to screenpipe like cursor)
basic foundational code to use @ and # to get specific context from screenpipe (because the UX is unclear yet, feel free to just write some basic code for this, doesn't have to work yet) (basic thought is that you can use #tags like in obsidian somehow, and @ like @today @john, very unclear atm how to use this)
small dropdown to switch model effortlessly
bonus: be creative on the model output markdown parsing (for example when cursor answers with links you can click and it shows the file, atm we do this for .mp4 files, we tell the model that it can render video by using `absolutepath.mp4`)

rules:

use same dependency that we use (shadcn, magicui, tailwind, framer-motion)
use typescript
in general aim for quality of code like https://github.com/vercel/ai-chatbot

how to work on app:
cd examples/apps/screenpipe-app-tauri
bun i
bun tauri dev

/bounty 100

/bounty 100

/attempt #219

@louis030195 can i get it assigned so that i can start working on it?


[ISSUE #6748]Optimize NettyRemotingAbstract#writeResponse log print

Which Issue(s) This PR Fixes

Fixes #6748
Brief Description

Optimize NettyRemotingAbstract#writeResponse log print

How Did You Test This Change?

Codecov Report

Merging #6750 (ecb07ff) into develop (9d411cf) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6750      +/-   ##
=============================================
- Coverage      42.85%   42.83%   -0.03%
+ Complexity      9002     8997       -5
=============================================
  Files           1113     1113
  Lines          78615    78613       -2
  Branches       10229    10229
=============================================
- Hits           33692    33673      -19
- Misses         40701    40706       +5
- Partials        4222     4234      +12

Impacted Files
Coverage Δ

...rocketmq/remoting/netty/NettyRemotingAbstract.java
51.29% <0.00%> (-0.64%)
:arrow_down:

... and 20 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Adds ability for Reese to make Crystal stuff

Description:

Adds ability for Reese to sing Crystal items for the player (at a 50% shard markup)
Matches OSRS behavior and cost

Changes:
Adds ability for players with the quest points but not high enough skills to make:

Blade of saeldor (inactive) - 150 shards (+50)
Blade of saeldor (c) - 1400 shards

Reese fee is 500 shards, and you get credit for existing charges, making 900 + 500 = 1400.

Bow of faerdhinen (inactive) 150 shards
Bow of faerdhinen (c) - 1900 shards

Reese fee is 1000 shards, but you get credit for the first 100 shards when making inactive, so 1900 total.

Crystal axe/pickaxe/harpoon - 180 shards (+60)
Enhanced crystal key - 15 shards (+5)

(SotE skill requirements are enforced)
Other checks:

[x] I have tested all my changes thoroughly.

This is in OSRS, but someone else can re-do it if they want it.
Maybe add to the /sell command, like wyson


devilutionx: fix build dependency on SDL2

Motivation for this change
This fixes broken build of devilutionx, which was caused by removing static build of SDL2. Explanation can be found here.
Also, I've added the flag BINARY_RELEASE=ON"to CMake build, which among other things greatly reduces the size of the  executable.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Upstream requires a static SDL2?

I'm not a C/C++ developer, so it's a bit hard for me to know. There is a notion of dynamic SDL2 here, but only for windows AFAIK.
I just managed to make it work with some local upstream changes in their CMakeLists.txt. I'll create an upstream PR and see what happens.
I'm closing this PR for now. Thank you @aanderse for your help!


Package interface is not compatible with original org.json.*

My project uses both this package and Google Firebase. As the result I have this error:
java.lang.NoSuchMethodError: org.json.JSONStringer.object()Lorg/json/JSONWriter;
at com.google.firebase.database.util.JsonMapper.serializeJsonValue(JsonMapper.java:56)
at com.google.firebase.database.util.JsonMapper.serializeJsonValue(JsonMapper.java:45)
at com.google.firebase.database.util.JsonMapper.serializeJson(JsonMapper.java:25)
at com.google.firebase.database.util.GAuthToken.serializeToString(GAuthToken.java:53)
at com.google.firebase.database.core.JvmAuthTokenProvider$1.onComplete(JvmAuthTokenProvider.java:40)
at com.google.firebase.tasks.OnCompleteCompletionListener$1.run(OnCompleteCompletionListener.java:37)
Reason: Google libraries uses one library and Wicket uses another by the same name. These 2 libraries are in conflict.
I would suggest to have 100% compatible API with the latest version of the original package or change package name.
https://search.maven.org/#artifactdetails|com.google.firebase|firebase-server-sdk|3.0.3|jar

Can you suggest what semantics and API points you want?
There isn't an actual specification available and I don't want to
compromise the clean-room status of open json.
Test cases would be very helpful.
On Tue, Feb 28, 2017 at 3:37 AM, Mikhail Fursov<EMAIL_ADDRESS>wrote:

My project uses both this package and Google Firebase. As the result I
have this error:
java.lang.NoSuchMethodError: org.json.JSONStringer.object()
Lorg/json/JSONWriter;
at com.google.firebase.database.util.JsonMapper.
serializeJsonValue(JsonMapper.java:56)
at com.google.firebase.database.util.JsonMapper.
serializeJsonValue(JsonMapper.java:45)
at com.google.firebase.database.util.JsonMapper.serializeJson(
JsonMapper.java:25)
at com.google.firebase.database.util.GAuthToken.
serializeToString(GAuthToken.java:53)
at com.google.firebase.database.core.JvmAuthTokenProvider$1.onComplete(
JvmAuthTokenProvider.java:40)
at com.google.firebase.tasks.OnCompleteCompletionListener$1.run(
OnCompleteCompletionListener.java:37)
Reason: Google libraries uses one library and Wicket uses another by the
same name. These 2 libraries are in conflict.
I would suggest to have 100% compatible API or do not use the same package
name.
https://search.maven.org/#artifactdetails|com.google.
firebase%7Cfirebase-server-sdk%7C3.0.3%7Cjar
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tdunning/open-json/issues/11, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSegkmorxymoJm6tVdf6NLh1uz9XU8ks5rg5ZfgaJpZM4MN7fN
.

@tdunning I think the real problem is that OpenJson uses org.json as package name. This way it clashes badly with Douglas Crockford's JSON library.
Some projects (like Wicket) bring OpenJson as dependency, others (like Google Firebase) bring the old JSON library. At the end the JVM picks the class (e.g. JSONObject) from the one that is earlier in the constructed classpath.
IMO in the long run it would be safer if OpenJson changes its package name to org.openjson or something like that.

Well, the point here is to completely replace the Crockford's library since
he refuses to release it under an open source license.
As such, exactly emulating the API to the degree that could be discerned
was necessary because Wicket had a deadline to remove the original org.json
library. If you care about your code being open source and distributable,
then you might want to consider dependency surgery to get Firebase to not
use the problematic dependency.
If you can specify what functionality that would require, then I am happy
to look at implementing it.
I am a little surprised that Firebase uses Crockford's non-open library,
however, since Google did a clean-room re-implementation (that I used as a
base) for Android.
On Tue, Feb 28, 2017 at 8:42 AM, Martin Grigorov<EMAIL_ADDRESS>wrote:

@tdunning https://github.com/tdunning I think the real problem is that
OpenJson uses org.json as package name. This way it clashes badly with
Douglas Crockford's JSON library.
Some projects (like Wicket) bring OpenJson as dependency, others (like
Google Firebase) bring the old JSON library. At the end the JVM picks the
class (e.g. JSONObject) from the one that is earlier in the constructed
classpath.
IMO in the long run it would be safer if OpenJson changes its package name
to org.openjson or something like that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tdunning/open-json/issues/11#issuecomment-282977598,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSepeOXHXMUmRBPHTkU8WdFHyrGBpWks5rg93zgaJpZM4MN7fN
.

I support Martin that using unique package name is the best solution.
Reasons:

The 'old' library has multiple releases. The latest is dated by 2016. For some people this project is alive: https://search.maven.org/#search|gav|1|g%3A"org.codeartisans" AND a%3A"org.json"

There are 1000+ projects that relies on old code: https://mvnrepository.com/artifact/org.json/json
Having any of them in classpath may cause runtime (not compile time) issues.

It is actually a big work to support all methods from 'org.json'. It also includes XML support :)

That may well be, but the point of open JSON is to provide a temporary
plug compatible replacement for projects like wicket or hadoop who need to
get rid of the old library immediately.
Over the longer term, switching to Jackson is the right thing to do. Open
JSON is not a long-term solution.
So, I repeat my limited offer. If you have a limited addition to the API, I
am happy to help. Changing the package name, however, is off the table
because it conflicts with the primary goal.
On Feb 28, 2017 6:41 AM, "Mikhail Fursov"<EMAIL_ADDRESS>wrote:

I support Martin that using unique package name is the best solution.
Reasons:

The 'old' library has multiple releases. The latest is dated by 2016.
For some people this project is alive: https://search.maven.org/#
search%7Cgav%7C1%7Cg%3A%22org.codeartisans%22%20AND%20a%3A%
22org.json%22
https://search.maven.org/#search|gav|1|g%3A"org.codeartisans" AND a%3A"org.json"
There are 1000+ projects that relies on old code:
https://mvnrepository.com/artifact/org.json/json
https://mvnrepository.com/artifact/org.json/json
Having any of them in classpath may cause runtime (not compile time)
issues.
It is actually a big work to support all methods from 'org.json'. It
also includes XML support :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tdunning/open-json/issues/11#issuecomment-283056647,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSek-1x1--jA8K2SF1wFYia0THgNVsks5rhDIBgaJpZM4MN7fN
.

If the primary goal is to get rid of old code why package name is so important?
In Wicket, for example, the package name today is not org.json but org.apache.wicket.ajax.json.
Another example could be: when Sun included Xerces into JDK - they changed the package name for the same reason: to avoid conflicts.
About 'limited addition to API':  you either 100% compatible or not. 1000+ projects in Maven depends on original features of json.org. Some of them from Google, some from Spring, some from Apache. Why to have this problem at all?
Missing any of class, method, constant, code behavior is a hidden bug that will reveal itself in runtime.

Here is jardiff report.
changes.html.zip

I would like to come up with an alternative solution:
Maybe additional branch like 2.0 can be created and will have 2.X.X version and different package name
So users willing to use simple fully open library can switch to 2.x.x once
Others can use 1.x.x with old name as "short term" solution
WDYT?

I would definitely like this project and contribute to it. I'm a happy user of 'JSONObject' library for many years.  This library has a lot of benefits for me when compared to other solutions: it's simple, it has smaller jar size, it has no dependencies, it has better performance than Jackson (checked for parsing 4mb json files).
I do not like original https://github.com/stleary/JSON-java copy because it has no LinkedHashMap inside JSONObject and the maintainer of the library refuses  to accept any related fixes, however 3rd party datasets I depend upon relies on ordering in JSON to optimize data size. So Wicket impl was perfect for me and I would definitely contribute to another version that follows the same rules.
BTW, Hi Max :) Long time no see!

just for fun:  below are benchmark results for this package vs org.json:
(benchmark origin: https://github.com/RichardHightower/json-parsers-benchmark)
Benchmark                                Mode Thr     Count  Sec         Mean

i.g.j.s.OrgJsonBenchmark.actionLabel    thrpt   8         3    1   409515.806
i.g.j.s.OpenjsonBenchmark.actionLabel   thrpt   8         3    1   860833.050

i.g.j.s.OrgJsonBenchmark.citmCatalog    thrpt   8         3    1      280.911
i.g.j.s.OpenjsonBenchmark.citmCatalog   thrpt   8         3    1      508.311

i.g.j.s.OrgJsonBenchmark.medium         thrpt   8         3    1   176217.306
i.g.j.s.OpenjsonBenchmark.medium        thrpt   8         3    1   605602.511

i.g.j.s.OrgJsonBenchmark.menu           thrpt   8         3    1  1425624.972
i.g.j.s.OpenjsonBenchmark.menu          thrpt   8         3    1  2547549.411

i.g.j.s.OrgJsonBenchmark.sgml           thrpt   8         3    1   628004.661
i.g.j.s.OpenjsonBenchmark.sgml          thrpt   8         3    1  1447232.944

i.g.j.s.OrgJsonBenchmark.small          thrpt   8         3    1  8125230.083
i.g.j.s.OpenjsonBenchmark.small         thrpt   8         3    1 11046816.617

i.g.j.s.OrgJsonBenchmark.webxml         thrpt   8         3    1   106045.972
i.g.j.s.OpenjsonBenchmark.webxml        thrpt   8         3    1   337826.061

i.g.j.s.OrgJsonBenchmark.widget         thrpt   8         3    1   401139.761
i.g.j.s.OpenjsonBenchmark.widget        thrpt   8         3    1   911970.478

Another candidate to switch to OpenJson: Apache Tapestry.
I will cross link the issues so they are aware of our current findings.
https://issues.apache.org/jira/browse/TAP5-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897115#comment-15897115

@martin-g should I move wicketstuff projects to com.github.openjson?
@mfursov  I see lots of commits :) when are you planning first release?

Max,
All these commits are tests only. I see no reasons for any new release until some real issues fixed.
Originally I thought the package should be 100% compatible with original 'org.json' and started implementing missed parts, but later removed all these changes: I understood and appreciated the way the package was minified. Really good job.
So, 'com.github.openjson' package is 100% the same as this package now.
I'm going to add missed tests, want to make github to understand the licence correctly (some external tools like 'versioneye' depends on it) - but all these are infrastructure related changes only, not API.

Why I'm asking: Wicket is now in Milestone period (8.0.0-M4), and all major changes are only allowed in this period
So I guess it might worth to release this artifact with new coordinates, so wicket can receive updates after 8.0.0 will be finalized ...

But it was released at the moment of fork:
https://search.maven.org/#search|ga|1|openjson
and is used by Wicket:
https://github.com/apache/wicket/commit/f25687ade198b8e9dedf91d120c7f0d3ec0f1039
Did I miss something here?

It seems I missed all the changes, sorry for the noise :( (was on mountain skiing session for a while)
OK, going to check wicketstuff and perform necessary changes
Thanks for the pointers

Hi,
I am a bit confused. Where does the release now comes from:
<dependency>
   <groupId>com.github.openjson</groupId>
   <artifactId>openjson</artifactId>
   <version>1.0.0</version>
   <type>jar</type>
</dependency>

I didn't see any changes in this repository. May I missed something.

Ah now I see its this fork:
https://github.com/openjson/openjson
I would suggest to release one branch that is able to exchange the json.org lib as @tdunning mentioned and one branch that uses a new package names. This could be released separately and you could decide which to use:
<dependency>
   <groupId>com.github.openjson</groupId>
   <artifactId>openjson-json-org-replacement</artifactId>
   <version>1.0.0</version>
   <type>jar</type>
</dependency>
<dependency>
   <groupId>com.github.openjson</groupId>
   <artifactId>openjson</artifactId>
   <version>1.0.0</version>
   <type>jar</type>
</dependency>

@klopfdreh I don't understand your suggestion. Please give more details!

I think that the suggestion is to release two versions of the library, one
with good package hygiene and one with package name collision.
On Wed, Mar 22, 2017 at 11:33 PM, Martin Grigorov<EMAIL_ADDRESS>wrote:

@klopfdreh https://github.com/klopfdreh I don't understand your
suggestion. Please give more details!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tdunning/open-json/issues/11#issuecomment-288629647,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSeqEFhnUJxkuFhykLcEItUJZoPSknks5rohJSgaJpZM4MN7fN
.

Exactly.

This library's naming causes issues in larger projects with multiple dependencies and sub-dependencies. It is not a 100% compatible version with the "org.json" as maintained now at https://github.com/stleary
(there are several issues I've noticed - especially with automatic conversion of collections into json objects and arrays along with XML conversion capabilities)
While I'm speaking from hindsight, it was a significant mistake to duplicate the org.json package name.  Replacing package names within a Java project is a very straightforward task with little cost.  Projects who wanted to use this implementation should have been forced to incur that cost.  Instead, I had to hunt down a problem because the Tika implementation group decided to use this library.

Hello @slankas,
this was temporary solution, finally package name was changed: https://github.com/openjson/openjson
I can contact Apache Tika and propose this little refactoring as a PR :)

Look, you can say whatever you want about significant mistakes. But you
weren't there. You didn't make a library to solve an excellent problem. In
fact, of you are cataloging errors, I would count NOT implementing anything
when it was needed as a larger mistake.
Also, this is open source. You don't like it, fix it. To want a different
path, fork it. Please.
But don't go second guessing someone who took action when action was
needed. Remember also, this library was a stopgap measure intended as an
emergency way to buy time. To should be switching to a real library for
json.
On Oct 26, 2017 4:08 PM, "slankas"<EMAIL_ADDRESS>wrote:
This library's naming causes issues in larger projects with multiple
dependencies and sub-dependencies. It is not a 100% compatible version with
the "org.json" as maintained now at https://github.com/stleary
(there are several issues I've noticed - especially with automatic
conversion of collections into json objects and arrays along with XML
conversion capabilities)
While I'm speaking from hindsight, it was a significant mistake to
duplicate the org.json package name. Replacing package names within a Java
project is a very straightforward task with little cost. Projects who
wanted to use this implementation should have been forced to incur that
cost. Instead, I had to hunt down a problem because the Tika implementation
group decided to use this library.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tdunning/open-json/issues/11#issuecomment-339826108,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSeiiQJBQ9p3ME9kgWmGsbeHh-EhAjks5swRDcgaJpZM4MN7fN
.

@solomax Thank you.  The movement to the openjson package name and avoiding the conflicts was definitely needed.  I still disagree with maintaining the org.json duplication - that will continue to raise conflicts.  Unfortunately, there are 10 libraries within Maven that have picked up this particular implementation.  (https://mvnrepository.com/artifact/com.tdunning/json/usages).  I don't think it appropriate for you to contact the Tika team.  To @tdunning 's point, if I don't like, I should fix it.
@tdunning I stand by my criticism.  The continued use of the org.json package name will continue to cause conflicts.  My solution would be to shut this project down.  Direct others to the new package name.   I will make a suggestion(through an issue and will provided text in a fork) to @stleary to add commentary on his readme for those looking for an open-source version that avoid's Crockford's licensing issue to use the https://github.com/openjson/openjson implementation. I do appreciate the work you've put int this project.  Performing a clean-room implementation of an in existing API is not insignificant.

@mfursov, @tdunning, all :)
what can be done here, we can release new version of this library with following pom modification:
<distributionManagement>
    <relocation>
        <groupId>com.github.openjson</groupId>
        <artifactId>openjson</artifactId>
        <version>1.0.8</version>
    </relocation>
</distributionManagement>

as it is done here http://central.maven.org/maven2/xml-apis/xml-apis/2.0.2/xml-apis-2.0.2.pom
This will result: http://mvnrepository.com/artifact/xml-apis/xml-apis/2.0.2
I guess this way all users will be notified they need to move to the correct version
WDYT?

maxim,
I don't think I quite understand the specifics of what you are suggestion
and who you are asking.
Who is "we" in "we can release".
Are you suggesting that the github.com/openjson project release a new
version?  Or that I release a new version?
Or are you suggesting that "this library" that should be released is
xml-apis and you are talking about making a release of that with a new
dependency?
I am happy to help. Just a bit too confused to do so.
On Thu, Oct 26, 2017 at 8:15 PM, Maxim Solodovnik<EMAIL_ADDRESS>wrote:

@mfursov https://github.com/mfursov, @tdunning
https://github.com/tdunning, all :)
what can be done here, we can release new version of this library with
following pom modification:

com.github.openjson
openjson
1.0.8

as it is done here http://central.maven.org/maven2/xml-apis/xml-apis/2.0.
2/xml-apis-2.0.2.pom
This will result: http://mvnrepository.com/artifact/xml-apis/xml-apis/2.
0.2
I guess this way all users will be notified they need to move to the
correct version
WDYT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tdunning/open-json/issues/11#issuecomment-339861171,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSevDkgzWwSRidrYNaT9Uc0z3X0T5Xks5swUq0gaJpZM4MN7fN
.

Sorry for not being clear, English is not my native language :(
According to @slankas post
users of com.tdunning:json library might not be aware of existence of com.github.openjson:openjson library.
Also I believe com.github.openjson:openjson should be drop-in replacement for com.tdunning:json.
Maybe this need to be written to the

README.md
pom.xml relocation section

Since changes in pom.xml will be visible only after release I propose to release new version of com.tdunning:json with relocation coordinates
xml-apis was just an example of how this will look for the end user of the library :)
I'm using "we" in "we can release" since I have contributed to this library and feel involved :))

Inline
On Oct 27, 2017 8:18 PM, "Maxim Solodovnik"<EMAIL_ADDRESS>wrote:
Sorry for not being clear, English is not my native language :(
I would not have known. Many a native speaker is less clear.
According to @slankas https://github.com/slankas post
users of com.tdunning:json library might not be aware of existence of
com.github.openjson:openjson library.
Good point. They should be told.
Also I believe com.github.openjson:openjson should be drop-in replacement
for com.tdunning:json.
I don't think this can happen. They have changed the package names at
least. Also they are making changes going forward to make the alternative
better as they see it.
Maybe this need to be written to the

README.md

For sure. Pull requests welcome.

pom.xml relocation section

Hmm. Seems difficult because of packages at least. Surely redirection
should be at the option of the downstream users.
...
I'm using "we" in "we can release" since I have contributed to this library
and feel involved :))
And welcome. Thank you for that!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tdunning/open-json/issues/11#issuecomment-340135599,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSeqw3qE9ZQmtCBEtvrXGXp2DVcYxCks5swp0XgaJpZM4MN7fN
.


Add golangci checks

Add golangci checks

Pull Request Test Coverage Report for Build 116

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.454%

Totals

Change from base Build 113:
0.0%

Covered Lines:
514

Relevant Lines:
762

💛  - Coveralls


Nicknames with spaces

I just upgraded to 0.22 (coming from 0.20.2) and new in this version is that one of my slack bots now uses a different name, probably the visible name or so.
This name contains a space, therefore the PRIVMSG command now is as follows:
Activity Feed!Program Activity Feed@Program Activity Feed PRIVMSG #ourchannel :Text
This is ofcourse no longer valid IRC so my irssi is failing on this.  As per usual, detailled logs are available on irc, /query me

mattermost? slack?

mattermost? slack?

hm strange, slack wasn't touched between 0.20.2 and 0.22 so if you go back to 0.20.2 it still works?

hm strange, slack wasn't touched between 0.20.2 and 0.22 so if you go back to 0.20.2 it still works?

should be fixed by #374

should be fixed by #374


Support Merkleized Metadata

RFC-0078 Merkelized Metadata proposes to include a metadata hash in the extrinsic signature to improve trust in the protocol:
https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html

PR to provide this feature: https://github.com/polkadot-fellows/runtimes/pull/337
Subxt is discussing whether to support this: https://github.com/paritytech/subxt/issues/1586
The feature was activated on Kusama: https://kusama.subsquare.io/referenda/406

Open questions

Why did we not detect this in our builds?

The docker image we use for testing (paritypr/substrate:latest) is 10 months old. This seems a bit outdated

https://hub.docker.com/layers/paritypr/substrate/latest/images/sha256-a4e5fc063bee26dce1f8feb998712111be71b130118148fad1efc75d371bf97c?context=explore
Also see https://github.com/paritytech/polkadot-sdk/issues/4789
After some digging I found out that this is indeed the reason why we did not notice this breaking change. Testing with other docker images I get the following results

paritypr/substrate:master-ae864e6a broken
paritypr/substrate:8dbe4ee8 broken
paritypr/substrate:master-eda98954 works
paritypr/substrate:master-ad54bc36 works
Commit 8dbe4ee8 introduced the CheckMetadataHash extension

https://github.com/paritytech/polkadot-sdk/commit/8dbe4ee80734bba6644c7e5f879a363ce7c0a19f

Could this be improved in the future?

I created a new issue #778  for the up-to-date images

Link to Code of Parity: https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/metadata-hash-extension/src/lib.rs#L105


matched errors should not change the build status

If the invoked build tool returns with a code of 0 the error matching should not change the build result to failed. If this doesn't seem reasonable as a default there should be an option to switch the behavior.

This was actually added in #144 . I suppose an option to control this is in order.

I commonly trust by build tools return code more then the regular expression which might match if the output e.g. "by accident" contains a certain string. It would be great there would be an option for this to choose the desired behavior.

fixed in #224


update packages

:x: Build TheIdServer 3.0.4-fix-dependencies1-0032 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/fc64388fce by @)

:x: Build TheIdServer 3.0.4-fix-dependencies.1+32.build.1515 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/fc64388fce by @)

:white_check_mark: Build TheIdServer 3.0.4-fix-dependencies.1+32.build.1517 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/ca7d5a95cd by @)


Investigate common Logger interface

Can we abstract away having folks use slf4j-api? Is it necessary?

https://github.com/Azure/autorest-clientruntime-for-java/issues/557

Perhaps this is now considered a duplicate of #3466? @conniey can you confirm or deny?

Yup. It looks like there is a  common serviceLogger now.


Update how-to-identify-required-appliances.md

Updated max protected devices to 10K for "prod" appliances
Ariel Saghiv, Defender for IoT PM team

@arielsaghiv : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Created pull request 82169 instead - to include VM max protected devices


I cant play music

When i try to play music i get this:

I get this in LavaLink

Any idea why?

Lavalink issue, should now be resolved as of the latest build of PartyBot.


[C] Separate clocks in to separate compilcation unit (aeron_clock.{c,…

…h}).  Remove all function pointer indirection to aeron_clock_func_t (and remove typedef).  Add aeron_stub_clock.{c,h} and use it within tests via a link time ordering to override the production clock implementation.
This is initially here for comment and will follow up this with changes to use the cached clocks in various places.

Doesn't quite work with MacOS.  May come back to this implementation later.


Bitmanipulation C++

Have you read the Contributing Guidelines on Pull Requests?
YES
Description
Added Clear ith set bit code
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[ ] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#5311

Sir I am not pushing Kadane Algo file . It was my old PR which got merged and now it is coming when I am making new PR


Added zend-expressive-tooling to dev requirements

To ship the expressive-module tool out-of-the-box. Required upping the minimum requirement for zend-component-installer to ^0.7.
Fixes #134

Still working, as I think this should likely only be enabled for modular skeletons at this time; updating the installer to do so.


Add default for User-Agent HTTP header

and fix code that sets default headers when creating the client.
Fixes #94.
cc/ @ferdi2005

Thanks, now it’s perfect.👍

Coverage increased (+0.007%) to 94.254% when pulling 99b0dc959043b2ba9c53f328a817bf828cea94ab on feature/default-user-agent into<PHONE_NUMBER>d8d0831a73a8781d4cb266229399dc on develop.


Convert overlay peer updates to use protobuf

Signed-off-by: Jana Radhakrishnan<EMAIL_ADDRESS>

LGTM


Add<EMAIL_ADDRESS>

name: 🎉 New Feature
about: Add php uuid extension
labels: enhancement

Related issue: https://github.com/shivammathur/homebrew-extensions/issues/2426
Description
Add php uuid extension

Added in #2436


adding behavior to include spanlinks in start span in parametric apps

Motivation

Changes

Workflow

⚠ Create your PR as draft ⚠
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist

[ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
[ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
[ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
[ ] A docker base image is modified?

[ ] the relevant build-XXX-image label is present

[ ] A scenario is added (or removed)?

[ ] Get a review from R&P team

We are migrating the tests that this change would be used in to weblog, so this addition is no longer needed


Colossus access

Access to the Spirit temple should also display the desert colossus.

This seems to be working if Spirit is accessible from the front but not if it's only accessible from Twinrova.

I added that in too now.


docker-compose.yaml missing from v0.7.1

Is this a request for help?: No

Is this a BUG REPORT or a FEATURE REQUEST? (choose one): BUG REPORT
Version of Anchore Engine and Anchore CLI if applicable: v0.7.1
What happened: The mentionned docker-compose.yaml file from the documentation https://docs.anchore.com/current/docs/engine/engine_installation/docker_compose/#step-2-copy-configuration-files is missing from the latest v0.7.1 docker image. It is present in v0.7.0
What did you expect to happen:
Have the doc and the image matching toghether
Any relevant log output from /var/log/anchore: N/A
What docker images are you using:

docker.io/anchore/anchore-engine:v0.7.1 / latest
docker.io/anchore/anchore-engine:v0.7.0

How to reproduce the issue:
# docker run -it --rm --name ae docker.io/anchore/anchore-engine:v0.7.1 ls /
analysis_scratch  anchore_service  boot    dev			 etc   lib    licenses	  media  opt   root  sbin  sys	usr  workspace
anchore-engine	  bin		   config  docker-entrypoint.sh  home  lib64  lost+found  mnt	 proc  run   srv   tmp	var

# docker run -it --rm --name ae docker.io/anchore/anchore-engine:v0.7.0 ls /
analysis_scratch  anchore_service  boot    dev			    docker-compose.yaml   etc	lib    licenses    media  opt	root  sbin  sys  usr  workspace
anchore-engine	  bin		   config  docker-compose-dev.yaml  docker-entrypoint.sh  home	lib64  lost+found  mnt	  proc	run   srv   tmp  var

Hi @kumy sorry for the confusion, but this is a docs issue. The docker-compose file you're looking for is in the quickstart at: https://docs.anchore.com/current/docs/engine/quickstart. I'll update the older install page to point to the quickstart. We've stopped putting the compose file in the image so that it can be updated between releases without having to build new images.

Closing this since the docs are updated to refer to the quickstart guide now which has the proper instructions.


(PBI #123) Add new paragraph to landing page

:star: PR built and available in a preview environment david-ford-optimisemedia-jenkins-test-1-pr-2 here


Request for an option to show level of sensitivity in logs

When I enable debug logs, noticed secret key is masked but not the Access key. Some do consider access key is also sensitive at least for us.
Would like an option/flag to specify the level of sensitivity in the logs. Such as "private", "personal", and "public". Private would be hide passwords. Personal would mean hide user names, access keys, etc. Public means do not hide anything.
As discussed with @akutz opening an issue request for this. It will be a nice to have feature, especially when we have to share logs across.
Thanks
Lax

Issue moved to codedellemc/rexray #953 via ZenHub


Set-CertificateExtension issue with inexistent OID.Format() method

Hello,
There is a new bug since v3.3 in the Set-CertificateExtension function. 3 times in this function you are calling an inexistent Format() method on the OID objects.
This result in the try/catch to be triggered and the whole function to be exited, which is not good when we have more than 1 extension to set at once

This method exists as .NET extension method. This syntax would work in c#, but must be called differently in PowerShell.