fix: if there is a symbol '?' in the path, force url. query as the mi…

…metype

What this PR does / why we need it:
When our HTTP based model download path contains the symbol '?', the subsequent string will be parsed into a query, causing the mimetype to be unable to obtain the correct Content Type, resulting in errors in the entire model download process.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3013
Type of changes
Please delete options that are not relevant.

[√] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Pass the test for both the presence and absence of the symbol '?' in the HTTP path
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A
Model download path：'http://<IP_ADDRESS>:9999/00000123.zip'
[ ] Test B
Model download path：'http://<IP_ADDRESS>:32372/modelservice/model/download?path=bluewhale/model/74/00000123.zip'
Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[√] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Thanks @Wercurial !
/lgtm
/approve


How Can We Disable Authentication Popup when We launch url.

Hi Team,
Can you please suggest how we can disable Ulr Popup when we launch url in safari browser.
Thanks,
Venkata.

Hi!
You could authenticate via the url to hide the authentication flow.
Open the page like this: http://username:passowrd@localhost:8080/project/

Hi!
You could authenticate via the url to hide the authentication flow.
Open the page like this: http://username:passowrd@localhost:8080/project/


New Parser and Analyzer support materialized view related statements【Easy】

Requirement Description
The new Parser and the new Analyzer support the related statements of materialized views
Mentor
@HangyuanLiu
Registration procedure
Step 1. Add a comment when you sign up. The comment can be a brief self-introduction and reason for signing up, including what you do, what you're good at, what you're interested in and your technology stack, and how familiar you are with StarRocks. Example:

I pick! My name is Johnny. I am from StarRocks, and I have been working on database kernel development for 1 year. I am interested in OLAP, good at C++ programming, and have been using StarRocks for 6 months. I chose to solve this issue because I am familiar with execution engine.

Step 2. On your WeChat, add the StarRocks community assistant "StarRocks-1" as a WeChat friend and leave your GitHub ID. The assistant will invite you to a WeChat group based on the issue you picked.
Step 3. The mentor will communicate with all the participants who picked this issue and assign the task to the best match.
Before you start

Read the StarRocks GitHub workflow carefully, which provides the configurations of BE and FE and describes how to submit a pull request.
To learn more about StarRocks, read StarRocks documentation.

Pull request requirements

After you complete code development, upload the code to the StarRocks code repo as a pull request (PR).

PR title format: [SR GeekCamp] + PR title
Labels ：[Geek Camp 2022/feature]

After you submit your PR, comment on the status of your PR submission as requested under the Pinned Issue [StarRocks geek Camp 2022] page.

Comment format: "I have finished Issue #" + PR link id

I pick! My name is zhang dong,I have been working on database kernel development for 1 year.  I am interested in OLAP, I am good at Java programming, and I have been using StarRocks for 4 months.I chose to solve this issue because  I'm interested in materialized views。

I pick! My name is Xuqing Chai. I am a postgraduate student from BUPT. I have been learning on database kernel development for 1 year.  I have studied CMU 15-445 and MIT6.824, and I have read most of the source code of LevelDB. I'm currently studying CMU15-712, the main content of this course is reading VLDB papers. I am interested in OLAP, good at C++ programming, but have been using StarRocks. I chose to solve this issue because I want to contribute for StarRocks.

I pick! My name is Liujing. I am from Beike. I am interested in OLAP, good at Java programming, and have been using StarRocks for 6 months. I chose to solve this issue because I am interested in materialized views for StarRocks.


retdec-decompiler.py: error: the following arguments are required: FILE

The retdec\bin directory is already in my windows env path.
I am using retdec-offline plugin for binary ninja, upon decompilation the plugin generated the following command line for retdec-decompiler.py :
retdec-decompiler.py --backend-no-debug-comments --cleanup --mode raw --raw-section-vma 0x43e52d --raw-entry-point 0x43e52d --arch x86 --endian little --config C:\Users\nameless\AppData\Local\Temp\tmpf5bjocmg C:\Users\nameless\AppData\Local\Temp\tmpursu763x

But no matter what i have done, retdec always failed to seek the FILE or tmpursu763x
retdec-decompiler.py: error: the following arguments are required: FILE

The generated config file and the target file attached :
FILE.zip
What could be wrong?
[EDIT]
Adding python complete path into the command line is make it work :
"C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\python.exe" C:\Users\nameless\Documents\Tools\Retdec\bin\retdec-decompiler.py --backend-no-debug-comments --cleanup --mode raw --raw-section-vma 0x43e52d --raw-entry-point 0x43e52d --arch x86 --endian little --config C:\Users\nameless\AppData\Local\Temp\tmpf5bjocmg C:\Users\nameless\AppData\Local\Temp\tmpursu763x

On *.py i have set it to use C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\python.exe

Found out the solution is to put or hard-coded the python path and put the hardcoded "retdec-decompiler.py" path, is there any plan to make retdec-decompiler.py understand it's own relative-path?

Hi. This seems to be an issue in retdec-offline (a 3rd-party project that we have no affiliation with). As you can see in our README, the way to run RetDec on Windows is by specifying the path to the retdec-decompiler.py script:
python $RETDEC_INSTALL_DIR/bin/retdec-decompiler.py test.exe

Specifying the full path to python.exe should not be necessary (unless it is not reachable from your system's PATH).
As for the following question:

Is there any plan to make retdec-decompiler.py understand it's own relative-path?

Can you please elaborate what do you mean by "understand it's own relative path"?

@s3rvac
What i have meant is running retdec without hardcoding the full retdec-decompiler.py path by adding the retdec bin directory into environment variable.

What i have meant is running retdec without hardcoding the full retdec-decompiler.py path by adding the retdec bin directory into environment variable.

On Windows, this can be achieved as follows:

Add the path to retdec\bin into your system's PATH.
Open a new instance of cmd.exe.
Run retdec-decompiler.py. If Windows ask you by which application you want to open the script, select your Python installation.

After this, you should be able to run just retdec-decompiler.py (i.e. without python in front) from the command line instead of via python path\to\retdec\bin\retdec-decompiler.py.
Please note that running python retdec-decompiler.py on Windows will only work if you are in the bin directory (see below).
Also, please note that since this is a retdec repository, I am only talking about retdec, not about retdec-offline, as I do not know anything about retdec-offline.

Currently even i am moving my position in the windows command prompt into retdec bin directory, it's still required to use the retdec-decompiler.py full path.

This is not necessary. I have just tried that in Windows 7 and it works:
# Open cmd.exe
cd path\to\retdec\bin
python retdec-decompiler.py --help
retdec-decompiler.py --help

The last two commands correctly print the help. Can you please elaborate on why is it still required to use a full path for you? Maybe you are doing something differently than I and we misunderstand each other.
Please, let me know if this has answered your questions.

Closing due to inactivity. If the issue persists, please re-open (but please read the above comment and give us your feedback on it).


Feature Suggestion: Suggestion Mode for Intellisense by Default

Visual Studio currently always starts with Intellisense in completion mode:
If a completion popup is open and you finish typing (by whitespace or punctuation) a word that is not in the completion list, it will automatically complete/change to the best match from the completion list.
The alternative is suggestion mode, where the unrecognised word will remain, while completions are only applied by tab and optionally return.
The reasons for using suggestions mode could be:

The classic problem with autocorrect: When you mistype an identifier and it might get corrected to a different one. That wrong identifier is much harder to notice than a syntax error from non-existent identifier.
When you write code top-down you might want to write a statement with an identifier that doesn't exist yet.

The suggestion is an option to activate suggestion mode on startup. I assume this is possible to implement in an extension?
Developer Community suggestion: https://developercommunity.visualstudio.com/idea/838256/allow-toggling-between-suggestion-mode-or-completi.html

Since this will be in-box in 16.10 I guess this should be closed? Or do you plan to add it before the 16.10 release or for people who can't upgrade (yet)?
Preview release notes: https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes-preview#16.10.0.pre.1.0

Good point. I'll close it


Unit tests for AuthorRepository

Worked on unit tests for AuthorRepository while tracking test coverage through Coverlet. Achieved a line coverage of 100% and a branch coverage of 89.4% for AuthorRepository

With these test you accomplish, lack of coverage we demolish


Can we add a button to print the document similar to the download button

Can we have a an option to have a print button..just like the download button..we can place the print button next to the download button.
We can pass it as props whether we want to see a print button or not.
@mattmogford-alcumus @mattmogford @alcumus-itinfrastructure

Hi, this wouldn't be one for Infra so leave it with Matt.
Cheers
Scott


Add RegExp recursion depth limit

The regexp engine does not have any recursion depth check, thus it can cause problems with various regexps. Added a new build option --regexp-recursion-limit N whose
default value is 1000. For unlimited recursion depth use 0.
Also added a build-option-test for the unlimited recursion depth.
Fixes #2448
JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos<EMAIL_ADDRESS>

IMHO this limit should be applied to re_parse_alternative in re-compile.c also.

@zherczeg @LaszloLango I've applied the first version of the patch and updated the PR.

@LaszloLango @zherczeg @akosthekiss I've updated the PR.

@imiklos ping. @rerobika has suggested some reasonable changes, please apply them (except where commented otherwise).

@akosthekiss @rerobika Thank you! I've fixed the typos, style issues and updated the PR.


Merge https://github.com/okfn/licenses with this repo ...

Update. April 2015

We probably aren't going to actually merge licenses repo itself.
What we do want to do is merge the API / UI from licenses repo / licenses.opendefinition.org to here

though even here there is an argument to leave stuff in licenses and migrate web stuff to gh-pages

licenses repo will then slim down to being data only

TODO: work out what we to migrate here and what not
Original proposal
Source https://github.com/okfn/licenses
Merge process:

licenses => api/1/
bin/ => scripts/
js + index.html => api/

updated description with current proposal as to what happens

Can I suggest a simple solution to provide a machine-readable list of open licences and urls as this issue seems stalled...
Publish the licences as a CSV by OKI on datahub.io. If it's published as a CSV, then an API is generated.
In fact someone published the data as JSON on datahub.io  in the past but hasn't maintained it.

@Stephen-Gates basically yes! The main thing to complete actually right now is https://github.com/okfn/licenses/issues/45 - let's get the licenses repo fixed and then we can publish straight into datahub.io as you suggest.

Ok I'll look into it over the weekend

So we now have an up-to-date licenses.csv and datapackage.json being checked by goodtables.
To nudge this work (and the related issue) along, here's my suggestion...
Open Licenses Service

becomes an exemplar data package:

licenses.csv (continuously validated)
datapackage.json (follows versioning pattern)
readme.md

contains scripts to:

keep licenses.csv up-to-date
convert licenses.csv to multiple formats (json, jsonp, rdf) and into groups  if required to avoid breaking changes
publish the data package to datahub.io

has a githhub readme focused on using the data
full set of community files to assist with contributions
all other content removed

Open Definition site

Licence approval process is updated to reflect that licenses.csv is updated as a result of the review process
Filtered views of licenses.csv are shown on :

Recommended conformant licenses
Other conformant licenses
Non-conformant Licenses

This would result in some loss of information e.g. the BY, SA and Comments columns in the existing tables. This may result in adding columns to licences.csv.
Licences.csv changes
Consider changes to licenses.csv to:

Add BY, SA and Comments columns from the existing tables in Open Definition.
Add icon attribute to licenses #5
Add uri to licenses #6
define the family field, and the similar licenses #54
Add a description for each field in the datapackage.json schema #64

but be careful to communicate, or avoid, breaking changes.
Next Steps

determine what changes are required to support presenting filtered views of licenses.csv on the Open Definition site
make those changes
update the Open Definition site
consider the remaining suggestions

Thoughts?

I'd rather have the data package derived from:

SPDX (this is where the most concentrated effort to curate info about licenses is, a shame to not leverage that)
Open Definition (adding individual license records as Jekyll collection there would be one way to do it; I feel that we need to uplevel documentation around approval and making a CSV canonical would go opposite direction)
Wikidata

Derived probably means a script to collect info from those sources and shove into a CSV or whatever data packages want.
That said feel free to proceed as I don't know when I'll get around to fleshing out above.

@mlinksva @Stephen-Gates this sounds good - i'm happy for Stephen to proceed with Mike's guidance.


Validation error with multipart/form-data and object type property

Description
My spec looks like this:
openapi: 3.0.3
info:
  title: LIQUID Dataset Service
  version: 1.0.0
paths:
  /foo:
    post:
      x-openapi-router-controller: liquid_dataset_service.controllers.dataset_controller
      operationId: create_bar
      requestBody:
        required: true
        content:
          multipart/form-data:
            schema:
              type: object
              properties:
                bar:
                  type: object
                  properties:
                    baz:
                      type: string
              required:
                - bar
      responses:
          204:
              description: No Content

I use multipart/form-data and try to pass bar which is of type object.
I run this request with curl (same issue from the Swagger page):
curl -X 'POST' \
  'http://<IP_ADDRESS>:8080/api/v1/foo' \
  -H 'accept: application/json' \
  -H 'Content-Type: multipart/form-data' \
  -F 'bar={
  "baz": "string"
}'

Expected behaviour
The object bar is passed as a dict to the bar parameter of my controller function.
Actual behaviour
Server raises error: Validation error: '{\r\n  "baz": "string"\r\n}' is not of type 'object' - 'bar'
Steps to reproduce
Create a controller function, e.g.:
def create_bar(body):
    return

Adjust property x-openapi-router-controller accordingly.
Fire up the swagger page or use curl to run the request.
Additional info:
Output of the commands:

python --version: Python 3.11.6
pip show connexion | grep "^Version\:": Version: 3.0.5

My bad, forgot to set the encoding for bar  to application/json:
openapi: 3.0.3
info:
  title: LIQUID Dataset Service
  version: 1.0.0
paths:
  /foo:
    post:
      x-openapi-router-controller: liquid_dataset_service.controllers.dataset_controller
      operationId: create_bar
      requestBody:
        required: true
        content:
          multipart/form-data:
            schema:
              type: object
              properties:
                bar:
                  type: object
                  properties:
                    baz:
                      type: string
              required:
                - bar
            encoding:
              bar:
                contentType: application/json
      responses:
        204:
          description: No Content


Conditional inclusion does not work on

Already sent @tabatkins an email but filing it here too for tracking.
Trying to generate a version of our design principles for web developers, we tried this:

Title: Web Platform Design Principles
Group: tag
...

Title: Web Platform Design Principles for Web Developers

but the second block of metadata seems to always be overriding the first.

Gentle ping @tabatkins . We are considering using another preprocessor to generate Bikeshed if this cannot be fixed…


Set up translation service infrastructure

Set up the infrastructure to allow the use of the translation service https://www.transifex.com/.
It seems like the only integration provided by Transifex that could help in the case of this project is the Github Integration, which seems to support translations in a .json file

reopening, this is still pending.

@zackkrida even this is done, so we can close this.


multiple problems: params.dh, private.key, duplicate fullchain_with_key.pem.

Hello,
puppet6.example.com - puppet (ACME) master
reflect.example.com - puppet client
After our initial installation, we got the following error message on the master:

puppet6.example.com puppet-agent[13881]: Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Could not find resource 'File[/etc/acme.sh/configs/reflect.example.com/params.dh]' in parameter 'require' (file: /etc/puppetlabs/code/environments/puppet6/site-modules/acme/manifests/deploy/crt.pp, line: 97) on node puppet6.example.com
puppet6.example.com puppet-agent[13881]: (/Stage[main]/Acme/Acme::Request::Crt[reflect.example.com]/Acme::Deploy::Crt[reflect.example.com]/Concat[/etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem]/Concat_file[/etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem]) Failed to generate additional resources using 'eval_generate': Could not retrieve source(s) /etc/acme.sh/keys/reflect.example.com/private.key

params.dh as far as I understand should only be on the node itself (not on the master).  The same goes for private.key.  With the way source code is written right now, puppet is expecting both files to on both - master and node and is looking for /etc/acme.sh/keys/reflect.example.com/private.key, which of course doesn't exist on the master.
I added the following lines in deploy/crt.pp, which fixed that problem.

if $::hostname == 'puppet6' {
      $dh = "${cfg_dir}/puppet6.example.com/params.dh"
      $key = "${key_dir}/puppet6.example.com/private.key"
      $crt_full_chain_with_key = "${key_dir}/puppet.example.com/fullchain_with_key.pem"
}
else {
      $dh = "${cfg_dir}/${domain}/params.dh"
      $key = "${key_dir}/${domain}/private.key"
      $crt_full_chain_with_key = "${key_dir}/${domain}/fullchain_with_key.pem"
}

At this point I am experiencing the following issue:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Concat[/etc/acme.sh/keys/puppet.example.com/fullchain_with_key.pem] is already declared at (file: /etc/puppetlabs/code/environments/puppet6/site-modules/acme/manifests/deploy/crt.pp, line: 78); cannot redeclare (file: /etc/puppetlabs/code/environments/puppet6/site-modules/acme/manifests/deploy/crt.pp, line: 78) (file: /etc/puppetlabs/code/environments/puppet6/site-modules/acme/manifests/deploy/crt.pp, line: 78, column: 3) (file: /etc/puppetlabs/code/environments/puppet6/site-modules/acme/manifests/request/crt.pp, line: 32) on node puppet6.example.com

I have tried a couple of things, but none of them work 100% as often times fullchain_with_key.pem doesn't get distributed at all.
I would really appreciate your help on this matter.
Thank you!

puppet6.example.com - puppet (ACME) master
reflect.example.com - puppet client

Please provide the Puppet manifests (or hiera config) that you are using on your puppet master and puppet client.

Thank you.
$ cat reflect.pp

defines profile to request acme certificate
class profiles::acme::reflect {
include ::acme

$fqdn = downcase($::fqdn);

::acme::certificate { $::fqdn:
        use_profile    => 'nsupdate',
        dh_param_size  => 2048,
        acme_host      => 'puppet6.example.com',
        use_account    =><EMAIL_ADDRESS>        letsencrypt_ca => 'staging';
}

$ cat master.pp

#defines profile for acme master
class profiles::acme::master {
class { 'acme':
  accounts =><EMAIL_ADDRESS>  profiles => {
    nsupdate => {
      challengetype => 'dns-01',
      hook          => 'nsupdate',
      env           => {
        'NSUPDATE_SERVER' => 'dns1.example.com'
      },
      options       => {
        dnssleep        => 5,
        nsupdate_id     => 'acme-update',
        nsupdate_type   => 'hmac-sha512',
        challenge_alias => '_acme.example.com',
        nsupdate_key    => 'mykey',
      }
    }
  }
}

}

There is a chance I created a duplicate error message myself with my configuration, but I just started fresh and still getting error message after my second run on master:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Could not find resource 'File[/etc/acme.sh/configs/reflect.example.com/params.dh]' in parameter 'require' (file: /etc/puppetlabs/code/environments/puppet6/site-modules/acme/manifests/deploy/crt.pp, line: 104) on node puppet6.example.com

I was able to comment out this require, which fixed above problem.
Now next one:
Error:
Why puppet master is looking for fullchain_with_key.pem from a client?

/Stage[main]/Acme/Acme::Request::Crt[reflect.example.com]/Acme::Deploy::Crt[reflect.example.com]/Concat[/etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem]/File[/etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem]/ensure: change from 'absent' to 'file' failed: Could not set 'file' on ensure: No such file or directory @ rb_sysopen - /etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem

I was able to comment out this require, which fixed above problem.

I'm not going to analyze this further with modified sources. I'll look into the root problem and try to reproduce it first.

Ok thank you.
I think... it's resolved by specifying a hostname as opposed to $::fqdn

::acme::certificate { $::fqdn:

changed to

::acme::certificate { 'reflect.example.com':

Please let me know what you think and thank you for your help.

I take my words back.  It's still not working.  Thank you.

Error: /Stage[main]/Acme/Acme::Request::Crt[reflect.example.com]/Acme::Deploy::Crt[reflect.example.com]/Concat[/etc/acme.sh/certs/reflect.example.com/fullchain.pem]/Concat_file[/etc/acme.sh/certs/reflect.example.com/fullchain.pem]: Failed to generate additional resources using 'eval_generate': Could not retrieve source(s) /etc/acme.sh/configs/reflect.example.com/params.dh
Error: /Stage[main]/Acme/Acme::Request::Crt[reflect.example.com]/Acme::Deploy::Crt[reflect.example.com]/Concat[/etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem]/Concat_file[/etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem]: Failed to generate additional resources using 'eval_generate': Could not retrieve source(s) /etc/acme.sh/keys/reflect.example.com/private.key
Error: Could not set 'file' on ensure: No such file or directory @ rb_sysopen - /etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem
Error: Could not set 'file' on ensure: No such file or directory @ rb_sysopen - /etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem
Wrapped exception:
No such file or directory @ rb_sysopen - /etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem
Error: /Stage[main]/Acme/Acme::Request::Crt[reflect.example.com]/Acme::Deploy::Crt[reflect.example.com]/Concat[/etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem]/File[/etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem]/ensure: change from 'absent' to 'file' failed: Could not set 'file' on ensure: No such file or directory @ rb_sysopen - /etc/acme.sh/keys/reflect.example.com/fullchain_with_key.pem

@advorkin I was unable to reproduce this issue. Are you sure that you are using the latest version of this module? A duplicate declaration error was fixed back in december (#20).

For reference, this is the configuration I was using in a test environment.
Puppetserver 6.7.1
Puppet Agent 6.10.1
Config on Puppetserver:
acme::manage_packages: false
acme::letsencrypt_ca: 'staging'
acme::accounts:
  -<EMAIL_ADDRESS>acme::profiles:
  'variomedia':
    challengetype: 'dns-01'
    hook: 'variomedia'
    env:
      VARIOMEDIA_API: 'secret'
    options:
      dnssleep: 120

Config on client:
acme::manage_packages: false
acme::certificates:
  '%{::fqdn}':
    use_profile: 'variomedia'
    use_account<EMAIL_ADDRESS>    letsencrypt_ca: 'staging'

No errors with this configuration and puppet-acme version 1.0.4.

Yes, I am definitely using the latest version.  Duplicate issue was due to my "fix", which was wrong.
My issue is that master (puppet6) looks for private.key and fullchain_with_key.pem on master for an agent (reflect), which shouldn't be the case.  Should keys be stored in /certs on master for an agent as well?

My issue is that master (puppet6) looks for private.key and fullchain_with_key.pem on master for an agent (reflect), which shouldn't be the case.

True. And I have no idea how this should happen. Like I said, I cannot reproduce it. Verify that you run only the required code on your master and that PupeptDB is properly setup.

Should keys be stored in /certs on master for an agent as well?

No, as pointed out in the README:

Keep your private keys safe on the host they belong to and let your Puppet Server sign the CSRs and distribute the certificates.

Thank you.  But certificates are being copied there by the module.  I don't copy them myself.

But certificates are being copied there by the module. I don't copy them myself.

Well, what? o.O

I don't copy certs into /certs directory or any other directories on the master.  Everything is done by the master.  If you'd like, I can include the logs.

Ah, you are talking about keys, not certs.

If you'd like, I can include the logs.

Sure. Cleanup all old traces first and start over. Then please provide the full output of a Puppet Run on your master. Ensure that you don't run your profiles::acme::reflect class on the master.

root@puppet6 /tmp $ ls -la /etc/acme.sh/certs/
total 16
drwxr-xr-x. 4 acme acme 4096 Mar 30 09:50 .
drwxr-xr-x. 9 acme acme 4096 Jan 27 08:40 ..
drwxr-xr-x. 2 acme acme 4096 Mar 30 09:12 puppet6.example.com
drwxr-xr-x. 2 acme acme 4096 Mar 30 09:50 reflect.example.com
root@puppet6 /tmp $ ls -la /etc/acme.sh/certs/*
/etc/acme.sh/certs/puppet6.example.com:
total 36
drwxr-xr-x. 2 acme acme 4096 Mar 30 09:12 .
drwxr-xr-x. 4 acme acme 4096 Mar 30 09:50 ..
-rw-r--r--. 1 root acme 1029 Jan 27 08:40 cert.csr
-rw-r--r--. 1 root acme  488 Mar 27 13:03 cert.ocsp
-rw-r--r--. 1 root acme 1919 Mar 27 13:03 cert.pem
-rw-r--r--. 1 root acme 1678 Jan 27 11:29 chain.pem
-rw-r--r--. 1 root acme 4021 Mar 30 09:12 fullchain.pem
-rw-r-----. 1 root acme 5696 Mar 23 16:47 fullchain_with_key.pem
/etc/acme.sh/certs/reflect.example.com:
total 20
drwxr-xr-x. 2 acme acme 4096 Mar 30 09:50 .
drwxr-xr-x. 4 acme acme 4096 Mar 30 09:50 ..
-rw-r--r--. 1 acme acme 1919 Mar 30 09:50 cert.pem
-rw-r--r--. 1 acme acme 1680 Mar 30 09:50 chain.pem
-rw-r--r--. 1 acme acme 3599 Mar 30 09:50 fullchain.pem
puppetacme_1strun.txt
puppetacme_2ndrun.txt

Thank you very much for your help.  Please let me know if you need any additional info.

My puppet master has two profiles: master and client (NOT reflect).  I am attaching client below.  It's using $::fqdn, NOT reflect.example.com.
class profiles::acme::client {
include ::acme

$fqdn = downcase($::fqdn);

::acme::certificate { $::fqdn:
        use_profile    => 'nsupdate',
        dh_param_size  => 2048,
        acme_host      => 'puppet6.example.com',
        use_account    =><EMAIL_ADDRESS>        letsencrypt_ca => 'staging';
}

From acme.log
[Mon Mar 30 10:50:25 EDT 2020] Installing cert to:/etc/acme.sh/certs/reflect.example.com/cert.pem
[Mon Mar 30 10:50:25 EDT 2020] Installing CA to:/etc/acme.sh/certs/reflect.example.com/chain.pem
[Mon Mar 30 10:50:25 EDT 2020] Installing full chain to:/etc/acme.sh/certs/reflect.example.com/fullchain.pem

I had to reboot the server (master) and after it was done, no more problems it seems... Please ignore my ticket in the meantime as I am not sure what happened.  I'm sorry for all the trouble.  I will close it for now.  Stay safe and wish you all the best.

@advorkin Please test https://github.com/fraenki/puppet-acme/commit/312f4b05301da75a2e3ea6cc876b26d378739006, it should fix your issue.

Thank you!  I will test it out and let you know.

  Puppet master does not get its own certs and keys.

root@puppet6 /etc/acme.sh/results $ ls
reflect.example.com reflect.example.com reflect.example.com

If I add the client's profile to puppet master roles (in order to create certs and keys on master):

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Could not find resource 'File[/etc/acme.sh/configs/reflect.example.com/params.dh]' in parameter 'require' (file: /etc/puppetlabs/code/environments/puppet6/site-modules/acme/manifests/deploy/crt.pp, line: 97) on node puppet6.example.com

So the issue starts when puppet master wants to be a client as well.  If it only serves OTHER clients, $::acme_crts gets set properly and everything works as expected in both versions of your code.  Your new code did not make a difference, I am sorry.

Debug: Facter: fact "acme_crts" has resolved to "reflect.example.com".

So the issue starts when puppet master wants to be a client as well. If it only serves OTHER clients, $::acme_crts gets set properly and everything works as expected in both versions of your code.

The new code does exactly solve this issue. I was able to reproduce your issue and verify the fix multiple times.
I assume you're still not using the new code, maybe the old code is still cached by your Puppetserver.

Okay, I will try again later tonight to make sure and will double check everything.
Should puppet master be getting a client profile?

I've tried again with the same result.
As soon as I add client profile, I get an error message.
Again, this is what my client profile looks like:
$ cat profiles/manifests/acme/client.pp
# defines profile to request acme certificate
#defines the puppetmaster6 role

class profiles::acme::client {

    include ::acme

    $fqdn = downcase($::fqdn);

    ::acme::certificate { $::fqdn:
            use_profile    => 'nsupdate',
            dh_param_size  => 2048,
            acme_host      => 'puppet6.example.com',
            use_account    =><EMAIL_ADDRESS>            letsencrypt_ca => 'staging';
    }

I've made sure to clear the cache and checked on the master under correct environment.
My role for puppet master.  Could I be missing something that it fixed your installation?
$ cat roles/manifests/puppetmaster6.pp
#defines the puppetmaster6 role
class roles::puppetmaster6 {
    .......
    include profiles::acme::master
    include profiles::acme::client
}

Temporary solution is to actually first add puppet6 with client profile (so to get all keys and certs).  Then to remove the client profile from puppet master roles and add reflect.example.com and whatever other clients are necessary.    Hope I am making sense :)

Until now all examples were incomplete and I had to figure out how to reproduce your issue myself. That was rather time consuming for me.
I have to ask you to provide a complete, self contained example configuration that allows me to reliably reproduce this issue. I will not use your profile code to reproduce this issue. The examples should be pure Puppet manifests (and/or Hiera data), similar to the examples provided in the README.

$ cat roles/manifests/puppetmaster6.pp
#defines the puppetmaster6 role
class roles::puppetmaster6 {
   .......
    include profiles::acme::master
    include profiles::acme::client
}

$ cat profiles/manifests/acme/master.pp
#defines profile for acme master

class profiles::acme::master {

    class { 'acme':
      accounts =><EMAIL_ADDRESS>      profiles => {
        nsupdate => {
          challengetype => 'dns-01',
          hook          => 'nsupdate',
          env           => {
            'NSUPDATE_SERVER' => 'dns1.example.com'
          },
          options       => {
            dnssleep        => 5,
            nsupdate_id     => 'acme-update',
            nsupdate_type   => 'hmac-sha512',
            challenge_alias => '_acme.example.com',
            nsupdate_key    => 'secret',
          }
        }
      }
    }
}

$ cat profiles/manifests/acme/client.pp
# defines profile to request acme certificate

class profiles::acme::client {

    include ::acme

    $fqdn = downcase($::fqdn);

    ::acme::certificate { $::fqdn:
            use_profile    => 'nsupdate',
            dh_param_size  => 2048,
            acme_host      => 'puppet6.example.com',
            use_account    =><EMAIL_ADDRESS>            letsencrypt_ca => 'staging';
    }

    $base_dir = $::acme::params::base_dir
    $crt_dir  = $::acme::params::crt_dir
    $key_dir  = $::acme::params::key_dir

    file {
        "/etc/ssl/${fqdn}.crt":
            ensure    => file,
            owner     => 'root',
            group     => 'root',
            mode      => '0644',
            source    => "${::acme::params::crt_dir}/${fqdn}/cert.pem",
            subscribe => Acme::Certificate[$fqdn];
        "/etc/ssl/${fqdn}.key":
            ensure    => file,
            owner     => 'root',
            group     => 'root',
            mode      => '0640',
            source    => "${::acme::params::key_dir}/${fqdn}/private.key",
            subscribe => Acme::Certificate[$fqdn];
        "/etc/ssl/${fqdn}.ca":
            ensure    => file,
            owner     => 'root',
            group     => 'root',
            mode      => '0644',
            source    => "${::acme::params::crt_dir}/${fqdn}/chain.pem",
            subscribe => Acme::Certificate[$fqdn];
    }

}

$ cat roles/manifests/reflect.pp
#defines the role of a reflect server
class roles::reflect {
    .....
    include profiles::acme::client
}

hosts.pp

node 'puppet6.cs.princeton.edu'
{
    include roles::puppetmaster6
}

I have to ask you to provide a complete, self-contained example configuration that allows me to reliably reproduce this issue. I will not use your profile code to reproduce this issue.

This is what I did.  I am not sure what else you are asking for.  Are you expecting a tar file?

I still cannot reproduce this so I'll close this issue for now. If someone is able to explain what went wrong in these examples or is able to make them reproducable to me, I'll gladly reopen this issue.

This sounds a lot like #31. I saw a the same behavior with the params.dh on my puppetserver.
Are you open to try https://github.com/phifre/puppet-acme (master) and report if this fixes the issue with your original configuration?

The root cause was identified in #31 and a fix was released in version 2.2.0.


Update logback-classic to 1.4.5

Updates ch.qos.logback:logback-classic from 1.4.4 to 1.4.5.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback", artifactId = "logback-classic" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "ch.qos.logback", artifactId = "logback-classic" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
93 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-21.4%) to 55.53%

Files with Coverage Reduction
New Missed Lines
%

core/src/main/scala/io/aiven/guardian/kafka/Errors.scala
1
0%

cli-backup/src/main/scala/io/aiven/guardian/kafka/backup/App.scala
3
25.0%

core-cli/src/main/scala/io/aiven/guardian/cli/MainUtils.scala
4
0%

core-restore/src/main/scala/io/aiven/guardian/kafka/restore/KafkaProducer.scala
6
18.18%

restore-s3/src/main/scala/io/aiven/guardian/kafka/restore/s3/RestoreClient.scala
6
0%

core-backup/src/main/scala/io/aiven/guardian/kafka/backup/BackupClientInterface.scala
14
76.32%

core-backup/src/main/scala/io/aiven/guardian/kafka/backup/KafkaConsumer.scala
14
42.86%

backup-s3/src/main/scala/io/aiven/guardian/kafka/backup/s3/BackupClient.scala
45
0%

Totals

Change from base Build<PHONE_NUMBER>:
-21.4%

Covered Lines:
241

Relevant Lines:
434

💛  - Coveralls


enhance gliden64 video plugin configuration

looks correct.
i found the test on the rom a bit weird while i've possibly not the same names : do you think it will work for most people ? what happen when not set because of a bad name ?

https://gitlab.com/recalbox/recalbox-configgen/commit/f348e77472f06130dcda3d7b8763f0ecda1047ce


uFcontext threads segfault on ppc64le

Original issue: https://charm.cs.illinois.edu/redmine/issues/1913

Boost uFcontext threads offer the lowest overhead context switching of all our user-level thread packages, so we'd like to make them the default on OpenPOWER systems. However, we are seeing segfaults during startup when using uFcontext threads on Summit.
The updated version of Boost may fix this issue: ~~https://charm.cs.illinois.edu/gerrit/#/c/charm/+/4044/~~ https://github.com/UIUC-PPL/charm/commit/d667b3ec6435cdc2893c006928b6783d90a2983a
Note that the default threads on all ppc64le build targets is context, so you must link AMPI programs with "-thread uFcontext" to get them.

Original date: 2018-05-16 16:07:34

Updating our Boost threads to Boost 1.67.0 fixes the issue: ~~https://charm.cs.illinois.edu/gerrit/#/c/charm/+/4044/~~ https://github.com/UIUC-PPL/charm/commit/d667b3ec6435cdc2893c006928b6783d90a2983a

Original date: 2018-05-16 16:08:35

Make Boost uFcontext threads the default ULT implementation on all ppc64le targets: ~~https://charm.cs.illinois.edu/gerrit/#/c/charm/+/4193/~~ https://github.com/UIUC-PPL/charm/commit/45816e4971145c18e3157736c7240acaa19a8903


Sub-Folder Project Structure: source-code into "/src" and builds into "/build"

This PR introduces a set of changes for better file and project structuring:

Source code is moved out of the root to inside /src.
Project source code moved to /src/game.
Main modules (hot reload and release) moved to /src/main_*.
Added a /res folder for resources (moved sample shader to there).
Compilation and builds moved to /build/*:

hot reload: /build/dev/

Adjusted main_hot_reload.odin in order to correctly use the /build/dev folder for the game_* dlls.

release and debug: /build/release and /build/debug

Adjusted the build .bat scripts and VS Code and Sublime Text tasks in order to work with these new subfolders.

The .bat scripts automatically create the /build and /build/* folders.

Added a new script build_copy_resources.bat in order to copy resources to the /build/* folder if needed (for deployment, for example).

Running from the root folder with VS Code and Sublime Text does not require copying the resource folders to /build/*.

WARNING: I only adjusted the Windows .bat files and did not adjust the .sh files as I don't have a way to test for Linux and OS X. But it should be easy.
NOTE: I know this is mostly a matter of personal preference, as all the source files AND compiled files in the root folder all mixed up was driving me nuts, and personally I'll keep using this proposed project structure from this PR. I tried to follow the common/universal style of having a "src" and "res" folders.
Anyway, I opened the PR to make this new project structure aware and available for you or anyone else who wish to use it. Of course, feel free to refuse the PR if you prefer your current structure with everything in the root :)

Hi, thank for all the work! I see how this can improve quality of life when working on a project. But I think the simplicity of the current folder structure, where I have only added folders if they are absolutely necessary, is better for getting a quick overview. But that might just be personal preference again.
However, perhaps I can link to your repo in the readme? I was thinking of making a 'spinoff' section in the readme, with projects that are based on this. Perhaps some games, but also just variations of the structure. Let me know if you want to be features on such a list.

Let me know if you want to be features on such a list.

Yes, that's very fine for me :) In this case, I'll keep my main branch synced with yours, so if possible, please link to my build-subfolders branch (which is the branch for this PR too): https://github.com/alfredbaudisch/odin-raylib-hot-reload-game-template/tree/build-subfolders

@alfredbaudisch Okie! Thanks. I added a list at the bottom of the readme with your fork in it. Thank you!


How do see UI on http://localhost:3000/ when developing UI?

How do see UI on http://localhost:3000/ when developing UI?
I tried npm run dev but I am seeing blank white screen

Hi @akshaynstack, to develop within your browser you need to change ref value of isVisible to "true" inside App.vue file. Hope this helps!
const isVisible = ref(true);

Thanks


Width and height changes on resize

Hi,
Is it possible to somehow get the final values of a div after a resize has been completed? Currently I'm using the plugin along with Highcharts and would like to resize my chart along with the widget. I got everything working using the "resizestop" event but I've seen the resized div still changes its width and height to get everything in alignment with the other components after the event has triggered.
Thanks!

I ran into a similar issue that the content within one panel must react to the new size. The new width and high is calculated after the resizestop. For now I just used an small timeout (10ms) and that was in our case enough time and panel dimension was updated.

Thank you for the answer. I implemented a similar solution but had to set my timeout to 200ms in order for everything to resize correctly.


 object and message is wrong for CustomCommand

🐞 Bug Report
<--
❗ NEVER put your Telegram API key or any other private details here. (like passwords, user IDs, etc.)
Substitute them like <API_KEY> or <USER_ID> etc.
-->
Required Information

?
!

Operating system
Name and version

PHP Telegram Bot version
0.80.0

PHP version
8.1.7

MySQL version
5.5.52

Update Method
getUpdates

Self-signed certificate
no

RAW update (if available)
{...}

Summary

CustomCommand doesn't get new Update. CustomCommand always use the first update that has been received
Current behaviour

How to reproduce
Use any CustomCommand and check  object

Expected behaviour
 object must be current

The solution I used for me is:
telegram.php -> executeCommand function
        $this->last_command_response = $command_obj->setUpdate($this->update)->preExecute();

Thanks for bringing this up @uspilot
This is definitely a breaking change, as it changes the way the Update object may have been used in users' projects.
Would you be able to share more about your use-case for this?

I did some censor bot which should delete messages from group chats according to defined rules.
So, the GeneralmessageCommand class is used by default to deal with messages. Once this class is created at the first time it receives an Update object. On any later use of this class the pointer to this class has been returned without updating an Update object inside this class. So in fact you have a pointer to the class with Update object which has been sent to this class at the first use of it. So, you have a command class without any information about Update object you have to work with.

This is solved by #1384, hopefully there will be a release soon... Stay tuned.


update loss to work with sample weights

remove the switch for number of examples per batch that satisfy the y > i set condition.  This is required to a) not have tensorflow complain about using a Tensor in if statement; b) the dimensions of sample weights don't match anymore if the for loop includes that switch.  In order for losses and sample_weights (And any other function that expected losses.shape[0] == batch_size) the if swithc must be removed)

updating unit test (used wrong layer) ...

for reference: sent out corrected fix in https://github.com/ck37/coral-ordinal/pull/21


Feature Request: Timeline Loops Start End .. Export

Request that loops defined in the timeline act as an IN / OUT (start / end ) time span for exported products..
If project uses Wasapi .. Loop off to define ignored start end times

Ahh the main reason i said this is because it is quite standard as you know in linear time lines that the looped area represents the in and out or start and end positions of the project..  when it comes to exporting .. either to exe or video .. it will be essential to have such a functionality .. for the user to be able to define the length of the export ..
When looking at the timeline .. i just thought it would be easiest from a UI standpoint for the user to use those loop markers ... for this function

Okay. Point taken. I think we could move the definition for the loop area to a property in ProjectSettings.
But I have to think about the side effects a bit more.


typos andfixes for grammatical correctness + new pattern "agile business ideas"

1.) please see the detailed description in each of the commits
2.) I have added a new pattern "agile business ideas" using a system and README file.

Conflicts, please check and resubmit?


Option to use database table fields instead of resource

Hello,
Many of my resources have fields with are only visible in the database, but have to be filled..
a option for using fields from the coresponding table would be ideal for this..
thanks
D

I agree @Dontorpedo, that might be a nice feature in some circumstances.
I'm open to PRs if anyone fancies giving this a go.


Proposal: Adding support for environment vars

I'm planning to integrate flaggy into an existing project, replacing the currently used urfave/cli package. This existing program also provides the option to pass in options via environment variables. The env part now could be solved on its own. But I was thinking if it wasn't a cool feature for flaggy itself?
It could look something like this:
flaggy.DefaultParser.EnableEnvFlags()
flaggy.String(&stringFlag, "f", "flag", "A test string flag")

If --flag was not passed to the program, we would use the env var FLAG if it is set.
or
flaggy.DefaultParser.EnableEnvFlagsWithPrefix("MYAPP")
flaggy.String(&stringFlag, "f", "flag", "A test string flag")

With a prefix we would look for MYAPP_FLAG.
Precedence should be clear:

The passed --flag
ENV var FLAG
Default value of the flag

Lowercase flags would always relate to UPPERCASE env vars. Hyphens would be replaced with underscores. CamelCase will be split into separate words. So --someFlag would relate to SOME_FLAG.
By default the feature should be disabled, as I can see it could cause problems in some situations, where flags are named like common bash vars, e.g. HOME, TERM, etc
I'm not sure about subcommand flags. For my use case I would only need to add support for global flags - for functionality that would trigger special functionality on a global level, like MYAPP_DEBUG=1. But IF we want that feature as well for subcommand flags, I guess it will  make sense to include the subcommand name into the env var name, to avoid conflicts with flags from other subcommands.
flaggy.DefaultParser.EnableEnvFlagsWithPrefix("MYAPP")
flaggy.String(&stringFlagA, "a", "flagA", "A test string flag (A)")
subcommand := flaggy.NewSubcommand("subcommandExample")
subcommand.String(&stringFlagB, "b", "flagB", "A test string flag (B)")

Corresponding env vars would be:

MYAPP_FLAG_A
MYAPP_SUBCOMMAND_EXAMPLE_FLAG_B

Happy to work on this. Just wanted to check if you were interested in this feature or would reject it.

I also do like the way urfave/cli has support for custom env vars per flag. But I don't see how we could implement this in a backwards compatible way into flaggy. The function signature of all flag functions would change.

I like the way you're thinking of this and definitely agree that it would be a good feature to have.  We have had some people ask about the bet way to do this in the past, and I suggested a relatively simple way to solve it by setting a global with the flag's value.:
var myFlag = os.Getenv("MY_FLAG")
If flaggy does not get a flag, it will not change the previously parsed environment variable.  However, this still needs added to a help message as a prepend and isn't noted in the help output at all.  The only reason this isn't in flaggy is because I wasn't sure of the best clean and intuitive way to solve the issue.
I think it is possible to add an entirely new set of flags that do the flag name to environment variable conversion logic you described.  For example, we could create functions named flaggy.StringSliceEnv() instead of just flaggy.StringSlice.  This would let people easily indicate which values they wanted to have environment variables.  We should just be careful to clearly document the environment variable creation logic so it works as expected and isn't a surprise to the user.
If we get that right, it would be easier to use than specifying flags manually.  On the flip side, it does not solve the problem of overriding the environment variable use (as you mentioned with the HOME environment variable....   I am not sure what to do there yet.  Maybe that means a new Env function won't be compatible here - or perhaps it means that the Env style functions have an additional parameter to specify the environment variable name.
I actually have two long flights across the USA this week.  I will take a stab at this in a branch (tomorrow and Tuesday) and report back.  I think I know how to work this into the parsers in a way that makes sense.

var myFlag = os.Getenv("MY_FLAG")

Oh dear, I tend to overcomplicate things. Indeed, it is that simple to accomplish. 🤦♂

However, this still needs added to a help message as a prepend and isn't noted in the help output at all.

I don't know, not necessarily. I actually am not aware of any program that indicates env var counterparts for flags in the hep message. That's something that can be added to the documentation, or prepend/append help message. Or if the customer wants it in the flag description, it can be simply added to its desc.
I agree with everything you wrote, wrt to flaggy.StringSliceEnv() and an additional parameter for defining the flag name. Makes all sense. But I'm no longer sure it is worth the effort now that you made me realize how simple it is with the default value.
Save travels! 😸

One thing to keep in mind is, that with var myFlag = os.Getenv("MY_FLAG"), the help message would show the value of the env var as default value. This might be confusing, since it is a not a fixed default.
On the other hand this might also be used to the users advantage, e.g.
var flagLang = os.Getenv("LANG")
var flagTime = os.Getenv("LC_TIME")
...

I ended up leaving my laptop at the TSA in Seattle, so I didn't get to use my 10+ hours of flight time productively as I had hoped... 😞
Perhaps it should be noted how to deal with environment vars as described above in the documentation.  It's not obvious that flags not used by the user don't change from their original values.
I think the Env suffixed functions could be helpful, but maybe it's not worth the extra code complexity... Somehow, I am less motivated to write this feature than I was before my trip.  I'll try adding something to the readme.


Add Tourmaline to the showcase

Motivation
To get my recently published docs into the showcase
Have you read the Contributing Guidelines on pull requests?
I sure have!
Test Plan
Well I tested by running the site and making sure it was working. If there are any tests specific to the showcase I'd be happy to amend the PR.

@watzon thanks for adding your project to our showcase!


Brightness Temperature

The CEOS ARD Nighttime Lights Surface Radiance spec asks to provide "brightness temperature from thermal bands". With mit limited RS background, do I assume correctly that this is a per-band field that could be exposed in the EO extension? Something like eo:brightness_temperature as a numerical value with the unit Kelvin?
@matthewhanson

It just occured to me that this is probably a per-pixel value, not something you'd compute an average for per band?!


Added functionality to Twig extractor

Modified Twig extractor to allow user to add custom Twig extensions should they be required to parse templates for gettext

Ok, thank you


Keep waiting & Closed switched

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: the latest as of (20/02/2023)
OS Version: Windows

Steps to Reproduce:

if your vsCode freeze the modal that pops-up and ask do you want to close, keep-waiting or reopen
if you click keep waiting it closes & if you click close it keeps waiting

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

i would try recreating with the insider version

Thanks

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Multiple errors preventing starter app from working

The starter project is currently broken. After downloading a fresh install and applying fix in #44, the app still fails to run.
There are many errors. The first of which is rejecting the "Content-Security-Policy".
I reverted the setting here back to the previous one (2 days ago) and the Content-Security-Policy errors went away.
<meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self' * 'unsafe-inline'; img-src * data:; connect-src *; style-src 'self' 'unsafe-inline';">

The next error is a failure to fetch cordova.js
GET http://localhost:8000/cordova.js

I could only get this injected when running the starter from the cordova launcher. To do this I created a new cordova app then copied in the files from the starter. Then added a browser platform (the simplest to get started with for testing).
$ cordova create touchstone-test
$ cordova platform add browser
$ cordova run browser

At this point the cordova.js file get added.
When running through npm start, I found I could comment out the cordova.js entry in /src/index.html to get past it that way.
Then it fails for missing a "screen.js" file.
I'm looking forward to trying out this framework. I'd appreciate any help you can provide in solving these issues.
Other platform notes:

Using both Chromium and Google Chrome browser
Arch Linux
node 5.1.0
npm 3.5.0
cordova 5.4.1

Odd, it has been working fine for me... the CSP change was due to issues with iOS9, sounds like they're incompatible with the settings needed for Chrome?
Specifically, we need to add the gap: protocol to the whitelist or the app fails to start.
I took the new version from the cordova whitelist plugin docs: https://github.com/apache/cordova-plugin-whitelist
Aside from that the 404 on cordova.js is "intentional" when you're previewing in the browser; the correct file for the platform is copied into the target www folder when you run cordova prepare so that's a cordova thing and shouldn't affect the app from running correctly in the browser with npm start. Regardless, I think it would be a good idea to explain this in the readme :)
Not sure what's up with the missing screen.js file, I'm going to set up my local environment again from scratch because it sounds like I'm getting different results from you.

After retrying with the latest code changes and starting with a fresh project, I was able to get it working. Thanks!

Great, thanks for letting me know :)


fix - $cordovaSQLite.openDB callbacks

$cordovaSQLite.openDB has not callback parameters to pass to sqlitePlugin.openDatabase. Now "options" has two new fields:  "success" and "error" used as callbacks.

CI build failed; please pull latest; check errors; and re issue against dev-next.

I made a mistake, I pulled #1087


remove string "v1beta1" from streamer_test.go

Neither of the input parameters of InputStream() is used, so let them be empty strings.
#8087
@bgrant0607 @krousey @nikhiljindal

LGTM, thanks!

@k8s-bot retest this please


Python usability -- plain classes instead of TypedDict

It's inconvenient and un-Pythonic to have to make everything a TypedDict. The natural way to describe a Python schema would be to use a plain class or a dataclass. Pydantic classes should also work. All these have in common that the data, when being manipulated by a Python program, looks and feels like a Python object rather than a Python dict. For example, to construct an object, you would write something like
p = Point(x=10, y=42)

instead of
p = {'type': 'Point', 'x': 10, 'y': 42}

I believe that Pydantic is able to take in JSON and turn it into a Python object for consumption by Python code, and it does the validation as it is doing the conversion.
I would also like not to have to explicitly add the
    type: Literal["Point"]

declaration to the Point class.

I withdraw this. It seems you can use dataclasses just fine.


[SMALLFIX] The release package is missing bin/alluxio-monitor.sh

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/129/
Test FAILed.

failing test is unrelated. thanks for the fix. I will cherry-pick this PR to 1.8 branch


Have you heard of evil.sh?

Nice project you got here :) Have you seen evil.sh?

Looking at it, most of those seem to be rather more of a brute force approach then I'm going for here. :)


[Bug]: mode is only supported in Pydantic v2

Describe the bug
When I register a function in the agent and the agent needs to execute the corresponding function, an error message will appear: mode is only supported in Python v2
Steps to reproduce
File "autogen/agentchat/conversable_agent.py", line 638, in generate_oai_reply
is  extracted_response = extracted_response.model_dump(mode="dict")
will raise:
File "/usr/local/lib/python3.10/site-packages/openai/_models.py", line 190, in model_dump
raise ValueError("mode is only supported in Pydantic v2")
Expected Behavior
When I register a function in the agent and the agent needs to execute the corresponding function, an error message will appear: mode is only supported in Python v2
Screenshots and logs
File "/usr/local/lib/python3.10/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 247, in run_asgi
result = await self.app(self.scope, self.asgi_receive, self.asgi_send)
File "/usr/local/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in call
return await self.app(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/fastapi/applications.py", line 290, in call
await super().call(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/applications.py", line 122, in call
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/middleware/errors.py", line 149, in call
await self.app(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 79, in call
raise exc
File "/usr/local/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 68, in call
await self.app(scope, receive, sender)
File "/usr/local/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in call
raise e
File "/usr/local/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in call
await self.app(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/routing.py", line 718, in call
await route.handle(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/routing.py", line 341, in handle
await self.app(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/routing.py", line 82, in app
await func(session)
File "/usr/local/lib/python3.10/site-packages/fastapi/routing.py", line 292, in app
await dependant.call(**values)
File "/app/digital_jobs/copywrite/XHS/ai_pad.py", line 250, in run_chat
await customer_manager.a_initiate_chat(
File "/usr/local/lib/python3.10/site-packages/autogen/agentchat/conversable_agent.py", line 579, in a_initiate_chat
await self.a_send(self.generate_init_message(**context), recipient, silent=silent)
File "/usr/local/lib/python3.10/site-packages/autogen/agentchat/conversable_agent.py", line 403, in a_send
await recipient.a_receive(message, self, request_reply, silent)
File "/usr/local/lib/python3.10/site-packages/autogen/agentchat/conversable_agent.py", line 523, in a_receive
reply = await self.a_generate_reply(sender=sender)
File "/usr/local/lib/python3.10/site-packages/autogen/agentchat/conversable_agent.py", line 1012, in a_generate_reply
final, reply = await reply_func(
File "/usr/local/lib/python3.10/site-packages/autogen/agentchat/groupchat.py", line 391, in a_run_chat
reply = await speaker.a_generate_reply(sender=self)
File "/usr/local/lib/python3.10/site-packages/autogen/agentchat/conversable_agent.py", line 1012, in a_generate_reply
final, reply = await reply_func(
File "/usr/local/lib/python3.10/site-packages/autogen/agentchat/conversable_agent.py", line 648, in a_generate_oai_reply
return await asyncio.get_event_loop().run_in_executor(
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.10/site-packages/autogen/agentchat/conversable_agent.py", line 638, in generate_oai_reply
extracted_response = extracted_response.model_dump(mode="dict")
File "/usr/local/lib/python3.10/site-packages/openai/_models.py", line 190, in model_dump
raise ValueError("mode is only supported in Pydantic v2")
ValueError: mode is only supported in Pydantic v2
Additional Information
This my version:
autogen = 0.2.2
pydantic = 1.10.13
openai =1.3.8
Operating System:Windows 10
Python Version:3.10.13

@kevin666aa

Dear @ekzhu and @kevin666aa and @rickyloynd-microsoft : can you please release that blocking bugfix asap in 0.2.3? I assume many use cases are entirely broken due to that issue. Thank you very much in advance!

Releated to #1134 Thanks. We will do that.


Docs: Bug in code example

Describe the bug
The code example here has this bug.

The arguments passed to the mutate function causes.
Your minimal, reproducible example
https://tanstack.com/query/latest/docs/framework/react/quick-start
Steps to reproduce

Copy the code given in the link
Run it

Expected behavior
No errors
How often does this bug happen?
Every time
Screenshots or Videos

Platform
Win 10
Chrome
Tanstack Query adapter
None
TanStack Query version
5.52.1
TypeScript version
5
Additional context
No response

@Jay-Karia I think it depends on how you define the postTodo's function. I was able to resolve the error defining a custom postTodo function like this:
const postTodo = async ({id, title}: {id: number, title: string}) => {
    console.log(id,title)
}

the quick start is not a full example that's meant to be copy-pasted. It has an import that doesn't exist:
import { getTodos, postTodo } from '../my-api'

For runnable examples, please look at the examples:
https://tanstack.com/query/latest/docs/framework/react/examples/simple


Fix (LLMLingua): fix the link of llama_index

fix wrong llamaindex pipeline link

Hi @wlsdml1114, thank you for your help.
Please adhere to the guidelines set by the @microsoft-github-policy-service to resolve the CLE issue.

@microsoft-github-policy-service agree


fix issue #8325

fix issue #8325

Can one of the admins verify this patch?

Jenkins, test this please


[AutoPR cosmos-db/resource-manager] Added Sql Stored Procedure for CosmosDB

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6659

(message created by the CI based on PR content)


add a syslog option

add the ability to configure all the services to use syslog

thanks to jeblair we have this with pull request #104


[BACKLOG-35866] Add help button to VFS Connection dialogs

:x: Build failed in 6m 58s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/connections/ui,ui

:exclamation: No tests found!
Errors:
Filtered log (click to expand)

script returned exit code 1

:information_source:  This is an automatic message


Move the code dealing with trees to a different module

See #1165
It also fixes #1168
Everything dealing with _childNodes and _parent has been converted to use https://github.com/jsdom/js-symbol-tree. This library uses Symbol to keep track of the entire tree. It has has a few efficient query methods. Its main benefit is that performance remains constant as you add more nodes.
So far I have patched the minimal what was needed to get jsdom working. I intend to move over some more utility functions and things like compareDocumentPosition. However I want to get some comments in first.
The tree modification benchmarks show a modest improvement for removeChild(), the biggest improvement is indeed in the tests where you call removeChild() on a node with a huge amount of siblings.
appendChild() is a little slower probably because I am using for-of (the profiler is complaining about it). This hurts performance because of a limitation in v8. This has been recently fixed however: https://code.google.com/p/v8/issues/detail?id=3822. So I'm eagerly awaiting for that to land in io.js

<3. Review done. Largely minor concerns. Some stuff can be pushed off to later, for sure.

Instead of doing three passes (iterate to create array; loop over array with map; loop over array with join) why not stick with a for-of over a children iterator?

The original code was using join so I assumed it was better for performance. However I just did a benchmark and it seems that simple string concatenations are faster in v8 than array + join. Some googling tells me that the join "optimization" is a relic of ancient IE.

I've addressed all your points except the ones about mapper and NodeList. Addressing those two would be part of an effort to refactor all those collection classes. This is too big to include in this PR imo.
The symbol-tree API should be easier to understand now: https://github.com/jsdom/js-symbol-tree/blob/master/api.md
All optional arguments are passed an "options" object now. And the method names are more consistent with naming in DOM. For example firstChild() instead of first(), hasChildren() instead of isEmpty(), appendChild() instead of insertLast().
_indexOf() has been removed, it was only used by the old compareDocumentPosition.

LGTM! Maybe file a follow-up issue to refactor the collection classes.


Get-LocalAccountLockout cmdlet should return "Not Configured" as parameter value instead of null value

Code of Conduct

[X] I have read and agree to the project's Code of Conduct.
[X] Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
[X] Do not leave "+1" or other comments that do not add relevant information or questions.
[X] If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description
At present in below section of the code, we return null object if values are not found. Instead if we could state some meaninful info like "Parameter Not Configured", it helps user understand better than think that some thing not working and hence output is empty in ppm report page. I have a PPM ticket for your reference [ https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-password-management/issues/198 ]
      $accountLockoutObject = New-Object -TypeName psobject
       $accountLockoutObject | Add-Member -notepropertyname "System" -notepropertyvalue $vmName
       if ($failures) { $accountLockoutObject | Add-Member -notepropertyname "Max Failures" -notepropertyvalue $(if ($drift) { if ($failures -ne $requiredConfig.maxFailures) { "$($failures) [ $($requiredConfig.maxFailures) ]" } else { "$($failures)" } } else { "$($failures)" }) }
       if ($unlockInterval) { $accountLockoutObject | Add-Member -notepropertyname "Unlock Interval (sec)" -notepropertyvalue $(if ($drift) { if ($unlockInterval -ne $requiredConfig.unlockInterval) { "$($unlockInterval) [ $($requiredConfig.unlockInterval) ]" } else { "$($unlockInterval)" } } else { "$($unlockInterval)" }) }
       if ($rootUnlockInterval) { $accountLockoutObject | Add-Member -notepropertyname "Root Unlock Interval (sec)" -notepropertyvalue $(if ($drift) { if ($rootUnlockInterval -ne $requiredConfig.rootUnlockInterval) { "$($rootUnlockInterval) [ $($requiredConfig.rootUnlockInterval) ]" } else { "$($rootUnlockInterval)" } } else { "$($rootUnlockInterval)" }) }
       Return $accountLockoutObject

Use Case(s)
[ https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-password-management/issues/198 ]
As mentioned in the reference ticket raised in PPM, it is like if the SDDC appliance is not configured yet, all values for the account lockout settings of password management policy will be empty, to it is better to show "Not Configured" Instead of empty report, which could be misleading to customers.
Potential Configuration
set variables to a string value "Not Configured" instead of returning it as null.
References
No response

Hi Team, This is how I have implemented. @GaryJBlake, kindly provide your feedback.
PS C:\Users\Ashwini\Documents\GitHubPublic\VMware.CloudFoundation.PasswordManagement\tests>  Request-SddcManagerAccountLockout -server sfo-vcf01.sfo.rainpole.io -user<EMAIL_ADDRESS>-pass VMw@re123! -rootPass VMw@re123!
System    Unlock Interval (sec) Root Unlock Interval (sec)
------    --------------------- --------------------------
sfo-vcf01 601                   601

PS C:\Users\Ashwini\Documents\GitHubPublic\VMware.CloudFoundation.PasswordManagement\tests>  Request-SddcManagerAccountLockout -server sfo-vcf01.sfo.rainpole.io -user<EMAIL_ADDRESS>-pass VMw@re123! -rootPass VMw@re123!
System    Max Failures   Unlock Interval (sec) Root Unlock Interval (sec)
------    ------------   --------------------- --------------------------
sfo-vcf01 Not Configured 601                   601

kindly provide your feedback.

Looks good to me.

Thans Ryan!!!
On Wed, Aug 7, 2024 at 12:13 AM Ryan Johnson @.***>
wrote:

kindly provide your feedback.
Looks good to me.
—
Reply to this email directly, view it on GitHub
https://github.com/vmware/power-validated-solutions-for-cloud-foundation/issues/702#issuecomment-2271921416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2IMYCBS743AWS5FKZLLI5DZQEKMPAVCNFSM6AAAAABLX2GCNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRHEZDCNBRGY
.
You are receiving this because you were assigned.Message ID:
<vmware/power-validated-solutions-for-cloud-foundation/issues/702/2271921416
@github.com>

--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.


2169 update settings list

Context
https://trello.com/c/hOra3k4r
Changes proposed in this pull request

Remove links to schools
Remove status column
Reorder and rename columns
Display devices ordered rather than allocations
Only show "Devices received" column to RBs lacking a virtual cap
Change breadcrumb

Guidance to review

 Update the Settings list


Emmet need to move cursor to class for div. expansion

VSCode Version: 1.32.1
OS Version: Windows 10

Steps to Reproduce:
In an HTML file when typing div. and press tab
it creates a new

 and moves the cursor inside the
|
, I think it should move it inside the class name class="|", It's so helpful when using classname auto completion extension.

Does this issue occur when all extensions are disabled?: NO

\closedWith dc5a3da

\closedWith dc5a3da


TrackedStorage

A basic implementation for a TrackedStorage (https://github.com/slide-rs/specs/issues/89).
This version of the TrackedStorage does not implement a way to compare the past version and the modifies version of the components. Usage requires unwrapping the storage to the base TrackedStorage which implements Join for flagged components.
Alternative design choices:
Implement TrackedStorage similar to how MaskedStorage works.
Pros:

Would make it possible to have the Join of the storage only work on the flagged components without calling any additional methods.
Might open up a path for a generic storage wrapper like UnprotectedStorage but instead as a container for how the Join gets the components necessary for the loop (this could be interesting since it would allow for different methods other than bitsets, but would also be pretty hard to get right).

Cons:

Difficult to get all the components instead of just the flagged ones as there is no current way to directly get access to the container storage.
Might be unintuitive at a glance as you would expect to get all the components when joining the storage.

Compare modifications for more accurate flags
Pros:

Removes a large concern for if the user iterates over a mutable tracked storage.

Cons:

Performance benefits of the tracked storage decreases.
Difficult to implement. Requires a way to directly compare the new "modified" version with the past version.

Also, this runs into the same problem as the Join implementation for a &'a mut Storage. Maybe it might be better to have something like a Join and JoinMut, or possibly have Join with it automatically implementing it for &'a T/&'a mut T where T: Join?

I'm assuming the main problem is just that calling get_mut means it is checking again whether the entity has the component, even though we already know?

Yes.

Maybe it might be better to have something like a Join and JoinMut?

I don't think JoinMut would solve that. It would require all the iterated things to be mutable, while we need to mix and match them.

In case you don't want to add or change anything, I'd say you can merge it after squashing.
bors delegate=Aceeri

bors r+

Nice we finally have a FlaggedStorage :tada:
Thanks @Aceeri!
bors r+


_reshape_cell_shape_functions for SizedMatrix

When the number of dofs is too large, StaticArrays.kron returns a SizedMatrix instead of SMatrix. This fix is just a slighlty change in the signature of _reshape_cell_shape_functions to enable working with SizedMatrix.
Note that an alternative fix would be to use StaticArrays._kron and force to return a SMatrix. But I find the present fix less intrusive for now.

This partially solves #142