Use IsNullOrWhitespace instead of IsNullOrEmpty

Decimal and group separators are not touched - as discussed they can be white space.
Currency name and symbol are also left untouched, but I think they cannot be white space.
Fixes #730

This needs to be rebased with main as some of these files don't exist anymore, i.e. NickvisionMoney.GNOME/Helpers/Help.cs

CC @JoseBritto

User provided custom currencies can be empty. Right now you can create an account with currency name and symbol as whitespace. Checking for whitespace here should do the trick.
https://github.com/NickvisionApps/Denaro/blob/111308064333cfa9712b6bf73a53739b1e54a3d0/NickvisionMoney.Shared/Controllers/NewAccountDialogController.cs#L123-L149
Line 150 shouldn't be changed as if its changed to nullorwhitespace it would allow you to have to space in currency symbol and use space as the group separator, which isn't allowed I believe. Nick correct me if im wrong on this one.

@UrtsiSantsi will you be able to finish this by Thursday, the latest?
If not, @JoseBritto could you make that change and make sure it all looks good?
I would like to release a stable version on Friday with this included.

@nlogozzo tbh, I'm not sure how to modify this pr 😅. I'll have to look up some guides from github.
Also one more small thing.
I think we should trim user inputs in some places. Right now a user can name an account a and it will be created as 'a .nmoney' which can cause some confusions. Most other applications would just remove the space

@UrtsiSantsi If you're still having trouble with the environment let me know. I'll push the changes. Also maybe I can help with setting it up.

Currency name and symbol should not be whitespace, I agree with you guys

I think we should trim user inputs in some places. Right now a user can name an account a and it will be created as 'a .nmoney' which can cause some confusions. Most other applications would just remove the space

The same thing happens with groups. There can be two groups one 'abc<space>' and another 'abc' without the space and denaro will treat them differently. Tags are not affected by this as they are already trimed with the GetText() here:
https://github.com/NickvisionApps/Denaro/blob/58ed6ab35acefec3ca1b2ac1298514785b53fd04/NickvisionMoney.GNOME/Views/TransactionDialog.cs#L353
Replacing GetText() with GetText().Trim() here
https://github.com/NickvisionApps/Denaro/blob/58ed6ab35acefec3ca1b2ac1298514785b53fd04/NickvisionMoney.GNOME/Views/GroupDialog.cs#L143
and here
https://github.com/NickvisionApps/Denaro/blob/58ed6ab35acefec3ca1b2ac1298514785b53fd04/NickvisionMoney.GNOME/Views/NewAccountDialog.cs#L288
would fix group names and account names.
@UrtsiSantsi can you accommodate that as well along with the other fix. I don't think there is a need to create a separate pr for this.

I'll try it out

With commit bd1fa10 previously saved accounts with empty currency symbol will be now shown as the local symbol. I'm not sure if thats desirable or not. In my opinion we are probably better off not checking for whitespaces when loading data from nmoney files as the data is written by denaro after validation anyway.
Ignoring passwords which are just white spaces feels a bit off since they show up as characters in the password field in the new account dialog but the account gets created without a password. I feel like we should leave that as it was earlier.
@nlogozzo Thoughts?

Not sure why snap is failing 🤔

Writing this here as I always forget this 😅 We should update the changelog as well

Not sure why snap is failing 🤔

snap has an old version of blueprint-compiler that doesn't support Adw.Breakpoint syntax. Don't worry about it @soumyaDghosh is on the way with a fix

With commit bd1fa10 previously saved accounts with empty currency symbol will be now shown as the local symbol. I'm not sure if thats desirable or not. In my opinion we are probably better off not checking for whitespaces when loading data from nmoney files as the data is written by denaro after validation anyway.

I think it's okay because then users will notice and they will be forced into going into AccountSettings to fix their symbol and not provide a whitespace, to match the new standards.

Ignoring passwords which are just white spaces feels a bit off since they show up as characters in the password field in the new account dialog but the account gets created without a password. I feel like we should leave that as it was earlier. Or is there a way to hint the user that the password is invalid?

Yeah I'd say passwords can be whitespace cause   vs   vs   could all be valid passwords is my opinion but they would fail validation/login.

but it will fail validation, so I think this check should stay.

We are saying to revert it back to IsNullOrEmpty for all passwords checks because we want the different whitespace to all be valid.

Yeah I'd say passwords can be whitespace cause   vs   vs   could all be valid passwords is my opinion but they would fail validation/login.

Yes, you can construct password that consist only of different types of white space, but it will fail validation, so I think this check should stay.

The problem right now is that when typing in just spaces the password prompt shows input just like any other character and the user believes that a password is being set correctly but actually since the whitespace password is detected as empty (even though the user was shown the password field containing characters) denaro creates a regular unencrypted account. There is currently nothing informing the user that its not a valid password.

I typed in two spaces here
To disallow whitespace passwords properly, we need to have some kind of ruleset for password validation and inform users before they move on from this screen. Then again whitespace should be considered invalid password instead of empty password. Treating whitespace as the same as an empty password field would cause confusion.

PS: I'm not saying that we should disallow whitespace passwords, but incase we do it, it should be done properly

I'm against disallowing whitespace passwords. I think they should stay.

I'm against disallowing whitespace passwords. I think they should stay.
Everything else expect the parts where it touches passwords should be good then

I'm against disallowing whitespace passwords. I think they should stay.

Everything else expect the parts where it touches passwords should be good then

To you have time now? Could you update this PR and restore the password stuff back to IsNullOrEmpty so I can merge in the morning and release stable?

Sure thing

Sure thing

Thank you :)

@nlogozzo What do you think about including this in this release as well? It seems like a minor thing fix to me.

@nlogozzo What do you think about including this in this release as well? It seems like a minor thing fix to me.

We can include that. Feel free to commit that all in here too so it's just one merge.

Not sure if the changelog is good enough. You might have to rephrase it tomorrow, I'm bad at writing these things 😅

Not sure if the changelog is good enough. You might have to rephrase it tomorrow, I'm bad at writing these things 😅

Changelog is fine. It'd just but the disallowed as the first item and keep all the fixes together. But I'll edit that myself.
Thanks so much for working on this, you and @UrtsiSantsi ❤


Compute Good_turing estimate

All changes implemented. Both general and 1-reset Good-Turing estimators now computed well. See the below outputs.

Nice!
Just wanted to check something. Instead of the floating point result, can you print the number of singletons (and reset singletons)? This way, we measure singletons, I suspect f1 to increase proportionally to the total number of generated inputs (i.e., almost everything is a singleton).


chore: upgrade peer deps

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Thrust-shell.exe close problem.

Hi,
i want windows app with go-thrust.
So i don't want to open windows command line interface.
i use "go build -o MyApp.exe -ldflags "-H windowsgui"" command for build. this command work perfectly.
but when i close the program, trust-shell exe is still running..
First thrust-shell.exe is close. Second thrust-shell.exe does not close..
How can I solve this problem?
Thanks.

So this is a problem with OS signals. Windows just not properly send signals to child processes.
We have built a workaround at some point.
@tehbilly  do you happen to remember this.

I don't remember what we did to work around this offhand, but will take a look at it later on today hopefully. Most likely we should do a defer in main() to kill child processes before parent quits.

I think the correct solution to this was to use the Thrust.SafeExit or CleanExit command


Add forum or GitHub discussions

Bug description
Hi! It seems the only way to contact you, or ask for questions, or make feature requests is to use this bug template. But it's certainly not a bug
Adapter
No response
Model
No response
Suggested Resolution
No response

@InAnYan
Very good point. The GitHub issue templates need updating; I’ll take care of that.
I’ll add more types of GitHub issue templates (or remove them as needed).
Also, good suggestion on the discussion; I’ve just started it: https://github.com/jeremychone/rust-genai/discussions

As the "discussions" is opened, I will close the issue.
Thanks!


Bug tabindex on the form with date fields

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Hello, the bug happens when you are loading a form with dates, date fields are moved to the end of the list of indices,
Here is the example.
https://jsfiddle.net/6go7556p/6/
I suggest if you can put a tabindex property in the field so the user can set it.
Thank you. regards

This is not a bug with w2ui, but you did add a batt attr property (you forgot the closing ".
Updated fiddle: https://jsfiddle.net/6go7556p/7/
Please close this issue if your problem is solved.


staging server lacks hg38/fasta

Can you double-check? Not sure why that one is missing (how can it be missing if we've built the other assets?)

maybe it just didn't get archived correctly or something. you said the archives were still pending, right?

I know what's the reason. I've been archiving the largest assets (like dbnsfp or bismark*) while other genomes' assets were still building to save time. And did not archive the fasta in the end...

refgenieserver archive supports single assets archiving, so that's not a problem. I'll archive it today

done


Allow multiple transects within same CSET run

What problem does your feature request solve?

Currently we can only plot a single transect per model variable, with one set of start and end coordinates. It would be nice to plot multiple, to get a look at how they vary throughout the domain.
Describe the solution you'd like

Some kind of list of start and end points that we can then cycle over? Maybe something like the field definition?
Describe alternatives you've considered

Currently you can just run CSET multiple times to achieve this. It would be nice to do it in one shot.

An example use case is examining the winds through a channel. A user might want to create a transect across the front of the channel, through the middle and at the exit of the channel, to determine how the winds and moisture vary through the valley. We also need to ensure the proper metadata about the transect is included in the transect plot title (coordinate information).


How to modify this reipo to make it work on amd64 computer?

Hi,
thanks for your amazing work!
Could you please tell me which part of this repo should be modified if I want to deploy this system on amd64 computer?

@HilbertXu Hey, for me I just modified the CMakeLists.txt to know the cuda and tensorrt on my laptop:
include_directories(
    /usr/local/cuda/include
    /home/travis/packages/TensorRT-<IP_ADDRESS>/include
    ../include/
    ../include/plugin/
)

link_directories(
    /usr/local/cuda/lib64
    /home/travis/packages/TensorRT-<IP_ADDRESS>/lib
)

@jcuic5
Hey, thanks for your reply, I tested your config, and i works fine? thanks!

trt_infer: Assertion failed: cublasStatus == CUBLAS_STATUS_SUCCESS
../rtSafe/cublas/cublasLtWrapper.cpp:279
Aborting...
trt_infer: ../rtSafe/cublas/cublasLtWrapper.cpp (279) - Assertion Error in getCublasLtHeuristic: 0 (cublasStatus == CUBLAS_STATUS_SUCCESS)
: engine init null!
How to solve this problem


Support manage kubeconfig with AWS EKS

refer #44

we can talk if you want, me cli tool is doing just that.
https://github.com/AdamRussak/k8f

If you can contribute this part of the code, I would be very grateful. 🎉
You can find the relevant code here, and if you have any questions, feel free to contact me at any time.

what is the vision here?
adding 1 cluster in a cloud provider?
or scanning and adding all of them dynamically? (wich my tool k8s is doing)

Well. I use this feature quite often. I usually use Terraform to batch create k8s clusters, and using kubecm cloud allows me to download and merge the kubeconfig of the cluster I need to use into my local Kubeconfig without logging into the Cloud UI.
There is a difference between this and dynamically adding all clusters, where I just add the clusters of my choice.


Rubocop and emacs

I am using emacs (GNU Emacs 24.5.1) and I need rubocop to provide clean Cask for the homebrew-cask project. I contact you since you seem to also be an emacs contributor.
I am not a ruby developper and I don't intend to learn it.
The main problem I face is the alignments.
For example:
The default emacs indentation is:
      rmdir:  [
        '/Library/Preferences/Google',
      ]

Which lead to and error:
Inspecting 1 file
C

Offenses:

Casks/google-nik-collection.rb:35:9: C: Use 2 spaces for indentation in an array, relative to the position of the opening bracket.
        '/Library/Preferences/Google',
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

And a second one:
Casks/google-nik-collection.rb:36:7: C: Indent the right bracket the same as the left bracket.
      ]
      ^

So I have to manually indent the 2 last lines which not efficient to end up to:
      rmdir:  [
                '/Library/Preferences/Google',
              ]

Seems like the 2-space indentation is based on the hash key (rmdir:) and no on the [ char as it should be.
Is there a magic emacs configuration to solve that issue?
Thanks for your help.

I can no longer reproduce this in current master. Please feel free to re-open this issue with a reproducible example if you're still experiencing the problem. 🙂


Changed some tuples into lists in the docs

https://groups.google.com/d/msg/django-developers/h4FSYWzMJhs/ljiHfyPkwPQJ

IMO args and natural_key are meant to be tuples. They're more of a data structure than a simple list of elements of the same type.

Please see ticket #24149.

I'll wait for #24149 to happen first.


test: remove redundant test cases for R.__

Thanks to #836 we needn't test this for each function individually.

:cow2:

I have mixed feelings about this.
To my mind, test cases both test and describe the public API.  Since this behavior is now universal to Ramda, there's some reason to just assume it for individual functions.  But I'm loathe to drop these descriptive tests simply because our implementation has changed; part of the point of unit tests is to demonstrate constants in an API even as the underlying implementation changes.
So at the moment, I guess I'm :-1: .

I see your point @CrossEye. It's misleading, though, to perform these assertions for just a handful of functions. It suggests that other functions do not support R.__. We could go the other way and add R.__ tests to all the other functions. What say you?

That's why my feelings were mixed.  I don't think we should be adding such tests all over the place.
But perhaps we should as part of the recent changes add a curated few to note that this now works for more than operators.  Maybe the best way would be to write a test or two for each of the various curry functions that curry some simple functions and show that the placeholder works there.  (You may have already done so.)
That would help demonstrate the additional functionality.  And by not removing the existing tests, we show that current functionality is not impaired.

Okay. It seems we should take a different direction.


Clear cell output when re-running it

When running a cell in Jupyter, have its existing output clear while it's running:
a. since it's already voided, and there soon an updated output
b. it makes it easier to see that the cell still runs
this is the default behavior in Jupyter notebook.

Thank you for filing this issue, given the fact that we haven't had sufficient upvotes on this issue I'm closing this as not planned.


FR - Add Note Preloads front-matter according to active view filters.

What would you like to be added?
For determinate filters like "field" is "value" I think is expected that if I create a Note from the project, It pre-loads those filtered values into the note front-matter, after the template was applied, the same way it currently includes the field corresponding to the lane it was created at.
Why is this needed?
This will allow to display the new note in the context for when it was added independent of view filters.

Closes as duplicate and in favor of #596. Thanks for proposing!


Adding a regexp to match with each user group in resource control

does this fix https://github.com/prestosql/presto/issues/2919 ?

does this fix #2919 ?

It should make this possible if ldap groups are actually assigned to a user.

Merged, thanks!


Release tracking issue: V1 Fees

[x] https://github.com/penumbra-zone/penumbra/issues/2970
[x] https://github.com/penumbra-zone/penumbra/issues/3194
[x] https://github.com/penumbra-zone/penumbra/issues/3153
[ ] #3368
[x] #3369
[x] #3371
[x] #3391
[x] https://github.com/penumbra-zone/web/issues/308
[x] https://github.com/penumbra-zone/web/issues/309
[x] https://github.com/penumbra-zone/penumbra/issues/3164
[ ] https://github.com/penumbra-zone/penumbra/issues/4154
[ ] https://github.com/penumbra-zone/penumbra/issues/4155

@aubrika I modified the tracking issue to only encapsulate V1 fee related work, and spun off separate tracking issue for V2 fee work.


Bump minimum dbt-adapters requirement to 1.12.0

Resolves #10996
Problem
In dbt-core we've made a switch from an environment variable for gating microbatch functionality to a project flag (https://github.com/dbt-labs/dbt-core/pull/10799). In dbt-adapters we've done likewise (https://github.com/dbt-labs/dbt-adapters/pull/323). For everything to work properly, we need depend on those changes in dbt-adapters, which will go out in 1.12.0
Solution
bump dbt-core's requirement spec for dbt-adapters to have a minimum of 1.12.0
Checklist

[X] I have read the contributing guide and understand what's expected of me.
[X] I have run this code in development, and it appears to resolve the stated issue.
[X] This PR includes tests, or tests are not required or relevant for this PR.
[X] This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
[X] This PR includes type annotations for new and modified functions.

Tests won't pass until we do the dbt-adapters release


[TEST][DO NOT SUBMIT] Upgrade cares to 1.20.1

This version of cares has a known issue which is breaking gRPC: https://github.com/c-ares/c-ares/issues/571. If we ever decide to upgrade, we should skip this version (the issue is fixed in 1.21.0).


Python: We don't error on reader protocol v2

Environment
We should be throwing an error if reading a table with protocol v2, but we currently aren't, as demonstrated in #885.
Delta-rs version:
Binding:
Environment:

Cloud provider:
OS:
Other:

Bug
What happened:
What you expected to happen:
How to reproduce it:
More details:

Duplicate of #929.


ESP32-S3 WiFi Interrupt Registration breaks if Watchdog Enabled

Describe the bug
Once 6 other peripheral interrupts are installed, the WiFi "timer_alarm_isr" interrupt allocation fails resulting in loss of WiFi functionality.
Without the watchdog enabled, the WiFi timer interrupt "timer_alarm_isr" is correctly allocated.
(gdb) print int_log_data
$1 = {
  {source = 16, intr = 2, handler = 0x40378920 <gpio_esp32_isr>},
  {source = 27, intr = 3, handler = 0x4207b96c <uart_esp32_isr>},
  {source = 96, intr = 9, handler = 0x4207c2ec <serial_esp32_usb_isr>},
  {source = 28, intr = 12, handler = 0x4207b96c <uart_esp32_isr>},
  {source = 29, intr = 13, handler = 0x4207b96c <uart_esp32_isr>},
  {source = 42, intr = 17, handler = 0x40379564 <i2c_esp32_isr>},
  {source = 59, intr = 18, handler = 0x40377a30 <timer_alarm_isr>},  <-- WiFi interrupt
  {source = 0, intr = 0, handler = 0x0} <repeats 25 times>
}

With watchdog enabled, WiFi timer ISR fails and is not in the allocation table:
(gdb) print int_log_data
$8 = {
  {source = 16, intr = 2, handler = 0x40378920 <gpio_esp32_isr>},
  {source = 27, intr = 3, handler = 0x4207bb24 <uart_esp32_isr>},
  {source = 96, intr = 9, handler = 0x4207c4a4 <serial_esp32_usb_isr>},
  {source = 52, intr = 12, handler = 0x4207e0f4 <wdt_esp32_isr>},
  {source = 28, intr = 13, handler = 0x4207bb24 <uart_esp32_isr>},
  {source = 29, intr = 17, handler = 0x4207bb24 <uart_esp32_isr>},
  {source = 42, intr = 18, handler = 0x40379564 <i2c_esp32_isr>},
  # <timer_alarm_isr> missing
  {source = 0, intr = 0, handler = 0x0} <repeats 25 times>
}

Here is the GDB screenshot showing that the failure is caused by the interrupt controller failing to get an interrupt from the call to get_available_int().
┌─/home/work//zephyrproject-3.6/zephyr/drivers/interrupt_controller/intc_esp32.c──────────────────────────────────────────────────┐
│      592           */                                                                                │
│      593          switch (source) {                                                                                │
│      594          case ETS_INTERNAL_TIMER0_INTR_SOURCE:                                                                                │
│      595                  force = ETS_INTERNAL_TIMER0_INTR_NO;                                                                                │
│      596                  break;                                                                                │
│      597          case ETS_INTERNAL_TIMER1_INTR_SOURCE:                                                                                │
│      598                  force = ETS_INTERNAL_TIMER1_INTR_NO;                                                                                │
│      599                  break;                                                                                │
│      600          case ETS_INTERNAL_TIMER2_INTR_SOURCE:                                                                                │
│      601                  force = ETS_INTERNAL_TIMER2_INTR_NO;                                                                                │
│      602                  break;                                                                                │
│      603          case ETS_INTERNAL_SW0_INTR_SOURCE:                                                                                │
│      604                  force = ETS_INTERNAL_SW0_INTR_NO;                                                                                │
│      605                  break;                                                                                │
│      606          case ETS_INTERNAL_SW1_INTR_SOURCE:                                                                                │
│      607                  force = ETS_INTERNAL_SW1_INTR_NO;                                                                                │
│      608                  break;                                                                                │
│      609          case ETS_INTERNAL_PROFILING_INTR_SOURCE:                                                                                │
│      610                  force = ETS_INTERNAL_PROFILING_INTR_NO;                                                                             │
│      611                  break;                                                                                │
│      612          default:                                                                                │
│      613                  break;                                                                                │
│      614          }                                                                                │
│      615                                                                                │
│      616          /* Allocate a return handle. If we end up not needing it, we'll free it later on. */                                        │
│      617          ret = k_malloc(sizeof(struct intr_handle_data_t));                                                                          │
│      618          if (ret == NULL) {                                                                                │
│      619                  return -ENOMEM;                                                                                │
│      620          }                                                                                │
│      621                                                                                │
│      622          esp_intr_lock();                                                                                │
│      623          int cpu = esp_cpu_get_core_id();                                                                                │
│      624          /* See if we can find an interrupt that matches the flags. */                                                               │
│      625          int intr = get_available_int(flags, cpu, force, source);                                                                    │
│      626                                                                                │
│      627          if (intr == -1) {                                                                                │
│      628                  /* None found. Bail out. */                                                                                │
│  >   629                  esp_intr_unlock();                                                                                │
│      630                  k_free(ret);                                                                                │
│      631                  return -ENODEV;                                                                                │
│      632          }                                                                                │
│      633          /* Get an int vector desc for int. */                                                                                │
│      634          struct vector_desc_t *vd = get_desc_for_int(intr, cpu);                                                                     │
│      635                                                                                │
│      636          if (vd == NULL) {                                                                                │
│      637                  esp_intr_unlock();                                                                                │
│      638                  k_free(ret);                                                                                │
│      639                  return -ENOMEM;                                                                                │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
extended-r Thread<PHONE_NUMBER> In: esp_intr_alloc_intrstatus                                                                  L629  PC: 0x40389f15
}
(gdb) print cpu
$3 = 0
(gdb) print force
$4 = -1
(gdb) print source
$5 = 59
(gdb) bt
#0  esp_intr_alloc_intrstatus (source=59, flags=1026, intrstatusreg=0, intrstatusmask=0, handler=0x40377a30 <timer_alarm_isr>, arg=0x0,
    ret_handle=ret_handle@entry=0x0) at /home/work//zephyrproject-3.6/zephyr/drivers/interrupt_controller/intc_esp32.c:629
#1  0x4038a10c in esp_intr_alloc (source=59, flags=1026, handler=0x40377a30 <timer_alarm_isr>, arg=0x0, ret_handle=0x0)
    at /home/work//zephyrproject-3.6/zephyr/drivers/interrupt_controller/intc_esp32.c:739
#2  0x4202e347 in esp_timer_impl_init (alarm_handler=0x4037787c <timer_alarm_handler>)
    at /home/work//zephyrproject-3.6/modules/hal/espressif/components/esp_timer/src/esp_timer_impl_systimer.c:163
#3  0x4202e211 in esp_timer_init ()
    at /home/work//zephyrproject-3.6/modules/hal/espressif/components/esp_timer/src/esp_timer.c:556
#4  0x4207fa7b in esp32_wifi_dev_init (dev=<optimized out>)
    at /home/work//zephyrproject-3.6/zephyr/drivers/wifi/esp32/src/esp_wifi_drv.c:714
#5  0x4037d89e in do_device_init (entry=<optimized out>) at /home/work//zephyrproject-3.6/zephyr/kernel/init.c:312
#6  0x4037d908 in z_sys_init_run_level (level=INIT_LEVEL_POST_KERNEL) at /home/work//zephyrproject-3.6/zephyr/kernel/init.c:368
#7  0x4037dae8 in bg_thread_main (unused1=<optimized out>, unused2=0x0, unused3=0x0)
    at /home/work//zephyrproject-3.6/zephyr/kernel/init.c:427
#8  0x4201ac5d in z_thread_entry (entry=0x4037dac8 <bg_thread_main>, p1=0x0, p2=0x0, p3=0x0)
    at /home/work//zephyrproject-3.6/zephyr/lib/os/thread_entry.c:48
(gdb)

To Reproduce
On ESP32-S3 WiFi sample, enable additional peripherals.  I have enabled:

GPIO
JTAG USB Serial
Three UARTs
I2C
Watchdog Timer

I have shared an updated version of the interrupt registration patch that was originally shared in the discussion at https://discord.com/channels/720317445772017664/1211822589081550878/1219766247051235449
After booting the system use GDB and enter the following commands to dump the registered interrupts:
set print array on
print int_log_data

Expected behavior
Interrupt registration should be successful since there are more interrupts slots available per Table 9-2 in the ESP32-S3 TRM version 1.4.
Impact
Functionality loss of either the watchdog or WiFi in this case.
[
0001-DEBUG-log-interrupt.patch
](url)
Additional context
Zephyr v3.6.99 at commit d78a9429450f89de7829c8af7efe41fdb692fd50.

@sylvioalves

As a temporary work-around to continue development, I have enabled level 2 interrupts for the WiFI using this patch:
commit 19b1cdd240e5f9453a8589ad8bf2609384cd9796 (HEAD)
Author: Eric Holmberg<EMAIL_ADDRESS>Date:   Mon Jun 17 01:08:22 2024 +1200

    esp-hal-components: allow WiFi interrupt to use either level 1 or level 2

    Level 1 interrupts are failing to register, so enable level 2 interrupts
    while original failure is investigated.

    Fixes #74368

    Signed-off-by: Eric Holmberg<EMAIL_ADDRESS>
diff --git a/components/esp_timer/src/esp_timer_impl_systimer.c b/components/esp_timer/src/esp_timer_impl_systimer.c
index df379a198f..f2581a20ba 100644
--- a/components/esp_timer/src/esp_timer_impl_systimer.c
+++ b/components/esp_timer/src/esp_timer_impl_systimer.c
@@ -154,7 +154,7 @@ esp_err_t esp_timer_impl_early_init(void)

 esp_err_t esp_timer_impl_init(intr_handler_t alarm_handler)
 {
-    int isr_flags = ((1 << 1) & ESP_INTR_FLAG_LEVELMASK)
+    int isr_flags = ((1 << 1 | 1 << 2) & ESP_INTR_FLAG_LEVELMASK)
 #if !SOC_SYSTIMER_INT_LEVEL
                     | ESP_INTR_FLAG_EDGE
 #endif
@@ -163,6 +163,7 @@ esp_err_t esp_timer_impl_init(intr_handler_t alarm_handler)
        esp_err_t err = esp_intr_alloc(ETS_SYSTIMER_TARGET2_EDGE_INTR_SOURCE, isr_flags,
                                                                   (ISR_HANDLER)timer_alarm_isr, NULL, NULL);
        if (err != ESP_OK) {
+        __ASSERT(0, "esp_intr_alloc failed (0x%x)", err);
         ESP_EARLY_LOGE(TAG, "esp_intr_alloc failed (0x%x)", err);
         return err;
     }

@EricNRS, let me check something in wifi driver that could be related to this..

I've encountered the same issue also within the sample/net/wifi example by only enabeling the DMA.
add CONFIG_DMA=y to the prj.conf and enable the DMA in the dt overlay.
The patch from @EricNRS also fixes it.

Not sure if it is the same issue but even with the patch applied I still could not connect to wifi in my custom application.
There I allocated an additional interrupt and forgot to specify the interrupt priority.
e.g.
esp_intr_alloc(cfg->irq_source,
               0,  < ----------
               (intr_handler_t)video_esp32_irq_handler,
               (void *)dev,
               NULL);

Specifying any Interrupt level there (e.g. ESP_INTR_FLAG_LEVEL4) seems to fix it again.
I more or less copied that from the uart_esp32 driver where it also allocates an interrupt without specifying a priority level. (at least when not in async mode)

I keep stumbling over this problem...
By digging in to it I came across the interrupt_descriptor_table.
Looks like I'm running out of interrupt slots.
However, can someone explain me why almost half of the Pheripheral interrupts are marked as reserved? (e.g. INTDESC_RESVD)
Reserved by what?
from hal/esp32s3/interrupt_descriptor_table.c
const static int_desc_t interrupt_descriptor_table [32]={
    { 1, INTTP_LEVEL, {INTDESC_RESVD,  INTDESC_RESVD } }, //0
    { 1, INTTP_LEVEL, {INTDESC_RESVD,  INTDESC_RESVD } }, //1
    { 1, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //2
    { 1, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //3
    { 1, INTTP_LEVEL, {INTDESC_RESVD,  INTDESC_NORMAL} }, //4
    { 1, INTTP_LEVEL, {INTDESC_RESVD,  INTDESC_RESVD } }, //5
    { 1, INTTP_NA,    {INT6RES,        INT6RES       } }, //6
    { 1, INTTP_NA,    {INTDESC_SPECIAL,INTDESC_SPECIAL}}, //7
    { 1, INTTP_LEVEL, {INTDESC_RESVD,  INTDESC_RESVD } }, //8
    { 1, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //9
    { 1, INTTP_EDGE , {INTDESC_NORMAL, INTDESC_NORMAL} }, //10
    { 3, INTTP_NA,    {INTDESC_SPECIAL,INTDESC_SPECIAL}}, //11
    { 1, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //12
    { 1, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //13
    { 7, INTTP_LEVEL, {INTDESC_RESVD,  INTDESC_RESVD } }, //14, NMI
    { 3, INTTP_NA,    {INT15RES,       INT15RES      } }, //15
    { 5, INTTP_NA,    {INTDESC_SPECIAL,INTDESC_SPECIAL} }, //16
    { 1, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //17
    { 1, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //18
    { 2, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //19
    { 2, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //20
    { 2, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //21
    { 3, INTTP_EDGE,  {INTDESC_RESVD,  INTDESC_NORMAL} }, //22
    { 3, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_NORMAL} }, //23
    { 4, INTTP_LEVEL, {INTDESC_RESVD,  INTDESC_NORMAL} }, //24
    { 4, INTTP_LEVEL, {INTDESC_RESVD,  INTDESC_RESVD } }, //25
    { 5, INTTP_LEVEL, {INTDESC_NORMAL, INTDESC_RESVD } }, //26
    { 3, INTTP_LEVEL, {INTDESC_RESVD,  INTDESC_RESVD } }, //27
    { 4, INTTP_EDGE,  {INTDESC_NORMAL, INTDESC_NORMAL} }, //28
    { 3, INTTP_NA,    {INTDESC_SPECIAL,INTDESC_SPECIAL}}, //29
    { 4, INTTP_EDGE,  {INTDESC_RESVD,  INTDESC_RESVD } }, //30
    { 5, INTTP_LEVEL, {INTDESC_RESVD,  INTDESC_RESVD } }, //31
};

When DMA is enabled, it takes at least 6 (up to 10) interrupt slots for all of its rx/tx channels.
In my application I only need one rx channel though.
What ended up working for me is to configure all DMA Channel interrupts to share the same interrupt slot by setting the ESP_INTR_FLAG_SHARED flag when allocating the interrupts in the dma_esp32_gdma driver.

Are you on an older version of Zephyr?  I show interrupt_descriptor_table.c and interrupt_descriptor_table  as only being in IDF 4.x and not in the latest v5.1 version.

You're right. I was on zephyr 3.6.0.
In the latest hal shipping with  3.7.0-rc1 the table moved to components/esp_hw_support/cpu.c.
https://github.com/zephyrproject-rtos/hal_espressif/blob/snapshot/1/components/esp_hw_support/cpu.c#L181
However, the issue persists and there are still almost half of all slots marked as "reserved".

@epc-ake - FYI, you may not want to use LEVEL4 interrupts.  I ran across this issue which if still relevant, implies that anything higher than XCHAL_EXCM_LEVEL (which is 3) may cause corruption of the stack during window exceptions.
https://github.com/zephyrproject-rtos/zephyr/issues/41039

@epc-ake DMA issue is being handled in another PR.


sensor.samba_backup missing and blueprint not bringing it back

Since updating HA the blueprint to restore the sensor.samba_backup sensor is not working
No errors or anything mentioned in log file.

Hi, I have the same problem.
HA Core 2023.1.4 / HA OS 9.4 / HA Supervisor 2022.12.1.

My issue was the add-on was not started. After starting the add-on manually the automation ran fine.

Ok that explains it. There is already an issue that the addon does sometimes not start even though the option "start on boot" is active -> #116
But actually that's not a Samba Backup issue as starting addons in general is done by the supervisor.

Yes I have experienced this a couple of times, is there a work around?

Ok that explains it. There is already an issue that the addon does sometimes not start even though the option "start on boot" is active -> #116
But actually that's not a Samba Backup issue as starting addons in general is done by the supervisor.

Have the same issue, but only with this addon, all my others work fine

Yep thats right, it only happens on this add on for me as well.

I'm seeing the same issue.
I am having to manually start the add-on after each reboot, even though the add-on is set to start on boot in the configuration.

I cannot tell why you're only seeing that issue with this addon. I noticed that problem myself one time, but never again. Anyway, I'm closing this and leave #116 open for now. Even though I don't see anything I could fix at addon level.


Varlamore House Thieving Bonus Chest Indicator Broken After Using Mark Object Function

Type
Incorrect behavior
Operating System
Windows
OS Version
Win 10
Bug description
Arrows indicating bonus chest in the Varlamore thieving minigame were only displaying for a couple of frames before disappearing. Often arrow does not appear at all, but object is is highlighted for a frame and then appears normal.
Issue first appeared after marking chests using Object Markers, but persisted after objects were unmarked, after resetting Object markers plugin and  even after  disabling object markers plugin enabled.
Tried without 117 HD, tried without House Thieving plugin, issue still persisted.
Solved temporarily by logging into the official client, playing the minigame, then logging back into Runelite. After 1 round of thieving round of rounds, issue reappeared.
Screenshots or videos
Broken Thieving Minigame.webm
Temporarily Fixed After Using Official Client.webm
Using Official Client.webm
RuneLite version
Runelite Version: <IP_ADDRESS>
Launcher Version: 2.6.8
Logs
client.log
launcher.log

Can you try to replicate this problem in safe mode? Its my belief this is because of the hub plugin.
I've been using it while stealing the keys, and have noticed the single available arrow immediately jumps to the door, as soon as the child is done baiting the wealthy citizen. So a similar issue where the arrow is getting pulled somewhere else, feels like it's happening for you.
https://github.com/runelite/runelite/wiki/FAQ#how-do-i-run-runelite-in-safe-mode

I was able to replicate this issue while running in safe mode

This issue occurs for me while holding a clue scroll that has been read (and therefore has the clue step infobox on-screen). In my case this is an easy clue scroll with the "Dwarven Mine Crate" step, although I very highly doubt that the issue is that specific.
I am able to reliably reproduce the issue by reading this clue scroll, and reliably resolve the issue by banking or dropping the clue scroll.

This looks like it may be the same bug as #6938.

I've found I am unable to see the arrows with clue scrolls (only checked easy) open. My arrows will show up with the House Thieving Varlamore plugin.


[FEATURE] Create task from existing message

Description

As a
Task creator
I want to
Create a task from a message
So that I can
Use the content of the message as a starting point for a task
Languages
This feature is now implemented in:

[ ] Python
[ ] Node.js
[ ] Java

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

My implementation in #27 just pulls the text of the message and prefills the task title (currently the only field), but maybe we could introduce a notion of task metadata to reference back to the source message?

Might be nice to add some kind of threaded response when the task is created, so others have visibility.


[Bug] Tapping on the resume button would cause me to read the last/latest chapter.

Device information

Tachiyomi version: 1.6.1
Android version: 9
Device: Huawei Y6 Pro (2019)

Steps to reproduce

Tap the “resume" button in the manga page

Expected behavior
It would go to the chapter I'm currently reading
Actual behavior
It would send me to the last/latest chapter available
Other details
The bug only occurs when I read/tap on another chapter rather than the chapter I'm currently reading (I hope this isn't confusing to read). The only temporary fix I could muster up is to clear the cache and tapping the "start reading" button in the library menu.

This isn't a SY specific bug

Its fixed in the main apps preview, I will grab the fix sometime


Clojure can't (.say) numbers

http://discourse.codecombat.com/t/is-kithgaard-mastery-possible-to-complete-in-the-clojure-language-without-the-ability-to-cast-to-strings/4976/4?u=j_f_b_m
This is an issue migrated from the forum.
A user reported that he cannot say numbers (as they are no strings) in the experimental language Clojure. The solution would usually be to cast them with (str ), but that method is not available (unknown if at all or only in the dungeon).

Yeah, that's the situation.

(.say this 1)

(def gems 1)
(.say this gems)

Both of these seem to be working as intended. Perhaps the user misunderstood the level goals?

Fails on exactly such a line.
Full code from the forum thread:
;; Count how many gems you pick up, and then say the current count when near a fireball trap to disable it.
;; The raven at the start will give you a password. Say the password near a door to open it.
;; Kill ogres when you get near them.
;; You can use a loop to repeat all of the instructions as needed.
;; If you beat this level, you can skip to the Forest World!
(if (not gems) (def gems 0))
(.moveRight this)
(dotimes [n 2] (.moveUp this))
(dotimes [n 2] (def enemy (.findNearestEnemy this)) (if enemy (.attack this enemy)))
(.moveLeft this)
(dotimes [n 2] (.moveUp this))
(dotimes [n 2] (.moveRight this))
(.moveUp this)
(inc gems)
(.moveDown this)
(.moveRight this)
(dotimes [n 2] (.moveDown this))
(.say this gems)

It's undefined due to your if form at the top. You're using the gems symbol before it's ever bound. This is causing a reference error. You can see the error more clearly here:
(if (not gems) (.say this "test"))
; Results in "Line 1: ReferenceError: gems is not defined"

Unlike in Javascript, you can't use a symbol before it's bound. Here's your if form in a Clojure REPL:
=> (if (not gems) (def gems 0))
=> clojure.core/eval  core.clj: 2927
   ...
             java.lang.RuntimeException: Unable to resolve symbol: gems in this context
clojure.lang.Compiler$CompilerException: java.lang.RuntimeException: Unable to resolve symbol: gems in this context

For some reason though, the interpreter is handling this case in an odd way. I'm assuming that it sees that the (def gems 0) is in there somewhere so it doesn't throw a ReferenceError. Instead it seems that the form using the unbound symbol returns null or undefined:
(if (not gems)
    (def gems 0)
    (def gems 1))
(.say this gems)
; Says "1"

(if gems
    (def gems 0)
    (def gems 1))
(.say this gems)
; Says "1"

(if (+ 1 gems)
    (def gems 0)
    (def gems 1))
(.say this gems)
; Says "1"

Luckily though, all of this can be avoided by simply using (def gems 0) without the if form to begin with. Which makes me wonder why you had the if form there to begin with. In the future, I'd try to avoid using def anywhere inside of another form. I've never seen a reason to put def inside of a form, at least. If you find that you want to, the better solution would probably be using let or set!.

If I recall, I was prepping for the need to create multiple loops after this first one in that board.  In this case, my imperative coding practices have tripped me up!  I totally thought I had found an omission in the "gaining of language functions" for the experimental clojure playthrough.  But nope.  I'll try a few alternate approaches when I run across a weird situation like this, in the future.
Issue can totally be closed, thank you!


OCTO-2181: Implement over time analysis. Time-based SGA

Notes:

Input expects 'date' column in the data, which is a date since treatment.
Converting user specified day can be done in expan service.
Dimension of the cut is 'date', segment is a specific time interval.
User input: {'start': 'start_date', 'end': 'end_date'}. Validation of the user input date makes more sense to move also to expan service.

Coverage increased (+0.04%) to 92.063% when pulling b42746255f6fcecdb5fe5e53ded192e81578898a on daryaded_expan into 615d286cc63ec84cda3956ba4ffb0581f3aa9849 on dev.

Coverage increased (+0.04%) to 92.063% when pulling 7a4441fe8f8423480947be174d500167908b31e6 on daryaded_expan into 615d286cc63ec84cda3956ba4ffb0581f3aa9849 on dev.

will review today!

Coverage increased (+0.03%) to 92.052% when pulling 252d6508b112543551b5adf8c3102a70aa5d7ee4 on daryaded_expan into 615d286cc63ec84cda3956ba4ffb0581f3aa9849 on dev.

Coverage increased (+0.03%) to 92.052% when pulling d5d465412849f99cd8135411fe59928b59a51115 on daryaded_expan into 615d286cc63ec84cda3956ba4ffb0581f3aa9849 on dev.

Coverage decreased (-0.08%) to 91.942% when pulling 4a736e2cfb2e61f2dfd936d1fe7ab5fa516d3d70 on daryaded_expan into 615d286cc63ec84cda3956ba4ffb0581f3aa9849 on dev.

Coverage decreased (-0.08%) to 91.942% when pulling 4a736e2cfb2e61f2dfd936d1fe7ab5fa516d3d70 on daryaded_expan into 615d286cc63ec84cda3956ba4ffb0581f3aa9849 on dev.

Coverage increased (+0.4%) to 92.034% when pulling 6c5d637e7f32e786f93126da07cb5eb800e53703 on daryaded_expan into c9ecaae83605a55891fe7cc85c2ff62fc2423c9f on dev.

Coverage increased (+0.4%) to 92.034% when pulling 55b2749315d2212beb7913bb56e8f1076d9738e9 on daryaded_expan into 9776a69189e813dd797f9de705e30a570dead2e3 on dev.

@daryadedik is this PR in the state for review now?

Update: added variational inference

Coverage increased (+0.4%) to 92.034% when pulling b5a5c99c253e7091f9b236cc0ea5d9f6b586fbc9 on daryaded_expan into 9776a69189e813dd797f9de705e30a570dead2e3 on dev.

Coverage increased (+0.4%) to 92.034% when pulling b5a5c99c253e7091f9b236cc0ea5d9f6b586fbc9 on daryaded_expan into 9776a69189e813dd797f9de705e30a570dead2e3 on dev.

👍


Use full template for generating config file

I configured tool and decided to add more configuration
$ cat smartling.yml
user_id: my-user-id
secret: my-secret
account_id: accountuid
project_id: projectid
threads: 4
files: {}

Unfortunately i don't see any comments and examples. So if i the average user then i will not try to find online documentation or review source code.
Would be nice if we can copy and update our template.

@dimitrystd: Unfortunately, it's not so easy to implement, because current implementation of init will preserve any configuration fields that are already present in config file, e.g. if user changes something in config file and then run init again, that change will be preserved.
So, essentially, there are two choices:

do not preserve contents of config file and overwrite it with default template every time init is executed;
do not preserve comments in config file, but preserve values entered by user.

I vote for the 1st option (don't preserve content). It was cool to see existing data and just hit enter. But it's init command, not setup or update which supposed to preserve data.

@dimitrystd: fixed.


⚠ WSINGRESOS - OXXO has degraded performance

In 42b9482, WSINGRESOS - OXXO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/compartido/wspagosoxxo.r) experienced degraded performance:

HTTP code: 200
Response time: 6468 ms

Resolved: WSINGRESOS - OXXO performance has improved in ec96fa6.


issue #10 fix missing name key

Added non-empty validation to pullImageSecrets. This should fix issue #10.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: lennartschoch sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

LGTM

Could you raise the same PR for master as well

Will do so :)


Add simple snippet to print out object locations

This will print out which file defines which object. I have found this quite useful for porting my Julia code to use @from.
Cheers,
Miles

(FYI @Roger-luo -- this is something Miles and I were chatting about offline, so this isn't out of the blue.)
Hmm, it doesn't seem to work for me. When I try running it on top secret project we're collaborating on I just get src/src.jl printed out to less.

Weird, when I run it on that project, I do see everything get printed out.
What shell are you using? Also you wouldn't happen to have neovim aliased to vim, would you?

Shell is bash. I don't think neovim is around. The above snipppet just prints out src/src.jl as well. :/ (I don't really have time to debug this now I'm afraid.)

I'm a bit confused on what you want to do here - if you just want to know the file path, why not just find out which module it belongs to and then check out the module path?

@patrick-kidger (once you find time), does the following print all the source code, without the comment lines?
for f in **/*.jl; do echo $f && cat $f | vi - -nes -u NONE -c '%s/#.*//ge' -c ':%p' -c ':q!' | tail -n +2; done

@Roger-luo. To help explain, here's an example output when I apply this to SymbolicRegression.jl:

This shows me which function is defined where. Then I can go through my code, and add the corresponding
@from "Utils.jl" import debug_inline

wherever I need some object.
For small projects, of course one can usually remember what function is defined in which file. But for larger ones, it's hard. This makes it easier to port large projects to FromFile.jl. It was difficult at first to port SymbolicRegression.jl to use @from, but once I printed out this listing of which function comes from where, it was a lot faster.
Does that make more sense?

Printout:
src/src.jl
using FromFile
@from "datasets/datasets.jl" import datasets
@from "models/models.jl" import models
@from "train/train.jl" import train

I do have vim installed. (Would be hard to get by without it.)
Maybe try running your snippet on any of a few other machines available to you, see if you can reproduce the behaviour?

Okay, good. It looks like it's actually working! The issue here is just that there are no objects defined in the src directory (in our super secret project).
In principle **/*.jl should do a recursive glob, but apparently not on macOS. The ** for recursive searches was introduced in bash v4 (2009), but Mac never updated to v4 because it's GPL licensed (I use zsh so didn't notice this). Thus, here's a platform independent snippet, which should work for you, using find instead of **:
for f in $(find . -name '*.jl'); do
    echo $f && \
    cat $f | vim - -nes \
        -c '%s/#.*//ge' \
        -c '%s/"""\_.\{-}"""//ge' \
        -c '%v/^\S\+/exe "norm dd"' \
        -c '%g/^\(end\>\|@from\>\|using\>\|export\>\|import\>\)/exe "norm dd"' \
        -c '%g/.*/exe "norm >>"' \
        -c ':%p' -c ':q!' | tail -n +2
done | less

I'll put this in the PR.

Haha, I continue to believe that anything on the command line beyond ls and cd constitutes dark wizardry. (I am completely guilty of using Python scripts in the same way you're using vim here.)
Anyway, basically LGTM -- now runs successfully. (And "it runs on my machine" is apparently the bar to entry here.)


Add documentation for Unity SDK integration

I'd like to see if Greg has any final comments before we merge this


add bootstrap

👷 Deploy Preview for sensational-cascaron-d3919f processing.

Name
Link

🔨 Latest commit
0e9713908264ee185b6c60057a0815eb8839bccb

🔍 Latest deploy log
https://app.netlify.com/sites/sensational-cascaron-d3919f/deploys/65ba94254b58bf000811a667


Vertical alignment of buttons

Minor design issue. Button isn't vertical with input.

draw version? OS and Browser version? i.e. the details in the bug template that you deleted.

Sorry about that, but I didn't get any template. The draw version is 14.0.4 on the web with brave browser Version 1.18.70 Chromium: 87.0.4280.101. I'm also seeing this on the macOS app versioned 13.9.9.

OK, thanks, we'll take a look.

Thanks for the report. This will be fixed in the next release.


Container Registry: added package tag, fixed package tags for java readme

Automation for azure-sdk-for-go

Automation for azure-sdk-for-python

Can one of the admins verify this patch?

Automation for azure-sdk-for-java


Log shuffling deletes shuffled log.

As per title.
I've seen Strippy run with log output that replaces a shuffled log file with a message saying its been shuffled with no other content.
I believe this should have been prepended and the prepend has failed.
please update or remove the message so that logging of Strippy continues normally

Looks like some strange interaction with this line: https://github.com/cavejay/Strippy/blob/0d3e0804ac59ac201c7b02e8d838e25ef8190a3c/strippy.ps1#L183
I would begin by running a few times with very low max log sizes and seeing if the behaviour is repeatable

This issue is seen in version 2.4 from memory.
The version number requires confirmation.

I've been unable to replicate this problem so far - It's possible this is linked to #48 and failed because of a lack of available memory.


fix(searchable): unwrap _version field correctly when datastore is enabled

Description of changes
When datastore is enabled, opensearch must add the _version to the response type.
Issue #, if available
Fixes https://github.com/aws-amplify/amplify-cli/issues/9632
Description of how you validated changes

yarn test
manual test

Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #9694 (58cb5e0) into master (1239734) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9694   +/-   ##
=======================================
  Coverage   52.90%   52.90%
=======================================
  Files         830      830
  Lines       45948    45948
  Branches     9812     9812
=======================================
+ Hits        24308    24309    +1
+ Misses      19628    19627    -1
  Partials     2012     2012

Impacted Files
Coverage Δ

...-transformer/src/graphql-searchable-transformer.ts
93.43% <ø> (ø)

...earchable-transformer/src/generate-resolver-vtl.ts
90.47% <0.00%> (+4.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1239734...58cb5e0. Read the comment docs.


What is the best way to add tessellation shader support for OpenGL backend?

I found myself in need of terrain rendering optimization and want to use a tessellation shader to reduce the number of rendered triangles.
What would be the best way for me to add support for it?

TBH, after quickly skimming over the GL wiki (https://www.khronos.org/opengl/wiki/Tessellation), you're probably better off not using sokol-gfx at all, since it's not just a new shader stage, but also a new primitive type (GL_PATCHES) and this requires pretty deep cuts into the shader, pipeline and draw code (so almost everything).
Normally one can get pretty far with custom requirements by mixing OpenGL calls with sokol-gfx calls, but in this case that might not be worth it because you'd need to re-implement too big parts of the sokol-gfx GL backend.
Also, don't count on tesselation support ever making it into sokol-gfx, at least not until WebGPU has figured out a way to abstract this over the various backend APIs (and then it's still an open question whether this programming model can be wrapped over D3D11 and desktop GL too): https://github.com/gpuweb/gpuweb/issues/445

@floooh thank you for your insight! Other time then.


Make status use status_params

This moves everything needed to run status commands to a new status_params.py script. This matches more closely with how upstream Ambari services are defined.
Bonus points:

This is a snapshot of the current running state of a test Ambari instance. There is a little bit of cleanup needed, but I wanted to get this out there.

minor comment, not blocking. :+1: lgtm


global.json 5.0.100-preview.5.20251.2

where can 5.0.100-preview.5.20251.2 be downloaded to allow the package to build in VS or is it safe to change the version to the currently available public preview.4

See https://github.com/microsoft/reverse-proxy/blob/master/README.md#build


Kodi no longer work

Home Assistant release (hass --version):
0.38.3
Python release (python3 --version):
Python 3.4.2
Component/platform:
media_player/kodi
Description of problem:
platform kodi seems no longer work
Expected:
Creation of player in frontend, be able to send command to Kodi
Problem-relevant configuration.yaml entries and steps to reproduce:
media_player kodi2:
  platform: kodi
  host: http://<IP_ADDRESS>
  port: 8080
  name: Cucina
  turn_off_action: reboot

Traceback (if applicable):
17-02-15 10:42:14 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.4/asyncio/tasks.py", line 237, in _step
    result = next(coro)
  File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/helpers/entity_component.py", line 336, in _async_process_entity
    new_entity, self, update_before_add=update_before_add
  File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/helpers/entity_component.py", line 181, in async_add_entity
    yield from entity.async_update()
  File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/components/media_player/kodi.py", line 148, in async_update
    self._players = yield from self._get_players()
  File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/components/media_player/kodi.py", line 124, in _get_players
    return (yield from self._server.Player.GetActivePlayers())
  File "/home/homeassistant/.homeassistant/deps/jsonrpc_async/jsonrpc.py", line 24, in send_request
    response = yield from self.request(data=request_body)
  File "/home/homeassistant/.homeassistant/deps/aiohttp/client.py", line 577, in __iter__
    resp = yield from self._coro
  File "/home/homeassistant/.homeassistant/deps/aiohttp/client.py", line 213, in _request
    proxy=proxy, proxy_auth=proxy_auth, timer=timer)
  File "/home/homeassistant/.homeassistant/deps/aiohttp/client_reqrep.py", line 73, in __init__
    assert isinstance(url, URL), url
AssertionError: http://<IP_ADDRESS>:8080/jsonrpc

Additional info:

Can confirm....seeing this on 0.38.3

Same and my logs are basically the same. Kodi was working normally in 0.38.2

I think it is a bug in depence of aiohttp -> yarl. That give a new update todaty

@pvizeli The AssertionError appears for other components as well. See my error logs - https://hastebin.com/banuveyadi.sql.

https://github.com/KeepSafe/aiohttp/issues/1635

Can't see anymore the stream of a mjpeg camera (snapshot working instead)... probably for the same bug in aiohttp assuming @pvizeli is right

Same issue, after upgrade.

Deleting the yarl folders inside the deps folder takes care of the issue (at least temporarily).

Deleting did not correct it for me.
However, after deleting them I re-ran the update install for HA. It then installed yarl 0.9.6 and both Kodi and my generic cameras are now working.

try pip install yarl --upgrade

I reran HA upgrade, which upgraded yarl to 0.9.6, but I am still getting the same error. I also ran pip install yarl --upgrade and Kodi still doesn't work.
My log:
17-02-15 16:38:31 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.4/asyncio/tasks.py", line 237, in _step
    result = next(coro)
  File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/helpers/entity_component.py", line 336, in _async_process_entity
    new_entity, self, update_before_add=update_before_add
  File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/helpers/entity_component.py", line 181, in async_add_entity
    yield from entity.async_update()
  File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/components/media_player/kodi.py", line 148, in async_update
    self._players = yield from self._get_players()
  File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/components/media_player/kodi.py", line 124, in _get_players
    return (yield from self._server.Player.GetActivePlayers())
  File "/home/hass/.homeassistant/deps/jsonrpc_async/jsonrpc.py", line 24, in send_request
    response = yield from self.request(data=request_body)
  File "/home/hass/.homeassistant/deps/aiohttp/client.py", line 577, in __iter__
    resp = yield from self._coro
  File "/home/hass/.homeassistant/deps/aiohttp/client.py", line 213, in _request
    proxy=proxy, proxy_auth=proxy_auth, timer=timer)
  File "/home/hass/.homeassistant/deps/aiohttp/client_reqrep.py", line 73, in __init__
    assert isinstance(url, URL), url
AssertionError: http://<IP_ADDRESS>:8080/jsonrpc

Remove your dept Folder inside homeassistant

It's working now, thanks!

ok, everything's back to work now! Thanks


Add DecisionTree estimators into API reference

Currently DecisionTree estimators are missing on master. Lets add them in!

Aha, thanks for filing this! Will do.


Stream fails to disconnect on error

Stream hangs and fails to properly disconnect and reconnect on errors like:
{
  "errors": [
    {
      "title": "operational-disconnect",
      "type": "https://api.twitter.com/labs/1/problems/operational-disconnect",
      "disconnect_type": "OperationalDisconnect",
      "detail": "This stream has been disconnected for operational reasons."
    }
  ]
}

Fixed?


Add default translations to generated methods - enhancement request

This is a problem we are facing at this point with our common tests. Since the Android side of our kmm project requires an Android Context object, which is not available for our common kotlin tests, this causes our test to be unable to load strings for our translations and our tests to fail. We'd really like to run common tests for our common kotlin classes. If your code generator would insert the default locale string value (defaultLanguage.set("en")) instead of the "" in the generated Android files then when an android context wasn't available they could still return the default string for the locale. I don't know the details for all of the other platforms but am hoping a similar solution could be available for them as well.
For example in the KMMResourcesLocalization.kt file that is generated for Android we have this line
actual fun L.CalendarEvents.chair(): String = localizationContext?.getString(R.string.l_calendarEvents_chair) ?: ""
if your generator could (possibly guarded by a new config property) auto-generate this line instead:
actual fun L.CalendarEvents.chair(): String = localizationContext?.getString(R.string.l_calendarEvents_chair) ?: "Chair"
including the default locale value rather than the empty string, then our common tests would be able to leverage this when running in the default locale to extract the required strings for content validation.

Thanks for the info. This sounds like a nice addition. We already have the default language so this should not be an issue implementing this. I am going to look into this.

Thanks for your consideration, we'll be happy to beta test the changes when you're ready :-)

I have a first implementation ready (not published yet) and want to share some details of how the default translations are generated (all taken from the included sample project, defaultLanguage is NL in this case):
A simple string property is generated as follows
actual fun L.ExampleContent.Pages.Page1.body(): String = localizationContext?.getString(R.string.l_exampleContent_pages_page1_body) ?: "Body pagina 1"
Translation with arguments:
actual fun L.General.withParams(value0: String, value1: String): String = localizationContext?.getString(R.string.l_general_withParams, value0, value1) ?: "Een $value0 tekst met een $value1"
A basis list:
actual fun L.General.basiclist(): List<String> = listOf(   localizationContext?.getString(R.string.l_general_basiclist0) ?: "optie 1",   localizationContext?.getString(R.string.l_general_basiclist1) ?: "optie 2" )
List of objects:
actual fun L.Listofobjects.Categories.Samplecategory.Content.body(): String {    val context = localizationContext    return context?.getString(context.resources.getIdentifier("l.listofobjects.categories.samplecategory.content.$index.body", "string", context.packageName)) ?: "Dit is de body1" } actual fun L.Listofobjects.Categories.Samplecategory.Content.title(): String {    val context = localizationContext    return context?.getString(context.resources.getIdentifier("l.listofobjects.categories.samplecategory.content.$index.title", "string", context.packageName)) ?: "Dit is de titel1" }
To enable the genration of the default translation the property useDefaultTranslationIfNotInitialized must be set to true in the kmMResourcesConfig section in the Gradle build file. This is to make sure that the context is forgotten
to be initialized and you only see the default translations.
Is this something you can work with?

Yes, this will meet all of our needs at this time.

I have release version 1.0.0-alpha07 with the changes implemented as described above. Could you test it if this works for you? Don't forget to set useDefaultTranslationIfNotInitialized.set(true) in the mkkResourcesConfig (see Readme)

Its working great! Thank you so much.


tictactoe/handler.py: Fix Python syntax error

Woot!  Sorry about the DCO pain.
@dhh1128 -- can you please review this, since it is your code.


Deploying Cloud Foundry  error, time out pinging error.

Dear all,
could you pls help with below issue?
I dont know how to fix it.
Thanks.
Regards.
Jacko
Please review all changes carefully
Deploying
Are you sure you want to deploy? (type 'yes' to continue): yes
Director task 5
Deprecation: Ignoring cloud config. Manifest contains 'networks' section.
Started preparing deployment > Preparing deployment. Done (00:00:00)
Started preparing package compilation > Finding packages to compile. Done (00:00:00)
Started compiling packages
Started compiling packages > haproxy/ad6e9e08a6d7a0f8951322f9a2ce394105df7fcf
Started compiling packages > rootfs_cflinuxfs2/db8b8575d6f9fc57d470e1a8f0172f4f39e84d2b
Started compiling packages > nginx/31a4f3d6f880b63a097af7a462339410ca0156bc
Started compiling packages > ruby-2.3/ca5b2d16eac54f907ab6c1f454d9c81560f311a2
Started compiling packages > libpq/7e51aa75bcabc47002eccc38be269de63fc6df7d
Started compiling packages > libmariadb/90d7836132e02bb570d91f08c9e116c394888d75
Failed compiling packages > libpq/7e51aa75bcabc47002eccc38be269de63fc6df7d: Timed out pinging to 4876fd6f-7e93-4cb8-8068-25185945ad2e after 600 seconds (00:11:04)
Failed compiling packages > ruby-2.3/ca5b2d16eac54f907ab6c1f454d9c81560f311a2: Timed out pinging to dd24dc48-fdd9-445c-80c5-f0ee9d7c98eb after 600 seconds (00:11:05)
Failed compiling packages > haproxy/ad6e9e08a6d7a0f8951322f9a2ce394105df7fcf: Timed out pinging to ca7e8a34-bdc6-4eb5-bf64-da56c27abd33 after 600 seconds (00:11:26)
Failed compiling packages > rootfs_cflinuxfs2/db8b8575d6f9fc57d470e1a8f0172f4f39e84d2b: Timed out pinging to d5477b08-6bce-4f98-b341-7fff579fd90a after 600 seconds (00:11:30)
Failed compiling packages > libmariadb/90d7836132e02bb570d91f08c9e116c394888d75: Timed out pinging to 25cf5700-716d-4f64-b95a-44cf16439d53 after 600 seconds (00:11:30)
Failed compiling packages > nginx/31a4f3d6f880b63a097af7a462339410ca0156bc: Timed out pinging to 660ae8c5-64d0-4a04-82e2-05a2845b04fe after 600 seconds (00:12:49)

Hi - this is usually due to firewall misconfiguration. Take a look at https://bosh.io/docs/tips#unreachable-agent for some specific suggestions on how to investigate this issue.

Related to your other comment, if you're expecting your VMs to be created using IaaS-managed network IPs, you should make sure you're using a dynamic network.

Dear dpb587,
during the temperary Vm creation, I saw the VM's ip from vsphere console is <IP_ADDRESS> to <IP_ADDRESS>.
but the hostname /dns name of these vms are unreachable, error is the log we saw in my post.
So the problem is the director cannot access the hostname of the vm , even they are in the same VLAN.
Pls advise.
thanks.
regards
jacko

by the way , you mentioned dynamic network, where shall I config this? during create bosh director or create CF?
Thanks.

Hi,
I would like to ssh to the temporary VM duing deployment and have a look at the log, but I cannot access it via director;
/:~# ssh <IP_ADDRESS>
The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is 69:6a:e7:be:f5:26:dd:ed:d2:3f:8b:da:5e:5b:d8:02.
Are you sure you want to continue connecting (yes/no)? no
Host key verification failed.
/:~# ssh <IP_ADDRESS>
The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is 69:6a:e7:be:f5:26:dd:ed:d2:3f:8b:da:5e:5b:d8:02.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Unauthorized use is strictly prohibited. All access and activity
is subject to logging and monitoring.
<EMAIL_ADDRESS>password:
pls advise.
thanks.

It’s recommended to start a deploy again and SSH into one of the VMs and look at the Agent logs while the Director waits for VMs to become accessible. See director.debug.keep_unreachable_vms property to let Director know to leave unreachable VMs for easier debugging.
could you tell me how to access the VM via SSH?


Add TestVerifyMisbehaviour using mock vm for 08-wasm

Summary
Add a TestVerifyMisbehaviour. See this commented out test. There is no equivalent test using the grandpa client.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

for the mockVM contract api, this test will actually just be testing VerifyClientMessage

Closed by #4921


[StdlibUnittest] Make output for expected crashes less fatalistic

What's in this pull request?
A small change that disables printing stderr for expected crashes in StdlibUnittest
For example:
$ cat t.swift
import StdlibUnittest

TestSuite("Foo").test("bar") {
  expectCrashLater()
  assert(false)
}
runAllTests()

Would print:
$ ./t
[ RUN      ] Foo.bar
err>>> assertion failed: file t.swift, line 6
err>>> CRASHED: SIGILL
[       OK ] Foo.bar

Which is problematic, because at a glance it looks like a failure.
With this change, it prints:
$ ./t
[ RUN      ] Foo.bar
[       OK ] Foo.bar

Resolved bug number: rdar://18081448

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@benlangmuir

I tend to disagree... you really want all output possible from the CI in the log.
I'd rather have us look for better way to present the information.

Some suggestions off the top of my head for improving presentation:

Don't prefix with "err>>>".  That makes it sound like an error.
Replace CRASHED: SIGILL with something like "OK: saw expected crash sigill"

If we can make the most important information (did it pass) more obvious and the less frequently used information (what was printed to stderr when it crashed even though we expected the crash) less LOUD in the output I think it would go along way.

Don't prefix with "err>>>". That makes it sound like an error.

We can replace "err>>>" with "stderr>>>", that's what it is supposed to stand for.

Replace CRASHED: SIGILL with something like "OK: saw expected crash sigill"

Good idea!

I agree with all of that. Updated that (and the requisite tests)

LGTM

@swift-ci Please test

LGTM!

Thanks @harlanhaskins!


Prototype a new token representation

Just a prototype of a new token representation. This new one nearly supports a superset of PCRE, Oniguruma, and UTS#18. Omissions are mentioned at the bottom.
The idea is to store and traffic in TokenStorage and project a Token for ease of use.
I'm thinking of having the lexer continue to track whether it's in a custom character class, so that it can produce richer tokens. The actual logic of what token to project based on that bit can be separated out, see projectToken().

Quantifier was looking pretty good so I made it the AST representation. The AST here is like NewToken, that is it is ideally a simple projection on top of more sophisticated storage that includes source locations, etc. We'll have to see how the design pattern works with indirect enums.

If at any point in time someone wants to start building on top of this, let me know and I can whip it into mergeable shape.

@hamishknight can you do a pass over Token2.swift to see if there's anything in there that we don't currently support? Then I think I can close this  fully.

I think we have everything from Token2.swift


not able to train on different data set using the pretrained model

Thank you for sharing the work with us.
I'm trying to generate a new dataset with image size 128x32, but after loading the model 'checkpoints-33', and run self.trainBatch, I have dimensionality issue.
`tensorflow.python.framework.errors_impl.InvalidArgumentError: Conv2DCustomBackpropFilter: filter and out_backprop must have the same out_depth
[[node gradients/convolution_grad/Conv2DBackpropFilter (defined at D:\work\ocr-prescription\python\ocrPrescription\SimpleHTR\src\model.py:51) ]]
Errors may have originated from an input operation.
Input Source operations connected to node gradients/convolution_grad/Conv2DBackpropFilter:`
It is about the image dimension size? What is the train dimension size?

Image shape is 128x32 for training in single-word mode, and 256x32 in multi-words mode.
I suggest to check what the shape of the tensor fed to the NN during training looks like.


Create seed_roles_and_permissions_table.php

To seed the roles and permissions to tables as suggested in Usage.
To do data seeding using migrations

I'll think this one over


"afrom_texts" method implemented for vectordb base

@hrisikesh-neogi this seems to do multiple separate things, could you provide some context

Just it needs some recheck


Invisble entity suggestions

Hi,
I have two suggestions:

We can just set a living entity invisible, it would be great if we could hide all entity likes projectiles, items on ground...
It would be great also if we can choose that when we hide a player we can remove or keep the player in tablist.
I made these suggestions because some people and also me encountred these problems with bukkit api.
Thanks,

@Lightoner There is already a tab list API.

It's a solution for the second point but I think it would be usefull and more simple if sponge can do this.

Pull request https://github.com/SpongePowered/SpongeAPI/pull/387 originally did this, but later changed to only set invisibility on Living entities because the vanilla renderer ignores the flag for non-living entities.
See https://github.com/SpongePowered/SpongeAPI/commit/4dd045122956e58ad8948cbf8da3dec9d11aa19a

@Lightoner Why do you want to hide items/projectiles on the ground?
Some kind of hidden treasure?
If you just want to hide the projectiles after a big fight, then you should remove them directly.

I would like to do multiple fights in one arena.
So this why I don't want to hide the player in tablist and hide projectiles, items on ground...

I want to hide projectiles, items on ground.

You should remove entities when they're on the ground then.

In fight I would like to let's pick up item and see the projectile shot.

As mentioned in the other PR, it isn't possible to set non-living entities to be invisible. It is not our intention to make changes such as this, let alone possible at this time.

It sounds like instead of having multiple copies of an arena, Lightoner wishes to "shard" the world having players and entities only able to interact with players and entities in the same shard.http://www.wowwiki.com/Phasing

Yes.
Okay for the first point and the second ?

@Lightoner Don't use invisibility for that, it's client side only. The entities are still seen by the client, they just aren't rendered.

@AlphaModder considering its packet manipulation, aren't they invisible to the client entirely? its not the same as applying thr potion effect. haven't worked with packets much, so excuse me if that's wrong.

@Xemiru It's not packet manipulation. It's a flag on the entity that tells the vanilla renderer to ignore it.

For hide non living entity I am going to do likes EntityHider from protocolLib so. And for the tablist api, when I hide a player to another player I can re-add the player to the tablist and when I show the player I remove the player from the tablist and after sponge re-add the player to the tablist ?
But when I re-add the player to the tablist Can I Complete his name in chat or command ?


Extend 5.3.0 release notes with non-deterministic generated column behavior change

Shouldn't backport this to the 5.3 branch?


[Feature]: New icons

Describe the Feature
Add new icons because the current icons look very similar due to the color effect.

reworked icons in versions 1.18.2-<IP_ADDRESS> & 1.19-<IP_ADDRESS>


cluster-aws/cluster-eks: Duplicate subnet map keys should be an error

This problem was already observed in https://github.com/giantswarm/roadmap/issues/3048, but it wasn't clear why it happened. It turned out that a duplicate subnet name was used. See also another chat.
E0119 07:12:45.186110       1 controller.go:324] "Reconciler error" err="failed to reconcile network for AWSManagedControlPlane org-giantswarm/vac2eks: failed to patch conditions: AWSManagedControlPlane.controlplane.cluster.x-k8s.io \"vac2eks\" is invalid: spec.network.subnets[7]: Duplicate value: map[string]interface {}{\"id\":\"\"}" controller="awsmanagedcontrolplane" controllerGroup="controlplane.cluster.x-k8s.io" controllerKind="AWSManagedControlPlane" AWSManagedControlPlane="org-giantswarm/vac2eks" namespace="org-giantswarm" name="vac2eks" reconcileID="68cd2eb8-0587-4f93-ad88-c3e24a554bb5"

The error is "silent". The cluster status shortly shows NatGatewaysReconciliationFailed/RouteTableReconciliationFailed but then continues after some minutes and successfully creates a cluster.
@calvix noted in chat that this might relate to the secondary subnet AWSManagedCOntrolPlane.spec.secondaryCidrBlock which we assign to pods.
Not sure if this applies to the cluster-aws chart, but since it also has the subnet id field naming logic, let's check there as well.

issue fixed in our cluster-eks chart still might be worth consider if there should be some kind of fix in the upstream controller or if this is cause of new subnetID change and our way how we specify subnet ID in our charts.

Released in https://github.com/giantswarm/cluster-api-provider-aws-app/releases/tag/v2.16.0
Upstream PR: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4930


fix: Fixed build errors

Are you sure it wasn't that @floating-ui/core package that should be installed? Just checking because we should maybe fix this in @fabric-ds/core, too.

core is imported in dom so I guess it just magically works with npm? 🤷  I think we should leave fabric as it is... and if any problems with the new setup we will notice when using warp-ds/core in the other repos? 🙂


Pub/Sub sample integrations tests are flaky

See: https://travis-ci.org/spring-cloud/spring-cloud-gcp/builds/402396867
@dmitry-s PTAL

I believe this was fixed by #872. Closing.


how to compile android template for arm 64 in 2.1.5 release?

Godot version:

2.1.5
OS/device including version:

android
Issue description:

how to compile android template for arm 64 in 2.1.5 release?
in godot doc 2,1 only mention arm and x86

It's not possible currently. The changes done for arm64 support in the master branch need to be cherry-picked for 2.1.x and 3.0.x.
Closing as duplicate of #25030.


Core/198/handle stale transactions

WIP needs tests -- addresses #198

[Current coverage][cc-pull] is 85.45%

Merging [#359][cc-pull] into [master][cc-base-branch] will decrease coverage by 2.69%

@@             master       #359   diff @@
==========================================
  Files            18         18
  Lines          1240       1292    +52
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1093       1104    +11
- Misses          147        188    +41
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [77c08fb...521345a][cc-compare]
[cc-base-branch]: https://codecov.io/gh/bigchaindb/bigchaindb/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/bigchaindb/bigchaindb/compare/77c08fb978460ad9252e5c164d641506e61658f2...521345ab5b800bfdc4736671bdc01df2c0c8f69f
[cc-pull]: https://codecov.io/gh/bigchaindb/bigchaindb/pull/359?src=pr

Ok i don't know how to fix the test coverage.  The only two untested lines left are the configuration.  I've tried adding backlog_reassign_delay in test_commands.py and test_config_utils.py in the last two commits but apparently that's not helping. Suggestion?

Another thing that is missing is that the block creation pipeline now needs to also listen for updates,

cc @vrde
This is failing right now because the UPDATE from the changefeed returns {"old_val": ..., "new_val": ...} instead of the transaction
Two solutions would be:

change the ChangeFeed class to return only new_val
in block.filter_tx check if its a transaction or update notification and to tx = update['new_val']

works on my computer so I think we are good to go :+1:

works on my computer so I think we are good to go

:joy:


Evaluate various UI frameworks

Deer should reuse UI components provided by various UI frameworks. Evaluate frameworks to zero in on any one framework that would predominantly be used in Deer.

What about using Ant-design (https://ant.design)? @Venkat5694

Ant-design definitely seems to be the most mature/extensive design framework among the ones we considered. I agree with @abahmed on this. Let's get the wheel rolling on our bare-bone UI.


Proxy settings for Azure Arc server

If the version of Az.ConnectedMachine module is the latest version, the following sample will generate an error.
$settingsString = '{"proxy":{"mode":"application","address":"http://[address]:[port]","auth": true}}';
$protectedSettingsString = '{"proxy":{"username":"[username]","password": "[password]"}}';

New-AzConnectedMachineExtension -Name AzureMonitorWindowsAgent -ExtensionType AzureMonitorWindowsAgent -Publisher Microsoft.Azure.Monitor -ResourceGroupName <resource-group-name> -MachineName <arc-server-name> -Location <arc-server-location> -Setting $settingsString -ProtectedSetting $protectedSettingsString

Error message :

New-AzConnectedMachineExtension: Cannot process argument transformation on parameter 'Setting'. Cannot convert the "{"proxy":{"mode":"application","address":"http://xxxxx:8080/","auth": false}}" value of type "System.String" to type "System.Collections.Hashtable".

Probably because the parameter type was changed from IAny to Hashtable.

The contents of this sample must also be changed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd3dca2f-629d-36e9-f0f0-8c7e64cc04ab
Version Independent ID: f40ee991-6cb8-1eee-9a35-ebc5833d7c7f
Content: Azure Monitor agent overview - Azure Monitor
Content Source: articles/azure-monitor/agents/azure-monitor-agent-overview.md
Service: azure-monitor
Sub-service: agents
GitHub Login: @bwren
Microsoft Alias: bwren

@jun110 Thanks for your feedback! We will investigate and update as appropriate.

@jun110, thank you for bringing it to our attention. I am assigning this issue to our content team for review.
@bwren, can you please review this issue and share your thoughts. Thank you

#assign: guywi-ms

#ressign: guywi-ms

#reassign: guywi-ms

@jun110 Thanks for providing feedback that helps improve our documentation! We've created a PR to address this issue and the updates should be public shortly. #please-close


unable to apply dark theme on github pages

including blog_theme: dark in config, no results on github pages after build. Still light theme.
Built on windows 10.
First issue so lmk if I need to supply more.

@KST123ABC do you get the dark theme locally? Remember that chalk does not support standard Jekyll hosting as it is using unsupported plugins.

@nielsenramon thanks for responding.
I may be doing something wrong as this is my first time using a Jekyll theme that is unsupported.
Is there a different repo for the dark theme?
I cloned this repo, edited the config, and then attempted to generate the site.
Thanks for your help! :)

@KST123ABC Did you execute the installation instructions which is stated in the readme of Chalk? And did you manage to run your project locally?

@nielsenramon I have been the README. I receive an error now when I run the Jekyll bundle server command

@KST123ABC That error is about a file you are referencing and jekyll can't find it.

@nielsenramon hello. I do not believe I added any references to other files. I haven't modified anything in this pull.

I may try it on my Linux machine rather than windows... will keep you posted.

Weird: icon-github.html is not a file in Chalk. :-p

Hey @nielsenramon sorry it took me so long to get back to this. I have been quite busy.
Was never able to get it to build the site files on Windows using Chocolatey but I have had success on Linux.
I am quite new to Jekyll so excuse me if I botch the terminology here.
Attached I have included the successfully hosted site.
When viewing the site on any platform besides for Windows Internet Explorer, the included icon assets for the personal account portion of the theme seem to be inable to display. It looks quite the same on Macintosh osx's various browsers. I was wondering if this problem has been raised.
Again, appologies for my novice-ness and delayed response.
The listed images are examples of chrome on linux, mozilla firefox on windows, and finally IE on windows.
Please let me know if I can be of any help.

@KST123ABC Should be fixed now with latest version on master!

@nielsenramon thanks for the update! Just pulled from master and tried but the icons don't seem to be working. I then downloaded the .woff and .ttf from the source repo https://github.com/driftyco/ionicons
put those in _site/assets/ionicons/* and now the icons appear to work.


Make ready_to_execute channel more general.

Rename ready_to_execute channel to running_status_change reflecting it's broader purpose.
Small re-designs and changes about the interfaces in general
Add own Dispatch type with useful functions on top of the original base class

I see this was updated recently. Is it still a thing? Please let me know if you need more input from me.

This is very much a thing, one that will be updated now that the dependencies are merged :)

But apart from rebasing, the code is ready for review

@Marenz I updated the title to make it more suitable as a commit message. Can you please also update the PR description to be suitable as a commit message body? This will end up in the merge commit.

@llucax anything missing for a merge? :)

Oh, sorry, I didn't see it was updated, will have a look now.


Update grandfather.emit comments

updated comments to probably better reflex result (I did not run this locally). Though I expect the real intention of this one is for x to become its own grandpa.
I dropped my time travel for dummies book somewhere along the time stream so 🤷
P.S. Thank you for the laugh.

Ah makes sense, merged :)


repalce get_dummy with one_hot_encoder and save artifact

make sure the transformer is saved  as pkl for consistency
here some example:
https://stackoverflow.com/questions/46077793/how-to-save-a-custom-transformer-in-sklearn

I deleted transform.py
the one hot encoder is in: src/data/feature_engineering.py
changes are in new branch: feature/data-preprocessing.py

i added artifact_preparation.py and create a pkl for the transformer.
we need to train him again when we will get the original train.csv


Null clients

null chain sync client
null local tx submission client

I converted local tx submission client types to the form we use in the other modules, where a top level type is a newtype wrapper, but I didn't used it in the other type to avoid unnecessary indirection.  I think this gives the right indication of what's the top level API and still avoids newtype boilerplate.

bors r+


nodePackages.clean-css: rename to clean-css-cli

Motivation for this change
Fix #82527 . (cc @JustinLovinger ).
Things done

[x] Followed https://nixos.org/nixpkgs/manual/#node.js - used git add -p to add only relevant updates.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I got 2 PRs' commits mixed, the current set of commits should be relevant only for clean-css-cli now.

Please rework your PR. It now has a merge conflict after PR https://github.com/NixOS/nixpkgs/pull/89184 has been merged

Fixed merged conflicts.

@GrahamcOfBorg nodePackages.clean-css-cli

@GrahamcOfBorg build nodePackages.clean-css-cli

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-in-distress/3604/25

We likely may need to do something with base64 hashes (e.g. apply #89520). Meanwhile, I think, the PR could stick to changing node-packages.json file only.

@veprbl how often does someone run ./generate.sh for the node package set?

Landed as 9a47504fe7cff237d8ecb1c87b21b601ef03f335

@veprbl how often does someone run ./generate.sh for the node package set?

If you are asking for a suggestions, I'm not sure what to tell you. While I was applying this PR and another one, some other upstream dependencies had already been bumped. The way it is now, any PR that regenerates node-packages.nix will pick up irrelevant changes that would always lead to merge conflicts. Perhaps, it would work a bit more predictably if node2nix could fetch some specific snapshot of the npm registry.


Update to scarb 2.6.4

Updates to scarb 2.6.4
Use openzeppelin's components
Update CI
Use rust-based starknet-devnet

This PR also disables the L1 <-> L2 tests. This is done while waiting for Shardlabs to come up with a js wrapper to interact with the devnet and anvil.
Closes #613

thank you @ChaituVR senpai

hello! regarding

This PR also disables the L1 <-> L2 tests. This is done while waiting for Shardlabs to come up with a js wrapper to interact with the devnet and anvil.

You can give a try, feedback for now is quite good:
https://github.com/0xSpaceShard/starknet-devnet-js

@ivpavici thanks ! We had not seen the update was already here. We will be integrating this very soon :D


React-native upgrade doesn't upgrade

🐛 Bug Report
I'm trying to upgrade my projet to 0.59 as it released, but it tries to upgrade to 0.58.6, which is my current react-native version.
$~ > react-native info

  React Native Environment Info:
    System:
      OS: Windows 10
      CPU: (8) x64 Intel(R) Core(TM) i7-2600K CPU @ 3.40GHz
      Memory: 8.01 GB / 15.90 GB
    Binaries:
      Yarn: 1.13.0 - D:\Program Files (x86)\Yarn\bin\yarn.CMD
      npm: 6.1.0 - C:\Program Files\nodejs\npm.CMD

$~ > react-native --version
react-native-cli: 2.0.1
react-native: 0.58.6

$~ > react-native upgrade
You should consider using the new upgrade tool based on Git. It makes upgrades easier by resolving most conflicts automatically.
To use it:
- Go back to the old version of React Native
- Run "npm install -g react-native-git-upgrade"
- Run "react-native-git-upgrade"
See https://facebook.github.io/react-native/docs/upgrading.html
Upgrading project to react-native v0.58.6
Check out the release notes and breaking changes: https://github.com/facebook/react-native/releases/tag/v0.58.0
Successfully upgraded this project to react-native v0.58.6

$~ > react-native --version
react-native-cli: 2.0.1
react-native: 0.58.6

I tried to uninstall and reinstall react-native-cli just in case but didn't change much.

facing the same issue ^

Duplicate of #23866


Line endings end up UNIX style

The script should preserve line endings on the file

Should now be fixed