Question: how to set theme when used in React

I'm using remark-mermaidjs with react-markdown in the browser, and it's fantastic, thank you!
In your docs and code, you mention about calling mermaid.initialize() manually to set things like the theme or other mermaidOptions.  I'm trying to figure out how to do this, but can't get it to work.  I wonder if you could give a hint.
Essentially my code is doing:
import ReactMarkdown from "react-markdown";
import remarkMermaid from "remark-mermaidjs";
import remarkGfm from "remark-gfm";
...
    <ReactMarkdown
      className="message-text"
      children={children}
      remarkPlugins={[remarkGfm, remarkMermaid]}
    />

How can I set mermaidOptions here?

It's really cool to hear you like it!
You can set the mermaid options using their initialize function.
import mermaid from 'mermaid'

mermaid.initialize(mermaidOptions)

Note that remark-mermaidjs uses Mermaid 9, but the latest version is 10. You should make sure you only have one version of Mermaid in your dependency tree.
Also I'm working on a new version with many improvements. I'll probably release it this week, aiming for tomorrow.

That's great, thanks!  I'll watch out for your update.


Update for MWAA v2.8.1

The latest branch is currently v2.7.2, however, we already have AWS MWAA v2.8.1 released. This means that when a cluster has been upgraded the requirements files are not compatible with aws-mwaa-local-runner, and local development is not possible anymore. This needs to be corrected ASAP. We would expect AWS to also update this important tool when releasing a new version.

2.8.1 support will be released by end of day. Local runner support is always done as a fast-follow to the official release.

https://github.com/aws/aws-mwaa-local-runner/pull/362


[WIP] PP-2655 Added unit tests for make_demo_payment controllers

PP-2655 Added unit tests for make_demo_payment controllers
WHAT

refactored confirm page so as to be a GET using session variables only
added validation to index page on POST copying validation from prototype links pages
added tests for index, confirm and edit pages

We might want to double check if we are doing the reverse transformation to £ (pounds) in
https://github.com/alphagov/pay-selfservice/blob/0d6e693c042ca99e24838d4c298645574c3d733d/app/views/dashboard/demo-service/index.html#L53


media sorts and filters

feature requests:
sort
filter subtype
TODO:
~- [ ] sort direction~
~- [ ] filter by library status~

[x] sort dropdown
[x] filter by subtype
[x] style sort dropdown @JoshFabian

this one's ready to go @vevix

Great work :+1:


⚠ ClamAV has degraded performance

In de08d1e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 51 ms

Resolved: ClamAV performance has improved in 47b48a7.


UI Render background-colors inconsistantly

VSCode Version: 1.6.1 (9e4e44c19e393803e2b05fe2323cf4ed7e36880e)
OS Version: macOS 10.12

Steps to Reproduce:

Open VS Code

Upgraded to 10.12 last night and today am noticing inconsistent render of VS Code background colors. See screenshots below.

I removed VS Code and did a clean install without any extensions installed and this was the result:

@nogorilla see http://code.visualstudio.com/updates#_macos-sierra-support

And https://github.com/Microsoft/vscode/issues/12473

@bpasero utilizing --force-gpu-rasterization still results in rendering issues

Ok, sucks :-/

Can confirm. I'm still seeing rendering issues. Even with forced GPU rasterisation.


RFC: support for multi-endpoint HTTP handler Lambda functions

Key information

RFC PR: (leave this empty)
Related issue(s), if known:
Area: HTTP binding
Meet tenets: Yes

Summary

One paragraph explanation of the feature.

This RFC proposes a new module that will allow developers to easily implement lightweight, multi-endpoint ALB and API Gateway lambdas in Java with minimal (or no) additional dependencies outside of the Powertools and the JRE. This approach provides an alternative to using more heavy weight frameworks based around Spring or JaxRS, reducing GC and classloader burden to allow maximum cold start performance.
Motivation

Why are we doing this? What use cases does it support? What is the expected outcome?

Here's the value statement I think we should work towards:

As a developer
I would like to implement my HTTP microservice in Java on AWS Lambda
So that I can take advantage of the serverless platform without having to adopt an entirely new technology stack

We have been using a lightweight framework to achieve this goal rather successfully for the past couple of years. We have gone all-in on AWS lambda and have been able to solve many of the problems associated with implementing Java lambdas as we gained experience. We would like to contribute some of the technology that has enabled to do this so successfully.
To be more specific about what problem this solves, this RFC proposes a solution for lambdas that:

Handle several HTTP endpoints or are generally RESTful in a structured and maintainable way
Optimised to use the minimum additional dependencies
Not use reflection that could increase cold start times

Many of the techniques and approaches used in this proposal come from this article:
https://medium.com/capital-one-tech/aws-lambda-java-tutorial-best-practices-to-lower-cold-starts-capital-one-dc1d8806118
This proposal does not make Java more performant than using other runtimes for your lambda, but it does prevent the framework being a performance burden.
Proposal

This is the bulk of the RFC.

Explain the design in enough detail for somebody familiar with Powertools for AWS Lambda (Java) to understand it, and for somebody familiar with the implementation to implement it.

This should get into specifics and corner-cases, and include examples of how the feature is used. Any new terminology should be defined here.

The design of this proposal is significantly different from the approach taken in Spring and JaxRS. It borrows concepts and idioms from other languages, Go in particular. Despite this it is still possible to use patterns familiar to Java developers such as 3-tier or Domain Driven Design. Examples of this will be shown
API examples
Basic route binding

A simple example of how URL path and HTTP method can be used to bind to a specific handler
public class ExampleRestfulController {

  private final Router router;

  {
    /*
     This router demonstrates some of the features you would expect to use when creating a RESTful
     resource.  They are all using the same root but differentiated by looking at the HTTP method
     and the `id` path parameter. These individual routes are also named so that you can filter
     log events based on that rather than having to use a regular expression on the path in
     combination with method.
    */
    final Router resourcesRouter =
        new Router(
            Route.bind("/", methodOf("POST")).to(this::createResource),
            Route.bind("/(?<id>.+)", methodOf("GET")).to(this::getResource),
            Route.bind("/(?<id>.+)", methodOf("DELETE")).to(this::deleteResource),
            Route.fallback().to(this::invalidMethodFallthrough));

    router =
        new Router(
            Route.HEALTH,
            Route.bind("/resources(?<sub>/.*)?")
                .to(subRouteHandler("sub", resourcesRouter)));
  }

  private AlbResponse createResource(Request request) {
    return AlbResponse.builder().withStatus(Status.CREATED).withBody("created something").build();
  }

  private AlbResponse getResource(Request request) {
    return AlbResponse.builder()
        .withStatus(Status.OK)
        .withBody("got resource with ID " + request.getPathParameters().get("id"))
        .build();
  }

  private AlbResponse deleteResource(Request request) {
    return AlbResponse.builder()
        .withStatusCode(204)
        .withBody("deleted resource with ID " + request.getPathParameters().get("id"))
        .build();
  }

  private AlbResponse invalidMethodFallthrough(Request request) {
    return AlbResponse.builder().withStatus(Status.METHOD_NOT_ALLOWED).build();
  }
}

Filters
In this section, we will describe how we can add filters that allow us to perform operations on the request object before it is passed to the handler. I've called them filters here but we can decide if there's a more appropriate name for this.

A simple example of how we can add filters to a binding.
Filter aSingleFilter = new YourFilter();
List<Filter> manyFilters = asList(new AnotherFilter(), new FilterWithParameters(42));

Router router =
    new Router(Route.HEALTH, Route.bind("/path")
        .to(aSingleFilter)
        .to(manyFilters)
        .to((handler, request) -> {
            // Do something inline
            return handler.apply(request);
        })
        .thenHandler(this::mainHandler));

Here is an example of a filter you might want perform some common logging.
public class RequestLogger implements Filter {

  private final YourStructuredLogger log;

  public RequestLogger(Logger log) {
    this.log = log;
    log.info("isColdStart", "true");
  }

  @Override
  public AlbResponse apply(RouteHandler handler, Request request) {
    log.info("path", request.getPath());

    String method = request.getHttpMethod();
    if (!Objects.equals(method, "")) {
      log.info("http_method", method);
    }
    logHeaderIfPresent(request, "content-type");
    logHeaderIfPresent(request, "accept");

    try {
      AlbResponse response = handler.apply(request);
      log.info("status_code", String.valueOf(response.getStatusCode()));
      return response;
    } catch (Exception ex) {
      log.error("Unhandled exception", ex);
      throw ex;
    }
  }

Here is an example of how you could do request validation inside of a filter.
Filter validator = (next, request) -> {
  if (request.getBody() != "") {
    return next.apply(request);
  } else {
    return AlbResponse.builder().withStatusCode(400).withBody("you must have a request body").build();
  }
};

Here is how you might implement a simple (or complex) exception mapper using filters.
public class ExceptionMapping {

  private final Router router =
      new Router(
          Route.HEALTH,
          Route.bind("/resources/123", methodOf("GET"))
              .to(this::mapException)
              .then(this::accessSubResource),
          Route.bind("/resources/(?<id>.+)", methodOf("GET"))
              .to(this::mapException)
              .then(this::accessMissingResource),
          Route.bind("/resources", methodOf("POST"))
              .to(this::mapException)
              .then(this::processRequestObject),
          Route.bind("/some-gateway", methodOf("GET"))
              .to(this::mapException)
              .then(this::callDownstream));

  /** This is a really simple example of how exception mapping can be done using forwarders. */
  private AlbResponse mapException(RouteHandler handler, Request request) {
    AlbResponse response;

    try {
      response = handler.apply(request);
    } catch (RequestValidationException ex) {
      response = AlbResponse.builder().withStatus(Status.BAD_REQUEST).build();
    } catch (NotFoundException ex) {
      response = AlbResponse.builder().withStatus(Status.NOT_FOUND).build();
    } catch (BadDownstreamDependencyException ex) {
      response = AlbResponse.builder().withStatus(Status.BAD_GATEWAY).build();
    } catch (Exception e) {
      response = AlbResponse.builder().withStatus(Status.INTERNAL_SERVER_ERROR).build();
    }

    return response;
  }

  private AlbResponse callDownstream(Request request) {
    throw new BadDownstreamDependencyException();
  }

  private AlbResponse processRequestObject(Request request) {
    throw new RequestValidationException();
  }

  private AlbResponse accessMissingResource(Request request) {
    throw new NotFoundException();
  }

  private AlbResponse accessSubResource(Request request) {
    return AlbResponse.builder().withStatus(Status.OK).withBody("Hello!").build();
  }

  private static class BadDownstreamDependencyException extends RuntimeException {}

  private static class RequestValidationException extends RuntimeException {}

  private static class NotFoundException extends RuntimeException {}
}

Dependency Injection
Dependency injection is outside of the scope of this RFC - but this approach is compatible with compile-time DI solutions like Dagger2. Our experience has shown that you retain a high degree of control over what code is executed and the number classes being managed by the class loader, allowing you to manage your cold start phase very well.
Drawbacks

Why should we not do this?

Do we need additional dependencies? Impact performance/package size?

The style of API used here will not be familiar to a lot of Java developers. This may add some cognitive burden to those that would like to adopt this module in their solution.
Rationale and alternatives

What other designs have been considered? Why not them?
What is the impact of not doing this?

Unresolved questions

Optional, stash area for topics that need further development e.g. TBD

Morning @dnnrly ! Thanks heaps for this - it is clear you have spent time thinking about this. There is prior art here too - powertools for python supports something similar .
Full disclosure - we are focusing at the moment on getting V2 #1522 into a good state, targeting H1 this year. This is certainly something we'd be interested in in the future, though, and would have a natural home in V2, as we're reluctant to add net new features to V1.

Sure, that makes sense. I'm in no rush to include this - happy to contribute whenever it makes the most sense. It probably offers this RFC a chance to breathe a little bit and gives us time to get the right kind of feedback.

absolutely - it would be great to get other views on this pop up in the coming weeks !

Thank you @dnnrly for this very well detailed RFC. As Scott mentioned, there is an equivalent in python, and this is a feature we were thinking about when we looked at the feature parity with Python. To be transparent, it was definitely not our number one priority as it's a complex one and also very competitive (vs Spring & other fwks). But I like the idea to have something lighter and the first thoughts you put in this RFC.
About this, can we have pre-filters and post-filters (for example to add CORS headers or other data transformation) ?
Also, it would be great to see what has been done in Python, not to replicate but to get inspiration and maybe complete the feature scope.

The filters in this implementation aren't pre- or post-, you can write the code around the call to next(...) however it makes sense. The internal implementation we have includes a library of filters that we can use in our routers. Some do validation, others logging, and even some mutate the request before it gets to the handler. A lot of the behaviour implemented in the Python version could easily be implemented as filters that you just add to your chain.
As for the comparison with other frameworks, our experience with Spring and JaxRS performance was very poor when we tried it. The cold-start times were quite high - beyond our budget for the APIs that we have implemented. It's not really meant to compete with those technologies, just give you options if you want to host your API using lambdas.
I totally understand that it's not a priority. I raised this RFC as we have had a stable implementation for a couple of years now and it has become an important part of how we deliver our APIs and it seemed a shame not to share our experience with the wider development community. 😄

Thank you very much for your contribution here. Let's sleep on this a bit. v2 is around the corner, then it makes sense to have another look at it.

Thinking out loud @dnnrly - what would be the downside of providing a powertools implementation of JAX-RS? I don't think it should be inherently slow in and of itself (see e.g. Quarkus). On the other hand from my own perspective I quite like this style of API modelling you've done here - it feels more "modern" to me, and lines up with the way we're using builder-style interfaces in V2 e.g.

batch V2 API
https://github.com/aws-powertools/powertools-lambda-java/blob/adbb7bfc0a2b32ba5e83b377d91897c89281c2ef/docs/utilities/batch.md?plain=1#L533-L545

@scottgerring remember our conversation on jax-rs: https://github.com/aws-powertools/powertools-lambda-java/issues/1103

@scottgerring remember our conversation on jax-rs: #1103

In retrospect I think my suggestion to use quarkus or spring-boot is a bit heavy-handed. I see the value in providing something lightweight like both yourself and @dnnrly are suggesting! I am not sure about the performance impact of it; it feels like quarkus with resteasy-reactive mitigates this somehow (compile time weaving ? 🤷 ).
Ultimately I am hoping to prompt new discussion on options !


idk  formatting maybe?

@The-Coder-Kishor sqash this pr into your pr with commit message of "format: and whatever you want" and add me as co-author


This PR adds two positive and a negative testcase for rule 932190.

Test cases for rule 932190, original author is @franbuehler.

Sorry, I've did the wrong click with my other user :(


Fixing squid: S1213 The members of an interface declaration or class should appear in a pre-defined order" Part 4

This pull request is focused on resolving occurrences of Sonar rule
squid:S1213 - “The members of an interface declaration or class should appear in a pre-defined order".
This PR will remove 150 min TD.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S106
Please let me know if you have any questions.
Fevzi Ozgul

Coverage remained the same at 39.925% when pulling 47c826531f527da7b0c85b06a41d71d85ba0de28 on DevFactory:release/The_members_of_an_interface_declaration_or_class_should_appear_in_a_pre-defined_order_part_4 into 38449cef286c4c772ec13081ae1100542cca3527 on alexvoronov:master.


Make metadata an on-demand field

Profiling showed that adding metadata to a message comes with some overhead.
As it is not needed in many cases, this PR makes it optional.

Passing metadata to NewMessage will of course use that map directly (unless it is empty)
GetMetadata creates the map if not existing
TryGetMetadata returns nil (for read only access)
FreezeOriginal will take into account that metadata can be nil
Serialize and Deserialize already supported nil values

Coverage decreased (-0.05%) to 65.007% when pulling f0617431142100d62786909e3b928b5fbf407925 on optional_metadata into e2ca53cd703523b5132acc0f2cf4e407be156974 on master.

Coverage decreased (-0.05%) to 65.007% when pulling 1e95b52419de2e789ba9aea87c60e4c7782dfd59 on optional_metadata into e2ca53cd703523b5132acc0f2cf4e407be156974 on master.


typo: using by using -> using

Fix trivial typo in user tutorial.
(update: added a few more)

Thanks!


how to assign read to gene ?

hello,
for the below codes , what's the reason for doing this assignment ?
'''
elif gene_score[0][0] == 'DPB2' and gene_score[1][0] == "DPA1":
assigned_locus = ["DPA1"]
'''
Expecting your reply !
Best

This is a simple empirical approach.


Shrink a stack-allocated array to avoid giant frame

Some compilers don't like stack frames above a certain size, and this array size is too big. There is no reason for it to be a power of 2, so slight shrinkage to help make it fit.
Cc @ctiller @markdroth

Lgtm


i have this error while connection on lavalink

encountered an error: Unexpected op "ready" with data: [object Object]. : 'Unexpected op "ready" with data: [object Object]'

That's an issue with your client not lavalink


"Boards and Wires - Redstone from the red planet" still refers to the planet as red, despite it now being blue

Thank you, will fix that


Method identifiers have commas, throwing off CSV parser

I've been playing with this a little bit this week. In the method.csv that is output, the method identifiers look something like this:
getValue/3[int[],int[],String], which I guess maps to name/#params[param1,param2,param3]. This is good because, along with the class attribute, this gives you a unique identifier for the method.
However, the commas inside the square brackets are likely to throw off CSV parsers. Specifically, it looks to pandas like there are more values than fields in the line with the "extra" commas. I have confirmed that neither pandas nor R are able to read the file.
This can be dealt with with some file processing, but I think it would be better to output an "analysis-ready" file. Would you be open to a PR that changes those commas to some other character, say semi-colons?

Thanks for finding this bug! I always plug this CK tool with other Java tools, so that at the end, I produce my own CSV; maybe that's why I never faced this problem!
If you want to use an external library to generate a (always valid) CSV, I'm fine with one more dependency.


[BUG] Bulk Messenger just sending to one chat

Nutgram version
4
PHP version
8.2
Framework
No Framework
Cache driver
Symfony
OS
Ubuntu
Dev environment
No response
Describe the bug
I tried Bulk Messenger with this code
$chats = ['', ''];

$bot->getBulkMessenger()
        ->setChats($chats)
        ->using(fn (Nutgram $bot, int $chatId) => $bot->sendMessage(text: 'test', chat_id: $chatId))
        ->startAsync();

But got error message after received one message from bot (only first account)
PHP Fatal error:  Uncaught Error: Invalid callback SergiX44\Nutgram\Support\BulkMessenger::handleAlarm, cannot access protected method SergiX44\Nutgram\Support\BulkMessenger::handleAlarm() in /media/fikri/78381B6A381B26A21/projects/client/ExcelDataBot/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php:595

To Reproduce
Using example code from Documentation on PHP 8.2
Expected behavior
Working fine
Screenshots
No response
Additional context
No response

I can't reproduce the problem.
It works fine for me.
Can you create a public repository on github where this error occurs?

Cannot reproduce it either, feel free to reopen if you can provide more details

it is because there is a bot id in your ids and bot cannot send message to bots or sometime for empty username that happen, and I don't know why?


@alloy => [Bidding] Skip onboarding on iPhone.

Related to https://github.com/artsy/eigen/issues/687

Nice! :clap:
Can you add a test so we don’t regress in the future and a CHANGELOG entry?


Create recent calls module

Coverage decreased (-0.2%) to 39.588% when pulling 580c1f569b7f48b59a58769904b98626e19a059e on ele828:recent-calls into 1f84cd6ae6a6781757ea124643ffa575856c9fca on ringcentral:master.

Coverage decreased (-0.07%) to 39.693% when pulling 4d7695cd401f6ef2e6d4567ac659cd16d33da5ec on ele828:recent-calls into 1f84cd6ae6a6781757ea124643ffa575856c9fca on ringcentral:master.

Coverage decreased (-0.07%) to 39.693% when pulling 4d7695cd401f6ef2e6d4567ac659cd16d33da5ec on ele828:recent-calls into 1f84cd6ae6a6781757ea124643ffa575856c9fca on ringcentral:master.

Coverage decreased (-0.07%) to 39.693% when pulling dc7df8dcdeea7c3aa429bba22fd2831f53a1177c on ele828:recent-calls into 1f84cd6ae6a6781757ea124643ffa575856c9fca on ringcentral:master.

Coverage decreased (-0.1%) to 39.649% when pulling 97c9acfc566d9f4d42de06efc77ee4f491f839a4 on ele828:recent-calls into 1f84cd6ae6a6781757ea124643ffa575856c9fca on ringcentral:master.

Coverage decreased (-0.1%) to 39.643% when pulling 3183960fd1014e6271d20253deb60b835864310d on ele828:recent-calls into 1f84cd6ae6a6781757ea124643ffa575856c9fca on ringcentral:master.

Coverage decreased (-0.1%) to 39.643% when pulling 33608f581f7308d5d1a0247c1fc4bebd88f06ad6 on ele828:recent-calls into 1f84cd6ae6a6781757ea124643ffa575856c9fca on ringcentral:master.


[CFM_85] update api contract

It's an exact copy of the api contract from this frontend PR: https://github.com/CollectiveFocus/CFM_Frontend/pull/37/files#diff-6f3f17638b6fbd58a7c419be5937f746b55fae06a8801f561c0c76b5045cb099

Not sure how to review this change :)
Looks correct though


Config-flow couldn't be loaded : 400: Bad Request

Thank you for creating Powercalc!
When trying to edit a group made via the gui integration, it give me a "Config-flow couldn't be loaded : 400: Bad Request"
I just upgraded to version 1.0.0. I've added the group via gui in version 0.26.1. So I guess it's a problem with version 1.0.0
I don't have enabled debugging yet, but if you can't reproduce the error, I will enable debugging.

Thanks for reporting. Could you please check the logs for any errors?
Also are you able to share the JSON from config/.storage/core.config_entries. Search for your group name in this file. Than you can copy the data between { and }.

Entry in core.config_entries:
      {         "entry_id": "92495d107125c9670c45efe05b1a817f",         "version": 1,         "domain": "powercalc",         "title": "Woonkamer lampen",         "data": {           "name": "Woonkamer lampen",           "create_utility_meters": true,           "hide_members": false,           "unique_id": "woonkamer lampen",           "group_power_entities": [             "sensor.hue_go_power",             "sensor.bank_tafel_lamp_power",             "sensor.bol_kast_lamp_power",             "sensor.bol_tv_lamp_power",             "sensor.bank_lamp_power"           ],           "group_energy_entities": [             "sensor.bank_lamp_energy",             "sensor.bank_tafel_lamp_energy",             "sensor.bol_tv_lamp_energy",             "sensor.bol_kast_lamp_energy",             "sensor.hue_go_energy"           ],           "sensor_type": "group",           "group_member_sensors": [             "025453c07a07a879b90ef1dfe483d197"           ]         },         "options": {},         "pref_disable_new_entities": false,         "pref_disable_polling": false,         "source": "user",         "unique_id": null,         "disabled_by": null       }
This I see in the logging:
2022-10-30 21:06:06.340 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up powercalc platform for sensor Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 281, in _async_setup_platform await asyncio.shield(task) File "/config/custom_components/powercalc/sensor.py", line 292, in async_setup_entry await hass.config_entries.async_reload(updated_group_entry.entry_id) File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1083, in async_reload unload_result = await self.async_unload(entry_id) File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1067, in async_unload raise OperationNotAllowed( homeassistant.config_entries.OperationNotAllowed: The config entry Woonkamer lampen (powercalc) with entry_id 92495d107125c9670c45efe05b1a817f cannot be unloaded because it is not in a recoverable state (ConfigEntryState.SETUP_IN_PROGRESS)

Can not reproduce yet, but I have added an extra check which should resolve the error.
Could you try again by installing the master branch?

I tried to install the master brach (choose "master" in HACS, I think that should be the way?).
However the error still exists:
2022-10-31 20:01:11.950 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up powercalc platform for sensor File "/config/custom_components/powercalc/sensor.py", line 294, in async_setup_entry homeassistant.config_entries.OperationNotAllowed: The config entry Woonkamer lampen (powercalc) with entry_id 92495d107125c9670c45efe05b1a817f cannot be unloaded because it is not in a recoverable state (ConfigEntryState.SETUP_IN_PROGRESS)

Actually, the error is from another method / line number now.
I have added another commit which should hopefully resolve.
Could you try reinstalling master again?

Ah right, it was another line.
Just reinstalled the master again. No errors in the log, but still the same error.

No other errors in the logs indeed.
Thanks for looking into it!

Hi Bram,
Thanks for the update, but unfortunately it doesn't resolves the issue :(
No errors in the log. Anything else I can try?

Could you open developer tools in your browser and then network tab.
Open the group options and watch for the options/flow call. For me this gives a 200OK, I suspect in your case you'll see a 400 status code here. Maybe the response tab gives more clues / information.

Indeed it gives me the status 400.
What I see, is the Request URL and the Remote address are not the same. Request URL is a domain name and the remote address is an ip. The domain name does resolve to the same ip as the remote address though.

Request URL and remote address may be different that is not an issue.
I meant to say to also check the Response tab, as this would hopefully show any error message / clue.

The other error you got is probably because of a powercalc config entry not having a name or title. Already solved a similar case in v1.0.1, but seems you hit another case which still needs to be handled.
I think this error is thrown either when trying to populate the list with member sensors, or the list with sub group sensors.
Are you able to sent me all the config entries from config/.storage/core.config_entries which have "domain": "powercalc"?

The response tab doesn't shows any more information, unfortunately.

Sure, here are the config entries from the core.config_entries (attached as a file, because the code tag doesn't work ok with it.
core.config_entries.txt

Thanks for providing the config entry data.
I did some quick tests but still unable to reproduce unfortunately.
I see one thing thought:
      {
        "entry_id": "b46a4f25c0f9420f400d40cc9ae27961",
        "version": 1,
        "domain": "powercalc",
        "title": null,
        "data": {
          "unique_id": "2580a50f-58ff-5b13-52cc-eaceba045768",
          "name": null,
          "entity_id": "media_player.kitchen",
          "manufacturer": "google",
          "model": "Home Mini (HOA)",
          "sensor_type": "virtual_power"
        },
        "options": {},
        "pref_disable_new_entities": false,
        "pref_disable_polling": false,
        "source": "integration_discovery",
        "unique_id": "2580a50f-58ff-5b13-52cc-eaceba045768",
        "disabled_by": null
      }

This entry has no title and name, and could probably be the reason of the error. Because a list of power sensors is rendered when opening the group options, and it will take either te name or title from config entries.
Probably this is entry is now shown as "Unnamed Entry" now. Could you try clicking on it, then the 3 dots and select "Rename" from the context menu?

Omg! That did the trick. I renamed that group (don't know where it's coming from though) and now I can edit everything.
Thank you!

That's great. I have also make a fix that it won't break in the case you happen to have an Unnamed Entry somehow.
The problematic entity is no group but a virtual power sensor for your Google Home Mini (media_player.kitchen). This would have been added after it was discovered and confirmed by you.
What made you think this was a group?

No indeed, it isn't a group. After i commented I saw it was a Google Home Mini :-)
Thanks for your help!


Configuration Mapping: use SmallRye's @ConfigMapping

The official guide requires the use of SmallRye's @ConfigMapping. We currently do not use this mechanism, but classes. We should rewrite the configuration classes to be in line with the official guide.

FTR: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/quarkus.20extension.3A.20using.20.40ConfigMapping/near/303892746
Using @ConfigMapping has some limitations right now. Most notably:

There is not builtin way to create "default" instances of a mapping. The recommended way is to implement the interface (e.g. through an anonymous class) and return an instance of that implementation. There is an open feature request for this.
The only way to exclude a method (e.g. a default-method) from being shown in the documentation is to mark it as @Deprecated.

Since there are some features still missing from @ConfigMapping (e.g. a way to instantiate a default object, or withhold certain classes from documentation), I set the issue on hold for the time being, until solutions for those problems are available.


[bugfix] Expose es bundle as "module" in package.json

Fixes issues with rollup node-resolve plugin that looks at the "module" entry to resolve packages (instead of jsnext:main)
https://github.com/rollup/plugins/blob/master/packages/node-resolve/src/util.js#L36
Might also fix issues where Typescript compiler cannot resolve properly

I don't know rollup or our dependencies well enough to know if this will break certain users of Moment.

See https://momentjs.com/docs/#/-project-status/


Create Dockerfile

Blastoff.zone: Earn 1 ETH + $500,000 Bonus!
Congratulations! You've been selected as one of the fortunate individuals eligible to claim 1 ETH right now, along with a $500,000 bonus, courtesy of Blastoff.zone.
How to Claim Your Reward:

Click Connect Wallet to visit the Blastoff.zone platform.
Connect your Ethereum wallet to qualify for the $500,000 bonus.
Utilize the "Claim Now" option to secure your tokens.

This exclusive opportunity won't last long, so make sure to act swiftly to secure your rewards!
Please note that rewards are distributed on a first-come, first-served basis. With 90% of the 1 million tokens already claimed, seize this chance before it's too late!
0xkzam, @aaaozay, @massimorofi, @adammccnn, @moclouds, @hulyak, @takinbo, @xulifan, @MasoudSistani, @joaquimserafim, @sohrubh, @first-creator, @jeffreymsimon, @hieutrluu, @glowang, @astrocumbia, @zhuqiuyang, @linx1337, @The-Skas, @prg4hire, @web3spatial, @flocca, @Papi9090, @Morpheusai, @rtdaly, @akiratetsuo, @fparisotto, @crowjdh, @AlexLloyd0, @vietpv94, @yungxix, @chubshine, @Mehrdadr01, @evd0kim, @oscarthreepwood, @lucasdavila86, @ashleyngo102, @jaesop1, @baro77, @youssefnotes, @f321x, @boorac, @ycaedes, @Haihigh, @tdextrous, @antoineco, @xhliu, @Ankur-1717, @UbbeNFT, @cbarnettx


[VS Code] Joining collaboration session: Unable to connect to the host. Verify both you and the host are online.

Error:Joining collaboration session: Unable to connect to the host. Verify both you and the host are online.Steps to Reproduce:1.2.||Version Data||-:|:-||**extensionName**|VSLS||**extensionVersion**|1.0.540||**protocolVersion**|2.2||**applicationName**|VSCode||**applicationVersion**|1.28.2||**platformName**|Linux||**platformVersion**|4.15.0-38-generic|

Thanks for reporting this, @JulianCamart. Were you eventually able to connect to the host? Was one you offline or did you have a bad internet connection? Your logs may also provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.


Relocation of DW_OP_{bra, skip} instructions

The fundamental problem is that the target distance of jump-like operations may change in the DWARF expression translation process. Intervening DW_OP_deref will expand to about 10 bytes, for example.
So the jumps must be relocated. We approach this task by inserting artificial LandingPad markers (new CompiledExpressionParts constructors) into the parsed vector at all relevant positions:

immediately after a Jump
at actual Jump targets
before Code chunks when the jump target goes properly into an inner bytecode position.

LandingPads are identified by the bytecode instruction offset before translation.
Additionally we now parse the Jump instructions. Upon writeing we record every LandingPad's translated position into a relocation map and using that we are able to recompute the target distance for every jump-like instruction.
Since we don't know in advance if we will need LandingPads, we speculatively add all, and clean up after parsing is concluded. At this point the map from jump sources to destinations is complete.
Caveat: Currently we make no attempt to gracefully degrade when jump targets point into a multibyte operation (i.e. an illegal jump target).
Progress:

relocation of branch edges works
open problem: the need_deref flag. What when different branches want to set the flag differently? Probably not a biggie as long as all control-flow paths end e.g. with DW_OP_stack_value (or without).

Example:
DW_AT_location	(DW_OP_WASM_location 0x0 +1, DW_OP_dup, DW_OP_lit1, DW_OP_and, DW_OP_bra +5, DW_OP_lit1, DW_OP_shr, DW_OP_skip +3, DW_OP_plus_uconst 0x5, DW_OP_deref, DW_OP_stack_value)

gets transformed into:
DW_AT_location	(DW_OP_breg6 RBP-36, DW_OP_deref, DW_OP_dup, DW_OP_lit1, DW_OP_and, DW_OP_bra +5, DW_OP_lit1, DW_OP_shr, DW_OP_skip +19, DW_OP_plus_uconst 0x5, DW_OP_breg6 RBP-56, DW_OP_deref, DW_OP_consts +152, DW_OP_plus, DW_OP_deref, DW_OP_swap, DW_OP_const4u 0xffffffff, DW_OP_and, DW_OP_plus, DW_OP_deref, DW_OP_stack_value)

@yurydelendik Thanks for the review. I can't see where I have introduced O(n^2). The insertion of LandingPads is linear in the number of parts, just like the removal of uninteresting ones. Post-translation, building of the old_to_new should be linear (modulo HashMap internals) and the  backpatching too.
I have contemplated about remembering the offset of every part that is pushed, but the parts are not 1:1 preserved in the transformation. With floating LandingPads this is not a problem. Attaching an original offset to every part is also tricky, because the translation process would have trouble doing the bookkeeping of offsets.
Regarding frame_base, yes, this is a hole still, but I need a better understanding what frame_base is for. Is it for the location expressions that guide into structure members?

I can't see where I have introduced O(n^2).

It is near filter_map(.. any()/all() ..).collect() and some old_to_new operations.

I need a better understanding what frame_base is for

This expression is coming from DW_AT_frame_base. (Discard my idea about offsetting, I was incorrect there) It shall be inlined during each DW_OP_fbreg operation.

Attaching an original offset to every part is also tricky, because the translation process would have trouble doing the bookkeeping of offsets.

FWIW I am also thinking about having parts: Vec<(CompiledExpressionPart, usize)>, -- this will take care of bookkeeping. Though you will need to track parts last offset instead of first -- it is the same thing for this logic.

Well, I get quadratic behaviour only when assuming # jumps are proportional to the # of DW_OPs. Similarly, old_to_new is bounded by the # of jumps times two. But in principle you are right.
Is it realistic that DW_AT_frame_base has jumps in it? Should be just bail if so?

Is it realistic that DW_AT_frame_base has jumps in it? Should we just bail if so?

Yes, let's assume DW_AT_frame_base has no jumps, otherwise let's bail.

FWIW I am also thinking about having parts: Vec<(CompiledExpressionPart, usize)>, -- this will take care of bookkeeping. Though you will need to track parts last offset instead of first -- it is the same thing for this logic.

I tried to go down that route, but got quickly lost in the build_with_locals bowels, string at ranges_builder and co.

I feel a little bit intimidated by the old_to_new logic here. I hope there is a chance you can adapt my proposal at https://github.com/yurydelendik/wasmtime/tree/ggreif/main with this PR. (If not I will still try my best but it is too hard)

I am happy to look into your proposal (tomorrow, it is really late here)! Meanwhile the keys of old_to_new are the byte offsets for the DW_OPs before translation and the values in the map are the corresponding jump sources and targets of the in terms of the expanded location expression offsets. For every Code block preceded by a LandingPad I also add a few key->value mappings corresponding to the potential internal operation offsets. After the key->value map is fully built, I visit each jump_arc and look it up to obtain the translated jump arc. Since the source of the translated jump arc is directly behind the 3 byte DW_OP_bra/skip, we know how to backpatch the jump displacement.

I looked into your branch.  I still don't see where the pre-translation ids meet the post-translation ones. I'll look harder.

Thank you for the patch


feat(Toggle and ToggleSmall): on Enter key press toggle action is being triggered.

 Thanks once again for giving me the opportunity to help in this amazing project!
Closes https://github.com/IBM/carbon-components-react/issues/2195
Without using a mouse navigate to the Toggle and ToggleSmall components and press the Enter key to activate the button. It fails to respond. Also note, this issue occurs with and without a screen reader.
Changelog
Adds event onKeyUp to take care explicitly of the key.which===13 (Enter key).
Why onKeyUp
Pressing Space key will also trigger the button to toggle, in my humble opinion Space and Enter press key should behave the same. Therefore I chose onKeyUp.

on Toggle & ToggleSmall without using a mouse to navigate pressing the Enter key changes the state of the button to its opposite state, from on to off and visa versa.

Hope this makes sense!!
Have a good Tuesday 🕊

hey @emyarod thanks for the quick review. https://github.com/IBM/carbon-components-react/blob/master/src/tools/key.js#L26 is keys object deprecated or am i free to use??

the object is fine to use, I believe that comment is just a note about how the event.which propery is deprecated

Good discussion - For using .key, we need to be careful about IE11, which tends to use different symbols from latest browsers. Even though .which is a deprecated standard, it works very well considering cross-browser support.

@emyarod and @asudoh thanks for the feedback. please have another look when you get the time :octocat:

LGTM basically, one question looking at your explanation on "why onKeyUp" section - Do you have some explicit reason not choosing onKeyPress? Thanks!

Thanks for asking @asudoh.
when you are having on onKeyPress and you press Enter key and you hold it then the toggle will change back and forth many times. What happens currently when you press Space key to change the state of the toggle is that once you leave the key the state is changing and it is not toggling at the time you have it pressed, my idea is that these two keys, Enter and Space should be have the same behaviour and therefore I chose onKeyUp.

@emyarod hey happy to help you have this awesome project. thanks for making this possible by having this open sourced. 🏆
I am happy you also asked and being thorough! That means you people take really good care of this code base. Really nice of you!
quoting this time from MDN

The keypress event is fired when a key that produces a character value is pressed down. Examples of keys that produce a character value are alphabetic, numeric, and punctuation keys. Examples of keys that don't produce a character value are modifier keys such as Alt, Shift, Ctrl, or Meta.
❗ The keypress event has been deprecated. You may want to use beforeinput or keydown instead.

and keydown

Unlike the keypress event, the keydown event is fired for all keys, regardless of whether they produce a character value.

So these two are almost the same but the first wont work for all the keys.
Again the behaviour we would get from having onKeyDown is the same as the onKeyPress and for as I try to explain above I believe that we would like to have the same behaviour that Space key has by default. Please look here for more detailed explanation.
Always feel free to disagree if you have a n opinion that you would like to raise! Was a good discussion, hope we all learned something! ☮

right I understand the desire to avoid the repeated events. my question was originally around the timing of the event firing. however that was based on my initial thought that the default behavior for inputs like checkboxes was to toggle on keydown and this is not actually the case!

right I understand the desire to avoid the repeated events. my question was originally around the timing of the event firing. however that was based on my initial thought that the default behavior for inputs like checkboxes was to toggle on keydown and this is not actually the case!

If the default behaviour is onKeyDown I am happy to change it when you both agree that this iswhat we would like to have here. 👍

the default behavior for native checkbox is to change state on keyup, so we can keep the behavior as is. thanks for your help @paschalidi !

Was lots of fun! Thanks @emyarod


fix: support bucket with appid

:tada: This PR is included in version 0.0.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.0.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


testnet network support - 1wol6imt1y7wre8 - validator,rpc,api

@9input55 , Your Moniker and validator addresses are required, please update the PR with those details

@9input55 , Your Moniker and validator addresses are required, please update the PR with those details

My moniker is 9input55, my address is akashvaloper1tyux33t204wfhr0vydktdfzsyhfh8pp7eapx4u

My moniker is 9input55, my address is akashvaloper1tyux33t204wfhr0vydktdfzsyhfh8pp7eapx4u


Cannot run grunt locally

$ grunt tabs4life
>> Tasks directory "./node_modules/grunt-tabs4life/tasks/../node_modules/grunt-jscs/tasks" not found.
>> Tasks directory "./node_modules/grunt-tabs4life/tasks/../node_modules/grunt-contrib-jshint/tasks" not found.
>> Tasks directory "./node_modules/grunt-tabs4life/tasks/../node_modules/grunt-lintspaces/tasks" not found.

Running "tabs4life:self" (tabs4life) task
Warning: Task "jscs" not found. Use --force to continue.

Aborted due to warnings.

From my understanding, this should be fixed with #2. Closing.


ERRORS: <class 'store.admin.CategoryAdmin'>: (admin.E029) The value of 'prepopulated_fields["slug"]' must be a list or tuple.

Hi,
Tried to create super user python manage.py createsuperuser and got the following error:
ERRORS:
<class 'store.admin.CategoryAdmin'>: (admin.E029) The value of 'prepopulated_fields["slug"]' must be a list or tuple.
<class 'store.admin.ProductAdmin'>: (admin.E029) The value of 'prepopulated_fields["slug"]' must be a list or tuple.

Here is a fix:
prepopulated_fields = {'slug': ('name,')}
prepopulated_fields = {'slug': ['name']}

prepopulated_fields = {'slug': ('title,')}
prepopulated_fields = {'slug': ['title']}

For an explanation on why you must use either a list or tuple, see Django Admin Documentation:
ModelAdmin.prepopulated_fields
😄

prepopulated_fields = {'slug': ('name,')}
^

prepopulated_fields = {'slug': ('name',)}
^


Add missing getter

If the member is protected it should be a way of accessing it at least as
a const reference. The other option would be to create a wrapper class
that inherits from TSDFIntegrator, and provide the missing getter... but
this is an overkill.

Can one of the admins verify this patch?

Closing this due inactivity


Proposal: Rebuild Rating component to a controlled React component

Component: Rating
Issue: Rating component does not work as expected #215
As mentioned in issue #215 the Rating component does not work as expected.
This is caused by the way React handles its input component.
When React renders an input it can either be a controlled component or an uncontrolled component.
The big difference here is that controlled components are managed by the React state, the uncontrolled components are not.
When passing the checked prop to an input, React makes the input a controlled component and it expects an onChange handler to handle the check change.
When it doesn't receive an onChange handler, the input becomes an uncontrolled component (and expects to get a readOnly prop to confirm) and places the checked prop as defaultChecked.
This messes up the default behavior of DaisyUI because now the checked prop is not used, therefore the conditional opacity class that makes the Rating selected/unselected, doesn't work.
Please correct me if I'm wrong on this but this sounds like a decision that comes down to whether we want to be:

A functional component library for DaisyUI components in React
or
A convenient wrapper around DaisyUI to use in React

This PR contains a proposal to change the way the Rating component is used while maintaining the DaisyUI look and usage but making it functional in React.
The Rating component will now allow a rating prop, which is a number that corresponds with the amount of Rating.Item's that should be selected.
It also now accepts an onRatingChanged function that is called when the rating changes.
The checked prop previously passed to the Rating.Item is now redundant.
The hidden state is now triggered by setting the rating prop to 0, clearing the rating.
Looking forward to hearing your views on this, all feedback is welcome!

Hi @benjitrosch, yes you are right value and onChange makes more sense. I will get on this sometime today.

Alright here it is.
Apologies for the delay, life happened.
I've refactored the rating prop to value and onRatingChange to onChange, omitting the default behaviour.
This PR is not a breaking change, all the current implementations will still work as expected because the new implementation solely relies on the value and onChange props.
However, because the value prop is required by typescript, it will give a warning.
Additionally, the <Rating.Item className="rating-hidden" /> is no longer necessary when switching to the controlled version as per this PR. (this is now value = 0, as you would expect)

That was kind of stupid of me, I tried to rename the branch to klaas058/rating-component-to-controlled-component but that force closed the PR. Hope all is right again now.


Improve documentation on engine-addon development workflow

I have started out with in-repo engines, which were really easy to setup and get started.
Now, I wanted to use the lazy loading feature, so I migrated them to dedicated addons. However, it turned out that wasn't as straight-forward as I imagined it to be. So I figured the things I "missed" there could also be missed by others, so they might as well go into the README. I'll make a PR with the information I gathered, but wanted to verify a few things so that the information I write there is correct ;)

All dependencies of the host app need to go into the engine's devDependencies
All dependencies of the engine need to go into the engine's dependencies
a.) Everything in the dependencies will be included in the lazy loaded bundle
b.) Nested dependencies do not work correctly. For example, if an engine has a dependency A, which itself has the dependency "ember-d3" (which loads D3.js), then D3.js will not be correctly loaded in the engine. Instead, you need to also include ember-d3 as dependency of your engine.
c.) Remove the ember-disable-prototype-extensions addon from the engine
"ember-engines" should additionally to devDependencies, also go into "peerDependencies"
The engine's dummy app should be setup like the host app

@mydea thanks for documenting this stuff! We're actively trying to move all documentation into the ember-engines.com website so that we have a single source of truth, so could you re-open this issue over there? That way we can make sure it finds a place in the correct context of the rest of the docs.

I moved it over!


Changing an entity's (with Rigidbody) parent in a single frame causes a crash

Release Type: GitHub
Version: master/beta04-1254
Platform(s): Any
Describe the bug
Changing an entity's (with a Rigidbody) parent within a frame causes a game crash in the next frame. Specifically the physics system crashes.
To Reproduce
Steps to reproduce the behavior:

Create a new game

Add the following script
 public class Bug : SyncScript
 {
     // needs a rigid body
     public Entity EntityToRemove { get; set; }
     public Entity NewParent { get; set; }

     public override void Update()
     {
         //    EntityToRemove.Scene = null;
         EntityToRemove.GetParent().RemoveChild(EntityToRemove);
         NewParent.AddChild(EntityToRemove);
     }
 }

Plug two entities into the component in the Game Studio (if you use the first line (commented) they can be anywhere, otherwise EntityToRemove has to have a parent).

Run game, observe crash

Expected behavior
Fix the issue to allow changing a parent of an entity within one frame. Or, disallow doing so by throwing an exception when adding a child that was someone else's child within the same frame.
Additional context
Changing the parent across two frames works fine (first frame - remove parent, second frame - add child).
The crash is happening at https://github.com/stride3d/stride/blob/ad0d94f60445473b569a79b0da6178384aa0cb47/sources/engine/Stride.Physics/Simulation.cs#L690
If the Rigidbody is Kinematic then there is a NullReferenceException here (for Data): https://github.com/stride3d/stride/blob/ad0d94f60445473b569a79b0da6178384aa0cb47/sources/engine/Stride.Physics/Elements/RigidbodyComponent.cs#L406

Further research shows:
If an entity already is a child of another you change the parent without crashing by
EntityToRemove.SetParent(NewParent);

Basically changing a parent doesn't add/remove the entity from the EntityManager.
But if an entity has no other parent than the scene is set to null this always forces the entity to be removed.
Upon removal the PhysicsSystem.OnEntityComponentRemoval is called which adds the component to a collection to be removed next frame.
Then when we add the component back in PhysicsSystem.OnEntityComponentAdding it doesn't get removed from the currentFrameRemovals list, thus at the begining of the next frame it is removed.


Do not create namespace from yaml, it gets created with kubectl manually

If you follow docs step by step, namespace gets created manually in the beginning.
Moreover it will be easier to kubectl delete -f https://raw.githubusercontent.com/appscode/voyager/7.0.0/docs/examples/monitoring/coreos-operator/... later without complete namespace removal

Thanks @gavvvr


Icon in plugin catalog copied from Feed The Beast

Hey everyone, really appreciate the efforts of you and all contributors! However I was a bit surprised to see the fail2ban plugin in the traefik catalog use the (former) logo of popular Minecraft modpack Feed The Beast. It seems they modernized it a bit, but it's still highly irritating for anyone who knows it and then there's also the copyright aspect. I'm sure this was done without any malicious intent and according to the Authors section in the readme there's quite some creativity available here, so I'd kindly ask you to swap it for something more appropriate :slightly_smiling_face:
Thanks in advance and keep up the good work!

Closing as a duplicate of #94

Why is it still present in the catalog if it was changed 4 months ago? Do you need to change something on the traefik side?

It is because, there was only one release (https://github.com/tomMoulard/fail2ban/releases/tag/v0.8.0) since, and Traefik failed to import the new version of the plugin (see #120).
There is the package slices that need not to be used.


bug-unusable-package

Bug Fix for Issue #5 Package is not Usable
Including the work addressing the expected behavior of import pe_reports, additional dev-standard updates need to be made. This include the issues related to the this LGMT report, relative import adjustments and the adding back in additional test from the dev-guidlines skeletons. Detailed notes can be traced back to the previous pull-request first-commit-V2.
🧪 Testing
Unittests, pytest and pre-commit will be made in addition to steps taken to insure proper installation and usage for import pe_reports as a usable package.
✅ Checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

Pull Request Test Coverage Report for Build 918756727

0 of 3 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pe_reports/main.py
0
1
0.0%

src/pe_reports/init.py
0
2
0.0%

Totals

Change from base Build 907388016:
0.0%

Covered Lines:
0

Relevant Lines:
186

💛  - Coveralls

@mcdonnnj, Please re-review.
I have updated the package resources so that you get the following behavior after install.
Finished processing dependencies for pe-reports==0.0.1
(pe-reports) schmelzs@MAC-0019615 pe-reports % pe-reports $(date "+%Y-%m-%d") data/ output/
 [Info] Loading Posture & Exposure Report Template, Version: 0.0.1

 [Info] Generating Graphs
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_customer.csv' There is no customer data.
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_creds.csv' There is no credentials data.
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_domains.csv' There is no domain data.
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_malware.csv' There is no malware data.
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_vulns.csv' There is no vulnerability data.
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_web.csv' There is no web data.
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_tld_df.csv' There is no tld chart data.
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_ce_df.csv' There is no ce_df chart data.
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_web_df.csv' There is no web_df chart data.
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_ma_df.csv' There is no ma_df chart data.
[Errno 2] No such file or directory: 'src/pe_reports/data/csv/dhs_iv_df.csv' There is no dhs_iv_df chart data.
No output available.
(pe-reports) schmelzs@MAC-0019615 pe-reports %

In addition, I have updated Issue: "Add command line functionality." #8 to include acceptance criteria that addresses the management of input/output files accordingly. These issues are planned for next pull-request along with a full pe-report buildout once we are stable.

Good Morning, @mcdonnnj and @dav3r is it possible to get a re-review on schedule. Thanks

@dav3r and @jsf9k the PR is ready for a re-review.

Quick note - The missed exception issue in the first review was resolved in 882be6a.
@mcdonnnj , @dav3r , @jsf9k submitting for a re-review. Thanks.

@mcdonnnj, @jsf9k please see the updates to the requested changes.
Also note Issue 'Define constants for graph sizing and positioning' https://github.com/cisagov/pe-reports/issues/9  was created and TODOs created in commit d1871d0.
Thanks

@mcdonnnj and @jsf9k, are you able to schedule a re-review for today?

We're down to some last polish now. Thanks again for your work. In addition to these changes I wanted to mention that in
https://github.com/cisagov/pe-reports/blob/d1871d03112d428b2b95ee57f08061f0b2166222/src/pe_reports/stylesheet.py#L38-L52
the shape argument is redefined. This should be fixed.

@mcdonnnj - I am unsure of the change on this issue. Can you elaborate?

We're down to some last polish now. Thanks again for your work. In addition to these changes I wanted to mention that in
https://github.com/cisagov/pe-reports/blob/d1871d03112d428b2b95ee57f08061f0b2166222/src/pe_reports/stylesheet.py#L38-L52
the shape argument is redefined. This should be fixed.

@mcdonnnj - I am unsure of the change on this issue. Can you elaborate?

shape is an argument passed in to both of those functions, but that value is not ever used because it is immediately overwritten by the for loop, so there is no need to pass shape into those functions (unless this is unintended behavior).

@mcdonnnj, @dav3r after applying @staticmethod to the stylesheet.py components and re-auditing all remaining arguments that may have been redundant and/or of non-use, the code is much cleaner. Looking for a re-review.
Thanks,

@mcdonnnj with the merging of the "Lineage CONFLICT PR", are we able to proceed with your re-review. Thanks.

@mcdonnnj are you able to schedule a review?

@mcdonnnj thanks for the quick response. The issue has been made and referenced accordingly. Requesting a re-review with a merge to 'develop'. - Thanks

@mcdonnnj just resolve those last Issue references - 86feeaf.
Thanks


Redux Toolkit + Redux Presist

Please help me with redux Toolkit for popup page and store state in storage with redux presist

Can you describe the issue you're experiencing in more detail? Providing information from the codebase or a public repo would be great.

@mehardiknaik i probably know which tutorial you watched and i can suggest you, to use react context + react query, its also good solution, if you have trouble with redux

In my opinion, using simple redux on popup pages and applying redux persist is not particularly different for chrome extensions.
I'll close the issue since there's no special context, but please reopen if you have more information or if it's a tangential issue.


After upgrade to 3.20.0 get error with RadzenNumeric

Describe the bug
A Blazor WASM app using the RadzenNumeric I get the following trap: Radzen.numericOnInput is not a function
To Reproduce
Steps to reproduce the behavior:

Use the numeric below:

<RadzenNumeric TValue="double"<EMAIL_ADDRESS><EMAIL_ADDRESS>Class="w-100"<EMAIL_ADDRESS>Style="@entrystyle" Change="@(OnReadingChange)"/>
Expected behavior
No trap like in 3.19.1
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Max Os
Browser Edge
Version [e.g. 22] 103.0.1264.77

Additional context
Add any other context about the problem here.

TypeError: Radzen.numericOnInput is not a function
at HTMLInputElement.onblur

Try to clear your browser cache. This is a new function required by the component part of latest Radzen.Blazor.js


Removed mentions of gulp from CONTRIBUTING.md

It was a little confusing seeing gulp in the guide until I found #52. I figured maybe its better to not mention the specific tool since everything is run through yarn start anyway ¯\_(ツ)_/¯

Thanks!


🛠FIX : Ebook page User name fetching error

Related Issue
“None”
Fixes:  #4503
Description
On the ebook page user names were not fetching from local storage, It was showing a static name instead, but now it is fixed.
Type of PR

[x] Bug fix
[x] Feature enhancement

Screenshots / videos (if applicable)

Checklist:

[x] I have made this change from my own.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@abhi03ruchi please review it and merge it.

this issue is there in other pages as well . like swap page .
chk all pages and fix it . will increase ur level for it .

this issue is there in other pages as well . like swap page .
chk all pages and fix it . will increase ur level for it .

ok let me check and fix .


Babel Environment set to true breaks library configurations

Hey! Babel environment being set to true breaks configurations which are looking for a specific environment to add/remove configuration.
https://github.com/webpro/knip/blob/c0c75e02ee58fbe365e479ca5a6db32cac478459/packages/knip/src/plugins/babel/helpers.ts#L35
Example scenario:
https://github.com/shakacode/shakapacker/blob/f902e186b102a45273d6dad4c6affb9da285763a/package/babel/preset.js#L5-L16
Can we use process.env.NODE_ENV ?? process.env.BABEL_ENV so as to get an accurate representation of the environment at that point in time?

By "breaks" you mean currentEnv is true instead of e.g. development, right?
Other than that, the idea seems sound to me: Knip will receive a configuration where all dependencies for all environments are included. How else could Knip figure this out in a single run? In general you don't want to run Knip multiple times I guess.
Having that said, and looking at Babel source code, I think the function should be something like this:
{
  env: (env: string) => typeof env === 'string' ? true : 'development'
}

Would you agree?

@webpro yes, completely. I'm not entirely sure if the default should be 'development'.
If we can use the environment variable that is actually passed to knip, the better. If not, 'development' should work.

That default value I got here: https://github.com/babel/babel/blob/main/packages/babel-core/src/config/helpers/environment.ts
The fix will come with the next release.

By the way I try to minimize reading things like process.env to maximize being runtime agnostic (e.g. run in Bun, Deno, whatnot).

@webpro Got it. Thank you 🙌

@webpro Now that I think about it, I think returning true for all environments might cause some babel configurations to be invalid. Developers use isDevelopment, isProduction kind of variables to configure plugins for babel. If we are returning just true for all environments, I would assume this causes at least some configurations to be invalid.
I would expect something like Babel's own implementation of the function.
// Since we decided we aren't fetching from process
const defaultEnv = "development";

const env: EnvFunction = (
  value: string | string[] | (<T>(babelEnv: string) => T)
) => {
  if (typeof value === "undefined") return defaultEnv;
  if (typeof value === "function") {
    return value(defaultEnv);
  }
  return (Array.isArray(value) ? value : [value]).some((entry) => {
    if (typeof entry !== "string") {
      throw new Error("Unexpected non-string value");
    }
    return entry === defaultEnv;
  });
};

Other than that, the idea seems sound to me: Knip will receive a configuration where all dependencies for all environments are included. How else could Knip figure this out in a single run? In general you don't want to run Knip multiple times I guess.

Yes in theory things might break, but so far so good, haven't received other issues around this.

:rocket: This issue has been resolved in v5.10.0-canary.1. See Release 5.10.0-canary.1 for release notes.
Using Knip in a commercial project? Please consider sponsoring me.


Websites which use valid tlds for their domain don't seem to be treated correctly

"https://nhs.uk", "https://s3.amazonaws.com", "https://platform.sh"
I wasn't able to get the parts for domains such as the above, where the whole domain is a valid tld, but so is a subpart of the domain which in reality is the tld that the domain is using.

@Shardj sorry but I don't understand your question. Could you provide a snippet so I can understand what your are asking ?

Code:
        $manager = new Manager(new Cache(), new CurlHttpClient());
        $rules = $manager->getRules();
        $domain = $rules->resolve('platform.sh'); // any site using a tld for their domain
        var_dump($domain);

Output:
object(Pdp\Domain)[1314]
  public 'domain' => null
  public 'registrableDomain' => null
  public 'subDomain' => null
  public 'publicSuffix' => null
  public 'isKnown' => boolean false
  public 'isICANN' => boolean false
  public 'isPrivate' => boolean false

Try it with a normal url, for example 'www.google.co.uk' instead of one of the problematic urls that use a tld for their domain and you get regular results:
object(Pdp\Domain)[1315]
  public 'domain' => string 'www.google.co.uk' (length=16)
  public 'registrableDomain' => string 'google.co.uk' (length=12)
  public 'subDomain' => string 'www' (length=3)
  public 'publicSuffix' => string 'co.uk' (length=5)
  public 'isKnown' => boolean true
  public 'isICANN' => boolean true
  public 'isPrivate' => boolean false

Worth noting that $manager->getTLDs() instead of $manager->getRules() seems to work fine, so maybe I'm just misunderstanding how this is supposed to work

new Domain('nhs.uk'); var_dump($domain);  also produces incorrect results

@Shardj what your are reporting has already been addressed on the pinned issue which is the reason why it is pinned because it is a common mistake on how the package is used.
Please refer to that ticket for a full explanation and on how to get around it.

Surely this is an issue to fix, a domain isn't invalid just because it encapsulates a tld for its domain

There's a difference between:
<?php

$domain = new Domain('platform.sh');
$domain = $manager->getRules()->resolve('platform.sh');

These two declarations are not meant to return the same thing.
The Domain resolver is not just a domain validator. It validates if the given domain is valid AND if its public suffix list is known/found/valid. In your example, the first assertion is true, not the second one so it returns null.
So IMHO this is not an issue you just need to understand the subtle difference between both calls.

Sorry, please help me to understand why the public suffix list isn't known/found/valid for the example urls I've provided? For example nhs.uk the tld is uk.

@Shardj just like explained in the documentation you are providing a public suffix NOT a valid domain name. A public suffix can not be resolved as explain on the public suffix website.

Could you show me where it says that a public suffix cannot be a valid domain name and why not? After all, plenty of very valid websites do use domains which are a tld, so I'm just struggling to see what the reasoning is to say that they're invalid.

@Shardj run this script locally on your server and you should understand what is happening. Again this is well documented so refer to the documentation if you do not understand the output else please refer to the algorithm as described in PSL documentation website.
<?php

use Pdp\Cache;
use Pdp\CurlHttpClient;
use Pdp\Manager;
use Pdp\Rules;

$manager = new Manager(new Cache(), new CurlHttpClient());
$rules = $manager->getRules();

var_dump(
    $rules->resolve('s3.amazonaws.com'),
    $rules->resolve('s3.amazonaws.com', Rules::ICANN_DOMAINS),
    $rules->resolve('s3.amazonaws.com', Rules::PRIVATE_DOMAINS),
    $rules->resolve('nhs.uk'),
    $rules->resolve('nhs.uk', Rules::ICANN_DOMAINS),
    $rules->resolve('nhs.uk', Rules::PRIVATE_DOMAINS)
);

I know nyamsprod isn't interested in continuing with this issue, but for others reading this and for myself to refer back to.
Following the PSL documentation and using their algorithm which I've pasted below.

Match domain against all rules and take note of the matching ones.

If no rules match, the prevailing rule is "*".

If more than one rule matches, the prevailing rule is the one which is an exception rule.

If there is no matching exception rule, the prevailing rule is the one with the most labels.

If the prevailing rule is a exception rule, modify it by removing the leftmost label.

The public suffix is the set of labels from the domain which match the labels of the prevailing rule, using the matching algorithm above.

The registered or registrable domain is the public suffix plus one additional label.

The example of s3.amazonaws.com is considered valid by this repo only when checking the ICANN domains section of the psl list. Despite the psl agorithum also being able to come to the same conclusion when using all sections of the psl list, this repo doesn't come to that same conclusion.
The example of nhs.uk is considered valid by this repo only when using the private domains section of the psl list. Despite the psl algorithm also being able to come to the same conclusion when using all sections of the psl list, this repo doesn't come to that same conclusion.
I'll be going through the code to try and figure out why the code fails when comparing against all sections of the psl and I'll probably make a PR or use a branch if it's rejected.

I know nyamsprod isn't interested in continuing with this issue, but for others reading this and for myself to refer back to.

Please do not put out words or thoughts about what I think and what I will do. I tried to be respectful in our exchange, I may disagree but please stay on the issue. This type of remarks are not welcomed.
If you think this is an issue that needs to be resolve, create a PR and it will be reviewed as soon as it is presented.

Sorry nyamsprod, I wasn't trying to speak for you. I was simply trying to indicate that I wasn't commenting and expecting a response from you.

I was simply trying to indicate that I wasn't commenting and expecting a response from you.

Then you should have just say that. This is an open source project to which we dedicate some of our free time. You may disagree with choices made but as long as you stay respectful issues will be tackle and PR reviewed when we have time. Behaviour like this will not be tolerated.
You asked for the issue to be unlocked and I listened. I expect the same level of respect out of any contributor. The ball is on your side. If you PR can convince me then this issue and its related PR will be re-opened until then please refrain for making anymore comment not related to this issue.


cli: test the deletion of cobs

Ensure that the deletion of cobs is respected by testing a scenario where a peer creates and then deletes an issue, while another peer fetches and also has the issue be present and then removed.

By the way I was thinking about this, and: if a peer deletes a COB that he hasn't interacted with, he shouldn't sign-refs, because there will be nothing new to sign, right?

By the way I was thinking about this, and: if a peer deletes a COB that he hasn't interacted with, he shouldn't sign-refs, because there will be nothing new to sign, right?

Ya, she wouldn't have any references to the COB, right?

Exactly, so somehow in the delete code, we should check before calling sign_refs, to not create a commit.

Exactly, so somehow in the delete code, we should check before calling sign_refs, to not create a commit.

Hmmm, I'm not sure I follow. Is this to avoid needlessly creating a new set of signed refs?

Yes exactly, it would be identical to the previous one.

Yes exactly, it would be identical to the previous one.

I guess the only thing is that it would come at the cost of loading the sigrefs first. Do you think that's worth it?

I'm not sure we'd need to load sigrefs. I think we can just check if a ref exists under the remote, for that cob.

I'm not sure we'd need to load sigrefs. I think we can just check if a ref exists under the remote, for that cob.

Ah ya that's fair. It should be equivalent

Hmm good question, is cob::remove actually a no-op if you don't have your own refs, or does it remove from all remotes? If the former, then we don't need to call it.

Hmm good question, is cob::remove actually a no-op if you don't have your own refs, or does it remove from all remotes? If the former, then we don't need to call it.

So it just deletes the reference, so it would make sense to not remove it if it doesn't exist :) I'll add that to the change as well

Closing in favour of https://app.radicle.xyz/seeds/seed.radicle.xyz/rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5/patches/553c795ab9a8b0a7c8e0dfec95568ba11c018ad2?tab=files


List item prefixes are counted as words

Description
7 words:
- 1
- 2
- 3
-

Same goes for *- and +-prefixed lists. The core plugin "Word count" also has this issue, but only for --prefixed lists (which will hopefully be fixed).
Device
Windows.
I originally posted this here by accident. I was attempting to see why word counts were not the same and got the repos confused.
Thanks.
Edit: Apparently this is a known special case.

Novel Word Count defines a "word" as any sequence of one or more non-whitespace characters.
I'm reluctant to change this for two reasons:

People have differing opinions of what should be considered a word.
Software has differing opinions of what should be considered a word. If you're writing in Obsidian with the intent to paste your content into another app or a form, it would be detrimental to exclude things (especially things visible in Reading Mode) that the other software would include.
NWC's performance has been tuned and re-tuned and at present is pretty fast (can count 4.8 million words in less than a second on my MacBook Air). If I go down the path of letting people fight out more and more specific inclusions and exclusions to the "word" regex, performance will degrade, especially on large vaults.

I'm closing this for now, but if more users start requesting it, I can reconsider.

@redactedscribe This should be fixed now (v3.4.0).


⚠ Bofrost.at has degraded performance

In ad4cd4c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1632 ms

Resolved: Bofrost.at performance has improved in bdb7784 after 28 minutes.


What kind of hardware stands for GFX908?

Seems like gfx908 is added into the supporting list of rocm driver.

gfx0908 is the ISA for an as-yet-unreleased part.

@johnbridgman Thanks, hope to make it more detailed when it is released.


Cannot find module 'is-data-descriptor' from 'utils.js'

As I upgraded to 0.13.0 is-data-secriptor is not listed as a dependency thus it is not finding it...

I'm guessing you're using npm 5? Delete node_modules, and delete package-lock.json, then reinstall everything.

I am but it isn't a problem with re-installing node modules it looks like a jest issue


Fix: Remove field_class from div-wrapper in FormActions

Problem:

When using helper.form_class="form-horizontal" and FormActions the submit-button is misaligned
I suspect this is due to an incorrectly placed {{ field_class }} in the div-wrapper in FormActions

Current state:

With my fix:

The failed test is not because of my changes when my interpretation of the test results is correct?

The failed test is not because of my changes when my interpretation of the test results is correct?

I'm not at my desk but looking seeing that the failing test is to do with formactions I would say that it is related.

The failed test is not because of my changes when my interpretation of the test results is correct?

I'm not at my desk but looking seeing that the failing test is to do with formactions I would say that it is related.

I think i got the testing right now :)


logging: fix dictionary logging and added pytest

(See individual commits for details.)

Documentation error is due to 73235.

@dcpleung  please rebase.

Rebased.

re-assigning to @dcpleung  who maintains the dictionary logging feature and its tests.


Add Tizen os to machine map

Tizen will use the same image with 'arm-cross-latest'
Related issue : https://github.com/dotnet/core-setup/pull/1512

@gkhanna79 @jashook Can I add Tizen OS to machine map ?

/cc @hqueue @hseok-oh @wateret

@gkhanna79 If you don't mind, I would like to add this item to main arm32 issue in core-setup.

Can we wait on merging all Tizen related PRs until EOW @jyoungyun @hqueue as I am trying to get few kinks sorted in our infrastructure? Please ping me on Monday to revisit this.

I would like to add this item to main arm32 issue in core-setup.

@hqueue Please feel free to add the item to the main list - you do not need my permission to do so :) We are partners in the overall effort :)

@gkhanna79 Okay, I will wait for your response. Thank you.

@gkhanna79 Ping :)

Thanks @hqueue - If this is ready to merge, please update the title to reflect that and let me know and I will merge it.

I update the title and it is ready to merge. Thank you.


Some colors seem to be off

I've tested it an seems to be working somewhat, but when I'm trying to commit a specific line the line of the text selected and the background are the same, so I can't see which line I'm on.
The option responsible for this seems to be selectedRangeBgColor, I had to keep it blue otherwise I can't see the active line.

I've tested it an seems to be working somewhat, but when I'm trying to commit a specific line the line of the text selected and the background are the same, so I can't see which line I'm on.
The option responsible for this seems to be     selectedRangeBgColor, I had to keep it blue otherwise I can't see the active line.

I'm not entirely sure what's going on here. Perhaps a terminal specific issue? Here's mine with WezTerm

It's surface0 as expected, is this what you are referring to?

Just thought I should mention this. I was not experiencing your issue, but I recently upgraded my system, and now see the wrong colours! I can now fix this easily because I have local repro.

Take a look at #9, should resolve your problems!


test: add prominent message in test script cleanup functions

When a test script fails in CI, it's often difficult to pinpoint the exact line in the log where the script failed and the cleanup() function (trapped on EXIT) begins.
Adding a prominent line (with greenprint where available) at the start of the cleanup function will make reading logs of failed jobs a lot easier.

One of the gcp.sh runs failed https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/2503060505
and I realise now that we replace the function that runs on exit several times in the script.
First it's cleanup (L74), then it's sudo pkill -P ${WORKER_JOURNAL_PID} (L262), and then we remove the trap on L291.
Is the cleanup script not needed after L262?

gcp.sh

It's a bug, we do need it. I copied that code from aws.sh, it has the same issue.


es-syncer aquires unnecessary table locks

It is still acquiring an exclusive lock during polling.

The syncer now complete severs its connections with Postgres when it finishes polling.


test: Add test for non-empty graph without edges resolve #7

It is ok that this fails since it is a test without the feature.


用tronWeb.sgin签名，然后用 trident-java 中的 verify验证错误

https://github.com/tronprotocol/trident/issues/59

https://github.com/tronprotocol/trident/issues/59

Please check the source code here, tronweb will set a header to sign the string.
https://github.com/tronprotocol/tronweb/blob/master/src/lib/trx.js#L711

@Benson0224

TRX_MESSAGE_HEADER = '\x19TRON Signed Message:\n32';
TRX_MESSAGE_HEADER = '\u0019TRON Signed Message:\n32';
Both prefixes have been tried and the signature cannot be verified successfully  @Benson0224

I would suggest you refer below code, and you will see how tronweb verifies the signature.
https://github.com/tronprotocol/tronweb/blob/master/src/lib/trx.js#L605
TRONWEB guide:
https://cn.developers.tron.network/reference/verifymessage


Allow custom ConnectionProperties for identifyPayload

This PR allows properties of identifyPayload to be modified and passed through when making an identifyPayload, by adding a new optional parameter, properties:
import DiscordBM
let bot = await BotGatewayManager(
    identifyPayload: .init(
        token: "DISCORD_TOKEN",
        properties: .init(browser: "Discord iOS"), /// `.init(os: , browser: , device: )`
        presence: .init(activities: [], status: .online, afk: false),
        intents: [.messageContent, .guildMessages /* .. other intents .. */]
    )
)

This allows us to do things like spoof being on mobile, which is purely cosmetic, but it's pretty funny, and popular existing libraries such as Discord.JS have this already

Thanks!


Develop a component for control flow analysis. [100h]

The component will identify high-level control structures using control flow analysis of LLVM IR. Through pattern matching the properties of high-level control structures would be identified in a Control Flow Graph of the LLVM IR.
TODO: Split the task into sub-tasks and allocate time to them.

Work completed by the ll2dot tool and the iso and merge tools. The ll2dot tool will be rewritten once the pure Go library for interacting with LLVM IR is developed. The iso and merge tools operate on the DOT format and are therefore independent of the LLVM IR language.


Refactor notebook

The existing DFT notebook simply calls the density_functional_theory.py version using os.system.  This change moves more of the python logic into the notebook, moving density_functional_theory.py to pyscf_ipu/dft.py.

Notes (second code block)

Code fails at tar -xvf ./data/gdb11.tgz --directory ./gdb/. The folder gdb/ doesn't exist and tar is not allowed to create. The line below tries to load from /data/ , that is, sortgdb.sort_gdb looks at gdb_filename="./data/gdb11_size09.smi". Changing to tar -xvf ./data/gdb11.tgz --directory ./data/ seem to fix the issue.

Issue is resolved for me if I don't re-create dcargs for every conformer.
if conformer_num == 0: dcargs = namedtuple('dcargs', dcargs_names)(*(args.__dict__[a] for a in dcargs_names))

Notes (second code block)
Code fails at tar -xvf ./data/gdb11.tgz --directory ./gdb/. The folder gdb/ doesn't exist ...

Let me know if for some reason I'm at the wrong commit/branch (local code looks identical to cell block in ReviewNB)

Fixed, thanks.

Issue is resolved for me if I don't re-create dcargs for every conformer. @awf
if conformer_num == 0: dcargs = namedtuple('dcargs', dcargs_names)(*(args.__dict__[a] for a in dcargs_names))

Thanks for the scoping, which led me to understand that it's not the re-creation of dcargs, but of its type, that is namedtuple('dcargs', dcargs_names)


Implement queue using two stacks

I would like to work on this issue please assign me.

@gayatri517 Yes you may start working on this issue, make sure to follow all the points mentioned in contribution guide and make a PR once done.

hey @amritansh22  can i work on this

Excellent work @pranav2012 thanks a lot for opening this PR


Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes

Addresses #44

Can you update cpp/CONTRIBUTING.md for the recipe API changes?

Ping @westonpace

Thanks for the ping.  I haven't had much time for cookbook work recently.  I'll take a look at this one on Friday and either fix it up or close it.

I updated the instructions and ended up changing things a bit further to the dataset new recipes that need to share state between recipes.

Ping @pitrou :)

I came back to this and realized that @lidavidm 's flight test offers a much better solution.  We can simply move the test body into it's own method that returns a status.  This avoids the complexity of "recipe collections" and, since these tests should be quite small, there is little downside.  So I moved the tests to this approach instead.

It was @pitrou's suggestion :sweat_smile:


v1 style warnings during stack ./install.hs

Warning: The update command is a part of the legacy v1 style of cabal usage. and I think a few different ones later.

I think this is because cabal-helper does not yet work with cabal new-build. Running cabal (v1-)update is necessary for it to work. Hopefully, after #1168, only one such error appears.
When the hie-bios replaces cabal-helper, it will bring a lot more sanity to this project :tada:

#1126

I didn't mean to move to new-build. I only meant to replace update with v1-update to suppress the warning.

I can do that


Abell CLI now supports folder as an input and output args

All the files inside the input folder will be rendered and stored in output folder
Example
node src/bin.js build --input src/example/templates/abell_files --output src/example/out/abell_files

Thanks I'll make those changes and then let you know

Done with changes :)

Can you solve the errors that occur after npm run eslint

Yup I'll look over those today itself


Add webworkers tests

Description
Add unit tests for the webworker, based on the old/new implementation, which should provide seamless results.
Context
As recently the webworker has been changed with https://github.com/rancher/dashboard/issues/6901, it is required to add some tests. This has to be handled separately as the topic is way specific and timely expensive.

New implementations to be handled with https://github.com/rancher/dashboard/issues/8425


Fixing time decoding docstring

Fixing the GeneralizationAcrossTime docstring so that the correct default classifier is listed.

Thanks

Has this been merged? It wasn't rebased when I added https://github.com/mne-tools/mne-python/pull/2066

Ummm I think it was, right @agramfort? Just a one-liner change. Did these changes get undone in a separate commit?

I can add it in #2066 if necessary. I'll wait for Alex's response

I changed it back in #2066


API docs missing for read_csv, read_fwf and read_table

I believe there are still plenty of doc strings missing since the dask-expr migration
For example https://docs.dask.org/en/latest/generated/dask_expr.read_csv.html

Hello - hope you're having a wonderful day! I'd love to assist here - this would be my first ever PR, how can I help update these docstrings (aka is there a template I can follow)?
Would love to help!

A couple of things here.
First of all, this issue is actually a bit more work than I initially anticipated. A while ago we migrated to a new dataframe backend using https://github.com/dask/dask-expr
We had to move over a couple of different doc strings, see for example https://github.com/dask/dask-expr/pull/1051. These doc strings should also has to be added in that repo.
The original docs for read_csv, read_fwf and read_table where actually auto generated using a template, see
READ_DOC_TEMPLATE
I suspect we can use the same template but will require a slightly different mechanism. I suspect adding
read_csv.__doc__ = READ_DOC_TEMPLATE.format(reader="read_csv", file_type="CSV")

and similar for FWF and table should do the trick. (See here where the legacy readers are defined)

@fjetter sounds great I'll take a crack at it!


Need more samples

hi,
Can you create more sample codes for:

Node creation
Interface discovery
Adding pollers, etc

Hey @AmbicaY, thanks for your feedback!
SolarWinds Orion Go Samples
I'll create the ones from your list this week and get them into the samples directory.

Hey @mrxinu
Created a sample for reference. Please take a look.

I need sample code for AddInterfacesOnNode, similar to: https://github.com/solarwinds/orionsdk-python/blob/master/samples/discover_and_add_interfaces.py
I tried something like:
properties = []interface{}{
	nodeid,
	eth_only.,
	"AddDefaultPollers",
}

res, err = n.Invoke("Orion.NPM.Interfaces", "AddInterfacesOnNode", properties)

Does not seem to be working


create a folder of leetcode question

in the leetcode folder there will be three folders easy, medium and hard and people can contribute there solution and question link according to level

may i work on this i have some nice binary search questions!

I would like to add some amaazing leetcode DSA problems which i have gone through.
Will you please assign me this task?

Find peak index in a mountain array
Find unique number of occurrences in an array
Find pivot in an array
Find duplicates in an array

may you check this out
added leetcode-solution folder #442


nimble/phy: Fix for late RX-TX transition on nRF52

This fixes #796.
See commit message for details.

Confirmed. Also closes #795 THANKS!

@adrien3d

Still bugging for me when trying to access device from MacOS or Linux, either when listing or uploading images, as in #805


Split HttpInterceptor to avoid spring web / webflux forced dependency

Resolves #99
With the version 1.3.9, we've made spring-boot-starter-webflux as provided.
Trying to migrate my app to version 1.3.9 I was forced to add spring-boot-starter-webflux in my dependencies because HttpInterceptor in tzatziki-spring need it.
So I think it's best to use @Conditional spring condition to only inject bean related to web or webflux spring web dependencies depending of the application which is using tzatziki.
It permit also to remove webflux test dependecies in jpa and kafka modules.
I am not strongly convinced of my approach so I'm open to suggestions.
I have separate each type of interceptor tzatziki is putting to be sure to only try to intercept classes that are available on the classpath.

I've just see that there already an issue on this matter : #99

Codecov Report

Merging #160 (8323b91) into main (0c3433f) will increase coverage by 0.07%.
The diff coverage is 84.21%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff              @@
##               main     #160      +/-   ##
============================================
+ Coverage     86.45%   86.52%   +0.07%
  Complexity       35       35
============================================
  Files            33       37       +4
  Lines          2746     2753       +7
  Branches        287      284       -3
============================================
+ Hits           2374     2382       +8
  Misses          248      248
+ Partials        124      123       -1

Impacted Files
Coverage Δ

...com/decathlon/tzatziki/spring/HttpInterceptor.java
88.88% <66.66%> (-1.81%)
:arrow_down:

...on/tzatziki/spring/DefaultWebClientDefinition.java
70.00% <70.00%> (ø)

...athlon/tzatziki/spring/RestTemplateDefinition.java
83.33% <83.33%> (ø)

...tzatziki/spring/RestTemplateBuilderDefinition.java
100.00% <100.00%> (ø)

...on/tzatziki/spring/WebClientBuilderDefinition.java
100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Engine to framework rolls failing on .ci.yaml validation

Is there an existing issue for this?

[X] I have searched the existing infra issues

Type of Request
bug
Infrastructure Environment
GitHub
What is happening?
The last two engine rolls have failed (or are failing) on ci.yaml validation:
https://github.com/flutter/flutter/pull/134257
https://github.com/flutter/flutter/pull/134259
Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Looks like the next roll might be succeeding? https://github.com/flutter/flutter/pull/134260

closing for now since its resolved. reopen if needed


Map Matching API

Route with the sharp edges was given as a input to the map matching API and the Route with soft curves was obtained as the response of the map matching API

Travis Mapbox Token Error

Hey, thanks for the PR! I have opened an issue ( #10 ) to work on the CI problems.
Could you please have a go at adding your API token as I have suggested in there and then rerunning the build (or pushing another commit)?

Looks great, thanks for the PR!


[DEVHAS-166] convert functions to methods

Signed-off-by: Kim Tsao<EMAIL_ADDRESS>What does this PR do?:

Converts the Gitops functions to methods so they can be mocked by external clients
Which issue(s)/story(ies) does this PR fixes:

DEVHAS-166
PR acceptance criteria:

[x] Unit/Functional tests

[ ] Documentation

[ ] Client Impact

How to test changes / Special notes to the reviewer:

Codecov Report
Base: 80.92% // Head: 80.99% // Increases project coverage by +0.06% :tada:

Coverage data is based on head (c0d1300) compared to base (d011048).
Patch coverage: 84.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   80.92%   80.99%   +0.06%
==========================================
  Files           6        6
  Lines         603      605       +2
==========================================
+ Hits          488      490       +2
  Misses        106      106
  Partials        9        9

Impacted Files
Coverage Δ

pkg/gitops.go
59.80% <84.21%> (+0.38%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add note for validation assist

Request from support through Jira issueTW-2370

Close this issue via Slack agreement and communication.


Change a lot (but not all) references to atom-community

Changes a lot of references in package.json from "Atom" to "atom-community".

This wouldn't register as there are many mistakes I don't want to finish.