Refactor code base for better enhancement and approach

Yesterday night I tried to study for the browser extension work and studied this extension as I was interested in the MS Edge. My full efforts for making the codebase clean while understanding, I have also refactored many pieces of stuff to replace the packages we need, my friend :)

@shivapoudel Thanks for opening this PR, I'll take a look as soon as I can (probably later this week).
It seems you are using different indentation settings though, which makes the diff pretty large and makes it harder to review the PR since pretty much every line seems to be changed. Would you mind changing your editorconfig file to match the style of the existing codebase so the PR reflects only actual changes? That would make it much easier to jump into it when I have a chance :)

@Claudiohbsantos Now you can proceed with the review. I have managed to fix the coding rulesets you have mentioned earlier including svgo error in its latest version which doesn't support --disable in CLI. Additionally, I have chosen a shallow clone of VSCode extension repo and npm installation without scripts for it to faster the build process of icons for us!
If there is anything missing, please suggest me and I will have a look!!

Thanks for all of these changes, this is looking great. Whenever you feel like it's ready for a full review again just re-request review and I'll jump in whenever I can.

@Claudiohbsantos I am ready with this PR so please give a full review from your side. Additionally, after merging the PR, help with some logic to implement a simple config file for activeIconPack as I will not be looking on that currently with this PR.

@Claudiohbsantos any updates when you can full review this PR, my friend :)

Hey @shivapoudel . Thanks for the work on this. I'm travelling for a quick break until mid next week. I'll make sure to review this asap when I'm back. Sorry for the delay

In the new build scripts, could you add console log comments that give the user an idea of what the scripts currently doing?
I do the same in #10 and it helped me greatly when I was debugging the build scripts 😄

@4086606 I wish I could but unfortunately, I have some other prior tasks which I have to wrap up till the next week. However, that can be done after the merge also so will give a look at that on some other days, my friend :)

@shivapoudel sorry about the delay. I just merged the other PR that preceded this one and will jump on this next. If I can't finish reviewing today I'll do it Monday the latest. Thank you for your patience

If you'd like, I created a PR in your fork with the solution to the merge conflicts flagged here: https://github.com/shivapoudel/github-material-icons-extension/pull/2 . I thought that was easier for you than having to review the PR once again :) , and nicer than pushing the changes directly into this PR. Let me know if anything seems wrong to you.
I'm also happy to merge those changes directly into the PR if that's easier, I already tested the changes and they work as expected

@Claudiohbsantos I have tested the PR raised in the fork and seems nicer. Please proceed :)

@Claudiohbsantos Is download Chromium still necessary?

Oh, i don't think so, thanks for catching that. Looks like I accidentally removed the --ignore-scripts option you added during the merge. I can re-add that after merging

@Claudiohbsantos While running npm run build I am facing this issue with module make-dir we already have mkdirp so can this be the one package that does both works?

make-dir > mkdirp:

https://github.com/substack/node-mkdirp/issues/66
https://github.com/substack/node-mkdirp/issues/70
https://github.com/substack/node-mkdirp/pull/96

@4086606 Is this okay for you https://github.com/Claudiohbsantos/github-material-icons-extension/pull/7/commits/ebef814f1bad8fcf4d688eaa385dd582c3dc55e9 as for me on Windows now it is working great!!

@Claudiohbsantos Merge conflicts and other issues have been patched. Please have a review and merge the PR :)

Some small issues in Ubuntu (WSL), will open a pull to fix those

This looks awesome, thanks for all the work on it and the many revisions


[Experiment] Make OpaquePointer an alias for UnsafeRawPointer.

This is an experiment to see what the impact of changing OpaquePointer to UnsafeRawPointer would likely be. It's a simplification we'd like to do... depending on source impact.

Can one of the admins verify this patch?

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

How to change the base branch: (Link)
More detail about the branch update: (Link)


Error when trying to run_ucs with 6dof rotor

When trying to run the .run_ucs method to a 6dof rotor I get the following error:
---------------------------------------------------------------------------
Exception                                 Traceback (most recent call last)
<ipython-input-39-59650c74aad8> in <module>
----> 1 ucs0 = rotor.run_ucs()

~/ross/ross/rotor_assembly.py in run_ucs(self, stiffness_range, num_modes, num, fig, synchronous, **kwargs)
   2159         for i, k in enumerate(stiffness_log):
   2160             bearings = [BearingElement(b.n, kxx=k, cxx=0) for b in bearings_elements]
-> 2161             rotor = self.__class__(self.shaft_elements, self.disk_elements, bearings)
   2162             speed = 0
   2163             if synchronous:

~/ross/ross/rotor_assembly.py in __init__(self, shaft_elements, disk_elements, bearing_elements, point_mass_elements, min_w, max_w, rated_w, tag)
    198             raise ValueError("Tags should be unique.")
    199
--> 200         self.number_dof = self._check_number_dof()
    201
    202         ####################################################

~/ross/ross/rotor_assembly.py in _check_number_dof(self)
    530             len(brg.dof_mapping()) != number_dof / 2 for brg in self.bearing_elements
    531         ):
--> 532             raise Exception(
    533                 "The number of degrees o freedom of all elements must be the same! There are BEARING elements with discrepant DoFs."
    534             )

Exception: The number of degrees o freedom of all elements must be the same! There are BEARING elements with discrepant DoFs.

The problem is happening on line 2160.
   2159         for i, k in enumerate(stiffness_log):
   2160             bearings = [BearingElement(b.n, kxx=k, cxx=0) for b in bearings_elements]

The code should select between BearingElement and BearingElement6DoF automatically.

Yes, I have replaced that with b.__class__(...), but now I am getting other errors.
The problem now is that, for a 4dof we basically had to select the forward modes, but now we also have modes that are related to the torsional/axial dofs, and I still need to find a way to identify and remove those from the results. A hack could be to just create a 4dof rotor within the function using the 6dof rotor attributes.
But this problem made me think about how we are displaying our modes after running .run_modal(...).plot(...), how can we show the user that a specific mode is related to torsion?
@rodrigomoliveira1 , @atbrandao

Hi there!
I have marked this issue as stale because it has not had activity for 45 days.
Consider the following options:

If the issue refers to a large task, break it in smaller issues that can be solved in
less than 45 days;
Label the issue as wontfix or wontfix for now and close it.

The solver's algorithms were evaluated to better understand the solution of the modes shapes, so that the possible solutions listed as viable options can be implemented in the already developed solver. The torsional and axial mode shapes were evaluated in order to represent them visually. To this end, the plot functions already implemented were examined to understand how to graphically represent the results of interest. The next step is to sketch the graphical solution.


Googlebot Desktop: BotD detection fail

Testing BotD: Googlebot Desktop in Chrome.
Output {bot: false}
See image below:

Hi @dinhduc2402. We decided internally to not proceed with implementing crawler-like bots (e.g. google/facebook ect) in BotD OSS.
However, if you care about such functionality, you can check our pro version at https://fingerprint.com/


[12.2] Fork testnet to test 12.2 migration

Since this PR simply includes an unchanged commit by @schinzelh, I'm going to review it myself :P
utACK :)


Throw an error if showMarketplace() or similar functions are called before a successful authenticate()

Currently, if you omit a prismatic.authenticate() call, or if your call fails but is not caught, a showMarketplace() or similar call will still inject an iframe but the iframe will contain a 404 screen. This makes it so a successful prismatic.authenticate() call must run before subsequent calls are allowed, and an instructive error is thrown if you attempt to call showMarketplace() prior to authenticate().

The latest commit also causes an error to be thrown if someone tries to call prismatic.showDesigner or prismatic.showIntegrations for a customer user who does not have embedded designer enabled.


Fix of #2 and #3

Fix both a parser and a lexer error (#2, #3).
Improve README.
Improve tests.

Fixes #2 and #3.


Fix publish step in the pipeline

Two current issues in the pipeline:

We should only tag the release once, instead of after both scoped and non-scoped package publishes
Do a check to see if the package has already been published and, if so, skip the step instead of failing. This will allow us to re-run the step in case there any ephemeral errors in the pipeline that cause the step to fail

When checking, make sure the published package is the same we are going to publish.  We should still error if we are trying to publish a different package of the same version.


Ban Trapinch from LC

https://www.smogon.com/forums/threads/usum-lc-trapinch-suspect-voting.3648825/post-8086522

You also have to ban it in formats.js in the off chance it moves out of LC Uber


Settings - case sensitivity - misleading example in docs

Bug
Please complete:

OS: Linux
Python version import sys; print(sys.version): 3.6.9
Pydantic version import pydantic; print(pydantic.VERSION): 1.2

There is an example in docs about case sensitivity of environment variable names: https://pydantic-docs.helpmanual.io/usage/settings/#environment-variable-names.
I cite it here for convenience:

Case-sensitivity can be turned on through the Config:

from pydantic import BaseSettings

class Settings(BaseSettings):
    redis_host = 'localhost'

    class Config:
        case_sensitive = True

When case_sensitive is True, the environment variable must be in all-caps, so in this example redis_host could only be modified via export REDIS_HOST.

This example is simply incorrect. It leads that you can name Settings attrs using "snake_case", and export env variable named "UPPER_CASE", and Settings will catch them and populate proper attr with value taken from this env variable. This is not the case. In fact, if you want case sensitive environment variable names, you must name Settings attributes all "UPPER_CASE" as well.
Proof
Let's take this example "as is" and try to override settings attribute using environment variable:
import os
from pydantic import BaseSettings

class Settings(BaseSettings):
    redis_host = 'localhost'

    class Config:
        case_sensitive = True

Settings().redis_host
'localhost'  # default

os.environ['REDIS_HOST'] = 'myredis'  # according to example, we must name env var all UPPER_CASE
Settings().redis_host
'localhost'  # still default
os.environ['redis_host'] = 'myredis'
Settings().redis_host
'myredis'  # now it's working

Thank you for reporting this, I guess we forgot to update the documentation when the functionality changed.
PR welcome to correct the docs.

I will submit PR, but just need to clarify current behavior/any drawbacks? Does it just turns case sensitivity on without any "smarty" logic? So, attribute names must match environment variable names closely?

No, the other logic for working out environment variable names to look up is unchanged.
Just that if not self.case_sensitive everything is converted to lowercase before the lookup.
https://github.com/samuelcolvin/pydantic/blob/de6bd1b4694dc7b04c9626e39fd494965f230b7c/pydantic/env_settings.py#L67-L88

But, if there is no explicit binding to environment variable (through Field.env), then variable name is taken from attribute's name, and follow its case as is, is it correct?

well it's cls.env_prefix + field.name but env_prefix is an empty list by default, so yes.


[AIRFLOW-488] AirflowException("Failed to create remote temp file")

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

_https://issues.apache.org/jira/browse/AIRFLOW-488_

Testing Done:

It can pass all the test, travis included.

Current coverage is 65.51% (diff: 100%)

Merging #1782 into master will increase coverage by 0.05%

@@             master      #1782   diff @@
==========================================
  Files           143        143
  Lines          9887       9887
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6472       6477     +5
+ Misses         3415       3410     -5
  Partials          0          0

Powered by Codecov. Last update 247955d...0208a58

Thanks. Please squash your commits and provide a proper commit message per the guidelines (jira reference, title, what/why description)

@forevernull please follow the 50/72 rules for commit messages. https://cwiki.apache.org/confluence/display/AIRFLOW/Contributors'+Guide

@msumit  I have mended. Can It merge or How can I do something?

lgtm

I still get this error after make revison on 'mktemp', and I am using Linux platform.
Has it been tested on Linux before?


Add FullName templated fields

Summary | Résumé
Adds the "Full name" templated field that adds a Text element with autocomplete set to Name.
Includes a bit of a refactor of the previously-created Name component which has been renamed to FirstMiddleLastName component for clarity.
Pull Request Checklist
Please complete the following items in the checklist before you request a review:

[ ] Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
[ ] The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
[ ] If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
[ ] Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
[ ] Does your code have adequate comprehensible comments? Do new functions have docstrings?
[ ] Have you modified the change log and updated any relevant documentation?
[ ] Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
[ ] If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Thinking we should remove "Name" from the Panel


If the directory does not exist, an exception is raised

GameLib.Core   PathUtil.GetExecutables  If the directory does not exist, an exception is raised
  public static List<string> GetExecutables(string path)     {         if (!Directory.Exists(path)) return new List<string>();         return Directory.GetFiles(path, "*.exe", SearchOption.AllDirectories).ToList();     }

Hi @dongzhaosheng73, thank you for the hint. Fixed in v1.3.3


Possible typo MainLogging.defaultScreen Terminal.get usage?

In MainLogging
https://github.com/sbt/sbt/blob/fe5497938a8b2898dcbab49b60e0f2ef53b06c29/internal/util-logging/src/main/scala/sbt/internal/util/MainLogging.scala#L69-L88
Line 78 uses Terminal.get based upon the other signatures, they use the passed in console
As far as I can tell the consoleOpt usage https://github.com/sbt/sbt/blob/fe5497938a8b2898dcbab49b60e0f2ef53b06c29/internal/util-logging/src/main/scala/sbt/internal/util/MainLogging.scala#L60 get ignored

I am actually not sure if this was a typo.
Looking at git blame, this was changed in https://github.com/sbt/sbt/pull/5620/commits/1b03c9b1a9e65d174f2470486a6d2178ceb770fd to enable sbtn terminal forwarding. If we do change this area, we probably need to make sure sbtn continues to work.

@eatkins I can't tell from the change if this was actually intentional or not

I don't remember writing this code all that well but I do remember that I did a bunch of refactoring. It is quite possible that in refactoring I failed to update an api unintentionally. If you think that it looks like a typo then there is a good chance that it is. To know for sure I'd have to reread all of the surrounding code. In general though I think Terminal.get is to be avoided, especially if the parameter list includes a parameter that provides a Terminal. My guess is that https://github.com/er1c/sbt/commit/c1ed109f8927cf8b1815c50ac45444cfd7cc76d3 is both safe and more correct but I'm not 100% sure.


"Negreni" is listed in the drop-down menu

Description:
"Negreni" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Negreni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Negreni, Argeș (Dârmănești)".


Selenium hangs on creation of driver in AWS Lambda

I am unable to get Selenium + Chrome (version 116) working in AWS Lambda. It works fine locally (setting environmental varibable LOCAL_LAMBDA) and in a Docker container (run with ./debug_docker.py to simulate as best as possible the Lambda environment). It also doesn't hang with Chrome for Tesing, but Google detects that automation is being used in this case and returns the untranslated PDF.
To install Chrome for Testing instead of Chrome (from the RPM), replace the following lines in the Dockerfile
# Install Chrome
RUN yum update -y && \
    yum install -y curl gcc jq tar unzip wget && \
    wget https://dl.google.com/linux/direct/google-chrome-stable_current_x86_64.rpm && \
    yum install -y ./google-chrome-stable_current_x86_64.rpm && \
    rm google-chrome-stable_current_x86_64.rpm && \
    yum clean all

with
RUN yum update -y &&  \
    yum install -y alsa-lib atk at-spi2-atk at-spi2-core bash ca-certificates cairo chkconfig curl expat glib2 glibc gtk3 jq libcurl libdrm libgcc libX11 libxcb libXcomposite libXdamage libXext libXfixes libxkbcommon libXrandr mesa-libgbm nspr nss nss-util pango unzip vulkan wget xdg-utils && \
    LATEST_CHROME_RELEASE=$(curl -s https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions-with-downloads.json | jq '.channels.Stable') && \
    LATEST_CHROME_URL=$(echo "$LATEST_CHROME_RELEASE" | jq -r '.downloads.chrome[] | select(.platform == "linux64") | .url') && \
    wget -N "$LATEST_CHROME_URL" && \
    unzip chrome-linux64.zip -d /usr/local/bin/ && \
    chmod +x /usr/local/bin/chrome-linux64/chrome && \
    ln -s /usr/local/bin/chrome-linux64/chrome /usr/bin/google-chrome && \
    rm chrome-linux64.zip

If you uncomment the commented code in lambda.py, it will output detailed logs from chromedriver. in both cases (Chrome and Chrome for Testing) it tries to autoAttach
2023-09-06T16:30:58.671+01:00	[1694014258.662][DEBUG]: DevTools WebSocket Command: Target.setAutoAttach (id=6) (session_id=292511072B05DAD8B031956A1BB53DA8) 7639FE854C8ED3F0C1609BFA9360C0C4 {

2023-09-06T16:30:58.671+01:00	"autoAttach": true,

2023-09-06T16:30:58.671+01:00	"flatten": true,

2023-09-06T16:30:58.671+01:00	"waitForDebuggerOnStart": false

2023-09-06T16:30:58.671+01:00	}

and Chrome for testing outputs
2023-09-06T16:30:58.671+01:00	[1694014258.662][DEBUG]: DevTools WebSocket Event: Target.attachedToTarget (session_id=292511072B05DAD8B031956A1BB53DA8) 7639FE854C8ED3F0C1609BFA9360C0C4 {

2023-09-06T16:30:58.671+01:00	"sessionId": "F9969B18C0C431E32FC802135DE31491",

2023-09-06T16:30:58.671+01:00	"targetInfo": {

2023-09-06T16:30:58.671+01:00	"attached": true,

2023-09-06T16:30:58.671+01:00	"browserContextId": "BDE3048E1615B4FCFEE0082E160CF5C7",

2023-09-06T16:30:58.671+01:00	"canAccessOpener": false,

2023-09-06T16:30:58.671+01:00	"targetId": "7DA74A4AF0E5D53DC9EF39281F55BAAE",

2023-09-06T16:30:58.671+01:00	"title": "chrome-untrusted://new-tab-page/one-google-bar?paramsencoded=",

2023-09-06T16:30:58.671+01:00	"type": "iframe",

2023-09-06T16:30:58.671+01:00	"url": "chrome-untrusted://new-tab-page/one-google-bar?paramsencoded="

2023-09-06T16:30:58.671+01:00	},

2023-09-06T16:30:58.671+01:00	"waitingForDebugger": false

2023-09-06T16:30:58.671+01:00	}

whereas Chrome (installed from the RPM package) never attaches.
Remember that both of these cases work in a Docker conatiner run locally, so there must be some difference between Chrome and Chrome for Testing that is clashing with some restriction in AWS Lambda that I am unable to reproduce locally.

I think I know where it is failing, but not how to fix it (yet). When Chrome (as opposed to Chrome for Testing) runs it interacts with update.googleapis.com and tries to unpack a component
[14:51:0907/064739.953705:VERBOSE1:network_delegate.cc(35)] NetworkDelegate::NotifyBeforeURLRequest: http://edgedl.me.gvt1.com/edgedl/release2/chrome_component/adqyi2uk2bd7epzsrzisajjiqe_9.48.0/gcmjkmgdlgnkkcocmoeiminaijmmjnii_9.48.0_all_ohmvxqjs7ttvopbcet23jjvqje.crx3
[14:14:0907/064739.975918:VERBOSE1:url_fetcher_downloader.cc(136)] url fetcher response started for: http://edgedl.me.gvt1.com/edgedl/release2/chrome_component/adqyi2uk2bd7epzsrzisajjiqe_9.48.0/gcmjkmgdlgnkkcocmoeiminaijmmjnii_9.48.0_all_ohmvxqjs7ttvopbcet23jjvqje.crx3
[14:14:0907/064739.978428:VERBOSE1:url_fetcher_downloader.cc(113)] Downloaded 34946 bytes in 24ms from http://edgedl.me.gvt1.com/edgedl/release2/chrome_component/adqyi2uk2bd7epzsrzisajjiqe_9.48.0/gcmjkmgdlgnkkcocmoeiminaijmmjnii_9.48.0_all_ohmvxqjs7ttvopbcet23jjvqje.crx3 to /tmp/.com.google.Chrome.kFRKeD/gcmjkmgdlgnkkcocmoeiminaijmmjnii_9.48.0_all_ohmvxqjs7ttvopbcet23jjvqje.crx3
[14:35:0907/064739.978793:VERBOSE1:puffin_component_unpacker.cc(71)] Verifying component: /tmp/.com.google.Chrome.kFRKeD/gcmjkmgdlgnkkcocmoeiminaijmmjnii_9.48.0_all_ohmvxqjs7ttvopbcet23jjvqje.crx3
[14:35:0907/064739.979604:VERBOSE1:puffin_component_unpacker.cc(100)] Unpacking in: /tmp/.com.google.Chrome.q7g8Pp
[14:36:0907/064739.980364:VERBOSE1:puffin_component_unpacker.cc(109)] Unzipping failed.

I haven't been able to figure out what is causing the unzip to fail even looking at the Chromium source code. What is weird is that when it is run in a local Docker it doesn't try to unpack.

I've been trying to replicate AWS Lambda functions locally as closely as possible. I have been passing the following flags to Docker:
--cpus 1 -m 1024m -p 9000:8080 \
--read-only --tmpfs /tmp:rw,exec,size=512m \
--security-opt seccomp=x86_64-unknown-linux-musl.json

(I got the seccomp file from here: https://github.com/firecracker-microvm/firecracker/blob/main/resources/seccomp/x86_64-unknown-linux-musl.json).
Still unable to reproduce the behaviour locally.
So then I

Cloned and exported the AMI that AWS says is used for the Lambda functions (https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html).
Extracted the rootfs from the image.
Spun up an EC2 with the AMI.
Extracted the Linux sources with yumdownloader --source kernel.
Built the kernel with a minimal initramfs.cpio.
Launched the Lambda image on https://github.com/firecracker-microvm/firecracker-containerd with the kernel and rootfs from the previous steps.

...and was still unable to reproduce the behaviour. (Although I also didn't get errors like prctl: Operation not permitted which I thought would be due to some seccomp configuration or to a cut-down kernel.)
I am starting to suspect that Google API detects the IP address of AWS Lambda.


fix(semantic): incorrect semantic check for sibling label has same name

fix: #5036

What's wrong? Do you need assistance here?

I didn't write this part of the code, feel free to refactor and make bigger changes.

The current method is incorrect. It can't pass:
Parentout: {
    Parent: {
        Son: console.log("Son11");
    }
    Parent: {
        Son: console.log("Son21");
    }
}

@Boshen  I'm a bit confused about CI/Conformance, it seems that the local just ready doesn't have this option. Currently, I am running cargo coverage locally but it has failed.

I am running coverage locally and it shows the following error
cargo coverage
   Compiling oxc_coverage v0.0.0 (/Users/hhh/test/oxc-main/tasks/coverage)
    Finished `coverage` profile [optimized] target(s) in 27.85s
     Running `target/coverage/oxc_coverage`
thread '<unnamed>' panicked at tasks/coverage/src/test262/mod.rs:64:48:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: Recipe `coverage` was terminated on line 85 by signal 6

I am running coverage locally and it shows the following error
cargo coverage
    Finished `coverage` profile [optimized] target(s) in 27.85s
     Running `target/coverage/oxc_coverage`
thread '<unnamed>' panicked at tasks/coverage/src/test262/mod.rs:64:48:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: Recipe `coverage` was terminated on line 85 by signal 6

I am running coverage locally and it shows the following error
cargo coverage
    Finished `coverage` profile [optimized] target(s) in 27.85s
     Running `target/coverage/oxc_coverage`
thread '<unnamed>' panicked at tasks/coverage/src/test262/mod.rs:64:48:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: Recipe `coverage` was terminated on line 85 by signal 6

tasks/coverage/test262 may be dirty, try remove and reclone?

tasks/coverage/test262 may be dirty, try remove and reclone?

This step was successful with this method, and the next step has the following new problem. Can a similar solution be used to solve it?
Coverage looks difficult to handle🥹
[react.development.js] - Downloading<EMAIL_ADDRESS>to [/oxc-main/target/react.development.js]
thread 'main' panicked at tasks/common/src/test_file.rs:90:67:
called `Result::unwrap()` on an `Err` value: "Transport(Transport { kind: ConnectionFailed, message: Some(\"tls connection init failed\"), url: Some(Url { scheme: \"https\", cannot_be_a_base: false, username: \"\", password: None, host: Some(Domain(\"cdn.jsdelivr.net\")), port: None, path<EMAIL_ADDRESS>query: None, fragment: None }), source: Some(Os { code: 54, kind: ConnectionReset, message: \"Connection reset by peer\" }) })"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: Recipe `coverage` was terminated on line 85 by signal 6

tasks/coverage/test262 may be dirty, try remove and reclone?

This step was successful with this method, and the next step has the following new problem. Can a similar solution be used to solve it? Coverage looks difficult to handle🥹
[react.development.js] - Downloading<EMAIL_ADDRESS>to [/oxc-main/target/react.development.js]
thread 'main' panicked at tasks/common/src/test_file.rs:90:67:
called `Result::unwrap()` on an `Err` value: "Transport(Transport { kind: ConnectionFailed, message: Some(\"tls connection init failed\"), url: Some(Url { scheme: \"https\", cannot_be_a_base: false, username: \"\", password: None, host: Some(Domain(\"cdn.jsdelivr.net\")), port: None, path<EMAIL_ADDRESS>query: None, fragment: None }), source: Some(Os { code: 54, kind: ConnectionReset, message: \"Connection reset by peer\" }) })"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: Recipe `coverage` was terminated on line 85 by signal 6

Are you able to get<EMAIL_ADDRESS>


Binary in npm package is not executable

Testing this on Linux, not sure if it affects other platforms.
The workerd binary in the workerd npm package is not marked executable, resulting in
/bin/sh: 1: /home/erisa/worker-links/node_modules/@cloudflare/workerd-linux-64/bin/workerd: Permission denied

With wrangler dev --experimenal-local this manifests as
⎔ Starting an experimental local server...
Running the 🦄 Cloudflare Workers Runtime 🦄 natively ⚡...
/bin/sh: 1: /home/erisa/worker-links/node_modules/@cloudflare/workerd-linux-64/bin/workerd: Permission denied
✘ [ERROR] local worker: MiniflareCoreError [ERR_RUNTIME_FAILURE]: The Workers runtime failed to start. There is likely additional logging output above.

      at Miniflare.#waitForRuntime
  (/home/erisa/worker-links/node_modules/@miniflare/tre/dist/src/index.js:4770:13)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async Miniflare.#init
  (/home/erisa/worker-links/node_modules/@miniflare/tre/dist/src/index.js:4680:9)
      at async startLocalWorker
  (/home/erisa/worker-links/node_modules/wrangler/wrangler-dist/cli.js:144649:9) {
    code: 'ERR_RUNTIME_FAILURE',
    cause: undefined
  }

Running chmod +x on the path in the error causes it to work as intended.
Worth noting that I am using Yarn:
$ yarn --version
1.22.19

Should be fixed in<EMAIL_ADDRESS>(the linux x86 binary included in workerd). Could you try installing<EMAIL_ADDRESS>and see if that works?

I can confirm this is fixed with<EMAIL_ADDRESS>Thanks!

Amazing!


Cannot find module:'@algolia/cache-common'"

I have a lambda function in AWS and when I run the server locally everything works perfectly, the usage of algolia is being made inside a service, which is in an endpoint inside my server.
I tried installing @algolia/cache-common and it didn't help either.
Every call that is made to the lambda crashes the entire app because of this error.
is there any way to fix it?
the error is the following:
    "errorType": "Runtime.ImportModuleError",
    "errorMessage": "Error: Cannot find module '@algolia/cache-common'\nRequire stack:\n- /opt/nodejs/node_modules/algoliasearch/dist/algoliasearch.cjs.js\n- /opt/nodejs/node_modules/algoliasearch/index.js\n- /var/task/dist/api/v1/services/algolia.service.js\n- /var/task/dist/api/v1/handlers/jobs.handler.js\n- /var/task/dist/api/v1/controllers/jobs.controller.js\n- /var/task/dist/api/v1/v1.routes.js\n- /var/task/dist/api/routes.js\n- /var/task/dist/serverless.js\n- /var/runtime/UserFunction.js\n- /var/runtime/index.js",
    "stack": [
        "Runtime.ImportModuleError: Error: Cannot find module '@algolia/cache-common'",
        "Require stack:",
        "- /opt/nodejs/node_modules/algoliasearch/dist/algoliasearch.cjs.js",
        "- /opt/nodejs/node_modules/algoliasearch/index.js",
        "- /var/task/dist/api/v1/services/algolia.service.js",
        "- /var/task/dist/api/v1/handlers/jobs.handler.js",
        "- /var/task/dist/api/v1/controllers/jobs.controller.js",
        "- /var/task/dist/api/v1/v1.routes.js",
        "- /var/task/dist/api/routes.js",
        "- /var/task/dist/serverless.js",
        "- /var/runtime/UserFunction.js",
        "- /var/runtime/index.js",
        "    at _loadUserApp (/var/runtime/UserFunction.js:202:13)",
        "    at Object.module.exports.load (/var/runtime/UserFunction.js:242:17)",
        "    at Object.<anonymous> (/var/runtime/index.js:43:30)",
        "    at Module._compile (internal/modules/cjs/loader.js:1085:14)",
        "    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)",
        "    at Module.load (internal/modules/cjs/loader.js:950:32)",
        "    at Function.Module._load (internal/modules/cjs/loader.js:790:12)",
        "    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)",
        "    at internal/main/run_main_module.js:17:47"

    ]
}

the way I use the algolia is like the following:
const applicationId: any = config.get("ALGOLIA.APPLICATION_ID");
const apiKey: any = config.get("ALGOLIA.ADMIN_API_KEY");
const client = algoliasearch(applicationId, apiKey);
const index = client.initIndex("my-actual-index");
note (tl:dr): everything works locally but not in lambda.

hmm, that module exists on npm, so I'm not sure what could cause the issue. Are you possibly mixing v3 and v4 of algoliasearch? Can you reproduce this issue in a standalone GitHub repo (without AWS), or does it only happen on a lambda?

It only happens on lambda

I wonder if this is a bug related to the zipping then, could you check if the module is available locally for you, and if it's also in the zip sent to lambda? some debugging tips: https://stackoverflow.com/questions/30678348/aws-lambda-cannot-find-module https://bobbyhadz.com/blog/aws-lambda-cannot-find-module

You are correct, I have uploaded the modules in a wrong way. missed the algolia dependencies.


test: Update git cypress test logic for merge conflicts

Description
This PR updates test logic in order to get merge conflicts , earlier merge conflicts would come if we commit different widgets on same page, since this is resolved by canvas split PR, updated test to use theme for conflicts instead
Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.

[ ] Cypress

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/ok-to-test

/ok-to-test


Support mapping ulong, uint, ushort, sbyte, and char on SQL Server

I have the following enum:
    [Flags]
    public enum Factor : long
    {
        Parent = ( 1 >> 0 ),
        PastSupporter = ( 1 >> 1 ),
    }

When I utilize the enum in an entity class, dotnet ef migrations add has a problem:

dotnet : System.InvalidOperationException: The property 'Voter.Factors' is of type 'Factor' which is not supported by current database provider. Either change the
property CLR type or manually configure the database type for it.
At line:1 char:1

dotnet ef migrations add SimplifyContactsFactors

CategoryInfo          : NotSpecified: (System.InvalidO...se type for it.:String) [], RemoteException
FullyQualifiedErrorId : NativeCommandError

at Microsoft.EntityFrameworkCore.Metadata.Conventions.Internal.PropertyMappingValidationConvention.Apply(InternalModelBuilder modelBuilder)
at Microsoft.EntityFrameworkCore.Metadata.Conventions.Internal.ConventionDispatcher.OnModelBuilt(InternalModelBuilder modelBuilder)
at Microsoft.EntityFrameworkCore.Infrastructure.ModelSource.CreateModel(DbContext context, IConventionSetBuilder conventionSetBuilder, IModelValidator validator)
at System.Collections.Concurrent.ConcurrentDictionary2.GetOrAdd(TKey key, Func2 valueFactory)
at Microsoft.EntityFrameworkCore.Internal.DbContextServices.CreateModel()
at Microsoft.EntityFrameworkCore.Internal.LazyRef`1.get_Value()
at Microsoft.EntityFrameworkCore.Internal.DbContextServices.get_Model()
at Microsoft.Extensions.DependencyInjection.ServiceProvider.ScopedCallSite.Invoke(ServiceProvider provider)
at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.TransientCallSite.Invoke(ServiceProvider provider)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.ConstructorCallSite.Invoke(ServiceProvider provider)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.TransientCallSite.Invoke(ServiceProvider provider)
at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
at Microsoft.EntityFrameworkCore.Design.MigrationsOperations.AddMigration(String name, String outputDir, String contextType)
at Microsoft.EntityFrameworkCore.Tools.Cli.MigrationsAddCommand.Execute(CommonOptions commonOptions, String name, String outputDir, String context, String
environment, Action`1 reporter)
at Microsoft.EntityFrameworkCore.Tools.Cli.MigrationsAddCommand.<>c__DisplayClass0_0.b__0()
at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
at Microsoft.EntityFrameworkCore.Tools.Cli.Program.Main(String[] args)

The property 'Voter.Factors' is of type 'Factor' which is not supported by current database provider. Either change the property CLR type or manually configure the
database type for it.

By experimentation I've determined that it's the unsigned portion of the spec that's causing a problem (i.e., long works just fine).
Are unsigneds not supported? I ask because I'm looking to have as large a bitfield as I can to store options.

@markolbert Unsigned longs, ints, and shorts are not yet supported for SQL Server because the underlying ADO.NET provider for SQL Server ("a.k.a. SQL Client") does not support them. They can be used with other providers, such as SQLite. We plan to support them for SQL Server when type conversions are implemented. This is being tracked by issue #242. Closing this as a duplicate of that issue.

Thanx for the quick reply, and explanation.

Mark
Sent from my iPhone

On Sep 7, 2016, at 5:49 PM, Arthur Vickers <notifications<EMAIL_ADDRESS>wrote:
@markolberthttps://github.com/markolbert Unsigned longs, ints, and shorts are not yet supported for SQL Server because the underlying ADO.NEThttp://ado.net provider for SQL Server ("a.k.a. SQL Client") does not support them. They can be used with other providers, such as SQLite. We plan to support them for SQL Server when type conversions are implemented. This is being tracked by issue #242https://github.com/aspnet/EntityFramework/issues/242. Closing this as a duplicate of that issue.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/aspnet/EntityFramework/issues/6480#issuecomment-245462939, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIrJuogGToMeTtfqQEZSpEwQKmaWaEXHks5qn1t8gaJpZM4J2XT-.

These are the default conversions:

sbyte -> smallint
ushort -> int
uint -> bigint
ulong -> decimal(20, 0)
char -> nchar(1)

These can be used by changing the store type:

sbyte -> byte (not order preserving)
ushort -> short (not order preserving)
uint -> int (not order preserving)
ulong -> long (not order preserving)
char -> other string types of any size: char, nchar, varchar, nvarchar, text
char -> int


Update Readme

Current readme doesn't reflect all the files that are used within the same version.

Fixed in PR: https://github.com/eastgenomics/eggd_vep_CEN_config/pull/17


Create savalan-neisary

Hi
I added my information. Would you please accept it?
Thanks

Thanks for doing it for me!!! Sorry, I forgot to change it to .yaml.


Fixing typo on service log output.

- What I did
Fixed a typo.
- How I did it
With my editor.
- How to verify it
Run 1.12-rc2 in swarm mode, create two services with the same name while tailing the logs. Before patch will say "Error reating...", after will say "Error creating...".
- Description for the changelog
Fixing typo on service log output.
- A picture of a cute animal (not mandatory but encouraged)

LGTM

LGTM 🐮


StatusBar becomes light when dropdown open

I found strange issue. When I open dropdown - my status bar become light.
Status bar color implemented in next way in my root component:
<StatusBar backgroundColor="rgba(0,0,0,0.2)" barStyle="dark-content" translucent />

Thanks for issue and sorry for delayed reply. Looks like this should be fixed in RN, however there is an alternative solution, based on fix in styles.xml. Please take a look at facebook/react-native#7474.


Feature Request: Arabic Language Support and Explanation

Description:
I kindly request the addition of Arabic language support and explanation capabilities to GitHub Copilot Chat. As an Arabic-speaking user, it would greatly enhance my experience and productivity to have the ability to communicate with Copilot in Arabic.
Benefits:

Improved Accessibility: Arabic is one of the most widely spoken languages worldwide, and incorporating support for it would make GitHub Copilot more accessible to a larger user base.
Enhanced Collaboration: Many developers who communicate primarily in Arabic would benefit from being able to interact with Copilot in their native language. This would facilitate better collaboration and understanding within teams.
Increased Productivity: Arabic language support would enable Arabic-speaking developers to write code and explanations more efficiently. Copilot's assistance in Arabic would help reduce language-related barriers and improve code quality and accuracy.

Explanation in Arabic:
الرجاء إضافة دعم للغة العربية وإمكانية شرح الأكواد في GitHub Copilot Chat. كمستخدم يتحدث العربية، ستزيد إمكانية التواصل باللغة العربية من فائدتي وإنتاجيتي بشكل كبير في استخدام GitHub Copilot.
الفوائد:

تعزيز الوصولية: تعتبر العربية من أكثر اللغات المنتشرة في العالم، وبإضافة دعم اللغة العربية ستصبح GitHub Copilot أكثر قابلية للوصول لعدد أكبر من المستخدمين.
تعزيز التعاون: العديد من المطورين الذين يتواصلون بالعربية سيستفيدون من القدرة على التفاعل مع Copilot بلغتهم الأم. سيسهم ذلك في تعزيز التعاون والتفاهم بين الفرق.
زيادة الإنتاجية: سيمكن دعم العربية المطورين الناطقين بالعربية من كتابة الأكواد والشروح بشكل أكثر كفاءة. ستساعد مساعدة Copilot بالعربية في تقليل الحواجز اللغوية وتحسين جودة الأكواد والدقة.

I hope you consider my feature request for Arabic language support and explanation capabilities in GitHub Copilot Chat. Thank you for your attention to this matter.

I understand your intention...but it would take a very long time to implement it...as it should not be implemented for arabic only but for most of the world's spoken language.
Because, your are saying it for arabic then some day another person comes out to say add french and so on and so forth.
Plus,The ChatGPT model is made in such a way to produce english correctly so it would be a mess to again teach him in all languages(if we do not use a translator)
And adding a translator can produce mistakes which again needs to be fixed.
Therefore i think that you should not close this issue as it will take a long life of atleast 5 yrs to implementation.
Its comparatively new so i think it should need more time....

I believe using a translator to offer assistance is acceptable, even if it may occasionally result in errors.

I believe using a translator to offer assistance is acceptable, even if it may occasionally result in errors.

Errors would change the meaning i think!
As it is with the case of google translator

https://github.com/microsoft/vscode/issues/86667


maybe_connect is possibly racy

This seems to consistently happen in travis:
https://gist.github.com/kevints/1a1279e6ce4d7ec650e0
This is probably a misunderstanding about how to asynchronously create sockets in tornado, but we should fix this up asap so that we can get our travis builds green.

Fixed at 900fe867.  send and link tried to establish socket connections directly rather than enqueueing those requests on the event loop, which causes epoll-based implementations to shit the bed but not kqueue.


add k3s provisioning as GA in 2.7.0

Signed-off-by: Gary A Korhonen<EMAIL_ADDRESS>
Summary
Fixes #7361

Occurred changes and/or fixed issues

What's New for 2.7.0 now includes mention of k3s provisioning being GA
Technical notes summary

Areas or cases that should be tested

Load What's New and ensure that k3s provisioning as GA appears.
Areas which could experience regressions

Screenshot/Video

Apologies, didn't see any additional reviewers and on a mission to branch for 2.7.0.
@gaktive Can you make sure any updates go in to release-2.7.0 and master?

Just noticed, the what's new page has title: What's New in 2.6, which should probably just be What's New in 2.6?

Will file a new PR upon updates from @leflambeur

k3s provisioning is GA (x86 Only)

Provisioning K3s clusters on x86 clusters has graduated to GA!
The fully compliant Kubernetes distribution is simplified, secure and at less than 60mb is perfect for Edge.


Groupings 884

This is the working DOM code for the clear button in the import modal. Michael said to push this working code and create a ticket for the future to change this code using AngularJS. There are no tests for this feature.

Does this also need to be applied to dev-2-2-0?

Does this also need to be applied to dev-2-2-0?

My opinion to this is no, it should stick in 2-3-0 since it is a new feature. As of right now, the user can refresh the page to remove the file and upload another one. In my opinion, this is not fix to a critical bug that needs to go out in 2-2-0.
Any thoughts?

Good point.  Future features are for the master branch only.  Thanks for catching that.


Check for more error conditions and add additional tests

Fixes #13434, #13437 and #13438 and supports using class type aliases to create new objects.

Oh, and it strikes me that that  wording isn't actually accurate. A type alias can be used with certain builtin functions.

thanks!


Firefox wrapper preserve addon settings

Motivation for this change
In the current firefox wrapper every addon update discards the addon settings, like mentioned here https://github.com/NixOS/nixpkgs/issues/105783#issuecomment-739212366.
Things done
This change makes the extid static and user defined. However now it has to be made sure that every addon gets assigned an unique name by  the user. I do not know how to do that in the nix language so if someone knows how please comment how ^^.
I would like to do something like this:

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Yes, this is what I had in mind. However, i do not really like the 12345@, in the implementaion I currently use I add an attr to fetchFirefoxAddon that allows me to specify the extid myself


Update go-sqlite3 to 1.14.22

Not sure what's up with the Windows CI. What's the goal of this update, just out of curiosity?

Not sure what's up with the Windows CI
Build required go 1.19. Upgrading image and setup seemed to work.

What's the goal of this update, just out of curiosity?

This upgrades sqlite from 3.39.4 (Sept '22) to 3.45.1 (Jan '24).

My question is more about: why do you need this upgrade

Thanks btw!

My question is more about: why do you need this upgrade

No particular reason - chain of events: json1 functions didn't work, thought this pod needed an upgrade, turned out I copy-pasted an old pod-version from the bb-book (hence that PR), already did the work so therefor this PR :)
Thanks for the merge!


Fix changelog.sh for Windows

Previous version doesn't work correctly (it miss first commit message in changelog list).
I can't understand this behavior, but this commit fix it.

@bajtos , I'm ready to merge this one and release 0.8.2
Also I'm glad to notice that now we have prebuild binaries for Linux and OSX x64 (I'm ready to add x32 atoreleasing if it's needed)

First .gitignore rule is ._*, I get the name relative to this rule. Correct me if understand incorrect this mask.

Oh, I did not realise we have such rule in .gitignore.
Let's not dwell on details and ship this patch then.
LGTM.


How to evaluate mAP with no instances detected?

Hi, we have a network that has been trained in a particular way, and sometimes it hasn't a great accuracy. We noticed that, for the mAP calculation in instance segmentation, the script requires at least one prediction per frame. However, there are frames where we fail to detect any instance. How can we run an evaulation on those? Thanks in advance.

Hi, did you try to create an empty .txt file for those frames where you have no prediction?

What is the error message/stacktrace?


improvement: add fixup commits

Added the ability to create a fixup commit, similar to the way magit allows. However, I much prefer the type-ahead/quick pick style in VSCode, so I think that is the way to go. Open to any/all feedback.

Resolves: https://github.com/kahole/vscode-magit/issues/9

I'll add matchOnDescription to the quickMenu util post-merge. So you can still search messages and full hashes


Fix awaiting an array of custom attributes

Also fixed errors being caught, and not stopping the process when encountered (by re-throwing the error after logging it).
Also formatted file using prettier (Sorry about the diff being a bit noisy, I'm using vscode with auto format on save turned on).

Fixes #6

Thanks for the fix. I am going to accept this change. Can you please include your .prettierrc file here so that we can include it in this repo?


Mark latest CommunityResourcePack as explicitly compatible with KSP 1.1.2-1.1.99

Mark latest CommunityResourcePack as explicitly compatible with KSP
1.1.2-1.1.99.
Hopefully future versions of CRP will have an updated .version file.   The mod contains configs only, so nothing from 1.1.1 to
1.1.2 should break anything.

Also, most of RoverDude's mods have already been updated for 1.1.2 and depend on this (which he owns), so I'm fairly certain it's safe to say it's compatible.

You'll have to PR directly to the file listed in the $kref and not to us. https://github.com/BobPalmer/CKAN/


Setting a limit for file cache capacity

Is your feature request related to a problem? Please describe
Following up to #14004 . Currently we use the total space of file cache path to verify the user-defined file cache size setting.
https://github.com/opensearch-project/OpenSearch/blob/c71fd4a2f2e6d5d7d9f2f304c573180027af8f44/server/src/main/java/org/opensearch/node/Node.java#L2033
For the cache scenario, it seems to be not reasonable. The file cache will try to evict blocks when the watermark is higher than user-defined size. At the same time, the query task may need other new blocks that are located at remote storage, if the tolerance space( totalSpace - fileCacheSize) is very small, there will be no free space for caching new blocks and the query task will fail.
Describe the solution you'd like
There are some options:

the user-defined file cache size must be less than a specific percentage of total space (hard code), like 95%;
the tolerance size must be larger than a specific size (hard code), like 50G;
add another tolerance size setting(non-dynamic, can be set as byte size or percentage).

Related component
Storage:Snapshots
Describe alternatives you've considered
Treats the current file cache capacity as the maximum size allowed, and introduces another setting evict_watermark that is the percentage of the file cache capacity. When the total size of cache entries occupies a proportion of the cache capacity that exceeds the preset watermark, the file cache begins to attempt to evict entries. When a new block needs to be cached and there is no free space in the file cache, we can fail the corresponding query or we can use an on-heap memory block to hold this file block and to serve the query.
In this way, the behavior of the file cache may become more predictable, especially when the search node is deployed with other node roles on the same node, to ensure that the file cache does not encroach on disk space for different purposes, which then affects the normal operation of the node. And when implementing a writable warm index, we may also need to set a file cache along with a local directory, if a sudden large number of queries or a big query causes the file cache to take up all the available space, it can cause writes to fail.
Additional context
No response

@andrross @kotwanikunal  any thoughts?

the user-defined file cache size must be less than a specific percentage of total space (hard code), like 95%;
add another tolerance size setting(non-dynamic, can be set as byte size or percentage).

@bugmakerrrrrr These ideas seem reasonable. One thing to consider is the behavior of the system once it crosses into the disk watermark thresholds. Should we even allow a cache size to be larger than the watermark thresholds?


Next 8288

1. Why is this change necessary?
GDPR Compliance
2. What does this change do, exactly?
* Removed `required` status for `firstName` and `lastName`on `newsletter-form.html.twig`
* Added fallback for missing `getFirstName` and `getLastName` on `NewsletterRegisterEvent.php`

4. Please link to the relevant issues (if any).
https://github.com/shopware/platform/issues/819
shopware.zip

hey @kiplingi
please squash your commits and adjust the commit message just like shown in the document provided in the slack channel.

also your branch needs a rebase :wink:

I made a new pull request for this: https://github.com/shopware/platform/pull/936


CORE-5786: Be lenient about SQLTransientException in DB Bus

SQLTransientException may occur when a connection cannot be retrieved from a Hikari pool.
In particular this scenario may happen when people sit on a breakpoint for long enough, therefore exceeding default time (of 30 seconds) to retrieve a connection from a connection pool.
If we do nothing, this exception will propagate causing Bus consumer/producers to fail. This wil in turn fail all the dependant services via Lifecycle coordinator chain, making Combined Worker unusable after execution resumed.
I have tested this change locally by stopping on breakpoint for over 5 minutes and once resumed Combined worker was still usable and status page shown no DOWN components.

Do we only care about these being during debugging?  Would we want to still error out in normal operation?
I ask because I've had this locally
val isDebug = ManagementFactory.getRuntimeMXBean().inputArguments.toString().indexOf("jdwp") >= 0

to keep eventually from failing when I'm at a breakpoint and it might be useful in a wider context (I wanted to put it in, but wanted to see where it would be more widely useful)

Do we only care about these being during debugging? Would we want to still error out in normal operation?
I ask because I've had this locally
val isDebug = ManagementFactory.getRuntimeMXBean().inputArguments.toString().indexOf("jdwp") >= 0

to keep eventually from failing when I'm at a breakpoint and it might be useful in a wider context (I wanted to put it in, but wanted to see where it would be more widely useful)

I was thinking of making it conditioned on debug agent being present, but I think it is OK even at "production" run with DB Bus to perform an extra one try in case of SQLTransientException before giving up.


Rework chainlink rebase

chainlink rebase should just do git rebase --update-refs main on all the leaf branches.

Need to test if it will work reliably


Modal Close On Escape keyboard = true Does Not Work

The JavaScript modal according to the doc should close when escape is pressed by default:
    keyboard        boolean    true Closes the modal when escape key is pressed

Even setting keyboard = true still does not close the modal when escape key is pressed.

Not working in Microsoft Edge but working in all other browsers

@GearTheWorld don't necropost on an issue closed 4 years ago. also, 3.x is now in maintenance mode, and and focus is now on getting 4.x stable. if you find it's still an issue using the latest 4.x, please file a new fresh issue.

Sorry I didn't notice about the years.  Ok I will test using 4.x  Thank you


chore: fix readme badge

Changes introduced in this pr:

Updates readme to fix badge

Codecov Report
Base: 32.62% // Head: 32.65% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (0f36843) compared to base (0b6eeff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   32.62%   32.65%   +0.04%
==========================================
  Files          33       33
  Lines        2128     2129       +1
==========================================
+ Hits          694      695       +1
  Misses       1434     1434

Impacted Files
Coverage Δ

arkworks/setups/src/r1cs/vanchor/mod.rs
49.80% <0.00%> (ø)

arkworks/r1cs-gadgets/src/poseidon/sbox.rs
32.00% <0.00%> (+2.84%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


whereIn crashes on empty list

Similar to #260, I am putting this boilerplate here and there:
return postIds.length ? await db.post.whereIn("id", postIds) : []

because if I don't, it crashes with:
SELECT ... FROM "post" WHERE "post"."id" IN ()
Error: syntax error at or near ")"

Do you think it's worth a similar shortcut on the ORM level (empty list = no query), or that's too magicky? What about subqueries? Technically whereIn([]) could be translated internally into whereSql`false`  but that's probably taking on too much...

I agree, implementing the same "none" query as in #260 is a bit magical (non-obvious), but anyway it's better than crashing with an SQL error.
Good point regarding sub-queries, need to support expected behavior in sub-queries as well.
db.person.find(123).select({
  pets: (q) => q.pets.whereIn('name', []),
})

Here I'd expect that person is returned with empty array of pets.
But there is a join to use an INNER JOIN so the relation becomes required:
db.person.find(123).select({
  pets: (q) => q.pets.join().whereIn('name', []),
})

And this would need to throw a not found, since it's what find does when can't find.
Or to return undefined for findOptional.
And need to consider cases when joining and using sub-queries in different ways.

Done, published in new orchid-orm version.
Empty whereIn will be resolved into none query.
The none now will handle sub-selects and joins better, see the updated docs.


Add github workflow to automatically assign labels on new issue creation

This workflow would automatically assign hacktoberfest accepted and gssoc extd labels once the issue is created. This will save time of the project admin.

It must be authenticative to @tanishaness whether issues are legit

It must be authenticative to @tanishaness whether issues are legit for gssoc-ext and hacktoberfest.

exactly


x seconds too late

Hi, I keep getting x seconds too late (usually 1-4 seconds). Is there a setting to improve this? Many thanks.

You can increase the interval parameters


Provide Design for landing page

Simple initial design cc @SofianeHamlaoui please cite the sections of the landing page with brief description

header
Logo & some small sentence about our goal and how OPEN we are
—————
What does Open Source Community mean ?
...
...
...
—————-
About this community and what’s our goal
...
...
Projects :

—————-
Transition between our goal and what we are doing and how to contribute
= how to join the community, join us on social networks.....
——————-
Made with ❤ by Algerians to Algerians or something like this ( by Algerians for Algeria .... )

A dark mode switch

subscribing to Newsletter for Open Source news

Simple Prototyping 1 :

Simple Prototyping 2 :

Colors :
1 ( cc @SofianeHamlaoui :+1: ) :

2 ( cc @SofianeHamlaoui :+1: ) :

3 ( cc @SofianeHamlaoui :+1: )  :

4 :

5 ( cc @SofianeHamlaoui :1st_place_medal: : ):

6 :

7 ( cc @SofianeHamlaoui :1st_place_medal: ) :

1 ( cc @SofianeHamlaoui :+1: ) :

2 ( cc @SofianeHamlaoui :+1: ) :

3 ( cc @SofianeHamlaoui :+1: )  :

4 :

5 ( cc @SofianeHamlaoui :1st_place_medal: : ):

6 :

7 ( cc @SofianeHamlaoui :1st_place_medal: ) :


GEOMESA-2748  Add support for dsParams which contains hbase Connection when creatin…

Sometimes, our dsParams contains hbase connection, as shown below.
val dsParams = Map(
"hbase.connection"  -> connection,
"hbase.catalog"     -> "xxx"
)
For instance, we have to create a special hbase connection for kerberos . We use  "hbase.connection" rather than  "hbase.zookeepers", so that we can set related configuration files.
However，we cannot create a rdd through "spatialRDDProvider.rdd(conf, sc, dsParams, query)" , for there is only Map[String, String] is allowed as a dsParams.
Since we have this type of dsParams which contains hbase connection，we'd better add support for these dsParams to create rdd. Aimed at this case, I add a function createRdd, so that we can use "createRdd(conf, sc, dsParams, query) " to create rdd.

Is there a something specific that requires you to pass in a connection instead of using hbase-site.xml to configure it? I don't think this approach is feasible, because spark is a distributed system - the parameter map has to be serialized and sent out to each worker. Since the HBase connection object is not serializable, it can't be passed in directly.

As of 2.4.0, you can set additional configuration files as parameters in the datastore. This may solve your issue with configuring the connection.


Merges the contents of the long running cloud-20 branch into main

This branch contains all of the cloud 2.0 commits which we'll now merge back into main.   Updating to the latest SDK also caused a merge conflict due to the list minute decision to rename provisioned_vcpus to provisioned_virtual_cpus.  That change was rebased into each of the commits in this list.
Additionally there is a commit on top to tag the provider release to 1.8.0.
Commit checklist

[x]  Changelog
[x]  Doc gen (make generate)
[x]  Integration test(s)
[x]  Acceptance test(s)
[x]  Example(s)

There were 2 errors during the acceptance test runs.  Both of which seem unrelated to this branch so I'm going to merge it down.  It has now been rebased to use the tagged version of the cockroach-cloud-sdk-go (v3.0.0)
For posterity, the errors were:
*pgconn.PgError: failed to create user cockroach-user for cluster with ID 5926ca44-7340-49c8-82a2-ba4440e0cca1: retrying txn failed after 50 attempts. original error: ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_SERIALIZABLE - failed preemptive refresh due to conflicting locks on /Tenant/1765/Table/4/2/202/0 [reason=wait_policy] - conflicting txn: meta={id=6e2e06e2 key=/Tenant/1765/Table/4/1/"cockroach-user-nopass"/0 iso=Serializable pri=0.11642794 epo=0 ts=1726709564.316920842,2 min=1726709563.656286716,0 seq=4}): "sql txn" meta={id=b01df34e key=/Tenant/1765/Table/4/1/"cockroach-user"/0 iso=Serializable pri=0.11642799 epo=42 ts=1726709564.353887001,2 min=1726709501.481762885,0 seq=51} lock=true stat=PENDING rts=1726709562.962337882,0 wto=false gul=1726709501.731762885,0 isn=1 (SQLSTATE 40001).

and
=== NAME  TestAccMetricExportPrometheusConfigResource
metric_export_prometheus_config_resource_test.go:115: Error running post-test destroy, there may be dangling resources: exit status 1
    Error: Error deleting cluster

    Could not delete cluster: cannot delete locked cluster


Namespace schema shows repeated methods in collectionMethods

See UI ticket:
For a standard user, the namespace schema includes repeated methods:
Looking at the response to /v1/schema/namespace, collectionMethods returns as:
"collectionMethods": [
  "GET",
  "GET",
  "GET"
],

GET should not be repeated
This may affect other resource types.

@Jono-SUSE-Rancher we're thinking this might be more of a team 1 issue, rather than team 2.

Yeah that's fair. I wasn't entirely certain when I assigned it. @samjustus please take a look with your team when you get a chance.

Bumping to 2.6.7

moving out of 2.7 as we have other priorities from UI team @nwmac

The following schemas (management.cattle.io.project, management.cattle.io.cluster) have duplicate entries for the GET method under collectionMethods as well.
management.cattle.io.project:
{
"id": "management.cattle.io.project",
"type": "schema",
"links": {
"collection": "…/v1/management.cattle.io.projects",
"self": "…/v1/schemas/management.cattle.io.project"
 },
"description": "Project is a group of namespaces.\nProjects are used to create a multi-tenant environment within a Kubernetes cluster by managing namespace operations,\nsuch as role assignments or quotas, as a group.",
"pluralName": "management.cattle.io.projects",
"resourceMethods": [ 4 items
"GET",
"DELETE",
"PUT",
"PATCH"
 ],
"resourceFields": null,
"collectionMethods": [ 3 items
"GET",
"GET",
"POST"
 ],
namespace:
{
"id": "namespace",
"type": "schema",
"links": {
"collection": "…/v1/namespaces",
"self": "…/v1/schemas/namespace"
 },
"description": "Namespace provides a scope for Names. Use of multiple namespaces is optional.",
"pluralName": "namespaces",
"resourceMethods": [ 4 items
"GET",
"DELETE",
"PUT",
"PATCH"
 ],
"resourceFields": null,
"collectionMethods": [ 3 items
"GET",
"GET",
"POST"
 ],

management.cattle.io.cluster:
{
"id": "management.cattle.io.cluster",
"type": "schema",
"links": {
"collection": "…/v1/management.cattle.io.clusters",
"self": "…/v1/schemas/management.cattle.io.cluster"
 },
"pluralName": "management.cattle.io.clusters",
"resourceMethods": [ 4 items
"GET",
"blocked-DELETE",
"blocked-PUT",
"blocked-PATCH"
 ],
"resourceFields": null,
"resourceActions": {
"apply": {
"input": "applyInput",
"output": "applyOutput"
 },
"generateKubeconfig": {
"output": "generateKubeconfigOutput"
 }
 },
"collectionMethods": [ 3 items
"GET",
"GET",
"blocked-POST"
 ],


Windows and platform specific class Dir (as an example)

Currently, I have dir.cr(which just requires relevant file), dir.posix.cr and dir.windows.cr in my branch. I took https://github.com/crystal-lang/crystal/pull/4770 as an example and, apparently, I just need to move platform specific things into its own namespace, but it's not clear for me how to do it for platform specific instance variables. For example, if there are
class Dir
    @dir : LibC::Dir*
    def initialize(@path)
        @dir = LibC.opendir(...)
    end
end

class Dir
    @handle : LibC::Handle
    def initialize(@path)
        @handle = LibC::INVALID_HANDLE_VALUE
    end
end

so how things are going to look? Can someone explain it to me?

The way I implemented it when I abstracted IO::FileDescriptor is likely helpful to you. The commit is here. What I did was I extracted the minimum platform-specific functionality to another class, called Crystal::System::FileHandle (you should create a Crystal::System::DirHandle). Surely though, you say, that's just recreating the IO::FileDescriptor class in Crystal::System and forwarding all methods? Well, there are two differences between Crystal::System::FileHandle and IO::FileDescriptor: IO::FileDescriptor is buffered, and Crystal::System::FileHandle doesn't include any helper methods which don't include platform specifics in themselves. Yes, IO::FileDescriptor forwards a lot of it's methods directly to the handle but it does add quite a bit of platform-agnostic functionality.
So, I suggest you create a Crystal::System::DirHandle and implement Dir in terms of that. You should be able to make DirHandle a struct here, so in the end there will actually be pretty much 0 overhead.


Add pod lifecycle options

What is your feature request?
In the Chart we currently don't have an option to add a lifecycle to the pods.
These lifecycle hooks can be useful in a number of situations where we need to patch small parts of the pod.
An example could be:
          lifecycle:
            postStart:
              exec:
                command: ["/bin/sh", "-c", do_something.sh]

To give a concrete example, I am currently facing this issue https://github.com/apache/airflow/issues/8212.
To fix this I need to patch a single file in the container. I could of course go ahead and build my custom container - having a lifecycle hook would be very simple though.
Implementation should be really simple and straight forward - just forwarding whatever the user specifies in the values.yaml.
It would be good to have this, as anything else, once globally and additionaly an option to overwrite for the individual components.

@c-thiel Sounds like an interesting idea, what do you think the values could look like?

@thesuperzapper in the values.yaml I would simply add an empty lifecycle: {} option to all components.
This can then be filled by the users according to the docs: https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/

@c-thiel do you want to create a PR for this feature?

Hi, how's it going, is there a possibility of this functionality being added in the future? My team has come across this issue where we want to copy some file from a shared volume to a path on the container and run some extra commands after using a postStart lifecycle hook. But currently aren't able to do so

@iSWATxJOKERi thanks for the PR, I will take a look at it.


Unsubscribe in OnDestroy

I think it should be mentioned in documentation that all subscriptions initialized in OnInit method should be unsubscribed in OnDestroy method.
I've come to lot of problems with subscriptions being evaluated multiple times before I realized that..

We are covering RxJS usage in a forthcoming guide where this topic will be discussed.


Add use_env_var flag to client

Signed-off-by: Jun Ki Min<EMAIL_ADDRESS>Description
Introduce an option to select between env vars and config yaml file.
Feathr client to use explicitly configured yaml file over environment variable if use_env_var flag is set to False.
The changes are added as the last argument of the existing functions and set default to True (use env variables) so that
existing codes don't break.
Resolves #922
How was this PR tested?

Unit test
Does this PR introduce any user-facing changes?

[ ] No. You can skip the rest of this section.
[x] Yes. Make sure to clarify your proposed changes.

Hello @loomlike seems this doc should get updated as well https://feathr-ai.github.io/feathr/how-to-guides/feathr-configuration-and-env.html#configuration-and-environment-variables-in-feathr
Can I ask is there any use case for introducing this new env? Have this new flag can make configuration more flexible but it introduces complexity on configuration code as well.

Hello @loomlike seems this doc should get updated as well https://feathr-ai.github.io/feathr/how-to-guides/feathr-configuration-and-env.html#configuration-and-environment-variables-in-feathr
Can I ask is there any use case for introducing this new env? Have this new flag can make configuration more flexible but it introduces complexity on configuration code as well.

The default behavior is to override the config file values (use_env_vars=True) so I think we can keep the document as it is.
Usecases are mostly for us to test with different configuration of the client, since if we change the env var of the test machine for each test case, it's not safe (someone can forget to put the original env var back at the end of the test) as well as parallel testing will not work as they'll share the env vars.


i18n(pt-BR): Add directives-reference.md translation

What kind of changes does this PR include?

[ ] Minor content fixes (broken links, typos, etc.)
[ ] New or updated content
[x] Translated content
[ ] Changes to the docs site code
[ ] Something else!

Description
PT-BR translation for directives-reference.md

@Yan-Thomas, I told you :)

Thanks for the review @victor0x16!
I think I have killed the link checker somehow... :fearful:

Paging @hippotastic !

So good news, I just updated the branch of another existing PR and the link checker completed just fine. So, it must be localized to here. I'll try re-running the test here. I've never seen it just fail this early before!  😅

I don't see an issue. Logs look normal. The build has been cancelled by another build being started by the CI workflow. I'll probably separate the build step from the actual link check sometime to make it more clear that these are usually build issues and not link check issues. :)


Health status for some entities

Feature request
There should be a health status for at least the following entities

Doors
Lifts
Dispensers
Ingestors
Fleets
Robots

Implementation considerations
The health statuses should be in a different topic from the state messages so that it is still possible to receive the health status even if the adapters crash for any reason. They should also be published from a node with failover for better resilience.
Alternatives

Additional information

Could you elaborate on what health means, if it's something different from state? In DDS there are topic heartbeats that can let you know a node is still up and able to publish, even if it hasn't published anything in a while, but since you're talking about the "health" coming from a different node, I guess you're asking for something else.
We're working towards a point where every node has reliable fail over. If we assume that all state publishers will (eventually) have reliable fail over mechanisms, then is there something else you're looking for that would indicate "health"?

I imagine the meaning of "health" would be different for each type of entities. In general, I would define it loosely as "an entity having an abnormal state which might require user intervention". For example a state publishing node (without fail over) that crashed would be an important event that the user should be aware of.
In most cases, it could be part of the state, but it would be good if there more information is available for the cause of "bad health". e.g. A lift is down because of scheduled maintenance. The case for a separate health node/topic is mostly when it is not possible to have a reliable fail over, e.g. a door/lift adapter that uses embedded hardware.


Add an accessor for i2c_master_bus_t->status because i2c_master_transmit_receive returns ESP_OK on device failure! (IDFGH-12075)

Is your feature request related to a problem?
Originally posted here: Why does i2c_master_transmit_receive return ESP_OK when the device is unplugged?
I can successfully read from an I2C device (its an RTC clock) and it works. However, if the device is disconnected from the bus, the i2c_master_transmit_receive() function always returns ESP_OK.
Digging through the code, it appears that synchronous requests will set (or rather, pass-through) any of these in i2c_master_bus_t->status:

I2C_STATUS_ACK_ERROR
I2C_STATUS_TIMEOUT
I2C_STATUS_DONE

as shown in esp_driver_i2c/i2c_master.c:
    if (i2c_master->status != I2C_STATUS_ACK_ERROR && i2c_master->status != I2C_STATUS_TIMEOUT) {
        atomic_store(&i2c_master->status, I2C_STATUS_DONE);
    }

Describe the solution you'd like.
Provide an API accessor, something like this:
i2c_master_status_t i2c_master_get_previous_io_status(i2c_master_bus_handle_t i2c_master)
{
  return i2c_master->status;
}

and expose these enums publically (if they are not already):
 */
typedef enum {
    I2C_STATUS_READ,      /*!< read status for current master command */
    I2C_STATUS_WRITE,     /*!< write status for current master command */
    I2C_STATUS_START,     /*!< Start status for current master command */
    I2C_STATUS_STOP,      /*!< stop status for current master command */
    I2C_STATUS_IDLE,      /*!< idle status for current master command */
    I2C_STATUS_ACK_ERROR, /*!< ack error status for current master command */
    I2C_STATUS_DONE,      /*!< I2C command done */
    I2C_STATUS_TIMEOUT,   /*!< I2C bus status error, and operation timeout */
} i2c_master_status_t;

Describe alternatives you've considered.
Could try using the async code and work with the i2c_master_event_t enum values in the i2c_master event callback.
According to the forum response, that should work, but I've not tried it yet.
However, it would be nice to trivially query the status of the previous i2c request for sync requests without setting up everything needed for async.
Additional context.
No response

(I'm adding mention of #13134, but I think thats a slightly different issue.)

I know there is no nack checking... Fine, I will add one...

After some testing, the callback  NACK checking does not work in async, either.  It always returns I2C_EVENT_DONE even if you unplug the device.  Here is a simple esp32 test project that can toggle either sync or async operation in case it helps with testing new NACK support:

https://github.com/KJ7LNW/esp32-i2c-test/

IMHO, error handling is a critical consideration in microcontroller development: Maybe this should be escalated from Feature to BUG status.

@mythbuster5, I was going to write a PR for this issue, but it looks like i2c_master->status is always I2C_EVENT_DONE after a sync transaction.    I tried commenting the atomic_store line just to see what ends up in i2c_master->status, even if it fails (of course that breaks the FSM, this is just a test); it contains I2C_STATUS_STOP but I was hoping for something like I2C_STATUS_ACK_ERROR:
https://github.com/espressif/esp-idf/blob/60a2bf6a68867fd468a250966230a067f8d97ea2/components/esp_driver_i2c/i2c_master.c#L439-L441
However, i2c_master_probe() is able to detect a I2C_STATUS_ACK_ERROR so I'm not sure what needs to happen so that s_i2c_send_commands() can pass an error back up to functions like i2c_master_transmit() so the caller can know that the IO failed.  Here is i2c_master_probe()'s detection of a missing device:
https://github.com/espressif/esp-idf/blob/60a2bf6a68867fd468a250966230a067f8d97ea2/components/esp_driver_i2c/i2c_master.c#L1064-L1070
Below is the diff we were working on, it's just a i2c_master->status accessor.  Do you know what needs to happen to handle missing devices and failed requests?
diff --git a/components/esp_driver_i2c/i2c_master.c b/components/esp_driver_i2c/i2c_master.c
index 175fb15703..5a50f048b4 100644
--- a/components/esp_driver_i2c/i2c_master.c
+++ b/components/esp_driver_i2c/i2c_master.c
@@ -967,6 +967,11 @@ esp_err_t i2c_master_bus_reset(i2c_master_bus_handle_t bus_handle)
     return ESP_OK;
 }

+i2c_master_status_t i2c_master_bus_status(i2c_master_bus_handle_t i2c_master)
+{
+    return i2c_master->status;
+}
+
 esp_err_t i2c_master_transmit(i2c_master_dev_handle_t i2c_dev, const uint8_t *write_buffer, size_t write_size, int xfer_timeout_ms)
 {
     ESP_RETURN_ON_FALSE(i2c_dev != NULL, ESP_ERR_INVALID_ARG, TAG, "i2c handle not initialized");
diff --git a/components/esp_driver_i2c/include/driver/i2c_master.h b/components/esp_driver_i2c/include/driver/i2c_master.h
index 228f64fcc9..b8b9bb0abf 100644
--- a/components/esp_driver_i2c/include/driver/i2c_master.h
+++ b/components/esp_driver_i2c/include/driver/i2c_master.h
@@ -196,6 +196,18 @@ esp_err_t i2c_master_register_event_callbacks(i2c_master_dev_handle_t i2c_dev, c
  */
 esp_err_t i2c_master_bus_reset(i2c_master_bus_handle_t bus_handle);

+/**
+ * @brief Return the status of the last I2C transaction.
+ *
+ * @param bus_handle I2C bus handle.
+ * @return
+ *      - I2C_STATUS_DONE: I2C command done
+ *      - I2C_STATUS_TIMEOUT: I2C bus status error, and operation timeout
+ *      - I2C_STATUS_ACK_ERROR: ack error status for current master command
+ *      - Otherwise: transaction in progress (see `i2c_master_status_t`)
+ */
+i2c_master_status_t i2c_master_bus_status(i2c_master_bus_handle_t i2c_master);
+
 /**
  * @brief Wait for all pending I2C transactions done
  *

@mythbuster5
It's marked as Resolution: Done since Jun 24, but it's not yet closed.
How is the status of this issue now?

It should be done already, I forgot to close it.


Fix nuget package versions

fixes #12

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: cecilphillip sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


feat: Action selector redesign

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

Add a TL;DR when description is extra long (helps content team)

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Manual
Cypress

Test Plan
Covered in https://github.com/appsmithorg/appsmith/pull/18166
https://www.notion.so/appsmith/Trigger-fields-a9e9f78fddfd428f861abcce6a251706
Issues raised during DP testing

[ ]  QA round 2 - https://github.com/appsmithorg/appsmith/issues/20666
https://github.com/appsmithorg/appsmith/issues/20016
https://github.com/appsmithorg/appsmith/issues/20015

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview env=release

/build-deploy-preview env=release

This feature is moved to https://github.com/appsmithorg/appsmith/pull/21582


API: Create route for a user to see V3 positions and associated analytics

This API route will be the backbone of our 'Portfolio Management' feature, to be delivered in a 'basic' version on May 5th and to be one of our biggest priorities post-launch. The goal for this API route is to take a wallet address and return a summary of the positions for that address, both opened and closed.
Data for an individual position should contain:

The pool associated with that position (pair + fee tier)
Address of the position's NFLP
The date the position was opened
The date the position was closed (if applicable)
Total liquidity of position at entry (including individual token amounts and notional USD)
Tick range of position, including mid-pricce
Price of each token at entry (in USD)
Total liquidity of tick range of position at entry
Total liquidity of tick range of position at close/current
Total liquidity of pool at entry
Total liquidity of pool at close/current
Fees collected for position
Impermanent loss for position (within the tick range)
% of trade volume within position, over lifetime of position
Notional USD gain of the position
NICE TO HAVE: gas cost of entering the position

Acceptance Criteria:
Route exposed to get position details for v3
Route validates address is a valid ETH address
Route returns position details  for each position, with fields specified above
API Integration tests written for route

We need to figure out what we will be able to get from the subgraph and what we will have to get from other sources.


The app is getting stuck on "Generating Recovery Keys" loader module.

This is fixed in # 190

-Verified this on dev app v1.4.0(190)


Anonymous transition from outer state that has sub machine should wait sub machine's termination

See the following diagram:
Sm

+------------+       +---------+
|*state:Sub  |------>| State2  |
|            |       |         |
+------------+       +---------+

Sub

+------------+  Event1
|*SubState1  |--------->X
|            |
+------------+

UML specification said that Sm's anonymous transition invokes when Sub arrives at terminate state.
#include <cassert>
#include <boost/sml.hpp>
namespace sml = boost::sml;
struct Event1 {};
struct Sub {
    auto operator()() const noexcept {
        using namespace sml;
        return make_transition_table(
            * "SubState1"_s + event<Event1> = X
        );
    }
};
struct Sm {
    auto operator()() const noexcept {
        using namespace sml;
        return make_transition_table(
            * state<Sub> = "State2"_s
        );
    }
};
int main() {
    using namespace sml;
    sm<Sm> sm;
    assert(sm.is(state<Sub>)); // actual state is "State2"_s
    assert(sm.is<Sub>("SubState1"_s));
    sm.process_event(Event1{}); assert(sm.is("State2"_s));
}

http://melpon.org/wandbox/permlink/dk6BWkG5oh60EiIP
However, it seems that anonymous transition invoked before Sub is terminated.

UML specification said that Sm's anonymous transition invokes when Sub arrives at terminate state.

Strictly speaking, UML specification said that Sm's anonymous transition invokes when Sub arrives at final state, not terminate pseudo state.
http://www.uml-diagrams.org/state-machine-diagrams.html#final-state
http://www.uml-diagrams.org/state-machine-diagrams.html#terminate-pseudostate
But I'm not sure SML should distinguish them or not.

This one is interesting. Thanks for pointing it out @redboltz. I wasn't aware of that. I will check it with UML and Boost.MSM and try to fix it ASAP.

Here is an example of the state machine:
http://redboltz.wikidot.com/exit-point-pseudo-state
AFAIK, Boost.MSM doesn't support the first diagram, but it supports the second one that is using exit point pseudo state with anonymous transition:
http://melpon.org/wandbox/permlink/aEJk9ZK5dSrqXKNH
Even if outer state machine's current state has an anonymous transition, it waits for reaching inner sub machine's state transition to the exit point pseudo state.

Thanks @redboltz for the examples. It would be really valuable to have entry/exit pseudo states. They are on my list to implement ASAP.

@redboltz do you happen to know, as I can't find it the UML spec, what about the case when sub machine has multiple orthogonal regions and only one of them is in final/terminate pseudo state?
Should the anonymous transition happen only if all regions are done or it's enough that one will be finished?

Implemented by https://github.com/boost-experimental/sml/commit/c10e541869c73c03aac246aad8b6a123636088d4
In the current version, all orthogonal regions have to be in a terminate state in order to anonymous transition to happen.

I've checked UML 2.5 specification.
http://www.omg.org/spec/UML/2.5/PDF/
In the following section:
<IP_ADDRESS>.3 Completion Transitions and completion events
I found the following sentence:
if the State is a composite State, all its orthogonal Regions have reached a FinalState
So, I think that your current implementation satisfied UML 2.5 spec.

I think that the anonymous transition from the parent state that have composite state or sub machine state is a completion transition.

Thanks @redboltz for checking it for me. I find UML 2.5 spec quite hard to deal with. It's really subtle.
Nevertheless, after deeper look, it seems like you are right and the implementation is fine. Yay!


Allow devices to determine the viewport for each eye

This makes the Window determine the viewports, not the demo appl

Rebased.

Rebased.

Rebased and split out getting the viewport from make_current.


libwebsockets: libuv, openssl should be propagated?

Describe the bug
Building with libwebsockets leads to errors like
/nix/store/kr9ivkvs7vy6bvwskf7cdh4r4f3kn64m-libwebsockets-3.2.0/include/libwebsockets.h:244:10: fatal error: openssl/ssl.h: No such file or directory
   #include <openssl/ssl.h>
            ^~~~~~~~~~~~~~~
  compilation terminated.

and
/nix/store/vmjqcmsd72sfps818p01iv9bj5kz3rgd-libwebsockets-3.2.0/include/libwebsockets.h:174:10: fatal error: uv.h: No such file or directory
   #include <uv.h>
            ^~~~~~
  compilation terminated.

Metadata
Please run nix run nixpkgs.nix-info -c nix-info -m and paste the result.

system: "x86_64-linux"
host os: Linux 4.19.86-gentoo, Gentoo, noversion
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.1
channels(root): "nixpkgs-20.03pre205780.d942688fc13"
channels(swim): "nixpkgs-19.09.1682.bfdae0860e4, nixpkgs-unstable-20.03pre206331.eeaf1f702d4"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixpkgs

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

This is still important to me.  I just started writing a program that uses libwebsockets with a nix flake and am encountering these odd behaviors that I thought would not show up.

How exactly do you try to build libwebsockets?


Saving actor to .obj

Sorry again Marco, I'm having problems saving meshes to .obj.
I've created a mesh with volume.isosurface and saved it as either .obj or .vtk, then just loaded the files and rendered:
obj = load('test.obj').c('red')
vtk = load('test.vtk').x(500).c('green')

show(obj, vtk)

The result is this:

Any idea about what could be going wrong?

Try with
pip install -U git+https://github.com/marcomusy/vtkplotter.git
this gives me:
from vtkplotter import *

m = load(datadir+'man_low.vtk').c('green').lw(1)#.triangulate()

m.write("man_low.obj")

obj = load('man_low.obj').c('red').x(2).lw(1)

show(m, obj, axes=1)

Hi,
It works perfectly fine in the example code above, but it still fails in the same manner with my mesh.
Looking at the content of the objs files:

it looks like a point is added repeatedly to test obj I create from my mesh, but not with the one from your example.

that's strange! you can maybe provide the source mesh?

Okay, the .obj file is quite large so I had to upload them somwehere, let me know if you can get them from here: https://drive.google.com/open?id=1khhZbPeHXBZfmR0RrefPnwjX4Q6YyZtd

..it was a bit painful but i could eventually find the bug..
i just ushed a version with the fix.
Note that the obj does not store scalars, only the mesh.
ps: the points in your dump are not added repeatedly... they 're just in the same yz plane.. i got confused by that to...

hi marco sorry, I've updated vtkplotter but I'm getting the same output, am I missing something?

hey sorry for the deleted comment, as you pointed out in https://github.com/marcomusy/vtkplotter/issues/120 I hadn't correctly updated from the master.
It now works perfectly, thank you so much!


jsonb column edit context issues

I've noticed the following 2 problems with jsonb column types when editing:

if annotated as 'generated', the display should indicate "Automatically generated" but does not (not sure if this is an ermrestjs or chaise bug)
if annotated with a 'display' annotation and 'markdown_pattern', the value will be changed per the markdown pattern and therefore no longer is (likely to be) a proper jsonb value. Really just the presentation should be changed not the underlying raw tuple value.

An example can be seen here:
https://cirm-dev.isrd.isi.edu/chaise/recordedit/#2/Microscopy:Collection/ID=4@sort(ID)

The first issue is related to chaise. In textarea that is used for json the placeholder (placeholder="{{::form.getDisabledInputValue(column, form.recordEditModel.rows[rowIndex][column.name]);}}") is missing.
The second issue is related to ermrestjs. Basically we're calling the function that takes care of formatting json column (which does "markdown_pattern" manipulation) in entry contexts.

@nitishksahu this one has you as a reviewer. If you want to ask @robes to review, please assign the appropriate assignee to the task.

@hongsudt this issue needed some code changes in chaise as well, the PR for this change is still open in chaise and the code has not been merged to master, so it is still in my queue.

The changes for this issue have been merged to master, assigning this to @robes to verify.


Adding a group to a Volume and then removing the group doesn't update the object inspector.

I've created a command in that command I 'Mesh's to a group that I add to a volume. Since there are a lot of them, I made a way to remove them from the volume. When I remove the meshes, they remain in the inspect. If I remove one of them from the inspector, it updates and the volume no longer has the groups as children.
The command lives here:
https://github.com/Living-Technologies/SciviewDM3D

The relevant code from MeshVolumeDemo first adds a bunch of groups to the volume.
        Node active = sciView.getActiveNode();
        Volume v = (Volume)active;
        Group g = new Group();
        g.addChild(mesh);
        sciView.addNode(g, v);

Then in the MeshVolumeNavigator the groups are removed from the volume.
    TreeMap<Integer, Group> meshes;
    meshes.values().forEach(v::removeChild);

Maybe I should be removing the nodes through the sciView interface. I'm sure there are a lot of problems going on here.

Yes, you are correct. To get UI updates you need to use the sciview API to remove them. You would use SciView.deleteNode.

That works, it is slow if I don't control the publish option.
        Iterator<Group> iter = meshes.values().iterator();
        while(iter.hasNext()){
            Node node = iter.next();
            boolean publish = ! iter.hasNext();
            sciView.deleteNode(node, publish);
        }

Is there a publish method?

Highlighting some of the issue:

Publishing events about nodes triggers scene rebuilds and rebuilds of the inspector tree and properties panel.
SciView.deleteNode does take care of a few other things, but triggers a NodeRemovedEvent for each call.
Some of the work triggered by NodeRemovedEvent shouldn't be done per-node, but instead should be per-scene/per-frame

@skalarproduktraum @ctrueden We've seen issues like this before and with enough regularity that we should probably do something more serious than the activePublish flag. My immediate proposal:
At both of the previously mentioned locations where NodeRemovedEvents trigger updates:

change the rebuild/update calls to flag setting logic (e.g. Properties.isValid)
then run the corresponding logic in the SciView and Properties classes conditionally on a per-frame basis (e.g. each timestep check if we need to run the rebuilds)

@odinsbane would you consider this closed if we get this merged: https://github.com/scenerygraphics/sciview/pull/594
Otherwise having deletion work with the removeChild methods would be a bigger ask since that means connecting the scenery methods to the corresponding sciview instance.

Yes! I am not sure where this flag is, but when you told me to use sciview
to remove the node. That flag works ok too.
On Mon, Jun 3, 2024, 4:14 PM Kyle I S Harrington @.***>
wrote:

@odinsbane https://github.com/odinsbane would you consider this closed
if we get this merged: #594
https://github.com/scenerygraphics/sciview/pull/594
Otherwise having deletion work with the removeChild methods would be a
bigger ask since that means connecting the scenery methods to the
corresponding sciview instance.
—
Reply to this email directly, view it on GitHub
https://github.com/scenerygraphics/sciview/issues/578#issuecomment-2145313812,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2NNEPH32KDBDVRYMQOUGLZFR25BAVCNFSM6AAAAABGNKQXP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGMYTGOBRGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Great, and the PR should speed up node deletion for many nodes.


Leave no apk cache in Docker image

Use apk add with --no-cache will prevent leaving cache in the released image, and it's now kind of Dockerfile best practice.

Wrong repo...


CI: Fixup

Use high-level graphs.

https://github.com/dask/dask/issues/4298 for the IndexError failures.
https://github.com/dask/dask/issues/4299 for ValueError in label.py.

I think that all remaining failures are due to bugs in dask itself. I'll wait to update this until those are fixed upstream.

Tests are passing, so I'm going to merge.


Propose more common apps

Hi @merill,
Thanks for making this, this is extremely useful!
I have taken a look at the most common apps across a number of tenants, and here is a list of common apps that appear to be first-party.
Two of the techniques that I have tried to check if an app is first-party or not:

Visit https://login.microsoftonline.com/common/adminconsent?client_id={appId} or https://login.microsoftonline.com/common/oauth2/v2.0/authorize?scope=openid&response_type=code&client_id={appId}, then:

Manually follow the flow to see if a consent screen is displayed or not. Most first-party apps will instead redirect with an URL parameters error=invalid_request&error_description=AADSTS65002...
Inspect the value of the JavaScript variable $Config.sCompanyDisplayName (this can be scripted easily and doesn't require an account). Most first-party apps have Microsoft Services (one has Orgid Migrated Apps, some don't have the field...).

These are clearly hacks... if anyone has a better solution, I'm very interested!

This is great. Thanks @gcl-sekoia !