Please change color scheme

I've read through https://github.com/visionmedia/mocha/issues/802 and https://github.com/visionmedia/mocha/issues/590
I believe I've found where the issue lies:
Snippet from base.js
https://github.com/visionmedia/mocha/blob/master/lib/reporters/base.js
exports.colors = {
    'pass': 90
  , 'fail': 31
  , 'bright pass': 92
  , 'bright fail': 91
  , 'bright yellow': 93
  , 'pending': 36
  , 'suite': 0
  , 'error title': 0
  , 'error message': 31
  , 'error stack': 90
  , 'checkmark': 32
  , 'fast': 90
  , 'medium': 33
  , 'slow': 31
  , 'green': 32
  , 'light': 90
  , 'diff gutter': 90
  , 'diff added': 42
  , 'diff removed': 41
};

var color = exports.color = function(type, str) {
  if (!exports.useColors) return str;
  return '\u001b[' + exports.colors[type] + 'm' + str + '\u001b[0m';
};

So the color function takes in a type and uses the conversion table above to get the ANSI escape color.
A chart can be found here:
http://en.wikipedia.org/wiki/ANSI_escape_code#CSI_codes
As you can see:

Seems to be a closed-source terminal from IBM AIX.
I believe nobody is using mocha on it. (Correct me if I'm wrong)
Furthermore, I found the ECMA specification:
http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf
Here is page 62:

Color 90-99 are not in the specification. Most terminals wouldn't care implementing these colors correctly and god knows what color they'll fall back into.
And not everyone uses iTerm2, which has a contrast setting.
Please use color 30-37, if you want increased intensity then \u001b[30;1m would use the intense variant.
I think users are only responsible for configuring their terminals so the 16 colors look great on their bg/fg colors. So please don't just say "It's the theme's fault" and close the issue. It's mocha's problem not using color from the standard palette.

This is still as issue when using solarized color scheme:

Any chance this has been addressed somewhere that works with release version.  I have tried all the various tweaks outlined above, but nothing works.   My issue is that I cant see any of the messages in terminal (running MobaXterm on Windows).

@boneskull
I just see this get reopened. How do you plan to fix it?

I'm just going to use chalk so nobody can complain Mocha uses weird ANSI escape sequences.

if people have a problem with the colors thereafter, it's really, truly, not Mocha's fault

(we're locked to v0.4.0 of chalk to keep node v0.8.0 support--its default npm version doesn't grok carets)

oops.

reopening since this had to be reverted.
we can still use standard colors by using chalk's dependencies (maybe), but not chalk itself.  this basically amounts to rewriting chalk without functionality which can't be shimmed in IE8 (Object.defineProperty() is the gotcha; explanation

Are you planing on reverting all of chalk via https://github.com/boneskull/mocha/commit/ba3378a336dad69b10970cd171d109f3160923ac ?

@danielstjules yes

@danielstjules well, it's this changeset now

Seems like we can work around that by forcing use of the defineProperty/defineProperties shim in IE8 though?

I'm just getting off lunch break now so I don't have time to test, but I can take a stab at an alternative tonight.

afaik there is no such shim that's functional.  anyway I was having a hell of a time getting a shim to work; would appreciate the help

I can help dig into this 6 hours from now, but not sure how much of a rush we're in.

It's not of huge importance.  I did it in the first place because I thought it was low-hanging fruit.  Boy, was I wrong...

If this gets fixed please consider using 'dim' in place of 'gray' which fixes output on the solarized theme.
Let me know if there's something I can do to help.

this is such a pain in the ass, I have the same issue in Webstorm, Unless I change the console colors to very light background, the passing text won't show because it's dark grey.  I'd love to have a dark background for my console in Webstorm but if I do that then I can barely see the passed text for tests since I can't change that damn color!

My coworker is having the same problem with my new test harness and I can't figure out how to get him a color scheme that doesn't suck on a black background.

anyway, this is more of a "next major" thing, but will definitely be addressed

I ended up changing the color mappings on my terminal to improve the contrast on the dark grey color.  But it's a weird color selection in any context so I'd appreciate it if we got it fixed.

I am still having this problem with solarized color scheme. I am annoyed.

@boneskull What if we refactored the reporters a bit so that console-output reporters inherit from something that uses Chalk but the HTML reporter (and any hypothetical programmatic or null reporter) doesn't inherit this and then we can exclude the Chalk-using reporters from the browser bundle (assuming that isn't going to break intended PhantomJS usage...)?

I can't for the life of me reproduce a terminal with a "solarized dark" color scheme wherein mocha won't be readable

can someone tell me how to reproduce this on a mac with either iTerm or Terminal?
we did fix the diff colors some time ago via a PR.

See #2164 for a proposed fix.  This fix LGTM except for my inability to assert it fixes any problems.

@boneskull You should be able to reproduce by downloading the official Solarized theme for iTerm. Open the file with Finder, then open iTerm. Load the colors by opening Preferences, selecting the Colors tab, opening the "Load presets" menu, and choose Solarized Dark.
Then run any test and you should see something like this:

I added this on the PR too but, it's starting to look like this is mostly a problem with the Solarized theme. It's using bright black as its background, which seems a little odd.
FWIW, I'd say the PR definitely fixes the original issue here, but maybe not the problem people are having with Solarized + Mocha. I tend to get around this problem anyway by npm linking my own copy of Mocha so I can choose my own colors. Would custom colors be worth exploring?

@r-tanner-f I did exactly that:

@r-tanner-f Maybe the "minimum contrast" is making it so I cannot reproduce.

Yep.  When I slide it to the left, nothing is shown.
You can see here that the problem is with the solarized theme itself:

While #2164 seems "more correct", and potentially a low-impact change, it won't help anybody running a "Solarized Dark" theme in iTerm.
Running the official "Solarized Dark" theme in Terminal.app seems to work fine without any modifications.
Let's recap:

OP complained about jacked-up color scheme
To the credit of the OP, at the time the "diff" colors were jacked-up
Someone sent a PR to fix the diff colors, and we merged that
Along the way, people were complaining that the "Solarized Dark" theme didn't work
tj was loathe to change the colors based on a a terminal theme some were using
Ostensibly to convince tj, users noted the reporters used non-standard ANSI colors
Others argued that you're unlikely to be using a terminal that doesn't support the non-standard colors
Later, I attempted to leverage the chalk module for colors so Mocha could absolve itself of choosing them (and finally end the debate), but that caused mass brokenness, and had to be reverted.
@jtangelder sent #2164, which removes the non-standard colors and uses "standard" ones
As some users suspected, the non-standard colors had no impact on some users of "Solarized Dark", who still have problems with visibility
In fact, certain users w/ certain terminal configurations can notice no difference whatsoever when the changes in #2164 are applied.

I can now say with certainty, if the colors Mocha uses aren't visible, your color theme is broken and/or your terminal is misconfigured.  If you are having problems wherein Mocha fails to display visible text, you will also have problems using other programs which leverage the same ANSI colors.
If we changed the colors so theme A will display, there's no guarantee users of popular color theme B won't suffer invisible text as a result, because color theme B may be broken as well in a different manner.  In either case, a terminal can be misconfigured.
I still may be interested in merging #2164, but I am going to close this ticket.  It's not really in Mocha's best interest to play whack-a-mole with invisible terminal colors.  While tj may have been ultimately correct--and I had suspected as much--neither one of us did a great job of communication about it.
If you are having this problem:  Reconfigure your terminal and/or scheme to ensure all valid ANSI colors are clearly displayed.
For iTerm users:  You can still use "Solarized Dark", but increase the "minimum contrast" setting.
For anyone else:  I don't know; if you have a workaround, please post it here.

All I know is for me, I spent a lot of time trying to get mocha test colors fixed so that I could actually view it well in Solarized theme and it was impossible.  I ended up having to make my console completely white in order to be able to run mocha tests and see them clearly.   Most people do not run their tests in console, they do, but they usually have console embedded in an IDE like webstorm or other.  I was able to try to tweak some things via the Webstorm IDE but still no luck, it's mocha...trust me.

Most people do not run their tests in console

Do you have data to support this?

I was able to try to tweak some things via the Webstorm IDE but still no luck

Mocha works fine for me in WebStorm terminal, using any color theme.
I understand you are frustrated, but I would prefer to leave this issue unlocked so people can post workarounds or proper terminal configurations.

So you're telling me most devs who use Sublime, Atom, Webstorm, etc. don't try using console embedded inside them and are always toggling back and fourth between their IDE or Editor and Console?  I doubt that.  Sure I can come up with proof, let me do a short video soon that illustrates the inability to tweak mocha's default terrible color scheme.

Besides my bitching :)  What I'll also do is come up with a video showing a work-around, not really the colors I'd prefer, and you have to change the terminal background to white but that's what I had to do to get around the problem.

So you're telling me most devs who use Sublime, Atom, Webstorm, etc. don't try using console embedded inside them and are always toggling back and fourth between their IDE or Editor and Console

I use Atom and WebStorm embedded terminals in addition to iTerm (all regularly), and have never had this problem.

inability to tweak mocha's default terrible color scheme.

You can't tweak its color scheme, but you can adjust your terminal. :smile:

I use Atom and WebStorm embedded terminals in addition to iTerm (all regularly), and have never had this problem.

It's a problem in the 'Darkula' theme, which almost everyone I observe using IntelliJ products seems to use now.

I see... I'll look at that thx @jdmarshall

@dschinkel

Before:

After:

@boneskull pretty sure I have tried that but I'll check it out again to be sure.

@jdmarshall thanks for the direction on that.

also note above "ANSI: black" is actually white.

Yep that's the work around I talked about.  That makes the background of your console white for the terminal inside Webstorm.

I tried Dracula again, like you did tehre, and I still get the same problem I had originally, before my workaround which was to change the background of the terminal to white so I could at least read the dark grey text, the problem you see here that I still get with Dracula if I revert back to trying to use Dracula:

Yep that's the work around I talked about. That makes the background of your console white for the terminal inside Webstorm.

There's is no need to make the background white, nor is that what my change in the screenshot did.
I'm trying to understand the problem you're seeing.  If that "exception" text is too dark, make it lighter by increasing the brightness on the "dark gray":

If you're still having trouble, you may wish to consult the WebStorm documentation and/or contact someone at JetBrains.

Oh believe me I have consulted with them.  Oh well...thanks for providing the info.  If I find out the solution I'll post it on my side.  Not sure why yours is working and mine is not but hopefully I'll pinpoint it.

@dschinkel Put this file in your colors folder, then restart WebStorm.
On a mac, this is ~/Library/Prefernces/WebStorm<version>/colors/.
But that's about the extent of what I can do to support JetBrains' products.  Again, this is not a Mocha-specific issue.

@boneskull yea I've tried that :).  Thanks though.

Just FYI, Webstorm just came out with a new version that apparently has fixed the problem at least it did for me http://bit.ly/29vZhiQ

Just wanted to throw out there that I'm still bumping into this issue on gnome-terminal and xfce4-terminal, and I know this has a lot of talk, but as a new user of mocha, it's quite annoying :( It would be great if there was just a way to change, maybe via CLI, what color code gets used for secondary text output.

@jeffvandyke Are you using Solarized Dark? Much as I love the theme, it's simply broken. It uses Bright Black as the background color. Simple as that.
Take a look at the values section: http://ethanschoonover.com/solarized#the-values
And the usage guide: http://ethanschoonover.com/solarized/img/solarized-values-dark.png
If the background color was Black that might be forgivable, but I would never expect Bright Black to be the same as the background color. I've had this issue with other console applications and Solarized Dark as well. This isn't limited to Mocha at all.

Gotcha, that does make sense. My workaround was to set Bright Black to one of the lighter gray colors in my terminal, but I see how solarized dark doesn't fit perfectly for 16-color terminals. Thanks!


Feat/support cucumber 4.5

Hi Alex,
First of all, thanks for your work on this.
I pull request now for you to review in advance but I will have to test on my job project next week.
But for now it seems ok.
I changed indent in pom and removed tabs if your are ok ?
I added an .editorconfig for convenience.
About the version, I let you decide.
I would have moved directly on a 1.0 for introducing breaking changes with version compatibility.
I often recommend a v1.0 since day one for gaining adoption on OS project.
It's up to you.
Thanks again,
Have a nice week end

Thanks a lot for your PR


No Log output in Addon. Stops after > node index.js

Description of problem:
I followed the instructions in the post by TheStigh on this  issue after restoring a backup. There is now no log output form the addon it just stops at > node index.js
Zigbee2mqtt add-on version (if edge, please report commit hash):
// ><EMAIL_ADDRESS>start /app

Your entire configuration from the frontend (with sensitive fields redacted):
data_path: /config/zigbee2mqtt
external_converters: []
devices: devices.yaml
groups: groups.yaml
homeassistant: true
permit_join: false
mqtt:
  base_topic: zigbee2mqtt
  server: 'mqtt://core-mosquitto:1883'
  user: xxxxxxxxxxxx
  password: xxxxxxxxxxx
  client_id: zigbee2mqtt
serial:
  port: /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0
advanced:
  log_level: warn
  pan_id: 6755
  channel: 11
  network_key:
    - 1
    - 3
    - 5
    - 7
    - 9
    - 11
    - 13
    - 15
    - 0
    - 2
    - 4
    - 6
    - 8
    - 10
    - 12
    - 13
  availability_blocklist: []
  availability_passlist: []
device_options: {}
blocklist: []
passlist: []
queue: {}
frontend:
  port: 8099
experimental: {}
socat:
  enabled: false
  master: 'pty,raw,echo=0,link=/tmp/ttyZ2M,mode=777'
  slave: 'tcp-listen:8485,keepalive,nodelay,reuseaddr,keepidle=1,keepintvl=1,keepcnt=5'
  options: '-d -d'
  log: false
zigbee_herdsman_debug: false

Running platform (details from Suypervisor > System)
Operating System: HassOS 5.12

Your logs from Home Assistant Supervisor
21-02-25 22:33:44 INFO (SyncWorker_0) [supervisor.docker.interface] Attaching to homeassistant/aarch64-hassio-audio with version 2021.02.1
21-02-25 22:33:44 INFO (MainThread) [supervisor.plugins.audio] Starting Audio plugin
21-02-25 22:33:45 INFO (SyncWorker_0) [supervisor.docker.audio] Starting Audio homeassistant/aarch64-hassio-audio with version 2021.02.1 - <IP_ADDRESS>
21-02-25 22:33:45 INFO (SyncWorker_0) [supervisor.docker.interface] Attaching to homeassistant/aarch64-hassio-cli with version 2021.02.1
21-02-25 22:33:45 INFO (MainThread) [supervisor.plugins.cli] Starting CLI plugin
21-02-25 22:33:46 INFO (SyncWorker_0) [supervisor.docker.cli] Starting CLI homeassistant/aarch64-hassio-cli with version 2021.02.1 - <IP_ADDRESS>
21-02-25 22:33:46 INFO (SyncWorker_0) [supervisor.docker.interface] Attaching to homeassistant/aarch64-hassio-observer with version 2020.10.1
21-02-25 22:33:46 INFO (SyncWorker_0) [supervisor.docker.interface] Attaching to homeassistant/aarch64-hassio-multicast with version 3
21-02-25 22:33:46 INFO (MainThread) [supervisor.plugins.multicast] Starting Multicast plugin
21-02-25 22:33:46 INFO (SyncWorker_0) [supervisor.docker.multicast] Starting Multicast homeassistant/aarch64-hassio-multicast with version 3 - Host
21-02-25 22:33:46 INFO (MainThread) [supervisor.updater] Fetching update data from https://version.home-assistant.io/stable.json
21-02-25 22:33:46 INFO (SyncWorker_0) [supervisor.docker.interface] Attaching to homeassistant/raspberrypi4-64-homeassistant with version 2021.2.3
21-02-25 22:33:46 INFO (MainThread) [supervisor.homeassistant.secrets] Loaded 1 Home Assistant secrets
21-02-25 22:33:47 INFO (MainThread) [supervisor.hassos] Detect HassOS 5.12 / BootSlot A
21-02-25 22:33:47 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Frigate NVR
21-02-25 22:33:47 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Frigate NVR Beta (outdated)
21-02-25 22:33:47 INFO (MainThread) [supervisor.store.git] Loading add-on /data/addons/git/a0d7b954 repository
21-02-25 22:33:47 INFO (MainThread) [supervisor.store.git] Loading add-on /data/addons/git/15d21743 repository
21-02-25 22:33:47 INFO (MainThread) [supervisor.store.git] Loading add-on /data/addons/core repository
21-02-25 22:33:47 INFO (MainThread) [supervisor.store.git] Loading add-on /data/addons/git/ccab4aaf repository
21-02-25 22:33:47 INFO (MainThread) [supervisor.store.git] Loading add-on /data/addons/git/773cbd65 repository
21-02-25 22:33:47 INFO (MainThread) [supervisor.store.git] Loading add-on /data/addons/git/7ad98f9c repository
21-02-25 22:33:47 INFO (MainThread) [supervisor.store.git] Loading add-on /data/addons/git/a889bffc repository
21-02-25 22:33:47 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Frigate NVR
21-02-25 22:33:47 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Frigate NVR Beta (outdated)
21-02-25 22:33:47 INFO (MainThread) [supervisor.store] Loading add-ons from store: 74 all - 74 new - 0 remove
21-02-25 22:33:47 INFO (MainThread) [supervisor.addons] Found 4 installed add-ons
21-02-25 22:33:48 INFO (SyncWorker_4) [supervisor.docker.interface] Attaching to ghcr.io/hassio-addons/tasmoadmin/aarch64 with version 0.14.0
21-02-25 22:33:48 INFO (SyncWorker_7) [supervisor.docker.interface] Attaching to homeassistant/aarch64-addon-mosquitto with version 5.1.1
21-02-25 22:33:48 INFO (SyncWorker_5) [supervisor.docker.interface] Attaching to esphome/esphome-hassio-aarch64 with version 1.16.2
21-02-25 22:33:48 INFO (SyncWorker_2) [supervisor.docker.interface] Attaching to homeassistant/aarch64-addon-samba with version 9.3.1
21-02-25 22:33:48 INFO (MainThread) [supervisor.snapshots] Found 1 snapshot files
21-02-25 22:33:48 INFO (MainThread) [supervisor.discovery] Loaded 1 messages
21-02-25 22:33:48 INFO (MainThread) [supervisor.ingress] Loaded 1 ingress sessions
21-02-25 22:33:48 INFO (MainThread) [supervisor.resolution.check] Starting system checks with state CoreState.SETUP
21-02-25 22:33:48 INFO (MainThread) [supervisor.resolution.check] System checks complete
21-02-25 22:33:48 INFO (MainThread) [supervisor.resolution.evaluate] Starting system evaluation with state CoreState.SETUP
21-02-25 22:33:48 INFO (MainThread) [supervisor.resolution.evaluate] System evaluation complete
21-02-25 22:33:48 INFO (MainThread) [__main__] Running Supervisor
21-02-25 22:33:48 INFO (MainThread) [supervisor.hassos] Rauc: A - marked slot kernel.0 as good
21-02-25 22:33:48 INFO (MainThread) [supervisor.addons] Phase 'AddonStartup.INITIALIZE' starting 0 add-ons
21-02-25 22:33:48 INFO (MainThread) [supervisor.addons] Phase 'AddonStartup.SYSTEM' starting 2 add-ons
21-02-25 22:33:49 INFO (SyncWorker_2) [supervisor.docker.addon] Starting Docker add-on homeassistant/aarch64-addon-mosquitto with version 5.1.1
21-02-25 22:33:49 INFO (SyncWorker_3) [supervisor.docker.interface] Cleaning addon_a0d7b954_sonweb application
21-02-25 22:33:50 INFO (SyncWorker_3) [supervisor.docker.addon] Starting Docker add-on ghcr.io/hassio-addons/tasmoadmin/aarch64 with version 0.14.0
21-02-25 22:33:52 INFO (MainThread) [supervisor.services.modules.mqtt] Set core_mosquitto as service provider for mqtt
21-02-25 22:33:55 INFO (MainThread) [supervisor.addons] Phase 'AddonStartup.SERVICES' starting 1 add-ons
21-02-25 22:33:55 INFO (SyncWorker_0) [supervisor.docker.addon] Starting Docker add-on homeassistant/aarch64-addon-samba with version 9.3.1
21-02-25 22:33:55 INFO (MainThread) [supervisor.auth] Auth request from 'core_mosquitto' for 'Stephen'
21-02-25 22:33:55 INFO (MainThread) [supervisor.auth] Home Assistant not running, checking cache
21-02-26 08:36:41 INFO (MainThread) [supervisor.core] Start Home Assistant Core
21-02-26 08:36:41 INFO (SyncWorker_1) [supervisor.docker.interface] Starting homeassistant
21-02-26 08:36:41 INFO (MainThread) [supervisor.homeassistant.core] Wait until Home Assistant is ready
21-02-26 08:36:42 INFO (MainThread) [supervisor.auth] Auth request from 'core_mosquitto' for 'Stephen'
21-02-26 08:36:42 INFO (MainThread) [supervisor.auth] Home Assistant not running, checking cache
21-02-26 08:36:57 INFO (MainThread) [supervisor.homeassistant.api] Updated Home Assistant API token
21-02-26 08:37:02 INFO (MainThread) [supervisor.homeassistant.core] Detect a running Home Assistant instance
21-02-26 08:37:02 INFO (MainThread) [supervisor.addons] Phase 'AddonStartup.APPLICATION' starting 0 add-ons
21-02-26 08:37:02 INFO (MainThread) [supervisor.misc.tasks] All core tasks are scheduled
21-02-26 08:37:02 INFO (MainThread) [supervisor.core] Supervisor is up and running
21-02-26 08:37:02 INFO (MainThread) [supervisor.host.info] Updating local host information
21-02-26 08:37:03 INFO (MainThread) [supervisor.updater] Fetching update data from https://version.home-assistant.io/stable.json
21-02-26 08:37:03 INFO (MainThread) [supervisor.resolution.fixup] Starting system autofix at state CoreState.RUNNING
21-02-26 08:37:03 INFO (MainThread) [supervisor.resolution.fixup] System autofix complete
21-02-26 08:37:03 INFO (MainThread) [supervisor.host.services] Updating service information
21-02-26 08:37:03 INFO (MainThread) [supervisor.host.network] Updating local network information
21-02-26 08:37:05 INFO (MainThread) [supervisor.host.sound] Updating PulseAudio information
21-02-26 08:37:05 INFO (MainThread) [supervisor.host] Host information reload completed
21-02-26 08:38:05 INFO (MainThread) [supervisor.snapshots] Found 1 snapshot files
21-02-26 08:38:34 INFO (MainThread) [supervisor.snapshots] Found 1 snapshot files
21-02-26 08:38:42 INFO (MainThread) [supervisor.snapshots] Found 1 snapshot files
21-02-26 08:39:00 INFO (MainThread) [supervisor.addons] Creating Home Assistant add-on data folder /data/addons/data/7ad98f9c_zigbee2mqtt
21-02-26 08:39:00 INFO (SyncWorker_6) [supervisor.docker.interface] Downloading docker image zigbee2mqtt/zigbee2mqtt-aarch64 with tag 1.17.1-4.
21-02-26 08:39:36 INFO (MainThread) [supervisor.addons] Add-on '7ad98f9c_zigbee2mqtt' successfully installed
21-02-26 08:41:31 INFO (SyncWorker_7) [supervisor.docker.addon] Starting Docker add-on zigbee2mqtt/zigbee2mqtt-aarch64 with version 1.17.1-4
21-02-26 08:41:47 INFO (SyncWorker_1) [supervisor.docker.interface] Stopping addon_7ad98f9c_zigbee2mqtt application
21-02-26 08:41:48 INFO (SyncWorker_1) [supervisor.docker.interface] Cleaning addon_7ad98f9c_zigbee2mqtt application
21-02-26 08:41:58 INFO (MainThread) [supervisor.hardware.monitor] Detecting HardwareAction.ADD usb hardware /dev/bus/usb/001/003
21-02-26 08:41:58 INFO (MainThread) [supervisor.hardware.monitor] Detecting HardwareAction.ADD serial hardware /dev/ttyUSB0 - /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0
21-02-26 08:42:02 INFO (SyncWorker_7) [supervisor.docker.addon] Starting Docker add-on zigbee2mqtt/zigbee2mqtt-aarch64 with version 1.17.1-4
21-02-26 08:48:10 INFO (SyncWorker_0) [supervisor.docker.interface] Stopping addon_7ad98f9c_zigbee2mqtt application
21-02-26 08:48:11 INFO (SyncWorker_0) [supervisor.docker.interface] Cleaning addon_7ad98f9c_zigbee2mqtt application
21-02-26 08:50:13 INFO (MainThread) [supervisor.snapshots] Found 1 snapshot files
21-02-26 08:50:23 INFO (SyncWorker_1) [supervisor.docker.interface] Restarting homeassistant/raspberrypi4-64-homeassistant
21-02-26 08:50:31 INFO (MainThread) [supervisor.homeassistant.core] Wait until Home Assistant is ready
21-02-26 08:50:57 INFO (MainThread) [supervisor.homeassistant.core] Detect a running Home Assistant instance
21-02-26 08:53:58 INFO (SyncWorker_0) [supervisor.docker.addon] Starting Docker add-on zigbee2mqtt/zigbee2mqtt-aarch64 with version 1.17.1-4
21-02-26 08:55:32 INFO (SyncWorker_4) [supervisor.docker.interface] Stopping addon_7ad98f9c_zigbee2mqtt application
21-02-26 08:55:34 INFO (SyncWorker_4) [supervisor.docker.interface] Cleaning addon_7ad98f9c_zigbee2mqtt application
21-02-26 08:55:43 INFO (SyncWorker_5) [supervisor.docker.addon] Starting Docker add-on zigbee2mqtt/zigbee2mqtt-aarch64 with version 1.17.1-4
21-02-26 08:58:13 INFO (SyncWorker_4) [supervisor.docker.interface] Stopping addon_7ad98f9c_zigbee2mqtt application
21-02-26 08:58:14 INFO (SyncWorker_4) [supervisor.docker.interface] Cleaning addon_7ad98f9c_zigbee2mqtt application
21-02-26 08:59:36 INFO (SyncWorker_0) [supervisor.docker.addon] Starting Docker add-on zigbee2mqtt/zigbee2mqtt-aarch64 with version 1.17.1-4
21-02-26 08:59:46 INFO (MainThread) [supervisor.auth] Auth request from 'core_mosquitto' for 'Stephen'
21-02-26 08:59:47 INFO (MainThread) [supervisor.auth] Successful login for 'Stephen'

Addon Logs
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] socat.sh: executing...
[08:59:37] INFO: Socat not enabled, marking service as down
[cont-init.d] socat.sh: exited 0.
[cont-init.d] zigbee2mqtt.sh: executing...
[08:59:38] INFO: MQTT available, fetching server detail ...
[08:59:38] INFO: Previous config file found, checking backup
[08:59:38] INFO: Creating backup config in '/config/zigbee2mqtt/.configuration.yaml.bk'
[08:59:38] INFO: Adjusting Zigbee2mqtt core yaml config with add-on quirks ...
[cont-init.d] zigbee2mqtt.sh: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
[08:59:39] INFO: Handing over control to Zigbee2mqtt Core ...
><EMAIL_ADDRESS>start /app
> node index.js

stuid me used the new config file and never changed log output to info.

It seemed like a silly problem, but "stupid you" helped me with the same "issue". So thanks a lot!


Support CopyFromPod and CopyToPod API for JobExecutor

Codecov Report

Merging #23 (451cac8) into master (6580a43) will decrease coverage by 5.69%.
The diff coverage is 52.12%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   72.71%   67.02%   -5.70%
==========================================
  Files           1        2       +1
  Lines         678      937     +259
==========================================
+ Hits          493      628     +135
- Misses        139      228      +89
- Partials       46       81      +35


add startup sound

This failed because of standard, though this pr doesn't include any changes to javascript

rebased & added :+1:


Fix #558

Pull Request Test Coverage Report for Build 1673

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.009%) to 24.349%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sagas/index.ts
0
3
0.0%

Totals

Change from base Build 1668:
-0.009%

Covered Lines:
1208

Relevant Lines:
4135

💛  - Coveralls

Fix #586  as well


Support Lighttpd v1.4.64 or later

lighttpd v1.4.64 was released on Jan 19, 2022. It is time to migrate the new codebase for evaluation purpose.

Lighttpd v1.4.65 was released in Jun 7.


Uniform type is non-convertable with Nim-2.2.0

When building with the Nim-2.2.0 release the Uniform[T] types are not being implicitly converted to T.
examples/triangle.nim(17, 21) Error: type mismatch
Expression: MVP * vec4(vPos.arr[0], vPos.arr[1], 0.0, 1.0)
  [1] MVP: Uniform[vmath.Mat4]
  [2] vec4(vPos.arr[0], vPos.arr[1], 0.0, 1.0): Vec4

Expected one of (first mismatch at [position]):
[1] proc `*`[T](a: GMat4[T]; b: GVec4[T]): GVec4[T]

https://github.com/NixOS/nixpkgs/issues/350913

I need to look into this. I think I ran into this as well will probably have a fix soon.

https://github.com/nim-lang/Nim/issues/24415


StyleTransfer Demo

Introduce new styletransfer demo to rest of samples list. Updates include a change to the design pattern (MVC -> MVVM) and a new way of applying style transfer to webstreaming (FrameRenderer -> VideoEffect), as well as optimizations to the processing step, to increase framerate to real-time while webstreaming.

<!--
</blockquote>
File looks unchanged?

Refers to: Samples/FNSCandyStyleTransfer/UWP/cs/MainPage.xaml:1 in c880d30. [](commit_id = c880d301717e09d0b881ad0fed5526a841b5ce99, deletion_comment = False)

//@@@+++@@@@*****************************************************************

File looks unchanged?

Refers to: Samples/FNSCandyStyleTransfer/UWP/cs/MainPage.xaml.cs:1 in c880d30. [](commit_id = c880d301717e09d0b881ad0fed5526a841b5ce99, deletion_comment = False)

can be removed right?

Refers to: Samples/StyleTransfer/VideoEffect/StyleTransferEffectComponent/StyleTransferEffectNotifier.idl:10 in e2d963d. [](commit_id = e2d963d2c3d35eced6df283eb013025030170f0b, deletion_comment = False)


chore: promote jkx-golang2 to version 0.0.2

chore: promote jkx-golang2 to version 0.0.2
this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Irregular connection issues using Touch V3.10d

Are there known issues querying the JSON API, especially using the Touch panel of a Oekofen Pellematic Compact running V3.10d ?
I'm querying the JSON API regularly, and over 24h there are multiple time intervals where there is no data returned. E.g. manually running "curl" on all data regularly returns incomplete (broken) data, while querying all sections separately returns most (but not all) data.
Examples:
curl http://IP:PORT/PASSWD/all
curl: (18) transfer closed with 4338 bytes remaining to read

curl http://IP:PORT/PASSWD/pe1
{
   "pe1":{
      "L_temp_act":"680",
      "L_temp_set":"80",
      "L_ext_temp":"-32768",
      "L_frt_temp_act":"1269",
      "L_frt_temp_set":"80",
      "L_br":"false",
      "L_ak":"false",
      "L_not":"true",
      "L_stb":"true",
      "L_modulation":"0",
      "L_uw_speed":"0",
      "L_state":"99",
      "L_statetext":"Aus",
      "L_type":"9",
      "L_starts":"362",
      "L_runtime":"372",
      "L_avg_runtime":"61",
      "L_uw_release":"638",
      "L_uw":"0",
      "L_storage_fill":"3603",
      "L_storage_min":"400",
      "L_storage_max":"4300",
      "L_storage_popper":"29",
      "storage_fill_today":"15",
      "storage_fill_yesterday":"16",
      "mode":"1"
   }
}

curl http://IP:PORT/PASSWD/ww1
curl: (18) transfer closed with 506 bytes remaining to read

A few hours later, querying all data work again. From my logs, it affects mostly the "ww1", "hk1", "pe1", or a combination of them.
The heater is connected via cable (all cables and router already swapped and tested, with no success). Known bug?

Have a look at https://github.com/stawen/okovision - the code is not particularly clean, but it works well...!

Thanks for the hint, I was not even aware of that project.
I'm already using the solution described here:
https://nc-x.com/oekofen-spy
https://www.haustechnikdialog.de/Forum/t/242695/Monitoring-einer-Oekofen-Pelletronic-Touch-Heizungssteuerung
(documentation only in German, unfortunately)
The nice thing is that it simply queries the JSON data in a lightweight python script, puts all data into an Influx database, and the monitoring then runs in Grafana and can be flexibly adjusted.
For some reason, however, the JSON interface regularly has dropouts on my boiler or touch control. I don't think it's related to the python / influx / grafana framework, because it also happens when manually querying the JSON interface in a browser or via curl.

Thanks for that tip, didn’t know oekofen-spy yet.
but aren’t you hitting the rate limit? Had drop-outs too when I called more than once a time a 10 seconds if I’m correct.
Did you have oekofen-spy running at the time you did the manual request?

No, it does not look like I'm hitting the rate limit (should be 2.5s). oekofen-spy is running every 2 minutes, and the behavior is identical if I'm using manual requests (or even just query via a browser once every hour).
Hitting a rate limit returns an error 401 with error message(curl - v):
curl -v http://IP:PORT/PASSWD/pu1
*   Trying IP:PORT...
* TCP_NODELAY set
* Connected to IP (IP) port PORT(#0)
> GET /PASSWD/pu1 HTTP/1.1
> Host: IP:PORT
> User-Agent: curl/7.68.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 401 Unauthorized
< Date: Sat, 20 Nov 2021 11:24:01 GMT
< Content-length: 37
<
* Connection #0 to host <IP_ADDRESS> left intact
Wait at least 2500ms during requests

Whereas the erroneous return looks like this:
curl -v http://IP:PORT/PASSWD/all
*   Trying IP:PORT...
* TCP_NODELAY set
* Connected to IP (IP) port PORT(#0)
> GET /PASSWD/all HTTP/1.1
> Host: IP:PORT
> User-Agent: curl/7.68.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Date: Sat, 20 Nov 2021 11:26:23 GMT
< Content-length: 4357
<
* transfer closed with 4357 bytes remaining to read
* Closing connection 0
curl: (18) transfer closed with 4357 bytes remaining to read

Interestingly, if I quickly query the same "broken" URL again, it returns the 401 rate limit error - but never the complete data until it's back in a "working" state again after a few hours.

With the graphic analysis and partially recorded data, I was able to find some correlations:

"hk1" data is not available via JSON when radiator heating is off during night, but available during daytime and night when the outside temperatures are low enough (reduced heating temperature).
"ww" data is not available outside the configure warm water heating times (probably the set temperature is also at some low value).
Querying "all" via JSON only works when the sub-part data are all available and work, e.g. during daytime and warm water heating times.
Since the data is present in the CSV files and the Oekofen app, it looks like a bug in the JSON part of the V3.10d control panel software.

i may confirm same behaviour in Touch V3.00b 04112019 Version.

It seems that the issue is caused by German umlauts (äöü) in the JSON response. In my case http://IP:PORT/PASSWD/all and http://IP:PORT/PASSWD/hk1 did not work at all until I changed hk1.name from 'Heizkörper' to 'Heizkoerper'.
The phenomenon that hk1 data is not available on nights with higher outside temperature is probaby caused by the 'ü' in hk1.L_statetext='Außentemp über Heizgrenze absenken'. Also pe1.L_statetext='Zündung' breaks the JSON interface.
And there are probably more state texts with umlauts.
A simple workaround is to change the display language to English.

Great finding, thanks! Indeed, I had a gut feeling about the name fields and already cleared all of them, but haven't thought about the varying "statetext" fields.
It's all working exactly as you described: adding an Umlaut to a name field breaks the corresponding JSON block, removing them and changing the language of the heating control to English makes everything work as expected.
Slightly related, oekofen-spy is now available here: https://gitlab.com/p3605/oekofen-spy


retry helm test if failed without having to remediate

Currently, it is not possible to retry the helm test. Would be nice to be able to retry the helm test if the previous one fails.
When a helm chart has a webhook(validation/mutation) and the webhook relies on cert-manager(jetstack) for CA injection, the cert-manager can fail to inject the certificate but eventually, it retries and succeeds.  At the point helm install/upgrade would have succeeded, but any helm test relying on webhook would be failed due to invalid CA on webhook config. A rollback would be aggressive for this kind of failure. It would be nice to have the ability to retry the helm test if failed.

I think even remediation strategy none like proposed here  for the upgrade would be fine. As that would just retry to run the helm test

If the chart implements the test hook using a Job and supports setting the backoffLimit on that job (or just keeps the default of 6) then retries can be achieved that way. So the main use case would be with charts which use test Pods instead (and which you have no control to change this). I am not sure how many charts are using test Jobs (new in Helm 3 I believe) vs Pods at this point. One problem would be if folks were unaware that their chart already supports retries via backoffLimit (defaults to 6) and thus blindly added say 3 test retries at the HelmRelease level, that could lead to 6 * 3 = 18 retries which is likely more than they bargained for. Maybe good documentation can prevent too much of that though.

I am of opinion that this should be solved from within the chart (tests), for the same reason as that restarting your CI tests until they turn green is not considered a good practice, they are simply flaky and not taking the right things into consideration.
In addition, because when you run a Helm test action you are not capable of targeting a specific release revision, multiple test runs during a reconciliation would increase the chance of making observations on a release that has not been performed by the controller, and our current architecture does not have sufficient utilities (yet) to protect against this (although a model to possibly solve this has been unveiled in https://github.com/fluxcd/helm-controller/pull/166, which contains a Helm storage observer that can be used to ensure revisions do not magically change between action runs — and I am still planning on using some of what's in that PR).


[BUG] Issue running / building angular application inside docker with Angular v13

Hi Team,
Thanks for such an awesome plugin
I have been using formio plugin with different projects in angular and it's working fine. Previously i was using v5.2.0 with angular v12 it was running fine with docker and not giving any kind of issue.
But with the version upgrade to Angular v13 and v5.3.0 the plugin started giving me the following error
Error: export 'FormUtils' (imported as 'FormUtils') was not found in '@formio/angular'
The strange thing is that if i'm running the same application through my system settings without docker, it's running fine without any issue. I'm stuck at this point, i appreciate if you can help me to resolve the issue
I'm sharing one screenshot:

Thanks in advance,
Deep

Hi @deep913 ! Probably the issue with docker image build. Could  you provide us an information how are you building docker image?

@HannaKurban thanks for your reply, meanwhile i replaced the import from @formio/angular to formiojs and it's working fine with docker, the problem is in the @formio/angular import

@deep913 please close the issue if it's resolved! :)


ZF3 support

Is this repo supports zf3 ?

check my pr https://github.com/ZF-Commons/ZfcTwig/pull/119
i have also a fork with zf2/zf3 support https://packagist.org/packages/kokspflanze/zfc-twig

:+1:

I didn't get, somebody would can help me?

@bhcosta90 you have to replace smth in your composer.json, until this module is not zf3 rdy, if you want.
in composer.json
"zf-commons/zfc-twig": "dev-master"

with
"kokspflanze/zfc-twig": "~1.3"

for your information, i forked zf-commons/zfc-twig and added zf3 support, also i open a PR https://github.com/ZF-Commons/ZfcTwig/pull/119
if you found a bug i can also fix it in my fork, just pm me in gitter or open a PR =)

I got it, thanks

@bhcosta90 i wrote also some lines @ https://github.com/kokspflanze/ZfcTwig/blob/master/README.md
and changed the links, so i hope it is now better=)

Yes, I used your repository to work with twig

I have also created a fork from this repo which supports Zend Framework 3.1.x, have a look at: https://github.com/divix1988/ZfcTwig

any update?

Hello,
I can propose this variant. I did it without any forks from scratch, but with ideas from ZF-Common. https://github.com/OxCom/zf3-twig
I'm to lazy to wait for implementation here ...


[documentation] Upgrade deployment

Background
Ensure the upgrade process is clearly documented for the planned upgrade.
Linked Issues & Documentation

Notion task list
Notion spec

Definition Of Done
Documentation is completed and referenced in the scope document.
Tasks

[x] Link resources in scope (including vendor documentation links)
[x] Step-by-step deployment process documented

see https://www.notion.so/connext/Messaging-Layer-Audit-Scope-826b9ac2d43d47bf9f46bb4145aa6527?pvs=4#e2f1ec99bd0e43808c1265dc2949b841


Bug: Cannot sell gold dust at curiosity shop

Hello!
Currently the curiosity shop will not accept selling gold dust. In the vanilla game, you can sell gold dust for 200 rupees.

This isn't a bug this is intended behavior. You can only turn in Gold Dust to the smithy, it's like Ruto's Letter. This is because you can find Gold Dust in OOT and it comes back into your inventory every cycle until you turn it into the smithy.

Yeah it's the current solution to prevent losing gold dust permanently. It's not incredible but it's intended behavior and not a bug.

Yeah, that makes sense, thanks! Although it is frustrating when it's the only bottle available before having access to the smithy. Hopefully there's a different solution available in the future. :)


Tmp108: Negative temperature values are not converted correctly

In tmp108.c, I get real strange temperatures when the sensor value is negative.
To Reproduce
Steps to reproduce the behavior:

build and install the sample sensor/tmp108
get the temperature below zero
read out the temperature

Expected behavior
A negative temperature value should be printed.
Impact
I can't use the driver at all and have to implement my own custom driver until this is resolved.
Logs and console output
I added additional print statements to tmp108.c line 155:
LOG_INF("Reading temperature: %hx", drv_data->sample);

uval = ((int32_t)(drv_data->sample) * TMP108_TEMP_MULTIPLIER(dev)) >> 4U;

LOG_INF("uval: %d", uval);

val->val1 = uval / 1000000U;
val->val2 = uval % 1000000U;

LOG_INF("val: %d.%06d", val->val1, val->val2);

return 0;

the log output:
[00:00:13.350,738] <inf> TMP108: Reading temperature: f780
[00:00:13.350,769] <inf> TMP108: uval: 226564544
[00:00:13.350,799] <inf> TMP108: val: 226.564544

Note that I am using the as62xx here, so TMP108_TEMP_MULTIPLIER should be equal to 125000.
I would have expected the uval to be equal to 495000000 here (0xf780 = 63360, * 125000 / 16 = 495000000), but something goes wrong.
Possibly during the cast to int32_t and the subsequent multiplication by an uint32_t and the shift.
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK on nrf52480 (using arm gnu toolchain 12.2)
Commit SHA:

git describe
zephyr-v3.5.0-4042-g7f99677aa6

this file hasn't changed on the current main branch since.

I dug into it a bit and the reason it fails is the multiplication with 125000 overflows in 32 bit with large (unsigned) values of the sample. Changing the sample type to int16_t inside struct tmp108_data seems to fix it partly, but an integer overflow can still occur if the sample value is large. A different calculation should be done here.
Another weird bit is the fact that it is multiplied by 125000 and then shifted right by four. Instead, dividing by sixteen and mentioning in the comment what the precision is (1/128 in case of the AS62xx, and 1/256 in the case of the tmp108) would clarify the code. Divisions by 16 should be optimized to a right shift by the compiler already, no need to obfuscate the code.
@MaureenHelm I saw you are assigned to this, but I need this on short term, so I can make a PR for it if it suits you

I made a fix for it.


Navigation bar color not set when using 3-button navigation

Issue

close #1048

Overview (Required)

Navigation bar color is now set except for devices that can switch between 3-button navigation and gesture navigation.
The color of the navigation icon cannot be changed on devices with API 25 or lower, so the color of the navigation container has been changed so that it is not transparent.

Links
accompanist - systemuicontroller
Android developers - EdgeToEdge.enableEdgeToEdge
Android developers - isNavigationBarContrastEnforced
Android developers Japan Blog - 古い端末でも Edge-to-edge にしたい

It was helpful in writing window.isNavigationBarContrastEnforced = false.

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before
After
Description

Emulator Pixel API28 (Only 3-button navigation can be configured)

Emulator Pixel6 API 23 (Only 3-button navigation can be configured)

Emulator Pixel6 Pro API 30 3-button Navigation

Emulator Pixel6 Pro API 30 Gesture Navigation

Looks great! Thank you for your comprehensive investigation!


Simplify while stack not empty with while let

This looks like it's based off of the compression PR which I don't want to merge until the corresponding PR in the JS performance branch is merged. It all looks good otherwise so happy to merge once that's done.

Ah, I don't think it relies on that branch, rebased it to just be off main. My fault.


HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…

… redirecting jul to slf4j (#3093)
Signed-off-by: Michael Stack<EMAIL_ADDRESS>

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 47s
branch-2 passed

+1 :green_heart:
compile
3m  6s
branch-2 passed

+1 :green_heart:
shadedjars
7m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 44s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 26s
the patch passed

+1 :green_heart:
compile
3m  2s
the patch passed

+1 :green_heart:
javac
3m  2s
the patch passed

+1 :green_heart:
shadedjars
7m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
243m 13s
root in the patch failed.

285m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5c73d87feb29 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 1d3ea38f1e

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/testReport/

Max. process+thread count
4202 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
branch-2 passed

+1 :green_heart:
compile
8m 48s
branch-2 passed

+1 :green_heart:
checkstyle
2m  2s
branch-2 passed

+1 :green_heart:
spotbugs
10m  9s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 16s
the patch passed

+1 :green_heart:
compile
8m 44s
the patch passed

+1 :green_heart:
javac
8m 44s
the patch passed

+1 :green_heart:
checkstyle
2m  5s
the patch passed

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 49s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
11m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m  6s
The patch does not generate ASF License warnings.

73m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux 999f1987df84 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b051ad5594

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 41s
branch-2 passed

+1 :green_heart:
compile
2m 13s
branch-2 passed

+1 :green_heart:
shadedjars
6m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 19s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 21s
the patch passed

+1 :green_heart:
compile
2m 14s
the patch passed

+1 :green_heart:
javac
2m 14s
the patch passed

+1 :green_heart:
shadedjars
5m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 15s
the patch passed

_ Other Tests _

-1 :x:
unit
238m 43s
root in the patch failed.

273m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 15f10c31738e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b051ad5594

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/testReport/

Max. process+thread count
3726 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 12s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 30s
branch-2 passed

+1 :green_heart:
compile
3m 22s
branch-2 passed

+1 :green_heart:
shadedjars
7m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 13s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 29s
the patch passed

+1 :green_heart:
compile
3m  6s
the patch passed

+1 :green_heart:
javac
3m  6s
the patch passed

+1 :green_heart:
shadedjars
7m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m  8s
the patch passed

_ Other Tests _

-1 :x:
unit
246m  0s
root in the patch failed.

291m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a6f6767ad584 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b051ad5594

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/testReport/

Max. process+thread count
4411 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 53s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 32s
branch-2 passed

+1 :green_heart:
compile
2m 45s
branch-2 passed

+1 :green_heart:
shadedjars
7m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 54s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 13s
the patch passed

+1 :green_heart:
compile
2m 56s
the patch passed

+1 :green_heart:
javac
2m 56s
the patch passed

+1 :green_heart:
shadedjars
7m 26s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 47s
the patch passed

_ Other Tests _

-1 :x:
unit
29m 34s
root in the patch failed.

71m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ce560b448685 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b051ad5594

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/3/testReport/

Max. process+thread count
648 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 29s
branch-2 passed

+1 :green_heart:
compile
8m 44s
branch-2 passed

+1 :green_heart:
checkstyle
2m  1s
branch-2 passed

+1 :green_heart:
spotbugs
10m 13s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
8m 52s
the patch passed

+1 :green_heart:
javac
8m 52s
the patch passed

+1 :green_heart:
checkstyle
2m  0s
the patch passed

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 56s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
11m 10s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m  7s
The patch does not generate ASF License warnings.

73m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux 29979bbabee1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b051ad5594

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/4/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 29s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 31s
branch-2 passed

+1 :green_heart:
compile
3m 22s
branch-2 passed

+1 :green_heart:
shadedjars
7m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 43s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 40s
the patch passed

+1 :green_heart:
compile
3m 20s
the patch passed

+1 :green_heart:
javac
3m 20s
the patch passed

+1 :green_heart:
shadedjars
8m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 32s
the patch passed

_ Other Tests _

-1 :x:
unit
279m 24s
root in the patch failed.

325m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bc606eb7d1e5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b051ad5594

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/4/testReport/

Max. process+thread count
4410 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 24s
branch-2 passed

+1 :green_heart:
compile
2m 17s
branch-2 passed

+1 :green_heart:
shadedjars
6m 28s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 28s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
compile
2m 17s
the patch passed

+1 :green_heart:
javac
2m 17s
the patch passed

+1 :green_heart:
shadedjars
6m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
306m 32s
root in the patch failed.

341m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 98cec8be8386 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b051ad5594

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/4/testReport/

Max. process+thread count
4446 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 18s
branch-2 passed

+1 :green_heart:
compile
8m 47s
branch-2 passed

+1 :green_heart:
checkstyle
2m  1s
branch-2 passed

+1 :green_heart:
spotbugs
10m  8s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s
the patch passed

+1 :green_heart:
compile
8m 44s
the patch passed

+1 :green_heart:
javac
8m 44s
the patch passed

+1 :green_heart:
checkstyle
2m  2s
the patch passed

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  7s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 46s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
11m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 17s
The patch does not generate ASF License warnings.

72m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux f5d80f1f0268 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b051ad5594

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/5/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 36s
branch-2 passed

+1 :green_heart:
compile
3m  3s
branch-2 passed

+1 :green_heart:
shadedjars
7m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 19s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 27s
the patch passed

+1 :green_heart:
compile
3m  8s
the patch passed

+1 :green_heart:
javac
3m  8s
the patch passed

+1 :green_heart:
shadedjars
7m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
244m 47s
root in the patch passed.

288m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d1278b622f93 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b051ad5594

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/5/testReport/

Max. process+thread count
4273 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
branch-2 passed

+1 :green_heart:
compile
2m 24s
branch-2 passed

+1 :green_heart:
shadedjars
6m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 29s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 40s
the patch passed

+1 :green_heart:
compile
2m 27s
the patch passed

+1 :green_heart:
javac
2m 27s
the patch passed

+1 :green_heart:
shadedjars
6m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
385m  8s
root in the patch passed.

422m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3112

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dfe07ea13bbe 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b051ad5594

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/5/testReport/

Max. process+thread count
3971 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Bump JMH to the latest version(1.15)

It'd be nice to upgrade JMH to the latest version. :)

Thanks @monkey-mas


deps: update

What does this change?
Update dependencies.
Why?
Make @dependabot happy:

#77
#76
#75
#73

It looks like we have clashing definitions between Prettier and ESLint when it comes to semicolons in type declarations.
Prettier wants them gone, ESLint needs them all…

It looks like we have clashing definitions between Prettier and ESLint when it comes to semicolons in type declarations.

ooooh intersting, i'll look at the config

Config fixed in https://github.com/guardian/configs/pull/5

Here are the supported PR titles, as per the error logs:
> Error: Unknown release type "deps" found in pull request title "deps: update".

Available types:
 - feat: A new feature
 - fix: A bug fix
 - improvement: An improvement to a current feature
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit


Add method for bulk deletion

Essentially copy/paste. See http://www.elastic.co/guide/en/elasticsearch/reference/1.3/docs-bulk.html for the documentation.

Matt says it looks good but can't merge on mobile.


Reload plugin does not work with Docker and custom Corefile

This really isn't an issue with coredns_omada per se, but I'm putting this out there in case someone else struggles to get the reload plugin to work.  Maybe the documentation can be updated?
The issue, related to Docker, is described in detail here https://dev.to/robbmanes/running-coredns-as-a-dns-server-in-a-container-1d0
Basically, placing Corefile in a directory and mounting the directory as a volume and passing the config on the command line solves it.
ie. copy Corefile to /home/mikepell/root then mount that folder to /root in the container

docker run --name coredns --restart=always --volume=/home/mikepell/root/:/root --env OMADA_DISABLE_HTTPS_VERIFICATION="true" -p 53:53/udp ghcr.io/dougbw/coredns_omada -conf /root/Corefile

Hi, this is the expected behaviour when using a docker container - a container intentionally has its own isolated file system unless you specifically mount a directory or file as a volume. The existing documentation does already includes a section on using a custom Corefile in a docker container: https://github.com/dougbw/coredns_omada/blob/main/docs/getting-started.md#docker


Remove unused code

Hi, using unused by @joshuaclayton, I found and removed a small chunk of unused code.

Thanks @sondnm!


Check if pallet-contracts tutorial is still working

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Content request
The user on https://substrate.stackexchange.com/questions/3668/errore0405-cannot-find-trait-trait-in-crate-pallet-contracts writes:

I am performing the (add the contracts pallet to a runtime) substrate tutorial and I am getting this error
error[E0405]: cannot find trait Trait in crate pallet_contracts --> runtime/src/lib.rs:279:24 | 279 | impl pallet_contracts::Trait for Runtime { | ^^^^^ not found in pallet_contracts
can anyone tell me what should I do to solve this error

It could be that the tutorial is outdated, we should check.
Are you willing to help with this request?
Yes!

The tutorial in the docs works fine.
It's possible that the user followed an older tutorial that's not in the docs ( that still uses the Trait naming, and still contains some types that are now obsolete).

Dear cmichi ,
Tutorial for me is working fine.Tutorials are updated now please try again .

That's great to hear, thank you both!


Support removing trends widgets without cogwheel

Some users are reporting a version of the trends widget without the cogwheel link. We can try to identify this version (also the other version, but let’s keep the old code for that) using the “trending with…” links under some trends, which, if they exist, identify the source via some URL parameters.

Works, reportedly, so let’s merge.


Add logs to debug transfer task

What changed?
Add logs to debug transfer task

Why?
to debug lost transfer tasks

How did you test it?

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 0182cc68-fd51-4fe4-a748-b9194614bac7

5 of 9 (55.56%)  changed or added relevant lines in 1 file are covered.
55 unchanged lines in 10 files lost coverage.
Overall coverage increased (+0.06%) to 57.702%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

service/history/queue/transfer_queue_processor_base.go
5
9
55.56%

Files with Coverage Reduction
New Missed Lines
%

common/task/weightedRoundRobinTaskScheduler.go
1
89.64%

common/persistence/executionManager.go
2
77.95%

common/persistence/statsComputer.go
2
93.57%

common/task/fifoTaskScheduler.go
2
87.63%

service/history/execution/mutable_state_builder.go
2
68.98%

service/matching/taskListManager.go
3
75.87%

service/history/task/transfer_standby_task_executor.go
4
86.68%

service/history/shard/context.go
9
66.7%

service/history/execution/context.go
14
68.23%

common/persistence/sql/sqlExecutionStore.go
16
62.4%

Totals

Change from base Build 0182cb11-5013-431c-87c1-2643c653ff97:
0.06%

Covered Lines:
84104

Relevant Lines:
145755

💛  - Coveralls


[Bug]: Unable to download excel sheet successfully as it says file corrupted when trying to open the doc

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Link to slack conversation: https://theappsmith.slack.com/archives/C0341RERY4R/p1678954237147369
Steps To Reproduce

Go to this app https://app.appsmith.com/app/download-jsreport-document/page1-6424543cdc009637d664ba3c
Click on Download button
Try to open the downloaded file
Get an error while trying to open.

Public Sample App
https://app.appsmith.com/app/download-jsreport-document/page1-6424543cdc009637d664ba3c
Environment
Production
Issue video log
No response
Version
Cloud - v1.9.15

I have object:
`export default {
downloadXLS: async (name, guid, from, to) => {

	let data = await DownloadXls.run({
		"guid": guid,
		"from": from,
		"to": to
	})

	await download(data, name+"-"+from+"--"+to+".xlsx", "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet")
}

}And I call from table, button on click:{{
DownloadObject.downloadXLS(
Table1.triggeredRow.name, Table1.triggeredRow.guid,
from.inputText,
to.inputText
)}}`
It works

We find that when using the Table's builtin download button, any table that has a numeric column, will produce an excel file that when opened in Excel produces an error message regarding recovery of the file.
If we change the column type in the Table's column's properties to Plain Text, the file is created correctly. But this then breaks sorting of numeric columns (and maybe filtering?).
This is a basic functionality that is built into the table widget but does not work. Telling users to just "ignore the error" is not a good look. We are forced to disable this functionality and build another download button somewhere on the canvas, taking screen space unnecessarily.

We find that when using the Table's builtin download button, any table that has a numeric column, will produce an excel file that when opened in Excel produces an error message regarding recovery of the file.

I confirm a similar issue. Numeric columns miss the column title. When changing the type to plain text everything is fine.

Are there any updates on this issue? I encountered this problem using FilePicker
In my project I use the Appsmith + FastAPI. When I upload a file that is larger than 100kb, appsmith saves it to my file system. However, when opening the file, it seems to be corrupted. After researching more, I uploaded the file manually using swagger and noticed a difference in file sizes (the difference is on average 40kb). It’s interesting that files smaller than 100kb are uploaded correctly

I suspect that the file might be truncated or modified during the Appsmith upload, causing this error for specific .xlsx files

@bl1nkker this seems to be a very different issue you are facing. Can you please open a new issue with a sample app and file that we can use to test?
I'm closing this issue because it's not possible to reproduce the original issue


Refactor masternode and gobject RPCs to support help command subCommand syntax

See issue https://github.com/dashpay/dash/issues/2220

👍


zchange title on README

zzz

zzz

You can play the game at: https://newmanszhang.github.io/github-games/


[MLlib][Doc] Seed fix in mllib naive bayes example

Previous seed resulted in empty test data set.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I can't reproduce this. On master this results in a test set with 1 element. changing to 13 yields a test set with 2 elements. I don't mind changing it but are you sure?

I'm getting empty test set with spark-core_2.11 version 1.4.0 and spark-mllib_2.11 v. 1.4.0 used as SBT dependencies.

OK. This could be down to difference in Spark, Scala, the RNG across versions. If 13 works in your case, and still works for the plain-vanilla master + 2.10 build, I think we can just make this change.

So I thought. I can confirm that version 1.4.1 still results in empty test set.

We use Java's Random in randomSplit, which shouldn't be affected by the Scala version. Which JVM did you use?

1.8.0_45, Windows 8

I'm on 1.8.0_45 / OS X

@mupakoz I got the same result as @srowen . I don't think changing the seed is the solution. Instead, we should add more rows to sample_naive_bayes_data.txt. Could you do that instead?

Of course, no problem :). I'll prepare the commit later today.

@mengxr done. I added a few rows to the sample data and reverted the seed change. However, I had to add two rows for each class for the test set not to be empty after the split. Adding one row didn't resolve the problem.

@mupakoz We can add more rows to avoid this (even with duplicates).

LGTM. Merged into master (skipped Jenkins). Thanks!


Remove extra links in the footer that aren't being used

Remove these sections that aren't used anymore
Screenshot:

Full screen:

-------------------------------------
Website URL:
http://localhost:3000/
Device and browser info:
Chrome <IP_ADDRESS> (1528x946) | Mac OS (arm) 10.15.7
Date and time:
September 25th 2023 | 11:09pm UTC
View developer information (console logs, network requests & timing):
jam.dev/c/076a835b-58da-4778-a08f-a0f4384fe210
-------------------------------------
Captured with jam.dev

Hey, I have expertise in it, can I please be assigned to it?

hi, @edwinthinks I can remove the unused links and ensure the page design is still functioning well, can you assign me please?

@elidakirigo its yours :)

on it :)

hi @edwinthinks going through the project I noticed I needed ruby installed in order to proceed with local setup, I haven't worked with ruby hence I would not be fit for this task, sorry feel free to unassign kindly.

@nsiwnf If you want I can take this one. or @kasugaijin


Use https://api.datos.gob.mx

Use json data from api.datos.gob.mx to obtain the last copy of the database and check if the current database is updated
https://api.datos.gob.mx/v1/datasets/5a5783daeb88f68a39e7f453

The resource is no longer available


(fix) docker COPY does not copy folder itself, only contents

NOREF/fix-Dockerfile
Changes and Description

Separate COPY command for cmd/ and pkg/ as COPY does not copy folder itself, only the contents of folder. This PR will explicitly specify the ./pkg/ and ./cmd/ folders for the COPY command to place the contents into.

How to test this change

PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

Local build successful -
➜  ~/oddball/CMSGOV/mint-app git:(NOREF/fix-Dockerfile) ✗ docker buildx build --build-arg ARG_APPLICATION_DATETIME=2023-10-02 --build-arg ARG_APPLICATION_TS=1696264021 --build-arg ARG_APPLICATION_VERSION=78a6fb2f4cdf517f1aa047ccef4949254f0ecbb9 --file Dockerfile .
[+] Building 24.7s (18/18) FINISHED                                                                                docker:default
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 1.28kB                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 213B                                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.21                                                                                2.1s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 31.63kB                                                                                0.0s
 => [stage-3 1/4] WORKDIR /mint/                                                                                0.0s
 => [base 1/6] FROM docker.io/library/golang:1.21@sha256:19600fdcae402165dcdab18cb9649540bde6be7274dedb5d205b2f84029fe909                                                                                0.0s
 => CACHED [base 2/6] WORKDIR /mint/                                                                                0.0s
 => CACHED [base 3/6] COPY config/tls/*.crt /usr/local/share/ca-certificates/                                                                                0.0s
 => CACHED [base 4/6] RUN update-ca-certificates &&  apt update &&  apt install -y tzdata &&  rm -rf /var/lib/apt/lists/*                                                                                0.0s
 => CACHED [base 5/6] COPY go.mod go.sum ./                                                                                0.0s
 => CACHED [base 6/6] RUN go mod download                                                                                0.0s
 => CACHED [stage-3 2/4] COPY --from=base /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/                                                                                0.0s
 => CACHED [stage-3 3/4] COPY --from=base /usr/share/zoneinfo /usr/share/zoneinfo                                                                                0.0s
 => [build 1/3] COPY cmd/ ./cmd/                                                                                0.0s
 => [build 2/3] COPY pkg/ ./pkg/                                                                                0.1s
 => [build 3/3] RUN CGO_ENABLED=0 GOOS=linux go build -a -o bin/mint ./cmd/mint                                                                                22.0s
 => [stage-3 4/4] COPY --from=build /mint/bin/mint .                                                                                0.1s
 => exporting to image                                                                                0.2s
 => => exporting layers                                                                                0.2s
 => => writing image sha256:854d2668ef01e132b52e0893507eadbf8457ea9e8590c695dc31214c71cad61c                                                                                0.0s


Migrate to Swift 4.0.2

Removes backwards compatibility, full migration to Swift 4.0.2

@sandmman As this will break compatibility with Swift 3, I assume we want to bump the major (or at least the minor) when we tag this?

Codecov Report

Merging #70 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage    49.6%   49.47%   -0.13%
==========================================
  Files          12       12
  Lines        1633     1633
  Branches       71       71
==========================================
- Hits          810      808       -2
  Misses        799      799
- Partials       24       26       +2

Flag
Coverage Δ

#CouchDB
49.47% <100%> (-0.13%)
:arrow_down:

#CouchDBSample
49.47% <100%> (-0.13%)
:arrow_down:

Impacted Files
Coverage Δ

Sources/CouchDB/Database.swift
48.45% <100%> (-0.29%)
:arrow_down:

Sources/CouchDB/ConnectionProperties.swift
39.28% <0%> (-3.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdc610...0a65c61. Read the comment docs.

@tunniclm yes, this will go to 2.0.0


Strange characters rendered

Just installed Graphite-Web, Carbon and Whisper from the master branch:

Do you have any advice on what I can do?

Something is wrong with your fonts. Which OS are you using?

The Graphite suite is installed on a CentOS Linux 7 (Core) VM with Kernel Linux 3.10.0-514.16.1.el7.x86_64
I tried viewing graphs from the latest version of Chrome, Firefox and Internet Explorer on Windows 8.1 and the result is the same.
Graphs rendered by already installed older versions are displayed correctly.

Can it depend from old config files or from file/folder permissions?

Nope, it's only matter of font packages. Please try to install dejavu-sans-fonts & dejavu-serif-fonts packages.

PS:

Graphs rendered by already installed older versions are displayed correctly.

Did I understand correctly that old version is installed on another server, right?

Perfect thank you: it works now!


Fixed missing 'j' in g:snipe_jump_tokens

Sorry about the previous PR. This one should be good.

Thanks 👍


Chat with page suggestion

Although it generally works well, it deviates from the answers due to the presence of extraneous html components in the context.
I was wondering if it is feasible for the extension to evaluate only the element that we explicitly select using the inspect tool, so that the results could be generated with accurate context.

I like this idea. I will add a feature like the inspect tool in Chrome DevTools, which allows you to select the content you want to chat about.

It appears that sometimes only CSS is embedded as the model can not discern any content and will only talk about styling and code. Is it possible to attempt some document conversion by default, similar to firefox's reader mode?

Yes, I'm adding Mozilla's readability to the chat with website mode

I don't know if you want to add 3rd party services to this but solutions like jina exist for this purpose and don't require the user to get and api key. Admittedly this is tricky because it could change in the future I guess.

the latest version of the Page Assist website parser works similarly to the Jina one. It needs a few more improvements, but overall, it's the same

@n4ze3m  One thing I was looking for when I installed the extension, and that could be related to this feature request, was something similar to brave's leo ai, where you can select a piece of text and then prompt the ai something regarding it.

It lists a few presets of options, like summarize, explain, etc, but ideally it would be good if custom ones could be added (probably a list of title and system prompt to use when that option is selected), then when you select a text (could be a paragraph, or the whole article) and click on an option, it would send that text as a prompt, and together with the system prompt (or something similar, like just prepending the selected text with something like Summarize the following text: or Translate the following text) I guess it would generate the desired outcome :thinking:
Also, let me know if this is better off as a separate issue, I just thought this might be simpler to implement as it wouldn't require a inspect dom tool, and at the same time would achieve the same goal, but with more flexibility since you would be able to pre-define custom prompts as well

Hey guys, the latest version supports a Leo-like feature. Please note that you can edit the prompt from the 'Manage Prompt' section

That looks amazing. I'm not seeing an update though? Should I install manually, if it not on the store yet?

Ok sorry, it's on text selection specifically :) Wow. Works for me, and the prompt seems to be bang on! Very impressed!


cleanup, small cov incr in compiler app

Codecov Report

Merging #27 into master will increase coverage by 0.4%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #27     +/-   ##
=========================================
+ Coverage   98.68%   99.08%   +0.4%
=========================================
  Files          16       16
  Lines        5462     5462
=========================================
+ Hits         5390     5412     +22
+ Misses         72       50     -22

Impacted Files
Coverage Δ

src/yatol/semantic/versions.d
99.6% <ø> (-0.01%)
:arrow_down:

src/yatol/semantic/echo.d
100% <100%> (+17.94%)
:arrow_up:

src/yatol/semantic/package.d
80% <0%> (+5%)
:arrow_up:

src/yatol/app.d
80.58% <0%> (+13.59%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0045dde...785213d. Read the comment docs.


MINOR: Test assign() and assignment() in the integration test

A missing piece from KAFKA-14950. This is to test assign() and assignment() in the integration test.
I also fixed an accidental mistake in the committed API.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@philipnee : Thanks for the PR. Are the test failures related? Also, there are compilation failures in JDK 8.

Task :core:compileTestScala

[Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-14086/core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:23:8: value SeqHasAsJava is not a member of object scala.jdk.CollectionConverters
[Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-14086/core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:35:30: value asJava is not a member of List[org.apache.kafka.common.TopicPartition]

[Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-14086/core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:50:30: value asJava is not a member of List[org.apache.kafka.common.TopicPartition]

[Warn] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-14086/core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:23:39: Unused import

Hey @junrao Thanks a lot for reviewing this. I fixed the broken build and here are the failing tests.  I believe they are unrelated:
Build / JDK 17 and Scala 2.13 / testReplication() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest
3m 11s
Build / JDK 17 and Scala 2.13 / testDescribeAtMinIsrPartitions(String).quorum=kraft – kafka.admin.TopicCommandIntegrationTest
19s
Build / JDK 8 and Scala 2.12 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest
2m 3s
Build / JDK 8 and Scala 2.12 / [3] idBlockLen=10 – kafka.coordinator.transaction.ProducerIdManagerTest
<1s
Build / JDK 8 and Scala 2.12 / testSnapshotsGenerated() – kafka.server.RaftClusterSnapshotTest
26s
Build / JDK 8 and Scala 2.12 / testBalancePartitionLeaders() – org.apache.kafka.controller.QuorumControllerTest
12s
Build / JDK 8 and Scala 2.12 / shouldWriteLatestOffsetsToCheckpointOnShutdown[exactly_once] – org.apache.kafka.streams.integration.EosIntegrationTest
12s
Build / JDK 11 and Scala 2.13 / testDescribeAtMinIsrPartitions(String).quorum=kraft – kafka.admin.TopicCommandIntegrationTest
18s
Build / JDK 11 and Scala 2.13 / testTaskRequestWithOldStartMsGetsUpdated() – org.apache.kafka.trogdor.coordinator.CoordinatorTest
2m 0s
Build / JDK 20 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest
2m 0s
Build / JDK 20 and Scala 2.13 / testRackAwareRangeAssignor() – integration.kafka.server.FetchFromFollowerIntegrationTest
40s
Build / JDK 20 and Scala 2.13 / testRackAwareRangeAssignor() – integration.kafka.server.FetchFromFollowerIntegrationTest
42s
Build / JDK 20 and Scala 2.13 / testBalancePartitionLeaders() – org.apache.kafka.controller.QuorumControllerTest
12s