Fixes #1630 - reference identifier search

This PR implements the :identifier search modifier.
FHIR references can have an identifier property of type Identifier. The :identifier modifier searches reference.identifier with all of the identifier token semantics (value, system|value, system, etc).
For example:
GET [base]/Observation?subject:identifier=http://acme.org/fhir/identifier/mrn|123456

This is an odd feature, because it is basically an extra SearchParameter for every existing SearchParameter with type=reference.
The implementation here implements exactly that pattern via the new deriveIdentifierSearchParameter() utility method.  At "index" time and at "search" time, for every "reference" search parameter, we also allow the derived "identifier" search parameter.

Coverage: 94.033% (+0.02%) from 94.017% when pulling d47bb6a817f0f123e6a145314bc918aff9cdeef3 on cody-reference-identifier-search into 5125b948d4d15e77d4249a06f6d2f2aeb224d217 on main.


[WIP] Fixing Documentation

Hi @demelin,
Thanks a lot for such a comprehensive codebase for your paper. As part of our NLP course at UW (CSE 517), we (@carolinahiguera, @npho, and I) reproduced your code. We found it great to work with and were able to replicate all the classification experiments from your paper. We found some minor issues in getting started and as part of this pull request, we wanted to fix it.
In addition to changes in README, we have also hosted the models we have trained on hugging face. If you'd like we can add a link to that on the README as well :)

Hey Sebastin!
Super happy to hear that you found my codebase useful for your studies :) ! And that the experiments could be replicated, of course. Thank you for the suggested fixes, they are very much appreciated! And yeah, if you don't mind, please go ahead and add the link to the models to the readme - I'm sure someone will find them useful.
Cheers,
Denis

@demelin Thank you for accepting our PR. Here is the Huggingface link for some of the models that we trained: https://huggingface.co/moralstories


developer friendliness -- buildx missing in 23.04

buildx is not on the 23.04 image. look into getting it there so the build just works for people

migrated * to the 23.04 and upstream docker.


Add properties for datasets in a dataset series

Problem statement
Following DCAT 3, DCAT-AP 3 introduces properties specific to datasets in a dataset series, namely, dcat:inSeries, dcat:next, and dcat:prev (see the DCAT-AP 3 specification, §7.8).
d).
Proposal
To be aligned with DCAT-AP 3 and DCAT 3, GeoDCAT-AP 3 should include properties  dcat:inSeries, dcat:next, and dcat:prev .

Dataset in Dataset Series did not make it into the current and final draft of DCAT-AP 3.0.0.
Still, datasets in a series should be connected to the series via dcat:inSeries. dcat:next was removed from DCAT-AP, as the preferred of the two properties in DCAT is dcat:prev.
That being said, currently, I do not see evidence of support for a relation similar to dcat:prev in the INSPIRE Technical Guidelines that could map to dcat:prev.
I do not even see how a relation similar to dcat:inSeries is represented in the INSPIRE metadata, but I may be missing something.


Update README.md

#331 proposed a change to our README, but didn't sign the CLA. This PR contains the same change, but now it comes from me.

🚀 [bumpr] Bumped! New version:v1.0.21 Changes:v1.0.20...v1.0.21


Add support for Mtime 2.0.0

This PR adds an upper bound on mtime library and includes a missing logs-syslog dependency for EIO.

Thanks for this PR, but wouldn't it be nicer to move on and support mtime >= 2.0.0? Shouldn't be too hard to figure out which parts needs to be adapted.

It's kinda sad how complicated it is to get "uptime in seconds", I think this should do it without the manual conversion:
Int64.div (Mtime_clock.elapsed () |> Mtime.Span.to_uint64_ns) (Int64.of_int 1_000_000_000)

lgtm

Thanks @haesbaert for the help with the conversions.
Commit a89cc6f updates to mtime >= 2.0.0 as requested @hannesm
The other commit might be interesting as a meta-data back port for https://ocaml.org/p/charrua-unix/1.5.0 which has the added constraint mtime >= "1.0.0" & < "2.0.0".

It's kinda sad how complicated it is to get "uptime in seconds", I think this should do it without the manual conversion:
Int64.div (Mtime_clock.elapsed () |> Mtime.Span.to_uint64_ns) (of_int 1_000_000_000)

What you can as well do is use duration and Duration.to_sec (Mtime_clock.elapsed () |> Mtime.Span.to_uint64_ns) if you like to avoid hardcoded digits.

It's kinda sad how complicated it is to get "uptime in seconds", I think this should do it without the manual conversion:
Int64.div (Mtime_clock.elapsed () |> Mtime.Span.to_uint64_ns) (of_int 1_000_000_000)

What you can as well do is use duration and Duration.to_sec (Mtime_clock.elapsed () |> Mtime.Span.to_uint64_ns) if you like to avoid hardcoded digits.

Ah yes please that looks much better, both us missed I guess.

Duration.to_sec is actually gone, there is Mtime.Span.s, but there is no division arithmetics for it (there is mul though)


using the same directory doesn't merge repos

~/study/c++/:
  uMario:
    repo: "git+https://github.com/jakowskidev/uMario_Jakowski"
    remotes:
      tony: "git@github.com:tony/uMario_Jakowski.git"

~/study/c++/:
  sdl2-playproject<EMAIL_ADDRESS>  aseprite:
    repo: 'git+https://github.com/aseprite/aseprite.git'
    remotes:
      tony<EMAIL_ADDRESS>
won't merge repos. fix

http://yaml.org/spec/1.1/#id932806

In such a case the YAML processor may continue, ignoring the second key: value pair and issuing an appropriate warning. This strategy preserves a consistent information model for one-pass and random access applications.

In 1.2, http://www.yaml.org/spec/1.2/spec.html

JSON's RFC4627 requires that mappings keys merely “SHOULD” be unique, while YAML insists they “MUST” be. Technically, YAML therefore complies with the JSON spec, choosing to treat duplicates as an error. In practice, since JSON is silent on the semantics of such duplicates, the only portable JSON files are those with unique keys, which are therefore valid YAML files.

This may not be a vcspull problem

Closing, this is a yaml issue


Document functionality and testing

Trello: https://trello.com/c/Fhqmp62n/771-document-outcome-of-testing-paste-html-to-govspeak
This PR attempts to document how this functionality works in a way that explains the various limitations and problems it could hit. I've tried to collate the common discoveries from the testing work into a format that can expand in time if/when we learn of more.
I've also put in a file which has HTML especially written in a format that is friendly for the tool which can act as a best case scenario.
Finally, I've added some debug information.

@emmabeynon Thanks Emma, I've made those changes.
I don't think we should add a full summary of rules added to overcome issues, as that'll couple this document to any future fixes we make. They are mostly documented too in the commit and/or the fix. I am opening to adding specific ones where they're relevant. Do you have any that you think should be included? The ones that I can think of are paragraphs in list items and the ordered list header issue. I'll see if I can slot them in.

@emmabeynon I've updated this now.

Thanks @emmabeynon 🎉


Graphics corruption after enabling "Hidden Test" +"Gravity Well" and returning to game screen

Description:
First of all, I'd like to thank you for porting this classic game to Android! I've always been a fan of Space Cadet and having it on mobile is fantastic. The port works well overall, and I appreciate the effort you've put into bringing back this nostalgic experience :)
However, I came across a visual issue that I wanted to report.
Steps to Reproduce:

Go to the game settings.
Enable "Hidden Test".
Enable "Gravity Well".
Return to the main game screen.
The game assets appear corrupted, as shown in the attached image.

Expected Behavior:
The game assets should display correctly without visual corruption after enabling these features.
Actual Behavior:
Graphics become distorted, making it hard to enjoy the game.
System Info:

Device: Oneplus 11
OS Version: Android 14
Game Version: 2.5

Additional Information:

The issue specifically occurs only after enabling "Hidden Test" and then "Gravity Well", and then returning to game screen. i have tried multiple other combinations to reproduce the same bug, but i was unable to.

if you do it before the game is loaded (i.e before the ball appears in a new game) all the assets are corrupted as shown here

But if you do it after the game has loaded, the assets get progressively corrupted whenever the ball hits them. Shown here

Upon reloading from the above state, all assets load visually corrupted.

Force closing and opening the app loads the game normally, only happens when HT + GW are enabled.

Please let me know if I can provide any further information or assist in reproducing the issue. Thanks again for your efforts!

Hi Rohit! Hi everyone 👋🏻 .
Alright, just to add, this also happens on Android 13 (OxygenOs 13) - OnePlus Nord Ce5g.

AS A SIDENOTE FOR EVERYONE: This just doesn't happen for OnePlus' devices; I've just tested it on a Samsung Galaxy Z Fold 2 device and the same bug happens (refer to the attachment below)

So, this isn't a bug related to the OS of the device or something, the thing is in the apk.
Greetings!

Diego (lokustus)

Hi Diego! 👋🏻
Thanks for confirming this and testing it on other devices! It’s helpful to know that it's happening across multiple brands and not just device-specific.
Appreciate your input!
Best,
Rohith


Hyper CLI AttributeError no attribute 'OP_NO_COMPRESSION'

On Mac OS X 10.11.3, if I attempt to run the following:
$ hyper GET https://http2bin.org/
Traceback (most recent call last):
File "/usr/local/bin/hyper", line 11, in
sys.exit(main())
File "/Library/Python/2.7/site-packages/hyper/cli.py", line 244, in main
data = request(args)
File "/Library/Python/2.7/site-packages/hyper/cli.py", line 233, in request
conn.request(args.method, args.url.path, args.body, args.headers)
File "/Library/Python/2.7/site-packages/hyper/common/connection.py", line 98, in request
method=method, url=url, body=body, headers=headers
File "/Library/Python/2.7/site-packages/hyper/http11/connection.py", line 164, in request
self.connect()
File "/Library/Python/2.7/site-packages/hyper/http11/connection.py", line 128, in connect
sock, proto = wrap_socket(sock, host, self.ssl_context)
File "/Library/Python/2.7/site-packages/hyper/tls.py", line 36, in wrap_socket
_context = init_context()
File "/Library/Python/2.7/site-packages/hyper/tls.py", line 91, in init_context
context.options |= ssl.OP_NO_COMPRESSION
AttributeError: 'module' object has no attribute 'OP_NO_COMPRESSION'
Given the error I did check that the command works as expected if  I don't use a HTTPS URL (example hyper GET http://http2bin.org/).

Your version of Python or OpenSSL is too old for us to safely secure the connection.
HTTP/2 puts some very strong requirements on the quality of the TLS used to establish the connection. One of these requirements is that TLS compression must be disabled. Your particular Python or OpenSSL does not expose OP_NO_COMPRESSION, which makes it impossible for hyper to disable it. Hyper correctly considers this an error condition: if it didn't, once the connection is established you'd likely see it immediately torn down with an INADEQUATE_SECURITY error code.
Where did your Python come from, and what OpenSSL is it linked against? (You can answer that latter question by typing python -c 'import ssl; print ssl.OPENSSL_VERSION')

Python came as Apple's development tools package (Python 2.7.10 (default, Oct 23 2015, 18:05:06) )
$ python -c 'import ssl; print ssl.OPENSSL_VERSION'
OpenSSL 0.9.8zg 14 July 2015

Yup, that version of OpenSSL is altogether too old to do HTTP/2. You'll need to replace it, probably using Homebrew.


Add missing backticks to hist docstring

Description
Add missing backticks to the hist docstring (only a very small change I know!!).
Type of change

[x] Bug fix (non-breaking change which fixes an issue), actually just an update to documentation.

Checklist

[x] Added or changed relevant sections in the documentation

Thanks!


Sugested Mods for Integration

Intro
reading time: 3 min
After going through all mods on the Civ VI workshop under the UI tag (most are not UI mods), I have found the following mods an objective improvement. I will keep the descriptions short as the screenshots on the Steam workshop do a much better job.
I will list mods and the reasons why, I feel, they should be integrated. Mods appear in order of importance. All these mods I have used in multiple games with CQUI without any issues.
Alternate Policy Screen (link)
If you had to pick one mod from here, make it this one. Gets rid of the clunky card layout and adding more options to sort policies. The “new” category being particularly useful. It gets even better when used in combination with the following mod.
Better Report Screen (link)
The amount of information, and time saved with this mod is insane. Here are some things I used it for: finding the third most productive city, finding a specific apostle, finding idle workers and traders and a lot more. It gets even better when combined with the mod above, because now each policy shows how much effect it will have. Screenshots here.
Notification Log + Simplified Combat Reports (link 1) (link2)
I nearly went cross eyed with 10 rumors popping up every turn informing me that someone build an aqueduct district. This mod moves it all into a nice and compact panel on the side. Combine with the Simplified Combat Report and it just very nice to look at. The Notification Log mod is the only one that didn’t work out of the box, requiring the Simplified Gossip mod to be enabled, even though it’s integrated into CQUI.
Side note: I feel these mod would be rendered unnecessary by reducing the amount of useless gossip. The only ones that have been useful to me are the wonder and considering war ones.
Better World Rankings + Global Relations Panel (link 1) (link2)
I can live without these mods, but they are useful nevertheless. Their names should be description enough. They are particularly useful for Cultural victories.
Thanks for reading and your work.

@Nani-Sore-0 Right now the philosophy is to reduce or maybe even remove all integrations. Integrations add little to no value but require constant attention and overall increase amount of work on the mod.
We agreed that exceptions could be situations where author(s) no longer maintain the mod.

@Nani-Sore-0  I definitely agree that using the standard game UI is painful and counter-productive. it seems to me that no one on the gamedev team actually plays the game start to finish:
every individual game component works to achieve its locally-stated goal (add unit to queue - works, build a wonder - works, replace a card - works, etc), but the overall user experience is just horrendous. if you ever played a single game start to finish, you would see how disjointed and suboptimal the user experience is.
this is the main impediment for me personally to play the game regularly.
any Civ player with a 1000+ hours of experience could easily produce (and probably would be just happy to do it, if asked!) a list of potential changes for the UX that would greatly improve user satisfaction, thus making it more re-playable.
but... I am afraid the UX situation is not likely to be addressed by the game studio in the near future. the existing players (those who have already PAID) do not contribute much to the additional profits the company needs to acquire to be able to survive... I am actually glad the company may be inching towards the monthly/yearly subscription model (as opposed to "buy once, use forever"). as much as some people are wary about this, this may be a way for the company to maintain enough of a profit level to be able to invest into things like UX and everything else. this is a total speculation on my part though, so don't take this to the bank.
anyway, I am glad that some of the existing UI mods address certain shortcomings of the game, making them less painful.
as far as the mods integration goes - as @Infixo  mentioned, one potential reason for pulling mods into this one would be if the original mod is abandoned. but even then - we could just fork them into our github org and maintain them there.
while bundling multiple plugins into one simplifies their discoverability (no need to search for multiple plugins), the downside is that every time a game patch is released, something can break (that would be a whole other interesting discussion on the value of exposing and maintaining stable APIs, ensuring that external popular mods work, etc). if things do break , the user would need to disable the WHOLE plugin , thus losing access to all the goodies and not just that one piece that is broken.
what I would propose instead is having some page listing the reviewed, tested and "community-recommended" UI mods, with some compatibility matrix or notes.
maybe a README file in this repo, or have a separate REPO just with docs ( to indicate that this is not a part of CQUI, but rather some general information about Civ 6 game).
I would start with a chapter in the README file in this repo to simplify the discoverability of this information for our beloved visitors who this whole thing is created for.
tagging @alimulhuda  and @the-m4a as well

I agree with what Infixo and alexeyOnGitHub says. Also to add a bit of past info, we have at times looked over requests where people had conflicts between CQUI and other mods, and made changes where possible to make it so that they are compatible. That will not always be the case but I think we have been looking at those things on a case-by-case basis.
The report screen one (BRS) is one of Infixo's and I believe he mentioned somewhere else that it should just work alongside CQUI. If the other ones have issues working alongside CQUI, then let us know here. No promises but sometimes the fix is easy to do and we can probably try a compatibility fix for those ones.

@alexeyOnGitHub I feel like this is always the trade off of semi-complex strategy games aimed at the mainstream market. The UI in Civ VI works well, I feel, for a casual Prince/King player that only plays sometimes or doesn't really "push the game."
I fell like have have misunderstood. When I saw that some mods where integrated I assumed you are looking for more and that the goal was to unify all good UI mods into one mod. Even if you did integrate all the mods above, in a sense that I have one mod and not several, nothing would really change for me as it all works as expected.

what I would propose instead is having some page listing the reviewed, tested and "community-recommended" UI mods, with some compatibility matrix or notes.

Adding links and and a list showing compatibility, under an optional "add-on" section perhaps, would have the same practical results as integration.
One more thing, change the README to say on the top that this is the updated version. If you google CQUI you end up on the old Azurency repository and it looks identical to this one, at a glance of course.


Publish the latest version to Maven central

The latest version of the connector for Flink 1.11 available in Maven central repository is 2.3.0, while the README mentions 2.3.1.

Thanks for reporting this @vitaliislobodianyk-okta. We will promote the build to maven central soon.

Sorry for the delay, all versions have been deployed to Maven central. It may take a few hours for the jars to show up.


hasFormat gives wrong results in IE

When the beginning of an element with a format is selected in IE (10 or 11, likely others), hasFormat does not find the format as expected.
Example: If the editor contains
Argle bargle foo
 and you select all of 'bargle' or 'bar', hasFormat('b') will return false. If you select 'arg' or 'gle', it will return true, as expected.

Having trouble replicating this one now.

No, now I can again. It happens, specifically, when selecting from the back toward the front of the formatted element. So in the example above, if one clicks the g in 'bargle' and drags to select the front of the word ('barg'), then editor.hasFormat('b') returns false, it seems.

In this case, the selection appears to start at the last index of the previous sibling element, so, again with the above example, at the tail end of the text node containing 'Argle '. I'll add a test case to #141.

Fixed by #141.


WIP] Add tests for HeapDumper

:memo: Blocked on #319, and also a work in progress.

Codecov Report

Merging #338 into master will increase coverage by 0.36%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   16.29%   16.66%   +0.36%
==========================================
  Files         198      200       +2
  Lines      112699   112724      +25
  Branches    11244    11244
==========================================
+ Hits        18368    18784     +416
+ Misses      93537    93087     -450
- Partials      794      853      +59

Flag
Coverage Δ

#2017
16.66% <76.47%> (+0.36%)
:arrow_up:

#Debug
16.66% <76.47%> (+0.36%)
:arrow_up:

#Release
?

Impacted Files
Coverage Δ

src/PerfView/memory/HeapSnapshot.cs
26.04% <ø> (+26.04%)
:arrow_up:

src/PerfView/Properties/BuildDateAttribute.cs
0% <0%> (ø)

src/PerfView/App.cs
5.37% <0%> (+2.63%)
:arrow_up:

src/PerfView.Tests/Utilities/PerfViewTestBase.cs
95.52% <100%> (+3.09%)
:arrow_up:

src/PerfView.Tests/Memory/HeapDumperTests.cs
95.83% <95.83%> (ø)

src/PerfView/PerfViewEventSource.cs
10% <0%> (+2%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67d0e5...29ac645. Read the comment docs.


[REF] move to native stack navigation

I've been testing the navigation a lot and it seems to work well. The only issue I detect is that the TransactMenu doesn't close after select an option. The app freezes.

@Gamboster fixed. Thanks for reviewing

https://github.com/bitpay/bitpay-app/pull/1005


Do not assign numbers to drafts

Proformas and Invoices should not get numbers when they are saved in draft state. Instead they should get number and series when they are issued (of course, if they don't have a manually assigned ones).

@bogdanpetrea this one is on live?


Typos

Typos:

the code server is registered as code_server not codeserver
Applications tab rather than Application tab in the observer

Thanks.


KAFKA-15838: ExtractField and InsertField NULL Values are replaced by default value even in NULLABLE fields

Value null is valid for an optional filed, even though the field has a default value.
Only when field is required, the class return default value fallback when value is null
Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

A follow up after this https://issues.apache.org/jira/browse/KAFKA-8713
@C0urante @divijvaidya @mimaison

Hi @mfvitale, thanks for the PR!
This is adding new configurations to transformations so this will require a KIP.

Hi @mfvitale, thanks for the PR! This is adding new configurations to transformations so this will require a KIP.

@mimaison actually key.converter.replace.null.with.default and value.converter.replace.null.with.default are not new configuration but are the one used by JsonConverter added with https://github.com/apache/kafka/pull/13419

While it's not directly adding new configurations, it's effectively changing the behavior of ExtractField and InsertField and making them support new configurations. The configure() method on Transformation is only called with configurations provided with their prefix. In this example a user would need to set something like:
transforms=my-smt
transforms.my-smt.type=MyTransformation
transforms.my-smt.key.converter.replace.null.with.default=false

Also by not defining the configurations explicitly users can't discover them using the GET /connector-plugins/{plugin-type}/config.

The configure() method on Transformation is only called with configurations provided with their prefix.

This cleared my doubt. So in that case it should be clear declared as an SMT configuration. I'll open a KIP. Thanks for the explanation.

@mimaison Seems that the KIP-1040 has been accepted. Do you think it's mergiable now??

@jlprat do you think this can be backported?

@mfvitale Merge-able, I don't know yet, but we can start reviewing it :)
This is not a candidate for 3.8 as we're now past code freeze. Also the KIP only got 3 binding votes earlier this week and KIP freeze was on May 15.

@mfvitale Merge-able, I don't know yet, but we can start reviewing it :)

;-)

This is not a candidate for 3.8 as we're now past code freeze. Also the KIP only got 3 binding votes earlier this week and KIP freeze was on May 15.

Ok, I tried :smile:

@C0urante Can I ask to have a look?

As @mfvitale mentioned
@divijvaidya @mimaison

Thanks for your review, required changes is now addressed.

Thanks for the PR. The KIP mentions updating InsertField, ExtractField, HeaderFrom, Cast, SetSchemaMetadata, TimestampConverter, MaskField, ValueToKey and ReplaceField. Is there a reason this PR only updates ExtractField and InsertField?

The orignal KIP scope was for InsertField and ExtractField but it was enlarged during KIP discussion. In agreed with @C0urante that not all SMTs should have implemented in this PR, mainly for time constrain.
In any case I can try to do my best to add the others, but then will be good if we can merge what we will have ready for the 3.9 feature/code freeze. WDYT?

Sure, it's fine to do the remaining transformations in another PR. I just wanted to check you were happy with the content of this PR before spending time reviewing it.

Sure, it's fine to do the remaining transformations in another PR. I just wanted to check you were happy with the content of this PR before spending time reviewing it.

Yes, I am good with it. I'll let the others SMTs to another PR.

Thanks for the PR! I made another pass. The changes look fine overall, I left a couple of questions/suggestions and spotted a bunch of cosmetic issues.

Changes done.

@C0urante @yashmayya @gharris1727 Since you also voted on the KIP, do you want to take a look?
If not let's merge next week. Thanks

Test failures appear unrelated, and connect:transforms:test passes for me locally.


Update and re-structure documentation

Which area this feature is related to?
/area documentation
Which area is this documentation change is related to?

/area library
Issue details
After all the changes introduced in the last issues that we have completed (removal of JS and Java implementation etc), we need to update the Readme.md file and the docs/name_detection.md.

Another point here should be to add also documentation to devfile.io as this service will be onboarded to devfiles team

Also need to add build instructions

PR opened and ready for review


As a data scientist, I want to get the locations of my customers and stores so that I can make nice maps

This requires adding support for the Mapbox geocoding API to create lat/lon points from addresses. I recommend work on this in the next version.


Rotary input 3.x

This PR adds Rotary input support for wear os devices. It converts RotaryInput to vertical mouse wheel event. Without it Godot does not recognise this event at all. The same feature as implemented in https://github.com/godotengine/godot/pull/88130

You need to target the correct branch


Random seed is not propagated to the exrex package

Hi! I'm using Field to define JSON Schema. The regex randomisation is working, but it would be more useful if the seed would work as well.
Minimal working example:
from pydantic import BaseModel, Field
from pydantic_factories import ModelFactory

class MyModel(BaseModel):
    id: int
    special_id: str = Field(
        title='study',
        description='the study id for the data',
        regex=r'study-[1-9]{3}\.[1-9]{3}'
    )

class MyModelFactory(ModelFactory):
    __model__ = MyModel

ModelFactory.seed_random(1651)

print(MyModelFactory.build())

# id=4 special_id='study-281.776'
# id=4 special_id='study-297.351'
# id=4 special_id='study-249.654'
# ...

Hmm. Fair point. PR is welcome

I am happy to do it, but not yet know why the seed is not working as exrex is using the same random module internally. But I'll figure out and do the PR! :)

Ok, I got it, this package is actually using a separate random instance. In pydantic.utils, ther is random = Random(). I need to figure out what is the rationale behind that.

I did the PR: #40. I haven't find any rationale for the separate Random instance, so I reverted back to the default one. Hope I did not miss something. Also added a test for the pydantic.Field with regex.

v1.2.8 was released, thanks for your contribution @blagasz


A11y_MySQLextensionforAzureDataStudio_NewDatabase_ScreenReader: ORCA Screen reader is not announcing selected or non selected state of list item from the dropdown.

"[Check out Accessibility Insights!] - Identify accessibility bugs before check-in and make bug fixing faster and easier."
#GitHub Tags:
#A11yMAS; #A11ySev2; #A11yTCS; #DesktopApp; #GH_MySQLextensionforAzureDataStudio_Linux_Mar23; #MySQL extension for Azure Data Studio; #WCAG1.3.1; #Linux; #Element:EditField; #ScreenReader; #ORCA;
Actual Result:
ORCA Screen reader is not announcing selected or non selected state of list item from the "Charset" and "Collation" dropdown.
Expected Result:
ORCA Screen reader should announce selected or non selected state of list item from the "Charset" and "Collation" dropdown.
For example we have selected "utf8mb4" list item then screen reader should announce it as "Charset utf8mb4 selected".
Environment Details:
Application Name: MySQL extension for Azure Data Studio
Application Version: 1.42.0-insider
Operating System: Ubuntu 20.04.2 LTS
GNOME Version: 3.36.8
ORCA: 42.2-1ubuntu1
Distributor ID: Ubuntu
Description: Ubuntu 22.10
Release: 22.10
Codename: kinetic
Repro Steps:

Launch Azure Data Studio application.
TAB to "Servers" and select any server from the list and hit ENTER on 'Connect' button.
TAB to connected server and right click on it and TAB to "Manage" and hit ENTER key.
TAB to "New Dashboard" and hit ENTER key.
"New Dashboard" screen gets open. Start the ORCA screen reader.
TAB to "Charset" and "Collation" dropdown and hit ENTER key.
Observe that ORCA Screen reader is not announcing selected or non selected state of list item from the dropdown.

User Impact:
Screen reader users will get confused about the announcement as they might have selected any list item but it is not announcing as selected.
"Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility or the Divisional Driver."
Attachment:
Github issue for selected or non selected state.webm

This issue is external to MySQL extension as it is a common UI of Azure Data Studio.

Hi @PoojaNamde,
I have fixed the bug in attached PR.
You can download the pre-release extension and test it out.
https://github.com/microsoft/azuredatastudio-mysql/releases/download/v0.2.9-alpha.1/azuredatastudio-mysql-0.2.9-alpha.1.vsix
Steps for installing pre-release extension:

Uninstall the MySQL Extension if already installed. (Open ADS -> Extensions -> MySQL -> uninstall -> Restart ADS)
Download the pre-release extension vsix from above link.
Open ADS -> File -> Install Extension via VSIX File -> Select the dowloaded vsix.
Pre release extension will be installed.

Verified this issue in the latest environment
Version: 1.45.0-insider
Commit: 4329d04da3b86689556d4dceab7d9b3d5cde3f58
Date: 2023-05-15T05:30:26.887Z
VS Code: 1.70.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
issue is not fixed as screen reader is not announcing selected or unselected.

Hi @PoojaNamde,
As we discussed, this issue is common for all the dropdowns in Azure Data Studio.
So this is external to mysql extension.
If you dont find any exisiting related bug in azure data studio repo, please add a new issue in azure data studio repo.
Before raising the issue to azuredatastudio, Please also confirm if this is not a issue in other ubunut apps also.

Logged External bug: https://github.com/microsoft/azuredatastudio/issues/23182
As per the External Bug Process - First Party Dependencies assigning the bug to the Product Owner. Please assign this bug back to the tester once the "External" issue has been resolved and changes are pushed to the environment that will be available for bug verification.

#Closed; #Regressed:06-06-23;
Closing this bug as per the discussion with SME.


Fix models after refactor to ConsumerEvent, HttpPushConsumer

#98  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @acco and the rest of your teammates on  Graphite


Aliasing dependencies doesn't affect typescript declaration

In some packages, aliasing dependencies doesn't affect typescript declaration.
For example, https://esm.sh/use-resize-observer<EMAIL_ADDRESS>is expected to use https://cdn.esm.sh/v45/deps=preact<EMAIL_ADDRESS>but actually uses https://cdn.esm.sh/v45/deps=preact@10.5.14/<EMAIL_ADDRESS>

@takker99 thanks I will fix this later！

@ije Can I sponsor (Patreon, Paypal, GH Sponsors, or similar) you in any way to get this fixed?

@lucacasonato i will fix it very soon, no sponsor needed, thanks for your kind!

@ije still seeing this so I'm also wondering if there's any way we can sponsor you for this now.

Thanks for fixing this so quickly!


Getting internal error while trying to add dependency

I cannot add another OTP application as dependency of an OTP application.  Rebar complains while adding dependency project into main project, on various commands:
DEBUG=1 rebar3 tree
===> Verifying dependencies...
===> Fetching dep_proj ({git,
===>    opts: [{use_stdout,false},abort_on_error]

===> Port Cmd: mv /tmp/.tmp_dir148469433397 /home/reith/projects/main_proj/_build/default/lib/dep_proj
Port Opts: [exit_status,{line,16384},use_stdio,stderr_to_stdout,hide,eof]

===> Uncaught error in rebar_core. Run with DEBUG=1 to see stacktrace
===> Uncaught error: {badmatch,not_found}
===> Stack trace to the error location: [{rebar_prv_install_deps,
                                                 update_app_info,2,
                                                 [{file,
                                                   "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_prv_install_deps.erl"},
                                                  {line,367}]},
                                                {rebar_prv_install_deps,
                                                 maybe_fetch,5,
                                                 [{file,
                                                   "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_prv_install_deps.erl"},
                                                  {line,297}]},
                                                {rebar_prv_install_deps,
                                                 update_unseen_dep,9,
                                                 [{file,
                                                   "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_prv_install_deps.erl"},
                                                  {line,241}]},
                                                {lists,foldl,3,
                                                 [{file,"lists.erl"},
                                                  {line,1262}]},
                                                {rebar_prv_install_deps,
                                                 handle_profile_level,6,
                                                 [{file,
                                                   "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_prv_install_deps.erl"},
                                                  {line,154}]},
                                                {rebar_prv_install_deps,do,1,
                                                 [{file,
                                                   "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_prv_install_deps.erl"},
                                                  {line,78}]},
                                                {rebar_core,do,2,
                                                 [{file,
                                                   "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar_core.erl"},
                                                  {line,124}]},
                                                {rebar3,main,1,
                                                 [{file,
                                                   "/home/travis/build/rebar/rebar3/_build/default/lib/rebar/src/rebar3.erl"},
                                                  {line,48}]}]
===> When submitting a bug report, please include the output of `rebar3 report "your command"

Content of rebar.config in main project:
{erl_opts, [
            debug_info,
            {native, o3},
            {parse_transform, lager_transform}
           ]}.

{deps, [
  {dep_proj,
    {git, "file:///home/reith/projects/dep_proj", {branch, "master"}}},
  {lager,
    {git, "git://github.com/basho/lager.git", {branch, "master"}}},
  {common,
    {git, "file:///home/reith/projects/common", {branch, "master"}}}
]}.

{relx, [{release, {'main_proj', "0.0.1"},
         [
          {lager,  "2.1.1",  '>='},
          {dep_proj, "0.1.0",  '>='},
          crypto, 'main_proj'
         ]},

        {sys_config, "./config/sys.config"},
        {vm_args, "./config/vm.args"},

        % {dev_mode, true},
        % {include_erts, false},

        {extended_start_script, true}]
}.

{profiles, [{prod, [{relx, [{dev_mode, false},
                            {include_erts, true}]}]
            }]
}.

And rebar.config in dependency project:
{erl_opts, [
             debug_info,
             {native, o3},
             {parse_transform, lager_transform}
           ]}.

{deps, [
  {common,
    {git, "file:///home/reith/projects/common", {branch, "master"}}},
  {lager,
    {git, "git://github.com/basho/lager.git",          {branch, "master"}}}
]}.

{relx, [{release, {'dep_proj', "0.1.0"},
         [
           {lager,    "2.1.1",  '>='},
           {common, "0.1.0",  '>='},
           crypto, 'dep_proj'
         ]},

        {sys_config, "./config/sys.config"},
        {vm_args, "./config/vm.args"},

        % {dev_mode, true},
        % {include_erts, false},

        {extended_start_script, true}]
}.

{profiles, [{prod, [{relx, [{dev_mode, false},
                            {include_erts, true}]}]
            }]
}.

Cleaning _build directory didn't help.

The problem was my dependency project structured like /dep_proj/apps/dep_proj/{src, include, priv} instead of /dep_proj/{src, include, priv} and It confused rebar3 when processing dependency, though rebar3 can compile or release it when It's standalone.

Right, a dep can be only a single app and thus is assumed to exist in the single app structure. We can certainly improve the error message you got.

An error message for a badly formed dep like this has been added. Reopen if you need.


Allow reconfigure EventSourceMapping after running amplify add function

Is this feature request related to a new or existing Amplify category?
function
Is this related to another service?
No response
Describe the feature you'd like to request
When using Amplify to create a Lambda function with event triggers, it's possible to specify the associated DynamoDB tables during the initial setup. However, there might be scenarios where you need to reconfigure or update the event source mappings to associate the Lambda trigger with different tables. This issue explores how to achieve this reconfiguration.
Describe the solution you'd like
Users should be able to reconfigure the event source mapping for a Lambda function created through Amplify, allowing them to associate the function with different DynamoDB tables. The process for updating the event source mappings after the initial amplify add function command should be documented clearly.
Describe alternatives you've considered
x
Additional context
Where is what the doc says, but you can't "reconfigure" this after the initial setup.

Is this something that you'd be interested in working on?

[X] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

[X] ⚠ This feature might incur a breaking change

Hey @yaquawa, thank you for reaching out. The feature is currently being tracked on https://github.com/aws-amplify/amplify-cli/issues/4038. Please feel free in adding a thumbs up on the issue.
Closing the issue as duplicate.


Getting Error Unsupported: timing control statement in this location, for wait and @(posedge) statements

IDE Version: NVIM v0.10.1
Tools: Neovim with Verible LSP
Additional Plugins: Veridian
Failed
Linting failed with Verible LSP while handling timing control statements like @(posedge clk) and wait.
Expectation
Verible LSP should handle timing control and wait statements without errors in Neovim.
I am getting unsupported timing control statement in this location and Unsupported wait statements. Verible LSP flagged valid SystemVerilog code with errors, specifically regarding timing control constructs.

The text in RED, is that the error message?
I tried a couple of lines in the latest verible language server and I don't get these issues. I'm suspicious that you issue is something to do with Veridian.
What do you get if you run verible-verilog-lint --ruleset=all some_file.sv?

This is what I get when I run the command. Yes, you are correct, the issue is not with verible but with veridian. Once I removed veridian, I no longer encountered those errors.
conv_testbench.sv:2:8-13: Declared module does not match the first dot-delimited component of file name: "conv_testbench" [Style: file-names] [module-filename]
conv_testbench.sv:5:3-11: 'parameter' declarations should only be in the formal parameter list of modules/classes. [Style: constants] [proper-parameter-declaration]
conv_testbench.sv:5:13-21: Explicitly define a storage type for every parameter and localparam, (CLK_PHASE). [Style: constants] [explicit-parameter-storage-type]
conv_testbench.sv:6:3-11: 'parameter' declarations should only be in the formal parameter list of modules/classes. [Style: constants] [proper-parameter-declaration]
conv_testbench.sv:6:13-17: Explicitly define a storage type for every parameter and localparam, (ROUND). [Style: constants] [explicit-parameter-storage-type]
conv_testbench.sv:8:16-27: Signal name does not match the naming convention defined by regex pattern: [a-z_0-9]+ [Style: signal-conventions] [signal-name-style]
conv_testbench.sv:9:16-27: Signal name does not match the naming convention defined by regex pattern: [a-z_0-9]+ [Style: signal-conventions] [signal-name-style]
conv_testbench.sv:10:16-25: Signal name does not match the naming convention defined by regex pattern: [a-z_0-9]+ [Style: signal-conventions] [signal-name-style]
conv_testbench.sv:11:16-26: Signal name does not match the naming convention defined by regex pattern: [a-z_0-9]+ [Style: signal-conventions] [signal-name-style]
conv_testbench.sv:12:16-24: Signal name does not match the naming convention defined by regex pattern: [a-z_0-9]+ [Style: signal-conventions] [signal-name-style]
conv_testbench.sv:13:16-22: Signal name does not match the naming convention defined by regex pattern: [a-z_0-9]+ [Style: signal-conventions] [signal-name-style]
conv_testbench.sv:15:16-28: Signal name does not match the naming convention defined by regex pattern: [a-z_0-9]+ [Style: signal-conventions] [signal-name-style]
conv_testbench.sv:92:5-11: forever block constructs shall explicitly use begin/end. Expected begin, got # [Style: explicit-begin] [explicit-begin]
conv_testbench.sv:92:14-22: Symbol CLK_PHASE is shadowing symbol CLK_PHASE defined at conv_testbench.sv:5:13 [Style: mark-shadowed-instances] [instance-shadowing]

Good to hear you have it sorted.


Unable to create a new task with no parent

I'm trying to create a new task on a submission:

The parent task defaults to a dropdown list that doesn't include a "no parent" option.
One should be able to have no parent when creating a new task.
Let me know if I'm missing something about how this should work. @WrathfulSpatula

@willzeng We have defined 5 top level tasks. This set of 5 cannot be added to, by members. However, if a task had no parent, it would be a top level task, by definition. Does that make sense?

Ah so this would be under Hardware then as a top level?
Maybe would be helpful to make the very top level ones standout in the list
On Fri, Apr 22, 2022, 2:09 PM Daniel Strano @.***>
wrote:

@willzeng https://github.com/willzeng We have defined 5 top level
tasks. This set of 5 cannot be added to, by members. However, if a task had
no parent, it would be a top level task, by definition. Does that make
sense?
—
Reply to this email directly, view it on GitHub
https://github.com/unitaryfund/metriq-app/issues/523#issuecomment-1106746244,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHZDAXKXGQCUPO3DPR3F2LVGLTNXANCNFSM5UCQVYGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

This has come up at least twice, so, I agree, that perhaps we should highlight the top level tasks in the drop-down. We'll track progress in this ticket.

+1 on having top level categories stand out. See also #411.

You might notice, top-level categories already get their own item group, so we can close this, now.


add secure/httponly support for session sticky cookies

add secure/httponly support for session sticky cookies

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.taoxinde seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.taoxinde seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


About the Revolving Test

By changing the order of the images from ['FRONT LEFT', 'FRONT', 'FRONT RIGHT', 'BACK RIGHT', 'BACK', 'BACK LEFT'] to ['BACK LEFT', 'FRONT LEFT', 'FRONT', 'FRONT RIGHT', 'BACK RIGHT', 'BACK'], have the camera's intrinsic and extrinsic parameters been adjusted accordingly? Could you elaborate on the details of this experimental aspect?

Hi, @AlphaPlusTT In revolving test, it is not necessary to modify the intrinsic parameters. Only the camera extrinsics need to be rotated clockwise by 60 degrees. Once the inference process is completed, the predicted bounding box should be rotated counterclockwise by 60 degrees before evaluation.

Thanks for the explanation, is this process similar to BEV's rotation data augmentation?

Yes, it is similar to BEV's rotation data augmentation. The difference is that we rotate the predicted bounding boxes counterclockwise after inference, aligning them with the standard ground truth for evaluation.


How to run hyperparameter tuning with multiple seeds for each configuration?

Unless I'm missing something, hyperparameter tuning just runs each config with a single seed, which makes it difficult to draw conclusions for research due to stochasticity. Is there any way to do tuning with a consistent set of seeds and average results over 3-5 runs?

Is there any way to do tuning with a consistent set of seeds and average results over 3-5 runs?

yes, you need to change the objective function: https://github.com/DLR-RM/rl-baselines3-zoo/blob/master/utils/hyperparams_opt.py#L89
and the callback.
But it is not recommended as it well take much more time.

closing in favor of https://github.com/DLR-RM/rl-baselines3-zoo/issues/151


Coverage

Changes Unknown when pulling 6d3895b2e4e366fec6fcbca3a7d6b41e85ca302e on coverage into ** on master**.

Changes Unknown when pulling 4b77b899eb0cf8d28849f03fa8bdac27abf1dbc6 on coverage into ** on master**.

Changes Unknown when pulling 16a78fb0ffecd386a47ec5227f658d10ea05ad51 on coverage into ** on master**.


merge from template-node-app

.github/workflows/update_package_lock.yml

chore: add Regenerate package lock (jobs.update_package_lock.steps.with.title)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.161%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
54

Relevant Lines:
56

💛  - Coveralls


libssh2 multiple channels concurrent issue

I'm trying to implement a remote port forwarding proxy using async-ssh2. The core idea can be expressed like bellow code:
use async_ssh2::{Channel, Session};
use futures_util::io::AsyncReadExt;
use smol::io::copy;
use smol::Async;
use std::net::SocketAddr;
use std::net::TcpStream;

async fn do_proxy(tcp_conn: Async<TcpStream>, ch: Channel) -> Result<(), anyhow::Error> {
    let (ch_rh, ch_wh) = ch.split();
    let (conn_rh, conn_wh) = tcp_conn.split();
    smol::future::or(copy(ch_rh, conn_wh), copy(conn_rh, ch_wh))
        .await
        .map_err(|e| {
            println!("copy error: {:?}", e.raw_os_error());
        });
    Ok(())
}

Then I find concurrent connections to the remote port cause ssh2 channel read error at the copy point, and "Channel not found" error at the accept point.
After some investigation, I find a mail about the limitation of libssh2 multiple channels concurrent issue: https://www.libssh2.org/mail/libssh2-devel-archive-2014-06/0028.shtml
Maybe I need to ask in that mail thread directly. But before that, I would like to know are there anyone else have tried ssh2-rs remote port forwarding in a concurrent way?

I would say you will find more luck by replying in the email thread and also opening an issue to https://github.com/spebern/async-ssh2 since this error happens when using that library and the async model that comes with it.

Thanks for your suggestion. I have replied in that thread and get confirmation that there's no improvement since then. So it's still broken when using epoll with libssh2.
I indeed created a same issue to async-ssh2 but not get any response yet.
Just wondering how do you guys use this ssh2-rs wrapper? Any other async model work beside async-ssh2?

I am personally using only the sync version, so I cannot really help here :(

Thanks. It seems a cold topic without much attention. I'm working on thrussh to achieve my goal. If anyone have interest in async and pure Rust, I suggest you have a look of thrussh.


cmd/go: "The system cannot find the path specified" error during go get

Hi,
After upgrade to go1.10 I can't download packages. I've tried few of them.
What version of Go are you using (go version)?
PS C:\Users\spock\go\src\github.com\mrspock> go version
go version go1.10.1 windows/amd64
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
PS C:\Users\spock\go\src\github.com\mrspock> go env| Select-String GOHOST

set GOHOSTARCH=amd64
set GOHOSTOS=windows

What did you do?
Example command:
PS C:\Users\spock\go\src\github.com\mrspock> pwd

Path
----
C:\Users\spock\go\src\github.com\mrspock

go get github.com/mrspock/godocsis
package github.com/mrspock/godocsis: mkdir C:\Users\spock\go\src\github.com\mrspock\: The system cannot find the path specified.

I've tried with package where top directory doent' exist. Error is the same.
PS C:\Users\spock\go\src\github.com\mrspock> go get github.com/jrallison/go-workers
package github.com/jrallison/go-workers: mkdir C:\Users\spock\go\src\github.com: The system cannot find the path specified.
PS C:\Users\spock\go\src\github.com\mrspock>

What did you expect to see?
Proper package install
What did you see instead?

Is OneDrive involved in any way>
On 20 April 2018 at 19:45, Marcin Jurczuk<EMAIL_ADDRESS>wrote:

Hi,
After upgrade to go1.10 I can't download packages. I've tried few of them.
What version of Go are you using (go version)?
PS C:\Users\spock\go\src\github.com\mrspock> go version
go version go1.10.1 windows/amd64
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
PS C:\Users\spock\go\src\github.com\mrspock> go env| Select-String GOHOST
set GOHOSTARCH=amd64
set GOHOSTOS=windows
What did you do?
Example command:
PS C:\Users\spock\OneDrive\go\src\github.com\mrspock> pwd
Path
C:\Users\spock\OneDrive\go\src\github.com\mrspock
go get github.com/mrspock/godocsis
package github.com/mrspock/godocsis: mkdir C:\Users\spock\go\src\github.com\mrspock: The system cannot find the path specified.
I've tried with package where top directory doent' exist. Error is the
same.
PS C:\Users\spock\go\src\github.com\mrspock> go get github.com/jrallison/go-workers
package github.com/jrallison/go-workers: mkdir C:\Users\spock\go\src\github.com: The system cannot find the path specified.
PS C:\Users\spock\go\src\github.com\mrspock>
What did you expect to see?
Proper package install
What did you see instead?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/24968, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAcAyz0erzjaQyb6fsUrmqFDEZ8CKyHks5tqa4_gaJpZM4TdLVp
.

Yes.
src is on OneDrive.

What does go env GOPATH print?

Please search the issue tracker for recently closed issues involving one drive. This has been addressed in the last month or so.

On 20 Apr 2018, at 20:32, Marcin Jurczuk<EMAIL_ADDRESS>wrote:
Yes.
src is on OneDrive.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@MrSpock If your problem is same as https://github.com/golang/go/issues/22579, please close this.

Duplicate of #22579


Update chart cert-manager to v1.14.2

This PR contains the following updates:

Package
Update
Change

cert-manager
patch
v1.14.1 -> v1.14.2

Release Notes

cert-manager/cert-manager (cert-manager)
v1.14.2
Compare Source
cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters.
cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions.
ℹ Documentation
Release notes
Upgrade notes
Installation instructions
🔧 Breaking changes
See Breaking changes in v1.14.0 release notes
📜 Changes since v1.14.1
Bug or Regression

BUGFIX: cert-manager CA and SelfSigned issuers incorrectly copied the critical flag from the CSR instead of re-calculating that field themselves. (#6727, @jetstack-bot)
Helm: Fix a bug in the logic that differentiates between 0 and an empty value. (#6729, @jetstack-bot)

Other (Cleanup or Flake)

Bump golang to 1.21.7 (#6735, @jetstack-bot)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Need help using this with webpack

Hello,
I am trying to use theese layouts with webpack, and have webpack build a hbs file to an html file, but experiencing many issues. I am quite new with thiw and with javascript in general, so I might be missing something very stupid.
Here is my webpack config:
// webpack.common.js
const path = require('path');

module.exports = {
  entry: {
    app: './src/js/app.js',
  },
  output: {
    path: path.resolve(__dirname, 'dist'),
    clean: true,
    filename: './js/app.js',
  },
  module: {
    rules: [
      {
        test: /\.css$/,               // Targets all .css files
        include: path.resolve(__dirname, 'src/css'), // Adjust if your CSS files are located elsewhere
        use: [
          'style-loader', // Adds CSS to the DOM by injecting a


What's about nested routes?!

Hi @bertho-zero .
I've been follow this repo for pretty long time and observed many changes recently. having hard time figuring out the new React-router-4. In your routes.js file I cannot find any nested routes although react-router-config.
I want to have a child routes for home like this
const routes = [
  {
    component: App,
    routes: [
      {
        path: '/',
        exact: true,
        component: Home,
        routes: [
          { path: "/pageone", component: PageOne, exact: true},
          { path: "/pagetwo", component: PageTwo, exact: true },
        ]
      },
....
// rest of the router
]

And in Home.js container
import { renderRoutes } from 'react-router-config';
....
render() {
  const { route } = this.props;
  return (

Home

<Link to="/pageone">child Page One</Link>

<Link to="/pagetwo">child Page Two</Link>

      {renderRoutes(route.routes)}

  );
}

Expected Behavior
I want to be able to navigate to page one and page two. and if not match -> go to NOT FOUND. Other routes in your setup must work as normal.
Actual behavior
I can navigate to page one and page 2 (remove the exact: true from the routes to Home above). But if the route is not match, the home page will be display not the NOTFOUND page.
Can you guide me please?

I do not know how to adjust the exact option, I let you test the different possibilities, in my opinion you can remove the exact: true.
I think that Redirect can be useful to you, something like:
import { Redirect } from 'react-router';

const routes = [
  {
    component: App,
    routes: [
      {
        path: '/',
        component: Home,
        routes: [
          { path: "/pageone", component: PageOne },
          { path: "/pagetwo", component: PageTwo },
          { component: () => <Redirect to="/404" /> }
        ]
      },
      // ....
      // rest of the router
    ]
  }
];

(I did not try)

Thanks for your advise. I will give it a try.


Doesn't support React 16.8+

In React 16.3 aliases for the unsafe lifecycles were introduced and now as of React >16.8 we receive warnings each time one of these APIs are used.
Renaming them to their UNSAFE_* counterparts will resolve the warnings.
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

Merged #50 and published as v5.1.4.


MinIO type defintions

Collect differences between MinIO and AWS S3.

x-minio-force-delete

VersioningConfiguration
pub struct VersioningConfiguration {
    ///
Specifies whether MFA delete is enabled in the bucket versioning configuration. This
    /// element is only returned if the bucket has been configured with MFA delete. If the bucket
    /// has never been so configured, this element is not returned.

    pub mfa_delete: Option<MFADelete>,
    ///
The versioning state of the bucket.

    pub status: Option<BucketVersioningStatus>,
}

minio add ExcludedPrefixes,ExcludeFolders fields
type Versioning struct {
	XMLNS   string   `xml:"xmlns,attr,omitempty"`
	XMLName xml.Name `xml:"VersioningConfiguration"`
	// MFADelete State    `xml:"MFADelete,omitempty"` // not supported yet.
	Status State `xml:"Status,omitempty"`
	// MinIO extension - allows selective, prefix-level versioning exclusion.
	// Requires versioning to be enabled
	ExcludedPrefixes []ExcludedPrefix `xml:",omitempty"`
	ExcludeFolders   bool             `xml:",omitempty"`
}

DeleteReplication
https://github.com/minio/minio/blob/68b004a48f418ed9c4363b9faaf61a90d2f6f502/internal/bucket/replication/rule.go#L137-L138


Event handler attribute doesn't add quotes after =

Version: VS 17.9.0 P2
It works for CssClass (type string) both by activating the completion with Enter or simply typing = continuously.
But it doesn't for OnClose (which is an EventCallback). It works by selecting and activating it by Enter from the completion list, but not by typing =.
https://github.com/dotnet/razor/assets/9047283/682710b5-2b13-44d7-b391-4b7501cbf3d8

Fixed


Consider improving failure message of #change matcher by extracting block snippets

Currently failure message of the change matcher with a block is sometimes unclear:
RSpec.describe '#do_something' do
  def do_something
    @foo = true
    @bar = false
  end

  before do
    @foo = false
    @bar = false
  end

  it 'changes @foo and @bar' do
    expect { do_something }.to change { @foo }
                          .and change { @bar }
  end
end

Failures:

  1) #do_something changes @foo and @bar
     Failure/Error:
       expect { do_something }.to change { @foo }
                             .and change { @bar }

       expected result to have changed, but is still false

It's not clear whether the cause is @foo or @bar from the failure message. This is because RSpec does not know the snippets of the blocks and can only express them as result.
However, as we have introduced snippet extraction in https://github.com/rspec/rspec-core/pull/2083, extracting the block snippet may be possible in some situations.
I tried implementing a prototype and it seems to be working well. With the prototype, the above spec is reported as:
Failures:

  1) #do_something changes @foo and @bar
     Failure/Error:
       expect { do_something }.to change { @foo }
                             .and change { @bar }

       expected `@bar` to have changed, but is still false

@rspec/rspec What do you think?

I like this idea @yujinakayama

I like the improved output a lot, but I worry slightly about the difficulty of maintaining the code for this.  I'm not sure I'd be very effective at troubleshooting and fixing bugs in the code that supports this...

but I worry slightly about the difficulty of maintaining the code for this.

Though in some cases extracting the block snippets may be difficult (mainly because of lack of column information in Proc#source_location), we can fallback to the result in that cases since the snippets are provided through failure message, not as a public API.

Good point.  The other thing that worries me is that your prototype relies upon RSpec.world.source_cache from rspec-core.  If we move forward with this we'll have to decide if it makes sense to move the source cache stuff to rspec-support or if the code in rspec-expectations should be written to conditionally do this only if rspec-core is loaded (similar to the color? definition).


Gitrob is not using go modules.

Expected Behavior
gitrob should use go modules to install dependencies.
Actual Behavior
gitrob does not have go.mod nor go.sum to install dependencies using modules.
Specifications

Gitrob version: 2.0.0-beta
Operating system: Arch Linux
Go version: 1.13

@da-edra This is merged and now closed


OpenVPN Stopped working after last update (Juli 27)

My OpenVPN Stopped working after the last system update of Juli 27th, when i try to start the service manually i'll get the following message:
Fatal error: Call to undefined function openvpn_get_settings() in /usr/local/www/status_services.php on line 35
I have disabled OpenVPN for now but would like to see it fixed :)

We are aware, fix here: https://github.com/opnsense/core/commit/3a28b5a36342043e62c666ea9b068a5d6c474e8c
Will be part of 15.7.5 which is being released later today.


improve handling of optional parameters for Index

Checking explicitly for None allows to use types which do not validate to True, e.g. numpy.array.

I was just hit by this one. Definitely worth merging.

Thats great, thanks!


Custom Error Page in UI

EDIT: view the last comment, now the custom error page is in the server code and works in the browser, without Electron.
I was working on a custom error page for replacing the simple "dialog" in Electron code.
Screenshot and video recording of the error page.

https://user-images.githubusercontent.com/27729549/128645058-d64bd35d-c7df-4fdb-8ccc-e2b7cfaec9a9.mp4
(for the last video I added a simple "test();" to server-side socket.io listener for the login)
Pressing the "Open a bug report on Github" button, the webpage comunicates with main.js with IPC that opens TallyArbiter new issue page on Github in browser.
The link contains some parameters, so the new issue is pre-filled with version and logs.
Excerpt from the code let url = `https://github.com/josephdadams/TallyArbiter/issues/new?labels=bug&template=bug.yaml&title=%5BBug%5D%3A+&version=${app.getVersion()}&logs=${encodeURIComponent(logs)}`;

Pretty cool 😃👍👍👍 I think I know where you got the look from ;-)
Just as a litte finish, we could give the scrollbars a more flat apperance: http://webkit-scroll-gen.sourceforge.net/
This could be something for the main UI, too

And what about masking the security and Cloud section in the config file? People could easily leak sensitive information otherwise...

Only thing I would do is trim the security part from the config file. Since we just implemented security features like brute force protection it makes no sense for them to upload their username and password with the config. Especially if it's cloud hosted.

Love this. Could also be great to trap process errors on the server side and offer a similar link via modal pop up if the user is not using electron to view TA but is viewing just in the browser.
Also wondering if we could auto submit an error report asynchronously somehow and store that in a file somewhere and if we see an error occur often, it would be something to act on.

I’m talking about this area:
https://github.com/josephdadams/TallyArbiter/blob/2bca96d041c7a9802029ffe26627d779eba0b83d/index.js#L760
Obviously a new PR, just referencing it here for conversation.

Oh. One other thing. Let's make a config upload section for the bug request form. That way we can get everything at once.

Oh. One other thing. Let's make a config upload section for the bug request form. That way we can get everything at once.

Done. I updated bug.yaml and I added support for new fields in main.js.
New url: https://github.com/josephdadams/TallyArbiter/issues/new?labels=bug&template=bug.yaml&title=%5BBug%5D%3A+&version=${app.getVersion()}&config=${encodeURIComponent(config)}&logs=${encodeURIComponent(logs)}&stacktrace=${encodeURIComponent(err.stack)}

@MatteoGheza feel free to merge this when you are ready

Fixed it for #162
Now it works without Electron.
Now the error page is just an Angular component in the UI, and errors are now reported by the server, and not by Electron.
New features/improvements:

Everything in the UI as a component
Unexpected errors are now saved in a file in the directory ErrorReports as json files with the following schema:
{   datetime: Date;   stacktrace: string;   logs: string;   config: object; } (BTW the id of the error report is just the filename, generated with uuidv4)
When an unexpected error is detected, the server emits a websocket event (server_error)

Thanks to CodeQL, I noticed that the last commit introduces an "high severity security vulnerability", since everything passed to socket event get_error_report is passed to getErrorReport, opened and parsed as JSON.
This leads to Remote File Inclusion (RFI) attacks and to DoS attacks.
I'm fixing it right now.

Sorry, I forgot to add credits to the original Codepen.
Added in the last commit.

Really slick. Great work!

The codeQL thing is pretty cool! I would have never thought about that vulnerability.

@JTF4 I don’t think the error reporting page design needs to be changed at the moment. Hopefully, it will get very little views 😃 because our code is so awesome. And it can always be changed later.

Oh! I meant that as a "I would love to do this in the future" thing. I'm just fine with the current design.

Only one feature remains: Send "server_error" event again if there weren't clients during the error

How about a master Boolean and an interval; if the user answers the error modal it clears the Boolean and the interval, otherwise it pops up again

I read your comment only now. Good idea.
Now I implemented a simple "readed error reports list", so when someone opens the setting page and there are unreaded reports, a popup is shown.

Done! No more TODOs for now!🎉
Waiting for reviews.

Closes #162


Error occurred when executing XlabsSampler: list index out of range

Error occurred when executing XlabsSampler:
list index out of range
File "/root/ComfyUI/execution.py", line 316, in execute
output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "/root/ComfyUI/execution.py", line 191, in get_output_data
return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "/root/ComfyUI/execution.py", line 168, in _map_node_over_list
process_inputs(input_dict, i)
File "/root/ComfyUI/execution.py", line 157, in process_inputs
results.append(getattr(obj, func)(**inputs))
File "/root/ComfyUI/custom_nodes/x-flux-comfyui/nodes.py", line 379, in sampling
x = denoise_controlnet(
File "/root/ComfyUI/custom_nodes/x-flux-comfyui/sampling.py", line 256, in denoise_controlnet
t = timesteps[t_idx]

I hit the same error, was able to resolve by switching to "Empty Latent Image" instead of "EmptySD3LatentImage" which some flux example workflows seem to be using.

一样的问题，正在尝试解决，

找到一个可能解决的办法，不要用vae编码到later，空later尺寸给到1024X1024，似乎可以解决问题，


"Sites to open when the browser starts"

Please identify which version of Edge will support the Admin Template "Sites to open when the browser starts" in Assigned Access (single app) mode.
Intune referred to this setting as "Custom Start pages" under Device Restrictions for 'Microsoft Edge Legacy (Version 45 and earlier)'

Please identify which version of Edge will support the Admin Template "Sites to open when the browser starts" in Assigned Access (single app) mode.
Intune referred to this setting as "Custom Start pages" under Device Restrictions for 'Microsoft Edge Legacy (Version 45 and earlier)'

If this is pointing to Edge Legacy in Intune, this would only support the non-chromium versions of MS Edge, due to the location of the policy. All of the Edge Chromium policies are not located in that policy location.
Can you indicate the full ADMX path of the policy for your inquiry?

It seems my comment isn't properly linked to the "Kiosk Mode" page I intended to comment on. I'm attaching it below.
The Admin Template setting being referenced:
\Microsoft Edge\Startup, home page and new tab page
Action to take on startup = "Enabled" , "Open a List of URLs"
Sites to open when the browser starts = "Enabled", "< URLs >"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 229e4d46-19a6-c042-8ce1-844c44c00112
Version Independent ID: 8ab07629-42a6-e7a1-86a9-f8103825ebc4
Content: Configure Microsoft Edge kiosk mode
Content Source: edgeenterprise/microsoft-edge-configure-kiosk-mode.md
Product: microsoft-edge
GitHub Login: @Aguta
Microsoft Alias: aguta

It seems my comment isn't properly linked to the "Kiosk Mode" page I intended to comment on. I'm attaching it below.
The Admin Template setting being referenced:
\Microsoft Edge\Startup, home page and new tab page
Action to take on startup = "Enabled" , "Open a List of URLs"
Sites to open when the browser starts = "Enabled", "< URLs >"
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 229e4d46-19a6-c042-8ce1-844c44c00112
Version Independent ID: 8ab07629-42a6-e7a1-86a9-f8103825ebc4
Content: Configure Microsoft Edge kiosk mode
Content Source: edgeenterprise/microsoft-edge-configure-kiosk-mode.md
Product: microsoft-edge
GitHub Login: @Aguta
Microsoft Alias: aguta

It looks like the intune policy is referencing the old legacy version, where this kiosk policy is referencing the current Chromium edition. The policy you’re linking calls out v87 or higher. Which is the current release level. Not legacy.

Sorry I'm not being clear, here.
I'm trying to open multiple URLs ("Sites to open when the browser starts") in Edge Chromium.
The documentation doesn't list this particular setting as being available in v89/v90/v91.  (Most other legacy Edge settings in the documentation have a release date for parity.)

Legacy Edge:  "Custom Start Pages" (works OK for Legacy Edge, Win10 Assigned Access Kiosk mode)
Chromium Edge: "Action to take on startup" and "Sites to open when the browser starts" (does NOT work in Chromium Edge, Win10 Assigned Access Kiosk mode)

Please indicate in the documentation which Chromium Edge version will support it.

@rpertusio Hello!  I've reached out to our Kiosk mode team.
Here is there reply/recommendations:
My understanding is that you are trying to open multiple URLs within different tabs for within Edge Kiosk mode Assigned Access Single App.
Are you trying to use the Digital\Interactive Signage (that runs full screen) or Public Browsing (tabbed browsing)?  I would presume this would be under the public browsing, which is a multi-tab experience.
It is possible to open multiple URLs, depending on how you are configuring assigned access:

Via Windows Settings \ Intune: in the field that you can configure the homepage just enumerate the sites you want to configure and separate them by space

For e.g.: site1.com site2.com site3.com

Via PowerShell: you can configure the command line and the same just enumerate the sites you want to configure and separate them by space

msedge.exe --kiosk www.contoso.com www.contoso2.com www.contoso3.com --edge-kiosk-type=public-browsing
Let us know if there are any further questions.  Thanks!

Thank you.  Setting the 'space between' worked.
For the Intune PG team (Intune/Windows)
It would be helpful to specify the 'space' is the method for multiple URLs in Assigned Access Single-app Kiosk mode (w/ Public Browsing). The (i) info bubble (see arrow in my screenshot) would be a great place to put it.
For the Intune or Edge (Kiosk) Documentation team:
For reference, the transition of this functionality from OLD (legacy Edge) and NEW (Edge Chromium) wasn't clear.  Any improvements in documentation to clarify this would help the next person.
OLD vs NEW equivalent:

Thank you.  You can close this issue once you've taken whatever action you deem appropriate (with PG and/or documentation)
-Ryan

Thanks for the feedback! I've passed your suggestions on to the team.  Closing this issue now.


luci-base: form.js: keep config for disabled options

When using "depends" functionality, fields that do not satisfy the constraint are hidden from view, and on save they are removed from the uci configuration. This causes a loss of information previously stored by the user when for example temporarily disabling a certain functionality. Upon reactivation of the said functionality, it is an improved user experience to restore any configuration previously used.
What do you think about this @jow- ? I'm not sure of side effects this change might cause.

I have been thinking about the same "loss of previous config" at disable, as preserving the config details of dependencies of the disabled option might be interesting some times.
(Leaving the not-in-use options there might confuse the user in some cases, though)

This is what the rmempty flag was about, originally, but over the years its meaning was conflated with optional and nowadays it is not easy to untangle without a tree-wide refactoring and retaining backwards compatibility at the same time.
I'd suggest to introduce a new property .retain instead which defaults to false. If an option is found to have unsatisfied dependencies and if .retain is set to true, the value is not removed.
I am against making this the default behavior though since - in conjunction with default values - it'll cause configs to suddenly contain a lot of unused options, confusing users and violating LuCI's design goal of producing the smallest possible config without setting redundant (where value matches the default) or unused options.

The largest negative impact is on complex suboptions depending on the high-level options. E.g. disabling 80211r functionality causes you to lose all 15-20 R0/R1 keys & other config items that depend on 80211r option being enabled.
Would that proposed new .retain need to be separately defined for all the 10-20 different 80211r suboption fields?
Or could that .retain be defined for the top-level 80211r enabled option, meaning that preserve the lower-level suboptions even if this main options is disabled. The dependency would be evaluated in style of "enabled or retain".  Would that work?
(Ps. right now that 80211r is not a huge problem any more, as most 80211r settings can be automately generated)

My proposal would require each individual sub option to be tagged. Since there is no real concept of "sub options" unless you want to apply it to all options of a section or if you consider any option a sub-option that is somehow dependent on a given option. But waling the dependency tree is expensive and complex, I'd rather avoid adding too much logic for this comparatively minor use case.

Closing this as it will not be merged as-is.

Commit f5fbecf132b6c18141896b093935fb4c035ab33d introduced a new retain property for options. You can set it on individual options whose contents should be kept when the options are disabled due to unsatisfied dependencies.
See also http://openwrt.github.io/luci/jsapi/LuCI.form.AbstractValue.html#retain


Compatibilities with different Excel versions

Couldn't find from the readme anything about compatibility in different Excel versions. I have one user reporting an issue "Compile error in hidden module: WebHelpers". The user has an older Windows with Excel 2007.
Then I have another user who uses Office 365. He told me that my template used to work there but is not working anymore. I didn't do any changes to the template while it stopped working, so wondering if Office 365 has changed something that makes the template to fail. It may not relate to this project at all. I was just amazed that the template had worked in Office 365 in the first place.
But can you add a list of supported Excels, or a list of known issues if some Excel version is known to have issues with the project?

Currently, I've only tested on the latest versions of Excel for Windows 10 and Mac. It should theoretically work back pretty far, but there are probably some small issues to fix. Any details on what the compile errors were for Excel 2007?


Fix verify-poll parameter

It's --tx-file, not --signed-tx-file
Checklist
<-- Please fill the boxes with [x] before submitting a pull request -->

[x] I have read the How to Contribute.
[x] I have run yarn build after adding my changes without getting any errors.

Updating documentation or Bugfix

I spot a Nijntje!

correct, it's from the cover of Miffy Learns to Paint (English title); I edited out the paintbrush 🐰

@katomm @os11k @rdlrt getting some traffic from https://forum.cardano.org/t/entering-voltaire-on-chain-poll-for-spos/117330/38 so will have to push this out soon.

I figured out how this error came about... the option was --signed-tx-file in the backport.  I guess since 8.0.0 uses the more canonically named option, and will completely supersede the backport in time, there's no point complicating the instructions by explaining how the backport works differently.  @rdlrt @os11k @fill-the-fill @katomm maybe let me know if you think otherwise & I'll update the instructions for both cases.
$ cardano-cli-8.0.0 governance verify-poll --poll-file poll.json --tx-file vote.signed
Found valid poll answer with 1 signatories
[
    "c94e6fe1123bf111b77b57994bcd836af8ba2b3aa72cfcefbec2d3d4"
]

$ cardano-cli-1.35.7+cip-0094 governance verify-poll --poll-file poll.json --tx-file vote.signed
Invalid option `--tx-file'

Usage: cardano-cli-1.35.7+cip-0094 governance verify-poll --poll-file FILE
            --signed-tx-file FILE

  Verify an answer to a given SPO poll


bug: Expansion of env vars in plugin command args misses meltano.yml env level

Meltano Version
2.11.0
Python Version
3.10
Bug scope
Configuration (settings parsing, validation, etc.)
Operating System
Linux
Description
version: 1
default_environment: dev
project_id: f71334e3-2231-4661-baa5-ddc3aeb9f852
send_anonymous_usage_stats: false
env:
  LEVEL: '2'
  STACK: ${STACK}-2
  CHAIN2: ${CHAIN1}-2
plugins:
  utilities:
  - name: pyjokes
    namespace: pyjokes
    pip_url: pyjokes
    commands:
      joke:
        executable: pyjoke
        args: STACK=${STACK}, CHAIN1=${CHAIN1}, CHAIN2=${CHAIN2}, CHAIN3=${CHAIN3}, CHAIN4=${CHAIN4}, CHAIN5=${CHAIN5}, LEVEL=${LEVEL}
    env:
      LEVEL: '4'
      STACK: ${STACK}-4
      CHAIN4: ${CHAIN3}-4
environments:
- name: dev
  env:
    LEVEL: '3'
    STACK: ${STACK}-3
    CHAIN3: ${CHAIN2}-3
  config:
    plugins:
      utilities:
      - name: pyjokes
        env:
          LEVEL: '5'
          STACK: ${STACK}-5
          CHAIN5: ${CHAIN4}-5
- name: staging
- name: prod

Using the above meltano.yml, we expect the following output from meltano invoke pyjokes:joke:
2022-12-08T20:19:15.638460Z [info     ] Environment 'dev' is active
usage: pyjoke [-h] [-c {neutral,chuck,all,twister}] [-l {en,de,es,gl,eu,it}]
pyjoke: error: unrecognized arguments: STACK=1-2-3-4-5, CHAIN1=1, CHAIN2=1-2, CHAIN3=1-2-3, CHAIN4=1-2-3-4, CHAIN5=1-2-3-4-5, LEVEL=5

Instead we get the following:
2022-12-08T20:19:15.638460Z [info     ] Environment 'dev' is active
usage: pyjoke [-h] [-c {neutral,chuck,all,twister}] [-l {en,de,es,gl,eu,it}]
pyjoke: error: unrecognized arguments: STACK=1-3-4-5, CHAIN1=1, CHAIN2=${CHAIN1}-2, CHAIN3=-2-3, CHAIN4=-2-3-4, CHAIN5=-2-3-4-5, LEVEL=5

Env var expansion in the top-level env field in meltano.yml normally works, as it is used within the env precedence integration test.
I have confirmed that this is not a new issue as of Meltano 2.11.0 - it also affects Meltano 2.10.0, and Meltano 2.9.0. I did not test further.
I am not sure exactly what fields are affected, aside from the args field of plugin commands.
Running with --no-environment does not resolve the issue. We still see CHAIN2=${CHAIN1}-2 in the output.
As with most other env var related issues, I would recommend against prioritizing a fix for this until the Meltano manifest feature has been implemented:

#6876

Code
No response

Similar bug "space" as:

https://github.com/meltano/meltano/issues/7023
https://github.com/meltano/meltano/issues/7034

Still relevant


Replace nl-unit-test with pigweed for credentials

Problem
The problem was described in #29342.
Changes
These changes are another piece of replacing the nl-unit test with the pigweed-unit test. I changed tests for the credentials. I didn't introduce any changes to the logic of tests; I only replaced one framework with another.

@jlatusek it seems we have asan complains:
==25698==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 424 byte(s) in 1 object(s) allocated from:
    #0 0x55aed38e7e5f in malloc ../../../../../../llvm-llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:68:3
    #1 0x55aed3a57120 in chip::Platform::MemoryAlloc(unsigned long) /__w/connectedhomeip/connectedhomeip/out/sanitizers/../../src/lib/support/CHIPMem-Malloc.cpp:96:12
    #2 0x55aed3a6f14f in chip::Credentials::ChipCertificateSet::Init(unsigned char) /__w/connectedhomeip/connectedhomeip/out/sanitizers/../../src/credentials/CHIPCert.cpp:71:54
    #3 0x55aed39e7a8f in (anonymous namespace)::TestFabricTable_TestUpdateNocFailSafe_Test::PigweedTestBody() /__w/connectedhomeip/connectedhomeip/out/sanitizers/../../src/credentials/tests/TestFabricTable.cpp:1933:9
    #4 0x55aed3920d86 in pw::unit_test::internal::Test::PigweedTestRun() /__w/connectedhomeip/connectedhomeip/out/sanitizers/../../third_party/pigweed/repo/pw_unit_test/light_public_overrides/pw_unit_test/framework_backend.h:701:7
    #5 0x55aed392035a in void pw::unit_test::internal::Framework::CreateAndRunTest<(anonymous namespace)::TestFabricTable_TestUpdateNocFailSafe_Test>(pw::unit_test::internal::TestInfo const&) /__w/connectedhomeip/connectedhomeip/out/sanitizers/../../third_party/pigweed/repo/pw_unit_test/light_public_overrides/pw_unit_test/framework_backend.h:487:20
    #6 0x55aed3a687bf in pw::unit_test::internal::TestInfo::run() const /__w/connectedhomeip/connectedhomeip/out/sanitizers/../../third_party/pigweed/repo/pw_unit_test/light_public_overrides/pw_unit_test/framework_backend.h:654:22
    #7 0x55aed3a681e1 in pw::unit_test::internal::Framework::RunAllTests() /__w/connectedhomeip/connectedhomeip/out/sanitizers/../../third_party/pigweed/repo/pw_unit_test/framework_light.cc:63:13
    #8 0x55aed3a55506 in main /__w/connectedhomeip/connectedhomeip/out/sanitizers/../../third_party/pigweed/repo/pw_unit_test/simple_printing_main.cc:33:10
    #9 0x7fa6fcaf5082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082) (BuildId: eebe5d5f4b608b8a53ec446b63981bba373ca0ca)

SUMMARY: AddressSanitizer: 424 byte(s) leaked in 1 allocation(s).


Update text of banner on view page for return Globus users

Existing banner text should be replaced with the following:
Almost there! Just a few more steps. If you need help, visit the [help page|https://docs.google.com/document/d/10b7y3yZCOfyVJ_uP4l7QHbkILQKnfdJi9hj-MpmmdIk/edit?pli=1#heading=h.f2rvtrjiw01].

Look for an email from "Globus Notifications." Click the link in that email under "Use this URL to access the share" and upload your files.
Then return here and click the pencil icon above to edit your draft.
Check the box in the "Add your files" section on the edit page to indicate you have uploaded your files to Globus.
Scroll to the bottom of the form and click "Save as draft" to return later to complete your deposit, or click "Deposit" to complete your deposit now.

Banner should be in orange box with exclamation mark icon on left. This box is currently blue.
Second screenshot under Step 4 at https://projects.invisionapp.com/share/YQ132HXFX2GR#/screens/471628807_Globus_Integ_Enh

Orange: D1660F
Light orange: FEDCB8

We're currently using an "info" alert for the message about next steps. I'm wondering if we could use the existing "warning" alert style for this?
Alternatively, I'll create and style this box without using alerts, in order to get the orange. Just wanted to check in first about this option.

@lwrubel That's okay with me. @astridu does this work for you?

Yes! looks good. Thank you!


Guide to building pipeline components uses inconsistent examples

The guide to building pipeline components pulls its code from various samples. This makes it hard to follow:
https://www.kubeflow.org/docs/pipelines/build-component/
Instead, the guide should pull all its code from one sample, and should link to that sample so people can see the entire thing.

/assign

/close


Mmap are never removed from cache in processes that are only "reading".

Describe the bug
Following discussion with @jannickj.
He ran a reader process that continuously opens a new index, until his process hits a
ENOMEM error when MMapping new files.
It turns out cache eviction only happens on file deletion, ie, only in the writer process.
Which version of tantivy are you using?
0.8.2

I created this simple script to show case the issue:
dependencies
[dependencies]
derive_more = "0.13.0"
tantivy = "0.8.2"

main.rs
use tantivy;
use tantivy::collector;
use tantivy::doc;
use tantivy::query as tquery;
use tantivy::schema;

#[derive(Debug, derive_more::From)]
pub enum Error {
    TanvityError(tantivy::TantivyError),
    SchemaError,
}

pub type Result<T> = std::result::Result<T, Error>;

fn test_writing(index: &tantivy::Index, sch: &schema::Schema) -> Result<()> {
    let mut writer = index.writer(50_000_000)?;
    let test_field = sch.get_field("test").ok_or(Error::SchemaError)?;

    let my_test_msg = "there might be a sad bug here";

    for i in 0..5000 {
        let doc = tantivy::doc!(
            test_field => my_test_msg,
        );
        writer.add_document(doc);
        if i % 200 == 0 {
            eprintln!("written: {}", i);
        }
    }
    writer.commit()?;
    Ok(())
}

fn test_searching(index_path: &str) -> Result<()> {
    loop {
        let index = tantivy::Index::open_in_dir(&index_path)?;
        let sch = index.schema();
        let test_field = sch.get_field("test").ok_or(Error::SchemaError)?;
        let line = "sad";
        let searcher = index.searcher();
        let query = tquery::TermQuery::new(
            tantivy::Term::from_field_text(test_field, line),
            schema::IndexRecordOption::Basic,
        );
        println!("{}", searcher.search(&query, &collector::Count)?);
    }
}

fn main() -> Result<()> {
    let mut args = std::env::args();
    args.next();
    let mode = args.next().unwrap();
    let index_path = ".index";
    println!("{}", mode);
    if mode == "writer" {
        let mut sb = schema::Schema::builder();
        sb.add_text_field("test", schema::TEXT);
        let sch = sb.build();
        let index = tantivy::Index::create_in_dir(&index_path, sch.clone())?;
        loop {
            test_writing(&index, &sch)?;
        }
    } else if mode == "reader" {
        test_searching(&index_path)?;
    }
    Ok(())
}


Show current version on seed-rs.org

I like the way rocket communicates the latest release on the main website (https://rocket.rs):

Latest Release: 0.4.2 (Jun 28, 2019)

Done

@David-OConnor Could you add to RELEASE_CHECKLIST.md that we should update release version and probably changelog in seed-rs.org?

Done and CL updated.


added lvm plugin

This add the lvm plugin support.

@blkperl just noticed your reply. I've updated the README accordingly.

@blkperl just noticed your reply. I've updated the README accordingly.

Thanks @sijis.


Collections Extensions and Admin Sets: Flexible approaches to grouping things in the repository

Collections Extensions and Admin Sets: Flexible approaches to grouping things in the repositoryAn introduction to the Hyrax 2.0 Collections which include collections extensions, once known as Display Sets.  This implementation adds the ability to define collection types with various settings to meet the many use cases for collections from user collections to exhibits.  We'll also look at how these play nicely with Admin Sets.
Suggested by: Lynette Rayle
Presenter: Lynette Rayle
Format: Presentation + Break out if interest
Audience: Devs, Repo Managers

Presenter & Affiliations
E. Lynette Rayle
Cornell University
Title
Collections Extensions and Admin Sets: Flexible approaches to grouping things in the repository
Synopsis
An introduction to the Hyrax 2.1 Collections which include collections extensions, once known as Display Sets.  This implementation adds the ability to define collection types with various settings to meet the many use cases for collections from user collections to exhibits.  We'll also look at how these play nicely with Admin Sets.
Audience
dev
manager


KSP option for single destination invoke() function

Hello, this is rather just a loose idea for improvement, maybe something for 2.0
I think having two equivalent operator fun invoke to navigate to the same destination can be somewhat undesired.
When having navArgsDeletage this is generated:
    override fun invoke(navArgs: SyncScreenNavArgs): Direction = with(navArgs) {
        invoke(title)
    }

    public operator fun invoke(
		title: String,
    ): Direction {
        return Direction(
            route = "$baseRoute" + "/${DestinationsStringNavType.serializeValue("title", title)}"
        )
    }

I've found our team is using almost exclusively navArgsDelegate version because click-through-ability is way better.
If I need to see "who navigates to this screen?" I can just ctrl+clik its arguments, no need to go through generated class.
It still happens once i a while somebody uses the wrong option, would be nice to be able to block that.
It could be done by something like:
ksp {
    arg("compose.destinations.singleInvokeOperator", "true")
}

Which would simply make the basic invoke private, if there's navArgsDelegate used.
Let me know what you think. I can do a PR on it if you see no issues with such approach :)

So you mean not generating this?
public operator fun invoke(
		title: String,
    ): Direction {
        return Direction(
            route = "$baseRoute" + "/${DestinationsStringNavType.serializeValue("title", title)}"
        )
    }

Rather to make it private, if navArgsDeletage is defined.

Hi again, sorry for the big delay 🙏
I accept PRs if you want :)
HINT:
NavArgumentBridgeCodeBuilder#invokeMethodsCode
You can check this config and make the second method private if it is set.
For how configs are handled, check ConfigParser.
And finally you may need to add CodeGenConfig to the constructor of NavArgumentBridgeCodeBuilder to be able to check it.


use AndroidKeyStore for store encryption key

Hi, maybe you have missed it, but currently it is a design choice to NOT include the AndroidKeyStore system (see README.md)

Android Keystore System is not used: In my humble opinion, the Android Keystore is the best possible way to secure data on an Android device. Unfortunately, due to the massive fragmentation in the ecosystem properly handling and using the Android Keystore System is not easy and has some major drawbacks. Due to working in a security relevant field I have a lot of experience with this technology, therefore the decision was made to not support it for this implementation i.e. to keep it simple.

In my past professional project we used (due to my input) the Android Keystore extensively; we had very high security requirements (read EMV payments). Unfortunately due to the often poor implementation or very vague API description it was often hard to navigate through the device bugs, to find a solution that works on most every device (btw. we had minSDK 23, so devices where not too old). That is why I ommited it in this project because I don't feel I can support it well with my limited time (and resources).

i see, thanks

Hey, whats your recommendation?
I am searching something to store my encryption key.
I can't enter the key every time, because i want an automatic sync.

Just turn off user password.

Yes i know its optional, but i want to encrypt the data.
Do you have a alternative for the Android Keystore for automatic systems, like cloud synchronization?

The data is encrypted with the fingerprint (and salts) which is unique for every device although not entirely confidential if you have access to that device. Storing/fetching the key from a backend is hard to do correctly and I'd advice against it - in my opinion its hardly any more secure than using the finterprint -> if you want to strengthen the security add more data to the finterprint like a user id, etc.


[Feature] Address Hannah's feedback

Is it possible to change the language on the welcome screen to read something like: "Welcome to [NAME]! Through a series of interactive games, you'll learn about the presidential candidates' stances on important issues ahead of the election. First, let's get you on board!"

Please edit as needed! I just wanted to avoid telling them about empathy and cooperation since we will want to measure these things using the app. Also, Walter suggested some names for the game -- I'm open to putting whatever you both want here for now and running this question by the group (it's a big decision)!

Did we decide to assign players puzzle pieces rather than let them choose, just so we don't end up with, say, two purples? Another possibility I suppose is to let people choose on a first-come-first-served basis if assigning pieces is too difficult (from a programming perspective). What do you think?

Thank you again, Ting! It's exciting to see it coming together so nicely!

Done with anonymous players with piece name randomly assigned.


Update Logo

Identify a new logo that is more generic and log related and replace existing AVIO logo with it.

@adesjardin is there any guideline for this? I think we can generate one similar (maybe with avio colors) to the current mule logger icon. What do you think?


Typing "=" after attribute name or tag helper property should trigger double quotes autocompletion

This was mensioned several times in different places, but I didn't manage to find separate issue for this.
Start text:
<div class|></div>

where "|" is cursor position.
Then type =.
Expected result:

Quotes are added, cursor is between them, completion list is invoked.
Actual result:

Only completion list is invoked, but no quotes are added.

We think this is a duplicate of https://github.com/dotnet/razor-tooling/issues/4436.


feat: Move common-use crates into hc_common

As part of a general bookkeeping effort, this moves the following common-use crates into the hc_common crate:

hc_command_util
hc_error
hc_filesystem
hc_pathbuf
hc_test_util

Open to suggestions to restructure hc_common with some nested folders inside src, if that makes things more legible code-wise.

Thanks! I think we can start here and then consider a module restructure after that. LGTM!

Ah, looks like there are conflicts preventing a rebase. @mchernicoff think you could resolve them? Happy to do it myself if that's easier.

Hm, looks like it didn't do the Conventional Commits checking in CI, which it should be doing now. So I'll also debug that

@alilleybrinker I can do another rebase.

Taking a look at the updates now!

Okay @mchernicoff looks like it just needs a final review from you since I pushed some minor fixes to the PR branch. Then we're good to merge!


The model claims its creator is Google. You may want to correct it.

Thanks for open source your model. I was following your HF webpage, https://huggingface.co/baichuan-inc/Baichuan2-7B-Chat, and I asked following question:

>>> model.chat(tokenizer, [{"role": "user", "content": "who is your creator?"}])
'I am an artificial intelligence language model developed by Google, which is based on the TensorFlow framework and designed by a team of engineers.'

I am surprised by its output, which should be a mistake. You may want to correct this.