react-native-screens should be an optional dependency instead of peer

As I understand it from react-native-screens documentation and my own experience, it's not actually required for react navigation to work. This means it should be in the optionalDependencies section of the package.json instead of peerDependencies. This'll avoid the following warnings when installing:
warning "react-navigation ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^1.0.0-alpha".
warning "react-navigation ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^1.0.0-alpha".
warning "react-navigation ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^1.0.0-alpha".

Related to https://github.com/react-navigation/drawer/issues/80, https://github.com/react-navigation/tabs/issues/141

You don't need to enable it, but it still needs to be installed for React Navigation to work. This is because we import the module in the code and metro doesn't support optionally importing a module.
So even if it's optional in the sense that you don't need to use it, that's not true in the sense of the package manager and bundler (which optionalDependencies and peerDependencies are intended for). Not installing or failing to install it is going to fail the build.
I'm closing the issue since it's not possible to make it an optional dependency. It needs to be a peer dependency.

Okay, thanks for the additional context. I still think the warning indicates an issue and this should be moved to optionalDependencies or just removed from peer dependencies completely.
Since @react-navigation/native is a peer dependency and has an explicit dependency on react-native-screens, it's not necessary to also include react-native-screens as a peer dependency here, since you're guaranteed for it to be installed if you satisfy the @react-navigation/native peer dependency. (to your "it still needs to be installed for React Navigation to work" point).
If it's removed or moved, the warning won't show up for people who don't directly use react-native-screens.

Why not a normal dependency?


fix the apply method

@williamboxhall The () was missing for apply. The consequence is that when using clump.apply(), you are actually using the Clump's apply and then the Future's apply[1], that is a blocking operation.
[1] https://github.com/twitter/util/blob/master/util-core/src/main/scala/com/twitter/util/Future.scala#L655

Shit! Good spot, :+1:


Design changes to /pleblist/history/

[x] Make already-played songs gray
[x] Strengthen the color of the currently playing song
[x] Add an anchor link at the top which takes you to the currently playing song
[x] Show the current song at the top of the page, since that's usually the most relevant thing.

fixed


How best to implement IPv6?

I've been wanting to poke around with IPv6 multicast for a while, and I've collected some thoughts that might turn into an implementation at some point...
The first thing is that dual-stack sockets aren't really feasible, because OpenBSD disables them for security reasons. The second is that the multicast address is of course different when in the IPv6 space (unless you use the "IPv4 mapped into the IPv6 space" address, but I'm not sure if that's allowed on OpenBSD).
So either we accept all address types and have 2 sockets internally, or just bump the work down to the user and have a MulticastSocketV4 and MulticastSocketV6. I think this is probably best, I've never seen any use for both V4 and V6 at the same time.
Then, the question is whether to have a generic MulticastSocket<T> where T is either Ipv4Addr or Ipv6Addr, or actually split the implementation... somehow. Macros? Just repeat the code and have some helper functions?
I'm not really sure of the best way to do it and would appreciate any input! On a technical level, it seems like both the unix and windows APIs can happily work with ipv6.

I'm personally not much familiar with the IPv6 multicast world. I've designed this library mostly to cover the usecase of IPv4 Broadcast across all interfaces, for things such as MDNS and p2p applications to find each other.
As IPv6 Multicast does not have a broadcast address anymore, I'm unsure what is the usecase for it.
Could you share more about usecases of ipv6 multicast so I can learn more about, and reason around it, please?

I'm also quite unfamiliar with IPv6 multicast, so I hope it's not "blind leading the blind"...
Basically, my main use of this library is connecting to a CAN->Ethernet bridge like this one. It emits and receives packets exclusively over UDP multicast. No broadcast at all! So you basically just add yourself to its multicast group and start receiving packets (and my reason for using this library: from potentially many devices attached to multiple adapters).
IPv4 link local works, kind of, but it's a bit painful. I really like the idea of IPv6 link local, because then you can have a local network setup where a bunch of separate devices can talk to each other without needing static IPs or for someone to act as a DHCP server.


Code change detection - Automatic or manual?

We have two options:
The first option is that the bot saves the code(s) for each issue and detects changes every once in a while (which would take up space and would be inefficient).
The second option is that change detections wouldn't be automatic and people will be able to comment "@MaterializeBot review the code" and it will.
I think that the second option is better.

Im gonna go with manual

auso would be too much work

Why not check the latest comment date instead, and compare when the last check was done?

@fega It'd still be checking each issue, and that would heavily overload github API limits

We can avoid this problem with web scrapping, sorting the issues result by recently updated

Thats a good idea, I'll look into that once I get to that point.

@fega @smileytechguy In that case we could do that and check the errors in MaterializeBot's last comment  instead of saving the whole code and comparing them to the new issues. What do you think?

It's pretty easy just to check errors again. The way I'm doing it currently is using a external tool, and formatting output. What's probably best is to rescan/make a new comment, and edit the old one to say something like "This comment is outdated. Please see the updated version below" or something
But that's still a bit out

working

see https://github.com/smileytechguy/issueTesting/issues/77


iPad App 2.0.0 - Landscape View

After latest update iPad App version 2.0.0 (Build 452), will not display in Landscape mode.
Using iPad Pro (11-inch) model number MTXN2LL/A.
The portrait mode on iPad is inconvenient to use.   Would greatly appreciate if this is fixed in the next App update (or advise me on how to make it display in Landscape view).
Thank you

This is fixed in the latest v2.0.1 release,

Excellent!  Thank you!


owners: change snowp email

Signed-off-by: Snow Pettersen<EMAIL_ADDRESS>

/retest

/azp run

/azp run envoy-linux


chatbox can not use

config my data

get cloudflare url

config chatbox

it does not work

可以了 忘记填 api-key 了


Refactor interface

I have always been dissatisfied with ritsu's API, so I have not released version 0.1.
I plan to remove the high-level API and switch to a low-level (but safe) API so that I can use it in my project as soon as possible.

close by https://github.com/quininer/ritsu/pull/18


Added Topher

Not heart-stopping work, but may be a fun / goofy addition ^__^

@ckk-scratch Yeah, it is funny but not what I'm looking for. Thanks for contributing 👍


Update martech.main.standard.qa.min.js

Adding Alloy.js library in bootstrap file to ease developer to use alloy commands to send events/access ECID.

@Bhim12 can you request to join the milo contributors? https://github.com/orgs/adobecom/teams/milo-contributors
See https://github.com/adobecom/milo/wiki/Roles-and-Responsibilities for more information on milo team setup, otherwise you can also get an invite via #milo-dev
Please also make sure you add your full name to your Github profile, so everyone knows who we are dealing with!

Also one more thing I've noticed, your description could have some love - here's a valuable discussion: https://github.com/orgs/adobecom/discussions/997

What else besides green checks?
PR descriptions should follow the required template. See CONTRIBUTING and Submitting-PRs. Even though the JIRA link is required, don't expect reviewers to dig through the issue. The description on PR should give any reviewer the context necessary. Screenshots are useful.


Throw exception if messages fetched by storm-kafka is emtpy

In kafka ConsumerIterator, there is some codes like this:
// if we just updated the current chunk and it is empty that means the fetch size is too small!       if(currentDataChunk.messages.validBytes == 0)         throw new MessageSizeTooLargeException("Found a message larger than the maximum fetch size of this consumer on topic " +                                                "%s partition %d at fetch offset %d. Increase the fetch size, or decrease the maximum message size the broker will allow."                                                .format(currentDataChunk.topicInfo.topic, currentDataChunk.topicInfo.partitionId, currentDataChunk.fetchOffset))
When "fetch.message.max.bytes" config is smaller than the actual message size in topic, ConsumerIterator will throw an exception to notify user.
But in storm-kafka, there is no such logic. And as a result, if KafkaConfig.fetchSizeBytes is smaller than actual message size, the topology will fetch no data but still be running.
To prevent this situation, we need throw MessageSizeTooLargeException as well.

This would mean spout will get stuck at that particular message and go into infinite worker jvm restarts. Isn't it?

Spout will not get stuck and keep running like nothing goes wrong. Users will not know what happened but their topology just stop processing kafka messages.

 When worker is re-launched again, the jvm will again be killed when spout reaches the faulty offset. This behavior may not be desired for many users who don't want to stall the worker because of one large message. Can you instead log an Error, ignore the message and proceed further?
Also I didn't fully understand the side effect of not throwing an exception. what do you mean by "topology will fetch no data but still be running"? Will it stop fetching data at all?

Can you instead log an Error, ignore the message and proceed further?

This means data loss to users. I am not sure data loss is acceptable or not. As I mentioned above, ConsumerIterator choose to throw an exception (MessageTooLargeException, which will cause Kafka Consumer to stop working), so I think maybe it is a good way.

what do you mean by "topology will fetch no data but still be running"? Will it stop fetching data at all?

The spout will keep trying to fetch data, but the response from Kafka contains no valid bytes because of size limit. The side effect of this is that the data in Kafka topic will pile up while user doesn't know why there storm topology stop processing messages (there is no data to process).
I think you are right that many users don't want to stall the worker because of one large message, but this a result of incorrect config (KafkaConfig.fetchSizeBytes) and if they want to avoid this situation, they need to set a really large size limit at the first time.

@abhishekagarwal87 and @victor-wong
I am on the fence on this.  Having a spout that is stuck forever is really bad, but having it crash, lose data, come back up and repeat the process possibly draining the other partitions feels even worse.  I guess if you configured your spouts for at most once processing then you got what you asked for, even if it was shoot yourself in the foot, and storm is fail fast so it fits with that philosophy.
Please at least update the exception message to indicate what the sizes are actually set to.  I think this would make life simpler for the user that is in this situation, so they see the error message and it says something like.
Found a message (10,485,760 bytes) that is larger than the maximum fetch size (1,048,576 bytes) in topic myGreatTopic partition 5 at fetch offset 103404502. Increase the fetch size, or decrease the maximum message size the broker will allow and start after this offset."
Another alternative might be to give the user the option to skip messages that are too large, and provide a metric to indicate how many messages/bytes have been skipped because of this.

Found a message (10,485,760 bytes) ...

It seems we can not get the actual size of the message.
I have made some updates according to your advice.

Add an option "KafkaConfig.skipMsgOverFetchSize" to determine how to handle a large message, default is to skip this message and continue processing.
Move handling logic out of KafkaUtils. Instead handle it in PartitionManager (non-trident) and TridentKafkaEmitter (trident).

I made some changes, what about logging a warn message instead?
why 'The travis CI build failed' happened? It says storm-core test failed, but I made no changes of storm-core.
@abhishekagarwal87


train ConvolutionModel  model,it seems failed

when i train CNN model,it epochs 2 twice ,the loss value became nan. it seems getting in local minmize.

I've ported the CNN-LSTM model implemented here, on PyTorch and my loss also becomes 0.0 for the second, third and fourth epochs and then rises again. Is it a Learning Rate issue.


Add easy pick label

Can someone add an easypick label similar to the one in JIRA ?

Great thanks :)


Improve troubleshooting/docs for gfycat integration

Currently we have zero troubleshooting for the gfycat integration.
99% of cases the gif preview is not working because admins don't know that the images from gfycat in chat (unlike the preview in the emoji picker) is being loaded through the Mattermost server.
We should add a section that has the following info included:
What to do if gifs are not loading even though they show up in the emoji picker

check if the server has access to the gfycat servers if it's behind a proxy or firewall blocking outgoing connections.
check if the server reaches the link metadata timeout (see system console -> experimental -> link metadata timeout)

Hey, @svelle! Would you be open to updating the docs to reflect this new content? It seems like it'd fit well into the Configuration > Integrations section of the Troubleshooting guide?

Yeah sounds like a good idea. I'll add it later today. Thanks for looking that up :)

Thank you for helping out, much appreciated!


[ACR] Use autorest.md transform to remove securityDefinitions from swagger

Fixes https://github.com/Azure/azure-sdk-for-net/issues/34606

API change check
API changes are not detected in this pull request.


Readme updates regarding cron and settings change

For the bounty.

Would you be able to re-work this into instructions in a list-format to match the installation?

Closed due to lack of activity.


Add yubikey tools

[ ] https://github.com/Yubico/yubikey-manager
[ ] https://github.com/Yubico/yubico-piv-tool

See #5230


Improve karma & webpack test workflow

Karma tests are run & debugged against dist/tmb.js. That means putting the breakpoints in dist, but editing in src (ouch!), and building again before testing.
Explore karma-webpack plugins that make this workflow easier (ie less error prone).

But - how to debug using webpack???
Breakpoints are ignored!


Create, List, Edit & Delete Namespaces

Tagging dependent backend issue #897

After discussions it seems there won't be much additional information required when creating a namespace for the forseable future, so the create experience should be moved to a modal.
@catherineluse This should be straight forward

Create a new modal with the contents of the existing one. This will need to support error handling and validation as before
Investigate if it's possible to replace the current way to reach the 'create' process (generic button in generic list) with a way to show the prompt instead. I'm not sure this is possible though. The alternative is replacing the Namespace list with a custom one... where we add our own 'Create' button to the masthead which shows the pop up. Lets chat before you start


Windows executables do not have the needed metadata embeded as part of the build

Applies to all releases

as per the above image, I would expect that this metadata is embedded in the executable so that I could determine from it what version is being run without needing to run it & as such is a security concern that this information is missing from the build

@bep this is something that many sysadmins, whether windows or not would expect to be able to inspect and whilst it's possible to get this from hugo version it should also be embedded in the metadata of the executable too, at least on windows, though I also would expect others would also like to inspect this metadata without having to actually ever run the executable either, irrespective of what platform it is running on.
So could I ask that this be looked into and added in a near future release please as it is a security concern that it isn't already there. I think it's less a case of actively missing this out and just not being aware of it that's all, hence this issue.

Yea, we should fix this.
This tools look solid:

https://github.com/josephspurrier/goversioninfo
We need to integrate that into our build process; if we add resource.syso to the tagged version then external tools building for Windows should also get the metadata included in their binaries.


Fails to parse usages of metaclass

I tried to use the tensorflow update script on a codebase that uses abstract classes with ABCMeta. Parsing failed with
AnnotationError: Expected ':' but found 'metaclass'

Minimal example:
pasta.parse('class A(metaclass=X): pass')

This is some missing support for python3 syntax-- I'll add it. Thanks for the report and example!

Fixed at HEAD, I'll create a new version soon. Thanks again!

Wow, that was fast. Thank you!


Makefile addition

fix for issue  #106

done the suggested change

closing the pull request according to suggestion of @rjsadow


Resources are encrypted locally or resources are loaded from memory or resources are packaged into a single file

Problem to solve
Mainly to prevent game resources from being pirated. Possible solutions I'm thinking of
1 The assets directory is encrypted and can be decrypted and read through the flame api.
2 Resources are directly encoded in the code as binary arrays
3 Merge resources into a single independent encrypted file
Proposal
Game Resource Encryption Assistant
More information
No response
Other

[ ] Are you interested in working on a PR for this?

Right now, Flame does not do any asset packing/encryption on its own. It depends on Flutter build to do that. But I agree that stealing game assets from desktop builds is much easier as of now.
Something like rres can be potentially used to package the data better.

It may be possible to manage resources through a single encrypted zip file. Some extension classes need to be written.


Update edit details in UG

Edit example for edit command to match the sample data
Explicitly states that INDEX in edit command must be a positive integer

Codecov Report
Base: 70.17% // Head: 70.17% // No change to project coverage :thumbsup:

Coverage data is based on head (7a2c94c) compared to base (93acbd1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #178   +/-   ##
=========================================
  Coverage     70.17%   70.17%
  Complexity      641      641
=========================================
  Files           100      100
  Lines          2012     2012
  Branches        221      221
=========================================
  Hits           1412     1412
  Misses          531      531
  Partials         69       69

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update error handling

https://github.com/OSGeo/PROJ/pull/2487
This will be a breaking change. Previous behavior is deprecated.
As of PROJ 8.0.0, this function is deprecated as potentially thread-unsafe.  Users should use `proj_context_errno_string` instead.

This will be a breaking change

What exactly do you see as deprecated (apart proj_errno_string()) ?

I should clarify that it will be a change that will break things in the future and pyproj should make changes now to be ready for it.


fix: fft domain precompute thread safety

Missed that in my review of #45 .
The pattern
BitReverse(domain.CosetTableInv[coset-1])
// ...  scale by coset
BitReverse(domain.CosetTableInv[coset-1])

is not thread safe, and quite wasteful.
Replaced by dynamically computing the correct index in the coset table:
parallel.Execute(len(a), func(start, end int) {
	for i := start; i < end; i++ {
		irev := bits.Reverse64(uint64(i)) >> nn
		a[i].Mul(&a[i], &domain.CosetTable[coset-1][int(irev)])
	}
})

Benchmark:
BenchmarkFFT/fft_2**19bits_(cosets_without_precomputations)-8     63984013      43923680      -31.35%

Also did few style adjustment with less if -> if -> else -> if statements.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: gbotrel:white_check_mark: yelhousni:x: ThomasPiellardYou have signed the CLA already but the status is still pending? Let us recheck it.


"Detailed Lines Description" setup not self explanatory

Please add a section explaining the field "Detailed Lines Description" in the finance charge terms. That that one is only used if multiple interest rates are setup in order to put a sum to the additional created finance charge lines. It is not explained in the tooltip. The tooltip is basically copied from the Line Description one.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 00c53c6c-611f-4167-9c00-7f1c3d8bf62d
Version Independent ID: a1c00cab-64fb-2443-5c35-cf989e0f02e1
Content: Remind or Fine Customers of Overdue Payments - Business Central
Content Source: business-central/receivables-collect-outstanding-balances.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Thanks for the feedback. The tooltip will be fixed in a future update soon.


Explore Nginx Comptability on Docker Network

Currently, Nginx, Cloud Docker, and Request docker not compatible with DNS (Docker hostname) redirects even when on docker network.

This is now operational after using internal docker ports.


Recommendation: Never declare fractional absolute lengths

I recommend using whole numbers when declaring absolute lengths, like px, em, rem, (cm, etc.). Not all browsers round or alias fractional pixel lengths the same, and there is no spec guidance on the matter. Subpixel sizing is especially problematic for text sizes.
http://www.unumux.com/ux-insights/2016/2/24/subpixel-troubleshooting
Browser APIs inconsistently support returning floated numbers or integers (an unrelated example off the top of my head is innerWidth, I believe). I recommend avoiding fractional absolute lengths, especially for font-size.
This is, of course, knowing and accepting that fractional lengths naturally occur (as the exception) when using %.
Thoughts?

I think for pixels we could probably do this. Most likely we'd develop some rounding mixin in Sass, esp for column widths (related: #742). We only really use pixels in a handful of places (mostly the grid), so it wouldn't be that much dev time to go through and iron these out. The grid is sort of difficult, though, because if you round down, columns inside might not fit anymore, so this might actually just cause more bugs, not sure. I think we'd just have to go in and branch and see.
We very infrequently use em, cm, so not a lot to worry about there.
Using whole rem values is completely unworkable as a solution. The jump from 1rem to 2rem is  massive. Is that what you're advocating? No decimals on rem values at all? Maybe I don't understand what we're going for on this front.
Just something to consider, using rems for most padding/spacing allows us to do things like change the base font size for mobile (and all the patterns instantly become slightly more compact). We could reverse-engineer our rems based on whole pixel values, or go through and update all of the patterns padding and spacing at all of the breakpoints, but this is a lot of work.

But it may only show up once in a blue moon in the form of some small, very difficult to diagnose, browser-specific bugs

This from the article you linked to made me think a bit. Is it worth rearchitecting the entire framework and rewriting all of the styles, and making lots of breaking changes just to fix rare, hypothetical browser-specific bugs (esp now that we are IE11+)?

Ah, I didn’t mean to say 1rem, 2rem, 3rem. I mean computed absolute values, so px.

I see, so it would just be a matter of looking at the computed styles and then figuring out which rem values produced even pixels?

Also, while the article might talk about older browsers, I think that just makes it easy to dismiss. These issues still exist in Edge and Safari. Subpixel aliasing is not exact science. It’s why I pulled innerWidth out of memory. One could also dismiss my arguments because fonts will still look different in different OS’s due to how they handle aliasing in general. I think the philosophy of standing with whole numbers for computed values is about establishing consistency at a reasonable level.
My arguments can totally be dismissed for many reasons, but I would hate to see them dismissed because they also happened to apply to browsers we don’t care about. I just do a horrible job making a case for anything.

In next release all media queries, column widths, etc will be even pixel values. Type sizes are now based off 16px so almost all of them are also even pixels now.


Graphical glitch with the details panel

There seems to be graphical glitch in the newest release (0.22) when making the details panel bigger or smaller

Hey @SViN24! Thanks for the report, and I appreciate the GIF. I've seen that behavior as well and I believe it's something in wxWidgets. I'll see what I can do to remedy it.


Duplicated keys in getAllRecords

use of the $type + classname is creating duplicate entries,
cause by line 441 in zone.php
This happens for each record type.
the symptom:
Array
(
    [CNAME] => Array
        (
        )

    [Dyn\TrafficManagement\Record\CNAME] => Array
        (
            [0] => Dyn\TrafficManagement\Record\CNAME Object
                (
                    [type:protected] => CNAME
                    [cname:protected] => asdfsdfa.com.
                    [id:protected] => 150588609
                    [fqdn:protected] => asdfsadf.whole_rest.nl
                    [ttl:protected] => 3600
                    [rdata:protected] =>
                )

Thanks for reporting this, it should just be using the record type as the key (in this case CNAME). This is fixed in version 0.5.0.


[openvino] fix osx build

Uses the upstream patch https://github.com/openvinotoolkit/openvino/pull/19946

@autoantwort Thanks for the fix!
@ilya-lavrenov Thanks for the review!


SCSS Version.

This might help:
https://www.npmjs.com/package/sass-convert

Ya this seams like a good option.


Refactor bump release plugin

Various simplifications in preparation for the Tekton changes (which will not be part of this PR).
This should preserve exactly the same functionality as before.
Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

Updated label check to handle component and version consistently


Bug when trying to login

Hello all,
We are still using the latest versions of onyxia web and api, and in the last few weeks we've been unable to login into onyxia, even if we did not change any configurations. After pressing the login button, the page never loads and in the console, the following message appears:
assert.ts:8 Uncaught (in promise) Error: Wrong assertion encountered: "There is no specific keycloak config for Vault and no keycloak config to fallback to"

Any help would be greatly appreciated.

Yep, that was the issue, thanks.


Use the Authentication overlay for odh-dashboard

This points our kfdef at the Authentication overlay for the ODH
Dashboard, which will configure it with an OAuth proxy to authenticate
and authorize users.

LGTM. This was the same overlay I enabled when testing dashboard authentication for ODH upstream

Hmm, it looks like the red-hat-data-services/odh-manifests repo does not have this overlay yet.....which brings up some other process-related questions about things going forward.

I've merged the requisite manifest changes and am currently testing this out locally.

This is working for me.  I think I saw the Login with OpenShift intermediate page, but that would be unrelated to this PR (would be a manifest change).


Show response declarations in comments above request method

PR: https://github.com/acacode/swagger-typescript-api/pull/17

Added by CLI flag (-r, --responses) in release 1.4.0


Purge cache is not working

Hi, the method to purge the cache is not working since a few weeks. I'm currently using the method
Zones::cachePurge() but it doesn't seem to work properly.
But checking the Cloudflare API v4 and the code, I notice that the Cloudflare API requires a POST method but this library is using DELETE. So I'm proposing a fix.

Please help to close this issue @IcyApril

My bad, I thought that the issue has been closed automatically when the merge was done.


Disable SSE4.2 functions (breaks on App Engine, possibly other platforms)

Having this unused code makes App Engine compiles fail, since it cannot  find the "func haveSSE42() bool"/scanStringSSE function.
So let's remove them until we need them.

I'd prefer to find the right build flags for app engine so that its not attempted to build, rather removing it, keeping it there is a constant reminder to do the work for me :)

I think // +build !appengine should make it not build?

There you go :)


remove code being used in violation of the license

This code is being distributed by Calyx in violation of the license. Any further usage of this code by Calyx is not permitted as it was not used under the terms offered by the license. The license is revoked. You aren't welcome to use any of your changes due to your continued raids on our community, misinformation spread about the project and harassment of our developers.

Legal action will be taken if you do not drop all code derived from GrapheneOS that has been distributed in violation of the licenses as is the case with this code. We're in contact with a journalist about how CalyxOS has repeatedly taken our code without complying with the attribution required by the licenses, while actively attacking and undermining our project.
This is not the most egregious case since you did follow the license in this repository, but not in your redistributions of this code in other repositories or as part of your Chromium builds and OS. In other repositories, you've taken our code and entirely stripped the attribution in the source repositories in addition to not complying with the license for the OS releases. DMCA takedowns will be sent for both GitHub and GitLab for all relevant repositories over the next few weeks. We'll also be publishing information on what has been happening.
You use our code as a reference and repeatedly take our changes while acting maliciously towards us and do not credit us for the stolen work.


feat(Connection): Enable timeout to wait for commands

Fixes #2473

I signed it!

@JoelEinbinder can you please code review this?

@regevbr I'm not sure I follow: why does websocket hang for you?
WebSocket should never hang, but this PR makes it look like this kind of behavior is legitimate, even exposing an API bit to control it.

@aslushnikov I don't know why it hangs and it is very hard to investigate it but the fact of the matter is that it happens, and once I started using my forked version, it stopped happening...
Also, I'm not syaing that the web socket is hanging, im saying that after you send a message, the response never comes back, causing the promise to never be settled...

I don't know why it hangs and it is very hard to investigate it but the fact of the matter is that it happens, and once I started using my forked version, it stopped happening...
Also, I'm not syaing that the web socket is hanging, im saying that after you send a message, the response never comes back, causing the promise to never be settled...

I see, thanks for the response.
This approach is a no-go for us: it hides the problem rather then fixes it. It could also be a problem in your environment.
Let's continue the discussion in the bug.

@aslushnikov The issue seems to come from the chromium side and not from this library... How do you suggest handling non responsive tabs?

@regevbr I'd start with buliding a reliable repro case and then recording a trace.


chore: custom struct for deleted deployment

Description
DeletedDeployments is used as a naked type of expiring cache. It alsos stores boolean (always true). In this PR I've changed it store an empty struct to reduce used memory and exposed a smaller interface.

[x] CHANGELOG update is not needed
[x] Documentation is not needed

Testing

[x] inspected CI results

Automated testing

[x] modified existing tests
[x] contributed no automated tests

How I validated my change
CI

@0x656b694d PTAL


Investigate making deletion of related skill events async

Investigate making the deletion of skill related skill events async when deleting a skill event from a skill that has been exported to the catalog (see SkillEventAdminService.deleteSkillEvent)

obe


(PDB-1292) docs sweep

This patch updates and expands on a number of our documentation examples, and
corrects various inaccuracies I came across.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1515/

Overall looks good.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1536/


[Doc Improvement][Broken link update for sample]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/teams-conversational-ai/how-conversation-ai-get-started.md
90
70
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


[typo] fix a typo.

Motivation
Cleanup after myself
Have you read the [Contributing Guidelines on pull requests]
Yes
Test Plan
Spellcheck
Related PRs
None
If targetting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Why we must have it for V1 launch.
What workarounds and alternative we have if we do not push the PR.

/priority low

/land


Feature request: order on VertexQuery

Hi,
I would like a feature like .order(String key) and .orderDesc(String key) on VertexQuery or GraphQuery.
Is there a reason why it is missing? Or, is it just not yet implemented?
Thanks

We will not be changing the Blueprints API as the 2.x line of code is basically in maintenance mode as we are full speed ahead on TinkerPop3:
http://www.tinkerpop.com/docs/3.0.0-SNAPSHOT/
I suspect this issue is resolved by the API changes there:
http://www.tinkerpop.com/docs/3.0.0-SNAPSHOT/#order-step

Perfect, I wait for the version 3.0.
Thanks.


can't interact with way midpoints

Update: midpoints were turned off temporarily while we attend FOSS4G.

I confirm the issue is still there and it makes it impossible to modify existing geometries (and also refine new ones).

Fixed in 400aa6612.
There are still some places where the midpoints aren't being rendered correctly- will open a separate bug for that. The midpoint dragging behavior is restored at least! proof:


Switch scrolling detect level of PagerController.scrollView

I want to change viewController after scrolling new page completely.
To do this action, you should switch PageController.scrollType to .Edge.
It is first time for me to create pull request to other project.
If there is any bad point, please point out!
thank you.

Thanks for PR, @kawasin73 .
It would be that to synchronize pages and menus than after scrolling to a new page completely.


ListView shows a blank line in IOS(iphone xs)

It'e will have a blank line in IOS when i use the ListView widget, but it won't happen in Android.
The red box in the picture below is that blank line, anyone knows how to solve it? ths~

Hi @chendanping, could you please share minimal runnable sample code with the issue? Thank you!

Hi @chendanping, could you please share minimal runnable sample code with the issue? Thank you!

Hi, the following is the code:
ListView.builder(
shrinkWrap: true,
itemCount: itemList.length,
physics: NeverScrollableScrollPhysics(),
itemBuilder: (BuildContext context, int index) {
return SafeArea(
child: Column(
children: [
Container(
padding: EdgeInsets.all(17.0),
child: Flex(
mainAxisSize: MainAxisSize.max,
crossAxisAlignment: CrossAxisAlignment.center,
mainAxisAlignment: MainAxisAlignment.spaceBetween,
direction: Axis.horizontal,
children: [
Flexible(
fit: FlexFit.tight,
child: Text(
itemList[index].itemKey,
style: TextStyle(
color: COLOR_GRAY_TEXT,
),
),
),
Flexible(
fit: FlexFit.loose,
child: Text(
itemList[index].itemValue,
textAlign: TextAlign.right,
),
)
],
),
),
Divider(height: 1.0),
],
),
);
},
)

Hi, I met the same problem. Have you solved this problem?@chendanping

Hi @chendanping ,
Is it still an issue?
I can't reproduce it with flutter master v1.15.20 and iOS 11.0 or 13.3 simulators

I hope it's fixed.
Could everyone who still has this problem please file a new issue with complete minimal reproducible code sample and the output of flutter doctor -v please.


Get open source approval for the latest libraries

The following libraries were approved: Pathkit, Zewo Websocket, and Redbird


Post release automated changes for core releases

Post release automated changes for azure-core-paging

/check-enforcer override


RichTextLabel: allow 'scroll_to_line' when scroll_active is 'false'

Fixes #36134.
That functionally actually worked previously, but was broken due to fixing other issue: #32964
With my PR both of those stories are satisfied:)

Thanks!

Cherry-picked for 3.2.2.


Add some additional config options to remoteTrigger

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Hey Andrew, thanks for the contribution!


is there a way to eliminate the outline and only keep the glow?

Not really. The outline serves as an emissive 'mask' for the bloom post-processing. In theory, I think it's possible to implement a custom image effect, which will get the info from somewhere else (stencil, maybe), but that's out of the scope of the current solution.


Border 2px to 0px on Success, Alert, Secondary

Reference: https://github.com/zurb/foundation-emails/issues/395

Great PR! Thanks for jumping in @iamsankalp !


License is missing

Greetings Chen Yufei!
Could you please share the license you used for your code? I would like to use it in a commercial project, but could not find the license. Are you okay with this?

Thanks for your interest, just added MIT license.


Exclude tests from coverage reporting

Fixes #132

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.36%. Comparing base (56aece9) to head (45a3a2a).
Report is 3 commits behind head on main.

:exclamation:  There is a different number of reports uploaded between BASE (56aece9) and HEAD (45a3a2a). Click for more details.
HEAD has 15 uploads less than BASE

Flag
BASE (56aece9)
HEAD (45a3a2a)

16
1

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #135       +/-   ##
===========================================
- Coverage   49.60%   33.36%   -16.24%
===========================================
  Files          59       39       -20
  Lines        7681     5805     -1876
  Branches     1647     1284      -363
===========================================
- Hits         3810     1937     -1873
- Misses       3807     3811        +4
+ Partials       64       57        -7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add thin black outline?

Can we add a thin black outline to improve image quality?
viewer.setViewStyle({style:"outline",color:"black", width:0.1});
See the 3DMol.js poster from the ACS meeting:
http://bits.csb.pitt.edu/files/3Dmol_ACS2016.pdf

Is this what you're looking for?

Something like that, but perhaps thinner (e.g., 1/3 the thickness)? I'm wondering if it's possible to basically add a thin black trace. If that was 0.1, maybe 0.03 or something.
And perhaps we should only do it for the surface - the molecule itself looks pretty good without it.
I'm just thinking this will help with the white-on-white look between the molecule surface and the site background.

I think that with 0.01 outline width, the outline looks great on both the surface and molecule! Thoughts?

Yes, looks great.

Closing with 646676ad1341f3c8da1928d394c511646af86754


add sentence piece IS loading option

Description
Add SP InputStream loading option

Codecov Report

Merging #1949 (1288411) into master (bb5073f) will decrease coverage by 2.10%.
The diff coverage is 67.25%.

:exclamation: Current head 1288411 differs from pull request most recent head e2e996b. Consider uploading reports for the commit e2e996b to get more accurate results

@@             Coverage Diff              @@
##             master    #1949      +/-   ##
============================================
- Coverage     72.08%   69.97%   -2.11%
- Complexity     5126     5710     +584
============================================
  Files           473      544      +71
  Lines         21970    25193    +3223
  Branches       2351     2734     +383
============================================
+ Hits          15838    17630    +1792
- Misses         4925     6222    +1297
- Partials       1207     1341     +134

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <0.00%> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <0.00%> (-5.24%)
:arrow_down:

...odality/cv/translator/BigGANTranslatorFactory.java
33.33% <0.00%> (+8.33%)
:arrow_up:

...nslator/InstanceSegmentationTranslatorFactory.java
14.28% <0.00%> (-3.90%)
:arrow_down:

.../cv/translator/SemanticSegmentationTranslator.java
0.00% <0.00%> (ø)

.../cv/translator/StyleTransferTranslatorFactory.java
40.00% <ø> (ø)

... and 445 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Edit dev install docs and add troubleshooting tips

Closes #732
@SylvainCorlay @fperez

thanks @willingc! BTW, I just realized the triple-backticks weren't really needed b/c you'd already indented the source, which makes markdown render it as code. Sorry about that :)
Let's see if @SylvainCorlay has a chance to give it a once-over, since he's much more familiar with the process than me.
Otherwise I'm +1 on merging this, thanks!!

Fantastic!  Thanks @willingc

👍


Fix typos in README: 'card' to 'cart' and 'emai' to 'email'

Coverage remained the same at 100.0% when pulling 8f1d2b251fb2041efd77aca82375e850abc8d063 on johnwheeler:johnwheeler-patch-1-1 into a353cd0fd756164343a23600bcc0a8856c81dc7e on Accenture:master.


p

Closing this issue because @lladynski didn't provide any relevant details. Please reopen and edit the original post with details regarding the issue you are facing,.
Thank you.


pcre2 build failure

Operating system
Mac Ventura
Compiler
Xcode clang
Steps to reproduce the behavior
./vcpkg install pcre2

Failure logs
Computing installation plan...
The following packages will be built and installed:
pcre2[core]:arm64-osx -> 10.40#1
Detecting compiler hash for triplet arm64-osx...
Restored 0 package(s) from /Users/michalpospieszalski/.cache/vcpkg/archives in 536.1 us. Use --debug to see more details.
Installing 1/1 pcre2:arm64-osx...
Building pcre2[core]:arm64-osx...
-- Using cached PCRE2Project-pcre2-pcre2-10.40.tar.gz.
-- Cleaning sources at /Users/michalpospieszalski/src/matterfi/vcpkg/buildtrees/pcre2/src/cre2-10.40-42fc341438.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /Users/michalpospieszalski/src/matterfi/vcpkg/downloads/PCRE2Project-pcre2-pcre2-10.40.tar.gz
-- Applying patch pcre2-10.35_fix-uwp.patch
-- Applying patch no-static-suffix.patch
-- Using source at /Users/michalpospieszalski/src/matterfi/vcpkg/buildtrees/pcre2/src/cre2-10.40-42fc341438.clean
-- Found external ninja('1.11.1').
-- Configuring arm64-osx
-- Building arm64-osx-rel
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
Command failed: /opt/homebrew/Cellar/cmake/3.26.3/bin/cmake --build . --config Release --target install -- -v -j11
Working Directory: /Users/michalpospieszalski/src/matterfi/vcpkg/buildtrees/pcre2/arm64-osx-rel
See logs for more information:
/Users/michalpospieszalski/src/matterfi/vcpkg/buildtrees/pcre2/install-arm64-osx-rel-out.log
Call Stack (most recent call first):
installed/arm64-osx/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
installed/arm64-osx/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
ports/pcre2/portfile.cmake:41 (vcpkg_cmake_install)
scripts/ports.cmake:147 (include)
error: building pcre2:arm64-osx failed with: BUILD_FAILED
error: Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+pcre2
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[pcre2]+Build+error
Include '[pcre2] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
vcpkg-tool version: 2023-02-16-12e657924d99511514c0287ca5ce46882d3657c7
vcpkg-scripts version: a7b6122 2023-02-24 (7 weeks ago)
Please use the prefilled template from /Users/michalpospieszalski/src/matterfi/vcpkg/installed/vcpkg/issue_body.md when reporting your issue.
install-arm64-osx-rel-out.log
Additional context
No response

this was caused by a min build target set to 10.15 in my script.  fixed.


New token logo for Jiicoin

I have check but the new logo for the Jii coin is not showing in the Trust Wallet
Can you double check please
I appreciate it
Warm regards
J

It’s alrwsdy on Trust! I’m able to see it

@JurgenJii we have caching for 7 days, new users will see the new token image.


Livestream working in Camera.Ui but not in HomeKit

For now, I only have one "Camera". It's simply a restream of my Octoprint webcam stream, and so far I have only gotten a still picture every 20 seconds (or more), but as soon as I want to see the stream, it just doesn't load and eventually just stops trying to connect.
My Config:
"cameras": [
{
"name": "Octoprint",
"motion": true,
"motionTimeout": 15,
"unbridge": false,
"hsv": true,
"prebuffering": true,
"forcePrebuffering": true,
"prebufferLength": 4,
"hksvConfig": {
"source": "-i http://<IP_ADDRESS>/webcam/?action=stream"
},
"videoConfig": {
"source": "-i http://<IP_ADDRESS>/webcam/?action=stream",
"subSource": "-i http://<IP_ADDRESS>/webcam/?action=stream",
"stillImageSource": "-i http://<IP_ADDRESS>/webcam/?action=stream",
"maxFPS": 15,
"vcodec": "copy",
"audio": false,
"debug": true
},
"smtp": {
"email": "Octoprint"
},
"videoanalysis": {
"active": true
},
"mqtt": {}
}
],
"_bridge": {
"username": "0E:4C:D7:29:F0:7B",
"port": 58778
I am also sometimes getting this error:
[7/23/2024, 6:55:37 PM] [CameraUI]  ERROR  Octoprint: FFmpeg exited with code: 1 and signal: null

🎉 A new version of camera.ui
A new version of camera.ui is currently under active development. An initial alpha/beta release and previews are coming soon. Stay tuned for exciting updates: https://github.com/seydx/camera.ui/issues/448 .
This version will no longer be developed / fixed. The new version contains many novelties and fixes (most important is for HKSV recording).

I have the same problem. It works in the Plugin but not in Homekit.
same Error.

This version will not be fixed or improved anymore. A completely new version is being created from scratch.
At this moment new version of camera.ui can be installed via NPM on each device, so also next to Homebridge (Homebridge plugin is planned).
New version is in alpha stage, but it is very stable and every option that is at this moment implemented works much better than in old plugin (e.g. HomeKit, Motion detection, Web panel), but not all options are implemented yet (eg. Local recordings will be soon).
If you want to try new alpha, join Discord channel and check installation channel: https://discord.gg/8F22ZgmQs9


Getting most updated package from PyPI is delayed, (can pip install, but not poetry add).

[x] I am on the latest Poetry version.
[x] I have searched the issues of this repo and believe that this is not a duplicate.

OS version and name: macOS 10.13.6
Poetry version: 0.11.5

Issue

cjkradlib is my self-created package, that I've just uploaded to PyPI.
I cannot poetry add cjkradlib==0.1.2, but the I can pip install cjkradlib==0.1.2, but even after pip install for a while, I still cannot poetry add cjkradlib==0.1.2.
(venv) Pacharapols-MacBook-Air:ChineseViewer patarapolw$ poetry add cjkradlib==0.1.2

[ValueError]
Could not find a matching version of package cjkradlib

I had the same issue for me and my package, rororo.
I'm using,

OS version and name: macOS 10.14
Poetry version: 0.12.4

New alpha version of my package installable by pip, but not by poetry,
$ .venv/bin/pip install rororo==1.2.0a1
...
Successfully installed rororo-1.2.0a1
$ poetry add rororo==1.2.0a1
...
Could not find a matching version of package rororo

However in 30 minutes or so I'm able to install new alpha version via poetry as well. Not sure that poetry is a reason for bug here, but that was strange.
ps. My package has both *.tar.gz and *.whl files to install from.

This is due to the cache in Poetry. Basically, Poetry caches the http responses to speed up releases lookup when resolving dependencies.
Note that sometimes this is in reverse: Poetry will see a new release but Pip won't so the installation will actually raise an error.
As of now there is no way around it without compromising dependency resolution speed.

I believe poetry cache clear pypi --all clears the cache (at least on 1.0.0b1).
@sdispater what about falling back to an http request on resolution failure? What is the timeout on the cache?


Create OCI Plugin Releases

Summary
We should create a script that can:

Copy TF plugins into TCE's OCI repo
Create a plugin release manifest
Push the plugin release manifest to TCE's OCI repo

1. Copy TF plugins into TCE's OCI repo
We must be able to copy TF's plugin releases using imgpkg. The following image shows how the copy should occur:

2. Create a plugin release manifest
Pull and unpack the contents of projects.registry.vmware.com/tce/cli-plugins/release:v0.10.0-dev.5 to see a finalized release manifest. See https://github.com/vmware-tanzu/community-edition/pull/3112/files to understand how this is done. Using this PR, polish up the steps and wire in a simplified scrip that can execute and create this manifest.
Note that you will point to CLI images that have already been pushed, that work is part of:

https://github.com/vmware-tanzu/community-edition/issues/3233

3. Push the plugin release manifest to TCE's OCI repo
The manifest (bundle) produced in step 2, should be pushed to projects.registry.vmware.com/tce/cli/release:${TCE-VERSION}
Additional Information
See the PR here:

https://github.com/vmware-tanzu/community-edition/pull/3112/files

That demonstrates the model described above.

@karuppiah7890 is added here. @seemiller owns the initial work. Release engineering should then handle the triggering of it (via automation) and maintencne of it over time.
@karuppiah7890 feel free to assign someone from your team if you're not the right human.

This won't be relevant for v0.12.0 because we cannot afford to change this model until potentially v0.13.0.

@joshrosso ping me if I can help with this. I keep having packaging conversations w.r.t. Sonobuoy (the conformance plugin) and I'd like to just be involved more with how it is/will be implemented here. I'm considering doing something like this for the Sonobuoy repo itself, so if landing something there would be helpful, let me know.

@joshrosso ping me if I can help with this. I keep having packaging conversations w.r.t. Sonobuoy (the conformance plugin) and I'd like to just be involved more with how it is/will be implemented here. I'm considering doing something like this for the Sonobuoy repo itself, so if landing something there would be helpful, let me know.

@johnSchnake, apologies I missed this notification.
Will do. Near-term we're stopping our incrementing of tanzu-framework and aren't going to change anything about our plugin model.  Depending on where you're looking to include Sonobuoy (e.g. TKG) doing this work may still be valuable on your end.
Happy to chat more in Slack on this if I can clarify.


Use context from custom exceptions

Is there any plan to add this? I've been wasting a lot of time trying to make use of Laravel's exception context functionality only to have it accomplish nothing because Ignition doesn't show the context around my exception, and wraps my exception in its own exception so that Telescope can't see it.


Remove some complexity of the generated Java multi-project build

@bot-gradle test and merge

OK, I've already triggered a build for you.


Visualization export takes the wrong id

In some cases the export is requested with a id that doesn't match the actual visualization id. In this log you have the full information: https://rollbar.com/vizzuality/CartoDB/items/18411/occurrences/13360110358/ . As you can see, the referral visualization id doesn't match the requested id

New occurrences: https://rollbar.com/vizzuality/CartoDB/items/18411/?item_page=0&#instances

STR:

Go to a dataset
Create a map from the dataset (click visualize)
Export the map
:bomb: The vis_data has the id from the dataset until you reload the page


secrets-from-s3: Generate secrets from blob storage

Generate k8s secrets from an s3 bucket that can be deployed with
k8s-deploy.

@reactiveops/technical-team-members
Deploy with a client in CircleCI and working.

\0/ Awesome @philipcristiano

Works great for me!
Would like to see this merged and released

In the absence of comments about the code I will update docs next free day I get and merge/release.

Updated docs and will merge/tag this.


Extracted counter constants and action creates in to dedicated folders

I did see the comments about this in the code but still thought it was a good idea. This helps on new projects when prototyping a store and reduces the clean up needed on a new project (removing the existing counter constants/actions).

Hey so you can ignore those comments for now, since I'm still debating whether or not this is a change I'd like to make -- I've gone back and forth on it already a few times during this starter kit's existence. That said, I'll most likely merge it in, so I really appreciate the effort, but I'll probably sleep on it first. Regardless, thank you for the contribution!

I figured it had a 50/50 shot but thought I'd try :)

Hey @kyleect, if you make the changes per the comments above I'll happily merge this in. Yeah, it adds another file or two that people have to delete, but in the end I think it's helpful to demonstrate the utils and recommended folder structure.

I agree - those changes make this starter kit easier to begin with, and it's easier to delete few files if you already know what you're doing, than figure out by yourself what is the best way to organise things when you're starting up for the first time.

Good point @Jarema; waiting on @kyleect to make those few tweaks and then I'll merge it.

I have made those updates

Awesome, thank you!


fix _getPixelPerfectCursorOffset logic when infinite

Description
The fallback values used in https://github.com/flutter/flutter/issues/64785 were not right.
Related Issues
Fixes https://github.com/flutter/flutter/issues/66457
Tests
Corrected an existing test
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.

Not sure if it makes any difference to the solution, but in the example provided by MaruQuarky in #66457, the issue does occur in Android as well, just much less frequently. I've added a comment to that issue with a trace of the exception being thrown in Android.


The link to Security and Compliance powershell goes to EXO powershell.

There doesn't yet seem to be docs articles for set-teamsretentioncompliance* anywhere in that area.  Trying to find more info on preservation lock for Teams.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca579d63-182b-d6f5-8777-79248fa27ed9
Version Independent ID: b4c27d1b-b2f1-41ac-b15c-d12b448a539e
Content: Overview of security and compliance in Microsoft Teams
Content Source: Teams/security-compliance-overview.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@chrislehr - I agree it is hard to find those. I will add the direct links to this article. In the meantime, you can find the cmdlets here:

Go to Exchange Online Cmdlet Reference
On the left nav, expand Reference > Exchange > policy-and-compliance-retention.

Hope that helps and thank you for the feedback on this!

@chrislehr - Ack, sorry I misread this one. I thought it was asking for the link to Exchange Online PowerShell. I will track this down.

@chrislehr - I found out these cmdlets are in fact supposed to be in Exchange cmdlet content set since they directly relate those modules. I will add direct links in the article. I will keep this open until the links are added. Thanks again for pointing this out. I am sure a number of customers had the same confusion and I really appreciate you taking the time to submit feedback.

Added direct links to the cmdlets in the article. Thanks again for pointing this out!

This is the most impressed with a feedback loop ive been in recent memory. Awesome work. Thanks.

Chris Lehr
On May 4, 2018, at 3:15 PM, Ken Withee <notifications<EMAIL_ADDRESS>wrote:
Added direct links to the cmdlets in the articlehttps://docs.microsoft.com/en-us/microsoftteams/security-compliance-overview. Thanks again for pointing this out!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/169#issuecomment-386748792, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKXzE4x4j-U7yg0eBINKYGGybl1ttdBXks5tvNLlgaJpZM4TzF9d.


Add containerized options for tests in Makefile

Fix #4162
Add an option to run the test-unit, test-style, build, and test
steps from the Makefile insides of a docker container. Doing so
isolates this component of helm development from any other aspect of
your global go environment.
These commands all have the name containerized-*. Long term, there may
be reproducibility benefits to running all of the Make steps in a
container by default, in which case containerized-test-unit could
become test-unit.

@bacongobbler fixed and ready for another look whenever you get the chance :) thanks!

@mattjmcnaughton Sorry for this falling through the cracks. 😞 Can you please rebase this and then we will finish up review and pull into 2.11

Yup, would be happy to! Will do tomorrow :)

@thomastaylor312 @bacongobbler ready for another look whenever y'all get the chance :) thanks!

This was contributed under the CLA prior to the DCO agreement, so this is good to merge.


[TF:TRT] Add ability to persist timing cache to disk

Drops compile time of models significantly (e.g. 240 sec -> 40 sec on object detection with TRT 8.2)

Marked as draft as we require some discussion. Is there a better way to persist the cache than just persisting to disk at an environment variable location? Can we embed it as a resource in the model (with some information about the GPU)?

The approach looks fine to me. Thanks for working on this!

@christopherbate This PR is in draft, any update on this? Please. Thank you!

@christopherbate This PR is in draft, any update on this? Please. Thank you!


Annoying shortcut key Shift+C

The shortcut key for Insert-PVS Studio comment is Shift+C, i cant write the "C" char

I recognized i can change the shortcut keyboard in Tools/Options/Enviroment/Keyboard.


Not updated to work in VR

Unity currently doesn't have any volumetrics for VR AFAIK. Please update. A Proper postprocessing + volumetrics stack should have a very high priority on unity's list if you want to compete with the big boys, and the little boys with custom engines.

Seconding tdbe's issue, I would love to see this for VR.

Thirding. I need this to work in VR, because it’s perfect for what I need.

This does appear to work in VR OOB as of Unity 2017.2.0f3.

Its sort of useless without directional light support

You can't use directional lights and these area lights at the same time? Ouch.
The main thing for VR would be single pass stereo rendering support, right?
What are the chances that we will see that? Last project update was 2 months ago at the time of writing...

You can't use directional lights and these area lights at the same time? Ouch.
You can, the directional light won't affect the fog though. Not yet at least.

As for VR support, and any new feature in general, I will add it when whatever demo we're currently working on requires it. This way it will be tested properly as well.

+1 for VR support

@robertcupisz any updates to this project?


nil can't be coerced into Fixnum

Hello!
I'm trying to use kaminari inside my service object (actually it's an operator from trailblazer). Here is a simplified version of my code:
class MyService
  def initialize
    apply_pagination()
  end
  # ...

  def model
    Model.all
  end

  # ...

  def apply_pagination
    self.model = self.model.page(params[:page])
  end
end

For some reason, when i'm trying to run any kaminari-related method on my results, kaminari throws nil can't be coerced into Fixnum at lib/kaminari/models/page_scope_methods.rb:42
That happens only when i'm trying to make it from inside my service/operation class. Running page() outside of it works just fine.
Thanks in advance for any clues!

 It turned out that such error occurs when we pass nil to the limit() method. Shouldn't it default itself?


firehol: 3.1.5 -> 3.1.6

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/firehol/versions.
meta.description for firehol is: '"A firewall for humans"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
Warning: no invocation of /nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/bin/firehol had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/bin/fireqos had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/bin/link-balancer had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/bin/update-ipsets had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/bin/vnetbuild had a zero exit code or showed the expected version
0 of 5 passed binary check by having a zero exit code.
0 of 5 passed binary check by having the new version present in output.
found 3.1.6 with grep in /nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6
directory tree listing: https://gist.github.com/df2224977b9164c0740b40beccfce1f7
du listing: https://gist.github.com/ab8ef50780849dfff2adb2072ff647f5

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 3af49c963ddd3036378d935bab83ec944bd2c7f3 && nix-shell --pure -I nixpkgs=. -p firehol

cc @geistesk for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: firehol
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: firehol
Partial log (click to expand)
/nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/share/doc/firehol/examples/adblock.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/share/doc/firehol/contrib/ipset-apply.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/share/doc/firehol/contrib/dnsbl-ipset.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/libexec/firehol/3.1.6/vnetbuild: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/libexec/firehol/3.1.6/update-ipsets: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/libexec/firehol/3.1.6/link-balancer: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/libexec/firehol/3.1.6/fireqos: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/libexec/firehol/3.1.6/firehol: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6...
moving /nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/sbin/* to /nix/store/vfmbda3d1aa0s0frpvgxfkkzpg5s256s-firehol-3.1.6/bin

Success on aarch64-linux (full log)
Attempted: firehol
Partial log (click to expand)
/nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6/share/doc/firehol/contrib/dnsbl-ipset.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6/share/doc/firehol/examples/adblock.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6/libexec/firehol/3.1.6/vnetbuild: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6/libexec/firehol/3.1.6/update-ipsets: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6/libexec/firehol/3.1.6/link-balancer: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6/libexec/firehol/3.1.6/fireqos: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6/libexec/firehol/3.1.6/firehol: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6...
moving /nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6/sbin/* to /nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6/bin
/nix/store/wr5wl6v4scj4raigsxy61amvid00l8mm-firehol-3.1.6


Feature request

Discussed in https://github.com/Dhruv-Techapps/auto-click-auto-fill/discussions/185

Originally posted by forp3tessake August  4, 2021
Hi I'm not sure if this is the right place for a feature request so feel free to move this post to somewhere else.
We already talked about this in the Discord group, but I wanted to put in a formal request nonetheless.
I would like to be able to autoclick buttons on popups from Chrome extensions with URLs starting with chrome-extension://
Thanks

We checked on this and currently chrome browser don't load extension script on pages which are generated from another extension


[zlib] Update to 1.2.12 since 1.2.11 has been redacted by upstream

Describe the pull request

What does your PR fix?

zlib 1.2.11 has been redacted  and the tar ball has been removed from zlib.net:

Due to the bug fixes, any installations of 1.2.11 should be replaced with 1.2.12.

Which triplets are supported/not supported? Have you updated the [CI baseline]

No changes

Does your PR follow the maintainer guide?

Yes

This LGTM, thanks for the PR!


How to display related table in blazor using entity frame work

//Entity framewor core include statement
proj = pron.Proj.Include(p => p.Mod.Select(x => x.ModId)).AsNoTracking().SingleOrDefault(p => p.ProjId == id);
//pron - dbcontext
//client code

@proj.ProjName

@proj.Mod.ModName

Value get it from DB (while check in VS through break point) but not displaying

Hi. It looks like this is a question about how to use ASP.NET Core. While we do our best to look through all the issues filed here, to get a faster response we suggest posting your questions to StackOverflow using the asp.net-core-blazor tag.


Support selecting out lower-dimensional slices with [] for DataFrame and series

Is your feature request related to a problem? Please describe.
Support basic indexing for DataFrame.

Object Type
Selection
Return Value Type

Series
series[label]
scalar value

DataFrame
frame[colname]
Series corresponding to colname

PR #638 implements fetching dataframe slice by DataFrame.iloc, which may be related to the DataFrame part of this issue.


property.shortdesc malformed?

This is from a "class"-Page of my Documentation:

Notice that the property's type and name get repeated in front of the description without any whitespace. The corresponding DocBlock looks like this:
/**
[...]
 * @property int $id The ID of the Category object.
 * @property int $parentCategoryId The ID of the parent category, if applicable
[...]
 */

Did I do something wrong in the DocBlock? Or is this indeed a bug?
Cheers
Christoph

The DocBlock looks good.
This can be bug in following places, but without checking in the code I can't tell:

library we're using to parse DocBlocks
Twig template where data is being displayed

I've updated the Repo I created for #204 so now when you run
`php vendor/sami/sami/sami.php update samidoc/config.php``,
the generated documentation includes this.

As a hotfix, modifying class.twig in the following way:
{% block properties %}

        {% for property in properties %}

                    {% if property.static %}static{% endif %}
                    {% if property.protected %}protected{% endif %}
                    {% if property.private %}private{% endif %}
                    {{ hint_link(property.hint) }}

                ${{ property.name|raw }}
                /****************************************************************
                 The following line contains the hotfix
                ****************************************************************/
                {{ property.shortdesc|desc(class)|slice(hint_link(property.hint)|length + property.name|raw|length) }}

                    {%- if property.class is not same as(class) -%}
                        from {{ property_link(property, false, true) }}
                    {%- endif -%}

        {% endfor %}

{% endblock %}

seems to work.

Can you please show what's changed (diff) of that line?

Or even send a PR?

I could, though this is really a dirty fix. Somehow, property.shortdesc|desc(class) returns a string including type and name in front of the description. To get rid of it, I simply slice'd it (as in: took a substring of it with the beginning cut off).
Original line:
{{ property.shortdesc|desc(class) }}

My line with the dirty fix:
{{ property.shortdesc|desc(class)|slice(hint_link(property.hint)|length + property.name|raw|length) }}

If you'd like, I'll send a PR regardless, of course. :)

Maybe underlying DocBlock parsing library has an error. Can you please debug it?

Sure, I'll be glad to! :) It's going to take some time 'though, I'm running a little low on spare time at the moment. But I should be able to get to it before the end of next week.

Same problem here. At least I try to respond on GitHub to at least organize people into doing things.

I appreciate that! It's not to be taken for granted that the response time on issues for an open source project is that short. Keep up the good work!

According to PHPDoc website (see https://www.phpdoc.org/docs/latest/references/phpdoc/tags/property.html) the syntax for @property tag is as follows:
@property [Type] [name] [<description>]

In the example repo you've used following code however:
@property $someProp Some random property, only introduced to demonstrate a bug

In there type is missing. I'm looking into how @property is being handled right now, but this is definetly code in Sami side.

@Christoph-Harms , I've created #206 PR, that fixes this issue.


Fix formatting in ProblemList files

-Reformatted the ProblemList files
related: adoptium#5787

Disabled Tests Linter passed! :)
https://github.com/adoptium/aqa-tests/actions/runs/12264148271/job/34217352559?pr=5811
Thanks @annaibm


Import OADOI from new subscription source

Asked Richard Orr for clarification on the creation date of the "current daily snapshot", to potentially make import process more efficient. Waiting for an answer.

done


Decomposition of single service into multiple services

1.) This renames the existing service manager into a service to
implement the all in one scenario (existing)
2.) Next, two new services are added (vm only and db only)
3.) Each lifecycle operation go file (bind, deprovision, provision, unbind)
now declares a method for each service manager struct
4.) Added new services to the catalog
5.) DB only option is plumbed in, but won't work as of yet (ref instance)
6.) Refactored catalog/service interface to add GetBindable() method
7.) Modified tests to only execute binding related tests if plan
is bindable
I'm wondering if it would make sense to decompose the lifecycle go files. Right now, we are violating DRY for these, so might also be good to identify commonality and refactor the Provision Params / Instance Details to use embedding to get some reuse.

Registered a few small bits of feedback, but overall, this is great. There are DRY exceptions we can factor out later. (I'd already said that siloing the service managers for this module was a more immediate priority than avoiding DRY exceptions, insofar as this PoC is informing where we go next.)
Re: any feedback I've left. Act on whatever things you reasonably can, but this PR advances us significantly toward what we're trying to achieve with #124 and I think we should get this merged sooner, rather than later. i.e. Don't let perfection be a blocker for this PR.


Can't find teams or group using GRAPH

Happy Friday. End goal is to fetch all members of a team.
/v1.0/me/joinedTeams - returns a resource does not exist
/v1.0/me - returns a suspiciously sparse user profile

I then manually extracted the team_id from the team's shareable link and tried
/v3/conversations/fc5b01dd-15e1-4102-8b18-12863e77022f/members - returns 'Authorization has been denied'
I used the same email for the requests and Teams. Is it possible it's being treated as two emails hence the disconnect? I could be making an obvious mistake and appreciate any help.

@isaacdchan - Seems like you are using Microsoft Teams Free account (isaac.d.chan_gmail.com). It appears you are calling the graph with a Microsoft Account (aka MSA) versus an Azure Active Directory (Azure AD) account. Microsoft Graph APIs for Teams do not support MSA accounts, only Azure AD accounts.
Could you please use https://login.microsoftonline.com/TENANT_ID/oauth2/authorize?... and not https://login.microsoftonline.com/common/oauth2/authorize?... as documented in FAQ?
For this you could follow the steps provided in Get access on behalf of a user documentation.
I am not sure if Freemium is requirement for you. If not then you can sign up for the Office 365 Developer program to get a free one-year Office 365 Developer Tenant. This account can only be used for testing purposes.

@Wajeed-msft Thanks for the help. Created an Azure AD account<EMAIL_ADDRESS>and joined team. The request from /v1.0/me/joinedTeams returned 200, so authorization worked and the account is not forbidden. But the list of teams is empty despite being in a team.

Appreciate the patience.

Could you please check if /groups/{id}/members shows all the members? You can get a list of groups that have teams using beta APIs.

/groups returns the group "test group" that I created. id: c947a221-4422-41be-8f95-e837638311f5
/groups/c947a221-4422-41be-8f95-e837638311f5/members returns an empty list
Is this normal behavior?
MS account<EMAIL_ADDRESS>is the main tenant of this Azure, created the org and the team. Could that possibly be affecting the results?

If you still facing this issue, please re-open with latest request/response details.


Event requests/function refactoring - CU7600 Calendar Management, P7605 Customized Cal. Entries Subfm

Hello,
Could you please create new publishers in the CU7600 (Calendar Management) / refactor the function?
Reason: We need to propagate new fields from the calendar changes to the base calendar
CU7600 The functions CheckDateStatus AND CheckCustomizedDateStatus (current state, both functions contains the same code except the first line in the CheckCustomizedDateStatus, I attach only one of them, but we need to refactor both of them)
[External] CheckDateStatus(CalendarCode : Code[10];TargetDate : Date;VAR Description : Text[50]) : Boolean
BaseCalChange.RESET;
BaseCalChange.SETRANGE("Base Calendar Code",CalendarCode);
IF BaseCalChange.FINDSET THEN
  REPEAT
    CASE BaseCalChange."Recurring System" OF
      BaseCalChange."Recurring System"::" ":
        IF TargetDate = BaseCalChange.Date THEN BEGIN
          Description := BaseCalChange.Description;
          EXIT(BaseCalChange.Nonworking);
        END;
      BaseCalChange."Recurring System"::"Weekly Recurring":
        IF DATE2DWY(TargetDate,1) = BaseCalChange.Day THEN BEGIN
          Description := BaseCalChange.Description;
          EXIT(BaseCalChange.Nonworking);
        END;
      BaseCalChange."Recurring System"::"Annual Recurring":
        IF (DATE2DMY(TargetDate,2) = DATE2DMY(BaseCalChange.Date,2)) AND
           (DATE2DMY(TargetDate,1) = DATE2DMY(BaseCalChange.Date,1))
        THEN BEGIN
          Description := BaseCalChange.Description;
          EXIT(BaseCalChange.Nonworking);
        END;
    END;
  UNTIL BaseCalChange.NEXT = 0;
Description := '';

Future state (new var parameter)
[External] CheckDateStatus(CalendarCode : Code[10];TargetDate : Date;VAR Description : Text[50]; VAR BaseCalChange) : Boolean
BaseCalChange.RESET;
BaseCalChange.SETRANGE("Base Calendar Code",CalendarCode);
IF BaseCalChange.FINDSET THEN
  REPEAT
    CASE BaseCalChange."Recurring System" OF
      BaseCalChange."Recurring System"::" ":
        IF TargetDate = BaseCalChange.Date THEN BEGIN
          Description := BaseCalChange.Description;
          EXIT(BaseCalChange.Nonworking);
        END;
      BaseCalChange."Recurring System"::"Weekly Recurring":
        IF DATE2DWY(TargetDate,1) = BaseCalChange.Day THEN BEGIN
          Description := BaseCalChange.Description;
          EXIT(BaseCalChange.Nonworking);
        END;
      BaseCalChange."Recurring System"::"Annual Recurring":
        IF (DATE2DMY(TargetDate,2) = DATE2DMY(BaseCalChange.Date,2)) AND
           (DATE2DMY(TargetDate,1) = DATE2DMY(BaseCalChange.Date,1))
        THEN BEGIN
          Description := BaseCalChange.Description;
          EXIT(BaseCalChange.Nonworking);
        END;
    END;
  UNTIL BaseCalChange.NEXT = 0;
Description := '';

CU7600 The function CombineChanges (current state)
...
    TempCustChange."Recurring System" := CustCalChange."Recurring System";
    TempCustChange."Entry No." := TempCounter;
    TempCustChange.INSERT;
  UNTIL CustCalChange.NEXT = 0;
...
    TempCustChange.Nonworking := BaseCalChange.Nonworking;
    TempCustChange."Recurring System" := BaseCalChange."Recurring System";
    TempCustChange.INSERT;
  UNTIL BaseCalChange.NEXT = 0;
...

Future state
...
    TempCustChange."Recurring System" := CustCalChange."Recurring System";
    TempCustChange."Entry No." := TempCounter;
    OnCombineChangesCustCalendar(var TempCustChange, CustCalChange, TempCounter);
    TempCustChange.INSERT;
  UNTIL CustCalChange.NEXT = 0;
...
    TempCustChange.Nonworking := BaseCalChange.Nonworking;
    TempCustChange."Recurring System" := BaseCalChange."Recurring System";
    OnCombineChangesBaseCalendar(var TempCustChange, BaseCalChange, TempCounter);
    TempCustChange.INSERT;
  UNTIL BaseCalChange.NEXT = 0;
...

CU7600 The function CreateWhereUsedEntries(current state)
...
    WhereUsedBaseCalendar.INSERT;
  END;

COMMIT;

Future state
...
    WhereUsedBaseCalendar.INSERT;
  END;

  OnCreateWhereUsedEntries(var WhereUsedBaseCalendar, BaseCalendarCode );
COMMIT;

P7605 The function UpdateBaseCalendarChanges(current state)
...
  CustomizedCalendarChange.Nonworking := Nonworking;
  CustomizedCalendarChange.INSERT;
END;

Future state
...
  CustomizedCalendarChange.Nonworking := Nonworking;
  CustomizedCalendarChange.INSERT;

  OnUpdateBaseCalendarChanges(var CustomizedCalendarChange, Rec, Nonworking);
END;

P7604/P7605 Please create a new functions. This is the most important thing, without this function, it is impossible to do any change on this page...
[External] GetCalendarCode(VAR CalendarCode : Code[10];VAR LocNonworking : Boolean;VAR LocDescription : Text[30])

[External] GetCalendarCode(VAR SourceType : 'Company,Customer,Vendor,Location,Shipping Agent';VAR SourceCode : Code[20];VAR AdditionalSourceCode : Code[20];VAR CalendarCode : Code[10];VAR LocNonworking : Boolean;VAR LocDescription : Text[30])

Thank you for your input. We will investigate this request further and may get back to you with further questions.

@TKapitan, what fields do you want to add? Will it makes sense to add them to the standard product?

Assuming a solution was found due to lack of response on old issue. Closing issue. If problem still exists, please open a new issue.


chore: provide initial framework, structure and content

What this PR changes/adds
See a preview here.

Adds docsify framework
Moves docsify specific documentation from connector repo
Updates contribution/workflow files
Adds other repos as submodules to allow the direct embedding of markdown files
Adds workflow to automatically update submodels

Why it does that
Fill GitHub pages with content.
Further notes
Some links may be currently still broken as major changes will be applied with #1882. Also, the PRs #34, #30, #8 and #1 apply changes to simplify the navigation via GitHub pages.
Linked Issue(s)
Relates #1865
Checklist

[ ] added/updated copyright headers?
[ ] documented code?
[ ] formatted title correctly? (take a look at the CONTRIBUTING for details)

@mspiekermann GitHub pages will need to be activated within this repo:

Github pages is active now


Implement getShuffleRDD and fixup mismatched output types on shuffle reuse [databricks]

Fixes #4216.
This implements the getShuffleRDD interface for GpuShuffleExchangeExec and fixes an issue with ReusedExchangeExec caching CPU aggregation buffer types before they're updated with GPU aggregation buffer types.  The plan is searched for instances where the ReusedShuffleExec output types do not match the underlying GPU shuffle output types, fixing the output types of ReusedShuffleExec to match the GPU shuffle.

build

Databricks 9.1 build failed due to access restrictions on newReuseInstance.  Added a shim for this and my best guess at a workaround for it.

build


Removing yarn

Codecov Report

Merging #40 (28eb35c) into main (0d21701) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          311       311
  Branches        55        55
=========================================
  Hits           311       311

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d21701...28eb35c. Read the comment docs.


feat(chat): [Authorizatiton] Add option to do authorization in the same window (Issue #1737)

feat: [Authorizatiton] Add option to do authorization in the same window (Issue #1737)
Description:
Added flag to force sign in to overlay be opened in the same window
Issues:

Issue #1737

UI changes
None
Checklist:

[X] the pull request name complies with Conventional Commits
[X] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[X] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[X] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review


Missing Areas on the downloaded pdf[Bug]

Is there an existing issue for this?

[X] Yes, I have searched the existing issues and none of them match my problem.

Product Variant
Cloud (https://rxresu.me)
Current Behavior
I download the pdf version of the resume I created which the function works well BUT, the downloaded file a lot of missing areas in the pdf. On the main part of the resume, it only show one part which is the one on the top, whatever is on the top of the main area, it's there, but below that is nothing, it's just blank, no writings, no letters no information, nada, nothing.
Expected Behavior
well, it's suppsoed to give me the pdf file of the resume I created with all the information i created on the website, but no.
Steps To Reproduce
No response
What browsers are you seeing the problem on?
Chrome, Microsoft Edge
What template are you using?
None
Anything else?
No response

Does this happen to all templates?

Yes
On Fri, Jun 14, 2024, 7:55 PM Amruth Pillai @.***>
wrote:

Does this happen to all templates?
—
Reply to this email directly, view it on GitHub
https://github.com/AmruthPillai/Reactive-Resume/issues/1964#issuecomment-2167863664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJGCUI3GE4P5DWI4QLUAZM3ZHLK3FAVCNFSM6AAAAABJJ5VMN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXHA3DGNRWGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

After clicking export pdf, the page returns to blank and a new page about:blank pops up with no content.

What?? I said, it's the pdf file that was downloaded. Its the downloaded
file that's missing contents - not the web page. Try to create a resume
yourself and download the pdf, you'll see what I'm talking about.
On Fri, Jun 14, 2024, 9:08 PM loneliness @.***> wrote:

After clicking export pdf, the page returns to blank and a new page
about:blank pops up with no content.
—
Reply to this email directly, view it on GitHub
https://github.com/AmruthPillai/Reactive-Resume/issues/1964#issuecomment-2168008120,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJGCUI2XZSDJXNZRSM5UBOTZHLTL3AVCNFSM6AAAAABJJ5VMN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGAYDQMJSGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Update:
My current resume is on Gengar template, when I change the template, the
pdf file works fine, all contents are there.
When I change it back to Gengar, same problem occurs.
When I create a new resume with Gengar template, there' no problem at all.
I don't want to change the template of my resume.
There's already a lot of information to create new resume using Gengar
template.
On Fri, Jun 14, 2024 at 9:08 AM loneliness @.***> wrote:

After clicking export pdf, the page returns to blank and a new page
about:blank pops up with no content.
—
Reply to this email directly, view it on GitHub
https://github.com/AmruthPillai/Reactive-Resume/issues/1964#issuecomment-2168008120,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJGCUI2XZSDJXNZRSM5UBOTZHLTL3AVCNFSM6AAAAABJJ5VMN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGAYDQMJSGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I also encountered the same problem, I am self hosting


Support column with _

The method "underscoreToCamelCase" must be extended to support column with _. Otherwise you will get an error, if you try to export articles with attributes e.g. "download_file_1".
Doctrine does expect "downloadFile_1" and not "downloadFile1".

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-7775.
Please use this issue to track the state of your pull request.

closed in favour of #13


java_install => true does not work as expected.

I am using the latest version of the module.
Below is my configuration file to set up a node with elasticsearch. The node does not have 'java' installed so as per the documentation I used the 'java_install' attribute, but the puppet run errors out.
Config file:
classes:
-elasticsearch
elasticsearch::instances:
 es-01:
  config:
   node.name: 'es-01'
   java_install: true
   package_url: 'https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.7.2.noarch.rpm'
Have also tried adding the java_install and package_url under the elasticsearch class instead of under 'instances' like above.
Error:
Error: /Stage[main]/Elasticsearch/Elasticsearch::Instance[es-01]/Elasticsearch::Service[es-01]/Elasticsearch::Service::Init[es-01]/Service[elasticsearch-instance-es-01]/ensure: change from stopped to running failed: Could not start Service[elasticsearch-instance-es-01]: Execution of '/sbin/service elasticsearch-es-01 start' returned 1: which: no java in (/sbin:/usr/sbin:/bin:/usr/bin)
17 Feb 2016 16:34:15,873 | 697017      [ERROR] {Connect thread <IP_ADDRESS> session}<EMAIL_ADDRESS>[solution_quickstart_ravin_mbp_graviton-elasticsearch1] Could not find any executable java binary. Please install java in your PATH or set JAVA_HOME

hi, java_install is part of the main class, not of the instances part.

Yeah, that's what I thought and tried in the first place.
elasticsearch:
 package_url: 'https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.7.2.noarch.rpm'
 java_install: true
But since this doesn't work, I tried to incorporate that part in the instances part.

classes:

elasticsearch

elasticsearch::java_install: true
elasticsearch::package_url: 'https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.7.2.noarch.rpm'
elasticsearch::instances:
 es-01:
  config:
   node.name: 'es-01'
Tried this, but getting an error
Error 400 on SERVER: Puppet::Parser::AST::Resource failed with error ArgumentError: Could not find declared class ::java at /opt/puppet/environments/solution_quickstart_ravin_mbp_graviton/modules/elasticsearch/manifests/init.pp:372
So, it seems that it is taking the java_install: 'true' parameter but it is not able to download/install java.
I am sure, I'm missing something, any help would be appreciated.

Ahh. Seems you are missing the puppetlabs-java module for dependency. I wonder why its not installed. How did you install the elasticsearch puppet module?

So, it seems that if we were to include the java_install => true attribute, we got to have some puppet module that will have java installed on that machine. When I explicitly specify the puppetlabs-java module , java becomes available on that machine and there is no need to specify 'java_install => true'.
It is confusing because, reading the documentation I thought that if the machine does not have java installed already, including 'java_install => true' will automatically solve the problem. Correct me if I am wrong here, thanks!
If it was just me misunderstanding the documentation, we can go ahead and close this.

Hi. You are partially right indeed. If you explicitly state that the java module is included for a node then it installs it and you don't need the java_install flag. But not everyone does or wants that so I added the flag to reduce the number of classes required to define.
Hope this makes sense.

Correct, but what if I do not specify the java (puppet)module? Initially, it was failing because I did not include a java (puppet)module and added the java_install => true attribute giving the above errors.

I've added this to the requirements section of the README

Thanks @ravinaik1312 for the report and @philipwigg for the quick PR.  Merged.


snapping result varies by OS

Prereq for #595 and #581
This issue was initially discovered in #595 and thought to be bug in esda.Moran. However, after some digging by @jeffcsauer and I the difference in the calculated values of esda.Moran.I were determined to be a direct result of a single point observation being snapped to one network arc on macOS/Windows and another on Ubuntu. For gists demonstrating the issue see: macOS-full dataset and Ubuntu-full dataset.
Next steps in debugging:

[x] make MWE and try

obs [274, 275]
arcs [(30,31), (30,208)]

[x] look are point snapping

functions in util
rtree
observations equidistant from network arcs?

This ended up being a sorting issue with closet arc candidates coming from rtree. If two candidate arcs are equidistant from the observation point being snapped the first in the list gets chosen because the second doesn't lead to a decreased distance. This doesn't lead to wrong solutions, but may lead to inconsistent solutions, which are then exacerbated in subsequent analysis (e.g. Moran's I of 0.005192 on macOS vs. 0.004139 on Ubuntu). To solve this problem a sort step should be added in util.snap_points_to_links()
A very similar issue is investigated in Gaboardi et. al (2020).

James D. Gaboardi, David C. Folch, and Mark W. Horner. Connecting Points to Spatial Networks: Effects on Discrete Optimization Models. Geographical Analysis, 52:299–322, 2020. doi:10.1111/gean.12211.

This ended up being a sorting issue with closet arc candidates coming from rtree. If two candidate arcs are equidistant from the observation point being snapped the first in the list gets chosen because the second doesn't lead to a decreased distance. This doesn't lead to wrong solutions, but may lead to inconsistent solutions, which are then exacerbated in subsequent analysis (e.g. Moran's I of 0.005192 on macOS vs. 0.004139 on Ubuntu). To solve this problem a sort step should be added in util.snap_points_to_links()
A very similar issue is investigated in Gaboardi et. al (2020).

James D. Gaboardi, David C. Folch, and Mark W. Horner. Connecting Points to Spatial Networks: Effects on Discrete Optimization Models. Geographical Analysis, 52:299–322, 2020. doi:10.1111/gean.12211.

#599

#599