Consolidate ballots and proposals with same smesher and layer to one

Update the EligibilityProof in InnerBallot to EligibilityProofs—a slice of VotingEligibilityProofs. https://github.com/spacemeshos/go-spacemesh/blob/a22d1eeee6f593b54fbb5f89fb32573f965a6528/common/types/ballot.go#L38-L44
Update proposal_builder.go→createProposal() https://github.com/spacemeshos/go-spacemesh/blob/a22d1eeee6f593b54fbb5f89fb32573f965a6528/miner/proposal_builder.go#L245-L253 to accept a slice of eligibility proofs.
Unwrap the code in this loop: https://github.com/spacemeshos/go-spacemesh/blob/8951b6fa049c8f91e774e69f751973eebc34d690/miner/proposal_builder.go#L362-L412 in proposal_builder.go→handleLayer() - instead of looping, pass proofs into createProposal directly.
In handler.go→checkBallotDataIntegrity() https://github.com/spacemeshos/go-spacemesh/blob/a22d1eeee6f593b54fbb5f89fb32573f965a6528/proposals/handler.go#L242-L280 add a check that counter values (J) of all eligibility proofs are distinct.
In handler.go→processBallot() https://github.com/spacemeshos/go-spacemesh/blob/a22d1eeee6f593b54fbb5f89fb32573f965a6528/proposals/handler.go#L204-L218 add a check for an existing ballot by the same smesher in the same layer. If such a different ballot already exists in our database the expected behaviour is to blacklist the smesher and publish a fraud-proof consisting of the two ballots. Since we don't have this mechanism implemented (and it's non-trivial to implement) we should create a stub method as follows and call it:

func Blacklist(types.SmesherID) {
    // TODO: Implement me!
}

Change the following method to account for multiple eligibility proofs in a ballot. This will probably require changing the weights data structure or augmenting it with another one for the weight of a single ballot of a smesher in an epoch. https://github.com/spacemeshos/go-spacemesh/blob/a22d1eeee6f593b54fbb5f89fb32573f965a6528/tortoise/threshold.go#L10-L59

We currently don't limit the number of transactions in a proposal. Sizing proposals based on ballot weight will be part of the task of limiting the size (part of the transaction selection epic that's being written these days).

Change the following method to account for multiple eligibility proofs in a ballot. This will probably require changing the weights data structure or augmenting it with another one for the weight of a single ballot of a smesher in an epoch.

it won't require changing weights or any other data structure. what is needed is to track which ballots are malicious and either completely skip them when they are loaded into the tortoise, or explicitly register them with 0 weight.

@dshulyak

it won't require changing weights or any other data structure. what is needed is to track which ballots are malicious and either completely skip them when they are loaded into the tortoise, or explicitly register them with 0 weight. Probably registering with 0 is the most convenient, as it will handle cases when ref ballot was malicious so a new ballot based on ref ballot automatically won't be counted.

The problem is not malicious ballots, it's valid ballots with more than one eligibility. So if the ref ballot has 2 eligibilities its weight will be double. When we then calculate the weight of the current ballot, if it only has a single eligibility then we can't use the weight of the ref ballot (we need half).
Two possible solutions I can think of - both seem too complex - we can probably find something simpler/more efficient:

weight is currently a wrapper around a *big.Float[^1] - we can have two numbers in there weight and eligibilityCount with an additional method that returns the weight of a single eligibility (before multiplying by the eligibility count).
We can create an additional map[layerID][smesherID]weight (weight here will be the weight of a single eligibility).

[^1]: The TODO there says it should be replaced with a fixed float, but I think it should be replaced with an integer - we should discuss this some other time.

Thanks, i misunderstood the original intent. I think we should index by atxid then. Map with atxid will store just atx_weight / eligibility_count, and weight of the ballot will be computed as that weight multiplied by eligibilities included into the ballot. And then for efficient eviction it probably needs to be indexed by epoch as well.
So full structure will map[EpochID][AtxID]weight


my change

Checklist

[x] I made something good today 💐.
[x] I put links in the correct format: [Tool](link) — description.
[x] My description starts with the lower-case letter and ends with the full stop.
[x] I put the tool in the alphabetical order.

Optional

[x] I added the appropriate labels: free, open-source or mac.
[x] I put the tool only to one category.
[x] I followed Contribution Guidelines.

@AfifAljav thanks a lot for your suggestion. But we have already had this tool in the SMM Design Tools section. That's why I closed your pull request.


Fix Chat Feature

Restore chat functionatity

display responses correctly
restore accordion logic for prompt accuracy
continue thread functionality

discuss technical design with @gaboesquivel before you start coding

Update:
I am closing this issue for the following reasons:

The current strategy path has already fixed the mentioned details.


Pass extra data (fe. accountIDs) to HTMLToMarkdown method & add possibility to disable certain rules

This PR consists of two different changes

htmlToMarkdown method now has additional, optional argument extras this argument adds the possibility to pass extra data which can be used in replacement function. For now is used to pass accountID to name and reportID to name maps
replace method has additional object key disabledRules. Every rule name from this array will be skipped in parsing.

Fixed Issues
$ https://github.com/Expensify/App/issues/40480
https://github.com/Expensify/App/issues/39550
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
The changes, which this PR introduces, allows to more precisely interact with parser. To be precise, now we will be able to pass application state to the parser itself. We wrote couple of unit tests which mocks passing extras object with account ID and reportID maps to ensure that parsing shortened room and user mentions tags works as intended.

What tests did you perform that validates your changed worked?
We also tested our changes inside E/App. It's not yet supported on main branch, but all changes worked as intended

QA

What does QA need to do to validate your changes?
These changes cannot be tested on E/App yet. Only follow-up PR will be using these changes
What areas to they need to test for regressions?
As we were touching methods responsible for both HTML –> markdown and markdown -> HTML we should look for regressions in every rule and parsing.

I have read the CLA Document and I hereby sign the CLA

Merging to unblock other issues


feat(@angular-devkit/schematics): update zone.js to 0.11.8 and add async tagging API support

Update to zone.js 0.11.8
import 'zone.js/plugins/async-stack-tagging in development mode
to support async tagging API for better debugging experience.

For more information, please refer to this PR https://github.com/angular/angular/pull/46693

Can you please change the scope to @schematics/angular?
Thanks

@alan-agius4 , sure, updated, thank you.

This is handled by https://github.com/angular/angular/pull/47416.


Addthe initial boundary constraint.

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#574  👈
#573
#572
#562
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on  Graphite


[BUG] Cannot create request in subfolder

Bug Description 🐞
I cannot create request in subfolders. Same for duplicate operation
Steps to Reproduce 🕵
Steps to reproduce the behavior:

Some problem with subfolders when duplicate request or save.

Create Folder 1 in root
Create Folder 2 as sub folder of previous
Try to create a new Request in Folder 2
It will select wrong parent and not allow to select Folder 2

Desktop (please complete the following information):

OS: x64
Version 0.3.0

Will be in next release


stop leaking memory by avoiding retain cycle in callback referring to itself

Description
Mu Kitura based HTTPS server with basic auth has been leaking memory for the past months and I finally found a time to investigate. The sample project https://github.com/mman/leaky-kitura demonstrates this issue nicely.
Motivation and Context
The line https://github.com/IBM-Swift/Kitura-Credentials/blob/master/Sources/Credentials/Credentials.swift#L99 creates a retain cycle that from my investigation keeps all requests in memory eating the memory with every authenticated request passing through Credentials.handle method.
Tested using malloc debugger in Xcode 9.2 and Xcode 9.3 as well as in instruments. With this proposed change the process memory usage remains stable.
Checklist:

[x] I have submitted a CLA form
[ ] If applicable, I have updated the documentation accordingly.
[ ] If applicable, I have added tests to cover my changes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Fixes #62 for me.

Codecov Report

Merging #63 into master will decrease coverage by 0.57%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master     #63      +/-   ##
=========================================
- Coverage   65.18%   64.6%   -0.58%
=========================================
  Files           5       5
  Lines         247     243       -4
=========================================
- Hits          161     157       -4
  Misses         86      86

Flag
Coverage Δ

#Credentials
64.6% <75%> (-0.58%)
:arrow_down:

Impacted Files
Coverage Δ

Sources/Credentials/Credentials.swift
62.55% <75%> (-0.7%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9858956...471036a. Read the comment docs.

Thanks @djones6 for very valid comments. I did not consider concurrency at all, I wanted to make sure there are no retain cycles in the first place. I'm not familiar with the codebase that much - just landed in the code as it was leaking :) so let me spend some time on this to see if I can address it properly... no promises though to set the expectations correctly :)

FWIW, this is the fix I tried locally when I wrote the above comment (I'm quite happy for you to use this in your PR if you like).  It seems to fix the problem and works with concurrent requests.
https://gist.github.com/djones6/a3b488812af82af64f6f679143e80ad9

Thanks @djones6 for suggested fix, I have re-examined, reverted my changes, used your suggested fix, retested in both instruments and Xcode with multiple ./test_load.sh instances running and cleaning up the callback reference does indeed help.
I have not verified all code paths thus, but I trust your knowledge of the code 👍


Add info about Mikrotik switches

Some Mikrotik switches have PTP support.
There's a list at the bottom of this page https://help.mikrotik.com/docs/display/ROS/Precision+Time+Protocol

The cheapest is the CRS326-24G-2S, which has two variants:

CRS326-24G-2S+RM, which is rack-mounted
CRS326-24G-2S+IN, which is desktop

I just got the RM version
https://mikrotik.com/product/CRS326-24G-2SplusRM
List price is only $209.  It seems to be widely available: I was able to get from a local retailer in Thailand.
The ports are

1Gb RJ45 x 24
10Gb SFP+ x 2

As regards PTP support

only the RJ45 ports have PTP support
works as boundary clock
does not support working as a transparent clock
all ports have to have the same PTP profile
has support for 802.1as

@kondou you might be interested in this

Thanks.  But it has no TC capability.  And it's not so cheaper than what fs.com provides.


Need help to set task on the same line  for each resource

Hi, I need to set task in the same line to show the resource schedule, how can we do that? I also want to implement zoom in/out feature board. how can we do that?

saydujjaman:  I too am looking for a way to set a task (new or additional) in the same line but further in the timeline.  Have you had any luck with this?

saydujjaman:  I am looking at the code in Chart.cs.  The _DrawTasks method does not allow the drawing of multiple tasks on a single line.  The code simply iterates through the list of tasks and draws them consecutively 1 below the previous incrementing the row variable at the end of each loop.

You can use split tasks into parts and draw the separate parts in the same row.


Omit the "Navigation" label on the menu bar

I'd like to get rid of the "Navigation" word that shows up on the left side of the menu bar in responsive view, but I can't figure out where this is being defined. Not finding it in the html or the CSS. Any help is appreciated, thanks!
Nevermind!
I just found it in the megamenu.js - Should have looked around more before commenting. Thanks!
;0)

In megamenu.js, on line 13 you can change it to what ever you like!
Thanks for using my plugin. Im gonna close this issues.


TypeError: renderPage is not a function

TypeError: renderPage is not a function
at Function.getInitialProps (http://localhost:4000/_next/1500888985100/commons.js:23805:25)
at _callee$ (http://localhost:4000/_next/1500888985100/commons.js:6792:30)
at tryCatch (http://localhost:4000/_next/1500888985100/commons.js:37520:40)
at Generator.invoke [as _invoke] (http://localhost:4000/_next/1500888985100/commons.js:37758:22)
at Generator.prototype.(anonymous function) [as next] (http://localhost:4000/_next/1500888985100/commons.js:37572:21)
at step (http://localhost:4000/_next/1500888985100/commons.js:4170:30)
at http://localhost:4000/_next/1500888985100/commons.js:4188:14
at Promise ()
at F (http://localhost:4000/_next/1500888985100/commons.js:970:28)
at http://localhost:4000/_next/1500888985100/commons.js:4167:12

Please provide a proper reproduction.

@arunoda  I have the same issue renderPage is not a function from dist/server/document.js:83:25.
I am using styled components and implemented the server side rendering as per the example-with-styled-components for the static generation of a github page, but neither as build or as dev does it render.
// pages/index.js

import React from "react";
import App from "./components/app";

import { Provider } from "rebass";
import { injectGlobal, ServerStyleSheet } from "styled-components";

import Document, { Head, Main, NextScript } from 'next/document';

// Resetting browser defaults
injectGlobal`
  * { box-sizing: border-box; }
  body { margin: 0 }
`;

// Composing app with theme
export default class LandingPage extends Document {
  render() {
    // Getting CSS Classes & Styles for in-lining as static render.
    const sheet = new ServerStyleSheet();
    const main = sheet.collectStyles(<Main />);
    const styleTags = sheet.getStyleElement();

    return (
      <html>
        <Head>
          <title>Title</title>
          <meta name="viewport" content="initial-scale=1.0, width=device-width" />
          {styleTags}
        </Head>
        <body>
          <div className="root">
            {main}
          </div>
          <NextScript />
        </body>
      </html>
    );
  }
}

Error Stack:
[1]  WAIT  Compiling...13:46:23
[1]
[1] TypeError: renderPage is not a function
[1]     at Function.getInitialProps (/Users/worker/development/gitmoji/node_modules/next/dist/server/document.js:83:25)
[1]     at _callee$ (/Users/worker/development/gitmoji/node_modules/next/dist/lib/utils.js:36:30)
[1]     at tryCatch (/Users/worker/development/gitmoji/node_modules/regenerator-runtime/runtime.js:65:40)
[1]     at Generator.invoke [as _invoke] (/Users/worker/development/gitmoji/node_modules/regenerator-runtime/runtime.js:303:22)
[1]     at Generator.prototype.(anonymous function) [as next] (/Users/worker/development/gitmoji/node_modules/regenerator-runtime/runtime.js:117:21)
[1]     at step (/Users/worker/development/gitmoji/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
[1]     at /Users/worker/development/gitmoji/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14
[1]     at Promise (<anonymous>)
[1]     at F (/Users/worker/development/gitmoji/node_modules/core-js/library/modules/_export.js:35:28)
[1]     at /Users/worker/development/gitmoji/node_modules/babel-runtime/helpers/asyncToGenerator.js:14:12

// Package.json
  "dependencies": {
    "next": "beta",
    "react": "^15.6.1",
    "react-dom": "^15.6.1",
    "styled-components": "^2.1.0"
  }

Added a PR... since I spend quite some time to find my problem. Not seeing it was related to the file naming _document.js instead of index.js. Which absolutely makes sense.


Increase test coverage

Summary
This PR increases test coverages by adding a non-trainable nested case in preprocess_weights_for_loading for the current following missing lines:
keras/engine/saving.py                      492     88    82%  789-794

Related Issues
#10259
#10236

The results are:
keras/engine/saving.py                      492     86    83%


[Bug] 2.6.0 Data Storm Weaver wheel rendering

Very strange path rendering visual bug. Fresh portable copy full updated.
http://i.imgur.com/U0R2FZB.png
http://i.imgur.com/XJI01A5.png

Yes, I've already been made aware of this. It seems the pathing for that cluster in the passive tree data is messed up; I can't fix the pathing but the next update will allow the current pathing to be correctly rendered.

The rendering is fixed; the pathing is GGG's issue so I'll close this now.


data dashboard - comparing a category and unselecting all dimensions breaks plot

all age groups are unselected but we're comparing by age group. see broken plot:

Perhaps we should select all after the user deselects the last selected dimension.

fixed


get latent code of image

I trained a model in diffargument-stylegan2
I implement a function to get latent code from an image?
can you please show me an example to invert an image.

This is not directly supported, but you may try stylegan2's projection code though it requires some modifications.


how to finetune Bart to summarization task of my own?

Hi Blurr, Thank you for your work first.
My question is about [blurr/nbs/02zc_modeling-seq2seq-summarization.ipynb]
Question one:
I have read through this notebook and  could I use the same codes to finetune Bart on my own academic publication dataset?
I mean, after converting my data into the format of cnndm_sample.csv,  Is it right that I only need to change {the csv file location} and {params of the function learn.fit_one_cycle()} ?
Question two:
If I only need to change the params of learn.fit_one_cycle(), the first param is epoch, and I could change epoch to finetune different models and compare their performance. How about the lr_max param and could I use 4e-5 also?
About the epoch, do you have suggestions?(I have about 1,000,000 articles of full texts and their abstraction)

See my article at here for a walk-thru of summarization with blurr.  To answer your questions:

Yes, you can use all the code as it with a properly formatted dataset.

You'll want to use lr_find both before and after freezing/unfreezing your model to get an idea of how to set the learning rate.  The best resource here for you is the fastai book and this lecture 6 from the latest fastai course.  I don't have any particular recommendations as of yet, but if you watch the lecture you'll get a good feel for how I'd determine what LRs to use.

Thank u so much for your suggestions ！


Convert more tests to JUnit5

some low-hanging fruit
speed up admin tests with declaration failures with a NoBackoffPolicy or remove retry altogether
speed up some tests that were waiting 2 seconds for no message expected

Merged as https://github.com/spring-projects/spring-amqp/commit/2c5d0374f81dec95e77b12df5c612d98acb88b9b


Enhancement: Delete temp files on Errored

I had some plots end with an Errored status (not sure why yet) and the temp files caused some ongoing plotting issues. It would be cool if plotng knew to delete the tmp files from the temp drive in that case.

implemented in v0.12


slot name completion doesn't work

Volar version: 1.7.8
Vue version: 3.3.4
Slot name completion didn't work when I typed #.

But if I typed a additional character d, code completion is triggered properly.

Hi @makedopamine 👋 I cannot reproduce this problem. Could you please confirm?

Can confirm this is no longer reproducible in v1.8.2.

Thanks for confirming. I'll close this issue for now, feel free to ping me to reopen.


Show file structure

Hey!
I am interested in helping to develop the matlab plugin.
Can you point me to some documentation or example on how to begin to implement the "Show file structure" feature? That's the one feature I really like to have.
All the best!

Hi, Timo!
That’s really nice to hear!
You need IntelliJ platform sdk documentation, here is the page about structure view:
http://www.jetbrains.org/intellij/sdk/docs/reference_guide/custom_language_support/structure_view.html
Were you able to setup development and run/debug plugin? If you have any problems you may contact me by telegram: t.me/lkornilova

I suggest reading Grammar-Kit tutorial and looking at #32.
Also there is a step by step guide on how to implement language plugin. I do not recommend you reading Implementing a Parser and PSI section because it may be confusing, but if you decide to look at it just remember that we do not write parser manually (instead we use Grammar-Kit parser generator). Also note that in Matlab AST and PSI is the same (because there is MatlabASTFactory that creates tree nodes that implement both PsiElement and ASTNode interfaces)


Add missing backups pool with profile rbd

When Manila is part of the deployment, we need to enable access to manila_data pool from the previous deployment (TripleO). However, we missed backups pool to the command, which may cause issues to the cinder-backup service when is enabled.

@cescgina @jistr another green run w/ this dependency on tempest / cinder (https://review.rdoproject.org/r/c/testproject/+/55128).
Can we land this patch?

/lgtm

rebased

@jistr can we merge this?


The blocked part is golang.org. With that block in place, you'll have trouble working with Go at all. It is outside of our powers to do something about it.


updates example to work with renamed function

It looks like contextily.calculate_zoom was changed to a private function, so I'm updating the example to work again.
BTW, contextily is so nice @darribas :)

Excellent!!! Merging and thanks for the shout! Glad you're finding the package useful!

Somehow the CI is now failing. I don't think it's related to this patch, but I'll investigate a bit further before merging...

Yeah, looks like floating point precision or something like that? The test could be updated to use assert approximately equal. There's support for that in unittest, numpy, and others.

Coverage remained the same at 92.938% when pulling 9cd45ef65390d075e5b7f83801716a62f440bb66 on andy-esch:update-example-zoom into d55bacd18a46cf7d06188a66e69facdca9543fd6 on darribas:master.

OK I've pushed a couple of updates to the tests (replace assert for assert_array_almost_equal as well as new bounds to the extent because the underlying tiles appear to have changed (plotting the image looked good so assumed no other errors). Merging this now.


NetworkMessage can be value type.  It eliminates per message allocation

Low hanging fruit,
make NetworkMessage a value type to eliminate allocations.
It does not add any complication.
It works for me,  but needs more testing

generally a big fan of value types.
we need to consider if there are cases where we pass around networkmessage through functions where we modify things inbetween..
need to check ummorpg and usurvival later

Its not Mirror itself but I do pass around Msgs in Insight which relies on Mirror.

@uweenukr  passing them around is perfectly fine,  the value types just get copied every function call,  the only issue is if you modify them in one of the callees.

is this necessary if we remove networkmessage anyway?

is this necessary if we remove networkmessage anyway?

No.   But does that matter?  one thing at a time.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


docs: Fix a few typos

There are small typos in:

asciimatics/exceptions.py
asciimatics/parsers.py
asciimatics/renderers/players.py
asciimatics/widgets/textbox.py
doc/source/io.rst

Fixes:

Should read indices rather than indeces.
Should read overridden rather than overriden.
Should read detected rather than detetected.
Should read data rather than datd.

Semi-automated pull request generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

Coverage remained the same at 96.767% when pulling c35950731df2df1cd01336d6f692687877bbb4cb on timgates42:bugfix_typos into 1acde35d994accb1b3811b50c8ec2c8e2682091b on peterbrittain:master.


[Inline Suggestions] Support accepting suggestions that are not on tab-stops

Currently, when we display indented inline suggestion, the user needs to tab until the cursor is at the same location as the beginning of the text in the inline suggestion.
This however is problematic if the suggestion is not exactly at the tab stop point (for example tab is set to 4 spaces in editor setting but displayed suggestion is on 6 spaces indentation) - it means users are often accidentally dismissing suggestion (by moving the cursor past suggestion). The workaround from a user point of view is that they need to use space to move the cursor precisely to the location of ghost text, however it's not super discoverable/obvious to users
I could potentially see 2 solutions here:

If the user press tab in a situation where it would move the cursor past suggestion, insert only as many spaces as required to put the cursor at the suggestion (from my earlier example - insert only 2 spaces, to put the cursor at 6 spaces), and next tab would accept suggestion normally.
Or, if the tab would move the cursor past the suggestion, accept the suggestion.

CC: @hediet

Here's a user submitted video of this behavior:
https://user-images.githubusercontent.com/26822551/126787880-500f6faf-5e41-4cdf-97e2-4ecb85213086.mp4
@hediet I think this is high priority as we've had reports of people quitting Copilot over this issue.

I think in both cases the user experience as shown in @orph's video is not very nice - the user has to press tab very often until the suggestion is being accepted.

This is an early copilot iteration I think we nailed actually - pressing tab enough times to "meet" the insertion is learnable. Whereas if we just accept the current indented suggestion on Tab, it would not allow you to create a different indent from what the AI suggests.

Here's another test case I just experienced - insert a space at the start of the suggestion, and Tab never accepts the suggestion. It's always off-by-one. I think this is the base case that the first video demonstrates.
https://user-images.githubusercontent.com/28068/136679670-a5afaaa9-6be4-49df-a695-84ccd30a1c09.mov

Or is the choice about what the Tab key should do made at an earlier stage that makes it hard for it to both?

Yes, currently the command "accept inline suggestion" is bound to tab (potentially override the "insert tab character" command), but only active if the suggestion does not start with whitespace.
But I just got an idea:
"accept inline suggestion" could be active (overriding the default tab command) if and only if the suggestion starts with an indentation that is less than tab-width.

Sorry for the delay - we were very busy with Universe last week.
I've had a play with Insiders versus the current release and it seems to behave better on one example we originally saw with Copilot, but I'm having trouble characterising exactly what was wrong before and whether it's gone now. In one example a closing } still jumps around quite a bit in ways I can't quite predict.
@orph @Krzysztof-Cieslak could you take a look too?


Verify nft minting with did example

https://docs.chia.net/guides/nft-cli#mint-an-nft-with-did

verified this guide is accurate


[android] check source prop if changed

Asana: https://app.asana.com/0/0/1202892952549803/f
Add some logic to check if the source map has changed. If it has changed, reload the url. If it hasn't, do nothing.
While this logic could possibly extended for webviews without a webViewKey, it may not be desired - (i.e perhaps say the source uri changes to the current url loaded by the webview (perhaps through redirects) - for that case, you wouldn't want to reload the page)

How are we verifying the correctness of these changes? Have these been tested in the Discord app, or is there a manual test case we can add to the react-native-webview sample app for testing this?

I verified this in the sample app, by modifying the source prop (via hot-reload) and seeing whether or not the webview would reload or not.
Also, by teleporting from blue to green, the view is remounted, and the webview did not reload the page (as expected)

I verified this in the sample app, by modifying the source prop (via hot-reload) and seeing whether or not the webview would reload or not.
Also, by teleporting from blue to green, the view is remounted, and the webview did not reload the page (as expected)

Great! That seems like a sufficient test to me.

I can add a test case inside the sample app where it modifies the source prop - do you think that would be valuable?

It could be valuable. Feel free to add it if you like. It's also fine if you don't add it, since I think the other manual test you described is enough


Improve scrolling actions in the animation track editor

3.x version of https://github.com/godotengine/godot/pull/48598.

Implement timeline scrobbling using Alt + Mouse wheel anywhere in the animation track editor.

Snap settings are followed, and precise snapping can be obtained by also holding down Shift.
This modifier wasn't used by anything in the animation editor.

Allow zooming by using Ctrl + Mouse wheel on the timeline itself.

Previously, this was only possible on the track area, not the timeline.

Thanks!


fix-documentation-error-in-yml-base_ga4__events

Description & motivation

Checklist

[x] I have verified that these changes work locally
[x] I have updated the README.md (if applicable)
[x] I have added tests & descriptions to my models (and macros if applicable)
[x] I have run dbt test and python -m pytest . to validate existing tests

@adamribaudo-velir any chance you can tag a release with this fix? Running locally causes errors on the latest available tagged release.

If you want, you can use this release by placing this in your packages.yml file instead of the normal install code.
packages:
  - git: "https://github.com/Velir/dbt-ga4"
    revision: d42e18ba07ae53838fe299093e999d3c47fb3b41


PO file which is ISO-8859-1 coded is converted to UTF-8 at saving with 1.8.11

The attached PO file is iso-8859-1 coded and has some German umlauts in the msgid strings. The coding for content and source is set to iso-8859-1 in the header section. The file worked great with poedit 1.6.7.
With latest poedit 1.8.11 the file has following issue:
When I open the PO file and use File->Compile to MO... everything is fine. The compiled MO file is iso-8859-1 coded.
But when I use File->Save the PO file is converted to UTF-8 although it was not modified. And the automatically compiled MO file is UTF-8 then too.
The PO file coding is shown correct as iso-8859-1 in the Catalogue properties.
Open the PO file again respects the unchanged header coding information as the umlauts are represented by 2 characters then (the 2-byte UTF-8 codes). The file is not interpreted as UTF-8.
poiso.po.txt

Thanks for the detailed report and a test case!

Not at all! Thank you for your great support.


[BUG FsSpreadsheet.Exceljs] ClosedXml files cannot be read from exceljs

Test is commented out in tests/JS/Exceljs. Never open the TestFiles and save them afterwards.

Not directly about the issue but about the wording: ClosedXML is a library that uses OpenXML, as we do. But we do not have anything to do with ClosedXML, so it'd be better to get rid of their name here before any misunderstandings happen. 😅
@Freymaurer

No it is on purpose. We should thrive to suppot read in of files produced by openxml/closedxml/exceljs

In tests/JS/Exceljs:
// TypeError: Cannot read properties of undefined (reading 'company')
it('ClosedXml.Table', async () => {
    const path = "tests/JS/TestFiles/ClosedXml.Table.xlsx";
    const fswb = await Xlsx.fromXlsxFile(path)
    let worksheets = fswb.GetWorksheets()
    equal(worksheets.length, 1)
});


feat(6222): remove @ and project from OIDC client ID

Which Problems Are Solved
The client ID for OIDC applications has an @ in it, which is not allowed in some 3rd-party systems (such as AWS).
How the Problems Are Solved
Per @fforootd and @hifabienne in #6222, remove the project suffix and the @ from the client ID and just use the generated ID.
Additional Changes
N/A
Additional Context

Closes #6222

I have also done some basic searching and changing of the documentation. Let me know if you'd like me to add that commit to this PR or create a new one (either concurrently or after this one is closed out).

I have also done some basic searching and changing of the documentation. Let me know if you'd like me to add that commit to this PR or create a new one (either concurrently or after this one is closed out).

Oh good call 😁
Let us assign somebody to this PR and come back to you

@btajuddin I will review PR in the next days. Just had a quick look and one question:
Will clients that used the old format still work?

Will clients that used the old format still work?

They should. This change only affects the creation of new clients and should allow existing clients with the old format to continue working. I think that's going to be the tricky part when it comes to the documentation. The docs should probably reflect the new format, but we might want a note about the old format so that people don't leave the @<project> off when they see the docs without it.
Also, I fixed the two failing e2e tests.

@btajuddin and @muhlemmer
Looks good to me, I approved the PR, thanks for the contribution


wmma: clean up the TC alias pattern and remove TC=2 behavior

other than the removal of the TC=2 behavior, all other behavior and performance should be the same

I think we keep TC=2 behavior for now, it's a mid step for debugging TC. Also you really want to remove it you will need update the github action too

SGTM!


Fixed : Disable Submit Button

Proposed Changes

Fixes #9501
Submit button remains disabled until form fields are modified

https://github.com/user-attachments/assets/1bf15b34-ad1e-47e4-836e-b4cdd103fcd2
@ohcnetwork/care-fe-code-reviewers
Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

Summary by CodeRabbit

New Features

Introduced new dependencies for enhanced form functionality and internationalization.
Improved form state management and validation through updated logic.
Enhanced error handling during form submission.

Bug Fixes

Resolved issues related to form state resetting and validation checks.

Documentation

Updated import statements and component usage for clarity.

@rithviknishad Implemented without using lodash

@rithviknishad Used Shadcn Form and added form.tsx

no longer relevant in new architecture as we are using shadcn's form with react hook form


geth settings recommendation

A simple recommendation tag/fold-out for geth settings recommendations.

Available on latest commit.


Rotation issues in UIStackView - iPad

I have an FSCalendar component and a UITableView within a vertical UIStackView.  It was setup using Interface Builder.  The stack view is set to fill equally, and I have constraints that pin the height and width of the FSCalendar and UITableView to be equal.  The calendar renders fine on initial load.  However, once the device rotates, the layout of the calendar is all messed up.  The month header at the top becomes off-center and swiping from month-to-month reveals that the day layout is also completely messed up.
I've tried implementing func calendar(_ calendar: FSCalendar, boundingRectWillChange bounds: CGRect, animated: Bool) within my FSCalendarDelegate (as is mentioned on the project home page), but this method is never called.
I'd assume this is a bug within FSCalendar, but I don't know of a workaround to address this behavior.  Thoughts?

UPDATE:
I found a mention to overriding func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) as a potential workaround to this issue.  My implementation looks looks like this:
override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
    super.viewWillTransition(to: size, with: coordinator)

    coordinator.animate(alongsideTransition: { (UIViewControllerTransitionCoordinatorContext) in
        self.calendar?.reloadData()
    }, completion: nil)
}

At this point, the date cells themselves are rendered properly.  However, the month header at the top of the calendar remains incorrect.  I don't know if this helps diagnose the issue or not, but it does change the behavior.

I had the same issue and added calendar programmatically in view. I resolved it with calendar.adjustMonthPosition()
override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
        super.viewWillTransition(to: size, with: coordinator)
        coordinator.animate(alongsideTransition: nil) { (_) in
            self.calendar.reloadData()
            self.calendar.adjustMonthPosition()
        }
    }

I have the same issue, the viewWillTransition that was suggested fixed the days but the header is off center and the year shows 2035.

@keithmichelson I have exactly the same issue, did you find a fix? I am manually setting the frame of the calendar.

I had the same issue. There seems a bug in FSCalendarHeaderView.m's method

(void)configureCell:(FSCalendarHeaderCell *)cell atIndexPath:(NSIndexPath *)indexPath

I my case, this enhancement fixed this problem. But its ... creepy!
    override func viewWillTransition(to size: CGSize,
                                     with coordinator: UIViewControllerTransitionCoordinator) {
        super.viewWillTransition(to: size, with: coordinator)
        coordinator.animate(alongsideTransition: nil,
                            completion: { transitionCoordinatorContext in
                                self.calendarView.reloadData()

                                /* HACK: force reload of calendarHeaderView to show correct
                                 month and year after a rotation. Terrible! */
                                self.calendarView.scrollDirection = .vertical
                                self.calendarView.scrollDirection = .horizontal
        })
    }

@ricsantos Does this work for you?

An Update:
This bug could be related to https://github.com/WenchaoD/FSCalendar/issues/782
In other words: with UIRequiresFullScreen = true the info.plist I don't need to override viewWillTransition().


Epic: Addresses & Keys Changes

Following several rounds of discussions and decisions, here's a list of tasks relating to changes to addresses & keys.
### New address scheme
- [ ] Write an eng design doc for the new address scheme. Liaise w/ other teams (esp AVM).
- [ ] Implement the new address scheme across the stack

### Keys
- [ ] Don't app-silo viewing keys anymore (neither incoming nor outgoing)
- [ ] Remove code relating to key rotation
- [x] Remove the key registry

### Plume
- [ ] Liaise w/ Crypto Research to ensure security of approach for Plume w/ Grumpkin & Posiedon2
- [ ] Run the latest flamegraph of the reset private kernel circuit, to determine the constraint counts for one key validation request. Compare it against 3300 for plume.
- [ ] Implement an example flow of using plume nullifiers.
- [ ] Fun: Explore how to add Grumpkin ops as an 'app' on Ledger hardware wallets.

The key registry was removed in #8613, and key rotation was then fully removed in #8645.

Marking plume and internal incoming keys as p1 (i.e. post testnet)


Rename DateFilter to DateTimeFilter

PR Checklist

[x] Verify if the change requires a changeset. See CONTRIBUTING.md
[ ] Link to the respective task if one exists:
[ ] Provide screenshots/screencasts if the change contains visual changes

Screenshots/screencasts

Would you be willing to write a (rather simple) upgrade script for this?

Yes

Would you be willing to write a (rather simple) upgrade script for this?

Yes

https://github.com/vivid-planet/comet-upgrade/pull/14


Gene YCR024C should have uniprot identifier P25345 uniprot identifier not P32903

I was going through the model in cobrapy and doing some sensibility checked.
And I noted their were 1161 unique uniprot identifers, but 1162 unique gene ids.
So i went looking closer to see what was going on
and I see that YCR024C and  YCR024C-A
are both listed as linked to P32903
And as far as i can tell only the latter ( YCR024C-A) should have that tag
and instead the former (YCR024C) should have P25345, which is not currently present in the model at all.
The relevant section of the SBML is:
<fbc:geneProduct metaid="YCR024C" sboTerm="SBO:0000243" fbc:id="YCR024C" fbc:label="SLM5">
  <annotation>
    <rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:dcterms="http://purl.org/dc/terms/" xmlns:vCard="http://www.w3.org/2001/vcard-rdf/3.0#" xmlns:vCard4="http://www.w3.org/2006/vcard/ns#" xmlns:bqbiol="http://biomodels.net/biology-qualifiers/" xmlns:bqmodel="http://biomodels.net/model-qualifiers/">
      <rdf:Description rdf:about="#YCR024C">
        <bqbiol:is>
          <rdf:Bag>
            <rdf:li rdf:resource="https://identifiers.org/uniprot/P32903"/>
          </rdf:Bag>
        </bqbiol:is>
      </rdf:Description>
    </rdf:RDF>
  </annotation>
</fbc:geneProduct>
<fbc:geneProduct metaid="YCR024C__45__A" sboTerm="SBO:0000243" fbc:id="YCR024C__45__A" fbc:label="PMP1">
  <annotation>
    <rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:dcterms="http://purl.org/dc/terms/" xmlns:vCard="http://www.w3.org/2001/vcard-rdf/3.0#" xmlns:vCard4="http://www.w3.org/2006/vcard/ns#" xmlns:bqbiol="http://biomodels.net/biology-qualifiers/" xmlns:bqmodel="http://biomodels.net/model-qualifiers/">
      <rdf:Description rdf:about="#YCR024C__45__A">
        <bqbiol:is>
          <rdf:Bag>
            <rdf:li rdf:resource="https://identifiers.org/uniprot/P32903"/>
          </rdf:Bag>
        </bqbiol:is>
      </rdf:Description>
    </rdf:RDF>
  </annotation>
</fbc:geneProduct>

Will get this fixed. For sanity, we'll check all UniProt IDs.


Update windows_web_http.md

Test autoassignment.
Please do not change or merge.

@MancunianBandit : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


⚠ SolarOscp has degraded performance

In 89971fc, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 323 ms

Resolved: SolarOscp performance has improved in 18dd143 after 10 minutes.


Simplify option validation

If I understand it right the following code checks that we have a comma-separated list of "valid" options where at least 1 option needs to be provided and a option is valid if it starts with a letter (lower or uppercase) followed by at least one letter / number / "." / "_" or a single "*" without anything else. Also the commas can be surrounded by arbitrarily many spaces. Also an option must not be empty.
https://github.com/GIP-SmartMercial/xyna-xacm/blob/ce49c88809984bc3e4f1cdd4dfcc962b0e25813b/xo/xo-right-parameter.model.ts#L116-L129
Using a RegExp causes an https://github.com/GIP-SmartMercial/xyna-modeller/security/code-scanning/27.
Also the filter and map are probably mixed up because !!'    ' returns trueduring the filter´-step but will be converted to '' during the map-step which would have been considered false during filtering.

Also, I don't know if this is on purpose, but the current implementation allows options like *OG because the "comma-part" inside the regexp also has multiplicity 0. This is also the reason why ob* is considered a valid option because ob is a valid option and * is a valid option. ob* doesn't match with /([a-zA-Z][a-zA-Z0-9._]+|[*]{1})/.


BUG - Double ? in start task

Related Feature
Feature request: (https://github.com/SAP/open-ux-tools/issues/271)
Description
This PR https://github.com/SAP/open-ux-tools/commit/030f490b6bbf0ed89a1a8ec6625af4879ff2ab78 has introduced an error in the package json start script when a client value is provided. It now adds 2 query param delimiters '?':
 "start": "fiori run --open 'test/flpSandbox.html??sap-client=012&sap-ui-xx-viewCache=false#felrop1-tile'",
Steps to Reproduce
Generate a Fiori Freestyle app providing a client value via the service interface.
Expected results
The correct single '?' is used.
Actual results
 "start": "fiori run --open 'test/flpSandbox.html??sap-client=012&sap-ui-xx-viewCache=false#felrop1-tile'",
Screenshots
If applicable, add screenshots to help explain the problem.
Version/Components/Environment
Add any other context about the problem here
OS:

[x] Mac OS
[x] Windows
[ ] Other

Root Cause Analysis
Problem
{describe the problem}
Fix
{describe the fix}
Why was it missed
{Some explanation why this issue might have been missed during normal development/testing cycle}
How can we avoid this
{if we don’t want to see this type of issues anymore what we should do to prevent}

fyi: @slin-sap

Thx for the fix @slin-sap


node_vms_folder value seems to be handled differently between vcp-manager and vcp-daementset

Set node_vms_folder in the vcp_secret.yaml to '/Development_VMs/Kubernetes'
The VMs working folder starts out as: /SCT/vm/Development_VMs/
When the vcp-manager pod runs it creates the vms folder relative to /SCT/vm/
Creating: /SCT/vm/Development_VMs/Kubernetes
When the daemonset runs it fails with:
+ govc object.mv -dc=SCT /SCT/vm/Development_VMs/my-vm-name-snipped /Development_VMs/Kubernetes
+ '[' 1 -eq 0 ']'
+ ERROR_MSG='Failed to move Node Virtual Machine to the Working Directory Folder'
+ update_VcpConfigStatus vcp-daementset-d68xg '[PHASE 3] Move VM to the Working Directory' FAILED 'Failed to move Node Virtual Machine to the Working Directory Folder'

I connect to the pod to try the govc command given above and get as expected:
govc: folder '/Development_VMs/Kubernetes' not found
I have also tried the above by removing the prefixing forward slash which fails in a similar way and by giving the full path which cause the vcp-manager to try to create the folder:  /SCT/vm/SCT/vm/Development_VMs/Kubernetes
Docker image pulled was:
REPOSITORY                    TAG                 IMAGE ID            CREATED             SIZE
cnastorage/enablevcp          v1                  bf7b5e183363        5 weeks ago         534MB

I worked around this issue by setting the value to '/Development_VMs/Kubernetes' when initially creating the vcp-manager pod. Letting the daemon sets fail. Changing the value to '/SCT/vm/Development_VMs/Kubernetes' and reapplying the secret. Then deleting the vcp-daementset pods.

I want to indicate that I as well have observed the same behavior, and the same workaround seems to work as well. It's cumbersome to work through, but is possible to get through this phase with this workaround.


How about rewriting this to allow dependency injection?

I love what you've done here, but I find myself not wanting to use it because it doesn't allow dependency injection. Quite a bit of flexibility is lost by hardcoding repository behavior as static methods. For example, the code gets convoluted if we want a function that acts on any model conforming to a particular interface. Suppose I want to generically act on any of several similar tables? Or suppose I want to generically act on either of two databases? Or suppose I want to stub a table for testing purposes?
I've written several servers that rely on statics to access the underlying database, as you've done here, but I'm now finding that this is not how large scale applications are written. I recently decided to abandon this approach and do things the modern way.
Do you have any interest in rewriting this to put repository behavior on instance methods? I'd be glad to help or even do it all. This would require revising the approach to mixins.

Then you can use kysely directly for this purpose.


"Show Proof" opens an empty new tab

VSCode opens a new empty tab "Untitled-n" and the cursor blinks at the beginning of the new tab

This is strange - it might be because when you tried this functionality, the LSP server had already crashed because of other issues, and was not there to provide the proof.
I'd suggest to try this again on an error-free set.mm or when crash issues are solved...


Error while merging dex archives

I get the following error with the latest plugins while building android version:
Error while merging dex archives:
D8: Program type already present: android.support.v4.app.FrameMetricsAggregator$FrameMetricsApi24Impl$1
apparently its caused by duplicate classes as explained in the log message with an invitation to "Learn how to resolve the issue at " https://developer.android.com/studio/build/dependencies#duplicate_classes
If I remove cordova-plugin-firebase-messaging the build is  always OK. But keeping cordova-plugin-firebase-messaging, I have tried to remove other plugins but always get similar "Error while merging dex archives". However with different details:
D8: Program type already present: android.arch.core.util.Function
D8: Program type already present: android.support.v4.content.FileProvider$SimplePathStrategy
D8: Program type already present: android.support.v4.app.FrameMetricsAggregator$FrameMetricsApi24Impl$1
The other plugins that I am using:
cordova-plugin-device
cordova-plugin-file
cordova-plugin-actionsheet
cordova-plugin-file-transfer
cordova-plugin-geolocation
cordova-plugin-inappbrowser
cordova-plugin-network-information
cordova-plugin-splashscreen
cordova-plugin-vibration
cordova-plugin-badge
cordova-plugin-whitelist
phonegap-plugin-barcodescanner
cordova-plugin-contacts
cordova-plugin-calendar
cordova-plugin-geolocation
cordova-plugin-dialogs
cordova-plugin-buildinfo
cordova-plugin-android-permissions
uk.co.workingedge.phonegap.plugin.launchnavigator
cordova plugin add cordova-plugin-googlemap
cordova-plugin-firebase-messaging

did you found any answer for this ?

In my case it is AppLaunchChecker which is already present:
Program type already present: android.support.v4.app.AppLaunchChecker
cordova-support-google-services
cordova-support-android-plugin
cordova-plugin-whitelist
cordova-plugin-statusbar
cordova-plugin-splashscreen
cordova-plugin-ionic-webview
cordova-plugin-ionic-keyboard
cordova-plugin-firebase-messaging
cordova-plugin-device
Ionic:    ionic (Ionic CLI)  : 4.12.0 (C:\Users\hugob\AppData\Roaming\npm\node_modules\ionic)    Ionic Framework    : ionic-angular 3.9.5    @ionic/app-scripts : 3.2.2
Cordova:    cordova (Cordova CLI) : 9.0.0    Cordova Platforms     : android 8.0.0    Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.0.1, (and 7 other plugins)
System:  (C:\Users\hugob\AppData\Local\Android\android-sdk)    NodeJS            : v10.15.3 (C:\Program Files\nodejs\node.exe)    npm               : 6.4.1    OS                : Windows 10

Hello, I had the same problem. I do not know exactly why, but what happens is that he has conflicting dependencies. In the declaration, you specify the constants like this:
"cordova-plugin-firebase-messaging": {
         "ANDROID_SUPPORT_VERSION": "26.1",
         "FIREBASE_CORE_VERSION": "16.0. +",
         "FIREBASE_MESSAGING_VERSION": "17.6. +"
},

Specifically this constant. That fixed the mistake for me.
"ANDROID_SUPPORT_VERSION": "26.1"
Apparently, the gradle tries to validate the installed dependencies. This conflicts with the dependencies of the firebase, in particular.

@danielprrazevedo solution didn't fix the problem in my case.
I've got the same error as @vuaridel :
D8: Program type already present: android.support.v4.app.FrameMetricsAggregator$FrameMetricsApi24Impl$1
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:transformDexArchiveWithExternalLibsDexMergerForDebug'.

com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives:
Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes.
Program type already present: android.support.v4.app.FrameMetricsAggregator$FrameMetricsApi24Impl$1

I tried it one more time doing this (as @danielprrazevedo instructed in issue #82 ):
cordova plugin add cordova-plugin-firebase-messaging --variable ANDROID_SUPPORT_VERSION=26.1
Worked like a charm. Thanks

cordova plugin add cordova-plugin-firebase-messaging --variable ANDROID_SUPPORT_VERSION=26.1
HELP!! This option manages to make my project compile but when the notification arrives the app closes

Javier, the problem is in the FirebaseMessagingPluginService.java file, on line 54. It is trying to get the color resource using deprecated code. You can either update it or remove the OR value so that it uses the default value only. I tested that if you do so, it receives the pushes correctly and doesn't crash.

@Javieralonso18 @StevenRodz I've removed deprecated code in https://github.com/chemerisuk/cordova-plugin-firebase-messaging/commit/2a47608bf3b4bbab89599e70afe9346c1ccaaf0e. Do you mind to modify the file locally on your side and verify if it fixes you crash.

@chemerisuk I have tested in a samsung s9 with android 9.0 and still it goes out error and the notification is not shown, it is possible to stand out that the solution of @StevenRodz solved my problem and works correctly.

The issue I believe is that since we did not define the default color in the config, it cannot match the ID to the resource, and fails. I just updated the "getColor" method and added a try/catch for the resource. Seems to work fine. The final edit I made was as follows:
In the FirebaseMessagingPluginService.java, the OnCreate method:
public void onCreate() {
this.broadcastManager = LocalBroadcastManager.getInstance(this);
this.audioManager = (AudioManager) getSystemService(Context.AUDIO_SERVICE);
this.notificationManager = (NotificationManager) getSystemService(Context.NOTIFICATION_SERVICE);
this.defaultSoundUri = RingtoneManager.getDefaultUri(RingtoneManager.TYPE_NOTIFICATION);
Context context = getApplicationContext();
    try {
        ApplicationInfo ai = getPackageManager().getApplicationInfo(getApplicationContext().getPackageName(), PackageManager.GET_META_DATA);
        this.defaultNotificationColor = 0xFF000000;

        try{
            this.defaultNotificationColor = ContextCompat.getColor(context, ai.metaData.getInt(NOTIFICATION_COLOR_KEY));
        }
        catch(Resources.NotFoundException e){
            Log.e(TAG, "Failed to find resource", e);
        }

        if (this.defaultNotificationIcon == 0) {
            this.defaultNotificationIcon = ai.icon;
        }
    } catch (PackageManager.NameNotFoundException e) {
        Log.e(TAG, "Failed to load meta-data", e);
    }
}

@StevenRodz can you test code below:
 try {
            ApplicationInfo ai = getPackageManager().getApplicationInfo(getApplicationContext().getPackageName(), PackageManager.GET_META_DATA);
            this.defaultNotificationIcon = ai.metaData.getInt(NOTIFICATION_ICON_KEY, ai.icon);
            this.defaultNotificationColor = ContextCompat.getColor(this, ai.metaData.getInt(NOTIFICATION_COLOR_KEY));
        } catch (PackageManager.NameNotFoundException e) {
            Log.e(TAG, "Failed to load meta-data", e);
        } catch(Resources.NotFoundException e) {
            Log.e(TAG, "Failed to load notification color", e);
        }

Only color read logic can throw an exception I think.

Well, I no master, I could be wrong. What I did was go to the documentation and found this:
https://developer.android.com/reference/android/support/v4/content/ContextCompat.html#getColor(android.content.Context, int)
where the Exception thrown is "Resources.NotFoundException", which at least matches the problem I was getting when it crashed. Let me know if I am wrong. I like to learn...

@StevenRodz you are correct. We read 2 default values here: color and icon. The line below tries to read iconId from metadata and fallbacks to application icon (without exception in any case):
this.defaultNotificationIcon = ai.metaData.getInt(NOTIFICATION_ICON_KEY, ai.icon);

Only ContextCompat.getColor can throw an exception, but it's the last one.
Just pushed a6897cd16e70b2765131da14e7bf4406b53b746a, please try to update and let me know if it works for you.

Just tested it. Works great! Thanks for your help!

Bugfix published in v2.1.1

@chemerisuk is working correctly, a query use this plugin along with the remote configuration and I see this dex error, there was some way to work without the --variable ANDROID_SUPPORT_VERSION = 26.1

I ran it using:
cordova plugin add cordova-plugin-firebase-messaging --variable ANDROID_SUPPORT_VERSION=26.1 --variable FIREBASE_CORE_VERSION=16.0.+ --variable FIREBASE_MESSAGING_VERSION=17.6.+
And it runs fine, try it to see if it helps.

v2.1.1 did not solve the problem for me ... same error...
With cordova plugin add cordova-plugin-firebase-messaging --variable ANDROID_SUPPORT_VERSION = 26.1 I can build the app successfully, but then I get an error when I quit the method cordova.plugins.firebase.messaging.requestPermission()
If I add "{forceShow: [" alert "," sound "," badge "]}" to the method "requestPermission", it works....

@PIXPOINT try v2.1.2, forceShow is a boolean now and no error thrown when it does not exist.

Execution failed for task ':app:transformDexArchiveWithExternalLibsDexMergerForDebug'.

com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives:
Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes.
Program type already present: com.google.zxing.DecodeHintType

i have the same error, when i install the barcode native ionic plugin
can u pls help me

I have a similar error when I install cordova-plugin-firebase-messaging and no error when its removed:

com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives:
Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes.
Program type already present: android.support.v4.os.ResultReceiver$MyRunnable

Note that the to resolve such issue with:
D8: Program type already present: android.support.v4.os.ResultReceiver$MyRunnable
you can find info on
https://developer.android.com/studio/build/dependencies#duplicate_classes

Hi,
in fact In have the same error error as well and fond in other issues:
that one should install:
cordova-plugin-firebase-messaging
cordova-plugin-androidx
cordova-plugin-androidx-adapter
cordova-plugin-firebasex
and it compiled. So not ask me why!
Best regards
Bertrand
On 02.10.19 03:42, Yawn2323 wrote:

Execution failed for task
':app:transformDexArchiveWithExternalLibsDexMergerForDebug'.
com.android.builder.dexing.DexArchiveMergerException: Error while
merging dex archives:
Learn how to resolve the issue at
https://developer.android.com/studio/build/dependencies#duplicate_classes.
Program type already present: com.google.zxing.DecodeHintType

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chemerisuk/cordova-plugin-firebase-messaging/issues/81?email_source=notifications&email_token=ACI4DJUC7LYW24462N6KMD3QMP4A7A5CNFSM4HK3RJX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADIV4I#issuecomment-537299697,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACI4DJSL77Y5FVY4QHGCOJTQMP4A7ANCNFSM4HK3RJXQ.

--
Bertrand Vuaridel
email:
<EMAIL_ADDRESS><EMAIL_ADDRESS>director
ARTEGIS https://www.artegis.com
web:
https://www.artegis.com
information:
<EMAIL_ADDRESS><EMAIL_ADDRESS>Chemin du Vallon 18
support:
<EMAIL_ADDRESS><EMAIL_ADDRESS>CH 1260-Nyon
Switzerland

@vuaridel man, this works. make no sense.
Best regards
Allan Batista

@vuaridel work like a charm, don't know why ^^

thanks
@vuaridel
and good luck
cordova-plugin-androidx
is fixing my problem


Alert users when a project can't be read

Summary
When a project is deleted from disk, it will be silently removed from Guppy.
In many cases, this behaviour is fine; if the user deletes it with Finder/Explorer, it should naturally also disappear from Guppy. But given that this app is targeted at beginners, it might be good to throw a notice prompt up:
Project deleted

Your projects Thing 1, Thing 2, and Thing 3 were deleted from disk, and have been removed from Guppy.

Implementation
The code that manages this is in read-from-disk.service, under loadGuppyProjects:
Right now we're silently swallowing these errors.
We could throw a prompt right there in the .catch, but that would mean 1 prompt for every deleted project. If the user deletes 10 projects, that's a lot of prompts!
Instead, we want to bubble those errors in with the results. So if we're loading 5 projects and 2 were deleted, the value passed to results might look like this:
[ project1Json, Error, Error, project4Json, project5Json]

We should split loadGuppyProjects up into a couple functions; one to parse the disk and return results, and then another to build a valid projects object out of it.
Here's the flow I imagine, in refresh-projects.saga.js:
const pathsArray = yield select(getPathsArray);

const projectsFromDisk = yield call(loadGuppyProjects, pathsArray);
// This will now be that array of mixed JSON and errors

const deletedPaths = /* some method that finds the paths in `pathsArray` that produced errors */

if (deletedPaths.length > 0) {
  const deletedProjectNames = /* some method that converts deletedPaths to projectNames */

  const message = /* some method to build up a nice error message, taking into account the number of projects for proper grammar */

  dialog.showMessageBox({...});
}

As a bonus, this would set us up well to handle other types of errors when loading projects.

hey there @joshwcomeau ! 👋 really like what you’re doing with guppy and would be happy to lend a hand. if no one’s claimed this i’d love to take a crack at it

@joshwcomeau thanks! i'll have a better chance to take a closer look at the everything you've sent sometime this evening.
excited to start helping!

hi @leo-generali!
Just a quick check-in. No rush if you're still interested in doing this but just haven't had the time :) I just wanna make sure you're not stuck or blocked on something, and that you still intend to work on it.
Thanks!

hey @joshwcomeau! sorry for the delay on my end - i foolishly asked to pick this up a few days before i moved across the country thinking i could get this done quickly... clearly that didn't happen hah. things have settled down on my end and i'm planning on having something out for review over the next few days! hope that's all right!!

Hey Leo, that’s no problem at all! Thanks for the update, hope moving went well!

On Sep 24, 2018, at 11:54 AM, Leo Generali<EMAIL_ADDRESS>wrote:
hey @joshwcomeau! sorry for the delay on my end - i foolishly asked to pick this up a few days before i moved across the country thinking i could get this done quickly... clearly that didn't happen hah. things have settled down on my end and i'm planning on having something out for review over the next few days! hope that's all right!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I started playing with it and have the basic logic working, but still need to write tests, comment and improve the code before being able to open a Pull Request for it.
@leo-generali are you OK with me continuing working on this? No problem if you are not, I already had a lot of fun implementing it :) I can also share my solution with you if you want to continue from there, didn't push it yet cause the code is still far from ideal (but it works).

hey @menor!
for sure! i was able to get about half way and then life took over. if you’ve got a solution by all means please take over for me. if you want to tag me in the PR i’d love to see how you did it 😃

Thanks :) I will start cleaning it tomorrow then
Will tag you in the PR then once it's ready.

Ok, I have been working on this and it works, but I still need to rewrite the tests for the sagas and improve the message in the alert box (handle plurals)
The thing is before continuing with it, I would like to know if this fits the idea @joshwcomeau commented in the OP. I opened a PR in my fork so you can see the changes more easily.
https://github.com/menor/guppy/pull/1/files
loadGuppyProjects calls now loadPackageJson, catches the errors and filters those related to the file not being in the disk, then it returns the array with the mixed type of Errors and Projects.
The refresh-projects.saga gets this Array and splits it into validProjects and Errors, I get the folder name of the project from the Error using a Regex and show the alert box.
I've been thinking about it and if instead of returning the Errors, Projects array from loadPackageJson we return a 'tuplish' array in the form [[Error, Error],[Project, Project]] we don't need to split it later again. If we make loadPackageJson take the project name as an argument in addition to the project path, we also remove the need to use the regex later.
Please let me know wha tyou think since I'm not sure if this is a good idea at all, this is my first contact with this codebase, and this will probably break loadPackageJson in other parts, but just couldn't keep it to myself 😄
No need to comment on anything else, since I will fix the tests (once I learn how to test sagas) and make a proper PR once that is done.
Thanks for the awesome project, all the comments in the code, made it really easy to understand what was going on.


Cache cds-service definitions

Cache service definitions
3-4x speedup for cds-hooks calls

@sliver007 reviewed offline.


Use coredns for a common/1.8 provider

Coverage increased (+0.3%) to 43.008% when pulling 32168822e4572ee9af5b05d248a278747b51577f on saheienko:add_coredns_sg1.0 into b3e6713a71f15dda22b22921d9a1b6d25facc584 on supergiant:release-1.0.


[Bug]: PaintingEditor's onImageEditingComplete returns the previously "undo/undone" element instead of the latest drawing

Package Version
5.4.1
Flutter Version
3.24.0
Platforms
Android, iOS, Web
How to reproduce?
Hi, thanks for this awesome package. However, I encountered an issue with the PaintingEditor
I replicated this on Android and iOS when we used PaintingEditor.memory on our project. Checked on the demo website if it is actually an issue and it exists on the demo web app.
Steps:
Web

Go to the demo website
Click "Signature or Drawing"
Click either "Signature" or "Drawing"
Draw anything (ex. circle)
Click "Undo"
Draw anything again (ex. a line)
Click the check button
Notice that the result is the one drawn previously (the one you draw on Step 4 above, circle)

Logs (optional)
No response
Example code (optional)
No response
Device Model (optional)
No response

Thanks for reporting that issue with detailed reproduction steps. I've just released version 5.4.2, which should resolve it.

Thanks for reporting that issue with detailed reproduction steps. I've just released version 5.4.2, which should resolve it.

Thank you for your quick response. I hope to contribute to this package someday.


Add ready event

Added a "ready" event emission after the underlying leaflet object is made available. I did this to more closely match general vue2-leaflet component behavior, particularly the LFeatureGroup component as leaflet-marker-cluster plugin extends feature group.  Here is the link to the matching code.

Sorry for not merging or commenting, I'm trying to get some time for this, maybe this weekend. And thanks for taking the time to make the PR.

@jperelli Any news on this one?

Thanks again for the PR, I'm merging it now and publishing a new version to npm (v3.1.0)


add config for energy amount

Describe your enhancement
add a configurable amount of energy that the device can hold

Already exists. Make sure to check server configs not just the normal config folder.


Lookahead streaming support?

Feature request
From what I understand, streaming dataset currently pulls the data, and process the data as it is requested.
This can introduce significant latency delays when data is loaded into the training process, needing to wait for each segment.
While the delays might be dataset specific (or even mapping instruction/tokenizer specific)
Is it possible to introduce a streaming_lookahead parameter, which is used for predictable workloads (even shuffled dataset with fixed seed). As we can predict in advance what the next few datasamples will be. And fetch them while the current set is being trained.
With enough CPU & bandwidth to keep up with the training process, and a sufficiently large lookahead, this will reduce the various latency involved while waiting for the dataset to be ready between batches.
Motivation
Faster streaming performance, while training over extra large TB sized datasets
Your contribution
I currently use HF dataset, with pytorch lightning trainer for RWKV project, and would be able to help test this feature if supported.

In which format is your dataset? We could expose the pre_buffer flag for Parquet to use PyArrow's background thread pool to speed up loading.


Search as URL parameter

Search as URL parameter (for https://containers.dev/features and https://containers.dev/templates)

Hi there! Could you expand a bit on what you're interested in? Additionally, we'd certainly welcome a PR contributing the change(s) you have in mind!

I am on phone right now, sorry for the mobile PC emulation screenshot
For example, the link https://containers.dev/features?search="test" will directly open this page with the "test" search parameter :

Thanks for clarifying! I think that change makes sense! If you'd be willing to contribute a PR, we'd absolutely welcome it 😄

@bamurtaugh done

Znc.in


[I/O] what's the explanation of this HUGE spike in the events with the user.TIER = none

We have a weird pike of events with location=nr1 and with the TIER = none right after the launcho of the I/O and the marketplace
Questions to answer

Why the spike of 102K unique user events
Why is thetier = none
why is the location nr1 there is no way we got 100.000 new users in NR1 on the first day?

All 102K have a User Id == none which indicates that they're not logged in which in turn indicates that these events are not being fired within one.newrelic.com
Acceptance Criteria

[x] Work with Luka  Eterovic to evaluate root cause
[ ] If I/O is causing this problem determine what a resolution might be

marking as done as this ended up being a much larger issue and had little to do with the launch of I/O


Add JsonDecoder Algebra

Single Type Abstraction for separation of Sync and the locations using the Json, which is primarily businesss logic where we'd prefer to remove effects.

I think this isn't being used in the client, do you folks think we could get that in 1.0.0?

I've never used it, so I can't say how well it has aged.  But symmetry seems good.  If it has worked out well for people, I'd be :+1:.


is this nan 2.0.0 related? which was published 7/31

$ npm install odbc
\

<EMAIL_ADDRESS>install /home/andrew/dma/prd/node_modules/odbc
node-gyp configure build

make: Entering directory `/home/andrew/dma/prd/node_modules/odbc/build'
CXX(target) Release/obj.target/odbc_bindings/src/odbc.o
../src/odbc.cpp: In static member function ‘static void ODBC::New(const v8::FunctionCallbackInfov8::Value&)’:
../src/odbc.cpp:143:34: error: call of overloaded ‘NanThrowError(v8::Localv8::Object&)’ is ambiguous
return NanThrowError(objError);
^
../src/odbc.cpp:143:34: note: candidates are:
In file included from ../src/odbc.h:23:0,
from ../src/odbc.cpp:25:
../node_modules/nan/nan.h:705:21: note: void NanThrowError(v8::Handlev8::String)
NAN_INLINE void NanThrow ## NAME(v8::Handlev8::String errmsg) {
^
../node_modules/nan/nan.h:711:3: note: in expansion of macro ‘X’

yep, did a clone and changed package.json nan to 1.8.4 and all good

Thanks, just submitted a pull request with a hot fix. Seems nan broke something before their major version change.

Thank you both! Published v1.1.7 to npm.


Add more info about stripe.js load failed

Add more info to ez debug why stripe.js load failed
Summary & motivation

Testing & documentation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Instances: Overview Page

Overview page of each instance's page

@bltarkany please paste a screenshot of your overview page design for instances. @darwin808 please implement @bltarkany designs

@bltarkany is this screenshot intended to be the main dashboard?

it was meant to replace the blue area here so that there is no dead space(image below). With the new layout changes, it doesn't work well there unless it starts with an overview of the instance and has release updates below it. And unless there are tabs there really isn't a way to include status.zesty.io.

Updated Overview wireframe for current layout - instance specific:


Final submission for COVID19 MDW WhatTheHack

This is a team WhatTheHack that was run in state and local government.  We would like to contribute our assets.  Our hack number is 036-MDW-COVID19.

Can we get a review of this PR please.  We spent a lot of time on putting this together and had a very successful event based on this content.

@blevinscm Sorry about that, Peter and I have been on vacation and doing 3 day what the hacks every week this month so things are a little crazy.

We have some time tomorrow and usually we like to meet up for a phone call and walk through everything and point out things to fix. We find this goes faster than constant back and forth PR comments. That makes approving the final PR much quicker.
Let us know if that's ok with you or not.
cc: @jrzyshr

Me and @chrisbaudo should find some time. If you want to message me on teams tomorrow morning we can find a time. Thanks.
Sent from my iPhone

On Apr 13, 2021, at 17:17, Gino Filicetti @.***> wrote:

@blevinscm Sorry about that, Peter and I have been on vacation and doing 3 day what the hacks every week this month so things are a little crazy.

We have some time tomorrow and usually we like to meet up for a phone call and walk through everything and point out things to fix. We find this goes faster than constant back and forth PR comments. That makes approving the final PR much quicker.
Let us know if that's ok with you or not.
cc: @jrzyshr
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks Chris!  Waiting for Gino to make his pass, then we'll publish.


Schedule for next release?

Hi there, the last release was 8 months ago, and those of us who use modules can't get hold of anything newer (as far as I understand it).  Is there a plan to make a new release soon?
Thanks, Chris

I'm going to do one this week.


Improve error message when body size of a request is unknown

Hello!
Recently I tried to send an Enumerable object as a body for a request:
http.put(url, body: enumerable_instance)

This is a valid body according to the code: https://github.com/httprb/http/blob/master/lib/http/request/body.rb#L76
def validate_source_type!
  return if @source.is_a?(String)
  return if @source.respond_to?(:read)
  return if @source.is_a?(Enumerable)
  return if @source.nil?

  raise RequestError, "body of wrong type<EMAIL_ADDRESS>end

But the request failed with the exception cannot determine size of body: ...
Indeed, although Enumerable is a valid option for body, there is no corresponding case in #size function: https://github.com/httprb/http/blob/master/lib/http/request/body.rb#L17
def size
  if @source.is_a?(String)
    @source.bytesize
  elsif @source.respond_to?(:read)
    raise RequestError, "IO object must respond to #size" unless @source.respond_to?(:size)

    @source.size
  elsif @source.nil?
    0
  else
    raise RequestError, "cannot determine size of body<EMAIL_ADDRESS>  end
end

It seemed a bit vague for me and took some time to figure out that in this case one should set Content-Length header explicitly so that Body#size is not called: https://github.com/httprb/http/blob/master/lib/http/request/writer.rb#L50
def add_body_type_headers
  return if @headers[Headers::CONTENT_LENGTH] || chunked?

  @request_header << "#{Headers::CONTENT_LENGTH}<EMAIL_ADDRESS>end

It seemed for me that it would be useful to have some hint on it in the error message.

IMO this details should not be in exception details. It belongs to documentation/wiki.

@httprb/core WDYT?

I think for bodies that do not support #size we should use (force?) chunked encoding instead. Otherwise we might end up with user setting Content-Length that is invalid (e.g. smaller or bigger than the actual size is).

I think for bodies that do not support #size we should use (force?) chunked encoding instead.

👍The user should still be able to specify Content-Length, but if they haven't we should default to Transfer-Encoding: chunked.
On a related note, I also think that for IO-like objects we don't need to require #size.
https://github.com/httprb/http/blob/6240672bc84b23339fc9a9878040fcb45db78fb5/lib/http/request/body.rb#L21

@janko I agree.

Hello!
Just wanted to clarify, is this issue still worth being opened? As far as I can see, it was automatically closed because of the main branch rename.

I think so.
On Tue, 14 Sep 2021, 13:14 Ilya Averyanov, @.***> wrote:

Hello!
Just wanted to clarify, is this issue still worth being opened? As far as
I can see, it was automatically closed because of the main branch rename.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/httprb/http/pull/560#issuecomment-919052991, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAXEPRELL23SGYVVK5KRP3UB4U75ANCNFSM4IKKVJPQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Reopened as #689

Yep, sorry, pardon my dust


Unified treatment of Hilbert and Cauchy Operators

Currently, we have Hilbert inheriting its core structure & function from the calculus_operator macro (which is awesome by the way). So I was thinking could the same be done for Cauchy operators?
One way to do it would be to create two new operators CauchyPlus and CauchyMinus, and their abstract supertypes and wrappers. Another way would be to modify the macro and have the immutable types declared before. This would allow a single Cauchy operator to look like:
immutable Cauchy{S<:FunctionSpace,T<:Number} <: AbstractCauchy{T}
    space::S
    order::Int
    orientation::Vector{Bool}
end

The calculus_operator macro would set most things as usual. Then, one simple outer function, say orientation(s::Union(Int,Bool),C::Cauchy) assigns a value to a Cauchy instance's orientation[1]. Note that storing orientation as a Vector{Bool} allows its entries to be changed even though the operator is immutable.

There are multiple ways of defining cauchy/hilbert for a given space:
cauchy(±1,f,z)    # pointwise definition
hilbert(f,z)                     # pointwise definition
hilbert(f)                        # function definition
Cauchy(±1,f)      # operator definition, but only nice spaces in periodic case
Hilbert(f)                        # operator definition
where ±1 stand for true/false.  We need to decide what the fall backs are when one is not defined, here are the possibilities:
cauchy(±1,f,z) = ±0.5f[z] - imhilbert(f,z)
hilbert(f,z) = im(cauchy(+1,f,z) + cauchy(-1,f,z))      # if we implement both fallbacks, we get race condition, so maybe just first fallback and make "hilbert" the thing to implement
hilbert(f,z) = hilbert(f)[z]
hilbert(f) = Hilbert()*f
cauchy(±1,f,z) = (Cauchy(±1)f)[z]    # probably not useful for intervals, so may skip this
Cauchy(±1) = ±0.5I - imHilbert()    # This one is implemented

I'm going to implement these fall backs for now and see if we are happy:
cauchy(±1,f,z) = ±0.5f[z] - imhilbert(f,z)
hilbert(f,z) = hilbert(f)[z]
hilbert(f) = Hilbert()f
Cauchy(±1) = ±0.5I - im*Hilbert()

That works for me. Probably should have most fallbacks in one direction unless there's ambiguity.

I think this is as unified as it can be.


Fixed issue with nesting blocks.

Added code coverage gem
Some minor linting changes

Found an issue which I've PR'd to this PR at https://github.com/newrelic/papers/pull/36


fix: prevent empty parent xml overwrites

What does this PR do?
when retrieving a decomposed type (ex a customField) the API returns the parent (customObject) with only the requested field inside it.
Decomposition removes the requested field from the parent, leaving it empty (a CustomObject with no child xml nodes) and then writes that.
What issues does this PR fix or reference?
https://github.com/forcedotcom/cli/issues/2865
@W-15727064@
repro
have a repo with custom objects in it.  (dreamhouse works fine)
sf project retrieve start -m CustomField:Foo__c.Bar__c
before: the object-meta.xml would be blank unless you retrieve the CustomObject, too
after: the object-meta.xml keeps its original values
Note: you can still retrieve a field and end up with an empty parent, as long as you didn't have the parent before.  To get the parent's contents, include it in your retrieve (ex:  sf project retrieve start -m CustomField:Foo__c.Bar__c -m CustomObject:Foo__c)

QA:
setup

checkout branch, yarn && yarn build
yarn link @salesforce/source-deploy-retrieve in PDR
sf plugins link --no-install in PDR

In dreamhouse-lwc
sf project retrieve start -m CustomField:Broker__c.Broker_Id__c
🟢 force-app/main/default/objects/Broker__c/Broker__c.object-meta.xml is not empty


[$250] Workspace - Inbox briefly displayed when creating WS from selector and going back

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5088507&group_by=cases:section_id&group_order=asc&group_id=296775
Issue reported by: Applause Internal Team
Action Performed:

Open the Expensify app.
Tap on the workspace selector on the top left corner.
Tap on the "+" icon to add a new workspace.
Once navigated to workspace menu, tap on the arrow on the top left corner.
Verify you are redirected to workspace selector again.

Expected Result:
After the workspace is created and the user should be navigated to the new workspace menu, and when the back arrow is tapped, the app should return to workspace selector.
Actual Result:
When the user lands on new workspace menu and tap the back arrow to return to workspace selector, the inbox is displayed for a second, before the user lands on selector again.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/e09bb819-9eee-4cd6-a43e-52ce9faa4567
https://github.com/user-attachments/assets/323abdf3-e4d0-4fcf-b676-787d04336f0c

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021849140571510923303
Upwork Job ID:<PHONE_NUMBER>510923303
Last Price Increase: 2024-10-30
Automatic offers:

huult | Contributor | 104756734
dominictb | Contributor | 104771074

Issue OwnerCurrent Issue Owner: @aimane-chnaif

We think that this bug might be related to #wave-collect - Release 1

@puneetlath  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
When the user lands on new workspace menu and tap the back arrow to return to workspace selector, the inbox is displayed for a second, before the user lands on selector again.
What is the root cause of that problem?
We are reseting the navigation to home before we navigate to workspace-switcher. and hence for a second we see inbox for a second
https://github.com/Expensify/App/blob/a53705da129d1398725fa4464cb64e7f53168e2f/src/pages/workspace/WorkspaceInitialPage.tsx#L380-L381
What changes do you think we should make in order to solve the problem?

We need to remove Navigation.resetToHome(); from WorkspaceInitialPage.tsx and
modify WorkspaceSwitcherPage to remove
Navigation.goBack and add Navigation.resetToHome instead
https://github.com/Expensify/App/blob/a53705da129d1398725fa4464cb64e7f53168e2f/src/pages/WorkspaceSwitcherPage/index.tsx#L168
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Inbox briefly displayed when creating WS from selector and going back
What is the root cause of that problem?
The reason we briefly see Inbox is that when we tap the back arrow, the function called includes Navigation.resetToHome();. As a result, Inbox appears for a short time before we proceed to call Navigation.isNavigationReady().then(() => Navigation.navigate(route.params?.backTo as Route)); to navigate to the workspace switcher.
https://github.com/Expensify/App/blob/5103b4bd53ae74dcb301b8450f7046e82dc311d3/src/pages/workspace/WorkspaceInitialPage.tsx#L378-L382
What changes do you think we should make in order to solve the problem?
To fix this issue, we should navigate directly to the workspace switcher without calling Navigation.resetToHome(); to avoid seeing the Inbox. After reaching the workspace switcher, when we go back, we can add Navigation.resetToHome(); to return to the home screen. Something like this:
//.src/pages/workspace/WorkspaceInitialPage.tsx#L380
        onBackButtonPress={() => {
              if (route.params?.backTo) {
-                  Navigation.resetToHome();
-                  Navigation.isNavigationReady().then(() => Navigation.navigate(route.params?.backTo as Route));
+                  Navigation.isNavigationReady().then(() => Navigation.navigate(`${route.params?.backTo}?resetToHome=true` as Route));
              } else {
                  Navigation.dismissModal();
              }
          }}

//.src/pages/WorkspaceSwitcherPage/index.tsx#L38
-        function WorkspaceSwitcherPage() {
+        function WorkspaceSwitcherPage({route: {params}}) {

//.src/pages/WorkspaceSwitcherPage/index.tsx#L93
    const selectPolicy = useCallback(
        (option?: WorkspaceListItem) => {
            ...
+            if (params?.resetToHome === 'true') {
+                Navigation.resetToHome();
+            }
            ...
        },
        [activeWorkspaceID, setActiveWorkspaceID],
    );

//.src/pages/WorkspaceSwitcherPage/index.tsx#L168
-        onBackButtonPress={Navigation.goBack}
+        onBackButtonPress={() => {
+              if (params?.resetToHome === 'true') {
+                  Navigation.resetToHome();
+              }
+              Navigation.goBack();
+        }}

POC
https://github.com/user-attachments/assets/2d22933a-6ad9-4051-a0fa-d0366807308a

@aimane-chnaif Yes, I will improve the next proposal.

@aimane-chnaif Yes, sure. I tested the case you mentioned, and my proposal worked.

@huult are you able to find any regression with that solution?

@aimane-chnaif Yes, the other proposal has an issue: when we are on the search page, open the workspace switcher, and click the back arrow, it resets to the home page. That’s why, in my proposal, I use params to determine whether we need to reset to the home page or not
Video
https://github.com/user-attachments/assets/8c553b47-586b-405d-9074-7ab8022fea45

Waiting for @puneetlath

Issue not reproducible during KI retests. (First week)

@dominictb I think this ticket is still valid because we have the Get Started case where, if we don't have any workspace, we can create a workspace (click get started) in the same way as using the plus icon. Therefore, I believe the PR is still valid and ready to be merged. I will test that case once the server is back.

@dominictb I tested, and we have an issue when going back. Do you agree that we continue with this pull request?
https://github.com/user-attachments/assets/f01770d9-239b-40c8-9b08-638bb77d63a3

I made a mistake. This is not related to this ticket, so I will close this pull request. Thank you.

@puneetlath FYI

Ah interesting ok.

Ok, I've paid out the contracts. Closing. Thanks y'all!


Small perf optimizations ipcache

read per commit message

This change is

test-me-please

Coverage decreased (-0.03%) to 44.023% when pulling 956d7fc040d20a855d67d6866bf5393ee3bf9bcc on pr/small-perf-optimizations-ipcache into de10fdd9f0a920fc7a7453de7af4b3129ac04994 on master.


Address Open SSF scorecard issues

Address all high and medium issues found https://github.com/notaryproject/notation/security/code-scanning

[ ] Create a security policy.  This is a good template to consider.

@dtzar  Can we do it post rc.1?

I would suggest the security policy one, Token Permissions, and Pinned Deps ones be done @ RC-1.  I can't imagine all those things take more than ~1 day of work for one person.  The rest, yes post RC-1.

Most of issues were fixed by PR #730 and #731.

Closed as most issues were fixed. Please create a new issue for new problems.


README.md for setting up the project locally or on deployment

Do a solid README.md for how the project can be setup locally or on deployment. To do this, one must have to understand how the project works so that steps will not be misleading.

Basically, this issue has been tackled. More fixes shall come into the README.md file as time goes on if need be.


Config missing in carbon.xml.j2 in IS 5.10.0

Describe the issue:
In PR[1] we have backported the validateUsername to the IS 5.10.0 and in PR[2] we have backported adding util method to disable email username validation. But the below configuration is missing in the carbon.xml.j2 file, therefore we cannot disable email username validation in the IS. This config has not been added with the PRs.
{% if tenant_mgt.disable_email_domain_validation is defined %}
{{tenant_mgt.disable_email_domain_validation}}
{% endif %}
[1] https://github.com/wso2-support/carbon-identity-framework/pull/2577
[2] https://github.com/wso2/carbon-identity-framework/pull/3582
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS 5.10.0

duplicate of https://github.com/wso2/product-is/issues/15678


Fix pylint issues

Fixing most issues reported by pylint. A few were ignored, in particular these ones with the flag --disable=

W1203 - Use lazy % formatting in logging functions
C0103 - Variable name "..." doesn't conform to snake_case naming style
E0401 - unable to import '...'
R0902 - Too many instance attributes
R0913 - Too many arguments
R0914 - Too many local variables

I also used the flag --logging-format-style=new when running pylint in an attempt to avoid the issue about lazy logging, but it doesn't always work. I don't think we should switch to lazy logging (and have most of the internet backing me up).
I added some pylint messages in the code as well so that it ignores specific lines or pieces of code which we know are OK.
Remaining issues that we should actually resolve are missing module docstrings, TODOs, FIXMEs and some specific issues like the one reported in #417.
pylint also complains about duplication of code. Not sure if we can or should resolve these. I suggest we take a closer look in the future.
In general I think we can start using pylint as a prehook if we decide to officially ignore the messages above and fix or decide about the few remaining others. We should probably ignore the module docstring as well in this case until they are implemented.
This PR closes #415.

Codecov Report

Merging #430 (400df14) into master (8cdb37a) will increase coverage by 0.04%.
The diff coverage is 70.03%.

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   81.27%   81.31%   +0.04%
==========================================
  Files          70       70
  Lines        6931     6931
==========================================
+ Hits         5633     5636       +3
+ Misses       1298     1295       -3

Impacted Files
Coverage Δ

simtools/io_handler.py
93.02% <0.00%> (ø)

tests/unit_tests/test_db_handler.py
95.00% <ø> (ø)

simtools/ray_tracing.py
33.33% <12.50%> (+0.73%)
:arrow_up:

simtools/model/model_utils.py
52.00% <16.66%> (ø)

simtools/visualization/visualize.py
60.97% <33.33%> (ø)

simtools/model/mirrors.py
62.33% <40.00%> (-0.49%)
:arrow_down:

simtools/psf_analysis.py
56.88% <41.66%> (+0.78%)
:arrow_up:

simtools/db_handler.py
73.54% <46.87%> (-0.51%)
:arrow_down:

simtools/simtel/simtel_runner.py
67.02% <47.36%> (ø)

simtools/configuration/commandline_parser.py
87.14% <50.00%> (ø)

... and 29 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Agree with your suggestions on moved the pre-commit topic to #431
(and not sure if I should merge, as it is not clear if you ask for 2 or at least 1 out of 2 reviewers)

Thanks for the review and for opening the issue. I merged the PR. I asked for 2 reviewers as a way to ask both of you and planned to accept the quickest person. Sometimes I ask a specific person because it relates to code they wrote.


init: Is init a POSIX utility?

I didn't find init in the POSIX standard (http://pubs.opengroup.org/onlinepubs/9699919799/idx/utilities.html).
How about treat init itself as a "type"/"feature" (similar with "POSIX", "Netowrking", etc)?.
Also, I am trying to compile mesabox in OS X (x86_64-apple-darwin). init (in "posix" feature) and getty (in "loginutils" feature) are not compatible with OSX (which are not designed and supposed to work in OSX). Therefore, for people who want to use it in OSX can simply exclude "init" and "loginutils" feature.
Anyway, I don't think supporting OSX is the first priority.

It's probably not, but I wasn't sure where to put it when I first added it.  Separating it out into its own feature (along with other system start-up related utilities) makes sense to me.

This should be resolved by 8314b9cdf8dd8ca67d3841c3d1e450f75ded2d95.


Any npm package / docs?

Hi,
I was finding an age-in-js solution and found out this repo (and, of course, the rage repo). It's a really cool idea about using a rust-powered wasm!
However, is there any npm package and/or docs? It seems that the only ("hacker") way to understand the package usage is by reading the source code of App.vue.
Thank you so much for your help! :-)

I was using the webapp to figure out what the package API should look like. But yeah, I should get around to publishing a beta package that others can start using and giving feedback on.

Is there any progress on this? It would be nice to have a package on npm :)


Difference alpha/non-alpha images

Hi Thomas,
I am not sure that the behavior is intentional, but the difference between the same OpenEXR image with and without an alpha channel does not work. Denying computing the difference between images with different numbers of channels is a very reasonable approach.
However, by default, saving an OpenEXR image from tev automatically creates an alpha channel, which can break the difference computation when the image is reopened later.
Is it possible to fix one of this behavior (saving or difference computation)? For example, I am unsure if fixing the OpenEXR saving can have a side effect.
Best,
Adrien

Hi Adrien, yeah, tev should be able to compare images with mismatched channels — it used to be supported in a hacky way, which seems to have broken at some point in the past year.
Could you check the linked PR for whether it fixes your use case? Mismatched top-level channels should now gracefully compare.
Things will still not work if the mismatched channels are situated in mismatched layers, which I plan to address in a future PR.

Hi Thomas,
Yes the changes works perfectly! Thanks for your rapid response.
Best,
Adrien


fix inadvertent expression reversal in math database functions

This was detected by the ATAN2 tests and it turns out the bug
was in the adapter, not in cockroachdb.

This explains why I couldn't figure that out! Thanks


Add example of breakpoint's usage in the language manual

The language manual currently describes how breakpoint works, but doesn't provide a visual example. This makes it harder to skim when using the manual as a reference sheet in a second window.

@JohnEarnest Lol, I was going to submit a PR for this one. Ty though! For smaller issues like this, do you just want me to submit PRs?

Sure. We can always have discussion about anything unclear in comments on the PR itself.

Sounds good, ty!