IOU - Content in IOU thread and details page has different shade of gray when created offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify,com
Go offline
Request money from another use
Click on the IOU preview in 1:1 DM to open IOU report
Click on the IOU preview in IOU report to open IOU details page

Expected Result:
The content in both IOU report and IOU details page has the same shade of gray when created offline
Actual Result:
The content in both IOU report and IOU details page has different shade of gray when created offline.
IOU details page has lighter gray than IOU report
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome
[ ] MacOS / Desktop

Version Number: 1.3.58-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/51515a03-1e04-4e2c-be07-cb0bfee772aa
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Proposal
Please state again the problem we are trying to solve in this issue.
Content in IOU thread and details page has different shade of gray when created offline.
What is the cause of this issue?
MoneyReportView and MoneyRequestView are wrapped with OfflineWithFeedback.
And "Amount Cash", "Description", "Date" and "Merchat" in MoneyRequestView are also wrapped with OfflineWithFeedback again.
So MoneyRequestView has more gray than MoneyReportView.
What changes do you think we should make to solve the problem?
We can remove OfflineWithFeedback for "Amount Cash", "Description", "Date" and "Merchat" in MoneyRequestView.
What alternative solutions have you investigated? (Optional)
None.

Was able to reproduce

isn't the same as

Gonna tag design for quick 👀 to ensure we're following the proper design guidelines since I'm not 100% we want the latter to be similar to the former.

@sonialiap I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday?  Thx

I'm not 100% certain of our rules/guidelines regarding offline styles, but it does seem like the details screen is extra faint. My gut says that those styles should match our regular chat and request offline styles, but I might want @shawnborton to take a look when he has time and give me the rundown of how we handle offline stuff stylistically.

That does look quite faint. CC'ing @mountiny again here since you had some experience with these rows for manual requests. Any idea what's happening?
I think the offline pattern for this would be that the rows appear at reduced opacity, but something consistent like 50% for all of them. cc @trjExpensify does that sound right?

Yeah I am not sure, I guess this is a combo of two offline wrappers as the transaction as well as the thread is created optimistically, I think if we define how it should look like here, we can export it then

I did some quick Figma-ing and that details screen looks like a pretty close match to 25%.

@shawnborton are you cool with this?

I think what Danny is saying is that it shouldn't be at 25% - and that's happening because we're doing 50% opacity twice.

So we should just be using the standard 50% opacity reduction.

I think what Danny is saying is that it shouldn't be at 25% - and that's happening because we're doing 50% opacity twice.
So we should just be using the standard 50% opacity reduction.

Yes—what Shawn said.

Thanks @shawnborton and @dannymcclain .   I updated the OP and made external, let me know if the below isn't correct.
Expected result
The content in the IOU details page should be the same opacity as the IOU report page which is 50% (not 25% which is happening because we're 50% opacity is being applied twice)
@sonialiap I unassigned ya since I'm already working on this.

D'oh, accidentally removed the Help Wanted label and didn't add back.   Just added

I caught up with the discussion and concluded that the first proposal, by @StevenKKC, achieves the desired outcome and is a clean solution to the problem.
C+ reviewed 🎀 👀 🎀

@ginsuma
Haven't we established that MoneyRequestView is already wrapped here?

@StevenKKC Thanks for clarification. Well, I didn't notice that in the beginning to.
Sorry everyone for the confusion. This is my bad in the big part.
After clearing up the situation, I must to change my stand and we should go with @ginsuma
C+ reviewed 🎀 👀 🎀 (again)

The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/25399

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/25399/files#r1348567685

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need for additional discussion

Determine if we should create a regression test for this bug.

Up to the QA team

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Be offline.
Plus > Request money.
Open the IOU details page.
Verify that the level of grey is as usual (50%).
Be online.
Verify that there is no grey in the content.
Be offline again.
Update the Amount, Description, Date, and Merchant.
Verify again that the level of grey is as usual (50%).
Be online again.
Verify that there is no grey in the content.

Issue reporter: Applause
Contributor: @ginsuma paid $500 via Upwork
Contributor+: @cubuspl42 paid $500 via Upwork.
Thanks @cubuspl42 , I created the TestRail GH, we def won't check this on every regression test, maybe monthly?

@mallenexpensify As I shared in the other thread, I don't have a good intuition here! Monthly sounds fine for me


New method to set brightness (intensity)

I've salvaged an IC labeled TM1616 that happens to work with your library. In the TM1638 by rjbatista lib's  source there's an option to set the brightness (it's called intensity there), which I find very useful and it also happens to work with TM1616.

Looks good!


[plugins]Deprecation & Unchecked warning

Steps to Reproduce

Run flutter create bug.
Update the files as follows: Add package's from https://pub.dev/publishers/flutter.dev/packages to pubspec.yaml
Run flutter build apk.

Expected results: No Warning
Actual results:

androidintent : MethodCallHandlerImpl.java uses unchecked or unsafe operations. PR : https://github.com/flutter/plugins/pull/3043

camera : CameraPlugin.java uses or overrides a deprecated API. PR : https://github.com/flutter/plugins/pull/3018

connectivity : ConnectivityBroadcastReceiver.java uses or overrides a deprecated API. PR : https://github.com/flutter/plugins/pull/3051

espresso : EspressoFlutter.java uses unchecked or unsafe operations. PR : https://github.com/flutter/plugins/pull/3111

google_maps_flutter : Some input files use unchecked or unsafe operations. PR : https://github.com/flutter/plugins/pull/3112

in_app_purchase : MethodCallHandlerImpl.java uses unchecked or unsafe operations. PR : https://github.com/flutter/plugins/pull/3120

share : MethodCallHandler.java uses unchecked or unsafe operations. PR : https://github.com/flutter/plugins/pull/3004

video_player : VideoPlayerPlugin.java uses or overrides a deprecated API PR : https://github.com/flutter/plugins/pull/3019

webview_flutter : Some input files use or override a deprecated API. & FlutterWebView.java uses unchecked or unsafe operations. PR : https://github.com/flutter/plugins/pull/3117

Logs

Analyzing example...
No issues found! (ran in 24.2s)

flutter doctor -v
[√] Flutter (Channel master, 1.22.0-10.0.pre.39, on Microsoft Windows [version 10.0.19041.508], locale fr-FR)
    • Flutter version 1.22.0-10.0.pre.39 at D:\flutter
    • Framework revision dcace1417d (2 days ago), 2020-09-15 09:36:26 +0100
    • Engine revision 7e962ba911
    • Dart version 2.10.0 (build 2.10.0-124.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at C:\Users\hamdi\AppData\Local\Android\Sdk
    • Platform android-30, build-tools 30.0.1
    • ANDROID_HOME = C:\Users\hamdi\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.3)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.6.30225.117
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.49.0)
    • VS Code at C:\Users\hamdi\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.14.1

[√] Connected device (4 available)
    • Windows (desktop) • windows    • windows-x64    • Microsoft Windows [version 10.0.19041.508]
    • Web Server (web)  • web-server • web-javascript • Flutter Tools
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 85.0.4183.102
    • Edge (web)        • edge       • web-javascript • Microsoft Edge 85.0.564.44

• No issues found!

All the linked PRs are closed, so I'm assuming this is fixed. If there are still other things left, please file new issues to track them.


gst_all_1.*,python3Packages.gst-python: 1.24.2 -> 1.24.3

Description of changes
GStreamer bump (https://gstreamer.freedesktop.org/releases/1.24/#1.24.3), including security fix in gst-plugins-base: https://gstreamer.freedesktop.org/security/sa-2024-0002.html
Needs backport to 24.05
GStreamer 1.22.12 will be backported to 23.11 Edit: Done! See #314004
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin
[x] x86_64-linux -> aarch64-linux (cross)
[x] x86_64-linux (with qt5Support override via nheko)
[x] x86_64-linux (with gtkSupport override via pitivi)

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Cherry-picked to staging-next for testing, failing to build gst-plugins-rs on macos 12 x86_64 - fails at the link stage?
"-dynamiclib" "-Wl,-dylib" "-nodefaultlibs" "-Wl,-install_name,/nix/store/m6whfrlqxbjzx83bwa9vvhfm38ikl89a-gst-plugins-rs-0.12.4/lib/libgstrav1e.dylib" "-Wl,-headerpad_max_install_names"
  = note: ld: in /private/tmp/nix-build-gst-plugins-rs-0.12.4.drv-0/source/build/target/x86_64-apple-darwin/release/deps/librav1e-ddfef1facd5cdfb4.rlib(cdef_avx2.o), in section __DATA,__const reloc 24: symbol index out of range
          clang-16: error: linker command failed with exit code 1 (use -v to see invocation)

Incidentally this is running on a machine without AVX2, but it's not as though this is an illegal instruction error.

:point_up: Forget the above, I get the same on current staging-next


[RELENG-5138] Patch error on webhooks

Codecov Report

Merging #63 (391d3e7) into main (4109437) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   76.22%   76.22%
=======================================
  Files          12       12
  Lines         572      572
=======================================
  Hits          436      436
  Misses        136      136

Impacted Files
Coverage Δ

srcs/runners_manager/runner/Manager.py
66.19% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4109437...391d3e7. Read the comment docs.


ci: fix publish

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.28%. Comparing base (0b415c3) to head (5e455bb).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   95.28%   95.28%
=======================================
  Files           7        7
  Lines         191      191
=======================================
  Hits          182      182
  Misses          9        9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update libnetwork to 4df06c4

This fixes docker #28931, #28172, #28969
Signed-off-by: Santhosh Manohar<EMAIL_ADDRESS>

LGTM


Influxdb service adapts to distributed MPP framework and fixes some bugs in InfluxFunction and TagInfoRecord

Background
The existing InfluxDB service does not adapt to the new distributed MPP framework. I developed a new InfluxDB service that adapts to the new distributed MPP framework without affecting the original influxDB service.
Different
added some new classes

AbstractInfluxDBMetaManager: manages the mapping of tags->path, provides template methods, and subclasses only need to implement abstract methods

InfluxDBMetaManager: An existing implementation class that uses ServiceProvider to perform physical planning.
NewInfluxDBMetaManager: An implementation class adapted to the MPP framework, which uses ClientRPCServiceImpl to process read and write requests.

AbstractQueryHandler: handles query requests, provides template methods, and subclasses only need to implement abstract methods.

QueryHandler: Existing implementation class, which uses ServiceProvider to process the read physical plan
NewQueryHandler: An implementation class adapted to the MPP framework, which uses ClientRPCServiceImpl to process read requests.

InfluxDBSeviceImpl: The existing influxDBRPCSevice instance.
NewInfluxDBSeviceImpl: an instance of influxDBRPCSevice adapted to the MPP framework.
Detailed class diagrams and designs：https://apache-iotdb.feishu.cn/docx/doxcnZzEZ1BwXS6EQfrUEuGOX4d#doxcnO2Kue0WCMog6En9LtAJEJh

fixed some bugs
the classes involved：

TagInfoRecords：This class is used to write the sequence of each tag into IoTDB. At present, there may be multiple adjacent tags with the same timestamp, which causes the tags written later in IoTDB to overwrite the tags written before.
InfluxMeanFunction：The type of the incoming parameter is double, but the type of the member variable sum is long, resulting in a type mismatch exception
InfluxFirstFunction and InfluxLastFunction：There is a problem with the logic. The existing implementation reverses the logic of last and first, and the result of the calculation is null.

@LIU-WEI-git If you have free time, please review it together :D

Thanks for your contribution, LGTM!


[Feature request]: metabolomics integration

Contact Details
No response
Description
These are the minimum features to efficiently embed mzTab (as standard format for exchange of metabolomics data) into MODOs:

The metadata on samples and assays specified in the mzTab (MTD lines) should be available and queryable through the API. Having to download the full file (or files) and parse it externally to know what data is included kills any
The API should include helpers to pull pandalized versions of the SML, SMF, SME, etc.
There should be helpers to remove data that is associated with a specific sample_id (=set columns in SML and SMF to NaN). Think of a patient who decides to opt-out of a study,
The mzTab file should definitely be stored within the object. How else can you ensure sync, slicing, etc of modo? I can't imagine there is no way of storing a text file into zarr arrays.
There should be coherence in how sample metadata across different omics layers is represented. It should be user-friendly to obtain a single table with sample_id, patient_id, batch_id, all types of objects included, and their name id

Importance Level
High
Affected Components
No response
Technical Requirements
No response
Acceptance criteria
No response

Thank you @htmonkey for the detailed and valuable feedback.
I see two issues here:

The vision of MODOs is to have one MODO / patient, you delete one object when consent is retracted. On the other hand, I understand that mztab files can contain multiple patients.
In the mztab spec, I find no field corresponding to patient or batch ID. How could we then know whether two samples are from the same patient or 2 different patients.

I see two options:

Compromise on the original vision and bundle multiple patients in the same object, reducing the original simplicity.
Only embed metadata and columns corresponding to specific samples from a single patient (as tables) and not the actual mzTab file.

Would it make sense to expect mzTab files to be split by patient upstream of modos creation (on the provider side) and that all samples in the file belong to the same patient?
This could be a good trade-off to retain privacy guarantees while still embedding files in the mzTab format.


Missing rule on cssComb

Original report by sobral (Bitbucket: sobral, GitHub: robsonsobral).

"space-before-combinator": " ",

Closing this since cssComb will be replaced with stylelint order


Can we Extract data from MSSQL database and load it into a csv file?

Using this library Can we Extract data from MSSQL database and load it into a csv file?

It wont work because https://github.com/wizacode/php-etl/blob/master/src/Database/Connectors/SqlServerConnector.php#L55 is using deprecated code now.
See screeenshot for example.

Hi @chriscalip and thank you for your message.
I am not sure to understand: in your screenshot I don't see any deprecation notice (on top of that, deprecation should not prevent the code to work).
However when looking at your screenshot, I see the error could not find driver, usually meaning that the proper PDO extension is not installed.
Do you have any information to help us to understand?

Closing since no news for months.


Update scalafmt-core to 3.5.4

Updates org.scalameta:scalafmt-core from 3.5.2 to 3.5.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (3.5.2).
You might want to review and update them manually.
docs/website/yarn.lock

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:n:2

Codecov Report

Merging #1265 (192e1e0) into main (c456f16) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
- Coverage   59.27%   59.11%   -0.17%
==========================================
  Files          66       66
  Lines        2409     2409
  Branches       77       77
==========================================
- Hits         1428     1424       -4
- Misses        981      985       +4

Impacted Files
Coverage Δ

zio-http/src/main/scala/zhttp/service/Server.scala
46.66% <ø> (ø)

...p/src/main/scala/zhttp/socket/WebSocketFrame.scala
19.35% <0.00%> (ø)

...ain/scala/zhttp/service/ServerResponseWriter.scala
85.71% <0.00%> (-7.15%)
:arrow_down:

zio-http/src/main/scala/zhttp/http/Response.scala
82.85% <0.00%> (-1.43%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c456f16...192e1e0. Read the comment docs.


Exporting difference in styles

What you think abought adding a feature that allows you to export difference in styles between original page and changes maked by VisBug. (window with plain text classes or smth like that)

what do you think of this UX?

make changes to an element
switch to the style inspect tool
on hover you see your changes
click to copy the css you changed
paste anywhere (somewhere else on the current page, another page, vscode, etc)

I know this is old but cool UX will be to have changes in Firefox Style Editor as custom visbug.css file.


Feature Request: basic HDMI-CEC support.

Pulse-Eight sells a USB HDMI CEC adapter. It is the same one used in the raspberry pi as they provide the module for it. The adapter is cheap and can be used to do things like switch the TV input.
The following library includes a very simple to use command line client: https://github.com/Pulse-Eight/libcec. I believe an arch package exists for it.
I think it would greatly enhance the console experience if a command to turn the input active during bootup and a command to disable the input during shutdown was implemented. Additionally, turning the input off for suspend when pressing the power button and turning it on in resume would be desirable. This is similar to how Xbox implements their CEC so that you can turn a controller on and it wakes the console and turns the TV on. Waking the system with a USB Xbox wireless adapter already works, so cec-client is the only missing piece.
Turning the display off and on should be as simple as a systemd service that calls echo as | cec-client -s to turn it on and echo standby 0 | cec-client -s to turn it off during boot and shutdown respectively. If no CEC dongle is available this just won't do anything and is safe.

I recently purchased one of these devices for this purpose. It is quite simple to use, but my priorities have been elsewhere lately. I'm glad to know that others are interested in this. I'll be sure to update this post once I've started the PR.

Seems to be a duplicate of #149


Rewrite app

Rewrote from the ground up with Angular CLI v11. Got rid of a lot of problems and requires way less from the user than before. Also takes care of https://github.com/stevewhitmore/mmm-toast/issues/8 and https://github.com/stevewhitmore/mmm-toast/issues/1.

This was way too big to merge cleanly so I changed rewrite-app to be the new master. Pre-rewrite still remains in the pre-rewrite branch.

This was way too big to merge cleanly so I changed rewrite-app to be the new master. Pre-rewrite still remains in the pre-rewrite branch.


DE-EN WMT tutorial not giving expected output

Hi,
I trained a DE-EN model exactly as per the instructions here - https://awslabs.github.io/sockeye/tutorials/wmt.html.
When I try to run the inference using the following command -
echo "er ist so ein toller Kerl und ein Familienvater" |
python3 -m apply_bpe -c bpe.codes --vocabulary bpe.vocab.en
--vocabulary-threshold 50 |
python3 -m sockeye.translate -m wmt_model 2>/dev/null |
sed -r 's/@@( |$)//g'
The translation output I receive is: "it is is a a of of and and and and ,"
and not the expected output:         "he is a great guy and a family father ."
The final model details are as below -
"Training finished. Best checkpoint: 155. Best validation perplexity: 700.395322"
I wanted to check if my trained model parameters are consistent with those of the model that produced the output in the tutorial?
Thanks.

Could you paste the the last couple of lines from the training log and maybe the output of the model/metrics file?
Also if you have your exact training commands for double checking that would be helpful too.

This is the output from log file -
[2019-02-06:12:26:15:INFO:sockeye.training:collect_results] Decoder-187 finished: {'bleu-val': 0.003785395765721445, 'chrf-val': 0.11861884554235633, 'rouge1-val': 0.20614581305158247, 'rouge2-val': 0.019603614782491296, 'rougel-val': 0.1436156638114417, 'avg-sec-per-sent-val': 0.046578153133392336, 'decode-walltime-val': 23.289076566696167}
[2019-02-06:12:26:15:INFO:sockeye.training:fit] Training finished. Best checkpoint: 155. Best validation perplexity: 700.395322
[2019-02-06:12:26:15:INFO:sockeye.utils:exit] Releasing GPU 0.
Model/metrics file -
187	avg-sec-per-sent-val=0.046578153133392336	bleu-val=0.003785395765721445	chrf-val=0.11861884554235633	decode-walltime-val=23.289076566696167	epoch=15	gradient-norm=1.2479667971962376	learning-rate=4.801999999999999e-05	perplexity-train=106.91554398656997	perplexity-val=713.993640141835	rouge1-val=0.20614581305158247 	rouge2-val=0.019603614782491296	rougel-val=0.1436156638114417	time-elapsed=37264.601153850555	used-gpu-memory=10493
And the training command -
python3 -m sockeye.train -d train_data
-vs newstest2016.tc.BPE.de
-vt newstest2016.tc.BPE.en
--encoder rnn
--decoder rnn
--num-embed 256
--rnn-num-hidden 512
--rnn-attention-type dot
--max-seq-len 60
--decode-and-evaluate 500
--checkpoint-frequency 100
--device-ids 0
-o wmt_model

Hi, any updates on this?

That's a very high perplexity and similarly low validation BLEU score, so something has gone quite wrong. So something is quite wrong. What command did you use to prepare the training data? Maybe you had the language directions reversed?

Indeed. I followed the tutorial to the t but I'll try to reproduce the error.

That tutorial might also be outdated. You might also consider trying the tutorial under Sockeye autopilot.

This is quite strange indeed. Could you attach the entire log or paste the full beginning of the log (to sanity check vocab count etc). I will try rerunning the tutorial and see if I run into the same issues.

Did you limit the training data (the lines with head -n 200000 ...  in the tutorial?

I finally had some time to verify this and I am not able to reproduce the issue.  | \
  python -m apply_bpe -c bpe.codes --vocabulary bpe.vocab.en \
                                   --vocabulary-threshold 50 | \
  python -m sockeye.translate -m wmt_model_smallbach 2>/dev/null | \
  sed -r 's/@@( |$)//g'

(note that I used a smaller batch size)
This produces:
> he is a a guy guy and a family father .

Final perplexities:
[2019-03-31:14:29:27:INFO:root:save_params_to_file] Saved params to "wmt_model_smallbach/params.00338"
[2019-03-31:14:29:27:INFO:sockeye.training:fit] Checkpoint [338]        Updates=1352000 Epoch=17 Samples=99552407 Time-cost=4751.748 Updates/sec=0.842
[2019-03-31:14:29:27:INFO:sockeye.training:fit] Checkpoint [338]        Train-perplexity=6.886707
[2019-03-31:14:29:46:INFO:sockeye.training:fit] Checkpoint [338]        Validation-perplexity=5.256161
[2019-03-31:14:29:53:INFO:sockeye.utils:log_gpu_memory_usage] GPU 0: 6192/11441 MB (54.12%)
[2019-03-31:14:29:53:INFO:sockeye.training:collect_results] Decoder-337 finished: {'bleu-val': 0.31160440885243934, 'chrf-val': 0.5338281700155819, 'rouge1-val': 0.5847193871188325, 'rouge2-val': 0.34614205046951774, 'rougel-val': 0.5197600801634908, 'avg-sec-per-sent-val': 0.14392298889160157, 'decode-walltime-val': 71.96149444580078}
[2019-03-31:14:29:53:INFO:sockeye.training:start_decoder] Starting process: Decoder-338
[2019-03-31:14:29:58:INFO:sockeye.training:fit] Validation-perplexity has not improved for 32 checkpoints, best so far: 5.249562
[2019-03-31:14:29:58:INFO:sockeye.lr_scheduler:new_evaluation_result] 8 checkpoints since improvement or rate scaling, lowering learning rate: 1.94e-06 -> 1.36e-06
[2019-03-31:14:30:04:INFO:sockeye.training:fit] Maximum number of not improved checkpoints (32) reached: 32
[2019-03-31:14:30:04:WARNING:sockeye.training:wait_to_finish] Waiting for process Decoder-338 to finish.
[2019-03-31:14:30:35:WARNING:sockeye.training:wait_to_finish] Had to wait 30 seconds for the Checkpoint Decoder-338 to finish. Consider increasing the checkpoint frequency (updates between checkpoints, see --checkpoint-frequency) or reducing the size of the validation samples that are decoded (see --decode-and-evaluate).
[2019-03-31:14:30:35:INFO:sockeye.training:collect_results] Decoder-338 finished: {'bleu-val': 0.31111721046826374, 'chrf-val': 0.5350197387551763, 'rouge1-val': 0.5875994688372096, 'rouge2-val': 0.3471943959830435, 'rougel-val': 0.5192682805429852, 'avg-sec-per-sent-val': 0.061370361328125, 'decode-walltime-val': 30.6851806640625}
[2019-03-31:14:30:35:INFO:sockeye.training:fit] Training finished. Best checkpoint: 306. Best validation perplexity: 5.249562
[2019-03-31:14:30:35:INFO:sockeye.utils:__exit__] Releasing GPU 0.

The discrepancy between the perplexities makes me wonder if maybe some files were swapped accidentally. Anyway, let me know if you have any more details for reproducing. Otherwise I will close the issue for now.

closing for now. Feel free to reopen.


Add box score API function

Returns a game summary JSON given a game ID.
Line Score section is incomplete.

This needs a review but it will possibly change with the upcoming event summary changes. Maybe we should hold off


Fix #95: Stop logging database secrets

Fixes #95 by redacting db_connect string from output of logs

LGTM - Thank you @nyanshak for the contribution!


Fix reloading on viewport size change

This fixes the constant reloading if the viewport size changes. This has already bothered me a long time, and I knew it was reloading, because of the constant reimporting of the component , but didn't changed, I just popped out the dev tool in a separate window and avoided resizing till @LavissaWoW created that issue now :D . Also sometimes this can lead to a so high number of requests that the server temporarily get unavailable and the session logs out of PUI.
Fixes #6004

@wolflu05 nice work, appears to work very smoothly :)


net/http/httputil: ReverseProxy flush immediately additional case

While using ReverseProxy in a stream-based HTTP API I got hit by the default value of FlushInterval. This API used a Transfer-Encoding: chunked and Content-Length: -1 for the intention of a stream-based response.
The default value of FlushInterval isn't latency based nor flush immediately which seems fine in general, but in this particular case, the end client (talking with the reverse-proxy) wasn't seeing any stream messages since they were being buffered until the HTTP response finished, which in this case was never since only gets canceled by the client.
Looking at ReverseProxy implementation the solution was simple, just use FlushInterval = -1 to signal to flush immediately. Interestingly, the exact same situation was in a TODO comment which from my point of view sounds like it might be a good idea to implement.
I'm opening the discussion to see if makes sense. If that's the case, I can propose a PR if we decide is a good idea to also flush immediately on Content-Length: -1 or other decided case in addition to the current exception Content-Type: "text/event-stream".

FYI, Caddy's approach.

@bradfitz

Doing that TODO from line 409 seems reasonable.
/cc @neild

Sounds good, I can take care of this. I'll make a PR in the next days.

cc @odeke-em as possible reviewer.

Thank you for the tag @networkimprov :) I've provided my review.

@dmitshur should we perhaps backport this change?

This was a TODO comment added 2 years ago that was only reported 2 weeks ago. That suggests to me it's not a very serious issue, and fine to leave for 1.16.


Mechanism for handling sites with authentication

Feature suggestion from https://writethedocs.slack.com/archives/C72NZ18FR/p1646878775398999?thread_ts=1646877544.991549&cid=C72NZ18FR

The simplest way to do this would be to support adding extra headers to requests - that way users could define cookies to be sent.
But... cookies are fickle. They expire, which means the YAML file would stop working. They're not particularly user-friendly either.
The much more exciting way to solve this would be the Playwright way - allow users to define a sequence of steps, e.g. "Go to /login, then enter this username and password in these fields, then submit the form, then go to /x and take a screenshot".
I don't think it would be feasible to support that as one-off command-line options, it would need to be YAML only.
But within the YAML format it could be feasible!
(CAPTCHAs and 2FA would block this approach entirely.)

There's something deviously tempting about defining a mini YAML language that automates the process of visiting a page, filling in a form, submitting it, visiting another, snapping a screenshot, injecting some JavaScript, snapping another screenshot of a page element, navigating somewhere else...

@simonw
Based on your tweet here are two potential use cases I was thinking about:

Logging into a site where some sort of social authentication is performed (a la django-allauth using GitHub, or Twitter as an authentication App)
Logging into a site using OKTA (this would be more for a work thing where we use OKTA to log into internal and external sites). OKTA uses 2FA so I'm not sure how that could be implemented.

The reason item 2 above would be more for enterprise-y sorts of access, and so from a purely OSS perspective, may fall outside of reasonableness (unless you got some Enterprise to sponsor you 😄), but item 1 I think would be more generally purpose.

OK, I think there may be a way to support 2FA / CAPTCHAs / etc.
I could add an option which pops open an actual browser interface and waits for a human being to use that interface to login to the system - solving CAPTCHAs, doing 2FA - whatever it takes.
Then, once they have signed in, shot-scraper could dump out the resulting cookies to disk and use them for subsequent operations.
If the cookies expire that's fine - it can show an error and tell the user they need to authenticate again.
This would be a bit complex to build, but not impossible... and it would unlock a LOT of value for people.
As someone on the Write the Docs Slack pointed out, "Almost every product I've documented has been a Saas site with authentication". So this matters.

Playwright has some very relevant documentation on this here: https://playwright.dev/python/docs/auth

I'm going to save the file with 0600 by default, like in https://github.com/simonw/google-drive-to-sqlite/commit/18143e99cd5c16ee02bc04c9054f4be00415bcf6

This prototype works! It opens the browser window, and then dumps out the resulting cookies as JSON when the user hits "enter":
@cli.command()
@click.argument("url")
def auth(url):
    """
    Open browser so user can manually authenticate with the specified site,
    then save the resulting authentication context to a file.

    Usage:

        shot-scraper auth https://github.com/
    """
    with sync_playwright() as p:
        browser = p.chromium.launch(headless=False)
        context = browser.new_context()
        page = context.new_page()
        page.goto(url)
        click.echo("Hit <enter> after you have signed in:")
        input()
        storage = context.storage_state()
        print(storage)

I'm not going to default to dumping to standard out because that feels unsafe. I'll let people specify - if they really do want that.
I think this command takes two required arguments: the URL and the file to write the resulting state to.

Just tried this out with my blog:
% shot-scraper auth https://simonwillison.net/admin/ auth.json
Hit <enter> after you have signed in:

% cat auth.json
{
    "cookies": [
        {
            "sameSite": "Lax",
            "name": "csrftoken",
            "value": "OEYfJYoP...",
            "domain": "simonwillison.net",
            "path": "/",
            "expires":<PHONE_NUMBER>.345368,
            "httpOnly": false,
            "secure": false
        },
        {
            "sameSite": "Lax",
            "name": "sessionid",
            "value": "...",
            "domain": ".simonwillison.net",
            "path": "/",
            "expires":<PHONE_NUMBER>.345399,
            "httpOnly": true,
            "secure": true
        }
    ],
    "origins": []
}

That totally worked!
shot-scraper shot https://simonwillison.net/admin/ -o logged-in.png -a auth.json --wait 1000

The auth command could take the standard --javascript option.
It could also take a --headless option - which causes it to open the page in regular headless mode, execute that JavaScript and then close the page again.
This would allow you to automate logins on pages that support it:
shot-scraper auth https://site.local/ auth.json --headless --javascript "
document.getElementById('#username').value = 'username';
document.getElementById('#password').value = 'password';
document.forms[0].submit();
"

Testing against https://datasette-auth-passwords-demo.datasette.io/
Ran this:
shot-scraper auth https://datasette-auth-passwords-demo.datasette.io/-/login ds-auth.json

So now:
% shot-scraper accessibility -a ds-auth.json https://datasette-auth-passwords-demo.datasette.io/
{
    "role": "WebArea",
    "name": "datasette-auth-passwords demo: _internal, public, private",
    "children": [
        {
            "role": "DisclosureTriangle",
            "name": "Menu"

Compare with:
% shot-scraper accessibility https://datasette-auth-passwords-demo.datasette.io/
{
    "role": "WebArea",
    "name": "datasette-auth-passwords demo: public",
    "children": [
        {
            "role": "heading",
            "name": "datasette-auth-passwords demo",
            "level": 1
        },
        {
            "role": "text",
            "name": "Sign in at"
        },

shot-scraper pdf -a ds-auth.json https://datasette-auth-passwords-demo.datasette.io/ --landscape -o l.pdf


Restart kubelet

Want a scenario to restart the kubelet,

Ran few tests and the scenario works as expected. Thanks @paigerube14!


onShowResult not working in android

onShowResult is not triggered after result list is being rendered.
<Autocomplete   ... onShowResult={() => console.log('onShowResult triggered')} ... />

I gave console.log() directly inside braces and it works.


ManyToManyConcurrentArrayQueue with capacity = 1

Hi,
I was playing with ManyToManyConcurrentArrayQueue and got confused about behaviour of the queue when I set its capacity to 1.
My agrona version is 0.4.8 and here is my test:
import org.junit.Test;

import static org.junit.Assert.assertFalse;
import uk.co.real_logic.agrona.concurrent.ManyToManyConcurrentArrayQueue;

public class ManyToManyTest
{

    private ManyToManyConcurrentArrayQueue<Integer> queue = new ManyToManyConcurrentArrayQueue<>( 1 );

    @Test
    public void shouldNotOfferSecondInteger() {
        queue.offer( 1 );
        assertFalse(queue.offer( 2 ));
    }

}

queue.offer(2) overwrites the first element and returns true. Is ManyToMany queue with capacity=1 not supported (I check the source but couldn't see anything related to it) or am I missing something?
Thanks in advance

The algorithm is not designed for a size of 1. I'll look it tomorrow and put in check to ensure the capacity is sufficient.

yeah, that was my guess.
thanks a lot for the clarification


Research: Use of Argo rollouts for b/g and canary

The result of this issue is KEP 23

The initial version of the helm-deploy-service as well as a branching strategy according to the shipyard can be found in this branch: https://github.com/keptn/keptn/tree/research/2128/helm-deploy-service


optimized hasproperty(o::Py, attr) = pyhasattr(o, attr)

Currently, hasproperty(o, attr) works by falling back to Julia's default method, which checks attr in propertynames(o).   This is functional but rather inefficient because it first constructs the propertynames list.
Since you already have an optimized pyhasattr method, it seems like you should just define:
hasproperty(o::Py, attr::Symbol) = hasproperty(o, String(attr))
hasproperty(o::Py, attr::AbstractString) = pyhasattr(o, attr)

Good idea, this is more consistent with getproperty and setproperty. Done.


Rotate publishing credentials

Codecov announced a security breach with their bash script to publish code coverage which could compromise environment variables on CI environments: https://about.codecov.io/security-update/.
This could impact our publishing credentials.
This change is to take care of it

Pull Request Test Coverage Report for Build 5407

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.327%

Totals

Change from base Build 5399:
0.0%

Covered Lines:
13552

Relevant Lines:
19270

💛  - Coveralls


XMLStreamReaderHandle offers no way to close the underlying InputStream

I just discovered that XMLStreamReader.close() does not close the underlying input source.  That means we need a way clients can tell us to close the InputStream we hand to XMLStreamReader.receiveContent().  We will add a close() method to XMLStreamReaderHandle which explicitly will close the input source.
This affects b3_0, b2_0, and b1_0.

Here is the testcase I am trying to write to verify this and I dont see what I am expecting, it could be a test issue but wanted to get opinion on it, I was expecting a exception if we still try to read handle after it get closed but it seems like it wont.
public void testXmlStreamReaderHandleClose() throws IOException, SAXException, ParserConfigurationException, TransformerException, XMLStreamException
	{
		String filename = "xml-original-test.xml";
		String uri = "/write-xml-XMLStreamReaderHandle/";

		System.out.println("Running testXmlCRUD");

		// connect the client
	    DatabaseClient client = DatabaseClientFactory.newClient("localhost", 8011, "rest-writer", "x", Authentication.DIGEST);

	    // write the doc
	    writeDocumentReaderHandle(client, filename, uri, "XML");

	    XMLStreamReaderHandle readerHandle = new XMLStreamReaderHandle();
	    // read the document
	    for(int i=0;i<101;i++){
	    	// create handle
	    	DocumentManager docMgr = null;
			docMgr = documentManagerSelector(client, docMgr, "XML");
			docMgr.read(uri + filename, readerHandle);
	         // access the document content
	        String readContent = convertXMLStreamReaderToString(readerHandle.get());
	    // get xml document for expected result
		Document expectedDoc = expectedXMLDocument(filename);
		String expectedContent = convertXMLDocumentToString(expectedDoc);
		expectedContent = "null"+expectedContent.substring(expectedContent.indexOf("<name>")+6, expectedContent.indexOf("</name>"));
		assertEquals("Write XML difference", expectedContent,readContent);
		readerHandle.close();

	    }
	    String exception = "";
	    try
	    {
	    	readerHandle.get();
	    } catch (Exception e) { exception = e.toString(); }
// Expecting an exception but I dont see one.
	    System.out.println(exception);
		// delete the document
	    deleteDocument(client, uri + filename, "XML");

		// release the client
	    client.release();
	}

Sounds like a good suggestion.  I created #265 for us to track.  Currently when you call XMLStreamReaderHandle.get() it just returns the XMLStreamReader.  I wouldn't be surprised if you got an error if you called any method on that closed  XMLStreamReader.

Yes I see an error if I try to use any method, since we are tracking it in a different bug, moving this to ship.


pT5 bug fix

Pixel Segment duplicates were not being removed in the pT5 newgrid kernel. This bug is now fixed
Comparison plots can be found here : http://uaf-10.t2.ucsd.edu/~bsathian/SDL/eff_comparison_plots__17dcf7dDIRTY_explicit_newgrid_17dcf7d_explicit_newgrid_PU200/TC_AllTypes__pt.pdf
http://uaf-10.t2.ucsd.edu/~bsathian/SDL/eff_comparison_plots__17dcf7dDIRTY_explicit_newgrid_17dcf7d_explicit_newgrid_PU200/TC_AllTypes__etacoarse.pdf

https://github.com/SegmentLinking/TrackLooper/blob/f09a227bf0891c1ec09d5208dec72aa29afdca42/SDL/Kernels.cu#L2693
can you also change "10" to "7" in this line (PR#79)

Plots after change here :-
http://uaf-10.t2.ucsd.edu/~bsathian/SDL/eff_comparison_plots__2a3209c_explicit_newgrid_17dcf7d_explicit_newgrid_PU200/


Why is the cpu sometimes 100% when render, sometimes only 10%?

Why is the cpu sometimes 100% when render, sometimes only 10%?
Some templates will be like this

I'm not sure, to be honest. I feel like it is most likely related to aerender itself.


Hggingface Space ?

Can a Huggingface Space be made for this project ?

Thank you for your suggestion. We have added this requirement to our to-do list.


Explore Accessibility Options

This component does not currently have any accessibility considerations.
As we are converting an accessible view into an image and then a video stream, the original accessibility metadata is lost. Users using a screen reader (or similar technology) may not be able to use this feature.
This tickets is open as a reminder that I would like to look into this further. I am currently unfamiliar with accessibility in general for "typical" PiP use cases - as in, actual video content. However, I would expect video captions to usually be available through PiP - we may be able to utilise this and provide accessibility data through captions.
If anybody has information that may be helpful then please drop a comment below!

After diving into the view hierarchy, it does appear that there is an internal 'FigSubtitleCALayer' present which likely means captions are possible.
I've explored quite a lot of different posts (the most promising linked below) but have been unable to find the perfect combination of APIs to allow us to inject subtitles into our buffer layer.
https://developer.apple.com/forums/thread/700128
https://github.com/norio-nomura/DisplayLinkPlayer/blob/master/DisplayLinkPlayer/SampleBufferDisplayLayerView.swift
It might be that we need to essentially implement an AVPlayer, and route through the view buffer to that which will allow us to add both audio (#11) and subtitles/captions.


Validate Subcommand!

What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces to bom the capability to start validating things. For now, only files attached to the first level of the document are supported and we will be introducing more artifact types and other kinds of validation.

Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Test for document.ValidateFiles() is coming in a followup shortly
Test is now included
/assign @cpanato
Does this PR introduce a user-facing change?
`bom` can now validate artifacts! We now have a new validate subcommand that can be used to check files attached to the top of the SBOM: `bom validate sbom.spdx file.txt`. No more checksum.txt files! 🎉

thanks for this feature

Ready,foxed the nit and also pushed the new function test. Please take another look when you have time @cpanato

Fixed the merge conflicts :rocket:

/lgtm


Add the option to raise issue when license submission failed

Give an option to the license submitter to raise an issue to the SPDX online tools repository when an error has been encountered. This will make it easier to track the errors and fix them asap.

@rtgdk @SantiagoTorres Could you both please take a look at it once and lmk if it's fine?

@rtgdk @SantiagoTorres Please take a look now, I have made the modifications. Thanks

@Ugtan Overall looks good to me, Can you also paste the screenshot/issue created after clicking submit? Left some comment to address, I'll merge it after that.

@rtgdk I will post the screenshot tomorrow.

@Ugtan Can you please address the comments and post the screesshot here?

@Ugtan ping


Can not build/upload

I'm having two issues which prevent me from building/verifying

TimeLib.h

gtmRadio.cpp:8:10: fatal error: TimeLib.h: No such file or directory  #include <TimeLib.h>           ^~~~~~~~~~~ compilation terminated. exit status 1 TimeLib.h: No such file or directory
Upon further searching I found that it should be include <Time.h>

esp_log.h
gtmRadio.cpp:8:10: fatal error: TimeLib.h: No such file or directory #include <TimeLib.h>        ^~~~~~~~~~~ compilation terminated. exit status 1 TimeLib.h: No such file or directory

I'm getting the same errors on "playharder.cpp"
I made sure to download and install the dependencies from here:
https://github.com/Xinyuan-LilyGO/LilyGO-T-Beam
This is the board I'm working with:
https://www.amazon.com/gp/product/B08GK8JP7Y/ref=ppx_yo_dt_b_asin_title_o04_s00?ie=UTF8&psc=1

Sorry, I included the wrong error log for esp_log.h But it's the same. No such file or directory "esp_log.h"

Excellent choice on the hardware - same model that I use! :)
I can see a few issues here, mostly the result of incorrect/incomplete documentation at my end - my apologies for this. I have updated the README.

No such file or directory "esp_log.h"

It means that Arduino doesn't know we're compiling for an ESP target. You need to select the correct board ("T-Beam" in your case) from Arduino's Tools > Board menu.
If you don't have a "T-Beam" option in the list, you may need to (re)install the ESP32 support files in Arduino. See for instructions:
https://github.com/espressif/arduino-esp32/blob/master/docs/arduino-ide/boards_manager.md

TimeLib.h: No such file or directory

This was another error in my documentation (fixed now). You need to install the "Time by Michael Margolis" library from Arduino's Tools > Manage Libraries menu, this will fix the TimeLib.h error.

Upon further searching I found that it should be include <Time.h>

The header files TimeLib.h and Time.h (in the Margolis library context) used to be equivalent/interchangeable, however the latter has been deprecated due to a name conflict.
Discussion: https://forum.arduino.cc/index.php?topic=451360.0
Good luck!

Ah, one more thing:

I made sure to download and install the dependencies from here:
https://github.com/Xinyuan-LilyGO/LilyGO-T-Beam

We don't use any of those libraries at this stage, and it may actually be safer to put them away for the time being. :)

I was able to install everything I needed. The Time by Michael Margolis was way on the bottom and I had to scroll quite a bit to be able to install it. :)
I'm going to have to spend some time learning about how all of these work. I'm new to arduino. Not sure how to test the relay mode just yet as that's what my main goal on this is.

Hey, can we do a zoom session so I can learn a little more on how we might want to implement relay mode?

To enable the experimental relay mode, just type !sr1 in the serial console and press Enter. It should respond GTMLAB: RELAYING is now ON and that's it. :)
Before you do that, though, you should first make sure you can send and receive messages.
Try running your gtm-lab in the presence of some goTenna traffic and check for RX_MSG lines in the console. These indicate that gtm-lab is receiving radio traffic correctly.
Secondly, check for output lines that say GTMLIB: RELAYMSG (OFF), which indicate that the gtm-lab would have relayed the message in a relaying-enabled scenario.
Once you have this functionality confirmed, you can enable the relay (!sr1) and see how it works for you.
I'm sorry, I don't have zoom, but please feel free to open as many issues as you need - even if it's just to ask a question.


-a

I have no idea how to use the -a command. I have written every account down on the accounts.json file.

So in general I would avoid the screenshots and rely on a textual representation of the problem and the the output of the command, description of what the expected and actual behavior was and an accurate title. For an example of the output of the command:
$ crunchyroll-guest-pass-finder.py -a
usage: crunchyroll-guest-pass-finder.py [-h] [--auto AUTO] [--delay DELAY] [--log-level {CRITICAL,ERROR,WARNING,INFO,DEBUG,NOTSET}] [--dry-run]
                                        [--username USERNAME] [--password PASSWORD] [--save] [--list-users] [-v]
crunchyroll-guest-pass-finder.py: error: argument --auto/-a: expected one argument

That said this is a simple problem. The auto option was expecting an explicit argument.
crunchyroll-guest-pass-finder.py -a true would work. I agree with you though that this isn't intuitive and wasn't intentional.
Thanks for pointing it out and it'll be fixed shortly

So in general I would avoid the screenshots and rely on a textual representation of the problem and the the output of the command, description of what the expected and actual behavior was and an accurate title. For an example of the output of the command:
$ crunchyroll-guest-pass-finder.py -a
usage: crunchyroll-guest-pass-finder.py [-h] [--auto AUTO] [--delay DELAY] [--log-level {CRITICAL,ERROR,WARNING,INFO,DEBUG,NOTSET}] [--dry-run]
                                        [--username USERNAME] [--password PASSWORD] [--save] [--list-users] [-v]
crunchyroll-guest-pass-finder.py: error: argument --auto/-a: expected one argument

That said this is a simple problem. The auto option was expecting an explicit argument.
crunchyroll-guest-pass-finder.py -a true would work. I agree with you though that this isn't intuitive and wasn't intentional.
Thanks for pointing it out and it'll be fixed shortly

It only logins to 1 account:

C:\Users\itzro>python "C:\Users\itzro\Desktop\CrunchyrollGuestPassFinder-master (3)\CrunchyrollGuestPassFinder-master\crunchyroll-guest-pass-finder.py" -a true
INFO:logged into itzrondy
INFO:searching for guest passes
INFO:Assuming [] are already used
INFO:Trial

0

It'll login into 1 account at a time. It basically loops over all accounts and does the scraping for each one. If the script tried to do run each  in parallel, they'd just compete with each other and the process wouldn't go any faster.


Cannot install this plugin on latest clion

I'm unable to install this plugin on latest clion: https://youtrack.jetbrains.com/issue/CPP-26061
This issue appears only for org4idea plugin.

got the same, in logs i've found
2021-08-07 10:56:44,772 [  32697]   INFO - lij.ide.plugins.DynamicPlugins - Plugin Org4Idea is not unload-safe because of extension to non-dynamic EP com.intellij.fileTypeFactory

@huhuang03 hi, thanks for your work, installed from https://github.com/huhuang03/org4idea/releases/tag/for_java11
But cannot build myself:

It needs chmod +x gradlew (this need commit for convenient use)

After, chmod, If I do ./gradlew:
$   ./gradlew
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain

Seems gradlew wrapper not properly configured. You need add org4idea/gradle/wrapper/gradle-wrapper.jar to repository. gradlew uses this jar if gradle not installed in system.

But even I use installed correct version gradle and java in system I cannot build plugin. I got:
$  gradle buildPlugin

To honour the JVM settings for this build a single-use Daemon process will be forked. See https://docs.gradle.org/7.2/userguide/gradle_daemon.html#sec:disabling_the_daemon.
Daemon will be stopped at the end of the build

FAILURE: Build failed with an exception.

* Where:
Build file './org4idea/build.gradle' line: 8

* What went wrong:
Plugin [id: 'org.jetbrains.intellij', version: '1.2.0'] was not found in any of the following sources:

- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Plugin Repositories (could not resolve plugin artifact 'org.jetbrains.intellij:org.jetbrains.intellij.gradle.plugin:1.2.0')
  Searched in the following repositories:
    Gradle Central Plugin Repository

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 4s

I stuck with this and unfortunately don't understand how to fix this error.

Hope this help improve you PR. I will help to test changes if you provide some fixes.
Anyway thanks for help, I've installed plugin from zip archive.
Seems works as expected.

I'm also looking at the PR, the above should indeed work but I'm looking at a different angle: rather than manually adding the wrapper JAR I'd leave the task to gradle itself. Here's what works:

set an environment variable to ORG_GRADLE_PROJECT_jetbrains_token to anything, empty string should suffice
run gradle wrapper to both update the wrapper as well as downloading the required supporting files

After doing that, ./gradlew buildPlugin should build successfully

Yes, it works as you described, but in any case, ./gradlew script especially intended to run gradle-wrapper.jar downloader for gradle on machines where gradle not installed at all. So strictly speaking ./gradlew in repo without gradle-wrapper.jar does not make sense at all (as it describe in  tutorial).
Last argument is it's great to have a repeatable build on any machine regardless of the environment. I would also add JVM version check as I got an unobvious error when trying to build a project on JVM 8.
The decision is always yours. But it's always great when a project is being built by one command.
With no additional steps required. I'm NOT writing for criticism - just want to improve the build process a little.

it's all appreciated, thanks. I'm a bit far away from gradle / java these days so it's all very welcome input

@mrkeuz . Thanks for the guide, I have update the PR.
But the java toolchain seems not work
java {
    toolchain {
        languageVersion = JavaLanguageVersion.of(11)
    }
}

Still get the error:
              - Incompatible because this component declares an API of a component compatible with Java 11 and the consumer needed a runtime of a component compatible with Java 8

@huhuang03 great, thanks for changes! I also finally way to check java version. I've sent changes to you java11  branch (#1)

@huhuang03 found the trick for check java version (see #2)

@mrkeuz Thank you. I have merged.


Bump apptest-framework to v1.0.0

This PR:

Updates apptest-framework to v1.0.0 that now handles cluster creation within the test framework

Checklist

[x] I added a CHANGELOG entry
[x] I ran E2E tests in the CI pipelines

Add the following comment to trigger the E2E tests:
/run app-test-suites

/run app-test-suites

wtf? That test run failed. That shouldn't say success

/run app-test-suites-single PROVIDER=capa


Fix TOC & AppData note

Acrolinx Scorecards
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard

docs-ref-conceptual/TOC.md
100
0
link

docs-ref-conceptual/install-azure-cli.md
80
8
link

More info about Acrolinx

The scorecard links are good for one hour. If you're prompted to authenticate, you can close and reopen the PR to get new links. Or, use these credentials:
Account: report-viewer
Password: kermit$
Report false positive results or other issues

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-autogen/TOC.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/TOC.md
:white_check_mark:Succeeded

docs-ref-conceptual/install-azure-cli.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Date picker incorrectly formats date when specified in "dd.mm.yy" format

Description
When I set the locale of the date picker to 'de-DE', i expected that the auto completion would also change to this specific format but when i typed in 10.1.24 the value changed to 01.10.2024 while it should be 10.01.2024
Link to Reproduction (or Detailed Explanation)
https://codesandbox.io/p/devbox/optimistic-glade-jcypf4
Steps to Reproduce

Copy the example code of the Date picker into an ark ui project
Add the locale prop to the root element and set it to 'de-DE'
Enter a valid date like '01.12.24'
See that it changed to '12.01.2024'

Ark UI Version
3.7.0
Framework

[X] React
[ ] Solid
[ ] Vue

Browser
Chrome
Additional Information
No response

bump i faced the same issue


switch to using the libmamba server on windows

hopefully this resolves the CI problems?
If it does help then we can change the other configurations as well.

Actual solution in #6325


MDRaisedButton md_bg_color attribute won't work as expected

Description of the Bug
You cannot instantiate a new MDRaisedButton in python with altered color even though md_bg_color parameter is provided with a new color.
Code and Logs
NOK as parameter
from kivy.uix.screenmanager import Screen
from kivymd.app import MDApp
from kivymd.uix.button import MDRaisedButton

class App(MDApp):
    def build(self) -> None:
        screen = Screen()
        raised_button = MDRaisedButton(
            text="Hello",
            md_bg_color=[1, 0, 0, 1],
            pos_hint={"center_x": 0.5, "center_y": 0.5},
        )
        screen.add_widget(raised_button)
        self.root = screen

app = App()
app.run()

OK as attribute set
from kivy.uix.screenmanager import Screen
from kivymd.app import MDApp
from kivymd.uix.button import MDRaisedButton

class App(MDApp):
    def build(self) -> None:
        screen = Screen()
        raised_button = MDRaisedButton(
            text="Hello", pos_hint={"center_x": 0.5, "center_y": 0.5},
        )
        raised_button.md_bg_color = [1, 0, 0, 1]
        screen.add_widget(raised_button)
        self.root = screen

app = App()
app.run()

Versions

OS: Windows 10
Python: 3.8.3
Kivy: v2.0.0rc2
KivyMD: v0.104.1 (master)

@mozesa So far it will work that way.


Remove dependency on debug

I don't think we're actually using this?
I don't think we've used this since before logging (~January 2015)?
Anyway, nsp reported a regexp denial of service vulerability.  So, instead
of upgrading I'm just removing, since... I don't think we're actually using
this? :grin:

Note that travis is failing on this in master right now, so PRs may need to be rebased once this lands.

👍

Added a few more changes here: Upgraded to the latest beta of lerna because that's what it took to get the dependency change in react-server picked up at bootstrap time.  I also cleaned up our .travis.yml (modeled after what I did for stratocacher) because that had been bugging me for a while.  Runs a little faster without the redundant global installs of gulp and lerna.

Gonna merge this to get other PRs unblocked.
Next time you update from master be sure to upgrade lerna.


Add docker support for contracts tests

Building on the structure used for PDO, this commit adds a recipe for
building a contracts container that can be used for testing of the
contracts and the jupyter interface to the contracts.
The structure is similar to the PDO docker support: keys and
configuration variables are shared through the xfer directory. Tools
run in the container build the contracts, run the tests, and also run
a jupyter server.
The behavior can be customized through a local makefile that allows
for override of variables. A local environment file can be used to
customize the behavior docker compose.
Run contract tests: cd docker; make test
Run a Jupyter server: cd docker; make test_jupyter

First pass of comments after (trying to) run the docker tests as my issue found below probably also will be a stumbling block for others.
BTW: now as we have 22.04 but you only adding libgl, did we change recently anything else in inference contract that guarding doesn't need the libcudart libraries anymore?

i was able to build & run just fine with only libgl using the pdo 0.2.99 (ubuntu 22) containers. did yours fail? (there is something else going wrong with the inference contract... but i don't want to debug that problem in this PR)

i was able to build & run just fine with only libgl using the pdo 0.2.99 (ubuntu 22) containers. did yours fail? (there is something else going wrong with the inference contract... but i don't want to debug that problem in this PR)

Now, it did all work fine. That's what surprised me as when i tried earlier -- what triggered the 22.04 pdo pr .. -- guardian start failed with unresolvable libcudart and afaict you call essentially the same tests which failed then but do not fail now. i couldn't spot in this PR any other change which could have explained that.  That said, there are a number of pdo-contract prs which i haven't checked; maybe also something changed in the pip package?  anyway, good thing it works now without libcuda as that brought a rathole of other packages and anyway seemed strange why an api service would need it (arguably, the same holds also for libgl ...)

A readme.md much like what we have in the pdo HL repo (regarding usability of contracts container beyond just testing via test.yaml) would be very helpful.

You are absolutely correct. We really need documentation for this. AND... we need to update the readme in the PDO repository as well.
You had other comments about creating more useful docker compose files. I'm actually strongly opposed to that. The problem is that the particulars of the compose configuration are highly dependent on the particulars of your deployment. and every deployment is likely to be unique. the test.yaml provides a very good example of how to put the pieces together. better documentation about start_client.sh (in the PDO repository) and start_jupyter.sh (in the contract repo) should address those needs.

2. The site.toml file creation cell in the issuer notebook is no longer a SKIP since it runs within a container. might be a point of confusion for some one who wants to just test the contract without understanding the details of the deployment (the whole point of this dock erization).

are you talking about the cell to create the groups file? it certainly should be optional. if you've copied in a configuration, with your own groups file then you absolutely do not want to run that.


⚠ Bofrost.at has degraded performance

In ed7d14a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 955 ms

Resolved: Bofrost.at performance has improved in 5331ec2 after 6 minutes.


need to remove the dependency for catalog module

currently maps to catalog module in module yaml, need to remove that and specify the entitlement key in bom as global var

closed with release 1.0.4


[ISSUE #2240] (Optimize) change Boolean.True to true.

[ISSUE #2240] (Optimize) change Boolean.True to true.

LGTM


Unable to rename tables

Describe the bug
There is no way to rename a table after that table has been created from Designer tab.
To Reproduce
Steps to reproduce the behavior:

Create a table in Designer tab
Select the table and try to rename it

Expected behavior
Renaming a table is a must have feature.
Environment (you can view the current version under Settings):

Operating System [e.g. Windows]: w11 Pro
Surrealist Version [e.g. 1.2.0]: 1.11.3
SurrealDB Version [execute "surreal version"]: 1.1.1

Unfortunately table renaming isn't supported by SurrealDB currently hence this functionality is missing in Surrealist.
I'll continue to consider implementing this behavior in some capacity with or without direct support in SurrealDB.
Thanks!


[FLINK-19681][checkpointing] Timeout aligned checkpoints

This is an updated version of #13827 to pass the tests and address the remaining feedback.

@flinkbot run azure

@rkhachatryan Did you complete working for FLINK-19681? I'm waiting for you for the completion of this pull request.

@SteNicholas yes, but I think the PR won't be merged soon. I expect a lot of feedback from @pnowojski
The latest AZP failure is caused by FLINK-19863

Thanks for reviewing @pnowojski.
Yes, the tests are stable (I'll check it again though since I rebased the PR recently).
I agree about unit tests, will add them and address other issues.

I've updated the PR and addressed your feedback @pnowojski, please take a look.

@flinkbot run azure


Enable to specify reverberation time of MIRD

Summary
By this PR, you can specify the reverberation time of MIRD.
You can choose 0.16, 0.36, or 0.61.
Notes
MIRD: https://www.iks.rwth-aachen.de/en/research/tools-downloads/databases/multi-channel-impulse-response-database/

Codecov Report
Base: 94.93% // Head: 94.94% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (35d0eac) compared to base (dfeee9f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   94.93%   94.94%
=======================================
  Files          31       31
  Lines        3794     3798    +4
=======================================
+ Hits         3602     3606    +4
  Misses        192      192

Impacted Files
Coverage Δ

ssspy/utils/dataset/__init__.py
100.00% <100.00%> (ø)

ssspy/utils/dataset/mird.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[AVM Module Issue]: res/web/site not appending EndpointSuffix to AzureWebJobsStorage

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
Module Name
avm/res/web/site
(Optional) Module Version
0.3.7
Description
Using the following module call:
module function 'br/public:avm/res/web/site:0.3.7' = {
  name: '${functionName}-deployment'

  dependsOn: [
    storage
  ]

  params: {
    name: functionName
    location: location

    kind: 'functionapp,linux'
    serverFarmResourceId: asp.outputs.resourceId
    appInsightResourceId: appInsights.outputs.resourceId
    storageAccountResourceId: storage.outputs.resourceId

    managedIdentities: {
      systemAssigned: true
    }

    siteConfig: {
      alwaysOn: false
    }

    appSettingsKeyValuePairs: {
      FUNCTIONS_EXTENSION_VERSION: '~4'
      FUNCTIONS_WORKER_RUNTIME: 'java'
      AZURE_FUNCTIONS_ENVIRONMENT: environmentName == 'prod' ? 'Production' : 'Development'
      FUNCTION_APP_EDIT_MODE: 'readonly'
      WEBSITE_CONTENTAZUREFILECONNECTIONSTRING: storageAccountConnectionString
      WEBSITE_CONTENTSHARE: functionName
    }
  }
}

I've set Java version 17 and OS as Linux in pom.xml.
The module sets the app setting/environment variable AzureWebJobsStorage as expected. However, it does not append EndpointSuffix=core.windows.net. This leads to the following error when trying to deploy to the function using the Github Action Azure/functions-action:
Error: Invalid EndpointSuffix in the provided Connection String
    at extractConnectionStringParts (/home/runner/work/_actions/Azure/functions-action/v1/node_modules/@azure/storage-blob/dist/index.js:13685:23)
    at BlobServiceClient.fromConnectionString (/home/runner/work/_actions/Azure/functions-action/v1/node_modules/@azure/storage-blob/dist/index.js:24336:32)
    at WebsiteRunFromPackageDeploy.<anonymous> (/home/runner/work/_actions/Azure/functions-action/v1/lib/publishers/websiteRunFromPackageDeploy.js:27:70)
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/Azure/functions-action/v1/lib/publishers/websiteRunFromPackageDeploy.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/_actions/Azure/functions-action/v1/lib/publishers/websiteRunFromPackageDeploy.js:4:12)
    at WebsiteRunFromPackageDeploy.execute (/home/runner/work/_actions/Azure/functions-action/v1/lib/publishers/websiteRunFromPackageDeploy.js:23:16)
    at ContentPublisher.<anonymous> (/home/runner/work/_actions/Azure/functions-action/v1/lib/handlers/contentPublisher.js:25:68)
    at Generator.next (<anonymous>)

If I manually append EndpointSuffix=core.windows.net to AzureWebJobsStorage in the Azure Portal deployment works fine.
(Optional) Correlation Id
No response

A workaround seems to be to set the AzureWebJobsStorage-parameter directory in appSettingsKeyValuePairs and unset storageAccountResourceId.
var storageAccountConnectionString = 'DefaultEndpointsProtocol=https;AccountName=${storage.outputs.name};AccountKey=${listKeys(resourceId('Microsoft.Storage/storageAccounts', storageAccountName), '2023-01-01').keys[0].value};EndpointSuffix=${environment().suffixes.storage}'

(...)

AzureWebJobsStorage: storageAccountConnectionString

This might not work if you're configuring slots, as it also seems to use the storageAccountResourceId-parameter. Additionally, there might also be issues if the storage account doesn't already exists when the listKeys()-function is ran.

Hi There - Thanks for logging this issue. We shall triage this wc 8th July.


Sort Block Types (and combine all block types into one list in dashboard)

Re-do of pull request #148 . This time I didn't bother with the "show/hide" thing, it's just the display order.

Really nice job. I have manually merged this into the 5.5.2-devel branch. I made a change to how the default sort order was computed (so it behaved the same and didn't result in blocks being in their opposite order) but other than that didn't touch anything. Looks good.


Add neo4j m2 repo (community) & always run the plugins tests

Please see the related trello card.
I've tidied up the commit history and added an environment variable so we can enable/disable the test in a more fine grained way using team city environment parameters


Coverage target and docs

Add coverage target and document how to run the tests and inspect coverage.

Why do we need a coverage target? The coverage target is another target in the Makefile which is to ease understanding ho go coverage can be reported?
The discussed intention was to provide a coverage report at the end, that can then be a CI routine that covers if the current PR degrades coverage from the current branch coverage. Is this leading towards the same?

Why do we need a coverage target? The coverage target is another target in the Makefile which is to ease understanding ho go coverage can be reported?

For the same reason we need all the other targets in the makefile, all of them are just trivial wrappers using some tool that the developer can use manually.
We want that developers will check coverage when modifying the code and adding tests, and the way to make it happen is make it easy to inspect coverage.

The discussed intention was to provide a coverage report at the end, that can then be a CI routine that covers if the current PR degrades coverage from the current branch coverage. Is this leading towards the same?

Coverage report in the CI is orthogonal. This is more complicated and may require interaction with another service so it should not be the only way we have to inspect coverage.


added plugin support (possibly #7)

I started working on it before seeing that you wanted to define plugins in App. I believe this is a better solution as it allows to, for example, create plugins specific to a controller / route.
I don't have experience testing addons (ember test wouldn't work for me) so there is just an example plugin in controllers/application.js.
If you want me to make it possible to define plugins in App just reject that PR and let me know, should be too hard.

Thanks @maciek134! This is looking great. I will take it for a spin this weekend and get it merged and published!

One thing we might want to change is perhaps making plugins defined globally in the app config and then being able to toggle them off/on in props passed to the component, but I will do some more thinking on that when I can get around to this tomorrow. I will provide more in depth feedback then.
And thank you again for opening up the pr 🙇♀ !

I could make it work two ways, so you can define plugins in app config and in controllers / routes - unless we can figure out how to bring dynamic rendering back

Close / re-open seems to have fixed CI ;p
I could make it work in both ways - so you can define plugins in either app config or controller / route. I need the latter, because dynamic rendering doesn't work for me in Ember 2.10.0 - it's like there is no data available for the component.

Ok, I think I tried every way possible and plugins can't be stored in any config (be it app/config/environment.js or ember-cli-build.js) without resorting to some ugly hacks. Reasons: functions can't be stored in environment.js, because it's contents are compiled to JSON; anything in ember-cli-build.js is only available during compilation - here it probably could be hacked by creating some global with unique name and injecting it later in initializer.
I also realized that plugins for remarkable should be injected using md.use(), not how I implemented that.
Let me know if the hacky way is ok, that'll take a few lines of code to implement.

Thanks for looking into it. I didn't realize we wouldn't be able to pass in the plugins in ember-cli-build. I think we can avoid global plugin config (it was a "nice to have" anyway). My apologies for sending you off in the wrong direction 😬 .
So let's roll with this solution, where a wrapper component or controller can define the plugins to pass in to md-text. Though, before merge and release I'd like to add in a quick test and leverage md.use(). If you would like some help with creating a test please let me know!
✨ ✨ Thanks!

I'll make changes tomorrow morning, I've got the tests figured out.

For some reason ember-beta check fails on CI (even though ember-canary passes).

For some reason CI has been a little flaky (I think since the version of ember-cli is pretty out of date in this project). After restarting the build for beta it has now passed. So, I'll go ahead and merge/release now.
Thank you! 🎉

Published to npm as<EMAIL_ADDRESS>Let me know if you encounter any issues!


feat: revamp testimonials sliding animation design 🪄✨

Description

Revamped the slider design to enhance the testimonials section of About Us Page

Fixes #786
Screenshots

BEFORE

AFTER

Checklist

[x] Tests have been added or updated to cover the changes
[x] Documentation has been updated to reflect the changes
[x] Code follows the established coding style guidelines
[x] All tests are passing

Please merge this PR @SurajPratap10


Support for changing button color in progress state

Bumping this :)

Hi,
Here is PR for this feature request. #49
Thanks!


Unable to open database file?

Just upgraded from the version I was using a week ago.  Now I get an unable to open database file error.  I am not providing a --db-engine argument and I'm just using the default of
sqlite:///state/gdax_history.db.  Do I need to initialize the db somehow?
BTW, I'm not using docker either, just running the script by hand passing arguments to it to test it out.
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/base.py", line 2147, in _wrap_pool_connect
    return fn()
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 387, in connect
    return _ConnectionFairy._checkout(self)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 766, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 516, in checkout
    rec = pool._do_get()
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 1229, in _do_get
    return self._create_connection()
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 333, in _create_connection
    return _ConnectionRecord(self)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 461, in __init__
    self.__connect(first_connect_check=True)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 651, in __connect
    connection = pool._invoke_creator(self)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/strategies.py", line 105, in connect
    return dialect.connect(*cargs, **cparams)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/default.py", line 393, in connect
    return self.dbapi.connect(*cargs, **cparams)
sqlite3.OperationalError: unable to open database file

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/myusername/crypto/optimal-buy-gdax-mine/optimal-buy-gdax.py", line 65, in <module>
    db_session = get_session(args.db_engine)
  File "/home/myusername/crypto/optimal-buy-gdax-mine/history.py", line 46, in get_session
    Base.metadata.create_all(engine)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/sql/schema.py", line 3949, in create_all
    tables=tables)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/base.py", line 1928, in _run_visitor
    with self._optional_conn_ctx_manager(connection) as conn:
  File "/usr/lib/python3.5/contextlib.py", line 59, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/base.py", line 1921, in _optional_conn_ctx_manager
    with self.contextual_connect() as conn:
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/base.py", line 2112, in contextual_connect
    self._wrap_pool_connect(self.pool.connect, None),
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/base.py", line 2151, in _wrap_pool_connect
    e, dialect, self)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/base.py", line 1465, in _handle_dbapi_exception_noconnection
    exc_info
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/util/compat.py", line 203, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/util/compat.py", line 186, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/base.py", line 2147, in _wrap_pool_connect
    return fn()
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 387, in connect
    return _ConnectionFairy._checkout(self)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 766, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 516, in checkout
    rec = pool._do_get()
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 1229, in _do_get
    return self._create_connection()
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 333, in _create_connection
    return _ConnectionRecord(self)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 461, in __init__
    self.__connect(first_connect_check=True)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/pool.py", line 651, in __connect
    connection = pool._invoke_creator(self)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/strategies.py", line 105, in connect
    return dialect.connect(*cargs, **cparams)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/default.py", line 393, in connect
    return self.dbapi.connect(*cargs, **cparams)
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) unable to open database file

Fixed it.  I just had to mkdir state.  Keeping it open if you want to address it in the repo.

Yes that's right. It's a bit annoying that it doesn't automatically create the path. I'm going to update the default so you can run the script without having to explicitly create the dir.


Fix heap buffer overflow

Detailed description

Reserve extra byte for terminating null to prevent heap buffer overflow (https://github.com/radareorg/sdb/blob/master/src/text.c#L229) in last call of load_flush_line() (https://github.com/radareorg/sdb/blob/master/src/text.c#L364)
Test plan

...
Closing issues

...

@thestr4ng3r

Same issue as in #226. While your change fixes the issue for loading files without mmap, it is still technically wrong with how the API of sdb_text_load_buf() is meant to be used (the buffer is allowed to be only of the given size) and will also fail when loading a file which has a size of exactly a multiple of the pagesize with mmap.

Meh...  I’m not even the first...

Funny that we both found the bug within one hour after it has existed for 16 days.


EngineManager.reqCounts use AtomicInteger replace int for request statistics

Preflight Checklist

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
[X] I am not looking for support or already pursued the available support channels without success.

Version
1.3.1
Installation Type
Official Docker Compose
Service Name
DongTai-agent-java
Describe the details of the bug and the steps to reproduce it
I'm reading the DongTai-agent-java source code and found below code，Obviously this is not thread-safe，int shoud be replaced with AtomicInteger
public class EngineManager {

     private static int reqCounts = 0;

    //...

     public static void maintainRequestCount() {
        EngineManager.reqCounts++;
    }
}

Additional Information
No response
Logs
No response

Nice issue.


Maximum call stack size exceeded

Hello I'm trying to include:
require('script!../../../vendor/amcharts3/amcharts/plugins/export/export.min.js');

inside my project but when I try to enable the export property (the default one) I get:
Uncaught (in promise): RangeError: Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded

Thanks for pointing this out, can you give me few more details to be able to reproduce this issue?

Hi @maertz the problem was related with the previous release. I bought amcharts and exports was  included but when you try to use it it fail for the above reason. Using the new version fix the problem


Gray level slicing without background

Kindly assign me this

Go ahead!

@geekquad
https://github.com/mansi75/Image-Processing-OpenCV/tree/master/Gray_level_slice_without_background
kindly check.

@geekquad please assign me this issue

Hey @subhangi2731, it has already been assigned and a PR is already been made.
Will be opening more Documentation issues soon. Keep an eye.


Add minimal working code expample in experiment API docs

Summary
This change adds minimal working code examples to the API pages for each experiment,especially in characterizaion experiments. The minimal working code example is a code snippet which users can copy and paste to run the experiment.
Details and comments

This change solves the issue#1238 (See also the issue#1221).
In the API pages, the documentation for each experiment has been updated with its code example. Users are required to specify a backend in the code example. As a default, the backend is a simulator such as GenericBackendV2(num_qubits=27).
In some experiments,
CorrelatedReadoutError
ResonatorSpectroscopy
CrossResonanceHamiltonian and
EchoedCrossResonanceHamiltonian,
the backend is an IBM Quantum real device due to the backend.defaults() dependence of the code example.
In these cases, the code example explicitly imports the module qiskit-ibm-provider in order to retrieve the job on IBM Quantum real devices.
Therefore, requirements-dev.txt has been updated to add the dependency on qiskit-ibm-provider for running tests and building documentation.

PR checklist (template)

[x] I have read the contributing guide CONTRIBUTING.md.
[ ] I have added the tests to cover my changes.
[x] I have updated the documentation accordingly.
[x] I have added a release note file using reno if this change needs to be documented in the release notes.

PR checklist (additional in CONTRIBUTING.md)

[x] The code follows the code style of the project and successfully passes the tests.
[x] The API documentation has been updated accordingly.
[x] You have updated the relevant documentation or written new docs. In case the PR needs
to be merged without delay (e.g. for a high priority fix), open an issue for updating
or adding the documentation later.
[] You've added tests that cover the changes you've made, if relevant.
[] If your change has an end user facing impact (new feature, deprecation, removal,
etc.), you've added or updated a reno release note for that change and tagged the PR
for the changelog.
[x] If your code requires a change to dependencies, you've updated the corresponding
requirements file: requirements.txt for core dependencies,
requirements-extras.txt for dependencies for optional features, and requirements-dev.txt
for dependencies required for running tests and building documentation.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@coruscating, thank you for your review and suggestion, . The branch issue-#1238 has been updated.


this version will not work anymore

please release new version

Same to me
This version will not work anymore. Wait please until the next release. Sorry for inconvenience.

Same issues still persist, please have it released

yeh same issue

does anyone knows the reason it doesn't work anymore?


Mark compactify as a passing test

Compactify was never marked as a passing test after we got a regression
in https://github.com/sbt/sbt/issues/1553.
For some reason, the scripted setup was not recognizing tasks defined
locally in the build.sbt, and so we add this functionality to
IncHandler which is the responsible of mapping task keys to their
actual implementation in sbt-scripted.
Aside from moving this functionality around and marking the test as
passing, I took the liberty to modify the name of output-empty for
something clearer in spirit: checkNoClassFiles.

For some reason, the scripted setup was not recognizing tasks defined locally in the build.sbt

The scripted handler for Zinc does not support sbt, so I've marked a bunch of stuff pending when we started porting scripted tests over.

Thanks for confirming Eugene. It would be nice if in the future there's a way to still recognize concrete SBT settings like log levels.


[Improvement]: File names can easily be mistaken to be Arctic file format

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
File names can easily be mistaken to be Arctic file format, because the regular expression to parse file name is too common.
  private static final String KEYED_FILE_NAME_PATTERN_STRING = "(\\d+)-(\\w+)-(\\d+)-(\\d+)-(\\d+)-.*";

How should we improve?
Check the 2nd part of the fileName must be one of
  BASE_FILE(0, "B"),
  INSERT_FILE(1, "I"),
  EQ_DELETE_FILE(2, "ED"),
  POS_DELETE_FILE(3, "PD"),
  ICEBERG_EQ_DELETE_FILE(4, "IED");

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Subtasks
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Iceberg's format is like

If all the characters of the first 3 parts of uuid are all numbers, it will be mistaken as the Arctic file format.


Add civetweb HTTP sample

This PR adds support for CivetWeb - an external, POSIX-based HTTP library.
The form of this integration - filling the incompatibilities between CivetWeb and minimal libc - is a result of discussions on TSC and the networking forum, as described in #16683
Note that the additional hacky header only defines (and sometimes even declares) only the absolute minimum to get the sample to work.
Since the CivetWeb support for Zephyr is not yet merged, the west configuration points to our fork, thus - DNM.
It was tested on SAM E70 Xplained.
CC: @laperie @jukkar @PiotrZierhoffer @bel2125

Yes, actually initially the stacks were quite small but we were getting a BUS fault every now and then (usually when handling a bigger request). To avoid that we just made them very large. The current settings are an overkill for sure.
This can probably be fine-tuned to optimize the memory usage for all the thread stacks.

@pfalcon @tbursztyka could you review this patch, as well?

I'm on vacation till next week. We already discussed this matter a lot, so I wouldn't give to -1, and if other folks don't spot small issues, it should be good to go.


Fix for #29 - handling failures during installation

The fix is aimed to:

Check that installation was successfully executed by checking the list of installed packages.
Ensure that we are not starting installation on devices until they are ready to be used (rebooted).

This change is

Hi @czyzm, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

tasker/android.js, line 79 [r1] (raw file):
Firstly, we should not hard-code the package name to the code, because the CI is used for multiple different apps. Search this file for variable class_name and see if there would be a way to router that info to this function and use that instead of a hard-coded string.
Secondly, does this code now check that pm list packages actually lists the wanted package? I might be wrong, but in a success case, that package name should be in the stdout in case it is successfully installed?

Comments from the review on Reviewable.io

@czyzm, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

tasker/android.js, line 79 [r1] (raw file):
I've added usage of class_name.
Good point with the stdout - I did it basing on my tests - the issue was here that the params for exec callback function were misplaced - stdout should be first. As result I was checking in fact stdout but under name stderr - changed this.

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Interim release?

What's a recent known-good build?

+1 - Some beta or dev-like git-tags would also help doing autobuilds with F-Droid on own repositories.


I can't have more than 17 kits!

I saw a post that said you couldn't have more than 17 kits at once. I tried this myself and got the same result. I noticed that having more than 17 kits only affected the kit signs, not the usage of the /battlekits command.
Please take a look at this!

I'm pretty sure there is no formatting mistake in the configuration file.

Why 17 though?

How can I know?
Did you try this many kits and get the same result?

No I haven't yet abacus I don't understand what happens when you have 17 kits. Can you not create kit signs? Can you not use them?

You can't use kit signs in any way.

Have you taken a look at this?

Now this is embarrassing...
Turns out my version of PocketMine was not up to date! Wooooooow.
It works fine on the version I upgraded to. Wooooooooooow.
Well, sorry to disturb you! There is nothing wrong with your plugin!
Thanks for following!

Though, strange that it is 17 (reminds me of 0x11) and how it's affected by the PocketMine version.

What changed in-between the versions?
That's what I wonder


added jury duty email

@zeroSteiner @wolfthefallen

@wolfthefallen if that's the only change you can go ahead and fix it while merging, no need for @guitarmanj to address it.
Just pull down the branch locally to test it like usual, then make a commit fixing the EOF. Finally after you've addressed the change in the local branch, merge it into the master branch like usual. This will keep your changes but the latest commit will still be the merge.

@guitarmanj as always thank you for contributing to the repository