Enhance bm_diff

This fixes some issues bm_diff had with the new metrics from allocs_per_write and atm_add and others. Those were stored as strings in the json file, so changed_ratio would error out. This fixes that and also fixes some issues when the data is written in scientific form.
It also adds a command line flag in case you want to specify which metrics to track, since the output can get pretty messy if you do all of them.

@ncteisen @matt-kwong this and #10101 and #10095 seem to be doing similar things: with #10101 in now, can we recheck and decide amongst ourselves what's still needed?

I'll close #10095 in favor for this

No tests for this, merging early


Fix FQDN for pod in document dns-pod-service.md

In the doc talking about pod subdomain, there is a mistake of the FQDN of the pod

The FQDN for a pod should be ***.namespace.pod.cluster.local instead of ***.namespace.svc.cluster.local

Related Page : https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-hostname-and-subdomain-fields

The FQDN for a pod should be ***.namespace.pod.cluster.local instead of ***.namespace.svc.cluster.local

That's not completely true it can be both. Please note that

Any Pods exposed by a Service have the following DNS resolution available:
pod-ip-address.service-name.my-namespace.svc.cluster-domain.example.
In general, a Pod has the following DNS resolution:
pod-ip-address.my-namespace.pod.cluster-domain.example.

as stated here
Both FQDN will be valid.

For user ease, there can be a short explanation that both FQDN can be used. also would like to take some opinions from
/sig network
Also read this


Provide universal binary that support both Intel and Apple Silicon

On my new M1 MacBook, I'm trying to avoid running any Intel code in compatibility mode with Rosetta 2. Therefore, it would be nice if there were a version of Gitify built for arm64.
There are now builds of Electron for arm64 but I'm not sure how exactly the building & bundling would work, e.g. if a universal binary that contains both archs is feasible.

We now have support for Apple Silicon (#475, #478) - the website has 2 download buttons (Intel + Apple Silicon) 🎉 https://gitify.io/


Repository

Hi, is the repository still working for this? I am not finding the package when I try and install.
Thanks!

Hi,
Yes it's still works, but for access to  repository needs credentials. How get them you can read here https://haproxy-wi.org/installation.py

Perfect, thank you!

You are welcome:)

When I try to install manually roxy, I got a Error for the step where you use the command
sudo a2ensite roxy-wi.conf
the error says: ERROR: Site roxy-wi does not exist!
What can I do to fix it ?
Thanks

You can create config

The repositories are now open


Android Studio Compile of 6.0 controller app fails

There is probably a simple answer for this, but just getting back into FTC after months away. Opened my 6.0 controller project expecting to work with that to get going again while waiting for 2021/2022 release. However, I cannot compile anything as all imports of org.firstinspires.ftc.robotcore packages fail with Cannot resolve symbol 'robotcore'.

The 3rd-party hosting service we were using for 6.0 artifacts (called Bintray) was shut down. Update your project to version 6.2, and that will work.

7.0 is out now.

Thanks for the quick response and 7.0 notification.
On Mon, September 20, 2021 9:24 am, Noah Andrews wrote:

7.0 is out now.

--
You are receiving this
because you authored the thread.
Reply to this email directly or
view it on GitHub:

https://github.com/FIRST-Tech-Challenge/FtcRobotController/issues/154#issuecomment-923080726
Richard Corn
Software Devices LLC
P.O. Box 12299, Olympia WA. 98508
@.***Â Â Â www.swdevs.com


Add karanehra to Contributors list

FIrst Commit in the tutorial.

@karanehra, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

@Roshanjossey i was amazed your lighting fast response. I hit refresh and Voila!, there you were. In short, I've been developing websites for a better part of the year now. I want start (with my mediocre experience) contributing to the Open Source community.
The problem is i don't have a clue where to get started. After this tutorial where do i go? Some projects seem interesting but the problems are daunting.
Can you please guide me here?

@karanehra, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


[RequireJsBundle] Definition "oro.cache.abstract" does not exist.

https://github.com/orocrm/RequireJSBundle/blob/81bb71982747f057fb262b2fc713f56a1b266965/Resources/config/services.yml#L14
I am getting the following error when I use RequireJSBundle standalone.

The parent definition "oro.cache.abstract" defined for definition "oro_requirejs.cache" does not exist.

Can we drop this dependency?

Hello @kayue ! Thanks for raising up this issue. We tried to find good solution for this in #100 . If you have ideas how to drop this dependency feel free to submit PR or update initial one.
Thank you!

@alsma-magecore May I know where is this service being used in the RequireJSBundle.

It's used here for caching requireJS merged config.

Can we call setCache in PlatformBundle instead?
On Mon, Jan 12, 2015 at 6:04 PM, Alexander Smaga<EMAIL_ADDRESS>wrote:

It's used here
https://github.com/orocrm/platform/blob/master/src/Oro/Bundle/RequireJSBundle/Provider/Config.php#L71-71
for caching requireJS merged config.
—
Reply to this email directly or view it on GitHub
https://github.com/orocrm/platform/issues/215#issuecomment-69548864.

@kayue have you managed to get rid of this dependency?

The PR #496 should help on this


Add monitring overview to docs

What this PR does / why we need it:
Add docs to the metrics section
Which issue(s) this PR fixes:
Fixes #4337
Does this PR introduce a user-facing change?:
NONE

@khanhtc1202 I just added docs to docs-dev. Should I add it to docs too?

I just added docs to docs-dev. Should I add it to docs too?

Yes, please 👍 Also add that to the /docs-v0.43.x as well.

Also, I don't remember correctly, but do we have any places which mention the admin server of pipecd components? If not, I guess we should add it so that users can understand how to get the metrics from pipecd's components.

I couldn't find any places to mention "admin server" in documents.
What about just HTTP server? If we use "admin server", we need to explain a bit more about the role of "admin server".

What about just HTTP server? If we use "admin server", we need to explain a bit more about the role of "admin server".

I think we should make it clear what is admin server so that piped managing dev can understand where they can actually get the piped metrics, mentioning as "HTTP server" could lead to a confusing situation.

I got it 👍 I'll add the explanation about the "admin server".

@khanhtc1202 Fixed 👍

@khanhtc1202 Thanks! Can you approve it?

Approved, feel free to merge it on your pace.


Narrow suggestions in when and unless clauses

Category
Cedar editing features
Describe the feature you'd like to request
A way to “narrow” the suggestions offered by the extension in the when/unless clauses would be fantastic.
See attached screenshot - in the particular example I assert that resource is GCP::ProjectGrant, so ideally I would only see autocomplete suggestions pertaining the GCP::ProjectGrant resource.
This is a pain point for us because we have actions that can apply to many resource types, so it makes the autocomplete quite noisy.

Describe alternatives you've considered
Currently the workaround is to look through the list of suggestions and find the matching entity type on the right side of the selector dropdown.
Additional context
No response
Is this something that you'd be interested in working on?

[X] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

Fixed in #18 and part of release v0.6.2.
Working on changes for upcoming Cedar 3.x pre-release version

fixed in #20 for pre-release v0.7.2


Add link to archived discussions in README

Signed-off-by: Mihai Budiu<EMAIL_ADDRESS>

May I suggest you print to a PDF and put the PDF in this repo and link to that? Just in case google ever changes their URLs or that doc ever goes away, it is also saved away in a location in the repo.

@apinski-cavium see #1216


fast-path implementation of point-to-point distance

I was looking at the differences in performance of distance shown in this benchmark and found out, that sf has a special fast path implementation of distance computation if all geometries are points on a plane - https://github.com/r-spatial/sf/blob/32aa6c8c53005245493540b1359bc35fe50f0115/R/geom-measures.R#L200-L203
I think we could do the same, as if we measure the distance between points using numpy, we can get significant performance boosts. See below a replication of that benchmark using GEOS 3.12.1 and shapely main:
import shapely
import numpy as np

points = shapely.points(np.random.rand(4000, 2))

%%timeit
geos = shapely.distance(points, points.reshape(-1, 1))
# 4 s ± 21.1 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%%timeit
# linalg.norm is convenient and commonly used for this
assert (shapely.get_type_id(points) == 0).all()
coords = shapely.get_coordinates(points)
linalg = np.linalg.norm(coords[:, None] - coords, axis=2)
# 328 ms ± 4.44 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%%timeit
# but we can also be explicit, and faster
(shapely.get_type_id(points) == 0).all()
coords = shapely.get_coordinates(points)
sqrt = np.sqrt((coords[:, None][:, :, 0] - coords[:,0])**2 + (coords[:, None][:, :,1] - coords[:,1])**2)
# 71.2 ms ± 1.73 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

That is more than 50x faster than the GEOS version with identical results.
Would there be an appetite to get this implemented directly in shapely?

Somewhat related I noticed the following stackoverflow question that is somewhat related, but rather about geographic distances...
https://stackoverflow.com/questions/78324162/need-to-compute-distances-between-each-of-60-000-coordinates
I also wonder why it would/can/is faster that way than the implementation in GEOS. Maybe the implementation is GEOS could be improved?

Given the GEOS API is designed to do distance between single points, it is the best to do this kind of optimisation here. See https://github.com/libgeos/geos/issues/1066

Also see https://github.com/libgeos/geos/pull/1067

Thanks for opening that upstream issue, that seems to have triggered a nice speed-up ;)

sf has a special fast path implementation of distance computation if all geometries are points on a plane - https://github.com/r-spatial/sf/blob/32aa6c8c53005245493540b1359bc35fe50f0115/R/geom-measures.R#L200-L203

Does sf keep track that all the geometries in a collection (dataframe) are of a certain type?
It would be _some_overhead to have to check this (although also not that big, below for a binary case, not matrix):
In [25]: import shapely
    ...: import numpy as np

In [26]: points = shapely.points(np.random.rand(4000, 2))
    ...: points2 = shapely.points(np.random.rand(4000, 2))

In [27]: %timeit shapely.distance(points, points2)
671 µs ± 1.44 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each)

In [28]: %timeit (shapely.get_type_id(points) == 0).all()
33.8 µs ± 334 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)

Or it could be a specialized API? (distance_points, and let it be the responsibility of the user to know and/or verify this)


M2: on*Activity() all need a context parameter

None of the on*Activity methods includes a context argument.
On the one hand they may not strictly be necessary. After all, in order to access these in the first place you need a context, and you can just close over it:
context.onSendActivity((activities, next) => {
    const state = conversationState.get(context);
    // do something with state
});

On the other hand, it makes it harder to just provide a function:
function doThing(context, activities, next) {
    const state = conversationState.get(context);
    // do something with state
}

context.onSendActivity((activities, next) => doThing(context, activities, next));

If context were an argument you could just do:
context.onSendActivity(doThing);

They actually do now but I haven't updated the docs yet. @cleemullins noticed this on Tuesday. I published the fix Tuesday but forgot to re-gen the docs.

fixed


Doesn't work in complex workspace

When trying to use the plugin from a complex workspace with multiple projects I get an error:
/home/user/.sdkman/candidates/java/<IP_ADDRESS>-tem/bin/java
-Dmaven.multiModuleProjectDirectory=/home/user/x
-Djansi.passthrough=true
-DspotlessFiles=.home.user.x.src.common.src.main.java.x.common.TableName\.java
-Dmaven.home=/home/user/.sdkman/candidates/maven/3.9.4
-Dclassworlds.conf=/home/user/.sdkman/candidates/maven/3.9.4/bin/m2.conf
-Dmaven.ext.class.path=/snap/intellij-idea-community/454/plugins/maven/lib/maven-event-listener.jar
-javaagent:/snap/intellij-idea-community/454/lib/idea_rt.jar=40583:/snap/intellij-idea-community/454/bin
-Dfile.encoding=UTF-8
-classpath /home/user/.sdkman/candidates/maven/3.9.4/boot/plexus-classworlds-2.7.0.jar:
/home/user/.sdkman/candidates/maven/3.9.4/boot/plexus-classworlds.license org.codehaus.classworlds.Launcher
-Didea.version=2023.2.1
spotless:apply

[ERROR] No plugin found for prefix 'spotless' in the current project and in the plugin groups
[org.apache.maven.plugins, org.codehaus.mojo] available from the repositories
[local (/home/user/.m2/repository), central (https://repo.maven.apache.org/maven2)] -> [Help 1]

Trying the command used by the plugin in a terminal, but adding -pl :x to the command line (x is the project name) is enough to make it work.

Hi!
Thank you for your participation.
Yeah, currently the plugin doesn't support multi projects in one IDE instance.
Only multi module projects or when all projects are located inside one folder and that folder is opened as one project in the IDE.
Will investigate how to add supporting for the case you mentioned.

I had some time and investigated the issue. Unfortunately, I couldn't reproduce the issue (built the workspace using in your way). Every time, the plugin resolved the build tools and executed the task successfully.
Could you please share a screenshot of the project window? Additionally, a screenshot of the 'Select modules' window (Ctrl+Shift+Alt+;) would be helpful.

I tried again the plugin and this time it seems to work without errors, I can't reproduce the error anymore.
There were a large number of pom changes on the project, java upgrade from 17 to 21, so whatever caused the incompatibility was probably changed.
I'll close the issue and reopen if I encounter it again.


Allow rollup number value to be nil

Addressing issue #26
In theory number in value in rollup always should have a value, but based on bug reports, there are situations where API returns a null value.

unable to reproduce


MSVC version incompatibilty (14.38 vs 14.41)

Hello, I'm hitting an issue where UE5 wishes to use MSVC 14.38 (for example, 'Generate Visual Studio Project' from the context menu will fail if I don't install this version of MSVC). However, when I try to compile UE5Coro wishes me to use MSVC 14.41.
I've followed the readme instructions e.g updated my .Target.cs files to use
DefaultBuildSettings = BuildSettingsVersion.Latest;
IncludeOrderVersion = EngineIncludeOrderVersion.Latest;

Not sure how to proceed, wondering if anyone has faced the same?

Oh it was just a warning! Going ahead with 14.41 when generating the VS project and it comes good.


Support event/time-based synaptic models

Take advantage of the callback features in ModelingToolkit.jl to create synaptic currents that reset based on presynaptic threshold crossing.

fixed by #54


Problem formatting Author and Book

The column Book and Author show a parenthesis in front of it.
Please view in the linked image:
https://pasteboard.co/06D2Ef91foYH.png
Is a syntax problem? How can I solve? Thanks

@diegos79  I don't know what the situation is. Could you explain in more detail?


Character Encyclopedia - Styling

Need to integrate the character search, comment thread, bookmark, and rating feature together stylistically rather than as separate components.
Bookmark and save rating buttons need to be styled with effects to ensure the user they are being hovered over and clicked.
Turn stars from rating into infinity stones.
Turn the post comment into the shape of a comic speech bubble

re-arranged the formatting of the bookmark and rating features and updated their styling slightly. another twist could be to turn the stars into infinity stones.
comment thread can still be further styled into the comic speech bubble


Morph svg with clip-path not works on Safari

Hi guys!
I'm trying to morph an svg. The problem is that the clip-path property not woks on Safari.
I provide a pen:
https://codepen.io/nicoladelazzari/pen/PRVEPp
Thanks!

Not sure if this is an anime issue. Safari seems to need a vendor prefix on clip-path (-webkit-clip-path) to work: https://caniuse.com/#feat=css-masks.

Hi @alexchantastic thanks for your answer.
How can I add vendor prefix in this particular case?

Thanks @alexchantastic
I need vendor prefix during anime morph. If I add vendor prefix as your suggestion morph doesn't show.
I have update pen link: https://codepen.io/nicoladelazzari/pen/PRVEPp

I think this might be an issue with clip-path support on Safari. Here is the related webkit bug: https://bugs.webkit.org/show_bug.cgi?id=126207
A way around this would be to force a repaint like so:
anime({
  targets: '#axure-svg .anime',
	points: [
    { value: '625.1,-3.7 237.2,0 197.2,0 166.6,0 0,0 0,361 50,361 60.3,361 80.5,361 139.5,361 197,361 237,361 267.5,361 306.5,361 343.5,361 389.6,361 431.4,361 470.2,361 524.9,361 582.6,361 625.1,361 ' },
    { value: '175.6,17.9 48.1,291.7 29.9,291.7 166.6,0 145.6,0 0,310.7 60.2,310.7 60.3,310.7 175.6,63 282.4,291.7 264.4,291.7 176.2,103.8 78.9,310.7 139.2,310.7 184.6,213.4 163.6,213.4 127.1,291.7 108.9,291.7 176.2,148.5 252.3,310.7 312.2,310.7 ' }
	    	  ],
  duration: 2000,
  loop: true,
  update: () => {
    const el = document.querySelector('.background-content');

    el.style.display = 'none';
    el.offsetWidth;
    el.style.display = 'block';
  }
})

Thanks @alexchantastic it works!
:rocket:


reorder flags so they can come after arguments

What type of PR is this?

feature

What this PR does / why we need it:
This brings back (and improves) the reorderFlags function from v1 that allows flags to be specified after arguments and still work. It's a very much requested feature, see https://github.com/urfave/cli/issues/1733 and https://github.com/urfave/cli/issues/976.
Which issue(s) this PR fixes:
Fixes #976
Testing
I've done some manual testing.

I did something similar in another repo if you need this: https://github.com/urfave/cli/issues/1583#issuecomment-1385733549

Some Run tests are failed, please check @fiatjaf

I don't understand what is failing. Looks like it's test coverage only? I can fix that, but can you tell me first if this change is wanted and would be merged if tests were ok?

@fiatjaf No one has specifically asked for this feature, so it depends.

I've linked to two issues above with many people asking for it.

This trips up my team all the time — I’d definitely appreciate the feature!

@fiatjaf This starts getting complicated. Can you provide more examples of the behaviour ? if you have say
cli subcmd1 subcmd2 -f -s -t

that would be equivalent to
cli -f -s -t subcmd1 subcmd2

even if say '-s -t' are defined for subcmd1 and not root command.

Subcommands should not be involved here. So cli subcmd -s -t -m file.txt otherfile.txt should be equivalent to cli subcmd file.txt otherfile.txt -s -t -m.

I understand the appeal of this but you are interpreting what the user want to achieve. Its is entirely possible that the subcmd wants to handle all the args itself in the command action.
cli subcmd file.txt s.txt -f -s

So you need a new boolean field in Command, something like ReorderArgs, which is off by default and can be enabled if a particular user of this library wishes it. Also you have to ensure that the reorder can be applied only to a leaf command and not to root/branch commands which have subcommands.

No one has specifically asked for this feature

checks notes one of the most critically requested features and reason for several projects migrating back to v1 and/or dropping urfave/cli altogether in favour of cobra 😆

checks notes one of the most critically requested features and reason for several projects migrating back to v1 and/or dropping urfave/cli altogether in favour of cobra 😆

[reference needed]. I don't see "reorder" in the critical list of requested features.
https://github.com/urfave/cli/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc
Alzo the v1 migration dataset is very interesting to see.

@abitrolly you don't have to look far https://github.com/urfave/cli/issues/1113 There are several folks (including myself) who had to remigrate to v1. Additionally, several folks there and in other issue migrating to cobra because of this. I don't know who curates this list but this ordering issue should be on it imho

I've opened a feature request here: https://github.com/urfave/cli/issues/1950
Let's go there an upvote it!

Can confirm, can't move to v2 in any of our project for ergonomic issues. "It's more POSIX compliant" is a very weak arguments, humans are not POSIX compliant.
We have a lot of pattern that can be described as
<cmd> --global --config <subcmd> --subcmd-config
because for CLI user it is easier to just copy front part (<cmd> --global --config ) or outright alias it for shorter cmdnline and then change subcommand and its options when using it.
Forcing flags to be at certain position just means unnecesary cursor movement

I've done manual some testing @fiatjaf and it doesn't seem to be working for flags on sub-commands?
./<cli> <command> --help # (1)
./<cli> <command> <sub-command> --help # (2)

Where both (1)/(2) show help output for <command> only. I can't seem to trigger help output for <sub-command> at all.

That's true. It's broken indeed. I'll try to fix it soon.

How many utilities you see provide 3-4 level subcmds ? This library has to support that use case so we cannot make choices assuming a certain depth. urfave/cli is more akin to a platform than a cli library. It allows lots of configurations so that people can achieve what they want from a cli library. Just because something is good for one user doesnt mean that others want it. Any changes have to be backward compatible(within major versions) and if it is an optional feature it needs to turned off by default. Interested users should be able to enable it as needed. I have thought about this in the past and felt there needs to be a "personality" setting for the library which configures a set of defaults automatically to provide a given behavior. As an example we would provide say 'ls' personality or 'git' personality and the cli would behave similar to what those utilities do in terms of flags/subcmds in terms of how options are parsed(reorder args) and help output. Additionally users would be able to plugin their own personality engine which would define behaviors expected of the platform.

I made it work for subcommands -- now it seems to be working fine in all my manual tests -- and made the behavior optional.
But some test in the suite and I'm having trouble understanding which. When I run go test I get a thousand lines of output from command calls. Please help me!

@fiatjaf Can you add some test cases for this first ? If you want to test locally you can do
go test -v -failfast

that should give you test which failed immediately

Working on tests now.

@fiatjaf One more thing is to check the behavior when ShellCompletion is enabled. Pressing TAB and having the reorder, now sure how that might work.

One thing I ran into on manual testing latest changes. One example to compare from another tool. You can do hugo -h and hugo -h serve and still get the same main command help output. In the current changes, the -h would get reordered to hugo serve -h which I think will cause confusion. I think this might relate to the discussion in https://github.com/urfave/cli/issues/1950 where reordering should be "local first"?

OK, I'm giving up.

@fiatjaf if you'd like us to add this feature please keep the branch open. We can try picking it up later . As you can see it's not that trivial to implement . For a particular use case it's easy but to have it work for all users for different use cases is extremely difficult. That's something we've always struggled with

We can add "Unsolvable challenges" chapter with examples and clarification to documentation. That will be useful for people from all CLI frameworks to tackle this problem without spending extra too much time on researching these tangled bits.

This "unsolvable challenge" is implemented in every other CLI framework, it's the number 1 requested feature according to your own link above, and this PR implements it perfectly as far as I know (except for the autocomplete thing which I have no idea of how it works, never managed to get it working on my apps).

@fiatjaf hey, I am not dismissive. Now that you've created the issue, the link https://github.com/urfave/cli/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc correctly lists it as the most upvoted feature (with my upvote included), but before that there was no data to back up you claim. )
I can confirm that in Python argparse flags can come after arguments by default.
$ cat postarg.py
import argparse

parser = argparse.ArgumentParser()

parser.add_argument('filename')           # positional argument
parser.add_argument('-c', '--count')      # option that takes a value
parser.add_argument('-v', '--verbose',
                    action='store_true')  # on/off flag

args = parser.parse_args()
print(args.filename, args.count, args.verbose)

$ python postarg.py -v filename -c 4
filename 4 True
$ python postarg.py -c4 -v filename
filename 4 True

I personally hate don't like that go binary itself has very awful command help interface.
$ go mod -h
go mod: unknown command
Run 'go help mod' for usage.

It could be much better if go supported -h option, which could be stuffed at the end.

👍 for this feature!
I decided to try out urfave/cli, as it had some nice idiomatic patterns compared to cobra. The lack of this feature is a deciding factor that will keep me using cobra. I will always favor the ergonomics of my customers rather than my own ergonomics as a developer.

@fiatjaf I've implemented this feature in #1977 so as to keep backward compatibility and work with autocomplete. I am closing this. Can you review that PR ? Much appreciated

@fiatjaf I have a potential fix at github.com:dearchap/cli/pos_args_flags_mix . Want to try it out  ?

Seems to work pretty well for me now!


Replace MPoly with MultivariatePolynomials

This replaces MPoly completely with MultivariatePolynomials without any changes to the API. To achieve this, I had to cheat  in src/PredictorCorrector/solve.jl. I will remove this in a following PR to keep this PR focused.
Closes #6.

My "cheat" actually also is wrong, so I have to figure out the new API, especially how we will handle homogenization of systems.

I think I got now a proper solution.


pipe: Fix ListenPipe/DialPipe race

ListenPipe can fail if there is a concurrent DialPipe because there is a
race window where DialPipe can connect to the initial server named pipe
before it is connected to and closed by ListenPipe.
To fix this, use the lower-level NT API for creating the server pipe,
since this API allows for specifying that a server pipe should initially
be in the disconnected state instead of the listening state. This allows
us to avoid the race condition by creating the pipe in the correct state
initially, so there is no longer a need to create a dummy client
connection.

Looks scarily good to me.

@jterry75 I'll vendor this into hcsshim.


fix: config test

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

This change is

#1946  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nagmo-starkware and the rest of your teammates on  Graphite


[ Question ] What could i do wrong?

Everything work correctly (lobby, champ select, in game overlay) but for some reason module league state can't can't get information for  summoners tested on eune euw and kr

Hey, please make sure you are using a correct riot API key.
Usually developer keys are only valid for 24 hours. You can either register an application, or use your developer key. Please make sure however that you update your API key in the following file:
modules/plugin-config/config.json


Divisional Tracking - Spreadsheet Filter - Arts & Culture

Describe the bug in current situation
Economy Sector Users were using the division filters, and found that not all requests were being pulled on the excel sheet.
As an example - TAC-2022-20722 does have a divisional assignment with "Arts and Culture" - when you select them as a division filter, the request does not get pulled.  It is possible that there are other divisions exhibiting this behaviour and it hasn't yet been caught
Link bug to the User Story
Impact of this bug
Will impact quality/accuracy of reports - user may no longer trust the tool. Currently this impacts a small number of users, but if is a bigger issue may eventually impact all.
Chance of Occurring (high/medium/low/very low)
High
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Use PROD environment
Steps to Reproduce
Steps to reproduce the behavior:

Go to the Combined ECON Dashboard
Click on Divisional Filter for Arts and Culture and Apply
Scroll down to Spreadsheet
TAC-2022-20722 is not displayed, despite having an assignment to that division

Actual/ observed behaviour/ results
Expected behaviour
GIVEN a user is on the divisional tracking dashboard
WHEN they select a division
THEN any request assigned to that division will be filtered to in the dashboard subject to any other filters applied
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

Matt to confirm whether they use excel or redash more often, if they want to keep division info in the combined dashboard. Will have new user session + task to create new division dashboard

@nkan-aot - the divisional stage filter is working great - there's just one thing I noticed.
For the ECON sector dashboard, when I filter to "Minister's Office" - I get the Minister's Office requests... but it seems to also pull requests that DONT have Minister's Office, but have Assistant Deputy Minister's Office, or Deputy Minister's Office... I assume the "Minister's Office" string is pulling those for that reason.
I assume it would have the same issue with EDUC - but I note I can't select Minister's Office - presumably because there are no requests that have been assigned to the Minister's office - is that right?
Can that be fixed before I close this? Thanks!

@m-prodan hey yes you are correct, that is why extra requests are being pulled, and also why there is no Minister's Office option for EDU. I've updated the query to correct this, please take a look when you get a chance

Appears to be working as expected - thanks @nkan-aot as always!


Support snake case in DynamoDB table names

What problem are you facing?

I'm trying to create DynamoDB tables using snake case in the name (e.g "table_name"), which is an acceptable name for the AWS API.
Yet the name of the table is obtained from the name of the Table custom resource metadata, where it must be URL compliant - i.e "_" is not allowed
At the moment the system we are trying to create tables for is migrating to a kubernetes deployment with minimum changes, and the table names are hardcoded - changing this would be a breaking change that would be probably hard to deal with
How could Crossplane help solve your problem?

Support the same table names as the AWS API
Possible solution: allow setting the table name in the spec

My bad, already supported with the "external-name" annotation :smiley:


⬆<EMAIL_ADDRESS>

Bumps babel-core from 5.8.38 to 6.26.3

This should be closed in favor of https://github.com/atom-ide-community/atom/pull/67 and https://github.com/atom/atom/pull/20965

That's great. continue

Closing in favour of https://github.com/atom/atom/pull/20965


Student's Marks Prediction depending on the study hours

Hello admin, In this project I an going to predict the marks of a particular student based on the fact the how many study hours that student is having.
Tool used : Jupyter Notebook
Dataset : student study hours
Method : Supervised Learning
Algorithm used : Linear Regression
This project will be a great example of Supervised Machine Learning. @Niketkumardheeryan Please assign me this task.

@abhisheks008 sorry no more simple linear regression allowed ,bcz it is already there... choose or create other issues.


Share Instagram Story

Ask your Question

This is my options:
ShareData.shareSingle({           url: 'data:image/png;base64,' + imageData,           title: "Share via",           type: "image/png",           message: "Share to instagram",           // social: ShareData.Social.INSTAGRAM         })
But my device always redirect to Feed Instagram, but I want to Instagram Story.
is my options miss something?

looking at #556 it sounds like IG stories were rolled back, but there is some energy to bring it back.

Looks like there's an open PR for this: #600


Installation error on Raspberry Pi

I've just installed the lasted Raspbian lite on my raspberry and build Fish from source.
When I try to install fisherman I get :

alexandre@jim ~> curl -sL get.fisherman.sh | fish
✓ Downloading Fisherman to ~/.local/share/fisherman
✓ Creating the configuration in ~/.config/fisherman
✓ Updating the registry index
× Installing CLI dependencies

Sorry, but I couldn't install Fisherman. Some things you can try:

→ Upgrade your Git version (^2.0)
→ Upgrade your Fish version (^2.2.0)
→ Make sure you can write to
→ Make sure you are connected to the Internet

For more help visit http://issues.fisherman.sh
Does the installer write logs somewhere ?
Any idea ?

@adaigre, I am using raspberry pi 2 with archlinux arm all the time, I don't found any issue installing fisherman with fish 2.2.0 and the latest git. (note that some version before that current latest git might have problem installing fisherman)
What is your uname -a and fish -v? Can you please try out the latest fish git if you have found any issues?

@pickfire It seems that the OP fish version is fine, probably, the problem is fisher failing to download the two deps it currently uses (spin and debug).
@adaigre The installer does not write logs anywhere. I'll work on that for Fisherman 0.9.0 :smile:

@pickfire I used the latest git to build
git --version -> git version 2.1.4
uname -a -> Linux jim 4.1.17-v7+ #838 SMP Tue Feb 9 13:15:09 GMT 2016 armv7l GNU/Linux
fish -v -> fish, version 2.2.0-622-g613739b-dirty

@adaigre Have you tried installing Fisherman again? Maybe there was a problem with the two deps that are pulled after installing Fisherman (debug and spin).

@bucaran Yes I tried few seconds ago from a different network connection and same result.

However, it seems you were able to get past installing Fisherman itself. So, do you have the fisher command? If you do, try fisher install spin.

@adaigre Can you try fisher update and fisher install spin like @bucaran said.
I can't reproduce this in archlinux arm.

It seems that I have an issue with my Fish anyway
fish: Unknown command 'bc' appears on autocompletion

@adaigre I recall that problem in fish issues, let me check.

@adaigre Make sure you have fish 2.2.0 and bc in your system and let us know if that got everything fixed (likely).

@adaigre Do you happen to have $fish_debug variable set? Most probably not the problem here, but I just pushed a fix.
https://github.com/fisherman/install/commit/117f696e3c44412ecddc698f04c356cf03978abf

I install the bc package and re-run the fisherman install and it works !
Sorry for the inconvenience.

Glad to know you got things working. :+1:

Good luck and have a nice day!


CodeCommit Event

Description:
I am writing a lambda function which is supposed to be triggered by CodeCommit. However, I cannot figure out how to add the permissions for CodeCommit. If I configure it via GUI (screenshot), it works without a problem.

I saw, that there has been discussions about that.
https://github.com/awslabs/serverless-application-model/issues/60
https://github.com/awslabs/serverless-application-model/issues/920
I do not see a reason, why we should use workarounds like SNS (I haven't even seen a full example for this), if there is direct support for CodeCommit Events.
Observed result:
CodeCommit has no permission to invoke Lambda.
Expected result:
SAM accepts something like the following in template.yaml
Resources:
  CodePipelineTriggerFunction:
    Type: AWS::Serverless::Function # More info about Function Resource: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction
    Properties:
      CodeUri: src/
      Handler: app.lambda_handler
      Runtime: python3.7
      Tracing: "Active"
      Policies:
        - AWSCodePipelineFullAccess
      Events:
        CodeCommitTrigger:
          Type: CodeCommit
          Properties:
            RepositoryName: back-end
            TriggerName: back-end-trigger

I found the docs that talk about adding a code commit trigger to lambda manually.
I think that the implementation would be similar to the Cloudwatch Log event, which can be found here: https://github.com/awslabs/serverless-application-model/blob/master/samtranslator/model/eventsources/cloudwatchlogs.py

Yeah, I added the thing manually for now. However, I actually only need that because of another weird restriction in AWS. I want to build/test every pushed branch in a repo with amazons integrated CI CodePipeline/CodeBuild. This seems impossible without adding additional functionality. (Which is super odd in my opinion.) Thus, I am registering a post push trigger which fires up a Lambda to create a pipeline on demand....

Hi @keetonian, can I work on implementing this feature?

@sivarosh Absolutely! Looking forward to your PR. 😊

Just checking in, the project I was working for does not exist anymore, so my personal interest in this vanished for now. Happy to see progress happening here, though! :)


Add Simon Dudley as a maintainer

PR description
Simon has made significant commits improving the quality and features of besu, this PR adds him as a maintainer.
Voting ends 2 weeks from the publication of this PR or once a majority of the maintainers vote.
For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.

Simon met the 50% threshold 🚀


Consider using SecureStrings

https://msdn.microsoft.com/en-us/library/system.security.securestring(v=vs.110).aspx

For passwords, mnemonics and keys wherever possible.


V0.2.1

Fixes:

MIGRATE cmd Failed with message: NOAUTH Authentication required.
Redis Cluster do not recover data when custom appendonly=yes.

lgtm


Properties Panel: General: Id field vs "Key"

In Camunda the process is referenced by the Key which maps to the Id field in the modeler's Property Panel > General page.
Should this more more like Id (key) ?

We could add a note to the field to make that clear.

Closed via https://github.com/bpmn-io/bpmn-js-properties-panel/commit/86b4726f48e063583e12450e502fd2a2be105861.


fix: [RHTAPBUGS-996] Increase timeout

Description
This PR increases the test timeout to avoid failing before the build status annotation is set.
Issue ticket number and link
RHTAPBUGS-996
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Checklist:

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

lgtm, but I'd defer to @tisutisu for approval

/lgtm
/approve


stats: comments clean up

Commit Message:
Various stale or inconsistent comments clean up and style change.
Additional Description:
Risk Level: LOW
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

/retest


[Feature]: Sitemap addition for website {GSSoc'23}

[x] Would you like to take up this task?
[x] Are you from GSSoC'23?

✨
Feature request

Is your feature request related to a problem?
Yes, the feature request is related to a problem. The problem is that the current website does not have a sitemap. This absence of a sitemap makes it difficult for search engines and users to navigate and discover all the pages and content on the site. As a result, the website may experience lower search engine rankings, reduced visibility, and a subpar user experience.

Describe the solution you'd like
The solution I would like is to add a sitemap to the website. The sitemap should be a structured file that lists all the URLs and relevant metadata of the website's pages. It should be automatically generated and updated whenever new content is added or existing content is modified. The sitemap should follow the XML sitemap protocol, which is widely recognized and supported by search engines. By having a sitemap, search engines can effectively crawl and index the website, while users can easily find and navigate to specific pages.

Describe alternatives you've considered
One alternative that has been considered is manually creating the sitemap. However, this approach can be time-consuming and prone to errors, especially when the website has a large number of pages or frequent content updates. Another alternative is using third-party plugins or tools to generate the sitemap. While this can be convenient, it may not always provide the level of customization or automatic updating required.

Additional context
The addition of a sitemap will greatly improve the website's search engine optimization (SEO) efforts by enabling better indexing and visibility. It will enhance the user experience by allowing users to easily discover and access different pages on the site. Screenshot examples of existing sitemaps or visual representations of the website structure can be provided to further illustrate the problem and the potential benefits of implementing a sitemap.

Screenshot

In the attached screenshot, I have highlighted the website name with the expected presence of a sitemap.xml file. However, upon inspection, it is evident that the sitemap is not being displayed. This screenshot underscores the problem of the current website lacking a visible sitemap, further emphasizing the need for its implementation.

@sourabhsikarwar hey can you pls check the pr.


Shield rules object typings from schema or schema-based types

I don't know if it allready exist and I could find the doc or if I am asking something completely crazy. Somewhere in that spectrum.
I wonder if there was any way allready implemented to type the first argument to shield() so that it allows only existing object/fields in the rules keys. I would LOVE intellisense on vscode.
This typing should come from the schema itself or from some prisma2-generated Typescript types.
To be more specific : my schema has a Role type. When writing my shield's rules I would love to be able to choose Role from the intellisense menu. In the other hand, creating a rule on a Query field that does not exist in my schema would result in a red flag in the IDE, indicating that I just can't do this.
Cheers !

[* ] I have checked other questions and found none that matches mine.

I think that's a fantastic idea. I have thought of it many times as well but eventually always dismissed it due to the lack of funding since it requires more code change than regular maintenance.

I've contributed a little to help keep this project going - I too would agree that this would be a great feature to have.
Thanks again for this project!

Thanks! This is definitely coming in the next month or so with version 8.0.
Also, thank you for your contribution, I can't wait to see you try it. 🚀😄


Identify helper/internal and obsolete functions.

We need to go over the functions listed in each of the R scripts, to highlight functions that should be considered as helper/internal and unused functions (i.e not export to NAMESPACE and update function description accordingly). A suggested approach could be to list such functions in the comment section of this issue, I could then update the scripts accordingly and link the PR in the comments.

These functions can be considered helpers/internal and are not meant for out-of-package usage:
export(add_icgc_metadata)
export(append_to_table)
export(assemble_file_details)
export(collate_ashm_results)
export(collate_csr_results)
export(collate_curated_sv_results)
export(collate_nfkbiz_results)
export(collate_sbs_results)
export(collate_ssm_results)
export(collate_sv_results)
export(fetch_output_files)
export(finalize_study)
export(find_expected_outputs)
export(find_files_extract_wildcards)
export(get_gambl_outcomes)
export(map_metadata_to_colours)
export(populate_each_tool_result)
export(populate_tool_results)
export(process_all_manta_bedpe)
export(referesh_metadata_tables)
export(refresh_full_table)
export(region_to_chunks)
export(setup_fusions)
export(setup_study)
export(trim_scale_expression)

Thanks, Kostia! I will go over the R scripts and update the function description for above mentioned internal functions. Stay tuned.

Description for internal functions has been updated to state the function type and also what exported function that calls the described internal function. For example, in the description of map_metadata_to_colours the following line is added at the top of the description: #' INTERNAL FUNCTION called by plot_sample_circos and get_mutation_frequency_bin_matrix, not meant for out-of-package usage.. In addition, internal functions have been removed from NAMESPACE.
The following internal functions have been updated:

add_icgc_metadata
append_to_table
collate_ashm_results
collate_csr_results
collate_curated_sv_results
collate_nfkbiz_results
collate_sbs_results
collate_ssm_results
collate_sv_results
get_gambl_outcomes
map_metadata_to_colours

There are some outstanding internal functions (in portal.R and preprocessing_io.R) that needs to be updated after these scripts have been revised. The outstanding functions are:

fetch_output_files
assemble_file_details
finalize_study
find_expected_outputs
find_files_extract_wildcards
populate_each_tool_result
populate_tool_results
process_all_manta_bedpe
setup_fusions
setup_study

The issue will be closed once the outstanding functions are updated.

Functions in portal.R have been updated accordingly and the remaining functions in preprocessing_io.R are deprecated and handled elsewhere.


Create dependabot.yml

Add dependabot.yml to update github-actions as necessary.

@naveensrinivasan since you are most familiar with dependabot, could you please review this PR?

@naveensrinivasan since you are most familiar with dependabot, could you please review this PR?


Issue 82: attributes added to input tag

The input tag of component will now inherit html attributes like id, name etc.

can you please remove the build files

deleted, Thanks for email.
On Sat, Jan 27, 2024 at 8:06 PM shubhadip @.***> wrote:

can you please remove the build files
—
Reply to this email directly, view it on GitHub
https://github.com/shubhadip/vuejs3-datepicker/pull/84#issuecomment-1913174802,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGHGHWUAK2G6MPB7WOYUZ43YQUGHFAVCNFSM6AAAAABCIAZAVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGE3TIOBQGI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Mouse demo needs to be fixed since hover state no longer exists

Mouse demo needs to be fixed since hover state no longer exists

This has been fixed


Must use release-debug, or debug mode

If I want to compile my program in debug mode, d2sqlite3 must also have been compiled in debug mode (e.g. dub - b "debug" or dub -b "release-dubug").
If I build d2sqlite3.lib without the -debug flag, and I compile my program in debug mode, I get:
dmd -m64 main.d -Id2sqlite\source -Ld2sqlite3.lib sqlite3.lib -debug
lld-link.exe: warning: obj\debug\main.obj: undefined symbol: _D9d2sqlite38database8Database7Payload9__xtoHashFNbNeKxSQCcQBvQBpQBjZm
lld-link.exe: warning: obj\debug\main.obj: undefined symbol: _D9d2sqlite38database8Database7Payload11__xopEqualsFKxSQCbQBuQBoQBiKxQpZb

If I compile my program without -debug (and d2sqlite.lib is also without -debug), everything is fine.

You should build your program and the library in the same mode, probably using dub for both.


fix invalid use of pre-declared class (#3459)

This should possibly fix #3459.  We don't need the pre-declerations, when all headers are included in proper order.

Well, any ideas about the fails on Travis?

Updates here?


[FLAKE] Bazel C/C++ Dbg MacOS test/cpp/client/credentials_test

https://source.cloud.google.com/results/invocations/779ee44d-fb24-45df-8030-3d2640ff1d19/targets/%2F%2Ftest%2Fcpp%2Fclient:credentials_test/tests

see internal b/153136407

Flaky test removed in #21932. Have separate tracking for resending the test.


Hunter: To be or not to be

Hi,
Peoples with a sharp eye may notice that the "Sponsor" button appeared at the top of the project's page on GitHub. It's not just a cool-looking button - it has a purpose :)
If I do not receive enough support on https://patreon.com/ruslo, I'm planning to stop the maintenance of the Hunter on August 25, 2019.
P.S. If this unfortunate event will take place and you're the developer who feels he is interested in maintenance, you can ping me at<EMAIL_ADDRESS>(please don't leave any messages about it here!).
Thanks for understanding,
Ruslo

This is an amazing project, it would be a huge shame to see it die. I have used hunter a lot in various jobs and open source projects, and it has made a serious difference to me. I've added my support on patreon :)
What would be "enough" support?
I really hope you can get what you need, but I understand the amount of work that goes into a project like this, and wouldn't hold it against you if you had to leave.
Good luck!

I've added my support as well.
The one big thing this project lacks is promotion. Making a good conference talk can bring a lot of users and supporters.

Ah, man, I just started converting lnav over to use hunter since it seemed easier than conan[1]/vcpkg[2].  I want the end-user to only need cmake since that's already installed or easily installable most places.  I also started to build a front-end command as mentioned in #1340.  So, I'd rather not see it go away.
[1] - It's nicer for the developer to be able to work within one build system, cmake, rather than having to learn a separate one as well.
[2] - There were no releases, which meant a package could not be added to brew.  So, the end-user would have to figure out how to do that.

@dvirtz I. Annoy agree with you more!

The one big thing this project lacks is promotion. Making a good conference talk can bring a lot of users and supporters.

For example this talk The State of Package Management in C++ - Mathieu Ropert [ACCU 2019] mentioned Hunter, but then discarded it because Hunter was perceived as intrusive.
I pointed out that you can have the same level of support in Hunter like in Conan and VcPkg, you have to treat it separately from you build. You only have to edit one file, a CMakeLists.txt file, just like you would do with conanfile.txt or a script for vcpkg. The comment was removed from Youtube.
This CMakeLists.txt which does this 3rd party dependency download / compilation / installation for Qt6::Base looks like this:
cmake_minimum_required(VERSION 3.14)

file(
  DOWNLOAD https://raw.githubusercontent.com/hunter-packages/gate/master/cmake/HunterGate.cmake
  ${CMAKE_BINARY_DIR}/HunterGate.cmake)

file(WRITE ${CMAKE_BINARY_DIR}/hunter_config.cmake
[=[
hunter_config(pcre2
  VERSION
    ${HUNTER_pcre2_VERSION}
  CMAKE_ARGS
    PCRE2_BUILD_PCRE2_8=OFF
    PCRE2_BUILD_PCRE2_16=ON
    PCRE2_BUILD_PCRE2_32=OFF
    PCRE2_SUPPORT_JIT=ON)
]=])

set(HUNTER_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/hunter)

include(${CMAKE_BINARY_DIR}/HunterGate.cmake)
HunterGate(
  URL "https://github.com/ruslo/hunter/archive/v0.23.187.tar.gz"
  SHA1 "c62a35f423e6358ff0ec4325572527a9c8ddd5c8"
  FILEPATH ${CMAKE_BINARY_DIR}/hunter_config.cmake
)

set(HUNTER_CONFIGURATION_TYPES Release)

project(3rdparty)

hunter_add_package(freetype)
hunter_add_package(ZLIB)
hunter_add_package(PNG)
hunter_add_package(double-conversion)
hunter_add_package(pcre2)

# Create a toolchain file which sets CMAKE_PREFIX_PATH
file(READ ${CMAKE_BINARY_DIR}/_3rdParty/Hunter/install-root-dir hunter_install)
file(WRITE ${CMAKE_CURRENT_SOURCE_DIR}/hunter_toolchain.cmake
"list(APPEND CMAKE_PREFIX_PATH \"${hunter_install}\")\n")

if (CMAKE_TOOLCHAIN_FILE)
  file(APPEND ${CMAKE_CURRENT_SOURCE_DIR}/hunter_toolchain.cmake
    "include(${CMAKE_TOOLCHAIN_FILE})\n")
endif()

And then just configure the project with -DCMAKE_TOOLCHAIN_FILE=.../hunter_toolchain.cmake.
@ruslo you need to provide some plan on what you would like to tackle in the near / middle / far future.
So that people would know what they buy. Some sort of regular reporting would help. I can think of KDE Usability & Productivity

Making a good conference talk can bring a lot of users and supporters.

I really prefer videos like this awesome one:

https://www.youtube.com/watch?v=TeeLEfT8nCU

Few things have to be polished a little, bit but it's good quality, compact and clean.

For example this talk The State of Package Management in C++ - Mathieu Ropert [ACCU 2019] mentioned Hunter, but then discarded it because Hunter was perceived as intrusive.

I saw the same talk here and left a comment:

https://www.youtube.com/watch?v=C1m-Uy4nuQA

Yeah, it's quite surprising that he had time to prepare and give a one hour talk but can't find time to read a brief overview or ask a question in Gitter.
I'm a technical guy; you have a problem - I can give you an answer/suggestion of how it can be solved. And I can provide an estimate (if possible) of how much time it can take. That's the social problem. Peoples believe in some things blindly and see what they want to see. Another popular myth about Hunter is that it supports only CMake project and always build packages from sources (i.e., there is no binary download option). Even if both are mentioned on the front page of documentation.
But I guess the strongest punch against Hunter is "Use CMake to write a package manager? Phhhh...". That's a killar argument :)

you need to provide some plan on what you would like to tackle in the near / middle / far future

Hunter documentation issue was there for two years:

https://github.com/ruslo/hunter/issues/677

Even there is no high quality skills or time required, only little part of it was done so far.
I almost stopped doing anything about general CMake tutorial:

https://github.com/ruslo/CGold

Some topics like RPATH covered purely in official CMake/wiki but hit package management again and again:

https://github.com/ruslo/hunter/issues/1917
https://github.com/ruslo/hunter/issues/1804
https://github.com/ruslo/hunter/issues/1802

Automation is missing but important for usability:

https://github.com/ruslo/hunter/issues/449
https://github.com/ruslo/hunter/issues/1632

Actually it's hard to find any part of development that don't require support.

So that people would know what they buy. Some sort of regular reporting would help. I can think of KDE Usability & Productivity

I will provide a summary of the activity if the fundraising succeeds. Also at this point, it's a quite short report - nothing was done in the core for the last year, mostly maintenance and new packages.

This CMakeLists.txt which does this 3rd party dependency download / compilation / installation for Qt6::Base looks like this:

See this note, I think that's what really you're looking for:

https://gitter.im/ruslo/hunter?at=5d3698ed5ea6e644ec02bd5c

I think something that would really help is an actual website.
ATM, we have a docs site, which is super necessary, but also not enough. If someone is just browsing around, they want to see a showcase website, something that explains what the project is, and how to use it in the high level. Basically something to "sell" people on trying hunter at all. Also a good place to ask for donations.
Honestly, I think with something more structured like that in place, and a bit of time, hunter could become financially viable. I'm not sure if that will happen before August 25th though, and it will require some input of non-technical work to get there. I hope the current push turns out to be ok, or at least enough to convince you @ruslo to keep pushing to get the project to a sustainable state. IMO the current deadline might just be too hard for that.

As an experiment, i have built a simple package manager alongside with a build system wrapper (both are written in Go). Both use simple .json config files for describing packages and build pipeline. It is not compatible with hunter, but it allows easily defining custom packages to be built. Currently it is only tested on amd64 linux, but should work on almost any bash-capable environment. If anybody is interested, i can setup a CI (did not bother with it because its an experimental project) so anybody can download the tools at any time.

The main thing I like about hunter is not other programs needed to be downloaded, installed, whatever, everything is in cmake, so it is easy to drop-in to any existing project regardless of what else is used.  Something requiring Go is not.  ^.^;
Although a front-end to make submitting new libraries to hunter would be amazing, the current github-centric process is a bit... involved.  ^.^;

Go compiler links its runtime statically - so you can compile binaries on a CI and them distribute them without requiring to install Go.

Go compiler links its runtime statically - so you can compile binaries on a CI and them distribute them without requiring to install Go.

That becomes very platform specific though.  For example, I use hunter to acquire and compile dependencies on embedded arm32 systems (little low-power embedded servers around my house).  Are you going to distribute a go program for that?  Does go even support such a system where cmake does?

@handicraftsman @OvermindDL1 I don't think this issue is the right place for such kind of discussions.

I always wondered how you managed to put so much work into this project in your spare time. I do not blame you that you want to get rid of this burden.
If your fund raising fails, you could ask the CMake guys if you can add hunter to their project. That way they could manage further development so current users are not left standing in the rain.

you want to get rid of this burden

I don't want to "get rid of" it. I'm asking for help to make it better.

so current users are not left standing in the rain

As my first comment states:

you're the developer who feels he is interested in maintenance, you can ping me at<EMAIL_ADDRESS>

Hi. In the company I work for we use Hunter in most of our C++ projects and are very happy with it! So thank you for providing such a great tool
We would like to support hunter by a monthly payment, however Patreon does not hand out any invoice for the payment only online receipts. I was informed that this will cause problems for our administration resulting in cost and thus there is hesitation. Does anyone have a solution for that?

I would happily contribute to maintenance but almost every time I submit a PR it's rejected on grounds from the ever-changing arbitrary rules.

Your PRs were closed for inactivity.
I've just read through the comment threads, @ruslo went out of his way to help, so I wouldn't say they were "rejected on grounds of the ever-changing arbitrary rules". Changes were requested, and never made, so eventually the inactive PR was clsoed.
I get that it is painful making new packages with hunter, and that would be one thing I'd like to see improved too, but I don't think it's fair to say your packages were rejected arbitrarily, or even rejected at all.
Forking for your company is not the worst idea actually. The main project has to have higher standards for certain things, where your company might not care (eg, "package must work on all supported platforms" vs "we only support windows anyway"). What I have done in the past is make an internal fork and start using it, and get the package upstreamed later. I would encourage you to go back to your closed prs, and address the issues @ruslo raised, and we can all benefit from better packages :)

@wheybags if it were only me who has experienced the unhelpful, arbitrary, unpublished rules I would accept your rebuttal. It is not.
The project has lost a number of otherwise enthusiastic maintainers for the same reason.
I happen to know two of them.
It is a real problem.

Well, I have added several packages myself, and sure, I often had to change things to get them accepted, but they were all accepted when they reached that bar. I had no problems with this process, it is what I would expect when contributing to a well run FOSS project.
IMO the behaviour displayed by @ruslo  in your PRs is more than acceptable, you got prompt, actionable feedback.
As for other people, I can't say if I don't know who they are.
I will reiterate though, that I do agree that it can be too complicated to add and test a package, and that the project could benefit greatly from streamlining that process, but that is a technical issue, not a cultural one.

... almost every time I submit a PR it's rejected on grounds of the ever-changing arbitrary rules.

Your pull requests were rejected because of the poor quality.
For example here:

https://github.com/ruslo/hunter/pull/1862

The goal of the pull request was: "This change adds c++20 support, which is now supported by latest CMake"
The fix, in fact, is adding three characters:

https://github.com/ruslo/hunter/commit/355a7aeb120a5a92dc06529435d4d292a60b5f22

You've opened pull request with seven(!) commits:
@madmongo1 added SocketIOClient package 3e7d0a5
@madmongo1 updated socketio hash 34cff1d
@madmongo1 Merge branch 'master' of https://github.com/ruslo/hunter abfbd47
@madmongo1 Merge remote-tracking branch 'upstream/master' c01768e
@madmongo1 Merge remote-tracking branch 'upstream/master' f9b14dc
@madmongo1 Merge remote-tracking branch 'upstream/master' 52b4c4a
@madmongo1 added cxx20 support 9e04392

Two of them is about adding a new package (half-ready effort), and four of them were a merge commits. This is below the par of any sane contribution guide.
Here:

https://github.com/hunter-packages/socket.io-client-cpp/pull/2

You have used your write permissions and did merge even I have requested changes. That's absolutely unacceptable behavior. At this moment, there are 54 peoples and 232 teams in https://github.com/hunter-packages, and you're the only person I remember to remove from the organization. The fact that you're turning this issue into offtopic "I have a complaint" discussion just proving that what I've done was right.

I hope everything will go well because IMHO hunter is the best package manager for C++

hey @ruslo
first off all, I really like hunter and it would be very sad if the project stops.
So you got my support on patreon!
I also promoted hunter on the meetingC++2018 in Berlin on a small lightningTalk(it was my first talk on a stage): https://www.youtube.com/watch?v=wrCObV3qlhM
On the other side, I can totally understand that it is a lot of work! And best would be if all the work can be shared between a maintainer-team and not just by you!
So I'm looking forward to your decision!

10 patrons | $230 of $1,500 per month

I'm grateful for your help, but I hope it's clear for everyone that this number of supporters will give me neither motivations nor resources to continue. I've done a full refund for all patrons.

... and you're the developer who feels he is interested in maintenance ...

Please send your pull requests and issues to https://github.com/cpp-pm/hunter
@rbsheth @bkotzz Good luck have fun! :)

Sorry to hear all this, I have been lost in haze of development lately so I did not see any of this till now (definitely would have supported, although it would not have made up for that short fall).
I just want to say thank you, your work has been greatly appreciated and I have always been thoroughly impressed with the work and your responses to questions/PRs/issues. Pretty much anything that you have done so far. Thanks again for all your hard work.


"No route matches [GET] /assets/ekko-lightbox.min.css.map" problem fix

There is an issue  related to missed ekko-lightbox.min.css.map (output in rails console):
ActionController::RoutingError (No route matches [GET] "/assets/ekko-lightbox.min.css.map"):

actionpack (5.0.2) lib/action_dispatch/middleware/debug_exceptions.rb:53:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
web-console (3.4.0) lib/web_console/middleware.rb:135:in `call_app'
web-console (3.4.0) lib/web_console/middleware.rb:28:in `block in call'
web-console (3.4.0) lib/web_console/middleware.rb:18:in `catch'
web-console (3.4.0) lib/web_console/middleware.rb:18:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
actionpack (5.0.2) lib/action_dispatch/middleware/show_exceptions.rb:31:in

I fixed it by adding ekko-lightbox.min.css.map directly into /vendor/assets/ folder.

Good job! :+1:
When can we wait this to be merged?

Definitely be great to get it merged 👍


Showing method signature only working with certain characters following

On pressing Ctrl+Shift+Space, the method signature shows up. Unfortunately, this only works when certain characters follows the cursor, e.g. a space, a quote or a bracket.
I show you some examples with the str() method where this | is the cursor.
Signature showing up:
str(|), str( | ), str(|"foo"), str( | "foo"), str( | foo)
Signature not showing up:
str(|foo), str(|str(""))

/needsMoreInfo
Please update this issue after reading https://github.com/Microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions#writing-good-bug-reports-and-feature-requests. Thanks.


Improved guestbook.sh test to become actual test

After change the test waits until pods come up and frontend starts serving content,
then adds entry to guestbook and verify if operation succeed
This fixes #3693

Satnam, could you please take a look?
Should be merged after #5284

Happy to review although I always value @filbranden 's words of wisdom about bash. I will try to get to this after the Fixit today -- which might mean no action until tomorrow. Are you in a hurry? Perhaps not if you are blocked on #5248

Handing over to @filbranden who is clearly in charge here.

Looks good overall! Thanks @piosz for tackling this one!
I have a lot of notes (as usual) but in general the code looks good and there's nothing structural, only style and nitpicks. Please let me know when ready to take another look, I'll review it and merge it when it's ready.
Cheers!

Thanks for comments. I resolved them (hopefully all). Sorry for such bad style but it's the first time I'm coding in bash;) PTAL
BTW do you prefer updated version as a new commit or amend to the previous one (which I did this time)?

Looks great. ammended commit is fine, it's a bit annoying to have to review everything again but in the end it works just fine. (If you do the other way around I'd ask you to squash it before we merge it.) Merging now.
Don't worry, your bash was great... way above average. The problem is the extra nitpicky reviewer ;-)
Cheers!
Filipe

Thanks!


I cannot install bark_ssg==1.3.4, because of hoedown

How can I do with it?
When running "/vlog_read_script_sample.py"
hoedown.c
hoedownpy/hoedown.c(4501): error C2105: “++”需要左值
hoedownpy/hoedown.c(4503): error C2105: “--”需要左值
hoedownpy/hoedown.c(4762): error C2105: “++”需要左值
hoedownpy/hoedown.c(4764): error C2105: “--”需要左值
hoedownpy/hoedown.c(5164): error C2039: "tp_print": 不是 "_typeobject" 的成员
C:\Users\xxx\anaconda3\envs\vlogger\include\cpython/object.h(191): note: 参见“_typeobject”的声明
hoedownpy/hoedown.c(5172): error C2039: "tp_print": 不是 "_typeobject" 的成员
C:\Users\xxx\anaconda3\envs\vlogger\include\cpython/object.h(191): note: 参见“_typeobject”的声明
hoedownpy/hoedown.c(5181): error C2039: "tp_print": 不是 "_typeobject" 的成员
C:\Users\xxx\anaconda3\envs\vlogger\include\cpython/object.h(191): note: 参见“_typeobject”的声明
hoedownpy/hoedown.c(5190): error C2039: "tp_print": 不是 "_typeobject" 的成员
C:\Users\xxx\anaconda3\envs\vlogger\include\cpython/object.h(191): note: 参见“_typeobject”的声明
hoedownpy/hoedown.c(5198): error C2039: "tp_print": 不是 "_typeobject" 的成员
C:\Users\xxx\anaconda3\envs\vlogger\include\cpython/object.h(191): note: 参见“_typeobject”的声明
hoedownpy/hoedown.c(5808): warning C4996: '_PyUnicode_get_wstr_length': deprecated in 3.3
hoedownpy/hoedown.c(5824): warning C4996: '_PyUnicode_get_wstr_length': deprecated in 3.3
hoedownpy/hoedown.c(6213): warning C4996: 'PyUnicode_FromUnicode': deprecated in 3.3
error: command 'C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.35.32215\bin\HostX86\x64\cl.exe' failed with exit code 2
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for hoedown
Running setup.py clean for hoedown
error: subprocess-exited-with-error
× python setup.py clean did not run successfully.
│ exit code: 1
╰─> [6 lines of output]
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help
  error: option --all not recognized
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed cleaning build dir for hoedown
Failed to build hoedown
ERROR: Could not build wheels for hoedown, which is required to install pyproject.toml-based projects

Same problem, hoping to get a reply soon.

It appears that you are encountering build errors while trying to install the hoedown Python package. The error messages suggest issues with C code in the hoedown package, possibly related to compatibility with the Visual Studio compiler.
Here are a few steps you can try to resolve this issue:

Upgrade setuptools and wheel:
Ensure that your setuptools and wheel packages are up-to-date. You can upgrade them using the following commands:
pip install --upgrade setuptools wheel

Install Visual Studio Build Tools:
The errors seem to be related to the Microsoft Visual Studio compiler. Make sure you have the necessary build tools installed. You can download the Visual Studio Build Tools from here.

Check Python Version:
Ensure you are using a compatible Python version. Some packages have specific compatibility requirements. You can check the package documentation for any version-specific information.

Check hoedown Compatibility:
Check if the version of hoedown you are trying to install is compatible with your Python version and the build tools you have installed. You may find this information in the package documentation or on the package's PyPI page.

Try an Alternative Markdown Library:
If the issue persists, consider using an alternative markdown library that may have better compatibility with your environment. Popular alternatives include markdown and mistune.
pip install markdown

or
pip install mistune

Contact Package Maintainers:
If the problem persists, consider reaching out to the maintainers of the hoedown package for support. They may be aware of compatibility issues and might provide guidance or updates.

Remember to activate your virtual environment (vlogger) before attempting to install or upgrade packages.

pip install mistune——Thank you! It works for me!
But I met another problem.
model ready!
protagonists ready!
Traceback (most recent call last):
File "C:\Users\xxx\Documents\Vlogger\sample_scripts\vlog_read_script_sample.py", line 303, in
main(omega_conf)
File "C:\Users\xxx\Documents\Vlogger\sample_scripts\vlog_read_script_sample.py", line 157, in main
video_list = readscript(args.script_file_path)
File "C:\Users\xxx\Documents\Vlogger\vlogger\planning_utils\gpt4_utils.py", line 530, in readscript
video_fragments = ast.literal_eval(script)
File "C:\Users\xxx\anaconda3\envs\vlogger\lib\ast.py", line 64, in literal_eval
node_or_string = parse(node_or_string.lstrip(" \t"), mode='eval')
File "C:\Users\xxx\anaconda3\envs\vlogger\lib\ast.py", line 50, in parse
return compile(source, filename, mode, flags,
ValueError: source code string cannot contain null bytes

I'm glad to see that your environmental issues have been resolved.
Based on the current error information you provided, potential issues can be categorized into two scenarios:

If you did not use the default configs/vlog_read_script_sample.yaml as the configuration file for sample_scripts/vlog_read_script_sample.py and instead modified the script file, you need to compare it with the scripts in the repository I provided. Check if there are any differences in formatting, as content generated by GPT may occasionally deviate from the interface I designed.

If you used the default configs/vlog_read_script_sample.yaml as the configuration file, it's possible that you accidentally modified some scripts within it. In this case, you can directly download and replace the original files with the script files I provided.

I'm glad to see that your environmental issues have been resolved.
Based on the current error information you provided, potential issues can be categorized into two scenarios:

If you did not use the default configs/vlog_read_script_sample.yaml as the configuration file for sample_scripts/vlog_read_script_sample.py and instead modified the script file, you need to compare it with the scripts in the repository I provided. Check if there are any differences in formatting, as content generated by GPT may occasionally deviate from the interface I designed.
If you used the default configs/vlog_read_script_sample.yaml as the configuration file, it's possible that you accidentally modified some scripts within it. In this case, you can directly download and replace the original files with the script files I provided.

Thank you so much, I did it!


NSP not updated when Target IP updated after killing Proxy POD

Describe the bug
Using kubectl delete pod to kill the Proxy POD serving a Target POD will lead to updating the IPs used by the NSM connection connecting the Target with the (new) Proxy. However, update of the Target IP is not propagated to the Stream part of TAPA anytime soon. Thus it will get stuck with the old set of local IPs that it will keep announcing to NSP, hence the LBs won't update their Target related config.
Details:
For TAPA (Target) originated NSM connections the IPAM database will rely on the NSM connection ID applicable for the Proxy path (NSM terminology) to store/look-up related IPs. This ID most likely will be different for the newly started Proxy. Thus the old IPs can't be recovered for the Target's NSM connection Request, instead a new set will be allocated.
However the TAPA does not seem to inform NSP about the update in time. It can take ~30 minutes for the Stream to "realize" the change when it registers the Target with new IP.
To Reproduce
Steps to reproduce the behavior:

Deploy nVIP and 1 Target.
Note the IPs of the nsm interface in the Target, and the ip rules routes in the LB configured for the Target(s).
Use kubectl delete pod to remove the proxy located on the same worker as the Target.
Compare the ips of the nsm interface in the Target to the old ones. Check the ip rules and routes for the Target in LB again, which should still point to the old ips of the Target.

Expected behavior
The NSP should be updated in short notice when Target ips change.
Context

Network Service Mesh: v1.7.1
Meridio: v1.0.1

Logs
Add logs here.

I tried it, it took less than 3 minutes for the traffic to be fully back with no lost connection. Targets register themselves every 30 seconds (to update the keepalive), and if no update is received, the NSP remove the entry after 2 minutes.

For me it took ~30 minutes for some reason. Will double check.

I added an item to this issue: https://github.com/Nordix/Meridio/issues/159
The TAPA conduit handler must monitor the NSM connection it manage so it can be notified of the IP changes. It is currently notified about them only when the SetVIPs is called because it request the connection to NSM a new time.

Until the NSP update logic is improved, the chance of replacing IPs for a TAPA connection could be minimized upon Proxy kill/upgrade.
The idea is to use a different key to store the IPs in the IPAM database for NSM connections initiated by TAPAs.
The new key would be the first segment's ID of the NSM connection, which describes the TAPA side. Thus the IPs could be restored even if the segment ID of the Proxy changes.
(With the suggested change the Proxy side IP of a TAPA orignated connection wouldn't be leaked if the Proxy POD is replaced.)


downgrade snapshot service to v0.15.2

Summary of changes
Changes introduced in this pull request:

the v0.16.0 Rottenmelon may have a performance regression. For the time being, we could use v0.15.2 Defenestration, given we are past the Watermelon fixes epochs anyway with the recent snapshots.

Reference issue to close (if applicable)

Closes
Other information and links

I did a single check of ~80 epochs between 0.16.0 and 0.15.2, and there was a 20% difference (0.16.0 being slower) with a bunch of sending on a closed channel warnings. It's not decisive, though, the 0.16.0 may have gotten better peers.

@lemmih as confirmed by @ruseinov, https://github.com/ChainSafe/forest/pull/3683 caused the regression in performance so I believe we should go ahead with the downgrade for now.

@LesnyRumcajs perhaps instead of reverting we should do a hotfix to 0.16?
The problem is we already have some snapshots that don't work with 0.15.2 version..

It shouldn't matter really. The snapshot service is bootstrapping from newer snapshots anyway.

It shouldn't matter really. The snapshot service is bootstrapping from newer snapshots anyway.

Roger that.
I had issues with bootstrapping 0.15.2 with the newest calibnet snapshot.

We're holding off on this PR according to @lemmih, not sure if we need to merge it then or not.

Hopefully, superseded by https://github.com/ChainSafe/forest-iac/pull/342


Latest MigrationInfo is incorrect if all previous migrations have the same AppliedAt time stamp

Description
PR #8 solved #7 by correctly querying the most recently applied MigrationInfo in descending order:
var migrationInfos = await DataConnection.GetTable<TMigrationInfo>()
                                         .OrderByDescending(migrationInfo => migrationInfo.AppliedAt)
                                         .Take(Take)
                                         .ToListAsync(cancellationToken);
return migrationInfos.GetLatestMigrationInfo();

Unfortunately an incorrect migration is still returned in the following scenario:

There are more than Take migrations (defaults to 100)
All migrations are applied onto an empty database in a single run of MigrationEnginge.MigrateAsync(). All of the corresponding MigrationInfos are assigned the same time stamp
During the next run of the MigrationEngine it is up to the database engine to determine the order as the AppliedAt values of all MigrationInfos are equal. In the case of MSSQL Server the first Take migrations are returned, not the last. Consequently, migration #Take is incorrectly identified as the last one and the engine tries to reapply the remaining migrations starting from Take + 1.

Possible Workarounds

Use different timestamps for every pending migration. This does not solve the problem for existing databases, though.
Order by the AppliedAt AND the Id column. This workaround depends on the ID generation for the MigrationInfos table.

Yep, we should order by AppliedAt and Id - this is the best solution.


[RFR] Finalize SetWireframe StateChange

Contains
As title mentions, finalizes a Wireframe state change for All obvious State Changes implemented
How to test
By checking the log and observing wireframe debug mode.
FYI:  Debug mode is toggled by F3 key and wireframe with F9.
An example screenshot when wireframe is enabled:

Eliminations must be seen in the log:

Important note:
This PR also includes setViewportSizeOf PR. Please just focus on last commit.

Hooray Jenkins reported success with all tests good!

Neat screenie! Apparently 3D wizards keep spiders as familiars :D

Hooray Jenkins reported success with all tests good!

Too late for me to review this, I better go to bed. I'll review it over the weekend.

Good work on this one. Very few minor issues to address. Let's line it up for landing!

Hooray Jenkins reported success with all tests good!

Changes introduced in 53ca1a4 look good and address the remaining issues. Please @tdgunes solve the conflicts and please @Cervator be informed that this PR is on final approach for landing. =)

The conflicts may be total non-issues due to the import tweaking I did myself. If that's all I'm happy to resolve that and merge - will take a look a little later tonight :-)
Thanks for the updates!

I have gazed upon the arcane spiderweb of 3d wizardry, and it was good. I now know kung fu.
Conflicts were benign as expected: import clash. Found a new/modified file in this PR that then also needed a tweak on top since it was still using the dependency I changed in #2386 (done in https://github.com/MovingBlocks/Terasology/commit/7af48aea4ebe5ca78f4825133c22994f067ff2f9)
As noted in the top post this also included #2419 which I guess may or may not have outstanding comments? In any case I would grab latest including the conflict resolution and apply any needed tweaks on top :-)

Hmmm... this merge was a bit of a mess - my fault.
What I could see specifically from this PR was ready for merge, but I hadn't realized that this PR was based on another one that wasn't quite ready to go yet.
@Cervator: how can we avoid this happening again?

@emanuele3d that was what I was getting at on Slack :-) While functionally distinct PRs may ease review if they overlap in code this sort of thing can happen. Not a lot to do about it other than keeping stuff more insulated or closing older PRs as they're superseded by newer ones (or I guess keep them open but with the understanding that they're subordinate to some further along PR)
Git and GitHub doesn't really care what we do about PRs so long as all the right commits end up in the right branch eventually.


Add support for Private projects (paid of course)

I have a number of projects that can not be opensourced at the moment, however I would still very much like reporting on documentation (such a wonderful idea!).

Thanks, I take that as a compliment!
Are you aware of Inch and InchJS? They are the command-line tools which power Inch CI and can be used locally, from the comfort of your own $HOME.

@rrrene But it is not possible to have a badge visible within the company for example. Or could you extract the badge code and generate an own badge?

It is possible to render badges for private repos in github organizations.

@stefanahman There is Inch Badge.
Maybe you are able to write a script/gem that uses inch-badge to generate badges locally?

@naterkane That sounds like it should not be possible. The CI system should not be able to clone private GitHub repos. could you elaborate?

I'd also like a paid service for private repos. I'm looking into generating my own inch badge but don't really want to spin up a new app server just for badge hosting.

Hi there, sorry for replying so late. I was at EuRuKo giving my very first talk about Inch & Inch CI. The response was completely overwhelming and it seems there are a couple of people who are interested in this as a paid service for private repositories, so I will have to think about the right way to do that.
If you have any more suggestions, please let me know! Maybe I should start by setting up a landing page where people can leave their e-mail / twitter handle to be notified when this becomes available?

Please do

sent from my potato
On Oct 19, 2015 2:58 AM, "René Föhring"<EMAIL_ADDRESS>wrote:

Hi there, sorry for replying so late. I was at EuRuKo giving my very first
talk about Inch & Inch CI. The response was completely overwhelming and it
seems there are a couple of people who are interested in this as a paid
service for private repositories, so I will have to think about the right
way to do that.
If you have any more suggestions, please let me know! Maybe I should start
by setting up a landing page where people can leave their e-mail / twitter
handle to be notified when this becomes available?
—
Reply to this email directly or view it on GitHub
https://github.com/inch-ci/inch_ci-web/issues/64#issuecomment-149121863.


Unexpected Babel configuration behavior

The babel config override will override the loaderOptions, presets, and plugins for both of the babel-loader rules CRA has.
It seems like the second loader shouldn't receive the presets and plugins by default, since the second loader is meant for:

// Process any JS outside of the app with Babel.
// Unlike the application JS, we only compile the standard ES features.

I would argue the behavior is unexpected since only files in src/ are supposed to get babel-preset-react-app and previously tools such as react-app-rewired only modified the first loader

Hi @d3dc
Thank you for your feedback.
Interesting, I haven't notice that.
May I ask what  side effects you are experimenting since craco updates both babel-loaders?
Do you see any use cases were someone would require to apply presets or plugins to both babel loaders?
Thank you

The second loader is intended to polyfill code for browsers with react-app-polyfills. I don't think there should be too many side-effects.
The biggest is performance. Each plugin will traverse the AST for each import - and this happens for all of node_modules with the second loader.
IMO, the second loader is the "polyfill loader". I could see a use case where someone would want to apply a babel preset to all code to support an "environment".

My use case is a little out of the ordinary - I'm trying to package my whole toolkit with a customized craco config and uncompiled library code. When using lerna's bootstrap, my babel config applies differently than when using the packaged code, because the symlink resolves. My fix is just to check which loader is being modified in my loaderOptions function.

So to clarify, anything outside of source ordinarily only gets:

@babel/preset-env
@babel/plugin-transform-runtime
@babel/plugin-syntax-dynamic-import

This does seem odd to automatically add all new plugins to.
It is already pretty convenient to use  a loaderOptions function:
  loaderOptions: opts => {
    if (!opts.customize) {
      // external files
      return opts
    }

    return {
      ...opts,
      ...customization
    }

Hi @d3dc
This is indeed an easy fix if you want to customize what's being configured for the files outside of the src/ directory.
I might wait before updating any code for this one since I don't want to break anyone setup.
How could craco's configuration be modified to accommodate your usecase?
Maybe an applyToExternalFiles  boolean option with a default value of false ? Not sure though if it wouldn't be more confusing than helping?
{
   babel: {
        presets: [],
        plugins: [],
        loaderOptions: { }
        applyToExternalFiles: false
   }
}

I ended up writing a custom function for my babel configuration. Its pretty close to the original, with two things:

it only applies settings to the "customize" loader
it modifies the same loader to include specific external libs

  overrideWebpackConfig({ webpackConfig, cracoConfig }) {
   ...
    const {
      externalLibs,
      presets,
      plugins,
      loaderOptions,
    } = cracoConfig.customBabel

    matches.forEach(({ loader }) => {
      if (loader.options.customize) {
        Object.assign(loader.options, loaderOptions, {
          presets: [...loader.options.presets, ...presets],
          plugins: [...loader.options.plugins, ...plugins],
        })

        if (externalLibs) {
          loader.include = (Array.isArray(loader.include)
            ? loader.include
            : [loader.include]
          ).concat(externalLibs)

          loader.exclude = {
            test: loader.exclude || /node_modules/,
            not: externalLibs,
          }
        }
      }
    })

    return webpackConfig
  }

The boolean approach is probably better for react native libraries, as there could be frequent changes to the config with my way. I would think the performance would need testing before saying a whitelist is faster, but I also think a whitelist is faster.
We both used the word "external" but I wonder if "applyOutsideSrc" is simpler.

Thanks for sharing.
I agree with you that applyOutsideSrc is more accurare.

Will be fix in #49


Model reference still exists in collection after remove

Backbone version: v1.2.1
Description: when you remove model from collection, model is still in collection in model remove handler
Expected: after remove model is not part of collection anymore
Actual: model is still in collection, because model remove event is triggered before model reference is removed
I've located problem in _removeModels method of Collection
...
 _removeModels: function(models, options) {
...
        if (!options.silent) {
          options.index = index;
// PROBLEM: Model remove event triggered, before reference is removed
          model.trigger('remove', model, this, options);
        }
        removed.push(model);
        this._removeReference(model, options);
      }
      return removed.length ? removed : false;
    },

How to reproduce:

var collection = new Backbone.Collection;
var model = new Backbone.Model;
collection.add(model);

model.on('remove', function (model, collection) {
  if (collection.get(model)) {
    alert('Model is still in collection'); // error thrown (unexpected)
  }
});

collection.remove(model);

if (collection.get(model)) {
  alert('Model is still in collection'); // error not thrown (as expected)
};

or jsfiddle: https://jsfiddle.net/mauron85/sLoygsk7/1/

Thanks for the report! We're already tracking in https://github.com/jashkenas/backbone/issues/3693.


Feature/cluster servermapping

Enhanced servermapping options during installApplication to support mapping of WebServers

About the "cleanup", startApplication and stopApplication share the same appManager, should better to extract to a method as you did, while restartServer for a cluster, might not work. I might remove "stopApplication` as it's not been used at all.
I'll need a few days to test you jython script on a cluster, to make sure the currently working stuff is not affected.
Yes, I'm not quite understand why you need to install app to several different unmanaged nodes, like what kind of scenarios...
This plugin should supports customized jython script. You can put your customized jython script to the root directory of the Maven project, and set the file name in the properties section, for the time been.

Are you using Portal server?

Unmanaged nodes can be web servers in a cluster or application servers not in a cluster.
It's not so reasonable to put your mappings for "unmanaged" into the "cluster" section, as it's not actually a "cluster".
Using the same appManager as server will not be able to do rippleStart for the cluster.
So I'm not to merge your PR.
I suggest you use your own jython script within the plugin, s sample as below:
Or refer to this section: Customized Jython Script File
BTW, the customized script was not working as expected untill l.0.11, so please use 1.0.11
<plugin>
	<groupId>com.orctom.mojo</groupId>
	<artifactId>was-maven-plugin</artifactId>
	<version>1.0.11</version>
	<executions>
		<execution>
			<id>deploy</id>
			<phase>install</phase>
			<goals>
				<goal>deploy</goal>
			</goals>
			<configuration>
				<wasHome>${env.WAS_HOME}</wasHome>
				<verbose>true</verbose>
				<cluster>cluster_name_if_is_a_cluster</cluster>
				<host>host_name</host>
				<server>server_name</server>
				<virtualHost>v_host_name</virtualHost>
				<script>myscript.py</script>
			</configuration>
		</execution>
	</executions>
</plugin>


Update tests to support PHPUnit 7

As noted at https://phpunit.de/ , PHPUnit 5.7 was the last version to support PHP 5.x.
Testing on PHP 7.1 with PHPUnit 7.0.2 indicates that new versions of PHPUnit will require our tests to be refactored to use new (namespaced) class names and method signatures.
As PHP 5.6 will reach end-of-life on December 31, 2018, it likely makes sense to update tests as part of a new version of phpCAS that drops PHP 5.6 support.

During my work in #320 I found that the first non backward-compatible PHPUnit should be 8.0.
We still have a long list of 5.x tests in Travis CI. Not sure when to drop support of them.

I have just dropped php 5.x from our build scripts and test are currently running on phpunit 7.5.x


Pre-Backup pod labels are too long

Description
The label of the pre-backup pod is too long. I have no clever way how to solve this but this should definitely not happen.
apiVersion: k8up.io/v1
kind: Schedule
metadata:
  name: backup-schedule-schoolguy-photoprism
  namespace: photoprism
spec:
  podSecurityContext:
    runAsUser: 0
  backend:
    rest:
      url: "http://<IP>:8000/<repository_name>"
    repoPasswordSecretRef:
      name: backup-repo
      key: password
  backup:
    schedule: '0 3 * * *'
    failedJobsHistoryLimit: 2
    successfulJobsHistoryLimit: 2
    promURL: http://prometheus-pushgateway.monitoring.svc.cluster.local:9091
  check:
    schedule: '0 5 * * 6'
    promURL: http://prometheus-pushgateway.monitoring.svc.cluster.local:9091
  prune:
    schedule: '0 0 1 * *'
    retention:
      keepLast: 5
      keepDaily: 14

Additional Context
No response
Logs
2023-05-25T19:35:44Z ERROR k8up.operator Reconciler error {"controller": "backup.k8up.io", "controllerGroup": "k8up.io", "controllerKind": "Backup", "Backup": {"name":"backup-schedule-schoolguy-photoprism-backup-j7s5z","namespace":"photoprism"}, "namespace": "photoprism", "name": "backup-schedule-schoolguy-photoprism-backup-j7s5z", "reconcileID": "313f0f45-4162-4af3-a009-584173651199", "error": "unable to createOrUpdate(\"backup-backup-schedule-schoolguy-photoprism-backup-j7s5z-prebackup\"): Job.batch \"backup-backup-schedule-schoolguy-photoprism-backup-j7s5z-prebackup\" is invalid: spec.template.labels: Invalid value: \"backup-backup-schedule-schoolguy-photoprism-backup-j7s5z-prebackup\": must be no more than 63 characters"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
 /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:326
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
 /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:273
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
 /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:234

Expected Behavior
Pre-Backup Pods spawn as expected.
Steps To Reproduce

Use schedule from above
Wait for error to appear in log

Version of K8up
2.7.1 (app) / 4.2.2 (helmchart)
Version of Kubernetes
v1.26.4+k3s1
Distribution of Kubernetes
k3s

I am deeply sorry that I report so many issues in recent days. I really love the software you build and I will continue to pay the early adopter tax. Before and including 2.7.0 everything was very easy and rock solid for me!

@SchoolGuy
I appreciate you reportiing bugs, so we're aware of them and can fix them. :)
As a workaround here I'd suggest to shorten the name of your backup schedule,

@Kidswiss Ack. Thanks for the tip.


PA computer won't accept lv cable

Description
When you go to complete the PA where you put the lv cables in, the step doesn't appear in the construction process, and it won't let you put the cable in. Thus making the PA unusable. I can get screenshots later if need be, I'm tired though.

occurred again in lizard, no parts will accept lv cable

these were started as machine frames and built normally using machine boards, spawning the unfinished parts and replacing these broken ones let them build it

bugged again this time roundstart barratry

You can't build them manually anymore, they seem to be bugged right now.

Dupe of #18511 and #19342


Strange App Scroll

@aslanyanhaik  , @IvanYurchenko , @rrulin  When I tried to setup this project. everything was quite nice except Chat window scrolling. scroll was not up to the mark when new message pushed or deleted.

@w3care25 this is fixed on latest version