Comments on Best Practices article template

I love the eLife template that you're starting with.
Here are some suggestions that may make it better for our purposes:

A nice custom checklist panel environment would make it a lot easier for authors to come up with something that is usable and has a consistent style. Perhaps the appendix box environment could be adapted for this purpose?
For the Best Practices papers, it probably makes sense to use more of the page width for body text and checklists.
I have a stylistic preference for sans serif math fonts to go along with the sans serif text.
The date, version, and DOI should probably appear in the left column on the first page.
The template can be restructured to give a better example of what we hope the Best Practices papers to look like:

The Abstract might have specific subsections that describe the intended audience, specific application domains, and scope of the document to make it easier for readers to find Best Practices of relevance to them.
An Introduction might follow the Abstract, clarifying the scope and highlighting some recent applications to give the readers a better idea of whether this is the document they want
The Checklist might come next
The Detailed Best Practices section that elaborates on the decisions recommended by the Checklist may come next
A Discussion at the end may highlight still-under-debate areas (though maybe we want a specific section for this?), as well as areas for improvement or things that would help focus areas the next revision can improve

I think these are in general good ideas; I especially like the points about restructuring the template along the lines of what we hope these might look like, or think they might often look like.

Thanks for the detailed input!  I am having a hard time visualizing what you mean by "nice custom checklist panel environment".  Can you link to an example, perhaps?
I agree on restructuring the template to be in the form we want.  Other formatting things we can definitely look at (that's where we probably could use a LaTeX consultant once we have enough formatting ideas!)

Thanks for the detailed input! I am having a hard time visualizing what you mean by "nice custom checklist panel environment". Can you link to an example, perhaps?

I think we want something that generates visually appealing checklist-like panels while making it as easy as possible from the author perspective to slot in the content they want: checklist section groupings, checklist items with boldfaced step summaries, descriptions, and references to other sections of the paper that describe best practices in more details.
As far as visual appearance, you can find some examples that are marginally appealing here:

Checklist with sections and boldfaced step summaries (but awful font choices otherwise
Minimalist checklist with sections
Minimalist checklist with sections in boxes
A visually appealing checklist
Ducati maintenance checklist

I like the first one on John's list a lot, though there are a couple of these that work for me. Basically we want somethign that does checklists which can (but don't have to) be grouped into sections, and each item could have a boldface summary or be just plain text and might or might not span multiple lines.

Got it!  It was unclear if was a checklist for the authors, or a checklist that the authors were preparing for the readers as the "checklist" part of the best practices documents.

Regarding conflicts, should we assume they must be financial?  We could change the default subheading 'Competing Financial Interests' to 'Potentially Competing Interests' and ask for financial and other interests.  For example, 'DMZ is a developer of the WESTPA software package,' which might bias me to present WE and WESTPA the benefit of the doubt.  Probably not a big deal, but it would be nice to set a high ethical standard.

Great idea, yes, I'll add this to my list in #20 . (Added)

We want to steer reader comments to the github repo.  There should probably be info about that on the front page and the end.  On the front page, below corresponding authors (which we should retain, so folks get academic credit) we can put a note for readers to comment directly on the github repo.  Then we can also say the same in a subsection at the end, perhaps just above Author Contrib, to emphasize its importance.

@dmzuckerman Something that PLOS does well is on the side panel when viewing an article, it provides tweets that reference the paper. We could possibly have a conversations tab on the side of the article that shows the github issues.
This seems to be very similar to what we are looking for. Although I am quite unfamiliar with Jekyll and implementing this API.

Good idea!  I'm not a good person to comment on feasibility.

From: Justin Gilmer<EMAIL_ADDRESS>Sent: Wednesday, September 20, 2017 10:12 AM
To: livecomsjournal/article_templates
Cc: Daniel Zuckerman; Mention
Subject: Re: [livecomsjournal/article_templates] Comments on Best Practices article template (#16)
@dmzuckermanhttps://github.com/dmzuckerman Something that PLOS does well is on the side panel when viewing an article, it provides tweets that reference the paper. We could possibly have a conversations tab on the side of the article that shows the github issues.
Thishttp://donw.io/post/github-comments/ seems to be very similar to what we are looking for. Although I am quite unfamiliar with Jekyll and implementing this API.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/livecomsjournal/article_templates/issues/16#issuecomment-330918857, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AUWz1_TOKiwt8811DAsTaChx9OxM4kz4ks5skUdmgaJpZM4PP39l.

@justinGilmer - you're having some good ideas. I think we want to be careful to distinguish between two different things in discussions for clarity though:

actual journal website (livecomsjournal.org)
journal information site (https://livecomsjournal.github.io/)
(Maybe we need names for these to improve clarity?)

Anyway, I THINK you're asking about the actual journal website, which is actually run on Scholastica and where we have very little control over design/features at this point (though hopefully that'll improve in the future). The journal information site runs Jekyll, and we have a bit more freedom doing things there (though it's still hard to be super fancy).
@ptmerz will need to comment on Jekyll feasability I think. :)

I would have to look into Jekyll feasibility, I don't know offhand, but I also think that what @justinGilmer refers to would be about the journal page (livecomsjournal.org). So we would need to ask Scholastica about feasibility.
For the info page (livecomsjournal.github.io), I am not sure commenting features are necessary, as these pages should be relatively static once we worked out the policy details.

@justinGilmer - the journal website content is all on this site: https://github.com/livecomsjournal/journal_information
Michael migrates it by hand from there to the actual live page.
So that would probably be the best place to discuss. Maybe you can start an issue tracking things we should discuss with Scholastica that we'd like them to enable if possible or at least give us freedom to modify. As I understand it hosting is in beta and they will be adding lots of features, etc. eventually, so we should get them feedback/requests.

A couple stylist comments:
--Quite minor: On page 6, why is the spacing different between the lines?
--Re the gutter: do we imagine a use for it beyond on the first page where it specifies the contact info, etc.? Annual Reviews uses gutters for figure captions, first defining acronyms, other definitions, etc. If we want to use the gutter space in that way, let's add some examples. Otherwise, let's use the whole page (helps with tables and images) and go to two-column.

Good comments on gutter. We could get rid of it after the first page.  Using the gutter for other things (figure captions, etc), could complicated this a fair amount, and we don't want to have to resolve people's typesetting issues.  Perhaps the stuff in the gutter should just be at the bottom of the page.
No idea on the space difference between the lines, but I could ask.

Agreed. I like RSC journals' approach of a gutter next to the abstract, then removing it and switching to two-columns. I've found their LaTex templates easy to use.
I'm probably the only one who would notice spacing differences between those lines; not a big deal.

Thanks, everyone, for the valuable feedback! I'm updating the to-do list accordingly.
@jchodera - I know you're a big fan of the eLife template; do you have thoughts on the suggestion to go to two columns (eliminating the gutter) after p1?

This was closed by the updates to the templates which were merged ( #23 ).


Build Reusable Components - Component parameters are invalid

For Kubeflow 0.5.1, the input/output parameters for the dummy component.yaml are out of sync in Component Development:
When running the provided example component.yaml with description='GCS path to Input 1' i get the following error:
__init__() got an unexpected keyword argument 'description='GCS path to Input 1''
After changing the description from description= to description: and default= to default:  That resolved the first issue.
Next,
In the sample pipeline:
Parameters for Output 1 URI template/output_1_uri_template are missing from the the sample pipeline file, and not output_1_uri
input_1_uri for dummy2_task should be output_1_uri and not output-1-uri

/area usage
/priority p2


Autocomplete: dotting into records

type Person =
  {
    age  :: Int,
    name :: String
  }

testPerson :: Person
testPerson = { age: 56, name: "Andrew" }

Q1: with the above definitions, typing testPerson (say within a function in the same module) and then a . does not bring up a list of the record's fields, age and name.  Should it do so?  Tooltips certainly reveal that the editor knows the type of testPerson; sometimes it's revealed as Person and at other times as an anonymous record type with fields age of int and name of string, but in neither case does dotting-into testPerson show its fields in auto-complete.
Q2: related, but different... with the above definitions and this function:-
showPerson :: Person -> String
showPerson p = p.name <> " (" <> (show p.age) <> ")"

typing p within the function body brings up an autocomplete list without this local, and dotting into p also doesn't show the record's fields.  Are these behaviours to be expected?
Is it worth opening an issue for these matters?
(I have the latest purescript, pulp, Atom.io, psc atom packages, etc.)

No, neither of these things is going to happen at present, though I agree they are desirable, because type information is provided by psc-ide (see the compiler repository) which currently operates on the basis of externs files rather than a full (typed) AST, making it fast but restricting to information on top-level identifiers. (Moreover, only exported identifiers, except in the case that you first rebuild (by saving) the individual file in question)
@kRITZCREEK was investigating completion for records but the current solution isn't ideal & may not progress.
So discussion of these particular issues should be in the purescript repo (probably there will be some existing issue tagged with psc-ide) - but I don't object in general to issues being raised here where it's not clear to you :)


Values mistaken as identifiers

vars one two three int 2
The 2 is mistaken as an identifier despite being a value.
Identifier detection needs to be improved to ignore numbers.

you could separate those via the function call is_valid_int since identifiers can't be pure numbers and there is not type that is a pure number.


Create a omop.geom_omop_location table (geocoded addresses) DDL

Have a DDL as a first step towards solving #193
location_id
person_id
care_site_id
address_type (patient or care_site)
address
geometry

Edits need to be made to write/create Gaia DDL scripts to automatically generate

This is incompatible with the more recent thinking about getting geocoded patient data into Gaia


Impossible to write ':' character

After the installation of the plugin I cannot write ':' character.

I'm guessing you're on a non-US or non-QUERTY keyboard, see #128 if so, otherwise can you provide additional context (settings, other plugins, os, etc)

Sure, I am spanish with spanish keyboard.

Your best bet for now is to check the "Legacy/International Mode" checkbox in preferences, until the deeper issues with atom have been worked out


http mock routes in production

I'm using backbone.js routes with HTML5 pushState on 0.2.4. In development it works fine but in production it gives me Connect GET error.

Hi Andrew
Well spotted. Will be fixed in 0.2.5 out soon.
Owen


fwupd: 1.5.3 → 1.5.5

Motivation for this change
- https://github.com/fwupd/fwupd/releases/tag/1.5.4

https://github.com/fwupd/fwupd/releases/tag/1.5.5

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 111607 run on x86_64-linux 1

2 packages marked as broken and skipped:

libsForQt512.discover
libsForQt514.discover

1 package blacklisted:

tests.nixos-functions.nixos-test

4 packages built:

fwupd
gnome-firmware-updater
gnome3.gnome-software
libsForQt5.discover (libsForQt515.discover ,plasma5Packages.discover)

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 111607 run on x86_64-linux 1

2 packages marked as broken and skipped:

libsForQt512.discover
libsForQt514.discover

1 package blacklisted:

tests.nixos-functions.nixos-test

4 packages built:

fwupd
gnome-firmware-updater
gnome3.gnome-software
libsForQt5.discover (libsForQt515.discover ,plasma5Packages.discover)


Let OpenSslContext implement ReferenceCounted?

Hello,
would it make sense to let the OpenSslContext class implement the ReferenceCounted interface?
We have a dynamic and unbound set of OpenSslContext that are concurrently in use and it would be great if we can release the native resources in a timely manner. We're currently using a wrapper object that extends SslContext, implements ReferenceCounted and gets passed into the SniHandler.
Something along the lines of this pseudo code. I'd be happy to open a PR.
public class OpenSslContext extends SslContext implements ReferenceCounted {

  private final ReferenceCounted refCnt = new AbstractReferenceCounted() {

    @Override
    public ReferenceCounted touch(Object hint) {
      OpenSslContext.this.hint = hint;
      return this;
    }

    @Override
    protected void deallocate() {
      destroy();
    }
  };

  private Object hint = null;

  @Override
  public int refCnt() {
    return refCnt.refCnt();
  }

  @Override
  public OpenSslContext retain() {
    refCnt.retain();
    return this;
  }

  @Override
  public OpenSslContext retain(int increment) {
    refCnt.retain(increment);
    return this;
  }

  @Override
  public OpenSslContext touch() {
    refCnt.touch();
    return this;
  }

  @Override
  public OpenSslContext touch(Object hint) {
    refCnt.touch(hint);
    return this;
  }

  @Override
  public boolean release() {
    return refCnt.release();
  }

  @Override
  public boolean release(int decrement) {
    return refCnt.release(decrement);
  }

  protected final void destroy() {
    synchronized (OpenSslContext.class) {
      if (ctx != 0) {
        SSLContext.free(ctx);
        ctx = 0;
      }

      // Guard against multiple destroyPools() calls triggered by construction exception and finalize() later
      if (aprPool != 0) {
        Pool.destroy(aprPool);
        aprPool = 0;
      }
    }
  }
}

@rkapsi I think we could do this. That said we would still need a finalizer for the OpenSslEngine itself as we never know what the user will do with it (or will use it at all after creating).

@normanmaurer Correct. It's meant to be an optimization for folks who don't want to wait for the GC. The finalizer will still run but potentially do nothing.

@rkapsi are you using the OPENSSL_REFCNT ssl provider in production? I'm currently trying to wrap my head around the usage eg. every call to io.netty.handler.ssl.SslContext#newEngine(io.netty.buffer.ByteBufAllocator) must be matched with releasing it via io.netty.util.ReferenceCountUtil#release(java.lang.Object) or is it enough just to release the io.netty.handler.ssl.SslContext? equally from a client pov it seems it is possible to hack the openssl_refcnt ssl provider into async-http-client using a custom org.asynchttpclient.SslEngineFactory but I suppose each connection may need to be released explicitly too.

@johnou we do. In our case we match newEngine(...) to one release(...) upon the client's disconnect.
Management of the SslContext follows a similar pattern but there is a little twist. We try to re-use an SslContext instance for as long as possible (with constraints) by making use of a (heap) caching layer. The flow looks about like this:
A client connects and we go thru the SNI flow. The SNI thingy is backed by the said cache. The cache always increments the refCnt by 1 before returning it and we then do newEngine(...). When the client disconnects we decrement the engine's as well as the context's refCnts by 1. And lastly the cache decrements the context's refCnt upon eviction.
To put it differently, a context's refCnt will always be >= 1 as long as a reference is being held in the cache OR one connection is using it.

@rkapsi perfect, thanks! I am currently investigating implementing it for our server application as we have thousands and thousands of concurrent long lived SSL connections.. at first glance it looks like I don't even need to track the engine as releasing it is already taken care of here io.netty.handler.ssl.SslHandler#handlerRemoved0 :grinning:

Yea, we do something like this:
class MyHandler extends SslHandler {
  SslContext sslContext;

  void handlerRemoved(...) {
    try {
      super.handlerRemoved(...);
    } finally {
      sslContext.release();
    }
  }
}

See also #9626


Update view-state-transitions.md

Missing the binding for _goToNYC :)

For #

Background

Change List

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage remained the same at 82.494% when pulling 45faf386c25a45c2b8e15ec0c9b13d13315a594e on FrancescoSaverioZuppichini:patch-1 into aceae4ece500007f4989ef5e0ebd678791e2b628 on uber:master.

 All committers have signed the CLA.


Implement login and register

Implement auth related endpoints. Start with the blocking ones, the rest can be added at a later point separately.

Add user schema
Add related endpoints:
Login
Registration
Inject user to request context and implement an auth guard

I changed the description of this PR from "Issue #30" to "Closes #30", following Linking a pull request to an issue using a keyword


Tasks 205-208: New Synthetic tasks

Also, there is a bug in the current test_all.py script. The for loop on line 65 does not run. The line 55 instances = enumerate(data['Instances']) should be removed. After the first for loop runs on line 58 the instances variable will point at the end of the enumerate object. Thus when the second loop runs there is nothing to enumerate over. I've made a new test script that solves this error (and also runs faster) but did not include it, let me know if you would like me to add the new testing script as well.  Currently, there are 13 files that include input from a Positive Example in the Instances.

Tasks till 204 are taken (https://github.com/allenai/natural-instructions-expansion/pull/120), I have renamed this PR. Please rename your files.
Thanks for finding the issue in the test. Are you sure about the bug? Please add your changes in a new PR (saying fixing test file)

How do I open a pull request with a specific commit? Currently, when I go to open another PR it includes this PR and the commits in this PR. Also, when I push to my local branch the commit appears under this PR.
This code is a simpler version of what's going on. You can run this to confirm.
arr = [1,2,3,4,5]
instances = enumerate(arr)
for idx, ar in instances:
    print(f"I am the index = {idx} I am the element {ar}")
for idx, ar in instances:
    print(f"SECOND LOOP I am the index = {idx} I am the element {ar}")

Looks good to me, thanks!

Merging! Apply the above comments next time you create PR.


Write out of order hint when initially creating meta file

This PR adds the from-out-of-order hint to meta before the meta file is created, so that the file doesn't need to be re-written afterwards. This PR generalizes the parent meta in LeveledCompactor.Write to be a base meta, to be used for building actual block meta.

So the reason to do this is efficiency?

Yea, there's no need to re-write the meta file for OOO blocks.


Refactors HTTP SpanReporter tests to use ZipkinRule

This replaces direct usage of MockWebServer with ZipkinRule.
See https://github.com/openzipkin/zipkin-java/pull/83

:shipit:


Some songs skipped

The issue is
-Running a song above 5000 tempo may cause random lines to be skipped once in a
while if your computer isn't fast enough. This is an efficiency problem that
may have to be sorted out over time and many iterations.
[FIXED, v1.0.0]
My tempo is 556.0 and it skipped one of the line like this one

Please fix this I want to make this song

Are you having issues with recording or just regular song making? I've been attempting to improve the performance over time but it might not track to older computers too well. If it's just recording, you can always join the discord server and there are people there who can help record.

My computer is not that old, I was making a Chinese song and this part skipped. How to fix this?

This appears to be fixed?


Fix Portal widget

Overall, I'm not sure what's going on here at all as there's only a single comment (and not related to the temporary changes).

The comment is somewhat related.
Basically, one of the problems we ran into with the to_do_list example was that we had a Flex inside a Portal, and the Portal is design to display scrollbars and provide scrolling if the child is larger than its constraints... but then Flex's layout method always clipped the returned size it wasn't ever larger than its constraints. Hence, no scrolling. Removing the bc.constrain(my_size) part makes the example have scrolling behavior again.
I guess I should add this explanation to the commit message.

I'm not sure why the track caller stuff is part of a same commit with a fix for something... and no comment explaining why that's there either.

I think #[track_caller] is standard / researchable enough not to need a comment.
The #[track_caller] annotation makes it so that if a function crashes, the crash location reported (file, line number, etc) will be the location of the function's caller, not the part inside the function that crashed. I added a bunch of them because I kept getting crashes and these annotations are helpful to pinpoint their cause.

Just checking that you will add that to the commit message…

Just checking that you will add that to the commit message…

Good catch =)


Use DMI on EC2 Nitro instances to get host aliases

What does this PR do?
The Agent now leverage DMI information on Unix to get the instance ID on AWS EC2 when the metadata endpoint fails or is not accessible. The instance ID is exposed throught DMI only on AWS Nitro instances.
This will not change the hostname of the Agent upon upgrading but will add to the list of host aliases.
Describe how to test/QA your changes
Test on ECS/EKS/EC2 that we can get the instance-id as an host aliases when the metadata endpoint is not available (you will need a Nitro instance: use a C5).
The AWS metadata endpoint is not available when running in a container on ECS/EKS (because the network hop is 1).
On EC2 use aws ec2 modify-instance-metadata-options --instance-id i-123456789 --http-endpoint disabled.
Finally, test that Fargate agent does NOT collect an host alias.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

This is a cool feature, but it would be really nice if the documentation was really clear about this when encountering strange anomalies with host_aliases not getting populated on instances that aren't nitro-based.
Example: https://docs.datadoghq.com/containers/troubleshooting/duplicate_hosts/
In our environment, we want to avoid enabling more than 1 hop for IMDS (for compliance reasons), but I was caught by surprise when the functionality was only working on nitro-instances because of this DMI feature. When I launched i3 instances, the duplicate hostname issue arised since host_aliases wasn't being populated.
Now I have to enable more than 1 hop for those node-types.


Migrate metafields to hui

Description
This migrates metafields to hui. As part of this migration, I realized that there's still quite a bit of work left in the metafield component to get full parity with what the SFAPI exposes, so we added that as a task to our board, to get to in the future.
None of the stories have controls, but I think that works out because there's a story for each and every type of metafield we support. I did notice as part of that, that we're potentially not handling {type}_reference metafields well, either (see paragraph above).
Stories added:

Also exposes flattenConnection, parseMetafield, and parseMetafieldValue helper functions.
Additional context
I fixed our package exports to use browser instead of script, and also updated h-ui dependencies.  I also fixed an issue with our Vite config (for testing) where __HYDROGEN_DEV__ wasn't being set correctly, and had to update some other tests to account for that.

Before submitting the PR, please make sure you do the following:

[x] Read the Contributing Guidelines
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[ ] Update docs in this repository according to your change
[x] Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

I also was tophatting 🎩 and found some laddle stories not showing.

Yeah, that's on the {thing} reference pages, right? I talked with Elise about that and we're going to come back to metafields before release and make sure we're getting everything right; there's still quite a bit of work to be done here to support everything that a metafield can be. So, we're punting on it for now.

Also json shows like this. Is this expected?

Yeah, that's the expected behavior for now. Stringified json.


Unable to detach google account at My Account page due to null exception

When detaching your google account at My Account Page, null exception occurs.

I guess this issue is related to https://github.com/concrete5/concrete5/issues/7750 which was introduced after https://github.com/concrete5/concrete5/pull/7011 (maybe).

This issue is not to do with 7750
It is a problem introduced when I re-wrote the Oauth2 controller and added detaching for all SNS options by default.
see https://github.com/concrete5/concrete5/pull/6018/commits/f5ca04db25c812d1069f2d846ef91101627d8cc2
Its fixed now in #8190


Fix LQR for 3 arguments

Fixes #24

Coverage increased (+0.04%) to 72.93% when pulling 0f37e9f7c1623a4b923e8c4576f8c0cfdbc69213 on cwrowley:fix-lqr into 86ebb1cdd3c3c1546356deea1f1e137ec6f1f728 on python-control:master.

Coverage increased (+0.04%) to 72.93% when pulling 0f37e9f7c1623a4b923e8c4576f8c0cfdbc69213 on cwrowley:fix-lqr into 86ebb1cdd3c3c1546356deea1f1e137ec6f1f728 on python-control:master.

I reviewed this and the fix + unit test looks good.  Merging with master branch.


accessibilityIdentifier for SVProgressHUD

Is it possible to add an accessibilityIdentifier for the SVProgressHUD, so that it is easily accessible for UI Tests ?
Thank you very much for your work.

Is there an answer for his question?


Move NavViewItem presenter margin to resource

Description

Move NavigationViewItem's ContentPresenter margin to resource for lightweight styling
In the current state, this PR does not create merge conflicts with #2271
Motivation and Context

Closes #2288
How Has This Been Tested?

Running app and looking at visuals.
Screenshots (if appropriate):

Open question: Should the negative margin of the chevron also be a theme resource?

Should the negative margin of the chevron also be a theme resource?

@chingucoding I started a discussion the chevron here.

@chingucoding I started a discussion about the chevron here.

I think that discussion is more moving towards changing that value, right? The question in this PR is to what degree we should provide lightweight styling.

@Chingucoding Since users can lightweight style the thickness of the scrollbar and the linked issue is meant to prevent the chevron from being overlapped by the scrollbar we should also provide a lighweight styling resource for the chevron.

True. @ranjeshj @ojhad @StephenLPeters @chigy Thoughts?

@Chingucoding How do we want to approach issues #2288 and #2287? My initial plan was to create one PR with the updated values and adding lightweight styling resources. Now that you already created a PR for this one, do we consolidate them in one PR or wait for one PR to be merged first with master and then base the other PR on it?

If that's fine with you, I can add the fix for #2288 it in this PR to save time with this, but I leave that up to you. If you want you can create a PR with the updated values, you can also do that. Since we wouldn't be touching the same areas depending on where you put the new resource, I don't think that there will be merge issues.

Talked with @chingucoding and we decided to treat both issues independently. A later PR for issue #2287 will update the introduced lighweight styling resources in this PR if required.

                                Margin="-16,0,0,0"

We'd want this to update with changes to the resource value as well

Refers to: dev/NavigationView/NavigationView_rs1_themeresources.xaml:677 in e6e3cd0. [](commit_id = e6e3cd0db2da35cead70f13aa141e0a9727b0b36, deletion_comment = False)

                                Margin="-16,0,0,0"

We'd want this to update with changes to the resource value as well
Refers to: dev/NavigationView/NavigationView_rs1_themeresources.xaml:677 in e6e3cd0. [](commit_id = e6e3cd0, deletion_comment = False)

I'm not sure there is a way to get both of these referencing the same resource without creating a converter... So I think I'd just make a second resource

I've added a resource for that. Also noticed that we had some special margins for the top present, added resources for them too.

@chingucoding #2271 is now merged, can you merge master and push an update ? Thanks!

@chingucoding #2271 is now merged, can you merge master and push an update ? Thanks!

Good idea, done.

/azp run

                                Margin="12,0,16,0"

there is a separate style for when these items are in the overflow flyout, we probably want to create styles for these as well

Refers to: dev/NavigationView/NavigationView_rs1_themeresources.xaml:1468 in c7d4a15. [](commit_id = c7d4a1508ebbc41fe89b037fdb8f5295caf0f465, deletion_comment = False)

there is a separate style for when these items are in the overflow flyout, we probably want to create resources for these as well

Good point, created resources for that too.

/azp run


AttributeError: module 'tornado.web' has no attribute 'asynchronous'

Hello there,
There is a dependency problem in the last splash-jupyter commit.

Because of the update of nbconvert, tornado version 6 has been changed.
I think we should downgrade nbcovert to a version where tornado version 5 is used.
I'm gonna try with that and let you know.
Kind regards,
Ahmed.

Hi again,
I managed to fix the issue:
Simply you need to uninstall nbconvert and tornado
pip uninstall tornado
pip uninstall nbconvert

After that re-install nbconvert==5.3.1 and tornado version 4.2
pip install nbconvert==5.3.1
pip install tornado==4.2

Next you need to re-build the image after you exit.
docker ps -a
copy the container ID and rebuild the image:
docker commit <container_id> jupyter_splash:test
Now to launch it you simply need to use the following command:
docker run --entrypoint="../start-notebook.sh" -p 8888:8888 -it jupyter_splash:test
Kind regards,
Ahmed.

This is not a solution right... what if I should use tornado 6.0

A much better solution for those running into this issue is to do pip install --upgrade nbconvert. This allows you to keep tornado6.

Thanks @Teque5

@Teque5 thanks

@Teque5  This solution does not work with nbconvert==5.6.0 and tornado==6.0.3
We should reopen this issue

A much better solution for those running into this issue is to do pip install --upgrade nbconvert. This allows you to keep tornado6.

That works for me! Thank you.

i am using tornado 6.0.3 but i am still facing the issue

I have the same question, i am using tornado 6.0.3 but, still facing the issue

Updating nbconvert to 5.6.1 with tornado 6.0.3 works for me.

I have tornado 6.1 and nbconvert 6.0.7, upgrading does not works for me either.

I have tornado 6.1 and nbconvert 6.0.7, upgrading does not works for me either.

tornado 6.1 + nbconvert 5.6.1 = working for me.

A much better solution for those running into this issue is to do pip install --upgrade nbconvert. This allows you to keep tornado6.

Thanks


Skungee error sending to server on bungeecord network

Hi,
I have an issue with skungee sending me from Lobby to BuildServer.
All my servers are connected successfully.
Lobby log: https://pastebin.com/7F5vcrPq
Bungeecord log: https://pastebin.com/1yULgQD7
BuildServer log: https://pastebin.com/UeE2SXiJ
Skript that should send me to buildserver: https://pastebin.com/x2gsQG7M
Lobby and Build server version:
CraftBukkit version git-Spigot-db6de12-18fbb24 (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)
Bungee version:
BungeeCord version git:BungeeCord-Bootstrap:1.16-R0.4-SNAPSHOT:5ab5a84:1533 by md_5

Duplicate https://github.com/Skungee/Skungee/issues/156


Clearer implementations of LDAP

I've found much confusion amongst people on the best way to implement LDAP with helm, so i thought id create a small addition to allow users to quickly and easily add in LDAP configuration.
Example discussions like: https://github.com/trinodb/trino/discussions/17531 could be solved. Also similar but more up-t-date then this PR: https://github.com/trinodb/charts/pull/104/commits/1abb250b260358fce3e6fac8529a1addf9636491

I'm closing this since it's abandoned.


Kafka source 0.9.0 seems broken

Expected Behavior

it works

Actual Behavior

0.8.2 is last working releaes

Additional Info
From the logs:
kubectl logs -f kafka-source-ppvb6-7d777c4fc6-68ms5
{"level":"info","ts":"2019-09-24T07:48:39.332Z","caller":"receive_adapter/main.go:110","msg":"Starting Apache Kafka Receive Adapter...","BootstrapServers":"my-cluster-kafka-bootstrap.kafka.svc:9092","Topics":"my-topic","ConsumerGroup":"knative-groupppp","SinkURI":"http://event-display.default.svc.cluster.local","SASL":false,"TLS":false}
{"level":"info","ts":"2019-09-24T07:48:39.333Z","caller":"adapter/adapter.go:110","msg":"Starting with config: ","BootstrapServers":"my-cluster-kafka-bootstrap.kafka.svc:9092","Topics":"my-topic","ConsumerGroup":"knative-groupppp","SinkURI":"http://event-display.default.svc.cluster.local","Name":"kafka-source","Namespace":"default","SASL":false,"TLS":false}
{"level":"info","ts":"2019-09-24T07:48:42.477Z","caller":"kafka/consumer_handler.go:65","msg":"Starting Consumer Group Handler, topic: my-topic"}

while the messages are consumed, they are not dispatched to the http sink

All works fine...
I just tested w/ NON-JSON messages.
putting JSON (e.g. {"yo":"yo"} on the topic makes the source work :-)

/close


Added Rule for Nginx Ingress Shows no Resources

What happened?: I've added some rules to capture Nginx ingress metrics, but see no results from the API (details below).
What did you expect to happen?: See results from a query to /apis/custom.metrics.k8s.io/v1beta1. What I actually see is:
{
  "kind": "APIResourceList",
  "apiVersion": "v1",
  "groupVersion": "custom.metrics.k8s.io/v1beta1",
  "resources": []
}

Please provide the prometheus-adapter config:

prometheus-adapter config
    - seriesQuery: '{__name__=~"^nginx_ingress_controller_requests.*",namespace!=""}'
      seriesFilters: []
      resources:
        template: <<.Resource>>
        overrides:
          namespace:
            resource: "namespace"
      name:
        matches: ""
        as: "nginx_ingress_controller_requests_rate"
      metricsQuery: round(sum(rate(<<.Series>>{<<.LabelMatchers>>}[1m])) by (<<.GroupBy>>), 0.001)

I've also tried being greedier with the query; "^nginx_.*".

Please provide the HPA resource used for autoscaling:

HPA yaml
Not relevant, didn't get that far.

Please provide the HPA status: N/A
Please provide the prometheus-adapter logs with -v=6 around the time the issue happened:

prometheus-adapter logs
I'll add more as requested, but for now I'll just post what I believe is pertinent, which is that I do see lines like this:
I0317 08:17:01.370711       1 api.go:76] GET http://prometheus-server.monitoring.svc:80/api/v1/series?match%5B%5D=%7B__name__%3D~%22%5Enginx_ingress_controller_requests.%2A%22%2Cnamespace%21%3D%22%22%7D&start=1647504961.368 200 OK

Anything else we need to know?:
Environment:

prometheus-adapter version: Tag v0.9.1 from k8s.gcr.io/prometheus-adapter/prometheus-adapter
prometheus version: 2.26.0
Kubernetes version (use kubectl version): 1.19
Cloud provider or hardware configuration: AWS, running on EKS
Other info: Deployed via Helm

I see very similar issue.
resources is empty and I see only seriesMatch query.


Iotedge: Troubleshoot warning for setting DNS via deployment

When setting DNS via an iothub deployment, it is possible to get EdgeAgent in a state where it can no longer connect to iothub and receive new deployments. The recommendation in this case:

Warning: If you use this method and specify the wrong DNS address, EdgeAgent will lose connection with iothub and won't be able to receive new deployments to fix the issue. In order to resolve this, you can reinstall the iotedge runtime, making sure to remove any EdgeAgent containers after uninstall.

@and-rewsmith : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Update GKE kubelet scraping docs

Chatting in https://github.com/coreos/prometheus-operator/issues/1623 it sounds like prior to 1.11, downgrading to https is the correct approach.
This adds the jsonnet approach to to the docs, and adds a reference to it from the README

Thanks!


[0.17.45] LuaCustomTable cannot be serialized

This seems to happen entirely at random. Every server in the cluster will attempt a save and crash with this error at the same time.

31985.387 Warning WriteFileGuard.cpp:57: Writing D:\Factorio Server\main\factorioClusterio\instances\Mining\saves_autosave1.zip failed; previous version (if any) should still be available
31985.388 Error ParallelScenarioSaver.cpp:114: Saving scenario failed: The mod Clusterio caused a non-recoverable error.
Please report this error to the mod author.

Error while running event clusterio::on_save()
LuaCustomTable cannot be serialized.
31985.391 Error Util.cpp:83: Attempting to create notice box in headless mode. Message: 'Cannot save map: The mod Clusterio caused a non-recoverable error.
Please report this error to the mod author.

Error while running event clusterio::on_save()
LuaCustomTable cannot be serialized.'

Weird. What version of the mod are you running, what other mods are you running?

Seems to be a recurring factorio bug according to this bug report and many from previous years as well.
Have you made a bug report on the forums?

This issue is caused by the combinator code storing a reference to a LuaCustomTable in a local variable (see https://github.com/Danielv123/factorioClusterioMod/blob/1.15.2/src/control.lua#L806-L814).  This code has been removed along with the rest of the combinator code.


"pdf" links should directly download the pdf, not link to github repo

I'm talking about this page https://compstat-lmu.github.io/lecture_i2ml/articles/content.html
where I click on a "pdf" link. If this is not the official site you can disregard this.
Maybe you can get direct pdf download links if you link to https://compstat-lmu.github.io/..../x.pdf

i am sure what the issue is? is anything inconvenient?
the github io page is the "official" entry point (for readers, students and so on)
the normal github repo for authors / developers.
the pdfs are created by makefiles in the normal repo then pushed to it.
then we link to them in the pages.
but again: whats bothering you?

ok sorry, i get it now. because the pdf is not directly dled, but "opened" in the repo, i see

i dont know how to fix this to be honest. it doesnt seem like a super bad problem?

if you right-click on the pdf links and say "save to" it works as exepected an without going to the repo.
maybe we should add a sentence that people should do that, and all is good?

Maybe deploy the pdfs to the gh-pages branch and link to them there?


Fix pgx dependency to v2

Fix dependency of pgx to v2.
Can be closed when https://github.com/bgentry/que-go/pull/16 gets merged.

#16 is merged and released as v1.0.0. Use an earlier tag (such as v0.5.0) if you want pgx v2 compatibility. Thanks!


1.7a3 release

Hi @sgillies, is there going to be a release soon? Having the issue that https://github.com/Toblerity/Shapely/pull/765 seems to have solved.

New target date: 2019-12-30.

I am adding testing against shapely master to the CI of GeoPandas, and all is passing at the moment.

Issues in the 1.7a3 milestone are closed, pull requests merged, the tag is pushed, and I'm building wheels now.

https://pypi.org/project/Shapely/1.7a3/#files.


cinny: 2.2.0 -> 2.2.2

Description of changes
https://github.com/cinnyapp/cinny/releases/tag/v2.2.2
Security release including fixes from:
https://github.com/matrix-org/matrix-js-sdk/releases/tag/v19.7.0
https://github.com/matrix-org/matrix-js-sdk/releases/tag/v20.0.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I already opened one at https://github.com/NixOS/nixpkgs/pull/193349

Great! In the future it'd be great if you could coordinate with us on matrix

Great! In the future it'd be nice if you could coordinate with us on matrix

When you say "us", who do you mean exactly ? And where ?

The matrix and security channels on matrix which you can find in the space: https://matrix.to/#/#community:nixos.org
#matrix-nix:transformierende-gesellschaft.org
https://matrix.to/#/#security-discuss:nixos.org
https://matrix.to/#/#security:nixos.org


add ability to specify project with :TogglStart?

First, thanks for making this plugin! It works great. It'd be really great if there were a way to run :TogglStart some task here +projectName and have the command start the task called "some task here" and assign it to the project 'projectName'. This would be really useful for users of todo.txt and todo.txt-vim, since todo.txt lines have entries like:
make some breakfast +meals

Where the +meals is the project. If there were a way to specify the project name with :TogglStart, then I could put together some keybinding that runs :TogglStart <current line here>, and it would automatically start the task given by the current line in the todo.txt. That would be so awesome.

I create a PR #3 to resolve it.
Could you please test it?

Great! Starting a project works, with :TogglStart task name +project! I see you added tag specifiers too, that's so awesome. Starting a task with a tag doesn't yet work for me, though--I tried :TogglStart test task @Coding, for instance, and the task starts, but with the name 'test task @Coding' instead of attaching the tag Coding.

Nevermind, it looks like it's working now. Maybe I just forgot to reload it. Thanks! Closing.

Thanks!


added partial codeowners file

the oss-big-tent squad is fine with owning the sql-related code in this repo, so i made a CODEOWNERS that reflects this. of course, if someone else wants to own it too, feel free to comment and we can modify this👍 .
(NOTE: github is complaining that the codeowners is not valid because oss-big-tent has no write access, i'll solve that if/when this gets approved)

(i just picked the last 5 committers as reviewers 😄 )

you should add the team as writers to this repository.


Allow using custom encoders and decoders instead of hard-coded Aeson ones

Accompanied by https://github.com/eskimor/servant-purescript/pull/34

awesome, thank you!


Declosurize

Brod uses a lot of long-lived anonymous functions, which cause problems during live upgrades. In our case a change in build procedure caused the brod .beams to change unexpectedly, causing a lot of badfun errors after the upgrade. (If you know brod will be upgraded you can stop and restart it, but in this case we didn't know.)
To avoid these issues this changes several callback functions to accept a {Fun, Arg} representation. At the call sites, Arg is prepended to the list of actual parameters. This allows us to use exported functions, fun Module:Fun/N, as the callbacks, making the code live-upgrade safe.
In two cases the code wrapped data in functions to hide it from crash logs, but that isn't necessary any more.

Looks like rebar3 is broken in your OTP-21 job. I have no idea why the OTP-22/23 jobs were cancelled.

Looks like rebar3 is broken in your OTP-21 job. I have no idea why the OTP-22/23 jobs were cancelled.

All jobs in a matrix are cancelled if any one of them fails (it's a github action feature).
It's likely the default rebar3 for github action has been upgraded to one built on OTP-22.
I have sent https://github.com/kafka4beam/brod/pull/461 to fix it.

@mikpe if you fetch and rebase, the ci should be able to run.

Rebased and added a note to the changelog.

thank you @mikpe
Please change TBD to 3.15.6 if you want a tag

Done, thanks.

3.15.6 tagged

Thanks


max-height issue

Hi,
I was using selectpicker for items having more than 20 rows, i notice that when the list has the search and action box (select all and deselect), the scrollbar is also adjusted and cannot be seen anymore.
i am not sure if it's because the height is automatically computed, however if the search and action box is included on the list, it was not part of the computation.

See guidelines for contributing.

Bug reports
A bug is a demonstrable problem that is caused by the code in the repository.
Good bug reports are extremely helpful - thank you!
Guidelines for bug reports:

Use the GitHub issue search. Check if the issue has already been reported.

Check if the issue has been fixed. Try to reproduce it using the latest master or development branch in the repository.

Provide environment details. Provide your operating system, browser(s), jQuery version, Bootstrap version, and bootstrap-select version.

Create an isolated and reproducible test case. Create a reduced test case.

Include a live example. Make use of jsFiddle or jsBin to share your isolated test cases.


[BUG] setup.cfg + pyproject.toml + setup.py (with PBR) breaking.

setuptools version
setuptools==64.0.0
Python version
Python 3.8.5
OS
macOS
Additional environment information
No response
Description
Reported originally in #3498. Unsure what is going on, but after the latest setuptools the following is thrown when using editable installs:
      distutils.errors.DistutilsSetupError: Error: setup script specifies an absolute path:

          /var/folders/r7/ggtlz3qs465bzrr2zjtf1h380000gp/T/tmpbr2b9x3w.build-temp/test.egg-info/SOURCES.txt

      setup() arguments must *always* be /-separated paths relative to the
      setup.py directory, *never* absolute paths.

      error: Support for editable installs via PEP 660 was recently introduced
      in `setuptools`. If you are seeing this error, please report to:

      https://github.com/pypa/setuptools/issues

      Meanwhile you can try the legacy behavior by setting an
      environment variable and trying to install again:

      SETUPTOOLS_ENABLE_FEATURES="legacy-editable"
      [end of output]

Expected behavior
No error should be thrown, and the package should be installed.
How to Reproduce
Here is a reproducible repo: https://github.com/synchronizing/setuptools-error
Running pip install -e . inside the folder will cause the error seen above. A few points:

SETUPTOOLS_ENABLE_FEATURES flag fixes the issue.
Installing it without being editable (pip install .) fixes the issue.
Removing pyproject.toml fixes the issue.
Removing pbr fixes the issue.
Removing the other folder fixes the issue.

Output
See above.

Thank you very much for reporting this and for the reproducer.
I will investigate the issue and try to get back to you as soon as I can.

An interesting find. On the repo linked above, I added the following Dockerfile:
FROM python:3.8

RUN pip install --upgrade setuptools

WORKDIR /opt/
COPY . test
WORKDIR /opt/test
RUN pip install -e .

CMD ["/bin/bash"]

The above errors out with the same issue noted. Changing version to 3.8.5 fixes the problem.

I added Dockerfile and docker-compose.yml to the repo linked. Doing docker-compose up should result in the issue noted.

I also can reproduce the error in my machine with Python 3.8.10

3.8.10 seems to be working with the Dockerfile above, weirdly enough.

It's dependent on the release, and which Python package is getting pulled based on the tag. Using Github Actions with the matrix functionality fails on all versions: https://github.com/synchronizing/setuptools-error/actions/runs/2841720491

Thank you very much for helping to investigate that. I really appreciate all the effort.

Of course. Version 3.6.x works due to it being tied to setuptools 59.6.0.
See: https://github.com/synchronizing/setuptools-error/actions/runs/2841783973

Felipe, please let me know if v64.0.1 works for you, otherwise we can re-open this issue.

Yup, fixed! Thank you. https://github.com/synchronizing/setuptools-error/actions/runs/2843387978


Revised import statement formatting for better readability: sorted li…

Revised import statement formatting for better readability: sorted libraries by length and edited one extra indentation.

Thanks for the contribution!


Python packaging

Distribute both server and client in a package called forest_lite to distinguish it from forest

Allows python setup.py develop to make forest_lite importable


Searches for OSM (Open Street Map) Packags return "Bad Body"

When searching for osmgpsmap, or any shortened version such as osm, I get a "Bad Body" error with this message:
The Json.Decode.oneOf at json.hits.hits[6]['_source']['package_homepage'] failed in the following 2 ways: (1) Problem with the given value: [ "https://wiki.openstreetmap.org/wiki/osmconvert", "https://wiki.openstreetmap.org/wiki/osmfilter", "https://wiki.openstreetmap.org/wiki/osmupdate" ] Expecting null (2) Problem with the given value: [ "https://wiki.openstreetmap.org/wiki/osmconvert", "https://wiki.openstreetmap.org/wiki/osmfilter", "https://wiki.openstreetmap.org/wiki/osmupdate" ] Expecting a STRING

osmgpsmap is listed as a dependency of the gramps package for genealogy research.

@turboMaCk do you maybe have time to look at this. it looks like package_homepage is not only a string but can be a list of strings. I think we need to update our Page.Packagges.decodeResultItemSource.

I will try to find time over the weekend. I have some issues with backpain for few last days so I'm forbidden to spent more than 8hrs in front of computer per day.
Note: This should be an update in search result type and relevant decoder + fixes related to these changes.

@turboMaCk oh man, take care of your back! this can wait.

Yes, this can certainly wait @turboMaCk !
On Wed, Dec 2, 2020 at 8:56 AM Rok Garbas<EMAIL_ADDRESS>wrote:

@turboMaCk https://github.com/turboMaCk oh man, take care of your back!
this can wait.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixos-search/issues/238#issuecomment-737281296,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGZD7TKIRHO6HTKEDDPI6PLSSZIRBANCNFSM4UFO7HQA
.

--
Charles Suggs
worker-owner, full stack developer @
FullSteam Labs http://fullsteamlabs.com
+1.828.202.5300 <+18282025300>
fax: +1.747.529.9375 <+17475299375>
encrypt: 9A03 4B63 B969 DDD8 CE51 ADDB 7C17 2D8E 6E1C DBEA
https://keys.openpgp.org/search?q=charles%40fullsteamlabs.com
Please direct messages requesting web/tech support to
<EMAIL_ADDRESS>Thanks!
FullSteam Labs will be closed Nov. 26, Nov. 27, Dec. 25, and Jan. 1. If
you anticipate having needs near to those dates please let us know in
advance.
FullSteam Labs stands in solidarity with Black Lives Matter
https://blacklivesmatter.com/, proudly supports Southerners on New Ground
https://southernersonnewground.org/, and endorses the Energy Innovation
and Carbon Dividend Act https://energyinnovationact.org/ (H.R. 763).

Sorry for delays. These health issues caught me completely off guard messing all my plans. Luckily it turned out not to be chronic and I feel completely fine again. Thanks for the report and patience @charlesfsl. https://github.com/NixOS/nixos-search/pull/255 should fix the issue.


Add attr for not saving state.

Saving state sometimes caused android.os.TransactionTooLargeException.
If users do not require state saving it can be turned off.

I can confirm the crash is coming from inside Signature.java$onSaveInstanceState() method.
I attached a debugger in there and set bundle as null at the end the crash didn't happen.
Preserving the state is important but I think @gcacace should come up with a better way to save bitmap into state.


rm() fails if given a pathlib.Path parameter

I'm running:
path = pathlib.Path("cian-parse.appspot.com/perscache_test_cache")
self.fs.rm(path)

where self.fs is a GCSFileSystem object.

The docstring does say that the input should be a string. Path objects are designed for the local filesystem only; if you want to use pathlib-like semantics for remote storage, you might want to use https://github.com/fsspec/universal_pathlib , which is a layer over fsspec.

The docstring does say that the input should be a string.

You are right. Although the signature of the function says path: Any.
Anyway, the acceptance of Path objects is inconsistent. Most of the methods of GCSFileSystem accept it, but rm hiccups. Although better consistency would not hurt, this is indeed just a minor inconvenience.

My bad -- I relied on what IDE told me :)

I suppose you could make the change, which would presumably be in fsspec, not here.


IOOverrides getCurrentDirectory not respected for multiple File operations.

Version: Latest master (3.1.0-edge.862c22d42cb8ed4a67225979bbe7672ba9082d88)
Repro program:
import 'dart:io';

void main() async {
  final tmpDir = Directory.systemTemp.createTempSync();
  await IOOverrides.runZoned(
    () async {
      var file = File('cool.txt');
      file.writeAsStringSync('hello!'); // Does not write to the tmp dir - writes to your current working dir
      print(file.existsSync()); // true
      print(file.absolute.existsSync()); // false

      file = File(Directory.current.uri.resolve('cool.txt').path);
      file.writeAsStringSync('world!');
      print(file.existsSync()); // true
      print(file.absolute.existsSync()); // true
    },
    getCurrentDirectory: () => tmpDir,
  );
}

What is happening here is that for files with a relative path, the existsSync and writeAsStringSync methods are not respecting the current directory change from IOOverrides ~(and they used to previously, fwiw)~. Possibly this is just an issue with the File constructor itself, where when given a relative path it doesn't respect the IOOverrides, but I am not sure at which point we actually do things.
However, .absolute is respecting the IOOverrides. So as soon as you create the absolute path version the File no longer points to the same file.

I wonder if this is related to https://github.com/dart-lang/sdk/commit/066106d19a3d3cd1146da030c79d4a7ed7c0cc7e ? cc @lrhn

Actually - I tried my exact repro on the Dev channel, and it does appear to have the same behavior as master - so this may not be a new thing.
Our test got broken because it uses p.absolute which uses Uri.base which started doing the "right" thing. But since File doesn't also do the same, our test is failing now. The test has always been broken though - it was never writing things to the temp dir like it though it was, it was actually always writing files to the current dir.

I am not exactly sure what all the intended behavior is here, but I would definitely expect that calling .absolute on a File should always point at the same file as the original - at least if I haven't changed the current working dir.


Option to add messages only to template ARB file

Option to add new messages only to template file would be great. Currently new messages are added to all ARB files which makes it hard to tell that they still require translation. This is especially a problem when using arb_translate for automatic translation.
I can make a PR with this feature when I have some free time.

Hi @RobertOdrowaz,
Thanks for issue.
You want
app_en.arb
{
  "@@locale": "en",
  "helloWorld": "Hello World"
}

app_es.arb
{
  "@@locale": "es",
  "helloWorld": ""
}

or
app_en.arb
{
  "@@locale": "en",
  "helloWorld": "Hello World"
}

app_es.arb
{
  "@@locale": "es"
}

I would prefer the second option without the entry at all. This way arb_trnaslate would work correctly and l10n-gen would also correctly warn about missing translations. But I think there can be three options available:

Add in template language
Add empty
Don't add

Okay for an enumeration, but for the moment we only manage:
Add
Don't add

The feature is present in version 3.2.0

@lsaudon Thanks a lot! I got back to this issue for a different reason (unrelated to arb_translate) so I'm very glad it has been resolved


Improve the UI of Ovulation and Menstrual cycle page

I want to work on this issue under JWOC (phase 2)

I want to work on this issue under JWOC (phase 2)

what are the changes u want to make

I want to change some text alignments, colours and padding margin etc to
make it attractive.
On Fri, 10 Mar, 2023, 10:39 am Nisha Yadav, @.***>
wrote:

I want to work on this issue under JWOC (phase 2)
what are the changes u want to make
—
Reply to this email directly, view it on GitHub
https://github.com/nisha331/flow_cycle1/issues/95#issuecomment-1463283538,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2YSDDDNXGCSNQCDI5DFJMDW3KZP5ANCNFSM6AAAAAAVUEMFAE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Polyline cross Greenwich

Hi!
When i try to make polyline that cross Greenwich (longitude 180) i see this bug on map:
https://gyazo.com/6063e8ad7aca42007d074ddbee47ad32
It's because in response from server-side i have negative and positive latitude values
(example:
first point: -179.99937449989375,
next point:<PHONE_NUMBER>0001738
So i try to convert negative values to positive:
if(point.lon < 0){
    point.lon = 360 + point.lon;
}
var pointLatLng = new L.LatLng(point.lat, point.lon);

But in this case i see:
https://gyazo.com/95bbafc7e52fc9355f997bddf9cf3ef4
Left point has longitude 0
In response frome server where is no points with longitude 180 or 0
And sometimes there is no this bug and track is correct with same server response.
I really can't find bug in my code and think that it is Leaflet bug...
P.S.:
Sorry for my English =)

It's a known issue (#1293, #2645), so I'll just close this as duplicate.
And you don't mean "greenwhich" (which is a place near London), you mean the antimeridian.
A workaround is to split your polylines at the antimeridian. Read this: http://blog.cartodb.com/jets-and-datelines/


Webdriver update

@mfazekas thanks for keeping an eye on this! I caught this too before shipping the update to docs, and added a return here and before the finalize call (but snuck it in on master branch after merging this).


Where did docs on counters go?

This doc says
> For more information about counters and other expressions, see expressions
But the 'expressions' page says nothing about counters.
There used to be a section about counters (see https://github.com/MicrosoftDocs/vsts-docs/blob/68a6952c8bc0f647648b217d5c0d49e24ebd121d/docs/pipelines/process/variables.md#counters). This was removed in https://github.com/MicrosoftDocs/vsts-docs/commit/0b64c24e4f3f6c98bfc782b534bce2cfbe9c8798 by @vijaymatest1. Was this intentional?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd7e0bd3-1f7d-d7b6-cc72-5ef63c31b46a
Version Independent ID: dae87abd-b73d-9120-bcdb-6097d4b40f2a
Content: Variables - Azure Pipelines
Content Source: docs/pipelines/process/variables.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Please stay tuned for an update on the expressions doc. That will roll out later this week.

I'm also interested in the counter documentation. Thank you @natemcmaster for pointing me in the right direction.

Thank you for reporting this issue. I believe it's been fixed: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/expressions?view=azure-devops#counter


Initial Commit of FEAT FindUnusedStepDefinitionsCommand.

This commit duplicates code from FindStepDefinitionUsageCommand. Not tested.
This is a preliminary PR to track the POC for adding a feature to the Reqnroll.VisualStudio extension that provides a context menu command that will find all StepDefinitions in the current project that are not bound to a feature file Step.

[ ] Bug fix (non-breaking change which fixes an issue).
[X] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Performance improvement
[ ] Refactoring (so no functional change)
[ ] Other (docs, build config, etc)

Checklist:

[ ] I've added tests for my code. (most of the time mandatory)
[ ] I have added an entry to the changelog. (mandatory)
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Pardon my ignorance of VS Extensions... I have this new command running in Unit tests. But I can't figure out how to launch a second instance of VS that would use my version fo the extension so that it can be tested via the UI. What's the procedure?

Trying things out in VS:

You need to enable "Visual Studio Extension Development" in VS installer

This will add a separate registry hive for Visual Studio that you can use for testing, so that you can separately add/remove extensions to that without affecting your main VS. This is called the "Ext" hive. The ext hive can be run from a dev console with devenv /rootSuffix Exp, but the VS installer also adds a new command to the start menu called "Start Experimental Instance of Visual Studio 2022" (I usually pin that to the start menu somewhere).
Every time you build the VS extension in Visual Studio, the build will install the just-compiled package into the ext hive. So if you open the ext hive version of VS, you will be able to use the latest version of your extension.
Once the exp hive is running, you can attach to that "devenv" process from your main VS and you can also debug.
You can even "run" the package project (F5), in that case VS will automatically start the exp hive with the debugger attached (and your extension will be loaded of course). I normally does not use that, but run my exp hive manually and attach to it later because otherwise you need to wait for a long time until the VS exp hive boots up with the debugger attached.

Comments on the code:

In order to make the actual command visible (for example in the context menu), you need to register it in the ReqnrollVsPackage.vsct file. It's an XML file. You can see my commit about the "go to hook" command about what changes are needed.

The unit tests are good, but usually the most help you get is from the Reqnroll tests. Take a look at the scenarios in the FindStepDefinitionUsagesCommand.feature (and the other editor command features) to get an inspiration.

I think otherwise you seem to go to the right direction. At the end we don't have to collect the step definitions and make a temporary binding registry, like you do here, but you can simply access the latest binding registry with var bindingRegistry = _discoveryService.BindingRegistryCache.Value;, like we do at the syntax coloring here

I suspect it will report multiple "unused" for a single Step method for each Given/When/Then Attribute applied to that Method (when those attributes don't match with feature steps). These should probably be deduplicated.

The ProjectStepDefinitionBinding.Implementation gives you a ProjectBindingImplementation object that is unique within a binding registry, so you can use that for deduplication.
It is an interesting question though what the expected behavior is for this two key cases:
Case 1
[When("X")] // unused
[Given("Y")] // unused
public void WhenX() {}

Shall we list WhenX twice (as an unused Given and an unused When) or only once?
Case 2
[When("X")] // used
[Given("Y")] // unused
public void WhenX() {}

Shall we list WhenX as unused? Because the method itself is used (as When) but not used as Given.

I like the concept of "draft pull requests" quite much - they give you early indication of the integration without looking to be "ready"

@clrudolphi could you please do a dummy push to this to see if the CI works better now with external PRs?

yes
(or you can just change a dummy line and push)

yes (or you can just change a dummy line and push)

Executed.

In order to make the actual command visible (for example in the context menu), you need to register it in the ReqnrollVsPackage.vsct file. It's an XML file. You can see my commit about the "go to hook" command about what changes are needed.

I see in the vsct file that keyboard shortcuts are defined for each menu command. Should one be defined for this new command, and what should the keybinding be?

@gasparnagy Thanks for the help so far. I have this wired in and working.  Here is an update on status:
First, an observation: when a Reqnroll solution is first loaded, the context menu items for 'Find Step Definition Usages' and this new one 'Find Unused Step Definitions' fail. The output shows:

Info: OnActivityStarted: Starting Visual Studio Extension...
Info: CreateProjectScope: Initializing project: ReqnrollExampleProject
Info: OnSettingsInitialized: Project settings initialized: .NETCoreApp,Version=v8.0,Reqnroll:1.0.0
Warning: GetStepDefinitionsAsync: Unable to get step definitions from project 'ReqnrollExampleProject', usages will not be found for this project.
Info: FindUsagesInProjectsAsync: Found 0 usages in 0 feature files

Subsequent invocations do work properly. Am I doing anything incorrectly or is this known/expected behavior?
Secondly, I need some guidance on what we want to be displayed in the dynamically built result list in the context menu. Taking a cue from the 'Find Step Definition Usages' command, I have it currently set up to show the Location and Method. For a step definition like this:
[Given("this isnt used anywhere")]
[When("a second unused binding")]
public void ThisIsntUsed()
{ throw new PendingStepException(); }
The context menu is populated with this info:

Per our previous dialog, it may be more helpful to include both the methodName and the RnR Attribute in that message. What are your thoughts?
My next step is to create Specs to further test this.

First, an observation: when a Reqnroll solution is first loaded, the context menu items for 'Find Step Definition Usages' and this new one 'Find Unused Step Definitions' fail.

I have also observed this, but haven't got time to debug it yet (it is since a last change and somehow related to the async handling, I think). Feel free to ignore it for now.

Per our previous dialog, it may be more helpful to include both the methodName and the RnR Attribute in that message. What are your thoughts?

This is a good question. So basically we have the following information that might be relevant:

file name & line no
class & method name
attribute type (G/W/T)
attribute parameter

For the most of the cases, the unused method will not have multiple attribute, so IMHO we should find a solution that is somewhat optimized for that, but it also works for the multi-attribute model as well.
Maybe:
StepDefinitions\CalculatorStepdefinitions(47,9): [Given("this isnt used anywhere")]

or
StepDefinitions\CalculatorStepdefinitions(47,9): [Given("this isnt used anywhere")] CalculatorStepdefinitions.ThisIsntUsed()

but this is probably too long (would need to check how it looks).
(We can consider to add G/W/T as icon in addition to that, but I'm not sure.)

Technical side-note: in the PRs it is better not to rewrite the commits (amend/force push), so that reviewers can better see what has been reviewed and what has changed since. At the end we will anyway squash the changes, so the individual commits will not be relevant.

And BTW: it is fantastic that two days after someone bought up an idea, we have a working solution. Congrats!

Technical side-note: in the PRs it is better not to rewrite the commits (amend/force push), so that reviewers can better see what has been reviewed and what has changed since. At the end we will anyway squash the changes, so the individual commits will not be relevant.

Sorry about that. My git setup has something weird about it. Sometimes when I go to Push, git thinks that I have conflicting commits from Origin even though I was the last one to commit and push. Perhaps it's me doing something wrong with my manner of using git (sometimes from the command line, sometimes from within VS, sometimes by using GH Desktop).
In this situation, I knew that the last commit was mine (the dummy commit we did earlier today) and so a force push was simpler for me than trying to figure out what it thought was wrong.

Do we have available a large RnR project that this could be tested on? I'm curious about the performance and how long the user will have to wait for the context menu to be populated with the results. Since this is a result of a bunch of set subtraction operations we don't have a convenient means of progressively populating the result. On large solutions, this command might take a while.
Perhaps this whole thing should really be a batch operation (command line) and expect users to run this as part of their CI?

With this command line tool, you can generate a big sample project. https://github.com/reqnroll/Reqnroll.VisualStudio/tree/main/Tests/Reqnroll.SampleProjectGenerator
I think for many users, the version integrated to vs is beneficial. Having it as a ci option might also make sense, but that is another story - we don't really have infrastructure for that yet.

Most of the users have <500 scenarios per project.

Maybe:
StepDefinitions\CalculatorStepdefinitions(47,9): [Given("this isnt used anywhere")]

or
StepDefinitions\CalculatorStepdefinitions(47,9): [Given("this isnt used anywhere")] CalculatorStepdefinitions.ThisIsntUsed()

IIRC, you mentioned earlier that the expression in the StepDefinitionBinding was, in the case of Cucumber expressions, a Regex created by transforming the Cucumber expr into a Regex. Would displaying the regex in that situation be confusing for the user (as it doesn't match their own code)?

There are two properties on the loaded step deft: the calculated regex and the original expression that the user entered.

There are two properties on the loaded step deft: the calculated regex and the original expression that the user entered.

OK. It looks like if I use stepDefinition.Expression then I should be safe.

Yes. I think this is it: https://github.com/reqnroll/Reqnroll.VisualStudio/blob/main/Reqnroll.VisualStudio/Discovery/ProjectStepDefinitionBinding.cs#L20

Current UI:

Looks good! I like it!

Pushed another commit. This includes testing via Specs. Fixed up unit tests (such as they are).
I tested this with an external assembly and it worked fine.
What other refactoring/clean-up would you like to see?

@gasparnagy thanks for the extensive feedback. I will get to work on those items.
I have completed an attempt at using the SampleProjectGenerator; and now I suspect we have a bug to find somewhere.
I generated a sample project with 50 feature files and 10 scenarios per file. The rest of the options were defaults. That gave a project with 235 Step definition classes and 1400 Step Definition methods. Ridiculously large, yes, but my intent was to determine the processing rate.
The command hung the UI thread for several minutes (I'll rerun it later to get a specific time).
When it did return, the output window showed this:

Found 67648 unused step definitions in 50 feature files

That number can't possibly be correct; remember there were only 1,400 step definitions in the project.
You might be able to help me by explaining how the generator works - how many step definitions should be expected to match with scenario steps? In a spot check, I see some that do and some that don't. If the generator is deterministic, I might be able to determine which types of step defs won't match and would then look at the logic of the command for bugs related to those types of step defs.

@clrudolphi Ah. These are good questions. I haven't checked the generator for some years, so I don't really remember. One thing is for sure that it is deterministic. I will refresh my memories next week and give some hints.
For the size: The 235 step definition classes and 1400 step definition methods look too much. I have no idea why it generated that many for 50 feature files. I will check. Whatever we measure, we should also compare with other features, like the "find step definition usages". If that one also hangs, the issue is not with your code (or maybe we need to include a few "yield" calls to give a chance for the UI to refresh).

Refactored per your review suggestions. Open issues are:

Perf
Messaging on the UI when no Unused StepDefs found - per project or solution?

Whatever we measure, we should also compare with other features, like the "find step definition usages".

The "Find step definition usages" operates quickly without hanging.
But let's acknowledge that the amount of work done by these two commands is not comparable. Find SD Usages starts from a single StepDef method and has to scan for matches against the 500 scenarios. The FindUnusedSD command does that work for ALL step definition methods (1x vs 1400x).
I will look into the idea of incrementally yielding context menu items.

Found a bug that may explain the weird results seen in the perf test. For each Project/FeatureFile, the algo subtracts those step defs that are matched and creates a set of "unused" from the remaining. The problem is that the set of step defs spans the entire solution, so stepDefs that don't match for a given feature file are reported as "unused" even when they might match a different feature file. Each stepDef is getting found as "unused" multiple times, at least as many as the number of featureFiles minus 1.
I'll look for ways to address this in the coming days.

Found a bug that may explain the weird results seen in the perf test.

I think I have this fixed.
17:45:07:301	Info: FindUnusedStepDefinitionsInProjectsAsync: Found 282 unused step definitions in 1 Projects
Instead of the 67K unused step definitions found in this morning's test, the function is now reporting 282, which seems more reasonable. To examine the 1400 step definitions and report back the 282 found as unused took only about 2 seconds. Pushing code changes shortly.

I think I have this fixed.

Nice! This is yet another good example of the importance of exploratory testing. We did specs, we did unit tests, we did review - these are good, but they all driven by our own thinking, so they cannot detect such out of the box problems. It's good that you went after the strange perf test results!

I have checked it and indeed now it finds the unused step definitions from all, but in my opinion it is not convenient this way (I tested it in a real project and it found some totally unimportant unused one in an included sample).
The reason that it works this way is because you ask for the binding registry from the projects of the feature files here. If you would move up this call, and would only get the binding registry from the project of the editor in here (and pass down the binding registry) then it would only show the ones from the editor, I think.

I have checked it and indeed now it finds the unused step definitions from all, but in my opinion it is not convenient this way (I tested it in a real project and it found some totally unimportant unused one in an included sample). But I'm not 100% sure.
The reason that it works this way is because you ask for the binding registry from the projects of the feature files here. If you would move up this call, and would only get the binding registry from the project of the editor in here (and pass down the binding registry) then it would only show the ones from the editor, I think.

I've tried that, but it resulted in a bug of duplicate and erroneous findings. The reason was because the list of projects is being enumerated in PreExec resulting in all feature files (and scenarios) for all projects in the solution. When the StepDefs for the current project are compared against that list of scenario steps, the results are incorrect as the SDs are not matching against scenarios from other projects.
Instead, the approach I took was to eliminate the enumeration of all project files, but simply used the current Project as the source of both SDs (via the Binding Registry) and scenarios (via the feature file loading and parsing done in FindUnused and FindUsagesFromContent).
Changes made in this commit

Updated the original PR form to reflect that Tests are now included.
Still need to update Documentation and to update the Change Log.
Before those get done, is there anything else code-wise or logic yet to do?

Instead, the approach I took was to eliminate the enumeration of all project files, but simply used the current Project as the source of both SDs (via the Binding Registry) and scenarios (via the feature file loading and parsing done in FindUnused and FindUsagesFromContent).

I think I have confused you now (sorry) and I don't know what is the best option. Let me explain the complexity that causes the problem, because this is going to be useful info anyway.
In the majority of the cases, the step definitions are in the same project as the feature files, but this is not always like that. You can include step definitions of another project as well with the Bindings from External Assemblies feature. You can include bindings from other projects that also have feature files (the projects that have feature files are called the ReqnrollTestProjects) or you can include bindings from projects that are just used to implement shared step definitions (these are called ReqnrollProjects). These ReqnrollProjects that are not ReqnrollTestProjects cannot have a reqnroll.json config file, so they are not "standalone".
Actually you can only get the binding registry of ReqnrollTestProjects. The binding registry of these projects will contain the step definitions of the project itself and also the step definitions of the used external step definitions as well.
Technically you can probably get the binding registry of a ReqnrollProject that is not a ReqnrollTestProjects as well, but that is not really a valid operation (they might be dependent on some plugins or config settings that is only available in ReqnrollTestProjects).
This altogether means that if we would like to list all step definitions in the current project that are unused, we cannot get the editor's binding registry as I suggested earlier, because that might be just a normal ReqnrollProject (without feature files), but we would need to enumerate all ReqnrollTestProjects that "use" the current project as an external binding source, get the unused step definitions of them and filter out these unused step definitions to show only the ones from the current project. Pretty complicated. (I think there is no function to list ReqnrollTestProjects that "use" the current project, but of course we could just list all of them the filtering will anyway ignore all their unused step definitions if they don't "use" the current project.)
I'm not sure that we want this.
The alternative is to revert the last change and rater implement this feature in a way that it finds all step definitions from all projects (as you did it anyway). The most of the users have anyway only one Reqnroll project, and we can still change this feature later to filter for the current project's step definitions if we will see big problems with this approach.
Sorry again for misleading you...

Still need to update Documentation and to update the Change Log.

We don't yet have a documentation of the VS integration, so you cannot extend that (OK for now), but please add a line to the change log. I don't see anything else to be done. (Except solving the confusion that I caused as described above.)

I'd like to ensure I correctly understand the nuances of what you've explained and ultimately the requirements for this feature.
Please review the following and correct it/add to it so that we have a well thought out statement of our objectives/requirements.
Feature: Reqnroll StepDefinition Finding

Scenario Outline: ReqnRoll Finds Unused Step Definitions
	Given a project of <type> that has <features> features and <stepDefs> step definitions
	And a sibling project of <siblingProjectType> with <siblingFeatures> and <siblingStepDefs> step definitions
	When the Find Unused Step Definitions command is executed in the <project>
	Then the command will report back unused Step Definitions from <scope> project(s)

Examples:
	| type           | features | stepDefs | siblingProjectType | siblingFeatures | siblingStepDefs | project | scope   | comment                                                    |
	| RnrTestProject | some     | some     | none               | none            | none            | main    | main    |                                                            |
	| RnrTestProject | some     | some     | RnRTestProject     | some            | some            | main    | main    |                                                            |
	| RnrTestProject | some     | some     | RnRTestProject     | some            | some            | sibling | sibling |                                                            |
	| RnrTestProject | some     | some     | ExternalAssembly   | none            | some            | main    | both    |                                                            |
	| RnrTestProject | some     | some     | RnRProject         | none            | some            | main    | main    |                                                            |
	| RnrTestProject | some     | some     | RnRProject         | none            | some            | sibling | sibling |                                                            |
	| RnRProject     | none     | some     | RnRTestProject     | some            | some            | main    | main    | mirror of line above; really restating the same thing      |
	| RnrTestProject | some     | none     | none               | none            | none            | main    | invalid | the FUSD command can only be executed from a binding class |

Essentially your understanding is correct, my thoughts on the expected result only differs in the "ExternalAssembly" case, but that is something we haven't discussed anyway and the difference is not important.
I have tried to rephrase the specs in a way that it is better fitting to my way of thinking. Instead of using the "sibling" term I simply used project "A" and "B" and added an extra condition whether the B is listed as additional binding assembly for A or not. This is what I got. As I said at the end the result is the same, the only diff is marked with (*) .
Feature: Reqnroll StepDefinition Finding

Scenario Outline: ReqnRoll Finds Unused Step Definitions
	Given a project A of <typeA> that has <featuresA> features and <stepDefsA> step definitions
	And a project B of <typeB> with <featuresB> and <stepDefsB> step definitions
	And project B is <B listed as bindigns of A> as binding assembly of A
	When the Find Unused Step Definitions command is executed in the <project>
	Then the command will report back unused Step Definitions from <scope> project(s)

Examples:
	| description                                                  | typeA   | featuresA | stepDefsA | typeB   | featuresB | stepDefsB | B listed as bindigns of A | project | scope         | comment                                                                                |
	| single RnR Test project                                      | Project | some      | some      | none    | none      | none      | not listed                | A       | A             |                                                                                |
	| two independent RnR Test project                             | Project | some      | some      | Project | some      | some      | not listed                | A       | A             |                                                                                |
	| two independent RnR Test project, invoked from B             | Project | some      | some      | Project | some      | some      | not listed                | B       | B             | same case as 'two independent RnR Test project'                                                                  |
	| RnR Test project uses bindings from a DLL                    | Project | some      | some      | DLL     | none      | some      | listed                    | A       | A (*)         | the unused step defs of the external DLL are not managed in this solution, but in the one where it is maintained |
	| RnR Test project uses bindings from a shared library project | Project | some      | some      | Project | none      | some      | listed                    | A       | A             |                                                                                |
	| feature invoked from a shared binding library project        | Project | some      | some      | Project | none      | some      | listed                    | B       | B             |                                                                                |
	| feature invoked from a shared binding library project 2      | Project | none      | some      | Project | some      | some      | listed                    | A       | A             | mirror of line above; really restating the same thing                                                            |
	| single RnR Test project, without any bindings                | Project | some      | none      | none    | none      | none      | not listed                | A       | not available | the FUSD command can only be executed from a binding class                                                       |

I've modified the Command to limit the set of UnUsed SDs to those within the current project. In doing so, I made a change to VsProjectScope.GetProjectFiles(string extension). While that method would take any string as an extension, it did not use it and instead was only returning feature files. I modified it such that it used the extension in the filtering process it ran. Let me know if that change is too intrusive or risky.
I am a noob with git and not quite sure how to proceed here. I've sync'd my fork on GH to bring in the other changes that have been merged, and pulled them down to my machine. I then rebased these changes on top of main. My GH Desktop app is now reporting that my branch has 11 commits to push (6 from this work, the two fixes I did for GH6 and GH7 and 4 from you - work that you did on CI. That doesn't sound right and fear I've messed up my local git repo. I haven't yet pushed anything to GH for fear of screwing it up.
Any suggestions on how to proceed? I am guessing that a squash is needed. Should I have done that before rebasing?
Should I delete my local git repo and pull it back down fresh from GH?

I've modified the Command to limit the set of UnUsed SDs to those within the current project. In doing so, I made a change to VsProjectScope.GetProjectFiles(string extension).

Good idea! I like it.

[...] that is a merge commit ("Merge branch 'reqnroll:main' into RNR70_UnusedStepDefinitions {the branch name}). that merge commit seems suspicious to me too. What did I do wrong?

Nothing. This is good. When GH runs the PR checks, it automatically tries to merge your changes to the reqnroll:main and runs the tests on the merged result. So basically it checks the "merge compatibility" or "integration". If this succeeds, there is nothing else to do.
In some cases your changes cannot be merged with the reqnroll:main because there has been changes there that are not compatible. This happens for example when you add a new line to the changelog while others have also added some, so git cannot decide which line should go first. In this cases, you need to "resolve the conflict" on the PR. This can be done in multiple ways. It could be done by rebasing the entire PR to reqnroll:main and force push, but it is not practical if people have done reviews (as we discussed earlier). The better option is to simply merge the reqnroll:main into your PR branch. (This might look ugly, because all the changes others have done will appear in this PR, but don't worry GH and git knows that those are not belong to this PR.) This is exactly what you did, so all ok.
You do not need to do squashing, this will be done by GH once I "merge" the PR.
Now as you are part of the core-team, it will be a bit easier, because you don't need to use & sync your own fork, you can work on the main repo directly: in the cloned main repo, just create a new branch and push it - on the GH Reqnroll project page it will ask you to make that a PR.
Side note: As you work with "draft" PRs now, at the point where you think the PR is OK from your point of view, you can click on the "Ready for review" button. This is just an signal for the potential reviewers, does not really change anything. (I did that now.)


[GLUTEN-1632][CH]Daily Update Clickhouse Version (20230925)

Auto commit by gluten daily build, please check the build status and merge it if it's green.

We need merge due to https://github.com/ClickHouse/ClickHouse/pull/54664, let's run performance test.

let's defer to 0926


Error: 'v' of type '^Range_Stmt' has no field 'reverse'

I get the following error when installing ols in windows:
./build.bat
ols/src/odin/printer/visit.odin(1312:6) Error: 'v' of type '^Range_Stmt' has no field 'reverse'
if v.reverse {

You are using an old version of Odin. This project is currently built to work with the latest master of Odin.


More efficient computation in MomentsMonoid

I was staring at this code and noticed that we could make it faster by avoiding a few divisions. So here we go!
Also, I wasn't sure where to put this, but this - and the mutable equivalent - are going to be faster than the provided Aggregator in the case of a scan. Any interest?
  def plusDouble(a: Moments, b: Double): Moments = {
    val countCombined = a.m0D + 1
    val delta = b - a.mean
    val delta_n = delta / countCombined
    val delta_n2 = delta_n * delta_n
    val term1 = delta * delta_n * a.m0D
    val meanCombined = Moments.getCombinedMeanDouble(a.m0D, a.mean, 1.0, b)

    // writing them in reverse order like this will be useful in the mutable case, but doesn't matter here.
    val m4 = a.m4 + term1 * delta_n2 * (n * n - 3 * n + 3) + 6 * delta_n2 * a.m2 - 4 * delta_n * a.m3
    val m3 = a.m3 + term1 * delta_n * (n - 2) - 3 * delta_n * a.m2
    val m2 = a.m2 + term1

    new Moments(countCombined, meanCombined, m2, m3, m4)
  }

As for the plusDouble I think a mutable Fold is the right way to do that since you can can allocate some mutable state to hold your variables class MutMoments { var count: Double , ... } then implement your plusMoments function there.
that way, you wouldn't allocate on each call, but you would wind up boxing the doubles (since these types are generic) so I don't know if that is going to kill the win (since boxing into a Moments is maybe almost as cheap).
But you could also add plusDouble to Moments and just add a law that m.plusDouble(x) == m.plus(Moments(x)).
That said, you would have to allocate a new Moments on each return anyway... Seems to me maybe the real win would be maybe making a MomentsState class that is mutable, and you could add a Moments into it, or a Double, and the only thing you can do with a MomentsState is convert to Moments (or from Moments).
so, something like:
final class MomentsState {
  // has private vars that keep track of the moments
  // we can then use this state in sumOption or in a mutable Fold.
  def +(m: Moments): this.type
  def +(d: Double): this.type

  def toMoments: Moments
  def resetFromMoments(m: Moments): this.type
}

object MomentsState {
  def newEmpty: MomentsState
}

Done in #1050


Parsing: don't require "intent" in resources.

Current dependencies on/for this PR:

main

PR #939   👈

This comment was auto-generated by Graphite.


Reworking file and directory ownership

Playbook level becomes are not a good idea. We should only give the minimum set of permissions possible rather than all at once.
I'm going to test how the deployment behaves once I disable these and progressively add becomes to tasks in roles. Eventually I aim to arrive at minimum viable number of tasks with root access.
Fixes: https://issues.redhat.com/browse/OSPRH-3763

recheck

recheck - no logs retrieved from last test

Test operator error @lpiwowar may have some info.
2024-06-28T17:19:01Z	ERROR	Reconciler error	{"controller": "tempest", "controllerGroup": "test.openstack.org", "controllerKind": "Tempest", "Tempest": {"name":"tempest-tests","namespace":"openstack"}, "namespace": "openstack", "name": "tempest-tests", "reconcileID": "f7298ece-7e09-44de-aa1a-3018c238fcbf", "error": "PersistentVolumeClaim \"tempest-tests-7b115\" not found"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:324
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:265
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:226

recheck

recheck
gateway timeout

lgtm

edpm-ansible-molecule-edpm_libvirt is failing due to unrelated issue addressed in another PR.

/cherry-pick 18.0.0-proposed


mvp

true

This issue used for marketing purposes, see https://gist.github.com/brianzelip/34c7ae7fae90122c45d624fb20aa670b.


UserToken flow not exposed in BotFrameworkAdapter

Is your feature request related to a problem? Please describe.
The BotFrameworkAdapter is missing some methods of the C# version, including the ones to get the User's Tokens.
Describe the solution you'd like
The logic to retrieve these tokens is already present in botframework-connector, and it should be used in a method inside the BotFrameworkAdapter just like the C# version does.
Describe alternatives you've considered
-
Additional context
-
[enhancement]

PR has been merged. Closing Issue.