Feature Deprecation Summary

As of today, we haven't deprecated a lot of features but when we do, this can cause breaking issues if customers are not aware of them when they do an upgrade.  Deprecation is usually mentioned in the release notes or on the page where the feature is documented.  At some point, it may be worthwhile to list this items in a summary page for items that have been deprecated, or will be.  This is not a high priority, but could be useful in time as we have more customers and more deprecating features.  Additionally, explaining our deprecation policy would give customers a piece of mind the amount of runway they have to move off of those features.

Thanks, @chriscasano.
@nstewart, @isaactwong, this ties into a much broader need to document our overall API policy: What interfaces are stable and "programmable"? What guarantees do we make around those in terms of deprecation, backward-incompatibility, and communication approach? Thinking around this work started some quarters ago but never progressed to completion, and I'm not sure where we stand now.
Nate, Isaac, I'd love to know who in Product and Eng should take this on, with Docs support. I think we need to make this happen within the next few quarters. Raphael was involved at one point, but I'm not sure who should be leading this now.


Implement private repository limits

Since @kasbah does not appear to have time to continue his work on PR #6184 I started looking at continuing his work. As there have been many changes to master since, I felt it was easier to start fresh.
Fixes #3653. Feedback very much appreciated.

[x] Adjust User model
[x] Adjust repo model
[x] Check fields when creating repositories
[x] Add locale entries
[x] Add setting to admin interfaces
[x] Adjust TransferOwner counts
[x] Adjust DeleteRepo counts
[x] Adjust checkers
[ ] Add tests
[ ] Check what happens if ownership of a private repositories is transferred to a user at the limit
[ ] Test in a local install

For clarity: what I'm going for here is that the current num_repos / max_repo_creation stuff is equal to the public number of repos. For private repos, I'm adding new counts and admin screen entries.

Codecov Report

Merging #12705 into master will increase coverage by 0.00%.
The diff coverage is 14.70%.

@@           Coverage Diff           @@
##           master   #12705   +/-   ##
=======================================
  Coverage   43.29%   43.30%
=======================================
  Files         646      645    -1
  Lines       71592    71586    -6
=======================================
+ Hits        30993    30997    +4
+ Misses      35583    35571   -12
- Partials     5016     5018    +2

Impacted Files
Coverage Δ

models/error.go
34.51% <0.00%> (-0.30%)
:arrow_down:

modules/graceful/server.go
47.00% <0.00%> (-0.41%)
:arrow_down:

modules/highlight/highlight.go
24.69% <0.00%> (ø)

modules/migrations/gitlab.go
1.04% <0.00%> (-0.10%)
:arrow_down:

modules/session/virtual.go
60.20% <0.00%> (ø)

routers/repo/issue.go
37.51% <0.00%> (-0.03%)
:arrow_down:

modules/migrations/base/downloader.go
17.64% <5.12%> (-5.72%)
:arrow_down:

models/repo.go
55.55% <20.00%> (-0.14%)
:arrow_down:

models/user.go
53.26% <33.33%> (-0.49%)
:arrow_down:

modules/migrations/github.go
83.36% <100.00%> (-0.41%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a5e39...0780ff0. Read the comment docs.

just idears: different limits for: forks, public and private repos
-> let's say a user is allowd to have 1 private, 10 public and kan fork as he like ( to contribute to other projects ... )
note: forks can be conferted to normal repos, before this hapen a check has to happen again too ...

just idears: different limits for: forks, public and private repos
-> let's say a user is allowd to have 1 private, 10 public and kan fork as he like ( to contribute to other projects ... )
note: forks can be conferted to normal repos, before this hapen a check has to happen again too ...

For the purposes of this PR, I'm going to limit it to public and private repo counts. A forked repo is also either public or private so it'll count against either the public or the private count.

Right! F-ed this up good. A combination of laptop performance issue, a fault between keyboard and chair as well as a four year old screaming in my ears. :rofl:
I'll close this PR and re-create a new one that's not f-ed up. Sorry about this! :smile:


Identity refactor

Do not merge before #138

Identity Client register method has to also include resources after we removed isLimited flag


CSS @keyframes Best Practice

In src/App.css we have the @keyframes spin rule:
@keyframes spin {
  from { transform: rotate(0deg); }
  to { transform: rotate(360deg); }
}

Wouldn't best to rename spin to App-logo-spin? That way we teach newcomers to avoid "CSS globals" for everything.
I mean, @keyframes spin is a good candidate to be added in many component's CSS file.

👍 want to send a pull request?

@vjeux sure, doing it now.


Reproducibility Discrepancy

I've been trying to reproduce your results on KITTI Raw dataset using the published code and also used the code in here to create the same splits and preprocessing indicated in the paper. I ran an evaluation run using the pretrained weights of KITTI (32 layers) but the following results are the ones I got which don't align with the results of the paper.
[2021-11-10 18:40:17,526 synthesis_task_kitti.py] Evaluation finished, average losses:
[2021-11-10 18:40:17,531 synthesis_task_kitti.py]     val_loss_rgb_src 0.011722 (0.013352)
[2021-11-10 18:40:17,531 synthesis_task_kitti.py]     val_loss_ssim_src 0.018813 (0.022328)
[2021-11-10 18:40:17,531 synthesis_task_kitti.py]     val_loss_rgb_tgt 0.058807 (0.064112)
[2021-11-10 18:40:17,531 synthesis_task_kitti.py]     val_loss_ssim_tgt 0.343890 (0.348406)
[2021-11-10 18:40:17,531 synthesis_task_kitti.py]     val_lpips_tgt 0.214107 (0.253099)
[2021-11-10 18:40:17,531 synthesis_task_kitti.py]     val_psnr_tgt 18.623119 (18.415305)
I've also included attachments of the synthesized target and src images. There could be an issue with the kitti data loader that I created so I can share it with you to point out the issue that's causing the discrepancy. If not, I would appreciate it if you can share with me your KITTI data loader to trace where the error is myself.

Hi, is the problem solved?

Bumping this up, any updates on KITTI reproducibility? @YoussefFathi? Thank you!


Bump to 0.9.17

Signed-off-by: Piotr Gorski<EMAIL_ADDRESS>

The 0.9.17 tag is also updated!


expr: interpret numbers != 0 as true for | and &

So far when using | or & numbers were only interpreted as true if they were 1. This PR changes this behavior, now any number != 0 is interpreted as true.
Fixes https://github.com/uutils/coreutils/issues/5315 and https://github.com/uutils/coreutils/issues/5316

excellent, thanks.
the fuzzer is running a bit longer :)


Event maptypeid_changed

Can you add the possibility to add a listener on the event ''maptypeid_changed"?
The same solution as for a click event: <agm-map (mapClick)="...">

Merged the PR recently. Will be in the next release


rescan not working properly

Currently, (re)import seed doesn't trigger rescan for the whole history.
cmd/dropwtxmgr did not help.

As an optimization, lbcwallet uses "birthday" to mark from which block, instead of the genesis block, it should rescan for the chain for relevant transactions.
Currently, the birthday is hardcoded as time.Now(), which only works for a newly created wallet using a randomly generated seed. For an imported seed, prior transaction history is ignored.


Taiko socialfi

Describe the feature request

Description of the feature request here. A socialfi app that suppports the chain{taiko} and help create equality and chance for people who are looking to create visibility and commjnity for themselves and their project but targeting only users of a particular chain {e.g Fantasy top, farcaster etc}.
Just like every other chain rigth now, it has become a fact that having a socialfi helps to retain users and i feel it should not be overlooked y the taiko team

Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

That is not a feature, but a new app.


[docs] Add, update, and revise marketing pages for all products

Summary 💡
Currently:

mui.com/core and mui.com/x are both outdated
mui.com/material-ui is just a list of components
mui.com/base and mui.com/system don't exist

I think all of these pages are due for updating (or creating). For the individual products, these pages would be the more marketing-oriented counterparts to the "Overview" page that X has (and Base has as a WIP #32310) in the docs.
@danilo-leal I'd love to get your thoughts on the design for these pages. Should we stick with the basic template of the Core and X pages for Base/System/Material UI (and eventually Joy!)? How do we show off Base in particular?
Should the X products get their own individual marketing pages? (e.g. mui.com/x/data-grid) cc: @joserodolfofreitas @flaviendelangle
Would it make more sense for the structure to be like mui.com/material-ui or mui.com/core/material-ui? My gut says the former is better for SEO but I could be persuaded to go either way.
Stuff to do:

[ ] revise copy on mui.com/x
[x] revise copy (and possibly design) on mui.com/core
[ ] revise mui.com/material-ui
[x] create mui.com/base
[ ] create mui.com/system

Should the X products get their own individual marketing pages?

I think it could become interesting later on, when we have a 3rd set of components (Charts ?).
For now, If we are able to restructure mui.com/x to host both the datagrid and the pickers, I think it's better.
Especially if we improve our X overview pages and if we create new marketing pages for advanced examples (like discussed a few weeks ago).
A few things I think we could improve on mui.com/x :

A new section concerning the Date Range Picker (similar to Data Grid - A level of performance and quality that hasn't been seen before)

A better feature list for the Data Grid in Data Grid - A level of performance and quality that hasn't been seen before, for instance the editing do not use the new editing API and we could probably a "Grouping"

A more advanced custom theme in Theming - Advanced and beautiful (which is also related only to the datagrid, the whole structure of the page should be improved with the arrival of the pickers), maybe we will soon be able to do a POC with Joy for instance.

The Roadmap is outdated (these hardcoded values are really problematic if we want to avoid outdated info, Grouping is released for instance)

The Tree View might be released but it is not part of X, marking it as such is not great

Link the Much more of the datagrid features to a good feature list, not the one currently used

In the data grid example of Powerful components for advanced use-cases, remove the form with Dataset, Rows and Page size, the example is to small for it to be relevant

Update the Available with MIT and commercial licenses description for premium plan when available

I'd love to contribute to this. What shall I do?

Thank you for the feedback @flaviendelangle ! That is super helpful.

Hey @sumitsaurabh927 👋 it's nice to see you here!
I'm glad you're interested in contributing. This issue is better suited to internal folks at MUI who've worked on shaping the company's branding and messaging, so I don't think there's much I could ask you to do here. It's more like a public bulletin board where I can show the team what tasks I'm working on, and request feedback.
Feel free to have a look around our good first issues and grab anything you might be interested in working on. If you're looking to contribute to the docs specifically, please email me at<EMAIL_ADDRESS>and I'll be happy to show you where and how we could use your help!

Thanks, Sam for putting this up! Totally on board for this, I was already sketching something toward that direction for the Core page, resonating a bit more with the idea of a collection of libraries instead of a synonym for Material UI (current reality).

Pages for Joy and Material UI could use their default theme so it's straight up clear what folks will get out of installing the packages. As for Base and System, they might probably continue using the MUI branding theme, I guess.
I guess we could try thinking about content first and design later. What do we want to highlight and talk about on each of these pages? Then we figure out how to showcase them. What do you think about it?
Lastly, I think that most of what @flaviendelangle mentioned can be done today without any major design implication, it's mostly code and messaging adjustment. The one that makes me wonder though is "A more advanced custom theme"—let me know what you meant by that! Also, one easy/quick fix for the Roadmap section is simply deleting the "Work in progress" Data Grid column there. We release new Data Grid features way faster than new X components, so having to update that is definitely a hassle.

A more advanced custom theme

I don't have a clear idea of how it could be improved
But I feel like the current custom theme could be more ... custom. For instance with another pagination button, to demonstration deeper changes.

Do we have a vision about this topic ?
I can do some basic changes (like removing the "In progress" for the date range piker)
@joserodolfofreitas in the coming months I think it would be nice to improve the content of the X home page on the marketing website.

Thanks for unearthing this @flaviendelangle! 😁 I agree that these pages are now long overdue for updating. Since this is a topic that spans marketing, design, and DX, maybe this would be a good project for us to pick up in the next available product marketing meeting like we talked about in the X team split retro? cc: @gerdadesign
As for where things currently stand, we've talked a lot on the Core side of things about prioritizing a landing page for MUI Base since we've just "officially" launched it in alpha. I might have dropped the ball there 😅 and I should probably just ask @danilo-leal if his design is ready to go so I can start assembling it.

think it would be nice to improve the content of the X home page on the marketing website.
+1

maybe this would be a good project for us to pick up in the next available product marketing meeting like we talked about in the X team split retro?
+1

I'm adding it as an initiative for Q4.

Closing this, as most of these pages have been revised, or else they're not a priority at this time.


IDAV6 1229 Fixes for manage authorised people page

Link to Jira:
https://companieshouse.atlassian.net/browse/IDVA6-1229
Changes:
Removal of association

updates verification request to handle pagination
typo fixed

Cancellation of association

updates request to handle pagination
add missing await operator to removeUserFromCompanyAssocations

Navigation checks

resend email url now includes formatted company number in url
adds an allow list for the resend email confirmation page

CI: No security warnings found


The first support is not captured (Support Image Maker)

MAKE SURE YOU TESTED THE LATEST RELEASE.

Always has been 🔫
Describe the bug
[NA] You can see that the second one is selected and the first one is not
Kinda similar to my jp one #124 but it's support image maker now not battle mode (the battle mode is fixed both na and jp , I tested it over and over)
Screenshots

Device Info:

Device model: Xiaomi Redmi Note 7
Screen size: 1080 x 2340

You're right. Support Image Maker is indeed acting weird.
It's detecting the first support but ignoring the second one for me.

It isn't consistent either. Sometimes it detects both, sometimes detects only one.

I'll take a look.

Found the bug and fixed. Thank you for reporting!
@reconman remember changing that for loop which terminated after 2 selected supports to take(2).
We should have done the bounds check before that.
The third support was getting more similarity than the above one but left out by the bounds check.

Got it.


Sample code tweaks to prevent immediate errors

Note - the buttons still don't work unless IsHitTestVisible="False" gets set, but that is presumably a temporary bug.

@kmgallahan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This topic and WinUI have gone through a number of revisions. Closing the PR, but please open a new one if you are still encountering any issues.


Consider musl builds

It might be worthwhile to consider picking musl builds instead of glibc builds for platforms without glibc to address #30. The builds themselves are available but currently not considered by rye.

Relates to #189

Possible solution for musl libc:

Add new OS string for musl Linux on the downloads.inc, e.g linux_musl. It will detect whether the OS is musl libc or GNU libc, and use the appropriate URLs for each
Prioritize musl downloads over glibc. This method will download musl builds when available; if they are not available, use GNU libc. This has the downside that while using a musl Linux, you might believe that the other Linux downloads work here as well, but they don't (e.g PyPy's binary Linux builds only support glibc, as of now)

I'm taking a look at this issue further, hoping to help out with it

There's also the option for adding a toolchain string in the Python versions. E.g:

linux-gnu-x86_64
linux-musl-x86_64
win32-msvc-aarch64
I don't think it's worth it though, since AFAIK there's only one edge case for now, which is musl

Ran into this yesterday while trying to set-up an Alpine Linux Docker image for CI purposes. Even despite using the locally installed toolchain rye will still complain about incompatible versions. I'll provide the Dockerfile I am playing with for reference:
FROM "alpine:latest"
ENV HOME="/root"
WORKDIR $HOME

RUN apk add -U --no-cache \
        git \
        libffi \
        libffi-dev \
        python3 \
        py3-virtualenv \
        openssl \
        openssl-dev \
        build-base \
        perl \
        pkgconfig \
        curl \
        cmake

RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- --default-toolchain stable --profile minimal --component clippy -y
ENV PATH="$HOME/.cargo/bin:${PATH}"
RUN cargo install --git https://github.com/astral-sh/rye rye --locked
RUN rye toolchain register "/usr/bin/python"
RUN rye tools install pytest

And the result of running docker build . is:
 => ERROR [7/7] RUN rye tools install pytest                                                                                1.5s
------
 > [7/7] RUN rye tools install pytest:
0.283 Bootstrapping rye internals
1.502 Found a compatible Python version<EMAIL_ADDRESS>1.527 error: unable to create self venv using /usr/bin/python3.11. It might be that the used Python build is incompatible with this machine. For more information see https://rye-up.com/guide/installation/
1.527
1.527 Caused by:
1.527     No such file or directory (os error 2)
------
Dockerfile:23
--------------------
  21 |     RUN cargo install --git https://github.com/astral-sh/rye rye --locked
  22 |     RUN rye toolchain register "/usr/bin/python"
  23 | >>> RUN rye tools install pytest
  24 |
  25 |
--------------------
ERROR: failed to solve: process "/bin/sh -c rye tools install pytest" did not complete successfully: exit code: 1

Same happens if I try doing rye self install -y.


Error with no config file

reduce() of empty sequence with no initial value

Thanks for the report, I fixed it via a similar way. See https://github.com/floydwch/kaggle-cli/commit/0521b154ab869ceb93d76787b515988e2d0a28bc and https://github.com/floydwch/kaggle-cli/commit/f3d966906e8ad3861e9d93b94a933e2b2c32fa84 .


Support Kubernetes-related Environments API fields

These fields have been added to 17.4, see
https://docs.gitlab.com/ee/api/environments.html#create-a-new-environment

@svanharmelen do you mind giving this a review?


Incorrect nvm sourcing

https://github.com/Nipsuli/dotfiles/blob/22c214051649e6bc6fc56d078bc4089ac3393238/nipsulidotfiles.sh#L396
Perhaps should be:
source $(brew --prefix nvm)/nvm.sh

Or changing to:
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"


allowJs: why is import "x.js" being ignored?

Source:
// ./src/main.ts
import './console-log';
import './console-log.js';

console.log('console-log main')

// ./src/console-log.js
console.log('console-log JS')

// ./src/console-log.ts
console.log('console-log TS')

Config:
{
    "compilerOptions": {
        "module": "amd",
        "outFile": "./target/main.js",
        "allowJs": true
    },
    "files": ["./src/main.ts"]
}

Output:
// ./target/main.ts
console.log('console-log TS');
define("main", ["require", "exports", './console-log', './console-log.js'], function (require, exports) {
    "use strict";
    console.log('console-log main');
});

Notice that the output is missing the contents of the ./console-log.js import.

I suspect this is a dupe of #4595 and fixed via #8895

Is there any workaround? I guess I could rename all of my files to .ts

I guess the question is why do you have to be explicit about the file extension on your modules?
I see you are outputting to AMD... it is considered not a good idea to specify the file extension in AMD, because of portability issues just like this.

I have an app where some modules are TS, some are JS. I want to include all of them, but this bug means that currently, all my JS files are ignored.
I'm being explicit in my example because I have two files, one in TS and one in JS, and I want to import both. The fact they have the same name is irrelevant.

I'm being explicit in my example because I have two files, one in TS and one in JS, and I want to import both. The fact they have the same name is irrelevant.

Name two different modules .js and .ts is a recipe for disaster...  When you files are transpiled and emitted, what do you think the .ts file is going to be named?

The issue persists even if the files have different names.

But then you don't (and shouldn't) append .js to your file name for an AMD module loader.

I see, that seems to fix it! Thank you.
On Fri, 10 Jun 2016 at 11:21 Kitson Kelly<EMAIL_ADDRESS>wrote:

But then you don't (and shouldn't) append .js to your file name for an
AMD module loader.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/9070#issuecomment-225147143,
or mute the thread
https://github.com/notifications/unsubscribe/AA4QCa5zw196YN_9Tm7x4Xx-zJIHjquSks5qKTqOgaJpZM4Iyvi6
.

Now I have separate names, the modules are being included in the bundle. However, the AMD output is broken:
console.log('console-log JS');
console.log('console-log TS');
define("main", ["require", "exports", './console-log-1', './console-log-2'], function (require, exports) {
    "use strict";
    console.log('console-log main');
});

Requiring/importing main will fail because there is no AMD module called console-log-1 or console-log-2. TypeScript did not wrap them as AMD modules. Why is this?

@OliverJAsh did console-log-1 or console-log-2 have any import or export statements? Our detection on whether or not a file is a module is based on that. If you don't have any exports, you can use export {}.

They have no import/export statements. Should TypeScript be adding them as dependencies to the outputted module if they are not detected to be a module?
In my case I am gradually converting an app into modules, so it would be difficult to add export everywhere.

there are two issues, first the .js extension issue. this is tracked by  #4595 and fixed in #8895 as @kitsonk noted.
the second is that the files are not considered modules, as @DanielRosenwasser noted. for these, consider adding an empty export statement in the JS files, e.g.:
// ./src/console-log.js
console.log('console-log JS')

export {}; // makes it a module

with that change, the output would look like:
define("console-log", ["require", "exports"], function (require, exports) {
    "use strict";
    // ./src/console-log.ts
    console.log('console-log TS');
});
define("console-log", ["require", "exports"], function (require, exports) {
    "use strict";
    // ./src/console-log.js
    console.log('console-log JS');
});
define("main", ["require", "exports", "console-log", "console-log"], function (require, exports) {
    "use strict";
    console.log('console-log main');
});

The change that needs to be done on the TS compiler side, is to treat a file as module, if it was imported. this is more inline with the spec. we should file a different issue to track that.

I think TypeScript should not allow the user to end up in the situation I did, with a broken AMD module. Could TypeScript throw an error/warn if you try to load a JS file that is not a module?

@OliverJAsh, covered by #9082

I have a similar issue I posted in a StackOverflow question and then I stumbled across this -- it seems related, except I think my question points out that @mhegazy's suggestion actually does not produce the expected output posted.

@mjohnsonengr is this a different issue. i have replied to your SO question.

Error for non-module code used as module is tracked by  #9082

@OliverJAsh The problems with explicit extension syntax are, as @kitsonk mentioned, name collision and loader issues, and also workflow toolchain issues.
Let's suppose I am developing a module using SystemJS and using plugin-typescript as my transpiler. My colleague is developing a different module and prefers to use gulp-typescript. I can consume his code and he can consume mine without any issues. However, if either of use used explicit extensions, they would be emitted in the transpiled code, meaning if my colleague were to import one of my files, it would be looking for the artifact. It also would mean that with allowJS the compiler would pick a .js file before a corresponding .ts file, and thereby lose available type information.


Publishing as hex package

hex.pm package v. 0.1.0 published at  https://hex.pm/packages/elixir_email_reply_parser
Closing


Use threads, cache Scala compiler in GH mvn workflow

Save the overhead of setting up the runner by folding the short-lived runner get-shim-versions-from-dist steps into cache-dependencies job
Add  restore-keys to make sure  cache-dependencies does not start on an empty m2, stable versions like for spark artifacts do not change
Use de.qaware.maven:go-offline-maven-plugin suggested by @revans2
Save scala compiler bridge into a cacheable location

Previous mvn workflow duration:

before #9674: ~8min or much longer with retries
on cache hit: ~7min
on cache miss: ~11min

After this PR:

on cache hit: 5min
on cache miss: 7min

build


Blue bar appears on input field for one plaque

URL
No response
How to reproduce the issue?
A blue bar, resembling a scroll bar -it does not move when scrolling or on interaction-, appears when entering the input field for the inscription of this plaque. It does not seem to appear on other plaques (I've checked ones with long descriptions as well as short descriptions).
Screenshot(s) or anything else?

Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
2.24.1
Which browsers are you seeing this problem on?
Chrome (outdated version)

This is a new feature telling you how many characters you have left before hitting the API limit on value lengths: #9390. I can see how it might look like a rendering glitch, when it underlaps the button separators in the button bar above the text field.

Closing in favour of discussion on #7943.


fix: makes URLSearchParams global and remove node import

Summary
When using json-api in client side, we get the following warning

Node.js already supports using URLSearchParams under the globalThis. Hence we don't need to import them explicitly.

Changes

remove node:url import to be compatible with client side

Videos/screenshots

@therockstorm I just realized that I didn't do a version bump for the PR. should we do that ? How does this gets updated in the consumer ?

It auto bumps the version and publishes on merges to main, so you just upgrade to the latest version in services that use the library.


Add a null check command

[ ] Design doc
[ ] Implementation

This is pretty simple in most languages. For JavaScript let's use typeof x === "undefined".


Issue1055 Status Condition for Installation's CR from Tigerastatus conditions

Description

For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Highlights of the changes in this PR:

Have used metav1.condition for Installation CR status condition as per the API convention.
Tigerastatus condition type Available is mapped as "Ready" in installtion's condition
Reasons will be one of the newly introduced TigeraStatusReason Enum.
Modified SetDegraded func definition to accept TigeraStatusReason and appended the existing free form reasons in the code to message.
Clearing Available,Progressing or degraded status will set the reason as operator.unknown and message as Unknow. Since both are required field in metav1.condition
ObservedGeneration will be available in new Installation condition (edited)

Detail Design Document
https://docs.google.com/document/d/1wrQDvQIFGCElmrZ0XxOFuFLUXY-SoSeG/edit#

Fixes #1055


sync: release 0.36.x

What type of PR is this?
/kind release
What this PR does / why we need it:
Backports

[x] https://github.com/falcosecurity/falco/pull/2810
[x] https://github.com/falcosecurity/falco/pull/2813
[x] https://github.com/falcosecurity/falco/pull/2814
[x] https://github.com/falcosecurity/falco/pull/2815
[x] https://github.com/falcosecurity/falco/pull/2820
[x] https://github.com/falcosecurity/falco/pull/2819
[x] https://github.com/falcosecurity/falco/pull/2809
[x] https://github.com/falcosecurity/falco/pull/2823
[x] https://github.com/falcosecurity/falco/pull/2822
[x] https://github.com/falcosecurity/falco/pull/2824

from master.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
sync: release 0.36.x

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c3a625368d5d9000f71ca9a6a2d9c3350f2cf433

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


non-English characters get translated differently in title tag

I was trying to insert some non-English characters into the title tag, Characters displayed correctly without errors, but in the source code, they get translated into some unrecognized characters. (Looks like some escaped UTF8 characters)
For example,
DocHead.setTitle('タイトル');

Gets translated into this
<title>タイトル</title>

I already put the meta tag with charset set to utf-8, but source code still remains the same
see my forked repo: https://github.com/awsp/hello-react-meteor
→ https://github.com/awsp/hello-react-meteor/blob/master/both/router.jsx
I would like it to be exactly the same as the title I input.
How would I possibly do it?
PS:
The body content being processed by the package flow-router-ssr displays non-English characters correctly even in source code. It seems to happen in <head> tag only.
EDIT
This issue seems to happen in meta tag as well.

Yeah! Seems like something to investigate. Let's check.

Thanks for your reply.
I found this article might look somewhat similar, hope it helps.
http://stackoverflow.com/a/2862421/2167601

Ok, I think I have located where the issue is.
It is actually in the flow-router-ssr package,
https://github.com/kadirahq/flow-router/blob/ssr/server/route.js#L95
Is it possible to change to the follow?
In that case, it should not encode anything in <head> including title and meta.
var $ = Cheerio.load(data, {
  decodeEntities: false
});

Yeah! I think that's the issue.
Could you send me a PR for that project?

thanks!


React viro app keeps stopping on android device

Following this tutorial, I create a boiler plate react native app using nxp command line . Then I added react-viro by npm install -S -E react-viro and finally configured project through this document.
Now I can build app successfully and run it on real device so that the default menu of ViroSample app appears:

But if I go to any of AR or VR menus, it crashes and I get Keeps Stopping.
Now I've realized there are some incompatible version installed for project. When I execute npm list --depth, I see this:
npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.00-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta, required by<EMAIL_ADDRESS>
npm ERR! peer dep missing<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.00-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta, required by<EMAIL_ADDRESS>
Should I downgrading installed version of mention libraries?
This is part of my package.json:
"dependencies": {
    "create-react-class": "^15.7.0",
    "react": "16.13.1",
    "react-native": "0.63.4",
    "react-viro": "2.17.0"
  },

Did you figure out the solution to the issue


Helm: Added various configuration options for the Tetragon Operator Deployment

I have added multiple configuration options for the Tetragon Operator Deployment, which are often crucial for enterprise-grade deployments that need to happen within certain security boundaries.
According to my current understanding, this should not break anything for existing users. The only chance I see a breakage happen is when somebody already configured .Values.serviceAccount.name in the past. The thing is, this value was never considered, and the SA was simply named {{ .Release.Name }} or {{ .Release.Name }}-operator-service-account. With this change, it would suddenly be considered for the actual SA naming.

helm: Added extraVolumes support for the Tetragon Operator
helm: Added extra labels for the Tetragon Operator Deployment and Pods
helm: Added configurable annotations for the Tetragon Operator Deployment and Pods
helm: Made the placement of Tetragon Operator Deployment Pods configurable
helm: Made update strategy configurable for the Tetragon Operator Deployment
helm: Made resource configurable for the Tetragon Operator Deployment
helm: Added pod/container securityContext to the Tetragon Operator Deployment
helm: Added priorityClassName to the Tetragon Operator Deployment
helm: Added imagePullSecret to the Tetragon Operator Deployment

@PhilipSchmid I see the CI is failing:

The generated docs are not up to date - ./install/kubernetes/test.sh should do the trick
The commit messages are too long

Could you fix these?

@lambdanis I just shortened the commit messages and checked that the .test.sh script no longer generates new changes. Unfortunately, the CI is now even more unhappy with this PR 😆.

Oh dear, it looks like some Quay hiccup maybe? The CI failures definitively don't looks related to the changes. I'll rerun.

checked that the .test.sh script no longer generates new changes

Ok, I run on your branch and it looks like the trailing space here is the problem. I suppose your editor is removing trailing spaces automatically? If you could remove this space from the script, then it should pass :) (a bit surprising that nobody hit it before tbh)

After some flakes the CI finally passes, so I'm merging it, thank you @PhilipSchmid!


Settings - Cancel Button

When the cancel button is pressed, nothing happens. It should go back to the home page.

I'm going to change the buttons around a bit today. I don't like the
current placement of them; they seem out of place and should be integrated
into the bottom of the form instead of in the title bar. We may not even
need a cancel button, just a simple save may be all that's needed.
I'm going to change them around today and then we can circle back to see if
any other changes are needed.
On Nov 17, 2015 12:21 AM, "Dr Washington Sanchez"<EMAIL_ADDRESS>wrote:

When the cancel button is pressed, nothing happens. It should go back to
the home page.
—
Reply to this email directly or view it on GitHub
https://github.com/OpenBazaar/OpenBazaar-Client/issues/220.

Pressing cancel just reloads the settings page. Do we still need a cancel button? I know
@hoffmabc had an issue with the name 'Cancel' if we keep it. I suggest we probably remove it... if people want to cancel stuff, they can go back home or refresh or something.

I could see switching it to be a restore button or something.

Yep that's a good idea.


Show slide box for cells without events

Is there a way to show the slide box when clicking on a cell without events?
Versions
Angular:1.5
Calendar directive:0.20
Browser name and version:Chrome

Not currently as it wouldn't show anything. What's your use case?

Thanks for the quick reply.
I really like the slide box and want to use it to allow the user to add an event instead of using a modal or other "add" controls.
I customized the template for the SlideBox (very easy to do) so it's just a matter of showing it. I looked through the code but couldn't figure out how to set the isCollapsed variable from my controller.
Thanks,
Andrew

Ah ok, if you override the month view template and change the expression on this line to:
vm.openRowIndex === $index && !vm.slideBoxDisabled

it should give you the behaviour you need 😄

Thank you sir.


add PNAS accepted article to Publications page

I think we should add the full citation for our accepted PNAS article to Publications page - I couldn't find the format to do this

The format for publications is documented here https://wowchemy.com/docs/content/publications/ (I'll add to the README) but the theme does not have a good way to add citations of pre-published work.
I suggest leaving this on the About page as it is in the google doc, then adding to "publications"  when it's published in a few days

Zarnetske, P.L., J. Gurevitch, J. Franklin, P. Groffman, C. Harrison, J. Hellmann, F. Hoffman, S.
Kothari, A. Robock, S. Tilmes, J. Wu, D. Visioni, L. Xia, and C.-E. Yang. In Press. Potential ecological impacts of climate intervention by reflecting sunlight to cool Earth. Proceedings of the National Academy of Sciences.

added in as "in press" on a new publication page.  The formatting is not great for pubs for this theme - it's built assuming you will have many publications (e.g. a CV) but the information is there.

closed with 48c7464321f5d76600bfe1de531345f8629bd1f3  which adds a new publications sections and menu item. https://www.climateinterventionbiology.org/publication/

Thanks - the "P.L." is not showing up next to my name in the beginning of the citation.

unfortunately, the theme meddles with the author list, so for now I've simply put your initials in front of your name.   That's not standard format but it's a website, not a CV,  so I think it will be ok


Add E2E test script for user space instrumentation on Silenus

Bug: http://b/219015201
Test: Ran locally.

https://github.com/google/orbit/pull/3339 should be merged first but I'm creating this since I have it while I see if I can test https://github.com/google/orbit/pull/3339 a bit more.


Pijul 0.8.0 -> 0.10.0

Motivation for this change
This is a non-trivial verision bump.
Had to make quite a few changes:

sourceRoot was removed because target/release is now located the root directory not in ${name}/pijul
added pkgconfig, libsodium, and openssl

Requires additional testing.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This one seems the way to go from my perspective. If we later want to move from this version to carnix, that’s fine, but I don’t think there’s any reason to avoid getting the version bump done. I mean, this has already been here for a month, and I’d love to be using it.

Agreed, lets pull this now and then Carnix can have it's day later.
On Sat, Jun 16, 2018, 14:06 Greg Pfeil<EMAIL_ADDRESS>wrote:

This one seems the way to go from my perspective. If we later want to move
from this version to carnix, that’s fine, but I don’t think there’s any
reason to avoid getting the version bump done. I mean, this has already
been here for a month, and I’d love to be using it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/40622#issuecomment-397838879, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACC_mxFuns1hy2qPKBxWfNvwIbX-C4yWks5t9XNugaJpZM4UCMhe
.

@GrahamcOfBorg  build pijul

Failure on aarch64-linux (full log)
Attempted: pijul
Partial log (click to expand)
source root is pijul-0.10.0
unpacking source archive /nix/store/j36ha3n1ppvkfcksv3f978wanxvqnir3-pijul-0.10.0-vendor
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
building
Running cargo build --release
error: the lock file needs to be updated but --frozen was passed to prevent this
builder for '/nix/store/1lxv42jdwswriqc4ggf2kb6jkqipn02w-pijul-0.10.0.drv' failed with exit code 101
error: build of '/nix/store/1lxv42jdwswriqc4ggf2kb6jkqipn02w-pijul-0.10.0.drv' failed

Failure on x86_64-linux (full log)
Attempted: pijul
Partial log (click to expand)
unpacking source archive /nix/store/3s6vdyzkly0mzhgbg2xq08n6mqrzgf2z-pijul-0.10.0.tar.gz
source root is pijul-0.10.0
unpacking source archive /nix/store/j36ha3n1ppvkfcksv3f978wanxvqnir3-pijul-0.10.0-vendor
patching sources
configuring
building
Running cargo build --release
error: the lock file needs to be updated but --frozen was passed to prevent this
builder for '/nix/store/a6p2s7vz0rdshbnhx8vh67h6g2x7s1rg-pijul-0.10.0.drv' failed with exit code 101
error: build of '/nix/store/a6p2s7vz0rdshbnhx8vh67h6g2x7s1rg-pijul-0.10.0.drv' failed

Failure on x86_64-darwin (full log)
Attempted: pijul
Partial log (click to expand)
unpacking source archive /nix/store/3s6vdyzkly0mzhgbg2xq08n6mqrzgf2z-pijul-0.10.0.tar.gz
source root is pijul-0.10.0
unpacking source archive /nix/store/j36ha3n1ppvkfcksv3f978wanxvqnir3-pijul-0.10.0-vendor
patching sources
configuring
building
Running cargo build --release
error: the lock file needs to be updated but --frozen was passed to prevent this
builder for '/nix/store/a7cc6x79av56zkh3x7mjxz5dq9b26c1h-pijul-0.10.0.drv' failed with exit code 101
error: build of '/nix/store/a7cc6x79av56zkh3x7mjxz5dq9b26c1h-pijul-0.10.0.drv' failed

Build fails, please fix.

This looks like the same failure @drostron ran into earlier.

Yes, I ran into the same failure when introducing this as an overlay. I had to override buildRustPackage's buildPhase removing the --frozen flag. That worked, but I'm not familiar enough with Rust builds to know the ramifications.

Without --frozen, rust will auto-update dependencies when necessary. It will fail in the sandbox.

Any updates on this? Mine is failing with:
source root is pijul-0.10.0
unpacking source archive /nix/store/j36ha3n1ppvkfcksv3f978wanxvqnir3-pijul-0.10.0-vendor
patching sources
configuring
building
Running cargo build --release
error: the lock file needs to be updated but --frozen was passed to prevent this

Seems upstream Rust needs to update its dependencies before this will build. Upstream Rust has been taking too long to do so, I suggest we merge #39317


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.144

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.144


Course relocation will not work on HoloLens 2 following these instructions, needs appx manifest instructions

Course relocation on HoloLens 2 does not work using WiFi, unless you make the change to the appx manifest mentioned here - https://github.com/Azure/azure-spatial-anchors-samples/issues/98
Please add this to the documentation so people can make a working app on HoloLens 2 by following the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83ae36cf-7518-1564-74fc-01b7201e83c6
Version Independent ID: aa88f765-3e1a-ca51-5f15-d1d329262713
Content: Coarse relocalization in Unity - Azure Spatial Anchors
Content Source: articles/spatial-anchors/how-tos/set-up-coarse-reloc-unity.md
Service: azure-spatial-anchors
GitHub Login: @msftradford
Microsoft Alias: parkerra

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Hi @asergaz - we are tracking this under work item 37840042 - can you please reassign to Patrick Misteli ?


battery drain

Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
Expected behavior
Tell us what should happen
Actual behavior
Tell us what happens instead
Steps to reproduce

Environment
K-9 Mail version:
Android version:
Account type (IMAP, POP3, WebDAV/Exchange):

I will try to log in later on my desktop. I'm having trouble using the mobile version of github.


Force function not run with MySQL on register

DO NOT REMOVE THIS
Please make sure your issue complies with these guidelines:

[x] Be using PMMP

[x] Make sure the issue hasn't already been reported

[x] Make sure you are on the latest version of PMMP & PiggyAuth

[x] Have a detailed title like "Players are being kicked randomly"

[x] Provide any crash dumps or errors

General

Sometimes the force function is not run after registering or logging in, resulting in effects not being removed, bossbars not removed, or gamemode set.
Server Software:
 PMMP
Version of PiggyAuth:
 <IP_ADDRESS>
Data Provider:

[x] MySQL
[ ] SQLite

Steps to Reproduce the Issue

Turn on MySQL
Register non stop until it happens

Extra Information

Please please please please... Add more comments so I can better understand your codebase... My classes basically have a huge essay in a multi-line comment explaining what they do (although the code explains itself). Sometimes I also add small comments in certain lines (such as ternary statements) for code that doesn't explain itself right away.
If you did the same (not encouraging you to litter the code with comments xD),Me and other people could better understand the codebase so that we could better help you fix this bug.

@miguel456 the functions SHOULD be self documented by names and calling from
it's somewhat messy honestly doe

When a player's password is reset using resetpassword, logout doesn't seem to run either.

Fixed 2nd issue.

Commit 661e3739756f72d81568b4da58a6fd7ef1728636 seems to have fixed it.


/ Running out of disk space (2.4G)

I dropped the price table which got us to 2.4G (we were at 1.2G free) but we probably need to do something about it sooner rather than later.

Big Query.

This became serious again today. Deleted a 2.4G backup of prices sqlite and dropped the price table (and recreated empty) which got us 1.8G because the backup deletion didn't seem to recognize that the file was gone??

Now down to 1.5G after latest deletion.


Pickling a function returns None as the module

Pickling the readline function of io.BytesIO returns a None module instead of _io
>>> jsonpickle.encode(BytesIO(b'bytes').readline)
'{"py/function": "None.BytesIO.readline"}'

Thank you for the PR! Please link this issue to your PR by editing the PR description to say "Fixes #399".


Understanding the speed parameters

Hi @taigw,
I am trying to understand how the implemented equation with speed parameter relate to the original geodesic distance equation in the paper.
More particularly the line in question is:
https://github.com/taigw/GeodisTK/blob/7907b3874c5e19d10b056f8de39e443cb7f221c2/cpp/geodesic_distance_2d.cpp#L191
This seems different from Equation 2 and Figure 12 of:
https://www.microsoft.com/en-us/research/wp-content/uploads/2016/02/Criminisi_eccv2008.pdf
Can you guide me on the derivation that relates this back to the gradient as in Figure 12?
Many thanks!
Muhammad

Hi @masadcv , This implementation gives a generalization of Euclidean and  Geodesic distance. In the original paper, the hyper-parameter gamma  in figure 12 makes the equation always contain the Euclidean term. This repository used another hyper-parameter lambda, so that the output only depends on the spatial distance when lambda is 0, and becomes purely dependent on the integration of intensity differences when lambda is 1.


Failure in linking with libdispatch following Linux directions

Running Ubuntu 14.04 LTS fully up2date and using the swift-DEVELOPMENT-SNAPSHOT-2016-06-20-a-ubuntu14.04 I get the following error during linking with libdispatch:
/usr/bin/ld: /home/administrator/lib-dispatch/swift-corelibs-libdispatch/src/Dispatch.o: relocation R_X86_64_PC32 against protected symbol `_TMaC8Dispatch17dispatch_object_t' can not be used when making a shared object

Full log: https://gist.github.com/msmollin/8165a2ba3c99b2b1777aab3e524a0022
Relevant build command used:
git clone --recursive -b experimental/foundation https://github.com/apple/swift-corelibs-libdispatch.git && cd swift-corelibs-libdispatch && sh ./autogen.sh && ./configure --with-swift-toolchain=/home/administrator/swift/usr --prefix=/home/administrator/swift/usr && make && make install

I will refer this to the libdispatch folks, as this is really a libdispatch issue and not a Kitura issue.

Cool. Should I post a bug over there for them?

Let's wait and see. I have contacted them offline. Pointing them at this issue.

@dgrove-oss ?

You get that error when using the GNU linker (bug in GNU linker).  You need to use the gold linker instead.

How is the gold linker specified?  Do we need to update our libdispatch build instructions?

It looks like you can apt-get install binutils-gold and it'll replace the standard linker with gold for the ld command. However that's a system-wide change. I haven't been able to find a way yet to do that more localized to just the libdispatch project. Thoughts?

I don't know of a more localized way.   When I installed binutils-gold on 16.04 it was a little less invasive....I have both ld.gold and ld.bfd and /usr/bin/ld is a symlink to ld.bfd by default.
dgrove@dgrove-vb-swift:~/swift$ which ld
/usr/bin/ld
dgrove@dgrove-vb-swift:~/swift$ ld --version
GNU ld (GNU Binutils for Ubuntu) 2.26.1
Copyright (C) 2015 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.
dgrove@dgrove-vb-swift:~/swift$ ld.gold --version
GNU gold (GNU Binutils for Ubuntu 2.26.1) 1.11
Copyright (C) 2015 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.
dgrove@dgrove-vb-swift:~/swift$ ld.
ld.bfd   ld.gold
dgrove@dgrove-vb-swift:~/swift$ ld.bfd --version
GNU ld (GNU Binutils for Ubuntu) 2.26.1
Copyright (C) 2015 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.
dgrove@dgrove-vb-swift:~/swift$ ll /usr/bin/ld
lrwxrwxrwx 1 root root 19 Jul 14 15:30 /usr/bin/ld -> x86_64-linux-gnu-ld*

Thanks @dgrove-oss . As we know the solution to this issue, and Ubuntu 16.04 is not yet officially supported by swift.org or Kitura, I'm closing this issue.

Well, so, I did some more digging, and the binutils package for the latest 14.04 LTS also includes ld.gold now. However, you have to do some work because for some reason ld.bfd and ld.gold aren't integrated into Ubuntu's update-alternatives list. However, it's fairly easy to do so.
$ sudo update-alternatives --install /usr/bin/ld ld /usr/bin/ld.bfd 10
$ sudo update-alternatives --install /usr/bin/ld ld /usr/bin/ld.gold 9
$ sudo update-alternatives --config ld

Then you can easily switch between the two as the ld executable of choice.
To that end, I can confirm @dgrove-oss's original statement, as ld.gold does correctly compile and link, and thus allow for subsequent installation, of the libdispatch system.

@ianpartridge might make sense to put a note in the README docs about this, as it affects but it solvable on 14.04

Good point, I'll reopen this. Also need to research a bit more as I'm sure we never used to have to worry about this.

I've updated the Readme in 1f6e660c7b5a8c488911382ca2b3e215afd7f553 to specify the gold linker.  This is how our Package-Builder repo is doing it and it seems like a simple solution.  Thanks!


Error: Could not open video stream

Please use the issue template.
Please do not post screenshot of a terminal.
It seems you are not using the last version (v1.13).


Fix rwx logo

rwx logo is missing. This is the best one I could find - it's from their GitHub page. Their current logo is provided as an inline SVG.
Signed-off-by: Henrikh Kantuni<EMAIL_ADDRESS>

Hi @kantuni, thanks for your contribution!
I was thinking it could be nicer to store the raw svgs in a sponsor folder and link to those, that should also cause the whole README to load faster. What do you think?

I was thinking it could be nicer to store the raw svgs in a sponsor folder and link to those

Hey, just chiming in since I happen to have a cached version of the README in my browser pointing to the "old" svg :)
rwx SVG
<svg
  version="1.1"
  xmlns="http://www.w3.org/2000/svg"
  xmlns:xlink="http://www.w3.org/1999/xlink"
  viewBox="68 44.98 631 248.02"
>
  <title>rwx_banner_transparent</title>
  <g
    id="Banner-Transparent"
    stroke="none"
    stroke-width="1"
    fill="none"
    fill-rule="evenodd"
  >
    <rect id="Rectangle" x="0" y="0" width="766" height="339" />
    <g
      id="rwx_logo"
      transform="translate(348.000000, 111.000000)"
      fill="#008754"
      fill-rule="nonzero"
    >
      <g
        id="Group"
        transform="translate(175.500000, 57.500000) scale(-1, 1) rotate(-180.000000) translate(-175.500000, -57.500000) translate(0.000000, 0.000000)"
      >
        <path
          d="M57.9948522,114.428966 C48.7273331,112.682848 42.0244105,108.899591 34.0391896,100.92565 L28.0939887,94.988847 L27.744271,100.92565 C27.5111259,104.126867 27.2196945,108.201144 27.0448356,109.889058 L26.6951179,112.915664 L13.347559,112.915664 L0,112.915664 L0,56.4578318 L0,0 L14.2801395,0 L28.560279,0 L28.560279,33.8164951 L28.560279,67.6329903 L30.3671538,71.0670234 C33.9809034,77.8186816 38.3523746,81.4855305 46.1627366,84.2793201 C50.1262039,85.6762149 51.1170707,85.7926228 60.9091664,85.7926228 C68.428097,85.7926228 72.9744271,85.501603 76.8796081,84.8031556 C79.9104949,84.2211161 82.4750913,83.8718924 82.5916639,83.9883003 C82.7082365,84.1047082 83.6991033,90.4489388 84.864829,98.0736563 C86.4968449,109.015999 86.7882763,111.9844 86.2054135,112.391828 C85.7974095,112.624644 83.232813,113.264887 80.4933577,113.788723 C73.5572899,115.06921 63.0657589,115.418434 57.9948522,114.428966 Z"
          id="Path"
        />
        <path
          d="M101.709565,111.053137 C101.884424,110.005466 106.48904,84.6285438 111.851378,54.7117133 L121.585188,0.291019752 L134.349884,0.291019752 L147.11458,0.291019752 L154.16722,35.3297979 C158.014115,54.5953054 161.336433,70.4849839 161.511292,70.6595957 C161.686151,70.8342076 164.36732,58.4949701 167.514779,43.1873312 C170.720525,27.9378962 173.984557,12.0482177 174.858851,7.8575333 L176.374294,0.291019752 L189.13899,0.291019752 L201.903686,0.291019752 L211.987214,56.1668121 C217.466124,86.8984979 222.012454,112.217216 222.070741,112.508236 C222.070741,112.741052 216.067253,112.915664 208.781468,112.915664 L195.492195,112.915664 L191.528728,81.3691226 C186.690966,42.4888837 185.816672,36.0282453 185.525241,36.2610611 C185.408668,36.377469 182.319495,52.9655948 178.647459,73.1041616 C174.975423,93.2427284 171.769678,110.412894 171.594819,111.344157 L171.245101,112.915664 L161.569578,112.799256 L151.835769,112.624644 L144.841415,74.2100367 C139.595649,45.2826734 137.788774,36.2610611 137.439057,37.541548 C137.147625,38.5310151 134.991033,55.2937528 132.601295,74.7920762 C130.153271,94.3486035 128.054965,110.878525 127.880106,111.635177 L127.646961,112.915664 L114.474261,112.915664 L101.359847,112.915664 L101.709565,111.053137 Z"
          id="Path"
        />
        <path
          d="M238.565759,112.508236 C238.740618,112.217216 247.133843,99.8779788 257.275656,85.0359714 C267.417469,70.1357602 275.635835,57.6801148 275.460976,57.2726871 C275.286118,56.8652595 267.88376,45.8647129 258.907672,32.768824 C249.98987,19.7311392 241.305214,6.98447404 239.673198,4.48170418 L236.584025,0 L252.263036,0 L267.88376,0 L280.706742,18.3342444 C287.701096,28.4035278 293.646297,36.6684887 293.879442,36.6684887 C294.112587,36.6684887 300.057788,28.4035278 307.168715,18.3342444 L320.049983,0 L335.554135,0 L351,0 L350.009133,1.57150666 C349.42627,2.50276986 340.625042,15.4240468 330.366656,30.3824621 L311.831617,57.5637069 L326.461475,78.9827606 C334.563268,90.7399586 343.073065,103.195604 345.462803,106.687841 L349.775988,112.915664 L334.155264,112.915664 L318.53454,112.915664 L306.29442,95.4544786 C299.591498,85.8508267 293.937728,78.0514974 293.762869,77.9932935 C293.588011,77.9932935 287.992527,85.8508267 281.289605,95.4544786 L269.224344,112.915664 L253.778479,112.915664 C245.268682,112.915664 238.449186,112.741052 238.565759,112.508236 Z"
          id="Path"
        />
      </g>
    </g>
    <g
      id="Group"
      transform="translate(68.000000, 45.000000)"
      fill="#008754"
      fill-rule="nonzero"
    >
      <path
        d="M103.180071,1.81413045 C107.40629,-0.604710151 112.593843,-0.604710151 116.820062,1.81413045 L140.882548,15.591205 C145.272443,17.9683857 148.032427,22.5419986 148.094009,27.541434 C148.155591,32.5408694 145.509106,37.1813411 141.179102,39.6663559 C136.849099,42.1513707 131.515279,42.0908435 127.242556,39.5082065 L110.000067,29.6438211 L92.7575769,39.5082065 C88.4848541,42.0908435 83.1510344,42.1513707 78.8210306,39.6663559 C74.4910269,37.1813411 71.8445415,32.5408694 71.9061239,27.541434 C71.9677063,22.5419986 74.7276896,17.9683857 79.1175852,15.591205 L103.180071,1.81413045 L103.180071,1.81413045 Z M49.7476029,48.270426 C53.5119004,54.8752141 51.2223015,63.2869458 44.632606,67.0623557 L41.4701079,68.8809295 L44.632606,70.6995034 C49.0225017,73.0766841 51.7824849,77.6502969 51.8440673,82.6497324 C51.9056497,87.6491678 49.2591643,92.2896394 44.9291606,94.7746542 C40.5991568,97.259669 35.2653371,97.1991418 30.9926143,94.6165049 L27.5001164,92.6188291 L27.5001164,96.4350787 C27.5001164,104.043947 21.3440354,110.212153 13.7501247,110.212153 C6.15621399,110.212153 6.62274327e-05,104.043947 6.62274327e-05,96.4350787 L6.62274327e-05,68.8809295 C-0.0155450245,63.838855 2.7298023,59.1943114 7.1501287,56.7846581 L30.9926143,43.1453542 C37.5844188,39.3736424 45.9796147,41.667751 49.7476029,48.270426 L49.7476029,48.270426 Z M170.25253,48.270426 C174.020518,41.667751 182.415714,39.3736424 189.007519,43.1453542 L212.836254,56.7846581 C217.248963,59.2040981 219.994973,63.8408459 220,68.8809295 L220,96.4350787 C220,104.043947 213.843919,110.212153 206.250008,110.212153 C198.656098,110.212153 192.500017,104.043947 192.500017,96.4350787 L192.500017,92.6188291 L189.007519,94.6165049 C184.734796,97.1991418 179.400976,97.259669 175.070972,94.7746542 C170.740969,92.2896394 168.094483,87.6491678 168.156066,82.6497324 C168.217648,77.6502969 170.977631,73.0766841 175.367527,70.6995034 L178.530025,68.8809295 L175.367527,67.0623557 C168.777832,63.2869458 166.488233,54.8752141 170.25253,48.270426 L170.25253,48.270426 Z M74.0025883,103.378724 C77.7705765,96.7760494 86.1657725,94.4819407 92.7575769,98.2536526 L110.000067,108.118038 L127.242556,98.2536526 C131.515279,95.6710156 136.849099,95.6104884 141.179102,98.0955032 C145.509106,100.580518 148.155591,105.22099 148.094009,110.220425 C148.032427,115.219861 145.272443,119.793473 140.882548,122.170654 L123.750058,131.979931 L123.750058,151.543377 C123.750058,159.152245 117.593977,165.320452 110.000067,165.320452 C102.406156,165.320452 96.2500748,159.152245 96.2500748,151.543377 L96.2500748,131.979931 L79.1175852,122.170654 C72.5278897,118.395244 70.2382909,109.983512 74.0025883,103.378724 Z M13.7501247,137.766302 C21.3440354,137.766302 27.5001164,143.934509 27.5001164,151.543377 L27.5001164,171.106823 L44.632606,180.9161 C49.0225017,183.293281 51.7824849,187.866894 51.8440673,192.866329 C51.9056497,197.865764 49.2591643,202.506236 44.9291606,204.991251 C40.5991568,207.476266 35.2653371,207.415739 30.9926143,204.833102 L6.93012883,191.056027 C2.64627684,188.604201 0.00172431745,184.040723 0.000133021286,179.097526 L0.000133021286,151.543377 C0.000133021286,143.934509 6.15621399,137.766302 13.7501247,137.766302 Z M206.250008,137.766302 C213.843919,137.766302 220,143.934509 220,151.543377 L220,179.097526 C219.998409,184.040723 217.353856,188.604201 213.070004,191.056027 L189.007519,204.833102 C184.734796,207.415739 179.400976,207.476266 175.070972,204.991251 C170.740969,202.506236 168.094483,197.865764 168.156066,192.866329 C168.217648,187.866894 170.977631,183.293281 175.367527,180.9161 L192.500017,171.106823 L192.500017,151.543377 C192.500017,143.934509 198.656098,137.766302 206.250008,137.766302 Z M74.0025883,213.595321 C77.7705765,206.992646 86.1657725,204.698537 92.7575769,208.470249 L96.2500748,210.467925 L96.2500748,206.651675 C96.2500748,199.042807 102.406156,192.874601 110.000067,192.874601 C117.593977,192.874601 123.750058,199.042807 123.750058,206.651675 L123.750058,210.467925 L127.242556,208.470249 C131.515279,205.887612 136.849099,205.827085 141.179102,208.3121 C145.509106,210.797115 148.155591,215.437586 148.094009,220.437022 C148.032427,225.436457 145.272443,230.01007 140.882548,232.387251 L117.026312,246.054109 C112.700009,248.64863 107.300124,248.64863 102.973821,246.054109 L79.1175852,232.387251 C72.5278897,228.611841 70.2382909,220.200109 74.0025883,213.595321 L74.0025883,213.595321 Z"
        id="Shape"
      />
    </g>
  </g>
</svg>

Actually can we put the svg in https://github.com/roc-lang/design-assets instead?
If we're not linking to the sponsor's domain, I'd prefer to link to a URL we control (e.g. I can't tell from the domain who controls https://avatars.githubusercontent.com/u/97913715 and might change it in the future)


Disable correlation for Azure Function

Describe your environment.
Describe any aspect of your environment relevant to the question:

SDK version:

Microsoft.ApplicationInsights 2.13.1
Microsoft.Azure.WebJobs.Extensions.ServiceBus 4.1.1
Microsoft.Azure.WebJobs.Extensions.Http 3.0.0
Microsoft.NET.Sdk.Functions 3.0.6

.NET runtime version (.NET or .NET Core, TargetFramework in the .csproj file): netcoreapp3.1
Hosting Info (IIS/Azure WebApps/etc): Azure, App Service Environment
Platform and OS version: Windows

What are you trying to achieve?
We have multiple systems, lets call them system Z and system Y. In system X are 10.000+ items that requires an transformation, update and needed to be added to system Y. To facilitate this, there are two Azure Functions. The first function is a HTTP trigger that puts N number of messages on a Azure Service Bus Queue. The second function is a ServiceBusTrigger that retrieves the message from the queue and transforms, update and saves the item to system Y. (If this is the most sensible way of approach is not the issue now.)
When we go into Application Insights in the Azure Portal to check exceptions everything is connected to each other because of the first HTTP trigger. So for instance, if I queue 10 items and item 2 fails in the transform part the "End-to-end transaction details" shows my exception, but also the "sibling" messages because everything is a child of the HTTP trigger.
For 10 items it is not that big of a problem, but I have many items and I queue many at once. So my interface looks like this:

What did you expect to see?
There should be a way to disable the correlation between different steps. The idea of business transactions and how they are usually behaving, but in this case I want to have more control. For instance it would be nice if I can disable the "connection" between the processing of the service bus message and the initial HTTP trigger.
Additional context.
To solve the issue we have tried to set the parent id in the telemetry context to an empty string (didn't work) and custom telemetry processor that skips service bus calls (no service bus dependencies but the connection is made).
Also tried to change the operation id, but that resulted that the tree was broken but everything was still there...
Perhaps there is something simple to achieve what we want, but we couldn't find it....
Thank you in advance!

I have a similar need. In my case, i send scheduled messages to myself in a loop. During each iteration i also send trigger messages to other services. The current implementation causes all of my function executions, that originate from such a scheduled message loop, to be part of the same operation.
What i need is a means to not pass the operation id when sending the scheduled message to myself.

Unfortunately, I am currently not in the position to check / test if this is still the case / issue. Still, I would like to be able to have some influence on the data that is collected.

Confirmed that yes, it is still the case.

Have the same issue, is there no way of creating a new correlation id for each new instance of the function app being started/triggered from the service bus messages?
It is near impossible to try find an issue if one message in 10 000 fail or cause an unexpected result


Node Texture Autosize Mode

When enabled, when a texture is loaded into the Node, the Node will automatically resize to the dimensions of the texture.
Text Nodes are always autosized based on their text content regardless of this mode setting.
Autosize Mode is false by default and must be explicitly set to true to be enabled.
Based on previous work by @pecoram in #68
Resolves #34

Autosize Mode is false by default and must be explicitly set to true to be enabled.

Letting this line be up to debate. I wanted to rethink this and make it true by default since that is now essentially the mandatory behavior for text. But I feel that would break things a lot more.
I've decided to abandon having this be set to true when using the src property. If anyone disagrees with that let me know.

I think thats fine - it's easy to pass through that prop. Most of the time users will set the image size - and then they don't know the size they can set the flag.


Tags query language

Big PR to review ;)
Implementing the tags query language (see #52 )
Don't merge til corresponding PR on server side is not merged (language could still evolve?)

It's ready to review / merge

@tsegismont do you have some time for this?

@karelhala thanks for sharing some javascript practices!
I addressed most of the issues, not all :

string templates: I am not yet fully convinced on that, readability is kinda subjective sometimes, and to me adding yet another way to represent string is just more confusion... well, maybe I need some time to get used to it :)

I looked at your suggestions with lodash take[while], but here it's maybe not as obvious as you would think and, in the end, it would not really compact the code.

I think apart from that, I've done everything

@karelhala , some follow-ups after I used your code snippet: after some small changes I did (that you can see here: https://paste.fedoraproject.org/paste/wMBI5aLdpZ2YRHtT~npLZV5M1UNdIGYhyRLivL9gydE=
) due to the fact that I gave you just some sample input, and not an exhaustive list of the possibilities, it happens that there's still some non working case, with the "not exists" operator which, unlike other operators, requires to write the tag key before the operator when outputing to string: "mytag" "doesn't exists" translates to NOT mytag.
So rather than coding some special behavior in the reduce function, I prefer to stick to my initial approach which is maybe less condensed, but IMO it shows the language rules more explicitly which is an advantage for understanding them.
BTW I added more unit tests since I discovered the "not exist" operator was not covered.

@jotak oh I see, no problem the reduce function was not readable as well, so no problem.

Thanks for the review Karel!


Update build.gradle

Allow change Kotlin version from project root settings
Closes #286 #281 #279 #277 #271 #268
In your root adroid/build.graddle you can specify kotlinVersion

When this PR will be merged?

@JordaoViktor This repo does not seem to be mantained anymore, there are no changes since 2021. I switched to a different library, see https://github.com/react-native-text-input-mask/react-native-text-input-mask/pull/280#issuecomment-1427498791

@mlazari Thank you!

Can we merge these changes?

@JordaoViktor you don't need to wait the update you can patch the package with this changes and it will work fine

Can we merge this PR plz?


libqalculate: 3.8.0 -> 3.9.0

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/qalculate/libqalculate/releases.
meta.description for libqalculate is: "An advanced calculator library"
meta.homepage for libqalculate is: "http://qalculate.github.io"
Updates performed:

Version update

Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.9.0 with grep in /nix/store/7mpq4rshlxgjnr4nv8hs319allmrddl0-libqalculate-3.9.0

directory tree listing: https://gist.github.com/af39cf77a0d42a4f6771043ec54221ed

du listing: https://gist.github.com/36d71df2777f65f16f5254857a136378

Rebuild report (if merged into master) (click to expand)

83 total rebuild path(s)
28 package rebuild(s)
28 x86_64-linux rebuild(s)
26 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
26 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
kde-cli-tools
kdeplasma-addons
kdev-php
kdev-python
kdevelop
kdevelop-unwrapped
kmenuedit
krohnkite
kwin-tiling
libqalculate
libsForQt5.khotkeys
libsForQt512.khotkeys
nasc
plasma-desktop
plasma-workspace
plasma5.kde-cli-tools
plasma5.kdeplasma-addons
plasma5.khotkeys
plasma5.kmenuedit
plasma5.plasma-desktop
plasma5.plasma-workspace
plasma5.powerdevil
plasma5.systemsettings
powerdevil
qalculate-gtk
rofi-calc
systemsettings
wacomtablet

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7mpq4rshlxgjnr4nv8hs319allmrddl0-libqalculate-3.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libqalculate https://github.com/r-ryantm/nixpkgs/archive/2078f2a0ee7d4712ddcc723daf5662cf9f039403.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7mpq4rshlxgjnr4nv8hs319allmrddl0-libqalculate-3.9.0
ls -la /nix/store/7mpq4rshlxgjnr4nv8hs319allmrddl0-libqalculate-3.9.0/bin

Result of nixpkgs-review 1

1 package marked as broken and skipped:
- linuxPackages_hardkernel_4_14.systemtap

1 package failed to build:
- nasc

18 packages built:
- kde-cli-tools
- kdeplasma-addons
- kdev-php
- kdev-python
- kdevelop
- kdevelop-unwrapped
- kmenuedit
- krohnkite
- kwin-tiling
- libqalculate
- plasma5.khotkeys (libsForQt5.khotkeys)
- plasma-desktop
- plasma-workspace
- plasma5.powerdevil
- plasma5.systemsettings
- qalculate-gtk
- rofi-calc
- wacomtablet

cc @gebner for testing.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixpkgs-update-runs-nixpkgs-review-on-every-pr/6701/1

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixpkgs-update-runs-nixpkgs-review-on-every-pr/6701/11

1 package failed to build:

nasc

Seems to truly break nasc and it's not broken on master. Output:
building
build flags: -j2 -l2 SHELL=/nix/store/ffli6m23501dkiznwlkf6n4xvrj02snr-bash-4.4-p23/bin/bash
Scanning dependencies of target qalculatenasc
[  5%] Building CXX object libqalculatenasc/CMakeFiles/qalculatenasc.dir/QalculateNasc.cc.o
/build/source/libqalculatenasc/QalculateNasc.cc: In function 'char* get_function_name(int)':
/build/source/libqalculatenasc/QalculateNasc.cc:38:13: error: 'string' was not declared in this scope; did you mean 'std::string'?
   38 |             string str = ename_r->name;
      |             ^~~~~~
      |             std::string

The problem seems to be a missing using namespace std;.
Perhaps the previous version of libqalculate brought that using in with an #include (that would be bad)?

Perhaps the previous version of libqalculate brought that using in with an #include (that would be bad)?

I can see no such thing in the upstream diff though. Somebody will have to take a detail look.

I opened an issue upstream: https://github.com/parnold-x/nasc/issues/145 .

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/how-can-i-be-more-useful-at-reviewing-pull-requests/6731/3

@jtojnar I'm pretty sure nasc builds fine now when the PR is rebased on latest master, I'm not sure how that got fixed but let's see:
@GrahamcOfBorg build nasc

ofborg's nasc's build was successful.


Adds flag to clean up cilium state before startup

Signed-off-by: Amey Bhide<EMAIL_ADDRESS>

@eloycoto @joestringer New PR for https://github.com/cilium/cilium/pull/3680; since ginkgo test gate wasn't getting triggered

test-me-please

test-missed-k8s

test-me-please

@eloycoto this PR still isn't getting picked up by Jenkins.

@eloycoto any idea why CI isn't picking this up?

@abhide15 it seems to have eventually run, but I suspect that this is a CI flake. I'll attempt to retrigger.

test-me-please

backport in https://github.com/cilium/cilium/pull/3953


Error: Failed fetching inputs: org.opensearch.OpenSearchSecurityException: no permissions for [indices:data/read/search] and associated roles

When deploying an alert and the monitor is triggered, the following error is seen: Error: Failed fetching inputs: org.opensearch.OpenSearchSecurityException: no permissions for [indices:data/read/search] and associated roles
The alert then goes into an error state and cannot be acknowledged.

Clone of this issue: https://github.com/opensearch-project/alerting-dashboards-plugin/issues/353


Code Helper running at 100% CPU

Issue Type: Performance Issue
My Macbook Pro turned into a space heater after the CPU was pegged out. The process that was running over 100% was Code Helper. This happened while VS Code did not have focus (I was using Chrome at the moment).

Here's some process Info
cwd
/
txt
/Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper
txt
/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework
txt
/Applications/Visual Studio Code.app/Contents/Frameworks/Squirrel.framework/Versions/A/Squirrel
txt
/Applications/Visual Studio Code.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/A/ReactiveCocoa
txt
/Applications/Visual Studio Code.app/Contents/Frameworks/Mantle.framework/Versions/A/Mantle
txt
/usr/lib/libSystem.B.dylib
txt
/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib
txt
/System/Library/Frameworks/IOKit.framework/Versions/A/IOKit
txt
/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libffmpeg.dylib
txt
/System/Library/Frameworks/AVFoundation.framework/Versions/A/AVFoundation
txt
/System/Library/Frameworks/CoreMIDI.framework/Versions/A/CoreMIDI
txt
/usr/lib/libsandbox.1.dylib
txt
/System/Library/Frameworks/CFNetwork.framework/Versions/A/CFNetwork
txt
/usr/lib/system/libdyld.dylib
txt
/usr/lib/system/libsystem_kernel.dylib
txt
/usr/lib/system/libsystem_sandbox.dylib
txt
/usr/lib/system/libkxld.dylib
txt
/usr/lib/libexpat.1.dylib
txt
/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/icudtl.dat
txt
/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/snapshot_blob.bin
txt
/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/natives_blob.bin
txt
/usr/lib/dyld
txt
/usr/share/icu/icudt57l.dat
txt
/private/var/db/dyld/dyld_shared_cache_x86_64h
0
->0x85804365c3c335e9
1
->0x85804365c3c33e81
2
->0x85804365c3c34651
3
->0x85804365c3c32c89
4
/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/icudtl.dat
5
->0x85804365be2f4589
6
->0x85804365be2f29c9
7
count=3, state=0x8
8
->0x85804365be2f4649
9
->0x85804365be2f2909
10
->0x85804365be2f4889
11
->0x85804365be2f2fc9
12
/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/snapshot_blob.bin
13
/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/natives_blob.bin
14
/dev/urandom
15
/dev/null
16
->0x85804365b2e34e19
17
->0x858043659a67e4b9
18
->0x85804365beba7589
19
/var/folders/vw/b6mdptss0rn3q6h3p4247g_ngjctjp/T/vscode-d6b7e6916e601fcfe937153579a61f3c91b36f61.sock
24
->0x85804365ba38ab61
25
/Applications/Visual Studio Code.app/Contents/Resources/electron.asar
26
/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar
27
/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar

VS Code version: Code 1.24.0 (6a6e02cef0f2122ee1469765b704faf5d0e0d859, 2018-06-06T17:30:30.113Z)
OS version: Darwin x64 16.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 2

Memory (System)
16.00GB (2.56GB free)

Process Argv
/Applications/Visual Studio Code.app/Contents/MacOS/Electron

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
   12	    98	 31071	code main
    0	   115	 31072	   gpu-process
    0	   246	 31073	   window (component.js — sa-ui)
    0	    98	 31248	     extensionHost
    0	    49	 31272	       electron_node jsonServerMain.js
  100	   246	 34066	       electron_node electronForkStart.js tsserver.js
    0	    66	 34071	         electron_node typingsInstaller.js tsserver.js typesMap.js
    0	    82	 34067	       electron_node eslintServer.js
    0	   115	 31249	     watcherService
    0	    66	 34068	     searchService
    0	    82	 31074	   shared-process
    0	    98	 37380	   shared-process
    0	     0	 37382	   /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=

Workspace Info
|  Window (component.js — sa-ui)
|    Folder (sa-ui): more than 51748 files
|      File types: js(36435) scss(3430) css(2393) json(1038) png(1029) md(831)
|                  hbs(688) gitkeep(677) map(628) html(515)
|      Conf files: package.json(573) gulp.js(13) jsconfig.json(12)
|                  launch.json(2) makefile(1) settings.json(1);

Extensions (11)

Extension
Author (truncated)
Version

ember-module-snippets
can
1.1.0

vscode-eslint
dba
1.4.12

vscode-babel-coloring
dza
0.0.4

emberjs
emb
1.0.1

vscode-ember
emb
0.2.0

json-tools
eri
1.0.2

vsc-ember-cli
fel
0.3.3

vscode-ember-snow
gtb
0.0.1

ember-related-files
jos
1.3.0

EmberES6Snippets
pha
2.3.3

ayu
tea
0.14.0

What is the deal with these crazy code helpers since the last update. My Macbook Pro's CPU is going over 100%. So frustrating ...

CPU %	Mem MB	   PID	Process
   12	    98	 31071	code main
    0	   115	 31072	   gpu-process
    0	   246	 31073	   window (component.js — sa-ui)
    0	    98	 31248	     extensionHost
    0	    49	 31272	       electron_node jsonServerMain.js
  100	   246	 34066	       electron_node electronForkStart.js tsserver.js
    0	    66	 34071	         electron_node typingsInstaller.js tsserver.js typesMap.js
    0	    82	 34067	       electron_node eslintServer.js
    0	   115	 31249	     watcherService
    0	    66	 34068	     searchService
    0	    82	 31074	   shared-process
    0	    98	 37380	   shared-process
    0	     0	 37382	   /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=

From the process info, it looks like the typescript server is causing the problem

I'm tempted to open a new issue but I'll just add to this one.
The only unhelpful reply I got was to use the 'Open Process Explorer' from the help menu to try and debug the problem
Well yet again my Code Helper in Activity Monitor was going at 99% CPU.. and I did use the Open Process Explorer and it was not helpful at all! See below screenshots! These were taken at the same time!

@gtb104 Please test in the latest vscode insiders build with all extensions disabled. If you still see the issue, try upgrading your workspace to typescript@next by following these instructions

@mjbvz It happens to me a lot on mac with all versions including the very last insider build.
It mostly happens with projects with very big .d.ts files.
I can almost always reproduce it after working for a while with nativescript projects.  They use an android.d.ts which is really big.

@mjbvz is there any way to get a tsserver log file? I am having the issue right now. If i could enable a log and get it for you i think it would greatly help

To collect the TS Server log:

Set "typescript.tsserver.log": "verbose",
Restart VS Code and reproduce the problem
In VS Code, run the TypeScript: Open TS Server log command
This should open a folder with a tsserver.log file in it

Look though that log file for errors or stack traces. If you can share the log, I can also take a look to see if anything stands out

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this

@mjbvz just facing it right now. CPU to 100%, vscode stuck searching after trying to click on a reference to open it.
Here is my log file. I hope you will find something
tsserver.log

I am experiencing this issue too on my macbook and imac, both running macOS HS 10.13.5. The process continues even when VSCode is closed.

so how to fix

Had the same issue across multiple OSs and multiple projects and this is the only thing that has helped. The article says to disable all extensions, quit VS Code, and turn them on one by one. Make sure to kill the "code helper" process manually before reloading VS Code each time. Quitting VS Code did not kill the process on my machine. For me, a file icon extension caused the issue.

@farfromrefug Thanks. I don't see anything suspicion in the TS server log. Can you check the full process arguments of the process that has the high cpu usage. Is it the tsserver one?
Also test in VS Code insiders to make sure this is still happening with the latest changes

@mjbvz always using the latest insider !
here is the ps aux result:
mguillon         20445 100.0  1.3  5813140 213952   ??  R    11:24AM  70:04.45 /Applications/Visual Studio Code - Insiders.app/Contents/Frameworks/Code - Insiders Helper.app/Contents/MacOS/Code - Insiders Helper /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript-language-features/out/utils/electronForkStart.js /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /var/folders/0v/_p69syd96plgy916gb3rcqxm0000gn/T/vscode-tscancellation-e0c55c1261ef6b5976d3.sock* --locale en --noGetErrOnBackgroundUpdate

This is happening specially when I'm opening multiple instances of VSCode. 3 projects open and I got at least 15 different Code Helper processes, all of them running at 100% (or more).

@mjbvz any news on this?
I think you should try to reproduce this. And I think it is doable:

clone https://github.com/Akylas/nativescript-bluetooth
open in vscode
run npm install within the plugin folder
go into plugin/src/android.
now the thing is just to play with it, asking for definition, waiting for pop over, and things like that.
what will put is the big android def file. You can go into it by going to definition for any android.*
That should bring you to android.17.d.ts. That's the big one.

Now I am not sure how fast this will happen but it should. Also as @LeonardoBraga I don't know for sure if it is related to multiple windows. I mostly always have a few opened.

Here the same
Version 1.25.1 (1.25.1)
Mac OS X 10.13.6
no TS only JavaScript

Version: 1.25.1
Debian GNU/Linux buster/sid
No plug-ins, POJS.  Started with the installation of 1.25.0

Version: 1.25.1
Mac OS X 10.13.6
On any type of file, after working for a while it takes a few seconds to save a single file. (This also excludes the fact my laptop turns into a space heater once it starts doing this.) A restart fixes it, but it comes back after a while again.

Mac OSX 10.13.3 (17D47)
Version: 1.26.0-insider (1.26.0-insider) - but its happening for about 8 months...
File 200+ lines in a medium+- TS project - any change / autocomplete /save causes 99% CPU FOREVER.
tried debugging it for 8 hours it seems like many props on an item in a big file cause it to slow down until eventually, it fails.
I can now reproduce it on a whim, but can't do my job and write new code AT ALL.
for the time being, I'm going back to IntelliJ but I'm looking forward for a fix.
I'd be happy to assist if anyone wants to fix it...

This one seems to be related https://github.com/Microsoft/vscode/issues/55070

For those who are not using TS. It could be Import Cost plugin.
Here's the issue https://github.com/wix/import-cost/issues/35
Disabling Import Cost completely reduced Code Helper %CPU from 100 to 5.
Until that issue is fixed I would be disabling Import Cost.

Don't have Import Cost installed and still experiencing the issue.

Same.
I managed to reproduce this without any plugin enabled / installed.
On Fri, Aug 17, 2018 at 11:56 AM Makan Dey<EMAIL_ADDRESS>wrote:

Don't have Import Cost installed and still experiencing the issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/51776#issuecomment-413802275,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFl9RGP6lBVSyGz338JJhmMf_H0QzZKuks5uRoVOgaJpZM4UmbvI
.

I'm not sure if it's 100% related to this bug, but I can reproduce this by running npm install on my Node projects while I have the project folder open in VS Code.  I suspect that the Code Helper goes crazy trying to index all of the new files that npm is creating.

I don't use TypeScript and I don't have the Import Cost plugin, but sometimes I have the same issue with Code Helper going wild on one of the CPU cores and the culprit is electron_node index.js judging by the process explorer. When this happens to me, I notice there's a progress bar under the explorer label (the one on top of the side bar) running continuously even when there's no file or folder open in the editor. As soon as I kill electron_node index.js from the process explorer, Code Helper stops and the progress bar disappears. Last time happened yesterday, with vscode version 1.26.0 running on macOS 10.12.6.

@MastaCoder Thanks.  My issue went away when I uninstalled Import Cost.

Probably a TS Server hard bug they can't fix, or maybe a fix that hasn't been released yet.
To temporarily get around this until they have a fix, I turned on logging like the @mjbvz said, figure out which file it is croaking on, add that file or set of files to my "files.exclude", "files.watcherExclude" lists.

i try to set the 'file.excludes' items but it does not work, then i uninstall the tslint extension, seems the problem fixed now.

My vscode does not have an extension installed and is consuming 100% CPU in MacBook Pro

Same here. I constantly have to force quite "Code Helper" which is using 100% CPU on my MacBook using the latest (1.26.1) version.

I'm experiencing this issue is well. My installed extensions are:
Auto Close Tag
Babel ES6/ES7
Document This
ESLint
Flow Language Support
HTML CSS Support
Prettier
Settings Sync
stylus
TODO Highlight
WakaTime

I've been having the same issue. My hunch is ESLint and Prettier but I'm not sure.

[UPDATE] This has helped immensely (though it does still run around 20-30% after running for a while):
	"files.watcherExclude": {
		"**/node_modules/*/**": true
	},
	"eslint.autoFixOnSave": true,
	"eslint.run": "onSave",
	"eslint.provideLintTask": false,
	"[javascript]": {
		"editor.formatOnSave": true,
	},
	"typescript.validate.enable": false,
	"javascript.validate.enable": false,
	"files.watcherExclude": {
		"**": true
	},
	"files.useExperimentalFileWatcher": false,
	"git.ignoreLimitWarning": true

The most effective changes were disabling continuous validation, limiting the watcher and disabling files.useExperimentalFileWatcher.

Doesn't seem to work.  I have node_modules in my exclude and watcherExclude list, but still scanning that directory.
   "**/node_modules/**": true

useExperimentalFileWatcher is false by default.
I'm going back to Vim until the next VSCode release comes out.

This message is probably useless for those who will be debugging the issue. But anyways here's "workaround" I made to keep using vscode.
I removed vscode as well as all it's settings and all plugins.
I installed it from scratch and added some most important plugins I use.
Below is current config I use:
{
  "workbench.colorTheme": "One Dark Pro",
  "editor.fontSize": 14,
  "workbench.editor.enablePreview": false,
  "editor.rulers": [80],
  "workbench.iconTheme": "vscode-icons",
  "prettier.eslintIntegration": true,
  "editor.formatOnPaste": false,
  "editor.formatOnSave": true,
  "editor.formatOnType": false,
  "flow.useNPMPackagedFlow": true,
  "javascript.validate.enable": false,
  "jest.showCoverageOnLoad": true,
  "[yaml]": {
    "editor.formatOnPaste": false,
    "editor.formatOnType": false,
    "editor.formatOnSave": false
  },
  "window.zoomLevel": 0
}

and extensions I installed again
dbaeumer.vscode-eslint
eamodio.gitlens
esbenp.prettier-vscode
flowtype.flow-for-vscode
ms-vsliveshare.vsliveshare
Orta.vscode-jest
robertohuertasm.vscode-icons
vscodevim.vim
zhuangtongfa.Material-theme

here is what my original config looked like and list of original extensions:
{
  "gitlens.advanced.messages": {
    "suppressShowKeyBindingsNotice": true
  },
  "workbench.colorTheme": "One Dark Pro",
  "editor.rulers": [80],
  "editor.formatOnPaste": true,
  "editor.formatOnSave": true,
  "editor.formatOnType": true,
  "prettier.eslintIntegration": true,
  "workbench.iconTheme": "vscode-icons",
  "window.zoomLevel": 0,
  "editor.fontSize": 14,
  "workbench.editor.enablePreviewFromQuickOpen": false,
  "workbench.editor.enablePreview": false,
  "editor.formatOnSaveTimeout": 5000,
  "gitlens.blame.ignoreWhitespace": true,
  "todo-tree.showInExplorer": false,
  "docker.showExplorer": false,
  "[xml]": {
    "editor.formatOnPaste": false,
    "editor.formatOnSave": false,
    "editor.formatOnType": false
  },
  "workbench.sideBar.location": "left",
  "editor.largeFileOptimizations": true,
  "flow.enabled": true,
  "flow.useNPMPackagedFlow": true,
  "eslint.autoFixOnSave": true,
  "javascript.validate.enable": false,
  "editor.minimap.enabled": false,
  "eslint.enable": true,
  "liveshare.guestApprovalRequired": true,
  "flow.showUncovered": false
}

RoscoP.ActiveFileInStatusBar
alexkrechik.cucumberautocomplete
dbaeumer.vscode-eslint
DotJoshJohnson.xml
eamodio.gitlens
emilast.LogFileHighlighter
esbenp.prettier-vscode
flowtype.flow-for-vscode
formulahendry.auto-close-tag
formulahendry.auto-rename-tag
Gruntfuggly.todo-tree
ionutvmi.path-autocomplete
jdforsythe.add-new-line-to-files
jpoissonnier.vscode-styled-components
mikestead.dotenv
ms-python.python
ms-vscode.cpptools
ms-vscode.Go
ms-vscode.node-debug2
ms-vsliveshare.vsliveshare
msjsdiag.debugger-for-chrome
Orta.vscode-jest
patrys.vscode-code-outline
PeterJausovec.vscode-docker
redhat.java
robertohuertasm.vscode-icons
sadesyllas.explorer-excluded-files
shd101wyy.markdown-preview-enhanced
sleistner.vscode-fileutils
tomphilbin.lodash-snippets
vscjava.vscode-java-debug
vscjava.vscode-java-pack
vscjava.vscode-java-test
vscjava.vscode-maven
vscodevim.vim
vsmobile.vscode-react-native
wayou.vscode-todo-highlight
wix.vscode-import-cost
yaruson.ascii-unicode-escape
yzhang.markdown-all-in-one
zhuangtongfa.Material-theme

Closing this issue as it has become a catch-all for many unrelated performance problems and we never heard back from @gtb104
If you are still seeing performance issues, please open a new issue so we can investigate your problem individually

@mjbvz, sorry, I seem to have missed the notification for this issue. I just upgraded to 1.27.2. If I see any issues I'll open a new issue.

I had this issue a couple days ago. It went away when I uncommented "typescript.validate.enable": true in my global settings, altho I wasn't even working in a typescript project - no tsconfig / jsconfig.

I had the same issue: Code Helper using 100+% CPU when large projects are open, even when all extensions were disabled. The problem is completely gone now that I turned on "Use Experimental File Watcher" which excludes node_modules from the watch list... (in "files.watcherExclude" property)

I think it's safe to presume the latest update has caused this.

Disabling extensions is not enough. I solved it by uninstalling ms-vscode.csharp en then reinstalling. Plays nice at around 0.4% now.

I think Code Helper is kind of a shared lib that get's instantiated several times, once per each installed extension that requires/uses it (or not, and i can be totally wrong!).
That's why several users reported the problem got solved when they disabled extension X or Y.
In my case: after several hours facing 99% CPU loading and fiddling with a minimum set of extensions, and even enabling/disabling some extensions settings, I found out that the culprit was the Settings Sync extension.
When I set sync.autoUpload=false all other extensions run nicely and Code Helper started to behave and not stressing out CPU anymore.
Reporting this to extension authors.

I'm locking this issue because it is not the correct place to report these problems. If you are seeing a bug with high cpu usage, please open a new issue and we will continue to investigate.
High cpu usage usage is a symptom with a very large number of potential root causes, so it usually must be investigated on a case-by-case basis. We will mark your issue as a duplicate if needed