Add PriorityClassName as option to Keycloak

Small addition, we need to set priorities for a couple of our deployments, such as keycloak.
@unguiculus
What this PR does / why we need it:
It adds PriorityClassName as a field to the values and template, this allows us to prioritize keycloak deployment over other applications on our cluster, as they depend on keycloak for logging in anyway.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/ok-to-test

/lgtm


Fix rotate/renew old oauth

This PR closes: #1325 #1458 probability #1181, but not #1211

Coverage decreased (-2.9%) to 70.882% when pulling 6200c4bccd87245a1c3f5b8a7fcdcf7ccddfda0b on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage decreased (-2.9%) to 70.882% when pulling 9db41e53b474a4e18b94c915b24afb66b958ccea on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage decreased (-3.02%) to 70.781% when pulling 9db41e53b474a4e18b94c915b24afb66b958ccea on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+1.0%) to 74.789% when pulling<PHONE_NUMBER>ea832ab0211f698350a3f4bcc37b94 on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+1.0%) to 74.789% when pulling ca747b5870125c0435df287d8f1a1b8c14d7fd8e on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+0.2%) to 74.008% when pulling 84301dcb9be834c710d352c3f946297e744715ab on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+0.9%) to 74.671% when pulling 84301dcb9be834c710d352c3f946297e744715ab on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+1.06%) to 74.864% when pulling 5e4918ef0280290182b6651029126b575931f27a on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+1.05%) to 74.849% when pulling 947fcc0d638d24a4695e5e175a4e5b87759c6c2e on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+1.05%) to 74.849% when pulling 947fcc0d638d24a4695e5e175a4e5b87759c6c2e on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+1.05%) to 74.849% when pulling 7c45400f91be918956f31b73353e1bbf06ed968e on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+1.05%) to 74.849% when pulling 7c45400f91be918956f31b73353e1bbf06ed968e on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+1.05%) to 74.849% when pulling 7c45400f91be918956f31b73353e1bbf06ed968e on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage increased (+1.05%) to 74.849% when pulling db119d4420372bd917a2f1e7382366b71ac70c1c on vxcamiloxv:fix-rotate-old-oauth into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.


Sayyaf69sy

What article on docs.github.com is affected?

What part(s) of the article would you like to see updated?

Additional information

#6145
Duplicate of # @S69y

#6145
Скачайте Outlook для Androidhttps://aka.ms/AAb9ysg

From: Sayyaf69 @.>
Sent: Saturday, June 26, 2021 4:45:57 AM
To: github/docs @.>
Cc: echkavs @.>; Comment @.>
Subject: Re: [github/docs] Sayyaf69sy (#6052)
#6145https://github.com/github/docs/issues/6145
Duplicate of # @S69yhttps://github.com/S69y
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/github/docs/issues/6052#issuecomment-868924760, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APRAUQ3JTUEWXCBXUWOS3X3TUUWNLANCNFSM44E7KJIQ.

@S69y
Скачайте Outlook для Androidhttps://aka.ms/AAb9ysg

From: Rik Dima @.>
Sent: Sunday, June 27, 2021 3:36:45 PM
To: github/docs @.>; github/docs @.>
Cc: Comment @.>
Subject: Re: [github/docs] Sayyaf69sy (#6052)
#6145
Скачайте Outlook для Androidhttps://aka.ms/AAb9ysg

From: Sayyaf69 @.>
Sent: Saturday, June 26, 2021 4:45:57 AM
To: github/docs @.>
Cc: echkavs @.>; Comment @.>
Subject: Re: [github/docs] Sayyaf69sy (#6052)
#6145https://github.com/github/docs/issues/6145
Duplicate of # @S69yhttps://github.com/S69y
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/github/docs/issues/6052#issuecomment-868924760, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APRAUQ3JTUEWXCBXUWOS3X3TUUWNLANCNFSM44E7KJIQ.


Restrict constant lookup

  # When a constant with a name matching nested attribute :data exists
  Data = Module.new

  module Namespace
    class Struct < Dry::Struct
      attribute(:data) do
        attribute(:num, Dry::Types::Integer)
      end
    end
  end # => Dry::Struct::Error

Dry::Struct::Error: Can't create nested attribute - Namespace::Struct::Data already defined
This pr restricts constant lookup to class scope Dry::Struct::StructBuilder#check_name

Doesn't https://github.com/dry-rb/dry-struct/pull/92 solve the same issue?

@flash-gordon Ahh, right. Did not see that. Regardless, this is PR is 7.4x. Your call.
  Other = Module.new
  Test = Module.new
  Test::Struct = Class.new

  require 'benchmark/ips'
  Benchmark.ips do |x |
    x.report 'restrict traversal' do
      Test::Struct.const_defined?(:Other, false)
    end

    x.report 'qualify constant name' do
      Object.const_defined?("#{Test::Struct.name}::#{:Other}")
    end

    x.compare!
  end

  # Warming up --------------------------------------
  #   restrict traversal   422.852k i/100ms
  # qualify constant name
  #                       131.759k i/100ms
  # Calculating -------------------------------------
  #   restrict traversal     12.787M (± 1.8%) i/s -     64.274M in   5.028142s
  # qualify constant name
  #                           1.733M (± 1.9%) i/s -      8.696M in   5.020003s
  #
  # Comparison:
  #   restrict traversal: 12787405.8 i/s
  # qualify constant name:  1732944.0 i/s - 7.38x  slower

Fix #91. @PikachuEXE the docs also explain that when const_defined?(:Constant, inherit = false) the lookup is performed within the receiver scope. I submitted #94 not realising you'd already submitted #92. Per benchmarks submitted in #94 you'll find disabling traversal is much faster. There is now a third PR #95 submitted by @jviney. @flash-gordon Is there any plan to merge?

I will take a look, matter of days

If there is a benchmark then just merge the fastest one :)

Will this be merged?


Update notification window doesn't respond to clicks

I just got a notification "Updates for HidHide are available". There are two problems with this window:

the window is tiny (looks like it's rendered at 96 DPI without scaling; my screens are set to 216 DPI)
the window does not respond to clicks anywhere, though I can drag it around

According to Programs and Features I have HidHide 1.5.212 installed at the moment.
Steps to reproduce
Just wait for the updater window to appear

OK I did some digging and it appears that SFML needs to be configured properly to support DPI awareness and the developer has to react accordingly to scale everything. Interesting. @jernejs can you share your settings so I can replicate them, Screenshots or whatever shows how your monitor is set up.

I've got two 27″ 5120x2880 monitors, both are set to 225% DPI in Windows; not sure if it matters, but I also use High Contrast mode. Here's a screenshot of my Display Settings:

Also, I need to amend my report – after I sent the bug report, the updater started responding to clicks, though I have no idea why (I tried clicking everything first, including the Cancel button, but the only response was dragging the window when I did that near the top; dragging also wasn't working quite properly – it'd lose tracking fairly quickly; after I moved the window to the left side of my monitor, I noticed that "Display update details now" started responding to mouse hovering, after which I was able to click it and proceed with the update).

Partially good news then. Still the DPI topic is on my TODO anyway.

Some research resources:

DPI-aware IMGUI
DPI awareness on Windows
DPI-Scaling on Windows

Also opened an issue about this over at imgui-sfml, fingers crossed 🤞

Small progress but oh dear, what have I unleashed 🤯

Another example implementation to look at 😃

Progress! 🥳
Tested at 150%:

@jernejs once I have a test build would you be available to help testing with your system and give feedback about the look and feel?

@jernejs once I have a test build would you be available to help testing with your system and give feedback about the look and feel?

Sure.

@jernejs once I have a test build would you be available to help testing with your system and give feedback about the look and feel?

Sure.

Neat! So in case you already updated HidHide to the latest version, first run this in an elevated PowerShell/Terminal:
Set-ItemProperty -Path 'HKLM:\SOFTWARE\Nefarius Software Solutions e.U.\HidHide' -Name Version -Value "1.4.0" -Force

Next download and run this build and share screenshots and your opinion on how it scales, and maybe even a video clip of navigating through the pages.
Cheers

Looks fine now:

Also no problems with clicking the buttons, though trying to move the window still loses tracking sometimes.

Very cool, thanks for testing! I will see if I can improve the dragging situation further.

Related to #54
@jernejs I also fixed (at least on my end) the focus problem (buttons not clickable on first window launch), could you help me test nefarius_HidHide_Updater.zip please, thx.

I've got a bit of a problem – after installing the previous test version, HidHide Updater kept popping up every time I started Windows (and it did this even if I let it update), so I finally had enough and uninstalled HidHide yesterday; now when I try running the new updater, I get:

Somewhat related, I've always had problems updating HidHide – it always requires a restart, and unless I let it restart immediately, it never managed to update.

Yeah that message is expected; the product to check is not present on the system.
To have HidHide update successfully you must let it reboot whenever it asks you to. This will eventually be fixed in the future, there are open issues about it, but I do not have the time to tackle this right now.
Back to topic; if you just install an older version of HidHide normally and then invoke the exe I uploaded, it should immediately work navigating in it.


Possible race condition

Weird build exception initialize must be called for meta class of class
Expected Behavior
Task succeeds

Current Behavior
I am experiencing weird build error time to time (~1-2% of builds are failed):
18:52:50 Execution failed for task ':module1:unpackTars'.
18:52:50 > initialize must be called for meta class of class build_4eob1vc78iegmx7jkwtg7hvqr$_run_closure14$_closure50$_closure82$_closure83(class org.codehaus.groovy.runtime.metaclass.ClosureMetaClass) to complete initialisation process before any invocation or field/property access can be done

task implementation is pretty simple:
    task unpackTars {
        doLast {
            configurations.tars.files.each {
                tarFile ->
                    copy {
                        from(tarTree(tarFile)) {
                            dirMode 0755
                        }
                        into stageFolder
                    }
            }
        }
    }

Gradle 3.2.1
OS: Debian 6.0
JVM: Oracle SDK 1.8
Gradle build has around 50 modules and runs with --parallel
Jenkins server has 32 CPU cores and 128GB RAM, parallel build usually starts 32 threads
It seems like execution phase starts before configuration has been finished

Context

Steps to Reproduce (for bugs)
There are no steps to reproduce it, issue is intermittent

Your Environment

Build scan URL:

@john-auden Are you using --configure-on-demand or any other flags?

Good morning,
We have few environments building different branches of the same application, some of them use --parallel --configure-on-demand, though I can't tell you if it correlates. I will try to disable everything, but --parallel to recheck. I am sorry there is no easy way to reproduce, so I'll have to just wait.

@john-auden It's possible for execution to begin before configuration completes when using --configure-on-demand. Note that both of these flags are @Incubating, though we are working hard to get them perfectly stable.

I have just got a build failure with the same error, verified start options.

Thanks for checking. Do you think you might be able to put together a (somewhat) reproducible example project?

Hardly. We have a 6GB codebase with 50+ modules, so don't have any ideas how to replicate it in test project. BTW, thanks, with parallel build and fast host it takes ~4mins to build 4GB of artifacts

I would try tweaking your extract task a bit:
task unpackTars(type: Sync) {
    dependsOn configurations.tars

    from {
        configurations.tars.files.collect {
            tarTree(it)
        }
    }
    into stageFolder
    dirMode 0755
}

Otherwise, you're creating lots and lots of anonymous classes to handle extracting each tar when there are lots of tars in configurations.tars.

Thanks, I will definitely check it, though there are 1-2 tars in this configuration.

I have the theory, it happens since I changed something in Jenkins, where now I start building two subprojects from the same root project concurrently (at the same time). Before, everything from the Jenkins POV was serialized (still parallel =true in gradle) I never saw this problem.
Sadly it is also hard for me to extract a reproducible example. Big and complex buildSrc and many projects.
I ll run the build with --stacktrace, and let you know next time it happens.

I have the theory, it happens since I changed something in Jenkins, where now I start building two subprojects from the same root project concurrently (at the same time). Before, everything from the Jenkins POV was serialized (still parallel =true in gradle) I never saw this problem.
Sadly it is also hard for me to extract a reproducible example. Big and complex buildSrc and many projects.
I do have the full stacktrace:

Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':mycompany_module_extras:generic:user_management:JAASUserAuthentication:jar'.
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:98)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:68)
at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)
at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)
at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)
at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)
at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)
at org.gradle.internal.Transformers$4.transform(Transformers.java:169)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)
at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)
at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)
Caused by: java.lang.IllegalStateException: initialize must be called for meta class of class com.mycompany.build.mycompanyPluginConvention$_configureBuild_closure4$_closure27(class org.codehaus.groovy.runtime.metaclass.ClosureMetaClass) to complete initialisation process before any invocation or field/property access can be done
at com.mycompany.build.mycompanyPluginConvention$_configureBuild_closure4$_closure27.doCall(mycompanyPluginConvention.groovy:218)
at org.gradle.api.internal.AbstractTask$ClosureTaskAction.execute(AbstractTask.java:656)
at org.gradle.api.internal.AbstractTask$ClosureTaskAction.execute(AbstractTask.java:637)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.execute(ExecuteActionsTaskExecuter.java:115)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.execute(ExecuteActionsTaskExecuter.java:109)
at org.gradle.internal.Transformers$4.transform(Transformers.java:169)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:109)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:90)
... 20 more

I have same issue on copy operation in multi module project with parallel execution (about 30%-40% of builds)

@grolfcry Please use code snippet proposed by @big-guy. It worked for me.

I hit this with a fairly simple copy-type task, using configureondemand + parallel.
task buildFeature {
    dependsOn configurations.feature
    inputs.file("${project.projectDir}/src/main/feature/feature.xml")
    outputs.file("${project.buildDir}/feature.xml")
    doLast {
        // The resolved version of the sdk dependencies is dynamic, so create a nested map of
        // resolved {group} -> {artifact-name} -> {version} data for reference in the feature.xml.
        def versions = configurations.feature.resolvedConfiguration.getFirstLevelModuleDependencies()
                .stream().collect(
                    Collectors.groupingBy({it.moduleGroup},
                            Collectors.toMap({it.moduleName}, {it.moduleVersion})));
        copy {
            from file("${project.projectDir}/src/main/feature/feature.xml")
            into "${project.buildDir}"
            expand(project.properties + [ "versions" : versions ])
        }
    }
}

I couldn't use the copy task, because I wanted to pass the versions of resolved configurations in expand.
Gradle 4.3.1,

I hit the same problem with parallel + configureondemand. We had to turn it off. The odd thing is it would only occur on our TeamCity (a build system) on a VM. Never locally. No reliable way to recreate. This is obviously a race condition.
Stuff happens. gradle is great. I'm not complaining but warning others.
Regards,
Steve

Folks should usually avoid using configure-on-demand, in general, because it rarely provides performance benefits. We'll be working on other ways to improve configuration time.

I see. Thanks for the response. I/We appreciate it.

We have turned off configureondemand, but we are still occasionally seeing this error.
our gradle.properties looks like this:
org.gradle.jvmargs=-Xmx1536m -Dfile.encoding=UTF-8
org.gradle.caching=true
org.gradle.parallel=true
org.gradle.configureondemand=false
org.gradle.daemon=true

Looks like I've ran into the same problem:
// dependencies.gradle
String max2017SdkPath = "${project.ext.sdkDirectory}/maxsdk2017"
HashMap max2017Libraries = [
  bmm             : 'bmm.lib',
  core            : 'core.lib',
  geom            : 'geom.lib',
  gfx             : 'gfx.lib',
  mesh            : 'mesh.lib',
  maxutil         : 'maxutil.lib',
  maxscrpt        : 'maxscrpt.lib',
  morpher         : 'Morpher.lib',
  poly            : 'Poly.lib',
  paramblk        : 'Paramblk2.lib',
  assetmanagement : 'assetmanagement.lib',
]

model {
  repositories { // this is a 128 line in the origin file
    libs(PrebuiltLibraries) {
      max2017Libraries.each { name, path ->  // this is a 400 line in the origin file
        libs.create(name) {
          String max2017HeadersPath = "${max2017SdkPath}/include"
          headers.srcDirs max2017HeadersPath,
            "${max2017HeadersPath}/xref",
            "${max2017HeadersPath}/maxscript",
            "${max2017HeadersPath}/maxscript/macros",
            "${max2017HeadersPath}/maxscript/foundation",
            "${max2017HeadersPath}/maxscript/maxwrapper",
            "${max2017HeadersPath}/maxscript/mxsplugin"
          String max2017LibPath = name == 'morpher' ? "${max2017SdkPath}/samples/modifiers/morpher/Lib/x64/Release"
            : "${max2017SdkPath}/lib/x64/Release"
          binaries.withType(StaticLibraryBinary) {
            staticLibraryFile = file("${max2017LibPath}/${path}")
          }
        }
      }
    }
  }
}

D:\path\to\project> gradlew mainVisualStudio -PpureGradle
Starting a Gradle Daemon (subsequent builds will be faster)
Parallel execution is an incubating feature.
> Task :foliage_exporter:foliage_exporter_mainDllVisualStudioProject FAILED

FAILURE: Build failed with an exception.

* Where:
Script 'D:\path\to\project\gradle\dependencies.gradle' line: 400

* What went wrong:
Execution failed for task ':foliage_exporter:foliage_exporter_mainDllVisualStudioProject'.
> Exception thrown while executing model rule: repositories { ... } @ gradle\dependencies.gradle line 128, column 3
   > initialize must be called for meta class of class dependencies_5cwmil6twuutfnbbzojw986yk$_run_closure1$_closure2$_closure3$_closure25$_closure65(class org.codehaus.groovy.runtime.metaclass.ClosureMetaClass) to complete initialisation process before any invocation or field/property access can be done

I've tried to reproduce it with --stacktrace switch but no luck - any further builds were successful
------------------------------------------------------------
Gradle 4.10.2
------------------------------------------------------------

Build time:   2018-09-19 18:10:15 UTC
Revision:     b4d8d5d170bb4ba516e88d7fe5647e2323d791dd

Kotlin DSL:   1.0-rc-6
Kotlin:       1.2.61
Groovy:       2.4.15
Ant:          Apache Ant(TM) version 1.9.11 compiled on March 23 2018
JVM:          1.8.0_171 (Oracle Corporation 25.171-b11)
OS:           Windows 10 10.0 amd64

Also affects gradle 5.6 with --parallel

Just got this with Gradle 6.2 with --parallel as well.

Confirmed by rewriting build logic: This is a race condition on access to the internals of Closure. We are no longer affected by this bug, but it is valid.
I think the race may be related to accessing the internals of a lexically-outer closure when the lexically inner closure is called asynchronously to the outer closure, e.g. an afterConfigure callback, etc.

Bad bot, this should stay open and be fixed

Unfortunately, from all the comments it is unclear what the issue to fix is here.
Some of the shared samples have incorrect build logic (e.g. all configurations that are resolved should be declared as input).
If this is a general underlying problem, can someone please share a reproducer for that.
For now I assume that what this about. I adjusted the title and categorised this as a "groovy-dsl" bug. But we need clearer information to act on it.

maybe it just requires a better explanation of the problem / cause? i've had and worked around the issue, but never thought of either the racey or workaround groovy logic as 'incorrect'. Maybe its not clear to people when they are doing something incorrectly?
is this incorrect?
task buildFeature {
...
    doLast {
...
        copy {
            from file("${project.projectDir}/src/main/feature/feature.xml")
            into "${project.buildDir}"
        }
    }
}

if its the internals of a lexically-outer closure when the lexically inner closure is called asynchronously to the outer closure im not quite sure what that means =)

That looks like correct build logic. If that is enough to reproduce the issue - thanks for sharing @nhoughto


TOMEE-2495 - Translate to portuguese: examples/jpa-eclipselink

JIRA ticket https://issues.apache.org/jira/browse/TOMEE-2495

It's very good for me.
only an change :
change README_PT.adoc  to README_pt.adoc
thanks @marcoantoniobferreira

Thanks Daniel, change made.

great @marcoantoniobferreira  thanks.

Hi @marcoantoniobferreira
Thank you for your contribution, in order to move forward this PR please open an email thread on the mailing list to make reference to both the Jira and the PR.
In this way, we collaborate with the committers to move forward the contributions and follow the Apache Way "If it didn't happen on a mailing list, it didn't happen." [1] along with the recommended Apache TomEE Workflow [2].
[1] https://community.apache.org/newbiefaq.html#NewbieFAQ-IsthereaCodeofConductforApacheprojects?
[2] http://tomee.apache.org/community/contributing/workflow.html

Ok @cesarhernandezgt! Thanks for the tip!


Documentation: Grid should be an example, not a style

It seems to me that the styles section of the documentation is for learning about all the available utilities, and then examples shows how you can compose multiple utilities to make cool stuff.
I've now seen a couple of developers get confused when they try to figure out grids—and can't get their head around what's special about the md:w-1/3 class that makes it suitable for grids, and what other "grid utilities" are available.
I wonder whether this is a result of grid being listed in the styles section of the docs. Shouldn't grid be categorized under examples? It just composes flex, sizing and responsive utilities – it's no more a part of Tailwind than buttons or alerts are.
Or, if not, a note in the grid docs to explain that it's just comprised of whatever flex and sizing and responsive utilities you want to use.

Yep improving this has been on my radar for a while but just no time to do it yet. Definitely want to move it to examples and change all of the examples to look like all the other code examples in the docs; the grid docs were actually one of the very first things I quickly hacked out before we had any patterns in place for how we were going to do things.
I'll see if I can improve this today.


Azure Redis should support managed identity

Similar to Azure PostgreSQL should support managed identity (dotnet/aspire#5793), we should support managed identity when publishing an Azure Cache for Redis resource.
Proposal
Add a new enum that gets passed into .[Publish]AsAzureRedis() that switches which kind of auth is used.
namespace Aspire.Hosting.Azure;

public enum AzureRedisAuth
{
    Password = 0,
    ActiveDirectory = 1 // Note the name used in bicep and ARM is `aad-enabled`
}

// user code
builder.AddRedis("cache")
    .PublishAsAzureRedis(AzureRedisAuth.ActiveDirectory);

cc @mitchdenny @davidfowl @tg-msft @sebastienros @radical

We might need to use https://github.com/Azure/Microsoft.Azure.StackExchangeRedis for this

We might need to use https://github.com/Azure/Microsoft.Azure.StackExchangeRedis for this

Yes, that is what the actual app that connects to Azure Cache for Redis would need to use to authenticate. This is the reason why I'm not proposing to make ActiveDirectory auth the default, because it would break apps that didn't use Microsoft.Azure.StackExchangeRedis. This is similar to PostgreSQL in #5793.

Note the above proposed API wasn't implemented. See #5966 for a discription of the approved API.


Convert url mapping to include the topic + operation in the url …

... rather than payload, for aca-py backend.  (Should also work for VCX and Pico but not tested.)
Signed-off-by: Ian Costanzo<EMAIL_ADDRESS>Also added support for url with & without the trailing slash for all url mappings
Note - kept the csv file (for now) that defines the allowable topic/operation combinations.  We can revisit this when we build in the swagger functionality.

The tests are also updated.  We can merge this now, it will break the .NET backchannel until they convert it over to the new urls

I only see updates in the backchannel for acapy.  What am I missing?

https://github.com/bcgov/aries-agent-test-harness/pull/69/files#diff-ead3ad85667e11f46c1ce15f090dfc53

Doh...even on the second look I didn't notice the test-harness.  I was thinking it was the base class and specific.  :palm:

BTW - are we paying by the line of code?  That was a big change with very little code to show for it...
:-)

$1 per line of code changed, $10k for knowing which lines to change


Cannot Access prlint.json in forks

When a PR is made from the fork to the original repo, the error ".github/prlint.json not found" is displayed despite that file being present in the fork.
My guess is that PRLint does not have permission to access the file in the forked repo? Is there anything we can do to fix this? Many github work flows rely on creating PRs from forks.

Interesting, definitely a case I hadn't considered.
If the fork is public then it's probably trivial to fix this. If the fork is private, I'll have to verify if GitHub's API will allow PRLint to access it's contents. My guess is that the answer is no... Just because you forked a project, doesn't mean you consent to letting all of it's connected apps have access to your new files/source code.
I plan on giving this project some T.L.C. this month (rewriting tests, updating dependencies, etc). But I can't make any guarantees. If you want to help out and open a pull request to fix your issue I'll definitely merge it in!

Hi @ewolfe, sadly the forks we're using are private. We hope you'll have success. If not, we'll find a workaround. Thanks.

A quick fix might be to just "install" prlint to your fork. Would you mind trying that and letting me know? I can hop on a chat or video call too, it might be faster to debug that way.

@m3rabb sorry, just saw your message. I can do anytime today, you can send me a Google Hangouts link on here or to my email (it's listed on my profile)


Properly set Index and Search Analyzer names in FieldBuilder

Description
Fixes #35165
Fixes FieldBuilder to properly set indexAnalyzerName and searchAnalyzerName when SearchableField has indexAnalyzerName and searchAnalyzerName configured in the annotation.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Example does not run under non-US locale

Hi,
thanks for this good documentation. I had smaller problems running this example and finally managed to get it running.
My problem was laying in my environment, as I am from Germany :)
I got a HttpStatus 403 all time and added some debug code to postData method:
			int statusCode = response.getStatusLine().getStatusCode();
			System.out.println("Status code: " + statusCode);
			try (InputStream content = response.getEntity().getContent();
					InputStreamReader isr = new InputStreamReader(content);
					BufferedReader br = new BufferedReader(isr)) {
				String line;
				while ((line = br.readLine()) != null)
					System.out.println(line);
				System.out.println();
			}

By that I discovered that the dates are formatted with my locale:
{"Error":"InvalidAuthorization","Message":"An invalid date format used in the x-ms-date header."}
And I finally found this request header
x-ms-date: Do, 20 Mai 2021 09:17:49 GMT
After I added
		Locale.setDefault(new Locale("en", "US"));

to the main method everything worked fine.
I think the same applies for the read log analytics Java example ...
Cheers
Thorsten

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 657b5b68-4c41-841a-1110-67b9c2049e39
Version Independent ID: 2237ca0e-c552-7ee8-97ae-7034e51241d9
Content: Azure Monitor HTTP Data Collector API - Azure Monitor
Content Source: articles/azure-monitor/logs/data-collector-api.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

Assigning to content author @bwren for review and doc-enhancement if required.

#please-close


THRIFT-3921 Add C++ ostream operator<< functions for enums

I can see cases where someone relying on the enumeration's numeric output today would have a breaking change that they cannot easily avoid here.  Changes like this one, for example the one that added what() to thrift C++ generated exception code, have caused me headaches in the past when upgrading.  This makes me wonder if we want to make things like this thrift-compiler-time optional.  Not something we have to solve here, but a more general question to the maintainers.

Yeah, as I mentioned on JIRA there may be backwards compatibility concerns. But from what I saw in the related THRIFT-3336 comment my sense was devs don't want to add more options/annotations, which makes sense to me since ultimately it does have a maintenance cost.

Is there anything else needed to merge this? Seems to be a lot of stale PRs waiting for review/merge. :(

Hello - when I upgraded a project to thrift-0.10.0 I found I needed to provide the operator << for enumerations.  I am a bit concerned we're not providing an operator >> as well; I think it would be a good idea to make sure the implementation can be overridden.  That said, if you could rebase on master and force push it will kick a new CI build; I would like to see things passing (save maybe build job 17 which has had some trouble lately).

I'm going to pick this up and implement it in the context of THRIFT-4060.  The compiler will emit a declaration for operator << of an enumeration, but the emitter for the definition of same will be optional.

Hi,
This seems to have caused a regression on AArch64. I didn't investigate it yet, usually it's some signed vs unsigned char in compiler defaults, maybe some other type mismatches.
Logs: http://paste.ubuntu.com/24050156/

@alexandruavadanii thanks, I reopened the ticket.   Looks like it might be a C++11 issue?

To be honest, my C++ is a bit rusty, I got here indirectly while investigating a downstream bug (https://jira.opnfv.org/browse/ARMBAND-224).
Btw, OS/compiler info: Ubuntu Xenial (16.04) AArch64 - native build on armv8 baremetal;
$ g++ --version
g++ (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.2) 5.4.0 20160609
I'll try to look at the code/logs a little, see if I can be of help.


Quantum Documents - Release July 2020

Docs Build status updates of commit 5c8148a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

api/iqsharp-magic/azure.connect.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.execute.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.jobs.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.output.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.status.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.submit.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.target.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/check_kata.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.broombridge.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.encode.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.fh.add_terms.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.fh.load.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.inputstate.load.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/config.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/estimate.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/index.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/kata.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/lsmagic.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/lsopen.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/package.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/performance.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/simulate.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/toc.yml
:white_check_mark:Succeeded

api/iqsharp-magic/toffoli.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/who.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/workspace.md
:white_check_mark:Succeeded
View

articles/concepts/advanced-matrices.md
:white_check_mark:Succeeded
View

articles/concepts/oracles.md
:white_check_mark:Succeeded
View

articles/quickstarts/install-command-line.md
:white_check_mark:Succeeded
View

articles/quickstarts/install-jupyter.md
:white_check_mark:Succeeded
View

articles/quickstarts/install-python.md
:white_check_mark:Succeeded
View

articles/quickstarts/update.md
:white_check_mark:Succeeded
View

articles/resources/contributing/index.md
:white_check_mark:Succeeded
View

articles/resources/contributing/style-guide.md
:white_check_mark:Succeeded
View

articles/resources/relnotes.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/additional-libraries.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/chemistry/installation.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/chemistry/samples/molecular-hydrogen.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/index.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/machine-learning/intro.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/machine-learning/toc.yml
:white_check_mark:Succeeded

articles/user-guide/libraries/numerics/index.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/numerics/installation.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/numerics/toc.yml
:white_check_mark:Succeeded

articles/user-guide/libraries/standard/algorithms.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/standard/diagnostics.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/standard/index.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/toc.yml
:white_check_mark:Succeeded

articles/user-guide/machines/full-state-simulator.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 4878e8f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

api/iqsharp-magic/azure.connect.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.execute.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.jobs.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.output.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.status.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.submit.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.target.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/check_kata.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.broombridge.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.encode.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.fh.add_terms.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.fh.load.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.inputstate.load.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/config.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/estimate.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/index.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/kata.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/lsmagic.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/lsopen.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/package.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/performance.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/simulate.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/toc.yml
:white_check_mark:Succeeded

api/iqsharp-magic/toffoli.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/who.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/workspace.md
:white_check_mark:Succeeded
View

articles/concepts/advanced-matrices.md
:white_check_mark:Succeeded
View

articles/concepts/oracles.md
:white_check_mark:Succeeded
View

articles/quickstarts/install-command-line.md
:white_check_mark:Succeeded
View

articles/quickstarts/install-jupyter.md
:white_check_mark:Succeeded
View

articles/quickstarts/install-python.md
:white_check_mark:Succeeded
View

articles/quickstarts/update.md
:white_check_mark:Succeeded
View

articles/resources/contributing/index.md
:white_check_mark:Succeeded
View

articles/resources/contributing/style-guide.md
:white_check_mark:Succeeded
View

articles/resources/relnotes.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/additional-libraries.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/chemistry/installation.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/chemistry/samples/molecular-hydrogen.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/index.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/machine-learning/intro.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/machine-learning/toc.yml
:white_check_mark:Succeeded

articles/user-guide/libraries/numerics/index.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/numerics/installation.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/numerics/toc.yml
:white_check_mark:Succeeded

articles/user-guide/libraries/standard/algorithms.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/standard/diagnostics.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/standard/index.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/toc.yml
:white_check_mark:Succeeded

articles/user-guide/machines/full-state-simulator.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 415cec3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

api/iqsharp-magic/azure.connect.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.execute.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.jobs.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.output.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.status.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.submit.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/azure.target.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/check_kata.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.broombridge.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.encode.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.fh.add_terms.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.fh.load.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/chemistry.inputstate.load.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/config.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/estimate.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/index.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/kata.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/lsmagic.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/lsopen.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/package.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/performance.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/simulate.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/toc.yml
:white_check_mark:Succeeded

api/iqsharp-magic/toffoli.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/who.md
:white_check_mark:Succeeded
View

api/iqsharp-magic/workspace.md
:white_check_mark:Succeeded
View

articles/concepts/advanced-matrices.md
:white_check_mark:Succeeded
View

articles/concepts/oracles.md
:white_check_mark:Succeeded
View

articles/quickstarts/install-command-line.md
:white_check_mark:Succeeded
View

articles/quickstarts/install-jupyter.md
:white_check_mark:Succeeded
View

articles/quickstarts/install-python.md
:white_check_mark:Succeeded
View

articles/quickstarts/update.md
:white_check_mark:Succeeded
View

articles/resources/contributing/index.md
:white_check_mark:Succeeded
View

articles/resources/contributing/style-guide.md
:white_check_mark:Succeeded
View

articles/resources/relnotes.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/additional-libraries.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/chemistry/installation.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/chemistry/samples/molecular-hydrogen.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/index.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/machine-learning/intro.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/machine-learning/toc.yml
:white_check_mark:Succeeded

articles/user-guide/libraries/numerics/index.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/numerics/installation.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/numerics/toc.yml
:white_check_mark:Succeeded

articles/user-guide/libraries/standard/algorithms.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/standard/diagnostics.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/standard/index.md
:white_check_mark:Succeeded
View

articles/user-guide/libraries/toc.yml
:white_check_mark:Succeeded

articles/user-guide/machines/full-state-simulator.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


"Create Azure Stateful Node by Importing VM" support

This is the default pull request template. You can customize it by adding a pull_request_template.md at the root of your repo or inside the .github folder.
Jira Ticket
Include a link to your Jira Ticket
Example: JIRAISS-1234
https://spotinst.atlassian.net/browse/SPOTAUT-15415
Demo
Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route
Checklist:

[ ] I have filled relevant self assessment (NodeJS, Frontend, Backend)
[ ] I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have validated all the requirements in the Jira task were answered
[ ] I have all neccessary approvals for the design/mini design of this task
[ ] I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

Add support for Azure stateful import vm


Add gesture recognizers on the main thread

What was done
Moved the adding of gesture recognizers in the CameraManager.swift file to the main thread.
Why was it done
Intermittent crashes.
Xcode 9's thread checking feature was throwing an error each time I used the CameraManager saying that adding a gesture recognizer must be done on the main thread. XCode's static analyzer also showed a warning about this gesture recognizer and said it needed to be done on the main thread.
Testing
Run the CameraManager using Xcode 9 without this change and you should see the console print an error about adding a gesture recognizer on a background thread. If you build this branch that error should be resolved.

Hi @erparker,
thanks for you PR. I will be merging some PRs this weekend :)
Sorry for the delay.

@erparker fix please attachZoom too :)

@torrao  Can you update 3.x version also? I still have swif3 on some projects. Thank you.


Initialize RAC string translations

Adds translation file for remaining RAC strings that need translations.
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

The only other comment is that all RAC users, regardless of if they use Breadcrumbs, will now get breadcrumb strings. There aren't many strings now, but should we split it out anyways?

@snowystinger I think this ok for now, and we aren't anticipating a lot of strings in RAC that wouldn't be in the hooks. We can split them up in the future if we need to and it will be non-breaking.


Update ConnectButton.vue

Adds chain to login data
On page load, does not try to autologin if chain is different from stored login data

@tomtomcrypto I changed the base of this PR to be dev branch and now there's a ton of changes we don't want, I think it might be easier to discard this PR/branch and re-apply your changes onto a branch of dev.  Or re-use this PR/branch, but there will be a lot of conflicts possibly to handle.

Ok yeah wasn't sure, I'll close this


[Node Agent] Support patching containerd config file

How to categorize this issue?

/area quality os
/kind enhancement
This proposal was inspired by a discussion with @ialidzhikov. Thanks!
What would you like to be added:
kind supports patching of the containerd configuration. We make use of this feature in our local setup https://github.com/gardener/gardener/blob/b83a3a0932698ebf267462dff30f3e31c8f912ac/example/gardener-local/kind/cluster/templates/cluster.yaml#L34-L37
I propose that we extend the OperatingSystemConfig with a similar API so that the node-agent can apply these patches to the containerd configuration and restart containerd if needed. Here is the kind implementation.
Why is this needed:
The current import functionality is not robust enough to be used in certain scenarios. See https://github.com/gardener/gardener/issues/7838
Extensions that need to modify the containerd configuration usually deploy a daemonset which makes use of some error prone and limited scripting in order to apply changes to the config file. It would be nice if such extensions can simply modify the OSC with a webhook requesting the changes they need.
Some examples of such scripting:

Gvisor
Kata

/remove-lifecycle stale

/remove-lifecycle stale

@timuthy , I think we can close this as https://github.com/gardener/gardener/pull/10167 is merged, right?

/close


Update index.qmd

Hi @donotdespair
I have removed all the accidental commits and committed only the index.qmd file. I have also incorporated all the changes you made into the file with one minor adjustment. I still think the mean of \tau should be \bar{\Sigma}y instead of y so I changed the code back from b.tau  = aux$Y to solve(V.tau.bar.inv)%*%aux$Y. Sorry for the confusion and thank you very much for your feedback!
Best,
Rui

Hey @rruiliu1005
Let me just explain what's the situation and what will happen now. What you should do is:

Fork the repo
edit your section
submit the PR
NOT delete existing sections.

What I'll do is:

close this PR
copy the code for your section
submit the PR
do all the things necessary on Canvas

Cheers,
Tomasz

Sorry about that… this repo is kind of confusing.. let me know if there’s
any action required on my end.
On Fri, 14 Jun 2024 at 09:37, Tomasz Woźniak @.***>
wrote:

Closed #42
https://github.com/donotdespair/Bayesian-Unobserved-Component-Models/pull/42
via 6f28ce6
https://github.com/donotdespair/Bayesian-Unobserved-Component-Models/commit/6f28ce652504053b5212e4c5523df8efc5d8c411
.
—
Reply to this email directly, view it on GitHub
https://github.com/donotdespair/Bayesian-Unobserved-Component-Models/pull/42#event-13154399319,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKDWLXDKQVEGWLJQED7WRYLZHJCOBAVCNFSM6AAAAABJGYQACSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGE2TIMZZHEZTCOI
.
  Thanks!
The repo is confusing a lot right now. On one side, a few submissions not following the directions. On the other one, me not protecting the master branch and not blocking changes to other files than index.qmd. I need to improve this next year (and give myself 7/10 for the repo management this year - or less :) )!
Greetings, Tomasz


[Master issue] Build speed optimizations

This is the master issue to coalesce all build speed optimizations.

[ ] #11442
[ ] #11626

closing in favor of https://github.com/tenstorrent/tt-metal/milestone/10


Supporting the Python buffer protocol with std::vector<T>

It would be really useful to have a way to convert std::vector<T> to T[::1] in Cython. This would allow zero-copy usage of std::vector<T>'s data in Python or other Cython contexts.
Here's some dummy code illustrating a bit more how one might like to use this.
cdef vector[uint8_t] v = memoryview(b"abc")
cdef uint8_t[::1] d = v

Here's an SO question along the same lines.

cdef vector[uint8_t] v = memoryview(b"abc")

This would  always require a copy since the vector owns its own memory and can share with another object.
For the vector->memoryview conversion there's a choice of three ways of doing, and only the way that makes a copy is safe:
# view generated from a pointer - dangerous the the memoryview outlives the vector.
# You can do this with regular pointers too, but it has to be explicit
cdef uint8_t[::1] d = <uint8_t[:v.size()]>&v[0]

# COPY into a Python wrapper class that exports the buffer interface
cdef uint8_t[::1] d = WrapperClass(v)

# move into a Python wrapper class that exports the buffer interface.
# Dangerous if anyone else tries to use the vector afterwards so could not be automatic
cdef uint8_t[::1] d = WrapperClass(move(v))

Providing optional cdef wrapper classes for standard library types (like ArrayWrapper in the linked SO question) might be a useful addition (or it could be getting a bit out of scope for a code-translator project), but I don't think there's a sensible way of doing what you want correctly and automatically. Unless someone else can thing of one.

Thanks @da-woods! 😄
FWIW the memoryview(b"abc") bit was merely illustrative. Not worried about that bit.
Yeah I guess I was hoping that WrapperClass(move(v)) could be injected here. With some WrapperClass bits living in Cython. Though don't feel tied to any of the SO proposals if you think there is a better way 🙂
Admittedly the code example above doesn't show this, but was specifically thinking of the case where the std::vector would be returned to Python. So a memoryview onto the underlying data that keeps std::vector alive and could be pretty powerful. 😄
There would be some code needed for this. Though I doubt it will be quite as extensive as Cython's own memoryview support. 😉

Though don't feel tied to any of the SO proposals if you think there is a better way

I don't think there's a better way. But someone else might....
I think WrapperClass(move(v)) could only be safely applied where v is known to be a temporary (like):
cdef uint_t8[::1] d = std::vector(...) # fine ...

but most other cases wouldn't be fine.
I can see why this idea is quite appealing, but I think it'd be difficult to do automatically.

Yep, that makes sense. Thanks for helping shine some light on the trickier parts. 🙂
Wasn't thinking of move explicitly, but you are right it needs to be there and that can be tricky. What if WrapperClass requires an rvalue? This would force the user to acknowledge this value is expiring and kick up some compiler errors if they don't handle it correctly?

There's two problems with rvalues.

is that Cython doesn't really understand them so the failure would happen when the C++ is compiled. I think it's better if the error can be generated at the Cython stage if possible.
I think Cython is still targetting C++98 code. It's obviously fine (and good) to use later versions to be more efficient, but it's bad to be automatically generating code that can't work with C++98.  So a wrapper than moves if possible and copies if not would be OK, but a wrapper that requires move to exist probably wouldn't (especially if it was created automatically)

Do you know if there is discussion about bumping the C++ target for Cython? Wondering given how quickly C++ standards are evolving these days. Also didn't know if this was something that might fit in Cython 3.0.

Considering I had to change one of my PRs to fit C89 I suspect not.
My view is still that it might be nice if a suitable wrapper existed (and maybe for std::string too if you were doing one?), but
a) You'd probably want it to be created on explicit request rather than doing automatic conversions for memoryviews.
b) Facilities exist for the user to ask for a move https://github.com/cython/cython/pull/3358, which would make intent clear and only work on C++11
c) Copying the vector would be an acceptable C++98 fallback (unless the user has asked for a move)
d) I do have a PR pending that should automatically use std::move on temps if it's safe to do so. That should help with this to avoid copying in some of the easier cases. But obviously "explicit is better than implicit".
I think that's all the opinions I usefully have on this

Noticed your PR ( https://github.com/cython/cython/pull/3362 ) went in the other day. Congrats! 😄
Wondering, does that help us here?

Noticed your PR ( #3362 ) went in the other day. Congrats! smile
Wondering, does that help us here?

No I don't think so. That PR is pretty unrelated to this.

Considering I had to change one of my PRs to fit C89

That's partly for MSVC, partly because we didn't have a reason yet to change it.
I think it can be acceptable to require a certain C/C++ language level for specific features, and then generate an #error that explains what users need to do to make it work. As long as it doesn't impact the general compilation but only that specific feature.
OTOH, if we can implement some feature without requiring a more recent C/C++ compiler (or at least keep a reasonable fallback for older ones), the better. :)

That makes sense. Would the C version be bumped once Python 2.7 is dropped? IIUC Python 2.7 requires VS 2008, which only had C89 support.

Also while you are here @scoder, I'm curious to hear your thoughts on this problem more generally. For example one case that comes up is the need to return a std::vector<T> from a Python function. What are your thoughts on having some wrapper class in Cython that exposes the Python Buffer Protocol and hangs onto the std::vector<T> object. I think currently this is coerced to a Python list, but it would be very helpful to avoid that coercion. Here's the use case:
def func(...):
    cdef vector<uint8> v = c_func(...)
    return v

Maybe we could add a cython.listview() for that?

So adding some new object to Cython? Yeah that makes sense.
With std::vector it can be templated to hold different types. Do you have thoughts on how we handle this templating in this new object?

Practically it would have to be generated code like the code for struct conversion since it isn't possible to template cdef classes.

Do you have thoughts on how we handle this templating in this new object?

Hmm, right, mapping the item type is an issue. A case like vector[int] is simple (items would be Python int objects), but a vector[vector[int]] would then return copied int-lists as items again, and it's not obvious how to let users map those.
Although, why not listview(container, mapping_function)? Where the optional mapping_function could also be cython.listview, amongst other things, and the default would just be the normal C->Python type mapping.
I don't see this as a plain object implementation. It can well be a language feature with deep integration into the type system. It can be implemented with Cython code generation, like fused types or the C++ type mappings. Maybe with a base class that can then be shared across different Cython modules. (Not sure if the latter is helpful, maybe for type checks?)
And if the item type is one that is supported by the buffer protocol (including structs etc.), then the generated type could include support for the buffer protocol. (vector can apparently provide access to its buffer).

Thanks for your thoughts @da-woods and @scoder! 😄
Good idea. Will look at CConvert.pyx to understand how similar things are handled. Does this seem like a reasonable place for this functionality to live?
Having a way to handle nested vectors would be good. Am seeing cases where that would help. Though even at a first pass just handling a single level of vectors would be good. We can always build on that if it's too tricky to handle the nesting initially.
It's definitely useful to have some way to handle and pass around data like this at the Python layer.
Yep supporting the buffer protocol wherever possible seems ideal. Should be helpful for people wanting to use this in conjunction with NumPy and/or other libraries that are able to handle the buffer protocol and/or memoryviews.

I changed the title of this ticket to catch the more general idea.
@jakirkham yes, I think we can start "small" and build on it. The first step would be to write a Tempita template for an @cython.final cdef class that wraps a std::list of a specific item type, and uses Cython's auto-conversion for passing the items from and to Python. See CppConvert.pyx for the C++ conversions, but I think it's worth a new file CppWrap.pyx.
In later steps, we can add support for non-standard item conversions and the buffer protocol.
I think there is a use case for packing and unpacking this wrapper, though. That suggests that it should be integrated with the type system, and that the wrapping should be triggered by a type cast, assignment or return type declaration, instead of a function call. Hmmm … I guess type checking the item type of such a wrapper on input safely at runtime would involve something almost as complex as the dtype item description of the buffer protocol. Maybe we can piggy-back on the buffer item type checks? Or maybe that's out of scope for the initial attempt…
Anyway, integrating it with the type system means that there should be a new type for it in PyrexTypes.py, similar to MemoryViewSliceType, but without the axis, contiguous and incref/decref parts. The from_py/to_py methods are where the conversion is triggered by the type system. That would mean calling some helper function that instantiates the wrapper or unpacks it back into a pointer. The dtype is the item type, maybe we can keep that. We need separate wrapper types for different wrapped item types, but I'm not sure if we also need separate types for different C++ container types, e.g. std::list vs. std::vector. Maybe we can get away with just std::list? (Although I guess it doesn't really matter if we generate a couple of more such types…)
Note that the MemoryViewSliceType does more than we need here because it's actually a mix of a C level type and a Python level representation. For our case, I think we can even inherit from PyExtensionType since that's what we're building here.
Regarding ownership of the C++ list/vector – that's also a bit tricky. I think we need to assume that the ownership always passes on to the wrapper, and use its __dealloc__() method to call del on the C++ pointer. I guess that's where std::move() enters the game. I'd be ok with making this a C++11-only feature, i.e. add a new C++ utility code section that checks the C++ version and emits a hard #error otherwise.
Ok, enough panic induced, I guess. I don't think it's as difficult or as much work as it might sound from my description. Just give it a try, and we'll see where that gets us.


[Docs] Refine deployment documentation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhangyutian02 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Camera background permission check

Nammu.checkCamera() is there but is kept private as this results in crash in sample app when Camera in Fragment is launched:
java.lang.RuntimeException: set display orientation failed
            at android.hardware.Camera.setDisplayOrientation(Native Method)
            at pl.tajchert.nammusample.camera.CameraPreview.surfaceChanged(CameraPreview.java:97)
            at android.view.SurfaceView.updateWindow(SurfaceView.java:591)
            at android.view.SurfaceView$3.onPreDraw(SurfaceView.java:176)
            at android.view.ViewTreeObserver.dispatchOnPreDraw(ViewTreeObserver.java:944)
            at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2030)
            at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1107)

To fix this probably there is needed some release call or use of Camera2 API.
I couldn't find any method that doesn't open Camera preview and require permission to use a test (so only async methods which are not perfect).
For now Camera permission can be check only with Activity instance with new runtime permission API.
Help needed - if you know solution to that :)

My mistake, it turned out that context has method to check permissions in easy manner. Deleted a two hour code, and also solved that issue.


Flaky unit test AsyncDataCacheTest.ssd

Bug description
We saw this unit test failing in CircleCI jobs. This is flaky as it doesn't fail every time.
Example log: https://app.circleci.com/pipelines/github/facebookincubator/velox/19897/workflows/a3098384-c09e-4778-9cfb-08769a73b022/jobs/125362
System information
CircleCI
Relevant logs
../../velox/common/caching/tests/AsyncDataCacheTest.cpp:658
Expected equality of these values:
  0
  stats2.numPins
    Which is: 18

Is a clone of #2130
latest failure:
https://app.circleci.com/pipelines/github/facebookincubator/velox/20837/workflows/de2eab77-5630-408b-b5b9-61f8363c429e/jobs/130919


Limitations for files with changing source

What did you do?

Diff two already generated catalogs against each other by using the API functionality:
catalog_old.write(getCatalog(@options.merge({:puppetdb_url => 'https://puppetdb-live.example.org:8081'}), logger))
catalog_new.write(getCatalog(@options.merge({:puppetdb_url => 'https://puppetdb-dev.example.org:8081'}), logger))

catalog_diff_result = OctocatalogDiff::API::V1.catalog_diff(
  {
    :to_catalog   => catalog_new.path,
    :from_catalog => catalog_old.path,
  }
)

diff_printer = OctocatalogDiff::Cli::Printer.new(@options, logger)
diff_printer.printer(catalog_diff_result.diffs)

Resource that changed looked like this:
  file { "${nagios::nrpe::plugindir}/check_ram":
    owner  => 'root',
    group  => 'root',
    mode   => '0555',
    source => 'puppet:///modules/ve_base/check_ram',
  }

The content of the source file "ve_base/check_ram" changed.

What happened?

octocatalog-diff didn't show any changes

What did you expect to happen?

Show diffs on the changed content of the file

How can someone reproduce the problem?

Generate two catalogs with a file {} resource which source file changed.

Command used and debugging output

Platform and version information

Your OS:
Ubuntu 14.04

Your Ruby version: <!-- type ruby --version at the command prompt -->
2.4.0

Your version of Puppet:
4.10.1

Your version of octocatalog-diff: <!-- type octocatalog-diff --version -->
1.0.1

Do the tests pass from a clean checkout?
Installed from gem, so hopefully ;)

Anything else to add that you think will be helpful?

I think this has to do with how Puppet itself operates. Content of a file {} source parameter is retrieve while applying the catalog. My question therefor is: Are you aware of this limitation? Do you know any workaround which could help detect the change?

@baurmatt what you request is implemented already for compiled catalogs, but not other methods of retrieving catalogs. There are some cases where it can't be implemented.
Details:

If you generate catalogs by compiling them, the --compare-file-text option (enabled by default) will "diff" the files generated from source => ... and display the output of that diff if any. This means that if the text changed, the diff will be shown. If the path to the file in the source attribute changed but the content of the file is identical, no diff is shown.

If you get catalogs from a puppet master, it turns off --compare-file-text. It would be possible to contact the puppet master's API to retrieve the content of the files and then do --compare-file-text logic on them. This functionality is possible, but it doesn't exist now because nobody's written it. (I only get catalogs from the puppet master in very limited situations -- see for example https://puppet.com/blog/upgrading-to-puppet-4-at-github, so writing this is not a high priority for me for work purposes at least.)

If you get catalogs from a JSON file or from puppetdb, there's no way to get the actual source of the files in question from the catalog. That information is simply not in the catalog. (Maybe, we could pass a supplementary argument with the path to the puppet repository so and look up the files from there?)

Hmm damn, yeah this is pretty much what I suspected. Thanks for clarifying! :) Do you see a chance that static catalogs could help? Also could this perhaps be mention in Limitations?

I can clarify this in the docs.

Sounds good, thanks! :) Do you have experience in using static catalogs?


SSL Certificate binding doesn't work unless C:/Temp directory is present

Provisioning an IIS site with a binding against a VM that does not have a directory called C:\temp\ throws errors when creating an SSL binding using this module. Module should use the standard Windows Temp directory ($env:TEMP) instead of an arbitrary C:\temp directory.
Here are the errors thrown when you try to run this manifest:
  iis::manage_app_pool {"${applicationName}": ensure => present }

  iis::manage_site { $applicationName:
    ensure      => present,
    site_path   => "${webPath}", #Must be \\'s for IIS to work correctly
    app_pool    => "${applicationName}",
    host_header => "${hostHeader}",
    require     => File['application-root'],
  }

  acl { 'iis_root':
    target => "${webPath}",
    inherit_parent_permissions => true,
    permissions => [
      { identity => 'IIS_IUSRS', rights => ['full'] },
      { identity => 'IUSR', rights => ['read'] },
      { identity => 'vagrant', rights => ['full'] }
    ],
    require => File['application-root'],
  }

  iis::manage_binding { "${applicationName}-https":
    ensure => present,
    site_name => $applicationName,
    protocol => 'https',
    port => 443,
    host_header => $hostHeader,
    certificate_thumbprint => '########',
  }

Error:
==> default: Error: Could not set 'present' on ensure: No such file or directory - C:/temp/create-mysite.local-https.ps120140812-1688-4j4xak.lock at 42:C:/tmp/vagrant-puppet-4/modules-0/iis/manifests/manage_binding.pp
==> default:
==> default: Error: Could not set 'present' on ensure: No such file or directory - C:/temp/create-mysite.local-https.ps120140812-1688-4j4xak.lock at 42:C:/tmp/vagrant-puppet-4/modules-0/iis/manifests/manage_binding.pp
==> default: Wrapped exception:
==> default: No such file or directory - C:/temp/create-mysite.local-https.ps120140812-1688-4j4xak.lock
==> default: Error: /Stage[main]/Application_server/Iis::Manage_binding[mysite.local-https]/File[create-mysite.local-https-certificate.ps1]/ensure: change from absent to present failed: Could not set 'present' on ensure: No such file or directory - C:/temp/create-mysite.local-https.ps120140812-1688-4j4xak.lock at 42:C:/tmp/vagrant-puppet-4/modules-0/iis/manifests/manage_binding.pp
==> default: Error: Could not set 'present' on ensure: No such file or directory - C:/temp/inspect-mysite.local-https.ps120140812-1688-1vnygg2.lock at 36:C:/tmp/vagrant-puppet-4/modules-0/iis/manifests/manage_binding.pp
==> default:
==> default: Error: Could not set 'present' on ensure: No such file or directory - C:/temp/inspect-mysite.local-https.ps120140812-1688-1vnygg2.lock at 36:C:/tmp/vagrant-puppet-4/modules-0/iis/manifests/manage_binding.pp
==> default: Wrapped exception:
==> default: No such file or directory - C:/temp/inspect-mysite.local-https.ps120140812-1688-1vnygg2.lock
==> default: Error: /Stage[main]/Application_server/Iis::Manage_binding[mysite.local-https]/File[inspect-mysite.local-https-certificate.ps1]/ensure: change from absent to present failed: Could not set 'present' on ensure: No such file or directory - C:/temp/inspect-mysite.local-https.ps120140812-1688-1vnygg2.lock at 36:C:/tmp/vagrant-puppet-4/modules-0/iis/manifests/manage_binding.pp

So I just ran into this same problem. It looks like the c:\temp path is hard coded into the manage_binding.pp.
    file { "inspect-${title}-certificate.ps1":
        ensure  => present,
        path    => "C:\\temp\\inspect-${name}.ps1",
        content => template('iis/inspect-certificate-binding.ps1.erb'),
      }

On my server 2k12 install that directory doesn't exist therefore puppet blows up. There is no provision to create that temp directory if it's not already there. So two ideas.
A. We enforce the creation of that directory if it doesn't exist.
B. We declare a variable temp_dir and make it required.

@kensykora what about the $env:TEMP option?

We don't actually need to make the files on disk at all, and skip this problem completely.
I think the whole thing could be simplified to this:
exec { "Attach-Certificate-${title}":
        command   => template('iis/create-certificate-binding.ps1.erb'),
        onlyif    => template('iis/inspect-certificate-binding.ps1.erb'),
        provider  => powershell,
        logoutput => true,
      }

Then we dont need to worry about the temp directory at all 👍

@YarNhoj @kensykora @karmafeast: can you try testing the SSL code with https://github.com/voxpupuli/puppet-iis/tree/manage_binding_to_templates? This shouldn't require a temp file directory at all.
If not, can someone give an example of what the code would look like, with a self-signed cert or something for an acceptance test?

Hi. I'm going to close this Issue. We deprecated the module and the new version is available here: https://forge.puppet.com/puppetlabs/iis


Add accessibility blog post

This is a blog post on the accessibility features that have been added to Spectron and Devtron ⭐

🎉


Introduce semantic validation of swagger doc

Introduced semantic error validation (#4):
Definitions:

A definition/model cannot declare a property that is already defined by one of its ancestors.
Discriminator must be defined as a required property
Discriminator must be an existing property of definition/model
Required properties must be declared as properties in the definitions
Required properties cannot contain duplicates
References to other definitions must exist
"Items" property must be defined in array

Operations:

Operation cannot contain both form and body parameter
Operation must contain at most one body parameter
Api path must be unique (not equal/equivalent to another defined path)
Path params must by matched by operations params (and viceversa)
Operation must not duplicate parameters (combination of "name" and "in" must be unique)

Thanks for the suggestion: you are right, I generated with IntelliJ the delegate with inheritance when I wasn't 100% sure about the approach (and the fields I needed).


Version Database

Pull requests into this repository require the following checks to be completed by the submitter and reviewers.
Submitter:

[x] Administrative tasks are complete.

This pull request describes why these changes were made.
The JIRA ticket links to this PR.
The JIRA ticket for this PR is:  Lantern 318 JIRA Ticket

[ ] Tests are complete.

Tests are included and test edge cases.
Tests have been run locally and pass.

[x] Code review has been performed.

Code diff has been done and checked to ensure only expected code is being committed.
A linter for the language has been run.

Primary Reviewer:

[ ] Code works.

Code has been run locally and the basic functionality affected by the PR has been checked.
Edge cases have been checked to ensure behavior is as expected.

[ ] Code review has been performed.

Code is maintainable, reusable, efficient, and correct.
Code accomplishes the tasks purpose.
Code follows style guidance appropriate for the language, including passing linter checks.
Code is well commented (which does not mean verbosely commented).

[ ] Tests are complete.

Tests are included and test edge cases.
Tests have been run locally and pass.

Secondary Reviewer:

[ ] Code works.

Code has been run locally and the basic functionality affected by the PR has been checked.
Edge cases have been checked to ensure behavior is as expected.

[ ] Code review has been performed.

Code accomplishes the tasks purpose.

[ ] Tests are complete.

Tests have been run locally and pass.

Merger:
Prior to merging, ensure that all checks have been completed. Delete the branch after the merge
is complete.
Create a new branch <branch name>_gomodupdate. Run make update_mods to update the go.mod
and go.sum files to point to master. Create a PR. Require one sanity check reviewer.

I just thought of this and was wondering if either you or @mayerm94 had an opinion: do you think their should be a constraint on the fhir_endpoints_info table for the URL and FHIR version fields? like
CONSTRAINT fhir_endpoints_info_unique UNIQUE(url, capability_fhir_version, requested_fhir_version)
I don't know if this adds anything but I was looking at the constraints on other tables and figured I should mention it!


Image cache

It would be really nice if it could cache pre-built images in .svelte-kit or similar so the image cache can be shared across builds/CI

This should probably be solved at the vite or vite-imagetools level. There's ongoing discussion here.

The latest version of vite-imagetools now includes a cache

well then

The latest version of vite-imagetools now includes a cache

@benmccann Thanks for the heads-up, I'll check it out.

@sveltejs/enhanced-img also uses vite-imagetools, so it now supports caching as well


Extend number of BOSH director event logs

During 18F/security-incidents#180 we found that we only retain 10,000 Bosh director event logs.
Acceptance criteria

[ ] WHEN I look for a bosh event that happened within the last 180 days, I should find it

Docs about how to increase this


Run on custom set of images

First, thanks for sharing your work, it's very interesting
I'm trying to run the pre-trained models on my own set of images (not using an existing dataset), what would be the proper way to do that?

@Ruffi
Basically, you can start by changing the load method of the Places365Dataset class.
You can also create your own dataset class by inheriting from BaseDataset. The only method you are required to implement is the load method. In this case, you need to change the model's create_dataset method with your own dataset class.
As a side note, although the model is fully convolutional and you can use images of any arbitrary size at test time, the Places365 model model works best when the input size is 256x256 image!

Thanks, I'll try that :)

Hi
How were you able to run on your set of images?

@adityajain28 We are planning to add a helper method so that one can easily run the model on their set of images. However, right now your best bet is to create your own dataset class as I mentioned above.

Right now, if you run the tests, the images are being displayed to you and you can save them manually, however as I mentioned earlier, I'm going to add a helper method to test on custom images and save the results on disk.

The problem I am facing is not being able to run test-turing.py
It just shows loading model and it stops. Nothing happens after that.
So to visualize the images I have to run Python test-turing.py, correct? Or
is there any other method?
On Wed, Nov 14, 2018, 11:13 PM Kamyar Nazeri<EMAIL_ADDRESS>wrote:

Right now, if you run the tests, the images are being displayed to you and
you can save them manually, however as I mentioned earlier, I'm going to
add a helper method to test on custom images and save the results on disk.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ImagingLab/Colorizing-with-GANs/issues/4#issuecomment-438911149,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASQspHe77Lzp_RrtAcueS0tPZzgbkEDFks5uvOnkgaJpZM4Vf_th
.

Not sure why it might stop after loading! Right now to visualize, that's your best bet. You can change the code to do the visualization as you like. However, next week I'm adding a helper method to test the model on custom images.


Prometheus not replacing invalid characters from label names from some metrics: dot, dash and slash (.-/)

Bug Report
What did you do?
Collecting metrics from Kubernetes pods.
What did you expect to see?
Labels properly sanitized, with .-/characters replaced by _. For example: app.kubernetes.io/instance and pod-template-hash.
What did you see instead? Under which circumstances?
Example of a simple query to display the metric in Prometheus web interface.
br_jus_tjpr_uniformizado_funjus_jmx_MxImportarArquivosBancarios_Status{app.kubernetes.io/instance="uniformizado-deploy",app.kubernetes.io/name="app-padrao",idDeploy="d8192f96-b6b6-47dc-8206-7b8e337a5c10",instance="<IP_ADDRESS>:9404",job="kubernetes-pods",kubernetes_namespace="uniformizado",kubernetes_pod_name="uniformizado-65d476bc49-899lf",pod-template-hash="65d476bc49"}

Environment

System information:

Linux 4.15.0-48-generic x86_64

Prometheus version:

prometheus, version 2.9.0 (branch: HEAD, revision: 1a9cdbd024fea05a1888c3164058087476cfdc3b)
  build user:       root@4d7ed54ba6d9
  build date:       20190415-09:06:49
  go version:       go1.12.3

Alertmanager version:

alertmanager, version 0.15.3 (branch: HEAD, revision: d4a7697cc90f8bce62efe7c44b63b542578ec0a1)
  build user:       root@4ecc17c53d26
  build date:       20181109-15:40:48
  go version:       go1.11.2

Prometheus configuration file:

prometheus.txt
I noticed this when a specific alert was not being sent to Alertmanager. The alert is fired in Prometheus and I see these error messages in the Prometheus logs:
level=error ts=2019-05-14T20:26:44.203Z caller=notifier.go:482 component=notifier alertmanager=http://<IP_ADDRESS>:9093/api/v1/alerts count=1 msg="Error sending alert" err="bad response status 400 Bad Request"
level=error ts=2019-05-14T20:28:44.203Z caller=notifier.go:482 component=notifier alertmanager=http://<IP_ADDRESS>:9093/api/v1/alerts count=1 msg="Error sending alert" err="bad response status 400 Bad Request"
level=error ts=2019-05-14T20:30:44.203Z caller=notifier.go:482 component=notifier alertmanager=http://<IP_ADDRESS>:9093/api/v1/alerts count=1 msg="Error sending alert" err="bad response status 400 Bad Request"

... while at Alertmanager, I see the following errors:
level=error ts=2019-05-14T20:30:44.202800334Z caller=api.go:813 msg="API error" err="bad_data: \"app.kubernetes.io/name\" is not a valid label name"
level=error ts=2019-05-14T20:32:44.203194602Z caller=api.go:813 msg="API error" err="bad_data: \"app.kubernetes.io/instance\" is not a valid label name"
level=error ts=2019-05-14T20:33:44.202983532Z caller=api.go:813 msg="API error" err="bad_data: \"app.kubernetes.io/name\" is not a valid label name"
level=error ts=2019-05-14T20:35:44.202978802Z caller=api.go:813 msg="API error" err="bad_data: \"app.kubernetes.io/instance\" is not a valid label name"
level=error ts=2019-05-14T20:37:44.202707976Z caller=api.go:813 msg="API error" err="bad_data: \"pod-template-hash\" is not a valid label name"

Looks to me that Prometheus scraping is not properly sanitizing labels in some cases. This does not appear to be the case for every metric. This one in particular was scraped from a JMX Exporter endpoint.
Could this be a problem in Prometheus itself? Or did I not configure something correctly here?

Nevermind.. upgrading to v2.9.2 fixed the issue.


feat: bump to use go1.21

Description
bump to use go1.21 for build
relates to https://github.com/Homebrew/homebrew-core/pull/159379
Related Issue

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (changes only affecting documentation)

Checklist

[x] I have tested my changes locally and ensured they are functioning properly.  Please run the make build and make test commands.
[ ] I have added/updated unit or e2e tests to cover my changes.
[ ] I have updated the relevant documentation. If you change commands or arguments, run make doc-gen to generate new documentation.

@all-contributors
please add @chenrui333  for infra.


Semantic Segmentation vs Instance Segmentation

Hi,
Thanks for sharing this repo!
I wanted to ask what was the reasoning behind choosing semantic segmentation over instance segmentation ? I would think that to be able to do an accurate mapping with SLAM, it would be better to have an instance segmentation of the cones so the cones are individualized even when overlapped and can each have their own depth estimation etc. Is the centerestimation script to individualize the cones of the semantic mask using the LIDAR for SLAM to be able compute the mapping then ? If yes, why not have instance segmentation directly ?
Thanks in advance!

No problem! We were using a very accurate LiDAR for 3D localization of the cones, and so we only needed to know the color of each of the 3D points. There was no need for us to know the specific cone a point belonged to, only a color. The center estimation script computes the center of each of the previously found cones.

Thanks for your reply ! Thus, the center estimation is not the center of a single cone extracted from a cluster (semantic mask) ?

The center estimation estimates the center of a single cone, represented as a cluster of 3D points. The clustering has nothing to do with the image segmentation.

I added our thesis as a file in the repository, which contains a better explanation for our choices than what I can hope to provide in a Q&A format.

Thats awesome thank you !


Implement resource_jars attribute for Scala targets

Summary
Implements the resource_jars attribute which is already available for Java targets:
https://bazel.build/versions/master/docs/be/java.html#java_library.resource_jars
This implementation follows the behavior described in the Java target documentation:

Set of archives containing Java resources. If specified, the contents of these jars are merged into the output jar.

The Java behavior appears to be implemented here...
https://github.com/bazelbuild/bazel/blob/master/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/SimpleJavaLibraryBuilder.java#L203-L226
...and it appears to generally agree with the behavior in this PR.
Motivation
Easy collection of generated resources in https://github.com/bazelbuild/rules_scala/pull/165
Testing
Added a test case; also got this logic working with #165
r? @johnynek

Can one of the admins verify this patch?

osx head seems to be getting stuck, which is a bit worrisome.

Looks like it unstuck!

I can indeed confirm I am happy to see these commits contributed to rules_scala.