HBASE-23378: Clean Up FSUtil setClusterId

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 29s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
checkstyle
1m 21s
master passed

+1 :green_heart:
shadedjars
4m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

+0 :ok:
spotbugs
4m 18s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 15s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 58s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
checkstyle
1m 17s
hbase-server: The patch generated 0 new + 73 unchanged - 1 fixed = 73 total (was 74)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m 19s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 35s
the patch passed

+1 :green_heart:
findbugs
4m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
147m 31s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

205m  7s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/910

JIRA Issue
HBASE-23378

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux cd13536792a9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-910/out/precommit/personality/provided.sh

git revision
master / 9c82a65b29

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/1/testReport/

Max. process+thread count
4624 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@HorizonNet When you are too helpful, you get asked to do more. :)
Can you please also take a look at this PR as well?

@busbey Thanks for that.  Embarrassing mistake on my part, to say the least.
I addressed this and also updated the JavaDocs to talk about the retry capability.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  6s
https://github.com/apache/hbase/pull/910 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/910

JIRA Issue
HBASE-23378

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/2/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  2s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 31s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
checkstyle
1m 20s
master passed

+1 :green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

+0 :ok:
spotbugs
4m 34s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 32s
master passed

-0 :warning:
patch
4m 41s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  5s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

-1 :x:
checkstyle
1m 19s
hbase-server: The patch generated 1 new + 65 unchanged - 1 fixed = 66 total (was 66)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 44s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 35s
the patch passed

+1 :green_heart:
findbugs
4m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
151m 16s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

210m 53s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/910

JIRA Issue
HBASE-23378

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 0844b8bccc76 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-910/out/precommit/personality/provided.sh

git revision
master / 94346d8623

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/3/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/3/testReport/

Max. process+thread count
4754 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey You able to take another swing at this?

@saintstack Yes and I too am trying to raise the bar here and clean things up.  Thanks for catching that!  I've removed it.

...and I too am trying to raise the bar here and clean things up
Sorry. Yes. This is plain. This is great stuff.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 26s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
checkstyle
1m 18s
master passed

+1 :green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

+0 :ok:
spotbugs
4m 34s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 33s
master passed

-0 :warning:
patch
4m 42s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  1s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
checkstyle
1m 18s
hbase-server: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 47s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 35s
the patch passed

+1 :green_heart:
findbugs
4m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
151m 29s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

209m 19s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/910

JIRA Issue
HBASE-23378

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux ca6ebc9e3714 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-910/out/precommit/personality/provided.sh

git revision
master / 85ecdd10a9

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/4/testReport/

Max. process+thread count
5647 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-910/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Will commit in a day or so. Give @busbey a chance to looksee.


Setup Mini Ceph Environment in Github Runner

Description:
We aim to set up a miniature Ceph environment within a GitHub runner for experimentation purposes. This task requires evaluation and implementation of potentially suitable setups including Rook with Minikube, Cephadm, or CBT. Due to resource constraints of ubuntu-latest runner, we may need to consider alternative runners. The experiments should be conducted in a public project under a user's personal GitHub repository, not in the cephlet project.
Acceptance Criteria:

Resource Constraints: The setup should function within the constraints of the selected runner.
Deploy a Ceph cluster.
Create and verify a functional Ceph pool.
Documentation on the steps taken and rationale for the chosen setup.

Runner Alternatives:
If ubuntu-latest runner proves insufficient:

Consider macOS and Windows runners.

Steps:

Evaluate Rook/Minikube, Cephadm, and CBT for feasibility within runner constraints.
Choose and set up the most suitable runner.
Implement the most suitable Ceph setup method on the chosen runner.
Ensure the health of the deployed Ceph cluster.
Verify the functional state of the Ceph pool.
Document all steps, choices, findings, and the runner selected.

Additional Notes:

The setup and teardown process should be seamless since the environment might be instantiated and torn down frequently.

Does anybody know microceph (https://ubuntu.com/ceph/install). Could this also be a viable option?


Component date_input not clearable.

With st.date_input(...):

With stp.date_input(...):

As a workaround I tell users to clear it from URL (or I saw them just to some super early date).
$ pip freeze | grep permalink
streamlit-permalink==0.5.2

Thanks for the information!
I won't have time to debug this any time soon :/
Although, if you find a fix I'd be happy to merge it and upload to PyPI.

That is understandable.
There is a chance that it is related to underlying component and how it handles default value, if I'll have anything I'll get back 🙏


Basemap not imported correctly: matplotlib import error?

Not sure if this is a syntax or import error - it says the latter but I don't know the correct spelling. I'm getting this from the binder instance - do we need to add matplotlib to the requirements.txt, do you think?
from mpl_toolkits.basemap import Basemap
from matplotlib.collections import PolyCollection

ImportError                               Traceback (most recent call last)
 in ()
----> 1 from mpl_toolkits.basemap import Basemap
2 from matplotlib.collections import PolyCollection
ImportError: No module named basemap

yes, we should add mpl_toolkits in requirements.txt (conda install basemap)

Go for it! :-)
On Fri, Jul 15, 2016 at 4:48 PM, fjaviersanchez<EMAIL_ADDRESS>wrote:

yes, we should add mpl_toolkits in requirements.txt (conda install basemap
)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fjaviersanchez/JupyterTutorial/issues/17#issuecomment-232990094,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArY93cVtUxhLnaBcWM4efHgNIzJLq_Bks5qV6vpgaJpZM4JNf6t
.

I added RUN conda install basemap on Dockerfile. Unfortunately the disk of the binder server was full when I tried to build the notebook and the process is halted (there is a built version in which everything works except for the basemap part. But you can add before that cell !conda install basemap -y and it will install the package and run without trouble. Could you please try if you can build it?

I think this can now be closed - see #18.


Cosmetic: Items having the correct item fanfare

So this is a very super minor detail but both OOTR and MMR did this, I'm not sure how possible it is to do since you made it so chests believe they have their vanilla contents (actually, this also happens with NPCs anyway too so I think it's just the items themselves?) But basically, what this issue is is that when you get a blue rupee from a chest/NPC it should play the minor get item fanfare instead of the major one like it does right now with some chests/NPCs. Likewise, when you get a major item from a chest it should always play the major get item fanfare (I haven't noticed any major items not play the major item fanfare so I think this is fine already). However, I do know that with minor items like money, ammo, etc it's not consistent on whether it plays the minor fanfare or major fanfare so that's really what needs to be changed.
A quick example I can give is probably in MM's lens cave, if you go over to the invisible chest and pick up a rupee from that chest I believe right now it will still play the major item fanfare instead of the minor one. It's just a minor odd thing and if it's not doable with how chests behave right now then no big deal.
Edit: I think this applies across the board to chests, NPCs, and freestandings right now? Not 100% but feel like it does. It's super minor either way, though.

I think the issue actual is that the fanfare is not correct for foreign items.

Added


Enable/disable checksums

Reported by jsoumagne on 1 Jan 1970 00:22 UTC
Needs to be able to enable/disable checksum of metadata per operation.

Modified by jsoumagne on 1 Jan 1970 00:22 UTC

Comment by dkimpe on 1 Jan 1970 00:23 UTC
No use case for this at this point; Might reconsider once overhead of checksum is proven.


Add jaquelineq's file

I have created a branch, created a file and made a commit, and opened a pull request.

I am done! youhou


HBASE-27564 Add default encryption type for MiniKDC to fix failed tests on JDK11+

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
spotless
0m 50s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  4s
Maven dependency ordering for patch

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
spotless
0m 46s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

4m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4955/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4955

Optional Tests
dupname asflicense spotless

uname
Linux 6835aa3dc1e7 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4add5250ed

Max. process+thread count
42 (vs. ulimit of 30000)

modules
C: hbase-endpoint hbase-examples hbase-http hbase-mapreduce U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4955/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

we only need to support hadoop3 on 3.0+, so I think we only need to apply the patch to branch-2.x?

we only need to support hadoop3 on 3.0+, so I think we only need to apply the patch to branch-2.x?

Yes. Will reopen a PR to branch-2 later.

we only need to support hadoop3 on 3.0+, so I think we only need to apply the patch to branch-2.x?

Yes. Will reopen a PR to branch-2 later.

Done. Close this PR.


PHP, Contact Me Form

The Contact me form is not working on my website. I am using Freelancer. Please Help.

Have you made any modifications in the PHP Script?
You need to go into the PHP file and make the following changes

Replace<EMAIL_ADDRESS>with the email ID where you want the emails to be sent whenever somebody fills up the contact form

The rest of the fields can be kept the same.
Let me know if this solves the issue.

Which Web Hosting Service are you currently using? Could you try contacting your web hosting service to open the SMTP Ports?
If they aren't able to solve it, let me know. We'll try to bypass the issue in some way.

I'm using GitHub pages. From what I've read all the ports are open.

@backtrackbaba Does GH Pages block SMTP Ports?

i have the same problem ???? what can i do now

@larsonthekidrs  did you solved it ??

@backtrackbaba  can you help plz ??

@AbdullhRtima I have not yet solved it. The support is almost none... I'm still working on this in my free time.

because i almost have no time for it so if you solve it plz  mention me

@backtrackbaba Do you know of a way to get this working?


Not able to get OBO file

I was trying to convert the OWL file in the repo to OBO format using the following code:
from pronto import Ontology

dideo = 'https://raw.githubusercontent.com/DIDEO/DIDEO/master/dideo.owl'
file_name = dideo.split('/')[-1]
Ontology.from_obo_library(file_name)

But when I do so, I get the following error:
Traceback (most recent call last):
  File "annotate_assay.py", line 216, in <module>
    main()
  File "annotate_assay.py", line 212, in main
    Ontology.from_obo_library(file_name)
  File "lib\site-packages\pronto\ontology.py", line 206, in from_obo_library
    return cls(
  File "lib\site-packages\pronto\ontology.py", line 283, in __init__
    cls(self).parse_from(_handle)  # type: ignore
  File "lib\site-packages\pronto\parsers\rdfxml.py", line 95, in parse_from
    self.process_imports(
  File "lib\site-packages\pronto\parsers\base.py", line 70, in process_imports
    return dict(pool.map(lambda i: (i, process(i)), imports))
  File "lib\multiprocessing\pool.py", line 364, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "lib\multiprocessing\pool.py", line 771, in get
    raise self._value
  File "lib\multiprocessing\pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "lib\multiprocessing\pool.py", line 48, in mapstar
    return list(map(*args))
  File "lib\site-packages\pronto\parsers\base.py", line 70, in <lambda>
    return dict(pool.map(lambda i: (i, process(i)), imports))
  File "lib\site-packages\pronto\parsers\base.py", line 49, in process_import
    return Ontology(url, max(import_depth - 1, -1), timeout)
  File "lib\site-packages\pronto\ontology.py", line 283, in __init__
    cls(self).parse_from(_handle)  # type: ignore
  File "lib\site-packages\pronto\parsers\rdfxml.py", line 95, in parse_from
    self.process_imports(
  File "lib\site-packages\pronto\parsers\base.py", line 70, in process_imports
    return dict(pool.map(lambda i: (i, process(i)), imports))
  File "lib\multiprocessing\pool.py", line 364, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "lib\multiprocessing\pool.py", line 771, in get
    raise self._value
  File "lib\multiprocessing\pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "lib\multiprocessing\pool.py", line 48, in mapstar
    return list(map(*args))
  File "lib\site-packages\pronto\parsers\base.py", line 70, in <lambda>
    return dict(pool.map(lambda i: (i, process(i)), imports))
  File "lib\site-packages\pronto\parsers\base.py", line 49, in process_import
    return Ontology(url, max(import_depth - 1, -1), timeout)
  File "lib\site-packages\pronto\ontology.py", line 283, in __init__
    cls(self).parse_from(_handle)  # type: ignore
  File "lib\site-packages\pronto\parsers\rdfxml.py", line 122, in parse_from
    self.symmetrize_lineage()
  File "lib\site-packages\pronto\parsers\base.py", line 84, in symmetrize_lineage
    graphdata.lineage[superentity].sub.add(subentity)
KeyError: 'http://www.geneontology.org/formats/oboInOwl#ObsoleteClass'

I am not sure what the issue is. Is it from the OWL file or something from the pronto package but the aim is to get an OBO file. Do you have any other alternative for doing so?
Thank You.

I think this is a question for the PRONTO developers or the OBO community.


Add Taylor Diagram plotting

@lee1043
Checking it in for the evening... its working but needs a lot of cleanup .... more tomorrow...
taylor1panel.py -y '/work/gleckler1/processed_data/metrics_package/metrics_results/cmip5clims_metrics_package-amip/v1.1/pr_2.5x2.5_esmf_linear_metrics.json' -s 'djf' -e 'amip'

@lee1043 .... ok a new branch 345_pjg_taylor_diagram
Is working kind of but needs improvement!
When on this branch, it is producing plot while running this at command line:
taylor1panel.py -j '/work/gleckler1/processed_data/metrics_package/metrics_results/cmip5clims_metrics_package-amip/v1.1/pr_2.5x2.5_esmf_linear_metrics.json' -s 'djf' -e 'amip' -d 'NHEX' -v 'pr'

@lee1043  seasonal stds fixed and problem pr xyt_corr (>1) removed for now to undergo further testing.  Awaiting branch ( 272 pjg add std newsoln) with these corrections to be pushed by CD and will update jsons in the next 1-2 days

Now working with updated jsons that have "RESULTS" key... example...
taylor1panel.py -j '/work/gleckler1/processed_data/metrics_package/metrics_results/cmip5clims_metrics_package-amip/v1.1/pr_2.5x2.5_esmf_linear_metrics.json' -s 'djf' -e 'amip' -d 'NHEX' -v 'pr'

@gleckler1 I suggest moving this to 1.2

@jservonnat @doutriaux1 @lee1043  @zshaheen  For better or worse, PG has merged the TD and barchart issues into a common branch so that they could be developed together and in particular with consistent use of argparse arguments.    Under https://github.com/PCMDI/pcmdi_metrics/tree/345_pjg_taylor_diagram/src/python/devel/taylor_diagram_mpl/scripts and the corresponding /lib,  both codes are currently working (cmd line examples below) but need  ample cleanup.   A capability to add a second json is needed for both, and to figure out how to highlight those (2nd json) results in the context of the CMIP5 (1st json) ensemble.    PG and JS will be working on this on the days ahead, but will likely seek advice from CD JL and ZS.
After running setup in devel mode, here is an example for the TD and one for the barchart:
python -i taylor1panel.py -j /work/gleckler1/processed_data/metrics_package/metrics_results/cmip5clims_metrics_package-amip/acme-test_10102016/ta-200_2.5x2.5_esmf_linear_metrics.json -o . -e amip -d global -s all -v ta-200
python -i bar_chart_climseas.py -j /work/gleckler1/processed_data/metrics_package/metrics_results/cmip5clims_metrics_package-amip/acme-test_10102016/VAR_2.5x2.5_esmf_linear_metrics.json -o . -e amip -d global -v ta-200 -s bias

the json issue is taken care of in the branch  issue_429_json_to_db


Made generic buttons and updated dist

In order to support more generic typed buttons, i have opted for slotted content in the buttons

Hey there - thanks for the pull request! I do like the idea of adding scoped content to the buttons. That way if you want to use icons you can.
Merging now. Will be publishing on npm shortly.

Ok - I've cleaned up the readme and incremented the version number. Because this gets rid of some old props I've set this version to 2.0.0 - it's now published in npm.


Fixes bug in IsotropicTracerVarianceDissipationRate

The alterations done so far do fix a bug, however, this routine still isn't working because it turns out that calc_κᶜᶜᶜ isn't working at the moment.
I'll open an issue (and possibly a bug fix) upstream. Do we want/need to rely on that subroutine?


fix bugs related the state of tags after a tag is removed

when the keword is removed the UI should go to Home not show the layer list

additionally, the selected tag does not reset the state of the filter component

after removing the tag the component is not reset

this is now solved


Error while installing in Docker

Hi,
I'm trying to install this in Docker with base image Node:latest.
This is my Dockerfile with error.

are you using this Dockerfile? https://github.com/cazala/coin-hive#can-i-run-this-on-docker

This Dockerfile is broken i think ... : https://paste.bouillaudmartin.fr/?fe55a5561f36edb4#8pRkjwwBxnSxNBhcPQMLWNsmgO1V93u6r3N63B2bFlc=

When i run the docker image, i've got this : An error occured Invalid array length

What if you try this, create a package.json file that looks like this:
{
  "name": "coin-hive-docker",
  "version": "1.0.0",
  "scripts": {
    "start": "coin-hive"
  },
  "dependencies": {
    "coin-hive": "^1.8.0"
  },
  "engines": {
    "node": "8.1.2"
  }
}

Add next to it add this Dockerfile:
FROM node:8-slim

# Install latest chrome (dev) package.
# Note: this also installs the necessary libs so we don't need the previous RUN command.
RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - &&\
sh -c 'echo "deb http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google-chrome.list' &&\
apt-get update &&\
apt-get install -y google-chrome-unstable

COPY package.json .
RUN npm install
ENTRYPOINT npm start -- <YOUR-SITE-KEY>

Replace <YOUR-SITE-KEY> at the bottom of the Dockerfile with your actual site key, build and run that.

Thank's for this but, image creation ok and when i run the docker i've got this error :
`npm info it worked if it ends with ok
npm info using<EMAIL_ADDRESS>npm info using<EMAIL_ADDRESS>npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS>start /
coin-hive "PW7YzsuqSUb6O5frye0DGTkqcPFWv4Na"

Initializing...
An error occured Invalid array length
npm info lifecycle<EMAIL_ADDRESS>Failed to exec start script
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: coin-hive "PW7YzsuqSUb6O5frye0DGTkqcPFWv4Na"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!  I just tried it and it worked fine for me:
package.json:
{
  "name": "coin-hive-docker",
  "version": "1.0.0",
  "scripts": {
    "start": "node coin-hive"
  },
  "dependencies": {
    "coin-hive": "latest"
  }
}

coin-hive.js
const CoinHive = require("coin-hive");

(async () => {
  const miner = await CoinHive("3kK4xAVlA6XXVRmuR6RRGYIxEsTku2rn");
  await miner.start();
  miner.on("found", () => console.log("Found!"));
  miner.on("accepted", () => console.log("Accepted!"));
  miner.on("update", data =>
    console.log(`
    Hashes per second: ${data.hashesPerSecond}
    Total hashes: ${data.totalHashes}
    Accepted hashes: ${data.acceptedHashes}
  `)
  );
})();

Dockerfile
FROM node:8-slim
# Install latest chrome (dev) package.
# Note: this also installs the necessary libs so we don't need the previous RUN command.
RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - &&\
sh -c 'echo "deb http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google-chrome.list' &&\
apt-get update &&\
apt-get install -y google-chrome-unstable
COPY package.json .
COPY coin-hive.js .
RUN npm install
ENTRYPOINT npm run start

Add those three files in the same directory, and from that directory run:
$ docker build -t coin-hive .
$ docker run coin-hive

Docker after git clone didn't work for me, but running @cazala scripts (from the last comment) worked fine.
I think the problem is that dependency "coin-hive": "latest" is not at package.json of https://github.com/cazala/coin-hive/blob/master/package.json. (but I didn't check carefully)

Nice ! It's work for me, but i would like to create an image with ENV to pass paramaters (Key, threads and username) throught docker-compose.yml. Do you think it's possible ?

``

@bilyboy785 you have to pass the username in the options object:
const miner = await CoinHive("SITEKEY",{ username: "USERNAME" });

Nice !
I found a way to make works my Dockerfile :
https://paste.bouillaudmartin.fr/?6fe31df40dd93e8f#VaAYAAzTWM/rFQ1W5SmKBwqdS7hhcN4nb+IVXGzHNEk=
But when i add ENV in this, it doesn't work. I'm lost with theses fu***** ENV.
I need to create an image that i can deploy with compose and ENV.

As of version v1.9.1 this Dockerfile is working


trapd00r theme has external dependency

When I use the trapd00r theme I see the following error:
prompt_jnrowe_precmd:3: command not found: zsh_path

This comment says it needs this script to work.
I don't think that's a satisfactory way of working so it would be good to have it integrated.

Right, and when I installed zsh_path, the command prompt threw a much more verbose error, asking for a perl script named Term-ExtendedColor (https://github.com/trapd00r/Term-ExtendedColor and https://github.com/trapd00r/Term-ExtendedColor). I couldn't get it to work, but I also didn't spend much time on it.

I submitted a PR (#5579) with a fix that might or might not make you cringe. It still requires you to have the Term::ExtendedColor module installed, but that could definitely be avoided too, if someone is willing to devise a workaround for the perl code.

I followed this instructions to get the problem fixed:
https://luxing.im/zsh-trapd00r-theme-fix/
Even after installing Term-ExtendedColor, I was getting the error. That is because my system is using /usr/local/bin/perl instead of /usr/bin/perl. I solved the issue by changing the shebang in zsh_path to #!/usr/bin/env perl.

I've pulled @miia's "fix". If any of you can think of a better solution feel free to open a new PR. Thanks!


Set index to fk optionally

Problem
In the case of Mysql (InnoDB), if the index is not explicitly set for the foreign key, the second and subsequent migrations will fail.
e.g.
create_table "departments", force: :cascade do |t|
  t.string "dept_name", limit: 40, null: false
end

create_table "employees", force: :cascade do |t|
  t.date   "birth_date", null: false, comment: "my comment"
  t.string "first_name", limit: 14, null: false
  t.string "last_name", limit: 16, null: false
  t.bigint "department_id", null: false
  # t.index "department_id" #Currently this is necessary
end

add_foreign_key "employees", "departments", name: "employees_fk_departments"

% bundle exec ridgepole -c config/database.yml --apply
-- remove_index("employees", {:name=>"employees_fk_departments"})
[ERROR] Mysql2::Error: Cannot drop index 'employees_fk_departments': needed in a foreign key constraint

Solution
Add --set-index-to-fk option.
Enable this option to set the index when setting the foreign key.
The reason why this behavior is not always performed in the case of Mysql is based on the case where a storage engine other than InnoDB is used and an index is not intentionally added to the foreign key.

Thank you for sending this PR! I got the same issue. I'll review it.

I think we have three options:

Add an option to automatically add indexes to foreign key columns (This PR)
Just display warnings if foreign key columns don't have their indexes

only if the table options include "ENGINE=InnoDB"

In scan_indices_change, ignore indexes whose name are equal to foreign keys, which are likely to be added automatically by InnoDB, if to[:indices] doesn't have any indexes for the columns

only if the table options include "ENGINE=InnoDB"
ridgepole won't drop indexes added automatically by InnoDB

I prefer option 2 or option 3 to option 1 because users who don't know the new option will get the same issue.
@winebarrel What do you think?

@abicky
Thank you for review!
I thought option 2 was good.
Option 3 is likely to cause problems, and option 2 is easier and safer.
@winebarrel
Sorry to bother you, but please check when you have time.

@pharuq @abicky Sorry for the late reply 🙏
I agree with option2 because it is a simple solution

Thank you for reply!
I will implement with option 2.

Created new PR Because the implementation policy has changed significantly.
This closes.
https://github.com/winebarrel/ridgepole/pull/290


Test stripsigns

this PR (to scott's bash->perl branch) also contains the https://github.com/so-fancy/diff-so-fancy/pull/125 PR.
but, in 06b9421 i've added an extra test that currently fails.
you can see the failure in action here. it's using the same git show command that @stevemao introduced before.

hopefully the new symbol stripping fixes this bug.

this might be a bug in git???
here's git --no-pager show --color=never  74804e377d4a54d1173d4393827d4e4b27e4d5d0
check out the indentation before some of the +/-

I assume you're referring to the remaining + and - as the problem?
I've seen git use the second column (in addition to the first) to indicate line additions/deletions but never knew why. I suspect looking at this, it's a three-way merge. It's most likely indicating that the line addition came from file 1, or file 2.

ahhhh yup. three way.. that's why the hunk header is also crazy

This gets a little hairy... we have to basically remove the first two columns of indicators... or maybe three if it's a four way merge?

yup. that's going to be hard for us to reformat successfully, i think.. :/
we could ask git whether that diff is a merge commit and then use some more invasive parsing.
seems like we'll have to put this on the roadmap and admit we have poor support for the moment.

We could look at the diff header, determine how many merges (X) there are and remove the first X-1 columns? That will require some more intelligence in the strip_leading_char() function.

True true.
i'm good with deferring our support for merge commits for now. Would rather get the fundamentals feeling good before we add this kinda complexity.
wdyt

I agree... this is a good roadmap thing. Not a show stopper.

Do you want me to merge this before you can merge the "move functions to perl" in the main repo? Will this break tests?

no, we wont merge this PR. we'll keep the test around for when we want to fully support merge commits.


Formalize endpoint running vs serving and cleanup some tests

What was wrong?
This addresses a few loosely connected issues:

The name attribute on an endpoint was not reliably present.
Running and Serving were started using independent mechanisms but stopped using the same mechanism.
Some of the tests were a little indirect in the way they tested certain things.
The use of a queue for internal events seemed like un-necessary overhead.
No formal API for checking if an endpoint was runnind or serving.
No checks for if already running/serving
No check in core connect_to_endpoint API for whether already connected.

How was it fixed?

Endpoints now always have a name
Firmer distinction between running and serving start and stop methods
Tried to make tests more direct
Removed use of a Queue for internal events in favor of immediate processing.
Added check for whether already serving or running
Added check to connect_to_endpoint API for duplicates.

Cute Animal Picture

None of my pull requests on this repo run the first time I push them.  Anyone else experiencing that?


Can it support Inspector protocol?

I want to debug when python executes js code. I checked some documents of V8, but I am not familiar with C++ and cannot implement this function myself. So, I would like to ask if this feature can be added in subsequent updates.

Hey, interesting idea!
The v8 inspector protocol is pretty extensive! I wonder if you could describe what kinds of things you want to do with it? (E.g., print values, change values, pause execution, profile memory, ...)
It might be noteworthy that as of PyMiniRacer v0.12.0, you can now, finally, make callbacks from JavaScript to Python, which enables crude "print debugging", like this:
$ python
>>> from py_mini_racer import MiniRacer
>>> ctx = MiniRacer()
>>> async def log(s):
...   print(s)
...
>>> async def run_my_code():
...   async with ctx.wrap_py_function(log) as log_js:
...     ctx.eval('this')['log'] = log_js
...     ctx.eval('for (let i = 0; i < 10; i++) { log(i); }')
...
>>> import asyncio
>>> asyncio.run(run_my_code())
0
1
2
3
4
5
...

I'm very sorry that I'm replying to your message just now. What I hope is that I can debug the js code with the help of Chrome's DevTools, and I can pause the program where needed, similar to Pycharm's debugging mode.
I describe it like this, I don't know if it is clear. This feature is great for reverse developers, and I hope you can adopt this suggestion.

@bpcreech I have looked at your example and have the problem that the wrapped function is not called immediately but only when the async contextmanager exits:
$ python
>>> from py_mini_racer import MiniRacer
>>> ctx = MiniRacer()
>>> async def log(s):
...   print(s)
...
>>> async def run_my_code():
...   async with ctx.wrap_py_function(log) as log_js:
...     ctx.eval('this')['log'] = log_js
...     print('before loop')
...     ctx.eval('for (let i = 0; i < 10; i++) { log(i); }')
...     print('after loop')
...   print('after async with')
...
>>> import asyncio
>>> asyncio.run(run_my_code())
before loop
after loop
0
1
2
...
9
after async with

The expectation would be that after loop would be printed after 9 and not before 0. I assume these callbacks are somehow stuck in a loop and get executed when the context is cleaned up.
Is that a bug or am I overseeing something?

Ah, hmm, I think that's either a bug or expectation gap in the code. Because the JS code doesn't await the return value of log, it's basically a race condition if the thing completes or not. If you add await asyncio.sleep(0.5) before the async contextmanager exits, it does print in the expected order.
If we wanted more deterministic logging we'd need to do something like:
import asyncio
from py_mini_racer import MiniRacer
ctx = MiniRacer()
async def log(s):
  print(s)

async def run_my_code():
  async with ctx.wrap_py_function(log) as log_js:
    ctx.eval('this')['log'] = log_js
    print('before loop')
    await ctx.eval('Promise.all(Array(10).keys().map(i => log(i)))')
    print('after loop')
  print('after async with')

asyncio.run(run_my_code())

Not sure if Promise.all will even ensure processing in proper sequence. But anyways if you want to bind e.g. console.log to python (or any other sync function) you cannot use an async function as sync-over-async is bound to fail. So to make that work properly I think two wrap_py_functions are needed - for async and sync.

The sequence isn't relevant in this example since the values are ignored. The purpose here is simply to ensure the function is completed.
You sre write that this is not a drop-in replacement for console.log. it is, however, a functioning way to get logs!
The trouble with a sync wrap_py_function is that it would very quickly deadlock when the wrapped function attempted to call back into v8 for anything including even unpacking an object or array.

The reason I came here was, because I was trying to intercept document.write. I'm parsing web pages with BeautifulSoup and execute the script nodes with MiniRacer. As soon as one of the scripts use document.write, I'd have to adapt the document object in python and execute added script nodes. But these need to be executed before the next script in the original document, so I cannot wait until the async contextmanager exits its scope.
Any idea?

Neat use case! You are sort of building a headless web browser. :)
So we want to serialize operations here while avoiding the world of multithreaded recursion... IIUC we want our Python outer loop (which is running BeautifulSoup) to ensure any calls to document.write have completed before it continues to the next part of the document. Is it possible to create a JS function which calls the Python document writer and stores the promise in a JS global, and use that function as document.write? Then the Python outer loop can find that global and await all the promises in it before proceeding to processing the next HTML fragment.


Show device name on explorer page title

Instead of just "Explorer"

adb devices -l

Fixed in 92059940f16b4bff3f3b28390db5d6241ee114bb


solaredge: Fix energy sensor names

Breaking change that could be included with other 2021.11 breaking changes for solaredge integration.
Fixes key & name for energy sensors as discussed in https://github.com/home-assistant/core/issues/58735

Breaking change

Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[X] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #58735
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[ ] Local tests pass. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist
[ ] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

[ ] No score or internal
[ ] 🥈 Silver
[ ] 🥇 Gold
[ ] 🏆 Platinum

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

Sorry, didn't mean to raise against your fork.


Hc 123 container builder

@mcayanan  my bad, i was curious what the refresh button did next to your approval check mark


Fastcgi (with latest nginx) is serving mobile cache to users on Desktop

Hey,
Any idea how to prevent nginx from serving cached mobile pages to users on Desktop?
I'm using WP Rocket with this configuration
Thank you

The configuration should not serve mobile pages to desktop users.
WP-Rocket gives you the option to have your pages being responsive or save one version for desktop and one version for mobile.
Please be more specific and give a real use case so it can be validated.

@maximejobin Sometimes we need to use separate theme for WordPress and this is important to store mobile cache as different version.  I know it's difficult to check each request is mobile or not but possible this will great.

It is not possible to detect if it is a mobile or desktop device from Rocket-Nginx. I tried to do it but there are so many validations to do that it made every request slower. More than that, there was no way I could do all validations because NGINX's configuration "coding" is not a real langugage.

This should work for a majority of cases, append the $is_mobile var to the cache key.
Map Mobile
map $http_user_agent $is_mobile {
default 0;
~*android|ip(hone|od)|windows\s+(?:ce|phone) 1;
~*symbian|sonyericsson|samsung|lg|blackberry 1;
~*mobile 1;
}

The reason I did not do it is basically because it's incomplete. By doing that, I know people will create tickets asking to add X or Y phone.
I might have to develop a way to add plugins! ;-)

Majority of mobile market share is Android, iPhone, and the remainder list above. Feel free to make it configurable or optional if you prefer.

The problem with "map" is that it impacts EVERY request. That is why I decided to not implement it. I will close this thread as it has derailed from the previous request. If you want to create a specific discussion for mobile detection, please create a new one.


Avoid reimporting modules

With this commit we reenable the pylint check W0404 which checks
whether an import has already been imported.
Relates #838

@elasticmachine update branch


Spatial camera unselectable in editor and icon gizmo not shown

Godot version
v3.4.beta5.official
System information
Windows 10 gles 3
Issue description
As shown on screenshot:

Worked in 3.3.2 and 3.3.3 where I also tested.

Steps to reproduce
Create a 3d scene and add camera with the + button. It doesn't matter if it's an old scene or just created.
Minimal reproduction project
No response

Just an addition: lights and other nodes that show up as similar icons seem to work.

The camera icon gizmo was removed by design: https://github.com/godotengine/godot/pull/35784

It was confusing, but it also prevents selecting the camera by clicking on it. It's premature to remove the icon if it causes this issue.


cleanup(metrics): improve prometheus and plugin metrics info

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:
Improve prometheus and plugin metrics info, see https://github.com/falcosecurity/falco/issues/3229
@sgaist would you mind helping with the review? Thank you!
@sboschman are these updates ok? Do you have additional input?
CC @Issif
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incertum
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I guess the added plugin section at least tempers expectations for now. Not sure if I understand the design behind it and how it is supposed to look in the future. Will add a comment to #3194 for clarity.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incertum, sgaist
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum, LucaGuerra, sgaist
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 7b77c8d9d3d80d525d54af64ddace00f2c3d143d


[SPARK-40787][SQL][TESTS] Check error classes in SparkSqlParserSuite

What changes were proposed in this pull request?
This PR aims to replace 'intercept' with 'Check error classes' in SparkSqlParserSuite.
Why are the changes needed?
The changes improve the error framework.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suite:
$ build/sbt "test:testOnly *SparkSqlParserSuite"

cc @MaxGekk


_write_parameter_expression takes version parameter

Summary
@jakelishman version was added as a new argument here which I believe caused our unit tests against Qiskit/main to start failing. Is this the correct way to handle version from the provider?
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 3 (66.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.009%) to 82.754%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/utils/json.py
2
3
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.009%

Covered Lines:
6238

Relevant Lines:
7538

💛  - Coveralls

From the Slack discussion I think we can just drop the support for ParameterExpression type, since it's not an input type to primitives anymore.

From the Slack discussion I think we can just drop the support for ParameterExpression type, since it's not an input type to primitives anymore.

Closing this PR, i'll open a separate one


Added disable to chip and search box components

So..
Just the Chip component should change 'opacity' based on the 'disabled' prop.
The SearchBar component should only change icon (search and clear icons) colors to gray (some shade of gray) based on the 'disabled' prop.


Error mounting /dev/mapper something.

Stopped a container with Fig. Tried to restart it. Got:
Cannot start container ff7f76...17a4e4: Error getting container ff7f...e827
8017a4e4 from driver devicemapper: mkdir /var/lib/docker/devicemapper/mnt/ff7f76...7a4e4/rootfs: input/output error
Rebooted. now i get this trying to fig up
root@# fig up -d
Recreating iamdev_postgres_1...
Error mounting '/dev/mapper/docker-202:2-359...bc8-init' on '/var/lib/docker/devicemapper/mnt/bab1de5...dbc8-init': invalid argument
docker version
Client version: 1.4.1
Client API version: 1.16
Go version (client): go1.3.3
Git commit (client): 5bc2ff8
OS/Arch (client): linux/amd64
Server version: 1.4.1
Server API version: 1.16
Go version (server): go1.3.3
Git commit (server): 5bc2ff8
Linux host.example.com 3.13.0-40-generic #69-Ubuntu SMP Thu Nov 13 17:53:56 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

This machine its totally borked. Removed /var/lib/docker/* and tried to fig build but it doesnt complete now. Its a VM on Softlayer.

Usually when I have had related issues in the past I have had to manually umount the directories it is complaining about in addition to removing /var/lib/docker.  Make sure you restart the Docker daemon too.

After reading https://github.com/docker/docker/issues/4036 it appears this was an issue with docker not using AUFS (using device mapper instead.)
Installed aufs:
sudo apt-get install linux-image-extra-$(uname -r)

Removed docker, removed /var/lib/docker/*
apt-get remove lxc-docker
rm -rf /var/lib/docker/*

reinstalled docker latest:
curl -sSL https://get.docker.com/ubuntu/ | sudo sh

Build and launch now works. Closing this ticket.

Did you run out of space?

@RoelVdP Nope, it appears that the softlayer VMs don't come with the linux-image-extra kernel modules so docker falls back to using devicemapper instead of aufs.

@RoelVdP personnaly I ran out of space, then I extended my FS . After rebooting the container don't start with :
Error response from daemon: Cannot start container 78e461b4b85e: Error getting container 78e461b4b85ec399e0bc94bbfbce9d291b5b849aebba89e5f64f2ba8df384439 from driver devicemapper: Error mounting '/dev/mapper/docker-253:0-33661794-78e461b4b85ec399e0bc94bbfbce9d291b5b849aebba89e5f64f2ba8df384439' on '/var/lib/docker/devicemapper/mnt/78e461b4b85ec399e0bc94bbfbce9d291b5b849aebba89e5f64f2ba8df384439': invalid argument
Error: failed to start containers: [78e461b4b85e]
I tried to restart docker, reboot or umount /var/lib/docker/devicemapper/mnt/78e461b4b85ec399e0bc94bbfbce9d291b5b849aebba89e5f64f2ba8df384439 , unsuccessfully .

@Xat59 :( hope the container was not too important/complex

@RoelVdP it was not but this is not reassuring .
Is this problem unfixeable ?
Thank

Hi @Xat59 no idea, sorry

@Xat59 see https://github.com/docker/docker/pull/20786 to prevent it from happening

I tried to restart docker, reboot or umount ,but it doesn't work.

rm -rf /var/lib/docker/ worked for me.

I ran into this issue on Fedora 25 after stopping my containers and rebooting.  Apparently aufs isn;t supported by Fedora so I installed fuionfs and removed the contents of /var/lib/docker ... after my images downloaded/built ... all is well.


Secret Store Sample (#175)

Description
Please explain the changes you've made
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] The sample code compiles correctly
[ ] You've tested new builds of the sample if you changed sample code
[x] You've updated the sample's README if necessary

@orizohar - Took care of your last comment. I deleted the remote branch and recreated it. That closed PR: https://github.com/dapr/samples/pull/212

Will merge this one if you approve. @youngbupark had already approved the earlier one


update document api for marshmallow v2.15.3

Summary of Changes

This change to the version of marshmallow (the version used in the other Amundsen services) broke the Document API because the unknown parameter it was using is not available until marshmallow 3.0.0+
PR updates the API to work with marshmallow v2.15.3

Tests

Modified tests for Document API so they do not mock the schema and would have caught this error

Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes make test

thanks!


Fix onboarding search UI for iPhone

This ticket has a different ‘fixed’ look: https://github.com/artsy/eigen/issues/156, which should it be?


Update e2e tests to use local icons

What
Update e2e tests to use local icons instead of those from Fluent's CDN
Why
Prevent flakiness in tests.
This is a stopgap fix to prevent flakiness today. The real fix is stop using icons from Fluent's CDN everywhere (tracked in another bug)
How Tested
See PR for updated snapshots.
Icon styling isn't great (e.g. chevrondown icon is not vertically centered, see onion-skin diff below), but this would be tackled in the actual fix to stop using fluent's font icons

I'm worried that we'll start getting lots of review comments about misaligned icons in the snapshots, or worse learn to ignore these misalignments and let real bugs slip through.

I'm worried that we'll start getting lots of review comments about misaligned icons in the snapshots, or worse learn to ignore these misalignments and let real bugs slip through.

I agree. This basically is a real bug though -- it's not easy for contoso to set icons that are aligned correctly, but having flakiness is blocking having landscape tests so I'd like to check in regardless.
One mitigation would be to only set the people and chevronRight icons as they are the flakiness culprits

I'm worried that we'll start getting lots of review comments about misaligned icons in the snapshots, or worse learn to ignore these misalignments and let real bugs slip through.

I agree. This basically is a real bug though -- it's not easy for contoso to set icons that are aligned correctly, but having flakiness is blocking having landscape tests so I'd like to check in regardless. One mitigation would be to only set the people and chevronRight icons as they are the flakiness culprits. But really we need the proper fix to remove the use of fluent's font icons, discussion here: teams.microsoft.com/l/message/...

LGTM so we can get landscape tests. Let's see what we can do about those misaligned icons.

I am confused.
I thought fluent doesn't contain any icons and all of them needed to be downloaded from a CDN?

I am confused. I thought fluent doesn't contain any icons and all of them needed to be downloaded from a CDN?

We use a package called @fluentui/react-icons for most of our icons, these are local SVGs that are bundled. However, we still have some instances where we use the fluent CDN font icons


Interpunction is missing on WordLevelTimestamps for continuous recognition.

Describe the bug
Missing interpunction on WordLevelTimestamp entries eventhough it is present in privText
{
  "privText": "La prochaine réunion de la Commission Harlem, maintenant l'Assemblée régionale et l'école euroméditerranée se tiendra à Rabat dans une.",
  "Words": [
    {
      "Word": "la",
      "Offset":<PHONE_NUMBER>,
      "Duration": 1700000
    },
    {
      "Word": "prochaine",
      "Offset":<PHONE_NUMBER>,
      "Duration": 3100000
    },
    {
      "Word": "réunion",
      "Offset":<PHONE_NUMBER>,
      "Duration": 4100000
    },
    {
      "Word": "de",
      "Offset":<PHONE_NUMBER>,
      "Duration": 2300000
    },
    {
      "Word": "la",
      "Offset":<PHONE_NUMBER>,
      "Duration": 3300000
    },
    {
      "Word": "commission",
      "Offset":<PHONE_NUMBER>,
      "Duration": 6700000
    },
    {
      "Word": "harlem",
      "Offset":<PHONE_NUMBER>,
      "Duration": 6900000
    },
    {
      "Word": "maintenant",
      "Offset":<PHONE_NUMBER>,
      "Duration": 6000000
    },
    {
      "Word": "l'assemblée",
      "Offset":<PHONE_NUMBER>,
      "Duration": 3300000
    },
    {
      "Word": "régionale",
      "Offset":<PHONE_NUMBER>,
      "Duration": 3500000
    },
    {
      "Word": "et",
      "Offset":<PHONE_NUMBER>,
      "Duration": 900000
    },
    {
      "Word": "l'école",
      "Offset":<PHONE_NUMBER>,
      "Duration": 3300000
    },
    {
      "Word": "euroméditerranée",
      "Offset":<PHONE_NUMBER>,
      "Duration": 7500000
    },
    {
      "Word": "se",
      "Offset":<PHONE_NUMBER>,
      "Duration": 1900000
    },
    {
      "Word": "tiendra",
      "Offset":<PHONE_NUMBER>,
      "Duration": 3500000
    },
    {
      "Word": "à",
      "Offset":<PHONE_NUMBER>,
      "Duration": 2200000
    },
    {
      "Word": "rabat",
      "Offset":<PHONE_NUMBER>,
      "Duration": 5800000
    },
    {
      "Word": "dans",
      "Offset":<PHONE_NUMBER>,
      "Duration": 1500000
    },
    {
      "Word": "une",
      "Offset":<PHONE_NUMBER>,
      "Duration": 1700000
    }
  ]
}

With the inability to limit text segment length we are looking to sentence break long segments ourselves, but it appears there's no stable way of doing this through your service as outlined here: https://www.bbc.co.uk/accessibility/forproducts/guides/subtitles/#Line-breaks
Expected behavior
Your service should allow developers to have the ability to correctly render subtitle formats as outlined on https://www.bbc.co.uk/accessibility/forproducts/guides/subtitles/#Line-breaks by either limiting the length of returned segments or provide a transparent way to word wrap based on interpunction through use of WordLevelTimestamp entries.

Internal work item ref. 5415812.

Closing the issue as we now have a work item for the feature request on the backlog - no ETA. We'll update here when there is a release plan for it.


Wrapping app-router in another element for reuse

First of all, thank you for this excellent component.
I have a number of apps that would require some common routes, so I thought I'd be able to accomplish this with a new element, eg, our-routes that used app-router:
<polymer-element name="our-routes" noscript>
  <template>
    <app-router mode="hash">
      <app-route path="/login" element="our-login"></app-route>
      <content></content>
      <app-route path="*" element="our-not-found"></app-route>
    </app-router>
  </template>
</polymer-element>

An example from an app:
<our-routes>
  <app-route path="/" element="page-home"></app-route>
  <app-route path="/locations" element="page-locations"></app-route>
  <app-route path="/alarms" element="page-alarms"></app-route>
</our-routes>

The problem here is that, while routing to our-login and our-not-found works flawlessly, any app-route inserted via content is ignored. (Not available early enough for app-router to see it? I'll admit to plenty of ignorance when it comes to the intricacies of polymer load order and how that might interact with vanilla custom elements).
Am I approaching this problem incorrectly? Would there be a better way to package up "standard" routes, essentially extending app-router (notably, I couldn't get this working with a polymer extends of app-router, either).

The concept seems right. That's the correct way to use <content> to insert DOM.
This is the code that loops over the <app-route>s https://github.com/erikringsmuth/app-router/blob/master/src/app-router.js#L188. You could try debugging here and see if it's missing the routes in <content>. Beyond that everything looks right.

My guess is the issue is with route = route.nextSibling -- maybe that needs to take into account how elements are inserted via <content></content>. I'll investigate; thanks for the pointer.

Verified that's the problem.
In short, the structure ends up looking like:
our-routes
  #shadow-root
    app-router
      app-route (our-login)
      content
      app-route (our-not-found)
  app-route (page-not-found)
  app-route (page-locations)
  app-route (page-alarms)

So, the app-routes provided as content end up outside the shadow dom (and aren't actually nested under app-route to be found by nextSibling).

Hm, the reason I went with router.firstElementChild and route.nextSibling is that router.querySelectorAll('app-route') will select all children <app-route>s. The problem is that a page like page-alarms may also contain a router inside of it and I don't want to select those routes, just the direct decedents of the current router. I'm not sure what to do to select routes projected using the <content> tag.

Yeah, I can definitely understand that.
What about something like: the app-route children of the app-router plus (if I'm inside a shadow dom), the app-route children of the shadow dom's parent?

Actually, since order matters, running into a content should cause the check to occur. I'll do a PR after I get it to work for your review.

Seeing the code changed my mind about the <content> tag https://github.com/erikringsmuth/app-router/pull/97/files#diff-8f495b0b37d1611ef1e4046e099aa7e1R181. The <content> isn't adding benefit here since it only "projects" the elements at render time and doesn't actually move anything in the DOM tree.
It also doesn't take into account the select attribute like this.
<content select=".routes"></content>

That's not the real issue though. Since it doesn't modify the DOM tree and projection doesn't cleanly help us determine which routes are in the light DOM, the <content> tag is out as a solution. I also found out router.querySelectorAll('app-route') won't select projected content.
I'm not sure what to look at next, but there may still be a way to do something like this.

I'm not sure I see the importance of the distinction between render-time projected elements and elements in the DOM, given that app-route elements can be reliably collected. No, it's not a single call (ie, querySelectorAll -- and while I've seen people use /deep/ and ::content I'm not sure that would help) -- but valid app-route elements would be children of the shadow root .host.
Since select is only used to check the direct descendants (children) anyway, it seems like would be fairly trivial to check candidate elements with, eg, matches()' in the while`.

if (element.toString() === "[object ShadowRoot]") { ... and if (route.tagName === 'CONTENT') { ... may work, but I really don't like how hacky it is. If a selector like router.querySelectorAll(':host /local/ > app-route') were defined in the future where /local/ queried the children including projected children, that'd be ideal, but this feels like a big hack at this point.

I agree it's "hacky" (although, the tagName checking is exactly what you do for APP-ROUTE above, and I mentioned alternatives for the toString in the PR if iframes aren't a concern) -- but necessary (as far as I can see) precisely because the facility you want doesn't exist yet.
I'll give a shot later in the week and tracking down something more direct. In the meantime I can use app-router for our apps off my fork, treating this as I would a polyfill.
Thanks for looking at it.


User question: ktrain without an internet connection, can't fine the folder, and resuming training

Hello Arun,
You have a very good documentation. I have 2 issues. I wanted to finish the training for such large dataset. Sometimes in Colab (I have already consumed 4 days of GPU in Colab) and home PC with 4 gb GPU - My notebook  . It's difficult but I want to finish it.

While I downloaded all files, tf_model.h5, config.json and vocab.txt and kept in 'Download/model', it still tries to get to huggingface jason file link or the local folder, cant find it. I'm on Windows 10, Anaconda and

import ktrain
from ktrain import text
t = text.Transformer('Download/model', maxlen=500)
and,

While I was resuming the training from an interrupted (ctrl+c) and clicking on Colab, save and downloaded 3 files to resume it

model = ktrain.load_predictor('Download/model').model
While I re-instantiate Learner and continue training
learner = ktrain.get_learner(model, train_data=trn, val_data=val, batch_size=2)
It asks me trn and val, and then I have to go back to start other items, and takes time once again
MODEL_NAME = 'sagorsarker/bangla-bert-base'
t = text.Transformer(MODEL_NAME, maxlen=500)
and this, takes 60 mins,
trn = t.preprocess_train(X_train, y_train)
val = t.preprocess_test(X_test, y_test)
and
model = t.get_classifier() takes more time.
I needed to train, but I fell back to do all these.
learner.fit_onecycle(2e-5, 1)
Somewhere in your doc, you mentioned,
from ktrain import text
MODEL_NAME = 'distilbert-base-uncased'
dummy_texts = ['আমি এক', 'তুমি এক', 'সে এক']
dummy_labels = ['আমি', 'তুমি', 'সে']
t = text.Transformer(MODEL_NAME, maxlen=500)
trn = t.preprocess_train(dummy_texts, dummy_labels)
And this one gets longer, I wanted to run it from local folder.
model = t.get_classifier()
Does that mean, I can always start with dummy text and labels just to get the trn value?
Thank you.

Hello,
This question was just answered in #295 .  Basically, when loading a local model using Transformer you need to ensure the tokenizer files (which are very small) are included in the folder or you need to manually set the tokenizer yourself before calling preprocess_train.
Also, here is an FAQ entry that explains how to resume training.  This assumes you can get through a complete epoch on Google Colab.  If not, you'll need to use the steps_per_epoch argument that you requested earlier.
Thanks.

Thank you. You mean to say, I need to have small tokenizer file like dummy files, right? What would be the extension of those files?
I'll create the tokenizer files like,
dummy_texts = ['hello world', 'goodbye world', 'hi world']
dummy_labels = ['hello', 'bye', 'hello']
and then call them by
trn = t.preprocess_train(dummy_texts, dummy_labels)
Will it create any files?
I'll try these. Thank you.
Thank you once again.

Hi:
No, by "tokenizer files" I'm referring to files like vocab.txt that are downloaded directly from Hugging Face when doing something like: tokenizer = AutoTokenizer.from_pretrained('distilbert-base-uncased').   But, I just saw in your post that you seem to already have that file (missed that before).   I know that if you name the download folder with the model name in it, Hugging  Face tries and fails to download from internet.  So, maybe try giving a more vague name like /tmp/mymodel/, if that's what is going on.
Please also see this FAQ along with information in the other post I referenced, which may help.

Thank you. I'll try that too.


SAML Secured Endpoints

Example
Here's a self-contained, minimal, reproducible, example with my use case:

from fastapi import  FastAPI, HTTPException, Request
import app.SAML_Interface as SAML_Interface
from starlette.responses import RedirectResponse

@app.post("/acs")
async def acs(request: Request):
    try:
        form = await request.form()
        samlResponse = form["SAMLResponse"]
        #ACS URL listed here:
        strAcsUrl = 'http://localhost:6321/acs'

        if SAML_Interface.SAML_Response.ParseSAMLResponse(strAcsUrl,samlResponse)[0]:

           userId = SAML_Interface.SAML_Response.ParseSAMLResponse(strAcsUrl,samlResponse)[1]

        else:
            raise HTTPException(status_code=401)
    except KeyError:
        raise HTTPException(status_code=401)

@app.post("/login")
def login():

    strAcsUrl = 'http://localhost:6321/acs'
    #Issuer URL listed here:
    strIssuer = '***********************'
    #Sign In URL listed here:
    strSingleSignOnURL = '**********************************'
    return RedirectResponse('{uIDPUrl}?{bParams}'.format(uIDPUrl = strSingleSignOnURL, bParams = SAML_Interface.SAML_Request.GetSAMLRequest(strAcsUrl, strIssuer)))

Description
I am currently trying to implement SAML auth for my API.  The basic workflow is that the user will visit /login of course this endpoints redirects to the SAML url and upon return users are passed to the /acs/ endpoint.   I have the login working and I am getting data about the user returned (ie userId variable).  My question is how can I use the data that is returned to secure my endpoints?  I am basically trying to do something like if a user utilizes another endpoint, say /home/ but userId is None then raise HTTPException(status_code=401).
Environment

OS: Windows 10

FastAPI Version: 0.61.0

Python version: 3.7

Additional Context
I would like to be able to use credentials and the user roles return from SAML to create multi-tenancy for my APIs data (ie users can only see data they create).

from fastapi import  FastAPI, HTTPException, Request
import app.SAML_Interface as SAML_Interface
from starlette.responses import RedirectResponse
from fastapi.security import APIKeyCookie

cookie_sec = APIKeyCookie(name="session")
secret_key = 'key'

def get_current_user(session: str = Depends(cookie_sec)):
    try:
        sess = jwt.decode(session, secret_key)
        return sess['userId']
    except Exception:
        raise HTTPException(
            status_code=401, detail="Invalid authentication"
        )

@app.post("/acs")
async def acs(request: Request):
    try:
        form = await request.form()
        samlResponse = form["SAMLResponse"]
        #ACS URL listed here:
        strAcsUrl = 'http://localhost:6321/acs'

        if SAML_Interface.SAML_Response.ParseSAMLResponse(strAcsUrl,samlResponse)[0]:

           userId = SAML_Interface.SAML_Response.ParseSAMLResponse(strAcsUrl,samlResponse)[1]

        else:
            raise HTTPException(status_code=401)
    except KeyError:
        raise HTTPException(status_code=401)

@app.post("/login")
def login():

    strAcsUrl = 'http://localhost:6321/acs'
    #Issuer URL listed here:
    strIssuer = '***********************'
    #Sign In URL listed here:
    strSingleSignOnURL = '**********************************'
    return RedirectResponse('{uIDPUrl}?{bParams}'.format(uIDPUrl = strSingleSignOnURL, bParams = SAML_Interface.SAML_Request.GetSAMLRequest(strAcsUrl, strIssuer)))

@app.post('/private')
@app.get('/private')
def read(session: str = Depends(get_current_user)):
    return session

Never mind, I did figure things out.  I just encoded the data and stored the object in APIKeyCookie then make subsequent endpoints depend on the get_current_user function.  Hope this helps someone else.

Thanks for reporting back and closing the issue :+1:

If anyone else is looking for an example SAML implementation in FastAPI, check out this answer


More RuntimeService tests

plus toFile throws ConfigurationError.

The throw may result in API break! Not sure whether to keep it.

Code is now included in the refactorings branch. I close this PR.


CASSANDRA-18508 Enhancing sensitive JMX SSL Config

The Cassandra Jira 18508.
This PR enhances ability to specify JMX SSL configuration via cassandra.yaml in the same way it can be done for Native transport/Internode messaging using encryption_options. This removes the need for specifying sensitive configuration for JMX SSL like key/trust store passwords in cassandra-env.sh. This PR also adds required unit and integration tests for JMX SSL configuration covering existing code prior to this change.

@smiklosovic I've fixed the latest failing test and pushed the commit. However, now I am running ALL unit tests locally to validate if anything fails due to the jmx encryption options. It would take some time to finish it though. Will post what I find.

@smiklosovic I moved the JMX test method to a utility class and added ERROR level log for each error before adding it to the suppressed list. Let us see if this helps us identify flakiness in the test.


werkzeug.http.parse_accept_header should parse Accept parameters

First of all, the HTTP spec on the Accept header states that:

Each media-range might be followed by zero or more applicable media type parameters (e.g., charset), an optional "q" parameter for indicating a relative weight (Section 5.3.1), and then zero or more extension parameters.

Considering this, an Accept header like Accept: application/vnd.api+json; charset=utf-8 is valid.
However, if you use parse_accept_header on such a header, the charset option will not be extracted:
>>> from werkzeug.http import parse_accept_header
>>> from werkzeug.datastructures import MIMEAccept
>>> parse_accept_header('Accept: application/json; charset=utf-8')
Accept([('application/vnd.api+json; charset=utf-8', 1), ('Accept:', 1)])
>>> parse_accept_header('Accept: application/json; charset=utf-8', MIMEAccept)
MIMEAccept([('application/vnd.api+json; charset=utf-8', 1), ('Accept:', 1)])

This has implications for content negotiation, whereby your server supports application/json but the user includes a charset, meaning that it will neither match with the best property, nor best_match unless the charset also matches:
>>> from werkzeug.http import parse_accept_header
>>> from werkzeug.datastructures import MIMEAccept
>>> acc = parse_accept_header('Accept: application/vnd.api+json; charset=utf-8', MIMEAccept)
>>> acc.best
'application/vnd.api+json; charset=utf-8'
>>> acc.best_match(['application/json'])

(this last invocation returns None)
I notice that parse_options_header does work correctly for this header, but this would need to be applied to each Accept in the list of types:
>>> from werkzeug.http import parse_options_header
>>> parse_options_header('application/json; charset=utf-8')
('application/vnd.api+json', {'charset': 'utf-8'})

I'm happy to write a PR for this, by the way. I just want confirmation that this is in scope for werkzeug.

First off, which version of Werkzeug are you using. I cannot get the same responses from the provided code snippets.
Second, it appears you are mixing apples and oranges hear. Parsing the header and getting a match are very different. In that manner, parse_options_header and parse_accept_header are very similar although they are intended to be different. Matching, as far as I can ascertain from re-reading the spec is working as expected. Your accept statement provides one type with a charset option. It does not allow for a type without the charset of utf-8. Therfore, it will not match a type without the a charset of utf-8. If you were to provided a utf-8
charset for in matching acc.best_match(['application/json;charset=utf-8'] or an option without a charset  parse_accept_header('Accept: application/json, application/json; charset=utf-8', MIMEAccept), you would get a match.
It would appear from the spec that If you want to treat character sets out side of content types, you should use the Accept-Charset header: https://tools.ietf.org/html/rfc7231#section-5.3.3.

I get this on all versions of Werkzeug, but I just tested it on 0.16.0 and got the same results.
I think you might be right though. If the client is asking for charset=utf-8, then it means it will only accept application/json if it has this charset, meaning that a literal match is still appropriate. I'm further convinced because, using format=flowed as an example, the spec says:

For example,
Accept: text/*, text/plain, text/plain;format=flowed, */*
have the following precedence:
1.  text/plain;format=flowed
2.  text/plain
3.  text/*
4.  /

But, having said that, I can see a common use-case where we're we are hosting a server that supports application/json, and is happy to reply with any unicode encoding, specified either with charset= in Accept, or with Accept-Charset.
If we use Werkzeug's best_match to determine if there was a valid Accept header, our server will always 406 Not Acceptable, when in fact we would much rather Werkzeug treats application/json;charset=utf-8 equivalently to:
Accept: application/json
Accept-Charset: utf-8

But yes, I guess I'm more talking about matching mimetypes rather than parsing headers here. But I still think there's a need that Werkzeug doesn't fulfil.

So, werkzeug is properly implementation of the specification as I read it. The specification portion you're pointing out is that the most specific match should win. You must get more specific in the match not less specific. Dropping the extension when matching would make it less specific. By the logic you proposed and the specification that applies, the following request
HTTP 1.1 GET /
Accept: application/json;charset=utf-8

could match properly to application/json for MIME type and latin1 for Character Set as any character set passed would pass the check thanks to the lack of an Accept-Charset header. The spec says:

A request without any Accept-Charset header field implies that the  user agent will accept any charset in response.

I get that it doesn't seem to make sense; but, it would appear that you need to specify all the possible supported character sets using the charset extension if you want to support the amazingly valid use case according to the specification. Each header is processed separately and has to be to satisfy the specification.


Form fill causes casper to die if form field doesn't exist

I currently have an issue with the fill method whereby if a form field doesn't exist, casper dies with a CasperError. Ideally this should also fail the test if it is within a test. Not sure what it should do in non-test scenario though!
It also occurs that when trying to fill in a form, there is no guarantee we have an assert to catch the CasperError to mark as failed. This feature would be excellent when grouped in the proposed testSuite function such as in Issue #56

I'm trying to write enter a question title with the following casperjs but Casper fails to recognize the text input feild.
Here is my code: casper.then(function(){ this.fillXPath('form', { 'html body div#app-root.spg-survey-wrapper div.sp-survey main.sp-survey-content section.sp-question-container div#question-editor section.sp-question-editor-wrapper.sp-question-editor-wrapper-no-footer main.sp-question-canvas textarea.sp-question-title': 'Question One'}, true); });
casper.then(function() {
this.fillXPath('form', {
'html body div#app-root.spg-survey-wrapper div.sp-survey main.sp-survey-content section.sp-question-container div#question-editor section.sp-question-editor-wrapper.sp-question-editor-wrapper-no-footer main.sp-question-canvas textarea.sp-question-title': 'Question One'
}, true);
});
Here is the the inspect element:

Thanks


Updating code to be able to handle newest versions of react native

As you can see, I made few changes to handle the newest react native version. According to the react native documentation, packages should no more be managed in Activity but in Application. Also, we cannot give an activity to the constructor any more 'cause it is now handled in Application but the ReactContextBaseJavaModule class provides a method to get the Activity.
Friendly

I have seen a pull request for upgrading already ... I missed some code in there so ...


document that adata.X is None in v2 docs

Developing new methods is confusing for anyone who has worked with anndata before, as typically you would expect that adata.X would not be None. At the very least this needs to be documented. Partially addresses https://github.com/openproblems-bio/openproblems-v2/issues/120

The thing is that the AnnData format depends on what's defined in the api/comp_method.yml spec. So in the documentation I can't specify which slots are going to be there other than checking out the contents of this file, reading in the example datataset and printing it out, or building a per-task reference documentation. Agreed?

In that case I would just require that X be set? Seems more straightforward and in line with standard use of AnnData objects. We could consult with scanpy folks if you disagree but it seems pretty reasonable to assert that adata.X is defined.


How to add a reducer in a store enhancer?

This is my version of applyMiddleware in use in redux-tiny-router

function compose(...funcs) {
    return funcs.reduceRight((composed, f) => f(composed));
}

function is_server() {
    return ! (typeof window != 'undefined' && window.document);
}

export function applyMiddleware(...middlewares) {
    return (next) => (reducer, initialState) => {

        function reducerEnhancer (state,action){
            //need to find a way to stick my reducer in here and allow client to call combineReducers
            Object.assign(reducer,tinyReducer,reducer);
            var res = combineReducers(reducer);
            return res(state,action);
        }

        var store = next(reducerEnhancer, initialState);

        middlewares.push(tinyMiddleware);

        if (__UNIVERSAL__ && !__CLIENT__){
            middlewares.unshift(tinyUniversal);
        }

        var dispatch = store.dispatch;
        var chain = [];

        var middlewareAPI = {
            getState: store.getState,
            dispatch: (action) => dispatch(action)
        };
        chain = middlewares.map(middleware => middleware(middlewareAPI));
        dispatch = compose(...chain, store.dispatch);

        var result = {
            ...store,
            dispatch
        };

        if (__CLIENT__){
            init(result);
       }

        return result;

    };
}

it works for adding my custom middleware but i need to add my custom reducer in there too, in my failure to do that, i did this above:
    function reducerEnhancer (state,action){
            //need to find a way to stick my reducer in here and allow client to call combineReducers
            Object.assign(reducer,tinyReducer,reducer);
            var res = combineReducers(reducer);
            return res(state,action);

        }
        var store = next(reducerEnhancer, initialState);

so users can't combineReducers, they just pass in the object and my enhancer will combine for them, but i want to allow them to pass the combined reducers and just add on mine, how do i do that?

Can you explain why you want your own applyMiddleware instead of the one that ships with Redux?

It seems that you might be better off exporting middleware and reducer and asking the user to explicitly use them.

@gearon, I "overload" applyMiddleware to insert the router middleware and to bootstrap the router, you think this should be an separate enhancer?  maybe there should be a canonical way of modifying the the redux create store process, just a crazy idea, some wrapper function that receives all functions and its arguments, that have the opportunity to process them?, something like
combineReducers(reducers)  returns an object with do() function and its arguments as properties
applyMiddleware(....) the same thing, returns a object with a do() and all arguments as properties
then this wrapper function has access to all the process, one can then modify the arguments and then calls do(...) on each to have the final product, sorta of an more sophisticated compose, but with the intent from the start to be used to modify the creation procedure.

Can you not just instruct the user to include the tinyMiddleware whenever they are creating their store? It doesn't seem to be that unreasonable of an install request. The devtools have you do essentially the same thing, just at a higher level.

@timdorr I was doing this, and it was fine, replacing applyMiddleware is a better choice, as it frees the user to place the middleware at any order, as that has consequences for the router, the thing is replacing applyMiddleware or even combineReducers works fine, and its not too much to ask, i just bring this up as to start a conversation as "patching" core elements as an api does not seems to be a good idea.
Suppose for instance another lib is written that does something else, that also patches applyMiddleware, and combineReducers, now there is a conflict, the user can't use both.

If I were to use rtr( which I'm looking into), I would want there to be no
magic. I'd want to have the same interaction with redux that I already do:
register reducers, add middleware via compose, bind action creators.
Having a reducer modifying the state tree but not being able to see it when
looking at the reducer code is sub optimal imo because now when a new
developer needs to work on the project, they can't "just read the code".
On Thu, Sep 3, 2015 at 1:53 AM Guilherme Guerchmann <
<EMAIL_ADDRESS>wrote:

@timdorr https://github.com/timdorr I was doing this, and it was fine,
replacing applyMiddleware is a better choice, as it frees the user to place
the middleware at any order, as that has consequences for the router, the
thing is replacing applyMiddleware or even combineReducers works fine, and
its not too much to ask, i just bring this up as to start a conversation as
"patching" core elements as an api does not seems to be a good idea.
Suppose for instance another lib is written that does something else, that
also patches applyMiddleware, and combineReducers, now there is a conflict,
the user can't use both.
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/redux/issues/678#issuecomment-137343483.

It's better to export the primitives (middleware, reducer) and give user control over them, than to hide it.
Otherwise every other library will want to “own” applyMiddleware and it'll be a mess.

@gaearon yes, what i am doing now is both, having two choices as to how to bring rtr in, one for convenience, and the other for compatibility.  @danmartinez101 There are no shenanigans inside applyMiddleware, its just adding the router middleware. i will do the same to combineReducers, to remove  reducerEnhancer.


[BUG] Cannot delete an user from the list

Describe the bug
I'm trying to delete a user I've created. When I look at the documentation, it says :
To delete a user, navigate to /settings/users in your browser. Locate the Users table and click the action menu button (three dots) for the user you wish to delete.
However, I can't find the menu button for deleting a user.
I used the Docker image aaronleopold/stump:nightly, aaronleopold/stump:0.0.4 and aaronleopold/stump:0.0.3 and no one of these versions have a menu button in the users table.
To Reproduce
As administrator, create a user with rights. Still as admin, go to /settings/users to display the list of users.
As Server Owner:

Go to '/settings/users'
Click on 'Create User'
reload the page '/settings/users'
the new user appears in the list but without a menu

Expected behavior
I don't know if this feature is currently under development. I assume it should be present as it is documented.
Maybe I'm using the wrong Docker image or a wrong config... .
Screenshots

Docker config:
services:

  stump:
    image: aaronleopold/stump:nightly
    container_name: stump
    volumes:
      - ./config:/config
      - ./media/books:/data
    ports:
      - 10801:10801
    environment:
      - PUID=1000
      - GUID=1000
      - STUMP_CONFIG_DIR=/config
    restart: unless-stopped

volumes:
  stump-volume:

Additional context
I've tried to use Postman to delete the user with his ID but I can't use the route. This may be a misuse, as I'm not familiar with the language used on the server side. However, I've retrieved the list of users by API with Postman.

Hey 👋 thanks for reporting this!
I think this is just an instance where the UI needs to be tweaked a bit. The menu should be present but might be overflowing and require a horizontal scroll to access it. Can you confirm that the menu exists after attempting to scroll horizontally within the table?

Hi, Thank you for your quick feedback.
Indeed, the button does exist in the table!
After adding the following css classes to the table tag, the menu appears.
display: block; overflow: auto;
Interface with this CSS :

do you think it would be possible to add a little styling to the table to make the scrollbar appear if not all the elements are displayed?
Otherwise thank you again for your feedback, have a good day !

do you think it would be possible to add a little styling to the table to make the scrollbar appear if not all the elements are displayed?

Absolutely! I'll try to put up a quick fix this week to at least remove any intentional hiding of the scrollbar. We were also discussing implementing pinned columns on the Discord server, so certain columns (e.g. actionable things) are always visible and don't require scroll.
I'll close this issue out once the first, quicker fix is in the nightly image. It will be part of the next version (0.0.5) sometime after


Get-Version.ps1 doesn't work in 2.2.13

Get-Version.ps1 fails with:
Exception calling "HelpFindLibGit2NativeBinaries" with "1" argument(s):
"Unable to find native binaries under directory: "[...]\NerdBank.GitVersioning\tools\..\build\MSBuildFull\lib\win32\x64"."

It seems 2.2.13 moved the lib directory (0da2e40006b55b07c7de7a5721e9ea222d393d68), but the script wasn't updated.

Thanks for the report. I haven't been testing the .ps1 scripts lately now that we have the nbgv dotnet CLI tool. Does that work for you?

True. That does make the .ps1 a bit more convenient. However you can use nbgv for that purpose as well:
nbgv get-version -f json | ConvertFrom-Json

And voila! You have a powershell object again. :)

The problem is that nbgv get-version returns the wrong information. For example, it shows the build version as <IP_ADDRESS> while get-version.ps1 correctly shows 3.2.37.

That's interesting. the ps1 script and the nbgv tool use exactly the same VersionOracle class to get the answers. I wonder if it's just a formatting thing.
FWIW, the version property in your version.json file looks misleading: it has a 3rd integer set to zero, but I think NB.GV ignores that. But it might be enough to throw off the nbgv tool and if so, is probably why I didn't catch it, since I'm not testing with inert trailing .0 in my version property. @heaths if you wouldn't mind sharing your repo info with me, I can try it out.

I tried removing the ".0" and get the same result. See the develop branch of https://github.com/heaths/psmsi repo. Happens on an internal repo as well.

I guess the trailing .0 isn't ignored any more anyway. NB.GV used to ignore that, but now it just moves height integer to the 4th position. Sorry I forgot about that.
Anyway, I can repro the .ps1 script failure, and also some inconsistencies in reporting versions by the various build/script/tools. So I'm working on that now.

@heaths I tried commit a4b68111a on your repo (since your develop branch moved on since your report, evidently) and both nbgv and get-version.ps1 (after #258 and #256) report your version as <IP_ADDRESS>, which given your version.json contains "3.2.0" appears to be the corrrect version.

For example, it shows the build version as <IP_ADDRESS> while get-version.ps1 correctly shows 3.2.37.

Why do you say 3.2.37 is the correct value when your version.json calls for "3.2.0" as the first three integers?

Yes, in some cases at least, committing the version.json file is required.


有些方法找不到 Some method is undefined

class: lambdasinaction.chap10.OperationsWithOptional
line 15  and  line 18
The method or(() -> {}) is undefined for the type Optional

class: lambdasinaction.chap10.OptionalMain
line 21
The method flatMap(Function<? super Optional,? extends Stream<? extends R>>) in the type Stream<Optional> is not applicable for the arguments (Optional::stream)

class: lambdasinaction.chap6.Grouping
line 36
The method flatMapping(( dish) -> {}, toSet()) is undefined for the type Grouping
line 41
The method filtering(( dish) -> {}, toList()) is undefined for the type Grouping

class: lambdasinaction.chap6.PartitionPrimeNumbers
line 36
The method takeWhile(( i) -> {}) is undefined for the type Stream

I meet the same problems. The readme.md said this project should be based on JAVA 1.8, but actually the takeWhile is a new function for JAVA 1.9, and also source and target in the pom.xml are also 1.9, so i'm a little confused which java version should i use to run this project?

@manaatmoon I've used Java 11.

pom.xml compile plugin  source and target all 1.9 , but the project of java8.

I meet the same problems ,too

any solution i am also facing same problem when giving 1.8

java11 is ok

java11 is ok


retrybp: Rename MaxN to MaxExponent

Based on the user feedback, the name "MaxN" would confuse user to think
that it works as "max attempts". Rename it to MaxExponent to avoid this
confusion.

cc @andizzle


Include notification to GM if version changes

When a new version is released, support sending the GM a whisper that has important info.

Initial fix in 0.2.2-ALPHA.0


docs: register node api usage

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Infrastructure Deployment

Over the next two weeks starting 11/7/2022, we will be performing a scheduled configuration rollout to upgrade the PMC infrastructure. This two-week phased operation aligns with our commitment to improving PMC reliability and availability and is expected to be completed by 11/17/2022. During this time, we do not anticipate there to be any impact to our customers. We will communicate further updates, as necessary.

7Nov2022 at 1000 PST

For rpm repos, there has been a change in packages paths, from reponame/packagename.rpm to reponame/Packages/p/packagename.rpm.
Since we understand this broke some automation scripts, we've shipped an update so that rpm packages will also be served from their "old" url (without the Packages subfolder`).

We've rolled back these changes. Will reattempt rollout at a later date.


Add putBuffer method for uploading a file as a Buffer

This is similar to #48 but much cleaner.

Can you add a quick test?

Thanks!


@l2succes => Add interfaces to all pieces of Conversation container

cc @alloy
My initial stab at what we discussed, so far.

Fails

:no_entry_sign:

No CHANGELOG added.

:no_entry_sign:

Missing Test Files:

src/lib/Components/Inbox/Conversations/__tests__/MarkReadMessage-tests.ts
src/lib/Components/Inbox/Conversations/__tests__/Messages-tests.tsx
src/lib/Components/Inbox/Conversations/__tests__/SendConversationMessage-tests.ts

If these files are supposed to not exist, please update your PR body to include "Skip New Tests".

  Generated by :no_entry_sign: dangerJS

Woo!
ok, so this is updated with everything working.

Looks like it was danger on Travis that failed. Should we even still be running danger there? cc @orta

Yep, the message is just above you - https://github.com/artsy/emission/pull/755#issuecomment-329857392

Oh, the Travis CI output read to me as if Danger was unable to post and the Danger entry in the CIs list is green, so was overall confused.

Me and @l2succes will get some tests in, that should clear up Danger and get it 💚 mergeable.


Adds target=_blank to Gov Apps

HOW TO TEST

Go to http://localhost:4000/herramientas/otros/

[ ] Validate links open in new window

:+1:


Bumping up the Platform base build 1.3.437.

Bumping up the Platform base build 1.3.437.

Closing and discarding changes in this PR


Add Batch aka .bat files

i don't know where to find them, but you can try like with the .sh

#388 duplicate