Dragging on mobile

When we use the directive version 0.8.4 with leaflet version 0.7.3 or 0.8.x/1.0.x, it won't drag on mobile. Our application has a responsive design, so it must work either on the desktop and on a mobile device. On the desktop it works well, but mobile we cannot drag the map and or double tap to zoom.
Our config (markers are added manually):
$scope.map = {

        // Center
        city: {
            lat: 52.216667,
            lng: 6.883333,
            zoom: 13
        },

        // List of markers
        markers: {},

        // Default settings
        defaults: {
            scrollWheelZoom: true,
	        tileLayer: 'http://{s}.tile.openstreetmap.se/hydda/full/{z}/{x}/{y}.png',
	        tileLayerOptions: {
		        detectRetina: true,
		        reuseTiles: true
	        }
        }

    };

One of our markers:
{
    "id": "van_heekgarage",
    "title": "Van Heekgarage",
    "max": 1650,
    "free": 209,
    "lastUpdate": "1434619535220",
    "lat": 52.21714401245117,
    "lng": 6.898071765899658,
    "icon": {
        "iconUrl": "img/markers/parkinggarage.png",
        "iconSize": [
            32,
            37
        ],
        "iconAnchor": [
            16,
            37
        ],
        "popupAnchor": [
            0,
            -37
        ]
    },
    "message": "
Van Heekgarage
Aantal vrij: 209
Totaal: 1650"
}

Fyi; the markers are visible and clickable on the 0.7.3 version of leaflet. The 0.8.x/1.0.x version of leaflet doesn't work.

I only see 0.7.3 as a valid release. If there are more versions where do you find them? https://github.com/Leaflet/Leaflet/releases

I've also tested with the dev release.
http://leafletjs.com/download.html

Any progress on this issue ??

It's works well for me.
Make sure you've set all the dragging settings true.
dragging: true, touchZoom: true, scrollWheelZoom: true, doubleClickZoom: true
http://leafletjs.com/reference.html#map-dragging
Could you please provide a JSfiddle?

I'm having this issue as well. Not able to pan the map using chrome devtools touch emulation.
  angular.extend($scope, {
        center: {
          autoDiscover: true,
          zoom: 6
        },
        layers: {
          baselayers: {
              base: {
                  name: 'Base',
                  url: 'http://api.tiles.mapbox.com/v4/{mapid}/{z}/{x}/{y}.png?access_token={apikey}',
                  type: 'xyz',
                  layerOptions: {
                      apikey: 'xxxxxxxxxxxxxxxxxxx',
                      mapid: 'xxxxxxxxxxxx',
                      showOnSelector: false,
                  }
              }
          },
          overlays: {
            flightPaths: {
              name: 'Local Flight Area',
              type: 'group',
              visible: true,
              layerParams: {
                // showOnSelector: false, TODO: Add custom box for selectors
              }
            }
          }
      }
    });

This issue was moved to angular-ui/ui-leaflet#66

Hi @nmccready -- Sorry I didn't chime back on this. I managed to figure out what was going on a while ago but I'm forgetting exactly what it ended up being..
I want to say it had to do with touch events propagating up the DOM (but I could be wrong; I had a few issues with mobile touch events during the course of putting together my angular site).

ok @dsifford well if more comes to mind to hesitate to respond on here.

I'm going to rework&redesign angular-leaflet-directive to be compatible with Leaflet v1.0. It will mantain almost all its functionality, and will be compatible with the current features of the directive, but I must start from a fresh point, so I'm going to close this issue. If you think it must be worked with the new version, please reopen it.


compile setup.py

could I compile the setup.py in Win10.

Hi,
I haven't tried it and I do not recommend running codes under Windows OS.

Thank you！

I have implemented training and testing under window, you can go to have a look. Thanks to the author for the source code.
smoke-window


pygosemsim.exception.PGSSInvalidOperation: 'Pre-calculated lower bounds' is required.

similarity.resnik(G, "GO:0004340", "GO:0019158")
Traceback (most recent call last):
File "", line 1, in
File "/Users/Downloads/pygosemsim-master/pygosemsim/similarity.py", line 89, in resnik
mica = lowest_common_ancestor(G, term1, term2)
File "/Users/Downloads/pygosemsim-master/pygosemsim/similarity.py", line 58, in lowest_common_ancestor
G.require("Pre-calculated lower bounds")
File "/Users/Downloads/pygosemsim-master/pygosemsim/graph.py", line 38, in require
"'{}' is required.".format(desc))
pygosemsim.exception.PGSSInvalidOperation: 'Pre-calculated lower bounds' is required.

see the instruction
https://github.com/mojaie/pygosemsim/blob/master/README.md#go-term-semantic-similarity
precalc_lower_bounds is necessary before you call resnik

Please:
graph.precalc_lower_bounds(G)
Traceback (most recent call last):
File "", line 1, in
AttributeError: module 'pygosemsim.graph' has no attribute 'precalc_lower_bounds'

Oh... The instruction is wrong.
try:
similarity.precalc_lower_bounds(G)

Thank you very much for catching it.

Welcome, can I implement similarity() for a (long) list of GO-terms to analyze functional similarity instead of two GO-terms? How?
As below:
similarity.resnik(G, "GO:0004340", "GO:0019158", ...., n)

Similarity can be defined only between two items.
If you want to compare a list of terms with a reference term, use Python built-in iterator.
import functools
resnikfunc = functools.partial(similarity.resnik, G, ref_term)
for s in map(resnikfunc, terms)
    print(s)

Or, pairwise computation can be done by using itertools.combination
import itertools
for a, b in itertools.combination(terms)
    print("{} {} : {}".format(a, b,  resnikfunc(similarity.resnik, a, b))

The second example code was corrected as below
import itertools
for a, b in itertools.combination(terms)
    print("{} {} : {}".format(a, b,  similarity.resnik(a, b)))


Remove or reduce some test sleeps

Make some test code more Pythonic (e.g., generators, list comprehension)
Remove a number of unnecessary sleep calls (or vastly reduce)
Teach some tests to assert
Remove more print()s

Type of change

Code maintenance/cleanup

my main concern is the introduction of randomization in test_fail

The main change is in removing the .sleep() call that was randomizing when calls would fail.  But these tests weren't verifying anything to do with time — like that the app fails as soon as possible.  That might be an additional test, but I'm trying for these set of changes to strictly remove the .sleep() calls where I can.


Make clarin-dspace restart properly on reboot

Hmm, I don't recall when/how this issue occurred, but it's working fine now.


Default inverse scale factor

Hi, love your addon!
Just had a thought about the scale factor. In the wiki it says Quake units are in inches, and set the scale factor to 16 to match Godot units (meters).
1 meter divided by 1 inch (0,0254 meters) is about 40. Should the value maybe be changed to 40?

The "Unit" in quake does not actually correspond to a value

Quake units are only very loosely considered to be in inches- Carmack mentioned that's what they were based on at one point, but in practice the actual scale of entities and architecture in Quake doesn't conform to a real-world metric.
Take Ranger as an example - in Quake he's 56qu high, which translates to 1.4224 meters if you assume inches as the metric. By comparison, standard-size doors are 128 * 128qu, which shakes out to 3.2512 * 3.2512 meters when converted from inches.
So by that measure, Quake is a game about a tiny man running around in massive environments. It doesn't really map to reality.
Thus, the default value is set to 16 so that Quake architecture and entities will covert across 'well enough' to be correct in terms of Godot's physics system, which uses metric as its baseline.
You can of course change it on a project-by-project basis if you decide to map at a bigger or smaller scale than in Quake.


Writing output in parallel is broken

When running the simulation via
mpiexec -np 8 python main.py -parallel

the script terminates with a SIGTERM error.
I did some digging, and it originates from the _write_initial_output method.
https://github.com/PI-UniA/SurroGlas/blob/d4fa6f1605fdcb25045ed818770e3980011b3ee7/ThermoViscoProblem.py#L474
It seems that writing output in parallel is not possible, which we should fix.
Seems to me like a bug, @tarekhussein maybe we can do some research on the FEniCS discourse how to fix that.

Investigated a little further, seems like there's an issue with the VTKFile, XDMF works fine. I'll open a PR when it's fixed.


Alternative solution

However, f is needlessly run asynchronously, on a future tick.

Maybe Promises should not needlessly run asynchronously in such cases.
The alternative solution would be to fix the Promise spec. I heard other people in NodeJs community were also discussing this at some point

There are no discussions or viable changes that would alter this proposal or that sentence.
What you’re thinking of is reducing ticks in a different specific case.


Lv4 Self checkout

Having problems thinking of a solution to Lv4. How do we keep track of which customers go to which self-checkout counter when he/she has to wait? Was thinking of having an array to store the mostAvailableTiming for each self-checkout counter then, create a wait event, attaching the customer to the self-CheckOut counter with the earliest mostAvailableTImings

Personally, I created a new class called SelfCheckoutList that only creates one instance in the Simulator code. The new class is basically just the waitlist for servers but shared among all the self-checkout and each time a customer waits for a self-checkout this new Class changes and adds a new person to the waitlist. However, I think how u create your SelfCheck out depends on your initial implementation. Also, I think you can create a static waitList that is shared among all SelfCheckouts.

I stored the Customers queuing for self-checkout in a common queue (ArrayList) managed by a “Shop”, which also manages all the Servers.
If customers have to wait, then the Done Event needs to trigger the next Serves event somehow (although if Done directly creates Serves this leads to a cyclic dependency). So I used Simulator to identify Done Events and manually create the next ServesByEvent, using the same self-checkout counter which is now available and popping the next Customer in the common self-checkout queue (ArrayList).

I created an interface (abstract class should also work) called Server, then 2 classes, HumanServer and SelfCounter. SelfCounter is almost the same but the waiting queue is static.
private static final Queue<Customer> waiting = new LinkedList<>();
Then, the constructor will not make a new waiting queue and every SelfCounter will update this same static queue.

My approach was slightly different- I basically have the same event flow for all customers regardless of whether they are being served by a human server or a self-checkout machine. For me, every self-checkout (SCO) machine had its own queue(just for ease of implementation and uniformity) but if a server had to wait, I would always queue them in the queue of the first SCO machine and thus always have the same log output for anyone waiting for a SCO. Then when it finally came to serving the customer, I allocated the best SCO to them at that moment. Essentially you delay allocating a SCO until as long as possible.

Currently having some problems, using the static waiting list approach.
Simulation:
Human example: (curr implementation)
A in queue, B joins queue. B will have to wait A's service time, gen Wait event. adding A's service time
SCO:
A in queue, B join queue. However, A may proceed to SCO 3 while B go SCO4. Any suggestions for this?

A and B can be in the same queue, but the allocation to SCO need not occur upon arrival. It should simply create a Wait Event and allocate to the first SCO. Then, when a Done Event is polled from the PriorityQueue, check the common SCO queue, pop the next Customer from the queue, and add a Serves Event.
However, there may be some cases where you want the Customers to proceed to the SCO directly, in which case they should be allocated to the SCO upon arrival. What I did here was run an .allocateServer() function in the Arrival Event and then run a .allocateSelfCheckout (only searches through self-checkouts) again later on if the Customers are queuing for a self-checkout counter.

My server has an internal queue to handle customer queues. So for self-checkout, I made a new constructor in my server to take in a queue instead of creating one in the constructor. Then for self-checkout, I just extended server and pass in a queue that is defined outside. So every instance of self-checkout will only reference 1 queue.

Currently having some problems, using the static waiting list approach. Simulation: Human example: (curr implementation) A in queue, B joins queue. B will have to wait A's service time, gen Wait event. adding A's service time
SCO: A in queue, B join queue. However, A may proceed to SCO 3 while B go SCO4. Any suggestions for this?

Yes, the way to calculate wait time is still the same but when A is done serving and its B's chance to now be served, create an implementation to allocate to it the best SCO in that situation:) and then proceed normally

Thanks for all your help people hope this thread also helps others with this level!!


Increase dns timeout and no. of tries

Note: This is for giving more opportunities to envoy to succeed doing DNS resolutions for STRICT DNS clusters before calling itself ready.
Goal: Increase dns timeout from 5 seconds, to 10 seconds, and increase tries from the default 3 (excluding the first attempt) to 10.

Adding @zuercher
I do not think this should have an impact on Envoy start times.
I think these options should be configurable though. I can see someone wanting to bump them even further in the future if their DNS is slow.
/wait-any

Agree that it should be configurable, with the current value as the default.

/wait


fs-1760-localise-email-sent-page

Superseded by https://github.com/communitiesuk/funding-service-design-authenticator/pull/98


Create “info-unit-groups-link-blobs”

Automatically generated by Netlify CMS

Merging this to get around some API errors. Additional PR to finish work on this ASAP.


Motivate and explain regular expression rules.

@nikore what do you think, is this good enough?
@containous/traefik PTAL.

Looks great; thanks!

LGTM 👍

@dtomcej okay to merge?


2.3.1

2.3.1 Converting to upper (2 points)
A. Convert the EMPLOYER_NAME and Name fields to uppercase using list comprehension rather than df.varname.str.upper() (it's fine to do a separate list comprehension line for each of the two columns)
B. Print a random sample of 15 values of each result

Random sample - Employer

Random sample - debar

C. Assign the full vector of uppercase names back to the original data, writing over the original EMPLOYER_NAME and Name columns

Just to double check, are we using the name from debar or debar_clean?

Just to double check, are we using the name from debar or debar_clean?

debar_clean for all questions post 1.4 - thanks for checking!


File Imports Appear Broken in Server 2016

Version:
Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      14393  2339

Error:
Error: The term 'function' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was includ
ed, verify that the path is correct and try again.
Summary:
Last night, an update was implemented on our system via active directory. Today, I am unable to run file imports that work on other versions (5.1.16299.431 is working fine on my local machine, Windows 10). I'm not 100% sure that this is a bug, but I can't reproduce on other versions and there doesn't appear to be any link I could find to get an upgrade on the OS I'm using. The latest update was KB4284833 run overnight.

Does this look like an end user issue?
Is there a way to upgrade Windows Server 2016 PS to 5.1.16299.431 (working)?

Test Code:
ZipFiles.ps1
Param ($type)

$ScriptDirectory = Split-Path -Path $MyInvocation.MyCommand.Definition -Parent
$date = get-date -UFormat %Y%m%d
$Logfile = "$ScriptDirectory\FileManagement-$date.log"
try {
    . ("C:\Program Files (x86)\oneZero\Scripts\SendMail.ps1")
    . ("C:\Program Files (x86)\oneZero\Scripts\LogWrite.ps1")
}
catch {
    Write-Host "Error while loading supporting PowerShell Scripts"
    Write-Host "Error: $($_.Exception.Message)"
    exit 1
}

SendMail.ps1
function sendHTMLMail {

    Param (
        [string]$Body = '',
        [string]$Subject = ''
    )

    $SMTPServer = "smtp.sendgrid.net"
    $SMTPClient = New-Object Net.Mail.SmtpClient($SmtpServer, 587)
    $SMTPClient.EnableSsl = $false
    $SMTPClient.Credentials = New-Object System.Net.NetworkCredential("user", "password");
    $EmailFrom = "email"
    $EmailTo = "email"
	$message = New-Object System.Net.Mail.MailMessage $EmailFrom, $EmailTo
	$message.Subject = $Subject
	$message.IsBodyHtml = $true
	$message.Body = $Body
    $SMTPClient.Send($message)
}

LogWrite.ps1
function LogWrite
{
   Param (
    [string]$logstring,
    [string]$logfile)

   $date = Get-Date
   $log = "$date - $logstring"

   if (!(Test-Path $Logfile))
   {
	 New-Item -path $Logfile -type file
     Add-content $Logfile -value $log
   }
   else
   {
   Add-content $Logfile -value $log
   }
}

Question to you @talaniz?
Is this a Windows PowerShell issue? Or, a PowerShell Core issue?
Keep in mind, Github is only PowerShell Core only.  Any Windows PowerShell issue should be address thru the UserVoice forum: https://windowsserver.uservoice.com/forums/301869-powershell
This is as stated in the PowerShell Core landing page: https://github.com/PowerShell/PowerShell#windows-powershell-vs-powershell-core
Now, I would recommend to test the issue on a later Windows 10 build (< 16299) or Insider edition as we've seen issues been corrected on later builds.
:)

Thank you for clarifying. I have updated on the UserVoice forum. Closing out.


📝 docs: Update README.md

:tada: This PR is included in version 3.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[RFR] Find winner of the game

Create a function to find the winner of the game.
The function goes through each case of the board game and check in every position possible if it's there is 5 marbles aligned.
The function return the marble of the winning player, if there is no player it returns None.

Ready for review


refactor(webpack): switch to core-js from @babel/polyfill

We do not need regenerator-runtime as generators are supported in all node versions untool supports.


Error during login: error decoding login resp

Hello everyone!
I got an error while receiving QR:
error during login: error decoding login resp: json: cannot unmarshal array into Go value of type map[string]interface {}
I've worked with 0.4.1307 before.
wac.SetClientVersion(0, 4, 1307)
Does anyone have a similar problem?

New version solved:
wac.SetClientVersion(2, 2123, 7)

New version solved:
wac.SetClientVersion(2, 2123, 7)

In which file can I find this code?

Session.go
On Wed, Jun 23, 2021, 8:22 AM excaliburapp @.***> wrote:

New version solved:
wac.SetClientVersion(2, 2123, 7)
In which file can I find this code?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Rhymen/go-whatsapp/issues/578#issuecomment-866531348,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDLT274UCOR4XMT75LZFCTTUFVRRANCNFSM47BEO3JQ
.


Removed the legendary blinking gold lights :(

Just did, I think it's fixed now?

Just did, I think it's fixed now?

yep, thanks!


add cpu_ubuntu16.04 dockerfile

I added a Dockerfile building the non-gpu environment from source.
It seems to be required dockerfile to build from source because various changes is anticipated.  Some people wants to use latest environments.

Thanks for your PR. It must be convenient for some people. We think we'd better wait for some opinions from other people about whether it deserves to be contained in the official repository. Thanks again for your suggestive PR.

Thanks.
Honestly I was wondering if the place of dockerfile is right or not.
Would you mind making "easy to use NNabla" Dockerfile Directory?
I'm now coding Dockerfile containing nnabla_ext_cuda and Jupyter.
It seems useful many people but I don't know which directory should i palce it.


Data Size！

Hi：
Thank you very much for the source code. Due to memory limitations, I cannot allow large-size data. Therefore, I would like to ask how to adjust the parameters if I want to run data with a size of (96, 112, 96). Or the smallest image I can run and how to adjust the parameters. Thank you so much!

Hi @SLKaMiHi
The shape of the input should be divisible by 32. Therefore, 112 would not be a valid size. Additionally, 96/32=3, which is smaller than what we used for patch size (i.e., 4). I would recommend you to try TransMorph-small:
https://github.com/junyuchen245/TransMorph_Transformer_for_Medical_Image_Registration/blob/246795ebf3086238b7605f495e181d704ba04c48/TransMorph/models/configs_TransMorph.py#L235
https://github.com/junyuchen245/TransMorph_Transformer_for_Medical_Image_Registration/blob/246795ebf3086238b7605f495e181d704ba04c48/TransMorph/models/TransMorph.py#L959
https://github.com/junyuchen245/TransMorph_Transformer_for_Medical_Image_Registration/blob/246795ebf3086238b7605f495e181d704ba04c48/TransMorph/train_TransMorph.py#L47
Also, you will need to zero-pad 112 so that it becomes 128. You will also need to change the patch size to be 2 or 3 (i.e., line 242):
https://github.com/junyuchen245/TransMorph_Transformer_for_Medical_Image_Registration/blob/246795ebf3086238b7605f495e181d704ba04c48/TransMorph/models/configs_TransMorph.py#L235-L242
Thanks,
Junyu

Hi @junyuchen245
what is your model's input data size ?
Thank you very much!


fix(gitpod): update playwright, add mailhog and other ports

This PR updates the playwright package so it is in sync with the image, additionally it should suppress a couple port notifications.

OK - I also brought the Dockerfile to this repo so its easier to "track".


Port to typescript

This ports this project to typescript
The code will look like 99% javascript except in small places. But, "under the hood", it is checking things. It would have caught e.g. the thing where the wrong parameters are passed to BgzipIndexedFasta cosntructor, and your editor can be configured to give much better "intellisense" things with typescript
You don't necessarily have to accept this PR, just an idea

See also package.json, it's a good idea to list all dependencies in the package.json. Not sure how you had it setup before, but with the proper dependencies in package.json, we can run "yarn" and it'll automatically download them


Check why "theme" is being extracted from screenView on some screens

Allows for specify a specific theme, so it fits in when in an iFrame


Support for python3 ideas?

Is there a chance to consider python3?

Sure, I will consider support python3.


Add missing calls to super to fix static analysis warnings

:+1: I'll get this merged in on Monday!

Thanks for the contribution, @ZevEisenberg!


Add more Travis CI caching

This turns on the Travis caching feature for the bundled gems and node packages that should shave off 30 seconds from the travis build time by not bundling every time! Woohoo!

@airhorns Looks great! :tada: It looks like Travis is failing, so I will assume it's still a WIP. Let me know when it's ready for review (or if you have any questions about the current build system).

Ok, I think this is finally ready to go if it is ✅ . I kept getting codecov fails with a message like this:
@@             Coverage Diff              @@
##           staging     #828       +/-   ##
============================================
- Coverage      100%   54.65%   -45.35%
============================================
  Files          192     2790     +2598
  Lines         3009   115689   +112680
============================================
+ Hits          3009    63229    +60220
- Misses           0    52460    +52460

which indicate that somehow my changes left 45% more code un-covered. Turns out it was detecting the ruby code for the bundled gems in vendor/bundle and .vendor/bundle and since no tests from gems are run all that code is listed as uncovered. So, I just moved the bundle out of the repo so the coverage tools won't find it. The reason it is anywhere other than where bundler normally stores gems is so that travis can cache it. 🎉


Modify kerberos

hog: https://github.com/aicers/hog/pull/544
Issue: https://github.com/petabi/review-database/issues/140

Migration support is needed for changing BlockListKerberos event. Examples could be found in src/migration.rs


Trigger modal close inside iframe

Hopefully can get this to work.
I use iziModal to display a survey that is on a different server. When the survey is complete it comes back to original server and displays a thank you message, but still within the iframe.
In this thank you message I'd like to be able to present a button for the user to click to close the modal.
I've added data-izimodal-close to a button (shown in the thank you message), but it is not getting picked up by izimodal.

Actually I just found an alternative way. I've saved a reference to the iziModal attached to window. Then in my thank you page, I can access it through the special "parent" object.


Avoid using the connection pool and instead, create the connection just-in-time, when it is required

First of all thank you very much for this library which is really helpful, I am using it and it works perfectly.
Although I integrated it within some specific routes of my api located under a Google Cloud Function, and it create many extras connection to the database even though the specific routes are not called.
How could we create create the database connection just-in-time (only when routes configured with idempotency service get called) ?
Thanks in advance for your recommandations.

Hi @rodneyrd  ,
Thank you for your kind words.
I think the functionality that will suit you best is the use of the adapter delegate function. But I need to adjust the behavior so the adapter calls the delegate function everytime it requires database connectivity instead of keeping the reference. I should also introduce some callback function which will allow you to close the connection when the adapter is done using it.
I will let you know when I adjust the code and a release candidate is available so you can do some testing on your side.

Hi @joscelynjean,
As soon as you are ready I'll be do the testing.
Feel free to let me know when I can try it out.

Hi @rodneyrd ,
Got some problems with CircleCI but now is all goods. You can test v1.0.4-rc.2, which is a release candidate.
Basically, when you will initialize the adapter, is will be important to use the 3 following options :
...
useDelegation: true,
delegate: your function which provide a Mongo.Db reference (ex: MongoClient.connect().Db()),
onAfterDbUse: provide a function to close your connection (ex: MongoClient.close() ),
...

I have not tested it well for now, I wanted to unblock yourself but I will provide unit tests and a Docker example of what you are trying to achieve.
Just let me know how it is going!
Thank you

Hi @joscelynjean thank you very much for this. Sorry for the delay, it took me quite some time to investigate and find a solution as it didn't really solve my issue since it is more a context related issue.
The adapter was still calling the DB connection at every cloud runtime execution because I instanciated the mongo adapter (newAdapter(...)) at runtime, which kept calling the adapter db connection even if I didn't wanted to.
Cloud function invocation get reused by subsequent invocation, so I definitely want to keep the database connection pool until my cloud function is getting offline. As some of my components are shared within multiple cloud functions (My mongodb service for example) it triggered the adapter connection in every cloud function even if they don't need it.
So, I figured out a solution by playing around with your adapter. In case it could useful for someone else, here is what I did :
I created a specific middleware that setup the mongo adapter configuration (which use my own db connection delegator) and call the idempotency middleware itself. This custom middleware can then be reused in any endpoint that needs it without triggering the newAdapter() default db connection.  Instead of using the newAdapter() I instanciated a new MongoAdapter(...) directly, then this middleware becomes in charge to call the .init()method, so that the connection to the DB is made only when it needs it.
import { idempotency } from 'express-idempotency';
import { MongoAdapter } from 'express-idempotency-mongo-adapter';
import { getDb } from '../libs/services/mongodb/mongodb.service';

let dataAdapter: MongoAdapter;

export const idempotencyDefaultAdapter = async (req, res, next) => {
  if (!dataAdapter) {
    dataAdapter = new MongoAdapter({
      useDelegation: true,
      delegate: () => getDb(),
      collectionPrefix: 'idempotency',
      ttl: 86400,
    })
  }
  if (!dataAdapter.isInitialized()) {
    await dataAdapter.init();
  }
  await idempotency({ dataAdapter })(req, res, next);
};

Feel free to let me know if you have a better recommandation. In any case, thank you very much again for your help !


TODO: look into hosting hub on https://www.hetzner.com/cloud

Needs a $20 (20-Euro, actually) deposit on Paypal...


remove redundant test.sh file

🛑 Important:
Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!
For guidelines on how to contribute, please review the CONTRIBUTING.md document.
Purpose of this PR
Provide a clear and concise description of the changes. Explain the motivation behind these changes and link to relevant issues or discussions.
Proposed changes:

Fix go lint error to pass code check CI
Remove redundant test.sh file

Change Category
Indicate the type of change by marking the applicable boxes:

[x] Bugfix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that could affect existing functionality)
[ ] Documentation update

Rationale

Checklist
Before submitting your PR, please review the following:

[x] I have conducted a self-review of my own code.
[ ] I have updated documentation accordingly.
[ ] I have added tests that prove my changes are effective or that my feature works.
[x] Existing unit tests pass locally with my changes.

Additional Notes

/assign @ImpSy

/approve


Pass joint_limits to move_group node

Fix https://github.com/PickNikRobotics/abb_ros2/issues/46

Note: The use_acceleration_limits for each joint in abb_irb1200 is presently set to false. It would be ideal if these were true but I've left this change out of this PR as I'm not sure what the acceleration values should be for the joints of this robot.

Thanks for this fix!


DDG doesnt block yandex ad anymore

Describe the bug
Going to my usual sites I started to see ads from https://yandex.ru/an/count/ (etc... Very long URL)
It's never happened before because these ads have been blocked before.
Because I could see it from my computer, but not my phone.
How to Reproduce
1
Expected behavior
2
Environment
- DDG App Version: 51.77.1
- Device: Pixel 6a
- OS:Android 13

Thanks @Minalinsky007.
We are aware of the issue and will be working on a fix.

This should be fixed now. Thanks!


Add a protocol-ftp feature which enables FTP support when using bundled libcurl (#322)

Closes #322

Awesome, thanks!

@alexcrichton Would it be possible to get a release with this change?

Sure thing, done now!

Thanks


Convert all types of parameters in docstrings to proper type annotations

Overview: What does this pull request change?
I have gone through all of the types of parameters in docstrings and:

If there was no type annotation for that parameter I annotated with the type from the docstring (and added the necessary imports)
If there was (so the docstring type is redundant) I checked they were the same and deleted the docstring type
If the docstring mentioned a param which does not exist I fixed it
Reformatted function signatures that became longer than 88 chars after my changes
Fixed some more docstring issues I found
There are now zero types in the "parameters" section of docstrings across the library

Motivation and Explanation: Why and how do your changes improve the library?
Advances progress in #2121 by a lot 🎉
There are still return types and attribute types in docstrings, maybe I'll do them next.
Links to added or changed documentation pages

Further Information and Comments
I wrote a script to help me automate a lot of the process, and manually did what I couldn't automate.

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

The first commit was created by running this script I wrote, so if you prefer you can review the script instead of the diff it created.
For the 2nd commit I ran isort and for the 3rd commit I ran black, but the 4th commit was done manually so it also requires reviewing.

@behackl I'm sorry I wasn't responsive this month so far, I've been busy with school work unfortunately (semester started recently).
Thank you for your efforts to merge the PRs!!
Hopefully I'll find time to work on more stuff here, like converting attribute types from docstrings.


Finalising sprint 2 changes (Bench/Collisions) and Improving map design & adding different layouts

Description
In this sprint, we are going to start by working on fixing the bench collisions as well as refactoring the bench class (creating Bench Generator) to make the spawning of the bench tiles easier. We are also working on changing the background of the game area based on the time of day. This means it will go from day to night by having the background progressively change.  In addition, we are also working on creating multiple maps for the different levels. During the sprint we will also try to work on improving the UI of the game (including stats and other components), as well as improve the layout of map. In the first half of the sprint we will be focusing on polishing our changes from the previous sprint (Bench/collisions).
SubFeature/component (optional)
#359 - Improving Map design
#309 - Adding different Map layouts
Dependencies
No dependencies
Milestones
List of sub-features you intend to have done and in Master by the end of the sprint. The dates might vary based on how much work can be done during the mid-sem break.

[ ] Improve bench code layout and finalise collisions (21st Sept)
[ ] Multiple map layouts (Oct 1)
[ ] Integrate into different levels(Oct 2)
[ ] Change game background (29 Sept)
[ ] Final UI changes to the game and improve map design (30 Sept)

Completion Deadline: 2nd October
Documentation
Map Design
Map Layouts
Game Screen Background
Members

Danh Dinh (@danhdinh98)
Sarah Abdulkhalek (@Sarahkhalek)
Alex Macnamara (@amacn13)
Alex Ong (@ATOApplett)
Reza Panday (@pineapple11111)
Rakshit Singh (@Rakshit31773 )

Closed by #447


fix(Col): 支持Col的响应式

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements

[ ] Follow our contributing docs
[ ] Docs have been added/updated
[ ] Tests have been added; existing tests pass

Other information:

lgtm


⚠ Bofrost.de has degraded performance

In ccc3026, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1287 ms

Resolved: Bofrost.de performance has improved in dc70a31.


Unknown error throwed when file size matches exact 410241024 bytes

Strangely, when I use java HttpComponent to issue a POST request to location / to save an object, and when the stream size is exact4*1024*1024bytes, the error occurred:
[2017-04-08 04:59:06,660] DEBUG [id: 0xbc704c90, L:/0:0:0:0:0:0:0:0:1174] RECEIVED: [id: 0xc21bf33a, L:/<IP_ADDRESS>:1174 - R:/<IP_ADDRESS>:35694] (io.netty.handler.logging.LoggingHandler)
[2017-04-08 04:59:07,046] ERROR Internal error handling request / with method POST. (com.github.ambry.rest.NettyResponseChannel)
com.github.ambry.rest.RestServiceException: com.github.ambry.router.RouterException: Operation failed, but exception was not set
	at com.github.ambry.frontend.AmbryBlobStorageService.submitResponse(AmbryBlobStorageService.java:253)
	at com.github.ambry.frontend.AmbryBlobStorageService$PostCallback.onCompletion(AmbryBlobStorageService.java:767)
	at com.github.ambry.frontend.AmbryBlobStorageService$PostCallback.onCompletion(AmbryBlobStorageService.java:687)
	at com.github.ambry.router.NonBlockingRouter.completeOperation(NonBlockingRouter.java:388)
	at com.github.ambry.router.PutManager.onComplete(PutManager.java:255)
	at com.github.ambry.router.PutManager.poll(PutManager.java:173)
	at com.github.ambry.router.NonBlockingRouter$OperationController.pollForRequests(NonBlockingRouter.java:516)
	at com.github.ambry.router.NonBlockingRouter$OperationController.run(NonBlockingRouter.java:570)
	at java.lang.Thread.run(Thread.java:745)
Caused by: com.github.ambry.router.RouterException: Operation failed, but exception was not set
	at com.github.ambry.router.PutManager.onComplete(PutManager.java:242)
	... 4 more

And I tried to CURL -XPOST the very same file to the / endpoint, it succeeded.
I debugged, and notice that in ambry/ambry-api/src/main/java/com.github.ambry/config/RouterConfig.java
there is a config line:
routerMaxPutChunkSizeBytes = verifiableProperties.getInt("router.max.put.chunk.size.bytes", 4 * 1024 * 1024);
I tried to change it, and any file size matches this size of setting, the UNKNOWN ERROR appears.
However, older versions other than the current master build have no such issue.

Hello @michael2008, thanks for raising an issue. Do you have example code using HttpComponent that we can use to reproduce the problem? Since you say curl works, it might be a specific interaction that causes the problem.
Also when you say "older versions", is it possible to tell us a commit at which there is no problem?

Hi @vgkholla , thank you for your reply.
I managed to extract a sample from our codebase, and reproduced the strange error.
I have not tested all recent commits the locate the exact commit which caused the unknown exception. But I do reproduced the problem on this commit:
https://github.com/linkedin/ambry/commit/54de79c13369356759e308e28e48b2f910184bc0
As far as I know the version we used last year around December is free of this problem (now we fallback to that version and everything is ok). I am not sure which exact commit caused it. Since the curl post is ok, I also suspect HttpComponent is the problem. However, older version of ambry is ok, so there might be some changes of the Ambry that caused some compatibility issues.
Test sample is here:  https://github.com/michael2008/AmbryDebug
Hope this sample would be useful.

@michael2008 thanks for the code snippet - it was helpful in debugging the problem. I have found the interaction that is causing the bug - will work with @pnarayanan to figure out the right solution. We should have a fix out soon since the (probable) cause is a race condition that curl is not hitting but the http client you are using is.
In the meantime, could you try upgrading to this commit? This commit should experience the problem but the commit just before that should be free of the problem.

@vgkholla  you are welcome, glad you found the cause of this extremely strange issue, looking forward to your fix

@michael2008 thank you for raising this. #600 should fix this issue. Since this is reproducible for you, we would appreciate if you could verify this at your end when you get a chance. Thanks.


Fix LibreSSL- and -version detection

Was almost correct...
LibreSSL uses X.Y.Z numbering only whereas OpenSSL uses X.Y.Za numbering (apart from first release of X.Y.Z).
This patch fixes detection of LibreSSL and the version yet keeps OpenSSL detection as intended.
OpenSSL 0.9.8zf
OpenSSL 1.0.1m
OpenSSL 1.0.2
LibreSSL 2.0.5
LibreSSL 2.1.6
OpenSSL version: major=2, minor=1, fix=6
Warning: LibreSSL found, support for LibreSSL is experimental!All modules will be installed.
OpenSSL version: major=1, minor=0, fix=1, patch=l
All modules will be installed.
OpenSSL version: major=1, minor=0, fix=2, patch=a
All modules will be installed.
(OpenSSL 1.0.2 was skipped on FreeBSD, port was upgraded from 1.0.1m to 1.0.2a)

Without a fix like this, build of openxpki-0.28.0 breaks if encounters today's libressl-2.1.6.

I will publish a new release hopefully end of this week which will contain this merge. Can you confirm that this fix on top of current develop works?

@Sp1l  can you please make pull requests against develop next time, that will speed up integration.

Hi Oliver. For me it looks like the latest today's commit to develop (edcec2e4c005773f5c83bce77fca17fde0c813d5) is empty. It says:
"Showing 0 changed files with 0 additions and 0 deletions."
At least it does not modify the file in question ..../Makefile.PL. What I am doing wrong?

Meanwhile, yes I can confirm. Develop brunch (edcec2e) builds ok with libressl-2.1.6. Moreover, tests say PASS, although with lots of warnings.

And you may want to terminate a message with "\n" in line 118 of ..../Makefile.PL

Thanks @oliwel! Will try and remember if I create a next patch for OpenXPKI to patch the develop branch instead. (If you had told me earlier I'd have rerolled the patch for that branch :D)


Zabbix update

Full rewrite of the Zabbix output plugin, using the ZabbixProtocol Ruby gem instead of the zabbix_sender binary via the shellwords gem.

big :+1: for the first docker-enabled tests I see, will try to get inspiration from it. Thx

@untergeek As you are heavily reviewing zabbix, could you have a quick look to the usecase of https://github.com/elastic/logstash-contrib/pull/118 please

Thanks for the doc fixes and the ref to the PR to put the timestamp in.  I'm sure I can do this, if the ZabbixProtocol Rubygem supports it.

LGTM

LGTM


Support BINARY type name for SQLite

I believe this fixes #1355.
My understanding is that this issue is a matter of taking columns labeled BINARY and fitting them under Diesel's Binary type. I've just been getting into the source code for diesel and I'm slowly gaining more context for how determine_column_type fits into everything, so feel to correct and provide more context if I have the wrong idea!
Let me know if this is something we should add to the changelog. I'm happy to do that with some guidance.

@weiznich I think I might be confused: don't we already have something like it in the same file, a few lines down?

Can you a CHANGELOG entry?

I didn't see any other recent additions to the changelog, so I added an "Unreleased" section. Please do let me know if you had something more specific in mind!


Use HIDE_SYMBOLS_BY_DEFAULT

🎉 New feature
Part of testing gazebosim/gz-cmake#392.
Summary

Test it

Checklist

[X] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

dartsim/src/Base_TEST.cc has linking errors on Ubuntu
[ 62%] Linking CXX executable ../bin/UNIT_Base_TEST
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: warning: relocation against `_ZTVN2gz7physics7dartsim11SDFFeaturesE' in read-only section `.text._ZN2gz7physics7dartsim11SDFFeaturesC1Ev[_ZN2gz7physics7dartsim11SDFFeaturesC1Ev]'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `BaseClass_SdfConstructionBookkeeping_Test::TestBody()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:165: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::ConstructEmptyWorld(gz::physics::Identity const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:174: undefined reference to `gz::physics::dartsim::SDFFeatures::ConstructSdfModel(gz::physics::Identity const&, sdf::v15::Model const&)'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:181: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::GetLinkCount(gz::physics::Identity const&) const'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:182: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::GetJointCount(gz::physics::Identity const&) const'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:186: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::GetLink(gz::physics::Identity const&, unsigned long) const'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:186: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::GetShapeCount(gz::physics::Identity const&) const'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:192: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::GetJoint(gz::physics::Identity const&, unsigned long) const'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `gz::physics::detail::ExtractAPI<gz::physics::detail::ImplementationSelector, gz::physics::FeatureList<gz::physics::Feature> >::Impl<std::integer_sequence<unsigned long, 0ul> >::type<gz::physics::FeaturePolicy<double, 3ul> >::type()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `gz::physics::dartsim::Base::Base()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base.hh:261: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base.hh:261: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `gz::physics::GetEngineInfo::Implementation<gz::physics::FeaturePolicy<double, 3ul> >::Implementation()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/GetEntities.hh:46: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o:/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/GetEntities.hh:46: more undefined references to `VTT for gz::physics::dartsim::SDFFeatures' follow
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `gz::physics::dartsim::SDFFeatures::SDFFeatures()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/SDFFeatures.hh:53: undefined reference to `vtable for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `gz::physics::detail::ExtractAPI<gz::physics::detail::ImplementationSelector, gz::physics::dartsim::SDFFeatureList>::Impl<std::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul> >::type<gz::physics::FeaturePolicy<double, 3ul> >::~type()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o:/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: more undefined references to `VTT for gz::physics::dartsim::SDFFeatures' follow
/usr/bin/ld: warning: creating DT_TEXTREL in a PIE
collect2: error: ld returned 1 exit status

dartsim/src/Base_TEST.cc has linking errors on Ubuntu

here we go cf35e03

dartsim/src/Base_TEST.cc has linking errors on Ubuntu

here we go cf35e03

thanks!

it's working now thanks to @j-rivero!


Code samples in documentation

x-code-samples

:yum:

Implemented
Docs are here
Example of usage is here
Live demo is here

:+1:


Manage release of different collectors (generic, aws, azure, gcp)

To handle different collector releases from the same repository:

We need to have different "tag" streams for different collectors, e. g. generic/1.0.0, aws/1.0.0, azure/1.0.0, gcp/1.0.0;
Release on the repository should be specific for collector type as well, e. g. "Generic ODD Collector 1.0.0", "AWS ODD Collector 1.0.0", "Azure ODD Collector 1.0.0", "GCP ODD Collector 1.0.0";
GitActions should include in the logic the release pattern and tag pattern.

PR: https://github.com/opendatadiscovery/odd-collectors/pull/83

PR #83 does not contain all the needed changes. Main PR: #86 , with the last working fixes.


build erros

Good afternoon!
Encountered this problem when building your template =(
build_error.pdf
I realized that TS doesn't understand the type of request graphql
my dependencies are exactly the same as in your repository
Can you tell me how I can fix this?
because these errors prevent me from deploying my tutorial application.
thank you for your help and future replies ))

@SergGrey1992 notice all the UNAUTHORIZED messages in the GraphQL queries? That likely means your environment variables are missing or incorrect.


fix issue that the match of HierarchyMatch do not work

Coverage increased (+0.04%) to 17.966% when pulling 2bb4c63b2ed47373dd3deeeb7d24473d00a480fa on ascrutae:zhangxin/fix/hierarchy-match-failed into 972d4396eb13ceb09fcfdf8b6bd32564575d9c71 on wu-sheng:master.

Coverage increased (+0.04%) to 17.964% when pulling 164960f668364595fec02957a8a5072affbec7a2 on ascrutae:zhangxin/fix/hierarchy-match-failed into 972d4396eb13ceb09fcfdf8b6bd32564575d9c71 on wu-sheng:master.

Coverage increased (+0.04%) to 17.964% when pulling 164960f668364595fec02957a8a5072affbec7a2 on ascrutae:zhangxin/fix/hierarchy-match-failed into 972d4396eb13ceb09fcfdf8b6bd32564575d9c71 on wu-sheng:master.


It looks like you already took a fair amount of my changes and integrated them earlier up the chain, so this shouldn't have a huge amount of impact - I tried to make my changes while doing the least amount of "harm" possible.

I changed the base branch for this PR from Main to Dev, as the branch was based off of development originally.
Does this PR replace #984?
Also...there's a customer name in the commit history. Please remove that customer reference.


TLS Support

Pushed Upstream
https://github.com/luvit/luvit/pull/148

closing in favor of the upstream pull request


Questions regarding the DirectoryStore design and expected functionality.

Hi there,
I'm trying to understand the reasoning, choices and trade-off made when the DirectoryStore on disk layout was created.
As far as I can tell it has been done to be:

relatively simple
cose to the default zarr protocol.
internal meant to be inspected by humans, subgroup in hierarchy accessed independently without opening the root via the zarr lib.

Are these assumption of mine correct ? To what extent could they be changed – for the internal implementation of DirectoryStore for v3 spec assuming the end user API does not change ?
For multiple language implementation of the DirectoryStore v3, I'm supposing we also care about a few other things mainly:

On disk layout should be relatively friendly to machines and many languages.
robust to Key Cases (as the zarr protocol may allow unicode and enforce store to maybe be case sensitive?)
Efficient when possible

There are few other questions that I have not seen mentioned in discussions/spec of the DirectoryStore, mainly whether soft/hard links are allowed, how permission is handled and wether writing over a chunk keep the inodes and seek write or should replace the files.
I believe some of the current constraint on casing and efficiency of current DirectoryStore can be overcome with minimal loss of readability for human exploring the internal of such a datastore.
for Example, we could change the encoding of keys as follow.

in the Zarr Protocol allow arbitrary unicode for keys, or at least relax casing.
For the DS, encode the key as follow.

A key in the DS would HUMAN_PART-MACHINE_PART

the HUMAN_PART would be ascii-restricted, non empty version of the key, mostly informative for the user exploring the filesystem.
MACHINE_PART would be base32 encoded version of the key stripped of trailing =. This would ensure ability to store complex unicode keys without having any issues with casing, or reserved names (like COM on windows, names starting with dashes, dots.. etc.
The "MACHINE_PART" can also ends with d, or g depending on whether a key is a group or a dataset which should limit the number of stats/read when listing a store with large number of groups/datasets.

I'm happy to come up with a more detail description, but don't want to engage into this if I don't understand properly the tradeoff that need to be achieved.

Hi @Carreau,

I'm trying to understand the reasoning, choices and trade-off made when the DirectoryStore on disk layout was created.
As far as I can tell it has been done to be:

relatively simple
cose to the default zarr protocol.
internal meant to be inspected by humans, subgroup in hierarchy accessed independently without opening the root via the zarr lib.

Yes, it makes the data very "hackable" in the sense that they're easy to manipulate using generic tools, like file browsers, cp, rsync, text editors, etc.
There is another consideration which is that the cloud stores (GCS, S3, ABS) use the same mapping of storage keys to object paths. What this means is that data can be created on a local file system using DirectoryStore, then copied to cloud via a utility like gsutil.

Are these assumption of mine correct ? To what extent could they be changed – for the internal implementation of DirectoryStore for v3 spec assuming the end user API does not change?

That is a good question. I'm not sure, needs some careful consideration.

For multiple language implementation of the DirectoryStore v3, I'm supposing we also care about a few other things mainly:

On disk layout should be relatively friendly to machines and many languages.

Ideally, yes.

robust to Key Cases (as the zarr protocol may allow unicode and enforce store to maybe be case sensitive?)

Ideally, yes.

Efficient when possible.

Again, ideally, yes. Although efficiency for cloud object stores is likely a more important consideration than efficiency on a local file system. Much of the current v3 design of storage keys is there to accommodate performance and functionality limitations of cloud storage.

There are few other questions that I have not seen mentioned in discussions/spec of the DirectoryStore, mainly whether soft/hard links are allowed, how permission is handled and wether writing over a chunk keep the inodes and seek write or should replace the files.

I think these are all implementation choices. E.g., the current Python implementation replaces files to avoid files being left in a partially-written state. But that is not mandatory.

I believe some of the current constraint on casing and efficiency of current DirectoryStore can be overcome with minimal loss of readability for human exploring the internal of such a datastore.
for Example, we could change the encoding of keys as follow.

in the Zarr Protocol allow arbitrary unicode for keys, or at least relax casing.
For the DS, encode the key as follow.

A key in the DS would HUMAN_PART-MACHINE_PART

the HUMAN_PART would be ascii-restricted, non empty version of the key, mostly informative for the user exploring the filesystem.
MACHINE_PART would be base32 encoded version of the key stripped of trailing =. This would ensure ability to store complex unicode keys without having any issues with casing, or reserved names (like COM on windows, names starting with dashes, dots.. etc.

I've also been wondering about approaches like this, following your previous suggestions.
This is tricky, and I think this will need some time to work through. But FWIW, my current feeling is that we'll need to offer a choice.
I.e., I think it should be possible to use a natural approach to forming storage keys and translating these into file paths, similar to in the current zarr v2 implementations. This is best for hackability and for moving data between file systems and cloud stores. Lots of people are happy with this approach in v2, and I have only ever heard of one situation where a problem arose because of use on case insensitive file systems.
And I think it should also be possible to define and use a different approaches to forming storage keys such as the approach you suggest, which is less hackable but robust to case insensitive file systems.
Bottom line, this is one of those situations where it's very hard to see all possibilities, and so probably the best we can do is design some flexibility into the protocol to allow people to make choices and explore new options should problems arise or better ideas come along.
Thinking out loud, but I wonder if it would be better to deal with this within the v3 core protocol above the layer of the store interface. In other words, the v3 core protocol could offer a choice of different possible approaches regarding how storage keys are formed. The default would be to form storage keys as currently specified. That section of the spec defines rules for forming storage keys for metadata documents and data chunks, given a node at some hierarchy path P. But different approaches could be defined, either within the core protocol, or via protocol extensions.

Thinking out loud, but I wonder if it would be better to deal with this within the v3 core protocol above the layer of the store interface. In other words, the v3 core protocol could offer a choice of different possible approaches regarding how storage keys are formed. The default would be to form storage keys as currently specified. That section of the spec defines rules for forming storage keys for metadata documents and data chunks, given a node at some hierarchy path P. But different approaches could be defined, either within the core protocol, or via protocol extensions.

Note that whether you want to use keys like "data/foo/baz/0.0.0" or "data/foo/baz/0/0/0" (a.k.a. "nested" directory store) would be an example of this kind of configuration choice. I.e., these are two different approaches regarding how to form storage keys for data chunks, and which approach is in use could be declared within the entry point metadata document. I.e., it is a choice above the level of the store interface.

Thanks, I think one of the key point I was missing was the transfer from the filesystem to a cloud environment, and explain a lot.
I'm reticent to have too much flexibility on the store internal data structure, by experience with Jupyter Notebook format that leads to issue across implementation. At least there should be a "canonical" version, so that something can be normalized. "Be conservative in what you send be liberal in what you accept", with what you send be on on disk version. (Though I've head the opposite if good as well to detect misbehaving implementation, but that's mostly network protocol.

Note that whether you want to use keys like "data/foo/baz/0.0.0" or "data/foo/baz/0/0/0" (a.k.a. "nested" directory store)

I'm wondering about efficiency of those, with /0/0/0 it's hard to detect wether you are accessing a group or a chunk.
Thanks for the helpful insight, 'll try to send some updates to the spec v3 draft to that highlight those reasoning.


Add new column to Grid (ts

I want to add new column to mygrid.ts at position 0, and assign a row number(incremental) to it.

a row number(incremental)

should be your table's identity number (auto incremental), and you can put identity column at 1st position in your "mygridcolumns.cs"
Also you can put a column at any position in your grid columns,
check it out:  https://github.com/volkanceylan/Serene/blob/master/Serene/Serene.Web/Modules/BasicSamples/Grids/InlineActionButtons/InlineActionGrid.ts

Thanks For your reply.
i dont want a database field. just a new column that  give the serial no to all the records. always starting from 1 and so on. (call it sequence no/serial no  for each row in the grid) ,

Hi @sispk6 ,
How has this "visual only sequence number" to behave when the records are resorted? Keeping the initial value or again the most top line starting with 1 and ascending to the most bottom one?

@JohnRanger
again the most top line starting with 1 .
actually trying to implement this code now
Add to grid.ts, as it is
 public class RowIndexFormatter : ISlickFormatter
    {
        public string Format(SlickFormatterContext ctx)
        {
            return (ctx.Row + 1).ToString();
        }
    }

column.cs
[RowIndexFormatter, EditLink]
public int RowIndex { get; set; }

ISlickFormatter is unidentified in grid.ts

@JohnRanger This should be pretty simple since a common requirement of Grid. but i have not been able to do it. Above example was the only clue i got in forum. still struggling.

Im still stuck in this.

https://github.com/volkanceylan/Serene/blob/master/Serene/Serene.Web/Modules/BasicSamples/Grids/ViewWithoutID/ViewWithoutIDGrid.ts


Can not find  keras in Tensorflow.Net 0.30

Hi，it seems keras has been removed from Tensorflow.Net，why?
how to use keras now?  please suggest.
Thanks.

Keras is deployed in a separate package: https://www.nuget.org/packages/TensorFlow.Keras/

get it, Thank you very much.


Regarding Custom Plugins

Hi, @jkjung-avt,
Thanks for your great Work and continues Support. I have learnt a lot from your blogs and from your open-source implementations.
Actually, I am currently working on adding a custom plugin to the TRT. So, I am referring to your implementation of the Custom plugin for Yolov3 and yolov4.
Having said that, I just want to understand how you are using the Custom Plugins here(https://github.com/jkjung-avt/tensorrt_demos/blob/master/yolo/plugins.py). I have understood that: after compiling yolo_layer.h and yolo_layer.cu, I will get the .so file, you are loading the .so(as a library) in plugins.py file. Is this right?
And also, why you are passing the 8 values under the Field_collection here: https://github.com/jkjung-avt/tensorrt_demos/blob/451208d77af78d66f0fcbd70802b8bea1701eb5e/yolo/plugins.py#L152 to create_plugin(). Where is that referenced in yolo_layer.cu?
And, lastly, may I know how the execution flow is going on in yolo_layer.cu?
Thanks in advance,
Darshan C G

I have understood that: after compiling yolo_layer.h and yolo_layer.cu, I will get the .so file, you are loading the .so(as a library) in plugins.py file. Is this right?

Yes.  You could refer to: https://github.com/jkjung-avt/tensorrt_demos/blob/451208d77af78d66f0fcbd70802b8bea1701eb5e/yolo/plugins.py#L12-L17

Where is that referenced in yolo_layer.cu?

https://github.com/jkjung-avt/tensorrt_demos/blob/451208d77af78d66f0fcbd70802b8bea1701eb5e/plugins/yolo_layer.cu#L352

may I know how the execution flow is going on in yolo_layer.cu?

Please read NVIDIA's documentation and sample code of TensorRT plugins.


Maxlengte limit voor Route

I don't think you understood my feedback, let's call about this ticket.


Compose overflow

Fixed a bug in compose.css which lead to the compose box
overflowing off the screen when the compose box was expanded,
in preview mode and the preview text did not fit on the screen.
Fixes: #23493

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Thanks for working on this, @Nibor9198!
Please fix the failing test and add screenshots (and, perhaps, a screen capture) to your pull request to illustrate the changes. Once you've done so, please post a comment requesting review.

You will also need do drop the merge commit from your PR; please see here for more info.

@Nibor9198 are you still working on the PR? If not, I'd love to take it up.

@Nibor9198 are you still working on the PR? If not, I'd love to take it up.

Its already solved, I just need fix my pull request. But good luck finding a fun PR!

@SameepAher Please comment on the PR if you have any feedback on the code. Thanks!

@SameepAher Please comment on the PR if you have any feedback on the code. Thanks!

According to me, the code is perfect.
Though, I don't have a solid reason as to why height: 0 works, I have tested the output for different heights.
It seems there is a threshold height (733px as per my testing) up to which any height avoids overflow.
So, if we don't define the height property under #preview_message_area in compose.css, it will assume the height to be the height of content (the actual vertical space the message in the compose box needs), which might lead to overflow of text and buttons (on the bottom of the compose box) being pushed off the screen.

I would like us to find a solution that we do understand why it's correct.

I would like us to find a solution that we do understand why it's correct.

It's been addressed here

Since essentially the same PR was done correctly by @SameepAher in this PR I am closing this PR.
Thank you @SameepAher, I have had some weird problems with my git config on my local machine so it would have taken a while for me to fix it.

Oh, no issues :+1:
Thanks.


[android] Provide correct temporary directory path.

Android Bionic uses /data/local/tmp as the temporary writable directory.
TMPDIR is rarely set and /tmp doesn't exist.
There's some usage of /tmp/ in the tests that might be wrong and might
need to be fixed in the future, but I have to check one by one and right
now I don't have a device to test on.

@swift-ci test


[analyzer] associate some diagnostics with RemoveAnnotation

There are some with a note about offering a fix by removing the annotation.

https://dart-review.googlesource.com/c/sdk/+/276641


Include Option to Render Ellipses For Skipped Lines When Using Selected Lines

As part of #11, We add logic to allow users to select which lines are rendered for a snippet by passing in selected_lines as snippet JSON configuration. We should allow users to configure if they want an ellipsis, ..., comment to be rendered to signify that lines where skipped. The ellipsis would be rendered for every skipped portion of the snippet content and the comment should have the appropriate spacing. An example would be if we have a source snippet of
// snippet::start main { "lang": "rust" }
fn main() {

    // snippet::start nested
    println!("printing...")
    // snippet::end
}
// snippet::end

Target snippet would define a new attribute selected_lines_include_ellipses which defaults that ellipses are not included
Select Lines
<!-- snippet::start main { "selected_lines": ["1", "3-4"], "selected_lines_include_ellipsis": true } -->
<!-- snippet::end -->

in this target snippet we do not select line 2 leaving a gap. This would cause the following to be rendered
Select Lines
<!-- snippet::start main { "template": "code", "selected_lines": ["1", "3-4"], "selected_lines_include_ellipsis": true } -->
```rust
fn main() {
    // ...
    println!("printing...")
}
```
<!-- snippet::end -->

Planning on also supporting selected_lines_include_ellipsis as a global setting in snippext.yaml config as well as a extract CLI arg.


Change all list exercise commands into mocked tests.

Closes #184

Coverage increased (+0.1%) to 41.362% when pulling<PHONE_NUMBER>feccb18d1b0a7a0fd59f1b4e419af3 on mock-tests-aleksi into<PHONE_NUMBER>c42dd72fa013e9a7b5c2f63f34e1f1 on master.

Coverage increased (+0.3%) to 41.56% when pulling 35e56b6924b234987c1a22a01e56bf0540c28b56 on mock-tests-aleksi into<PHONE_NUMBER>c42dd72fa013e9a7b5c2f63f34e1f1 on master.

LGTM

Coverage increased (+0.3%) to 39.729% when pulling e3998a2d84048ec4959413efa43fdb101a60617d on mock-tests-aleksi into 11041e31cd88c154e1b00192dd4fc4e8da64c1dd on master.


Split wallet new static

Description
I'm splitting cardano-sl-wallet-new in the top level default.nix. I can't use it as a dependency in its current form as justStaticExecutables throws away the library.
I've also pulled in @disassembler's changes ignoring dist and other local files. That's a separate commit and can easily be dropped if we'd prefer to wait for his original changes to reach develop.
Type of change

[x] 🐞 Bug fix (non-breaking change which fixes an issue)
[~] 🛠 New feature (non-breaking change which adds functionality)
[~] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[ ] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[~] I have read the style guide document, and my code follows the code style of this project.
[~] If my code deals with exceptions, it follows the guidelines.
[~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

[~] I have added tests to cover my changes.
[~] All new and existing tests passed.

QA Steps
I need some code review on where the new derivation cardano-sl-wallet-new-static should be used instead of cardano-sl-wallet-new
@adinapoli-iohk @disassembler @jmitchell @cleverca22 @k0001
Supersedes #2928

Closed because this PR is just too old.

this also was already done in [DEVOPS-1027] make hydra show metrics for derivations  [Samuel Leathers] so perfectly correct to close.


fix rspec tests

This tightens the required RSpec version in the gemspec, and fixes a couple of tests.
Additionally, it removes an unused gem that was causing compatibility issues with JRuby.

I'm not sure why the Travis build is failing -- it seems to be something wrong on your end.  Is this project still being maintained?

ok, I was able to fix it -- it appears there was a problem with the version of bundler in travis.  Updating the .travis.yml to install a new version of bundler makes the build work.

I also added JRuby to the .travis.yml file to ensure JRuby compatibility.


Fix Go formatting

In accordance with Go Report Card standard

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   93.54%   93.54%
=======================================
  Files           7        7
  Lines         124      124
=======================================
  Hits          116      116
  Misses          4        4
  Partials        4        4

Impacted Files
Coverage Δ

config/config.go
100% <ø> (ø)
:arrow_up:

api/api.go
100% <ø> (ø)
:arrow_up:

api/viacep/viacep.go
88.57% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c681256...cb553c9. Read the comment docs.

@dukex can you incorporate this commit on your PR or make sure that the changes here are there, then we merge your PR.. thanks for the contribution @zbeach.. otherwise, there will be conflicts between the two PRs


Handle 409 - object is being deleted: authenticationservices already exists.

Test failed on CI with:
Failure executing: POST at: https://<IP_ADDRESS>:8443/apis/admin.enmasse.io/v1beta1/namespaces/enmasse-infra/authenticationservices. Message: object is being deleted: authenticationservices.admin.enmasse.io "standard-authservice" already exists. Received status: Status(apiVersion=v1, code=409, details=StatusDetails(causes=[], group=admin.enmasse.io, kind=authenticationservices, name=standard-authservice, retryAfterSeconds=null, uid=null, additionalProperties={}), kind=Status, message=object is being deleted: authenticationservices.admin.enmasse.io "standard-authservice" already exists, metadata=ListMeta(_continue=null, resourceVersion=null, selfLink=null, additionalProperties={}), reason=AlreadyExists, status=Failure, additionalProperties={})

@enmasse-ci run tests profile=upgrade upgrade_from=0.28.1


[JS] [KeyVault] Design and implement Secrets API

This is the meta issue for designing and implementing the Secrets portion of the Key Vault SDK v2.
We can close this epic when the following are complete

[x] API Proposal ready
[x] The updated API shape is merged into master
[ ] The Secrets API is available as a standalone package
[ ] We have test coverage for the new API shape
[ ] We have documentation (samples inside readme) for the API

I made this issue to reference the third point: https://github.com/Azure/azure-sdk-for-js/issues/3230

Checked this from your list: The Secrets API is available as a standalone package.


SuperElastix Application crashes

The SuperElastix comandline crashes (at destruction time) with no exceptions caught.
Minimal example:
..\SuperElastix.exe --conf ..\Configuration\Minimal_noComponent.json
with Minimal_noComponent.json:
{     "Component": {         "Name": "XX"     } }

You can have a look at this commit: https://github.com/SuperElastix/SuperElastix/commit/fa249edccc2c353e1717ab5ac528f271120d3777. I had the same problem and in my case it was related to memory management of the blueprint. Maybe it also solves your problem.

Is now PR #120


cannot find these class

import livekit.LivekitModels
import livekit.LivekitRtc
cannot find these class

Follow the Dev Environment instructions if you're going to be building from the repo directly.


AVRO-2732 / AVRO-2733 Fix master build on CI.

The recent bump in the openjdk images causes some breakage in the travis-ci build.
I've included two independent fixes in this PR (both should be necessary), but I'm specifically not pleased with the first one (importing openjdk-8-jdk from the unstable)...
Jira

[X] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"

https://issues.apache.org/jira/browse/AVRO-2732
https://issues.apache.org/jira/browse/AVRO-2733
In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

The test will be seeing the build pass!
Commits

[X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

I'm closing this for now, looking for better alternatives to using the sid/unstable debian packages to get JDK 8.


Iotedge 1197 Android TV PoC

Does examples/proof-of-concept/mobile-sdk/forgetv/gradle/wrapper/gradle-wrapper.jar get generated at some point? Should it be part of the commit?


LiteDB Single Documents One Million Data Retrieval Performance Issue taking more than 10 Mins to return the data using Find()

Hi Friends,
I have a .TXT file having more than 3GB file size and I am parsing this file and extracting data from each line and loaded all the data into LiteDB in a single collection.
Now LiteDB contains ONE MILLION Rows in the table collection.
I have some columns in the table "_id, FileName, Column3, Column4, Column5... Column8" and the primary key column is "_id " which is a GUID.
I have created a index for column "FileName" like below
this.DBContext.GetCollection(TableName).EnsureIndex("FileName", "$.FileName");
After successful creation of index the GetIndexes() functions returns two index one is "_id" and "FileName"
Now LiteDB contains nearly ONE MILLION Rows in a Table and When i try to retrieve all one million data from LiteDB using below Find() function it's taking more than 10 mins to return or Database Connection Got Timed Out.
List obj = this.DBContext.GetCollection(CollectionName)
.Find(Y=> Y.FileName
.Equals(inputFileName)).ToList();
File name is in Lower Case only in LiteDB and inputFileName also.
Kindly help me on this to resolve how to retrieve data in faster way/optimized way to get One Million record in the faster way.
Thank You for your support in Advance.
Thanks & Regards,
Selvan

@TamilGithub06 Is there a log file? If so, you should run db.Checkpoint(). If there's not, perhaps db.Rebuild() improves the performance. Also, could you run the following command and post the result here?
string queryPlan = this.DBContext.GetCollection(CollectionName).Query().Where(Y=> Y.FileName.Equals(inputFileName)).GetPlan().ToString();

Sorry for the very late response.
Thank you very much for your quick response Leonardo Nascimento.
We are using LiteDB version 4.1.4 when I tried to execute the command i am getting the below error message.
Error CS1061 'LiteCollection' does not contain a definition for 'Query' and no extension method 'Query' accepting a first argument of type 'LiteCollection' could be found (are you missing a using directive or an assembly reference?
Thanks & Regards,
Tamilselvan D

@lbnascimento, Please find my above comments.


Cake! 🎂  ❤

🎂

We'll do this when getting to #1209 :-)

@s0lvang where's my cake? :angry:

We the captain now


docs: ObjectHandle.NewWriter always truncates files

*storage.Writer always truncates files when calling .Close, no matter what.
I think this behaviour should be more clearly documented. I can rephrase it however you like, if required.
This bite me while building a Google Cloud Storage client for a filesystem abstraction library soon to be used on production.

Sorry, we don't use pull requests for this repo. This repo is just a mirror of code managed by Gerrit upstream.
Let's discuss on a new bug instead. The proposed wording needs some work.


Exporting platform agnostic zip file artifact during release

We need to export the build as a zip file during the release process and list in the released assets. A user should be able to download, extract and open the index.html via his browser (independent of their operating systems).

Done in 0.13.6


toggleTerminal may not focus terminal anymore

Repro:

Open terminal
Focus editor
ctrl+`

Regression in https://github.com/microsoft/vscode/pull/184963/files
cc @connor4312

It runs the command and opens the view, it doesn't focus it though:

Not reproducing in OSS yet

Tracking in https://github.com/microsoft/vscode/issues/185369
/duplicate


Add Curl

It would be great to have libcurl support in Hunter!
https://github.com/bagder/curl
I love everything Hunter is trying to accomplish, thanks for all the hard work!

@jneidlinger What platform are you interested in? The last time I've tried to build Curl universal iOS library I've hit some troubles. Mainly because it generates different headers for different architectures. With this exception it should "just work" since it has a CMake build. Can you try: https://github.com/ruslo/hunter/wiki/usr.adding.new.package ?

Well, in a perfect world, Win/Lin/OSX + Android/IOS/WinRT
I've only ever built seperate libcurl iOS architectures and lipo'd them myself. Other's go the route of using a different build system, for example:
https://github.com/biasedbit/curl-ios-build-scripts
will build curl as a universal library for you

The last time I've tried to build Curl universal iOS library I've hit some troubles. Mainly because it generates different headers for different architectures.

Here is the place to workaround Curl header issue that I was talking about:
https://github.com/gcesarmza/curl-android-ios/blob/503d7ef85a9650503a0620993c066576509f5d7e/curl-compile-scripts/build_iOS.sh#L89

for example:
https://github.com/biasedbit/curl-ios-build-scripts
will build curl as a universal library for you

this script doesn't handle header issue, here is a bug: https://github.com/biasedbit/curl-ios-build-scripts/issues/24
Quote:
This is because curlbuild.h differs for the 32 bit and 64 bit versions,
but the build script assumes that they are the same, and uses just
the 32 bit version

Good find

Well, in a perfect world, Win/Lin/OSX + Android/IOS/WinRT

I've never used WinRT, if it's supported by CMake should work too though. The rest platforms should work fine.

Added by #511. Not all toolchains are working, see testing branches for available list:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.914
https://travis-ci.org/ingenue/hunter/builds/157820991


placeholder text zach/nightly ux option doesnt change anything

The option to set the placeholder text as the group or contact name doesn't work at all, it just always says BlueBubbles

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @Intellijence in #requests.

I'm working on it.

I'm working on it.

Ok close this I fixed it

Ok close this I fixed it

wait nvm only fixed on material

wait nvm only fixed on material

nvm fixed on everything

nvm fixed on everything

Do you have a commit to relate to this ticket?

Do you have a commit to relate to this ticket?

I'm gonna make a pull request for it once I fix the 4 other issues in Material.

I'm gonna make a pull request for it once I fix the 4 other issues in Material.

#675

#675

Fixed. Closing


Change image to galaxy-min 21.01

We should probably either merge this or change appVersion back.
On a related note, do we also want to revert back some versions and do a big 4.0 release with 21.01? We can start by just forcing it back to 4.0.0 or 4.0.0-dev after which we don't use labels on PRs for a few days and just overwrite that single version until we are satisfied and we release 4.0.0 and restart bumping from there? Purely aesthetic, so happy to not, but we're still close to when the 4's started being packaged so we could still just do a force cleanup hopefully without affecting anyone

Can we just push 4.0 out quickly?


Difference / bias map plots

Difference between two spatial fields.

Consider around difference between cubes and differences between just the data in the cubes. This is relevant for comparing between UM and LFRic.

I think we can already load multiple models by putting wildcards in the load path.


fix windows NotImplementedError

When running the find command at least, proxybroker returns zero results and spams the terminal with NotImplementedError that traces back to pycares, the dep that aiodns uses.
The solution to this seems to be replace aiodns with dnspython, a dependency that is kept up to date.

Unrelated but aiohttp should be updated because on windows at least when executing the find command, python raises an NotImplementedError This doesn't seem to occur on linux.
Updated Dependencies because aiohttp 3.8.1 was causing issues

I don't know how to fix the test cases...

@ziloka seems that you need to remove aiodns related codes in test and mock self._resolver.resolve() instead.

linked issue https://github.com/bluet/proxybroker2/issues/113#issuecomment-1427189725

@ziloka seems that you need to remove aiodns related codes in test and mock self._resolver.resolve() instead.

haha I don't exactly know how to, thats the issue

I'm probably using it wrong, but this is my point

https://github.com/bluet/proxybroker2/blob/544837733468f15dcf64d369992da4df7b1804c2/tests/test_resolver.py#L46
This function means to get the external ip address.. right? But it tests for the internal ip address..

hi @ziloka did you intend to close this issue because it's been fixed?


feat: build app in CI

Not sure why the build fails all of a sudden, but it's reproducible locally. Will look into a fix.

lgtm!


created a simple live edit css editor

Hi Rob! Do you mind adding a screenshot or a deployed link? Thanks - Nat


fmapLT is basically withExceptT

Except that withExceptT has less requirements:
withExceptT :: Functor m => (e -> e') -> ExceptT e m a -> ExceptT e' m a
fmapLT      :: Monad   m => (a -> b ) -> ExceptT a m r -> ExceptT b  m r

I think it's fine if errors exports two functions that do the same thing.  There are other examples of this in the library like all the MonadPlus functions in Control.Error.Safe are generalized versions of the functions re-exported from the Safe library

Hm, in that case wouldn’t it make sense to redefine fmapLT = withExceptT? This way you can have the more general type and still use the name symmetry.

I don't define withExceptT.  It's re-exported by default from Control.Monad.Trans.Except from transformers

Oh sorry, I misunderstood your comment and read it backwards.  Yeah, I could do that


Main content has viewpager with Recyclerview inside

Hi Thanks for help, I Have Recyclerview inside viewpager main content, my problem is the last items is not is covering with panel how to scroll above that

I had the same problem. If you add
sothree:umanoOverlay="false"
to your <com.sothree.slidinguppanel.SlidingUpPanelLayout> element it will make the recycler view scrollable


Amplify Pull not working

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
21.4.0
Amplify CLI Version
12.10.3
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made.
Describe the bug
Failure updating Xcode project during amplify pull:
Updating Xcode project:
🚫 xcodeProject:
-- Caused by: notFound(path: "[redacted]")
🛑 Command failed with exit code 1: /Users/[redacted]/.amplify/lib/aws-amplify-amplify-frontend-ios/resources/amplify-xcode import-config --path=[redacted]
Resolution: Please report this issue at https://github.com/aws-amplify/amplify-cli/issues and include the project identifier from: 'amplify diagnose --send-report'
Learn more at: https://docs.amplify.aws/cli/project/troubleshooting/
Expected behavior
I would expect no issues during amplify pull
Reproduction steps

Run amplify pull

Project Identifier
I could not create the file because pull failed.
Log output

# Put your logs below this line

Additional information
Since I've been having trouble using amplify pull, I've been attempting to copy relevant files into my iOS project however I'm now experiencing permission issues with Amplify DataStore so I imagine it could be related.
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

I've identified that the root cause of the encountered challenge was related to the specific directory from which amplify pull was being executed. It's crucial for the command to be run in the top-level directory of the project, where the Xcode project file resides, to ensure proper integration and configuration. Closing the issue.