System hangs when repeatedly triggering a wav file on Teensy 4.0

Hello! first off thanks for the great lib. its amazing how many projects must be using SDfat now : )
I am trying to rid my system of clicks and pops when loading multiple WAVs on Teensy 4.0, several people have mentioned the issues with SD.h so I am trying sdfat on T4. SdFormatter, SdInfo and TeensySdioDemo are all working well! I can even get one wav playing using my own code and its seems the dropouts when a single wav is triggered repeatedly are much improved. Sadly when I try and trigger 4 wavs at the same time, although they play I loose control of the system at the serial window until they have finished playing. If I trigger two wavs at the same time, I can retrigger a couple of times and then I loose control. I also have the cash register sound that I can trigger as it is handy for debug.
Here is the code... (super lean to keep it simple)
`#define USE_SdFat_ // uncomment for SdFat.h, comment for SD.h lib.
#include "SdFat.h"
SdFat sd;
#include <Audio.h>
#include <Wire.h>
#include <SPI.h>
// GUItool: begin automatically generated code
AudioPlayMemory          sound0;         //xy=257,200
AudioPlaySdWav           playSdWav2;     //xy=296,375
AudioPlaySdWav           playSdWav3;     //xy=313,439
AudioPlaySdWav           playSdWav1;     //xy=324,292
AudioPlaySdWav           playSdWav4;     //xy=345,516
AudioMixer4              mixer1;         //xy=802,203
AudioMixer4              mixer2;         //xy=851,322
AudioOutputI2S           i2s1;           //xy=1069,248
AudioConnection          patchCord1(sound0, 0, mixer1, 1);
AudioConnection          patchCord2(sound0, 0, mixer2, 2);
AudioConnection          patchCord3(playSdWav1, 0, mixer1, 0);
AudioConnection          patchCord4(playSdWav1, 1, mixer2, 1);
AudioConnection          patchCord5(mixer1, 0, i2s1, 0);
AudioConnection          patchCord6(mixer2, 0, i2s1, 1);
// GUItool: end automatically generated code
// Use these with the Teensy Audio Shield
//#define SDCARD_CS_PIN    10
//#define SDCARD_MOSI_PIN  7
//#define SDCARD_SCK_PIN   14
// SDCARD_SS_PIN is defined for the built-in SD on some boards.
#ifndef SDCARD_SS_PIN
const uint8_t SD_CS_PIN = SS;
#else  // SDCARD_SS_PIN
// Assume built-in SD is used.
const uint8_t SD_CS_PIN = SDCARD_SS_PIN;
#endif  // SDCARD_SS_PIN
// Use these for the SD+Wiz820 or other adaptors
//#define SDCARD_CS_PIN    4
//#define SDCARD_MOSI_PIN  11
//#define SDCARD_SCK_PIN   13
int inByte = 0;
byte  newDATAin = 1;
#include "AudioSampleCashregister.h" // http://www.freesound.org/people/kiddpark/sounds/201159/
void setup() {
Serial.begin(115200);
// Audio connections require memory to work.  For more
// detailed information, see the MemoryAndCpuUsage example
AudioMemory(100);
//SPI.setMOSI(SDCARD_MOSI_PIN);
///SPI.setSCK(SDCARD_SCK_PIN);
if (!sd.begin(SdioConfig(FIFO_SDIO))) {
// stop here, but print a message repetitively
while (1) {
Serial.println("Unable to access the SD card");
delay(500);
}
}
}
void loop() {
switch (Serial.read()) {
case 's': {
Serial.println("s");
// envelope1.noteOff();
// envelope2.noteOff();tttttttttttt
playSdWav1.stop();
playSdWav2.stop();
playSdWav3.stop();
playSdWav4.stop();
//playSdWav5.stop();
//playSdWav6.stop();
//playSdWav7.stop();
//playSdWav8.stop();
sound0.play(AudioSampleCashregister);
}
break;
case 't': {
sound0.stop();
playSdWav1.play("10BAB1.WAV");
playSdWav2.play("10BAB2.WAV");
playSdWav3.play("10BAB3.WAV");
playSdWav4.play("10BAB4.WAV");
}
break;
case 'y': {
sound0.stop();
playSdWav1.play("10BAB2.WAV");
delay(5);
//playSdWav2.play("10BAB2.WAV");
//playSdWav3.play("10BAB3.WAV");
//playSdWav4.play("10BAB4.WAV");
}
break;
}
}`
Here is the audio used in the above example: http://donjohnstonmusic.co.uk/tr/sinewavs.zip
I am aware three of the wav players are not connected to any outputs, they still play and cause the issue and its the same when they are connected. is there something in the SDfat settings I can tweak to prevent this hang?
all help very gratefully received, I am properly stuck

SdFat uses two 512 byte cache buffers.  One for FAT entries and one for file data.  If you open multiple files, you will have problems since these caches will be invalidated often.
SdFat evolved from a 2008 library for an Arduino Diecimila with a ATmega168, 1 KB SRAM, and 16 KB flash and a single 512 byte sector cache.
It would be possible to extend SdFat for provide cache for each file but I have lost interest in developing SdFat.
SD cards are not intended to be multi stream devices without huge buffers and file read-ahead.
Teensy 4.0 is a nice board but is lacks a decent multi-tasking OS with an integrated file system that can cope with multiple data streams.

Thanks for taking the time to respond! Totally understandable, that all makes good sense. Do you think a pi running a light as possible os would be better suited for multiple data steams?

Pi has a better OS since the base is Linux.  It depends on how the file system cache is configured.

Thanks for the replies I will look into it! Regards, Al.

Hopefully this has fixed the problem.
https://github.com/PaulStoffregen/Audio/commit/6369a6ae1f3b6ea547a5192f9bf7efe3b778a629


Weird error based on running location

My TestRunner.html is placed in a tests folder.  However, if I go to the tests folder and run mocha-phantomjs ./TestRunner.html I got
Failed to use load and use the custom reporter ...../code/todomvc/backbone/tests/spec.js
Unsafe JavaScript attempt to access frame with URL about:blank from frame with URL file:///usr/local/lib/node_modules/mocha-phantomjs/lib/mocha-phantomjs.coffee. Domains, protocols and ports must match.

Looks like its similar to #167. Do you have a mocha-phantomjs.opts file in one folder vs. another? What about TestRunner.html vs. ./TestRunner.html?

Hello,
a) Nope, I don't have mocha-phantomjs.opts file.
b) I tried both TestRunner.html and ./TestRunner.html. The result is the same.
Are you able to reproduce the problem. Maybe it is something with my local setup.

I'm having the same issue.  Running mocha-phantomjs 3.5.3, phantomjs 1.9.8, and I have no mocha-phantomjs.opts file.

What if you invoke phantom directly?
phantomjs your/path/to/lib/mocha-phantomjs.coffee TestRunner.html

@nathanboktae--it renders the same error :(

Yeah I don't have enough information to help you. A publicly available repro of this issue would be appreciated.

Here we go, failing in this repo:
https://github.com/callumacrae/whtevr
https://travis-ci.org/callumacrae/whtevr

@nathanboktae Are you able to replicate? I'm getting the same error on another repo.

I think my issue was caused by calling mocha.run() when I wanted to call mochaPhantomJS.run().
https://github.com/callumacrae/whtevr/commit/0370bf6c14346b437075a319e203edc17b5befe2

Closing as a dupe of #167


Update TWAMM.sol

Well, this PR made 2 types of changes and these changes feels like valid as far as I am concerned. If not then do let me know and tell the reason which will be another great learning experience. Anyways let's dive into the changes made:
1. Struct Packing: As we know, that solidity use slots and the usage of it really affects the gas (means more the slots more gas used by the contract). I have noticed that rest of the structs were perfectly packed but not this one. Earlier it was using 4 slots and now decreased to 3.
2. Changed bool [variable-name] = false; to bool [variable-name];: Not really sure about this change (looks like it's been done on purpose) but while I was going through the repository, there were several examples of unsigned integers not initialized to any value, thus leaving their value as 0 by default. And, same concept applies to this boolean variable. When not initialized, it's default value gonna be false

PR is incomplete and adds small gas increase when run with forge test. Not necessary, so closing.


GenICam 32bit

Hello
Following this closed issue: https://github.com/genicam/harvesters/issues/43

The development of the 32bit version will come after the version 3.2 release so it would be some time in 2020

well, GenICam is version 3.3 and it's 2021, I couldn't find any information on EMVA website regarding the 32 bit version.
Is it released yet?
Thank you,
Shorlaks

@Shorlaks Please excuse me, we are not working on it and can't give you any feasible release plan for the 32-bit version. Please excuse me. Regards, Kazunari.

@kazunarikudo It's alright, Thank you


Update filters

Remove company filters and add seniority and city filters.
The two added filters are more useful.

I am not sure I understand why we should remove the company filter, should we not just add filters for the Seniority and Cities ?

Closing this as we brought the company's filter back


[SP-2959][PDI-15296] Arguments (legacy) do not work in Spoon 6.1

[SP-2959][PDI-15296] Arguments (legacy) do not work in Spoon 6.1
-fix regression opening run dialog with transformation without file
@mbatchelor @mchen-len-son Could you please review and merge it?

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/job/JobExecutionConfiguration.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change:  + 7.14%
Complexity Change:  + 7.69%

org.pentaho.di.job.JobExecutionConfiguration

Instruction Change: -.42%:small_red_triangle_down:
Line Change: -.14%:small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Instruction Change: -.19%:small_red_triangle_down:
Line Change: -.27%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%


Issues modelling tides with JSON definition files

Hey @tsutterley, I've been trying to test out the new GOT5.5/5.6 using the JSON definition files included in tests. My directory looks like this:

I can run tide modelling for other models (e.g. FES2012) from a .def format definition file pretty easily, e.g.:
from pyTMD.compute import tide_elevations
import pandas as pd
import numpy as np

out = tide_elevations(
    x=[122.14],
    y=[-17.9],
    delta_time=pd.date_range("2020", "2021", periods=2),
    DIRECTORY="/gdata1/data/tide_models/",
    MODEL="FES2012",
    DEFINITION_FILE="/gdata1/data/tide_models/model_FES2012.def",
    DEFINITION_FORMAT="ascii",
    EPSG=4326,
    TIME="datetime",
    EXTRAPOLATE=True,
    CUTOFF=np.inf,
)

However, if I try to do something similar with a JSON fromat definition, I get an TypeError: intern() argument must be str, not list error:
out = tide_elevations(
    x=[122.14],
    y=[-17.9],
    delta_time=pd.date_range("2020", "2021", periods=2),
    DIRECTORY="/gdata1/data/tide_models/",
    MODEL="GOT5.6",
    DEFINITION_FILE="/gdata1/data/tide_models/model_GOT5.6.json",
    DEFINITION_FORMAT="json",
    EPSG=4326,
    TIME="datetime",
    EXTRAPOLATE=True,
    CUTOFF=np.inf,
)

Is there anything I'm doing obviously wrong here? I wasn't exactly sure what additional params need to be provided when specifying JSON definition files, beyond DEFINITION_FORMAT="json"...

Full error
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[23], line 40
     18 import numpy as np
     20 # out = tide_elevations(
     21 #     x=[122.14],
     22 #     y=[-17.9],
   (...)
     36
     37 # out
---> 40 out = tide_elevations(
     41     x=[122.14],
     42     y=[-17.9],
     43     delta_time=pd.date_range("2020", "2021", periods=2),
     44     DIRECTORY="/gdata1/data/tide_models/",
     45     MODEL="GOT5.6",
     46     DEFINITION_FILE="/gdata1/data/tide_models/model_GOT5.6.json",
     47     DEFINITION_FORMAT="json",
     48     EPSG=4326,
     49     TIME="datetime",
     50     EXTRAPOLATE=True,
     51     CUTOFF=np.inf,
     52 )
     54 out
     56 # # from pyTMD.compute_tide_corrections import compute_tide_corrections
     57
     58 # # out = compute_tide_corrections(
   (...)
     68
     69 # # out
File /env/lib/python3.10/site-packages/pyTMD/compute.py:299, in tide_elevations(x, y, delta_time, DIRECTORY, MODEL, ATLAS_FORMAT, GZIP, DEFINITION_FILE, DEFINITION_FORMAT, CROP, BOUNDS, EPSG, EPOCH, TYPE, TIME, METHOD, EXTRAPOLATE, CUTOFF, INFER_MINOR, APPLY_FLEXURE, FILL_VALUE, **kwargs)
297 # get parameters for tide model
298 if DEFINITION_FILE is not None:
--> 299     model = pyTMD.io.model(DIRECTORY).from_file(DEFINITION_FILE,
300         format=DEFINITION_FORMAT)
301 else:
302     model = pyTMD.io.model(DIRECTORY, format=ATLAS_FORMAT,
303         compressed=GZIP).elevation(MODEL)
File /env/lib/python3.10/site-packages/pyTMD/io/model.py:1408, in model.from_file(self, definition_file, format)
1406     self.from_ascii(fid)
1407 elif (format.lower() == 'json'):
-> 1408     self.from_json(fid)
1409 # close the definition file
1410 fid.close()
File /env/lib/python3.10/site-packages/pyTMD/io/model.py:1734, in model.from_json(self, fid)
1730 elif (temp.type == 'z') and (temp.directory is not None):
1731     # use glob strings to find files in directory
1732     glob_string = copy.copy(temp.model_file)
-> 1734     temp.model_file = list(temp.directory.glob(glob_string))
1735     # attempt to extract model directory
1736     try:
File /env/lib/python3.10/pathlib.py:1030, in Path.glob(self, pattern)
1028 if not pattern:
1029     raise ValueError("Unacceptable pattern: {!r}".format(pattern))
-> 1030 drv, root, pattern_parts = self._flavour.parse_parts((pattern,))
1031 if drv or root:
1032     raise NotImplementedError("Non-relative patterns are unsupported")
File /env/lib/python3.10/pathlib.py:74, in _Flavour.parse_parts(self, parts)
72 else:
73     if rel and rel != '.':
---> 74         parsed.append(sys.intern(rel))
75 if drv or root:
76     if not drv:
77         # If no drive is present, try to find one in the previous
78         # parts. This makes the result of parsing e.g.
79         # ("C:", "/", "a") reasonably intuitive.
TypeError: intern() argument must be str, not list

I guess on a similar/related note - does this look correct for loading JSON format definitions directly from a dicitonary, e.g. passing the bytes_io object directly to DEFINITION_FILE?
# Example dictionary
data = {"format": "GOT-netcdf", "name": "GOT5.6", "model_file": ["GOT5.5/ocean_tides/2n2.nc", "GOT5.5/ocean_tides/j1.nc", "GOT5.5/ocean_tides/k1.nc", "GOT5.5/ocean_tides/k2.nc", "GOT5.6/ocean_tides/l2.nc", "GOT5.6/ocean_tides/m1.nc", "GOT5.5/ocean_tides/m2.nc", "GOT5.6/ocean_tides/m3.nc", "GOT5.5/ocean_tides/m4.nc", "GOT5.5/ocean_tides/ms4.nc", "GOT5.5/ocean_tides/mu2.nc", "GOT5.6/ocean_tides/n2.nc", "GOT5.5/ocean_tides/o1.nc", "GOT5.5/ocean_tides/oo1.nc", "GOT5.5/ocean_tides/p1.nc", "GOT5.5/ocean_tides/q1.nc", "GOT5.5/ocean_tides/s1.nc", "GOT5.5/ocean_tides/s2.nc", "GOT5.5/ocean_tides/sig1.nc"], "type": "z", "variable": "tide_ocean", "version": "5.6", "scale": 0.01, "compressed": False, "reference": "https://doi.org/10.1126/sciadv.abd4744"}

# Convert dictionary to BytesIO
bytes_io = io.BytesIO(json.dumps(data).encode('utf-8'))

out = tide_elevations(
    x=[122.14],
    y=[-17.9],
    delta_time=pd.date_range("2020", "2021", periods=2),
    DIRECTORY="/gdata1/data/tide_models/",
    MODEL="GOT5.6",
    DEFINITION_FILE=bytes_io,
    DEFINITION_FORMAT="json",
    EPSG=4326,
    TIME="datetime",
    EXTRAPOLATE=True,
    CUTOFF=np.inf,
)

Got it. Having the DIRECTORY argument triggers the glob functionality, so it is trying to search the directory for files. Right now that functionality only works with a single pattern (a string). If you drop the DIRECTORY argument and append /gdata1/data/tide_models/ to the start of each model_file in the definition file it should work. I will update the glob functionality to enable iterating on lists. That will also allow searching for constituent files in multiple directories.

Ah, makes sense - thanks!
One other slight usability improvement could also be auto-guessing the definition file format from the extension/datatype... e.g. if it's a JSON file or bytes_io, it's likely (always?) going to be JSON format. Perhaps the default for DEFINITION_FORMAT could be None or "auto" instead of "ascii", and automatically default to "ascii" under the hood for all file extensions other than JSON/bytes_io? (but still allow passing "ascii" and "json" manually too like currently)

That's a great idea! Implemented in #319

Awesome, can confirm that both of these fixes/features work for me! Will do a small validatation of the new GOT models and see how they perform at our tide gauges. 🙂


Create ML_2_6_Logistic_Regression(A).md

#2799
@Isha307
Here is the audio format explanation of Logistic regression under supervised learning
Do review
Thank you

PR Merged 🎉 @PurviBhoyar21

@abhisheks008
can you please add a hacktoberfest-accepted label on this merged PR?


Begin a README.md for library.

This is a template for the README which will be specific to the Spec Math Library. I mainly wanted to get this out to show how to run the tests.

LGTM - but I would take out the license text. You don't need license headers in text files and the repo itself is covered by the same license.


Restrict font fallback families to be added

@hjanetzek Updated. Thanks

Note from @hjanetzek on why we are not using other styles for fallback fonts (in reference to 0f8a8d5):
the fallback font list is used to find glyphs that are not available otherwise. if that list contains e.g. a font with bold and then regular variant it would only always use the first since they provide the same glyphs

we could have separate fallback lists for different styles though making things more complicated (which I would not recommend right now though)


additionalProperties support

Needs support for additionalProperties (part of the OpenAPI specification). The official Swagger Codegen for Swift has some support for additionalProperties but would be great to see the same support in this project (as the code generated is so much nicer).
NB additionalProperties need to be supported in many cases:

Classes with no static properties but additionalProperties
Classes with both static and additionalProperties
Classes that are inheriting from classes with additionalProperties and vice versa.

https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#schemaObject

Yes, I believe SwagGen only supports the first case you mention, which doesn't generated a class but rather a dictionary such as [String: Model] or [String: Int] (or any other simple type).
Do you have a link or snippet of a spec that you would like to support?

Hi @yonaskolb
Yeh the implementation in Swagger codeGen was completely broken as someone tried to implement it like java and of course in Swift the class cannot just be a subclass of the dictionary (unless they changed the class's base type to an NSDictionary but that's not very swift).
@dwoodel and I implemented a solution based on adding an additionalProperties as a collection to the class and using a subscript accessor to set and get the values:
https://github.com/swagger-api/swagger-codegen/pull/5406
Not sure if there is a better approach. What do you think?
Either way I would just love to see it implemented in your generator. I'm happy to help but not 100% sure where to start. any thoughts?

Seems a reasonable approach. In my experience additionalProperties are either specified as a property, or as a seperate property of a Definition, not both within one schema. But I guess there are some api's that are defined like that.
Do you have a spec I could use for testing? Otherwise I'll just create one, and have a stab at this

This is a cut down version of some of the objects we create. Couple with defined properties and additionalProperties and one with just additionalProperties. Hope this helps:
"UserRequest": { 			"type": "object", 			"description": "Request user model", 			"additionalProperties": { 				"type": "string" 			} 		}, 		"UserResponse": { 			"type": "object", 			"properties": { 				"username": { 					"type": "string", 					"example": "jdoe", 					"description": "Name of user" 				}, 				"phoneNumber": { 					"type": "string", 					"example": "+375291112233", 					"description": "User's phone number" 				}, 				"status": { 					"type": "string", 					"example": "REGISTERED", 					"description": "User's status" 				} 			}, 			"description": "Response user model", 			"additionalProperties": { 				"type": "string" 			} 		}, 		"CreateUserRequest": { 			"type": "object", 			"properties": { 				"phoneNumber": { 					"type": "string", 					"example": "+375291112233", 					"description": "User's phone number" 				} 			}, 			"additionalProperties": { 				"type": "string" 			} 		}

@wuf810 please checkout #15 and see if it fixes your issue


Kill the process if was exception occurs

Now exists a problem:
If exit from function aiopytesseract.base_command.execute by timeout, process will not be closed.
I suggest this solution.

@shizacat, could you share some example with this problem? I couldn't reproduce this behavior locally.
If this is really a problem maybe we can use a try except block for asyncio.TimeoutError.

Example:
import asyncio
import aiopytesseract

# You need take your image
asyncio.run(aiopytesseract.image_to_string(
    "/tmp/img2.jpeg",
    lang="eng",
    timeout=0.1
))

After, how you caught exception by Timeout, exit from python and look up into console:
ps -aux | grep tess

You shall see process tesseract.

A bit of theory: Exception by wait_for, we got from python, but don't from process of tesseract, it nothing know about who and how long want to wait him.

Second statement
Do you mean without 'finally'? With him, we will may close process if occur something else errors.

@shizacat,
I managed to reproduce related behavior locally and you're right currently aiopytesseract only raise asyncio.TimeoutError and I agree that for better timeout management, we can kill tesseract process.
How aiopytesseract is a wrapper for tesseract-ocr I think wait_for is appropriate to us for this scenario.
Yes. I think that we don't need finally statement. Can you check the code related in the branch 0.7.0. I think this resolve the issue.

Ok, thanks


Bump elvis_core version to 0.3.7 and hex.pm it!

Fixed in https://github.com/inaka/elvis_core/pull/90


Intellisense popup gets in the way. It should be locatable elsewhere in the UI

VSCode Version: 1.10.0
OS Version: macOS 10.12.3

In the screenshot below the encircled popup is very annoying. I do not like the way that it covers up code that I may want to read while typing. I would like to move it to the top right corner of the editor via CSS or some other mechanism. It's nice to have the information, but not in such an obtrusive way.

@jsumners Are you using VsCodeVim by chance?
If so, then be sure to give this VsCodeVim issue a thumbs up.
If not, then I find esc works great for dismissing it (I have caps mapped to esc for convenience). When you want it to pop back up use ctrl + shift + space.

@bill-mybiz no. I only inflict Vim upon myself when working remotely or for quick edits.
The root of the issue is that having to dismiss the popup is disruptive to my workflow. Yet, I want to be able to glance at the information if I need it without having to invoke a three fingered hotkey.


Dynamic Programming: Comparison of three methods

Presentation in 1/11 will be about comparing three methods for numerically solving dynamic programming problems, which are Value Function Iteration, Policy Function Iteration, and Endogenous Grid Points.
I will follow the lecture notes by ZICE 2014. The specific problem  to be solved is from A Simple Optimal Growth Model in Quantitive Economics. I use the same code in Value Function Iteration, and then extend it to Policy Iteration and Endogenous Grid Points.

Good.
Will you also include your own code from the previous homework (i.e., the code that computes a fixed point by imitation games)?

Sure, if there is time left, I would like to include those previous homework (which are computing a fixed point by imitation games and Experimental Analysis of Lemke Howson Algorithm).

Here is my code.

So why don't you use your fixed point computation routine in place of qe.compute_fixed_point.

Do you mean use qe.compute_fixed_point to replace fmin function in Dynamic Programming?

No.
The optimal value function is a fixed point of the Bellman operator. Any fixed point solver can in theory find an (approximate) optimal value function. So why not use your own.
For example, you can just replace qe.compute_fixed_point in cell [6] with your routine.

I see your point.  Later I defined a function named 'iteration' to compute the fixed points for operators that are contraction mapping. Cell [6] is a part copied from Quant Econ to introduce the background of the problem.


SPIR-V Transpiler: Don't output indentation or newlines for release/debug builds

The SPIR-V transpiler outputs human-readable GLSL/SkSL, but for release/debug this is not necessary.

This is obsolete now as we've moved to precompiled shaders directly to a host language (SkSL, MSL for Impeller on iOS, et cetera).


Clarify whether to use alpha annotations

I was wondering if we should rather use alpha annotations while external-dns is still unstable?
Looking at other projects I think it makes to target alpha.external-dns.kubernetes.io for now so that we allow us to change them at any time if we discover they aren't suitable. I know that we discussed the desired annotations for quite some time but you never know if they really works out.

Let's decide this. I'd prefer to use
external-dns.alpha.kubernetes.io/controller
external-dns.alpha.kubernetes.io/hostname

for our initial release. This leaves us the possibility to tweak/change the names later on.

/cc @ideahitme

Yup, agree with having alpha annotation, naming seems fine with me


FileConfiguration fails to read configuration-file

Some test fails under Travis CI.
The program stalls and is terminated by Travis after 10min without output.
The TestConfigurationModes 5/5 (FileConfiguration) seems to be the cause of this problem.
Details can be seen here: https://travis-ci.org/doe300/OHMComm/jobs/79519412

FileConfiguration throws error on reading config-file.
The error-code is SUCCESS


Running on macos

Hi,
Trying to get this running locally.
I'm able to run the server (after having set my credentials):

But I get stuck with this loading behavior:

Console:

Wondering if anyone else has encountered this.

Hey @asselinpaul, it looks like Twitter might be returning something that Lucerne didn't expect. I'm suspecting some kind of an authentication issue given that all 3 API calls are failing, but can't say for certain. Could you check what responses you get in the Network tab of the devtools? Specifically in response to the API endpoints that are erroring out.
Feel free to email me if you'd rather not put personal data on GitHub issues -- linus at thesephist dot com

@thesephist was using a wrong ConsumerKey. thank you!
For future ref, "Terminology clarification" is useful here: https://developer.twitter.com/en/docs/authentication/oauth-1-0a/obtaining-user-access-tokens

Oh yeah, I remember getting confused myself too. They use different words for it in different places. Glad you got it figured out!


Add tests and improve error messages on Windows

Add Windows to the testing matrix, and exclude tests on Windows for Terminate on Timeout which is not supported on the platform.
Since Windows is a bit more supported now, add a more informative message for the exception.
Fixes #179

Thanks!


Fix your indentation

Hi ! I'm reading your js code from GitHub interface but since you are mixing tabs and spaces the code is not correctly indented. Please use spaces only :)

Hi, I'm aware of this, I use tabs to indent my code but it sometimes slips, thus the weird indentation you can see sometimes in the GitHub interface.


Script should only restart containers that had updated images pulled.

There's a line in this script that states: "Stop all of the running Docker containers." But what if the container's image hasn't actually been updated?
While this is a great and useful script, I think it should detect which images actually pulled new versions and only restart the containers that are affected.
No point in downtime if it's not necessary, right?

So, the problem is that you cannot actually pull or remove images that have running containers.
It's very hard to figure out what has updates without pulling (it would require coding an API client, which I think would be quite hard in Bash) and thus, everything is stopped.
A work-around, especially for people putting this in a cronjob, would be to add a feature that records what containers are running and restarts them as a final step...

If a tag has an update, you wouldn't be pulling the same image as what's already running.  I tend to perform this process manually like this:
docker image ls |grep -v REPOSITORY |awk '{print $1 ":" $2}' |grep -v "<none>" |xargs -L1 docker pull

docker-compose -f /srv/docker-compose.yml up -d

docker container prune && docker image prune


Chromium fails to login to Patreon via Gmail account

Tried to download a post from Patreon, but had an issue with login. My account on Patreon uses login via Gmail. Chromium instance launched by downloader was treated as suspicious by Google, and get This browser or app may not be secure.  error while trying to log in. It forbids logging totally. Despite it, desktop Chromium does Patreon login successfully.
Remote browser with manually logged session might be a solution here. I tried to setup it, but failed - downloader opens own instance of Chromium even with passed valid --remote-browser-address. Tried both Chromium and Chrome with enabled remote debug with the same negative result.
I use Ubuntu Focal. Compiled the tool using dotnet-6.0 SDK

#178


Support Redis password

Please support Redis simple password authentication.

Redis password is supported https://github.com/portertech/em-redis/blob/unified/lib/em-redis/redis_protocol.rb#L176 Reference documentation is on the way! https://trello.com/c/2aOw1Kf5/19-as-an-operator-i-would-like-redis-reference-documentation


IE10 compat: Use getAttribute instead of dataset

This makes the library compatible with IE10 (and possibly 9)

^_^, thanks~


Revisit documentation / clarification for subcommands #14

I have been playing around with the command aliasing feature and would like to take a crack at adding to the documentation. From what I can see this isn't a true sub-command structure but the potential for organizing commands with it is awesome.
This is what a sample help screen looks like:
bundle exec projman help
...
Commands:
  help ...

Aliases:
    project list project list
    project new  project new
    project show project show
    task add     task add
    task delete  task delete
    task update  task update

I appreciate any advice you have on this matter.
Thank you.

If you're interested in adding to the docs I would say take a shot at editing the section in the README — anything clarification you can add would be great!

I would like to reopen this. The project that spawned this request is working well. Just need to document it for some of my former colleagues. My pull request is failing the Travis integration and I need some help.
Thank you.


add:Aman-chauhan

Description
I have added my profile json to contribute in this project.
Changes Proposed
changes done in
\public\data\

## Checklist

- [ X ] I have read and followed the [Contribution Guidelines](https://github.com/shyamtawli/devFind/blob/master/CONTRIBUTING.md).

- [ X ] I have updated the documentation to reflect the changes I've made.
- [ X ] My code follows the code style of this project.
- [ X ] The title of my pull request is a short description of the requested changes.

@AmanChauhan29 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


Add callback to rest context

Summary
This PR adds the InteractionResponseCallback property to RestInteractionContext and introduces the interface IRestInteractionContext. This allows the process of writing the respond function much simpler, ex:

async Task WriteCallback(string payload)
{
    await response.OutputStream.WriteAsync(payload);
}

var context = new RestInteractionContext(client, interaction, WriteCallback);
await interactionService.ExecuteCommandAsync(context, services);
response.StatusCode = 200;
response.Close();

If no callback is passed into the ctor of RestInteractionContext then the default global callback is used, the callbacks are mutually exclusive.

cc: @Cenngo


[Playground][Task]: Deleting the Cloud Storage client

What needs to happen?
Need to use the Cloud Datastore instead of the Cloud Storage and remove unused code related to the storage
Issue Priority
Priority: 1
Issue Component
Component: beam-playground

.take-issue


Add elements/functions missing from 2.8 branch, which exist in 2.7 branch

Some functions are missing from the master/2.8 branch, but were available in 2.7
Some notes for OLUtil:
I deleted the already commented out getMinZoomLevel and getMaxZoomLevel functions as both are easily available by accessing the sources tile grid.
Being able to listen for map move and zoom events is important, but I simplified the addMapMoveListener function to always use the immediate feedback mode while moving not only at the end of the move (which was default for the function call without supplying the immediate mode parameter).

Thanks!


subscriptions: kick resub ddos protection

Fixes LAND-1527 by adding a library with a mechanism for us to delay resubscriptions by 30 seconds to ensure that we don't take up all CPU/event throughput of a ship when in a kick + resubscribe loop. This was added to only groups and channels, but could stand to be applied elsewhere.
PR Checklist

[X] Includes changes to desk files
[X] Describes how you tested the PR locally (test ship vs livenet)
[X] If a new feature, includes automated tests
[X] Comments added anywhere logic may be confusing without context

@Fang- added missing leave, but unsure how to test since we don't have a way to trigger an unsubscribe from a group we don't have yet so might need your help there.

I wouldn't be super concerned with testing that, in this case it's plainly visible from the code that we always emit a leave.
 That is, calling the +unsubscribe from the library with any argument, in any context, and seeing that a %leave gets sent despite the subscription not being in the provided state. You don't strictly need to go through an agent, when all you want to do is test library behavior.
I do still notice a lack of +unsubscribe calls in /app/channels.  Probably want to be consistent about doing every un/subscription through the library, even if the delay case isn't relevant for some particular ones.
Lastly I'd consider adding a little comment at the top of the file explaining that all subscriptions must be managed through the library. Or pointing that out at the /+ of it, or something similar. Just so contributors (internal ones too) are more likely to catch on.


Deployment fails with Cloud Run Error

Deployment fails with Cloud Run Error:
ERROR: (gcloud.run.deploy) Cloud Run error: Container failed to start. Failed to start and then listen on the port defined by the PORT environment variable. Logs for this revision might contain more information.

You should check log on Cloud Run, It can't start because something wrong on that service.

What do the Cloud Run logs show?

Logs do not have much additional info either. Here's what they look like:
starting build "ad0104cb-1585-4215-9776-7e69412c05ad"

FETCHSOURCE
BUILD
Pulling image: gcr.io/google.com/cloudsdktool/cloud-sdk:293.0.0-alpine

                   ***** NOTICE *****

Alternative official `docker` images, including multiple versions across
multiple platforms, are maintained by the Docker Team. For details, please
visit https://hub.docker.com/_/docker.

Creating Revision.................................................................................failed
Deployment failed
ERROR: (gcloud.run.deploy) Cloud Run error: Container failed to start. Failed to start and then listen on the port defined by the PORT environment variable. Logs for this revision might contain more information.
ERROR
ERROR: build step 0 "gcr.io/google.com/cloudsdktool/cloud-sdk:293.0.0-alpine" failed: step exited with non-zero status: 1

Hi @vbGoz those are the Cloud Build logs. To get the Cloud Run logs, go to Cloud Run in the console (find it in the sidebar or use the search box). Then click on your service (it should have a big red circle indicating it failed), then click on logs to view the logs.

@sethvargo Here's the error I see:
2020-07-04 18:05:34.957 PDTsetup.Setup: unable to connect to database: creating connection pool: failed to connect to `host=localhost user= database=`: dial error (dial tcp <IP_ADDRESS>:5432: connect: connection refused)

I found the confine.go file with the host and port configuration, but changing it didn't help:
2020-07-05 08:38:44.545 PDTsetup.Setup: unable to connect to database: creating connection pool: failed to connect to `host=<IP_ADDRESS> user= database=`: dial error (dial tcp <IP_ADDRESS>:8080: connect: connection refused)

2020-07-05 08:46:55.260 PDTsetup.Setup: unable to connect to database: creating connection pool: failed to connect to `host=<IP_ADDRESS> user= database=`: dial error (dial tcp <IP_ADDRESS>:5432: connect: connection refused)

Hi @vbGoz can you tell me more about how you're deploying? Did you use the Terraform configurations?

Yes, I used Terraform configurations.

Terraform has to do the first deployment to set those variables.

Thank you @sethvargo for your quick responses. I truly appreciate it.
I re-tried the terraform setup and followed the guide at:
https://github.com/google/exposure-notifications-server/tree/main/terraform
I see the following warning for the apply command:
$ terraform apply

Warning: Value for undeclared variable

The root module does not declare a variable named "project" but a value was
found in file "terraform.tfvars". To use this value, add a "variable" block to
the configuration.

Using a variables file to set an undeclared variable is deprecated and will
become an error in a future release. If you wish to provide certain "global"
settings to all configurations in your organization, use TF_VAR_...
environment variables to set these instead.

Warning: Value for undeclared variable

The root module does not declare a variable named "generate_cron_schedule" but
a value was found in file "terraform.tfvars". To use this value, add a
"variable" block to the configuration.

Using a variables file to set an undeclared variable is deprecated and will
become an error in a future release. If you wish to provide certain "global"
settings to all configurations in your organization, use TF_VAR_...
environment variables to set these instead.

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Are you sure you're inside the terraform/ directory on the latest pull? The module does define a variable named "project" and "generate_cron_schedule".

Thank you! My bad, I believe while trying to debug other issues. I overwrote some of the configs.
I did a fresh clone and re-ran the terraform instructions and apply fails with the following:
Error: Error waiting to create Connector: Error waiting for Creating Connector: Error code 7, message: Operation failed: Google APIs Service Agent<EMAIL_ADDRESS>needs editor role in the project.

I verified that<EMAIL_ADDRESS>already has an editor role for the project.

Can you share more of the Terraform output logs? Can you share a screenshot of your IAM console where the Service Agent has Editor permissions please?

https://drive.google.com/file/d/1mOIQsExVxcvCaV5-of7Qqps6Q5sJ0Tae/view?usp=sharing
https://drive.google.com/file/d/1IKyl3IBMQ0UO5_GtQ8Q7rUvC-BfitvtB/view?usp=sharing

Hmm. Do you have any organization policies or restrictions on your project (like VPC-SC, org policies, etc)?

No, I don't have the project connected to any org, it is under my personal google account.

Hmm I'm really not sure to be honest. I just tried again in a new project and it worked fine. You could try a new project, or revoke and re-add the permisisons:
gcloud projects add-iam-policy-binding project_id
  --member<EMAIL_ADDRESS>  --role roles/editor

I tried a new project but still ran into the same issue. It looks like my issue is exactly same as:
https://github.com/google/exposure-notifications-server/issues/639
I am trying vpc_access_connector_max_throughput default value as 300 now.

@sethvargo It worked with 300 value.


Alternative hash_to_scalar without an xof

First shot in a hash_to_scalar_xmd function to be used with regular hashes as an alternative to the one currently in the spec (that uses an xof). The proposed function essentially makes use of expand_message_xmd (not called directly, see below why), and will give a less efficient option for implementers not wishing to make use of shake256.
Comparison with hash_to_field and expand_message_xmd:

Memory efficiency: hash_to_field will call expand_message once to output the total number of bytes needed for all the outputted elements. Since we may potentially need to create many scalars, this may not be the more efficient approach. For example, if one wants to create a proof with 1000 hidden messages, the output of expand_message will need to be at least 64 kb. In contrast, hash_to_scalar_xmd will only need to “hold” 64 bytes at once. Note that the total number of hash invocations is the same in both cases, so the computational overhead will effectively be zero.
Efficiently checking if a scalar is 0: Although there are discussions on not overengineering the spec, I feel here is the one place we may need to have the check. The reason is that many signed messages may result to the probability of returning a 0 been higher than what we anticipate (not really an issue for bls12-381 but may become an issue for “smaller” ECs).
Calling expand_message_xmd directly instead of the xof would be wasteful (it would result to at least n-1 unnecessary hash computations for b_0)

Another option can be to use hkdf instead. The tradeoff here is double the hash computations vs spec simplicity + the wider availability of hkdf.

If the memory usage turns out to not be an issue the operation can be significantly simplified to something like,
result = hash_to_scalar_xmd(msg, n)

Procedure:

1. msg_hash= hash(msg || I2OSP(0, 1) || I2OSP(n, 8))

2. (scalar_1, ..., scalar_n) = hash_to_field(msg_hash, n)

3. if 0 in (scalar_1, ..., scalar_n):

4.     msg_hash = hash(msg_hash)

5.     go back to step 2

6. return (scalar_1, ..., scalar_n)

Updated to use the range(a, b) notation introduced to #155.

If the memory usage turns out to not be an issue the operation can be significantly simplified to something like,
result = hash_to_scalar_xmd(msg, n)

Procedure:

1. msg_hash= hash(msg || I2OSP(0, 1) || I2OSP(n, 8))

2. (scalar_1, ..., scalar_n) = hash_to_field(msg_hash, n)

3. if 0 in (scalar_1, ..., scalar_n):

4.     msg_hash = hash(msg_hash)

5.     go back to step 2

6. return (scalar_1, ..., scalar_n)

Looking again, I think this may be the better option. There's no actual requirement for the hash_to_field implementation to output all of the bytes before generating the scalars, in fact the bls12-381 implementation does it iteratively: https://github.com/zkcrypto/bls12_381/blob/34dab74ae44cd77dfa867928dd2e6c8383d8dc9d/src/hash_to_curve/mod.rs#L50
We could even use the same method for both XOF and XMD modes and eliminate the separate versions, short-circuiting and restarting if a zero scalar is found (which is unlikely anyway) by using a slightly modified version of hash_to_field.

Discussed on WG call, the current sentiment is to restructure the hash to scalar procedure to either use hash_to_field or expand_message to accomplish the same functionality but in a simpler manner. See above for the two proposals from @BasileiosKal and @andrewwhitehead respectively.

Discussed on WG call, resolved to move to the hash_to_field based approach suggested by @BasileiosKal, however a slightly modified procedure to use a counter instead of hash if a zero scalar value is encountered.
More generally it was also discussed that we should open a tracking issue to determine whether we want to support rejection sampling in general across the spec for procedures that involve generating scalars. There is guidance in the hash to curve draft that advises against this style of check (e.g checking that a generated scalar value is zero) so we may revise to line up with that guidance because the probability is so low.

After some more thought, a potentially annoying issue is that using hash_to_field will require defining 2 h2c ciphersuites, one for the xof and one for the xmd version of expand_message. The reason is that the h2c spec only defines suites where the field in hash_to_field is the base field of the EC itself and not the scalars mod r (that we need). This matters because we would then "mod" with the wrong prime (i.e.,  not r).
Any thoughts here?? @andrewwhitehead, @tplooker?? If not, I may move with Andrew’s proposal to avoid this issue.

@BasileiosKal  The H2C spec does say this..

The hash_to_field function is also suitable for securely hashing to scalars.  For example, when hashing to the scalar field for an elliptic curve (sub)group with prime order r, it suffices to instantiate hash_to_field with target field GF(r).

However, I'm not sure if we can guarantee that a particular H2C implementation has support for this operation.

After some more thought, a potentially annoying issue is that using hash_to_field will require defining 2 h2c ciphersuites, one for the xof and one for the xmd version of expand_message. The reason is that the h2c spec only defines suites where the field in hash_to_field is the base field of the EC itself and not the scalars mod r (that we need). This matters because we would then "mod" with the wrong prime (i.e., not r).

On the flip side would this not make the BBS signature ciphersuite definition simpler e.g just a single reference to h2c ciphersuite for all underlying operations?

However, I'm not sure if we can guarantee that a particular H2C implementation has support for this operation.

Yea those are my worries as well. We can define the "correct" field for hash-to-field but there are some implementations that don't support Fr (like blst. Other libs, like nodle-bls12-381 and the rust crate do support this though).

On the flip side would this not make the BBS signature ciphersuite definition simpler e.g just a single reference to h2c ciphersuite for all underlying operations?

That’s definitely true! However, as Andrew noted, an issue is that not all libraries have support for the operations we need.
Another issue is that we can't just define a different hash-to-field that mods r because we need the mod p to create the generators (i.e., for hash-to-curve). So this can be confusing to implementers (essentially we need two different versions of hash-to-field, one that mods p for create-generators and one that mods r for hash-to-scalar).

Ok! i gave a shot, based on @andrewwhitehead's proposal of using  expand-message. As most libraries have a mod r functionality, this would create the lowest implementation barrier + keep the spec simpler. I added a note saying that hash-to-scalar essentially calls hash-to-field for Fr, so if implementers have this available, they can just use that. Also made some updates in the ciphersuites. Thoughts??

Multiple reviews and approvals, discussed on multiple wg calls, merging.


Close Mentorship (endpoint, button handle)

Dependencies

#107

Feature Description
When a mentor/mentee clicks on the "Close Mentorship" button of #107, we want to have:

a confirmation message box dialog with user feedback (toast, button loading)
an API endpoint to close the mentorship, and remove it from the active ones (status -> closed)

I can take this one if no one is interested

this is ready to be reviewed


multi-role support

Hello,
I've started using this project and it's very helpful, thank you.
How do you feel about support for multiple roles per user? I think this is generally how RBAC works (for example these descriptions: https://auth0.com/docs/authorization/rbac#overlapping-role-assignments, https://searchsecurity.techtarget.com/definition/role-based-access-control-RBAC).
If a user can only have a single role the permissions for that role will need to be customized for that user which removes some of the benefit of RBAC (vs. just using user based access).
Are there plans to add support for this or would you be open to a PR that adds it?
Thanks!

Hi @bhainesva
Actually it's a good feature,
I will work on adding it next week, and let you know once it's ready.
Thanks.

hi @bhainesva
I just released v2.0.0, it supports multiple roles,
please have a look and let me know your feedback
thanks.

Took me a while to get to it but I've upgraded to the new version and it works great! Thanks for implementing so quickly!


Refer to other resources by reference instead of ID

TypeScript:
export interface MethodSettingsArgs {
...
  /**
     * ID of the REST API
     */
    restApi: pulumi.Input<string | RestApi>;
...
}

What we generate currently:
final case class MethodSettingsArgs private(
...
  restApi: Output[String],
...
)

Relevant schema:
          "restApi": {
            "type": "string",
            "oneOf": [
              {
                "type": "string"
              },
              {
                "type": "string",
                "$ref": "#/types/aws:apigateway%2FrestApi:RestApi"
              }
            ],
            "description": "ID of the REST API\n",
            "willReplaceOnChanges": true
          },

This might be related: https://github.com/pulumi/pulumi/issues/8412

How does it work? What is the definition of RestAPI resource?

this codegen log looks related:
Warning: Type URI #/types/aws:apigateway%2FrestApi:RestApi has no corresponding type definition - using its underlying type as fallback

I was able to get the correct type resolved, from this schema:
{
  "type": "string",
  "oneOf": [
    {
      "type": "string"
    },
    {
      "type": "string",
      "$ref": "#/types/aws:apigateway%2FrestApi:RestApi"
    }
  ],
  "willReplaceOnChanges": true
}

into String | besom.api.aws.apigateway.RestApi
but, there is another issue, the generated code has Args suffix:
[error] ./.out/codegen/aws/6.5.0/src/apigateway/AuthorizerArgs.scala:13:23
[error] Encoder for besom.internal.Output[scala.Predef.String | besom.api.aws.apigateway.RestApiArgs] was not found!
[error] ) derives besom.types.ArgsEncoder

Added to codegen in #332

Almost there:
=> Diff (- obtained, + expected)
-String | besom.api.aws.apigateway.RestApiArgs
+String | besom.api.aws.apigateway.RestApi


fix wrong image

Description

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Would you describe what is the issue you are trying to solve? The path for that image looks fine as it is without this PR, it shouldn't be relative Vite monorepo.

I'm just trying to fix the "image can't appear" error due to lack of directory writes. In this PR, /images/graph.png cannot appear the image. Because the image is in the directory /docs/images/graph.png.
BEFORE

AFTER

But the image is shown correctly in the docs: https://vitejs.dev/guide/features.html#async-chunk-loading-optimization
So I will close this now


[New game]: Classic Guess Who?

🎮 Game Request
A 2 player game, each player picks a character from a set of characters. They then turn the screen back and forth, typing questions that they wish to ask the other player. The first player to get the right character wins.
Point down the features
+1 point for a correct final guess, -1 point for an incorrect final guess
Select program in which you are contributing
No response
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Deegee13244 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hello @Deegee13244, Time's up!⏰
Sorry for closing your issue!
But it's more than a week since we haven't received anything from your side 😢 .
Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥
All the best! 🚀
Happy Hacking! 💗

Hey @Deegee13244 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Redundant code is generated when shifting integer types by constant

The following piece of code is a part of the hash function, which is important for the performance of hash table lookups:
@[NoInline]
def rotl32(v : UInt64)
  (v << 32) | (v >> 32)
end

Currently Crystal 1.3.2 with LLVM12 generates the following x86-64 instructions for it:
000000000002e7a0 <*rotl32<UInt64>:UInt64>:
   2e7a0:       b0 01                   mov    $0x1,%al
   2e7a2:       84 c0                   test   %al,%al
   2e7a4:       74 08                   je     2e7ae <*rotl32<UInt64>:UInt64+0xe>
   2e7a6:       48 c1 c7 20             rol    $0x20,%rdi
   2e7aa:       48 89 f8                mov    %rdi,%rax
   2e7ad:       c3                      ret
   2e7ae:       50                      push   %rax
   2e7af:       e8 00 00 00 00          call   2e7b4 <*rotl32<UInt64>:UInt64+0x14>

This looks like an unnecessary branch with a condition that is always false. Changing the source code to use .unsafe_shl and .unsafe_shr improves it:
@[NoInline]
def rotl32_unsafe(v : UInt64)
  (v.unsafe_shl(32)) | (v.unsafe_shr(32))
end

000000000002e800 <*rotl32_unsafe<UInt64>:UInt64>:
   2e800:       48 89 f8                mov    %rdi,%rax
   2e803:       48 c1 c0 20             rol    $0x20,%rax
   2e807:       c3                      ret

If a true rotation is involved, #12307 should take care of that. For other kinds of shifts (e.g. rotations not using all bits of an integer) there is probably nothing we could do that LLVM cannot figure out already.


Bluetooth doesn't work on Pi3

With SD image v0.5.9 the bluetooth device doesn't work. On the serial UART console I'm getting an error
[FAILED] Failed to start Configure Bluetooth Modems connected by UART.
See 'systemctl status hciuart.service' for details.

Issuing systemctl status hciuart.service reveals some problems on starting the service:
● hciuart.service - Configure Bluetooth Modems connected by UART
   Loaded: loaded (/lib/systemd/system/hciuart.service; enabled)
   Active: failed (Result: exit-code) since Sat 2016-05-14 15:09:49 UTC; 12s ago
  Process: 8357 ExecStart=/usr/bin/hciattach /dev/serial1 bcm43xx 921600 noflow - (code=exited, status=1/FAILURE)
 Main PID: 4457 (code=exited, status=0/SUCCESS)

May 14 15:09:49 black-pearl hciattach[8357]: Can't open serial port: No such file or directory
May 14 15:09:49 black-pearl hciattach[8357]: Can't initialize device: No such file or directory
May 14 15:09:49 black-pearl systemd[1]: hciuart.service: control process exited, code=exited status=1
May 14 15:09:49 black-pearl systemd[1]: Failed to start Configure Bluetooth Modems connected by UART.
May 14 15:09:49 black-pearl systemd[1]: Unit hciuart.service entered failed state.

The device /dev/serial1 doesn't exist, so the hciuart.service failed to start.
Possible solution: using device /dev/ttyAMA0 in /lib/systemd/system/hciuart.service seems to fix the problem. But we have to investigate if this is the best way, before using the fix.

@DieterReuter It does work for me when I run the integration tests. No failing bluetooth tests.

There is a change introduced in package "pi-bluetooth=0.1.1" which is incompatible with HypriotOS, this causes a failure on starting up the Bluetooth service. Package "pi-bluetooth=0.1.0" is not available any more, so all new builds will end up having an issue with BT.
I'm now testing a work around to fix this issue, so we can provide a working Bluetooth device until we get a better solution.


Adds Device.getDevices() for all Device

This improves upon the creation of MultiDevice in #2819 by moving the getDevices function to the main Device class. This can simplify the usage of something which is potentially a MultiDevice and make it easier to check for the presence of a MultiDevice.

Codecov Report
Attention: 1365 lines in your changes are missing coverage. Please review.

Comparison is base (bb5073f) 72.08% compared to head (e9f3425) 72.25%.
Report is 901 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2820      +/-   ##
============================================
+ Coverage     72.08%   72.25%   +0.16%
- Complexity     5126     7156    +2030
============================================
  Files           473      708     +235
  Lines         21970    31918    +9948
  Branches       2351     3315     +964
============================================
+ Hits          15838    23063    +7225
- Misses         4925     7279    +2354
- Partials       1207     1576     +369

Files
Coverage Δ

...ava/ai/djl/inference/streaming/StreamingBlock.java
100.00% <100.00%> (ø)

api/src/main/java/ai/djl/metric/Dimension.java
100.00% <100.00%> (ø)

api/src/main/java/ai/djl/metric/Unit.java
100.00% <100.00%> (ø)

api/src/main/java/ai/djl/modality/audio/Audio.java
100.00% <100.00%> (ø)

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

...ava/ai/djl/modality/cv/output/DetectedObjects.java
96.29% <100.00%> (+1.29%)
:arrow_up:

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <100.00%> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...i/djl/modality/cv/transform/RandomResizedCrop.java
94.11% <100.00%> (+5.22%)
:arrow_up:

... and 225 more

... and 379 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


list failed in linux ( Deserialization failed)

I have a pack that was created on windows, I wanted to check its content on my Ubuntu 20.04.
If I list I found my pack,
PACK                                                                       SNAPSHOTS SIZE
loose/ba54343841542c1964b6b4064dc19982861fb310                             1         -
windowspack                             1         0.057MiB

But if I want to list all snapshot I have :
./elfshaker list windowspack

But I get this error :
[ERROR (main) 5.469347ms]: *FATAL*: Deserialization failed, corrupt pack index: cannot deserialize Windows OS string on Unix

An idea to succeed in using a windows pack on linux ?

Because paths are represented differently on Windows and Linux, packs are not currently portable. We could theoretically support this (with limitations) with some effort. What is your use case? Our primary usecase is for binaries, which are not portable across operating systems anyway, so this limitation did not seem like a significant issue when we introduced it, but it sounds like something we may want to relax if this is important to you.

Sorry about the limitation. I can't promise a fix on any timescale, which might rule out elfshaker for your usecase for now. If anyone fancies trying to fix this, help would be appreciated.


Better cross runtime support

Description
This builds on efforts of #91 and intends to make the library work on browsers and Deno (possibly CFWorkers) by replacing as much dependencies as possible with equivalent Web APIs available on all platforms.
This is a major change which will break event and stream APIs as these are to be replaced by their Web API equivalents.
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Changes:

[x] Remove node APIs

[x] crypto -> SubtleCrypto
[x] stream -> Web Stream API
[x] events -> EventTarget
[x] make sure buffer is polyfilled on all platforms

[x] Replace Axios with Fetch API - Fetch is available on more platforms than XMLHTTPRequest
[x] Documentation for Deno usage
[x] Update tests for browsers
[x] Documentation for browser usage
[ ] Tests for Deno?

EDIT: will not support Bun.js at this time, too experimental at this moment.

events -> EventTarget

Maybe we could work on a custom implementation of EventEmitter? It seems quite simple and would probably be better compared to the verbosity & weirdness of the EventTarget API.

I now realize that this is going to cause massive merge conflicts with #93, but how bad could it be 😅

Haha there's already a quite big conflict due to 68cb841c0058ec5aac7b79b7736fdf57b825da3c (which was an inevitable change as we had lots of dead code laying around). I guess we could help but unfortunately he's working on a branch outside of the project.

I'm going quite out of the scope of this PR by doing so much TS conversion too, but I cannot write my new changes in TS without then also converting some of the other parts of the project to TS too.

I'm going quite out of the scope of this PR by doing so much TS conversion too, but I cannot write my new changes in TS without then also converting some of the other parts of the project to TS too.

At this point this probably supersedes @MasterOfBob777's PR.

I'm going quite out of the scope of this PR by doing so much TS conversion too, but I cannot write my new changes in TS without then also converting some of the other parts of the project to TS too.

At this point this probably supersedes @MasterOfBob777's PR.

There's no way I'm rewriting all the parsers to TS in this PR though, so there's still a lot of work to be done if we want the entire codebase to be TS, for now I've enabled allowJS in the tsconfig

Wow! This is very cool! As @Wykerd mentioned I do think my PR has its place, but I think it is probably best to wait until this PR is completed to avoid merge conflict hell.
I also just want to mention it might be better to compile for each platform separately with esbuild constants, instead of programmatically figuring out the runtime, as it increases bundle size by quite a bit if you include unnecessary code in their respective platforms (Also the exports field in package.json can also achieve a similar effect by swapping out modules by path.) Regardless this isn't a huge issue at the end of the day, because it would barely effect performance, as V8 and other engines should just realize those branches are impossible to reach and "remove" the check, and basically achieve the same thing.
Those are just my two cents though it might not be the right decision in this case.

Got basic browser example up and running 🎉

Wow! Astounding work here! It's only been 4 days and this PR is almost complete, really impressive @Wykerd 😆

Node 12 does not have EventTarget, should we support it? Guess I could polyfill it?

Node 12 does not have EventTarget, should we support it? Guess I could polyfill it?

Not sure if we should. Up until now only one person asked for Node12 support, so it might not be worth it at all.

Theres a bunch more APIs only available from Node 16 so I'll need to do some additional work in order to support them. Undici for example only implements fetch for node 16 and later.

The current LTS version of Node is v16, so might be able to get away with making it a requirement, otherwise I'll need to  write some fallback logic for older node versions.

Ah that's a bummer, I think the minimum should be v14. If that's too much work then we can make v16 a requirement for now.

I can polyfill EventTarget on older versions, and swap out undici for node-fetch but then the video downloading methods no longer work since node-fetch is not spec compliant and returns its streams as nodeReadable streams instead of web ReadableStream
I could offer two versions of the VideoInfo#download method, something like VideoInfo#downloadNode for use when you need to support versions of node earlier than v16?

Nope, don't waste your time on that. Let's stick with Node 16 for the moment.

Nope, don't waste your time on that. Let's stick with Node 16 for the moment.

I've added a way to provide a custom fetch implementation which should be a decent compromise. This way users may bring their own fetch on older node versions, or for proxying request.

See the old codebase, that was used to debug InnerTube requests, it would print every request's url and body if set to true.

Yes, but it doesn't do anything anymore since I rewrote the requests to use fetch. I could add it back?

Did a little testing with OAuth and LiveChat but none work correctly. It seems that EventTarget's CustomEvent is not available in Node yet.
See https://github.com/nodejs/node/issues/40678

Should probably do some more tests to make sure I'm not missing anything, but this should be ready to merge now.

This seems to return undefined in Node, which in turn throws an error when using UniversalCache:
https://github.com/LuanRT/YouTube.js/blob/79c6ca883554863220d026050a860ba7bbb99240/lib/utils/Cache.ts#L34-L35

Whoops that broke deno and browser again 🙃

I think Innertube#session.signIn() doesn't doesn't wait for authentication to finish.
Ex:
//...

// Triggers the auth event and asks the user to authorize the authentication.
await yt.session.signIn(undefined);

// This will return true even though authorization hasn't been granted yet.
// In fact, this should not be printed at all since the auth flow hasn't finished and any InnerTube call will inevitably fail.
console.log(yt.session.logged_in);

I think Innertube#session.signIn() doesn't doesn't wait for authentication to finish.
Ex:
//...

// Triggers the auth event and asks the user to authorize the authentication.
await yt.session.signIn(undefined);

// This will return true even though authorization hasn't been granted yet.
// In fact, this should not be printed at all since the auth flow hasn't finished and any InnerTube call will inevitably fail.
console.log(yt.session.logged_in);

It does not, it only waits until the first auth event is fired with the login code

Should I make it wait instead? Probably makes more sense if it does.

Should I make it wait instead? Probably makes more sense if it does.

Yup, not doing so would probably cause some confusion.

Just a few small comments I had. Nothing that seem like a huge issue, or a glaring bug, but since this a large PR I most definitely missed something, and frankly I don't have a large amount of experience with the library.

I do think there will be some small bugs that slipped through the cracks here and there, especially in the JS code. They should be easy to find once the project is completely migrated to TS.

Whoops assigned this to myself accidentally 🤣

I think this PR is ready to be merged now. Mind giving it a look @LuanRT ?

I don't see any other major bug, so merging now. Thanks @Wykerd!


Use of IDE-theia

Info:

Docker version ($ docker --version):
Laradock commit ($ git rev-parse HEAD):
System info (Mac, PC, Linux):
System info disto/version:

Issue:

i've added the ide-theia to the docker-compose up -d nginx mysql ide-theia memcached and it installs but when i try to acces to the port 3000 it doesnt work ...
Expected behavior:

i expect to use that ide with the laragon proyect
Reproduce:

Relevant Code:
// place a code sample here

port 3000 is container export port, but docker-compose mapping to host port 987.
check .env
IDE_THEIA_PORT=987


Add metrics for certificate expiry

Creating a Draft PR for testing in sandbox.

Coverage decreased (-0.09%) to 62.283% when pulling cca31de50f05809d3e2abb18057be1ef41ac8222 on mitchcail:mitchc/add_metrics_for_certificate_expiry into 82c347aa8020df2568a24d2e6a87082956a4947a on Netflix:master.


Create a 404 page for invalid URLs

Please create a 404 page for invalid URLs.
The page must centre align the FightPandemics logo.
The page must contain the link to redirect to Homepage and support email.
This must work on mobile and web both for all the invalid URLs

@ppagarawal is there a specific design for this?

There is but in Figma. Unfortunately, my laptop is in trouble now. @vikjoshi @Yu-Alexa-Zhao can either of you please help here?

Hi @ppagarawal, I couldn't find any design in Figma which is related to 404 page.  Maybe It is updating?

Thanks for raising this @OzkanAbdullahoglu Let me check this with @Yu-Alexa-Zhao and get back.

Any news on the design? @ppagarawal

Yes we have an updated design. Let me export to Zeplin in about an hour? Sorry about the delay.

Hi @nadinejuraschek , the desktop version of 404 page is here: https://zpl.io/bJJMeDK, the mobile version is here: https://zpl.io/bJJMeDK


Datepicker: datepicker is shown partially when inside a modal

Bug:
Datepicker is shown only partially when inside a modal
What are the steps to reproduce?

See, it is missing the last week of the month.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Google Chrome - Version 58.0.3029.110 (64-bit)

Duplicate of #4406

Not really I don't think @willshowell I'm running a version with https://github.com/angular/material2/pull/4696 in and it's still broken inside a modal.

@fxck I just ran that PR as is (4a47f89) and it seems to be working fine

Another thing is that it's fixed on the screen, so when you resize the view port, the dialog mooves to try to stay at the center, but the date picker seems to stick where it initially was:

After resizing:

@adaojunior @julianobrasil could you check against the master build? #4696 was merged after the beta-6 release.

@willshowell , it worked for me (it follows the dialog when the view port is resized ande the dialog tries to be centered). Also it popups in the most logical direction (upward if the component is near the bottom of the viewport, and downward if the input if near the top).

sounds like this has been fixed


RollwingWindow join processor backend bugs

Flux generation needs fixes as flux is reporting errors. Also need to fix misc bugs found during testing.

https://github.com/hortonworks/streamline/pull/1098 fixes this.


Add flag to handling standard ingress

This will be needed for GKE.

This is not needed any more since kubernetes.io/ingress-class is supported in official controllers.


Pydantic 2

Pydantic 2.0 is out (https://pypi.org/project/pydantic/)
At some point, we should migrate our codebase. @evo-bschiller @bertiqwerty

See PR #279


@sveltejs/package missing import in package.json.exports['.']?

Describe the bug
I started running into

Error: Failed to resolve entry for package "@sveltejs/package". The package may have incorrect main/module/exports specified in its package.json: No known conditions for "." specifier in "@sveltejs/package" package

Stacktrace
❯ packageEntryFailure node_modules/vite/dist/node/chunks/dep-df561101.js:28691:11
 ❯ resolvePackageEntry node_modules/vite/dist/node/chunks/dep-df561101.js:28686:9
 ❯ tryNodeResolve node_modules/vite/dist/node/chunks/dep-df561101.js:28419:20
 ❯ Context.resolveId node_modules/vite/dist/node/chunks/dep-df561101.js:28[18](https://github.com/janosh/elementari/actions/runs/5791065675/job/15695238618?pr=42#step:5:19)0:28
 ❯ Object.resolveId node_modules/vite/dist/node/chunks/dep-df561101.js:44207:64
 ❯ async file:/home/runner/work/elementari/elementari/node_modules/vite/dist/node/chunks/dep-df561101.js:65837:21
 ❯ async file:/home/runner/work/elementari/elementari/node_modules/vite/dist/node/chunks/dep-df561101.js:44852:[20](https://github.com/janosh/elementari/actions/runs/5791065675/job/15695238618?pr=42#step:5:21)
 ❯ addManuallyIncludedOptimizeDeps node_modules/vite/dist/node/chunks/dep-df561101.js:46034:31
 ❯ optimizeServerSsrDeps node_modules/vite/dist/node/chunks/dep-df561101.js:45638:5
 ❯ createDevSsrDepsOptimizer node_modules/vite/dist/node/chunks/dep-df561101.js:45556:[22](https://github.com/janosh/elementari/actions/runs/5791065675/job/15695238618?pr=42#step:5:23)

I'm no packaging expert but looking at
https://github.com/sveltejs/kit/blob/a6fe5fcb1c7258281b4bf53b94543272e6e6c6d8/packages/package/package.json#L44-L50
isn't that missing an "import": "./src/exports/index.js" or similar (going by kit exports).
https://github.com/sveltejs/kit/blob/a6fe5fcb1c7258281b4bf53b94543272e6e6c6d8/packages/kit/package.json#L75-L100
Reproduction
Tried but failed to repro on StackBlitz.
Logs
No response
System Info
System:
    OS: macOS 13.4
    CPU: (12) arm64 Apple M2 Max
    Memory: 4.25 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.5.0 - /opt/homebrew/bin/node
    npm: 9.8.0 - /opt/homebrew/bin/npm
    pnpm: 8.6.2 - /opt/homebrew/bin/pnpm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 115.0.5790.170
    Safari: 16.5
  npmPackages:
    @sveltejs/adapter-static: 2.0.3 => 2.0.3
    @sveltejs/kit: ^1.22.4 => 1.22.4
    @sveltejs/package: ^2.2.0 => 2.2.0
    svelte: 4.1.2 => 4.1.2
    vite: ^4.4.9 => 4.4.9

Severity
blocking all usage of SvelteKit
Additional Information
No response

moved the issue to vite-plugin-svelte.
It looks likevitefu adds @sveltejs/package and svelte2tsx to ssr.noExternal
 vite:vite-plugin-svelte extra config for dependencies generated by vitefu {
  optimizeDeps: {
    include: [
      '@sveltejs/package > chokidar',
      '@sveltejs/package > semver',
      '@sveltejs/package > svelte2tsx > dedent-js'
    ],
    exclude: []
  },
  ssr: {
    noExternal: [ '@sveltejs/package', 'svelte2tsx' ],
    external: [
      'chokidar',
      'kleur',
      'sade',
      'semver',
      'dedent-js',
      'pascal-case'
    ]
  }
}

and vite adds packages present in ssr.noExternal to optimizeDeps.include.
We may have to update some config or change the filter functions we use with vitefu to prevent these from showing up. I'm also a bit confused about some of the values in ssr.external.

If the error is coming from Vitest 0.34 specifically, it's likely because that version started to use ssr.external and ssr.noExternal, instead of deps.external and deps.inline, that's causing these errors. Vite's ssr configs are usually lazy, so setting these packages incorrectly is fine as long as you don't import it, but Vitest seems to made it eager (which I don't exactly think it's a bug there).
The PR fix sent is probably the simplest way to fix this though.

released fix in 2.4.5  please let us know if you still have this issue aftert updating

released fix in 2.4.5 please let us know if you still have this issue aftert updating

I'm having the same issue :
Failed to resolve entry for package "sveltekit-flash-message". The package may have incorrect main/module/exports specified in its package.json: No known conditions for "." specifier in "sveltekit-flash-message" package

Packages :
{
    "@sveltejs/kit": "1.25.1",
    "svelte": "4.2.1",
    "sveltekit-flash-message": "2.2.1",
    "vite": "4.4.10",
}


Implement mldonkey gui protocol

http://mldonkey.sourceforge.net/GuiProtocol
Mldonkey has well defined protocol for "core" and gui communication. An example would be sancho, quite decent desktop client for mldonkey. Consider to implement that protocol and etorrent will have good desktop gui for free.

This is not going to happen in the near future anyway. MLdonkey is a pretty archaic program and I'll rather build a new web interface on top of cowboy than trying to retrofit the old MLdonkey GUI protocol to match.


Fix in-cluster API discovery documentation

The documentation incorrectly describes the way that client libraries discover the Kubernetes API server. While the kubernetes.default.svc DNS is provided as a convenience, all of the officially supported API clients use environment variables to discover the address of the API server.
This change updates the documentation to reflect this.
Fixes kubernetes/kubernetes#112263
Signed-off-by: Oliver Gould<EMAIL_ADDRESS>

/wg api-expression
Tech review / feedback is welcome here.

What's the next step for this PR?
Shall we merge it as is or continue waiting for some tech LGTM?

@sftim @kbhawkey Are you happy with the changes?

Looks good to me.
/lgtm

@olix0r The gate is not happy with the change yet. Please try recommit this PR so that another test can be triggered?

Hello @olix0r , please can you recommit this PR so that another test can be triggered?

I can trigger a build for you @olix0r

Sorry about that. I've merged main into my branch.


Options to exclude maven classpath from gem-maven-plugin:exec

I got createprocess error=206 the filename or extension is too long when try to use gem-maven-plugin in javaee project. It's because we have very many dependencies and windows can't execute process with huge comand line.
For fix this problem I added options to exclude (exactly, it's named add project classpath) to AbstractJRubyMojo.
Example of usage:
			<plugin>
				<groupId>de.saumya.mojo</groupId>
				<artifactId>gem-maven-plugin</artifactId>
				<version>1.0.9-SNAPSHOT</version>
				<executions>
					<execution>
						<goals>
							<goal>exec</goal>
						</goals>
						<phase>generate-resources</phase>
						<configuration>
							<addProjectClasspath>false</addProjectClasspath>
							<skipGemInstall>true</skipGemInstall>
							<execArgs>${gem.home}\bin\compass compile
								${basedir}\src\main\sass
								--sass-dir ${basedir}\src\main\sass\
								--css-dir ${project.build.directory}\css</execArgs>
						</configuration>
					</execution>
				</executions>
				<dependencies>
					<dependency>
						<groupId>rubygems</groupId>
						<artifactId>compass</artifactId>
						<version>1.0.3</version>
						<type>gem</type>
					</dependency>
				</dependencies>
			</plugin>

The TorqueBox Project » jruby-maven-plugins #112 FAILURE
Looks like there's a problem with this pull request
(what's this?)

will look at this probably tomorrow - cloudbees sees a lot of timeouts on those integration tests.

I just check build and this BUILD SUCCESS on my local machine

thanx


Update features about DevOps - [closed]

In GitLab by @wknet123 on Feb 9, 2018, 02:31
Merges dev-gogs-integration -> dev

In GitLab by @wknet123 on Nov 13, 2019, 10:31
the coverage is  %   check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:31
the it is failed check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:31
closed


fix(select): patch #539 regression

@xvzc if you could review. I tested on my side and it works for #515.

Could you share your configuration?

I use no special config. I tried with
selection_modes = {
<EMAIL_ADDRESS>= "V", -- linewise
}

and
selection_modes = {}

@phgz So you wanna respect the selection_mode only when the mode is "v"?

@xvzc I think that makes sense, and in the default operator-pending mode. (if we can detect the yV case, we should prioritise the user's choice.)

@xvzc selection_mode is respected either if v or not in operator pending with forced-motion.

Lets say we have following configuration.
selection_modes = {
<EMAIL_ADDRESS>= "V", -- linewise
}

"vaf" selects "V-Line" mode, but should we select "V-block" mode when we "af? what do you guys think?

It is already the case.

@xvzc yeah, if it is something other than vaf it should respect the user's choice. And from my understanding this PR addresses this.

Let's fix 2 things:

is_normal_or_charwise_v then ret_value = selection_mode
before returning, if selection_mode == "n" then return "v"

I agree with this. Its way more intuitive.
if mode == "n" then
  return "v"
end

if mode == "v" then
  return selection_mode
end

Anyway, my bad, guys. I apologize.

We should also add some test cases. It's very easy

change scripts/minimal_init.lua to add selection_mode for one type of textobject.
In tests/select/python_spec.lua, add a line like this

run:equal_cmds("new_test_file.py", { row = 1, col = 10, cmds = { "dVil", "Vial", "cVil" } })

we need to add a new_test_file.py which contains a class, for example.

Let's fix 2 things:

is_normal_or_charwise_v then ret_value = selection_mode
before returning, if ret_value == "n" then return "v"

We can also simply if is_normal_or_charwise_v then return selection_mode end, since it will take user preference into account as well for the TSTextobjectSelect command.

I think in some weird cases the selection_mode value could be "n", so we need to add that logic before returning it.

Also, assigning a parameter to vim.fn.mode() function seems to be no longer working in nvim nightly. It just returns on character regardless of the existence of parameter

By the way, no worries about this. it was just a type warning. it's happening on nvim 0.10.0 but the fixed version will soon be released with neovim/neovim#26776

There seems to be something flaky in one test, but I think it's just a matter of rerunning the failed job (For an oscure reason, I can't see the button to rerun, maybe only "Collaborator" can).

Thanks a lot for your work! This is perfect :)

Thanks a lot for your work! This is perfect :)


Testing ci

a kickstart for #24

@bendichter
the tests are included in the package, this would allow for other projects to import any tests methods implemented here.
Can you take a look and say if that's what you had in mind, before I make a new release on pypi?

Actually I mean testing infrastructure should be in the package. For example, in SpikeExtractors, the code to generate a fake RecordingExtractor here should be importable. The tests themselves should not be.

/test back to root!


Update some node modules, add code formatting pre-commit hook

Update some node modules, add code formatting pre-commit hook, Run yarn install again and the pre-commit hook will be enabled: all code changes(except rust code) will be formatted automatically before you submit a git commit

BTW: do we need tslib? I can't see where it was used


Escaping variables so theyre not replaced by pseudo parameters

Hi,
I'm trying to setup a DataPipeline for exporting DynamoDB data to S3 using Cloudformation
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-datapipeline-pipeline.html#aws-resource-datapipeline-pipeline--examples
DataPipeline references other blocks of the DataPipeline configuration using the same token format as used by serverless-pseudo-parameters e.g. #{myOutputS3Loc} and therefore they are getting replaced with the Fn:Sub intrinsic function which is not desired behaviour.
Is there currently a way to escape the token so that the resulting cloudformation template still contains the token as #{myOutputS3Loc}?
Cheers,
Matt

Oh well that sucks 😅 I have to think about this one... 🤔

Op 2 okt. 2019 om 09:24 heeft vodlogic<EMAIL_ADDRESS>het volgende geschreven:

Hi,
I'm trying to setup a DataPipeline for exporting DynamoDB data to S3 using Cloudformation
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-datapipeline-pipeline.html#aws-resource-datapipeline-pipeline--examples
DataPipeline references other blocks of the DataPipeline configuration using the same token format as used by serverless-pseudo-parameters e.g. #{myOutputS3Loc} and therefore they are getting replaced with the Fn:Sub intrinsic function which is not desired behaviour.
Is there currently a way to escape the token so that the resulting cloudformation template still contains the token as #{myOutputS3Loc}?
Cheers,
Matt
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks Sander. One thought I had was to allow escaping using soomething like #\{myOutputS3Loc}. Any existing parameters such as #{AWS::AccountId} would be replaced with Fn::Sub as usual and then at the end of the process, any tokens matching #\{(.*)} could be replaced with #{$1}.
I've not checked the code to see if that is appropriate but just thought I'd share some general ideas

Yep, that could work I think

I’ve added a proposal in PR, would be grateful if you could review.
Thanks!

I just release 2.5.0, let me know if that works as expected :)

Closing, as all functionalities as provided by this plugin are now covered by the Framework (since v2.50.0)


feat(playground-test): created playground story

Related Ticket(s)
#8968
Description
Created a Playground Story containing a dropdown knob that is able to bring any component inside a Dotcom Shell wrapper with an optional ToC/horizontal ToC. This is in preparation for the component grid audit that is a follow up to this issue.
Since this is for internal use only, this might not need to be merged. However, we can also put this behind a feature flag instead.
Changelog
New

added Playground story to add every single component individually to be wrapped in Dotcom shell or ToC
added propSet parameters to a couple components in order for the stories to be imported properly

Getting an error when looking at the deploy preview undefined is not an object (evaluating 'storyParameters')

@ariellalgilmore Fixed it, I'm getting/saving the current story so whenever it refreshes it displays again without needing to choose it from the dropdown all over again, but forgot to set a default if there's nothing stored in localStorage at first, hence the error lol

@RichKummer I'll update the branch anyway, since to we'll need the most updated components to make sure the grid placement is right 👍

Percy picked up an odd issue where it looks like Card - pictogram is no longer interactive in this build. Tried this out in the Web components Storybook. If this wouldn't effect Card, I can approve it but the Pictogram version looks like it's effected for some reason.
https://user-images.githubusercontent.com/15643582/174390588-a2b67b5d-0e6a-4450-bfc4-a4800259699d.mov

Also there are some conflicts now that card-section-images has been deprecated

Dropping the Figma file here in case we update later.