Release a new os2 version

Tag a new release of https://github.com/rancher-sandbox/os2 from the latest changes including: https://github.com/rancher-sandbox/os2/issues/5, https://github.com/rancher-sandbox/os2/issues/2, https://github.com/rancher-sandbox/cOS-toolkit/issues/1104

New version released, BUT the chart image repository is wrong, currently fixing that. It is hardcoded, but should be tweakable because the build system already takes an image repo as input, and that is quite misleading

WIP in https://github.com/rancher-sandbox/os2/tree/chart. I'm adding also an integration test which deploys the generated chart and creates a machineregistration resource, so this shouldn't slip anymore. Besides, I've also moved the images to be used in the deployment to the framework ones - those are smaller and don't contain the full OS ( currently the OS images are used, which are including also kernels and initrd)

I'm still looking at adding the integration test. the chart we produce depends on rancher to be installed already so the test needs to install first.

New release: https://github.com/rancher-sandbox/os2/releases/tag/v0.1.0-alpha16


feat: Global Catch of Publisher ID to Store

🍰 Pullrequest

checks all routes for the presence of pid in the query
commits the pid to the store.
deletes the pid from query (not from the route)
store does not delete pid on logout

Issues

fixes #941

I consider it part of the task to clarify what followup tickets we need to handle things properly. This requires decisions regarding how to handle the pid in our application & how our elopage register process will look like. If this would be a strong blocker due to decision time, i'd recommend to keep the issue open and merge this.


Frontend

Added frontend for the menu page (and remaining home page changes)
Closes #23 #24

Worked on this with Brian over visual studios live share


Make jump forward/ backward and the playback speed configurable

Thank you so much for the plugin! Can we please make jump forward/backward and the playback speed configurable from the plugin settings?

Hi, I would like to understand the current limitation you have to provide the best outcome for both of us. Although adding a settings page is simple it comes at a cost which was can make things difficult to change later, but I'm for discussion.
The current available values for the playback speed are 0.8, 1.0, 1.25, 1.5, 1.75 and 2.0. According to my research most players have similar values. Also it doesn't make a huge difference if you listen in 1.4 or 1.5 in my opinion. Please share your thoughts on this.
Same for the skip, 10 seconds seems to be quite common, although players use  30s. The idea was if you want to skip 30s, click the button three times, but I can see why you want to modify the value.

I totally agree with the skip buttons. With regards to the play speed, I have seen many language learners who prefer to have play speed at more granular level since 0.8 is too slow. Also, at 0.8 speed, listeners often lose the original prosody of the speech. The other side of spectrum is also true. For many language learners, 1.25 is too fast. Hope you could consider these points in the next iteration.

Thanks for sharing some additional context. I just added 0.9 and 1.1 as possible playback speeds in v0.1.0. Not sure how long it will take to become available on the marketplace ... I guess we will find out.

The release didn't worked. I made the code change from my phone, but looks like making the release from my phone isn't straight forward. I'll look into tomorrow

Noted. Again thank you so much for this plugin! Additional play speed will tremendously help many language learners. Will check it back later.

Updated the plugin and confirmed the changes!


Ask before clearing the currently open file buffer in case text found

later discussed and removed.
Resolution:
User selects a part of text in editor section, they know that after selecting the command all those text should be replaced by example snippet. This is a common understanding in vscode extension


SmartBCH eth_getTransactionByHash method not returning values for v, r and s

A query to SmartBCH using eth_getTransactionByHash doesn't return value for ECDSA recovery id, ECDSA signature r or ECDSA signature s
Example:
curl --data '{"method":"eth_getTransactionByHash","params":["0xaea7d1fa62afefc4b0fb14bdf8ba4c96de45e5c29fdae8fd6b5dbb60ed450ea8"],"id":1,"jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST https://smartbch.fountainhead.cash/mainnet

returns:
{
  "jsonrpc":"2.0",
  "id":1,
  "result":{
    "blockHash":"0x2e5a25cf8601440a94b2ab3d50ceab91d2fca7e0bf14265c4099d118f4220a51",
    "blockNumber":"0xdeab4",
    "from":"0xe4123ad71b4626f2337d54cb315d91ada6ebb132",
    "gas":"0x249f0",
    "gasPrice":"0x3e63fa64",
    "hash":"0xaea7d1fa62afefc4b0fb14bdf8ba4c96de45e5c29fdae8fd6b5dbb60ed450ea8",
    "input":"0x152cf3afcd1a45850f11f5aa339230b4a58557996ef81bcea36b7ec900b725140a8054cf0000000000000000000000009120534ac90b36188711b410b70b3043051b9318c956b4c4f274ed22ff97fe24e15bc3356ae12e76000000000000000000000000000000000000000000000000000000000000000000000000000000006152f5ec",
    "nonce":"0x0",
    "to":"0x531deb2240bcbc89fe891fab2e85cf4ddc20eec9",
    "transactionIndex":"0x0",
    "value":"0x2d79883d2000",
    "v":null,
    "r":null,
    "s":null
  }
}

Values are returned as null.
This seems to be causing an issue with AtomicDEX as reported by @artemii235 in the following issue related to SmartBCH atomic swap:
https://github.com/KomodoPlatform/atomicDEX-API/issues/1063#issuecomment-931930767
It includes an example response from BSC.
eth_gettransactionbyhash docs:
https://eth.wiki/json-rpc/API#eth_gettransactionbyhash

Awesome, I've just tested it:
curl --data '{"method":"eth_getTransactionByHash","params":["0x91790092ef6f1a522a148b685ee8b380c1a418f09ed8b73d7b0723e08db95209"],"id":1,"jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST <IP_ADDRESS>:8545
{"jsonrpc":"2.0","id":1,"result":{"blockHash":"0x6890b74960bbf6a58f59d9a31bf58b6bc44d903739f896e6660c3049a69c8d3c","blockNumber":"0x47955","from":"0x7e5f130366643304f52444ef2f925c88316f6a45","gas":"0x3aabb7","gasPrice":"0x4190ab00","hash":"0x91790092ef6f1a522a148b685ee8b380c1a418f09ed8b73d7b0723e08db95209","input":"0xf305d71900000000000000000000000017f4fcf5b6e0a95d4ee331c8529041896a073f9b00000000000000000000000000000000000000001027e72f1f1281308800000000000000000000000000000000000000000000001027e72f1f12813088000000000000000000000000000000000000000000000000000000016345785d8a00000000000000000000000000007e5f130366643304f52444ef2f925c88316f6a4500000000000000000000000000000000000000000000000000000000611c46e6","nonce":"0x15","to":"0xa194133ed572d86fe27796f2feadbafc062cb9e0","transactionIndex":"0x0","value":"0x16345785d8a0000","v":"0x43","r":"0xe212e9c1cd63850f7a078ba44db2f0c6eeced061e4afd55ecb608a89c2f58152","s":"0x178f50e74514239900c87770fa1b84555e09dacc96f8b71ca9fd7351fd3da08c"}}

Does it have any effect on sync speed, I've hanged the host and used master so not sure about reason.
By the way is there any chance you join the developer channel on Telegram.

It should have no big effect on sync speed. I have joined the developers channel. Thanks for your feedbak @damascene


Make SSR optional

SSR is optional now.
Still enabled by default.
Can be disabled by setting ssr={false} on a component, or by not including the NodeJS supervisor inside the application.ex file.


Determine webhook path for createNodeModules via env variable

Fixes #1878
When using probot 13 beta i realized that it was totally unintuitive that setting the WEBHOOK_PATH had no effect on our bots.

I prefer the singular form WEBHOOK_PATH.
webhooksPath comes from the @probot/webhooks package.
Just for some background:
We use probot for our bots in combination with google cloud functions.  I upgraded to probot 13 and needed to set the webhook path. So i set it as environment variable WEBHOOK_PATH but the trigger was still /api/github/webhooks.
So I realized it is not picking up the path from the env variable.
So we used webhooksPath option. The PR makes it possible that probot picks up the webhooks path from the env variable.

@gr2m
Implemented as requested. ;)

if possible, can you avoid force-pushing to pull requests once reviews started? It makes it harder to keep track of progress. PRs can get messy as they need be, we will squash them at the end anyway

Sry regarding forced pushing. Kind of bad habit from creating PRs for nodejs.
When I am at home I will check again. I just want to be able to overwrite the webhookPath via env variable when using createNodeMiddleware.

I just want to be able to overwrite the webhookPath via env variable when using createNodeMiddleware.

maybe we should move reading that env variable into createNodeMiddleware?

@gr2m
I really invested now multiple hours on this, but your request is contradictive.
createProbot has the env option, where I need to pass WEBHOOK_PATH. So I would expect that that env would handle WEBHOOK_PATH properly. So it has to expose the knowledge somehow.
The only other solution I can propose is to make the state attribute of probot public and make it start with _ to indicate it is internal api and the api contract is not ensured.


curl TLS hangshake hangs with some URI when using fan network and VM

Required informationcurl
TLS hangshake hangs with some URI when using fan network and VM

Distribution:
Ubuntu 22.04.1 LTS

Storage backend in use:
Local dir

Issue description
I've discovered a strange situation that only occurs  when using a fan network and certain https URI's.
This command should not timeout.
curl -L -v https://raw.githubusercontent.com/getumbrel/umbrel/master/scripts/install

Trying <IP_ADDRESS>:443...
Connected to raw.githubusercontent.com (<IP_ADDRESS>) port 443 (#0)
ALPN, offering h2
ALPN, offering http/1.1
CAfile: /etc/ssl/certs/ca-certificates.crt
CApath: /etc/ssl/certs
TLSv1.0 (OUT), TLS header, Certificate Status (22):
TLSv1.3 (OUT), TLS handshake, Client hello (1):
SSL connection timeout
Closing connection 0
curl: (28) SSL connection timeout

Steps to reproduce

Create a new lxd cluster with defaults and a fan network
Launch a new VM lxc launch images:ubuntu/jammy/cloud debug --vm
install curl lxc exec debug -- apt install -y curl
curl will time out using this URI lxc exec debug -- curl -L -v https://raw.githubusercontent.com/getumbrel/umbrel/master/scripts/install

Attached output for lxc info
lxc.txt

Sounds like an MTU problem, what's the link mtu you're getting inside the containers?

Hello @stgraber thanks for the response. The MTU is 1500 I increased it to 2800 but it still hangs while handshaking.
Were you able to replicate this at all?

Other way around, the MTU in your containers should be lower than 1500 when using the fan. You can try 1400 which will be a bit too low but should work fine.

My mistake. setting the MTU to 1400  does solve the problem now.
What do you recommend for setting MTU for VM's that use fan? I can hack something together but I'd prefer a more top down way to set this if I could.

If you are using lxds dhcp server then it will broadcast the MTU setting from the network as part of the dhcp responses and the instances should configure themselves that way.

Thanks close the issue. I'll look into why the MTU is not being set properly later.  My cluster is kinda adhoc. I'm transitioning from using zerotier to fan which should make this easier to sort out. Appreciate the help and all the work @stgraber


Fix build_without_gradle.sh

Fixes #1481
Signed-off-by: Louis Leseur<EMAIL_ADDRESS>

I tested it, this patch works.

Thank you :+1:
Merged: 1b73eff3c95a3e1875f0db51a60179f3d282ea57


Abstract Logical space

Just as a reminder:
a good example to model logical space (in CityGML 2.0) in 3D cadastre has been publish and further developed since than by Ms Gozdz (without teh need of an Abstract Logical Space class/interface):
Gozdz, K., Pachelski, W., van Oosterom, P., and Coors, V.: The possibilities of using CityGML for 3D representation of buildings in the cadastre, In: van Oosterom, P. & Fendel, E. (Eds.): Proceedings 4th International Workshop on 3D Cadastres, 9-11 November 2014,Dubai,United Arab. Emirates, ISBN 978-87-92853-28-8, pp 339-361
https://www.coors-online.de/wp-content/uploads/2014/11/paper-3D-cadastre-gozdz.pdf
https://www.coors-online.de/wp-content/uploads/2014/11/presentation-3D-cadastre-Coors.pdf

https://www.fig.net/resources/publications/figpub/FIG_3DCad/FIG_3DCad-final.pdf
the book just summarizes the 2014 paper, a newer reference, but no new content.
see summary in chapter 5.2

In the web conference on 18 April 2019 we discussed that we will check the paper and use it as example for logical spaces.


Fix nvtx3 build export

Description
Fixes the following error:
CMake Error at /home/coder/rmm/build/conda/cuda-12.2/latest/rmm-targets.cmake:52 (set_target_properties):
  The link interface of target "rmm::rmm" contains:
    nvtx::nvtx3-cpp
  but the target was not found.  Possible reasons include:
    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.
Call Stack (most recent call first):
  /home/coder/rmm/build/conda/cuda-12.2/latest/rmm-config.cmake:75 (include)
  build/conda/cuda-12.2/release/cmake/CPM_0.38.5.cmake:243 (find_package)
  build/conda/cuda-12.2/release/cmake/CPM_0.38.5.cmake:303 (cpm_find_package)
  build/conda/cuda-12.2/release/_deps/rapids-cmake-src/rapids-cmake/cpm/find.cmake:189 (CPMFindPackage)
  build/conda/cuda-12.2/release/_deps/rapids-cmake-src/rapids-cmake/cpm/rmm.cmake:75 (rapids_cpm_find)
  cmake/thirdparty/get_rmm.cmake:20 (rapids_cpm_rmm)
  cmake/thirdparty/get_rmm.cmake:24 (find_and_configure_rmm)
  CMakeLists.txt:192 (include)

Checklist

[x] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The cmake-format.json is up to date with these changes.
[ ] I have added new files under rapids-cmake/

[ ] I have added include guards (include_guard(GLOBAL))
[ ] I have added the associated docs/ rst file and update the api.rst

I noticed we do this in RMM for spdlog, so maybe we should do that in rapids-cmake/cpm/spdlog.cmake instead?

I noticed we do this in RMM for spdlog, so maybe we should do that in rapids-cmake/cpm/spdlog.cmake instead?

There is an open issue to track that refactoring. https://github.com/rapidsai/rapids-cmake/pull/592 started down that path as part of the update to a newer spdlog version.

@trxcllnt I updated the PR to consistently use the name nvtx3 instead of NVTX3. Doing so makes the package logic consistent , and removes the need to do rapids_export_package(BUILD nvtx3 ${_RAPIDS_BUILD_EXPORT_SET} GLOBAL_TARGETS nvtx3-c nvtx3-cpp) as that is now properly done by rapids_cpm_find since it is given the corrected name.
Tested with a local rmm build tree and I see rmm the correct usage of the nvtx3 package in the rmm build tree.

/merge


Feature request: Add view count for clips and archive

Can Holodex have the same convenient view count info as on YouTube?
I'm not aware of the underlying Holodex nor HoloAPI implementation, so I can't guess how hard it can be adding that, but It'd be cool to have that eventually.
I have a user script that augments Holodex as I'd like. This script relies on YouTube Data API v3 and requires API token to run.

Our videos update too infrequently for accurate view count, although it is possible (and even quite accurate after the video 'cools down'). We also just aren't very much about those kinds of numbers.
Cool userscript though.


subcollections

Feature Request:
"subcollections" - or the ability to access other collections from within a collection.
Current Behavior:
Example - While editing entries in my "blogpost" collection, I can't access my "users" collection for author choices.
Expected Behavior:
The ability to access other collections from within a collection.

@JFingert the relation field does this, but is sadly undocumented. I gave a quick explanation in an issue comment recently: https://github.com/netlify/netlify-cms/issues/192#issuecomment-311133616
Hope it helps! Join us on Gitter if you have questions.


why not have alias_subject

a subject can be a class or any instance or simply a symbol
when it is a symbol it can be aliased
we are using symbols for subjects a lot, as we do not have AR models

I think this is a fairly uncommon setup, to share an ability file between different applications but specify the same permissions on objects that have different names... If you want to try implementing alias_subject, I'd be happy to consider it.


Update config.yml

Pull Request Test Coverage Report for Build #127

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build #126:
0.0%

Covered Lines:
111

Relevant Lines:
111

💛  - Coveralls


Add actionlint pre-commit hook

📚 Documentation preview 📚: https://ridgeplot--201.org.readthedocs.build/en/201/

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.02%. Comparing base (ce371c7) to head (c42550c).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   91.02%   91.02%
=======================================
  Files          10       10
  Lines         401      401
  Branches       70       70
=======================================
  Hits          365      365
  Misses         28       28
  Partials        8        8

Flag
Coverage Δ

combined-src
90.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


✨ Allow hiding from OpenAPI (and Swagger UI) Query, Cookie, Header, and Path parameters

Add parameter include_in_schema to partially address #1708 for subclasses of Param: Cookie, Header, Path and Query
Implements the Param portion of https://github.com/tiangolo/fastapi/issues/1708#issuecomment-663366079, relevant parts of code sample reproduced below:

from fastapi import FastAPI, Query

app = FastAPI()

@app.get("/")
def read_root(hidden_param: str = Query(None, include_in_schema=False)):
    if hidden_param:
        return {"Hello": "Master!"}
    else:
        return {"Hello": "World"}

Any idea when this will be merged, and what version it will be released with?

@jordantshaw no idea but I have updated the request with a code sample from the original issue. Hope that will speed up the review.

This is a useful PR for me, too.

Please merge this!! This is a super useful feature! 😊😊

hello, any updates on this? this will be a really helpful additiona feature 👍

@tiangolo  Any updates on when this will merged?  Looks like a lot of people would find this very helpful.

@tiangolo Ping? I would also be very delighted to see this feature :3

@tiangolo Any update for this, really helpful

Joining the gang, I would find this very useful too

Awesome, thank you @astraldawn! :coffee:
Thanks everyone for the discussion! :cake:
I updated a bit the tests and added source examples (and tests) for Python 3.10.
I was thinking that maybe it could make sense to support also body/form-data, but the implementation would be non-trivial, or it would have to be a per-route include_body_in_schema or something like that. But at the same time, I don't easily see a use case where hiding the entire body would be wanted without just hiding the entire route, so let's just have this for now and I'll see if anyone finds later a use case that would benefit from hiding the body before implementing that. 🤓
This is available in FastAPI version 0.73.0 (released in a couple of hours). 🎉

This is a fantastic feature addition—thank you for this! 🎉
I wanted to share an alternative approach I’ve used in a similar context where I needed to exclude certain fields from the OpenAPI schema for a cleaner API documentation. My use case involved building an OAuth2-like authentication schema where fields like grant_type and access_token are essential for internal processing but irrelevant for API consumers to see in the documentation.
Here’s the implementation I used, leveraging pydantic.json_schema.SkipJsonSchema:
`from pydantic import BaseModel, Field, root_validator
from pydantic.json_schema import SkipJsonSchema
class UserSignInSchema(BaseModel):
grant_type: SkipJsonSchema[GrantType] = GrantType.PASSWORD
access_token: SkipJsonSchema[str] = None
username: str = Field(..., alias="email")
password: str
@root_validator(pre=True)
def validate_fields(cls, values):
    grant_type = values.get('grant_type')

    if grant_type == GrantType.PASSWORD:
        values['access_token'] = 'Null'
    elif grant_type in (GrantType.GOOGLE, GrantType.FACEBOOK):
        values['username'] =<EMAIL_ADDRESS>        values['password'] = 'Null1234567'

    return values

`
In this approach, SkipJsonSchema ensures that fields like grant_type and access_token are excluded from the OpenAPI spec, allowing us to focus the documentation on the fields users need to interact with, like username and password.
I’m curious about how this compares to the include_in_schema parameter introduced here. Both approaches achieve field exclusion but might cater to slightly different needs. For instance, does include_in_schema offer better control in dynamically configurable scenarios, or are there limitations when using SkipJsonSchema?
Thank you again for this valuable addition—it’s going to make handling such use cases a lot more intuitive! 😊


Notes for using with Vercel adapter, plus an alternative solution

Here are some hopefully helpful notes if you are just getting started with this and using Vercel adapter...
Having a root +layout.js like:
export const prerender = true;

And a svelte.config.js like:
import adapter from '@sveltejs/adapter-vercel';
import htmlMinifierAdaptor from "sveltekit-html-minifier";

/** @type {import('@sveltejs/kit').Config} */
const config = {
	kit: {
		adapter: htmlMinifierAdaptor(adapter(), { pages: ".svelte-kit/output" }),
	}
};

export default config;

I was getting an error like:
[...]
.svelte-kit/output/server/index.js                                      92.07 kB

Run npm run preview to preview your production build locally.

> Using sveltekit-html-minifier, @sveltejs/adapter-vercel
  ✔ done
✓ built in 10.85s
node:fs:601
  handleErrorFromBinding(ctx);
  ^

Error: ENOENT: no such file or directory, open '.svelte-kit/output/index.html'

So, I changed the config to:
import adapter from '@sveltejs/adapter-vercel';
import htmlMinifierAdaptor from "sveltekit-html-minifier";

/** @type {import('@sveltejs/kit').Config} */
const config = {
	kit: {
		adapter: htmlMinifierAdaptor(adapter(), { pages: ".svelte-kit/output/prerendered/pages" }),
	}
};

export default config;

Notice svelte-kit/output/prerendered/pages vs what I tried originally .svelte-kit/output.
This made it work; just thought I'd share if it helps anyone else using Vercel adapter.
Also note I learned you have to be using export const prerender = true; or else there is nothing to minify during "prerender".
Furthermore, I found this alternate method working using the html-minifier package directly in ./src/hooks.server.ts:
// ./src/hooks.server.ts
import { i18n } from '$lib/i18n';
import { minify } from 'html-minifier';
import { building } from '$app/environment';
import { sequence } from '@sveltejs/kit/hooks';

const minification_options = {
	collapseBooleanAttributes: true,
	collapseWhitespace: true,
	conservativeCollapse: true,
	decodeEntities: true,
	html5: true,
	ignoreCustomComments: [/^#/],
	minifyCSS: true,
	minifyJS: true,
	removeAttributeQuotes: true,
	removeComments: false, // some hydration code needs comments, so leave them in
	removeOptionalTags: true,
	removeRedundantAttributes: true,
	removeScriptTypeAttributes: true,
	removeStyleLinkTypeAttributes: true,
	sortAttributes: true,
	sortClassName: true
};

/** @type {import('@sveltejs/kit').Handle} */
async function minify_handle({ event, resolve }) {
	let page = '';

	return resolve(event, {
		transformPageChunk: ({ html, done }) => {
			page += html;
			if (done) {
				return building ? minify(page, minification_options) : page;
			}
		}
	});
}

export const handle = sequence(i18n.handle(), minify_handle);

I think using this adapter plugin is a bit more elegant than that however.
Just sharing if it helps anyone, so feel free to make it a closed issue; and thanks for sharing this adapter adapter.

Here are some hopefully helpful notes if you are just getting started with this and using Vercel adapter...
Having a root +layout.js like:
export const prerender = true;

And a svelte.config.js like:
import adapter from '@sveltejs/adapter-vercel';
import htmlMinifierAdaptor from "sveltekit-html-minifier";

/** @type {import('@sveltejs/kit').Config} */
const config = {
	kit: {
		adapter: htmlMinifierAdaptor(adapter(), { pages: ".svelte-kit/output" }),
	}
};

export default config;

I was getting an error like:
[...]
.svelte-kit/output/server/index.js                                      92.07 kB

Run npm run preview to preview your production build locally.

> Using sveltekit-html-minifier, @sveltejs/adapter-vercel
  ✔ done
✓ built in 10.85s
node:fs:601
  handleErrorFromBinding(ctx);
  ^

Error: ENOENT: no such file or directory, open '.svelte-kit/output/index.html'

So, I changed the config to:
import adapter from '@sveltejs/adapter-vercel';
import htmlMinifierAdaptor from "sveltekit-html-minifier";

/** @type {import('@sveltejs/kit').Config} */
const config = {
	kit: {
		adapter: htmlMinifierAdaptor(adapter(), { pages: ".svelte-kit/output/prerendered/pages" }),
	}
};

export default config;

Notice svelte-kit/output/prerendered/pages vs what I tried originally .svelte-kit/output.
This made it work; just thought I'd share if it helps anyone else using Vercel adapter.
Also note I learned you have to be using export const prerender = true; or else there is nothing to minify during "prerender".
Furthermore, I found this alternate method working using the html-minifier package directly in ./src/hooks.server.ts:
// ./src/hooks.server.ts
import { i18n } from '$lib/i18n';
import { minify } from 'html-minifier';
import { building } from '$app/environment';
import { sequence } from '@sveltejs/kit/hooks';

const minification_options = {
	collapseBooleanAttributes: true,
	collapseWhitespace: true,
	conservativeCollapse: true,
	decodeEntities: true,
	html5: true,
	ignoreCustomComments: [/^#/],
	minifyCSS: true,
	minifyJS: true,
	removeAttributeQuotes: true,
	removeComments: false, // some hydration code needs comments, so leave them in
	removeOptionalTags: true,
	removeRedundantAttributes: true,
	removeScriptTypeAttributes: true,
	removeStyleLinkTypeAttributes: true,
	sortAttributes: true,
	sortClassName: true
};

/** @type {import('@sveltejs/kit').Handle} */
async function minify_handle({ event, resolve }) {
	let page = '';

	return resolve(event, {
		transformPageChunk: ({ html, done }) => {
			page += html;
			if (done) {
				return building ? minify(page, minification_options) : page;
			}
		}
	});
}

export const handle = sequence(i18n.handle(), minify_handle);

I think using this adapter plugin is a bit more elegant than that however.
Just sharing if it helps anyone, so feel free to make it a closed issue; and thanks for sharing this adapter adapter.

Thank you for sharing. The adaptor is only work with prerender because it will minify the rendered HTML page.
If The prerender is false It will render during the SSR response the hooks way should be correct.


'editor.action.showHover'-window doesn't disapear pressing ESC

Type: Bug
(without any extensions active)

bind 'editor.action.showHover' to a key
go over a function call (for example) and press that key
then when the info window has popped up press ESC

I would expect the info window to vanish as it did in the previous version.
But it doesn't.
I have the hunch that in the previous version the popping up info window also gets the focus and that this is not happening anymore.  Because if I press the "editor.action.showHover"-key an other time  the info window seems to get the focus and the ESC works.
VS Code version: Code 1.96.2 (fabdb6a30b49f79a7aba0f2ad9df9b399473380f, 2024-12-19T10:22:47.216Z)
OS version: Linux x64 6.11.11-1-MANJARO
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10870H CPU @ 2.20GHz (16 x 3499)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_offwebnn: disabled_off

Load (avg)
0, 0, 0

Memory (System)
15.49GB (8.71GB free)

Process Argv
. --crash-reporter-id 530147e1-ac5a-4d1d-b6e0-d4f14e09761e

Screen Reader
no

VM
0%

DESKTOP_SESSION
i3

XDG_CURRENT_DESKTOP
i3

XDG_SESSION_DESKTOP
i3

XDG_SESSION_TYPE
x11

/duplicate of #235979 that will be fixed in the next release.
pinging @aiday-mar


[HUDI-6550] Add Hadoop conf to HiveConf for HiveSyncConfig

Change Logs

Create new HiveConf object every time when initializing HiveSyncConfig and add hadoopConf as resource
We have to load Hadoop conf otherwise properties like --conf spark.hadoop.hive.metastore.client.factory.class=com.amazonaws.glue.catalog.metastore.AWSGlueDataCatalogHiveClientFactory won't be able to passed via Spark Hudi job. This issue was introduced another PR to address the OOM issue changed it: https://github.com/apache/hudi/pull/8050

To address the OOM problem we can create a new HiveConf every time instead of casting hadoop conf to hive conf. So we don't keep references to old hadoop conf.
Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Hi @xushiyan, I noticed the casting from hadoopConf to hiveConf was introduced by this PR from you(https://github.com/apache/hudi/pull/6202) but I couldn't find any context. Could you help me learn why we made that change?
HiveConf hiveConf = hadoopConf instanceof HiveConf
        ? (HiveConf) hadoopConf : new HiveConf(hadoopConf, HiveConf.class);

Hi @xushiyan, I noticed the casting from hadoopConf to hiveConf was introduced by this PR from you(#6202) but I couldn't find any context. Could you help me learn why we made that change?
HiveConf hiveConf = hadoopConf instanceof HiveConf
        ? (HiveConf) hadoopConf : new HiveConf(hadoopConf, HiveConf.class);

hey @CTTY it's probably meant for being fully compatible with the original code, as it was done for refactoring.

@CTTY will you be able to test and verify the change before we land it? it's a blocker for 0.14.0

Hey @xushiyan, I've tested this fix manually with EMR Serverless and it works fine

Hi @xushiyan , regarding the Azure CI failure, I was able to reproduce locally but haven't got a chance to root cause it.
Issue:
org.apache.hudi.hive.HoodieHiveSyncException: Failed to get the last replicated time from the table bar
	at org.apache.hudi.hive.HoodieHiveSyncClient.getLastReplicatedTime(HoodieHiveSyncClient.java:305)
	at org.apache.hudi.hive.replication.GlobalHiveSyncTool.getLastReplicatedTimeStampMap(GlobalHiveSyncTool.java:64)
	at org.apache.hudi.hive.replication.ReplicationStateSync.<init>(ReplicationStateSync.java:37)
	at org.apache.hudi.hive.replication.HiveSyncGlobalCommitTool.getReplicatedState(HiveSyncGlobalCommitTool.java:51)
	at org.apache.hudi.hive.replication.HiveSyncGlobalCommitTool.<init>(HiveSyncGlobalCommitTool.java:100)
	at org.apache.hudi.hive.replication.TestHiveSyncGlobalCommitTool.testHiveConfigShouldMatchClusterConf(TestHiveSyncGlobalCommitTool.java:113)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

The issue above only show up when using new HiveConf(hadoopConf, HiveConf.class). When it's reverted it to HiveConf hiveConf = new HiveConf(); hiveConf.addResource(hadoopConf); it works fine
I think we should proceed with the first version of change if the order of loading hadoop conf doesn't break any Hudi components

The issue above only show up when using new HiveConf(hadoopConf, HiveConf.class). When it's reverted it to HiveConf hiveConf = new HiveConf(); hiveConf.addResource(hadoopConf); it works fine

@CTTY ok the order of loading resources makes a difference: 1st approach first adds hadoopConf then overrides whatever from hive-specific confs, 2nd approach does the opposite. In our case, we want to respect user-provided hadoopConf so we should add the resource after HiveConf initializes. I'll rebase master as the CI seemed not running for your last push.

@danny0405 do you have other input?

@danny0405 do you have other input?

Fine with it, it should not have resource reference leak like before right?

Fine with it, it should not have resource reference leak like before right?
No, it won't have OOM issue since it'd create new HiveConf instance every time it's invoked instead of casting from hadoopConf


Convert configs to no longer refer to unavailable stats

rating_inputs.json and all radar/*.json files are affected

Resolved by 40bffdb


CIFAR10 model trained in Keras error using BasicIterativeMethod

Describe the bug
tensorflow.python.framework.errors_impl.InternalError: Invalid loop structure: Mismatched parent frames for "while/while_context": "while/while_context" vs "". The node giving this error: {{node while/gradients/while/model/batch_normalization/cond/FusedBatchNorm_1_grad/FusedBatchNormGrad/Enter}}This is an internal bug, please file a bug report with instructions on how to reproduce the error.
I assume it is related to batch_norm, where the implementation is the same the following,
https://github.com/geifmany/cifar-vgg/blob/master/cifar10vgg.py
And I use the KerasModelWrapper to wrap the Keras sequential model.
P.S  I find cleverhans works to generate adversaries for FGSM, deepfool, but the same error occurs for both BasicIterativeMethod and JSMA
My tensorflow version is 1.11.0 and cleverhans version is 3.0.1

Duplicate of #874
Unfortunately we have not had success with having the underlying TF bug fixed so far. This problem may disappear with TF2 though


running application does not open a browser window automatically

During DX testings, we found that when running the application, no matter mvn or running the Application class inside IDE, it doesn't open a browser window for me, which is the default behavior for other Vaadin applications, e.g. an application downloaded from start.vaadin.com

The solution is to use LaunchUtil.launchBrowserInDevelopmentMode(SpringApplication.run(Application.class, args)); in Application.main(), but it would require dependency to
         <dependency>
            <groupId>org.vaadin.artur</groupId>
            <artifactId>a-vaadin-helper</artifactId>
            <version>1.5.0</version>
        </dependency>

Since it doesn't bring too much value, close it as won't fix for now.


CORS Enabled by default since 2.2.2.RELEASE due to Changes in Spring Webflux 2.2.3.RELEASE

Describe the bug
CORS enabled by default in Spring-Cloud-Gateway since 2.2.2.RELEASE due to dependency upgrade in spring framework 2.2.4 (>2.2.3), due to changes   for issues #24327
Sample
It should be OPTIONAL to let either Spring-Cloud-Gateway or downstream application to handle CORS preflight request.

This was a change in the Spring Framework. Although the comment says "does not change how Spring MVC or WebFlux process CORS request" it does appear to change the code path. I think you need to open this with Spring Framework team. It looks like a non bwc change.


feat(ingest/cassandra): Add support for Cassandra as a source

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Things to confirm:

Platform Instance is supported, and is included when generating keyspace (container) AND table (dataset) URNs
Make sure that UDT column types are correctly flattened and supported
Make sure the column type mapping matches the following

Cassandra Data Type
DataHub Data Type

ascii
StringType

bigint
NumberType

blob
BytesType

boolean
BooleanType

counter
NumberType

date
DateType

decimal
NumberType

double
NumberType

float
NumberType

inet
StringType

int
NumberType

list
ArrayType

map
MapType

set
ArrayType

smallint
NumberType

text
StringType

time
TimeType

timestamp
DateType

timeuuid
StringType

tinyint
NumberType

tuple
ArrayType

uuid
StringType

varchar
StringType

varint
NumberType

frozen<map<text, text>>
MapType

frozen<list>
ArrayType

frozen<set>
ArrayType

Views & Tables should have the same aspects

Data Platform Instance
Sub Types
Dataset Properties
Container
Browse Paths V2

And
Views have

View Properties

Also please make sure error handling is clear. And try-excepts are around areas where we need. This connector should only fail in known cases. We should not have ANY uncaught exceptions!


scope of token contract includes pricing, file management and a name system?

The scope of token contracts that I'm familiar with doesn't include setting prices. Prices are set elsewhere... in an auction, or an exchange, etc.
In fact, the way this contract is arranged seems to preclude things like auctioning off NFTs.

NFT (non-fungible token) in the way I see it, is a bag with "quantity": 1, "n": "silver" and with no other bag referring to the same tokenId "silver", if you have those 2 conditions you will never ever have another "silver" coin in this contract, there is only one that can be sold/sent, but cannot be divided, or cloned. It is non-fungible (isn't it ?)
Auctioning is not available at the moment, even the "SET_PRICE" for a bag is not coded, I don't see anything preventing auctioning mechanism. You would put you bag in a "auctions" object, and then purses come in, at some point, the one with highest balance is emptied, and the bag changes ownership, other purses are refunded of course.

Can that sort of NFT be owned by another contract?
If you just use an ERTP style Mint to make the NFTs (#2), then it can. And auctions contracts compose straightforwardly.
The RChain MakeMint contract doesn't have flexible AmountMath, but that's a straightforward enhancement.
The NFT in this contract is not just a bag, but a bag paired with a public key; i.e. a bag plus an access control list. But ACLs don't.

No, a bag (can be NFT or FT) cannot be owner by a contract because the mechanism of authentication is signature-based and not unforgeableName-based. This means that the rchain-token contract verifies signature before allowing an operation to be executed, signatures is generated from payload + unique nonce and must match a public key, it can only be issued by off-chain agents (expect if you let a contract managing a private key).
Right now I'm working on fixing version 4, and will use it for various things in dappy, I do think dropping signatures in the favor of unforgeable names for authentication is the way to go (simpler), if we make sure that it does not open attack vectors that are non-existent with the current implementation.
Note 1: rchain-token has an advantage, which is the ability to dump all bags/data off-chain redeploy them, and have the ownerships still 100% preserved. (no unforgeable name to authenticate)
Note 2: I principally developped rchain-token to address in a single codebase/protocol the needs for different components of dappy: files managment and name system. I noticed that a general purpose contract could be made out of it, it may have some capabilities that MakeMint does not have, and the other way around also.

dump/restore is definitely a challenge for unforgeable-name / ocap strategies. If that's a requirement, it wasn't explicit until now, AFAIK. Perhaps a benefit of this discussion was discovering it. Perhaps you want to document it more explicitly in the README or a code comment?

if the scope is file management and a name system, I suggest you reconsider the name "rchain-token"... or at least replace the 1st sentence of the readme: "Fungibles and non-fungibles tokens on the RChain blockchain."

Another challenge, let's say you have 100 tokens.
If ownership is expressed by the capability of generating a user-specific unforgeable name (like rho:rchain:deployerId in locker, I don't know about MakeMint), is it possible to send 50 tokens to some agent without requiring any action/deploy from this agent ?
It is possible with the current rchain-token architecture, simply create another bag with 50 tokens in it, and set .publicKey to someone else's: you don't own those 50 tokens anymore. This is what SEND_TOKENS does.

Sending ERTP style tokens does, in general, require that someone has deployed something to receive the tokens. But just like the .rho contracts here are deployed before anyone interacts with them, it's straightforward to deploy a sort of "post office" contract where anyone can send tokens to the post office and say "give these only to the party with public key XYZ".
Or people can use "mailbox" contracts in the registry a la inbox.rho in https://github.com/rchain-community/liquid-democracy/ .
There are other ways for the parties to rendezvous; in general, either of them may be another smart contract... an auction, or a covered call, or ...

... I don't know about MakeMint

It's one page of code (in a traditional language such as JS; .rho is so verbose that it's longer there). It's much simpler than the cryptographic stuff going on in these .rho contracts.
Please, before we continue this conversation any further, watch the 8 minutes from to 25:00 33:00 in Agoric + Protocol Labs // Higher-order Smart Contracts across Chains. Tell me the 1st line of code presented there or the 1st second of video that is not entirely clear.
Alternatively, look at the original "Simple Money" section of From Objects to Capabilities . Let me know the 1st word that is not entirely clear.

Ok thanks I looked at the agoric presentation, I got it, you either possess an object/purse identifiable by the issuer (MakeMint for example) or you don't.
I will in fact need offchain dump/redeploy for what I want to do with this repo (but it is just for the #files branch). I'll fix release 4.0 on #master + #files that I both use, and work on understanding MakeMint, and if it can cover the usecases, eventually remove crypto and maybe just work on a ocap branch.

Discussion above addressed #3 and made progress on #2; what remains of this issue, for me, is the difference in scope between

what's implied by the name rchain-token and stated in the 1st sentence of the README  "Fungibles and non-fungibles tokens on the RChain blockchain" on one hand vs.
the actual functionality of the contract and @fabcotech 's clarification that the contract was principally developed to fill a need for file management and a name system.

dump/restore is definitely a challenge for unforgeable-name / ocap strategies.

@fabcotech , discussion with @tgrospic of the PoS upgrade and https://github.com/rchain/rchain/issues/2956 reminded me that the dump/restore challenge has a long history in the ocap community:

upgrade: Live fast, die young and leave a good-looking corpse
Persistence and Upgrade

In https://github.com/rchain-community/rstake/issues/7 I learned @leithaus discussed upgrade in a presentation:

Biologically inspired consensus Apr 2018


After build, it occur: Cannot read property 'state' of undefined

My apps hased use vuex, and it can run it the development environment.

This is my code which use vux $store.
<script lang="ts">
import { ref, computed, getCurrentInstance } from 'vue'
import Card from './Card.vue'
export default {
  name: 'Main',
  components: {
    Card
  },
  setup(props) {
    const instance: any = getCurrentInstance()
    const ctx = instance.ctx
    const selectedDate = computed(() => ctx.$store.state.selectedDate)
    return {
      selectedDate
    }
  }
}
</script>

And I don't know if I wrote it wrong.

Hi,
For working vuex and vue-router...
You can refer to example below. It is using next version of vuex for use with vue 3
https://github.com/ais-one/vue-crud-x/tree/develop/example-app/web/vite
Take note of versioning (you can refer to package.json). I am using vite 0.14.4 for now

Why people already using the internal instance and the ctx? This is so wrong. If you are using the composition API, use provide/inject. Avoid getCurrentInstance() in any possible. It's only meant for libraries.

Closing because vuex@next is verified to be working with current release of Vite. Please make sure you are using the correct version of vuex and following the correct usage: https://github.com/vuejs/vuex/tree/4.0


feat: add data and into_data

adds back previous Memory data functions:
https://github.com/bluealloy/revm/pull/516/files
I don't fully understand if this is correct. idk what a context is or how the shared memory is laid out.
In reth inspectors we need to get the currently active memory, and I'm not sure this is still accurate:
https://github.com/paradigmxyz/reth/blob/9dd270e4e8095a4cab1d2118f8f965eec68f4db7/crates/revm/revm-inspectors/src/tracing/types.rs#L536-L537

This is not oka. .context_memory() should be used to fetch current call memory frame

but this is exactly what this did?
and context_memory is private

but this is exactly what this did?
and context_memory is private

I didn't see that context_memory is not public, it should be.
into_data would still copy the context_memory with split_off, and using into_data for consuming shared memory for its last context and disregarding previous ones could introduce footguns.

into_data would still copy the context_memory with split_off, and using into_data for consuming shared memory for its last context and disregarding previous ones could introduce footguns.

I see, yeah, makes sense, we need to clone that during tracing anyway,
will open another pr that makes context_memory pub then

into_data would still copy the context_memory with split_off, and using into_data for consuming shared memory for its last context and disregarding previous ones could introduce footguns.

I see, yeah, makes sense, we need to clone that during tracing anyway, will open another pr that makes context_memory pub then

Sorry if i closed this abruptly, you can make the change here or a new PR sounds okay.


[QUESTION] Automatically Insert new Entities

I am having some trouble to understand what is possible and what isn't with LiteDB. We are saving some entities in our database that have references of other entities. For example:
public class InvoiceLine : IEquatable
{
[BsonRef("BillingAccount")] public BillingAccount Account { get; private set; }
[BsonRef("Employee")] public Employee Employee { get; private set; }
public Amount Amount { get; private set; }
}
So when I save an invoiceLine that has an existing Employee and a BillingAccount everything works as expected. But when I save an InvoiceLine with an Employee that does not exist I would expect that LiteDB inserts that Employee into the correct collection and saves the newly added reference.
Sadly it seems like it saves a reference with the id "0", meaning none is created. I checked that with lite studio and there is no new entity created besides the InvoiceLine with faulty references.
Is there anything I have to add to create new entities automatically or is this not supported by LiteDB?

@JoshuaWegener The BsonRef attribute is only used to create references upon storage and resolve references upon retrieval. Insertions and updates to the referenced collection still have to be done manually.


Ruby CompressionType.values undefined

When i'm trying to include red-arrow version 0.12.x to my project i get
undefined local variable or method `values' for Arrow::CompressionType:Class (NameError)

output from cloning this repo and running rake test in ruby/red-arrow dir
$ rake test
cd -
/usr/local/bin/ruby test/run-test.rb
Traceback (most recent call last):
	16: from test/run-test.rb:33:in `<main>'
	15: from test/run-test.rb:33:in `require_relative'
	14: from /tmp/arrow/ruby/red-arrow/test/helper.rb:18:in `<top (required)>'
	13: from /usr/local/lib/ruby/site_ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	12: from /usr/local/lib/ruby/site_ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	11: from /tmp/arrow/ruby/red-arrow/lib/arrow.rb:24:in `<top (required)>'
	10: from /tmp/arrow/ruby/red-arrow/lib/arrow.rb:28:in `<module:Arrow>'
	 9: from /tmp/arrow/ruby/red-arrow/lib/arrow/loader.rb:24:in `load'
	 8: from /bundle/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:25:in `load'
	 7: from /bundle/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:45:in `load'
	 6: from /tmp/arrow/ruby/red-arrow/lib/arrow/loader.rb:30:in `post_load'
	 5: from /tmp/arrow/ruby/red-arrow/lib/arrow/loader.rb:38:in `require_libraries'
	 4: from /usr/local/lib/ruby/site_ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	 3: from /usr/local/lib/ruby/site_ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	 2: from /tmp/arrow/ruby/red-arrow/lib/arrow/compression-type.rb:18:in `<top (required)>'
	 1: from /tmp/arrow/ruby/red-arrow/lib/arrow/compression-type.rb:19:in `<module:Arrow>'
/tmp/arrow/ruby/red-arrow/lib/arrow/compression-type.rb:21:in `<class:CompressionType>': undefined local variable or method `values' for Arrow::CompressionType:Class (NameError)
rake aborted!

What version of Arrow GLib is installed?
Red Arrow uses Arrow GLib. Arrow::CompressionType.values was added in 0.12.0. You may need to upgrade Arrow GLib.

yeah sorry, found out the same that you just said


How to install on Windows 10?

I can copy zip and unzip, but I don't see an exe file or install file.  How do you install?

You download the correct version.
One that just contains the executable.


Add workload selection, success page, and name validation

Description
This adds workload selection to automatically add applicable additional repositories for RHEL EUS versions. These are set by name and version, which maps to an array of repos all provided by the rhsm-api endpoint v2/products/RHEL/extended-update-support-versions endpoint.
It also adds alphanumeric, -, and _ validation for the name of an activation key.
It also adds a success page with a link to the key, and the ability to close and continue looking at the list of keys.
Associated Jira ticket: TEAMNADO-5120

LGTM!


how to embed a ktrain model under a KerasRegressor call?

Hi @amaiya !
Just a quick question if you have some time. I would like to take advantage of the cross-validation features in scikit and given that ktrain is a wrapper around keras I though I would be able to wrap a ktrain call under a KerasRegressor call.
Unfortunately, the following does not seem to work correctly. I tried to wrap your simple text classification example but I get an error. What is the correct way to wrap ktrain then?
import ktrain
from ktrain import text
import keras
from keras.models import Sequential
from keras.layers import Dense
from tensorflow.keras.wrappers.scikit_learn import KerasRegressor
from sklearn.model_selection import RandomizedSearchCV

def build_model(maxlen = 500, class_names = [] ):

    MODEL_NAME = 'distilbert-base-uncased'
    t = text.Transformer(MODEL_NAME, maxlen, class_names)
    trn = t.preprocess_train(x_train, y_train)
    val = t.preprocess_test(x_test, y_test)
    model = t.get_classifier()
    return model

categories = ['alt.atheism', 'soc.religion.christian','comp.graphics', 'sci.med']
from sklearn.datasets import fetch_20newsgroups
train_b = fetch_20newsgroups(subset='train', categories=categories, shuffle=True)
test_b = fetch_20newsgroups(subset='test',categories=categories, shuffle=True)
(x_train, y_train) = (train_b.data, train_b.target)
(x_test, y_test) = (test_b.data, test_b.target)

#create the keras layer that will allow me to use cross validation, predict(), etc
keras_reg = KerasRegressor(build_model)

param_distribs = {
"maxlen": [100, 500],
"class_names": train_b.target_names
}

rnd_search_cv = RandomizedSearchCV(keras_reg, param_distribs, n_iter=10, cv=3)
rnd_search_cv.fit(x_train, y_train, epochs=100)

Thanks!

Perhaps try something like this:
def transformer(MODEL_NAME):
    preproc  = text.Transformer(MODEL_NAME, maxlen=200)
    x_test=df_test['text'].values
    x_test = preproc.preprocess_test(x_test)
    predictions,rmses=[],[]
    data = df_train[['text', 'target']]
    for train_index, val_index in KFold(5).split(data):
        train,val=data.iloc[train_index],data.iloc[val_index]
        x_train=train.excerpt.values
        x_val=val.excerpt.values

        y_train=train.target.values
        y_val=val.target.values

        trn = preproc.preprocess_train(x_train, y_train)
        val = preproc.preprocess_test(x_val, y_val)
        model = preproc.get_regression_model()
        learner = ktrain.get_learner(model, train_data=trn, val_data=val, batch_size=24)
        learner.fit_onecycle(1e-5, 5)
        print('mse',learner.validate())
        pred=learner.predict(val)
        rmse=mean_squared_error(y_val,pred,squared=False)
        print('rmse',rmse)
        predictions.append(learner.predict(x_test))
        rmses.append(rmse)
    return predictions,rmses

thanks @amaiya ! but this somehow embeds the training AND kfold validation in the function. My hope was to create a keras regressor object that will have a fit(), score() methods etc. In particular this will allow the user to call RandomizedSearchCV with the ktrain model but also with other scikit or keras models. That should be possible conceptually given that ktrain is a wrapper around keras... what do you think?

It's true that ktrain is a wrapper to tf.keras, but it doesn't expose the exact same API as Keras , which will probably cause problems for KerasRegressor.    It's still possible, though, if you modify or subclass KerasRegressor with some slight modifications, but I haven't tried it.

interesting, thanks. I think that would be a nice feature to have. You would leverage all of scikit's nice features.
In any case, keep up the good work!
Thanks


replace matrix with two vectors

Replaced the matrix with two vectors, since we only ever care about the previous and current rows.
Also use std::cmp::min instead of creating an array every iteration
Uses less memory and seems to be faster as well.

Hey, this seems like a strange decision to provide intentionally suboptimal code.
The suggestion from @Pfeil seems like a good one, would be happy to do whatever work is needed.

Yes, I also had second thoughts. As the idea with the educational features is only a that, an idea, it might make sense to apply well-known optimization to the algorithm. So I will reopen the PR.

@mikeantonacci the change doesn't apply cleanly any longer. Care to have a look?

Implemented in #13.


Specify node version

This fixes building on Apple silicon

Nice 👍 .
Side note: This logic could also be factored in build-logic and later on in a convention plugin


2021-10-11 - KDB Project Call Meeting Agenda

Date
Monday, October 11th, 2021 - 9:30am EST / 2:30pm BST
// Second Monday of every month
Attendees

Fullname
Affiliation
GitHub Username

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

(5 min) Convene, roll call, welcome new people.
[x] Display FINOS Antitrust Policy summary slide
[x] Review Meeting Notices (see above)
[x] (5 min) Approve previous meeting minutes.
[x] (10 min) Kdb Boothroyd updates?

Anything interesting from OSSF on the 4th for those who had scheduling conflicts?
Configuring auto-update? https://github.com/ScottLogic/kdb-boothroyd/issues/68

[x] (10 min) Findings on trying to get dzmipt fork of kdbStudio to build under FINOS tooling and within Morgan Stanley.

https://github.com/dzmipt/kdbStudio
Potential changes to project layout to make builds easier?
Who can help out with what on getting build / test going?

[x] (10 min)  Anaconda for q packages

AquaQ experience with releasing q libraries on Anaconda.
Discuss what it might take to get FINOS q packages on Anaconda.
Any other contenders for package distribution?

[ ] (5 min) cla-present tag.

https://github.com/finos/kdb-studio/pulls?q=is%3Apr+is%3Aclosed
Not very useful on PRs when every PR has that tag.
Can it be gotten rid of / moved to the end?

[ ] (5 min) Participation

Any other kdb developers who might be looped in?

[ ] (5 min) AOB, Q&A, Adjourn.

Decisions Made

Decision 1
Decision 2
...

Action Items

Action 1
Action 2
...

WebEx info
Webex

https://finos.webex.com/finos/j.php?MTID=me61719ca3c3295a7cc76762d78392bc3

Dial-in and Project Materials

US: +1-415-655-0003 US Toll
UK: +44-20319-88141 UK Toll
Access code: 2704 417 0390
GitHub Repos:

https://github.com/finos/kdb
https://github.com/finos/kdb-studio

Wiki Page:

https://finosfoundation.atlassian.net/wiki/spaces/DT/pages/329383945/kdb+Project

KDB Metrics on FINOS

https://metrics.finos.org/goto/033b15c80f0d08cab70f40f4358932f6

Linked shared in the KDP project meeting ...

https://github.com/gyorokpeter/qbinparse
https://github.com/adavies42/kdb/blob/feature/unzip/q/unzip/unzip.q


Add maven dependencies for OpenJCEPlus

This PR aims to solve the issue #5312 which caused by the dependency
,and also add the TestMemStressAll and TestMultiThread* related tests
for OpenJCEPlus

@jasonkatonica FYI

@JinhangZhang Could you update the title and commit message to Add TestMemStressAll and TestMultiThread*? And in the commit message, please reference https://github.com/adoptium/aqa-tests/issues/5312.
Also, will we add TestIntegration in a separate PR? https://github.com/ibmruntimes/OpenJCEPlus/blob/semeru-java11/pom.xml#L384
Please provide testing Grinders for PR.

This PR should be merged with https://github.com/adoptium/TKG/pull/551 together.

Yes, TestIntegration will be in a separate PR.

Also, will we add TestIntegration in a separate PR? https://github.com/ibmruntimes/OpenJCEPlus/blob/semeru-java11/pom.xml#L384

From what I understand, junit_vintage_engine,junit_platform_suite,junit_jupiter_api,junit_jupiter_engine,junit_jupiter_params,junit_platform_suite_api are jars that are needed for TestIntegration. Why are we adding them to this PR?

From what I understand, junit_vintage_engine,junit_platform_suite,junit_jupiter_api,junit_jupiter_engine,junit_jupiter_params,junit_platform_suite_api are jars that are needed for TestIntegration. Why are we adding them to this PR?

OpenJCEPlus contains this TestIntegration test in the pom file, we need those jars to compile it.

Grinder jobs: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_FIPS/1481/ TestAll fails
Grinder jobs: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_FIPS/1482/ shows the failed cases ( ibm.jceplus.junit.openjceplus.TestECDSASignatureInteropSunEC ) which is a known issue right now. Will be fixed soon.

re https://github.com/adoptium/aqa-tests/pull/5332#issuecomment-2122720028, ic, so we will compile TestIntegration now, but enable TestIntegration execution in a separate PR. 3rd party jars are needed for compilation.

I noticed job FAILURE in https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_FIPS/1481/console
01:24:56.566  ]: The incoming YAML document exceeds the limit: 3145728 code points.

What is the difference between two Grinder runs?

I noticed job FAILURE in https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_FIPS/1481/console
01:24:56.566  ]: The incoming YAML document exceeds the limit: 3145728 code points.

What is the difference between two Grinder runs?

1482 only execute the TestAll.java, 1481 runs TestMemStressAll.java, TestMultithread.java, TestMultithreadFIPS.java and TestAll.java. 1482 is only used to demo the failed cases.

shows the failed cases (TestECDSASignatureInteropSunEC ) which is a known issue right now. Will be fixed soon.

Do we have an open issue for this? If so, please provide the link. Thanks

shows the failed cases (TestECDSASignatureInteropSunEC ) which is a known issue right now. Will be fixed soon.

Do we have an open issue for this? If so, please provide the link. Thanks

The issue link is: jit-crypto/issues/445

Having an issue running https://openj9-jenkins.osuosl.org/job/test.getDependency/. I would prefer to hold this PR until the 3rd party libs are downloaded on the Jenkins job.
FYI @AdamBrousseau

I got a passed run: https://openj9-jenkins.osuosl.org/job/test.getDependency/1116/


update Critical version

Description
Our deploys were failing on Buddy because the build step was timing out when generating critical css.  Bumping up Critical to a more recent version worked.
Related issues

Thanks!

Released as 1.0.14

Thanks Andrew!


🌐 Add Dutch translation for docs/nl/docs/index.md

Relates to #4701
This translatesdocs/index.md into Dutch.

I guess it's duplicated of #4770 😟
A review there will probably be welcome 👀

I guess it's duplicated of #4770 😟
A review there will probably be welcome 👀

That one translates the tutorial instead of the index page. So, not a duplicate but yeah I can take a look.

It seems this was handled in another PR, so I'm gonna close this one, but thanks for the effort! :coffee:


Order commits by commit date

GitHub orders commits by author date instead of commit date:
https://help.github.com/articles/why-are-my-commits-in-the-wrong-order/
https://github.com/isaacs/github/issues/386#issuecomment-225763691 (title of this issue is sorta wrong)
I haven't looked at how hard it would be to fix this with refined-github. If I find a reasonable way to do it, would you accept a PR for it?

I think it's rare and unimportant enough to justify making an API call for the current branch to get each commit's date.

I don't think I understand your comment. You mean it's rare and unimportant (😢 on the latter), so it's not worth making an API call all the time? What about as an optional feature that defaulted to "off"?
A much easier feature to add would be putting small numbers beside the commits to indicate their true order, if they're not in the right order already.

If we were to reorder commits, I'll prefer ordering by parent in the Git graph and using dates only with multiple parents. This is a long-time issue I have with GitHub pull requests which I've created test reports for and communicated with GitHub. They are unwilling to change it. When you have a PR and interactively rebase your branch history and reorder commits they get reordered in some places on GitHub, but not in others. I don't see the benefit in switching the date, though. Committer date is better when ordering by date IMHO.

Closing as per my first comment. Perhaps Mottie has a userscript for this

@hkdobrev https://github.com/sindresorhus/refined-github/issues/2548

@graingert Is this about opening a new issue to discuss what I've suggested in https://github.com/sindresorhus/refined-github/issues/1294#issuecomment-386797552?

I think they did it, but only for PRs: https://github.blog/changelog/2020-07-14-pull-request-commits-now-ordered-chronologically/


Fix placeholders position in LineEdit when editing inside the Editor

Fix placeholders position in LineEdit when editing inside the Editor
Editing the Text property through the editor causes a wrong
placement of the placeholder, as it calls LineEdit::clear_internal,
which was wrongly reseting the cached placeholder width.
Fix #18184.

Thanks, seems good.

Still alignement issue of placeholder on godot 3.1.1 stable build


[dvsim] support css format for email

Correct email does not use correct CSS format.
This PR provide two settings of internal CSS formats: one for webserver,
another one for email
Signed-off-by: Cindy Chen<EMAIL_ADDRESS>

Hi Sri, the webpage won't be centered if we comment out these lines. It
looks like this:
https://reports.opentitan.org/hw/ip/alert_handler/dv/2020.04.24_05.03.14/results.html
On Thu, Apr 23, 2020 at 11:15 PM sriyerg<EMAIL_ADDRESS>wrote:

@sriyerg commented on this pull request.
Also how does the webpage look if we remove those lines?
In util/dvsim/utils.py
https://github.com/lowRISC/opentitan/pull/2053#discussion_r414314548:

@@ -186,6 +186,65 @@ def find_and_substitute_wildcards(sub_dict,
def md_results_to_html(title, css_path, md_text):
'''Convert results in md format to html. Add a little bit of styling.
'''

def gen_css_style():

Aah, sorry, nesting this function would look better only if we didn't have
to inline the whole css in here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/2053#pullrequestreview-399653157,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXPOOJK3YYSAI3DLXZ2PRDROEVANANCNFSM4MPWX6XA
.

Hi @sriyerg, here is what I found about premailer:

It converts external "


Remove RealT conversion from SVector

The inner type conversion is too dynamic for GPU kernels and it caused errors in my place during kernel compilation. But if the type conversion is removed, the kernel compilation looks good.
But it will bring some Float64 computation - do you @ranocha think it is Ok?

I cannot understand why we have to avoid Float64 entirely - GPU has tolerance for mixed precision.

This version looks good to me please review again and make it merge into the future release as soon as possible @ranocha

And update it with the future release as soon as possible thanks!

Please do not merge - I don't think it is a good way.

This final version cannot solve my problem https://github.com/trixi-gpu/TrixiCUDA.jl/issues/68 (I will think about another way) but it solves the original problem about small computation of Float64.
I want to confirm these things -

I cannot understand why we have to avoid Float64 entirely - GPU has tolerance for mixed precision computation so ensuring type preserving for results is enough
I am not sure whether 2^(i - 1) * (1 - 2) * RealT(1.1691) / (1 - 2^ncomponents(equations)) is better than 2^(i - 1) * (1 - 2) / (RealT(1) - 2^ncomponents(equations)) * RealT(1.1691)

Ready for review @ranocha

I cannot understand why we have to avoid Float64 entirely - GPU has tolerance for mixed precision computation so ensuring type preserving for results is enough

Where do you draw the line between an acceptable amount of Float64 and wasting time/energy? For example, you have insisted quite strictly on pure Float32 computations and maximal speedup in https://github.com/trixi-framework/Trixi.jl/pull/2042

I am not sure whether 2^(i - 1) * (1 - 2) * RealT(1.1691) / (1 - 2^ncomponents(equations)) is better than 2^(i - 1) * (1 - 2) / (RealT(1) - 2^ncomponents(equations)) * RealT(1.1691)

I prefer the first version since a * b / c is easier for me to read than a / c * b (which could be confused with a / (c * b)).

👍

Did you intend to close this PR? I'm asking since you have changed its title after closing it.

Yes - it is more convenient to open a new PR and I don't like to work on main branch.


Deprecate more filtered methods

Similar methods on Configuration were deprecated in https://github.com/gradle/gradle/pull/25124
If we are also able to remove these methods for removal in 9.0, we could delete the codepath the implements this legacy filtering.
Spring boot plugin and Spring dependency management plugin uses these APIs.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test ast

I've triggered the following builds for you. Click here to see all build failures.

AllSmokeTestsPullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

WARN: The milestone of this PR is 8.9 RC1, but the base branch version is 8.8


[broken feed]  CrimsonTome

Atom / RSS URL:

Link: https://crimsontome.com/atom.xml
Feed format (if known): Atom

Describe the bug
Images that are not from URLs will crash in the build process. e.g. https://crimsontome.com/img/cloud.png is classed as /img/cloud.png which of course is not found. This may be an issue with how Zola presents its images
Screenshots
N/A
System information (please complete the following information):**
OS will not matter, Dockerfile is below

Expand to view Dockerfile

FROM node:18.14-alpine3.16 as npmpackages
WORKDIR /app
COPY package.json .
RUN npm install

FROM node:18.14-alpine3.16 as builder
WORKDIR /app
COPY --from=npmpackages /app /app
COPY . .
RUN npm run build

FROM nginx:1.17.10-alpine
RUN rm -r /usr/share/nginx/html/
COPY --from=builder /app/_site/ /usr/share/nginx/html/

Build logs
Output of npm run build

Expand to view logs

><EMAIL_ADDRESS>build
> cd ./src && npx @11ty/eleventy --output=../_site

>>> [cache:MISS] GITHUB_USER sarapayne
>>> [cache:MISS] GITHUB_USER DavidParkerDr
>>> [cache:MISS] GITHUB_USER CrimsonTome
>>> [cache:MISS] GITHUB_USER fisherthewol
>>> [cache:MISS] GITHUB_USER itisNathaniel
>>> [cache:MISS] GITHUB_USER KieranRobson
>>> [cache:MISS] GITHUB_USER hullcss
>>> [cache:MISS] GITHUB_USER EirikaDoesntCode
>>> [cache:MISS] GITHUB_USER awenllais
FETCH 202ms https://kieranrobson.com/blog/index.xml
FETCH 226ms https://kieranrobson.com/docs/index.xml
FETCH 242ms https://goparker.com/index.xml
FETCH 247ms https://crimsontome.com/atom.xml
FETCH 253ms https://theeu.uk/blog/feeds/atom.xml
FETCH 282ms https://goparker.com/index.xml
FETCH 285ms https://hullcss.org/feed.xml
FETCH 300ms https://kieranrobson.com/blog/index.xml
FETCH 305ms https://kieranrobson.com/docs/index.xml
FETCH 326ms https://hullcss.org/feed.xml
FETCH 349ms https://theeu.uk/blog/feeds/atom.xml
FETCH 382ms https://crimsontome.com/atom.xml
FETCH 488ms https://nathanielread.co.uk/feed.xml
FETCH 626ms https://nathanielread.co.uk/feed.xml
FETCH 736ms https://edcblog.netlify.app/feed/feed.xml
FETCH 741ms https://edcblog.netlify.app/feed/feed.xml
FETCH 827ms https://blog.sarapayne.co.uk/feed
FETCH 839ms https://blog.sarapayne.co.uk/feed
FETCH 840ms https://awenllais.com/feed/feed.xml
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/C_Sharp_Logo.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/visualstudio_code-logo-1024x512.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/C_Sharp_Logo.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/C_Sharp_Logo.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2020/11/VisualStudioLogo.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2020/11/rider_logo_300x300.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2020/11/VisualStudioLogo.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/Python_logo_and_wordmark.svg_-1024x304.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/AND-Logic-Gate.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/LoopFlowChart.png
MEDIA IMAGE https://www.fedoraproject.org/w/uploads/2/2d/Logo_fedoralogo.png
MEDIA IMAGE https://upload.wikimedia.org/wikipedia/commons/c/c5/Nginx_logo.svg
MEDIA IMAGE /img/cloud.png
MEDIA IMAGE https://user-images.githubusercontent.com/64846840/188291755-3b17cbfb-667b-43cd-97c4-748a1d9f769a.png
MEDIA IMAGE /img/GitHub_Logo_White.png
MEDIA IMAGE /img/freeside_square_path.svg
MEDIA IMAGE https://edcblog.netlify.app/img/Testemphasis.png
MEDIA IMAGE https://awenllais.com/img/moonpie3110.png
FETCH 866ms https://awenllais.com/feed/feed.xml
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/C_Sharp_Logo.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/visualstudio_code-logo-1024x512.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/C_Sharp_Logo.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/C_Sharp_Logo.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2020/11/VisualStudioLogo.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2020/11/rider_logo_300x300.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2020/11/VisualStudioLogo.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/Python_logo_and_wordmark.svg_-1024x304.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/AND-Logic-Gate.png
MEDIA IMAGE https://blog.sarapayne.co.uk/wp-content/uploads/2023/02/LoopFlowChart.png
MEDIA IMAGE https://www.fedoraproject.org/w/uploads/2/2d/Logo_fedoralogo.png
MEDIA IMAGE https://upload.wikimedia.org/wikipedia/commons/c/c5/Nginx_logo.svg
MEDIA IMAGE /img/cloud.png
MEDIA IMAGE https://user-images.githubusercontent.com/64846840/188291755-3b17cbfb-667b-43cd-97c4-748a1d9f769a.png
MEDIA IMAGE /img/GitHub_Logo_White.png
MEDIA IMAGE /img/freeside_square_path.svg
MEDIA IMAGE https://edcblog.netlify.app/img/Testemphasis.png
MEDIA IMAGE https://awenllais.com/img/moonpie3110.png
[11ty] Problem writing Eleventy templates: (more in DEBUG output)
[11ty] 1. Having trouble rendering njk template ./index.njk (via TemplateContentRenderError)
[11ty] 2. (./index.njk)
[11ty]   EleventyShortcodeError: Error with Nunjucks shortcode `asset` (via Template render error)
[11ty] 3. ENOENT: no such file or directory, copyfile '/img/cloud.png' -> '../_site/img/cloud.png' (via Template render error)
[11ty]
[11ty] Original error stack trace: Error: ENOENT: no such file or directory, copyfile '/img/cloud.png' -> '../_site/img/cloud.png'
[11ty] Benchmark    959ms  16%     1× (Data) `./feed.11tydata.js`
[11ty] Benchmark    942ms  16%     1× (Data) `./index.11tydata.js`
[11ty] Wrote 0 files in 5.99 seconds (v1.0.2)

Additional context
N/A

can confirm this fixes #14, will close :smile:


Extend AsyncClient to support streaming requests / responses

Refactor AsyncRequestImpl to AsyncStreamImpl and add streaming requests / responses
Implements AsyncRequestImpl based on AsyncStreamImpl

Existing AsyncClientImplTest covers most of AsyncStreamImpl. Working on more tests for streams.
@qiwzhang PTAL.
Closes #317.

@lizan I'm OOO tomorrow, will take a look next week when all tests are in place. At a very high level approach is fine.

This is cool.  Just wondering if this stream can be shared by multiple threads.  1) can multiple thread write data to this stream. 2) When response data is received, which thread will be called.

@qiwzhang no, as written, AsyncClient is thread local and cannot be safely shared between threads. It would be possible to surround it with enough locking to make it safe, but my general recommendation would be to reframe your problem as a thread local problem. I have not yet found a problem that cannot be solved cleanly with this pattern. Happy to discuss this offline with you.

@mattklein123 Thanks for your quick response.  In this case, istio/proxy will need to create N gRPC streams to istio/mixer if it has N threads.  I feel it will be better if they can share the same gRPC stream since some transport optimizations of mixer api are done based on the gRPC stream.  We will go with one stream per thread for now to make thing easier, will visit this later if performance is an issue.

@lizan can you tag me when the tests are finished and you address roman's comments. then I will take a look.

@mattklein123 sure, I'm making more changes since I discovered some problems in the tests. In the meanwhile it would be nice if you can take a look on the interfaces (i.e. async_client.h).

@lizan sure will do.

@mattklein123 Thanks for reviewing it, and sorry I was busy on other things today, will update the PR with tests soon.

@mattklein123 This is ready to review, PTAL. Thanks!

@RomanDzhabarov please review. I will take a final pass once you are done.

I'll take another pass on this today.

@lizan there are a huge amount of comments on this review. I'm fine with the overall approach. When everyone's concerns are satisfied or if there are other questions let me know and I can review in detail.

@fengli79 @louiscryan @RomanDzhabarov PTAL again, thanks!

@mattklein123 Sorry for the delay, PTAL when you have time, thanks!


scripts: compliance: Fix misdetection of Kconfig choices as undefined

This commit updates the KconfigCheck to add the Kconfig symbols from both "config" and "choice" symbol lists to the defined symbol list, as opposed to the "config" list only, in order to prevent any references to the choice symbols outside the Kconfig files (e.g. in documentation) from being reported as undefined.
Signed-off-by: Stephanos Ioannidis<EMAIL_ADDRESS>
A practical use of this is referencing a Kconfig choice as :kconfig:option:'CONFIG_NAMED_CHOICE' in the documentation, which currently results in a compliance check failure without this patch.

I'd like @tejlmand to take a look before we merge


createLeft function is broken

Thanks for your work.
Latest commit, built with stack-local ghc-8:
*Data.Sext.TH Data.Sext Data.Sext.Class Data.Sext.TH> Data.Sext.createRight ' ' "string" :: Sext 10 String
"    string"
*Data.Sext.TH Data.Sext Data.Sext.Class Data.Sext.TH> Data.Sext.createRight ' ' "string" :: Sext 1 String
"g"

createRight is okay, but createLeft gives me:
*Data.Sext.TH Data.Sext Data.Sext.Class Data.Sext.TH> Data.Sext.createLeft ' ' "string" :: Sext 1 String
"string"
*Data.Sext.TH Data.Sext Data.Sext.Class Data.Sext.TH> Data.Sext.createLeft ' ' "string" :: Sext 100 String
"string"
*Data.Sext.TH Data.Sext Data.Sext.Class Data.Sext.TH>

It seems that the last call to C.take (C.length s) in the implementation is incorrect, since it just returns an origin string.
The correct implementation needs to use C.take t to be valid.

Hello, thank you for reporting the bug - this is really embarassing. Should be fixed in sext-0.1.3.

Don't worry! The issue was found when I played with liquidhaskell and your package for an university paper, so I am glad to help here.
I hope it is okay to mention your library in my course paper.
The issue is resolved, hence closed.

Of course. Best of luck.


Removing last item from cart in checkout page causes visual bug

Issue
Items can be removed at checkout which causes the checkout summary to collapse its width.

Solution

If you remove the last item from the checkout page / or have no items, show a "Cart Empty" message for the whole page to return the user to shopping (or redirect to the Cart with the empty cart message)
Or, don't allow users to modify their cart items at checkout

Comments from slack
Cassy [Yesterday at 2:39 PM]
@mike I agree with you re: the Checkout demo today that the current experience of removing the last item from your cart, during checkout, is super weird! I have some ideas for how to fix it so it’s less awkward (while keeping the ability to edit item quantities in checkout, which was our goal UX-wise) – should I file a bug in the Starterkit repo for that, or is there another way we should work that out? :thinking_face: (cc @spencer maybe?)
14 replies
Cassy [20 hours ago]
there are also a few more UX/UI bugs unrelated to that I’ve been keeping track of for the starterkit - let me know the best way to file those
spencer [20 hours ago]
I feel like we’ve changed this several times at this point and we should just stick with what we’ve decided for now and figure out how to make it a reasonable experience.
If a user removes the last item from their cart in checkout, can we just show them the empty cart message?
spencer [20 hours ago]
As a customer, if I remove the last item from my cart, I should expect that I won’t stay in checkout correct?
Cassy [20 hours ago]
yeah - we should at least kick them out of checkout, back to the empty cart or maybe the homepage?
spencer [20 hours ago]
I’d vote back to the empty cart
Cassy [20 hours ago]
I was thinking adding a “are you sure you want to remove this item?” modal would also make sense here…
spencer [20 hours ago]
That’s a great idea.
Showing the empty cart doesn’t necessarily even need to be forced navigation, just if we have an empty cart when you’re in the checkout, we’ll show you the empty component
Cassy [19 hours ago]
ok cool! so I think at minimum when the cart becomes empty during checkout, let’s redirect back to the empty cart so that the user understands what’s happening… (‘i just deleted all of my items and now my cart is empty, so i can’t check out.’)
Adding a modal as a failsafe for each item the user removes in checkout (either via the remove button, or by 0-ing the quantity) would also be ideal here.
Eric Dobbertin [19 hours ago]
@Cassy Makes sense. Can you make two separate issues in starter kit repo?
Eric Dobbertin [19 hours ago]
I’d say you can make an issue for each of the other UI/UX bugs, too. Even if we close them, it’s a place for public discussion of them
Cassy [19 hours ago]
@Eric Dobbertin ok! will do.
mike [19 hours ago]
@Cassy @Eric Dobbertin I added an issue here right after the retro: https://github.com/reactioncommerce/reaction-next-starterkit/issues/238
mike [19 hours ago]
feel free to add your own, or modify that one if needed
Cassy [19 hours ago]
@mike ahh cool! I’ll just comment on that one. thanks!


UI Bug: Logo and Heading Overlapping on Registration page

🐛 Bug Report
Describe the bug
There is a visual issue on the website where the logo and heading overlap. This affects readability and visual aesthetics, especially on smaller screens. This issue was observed in the Registration page.
To Reproduce
Steps to reproduce the behavior:

Go to the rentalog website.
Navigate to registration page
3, Observe the overlapping issue between the logo and heading.

Expected behavior
The logo and heading should have adequate spacing to ensure they are clearly visible and not overlapping.

Screenshots
Registration Page

Environment (if applicable)
Provide relevant details about the environment where the issue occurred:
Desktop (please complete the following information):

OS: Win 11
Browser Chrome
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
This issue was observed when viewing the site,. The overlap affects the readability and overall user experience on these screens.

Severity
How critical is this issue?

[ ] 🔴 Critical
[ ] 🟠 Major
[x] 🟡 Minor

Possible Fix
The logo and heading should have adequate spacing to ensure they are clearly visible and not overlapping.

Checklist

[x] I have searched the existing issues and this bug has not been reported yet.
[x] I have updated the project to the latest version.
[x] I have provided all the necessary details.
[x] I have starred this repository.

Please assign me this issue

Can I work on  this issue?


"Maximum call stack size exceeded" error reported by Chrome when viewing large file on Completed Jobs page

This issue is observed v0.4.0
Nothing is shown when trying to view a large log file from Completed Jobs page. And Chrome insepct shows error "Maximum call stack size exceeded" on link.
Stackorverflow has suggestions on how to handle this error:
https://stackoverflow.com/questions/49123222/converting-array-buffer-to-string-maximum-call-stack-size-exceeded
Hope this issue can be fixed soon. For now I have reverted to use v0.3.2.

This code has been completely rewritten. Can you please have a look at master and see if your issue is fixed?


Make the tests from sentry_flutter also to be run on the "browser"

https://github.com/getsentry/sentry-dart/blob/a9979b0adc18b2545ad907ebae8b1f4b558844d6/flutter/test/sentry_flutter_web_test.dart
get the inspiration from:
https://github.com/getsentry/sentry-dart/blob/d24cb5039f38845d73f613454704c2904cf0a94c/dart/test/sentry_browser_test.dart

Also see https://flutter.dev/docs/cookbook/testing/integration/introduction#6b-web

Currently a few tests seem to timeout with flutter test --platform chrome. I'll need to look further into it.


Index file language and send it on hover

This allows hover strings to have syntax highlighting
Currently it breaks hover in vscode (with nothing logged), and makes emacs emit the infamous (error No Content-Length header)

This now gives syntax highlighting in hover messages in both emacs and VS code (not sure if vs code had it already). AFAIK, this is ready for merging


Documentation for MapViewOfFile3 is inaccurate

Link to article:
https://docs.microsoft.com/en-us/windows/desktop/api/memoryapi/nf-memoryapi-mapviewoffile3
Problem:
The article claims that MapViewOfFile3 is exported from kernel32.dll, however as of Windows 10 1809, it is only exported from kernelbase.dll.

Hi @dblohm7 -- thank you for your feedback! We'll work on investigating this issue.

Since this issue has been open for a while, I'll add a +1 - this documentation is still incorrect for Windows 11.


Improved portuguese translation

Improved portuguese translation file.

Also, the English version uses the imperative form. Maybe you should write "Insira informações de acesso" instead of "Inserir informações de acesso", "Não use" instead of "Não usar", "Use o método de autenticação"  instead of "Usar método de autenticação", "Compartilhe a conexão HTTP" instead of "Partilhar ligação HTTP", "Force o uso do protocolo" instead of "Forçar o uso do protocolo", "Use o URL no primeiro campo" instead of "Usar o URL no primeiro campo".
I'm not from Portugal but it would be the correct approach in Brazilian Portuguese.

In Portuguese it is also common to use the infinitive form, both approaches are correct.
Anyway, I'll change it following your recommendations.

I understand that the infinitive form does exist in Portuguese. I'm just pointing out that the English translation uses the imperative form, and it's usually better to follow that pattern.

Thanks👍


Formatter, intelisense, even collapsing code blocks doesnt work with files opened from network location (nemo/cinnamon)

Type: Bug
Opening files from SFTP network locations opened in Nemo/Cinnamon as i have for years but now the "JavaScript" language button in the status bar just keeps rotating hourglass. Intellisense does't work, can't even collapse code block using Ctrl+K+1.
If i open a local file, sometimes i think its working, but if i open a file from network location and another local file, then intelisense stops working for all files. Something is wrong.
If i auto format the document, after waiting like 1 minute, intellisense stats to work again. Then rotating hourglass again.
I delete my .config/code and .vscode directories and reset everything, still does the same thing. Does not appear to be related to any plugin.
Im using Debian 12 RC3, its just a fresh install.
VS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:47:05.613Z)
OS version: Linux x64 6.1.0-9-amd64
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3093)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
31.30GB (25.17GB free)

Process Argv
--unity-launch --crash-reporter-id 0cadb521-1103-404f-a665-2d3050bc97f6

Screen Reader
no

VM
0%

DESKTOP_SESSION
cinnamon

XDG_CURRENT_DESKTOP
X-Cinnamon

XDG_SESSION_DESKTOP
undefined

XDG_SESSION_TYPE
x11

Extensions (23)

Extension
Author (truncated)
Version

Bookmarks
ale
13.3.1

doxdocgen
csc
1.4.0

json-tools
eri
1.0.2

shell-format
fox
7.2.5

compareit
in4
0.0.2

better-cpp-syntax
jef
1.17.2

auto-build
mar
2.1.45

nc-gcode
ML
0.13.0

compare-folders
mos
0.22.5

remote-containers
ms-
0.292.0

remote-ssh
ms-
0.102.0

remote-ssh-edit
ms-
0.86.0

remote-wsl
ms-
0.78.6

cmake-tools
ms-
1.14.31

cpptools
ms-
1.15.4

cpptools-extension-pack
ms-
1.3.0

remote-explorer
ms-
0.4.0

vscode-serial-monitor
ms-
0.9.0

platformio-ide
pla
3.1.1

cmake
twx
0.0.17

vscode-arduino
vsc
0.6.0

zoombar-vscode
wra
1.4.4

clang-format
xav
1.9.0

(2 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
282f8724:30602487
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
2i9eh265:30646982
showlangstatbar:30737416
vsccsb:30705552
pythonms35:30701012
pythonfmttext:30731395
pythoncmv:30739700
fixhidewlkth:30730051
pythongtdpathcf:30739705

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


ErrorDialog Pop-Up

The 1st part of the ticket has been completed, with the error window now using the native functionality of Visual Studio.
After this, I will be adding the theming fixes to this PR.


Backlinks with Ampersands Don't Resolve

Hi, thanks for the truly awesome work 🙇🏻 Some of my notes have ampersands (&) in the titles, and backlink to these notes don't resolve (404) despite the fact that the note itself does get published. For example, the link to Storage & Service on my homepage doesn't resolve, but the Storage & Service page is rendered just fine. I've turned off the slugify options. Is there a way to fix this?

Not an answer/solution but an explanation:

& is used as an argument separator web / URL encodings.
You can use it in the URL and it works but in the guts of URL interpreters it needs to be encoded as %26.
I'm actually surprised Obsidian lets you use it in note titles. Generally I would recommend avoid using & (or any other reserved URI characters) in your note titles.

My gut tells me what is needed is urlencoding at some early step to avoid this issue -- which probably make sense to debug and figure out because there are other characters beyond just & that people might use in titles.
Want to geek out deeply on this knowledge? Then check out the IETF RFC 3986     Uniform Resource Identifier (URI): Generic Syntax.  It really is actually pretty cool to understand this fundamental thing in our lives.
It lays out the other reserved characters - some of which Obsidian already prevents people from using in titles.
reserved    = gen-delims / sub-delims
      gen-delims  = ":" / "/" / "?" / "#" / "[" / "]" / "@"
      sub-delims  = "!" / "$" / "&" / "'" / "(" / ")"
                  / "*" / "+" / "," / ";" / "="

I have a script I'm using to prepare my vault for publishing...I could use it update titles and backlinks, but that seems a little kludgy TBH https://github.com/danforbes/wset-notes/blob/main/prepare-for-publish.ts

Sorry, this was broken in a recent refactor I did when adding better support for dataview js. I've found the issue and released an update which should fix this, so that ampersands in titles should work just fine. You need to update the template  for the fix. Let me know the issue was resolved or not after updating 😄


BUG: rna-seq > trackhub

Describe the bug
'InputFiles' object has no attribute 'twobits'
To Reproduce
run the rna-seq pipeline

https://github.com/vanheeringen-lab/snakemake-workflows/blob/0990c6280fbe6f3d502f8dbd7d2f95a91d167911/rules/trackhub.smk#L298
Probably changing that call would solve everything:
if any(assembly in twobit for twobit in input.getattr('twobits', []):


Call add_child after set_rect to fix size bug

closes: https://github.com/godotengine/godot/issues/80234

Even if the sizing problems are a bug, initializing stuff after adding it to tree is kinda backwards tbh

Well, it is possible that the context of the parent would affect how some things are resolved when it comes to sizing. Probably not with containers, but with anchors when setting a preset it may work differently, I think.
In this case, btw, I'm not even sure it makes sense to have a button control. We could just draw an icon and detect clicks over specific areas with a bit of lower-level code. That should avoid messing with control sizing all together. But that's not important for this PR.

Could you please amend your commit message to follow the project's preferred style? The title of the PR is a good option.

Thanks!


Allow indentation of non-nested code

There should be a setting allowing to indent non-nested code. For example, the following is valid and is often used to tell the reader that there is a kind of hierarchy, but without using fifteen kilometers long selectors :
.foo {
}

    .something-inside-foo {
    }

        .and-something-inside-its-parent {
        }

Instead of
.foo {
    .something-inside-foo {
        .and-something-inside-its-parent {
        }
    }
}

Doing this generates
.foo { }
.something-inside-foo { }
.and-something-inside-its-parent { }

Instead of
.foo { }
.foo .something-inside-foo { }
.foo .something-inside-foo .and-something-inside-its-parent { }
...

I suggest adding an option to the Indentation linter to ignore indentation errors when they increase the indentation level of a rule by a single level, and only if the rule is not the first one of the block.

Implemented in 1b0f2e5b140cd2f7ac145a93901eee6296e93529.

Great, thanks a lot!

This doesn't support class names with parent selectors.
As of Sass 3.3 parent selectors (&) can be used for prefixing class names, which means we can now rewrite this:
.block {}
.block__table {}
.block__row {}

into this:
.block {
    &__table {}
    &__row {}
}

Let's say &__row will always be inside &__table and I'd like to suggest that in the code:
.block {
    &__table {}
        &__row {}
}

This triggers a lint error, although being (IMO) a legitimate use of arbitrary indentation.
Would you consider removing the condition that arbitrary indentation is allowed only for top-level rulesets? Thanks!

Hey @kty, we would happily accept a pull request adding support for the feature you describe. Thanks!