Native Simulator: fix obviously unnecessary copying of large structures in wave function

Replace passing by value of GateWrapers and Clusters with passing by const& when read-only access is required. We still copy instances of these two classes a lot and there will be one more refactor to address that.

These changes look good, and I expect that the existing native tests would fail on clustering bugs (as they did when this infrastructure was introduced over the summer), so if those tests are passing that gives us good confidence on correctness. I would still like @dbwz8 to take a look to make sure, but this seems like it's ready to me!

Thank you for reviewing! I'm not concerned about this particular batch of changes because they are mostly mechanical. The next refactor of clustering is more meaningful and I will certainly involve Dave.


fix: luisresource missing from import

Description
add luisResource to the default schema for Azure Publishing
Task Item
fixes #8244

Coverage remained the same at 56.258% when pulling 68a05ab923761ddabb09c7c56600d5c3f395ce35 on natalgar/8244-fix-luisresource-missing-from-import into 8090b4cacd69617373ef6706a731615b1bd79717 on main.


修改触发器sql解析,解决触发器后续sql被吞掉的情况

修改触发器sql解析

原来的触发器解析时使用 this.parseStatementList() 方法解析全部的sql，这样就会导致触发器后续的sql也会一起解析；
解析完成之后需要拿触发器内的sql语句stmt.setBody(body.get(0))  这样再触发器后面的sql解析了，但是却被丢弃了，就导致了sql的丢失；
如示例sql中修改前解析出来的SQLStatement 只包含触发器 my_trigger前的，后续的sql将丢失(create table_2)。
 We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.fantasy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.fantasy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

请签署CLA

请签署CLA

签了


remove "Set who receives e-mail" from bottom of "Manage Users" page

This is deliberate, so I'm not changing it back, but I did change the nav and add some language to make it clearer.


State property will return a value of undefined if similarly named getter is configured

Reproduction
Having a state of:
{
    testProperty: null
}

and having 2 getters:
testProperty: (state) => state.testProperty,
somethingElse: (state) => state.testProperty !== null

calling storeObj.somethingElse() will return true because state.testProperty will return undefined
storeObj.testProperty()  will also return undefined
Steps to reproduce the bug

Define a store and create a property in the state
Add a getter with the same name as the property you just added in the state
Calling the getter will result in undefined
Changing the name of the getter with the identical name as the property in the state will make it return the correct value

Expected behavior
According to the docs a getter should access the value of a state property when you use state.<key> and should get the value of another getter when you use this.<getterName> .
Having a identically named getter should not produce a value of undefined for the state property.
Alternatively, if it is undesired to have a similarly named state property and getter, Pinia should throw an error in the console.
Actual behavior
using state.<propertyName> when a getter with an identical name as propertyName is set, will return a value of undefined.

@posva just not released yet then? I'm on 2.0.22 and experiencing this.


add: datepicker plugin and Flowbite

Name
Link

Tailwind Datepicker
https://github.com/themesberg/tailwind-datepicker

A datepicker component built with Vanilla JavaScript and Tailwind utility classes.

Name
Link

Flowbite
https://flowbite.com/docs/getting-started/introduction/

Open-source web components and interactive elements built with Tailwind CSS

[x] My item is in the right category
[x] My item is logically grouped below similar items
[x] My item's name and description respects the conventions of the list
[x] My item is awesome
[x] My item is in line with the Tailwind brand usage guidelines
[x] I have read and followed the contribution guidelines

@innocenzi I've moved the new additions below and also updates the description according to the guideline. I hope it's good now.

For some reason I can't commit these two changes myself, so please do so yourself and I'll merge after that!

I've resolved your changes, can you merge now?

You didn't make the modifications I asked, you just resolved (read: dismissed) the two review comments. :/

I've made the changes and also moved the Tailwind Datepicker to the "components" section since it wasn't actually a plugin but a component/library.
PS: I thought that by using the Github "resolve" mechanism it would apply your changes.

PS: I thought that by using the Github "resolve" mechanism it would apply your changes.

Nope, there's usually a "commit" button next to it for this purpose, but I couldn't see it this time. Anyway, it's merged, thanks!

Thanks @zoltanszogyenyi!


Automated cherry pick of #3669: fix: 安全组列表添加server过滤参数

Cherry pick of #3669 on release/2.13.
#3669: fix: 安全组列表添加server过滤参数

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@ec7f330). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.13   #3710   +/-   ##
==============================================
  Coverage                ?   6.95%
==============================================
  Files                   ?     500
  Lines                   ?   83960
  Branches                ?       0
==============================================
  Hits                    ?    5838
  Misses                  ?   77626
  Partials                ?     496

Flag
Coverage Δ

#aFlag
6.95% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/secgroups.go
2.05% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7f330...13631a8. Read the comment docs.

/lgtm

/approve


Fixed #25496 -- Made ModelChoiceField respect prefetch_related().

https://code.djangoproject.com/ticket/25496

LGTM


update library state to override default parameters.initialization

Hello you all! I'm using this awesome library some days ago, this works pretty well in some tests I did, Now I'm trying to get the data inside a navigateTo param when my app is NOT running. I'm using the firebolt Prameters module to get that data.
To do so, I'm trying to override the default mock value for parameters.initialization by uploading my parameters-initialization.json which contains the following json
{
  "jsonrpc": "2.0",
  "id": 1,
  "method": "parameters.initialization",
  "result": {
    "lmt": 0,
    "us_privacy": "1-Y-",
    "discovery": {
      "navigateTo": {
        "action": "playback",
        "context": {
            "source": "device"
        },
        "data": {
          "entityType": "program",
          "programType": "movie",
          "entityId": "my-entity-id"
        }
      }
    }
  }
}

this is the executed command node cli.mjs --upload ../examples/parameters-initialization.json
The update seems to be well since the cli says { status: 'SUCCESS' } and the server says "Updating state for default user 12345" (my app is working with the default user) but when I reload my app I'm getting the default data again and again :(
After updating the state of mock-firebolt and reloading my app I'm getting the default data:
{
  "navigateTo": {
    "action": "entity",
    "data": {
      "entityId": "abc",
      "entityType": "program",
      "programType": "movie"
    },
    "context": {
      "source": "voice"
    }
  }
}

I want mock-firebolt to get the data in my app as I defined in the library state, something like this:
{
  "navigateTo": {
    "action": "playback",
    "context": {
      "source": "device"
    },
    "data": {
      "entityType": "program",
      "programType": "movie",
      "entityId": "my-entity-id"
    }
  }
}

Could you help me please?

Hey, I found a solution for this, I just used a yaml file instead json to update the mock-firebolt state, my app is working now with this
command:
node cli.mjs --upload ../examples/parameters-initialization-playback.yaml
examples/parameters-initialization-playback.yaml:
---
methods:
  parameters.initialization:
    response: |
      function f(ctx, params) {
        const result = {"discovery":{"navigateTo":{"action":"playback","data":{"entityId":"my-entity-id","entityType":"program","programType":"movie"},"context":{"source":"device"}}}};
        return result;
      }


Observers can modify/move boats in-game

Issue
Observers can modify/move/break boats in observers.
How to Re-Create
Have someone in-game place a boat. Have another player in Observers. Have the observer go under the boat, they can re-direct it and move it with their head. Kindda like a flying carpet.
Evidence: http://youtu.be/pmbh7qXkbF8

Isn't fixed

My bad

I think this bug also happend on the Overcast, it would be cool if you guys fix it.


[HWMON] Fix PECI CPU temperature

PECI CPU temperature should be reported in milliCelcius

Just remembered this branch was a parallel effort to my fixing the same merge problem.
I suggest this branch be deleted, but will await confirmation.

Yes, that’s fine
From: Adrian Filipi @.>
Sent: Friday, November 8, 2024 9:56 AM
To: silicom-ltd/ecfw-zephyr @.>
Cc: Jeff Daly @.>; Author @.>
Subject: Re: [silicom-ltd/ecfw-zephyr] [HWMON] Fix PECI CPU temperature (PR #4)
Caution: This is an external email. Please take care when clicking links or opening attachments.
Just remembered this branch was a parallel effort to my fixing the same merge problem.
I suggest this branch be deleted, but will await confirmation.
—
Reply to this email directly, view it on GitHubhttps://github.com/silicom-ltd/ecfw-zephyr/pull/4#issuecomment-2464961211, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASDWUUE7IQCZOJIOF7YEX6LZ7TGG3AVCNFSM6AAAAABRJ2OSYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRUHE3DCMRRGE.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


add the missing WsContext.queryParam(key) function

Out as part of 3.4.1 now: https://javalin.io/news/2019/08/11/javalin-3.4.1-released.html


Verify package-lock.json file

Codecov Report

Merging #11030 (134e863) into main (fafa651) will decrease coverage by 0%.
The diff coverage is n/a.

:exclamation: Current head 134e863 differs from pull request most recent head f21decb. Consider uploading reports for the commit f21decb to get more accurate results

@@          Coverage Diff           @@
##            main   #11030   +/-   ##
======================================
- Coverage     63%      63%   -1%
======================================
  Files        482      482
  Lines      33821    33821
  Branches    5512     5512
======================================
- Hits       21366    21355   -11
- Misses     10419    10426    +7
- Partials    2036     2040    +4

Impacted Files
Coverage Δ

src/notebooks/debugger/debugger.ts
66% <0%> (-12%)
:arrow_down:

src/notebooks/outputs/tracebackFormatter.ts
93% <0%> (-7%)
:arrow_down:

src/notebooks/debugger/debuggingManagerBase.ts
69% <0%> (-6%)
:arrow_down:

src/notebooks/debugger/kernelDebugAdapterBase.ts
76% <0%> (-3%)
:arrow_down:

src/platform/common/cancellation.ts
62% <0%> (-2%)
:arrow_down:

src/notebooks/debugger/debuggerVariables.ts
67% <0%> (-1%)
:arrow_down:

src/kernels/jupyter/jupyterKernelService.node.ts
76% <0%> (+1%)
:arrow_up:

src/kernels/execution/notebookUpdater.ts
96% <0%> (+7%)
:arrow_up:


Fix broken behat scenarios

The build is broken due to symfony-cli installation problems on shivammathur/setup-php@v2


Translation update from Crowdin

Updated translations from Crowdin to the latest version.

Turkish - Tayfun Bilgi (Tayfun [Typhoon])
French - Guillaume Turchini (orion78fr)
Japanese - しょしょ02 (yamadatarounohosi)
Chinese Simplified - 田七不甜 (TianQiBuTian)
Ukrainian - Dmytro Lytovchenko (kvakvs)
Polish - krzychu124
English, United Kingdom - kianzarrin (kian.zarrin), aubergine10

Nuget package manager is failing... We have to wait...
I will probably update StyleCop.Analyzers to newer version when service will be available

Added missing strings for Ukr and Rus.


Exception catching for event subscribers

Currently, whenever a subscriber to an event throws an exception, the exception is passed through upstream as-is and because of that, execution of the other subscribers is halted.
This was a bit confusing to me, as I expected each subscriber to be executed atomically (even if executed synchronously).
I also think it's simple to catch thrown exceptions in the middleware, put them in a collection and throw a specialised SubscriberFailed exception with the collection of exceptions as parameter. This way, upstream callers can cleanly handle the exceptions, while the other subscribers are not affected.
Would this fit in the current NotifiesMessageSubscribersMiddleware? Or could it be a separate middleware handler that one can choose to use instead?

Thanks for reporting this long-standing issue! I knew it exists, but: I wasn't sure how to handle it. This is my reasoning for leaving it as-is:

Other event management tools I know of in PHP just let any exception in a listener bubble up, so I thought it would be more intuitive if MessageBus didn't do this either.
To collect the exceptions by default and throw them all together can't be standard behavior I guess because in one situation it makes sense to continue processing the other events, in others it doesn't.
What you're really looking for (I guess) is a retry mechanism: everything an event listener does is important to your application, so you can't afford to simply ignore a failure. If the exception is caused by some kind of a bug, then it doesn't matter if you only get this one exception (e.g. a LogicException). If the exception is caused by some external thing breaking or returning unexpected results (e.g. a RuntimeException), then I'd suggest moving the event subscriber logic offline and let it be handled by a message consumer (like the RabbitMQ or Bernard consumers for SimpleBus).

I'm curious about your (and anybody else's) thoughts here.
I also think it would still be interesting to collect and rethrow bundled exceptions, but it can't be the default style of handling exceptions (or it would require a new major version...). The behavior should be configurable via a constructor argument of NotifiesMessageSubscribersMiddleware I think. If you'd like to work on it: I'm happy to add it to this package.
By the way, it would then be nice to have a config option in SimpleBus/SymfonyBridge to enable this behavior too.


Update token_info endpoint from v2 to v3

Hi guys, is this change in program? v3 endpoint returns lot more information, so it would be useful...

Hello @aleripe, could you please be a little more specific? What token_info endpoint are you referring to? Something in the code of this project, or a URL in the Google APIs machineary?
What type of information is returned from the "v3 endpoint" that would be useful to you?
Thanks!

Hi,
thanks for your answer.
I am referring to this call:
https://www.googleapis.com/oauth2/v3/tokeninfo?access_token=[token]
Compared to the old https://www.googleapis.com/oauth2/v2/tokeninfo?access_token=[token] it returns a lot more informations. You can read more details here: https://github.com/zquestz/omniauth-google-oauth2/issues/216

I just tested it and i am getting the same information back from both.

{
"issued_to": "1046123799103-d0vpdthl4ms0soutcrpe036ckqn7rfpn.apps.googleusercontent.com",
"audience": "1046123799103-d0vpdthl4ms0soutcrpe036ckqn7rfpn.apps.googleusercontent.com",
"scope": "https://www.googleapis.com/auth/analytics",
"expires_in": 3579,
"access_type": "offline"
}

I dont think this question is related to the client library really.

This doesn't appear relevant to these client libraries; we don't appear to use the tokeninfo anywhere in this code.
Closing; please re-open with more information if some work is required.


some examples for how to run gost as tunnel.

https://github.com/woodlyer/gostExample  for more infomation.
./gost -L kcp://:9000/:8083
./gost -L tcp://<IP_ADDRESS>:8083  -F forward+kcp://server_ip:9000

Wish it is helpful for someone.

Hi,
I'm trying to connect to Server B through Server A with ssh,
basically I can connect to Server B fine with:
gost -L=:9050 -F forward+ssh://user@serverb:port
but now I want to add Server A in the middle and currently no luck!
Please help!
Thanks in advance

Thanks
I think I didn't explain exactly what I need, I need a proxy (socks) through ssh protocol.
I'm doing like this now:
# this will listen on local port 2222 and redirect connections to server B (through server A)
ssh -L 2222:<serverB_ip>:<serverB_port> <serverA_user>@<serverA_ip>:<serverA_port>

# forwards socks requests to server B (through server A)
gost-linux-armv8-2.11.4 -L=:<local_socks_listen_port> -F forward+ssh://<serverB_user>@localhost:2222

but still, this is a two step process (run ssh then run gost). I wonder if it can be run in just one gost command (chained).
And also, I've tried chaining -F (forward+)ssh://<ssh_connection_options> combinations aleady and get ssh connection failed error.

build a tunnel from A to B for ssh port 22 like this. kcp can be replaced with tls.
# server B
./gost -L kcp://:9000/:22
# server A
./gost -L tcp://:9050   -F forward+kcp://serverB_ip:9000

# ssh client to connect serverB with ssh.
ssh  user@serverA_ip  -p 9050

When I type code like this,the ssh -vvv says
debug1: Local version string SSH-2.0-OpenSSH_7.4
ssh_exchange_identification: Connection closed by remote host

the gost log seems the server A didn't send kcp request to server B, I'm confused for a long time

This cmd is ok. Please check udp is not blocked. for example:  use kcp on tcp or tls.
./gost -L kcp://:9000/:22?tcp=true
./gost -L tcp://:9050   -F forward+kcp://serverB_ip:9000?tcp=true

This cmd is ok. Please check udp is not blocked. for example: use kcp on tcp or tls.
./gost -L kcp://:9000/:22?tcp=true
./gost -L tcp://:9050   -F forward+kcp://serverB_ip:9000?tcp=true

Thx


Eureka server application

Team i was facing the issue with the rest endpoint when i hitting the URL i was getting the HTML page with login page
Spring version i am using  is 2.1.0.RELEASE
and cloud version Greenwich.RC2 i am new for this  Eureka
Please  provide me a solution for this .
Thank you.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


ci: simplify lint job

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[x] Build or CI related changes
[ ] Tests related changes
[ ] Documentation content changes

@nsbarsukov hello, please review me


Test: ringbuffer: Improving the description for ringbuffer test cases.

The existing testcase's doxygen describes are the general
implementation idea of a function.On this basis, adding
more descriptive statements to describe which conditions need
to be preset when running the testcase, which test techniques are applied,
and describe the testcase Design steps in detail. Make it more readable.
Signed-off-by: Ningx Zhao<EMAIL_ADDRESS>

Is there any other comment? If not, I think it can be merged. It is just doxygen comment change.


Introduction of mitodyn: simulation methods

Private repo Mitochondrial Dynamics

https://github.com/sosiristseng/MitochondrialDynamics/issues/9

closed by ab16c827cda7114c92c67474c524f21a3b42c651


Property access level policies

Hello 👋
Love the new Access Policies + Globals, great addition allowing to skip some access control on the backend side with a clear and concise syntax so thank you 😄
But I don't see anything about a property access policies, is it something planned ?
If that's planned sorry I must have missed it on the roadmap page in the website..., do you have an ETA about this feature now that Access Control is landing in V2 ?
But if that's not planned I think this could be useful for graphql and edgeql_http or just for query to avoid replacing data in backend by just sending a null instead of the data (which could by fantastic coupled with client generation)
There could be a lot of way this is useful but in my case I want to use it when selecting linked user to avoid showing their email by default or for it to be allowable by using a property in User type
Based on the last exemple from here with a new select(.<property>), this could be also added to update policy to allow multi user/tenant update of object without being able to update some property except for object creator
type User {
	required property email -> str { constraint exclusive; };

	multi link friends -> User;
	multi link blocked -> User;
}

type BlogPost {
  required property title -> str;
  link author -> User;

  access policy author_can_modify allow all using (
    global current_user ?= .author.id
  );
  access policy anyone_can_read allow select using (true);
  access policy exclude_blocked deny select using (
  	global current_user ?= .author.blocked.id
  );

	# this is added
	access policy only_current_user_can_see_email deny select(.email) using (
  		global current_user ?= .author.id
    );
}

Linking related discussion https://github.com/edgedb/edgedb/discussions/5447

Any update on this? We would appreciate guidance about any alternative pattern the EdgeDB team recommends.


HADOOP-19284: [Backport 3.4] [ABFS] Allow "fs.azure.account.hns.enabled" to be set as Account Specific Config

Description of PR
Jira: https://issues.apache.org/jira/browse/HADOOP-19284
Making config fs.azure.account.hns.enabled account specific
There are a few reported requirements where users working with multiple file systems need to specify this config either only for some accounts or set it differently for different account.
ABFS driver today does not allow this to be set as account specific config.
This also fixes test that were failing when "fs.azure.account.hns.enabled" config was not present.
How was this patch tested?
Existing tests modified and new tests added.
Test Suite result on HNS OAuth
[WARNING] Tests run: 154, Failures: 0, Errors: 0, Skipped: 2
[ERROR] Tests run: 647, Failures: 0, Errors: 0, Skipped: 82
[ERROR] Tests run: 433, Failures: 0, Errors: 0, Skipped: 58

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.4 Compile Tests _

+1 :green_heart:
mvninstall
32m  1s

branch-3.4 passed

+1 :green_heart:
compile
0m 25s

branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 22s

branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 22s

branch-3.4 passed

+1 :green_heart:
mvnsite
0m 27s

branch-3.4 passed

+1 :green_heart:
javadoc
0m 27s

branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 23s

branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 43s

branch-3.4 passed

+1 :green_heart:
shadedclient
20m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 20s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 12s

the patch passed

+1 :green_heart:
mvnsite
0m 18s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 45s

the patch passed

+1 :green_heart:
shadedclient
20m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 57s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

88m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7076/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7076

JIRA Issue
HADOOP-19284

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f34601ebf2ac 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.4 / 44da465725a7937b1be924d16eec69c1e63ed4e9

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7076/1/testReport/

Max. process+thread count
753 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7076/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


fix: update clap to stable

fixes a compile error with clap beta which changed about -> help.
also updates rust-toolchain to latest stable
addresses #104 and fixes #116

force merging, unrelated ci test config is failing


Toolkit Log Should List Referenced But Undefined Keys

Although there might be situations where it is expected that some keyrefs point to keys that are not defined, it is probably far more frequent that content creators need to know about undefined key references. They can't rely on authoring tools to provide this information because the authoring scope could easily differ from that of publication.
Some closed issues suggest that in the past, the toolkit logged such instances, but recent versions (1.8, 2.0) do not.
It might be desirable to have the option to suppress such logging by a build parameter or to log these as information-only rather than warnings.

I've had a number of my users request this as a way to diagnose missing keys. (They generally assume this should be an error.)

We already have DOTJ047I, doesn't that solve this?

Maybe DOTJ047I could also output the name of the file, where the unresolvable key is defined.

It already does
[keyref] file:/Volumes/tmp/topic.dita:7:45: [DOTJ047I][INFO] Unable to find key definition for key reference "b" in root scope. The href attribute may be used as fallback if it exists

Not sure why I forgot about that current info message - I think over time we've had and removed messages like this.

Yep, the messages are there; I wasn't seeing them for an unrelated reason.


Remove a lot of small vector allocation for lapce_core::syntax::find_tag

Splitted from #1796. That (#1796) pull request is so large it looks like it will never be merged, so I decided to break it down into smaller pieces.
This pull request performs one of the most important parts of improving program performance by changing a function that is constantly called in the program:

removes many unnecessary multiple allocations of vectors (strings) to store one character needed to use the lapce_core::syntax::Syntax::find_matching_pair function.

To do this, I wrote a helper structure to store a single character &str on the stack instead of on the heap (I think this will be a useful structure both now and later).
And well, since this is a structure for storing a "string slice", then it must be done correctly so that it can be compared with other string structures, converted from one structure to another and vice versa, it must have documentation and tests.
The name may not be very good, but I couldn't think of a better one.

Codecov Report

Merging #1841 (83aeed1) into master (7a2f342) will increase coverage by 0.80%.
The diff coverage is 90.21%.

@@            Coverage Diff            @@
##           master   #1841      +/-   ##
=========================================
+ Coverage    6.39%   7.20%   +0.80%
=========================================
  Files         128     129       +1
  Lines       55350   55591     +241
=========================================
+ Hits         3542    4003     +461
+ Misses      51808   51588     -220

Impacted Files
Coverage Δ

lapce-core/src/buffer/mod.rs
67.61% <0.00%> (ø)

lapce-core/src/lib.rs
100.00% <ø> (ø)

lapce-data/src/document.rs
0.00% <0.00%> (ø)

lapce-core/src/char_buffer.rs
91.28% <91.28%> (ø)

lapce-ui/src/app.rs
0.00% <0.00%> (ø)

lapce-ui/src/tab.rs
0.00% <0.00%> (ø)

lapce-rpc/src/lib.rs
33.33% <0.00%> (ø)

lapce-rpc/src/file.rs
0.00% <0.00%> (ø)

lapce-ui/src/title.rs
0.00% <0.00%> (ø)

lapce-data/src/data.rs
0.00% <0.00%> (ø)

... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Hotfix - keyerror in nested metrics converter

This prevents from KeyErrors

This is not needed, as this PR: https://github.com/publichealthengland/coronavirus-dashboard-pipeline-etl/pull/138 has been already merged. It fixed the issue.


support gateways

add support for

name prefix e.g hanafy.gw1.grid.tf given gw1 is controlled by a farmer and hanafy is just the prefix
fqdn domains myveryfinedomain.com is a full domain than can be configured on the gateway

Implemented in #9
Test it tomorrow as nodes are not available today.


Menu coming from bottom

I have just updated version of SideMenu. Before that, it was working completely. But it's not working normal, When i open the menu, it's coming from bottom like any other pages. It's not coming from left side.

Please follow the README carefully.


test-branch/execute-job/wrong-commit-sha-on-pr/ba13d07e-838d-4d14-875d-65f2af8bf7a3

PR for testing a244766160ea0b7c875f4c91fa235cef50700003

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


Rust bindings for substrait.io

Adds initial Rust bindings for substrait. See the README.md for instructions.

@jacques-n @jvanstraten Apologies for the lengthy delay but I have now removed the NVIDIA copyrights.


"Max collateral inputs reached"

I consistently get a Max collateral inputs reached error from Lucid when emulating a wallet via the following:
lucid.selectWalletFrom({
      address: PREVIEW_DATA.addresses.current,
      utxos: [
        {
        txHash:
          "fda5c685eaff5fbb2a7ecb250389fd24a7216128929a9da0ad95b72b586fab70",
        outputIndex: 1,
        assets: { lovelace:<PHONE_NUMBER>5n },
        address:
          "addr_test1qrp8nglm8d8x9w783c5g0qa4spzaft5z5xyx0kp495p8wksjrlfzuz6h4ssxlm78v0utlgrhryvl2gvtgp53a6j9zngqtjfk6s",
      }
      ]
    });

However, this only happens when I try to build a transaction with:
newTx.collectFrom([{
        txHash:
          "0264732a4c82c3f90af79f32b70cf0d108500be9160b3ae036ff21d3cf180798",
        outputIndex: 0,
        address:
          "addr_test1wpesulg5dtt5y73r4zzay9qmy3wnlrxdg944xg4rzuvewls7nrsf0",
        assets: {
          lovelace: 14_500_000n,
        },
        datum:
          "d8799f4103d8799fd8799fd8799fd8799f581cc279a3fb3b4e62bbc78e288783b58045d4ae82a18867d8352d02775affd8799fd8799fd8799f581c121fd22e0b57ac206fefc763f8bfa0771919f5218b40691eea4514d0ffffffffd87a80ffd87a80ff1a002625a0d8799fd879801a00989680d8799f1a00989680ffffff",
        datumHash:
          "48e3160a9a3761f40d71fef4fc45e5381f35f28f7af73c11756ffaeeae6e32c8",
      }], "d87a80");

Any ideas?

Has there been any solution to this, or what is it caused from?


TypeError on ionic state reset

Hi,
just upgraded to the newest version of cli and now when I ran the ionic state reset command I see this issue:
TypeError: Cannot read property 'platforms' of undefined
    at Object.restoreState (/home/dario/.nvm/versions/node/v0.12.2/lib/node_modules/ionic/node_modules/ionic-app-lib/lib/state.js:405:15)
    at Object.resetState (/home/dario/.nvm/versions/node/v0.12.2/lib/node_modules/ionic/node_modules/ionic-app-lib/lib/state.js:747:9)
    at Object.run (/home/dario/.nvm/versions/node/v0.12.2/lib/node_modules/ionic/lib/ionic/state.js:773:13)
    at Object.run (/home/dario/.nvm/versions/node/v0.12.2/lib/node_modules/ionic/lib/cli.js:71:32)
    at Object.<anonymous> (/home/dario/.nvm/versions/node/v0.12.2/lib/node_modules/ionic/bin/ionic:12:10)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3

Cannot read property 'platforms' of undefined (CLI v1.4.0)

Your system information:

Cordova CLI: 5.0.0
Gulp version:  CLI version 3.8.11
Gulp local:   Local version 3.8.11
Ionic Version: 1.0.0-rc.5
Ionic CLI Version: 1.4.0
Ionic App Lib Version: 0.0.16
OS: Distributor ID:	Ubuntu Description:	Ubuntu 14.04.2 LTS
Node Version: v0.12.2

A friend of mine (with os x) has the same problem.
Investigating the stack error I don't undestand why here you pass two parms, here they're ignored but, lastly here there's no checks against the possibility of an undefined value.
There is something that I miss?
Thanks a lot and best regards
Dario

Nice catch! What you're seeing here is - refactoring mistakes out of one project into another.
Patching it now. Thanks for reporting!

No problems! :smile: Good to have spotted for the community.
Thanks again

Patched in 1.4.1 - enjoy!


chore: remove worst log spam offenders

robot-server
A lot of internal middleware was putting pretty verbose logs in both the unit log (i.e. journalctl -u opentrons-robot-server),which I think is reasonable, and to the syslog ident opentrons-api (i.e.journalctl -t opentrons-api), which I think is not. This includes every sql statement the robot server ever makes, every http route interaction...
By adding some handlers that specifically only log to journald without the syslog ident and some that have both, we can tune what goes where. Now,

sqlalchemy output above or at warn will go to the syslog ident, since it's likely to be an issue
sqlalchemy output below warn will go only to robot-server unit logs
http middleware output goes to only robot-server unit logs
general robot_server logs originating from our code go to the syslog ident

Note that when a log "goes to the syslog ident", that's in addition to the unit logs. So if you want to know everything include http messages and such, do journalctl -u opentrons-robot-server and if you want to know just robotics relevant stuff do journalctl -t opentrons-api.
api and hardware
Don't log every dang motion group

Overview

Test Plan

Changelog

Review requests

Risk assessment

For an example of what this does, here's the output of journalctl -t opentrons-api during server startup:
Apr 24 18:01:26 be088a opentrons-api[52694]: API server version: 0.4.0
Apr 24 18:01:26 be088a opentrons-api[52694]: Robot Name: FlexyMCFlexFace
Apr 24 18:01:27 be088a opentrons-api[52694]: /data/robot_settings.json not found. Loading defaults
Apr 24 18:01:27 be088a opentrons-api[52694]: CAN connect: socketcan-can0-500000
Apr 24 18:01:27 be088a opentrons-api[52694]: Application startup complete.
Apr 24 18:01:27 be088a opentrons-api[52694]: Uvicorn running on unix socket /run/aiohttp.sock (Press CTRL+C to quit)
Apr 24 18:01:27 be088a opentrons-api[52694]: Using directory /var/lib/opentrons-robot-server for persistence.
Apr 24 18:01:27 be088a opentrons-api[52694]: Migrated database from schema 1 to version 1
Apr 24 18:01:27 be088a opentrons-api[52694]: Updating instrument model cache
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 32, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: loaded: gripperV1, gripper offset: GripperCalibrationOffset(offset=Point(x=0.0, y=0.0, z=0.0), source=<SourceType.default: 'default'>, status=CalibrationStatus(markedBad=False, source=None, markedAt=None), last_modified=None)
Apr 24 18:01:27 be088a opentrons-api[52694]: Calibrations for P50SV3420230114A02 on LEFT does not exist.
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 96, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: Error response: 503 - LegacyError -
Apr 24 18:01:27 be088a opentrons-api[52694]: loaded: p50_single_v3.4, pipette offset: (0.0, 0.0, 0.0)
Apr 24 18:01:27 be088a opentrons-api[52694]: Calibrations for P50MV3420230329A04 on RIGHT does not exist.
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 112, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: loaded: p50_multi_v3.4, pipette offset: (0.0, 0.0, 0.0)
Apr 24 18:01:27 be088a opentrons-api[52694]: The present devices are now {<NodeId.pipette_left: 96>, <NodeId.gripper: 32>, <NodeId.gantry_x: 48>, <NodeId.gantry_y: 64>, <NodeId.head: 80>, <NodeId.pipette_right: 112>, <USBTarget.rear_panel: -1>}
Apr 24 18:01:27 be088a opentrons-api[52694]: Checking for firmware updates
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 96, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 64, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 32, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 48, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 80, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 112, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for -1, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: No firmware updates required.
Apr 24 18:01:27 be088a opentrons-api[52694]: Updating instrument model cache
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 32, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: Calibrations for P50SV3420230114A02 on LEFT does not exist.
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 96, sha 79db2655 matches and not forced
Apr 24 18:01:27 be088a opentrons-api[52694]: Calibrations for P50MV3420230329A04 on RIGHT does not exist.
Apr 24 18:01:27 be088a opentrons-api[52694]: No update required for 112, sha 79db2655 matches and not forced
Apr 24 18:01:28 be088a opentrons-api[52694]: The present devices are now {<NodeId.gantry_y: 64>, <NodeId.gripper: 32>, <NodeId.gantry_x: 48>, <NodeId.head: 80>, <NodeId.pipette_left: 96>, <NodeId.pipette_right: 112>, <USBTarget.rear_panel: -1>}
Apr 24 18:01:28 be088a opentrons-api[52694]: Done with firmware updates
Apr 24 18:01:28 be088a opentrons-api[52694]: Setting gantry load to GantryLoad.LOW_THROUGHPUT
root@be088a:~# Apr 24 18:01:28 be088a opentrons-api[52694]: Updating the window switch status: open
Apr 24 18:01:28 be088a opentrons-api[52694]: Homing Z axes
Apr 24 18:01:28 be088a opentrons-api[52694]: Homing [<OT3Axis.Z_L: 2>, <OT3Axis.Z_R: 3>, <OT3Axis.Z_G: 4>]
Apr 24 18:01:28 be088a opentrons-api[52694]: Opentrons hardware API initialized
Apr 24 18:01:30 be088a opentrons-api[52694]: Malformed calibrations for P1KSV3420230114A03 on LEFT. Please factory reset your calibrations.
Apr 24 18:01:30 be088a opentrons-api[52694]: Malformed calibrations for P1KSV3420230114A02 on LEFT. Please factory reset your calibrations.

And here's the output of journalctl -u opentrons-robot-server for the same period:
Apr 24 18:01:01 be088a systemd[1]: Starting Opentrons Robot HTTP Server...
Apr 24 18:01:25 be088a python3[52694]: INFO:     Started server process [52694]
Apr 24 18:01:25 be088a python3[52694]: INFO:     Waiting for application startup
.
Apr 24 18:01:25 be088a python3[52694]: /data/robot_settings.json not found. Load
ing defaults
Apr 24 18:01:26 be088a python3[52694]: /data/robot_settings.json not found. Load
ing defaults
Apr 24 18:01:26 be088a opentrons-api[52694]: API server version: 0.4.0
Apr 24 18:01:26 be088a opentrons-api[52694]: Robot Name: FlexyMCFlexFace
Apr 24 18:01:27 be088a opentrons-api[52694]: /data/robot_settings.json not found
. Loading defaults
Apr 24 18:01:27 be088a opentrons-api[52694]: CAN connect: socketcan-can0-500000
Apr 24 18:01:27 be088a opentrons-api[52694]: Application startup complete.
Apr 24 18:01:27 be088a opentrons-api[52694]: Uvicorn running on unix socket /run/aiohttp.sock (Press CTRL+C to quit)
Apr 24 18:01:27 be088a opentrons-api[52694]: Using directory /var/lib/opentrons-robot-server for persistence.
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: BEGIN (implicit)
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: PRAGMA main.table_info("migration")
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: [raw sql] ()
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: PRAGMA main.table_info("protocol")
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: [raw sql] ()
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: PRAGMA main.table_info("analysis")
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: [raw sql] ()
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: PRAGMA main.table_info("run")
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: [raw sql] ()
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: PRAGMA main.table_info("action")
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: [raw sql] ()
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: COMMIT
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: BEGIN (implicit)
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: PRAGMA main.table_xinfo("run")
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: [raw sql] ()
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: SELECT migration.id, migration.created_at, migration.version
                                                                               FROM migration ORDER BY migration.version DESC
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: [generated in 0.00105s] ()
Apr 24 18:01:27 be088a opentrons-api[52694]: Migrated database from schema 1 to version 1
Apr 24 18:01:27 be088a /opt/opentrons-robot-server/uvicorn/__main__.py[52694]: COMMIT
(etc)

It will also get comms logs for can and so on injected in there, it's really the everything log

Yeah absolutely it's a back of mind thing. I think there's a journalctl field for like log source that could be the logger name.


Move image build to proper temp dir

Jenkins was running into a strange issue cleaning up the build.tmp directory, so this creates a proper temp dir and does the building in that instead.

This silently fails:
$ ./build
[+] Building 1.0s (8/8) FINISHED
 => [internal] load .dockerignore                                                                                0.1s
 => => transferring context: 2B                                                                                0.0s
 => [internal] load build definition from Dockerfile                                                                                0.1s
 => => transferring dockerfile: 38B                                                                                0.0s
 => [internal] load metadata for docker.io/library/ubuntu:20.04                                                                                0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 42B                                                                                0.0s
 => CACHED [1/3] FROM docker.io/library/ubuntu:20.04                                                                                0.0s
 => [2/3] RUN git clone https://github.com/intel/sriov-cni --branch v2.3 --depth 1;     cd sriov-cni;     make;     mkdir -p /opt/cni/bin;     cp sriov-cni/build/sriov /opt/cni/bin/sriov;     rm -rf sriov-cni                                                            0.6s
 => [3/3] COPY install-sriov-cni.sh /install-sriov-cni.sh                                                                                0.1s
 => exporting to image                                                                                0.1s
 => => exporting layers                                                                                0.1s
 => => writing image sha256:830eac7b6c23cde6c4e0820940cbc497f0517ec1a6c17976e0882cc58548ce7f                                                                                0.0s
 => => naming to docker.io/library/sriov-cni

Notice how the RUN command only took 0.6s? That's not right. For reference, it takes me ~2 seconds to clone the repository, and ~13 seconds to run make. I can confirm that /opt/cni/bin/sriov is missing from the built image:
$ docker run -it --entrypoint /bin/bash sriov-cni
root@ead17a2a1b66:/# ls /opt/cni/bin
root@ead17a2a1b66:/#

I'm pretty sure that the ubuntu:20.04 image does not include git or make. You would need to install them with apt. Adding those will bloat the image. I'm not a fan of this approach.

Works for me.


Use stdout instead of stderr

Reasoning behind this change:

https://github.com/feross/standard/issues/112#issuecomment-92544684
http://www.jstorimer.com/blogs/workingwithcode/7766119-when-to-use-stderr-instead-of-stdout

Fixes #112.

lgtm!

One quick question: Any reason why you need to put it into verbose mode to get the rule? It would be nice if that was also part of the standard mode since that makes building a checkstyle or json linter no longer dependent on the --verbose flag.

@malandrew That's a different issue from this PR. In short, the vast majority of the time you're going to just fix the lint errors. Overriding an eslint rule is supposed to be extremely rare, so I think it makes sense to hide the eslint rule name behind --verbose in order to keep the output simple. Feel free to open an issue if you want to solicit other opinions.

After I finish write this reporter module, I'll look into that issue. I believe it is only necessary for the checkstyle reporter, since the rule name would be put in the source xml property.
My main reason for giving people the name of the rule, is so they can go look up the documentation on that rule to better understand it.
i.e.: print rule name next to each error and in verbose mode, at the end of linting, print a deduped list of URLs for the documentation of each violated rule so someone can go read the docs and better understand a rule.
But anyways, that's a different issue and I'll open an issue later. This PR is good to go.

:+1:

Released as 3.6.0.


Add cspell

closes #137

Codecov Report

Merging #141 (c9e469c) into master (d4df7ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   95.50%   95.50%
=======================================
  Files          50       50
  Lines        1446     1446
  Branches      421      421
=======================================
  Hits         1381     1381
  Misses         64       64
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4569a82...c9e469c. Read the comment docs.


default random seed not random enough in parallel execution

Is the below snippet the default random seed?
gen.init_genrand((new Date).getTime() %<PHONE_NUMBER>);

If it is it could be unexpected behavior.  Because when executed in parallel the chances of matching initial seeds increases like it did in my app where I executed code in parallel.
My issues were gone when I manually set the seeds with a combination of both a date timestamp and Math.random()
I think the principle of least astonishment here would to make the initial seed collision less likely when running code in parallel such as running selenium browser tests.

If you need high-quality random seeds, I recommend using whatever system-specific random generator is available to you (CryptRandom(), /dev/urand, crypto.getRandomValues(), etc) and initialize using that.
For multiple parallel invocations to share a random seed, each parallel process needs to be created within the same millisecond as the one before it. While that can totally happen, this is not the common case, and even when it happens, it shouldn't break anything.
For the principle of least astonishment, the generator should be seeded by a constant value (such as 1) each time, and the original source of entropy should be entirely left up to the user. So, on the spectrum between:

initialize with 1
initialize with millisecond
initialize with strong system random source
the only way to "please everybody" is to provide three separate options, or to require the user to initialize however they want at all times, neither of which seem like an improvement. I don't think Math.random() is a strong system source, either -- it is not seedable by the user, and there are no guarantees that multiple process won't start out with the same initial seed.


DCT database loses Rule and Results forms on compilation

I'm not sure why just these two are missing - they're in the exported ODP from the source and don't have anything particularly anomalous about their names or security settings.

It's something in the body - if I delete the body content (in encapsulated format), it imports properly.

Ah-hah:
<error source='NotesInputSource' line='97' column='30' id='7059'>picture element is not allowed to have text content</error>
That's a bit odd, since it was exported from the same Notes runtime.
This is also as good a time as any to check for errors in the DXL import log and throw them as exceptions when found.

The trouble here comes from the formatting applied to the output DXL: the trouble is that there can be no text content, not even whitespace, directly within the picture or imageref elements.


Bare minimum upgrade to Orleans 1.5.1

I am not so sure this is necessary for use in Orleans 1.5.x - I think I jumped the gun prematurely.
Anyhow, the work is done and I don't have the heart to just throw it away so I'll let you throw it away for me (or not).

Update several .csproj to target .NET 4.6.1
Update Orleans nugets to 1.5.1
fixups for SerializationManager (not a static class anymore, etc.)
fixup codegen.cs
fixups for TestClusterOptions  (DefaultTraceToConsole is gone)
fixup for test - InconsistentStateException is no longer an InnerException
fixup for static GrainClient = GrainClient.Initialize(...)
TaskDone.Done   -->  Task.CompletedTask

closed via #21


Current Stable Documentation is not Working.

The documentation section that points to stable version is not working. Because it point to an ancient version. This is an issue because it is the version that is linked from the main GitHub page. For new people starting with ACE this is big issue, as it can cause a lot of confusion with non working documentation.
There are two possible fixes

Remove the links to the stable version and have all links point to the developer version.
Tag version to GitHub, which will trigger stable version build for the documentation.

Option 2. is probably the best way, as it does not need anything else than a tag in the repo.

Thank you for bringing this up  -  It's been on my todo list for a long time to sort out the doc builds. Can we discuss later when we meet please?

Only have time for a quick reply, but some of this was deliberate. The "ancient" version is just the ACE1pack with IPFitting, which we've kept alive because some people weren't ready to switch to ACEfit. So the idea was that the stable docs would be those.
But I think it's time to move past that and I agree wholeheartedly with the overall point about making things less confusing for users!

Also agree that we should always tag github releases to coincide with julia releases - that's key for version-specific docs. This is something we can do retroactively

If the two of you want to coordinate setting this up properly, I'll be really grateful. Do you need any additional access for that?

Thanks @tjjarvinen for the PR. At this point I likely won't have time to review it carefully until after the holidays, but do feel free to keep improving things as you see fit and I'm happy to review it all at once then.


Bluesky replies are maybe a bit funny?

I'm not yet sure if this is bridgy related, but it seems when I post replies they look like this: https://bsky.app/profile/singpolyma.net/post/3koasngjcry2f -- which seems to sort of think it is a reply, but I can't see the parent and it doesn't show up on the parent's thread. Though the parent does show it has "one reply" which I expect is mine and in my own feed it shows on the parent. But no link to the parent like I see on other bsky replies. Feels like there might be some subtle different in the metadata.

Hmm! You're right, that does look broken, and the in-reply-to post itself looks fine on bsky.app. Not sure what's going on here.

^ that commit might fix this. I've deployed it, I'll test manually soon, @singpolyma feel free to try yourself in the meantime!

Tested a reply to a reply manually just now, https://bsky.app/profile/snarfed.bsky.social/post/3korkdv3w332b , it looks right and shows the upstream thread. Tentatively closing. Thanks again for reporting!


Remove possible underflow in string buffer encoder

Found an issue with possible underflow in functions ReadStringData and WriteStringData.

I should add, platforms with non-standard size types.


Need to add CSS/JS file first?

Hi,
Do I need to add css file first to use the component?
And how about the interaction part, like the tab, I want to switch the tab, how to implement?
Thanks
Eric Xin

Answer is in the README.


Visualize arrow contributor network

This would need to be scaled up and expanded but something to consider:
library(gh, warn.conflicts = FALSE)
library(dplyr, warn.conflicts = FALSE)
library(tidygraph, warn.conflicts = FALSE)
library(ggraph, warn.conflicts = FALSE)
#> Loading required package: ggplot2

## Simple example
## Additional things to do:
## - ramp up limits
## - explore other orgs like ropensci, r-lib, cran repos on github

## Get some arrow contributors
arrow_contributors_resp <- gh("GET /repos/apache/arrow/contributors", .limit = Inf)
#> ℹ Running gh query
#> ℹ Running gh query, got 100 records of about 400
#> ℹ Running gh query, got 200 records of about 400
#> ℹ Running gh query, got 300 records of about 400
arrow_contributors <- data.frame(
  repo = "arrow",
  arrow_contributors = vapply(arrow_contributors_resp, "[[", "", "login")
)

## let's get some apache repos
apache_repos_resp <- gh(
  "GET /orgs/{org}/repos",
  org = "apache",
  .limit = 40
)
apache_repos <- vapply(apache_repos_resp, "[[", "", "name")

## Get contributors to apache repos
apache_contributors <- lapply(apache_repos, function(repo) {
  contrib <- gh(
    "/repos/{owner}/{repo}/contributors",
    owner = "Apache",
    repo = repo,
    .limit = 300
  )
  data.frame(
    repo_name = repo,
    apache_contributors = vapply(contrib, "[[", "", "login")
  )
}) %>%
  bind_rows()
#> ℹ Running gh query
#> ℹ Running gh query, got 100 records of about 200
#> ℹ Running gh query
#> ℹ Running gh query, got 100 records of about 400
#> ℹ Running gh query, got 200 records of about 400

## join and turn into a tbl_graph
contrib_overlap <- arrow_contributors %>%
  inner_join(apache_contributors, by = c("arrow_contributors" = "apache_contributors")) %>%
  count(repo, repo_name) %>%
  as_tbl_graph()

## plot
ggraph(contrib_overlap, layout = "kk") +
  geom_edge_fan(aes(colour = n)) +
  geom_node_point(aes(fill = name), size = 3)

Something went wonky here. Just opening an issue instead.


Whitelist branches

I like the -f option but it deletes all the remote branches without asking. It would be great to have some whitelisting so I could keep the production branch but still use the -f option.

good idea, will look into it

this is now implemented @raszi

How do you use this? I can't find any flag or something that matches this feature, would like to use it to prevent git-fresh from always deleting master when working on develop which breaks git-flow

@Anahkiasen add the branches you want to keep to .freshignore in the root of the repo

Does it also work with a global ~/.freshignore? It's just to always whitelist master no matter the repository in my case

@Anahkiasen that's a good point, there is no global .freshignore support yet. i'll add an issue for it. for now you'll have to specify a .freshignore for each repo you want to whitelist master in.


Row inclusion formula

Hello, The row inclusion formula is lacking a bit of documentation.
What variables can we use?
Is it possible to filter rows based on the current user?
I would expect someting like "email==user.email" but that does not work

I was looking for the same feature. The only thing which comes close (and actually works for me for the moment) is to use a key to user field and select "LoggedIn" on the "Default search form values when first loaded" page of the view configuration (no row inclusion formula). It works for that one specific use case though (select all rows owned by the current user).

implemented in #1448 - user $user_id to access user id (as indicated in field explainer)


BHBC-1893: Update the Composition and SRB Survey Template

Overview
Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-1893
https://quartech.atlassian.net/browse/BHBC-1880

Description of relevant changes

{List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
Code

[ ] New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
[x] I have avoided duplicating code when possible, moving re-usable pieces into functions
[x] I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
[x] My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
[ ] My code changes account for null/undefined values and handle errors appropriately
[ ] My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

[ ] My code follows the established style conventions
[ ] My code uses native material-ui components/icons/conventions when possible

Documentation

[ ] I have commented my code sufficiently, such that an unfamiliar developer could understand my code
[ ] I have added/updated README's and related documentation, as needed

Tests

[ ] I have added/updated unit tests for any code I've added/updated
[ ] I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

[ ] I have run the linter and fixed any issues, as needed
See the lint commands in package.json
[ ] I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

[ ] I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

What are we doing with the transformations these days? I know we put them on hold before, is that still the case now? Not sure if it came up at all while working through this ticket with Robin

resource page updates (when?)


[BUG]: Is there a better way to deal with data overflow?

🐛 Describe the bug
I used colossalai to train a model on a large dataset.
During training, we find a lot of steps will occur "INFO: Found overflow.".
By default, colossalai will skip this step's updating operation. But it is too expensive for us to skip a lot of steps.
Is there any better way to deal with this?
Or how can we better avoid this warning?
Environment
No response

🐛 Describe the bug
I used colossalai to train a model on a large dataset. During training, we find a lot of steps will occur "INFO: Found overflow.".
By default, colossalai will skip this step's updating operation. But it is too expensive for us to skip a lot of steps. Is there any better way to deal with this? Or how can we better avoid this warning?
Environment
No response
You can use the TorchDDPPlugin for training.


decode-secret adding (MISSING) to client secret when decoding

steps to reproduce
Compare the output from
kubectl -n hmpps-tier-preprod get secrets hmpps-tier -o json | jq ".data.OAUTH_CLIENT_SECRET" -r | base64 -D
and
cloud-platform decode-secret -n hmpps-tier-preprod -s hmpps-tier |  jq ".data.OAUTH_CLIENT_SECRET" -r
I don't want to post the secret in here but the output of the second command is quite different from the first and contains the string
(MISSING)

We reaffirmed we want this feature still, for these reasons

Hi @markreesmoj this is solved indirectly in 1.17.0. I'm fairly certain it was the way we passed a missing error value. A recent refactor solved this.
If it's still a problem, please feel free to re-open or dm me on slack.


Are SAGAN and SNGAN scripts tested?

I have tried to train the SAGAN and SNGAN using the provided scripts, and find the performance grows very slow, e.g., at 10k iteration, they both only have an IS score of around 1.00 and FID around 300, sometimes the FID score will become nan.
I wonder if these two scripts are tested, as I see in the README.md that BigGAN-deep script is not tested but these two are not mentioned.

Problem solved, it turns out to be caused by the dataset directory misplacement.
Closing this issue.


feat(urn): add AzkabanFlow and AzkabanJob urn

Add AzkabanFlow urn to represent an azkaban flow defined on a specific cluster
and inside a project.
Add AzkabanJob urn to represent an azkaban job defined as part of an azkaban
flow.
For more details on Azkaban flow and job see - https://azkaban.readthedocs.io/en/latest/
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

Added typerefs


Build question

Can someone explain what is the aim of having here IdentityServer4.Local.csproj ?
https://github.com/IdentityServer/IdentityServer4/blob/master/src/IdentityServer4/src/IdentityServer4.Local.csproj
The reason I am asking - I upgraded VS.NET (using the latest 2019 VS.NET upgrade) and .NET FWK to 3.1.200 on Windows and started having build issues using this solution - https://github.com/IdentityServer/IdentityServer4/blob/master/src/IdentityServer4/IdentityServer4.sln.
Pretty sure before the upgrade the build on my local Windows was OK.
For some reason VS.NET was keeping downgrading the IdentityServer  Nuget due to IdentityServer4.Storage Referenced there (was keeping reverting to using the preview of IdentityServer4.Storage).
I finally did fix my issue as was done in IdentityServer4.Local.csproj ie referencing the project directly as was done in IdentityServer4.Local.csproj

Very puzzled with the aim of this .Local. file...
Please advise.

Feel free to ignore it. It's an artifact on an experiment I did a while ago - and forgot to delete it.

Thanks, Dominick


The policy listed on this page is too long

File: docker-for-aws/iam-permissions.md, CC @johndmulhausen
Just wanted to make you aware that the policy on this page throws the following error when trying to create:
"An error occurred: Cannot exceed quota for PolicySize: 5120"
I'll sort this out on my own, but since I imagine I need all of these permissions for provisioning Docker on AWS, using your CloudFormation template, I would very much appreciate any help you can provide.
Thank you!

cc @friism @FrenchBen

@cwcoffman Most policies can be broken down into multiple chunks - You can then assign all of the policies to the user.
Typical breakdowns are:

Cloudfront
EC2
DynamoDB + logs + sqs
ELB
Lambda

The permissions are very granular, but can be shrunk via a * if desired.

Thanks so much for the reply.  Really appreciate your time.
On Mon, Aug 14, 2017 at 2:17 PM, French Ben<EMAIL_ADDRESS>wrote:

@cwcoffman https://github.com/cwcoffman Most policies can be broken
down into multiple chunks - You can then assign all of the policies to the
user.
Typical breakdowns are:

Cloudfront
EC2
DynamoDB + logs + sqs
ELB
Lambda

The permissions are very granular, but can be shrunk via a * if desired.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker.github.io/issues/3939#issuecomment-322312437,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALlZ5-nfoH2BVIAFkcntEqJpVx1LqAQWks5sYLlwgaJpZM4OeyhV
.

@FrenchBen Should we break up the policy on the page so that people can easily copy/paste without getting the length error?

I don't have a strong opinion on this. Feel free to do as you see fit.

My opinion - if I had understood policies better at the time, the single
policy would have made sense, and I would have been able to work around the
errors.  I think it is valid to just put a simple, short paragraph
explaining this, and pointing folks to resources for breaking the policy up
if needed.
On Tue, Aug 29, 2017 at 3:53 PM, French Ben<EMAIL_ADDRESS>wrote:

I don't have a strong opinion on this. Feel free to do as you see fit.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker.github.io/issues/3939#issuecomment-325827437,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALlZ50tcfcRA7rWCxAcPA6IbxDZ9wK7Uks5sdJZ8gaJpZM4OeyhV
.

We have info about this in the Cloud docs and can duplicate or link to it from here.

See #3406

If anyone still struggles with that just create role without permissions attached and attach custom inline policy.


DavidPostill: Blacklist hackercombat.com

DavidPostill requests the blacklist of the website hackercombat.com. See the Metasmoke search here and theStack Exchange search here.

The domain only gets 2/2 so far, I'm a bit hesitant but I'll approve if we see one more in a few hours. (Well it's 3/3 because the latest post was reported twice, but it's only really two hits.)

Codecov Report

Merging #1187 into master will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1187      +/-   ##
==========================================
+ Coverage   64.04%   64.22%   +0.17%
==========================================
  Files           6        6
  Lines        1819     1814       -5
==========================================
  Hits         1165     1165
+ Misses        654      649       -5

Impacted Files
Coverage Δ

chatcommands.py
47.87% <0%> (+0.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fd8d1...a85413c. Read the comment docs.

Codecov Report

Merging #1187 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1187   +/-   ##
=======================================
  Coverage   64.04%   64.04%
=======================================
  Files           6        6
  Lines        1819     1819
=======================================
  Hits         1165     1165
  Misses        654      654

Impacted Files
Coverage Δ

globalvars.py
93.33% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febd4e0...bca4ba1. Read the comment docs.

!!/approve


[WIP] Add CloudObject things to RBAC

CloudObjectStoreContainer and CloudObjectStoreObject are missing from the filterer.
It's WIP cause I've no idea if Libor's okay with them in the Network model tests and I need to check block storage still.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1411702
@miq-bot assign @lpichler

@miq-bot add_label bug

that's great that you added test to test cloud tenancy.
can you also add specs for testing when CloudObject* are tagged and RBAC is filtering it correctly ?
thanks !

@miq-bot remove_label wip


Update to latest Creek snapshot

Reviewer checklist

[ ] Read the contributing guide
[ ] PR should be motivated, i.e. what does it fix, why, and if relevant, how
[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage: 98.238%. Remained the same when pulling<PHONE_NUMBER>e45c3a6e8b2c9a8174868135e0f97b on big-andy-coates-patch-1 into 9fc9b1ddb436e504fd537b2111a414c0b5861b9f on main.


Document Breadcrumbs

Purpose / why
We provide "islandora breadcrumbs" - this documents them.
What changes were made?
New page for breadcrumbs, with screenshots, and adding it to the menu.
Verification
Is the text and info correct?
Interested Parties

@Islandora/documentation
@Islandora/committers

Checklist
Pull-request Reviewer
Pull-request reviewer should ensure the following:

[ ] Does this PR link to related issues?
[ ] Does the proposed documentation align with the Islandora Documentation Style Guide?
[ ] Are the changes accurate, useful, free of typos, etc?

Person Merging
The person merging should ensure the following:

[ ] Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
[ ] If pages are renamed or removed, have all internal links to those pages been fixed?
[ ] If pages are added, have they been linked to or placed in the menu?
[ ] Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

now part of https://github.com/Islandora/documentation/pull/2299


Handle file truncation and recreation

Try to handle file truncation or removal. This happens frequently on logfile rotation.

🎖❤⭐⚪⭐💙🎖

Going to do some cleanup on the project and push a new version shortly

v1.1.1 is now available. Let me know if you run into any issues with it.

Already in production. Works fine so far. Many thanks to merge so fast :)


I894 dim labels dim label

#894

@nitsrek can you resolve the conflicts in this one, then let's get it merged.


feat(release): Adds release rc for v2 branch

Bump to major version, in v2 branch.

:tada: This PR is included in version 1.14.0-prerelease.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


getInstance with only string not working

According to the docs https://db-migrate.readthedocs.io/en/latest/API/programable/ this should work: let dbmigrate = DBMigrate.getInstance(true, {cwd: './path/to/database.json'});
Probably because here https://github.com/db-migrate/node-db-migrate/blob/master/api.js#L104 never the type string is checked. Should I do a PR?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Also having database.json at the end of the path throws an error:
Could not find database config file './path/to/database.json/database.json'
Expected behavior: That the last string database.json is not added.

Temporary workaround: let dbmigrate = DBMigrate.getInstance(true, {cwd: './path/to/database.json'});

Don't close it. The issue has not been resolved yet 😄

LGTM, it only defines the path where to search for database.json, stripping database.json when it is there and it really don't exist a folder with that name including a database.json, should probably added.
Wanna create a PR for that?
Logical entrypoint would be either here
https://github.com/db-migrate/node-db-migrate/blob/73904ac162ff72088d5759caeb210719182dc668/api.js#L49-L50
or here
https://github.com/db-migrate/node-db-migrate/blob/master/lib/commands/set-default-argv.js#L4


[Core] AccessTokenCache API

Currently we have a tokenCycler that's internal to core-rest-pipeline and is used in bearerTokenAuthenticationPolicy.  ACR also needs the token cache functionality for its refresh token so it adds  a slightly different copy of tokenCycler.
It would be nice to have some API to support the caching and auto-refreshing of tokens.

[ ] API design
[ ] where would this live

This would be awesome!


[SourceKit] Ignore LLVM arguments in 'compile' request

LLVM arguments processing is a process global state. At this point, there's no way to localize it to a CompilerInstance. For now, ignore any LLVM arguments, so options from another compilation doesn't affect other compilations.
rdar://86809003
along with a couple of bug fixes.

@swift-ci Please smoke test

@swift-ci Please smoke test macOS platform

@swift-ci Please smoke test macOS platform


unpaper: 6.1 -> 7.0.0

Migrates the build to meson and ninja and adds support for ffmpeg 5.
The package now creates a man page that we divert into a dedicated man output.
Adds the paperless test into passthru.tests for good measure.
Description of changes
Moved out of #192249 because this changes breaks gscan2pdf and it makes the other pr less controversial.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020458

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 192510 run on x86_64-linux 1

6 packages built:

gscan2pdf
ocrmypdf (python310Packages.ocrmypdf)
paperless-ngx
pdfsandwich
python39Packages.ocrmypdf
unpaper


[Bug]: A resource XXX has been stopped unexpectedly notification on restart/redeploy from UI

Description
Coolify cloud.
Every time I restart or re-deploy resource to apply the configuration change, all the team gets
"Coolify: A resource has been stopped unexpectedly on XXX" email saying that "A resource XXX has been stopped unexpectedly... "
It's also triggered by a deployment on a Webhook, and (if I remember correctly) for repo-based resources this happens after automatic re-deployments on new commits (i.e. Auto Deploy feature)
Although these are absolutely legitimate reasons to stop. While the email definitely doesn't sound so 😀
Minimal Reproduction (if possible, example repository)

Add a resource
Notifications: subscribe to all the events
Re-deploy or restart

Exception or Error
A resource has been stopped unexpectedly
Version
v4.0.0-beta.284

This is already solved in the latest version. Closing


refactor: pill extractors for saved search

The type of this PR is: Refactor

This PR resolves []
Description

PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have tested my changes on iOS and Android.
[ ] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[ ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ ] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Pill extractors for saved search - dimatretyak

This PR contains the following changes:

Dev changes (Pill extractors for saved search - dimatretyak)

  Generated by :no_entry_sign: dangerJS against 004caf375b5d301f9cd5dc5365089b218af35988


Add safeAfter helper function to Maybe name space

With all those crazy value | undefined or Something | Another | Something Else returning functions in the wild it may be handy to take care of lifting the result of functions into a Maybe based on a some predicate. While safeLift can be used to check an input before calling a function, the typical compose(safe(pred), someFunc) can be replaced with this safeAfter function. It has the following signature:
safeLift :: ((a -> Boolean) | Pred) -> (a -> b) -> a -> Maybe b

This will need the following to be accomplished:

Add code:

[ ] src/Maybe/safeAfter.js

Add specs

[ ] src/Maybe/safeAfter.spec.js

Documentation

[ ] Update ReadMe (src/Maybe/README.md)
[ ] Add to Docs with description and example usage (docs/src/pages/docs/crocks/Maybe.md)
[ ] Add link to Helpers Section (docs/src/pages/docs/functions/index.md)

Expose new functions to public API (src/index.js)

[ ] Entry for safeAfter

Add specs for new public functions (src/index.spec.js)

[ ] Entry for safeAfter

Unless you're already working on this one, I'd be happy to take a stab.

Heck yesh. Sorry I did not add the Add Setoid to the  Monoids. I will add that tomorrow.

A question about the signature here. Shouldn't it be safeAfter :: ((b -> Boolean) | Pred) -> (a -> b) -> Maybe b? Am I missing something here?
Here's how I read it in my head - We execute a function from a -> b, pass b to a predicate, and we get a Maybe b depending on the predicate.

The only thing missing in your signature is the a we need to take in.
But we do not want to bring Pred in and should look something like:
// safeAfter :: ((b -> Boolean) | Pred) -> (a -> b) -> a -> Maybe b
function safeAfter(pred, fn) {
  const predFn =
    isFunction(pred) ? pred : pred.runWith

  return x => {
    const result = fn(x)
    return predFn(result)
      ? Just(x)
      : Nothing()
  }
}

Using the Pred proxy to keep Pred out of core.

After playing with the two options for a bit, I say lets go with the first that only allow unary functions and let the user partially apply up to the last arg. It adds less complexity and gets it in the lib quicker to get usage feedback. If it turns out a lot of people would prefer the second option, then we can add the complexity at that time.
Thoughts?

Sure, I agree with the unary approach - keeps it predictable.

@evilsoft - Also, I'm pretty sure it's a typo, but I just wanted to confirm for good measure - the returned function should be returning Just(result) right (instead of Just(x)).

@karthikiyengar good catch...fixing

This has been completed and merged, will go out in the next release 0.9.1


[Snyk] Security upgrade python from 3.9-slim to 3.13-slim

Snyk has created this PR to fix 5 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

cmd/metricscollector/v1beta1/tfevent-metricscollector/Dockerfile

We recommend upgrading to python:3.13-slim, as this image has only 37 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Integer Overflow or Wraparound SNYK-DEBIAN12-ZLIB-6008963
  500

Integer Overflow or Wraparound SNYK-DEBIAN12-KRB5-1549480
  150

CVE-2024-26461 SNYK-DEBIAN12-KRB5-6277411
  150

CVE-2024-26458 SNYK-DEBIAN12-KRB5-6277412
  150

CVE-2024-26462 SNYK-DEBIAN12-KRB5-6277421
  150

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 72.998%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
3117

Relevant Lines:
4270

💛  - Coveralls


I can't find Field Service >> Customer asset menu

I can't find Field Service >> Customer asset menu, which was guided in the document.

Hi @hyonlim - could you point me to the topic to which you're referring?


feat: abstract legacy code conversion

Bedrock already has one new "legacy" color code, "Minecoin gold". In 1.19.80, there will be a handful of new legacy color codes. The primary goal of this PR is to allow LegacyComponentSerializer usages to take advantage of these new color codes for hex color downsampling. While designing this PR, I also wanted to allow other non-color codes to be modified, since Bedrock doesn't have underscore and obfuscation. We already work around this, however, so this feature is not important to the PR.
For now, I only request feedback on the general structure of the PR. There are several Javadoc and checkstyle errors that I have yet to address until it is agreed upon that the implementation presented here is acceptable. Also, this PR has not yet been tested, for the same reason.

First of all I don't think we should support or add more "legacy color codes". It's legacy because it's outdated and shouldn't be used anymore. New types can be added to MiniMessage with more possibilities and richer formatting.
Imo your changes are limited and adding new types is pretty complicated. A better approach could be an interface (LegacyCodeConverter) which converts the string to a style. E.g.
public interface LegacyCodeConverter {
  /**
   * Convert the text with the legacy char to a format.
   * return: the style, null if no color can be determined.
   */
  TextFormat tagToFormat(final char legacy, final String input, final int pos);

  /**
   * Convert the TextFormat to a message.
   * return: a message, null if the color can't be formatted correctly
   */
  String formatToTag(TextFormat format);
}

This would create a few classes more but you would only need to store a List of Tag types.
But: The more I read that code and think about that topic I disagree on expanding the Legacy Converter logic. Keep it limited, keep it stupid, let's move people to MiniMessage.
My suggested changes are already implemented in MiniMessage (with TagResolvers) and there is no need to manage multiple Converters with the same possibilities.

Implemented kashike's suggestions. I don't think this is optimal, but maybe a step in the right direction. It might actually be possible to completely get rid of LegacyCodeConverterImpl now, but the legacyFormat method needs a home.

Joo's suggestion is also possible, but implementing such a design would have to account for the different hex character styles and whatnot.

I gave this some thought, and I think this could be implemented much more cleanly: https://github.com/Camotoy/adventure/tree/allow-custom-colors-legacy
This removes the LegacyCodeConverter class and has LegacyComponentSerializerImpl process the custom formats.

Superseded by #906.


failed to write "400000" , : invalid argument: unknown

I was trying to setup kubeflow within minikube , but encounter below error for metacontroller pod.
  OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: process_linux.go:508: setting cgroup config for procHooks process caused: failed to write "400000": write /sys/fs/cgroup/cpu,cpuacct/kubepods/burstable/pod50d4853e-0aa4-4d78-90cf-fd576b0a6df9/aff5bac1807a05d65c3f0830e8421c4f6a96eb32172bd79cda7fe542f21d68ea/cpu.cfs_quota_us: invalid argument: unknown

I am setup kubeflow using
while ! kustomize build example | kubectl apply -f -; do echo "Retrying to apply resources"; sleep 10; done

status of pods in kubeflow namespace:
kc get pods -n kubeflow
NAME                                                     READY   STATUS             RESTARTS   AGE
admission-webhook-deployment-f5d8f47f8-b75k4             1/1     Running            0          33m
cache-deployer-deployment-6dbb64ddcd-bld2v               2/2     Running            1          35m
cache-server-79d58845f5-vtft5                            2/2     Running            0          35m
centraldashboard-9846cbb75-ntd8k                         1/1     Running            0          34m
katib-controller-7b98cd6865-b86jv                        1/1     Running            0          34m
katib-db-manager-7f5f684dd5-w9qj2                        1/1     Running            0          34m
katib-mysql-85fc9c74b8-9nd7t                             1/1     Running            0          34m
katib-ui-64fbdf4d94-gmnc9                                1/1     Running            0          34m
kfserving-controller-manager-0                           2/2     Running            0          34m
kubeflow-pipelines-profile-controller-596b896f8d-bnw6w   1/1     Running            0          35m
metacontroller-0                                         0/1     CrashLoopBackOff   9          35m
metadata-envoy-deployment-95b58bbbb-mvlph                1/1     Running            0          35m
metadata-grpc-deployment-c8f784fdf-8nxz4                 2/2     Running            4          35m
metadata-writer-76b6b98985-7ctcr                         2/2     Running            1          35m
minio-5b65df66c9-28g98                                   2/2     Running            0          35m
ml-pipeline-5c5d8f4959-tbkw8                             2/2     Running            1          35m
ml-pipeline-persistenceagent-6ff46967ff-nht7m            2/2     Running            1          35m
ml-pipeline-scheduledworkflow-66bdf9948d-dq8nv           2/2     Running            0          35m
ml-pipeline-ui-57fdfc58cc-qsxhr                          2/2     Running            0          35m
ml-pipeline-viewer-crd-64dddf4597-knwrr                  2/2     Running            1          35m
ml-pipeline-visualizationserver-77b748f8fd-qmwsh         2/2     Running            0          35m
mpi-operator-d5bfb8489-kcq8d                             1/1     Running            0          32m
mxnet-operator-6cffc568b7-5b4hr                          1/1     Running            0          32m
mysql-f7b9b7dd4-5nczv                                    2/2     Running            0          35m
notebook-controller-deployment-7bd85f9f7d-fghwp          1/1     Running            0          33m
profiles-deployment-74b4f94d5c-fsndp                     2/2     Running            0          32m
pytorch-operator-56bffbbd86-bj9jj                        2/2     Running            0          32m
tensorboards-web-app-deployment-59ff4c7bd8-rv5zg         1/1     Running            0          33m
volumes-web-app-deployment-6457c9bcfc-x8n2n              1/1     Running            0          32m
workflow-controller-67bf6d848b-r4tbx                     2/2     Running            1          35m
xgboost-operator-deployment-c6ddb584-8tp6z               2/2     Running            1          32m

describe  pod

$ kc describe pod -n kubeflow metacontroller-0
Name:         metacontroller-0
Namespace:    kubeflow
Priority:     0
Node:         minikube/<IP_ADDRESS>
Start Time:   Fri, 06 Aug 2021 10:50:48 +0800
Labels:       app=metacontroller
              application-crd-id=kubeflow-pipelines
              controller-revision-hash=metacontroller-5d965474c8
              kustomize.component=metacontroller
              statefulset.kubernetes.io/pod-name=metacontroller-0
Annotations:  sidecar.istio.io/inject: false
Status:       Running
IP:           <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  StatefulSet/metacontroller
Containers:
  metacontroller:
    Container ID:  docker://aff5bac1807a05d65c3f0830e8421c4f6a96eb32172bd79cda7fe542f21d68ea
    Image:         metacontroller/metacontroller:v0.3.0
    Image ID:      docker-pullable://metacontroller/metacontroller@sha256:6db16cd0f02fee08641c8f0e7f687be7ec5de9a53ae098d3085fb66b500acded
    Port:          2345/TCP
    Host Port:     0/TCP
    Command:
      /usr/bin/metacontroller
      --logtostderr
      -v=4
      --discovery-interval=20s
    State:          Waiting
      Reason:       CrashLoopBackOff
    Last State:     Terminated
      Reason:       ContainerCannotRun
      Message:      OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: process_linux.go:508: setting cgroup config for procHooks process caused: failed to write "400000": write /sys/fs/cgroup/cpu,cpuacct/kubepods/burstable/pod50d4853e-0aa4-4d78-90cf-fd576b0a6df9/aff5bac1807a05d65c3f0830e8421c4f6a96eb32172bd79cda7fe542f21d68ea/cpu.cfs_quota_us: invalid argument: unknown
      Exit Code:    128
      Started:      Fri, 06 Aug 2021 11:06:11 +0800
      Finished:     Fri, 06 Aug 2021 11:06:11 +0800
    Ready:          False
    Restart Count:  6
    Limits:
      cpu:     4
      memory:  4Gi
    Requests:
      cpu:        500m
      memory:     1Gi
    Environment:  <none>
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-x76bm (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  kube-api-access-x76bm:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason     Age                   From               Message
  ----     ------     ----                  ----               -------
  Normal   Scheduled  18m                   default-scheduler  Successfully assigned kubeflow/metacontroller-0 to minikube
  Normal   Pulled     17m                   kubelet            Successfully pulled image "metacontroller/metacontroller:v0.3.0" in 1m19.353789439s
  Normal   Pulled     13m                   kubelet            Successfully pulled image "metacontroller/metacontroller:v0.3.0" in 3m7.04817341s
  Normal   Pulled     9m31s                 kubelet            Successfully pulled image "metacontroller/metacontroller:v0.3.0" in 4m12.623698649s
  Normal   Pulled     8m8s                  kubelet            Successfully pulled image "metacontroller/metacontroller:v0.3.0" in 58.219338739s
  Normal   Pulling    7m26s (x5 over 18m)   kubelet            Pulling image "metacontroller/metacontroller:v0.3.0"
  Normal   Created    7m24s (x5 over 17m)   kubelet            Created container metacontroller
  Warning  Failed     7m24s (x5 over 17m)   kubelet            Error: failed to start container "metacontroller": Error response from daemon: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: process_linux.go:508: setting cgroup config for procHooks process caused: failed to write "400000": write /sys/fs/cgroup/cpu,cpuacct/kubepods/burstable/pod50d4853e-0aa4-4d78-90cf-fd576b0a6df9/metacontroller/cpu.cfs_quota_us: invalid argument: unknown
  Normal   Pulled     7m24s                 kubelet            Successfully pulled image "metacontroller/metacontroller:v0.3.0" in 2.612507132s
  Warning  BackOff    3m24s (x26 over 13m)  kubelet            Back-off restarting failed container

nodes info

kc get nodes
NAME       STATUS   ROLES                  AGE   VERSION
minikube   Ready    control-plane,master   39m   v1.21.2

version info

 kc version
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.3", GitCommit:"ca643a4d1f7bfe34773c74f79527be4afd95bf39", GitTreeState:"clean", BuildDate:"2021-07-15T21:04:39Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.2", GitCommit:"092fbfbf53427de67cac1e9fa54aaa09a28371d7", GitTreeState:"clean", BuildDate:"2021-06-16T12:53:14Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"linux/amd64"}

BTW, kc is kubectl.

Allocating more resources to minikube solves this problem. e.g.
minikube start \
--cpus 6 \
--memory 12288 \
--disk-size=120g


Multiplication not existing anymore in FactoryGirl on random number

require 'rails_helper'
require 'faker'
require 'support/helpers/global'
include Helpers::Global

FactoryGirl.define do

  factory :admin, :class => User do

  end

  factory :shopkeeper, :class => User do

  end

  factory :customer, :class => User do

    fname                  "Customer"
    lname                  "N#{next_number(:customer)}"
    gender                 random_gender
    username               "Customer#{next_number(:customer)}"
    email<EMAIL_ADDRESS>    password               '12345678'
    password_confirmation  '12345678'
    role                   :customer
    tel                    Faker::PhoneNumber.phone_number
    mobile                 Faker::PhoneNumber.cell_phone
    birth                  rand * Time.now.to_i #"1970-02-12" #random_date

  end

end

I'm trying to get the birth                  rand * Time.now.to_i line to work but this error appears /Users/Loschcode/Google Drive/projects/panda-lo/website/spec/factories/users.rb:28:in block (2 levels) in <top (required)>': undefined method *' for #<FactoryGirl::Declaration::Implicit:0x007fcc32caa700> (NoMethodError)
I tried to find a way around it but it's like the multiplication doesn't exist anymore. I'm using binding.pry to troubleshoot this and there's no error whatsoever ... Only during the test. When i remove this specific line everything works fine.
Am I doing something wrong ?
My test bundle
group :development, :test, :staging, :local do
  gem "factory_girl_rails"
  gem "rspec-rails", "~> 3.0"
  gem "capybara"
  gem "database_cleaner"
  gem "pry-rails"
end

@Loschcode you'll want to wrap the values in { and } so they're recognized as block syntax and evaluated every time the factory is run, e.g.
factory :customer, class: "User" do
  birth { Time.current - (rand 60.years) } # gives you someone between 0 and 60 years old
end

For any interpolation in a factory, you'll want to use the block syntax.
Hope this helps! I'll close this for now, but if you run into issues, don't hesitate to comment on this thread.


How to use chrome extension with esm project?

I have a pet project with native es modules and init Vue not global but in module,
therefore console.log(window.Vue); shows as undefined (and it's ok),
therefore devtools can't detect Vue.js
How can I configure devtools?

Restart browser after installing devtools helped me.