Fix slab size when resetting mutable storable in OrderedMap

Update #335
Changes
Recompute slab size by adding all element sizes instead of using the size diff of old and new element because oldElem can be the same storable when the same value is reset and oldElem.ByteSize() can equal storable.ByteSize().
Given this, size diff of the old and new element can be 0 even when its actual size changed.
Also extracted map data slab prefix computation to a new function.
This is prep work for atree inlining to prevent a bug from surfacing.

[ ] Targeted PR against main branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.04% :tada:

Comparison is base (dda0495) 65.32% compared to head (cc19ec9) 65.36%.

Additional details and impacted files
@@                                        Coverage Diff                                        @@
##           fxamacker/fix-slab-size-when-resetting-same-storable-in-array     #337      +/-   ##
=================================================================================================
+ Coverage                                                          65.32%   65.36%   +0.04%
=================================================================================================
  Files                                                                 14       14
  Lines                                                               8773     8784      +11
=================================================================================================
+ Hits                                                                5731     5742      +11
  Misses                                                              2325     2325
  Partials                                                             717      717

Files Changed
Coverage Δ

map.go
67.54% <100.00%> (+0.09%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


remove servicegraphprocessor

waiting for https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/30149 get merged

@JaredTan95 this should be good to go now


HSEARCH-4317 + HSEARCH-4318 + HSEARCH-4320 Rename mapper-javabean to mapper-pojo-standalone (including APIs) and publish it as an incubating module

HSEARCH-4317: Rename mapper-javabean to mapper-pojo-standalone (including APIs)
HSEARCH-4318: Review mapper-pojo-standalone API, mark as @Incubating if necessary, remove loose ends
HSEARCH-4320: Publish mapper-pojo-standalone as an incubating module

@wklaczynski FYI, this will impact you as there's a bunch of renamed packages/classes. But it's going the direction you want, since we're going to publish the module :)


Stefan problem benchmark

In danaila2014newton, the third benchmark adds both the variable viscosity nonlinearity and the phase-change enthalpy source nonlinearity. Both of these are difficult additions, and since I am currently unsuccessful at reproducing the benchmark, I am trying an example that only introduces the latter. Beyond simply helping us debug this code, the Stefan problem benchmark, especially a 3D analogy, may be a useful contribution, or rather an interesting example application of Danaila's method.
To resolve this issue...

verify against the exact solution, e.g. from Kai's MATLAB script.
explore numerical limits, e.g. high and low Stefan Number. Possibly relate time step size and grid spacing to the Stefan Number.
Attempt adaptive mesh refinement for this 1D problem.

This works on the stefan_problem branch as of 0dc0d4ab263887de9937060a5e09d03827b78cff
The branch still needs to be merged.

When all parameters are set to unity, this looks great!

As we would expect, the differences at later times come from the Stefan Problem effectively having a Neumann boundary condition infinitely far away, rather than a Dirichlet boundary condition at $x = 1$. The difference at time $t = 0.001$ is more interesting, and may be a numerical discretization error.

Test code which verifies the position of the PCI was added in commit e209dc55b89b00eab7a8bd00577622f378df2fcf

Presently this works for Stefan Numbers 1 and 0.1, but fails for 0.01. I began experimenting with the regularization parameters, grid size, and time step size. Now I set those parameters aside, and am focusing on adaptively refining the mesh cells which contain the PCI.
I'm making some good progress on the branch https://github.com/geo-fluid-dynamics/phaseflow-fenics/tree/feature/refine_near_pci
In the following figure (which used $Ste = 1.$), things run well for a while, and then the Newton method fails miserably.

Having not had time to dig into this bug yet, I'm guessing it has to do with how I'm preserving the solution from the most recent Newton iteration, even when the Newton iterations fail to converge and I adaptively refine the mesh (and then continue the Newton iterations).

As of commit d9eacbd76f34aaaa6f528149654d52e2eb11fe0e, adaptive refinement of mesh cells containing the PCI appears to work well in 1D. The following figure is for the outputs of test_stefan_problem_pci_refinement:

The line markers are at mesh vertices. The initial mesh was refined by bisection repeatedly near the hot wall, with the initial temperatures. While integrating in time, whenever the Newton method failed to converge, mesh cells containing the PCI were bisected.

We can handle low Stefan numbers (down to 0.01) as of commit 0b6642dcfd048c621f0ac996e4844d700fe1f743.
The benchmark from danaila2014newton that has been giving me so much trouble used $Ste = 0.045$, so today's progress is quite promising.
Here again is the comparison to the analytical solution:

Now before closing this issue, I want to discuss goals for this benchmark with @julekowalski.

Hi Alex, this indeed looks promising. So what was it in the end?
There is a slight undershoot at the next to the kink at t=0.1. Is this sensitive to the grid resolution?
Regarding the benchmark: Is this solution a cut through a 2d calculation? Or is it solved in 1d? Next thing I would see relevant to do is of this result carries over to general 2d (or maybe even 3d) calculations.
Best, Julia

Getting this to work was a combination of... 1. automatically refining the mesh cells containing the PCI, and 2. playing with the parameters for regularization, time stepping, Newton tolerance, and even the initial spatial grid resolution. Right now I'm completing a test suite where all of this will be clarified.
I haven't tried fixing that undershoot yet; but my first guess is that tightening the Newton tolerance (which should also cause additional grid refinement, using my algorithm) will solve it. So yes, it should be sensitive to grid resolution, though I have not yet directly observed it for this problem. I'll make sure to look into that before closing this issue.
This is a proper 1D formulation. I agree about extending to 2D and 3D. I think I'll move on to the variable viscosity problem before the 3D extension; and I think I'll open a new issue for extending this benchmark to 2D/3D. Do we still call it a "Stefan problem" at that point, or is there a better way to think about the benchmark?

Hi Alex,
the 2d extension will still be a Stefan problem. It's just that we do not have a nice closed analytical solution for it. The viscosity coupling makes sense only in 2d, so a natural order of procedures would be:
2d-Stefan problem mimicking 1d behavior,
a 'real' 2d-Stefan problem, and then
viscosity coupling in 2d
Then we should be able to do the paper ..
Best, Julia

Thanks for the nice summary. So based on our recent conversations, I threw together a quick chart showing a "test matrix" for the capabilities we're aiming for in the scope of my lectures in September (granting that we might not complete everything we wanted):

The amount of blue ink might look daunting, but a lot of that should fill with green quite quickly. The biggest risk right now is getting the variable viscosity to work; but I haven't highlighted it as a problem, since I haven't actually taken any time to properly dissect that component.

The simple 2D Stefan Problem (where the 1D problem is simply extruded in the Y dimension) looks correct for unit Stefan Number. It is taking quite some time to compute lower Stefan Numbers on my laptop. Here's the $Ste = 1$ result:

Note that the mesh becomes quite coarse as the X coordinate increases.

good, try with a different temperature on the right hand side of the domain. Even with the same Stefan number you should see a more clearly distinct 'kink'. You can test this with the exact solution ...
Best, J

As part of this benchmark, we are also exploring the details of the regularization.
Today Julia noticed that the parameters a_s and R_s should really just be a single parameter. So that simplifies things a bit.
As part of this benchmark issue, we're planning to explore how a_s (or R_s), the grid spacing, and the Stefan Number affect convergence of the Newton method. This can be mostly done in 1D; but we should verify that the results extend to 2D.


Dropdown not working when inside lightbox/modal (Venobox/Glightbox)

Describe the bug
When using either Venobox or Glightbox (Also Oxygen Builder w/ WordPress) for a lightbox/popup modal, dropdown fields inside the modal/popup using ChoicesJS do not function.
To Reproduce
Steps to reproduce the behavior:

Install either Venobox or Glightbox
Create a form with a dropdown  field and initialize a new ChoicesJS object on the  field
Create a popup with the form inside and test the dropdown to see the issue

Expected behavior
ChoicesJS dropdown should work inside the popup/modal
Additional context
This is also replicable using WordPress and WPForms with a "Modern" style dropdown that utilizes ChoicesJS. It is not present in other popup plugins and only appears to be an issue with some of these libraries and also the Oxygen Builder for WordPress
Screencast
https://a.supportally.com/VEi06b

The only way i found to get my choices field to work inside my modal is to put the js code inside the modal in .
Gross but works perfectly :x

Hey,
I've created an MCVE at https://github.com/davesalomon/choices-js-modal-problem.
This looks like it's a problem with the way the modal is created; using Venobox, the content is copied into the modal, rather than using the existing (and correctly instantiated) elements. I've tried running the Choices() code in a setInterval to see if simply instantiating on the newly-created elements fixes it, but it thinks it's already done.
Haven't got much time to look in to this atm, but, hopefully this helps someone think of a fix. Using a different modal plugin may fix this, but that'll be down to whichever framework you're using (be that your wordpress theme, etc.)... would be great if it can be fixed within this lib, but I'm not 100% sure it can be.


Refine Itinerary Attraction command test case

Codecov Report

Merging #199 into master will increase coverage by 1.27%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #199      +/-   ##
============================================
+ Coverage     75.79%   77.07%   +1.27%
- Complexity      829      841      +12
============================================
  Files           117      117
  Lines          2595     2595
  Branches        389      389
============================================
+ Hits           1967     2000      +33
+ Misses          527      488      -39
- Partials        101      107       +6

Impacted Files
Coverage Δ
Complexity Δ

...raryattraction/EditItineraryAttractionCommand.java
84.14% <0.00%> (+18.29%)
7.00 <0.00> (+4.00)

...u/address/model/itinerary/ItineraryAttraction.java
73.17% <0.00%> (ø)
12.00% <0.00%> (+1.00%)

...c/main/java/seedu/address/model/itinerary/Day.java
57.50% <0.00%> (+2.50%)
9.00% <0.00%> (+1.00%)

.../java/seedu/address/model/itinerary/Itinerary.java
67.85% <0.00%> (+3.57%)
30.00% <0.00%> (+1.00%)

...ryattraction/DeleteItineraryAttractionCommand.java
100.00% <0.00%> (+9.52%)
10.00% <0.00%> (+1.00%)

...eraryattraction/AddItineraryAttractionCommand.java
96.42% <0.00%> (+42.85%)
11.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316b667...55c2a98. Read the comment docs.


Initialize Sequence Pair using SMT

Example:
constraints = [
    {"constraint": "SymmetricBlocks", "direction": "V", "pairs":
        [["a", "b"], ["c", "d"], ["e"], ["f"], ["g", "h"], ["m", "n"]]},
    {"constraint": "Order", "direction": "top_to_bottom", "instances": ["f", "a", "c", "g", "m", "e"], "abut": True},
    {"constraint": "Order", "direction": "left_to_right", "instances": ["a", "b"]},
    {"constraint": "Order", "direction": "left_to_right", "instances": ["c", "d"]},
    {"constraint": "Order", "direction": "left_to_right", "instances": ["g", "h"], "abut": True},
    {"constraint": "Order", "direction": "left_to_right", "instances": ["m", "n"]}
    ]

Result:
Elapsed time: 0.030 seconds
Sequence pair: fabcdghmen, emgcabdfhn

Another example with abut and 13 blocks (the solver is pretty fast):
constraints = [
    {"constraint": "SymmetricBlocks", "direction": "V", "pairs":
        [["a", "b"], ["c", "d"], ["e"], ["f"], ["g", "h"], ["m", "n"]]},
    {"constraint": "Order", "direction": "top_to_bottom", "instances": ["f", "a", "c", "g", "m", "e"], "abut": True},
    {"constraint": "Order", "direction": "left_to_right", "instances": ["a", "b"]},
    {"constraint": "Order", "direction": "left_to_right", "instances": ["c", "d"]},
    {"constraint": "Order", "direction": "left_to_right", "instances": ["g", "h"], "abut": True},
    {"constraint": "Order", "direction": "left_to_right", "instances": ["m", "n"]},
    {"constraint": "Align", "direction": "h_bottom", "instances": ["a", "b", "o", "p"]},
    {"constraint": "Align", "direction": "v_left", "instances": ["c", "g", "r"]}
    ]

Result:
Elapsed time: 0.017 seconds
Sequence pair: fopabcdghmenr, emnoprgcabdfh

@soneryaldiz I'm not convinced that the sequence pairs generated above (both cases) are correct. They fail when I run though the SAT solving version.
See #1045 for tests. (dev/Experimental/PySat/PERMUTATION.md for instructions.)

Eyeballing the first example: fabcdghmen, emgcabdfhn
{"constraint": "Order", "direction": "top_to_bottom", "instances": ["f", "a", "c", "g", "m", "e"], "abut": True}
=> Satisfied as POS has facgme and NEG has its reflection (emgcaf) as a subsequence
{"constraint": "Order", "direction": "left_to_right", "instances": ["a", "b"]}
=> Satisfied as a is before b in both sequences
{"constraint": "Order", "direction": "left_to_right", "instances": ["c", "d"]}
=> Satisfied as c is before d in both sequences
{"constraint": "Order", "direction": "left_to_right", "instances": ["g", "h"], "abut": True}
=> Satisfied as g is before h in both sequences AND there is no block between g and h in POS sequence.
{"constraint": "Order", "direction": "left_to_right", "instances": ["m", "n"]}
=> Satisfied as m is before n in both sequences

This is one sequence pair that works for me:
    constraints = [
        {"constraint": "SymmetricBlocks", "direction": "V", "pairs":
            [["a", "b"], ["c", "d"], ["e"], ["f"], ["g", "h"], ["m", "n"]]},
        {"constraint": "Order", "direction": "top_to_bottom", "instances": ["f", "a", "c", "g", "m
", "e"], "abut": True},
        {"constraint": "Order", "direction": "left_to_right", "instances": ["a", "b"]},
        {"constraint": "Order", "direction": "left_to_right", "instances": ["c", "d"]},
        {"constraint": "Order", "direction": "left_to_right", "instances": ["g", "h"], "abut": Tru
e},
        {"constraint": "Order", "direction": "left_to_right", "instances": ["m", "n"]}
    ]

    #
    #                       f
    #                  a         b
    #                  c         d
    #                  g    |    h
    #                  m         n
    #                       e

    instances_s = "abcdefghmn"
    pos_s, neg_s = "fabcdghmne", "emgcabdhnf"

I get this when it runs without guidance:
fabcdghmne emghcabndf


Select component: SubmitEvent triggered instead of OnSelect for  <Select<String> ... variant={SelectVariant::Multiple(onchange_category)}>...

...
    let onchange_category = {
        let state = state.clone();
        use_callback(move|category: Vec<String>, state|{
            gloo::console::log!(category.clone().join(","));
            let mut data = state.deref().clone();
            data.categories = category.join(",");
            state.set(data)
        }, state)
    };

   html!{
....
                <FormSection>
                    <FormGroup label="Select Categories">
                        <Select<String> chip={ChipVariant::Values} variant={SelectVariant::Multiple(onchange_category)}>
                                {
                                    for categories_vec.iter().map(|category|{
                                        html_nested!{<SelectOption<String> value={category.to_string()}/>}
                                    })
                                }
                        </Select<String>>
                    </FormGroup>
                    ....
}

Screencast from 06-26-2023 12:38:47 PM.webm
As you can see every time, an item is selected, it is treated as SubmitEvent and a request will be sent to the backend.

Yup, IIRC that was fixed just recently. One of the buttons was missing the type="button" attribute.

Ah now, same issue I guess, but different component: https://github.com/patternfly-yew/patternfly-yew/issues/42

There should be a fix on main (which uses PF5 now) or on release-0.4.x (for PF4).

I have been migrating and I am having to change lots of things. I am not sure if SubmitEvent  not actually works.
For Example:
    let onsubmit = {
        let local_errors = local_errors;
        let (state, dispatch) = (login_state.clone(), dispatch);
        Callback::from(move |event: SubmitEvent| {
            event.prevent_default();
            let state = state.clone();
            let local_errors = local_errors.clone();
            let (email, password, dispatch) = (
                state.email.clone(),
                state.password.clone(),
                dispatch.clone(),
            );
            wasm_bindgen_futures::spawn_local(async move {
                let response = login(&email, &password).await;
                let local_errors = local_errors.clone();
                match response {
                    Ok(response) => {
                        // FIXME: set cookie
                        redirect_page("/pages/display".to_string());
                    }
                    Err(err) => {
                        // web_sys::console::log_1(&JsValue::from_str(&err.description.to_string()));
                            let mut data = local_errors.deref().clone();
                            data.message = err.message.clone();
                            data.description = err.description.clone();
                            local_errors.set(data);

                    }
                }
            })
        })
    };

    html! {
        <>
            <Background />
            {error_handler}
                <Login>
                    <LoginMain>
                        <LoginMainHeader title={title} description="Enter Credentials to login to your account"/>
                            <LoginMainBody>
                                <Form onsubmit={onsubmit}>
                                    <FormGroup label="Email">
                                        <TextInput
                                            required=true name="email" r#type={TextInputType::Email}
                                            value={(*login_state.email).to_string().clone()}
                                            onchange={oninput_email} />
                                    </FormGroup>
                                    <FormGroup label="Password">
                                        <TextInput
                                            required=true name="password" r#type={TextInputType::Password}
                                            value={(*login_state.password).to_string().clone()}
                                            onchange={oninput_password}/>
                                    </FormGroup>
                                    <ActionGroup>
                                        <Button label="log in" r#type={ButtonType::Submit} variant={ButtonVariant::Primary} />
                                    </ActionGroup>
                                </Form>
                            </LoginMainBody>
                        <LoginMainFooter links={links} ></LoginMainFooter>
                    </LoginMain>
                </Login>
        </>
    }

I have been migrating and I am having to change lots of things.

Have you seen this document? Feel free to add or file an issue for anything you think might be missing!

@phill-85 thanks, but I managed to migrate most of the things, there is just an issue with OnSubmit

there is just an issue with OnSubmit

What's the issue?

when the "log in" button is clicked,  the onsubmit callback is not triggered. I could  be missing something, but I have checked and rechecked

I have been migrating and I am having to change lots of things. I am not sure if SubmitEvent not actually works. For Example:
    let onsubmit = {
        let local_errors = local_errors;
        let (state, dispatch) = (login_state.clone(), dispatch);
        Callback::from(move |event: SubmitEvent| {
            event.prevent_default();
            let state = state.clone();
            let local_errors = local_errors.clone();
            let (email, password, dispatch) = (
                state.email.clone(),
                state.password.clone(),
                dispatch.clone(),
            );
            wasm_bindgen_futures::spawn_local(async move {
                let response = login(&email, &password).await;
                let local_errors = local_errors.clone();
                match response {
                    Ok(response) => {
                        // FIXME: set cookie
                        redirect_page("/pages/display".to_string());
                    }
                    Err(err) => {
                        // web_sys::console::log_1(&JsValue::from_str(&err.description.to_string()));
                            let mut data = local_errors.deref().clone();
                            data.message = err.message.clone();
                            data.description = err.description.clone();
                            local_errors.set(data);

                    }
                }
            })
        })
    };

    html! {
        <>
            <Background />
            {error_handler}
                <Login>
                    <LoginMain>
                        <LoginMainHeader title={title} description="Enter Credentials to login to your account"/>
                            <LoginMainBody>
                                <Form onsubmit={onsubmit}>
                                    <FormGroup label="Email">
                                        <TextInput
                                            required=true name="email" r#type={TextInputType::Email}
                                            value={(*login_state.email).to_string().clone()}
                                            onchange={oninput_email} />
                                    </FormGroup>
                                    <FormGroup label="Password">
                                        <TextInput
                                            required=true name="password" r#type={TextInputType::Password}
                                            value={(*login_state.password).to_string().clone()}
                                            onchange={oninput_password}/>
                                    </FormGroup>
                                    <ActionGroup>
                                        <Button label="log in" r#type={ButtonType::Submit} variant={ButtonVariant::Primary} />
                                    </ActionGroup>
                                </Form>
                            </LoginMainBody>
                        <LoginMainFooter links={links} ></LoginMainFooter>
                    </LoginMain>
                </Login>
        </>
    }

when the "log in" button is clicked, the onsubmit callback is not triggered. I could be missing something, but I have checked and rechecked

I have been migrating and I am having to change lots of things. I am not sure if SubmitEvent not actually works. For Example:
    let onsubmit = {
        let local_errors = local_errors;
        let (state, dispatch) = (login_state.clone(), dispatch);
        Callback::from(move |event: SubmitEvent| {
            event.prevent_default();
            let state = state.clone();
            let local_errors = local_errors.clone();
            let (email, password, dispatch) = (
                state.email.clone(),
                state.password.clone(),
                dispatch.clone(),
            );
            wasm_bindgen_futures::spawn_local(async move {
                let response = login(&email, &password).await;
                let local_errors = local_errors.clone();
                match response {
                    Ok(response) => {
                        // FIXME: set cookie
                        redirect_page("/pages/display".to_string());
                    }
                    Err(err) => {
                        // web_sys::console::log_1(&JsValue::from_str(&err.description.to_string()));
                            let mut data = local_errors.deref().clone();
                            data.message = err.message.clone();
                            data.description = err.description.clone();
                            local_errors.set(data);

                    }
                }
            })
        })
    };

    html! {
        <>
            <Background />
            {error_handler}
                <Login>
                    <LoginMain>
                        <LoginMainHeader title={title} description="Enter Credentials to login to your account"/>
                            <LoginMainBody>
                                <Form onsubmit={onsubmit}>
                                    <FormGroup label="Email">
                                        <TextInput
                                            required=true name="email" r#type={TextInputType::Email}
                                            value={(*login_state.email).to_string().clone()}
                                            onchange={oninput_email} />
                                    </FormGroup>
                                    <FormGroup label="Password">
                                        <TextInput
                                            required=true name="password" r#type={TextInputType::Password}
                                            value={(*login_state.password).to_string().clone()}
                                            onchange={oninput_password}/>
                                    </FormGroup>
                                    <ActionGroup>
                                        <Button label="log in" r#type={ButtonType::Submit} variant={ButtonVariant::Primary} />
                                    </ActionGroup>
                                </Form>
                            </LoginMainBody>
                        <LoginMainFooter links={links} ></LoginMainFooter>
                    </LoginMain>
                </Login>
        </>
    }

there is just an issue with OnSubmit

What's the issue?

I think I can reproduce the issue. Need to check the cause and fix.

Yea, I think I know what the issue is. We started to use AttrValue, as recommended by Yew. However using AttrValue with a default will actually create an attribute with an empty string. Which caused some problems already, especially with the form attribute. Which then points to a form with an empty ID. Which doesn't work.
Switching to Option<AttrValue> solved this issue. And I guess we need to check all the places for exactly that.

This should be fixed with c33dcb697fbf6d8217db30294a849f607d743629


Style inline images as blocks with a border

Closes #2358 using styles only. Maybe we can consider use of a render hook later.
Ensures that image elements in markdown are treated as block-level elements
Adds a light border around images, which is necessary (in most cases) when the image background is white. The border around barker images isn't a problem in general.
Supports an easy way to declare that an image:

Shouldn't have a border by adding {.border-0} after an image. There's an example of this in the PR.
Isn't a figure, by using the img-initial  class.

Closes #2271

Preview:

https://deploy-preview-2359--opentelemetry.netlify.app/blog/2022/otel-demo-app-nomad/#4--see-it-in-nomad - illustrates how most images benefit from a border. This was also the target of #2271
https://deploy-preview-2359--opentelemetry.netlify.app/blog/2022/why-and-how-ebay-pivoted-to-opentelemetry/ - shows inline images without borders
https://deploy-preview-2359--opentelemetry.netlify.app/docs/instrumentation/cpp/ - for the inline image in the description
https://deploy-preview-2359--opentelemetry.netlify.app/docs/concepts/data-collection/#components - more inline images

Screenshots
Before:

After:

LOL, thanks for the review and approval @cartermp! ✨


SPK introspection backend needs to be deployable

As a: developer
I want: to run the backend and front end for the dashboard
So that: I can launch Spektate
Describe the solution you'd like:
As the work for https://github.com/microsoft/bedrock/issues/980 is almost complete, the following needs to be done before it's ready to merge:

[ ] New backend should be built as part of CI
[ ] Create Dockerfile for backend and make it part of the pipeline
[ ] Write/Update documentation on how to start dashboard with these changes
[ ] spk dashboard command should use the new setup
[ ] spk cli should consume the changes made to spektate package as part of https://github.com/microsoft/bedrock/issues/980

Acceptance Criteria:
Changes to spektate to bring in back end have been completed
Describe alternatives you've considered:
Consider the possibility of keeping the current implementation in place until this is finished
Additional context:
https://github.com/microsoft/bedrock/issues/938
Does this require updates to documentation?:
Yes

Please split this into a smaller tasks


gRPC: Use the playground to perform full integration testing of all new instrumentation

The new gRPC playground app should be used (with updates if necessary) to fully test the following:

instrumented client methods
instrumented server methods
distributed tracing

Resolved with the current state of the grpc branch


hobbes: fix build

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Not sure if we should backport this. I guess the package in the release is broken, so a version upgrade is probably the only way to unbreak it.


feat: add thor tradable asset script

Description
Adds a script to dynamically generate the mapping from thor asset notation to CAIP-19.
yarn generate:thor-asset-map
We currently maintain a hardcoded object for this, but we should make this more dynamic.
We opted to make this a generation script, rather than a run-time conversion for safety, and to give us the chance to sanity check any changes/new assets.
An assets trade status, however, is still checked at runtime.
Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
N/A, quality of life.
Risk
Small. If something went wrong with the generation we'd simply not be able to trade to or from the assets via THORSwap, or use them in THORSavers.
This should be easy to check at runtime.
Testing

Check all thor-tradable assets are still apperaing as expected
Check all THORSaver assets are still appering as expected

Engineering
☝
Note, we lost a few unsupported Etherum assets, and gained some, so the actual generated list varies slightly from the hardcoded one.
Also note, we do not currently parse BNB or native THOR assets, and so running the generation script will show these as un-parsable (this is fine).
Operations
☝
Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4678   👈

This comment was auto-generated by Graphite.


Nested grid not retaining the relative position in vertical mode

Thank you for sharing this good work - it is very helpful. The bootstrap style of responsiveness is very useful and the nested grids help implement very useful functions such as row or inner columns etc. (like col-xs inside col-md etc..). However, there seems to slight problem with it in the present state.
For example, for the demo at http://troolee.github.io/gridstack.js/demo/nested.html when the outer grid is resized with mouse, it works great (and the inner grid items retains their relative positions and sizes). But when the browser is resized to be small, all widgets (including those inside at the inner levels) collapse to single vertical line (thus no more respecting the inner-outer hierarchy).
In the vertical mode, only the outer widget should become part of vertical line of widgets, while the "inner widgets still keep their relative positions and size" inside it. I believe the purpose of outer widget is to protect the inner levels from loosing their relative positions.
If the present behavior (of making all equal width irrespective of inner-outer) is intention and by design, then at least there should be an option (something like, "retain inner structure" or "protect inner grid") which when set to true, the inner grids will retain their relative position and size irrespective of their parents.

You can achieve that behaviour by disabling one-column mode for nested grids.


When a branch is created , automatically create a WIP PR / MR

Maybe we can extract something from the branch name .
If the newly created branch is feature/blablabla we can maybe create a PR/MR named WIP: blablabla

No WIP PR allowed in Github => "No commit between source and target"


Proofread tut - add a pallet

@sacha-l @NukeManDan

@NukeManDan most issues addressed. Some I would suggest to defer addressing them until docs.substrate.io is launched.

@sacha-l @lsgunnlsgunn Thanks for the review and committed most suggestion into this PR.
I would suggest updating the tutorial name to Add Nicks Pallet to the Runtime, and changes all three files as you pointed out.


Fix bad usage on assertEquals and translate

I translated all the Chinese comments and corrected the improper use of assertEqual.

LGTM, thx for your contributions.
Hav a nice day!


[stdlib] Fix punctuation in doc comment

@PatrickPijnappel Why do you think removing the period is helpful for the reader?

Well, it's correct:

Requires: isOrderedBefore is a strict weak ordering. over self.

Becomes:

Requires: isOrderedBefore is a strict weak ordering over self.

I see!  Sorry for the confusion!


ID-3803: Delete PUT status endpoint for user.

Deleted PUT status endpoint along with some code that only this was using.

Må hugse å ikkje ta den vidare ut før datavask er ferdig rulla ut


Add Windows test runners

Codecov Report

Merging #28 (dfa397a) into main (3056e8d) will decrease coverage by 3.12%.
The diff coverage is 47.76%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   70.97%   67.85%   -3.13%
==========================================
  Files          39       41       +2
  Lines        1592     1711     +119
  Branches       92      104      +12
==========================================
+ Hits         1130     1161      +31
- Misses        420      509      +89
+ Partials       42       41       -1

Impacted Files
Coverage Δ

...ithub/ascopes/jct/assertions/DiagnosticAssert.java
0.00% <ø> (ø)

...assertions/DiagnosticCollectionRepresentation.java
20.00% <ø> (ø)

...b/ascopes/jct/assertions/DiagnosticListAssert.java
100.00% <ø> (ø)

...copes/jct/assertions/DiagnosticRepresentation.java
0.00% <0.00%> (ø)

...hub/ascopes/jct/assertions/OptionalPathAssert.java
17.07% <0.00%> (ø)

...opes/jct/assertions/PathLocationManagerAssert.java
100.00% <ø> (ø)

...a/io/github/ascopes/jct/compilers/Compilation.java
100.00% <ø> (ø)

...ithub/ascopes/jct/compilers/CompilerException.java
100.00% <ø> (ø)

...ava/io/github/ascopes/jct/compilers/Compilers.java
100.00% <ø> (ø)

...ub/ascopes/jct/compilers/ForwardingDiagnostic.java
100.00% <ø> (ø)

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc1bbf...dfa397a. Read the comment docs.


Find a Generic Solution to the "Unknown Fields Handling" Problem

without using generics (cause we need to use go 1.16)
without duplicating tons of code

solved in #102


ModuleNotFoundError: No module named 'win32api'

OBS version 28.0.2
[zoom_and_follow_mouse.py] Traceback (most recent call last):
[zoom_and_follow_mouse.py]   File "C:/Program Files/obs-studio/data/obs-plugins/frontend-tools/scripts\zoom_and_follow_mouse.py", line 9, in
[zoom_and_follow_mouse.py]     import pywinctl as pwc # version >=0.0.38
[zoom_and_follow_mouse.py]   File "C:\Users\hp\AppData\Local\Programs\Python\Python36\lib\site-packages\pywinctl_init_.py", line 673, in
[zoom_and_follow_mouse.py]     from ._pywinctl_win import (
[zoom_and_follow_mouse.py]   File "C:\Users\hp\AppData\Local\Programs\Python\Python36\lib\site-packages\pywinctl_pywinctl_win.py", line 13, in
[zoom_and_follow_mouse.py]     import win32api
[zoom_and_follow_mouse.py] ModuleNotFoundError: No module named 'win32api'
I already tried pip install pypiwin32 and python Scripts/pywin32_postinstall.py -install

Not the repo owner / contributor, but looks like a pywinctl issue.
What is the version of pywinctl installed, i.e. the output of the following in Command Prompt:
python
import pywinctl
pywinctl.__version__
quit()

The instructions on the pywinctl repo state that you can use the --force-reinstall flag to ensure dependencies are updated:

Not the repo owner / contributor, but looks like a pywinctl issue.
What is the version of pywinctl installed, i.e. the output of the following in Command Prompt:
python
import pywinctl
pywinctl.__version__
quit()

The instructions on the pywinctl repo state that you can use the --force-reinstall flag to ensure dependencies are updated:

Thank you! It's fixed now. I did see the instructions before but first I didn't direct my cmd path to my download folder since the PyWinCtl-0.0.39-py3-none-any.whl was there and didn't use --force-reinstall


How can i set width of columns?

I am unable to add width to columns. Can someone help me with this?

If you are using bootstrap applying col-md / col-sm etc.. will solve your problem. IF you are not using dynamic columns. In that case you need to implement a service/function which calculates the values.
If I can recall correctly you can use sub whole numbers as well like 0.5 etc.


Field Array Validation Example broken

Describe the bug
The field array validation/error reporting example is broken. I would need this example to investigate why the validation errors for my own field array form are not reported in the errors object.
https://codesandbox.io/s/react-hook-form-fieldsarray-yup-validation-min-length-k87iy

Sorry, as part of the code examples:
https://github.com/react-hook-form/react-hook-form/tree/master/examples


west.yml: update open-amp SHA

Bring in a small build system change:
https://github.com/zephyrproject-rtos/open-amp/commit/9b591b289e1f37339bd038b5a1f0e6c8ad39c63a

Bring in a small build system change:

ok, this should be fine I guess, but we have merged a change into the open-amp tree without running it through CI. Per the documentation we wanted the change to the module to be verified with the rest of the tree before it gets merged into the module tree.
Next time I guesss...

Next time I guesss...

Will do.

@nashif this has passed CI. Sorry about doing this in the wrong order.

This is funny, I just came here looking for some "role-modelling". Next!


Add documentation for GoogleApiHelper#getSafeAutoManageId() and do a teeny bit of cleanup in the auth README

@samtstern I recently added Firebase app indexing to my app and noticed that it was crashing if I tried to sign in or out. Turns out I was duplicating enableAutoManage ids with FirebaseUI so I think we should make GoogleApiHelper#getSafeAutoManageId() part of the public api so people can use it to get around this problem.

Hey @SUPERCILEX I don't think this should be part of the public API for a few reasons:

It's tangential to our library's core function, so if this was a pattern we wanted people to use we'd do better to just publish a snippet somewhere (Github Gist, StackOverflow, etc)
It's really just wrapping AtomicInteger, so we're not providing much value
The GoogleApiClient engineers made a decision to not just auto-increment IDs internally so that users would have to track their clients, so while for us this pattern works it's not something we want everyone to do without thinking.

Gonna close this one since the other README fixes can be part of another PR, hope that makes sense!

@samtstern your arguments totally make sense on not making it part of the public API, but as a counter proposal I think we should at least start the atomic integer with a value of 10 or something. What do you think? This should remove the need for devs to use getSafeAutoManageId() because we don't start with the default ID anymore. Also, I didn't think about this but we weren't using auto manage before so this is technically breaking backwards compatibility.


Use go mod to vendor dependencies

Coverage remained the same at 88.276% when pulling 8cd4b065407b8c159335775dbe6d947ff26fe2e4 on go-modules into 2cbeff069fd3f8af752fb09b89fa2ee9bdfbc4f5 on master.

Coverage remained the same at 88.276% when pulling 8cd4b065407b8c159335775dbe6d947ff26fe2e4 on go-modules into 2cbeff069fd3f8af752fb09b89fa2ee9bdfbc4f5 on master.

Coverage remained the same at 88.276% when pulling 8cd4b065407b8c159335775dbe6d947ff26fe2e4 on go-modules into 2cbeff069fd3f8af752fb09b89fa2ee9bdfbc4f5 on master.


How long was the new published model trained for?

How long is the newly published model trained for? The published model with 256 channels. Is it approximately same as the old one, i.e. 580K iterations?

https://github.com/NVIDIA/waveglow/issues/75#issuecomment-455057822


Wrong translation for month shortcut RO

In file
angular-locale_ro-ro.js and
angular-locale_ro-md.js
short version of November is "nov.", but Romanian name for November is "noiembrie", so a shortcut for this month should be rather "noi." than "nov."
Regards
kplogo

Hi, AngularJS uses the Google Closure I18N library to generate its own I18N files (the ngLocale module). This means that any changes to these files would be lost the next time that we import the library. Since the Closure library i18n data is itself auto-generated from the data of the Common Locale Data Repository (CLDR) project, errors in the data should be reported there. See also the Closure guide to i18n changes.


Auto Refresh for the Connector

Description
Currently, the createConnector API already allows quite a few option, but it misses a way to (automatically) invalidate the data (e.g., after a certain time).
Background
In case of the simplest possible call data is lazy loaded, but that data will remain "valid" forever. Naturally, such data should be marked invalid when the user has it too long.
There are two options:

Time when to look if the data is invalid
A function to check if the data is invalid

The default time is infinite. As such the data would never be checked for being invalid. A time of 0 would check always when the user accesses the data. Any other time would be managed via a setTimeout that is initiated once the data was loaded.
The default checker function is () => true, i.e., the data is always found invalid when checked. This can work nicely together with a WebSocket in case we don't want to re-render immediately when something changed.
Both options can be set independently even though the second option makes only sense if the first one has been set explicitly (to whatever value).
Discussion
Should they really be two separate options? Can this be done in one option? How is the time then coming in?
I see the value, but I have doubts regarding the management aspects. Maybe the returning HOC should have a property instead, e.g.,
const connect = api.createConnector(...);
const ConnectedPage = connect(Page);
const tid = setTimeout(() => {
  connect.invalidate();
}, 30 * 1000);

Problem with this approach is that the 30 seconds always start - and not just when the page was accessed. Can be done, of course, but now requires more implementation effort...

Regarding the discussion started above: Right now I tend to believe that this is in fact the only true way forward.
Why? Adding other options will result in a bloat that will make it hard to select the right options. Furthermore, we will anyway never provide the right options for what users actually want.
As a result having a invalidate function on the connect HOC we can do all that, potentially implicit in the callback (connect)!
To simplify even more, why not also return the callback currently passed into the connect functionality?
So instead of
const connect = api.createConnector(...);
const ConnectedPage = connect(Page);
const tid = setTimeout(() => {
  connect.invalidate();
}, 30 * 1000);

we could go for
const connect = api.createConnector({
 // ...
 connect(cb, invalidate) {
   const tid = setTimeout(invalidate, 30 * 1000);
   return () => clearTimeout(tid);
 }
});
const ConnectedPage = connect(Page);

And (sometimes) useful:
const connect = api.createConnector(...);

setTimeout(() => {
  connect.update({ /* ... */ });
}, 10000);

const ConnectedPage = connect(Page);

Problem with the last one: where is update applied if nothing is yet loaded / connected? Should we just discard it? Should we emit an error? So maybe this is for another issue with a more conclusive discussion...

Landed in develop and is available in the preview.


node-red-contrib-viseo-google-spreadsheet : Problem installing

Hello,
I installed google-spreadsheet together with node-red-contrib-viseo-google-authentication. I can drag the node into the flow and configure it. Bit when I try to deploy my flows I get this message:
The workspace contains some unknown node types:
google-spreadsheet
Are you sure you want to deploy?

or
Flows stopped due to missing node types.
google-spreadsheet

What am I doing wrong?
Using node-red V0.18.04 on a raspberry pi 3 with raspbian stretch with latest updates. Installed the node via UI: settings/palette/install
Thank you for your help.
Chris

The current version of the google spreadsheet node is broken.
When trying to load it, you get:
SyntaxError: Unexpected token )

The Node-RED palette manager shouldn't have added it to the palette in this case (so we need to look at that part in Node-RED), but the fundamental issue is the node is broken and cannot load.

Thank you for your reply. Sad to hear this. This feature could be verry handy or even essential for my current project.
Can I expect a fix in the near future?
Christian

Same problem, would be great with a fix for this.

Hi everyone,
I don't have this problem on my project. Are you working with the 0.2.9. version? I'll try to fix it today.

Just to answer the question, Yes:
Welcome to Node-RED
13 Apr 12:21:27 - [info] Node-RED version: v0.18.4
13 Apr 12:21:27 - [info] Node.js  version: v6.13.1
13 Apr 12:21:27 - [info] Linux 4.9.87-linuxkit-aufs x64 LE
13 Apr 12:21:27 - [info] Loading palette nodes
13 Apr 12:21:28 - [warn] ------------------------------------------------------
13 Apr 12:21:28 - [warn] [node-red/rpi-gpio] Info : Ignoring Raspberry Pi specific node
13 Apr 12:21:28 - [warn] ------------------------------------------------------
13 Apr 12:21:28 - [info] Settings file  : /data/settings.js
13 Apr 12:21:28 - [info] User directory : /data
13 Apr 12:21:28 - [warn] Projects disabled : set editorTheme.projects.enabled=true to enable
13 Apr 12:21:28 - [info] Flows file     : /data/flows.json
13 Apr 12:21:28 - [info] Creating new flow file
13 Apr 12:21:28 - [info] Server now running at http://<IP_ADDRESS>:1880/
13 Apr 12:21:28 - [info] Starting flows
13 Apr 12:21:28 - [info] Started flows
13 Apr 12:22:30 - [info] Installing module: node-red-contrib-viseo-google-spreadsheet, version: 0.2.9
13 Apr 12:22:37 - [info] Installed module: node-red-contrib-viseo-google-spreadsheet
13 Apr 12:22:38 - [info] Added node types:
13 Apr 12:22:38 - [info]  - node-red-contrib-viseo-google-spreadsheet:google-spreadsheet : SyntaxError: Unexpected token )
13 Apr 12:50:15 - [info] Stopping flows
13 Apr 12:50:15 - [info] Stopped flows
13 Apr 12:50:15 - [info] Waiting for missing types to be registered:
13 Apr 12:50:15 - [info]  - google-spreadsheet

Thank you Mikehole! Could you tell me your version of ""node-red-contrib-viseo-google-authentication"?

Hi,
Same problem for me:
Apr 13 23:20:29 raspberrypi3 Node-RED[25822]: 13 Apr 23:20:29 - [warn] ------------------------------------------------------
Apr 13 23:20:29 raspberrypi3 Node-RED[25822]: 13 Apr 23:20:29 - [warn] [node-red-contrib-viseo-google-spreadsheet/google-spreadsheet] SyntaxError: Unexpected t
Apr 13 23:20:29 raspberrypi3 Node-RED[25822]: 13 Apr 23:20:29 - [warn] ------------------------------------------------------
Apr 13 23:20:29 raspberrypi3 Node-RED[25822]: 13 Apr 23:20:29 - [info] Settings file  : /home/pi/.node-red/settings.js
Apr 13 23:20:29 raspberrypi3 Node-RED[25822]: 13 Apr 23:20:29 - [info] User directory : /home/pi/.node-red
Apr 13 23:20:29 raspberrypi3 Node-RED[25822]: 13 Apr 23:20:29 - [warn] Projects disabled : set editorTheme.projects.enabled=true to enable
Apr 13 23:20:29 raspberrypi3 Node-RED[25822]: 13 Apr 23:20:29 - [info] Flows file     : /home/pi/.node-red/flows_raspberrypi3.json
Apr 13 23:20:29 raspberrypi3 Node-RED[25822]: 13 Apr 23:20:29 - [info] Server now running at http://<IP_ADDRESS>:1880/
Apr 13 23:20:29 raspberrypi3 Node-RED[25822]: 13 Apr 23:20:29 - [info] Waiting for missing types to be registered:
Apr 13 23:20:29 raspberrypi3 Node-RED[25822]: 13 Apr 23:20:29 - [info]  - google-spreadsheet
Hope this helps or let me know if you need any other logs.
/ Jonas

On 16 Apr 2018, at 13:07, Klervi<EMAIL_ADDRESS>wrote:
Thank you Mikehole! Could you tell me your version of ""node-red-contrib-viseo-google-authentication"?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/NGRP/node-red-contrib-viseo/issues/85#issuecomment-381563249, or mute the thread https://github.com/notifications/unsubscribe-auth/ADIynYcdR6IUpVZxBPSWRqoo5rsR1luTks5tpHuGgaJpZM4TH7-8.

here is a log from a brand new nodered container:
Welcome to Node-RED
16 Apr 11:33:33 - [info] Node-RED version: v0.18.4
16 Apr 11:33:33 - [info] Node.js  version: v6.13.1
16 Apr 11:33:33 - [info] Linux 4.9.87-linuxkit-aufs x64 LE
16 Apr 11:33:34 - [info] Loading palette nodes
16 Apr 11:33:34 - [warn] ------------------------------------------------------
16 Apr 11:33:34 - [warn] [node-red/rpi-gpio] Info : Ignoring Raspberry Pi specific node
16 Apr 11:33:34 - [warn] ------------------------------------------------------
16 Apr 11:33:34 - [info] Settings file  : /data/settings.js
16 Apr 11:33:34 - [info] User directory : /data
16 Apr 11:33:34 - [warn] Projects disabled : set editorTheme.projects.enabled=true to enable
16 Apr 11:33:34 - [info] Flows file     : /data/flows.json
16 Apr 11:33:34 - [info] Creating new flow file
16 Apr 11:33:34 - [info] Server now running at http://<IP_ADDRESS>:1880/
16 Apr 11:33:34 - [info] Starting flows
16 Apr 11:33:34 - [info] Started flows
16 Apr 11:34:18 - [info] Installing module: node-red-contrib-viseo-google-authentication, version: 0.0.6
16 Apr 11:34:23 - [info] Installed module: node-red-contrib-viseo-google-authentication
16 Apr 11:34:24 - [info] Added node types:
16 Apr 11:34:24 - [info]  - node-red-contrib-viseo-google-authentication:google-service-account
16 Apr 11:34:24 - [info]  - node-red-contrib-viseo-google-authentication:google-api-key
16 Apr 11:34:44 - [info] Installing module: node-red-contrib-viseo-google-spreadsheet, version: 0.2.9
16 Apr 11:34:49 - [info] Installed module: node-red-contrib-viseo-google-spreadsheet
16 Apr 11:34:49 - [info] Added node types:
16 Apr 11:34:49 - [info]  - node-red-contrib-viseo-google-spreadsheet:google-spreadsheet : SyntaxError: Unexpected token )
These nodes are being added via the pallet management UI. Hope this helps.

I have the issue on docker by the way I am using the node red official container:
https://hub.docker.com/r/nodered/node-red-docker/

I've had a quick look at the error and identified the problem. This node requires node.js 8.x. It will not work with any earlier version of node.js.

Ah that's a pain there was me thinking that the docker image would be up to date when it comes to node.

Hi,
This is some more info on the system I’m running.
Raspberry Pi 3 with Raspbian Stretch
/ Jonas
Sent from my MacBook Pro
(m) +46 70 793 26 09
(e<EMAIL_ADDRESS>
On 18 Apr 2018, at 17:23, Klervi<EMAIL_ADDRESS>wrote:
We will receive a Raspberry in a few days, and so be able to reproduce this bug (no problem with linux/windows)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/NGRP/node-red-contrib-viseo/issues/85#issuecomment-382425981, or mute the thread https://github.com/notifications/unsubscribe-auth/ADIynZhGO5RI8O8kladWT2nVbfodoV4Hks5tp1qGgaJpZM4TH7-8.

We do publish node 8 images - https://github.com/node-red/node-red-docker#images - but the default images are still 6. We will be switching over at some point in the future, but can't just switch them as its a major version change.

Yes, so after switching to Node 8 I do get the node to load on the Raspberry Pi.
First it then complained about not having a scope, so added https://www.googleapis.com/auth/cloud-platform to the security configuration. Then it tried to load data but gave another error, it seems that it's somehow builds the URL incorrectly.
Looks like it tries to build the URL by combining the parameter from the node with parts of the REST api version url.
(I've changed the id of the spreadsheet when posting here.)
sheet | "https://docs.google.com/spreadsheets/d/1234567890/edit#gid=0"
The error message from Google is :
404. That’s an error.
The requested URL **/v4/spreadsheets/**https://docs.google.com/spreadsheets/d/1234567890/edit was not found on this server.  That’s all we know.

Hi @sejbk,
Please read our documentation in Node Red info tab. All the fields are described.

Hello,
updating node.js and npn no errors on deployment. But I get the same error as @sejbk
23 Apr 12:24:00 - [warn] [google-spreadsheet:Test1] Error: <!DOCTYPE html>

  <meta charset=utf-8>
  <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
  <title>Error 404 (Not Found)!!1</title>

404. That’s an error.

The requested URL /v4/spreadsheets/https://docs.google.com/spreadsheets/d/1T-TRHrbLECIrQNVrVxDQe49MSATSc2ysRT9H0adq7h8/edit was not found on this server.  That’s all we know.

Copy paste https:// [....] /edit bings be to the desired spreadsheet.
I thing i did all configurations right.

Hi there!
In the node's configuration, you should enter the spreadsheet's ID for the 'ID' field, which is only '1T-TRHrbLECIrQNVrVxDQe49MSATSc2ysRT9H0adq7h8' in your case. The 'range' field must be your tab's name.
You can find the concepts here: https://developers.google.com/sheets/api/guides/concepts
Please tell me if it works! :)

Thank you!
my fault. Now I ran into the next problem:

Error: Request had insufficient authentication scopes.

I fixed it with adding the scope "https://www.googleapis.com/auth/spreadsheets" (for other users who run into the same problem)
Thank you for your great work. Have a nice day!

I am having the same issue  regarding the "SyntaxError" on my raspberry PI when using Node.js version : v6.13.1:
`Welcome to Node-RED
27 Apr 19:25:46 - [info] Node-RED version: v0.18.4
27 Apr 19:25:46 - [info] Node.js  version: v6.13.1
27 Apr 19:25:46 - [info] Linux 4.9.35-v7+ arm LE
27 Apr 19:25:47 - [info] Loading palette nodes
27 Apr 19:25:52 - [info] Dashboard version 2.8.2 started at /ui
27 Apr 19:25:57 - [warn] ------------------------------------------------------
27 Apr 19:25:57 - [warn] [node-red-contrib-viseo-google-spreadsheet/google-spreadsheet] SyntaxError: Unexpected token )
27 Apr 19:25:57 - [warn] ------------------------------------------------------
27 Apr 19:25:57 - [info] Settings file  : /home/pi/.node-red/settings.js
27 Apr 19:25:57 - [info] User directory : /home/pi/.node-red
`
I am willingly to upgrade to version 8 if this won't break my flows or at least that it is not expected that this will break any flows.
Are there any instruction how I can best upgrade to version 8 ?
kr
jan

Same problem here with node red version 0.19.5 and node.js 9.10.1. Any sugestion?


food website added.

Description
(Describe your project over here.)
Checklist

[x] I've been assigned an issue related to this PR.
[ ] I've used beautifiers.
[x] I've added my Project's name and description to Index.md
[x] I've made a README.md file for my Project.
[x] The README.md file of my projrct contains Project title, Description, Use of project, Set up, Stack used and Output (Screenshots).

Related Issues or Pull Requests number
#298

@harshita2216 please have a look


fix(icomp): {off,on}-circuit computation of X{0,1}

Issue Link / Motivation
During the computation in circuit relaxed plonk instance, the instance & challenge fields were submitted to a set of limbs. Whereas for off-circuit were represented as field elements. This led to non-consistent values X0 & X1
Changes Overview
To avoid the extra cost of on-circuit calculations, an off-circuit decomposition of these fields into limbs was added
Test
Unit-test for {on,off}-circuit consistency was added

What is our e2e test circuit? Something trivial or sha256?

What is our e2e test circuit? Something trivial or sha256?

I'm debugging trivial now, sha256 is too long

Approved. Added a few NBDs, there are more places like this.

Actually asking the compiler to output a generic is nice, but very unobligatory, a matter of taste.


Add RootCAs as a configurable value to Traefik chart

What this PR does / why we need it: It allows a user of the Traefik chart to specify one or more custom certificate authorities to use when connecting to TLS-encrypted backends.

Something that's a bit unclear to me is the format that rootCAs takes when specifying certificates inline. Attempting to add the base64-encoded certificate yields:
2018/09/23 21:07:19 Error reading TOML config file /config/traefik.toml : toml: cannot load TOML value of type string into a Go boolean

@dtomcej thank you for the feedback. Rebased and signed off with the change and a bump.

/approve

/lgtm

/ok-to-test


Start lora-app-server in http

Is it possible start lora-app-server using http and not https with TLS certificate? If I comment HTTP_TLS_CERT and HTTP_TLS_KEY lora-app-failed to start.

No, this is not possible.

The http server for serving the web-interface and API (both gRPC as the RESTful JSON api) must be secured by using a TLS certificate.

https://docs.loraserver.io/lora-app-server/install/config/
This is because the gRPC and REST api are served on the same interface and this is only possible when using TLS (because a http/2 is needed).


docker build problem

Hello,
Why am i getting this message
Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
Error: no context directory and no Containerfile specified
Please help

Have you tried to run with the recommended command on readme?

Hello, Why am i getting this message Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg. Error: no context directory and no Containerfile specified
Please help

In addition to what @dolby360 said, please make sure that you're in the same directory as the repository's Dockerfile.

Hi @okofishe , has the issue been resolved?

Hello,
Yes it has been resolved. The Docker deamon was not working when i was calling docker, so i have to start the dock deamon and call docker again which resolve the issue.
Thanks bro


Fix docEditBase being ignored

Currently if the user specify a docEditBase, it will be ignored as we don't use the value. (directly overrided see line 6)
This fix this by looking at the value first and only then defaulting to the default value.

Tnx


Lost all my annotations because the absolute local path changed

I changed around the folder structure of my project, which resulted in the absolute local path changing. This, in turn, led to me losing all of my previous annotations. Is there a fix for this?

There are two possible solutions (although someone from HumanSignal might have better advice).
Annotations create a task file (a number like 2741) without an extension. They are JSON files and can be edited. You can fix the image file path and reimport the files.
The default database is SQLite3 (PostgreSQL is also an excellent choice).
You may manually edit the database (I did this after importing annotations converted from yolo; but was missing (so had to remap) the "storage filename" for S3.  Check your previous annotations are in the 'task' table. If you are uncomfortable with SQL commands in a terminal, you can use DB Browser for SQLite to open the database and make careful edits.
Note: Editing a database is like editing the Windows registry, a mistake can be a huge headache so, back up the database before editing.

@SheldonWBM thanks for your response!
I attempted to move my images back to the old file path location and updated the "Cloud Storage" with the old path (without hitting the "Sync Storage" button).

However, it looks like Label Studio is still unable to display these images.

You can fix the image file path and reimport the files (images and tasks).

How exactly would I do this? I know how to import images but not sure exactly how to import the tasks as well.
Editing the SQLite database directly is also a good suggestion - I am very comfortable with SQL, although I'm not sure what these fields (i.e. "data" within the "task" table) are supposed to look like and if that's the only field that needs to be updated.

I don't think that there's a general solution for this problem. Label Studio assumes fixed data locations for the data source, and if they change there's not an easy way for the application to implement migrating from one storage source to another.

You can use the experimental feature called "Add Or Modify Data Field" in the Data Manager actions.

Enable experimental features and run label studio:

ff_back_experimental_features=1 label-studio

Go to the Data manager for your project.

Select tasks where you need to make path replacement.

Click Actions > Add Or Modify Data Field.

Fill all inputs in the dialog:
Name =
Type = Expression
Value = replace('old-path','new-path')

Click OK and refresh the data manager page completely.

Note: this action is experimental and can corrupt your data if you do something wrong.

Not sure it matters as I may have just messed things up the first go around when trying this, but using replace("old-path","new-path") with double quotes as opposed to single quotes worked whereas the latter I think resulted in my table replacing "image" with "$undefined$" which required going into the database and manually changing. (Instruction box uses double quotes but image shows single quotes.)
Also I believe it's still necessary to update Settings/Cloud Storage/path variable along with this update in order to see the image tasks in the Data Manager.
Lastly this didn't work for me on version 1.12.1, but did work on version 1.13.1.


HTTP protocol and name in resource is highlighted as the function name

 Issue by prabushi
Tuesday Feb 23, 2021 at 13:33 GMT
Originally opened as https://github.com/ballerina-platform/plugin-vscode/issues/230

Description:

Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
import ballerina/http;

// By default, Ballerina exposes an HTTP service via HTTP/1.1.
service / on new http:Listener(9090) {

    // The resource method is invoked by the GET request for the
    // `/greeting` path. The returned string value
    // eventually becomes the payload of the `http:Response`.
    resource function get greeting() returns string {
        return "Hello, World!";
    }
}

service /hello on new http:Listener(8080) {

    resource function get .(http:Caller caller, http:Request req) {
        if (counter % 5 == 0) {
            // Delay the response by 5000 milliseconds to
            // mimic the network level delays.
            runtime:sleep(5);

            var result = caller->respond("Hello World!!!");
            handleRespondResult(result);
        } else if (counter % 5 == 3) {
            http:Response res = new;
            res.statusCode = 500;
            res.setPayload(
                "Internal error occurred while processing the request.");
            var result = caller->respond(res);
            handleRespondResult(result);
        } else {
            var result = caller->respond("Hello World!!!");
            handleRespondResult(result);
        }
        counter = counter + 1;
    }
}

import ballerina/http;
import ballerina/log;

service /sample on new http:Listener(9090) {

    // The `PathParam` and `QueryParam` parameters extract values from the request URI.
    // Path param is defined as a part of the resource path along with the type.
    resource function get path/[string foo](http:Caller caller,
                                            http:Request req) {
        // Get the [QueryParam](https://ballerina.io/learn/api-docs/ballerina/#/ballerina/http/latest/http/classes/Request#getQueryParamValue)
        // value for a given parameter key.
        var bar = req.getQueryParamValue("bar");

        // Get the [MatrixParams](https://ballerina.io/learn/api-docs/ballerina/#/ballerina/http/latest/http/classes/Request#getMatrixParams).
        map<any> pathMParams = req.getMatrixParams("/sample/path");
        var a = <string>pathMParams["a"];
        var b = <string>pathMParams["b"];
        string pathMatrixStr = string `a=${a}, b=${b}`;
        map<any> fooMParams = req.getMatrixParams("/sample/path/" + foo);
        var x = <string>fooMParams["x"];
        var y = <string>fooMParams["y"];
        string fooMatrixStr = string `x=${x}, y=${y}`;
        json matrixJson = {"path": pathMatrixStr, "foo": fooMatrixStr};

        // Create a JSON payload with the extracted values.
        json responseJson = {
            "pathParam": foo,
            "queryParam": bar,
            "matrix": matrixJson
        };
        http:Response res = new;
        // A util method to set the JSON payload to the response message.
        res.setJsonPayload(<@untainted>responseJson);
        // Send a response to the client.
        var result = caller->respond(res);

        if (result is error) {
            log:printError("Error when responding", err = result);
        }
    }
}

The same highlighting is used for functions.
import ballerina/io;

// The `main` function, which acts as the entry point.
public function main() {
    io:println("Hello, World!");
}

Related Issues:

Will be addressed with https://github.com/wso2/ballerina-plugin-vscode/issues/33


Allow spider settings to be set/overridden from instance/nodes/*NODE*/settings.json

Related:

#23

The spider should be able to follow delays and other relevant overrides in a node-specific settings file. For example, Harvard Dataverse wants a 4 second delay between requests, but most other sites can be crawled more rapidly.

Makes more sense as settings.json

Followed suggestion from https://docs.scrapy.org/en/latest/topics/settings.html#settings-per-spider to implement settings changes in Spider.from_crawler()

Tested and working.


Client to client outgoing call fails to connect randomly

Description
Client to client outgoing call fails first time after install. On iPhone 5S it fails more often than on iPhone 7s Plus. When tapped on call button callKit is fired in the background but nothing happens.
Steps to Reproduce

Run it on iPhone 7S and initiate client to client call

Expected Behavior
It should either connect or return failure and kill callKit.
Actual Behavior
Neither connects nor kills callKit. callKit keeps running in the background
Reproduces How Often
Over 90% of time on iPhone 5s and first time on iPhone 7 Plus
Logs
StartCallAction transaction request failed: The operation couldn’t be completed. (com.apple.CallKit.error.requesttransaction error 7.)

error 7 is CXErrorCodeRequestTransactionErrorMaximumCallGroupsReached
Voice iOS SDK
2.0.0-beta13 via CocoaPods
iOS Version
12.1.1
iOS Device
iPhone 5s, iPhone 7 Plus

Hi @aksthelion
Thanks for reporting the issue. Are you always getting the requesttransaction error 7 message when the error happens?

Hello, Yes error 7 is the error it throws when this issue happens.

I've been chasing this issue since long time, had a ticket on twilio as well also tried forums etc but couldn't get any solution. The only thing I can think of is that iPhone 5s is a bit of slow device which may be causing this issue to happen more frequently, however it may be just my imagination.

Cool.
From what error code is suggesting (CXErrorCodeRequestTransactionErrorMaximumCallGroupsReached) it seems the error is happening after a couple of calls due to the sample failing to report call ended to the CallKit.
Definitely happy to try the steps and fix the issue but would be great if you can help us narrow down the exact steps to get to this bug.
Thanks
-bobie

Sure, let me know instructions. Here is interesting thing, if call fails very first time then shouldn't it be reporting some error and kill callKit, in this way we would at least know what is happening? Anyways let me know how do we go about debugging it.

Hello, any update on this issue?

Closing this issue assuming the original issue was resolved by the updates of the sample app. Please reopen or create a new issue.
Thanks!

I already have latest code. It doesn't resolve the issue. Not sure why it's so hard for anyone to understand this simple problem. In my case call doesn't start but callkit UI is fired. If call is not connected then whatever you all keep saying all the time to fix doesn't work.
1) Callkit UI is started
2) Call is not connected. There is not call in progress, there is no UI there is nothing related with call.


Merging two SR300 to increase the field of view

Required Info

Camera Model
SR300

Firmware Version
<IP_ADDRESS>18

Operating System & Version
Windows 10

Build System
VS2015

Hello,
I have two Intel RealSense SR300 Cameras which i want to merge into one Program.
My idea was to increase the field of view by positioning the cameras in a degree of about 90°.
Can you please suggest an approach on how this could be accomplished?
My first step would be trying to get them into a single window and align them so that they overlap by a view pixels and merge them together but i'm not sure how to get this done. Then i would alter the image streams to transform the pixels.
Is this possible ?
Many thanks in advance,
dacula

Using two SR300 cameras to get an extended field of view does not seem to be possible.

This pattern causes destructive interference with other F200 and SR300 cameras and performance is dramatically degraded when multiple cameras are pointed at the same subject.

Reference: https://github.com/IntelRealSense/librealsense/blob/master/doc/camera_specs.md
However it seems that you might be able to do what you want using the R200.

Assuming he aims the cameras at a 90 degree angle, shouldn't be a problem.  The SR's use a structured light pattern of binary bar codes.  So overlapping fields of view obviously don't work, but that's not to say you can't still align the cameras with a gap between.  All you need to do is generate a video of the two cameras sitting on a tripod, and then just pan the tripod around 360 degrees.  Use the objects in the room as fiducials from which to derive a 4x4 transform matrix from one camera to the other.  And then embed this transform into your rendering code.


Portable Class Library

Can it be used in Portable Class Library for .Net Framework and Xamarin Android?

The library implements netstandard2.0 and netstandard2.1, though there are general reflection issues with those platforms most of it should work these days.


Incorrect mesh normals on GLTF export

Describe the bug
Mesh normals exported to GLTF and imported into Blender have incorrect rotation.
What Valve game does this happen in
Half-Life: Alyx
Reference file in a Source 2 game
models/props_combine/combine_battery/combine_battery_large.vmdl
Expected behavior
Current result on import:

Expected:

Steps to reach expected result:

Go into Edit Mode
Press A to Select All
Alt+N -> Flip
Check "Custom Normals Only" in the bottom left
Alt+N -> Rotate
Press Z, type 180, enter
Alt+N -> Rotate
Press X, type -90, enter

What version of VRF are you using? On what platform?
v0.3.1 on Windows 10

Should be fixed by 56a52111f1a1933c15516eb40b6249c020f24106, just need to verify against different games.


Arnej/outward conn check

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
@havardpe please review

@havardpe please take another look


CHANGELOG

This project has a changelog but it is empty.
Expected Behavior
Users and developers should be able to review a changelog for this project which adheres to the keepachangelog format and thus meets the following criteria:

It’s made for humans, not machines, so legibility is crucial.
Easy to link to any section (hence Markdown over plain text).
One sub-section per version.
List releases in reverse-chronological order (newest on top).
Write all dates in YYYY-MM-DD format. (Example: 2012-06-02 for June 2nd, 2012.) It’s international, sensible, and language-independent.
Explicitly mention whether the project follows [Semantic Versioning][https://semver.org].
Each version should:

List its release date in the above format.
Group changes to describe their impact on the project, as follows:

Added for new features.
Changed for changes in existing functionality.
Deprecated for once-stable features removed in upcoming releases.
Removed for deprecated features removed in this release.
Fixed for any bug fixes.
Security to invite users to upgrade in case of vulnerabilities.

Current Behavior
The project has an empty changelog file.
Possible Solution
Use the keepachangelog format and ensure that it is updated for each new version/release.
Context
Keeping a standardized changelog makes it easy for people to see and understand what has happened version to version and when those versions were released.

I'm willing to update the changelog with the skeleton of the format and work with you to ensure we capture changes/updates for future releases/versions.

100% agree with keeping the changlog. It's empty right now because the project has been in active development and core pieces have changed drastically in the last few months. Expect the changelog to be similar to the one in my NetScaler project.
Now that it's settled down, the changelog can start to be maintained.

A skeleton of a changelog has been setup according to the keepachangelog format.


Update build artifacts getting started

This one line made all the difference for me getting a working build.  The documentation talks about the IMAGE_FSTYPES settings, but even after reading the file-system-types docs I didn't get a clear picture of what I needed to change in the config to produced the output desired.

Thank you, much appreciated!

Your change should go live in an hour or so.


kilic.js.org

I think my website is also 10kbclub https://kilic.js.org/

Thank you for creating this issue. I am afraid, I will not add this website now because it does not satisfy rule 5.


Server Error for Camaro Package

When I attempt to get a bundle of the npm package, Camaro, I get a server error. Here is the URL<EMAIL_ADDRESS>...and here is the error returned:
Command failed: npm_config_cache=~/.npm /var/app/current/node_modules/.bin/npm install --production gyp: Undefined variable module_name in binding.gyp while trying to load binding.gyp gyp ERR! configure error gyp ERR! stack Error: `gyp` failed with exit code: 1 gyp ERR! stack at ChildProcess.onCpExit (/var/app/current/node_modules/npm/node_modules/node-gyp/lib/configure.js:336:16) gyp ERR! stack at emitTwo (events.js:125:13) gyp ERR! stack at ChildProcess.emit (events.js:213:7) gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:197:12) gyp ERR! System Linux 4.9.32-15.41.amzn1.x86_64 gyp ERR! command "/opt/elasticbeanstalk/node-install/node-v8.1.4-linux-x64/bin/node" "/var/app/current/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" gyp ERR! cwd<EMAIL_ADDRESS>gyp ERR! node -v v8.1.4 gyp ERR! node-gyp -v v3.6.2 gyp ERR! not ok npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the<EMAIL_ADDRESS>install script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! A complete log of this run can be found in: npm ERR! /tmp/.npm/_logs/2017-12-07T17_19_15_984Z-debug.log

Yes indeed, but it seems that the error Undefined variable module_name in binding.gyp is not related to our service :thinking:
I'm looking more in details, i'll let you know.

Unfortunately Camaro is not working in browser environments (see https://github.com/tuananh/camaro/issues/21#issuecomment-350150607).
I'm closing this since it's not related to our service.


Remove reference to non-existent function

Type

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Optimization
[x] Documentation Update

Description
Can't see anything to suggest that Either.toOption ever existed.
Related

Related Issue #
Closes #

:shipit:


update example 03 & example 06 project name

update some project's name are not correct that example 03 & example 06

Please add wechat yanyanho666 to join us


I added a question

It's my first time on GitHub, so I added one question. I am still learning this new stuff

Thank you for the contribution .


Make region argument case insensitive

Re-opening PR 18 against working branch
Hi,
One for consideration. If you give -r lon, all you get back is 'Endpoint not found', which isn't very informative.
So either the comparison can be case insensitive, or the error message can be a bit more descriptive.
I'd opt for case insensitive comparison, as ultimately the DNS lookup is case insensitive itself anyway.

Any love for this one?

Thanks!


Size of assignment pattern elements

According to 10.9.1, the elements of assignment pattern should adapt to the size of the array elements.
Please consider the following file:
module top(output logic a);
   logic x [1:0] = '{1, 0};
   assign a = x[1];
endmodule

Here is uhdm of logic x [1:0] = '{1, 0};:
  \_array_var: (work@top.x), line:2:10, endln:2:11, parent:work@top
    |vpiSize:2
    |vpiName:x
<EMAIL_ADDRESS>    |vpiAutomatic:1
    |vpiRandType:1
    |vpiVisibility:1
    |vpiExpr:
    \_operation: , line:2:20, endln:2:27
      |vpiOpType:75
      |vpiOperand:
      \_constant: , line:2:22, endln:2:23
        |vpiDecompile:1
        |vpiSize:64
        |UINT:1
        |vpiConstType:9
      |vpiOperand:
      \_constant: , line:2:25, endln:2:26
        |vpiDecompile:0
        |vpiSize:64
        |UINT:0
        |vpiConstType:9
    |vpiArrayType:1
    |vpiRange:
    \_range: , line:2:13, endln:2:16
      |vpiLeftRange:
      \_constant: , line:2:13, endln:2:14
        |vpiDecompile:1
        |vpiSize:64
        |UINT:1
        |vpiConstType:9
      |vpiRightRange:
      \_constant: , line:2:15, endln:2:16
        |vpiDecompile:0
        |vpiSize:64
        |UINT:0
        |vpiConstType:9
    |vpiReg:
    \_logic_var: (work@top.x<EMAIL_ADDRESS><EMAIL_ADDRESS>      |vpiExpr:
      \_operation: , line:2:20, endln:2:27

Currently Surelog doesn't change the sizes of constants and leaves the default ones.
I think it would be better to do it in Surelog than in all tools that use Surelog, especially that Surelog adapt the sizes in some other places like assigning constant to parameter etc.

Fixed by #2671


Upgrade from node16 to node20

Node16 is now EOL. The next LTS release is node18 which has support until 2025, but node20 has support until 2026.
https://nodejs.dev/en/about/releases/

CI is currently failing, but the tests all passed. One of our tests generates an error and it seems like the Actions runner is picking up on that and reporting the step as failed?

<EMAIL_ADDRESS>test
jest

PASS src/main.test.ts
Error: github-token is not set! Please add 'github-token: "${{ secrets.GITHUB_TOKEN }}"' to your workflow file.

PASS src/dependabot/update_metadata.test.ts
PASS src/dependabot/verified_commits.test.ts
PASS src/dependabot/output.test.ts
Test Suites: 4 passed, 4 total
Tests:       40 passed, 40 total
Snapshots:   0 total
Time:        4.206 s
Ran all test suites.

Is the underlying actions issue mentioned here related to the CI failures?

https://github.com/dependabot/fetch-metadata/issues/335

Is the underlying actions issue mentioned here related to the CI failures?

Migrate to node 18 whenever Actions adds support for it. #335

The original issue was but I think node 20 has shipped on Actions runners. Now I see a new error around a missing GitHub token that I can take care of in a bit.

As we near the deadline in Spring 2024, this action has begun generating deprecation warnings. Are there any obstacles in the migration process? I anticipate this becoming a prominent topic soon, as more individuals express frustration with these warnings.
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: dependabot/fetch-metadata@c9c4182bf1b97f5224aee3906fd373f6b61b4526. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Are there any obstacles in the migration process?

Nope just got busy. We're going to release this as a major version update since it breaks compatibility with older GitHub Enterprise Server versions that don't ship with Node20. I'll create a minor release for whatever changes are on main first, though.

Would really appreciate a release /w node20 support soon. Most of the actions are already migrated....

@Nishnha I'm unclear what's the next step here?
Do we need a minor release to catchup to HEAD and then merge this and cut a major release?
Should we land any of the other outstanding PR's first? I can take a look and make judgement calls but assume you've already looked at this?


Add arguments router to ConditionRouter

Add arguments router logic to ConditionRouter.
What is the purpose of the change
Add arguments router to ConditionRouter.
Compatible to current ConditionRouter logic.
Brief changelog
Add arguments router to ConditionRouter
Verifying this change
Add arguments router to ConditionRouter
Examples
In some cases, we need to choose the right provider while the arguments of the method is setted.
The condition rule is like

arguments[1].str!=b  => host = <IP_ADDRESS>

While the str property of the second argument is equal to b, the providers whose host is equal to <IP_ADDRESS> are to be choosed。
We could use this feature to route requests according to business params.
The feature is compatible to current ConditionRouter logic.
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[x] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

https://github.com/apache/dubbo/pull/5649

@AlbumenJ

Codecov Report

Merging #7378 (f1d4df3) into master (d009d0c) will increase coverage by 0.36%.
The diff coverage is 86.36%.

@@             Coverage Diff              @@
##             master    #7378      +/-   ##
============================================
+ Coverage     58.72%   59.09%   +0.36%
- Complexity      425      527     +102
============================================
  Files          1043     1076      +33
  Lines         42471    43439     +968
  Branches       6212     6344     +132
============================================
+ Hits          24942    25669     +727
- Misses        14748    14929     +181
- Partials       2781     2841      +60

Impacted Files
Coverage Δ
Complexity Δ

.../rpc/cluster/router/condition/ConditionRouter.java
71.08% <86.36%> (+2.33%)
0.00 <0.00> (ø)

...he/dubbo/rpc/protocol/rmi/RmiRemoteInvocation.java
0.00% <0.00%> (-80.00%)
0.00% <0.00%> (-2.00%)

...org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java
0.00% <0.00%> (-61.67%)
0.00% <0.00%> (-10.00%)

...g/context/properties/DefaultDubboConfigBinder.java
42.85% <0.00%> (-57.15%)
0.00% <0.00%> (ø%)

.../java/org/apache/dubbo/qos/command/impl/Ready.java
3.33% <0.00%> (-46.67%)
0.00% <0.00%> (ø%)

.../cluster/configurator/parser/model/ConfigItem.java
48.00% <0.00%> (-24.00%)
0.00% <0.00%> (ø%)

...bbo/common/bytecode/CustomizedLoaderClassPath.java
28.00% <0.00%> (-16.00%)
0.00% <0.00%> (ø%)

...che/dubbo/remoting/transport/mina/MinaChannel.java
35.52% <0.00%> (-14.48%)
14.00% <0.00%> (-2.00%)

...t/migration/DefaultMigrationAddressComparator.java
15.38% <0.00%> (-11.54%)
0.00% <0.00%> (ø%)

...ache/dubbo/remoting/transport/mina/MinaServer.java
53.33% <0.00%> (-10.00%)
5.00% <0.00%> (-1.00%)

... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d009d0c...f1d4df3. Read the comment docs.


Create, Edit, Clone API calls

I think there is still some things that Lucah is working on but wanted to open it (and possibly get this reviewed and merged) before the rest of the web team gets working on the teacher app. This is because they will need the latest API calls in order to work through the UI updates


initial generate survey build

initial files for generate survey form. just a backup/ about 30% 'complete'

styling libraries not imported - too many errors with WIP generate survey files.


handle Base64 properly

ActiveSupport::Base64 was deprecated in Rails 3.2 and removed in 4.0
3-2-stable
https://github.com/rails/rails/commit/5f09414f85edfa60ab54ce8b9f8b03874e0670dc#diff-5
master
https://github.com/rails/rails/commit/0f2f8003d2351079ce6ec0e706e474d8024839cc#diff-6

I tried this out on Ruby 1.8.7 with Rails 3.2 and a few tests are failing
uninitialized constant ActiveSupport::SecureRandom

If you could fix this up for 1.8.7 I can merge it in.

@jduff done with uninitialized constant ActiveSupport::SecureRandom
I've tested with 1.8.7-p352 and 1.9.3-p0 rubies.
There are still 2 failing tests https://gist.github.com/b2b12c529610c4fa0d20, but they fail without my changes too.


fix(SelectDropdown): Fix axe accessibility input issue + styling inconsistencies

Overview
Turns out with a bit of futzing, it's possible with react-select to get the search input to recognized as a search input and the hidden input to be recognized as the value input  🙃.
I've tested it in a branch against Jonathan's current branch and have gotten it passing accessibility specs, woo!
Also tweaks some small margin and padding things - planning on refactoring its styling to remove dependence on styles in a future PR.

PR Checklist

[x] Related to designs:
[x] Related to JIRA ticket: GM-239
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.61-alpha.b17c32.0@codecademy/gamut-labs@19.15.4-alpha.b17c32.0@codecademy/gamut@34.13.3-alpha.b17c32.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60df82fbc5f3c1637bb16aad--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.61-alpha.4dad72.0@codecademy/gamut-labs@19.15.4-alpha.4dad72.0@codecademy/gamut@34.13.3-alpha.4dad72.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60df900674fefb80fb200474--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.62-alpha.4b6c5d.0@codecademy/gamut-labs@19.15.5-alpha.4b6c5d.0@codecademy/gamut@34.14.1-alpha.4b6c5d.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60ec5853cdf13f1c73fe4434--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.63-alpha.d5e4ca.0@codecademy/gamut-labs@19.16.1-alpha.d5e4ca.0@codecademy/gamut@34.14.2-alpha.d5e4ca.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60ec6e4f7ad727395f09876c--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.63-alpha.6cb970.0@codecademy/gamut-labs@19.16.1-alpha.6cb970.0@codecademy/gamut@34.14.2-alpha.6cb970.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60edcb9bfeb20820df9894e7--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.63-alpha.c3f5fb.0@codecademy/gamut-labs@19.16.1-alpha.c3f5fb.0@codecademy/gamut@34.14.2-alpha.c3f5fb.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60edd60dfaeeb22f111ccf92--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.63-alpha.af7b8a.0@codecademy/gamut-labs@19.16.1-alpha.af7b8a.0@codecademy/gamut@34.14.2-alpha.af7b8a.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60ef5c1e7965b22fa0834360--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.67-alpha.6b0682.0@codecademy/gamut-labs@19.16.5-alpha.6b0682.0@codecademy/gamut@34.15.1-alpha.6b0682.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60f584d4bc7fd15f08301a28--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.70-alpha.a23789.0@codecademy/gamut-labs@19.16.8-alpha.a23789.0@codecademy/gamut@35.1.1-alpha.a23789.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60f6e108ef1d360a2db9aa5d--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.70-alpha.6e65bc.0@codecademy/gamut-labs@19.16.8-alpha.6e65bc.0@codecademy/gamut@35.1.1-alpha.6e65bc.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60f894701164f748641911fd--gamut-preview.netlify.appDeploy Logs


Requirements For Build

Users may not need the full jdk installed but it does resolve build issues like the following:
[ERROR] Failed to execute goal on project knit: Could not resolve dependencies for project io.continuum:knit:jar:1.0-SNAPSHOT: Could not find
 artifact jdk.tools:jdk.tools:jar:1.7 at specified path /usr/lib/jvm/java-7-openjdk-amd64/jre/../lib/tools.jar ->

On Ubuntu:
aptitude install openjdk-7-jdk

Would be good to find the minimum amount of packages: openjdk-7-jre-lib and ant and something else?

Will be solved with conda recipe


Draggable L.Marker (with divIcon) - unwanted map click event in Chrome on dragend

How to reproduce

Leaflet version I'm using: 1.3.1 (from<EMAIL_ADDRESS>

Browser I'm using: Chrome 65.0.3325.181 (64-bit)

OS/Platform I'm using: Windows 7 Professional x64

run the example JSFiddle Leaflet draggable marker Chrome issue

press left mouse button down when cursor is near the border of marker (near to marker's border as possible, when cursor is just changed to 'hand')

drag marker to some distance, the cursor will move out a bit from the marker border

after releasing mouse button, the blue marker with popup will be added to map - it means, that map click event was handled, but actually no click was intended

What behaviour I'm expecting and which behaviour I'm seeing
Expecting behavior: map click event should not be fired after marker dragging complete.
In Firefox 56.0.2 (32-bit) on the same system the behaviour is different (and it is how it should work): no map click event is fired after mouse button release, but clicking on map just after drag ended will fire click event. The same behaviour is on Firefox Nightly 61.0a1 (2018-03-28) (64-bit).
Minimal example reproducing the issue
JSFiddle Leaflet draggable marker Chrome issue
var map = L.map('map').setView([50, 1.0], 15);

map.on('click', function(e) {
  L.marker(e.latlng)
    .addTo(map)
    .bindPopup("Was clicked at " + e.latlng)
    .openPopup();
});

L.tileLayer('https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', {
  attribution: 'Map data © OpenStreetMap',
  maxZoom: 18
}).addTo(map);

L.marker([50, 1.0], {
    icon: L.divIcon({}),
    draggable: true
  })
  .on('drag', function(e) {})
  .on('dragstart', function(e) {})
  .on('dragend', function(e) {})
  .on('click', function(e) {
    L.DomEvent.stopPropagation(e);
  })
  .addTo(map);

Only add pointer-events: none in CSS property

Seems duplicate of #4457

Checked using Leaflet version 1.6.0 JSFiddle Leaflet draggable marker Chrome issue, the issue still here.

@apdevelop
Please check this solution: #7446