Add database:rollback to symfony recipe

Q
A

Bug fix?
No

New feature?
Yes

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

Hi, I suggest this feature for add the ability to rollback the database in the Symfony4 recipe.

Thanks for your PR. Please rebase in on master branch. The new version of Deployer currently developing in master, so it's the best time to introduce new features.
Please, recreate your PR.


HYF-redesign-group-2: Agile Development, 4 weeks

[ ] repo (with a complete README)
[ ] live demo
/planning

[ ] communication plan
[ ] constraints
[ ] backlog
[ ] wireframe
[ ] development strategy
[ ] retrospective

[ ] project board

Thanks for creating it @cristobal-lopez !


new commits

Could you also put your information into the roster.md file?

Just tried merging again


Image types

hi james ,
have you got an example code for figuring out the image type (jpg,png,svg,gif,bmp,....)  ?
i dont want to look at the file extension , bcs some files has wrong extensions (eg. File's codec is jpeg but extension is png)
Update : Image data coming from MemoryStream and i convert it to System.Drawing.Bitmap class.
Update 2 : I will use this image for Resizing in ImageProcessor , (dont want to png files losing transparency and jpeg files losing quality)
Thanks in advice.

Hi @Mtahtaci,
I see you opened and closed this issue. Did you find what you are looking for?
Both libraries, ImageProcessor and ImageProcessorCore use the various file headers to identify what format the image is and use the correct encoders and decoders. If it's not a supported image format e.g. svg then they will throw an exception.
You will be able to query the loaded format by looking at the CurrentImageFormat property.
Cheers
James


Create list of CLI commands to update

Go over the CLI commands as they are, and the desired state and make any tickets required.

Initial CLI cleanup items:
-- [ ] Weave gitops install

Closing as part of a cleanup effort. Discussed with @markramm and @JamWils


can't pack textures on MacOS with Godot 4.3

Terrain3D version
v0.93
System information
Godot 4.3, Mac OS Monterey V12.7.6, 2.2 GHz Quad-Core Intel Core i7.
Is the issue reproducable in the demo?
Not applicable
Issue description
the UI for packing textures is all jumbled, possibly make it resizable or scan to fit screen resolution? my Mac is 15.4-inch (2880 × 1800)

Logs
No response

Was fixed a while ago. Use a nightly build or disable hdpi.
Duplicate #531


SetUp Data Bases Integrations

Is your feature request related to a problem? Please describe.
We have to test data set in MySQL DB as well as in the Mongo DB
Describe the solution you'd like
Nice to have ability to connect to the DB's and execute queries
JDBC drivers may be a good solutions to use.

Seems i found  that feature


Added title to the download and github icons like darkMode button

Earlier when user hovered over the download and github buttons nothing used to show in order to tell user what these buttons will do like the darkmode button used to tell.

Now I have added the titles to download and github buttons, when user hover over download button it shows - "download sbuttons.min.css" and when user hovers over github button it shows "sbuttons repo".
Issue:

@shahednasser  Done with the required changes

Great but please remove all changes in dist/sbuttons.css as they are unnecessary

I am not able to get it, I have not even edited anything in dist/sbuttons.css .

@Hrshk15 the easiest way is to just copy the content of the file in the repo then committing the changes.

@Hrshk15 any update on this?


Replace gnome-clipboard-history with something

https://github.com/SUPERCILEX/gnome-clipboard-history/commit/e62fdbcdc5e7d62cd603a5f02f31c3ffedafa107

https://github.com/NixOS/nixpkgs/issues/336643


page.emulate userAgent should be optional?

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.5.0
Platform / OS version: Windows 10
URLs (if applicable):
Node.js version: 8.11.3

What steps will reproduce the problem?
Please include code that reproduces the issue.
If you want to emulate a desktop size, there is no need to change the userAgent from the default.
const emulatedDevices = [
  {
    name: 'Desktop 1920x1080',
    viewport: {
      width: 1920,
      height: 1080
    }
  },
  {
    name: 'Desktop 1024x768',
    viewport: {
      width: 1024,
      height: 768
    }
  },
  {
    name: 'Laptop 1280x800',
    viewport: {
      width: 1280,
      height: 800
    }
  },
  devices['iPad'],
  devices['iPad landscape']
]

What is the expected result?
page.emulate will emulate a device even though the userAgent hasn't been provided, as it will just use the default userAgent string.
What happens instead?
Protocol error (Network.setUserAgentOverride): Invalid parameters userAgent: string value expected

Can you just use page.setViewport(device.viewport)?

You can use browser.userAgent() to pre-populate default user agent for you emulated devices.
Let's keep things as-is.


Setup TestFlight Beta

Need to get a few people as testers to send out a beta release.

Closed by #18


[Fluent 2 iOS] TableViewCell colors update (2/2)

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
As we are trying to move away from Colors.swift, the Colors extension was removed from TableViewCell.
Some of the colors in the Table struct were used by other controls in fluent. In fact, PersonaListView, TableViewHeaderFooterTitleView & PopupMenuItemCell had dependencies to some of these colors and they were all updated to use their appropriate color tokens instead.
The Objective-C colors were changed into functions that take in a FluentTheme and output the right token.
Verification

Before
After

Pull request checklist
This PR has considered:

[x] Light and Dark appearances
[ ] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[ ] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

i kind of want all of this change except for the tableviewcell.swift and some pieces you are refering to fluent2 color to be in mainbranch first. Because most of the stuff is demoapp fixes only which has no impact on the framework. changes in exsiting fluent controls like personalist and tableheaderfooterview that just listens to the theme without any public api changes. these are all good things to have in main and not specific to fluent2-colors branch.

I disagree, Harrie. These changes are all directly related to the work to remove Colors.swift and are not entirely independent of the work being done in the fluent2-colors branch. Additionally, I don't see this change as crucial to have in main and it would introduce yet more delay into the schedule for the fluent 2 work. Unless you feel VERY strongly that this should be broken into two PRs (one in main, then merged to fluent 2 colors, then the remaining change pushed on top), I would prefer this to go in now, and eventually it will make it's way back to main.

because overall fluent2-color branch merge to main is being pushed back i think there are changes that should also live in Fluent2-token branch which is why i think some of the fluent-theme listening changes can live in main.

because overall fluent2-color branch merge to main is being pushed back i think there are changes that should also live in Fluent2-token branch which is why i think some of the fluent-theme listening changes can live in main

Essentially all non tokenized controls we have updated so far have FluentTheme listening changes. Is there any particular reason we would want to have just a handful of non tokenized controls into fluent2-tokens?

because overall fluent2-color branch merge to main is being pushed back i think there are changes that should also live in Fluent2-token branch which is why i think some of the fluent-theme listening changes can live in main

Essentially all non tokenized controls we have updated so far have FluentTheme listening changes. Is there any particular reason we would want to have just a handful of non tokenized controls in fluent2-tokens?

yup. which at the end, speeds up fluent2-token branch to be complete faster?

I've just started working on it and we would also need to pull in the updated AliasTokens and GlobalTokens from fluent2-colors. It might create some conflicts in main as many tokens have been changed/moved around/renamed. Should I still go ahead with it or just use the closest matching token from the main branch?

its not the end of the world if we have to copy and past in fluent-token side as well. @huwilkes @sophialee0416 yall fine with that?

its not the end of the world if we have to copy and past in fluent-token side as well. @huwilkes @sophialee0416 yall fine with that? the merges are going to be harder that's why i suggested on a separate change which makes commit conflict much smaller.

I'm not certain I understand what you're proposing here. But, if it makes merges harder, I would strongly recommend avoiding it. Our merges are already going to be a monster, I would hate to make it any worse!

its not the end of the world if we have to copy and past in fluent-token side as well. @huwilkes @sophialee0416 yall fine with that? the merges are going to be harder that's why i suggested on a separate change which makes commit conflict much smaller.

I'm not certain I understand what you're proposing here. But, if it makes merges harder, I would strongly recommend avoiding it. Our merges are already going to be a monster, I would hate to make it any worse!

I think @laminesm was asking if we should bring some of the update tokens from fluent2-colors -> main, which is a hard no. We don't want to add any of the new tokens to main until we're ready to remove the old ones. We could add the notification for theme updates on main if we wanted, but the change from Colors.tableCellBackgroundSelected to TableViewCell.tableCellBackgroundSelectedColor(fluentTheme: cell.fluentTheme) is a breaking change I really don't think we want to move to main right now.

its not the end of the world if we have to copy and past in fluent-token side as well. @huwilkes @sophialee0416 yall fine with that? the merges are going to be harder that's why i suggested on a separate change which makes commit conflict much smaller.

I'm not certain I understand what you're proposing here. But, if it makes merges harder, I would strongly recommend avoiding it. Our merges are already going to be a monster, I would hate to make it any worse!

I think @laminesm was asking if we should bring some of the update tokens from fluent2-colors -> main, which is a hard no. We don't want to add any of the new tokens to main until we're ready to remove the old ones. We could add the notification for theme updates on main if we wanted, but the change from Colors.tableCellBackgroundSelected to TableViewCell.tableCellBackgroundSelectedColor(fluentTheme: cell.fluentTheme) is a breaking change I really don't think we want to move to main right now.

right my first comment was not including tableviewcell.swift file and only about the theme listening


[babel] implement react-remove-prop-types and transform-react-constant-elements

.babelrc

commit about this feature


ENYO-1325: Fixes for language loading problem

Problem

Android L
Updated new android system webview 40
Found in Watch Manager
Menu always shows in English even user set language Korean

Cause

Android webview return format of navigator.language doesn't follow BCP-47 eg. It was "ko-KR" but now it returns "ko-kr"
Related Link - https://code.google.com/p/chromium/issues/detail?id=454331

Solution

As per i18n(Edwin) team's guide, glue.js should call ilib.setLocale with Ilib.getLocale() information, not navigator.language

Enyo-DCO-1.1-Signed-off-by: Seungho Park<EMAIL_ADDRESS>

Closing in favor of https://github.com/enyojs/enyo-ilib/pull/116.


⚠ Bofrost.fr has degraded performance

In 53f4bbe, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 896 ms

Resolved: Bofrost.fr performance has improved in 5c6781d.


Arabic Kashida

Arabic uses an unique way to justify text: instead of adding whitespace, they stretch the words by inserting TATWELL between letters.

Ref:

https://www.khtt.net/en/page/1821/the-big-kashida-secret
http://andreasmhallberg.github.io/stretchable-kashida/

Potential issues with this :

Kashidas inserted between contextual alternatives (which are heavily used in Arabic fonts) break the shaping. Unless you intend to run the shaper afterwards.
The example given is ugly looking. Kashida shouldn't be used this heavily.
some Arabic fonts make use of justification alternates, which look better but are not widely supported. (only in indesign iirc). but even indesign just applies to EVERYTHING which looks as bad as the example photo.

The naive implementation for kashida insertion shouldn't be the default behavior (for line lengths this long it is almost always better to just stretch and shrink spaces). If it should exist at all it should be an opt-in toggle.
Here is a three-part essay about Arabic justification by Titus Nemeth: https://research.reading.ac.uk/typoarabic/on-arabic-justification-part-1/ which goes over the history and the issues. You'll find one of the historical findings is that native typesetters prefer to stretch spaces and use alternate shape forms rather than inserting kashidas everywhere. kashidas are at best used very sparingly.

I created a crate to help with this: https://github.com/asibahi/kashida . Maybe you guys can find it useful. It has some custom rules for Arabic and Syriac, but also a generic function for other scripts like N'Ko and Adlam (using Unicode properties!)
While I believe using variable fonts to be the superior justification strategy, this is a useful fallback, before adjusting spaces.

Thanks @asibahi!

@asibahi that is awesome work!!


update: notation plugin command error messages

This PR improves error messages of notation plugin install command and updates the related cli specs as well.
Resolves #853.

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0f85752) 63.59% compared to head (2b0f74c) 64.78%.

Files
Patch %
Lines

cmd/notation/plugin/install.go
75.00%
4 Missing :warning:

cmd/notation/internal/plugin/plugin.go
0.00%
1 Missing :warning:

cmd/notation/plugin/uninstall.go
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
+ Coverage   63.59%   64.78%   +1.19%
==========================================
  Files          45       45
  Lines        2692     2695       +3
==========================================
+ Hits         1712     1746      +34
+ Misses        824      788      -36
- Partials      156      161       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Child element don't work for named elements in selectors

StackPanel#Name Button doesn't get applied

I think this is an OmniXaml issue - the Button is getting added to the StackPanel before StackPanel.Name is set, so when styling is applied it looks like the StackPanel doesn't have a name. I need to try the test with Portable.Xaml to check what the behavior there is.

@grokys Did you check if the behavior is different with Portable.Xaml?

This now works correctly.


Allows BR & MX admins to edit any content

What's this PR do?

Exports new regional admin permissions to edit any campaign content and static content
Redirects users to the proper translation page if the node source language does not match the user language

Where should the reviewer start?
dosomething_campaign.module -- campaign_init()
How should this be manually tested?

Create a new campaign
Under a new account with a different language, edit the campaign.
It should redirect you to a url containing /add//
Save the campaign
Hit 'Edit' again
It should redirect you to a url ending with your user language

Any background context you want to provide?
Multiple hooks were tried and discussed in #global but in the end we decided to go with hook_init()
Relevant tickets
Fixes #5020
@angaither

@deadlybutter when I pulled this down it worked for brazilian admins, but when I went to edit it as a regular admin it was adding the translations stuff and redirecting me here http://dev.dosomething.org:8888/node/1485/edit/add/en/
which 404s

Yeah that URL looks wrong,
what language was the campaign created in?

@deadlybutter english

thanks, looking into it now!

Note: this commit https://github.com/deadlybutter/dosomething/commit/478708ca7ab3ef326bb3fbae9e6c1f3baf631d98
fixed the bug Andrea raised above ^^
We logged the user_language and it wasn't on her account, thus the URL was a 404 because it was missing data. For the moment I made the default here 'en' but when the strongarm variables are finished this can become more dynamic / based on user role.

@deadlybutter actually @blisteringherb merged the strongarm stuffs in #5068

oh, great!

@deadlybutter might be worth making a new PR (perhaps before this one) to update dosomething_global_get_user_language()

Hmm, I dont have that function, Im still out of date

@angaither took care of all the comments I think -- should I work on merging this first? (otherwise it might start to get confusing) after that I'll rebase my code and update all the user language logic in a new PR

bahh, got a redirect loop on node/edit as a regional admin

fuckin redirect loops

@angaither I think we're good now

wait we're not. something happened to the git history. this looks like the same thing that just happened to @weerd


Exemplars should be sorted in Collector exporter

@franciscovalentecastro discovered in #777 that we need to make sure exemplars are sorted when sending to Cloud Monitoring or the points will be rejected.
We've been lucky so far, as most exemplars have come from explicit bucket histograms, where they are implicitly sorted.

This is the error i got when hooking up the go export of Exponential Histograms with the Exemplars from the algorithm implemented in https://github.com/open-telemetry/opentelemetry-go/pull/4455.
2023/12/14 19:14:57 rpc error: code = InvalidArgument desc = One or more TimeSeries could not be written: Field timeSeries[0].points[0].distributionValue had an invalid value: Distribution |bucket_options.exponential_buckets| has out-of-order/duplicate exemplars.
error details: name = Unknown  desc = total_point_count:2 success_point_count:1 errors:{status:{code:3} point_count:1}


docs(code-splitting): fix typo

Fixed a typo in the code splitting documentation: “Prefecting” => “Prefetching”.

Already updated on https://github.com/webpack/webpack.js.org/pull/2104, Please check for previous PRs before submitting yours.


王希<PHONE_NUMBER>7 作业1

WangXi17210130097  homework1.zip

homework2.csv.zip
homework2.ipynb.zip

homework3.ipynb.zip

homework4.ipynb.zip
homework5.ipynb.zip


[Nemo-792] Fix loop bugs

This PR:

makes the error message more informative
fixes the error occurring when there are vertices following the loop vertices
supports source vertices inside loop vertices (for writing to sink within each iteration)

resolves #792

Great! I just tested and it works well.


Create lts-20.19 Snapshot

This PR was created automatically because a new LTS was available.
See here for more details.
For a list of changed packages, see here.

@mastapegs feel free to see this all the way through. The tagged reviewer is meant to shepherd it across the line, and that could be anyone. Might as well be you!


Training fails with IndexError when performing train/test dataset splitting

Running a simple training command with some low-resolution training data (only 100 samples) gives me an error that gets triggered in train_for_one_epoch, when we enumerate(dataloader).  The index seems between 80-320 (I've certainly seen low 80s and high 300s).
There are 320 samples in all training subdomains combined (4 spatial domains, 80% each for training). We do batching with a size of 4. I've tried investigating and tinkering with these, but I've not managed to resolve it.
Doing either of these prevents the issue from occurring:

skip the subsetting (use the whole dataset for training)
use a single spatial domain

It would seem the problem is somewhere in Subset_ or related code, or in my xarray generated from the data step.

@CemGultekin1 I wonder if you came across something similar to this when looking at the gz code?


Exit

Hi. How I can exit in casperjs test? Using --engine=slimerjs. I'd tried:
console.log( 0 );
this.casper.die(1);
console.log( 1 );
this.casper.exit(1);
console.log( 2 );
phantom.exit(1);
console.log( 3 );
slimer.exit();
console.log( 4 );

Result:
0
Suite explicitely interrupted without any message given.
1
2
3
4
FAIL
# type assert
…
FAIL Error: WebPage not opened

WebPage not opened without end. Only ctrl+C in console breaking casperjs. Also I'd tried process.exit(), but process is undefined. Also I'd tried this.casper.options.exitOnError = true;.
How I can interrupt script after error?

Hm. I'm found reason. I'm using
this.casper.test.on("fail", function()
{
  // code
});

In code I'm ask page for one global variable (my debug). But page already closed, because casperjs in shutdown stage. In nodejs, process.exit kill current process. Here another behaviour. After wrapping that code by try cache, problem has been lost.


need Documentation for my javascript-practice-kit

Hi!
I'd like to contribute to the repository. Kindly assign me this issue.

Sure


Issue Title: "Add Cursor-Following Animation"

@mdazfar2
Issue Description: The website currently lacks interactive design elements that enhance user experience. I propose adding a cursor-following animation to create dynamic interactions where design elements move along with the mouse cursor, providing a more engaging and visually appealing experience.
I’d like to work on adding this feature. Please assign this issue to me under gssoc-ext, hacktoberfest-accepted, level

@AswaniBolisetti As of now, we do not need it. We will let you know in the future if there is a need. Please search for another issue and raise it, which I'm happy to assign to you.

Don't forget to give our repository a star and let me know once you've done it.


Rename Rect2 and Rect2i grow_margin() to grow_side()

As suggested here, renames Rect2 and Rect2i grow_margin() to grow_side().
Note: Includes updates to the documentation and the Mono module following #44605. Let me know if you want me to split it into separate commits.
Bugsquad edit: Supersedes #44743

At a glance it looks good, though I haven't compiled/tested it.
This makes #44743 obsolete, so if this is merged then #44743 should be closed. I updated the OP.

Thanks!


Fixed issues in version one properties builder shell file

When using docker to create a versionone collector, we found that there was no properties file was being created. This was due to a syntax error in the properties builder script when copying the values to the properties file. Once that file was created, the was no CRON being specified. CRON has been added to the versionone properties builder as well as the syntax errors being corrected.

@tabladrum LGTM

resolves https://github.com/capitalone/Hygieia/issues/1247
@brennanananan Thanks.


Fix for jenksBreaks() to correctly pull the breaks values

A fix for https://github.com/tmcw/simple-statistics/issues/88

Can you add a test that demonstrates the issue and that it's fixed?

Added two new tests, fixed one existing test.

:+1: thanks! Will merge once Travis-CI runs.

Coverage decreased (-0.0%) to 99.52% when pulling 4503b04e3b4767a42c5c9ac0c04713b7a9d5c92d on Joker-vD:master into a724dee89d55778c33b325661938da10bf59dc77 on tmcw:master.


Bug: NaN Calc world cframe

▶ If you see this report this as a bug, (NaN Calc world cframe) (x4960)  -  Client - Utilities:262
This bug happens pretty consistently, I am not exactly sure why.
I am using Version 0.4.0

Could you tell me if this happens on 0.3.1 aswell with the same setup you're currently using.

No, I haven't noticed the bug reappear. My apologies, I should have read your description more thoroughly.

From what i've seen it happens when you set the CFrame of the object via a WeldConstraint.
Thats what causes this for my use case.

Issue was resolved when reverting to 0.3.1


MSFT_HostsFile: Host entries that have multiple entries on a single line fail

Details of the scenario you tried and the problem that is occurring
When defining multiple entries on a single line it will write them to the host file every time the LCM kicks off.
Line 233 -259 takes in account for multiple entries per line but then a compare happens later against that array and a string that was passed into the Get-HostEntry.
Suggested solution to the issue
Change line 368
FROM: if ($result.Host -eq $HostName)
TO: if ([string]$result.Host -eq HostName)
The DSC configuration that is used to reproduce the issue (as detailed as possible)
HostsFile "Test1"
            {
                HostName  = 'test-ocsp-responder testVM.lab.local'
                IPAddress = '<IP_ADDRESS>'
                Ensure    = 'Present'
            }

The operating system the target node is running
OsName               : Microsoft Windows Server 2012 R2 Standard
OsOperatingSystemSKU : StandardServerEdition
OsArchitecture       : 64-bit
WindowsBuildLabEx    : 9600.19358.amd64fre.winblue_ltsb_escrow.190505-1600
OsLanguage           : en-US
OsMuiLanguages       : {en-US}

Version and build of PowerShell the target node is running
Name                           Value
----                           -----
PSVersion                      5.1.14409.1018
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14409.1018
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Version of the DSC module that was used ('dev' if using current dev branch)
<IP_ADDRESS> The code for this issue looks the same.

The hostname variable is a key property and appears to be intended for use with a single hostname value.  If it supported multiple hostname entries then it could create a resource state conflict like the following:
HostsFile "Test1"
{
    HostName  = 'test-ocsp-responder testVM.lab.local'
    IPAddress = '<IP_ADDRESS>'
    Ensure    = 'Present'
}

HostFile "Test2"
{
    HostName  = 'test-ocsp-responder'
    IPAddress = '<IP_ADDRESS>'
    Ensure    = 'Absent'
}

There would be no errors generated in the configuration block (or in the case of partials by the LCM when published) because the key properties are unique.  Then during execution one resource Test1 would attempt to add a host entry while the second Test2 would work to remove it.
I think the resource needs more checks in place if the intended input is supposed to be limited to a single host.  In its current form it handles single host entries correctly and needs to be configured iteratively for each hostname that shares an IPAddress to work properly.

  : Answer
    CNAME Record  . . . . : test-ocsp-responder


Add support for JSON configuration

Background in #26.
I'll make an initial attempt to support JSON and XML in parallel. I've already spiked it, looks like I can make it pretty cheap. Will begin only support JSON over HTTP (so file config still remain XML-only).
Let me know you don't have any objections @linkdata, and I'll bring it on.

Sure, just be aware that it's still a moving target. Especially the whitelist duality due to XmlSerializer not being able to handle Dictionary types.

Especially the whitelist duality due to XmlSerializer not being able to handle Dictionary types.

Yeah, sure. The idea I have involves basically no redesign of what is exposed already. It basically only extends it by acknowledging JSON when reaching out for config, and provides a super trivial adapter that expose such result as configuration type the log streamer already can work with. Future refactoring should be very straightforward.

I'm changing the pattern the log streamer use to identify a config argument, looking instead for *logstreamer.config.*. This allows us to support logstreamer.config.xml and logstreamer.config.json.
I'm still not changing the default from XML though, so things will work as they used to, if you just rename any existing config like that.

Pushelipushed in https://github.com/StarcounterPrefabs/LogStreamer/commit/8f8ed464db0316ab0523e22219d6a74d460a5416.
The log streamer now support file- and REST-based XML configuration, and additional REST-based JSON configuration.
Pseudo-code to provide the log streamer with JSON configuration from a HTTP server:
Handle.GET("my/custom/logstreamer.config.json", () => {
  var config = "{ "UpstreamUri": "my.upstreamnode.com:1234" }";
  return new Response() {
    ContentType = "application/json",
    StatusCode = 200,
    Body = config
  }
});

With the above running under my.childnode.com:80, start the streamer like so for it to be consumed:
star logstreamer.exe http://my.childnode.com:80/my/custom/logstreamer.config.json


You should be able to determine the real resolution in scaleform though, then you could pick which texture to mount based on that.
The stageWidth and stageHeight properties will be the actual resolution values not the scaled to 720p value.

So far I have been able to scale the loaded contents height to match the stage height. I have no eye for texture quality but its not looking terrible when the texture is scaled down in size.
https://github.com/Scrivener07/FO4_Overlays/blob/77d708d2b7fb20f3d585ae06af5b33cc6136d71e/Data/Interface/Source/FO4_Overlays/Overlays/OverlayMenu/OverlayLoader.as#L164

Im closing this for now until it needs to be revisited.


Error when registering a bot

I get the error: This item cannot be accessed or modified when trying to create a new bot.

Thanks for reporting this. Meanwhile, can you close your browser and try again?

I switched to chrome, worked in chrome.

If you can give any details on the browser & version that would be helpful. Thanks!

Microsoft Edge 38.14393.0.0
Microsoft EdgeHTML 14.14393

@danmarshall is this something we can fix or have to live with?

Closing this issue for now, please feel free to open a new issue if you encounter it.

Also coming in chrome for me.
Version 56.0.2924.87 (64-bit)

if you can try sign out of https://dev.botframework.com and sign back in, it might clear up your browser side state and unblock you. We will investigating for a code fix in the mean time.

I tried open in incognito, it solved my problem but the app id and app secret were gone. So I have to create new app id and secret. Other wise opening in incognito worked for me.

I'm closing this issue, as it is no longer occurring.

The issue is occuring in IE 11 (11.0.9600.18697) for me. Used the Chrome workaround with Version 59.0.3071.115 (64-Bit).

I'm facing the same issue on IE 11 (11.0.9600.18697).
I tried the workaround using Chrome (Version 59.0.3071.115 (Official Build) (64-bit) ) but it didn't work for me.
Using Chrome, I cannot select any template.

@IRRDC @GuilhermeQuelhos - thanks for your comments. Are you seeing the exact same issue as in the screenshot at the top of this issue? If not, can you open a new issue since this may not actually be the same situation.

I see the same message as in the original screenshot when I try to create a bot based on the first 3 templates. Also when I try to edit (in IE) the bot I created using Chrome I end up not on the bot's page but on the template selection page.

Same issue is occurring on IE 11 for first three templates.
When Language Understanding is chosen it ask to sign in and after successful sign in it gives option to create new blank LUIS app or use LUIS api key to connect. When clicked on continue it again displays the same message.

Open a new issue if you are still having problems


Allow BGP password to be passed as a kubernetes secret

Today kube-vip takes BGP password as a clear text input in the pod/ds manifest. This is not recommended in production scenarios.
This is an enhancement request to allow taking BGP password as a Kubernetes secret.

When you install with the helm chart, you can use envFrom to use a secret for any of the environment variables.
https://github.com/kube-vip/helm-charts/blob/024029685615ddedac85acd4bb503bca28841361/charts/kube-vip/values.yaml#L32

This can be fixed using kubernetes native functionality.


Module Panel?

Thank you all for this contribution! I'm excited to go build one. I don't think I saw a file anywhere for the module panel however, is there one that's available for sharing along with this project?

Thanks for the support @versipellis, the board design and module panel were made by @mart1ver so maybe he has the panel file in store somewhere to share ?


Looks like they changed their URLs around again. Fixing

After my last PR, unsplash changed up their URLs. I ran it with some print statements and it looks like image_id is str(tag['href']).split('/')[4] for both the main page and an individual profile
$ python3 unsplash_download.py ~/Dropbox/Photos/wallpaper
Parsing page https://unsplash.com/?page=1
image_id is sYegwYtIqJg
download_url is http://unsplash.com/photos/sYegwYtIqJg/download

and then running it against a profile
python3 unsplash_download.py ~/Dropbox/Photos/wallpaper @joerobot
Parsing page https://unsplash.com/@joerobot/?page=1
image_id is vLICFzBqoYY
download_url is http://unsplash.com/photos/vLICFzBqoYY/download
image_id is _YOipESU2SE

I could submit another PR with the change if you'd like.

Thanks for providing that patch. I'll upload this to pip later today.


Fix unwind issue on Travis ARM

See https://travis-ci.org/cwida/duckdb/jobs/598262901
As far as I can tell, this is an issue linking unwinder libraries. Crucial line is
terminate called after throwing an instance of 'std::runtime_error'
No idea how to fix this though.

turned out -fexceptions and -frtti needed to be set explicitly


UIRS-7 Remove/delete remote storage configuration

Purpose

https://issues.folio.org/browse/UIRS-7
Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.

[ ] I've added appropriate record to the CHANGELOG.md
Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

yarn run v1.22.4
$ eslint .
/home/jenkins/workspace/olio-org_ui-remote-storage_PR-18/project/src/RemoteStorageSettings.js
3:17  warning  'Switch' is defined but never used  no-unused-vars
/home/jenkins/workspace/olio-org_ui-remote-storage_PR-18/project/src/RemoteStoragesList/RemoteStoragesList.js
30:3  error  'newStorage' is missing in props validation  react/prop-types
/home/jenkins/workspace/olio-org_ui-remote-storage_PR-18/project/src/RemoteStoragesList/RemoteStoragesListContainer.js
53:6  warning  React Hook useCallback has a missing dependency: 'mutator.configurations'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
✖ 3 problems (1 error, 2 warnings)
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

yarn run v1.22.4
$ eslint .
/home/jenkins/workspace/olio-org_ui-remote-storage_PR-18/project/src/RemoteStorageSettings.js
3:17  warning  'Switch' is defined but never used  no-unused-vars
/home/jenkins/workspace/olio-org_ui-remote-storage_PR-18/project/src/RemoteStoragesList/RemoteStoragesList.js
30:3  error  'newStorage' is missing in props validation  react/prop-types
/home/jenkins/workspace/olio-org_ui-remote-storage_PR-18/project/src/RemoteStoragesList/RemoteStoragesListContainer.js
53:6  warning  React Hook useCallback has a missing dependency: 'mutator.configurations'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
✖ 3 problems (1 error, 2 warnings)
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.


Supported OS

@dimilider commented on Fri Feb 01 2019
Hey all,
the documentation is mentioning that the most used OS's are not supported -> https://docs.microsoft.com/de-de/azure/virtual-machines/extensions/dsc-linux#operating-system . btw, the link to the supported OS's is down. But on a other GitHub page (https://github.com/Microsoft/PowerShell-DSC-for-Linux#supported-linux-operating-systems) the OS's are supported. I think there is a missmatch between the both sources?
Regards,
Dimitri

Hi team,
Please check the issue reported.
Thanks!

@roiyz-msft can you take a look?

#reassign: @MicahMcKittrick-MSFT

This doc is correct. It is stating only two that are not supported while the github lists all the ones that are supported.
#please-close


Improve performance by doing more work in the worker

Currently the worker tokenizes the code and then turns it into a
JSON string. This JSON string is sent back to the main thread as a
message and parsed. Then it is turned into a HTML string and
stored in the attribute env.highlightedCode.
These conversions into JSON are unnecessary, because we can create
the HTML string directly in the worker and send it as a message to
the main thread.
Signed-off-by: Andreas Rohner<EMAIL_ADDRESS>

Hi! Nice catch, indeed. Thanks for contributing!


deps/template oss

chore: tap@16
deps<EMAIL_ADDRESS>

gonna back out of this for now, other things depend on this that aren't on template-oss yet.


Improved UI

1.I am adding blinking cursor to bottomline of tailfile output
2. I am adding auto scroll with newest output

@god-father01 I would prefer not changing the UI as the terminal look does not seem a lot intuitive and it suppose it's only tailing one file and that too by default without any apparent option to change. This project is supposed to tail any file in the indexed directory.
Please raise another pull request as this pull looks with a lot of changes.


Bookmarks window in dark mode is blinding - limits of Firefox theming?

Second thing, again for dark mode as my previous issue; bookmarks window in dark mode is blinding.
Is this within the limits of Firefox theming?
I've learned over the years that there's things that Firefox won't allow getting themed no matter how much effort you put into doing so. Not with CSS anyway.

As far as I can see, it seems like you might have been singing the song and sent me the screenshot in light mode. Have you enabled Light Mode macOS-wide?

That's odd - I think it must have been a user error. I can't remember if I was using dark theme or light mode for this , but using dark mode with the release I was using at the time does yield this exact appearance .. Also the title of that song is "Blinded by the lights" And no, I don't listen to it - I just know it is the title of the song. I am sorry for being a doucebag.

Ah No prob 😄


Investigate HTML5 3D issues

TurboFat's 3D parts don't work in HTML5. We should try to figure out why.

Is this a problem with TurboFat, or does it apply to all 3D games?
If this is a problem with TurboFat, can we run it in some kind of low-graphics mode or disable the problematic bits?
If 3D isn't supported at all, can we consider a fork of TurboFat which just makes the 2D/scenario bits accessible? Or, maybe a simplified sub-mode?

The more I think about it, the more a 2D/simplified mode might be nice anyways for the web. We'll have to see how it runs in the browser. I think this game could be about 1,000x more popular if a simpler ~50MB version is available on a web page with:

fewer characters
less music
simpler graphics
minimal story

Whatever it takes to make it run fast but still be fun.

We should also consider getting rid of 3D mode entirely, as it doesn't add much gameplay-wise.
The player could navigate a 2D overworld with the same immersion of a 3D world.
Pros:

Lower hardware requirements, game can probably run on a potato (or more importantly, in a web browser)
Lower risk of physics glitches, issues #176 and #174 are closed outright
Don't have to implement the player jumping, issues #135 and #113 are closed outright

Cons:

As a developer, I won't get experience working in 3D
Higher risk of 2D-based layer glitches, #94 and #51 become more pertinent
Have to implement 2D cameras correctly, #54 becomes more pertinent
Have to redo some spatial logic we've done in 3D, such as camera logic
Have to redo the visual/map logic we've done in 3D, although it should be easier in 2D

@crumblingstatue has done some research into this issue, here are their findings

Is this a problem with TurboFat, or does it apply to all 3D games?

This is a problem with all 3D games. Until the OpenGL ES 3 renderer is removed from Godot in favor of Vulkan, HTML5 export uses WebGL 2 when the GLES option is selected. Godot's WebGL 2 renderer has issues with 3D and is no longer maintained. In summary, we can not do 3D with GLES3.

If this is a problem with TurboFat, can we run it in some kind of low-graphics mode or disable the problematic bits?

Well, we can downgrade to GLES2. WiIn GLES2, it is smooth except that the colors are wrong and shaders have problems #1.
Additionally, @crumblingstatue investigated building Turbo Fat for mobile with GLES2, and found that it crashed with the following shader error:
SHADER ERROR: Built-in function "textureSize(sampler2D, int)" is supported only on high-end platform!

If 3D isn't supported at all, can we consider a fork of TurboFat which just makes the 2D/scenario bits accessible? Or, maybe a simplified sub-mode?

While 3D is supported, it is probably less work to make a 2D version of it than to maintain two separate 3D versions. However, I'm leaning more towards making zero 3D versions, and just making the overworld 3D.
Making the game fully 2D carries many benefits, and will probably accelerate development. I don't think it will negatively impact the gameplay or appearance of the game either, it may even look better as it will be easier to tweak the appearance of the game in 2D, and because I have more experience drawing 2D sprites than modelling 3D objects.


SAA-204 update risley pay bands

This changes Risley's pay bands from Low, Medium, High to the default 1-10 used by NOMIS in all emvironments.
(similar to how LEI is setup in our service).
It also updates any Activities and Allocations as part of the migration.

Codecov Report
Patch has no changes to coverable lines.
:loudspeaker: Thoughts on this report? Let us know!.


format description for EHR/EMR input file

Dear Vincent, Sara and Risteys team:
I am wondering is there any page to share format of EHR/EMR input file. I am trying to use this platform for some other cohort, but I am not sure what exact format for the EHR/EMR input file should be prepared.
Thanks.
Shicheng

Hello Schicheng :wave: !
Thanks for contacting us, it is exciting to have people use this project!
Probably the best resource would be found in the FinnGen analyst handbook, especially these relevant articles:

Phenotype files in Sandbox
Interpretation of the Endpoint Definition file

Hope this helps :slightly_smiling_face: .

Thank you so much, Vicent!! This information is quite helpful. I will check carefully for the format.
Shicheng


Add services section

Change the features section of the template to the offered services

Link to docs with info


fix(pkg/driverbuilder): fixed debian rpi and rt flavors kernel urls fetching

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it:
This PR fixes support to fetch kernel headers for debian rpi and rt flavors, where the common package has the -$flavor suffix.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Example:
./_output/bin/driverkit docker --target debian --kernelrelease 4.19.0-26-rt-amd64 --kernelversion 1 --output-probe /tmp/mod.o --loglevel debug --builderimage auto:master
level=DEBUG msg="running without a configuration file"
level=DEBUG msg="running with options" output-module="" output-probe=/tmp/mod.o driverversion=master kernelrelease=4.19.0-26-rt-amd64 kernelversion=1 target=debian arch=amd64 kernelurls=[] repo-org=falcosecurity repo-name=libs
level=INFO msg="driver building, it will take a few seconds" processor=docker
level=DEBUG msg="doing a new docker build"
level=DEBUG msg="kernel header url found" url=http://security-cdn.debian.org/pool/main/l/linux/linux-headers-4.19.0-26-rt-amd64_4.19.304-1_amd64.deb
level=DEBUG msg="kernel header url found" url=http://security-cdn.debian.org/pool/main/l/linux/linux-headers-4.19.0-26-common-rt_4.19.304-1_all.deb
level=DEBUG msg="kernel header url found" url=http://mirrors.kernel.org/debian/pool/main/l/linux/linux-kbuild-4.19_4.19.249-2_amd64.deb

As you can see, proper headers are now found and the build succeeds:

level=INFO msg="eBPF probe available" path=/tmp/mod.o

Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

On master instead:
./_output/bin/driverkit docker --target debian --kernelrelease 4.19.0-26-rt-amd64 --kernelversion 1 --output-probe /tmp/mod.o --loglevel debug --builderimage auto:master
level=DEBUG msg="running without a configuration file"
level=DEBUG msg="running with options" output-module="" output-probe=/tmp/mod.o driverversion=master kernelrelease=4.19.0-26-rt-amd64 kernelversion=1 target=debian arch=amd64 kernelurls=[] repo-org=falcosecurity repo-name=libs
level=INFO msg="driver building, it will take a few seconds" processor=docker
level=DEBUG msg="doing a new docker build"
level=ERROR msg=exiting err="kernel headers not found"

/cc @EXONER4TED

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: EXONER4TED, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [EXONER4TED,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add GA/EA versions to build pipeline

This enables CI builds for the latest Java versions supported by OpenJDK.

Awesome, thanks for raising the PR! Seems the CI is not letting me trigger a run of this on the PR so I'll merge for now and investigate separately.


Feature/denone

@diorcety can you check this solves your issues with None?

@diorcety thanks for the live feedback. This should be okay now?

Yes, it's 👍

This is definitievely not the way too go, fat too hacky, I'll put this one in pause and rework it later.

Obsoleted by #939


Matches with branchpoint builder implementation.

🦟 Bug fix
Matches with https://github.com/maliput/maliput_sparse/pull/24
Summary
It was failing when creating the road geometry because of the constraint of having a branch point at the ends of each lane.
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Note: it does not solve #18 but at least it does not fail at runtime.


BLE Stop advertising after 5-7 days of running

Not sure if this is the right place to ask , but cannot find better
I use ESP32 BLE for configuration,  updated, log etc. on my device , but from time to time after leaving the device running for days it stops advertising itself to make sure that the problem is not in bad disconnection/connection etc.  I put a code to break connections longer then 30m in and re advertising after 30 min - but it seems this do not help ... the esp32 and all other tasks are working fine juts the BL|E stop advertising
for breaking a connection that stay too long I use :  bleServer->disconnect(bleServer->getConnId()); // force disconnect
for re advertising I use : bleServer->startAdvertising(); // restart advertising

Try to add code that checks free heap and there is custom gap handler which you can add to see low level events, its helpful to debug.
You an find in Kolban's repo and arduino how to add custom handlers.

already there the heap check - plenty of heap...
my guess is that it is something with RTOS - as only the BLE lib uses RTOS...
re: custom handles - to what ? the BLE advertizing or ?

https://github.com/nkolban/esp32-snippets/issues/735#issuecomment-444007131


Update README and command descriptions.

Updates README to indicate 'particularly experimental' nature of some commands.   Updates command descriptions for help text to correct scope, and adds a '*' character to particularly experimental commands.

Merging


is more a question

I really tried everything but how to change prefix??? Nothing seems to work

By using the prefix command, e.g. $botify prefix . to change it to '.'


Add collaborators to this repo

Comment below to be added as a collaborator
We will all be using this repository today. Even though it's public right now, you will not be able to make changes until you're given the correct permissions. We've automated this process via the GitHub API. Once you comment, we will add you as a collaborator.
You'll start to receive a lot of emails. (❗) You can slow these down immediately by clicking the Unwatch button at the top of the page and selecting either the Participating and @mentions or Ignore option.

Hey Jamie! 😃

hello

Comment. 🌮

Hi, this is Mark


[Site] Adapt highlighted code blocks to tempest

Very mid.. but i'd like to clean the "CodeBLock" / "Terminal" / "CodeLine" first :)

Thanks Simon.


⚠ Auth API Endpoint has degraded performance

In 0439cfc, Auth API Endpoint (https://auth.roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 1466 ms

Resolved: Auth API Endpoint performance has improved in 670fb85.


Possible division by zero

Hello!
During the static analysis was found possible mistake:

Variable int64(len(h.handlers)), whose possible value set allows a zero value at pool.go:45, is used as a denominator at pool.go:45.

func (h *PoolHandler) Handle(ctx context.Context, r slog.Record) error {
	// round robin
	rand := h.randSource.Int63() % int64(len(h.handlers))
	handlers := append(h.handlers[rand:], h.handlers[:rand]...)

Please clarify whether this requires correction?

Fixed in #15 -> v1.2.4

@Bbulatov my SAST did not detect it. What tool do you use ?

@samber I used Svace


Eager loading

Hi there! Does Bun support eager loading?

No

You could develop some controllers for the model to eager load. You this for reference. Just specify the relation...
https://bun.uptrace.dev/guide/relations.html#introduction

Eager loading only slows bun's performance hence its not supported. If you want to fetch all relations at once just build a model controller


Drawer does not transition closed when initialised as open

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Initialising a Drawer component in the open state, then setting that state to closed, will not perform a close transition for that first state change. Further changes to the open state are transitioned properly.
Expected Behavior 🤔
The Drawer should transition each way regardless of what state it was initialised in.
Steps to Reproduce 🕹
Codesandbox Demo
Steps:

Click on the backdrop to close the Drawer from the open state.
Observe that it jumps closed instead of transitioning.
Observe that the same issue does not occur on further changes, or when initialising in the closed state.

Context 🔦
I would like the Drawer to be initialised as open on certain routes of the React application I am building.
Your Environment 🌎
@material-ui/core: 4.11.3
react: 17.0.1
react-dom: 17.0.1
react-scripts: 4.0.0

Issue is observeable in both Firefox and Chrome on a Windows 10 machine.

I've noticed the same behavior on Mui web-site. If you minimize the window to be able to see a menu button, then click on it, it will open a drawer, then maximize and minimize window again in order to see the same drawer opened, once you try to close it, there is no going to be any transition.

I am new to Material Ui, I made a layout that opens and closes depending on the witdh of the window, I hope it will help you!
https://github.com/cmcodexv/layoutReactJS

Also happens in v5: https://codesandbox.io/s/materialui-drawer-demo-forked-791sr


Support for Node 20

The following actions uses Node.js version which is deprecated and will be forced to run on node20: ..., wearerequired/lint-action@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

It seems to run fine, but it would be good to officially support it?

Duplicate of #787.


Underscores in variable names crash compiler

If underscore is present in variable name the compiler crashes in an unfriendly manner:
x_a=1

thread '' panicked at 'not yet implemented: top-level destrucuture patterns are not implemented', crates/compiler/load_internal/src/file.rs:5926:26
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
The funny bit is that roc check actually knows that _ is not allowed, but roc compiler just crashes.
roc repl crashes in a similarly unfriendly manner:
❯ roc repl

  The rockin' roc repl
────────────────────────

Enter an expression, or :help, or :q to quit.

» x_1=3
thread 'main' panicked at 'not yet implemented: handle pattern other than identifier (which repl doesn't support)', crates/repl_ui/src/repl_state.rs:123:25
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This problem still exists, but won't for long: Underscores will now be allowed after https://redirect.github.com/roc-lang/roc/issues/7214 . So I'm closing this issue.


Develop panel to include all results form a given query

Updated displayPanel() function to create and append a child element for each search result obtained from query
Initially hides panel, only reveals panel once there are search results to be displayed
Refreshes results list each time, so new results are not just added to old results

LGTM!


[Network-Manager] az network manager group static-member create

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Network-Manager


Allow literals without braces in html!

Description
Allows for all kinds of literals to be passed to the html! macro without enclosing them in braces as would be required for any other Rust expression, thus, for example, making the following valid:
html!{"Yew" 0.21}

The docs are updated accordingly.
Checklist

[x] I have reviewed my own code
[x] I have added tests

I remember it being a deliberate decision to require braces around the literals. I, personally, am not in favor of this change either.
Why do you think it would be better to allow literals like that? I think if we can't allow
yew 0.21

then there isn't really a point in removing the braces (we can't allow that because it's a parsing nightmare). The braces indicate any rust expression, which includes literals. Also, "Yew" 0.21 not only looks weird, compared to "Yew 0.21" but also isn't even valid Rust (literally or expression).
There's also the question of what to do with white spaces. HTML treats them as one whitespace, Rust ignores them. How should multiple literals be joined? Should they just be concatenated? Should they be different text nodes?

I've read the prior discussions on this proposal, and the main argument against it was that it makes it unclear whether the literals will be parsed as HTML or as Rust code, and that is a valid concern, however I believe that, in this case, being idiomatic about the syntax only hurts the developer experience. If we really wanted to be idiomatic, we'd have to remove if and {for x} expressions, since the first is "ambiguous" (for someone who sees Yew for the first time) and the latter is wrapped in braces but is not valid Rust syntax. html! is not Rust, it's not HTML, it's yew::html!, and there's documentation for it, so I believe we should focus on improving the experience for developers, not for those who see the framework for the first time and haven't checked any guides, examples, or the docs.
Regarding handling of whitespace, even though html! doesn't claim to replicate Rust syntax, it is lexed by Rust, which is whitespace-insensitive, I think we should respect that.
Besides, the PR only makes braces optional, if you want your literals separated from your HTML, you can always do that.

I agree with the point raised by @hamza1311 and this has been discussed numerous times.
The concerns raised by the original issue still stands today and hasn't changed.

Also, "Yew" 0.21 not only looks weird, compared to "Yew 0.21" but also isn't even valid Rust (literally or expression).

There is also the question of whether "Yew" 0.21 should be interpreted as Yew 0.21 or "Yew" 0.21 when passed to create a Text node. When you write
"Yew" 0.21
 in html, it is created as
"Yew" 0.21
.

Regarding handling of whitespace, even though html! doesn't claim to replicate Rust syntax, it is lexed by Rust, which is whitespace-insensitive, I think we should respect that.

However, the common writing style is space aware.
If we are not aware of the spaces, then we have to make a decision of whether we want to insert spaces for users.
We could not make a choice of between of having space or not having spaces between literals and represents both
"Yew" 0.21 and 20"km/h" nicely.

you mean using the debug formatting? "Yew" 0.21

I meant to say that if the content is not inside a brace, it should be rendered as if the content are written between 2 html tags.

I think it's more intuitive to use the ToString implementation. That's already how it is today for the things wrapped in {} no?

This is because {expr} represents a Rust expression, and it actually uses ToHtml to dedicate how expressions are converted to Html.

Anecdote: well actually xD you don't write 20km/h but 20 km/h because it's the International System of Units

TIL, Interesting.

More seriously: I think a single breakable space for separation is the most intuitive solution. It's like when writing spaces between arguments in bash, you do expect a single space to come out, not all the extra space you added in your terminal.

Terminals actually are aware of whether there are spaces around tokens.
 ➜  ~ echo 20"px"
20px
 ➜  ~ echo 20 "px"
20 px

There are cases where things are legitimately broken if spaces are present / not present between tokens when they should or should not be when it comes to html contents.
See: https://github.com/futursolo/stylist-rs/issues/104

There are cases where things are legitimately broken if spaces are present / not present between tokens when they should not or should be when it comes to html contents, in which I have come across in another project. So I do not wish Yew to pertain a similar kind of issue with html! when I already had to accept that it wouldn't be fixed anytime soon.
See: futursolo/stylist-rs#104

I understand better where you're coming from. I'm not sure if the html! macro can be compared to the css! one tbh... The issues you explain are real in CSS but in HTML the behavior of spacing is very different:

One or more spaces are translated as one space: https://jsbin.com/talusevuzu/edit?html,output
It's only really used for putting arbitrary text in arbitrary node. There isn't any syntax quirk here like in CSS.

We do not have the spacing information with the current procedural macro.

I don't think we need to. The spacing behavior in Rust parser is actually similar to the HTML. One or more space is basically the same as a single space.
This case you mention is very specific to bash:
 ➜  ~ echo 20"px"
20px
 ➜  ~ echo 20 "px"
20 px

Because "px" is first evaluated as string then put in place into the rest of the expression. This should not exist in html! macro. Actually I don't know any modern programing language that has this feature but it's a very confusing one so it's best not to have it.
What I'm trying to say is that maybe we don't need more than that. It has to be close to HTML and that's it.

This is because {expr} represents a Rust expression, and it actually uses the ToHtml trait to decide how expressions are converted to Html.

I do think it makes sense to wrap expressions into {}. The parser of syn will force us to do so (we had that exact problem back in the day when attributes where allowing expressions without the {} such as <input stuff=Animal::Cat />... the tldr was that, if we want to be able to do <input ...props />, we need to force expressions to be wrapped in {}).
But just like the parser for attributes, literals were not the issue. Strings, numbers and booleans can be used with syn without the {} just fine. <input foo=42 bar=true baz={ah_thats_an_expression()} />

The thing is, we don't even get one space. The Rust lexer ignores the spaces and will give the literals to us as if they were written without any spaces

I'm not sure if the html! macro can be compared to the css!

CSS can be inlined in the  tag. So issues applies to css! ultimately applies to html!.
(Unless it's OK to tell everyone to use stylist for CSS inlining.)

20"px" ... This should not exist in html! macro.

I agree, kind of.
I feel if I write
20"px"
, then I should get 20"px" in my browser window as if I am writing HTML.
(How React-JSX works.)

I do think it makes sense to wrap expressions into {}.

If the ultimate goal is to pursue text content / literals rendered without braces,
for content between html tags, we have to choose between:

content inside of {} (or another kind of identifier) is evaluated as expression, otherwise HTML text nodes.
everything is evaluated as an expression.

The ideal result for these solutions are:

The latest version of Yew is {ver}.

"The latest version of Yew is " ver "."

(Let's assume we don't have spaces between tokens for now. Or we have to use format!)

By the end of the day, I would definitely prefer 1 over 2.
Solution 1 is partially achievable once proc_macro_span is stabilised.
(Given the content can be tokenised as valid Rust tokens.)

CSS can be inlined in the  tag. So issues applies to css! ultimately applies to html!.

Good point

I feel if I write
20"px"
, then I should get 20"px" in my browser window as if I am writing HTML.

I would definitely prefer a compile error if no space.

By the end of the day, I would definitely prefer 1 over 2.

Same :+1:

If in the future we wish to make
The latest version of Yew is {ver}.
 possible,
it will be very difficult for users to remove quotation marks from all of their html! as it will be rendered as-is.

Good point... though I feel comfortable committing into the solution 2. But your example clearly shows that not forcing the space could be really useful. So I'm in doubt.

To be honest, the arguments here were so compelling I'm no longer in favor of my own PR, feel free to dismiss it.

By the end of the day, I would definitely prefer 1 over 2.

Same 👍

I misread. I'm definitely in favor of 2 instead of 1. Solution one is risky, it will brings tons of issues with the parser I can smell that.

To be honest, the arguments here were so compelling I'm no longer in favor of my own PR, feel free to dismiss it.

coward lol
tbh I don't care that much but I do recognize it would be useful and safe to allow literals. But again I don't really care, the {} does not bother me at all.


Possible fix for webpackHotDevClient disconnecting from server.

Hello I would like to submit a fix for the issue people are having with the websocket in webpackHotDevClient.js disconnecting from the server. The websocket is timing out after some time, so we simply ping the server periodically to prevent it from timing out. Here is the code I've been using.
// Ping the server to prevent the client from disconnecting
var ping = function() {
  if (connection && (connection.readyState === connection.OPEN)) {
    connection.send("ping");
    setTimeout(ping, 3000);
  }
};

connection.onopen = function() {
  if (typeof console !== 'undefined' && typeof console.info === 'function') {
    console.info(
      'The development server has connected.'
    );
  }

  ping();
};

I have a branch ready here. I can submit a PR.
https://github.com/vibelife/create-react-app/blob/master/packages/react-dev-utils/webpackHotDevClient.js#L85

Hi @gamedev8. You say others were experiencing issues? Would you mind providing a link for reference?

I am experiencing the same issue. If I don't make any code edits, the dev server web socket connection times out after 5 minutes. Is this related to the switch to native ws transport from sockjs done in https://github.com/facebook/create-react-app/pull/7988?

Every websocket connection should have a keepalive to prevent firewalls from terminating the connection unexpectedly because they think it's "idle". Sockjs defaults it to one ping every 25s which seems like a good default to me.

We pin the version of webpack-dev-server, so you've likely just installed another version in your tree that isn't being used. You can try yarn resolutions.

I had deleted the webpack-dev-server version I had from my node_modules folder, then installed 3.10.2. When I tried to run my application CRA detected the new version and printed a long warning. I had to put SKIP_PREFLIGHT_CHECK=true in my .env file to get around the warning.

Yeah that's not gonna work. Try npm ls webpack-dev-server. You'll likely see two versions installed. You'll need to use yarn resolutions to force the newer version to be installed in the correct location to test the fix.


Add ZooKeeper Namespace Id-to-name mapping

This PR is part of an ongoing work to improve efficiency and reduce slowdown of retrieving and writing namespace names and table names in ZooKeeper. These particular changes modify the namespace names, and a follow-up PR in the near future will modify the table names. It replaces the use of the /name nodes under namespaces with a namespace id-to-name mapping in a Json format stored under the /namespaces node. With this, when any function wants to retrieve a namespace name, ZooKeeper will only need to read the single mapping instead of iterating through all /name nodes every time.
New files added for implementation:

core/src/main/java/org/apache/accumulo/core/clientImpl/NamespaceMapping.java: Class that holds functionality for initializing, retrieving, writing, serializing, and deserializing namespace id-to-name map (and name-to-id map).

Files changed for implementation:

ClientContext.java: Allow namespace mapping to be retrieved from ZooKeeper by referencing the context.
Namespaces.java: Update namespace name retrieval functionality with new mapping.
ZooKeeperInitializer.java: Replace initialization of default and accumulo /name nodes with creation of new mapping.
TableManager.java: Update namespace creation functionality to use new mapping.
RenameNamespace.java: Replace usage of /name node to instead use new mapping.

Files changed for upgrading:

Constants.java: Deprecate ZNAMESPACE_NAME, as the /name node will no longer be used.
Upgrader11to12.java: Build namespace id-to-name mapping in ZooKeeper out of current /name nodes. Follow with deletion of /name nodes.
Upgrader11to12Test.java: Add test code respective to additions made in Upgrader11to12.java.

Original Issue: #4698

On hold until Upgrader11to12Test is fixed.

Upgrader11to12Test has been fixed and passes now.

Commit dd8c4fa has moved all namespace mapping actions (create/put, rename, remove) into NamespaceMapping, ensured that mutateExisting() is used in all cases, and gives checks for non-existent/already-existing namespaces (depending on the action). The actual namespace node creation and removal functionalities remain in their respective classes and occur after the mapping is updated.

@meatballspaghetti  - please take a look at NamespacesIT, I'm seeing 4 tests fail with the same type of error:
java.lang.IllegalArgumentException: Multiple entries with same key: =+default and =x
	at com.google.common.collect.ImmutableMap.conflictException(ImmutableMap.java:382)
	at com.google.common.collect.ImmutableMap.checkNoConflict(ImmutableMap.java:376)
	at com.google.common.collect.ImmutableSortedMap.fromEntries(ImmutableSortedMap.java:560)
	at com.google.common.collect.ImmutableSortedMap.access$100(ImmutableSortedMap.java:68)
	at com.google.common.collect.ImmutableSortedMap$Builder.buildOrThrow(ImmutableSortedMap.java:739)
	at com.google.common.collect.ImmutableSortedMap$Builder.build(ImmutableSortedMap.java:718)
	at org.apache.accumulo.core.clientImpl.NamespaceMapping.update(NamespaceMapping.java:148)
	at org.apache.accumulo.core.clientImpl.NamespaceMapping.getNameToIdMap(NamespaceMapping.java:160)
	at org.apache.accumulo.core.clientImpl.Namespaces.getNamespaceId(Namespaces.java:83)
	at org.apache.accumulo.core.clientImpl.Namespaces.lookupNamespaceId(Namespaces.java:97)
	at org.apache.accumulo.core.clientImpl.Namespaces.namespaceNameExists(Namespaces.java:110)
	at org.apache.accumulo.core.clientImpl.NamespaceOperationsImpl.exists(NamespaceOperationsImpl.java:113)
	at org.apache.accumulo.test.NamespacesIT.createAndDeleteNamespace(NamespacesIT.java:220)

I'm seeing 4 tests fail with the same type of error:

I didn't see that specific stack trace when running NamespacesIT in the 3.1 branch. I got different exceptions instead. Perhaps that stack trace only appears in the main branch? I did fix the test failures I saw in 3.1 with #5067. I tested a local merge to the main branch and NamespacesIT passed there also.


Postgresql service not shutting down (process-compose hangs)

What happened?
What's happening
The postgresql service does not shut down correctly.
The process-compose TUI hangs forever when trying to quit.
The postgresql os processes are kept running if you kill the process-compose terminal.
What to expect
If you press F10 the postgresql service should shut down correctly.
Steps to reproduce

Create a new devbox shell env
Install glibcLocales if needed, and postgresql
Run devbox services up
Wait for postgresql to be ready
Try to stop the server with F10 which also quits the TUI

Command
services
devbox.json
{
  "$schema": "https://raw.githubusercontent.com/jetify-com/devbox/0.13.4/.schema/devbox.schema.json",
  "packages": {
    "glibcLocales": {
      "version":   "latest",
      "platforms": ["x86_64-linux", "aarch64-linux"]
    },
    "postgresql": "latest"
  },
  "shell": {
    "init_hook": [
      "echo 'Welcome to devbox!' > /dev/null"
    ],
    "scripts": {
      "test": [
        "echo \"Error: no test specified\" && exit 1"
      ]
    }
  }
}

Devbox version
0.13.4
Nix version
No response
What system does this bug occur on?
Linux (x86-64)
Debug logs
No response

my current workaround is this script
{     "scripts": {         "down": [             "pg_ctl stop -m fast",             "devbox services stop"         ]     } }

@behzade  that works. Thanks.

Maybe related to https://github.com/F1bonacc1/process-compose/issues/258

@carlotm Doing some testing with this, I think the best option is to revert process-compose to 1.24.2 until there is a fix on the process-compose side. I'm seeing the same issue, but can't create a process-compose.yaml that reliably circumvents it

@Lagoja thanks for testing.
Dumb question:
can I downgrade just process-compose? Installing an older version in a shell does not seem to work, it always picks up 1.34.0

New release is out at 0.13.5 that reverts process-compose back to 1.24.2. Can you verify that fixes the issue?
@carlotm, we don't currently support it, but this issue makes me think we should have some override. An issue is that letting users override the version of process-compose they want to use may break some Devbox features, so we'd probably want a minimum version requirement somewhere.

@Lagoja The new version fixes, thank you!
@Lagoja maybe a new key in the json schema for the process-compose version?


Run always/rescue tasks when cancelling a task in a block with SIGINT/SIGTERM

Proposal: Run always/rescue tasks when cancelling a task in a block with SIGINT/SIGTERM
Author: Strahinja Kustudic @kustodian
Date: 2018/06/15

Status: New
Proposal type: improvement
Targeted Release: 2.7
Associated PR: N/A
Estimated time to implement: N/A

Motivation
Ansible has blocks and they allow us to have tasks which will be executed in case of failure which should be stated in the rescue section and tasks which should be run all the time which is stated in the always sections. This is very useful if you need to do some clean up, or some post tasks in case of failure, or always.
Problems
The problem is that if you cancel a task in a block which has a rescue/always sections by sending SIGINT/SIGTERM to the ansible-playbook process, Ansible just stops the execution and exits, it doesn't run the tasks in rescue/always sections.
For example we have the following playbook which runs some stress tests which looks like this:
---
- hosts: hosts_to_burn
  vars:
    duration: 24
    data_size: 120
    dirs:
      - /tmp
  tasks:
    - block:
        - name: Install sysbench
          yum:
            name: sysbench
            state: latest

        - script: files/burn.sh '{{ duration }}' '{{ data_size }}' {{ dirs | join(',') }}
          async: 0
          poll: 10
      always:
        - name: Remove sysbench by undoing the transaction
          shell: "yum -y history undo $(yum history list sysbench | grep -m 1 Install | tr -d ' ' | cut -d '|' -f 1)"
          args:
            warn: no

        - name: Remove benchmark dirs
          file:
            name: '{{ item }}'
            state: absent
          with_items: '{{ dirs }}'

So what I expect from this playbook when press CTRL+C is that it executes the always tasks so my hosts are clean from the sysbench package and files create by it.
Solution proposal
Make ansible-playbook treat SIGHUP/SIGTERM signals special and when cancelling a task with one of those signals execute the always/rescue sections, then stop the execution, so that possible clean up tasks can execute regularly.
One other important reason why always/rescue should execute is because if I want them to execute when the tasks fail, why I wouldn't want to execute them in case I cancelled the task? Also if for some reason we want to cancel tasks in those sections, you can always press CTRL+C again.

They are supposed to handle task 'failed' state, in an interruption, the task won't get a state assigned. That said, I would not be against this feature as long as it had a toggle for it.

I support this. One Ctrl+C to start a clean cancel (which runs always/rescue), and if they run Ctrl+C again during the clean cancel, it forcefully exits. A PLAY RECAP at the end showing all the hosts (that have not finished yet) "failed" would be nice to complement this.


Logon failed for login 'username' due to trigger execution.

Problem occurs when using tedious. I'm unsure of what causes this issue though. The account I have (on the db server that this err) happened has very limited permission.
I can connect to this server just fine using other mssql client (dbeaver, mssql server..).
I have no problem on a dev server of mine though.

Duplicate of https://github.com/pekim/tedious/issues/221.


Optimize the E-Graph Pattern Matcher

The current pattern matcher is an unefficient version of the pattern matcher in
https://www.hpl.hp.com/techreports/2003/HPL-2003-148.pdf
Adapted from https://github.com/philzook58/EGraphs.jl/
By now, the pattern matcher uses channels as generators.
This architecture should be reconsidered for efficient parallelization.
Another pattern matcher architecture, based on a small virtual machine is
http://leodemoura.github.io/files/ematching.pdf
If this solution is considered, the abstract virtual machine could be implemented as low level as possible.

The pattern matcher now uses shared buffers between recursive calls.

An update on the issue. The pattern matcher works fairly well, but still has some pitfalls that cause bottlenecks and need to be solved. E-matching is still the big bottleneck in the equality saturation process.
The main bottleneck in the pattern matcher is the ematchlist function. Profiling allocations shows that the code location where most bytes are allocated, is inside this function, when creating a fresh buffer of substitutions for each time the system is trying to match against a composite pattern of the form f(subpat_a, subpat_b, ...).
One can look at this flamegraph to confirm this.

This flamegraph was obtained by this line using the propositional logic system of rewrite rules (here).
There is a bad performance loss as the size of patterns grows. Let's consider this example
using Metatheory
@metatheory_init ()
using Metatheory.EGraphs
using Metatheory.Library
using Metatheory.Util
using Metatheory.EGraphs.Schedulers

Metatheory.options.printiter = true
Metatheory.options.verbose = true

function rep(x, op, n::Int)
    foldl((x, y) -> :(($op)($x, $y)), repeat([x], n))
end

rep(:a, :*, 3)

Mid = @theory begin
    a * :ε => :ε
    :ε * a => :ε
end

Massoc = @theory begin
    a * (b * c) => (a * b) * c
    (a * b) * c => a * (b * c)
end

T = [
    @rule :b*:B => :ε
    RewriteRule(Pattern(rep(:(:a), :*, 2)), Pattern(:(:ε)))
    RewriteRule(Pattern(rep(:(:b), :*, 3)), Pattern(:(:ε)))
    RewriteRule(Pattern(rep(:(:a*:b), :*, 7)), Pattern(:(:ε)))
    RewriteRule(Pattern(rep(:(:a*:b*:a*:B), :*, 5)), Pattern(:(:ε)))
]

G = Mid∪Massoc∪T
expr = :(a*b*a*a*a*b*b*b*a*B*B*B*B*a)

g = EGraph(expr)
params = SaturationParams(timeout=5)
saturate!(g, G, params)
ex = extract!(g, astsize)
rewrite(ex, Mid)

Even though the egraph grows to only 37 eclasses, 202 nodes, it takes in total 125 seconds to match against the egraph!
This is because we have some quite big patterns:
Pattern(rep(:(:a*:b*:a*:B), :*, 5)) is the pattern :a * :b * :a * :B multiplied by itself 5 times.
See the equality saturation report from this test run
┌ Info: Equality Saturation Report
│ =================
│       Stop Reason: Iteration Timeout
│       Iterations: 5
│       EGraph Size: 37 eclasses, 202 nodes
│       Total Time: (time =<PHONE_NUMBER>6500001, bytes =<PHONE_NUMBER>6, gctime = 11.394093429)
│       Search Time: (time =<PHONE_NUMBER>3800001, bytes =<PHONE_NUMBER>4, gctime = 11.394093429)
│       Apply Time: (time = 0.18337512299999997, bytes = 3743452, gctime = 0.0)
└       Rebuild Time: (time = 0.001482004, bytes = 346240, gctime = 0.0)

How to attack this problem?
I've tried attacking this problem in many ways.
Implementing a virtual machine based ematcher like leo de moura's is harder than predicted: since MT supports additional features such as type assertions and custom term types, MT's substitutions are much more complicated than simple pattern_var -> eclass_id maps.
Some ideas:

It is very important to not stupidly match again against some sub-patterns that have already been matched, if not necessary.
One could apply some dynamic programming technique to memoize substitutions from subpatterns
We could borrow a concept of an explicit backtracking stack when doing ematchlist
Sub(stitutions) are mutable structures! But they get copy-ed every time a substitution is yielded to an substitution buffer. Couldn't we avoid some copies?

New pattern matcher architecture started in branch newematch2.
Thanks @philzook58 for https://www.philipzucker.com/staging-patterns/

Merged into master


C#: upgrade protobuf nugets to v3.6.1

Upgrade the nugets (followup for https://github.com/grpc/grpc/pull/15597).

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,950,932      Total (=)      1,950,932

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,662,143      Total (>)     10,662,138

 No significant differences in binary sizes


Create .idea

Thanks for the contribution @phuchau1989! Would you mind sharing the motivation behind this .idea file?


[dropout] Added extractor

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
Adds extractor for Dropout. Requires a valid & active user login. Mostly a simple _url_transparent wrapper for VHXEmbedIE, which extracts the VHX url and adds metadata such as title, description, etc.

Oh lordy that's a lot of failed checks. I'm hoping that it's because it requires a valid login? I'm happy to provide login detailers to a reviewer to verify it.

Things left unchanged (commenting here since I can't reply to reviews):

payload was not moved to within the urlencode_postdata call because I couldn't find a way to format it that both looked good and satisfied flake8.
_login() was not moved to _real_initialize() because it requires an id, which requires knowing url, which is not passed to _real_initialize().
remove_end() was not used for title - instead, only the last two elements of the --delimited list are discarded
utils.get_element_by_attribute and utils.unified_strdate were not used because parsing the text inside the element is much more difficult than just looking at the data-meta-field-value of the attribute

Logging in and out for each video can be problematic for batch downloads. I'll have to think of how to implement this

The user doesn’t necessarily need to be logged in to download the video, only to retrieve the video URL. However, the token in that URL expires after a certain amount of time.
Why would logging in/out be problematic for batch? I understand that it’s kind of dirty, but would it impair functionality?

Having self._login() in _real_initialize did present a problem for batch downloads (like when testing DropoutSeasonIE), but moving it back to _real_download fixed that issue.

Yes, at the time, I was thinking logout isn't needed. If we are logging in and out for each video, it has to be in _real_extract. Another problem is, logout should happen even when extraction fails. It could be done with a try...finally block, but that is ugly.
I am thinking of implementing a _real_exit similar to _real_initialize that runs only when yt-dlp exits. This way, the process will be login > download 1 > download 2 > ... > logout. Errors can also be properly handled with a context manager

Added the try...finally block. tbh it's not that ugly, since we log out after only downloading the video webpage.

@pukkandan Looking at common.py, implementing _real_exit() seems like it wouldn't be that difficult. It could be as simple as adding a function like
def exit(self):
    if self._ready:
        self._real_exit()
        self._ready = False

and then adding a finally: self.exit() at the end of initialize(). Should that be handled in a separate PR?

?
When using fatal=False instead of default=None, the tester fails when ERROR: [Dropout] episode-1: [Dropout] unable to extract release_date, even when the error is in expected_warnings.

try to fix this if possible, though not necessarily in scope of this PR
I believe this happens because the tester doesn't --write-subtitles, so vhx:embed ignores the subs. This expected_warnings is also found in /extractor/vimeo.py, line 443.

Please confirm everything is still working

@pukkandan A few very minor fixes, everything works now


Table alias missing for columns specified under src_nk in Hub code

Describe the bug
If there are mutiple natural keys to be specified in hub under src_nk, the hub code only adds the table alias for first column specified in the list. Example : src_nk = "nk1,nk2". After the code is compiled, the code looks something like below  :
WITH row_rank_1 AS (
SELECT ........ rr.nk1,nk2,......
ROW_NUMBER() OVER(
PARTITION BY .....
) AS row_number
from table_test.....
As seen nk2 is not qualified with table alias (rr) causing issue when the model is rerun. For the fisrt time, model runs fine but after rerun we get error as ambiguous column as the code tries to implement the incremental logic to push only unique records
Environment
dbt version: 1.3
automate_dv version: 1.1.4
Database/Platform:  Snowflake
To Reproduce
Steps to reproduce the behavior:

Create a hub with incremental config
Give multiple natural keys against src_nk separated by comma
Run the hub model, works ok
Rerun the model, gets error ambiguous column

Expected behavior
all columns specified in the src_nk should get qualified by table alias

Hi! Thanks for your report.
I'm surprised, as we have tests around this.
Can you confirm the AutomateDV package version please? 1.1.4 isn't an available version.

yes that versio was incorrect, here is the correct version :
version: 0.10.1

Thanks! I've looked at the code and our tests and there's nothing which indicates a problem. Have you modified/created your own version of the hub macro which introduces this bug? If not, please provide your model file which is currently presenting the issues (with redactions/sample values if necessary)

Thanks for your input. I have not made any changes to macro. I only installed the package as mentioned in the documentation a
sample_hub_automatedv.txt
sample_hub_automatedv.txt
nd started developing. I have attached the hub model as well as the dbt error logs for your reference. please note columns and table names are sample names. Please let me know if any other information is needed. thanks for the help

Ah I see your problem :) You've provided the src_nk as CSV string, so it is trying to find a column named "NK1, NK2", you need to provide them as a list:
{{ config(materialized='incremental') }}

{%- set source_model = "hash_stg_sample"   -%}
{%- set src_pk = "HK_COL1"          -%}
{%- set src_nk = ["NK1", "NK2"]         -%}
{%- set src_ldts = "COL4"      -%}
{%- set src_source = "COL5"    -%}

{{ automate_dv.hub(src_pk=src_pk, src_nk=src_nk, src_ldts=src_ldts,
                   src_source=src_source, source_model=source_model) }}

yes it worked :) Thank you for detailed information and all the help !!

No worries, happy to help! Welcome to the community 😄


⚠ ClamAV has degraded performance

In a8451b0, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 232 ms

Resolved: ClamAV performance has improved in a082830.


Model Merging

Hello Eric,
This issue may not be relevant to this repo, but it seems like model merging is gathering some speed. Have you seen any examples ? Any tips on how to implement this in candle ?
Thanks !

@okpatil4u, thanks for your interest! If you mean LoRA model weight merging, candle-lora has already implemented it. Otherwise, could you please let me know what you meant by model merging?

Closing so that it does not become stale, please feel free to reopen!

Apologies Eric. I was thinking about the following repos.
https://github.com/yule-BUAA/MergeLM
https://github.com/cg123/mergekit
The idea behind is taking two different finetuned models with the same origin and merge them so their expertise could be compounded. This could be pretty useful tool if its theoretical efficiency is proven.
Just giving you a heads up.

Do you mean something like Mixtral?

@okpatil4u, I just took a look at the following link: https://github.com/cg123/mergekit. I think it would definitely be possible to implement using candle-lora's trait-based swapping mechanism!

Closed so it doesn't become stale. Please feel free to reopen if you have any ideas!


how to convert PowerButtonTimestamp to a datetime object

Any tips on how to convert PowerButtonTimestamp to a DateTime object?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4da13b68-67f7-a360-4e63-078dc0d275d5
Version Independent ID: 55998351-042c-ce92-841f-5023e3cff5af
Content: Advanced troubleshooting for Event ID 41 -
Content Source: windows/client-management/troubleshoot-event-id-41-restart.md
Product: w10
Technology: windows
GitHub Login: @Teresa-Motiv
Microsoft Alias: v-tea

Hello, @ricofox959  thank you for providing feedback.
Note that the feedback section you have submitted this feedback from is intended for product documentation issues only.
Please consider checking with PowerShell community for your problem so that it gets resolved quickly.
PowerShell Community Links
For bug reports specific to PowerShell, please visit, PowerShell at GitHub.
Thanks again.