Request textDocument/codeAction failed with message: Cannot find module '../encodings'

It shows errors when I open any file:
[Error - 21:57:28] Request textDocument/codeAction failed.
  Message: Request textDocument/codeAction failed with message: Cannot find module '../encodings'
  Code: -32603
{ Error: Cannot find module '../encodings'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.getCodec (/Users/xxx/.vscode/extensions/streetsidesoftware.code-spell-checker-1.5.1/server/node_modules/iconv-lite/lib/index.js:65:27)
    at Object.getDecoder (/Users/xxx/.vscode/extensions/streetsidesoftware.code-spell-checker-1.5.1/server/node_modules/iconv-lite/lib/index.js:122:23)
    at Object.decodeStream (/Users/xxx/.vscode/extensions/streetsidesoftware.code-spell-checker-1.5.1/server/node_modules/iconv-lite/lib/streams.js:16:49)
    at textFileStreamRx (/Users/xxx/.vscode/extensions/streetsidesoftware.code-spell-checker-1.5.1/server/node_modules/cspell-lib/dist/file/fileReader.js:21:22)
    at Object.lineReaderRx [as lineReader] (/Users/xxx/.vscode/extensions/streetsidesoftware.code-spell-checker-1.5.1/server/node_modules/cspell-lib/dist/file/fileReader.js:11:29)
    at Object.loadWordsRx (/Users/xxx/.vscode/extensions/streetsidesoftware.code-spell-checker-1.5.1/server/node_modules/cspell/dist/wordListHelper.js:10:25) code: 'MODULE_NOT_FOUND' }

Other infos maybe help:
macOS: 10.13.1
VS Code version: 1.18.1
Is this relate to https://github.com/ashtuchkin/iconv-lite/issues/118?

Wow, thank you. Yes, they seem to be related. Does restarting vscode work? It might be necessary to kill any Code Helpers that might still be open.
I use iconv, so it is very likely related.

Strange... I reinstall code-spell-checker and restart VS Code, now it works properly.

That is basically what the other issue said.
Glad it is working for you.
On Sat, 2 Dec 2017 at 17:27, mingkaili<EMAIL_ADDRESS>wrote:

Strange... I reinstall code-spell-checker and restart VS Code, now it
works properly.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Jason-Rev/vscode-spell-checker/issues/159#issuecomment-348702851,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADkR6es2S_eDFpwZVub2iYIRgaYgqsuqks5s8XpdgaJpZM4QzUSa
.


Opacity issue with Table stickyHeader when using checkboxes

Used stickyHeader prop on my Table to make a Fixed Header table.
There's a weird opacity issue when my table data contains checkboxes.
Someone on StackOverflow suggested moving the table head below the table body and it works for now.
Ref

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Steps to Reproduce 🕹
Test Sandbox
Steps:

Add checkboxes in table data
Make Table a stickyHeader

Your Environment 🌎

Tech
Version

Material-UI
v4.4.0

Thanks for the report, see #17276


Update eslint action dependency

What it solves
Resolves https://github.com/gnosis/safe-apps-sdk/issues/276
How this PR fixes it
As part of the this ticket we are updating the safe-apps-sdk dependencies including the gnosis/safe-react-eslint-plus-action. These changes include a major eslint version bump from 7.x.x to 8.x.x.
The list of affected Gnosis repos will be:
- https://github.com/gnosis/safe-react
- https://github.com/gnosis/safe-react-apps
- https://github.com/gnosis/safe-apps-sdk
- https://github.com/gnosis/safe-react-e2e-tests
- https://github.com/gnosis/safe-react-components
- https://github.com/gnosis/safe-react-gateway-sdk
- https://github.com/gnosis/safe-apps-dev-ui

ESLint 8 bring a lot of changes to the table that can cause issues so as we have several projects using this action we are making PR’s using a concrete tag v3.5.0 for ensuring nothing is affected in the corresponding pipelines.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 33.629%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3187

Relevant Lines:
8485

💛  - Coveralls


[SPARK-37506][CORE][SQL][DSTREAM][GRAPHX][ML][MLLIB][SS][EXAMPLES] Change the never changed 'var' to 'val'

What changes were proposed in this pull request?
Similar to SPARK-33346, there are still some var that can be replaced by val in the current code base, so this pr turn these  from var to  val.
Why are the changes needed?
Use val instead of var when possible.
Does this PR introduce any user-facing change?
No
How was this patch tested?

Pass the Jenkins or GitHub Action

Manual test: compile a client and manually execute bin/run-example MiniReadWriteTest README.md,  the behavior is consistent before and after this PR

Test build #145768 has started for PR 34760 at commit ecf91a8.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50240/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50240/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50240/

Test build #145768 has finished for PR 34760 at commit ecf91a8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145768/

Is this a result of automated analysis ?

Yes, tools can assist analysis, but the analysis results are not always right.

Test build #145835 has started for PR 34760 at commit 7f57e4a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50310/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50310/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50310/

Test build #145835 has finished for PR 34760 at commit 7f57e4a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145835/

does it actually impact the performance BTW? I wonder if it's really worthwhile to sweeping all these that would cause conflicts when backporting stuff.

does it actually affect the performance BTW? I wonder if it's really worthwhile to sweep all these that would cause conflicts when backporting stuff.

The Scala language recommends that we use val, right? If we are worried about conflicts, I can give the corresponding PR to the required branch, do you think this is acceptable? @HyukjinKwon

Test build #145928 has started for PR 34760 at commit 05942f4.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50404/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50404/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50404/

Test build #145928 has finished for PR 34760 at commit 05942f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TryElementAt(left: Expression, right: Expression, child: Expression)

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145928/

Okie, I am fine with this too.

Test build #145935 has started for PR 34760 at commit 7f60b2e.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50411/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50411/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50411/

Test build #145935 has finished for PR 34760 at commit 7f60b2e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145935/

This seems OK; are there more instances?

@srowen Yes, that's all.
And we have confirmed in SPARK-33346 that the cases related to mockito do not need to be modified.

Merged to master

thanks all


[Missing SNMP Polling Profile] cisco ciscoFpr4150K9

Device Vendor: Cisco
Device Model: ciscoFpr4150K9
System Object Identifier (SysOID): .<IP_ADDRESS>.<IP_ADDRESS>.2292

CPU
Memory
Interfaces
Modules

Gist Link: https://gist.github.com/travisroberts-sf/100908a1d3ee2d22323803cc1876acb1

resolved in https://github.com/kentik/snmp-profiles/pull/634


Need some help

When I try to use the script, I spite of the fact that I have the accounts to file in the same directory as the script, it still says the accounts txt file isn't found. Could someone please tell me what I'm doing wrong?

Hey, that feature isn't supported by the original script but there is a
fork that you might be referring to.
Feel free to submit an issue over there. (assuming @saatanaperkele has it
turned on)
https://github.com/saatanaperkele/pybomber
On Fri, May 6, 2016 at 12:21 AM NineFingersj<EMAIL_ADDRESS>wrote:

When I try to use the script, I spite of the fact that I have the accounts
to file in the same directory as the script, it still says the accounts txt
file isn't found. Could someone please tell me what I'm doing wrong?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/cxdy/pybomber/issues/2

Hey @NineFingersj, what arguments are you using with the script? Can I also get a copy of the format of accounts.txt? (you may censor as needed).

And also, to keep from blowing up @cxdy's notifs, please make an issue on my fork.
Thanks,
jukka


Enhancement: Calc within brackets

I just thought of a use case for something like this: md:h-[calc(100vh - 4rem].
Possible?

Hey! This should work already if you remove the spaces (classes can't have spaces unfortunately).
md:h-[calc(100vh-4rem)]

Oh man... this is the greatest thing ever! 🕺


PSD matrices rejected by the value check in expressions/leaf.py

(This problem is closely related to https://github.com/cvxgrp/cvxpy/issues/415)
An attempt to store a positive semi-definite (PSD) matrix into cvxpy.Parameter((n,m), PSD=True) can be rejected, due to the value check in expressions/leaf.py:344.
344:            elif np.sum(self.project(val) != val):

Since self.project contains eigenvalue decomposition (see expressions/leaf.py:290), the result might include small computation errors.
290:       elif any([self.attributes[key] for
291:                  key in ['symmetric', 'PSD', 'NSD']]):
292:            val = (val + val.T)/2
293:            if self.attributes['symmetric']:
294:                return val
295:            w, V = LA.eig(val)
296:            if self.attributes['PSD']:
297:                w = np.maximum(w, 0)
298:            else:  # NSD
299:                w = np.minimum(w, 0)
300:            return V.dot(np.diag(w)).dot(V.T)

I think that expressions/leaf.py:344 should be
elif np.sum(not np.allclose(self.project(val), val, rtol=rtol)):

after defining an appropriate rtol value.
You can reproduce this problem by the following test code.
import cvxpy as cvx
import numpy as np
np.random.seed(2)

a = np.random.normal(size=(100,100))
a2 = a.dot(a.T)    # This must be a PSD matrix.

b = (a2 + a2.T) / 2    # fixed
w, V = np.linalg.eig(b)
c = V.dot(np.diag(w)).dot(V.T)    # simulating self.project function
# You will see that np.max(c-a2) != 0 (1.22e-12 in this case)

d = cvx.Parameter((100,100), PSD=True)
d.value = a2

--> ValueError: Parameter value must be positive semidefinite.

For the test code you provided, I think "b" should be "b = (a2 + a2.T) / 2". Perhaps I'm misunderstanding?
Also (although not terribly important), the "np.max(c-a2)" calculation should probably be replaced by "np.max(np.abs(c-a2))".

@rileyjmurray Thanks for the comments. 2. is what I meant exactly.

I've made the changes necessary to resolve this issue. It will be included in my next pull request.

This can be marked as resolved.


Expand TypeScript Interface in IntelliSense

VSCode Version: 1.1.1
OS Version: OSX 10.10.5

When using the typescript definitions installed from definitely typed, the IntelliSense doesn't seem to want to expand things that are declared as "interfaces". I've attached a snippet below as an example.

From this screen shot, I have no way of knowing what is expected from the IRouteConfiguration interface.
Am I missing a setting somewhere or is this working as intended and I have to click around before being able to learn what the shape of that interface is?
Update
It appears that once you start filling out the object, it does give you hints about the value you are using, but it seems like you already need to have an idea of the shape of the object before you start typing.

@arb this is actually as designed. You can start with and empty literal and then fill it out using IntelliSense. IMO showing more information in the signature hover would only makes things more complicated. Think about a literal with many properties.
I will close this since showing a literal type here will not improve things.

I see this issue has been closed... is there going to be any follow-up or explanation? Is this just how it works or am I doing something wrong?

@dbaeumer: Is there a way to enable this behavior (either VS Code options or through language services or some low level API)? It would be very useful to see the interface definition in quick info, otherwise I can't determine which properties are required without navigating to the definition. Code complete is nice, but if it's an unfamiliar interface (i.e. a library), the user has no idea which letters to type to start the discovery.
Specifically in my case I'm testing Monaco with external type declaration files, so peek/go to definition won't actually allow them to view the interface.
I would prefer to see expanded definition like you displayed above, which is what type aliases do by default. If classes could implement type aliases I would use them instead of interfaces in most cases, solely for this reason.

@grovesNL  No there is currently no option to control this.

I understand that in some cases it can be unhelpful to be shown a fully expanded typescript interface. However, if you are doing some type level trickery with Omit, Pick, extending, intersecting. It would actually be quite great to be able to see that your combined interface type actually has the expected shape.


boot_device sugar is not supported on s390x

If boot_device.mirror is specified, Butane emits Ignition directives to repartition the entire boot disk(s), create RAID volumes, and create filesystems inside them.  During first boot, the OS copies the entire OS contents into memory, does the repartitioning, and copies the contents back to disk.  The partition tables created by Butane are hardcoded to match what the OS expects, which is slightly different for each architecture, and so Butane needs to know the CPU architecture via the boot_device.layout field (which defaults to x86_64).
If boot_device.luks is specified, Butane doesn't need to emit directives for repartitioning the entire disk, but it does need to locate the existing root partition so it can create a LUKS volume in it and a new filesystem inside that.  (At runtime, the OS still does the copy to RAM and copy back to disk.)  To do this, it references the partition by partition label (/dev/disk/by-partlabel/root) so that it doesn't need to know the number of the root partition.  Since we're not repartitioning the disk, the layout directive is technically not required when only using boot_device.luks.
If both mirror and luks are specified, Butane does a combination of both.
That all works fine for x86_64, aarch64, and ppc64le, since they all use GPT partition tables.  But s390x uses different partition table formats depending on the type of disk.  On FBA DASD disks, it uses MBR partition tables, which Ignition doesn't know how to create, and which don't have partition labels.  On ECKD DASD disks, it uses the DASD native partitioning format, which Ignition doesn't know how to create and which don't have partition labels (and which only support 3 partitions per disk).
So we could technically have three different layout values, e.g.:

s390x-virt - works like the other arches
s390x-fba - doesn't support mirror, supports luks by hardcoding a partition number (which requires a field for specifying the boot disk, e.g. /dev/sda)
s390x-eckd - same constraints as fba but with different hardcoded constants

but that would be confusing.
Ignition and the OS copy-to-RAM/copy-to-disk code should work fine on s390x, it's just that the Butane sugar doesn't know how to configure them.  For now, all users on s390x should bypass the boot_device sugar and manually configure LUKS and/or mirroring using the low-level directives, similar to how an encrypted/mirrored data volume would be configured.  Do not use boot_device with the default x86_64 layout on s390x, even in VMs where it appears to work, since the x86_64 layout is not guaranteed to remain compatible with the needs of s390x.
On VMs using GPT partition tables this might look like:
variant: fcos
version: 1.5.0
storage:
  luks:
    - name: root
      label: luks-root
      device: /dev/disk/by-partlabel/root
      wipe_volume: true
      clevis:
        tang:
          - url: http://example.com/
            thumbprint: ...
  filesystems:
    - device: /dev/mapper/root
      format: xfs
      label: root
      wipe_filesystem: true

/dev/disk/by-partlabel/root will only work in VMs using GPT partition tables.  Other values will need to be used on DASD disks.

Hi @bgilbert
here is the proposal to add boot_device sugar for s390x.
Presently the testing has been done vda/zfcp/eckd-dasd. We have not done any luks  disk encryption testing on zfba-dasd.
So for  the device like vda/zfcp/eckd-dasd can be configured with partition number.
Like if we use "layout: s390x-zfcp" then it generates the config as below, or if we use "layout:  s390x-eckd" or "layout: s390x-virt".
Layout S390x-zfcp
# butane worker-storage.bu -o worker-storage.yaml
Content of worker-storage.bu

variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-zfcp
  luks:
    tang:
      - url: http://tang1.example.com:7500
        thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX
    threshold: 1

# butane worker-storage.bu -o test-worker-storage.yaml

# Generated by Butane; do not edit
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: worker-storage
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      filesystems:
        - device: /dev/mapper/root
          format: xfs
          label: root
          wipeFilesystem: true
      luks:
        - clevis:
            tang:
              - thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX
                url: http://tang1.example.com:7500
            threshold: 1
          device: /dev/sda4
          label: luks-root
          name: root
          wipeVolume: true

For eckd-dasd disk
Layout S390x-eckd
# butane worker-storage.bu -o worker-storage.yaml
Content of worker-storage.bu

variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-eckd
  luks:
    tang:
      - url: http://tang1.example.com:7500
        thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX
    threshold: 1

# butane worker-storage.bu -o test-worker-storage.yaml

# Generated by Butane; do not edit
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: worker-storage
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      filesystems:
        - device: /dev/mapper/root
          format: xfs
          label: root
          wipeFilesystem: true
      luks:
        - clevis:
            tang:
              - thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX
                url: http://tang1.example.com:7500
            threshold: 1
          device: /dev/dasda4
          label: luks-root
          name: root
          wipeVolume: true

For virtual disk S390x-virt
Layout S390x-virt
# butane worker-storage.bu -o worker-storage.yaml
Content of worker-storage.bu

variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-virt
  luks:
    tang:
      - url: http://tang1.example.com:7500
        thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX
    threshold: 1

# butane worker-storage.bu -o test-worker-storage.yaml

# Generated by Butane; do not edit
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: worker-storage
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      filesystems:
        - device: /dev/mapper/root
          format: xfs
          label: root
          wipeFilesystem: true
      luks:
        - clevis:
            tang:
              - thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX
                url: http://tang1.example.com:7500
            threshold: 1
          device: /dev/vda4
          label: luks-root
          name: root
          wipeVolume: true

In the zfcp layout, it looks like you're hardcoding /dev/sda.  Is that a safe assumption to make, or should we add a Butane field for specifying the /dev/sda part?
boot_device:
  layout: s390x-zfcp
  luks:
    # only permitted for layouts that use it.  should probably be here and not directly
    # under boot_device, to avoid a semantic conflict with the device list in the mirror
    # section.
    device: /dev/sda
    tang:
      - url: http://tang1.example.com:7500
        thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX

Similarly for DASD and /dev/dasda.  And also, shouldn't we be using partition 2?
For virt setups, we can continue to use /dev/disk/by-partlabel, right?  If so, we probably should, to avoid unnecessary hardcoding of partition details.
In the DASD and zfcp cases, we should make sure to fail if a mirror configuration is specified.

I was trying to depict that the butane generates the device as /dev/sda.
This is right ,  /dev/sda for zfcp and /dev/dasda for eckd in boot_device.luks.device as below. For virtual device default  boot_device sugar works.
And will make a conditional check that the configuration will generate only with  boot_device.luks and it fails if  mirror  boot_device.mirror configuration is specified for s390x-eckd and s390x-zfcp
zfcp
butane worker-storage.bu -o worker-storage.yaml
Content of worker-storage.bu
variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-zfcp
  luks:
    device: /dev/sda
    tang:
        - url: http://tang1.example.com:7500
          thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX

eckd-dasd
variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-eckd
  luks:
    device: /dev/sda
    tang:
        - url: http://tang1.example.com:7500
          thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX

So, to be explicit: is it 100% certain that the user will always want /dev/sda and /dev/dasda respectively?  Or is it possible that they'll want e.g. /dev/sdb or /dev/dasdb?  If it's 100% certain, then we don't need the new device field.  But if there's any chance that they'll want a different device, we should add the field.
And to be clear, we'll still need a separate s390x-virt layout even if we're using /dev/disk/by-partlabel.  It's not safe to have users default to the x86_64 layout, since there might be arch-specific differences in the future.

An example when user try to create boot_device sugar, so the butane template looks like this.
variant: openshift
version: x.xx.x
metadata:
  name: <name>
  labels:
    machineconfiguration.openshift.io/role: <node-name-string)  >
boot_device:
  layout: <arch (string)>
  luks:
    device: <string>    #/dev/sda || /dev/dasda Optional but default /dev/sda
    tang:
        - url: <string>
          thumbprint: <string>

/dev/sda is an example when user specifies for zfcp and /dev/dasda eckd. So user  must specify layout: s390x-zfcp and   device: <string>  /dev/sd[a-z] is optional  (thanks for the idea _/\_ ).   , otherwise it uses the default  /dev/sda ?.
Similarly for dasd.
And condition to ensure that s390x-zfcp  accept scsi naming convention like sd<a-z] and similarly for s390-eckd.
For zKVM  we can still provision layout: s390x-virt which use the same semantic explained for scsi and dasd and default device to /dev/vda unless specifically mention in device: <> ?.
If it is specific like layout: s390x-virt and reduces confusion.

Please directly answer the question I asked in https://github.com/coreos/butane/issues/453#issuecomment-1652349302: is it true or false that the user will sometimes want to install on a disk other than the first one?
If we add a device field, it should be forbidden for layouts that don't support it, and mandatory for layouts that do.  Otherwise the user will likely forget to set it.
I think you're right that we should require a /dev/sd prefix for zfcp and /dev/dasd for ECKD.  It'll prevent mistakes, and we can always relax that restriction later.
For the s390x-virt layout, as I've been saying, we shouldn't allow the device field and shouldn't hardcode a /dev/vd* device.  Instead, we should use /dev/disk/by-partlabel/root as the other arches do.  That approach avoids the need to specify any device at all, and in the KVM case there's no reason not to do that.

Is it 100% certain that the user will always want /dev/sda and /dev/dasda respectively? -> False
(I cannot  assert the statement True, because it depends on the user requirements ).
I've a question here  related to above question. if we use boot_device sugar, it generates ignition with valid device automatically lets say for x86 it is /dev/disk/part-label/root.
However for the s390x device /dev/sd[] needs to be provided manually in that case right? because butane does not know how many disk present in the vm node.
If we add a device field, it should be forbidden for layouts that don't support it, and mandatory for layouts that do. Otherwise the user will likely forget to set it. - Will do that.
Will add s390x-virt layout. something like below.
variant: OpenShift
......
......
boot_device:
   layout: s390x-virt
   luks:
     tang:
        url:

so the butane should generate the following output...
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: master
  name: master
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      filesystems:
        - device: /dev/mapper/root
          format: xfs
          label: root
          wipeFilesystem: true
      luks:
        - clevis:
            tang:
              - thumbprint: QcPr_NHFJammnRCA3fFMVdNBwjs
                url: http://<IP_ADDRESS>:7500
          device: /dev/disk/by-partlabel/root
          label: luks-root
          name: root
          options:
            - --cipher
            - aes-cbc-essiv:sha256
          wipeVolume: true

if we use boot_device sugar, it generates ignition with valid device automatically lets say for x86 it is /dev/disk/part-label/root.
However for the s390x device /dev/sd[] needs to be provided manually in that case right? because butane does not know how many disk present in the vm node.

It doesn't have anything to do with the number of disks.  On other arches, we can find the existing partition with the label root and reformat it, since CoreOS reserves that label for the root partition.  But MBR and DASD partition tables don't support partition labels, or any equivalent functionality, so that trick doesn't work.

Hi @bgilbert
From the above discussion, here are the major rules  I captured for s390x.   Please let me know if any errors  or additional requirements.

Add  layout specific to s390x .
- > s390x-zfcp  s390x-eckd  and s390x-virt .

Add boot_device.luks.device specifically for s390x-zfcp s390x-eckd and forbidden for other arch including s390x-virt.

The configuration will generate only with  boot_device.luks and it fails if mirror boot_device.mirror  configuration is specified for s390x-eckd and  s390x-zfcp .

Expected  Butane sugar from user perspective below.

s390x-eckd
variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-eckd
  luks:
    device: /dev/dasd[a-z]
    tang:
        - url: http://tang1.example.com:7500
          thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX

s390x-zfcp
variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-zfcp
  luks:
    device: /dev/sd[a-z]
    tang:
        - url: http://tang1.example.com:7500
          thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX

s390x-virt
variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-virt
  luks:
    tang:
        - url: http://tang1.example.com:7500
          thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX

Looks good!  Could you also post the expected output for each of those configs?
Note that FCOS should also support these layouts, so the implementation should happen in the fcos experimental spec.

Will implement on FCOS also , in the experimental spec.
Here is the expected output for each configs.
 s390x-eckd s390x-zfcp s390x-virt
s390x-eckd
variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-eckd
  luks:
    device: /dev/dasda   // given as an example, if we give /dev/dasdb it returns corresponding disk
    tang:
        - url: http://tang1.example.com:7500
          thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX

Converting to ignition
# butane s390x-eckd -o s390x-eckd_out.yaml
# Generated by Butane; do not edit
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: worker-storage
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      filesystems:
        - device: /dev/mapper/root
          format: xfs
          label: root
          wipeFilesystem: true
      luks:
        - clevis:
            tang:
              - thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX
                url: http://tang1.example.com:7500
          device: /dev/dasda2   // corresponding disk as per the example.  `/dev/dasdb2`, if user use `/dev/dasdb` in device .
          label: luks-root
          name: root
          wipeVolume: true

s390x-zfcp
variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-zfcp
  luks:
    device: /dev/sda // given as an example, if we give /dev/sdb it returns corresponding disk.
    tang:
        - url: http://tang1.example.com:7500
          thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX

Converting to ignition
 # butane s390x-zfcp.bu -o s390x_zfcp_out.yaml
# Generated by Butane; do not edit
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: worker-storage
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      filesystems:
        - device: /dev/mapper/root
          format: xfs
          label: root
          wipeFilesystem: true
      luks:
        - clevis:
            tang:
              - thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX
                url: http://tang1.example.com:7500
          device: /dev/sda2.  // corresponding disk as per the example.  `/dev/sdb2` , if user use `/dev/sdb` in device.
          label: luks-root
          name: root
          wipeVolume: true

s390x-virt
device section forbidden for s390x-virt, like other archs.
variant: openshift
version: 4.13.0
metadata:
  name: worker-storage
  labels:
    machineconfiguration.openshift.io/role: worker
boot_device:
  layout: s390x-virt
  luks:
    tang:
        - url: http://tang1.example.com:7500
          thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX

Converting to ignition
 # butane s390x-virt.bu -o s390x_virt_out.yaml
# Generated by Butane; do not edit
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: worker-storage
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      filesystems:
        - device: /dev/mapper/root
          format: xfs
          label: root
          wipeFilesystem: true
      luks:
        - clevis:
            tang:
              - thumbprint: jwGN5tRFK-kF6pIX89ssF3khxxX
                url: http://tang1.example.com:7500
          device: /dev/disk/by-partlabel/root
          label: luks-root
          name: root
          wipeVolume: true

Looks good.  Note that you don't need to implement on FCOS also.  If you implement it in the FCOS experimental spec, the OpenShift spec will automatically inherit.


ExtractVariantCandidate.py

Hi,
I am now trying to run the first script to extract variant candidates, but I cannot get what do you mean by the chromosome start and end. I am using fasta file for chromosome 22 as a ref and bam file for the same chr also but when I tried to write down the chr start as 1 and end as wc -c of the same ref file, it gave me an invalid region or unknown reference. So how should it go from there ?
that's the code that I ran:
pypy3 ExtractVariantCandidate.py --fin_bam /home/ionadmin/bassyouni/source_bam/NA12877_chr22.bam --fin_ref /home/ionadmin/bassyouni/chr22.fa --chrName 22 --chrStart 1 --chrEnd 50818468 --fout_can /home/ionadmin/bassyouni/analysis/Psi-Caller_workplace/var.can
that was the error:
[W::fai_get_val] Reference 22:1-50818468 not found in FASTA file, returning empty sequence [faidx] Failed to fetch sequence in 22:1-50818468 [main_samview] region "22:1-50818468" specifies an invalid region or unknown reference. Continue anyway.
this is the output of the fasta index file:
chr22	50818468	7	50	51

I found the problem here in this issue, it's all related to the --chrName  flag as for some files the name has to be written with the chr22 instead of the 22 only. it worked fine with that!


Review comments/questions on Smmtt v0.1

Why are two separate encodings used for 4M_PAGES and 2M_PAGES? These can never be used at the same time.
It's not possible to atomically update 32 consecutive MTTL2 entries representing a 1 GiB range. Given the possibility of speculative lookups or lookups from another hart or I/O MTT, the walk behavior and fence behavior should be well-defined even when the consecutive MTTL2 entries do not match.
The text claims that Figure 8 is applicable to Smmtt46, but this is false, due to pn[0] being 3 bits for Smmtt32, but 4 bits for Smmtt46.
The "ZERO" fields in the MTTL3 and MTTL2 entries should be renamed "Reserved", so they can be used for a future specification.
Why is a different encoding used for MTTL1 and 4M_PAGES/2M_PAGES? Why not use the low bits (without gaps) in both cases? Any future change that uses the other two bits in MTTL1 is likely to apply to MTTL2 as well.
In section 4.3, the exception "but excluding MTT structure accesses" should be clarified to only exclude implicit MTT structure accesses (i.e. MTT walks), not just any memory access to the MTT. (Granted, S-mode shouldn't be able to explicitly access the MTT, because the MTT should be protected by itself or PMP.)

I'd like to expand on the last bullet item - regarding section 4.3's MTT structure access. This section also includes this line:

MTT structure accesses are to be treated as implicit M-mode accesses and are subject to PMP/Smepmp and IOPMP checks.

Should the phrase "MTT structure accesses" say "implicit MTT structure accesses"? To be explicit that these accesses are part of a MTT walk?

Why are two separate encodings used for 4M_PAGES and 2M_PAGES? These can never be used at the same time.

yeah can use the same.

It's not possible to atomically update 32 consecutive MTTL2 entries representing a 1 GiB range. Given the possibility of speculative lookups or lookups from another hart or I/O MTT, the walk behavior and fence behavior should be well-defined even when the consecutive MTTL2 entries do not match.

With the recent updates to the MFENCE instructions and the walk behavior - is there any additional explanation needed?

The text claims that Figure 8 is applicable to Smmtt46, but this is false, due to pn[0] being 3 bits for Smmtt32, but 4 bits for Smmtt46.

yes will fix the reference.

The "ZERO" fields in the MTTL3 and MTTL2 entries should be renamed "Reserved", so they can be used for a future specification.

ack.

Why is a different encoding used for MTTL1 and 4M_PAGES/2M_PAGES? Why not use the low bits (without gaps) in both cases? Any future change that uses the other two bits in MTTL1 is likely to apply to MTTL2 as well.

wanted to keep current PERMS and future reserved bits corresponding to a PA together. can group the other bit field the same way too.

In section 4.3, the exception "but excluding MTT structure accesses" should be clarified to only exclude implicit MTT structure accesses (i.e. MTT walks), not just any memory access to the MTT. (Granted, S-mode shouldn't be able to explicitly access the MTT, because the MTT should be protected by itself or PMP.)

makes sense - will update.

It's not possible to atomically update 32 consecutive MTTL2 entries representing a 1 GiB range. Given the possibility of speculative lookups or lookups from another hart or I/O MTT, the walk behavior and fence behavior should be well-defined even when the consecutive MTTL2 entries do not match.

With the recent updates to the MFENCE instructions and the walk behavior - is there any additional explanation needed?

I think so. Currently Table 3 has the text:

When configuring 1 GiB ranges, RDSM must ensure that 32 MTTL2 entries, each corresponding to 32 MiB of address space, have identical TYPE field values.

This implies that the behavior is undefined if the TYPE values are not identical. But the TYPE values will necessarily be non-identical if the permissions for a 1 GiB region ever change. So I would recommend constraining the behavior to be predicable while allowing caching flexibility by replacing that sentence with something like the following:

If this entry type is used, and the 32 consecutive MTTL2 entries corresponding to this 1 GiB address range do not have identical TYPE field values, it is unspecified which of these entries is used to determine the permissions for this address range.

Or, we could remove that sentence from the table cells and add a separate paragraph outside the table:

If any MTTL2 entry corresponding to a portion of a naturally-aligned 1 GiB address range uses one of the 1G_* entry types, then it is unspecified which of the 32 consecutive MTTL2 entries corresponding to that address range determines the permissions for the entire range.

This is similar to the behavior for I/O MTT rules with mismatching IOSDIDs added in #82.

Why is a different encoding used for MTTL1 and 4M_PAGES/2M_PAGES? Why not use the low bits (without gaps) in both cases? Any future change that uses the other two bits in MTTL1 is likely to apply to MTTL2 as well.

wanted to keep current PERMS and future reserved bits corresponding to a PA together. can group the other bit field the same way too.

OK, but there aren't enough bits to rearrange the MTTL2 encoding that way without making the INFO field wider. It would need to be 24/48 bits wide to allow even one reserved bit for each 2M/4M page.

Adding this clarification in an incoming PR for the 1 GiB cases: "If this entry type is used, and the 32 consecutive MTTL2 entries corresponding to this 1 GiB address range do not have identical TYPE field values, it is unspecified which of these entries is used to determine the permissions for this address range."

Why is a different encoding used for MTTL1 and 4M_PAGES/2M_PAGES? Why not use the low bits (without gaps) in both cases? Any future change that uses the other two bits in MTTL1 is likely to apply to MTTL2 as well.

wanted to keep current PERMS and future reserved bits corresponding to a PA together. can group the other bit field the same way too.

OK, but there aren't enough bits to rearrange the MTTL2 encoding that way without making the INFO field wider. It would need to be 24/48 bits wide to allow even one reserved bit for each 2M/4M page.

right, there is no additional space in the INFO fields - I will modify per your original suggestion to use the low bits for MTTL1 as well.

merged PR #102


Connection health and autoreconnect

I don't see this as a core feature, but instead as a nice to have feature.
We should make an effort to detect when the websocket connection is dead and reconnect as soon as possible. The way glirc handles this is to use  a ping + timer. If there is no response from a ping after N seconds (by default N = 60) the client initiates a reconnect.
I  don't know if the websockets library exposes server pings or not. If it does not, then we could simulate it by periodically initiating benign requests such as mmGetMe that just test our ability to fetch data that should always be available to us.
It's also worth noting that this connection health could correspond to both the one shot HTTP requests and the websocket connection. It's likely worth monitoring both. If we only test HTTP request we could hit an edge case where the internet connection dropped for just long enough to disrupt the websocket but came back fast enough to not interrupt HTTP requests.

I see this as being more than a "nice to have". For example, if I'm running a client on my laptop and I shut the lid, then open later it appears that I'm still connected to Mattermost, but in fact the connection is broken.
I think at the very least the connection health component should be part of the minimum client.

Yeah, I agree. Tag removed.

This feature is halfway there:

We detect a ping timeout and visually indicate in the top-right corner that the connection is dead
We sporadically attempt to reconnect, and after reconnecting you'll see new messages as they come in.

Some features which are currently missing:

We try to reconnect every five seconds, and we probably should have some kind of backoff over time so that we're not perpetually trying to vainly reconnect when we're not connected to the network
We don't report the health beyond a binary of connected/not connected, and it would be nice to report a good/fair/poor connection quality based on the latency.
Most importantly, we don't fetch any history on reconnection: you'll see messages from before the drop, and from after, but not from the period you weren't connected.

Latest update: we now catch all exceptions in the ping management threads to avoid stderr poisoning when those threads crash.  Before, we only caught specific websocket timeout exceptions.

Any other thoughts on what we can do before calling this done?
The only thing I can think of is to make the client check for updates when the websocket comes back up (i.e. refresh all state).

Yeah, I think refreshing the state is the next obvious thing. After that I think it makes sense to close this issue.

As of ead74fb we now refresh messages, but no other state.

I'm going to close this one and open another issue for refreshing the rest of the state: "refresh user/channel metadata on reconnect" is significantly different enough from this issue's title of "connection health and autoreconnect" that I think it should be recorded elsewhere.


Addind Managed Identity Integration link

Adding Managed Identity Integration doc link in dynamic configuration page to align with other dynamic config docs template

@gandhirajan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


feat: optimze data model of event metadata

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary

New metadata ddb module, details @dengmingtong
Update metadata api for new ddb module, support different value type with same parameter name.
Add built-in list to save Preset event/parameter and Public parameter.
Refactor sp-scan-metadata.sql, group the data into each days and months.
Refactor store metadata lambda function, combine data and generate the metadata summary data.

closes #266
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist

[x] add new test cases
[ ] all code changes are covered by unit tests
[ ] end-to-end tests

[x] deploy web console with CloudFront + S3 + API gateway
[ ] deploy web console within VPC
[ ] deploy ingestion server

[ ] with MSK sink
[ ] with KDS sink
[ ] with S3 sink

[ ] deploy data processing
[x] deploy data modeling

[x] new Redshift Serverless
[ ] provisioned Redshift
[ ] Athena

[ ] deploy with reporting

Is it a breaking change

[ ] add parameters without default value in stack
[ ] introduce new service permission in stack
[ ] introduce new top level stack module

Miscellaneous

[ ] introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

@dengmingtong we already enable V2 transform to load 4 dimension tables to Redshift, let's scan the metadata based on latest dimension tables or views.


IndexOutOfBoundsException when using Google Indic Keyboard with RN 0.53.0

Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Environment:
OS: macOS High Sierra 10.13.2
Node: 8.4.0
Yarn: 0.27.5
npm: 5.3.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.0 => 0.53.0
Target Platform: Android (6.0.1)
Steps to Reproduce

Create and run a new project with RN 0.53.0, using react-native init. (Most likely exists for projects created using other methods as well, didn't check.)
Switch the keyboard to Google Indic Keyboard from phone's input settings
Steps for reproducing the crash with emojis:
a. Create a TextInput with no additional props (or switch to the master branch of the provided repo).
a. Type an emoji and press the backspace twice.
Steps for reproducing the crash with any character:
a. Create a TextInput with autoCorrect={false} (or switch to the auto-correct branch of the provided repo).
a. Type any character and press the backspace once.

Expected Behavior
The emojis and characters get cleared with no crashes
Actual Behavior

The app crashes on clearing the emojis, with no additional props set on the TextInput

The app crashes on clearing the last character in case autoCorrect={false} is set

Reproducible Demo
https://github.com/SuhairZain/react-native-gindic-keyboard-crash
The master branch crashes when deleting an emoji character
The auto-correct branch crashes when deleting the last character in the input
The reason that I've created this issue here rather than on the Google Indic keyboard repo is that I can confirm that this bug does not exist with 0.47.1, which is the version our app was on before we upgraded. This is a bug that was introduced in one of the versions from then to 0.53.0.

@SuhairZain can you post the stack trace?

@joshyhargreaves  Here's all the data that I have about the crash:
{
  "client": {
    "clientUrl": "https://github.com/MindscapeHQ/raygun4android",
    "name": "Raygun4Android",
    "version": "3.0.0"
  },
  "context": {
    "identifier": "xxxxxxxxxxxxxxxxx"
  },
  "environment": {
    "architecture": "armeabi-v7a",
    "availablePhysicalMemory": 620,
    "availableVirtualMemory": 0,
    "board": "msm8937",
    "brand": "Xiaomi",
    "currentOrientation": "Portrait",
    "deviceCode": "land",
    "deviceName": "Redmi 3S",
    "diskSpaceFree": 5861,
    "locale": "en_US",
    "oSVersion": "6.0.1",
    "osSDKVersion": "23",
    "processorCount": 8,
    "totalPhysicalMemory": 2843,
    "totalVirtualMemory": 0,
    "utcOffset": 5.0,
    "windowsBoundHeight": 1280,
    "windowsBoundWidth": 720
  },
  "error": {
    "className": "java.lang.IndexOutOfBoundsException",
    "message": "IndexOutOfBoundsException: charAt: -1 < 0",
    "stackTrace": [
      {
        "className": "android.text.SpannableStringBuilder",
        "fileName": "SpannableStringBuilder.java",
        "lineNumber": 117,
        "methodName": "charAt"
      },
      {
        "className": "com.facebook.react.views.textinput.ReactEditTextInputConnectionWrapper",
        "fileName": "ReactEditTextInputConnectionWrapper.java",
        "lineNumber": 104,
        "methodName": "setComposingText"
      },
      {
        "className": "com.android.internal.view.IInputConnectionWrapper",
        "fileName": "IInputConnectionWrapper.java",
        "lineNumber": 340,
        "methodName": "executeMessage"
      },
      {
        "className": "com.android.internal.view.IInputConnectionWrapper$MyHandler",
        "fileName": "IInputConnectionWrapper.java",
        "lineNumber": 78,
        "methodName": "handleMessage"
      },
      {
        "className": "android.os.Handler",
        "fileName": "Handler.java",
        "lineNumber": 102,
        "methodName": "dispatchMessage"
      },
      {
        "className": "android.os.Looper",
        "fileName": "Looper.java",
        "lineNumber": 157,
        "methodName": "loop"
      },
      {
        "className": "android.app.ActivityThread",
        "fileName": "ActivityThread.java",
        "lineNumber": 5555,
        "methodName": "main"
      },
      {
        "className": "java.lang.reflect.Method",
        "fileName": "Method.java",
        "lineNumber": -2,
        "methodName": "invoke"
      },
      {
        "className": "com.android.internal.os.ZygoteInit$MethodAndArgsCaller",
        "fileName": "ZygoteInit.java",
        "lineNumber": 745,
        "methodName": "run"
      },
      {
        "className": "com.android.internal.os.ZygoteInit",
        "fileName": "ZygoteInit.java",
        "lineNumber": 635,
        "methodName": "main"
      }
    ]
  },
  "machineName": "Redmi 3S",
  "request": {
    "iPAddress": [
      "xxxxxxxxxxxxx"
    ],
    "networkConnectivityState": "Connected - WiFi"
  },
  "tags": [
    "UnhandledException"
  ],
  "user": {
    "identifier": "xxxxxxxxxxx"
  },
  "version": "xxxxxxxxxxx",
  "OccurredOn": "2018-02-14T04:27:24Z"
}

@SuhairZain are you able to reproduce on a simulator? Or is this a device?

@joshyhargreaves This is a device. I tried to reproduce it on an emulator but it didn't have the Indic keyboard. If it'd help you, I'll try to install the keyboard on an emulator and see.

@SuhairZain I installed the Indic keyboard on an emulator by downloading the APK and installing with adb however no crash for me on the emulator itself; I will try on a device.
Could you try the fix that I just pushed to a branch, you can either update your react-native dependency in your package.json or initialise a new project with react-native init fixedOnKeyPress --version joshyhargreaves/react-native#89eaafe6aa9f98a32ae48a400ebfea8295918bb6

@joshyhargreaves I was unable to reproduce it on an emulator as well. I think you wouldn't be able to reproduce this on a device either. Seems like I'm running an old version of Google Indic keyboard on my device, even though I have auto-updates on. The version I have on the emulator is 3.2.5, whereas on my device it's 3.2.1.
I think it'd be wise for me to not upgrade to the latest version of the keyboard on the device since it may be difficult to revert to the old version. What do you suggest?

@SuhairZain could you build your repo-project for your device with the changes I just pushed and let me know if it still crashes on your device?

I greatly suspect it will have fixed the issue.

But this issue doesn't appear on the older version of RN, at least as far
as 0.47.1. It's very likely that some change since then had something to do
with this edge case. Is it worth looking at?
On Feb 15, 2018 10:20 PM, "Josh Hargreaves"<EMAIL_ADDRESS>wrote:

I greatly suspect it will have fixed the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/17974#issuecomment-365988758,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFAbArLzBnzTHHpP8uzxuQ0N752uS2NZks5tVGBAgaJpZM4SEzn2
.

@suhairZain, I know what the issue was as I it was me who introduced it while implenting onKeyPress for Android. If you look at my earlier comment you can pull the fix from my branch and test it.

@joshyhargreaves I'm sorry. I was replying via email and didn't see your 1st comment. I'll check right away.

@joshyhargreaves I'm unable to build the project. Getting the following error:
Scanning folders for symlinks in /Users/suhairzain/Documents/fixedOnKeyPress/node_modules (16ms)
JS server already running.
Building and installing the app on the device (cd android && ./gradlew installDebug)...
Incremental java compilation is an incubating feature.
:app:preBuild UP-TO-DATE
:app:preDebugBuild UP-TO-DATE
:app:checkDebugManifest
:app:preReleaseBuild UP-TO-DATE
:app:prepareComAndroidSupportAppcompatV72301Library
:app:prepareComAndroidSupportRecyclerviewV72301Library
:app:prepareComAndroidSupportSupportV42301Library
:app:prepareComFacebookFrescoDrawee081Library
:app:prepareComFacebookFrescoFbcore081Library
:app:prepareComFacebookFrescoFresco081Library
:app:prepareComFacebookFrescoImagepipeline081Library
:app:prepareComFacebookFrescoImagepipelineOkhttp081Library
:app:prepareComFacebookReactReactNative0201Library
:app:prepareOrgWebkitAndroidJscR174650Library
:app:prepareDebugDependencies
:app:compileDebugAidl
:app:compileDebugRenderscript
:app:generateDebugBuildConfig
:app:mergeDebugShaders
:app:compileDebugShaders
:app:generateDebugAssets
:app:mergeDebugAssets
:app:generateDebugResValues
:app:generateDebugResources
> Building 57% > :app:mergeDebugResources^C
➜  fixedOnKeyPress react-native run-android
Scanning folders for symlinks in /Users/suhairzain/Documents/fixedOnKeyPress/node_modules (12ms)
Starting JS server...
Building and installing the app on the device (cd android && ./gradlew installDebug)...
Incremental java compilation is an incubating feature.
:app:preBuild UP-TO-DATE
:app:preDebugBuild UP-TO-DATE
:app:checkDebugManifest
:app:preReleaseBuild UP-TO-DATE
:app:prepareComAndroidSupportAppcompatV72301Library UP-TO-DATE
:app:prepareComAndroidSupportRecyclerviewV72301Library UP-TO-DATE
:app:prepareComAndroidSupportSupportV42301Library UP-TO-DATE
:app:prepareComFacebookFrescoDrawee081Library UP-TO-DATE
:app:prepareComFacebookFrescoFbcore081Library UP-TO-DATE
:app:prepareComFacebookFrescoFresco081Library UP-TO-DATE
:app:prepareComFacebookFrescoImagepipeline081Library UP-TO-DATE
:app:prepareComFacebookFrescoImagepipelineOkhttp081Library UP-TO-DATE
:app:prepareComFacebookReactReactNative0201Library UP-TO-DATE
:app:prepareOrgWebkitAndroidJscR174650Library UP-TO-DATE
:app:prepareDebugDependencies
:app:compileDebugAidl UP-TO-DATE
:app:compileDebugRenderscript UP-TO-DATE
:app:generateDebugBuildConfig UP-TO-DATE
:app:mergeDebugShaders UP-TO-DATE
:app:compileDebugShaders UP-TO-DATE
:app:generateDebugAssets UP-TO-DATE
:app:mergeDebugAssets UP-TO-DATE
:app:generateDebugResValues UP-TO-DATE
:app:generateDebugResources UP-TO-DATE
:app:mergeDebugResources
:app:bundleDebugJsAndAssets SKIPPED
:app:processDebugManifest
:app:processDebugResources
warning: string 'catalyst_debugjs' has no default translation.
warning: string 'catalyst_element_inspector' has no default translation.
warning: string 'catalyst_jsload_error' has no default translation.
warning: string 'catalyst_jsload_message' has no default translation.
warning: string 'catalyst_jsload_title' has no default translation.
warning: string 'catalyst_reloadjs' has no default translation.
warning: string 'catalyst_settings' has no default translation.
warning: string 'catalyst_settings_title' has no default translation.

:app:generateDebugSources
:app:incrementalDebugJavaCompilationSafeguard
:app:compileDebugJavaWithJavac
:app:compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/Users/suhairzain/Documents/fixedOnKeyPress/android/app/src/main/java/com/fixedonkeypress/MainApplication.java:5: error: cannot find symbol
import com.facebook.react.ReactApplication;
                         ^
  symbol:   class ReactApplication
  location: package com.facebook.react
/Users/suhairzain/Documents/fixedOnKeyPress/android/app/src/main/java/com/fixedonkeypress/MainApplication.java:6: error: cannot find symbol
import com.facebook.react.ReactNativeHost;
                         ^
  symbol:   class ReactNativeHost
  location: package com.facebook.react
/Users/suhairzain/Documents/fixedOnKeyPress/android/app/src/main/java/com/fixedonkeypress/MainApplication.java:14: error: cannot find symbol
public class MainApplication extends Application implements ReactApplication {
                                                            ^
  symbol: class ReactApplication
/Users/suhairzain/Documents/fixedOnKeyPress/android/app/src/main/java/com/fixedonkeypress/MainApplication.java:16: error: cannot find symbol
  private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
                ^
  symbol:   class ReactNativeHost
  location: class MainApplication
/Users/suhairzain/Documents/fixedOnKeyPress/android/app/src/main/java/com/fixedonkeypress/MainApplication.java:36: error: cannot find symbol
  public ReactNativeHost getReactNativeHost() {
         ^
  symbol:   class ReactNativeHost
  location: class MainApplication
/Users/suhairzain/Documents/fixedOnKeyPress/android/app/src/main/java/com/fixedonkeypress/MainApplication.java:16: error: cannot find symbol
  private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
                                                       ^
  symbol:   class ReactNativeHost
  location: class MainApplication
/Users/suhairzain/Documents/fixedOnKeyPress/android/app/src/main/java/com/fixedonkeypress/MainApplication.java:35: error: method does not override or implement a method from a supertype
  @Override
  ^
/Users/suhairzain/Documents/fixedOnKeyPress/android/app/src/main/java/com/fixedonkeypress/MainActivity.java:5: error: MainActivity is not abstract and does not override abstract method getPackages() in ReactActivity
public class MainActivity extends ReactActivity {
       ^
8 errors
:app:compileDebugJavaWithJavac FAILED

@SuhairZain sorry, that's my bad, I forgot that android needs to be built from source.

@joshyhargreaves In that case, I'll build it from source and try tomorrow. I see that it'll take some time.

You can build react-native in-place in node_modules by running the command: ./gradlew :ReactAndroid:installArchives

I'll try building the APK this way and sending it over to my team that is onsite.  I won't hear back from them until tomorrow afternoon/Monday most likely, but I'll let you know.

@ccdwyer, sounds good, thank you, and we can go from there. Sorry about this crash, it was a definite oversight on my part.

@joshyhargreaves Pardon my ignorance, where am I supposed to run the ./gradlew :ReactAndroid:installArchives command?  I tried running that inside my android folder and got:

What went wrong:
Project 'ReactAndroid' not found in root project 'MyProjectName'.

@joshyhargreaves @ccdwyer I'm getting the following error when trying to build from source as described in Building React Native from source.
Scanning folders for symlinks in /Users/suhairzain/Documents/TextInputBug/node_modules (20ms)
Starting JS server...
Building and installing the app on the device (cd android && ./gradlew installDebug)...
Incremental java compilation is an incubating feature.

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> java.lang.NullPointerException (no error message)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 11.746 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/getting-started.html

If you're able to build from source, would it be possible for you to use your fork with the example repo I had provided and send me a universal APK?

@ccdwyer, you have to run this from within node_modules/React-Native.
When React Native is published to npm, it runs this command and pushes the built assets as part of the package. As I’ve just pushed this to a branch, and including this repository as a git dependency; this step hasn’t happened.

@joshyhargreaves I get it. However, it seems that Play Store finally decided to update Google Indic keyboard on my device yesterday. I'm no longer having crashes. Will have to find an older version and install it on an emulator using adb. Where did you download the latest APK from?

@joshyhargreaves Do you think it might be possible for you to add those assets?  I encountered some issues trying to build react native myself, so I haven't been able to test the change.

@ccdwyer no problem, I will do this evening as currently AFK!

@joshyhargreaves Thanks!

@ccdwyer I've pushed the built assets: update the npm dependency to joshyhargreaves/react-native#616457a6a8ccc0c0b717646d2a66af68df358152

@joshyhargreaves Thanks!  I built an APK with it and sent it over to my team.

@joshyhargreaves Just letting you know I didn't forget about this.  My team is supposed to test the APK with the fix tomorrow.  Things move a little slower in the midwest. :)

@ccdwyer any news?

@joshyhargreaves Nothing yet, pinged them again for a response.

@joshyhargreaves It appears that the crash is gone for us with your change.  Thanks!

👋 @joshyhargreaves
I think that the issue OP posted is actually just one of the ways the bug can manifest itself (and #17922 is another) - this weekend we released the latest update to our app with RN 0.53 and I have 3 different crash reports that seems to be all related to the same root issue:
Fatal Exception: java.lang.NullPointerException: Attempt to invoke interface method 'android.os.Handler android.view.inputmethod.InputConnection.getHandler()' on a null object reference
       at android.view.inputmethod.InputConnectionWrapper.getHandler(InputConnectionWrapper.java:262)
       at android.view.inputmethod.InputMethodManager.startInputInner(InputMethodManager.java:1703)
       at android.view.inputmethod.InputMethodManager$H.handleMessage(InputMethodManager.java:558)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:154)
       at android.app.ActivityThread.main(ActivityThread.java:6692)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1468)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358)

Fatal Exception: java.lang.NullPointerException: Attempt to invoke interface method 'android.view.inputmethod.ExtractedText android.view.inputmethod.InputConnection.getExtractedText(android.view.inputmethod.ExtractedTextRequest, int)' on a null object reference
       at android.view.inputmethod.InputConnectionWrapper.getExtractedText(InputConnectionWrapper.java:62)
       at com.android.internal.view.IInputConnectionWrapper.executeMessage(IInputConnectionWrapper.java:273)
       at com.android.internal.view.IInputConnectionWrapper$MyHandler.handleMessage(IInputConnectionWrapper.java:78)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:154)
       at android.app.ActivityThread.main(ActivityThread.java:5523)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:739)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:629)

Fatal Exception: java.lang.NullPointerException: Attempt to invoke interface method 'boolean android.view.inputmethod.InputConnection.finishComposingText()' on a null object reference
       at android.view.inputmethod.InputConnectionWrapper.finishComposingText(InputConnectionWrapper.java:78)
       at android.view.inputmethod.InputMethodManager.checkFocusNoStartInput(InputMethodManager.java:1543)
       at android.view.inputmethod.InputMethodManager.onWindowFocus(InputMethodManager.java:1587)
       at android.view.ViewRootImpl$ViewRootHandler.handleMessage(ViewRootImpl.java:3958)
       at android.os.Handler.dispatchMessage(Handler.java:111)
       at android.os.Looper.loop(Looper.java:214)
       at android.app.ActivityThread.main(ActivityThread.java:6102)
       at java.lang.reflect.Method.invoke(Method.java)
       at java.lang.reflect.Method.invoke(Method.java:372)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1028)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:823)

Sadly I can't post much more of the stacktrace since it comes from the minified prod version; but I strongly believe the fix you linked earlier will solve these crashes too (I can't dive deeper into creating a repro or doing a new release pointing at your branch because of higher prior tasks this week).
It's still quite a small 'surface', since we are talking about a precise set of actions on a custom keyboard on Android (overall, we got less than 20 crashes reported by up to 6 users - which is a .00x% of our userbase) so no rush, but are you planning on doing a PR with it?
I don't think, since it's already late Feb, that it would be merged & cherry picked into a new 0.53.x release, but I think it would be possible to have it in 0.54 💪

Hey @kelset, thank you for the crash reports, I had actually suspected that their might be a few different ways that this bug could manifest itself.
One of the main issues I’ve had actually, is I haven’t been able to repro it myself actually, but I will put in some more effort. I’m entirely sure, that the fix I posted wouldn’t result in any more indexOutOfBoundsExceptions.
Looking at your stack traces, I’m not actually that confident that that the fix I posted previously would fix these, as it seems like the reference to the wrapped InputConnection can turn null, but I will do a bit of thinking/researching over the next few hours.
I will absolutely put in a pull request for this, I think it may be a good idea also to only enable this codepath if using ‘onKeyPress’, and so I will have a look at that also!
Let’s just get this fixed, thanks again for the crash reports.

@kelset it looks like you need to guard against null being returned by super.onCreateInputConnection(outAttrs) and that would almost definitely explain the null pointer exceptions you're seeing in your crashes, when then InputConnection target is null!
Reference & corresponding line in react-native source.
It would be helpful to know exactly the particular cases when oncreateInputConnection can return null as us returning null in these cases would stop onKeyPress from working, and when/if there'd be an appropriate time to recreate the input connection. There is also the option to implement every method in InputConnection in our subclass and guard against the null target case, but that doesn't feel right to me.

Hey, thanks for the clarification.
Yes I think replicating the fix as it has been done in the PR linked could be a good 'first approach' to have something that will prevent the crash. I believe that on the PR eventually there can be a discussion if this is the best approach or another road should be taken.

@kelset I'll put in a PR to master in a few hours. Hopefully @kmagiera won't mind giving it a review!

This should be addressed in, so I will close: https://github.com/facebook/react-native/commit/b60a727adbcfa785e3d1b13bf069b766216e60f8. Please re-open if the problem somehow persists.

I'lll re-open until this commit is merged into the0.54.

I'll close it as I am cherry picking it right now.


Use int64 instead of int for numbers.

Currently it's impossible to safely Encode/Decode int64 IDs unless all involved systems run on a 64bit machine where int data type is 64-bit. Hashids libraries in other languages (checked C#, JS) seem to support 64bit IDs.
This PR changes the []int to []int64 everywhere. All tests pass. However, since it changes the signature of the Encode/Decode functions all users of this library have to migrate their code manually.

That's a good change. However, can you make it so the Encode/Decode with int64 are now EncodeInt64/DecodeInt64 and keep the original signature (with an implementation which converts to/from []int then calls the Int64 variants). That way the API is the same for existing users, but you can use int64 if needed as well.
Also, the current tests don't go over the limits, it would be good to add tests with numbers between 32 bits and 64 bits to ensure they can be properly encoded/decoded without loss of data.
I'll merge your pull request if you can do that. Thanks.

Good idea. I added EncodeInt32/DecodeInt32 convenience functions as well, while I was at it.

That might be a bit redundant. I prefer APIs where there's not much duplication :)

Ok, no EncodeInt32/DecodeInt32 then :sunny:

Anything else I can improve here? :mag:

Updated comments, renamed variables.

Thanks, I'll do a final check tonight and merge :)

... ?

I'm sorry I didn't have the time to check yet. What I wanted to check is if the new code returns the same values as the old code, something which isn't actually tested for now (so I wanted to add tests as well). If you're up for it, you can add those tests :) It would just compare the returned string against a known one (generated with the PHP or JS version of the algorithm for example).

Done :)


Fixed branch name for nu_plugin_msgpack

This seems right. Why did you close it?

I wanted to fix the script too and didn't know how much would it take, so instead of duplicating the pr I canceled it


yt-dlp doesn't get all video formats

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.09.01 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
Hello, when i want to download from this live stream 4K quality, yt-dlp doesn't report/detects additional 1440p&2160p, also this happens on other 4K live streams, for normal videos ie non streaming everything is OK.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', '-f', '-', 'https://www.youtube.com/watch?v=HpZAez2oYsA']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.09.01 [5d7c7d6] (win32_exe)
[debug] Python 3.8.10 (CPython 64bit) - Windows-10-10.0.22622-SP0
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg 2021-07-04-git-301d275301-full_build-www.gyan.dev (setts), ffprobe 2021-07-04-git-301d275301-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] Loaded 1670 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2022.09.01, Current version: 2022.09.01
yt-dlp is up to date (2022.09.01)
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=HpZAez2oYsA
[youtube] HpZAez2oYsA: Downloading webpage
[youtube] HpZAez2oYsA: Downloading android player API JSON
[youtube] HpZAez2oYsA: Downloading m3u8 information
[youtube] HpZAez2oYsA: Downloading m3u8 information
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[info] Available formats for HpZAez2oYsA:
ID EXT RESOLUTION FPS │   TBR PROTO │ VCODEC        VBR ACODEC    ABR
─────────────────────────────────────────────────────────────────────
91 mp4 256x144     15 │  290k m3u8  │ avc1.42c00b  290k mp4a.40.5  0k
92 mp4 426x240     30 │  546k m3u8  │ avc1.4d4015  546k mp4a.40.5  0k
93 mp4 640x360     30 │ 1210k m3u8  │ avc1.4d401e 1210k mp4a.40.2  0k
94 mp4 854x480     30 │ 1569k m3u8  │ avc1.4d401f 1569k mp4a.40.2  0k
95 mp4 1280x720    30 │ 2969k m3u8  │ avc1.4d401f 2969k mp4a.40.2  0k
96 mp4 1920x1080   30 │ 5421k m3u8  │ avc1.640028 5421k mp4a.40.2  0k

https://www.avpasion.com/youtube-premium-contenido-4k/

YouTube only offers higher quality formats as DASH streams. yt-dlp can download these only with --live-from-start


Are there any plans to open source code with pre-trained models?

expectation

We plan to release our pre-trained models in a few weeks.

Are the few weeks over, does this work or just hot air ?


Add xSPWebAppExtension resource

The xSPWebAppExtension resource is used to create an extension of a SharePoint web application. It should be structured as follows:
xSPWebAppExtension PublicSiteExtension
{
WebAppUrl = "https://www.sharepoint.contoso.com"
ApplicationPool = "SharePoint Sites"
ApplicationPoolAccount = "CONTOSO\svcSPWebAppPool"
AllowAnonymous = $false
AuthenticationMethod = "NTLM"
HostHeader = "sharepoint.contoso.com"
Port = 443
SSL = $true
Zone = "Internet"
}

I'm taking a stab at this one, as my customer has a project that needs extended webapps.
That said, what conditions should trigger the Set method?
Obviously, the Set method will support creating or removing the extended zone based on the ensure property.
But I'm thinking about how to handle other situations... for example, the desired zone exists, but say the host header doesn't match, or the port? I'd rather not modify IIS settings directly for supportability, and I'm thinking in situations like that it may be best for the user to just remove the extended zone and recreate it with desired settings?
thoughts?

So I think what I want to do with this one is to make Zone name and web app URL the keys for this one, so that if you set Ensure = "present" every other property should be set to match - but those would only be the SharePoint specific bits. Anything to do with settings that are actually set in IIS I think can and should continue to be managed through xWebsite in the xWebAdministration module. Does that make sense?

make sense... looking at the SPWebApp.IisSettings[[Microsoft.SharePoint.Administration.SPUrlZone] object properties, it looks like we can support changing an existing zone's AllowAnonymous and Kerberos / NTLM auth settings as well. For actual bindings, I agree, leave that with xWebSite.

Hello,
@MikeLacher448 I saw you started to work on on SPWebAppExtension and it's awesome, but in your current version you allow only Windows NTLM or Kerberos authentication modes.
But:

it should be possible to set FBA or federated authentication
it should be possible to combine multiple authentication modes.

For example, below I add both NTLM and dederated authentication:
$winAp = new-SPAuthenticationProvider -UseWindowsIntegratedAuthentication
$trust = Get-SPTrustedIdentityTokenIssuer "Proseware"
Get-SPWebApplication http://sp16/ | New-SPWebApplicationExtension -Name "SharePoint - 443" -SecureSocketsLayer -Zone "Intranet" -URL "https://spsites.proseware.com" -AuthenticationProvider $trust, $winAp

Can you please make sure those scenarios are covered?
Hello,
@MikeLacher448 I saw you started to work on on SPWebAppExtension and it's awesome, but in your current version you allow only Windows NTLM or Kerberos authentication modes.
But:

it should be possible to set FBA or federated authentication
it should be possible to combine multiple authentication modes.

In example below, I add both NTLM and federated authentication:
$winAp = new-SPAuthenticationProvider -UseWindowsIntegratedAuthentication
$trust = Get-SPTrustedIdentityTokenIssuer "Proseware"
Get-SPWebApplication http://sp16/ | New-SPWebApplicationExtension -Name "SharePoint - 443" -SecureSocketsLayer -Zone "Intranet" -URL "https://spsites.proseware.com" -AuthenticationProvider $trust, $winAp

Maybe a possible way to implement that would be to use a parameter of type Microsoft.Management.Infrastructure.CimInstance[] in the script (I used that in SPTrustedIdentityTokenIssuer).
Can you please make sure that those scenarios are covered?

sure, I just did a direct copy / paste from the SPWebApplication resource for the authentication, but this makes perfect sense. I'll see what I can do.

@MikeLacher448 @Yvand I would rather see us put in the extension option with just the NTLM/Kerb support we have elsewhere as a starting point rather than make Mike slow down here trying to make this one perfect first go. I think we should raise another issue about "Lack of claims support in Web Applications" and track that as a separate piece of work. @ykuijs  your thoughts?

Agreed!  That way it can be used for folks (like my current customer), that just need support for an extended web application with Windows Authentication while I (or anyone else who'd like to tackle it) work on adding claims support for a future update.

I agree that adding support for FBA/Federated authentication should not delay the release of the resource, especially considering that SPWebApplication resource misses it for a while.
But it's a very important feature to integrate in a future version, and I'm very glad that @MikeLacher448 is already working on this for a later release, thanks a lot for this it will be very useful!

OK I'll raise a new issue to add that claims support in to these resources and we can track that separately to this one.

Resource created in PR #510


fix unit test.

Please check if the ./gradle clean build is passing before raising the PR. Ideally, we should have a pipeline setup but since not available for FLO. Please take care of this manually before raising the PR and add this in our backlog.

Yeah Naveen It was a miss. this change was already there in the branch but was not pushed to the remote.


Sysadmin level chat history export to S3 & user chat history controls

As the Ollama Web UI sysadmin I need to be able to download chat history from all users and also block users from deleting their chat history.
Describe the solution you'd like

Enable the sysadmin to download use chat history on a per user basis for a given time range (up to the first day they used the OWUI app).
Block end users from deleting chat history
Ability to connect an S3 object storage bucket to OWUI so that chat history can be pushed into object storage vs  being stored on the local host.

Describe alternatives you've considered
Bionic GPT has this capability by connecting to it's local postgres database which has access logs and chat history logs.
I'd like to do the same thing with OWUI.
Additional context
I need this capability for chat history security and compliance audit use cases.

Thanks @justinh-rahb - I am looking to use OWUI in High Schools with minors, so we have Legal compliance requirements that need us to be able to run reports on user activity. We can't have the kids using the tool and then deleting harmful chat history. So that's why we need the feature to block deletion of chats by end users - safety..

Thanks @justinh-rahb - I am looking to use OWUI in High Schools with minors, so we have Legal compliance requirements that need us to be able to run reports on user activity. We can't have the kids using the tool and then deleting harmful chat history. So that's why we need the feature to block deletion of chats by end users - safety..

Absolutely, I believe almost any scenario where an admin would want a way to download the history in bulk would likely also require that it not be removeable by users. At the moment, fine-grained access controls are still a planned feature as opposed to implemented, please see related issue #446

I'll narrow down the scope of this feature request to just  "blocking users with "user" role from deleting chat history". I don't plan on implementing the first and third requests in the near future, as they seem like very niche use cases. Feel free to create a separate issue/PR for the two.

What is "delete" is just a flag in the database. Only show "not deleted" chats.

Another future feature for this scenario would be an audit log. Delete could mean "remove from db" so long as it got dumped to the audit log.

@tjbck @justinh-rahb is there any chance that you could implement the "blocking users with "user" role from deleting chat history" feature by end of this week? I am planning a demo next week and would be great if users are prevented from deleting chats by then. Thanks for the great project!!!

@tbendien You can now toggle the setting from Admin Panel > Admin Settings > Users, let me know if you encounter any issues!


Support for silent installation with a default device

This pull request aims to fix the following issues:
#807 #205
Currently, if the installation is silent with k3os.install.silent=true you are forced to also set k3os.install.device.
This behavior is not documented in the current README.
I think that setting only k3os.install.silent=true without a device could be very useful (not only for my case).
The device is set to the first one available, simple as that.
Of course, setting both silent with a specific device is still supported.

This sound dangerous behaviour, it can accidentally  erase valuable data,  e.g. sda is not alway point to the same disk on each boot ...


aws: gp2 volume type for root device

[x] Installs cleanly on a fresh build of most recent master branch
[x] Upgrades cleanly from the most recent release
[x] Updates documentation relevant to the changes n/a

updated the aws terraform instance root volumes to use the gp2 type by
default
configurable for root and attached volumes
however, without manual configuration, the options are effectively limited to standard and gp2 due to terraform limitations. The io1 requires specifying iops on each volume but that setting is not compatible with the other types and cannot currently be conditionally included. If you want to set io1, you will also need to update terraform/aws/instance/main.tf to specify the iops attribute on the specific volume(s).
I did not update the legacy terraform/aws/aws.tf terraform with this option.

Fixes #1414

aws build failed due to quota.

@ryan are we good to merge this one?

I've been using it successfully on aws. as long as it looks good to you, it can be merged


ForceMove safety

This PR contains a draft blog post on the safety considerations taken in the ForceMove protocol.

Hi - I wonder if it might be worth adding in a little bit about who can issue a forceMove() transaction?  I'm a bit confused about who Eve is?  I managed to make sense of things when I decided that Eve and Bob were the same person, but that led to confusion in Version 4 when it appears that Bob is calling forceMove() when it's his/her turn to act next.
I went back to the code and this does appear to be allowed.
Could you possibly clarify this a little?

also - I'm 90% sure you want griefing rather than grieving throughout!

Hi - I wonder if it might be worth adding in a little bit about who can issue a forceMove() transaction? I'm a bit confused about who Eve is? I managed to make sense of things when I decided that Eve and Bob were the same person, but that led to confusion in Version 4 when it appears that Bob is calling forceMove() when it's his/her turn to act next.
I went back to the code and this does appear to be allowed.
Could you possibly clarify this a little?

Yes, Eve should be Bob. It's a mistake from an unfinished copy/paste.

@tomclose maybe close this in favour of the new blogging repo base.

This draft is no longer relevant, given @tomclose's draft post.


hugh information delay on using manuell wall switches

Hallo together,
i wants to thank you for this pretty usefull adapter. It keeps helping me in summer time to cool our house down.
I have recogniesed a problem, and i would like to know if i have something missconfigured.
The Problem:
Everything works fine and informations are updated in a reasonable time. But wenn i use our wall switches which are connected to our sunshade motors it took 1 hour to get the information that the position of our shades have changed. If i command a new percentage value via ioBroker/your app, i get it in 20 seconds. Is this behavior normal or is there a posibility to get the information faster?
Thanks alot in advance.

Hi,
to what number did you set the Polling interval in the adapter configuration? This should influence how often the adapter checks for updates on states.


Deprecate notice in PHP8.3 on the TreeNodeMethodsTrait method offsetGet()

There's a deprecate notice when you run PHP8.3 with this bundle:
Deprecated: Return type of offsetGet(mixed $offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice.
I guess there can be an easy fix for this in file TreeNodeMethodsTrait.

Update: made a PR for this: https://github.com/KnpLabs/DoctrineBehaviors/pull/753


No reply from GPT dead

Reinstalled but not getting any reply from Chatgpt

Same here - no response. This is a critical issue!

Still not getting any Response.

No response for all the time!!! What's wrong?

same here, no reply

Hello everyone, I'm excited to announce that this repository has now migrated to utilize OpenAI's official chat API. Please refer to the new guidelines for instructions on running this project. Thank you for your attention!


Environment page text should not be bolded

Title "Local" can be bold, subtitle "Train locally on your machine." should not be bold

I believe this is coming from the style for selected tabs? We should remove it because it makes the text change size and it's distracting. It should be in Resources.xaml under the "IsSelected" trigger for SideTab

I just asked Bri, it's the description text shouldn't be bold when selected. Which can be fixed simply by removing style.

The text isn't changing colors right. We should be able to make a new style that similar to the old but without the bold. Or we could just remove the bold.


Please add a LICENSE file

I would love to use some of this as a starting point for my own swarm setup. Could you add a LICENSE file that specifies the license under which this code is released?

The license has been added.
By the way, few days I published 70% of my new book. The next chapter that will be added in a week or two will go into more details about clustering and networking with Docker and Docker Swarm. You might want to check it out.
https://leanpub.com/the-devops-2-toolkit


Following up from #21, should we only run CI on the master branch? I don't think we need to run it on anything else, but this is also a minor issue that can be resolved when it becomes a problem.

I think it's desirable to run testing CI on all branches. That way a PR on an existing PR branch will be tested. PR builds might still be automatic regardless of this setting.
Asset generation (e.g. publishing mdbook) should be restricted to only master, and that's handled with sane defaults with provider: pages (for gh-pages branch).
In conclusion, we shouldn't need to touch the branches setting.
https://docs.travis-ci.com/user/customizing-the-build/#building-specific-branches

I think it's desirable to run testing CI on all branches. That way a PR on an existing PR branch will be tested. PR builds might still be automatic regardless of this setting.

True. Closing this issue then.

Asset generation (e.g. publishing mdbook) should be restricted to only master, and that's handled with sane defaults with provider: pages (for gh-pages branch).

This might be a separate issue, but I hate the idea of using two separate branches. If gh-pages is what the branch name needs to be for the website to be served via GH, then is it possible to rename master to gh-pages? Or perhaps it should be a separate repo primarily for this purpose...?

If gh-pages is what the branch name needs to be for the website to be served via GH, then is it possible to rename master to gh-pages? Or perhaps it should be a separate repo primarily for this purpose...?

The gh-pages branch is just where the autogenerated html files are dumped during CI merge/deploy:
https://github.com/purescript-contrib/purescript-book/blob/master/.travis.yml
https://github.com/purescript-contrib/purescript-book/tree/gh-pages

Looks like they've updated things since I last looked at GitHub Pages. See choosing a pubishing source. You can chose to use the gh-pages branch, the master branch, or the docs/ folder in the master branch. Of these three, I think the docs/ folder makes sense.

With docs folder strategy:

Con: Additional commit noise and larger checkouts.
Pro: Offline html viewing.

Let's try docs strategy for this repo and see how that experience compares to gh-pages with the other book.

docs-approach it is!


Help: Need someone who will clean and combine gathered data

Hi Vlad, do you mean to combine two csv files that we have?

No. It will be about 130 different csv files after script. They all have
different columns and some of them not a csv data at all. We need to clean
them all and combine to a single file.
On Sat, Feb 10, 2024, 3:04 PM Atindra @.***> wrote:

Hi Vlad, do you mean to combine two csv files that we have?
—
Reply to this email directly, view it on GitHub
https://github.com/MIT-Emerging-Talent/2024-group-02-cdsp/issues/12#issuecomment-1937245140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIOWMBVS7RKEAKKXGTOYNJLYS7VHXAVCNFSM6AAAAABDB4JOTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGI2DKMJUGA
.
You are receiving this because you were assigned.Message ID:
@.***>

I cleaned the data and added it in the data-entry branch. Is ready to review.


login updated

Related Issuse

Info about Issue or bug
In the login section, if one does not fill the details like email and password and click on submit then, it is redirecting to the next webpage.

Closes: #166[issue number that will be closed through this PR]
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
I have added the mandatory field option in login.html file for the required inputs.
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

Screenshots

Original
Updated

original screenshot
updated screenshot

Requesting @admins to review my PR.

@sreetu Can u pl check why it is showing all lines changed. Pl. fix that in changed files of ur PR

@sreetu I think ur fork is not updated. Please work on latest code.

And resolve the conflicts

Sir, I have updated my fork twice but the conflicted code does not arise there. I am working on it.

@khannakshat7 sir, after resolving conflict, when i try to merge the resolved conflict by clicking on commit merge (to commit the changes in pr) and updating changes to master branch, it everytime mentions that all lines are changed. what should i do next?

Actually Sir, while resolving conflict some changes are made on github editor then, while commiting those changes, the whole file gets committed again, that's why, it says that all lines changed.

Actually Sir, while resolving conflict some changes are made on github editor then, while commiting those changes, the whole file gets committed again, that's why, it says that all lines changed.

I suggest you to make a fresh PR. As i also go through this type of problems many times.
As much i understand you just have to put ''required" in two input tags...so its not a big deal to do this changes again. Just pull the latest code in master branch to your master.make a new branch, do the changes, make a fresh PR simple

Ok


 Update the command to use correct syntax, be verbose for debugging purposes, include 1000ms timeouts, and progress from TERM to KILL.

The underlying container uses a version of kill that does not support these flags. Closing.


Potential problem

Hello,
Let me start of by saying I haven't tested the code, since I don't have an LDAP server nearby. But I just went through the code and wondered if this isn't going to give a problem:
return {
			userId: userId,
			token: stampedToken.token
		};

In the case where the user doesn't exist, since then no stampedToken is going to be present, as it is only generated when a user already exists but it is returned in both cases...

@sebakerckhof It is initially set to null so if a user does not exist and isn't being created, it will remain null. But in general you're right, it's just sloppy code. I plan on cleaning up the server code in the coming days.


Missing isOwnCompanyData in BPDM request payload

Current Behavior
During company onboarding in BPN creation step BE is sending this flag OwnCompanyData to BPDM while as per their documentation flag name should be isOwnCompanyData
API of BPDM : PUT: input/business-partners
Specification of API Latest: Latest : upsert-business-partners-input
Specification of API 24.05: upsert-business-partners-input
Expected Behavior
BE should send this flag isOwnCompanyData to BPDM .
Steps To Reproduce
It can be checked directly in code
Model is used is this
public record BpdmLegalEntityData(
    string ExternalId,
    IEnumerable<string> NameParts,
    IEnumerable<BpdmIdentifier> Identifiers,
    IEnumerable<BpdmState> States,
    IEnumerable<string> Roles,
    BpdmLegalEntity LegalEntity,
    BpdmSite? Site,
    BpdmAddress Address,
    bool OwnCompanyData
);

current documentation shows the same.
if this is fine for @ntruchsess / @evegufy / @Phil91  i am too.

current documentation shows the same. if this is fine for @ntruchsess / @evegufy / @Phil91 i am too.

yes. makes absolutely sense to change it on our side. PR approved and merged