Fix strange markdown rendering in API docs

Hugo's markdown renderer does not support rendering markdown inside HTML tags and does not support the markdown="1" attribute on HTML tags that Jekyll supports to enable markdown rendering inside the tags.
To work around this limitation, we have a custom md shortcode that can be used inside HTML tags to wrap markdown that should be rendered. However, there was a bug in our md shortcode. We use the {{% md %}} syntax instead of {{< md >}} because we intend to have markdown inside the shortcode, and inside our md layout, we use {{ markdownify .Inner }} to render the .Inner content as markdown. However, in some cases, when not actually inside HTML tags, .Inner will end up being already rendered markdown. So we end up passing the already rendered markdown through the markdownify function, resulting in some wacky rendering.
The fix is to specify the behavior of {{% %}} per https://gohugo.io/content-management/shortcodes/#shortcodes-with-markdown, to consistently render .Inner as markdown whether it's inside HTML tags or not, and emit .Inner directly without passing it through markdownify.
Before
https://pulumi.io/reference/pkg/nodejs/pulumi/aws/s3/#static-website-hosting

After

Fixes #1118

Gonna merge and deploy to production to fix the rendering issues in the API docs. Happy to address any feedback subsequently.


ARROW-16501: [Docs][C++][R] Migrate to Matomo from Google Analytics

It's for becoming compliant with the GDPR (the European Union's
General Data Protection Regulation).
See also:

https://privacy.apache.org/policies/privacy-policy-public.html
https://privacy.apache.org/faq/committers.html

@github-actions crossbow submit test-ubuntu-default-docs

I have grep the code for any other reference to the GA id (UA-107500873-1) and have not found any others

We can also confirm it against the generated document that is uploaded to https://github.com/ursacomputing/crossbow/releases/tag/actions-2038-azure-test-ubuntu-default-docs
(I've confirmed that Google Analytics related tags aren't included.)

@kou only so I know how can I check that in the future, where did you found that the apache arrow site id is the id number 20?

I asked it at<EMAIL_ADDRESS>https://lists.apache.org/thread/g1cc82o4yv628c9652xsz7zwgy6vhl1p
Note: This is a private mailing list that can be viewable only by committers.
See also: https://privacy.apache.org/faq/committers.html#can-i-use-web-analytics-matomo

Can I use Web Analytics (Matomo)?
Yes: the Privacy Comittee has established a VM running Matomo, a GDPR compliant web analytics software. You can ask for your site id and tracking code at<EMAIL_ADDRESS>
BTW, we can see Matomo's dashboard for Apache Arrow at https://analytics.apache.org/index.php?module=CoreHome&action=index&date=yesterday&period=day&idSite=20#?period=day&date=yesterday&category=Dashboard_Dashboard&subcategory=1 .

@github-actions crossbow submit test-ubuntu-default-docs

Artifact: https://github.com/ursacomputing/crossbow/releases/tag/actions-2044-azure-test-ubuntu-default-docs


Can we use Rational Numbers instead of the Epsilon Hack?

https://github.com/LarryBattle/Ratio.js
@sjkaliski @ethanresnick

It depends on what you want to concentrate on for the library in general, but there will be many things you cant do without a BigNumber, or some sort of fraction/rational number engine.  i.e. I wrote a simple addition to the generator.js to generate a pascal triangle row just to play with the library, and can only get to row 55 accurately using the simple JS number precision.  If there was a "factorized" number class for working with Integers, you could get much farther for certain things like this.
I have found the best way is to actually keep numbers in factorized rational form if you want to play with integers and go farther than what precision calculations generally takes you.  <~2^55 is quite low.
C double gets to about 1000th row <~2^1000 with the same algorithm.
My primary interest is for playing with integer calculations and statistics.  The library algorithms in general seem very efficient :)
generate.pascal = function (n, result) {
if (n < 1) return;
var s = 1;
var stemp = 1;
var ntemp = n;
result.push(s);
while (ntemp > 0){
s *= ntemp--;
s /= stemp++;
s = Math.round(s);
result.push(s);
}
return;
};


Hygiene breaks add_one! macro

The add_one! example from the readme works with nightly-2017-12-02 but not nightly-2017-12-03.
   Compiling example v0.0.0
error[E0425]: cannot find value `x` in this scope
 --> src/main.rs:8:16
  |
8 |     let nine = add_one!(x) + add_one!(2 + 3);
  |                ^^^^^^^^^^^ not found in this scope
  |

Is there a workaround for this?

@rushmorem No workaround exists. As a result of https://github.com/rust-lang/rust/issues/46478 it was decided that the fix for macro hygiene will stay, disallowing the use of local variables as macro input to proc-macro-hack.

Fixed in 0.5.0.


Active state not working correctly on links with query strings

Scenario
I have a link in my global header to page with a filterable list of objects. The link includes a query parameter, because the starting state of the list is to already have a filter applied. The link looks something like this:
<Link
  className="menuitem"
  activeClassName="active"
  to={{pathname: '/tickets', query: {status: 'open'}}}>Tickets</Link>

When I click the link and the page loads, the active class is correctly added to the link.
Problem
When I change the filters, e.g. changing the path to just /tickets or /tickets?status=closed the active state is removed from the links.
What I expect
I expect query strings to be ignored for all consideration of what is the active path. Links behave as expected if they link to the naked pathname, rather than one with a query string (i.e adding filters preserves the active behaviour), but break when the link itself contains a query.
Versions affected
Only observed with 2.0+, but no reason to assume the problem didn't exist before.

This is operating as designed and tested. We expect the full location to match, including the query string.
It's actually more useful this way. Otherwise, how would you go about having links to the Open / Close state and mark either as the currently active one?

I'd have to solve that problem myself anyway, and already have (this isn't the first time I've built a complex faceted search feature). Because as soon as you care about more than one query parameter (which I do), whether a filter is "active" can't be determined without looking at the individual parameters - exact marching on the full URL won't work.
Aside: if you're asking me a follow-up question, shouldn't you wait for my reply before closing the ticket?

On 13 Apr 2016, at 19:29, Tim Dorr<EMAIL_ADDRESS>wrote:
This is operating as designed and tested. We expect the full location to match, including the query string.
It's actually more useful this way. Otherwise, how would you go about having links to the Open / Close state and mark either as the currently active one?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

It's tricky here. Ultimately I think we have a relatively simple API in <Link> that works well for most common use cases. You're correct that custom use cases like yours where the link activity and the link target are different will require extra code.
I'm not sure what we can necessarily do here, though.

For every person who wants it to work the way discussed here (if the segment of the query matches, it's active) there's another who doesn't want that to be active, but only if entire query matches.
In these situations, we ask "what does the browser do?".
a:visited { color: purple; }

bar
 baz

If you visit ?foo=bar it will turn red, but ?foo=baz will not.
We think this is the path of least surprise.

Aside: if you're asking me a follow-up question, shouldn't you wait for my reply before closing the ticket?

It was rhetorical. Sorry if it came off snarky. There's really a few different ways to define "active"-ness of a URL. We've chosen one that works well for most people and the decision is made. There's not really anything actionable here.
What would make a better issue is the discussion and consideration of more expressive "active" checking. For instance, having props like activePathClassName, activePartialPathClassName, activePartialQueryClassName, etc etc to check various partial or exact "active" states. There is probably a more concise and flexible means of doing that. If there's a specific suggestion, that would be greatly appreciated.

@ryanflorence I don't think we should automatically use the state of visited links as an example to follow.. Active route functionality has no existing semantics in browsers, mapping it to something else that may not be analogous is an error in my mind.
This is functionality that can be ignored and re-implemented by users of react-router (I assume, since i'm being told this is what I have to do). The fact that it can be implemented on top of the router, suggests to me that the only way it can justify being in the core is if everyone works in a way that you can argue solves nearly everyone's problems. Otherwise it's dead file-size that we can't opt out of.
To that end, I'd like to ask what use cases active route indicators actually address, two spring to mind, and I'm not convinced they're fulfilled by the current implementation:

A user needs some indication of which "section" or "page" of a site they are on. Following best practices for URL semantics, the path segments indicator the resource, query strings indicate options which manipulate the display of that resource (filters, sorting, paging, and frustratingly, tracking parameters). Following this practice, a query string doesn't change what resource you're looking at. The example i've provided and suggested as being broken, fits this use case - I want my nav link styling to indicate that a user is on a certain section of the site. I just happen to link directly to a pre-filtered list as a UX decision to save time.

A user is on a list of results, and needs to see what filters are selected, and what page they're on - Again, using best practices, query parameters are used to fulfil the URL part of this. We'd consider one of the links that controls this (let's say a facet link, or a pagination link), to be active when the query for the page includes the key/value pair represented by the link. Things like default filters and page 1 of pagination add further edge cases. Because this behaviour can end up being quite complex, i'd never expect my routing library to be responsible for telling me whether a filter option is currently active. Compared to the complexity of building an appropriate to prop for a Link with lots of filters, working out whether a link is active is trivial, and will usually be done at the same time. This is the use case alluded to by @timdorr in his first comment, and I think it's too complex to expect it to be supported by the default behaviour of the router.

(Note, I appreciate my mentioning of best practices is somewhat nebulous, but i've been a URL design nut for about 10 years, and haven't seen much to contradict what i'm saying)
Basically, I think neither of these use cases are wholly supported by the current solution, but I strongly suspect the first one is a more universal requirement for building sites, and it's also the use case closest to being fully supported - with the exception of the edge case I've presented in this ticket. If there are common use cases i've missed, i'd love to hear them - if i'm wrong, I want to know why :)
(Another aside: should this whole feature have a different name? Because "active" already has a defined meaning when it comes to link states.)

I can tell you that as a user of this library, the first time I hit the functionality for determining active state for queries on <Link>, that this behavior was exactly what I expected.
Additionally, at this point, it'd be quite expensive for us to introduce a breaking change to the semantics of active state on query state on <Link>, even to the extent that we want to make such a change.
As such, why don't we talk about ways to better support your use case? One option I'm considering is backporting a few changes from React-Router-Bootstrap into here.
The one change relevant to you would be to accept an active prop (forget the naming for now) that overrides the automatically calculated active state.
Another option might be to factor out reusable logic (the click handler, mostly) in <Link> and allow you to build your own.
Thoughts?

I'm actually a little confused, because when I discussed this with you in Discord a few days ago, you indicated that the behaviour I'm expecting here is what was already supported, however that's not important. I still want to know what use cases I'm missing, because if we're going for unsurprising, I find the current implementation surprising. But in the interests of this conversation going somewhere, let's look at your suggestions.
I think any solution has meet a couple of criteria:

It needs to be easy to determine what route is active based on whatever pattern I choose. There probably aren't that many different ways of doing this, but who knows?

The size of my code bundle shouldn't suffer from a solution i'm not using - i'm happy to let tree-shaking take care of this. But ultimately, if I'm solving this from scratch for myself, I don't want any mention of react-router's active functionality making it to my production build.

I don't mind writing my own Link component, as long as it's trivial to do so and i'm not copy-pasting logic. I already wrap every DOM and 3rd party component to inject CSS Modules, so this isn't creating work I don't already do. Conceptually it feels cleaner than adding yet another prop to Link, because I believe in small-focused components rather than ones with a billion configurable properties.
In terms of determining active route, I like @timdorr's suggestions, but I'd prefer being able to perform those checks via the router or history objects rather than as className props (who knows, it may affect something other than what classes get applied to the link). It feels like I need some of the logic that React Router provides, but some way of specifying which parts of the URL I care about when it comes.

I'm not sure what you mean.
If you think about what's involved here, this is going to look effectively like calling isActive with a different location descriptor on your end. I don't think we want to change the semantics of isActive.
This line of code: https://github.com/reactjs/react-router/blob/b5175b15bf0999e5fb151f57a8126aca3537a7c9/modules/Link.js#L119 is all that's involved in the link active state determination. Nothing else would change here, so code size ought not be a concern here.

What else is router.isActive used for?

It's exposed as an API on the router. I use it directly in a few places (via <LinkContainer>) when my logical site mapping doesn't line up with my URL/route scheme.

Okay, based on what you've said, it seems the right approach is pulling out the bulk of Link so it's easy to use in an alternative component. No other changes would be required.

Which parts of <Link> do you specifically not want?

Well it seems i'd have to write my own version of of the render method to create a different descriptor, which looks like a lot of code copying for such a tiny change.

The idea would be that we accept active as a prop to <Link>, and let that take precedence over the computed value.

That works, and if it's the simplest approach to implement I'm happy. I'm not convinced it's the best solution, but i'd live with it for now.


Minor fixes

This PR does some minor fixes on issues I found while working on #172. Since they ended up not being required for the GitLab work I moved them to a separate PR.
Best reviewed commit by commit.

Codecov Report

Merging #173 (5d12ac6) into main (a60ccc9) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   92.00%   92.26%   +0.26%
==========================================
  Files          29       29
  Lines        1575     1617      +42
==========================================
+ Hits         1449     1492      +43
+ Misses        126      125       -1

Flag
Coverage Δ

unittests
92.26% <100.00%> (+0.26%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ggshield/cmd.py
86.73% <100.00%> (ø)

ggshield/output/json/json_output_handler.py
88.57% <100.00%> (ø)

ggshield/output/text/text_output_handler.py
95.65% <100.00%> (ø)

ggshield/scan/scannable.py
95.03% <100.00%> (ø)

ggshield/utils.py
97.81% <100.00%> (+1.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60ccc9...5d12ac6. Read the comment docs.


Update snyk to 1.165.1

:tada: This PR is included in version 1.0.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Apple backend disk images can be accidentally removed when reordering them

Describe the issue
This is a very nasty bug in the UI for the Apple backend on Apple Silicon. I actually nuked a couple of my VMs (thankfully, unimportant ones) by performing the following steps:

Create an Apple backend VM, either for macOS or Linux

Install the guest OS for more drama ;) - the bug will still happen without it, though

Open the VM settings dialog

Click "New Drive" and create a new drive

Without closing the VM settings dialog, reorder the disk images so that the newly created drive ends up in the topmost position (either by dragging or using the Move Up / Move Down buttons)
Note: if you close the VM settings dialog after creating the drive, then reopen it and do the reordering maneuver, everything will work fine. The bug only happens if you create and reorder the drive in the same go.

Observe how the new drive has been saved as disk0.img within the VM bundle, overwriting the existing root drive. Moreover, config.plist will now refer to the same image twice, making the VM configuration invalid. Now you can't start the VM, it'll fail with the "Invalid virtual machine configuration. A storage device configuration is invalid." message if you try. You can't even remove the invalid drives from the UI. And the data from your original root drive is gone.

This is especially annoying as this disk reordering maneuver is part of the hack to boot into macOS recovery. See also #3526.
Configuration

UTM Version: 3.2.4 (58)
OS Version: macOS 12.4
Apple Silicon

This should be fixed in v4.0 as part of the configuration backend rewrite.


SNOW-810566: Fix SQL simplifier on filter and sequence column

Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN

Fill out the following pre-review checklist:

[ ] I am adding a new automated test(s) to verify correctness of my new code
[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency

Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.

Can we add some tests for window + filter?


Remote storybook

We should provide a remote link to the storybook on each pull request with the current modifications.
This can help reviewers to see what the modifications makes.

duplicate of #65


Allow making a radius around a prop/character to walk to

What's the expected benefit of the feature you are requesting?
The WalkToHelper is directional, which means that if the player approaches a character/prop from another side they will first have to walk to that other side.
Describe the solution you'd like
I propose making a "WalkToRadius". Basically the player approaches the character in the closest point in a circle of that radius, whether it's from the left or the right or whatever.
Describe alternatives you've considered
N/A

This may be related to #131
@BenjaTK can you confirm they are trying to solve the same issue?
Note: At the moment a possible workaround is to statically create the "hole" around the object or character in the walkable area.

Kind of? Right now when a character walks towards a prop or another character they walk to a WalkTo position in the character. With this I propose that we can make this position more dynamic, with a radius.
So let's say the WalkToHelper is placed in the middle of character, and the radius is 24px. If the character comes from the left it moves to the left of the character 24pxs away. If it comes from the right, it moves to the right. The way I do it in my game is I just get a vector from the target character to the moving one and set its length to radius then add that vector to the walk_to_position. Just getting the closest point in a circle.

Ah, now I understand. That's related but not the same. Thanks for clarifying!


Newest bubble not shown when KB is shown

I would expect that when the keyboard is shown, the messages would scroll to the bottom so that you can see the latest ones but when the keyboard is shown there is no scrolling so the latest messages are hidden under the keyboard.
How can I make it scroll down whenever the kb is shown so that the latest messages are not hidden?

hmm.. sounds like you have something else wrong.
self.automaticallyScrollsToMostRecentMessage defaults to YES

What are the requirements for this to work? What can I investigate since it's not working?

I am also facing the same issue. How did you resolve it?
Thanks

I didn't.
On Thu, Apr 23, 2015 at 12:45 AM, manobal<EMAIL_ADDRESS>wrote:

I am also facing the same issue. How did you resolve it?
Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/jessesquires/JSQMessagesViewController/issues/876#issuecomment-95430783
.


DOC: example for adhesive simulation with the sphere

https://github.com/ContactEngineering/Adhesion/blob/df9d5b1073e8d69b5cf01216d8953f8dc6e45321/long_tests/test_sphere_vdw82_mpi.py
There is already a test where we show plots comparing to MAugis Dugdale.
Maybe we can take code from there


Fix issue #1038

I think this should fix the problem but I'm new to Node, so please forgive me if it's not good.

cc @bmarini

@guimonz that looks nice, can you add tests for this new behavior?

Sure @simov!
I'll add them tonight!
:-)

Looking good, @guimonz can you pull https://github.com/simov/request/commit/bbcff4188629836662fb6e58c96cdf68f5876cc4 here? Only a minor indentation fixes, other than that :+1: from me.

Here you go, @simov!

Thanks @guimonz I'll merge this shortly.

:+1:

cc @bmarini


chore: digitize design architecture and components

Located here: https://docs.google.com/document/d/1OvOqWWqLs-wJG-z0YVPiWGFtVGLoEsfkvBHzwegG9bI/edit


Current stable release is 2.6.0

Thanks for the PR, @saz!
The document needs to be more generally updated, not only the link to the latest release. It should match the structure and content of https://github.com/wp-cli/wp-cli.github.com/blob/main/index.md.
Are you maybe up to going over the document in general to submit these needed changes?


Allow the endpoint to set transport state

We need to execute the EndPoint before executing the transport so that user code can affect the transport.

Done!


Token Resource Attirbutes not available

If we want to display, for example, the casualities (hp) of the unit on the token as a display bar, there does not seem to be the option.

This is a bug introduced by dnd5e 3.0, I missed that in their updates to the TokenConfig they kinda broke things.


Sequence Data

Hi
webdataset==0.2.86
when I use webdataset, the data I need is a sequence that requires the current frame image and its previous and next 3 frames.
These frames come from 300,000 video clips. I save each clip as a sample inside a tar file. After that, I use compose + generate_clips to read this sequence.

Then

However, I've noticed that this method is extremely slow, and num_workers doesn't seem to have an effect.
What can/should I do?

problem solved;
just make sure num worker <= tar file num
issue closed

Webdataset is such a great work!

problem solved
just make sure num worker <= tar file num
issue closed
Webdataset is such a great work!

Thanks. Sorry for not responding earlier, I was away at a conference.


Doesn't articulate the drawbacks of key-trust

Remote Desktop Connection (RDP) sign-in using Windows Hello for Business (WHfB) isn't possible with key-trust deployments. Additionally, it doesn't make it clear that two Azure AD Connect synchronisations are required in order for WHfB to begin working. These pages should be guiding people to make decisions on which method to use, but they don't give all the information to understand why one option may be better than another.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd3b8524-491d-7f49-0445-a34ed47d504c
Version Independent ID: 1106b56a-45f9-9465-7c7c-2fa9a68ca807
Content: Windows Hello for Business Deployment Guide
Content Source: windows/security/identity-protection/hello-for-business/hello-deployment-guide.md
Product: w10
Technology: windows
GitHub Login: @DulceMontemayor
Microsoft Alias: dolmont

@officedocsbot assign @jvsam

Hi @webash , thank you for your feedback. I will get this issue over to the Windows writing team for review. I also requested the team to update this issue if we need additional information from you.
We want users to have the best Windows 10 experience by ensuring that contents of the Microsoft Docs are useful, relevant and up-to-date. Suggestions, comments and feedback to improve the docs are always welcome!

@webash Thank you for your feedback, I will investigate further.

@webash Please have a look at this article and let me know if it helps, and I can have it added to the doc. https://docs.microsoft.com/windows/security/identity-protection/hello-for-business/hello-faq

These FAQs don't address the two issues I raised in my original comment; unless I've missed them somewhere in the page?

@webash Sorry to hear that. I did some more research and found that there is a terms section coming out in the 'how it works' section that goes over key trust, cert trust and the trust types. It should be visible with the next update coming out soon. @DulceMontemayor Could you please advise on update and documentation for this?

Hello again @webash, thank you for your patience. I just want to inform you that there's already a suggested update to this documentation (see PR #4568) based on your feedback. PRs are normally reviewed/merged in the order of submission but once approved, they will be displayed here at docs.microsoft.com site in the next scheduled publishing run. I will let you know once the PR has been approved and merged.

Calling out the RDP limitation is great - thanks for that. I wonder if there are other places where key-trust doesn't work and should all be listed? Otherwise if RDP the only drawback, then this note is great :)

Calling out the RDP limitation is great - thanks for that. I wonder if there are other places where key-trust doesn't work and should all be listed? Otherwise if RDP the only drawback, then this note is great :)

You're welcome! So far, we only have details on key trust in relation to RDP @webash. And thanks for requesting for it to be clarified on this doc.

Hi @webash, PR #4568 has been approved and merged. Soon, the updates will be displayed here at docs.microsoft.com. We will now close this issue, however, feel free to re-open if you have other suggestions or ideas to improve the quality of this documentation.
We really appreciate your feedback and thank you for being part of the Microsoft Docs community!

@officedocsbot close

Oops, I must have missed it before but "Windows Hello for business" is missing a capital on the "B". I know it is minor, but it may cause confusion as to whether it is referring to the product Windows Hello for Business or not. @jvsam

Even though the page appears to be updated yesterday, it does not have the full text from the pull request added in the note yet. When it does (not sure how soon), it should read

Remote Desktop Protocol (RDP) does not support authentication with Windows Hello for Business key trust deployments. RDP is only supported with certificate trust deployments at this time. See Remote Desktop with Biometrics to learn more.

instead of the current text

RDP does not support authentication with Windows Hello for business key trust deployments. RDP is only supported with certificate trust deployments at this time.

Very strange!

Yes, well, it is sort of strange. But some times, it takes more than a week for the Github master branch of MicrosoftDocs/windows-itpro-docs to migrate to the docs.microsoft.com pages.


[CMake] Add missing Python packages to build scripts

Fixes Windows PIP tests after #6137.

@tensorflow-jenkins test this please.

The only failures are in non-CMake code, so this should be good to fix the Windows build now.


[Platform]: New Table Component

[Platform]: New Table Component
Description
New table component created using tanstack to reduce the dependency on mui table.
Issue: # Issue-2887
Deploy preview: in-progress
Type of change
Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Test A - Known Drugs Table on disease page.
Test B - Additional Known Drugs Table on disease page added to compare and find improvements.

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

Add naLabel as default value if null is passed to cell value

Opening Another PR with Updated main


Required package php-http/message-factory is abandoned

Problem Statement
The latest version of sentry/sentry (3.19.1) is using the abandoned package php-http/message-factory (^1.1).
As said in https://github.com/php-http/message-factory: This package will remain available for the time being to not break legacy code, but we encourage everybody to move to PSR-17.
Solution Brainstorm
Upgrade to PSR-17.

Duplicate of #1541 (will be fixed at a later date).


Hide Coveralls badge from README temporarily

Coveralls doesn't show the correct coverage for now.
So let's hide its badge temporarily.
ref: https://github.com/mongomapper/mongomapper/issues/702

Coverage remained the same at 0.0% when pulling e789887a7aff81d409bfb46dcfd02bebf954197f on hide-coveralls-badge into a7f9b190a6da48c0d44d9dee4ee952487359235f on master.

I will disable it at https://github.com/mongomapper/mongomapper/pull/704.


relative_eq() has incorrect behavior for small values

Consider this small example:
let diff: f32 = 1.0e-7;
let x: f32 = 1.0e-5;
let y = x - diff;
assert_ne!(x, y);
relative_eq!(x, y) // returns true, but should be false

Note that x and y are normal, full-precision floating-point values (not "subnormals"), above the epsilon threshold, and their relative error is (x - y)/x, which equals 0.01, far above the default threshold. However, they are marked as "relatively equal" in the current implementation.
The problem is in the logic of the provided implementation of RelativeEq::relative_eq() for f32 and f64, namely these lines:
https://github.com/brendanzab/approx/blob/308176d3d882c75dd9b57d9a7711e879a76119a8/src/relative_eq.rs#L65-L70
While the precise definition of relative equality and the parameters epsilon and max_relative are never clearly specified in the documentation, based on the referenced blog posts, it seems that the intention is to use epsilon as a zero-closeness threshold, and max_relative as the relative error threshold.
The issue stems from not checking the two input numbers (self and other in this case) individually against epsilon for a zero-threshold, but instead testing their absolute difference against epsilon. As a result, relative equality works as expected for large numbers, but in practice defaults to absolute-difference equality for values less than 1.

Rust follow IEEE 754 all is specified here.

@dsroche does the code below illustrate your point? I'm not that familiar with relative floating point comparisons:
fn relative_eq(lhs: f32, rhs: f32, epsilon: f32, max_relative: f32) -> bool {
    // Handle same infinities
    if lhs == rhs {
        return true;
    }

    // Handle remaining infinities
    if f32::is_infinite(lhs) || f32::is_infinite(rhs) {
        return false;
    }

    let abs_diff = f32::abs(lhs - rhs);

    // For when the numbers are really close together
    if abs_diff <= epsilon {
        return true;
    }

    let abs_lhs = f32::abs(lhs);
    let abs_rhs = f32::abs(rhs);

    let largest = if abs_rhs > abs_lhs { abs_rhs } else { abs_lhs };

    println!("This part is never reached");
    // Use a relative difference comparison
    abs_diff <= largest * max_relative
}

fn main() {
    let diff = 1.0e-7;
    let x: f32 = 1.0e-5;
    let y: f32 = x - diff;

    println!(
        "relative_eq!(x, y) = {}",
        relative_eq(x, y, f32::EPSILON, f32::EPSILON) // true
    );

    println!(
        "abs_diff <= largest * max_relative = {}",
        (x - y).abs() <= 1.0e-5 * f32::EPSILON, // false
    );
}

So one has to pass their own epsilon in order for it to work for small values? E.g:
relative_eq!(x, y, epsilon = 1.0e-8f32)

Oooh thanks for the report! I may have got something wrong in the implementation - it's been a long time since I looked inside. And to be honest floating point numerics are not something I'm an expert on. I'd be interested if we can find a fix for this though!


Move explorers into their own channel

Problem
The garden channel is polluted with tiny tables from the food explorer.
Suggested solution
Move the food explorer from garden/explorers/2021/food_explorer to explorers/owid/2021/food_explorer.
It would need to be done in three steps:

Copy the explorer to the new location, and publish it
Migrate the production config to point to the new location
Delete the old location

@pabloarosado Perhaps you're already doing something like this in your FAO work?

Hi @larsyencken. I added the new explorer to the new channel outside garden, but have not moved the old explorer yet. That could be a different PR. Do you want me to do it?
By the way, I called the new channel explorer. Should I rename it to explorers? I don't mind either name.

Ah, good stuff! Then we can pick up this issue after the add-new-faostat-steps branch gets merged.
I have a soft preference for explorers over explorer, but I'm easy.

I have changed explorer to explorers on this branch.

Hi @larsyencken. The new food explorer is now in master, and I have moved the old food explorer to the new explorers channel. So in principle I think this issue can be closed, but I'm not sure if there is anything else to be changed.

I'm a little confused as to the current status. Is your new data that's been merged in actually being used in the current global food explorer, or is prod still using the old data?

Hi @larsyencken the global food explorer in production is using the new data.

Ah, cheers, I see it. Closing now.


NEXT-00000 - Fix bc checker on gh

WIP test

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix: reinitialize session on wix client id change

Porting https://github.com/codux-templates/e-commerce-remix/pull/56 over to this repo. I have no idea what I'm doing.

Porting codux-templates/e-commerce-remix#56 over to this repo. I have no idea what I'm doing.

:)


HBASE-23228 Allow for jdk8 specific modules on branch-1 in precommit/nightly testing

Testing locally with this version of our yetus personality and #251 for HBASE-22114

using jdk7 properly ignores the added module
using jdk8 properly shows the issues present in it according to precommit.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
shelldocs
0m  0s
Shelldocs was not available.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

:blue_heart:
mvndep
0m 36s
Maven dependency ordering for branch

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 10s
Maven dependency ordering for patch

:broken_heart:
shellcheck
0m  4s
The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

:blue_heart:
asflicense
0m  0s
ASF License check generated no output?

2m 22s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-804/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/804

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 1e5c4c6ee979 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-804/out/precommit/personality/provided.sh

git revision
master / f58bd4a7ac

shellcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-804/1/artifact/out/diff-patch-shellcheck.txt

Max. process+thread count
52 (vs. ulimit of 10000)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-804/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
shelldocs
0m  0s
Shelldocs was not available.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

:blue_heart:
mvndep
0m 36s
Maven dependency ordering for branch

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 10s
Maven dependency ordering for patch

:green_heart:
shellcheck
0m  3s
There were no new shellcheck issues.

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

:blue_heart:
asflicense
0m  0s
ASF License check generated no output?

2m 22s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-804/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/804

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 0035c420801e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-804/out/precommit/personality/provided.sh

git revision
master / c2e01f2398

Max. process+thread count
52 (vs. ulimit of 10000)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-804/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

thanks for the review!


Error while installing private ACS

$ sudo -E az component update --additional-component acs --private
Command "/usr/local/az/bin/python -u -c "import setuptools, tokenize;__file__='/private/var/folders/h3/l1_qqcnn7cn1g8_zrqtzjh540000gn/T/pip-build-AQODEZ/azure-cli/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" --no-user-cfg install --record /var/folders/h3/l1_qqcnn7cn1g8_zrqtzjh540000gn/T/pip-bt7Awg-record/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/az/bin/../include/site/python2.7/azure-cli" failed with error code 1 in /private/var/folders/h3/l1_qqcnn7cn1g8_zrqtzjh540000gn/T/pip-build-AQODEZ/azure-cli/

This was due to user permissions with the use of sudo.
The resolution is to use sudo -EH az component update --additional-component acs --private.
The linked PR adds the text "If executing az with sudo, you may want sudo's -E and -H flags." to the error message.


Migrate from F's to dOrg's Heroku

there's a tier limitation resulting in this.
Upgrade your dynos to a paid plan as soon as possible
Starting November 28th, 2022, free dynos will no longer be available. To ensure your app continues to run, subscribe to Eco or upgrade to another paid plan

We can just migrate it and charge it to the rest of our stuff on Heroku.


Update node-gyp to 3.0

And use that to install headers as well.

This should solve problems when trying to build for node 4.0.0

:+1:

It's no bug anymore since https://github.com/mafintosh/node-gyp-install/commit/f954f056a44829f08fb27e6b95a7ef098c5d4066 was fixed
I'll test around a bit with the new node-gyp to see if it works well.


commands: check createrecovery timelock parameter corresponds to recovery path

If passing a timelock value to the createrecovery command, we should check if the value corresponds to one of the wallet's recovery paths.

What's the issue with the current behaviour?

Perhaps it's not a problem as such, but it's currently possible to pass 0, for example, as the timelock value and get a transaction spending all confirmed coins. Without any check, there's more chance to make a mistake with the value passed in and select more coins than expected.


Integrating rekey buttons

this has enough code in it for us to discuss

:mag_right: The commits 5bbc57d4d82d...a7cae6914b96 introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

@keybase/react-hackers

actually lets wait. with @maxtaco 's new code i think this code can be greatly simplified as this'll all come in the getFavorites call

:mag_right: The commits 96ba26e2b580...a094bbd4af2e introduced some visual changes on win32:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits a864581127a5...83bf86acb8d3 introduced some visual changes on win32:

Changed: user_search-Normal (before) (after)

Changed: unlock_folders-No_paperkeys (before) (after)

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

[ ] plumb paperkey error through

:mag_right: The commits a864581127a5...5378f9fd9daa introduced some visual changes on win32:

Changed: unlock_folders-No_paperkeys (before) (after)

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits a864581127a5...5378f9fd9daa introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits a864581127a5...03fb11b155df introduced some visual changes on win32:

Changed: unlock_folders-Single (before) (after)

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits a864581127a5...03fb11b155df introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits a864581127a5...067394fcd74c introduced some visual changes on win32:

Changed: Search_User_Pane-Unfollowed (before) (after)

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits a864581127a5...340a8b489a8b introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits a864581127a5...340a8b489a8b introduced some visual changes on win32:

Changed: user_search-Normal (before) (after)

Changed: unlock_folders-Normal (before) (after)

Changed: Search_Non_User_Pane-Out_of_invites (before) (after)

Changed: Search_Non_User_Pane-No_Avatar (before) (after)

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits a864581127a5...067394fcd74c introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits a864581127a5...f035b6e1c739 introduced some visual changes on win32:

Changed: unlock_folders-Single (before) (after)

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits a864581127a5...f035b6e1c739 introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

[ ] rekey click on widget does nothing. maybe open mainwindow into files view or rekey popup if core supports it

[ ] clicking x on rekey popup needs to use the refresh session id

:mag_right: The commits f0caa342d2e6...6dea39763e22 introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits f0caa342d2e6...2ea29e3780f2 introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits f0caa342d2e6...879ceb0a9add introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits f0caa342d2e6...40294e236caf introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits f0caa342d2e6...d2ba8e5ab6cf introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits 894a9c70ff29...afebb9ed770e introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

@keybase/react-hackers to test participant rekey flow:
Do the above, but make a share with someone else.
Provision a new device that needs to rekey (same as above)
Then revoke all other devices / paperkey
Note: There is a known bug where the api server will suggest the revoked devices as solutions (but will correctly send you to the participant screen)

:mag_right: The commits 894a9c70ff29...a633edaf7ebb introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

🚀 :shipit: % nits

:mag_right: The commits 6068804a34ee...337543efa99d introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits 28e46c4de036...fd30514c3003 introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)

:mag_right: The commits 28e46c4de036...30a83589588b introduced some visual changes on linux:

Changed: Files-You_can_unlock_Public (before) (after)

Changed: Files-You_can_unlock_Private (before) (after)


Update membership from Ananya to Dan

Update membership from Ananya to Dan
Signed-off-by: Ananya Garg<EMAIL_ADDRESS>

lgtm, thanks @angarg05!
As @vbatts approved the PR, I'm going ahead nd merging it!


Parsing a stored selector fails if the selector is using commas

I'm unsure of the root case, but parsing this selector:
repository.properties['github/primary_language'] in ['TypeScript', 'Go']

from the database fails. We do have a hand-rolled Scan method that converts a JOIN with an ARRAY into a Go type which breaks.

CC @danbarr who reported the issue.
Marking as P0 because after such selector has been added minder just throws errors attempting to manipulate that profile.


Support for vertical divider?

is it planned to enable also comparing the images vertically?

I'd accept a PR for this

I could take a stab at it. Could you give me some guidance, of where to
start and how to approach it?
On Sun, Feb 25, 2018, 6:57 PM Jacob Parker<EMAIL_ADDRESS>wrote:

I'd accept a PR for this
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jacobp100/react-twentytwenty/issues/8#issuecomment-368329767,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEIcKoj7Noots069ItIULyvwoETtHi3Rks5tYZ76gaJpZM4SSXwE
.

It's pretty much just changing whether we use left or right in the positions of the elements to top or bottom. You'll then need to make the touch and mouse events handle vertical directions.
Let me know if any parts don't make sense


Manually override 'optional' schema parameter from afFieldInput inclusion

I would like to be able to manually override a field's optional parameter on the simple-schema definition from the field afFieldInput inclusion, like so:
schema:
email: {
  type: String,
  optional: true,
  autoform: {
    afFieldInput: {
       type: "email"
    }
  }
},

Field definition:
{{> afFieldInput name="email" optional=false}}

I would like to create a single schema that multiple autforms use; however, not every autoform uses every field. The only way to accomplish this is to make every field defined in the schema as optional:true, but be able to override it from the front end based on a parameter passed.
I'm building a large application with many forms and fields and this approach of having a single schema definition for all the forms will allow me to reuse as many fields as possible without duplication for the forms that use the same fields (e.g., email).

+1

+1

Interesant, I would like if you have been able you to get results with this idea, because I start working with  software product lines on meteor js and it is a case of variability implementation.
Thank in advance


line_ending does not work for me

My source CSV file:

010200;Galaxy M40;0;984;Phones;Samsung;984[nl]010201;Galaxy A50;0;5750;Phones;Samsung;5750[nl]010202;Galaxy M30;0;1834;Phones;Samsung;1834[nl]010203;Galaxy M20;1;760;Phones;Samsung;760[nl]010204;Galaxy A70;0;720;Phones;Samsung;720[nl]010205;Galaxy A30;0;160;Phones;Samsung;160[nl]

end line is '[nl]' and separator is ';'
my Import class:
class SyncProducts implements OnEachRow, WithProgressBar, WithCustomCsvSettings
{
    use Importable;

    /**
     * @param Row $row
     */
    public function onRow(Row $row)
    {
        $rowIndex = $row->getIndex();
        $row = $row->toArray();

        error_log("\n");
        print_r($row);

    }

    public function getCsvSettings(): array
    {
        return [
            'delimiter' => ';',
            'line_ending' => '[nl]',
        ];
    }
}

and my command:
public function handle()
    {
        $this->info('Syncing Products ...');

        (new SyncProducts)->withOutput($this->output)->import(public_path('sync_data/file.csv'), null, \Maatwebsite\Excel\Excel::CSV);

        $this->output->success('Done');
    }

The problem is that result is separated only by delimiters ';'

Array
(
[0] => 010200
[1] => Galaxy M40
[2] => 0
[3] => 984
[4] => Phones
[5] => Samsung
[6] => 984[nl]010201
[7] => Galaxy A50
[8] => 0
[9] => 5750
[10] => Phones
[11] => Samsung
[12] => 5750[nl]010202
...

As you can see line_ending is not working.
What am I doing wrong?

Please create a new ticket with the issue template filled. The issue template is required for us to be able to help you and is automatically available for you when opening a new issue, please do not remove the contents of the issue template.


Deployment Documentation

Hi,
Is there any documentation on how to use this implementation? From the k8s manifests I was able to deduce the below, please correct me wherever needed:
1.) This is a kind of simulation whereby real HW is not needed (this will be for testing purposes).
2.) UE-OAI -- This is a simulated lte device (my assumption also), I could not find information about how to configure the msisdn, imsi, eNodeB information. Can it be run with more than 1 replica (separate deployment)?
I saw a Cassandra configmap file that has some UE information which I believe is what the HSS will use.
3.) Any other reason apart from small image size for using UBI images (this requires getting a redhat system just for the purpose of building the images) or are there pre-built images that can be used?

Hi infinitydon,
Thank you for your interest and sorry for the slow response. We're currently laser-focussing on prepping for a first demo, so while the documentation in the main README.md is still valid, documentation on the configuration (which are a moving target still) is certainly lacking. We'll get back to this after next week (post-demo).

1.) This is a kind of simulation whereby real HW is not needed (this will be for testing purposes).
Right now we're prioritizing using real HW (USRPs). Yes, the oai-ue is for simulated UEs, but didn't receive much attention yet.

2.) UE-OAI -- This is a simulated lte device (my assumption also), I could not find information about how to configure the msisdn, imsi, eNodeB information. Can it be run with more than 1 replica (separate deployment)?
For that info, please see the OAI wiki. For the container images, we're simply embedding templated OAI configuration files, such that the templated parameters can be passed in as environment variables populated from ConfigMaps.
I saw a Cassandra configmap file that has some UE information which I believe is what the HSS will use.
Correct. Currently, you basically need to add/modify the CQL query to populate the user table in Cassandra directly. This is poor UX and will be replaced.

3.) Any other reason apart from small image size for using UBI images (this requires getting a redhat system just for the purpose of building the images) or are there pre-built images that can be used?
It's not really about small image size but that OAI makes use of many kernel and low-level features. This means it's important that the user space contained in the base images matches the kernel space of the host OS. RHEL-rt/CentOS-rt are the default host OS, as they give much better realtime performance (tighter latency bounds) for the radios than alternatives. Also, the quality of the UBI content plus extra packages is generally higher.
Builds currently only require a RHEL system because we pull additional RPMs from Red Hat CDN (CentOS packages weren't available when the effort originally started). We'll add the option to build using CentOS content instead to this repo eventually and will also look into providing pre-built images for convenience.

Much thanks for the response.. will be on the lookout for further updates.


error unsupported network

error unsupported network while on rinkeby test network, what to do?

Make sure you have this config and not the one by default

Make sure you have this config and not the one by default

I'm also stuck on the minting dapp myself! I checked on this config and it is set to the following:
testnet: Networks.hardhatLocal,
This is correct, right? But still, the minting page gives me an the "Error unsupported network" message. Strange thing is that I am still able to connect my wallet, but the error message stays up and I don't see neither my wallet address being displayed, nor the minting interface appear to start minting NFTs. Is there something eaxycoderr and I are missing? Would greatly appreciate the help!

This is because there are multiple network settings. As of this date there are two networks for the minting dapp.
One is Mainnet and other is testnet. In testnet there are further two networks Goerli and Rinkeby if you are on rinkeby test network on metamask then you need to change some settings because by default it is set to Goerli test network.
You can check all networks under smart-contract < libs < Networks.ts.

Rinkeby test network is named as ethereumLegacyTestnet and if you go to file under smart-contract < config < CollectionConfig.ts you'll find that it is set to ethereumTestnet by default.

Just change it to ethereumLegacyTestnet and you are good to go.

If you are on Goerli test network then you have no problem.


Uncaught TypeError: Cannot read property 'href' of null

Sometimes i get this error : barba.js:1245 Uncaught TypeError: Cannot read property 'href' of null
at line 1245 of barba.js
It's triggered every time i click on the screen, not on a link.

ok found the error, i was returning true to preventCheck function by returning nothing the error is gone.

it seems to emit this error if you click directly on the body tag.


akuvox_door_update event not firing

System Health details
System Information

version
core-2024.4.3

installation_type
Home Assistant Container

dev
false

hassio
false

docker
true

user
root

virtualenv
false

python_version
3.12.2

os_name
Linux

os_version
6.6.20+rpt-rpi-2712

arch
aarch64

timezone
America/Los_Angeles

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

GitHub API Calls Remaining
4996

Installed Version
1.34.0

Stage
running

Available Repositories
1399

Downloaded Repositories
1

HACS Data
ok

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Dashboards

dashboards
2

resources
0

views
0

mode
storage

Recorder

oldest_recorder_run
April 22, 2024 at 6:54 PM

current_recorder_run
April 26, 2024 at 12:13 AM

estimated_db_size
1.37 MiB

database_engine
sqlite

database_version
3.44.2

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
akuvox_door_update event does not seem to be fired when my door bell is rang. I am able to use the relays to unlock the door and access the camera just fine from HA, but ringing the door bell does not fire the akuvox_door_update event, and as a result I cannot build any automations around it.
Occurs on both v0.0.7 and https://github.com/nimroddolev/akuvox/commit/7c33d71fe86d89e8f60292e6540ed20c00c3799f.  I am in US region, if that helps.
Reproduction steps

Setup automations which use akuvox_door_update (without any event_data) and/or use /developer-tools/event page to listen for akuvox_door_update.
Ring the door bell.
Event is not fired.

Debug logs
2024-04-26 00:13:06.382 WARNING (SyncWorker_2) [homeassistant.loader] We found a custom integration akuvox which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-04-26 00:13:06.383 WARNING (SyncWorker_2) [homeassistant.loader] We found a custom integration hacs which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-04-26 00:13:07.466 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'hacs' accesses hass.components.frontend. This is deprecated and will stop working in Home Assistant 2024.9, it should be updated to import functions used from frontend directly at custom_components/hacs/frontend.py, line 68: hass.components.frontend.async_register_built_in_panel(, please create a bug report at https://github.com/hacs/integration/issues
2024-04-26 00:14:13.622 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'akuvox' calls `async_run_job`, which is deprecated and will be removed in Home Assistant 2025.4; Please review https://developers.home-assistant.io/blog/2024/03/13/deprecate_add_run_job for replacement options at custom_components/akuvox/api.py, line 81: hass.async_run_job(self.async_set_stored_data_for_key, "wait_for_image_url", self.wait_for_image_url), please create a bug report at https://github.com/nimroddolev/akuvox/issues
2024-04-26 00:14:25.487 WARNING (MainThread) [py.warnings] /usr/local/lib/python3.12/asyncio/base_events.py:1973: RuntimeWarning: coroutine 'AkuvoxData.async_set_stored_data_for_key' was never awaited
handle = self._ready.popleft()
2024-04-26 00:14:29.803 WARNING (MainThread) [custom_components.akuvox] 📜 Regional API subdomain not configured...using pre v0.0.7 backward compatible 'ecloud'
2024-04-26 00:17:36.622 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:17:40.395 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:17:44.022 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:17:47.701 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:22:33.525 ERROR (stream_worker) [homeassistant.components.stream.stream.camera.front_gate] Error from stream worker: Stream ended; no additional packets
2024-04-26 00:22:33.957 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:22:37.661 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:22:41.408 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:22:45.051 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:22:48.944 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:22:52.848 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:22:56.489 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"
2024-04-26 00:23:00.225 DEBUG (MainThread) [custom_components.akuvox] Changing app type "single" <--> "community"

### Diagnostics dump

_No response_

Hi @romilbhardwaj, sorry you've had this issue.
I just released a new beta release, v0.2.0-beta2, which includes many fixes including the personal door log polling (which is responsible for firing the akuvox_door_update event).
Can you please upgrade to the beta and let me know if the issue is resolved for you?
To install the new beta version:

Open the Akuvox SmartPlus repository in HACS
Click on the ⋮ button in the top right
Select the ↻ Redownload option
Enable the Show beta versions option (it may take a moment to update the list)
Select version v0.2.0-beta2 from the updated version drop-down list
Restart Home Assistant

Awesome, thanks @nimroddolev! Appreciate the fix - will try it soon and report back.

Hi @nimroddolev
Same issue occurs in v0.2.0-beta3
I think you need polling the call log
"log/getCallLog?row=1"


Fix LoginRecoveryAuthnCodeConfig recovery codes confirm checkbox behavior

This pull request fixes the behavior of the recovery codes confirm checkbox in the LoginRecoveryAuthnCodeConfig component. Previously, the checkbox was not functioning correctly, but now it correctly enables and disables the "Save" button based on its checked state.

Hello @thib-rdr,
Thank you very much for diagnosing the problem.
I can't merge this as is as it would be a breaking change. All the required changes must be done in the useScript hook implementation, since the hook is internalized we can freely modify it.

Anyway I opend to implement a more minimal fix to keep the diff minimal: https://github.com/keycloakify/keycloakify/commit/994f1f8d3d00669cb7f564d81e0913f5d32551f1
Thank you for your contribution!

Hi, thanks for your feedback,
If I may, I was wondering if you could consider implementing this change as well : https://github.com/keycloakify/keycloakify/pull/714/files#diff-23fcec1951286d0fe20580506afdd31e66c0782de0923521d70eb6c26b32b4ccR50
As otherwise, the <p> tag containing a <div> displays an error in the console when the page opens at the moment.


PhotoView's ScaleType is forgotten about when removed and reattaching to window

I have a setup that has multiple PhotoView's which may get removed and reattached to the window more than just 1 time.
In PhotoView#onDetachedFromWindow the current attacher is cleaned up and it's scale type is thrown away. So when you reattach the PhotoView, the default attacher value of FIT_CENTER is used.
I don't believe that this would be the intended behaviour and the fix is fairly trivial. Just setting the view's pending scale type before cleaning up the attacher:
    @Override
    protected void onDetachedFromWindow() {
++      mPendingScaleType = mAttacher.getScaleType();
        mAttacher.cleanup();
        mAttacher = null;
        super.onDetachedFromWindow();
    }

Closing as I now realise the current develop branch will not have this issue as the attacher is long lived


Update functions-bindings-cosmosdb-v2-input.md

Removed references to documents variable in "Queue trigger..."/python-v2 (variable not defined in function inputs or decorator args).
Trying to implement existing test_function results in 404

@ggailey777
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


No Set Default time option available

Need to have a set default time option, so that this will enhance the functionality.

you can already do that. If you don't know how, please ask a question on StackOverflow


replaces relative imports with absolute

closes #46
@oke-aditya can you verify if this branch now works with docker?

Codecov Report

Merging #109 into master will decrease coverage by 0.05%.
The diff coverage is 86.48%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   49.75%   49.69%   -0.06%
==========================================
  Files          59       59
  Lines        1829     1827       -2
==========================================
- Hits          910      908       -2
  Misses        919      919

Flag
Coverage Δ

#unittests
49.69% <86.48%> (-0.06%)
:arrow_down:

Impacted Files
Coverage Δ

mantisshrimp/all.py
0.00% <0.00%> (ø)

mantisshrimp/hub/detr/__init__.py
0.00% <0.00%> (ø)

mantisshrimp/hub/pennfundan/__init__.py
0.00% <0.00%> (ø)

...ntisshrimp/models/mantis_rcnn/rcnn_param_groups.py
93.33% <ø> (-0.42%)
:arrow_down:

mantisshrimp/backbones/__init__.py
100.00% <100.00%> (ø)

mantisshrimp/core/bbox.py
67.27% <100.00%> (ø)

mantisshrimp/core/category.py
85.71% <100.00%> (ø)

mantisshrimp/core/id_map.py
38.46% <100.00%> (ø)

mantisshrimp/core/mask.py
82.60% <100.00%> (ø)

mantisshrimp/data/__init__.py
100.00% <100.00%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b360f4...892a2d4. Read the comment docs.

I checked by building a docker image and running it. It works fine.


instead of specifying objectName's in SecretproviderClass it would be great to read all secrets in key-vault and mount in the pod

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Secrets Store CSI Driver version: (use the image tag):
Azure Key Vault provider version: (use the image tag):
Kubernetes version: (use kubectl version):
Cluster type: (e.g. AKS, aks-engine, etc):

Is there any solution already in place? If yes can you provide the relevant pods or steps to achieve this?
Thanks

@aramase any solution present already for this?

@skri547 No, that's not possible. The objects and versions (latest if not set) defined in the SecretProviderClass are the only ones fetched from keyvault.


Change YAML labels to 'publishLocation' and 'server'

The Publish Build Artifacts task has an input that doesn't make sense when seen in YAML:
- task: PublishBuildArtifacts@1
  inputs:
    ArtifactType:  Container

ArtifactType doesn't describe the meaning of the input, so this PR renames it to publishLocation.
Container doesn't describe the location where the artifacts will be copied, so this PR renames it to server.

Major rev is work for customers. Now every designer definition has a red flag to manually update to the new version, which provides them zero additional value.

The value is provided in the YAML scenario.  In my opinion, trying to figure out that ArtifactType:  Container really means PublishLocation: Server is harder than quickly selecting from a drop-down in the UI.  Today's labels make no sense in YAML.

We can’t major rev this.  That’s a big deal for us and customers.
You can add a yaml input alias ( thus exact scenario was why we added the feature ) and change the UI label without rev’ing.

I gently beg to differ :) but I didn't think aliases were supported on dropdown options.  That would be a great way to make this understandable.  Is that/could that be supported?

I was referring to the input name
You’re making this change to make it easier for customers.  But a major version needs to start in preview for a sprint or two.  Users must then elect to jump to get the benefit.  All users will be presented with the flag and decision.  You have to provide a reason / benefit displayed on why the user should jump.  What will that say?  Then after all that, when they decide to jump the input will lose it’s value and then be presented with two new values which aren’t the two values they’ve been seeing for years.
Use yaml aliases to change the input and label.  Leave values alone.  Reserve major channels for big rewrites and new approaches.

We don't support YAML aliases for input options (dropdown values), do we?
We should base the value of a major version change on more than what's apparent in the UI.  We often bump the major version only for changes that users don't see in the UI.
In this case, when a user voluntarily adopts the new version, they'll have to select in the "Publish Location" dropdown from the same two values that were there before:

TFS/Visual Studio Team Services
File share

That seems like a pretty minor thing to select the same value they had before.  It seems that's totally acceptable for voluntary adoption of a new major version.
Without this, on the YAML side, we have a really bad user experience.  This YAML makes no sense and even confuses things with Docker containers:
ArtifactType: container
No one will understand this really means that "the artifact publish location should be TFS/VSTS".  Users:  Hmmm?  my artifact type is not a container, so what's this even talking about? :-/

I agree with @bryanmacfarlane on this - we should not break major version compat for this change.


Update aws-java-sdk-bundle to 1.12.269

Updates com.amazonaws:aws-java-sdk-bundle from 1.12.260 to 1.12.269.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #2271.


Enable caching on intermediate realtime persists

The spills are not consistent across nodes so this would only work if the cache is local. That should probably be called out or enforced or something.

@xvrl is it possible to get real world performance numbers?

@gianm addressed comments, will look into getting some real-work numbers.

@gianm roughly 20% speedup on a typical top-n query 10-15min into the hour of a 1-hour realtime index task, with 10 persists completed (~ 1.4M rows to scan)
Unit: milliseconds
           expr      min       lq     mean   median       uq      max neval
  cache("true") 226.2689 269.5347 290.6316 279.4486 302.8039 542.1334   100
 cache("false") 285.9610 343.3580 395.8290 396.8076 419.2823 708.2887   100

:+1: since old behavior is preserved by default and this gets into action only if user explicitly provides the configuration.
not sure if documentation update is left out intentionally , if not then pls update same.

@himanshug yes, will add docs, was waiting for comments before doing so


How to run the server 25mb +?

how?

This also reduce lag ?

@NameYT Depends on what you plan on using the extra memory for.
node --max-old-space-size=val index.js
So if I wanted to increase the memory my server ran on to 6gb i would do:
node --max-old-space-size=6144 index.js (memory is in mb)
or you could do:
node --stack-size=val (memory is in kb)


Suggest "pipenv install" to install dependencies

pipenv run requires dependencies to be installed.

Thank you!

(JFYI I've just fixed some more bugs, so if you want to use this you should probably pull again)

Great, thank you!
And thanks for that very useful project to start with!


Architecture Request: UI Modification Callback for Buggy Functions

It would be useful for people creating questions to be able to cause UI changes in response to buggy functions. Minimum, we should be able to "call out" the different sections, like the instruction box.
I suggest creating a new service that can be passed into a callback defined in a question that allows users to start and stop callout animations and do other things, like spawn popups.

Per discussion with @BenjaminHolland, I'm going to close this. We talked about first filing an issue to demonstrate the desired change in the experience for users, and then based on the different behaviours we decide we want to support, we can figure out a callback API if needed. In the meantime, let's keep the interface as small as possible so that it's easy to maintain.


Config/default insight timeouts

adds logs
modify insight timeout defaults.

Coverage increased (+0.03%) to 82.398% when pulling 039ef2363135d1c9c6f9fe1e7635240db8aeb83d on matiu:config/default-insight-timeouts into 9f27a33f0ecf06c68b3792caa3ff7abe84eea199 on bitpay:master.


Integration with nginx/docker setup

Will this integrate well with the automated jwilder/nginx-proxy?

I can't think of any reason why it should not work. But I will give it a try during the christmas holidays to find out :+1:

Any luck?

I did go through the documentation and it should be possible to add a Per-VIRTUAL_HOST configuration redirecting the authentication requests from letsencrypt
location /.well-known/acme-challenge {         root /tmp/letsencrypt/www; }
I use a different/simpler/less capable approach for configuring my reverse proxy by using http://nginx.org/en/docs/http/ngx_http_map_module.html to proxy requests to the correct docker container without duplicating the configuration.
I am certain it will also work with jwilder/nginx-proxy

I really like your approach and I've given this some thought. The biggest problem I see is how to execute the letsencrypt container.

You need to know the IP addresses / hostname in advance for the route to work. Using Docker Network in 1.9 or Weave might help but it's a dependency.
It needs to share the same directory, mounting both to a common directory would work.

One integration is to use nginx proxy as a base image and extend it with letsencrypt and a custom tmpl. It's the approach taken by https://github.com/dmp1ce/nginx-proxy-letsencrypt but it's still not ideal IMHO, I couldn't get it to work and hit the rate limit trying.

You can always use the staging server without the the rate limit for development/testing using
--server https://acme-staging.api.letsencrypt.org/directory
I am not yet sure if I really like the shared volume approach. Therefore I fixed the previous attempt using the standalone client and reverse proxy forwarding the request to the le docker container by adding the missing parameter --standalone-supported-challenges http-01 to define http to be used for making the authentication request
I think most people will have a custom proxy/nginx configuration anyways so adding letsencrypt should interfere as little as possible with the existing configuration.

@BenHall - I ran into some issues with dmp1ce/nginx-proxy-letsencrypt as well, but have since got it working correctly (see #25).
I like the @mbrugger approach too, but don't know enough to implement it myself. If there is substantial reason to use it over the shared volume approach I may look into switching.
I looked at kid-nginx-letsencrypt-proxy as well, but also had issues.


Can't see collections except site.posts

I have another folder by the name of site.extras whose feed is not shown by feed.xml. How do I make this work?

Duplicate of #124

@pathawks Its not a duplicate.  I don't want separate feeds for them, it would work even if they are in one file. I had already seen that issue before opening this one.

I guess the bottom line is that, right now, the plugin only supports posts. We do not support other collections, in the same feed or in a different feed.

Oh right, are you guys planning on working on this? I think this is a major feature requirement

I would be happy to review a pull request:+1:


Can't install with PHP7.2

I believe the issue with with the mdanter/ecc dependency, which has a <= 7.1 requirement (which I think is because of mcrypt).

Tests are passing on PHP7.2. This likely comes from a problem of environment configuration.


Update SSM Patch Baseline OS validator

According to the CloudFormation documentation, a few more values are supported now for OperatingSystem.
Source

Thank you for this PR. Could I bother you to alphabetize the operating system names (yes, I know the current list isn't) and resubmit? That will make it easier to compare and update against the list in the documentation.

Thank you for this PR. Could I bother you to alphabetize the operating system names (yes, I know the current list isn't) and resubmit? That will make it easier to compare and update against the list in the documentation.

@markpeek Thank you for your feedback, I pushed an update.

Thank you for the PR and for making the additional change.


Getting error for Stacked Bar chart:  attribute y: Expected length, "NaN".

Expected Behavior
Either error should be removed from the browser console or pass default 0 to the rectangle generated using d3 code
Current Behavior
Getting too many errors in the browser console
Possible Solution
This might be helpful :)
https://stackoverflow.com/questions/40746319/error-rect-attribute-width-expected-length-nan-and-text-attribute-dx
Steps to Reproduce (for bugs)
A height of generated SVG is 310
A width of generated SVG is 800
Screenshots (if appropriate):

Context

Getting too many errors in the browser console results in a bad impact on web page
Your Environment

Britechart Version used: 2.9.0
Browser Name and version: Chrome
Operating System and version: Mac OS X

Hi @sagardalvi, thanks for creating this issue!
Could you create a codepen with the context of this bug? You could use this one https://codepen.io/Britecharts/pen/QqaogP as a starting point.
This way we will be able to help you better, thanks!!

Here is the example link
https://codepen.io/sagardalvi/pen/bjEZpK
The primary observation regarding the issue is
dataset created is as below
[
{name: "A", value: 0.12, stack:"stack1"},
{name: "A", value: 0.32, stack:"stack2"},
{name: "B", value: 0.22, stack:"stack2"},
{name: "C", value: 0.45,stack:"stack1"},
{name: "D", value: 0.55,stack:"stack2"},
]
For name A we have 2 stacks [stack1 & stack2] But for B, C, D we have given only one stack (either stack1 or stack2) so while rendering it is giving errors on the browser console as shown in below screenshot.

Submitted fix, hope it resolves your issues. It will be available next release.

@dalerasrorov-eb Thank you for your support.


Removed MAX_DIST2 which is incompatible with INFLATE_STRICT.

This PR removes MAX_DIST2 in favor of MAX_DIST(s) which makes the output produced by deflate medium compatible when zlib is compiled with INFLATE_STRICT (see #492). It also fixes the check for proper bounds in zng_tr_tally as mentioned in #490 (so debug CI finally succeeds).
Once this is merged I can clean up or close the other 2 PRs.

Once this is merged I can clean up the other 2 PRs.

Surprisingly this seems to improve compression speed by ~0.1-0.2%.
I had expected it to become worse due to the extra indirect lookup (I suspect MAX_DIST2's purpose was to get rid of that), so I re-ran the before and after tests several times and with this it is always faster than even the best before run.

Oh, compressed size was the same in all my tests.

Thank you for merging in, now the CI tests can finally pass.


Each member should have a public profile page.

Each member's profile page should be a page that displays:

their avatar
when they joined
when last active
their "role" / "role title"
display an "about me" section where they talk about their experience, their company etc. (NO HTML, but would support Markdown)
Total number of discussions they've started
Total number of posts they've created (replies, not new discussions)
"Homepage" link
Facebook link
X link
Threads link
GitHub link

"Homepage" link
Facebook link
X link
Threads link
GitHub link

Is it a good practice to store this data with settings for per-user ? If not, any suggestions?

If it was going to be a smaller site I think the settings table would be fine. With up to 65,000 users currently on the site, I think moving it to a dedicated user_profile table would make sense.


acryl-datahub[mongodb] > Cannot map bson.decimal128.Decimal128 type

Describe the bug
acryl-datahub[mongodb]  is not able of mapping MongoDb the type bson.decimal128.Decimal128
In the ui, columns with that type are shown with type "unknown"
To Reproduce
Ingest a mongo collection that uses the type bson.decimal128.Decimal128
Expected behavior
instead of unknown, The type is shown in the UI.
Screenshots
N/A
Desktop (please complete the following information):

OS: N/A
Browser N/A
Version: <IP_ADDRESS>

Additional context
offended code: https://github.com/datahub-project/datahub/blob/master/metadata-ingestion/src/datahub/ingestion/source/mongodb.py#L115

I've added this type support in a recent PR, you should expect to see it working once the new CLI release come out

Fixed as part of https://github.com/datahub-project/datahub/pull/9118


AttributeError: 'BlobProto' object has no attribute 'array'

blobs[0] is a instance of BlobProto and it doesn’t have array field but data field. Therefore, I believe that you should use blobs[0].data instead of blobs[0].array in the following line.
https://github.com/chainer/chainercv/blob/713c380414e2469392ffe0039e457b3125ff60d7/examples/ssd/caffe2npz.py#L75

Hi. The master branch no longer works with Chainer v2.
Please use v3, or use the previous release for v2 (https://github.com/chainer/chainercv/tree/v0.7.0).


[WIP] Add MMS and Wav2Vec2 models (Closes #209)

TODO:

[x] Feature extraction w/ wav2vec2
[x] Automatic Speech Recognition w/ wav2vec2
[ ] Audio classification w/ wav2vec2
[ ] Feature extraction w/ MMS
[ ] Audio classification w/ MMS
[ ] Automatic Speech Recognition w/ MMS (python implementation)

https://huggingface.co/patrickvonplaten/mms-1b-fl102
https://huggingface.co/patrickvonplaten/mms-1b-l1107
https://huggingface.co/patrickvonplaten/mms-1b-all

[ ] Text-to-speech w/ MMS (python implementation still in progress)

From my understanding MMS is either based on or uses wav2vec2 behind the scenes, so there should be significant overlap here.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Cannot use cluster_version 1.20 with the eks module

Description
Cannot use cluster_version 1.20 with the eks module
Versions

Terraform: 1.0.4

Provider(s):

registry.terraform.io/hashicorp/aws v3.53.0
registry.terraform.io/hashicorp/cloudinit v2.2.0
registry.terraform.io/hashicorp/kubernetes v1.13.4
registry.terraform.io/hashicorp/local v2.1.0
registry.terraform.io/terraform-aws-modules/http v2.4.1

Module: 17.1.0

Reproduction

Steps to reproduce the behavior:

Creating a cluster with a cluster_version "1.20" returns an error that it is not able to find an ami image for those versions

Expected behavior

The cluster should be created normally
Actual behavior

Error: Your query returned no results. Please change your search criteria and try again.
with module.eks_cluster.data.aws_ami.eks_worker[0],
on .terraform/modules/eks_cluster/data.tf line 20, in data "aws_ami" "eks_worker":
20: data "aws_ami" "eks_worker"
Additional context

As a temporal fix forcing the ami name filter with worker_ami_name_filter = "amazon-eks-node-${var.cluster_version}*" instead of the default one "amazon-eks-node-${var.cluster_version}-v*" seems to work

We had the same issue because our cluster_version was set to integer, like cluster_version = 1.20. When it's converted to string in the search filter, the zero is dropped and it becomes just "v1.2".
Changing the line to cluster_version  = "1.20" resolved the problem.

It worked, thanks for your help


Upgrade React

Change deprecated createClass syntax to ES2015 class syntax.

Just started reviewing :) :octocat: Sent from GH.

Thank you, pull request merged! :octocat: Sent from GH.


Update documentation on usage with Nuke

Nice one - works for me.
The real question is "would this have helped you succeed"?

I think so! especially because the example now matches the usage in Octopus Server. And the step about adding the package with the nuke command.

Just a comment about

"Can be set via the environment variable OCTOVERSION_CurrentBranch.",

Whilst this is true for OctoVersion itself, if this is a documented Nuke build example wouldnt it be better to specify it using the nuke parameter that the comment is referring to.  in other words, this is a nuke parameter so it can be set by passing --BranchName to nuke, or by using the env variable that nuke would associate with that parameter?

Just a comment about

"Can be set via the environment variable OCTOVERSION_CurrentBranch.",

Whilst this is true for OctoVersion itself, if this is a documented Nuke build example wouldnt it be better to specify it using the nuke parameter that the comment is referring to. in other words, this is a nuke parameter so it can be set by passing --BranchName to nuke, or by using the env variable that nuke would associate with that parameter?
It kinda doesnt make sense to wire this all up in Nuke but then use OctoVersion's direct env var to set/override the parameters for octoversion 🤔

That's a good point. In this case, we are setting the name of the BranchName parameter to OCTOVERSION_CurrentBranch, as a shortcut, so we can keep using the existing env vars we have setup... 🤔

Just a comment about

"Can be set via the environment variable OCTOVERSION_CurrentBranch.",

Whilst this is true for OctoVersion itself, if this is a documented Nuke build example wouldnt it be better to specify it using the nuke parameter that the comment is referring to. in other words, this is a nuke parameter so it can be set by passing --BranchName to nuke, or by using the env variable that nuke would associate with that parameter?
It kinda doesnt make sense to wire this all up in Nuke but then use OctoVersion's direct env var to set/override the parameters for octoversion 🤔

That's a good point. In this case, we are setting the name of the BranchName parameter to OCTOVERSION_CurrentBranch, as a shortcut, so we can keep using the existing env vars we have setup... 🤔

Do you want me to change this example to just use a CurrentBranch parameter which isn't sourced by an Env Var?

Do you want me to change this example to just use a CurrentBranch parameter which isn't sourced by an Env Var?

I think we can change it to
[Parameter("Branch name for OctoVersion to use to calculate the version number. ")]
readonly string BranchName;

The "match env var to parameter" is native to nuke, so this probably matches standard usage better.

New PR here for subsequent change: https://github.com/OctopusDeploy/OctoVersion/pull/63


San Jose mapping wishlist

[ ] Building footprints
[ ] Addresses
[ ] VTA bus routes and stops
[ ] Sidewalks & crosswalks
[ ] Parks and schools
[ ] Double-check libraries
[ ] Investigate trail coverage

Road Data - Lane numbers, speeds, direction (everything in TomTom?)

Lane numbers

Lane counts appear to be largely limited to freeways and expressways, plus major arterials in North County. Still a lot of major streets without lane counts.
HOV lanes have been tagged, but we need to fix up some of the tagging to meet the project’s standards. (There are plenty of ways tagged note=left lane is hov, for example; the hov:lanes tag is more appropriate.)

speeds

Speed limits are in good shape in Palo Alto and Sunnyvale and on most freeways and expressways.

direction

Do you mean one-ways? My impression is that OSM has pretty good coverage of one-ways in the South Bay.

Those links are so cool.
I'm not sure what is required yet for good road data.  I think we want to make it very good, at least for the big roads.  Potentially you can use OSM street networks for open source congestion modeling.  I think we would need all of the above.  I'll have a source from MTC -> VTA map network to test against soon from here.

the OpenSidewalks team has done a good job of gamifying and simplifying accessibility data crowdsourcing into OSM and their OSM proposal
https://github.com/OpenSidewalks/OpenSideWalkQuests
https://github.com/OpenSidewalks/GPSContributionApp-iOS

grocery and food retail - for mapping food deserts.

Hopefully we’ll get all the grocery and food retail POIs as part of #23. 🚀


[Feature Request] Disable automatic recompilation

It would be nice to make the auto-recompile feature optional. Having your computer constantly watching file changes and triggering recompilation isn't always desirable, especially if you're on battery power, your laptop chassis is the heat sink, you're working on a shader that takes inexplicably long to compile (written by some one else, of course 😉.)
I imagine the most flexible approach would be to add some command palette option to allow users to switch between having the preview recompile when they've changed the previewed file, only when they've saved the file, or only manually via some other command/a "recompile" button over the preview next to play/pause.

I agree this could be more felxible, but the option to disable it or modify the timeout already exists:

Adding more options for reloading, specifically disabling all automatic reloading and replacing it with a reload button (which is exactly what the online version of shader-toy does) sounds like a good idea.


RC-4

Remove unused variable from action.

Not actually RC-4 since this RC scheme was only for the wiki action thing, but who cares.


Confirm elements by Designer

It close because I add this item to https://github.com/sotayamashita/bdash/issues/27


[ISSUE #4810]word spell check

There are several typos in the code.
Like TIMER_WHELL_TTL_DAY in class TimerMessageStore.

Coverage increased (+0.1%) to 49.269% when pulling f41978fba4781a94179aef02cf7cd3305b6ba578 on fujian-zfj:typos-fix into 06ca14a5081d067a1e61b5d716d3f17c16ef00d0 on apache:develop.

Coverage increased (+0.1%) to 49.269% when pulling f41978fba4781a94179aef02cf7cd3305b6ba578 on fujian-zfj:typos-fix into 06ca14a5081d067a1e61b5d716d3f17c16ef00d0 on apache:develop.


Why is the Zernike aberration calculated by this module different from that in MATLAB function?

This is the fourth term with a coefficient of 1 calculated by this module：

and this is calculated by matlab function:

the matlab function can be downloaded here.
So, why the results are different? Which is correct?

At a glance the results seems identical.
The colormap distorts your perception outside the circle, cause you have -1 with the Matlab representation and 0 with this module. Just export a .dat output and compare both by subtracting them element-wise.

May I ask if you know why this problem is now? I also met the same question.

I have also noticed this. The scale seems to be double of the of the matlab code.
Ignore the colors, as they ar close in this image, but look at the peak and vallue. This python library is almost double that of matlabs.
It get close by doing a divide by 2.
Phi = cart.eval_grid(c, matrix=True) / 2

Zernike polynomials can be normalised in many ways. This code uses Noll's ordering and normalisation (https://opg.optica.org/josa/abstract.cfm?uri=josa-66-3-207), which is standard in adaptive optics literature. It allows to easily compute the root-mean-square and variance of aberrations (https://opg.optica.org/ao/abstract.cfm?uri=ao-33-34-8121). Plus there is a test for the normalisation https://github.com/jacopoantonello/zernike/blob/e81e48b07d706bf924d7b5098ac190a06a3a7471/zernike/test.py#L339 which is not reporting any error. In https://en.wikipedia.org/wiki/Zernike_polynomials#Zernike_polynomials the formula for Z_2^0 should yield -sqrt(3) at the centre and +sqrt(3) at the edge of the unit circle, which seems correct looking at your first plot.


Dependency Injection: Constructors & Injectors

Follows #1
Let's assume we have Container class. The goal is to build DI features, that are based on ekiro/haps but aren't dependent on global singleton Container. Probable use-cases as follows: ...

Inject descriptor
Loosely based on https://github.com/ekiro/haps/blob/v1.1.1/samples/instance_properties.py
# interfaces.py
class HeaterInterface:
    pass

# some_dependent.py
class CoffeeMaker:
    heater: HeaterInterface = Inject()
    pump = Inject(name='a_pump')

    def __init__(container: Container):
        self.container = container

    def make_coffee(self):
        return f"heater: {self.heater}\npump: {self.pump}"

# some_implementations.py
class Heater(HeaterInterface):

    def __repr__(self):
        return f'<Heater id={id(self)}>'

class Pump(PumpInterface):
    heater: HeaterInterface = Inject()

    def __repr__(self):
        return f'<Pump id={id(self)} heater={self.heater}>'

# configuration.py
Container.register_by_interface(interface=HeaterInterface, constructor=Heater)
Container.register_by_name(name='a_pump', constructor=Pump)

The second missing feature in ekiro/haps is a per-request scope.
class Scopes(Enum):
    SINGLETON = 'singleton'  # always the same instance in this container
    THREAD = 'thread'  # per thread (via `threading.local`)
    REQUEST = 'request'  # per a "request" (whatever a request is in your application)
    INSTANCE = 'instance'  # every injection makes a new instance

I've added first part: injecting dependencies as properties.

TODO:

public fields in Inject class
inject decorator

@jakos, close the issue if you think you're done here.


Support transient resources

Some resources are transient (AKA no backing database).  This usually occurs with something that does calculation and returns calculation data.  The routing for this tries to create a link to the item which won't exist because it is transient.  There should be a convention to specify that the request is NOT idempotent and that the routing should refer to the original route, possibly with the original params.

If you want to override the generated urls, you can do so by implementing IUrlPathBuilder. See the documentation on this topic.


New features

Add the following features and improvements:

Application:

Upgrades the NodeJS version and its dependencies
Additional info for GET handler
Add a POST handler
Add /health handler for health checks (suppressed logs)

Deploy:

Add Nginx Ingress support for helm chart
Add support for Skaffold

Sorry, this pull was intended for my fork :)


[WIP] Add experiment that simulates AWS Az being down

What
https://issues.redhat.com/browse/MGDSTRM-579
Add chaos experiment that simulates az being down
Why
To ensure resiliency of our service we need to evaluate what impact that an availability zone being down will have.
How

Add new litmus-go experiment for az-down
create dummy ACLs with deny all traffic policies
assign ACLs to subnets of az under test
revert ACL changes after experiment concludes

Premature PR

Hi @damienomurchu. Thank you for contributing this experiment 👍 .. if you'd like to open a draft PR and want to discuss - please feel free to do that!

Thanks @ksatchit :+1:
I'm just iterating and testing this on my fork, but happy to open a draft pr once its a bit more advanced.

@ksatchit I've opened a draft PR here by the way, #230
Trying to test it locally with okteto but I may be overlooking something and raised an issue here (#229 ) if you had any thoughts/ pointers


chore: import repository https://github.com/DaleWYZ/golangtest11.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment