NLTK Sentence tokenizer does not tokenize properly if there exists 'e.g.' or 'i.e.' in sentence.

Like i have sentence:
'The first approach, single-molecule simulation, taken by the StochSim simulator, tracks individual molecules and their state (e.g., what other molecules they are bound to) so that only the complexes formed at any given time are enumerated (and not all possible complexes) [11].'
The sentence tokenizer splits this sentence and gives me following two sentences;
The first approach , single-molecule simulation , taken by the StochSim simulator , tracks individual molecules and their state ( e.g.
and
, what other molecules they are bound to ) so that only the complexes formed at any given time are enumerated ( and not all possible complexes ) [ 11 ] .
How can this be resolved?

This is not reproducible as described.  The training algorithm will actually catch cases like e.g. if they are followed by a comma.  However, the bug behavior does occur without the comma.  It looks like the Penn treebank corpus, which was used to train the prepackaged english.pickle model does not actually contain e.g. or i.e. with the necessary frequency to be recognized.
If this diagnosis is accurate there are a few possible solutions that occur to me:

retrain on a different or expanded corpus
add a list of known abbreviations, which would include e.g. and i.e.

I think the punkt model was trained on Wikipedia, rather than PTB. I think it would be okay to add these as known abbreviations to the model (in abbrev_types). But I'm not sure how nltk versions its models.

The README included with the tokenizer says English.pickle was trained on PTB, and the sample 5% corpus contains zero instances of "e.g." and "i.e." so that makes sense.  I was able to extract the abbrev_types set from the English.pickle model (pasted below) and they don't seem to be there.
I can just "manually" add these to English.pickle (tested and working locally) but I wouldn't know how to deploy a new english.pickle model.
{'w.va', 'cos', 'sen', 'w.c', 'ga', 'c.o.m.b', 's.a.y', 'g.d', 'a.s', 'j.p', 'g.f', 'n.v', 'okla', 'j.k', 'r', 'pa', 'cie', 'a.a', 'dr', 's.a', 'adm', 'va', 'l.f', 'ok', 'jr', 'p.m', 'j.c', 'e.m', 'l.a', 'u.s', 'a.c', 'ariz', 'f.j', 'corp', 'n.j', 'j.r', 'n.h', 'j.b', 'reps', 'wash', 'h.c', 'ill', 'm.d.c', 'f', 'm.j', 'mr', 'ky', 'sept', 'i.m.s', 'colo', 'd.h', 'bros', 'wed', 'r.a', 'a.g', 'ph.d', 'st', 'tues', 'lt', 't.j', 'u.s.s.r', 'prof', 'oct', 'r.t', 'minn', 'b.f', 'wis', 's.p.a', 'd.w', 'mg', 'm.b.a', 'inc', 'w.r', 'vs', 'g', 'conn', 'm', 'r.i', 'a.t', 'nev', 'a.h', 'feb', 'c', 'ms', 'n.y', 'messrs', 'nov', 't', 'n.d', 'b.v', 'mich', 'f.g', 'l.p', 'sep', 'e', 's', 'tenn', 'ala', 'ore', 'a.d', 'co', 'p.a.m', 'col', 'rep', 'maj', 'n', 'dec', 'k', 'aug', 'w', 'ft', 's.g', 'u.s.a', 'e.f', 'v', 'n.c', 'sw', 'yr', 'r.h', 'h.m', 'fri', 'fla', 'h', 'n.m', 'j.j', 'h.f', 's.s', 'ave', 'e.l', 'g.k', 'u.n', 'l', 'vt', 'chg', 'c.i.t', 'a.m.e', 'gen', 'u.k', 'p', 'r.j', 'calif', 'mrs', 'c.v', 'a.m', '. . ', 'w.w', 'e.h', 'jan', 'sr', 'r.k', 'd', 'ltd', 'd.c', 'ct', 's.c', 'kan'}

Okay. It's a long time ago, but we might have chosen to train on PTB since
English Wikipedia uses very little abbreviation and hence might not be
useful for training a period disambiguator.


chore: add missing iceberg AC code

Adds a missing AC code to critera for iceberg APIs

closing as this will be addressed in: https://github.com/vegaprotocol/specs/pull/1747/files


adding jupyter con 2020 example to the example collection

I find that the examples you explained in the jupy 2020 are very acclaratory and contain all the data that a edge or node can contain. this is very useful for being able to understand the fully power of ipycytoscape.
adding that jupyter file to the collection of examples would be wonderfull.
From the same jupyter notebook example I would include in read the docs a section including all the attributes of nodes and edges. it suffices to copy and paste the list appearing in the video on min 15.06 into a section of read the docs. The atributes are basically self explanatory

Hey @joseberlines, thanks for the kind words :)
I just looked for the notebook here and I don't have it! Fortunately I've uploaded it to the conference dropbox, I sent an email and I'm waiting for someone to get back to me with the file so I can upload it here.
Cheers!

Hey @joseberlines we can reopen this.
I'm gonna ping the responsible folks one more time!

@SylvainCorlay were you able to have a look at this?
You have someone else I can ping about it?

This was lost, unfortunately.
I wrote a new notebook for scypy and will make it available here.


TODO left in hint

Describe the Issue
Hint for step 35 in "Learn Interfaces by Building an Equation Solver" in "Scientific Computing with Python" contains: "TODO: add details/improve wording".
Affected Page
https://www.freecodecamp.org/learn/scientific-computing-with-python/learn-interfaces-by-building-an-equation-solver/step-35
Your code
irrelevant
Expected behavior
irrelevant
Screenshots

System
irrelevant
Additional context
I'm not sure of the author's intentions, but I think it would be helpful to direct the learner on how to represent multiple characters, as this was mentioned much earlier in the course. For example, in this manner:
"When referring to all digits, you can use regex special sequences or sets"
Related file - https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/07-scientific-computing-with-python/learn-interfaces-by-building-an-equation-solver/664ef4623946e65e18d59764.md

The pattern (?<!\d) is a negative lookbehind assertion. It ensures that the character 1 is only substituted if it is not preceded by a digit.

What if we return this one
return re.sub(r'(?<!\d)1', '', equation_string.strip('+'));

Hi @MarcinK00 !
I have updated your issue to just focus on your second point you made about regex sequences.
I have opened this up for the discussion so other contributors and the Python team can weigh in here.
As for the TODO comment, I have opened a separate issue for that since that can be handled pretty quickly and shouldn't be blocked by this ongoing discussion here 👍

as this was mentioned much earlier in the course

That's kind of the idea. Our approach is often to get campers to recall (or revisit) concepts they have learned previously.

I am closing the issue. I created it because the author of the code left a “TODO: add details/improve wording” comment that was displayed to the campers. The step doesn't seem too difficult based on the posts on FCC forum. So after removing the bug, I consider the problem solved.


Feature request: Fish-like autocompletion and autosuggestion

Hi, I like this project and use recently. I used Fish and ZSh. I'd like request some new features I missed very much: Fish-like autocompletion and autosuggestion. Some guys implemented in Zsh already. is it possible to implement in Bash? Thanks!

Can you please described what these features do? Without that, it will be hard to impossible to implement them.

I think he is referring to fish shell

@arimourao yes. Could refer to fish shell.
And here is the implementation in zsh/oh-my-zsh.
https://github.com/zsh-users/zsh-autosuggestions
https://github.com/zsh-users/zsh-syntax-highlighting

Sorry guys, but I'm way too busy to read through these links and figure out what you're looking for.
If you're interested in having a feature added, please provide a concise description of what you're looking for. Or even better provide a Pull Request that implements the feature. Suggestions are great, but someone will have to implement it in the end.
No offence, but I don't have time for doing this guesswork.

Okay. Let explain the details. What's I want exactly is Fish-like auto-suggestions as below.
The command suggestions come out automatically according to the history. It's very useful while typing the long commands. And you can see the syntax highlight color of the commands in the screenshot.

@seagle0128 it's interesting but I think this is an entire new project in its own. You or someone else interested in these features should port these to Bash. Only then bash-it could add these as plugins to be installed.

Agreed. This looks like a useful feature, but if you take a look at the project, it looks like a huge undertaking. Not sure whether Bash supports the features required for making something like this happen.

Hi @seagle0128 I would like to have in bash the zsh autocomplete but so far what I have found is this.
https://github.com/dvorka/hstr
I hope it works for you and that @nwinkler revises it to implement it in the framework.
Greetings. :bowtie:

This looks similar to fzf, which we already have a plugin for - allowing to search through your history for previous commands...
From what I've seen, the autocomplete functionality you're looking for is not easily possible in Bash...
BTW: I'm not sure why you think that I have to implement this. Feel free to provide a Pull Request if you have something you would like to see added.

I completely support the suggestion of @seagle0128

I completely support the suggestion of @seagle0128
This is something very similar: https://github.com/scop/bash-completion

Isn't the Bash completion you linked to exactly what we already have in Bash-it's completion functionality?

Idk, i dont know bash-it - i thought its bash and hit this page here by google xD :P

This is what i mean: https://asciinema.org/a/37390?t=16

I agree with you guys, I can't believe something like that doesn't already exist for bash. Like @nwinkler said, bash probably doesn't support the features necessary to achieve the functionality, otherwise it would exist already. However, based on all these comments I'm gonna look further into the port idea.

I am on zsh now and very happy. Oh-my-zsh made it very easy to setup and https://github.com/zsh-users/zsh-autosuggestions add the functionality. One plus pro is that zsh is fully compatible with bash.
Solved for me...

Personally I believe Bash/Readline's existing history-search-backward and history-search-forward options are just as useful and less distracting (at least to my eye).
Add the following to ~/.inputrc:
"\e[A": history-search-backward
"\e[B": history-search-forward

Type a partial command (one that you have already executed previously) then use the UP-arrow to navigate through all the commands that match the prefix. Whilst it doesn't look as sexy as Fish/Zsh auto-suggestion it is just as functional.

Personally, I use fzf for that. If you install fzf and enable the fzf plugin, your Ctrl+R prompt turns into a fuzzy filter for command history, it will autocomplete previous commands as you type. I find this to be highly productive...

Coming from a google search...
After seeing some advantages from fishshell over bash but still preferring a lot of bash idioms (!!, $!, $!:h, command completion with <ESC>*, etc.)
Oh...my...god!!!
@nwinkler, you just made my day!!
What an awesome tool fzf is!!
Combined with vim integration, I'm blown away..

Thanks for the kind words, @benjamin-thomas - happy to help.
fzf is indeed absolutely fantastic, one of the best shell tools I know.
In addition to the built-in functionality (Ctrl+R), the fzf plugin contains some common functions that I have adapted from the fzf Wiki, too.
I also use it ad-hoc for things like ls | fzf, together with the preview functions this is incredibly useful. Try this with the configuration from my dotfiles:
https://github.com/nwinkler/dotfiles/blob/0d5688368b6a15e701768305625a469e43170c47/home/.bash_profile#L18-L27

These are very, very nice ideas.
Very well done, and thanks for the share!

I too, love the fish shell for its unobtrusive command suggestions, inline, as I'm typing.  I got so used to it.  It's nice zsh has something similar (as mentioned by @ShalokShalom).  I am far more comfortable in a bash similar shell, and fish is a little out there for me.

Impossible to achieve?

As far as I know, it's impossible unless readline is modified or replaced by some other line editor. I actually implemented syntax-highlighting and autosuggestions in my bash configuration (akinomyoga/ble.sh), but it replaces readline with a line editor written in bash scripts so that some behaviors might be different from those in readline. Nevertheless, maybe you like ble.sh (if you don't want to implement a new line editor and autosuggestions for yourself).

FYI pwsh is implementing auto-suggest in their PSReadLine project. (See fish branch)
I have a dream, that one day, bash too will have auto-suggest.


GoStringer implementation for aws.String and friends

Hello! We routinely log out %#v values of structs for debugging purposes, and they look a lot like this now: SpotPrice:(aws.StringValue)(0xc208207490). Can you please implement GoStringer for all the pointer wrappers to extract the actual value? If you want I can submit a PR but it'd look like this:
func (v String) GoString() string {
  value = "nil"
  if v != nil {
    value = fmt.Sprintf("%v", *v)
  }

  return fmt.Sprintf("aws.String(%s)", value)
}

Something like that, given I just ad-hoc typed that up in this issue.

We're actually looking at moving away from StringValues based on other user feedback, but this would be an interesting use case to keep it around. Note that these types have already been removed out of develop.
A better solution might be to provide some external util method that pretty prints response structures so you can debug more easily.

Either way is fine with me. Just a question: if you're moving away from the wrappers, what are you moving to?

You can see this generated in develop already, but we are using regular string, int, float, and bool pointers. The feedback we got was that the IntValue, BoolValue, and the like distract from the actual type and obfuscate the intent that they are just regular strings, ints, bools, etc.
We're still not settled on the solution, so we may go back to Value types. There seems to be some pros and cons for both arguments, but right now for simplicity we're just generating regular pointers. Feel free to weigh in on what might be best from your perspective!

@lsegal Oh you mean regular pointers? (Sorry didn't look in branch). Yeah, in that case you'd definitely add more work on your side of getting those pointers to not be hex values during debug printouts... so that is an argument for them. I honestly don't mind it either way, but pragmatically speaking it is harder to debug when they're raw pointers.

FWIW I added a awsutil.StringValue() helper in the paginators branch for a similar use case. It's possible that we might just pull this into develop/master as we go forward.

awsutil.StringValue() is now in master.

I'm closing this since awsutil.StringValue allows inspection of these objects in a pretty reliable way. We can certainly find a way to make this more convenient, but I think that should unblock the immediate problem. Thanks for bringing this up!


clientv3/integration: do not create v3 clients when not used

Add 'SkipClients' field to skip creating clients if not used.

@gyuho can you create an issue for the proxy failure? and re-trigger the test?

lgtm after fixing the naming.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f42534c). Click here to learn what that means.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master    #8756   +/-   ##
=========================================
  Coverage          ?   76.06%
=========================================
  Files             ?      359
  Lines             ?    29623
  Branches          ?        0
=========================================
  Hits              ?    22533
  Misses            ?     5526
  Partials          ?     1564

Impacted Files
Coverage Δ

integration/cluster.go
84.69% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42534c...ff2ed93. Read the comment docs.


Corrected line 337 to reflect the correct component name.

Description
Corrects line 337 in the hosts_example.yml to reflect the correct component name.
Fixes # (issue)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
No testing required, as it's a simple comment update.
Test Configuration:
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Sorry this should be merged into 540-post as well @JumaX just noticed.


How to use different daterangepicker design??

Based on function init_daterangepicker_single_call() on build\js\custom.js, I used this code to change daterangepicker style:
$('input.js-daterangepicker').daterangepicker({
    singleDatePicker: true,
        locale: {
            format: 'YYYY/MM/DD'
        },
    singleClasses: 'picker_1'
});

But the daterangepicker always use the default style. How do I use different style?

What we have in our template it's just a sample, for more examples of usage you can check this.


setPagingEnabled - ability to disable ONLY swiping?

I still want to be able to change month with the top bar, but i want to display swipe paging as it interferes with my activity's view pager!

This has been implemented with 1.3, which can be toggled with MaterialCalendarView#setPagingEnabled(false). The month paging should still work via the buttons on top bar.


Compressor crashing when building assets on Heroku

I can also reproduce this error if compression is enabled locally.
remote:        rake aborted!
remote:        SassC::SyntaxError: Error: error reading values after ,
remote:        on line 14370 of stdin
remote:        >> px, #ECECEC 4px, #E1E1E1 5px, #FFFFFF 6px, , , , , );
remote:        ------------------------------------------^
remote:        /tmp/build_bfac79ff2aeaeb533c89623080124288/vendor/bundle/ruby/2.2.0/gems/sassc-1.5.1/lib/sassc/engine.rb:38:in `render'
remote:        /tmp/build_bfac79ff2aeaeb533c89623080124288/vendor/bundle/ruby/2.2.0/bundler/gems/sassc-rails-3f36dd2b5159/lib/sassc/rails/compressor.rb:16:in `call'
remote:        /tmp/build_bfac79ff2aeaeb533c89623080124288/vendor/bundle/ruby/2.2.0/gems/sprockets-3.2.0/lib/sprockets/sass_compressor.rb:28:in `call'
remote:        /tmp/build_bfac79ff2aeaeb533c89623080124288/vendor/bundle/ruby/2.2.0/gems/sprockets-3.2.0/lib/sprockets/processor_utils.rb:75:in `call_processor'
remote:        /tmp/build_bfac79ff2aeaeb533c89623080124288/vendor/bundle/ruby/2.2.0/gems/sprockets-3.2.0/lib/sprockets/processor_utils.rb:57:in `block in call_processors'

Hey, is it possible to isolate a snippet of CSS that is eventually producing this error?

Ok this was being caused by improper use of a linear gradient mixin. Actually this found a bug and some dead CSS for us.

great, thanks for the follow up!


Cherry-pick changes for unified storage tiering REP to master

A large number of changes on the 4-2-stable branch have been made to support the unified storage tiering REP and these should be brought to the master branch as well. As I understand it, the master branch will be focusing on the policy-composed version of things (which may or may not even need code?) so it's possible that the unified storage tiering plugin will be the only thing shipped in the future.

I believe this is done now.


python310Packages.pynina: 0.3.1 -> 0.3.2

Changelog: https://gitlab.com/DeerMaximum/pynina/-/releases/0.3.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 248348 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.nina
python310Packages.pynina
python310Packages.pynina.dist
python311Packages.pynina
python311Packages.pynina.dist


Improve stacktrace format and clean main.cc

Align function names in stacktrace
Remove many useless code

Any description (what is to be implemented) of this change? It seems miscellaneous in one patch.

Added.


PHPStan throws undefined static method using modal method

Just recently I started seeing this following phpstan/larastan issue.
Call to an undefined static method Inertia\Inertia::modal().

Which my controller looks a litttle somthing like
<?php

namespace App\Http\Controllers;

use Inertia\Inertia;
use Momentum\Modal\Modal as InertiaModal;

class FolderController extends Controller
{
    public function __invoke(): InertiaModal
    {
        return Inertia::modal('Folder/Create')->baseRoute('home');
    }
}

and my phpstan.neon is using the base configuraiton
includes:
    - ./vendor/nunomaduro/larastan/extension.neon

parameters:
    paths:
        - app

    level: 5

    ignoreErrors:

    excludePaths:

    checkMissingIterableValueType: false

Any idea's or something I must add to my phpstan.neon? The method works fine still, just trying to clean up stan issues.

I'm pretty sure that's unrelated to the package. You can try bypassing the exception explicitly. Ignoring in configuration file


tox.ini:  black line length and flake8 max line length

should we try to specify and sync them in the tox.ini and reduce some of the longer lines in the func doc strings?

fixed


Remove version: Google.Chrome version 120.0.6099.217

Hash Mismatch - Old Version
Microsoft Reviewers: Open in CodeFlow

Sequence contains no elements

#133371

Sequence contains no elements

https://github.com/microsoft/winget-pkgs/issues/133371

(Automated response - build 642.)

Automatic Validation ended with:

2024-01-19T04:47:50.8275460Z Processing manifest: manifests\g\Google\Chrome\120.0.6099.217
2024-01-19T04:47:50.8284759Z -----------------------------------------------------
2024-01-19T04:47:50.8291265Z Status: Started
2024-01-19T04:47:50.8299331Z Manifest file is Deleted
2024-01-19T04:47:51.1204463Z Status: Completed
2024-01-19T04:47:51.1217897Z ##[error] Result: Failed
2024-01-19T04:47:51.1305981Z ##[error] Sequence contains no elements
2024-01-19T04:47:51.1877587Z ##[error]Manifest Validation Failed

(Automated response - build 642.)

URL: https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise.msi
Status Code: 200
(Automated message - build 642)


Add SQLITE_OPEN_FULLMUTEX flag

Adressing https://github.com/SRombauts/SQLiteCpp/issues/282 to add missing SQLITE_OPEN_FULLMUTEX flag in SQLite namespace.

Coverage remained the same at 100.0% when pulling 8ecadfd629efe6f1bf8ca47b36c6159406cd652c on rwrx:fullmutex-flag into 6a5a24f9a9e53e967439136e27271915cc73bc45 on SRombauts:master.

Thanks!

Thank you for merging it. When do you plan to release a new version of SQLiteCpp?


Multiple networks associated with a single service

I am trying to deploy SFM application with service connected to multiple networks (I am experimenting with micro-segmentation until Service Mesh is supported in SFM).
What I am observing is a GatewayTimeout. Is this a supported scenario? Is it going to be supported in next preview?

This still has to be one to one between networks and services.  I think there is validation coming with the next release to make this more obvious.  Once the isolated networks/gateways demoed at Ignite are released, then scenarios like this will start to light up.

@mattrowmsft Thank you so much! I see it now. This is pretty awesome solution - I see how to do 90% of Service Mesh features now using gateways!


[Feature Request] Historical recurring transactions

I wanted to input my transactions starting from 1st of January 2022, so I created a weekly transaction starting on the 7th of January. I expected this to create a transaction every week since then until today, but it only creates a single transaction for the 7th of January.

But you can see in the transaction row "Repeat interval: Weekly", correct?
The problem that numbers in overview are calculated as if all transactions are one-time is known and will be fixed hopefully in next release.

There is only a single transaction that shows on 7th of January (if I go to 14th, 21st, 28th, etc. there isn't anything). This transaction also shows on today's date, which I assume just shows every transaction in the database (because it also shows transactions for future dates). The transaction does say "Repeat Interval: Weekly".

Yes, repeating transactions are getting a complete overhaul to fix all it's issues. Please use #8 to track.


chore: bdd-spring-1585104256 to 0.0.1

chore: Promote bdd-spring-1585104256 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


C++20 might break manylinux2014

If not with the next vroom version, it'll only be a matter of time until gcc10 will run out of supported C++20 features vroom is using. Currently its running CI with gcc11. I'd suggest to move to manylinux_2_28 eventually, which has gcc12 and is basically CentOS8. I'm working quite a bit on bindings stuff these days and we're using that already, so I could this here too. WDYT @jonathf ?

I am all for it. I wish to contribute, but my time is a little bit limited for the remainder of the month. After that I definetly will give it a shot if you havenn't already gotten to it first.


Add support for remote commands

Add support for commit, export, inspect, kill, logs, mount, pause
port commands
Refactored Report class to allow column lengths to be optionally
driven by data
Refactored Ps class to truncate image names on the left vs right
Bug fixes

Signed-off-by: Jhon Honce<EMAIL_ADDRESS>

@baude @TomSweeneyRedHat Please take a look.  TIA.

bot, retest this please

bot, retest this please

LGTM

@rh-atomic-bot r+

bot, retest this please

bot, retest this please

bot, retest this please

bot, retest this please

bot, retest this please

bot, retest this please

@jwhonce I think test_runner.sh is breaking under papr

bot, retest this please

@rh-atomic-bot r+


Bttfclock

My first watchface and code for the bangle.js v2.
Please let me know if something seems wrong

Thanks @thyttan I saw the error in the flow, but it would have taken me a little longer to figure out without your help. I have made the changes and am crossing my fingers for it to work now :)

Nice! The linter still complains about three variables that are never used. Either remove them or comment them out and I think we should be good to go :+1:

Merging - thanks again!

Thanks for the help


KMZ Support

Hi are there plans to have KMLLayer support KMZ with images?
There are some KMZ files that contain images which is used by the KML file.

No plans at this time, but please consider sending a PR to add support if you'd like to see it sooner!

sorry i dont follow. PR as in pull request? doesn't sound right. and where exactly do i file one?

Yes, pull request. You can implement support and then send us a pull request for review and potential merge into the codebase.
Some info about PRs and how they work is available here: https://help.github.com/en/articles/about-pull-requests

I added KMZ support in https://github.com/googlemaps/android-maps-utils/pull/625.


NETOBSERV-1265 Overview / Topology fully drop metrics doesn't show

Overview will show "No results found" on the entire page only if every metrics buckets are empty, else it will show per graph results.
Topology will fallback on dropped metrics if metrics are empty, only for that particular case. Everything then appears red.

/approve


Only notify if active crystal

I didn't test to see if it worked or even if it compiled (don't have a java IDE set up) but should work in theory, sorry.
Closes #12

Couldn't add this directly to the hasEscapeCrystal method as it seems like that would break the "Show infobox even when inactive" setting

Nice, thanks! :)


Homepage info

Create a new component for the "How it Works" section that details the steps on signing up and using the functionality.  And a brief overview of the functionality below the header:
Reference for the overview,

I also feel like there should be a mention of the specifics of how it works somewhere. Maybe something like “connect with the community on Twitter and Github at the click of a button”. I’m having a hard time deciding where it would go though.

From @nrooney024
Rename the heading for the current "How it Works" section to "Developed Open-source"
See the Figma wireframe for reference.

@primer/octicons-react package is already installed - click the link for any questions on usage.
Icons used
Step 1: sign-in
Step 2: apps
Step 3: pencil
Step 4: code-of-conduct

Here is a mock-up of the "How it Works" component

Please refer to the Figma project for typography and color specifications. The text styles on Figma have the same name as their React component.
The typography component library can be found in client/src/components/misc/Typography


why in C?

is it for the constant time?  for performance?  wouldn't a pure OCaml implementation (see below) work in the same fashion?
let eqaf a b =
  let len = min (String.length a) (String.length b) in
  let res = ref 0 in
  let get_int idx s = int_of_char (String.get s idx) in
  for i = 0 to pred len do
    res := !res land ((get_int i a) lxor (get_int i b))
  done ;
  !res = 0

I'm waiting a long benchmark to check the constant time of the C implementation. However, from my tests, this ML function does not check the equality with a constant time - I'm not sure if it's about the GC noise or not but I will look the assembly code generated to understand why thea ML version of equal does not have a constant time execution.
I clearly want a OCaml version (for portability) but if I can not check the constant time execution on it, I prefer to use a C function. I will update this issue with my results :+1: !

########## Random ##########
---------- eqaf ----------
min: 295.563355.
max: 451.895365.
mean: 331.880177.
median: 324.179808.
deviation: 5.453890.
deviation: 18.100379%.
---------- eqst ----------
min: 25.332532.
max: 402.526954.
mean: 32.466916.
median: 27.256772.
deviation: 6.122530.
deviation: 1.987797%.
---------- eqml ----------
min: 4115.224663.
max: 7396.156073.
mean: 4862.692974.
median: 4599.915675.
deviation: 27.496528.
deviation: 1337.071723%.
########## Equal ##########
---------- eqaf ----------
min: 311.025058.
max: 612.734348.
mean: 384.195579.
median: 337.415476.
deviation: 8.980862.
deviation: 34.504076%.
---------- eqst ----------
min: 387.414471.
max: 733.811892.
mean: 432.752349.
median: 415.002861.
deviation: 7.110980.
deviation: 30.772933%.
---------- eqml ----------
min: 4082.366589.
max: 9207.859649.
mean: 5259.984148.
median: 4733.766429.
deviation: 35.377266.
deviation: 1860.838571%.
########## Total ##########
---------- eqaf ----------
min: -235.383571.
max: 83.966068.
mean: -52.315402.
median: -16.787965.
deviation: 8.791549.
deviation: -4.599334%.
---------- eqst ----------
min: -706.617198.
max: -31.485017.
mean: -400.285433.
median: -386.676459.
deviation: 7.962065.
deviation: -31.870984%.
---------- eqml ----------
min: -4738.452043.
max: 3084.672993.
mean: -397.291174.
median: -108.030682.
deviation: 40.194553.
deviation: -159.689412%.

@dinosaure So how do the runtime stats here compare to your expectations?
PS @hannesm your implementation fails to detect this inequality: :dancing_men:  ;) (you should fail and return false early if lengths differ)
utop # eqaf "ab" "abCDEF";;
- : bool = true

IMHO, eqaf has expected result. time needed to compare equal values or not is the same (a diff between series of times when we compare equal values and series of times when we compare different values is close to 0 - see Total/eqaf/mean = ~50).
eqst (so caml_string_equal) has expected result too. It is the faster implementation when it compares different values but took the same time than eqaf when values are equal (Equal/eqaf/mean = Equal/eqst/mean = ~400). A diff between them shows eqst is not a constant time equal function Total/eqst/mean = ~400.
Finally, the OCaml implementation eqml is ... incomprehensible.

And again, I don't like to put another C stub on projects for this trivial function but benchmarks don't help me to avoid this way. If someone can show me an OCaml implementation which is close to what eqaf has, I will happy to use it.

So if this solution is good for you @hannesm and @cfcs, I can prepare a better test (which keep the signal with Travis CI) and release it.

Good news, Travis CI is happy and standard derivation on eqaf has an expected result (between -10% and 10% - eqst exceeds this internal).
Another good new is about eqml which, only on Travis CI, has expected result (standard derivation is close to 0). So I'm able to externalize on the API eqml but I will keep eqaf and let the user to choose between them.

Finally, I will delete the support on 4.03.0 because Core ...

I think this makes sense. I am still kind of confused about the deviance that the OCaml implementation displays, but hopefully we can work that out. In the meantime, I think it makes sense to go ahead with this C implementation.

I would be curious to see a comparison with these two other implementations:
let eqaf_native a b =
  let len = min (String.length a) (String.length b) in
  let res = ref 0n in
  let get_int idx s = Nativeint.of_int (int_of_char (String.unsafe_get s idx)) in
  for i = 0 to pred len do
    res := Nativeint.logor !res (Nativeint.logxor (get_int i a) (get_int i b))
  done ;
  (String.length a = String.length b) && !res = 0n

external unsafe_get64 : string -> int -> int64 = "%caml_string_get64u"
let eqaf_int64 a b =
  let len = min (String.length a) (String.length b) in
  let res = ref 0L in
  let get_int idx s = unsafe_get64 s idx in
  for i = 0 to pred len do
    res := Int64.logor !res (Int64.logxor (get_int i a) (get_int i b))
  done ;
  (String.length a = String.length b) && !res = 0L

Beware that if the Travis CI tests run in a VM, you might see different runtimes/behavior in a non virtualized computer.

@UnixJunkie indeed, outputs on this issue come from my server (and can be replicated easily on your computer). And, as I said, problem on Mac OSX about eqml should be about noise of virtualization.
@gasche I will prepare some benchmarks about that :+1:

Of course my first eqaf_int64 version was wrong (didn't handle the modulo-8 leftover at the end of the inputs etc.), I edited it. I'm still not fully sure that it is correct, but it looks better now.

@gasche eqaf_native and eqaf_int64 can leak the length of the unknown string (which may or may not be an issue depending on the code), you should do the length comparison before running through the for loop.

Cannot the attacker also guess the length of the unknown string by calling the exit-early version many times with strings of each length, and see which exit early? I tried to avoid that, but of course you are right that running min s1 s2 iterations of the loop also leaks information. I guess that a safe formulation should be explicit into which argument is the secret and which is attacker-provided, and always run as many steps as the attacker-provided length.
(Apologies if I say something silly, I know nothing about timing attacks.)

@gasche In theory, yes, but that depends on the application. If the attacker passes a long string they could (if they have a baseline for your string comparisons) provide one very long string and get the length of the compared-against string with only one invocation of eq. If it exits early, they at least need multiple chances to compare against the same sensitive value.
On the other hand this makes it easier to determine the length (since the diff between a 128 vs 127 string would be much easier to distinguish if you exit early than if the attacker has to time the diff between 127/128 invocations), so you have a point.
I would still prefer exiting early, also because the performance of the neq case would be impacted less, leading to less overhead compared to vanilla OCaml String.equal in that case.

So, some news about previous benchmarks. I rewrote the benchmark to avoid dependency with the world^Wcore_bench and I have good results now about eqml. You can see the new implementation on #4 which follows mostly what core_bench do but the biggest change is about time where we use now a monotonic timer.
Then, I integrated snippets of @gasche and results on my computer (X1 Carbon, virtualization) is:
########## Random ##########
---------- eqaf ----------
min:       0.001152.
max:       0.002241.
mean:      0.001906.
median:    0.001954.
deviation: 0.015425.
deviation: 0.000000%.
---------- eqst ----------
min:       0.002506.
max:       0.027956.
mean:      0.025222.
median:    0.025612.
deviation: 0.058866.
deviation: 0.000015%.
---------- eqml ----------
min:       0.000080.
max:       0.000162.
mean:      0.000133.
median:    0.000136.
deviation: 0.004615.
deviation: 0.000000%.
---------- eqnt ----------
min:       0.000057.
max:       0.000176.
mean:      0.000109.
median:    0.000097.
deviation: 0.005999.
deviation: 0.000000%.
---------- eqbg ----------
min:       0.000736.
max:       0.001512.
mean:      0.001254.
median:    0.001305.
deviation: 0.014299.
deviation: 0.000000%.
########## Equal ##########
---------- eqaf ----------
min:       0.001005.
max:       0.002599.
mean:      0.001691.
median:    0.001458.
deviation: 0.022845.
deviation: 0.000000%.
---------- eqst ----------
min:       0.000904.
max:       0.002425.
mean:      0.001603.
median:    0.001576.
deviation: 0.020863.
deviation: 0.000000%.
---------- eqml ----------
min:       0.000069.
max:       0.000161.
mean:      0.000129.
median:    0.000138.
deviation: 0.005324.
deviation: 0.000000%.
---------- eqnt ----------
min:       0.000096.
max:       0.000167.
mean:      0.000135.
median:    0.000138.
deviation: 0.004099.
deviation: 0.000000%.
---------- eqbg ----------
min:       0.000020.
max:       0.001221.
mean:      0.000913.
median:    0.000998.
deviation: 0.016835.
deviation: 0.000000%.
########## Total ##########
---------- eqaf ----------
min:       -0.000838.
max:       0.001058.
mean:      0.000215.
median:    0.000343.
deviation: 0.023630.
deviation: 0.000000%.
---------- eqst ----------
min:       0.001392.
max:       0.026118.
mean:      0.023619.
median:    0.024057.
deviation: 0.058371.
deviation: 0.000014%.
---------- eqml ----------
min:       -0.000051.
max:       0.000075.
mean:      0.000004.
median:    0.000003.
deviation: 0.005738.
deviation: 0.000000%.
---------- eqnt ----------
min:       -0.000092.
max:       0.000067.
mean:      -0.000026.
median:    -0.000023.
deviation: 0.006447.
deviation: -0.000000%.
---------- eqbg ----------
min:       -0.000410.
max:       0.001049.
mean:      0.000341.
median:    0.000333.
deviation: 0.018763.
deviation: 0.000000%.

Your results are a bit hard to interpret for me. Correct me if I'm wrong:

the deviation is lower for eqml and eqnt than for eqaf on Random (and all are sensibly lower than eqst of course), so the OCaml implementations are even more constant-time than the C version, except eqbg which is about the same?

assuming we can use mean to draw performance conclusion, the numbers suggest that the OCaml-based solutions are sensibly faster (when called from an OCaml program) than the C version, doesn't that suggest just getting rid of the C code?

in the Equal case there is essentially no performance difference between eqml (the naive version) and eqnt (using native machine integers), so this suggests using the simpler/clearer eqml version from @hannesm.

The OCaml constant-time functions also seem much faster than eqst (using String.compare) on equal strings, which is somewhat strange. Does this suggest that String.equal should be reimplemented as OCaml code rather than a C primitive?

I don't understand why the mean value is different between Random and Equal for the same function, aren't the inputs of the same length in both cases, so shouldn't we get the same mean values?

The mean of eqbg is ten times smaller in the Equal case than in the Random case, isn't that wrong?

deviation(eqml) = 0,004615 < deviation(eqnt) = 0,005999 < deviation(eqbg) = 0,014299 < deviation(eqaf) = 0,015425 < deviation(eqst) = 0,058866

From these results, as you said, yes, the OCaml implementation (eqml) is more stable than the C implementation (eqaf). Then, we get expected results about eqst, this implementation about random inputs is not stable.

It's not a surprise than the OCaml implementation (eqml) is faster than the C implementation (eqaf). I think, we can get this kind of results (instead previous version of the benchmark) only because I decided to use a monotonic clock to benchmark them (which is less subject to noise). And from these results, I completely agree to use the OCaml implementation now.

Again, I completely agree with this. The code of eqml is more readable than eqnt.

Indeed eqml is more faster than eqst when we compare 2 same string (but physically different). I need to figure out why and see the ASM code produced of both, I think.

mean(eqml) = 0,000133 on Random inputs is sensibly equal to mean(eqml) = 0,000129 on Equal inputs. It's the same for eqnt (mean(eqnt) = 0,000109 and mean(eqnt) = 0,000135). But, you are right, mean eqaf and eqbg differ between Random and Equal inputs. Mean of eqst differs too but it's an expected result.

For your last point, I need to figure out why we can have this situation.

Currently, size of inputs is 4096 and we produce 50 string. For each string we run the equal function until 1 second. Then, we see how many runs we did. I think, I will run a bigger benchmark.

Yes, it's not surprising that the OCaml version is faster because it can avoid the (small but noticeable) FFI costs at the boundary of the call, saving the registers to bridge the different calling conventions etc. This also explains why String.equal (which I think is C code) is slower. This is a per-C-call cost so the difference should be less noticeable on large strings. What is the size of the strings you use to benchmark?

[4096 bytes](https://github.com/dinosaure/eqaf/pull/4/files#diff-fa96e02582bba62b4c7d8bac70d3e8e7R738_).

I will provide a test on Windows and then make a new release of it with the OCaml implementation and all will happy 👍 !

I guess with the FFI version it also becomes harder to filter out jitter from the OCaml runtime (since we are looking to be constant time in the sense that execution time does not depend on the data [apart from the length]; not that in the sense that each execution should take a constant amount of time to execute).
We can extrapolate that if something does take a constant time to execute for all inputs of a given length, the execution time is also constant-time (independent of the data), but we cannot go the other way.
So the FFI version, while it might be correct, is harder to measure correctly.

thanks to all who contributed, since this repository now uses a purely OCaml-based equal I'll close this issue.


don't assume bash-isms in default shell

resolves #146 broken symlinks

Alternatively: https://github.com/wix/react-native-interactable/pull/211

I am closing the PR as a part of an effort to cleanup and revive the project. If this issue persists after v1.0.0, you are more than welcome to reintroduce the PR.
Thanks for your contribution.

I had to recreate the symlinks using the command proposed by @markhu in this pull request


Check if lanterns are optional and conditioned in the bedroll use dialogue prompt

Added condition to ConditionVars and conditionalized the Use Lantern option. They were already optional.


mobile chat fall out

bigger:

[ ] it's easy to refresh the page if you use the livechat pull down method to close.
[ ] video player stops/restarts on size change of page / tablets (may do for go live)
[ ] chat box doesn't come up if you swipe away your address bar (KP firefox video)

Smaller items to fix later:

[ ] better support for disabled chats on mobile https://salt.odysee.com/@TimeGhostHistory:6/sweden-abolished-slavery-in-1945:3 (don't show comments box, just show disabled)
[ ] can't add tips with stickers anymore (non paid) (if you type, then add sticker, you can)
[ ] select sticker > change sticker > goes back to emoji picker, not sticker
[ ] add livestream user count on chat mode (middle of live chat section?)
[ ] light mode double input box - less noticable on dark.

[ ] show min superchat / chat amount somewhere - can even be outside of chat mode. Can also be a snackbar when trying to type/send.
[ ]  linked-comment highlight cut off

[ ] https://github.com/OdyseeTeam/odysee-frontend/issues/380
[ ] go to comment issues - doesn't always scroll. https://salt.odysee.com/markuptest:b9d4cec9b0e3386c8309fa38b53683c7752c872f?lc=20cde4558af7d52f69488441e27f346f6526d33b3ca50c598d1a8ab0f93ff25d / https://salt.odysee.com/2022priorities:b29e9f514cf066936aee02ed1ff1d986ec34f51c?lc=c8fd7fc7c54fd6fde82495419c4caafba64bce81f0338a66088ad0d7b63465c2 - these do work on odysee, and this may be a race condition where we stripe off ? params

[ ] Unrecognized prop.  Desktop, when opening a video.

[ ] Able to reproduce the recsys "-1" index reported by Johnny https://odysee-workspace.slack.com/archives/C02G20Z2AEL/p1641856040009500.  Not happening in master.

Steps:  Load a video.  Drag the window size to make it mobile.  Scroll down and click on the first recommendation

Should be related to the un-mounting or switching between FileRenderFloating and FileRenderMobile, but just a guess. Unmounting it means disposing videojs, which impacts recsys.

[ ] On tablet, there is always the need to pull down in order to see the red bar

https://user-images.githubusercontent.com/64950861/152629610-b835d112-e8c8-453c-aac2-556c1fc85e91.mp4

[ ] Try to create a channel while tipping, but cancel it.  The page goes into a bad state.

https://user-images.githubusercontent.com/64950861/152629641-ea83e0ea-358f-4064-b638-23c3cb17e392.mp4


grpc-gateway: txn marshaling broken

I try a txn with If(CreateRev("foo")=0) { Put("foo", "bar") }, generated with the gateway's marshaler from the pb struct:
'{"compare":[{"result":0,"target":1,"key":"Zm9v","TargetUnion":null}],"success":[{"Request":{"RequestPut":{"key":"Zm9v","value":"YmFy"}}}]}'

The %+v output for the pb structure gives:
{Compare:[target:CREATE key:"foo" ] Success:[request_put:<key:"foo" value:"bar" > ] Failure:[]}

However, the gateway decodes it into the pb structure:
{Compare:[target:CREATE key:"foo" ] Success:[] Failure:[]}

Then crashes out before returning from client.Txn:
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x45d7712]

goroutine 161 [running]:
github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.(*ResponseOp).Size(0x0, 0x1)
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb/rpc.pb.go:6801 +0x22
github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.(*TxnResponse).Size(0xc4201034a0, 0xc42079f8f8)
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb/rpc.pb.go:6916 +0x74
github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.(*TxnResponse).Marshal(0xc4201034a0, 0x500b340, 0xc4201034a0, 0x68a5378, 0xc4201034a0, 0x5012201)
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb/rpc.pb.go:4385 +0x2f
github.com/coreos/etcd/cmd/vendor/github.com/gogo/protobuf/proto.Marshal(0x500b340, 0xc4201034a0, 0xc4201034a0, 0x500b340, 0xc4201034a0, 0x50122a0, 0xc420221440)
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/github.com/gogo/protobuf/proto/encode.go:233 +0x34b
github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/etcdserver/api/v3rpc.(*codec).Marshal(0x5054910, 0x4a6ff60, 0xc4201034a0, 0x4a78920, 0xc4206eeb40, 0x4a6ff60, 0xc4201034a0, 0x0)
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/etcdserver/api/v3rpc/codec.go:22 +0x60
github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc.encode(0x5009700, 0x5054910, 0x4a6ff60, 0xc4201034a0, 0x0, 0x0, 0x0, 0x0, 0x45be857, 0xc420196400, ...)
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/rpc_util.go:278 +0x2f9
github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc.(*Server).sendResponse(0xc420148000, 0x5012420, 0xc420250a80, 0xc4201b8480, 0x4a6ff60, 0xc4201034a0, 0x0, 0x0, 0xc42020c4c8, 0x0, ...)
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/server.go:601 +0xb5
github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc.(*Server).processUnaryRPC(0xc420148000, 0x5012420, 0xc420250a80, 0xc4201b8480, 0xc42074aa80, 0x504e008, 0x0, 0x0, 0x0)
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/server.go:763 +0xedd
github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc.(*Server).handleStream(0xc420148000, 0x5012420, 0xc420250a80, 0xc4201b8480, 0x0)
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/server.go:932 +0x1339
github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc420011a00, 0xc420148000, 0x5012420, 0xc420250a80, 0xc4201b8480)
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/server.go:497 +0xa9
created by github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc.(*Server).serveStreams.func1
	/Users/anthony/go/src/github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/server.go:498 +0xa1

Hi guys, if no one has started to investigate this bug, I would like to work on it. I read through the stack trace in order to get a general idea of the data flow. Correct me if I'm wrong, but I believe that the unmarshaling  of transaction requests begins on line 724 of cmd/vendor/google.golang.org/grpc/server.go:
if err := s.opts.codec.Unmarshal(req, v); err != nil {         return err }
and the actual processing of the request start on line 738 of the same server.go file:
reply, appErr := md.Handler(srv.server, stream.Context(), df, s.opts.unaryInt)
If that is the case, then I think a good start to the investigation would be stepping through those areas of the code with a debugger. I actually haven't been able to determine a good way of reproducing this marshaling defect. Could you please provide steps for reproducing the defect. I have been googling for a while, but I wasn't able to find documentation explaining how to initiate a transactions to etcd.

@mangoslicer
This is how to repro:
curl -L http://localhost:2379/v3alpha/kv/txn \
        -X POST \
        -d '{"compare":[{"result":0,"target":1,"key":"Zm9v","TargetUnion":null}],"success":[{"Request":{"RequestPut":{"key":"Zm9v","value":"YmFy"}}}]}'

@heyitsanthony
Thanks for posting the reproduction info.
It looks like the marshaling code is fine. I recreated : {Compare:[target:CREATE key:"foo" ] Success:[request_put:<key:"foo" value:"bar" > ] Failure:[]} using pb structures and then marshaled and unmarshalled the structure. The result of unmarshalling was the original statement pb structure with a non-empty Success field.
The problem  actually appears to be related to an incomplete reading of the transport stream. So since we're not reading the entire stream (in our specific case we're only reading 11 bytes when we should really be reading 23 bytes), the bytes related to the Success field are missing by the time unmarshaller gets the data. From what I can tell, the recvMsg function from rpc_util.go is determining the length of bytes to read from the stream based off of the header of the gRPC message. This is just a small update on this issue, I'm actually still in the process of investigating why the header does not contain the proper length, I just thought people might appreciate an update.

@heyitsanthony
I was wrong in my last post. After investigating further, I found that the problem is actually with the JSON being passed to the gateway.
'{"compare":[{"result":0,"target":1,"key":"Zm9v","TargetUnion":null}],"success":[{"Request":{"RequestPut":{"key":"Zm9v","value":"YmFy"}}}]}'
There are actually two problems with this JSON string. The first issue is that "Request" and "RequestPut" are capitalized instead of in camel case or with underscores between the lower cased words (e.g. "request_put"). We need to adhere to this format of JSON, because library that we're using to unmarshal JSON into protobufs only searches for those specific JSON formats in the provided JSON.  Here's the code segment that enforces camel casing and underscoring:
       // Handle nested messages.
       if targetType.Kind() == reflect.Struct {
	         var jsonFields map[string]json.RawMessage
	         if err := json.Unmarshal(inputValue, &jsonFields); err != nil {
		            return err
	         }
	consumeField := func(prop *proto.Properties) (json.RawMessage, bool) {
		// Be liberal in what names we accept; both orig_name and camelName are okay.
		fieldNames := acceptedJSONFieldNames(prop)

		vOrig, okOrig := jsonFields[fieldNames.orig]
		vCamel, okCamel := jsonFields[fieldNames.camel]
		if !okOrig && !okCamel {
			return nil, false
		}
		// If, for some reason, both are present in the data, favour the camelName.
		var raw json.RawMessage
		if okOrig {
			raw = vOrig
			delete(jsonFields, fieldNames.orig)
		}
		if okCamel {
			raw = vCamel
			delete(jsonFields, fieldNames.camel)
		}
		return raw, true
	}

~From etcd/cmd/vendor/github.com/golang/protobuf/jsonpb/jsonpb.go
The second issue is that the "Request" field should not be included in the JSON. The success part of the JSON should actually be:
"success":[{"requestPut":{"key":"Zm9v","value":"YmFy"}}]
Since in RequestOp, "Request" is name of a field which is defined with a "oneof" property, I think that "Request"  may have snuck into the JSON due to improper handling of the "oneof" property. If you want to verify that "Request" should not be included in the JSON, take a look at the pieces of code that I found in the protobuf library.
The following is the definition of a message with a oneof property:
       message MsgWithOneof {
         oneof union {
           string title = 1;
           int64 salary = 2;
           string Country = 3;
           string home_address = 4;
         }
       }

~From https://github.com/golang/protobuf/blob/master/jsonpb/jsonpb_test_proto/test_objects.proto
Here is a test case using the MsgWithOneof  message:
       var unmarshalingTests = []struct {
           desc        string
           unmarshaler Unmarshaler
           json        string
           pb          proto.Message
       }{
                  "oneof", Unmarshaler{}, `{"salary":31000}`, &pb.MsgWithOneof{Union:&pb.MsgWithOneof_Salary{31000}}}
       }

~From https://github.com/golang/protobuf/blob/master/jsonpb/jsonpb_test.go
The expected JSON (i.e. {"salary":31000}) in the test case does not have the "Union" field defined, so I doubt we should include "Request" in our JSON string.
My question now is what generated the following JSON that was given to me to reproduce this issue?

@mangoslicer

My question now is what generated the following JSON that was given to me to reproduce this issue?

It was generated using grpc-gateway's runtime.Marshaler from a TxnRequest.

It was generated using grpc-gateway's runtime.Marshaler from a TxnRequest.

I'm not sure I follow. It would be really helpful if you could let me know if I have a sound understanding of the dynamics at work here. So according to api_grpc_gateway.md, the purpose of the grpc-gateway is to accept RESTful calls containing JSON data. Based off of this JSON support feature, I'm guessing that there must be an etcd client which takes protocol buffers and converts them into JSON, which is then sent to the grpc_gateway.
In the initial issue report, you state the following:

I try a txn with If(CreateRev("foo")=0) { Put("foo", "bar") }, generated with the gateway's marshaler from the pb struct:

'{"compare":[{"result":0,"target":1,"key":"Zm9v","TargetUnion":null}],"success":[{"Request":{"RequestPut":{"key":"Zm9v","value":"YmFy"}}}]}'
So if I am understanding you correctly, then you're saying that some protocol buffer was fed into the grpc_gateway runtime.Marshaler to produce the JSON at the top of this paragraph. My confusion lies at not being able to find the code that starts with "If(CreateRev("foo")=0) { Put("foo", "bar") }" and ends with the JSON string. Can you let me know where (if you're using some sort of client executable, let me know) you entered "If(CreateRev("foo")=0) { Put("foo", "bar") }" and where in the code you printed out the JSON string. Thanks for reading :)

@mangoslicer
in request_KV_Txn_0 of the generated code I added:
        txn := &etcdserverpb.TxnRequest{
                Compare: []*etcdserverpb.Compare{
                        &etcdserverpb.Compare{
                                Key: []byte("foo"),
                                Result: etcdserverpb.Compare_EQUAL,
                                Target: etcdserverpb.Compare_CREATE,
                                TargetUnion: &etcdserverpb.Compare_CreateRevision{0},
                        },
                },
                Success: []*etcdserverpb.RequestOp{
                        {
                                Request: &etcdserverpb.RequestOp_RequestPut{
                                        RequestPut: &etcdserverpb.PutRequest{
                                                Key: []byte("foo"),
                                                Value: []byte("bar"),
                                        },
                                },
                        },
                },
        }
        fmt.Printf("start: %+v\n", txn)
        b, _ := marshaler.Marshal(txn)
        fmt.Println("json: ", string(b))
        txn = &etcdserverpb.TxnRequest{}
        marshaler.Unmarshal(b, txn)
        fmt.Printf("unjson: %+v\n", txn)

which gives:
start: compare:<target:CREATE key:"foo" create_revision:0 > success:<request_put:<key:"foo" value:"bar" > >
json:  {"compare":[{"target":"CREATE","key":"Zm9v","create_revision":"0"}],"success":[{"request_put":{"key":"Zm9v","value":"YmFy"}}]}
unjson: compare:<target:CREATE key:"foo" create_revision:0 > success:<request_put:<key:"foo" value:"bar" > >

which is from JsonPB with origName = true (cf. https://github.com/grpc-ecosystem/grpc-gateway/blob/master/runtime/marshaler_registry.go#L16)
with origName = false, I get:
{"compare":[{"target":"CREATE","key":"Zm9v","createRevision":"0"}],"success":[{"requestPut":{"key":"Zm9v","value":"YmFy"}}]}

which parses OK and gives the resposne:
{"header":{"cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"2","raft_term":"2"},"succeeded":true,"responses":[{"response_put":{"header":{"revision":"2"}}}]}

I'll add some tests for this and close out this issue since marshaling is fine, just that the gateway seemingly can't unmarshal what it marshals. The crashing is still a problem, though.

@heyitsanthony

I'll add some tests for this and close out this issue since marshaling is fine, just that the gateway seemingly can't unmarshal what it marshals. The crashing is still a problem, though.

Thanks for the detailed explanation, but the question remains as to where the JSON that you gave me to reproduce the issue came from.
'{"compare":[{"result":0,"target":1,"key":"Zm9v","TargetUnion":null}],"success":[{"Request":{"RequestPut":{"key":"Zm9v","value":"YmFy"}}}]}'
This JSON contains has the extra "Request" field defined and when this extra piece of JSON fails to unmarshal into a success protocol buffer structure, then the program crash due to the nil success protocol  buffer structure. So I don't understand why we would close this issue without figuring out what generated that JSON and fixing it.

@mangoslicer it's from encoding/json. See https://github.com/heyitsanthony/scraps/blob/master/gateway-json/main.go

@heyitsanthony
Alright that solves that mystery. It also looks like the JSONBuiltin is throwing a marshalling error. So our any of the etcd clients which talk to the grpc_gateway using the JSONBuiltin? If so, we probably want to switch over to a different marhsaler.

What is is interesting is using 3.2.0 I will pass this to through grpc-gateway and it seems to randomly fail.
{"compare":[{"key":"Zm9v","target":"CREATE","create_revision":"0"}],"success":[{"RequestPut":{"value":"YmFy","key":"Zm9v"}}]}
vs your example
{"compare":[{"target":"CREATE","key":"Zm9v","createRevision":"0"}],"success":[{"requestPut":{"key":"Zm9v","value":"YmFy"}}]}
https://travis-ci.org/hexfusion/perl-net-etcd/builds/243610166
I guess the fact that it fails is one thing but what is your theory on the randomness.  In the travis tests it is checking against different versions of Perl.  But if you refreshed the tests it will fail in a different order.  I don't see this is master that I can reproduce.


add router-params to slot render view-component

I am sorry but it not fit to this place. If you want to get the router params = you have an HOC for that. Because of SOLID reason = There is only one way to kill yourself


Add plotting tests

This PR adds integration-like tests that generate realistic plots of various common kinds. They are derived from the notebooks in plot_testing/ and are intended to replace them (so this PR also deletes the notebooks).
This PR also adds a pytest CLI option to save the PDF files generated by these tests in a user-specified directory. This allows for manual inspection of the plots generated by the tests. See the README for details.
Drive-bys

fix a bug introduced in #26 in the colormap registration function.
disallow matplotlib 3.8.0 because it has a bug that breaks apc.mpl.setup.
disallow matplotlib 3.9 because it introduces breaking API changes.
add missing dev deps (seaborn, sklearn, pandas) (addresses #23).
update the poetry lockfile.

One higher-level question: should we remove the Jupyter notebooks? The goal of those notebooks is to serve as example code for folks to be able to understand how the library can be used in different contexts. Replacing those entirely with the tests prevents users from being able to have more interpretable examples to look at. We don't have to keep those exact notebooks or put them in the same place, but I do think it would be good for us to provide some copypaste-able code for this.

Yeah, makes sense. For now I've added the notebooks back into the plot_testing/ directory but we can move these to a more appropriately named directory later on.


Undefined label warning for labels defined only with PROTO keyword MASM

Hmm..

@francescogomez Recently I don't use MASM that often...
I've switched off PROTO defined labels because they created clashing label definitions. In your situation the ExitProcess label is not added to the label graph, hence the warning that it is not defined. I perhaps incorrectly assumed that the code of PROTO defined labels will be included elsewhere (eg. in an include).
If you think the warning is incorrect, I may find a way to fix this properly.

Fixed in the next version after <IP_ADDRESS>

It is work.

Visual Studio is a strange beast; the warning squiggles and the error tasks in the error list are unrelated. I forgot to update te error list update code...
Is fixed in the next version after <IP_ADDRESS>


extra certificates defined in values.pilot.jwksResolverExtraRootCA not working in version 1.22

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Hello!
I found that when update to version istio 1.22 , my company ca-certificate injected in the istiod container with:
                pilot:
                  jwksResolverExtraRootCA: |-
                      -----BEGIN CERTIFICATE-----

is not working anymore.
I compared the kubectl get pods -o yaml from the old pod with version 1.21 to the new pod with version 1.22.  and this is the difference:
My old pod has this that my new pod does not:
    - name: JWT_POLICY
      value: third-party-jwt

Version
$ istioctl version
client version: 1.22.1
control plane version: 1.22.1
data plane version: 1.20.6 (1 proxies)
$ kubectl version
Client Version: v1.30.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.30.0-eks-036c24b

### Additional Information

helm get values istiod
USER-SUPPLIED VALUES:
meshConfig:
accessLogFile: /dev/stdout
pilot:
jwksResolverExtraRootCA: |-
-----BEGIN CERTIFICATE-----
...
...

I forgot to restart the istio ingress pod for the data plane version:
$ istioctl version
client version: 1.22.1
control plane version: 1.22.1
data plane version: 1.22.1 (1 proxies)

anyways, I'm still the same issue...
pod logs:
[2024-06-10T13:01:42.740Z] "GET /hello HTTP/2" 401 - jwt_authn_access_denied{Jwt_verification_fails} - "-" 0 22 0 - "<IP_ADDRESS>" "curl/8.6.0" "0b085bd3-4196-4b4e-bee9-681925819cca" "xxxxx-xxxxx.xx.xx.mydomain.com" "-" outbound|80||"xxxxx-xxxxx.xx.svc.cluster.local - <IP_ADDRESS>:443 <IP_ADDRESS>:53614 "xxxxx-xxxxx.xx.mydomain.com


Example: QNN on a real backend

For sphinx implementation refer to mnist example

Fixed with PR #171


[vulnerability][exploitable][high]Reflected Cross-Site Scripting – Regular User

Exploit Mechanism
The user is able to inject javascript code and execute it on the user's browser.
Can this vector affect other products/apps/data?
Yes, other apps/data used by the user.
Can this vector expose sensitive data?
Yes, other apps/data used by the user.
Pentest Report

@ashrith this is caused by apps not sanitizing form inputs. Please file this in the specific app's repo.


not compiled

@arturmon Latest image will not compile until you have local snapshot of moquette
I have asked moquette team to give a nightly build --> https://github.com/andsel/moquette/issues/127
If they will not give I will upload somewhere to get snapshot build until we will get 0.8 release.
For now the workaround is,
clone https://github.com/andsel/moquette repository locally and build it.
clone https://github.com/andsel/moquette
cd moquette
mvn package install

Now continue with MyController

ok


Change remote to remotes?

I think this is kinda premature at this point. The idea was to accommodate different "remote" devices, as well as change the way in which one could potentially switch between being logged into one server or another, but that's all beyond the current scope right now, and it's not worth trying to see that far into the future.


[Feature Request]:  Improve documention for new eslint 9 flat configuration for shared monorepo project

Is there an existing issue for this?

[X] I have searched the existing issues and my issue is unique
[X] My issue appears in the command-line and not only in the text editor

Description Overview
I had some difficulties setting up a shared Eslint 9 flat configuration project in a mono repo structure. I couldn't find clear examples in the documentation, so I ended up creating a configuration file that I'm not entirely confident about.
I created a project @acme/eslint-config with the folllowing index file:
import pluginJs from '@eslint/js';
import reactPlugin from 'eslint-plugin-react';
import reactHooks from 'eslint-plugin-react-hooks';
import reactRefresh from 'eslint-plugin-react-refresh';
import globals from 'globals';
import tseslint from 'typescript-eslint';

export default [
  pluginJs.configs.recommended,
  ...tseslint.configs.recommended,
  reactPlugin.configs.flat.recommended,
  reactPlugin.configs.flat['jsx-runtime'],
  {
    files: ['**/*.{js,mjs,cjs,jsx,mjsx,ts,tsx,mtsx}'],
    ignores: ['dist'],
    languageOptions: {
      ecmaVersion: 2020,
      globals: {
        ...globals.serviceworker,
        ...globals.browser,
      },
    },
    settings: { react: { version: '18.3' } },
    plugins: {
      'react-hooks': reactHooks,
      'react-refresh': reactRefresh,
    },
    rules: {
      ...reactHooks.configs.recommended.rules,
      'react-refresh/only-export-components': ['warn', { allowConstantExport: true }],
    }
  }
];

I initially encountered multiple errors, but it was resolved after using "reactPlugin.configs.flat['jsx-runtime']". However, I'm still unsure about the correctness of my configuration.
In the project where I want to use this configuration, I created an eslint.config.mjs file with the following:
import acmeConfig from '@acme/eslint-config';

export default [...acmeConfig];

This setup is working for me, but I couldn't find a simple tutorial anywhere, only examples using .eslintrc. I'm also uncertain if my configuration is the best for creating documentation on this topic.
I opened this issue in this library because if I removed reactPlugin.configs.flat.recommended, it would work and with it I would always get 'React' must be in scope when using JSX, using reactPlugin.configs.flat['jsx-runtime'] fix it, but it wasn't clear at first.
Expected Behavior
I wanted a clearer tutorial using the new flat config.
eslint-plugin-react version
v7.35.0
eslint version
v9.9.1
node version
v20.10.0

It sounds like the issue is just that you were confused about the use of jsx-runtime, which is described in the eslintrc section of the readme, but not in [the flat config section(https://github.com/jsx-eslint/eslint-plugin-react?tab=readme-ov-file#flat-configs) of the readme. It's currently written assuming you've read the entire thing, but certainly could be improved.

I had similar bouts of confusion from the minimal examples for flat config in the README because I wanted to use the flat recommended AND jsx-runtime configs. It isn't as straightforward as extending both with the old .eslintrc method. I found that because the jsx-runtime flat config doesn't turn on (or off) any other rules besides the jsx-runtime related ones, I had to manually merged the configs to get it to work.
  {
    files: ['**/*.{js,mjs,cjs,jsx,mjsx,ts,tsx,mtsx}'],
    ...reactPlugin.configs.flat.recommended,
    ...reactPlugin.configs.flat['jsx-runtime'],
    rules: {
      // Need to combine the rules
      ...reactPlugin.configs.flat.recommended.rules,
      ...reactPlugin.configs.flat['jsx-runtime'].rules
    },
    languageOptions: {
      ...reactPlugin.configs.flat.recommended.languageOptions,
      ...reactPlugin.configs.flat['jsx-runtime'].languageOptions,
      globals: {
        ...globals.browser,
      },
    },
  },

I think you could get away with just spreading the jsx-runtime flat config's languageOptions and the rest of the config, but the rules specifically need to be merged. Definitely wish it was more clear how we should be using both the recommended and jsx-runtime flat configs.

I'd love a PR to improve the docs here.

...reactPlugin.configs.flat.recommended,
...reactPlugin.configs.flat['jsx-runtime'],

Given: import pluginReact from "eslint-plugin-react";
I had:
pluginReact.configs.flat.recommended,
  pluginReact.configs.flat["jsx-runtime"],

No ....


Refactor commands out of 'main' package

Resolves https://github.com/istio/istio/issues/13180 and follows the convention suggested by @geeknoid of istioctl/cmd package structure.

Not sure I like the package naming convention, too much repetition. Why not istioctl/pkg/cmd?

Not sure I like the package naming convention, too much repetition. Why not istioctl/pkg/cmd?

I was trying to follow https://github.com/istio/istio/pull/13277#issuecomment-485480768 and the pattern of the mixer, e.g. using mixer/cmd/mixs/main.go.  However maybe I missed https://github.com/istio/istio/pull/13277#issuecomment-486053949 so let me restructure...

/test all

@esnible: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
1ed8c5fcaa485adad9a829e44f20a01e1a78fb88
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liamawhite this should be easy to review ... no new code, just movement of the Cobra commands into a package.  The package structure is what was recommended by Martin.

@esnible: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
1ed8c5fcaa485adad9a829e44f20a01e1a78fb88
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: esnible, liamawhite
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid We need your approval for lowering the code coverage.  The code coverage is actually unchanged, but we moved code out of a large file which changed the coverage figure.

New changes are detected. LGTM label has been removed.

@esnible: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
683024192c4cad9e5887b7e7c87e8b2d58966213
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liamawhite Can you lgtm again?  The merge took the label away.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
683024192c4cad9e5887b7e7c87e8b2d58966213
link
/test istio-integ-k8s-tests

prow/release-test.sh
683024192c4cad9e5887b7e7c87e8b2d58966213
link
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: esnible, geeknoid, liamawhite
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@esnible: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
683024192c4cad9e5887b7e7c87e8b2d58966213
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Pass error to ErrorComponent

Related to #48
This will allow consumers to properly log errors in their ErrorComponent. IE: Sentry, BugSnag, etc.

Anything I can do to help this get merged? Thanks in advance 🙏🏻
Sorry to bug, just currently waiting on this new version to finalize our error reporting.

Anything I can do to help this get merged? Thanks in advance 🙏🏻
Sorry to bug, just currently waiting on this new version to finalize our error reporting.

Will review later today!

Awesome, thank you!


New page before each h1 heading.

Maybe I oversee something. But I'd like to have each first level heading on a new page. With default settings new chapters start in between.
Is it possible to add an option for that?

Wandmalfarbe gives a pretty good answer for this also in issue #81

This looks like a duplicate of Issue #81. @amaridev Please see the linked issue for a solution. As this seems to be a common question I'm going to leave this issue open as a reminder to update the docs.


include relevant versions (kernel & Swift) in test output

Motivation
Exact Swift version & kernel versions are often important to debug, let's include it.

Flaky test, tracking in #2427.

@swift-server-bot test this please


Segmentation fault when running tensorflow.python.eager.context.check_alive

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
binary
TensorFlow version
2.11.0
Custom code
Yes
OS platform and distribution
22.04
Mobile device
No response
Python version
3.9
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
nvidia-cudnn-cu11==<IP_ADDRESS>, cudatoolkit=11.8.0
GPU model and memory
No response
Current behavior?
Probably due to invalid string argument.
Standalone code to reproduce the issue
import tensorflow as tf
import numpy as np
from tensorflow.python.eager import context
try:
  try:
    with tf.device('/CPU'):
      arg_0 = "/job:remote_device/replica:0/task:1"
      out = context.check_alive(arg_0,)
  except Exception as e:
    print("Error:"+str(e))
  try:
    with tf.device('/GPU:0'):
      context.check_alive(arg_0,)
  except Exception as e:
    print("Error:"+str(e))
except Exception as e:
  print("Error:"+str(e))

### Relevant log output

```shell
/cudnn/lib:
2023-08-12 15:27:22.605920: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.
2023-08-12 15:27:23.511442: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-12 15:27:23.533020: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-12 15:27:23.533197: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-12 15:27:23.533535: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-08-12 15:27:23.534136: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-12 15:27:23.534277: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-12 15:27:23.534432: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-12 15:27:23.605501: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-12 15:27:23.605704: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-12 15:27:23.605831: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-12 15:27:23.605930: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 77 MB memory:  -> device: 0, name: NVIDIA GeForce GTX 1660 Ti, pci bus id: 0000:01:00.0, compute capability: 7.5
Segmentation fault

@dmc1778  I was able to replicate this issue on colab, please find the attached gist here.
Since Segmentation faults can be considered as potential security vulnerabilities please read SECURITY.md and report them through proper channel as mentioned in SECURITY.md.
Thank you!


[NEW GAME] Memorizing the cards game

Description

Display the cards face-down in a grid pattern on the webpage.
Allow the player to click on a card.
When a card is clicked, reveal its symbol.
Track the number of flipped cards.
If it's the first card flipped, remember it.
If it's the second card flipped:
Compare the symbols of the two cards.
If they match, keep them face-up.
If they don't match, flip them face-down after a short delay.
Allow the player to continue selecting pairs of cards.
Keep track of the number of attempts or time taken.
Once all cards are matched, display the player's score.

Screenshots
No response
Additional information
No response

@admindebu @panwar8279 please assign this game to me

Hi @Avdhesh-Varshney ,I am assigning this task to you. Kindly complete within a week. Good luck!


AttributeError: module '_distutils_hack' has no attribute 'ensure_shim'

setuptools version
setuptools==60.0.5
Python version
python 3.10
OS
macOS intel 12.1
Additional environment information
No response
Description
python3 -m pip install  -U setuptools
Expected behavior
python3 -m pip install  -U setuptools
How to Reproduce
brew install<EMAIL_ADDRESS>python3 -m pip install  -U setuptools
Output
Collecting setuptools
  Downloading setuptools-60.1.1-py3-none-any.whl (952 kB)
     |████████████████████████████████| 952 kB 351 kB/s
Installing collected packages: setuptools
  Attempting uninstall: setuptools
    Found existing installation: setuptools 60.0.5
    Uninstalling setuptools-60.0.5:
      Successfully uninstalled setuptools-60.0.5
Successfully installed setuptools-60.1.1

and when you exit and relogin
Error processing line 1 of<EMAIL_ADDRESS>
  Traceback (most recent call last):
    File<EMAIL_ADDRESS>line 186, in addpackage
      exec(line)
    File "<string>", line 1, in <module>
  AttributeError: module '_distutils_hack' has no attribute 'ensure_shim'

Remainder of file ignored

Code of Conduct

[X] I agree to follow the PSF Code of Conduct

i tested the version v60.1.1 and v60.1.0,both same error,only  setuptools==60.0.5 can work

Setuptools 60.1 ships with a new _distutils_hack module that does contain that attribute. For some reason, in your environment, there's another _distutils_hack module that's taking precedence, probably from an older Setuptools.
You should be able to run python3.10 -c "import _distutils_hack; print(_distutils_hack.__file__)" to see where that module can be found. Can you do that please and report the output? My guess is you have a user-installed copy in ~/.local.
In theory, loading the shim should be tolerant to configurations like these. In #2962 and #2964, we're exploring some approaches that could limit which .pth files invoke which _hack modules.

This issue is likely another manifestation of #2957.

Although the issues are similar, the more selective fix for that issue will likely not fix this one, so I'll deal with it separately.

@jaraco,
I am getting this error:
Error processing line 1 of /root/.ebcli-virtual-env/lib/python3.10/site-packages/distutils-precedence.pth:

  Traceback (most recent call last):
    File "/usr/lib/python2.7/site.py", line 158, in addpackage
      exec line
    File "<string>", line 1, in <module>
    File "/root/.ebcli-virtual-env/lib/python3.10/site-packages/_distutils_hack/__init__.py", line 194
      f'spec_for_{name}',
                       ^
  SyntaxError: invalid syntax

@marcelo, these parts of your error trace seem to indicated that there is something very wrong going on:
/root/.ebcli-virtual-env/lib/python3.10/
/usr/lib/python2.7/site.py

How can a python2.7 install be using files from a python3.10 virtual env and vice-versa?

Yeah I noticed that, but I don't really know how to fix it haha. I don't know why there is python2.7 there


[vcpkg_configure_meson] Update compiler flags parsing

Fixes https://github.com/microsoft/vcpkg/issues/30270. More generally, fixes parsing of fully quoted elements in flags detected from the cmake toolchain.
The parsing code for flags is now similar to what is in vcpkg_configure_make: The input is a single string of options for the native command line, so separate_arguments should do the right thing.
Tested with fribidi:arm64-android and NDK 25.

[ ] Changes comply with the maintainer guide
[ ] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[ ] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[ ] Only one version is added to each modified port's versions file.

This PR should effect other android ports? e.g. openssl?

This PR effect other android ports?

I hope so.

e.g. openssl?

No.

One of the problems however is that the flags need to be in cc/cpp instead of the _flag variables because those can be hard overriden by the project.


Transparent Screenshot gives pink background on iOS 15.5, iPhone 13 Pro Max

Forum: https://forum.playcanvas.com/t/screenshot-bug-on-ios-15-0/22090
Project: https://playcanv.as/p/i8wyBNbx/
Expected

On iPhone:

Can't reproduce in a new project: https://playcanvas.com/project/940813/overview/f-test_1

Look fine with iPhone5s (12.5.5).


Add the homepage to the metadata

When I started wrapping up CPDAcknowledgements - I noticed that this was missing from the metadata

Changelog and test?

Pring

Sorry, struggling to find out of work hours to write code

No worries, I got this working locally, I'll ship the 1.1.1 update in a couple of minutes!


Added Debug and Clone annotation to Bitmap struct

Thanks so much for this awesome crate! I love the API!
I needed them and I think it's generally useful to have those for Bitmaps

Thanks!


[NEW ICON] Xcode

Skill Name
Xcode
Why?
The IDE of Apple with essential tools for developers who develops on iOS, iPadOS, macOS and more
Reference Image

+1

I created a new project since this project is no longer updating & the author left it, xcode is available skills-icons
https://skills-icons.vercel.app/api/icons?i=xcode


Question about all the dataset & annotation

Hi, thanks for your great work!

Have you provided the supp. mat.? I couldn't find it now.
Could you share more details about the dataset and their mesh annotations, as MoSh is not available now, so how could you get gt mesh annotations? from SMPLify-X or others?
When will you release the main code?

Looking forward to your reply! Thank you in advance!

Hi, thanks for your interest in our work.
You could refer to this work for data preparation. Although several datasets, e.g., COCO, MPI-INF-3DHP, etc. do not have mesh annotations, we can still train our model on them using 2D/3D keypoint loss and adversarial loss following HMR.
Our code will be released in July. Stay tuned!


(GH-1) Added .Wait to ensure Tasks return correctly

@Redth  After doing some more testing with this new Alias, it turns out that it didn't work :-(
It wasn't working due to the fact that the Task wasn't being waited on, and as a result, the request was never being sent out.  I noticed that all other methods were using .Result but because there is nothing returned from the DELETE methods, this wasn't available.  Instead, using .Wait had the desired result.
I have done some testing, and I can confirm that these aliases now work as expected.

Ahh yep that makes sense :)

@Redth thanks for merging.  Can you let me know when you push to NuGet?  I would like to take it for a spin :smile:

Just pushed, so just wait for nuget caches to update!

Nice one, thank you!

@Redth final validation test just passed, so it is officially all working now :smile:


Warning: Only plain objects can be passed to Client Components from Server Components. Objects with toJSON methods are not supported. Convert it manually to a simple value before passing it to props.

[ ] Check if updating to the latest Preact version resolves the issue

Describe the bug
version:
@preact/signals-react": "^2.0.0",

pass the variable to child component, there is a warning:
code:
  const result = signal(0)

<ChildComponent result={result} />

Warning: Only plain objects can be passed to Client Components from Server Components. Objects with toJSON methods are not supported. Convert it manually to a simple value before passing it to props.
  <... filters={[...]} result={</>}>

Maybe it's my problem.
I create the signal in server component, and the ChildComponent is client client component.


hi could we get the full project with all sln

this will be very appreciated
because it dont want make the .lib

https://prnt.sc/w6zf92

No, it uses xmake which can generate the sln.
You need to update the submodules.

so how make it to date ?


Revert "Try join again"

Reverts cds-snc/notification-terraform#961
The dataset is there, but trying to import it fails. Seems to be a problem reding the status. plan fails too when running locally. Reverting for now...

Removed quicksight from CI temporarily, will try to fix using local / dev


A filter crash. Not the same as the other crash. (Sorry.) :P

Data filter crashed to menu.
No crash report but here is a log file.
latest.log
And the error message. (I was not going to wright all that gobbelty gook down. :p)

This looks like an error from laserio? Can you let me know what you were doing?

Sure. I open pack right click data filter and it crashes.
I's running ATM 10 version 0.28
With the fallowing changes.
Updated:
ApothicEnchanting-1.21-1.1.2
Added mods:
RingOfRepair-NeoForge-1.21-1.8.4
RingOfGrowth-NeoForge-1.21-1.8.2
travelersbackpack-neoforge-1.21-10.0.5
OreBerries-Replanted-1.21-0.9.4
toms_storage-1.21-2.0.8
GrowableOres-2.3.0-1.21-NeoForge
squatgrow-neoforge-21.0.3+mc1.21.disabled
ironchest-1.21-neoforge-16.0.7
I also noticed this pop up when logging back in and looking at NEI.

This is for laserio - i'll look into it :)


Linker error when building demos on Ubuntu 15.10

I'm getting a linker error when building PBD with CMake on Ubuntu 15.10. According to online sources, the problem could be fixed by inserting -lX11 at the right place, but I have no experience with CMake. I spent half an hour grepping and I couldn't figure out where that option would need to go.
This is the error output:
Linking CXX executable /home/lritter/devel/bin/BarDemo
/usr/bin/ld: /home/lritter/devel/lib/libAntTweakBar.a(TwMgr.cpp.o): undefined reference to symbol 'XCreateBitmapFromData'
/usr/lib/x86_64-linux-gnu/libX11.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

It appears this change fixed the problem and I got the binaries to build
diff --git a/extern/AntTweakBar/CMakeLists.txt b/extern/AntTweakBar/CMakeLists.txt
index 6bb7591..c182a9c 100644
--- a/extern/AntTweakBar/CMakeLists.txt
+++ b/extern/AntTweakBar/CMakeLists.txt
@@ -52,6 +52,9 @@ include_directories(include)
 add_library(AntTweakBar STATIC ${ATB_HEADERS} ${ATB_SOURCES})

 set_target_properties(AntTweakBar PROPERTIES FOLDER "External Dependencies")
+if (UNIX)
+    target_link_libraries(AntTweakBar X11)
+endif()

 set(AntTweakBar_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/include
     CACHE INTERNAL "AntTweakBar include directory")

I added your fix in the current release.
Thanks


Print ModSecurity version from nginx connector

With the nginx connector (v3), the log output currently looks like this:
2024/04/04 16:11:33 [notice] 630#630: ModSecurity-nginx v1.0.3 (rules loaded inline/local/remote: 0/824/0)
2024/04/04 16:11:37 [notice] 1#1: ModSecurity-nginx v1.0.3 (rules loaded inline/local/remote: 0/824/0)
2024/04/04 16:11:37 [notice] 1#1: using the "epoll" event method
2024/04/04 16:11:37 [notice] 1#1: nginx/1.25.3
2024/04/04 16:11:37 [notice] 1#1: built by gcc 12.2.0 (Debian 12.2.0-14)
2024/04/04 16:11:37 [notice] 1#1: OS: Linux 6.1.0-18-amd64

It would be helpful to also log the ModSecurity version, not only the connector version.

Thanks, I think that's a really useful feature request.
What do you think, what would be the better solution: make a new, separated line, or would be fine to append to the first line (before the part (rules loaded...)?

I think it's fine to append it to the same line. The ModSec and connector versions belong together anyway.
Maybe prepend it though: ModSecurity v3.0.12, ModSecurity-nginx v1.0.3....

Please take a review: https://github.com/owasp-modsecurity/ModSecurity-nginx/pull/319.

Fixed by #319.


Make docker drone image keep track with master branch

the drone image at dockerhub is too old, can you keep track with the master branch as the latest tag at dockerhub?

the drone docker image is published on every push / merge to master. The last image was published 13 hours ago


Group items by color tags not working properly

Description
Hello, I have a folder with lots of files marked with color tags and I want to see them grouped together, like when we view the Downloads folder grouped by creation date. The first time I set Files to group my files, it works like a charm. But when I go to another folder and enter again that folder I configured before, the files are all in the "not set" category. The color tags are all there, but they are all together in the same group.
Here's a screenshot.

What I know is the Downloads folder works ok set like that. It's always grouping items by the date, as seen in the screenshot below.

Steps To Reproduce
Go to a folder and set it to group files by the tags.
Go to another folder.
Go back to the first folder.
That's it.
Expected behavior
Whenever you enter such folder, It should be displaying the files grouped by the color tags.
Files Version
<IP_ADDRESS>
Windows Version
Windows 11 21H2 22000.434
Relevant Assets/Logs
debug.log
debug_fulltrust.log

Merging with #6844


Bluetooth: controller: Implement 2 additional VS commands

@holtmann @jhedberg comments addressed

@holtmann @jhedberg  opted for a simple concatenation and documented the lack of a space character

@holtmann @cvinayak if there are no further comments I will merge this soon


Default margin between field

How do you remove or lower the default margin between fields?

You can use spaceBetween attribute
OTPTextField(
  ...
  // this is the margin between fields
  spaceBetween:  10.0;
)


"#move " to move the song at index to play next

the index is a number which exists in the current queue and it moves the song to the top and plays it next

Changed to #move old_position new_position