AddColumn migrations created with bad default

Hope I'm not reporting a dup here.
Testing with SqlServer, I've added this property to my model:
builder.Entity<Blog>().Property(b => b.SomeProp).ValueGeneratedOnAdd();

Generating a migration creates the following code:
migrationBuilder.AddColumn<int>(
	name: "SomeProp",
	table: "Blogs",
	nullable: false,
	defaultValue: 0)
	.Annotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.IdentityColumn);

Note the defaultValue: 0, which I didn't specify in the model in any way. Note also that if the column is defined when creating the table, the correct CreateTable migration is generated:
SomeProp = table.Column<int>(nullable: false)
    .Annotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.IdentityColumn),

This causes an issue with Npgsql (https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/68) since the default value is examined in the migration decision process.

@roji How otherwise would you handle the already existing rows in the table?

That's a good question, but it seems like it's a migration detail. In other words, at the end of the process I should get the table definition that corresponds to my model, i.e. the same table definition I would have gotten if I created the table with the column in the first place.
One solution would be to add another migration operation to remove the default after the column is added. This way rows that existed before the addition have default values, but rows created afterwards don't.
Another possibility which seems better to me, is to force the developer to take manual action here, i.e. to generate the column addition without a default, making it fail if there are any rows. After all, adding a non-nullable non-default column requires a real decision from the develop - putting a zero for ints may not what what they want. It may even make them think and make the new column nullable, depending on their scenario.

@roji non nullable property obviously means NOT NULL column, so the developer made the decision already, I think there's no need to force any other manual action.
I agree that leaving the default value as part of the scheme is a bad idea though.
I would rather have something like valueForExistingRows which would update the rows before adding the new row.
migrationBuilder.AddColumn<int>(
    name: "SomeProp",
    table: "Blogs",
    nullable: false,
    valueForExistingRows: 0) // <---------
    .Annotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.IdentityColumn);

putting a zero for ints may not what what they want.
The auto generated migration is just a helper, you always should review the generated migrations and script and customize it if needed.

What do you think?
ps. Truncate Table is DDL :smile:

@roji non nullable property obviously means NOT NULL column, so the developer made the decision already, I think there's no need to force any other manual action.

The developer made the decision about the column being not null, but not regarding what should happen to existing rows... Basically it's a matter of whether 0 for existing rows should be a default, or something we force developers to choose. Both options make sense I guess; I definitely prefer the second because it seems like something the developer should confront - they may not have thought about the existing rows and just putting a zero there may cause trouble later. But I also understand the need for migrations to be seamless and not require too much manual intervention. It's a decision that has to be made.
Regarding your specific proposal (valueForExistingRows), something like that could make sense. Under the hood we're talking about two migrations: adding the column with the default, then altering the column to remove the column. I think that means two operations in the migration code as well (i.e. migrationBuilder.AddColumn(...) followed by migrationBuilder.AlterColumn(...)), but I may be wrong.

Under the hood we're talking about two migrations: adding the column with the default, then altering the column to remove the column.

It's two operations. Update existing rows and adding the new column, no need to create a default value at all.
The table needs to be locked though so there won't be a new row between the update and the altering of the table.
@roji Now that I rethink about it, I prefer the migration to leave the value blank and not compile and force the developer to fill the value.
I just don't think it's inline with how migrations in EF behave.

Under the hood we're talking about two migrations: adding the column with the default, then altering the column to remove the column.

It's two operations. Update existing rows and adding the new column, no need to create a default value at all.
The table needs to be locked though so there won't be a new row between the update and the altering of the table.

Uh, how do you update the existing rows if you haven't yet added the column?? Or am I totally misunderstanding?
If you add a column with a default, then remove the default everything seems nice and safe, no concurrency/locking issues...
Anyway, I guess we can wait for Monday to see what the team thinks...

Uh, how do you update the existing rows if you haven't yet added the column?? Or am I totally misunderstanding?

OMG I'm an idiot... :flushed:
Yes you're right. You need to add default values and remove it later.

What I usually do is add the new column as nullable.

See also: https://github.com/aspnet/EntityFramework/issues/5995

Triage: We should not try and set a default value if the column is set as identity, since it is not valid (and SQL Server would fill in the missing values anyway).
On a more general note, using the CLR default when you add a non-nullable column is just what we scaffold and we anticipate that folks would often change this to something that makes sense for their app. We don't think we need to change anything here.

@rowanmiller, note the discrepancy between what happens if the non-nullable column is present when the table is created, and when it's added later (i.e. between the CreateTable migration and the AddColumn migration) - in the first case there's no default, in the second there is. This is the part that bothers me most; if you always set the CLR default as the column default it would at least be consistent (although still wrong IMHO).
Again, I get the reasoning behind the default - when adding a column to an existing table there's the issue of existing rows, which doesn't exist when creating a new table. But that seems to be a detail; it seems that the database schema for a given model should be the same regardless of the history/migration path taken to reach it.

@roji we discussed this at length and decided the complexity of removing the default after adding the column isn't worth the benefit. Since the column is non-nullable, EF will always send a value in INSERT statements, so the database default is never used. It would only be used if SQL was run against the database out side of EF. Another factor in our decision is that we've had this behavior in EF6.x since the 4.3 release and have not had any complaints about it.

Thanks for looking at this, I didn't realize removing the default was such a complicated operation.
I'll describe how this bit me, I'm interested in how you deal with it. In the current Npgsql provider, you can mark an int property as ValueGeneratedOnAdd, without specifying any default. When the Npgsql migrations SQL generator sees such a property, it generates a PostgreSQL serial, which is actually just an int with a default coming from a sequence. The logic here is that the user may decide to have their own default which isn't a sequence. A similar thing is done with GUID fields that have ValueGeneratedOnAdd but no default. Note that this same logic works both for keys and non keys.
Now, as long as the column is present when the table is first created, everything works fine. But when the column is added later, the default is added by EFCore, and the migrations provider doesn't create a serial. In other words, it's not possible to know whether the default is a genuine user intention, or whether it's just an artifact of the column addition.
How do you guys handle this sort of thing?

I think that is similar to the issue we are planning to fix here, where the default value should not be added for database generated columns. BTW there is also DefaultValueSQL, which is different from a static default value and is where something like "newid()" would be used for SQL Server generated GUID columns.

@roji Also, look at SqlServerValueGenerationStrategy. This is how we define a high-level group of behaviors for SQL Server value generation across the stack. This is what allows Migrations and the update pipeline to know what to create/expect for different strategies.

@rowanmiller I check for DefaultValueSQL in addition to DefaultValue, if any of them are set I bypass the implicit sequence creation.
@ajcvickers, if I understand correctly you support two strategies:

Your migrations SQL provider checks for SqlServerValueGenerationStrategy.Identity and generates identity columns.
HiLo, where it's up to the user to manually specify the sequence in the model. In other words, migrations don't automatically seem to take HiLo into account in any way. There also seems to be a default for a single HiLo sequence, having a sequence-by-column seems to require an additional annotation.

In the PostgreSQL world, the standard for auto-increment columns (keys or otherwise) is the serial pseudo-type, which in reality implicitly creates a column-specific sequence and sets the columns default to get values from it (here are the relevant docs). The natural expectation is that when EF sees a value-generated int, it would do exactly that.
Requiring users to manually specify sequences for each value-generated would be awkward to say the least, as would be an additional annotation just to say "please create a sequence for this". This is why I made things simple: if your column is numeric, has ValueGeneratedOnAdd and doesn't have a default, I deduce you want a sequence. The only problem with this strategy is this issue - that some defaults aren't actually defaults...
Do you have any suggestion for supporting this scenario without imposing explicit sequence creation in the model or an added annotation? I hope I haven't misunderstood how you do thing in SqlServer and missed something.

@roji Is the problem that the PostgreSQL provider is using the "defaultValue" set in the Migrations model as the way to choose what strategy to use? I don't think this can work. I think you need to look in the actual EF model to determine which strategy is being used and then create the appropriate Migrations model from this. @bricelam might have more insight.

@ajcvickers, ah, that seems like a good way forward. The model would retain the user's intent (no default) even if the database has a default because of the migrations... I'll look into that, thanks!

Yep, that seems like it works. My NpgsqlMigrationsAnnotationProvider checks the property for ValueGenerate.OnAdd and for null DefaultValue/DefaultValueSql, and if so, passes an annotation that makes the migrations SQL generator create a serial column.
Note that this overrides the default value 0 set in the migration operation.
Thanks for the help!

Reopening this one as I think we should still avoid scaffolding a default value for new columns when the column is marked as store generated.

new columns when the column is marked as store generated.

What does "store generated" mean?
Does it mean that new columns won't have default values when they're not nullable?

@gdoron it means that values for the column are generated by the database (e.g. SQL Server IDENTITY) so there is no need for a default value. All other non-nullable columns will still have a default value generated.

@rowanmiller I'm admit I'm a bit confused as well by the terminology (have always been a little)... Columns with default are also generated by the database. In addition, Npgsql/PostgreSQL model seems to complicate this somewhat - let's take autoincrement (serial) columns. On the CLR model, the user is simply supposed to specify ValueGeneratedOnAdd, without specifying an explicit default (that would be needlessly verbose and un-PostgreSQL-like). The database column created from this should be a serial column, which in reality is a column with a default backed by a sequence (the sequence is implicitly created when the serial column is created).
To try to explain this in terms of the SqlServer provider, imagine a new value generation strategy in addition to identity and hilo. With this strategy, every ValueGeneratedOnAdd column gets its own sequence, which is automatically created by the migrations and named after the column. This is more or less how PostgreSQL serial works.
I think it's worth disambiguating whether, when we say "default value", we mean that on the CLR model or in the database column definition, because the two are not the same.

@ajcvickers, coming back to this after a long pause I have a small question with regards to your comment above.
In that comment you suggest that I look at the model directly to find out whether a property in question has a default or not - looking at the migration operation doesn't work because EFCore adds a default there even if one isn't defined on the model.
My question is whether this should happen directly in my MigrationsSqlGenerator, or whether an annotation should be generated in my MigrationsAnnotationProvider, and be examined in the MigrationsSqlGenerator. On the one hand, I can see that SqlServerMigrationsAnnotationProvider generates a ValueGenerationStrategy annotation which will later be examined by SqlServerMigrationsSqlGenerator. On the other hand, I can see cases where SqlServerMigrationsSqlGenerator directly looks up properties on the model (via FindProperty) and examines various things. I understand that annotations get embedded in actual migration code, but I'm  not sure exactly what the consequences of each method are.

@roji I think @bricelam is probably better able to answer that.

Use FindProperty in the Migrations SQL generator to discover additional context about performing an operation. For example, SQL Server checks to see if a column is indexed to determine the default max length (since SQL Server has a limit on the maximum bytes in an index).
Use annotations to expose store-specific features that the user may want to configure--imagine that they're creating a column without a backing property in the model. SQLite adds an annotation to set AUTOINCREMENT on the column because it is the best thing to do when working with EF, but the user free to change (remove) it if they know what they're doing.
I guess as a principle, try not to make decisions for the user in the SQL generator unless there is a way for them to override it (e.g. configure the max length in the call to CreateColumn).

@bricelam thanks for the guidance.


temporary back out of graph reference genomes to allow parallel development

This backs out the the graph reference genome support per decision to branch do allow parallel development.

-1!! No, this was not the agreement! Please push this change to a separate linear-edits branch.

Thanks @diekhans , the changes look good. @benedictpaten is right though, this change should be to create a new branch 'linear-edits' or 'linear-edit-variants' and not update master. I think the agreement is that this will be one of the candidates for becoming 'master' which we can discuss and vote on in Leiden. (I would vote for this linear-edit-variants branch becoming master, for what it's worth.)

There were actually two agreements. I thought on the call three weeks ago we agreed to take the linear-multiallelic VCF-like model as the master branch (I sent the call summary around and Stephen said on the topic of the master branch, my note was in line with his). Anyway, I will leave Mark to decide. I vote to make the VCF-like model the master.

yes, moving to branch first ... easy...  comment on contents.
how, to do a proper release model, something needs to flow into the default

@diekhans You could use a simple lifecycle nomenclature such as this:

For a new feature being introduced - let's say pysam-integration - just prefix the branch name with develop_ such as this:

develop_pysam-integration

Once we are happy with all the features, then rename it with test_ like this as a new branch - and would more likely create a new branch off this and then remove the old one:

test_pysam-integration
If this passes all the different tests, then it can be released - otherwise it get's pushed back to develop_. You can even have it be renamed to deploy_ in order for it to be released, but that's understood I think if it passes all the tests.  There's always the option of alpha_ and beta_ :)
~p


calculateDelta doesn't correctly account for minimum ada requirement in tests

Summary
The caluclateDelta function in Plutus.Contract.Test.MissingLovelace doesn't correctly account for the amount of Ada that is unaccounted for in a ContractModel test due to min Ada.
Steps to reproduce the behavior
Run the Spec.Auction contract model tests:
$> cabal repl plutus-use-cases-test
> import Test.QuickCheck
> import Spec.Auction
> quickCheck prop_Auction

Actual Result
Actions
 [Init,
  WaitUntil (Slot {getSlot = 97}),
  Bid (Wallet 3) 2000000,
  Bid (Wallet 3) 2000001]
Expected funds of W[1] to change by
  SymValue {symValMap = fromList [], actualValPart = Value (Map [(,Map [("",2000001)]),(363d3944282b3d16b239235a112c0f6e2f1195de5067f61c0dfc0f5f,Map [("token",-1)])])}
but they changed by
  SymValue {symValMap = fromList [], actualValPart = Value (Map [(,Map [("",655202)]),(363d3944282b3d16b239235a112c0f6e2f1195de5067f61c0dfc0f5f,Map [("token",-1)])])}
a discrepancy of
  SymValue {symValMap = fromList [], actualValPart = Value (Map [(,Map [("",-1344799)])])}
Expected funds of W[3] to change by
  SymValue {symValMap = fromList [], actualValPart = Value (Map [(,Map [("",-2000001)]),(363d3944282b3d16b239235a112c0f6e2f1195de5067f61c0dfc0f5f,Map [("token",1)])])}
but they changed by
  SymValue {symValMap = fromList [], actualValPart = Value (Map [(,Map [("",-655202)]),(363d3944282b3d16b239235a112c0f6e2f1195de5067f61c0dfc0f5f,Map [("token",1)])])}
a discrepancy of
  SymValue {symValMap = fromList [], actualValPart = Value (Map [(,Map [("",1344799)])])}
Test failed.

Expected Result
The tests pass!
Describe the approach you would take to fix this

Turn on the tests in plutus-use-cases-test with more than 10 runs of QuickCheck
Adjust the implementation of calculateDelta to correctly account for the delta due to minimum ada.
...
Profit!

Step 2 is a bit tricky but essentially the issue is that it needs to account for the fact that we don't know where all the ada goes, so it should probably simply say "the value could have gone anywhere" and introduce a wide band of uncertainty.
System info
N/A

ping @ak3n

@MaximilianAlgehed Should we close this?

Yes.
On Thu, 6 Oct 2022 at 16:28, koslambrou @.***> wrote:

@MaximilianAlgehed https://github.com/MaximilianAlgehed Should we close
this?
—
Reply to this email directly, view it on GitHub
https://github.com/input-output-hk/plutus-apps/issues/735#issuecomment-1270157795,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACBPPQMXDN2LLSKUTIQVH7TWB3O2FANCNFSM6AAAAAAQ4MRWHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Relay node throws "Have not received full local node configuration from the service, skipping interface setup" under load

Describe the bug
"Have not received full local node configuration from the service, skipping interface setup". A quick glance, looks like a race condition where setupInterfaceOS() was called prior to a peerListing getting processed
with it's local interface details in ax.buildPeersConfig(). https://github.com/nexodus-io/nexodus/blob/main/internal/nexodus/nexodus.go#L463.
Full log here:
https://gist.github.com/nerdalert/382b4cb6cddf9219430897b58eedd352
QA job and artifacts here:
https://github.com/nexodus-io/nexodus/actions/runs/4749567936
How to Reproduce
Joining 20 simultaneous -relay-only or 60 simultaneous nodes created the condition. TBD
Expected Behavior

Deployment Environment
qa-scale Large on main. No issues with medium qa job which is 35 nodes vs. 80 nodes.
Additional Context
No response

I was hitting this race in CI a bunch. I added this check to stop a nexd panic. It seems to be ok after reconciling again. I couldn’t figure out how it was happening, though, so I left the log message in place to highlight when it happens. It might be related to #831 but that’s just a guess.


Repage

finished the resources page.

@oraje looks like there is a conflict

@oraje looks good now


blocks endpoint returns invalid json field for epoch number

By schema /blocks should return epoch_no, but instead returns epoch

Thanks, looks like this was fixed earlier, but got overwritten between branches 😢 will get it sorted as patch soon


Raycasting demo still doesn't work

This official demo is broken (the line is never detected as intersecting), despite it being a paid, commercial plugin.
This issue went ignored on the forums, so let's try the actual issue tracker and maybe something can get done about it, huh?

This works fine with Phaser 2.6.2 (and various versions prior to that), it just doesn't work in the js-scrambled version of Phaser with Box2D built-in that is used on the site (which is pretty old now)
Nothing needs fixing in the plugin itself, or the example, just use a recent version of Phaser and it'll work fine. I'll update the site when I get a chance, but it's not important enough to have an Issue lingering open for.


当我们给接口新增一个参数密钥时，但参数的值为空时

Expected Behavior
可以正常发送请求并得到结果
Actual Behavior
当我们给接口新增一个参数密钥时，但参数值为空时，我点击发送，接口返回报错：缺少参数xxxxx
Reproduction Steps
当我们给接口新增一个参数密钥时，但参数值为空时  我点击Send ，接口返回报错：缺少参数xxxxx   但是我生成shell-->cURL 重新请求  一切正常🤔
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
10.0.0
What operating system are you using?
macOS
Operating System Version
macos
Installation method
官网下载
Last Known Working Insomnia version
No response

因与#7965 重复, 关闭此卡片.


Block opening storage UIs that are nested inside another

About the PR

Disables opening storage UIs if they are inside another storage UI.
Added a CVar for the nested container access.
Why / Balance

This makes storage a choice between more inventory space or faster access.
Technical details

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

add: Added a server setting to disable accessing nested storage UIs.

Concern: this will make searches painful for both parties

this will just make it even more clunky, maybe have it close the previous container instead?

This isn't a good choice for the players, especially when the tested system gets tweaks.
If we absolutely have to limit UIs, here's the possible alternatives:
1 - limit the amount of storage UIs on screen to 3.
For ex)
Bag open (1)
Box in bag open (2)
Toolbelt in belt slot open (3)
Now if someone has another box in their backpack, storage in their hand, etc, the 4th window should either close the 1st or last window opened.
Alternatively you could mimic ss13 - where one storage UI can be open at a time, but we would need something  to make that transition more smoother like a "go back to the previous storage" button.

This, combined with a reimplemented slot storage system, would be a total nightmare for security. You perform a search on John Greytide and discover his dufflebag contains 10 large briefcases, each with 10 cardboard boxes, each with 10 cigarette packs. Does he have the alleged energy dagger? you will find out the truth in 3 hours

This should definitely not be implemented how it is shown here.
At the very least, it should close the previous container, instead of refusing to open the new one.

Preventing the opening of storage within storage encourages people to ignore the problem and just ditch the container the stuff is in.  If I can't do that, I would just dump the contents into my bag so I wouldn't even have to open it, which over time will slowly shuffle every item around as i use them. Now, if someone needs the entire kit for something, I can't just give them the kit, I have to either go through my bag and drop every single healing item, which they now have to pick up, or give them my bag, removing my access to literally every other item I have for as long as it takes them, and leaving them to move the stuff.

no longer relevant


Expansion panel closes on data refresh

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Expansion panel should not close on data changes
What is the current behavior?
Expansion panel is closing after data is updated
What are the steps to reproduce?
http://plnkr.co/edit/KMgrqrb1gsOHK0AofCOf?p=preview
What is the use-case or motivation for changing an existing behavior?
Users shouldn't re-open the expansion panel when data is updating (e.g http request)
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 5.0.0
material 5.0.0
typescript 2.4.2
all browsers

This is expected behavior and due to you assigning a new array to packs. I would suggest looking into trackBy.
http://plnkr.co/edit/OA7SaaVBmeimsOHLDk60?p=preview

Closing as this is working as expected.
The expansion panel is not being closed but rather an entirely new expansion panel is being rendered and the old one is destroyed as the object is modified.  As @willshowell noted, you can use trackBy to perform the function you are looking for.

Write this following code you may solve this issue
ngOnInit() {
this.href = this.router.url;
console.log(this.href);
}
[expanded]="[this.href === 'routelink']"


German Translation

Hello,
if you want, i can offer to do the german translations for you. Just tell me what to do.
Best Wishes
Sascha

Oh, great!
You can copy english folder from resources/lang/en to resources/lang/de and translate the files contents.
To test it, you can change the config/app.php file:
    'locale' => env('APP_LOCALE', 'es'),
    'locales' => ['es', 'en'],
    'locale_system' => ['es' => 'es_ES.UTF-8', 'en' => 'en_US.UTF-8'],
    'fallback_locale' => 'es',

to
    'locale' => env('APP_LOCALE', 'de'),
    'locales' => ['es', 'en', 'de'],
    'locale_system' => ['es' => 'es_ES.UTF-8', 'en' => 'en_US.UTF-8', 'de' => 'de_DE.UTF-8'],
    'fallback_locale' => 'es',

As config is cached, you should delete the file bootstrap/cache/config.php.
Thanks!

ok, i'll try that

Whooha, i was not aware that there is so much to translate. This could take a few days, but i'm on the run :-)

I was able to trasnlate it faster than i thought. Attached you'll find a zip file with the translated files.
Best Wishes
Sascha
de.zip


Game makes system unresponse after staying long in lobby

Description
When keeping the game open for an hour while staying in lobby, windows becomes unresponsive with lagging mouse movement.
How to reproduce

Start Titanfall through northstar
Enter the multiplayer lobby
Stay there for an hour

Specs
Game

Titanfall 2 (Steam) (on hdd, using DGPU)

System

Windows 10 LTSC 2021 (from ssd)
Intel I7-7700HQ
16 GB DDR4 3200Mhz
NVIDIA GeForce 1050 TI Mobile
Seagate 256 NVME
Seagate 1TB 5400 RPM HDD

Notes

Titanfall 2 vanilla performs as expected
Northstar generates a lot of log information every second.
Are the hooks being reapplied constantly?

Attachments
nslog31-12-2021 17-35-31.txt

I'm wondering if there's any chance you could had a gamepad plugged in and something pushing its analog stick all that time? Gamepad interacts with the game even if it's minimized and not in focus

Closing as stale, if this is still an issue feel free to reopen


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #400 (c61ec1e) into main (2974dfe) will increase coverage by 12.36%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #400       +/-   ##
===========================================
+ Coverage   83.33%   95.69%   +12.36%
===========================================
  Files           2        1        -1
  Lines         126      395      +269
  Branches       31       53       +22
===========================================
+ Hits          105      378      +273
+ Misses         21       17        -4

Impacted Files
Coverage Δ

src/index.ts
95.69% <100.00%> (+13.69%)
:arrow_up:

example/src/main.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9bdf6...c61ec1e. Read the comment docs.


[BUG] Invalid message order in batch sending

After upgrading azure-messaging-servicebus lib from 7.0.1 to 7.3.0, I noticed that batch sending is reordering messages in Service Bus. I suppose this is due to the use of parallelStream() in the ServiceBusMessageBatch.sendInternal() method. This has been changed in the commit: https://github.com/Azure/azure-sdk-for-java/commit/a9b28ec39515b1aa112d6ef211cac2455d729afa#diff-bfbb3d6ac91c080eaa27ee29c12058246337099dcd205dc86a625dee08bfa17e.
I expect the order of the messages in the list for batch should be the same as in Service Bus.

@ki1729 could you take a look into this?

@grzegorzkalisz Changes are merged, and should be part of the March release

@grzegorzkalisz Changes are merged, and should be part of the March release

Thanks for your support!


⚠ Elibs has degraded performance

In da34dec, Elibs (https://elibs.unmer.ac.id) experienced degraded performance:

HTTP code: 200
Response time: 5081 ms

Resolved: Elibs performance has improved in ddeba44.


2019 Honda HRV EX-L carFw

Adding carFw for 2019 Honda HRV EX-L

Added in 6c80ceb18108dcb77bd5294b3ca62776da5adfc2


[NETBEANS-54] Module Review glassfish.eecommon

-no external library
-checked Rat report: everything has been relicensed to Apache, as this commit adds header to a java file that was missing header
-skimmed through module, did not notice additional problems

Should have been prefixed [NETBEANS-1074] Module Review.


[NTR] interalveolar septum neutrophil

Preferred term label:
interalveolar septum neutrophil
Synonyms
interalveolar septa neutrophil
neutrophil of interalveolar septum
neutrophil of interalveolar septa
Definition (free text, please give PubMed ID)
Any neutrophil that is found in the interalveolar septa
Parent term
neutrophil

These cells are circulating immune cells, not resident in tissue. Closing as new term not needed.


Upgrade to svgr 6

Ref https://github.com/gregberge/svgr/releases/tag/v6.0.0
This release bumped svgo internally which has a lot of fixes and less
dependencies.

Nice! Looks like this needs a rebase on main (and I guess the commits here can be squashed).

@iansu We are waiting on this pull request to fix nth check vulnerability. Can you please help us with ETA on this one.?

It has been two months

There are two PRs with update to newer version:

#12026
#12172

Any news?

@iansu @raix @mrmckeb anything missing from this PR? Would be great to install fewer dependencies...!


update netcore to 6, functions framework settings

@microsoft-github-policy-service agree [company="{your company}"]

Thanks @HeavyMachineGun for providing a fix to this project. I've recently taken ownership of this repo and made your same fix in parallel, so we won't be able to use your commit at this time. Thanks again for your help!


getStaticPropsForTina complicates setup

getStaticPropsForTina to me feels a bit unnecessary. Its role seems to be to make a request to the local API, as well as returning some of the arguments that were passed in.
Our current starter code:
export const getStaticProps = async ({ params }) => {
  const tinaProps = (await getStaticPropsForTina({
    query: `#graphql
      query BlogPostQuery($relativePath: String!) {
          // ...
      }
    `,
    variables: { relativePath: `${params.filename}.md` },
  })) as { data: { getPostsDocument: PostsDocument } };

  return {
    props: {
      ...tinaProps,
    },
  };
};

This to me feels a bit more clear about what getStaticProps is actually doing/returning:
export const getStaticProps = async ({ params }) => {

  const postRequestArgs = {
    query: `#graphql
      query BlogPostQuery($relativePath: String!) {
         // ...
      }
    `,
    variables: { relativePath: `${params.filename}.md` }
  }

  const post = new LocalClient().request(postRequestArgs)

  return {
    props: {
      post, // use this on your production page
      tinaArgs: postRequestArgs // needed for the Tina wrapper to re-request draft content client-side
    },
  };
})

The proposed solution also wraps all the tina stuff that gets sent to the frontend in a "tinaArgs" object, so it's clear what's for the production site, and what's for the frontend TinaCMScomponent.
Thoughts?

Also, it demonstrates that there's nothing Next-specific going on here. This proposed snippet could be run anywhere (alongside the graphql server)

In your example, we'd need some way of knowing that post was part of our live data, and I'm not sure this API is more clear. At least with getStaticPropsForTina there's an explicit nature to it so the user can just rely on us rather than worry about LocalClient and if they're composing things properly. Curious to hear more input on where the problems are.

post could be remapped to data within the client-side  provider. If you were using a catchall TinaCMS provider in a _app.tsx, you may want to call this variable data instead, but I don't think that affects my point about getStaticPropsForTina.

There is something Next-specific here, this wouldn't work in any non-SSG build context

If I understand correctly, getStaticPropsForTina does 2 things:

Request content from a LocalClient
Format a response with the graphql response, and the passed in arguments.

In your example, you're right that it's SSG-specific because under the hood it's using a static-only client that can't be configured. Since we've broken up the two responsibilities in my example, it's no longer next-specific, (as long as you're hitting an available server at the time of request).

Conceptually the getStaticPropsForTina was/is a good idea, however, simplifying the and unwrapping it will allow :

Less dependent on Next overall
Easy to extend
Give clarity about where and when certain things can be used.

Which IMO leans towards less friction for DX which is overall the most important factor.

I'm cool with this, but should we actually remove it? We can mark it as deprecated for now

We should deprecate over remove. We don't want to make breaking changes.

Made this PR ready for review: https://github.com/tinacms/tinacms.org/pull/1063

getStaticProps for Tina has been removed from the docs, so I think the only remaining things here are to:

[ ] Remove it from the originalstarter https://github.com/tinacms/tina-cloud-starter/tree/main
[ ] Tag it as deprecated in the code.

@jamespohalloran not sure if this is another remaining item, but I think the cli init is using getStaticPropsForTina in the generated demo/blog/[filename].js

Ah good catch, @jeffsee55 let me know if you want me to jump in and make a PR for either of those last items

The SDK is also generating this, so we'll want to remove that as well.


Fix locale to ISO 639-1 in index_gl.html

index_gl.html was submitted with a typo. Now its fixed and working.

Thanks so much for your contribution!  You rock, @anuf


[BUG] demo is not work

Describe the bug
ReactiveUI.Samples-main\winforms\demo2\WinForms.Reactive.Client
this demo is not work,no data
Steps To Reproduce

git clone https://github.com/reactiveui/ReactiveUI.Samples
2.go to dir  ReactiveUI.Samples-main\winforms\demo2\WinForms.Reactive.Client
3.click WinForms.Reactive.Client.csproj to open
4.run app

Expected behavior
work well
Screenshots

Environment

OS:      windows 10
Device:   dell notebook
Version:   19041.450
Working Version: 19041.450

Thanks for the issue. Please edit to bring back the full issue template otherwise gotta close this one.

See https://github.com/reactiveui/ReactiveUI.Samples/issues/new?assignees=&labels=bug&template=bug_report.md&title=[BUG]+Summary+of+item for an example

@glennawatson  issues have been fixed

Thankyou, I'll have a look later in the week. This sample was only recently added.

Hi @suc8899 can you try to remove
initialValue: Enumerable.Empty<ItemDto>()
From ItemsViewModel.cs, line 88 ?

@rallets  I have tried it, the problem is still not solved

@glennawatson not sure why, but now the code that was working, it throws an exception. It's related to the property being an IEnumerable, but the ListBox DataBinding is expecting a IList or IListSource. All the packages are up to date. I have a fix that consists in replacing IEnumerable to IList, but I'm wondering if you have any tips on what this can be related to, or if it's a smell of another problem.
I have sent a PR #542 that fixes the problem. @suc8899 if you want you can try that branch.
The exception is:
PropertyBinderImplementation: view.lstDetails.DataSource Binding received an Exception! - System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.ArgumentException: Complex DataBinding accepts as a data source either an IList or an IListSource. (Parameter 'value')
   at System.Windows.Forms.ListControl.set_DataSource(Object value)
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Span`1& arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
   at System.Reflection.RuntimeMethodInfo.InvokeOneParameter(Object obj, BindingFlags invokeAttr, Binder binder, Object parameter, CultureInfo culture)
   at System.Reflection.RuntimePropertyInfo.SetValue(Object obj, Object value, BindingFlags invokeAttr, Binder binder, Object[] index, CultureInfo culture)
   at System.Reflection.RuntimePropertyInfo.SetValue(Object obj, Object value, Object[] index)
   at ReactiveUI.PropertyBinderImplementation.<>c__DisplayClass11_0`3.<BindToDirect>g__SetThenGet|0(Object paramTarget, Object paramValue, Object[] paramParams) in /_/src/ReactiveUI/Bindings/Property/PropertyBinderImplementation.cs:line 296
   at ReactiveUI.PropertyBinderImplementation.<>c__DisplayClass11_0`3.<BindToDirect>b__7(<>f__AnonymousType0`2 x) in /_/src/ReactiveUI/Bindings/Property/PropertyBinderImplementation.cs:line 318
   at System.Reactive.Linq.ObservableImpl.Select`2.Selector._.OnNext(TSource value) in /_/Rx.NET/Source/src/System.Reactive/Linq/Observable/Select.cs:line 39

Possibly an update with .NET 6? Seems to be a hard requirement by winforms anyway.
Thanks for your fix, @suc8899 if you can confirm if that merge fixes it for you?

It's work ok,IEnumerable change to IList,thank you @rallets  @glennawatson

Thanks @suc8899  closing the issue now


chat: reactions take several seconds to appear.

Describe the bug, optionally with screenshots
When I do an icon reaction to a posting, it takes several seconds to appear.  This feels klunky.
Expected behavior
I am told that I am making a request for optimistic reactions, though I am unfamiliar with that terminology.
I expect reactions to feel instant on the user side.
While we are at it, it is sensible to point out that a similar delay in the disappearance of the 'unread items' dot for several seconds, even after all items have been read, is similarly unsatisfying.
Additional context:

Ship type (comet/moon/planet/star/galaxy)
Instance type (Tlon-hosted/self-hosted with Port/CLI)
OS/browser (Safari on MacOS, Chrome on Windows, Firefox on Linux, etc.)

@wbsquared, in case you're interested in the terminology:

I am told that I am making a request for optimistic reactions, though I am unfamiliar with that terminology.

"Optimistic" here refers to showing you a result of your in-browser action immediately (and then processing the action that you've just made on the server/urbit afterwards). The opposite is: "I click a button - but I don't see any change - and this action goes to the server, gets processed, and once the result comes back, I finally see it".
So in this case, it seems like the action "click emoji reaction in the browser" gets sent off to your urbit to process and make sure it's stored and whatnot, then once its done you see the emoji pop up.


Migrate CRFEntityExtractor to GraphComponent interface

Overview of the Solution:
Adapt the CRFEntityExtractor  to the new GraphComponent interface.
See the implementation proposal for further details.

adapt create and load functions to new signatures.
implement required_packages and supported_languages.
adapt persistence.
split train into train and process_training_data (process the training data for the next components in the pipeline).
support multiple messages in process (make sure to handle empty messages).
Inherit from both GraphComponent and EntityExtractorMixin (instead of the old EntityExtractor).

Process to avoiding breaking the CI
Use the approach showcased in the TEDPolicy migration to avoid breaking the test suite.
Main points:

Rename old files with a prefix i.e. from some_component.py to _some_component.py.
make the changes in the current file e.g. some_component.py.
In some_component.py import the old component from _some_component.py and assign like SomeComponent = SomeComponent
Rename the new component in _some_component.py to SomeComponentGraphComponent
Adapt the old unit tests, i.e. test_some_component.py to test SomeComponentGraphComponent.

Definition of Done:

[ ] CRFEntityExtractor adapted to the new GraphComponent interface.
[ ] Unit tests are adapted to adapted component.
[ ] Other tests (integration tests, etc.) don't break (because they'd (for now) still use the old component implementation).

@joejuzl This component has a function_dict attribute that doesn't quite look like it should belong to default config. Should I create a separate private property or a static method that returns this dict?

@joejuzl This component has a function_dict attribute that doesn't quite look like it should belong to default config. Should I create a separate private property or a static method that returns this dict?

It looks like it's not in defaults - it's just at class level.


added emr-on-eks module and made it generic

Issue #, if available:
Description of changes:

added emr-on-eks module and made it generic
tested it on LocalZones

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: b31122656df68438b86d5a5858b671d01db13a67
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: a2c55aa7fc46f2d0e89f2b35d7c8e1021200bfc0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: b76ed821e456136e79631da8cf0c5a370e07ea48
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: e0c1970b123631183871d1ab4466d1f93d3601da
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: 3ab94ff5d80ede11e1c6bb1f3734b3f4bc762259
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: 9df4f0f72414d2fbd82209722fb0b8adae679eab
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: b6ee84f44783669f2404a48fc225a79e529c5d0a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: ba532656e6a984a3310a8969ec7309a6a090cd78
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


[ios] OnPressOut fires instantly

I ran into a problem with touch events on svg shapes.
When touched on a real ios phone OnPressIn and OnPressOut events both fire instantly. OnPress mostly not at all.
I need there two events to be separated by users' intention. It works with mouse in ios simulator, and android works both simulated and on real device.
I suspect it has something to do with some micro movement which on ios screen happens constantly.
Can this be fixed to be consistent with android?
Thank you.

I also have same same proplem!

I'm also experiencing the same issue. Interesting thing is that on older phones (iPhone 6) seems to be working fine , how ever on iPhone 7 plus and newer issue occurs.

I have this issue on a Samsung Galaxy S7 edge (SM-G935F) running Android 8.0.0 as well... Duration between onPressIn and onPressOut is between 10ms and 30ms most times...

I think I have (gesture) interactions between native animated transforms and normal svg transforms working correctly now as well: https://github.com/react-native-community/react-native-svg/commit/8c05da043dea3f8d04420c2d7c9c11733e22258b

@flogy Please open another issue for android with a full reproduction. This is probably resolved now. Comment or reopen otherwise.

This problem is still occurring for me on an iPhone X (both physical device and the iOS simulator). The problem does not occur in the simulator using a iPhone SE (I don't have a physical iPhone SE to test on).
I have noticed the problem while attempting to use victory native's tooltips on a VictoryBar chart.
I am using react-native-svg 8.0.10 and victory-native 31.0.0.

@akepecs can you provide a repro? Either expo or something that can be cloned and run as is

I still had the issue that onPressOut fires immediately with Victory Pie on ios for iPhone 6S plus, 7, x (SE, 5S and 6 were fine), with victory-native 32.0.2, React Native 0.55.1 and react-native-svg 6.5.3.
I solved it in my code by replacing onPressOut with onResponderRelease.
onPressIn was fine.
Maybe it can help someone?


Showing APY

Got some user feedback that they would like to see the APY of the validators.

As a crypto asset owner, I would prefer to see the APY directly from each validator. I would also like to see my weighted APY from all over my delegations. For example, I have delegated 50% tokens to validator A with 30% APY and 50% of tokens to validator B with 40% APY. My weighted APY should be 35%.
APY should be calculated with several on-chain parameters.
APY = inflation / (delegated tokens / total supply) * (target block time / real time block time) * (1 - validator's commission)

However, this may encourage the "race to 0% commission" problem. How can we balance showing the APY while also suggesting token hodlers to support decentralization even if they will have slightly fewer APY in average?

The APY display issue is also related to how we display the top 34% voting power validators mention in https://github.com/forbole/big-dipper-2.0-cosmos/issues/506


[Dropdown] Search In-Menu Should Open With Keyboard

Search In-Menu dropdowns can't be opened by keyboard users on tab as it just skips to the next input.
If  a tabindex is manually placed on the dropdown then the dropdown opens and closes straight away.
Fiddle

I believe has.search on this like should be is.searchSelection
https://github.com/Semantic-Org/Semantic-UI/blob/master/src/definitions/modules/dropdown.js#L2186

Thanks for the quick reply.
I changed the code to is.searchSelection and it does now add a tabindex="0" to the dropdown, but then it immediately closes the dropdown when you try and open it, like the last dropdown on the fiddle with a manually added tabinddex. It looks like it is closing the dropdown when the search input gets focus.

I think I have also been bitten by this. JSFiddle & repro instructions
Makes a bad experience for power users.

This is pretty bad

Fixed in next


fontSize stays at 12

Hello,
Whether I change config.fontSize or config.verminal.fontSize, the font size sticks at 12 as defined in https://github.com/defringe/verminal/blob/master/index.js#L17.
Any idea of what is happening?
Here is my config:
// Future versions of Hyper may add additional config options,
// which will not automatically be merged into this file.
// See https://hyper.is#cfg for all currently supported options.

module.exports = {
  config: {
    // choose either `'stable'` for receiving highly polished,
    // or `'canary'` for less polished but more frequent updates
    updateChannel: 'stable',

    // default font size in pixels for all tabs
    fontSize: 16,

    // font family with optional fallbacks
    fontFamily: 'Menlo, "DejaVu Sans Mono", Consolas, "Lucida Console", monospace',

    // default font weight: 'normal' or 'bold'
    fontWeight: 'normal',

    // font weight for bold characters: 'normal' or 'bold'
    fontWeightBold: 'bold',

    // terminal cursor background color and opacity (hex, rgb, hsl, hsv, hwb or cmyk)
    cursorColor: 'rgba(248,28,229,0.8)',

    // terminal text color under BLOCK cursor
    cursorAccentColor: '#000',

    // `'BEAM'` for |, `'UNDERLINE'` for _, `'BLOCK'` for █
    cursorShape: 'BLOCK',

    // set to `true` (without backticks and without quotes) for blinking cursor
    cursorBlink: false,

    // color of the text
    foregroundColor: '#fff',

    // terminal background color
    // opacity is only supported on macOS
    backgroundColor: '#000',

    // terminal selection color
    selectionColor: 'rgba(248,28,229,0.3)',

    // border color (window, tabs)
    borderColor: '#333',

    // custom CSS to embed in the main window
    css: '',

    // custom CSS to embed in the terminal window
    termCSS: '',

    // if you're using a Linux setup which show native menus, set to false
    // default: `true` on Linux, `true` on Windows, ignored on macOS
    showHamburgerMenu: '',

    // set to `false` (without backticks and without quotes) if you want to hide the minimize, maximize and close buttons
    // additionally, set to `'left'` if you want them on the left, like in Ubuntu
    // default: `true` (without backticks and without quotes) on Windows and Linux, ignored on macOS
    showWindowControls: '',

    // custom padding (CSS format, i.e.: `top right bottom left`)
    padding: '12px 14px',

    // the full list. if you're going to provide the full color palette,
    // including the 6 x 6 color cubes and the grayscale map, just provide
    // an array here instead of a color map object
    colors: {
      black: '#000000',
      red: '#C51E14',
      green: '#1DC121',
      yellow: '#C7C329',
      blue: '#0A2FC4',
      magenta: '#C839C5',
      cyan: '#20C5C6',
      white: '#C7C7C7',
      lightBlack: '#686868',
      lightRed: '#FD6F6B',
      lightGreen: '#67F86F',
      lightYellow: '#FFFA72',
      lightBlue: '#6A76FB',
      lightMagenta: '#FD7CFC',
      lightCyan: '#68FDFE',
      lightWhite: '#FFFFFF',
    },

    // the shell to run when spawning a new session (i.e. /usr/local/bin/fish)
    // if left empty, your system's login shell will be used by default
    //
    // Windows
    // - Make sure to use a full path if the binary name doesn't work
    // - Remove `--login` in shellArgs
    //
    // Bash on Windows
    // - Example: `C:\\Windows\\System32\\bash.exe`
    //
    // PowerShell on Windows
    // - Example: `C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\powershell.exe`
    shell: '',

    // for setting shell arguments (i.e. for using interactive shellArgs: `['-i']`)
    // by default `['--login']` will be used
    shellArgs: ['--login'],

    // for environment variables
    env: {},

    // set to `false` for no bell
    bell: 'SOUND',

    // if `true` (without backticks and without quotes), selected text will automatically be copied to the clipboard
    copyOnSelect: false,

    // if `true` (without backticks and without quotes), hyper will be set as the default protocol client for SSH
    defaultSSHApp: true,

    // if `true` (without backticks and without quotes), on right click selected text will be copied or pasted if no
    // selection is present (`true` by default on Windows and disables the context menu feature)
    // quickEdit: true,

    // URL to custom bell
    // bellSoundURL: 'http://example.com/bell.mp3',

    // for advanced config flags please refer to https://hyper.is/#cfg
  },

  // a list of plugins to fetch and install from npm
  // format: [@org/]project[#version]
  // examples:
  //   `hyperpower`
  //   `@company/project`
  //   `project#1.0.1`
  plugins: [
    "hyperterm-tabs",
    "hypercwd",
    "hyper-statusline",
    "verminal"
  ],

  verminal: {
    fontSize: 16,
  },

  // in development, you can create a directory under
  // `~/.hyper_plugins/local/` and include it here
  // to load it and avoid it being `npm install`ed
  localPlugins: [],

  keymaps: {
    // Example
    // 'window:devtools': 'cmd+alt+o',
  },
};

In any case, thanks a lot for verminal.

I can't overwrite the font color either.

I have the same problem with Hyper 2.1.0-canary.2 for Mac OS

Write here!
@@ -123,6 +123,11 @@
     // bellSoundURL: 'http://example.com/bell.mp3',

     // for advanced config flags please refer to https://hyper.is/#cfg
+
+    // Here!
+    verminal: {
+      fontSize: 16,
+    },
   },

   // a list of plugins to fetch and install from npm
@@ -138,10 +143,6 @@
     "verminal"
   ],

-  verminal: {
-    fontSize: 16,
-  },
-
   // in development, you can create a directory under
   // `~/.hyper_plugins/local/` and include it here
   // to load it and avoid it being `npm install`ed

Thanks :)

I have tried what riaf has suggested and refreshed and still get font size 12

Write here!
@@ -123,6 +123,11 @@
     // bellSoundURL: 'http://example.com/bell.mp3',

     // for advanced config flags please refer to https://hyper.is/#cfg
+
+    // Here!
+    verminal: {
+      fontSize: 16,
+    },
   },

   // a list of plugins to fetch and install from npm
@@ -138,10 +143,6 @@
     "verminal"
   ],

-  verminal: {
-    fontSize: 16,
-  },
-
   // in development, you can create a directory under
   // `~/.hyper_plugins/local/` and include it here
   // to load it and avoid it being `npm install`ed

Thanks! This worked. Pretty annoying that it doesn't take the size from the default:
// default font size in pixels for all tabs
fontSize: 18,


Changes to the system for featured profiles

Changed featured profiles to use UUID instead of usernames
Changed the system to export into a JSON file instead of a database

Fixes #1348

But why is it needed to update them? nothing gets updated... it's just a static object no? 😕 🤔
The whole /scripts/update-featured-profiles.js) seems useless to me, no?

What about skins are those still going to auto update?

What about skins are those still going to auto update?

Yeah they are from crafatar, so external

What about skins are those still going to auto update?

Yeah they are from crafatar, so external

Good point

But why is it needed to update them? nothing gets updated... it's just a static object no? 😕 🤔
The whole /scripts/update-featured-profiles.js) seems useless to me, no?

You need to update the usernames somehow. Also that's why it only runs on start.

But why is it needed to update them? nothing gets updated... it's just a static object no? 😕 🤔
The whole /scripts/update-featured-profiles.js) seems useless to me, no?

You need to update the usernames and emojis somehow. Also that's why it only runs on start, it only needs to get updated user info and that's it.

oh right didn't think of that

#1358


[BugFix] Acquire rowsets at querying (backport #13830)

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Problem Summary(Required) ：

This is cherry-picked from #13830.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[x] 2.3
[x] 2.2

run all

run starrocks_be_unittest


[WIP] Tess CBV corrector

Greetings!
This is a first rough version of a CBVCorrector for LightKurve! This is definitely a WORK IN PROGRESS but enough functionality is implemented to demonstrate some basic methods, and get some feedback.
The main tools created so far are:

get_cbvs -- retrieves the requested Kepler/K2/TESS Cotrending Basis Vectors from MAST and creates a CotrendingBasisVectors object.

CotrendingBasisVectors -- Stores Cotrending Basis Vectors (CBVs) for the Kepler/K2/TESS missions.

CBVCorrector -- class to perform a correction on a LightCurve object utilizing the CBVs via the RegressionCorrector class. Right now it simply does Least-Squares correction; that will change!

Attached is a PDF of a Jupyter notebook demonstrating functionality. (Apparently you can't attach Jupyter notebooks to pull requests so converted to PDF)
CBVCorrector Demonstrator.pdf
The more I look at this the more I realize I am not creating a "CBV Corrector" but a wrapper for RegressionCorrector that happens to be able to load in the CBVs, along with other design matrices. In time, the class will allow for sophisticated optimization techniques. So, perhaps it should not be called "CBVCorrector" but a more generic name, perhaps "OptimizationCorrector" or something to emphasize the optimization techniques to be used, not just that it uses the CBVs. ...Or, just move it all into RegressionCorrector. I welcome feedback on this!
There is a lot more that can be done:

Finish code documentation
Write Unit Tests
Develop Goodness Metrics to assess performance
Allow user to specify signal bands they care about for creating goodness metrics
Use goodness metrics as a prior regularizing term
Add other prior options
Add L1 Norm (Lasso) and L2 Norm (Ridge Regression) regularizers
Add methods to band split the light curves and perform correction in specific bands
...And even more!

This won't all be completed anytime soon. I will begin by trying to develop some goodness metrics to assess over- and under-fitting, based on what is calculated in PDC.

Hi @barentsen, I want to give you an update on my work. I've been cleaning up the code a lot. But I've been stuck trying to get the goodness metrics working properly with specified band passes (I.e. when the user only cares about signal quality within a band pass), but I am not satisfied with how it behaves. So, for the first release this functionality might need to be disabled. The user will have to settle for broad-band goodness metrics for now.
One big question for you: I would like the over- and under-fitting goodness metrics available for general use (there's nothing about them that are specific to using the CBVs). Right now, they are buried as methods within the cbvCorrector object. I see a couple ways to make them publicly available:

Static methods within the classes. If called on their own then the user would have to supply all the information normally buried within the object.
Completely separate functions within the module. This would expose a lot of parameters to the user which they would have to pass to the function on every call. This all should normally never be seen by the user.
Have them be methods within the class but have wrapper functions that allow a user to measure the goodness for any light curve, the wrapper would then create a cbvCorrector object and call the methods.
Create a new class called lightCurveGoodnessMetric, containing the functionality.

I'm inclined to go with 4). One main reason is because the under-fitting metric requires downloading a large number of neighboring light curves. That would be slow to do every time you call the function so the way I handle that is store the data in the cbvCorrector object. Subsequent calls to the metric are then very fast. This same convenience could be via a separate lightCurveGoodnessMetric class, which the user first instantiates. So, unless you have a strong desire for me to not create another class, I was going to create a lightCurveGoodnessMetric class. I am thinking it could reside within the cbvCorrector module.
Please let me know if you have an opinion on this! I'll try to get my code finished as soon as I can to get a release out there.
Jeff

@jcsmithhere Can you add scikit-learn as an optional dependency, here:
https://github.com/jcsmithhere/lightkurve/blob/99991ac84d97c63a08867b45d0ab1739bcf5c823/setup.py#L27-L29
This will be important to get the unit tests to pass in GitHub's containers.

Closing this pull request. See #826 for the actual PR.


fix(goal_planner): fix updateCollisionCheckDebugMap timing in checkSafetyWithIntegralPredictedPolygon

Description

the behavior is not changed.
just modify updateCollisionCheckDebugMap call timing
Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 could you approve?


Installing Python library on Raspbian

Hi guys,
I'm trying to install the Google Speech Recognition Python client on my Raspberry Pi, but have been unable to do so as one of the dependencies is the GRPC library which does not seem to build on the Pi. It gets stuck on the following line:
Running setup.py bdist_wheel for grpcio...
and doesn't move forward until I cancel. Have the same issue when I try to pip install grpcio separately.
Is there any way around this?
Thanks,
Aazim.

Hi,
compiling on the PI can be very slow, so be patient, dont cancle and wait.
As long as there is no error everything should be fine.

@ProLoDs Oh okay, I've started it again and will wait for it to complete and report back - thanks!

@ProLoDs Would it be possible to provide wheels for this?

It worked! Took a while, but it did :) thank you @ProLoDs for the help!

@kpayson64 This customer installed successfully, but there is still an issue here. Would it be possible to provide ARM wheels?
GRPC installation can represent a significant usability issue for our customers; if possible, it would be nice to make this smoother, and we have the ability to do so.

@lukesneeringer
I've opened #10890.

Thanks!


How to use as drag and drop

Hi
how can i use this as a drag and drop alternative
Any example on how to move elements by dragging from one node to another
thanks

+1


Add CODEOWNERS and auto issue assignment

Summary

Add CODEOWNERS file
Add auto issue assignment pipeline to respond to open issues

How to test

Checklist

[ ] I have added unit tests to cover my changes.
[ ] I have added integration tests to cover my changes.
[ ] I have added the description of my changes into CHANGELOG.
[ ] I have updated the documentation accordingly

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below).

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Sorry, auto-assignment is not working (https://github.com/openvinotoolkit/datumaro/actions/runs/4572213153). So, I temporarily disabled this action from running until I fix it.


'desired_range' is not working, 'permitted_range' returns value out of the range, flexibility of 'permitted_range'

Hi, I have the three questions.
Firstly, I get this error when I try to use 'desired_range'.

Secondly, sometimes permitted_range cannot ensure the  controlled feature is in the range. For instance, the second image shows that the age is not in the range of 23 and 24.
Lastly, it seems that I have to set the range all for continuous features when using 'permitted_range'. For instance, in the second image I have to control another continuous feature 'hours_per_week' although I only want to control the 'age' feature.
Otherwise, I will get a key error because I only control one continuous feature-'age'.
How can I only control one continuous feature by DICE?

Thank you very much

@HengQuan1997  in my understanding desired_range should be used only for regression problems and desired_class should be used only in case of classification problems. You shouldn't set both. @amit-sharma  is that understanding correct?

@HengQuan1997 in my understanding desired_range should be used only for regression problems and desired_class should be used only in case of classification problems. You shouldn't set both. @amit-sharma is that understanding correct?

Hi @gaugup
Thank you for the reply. You are correct regarding the 'desired range' function. desired_range should be used only for regression problems.

@HengQuan1997, for the second and the third scenario could you share the sample code/notebook?

@HengQuan1997 can you also confirm the version of DiCE you are using? The third issue might be due to using an earlier version---the latest version is 0.5.

@HengQuan1997 can you also confirm the version of DiCE you are using? The third issue might be due to using an earlier version---the latest version is 0.5.

Hi, You are correct. I think that I did not use the latest version of 0.5.

@HengQuan1997 are all your questions answered or are you still facing trouble using dice-ml? If your questions have been answered, then maybe we can close this issue.

Closing this issue due to no activity.


Firefox crash with fcitx5 after closing one of multiple firefox windows

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit 1d40af64d352bd5a87c7d53a52707fc5cfc6940e  (text-input-v3: move to new impl).
Date: Thu Apr 25 18:27:44 2024
Tag: v0.39.1-83-g1d40af64, commits: 4543

flags: (if any)

System Information:
System name: Linux
Node name: pekin
Release: 6.8.9-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Thu, 02 May 2024 17:49:46 +0000

GPU information:
0a:00.0 VGA compatible controller [0300]: Intel Corporation DG2 [Arc A750] [8086:56a1] (rev 08) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

Bug or Regression?
Bug
Description
First bad commit: https://github.com/hyprwm/Hyprland/commit/1d40af64d352bd5a87c7d53a52707fc5cfc6940e
Refocusing a firefox window after closing another causes all firefox windows to crash. Only occurs with fcitx5. Present up to latest commit, https://github.com/hyprwm/Hyprland/commit/40201a760acd7c5ca10f27e7d0fdeb71c20df89f.
How to reproduce
With fcitx5 5.1.9

open firefox in current workspace
go to another workspace
open firefox in new workspace
close firefox in new workspace
go back to old workspace -> crash

Crash reports, logs, images, videos
No response

you mean firefox crashes? It surely doesn't crash to me.
can you attach the logs of firefox with WAYLAND_DEBUG=1?

yeah firefox crashes.
window1_stderr.txt
window1_stdout.txt
window2_stderr.txt
here are the files. window 2 has no stdout.
i should note that this doesn't occur when i open firefox through terminal with the terminal window on the same workspace. i think this is because after firefox is closed, the terminal window becomes focused before i switch back to the other workspace with firefox.
to obtain these logs, i left the terminal windows separate from the firefox windows, so each firefox window was in its own workspace.

Can confirm it happens to me as well. Setting the GTK_IM_MODULE environment variable to fcitx seems to have fixed this issue for me for now (as well as some random fcitx5 crashes I was getting). I don't know if this is the same issue as fcitx/fcitx5#1039, but this is where I got the fix from

odd, the logs dont show anything is amiss in the wl communication.

Setting the GTK_IM_MODULE environment variable to fcitx seems to have fixed this issue for me for now (as well as some random fcitx5 crashes I was getting)

right, I set that too and it works just fine.

Never tried without that. What would you even set it to?

Nothing, I had it unset. For some reason, whenever it is set, I get the following notification on Hyprland startup.

Detect GTK_IM_MODULE being set and Wayland Input method frontend is working. It is recommended to unset GTK_IM_MODULE and use Wayland input method frontend instead. For more details see https://fcitx-im.org/wiki/Using_Fcitx_5_on_Wayland

Everything seemed to work fine without the environment variable (until now) so I didn't bother setting it

hm. Any other app does this?

Not sure I understand your question. If it's about whether any app other than fcitx5 sends a notification on startup when some environment variable is set, the answer is no. If it's about whether any app other than Firefox crashes, I haven't encountered any. fcitx5 is the only input method I've ever used though, I haven't tried anything else.

Afaik GTK_IM_MODULE makes the app talk directly to input method and not via compositor

I was also experiencing this issue, however it seems to have resolved for me when I updated this morning to commit d1ad490. I'm unsure what specific commit between having this issue and that one resolved it, but it doesn't seem to happen to me anymore, at least.

I was also experiencing this issue, however it seems to have resolved for me when I updated this morning to commit d1ad490. I'm unsure what specific commit resolved it as I updated from one the other day, but it doesn't seem to happen to me anymore, at least.

tested just now, still reproducible w/ e4e84064f2d07810e0c150bce1369a0a00503e9a

Also having this :/

The behaviour had returned for me after the commit I mentioned above, though I have now gone back to the version in the Arch repos instead of -git (where the issue is still present fwiw).
One workaround I have found is manually dragging the window back into Firefox, and then closing it, doing that hasn't caused a crash for me at all.

GTK_IM_MODULE fixed it for me but now Hyprland randomly crashes

if on git, check pinned issues

This issue seems to have been fixed with one of the rewrites or a Firefox update or something


Add caching to GitHub Actions workflows

This commit adds caching for the cargo registry, git cache, and target
directory of pre-built dependencies for the root workspace, fuzz
workspace, and spec-runner workspace.
These changes are made for the CI and rustdoc workflows.
These changes should speed up CI iterations significantly. In the
playground repo where these actions steps are cribbed from, this led for
a 50% reduction in build times.

macOS is busted and the cache is hundreds of megabytes. Closing as not worth it.

macOS is busted and the cache is hundreds of megabytes. Closing as not worth it.

macOS cache corruption: https://github.com/actions/cache/issues/403

macOS cache corruption: https://github.com/actions/cache/issues/403


Last stable 1.6 is OK

Note that fix done in #227 based on issue #226 forces reinstall with latest stable django on 1.6, i.e. 1.6.11. This PR fixes that.

Good catch!


Document supported digest functions

I'm taking over #4979 on @kroeckx request.  This PR is simply his commit plus a fixup commit.

Merged.
4b7c6385f779e92ffcd76159b03b4dac301e93e7 Document supported digest functions


Display a running diff in the object history list page

Description
Add a column to the _object_history_list.html template that displays a table of the specific field changes made in each history object in the list (i.e for each item in the _object_history_list display the item.diff_against(previous_item)
Related Issue
https://github.com/jazzband/django-simple-history/issues/1308
Motivation and Context
This is a new feature, that I think makes the product much more helpful in tracking the changes in an object. It allows the user to see what changes were made in each history object, and allows browsing of changes, and makes it much easier to track down a specific change in the history. This is a feature the admin team for our website asked me to add, and it seems like a nice piece of functionality to add back to the codebase. I'm very happy to take suggestions on ways I can approve this, and will go through the testing and linting etc if people like the suggestion
How Has This Been Tested?
I have only tested manually for now, I wanted to get feedback on the idea before I went too far with the changes or testing
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have run the pre-commit run command to format and lint.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have added my name and/or github handle to AUTHORS.rst
[x] I have added my change to CHANGES.rst
[ ] All new and existing tests passed.

Thank you for your contribution, this is definitely wanted and useful! 😄 However, #1128 already implements a similar solution, but with simple, unordered lists instead of tables. (I personally think that nested tables have a tendency to make the page look more cluttered and disorganized - even if it would technically have been more structured.) So if that PR gets merged, I'll close this. Feel free to chime in on the other PR in case you think something's missing 🙂

Hey ddabble,
Thanks, that solution looks great. Remarkably similar to my solution in fact, haha! Including a number of other changes I was going to make too.
I looked through the issues to find someone else talking about a similar solution and couldn't find anything, I should have looked through the merge requests as well. I'll close this MR, and just contribute to the other one.
Thanks,
David


LLM Model updates

Description

Set the correct token limits for default models
Convert some default models to custom models

I think default models should generally not reference specific model instances eg. o1-preview-2024-09-12 since these models get replaced quite regularly.

Remove some default models that aren't being used
Add groq and perplexity

I have run the migration on a copy of the prod DB successfully.

Codecov Report
Attention: Patch coverage is 93.83886% with 13 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

...ce_providers/migrations/0021_migrate_llm_models.py
74.07%
7 Missing :warning:

apps/service_providers/models.py
85.00%
3 Missing :warning:

...ps/service_providers/llm_service/default_models.py
98.33%
1 Missing :warning:

...pps/service_providers/tests/test_default_models.py
98.18%
1 Missing :warning:

apps/utils/deletion.py
95.45%
1 Missing :warning:

Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!


How to shutdown the dir_monitor object in order to allow the io_service to exit the .run loop?

If you take the example test program test_running.cpp and add a asio/signal_set handler to trap Ctrl-C there doesn't appear to be a way to remove the async_monitor operation thus io_service.run() never exits.
In my application our Ctrl-C handler gracefully tells all asio io_objects (timers, sockets) to "shutdown".  Then the io_service exits once all the handlers have executed and the program drops out of the bottom of main.
Even calling remove_directory in the Ctrl-C handler appears to keep the work on the queue.

Hmm, I'm pretty sure you can just stop monitoring the directories and it should not add any work if it's not doing anything.
I need to refresh my memory though, it's been a while.


Author doesn't display well with ArXiv

I have subscribed to the RSS feed https://arxiv.org/rss/cs.
The author names do not display correctly. For example it display
Vahid Moosavi
instead of simply
Vahid Moosavi.
I tested that with Vienna 3.1.14 on an iMac with OS X El Capitan 10.11.6.

The problem is on their side. In the XML file, one can find :
<dc:creator> <a href="http://arxiv.org/find/cs/1/au:+Luo_T/0/1/0/all/0/1">Tie Luo</a>, <a href="http://arxiv.org/find/cs/1/au:+Zeynalvand_L/0/1/0/all/0/1">Leonit Zeynalvand</a></dc:creator>

Thanks for your answer. I contacted ArXiv administrators. They suggested me to try adding the version command to the feed url, so
http://arxiv.org/rss/cs?version=0.91
or:
http://arxiv.org/rss/cs?version=2.0.
Doing this with Vienna 3.1.14 results in both cases not showing anything in the author field.

I tried with an other reader (feedly.com). https://arxiv.org/rss/cs doesn't work for the authors, but both http://arxiv.org/rss/cs?version=0.91 and http://arxiv.org/rss/cs?version=2.0 work perfectly fine.


extensions: pull from github in OSS build

Fixes https://github.com/microsoft/vscode-internalbacklog/issues/2676
Pulls from Github releases unless the marketplace URL is set in the product.json.

Assigning to @joaomoreno as he owns this code.

Resolves #141340.


Add ability to edit existing queues

Useful if location changes, for example. Allows us to update queue information without wiping all existing questions.

Want to make sure I understand the issue correctly, I assume this refers to edit queue's title and/or locations right?

Yep - similar to how we can edit questions. Much of the code will probably be similar!

I see, thx!


NoClassDefFoundError: com/google/common/io/Resources

This is occurring in the tests for the newly separated mariadb module, using v1.4.0 of Testcontainers as the parent version.
See https://travis-ci.org/testcontainers/testcontainers-java-module-mariadb#L847
I think we have an undeclared dependency on Guava inside ContainerDatabaseDriver:
                URL resource = Resources.getResource(initScriptPath);
                String sql = Resources.toString(resource, Charsets.UTF_8);

Since we're trying to get rid of Guava because of its implications for dependency clashes, I'd say we should replace this with a fairly trivial non-Guava implementation.

Just checked, the jdbc module has Guava as a provided dependency but it's no longer being shaded in, hence breakage.

@rnorth
Damn! I hate Maven >_<
Let's release it as 1.4.1 hotfix, will do the change

Should be fixed in #399
@rnorth can you try it (with jitpack) in MariaDB module?


Feature/on schedule job callback

Hi @marrrcin
Following issue #76 and your comment on PR #77,
here is a proposed implementation for the --on-job-scheduled parameter.
To use it, you could for example create the following function:
#src/mymodule/myfuncs.py
def mycallback(job):
    click.echo(job.name)

and then run kedro azureml run --on-job-scheduled mymodule.myfuncs:mycallback
I took inspiration from the way uvicorn allows you to launch an application (uvicorn main:app) so the function is specified after a colon.
Note that I am not really happy with the way I implemented the unit tests so if you have better ideas, that would be great.

I updated the code based on your remarks.

Merged, thanks for this feature!


Changing quality should clear the cached video if the quality has been increased

Maybe this should be rather in the video player repo or is a duplicate, sorry in that case. 😅
Is your feature request related to a problem? Please describe.
The player usually starts using the "Auto" mode and changing it will not clear the already played cached video out. I have seen people complain about why changing to 1080p doesn't improve the quality of the video and I think it's caused because it doesn't remove the cached video data and still uses the lower quality instead of the 1080p.
It's not like changing the quality is not working, but if I change it 10 seconds into the video and want to see the first 10 seconds in 1080p, I basicially can't, since it will force me to watch it in 144p/480p.
I have seen feedback from both creators and users that they think we're not worth it as a platform because of the low quality video we're delivering (yeah, these people overdramatize, but still), I know that it's not true, but people usually don't click around or try stuff and will just complain or leave.
Describe the solution you'd like
Clear the cached video out if the quality is changed to a higher resolution.
Describe alternatives you've considered
Auto Quality could start at 1080p and go down to lower resolutions if it has issues with loading instead of going up to higher resolutions.
Additional context
POV: trying to watch the first 5 seconds of a video in 1080p:
https://user-images.githubusercontent.com/44294954/161297064-28ef00cf-3a95-466c-810b-c882ae964b68.mp4

Don't think this is a big deal and don't think it's possible without resetting the entire video player from scratch, otherwise there's a trade off with having the video buffer / load (with spinner) when switched : https://github.com/videojs/http-streaming/pull/235/commits/9219955afa8c3858905c6aaef712faa925a346e1 . Don't think most people switch and then try to go back either, never done that personally.
We do have another issue to save and set quality setting to a user's preference, so that should help in most cases.

Filed https://github.com/videojs/http-streaming/issues/1263 in case they want to add that also.


Provide only one arg to callback from unmarshalSecp256k1PrivateKey

In unmarshalSecp256k1PrivateKey, supply only the private key to the callback, as the API stipulates.
Fixes #7.

@jacobheun @vasco-santos Can we merge this? It's necessary for js-libp2p-daemon to be able to load Secp256k1 keys.

Thanks @jacobheun!

@jacobheun gave you publish perms instead :)


All day events in Day and Week View

Do you want to request a feature or report a bug?
Feature request
What's the current behavior?
When calendar has only "All day" events, the calendar (in week and day view) shows the events in "all day" section, but leaves the time section empty below.
What's the expected behavior?
I would like to be able to show only the "all day" view as the rest is just white space for me.

hey there! We probably won't add that to the library here since it's pretty specific to your use case, but you can accomplish it with custom views and reusing some of the libraries constituent components

Hey, thanks for the response.
Thanks for the hint to custom views i missed the part where we could pass Components.
However, I don't think that this is really a specific thing as all day events are already supported by react-big-calendar.
Maybe a boolean passed to TimeGrid?


Dummy ignition::rendering::BaseCamera::SaveFrame

ignition::rendering::BaseCamera::SaveFrame is a dummy function. Please, either mention this in the documentation or write the function.

All functions on BaseCamera are virtual functions that can be reimplemented by each rendering engine.
So I imagine what you're asking for is for that function to be implemented on either Ogre or Ogre2, right?

I use Ogre2 in my project, that is right. And as far as I understand, I cannot save an image from the camera itself. The way I did it is by capturing the image and then saving it with the help of ign-common.
I think it may be better to implement the function or override it for Ogre2Camera. Otherwise, a lot of users will use the function without understanding why it does not do anything (which happened to me).

Understood. I don't think we'll have time to work on this anytime in the future, but pull requests are welcome :wink:


Bluetooth: tester: Fix possible NULL pointer dereference

Fix calling NULL attribute read function pointer.
Signed-off-by: Mariusz Skamra<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@69613ca). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14634   +/-   ##
=========================================
  Coverage          ?   52.01%
=========================================
  Files             ?      309
  Lines             ?    45583
  Branches          ?    10555
=========================================
  Hits              ?    23711
  Misses            ?    17068
  Partials          ?     4804

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69613ca...103d01c. Read the comment docs.


PLT-8281: Sass to tailwindcss migration

@coderabbitai: ignore
PLT-8281

Another suggestion -
Replace https://github.com/input-output-hk/dapps-certification-web/blob/sass-to-tailwindcss-migration/src/compositions/InputGroup/utils/schemas.ts#L22-L28
with
export const CommitHash = yup.string()
  .min(7, 'The field value must have atleast 7 characters of the commit hash')
  .max(40, 'The field value has more than 40 characters. Please enter a valid commit hash')
  .matches(/^[a-f0-9]{7,40}$/, {
    message: 'The field value must be a valid commit hash',
    excludeEmptyString: true
  });

Just a minor outstanding feedback -
With the latest change, the tooltip/details text is always displayed below the field, and not hidden away within an info-icon like it was.

Passing over to @RSoulatIOHK  to make the decision, which do we want to maintain. Can you please have a look.
Otherwise, approving the rest of the changes from my side.

Just a minor outstanding feedback - With the latest change, the tooltip/details text is always displayed below the field, and not hidden away within an info-icon like it was.
Passing over to @RSoulatIOHK to make the decision, which do we want to maintain. Can you please have a look.
Otherwise, approving the rest of the changes from my side.

Ok! I just uploaded a change to show it as a tooltip like before

Thanks @EehMauro , the tooltip is in place


Question about usage

I think the splitting on delimiter should happen in the slicer, but there's probably something simple I'm just not getting.  Using the hdfs reader as example, it's not clear how records are handled when the chunk does not fall on delimiter boundaries.  Is this a valid use case?  If so, can you see what am I doing wrong?

The slicer just chunks the data evenly, then the reader handles the partial records at the time it processes them.
When offset is 0 it takes the entire chunk and then reads additional data beyond the chunk size to complete the last record.
When offset is > 0 it automatically drops the first record in the chunk assuming that it was processed in a different slice. It will then apply the same logic for the last record as above.

BTW, to add, the slicer should never read any data, it just works on byte offsets into the file.

The slicer is only responsible for determining byte offsets for the chunks, so the actual reading and processing of the slice falls to the reader, which is defined in whatever processor using this module. From what I can tell in the case of the test in this PR, all your reader is doing is returning the elements of chunks each time it is called, so when the chunked-file-reader tries processing the first slice, the reader initially returns {"test1":" for the first read. Since it does not end with a delimiter, the chunked-file-reader determines that the first part of the next slice is needed to complete the trailing record and calls the reader again with the margin offset and length this time, which ends up returning data"}\n{"t. The getMargin() function in the chunked-file-reader only returns up to the first delimiter, so that ends up being data"}. That's concatenated with the initial read to get {"test1":"data"}, which ultimately gets returned as a single-record slice. When the chunked-file-reader processes the second slice, the same thing happens for the third and fourth element of chunks, but since it is not a slice at the beginning of the file or a chunk that starts with a delimiter, the partial record gets dropped, leaving an empty slice. Then, there's nothing to return from chunks when the chunked-file-reader tries processing the third and fourth slice.

Cool!  Thanks for the help!


Allow automatic method name clash resolution

If the method name is generated from the request type, there is a
possibility of a clash if two methods take the same request type. For
example, if two unique methods take the request type
"CreateRoleRequest", both methods will be generated with the method name
"create_role", which causes generation to fail with an exception.
This commit resolves that issue by first generating a method name from
the request type of each method, and keeping track of which names are
duplicates. For methods that will generate a duplicate name from the
request type, the name is generated from the method ID instead (the
resulting name is guaranteed to be unique).

Coverage decreased (-0.3%) to 96.109% when pulling 345e5d5fc2bfbb9111c372d392267e9bbaab4337 on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.3%) to 96.109% when pulling 345e5d5fc2bfbb9111c372d392267e9bbaab4337 on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.3%) to 96.109% when pulling 345e5d5fc2bfbb9111c372d392267e9bbaab4337 on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.3%) to 96.109% when pulling 345e5d5fc2bfbb9111c372d392267e9bbaab4337 on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.3%) to 96.109% when pulling 345e5d5fc2bfbb9111c372d392267e9bbaab4337 on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.3%) to 96.109% when pulling 345e5d5fc2bfbb9111c372d392267e9bbaab4337 on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.2%) to 96.12% when pulling d6fd8f05794428550b1159079b48567b04bb7c0b on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.2%) to 96.12% when pulling d6fd8f05794428550b1159079b48567b04bb7c0b on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.2%) to 96.12% when pulling d6fd8f05794428550b1159079b48567b04bb7c0b on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.2%) to 96.12% when pulling d6fd8f05794428550b1159079b48567b04bb7c0b on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.2%) to 96.12% when pulling d6fd8f05794428550b1159079b48567b04bb7c0b on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Mostly looks good, but please check two cases to be sure:

Please make sure it doesn't inadvertently rename any existing methods when regenerating.
Check the case where a conflict is created at a later point in time to make sure the first method remains stable. This has been the source of most conflicts -- things work OK for a while then a method is added in a subsequent release that causes a conflict.

IIUC the code correctly, I think the 2nd case might break unless we lock in the name in the overrides.

I think those cases will be tricky to solve through logic in the annotator by itself...
The only solution to both that I can think of immediately is to, as part of the regeneration step, copy the generated names_out.yaml file and use that as input to the next generation (merged with api_names.yaml, such that names in api_names.yaml take precedence). That way, names are locked forever.
Does that solution seem reasonable to you?

I implemented the solution I suggested above - the generator first loads api_names_out.yaml, and then merges api_names.yaml. That should eliminate the possibility of a name ever changing once its been generated.
Does that seem reasonable to you? Or is there a better way

Coverage decreased (-16.04%) to 80.321% when pulling c9a2f3e6fc0e0e2aa39117ffbc6c4cbe7fb7c434 on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-16.04%) to 80.321% when pulling c9a2f3e6fc0e0e2aa39117ffbc6c4cbe7fb7c434 on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-16.04%) to 80.321% when pulling c9a2f3e6fc0e0e2aa39117ffbc6c4cbe7fb7c434 on saicheems:savework into 74c0242266fe8ae99ffbc08dcc81d1ffae9a4258 on google:master.

Coverage decreased (-0.2%) to 96.137% when pulling 040f805d3fd2af31c7a56491d9a00e83106bec36 on saicheems:savework into 8e701f7f41e42c9094fad54ee7146e15d3844666 on google:master.

Friendly ping, any thoughts on the above approach?

Friendly ping, any thoughts on the above approach?

lgtm