Checking the exit_status of the executed command in host_inventory

... for filesystem, cpu and memory. This will be in preparation for platforms where it is hard to exactly replicate the same behaviour Linux exhibits. Also added a unit test for host_inventory's memory and modified the filesystem one to work with the new changes.

Great! Thanks.

Released as v2.36.5.


Add destroy commands and make minor changes consistent with command help

Here is the script I used in case it is helpful to do again in the future:
#!/bin/sh
set -x
if [[ "$INDOCKER" = true ]]; then
	apk add perl
	cd ./compare_docs/textile/cmd/tt
	wget https://raw.githubusercontent.com/spf13/cobra/0ab5b6bcfcde193577634059f6f211c850a456ec/doc/md_docs.go
	wget https://raw.githubusercontent.com/spf13/cobra/1e58aa3361fd650121dceeedc399e7189c05674a/doc/util.go
	sed -i '14s/doc/main/' util.go
	sed -i '14s/doc/main/' md_docs.go
	sed -i '67s/##/#/' md_docs.go
	sed -i '67s/name/strings.Replace(name, "tt ", "", 1)/' md_docs.go
	sed -i '24d;40,44d;68,69d;111,114d' md_docs.go
	perl -0777 -pi.bak -e 's/(.+)("time")/$1$2\n$1"log"/' main.go
	perl -0777 -pi.bak -e 's[(func main.+?)^}][$1\terr := GenMarkdownTree(rootCmd, "../../../docs/docs/hub/cli")\n\tif err != nil {log.Fatal(err)}\n}]sm' main.go
	rm ../../../docs/docs/hub/cli/*
	go run .
	chown -R --reference=../../../docs/docs/hub/cli/ ../../../docs/docs/hub/cli
	#/bin/ash
else
	mkdir compare_docs
	cd compare_docs
	git clone https://github.com/textileio/textile.git
	#replace https://github.com/textileio/docs.git with your forked the docs repo
	git clone https://github.com/adgitate1/docs.git
	cd ..
	sudo docker run --rm -it -v $(pwd):/go -e "INDOCKER=true" golang:alpine ./compare_docs.sh
	cd compare_docs/docs/docs/hub/cli
	git add -AN #add all files without content (to get untracked)
	git add -p . #review lines, use ? for help
	git commit .
	#git push origin master
fi

Lovely!
Could you add the DCO signoff here, https://github.com/textileio/docs/pull/137/checks?check_run_id=676002053

It is now signed.

annnd you are live! https://docs.textile.io/hub/cli/tt_destroy/ thanks again
i'll revisit the sh script later to see if i can add it to the deploy step (though first need to migrate this to a textile bucket)

Cool.
The only problem with completely automating when deploying without manual review is overwriting changes people made directly to the markdown.  example.  Unless we want to make and document a new policy that the cli files are automatically generated and shouldn't be directly modified so they stay consistent. (suggested here)


feat(rln): package rln w/ resources into a static lib

!! WIP !!

feat(rln): package resources into lib
fix(rln): remove cdylib from target

Size of rln-wasm before -
4.0K    rln-wasm/pkg/README.md
4.0K    rln-wasm/pkg/package.json
8.0K    rln-wasm/pkg/rln_wasm.d.ts
 28K    rln-wasm/pkg/rln_wasm.js
596K    rln-wasm/pkg/rln_wasm_bg.wasm
4.0K    rln-wasm/pkg/rln_wasm_bg.wasm.d.ts
644K    total

Size of rln-wasm after -
4.0K    rln-wasm/pkg/README.md
4.0K    rln-wasm/pkg/package.json
8.0K    rln-wasm/pkg/rln_wasm.d.ts
 28K    rln-wasm/pkg/rln_wasm.js
608K    rln-wasm/pkg/rln_wasm_bg.wasm
4.0K    rln-wasm/pkg/rln_wasm_bg.wasm.d.ts
656K    total

8kb difference (not sure where that's coming from?)

@tyshko-rostyslav is it evident to you why the rln-wasm package size has increased? is it because include_dir has been included?

@tyshko-rostyslav is it evident to you why the rln-wasm package size has increased? is it because include_dir has been included?
edit: could it be due to static linking?

I think it's due to adding include_dir

I think it's due to adding include_dir

Could we skip compilation of include_dir if the target is wasm?

I think it's due to adding include_dir

Could we skip compilation of include_dir if the target is wasm?

Sure, something like
[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
include_dir = { version = "0.7.3", optional = true }

should work

Added it to the default_features, but still the wasm blob size is unchanged (608K)

Added it to the default_features, but still the wasm blob size is unchanged (608K)

How did Cargo.toml file change over the variants? Maybe new versions of already existing dependencies?

Added it to the default_features, but still the wasm blob size is unchanged (608K)

How did Cargo.toml file change over the variants? Maybe new versions of already existing dependencies?

Didn't change at all, the only change was include_dir.

Added it to the default_features, but still the wasm blob size is unchanged (608K)

How did Cargo.toml file change over the variants? Maybe new versions of already existing dependencies?

Didn't change at all, the only change was include_dir.

Sorry, I meant Cargo.lock file


Custom fonts

Has anyone played with adding fonts to the header for more font options? The basic instructions work, but when testing inside Reach and in Litmus, the fonts are entirely stripped in most email clients (desktop, tablet, and mobile). Not sure why this is a feature when it's stripped out.

@acox73 looks like you removed the default metadata so we have no reference to which article you refer to. Please open a new issue from the article in question and keep the metadata in place so we can find the right person to address you feedback.
Thanks,
Michael


Notification design improvements for OS X

The current design of the native electron-driven OS X notification could use some design improvements.
Here is Slack's:

And Mattermost's:

Some things that might be worth doing:

One Mattermost icon instead of two.
Align the notification text to the top. (Or at least add two lines.)
Consider formatting the notification to use bold for message boilerplate and non-bold for content (similar to Slack).

[x] icon
[ ] text alignment
[ ] format

I think we should try to shim and notify for the longrun.
See: https://github.com/Razzeee/desktop/commit/397b53f51d2298eebdc60000140e26bd07bbe865#diff-59f51de4945d3a9a80a254062862997bR17 which is wip but it should work, but I haven't been able to test it, as I don't have access to an mattermost instance, where I can create test accounts and just write myself to generate notifications :/

It seems that the commit doesn't work as I think. In my memory, Electron's Notification.onclick doesn't change window's focus state, so we should handle onlick manually in this kind of app. Then, onNotificationClick event should be sent on onclick in order to switch to the notified tab.
BTW, you can use a local machine like VirtualBox or Docker to host mattermost server for testing.

@kethinov I think the notification should show both of channel name and message. Could you check again?
Off Topic channel:

Mattermost server: 3.0.3
Mattermost desktop: 1.2.1
OS X: 10.11.3

After looking into it, I don't think we should do Consider formatting the notification to use bold for message boilerplate and non-bold for content (similar to Slack).
as this is probably something the guys from the platform would need to change centrally.
https://github.com/mattermost/platform/blob/c0d1b8fbb9a141b942d73ad4869e612cdf01bbcd/webapp/stores/notification_store.jsx#L86
We could only do it very very hacky and it will be likely to break with new translations etc.
@it33 fyi

The OS X notification appears reasonable to me at its current state - however, it is missing the Mattermost logo, and I will file a separate ticket for it.
Given

One Mattermost icon is used instead of two
Notification text is aligned to the top with channel name with channel name bolded on the first line and message content unbolded below it

we're ready to close this issue. Below is a screenshot of OS X icon for reference.

@jasonblais
Was there a change in the platform that changed the title ("Direct Message")? DMs previously had non set. So that was what caused the Notifications to look so ugly, like the author of this mentioned. Or like in my screenshot.

@Razzeee
There was indeed a change made to v3.2 by the platform team, which now shows the "Direct Message" title for DMs.

Perfect! Thank you.


ERROR: Unable to download JSON metadata

ERROR: Unable to download JSON metadata: HTTP Error 403: Forbidden (caused by HTTPError());
I am trying to download videos from udemy and this happens.

Output with verbose flag
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\common.py", line 627, in _request_webpage
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\YoutubeDL.py", line 2237, in urlopen
File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default


Crashlytics not working

We don't see any users in Crashlytics. We should add some hidden part of the app which causes the crash to test crash reporting in release builds.

It works after a day.


Cartservice Intermittent connection issue

The cartservice occasionally encounters storage errors due to an unreliable network connection. T
he errors typically indicate a failure to connect to Redis, as seen in the error message:
Status(StatusCode="FailedPrecondition", Detail="Can't access cart storage.
System.ApplicationException: Wasn't able to connect to redis
  at cartservice.cartstore.RedisCartStore.EnsureRedisConnected() in /usr/src/app/src/cartstore/RedisCartStore.cs:line 104
  at cartservice.cartstore.RedisCartStore.EmptyCartAsync(String userId) in /usr/src/app/src/cartstore/RedisCartStore.cs:line 168')'.

I just talked to the SRE team in Slack, they have plans to implement retries as a quick fix and address the network issue later.

closing this, as this was only used to demo the Elastic AI Assistant


added variables.sh

Resolves #678

cc: @shannonxtreme
@natea123 instead of reintroducing the variables.sh files, could we:

delete the source lines in all three scripts
substitue the ${VAR_NAME} in the three scripts for their intended hard-coded value

For example, this line:
echo "Copying datasets to Pod '${POD_NAME}'..."

Would become this:
echo "Copying datasets to Pod 'redis-leader'..."

@natea123 is this PR still active?


404 page not found

There is a problem with the test in the grafana data source, and the panel has no data

How to check availability after deploying k8spacket？

Check that the metrics are available. It is normal for curl <IP_ADDRESS>:8080/nodegraph to output 404 page not found. If it is normal, is there any configuration requirement for grafana? It cannot be displayed after online deployment

@LU1371046
You need to build a path according to used plugin requirements (see API Configuration fields and data on https://grafana.com/grafana/plugins/hamedkarbasi93-nodegraphapi-datasource/ )
result:

@LU1371046
This thread is inactive for 10 days.
I'm going to close this issue. If you will have more questions, feel free to reopen this or a new issue

I have same question? How to resolve this question?

metrics is normal

这个不支持在虚拟机上使用

我有同样的问题？如何解决这个问题？ 指标正常

不要用虚拟机

Hi @zhutong196
It looks like k8spacket didn't start any plugins on startup.
Could you share the logs from the k8spacket workload? There should be information about loaded plugins:
k -n k8spacket logs <k8spacket-pod-name> -f -c k8spacket

plugins/nodegraph-x86_64.so
plugins/tls-parser-x86_64.so
2023/01/12 08:26:14 Serving requests on port 6676
2023/01/12 08:26:14 Refreshing interfaces for capturing...
Getting k8s resources
2023/01/12 08:26:15 Starting capture on interface "azv98340604ff0"
2023/01/12 08:26:15 Starting capture on interface "azv46a1bc8c07a"
2023/01/12 08:26:15 Starting capture on interface "azvb3a4e067125"
2023/01/12 08:26:15 Starting capture on interface "azvf7f07f45cd7"
2023/01/12 08:26:15 reading in packets

Additionally, you can check logs in the init container with the command:
k -n k8spacket logs <k8spacket-pod-name> -f -c init-k8spacket

Connecting to github.com (<IP_ADDRESS>:443)
wget: note: TLS certificate validation not implemented
Connecting to objects.githubusercontent.com (<IP_ADDRESS>:443)
saving to 'nodegraph-x86_64.so'
nodegraph-x86_64.so   23% |*******                         | 14.1M  0:00:03 ETA
nodegraph-x86_64.so   51% |****************                | 31.0M  0:00:01 ETA
nodegraph-x86_64.so   76% |************************        | 45.7M  0:00:00 ETA
nodegraph-x86_64.so  100% |********************************| 59.9M  0:00:00 ETA
'nodegraph-x86_64.so' saved
Connecting to github.com (<IP_ADDRESS>:443)
Connecting to objects.githubusercontent.com (<IP_ADDRESS>:443)
saving to 'tls-parser-x86_64.so'
tls-parser-x86_64.so   0% |                                |  127k  0:08:04 ETA
tls-parser-x86_64.so   8% |**                              | 5408k  0:00:20 ETA
tls-parser-x86_64.so  33% |**********                      | 20.0M  0:00:06 ETA
tls-parser-x86_64.so  59% |*******************             | 36.0M  0:00:02 ETA
tls-parser-x86_64.so  86% |***************************     | 52.0M  0:00:00 ETA
tls-parser-x86_64.so 100% |********************************| 60.3M  0:00:00 ETA
'tls-parser-x86_64.so' saved

Hi @zhutong196 It looks like k8spacket didn't start any plugins on startup.
Could you share the logs from the k8spacket workload? There should be information about loaded plugins:
k -n k8spacket logs <k8spacket-pod-name> -f -c k8spacket

plugins/nodegraph-x86_64.so
plugins/tls-parser-x86_64.so
2023/01/12 08:26:14 Serving requests on port 6676
2023/01/12 08:26:14 Refreshing interfaces for capturing...
Getting k8s resources
2023/01/12 08:26:15 Starting capture on interface "azv98340604ff0"
2023/01/12 08:26:15 Starting capture on interface "azv46a1bc8c07a"
2023/01/12 08:26:15 Starting capture on interface "azvb3a4e067125"
2023/01/12 08:26:15 Starting capture on interface "azvf7f07f45cd7"
2023/01/12 08:26:15 reading in packets

Additionally, you can check logs in the init container with the command:
k -n k8spacket logs <k8spacket-pod-name> -f -c init-k8spacket

Connecting to github.com (<IP_ADDRESS>:443)
wget: note: TLS certificate validation not implemented
Connecting to objects.githubusercontent.com (<IP_ADDRESS>:443)
saving to 'nodegraph-x86_64.so'
nodegraph-x86_64.so   23% |*******                         | 14.1M  0:00:03 ETA
nodegraph-x86_64.so   51% |****************                | 31.0M  0:00:01 ETA
nodegraph-x86_64.so   76% |************************        | 45.7M  0:00:00 ETA
nodegraph-x86_64.so  100% |********************************| 59.9M  0:00:00 ETA
'nodegraph-x86_64.so' saved
Connecting to github.com (<IP_ADDRESS>:443)
Connecting to objects.githubusercontent.com (<IP_ADDRESS>:443)
saving to 'tls-parser-x86_64.so'
tls-parser-x86_64.so   0% |                                |  127k  0:08:04 ETA
tls-parser-x86_64.so   8% |**                              | 5408k  0:00:20 ETA
tls-parser-x86_64.so  33% |**********                      | 20.0M  0:00:06 ETA
tls-parser-x86_64.so  59% |*******************             | 36.0M  0:00:02 ETA
tls-parser-x86_64.so  86% |***************************     | 52.0M  0:00:00 ETA
tls-parser-x86_64.so 100% |********************************| 60.3M  0:00:00 ETA
'tls-parser-x86_64.so' saved

Download plugin failed，Can I install plugin offline?

Hi @zhutong196
I see the problem is with resolving the eval command when an init-container downloads plugins. See https://github.com/k8spacket/k8spacket-helm-chart/blob/master/charts/k8spacket/templates/daemonset.yaml#L49
To download them without resolving machine architecture create simple custom-values.yaml file with the content:
k8sPacket:
  plugins:
    - https://github.com/k8spacket/plugins/releases/download/v1.0.1/nodegraph-{{arch}}.so
    - https://github.com/k8spacket/plugins/releases/download/v1.0.1/tls-parser-{{arch}}.so

where {{arch}} is the architecture of your k8s cluster nodes (x86_64 and aarch64 available currently, see on the releases page: https://github.com/k8spacket/plugins/releases)
and upgrade k8spacket with the command:
helm upgrade --install k8spacket --namespace k8spacket k8spacket/k8spacket -f custom-values.yaml

Additionally, there is a new version 1.1.0 of k8spacket and plugins available.
I supposed the arch command is available everywhere, but maybe it was the wrong assumption. I'll fix it.

@zhutong196
What kind of architecture and the operating system does your K8S node use?

@zhutong196
This thread is inactive for more than 10 days.
I'm going to close this issue.


[Task]: Produce missing illustrations for onboarding flows

Task description
We have new or changed onboarding pages and we don't have an illustration or the current one doesn't match. We need to produce an illustration in the same style as previous, for both light and dark mode.
Requirements
Illustrations we need:

[ ] Shimmer vs IOTA selection used on normal and dev profiles
[ ] Network selection for devnet profiles, dev user decides on mainnet vs devnet vs custom network
[ ] Custom network input on dev profiles
[ ] Profile name input screen

Acceptance criteria
Illustrations approved by Andrew
Creation checklist

[X] I have assigned this task to the correct people
[X] I have added the most appropriate labels
[X] I have linked the correct milestone and/or project

@nicole-obrien
After discussion between the design team and Aleksa, we proposed the following:
The first three screens can use the same illustration to speed up delivery.
The profile name input screen can re-use the existing IOTA illustration (chest holding monster).

Thanks for the update, will close and @kraftjs can use this info for his PR


DNM: Test action fix

Summary
Details and comments

The neko tests passed so this is no longer needed to test anymore

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 84.587%

Files with Coverage Reduction
New Missed Lines
%

qiskit/pulse/library/waveform.py
3
91.49%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
62998

Relevant Lines:
74477

💛  - Coveralls


laravel preset for inertia

Hi i made a preset for laravel
which scaffold all the stuff you had in a very basic app install of inertia
composer require codeitlikemiley/vuetified-laravel-preset

I would love to improved this preset to either choose vuetify/tailwind for front end
for vuetify i can use my layouts from here
https://github.com/codeitlikemiley/vuetified
So basically this will be an upgrade of that repo.
Which has
custom authentication either jwt or laravel passport
custom websocket either by laravel echo server and laravel websockets
custom make:auth (tailwind/vuetify or both)
I would really love to here a feedback from you guys.
Since the main Author of inertia use tailwind. maybe  i can stub some of the login/register pages etc. for those that dont use vuetify

Hi @codeitlikemiley,
Cool idea, I would like to do the same but finally I did a repo template on Github.
What do you think?

https://github.com/laravel-frontend-presets/inertiajs

Thanks for sharing this @codeitlikemiley. Closing this as nothing further is required from this end.


fix: update public app permission to create sessions

Description

Update public app permissions for creating sessions

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.47.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


FDA PPE resources

there is a lot of information about this. https://www.fda.gov/medical-devices/general-hospital-devices-and-supplies/personal-protective-equipment-infection-control
https://www.fda.gov/regulatory-information/search-fda-guidance-documents/enforcement-policy-face-masks-and-respirators-during-coronavirus-disease-covid-19-public-health?utm_campaign=2020-03-25 Face Masks Immediately in Effect Guidance During COVID-19&utm_medium=email&utm_source=Eloqua
https://www.fda.gov/media/136540/download
There is also an ongoing webinar series, with past webinar materials on the web: https://www.fda.gov/medical-devices/workshops-conferences-medical-devices/medical-device-webinars-and-stakeholder-calls

One question:
what is the difference between a medical mask and a protective mask?
https://en.wikipedia.org/wiki/Mask#Medical
https://en.wikipedia.org/wiki/Mask#Protective
I think protective mask is a PPE.
Is medical mask such as oxygen mask a PPE?
A surgical mask is likely both a medical mask and protective mask. Hoewver, some mask like oxygen mask appears not to be used for protective purpose, but for medical purpose.


Suggest using collections.abc etc, not typing (deprecated since 3.9)

Affects:

[ ] AbstractSet (as collections.abc.Set)
[X] AsyncContextManager (as contextlib.AbstractAsyncContextManager)
[ ] AsyncGenerator
[ ] AsyncIterable
[ ] AsyncIterator
[ ] Awaitable
[ ] ByteString
[ ] Callable
[X] ChainMap (as collections.ChainMap)
[ ] Collection
[ ] Container
[ ] ContextManager (as contextlib.AbstractContextManager)
[ ] Coroutine
[X] Counter (as collections.Counter)
[X] DefaultDict (as collections.defaultdict)
[X] Deque (as collections.Deque)
[ ] Generator
[ ] Hashable
[ ] ItemsView
[ ] Iterable
[ ] Iterator
[ ] KeysView
[ ] Mapping
[ ] MappingView
[ ] Match (as re.Match)
[ ] MutableMapping
[ ] MutableSequence
[ ] MutableSet
[ ] OrderedDict (as collections.OrderedDict)
[ ] Pattern (as re.Pattern)
[ ] Reversible
[ ] Sequence
[ ] Sized
[ ] ValuesView

The collections.abc alias check cannot be implemented until these two bugs are resolved:

https://github.com/python/mypy/issues/11860
https://github.com/google/pytype/issues/1096

We can't suggest using re.Match and re.Pattern until typeshed drops support for Python 3.6 (they were only exposed in the re module in 3.7).

The only two left to do here are typing.Match and typing.Pattern. We can't check for that in typeshed until we drop support for 3.6, since re.Match and re.Pattern don't exist in Python 3.6, but I suppose we could add a check here before then.


Idle Eth Dispatch: hang on R chip TestWrapCompletionQOnInsufficientSpace

git checkout ucheema/fd-on-idle-erisc
TT_METAL_ENABLE_REMOTE_CHIP=1 ./build/test /tt_metal/unit_tests_fast_dispatch --gtest_filter="CommandQueueSingleCardFixture.TestWrapCompletionQOnInsufficientSpace"
OR
TT_METAL_ENABLE_REMOTE_CHIP=1 ./build/test /tt_metal/unit_tests_fast_dispatch --gtest_filter="CommandQueueSingleCardFixture.TestWrapCompletionQOnInsufficientSpace2"

Seeing it pass on L chip, but hanging on R chip.

do these parameters need to be adjusted?
    ```

std::vector<uint32_t> remote_pull_and_push_compile_args = {
0, // host_issue_queue_read_ptr_addr,
0, // issue_queue_start_addr,
0, // issue_queue_size,
0, // host_completion_queue_write_ptr_addr,
0, // completion_queue_start_addr,
0, // completion_queue_size,
0, // host_finish_addr
cmd_start_tensix,
data_section_addr_tensix,
producer_data_buffer_size_tensix,
cmd_start_tensix,
consumer_data_buffer_size_tensix,
(uint32_t)tt::PullAndPushConfig::REMOTE_PULL_AND_PUSH
};

for mmio case, I have this;
                ```
uint32_t cmd_start_producer = eth_core ? cmd_start_eth_dispatch : cmd_start_tensix;
                uint32_t data_section_addr_producer = eth_core ? get_data_section_l1_address(true, true) : data_section_addr_tensix;
                uint32_t producer_data_buffer_size = eth_core ? get_cq_data_buffer_size(true, true) : producer_data_buffer_size_tensix;

at least buffer size is different when fd is running on Tensix Vs ethernet cores.

Hang can be reproduced on main by moving L1 unreserved base from 120 KB to 119 KB.
It is not related to FD on ethernet cores feature. But is exposed because we have to move the l1 unreserved base lower to have more memory on ethernet cores for CBs.

Investigating.

FYI, on main, both TestWrapCompletionQOnInsufficientSpace and TestWrapCompletionQOnInsufficientSpace2 pass with watcher enabled on tensix. Please rebase and see what happens on your branch.

I checked in fixes to main. Can you confirm whether or not this resolves the issue so that we can close?

Verified that it works on R chip.
Thanks for the fix.


Properly constrain all columns

rent_start must be before rent_end
serialnumber, devicetye name and probably some other columns should be unique

looks good


[Site Request] audius.co

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running yt-dlp version 2021.01.24
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single tracks: https://audius.co/sanjaux/descent-222909
https://audius.co/naskoedm/where-i-belong-239874
Playlist: https://audius.co/itsvincent_/playlist/sunrise-series-7588
Description

Audius is a Soundcloud competitor with 320kbps music streaming.
There is already a functional extractor for audius, but it was never merged, I've been adding it manually and rebuilding yt-dlp with every update but maybe it can be officially added? Thanks for your efforts on this project :)
https://github.com/ytdl-org/youtube-dl/pull/27360/files

There is an issue with the "valid URLs" of the PR that could cause issue with Generic extractor (or others in the future). https://github.com/ytdl-org/youtube-dl/pull/27360#issuecomment-757123708

The problem is that I have no idea how handle all of this different hosts with regexp. For now, as a temporary solution, i used .+/v1/tracks regexp, but then this extractor will triggered to links like https://super-random-host.com/v1/tracks/trackID. For now such links do not overlap with other extractors, but who knows what will happen next.

I will look into how to fix this issue, and assuming I can figure out a fix, I will merge it

There is an issue with the "valid URLs" of the PR that could cause issue with Generic extractor (or others in the future). https://github.com/ytdl-org/youtube-dl/pull/27360#issuecomment-757123708

The problem is that I have no idea how handle all of this different hosts with regexp. For now, as a temporary solution, i used .+/v1/tracks regexp, but then this extractor will triggered to links like https://super-random-host.com/v1/tracks/trackID. For now such links do not overlap with other extractors, but who knows what will happen next.

I will look into how to fix this issue, and assuming I can figure out a fix, I will merge it

Thanks again, i really appreciate it!

Thanks again, i really appreciate it!

Hey, I'm not sure whether to leave a new issue but attempting to dl in version 2021.01.29 is throwing an error for me.
C:\ytdl>youtube-dlc -v https://audius.co/disguised/nullboy-false-past-230539
[debug] Command-line config: ['-v', 'https://audius.co/disguised/nullboy-false-past-230539']
[debug] Loading archive file None
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.01.29
[debug] Python version 3.9.1 (CPython) - Windows-10-10.0.19041-SP0
[debug] exe versions: ffmpeg 4.3.1-2020-11-19-full_build-www.gyan.dev, ffprobe 4.3.1-2020-11-19-full_build-www.gyan.dev
[debug] Proxy map: {}
ERROR: not enough values to unpack (expected 3, got 2)
Traceback (most recent call last):
File "c:\users\admin\appdata\local\programs\python\python39\lib\site-packages\youtube_dlc\YoutubeDL.py", line 950, in wrapper
return func(self, *args, **kwargs)
File "c:\users\admin\appdata\local\programs\python\python39\lib\site-packages\youtube_dlc\YoutubeDL.py", line 971, in __extract_info
ie_result = ie.extract(url)
File "c:\users\admin\appdata\local\programs\python\python39\lib\site-packages\youtube_dlc\extractor\common.py", line 533, in extract
ie_result = self._real_extract(url)
File "c:\users\admin\appdata\local\programs\python\python39\lib\site-packages\youtube_dlc\extractor\audius.py", line 127, in _real_extract
uploader, title, track_id = mobj.groups()
ValueError: not enough values to unpack (expected 3, got 2)

It was a mistake I made while merging. Should be fixed now. Can you check with master branch?
$youtube-dlc -v https://audius.co/disguised/nullboy-false-past-230539
[debug] Command-line config: ['-v', 'https://audius.co/disguised/nullboy-false-past-230539']
[debug] Loading archive file None
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.01.29
[debug] Plugin Extractors: ['SamplePlugin']
[debug] Git HEAD: c55256c5a
[debug] Python version 3.8.4 (CPython) - Windows-10-10.0.19041-SP0
[debug] exe versions: ffmpeg 4.3.1-2020-11-19-full_build-www.gyan.dev, ffprobe 4.3.1-2020-11-19-full_build-www.gyan.dev
[debug] Proxy map: {}
[Audius] Requesting available API hosts
[Audius] nullboy-false-past-230539: Downloading JSON metadata
[debug] Default format spec: bestvideo*+bestaudio/best
[info] Downloading format(s) 0
[debug] Invoking downloader on 'https://audius-discovery.nz.modulational.com/v1/tracks/oGvgX/stream'
[download] Destination: Nullboy - False Past [oGvgX].mp3
[download]  10.3% of 9.67MiB at 766.01KiB/s ETA 00:11
ERROR: Interrupted by user

It only downloads low quality mp3, aac in mp4 that have even higher bitrate: 348 kb/s cannot be downloaded.

audius.co has private ipfs network. They are open source, there will be somewhere written key which is needed for stock ipfs client to join network.


Black gloves are a lot darker now

About the PR

Changed black gloves texture to be darker
Why / Balance

Black gloves' sprite changed to be darker
Fixes #28474
Technical details

N\A
Media

now

before

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A
Changelog

tweak: Changed black gloves' sprite to be a lot darker

the increased darkness on the main color really hurts the readability on these

I never suggested to change the icon sprite, only the worn sprite.

This is honestly so weird
Why can't we set the color of the sprite with yaml?


clean prometheus config

Prometheus currently has default config to scrape all components, including control plain. need to stip it down.

Default prometheus is supposed to scrape the control plane. It seems we need to fix the endpoints to scrape the components correctly.

yes :) was cleaning router scape config and this came up.

/close


Sync .github/workflows directory with azure-sdk-tools for PR 7765

Sync .github/workflows directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/7765  See eng/common workflow

/check-enforcer override


errors with getSymbolsByUDA to get a private members

Resolve #15335 Remove ability in getSymbolsByUDA to get a private members If it is located in another module.
If you trying to get symbols from another module you will get errors. This commit resolve this. Now you can access to all attributes if you have access otherwise you will not get private members but also not throws errors.
examples:
uda.d
enum Attr;

struct HasPrivateMembers
{
    @Attr int a;
    int b;
    @Attr private int c;
    private int d;
}

main.d
unittest
{
    import uda : Attr, HasPrivateMembers;
    // Trying access to private member from another file therefore we do not have access
    // for this otherwise we get deprecation warning - not visible from module
    static assert(getSymbolsByUDA!(HasPrivateMembers, Attr).length == 1);
    static assert(hasUDA!(getSymbolsByUDA!(HasPrivateMembers, Attr)[0], Attr));

    struct A
    {
        @Attr int a;
        int b;
        @Attr private int c;
        private int d;
    }

    // Here everything is fine, we have access to private member c
    static assert(getSymbolsByUDA!(A, Attr).length == 2);
    static assert(hasUDA!(getSymbolsByUDA!(A, Attr)[0], Attr));
    static assert(hasUDA!(getSymbolsByUDA!(A, Attr)[1], Attr));
}

In my program I do not get deprecation warning instead of this I get a bunch of errors.
With this patch all works fine.
/usr/include/dlang/dmd/std/traits.d-mixin-7671(7671,1): Deprecation: editor.mapeditor.MyView.a is not visible from module traits
/usr/include/dlang/dmd/std/traits.d-mixin-7671(7671,1): Deprecation: ui.views.view.View.layoutData is not visible from class MyView
/usr/include/dlang/dmd/std/traits.d-mixin-7671(7671,1): Deprecation: ui.views.view.View.layoutData is not visible from module std.traits
/usr/include/dlang/dmd/std/traits.d-mixin-7671(7671,1): Error: class editor.mapeditor.MyView member layoutData is not accessible
/usr/include/dlang/dmd/std/meta.d(900,20): Error: template instance std.traits.getSymbolsByUDA!(MyView, OnClickListener).pred!"layoutData" error instantiating
/usr/include/dlang/dmd/std/traits.d(7672,39):        5 recursive instantiations from here: Filter!(hasSpecificUDA, "__ctor", "onOkButtonClick", "onCancelButtonClick", "a", "app", "createFromFile", "layoutData", "toString", "toHash", "opCmp", "opEquals", "Monitor", "factory")
src/ui/views/view.d(58,26):        instantiated from here: getSymbolsByUDA!(MyView, OnClickListener)
src/editor/mapeditor.d(34,14):        instantiated from here: __ctor!(MyView)
dmd failed with exit code 1.

found another problem - if put alias int INT or alias void function(INT) SomeFunction; application will crush. Fixed this.

Most __traits are now unbridled but not getAttributes. I think it would be better to remove the limitation instead of using workarounds. Users are free to respect the protection by using the getProtection. Once for all. Can you believe that __traits(protection) currently leads to a deprecation message when it's used on a private symbol !

If https://github.com/dlang/dmd/pull/6724 is accepted then all the std.traits related to UDAs can be updated (for example add a parameter like allowPrivate)

You must use getSymbolsByUDA!(__trait(getMember, stuff), Attr) to access private members. __trait(getMember, stuff) is not constrained by the protection of stuff.

Totally agree with you, If I want to add some useful attribute like property I will get a lot of errors, because of the inability to access the symbols.

I've deleted previous comments so there might be a misunderstanding. Actually the bug you try to fix is not a bug anymore. You must use __traits(getMember) as symbol and not the symbol directly. This has for effect to bypass the protection.

I do not quite understand why this is not a bug - errors fall specifically in the getSymbolsByUDA even if there are no private attributes in the structure but have private members without attributes e.g.:
struct {
    @Field int testField = 10;
    private int member = 0;
}

When I try to call getSymbolsByUDA from another module - my application is down.

ping @BBasile

My wish to make most of the built-in traits free from protection attribute interfere. Consider my previous comments as non-existent.

Ok, @UplinkCoder all corrected, will there be more comments?

@UplinkCoder corrected, but for some reason continuous-integration/jenkins/pr-merge and ci/circleci didn't pass

@sysint64 rebase on ~master.

@UplinkCoder haven't helped, DAutoTest throw an error: /home/dtest/DAutoTest/work/repo/dlang.org/dlangspec.html: No such file or directory.
Don't actually understand, how these changes affect to it.

@sysint64 squash please.
This is ready for merge.

That instead of merging 6 commits, we prefer to merge only one to keep the history nice and clean.
However, @UplinkCoder there's absolutely no need to request this from submitters (and thus complicate their flow) since a couple of months as:

maintainers can do manual squashes easily
the dlang-bot does support auto-merge-squash (!)

@UplinkCoder: Do you know this page: https://wiki.dlang.org/Guidelines_for_maintainers

@sysint64 there seems to be a problem when building ggplot

@UplinkCoder how can I reproduce it? jenkins/pr-merge log does not say anything except that this is linking error (collect2: fatal error: ld terminated with signal 7 [Bus error]).

how can I reproduce it?

Clone ggplotd and pass your locally build DMD to DUB with --compiler when running the tests (dub test)

@UplinkCoder, @wilzbach I checked ggplotd and everything was compiled fine and tests passed.
command:
dub build --force --compiler=/home/andrey/projects/dmd/generated/linux/release/64/dmd
dub test --force --compiler=/home/andrey/projects/dmd/generated/linux/release/64/dmd
dmd.conf:
[Environment64]
DFLAGS=-I/home/andrey/projects/phobos -I/home/andrey/projects/druntime/import -L-L/home/andrey/projects/phobos/generated/linux/release/64 -L-L/home/andrey/projects/druntime/generated/linux/release/64 -L--export-dynamic -fPIC

Jenkins falls when he tries to compile with flag -c ggplotd-gtk, I have tried to compile with this flag, and on my computer everything is compiled normally. I suppose problem with linking gtk-d:gtkd.

@UplinkCoder, @wilzbach I checked ggplot on another computer where only one dmd - v2.075.0-devel-e5ebfc5 and one phobos with my changes, and everything builds correctrly and all tests pass.
Maybe the problem is not in the changes but in jenkins configuration?

Maybe the problem is not in the changes but in jenkins configuration?

Quite likely, unfortunately I don't have access to restart jobs at Jenkins. I will try to restart manually by force-pushing the same changeset.

@wilzbach, @UplinkCoder all checks have been passing, but for some reason doesn't run the jenkins/pr-merge

This pull request may have introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=17643
Your PR description says:

Resolve #15335 Remove ability in getSymbolsByUDA to get a private members If it is located in another module.

However, as per the above issue, it also affects symbols within the same module.

However, as per the above issue, it also affects symbols within the same module.
there is test on this case which successfully passed:

@safe unittest
{
    enum Attr;
    struct A
    {
        alias int INT;
        alias void function(INT) SomeFunction;
        @Attr int a;
        int b;
        @Attr private int c;
        private int d;
    }

    // Here everything is fine, we have access to private member c
    static assert(getSymbolsByUDA!(A, Attr).length == 2);
    static assert(hasUDA!(getSymbolsByUDA!(A, Attr)[0], Attr));
    static assert(hasUDA!(getSymbolsByUDA!(A, Attr)[1], Attr));
}

You can't access to symbol only if this accessing leads to compilation error

@sysint64 I think that test passes only because it's located inside the std.traits module.
Suffice to say, it's not useful that we can access private members of types declared in std.traits specifically.

@CyberShadow you are right it's not compiled, I suppose it's because all computations are produced inside the function in std.traits, old version of this function also in the future will stop working due to deprecation such access.

@CyberShadow on current version of D not only does this method not work with private members also do not work getUDAs and hasUDA.


Add sox_effects submodule and delegate sox_effects initialization

Can you detail what you are trying to do here?

There are couple of aspects of this PR that overall improves the maintainability of the code base, based on "decoupling" and "separation of concerns".
As you know, sox_effects functionalities are either available or unavailable. From the viewpoint of torchaudio main module, the looser the connection between the torchaudio module and torchaudio.sox_effects, the more manageable the code base become because you can change the two modules independently. This is mostly accomplished when the definitions of initialize_sox and shutdown_sox were moved from torchaudio.__init__ to torchaudio.sox_effects, but the initialization of sox effects are still happening in torchaudio.__init__. If we move the initialization to sox_effects module, the responsibility of sox initialization is moved to sox_effects module, along with the required module availability check etc. The main torchaudio module can be carefree about how the sox_effects module should work.
In addition to that, I found that initialize_sox and shutdown_sox are confusing because it sound like they are required for libsox based I/O. To make it clear, I renamed them to include sox_effect in function name.
Also moving functions from the original places are BC breaking itself, therefore, these functions are re-imported in torchaudio.__init__ and renamed to match the original names. Therefore the PR is not BC breaking.
In the next PR https://github.com/pytorch/audio/pull/709/commits/9519310c4096537d9daa7481c6c10b9c648d8d25, I am gonna mark the initialize_sox and shutdown_sox deprecated, so that the decoupling is completed.


Fixing migration issues from moving to new Pulumi version

Pulumi migration issues:
Mock methods NewResourceAsync() and CallAsync have been updated to take new parameters.
This means the RunAsync() method in the Testing.cs class needs updating and ALL of the mocks need updating.
I've assigned myself this task, but I wanted to let people know that Mocks will be formatted slightly differently from now on.
See link  for more information on the update.

@sesispla , the conflicts on all five new PRs created by dependabot have been resolved.
Again, there were a lot of issues with the GitHub workflow testing phase. I cannot figure out why still.
It will eventually successfully pass all of the tests if you re-run the workflow enough times...


Upgrade multiple containers in parallel

Would be super nice if we could update multiple containers in parallel. I know there are tools that let you do that, but none of these tools are installed on the image, afaik

You can do that in your .gitlab-ci.yml file — if you define multiple steps in the same (deploy) stage they will run concurrently

If defined like this:
deploy-web:
  stage: deploy
  image: cdrx/rancher-gitlab-deploy
  script:
    - upgrade --service web

deploy-database:
  stage: deploy
  image: cdrx/rancher-gitlab-deploy
  script:
    - upgrade --service db

these will run in parallel, as long as you've got a runner with concurrency > 1

Oy. DIdnt know that. Thanks!


[docs] Add note in docs about componentsProps.root taking precedence

[x] I have followed (at least) the PR section of the contributing guide.

While working on SnackbarUnstyled component, I stumbled upon a use case about what if both props are specified which one will take precedence?
componentsProps.root or the additional native DOM props?
This is what I mean - see the following CodeSandbox: https://codesandbox.io/s/eloquent-hugle-xfri7g?file=/src/Demo.tsx:1245-1449
Here the id badge-1 of root slot gets applied, not badge-2. Hence mentioned it in the docs.
However, I think that it should be the other way around, the additional native props passed directly on the component should take precedence. But then we will have to change the implementation on all the components.
Docs preview: https://deploy-preview-33097--material-ui.netlify.app/base/getting-started/usage/

cc @michaldudak can you verify and approve?

I am merging this. The docs suggestion is applied. Could be helpful for #33272.


4 beta not working on m1 macbook pro 13

Describe the issue
Error: Use -machine help to list supported machines
Configuration

UTM Version: 4 beta
macOS Version: macbook pro 13 inch
Mac Chip (Intel, M1, ...): m1

Yeah, I am having the same problem!
UTM Version: 4.0.3 (BETA)
macOS Version: macbook pro 16 inch
Mac Chip (Intel, M1, ...): M1

It gets stuck on the black screen!


ModelExperimental: fix show behavior after tileset starts hidden

If a tileset started with show: false (but preloadWhenHidden: true), and then later the tileset was toggled on, ModelExperimental would stay hidden.
This was due to a line that set model.show = tileset.show in the constructor. Thus, the model was being hidden from the start, but nothing set it visible again when tileset.show was set to true.
Sandcastle for testing
Ah I'm getting ahead of myself, I should make a unit test for ModelExperimental3DTileContent

Thanks for the pull request @ptrgags!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

@j9liu this is now ready for review!

@ptrgags just some comments about unit tests, since the expected behavior isn't immediately obvious from a glance.

@j9liu updated!


Added ui api method to get list of installed plugins

As we talked about.
This just adds the UI API call to get a list of installed plugins, which includes if any need updating or not.
You can use it to finish this off and make it trigger the alerts based on the output.

Great, thanks so much! I’ll get this worked in this afternoon.
After sleeping on it, I think it might make sense for me to use my current method as a fallback if Config UI X is unavailable. That way it should work for anyone.


Refund complete booking

In case of errors we would like to refund a complete booking (typically with override codes of either TECHNICAL_ERROR or PAYMENT_ERROR). In this case it would be helpful to be able to ask for a refund offer without having to specifiy fulfillmentIDs.
Proposal:

either make fulfillmentIDs optional in the POST .../refundOffers (with the semantics of asking to refund the complete booking), or

create another endpoint POST .../refundOfferCompleteBooking, with the same semantics, with the same signature as the original refundOffers request, just without the fulfillmentIDs.

New endpoint getting just bookingId, overruleCode and refundData, no second step needed to confirm the refund. @ralfbayer-db to create a patch


Add custom type validator to support x-ms-mutability

The type validator was in previous z-schema versions extracted out of validators to enable fast failure for that specific failure since it was the most common.
This has been achieved in a different way in 3.22.0 and now the type validator is part of the validators so we can overwrite it.

@amarzavery  if you can have a look. Tested in oav and all is good. I think the only question is if we want to introduce an extra error if read is missing in x-ms-mutability but still a property is present. If you think so I can open an issue for that.

@vladbarosan -

if read is missing in x-ms-mutability but still a property is present (in the response, right? )

I am not sure if we want to do this for request objects. For response, yes raising an error would be the right thing to do.

@amarzavery  yes this would be strictly for responses . Opened an issue here: https://github.com/Azure/oav/issues/250

Feel free to merge once the CI passes.

Fixes https://github.com/Azure/oav/issues/239


Add submenu collapsed behavior

Contributor Comments
Currently, active items in the central navigation have styling applied to them (eg. green arrow on the left side, lighter background color, etc). However, there are not styles to handle active submenu items (ie. collapse menu items) in the central navigation.
Per our internal discussion, I implemented the following behavior:

When the navigation is expanded, an active submenu item has the same styling as an active nav item.
When the navigation is collapsed, the parent of the active submenu item reveals a green active arrow.

Testing

Clone this branch locally.
Start up the project and open localhost:8000
In the index.html file (or in your inspector) add active as a class to the .navbar-parent and a .nav-sublink (see screenshot below).

You should see the following behavior when opening/closing the central navigation.

Further Considerations
I did not implement "sticky" behavior so that submenus remain open for a few seconds after hover. I avoided doing this because of time constraints. We should open an issue and address this in the future when we have time.
The application of the active class should be handled in Javascript. However, I think that should be implemented in the application consuming this library, as most modern JS frameworks have routers to handle active states.
IMHO, when the menu collapses, it's sort of jarring right now. If others agree, we should work to smooth that out a little with property transitions, if possible.

@jgolieb Good point about avoiding new classes. I neglected to consider the fact that we refer to the Bootstrap docs for html examples, so the chances are high that a user wouldn't know of the new class existing.
Leaving the styles flat was sort of intentional on my part, and I figured it would come up in the review. I can easily create a new shallow nest at the end of the file. If you would prefer them to be included in the existing nest, I can do that too, but I wanted to avoid doing that while initially writing out the styles. As a new contributer, blocks nested that deeply can be hard to parse and remember right off the bat. That isn't intended as a criticism to your approach, as I know you're trying to work with existing classes and html structures from the Bootstrap documentation with as little change as possible. It's just hard to quickly customize and/or extend for project newbies like me.
All that said, if you're already working with the navbar and have the capacity to take on these issues, I would greatly appreciate it. If not, I can get to it within the next few days.

@sardell I recognize the difficulty of working with the nesting structure for the navbar. That thing is a beast and easily the most complicated thing in the project. I have a couple other things to finish up before I would get to this, so whichever one of us gets to it first, we'll just let the other know.


Update version for the next release (v.20.0)

This version makes this package compatible with Meilisearch v0.29.1 :tada:
Check out the changelog of Meilisearch v0.29.1 for more information on the changes.
🚀 Enhancements

Ensure support to the new search query parameter matchingStrategy (#333) @bidoubiwa
Ensure support to keys with wildcarded actions.

actions field during key creation now accepts wildcards on actions. For example, indexes.* provides rights to indexes.create, indexes.get,indexes.delete, indexes.delete, and indexes.update. https://github.com/meilisearch/meilisearch/issues/2560

⚠ Breaking Changes

Replace struct Query with SearchQuery (#341) @vishalsodani

Changes in filters and behavior of the NOT keyword https://github.com/meilisearch/meilisearch/issues/2486

Thanks again to @bidoubiwa,  @curquiza,  and @vishalsodani! 🎉

bors merge

Thanks again for contributing with Meilisearch :heart:
If you are participating in Hacktoberfest, and you would like to receive a small gift from Meilisearch too, don't forget to fill this form.


Configure Dependabot

This PR configures Dependabot to monitor dependencies across all of our own packages. It does not attempt to set up Dependabot for our examples or our create-turbo templates. (I want to address that update separately.)
Note: Dependabot does not officially support pnpm (dependabot/dependabot-core#1736) and is not workspaces-friendly (dependabot/dependabot-core#4993). All Dependabot PRs for the npm ecosystem will require checking out, regenerating the lockfile, and pushing back to the branch.
I've configured checks to be monthly which seems like a decent cadence to monitor things (and cluster everything to a few hours required to shepherd everything through).

I'm sorry if this might be bringing a new question/problem to the table. However, I would like to suggest an alternative to Dependabot for monitoring dependencies, which is Renovate. It supports pnpm, Go Modules, and also pnpm-workspace.
Hopefully, with Renovate, the process of bumping and monitoring dependencies can be performed fully by the bot.

@samnap11 Thanks for the pointer! Integrating Renovate is definitely something we could consider in the future. For now this is an intentionally targeted change which addresses our existing integration with Dependabot.

As an FYI: I had a similar experience but noticed some of the PR's were correct. The PR's that were correct didn't have the
in /<sub-dir> text.
ie:
chore(deps): bump commander from 9.2.0 to 9.3.0 in /my/sub-project

but PR's with just text like
chore(deps): bump commander from 9.2.0 to 9.3.0

updated all instances of commander in the project.json and the pacakge-lock.json at the root of the project
so maybe define the directory as / and don't define the individual subdirectories.


Example Profiling Data

From what I can tell, the three entries (BBBC, IDR, RxRx1) in the datasets resource section include only raw images.
Are there any known examples of resources that provide actual profiles (in addition to raw images)?
One of the major reasons for success in RNA space is that processed matrices are made available alongside raw data. This enables really quick secondary analyses. I haven't really seen much of this for profiling data.

It looks like Wawer et al. 2014 provides processed profiles. Maybe it is more common than I thought!

some processed profiles here: https://github.com/cytodata/cytodata-hackathon-2018

here are some more publicly available profiles:
https://docs.google.com/spreadsheets/d/1iNzLmISGxXmDlmZk_Edw5Pp4WBp3pUsmcp8iR7NUFv4/edit#gid=1262001141
I will add to the list soon!

I believe all papers published by our lab provided the processed profiles in some fashion, either as supplementary data or in the github repo for the paper (in carpenterlab umbrella).

Great! I feel like I captured them all in #4 except for https://github.com/carpenterlab/2016_bray_natprot. I will add this in the next PR!


Allow the welcome banner image to be set per server.

Allow the welcome banner image to be set per server.

This has been completed


Input fields placeholder mis-aligned

Current Behavior

New issue introduced with the 1.13.0 release mis-aligns the preview placeholder for text input boxes. It seems to ahve slightly different mis-alignment depending on the type of text-input, e.g the file input is too high, standard text-input is too low.
Expected Behavior
The placeholder should be centrally vertically aligned.
Steps To Reproduce
No response
Environment

Dashboard version: 1.13.0

Verified the issue disappears if I switch back to 1.12.4

This seems to be linked to us updating our Vuetify version: https://github.com/FlowFuse/node-red-dashboard/pull/1084

I'm guessing some underlying CSS classes were changed, which have affected how our --widget-row-height overrides work
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

This will be a bug that's likely a one or two line fix, but finding what that fix is could be a long exploration


Slate HTML renderer extension for mistletoe

Started a Slate HTML renderer extension for mistletoe. Hopefully I
don't have to switch to marko if mistletoe is not extendable enough.
Either way it would be an easy transistion. This library currently looks
more intuitive to me.
[JIRA: TBC]

Check out _action_types.html to see the html file that was created and rendered with placeholder slate_html_renderer.py file. This will be extended to create html files much closer to the actual slate documentation soon.
This is the first approach I'm going with for the parser as I wanted to use an AST when creating my own markdown parser. It seems like a waste of time to write code that converts markdown text into an AST when it's already included in this pip package. Although in the future if I end up having to write my own markdown->AST code due to unforeseen complications I can at least use the slate_html_renderer.py code to convert my AST to slate html files.


[lightgbm] Revert lightGBM to 3.2.110 for centos 7

Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report
Base: 72.08% // Head: 74.29% // Increases project coverage by +2.20% :tada:

Coverage data is based on head (a750be6) compared to base (bb5073f).
Patch coverage: 73.69% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2387      +/-   ##
============================================
+ Coverage     72.08%   74.29%   +2.20%
- Complexity     5126     6776    +1650
============================================
  Files           473      664     +191
  Lines         21970    29473    +7503
  Branches       2351     3057     +706
============================================
+ Hits          15838    21896    +6058
- Misses         4925     6093    +1168
- Partials       1207     1484     +277

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <0.00%> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <0.00%> (-5.24%)
:arrow_down:

.../modality/cv/translator/ImageFeatureExtractor.java
0.00% <0.00%> (ø)

.../ai/djl/modality/cv/translator/YoloTranslator.java
27.77% <0.00%> (+18.95%)
:arrow_up:

...ain/java/ai/djl/modality/cv/util/NDImageUtils.java
67.10% <0.00%> (+7.89%)
:arrow_up:

api/src/main/java/ai/djl/modality/nlp/Decoder.java
63.63% <ø> (ø)

... and 630 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Test runtime shaving

Description
This PR cuts down on the test runtime significantly.
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have added the relevant labels
[ ] I have updated the official documentation
[x] I have added sufficient documentation in code

Testing

[x] I have tested this code with the official test suite
[ ] I have tested this code manually

Additional comments
Fixes EDGE-383

Can we remove this test and if needed add linear card for it
https://github.com/0xPolygon/polygon-edge/blob/293c8ef910034045c3870958cba16f3afdc15453/txpool/txpool_test.go#L1060

When i have started tests locally i am getting the error
--- FAIL: TestState (0.00s)
state_test.go:122: open tests/GeneralStateTests: no such file or directory
--- FAIL: TestEVM (0.00s)
evm_test.go:146: open tests/VMTests: no such file or directory
FAIL

When i have started tests locally i am getting the error. Tried it 2 times, can you please check this --- FAIL: TestState (0.00s) state_test.go:122: open tests/GeneralStateTests: no such file or directory --- FAIL: TestEVM (0.00s) evm_test.go:146: open tests/VMTests: no such file or directory FAIL

@Aleksao998
Did you pull in the submodules?
git submodule update --init --recursive from the base of the repo

@Aleksao998
Removed the unused TestDemote:
3cd2919
cc @dbrajovic


Introduce job form component

Introduce a job form component – it's mainly needed to work around an issue (DCOS-7669) with the schema form, but might also serve other needs in the future.
/cc @kennyt @Poltergeist

Reviewer: @philipnrmn

Let me add that I'm very unhappy with this solution, and would love if we could fix SchemaForm instead, but I don't have the time nor do I know enough about all the form components to fix it myself.

@orlandohohmeier @kennyt
I am a little bit unhappy with this, because it disguise an underlaying problem, which makes it even more difficult to detect then.
But I also see the need for this right now.
I hope the underlaying architecture will be corrected in the future, so we can get rid of this.
Otherwise we will run in much more trouble later.

@orlandohohmeier
I see! Yes! :)

going to be fixing it this week


runtime/race: memory leak in race runtime

The leak was reported internally on a sever canary that runs for days.
After a day server consumes 5.6GB, after 6 days -- 12.2GB.
The leak is exposed by the following benchmark:
func BenchmarkStackLeak(b *testing.B) {
	done := make(chan bool, 1)
	for i := 0; i < b.N; i++ {
		go func() {
			growStack(rand.Intn(100))
			done <- true
		}()
		<-done
	}
}

func growStack(i int) {
	if i == 0 {
		return
	}
	growStack(i - 1)
}

The leak is fixed upstream in :
http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc?view=diff&r1=276102&r2=276103&pathrev=276103

The change is submitted. The is not autoclosed for some reason. Closing.

Reopened in case this needs to be merged into 1.7.

@dvyukov, we use separate bugs for master fixes vs branch cherry-picks now.


Remove regression tests

Fixes #127

📚 Documentation preview 📚: https://metatensor-models--128.org.readthedocs.build/en/128/

What was the plan to agree in how to handle these tests? I don't remember. We said we do a smoke test and a refression prediction test with a pretrained model?

The idea was to do a minimal regression test without any training, maybe by storing a checkpoint in the repo (assuming the files are small enough?) or by initializing a model with a fixed random seed.
This should allow to check that modifications to the code don't change the output, without having to handle breaking changes on every training script tweak.

I'm not sure. I just know that these tests are quite useless: they break all the time, and if one needs to refactor, they can do their own temporary test, and the reviewer can check by training a small model on main and on the PR branch

I agree that they are currently useless. The problem is that the function is that huge and non-determinisic...
I think you can't ask a reviewer to checkout the repo and run a test locally.
And asking developers to compare with tempory test is noble idea but who is doing this? As a developer you think you know your code and you mess around. Especially for a minor change you don't do any tests - you just push (to main). If there are no tests your code often breaks because you did not consider all consequences of even a minor change. I did this by myself a couple of times.

@Luthaf the pre-trained models are quite large and this repo seems to be already bloated because of them.
Should we keep just the initialization tests and try use a random seed (within the test function, if it's outside pytest sets it during "collection" so adding new tests that are executed before the regression test will break it)

OK. The main issue I can see with tests that just initialize & then run is that if the order of modules inside the architecture changes the test will fail.
A solution would be to manually construct a state_dict, adding members always in the same order. But this will become tedious really fast =/.
So a solution to make it less tedious would be to store a "meta state_dict", like this
{
   "linear.weights": [3, 45],
}

(Sorry, closed by mistake)
OK. The main issue I can see with tests that just initialize & then run is that if the order of modules inside the architecture changes the test will fail.
A solution would be to manually construct a state_dict, always generating the parameters in the same order. But this will become tedious really fast =/.
So a solution to make it less tedious would be to store a "meta state_dict", like this
{
   "linear.weights": [3, 45],
   "linear.bias": [3, 1],
}

Storing only the parameters shapes in a JSON files, and creating the state_dict on the fly but always in the same order (and we can rename fields by changing the JSON). We can have some helper code to create this JSON file from an actual state_dict & documentation on how to use it.
The only issue I see with this approach is model using data that does not end up in the state dict, but I feel like this is manageable.
Does this make sense?

I really do not want to make adding a model any more painful than it is now. This adds a new level of pain. People can have this sort of test if they want to, but I wouldn't require it. To be discussed today

I agree that this is a bit more work, but I think we need some way to ensure a model is still working the same after changing code around it; especially if the code is changed by someone who is not the initial author/maintainer. There will be a review, but we can't rely only on review to catch all mistakes.
The current solution is a bit flaky and should be improved, but I would not just remove tests.


Error: Building package zlib:x64-windows failed with: BUILD_FAILED

Trying to install gtk through vcpkg as per https://www.gtk.org/download/windows.php. Machine is running Windows 10 64-bit 1809 with VS2017 and VS2019 Community installed all fully patched.
Repro steps:

Run PowerShell as admin.
.\bootstrap-vcpkg.bat
.\vcpkg install gtk:x64-windows
Error below

Things I've tried:
Error in attached log references 14.20.27508 directory in compiler path under MSVC directory but that doesn't exist on machine, it's actually 14.21.27702.
Path in error in attached log
C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.20.27508/bin/Hostx64/x64/cl.exe
Actual path to cl.exe
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.21.27702\bin\Hostx64\x64
Tried adding CL env variable with correct path and re-running bootstrap-vcpkg.bat but it fails.
Patched VS2017/2019
Ran vcpkg update
Deleted vcpkg repo and re-cloned.
Ran with VS2019 Developer Command Prompt.
cl.exe compiles a sample c program successfully so compiler is working.
Tried installing other packages, boost seems to install (shows in vcpkg list) but there's a different error, something about not able to locate batch.bat. But I tried CURL package and that gives the exact same error as gtk.
config-x64-windows-out.log
config-x64-windows-out.log
ERROR
CMake Error at gitclones/vcpkg/scripts/cmake/vcpkg_execute_required_process.cmake:56 (message):
Command failed: ninja;-v
Working Directory: D:/Documents/gitclones/vcpkg/buildtrees/zlib/x64-windows-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
D:\Documents\gitclones\vcpkg\buildtrees\zlib\config-x64-windows-out.log
Call Stack (most recent call first):
gitclones/vcpkg/scripts/cmake/vcpkg_configure_cmake.cmake:273 (vcpkg_execute_required_process)
gitclones/vcpkg/ports/zlib/portfile.cmake:22 (vcpkg_configure_cmake)
gitclones/vcpkg/scripts/ports.cmake:71 (include)
Error: Building package zlib:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: zlib:x64-windows
Vcpkg version: 2018.11.23-nohash

Deleted the vcpkg repo on D drive and downloaded to C drive. That got further but still throws BUILD_FAILED error.
config-x86-windows-out.log

@aprykhus Thanks for reporting this issue. Could you do as below steps:

Clone a new vcpkg into your computer, whatever C or D drive.
Modify scripts\bootstrap.ps1 line 371 from /verbosity:minimal to /verbosity:normal and save it.
.\bootstrap-vcpkg.bat > vcpkg.log
.\vcpkg.exe install zlib
If the error still occur, please send the vcpkg.log and the config error log to us.

Thanks for your reply. Followed those steps and still get the error:
vcpkg.log
config-x86-windows-out.log

@aprykhus Please see the compile log of CMakeCCompilerId.c in x86-windows-rel(or x86-windows-dbg)\CMakeFIles\CMakeOutput.log.
I think there should be some error in your compiler. I suggest you repair your VS or reinstall it. I tested it with the same version of vs as yours, and zlib was installed successfully.

VS2019 windows console app threw error "MSB6006 "CL.exe" exited with code 2." Repairing VS2019 fixed the compiler in VS2019 but '.\vcpkg install zlib' still throws same error. Since you can't repro and I'm not spending any more time on this I'll close this issue and open a new one later if necessary.

hello
I have the same problem with vcpkg  in installing any package
help me please

ohhhhh   its on 379 not 371
tax alot

@jefmir Could you please open a new issue for this? Thank you.

I have the same problem with vcpkg in installing zlib, but I have resolved this problem.
Maybe you can also try to update VS2019 to the latest version and install it again


Hello, Can I using the memcached within this web package?

Hello, I am Martin.
I am first using use form golang. I found a full package and was very excited.
How can use the Memcached in this package?
thank you.

See this for reference: https://github.com/blue-jay/blueprint/issues/70. Both packages use gorilla/sessions.


Add a rest api

We have all this data we might as well start making it available :)
I propose we add a very simply API to access these JSON files.
Here is a basic spec idea :
Starting with our main route /
/ -> listing of LETTERS (or anything really)
/LETTER/ -> listing of WORDS that start with LETTER
/LETTER/WORD -> actual word definition
maybe add a fuzzy search also
It might be worth to take a look at lowdb and especially json-server that can offer an API in seconds with a json file. I am unsure if it works with multiple files out of the box.
The main idea would be to keep the data as is (so no unique id added in the files or something like that) to make contributing stay as easy as possible.
As for deployment I strongly recommend https://zeit.co/now as it is free, integrated with github and perfect for continuous release (and easy)
edit: 1GB bandwidth might be low

next step would be a front-end eventually once this is in place

if we do it on js we could also apply for a https://js.org site

indeed @jukefr the js.org perfectly makes sense.

@jukefr @krishnaprasanthg I was planning to make a Google extension out of this or something of that sort. API is the next step, eventually.
I don't know if Google extension is the best of ideas. Suggest if there's anything better

Well Google extension is good to make good use of the data. Maybe like a hover tooltip that does a search in the data for information (thesaurus).
What I feel would be good is to implement #612 first. That will push the first timers to pour in more data (as this will come to slowdown after Hacktoberfest). Gaming factor is always good. Maybe week's top 5 contributes/day top5 .
Once everything is ended then we can implement as a Google extension...
Anyway that's my 2 cents.

created pr #802 relating to this but I welcome some more work on it as it is very rough


Implement multiple payment methods (Wyre, Kyber)

Idea: Easy Crypto -> Stablecoins in-dapp

We can integrate Kyber network to have an in-dapp token converter such that lenders can convert Eth or ERC-20s into stablecoins using Kyber DEX.
I believe Airswap or 0x could offer similar functionality

Idea: Fiat -> Crypto onboarding

We could speak w/ Wyre protocol ("API for compilance and payments") about them handling KYC and fiat onramping for the product.

@tspoff I'd personally love both these options. Kyber would be fantastic, I've been hoping to work with their developer API

@tspoff Let me look into Wyre and update the wireframes. I think it's an interesting way to onboard non-crypto lenders.
Only question: what would be their repayment address? (i.e. who would the debt token be given to?)

@tspoff I've renamed task to its actionable and moved it into backlog

Moved to https://github.com/enabledao/enable-contracts/issues/29


Psychedelicraft shaders not compatible with shader mod

Hello, I made a bunch of test before write an issue here this time.. On 2 different graphic card (2 different computers), with only Psychedelicraft-1.5.2.jar + ivToolkit 1.2.1 installed and with ShadermodCore ShadersModCore-v2.3.31-mc1.7.10-f
Tests have been done on latest forge 1614(1.7.10)
The results are the same, a massive console spam of  "[B#347]  GL error 0x0502: Invalid operation at pre-useProgram".
Could you take a look into it? Should I reffer this issue to shadermod developers too?
This is what I see in the console and the fml latest log too;
http://pastebin.com/YvQvav7T
http://pastebin.com/xYFh4jp2

Shaders are inherently incompatible. There can never be a fix for other shader mods working alongside Psychedelicraft. Best you can achieve is turning off 3D shaders.

Honestly.. the real part that is bad to lose is the "after-water" effect that displays on your screen.. is really nothing that can be done about that?
The only thing I see in the config file is the 2D shader option to disable, and this besides kill the purpose of the mod itself also disable the pretty after-water effect on your monitor :(

The shaderEnabled option is the one to deactivate. The water droplets do work without it... I think. I did a good amount of work to ensure 2D shaders are capable of handling a majority of the effects too.

Ok, I tested it just now, I thought that shaders = false was to disable entirely everything, instead, that option was the "3d shaders" you was talking about, and yes, in effect with 2d shader that pretty water effect at least remain :)

my friend and I tried to install this mod on 1.7.10. but the textures don't work because of it. they broke down. we don't have shaders, standard vanilla Minecraft. But the mod still doesn't work. what to do, please help me 🥺


NLog 4.5 supports Message Template Syntax

Uses the NLog formatter by default, when it detects standard LogMessage with parameters.
Would prefer one could detect that the initial formatter for a LogMessage was DefaultLogMessageFormatter, so it would avoid changing custom formatters.

Only Error--LogEvent has the Cause-exception-property
Sent from my Samsung device
-------- Original message --------
From: Arjen Smits<EMAIL_ADDRESS>Date: 12/06/2018 12:37 (GMT+01:00)
To: "AkkaNetContrib/Akka.Logger.NLog"<EMAIL_ADDRESS>Cc: Rolf Kristensen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [AkkaNetContrib/Akka.Logger.NLog] NLog 4.5 supports Message   Template Syntax (#36)
@Danthar commented on this pull request.

In src/Akka.Logger.NLog/NLogLogger.cshttps://github.com/AkkaNetContrib/Akka.Logger.NLog/pull/36#discussion_r194690873:

@@ -40,9 +40,9 @@ private static void Log(LogEvent logEvent, Action<NLogger, LogEvent> logStatemen
public NLogLogger()
{
Receive(m => Log(m, (logger, logEvent) => LogEvent(logger, NLogLevel.Error, m.LogSource, m.Cause, m.Message)));

LogEvent does not contain an exception property ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/AkkaNetContrib/Akka.Logger.NLog/pull/36#discussion_r194690873, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnMriXR4BTqinEBjz2T6aGyH5cwLsks5t75n6gaJpZM4UjNC5.

@Danthar Is something missing for this to be approved?

Created #37 with unit tests of the NLogLogger


Kitti evaluation

Hello,
awesome work!
When I run the test script for the kitti sequence 10  with your provided weights I receive relative errors that differ from those in the TartanVO paper.

==> ATE: 11.8605,	 KITTI-R/t: 0.0280, 0.0911

In the paper the reported errors are 6.89 (t_r) and 2.73 (r_r).
I used the evaluation script from here: https://github.com/Huangying-Zhan/kitti-odom-eval
and received:

Sequence: 10
Translational error (%):  8.008632651428766
Rotational error (deg/100m):  3.2037836856229243
ATE (m):  58.1216975619417
RPE (m):  0.02597469391189542
RPE (deg):  0.09051218838992246

Would be glad about a hint how you evaluated the results.

Have you found this answer?


fixed bug in OpcUaAdapter

Purpose
Subscription to OPC UA node was not working properly
Approach
Added deep copy of event to avoid preprocessor errors

Hi Christian,
thanks a lot for the bug fix!


Add version informations in status responses

Issue/Task Number: 562
Closes #562
Overview
This PR adds additional info mostly about versions to the different status endpoints.
Changes

/ -> added ewallet_version: "1.1.0"
/api/admin and /api/client -> added "ewallet_version": "1.1.0" and "api_versions":[{"name":"v1","media_type":"application/vnd.omisego.v1+json"}]}
updated mix.exs files in all sub-apps to inherit version from application variable

Implementation Details
Added a new application variable for the :ewallet -> :version
Usage
Check the /, /api/admin and /api/client jsons.
Impact
Additional info in json responses.

Maybe do that in dev.exs and leave the value as "prerelease" or something in prod.exs. I have a script that can be used to update versions so maybe I can use that.

On 28 Nov 2018, at 17:06, Unnawut Leepaisalsuwanna<EMAIL_ADDRESS>wrote:
@unnawut commented on this pull request.
In config/config.exs:

@@ -9,7 +9,7 @@ use Mix.Config

back to each application for organization purposes.
import_config "../apps/*/config/config.exs"
-config :ewallet, root: File.cwd!()
+config :ewallet, root: File.cwd!(), version: "1.1.0"
@sirn It's possible to dynamically get the version from the Mixfile's project.version but I guess that doesn't work with distillery. Any suggestions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Nevermind me, it seems the Mixfile is able to take the version config successfully.


cmd/go, x/mod: "invalid go version" message mentions old version format

When parsing an invalid go line in a go.mod, the error message says
go: errors parsing go.mod:
go.mod:3: invalid go version '1.22foo': must match format 1.23

but that's not strictly true, it doesn't have to match the 1.23 format anymore.

cc @bcmills

What version of the go CLI was this with? I've hit this this morning when using gopls that's been compiled with a pre-1.21 go

just came across this, to update vscode go tooling:

Press Ctrl+Shift+P
Select Go: Install/Update tools

or just to update golang language server:
go install golang.org/x/tools/gopls@latest

and you may Ctrl+Shift+P to restart language server

I just got this error message recently after I updated go. I updated gopls as well and that did not fix it. For now I've manually edited the version number to be 1.21 rather than 1.21.1

I am also noticing this occurring in newly go mod init'd projects on fresh pull of gopls@latest.  Manually edition the go version allows the language server to restart without error.  I'm using vim-go which utilizes YouCompleteMe for the LSP communication to gopls.
go version
go version go1.21.0 linux/amd64

gopls version
golang.org/x/tools/gopls v0.13.2
<EMAIL_ADDRESS>h1:Pyvx6MKvatbX3zzZmdGiFRfQZl0ohPlt2sFxO/5j6Ro=

I am also running into this. Similar setup to @optik-aper:
go version go1.21.1 linux/amd64
golang.org/x/tools/gopls v0.13.2
<EMAIL_ADDRESS>h1:Pyvx6MKvatbX3zzZmdGiFRfQZl0ohPlt2sFxO/5j6Ro=

Possibly related to #63370?
There seems to be confusion to what version numbers the tools should support. Part of the challenge of introducing a new format and requiring it in the same release I think?

For me fixing version in go.mod and go.work to 1.21 didn't resolve the issue :(
What am I missing?

Hrm... should do this for all other modules in a workspace as well
Okay, changing all stuff to 1.21 resolved the issue
Is there currenlt no way to specify the version exactly, like 1.21.3?

Is this related to #62584?

Still an issue please fix

@kampaidev https://go.dev/wiki/NoPlusOne

I'm also getting this error, using:
go version
go version go1.21.5 darwin/arm64

gopls version
golang.org/x/tools/gopls v0.11.0
<EMAIL_ADDRESS>h1:/nvKHdTtePQmrv9XN3gIUN9MOdUrKzO/dcqgbG6x8EY=

Previously I'd get around it by editing the go.mod file and removing the patch version, for example by changing go 1.21.4 to go 1.21 and that still works if the the mod file doesn't use replace if it does, then I get:
updates to go.mod needed, disabled by -mod=readonly; to update it: ^Igo mod tidy

To get it working I have to:

edit the go.mod file to remove the patch version, for example by changing go 1.21.4 to go 1.21
run go work init . .
edit the go.work file to remove the patch version, for example by changing go 1.21.5 to go 1.21

but why? why is all this needed? why are the patch versions being added to the mod files?

I'm also getting this error, using:
go version
go version go1.21.5 darwin/arm64

gopls version
golang.org/x/tools/gopls v0.11.0
<EMAIL_ADDRESS>h1:/nvKHdTtePQmrv9XN3gIUN9MOdUrKzO/dcqgbG6x8EY=

Previously I'd get around it by editing the go.mod file and removing the patch version, for example by changing go 1.21.4 to go 1.21 and that still works if the the mod file doesn't use replace if it does, then I get:
updates to go.mod needed, disabled by -mod=readonly; to update it: ^Igo mod tidy

To get it working I have to:
* edit the `go.mod` file to remove the patch version, for example by changing `go 1.21.4` to `go 1.21`

* run `go work init . .`

* edit the `go.work` file to remove the patch version, for example by changing `go 1.21.5` to `go 1.21`

but why? why is all this needed? why are the patch versions being added to the mod files?

Also getting this at 1.21.5.
Had to move to 1.21

Looks like this was partially fixed in x/mod in https://go.dev/cl/527897, but we missed the ones in WorkFile.add:
https://cs.opensource.google/go/x/mod/+/master:modfile/rule.go;l=633-649;drc=6e58e47c7bd6672665dc35cce7b1f325d2addd67
🤦♂

Happy to merge if you can raise a PR

I think this is fixed as of https://go.dev/cl/560855.

@bcmills can we backport this CL to 1.21 and 1.22?
https://github.com/hashicorp/terraform using go1.21.5

@maxmeng-hw, the only change for this issue was to an error message. That does not seem worth backporting.

If anyone has the same issue when building a docker image, consider making the go version on your machine the same as the one in the Dockerfile
Step 4/8 : RUN go mod download
 ---> Running in 23ecb7792e18
go: errors parsing go.mod:
/app/go.mod:3: invalid go version '1.22.0': must match format 1.23

In my case, I was using Go 1.22 on my machine whereas the Dockerfile was using the base image of golang:1.18.0-alpine.

just came across this, to update vscode go tooling:

Press Ctrl+Shift+P
Select Go: Install/Update tools

or just to update golang language server:
go install golang.org/x/tools/gopls@latest

and you may Ctrl+Shift+P to restart language server

After doing the steps above , you sometimes have to manually close and reopen vscode (even Ctrl+Shift+P then 'Reload Window' doesnt worked for me )

Sorry to bump and old thread but there's another way to go around it since in my case even a language server restart didn't fix the issue. Instead of forcing gopls version updates, i saw that my vscode itself was using an older go binary (which could very well be why the solution wasn't working for me). I personally use and recommend gvm for managing multiple go versions so i thought of using the path that is specified by gvm for go1.21.5 and forcing vscode to use that. Step by step:

Run gvm use go1.21.5 or whichever version you want, then echo $GOROOT:

 [-> echo $GOROOT
 /Users/your_username/.gvm/gos/go1.21.5

From the bottom right of the vscode window, select the go version -> Choose Go Environment -> Choose from file browser. Hit Cmd+Shift+. to be able to view hidden folders in the file explorer and then locate the path above. Navigate to bin->go and select that file.
Follow the vscode prompt to recompile gopls and other modules with this version and it will automatically restart the language server after that.


Update config.yml

For disabling

This does not appear to be a valid config option?

Thanks for the help @Mause ! 🍰


Expression2 chip cannot send data signal to itself

Can be tested with a minimal code sample:
dsSendDirect("Name", entity(), 42)
if (dsClk("Name")){
    hint(dsGetNumber():toString(), 10)
}

Why would you want to

This used to work just fine, only later did I find out this is now intended functionality. It'd still be nice to have it back.
Personally I'd use this as a makeshift callback system. The only 'first-class' function support there is otherwise is 'calling' a string variable, which has quite a lot of limitations. This would be especially useful for handling events from library code that's been #include'd.

Calling a string variable has limitations that datasignals don't? Like what? Datasignals have way more limitations, not to mention they are way WAY more resource intensive to call

Maybe he has a framework designed to allow e2s to communicate with each other and in some cases the chip needs to communicate with itself. I never use datasignals so I'm just guessing.

There's been a check in place since April 2012 https://github.com/wiremod/wire/commit/2f8e748151bae129d62ef0acd32c9164dc43d051#diff-2c043cedd54bd76a4d37f3cf98c4746cR53 , though we could probably remove it to no ill effect.

I don't see any situation where you need to send a signal to the E2 itself
Also if we erase that check, there's a possibility that sending a signal to a group that the E2 is itself in, will cause the E2 to receive its own signal, which we don't want. The only case where we MIGHT want this is in dsSendDirect, but like I said I can't see any situation where we want it there either. Datasignals wait 1 tick, and then execute the entire receiving E2. Not only are they slower than function calls, they are also much laggier. And they're no more versatile than just using a callable string.
Datasignals are for communicating with other E2s. Allowing them to make the E2 execute itself just promotes bad code.

Computer networks are for communicating with other computers, but nobody claims it's bad practice to run a local HTTP server and then connect to it.
I'd say if an E2 is in a group and something sends a signal to that group, then the E2 should receive it - regardless if that E2 is the one that sent the signal or not. Adding this "no loopback" check is just another corner case, it makes things less simple in design.

Nothing wrong with it in a http server, but this is E2, and executing E2s is probably the most expensive operation there is.

To me, this seems to be analogous to explicitly disallowing 0 in addition. Yes, it's useless to add zero to something, but disallowing it just because you don't see a real use case is only going to trip up people expecting consistent behavior. If you're going to send a signal with dsSendDirect to an array of chips, and that array includes the sender, it'll just refuse to send the signal because there was a specific check in place to prevent loopback. This would make perfect sense if there was some technical limitation that would cause inevitable breakage when loopback occurs, but even then it'd be good practice to either alert the programmer through a console message, or clearly document the fact that loopback is NOT allowed.
I propose to remove the check, if only as a feature request. It'll get rid of a redundant branch in the logic, and it'll mean dsSendDirect will have consistent behavior.

The problem with your 0 addition analogy is that +0 is a really cheap operation compared to executing an E2.
There's also the thing where people are inevitably going to crash their own E2s because they placed their dsSendWhatever in the wrong place in their E2, causing the signal to send itself over and over, causing an infinite loop. But hey I guess they'll learn that the hard way, then.
If you're going to send a signal with dsSendDirect to an array of chips, and that array includes the sender, it'll just refuse to send the signal because there was a specific check in place to prevent loopback.
Pretty sure it will send the signal just fine to every other E2
I propose to remove the check, if only as a feature request. It'll get rid of a redundant branch in the logic, and it'll mean dsSendDirect will have consistent behavior.
Currently, the same logic is used for sending a signal to a group as when sending to a single E2. In fact, when sending to a group, it'll loop through all E2s in that group and use the same code as dsSendDirect on each of them. So this means that if we simply remove the check, it'll be removed for sending to groups as well as direct. Unless we add some "type" arguments to the function to check if the current signal is a group or a direct signal.
Very often, the E2 is going to be in the same group that it's sending to, and 99.99% of the time there's no need to send a signal to itself, and since executing an E2 is very expensive, it's good to avoid it. This is the main reason I'm against this. Why enable a feature that no one will ever use just to make it more "consistent", which would passively make datasignals much more laggy? As well as increase your E2's ops significantly, giving you less to work with.
Of course, as mentioned above, we could add a "type" argument to the code to make sure that only dsSendDirect has this feature. That way we avoid most of the problems I mentioned above. Then I wouldn't be against it as much.

Right, I see what you mean, dsSend to a group would cause the chip to self-trigger one tick later if it's in the same group as it's sending to, which is not going to be desired behavior in pretty much every case. Indeed, only dsSendDirect seems to be the odd one out when explicitly passing the sender as an argument will get rejected.
I have no issue with disallowing this by default. Even if that means the user has to jump through extra hoops to achieve self-triggering, that's only going to discourage its use if anything, and then it'll at least be there 'just in case'.

Remember the Linux principle: one should not restrict people from doing things for the sake of it. For example, if an end-user wants to do something crazy like run GParted on a dirty partition, then it is in the best interest for the GParted/fdisk/e2fs developers to add an override switch to allow the end-user to do this, as long as the end-user fully understands the consequences if this goes wrong.
Same goes for datasignals: when a scripter explicitly sends a signal to his own E2, then it is assumed that he knows what he is doing and this operation should be allowed at whatever cost. For any other case, however, this behavior should not be depended upon if the scripter is not aware of loopback behavior.
So scripters who want this specific behavior should be asked to override the restriction in their own scripts by saying something like dsToggleLoopback(true) at the beginning of their code.


User is informed immediately if a duplicate email address or user name is provided

What was changed
1.) Complete UI Overhaul into distinct components.
2.) Remove of outdated Handler interface and implementation
3.) Replace manual validation checks with vaadin binder allowing to show an invalid input immediatly to the user.
4.) Field specific Error notifications are replaced with the error message in their corresponding fields.
Missing
Invalid and valid feedback icon next to each field is not provided as of yet.
To keep this PR manageable, the outdated domain logic was not touched.

This is included in the SSO orcid PR #651


Okhttp

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@411bcf2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #1   +/-   ##
========================================
  Coverage          ?   0.00%
========================================
  Files             ?     170
  Lines             ?    4249
  Branches          ?     479
========================================
  Hits              ?       0
  Misses            ?    4249
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411bcf2...fd160a3. Read the comment docs.


differing number of tests

I've just encountered an interesting issue.  I have a suite of Minitest tests. When running bundle exec m and running bundle exec m -r test I am seeing a different number of tests being run.  The difference appears to be the number of tests that aren't in the standard set of test folders.
I have a test/services folder where those tests aren't running during the bundle exec m run but are in the recursive call.  Also, The tests are running when I specifically run bundle exec m test/services/[test file name] so I know the m gem is picking them up at some point.
Thoughts?
(e)
PS: be in my screenshots is just my alias for bundle exec

That is odd and should not be the expected behaviour. I'll look into it. Thanks.

followup…  In parser.rb you are calling rake test if no argv is passed in.  According to what I've read rake test does not attempt to run tests outside the standard set.  But rake test:all does.
Perhaps changing to calling out to rake test:all is the better solution.
Just a thought.
(e)

There is a proposed solution, if it does not work please reopen the issue.


dar: 2.7.0 -> 2.7.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dar/versions.
meta.description for dar is: "Disk ARchiver, allows backing up files into indexed archives"
meta.homepage for dar is: "http://dar.linux.free.fr"
meta.changelog for dar is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1/bin/dar passed the binary check.

/nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1/bin/dar_xform passed the binary check.

/nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1/bin/dar_slave passed the binary check.

/nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1/bin/dar_manager passed the binary check.

/nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1/bin/dar_cp passed the binary check.

/nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1/bin/dar_split passed the binary check.

3 of 6 passed binary check by having a zero exit code.

6 of 6 passed binary check by having the new version present in output.

found 2.7.1 with grep in /nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1

found 2.7.1 in filename of file in /nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1

directory tree listing: https://gist.github.com/6bd19113e96722fc13ef3c784b5d83e6

du listing: https://gist.github.com/691bd132ba57134ab1db1338b46f2280

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
dar

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dar https://github.com/r-ryantm/nixpkgs/archive/21b6ba946516ab55b30de24cc8aa10d739440b33.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1
ls -la /nix/store/72zh9i2d354j6hs5h0lq3qqzdi7bir8v-dar-2.7.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dar

Maintainer pings
cc @izorkin for testing.

Result of nixpkgs-review pr 123233 at 21b6ba94 run on x86_64-linux 1

1 package built successfully:

dar

1 suggestion:

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/backup/dar/default.nix:48:5:
   |
48 |     license = licenses.gpl2;
   |     ^

@ofborg build dar

darwin failure looks unrelated


Full syntax for stage is missing: lockBehavior

The "The full syntax to specify a stage" section is missing: lockBehavior
- stage: A
  lockBehavior: sequential # or: runLatest

See release notes at: https://docs.microsoft.com/en-us/azure/devops/release-notes/2021/sprint-190-update?WT.mc_id=DOP-MVP-21138#support-for-sequential-deployments-rather-than-latest-only-when-using-exclusive-lock-checks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d322215c-8025-4f21-0700-7dfa7dc5c46e
Version Independent ID: 141fcdbb-8394-525b-bb29-eff9a693a9c4
Content: Stages in Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/process/stages.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@NenoJoje - There's more information on this now in our YAML schema docs - https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/stages-stage?view=azure-pipelines#exclusive-lock


Resolve integration tests

This isn't quite done yet -- not only does it depend on eregs/regulations-parser#310, there's no doubt additional errors

Nice work!