[Broken] YouTube comments use account language timestamps, breaking yt-dlp

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running yt-dlp version 2021.07.07 (I'm using current master, cca80fe)
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log
~/przechowalnia/archiwum_youtube/testy $ yt-dlp -v --no-download --write-comments --cookies ../_meta/cookies.txt 'https://www.youtube.com/watch?v=-b-BjBQrOLc' 2>&1 | tee comments.log
[debug] Command-line config: ['-v', '--no-download', '--write-comments', '--cookies', '../_meta/cookies.txt', 'https://www.youtube.com/watch?v=-b-BjBQrOLc']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] yt-dlp version 2021.07.07
[debug] Python version 3.7.3 (CPython 64bit) - Linux-4.19.0-17-amd64-x86_64-with-debian-10.10
[debug] exe versions: ffmpeg 4.1.6-1, ffprobe 4.1.6-1
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=-b-BjBQrOLc
[youtube] -b-BjBQrOLc: Downloading webpage
[youtube] -b-BjBQrOLc: Downloading android player API JSON
[youtube] -b-BjBQrOLc: Downloading MPD manifest
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] Testing thumbnail 37
[debug] Default format spec: bestvideo*+bestaudio/best
[info] -b-BjBQrOLc: Downloading 1 format(s): 299+251
[youtube] Downloading comment section API JSON
[youtube] Downloading ~3 comments
[youtube] Sorting comments by od najnowszych
[youtube] Downloading comment API JSON page 1 (0/3)
ERROR: time data 'now-5dni' does not match format '%Y%m%d'
Traceback (most recent call last):
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/YoutubeDL.py", line 1145, in wrapper
    return func(self, *args, **kwargs)
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/YoutubeDL.py", line 1181, in __extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/YoutubeDL.py", line 1222, in process_ie_result
    ie_result = self.process_video_result(ie_result, download=download)
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/YoutubeDL.py", line 2217, in process_video_result
    self.process_info(new_info)
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/YoutubeDL.py", line 2377, in process_info
    self.post_extract(info_dict)
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/YoutubeDL.py", line 2872, in post_extract
    actual_post_extract(info_dict or {})
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/YoutubeDL.py", line 2864, in actual_post_extract
    extra = post_extractor().items()
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/extractor/youtube.py", line 3020, in <lambda>
    info['__post_extractor'] = lambda: self._extract_comments(ytcfg, video_id, contents, webpage)
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/extractor/youtube.py", line 2227, in _extract_comments
    for comment in _real_comment_extract(contents):
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/extractor/youtube.py", line 2219, in _real_comment_extract
    account_syncid=self._extract_account_syncid(ytcfg))
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/extractor/youtube.py", line 2156, in _comment_entries
    for count, entry in enumerate(extract_thread(continuation_items)):
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/extractor/youtube.py", line 2073, in extract_thread
    comment = self._extract_comment(comment_renderer, parent)
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/extractor/youtube.py", line 1997, in _extract_comment
    time_text_dt = self.parse_time_text(time_text)
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/extractor/youtube.py", line 1986, in parse_time_text
    return datetime_from_str('now-%s%s' % (time_text_split[0], time_text_split[1]), precision='auto')
  File "/home/grzesiek11/.local/pipx/venvs/yt-dlp/lib/python3.7/site-packages/yt_dlp/utils.py", line 3188, in datetime_from_str
    return datetime_round(datetime.datetime.strptime(date_str, format), precision)
  File "/usr/lib/python3.7/_strptime.py", line 577, in _strptime_datetime
    tt, fraction, gmtoff_fraction = _strptime(data_string, format)
  File "/usr/lib/python3.7/_strptime.py", line 359, in _strptime
    (data_string, format))
ValueError: time data 'now-5dni' does not match format '%Y%m%d'

Description

YouTube seems to have rolled out a change to comment timestamps (n units ago, for example 11 days ago), which now are dependent on account (?, not sure, but definitely not geolocation) language (for example 11 dni temu).
This means yt-dlp will break when downloading comments with cookies.txt from non-English accounts, because it uses timedate to calculate timestamps, which only works with English units.
A dirty fix by me, definitely not good for a merge, but if somebody needs to get it working now, here it is. Licensed under The Unlicense. You need to adjust the unit prefixes with ones for your language (these are for Polish):
yt_dlp/extractor/youtube.py:1979
    def parse_time_text(time_text):
        """
        Parse the comment time text
        time_text is in the format 'X units ago (edited)'
        """
        time_text_split = time_text.split(' ')

        translations = {
            'd': 'days',
            'm': 'months',
            'l': 'years',
            'm': 'minutes',
            'g': 'hours',
            's': 'seconds'
        }

        for i in range(len(time_text_split)):
            for translation in translations.items():
                if translation[0] in time_text_split[i]:
                    time_text_split[i] = translation[1]

        if len(time_text_split) >= 3:
            print(time_text_split)
            return datetime_from_str('now-%s%s' % (time_text_split[0], time_text_split[1]), precision='auto')

Another solution could be to look into seeing if there is a way to force the API to return the response as English regardless

Another potential solution could be to look into seeing if there is a way to force the API to return the response in English regardless

Surely this can be done by setting the Accept-Language header?
'Accept-Language': 'en-US, en, *'

Another potential solution could be to look into seeing if there is a way to force the API to return the response in English regardless

Surely this can be done by setting the Accept-Language header?
'Accept-Language': 'en-US, en, *'

Hmm doesn't seem to be (typical YouTube). Looking at the API requests it is probably dependent on the hl parameter in the client context data given. Should be easy enough to overwrite.


Helm create accepts uppercase characters

helm create MyChart

Creates a chart called MyChart. The expected behavior would be failing with an "Uppercase characters in chart name not supported" message.

https://helm.sh/docs/chart_best_practices/conventions/#chart-names
From the official documentation, Chart names must be lower case letters and numbers,The verification logic is missing here
I can try to fix

https://helm.sh/docs/chart_best_practices/conventions/#chart-names
From the official documentation, Chart names must be lower case letters and numbers,The verification logic is missing here
I can try to fix

this seems like a regression.

this seems like a regression.

Are uppercase letters not supported? I see where it says that in the documentation, but have never checked to see if that is true. We should definitely render the two consistent.
Release names are lowercase because of the DNS requirements of Kubernetes. I am not sure if this holds true for chart names. (Same with things like non-ASCII letters)

Are uppercase letters not supported? I see where it says that in the documentation, but have never checked to see if that is true. We should definitely render the two consistent.
Release names are lowercase because of the DNS requirements of Kubernetes. I am not sure if this holds true for chart names. (Same with things like non-ASCII letters)

Apart from consistency reasons, does it hurt if we continue to allow uppercase characters ? There is a potential to cause backwards compatibility issues if we stop supporting upper case characters.
Maybe we could just update the docs for now, and reconsider this for v4?

Apart from consistency reasons, does it hurt if we continue to allow uppercase characters ? There is a potential to cause backwards compatibility issues if we stop supporting upper case characters.
Maybe we could just update the docs for now, and reconsider this for v4?

I don't really see any backward compatibility issues. There is no way to install a chart that is created via "helm create UpperCase" unless people afterwards updates the name in Chart.yaml.

I don't really see any backward compatibility issues. There is no way to install a chart that is created via "helm create UpperCase" unless people afterwards updates the name in Chart.yaml.

This change should not break backward compatibility. If charts are installed, it will verify that the chart name complies with this rule, but if the charts have already been installed and need to be updated, it will not have any effect.

This change should not break backward compatibility. If charts are installed, it will verify that the chart name complies with this rule, but if the charts have already been installed and need to be updated, it will not have any effect.

Sorry I wasn't clear :
If folks have scripts / tooling which do a "helm create UpperCase", those scripts/tools will break :)
I don't think it's a big issue, though.

Sorry I wasn't clear :
If folks have scripts / tooling which do a "helm create UpperCase", those scripts/tools will break :)
I don't think it's a big issue, though.

Yes, it is not a serious issue. Perhaps the best way is to correct the document and note the ideal format，the existing format will be depreacted in V4 and  the code will be fixed in V4.

Yes, it is not a serious issue. Perhaps the best way is to correct the document and note the ideal format，the existing format will be depreacted in V4 and  the code will be fixed in V4.

We do not have enough consensus to determine if this will break compatibility for some users. The safe option is to hold off on merging any PRs that will enforce this behaviour until Helm 4.

We do not have enough consensus to determine if this will break compatibility for some users. The safe option is to hold off on merging any PRs that will enforce this behaviour until Helm 4.


Hard-coded length limits on createCUDABatchAligner causing poor performance

I've been trying to polish one of our mock community datasets with racon-gpu, but am seeing slow performance during the overlap alignment phase.

I can see many alignments are not being run on the GPU, but the CPU instead. Admittedly, slow performance was exacerbated by the use of only four CPU cores. I've had a little look around the code and as I understand it, an alignment can be prevented from running on the GPU under two conditions:

the query or the target is too long
the maximum number of overlaps has been reached for the batch?

I see there is also an error mode for exceeded_max_alignment_difference but I can't seem to find a case where that is actually raised by CUDAAligner.
I've checked the stats on the reads I am assembling and polishing with and the N50 is 28.3 Kbp (nice one @joshquick), so I'm thinking perhaps our longest reads are getting thrown off the GPU and are left to run on the CPU afterwards.
I've found where the CUDABatchAligner is initialised and see it has hard-coded limits of 15000 for both the max query and max target. Is this a specific limit for performance reasons, or would it be possible to perhaps allow users to set these limits themselves? Does the choice here affect the memory allocation on the GPU later? Ideally we'd want to raise it to at least 25Kbp, if not 50Kbp.
Just to check I was on the right track, I've filtered this data set of reads longer than 15Kbp and run the polishing again; and see there's now very little time spent aligning overlaps on the CPU. Though, I'm not entirely sure if this is just because the reads are <= 15 Kbp, or if there are fewer reads.

I thought I would try raising this myself, but it seems to linearly require more memory, meaning you must run fewer batches. This ends up taking much more GPU time overall, and presumably wastes a lot of memory in cases where the reads assigned to a batch are much shorter than the maximum allowed length.


.env varaible not working in index.html

Describe the bug
In the index.html I tried accessing my env varaibles.
It's not working at all and there's no concrete example in the docs.
Reproduction
In my index.html file I add this.
<script src="https://www.paypal.com/sdk/js?client-id=<%= import.meta.env.VITE_SOME_KEY %>">
</script>

It didn't work, then tried this
<script src="https://www.paypal.com/sdk/js?client-id=<%= process.env.VITE_SOME_KEY %>">
</script>

It didn't work either, then tried this
<script src="https://www.paypal.com/sdk/js?client-id=<%= VITE_SOME_KEY %>">
</script>

System Info
System:
    OS: Windows 10 10.0.19043
    CPU: (8) x64 Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
    Memory: 4.75 GB / 15.76 GB
  Binaries:
    Node: 14.15.4 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.14.10 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 91.0.4472.114
    Edge: Spartan (44.19041.1023.0), Chromium (91.0.864.67)
    Internet Explorer: 11.0.19041.1
  npmPackages:
    @vitejs/plugin-vue: ^1.2.4 => 1.2.4
    vite: ^2.4.0 => 2.4.1

Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

Duplicate of #3105


[SPARK-37014][PYTHON] Inline type hints for python/pyspark/streaming/context.py

What changes were proposed in this pull request?
Inline type hints for python/pyspark/streaming/context.py from Inline type hints for python/pyspark/streaming/context.pyi.
Why are the changes needed?
Currently, there is type hint stub files python/pyspark/streaming/context.pyi to show the expected types for functions, but we can also take advantage of static type checking within the functions by inlining the type hints.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144297/

CC @HyukjinKwon @ueshin @zero323 FYI. Thanks!

Test build #145101 has started for PR 34293 at commit 7a70727.

Test build #145101 has finished for PR 34293 at commit 7a70727.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145101/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49570/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49570/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49570/

cc @itholic mind reviewing this please?

This should be resynced with master.

Seems fine to me.
Would you mind taking a last look for this, @zero323 ??

Seems fine to me.
Would you mind taking a last look for this, @zero323 ??

It requires re-syncing with master and removal of obsolete ignores, but looks OK otherwise.

@dchvn Would you mind rebasing to the master?

I don't know why my GA has failed, I will update my other PRs once I know how to fix it. Thanks, @itholic @zero323  for your reviews.

I don't know why my GA has failed, I will update my other PRs once I know how to fix it. Thanks, @itholic @zero323 for your reviews.

@dchvn  This error is thrown by explicit checks in our wokflow, see this and this.

(BTW, there's a bug in GitHub Actions' RESTful API so the check fails. I sent an email to dev mailing list "PR builder not working now")

Thanks for looking into the this @HyukjinKwon and @itholic. LGTM (all tests passed locally).

Merged into master and branch-3.3.

Thank all :heart:


Updated Scenario Aggregates, Events, Repositories to be simplified to not provide additional infrastructure wrapping around Marten

Based on the Discussion on Gitter Updated Scenario Aggregates, Events, Repositories to be simplified to not provide additional infrastructure wrapping around Marten. That will make it more straightforward for new users (eg. to not think why did we used custom aggregation instead of the default one.
Fixed also version handling for the optimistic concurrency.
Question raised on Gitter:
ddivita
@ddivita
Jun 24 21:39
Int the repository example here: http://jasperfx.github.io/marten/documentation/scenarios/aggregates_events_repositories/ The method : protected void Register<T>(Action<T> handle) is manually setting the handlers as opposed to Marten automatically registering the Applymethods on the Aggregate Root?

@ddivita fyi

Some remarks regarding the changes:

The aggregate is about protecting its invariants -> I find the public setter on Id confusing, as I'd expect it to not change.
Each public method on the aggregate now has to remember to call two methods (Enqueue, Apply).
Each Apply method now has to remember to restore the aggregates version.
The aggregate version is restored from the version stored in the event. Now, while not a typical scenario, what if I decided to rewrite (or copy) the stream and e.g. delete events. Should the version of the aggregate match that of the number of events it is indexing in the stream as that would no longer be the case.

@jokokko see my answers below

The aggregate is about protecting its invariants -> I find the public setter on Id confusing, as I'd expect it to not change.
I can remove it in this example, although this is current Marten limitation for projections to have public setter with Id, so inline projection might not work correctly.

Each public method on the aggregate now has to remember to call two methods (Enqueue, Apply).
That's correct, but it's the same number of calls as the registrations in constructor. Also it's the common pattern used in Event Sourcing. Having them in the methods we don't need to do custom aggregation. Imho previous solution with custom aggregation might be good or even better solution at the end, but imho we should show in scenarios the most common scenarios. So showing that Marten user needs to write custom aggregator might be confusing and might bring the thoughts "why Marten doesn't have it out of the box? Why do I need to write my own wrappers?", while it's doable without that. Also I personally prefer explit calls where you can debug without reflection and see precisely what's going on instead of reflection.

The aggregate version is restored from the version stored in the event. Now, while not a typical scenario, what if I decided to rewrite (or copy) the stream and e.g. delete events. Should the version of the aggregate match that of the number of events it is indexing in the stream as that would no longer be the case.
Yes, but without that optimistic concurrency won't work properly, as you need to read from somewhere the version number. Imho we should give the possibility in Marten to apply stream and event metadata to the stream/events field during aggregation (as optional of course). So eg. when aggregate has field Version or event has field version then it will be mapped from the metadata. I know that it's possible to use Event but it's cumbersome, as it won't be easily used during the event creation in public method. The other option is to split IEvent into smaller intefaces.

@jokokko thoughts?

@jokokko any thoughts for my response? ;)

@jokokko any updates?

@oskardudycz Sorry for the delay. I'm fine with merging this. Although, I am not a fan of events having mutable surface, in this case the Version property. Given that events, by definition, should be immutable. There's also the option to have both implementations in the samples if it's not thought too confusing, e.g. they are offered as alternative implementations of each other.

@jokokko I removed IVersionedEvent interface with public setter from the Event to not make it mutable (See more in commit: https://github.com/JasperFx/marten/pull/1299/commits/9200cb85639fb3738630eb4d8f62fe1818dd22a1).
Although I don't fully like it, as it's some kind of redundancy of data and need to do it manually (while it's going on under the hood). I created new issue to make possible automatic mapping of metadata information to event: https://github.com/JasperFx/marten/issues/1337
@jokokko what do you think?

@mysticmind I'm fine with merge. Ideally, I'd want the aggregate not to have the mutable Id and version propagating to each event & each Apply being responsible for "restoring" the aggregate version. But better get this PR off the table.

@jokokko public mutable Id is current Marten limitation for the Inline Projection. It has to be property named Id with public getter and setter. I'd like to change that in v4.0 but currently it is as it is.

#1355 has been merged in lieu of this. Closing this one.


Non-critical CSS-error-messages removed from debug.log

The following log-messages were caused by setting a non-existing property via CSS in the "Options" dialogue.
GUI: QCheckBox(0x7fe0214e7fd0, name = "bitcoinAtStartup")  does not have a property named  "alignment"
GUI: QCheckBox(0x7fe021500540, name = "minimizeToTray")  does not have a property named  "alignment"
GUI: QCheckBox(0x7fe021502540, name = "minimizeOnClose")  does not have a property named  "alignment"
GUI: QCheckBox(0x7fe0214f9d20, name = "mapPortUpnp")  does not have a property named  "alignment"
GUI: QCheckBox(0x7fe0214fa280, name = "allowIncoming")  does not have a property named  "alignment"
GUI: QCheckBox(0x7fe0214f9de0, name = "connectSocks")  does not have a property named  "alignment"
GUI: QCheckBox(0x7fe0214f8df0, name = "coinControlFeatures")  does not have a property named  "alignment"
GUI: QCheckBox(0x7fe0214f9260, name = "spendZeroConfChange")  does not have a property named  "alignment"

It's fixed now.

another single line fix :smile: :+1:


when listItems is empty, an exception breaks page execution

Ok, this is another issue which is more of a usability improvement, but if issue occurs it breaks page loading altogether.
Expected behavior and actual behavior:
When setting the px-inbox list-items to a value which is empty ( which happens when it is filled in after an ajax request for example ) I get the following stack trace in the console:

Uncaught TypeError: Cannot read property 'id' of undefined
at HTMLElement._formatDates (px-inbox.html:197)
at HTMLElement._observerEffect (polymer.html:1662)
at HTMLElement._effectEffects (polymer.html:1507)

Steps to reproduce the problem:
This happens due to the observed value of the listItems property (  observer: '_formatDates' ). when it is nulled out or set to [] - and this might happen if the AJAX request fails and the listItems are set to []  - the page will not load (pb due to exception above )
The fix would pb be something like below at px-inbox.html:186
 if (!this.listItems || this.listItems.length == 0 ){         return;       }

Fixed in v0.2.29 - thanks!

Oops, had a bit of confusion with versioning with Elliot's typo fixes - went ahead and tagged the latest as 1.0.0, since bower and semver behave a little odd before 1.0.0 anyway.


Please check your name in Pepper & Carrtot Motion Comic credits

@mleduque Can you please check if your name is attributed correctly in the credits of Pepper & Carrot Motion Comic? - https://morevnaproject.org/2017/05/26/pepper-carrot-credits/
Currently there is a nickname instead of your real name. Please contact me ASAP if you want this changed to your real name.
P.S. Sorry, Haven't found any other way to reach you out. ^__^"

Hi,
OK si I though I didn't care either way, nickname or real name. Now after actually seeing it I feel it's missing something and I thank you for insisting.
Please use my real name if you would, Mickaël Leduque, and sorry for taking so much time to change my mind.
Mickaël

Great! I will need an email confirmation from you (from the same address that you used for Indiegogo account). This is necessary routine, just to be sure that you are the same person. Please check your mailbox for my confirmation request. ^__^

Hello @mleduque! I have made changes to the credits and published updated version. Please check if everything is alright now - https://morevnaproject.org/2017/05/26/pepper-carrot-credits/

Everything is OK, thanks!

Great!


New report: Day 80

Finish learning Fortran. Conclusion reached. Goal accomplished.

I have finished the challenge much more early than anticipated.


Session Metrics incorrect using hazelcast-jetty-sessionmanager

We are using Jetty 9.3.x with Hazelcast-Jetty-Sessionmanager for Jetty 9. I noticed metrics emitted by Hazelcast Session Manager is limited to the JVM and does not consider sessions available across cluster.
This behavior seems to be originating from org.eclipse.jetty.nosql.NoSqlSessionManager which is extending org.eclipse.jetty.server.session.AbstractSessionManager, this class has embedded logic to use org.eclipse.jetty.util.statistic.CounterStatistic and org.eclipse.jetty.util.statistic.SampleStatistic. These Statistics information models do provide support for cluster and are very JVM specific.
I believe Session Metrics exposed when using Hazelcast Jetty Session Manager should be cluster based than JVM based. In order to fix this behavior the above needs to change.
Let me know if contributions are welcome, will be happy to send a pull request across.
Version Details :-
Jetty - 9.3.x
JDK - 1.8.x
Hazelcast - 3.10.4
Hazelcast-Jetty-SessionManager - 1.0.2
Regards,
-Yogesh

Hi @yogeshrao ,
Can you please open the issue on Jetty Repository and send potential contribution there?

Hello @mesutcelik
I did look at Jetty repository especially Jetty-Hazelcast project for 9.3.x branch, based on the pom it has put in a dependency on com.hazelcast:hazelcast-jetty9-sessionmanager:1.0.2. The source has been rewritten as part of Jetty 9.4.x.
As suggested let me try opening the issue within Jetty Repo.
Thank you!
I am also closing this opened issue


test-branch/execute-job/wrong-commit-sha-on-pr/6304ad1a-29fb-41fb-b93e-4a6bee366813

PR for testing 2d5e9e603923b174d68857d4a82ed23635096eec

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


Enable validating tests

https://github.com/Vid201/aa-bundler/issues/66

@Vid201
Currently there are 3 validation tests failing

fail_with_inner_oog_revert
fail_with_unstaked_paymaster_returning_context
fail_with_validation_recursively_calls_handle_ops

I am just curious whether you are working on these cases in case we are working on the dup issues.

@Vid201
Currently there are 3 validation tests failing

fail_with_inner_oog_revert
fail_with_unstaked_paymaster_returning_context
fail_with_validation_recursively_calls_handle_ops

I am just curious whether you are working on these cases in case we are working on the dup issues.

I am not working. But maybe they are the same as in bundler spec tests (I think the 2 should be same). Not sure why it's failing though.


When will the code be made public？

Great job! May I ask when the code will be made public？

I planned to open codes when it is accepted in a conference or a journal. I will ask for approval of open codes earlier with an updated preprint version with one more idea validated.


Comment aggregation

These changes add per-line comment aggregation. Some of the tools can be quite chatty and result in multiple comments on a single line. With these changes only a single comment is made on each line instead of multiple.
This should make lint-review less spammy and more friendly :smile:

Thank you!

:clap:

:100:

neat

:clap:


Search a profile

This epic defines that the application will let a user search a profile.
Associated US :

[ ] As a user, I want to be able to list profiles with criteria : agency, topics, skills, appetites and click on profile to see it
[ ] As a user, I want to be able to search profiles with skill levels, appetites levels and click on profile to see it

resolved #123


Admin: Users, User-Profile

##Title
Develop the Admin Users, User Pages
Summary

This Task contain 2 pages
Develop the 2 pages

Additional information

Send a pull request for each of the pages
Ensure you look through the code base for usable components to avoid duplicates.
Follow the existing file structure

i can work on this.
Do you have a UI design ready for it ? or i should design from my imaginations

@yhoungdev check the ReadMe file you will see the UI design

@Mudi-Igbinoba are you working on this now?

@ingressive4good Yes I am


Initialize the adoption of centralized management of keywords via keywords.py (Phase I: compilation of all keywords)

Checklist
GitHub

[X] I've given this PR a concise, self-descriptive, and meaningful title
[X] I've linked relevant issues in the PR body
[X] I've applied the relevant labels to this PR
[X] I've assigned a reviewer

PR contents

[X] I've consulted ivadomed's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[X] I've added relevant tests for my contribution
[X] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description

Currently, we are using hard coded string to represent numerous settings/configurations and dictionary keys. This is easy to read but hard to maintain, manage and refactor as most IDEs are not smart enough to recognize string in its proper context consistently across the code base. Also, it poses a problem with explainability/readability of the code as the context of this string is usually lost. Here is a trivial example where a simple some_dictionary["balance"] is quite ambiguous in terms of its origin

where as some_dictionary[ContrastKW.BALANCE] vs some_dictionary[SplitDataSetKW.BALANCE] will make it immediately apparent. More importantly, should we decide to be more specific in the keywords or refactoring them  down the road, a search and replacement of "balance" will cause lots of issues while a IDE driven refactoring based on SplitDataSetKW.BALANCE or the underlying string representation at keywords.py will be much less painful and error prone.

Phase 1 of this project is to collect and centralize all the known strings with special purposes, which is now centralized at keywords.py

Phase 2 of this project is to gradually start phasing in the keywords adoption going forward to minimize disruption to existing long standing PRs and ongoing works.

Linked issues

@cakester can you please always add a description to all the PR you open-- this is part of our contributing guidelines-- also tagging @dyt811

@cakester could you reduce the scope of this PR to Phase I only to minimize the conflict and review/revision easier. For now, just introduce the keywords.py file is sufficient and will minimize disruption on other PRs and then once we captured most of the keywords and made others aware of the changes so they won't introduce additional keywords, we can carry out Phase II at either module or file level incrementally to start replacing them. Stach/local branch the changes you made to all other files for now. and gradually introduce them in the upcoming PRs.
Let me know if anything is not clear.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 128 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.5%) to 68.587%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ivadomed/keywords.py
0
128
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.5%

Covered Lines:
4120

Relevant Lines:
6007

💛  - Coveralls


How to calculate IoU?

I run the test.py on validation dataset of MoNuSegData, which generate some prediction images. I used these prediction image and ground truth of validation dataset to calculate IoU, but i achieved the IoU that is not same as yours. I think that i have some misunderstanding about the way of calculating IoU, so i want to ask how to calculate IoU.

You can use the performancemetrics_monuseg.m code provided in the repo !


Add stylesheet variant for Bootstrap

This would be helpful in Django admin which stands on Bootstrap with CSS variables and enable the browser "dark mode".
Currently the stylesheet hardcode its own colors, it is safely usable in dark mode but always with a "light" look.
A proper solution  have to be found to easily use the right stylesheet from widget implementation.

Worth to notice than fileinputbutton CSS is build from a Sass source included in SmartMedia repository, frontend developer that may need to customize it may be able to copy and include it in their Sass sources.


Expose MODSEQ attribute in FETCH responses

If the QRESYNC (RFC 7162) extension is being used, a FETCH response to a
STORE or UID STORE command with the UNCHANGEDSINCE query attribute will
return the mod sequence ID of the performed operation. This information
is crucial for building efficient caching clients.

This change is

This looks good, though I'd like for it to also mention QRESYNC if it only works with servers with that capability. Can we also link to the relevant part of the spec?

I am assuming you mean in the doc-string? Added a reference with link to it.


Register services in bundle extension file

Register services in bundle extension file instead of YAML file to reduce dependencies packages

Done https://github.com/sfmok/request-input-bundle/pull/4


Train Classifiers on Raw Features and on Latent Vectors to Predict Genres

Perhaps can use label to train the CNN encoder as well.
https://www.quora.com/How-do-I-train-an-autoencoder-using-labels/answer/Ramon-Viñas


[v1.14] bpf: lb: un-break terminating backends for service without backend

Manual backport of

[ ] #31840 (adjustments as some recent cleanups were missing. Also drop the BPF test, too much infrastructure is missing)

Once this PR is merged, a GitHub action will update the labels of these PRs:
 31840

@borkmann wdyt, does it make sense to do the backport without the BPF test? This is tricky territory, so I'd rather bring a test. But that means sorting out a bunch of missing PRs which introduced all the needed test helpers ...

/test-backport-1.14

@borkmann wdyt, does it make sense to do the backport without the BPF test? This is tricky territory, so I'd rather bring a test. But that means sorting out a bunch of missing PRs which introduced all the needed test helpers ...

Ended up just open-coding all the missing helpers, so we can also include the BPF test.


Set the DNS operator up for Lighthouse

Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

This should now be transparent on non-OpenShift deployments (I’ll check tomorrow).


Add Redirects for reused Schema Files

We reference a small number of general schemas files through external JSON Schema references, e.g.:
"dspace:agreement": {
	"$ref": "https://w3id.org/dspace/schemas/v0.8/contract-schema.json#/definitions/Agreement"
}

Obviously, the link to the contract-schema.json does not work yet. Therefore the following redirects need to be added:

[x] https://w3id.org/dspace/v0.8/contract-schema.json
[x] https://w3id.org/dspace/v0.8/catalog-schema.json
[x] https://w3id.org/dspace/v0.8/dataset-schema.json
[ ] https://w3id.org/dspace/shapes/v0.8/catalog-shapes.ttl or .../dcat-shapes.ttl?
[ ] https://w3id.org/dspace/shapes/v0.8/contract-shapes.ttl or .../odrl-shapes.ttl?
[ ] more?

Solved by https://github.com/International-Data-Spaces-Association/w3id.org/pull/3

I don't remember why we would need  https://w3id.org/dspace/shapes/v0.8/catalog-shapes.ttl, .../dcat-shapes.ttl,
https://w3id.org/dspace/shapes/v0.8/contract-shapes.ttl, or .../odrl-shapes.ttl. So let's ignore those ones.

Required links work, closing the issue.


Self Hosted Azure Agent with Auto Logon is not starting as Administrator

Describe your question
Hi Team,
We are using below Agent in windows server 2019.
v3.232.1
But we observed that Azure Agent with Auto Logon is not starting as Administrator after the configuration.
We have some VMs with agent 2.x version configured those run as administrator by default.
The process followed to configure the agent was same.
.\config.cmd --unattended --agent '' --pool '' --url '' --auth 'PAT' --token '' --runAsAutoLogon --windowsLogonAccount '<domain\user-name>' --windowsLogonPassword '' is the command we use in Powershell AdminMode
Versions
v3.232.1
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Operation system
Windows server 2019
Version controll system
No response
Azure DevOps Server Version (if applicable)
No response

Hi @bhargavkumar-65, thanks for reporting.
Could you please confirm that the windows user which you pass credentials as parameter, is in administrator group?

@ismayilov-ismayil  Yes, the user is in administrator group, in fact there is only one user in the machine.

@bhargavkumar-65  we are working on more prioritized issues at the moment, but will get back to this one soon.

@bhargavkumar-65  After investigation I found out that the --runAsAutoLogon   argument doesn't mean to run it as Administrator. It requires to set it up by administrator privilege due to create startup script.
If you want to run it with administrator privilege, please, create agent as a service.

Hi @bhargavkumar-65, closing this one - feel free to ask any other questions or let us know if it's still relevant for you.


Instalation ZABAPGIT_FULL

Hi,
I'm getting the error when installing/running ZABAPGIT_FULL:

Direct access to components of the global class ZCL_ABAPGIT_STAGE is
not possible. The statement CLASS ZCL_ABAPGIT_STAGE DEFINITION LOAD is
missing.

Line 11129.
Thanks

thanks
as a temporary workaround, try the build from yesterday, https://github.com/abapGit/build/blob/a0aab39001246301c0207a65a6332b97d39fe9fd/zabapgit.abap

@petrhos thanks for the bug report
should be fixed in latest version, try again

closing


Converted factory.py and parser.py to Cython files and updated setup.py

Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

[y] 🧪 Added tests for changed code.
[n] 🛠 All tests pass when run locally (run tox or make test to find out!).
[n] 📚 Updated documentation for changed code.
[y] ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Cython implementation added to the arrow.get() function. The main change I made was updating some of the variables in the factory.get() function to be defined of type cdef int where it made sense. On top of that I made some changes in parser.py which is now parser.pyx because it seemed like this file had a lot to do with the functions called in the get() function. The changes have been tested using a time function call within the code to see how long it took without the Cython changes and then with the Cython changes. The changes are not perfect and could definitely use some touching up on, but I wasn't entirely sure if I was on the right track in changing the types and data structures in the parser.pyx file. I also added 2 or 3 lines in the setup.py file to add the Cython dependency and added one line at the end of the setup to 'cythonize' the factory and parser files.

Hey, we decided that if we are to go through with Cython support, the entire library should be converted at once. Also, I think there alternatives to simply converting the files to ones with .pyx extensions. If you would like to explore this alternative, we'd be happy to take another look.


Question on "2G+" badges in version 2.16

Your Question
With version 2.16, CWA will start to show badges which rules (3G, 3G+, 2G, 2G+) are fulfilled by the certificates the user has stored on their devices.
Reg. the 2G+ bade, there is one big open question:
How to handel people who received a booster shot?
According to https://www.bundesregierung.de/breg-de/aktuelles/testpflicht-bei-2g-plus-1991544 they do not need to get tested, if their booster vaccination happened more than 14 days ago (and they do not want to visit a medical place).
The 2G+ badge should therefore also be shown if a booster is added to the app and it's older than 14 days.
However, this does not seem to be implemented currently. Why?
Ping
@mlenkeit

Why?

@Ein-Tim the Sprint/iteration where we built that feature closed on Dec 15, the day on which the statement was published 😉
There are discussions going on as to what extend this should be incorporated in CWA, especially considering that boosters cannot reliably be detected by inspecting an individual certificate (e.g. recovery > vaccination > booster, or booster after vaccination with Janssen) but as usual, we cannot make any promises.

@mlenkeit

the Sprint/iteration where we built that feature closed on Dec 15, the day on which the statement was published 😉

Ah, okay 😁
Regarding your other arguments, yes, boosters can't be reliable detected, however, IHMO the badge could still be shown if "3/3" certificate is in the app.
Regarding the different local rules: If this is really the case I have just one word for this: Don't 😅
If local regulations are different, we shouldn't even start to implement anything here, as these regulations might change.
Thanks for the answer Maximilian, hope you had a good start in 2022! Thanks for your work!
Closing.

Is it correct that, for example, a digital vaccination certificate (DCC) with the content "3/3" or "2/1" must always be a booster vaccination?
If yes... I have to express a little disappointment here regarding CWA v2.17.2. Although I had already recognized the difficulties and general conditions regarding programming here, for example.
I think no matter which 'all-encompassing' solutions regarding "2G+" or similar are in the pipeline, the current version of the CWA would have deserved an evaluation and display of "2G+" by now. And if only as a temporary workaround for the particularly simple cases; e.g. with vaccination certificates "3/3" or "2/1".
After determining "2G" in the algorithm, this would only have required an additional check as to whether a "3/3" or "2/1" can be found in the currently used DCC. I'll leave it open in terms of effort, whether a one-liner or three-liner would have been sufficient.
With the help of the new info card "People with booster vaccination" (until February 4th, 2022) 54.2% or 45,062,243 people, it is possible to estimate how many people could have possibly benefited from this workaround.


Prerequisites are not mentioned anywhere that I could find.

Just giving you a heads up that it would be nice to know that you also need to install future, pillow and pyfiglet to get the demonstration working.

Thanks for letting me know.
These are all explicitly listed as dependencies in setup.py (and requirements.txt).  My expectation was that people would install the package from PYPI before trying to run the samples and so pip would automatically resolve the dependencies for you.
Can you tell me what you did instead and so what would have helped you find this out more easily?

Assuming that it was a failed pip install, I've updated the main README to make it clear that the full dependencies are.


SCRCPY very slow on WiFi, fast on USB  Started doing this when new WiFi AP was installed

[X ] I have read the FAQ.
[ X] I have searched in existing issues.

Environment

OS: windows 10
scrcpy version: 1.23 and 1.18
installed from windows zip
device model: NREAL Developers Puck
Android version: [8.1.0]

Describe the bug
I had been using SCRCPY for awhile and it was very fast on USB or WiFi.  Had to replace my wifi gateway with a newer one.  New gateway has all the same settings as the old and all other software works normally on it.
SCRCPY runs same as before when USB connected, but when used over WiFi it is very slow, simple android menu updates taking up to a minute now.  Have checked all the wifi settings and they look normal, no weird routing, no parental controlls, traffic shaping...etc.
USB run looks like this
C:\Users\gcorson\Downloads\scrcpy-win64-v1.23>scrcpy
scrcpy 1.23 https://github.com/Genymobile/scrcpy
C:\Users\gcorson\Downloads\scrcpy-win64-v1.23\scrcpy-serve... file pushed, 0 skipped. 86.1 MB/s (41123 bytes in 0.000s)
[server] INFO: Device: QUALCOMM DevKit (Android 8.1.0)
INFO: Renderer: direct3d
INFO: Initial texture: 1440x2560
Wifi setup
adb tcpip 5555
disconnect device USB cable
adb connect <IP_ADDRESS>:5555
C:\Users\gcorson\Downloads\scrcpy-win64-v1.23>scrcpy
scrcpy 1.23 https://github.com/Genymobile/scrcpy
C:\Users\gcorson\Downloads\scrcpy-win64-v1.23\scrcpy-serve... file pushed, 0 skipped. 88.3 MB/s (41123 bytes in 0.000s)
adb.exe: error: more than one device/emulator
ERROR: "adb reverse" returned with value 1
WARN: 'adb reverse' failed, fallback to 'adb forward'
[server] INFO: Device: QUALCOMM DevKit (Android 8.1.0)
INFO: Renderer: direct3d
INFO: Initial texture: 1440x2560
Note that adb devices shows only one device at this point
I don't see any errors, scrcpy runs normally but is just hugely slow taking a minute to update the screen
This is NOT a problem on the wifi at my office and was not a problem on my wifi at home before the access point was replaced.
The connection to the device is a 5ghz one and the router and device are within a few feet of each other.
Obviously it's something related to the new WiFi, but what???  Any ideas on how to debug it?

One update, I tried the same setup with a Google Pixel 6 and it works fine.

I'm having this same issue,   used scrcpy in the past on wifi and it was very fast, also on usb was fast.
now its lagging extremely slow, even showing the menu is taking up to a minute.
never seen it lag this much, tried various versions.   not sure what else to do next.

If the wifi is too slow (due to device chipset, device ROM, wifi router, etc.), then perfs will be awful, this is "expected" (scrcpy communication is over TCP, it will never drop a packet or reduce bitrate automatically, it is intended to work over USB, and it also happens to work over TCP/IP when the network is good, but is not designed to work on poor networks.
You could reduce the bitrate/definition (scrcpy -m1024 -b2M).

These command solved my problem on Oppo Reno 5
scrcpy --bit-rate 2M  --max-fps 15 --max-size 960


Task: Make changes to the README

Overview

Focuses more on the forking option of contributing to make it stand out to people with no write access.

What was the motivation for this change? Did we have customers reaching out asking for assistance in cloning this repository or how to add sample queries?
I think the steps are already clear in distinguishing how to fork or clone the repository and under what circumstances either should be done.
Perhaps what we need to include in the README is a section on Adding Permissions. Which we can indicate that this is closed to direct contributions but that missing permissions can be raised as issue requests.

What was the motivation for this change? Did we have customers reaching out asking for assistance in cloning this repository or how to add sample queries? I think the steps are already clear in distinguishing how to fork or clone the repository and under what circumstances either should be done. Perhaps what we need to include in the README is a section on Adding Permissions. Which we can indicate that this is closed to direct contributions but that missing permissions can be raised as issue requests.

@irvinesunday I had made changes earlier which @MaggieKimani1 had merged (that is what is currently there) but there was an ongoing discussion on whether to explicitly mention the option on cloning a repo for those with write access or to amplify on the fork option only and lightly mention the cloning option to divert the attention of the contributors to the forking option so that they don't lean into requesting for access immediately.


get request fails for jpeg image when using with IO.stream()

If I try to download the following image using a normal get request, it works fine:
Req.get!("https://s3.amazonaws.com/core-marketplace-appointment-prod/uploads/af34444b-8599-4f58-b306-d75dc7b17250/images/af34444b-8599-4f58-b306-d75dc7b17250_20240507165221504430.jpg")
#Req.Response<
  status: 200,
  headers: %{
    "accept-ranges" => ["bytes"],
    "content-type" => ["image/jpg"],
    "date" => ["Fri, 10 May 2024 15:49:02 GMT"],
    "etag" => ["\"6892a2057a722bda0ac88af805af9fb9\""],
    "last-modified" => ["Tue, 07 May 2024 16:52:22 GMT"],
    "server" => ["AmazonS3"],
    "x-amz-id-2" => ["zaHxiP4aAhMN+dRM5Er2f+Hv7l7wpD7UvjXTee5PBspRw4I1sqPJLTZd8lEvk70ZrJ3hCX3ggQw="],
    "x-amz-request-id" => ["3PHKJVHS8J0316HC"],
    "x-amz-server-side-encryption" => ["AES256"]
  },
  body: <<255, 216, 255, 224, 0, 16, 74, 70, 73, 70, 0, 1, 1, 0, 0, 72, 0, 72,
    0, 0, 255, 225, 0, 140, 69, 120, 105, 102, 0, 0, 77, 77, 0, 42, 0, 0, 0, 8,
    0, 5, 1, 18, 0, 3, 0, 0, 0, ...>>,
  trailers: %{},
  private: %{},
  ...
>

Now, if I try the same request, but I want to get a stream from it, I will get the following error:
iex(7)> Req.get!("https://s3.amazonaws.com/core-marketplace-appointment-prod/uploads/af34444b-8599-4f58-b306-d75dc7b17250/images/af34444b-8599-4f58-b306-d75dc7b17250_20240507165221504430.jpg", into: IO.stream())
** (ArgumentError) argument error
    (stdlib 5.2) io.erl:103: :io.put_chars(:standard_io, <<255, 216, 255, 224, 0, 16, 74, 70, 73, 70, 0, 1, 1, 0, 0, 72, 0, 72, 0, 0, 255, 225, 0, 140, 69, 120, 105, 102, 0, 0, 77, 77, 0, 42, 0, 0, 0, 8, 0, 5, 1, 18, 0, 3, 0, 0, 0, 1, 0, 1, ...>>)
    (req 0.4.14) lib/req/steps.ex:898: anonymous fn/3 in Req.Steps.finch_stream_into_collectable/5
    (finch 0.18.0) lib/finch.ex:364: anonymous fn/3 in Finch.stream/5
    (finch 0.18.0) lib/finch/http1/conn.ex:346: Finch.HTTP1.Conn.receive_response/8
    (finch 0.18.0) lib/finch/http1/conn.ex:131: Finch.HTTP1.Conn.request/8
    (finch 0.18.0) lib/finch/http1/pool.ex:60: anonymous fn/10 in Finch.HTTP1.Pool.request/6
    (nimble_pool 1.0.0) lib/nimble_pool.ex:349: NimblePool.checkout!/4
    (finch 0.18.0) lib/finch/http1/pool.ex:52: Finch.HTTP1.Pool.request/6
    (finch 0.18.0) lib/finch.ex:423: anonymous fn/6 in Finch.stream_while/5
    (telemetry 1.2.1) /var/home/sezdocs/projects/rebuilt/platform/core/deps/telemetry/src/telemetry.erl:321: :telemetry.span/3
    (req 0.4.14) lib/req/steps.ex:907: Req.Steps.finch_stream_into_collectable/5
    (req 0.4.14) lib/req/request.ex:993: Req.Request.run_request/1
    (req 0.4.14) lib/req/request.ex:938: Req.Request.run/1
    (req 0.4.14) lib/req.ex:994: Req.request!/2

We can’t write non printable characters to stdout, this is the same outcome if you tried doing something like
File.read!("1.jpg") |> IO.write()

FWIW with Req can stream to file:
into: File.stream!("out.jpg")


Ability to set default initial route in NativeRouter?

Prior to v4 it was possible to <MemoryRouter initialEntries={['/sign-in']}> in order to set initial route to be sign-ip, I attempted to do so with NativeRouter as it is built atop of memory one
<NativeRouter initialEntries={['/sign-in']}>

however app routes to / initially. Is there a way to override this in v4 beta?

Is setting this up inside componentDidMount of App.js (App renders NativeRouter) through AsyncStorage correct?

Ah, this is an excellent point. We should be able to expose <NativeRouter initialEntries> and <NativeRouter initialIndex> as props and just plug them in here: https://github.com/ReactTraining/react-router/blob/e3cc25ad1fef7620d5868054f0d5f9eb858533c9/packages/react-router-native/NativeRouter.js#L56-L57
Would love to see a PR (with some tests, please!) that do this. You up for it, @IljaDaderko?

@mjackson yeh sure thing, might need some help with tests, but will mention it in the pr 👍

Docs state that memory routers initial index is of type array, but implementation shows number, is this an issue? If so could fix this one as well

Ya, initialIndex should be a number. initialEntries is an array. The docs on createMemoryHistory may be useful here.


Updated /games API to match the new IGDB v4 rules

Faunadb will now be used as the main source of games for lookup, while using IGDB to keep it up to date

📝Changed routes:

/games/[id]
/games

(view full size)
(view full size)

And 2 other routes:

/api/games/[[...route]]
/api/users/[[...route]]

Commit ea18da58944f1da12e865c8e08e6aea93763f0c3 (https://bruhnocom-git-develop.bruhno.now.sh).


chore(components): extract out default component options

Overview
For reusing them, especially of selectors, with React, etc. variants.
Resolves #460.
Added

options.js file for each components, working as the bast of static/default component options
index.js file for each components to import component code as well as their options
Code in src/index.js to import options of each components

Testing / Reviewing

Should CSS-related options have its own place, separate from other options?
Testing should make sure no component is broken.

Love this PR! How would you imagine frameworks/libraries importing this stuff to use?

Thanks @joshblack! The goal here is something like (though we need more work separate from this PR):
import { accorionOptions } from 'carbon-components';

const Accordion = ({ children, className, ...other }) => {
  const classNames = classnames(accorionOptions.classAccordion, className);
  ...
};

What is the scope of options you think it'd hold? Now and potentially in the future 😄

Feel free to merge this @asudoh if you want to continue the discussion somewhere else!

Only thing thinking through this is import ergonomics. Sucks that if we put it in the default export than we have to prefix all the options like accordionOptions versus just doing a direct import to the get the options.
Also makes it hard to use the import path in scss as well, which I would imagine add-on teams would want to use in order to verify their selectors get updated.
In other words, would be nice to be able to do something like:
import { selectors } from 'carbon-components/lib/accordion';
import selectors from 'carbon-components/lib/accordion/selectors';

selectors.container; // string

@import 'carbon-components/lib/accordion/selectors'

$accordion__container // string

@asudoh what are your thoughts on this?

My apologies @marijohannessen after some inputs from @joshblack wrt relevant area I began to think this area need to be put more thoughts before we go forward with this - At least making the options module pure JSON so that several tools can consume them directly. Let me withdraw this PR for now.


Configure online editor

This issue is part of the migration to v3. You can read full details about the various changes here.
In Exercism v3, students can now choose to work on exercises directly from their browser, instead of having to download exercises to their local machine. The track-specific settings for the in-browser editor are defined in the top-level "online_editor" field in the track's config.json file. This field is defined as an object with two fields:

"indent_style": the indent style, either "space" or "tab".
"indent_size": the indent size, which is an integer (e.g. 4).

You can find a full description of these fields in the spec.
Goal
The "online_editor" field should be updated to correspond to the track's best practices regarding indentation.
Example
"online_editor": {
  "indent_style": "space",
  "indent_size": 4
}

Tracking
https://github.com/exercism/v3-launch/issues/2

This is done already right? https://github.com/exercism/emacs-lisp/blob/main/config.json

🤷 I have no idea. I take it the correct settings are used thus? I'll thus close this issue.

The current config looks close to what I get in lisp files locally in emacs, and there's no much more that can be configurable on the online editor.


how to place destructive button at any index other than 0

how to place destructive button at any index other than 0?

also how to increase the padding to the left of a button text or icon?


[SPARK-31523][SQL] LogicalPlan doCanonicalize should throw exception if not resolved

What changes were proposed in this pull request?

Throw AnalysisException if LogicalPlan not resolved.
Why are the changes needed?

It's no meaning to canonicalize unresolved plan.
For fast fail.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Jenkins test pass.

Test build #121646 has started for PR 28304 at commit 49b27e1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26324/
Test PASSed.

Test build #121646 has finished for PR 28304 at commit 49b27e1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121646/
Test FAILed.

Test build #121653 has started for PR 28304 at commit 9a461f7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26331/
Test PASSed.

Test build #121653 has finished for PR 28304 at commit 9a461f7.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121653/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26347/
Test PASSed.

Test build #121669 has started for PR 28304 at commit 42ebcbe.


Update the heron scheduler document

The doc does not describe the scheduler isolation well. Add more descriptions to the scheduler isolation.

Nice catch. Thanks for the contribution. Could you sign the CLA first?
https://engineering.twitter.com/opensource/cla

Signed.


bulb on/off using button

Issue Type:

[ ] Bug Report
[x] Feature Request
[ ] Documentation

Describe the bug
it is a css effect which turn on light and turn it off using a button and produce a click sound.

A clear and concise description of what the bug is.

Screenshots

If applicable, add screenshots to help explain your problem.

please add gssoc tag to this issue

@Vamp-harshit , Assigned it to you.

I would like to take up the issue

I am a participant under GSSOC 2022. I would like to work on the issue. Please assign it to me

I am a participant under GSSOC 2022. I would like to work on the issue. Please assign it to me

It's already done

@Vamp-harshit is the PR merged for this? If yes then you can close this issue


[Build][Bugfix] Fix build failed when GC_ENABLE_DNNL=ON

Tracking #221

@huanghaixin008 Have you tested that it fixes the issue for you? Because for me building with -DGC_ENABLE_DNNL=ON works with and without your fix

Yes I did. Two other teammates and me cannot build on latest main branch, and with this fix I can build.


Performance issues in /data.py (by P3)

Hello! I've found a performance issue in /data.py: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.
Detailed description is listed below:

dataset.batch(batch_size)(here) should be called before dataset.map(decode_images, num_parallel_calls=8)(here), dataset.map(random_crop, num_parallel_calls=8)(here), dataset.map(set_explicit_size, num_parallel_calls=8)(here) and dataset.map(augment, num_parallel_calls=8)(here).

Besides, you need to check the function called in map()(e.g., augment called in dataset.map(augment, num_parallel_calls=8)) whether to be affected or not to make the changed code work properly. For example, if augment needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).
Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

Hi,
Thanks for comment! Yes, usually we do want to batch as early as possible but in this case we can't since a large number of the augmentations aren't vectorised :(
Mat

OK,
Thank you anyway~ @matpalm


Close Tasks and User Attribute

New Close Tasks function
New User attribute in Task
More robust Datastore filtering
Some minor code clean up
Addresses the following issues:
#102
#113

PTAL @aarontp  :)

Thanks for the PR @beamcodeup !   I'll take a look at this tomorrow (unless @berggren is bored and wants to take a look at some of this javascript, :).

I started looking at the code, one general questions:
With this change we are letting the user set whatever username they want in the request. This makes it possible to impersonate any user. Can't we set the authenticated users username on the server side instead? Can we get this from the call to cloud pubsub? @aarontp any thoughts on this?

I think allowing the user to specify the username is actually the right thing to do here.   It doesn't give us access to anything we couldn't see already (e.g. if we specify the number of days instead of the user we'll see requests for all of the users), and as a user I might be interested to see what jobs/output other people are using.

Ok, makes sense. Happy to chat about this going forward as I have some ideas, but let's do that outside of this PR :)

As a note - in this PR, though TurbiniaTask's init has an 'user' argument in the parameter, which is to specify the username, we do not have a built-in mechanism to allows users to do that unless they log in as something else.
Sounds good; let's talk about this outside of this PR.

PTAL @aarontp

@aarontp For real, this is the real PTAL. :)

Ok, FYI, all of the other big PRs have been submitted, so if you have some time, now would be a good time to get merged, :).  There are a few other changes coming too, so it would be great if we could get it in soon.  Thanks!

Aaron, merge is complete.
PTAL!!

Thanks!  This will make it much easier for us to clean things up!


Issue #14 🎫: Game class Unit Tests

🚩I have made the following changes to complete Issue #14
Here is a summary of what has been done
Type of files changed/added

In this new Branch, I have ➕ADDED➕ the succeeding *📂 folders and/or **📄 files to complete this ticket's requirements
*📂 root/

*📂 spec/lib_spec/

**📄 game_spec.rb ➕

I have tested all the implemented (public) methods.

I have ✏MODIFIED✏ the succeeding *📂 folders and/or 📄** files
*📂 root/

*📂 lib/

**📄 game.rb ✏

I have renamed the variable two_years_in_days and its value in days 365 * 2 to archive_years_constraint and 2.
Making it clear that the year constraint for it to be true is > 2 years.

**📄 item.rb ✏

As per the requirements I have made private the can_be_archived? method.
And implemented the same changes I did on game.rb regarding the archive_years_constraint, this one is set to 10.

Thank you for taking the time to review this PR ⭐

If you need additional information or have any questions, please don't hesitate to contact me on Slack as Arturo (Arthur) Emanuel Guerra Iturres. I'll be happy to help you out. 🎯

Thank you @demesameneshoa! 👯


sourceMappingURL/sourceURL support?

Here's a minimized JS: http://cdn.theatlantic.com/assets/static/b/theatlantic/js/video_embed.min.4eca65989dc6.js (from http://www.theatlantic.com/video/iframe/417309/)
Its last line is:
//# sourceMappingURL=video_embed.min.js.8dce9ae544de.map

And http://cdn.theatlantic.com/assets/static/b/theatlantic/js/video_embed.min.js.8dce9ae544de.map available. Can I import this map when invoking js-beautify?

What would you expect the beautifier to do with the source map?

Sorry this is not a good example - video_embed.min.4eca65989dc6.js is compressed but variable names are kept. Here another example: variables names in http://code.jquery.com/jquery-2.2.1.min.js are changed. Is it possible that the beautified code has variable names like http://code.jquery.com/jquery-2.2.1.js. For example, in first few tokens of the second line, function (a, b) is restored as function( global, factory).
I was studying JS from TheAtlantic, but seems there's no more information to generate a more readable form. You can consider this feature request as invalid.


some simple error

./scripts/feeds update -a && ./scripts/feeds install -a
WARNING: No feed for package 'kmod-mod-nat-extra' found, maybe it's already part of the standard packages?
WARNING: No feed for package 'kmod-mod-tproxy' found, maybe it's already part of the standard packages?

is that lost some package?

Nope, the warning said it all. 'kmod-mod-nat-extra' and 'kmod-mod-tproxy' already included in the standard packages, and luci-shadowsocks depends on it. You can just ignore this type of warning.


clean up extraneous whitespace in email subjects

otherwise the subjects can be unreadable due to
whitespace introduced in templates

you're right, that seems to work in all cases i tested. pushed revised commit


Uses nugget to download versions

fixes https://github.com/mongodb-js/runner/issues/51

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

That was fast :)

published in<EMAIL_ADDRESS>


Crash when click on physics related, press 'help>copy system info' leads to crash.

Godot version
4.1.1 stable, 4.2.dev6
System information
Godot v4.2.dev6 - Windows 10.0.19044 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (NVIDIA; <IP_ADDRESS>42) - Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 Threads)
Issue description
Crash when touch any physics related things... And copy system info makes crash too.
Steps to reproduce

New project > Add Character3D as root node > Crash.
New project > Project > Project Settings > press on 'Common' in physics > Crash.
New project > Add Node3D as root node > Add CollisionShape3D (or any 3D physics related node, like Character3D)  > Crash.
New project > Help > press on 'Copy system info' > Crash.

Minimal reproduction project
N/A

From my latest problem report when testing 4.2beta1, I found out FPS monitor conflicted with Godot, uninstalling fpsmon fixed the problem.


Android API 31 - 32

Hello,
Any news on JAR for API 31 - 32?
Thanks!

In case anyone is really needing them, there's this repository from another Issue: https://github.com/Reginer/aosp-android-jar. Currently it has from 29 to 32. 30-32 seem to be working normally (didn't try 29, as that one I have from this repo).

In case anyone is really needing them, there's this repository from another Issue: https://github.com/Reginer/aosp-android-jar. Currently it has from 29 to 32, and all seem to be working normally.

33 and 34 has been added for now.


Error in Row-Nornamization

Thank you for sharing your great work!
I was wondering why I get error while running a piece of your code.
In Row-Nornamization:
r_inv = np.power(rowsum, -1).flatten()
This line raise error: ValueError: Integers to negative integer powers are not allowed.
Could you please let me know how you got inverse using power(-1)?
Thank you in advance

Additionally, rowsum is a vector (1-Dimension) so why did you use flatten() here?


Compability issue for .pkl extension

We have a model stored as .pkl file which is trained on NVIDIA's StyleGAN. Since its extension is .pkl, and your structure asks for a .pth file, is there any way to convert our .pkl file to .pth file? Or is there any way to work on your system with a .pkl file?

I have the same problem. I also have NVlab's 'Stylegan2-ADA', 'Stylegan2-ADA-PyTorch' models. (.pkl files)
#9  suggested a method, but I didn't understand it.
I do not know how to load the parameters as NumPy.ndarray.
I apologize for such a beginner's question.

Any model weights (ideally) should be stored like a dictionary or a recursive dictionary. Some key-value pairs should be the parameter name-pre-trained weight pairs, where parameter name should be a string and pre-trained weight should be a tensor (pytorch or tensorflow version, both of which can be easily converted to numpy.ndarray). Please Google how to convert a pytorch (or tensorflow) tensor to a numpy.ndarray if you are really new to these two DL frameworks.
So, I would recommend first load the pkl file with ipython, and then check how the file is organized with print() function.


Accessing the error state in another directive

I have a custom input-container component which implements error class toggling in a similar way that the material form field component does -- by accessing a directive attached to the input inside, which in turn gets the error state from NgControl.
I wanted to do a similar thing for ngrx-forms via the NgrxFormControlDirective but the state and stateSubject properties and the state$ getter are both private, meaning I can't get the state of the input from the container component.
Is there a workaround for this? Or do I have to add an input to my input directive taking the form control state object and use that instead?

@nathanmarks I'll add an item to my TODO list to make the state property public. In the meantime there's two ways you can do this:

simply access the state property by casting the directive to any after injecting it (private doesn't exist at runtime so you can still access the value
add an @Input() ngrxFormControlState binding to your own component (this will always get the same value as the ngrx-forms directive has)

Thanks, I went with the casting for now.

@nathanmarks With a recent bugfix I made the state property public (see https://github.com/MrWolfZ/ngrx-forms/commit/8cc65d78a345b5f3c74296fb69568376fbc21f3e). Once the next version is released (which should happen either this or next weekend) you'll have access to the state without the casting trick.


os sync to retry in cpu

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 6 committers have signed the CLA.:white_check_mark: tmostak:white_check_mark: paul-aiyedun:white_check_mark: mattgara:white_check_mark: yoonminnam:x: guilhermeleobas:x: vastcharadeYou have signed the CLA already but the status is still pending? Let us recheck it.


abc

cde

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   83.44%   83.44%
=======================================
  Files          41       41
  Lines        7030     7030
=======================================
  Hits         5866     5866
  Misses        985      985
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddc7b8...efc980c. Read the comment docs.


Also initialize ValueTypes by default

See this line.
It currently only considers IsPrimitive Parameter-Types. But I could also initialize IsValueType Parameter-Types. I should definitely do that. It's just as easy as just adding IsValueType to the if.

Resolved with above mentioned commit


Add YAML maker: yamllint

yamllint [1] is a linter for YAML files. It does not only check for
syntax validity, but for common cosmetic conventions such as lines
length, trailing spaces, indentation, etc.
1: http://yamllint.readthedocs.org/

Github is telling me there are conflicts to resolve, so I can't merge. I'm happy to merge as soon as that button isn't disabled!

Thanks! Conficts resolved.

It has been 43 days, kind reminder :)

Thanks for the reminder!


Unknown prop index on  tag.

I got this warning whenever the suggestion is triggered, is it a known issue or I'm using it incorrectly? Thanks!
warning.js:44 Warning: Unknown prop index on  tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
in li (created by t)
in t (created by t)
in ul (created by t)
in div (created by t)
in t (created by MentionsInput)
in div (created by MentionsInput)
in MentionsInput (created by t)
in form (created by t)
in t (created by t)
in div (created by t)
in t (created by t)
in ReactCSSTransitionGroupChild (created by ReactTransitionGroup)
in span (created by ReactTransitionGroup)
in ReactTransitionGroup (created by ReactCSSTransitionGroup)
in ReactCSSTransitionGroup (created by t)
in div (created by t)
in t (created by t)
in div (created by t)
in t

Thanks for fixing it!


Suggestion: build/autoBuild and fields modification

Eg. using Context.getBuildFields() and inspecting, modifying, adding fields of a type.

Any suggestions for a real life example?  2 simple ideas I've had:

Something like mcli but easier. So, read the functions in the class, and create a main() that turns the class into a CLI tool.  We started this idea but never finished it.

A class that reads an outside file (HTML, JSON, an Image etc) and creates class fields in response.  For example, read a template file and create a class with properties that render the template.

https://gist.github.com/kevinresol/86e2746ea8701060feb8
I used this macro to read a folder, and turn the file name into static vars.
It generates:
public static var assets__mypic1_png = 'assets/mypic1.png';
public static var assets__mypic2_png = 'assets/mypic2.png';
public static var all = ['assets/mypic1.png', 'assets/mypic2.png'];

Yep good example. I did something recursive which was creating sub-types from a complex Json.


feat: add mechanism for prefixing queries with a comment string

This change proposes a new Comment(string) method and ContextWithComment(context.Context, string) function for prepending a comment to a SQL query.
Here's simple example:
// using the query API
err := db.NewSelect().
    Model(&products).
    Where("description like ?", d).
    Comment("customer:"+customerID).
    Scan(ctx)

// using a context
qctx := bun.ContextWithComment(ctx, "customer:"+customerID)
err := db.NewSelect().
    Model(&products).
    Where("description LIKE ?", d).
    Scan(qctx)

This would produce a query that looks like:
/*customer:01J1P97P3AP7V287B57P7055CZ*/ SELECT * FROM products WHERE description LIKE '%red%'

This may warrant a bit of discussion first, but I wanted to include the code with the proposal. I have had this code running in production since April with no problems. It appears that others may be interested in this as well: https://github.com/uptrace/bun/issues/998
My immediate use case for this is to add a comment to a query with tracing/debug information that will show up in the process list/pg_stat_activity, but there are certainly other uses for this functionality.

@kylemcc This looks useful, but I have a minor refactoring request. Please take a look when you have time.

@kylemcc any chance you can finish this?

@kylemcc any chance you can finish this?

Apologies @vmihailenco, got busy with other things. Let me see if I can get this cleaned up today or tomorrow


Add method to copy drive file

folder cannot be copied directly. user needs to create a new folder and copy files from original folder to the new folder.


Fix height fog (part 2)

There were a few lines that needed to be removed in the last PR (#53795) that cause issues. (Remapping height fog density to 1.0/density does not make sense, even with the original implementation.)
Also made the height fog calculation in the shader to be consistent with distance fog. It is functionally identical; the exact code just matches now.

Thanks!


[Bug]: precision is lost when displaying timestamps

ODC version
4.2.4
OB version
not related
What happened?
precision is lost when displaying timestamps
What did you expect to happen?
precision should not be lost
How can we reproduce it (as minimally and precisely as possible)?

create a table and insert table:

create table ts_tbl(
    col_ts_3 timestamp(3),
    col_ts_6 timestamp(6)
);
insert into ts_tbl values('2022-12-12 12:12:12.0','2022-12-12 12:12:12.0');

query this data:

we will see more precision if we query this data by obclient:

Anything else we need to know?
No response
Cloud
No response

have done

pass


Add a string to float function

This used to be in kartotherian/core, but isn't there anymore.

This comes from https://github.com/kartotherian/core/commit/b79f0da46c7592c0c368042ba97b5c34a41f74bc


Secure Coding Mode: Sandboxing

TODO : Running the user supplied code in a sandbox.

You can implement a codejail which runs the code in sandbox mode
https://github.com/edx/codejail

Look at https://google.github.io/nsjail/ as well.


Show status of filters (enabled / disabled)

Show status of filters for map (enabled / disabled)

done with #45

porting to v3 will be done in #162


[screengrab] Adding Falcon as a ScreenshotStrategy

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
I have been using fastlane+screengrab to take screenshots from my android app. I have been using UiAutomatorScreenshotStrategy and some of my screenshot tests are flaky. Some screenshots are taken before the whole ui is ready even though I am using Espresso onView and checks.
I haven't dig into how UiAutomator takes the screenshot but there is a race condition somewhere. Adding a small delay before taking the screenshots fixes all my issues.
While looking for other libraries to take screenshots I found https://github.com/jraska/Falcon
Falcon is a 400 lines dependency which takes screenshots in the main thread.
I am looking forward to add Falcon as a screengrab dependency and create a ScreenshotStrategy.
Would that be ok?

@fastlane-bot updating doesn't solve the issue.


teuthology-tree: a way to examine a qa suite

The idea behind this is to help see what qa suites are covering by adding short descriptions or other fields to the yaml fragments in a suite.
The first column is similar to the output of the tree command. The other columns are extracted from comments in the yaml fragments based on the specified prefix.
An example annotated suite is here:
https://github.com/ceph/ceph-qa-suite/commit/c3449c06f79c4006f74d55a4252ec577a3d0d5f8
This could be extended (perhaps as part of the ``teuthology-suite``` command) to output the full matrix of combinations rather than just the individual fragments.
Example output:
$ teuthology-tree -p desc ~/ceph-qa-suite/suites/rbd/basic
/home/jdurgin/ceph-qa-suite/suites/rbd/basic
+----------------------------------------------+-------------------------------------------------+
| path                                         | desc                                            |
+----------------------------------------------+-------------------------------------------------+
| ├── %                                        |                                                 |
| ├── base                                     |                                                 |
| │   └── install.yaml                         | install ceph                                    |
| ├── cachepool                                |                                                 |
| │   ├── none.yaml                            | default replicated pool                         |
| │   └── small.yaml                           | writeback replicated cache pool for rbd         |
| ├── clusters                                 |                                                 |
| │   └── fixed-1.yaml                         | single node cluster                             |
| ├── fs                                       |                                                 |
| │   └── btrfs.yaml                           | btrfs under the osds                            |
| ├── msgr-failures                            |                                                 |
| │   ├── few.yaml                             | infrequent network fault injection              |
| │   └── many.yaml                            | frequent network fault injection                |
| └── tasks                                    |                                                 |
|     ├── rbd_api_tests_old_format.yaml        | c/c++ librbd api tests with format 1 images     |
|     ├── rbd_cli_tests.yaml                   | basic rbd cli tool tests                        |
|     ├── rbd_cls_tests.yaml                   | low-level object class tests for cls_rbd.so     |
|     ├── rbd_lock_and_fence.yaml              | test manual locking and blacklisting via librbd |
|                                              | second line                                     |
|                                              | third line                                      |
|     └── rbd_python_api_tests_old_format.yaml | librbd python api tests                         |
+----------------------------------------------+-------------------------------------------------+

I would suggest to use maybe two annotation tags to simplify the process: #desc: and #step:
#desc: - would be used to describe a new feature
#step:  - would be used to describe a step of a test case/job/comment
We can use more annotations, of cause, if we want.  But if we push for a limited amount of descriptions in suites that'd be a good start.
Also we can have wiki pages corresponding to the annotated ceph-qa-suites dirs and have them auto-updated when a new annotation/feature was added, so as results we can have features list and test plans and comments or all together if we wish.
Here is an example http://tracker.ceph.com/projects/ceph-releases/wiki/TEST_TO_BE_DELETED

@yuriw I'm not clear on what you mean by suggesting that #desc would 'describe a new feature' - it seems to me the intent of this is to provide a way to provide multi-purpose annotations to each yaml fragment. Nothing about 'desc' suggests specifically 'new feature' to me.

@joshd I like this idea very much! I wonder about the name, though. I don't have strong opinions about this, but I could see something like teuthology-describe-suite as being a little more indicative of what the new tool does.

@zmc in my opinion, one of the purpose of this tool would be - building annotations for features that are tested by a particular yaml/facet configurations.  So my hope was that # desc:  can be used for this.  However if it's not clear, I'd vote for two annotations:
# feature:
# step:
@zack if agree with the purpose, how would you name them?
@tmuthamizhan may have an oppinion and want to comment as well

@zmc @jdurgin  teuthology-annotations or teuthology-comments?

@jdurgin +1 for adding this,  @zmc I think teutholgoy-describe-test might be better since its describe individual yaml test, If it can be made into high level function call, then pulpito can also benefit and a mouse hover can be used to describe the test.

@vasukulkarni Since this is implemented as yaml comments, none of it will make it into paddles/pulpito. If we want that, it'll have to take a different approach.
@yuriw I guess I don't have an opinion on the purpose of the feature. Perhaps we should get together with @jdurgin at some point to talk about use cases and basic implementation details if you both want?

@zmc @vasukulkarni I agree teuthology-describe-suite or similar is a better name - tree just came from the tree command, but it's not very descriptive.
Let's talk about the purpose of this more at the end of the infra standup tomorrow.

Updates: renamed to teuthology-describe-tests, added json/csv output, changed the input format to be part of the yaml (see the usage info for details), and added options to output the full matrix rather than just one row per path.
Some example output (using the wip-rbd-basic-tree ceph-qa-suite branch):
https://gist.github.com/jdurgin/09711d5923b583f60afc
https://gist.github.com/jdurgin/8380f42d6846ebed7304
@zmc to handle scheduling suites that have these 'meta' yaml elements, paddles needs to change to allow passing a job with a 'meta' attribute. HTTP 500 is given by the jobs controller right now if any unrecognized attribute is found. Could you help with this paddles change?

@zmc @jdurgin here is passed job http://pulpito.ceph.com/teuthology-2015-12-03_08:52:57-upgrade:infernalis:older-infernalis-distro-basic-vps/ on this wip-teuthology-tree branch and results seem reported normally.

I was wrong about a paddles change being needed - I accidentally had two symlinked files that still had a 'description:' element. Changing those to 'meta:' made scheduling a suite work. So this is all ready for review I think.

This how the table may look like on the latest code http://tracker.ceph.com/projects/ceph-releases/wiki/TEST_TO_BE_DELETED

@jdurgin this looks really good. I don't think any significant changes are needed. I'd ask two things though if you don't mind:

Please make the new files pass flake8
In docstrings, please use a newline after the """

I think that's it!

@zmc Thanks for looking, I added newlines to docstrings and made the new files pass flake8

@jdurgin Looks great, thanks!


compile error

Describe your bug here.
i cant compile demolition engine rn
Command Prompt/Terminal logs (if existing)
source/TitleState.hx:391: characters 15-27 : flixel.FlxSprite has no field screencanter (Suggestion: screenCenter)
source/TitleState.hx:615: characters 18-36 : Array<String> should be String
source/TitleState.hx:615: characters 18-36 : ... For function argument 'text'
source/TitleState.hx:616: characters 6-24 : Bool should be flixel.FlxSprite
source/TitleState.hx:621: characters 6-25 : Bool should be flixel.FlxSprite

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
sprites, songs, and data folders

Oh yeah, this is the image that it’s suppose to use, but it’s not in the files yet, just remove it lol

If anything, just go back to the commit before the changes made to TitleState.hx

@DEMOLITIONDON96 it is fixed ?


gendaylit1axis() making less skyfiles

Dear Sir/Madam,
The gendaylit1axis() function is creating less skyfiles than the necessary one (see Figure).
As a result although the metdata has the full year weather data, the gendaylit adds the skyfile till a certain day of the year (typically end of November).
Thanks in advanc for your support,
Erion

when you load the weather data, do you have a start_date or end_date ?
Also, do these entries have valid values for DNI, GHI and DHI? I think it cuts values very close to 0.
S.

Hi Silvana,
Thank you for the very quick reply.
To give some more insights in my example:

The metdata file has 4608 entries ending on the 31st December
the trackerdict after applying the set1axis() has 4382 data points, less cause as you said it cuts values close to zero.

The strange things happens when you apply the gendaylit1axis() function, here the datapoints are cutted further, always from the end.
I did a bit more deep research on this, and in my opinion the problem comes from the indexing of the gendaylit1axis() function.
In the photo is part of the gendaylit1axis() function.
        - At point 1 the for loop iterates over the trackerdict dictionairy whih has 4382 points.
        - However at point 2 the if statement is checking over the metdata dictionairy which continues having 4608 points.
        - As a result the counter is mixed between the metdata and the trackedict.

PS. The above are just suggestions, there is still a chance I am completely wrong :).
Thank you for the support,
Erion

I experience the same issue - that hourly full-year simulations with a single axis tracker stop short of completing the full year. From what I can tell, the problem stems from incorrectly assuming that trackerdict and metdata share a common integer index, as @ebousi points out. This will likely cause mixing of irradiation data and tracker angles that do not correspond.
trackerdict gets created as an empty dict and initialzed in _set1axis (lines 3275-3287 of 'main.py' (see screenshot)), based on timestamps in the epw file. However, since only ghi>0 and valid tracker angles are kept, trackerdict and metdata will not generally be of the same length, and entries indexed with an integer will not correspond between the two.
If trackerdict instead get initialized with trackerdict = dict.fromkeys(times) (that has been commented out in line 3274), the problem goes away - as trackerdict gets to have the same length, keys and order as the metdata.

The approach of indexing these data structures with integer indices that strictly require length and order to correspond seems risky, especially when pruning entries (ghi<0, etc.) various places in the code. Perhaps it would be safer to use the datetime index to look up the corresponding entries between dictionaries?


Style search results

The live search results popup needs some bootstrap 4 love:

 Migrate Laddr to Bootstrap 4

This is what I'm seeing in the features/bootstrap4 branch. Is there any more work to do here?

Handled in https://github.com/CodeForPhilly/laddr/pull/197


Fix hint and explanation flickering on drag and drop exercises

Checklist

[X] I tested all changes and all related features with different users (student, tutor, editor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[X] Client: I followed the coding and design guidelines.
[X] Client: I added multiple screenshots/screencasts of my UI changes

Motivation and Context

fixes #3743
Steps for Testing

Create a drag and drop quiz with a hint and an explanation
preview quiz
verify that you are able to see the hints/explanations on hover.

Test Coverage
unchanged
Screencast

https://user-images.githubusercontent.com/44805696/125445904-1895db4c-23d4-491c-9eb5-7dba184ed123.mp4

https://github.com/ls1intum/Artemis/pull/3746#pullrequestreview-705510883
Thanks! I can't reproduce this with any image. Which browser did you use?


Optimize Not error condition

We use Eval to defer doing any work except allocation on errors since oneOf can recover failures. So we don't actually want to run the error condition until the end.
Not was allocating a copy of a string before the Eval so that allocation had to happen on every failure, which could be a lot for some cases. By moving the allocation inside the Eval we will (almost certainly) save.

Codecov Report

Merging #363 (aa15a7e) into main (828ff4b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   96.63%   96.63%
=======================================
  Files           9        9
  Lines        1128     1130    +2
  Branches       99       99
=======================================
+ Hits         1090     1092    +2
  Misses         38       38

Impacted Files
Coverage Δ

core/shared/src/main/scala/cats/parse/Parser.scala
96.59% <100.00%> (+<0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828ff4b...aa15a7e. Read the comment docs.


Improve abs() function

Why have a separate function (positive) instead of improving abs?
The issue:
you can't return positive vector, without doing either

Vector=positive(vector rv1)
Vector = (abs(vector:x(), abs(vector:y(), abs(vector:z())

I want it to be
Vector = abs(vector)

The absolute value of a vector mathematically is it's length, so I guess they didn't want to trip up people who would expect abs(vec) to return the length.

This would be adding an overload abs(vector v), not improving the existing abs(number n).
Doing this would warrant deprecating positive and the potential name confusion from Sparky's message above. Gates also have "positive" instead of "abs(v)" so I think it's fine keeping it as is.

Also this would be a suggestion, so..


Increase memory limit for deploying large charts

Towards https://github.com/giantswarm/giantswarm/issues/18324
Checklist

[x] Update changelog in CHANGELOG.md.

Tested in ginger. Going with a ping.


chore(release): 1.109.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
Commit ID: 130606734f8d5c19eca3b1ab2e160f67cd8e6960
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
Commit ID: 5dca6df83a5c3abe6dbb114cf0ae206c5739323d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


operators hive-operator (2.4.3180-7299056)

Update Hive community operator to 2.4.3180-7299056
/hold

/merge possible


[Bug]: Warning raising "llama_index.llms.openai_utils:Retrying llama_index.embeddings.openai.get_embeddings"

Bug Description
When I'm trying to generate embedding using VectorStoreIndex.from_documents I'm getting the following error
RateLimitError: Rate limit reached for text-embedding-ada-002 in organization org-********** on requests per min (RPM): Limit 3, Used 3, Requested 1. Please try again in 20s. Visit https://platform.openai.com/account/rate-limits to learn more. You can increase your rate limit by adding a payment method to your account at https://platform.openai.com/account/billing.
I know this is related to the openai limits but the problem with the llama_index is it does have min waiting time for 4 seconds and max for 10. Why this was configured as 4 to 10 seconds? (while the openai limits are per minute which means the minimum could be 60 and maximum can be something like 120 seconds or even a day)
If it does sounds right to update the parameters, I'm happy to open a PR and update these parameters within the library.
Version
0.8.61
Steps to Reproduce

Load some long documents (with long texts maybe)
Using the free openai API tier, call the PGVectorIndex.from_documents passing the documents to the method.

Relevant Logs/Tracbacks
WARNING:llama_index.llms.openai_utils:Retrying llama_index.embeddings.openai.get_embeddings in 0.1008994285848912 seconds as it raised RateLimitError: Rate limit reached for text-embedding-ada-002 in organization org-************ on requests per min (RPM): Limit 3, Used 3, Requested 1. Please try again in 20s. Visit https://platform.openai.com/account/rate-limits to learn more. You can increase your rate limit by adding a payment method to your account at https://platform.openai.com/account/billing..
WARNING:llama_index.llms.openai_utils:Retrying llama_index.embeddings.openai.get_embeddings in 1.190891930285499 seconds as it raised RateLimitError: Rate limit reached for text-embedding-ada-002 in organization org-************ on requests per min (RPM): Limit 3, Used 3, Requested 1. Please try again in 20s. Visit https://platform.openai.com/account/rate-limits to learn more. You can increase your rate limit by adding a payment method to your account at https://platform.openai.com/account/billing..
WARNING:llama_index.llms.openai_utils:Retrying llama_index.embeddings.openai.get_embeddings in 2.7535836731643997 seconds as it raised RateLimitError: Rate limit reached for text-embedding-ada-002 in organization org-************ on requests per min (RPM): Limit 3, Used 3, Requested 1. Please try again in 20s. Visit https://platform.openai.com/account/rate-limits to learn more. You can increase your rate limit by adding a payment method to your account at https://platform.openai.com/account/billing..
WARNING:llama_index.llms.openai_utils:Retrying llama_index.embeddings.openai.get_embeddings in 3.5981531505702584 seconds as it raised RateLimitError: Rate limit reached for text-embedding-ada-002 in organization org-************ on requests per min (RPM): Limit 3, Used 3, Requested 1. Please try again in 20s. Visit https://platform.openai.com/account/rate-limits to learn more. You can increase your rate limit by adding a payment method to your account at https://platform.openai.com/account/billing..

@amindadgar retries can be triggered for many reasons. We do not want to wait 60s if it's a simple network hiccup for example
If you see a better way to handle the retries, I encourage a PR.+
To get around this for now, I would encourage embedding your nodes one at a time manually, since this rate limit is EXTREMELY small
from llama_index.embeddings import OpenAIEmbedding
from llama_index.node_parser import SimpleNodeParser

node_parser = SimpleNodeParser.from_defaults()

embed_model = OpenAIEmbedding()

nodes = node_parser,get_nodes_from_documents(documents)

import time
for node in nodes:
  node.embedding = embed_model.get_text_embedding(node.text)
  time.sleep(21)

index = VectorStoreIndex(nodes, ....)

Thanks for your answer @logan-markewich. So I think this issue can be closed.