SignOutSessionStateManager

Pull request description

Practically resolves #339.
Currently this is only in "draft" state as there are some open discussion points. I will highlight them in the code to open some discussion.
What is implemented?

The (Fake)SignOutSessionStateManager is automatically registered on AddTestAuthorization
SetSignOutState records the call to the LocalStorage
Public property of the FakeSignOutSessionStateManager let's you check whether or not is was invoked

What is missing / could be done better

VerifySignOut does currently not work. I have to check a bit better what is the expectation of a user with that function
Version chumbawamba! See more in details later
Currently I have to create a new BunitJsInterop object in AddTestAuthorization. I'd like to have it from somewhere else

Thanks for this. I have time later this week (Wednesday hopefully) to dig into this.

Hey Egil, hope you are doing good. I will have a look at the weekend as I am a bit busy right now.
Anyway: Thank you very much for your valuable input!

All in all I followed your structure and advise.
Small changes from that:

There is no 3.2.1 dotnet version. Unfortunately Microsoft decided for that important package that they do not follow the version-convention. Anyway I upgraded the minor version to the latest
I had to add <PackageReference Include="System.Text.Json" Version="4.7.2" /> to the web-assets project. Otherwise there would be conflicting dependencies which would lead to build-warnings. If you want to know more: check out this issue on the aspnetcore site.

OK, let me know when you dont consider this draft any more, and Ill take a second look. Thank you!

Hey Egil. Thanks for asking. Yes both PRs can be considered Review ready. Unfortunately I can’t change it on my own.
Have a great start into your weekend.
Cheers

Ok left a few more questions we need to consider.


Tool development - July 2023

Continued development on Archive Oracle tool

https://github.com/SingularityNET-Archive/archive-oracle/issues/3

This issue can be deleted, as the updates for tool development is now living in a quarterly issue.


Missing Colon Whitespace in Fullscreen ObjectHeaders

OpenUI5 version: 1.84.X
Browser/version (+device/version): Windows Desktop Chrome 93.0.4577.82 (64-Bit)
Any other tested browsers/devices(OK/FAIL): Failed on Edge 93.0.961.47 (64-Bit) and IE (Build 19042.1165)
URL (minimal example if possible): https://sapui5.hana.ondemand.com/1.84.18/#/entity/sap.m.ObjectHeader/sample/sap.m.sample.ObjectHeaderResponsiveIII
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

Open the sample page
Check Space between title, colon and text
Open the sample in SAPUI5 version 1.89.0
Compare the results.

What is the expected result?
The space between the colon and the text property should be visible. Like
Category: Laptops
What happens instead?
The whitespace gets ignored by the HTML rendering engine, so it looks like there is no space between the colon and the text. Like:
Category:Laptops
Which looks a little odd. Especially when comparing attributes within other not full-screen optimized ObjectHeaders.
Any other information? (attach screenshot if possible)
I compared the versions, apparently the bug was fixed till 1.89.0. But it is missing in the 1.84 long term version.
It looks like a CSS Style property was changed to fix it.

Hello @FlorianFechterTCon,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Cahit

Hello @FlorianFechterTCon,
Thank you for sharing this finding.
This is a visual issue which doesn't lead to usability issues. According to our downporting guidelines the fix of this issue
doesn't qualify for a transport into UI5 version 1.84. Therefore the fix will be available in the upper version.
Best Regards,
Boyan

Hey @aborjinik and @unazko,
thank you for your reply.
This is a bit unfortunate, as we would like to stay on the/an LTS version, and the headers now look slightly different depending on the view.
But then we'll have to wait for the next LTS version.
Nevertheless, thank you again for looking into this topic.
Best Regards
Florian


Scrollbar Styling Could Use Some Improvement

Describe the bug
The scrollbar appears as a basic style, which doesn't integrate well with the overall design of the page.
To Reproduce

Navigate to the main page of the application.
Scroll down through the content.
Observe the default scrollbar styling.

Expected behavior
I expected the scrollbar to be styled in a way that complements the page’s design, making it more visible and engaging.

Additional context
Customizing the scrollbar to align with the page's aesthetics could greatly enhance the user experience.
Also, the bottom horizontal scrollbar is not needed.

Thank you for assigning me this issue!
Could you please add the 'level' label so that I can get started? I would appreciate it!

Kindly refork and resync

Should I remove the horizontal scroll or not?

you should


RemoveStereochemistry after mol fragmentation

Would it be feasible to force RemoveStereochemistry (maybe re-assign as well?) for mol outputs of all molecule-fragmenting functions? Otherwise, the bonds retain their stereo information vs. the atom indices of the original molecule, which may cause subsequent issues. I got into problems when making fragment with Chem.PathToSubmol and later attempting Chem.MolToInchi for this fragment, which tried to call GetBondBetweenAtoms for non-existing indices.

Does this include simple things like RemoveBond and RemoveAtom? Often times fragmentation/addition is done in batch mode: make a bunch of transformations all at once, then worry about sanitization. Forcing it on each modification can be unnecessarily expensive.

After I posted this, I found #890, and see the point therein. However, SanitizeMol doesn't help here since it doesn't remove the stereo info.

Correct - you need to reassign stereochemistry with forceIt = true

Following the consensus in #890, I agree that this might not need any fix after all, but I would suggest it to be documented in the "list of things to do after modifying molecules". At least for me it was quite difficult (had to use debugger) to figure out the actual reason.


add option for different tmp-dir

eg from renee --tmp-dir /scratch/cluster_scratch/$USER
or on FRCE should it actually be /scratch/local
also see implementation in XAVIER

strategy: just set it in the config file, don't bother with a CLI flag until we refactor the CLI.


How To Identify SSL Handshake errors

Hi ,
I want to log errors which occurs during SSL handshake
One example is :
when I set the min proto version to TLS1_3_VERSION
SSL_CTX_set_min_proto_version(m_sslCtx, TLS1_3_VERSION);
But server only supports TLS1_2_VERSION
So in this case when i do handShakeStatus = SSL_do_handshake(m_ssl);
the error i get using  int err = SSL_get_error(m_ssl, handShakeStatus);
is 5 which is

define SSL_ERROR_SYSCALL    5/* look at error stack/return
                                       * value/errno */

and in case of The failure in finding a matching cipher suite during the TLS handshake  also I am getting same error code
Now I want to log the exact error to error log in my application
So how to get exact error from SSL_ERROR_SYSCALL  error which i get in all cases
How i can identify exact error
and SSL library says /* look at error stack/return
* value/errno */
But there is no clarity how to look and how exactly ?
Need urgent help on this
Thanks
Ratnesh

Please guide me how to log errors and which API to use for below Errors / Issues

mis match in cipher suite during the TLS handshake error
use of  older version than TLS 1.0 or SSL 3.1 error
termination of the session error
termination of a connection due to a missed TLS session renegotiation error
Exceeding the maximum size of a certificate during a TLS handshake error
The connection termination due to the lack of a certificate of either side error
The failure of finding a matching CA certificate during a TLS handshake error

Please help in in getting exact error log / error code for above cases

Please look at the ERR_* function calls in the man pages. For example ERR_print_errors can be used to dump the error stack to a BIO.

@mattcaswell  Do you mean If I use below call then I will get all errors ( from point 1 to point 7) ?
string getOpenSSLError()
{
BIO *bio = BIO_new(BIO_s_mem());
ERR_print_errors(bio);
char *buf;
size_t len = BIO_get_mem_data(bio, &buf);
string ret(buf, len);
BIO_free(bio);
return ret;
}

@mattcaswell
After making this call I got error string as
"16260:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:ssl\record\rec_layer_s3.c:1544:SSL alert number 40\n"
So How I can Interpret this error ?
Exactly How I can categorize what is the issue ?
Where I can see all Alert number definitions ?

@mattcaswell
Suppose from above error I want to classify error type as "mis match in cipher suite during the TLS handshake error"
Then exactly what I should do ?

Do you mean If I use below call then I will get all errors ( from point 1 to point 7) ?

Yes. Well that's one way to do it. There are quite a few different ERR_* functions that enable you to examine each individual error on the error stack, examine its reason code, get a human readable string, etc. Please take a look at the various ERR_* man pages:
https://www.openssl.org/docs/man1.1.1/man3/

"16260:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:ssl\record\rec_layer_s3.c:1544:SSL alert number 40\n"

This means you've received a handshake failure alert from the peer. So the peer is telling you it is unable to proceed with the handshake for some reason. There is no more detailed information from the peer in this case. To find out the reason you'd have to examine the peer's logs.

Where I can see all Alert number definitions ?

All the various SSL/TLS specific error reason codes are listed in openssl/sslerr.h (included automatically from ssl.h). The ones specific to alerts all have _ALERT_ in the name. You can retrieve the earliest error code using ERR_get_error() and you can extract the reason code from an error code using ERR_GET_REASON.
You should check the various RFCs for detailed descriptions of what the alerts actually mean.

Marking as inactive, to be closed at the end of 3.4 dev, barring further input


Issues coming from squash commit

What happened?:
Calling pachctl squash commit on the head of a branch leads to a few issues. list job will start returning errors. I believe this is already addressed by #6627. Jobs can get in a stuck state with the workers crashing due to not finding the job.
What you expected to happen?:
list job should work and workers shouldn't crash.
How to reproduce it (as minimally and precisely as possible)?:
Should work with any pipeline, I was using opencv.
Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version):
Pachyderm CLI and pachd server version (use pachctl version):
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
If you deployed with helm, the values you used (helm get values pachyderm):
OS (e.g. from /etc/os-release):
Others:

Fixed by #6627


[Feature Request]: Expose IQuickOpenService as public api

VSCode Version: 1.10.0
OS Version: win10

Steps to Reproduce:
I'm trying to build an extension that presents a list of npm-packages in the command palette. As the user scrolls down the list, I would like to show a preview-html of the package's README in a virtual document (see screenshot). The existing InputOptions do not help me in accomplishing this. For now, I'm using showQuickPick but I don't think it exposes a callback for the event of user moving down the list.
This experience would be similar to how vscode accomplishes previewing a color theme when the user is browsing through the different available themes from the command palette. This code is what I think I need, but it is not part of the public api.
// Thanks to @hoovercj for helping me navigate through the source.
screenshot:

I would also like to take advantage of this api.
I have an extension for a language called octo and I bundle documentation and sample code with it. As the OP does, I use quick picks to expose those and it would be hugely beneficial if I could simultaneously show the content of docs or sample code in an editor as the user cycles through the options.

closing this as dupe of https://github.com/Microsoft/vscode/issues?q=is%3Aopen+label%3Aapi+label%3Aquick-pick+label%3Afeature-request

@balajikris you and I both missed something obvious. oops!
QuickPickOptions takes an onDidSelectItem callback that does what we both need.
I connected it with a TextDocumentContentProvider in a sample extension here which I'll be folding into my real extensions after this fix comes out with the next release.
I hope that helps!

ah! I see. I noticed that event but got confused as to what selection meant - cycling through with arrow keys or commiting one by hitting Enter. Thanks for looking into this -- your api-playground idea is awesome, I'll take a peek. Thanks much!


Benchmarks

Hey! How long would these benchmarks https://github.com/rv8-io/rv8-bench/tree/master/src take in a cycle-accurate simulation on marrs-riscv? Just curious to know time estimates.

It depends on simulation parameters and delays you specify in the config file. Example config file is here.


[Apple Notes] Not working since Sonoma

Extension
https://www.raycast.com/tumtum/apple-notes
Description
Since updating to Sonoma, the extension hasn't been working. If I try the "Search Notes" command, it comes back with an error of "database disk image is malformed".
Steps To Reproduce

With Mac OS Sonoma 14.0
Run the command "Search Notes"

Current Behaviour
An error is returned with "database disk image is malformed"
Expected Behaviour
A list of notes to search

Same for me.
Searching through the issues it seems to be a common problem:
#8910
#8734
#8004
#8363
#6631
#6916
#5619

I ran into this issue as well, not sure how to help fix it

I have the same issue with some extensions. Likely originating from sqlite.

Has there been any solution to this?

also facing the same issue


Audio not recorded occasionally

Has anyone experienced audio not getting recorded every once in a while? I can't seem to reproduce this error consistently. I am doing a few things with AVAudioSession to enable background audio, but again the inconsistency in which no audio gets recorded is baffling.
I'm using AVAudioSessionCategoryPlayAndRecord with [.mixWithOthers, .defaultToSpeaker] options. Thanks!

try -[SCRecorder unprepare] instead of -[SCRecorder stopRunning] the AVCaptureSession after receiving UIApplicationWillResignActiveNotification ?

It happened to me, some time ago, I did set fastRecordMethodEnabled = true, and while recording, if you get quiet for while at the start, then no sound is recording at all. If you start talking and making sounds at the start of the recording the it worked just fine.
Make sure you are not setting it to true

I had the same issue. I am using swift 3. try to not use this line recorder.keepMirroringOnWrite = true


support for arm linux native BN

We've started to receive some requests for an arm linux native version of BN. Adding a new architecture adds a significant amount of work to the build/update infrastructure as well as requires more work for each stable release so we're holding off for now. In the meantime, vote on this issue to indicate your interest. Also, mentioning arm64 in case GH search doesn't find it without it.

Just posting my use case here.
I like macOS (which has gone all-in on arm64) as my host, but I like doing security research/CTFing on Linux. Thus most of my work is done in Linux virtual machines. It's a PITA to move over executables from the guest over to the host, in order to use Binary Ninja, every time I want to look at something.
I actually love Binja so much I reverted back to an Intel Mac just do I can use it on my guest VMs. :smile:

There are many notebooks with the Snapdragon X Elite will debut in mid-2024, which are by all accounts leaps and bounds above the "toy" arm notebooks we have seen the last couple years.
It might be worth reconsidering the priority of this. If the demand is not here yet, it will be shortly.

This has me so excited.

These builds and updates are now live on the dev branch and installers can be downloaded by using the License/Installer Recovery process on our website. Just make sure to change the "Download type" to dev before you click "Send license" as we do not have any 4.0 stable builds available at this time.
In our limited testing, the arm64 build seems to work very well and we're not currently aware of any limitations or issues. But, we have not gone through a full release test process yet. So, it should be considered a "release candidate" until the 4.1 stable in a few months.
If I'm wrong and anyone encounters a problem, I highly encourage you to file issue to bring the problem to our attention so we can get it fixed.

Tested dev build on Arch GNU/Linux aarch64 and binja works like a charm. Thank you guys


[platform-folders] update version to 4.2.0

Fixes https://github.com/microsoft/vcpkg/issues/29126
No feature needs to test.

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Thanks for the update!


iOS export errors / streamlining export process

Godot version:
3.0.6
OS/device including version:
Mac OS X 10.13.6 / Xcode 9.4.1
Issue description:
First of all, sorry. I am not familiar with ios development and google-fu didn't help.
I tried creating and exporting "hello world" project (1 scene, 1 "press me" button in gdscript) using official tutorial and official export templates.
Got problems on every step:

(minor) Export menu has no sane defaults for bundles, app name, etc.
Linking problem if target is emulator

ld: warning: ignoring file /Users/user/Documents/projects/mobile/project/xcode/project.a, missing required architecture x86_64 in file /Users/user/Documents/projects/mobile/project/xcode/project.a (3 slices)
ld: entry point (_main) undefined. for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

"Fixed" this via targeting real device.
2. https://github.com/godotengine/godot/issues/18359 this
3. now here  dsymutil error
error: cannot parse the debug map for "/Users/user/Library/Developer/Xcode/DerivedData/project-hjgvqxxbzgxuszbkfklkeekwagvq/Build/Products/Debug-iphoneos/project.app/project": Is a directory

I think this is related to step 6 of exporting tutorial (referencing project folder to xcode project).
Questions:
How to deal with problems 1 and 3?
How to export godot native application to ios?

A quick web search shows that you generally get linker errors such as clang: error: linker command failed with exit code 1 (use -v to see invocation) due to missing libraries. For me it was the StoreKit.framework. This is solved by going to Build Phases > Link Binary With Libraries And pressing the plus button to add a library. In my case I just searched for StoreKit and added the library.
For the dsymutil error, the only thing I can suggest is going to Product > Clean Build Folder in the menu bar (⌘ ⇧K)

This is solved by going to Build Phases > Link Binary With Libraries And pressing the plus button to add a library. In my case I just searched for StoreKit and added the library.

Thanks. On the long run it is better to remove storekit from default link in export template .

For the dsymutil error, the only thing I can suggest is going to Product > Clean Build Folder in the menu bar

It didn't help as far I remember. I'll try again.

Having the same issue, adding  StoreKit to Build Phases > Link Binary With Libraries in XCode didn't solve the problem:

Closing due to lack of update. Please comment if you can still reproduce this issue in the latest stable version of Godot.


Expose Sass lang version via node-sass API and CLI

API Usage:
var sass = require('node-sass')
console.log(sass.info)

/*
node-sass       3.7.0   (Wrapper)       [JavaScript]
LibSass         3.3.6   (Sass Compiler) [C/C++]
Sass            3.4     (Sass Language) [Sass]
*/

CLI Usasge:
node-sass -v

node-sass       3.7.0   (Wrapper)       [JavaScript]
LibSass         3.3.6   (Sass Compiler) [C/C++]
Sass            3.4     (Sass Language) [Sass]

Related to sass/libsass#2021.
cc @chriseppstein

This will have to wait until v3.8.0.

Should we get this in for the next release? Think this test needs to be updated https://github.com/sass/node-sass/blob/0c709c1e5fb0a6ef20412f6dc353d0cb59ba1605/test/api.js#L1831

I'm not sure anyone will understand this but I have no objections.

Rebased and update the test file accordingly.
After cherry picking https://github.com/sass/libsass/pull/2077/commits/01f370ae0d65809c40cee0f43d2ac6415716aa4a on top in src/libsass, it passed the version check test on both Mac and Windows.

@am11 I was under the impression sass/libsass@01f370a had been released. We will be shipping 3.3.7 soon.


compton-git: 5.1-rc2 -> 6.2

Motivation for this change
Many new releases:

https://github.com/yshui/compton/releases/tag/v5.1
https://github.com/yshui/compton/releases/tree/v6
https://github.com/yshui/compton/releases/tree/v6.2

Maintainers: @ertes @enzime @twey
Things done
I'm using it with the NixOS module and its default settings. Seems fine so far, running all day today.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

The module is using the old compton and not compton-git by default?
I guess it will be hard to maintain a common module if they start using distinct options...
IMHO we should keep only the maintained fork from yshui repo and call it compton
It's already the source for compton pkg in Arch / Mageia / Void for example.

Yes, that seems reasonable.

Add an alias compton-git = compton to avoid breaking existing users' configs

Ah nice to have a feedback from an actual compton user, thanks @Ma27

On a related note, I'm excited for https://github.com/yshui/compton/issues/32

Effectively breaks some configs since compton doesn't seem to take well of duplicate settings.

Oh you mean if you have wintypes in your extraConfig?
What do you have there?

The idea in NixOS/rfcs#42 would solve this rather well

Yes, for example in compton.sample.conf from the repository. extraWintypesConfig would fix it.
wintypes:
{
  tooltip = { fade = true; shadow = true; opacity = 0.75; focus = true; full-shadow = false; };
  dock = { shadow = false; }
  dnd = { shadow = false; }
  popup_menu = { opacity = 0.8; }
  dropdown_menu = { opacity = 0.8; }
};


[AutoDiff] NFC: gardening.

The following functions only have one user:

AnyFunctionType::getDerivativeOriginalFunctionType
AnyFunctionType::getTransposeOriginalFunctionType

Make them fileprivate static functions in lib/Sema/TypeCheckAttr.cpp.
This is consistent with master.
Downstream some changes from master.

@swift-ci Please test tensorflow


serializers: add created and updated to the search with ui content type

added created and updated to the source of the ES query because they were missing from the literature search with ui content-type
INSPIR-2582

@monaawi AFAIS it's not only for ui content type (for the commit message)

They were missing only for ui content type - for the rest I added the assertions in the tests because they were missing


Using Elegy with Equinox?

I am under the impression that Elegy is not really an NN framework by itself. Instead, it wraps NN frameworks like Treex/Equinox/Flax/Haiku to automate the training loop and provide handy utilities like elegy.Model.summary. If that is the case, could you provide a quick example of using Elegy with Equinox?

Hey @nalzok, this version of Elegy relies heavily on Treex to wrap other frameworksFlaxModule and HaikuModule e.g.
https://github.com/cgarciae/treex/blob/c35d68b261144ed9f04babc4434419ff576d36ad/treex/nn/flax_module.py#L16
Using arbitrary frameworks will be much easier with #236. I expect to roll a dev version of Elegy soon, if you want to try it out I'd be happy to help you get started.


Create required Azure AD resources section has incorrect information

The following text is incorrect:
"First, create an Azure AD service principal by using a specific application ID named Domain Controller Services. In public Azure, the ID value is 2565bd9d-da50-47d4-8b85-4c97f669dc36. In other clouds, the value is 6ba9a5d4-8456-4118-b521-9c5ca10cdf84. Don't change this application ID."
The correct information is:
"Domain Controller Services" AppID == 2565bd9d-da50-47d4-8b85-4c97f669dc36
"Azure AD Domain Services" AppID == 6ba9a5d4-8456-4118-b521-9c5ca10cdf84
I checked in AzureCloud and AzureUSGovernment, and the AppID for both of those are correct as I have listed them here.  The paragraph above is misleading and cost me a lot of time wasted figuring out the truth.  Please fix that.
Robert Smith

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c701f84-d6a8-b5aa-dad7-4c38b7749670
Version Independent ID: 207343c0-a46d-d277-c900-879d1065f25e
Content: Enable Azure DS Domain Services using PowerShell
Content Source: articles/active-directory-domain-services/powershell-create-instance.md
Service: active-directory
Sub-service: domain-services
GitHub Login: @Justinha
Microsoft Alias: justinha

@robsmi-msfte Thank you for sharing this information . We will engage with engineering and the content team to have this reviewed and updated .
Thank you.

@robsmi-msfte sorry for delay and thanks for providing feedback that helps improve our documentation. This issue has been resolved and we are closing the issue. #please-close


[Question] AttributeError: 'NoneType' object has no attribute 'glfwGetCurrentContext'

Question
Hi!
I'm learning how to use gymnasium and encounter the following error:
Exception ignored in: <function WindowViewer.__del__ at 0x7effa4dad560>
Traceback (most recent call last):
  File "/home/rlc/mambaforge/envs/tianshou/lib/python3.7/site-packages/gymnasium/envs/mujoco/mujoco_rendering.py", line 335, in __del__
  File "/home/rlc/mambaforge/envs/tianshou/lib/python3.7/site-packages/gymnasium/envs/mujoco/mujoco_rendering.py", line 328, in free
  File "/home/rlc/mambaforge/envs/tianshou/lib/python3.7/site-packages/glfw/__init__.py", line 2366, in get_current_context
AttributeError: 'NoneType' object has no attribute 'glfwGetCurrentContext'

The Mujoco window flashes and then disappears. Here is the minimum code snippet to reproduce the error
import gymnasium as gym

env=gym.make('Humanoid-v4', render_mode='human')
obs=env.reset()
env.render()

Gymnasium: 0.28.1
glfw: 2.5.9

Thanks!

0)env.render() is not thread locking
try:
import gymnasium as gym

env=gym.make('Humanoid-v4', render_mode='human')
obs=env.reset()
env.render()
breakpoint()

1)That error message will be fixed in the next version


build: Move DynamoDB into the non-core protocols library

Risk Level: Low
Testing: All targets build. All tests pass.

You don't want to use DynamoDB at Google??? Sad.
You need to merge master, otherwise LGTM.

Baby steps, Bob. Baby steps.


ACMG v4 tab in the VCI

New tab in the VCI to support table entry of v4 of ACMG.

Mockup started: https://docs.google.com/document/d/1V78rjzpirf1vzPkbu-8BiDkp4ff38n4ACqJOB0RlOR0/edit


CustomAttribute does't work when used in KeyAttribute

CustomReference does't work when used in KeyAttribute. Same CustomAttribute works fine if you put in Constraint
            <KeyAttribute
                motion:framePosition="50"
                motion:motionTarget="@+id/imageView">
                <CustomAttribute
                    motion:attributeName="imageResource"
                    motion:customReference="@drawable/icon_back"/>
            </KeyAttribute>

or
            <KeyAttribute
                motion:framePosition="50"
                motion:motionTarget="@+id/imageView">
                <CustomAttribute
                    motion:attributeName="colorFilter"
                    motion:customReference="@color/black"/>
            </KeyAttribute>

I'm using constraintLayout 2.1.0-beta02

This is working as intended
KeyAttribute are for continuous variables (floats, integers or colors).
I.e. CustomFloat,CustomColor,CustomDimension etc.
For a custom value to work it must be given the value in the start and end ConstraintSets.
KeyTriggers can be use to implement triggering a call at crossing which can be any type of CustomAttribute


Add soft constraints

We need to port https://github.com/uwdata/draco/blob/master/asp/soft.lp.

Done by @Zehua-Zeng and @JunranY


Execution context - correctly check if gevent has patched threading.local

Typo in call to is_object_patched. Correct module to check is threading, not _threading - https://docs.python.org/3/library/threading.html#threading.local

@ramshaw888 good catch, this looks indeed like a bug
In [1]: from gevent.monkey import is_object_patched

In [2]: is_object_patched("threading", "local")
Out[2]: False

In [3]: is_object_patched("_threading", "local")
Out[3]: False

In [4]: from gevent import monkey
   ...: monkey.patch_all()
Out[4]: True

In [5]: is_object_patched("threading", "local")
Out[5]: True

In [6]: is_object_patched("_threading", "local")
Out[6]: False

Do you remember why we used _threading in the original PR (https://github.com/elastic/apm-agent-python/pull/454)?

jenkins run tests please

@beniwohli It was a typo on my part, looks like I was getting confused the "internal" python _threading_local primitive - _threading and _threading.local do not even exist. https://github.com/python/cpython/blob/master/Lib/threading.py#L1408
We're using the "public api" threading.local in elasticapm.context.threadlocal so is_object_patched("threading", "local") should be the most correct.

Makes sense! Thanks for the update!
(also, jenkins run the tests please)

jenkins run the tests please

Added more robust tests for gevent and eventlet thread monkeypatching. (relies on #581)
Note that these tests should probably only run in isolation (i.e. when specifying the gevent or eventlet framework), as the monkeypatching is not easily reversible, e.g. once monkeypatched, it will be so for the remainder of the process. pytest.mark.gevent and pytest.mark.eventlet applied for that reason.

You're on a roll :D I think requiring the eventlet/gevent tests to run in isolation is fine (and was already the case for the eventlet tests). There's pytest-forked which might help if this limitation becomes a burden, although I suspect it would introduce some overhead, and it doesn't work on Windows...

jenkins run the tests please

jenkins run the tests please

@ramshaw888 looks like the failures are caused by the somewhat ancient Logbook version that we have pinned in requirements-base.txt. Let's remove that pinning for now. I'll see if we can introduce matrix testing for logbook itself later on.

Ahh thanks, beat me to it :)

@ramshaw888 hope that's ok with you! We're planning to ship this in a minor release in a few hours, so I thought I'll fix these two testing issues real quick

No worries @beniwohli, looks like the checks are all passing now as far as I can tell.


Error while installing: "The package was not found with the source(s) listed."

Describe the bug and expected behavior
Occasionally Windows will fail to resolve www.myget.org host immediately after restarting. This will cause a The package was not found with the source(s) listed. error as shown below

This can be fixed by simply restarting the install after the reboot completes:

Open powershell as administrator
navigate to the directory hosting the install script
.\install.ps1 -nochecks 1

I found out what was causing this issue for me. The name of the user that was running the install script was "First Last", while the script was trying to write to "C:\Users\First" (instead of "C:\Users\First Last"). It would fail to install every single package with the error "The package was not found with the source(s) listed.". After a fresh install of Windows 10 (fully updated, username just "First"), the script has been working! I will give credit to whoever opened the issue in regards to Flare-VM, and was able to determine what was happening.


feat(EMI-2098): Add tracking for Tasks

This PR resolves EMI-2098
Description
This PR is a follow up on artsy/cohesion#533
This PR adds tracking for tasks, for both acknowledging or dismissing tasks
Screenshots of tracking payload

Android
iOS

tappedNotification

tappedClearNotification

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Add tracking for tasks in HomeView

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (Add tracking for tasks in HomeView - MrSltun)

  Generated by :no_entry_sign: dangerJS against b6a811b061d7811fe45f26e46614b645478d0b5f


Package view for plugin: fix broken crossdart link

Crossdart links are broken for many Flutter plugins, and doesn't include the android and ios code.
Short term, if something is a plugin just remove the crossdart link, and if the homepage is a github page, show that as the package source link.
Longer term, do https://github.com/dart-lang/pub-dartlang-dart/issues/185.

Closed in
https://github.com/dart-lang/pub-dartlang-dart/commit/7f78d195002a5257b3236fac19b70cc72ba2702a
https://github.com/dart-lang/pub-dartlang-dart/commit/c1180b50007dd9d77030e571b1bfb81d03c7c9fd


Services observe enabled

Services were spinning up regardless of if the config was enabled or not.

+1

+1


May I use the vip_uart_svt_O-2018.09 Verification IP from Synopsys. Inc to verifiy the ip of uart(lowRISC/opentitan)?

https://github.com/lowRISC/opentitan/tree/cce60945e7bd169095a1976d40c489ddfc018c8d/hw/ip/uart
Can you give me some suggestions or  help?

The main goal of OpenTitan is to remain as open source as possible. Hence, we build our own UVM agents (which are also freely available) rather than use something off the shelf.
If you wish to use proprietary VIPs, the testbench can no longer remain in the open source domain - you will have to develop and maintain it privately in your workstation because no one else will have the licenses to compile / run simulations with the VIP. Plus, you will need permission from Synopsys to put pieces of their proprietary code in an open source repo, given that there are multiple competing VIP vendors out there. Just by pasting the image above, you could be violating some terms and conditions with Synopsys! The use of anything proprietary goes against the nature of open source.
It will be good to understand though, what is the need for this. The UART agent used in this testbench already ships with the repo:
https://github.com/lowRISC/opentitan/tree/master/hw/dv/sv/uart_agent
If you feel there are key features lacking in the agent (I am sure we could write more covergroups), I will instead encourage you to contribute to the code and make enhancements as needed.

The main goal of OpenTitan is to remain as open source as possible. Hence, we build our own UVM agents (which are also freely available) rather than use something off the shelf.
If you wish to use proprietary VIPs, the testbench can no longer remain in the open source domain - you will have to develop and maintain it privately in your workstation because no one else will have the licenses to compile / run simulations with the VIP. Plus, you will need permission from Synopsys to put pieces of their proprietary code in an open source repo, given that there are multiple competing VIP vendors out there. Just by pasting the image above, you could be violating some terms and conditions with Synopsys! The use of anything proprietary goes against the nature of open source.
It will be good to understand though, what is the need for this. The UART agent used in this testbench already ships with the repo:
https://github.com/lowRISC/opentitan/tree/master/hw/dv/sv/uart_agent
If you feel there are key features lacking in the agent (I am sure we could write more covergroups), I will instead encourage you to contribute to the code and make enhancements as needed.

Thank you very much for your kindness!

Thank you very much for your kindness!

BTW, UART IP is fully verified with UVM testbench here:
https://github.com/lowRISC/opentitan/blob/cce60945e7bd169095a1976d40c489ddfc018c8d/hw/ip/uart/dv/uart_sim_cfg.hjson
We run nightly regressions on all of our IPs, including the full chip. The results can be found here:
https://reports.opentitan.org/hw/top_earlgrey/dv/summary.html

BTW, UART IP is fully verified with UVM testbench here:
https://github.com/lowRISC/opentitan/blob/cce60945e7bd169095a1976d40c489ddfc018c8d/hw/ip/uart/dv/uart_sim_cfg.hjson
We run nightly regressions on all of our IPs, including the full chip. The results can be found here:
https://reports.opentitan.org/hw/top_earlgrey/dv/summary.html

Thanks a lot !

Thanks a lot !


http://localhost:8000/livereload.js?snipver=1

I execute php artisian server
and found this error in console.
Is project missing this js?

what error?

The url in issue's title is used to reload the page when you make changes.
You have to run gulp watch to dismiss the error but it is not necessary.


Show helpful warning when @types/react isn't found

Since the default error shown when @types/react isn't installed is JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. We show a separate warning when it is missing.
Currently, it just shows a warning instead of automatically installing it since it would be hard to know the correct way to install a dependency for a user considering they could be using yarn, npm, pnpm, etc.

Yup, it's updated to show them together if they both need to be installed now.


heatmap does not show contributions for existing pull requests

Description
when there exist a pull request for a branch all the commits will not be displayed in the heatmap
Gitea Version
1.16.5
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
as described
Database
MSSQL

Can you give more infos? I can't reproduce it with your infos
With my dev-server I created a PR

And pushed a new commit

The heatmap updated correctly from 24 to 25


mediainfo: 23.11 -> 24.01.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/mediainfo/versions.
meta.description for mediainfo is: Supplies technical and tag information about a video or audio file
meta.homepage for mediainfo is: https://mediaarea.net/
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 24.01 in filename of file in /nix/store/cbq6yczx1vhrwpyryvm9m0m364jh76rg-mediainfo-24.01

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
aaxtomp3
deepin.dde-file-manager
deepin.dde-gsettings-schemas
libsForQt5.kdenlive
mediainfo
plasma5Packages.kdenlive

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cbq6yczx1vhrwpyryvm9m0m364jh76rg-mediainfo-24.01 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mediainfo https://github.com/r-ryantm/nixpkgs/archive/4b6c2d8e9046a4ad589d08ddaca7d2022b7fbf28.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/4b6c2d8e9046a4ad589d08ddaca7d2022b7fbf28#mediainfo

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cbq6yczx1vhrwpyryvm9m0m364jh76rg-mediainfo-24.01
ls -la /nix/store/cbq6yczx1vhrwpyryvm9m0m364jh76rg-mediainfo-24.01/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

aaxtomp3
deepin.dde-file-manager
deepin.dde-gsettings-schemas
libsForQt5.kdenlive
mediainfo

Maintainer pings
cc @devhell for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/mediainfo/versions.
meta.description for mediainfo is: Supplies technical and tag information about a video or audio file
meta.homepage for mediainfo is: https://mediaarea.net/
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 24.01.1 in filename of file in /nix/store/2r8ay6lxnd7aajhln70mh64zg5c95g93-mediainfo-24.01.1

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
aaxtomp3
deepin.dde-file-manager
deepin.dde-gsettings-schemas
libsForQt5.kdenlive
mediainfo
plasma5Packages.kdenlive

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2r8ay6lxnd7aajhln70mh64zg5c95g93-mediainfo-24.01.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mediainfo https://github.com/r-ryantm/nixpkgs/archive/b3cf3d89404d86c32318af8c0c159c81b3f50967.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b3cf3d89404d86c32318af8c0c159c81b3f50967#mediainfo

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2r8ay6lxnd7aajhln70mh64zg5c95g93-mediainfo-24.01.1
ls -la /nix/store/2r8ay6lxnd7aajhln70mh64zg5c95g93-mediainfo-24.01.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

aaxtomp3
deepin.dde-file-manager
deepin.dde-gsettings-schemas
libsForQt5.kdenlive
mediainfo

Maintainer pings
cc @devhell for testing.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1498


fix: Dart uuid generation

Now generation a random uuid and storing it instead of grabbing a local identifyer

Thanks for your review @monsieurtanuki, applied your comments

Applied both


with_deleted does not cooperate with scopes

Let's say we have a model
class Article
  acts_as_paranoid
  scope :latest, order('created_at DESC')
end

Then
Article.with_deleted.latest

produces only undeleted articles, and
Article.latest.with_deleted

produces all articles, including deleted ones, but without any ordering.
This is expectable since with_deleted is basically an alias to unscoped, but it's not the right nor the obvious way how this scope should work.

It does now! Please check the "rails3.2" branch.


Alertmanager example

Is there any way you could provide an example configuration for alert manager? The follow is what I'm using without luck:
route:
  receiver: 'notify'
receivers:
  - name: 'notify'
    webhook_configs:
      - url: 'http://notify-bridge:8080/gotify_webhook'

Still having trouble getting this to work. Here are my logs:
gotify_bridge:
notify-bridge    | Starting debug server on http://<IP_ADDRESS>:8080/gotify_webhook translating to http://notify:80/message ...
notify-bridge    | WARNING: /message not at the end of the gotify_endpoint parameter (http://notify:80). Automatically appending it.
notify-bridge    | New gotify_endpoint: http://notify:80/message
notify-bridge    | 2021/02/25 20:47:31 bridge: Recieved request: &{Method:POST URL:/gotify_webhook Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Content-Length:[1267] Content-Type:[application/json] User-Agent:[Alertmanager/0.21.0]] Body:0xc000072500 GetBody:<nil> ContentLength:1267 TransferEncoding:[] Close:false Host:notify-bridge:8080 Form:map[] PostForm:map[] MultipartForm:<nil> Trailer:map[] RemoteAddr:<IP_ADDRESS>:49256 RequestURI:/gotify_webhook TLS:<nil> Cancel:<nil> Response:<nil> ctx:0xc000072540}
notify-bridge    | 2021/02/25 20:47:31 bridge: Headers:
notify-bridge    | 2021/02/25 20:47:31 bridge:  content-length: 1267
notify-bridge    | 2021/02/25 20:47:31 bridge:  content-type: application/json
notify-bridge    | 2021/02/25 20:47:31 bridge:  user-agent: Alertmanager/0.21.0
notify-bridge    | 2021/02/25 20:47:31 bridge: BODY: {"receiver":"notify","status":"firing","alerts":[{"status":"firing","labels":{"alertname":"TEST ALERT FROM PROMETHEUS PLEASE ACKNOWLEDGE","branch":"HEAD","goversion":"go1.15.8","instance":"localhost:9090","job":"prometheus","monitor":"traefik","revision":"a6be548dbc17780d562a39c0e4bd0bd4c00ad6e2","severity":"warning","version":"2.25.0"},"annotations":{"action":"TESTING PLEASE ACKNOWLEDGE, NO FURTHER ACTION REQUIRED ONLY A TEST","description":"TEST ALERT FROM localhost:9090"},"startsAt":"2021-02-25T18:21:16.646300974Z","endsAt":"0001-01-01T00:00:00Z","generatorURL":"http://3da5b2e699c3:9090/graph?g0.expr=prometheus_build_info%7Binstance%3D%22localhost%3A9090%22%7D+%3D%3D+1\u0026g0.tab=1","fingerprint":"e18369a3f432dd69"}],"groupLabels":{},"commonLabels":{"alertname":"TEST ALERT FROM PROMETHEUS PLEASE ACKNOWLEDGE","branch":"HEAD","goversion":"go1.15.8","instance":"localhost:9090","job":"prometheus","monitor":"traefik","revision":"a6be548dbc17780d562a39c0e4bd0bd4c00ad6e2","severity":"warning","version":"2.25.0"},"commonAnnotations":{"action":"TESTING PLEASE ACKNOWLEDGE, NO FURTHER ACTION REQUIRED ONLY A TEST","description":"TEST ALERT FROM localhost:9090"},"externalURL":"http://73374d8cc407:9093","version":"4","groupKey":"{}:{}","truncatedAlerts":0}
notify-bridge    |
notify-bridge    | 2021/02/25 20:47:31 bridge: data sent - unmarshalling from JSON: {"receiver":"notify","status":"firing","alerts":[{"status":"firing","labels":{"alertname":"TEST ALERT FROM PROMETHEUS PLEASE ACKNOWLEDGE","branch":"HEAD","goversion":"go1.15.8","instance":"localhost:9090","job":"prometheus","monitor":"traefik","revision":"a6be548dbc17780d562a39c0e4bd0bd4c00ad6e2","severity":"warning","version":"2.25.0"},"annotations":{"action":"TESTING PLEASE ACKNOWLEDGE, NO FURTHER ACTION REQUIRED ONLY A TEST","description":"TEST ALERT FROM localhost:9090"},"startsAt":"2021-02-25T18:21:16.646300974Z","endsAt":"0001-01-01T00:00:00Z","generatorURL":"http://3da5b2e699c3:9090/graph?g0.expr=prometheus_build_info%7Binstance%3D%22localhost%3A9090%22%7D+%3D%3D+1\u0026g0.tab=1","fingerprint":"e18369a3f432dd69"}],"groupLabels":{},"commonLabels":{"alertname":"TEST ALERT FROM PROMETHEUS PLEASE ACKNOWLEDGE","branch":"HEAD","goversion":"go1.15.8","instance":"localhost:9090","job":"prometheus","monitor":"traefik","revision":"a6be548dbc17780d562a39c0e4bd0bd4c00ad6e2","severity":"warning","version":"2.25.0"},"commonAnnotations":{"action":"TESTING PLEASE ACKNOWLEDGE, NO FURTHER ACTION REQUIRED ONLY A TEST","description":"TEST ALERT FROM localhost:9090"},"externalURL":"http://73374d8cc407:9093","version":"4","groupKey":"{}:{}","truncatedAlerts":0}
notify-bridge    |
notify-bridge    | 2021/02/25 20:47:31 Detected 1 alerts
notify-bridge    | 2021/02/25 20:47:31   title annotation ("Prometheus Alert") missing
notify-bridge    | 2021/02/25 20:47:31   message annotation (summary) missing
notify-bridge    | 2021/02/25 20:47:31   priority annotation (priority) missing - falling back to default (5)

alertmanager:
alertmanager     | level=error ts=2021-02-25T20:47:31.655Z caller=dispatch.go:309 component=dispatcher msg="Notify for alerts failed" num_alerts=1 err="notify/webhook[0]: notify retry canceled due to unrecoverable error after 1 attempts: unexpected status code 400: http://notify-bridge:8080/gotify_webhook"

No message appears in gotify.

Here is my docker-compose:
  notify:
    image: gotify/server:latest
    container_name: notify
    volumes:
      - notify_data:/app/data
    networks:
      - web
    labels:
      - org.label-schema.group=monitoring

  notify-bridge:
    container_name: notify-bridge
    image: nathaneaston/alertmanager_gotify_bridge-docker
    networks:
      - web
    ports:
      - 8080:8080
    environment:
      - GOTIFY_TOKEN=<actual token here>
      - ENDPOINT=http://notify:80
      - TITLE_ANNOTATION="Prometheus Alert"
      - MESSAGE_ANNOTATION="Alert from prometheus incoming"

Hello, @skluthe - sure. Here's the relevant alertmanager config I have set up. It's pretty unremarkable:
    route:
      group_by: ['alertname', 'priority']
      group_wait: 30s
      group_interval: 5m
      repeat_interval: 4h
      receiver: alerter

    receivers:
    - name: alerter
      email_configs:
      - to<EMAIL_ADDRESS>        send_resolved: false
      webhook_configs:
      - url: http://<IP_ADDRESS>:81/gotify_webhook
        send_resolved: false

The only thing of note here is that I'm running the bridge on port 81 because I already have a service on 80.
It looks like the real problem is the 400 reported by alertmanager. There seems to be something about the POST the bridge makes that alertmanager doesn't like. I'm not sure if there's a more robust debug log that can be enabled on the alertmanager side to see if the problem could be more clear? I took a look at the data POSTed from the bridge thanks to the debug log you provided and can confirm that it's at least clean JSON and has the minimum expected parameters.

Actually - on second review... you should be seeing a message Required fields found. Dispatching to gotify..., but that's missing. I think the bridge is not attempting to dispatch because of the missing fields noted. Makes sense - the title and message fields are required. I think you just need to set --title_annotation=action and --message_annotation=description based on the content of the prometheus alert.

That did it. Thanks!


Fix an incorrect axis

The text should either read "axis 0 of the kernel" or "the kernel operates along axis 3 of the input" to be consistent.

@googlebot I signed it!


Revise styling in emails

change primary button colour and border radius to match web design
change main font size to match web design (18px)
other tweaks to alerts list to be more inline with web design

Having looked at them I think they would look better with either the success or the secondary style buttons rather than the dark blue. The teal success buttons are in the new Mailchimp template and are used as call for actions in the design. Could you try that?
The button text also seems too small. The default buttons are 16px font I think?


Disk Drill Pro 5.6.913.0 Crack 2025 𝐅𝐑𝐄𝐄

Current Behavior
Disk Drill Pro Crack is a user-friendly data recovery software designed to recover lost data from a wide range of storage devices, including internal and external hard drives, USB flash drives, memory cards, and more. With its intuitive interface and powerful algorithms, Disk Drill Pro allows users to restore their lost files with ease, even if they are considered permanently deleted.
Disk Drill Pro 5.6.913.0 Download Crack
Expected Behavior
Data loss can be a devastating experience. Whether it’s due to accidental deletion, a system crash, or a virus attack, losing important files and documents can lead to frustration and significant setbacks. Thankfully, there are powerful data recovery tools available to help you retrieve your valuable data. One such tool is Disk Drill Pro, an advanced data recovery software that offers a comprehensive solution for both individuals and businesses. we’ll explore the features, benefits, and effectiveness of Disk Drill Pro, highlighting why it stands out as the go-to choice for data recovery needs.
Context (optional)
Quick Scan: Disk Drill Pro performs a quick scan to retrieve recently deleted files, providing a swift solution for those who need immediate data recovery.
Self-contained Reproducer Project
Deep Scan: This feature allows Disk Drill Pro to dig deeper into your storage device, searching for traces of lost or fragmented files. It employs advanced algorithms to maximize the chances of successful data recovery.
Gradle version
162.6.1
Build scan URL (optional)
No response
Your Environment (optional)
All File Formats: Disk Drill Pro supports a wide range of file formats, including documents, photos, videos, audio files, archives, and more. It ensures that you can recover almost any type of lost data.

Como los puedo descargar me explicarias de favor
Obtener Outlook para iOShttps://aka.ms/o0ukef

De: Florence @.>
Enviado: Sunday, December 15, 2024 4:44:31 AM
Para: gradle/gradle @.>
Cc: Subscribed @.***>
Asunto: [gradle/gradle] Disk Drill Pro 5.6.913.0 Crack 2025 𝐅𝐑𝐄𝐄 (Issue #31748)
Current Behavior
Disk Drill Pro Crack is a user-friendly data recovery software designed to recover lost data from a wide range of storage devices, including internal and external hard drives, USB flash drives, memory cards, and more. With its intuitive interface and powerful algorithms, Disk Drill Pro allows users to restore their lost files with ease, even if they are considered permanently deleted.
Disk Drill Pro 5.6.913.0 Download Crackhttps://win-store.site/?label=d7f93892418e9549d9f3e20e22498dda
Expected Behavior
Data loss can be a devastating experience. Whether it’s due to accidental deletion, a system crash, or a virus attack, losing important files and documents can lead to frustration and significant setbacks. Thankfully, there are powerful data recovery tools available to help you retrieve your valuable data. One such tool is Disk Drill Pro, an advanced data recovery software that offers a comprehensive solution for both individuals and businesses. we’ll explore the features, benefits, and effectiveness of Disk Drill Pro, highlighting why it stands out as the go-to choice for data recovery needs.
Context (optional)
Quick Scan: Disk Drill Pro performs a quick scan to retrieve recently deleted files, providing a swift solution for those who need immediate data recovery.
Self-contained Reproducer Project
Deep Scan: This feature allows Disk Drill Pro to dig deeper into your storage device, searching for traces of lost or fragmented files. It employs advanced algorithms to maximize the chances of successful data recovery.
Gradle version
162.6.1
Build scan URL (optional)
No response
Your Environment (optional)
All File Formats: Disk Drill Pro supports a wide range of file formats, including documents, photos, videos, audio files, archives, and more. It ensures that you can recover almost any type of lost data.
—
Reply to this email directly, view it on GitHubhttps://github.com/gradle/gradle/issues/31748, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKZIYYFQWHA3C7J6CBUT3BL2FVMQ7AVCNFSM6AAAAABTUNSIK6VHI2DSMVQWIX3LMV43ASLTON2WKOZSG42DANJTG42DANA.


Image Rotate in Samsung Devices

Hello Sir,
I am facing same problem for image capture in samsung device and image rotate automatically ,
i have check other device but image is set potrait format , i have use picasso library to resize the
image.
Pleaase provide me any suggestion and help for solve this problem !!!!!!

Are you using the latest version? there was a fix in 2.4.4: #267
Otherwise please provide more details of the issue.
Samsung camera uses exif data to rotate the image, the library should handle it.


Need more info on Subscribe Module for D365 Commerce

The MS Docs page for Subscribe Module in D365 Commerce deals with how to add the module to a specific page on the webstore.
However, it does not address what needs to be done once the module is visible to end users.

If a user enters their email ID and clicks on 'Sign Me Up' button, what is the expected behaviour?
Where can the merchant's team see the list of all users who have shared their email IDs and signed up / subscribed for newsletters?
are there any specific distribution schedules that need to run?
Such details would be helpful in all pages, wherever needed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4eac9bec-1eac-bdaa-20dc-1596983dc958
Version Independent ID: f3362e79-78f6-6bf7-7a22-4f3a92ded94d
Content: Subscribe module - Commerce | Dynamics 365
Content Source: articles/commerce/subscribe-module.md
Service: dynamics-365-commerce
Product: ****
Technology: ****
GitHub Login: @anupamar-ms
Microsoft Alias: anupamar

@AnandDixit2011 Thank you for the feedback.
@anupamar-ms Can you please take a look at the questions and review the topic to see if any changes can be made to assist.

Hi there, as called out in the documentation, you need to extend this module and add the necessary business logic to capture the email and process it. The module itself does not provide any out-of-box integration to capture and process this information.
"The subscribe module requires a data action extension to work with some marketing email providers, so that newsletter or promotional emails can be sent after customer information is captured."

Thanks Anupama.
So there's no default mechanism in D365 Commerce that just captures and
saves the email addresses collected through the subscribe module? If a user
just wishes to view a list of who has subscribed, it is not possible?
Warm regards,
Anand
On Wed, 22 Jun, 2022, 4:42 am Anupama Raju, @.***>
wrote:

Hi there, as called out in the documentation, you need to extend this
module and add the necessary business logic to capture the email and
process it. The module itself does not provide any out-of-box integration
to capture and process this information.
"The subscribe module requires a data action extension to work with some
marketing email providers, so that newsletter or promotional emails can be
sent after customer information is captured."
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/4050#issuecomment-1162450446,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZXS5W6UPEKUXES34UU7MPDVQJD4TANCNFSM5ZNFJUMA
.
You are receiving this because you were mentioned.Message ID:
<MicrosoftDocs/dynamics-365-unified-operations-public/issues/4050/1162450446
@github.com>


Upgrade dependencies

Hey Łukasz!
Using cypress-cucumber-preprocessor for a while now, nice work!
Wanted to play with it bit more, so thought before it's perhaps worth updating things here and there?
Seems to be safe, looking at the changelogs of updated deps. Failed to update just cosmiconfig, where the entire API has changed in v5, so left it for now.

Hello - thanks for the PR.
Btw, I read your medium post about testing - really enjoyed it.


runtime: Go 1.5.4/1.6.1 breaks running on Windows Nano Server

This regression occurred due to change b8af3fd1bd6338f315d92592c28ff26753f2f118 associated with #14959. These changes, which add the LOAD_LIBRARY_SEARCH_SYSTEM32 flag to LoadLibraryEx calls to system DLLs, are incompatible with Windows Nano Server, which is currently in preview release. Go programs fail to load because shell32.dll cannot be found in the course of calling CommandLineToArgvW to parse the command line.
Nano Server does not have shell32.dll or many other DLLs that are part of standard Windows desktop and Windows Server installations. Nano Server is based on OneCore and as such doesn't have shell functionality; the API in question is moved to a different DLL. OneCore replaces explicit references to system DLLs with "API sets", which are DLL-like things that reference logical sets of APIs that may be hosted by different DLLs on different Windows platforms. For example, CommandLineToArgvW is in api-ms-win-shcore-obsolete-l1-1-0. (I don't know why it's in something marked "obsolete", that seems strange to me, too).
Of course, most software out there is not going to start linking to the new API sets any time soon, so Nano Server also has a mechanism to forward from the old DLLs to the new API sets. This mechanism is known internally as "reverse forwarders". These reverse forwarders allow Go software (and a lot of other open source software) to run on Nano Server without changes.
Unfortunately, the loader will not try to load these reverse forwarders if you pass LOAD_LIBRARY_SEARCH_SYSTEM32. This means that while Go 1.5.3 programs worked great on Nano Server, programs built with 1.5.4 will not. This is quite unfortunate for us since we are trying to support Docker on Nano Server, and Docker has just moved to Go 1.5.4 for the security fixes.
We are working internally at Microsoft to see if/how we can support LOAD_LIBRARY_SEARCH_SYSTEM32 with reverse forwarders. I am hopeful that by RTM of Nano Server we will be able to improve this messy situation. But for now, this change has broken us pretty badly.
One proposal for a workaround would be to revert to the old behavior if kernel32.dll cannot be loaded with LOAD_LIBRARY_SEARCH_SYSTEM32. That would be a pretty good indication that you're on a system that doesn't have a standard set of Windows DLLs, and that you shouldn't pass this flag. I can put together a proposed fix today if that's likely to be acceptable.

Sorry, I'd never heard of Nano Server before this. I wrote b8af3fd1bd6338f315d92592c28ff26753f2f118 but I did so blindly using MSDN docs (where I didn't see any reference to Nano Server), and testing on Go's trybot buidlers. Another contributor (@alexbrainman) verified it still passes on Windows XP, since we don't have a Windows XP build machine anymore (I'm working on resurrecting one).
If this Nano Server is something we should support, I suppose we'll need builders for it. I filed #15287 for that.
Our bar for Go point releases is very high. I don't think we would issue a point release for an unreleased in-development operating system, even for our Docker friends. We do, however, have another point release coming for all the other Go 1.6.x non-security bugs (1.6.2: https://github.com/golang/go/issues?utf8=✓&q=milestone%3AGo1.6.2+), so it's possible we could put some minimal change in there for that.
But...

We are working internally at Microsoft to see if/how we can support LOAD_LIBRARY_SEARCH_SYSTEM32 with reverse forwarders.

... it does sound like a Windows problem. We're using a that flag bit to say "use a system DLL, not the malicious DLL in the user's Downloads folder". If you moved Windows system DLLs around and need to remap things, I expect Windows to still map things and yet honor our intention with that flag.

I'm marking this as Unplanned (which we use to just means it's been read, basically), but send a change for review (https://golang.org/doc/contribute.html) and we can consider for 1.6.2 if it arrives soon.

OK, thank you. I understand that this is a difficult request. I agree that this is a Windows problem, and ultimately we need a Windows solution. In the short term, though, we are a bit stuck. I should have an update later today or tomorrow.

@jstarks, I sent you CLA info to your microsoft.com email address I saw from Github. Let me know if you didn't get it.

Note that we're unlikely to issue 1.5.5 for this (Go 1.5 is unsupported except for critical security fixes, and this is a non-security problem in an unreleased piece of software). Even if Docker is using 1.5.4, it seems like it should be possible (trivial even) for the Windows Nano Server build to use 1.5.3. Again, Go 1.5 is not supported (see https://golang.org/doc/devel/release.html#policy).
I'm also somewhat skeptical of including a fix in 1.6.2, since again this is an unreleased piece of software, there is a plausible workaround (use 1.5.3 or 1.6), the functionality works fine on standard Windows, and it sounds like Windows Nano Server might fix the missing functionality before its official release. Especially since we now understand this section to be a security-critical part of the code, letting the fix work through the standard major release process for Go 1.7 seems preferable than rushing in a last-minute change.

@jstarks please try https://go-review.googlesource.com/22054. I just followed your proposed solution description. I don't have Nano Server to test my CL. And it is your fight to get this change (if accepted) into whatever release you want.
Alex

Thanks bradfitz, alexbrainman, and rsc for the quick and helpful response on this. Alex -- I think there is a small problem with my proposal, but see below for an alternative that should be simpler anyway.
Docker is working around this for now by rolling back to Go 1.5.3 when building for Windows. This takes the pressure off getting a fix into Go, but of course is not ideal in the long term. I believe we can move to Golang 1.6.x for Docker when building on Windows -- Docker for Linux is stuck on 1.5.x due to some net/http compatibility issues that do not apply for Windows: https://github.com/docker/docker/issues/20865.
For Nano Server RTM, we may be able to fix this in the OS, but given our release timelines this will add some complexity that the OS team would like to avoid. We'd like you to consider a fix in Go 1.6.2 as an alternative. As a simpler solution to what I proposed before, the loader team suggests passing LOAD_LIBRARY_SEARCH_SYSTEM32 | LOAD_LIBRARY_SEARCH_USER_DIRS to LoadLibraryEx() (instead of just LOAD_LIBRARY_SEARCH_SYSTEM32). This will cause the loader to include the reverse forwarders, but it will still limit the DLL search path in a way that avoids the original security issue. I'm testing this approach now.

@jstarks I will wait for you to decide what you want before doing anything else.
Alex

Sorry for the long delay.   However, we've figured out how to fix this in Windows, so I'm closing this issue. Thanks again for everyone's help.
It did occur to me while looking at this that there is very little reason for Go to load shell32.dll to begin with. With some small changes we can eliminate that and at least one other DLL; this has the advantage of significantly improving the launch performance of Go processes on Windows. I will open a separate issue for that soon and provide some fixes I've prepared.

Thanks for the update!

there is very little reason for Go to load shell32.dll to begin with. With some small changes we can eliminate that and at least one other DLL; this has the advantage of significantly improving the launch performance of Go processes on Windows. I will open a separate issue for that soon and provide some fixes I've prepared.

Please do. Thank you.
(We, obviously, won't be able to change anything until after go1.7 is released).
Alex


Discuss: Allow default text in StylableTextBox

Currently, it's not possible to predefine a text that is not a Hint on the StylableTextBox control.
Since this is kind of a self-made issue (due to the Hint being an extension to the original control) and the original control allows setting a default value, StylableTextBox should imho also allow this.

Good catch, this should definitely be fixed! This would remove the default Text as soon as the user focuses this textbox as the control thinks that this is the hint.


Having difficulties compiling

Was not able to find a better place to put this, so here goes:
I'm not able to build current master, nor Tags 5.0.0 rc5 or 4.3.7. (not tried others)
My IDE's Maven integration (Intellij) claims that Maven can't resolve a dependency in Izpack dist > plugins > org.codehaus.izpack:izpack-maven-plugin:5.0.0-rc5-SNAPSHOT
Is this a known issue, or am I doing something wrong?

Hi, there is no known issue and IzPack is compiling fine for me including the unit tests. Please try to re-clone the repository from here, checkout the master branch an retry.
If you have further trouble please provide some out, logs and the JDK version you are using.

Okay, no joy there.
I'm attaching a link to my command-line outputs, as well as all the surefire tests output, in case they are relevant.
Build basics:
Win 7 Pro 64 bit.
Oracle JDK 1.8.0_45 64 bit
Maven 3.3.3, apache compiled binary
Git 1.9.5.mysysgit.1, official git for windows installer.
Everything in this build, including git clone/checkout was done on the command line. Not a maven expert (Thanks for the impetus to get the thing installed properly!) But I suspect that the first clue is in izpack-buildlog.txt, at about line 56.

I see. Just some explanation at the beginning: We are still compatible to and compile with JDK 1.6. We have CI systems connected compiling additionally on Oracle 1.7 and OpenJDK 7. The Java 8 builds should of course work in future, but didn't receive the appropriate attention.
Just a quick test on Linux (no Windows build environment available at the moment):
Using Maven 3.2.5 (which is the latest version still compiling with JDK 1.6):
export JAVA_HOME=/usr/java/jdk1.6.0_45/
mvn clean
mvn verify
--> OK
export JAVA_HOME=/usr/java/jdk1.7.0_75/
mvn clean
mvn verify
--> OK
export JAVA_HOME=/usr/java/jdk1.8.0_31/
mvn clean
mvn verify
--> TEST FAILURES (although there are concerned different tests than for your case)
Thus more or less the JDK 1.8 builds seem to be still crap.
Leaving this issue open to be done.
You can use JDK 1.7 meanwhile to get it hopefully compiled locally.

Thanks for getting back to me so quickly. I've tried using JDK 1.7.0, and got the same results in my output. Looking at some of the surefire test output, the build system is seeing my 1.7 installation.
I've added a full debug (mvn -X) log to the same location as before, buildlog_extended.txt, just in case there is useful info there.
Question regarding a possible workaround: Is there a new location for a pre-compiled distribution? The old links seem to point to a part of codehaus that has been taken down.

Ah, I think I found it: In method com.izforge.izpack.util.xmlmerge.XmlMergeTest.testMergeFilesWithXPathTagMatcherReplace2Files(), there is a missing null check in the finally branch for the both FileChannel instances:
        FileChannel inputChannel = null;
        FileChannel outputChannel = null;
        try {
            inputChannel = new FileInputStream(new File(patchTargetFileUrl.getFile())).getChannel();
            outputChannel = new FileOutputStream(targetFile).getChannel();
            outputChannel.transferFrom(inputChannel, 0, inputChannel.size());
        } finally {
            inputChannel.close();
            outputChannel.close();
        }

For some reason, on your OS the transferFrom method seems to null them.
I will fix this soon, you can meanwhile skip the unit tests (-DskipTests=true) or skip this dedicated one if you want.

Thanks, I now have a working build... On to fixing the installer definition I was looking at!
I'll look at fixing the bug later, and we'll see how that goes.

This problem should be fixed now, merged pull request #355

Just tried a fresh compile with both JDK 1.7 and 1.8. Now I am getting:
java.io.FileNotFoundException: C:\Users\Admin\Programming%20Stuff\izpack\izpack-util\target\test-classes\com\izforge\izpack\util\xmlmerge\maps_resources_original.xml (The system cannot find the path specified)
In the same test as before.
When I check manually, the path & file definitely exist. Which makes this even weirder.

How did you compile this on the command line?
2015-05-30 6:25 GMT+02:00 Sailsman63<EMAIL_ADDRESS>
Just tried a fresh compile with both JDK 1.7 and 1.8. Now I am getting:
java.io.FileNotFoundException:
C:\Users\Admin\Programming%20Stuff\izpack\izpack-util\target\test-classes\com\izforge\izpack\util\xmlmerge\maps_resources_original.xml
(The system cannot find the path specified)
In the same test as before.
When I check manually, the path & file definitely exist. Which makes this
even weirder.
—
Reply to this email directly or view it on GitHub
https://github.com/izpack/izpack/issues/354#issuecomment-106986554.

git pull to update source.
git rev-parse --short HEAD and double check against latest commit hash here on gitub (I'm newer to git, so some of this is for my own education)
mvn clean
mvn verify
repeat the maven targets after setting JAVA_HOME to my 1.7 JDK directory. Both outputs the same.
Full Trace

Please try this again with the current master HEAD.
It seems like my last fix hasn't been correct. There has been rather bad file handling due to the space in the build directory path.

testMergeFilesWithXPathTagMatcherReplace2Files(com.izforge.izpack.util.xmlmerge.XmlMergeTest)  Time elapsed: 0 sec  <<< ERROR!
com.izforge.izpack.util.xmlmerge.ParseException: java.io.FileNotFoundException: C:\Users\Admin\Programming%20Stuff\izpack\izpack-util\target\test-classes\com\izforge\izpack\util\xmlmerge\maps_resources_patch.xml (The system cannot find the path specified)
at com.izforge.izpack.util.xmlmerge.merge.DefaultXmlMerge.merge(DefaultXmlMerge.java:223)
at com.izforge.izpack.util.xmlmerge.config.ConfigurableXmlMerge.merge(ConfigurableXmlMerge.java:85)
at com.izforge.izpack.util.xmlmerge.XmlMergeTest.testMergeFilesWithXPathTagMatcherReplace2Files(XmlMergeTest.java:137)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
(.... The rest seems to be setting up the test harness ...)
Only JDK 1.8.
Windows does have... unique... directory handling.

OMG, it seems like I have to set up a Windows build environment...
The way of opening a file over an URI is used also in other tests, it can be expected they will also fail.
Nevertheless, no blocker for 5.0 RC5 so far.
Leaving this open so far.

Fair enough. IZPack does work for me, as long as I skip that test. I'm pretty new to maven, so have not tried yet to skip only that test.
I'll have to try installing to a path that includes that directory to see if it's just the tests, or if the build has issues there as well.

Hello René,
The problem is the space in the path. We had the same problem in march and the fix is the same:
In line 139 and 154 the pathSourceFileUrl.getFile() must be replaced with pathSourceFileUrl.toURI().
I'll try to prepare a PR if you're not faster :-)

Hurray and thanks for helping, please send a PR.
I'm currently busy with releasing.
This fix can get into the code after RC5, not so critical.

Andreas was fast like a hurricane.
@Sailsman63: Please check this fix from the latest master, tell us if this works for you or reopen in case of further trouble.
Thanks you all guys.

Well, this issue seems to be resolved! Thanks. I have now moved on to other test failures. Shall I report them here, or open a new issue for each? New failure is in another unit, with errors not related to file io.

Please open a new issue, since 5.0 RC5 is already released and the previous fix got there, while further fixes go to the next snapshot.


Implement 3rd-party (envoy) proto generation mechanism

This PR improves our infrastructure code to support 3rd party proto dependencies, and allow them to generated C++ stubs via protoc compilation. It works for both Bazel and CMake.
The 3rd party proto libraries supported by this PR:

envoyproxy/data-plane-api
googleapis/googleapis
cncf/udpa
envoyproxy/protoc-gen-validate
census-instrumentation/opencensus-proto
ProtoBuf's well known protos (switched them to this path)

Bazel
For Bazel compilation, the general idea is letting Bazel treat envoy-api as a sub-repository. It's done by injecting a WORKSPACE file for it. But to avoid circular dependencies, we need to explicitly depend on transitive libraries. Most of the transitive libraries are already included in gRPC as Git submodules, except opencensus-proto which was needed by Envoy's opencensus.proto. The added grpc_deps are:

googleapis
re2
gazelle
opencensus-proto
protoc-gen-validate
io_bazel_rules_go (update required by protoc-gen-validate)

One extra setup is added for googleapis to WORKSPACE, so it exposes the APIs in a subset of languages instead of all of them.
Current version of re2 failed ASAN (see log). So, this PR disabled ODR check in ASAN (feel free to suggest other ways).
One caveat is the proto generation will fail on Windows RBE, since it doesn't have good Golang support (see log). The Golang tools is required by protoc-gen-validate which is a ProtoBuf plugin wrote by Envoy team, and it needs to be executed for every single Envoy proto files. CC @jtattermusch do you have more context about Golang on Windows RBE?
Overall, Bazel has generally good external library support. Follow the error log and fix the complains one-by-one, and it builds magically in the end.
ProtoBuf Inconsistent Path Problem
Without Bazel, we have to directly interact with protoc, which has some quirks that it is very picky about paths. One needs to find the right combination of working directory (pwd), import directory (-I), and import path (how one proto is meant to be imported). For example, let's say we have 2 proto files each in a different 3rd_party library:
# third_party/lib_a/a.proto
...
message NotImportant {}

# third_party/lib_b/b.proto

import "a.proto";
...

Proto file location
Current working directory
Expected Descriptor Name for "a.proto"
Generated Descriptor Path
How "b.pb.h" Imports "a.pb.h"
Generated "a.pb.h" Header Path

Untouched
.
descriptor_table_a_proto
descriptor_table_third_party_lib_a_a_proto ✗
#include "a.pb.h"
$OUTPUT/third_party/lib_a/a.pb.h ✗

Untouched
third_party
descriptor_table_a_proto
descriptor_table_lib_a_a_proto ✗
#include "a.pb.h"
$OUTPUT/lib_a/a.pb.h ✗

Both copied to project root
.
descriptor_table_a_proto
descriptor_table_a_proto ✓
#include "a.pb.h"
$OUTPUT/a.pb.h  ✓

Only b.proto is copied to project root
.
descriptor_table_a_proto
descriptor_table_third_party_lib_a_proto ✗
#include "a.pb.h"
$OUTPUT/third_party/lib_a/a.pb.h ✗

As above, the ProtoBuf C++ generated code brutal-forcely translate the import line import "third_party/lib_a/a.proto"; to how its dependency headers should be imported, and what its dependency descriptor should be named. But it somehow generated descriptor name based on relative path. The inconsistent header file path is annoying but not blocking the build. However, the difference in descriptor name will cause the build to fail deterministically. This issue troubles many ProtoBuf adopters that it blocks people from using multiple repos to store proto files.
To make protoc work, we can simulate how it is intended to be used in Google, which is gathering the build metadata, find the expected import path, and rebuild the directories, like a monorepo, or like Bazel.
gRPC Buildgen
The core update is done within extract_metadata_from_bazel_xml.py:

Allow external library labels to be count as dependencies;
Treat external libraries as normal libraries, so the script can traverse to find all transitive dependencies;
Map external library Bazel file labels to actual file locations.

(By removing all the intermediate dependencies, we lost the needed information to build those files in order. But the script uses topological sort to create a workable building sequence... What's the rationale behind it?)
The buildgen code is kind of complex, to understand how it work, I polished part of them as I read. It modernized some function calls and added type annotations (not all). There was one logical change, which is move the pre-build logic from mako_renderer.py to generated_projects.py, because the pre-build logic isn't really using "mako" and will only be executed once, there is not much benefit to wrap it in a process pool.
Also, there were 2 tiny fixes: fixed the jobset.py output so it prints str instead of bytes, so when run_tests.py fails the result will be more readable; finally moved the PyYAML installation to sanity Docker container, sorry for delaying for so long.
CMake
The updated ProtoBuf generation logic is:

Create a cmake/build/protos directory (or /protos);
Copy proto files to cmake/build/protos;
Generate C++ files via protoc as needed.

Notably, in step 2, the copy is done by file(COPY instead of add_custom_command, so the proto files will always be copied regardless they were imported or not. This is not as elegant as per-file dependency, because updating the proto files could trigger a large scale rebuild. On the other hand, the per-file dependency is not hard to implemented (as follow). However, since we removed dependency information and I yet to grasp the essence of the build-order sort code, the PR currently uses the brutal-force-copy solution. (@jtattermusch Please help)
    add_custom_command(
        OUTPUT  <%text>${_gRPC_PROTO_SRCS_DIR}/${REL_DIR}</%text>
        COMMAND <%text>${CMAKE_COMMAND}</%text>
        ARGS    -E make_directory
                <%text>${_gRPC_PROTO_SRCS_DIR}/${REL_DIR}</%text>
        WORKING_DIRECTORY <%text>${CMAKE_CURRENT_SOURCE_DIR}</%text>
        VERBATIM)
    add_custom_command(
        OUTPUT  <%text>${_gRPC_PROTO_SRCS_DIR}/${IMPORT_PATH}</%text>
        COMMAND <%text>${CMAKE_COMMAND}</%text>
        ARGS    -E copy
                <%text>${CMAKE_CURRENT_SOURCE_DIR}/${FILE_LOCATION}</%text>
                <%text>${_gRPC_PROTO_SRCS_DIR}/${IMPORT_PATH}</%text>
        DEPENDS <%text>${CMAKE_CURRENT_SOURCE_DIR}/${FILE_LOCATION}</%text>
        WORKING_DIRECTORY <%text>${CMAKE_CURRENT_SOURCE_DIR}</%text>
        VERBATIM)

xDS End2End Test
I make our C++ xDS end2end test the final examination of this PR. I replaced all the xDS proto dependencies from our copied version under src/proto/grpc/testing/xds to their real, complete version. Since the protos were manually moved and trimmed, there were some inaccuracy in message naming.
Old Compilers
Current ProtoBuf library (v3.14.0) has a bug that prevents C++ generated code to build on gcc 4.9, gcc 5.3, clang 3.6, and clang 3.7. I filed an issue to them: https://github.com/protocolbuffers/protobuf/issues/8240, but yet got any response. By upgrading to their head, we regain compatibility with gcc 4.9 and gcc 5.3, but ProtoBuf is still incompatible with clang 3.6 and clang 3.7...

This change is

@gnossen PTAL at the Bazel changes and the Python script updates.
@veblush PTAL at the CMake related changes and if I made some errors in "buildgen" scripts.

Current version of re2 failed ASAN (see log). So, this PR disabled ODR check in ASAN (feel free to suggest other ways).

This isn't a workable solution. This will lead to nondeterminism and segfaults.

@jtattermusch I redid the algorithm of computing the final build-yaml-like metadata, and it compressed 22% of the "build_autogenerated.yaml" size (reduced 1825 from original 8088). I tried to fill-in as much detail as I can in the comment, PTALA.

@jtattermusch Created 3 spin-off PRs #25510 #25511 #25512. After all of them are merged into master, this PR should be fairly clean to review.

@lidizheng  please rebase this as soon as the 3 prerequsite PRs are merged so that this PR gets into a form that can be reviewed without being distracted by unrelated changes (I'm getting a bit lost TBH). I can review as soon as that's done.

@jtattermusch PTALAA. As most changes being moved out of this PR, the actual changes is around 600 LOC in templates/CMakeLists.txt.template and tools/buildgen/extract_metadata_from_bazel_xml.py.

@jtattermusch PTALAA. I awkwardly forget to hit the submit review button. Also, if it is okay for you, can we use Reviewable? GitHub comments are so hard to track.

Ok, sure, I guess I can try using reviewable. But frankly I think the main reason why this PR is hard to review is that it still intermixes 3 different things:

python3 refactoring and introduction of type info
revamping the way extract_metadata_from_bazel_xml.py and changing the way the BUILD file gets processed significantly.
adding new processing of the XDS proto dependencies on top of everything.

I think putting 1 and 2. together is fine (since there's not that many python3 related changes and it's also refactoring), but 2. would be much safer to do and easier to review if it was split apart from 3.
Basically 2. should make the changes so that the changes in the generated files (build_autogenerated.yaml and other build files) are as minimal as possible (e.g. it should not modify ordering of dependencies where not needed because it obscures the real changes that are being made).
After 2. is in place, the XDS changes would really be pretty small and much more focused. Also we wouldn't be talking about 3 different things at a time, because 2.) would already be in place (as a refactor/codegen improvement) and we could focus on the real issues here (e.g. the fact that you're commenting out important lines in the distribtests which is basically making distribtests not check what they are supposed to check and that's not good). This situation would also be better in case we needed to revert 2 or 3, since we wouldn't need to revert everything as a whole in case a revert becomes necessary (and I think the change we're making is definitely tricky enough so that the risk of needing to revert is nontrivial).

Technically, we can split into 2 PR (1, 2) (3). Item 3 works pretty well as the examination for if item 2 is correct or functional. In case we need to revert this PR, I can handle the work. After all, without the new mechanism, the xDS protos won't work for gRPC++; with out the xDS protos, the new mechanism won't have any real usage. So... what do you suggest?

Thanks for the review!
I'm still working on how to automatically download submodules.

ok, but note that that's a crucial part of this PR and without it we don't really know if the whole solution is feasible or not. I want to avoid late surprises.
If successful, we may be able to change upb/xxxhash/etc. back to simple Git submodules.
I'm a bit skeptical and I think if you try that you'll run into problems.  Definitely don't attempt this in this PR and leave experiments with that for later.

@jtattermusch PTAL. The mechanism to pull xds-proto libraries in CMake has passed distribtests.

@jtattermusch PTALA. The changes have been rebased into this PR.

@jtattermusch The test should be green, and it is sync with master again. PTALA.

Still working on the internal parts of this PR, moving xDS protos into Core components.

It's been a year, the internal component change is about to complete.

We still want to remove the copied proto files. I have a rebased, all-in-one version in https://github.com/grpc/grpc/pull/29214. Learning from this PR, I hope this time I can make review less painful, so all code changes is split into:

#29219
#29220
#29221
#29222


Do not engage recovery protocol if resilience mode is off.

Closes #2444

@dipinhora This does not exactly address the concern expressed in #2444.  With this change, we ignore recovery files when not built in resilience mode, which is still transparent to users.  So we won't fail, but we also won't recover.  Basically, with this change, we say "If you haven't built with resilience mode, then you can't recover a failed worker, though you can start again from scratch."  If we want different behavior than that, then we're talking about a more significant change.

@jtfmumm @rachelblasucci has indicated that resolving the concern I expressed in #2444 would be worth doing for a future release.
I'm merging this PR because it solves the immediate crash.


Enums that contain 3rd party types do not get translated and no error/warning is displayed

Describe the bug
I have:
#[derive(Clone, Debug)]
pub enum SpecificMetadata {
    Image {
        width: u32,
        height: u32,
        pixel_aspect: Ratio<u32>,
    },
    Video {
        width: u32,
        height: u32,
        pixel_aspect: Ratio<u32>,
        number_of_frames: usize,
        frames_per_second: BigDecimal,
    },
}

This is not translated (and no error or warning generated) unless I comment out or the 3rd party types used in the enum (num_rational::Ratio & bigdecimal::BigDecimal).
I tried adding these dependencies in flutter_rust_bridge.yaml but this led to #2106.
But at least num-rational wasn't giving me an error.  So following this I added rust/src/third_party/num_rational/mod.rs with this:
#[frb(external)]
impl Ratio {
    #[frb(sync)]
    pub fn new() {}
    #[frb(sync)]
    pub fn numer() {}
    #[frb(sync)]
    pub fn denom() {}
}

Still no luck.
I see this in my lib/src/rust/third_party/num_rational.dart
// These types are ignored because they are not used by any `pub` functions: `ParseRatioError`, `RatioErrorKind`, `Ratio`

But Ratio is used in a public enum!
So here I gave up.

Looks like a bug, and I will have a look at this!

Hi, I cannot reproduce it:
Try 1:

use bigdecimal::BigDecimal;
use num_rational::Ratio;

#[derive(Clone, Debug)]
pub enum SpecificMetadata {
    Image {
        width: u32,
        height: u32,
        pixel_aspect: Ratio<u32>,
    },
    Video {
        width: u32,
        height: u32,
        pixel_aspect: Ratio<u32>,
        number_of_frames: usize,
        frames_per_second: BigDecimal,
    },
}

pub fn my_func(a: SpecificMetadata) -> SpecificMetadata {
    a
}

Output
Future<SpecificMetadata> myFunc({required SpecificMetadata a}) =>
    RustLib.instance.api.crateApiMinimalMyFunc(a: a);

// Rust type: RustOpaqueMoi<flutter_rust_bridge::for_generated::RustAutoOpaqueInner<SpecificMetadata>>
abstract class SpecificMetadata implements RustOpaqueInterface {}

That is an opaque type (if want non-opaque see below)

Try 2:

#[frb(non_opaque)]
pub enum SpecificMetadata { ..

// others unchanged

output
Future<SpecificMetadata> myFunc({required SpecificMetadata a}) =>
    RustLib.instance.api.crateApiMinimalMyFunc(a: a);

@freezed
sealed class SpecificMetadata with _$SpecificMetadata {
  const SpecificMetadata._();

  const factory SpecificMetadata.image({
    required int width,
    required int height,
    required RatioU32 pixelAspect,
  }) = SpecificMetadata_Image;
  const factory SpecificMetadata.video({
    required int width,
    required int height,
    required RatioU32 pixelAspect,
    required BigInt numberOfFrames,
    required BigDecimal framesPerSecond,
  }) = SpecificMetadata_Video;
}

// Rust type: RustOpaqueMoi<flutter_rust_bridge::for_generated::RustAutoOpaqueInner<BigDecimal>>
abstract class BigDecimal implements RustOpaqueInterface {}

// Rust type: RustOpaqueMoi<flutter_rust_bridge::for_generated::RustAutoOpaqueInner<Ratio < u32 >>>
abstract class RatioU32 implements RustOpaqueInterface {}

Close since fail to reproduce, but feel free to reopen if there is a reproduction or there are any other questions!


docker executor uses <IP_ADDRESS> and PORT = 8080

In some cases, 8080 is not available when docker executor deployed inside VM. Is this configurable? I didn't noticed relevant configuration where we can choose another port.
I think we need to provide couple of ports and then the entry point will bind them in a loop, until find available one.
@JosepSampe what do you think?

@gilv Now port 8080 is hardcoded in the docker backend. I put this port since it is one of the most common http ports. In any case, we can put it as a configuration variable in the config file.


Request: Summary for Spawn chances in editor, allowing for editing of existing weights

It would be useful to include a summary of sorts or an option to see a summary of category spawn chances as well as overall individual item spawn chances
I would also like to add that some steps, such as defining item grouping weights and the floors they apply to can't be edited, and need to be deleted and added back again to bring up the menu to adjust starts and ends. Please allow it so they can be modified without having to be deleted and recreated.

Added in https://github.com/RogueCollab/RogueEssence/commit/17b0cbe339ef1a0d038d6163b00af596603e1bd6 and https://github.com/RogueCollab/RogueEssence/commit/cca6deb93a5f8245ad086c21bb3bfa569974d5bb


Fix body scroll issue with micro cart, took reference from https://gi…

Fix body scroll issue with micro cart,took reference from
https://github.com/DivanteLtd/vue-storefront/pull/3411/files
Related Issues

Closes #480
Short Description and Why It's Useful

When open micro cart, body scroll stop working. Page got stuck
Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

Thanks @mohammad-k8 for the reference

Found one console warning related to
disableBodyScroll unsuccessful - targetElement must be provided when calling disableBodyScroll on IOS devices.

Hey @Fifciu, we can merge this PR for our new release, I have updated the change log for this PR.


Merge release/v2.33.1 release notes into master

Submisison Checklist

[ ] Run tests: ./runCmdStanTests.py src/test
[ ] Declare copyright holder and open-source license: see below

Summary:
Merge release/v2.33.1 release notes into master
Intended Effect:
How to Verify:
Side Effects:
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

@serban-nicusor-toptal this now looks like it is trying to merge unreleased changes into master (there were not 93 files changed between 2.33 and 2.33.1)

The only additional PR I merged was: https://github.com/stan-dev/cmdstan/pull/1197
As that was a fix for a failing test, should I try to revert this branch to this commit https://github.com/stan-dev/cmdstan/commit/b3778f6535b8beccb366fd8ae607f12e19dabba8 ? It will override develop merge conflict fixes but that should be fine for master branch, wdyt ?

Based on the commit log above, this also includes #1193, #1198, #1199, #1200 now.
Yes, I think you should make this PR so it only updates the change notes and version number and then merge it (ignoring CI)

Hey @WardBrian I've reverted the commits but now I think the Jenkins pipeline will fail because of #1197
Should we proceed with the merge anyway ?

Why is it checking out the develop branches or the dependencies on merges to master? I thought we had something to avoid this

Hey @WardBrian the Jenkins part seems to be working fine, I think what's causing that git checkout develop is actually the make stan-revert.

This looks good now, except the 1 warning which makes it UNSTABLE :( Maybe it's best to fix the warning and then merge so master will be green

Resolving those deprecation warnings is an open issue #1170

Uh, that's nice! We'll fix the warning itself rather than just ignore it in Jenkins.
Then we can merge, the only problem is that master will show up as red (pipeline status) after the merge I think.

The fix would be in the next version, not this one


Service name is updated for all muxes

I have a test signal by public broadcaster in Slovenia, who are testing an new mux, called R4. The interesting thing is, that the same service (even same bitrate and service ID) is used in both muxes (the first) R1 and R4, but different service label.
But after a scan of new mux R4, AbracaDABra has updated R1 as well, although I have not tuned to that mux.
[...]
17:33:53.398 [I] ServiceList:           [E49200 @ 215072 kHz | 10D] PRVI               E49201 : 0
17:33:53.398 [I] ServiceList:           [E49200 @ 215072 kHz | 10D] VAL 202            E49202 : 0
[...]
17:33:53.501 [I] RtlSdrInput: Setting bandwidth 1530 kHz
17:33:53.543 [I] RtlSdrInput: Frequency correction PPM: 2
17:33:58.788 [I] RadioControl: Tuning 0.000 -> 174.928 MHz ...
17:33:59.049 [I] RadioControl: Current frequency 174.928 MHz
17:34:02.266 [I] ServiceList:           [E49600 @ 174928 kHz |  5A] MuxR4 PRVI         E49201 : 0
17:34:02.273 [I] ServiceList:           [E49600 @ 174928 kHz |  5A] MuxR4 VAL202       E49202 : 0
^C
andreas@E535:~$

before

after scan of R4

When I switch to R1, then the ID is updated for the other R4, too.

Using a464828 , build from sources. Don't think you have changed it in later version.

Oh, interesting, I was not expecting that.