fix: remove abortable iterator

AbortableSource is slow because it races promises against every chunk causing extra async work.
It's only really necessary if we're going to pass the source off to another component.
Here we don't do that so it's simpler to just add a listener for the abort event and close the stream.

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b4e6a8d) 81.40% compared to head (353fbcf) 81.39%.

Files
Patch %
Lines

src/stream.ts
88.88%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   81.40%   81.39%   -0.02%
==========================================
  Files          48       48
  Lines       12325    12333       +8
  Branches     1301     1302       +1
==========================================
+ Hits        10033    10038       +5
- Misses       2292     2295       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

#434 can probably be closed if this is merged.


s3select -limit operator implementation

The LIMIT SQL command enables to limit the amount of scanned data
Signed-off-by: Girjesh Rajoria<EMAIL_ADDRESS>

please explore the getMatchRow, all data sources use this method.
eventually select count(0) from s3object limit {some-number};
should return result less-equal to {some-number}

#117 is merged
it is relevant to limit-syntax-rule issue.

the following
seq 1 1000000 | ./example/s3select_example -q 'select count() from stdin limit 1000000;'
does not return the correct result.

the review is for 2 issues.
as mentioned previously, should use enum class for different states of status returned by the execution flow.
the JSON flow is not working correctly (it continues to read the object), it's probably because of the status returned by the execution flow is not handled correctly.
upon JSON flow the reader is calling the SQL-processing, thus the reader should "know" how to handle limit operation.


[Feature]: Update gameService.dealCards() to use new GameState model

Feature Summary
We should update the function that deals the cards/initializes the game state so that it utilizes the new GameState model.
Detailed Description
gameService.dealCards() is the utility that initializes the game by creating and placing all the cards. We should update it to read from the process.env.SAILS_USE_GAME_STATE_API env var and if that is set to “true”, use a new sails helper to instantiate and save a new GameState associated with the specified game. This should make it so that we can start a game via ready and rematch.

Hey I am trying to work on this one.
Do you mean, we are not meant to change the actual code, just had the possibility to instantiate a gamestate if VITE_USE_GAMESTATE_API=true
Also the gamestate class doesn't exist yet..
Does it need validation ? checking the turn ?testing if there is a gamestaterow with this id already ?

Hey I am trying to work on this one. Do you mean, we are not meant to change the actual code, just had the possibility to instantiate a gamestate if VITE_USE_GAMESTATE_API=true Also the gamestate class doesn't exist yet, should I cretae it and where ? Does it need validation ? checking the turn ?testing if there is a gamestaterow with this id already ?

This is blocked by #975, #940, #941, and #943. The individual issues aren't marked with their blockers, but they are grouped into 'iterations' in the GitHub Project for the GameState API rollout. Each iteration generally blocks the ones after it.
The first (and the current) iteration is all about setting up the basis of the environment. The next one lays the foundation of the application logic by creating the helpers that every individual endpoint in the GameState API will use (unpackGameState(), saveGameState(), emitGameState().
Then comes an iteration focused on getting the first actual endpoints which utilize GameStates, starting with this issue for dealCards().
As for this specific issue, it does require validation, as well as creating a new gameState, given the previous one. It should follow the overall outline and approach shown in the drawCards() example in the Backend Control Flow section of the spec.
This issue does entail both the validation and the execution of dealing cards, though the validation should probably be done in the endpoint, rather than in the dealcards function. It should error if there are existing game state rows, or if the game does not have status GameStatus.STARTED.
Notably, this depends on the issues listed above because the intent is that all the card manipulation logic be done on a GameState object, which is the unpacked, object-oriented version, as opposed to the GameStateRow, which using string ids because it is the database-storage version of the state.
As for the parentheses, they represent jacks that are attached to the specified card. See the Game State Array Lists
 for details regarding how this data is stored. But dealing the cards and all the other endpoints, should be dealing with full Card objects in the context of an unpacked GameState object, not a GameStateRow.


Installation Issue

Hi,
Am trying to run the installation url in my localhost it shows, website not created create

Please open the application/config/constants.php
change the value of your base url that serve as main url of the multisite.
in your case,change <IP_ADDRESS> to localhost.
defined('WEB_BASE_URL') or define('WEB_BASE_URL', '<IP_ADDRESS>');

alternatively ,you can update your repo. this issue had been addressed in last commit

Yes that works!
But now am getting this, while installing
Duplicate column name 'year'
CREATE TABLE payroll_payments ( id int(11) NOT NULL AUTO_INCREMENT, staff_id varchar(128) NOT NULL, ref varchar(128) NOT NULL, session varchar(128) NOT NULL, month varchar(128) NOT NULL, year varchar(128) NOT NULL, phone int, amount DECIMAL(19,2) NOT NULL, status varchar(128), year varchar(128), time int(20), PRIMARY KEY (id) );

Parent Login Shows error; May be .htaccess issue

Please update your repo.all issue reported is now resolved

Thanks it works!


Close CMake Window on successfull CMakeBuild

Describe the solution you'd like
It would be awesome to have an option which closes the CMake window after a successful build. Just to avoid the two keystrokes for cq.
Thanks for the great plugin :+1:

Hi, thanks for posting this!
I've been thinking about this, and yes, closing the CMake window after a successful :CMakeGenerate or :CMakeBuild would be a nice option to have.
More in general, I was thinking whether it's worth adding some autocommand events, something like CMakeBuildOk, CMakeBuildError, etc. That way, the user would be able to do anything on such events.
What do you think? Would events be an overkill? Maybe just a close-on-success options as you suggest is enough to cover all possible needs?

Autocommand events would be awesome because one could start the application after a successful build.
For now I have to build with a hotkey and then debug (vimspector) the application with a separate key.
I think having both options would be awesome, however I do not know vimscript and cannot tell how much time it takes to implement it.

Two use cases are already enough to go for autocommand events, as far as I'm concerned. I'll pick this up when I'm back from holidays, unless, of course, you'd like to give Vimscript a shot :).


Feature: Adding document update by filter

Adding a function to allow updating of all documents in a collection that match a supplied filter.
https://typesense.org/docs/0.25.2/api/documents.html#update-by-query
Output From Test.

Please let me know if there are any issues or suggested improvements.
This would be very beneficial to the project I am working on as it will allow us to do some better targeted updates.

Hi @AdamGilliesSA,
Thanks for the contribution. Can you remove the formatting changes that has been made in the README.md file and in the test file.
// Rune

@runeanielsen That should all be fixed now.

@AdamGilliesSA do you know if batchSize is necessary?  Can't seem to find it specified in the documentation.

@runeanielsen I followed the function for the delete by filter operation that is currently in the code base.
    public async Task<FilterDeleteResponse> DeleteDocuments(string collection, string filter, int batchSize = 40)
    {
        if (string.IsNullOrWhiteSpace(collection))
            throw new ArgumentException("cannot be null empty or whitespace", nameof(collection));
        if (string.IsNullOrWhiteSpace(filter))
            throw new ArgumentException("cannot be null empty or whitespace", nameof(filter));
        if (batchSize < 0)
            throw new ArgumentException("has to be greater than 0", nameof(batchSize));

        var response = await Delete($"/collections/{collection}/documents?filter_by={Uri.EscapeDataString(filter)}&batch_size={batchSize}").ConfigureAwait(false);
        return HandleEmptyStringJsonSerialize<FilterDeleteResponse>(response, _jsonNameCaseInsentiveTrue);
    }

I can find a reference in an older version of the docs but cannot see one on the latest docs.
https://typesense.org/docs/0.20.0/api/documents.html#configure-batch-size

@AdamGilliesSA can you remove it for now, then we can add it later if it is a thing.

@AdamGilliesSA this has now been released in version 7.3.0. Thanks for the contribution.
// Rune


`CXXABI_1.3.9' not found

When attempting to import mcycle in Python, I receive an Import Error which has this at the end:
/anaconda3/bin/../lib/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /home/usrname/anaconda3/lib/python3.6/site-packages/scipy/sparse/_sparsetools.cpython-36m-x86_64-linux-gnu.so)
I've done some searching and have tried a few remedies including reinstalling scipy and libgcc. I'm not entirely sure, but it may be an anaconda issue more than anything. I am using Ubuntu 16.04 and Python 3.6.4 :: Anaconda custom (64-bit).

I've only been using pip or setup.py install to install the package, I haven't tried it with Anaconda so I'm not entirely sure either. Can you try pip in a venv and see if that works ?

I was able to reinstall SciPy with pip and now I can import mcycle.


Question about R0 matrix  in get_calib_from_file in PENet/dataloaders/calibration_kitti.py.

def get_calib_from_file(filepath):
    ''' Read in a calibration file and parse into a dictionary.
    Ref: https://github.com/utiasSTARS/pykitti/blob/master/pykitti/utils.py
    '''

    data2 = {}
    R0 = np.array([[ 0.99992624,  0.00965411, -0.0072371 ],
                                          [-0.00968531,  0.99994343, -0.00433077],
                                          [ 0.00719491,  0.00440054,  0.99996366]])
    with open(filepath) as f:
        for line in f.readlines():
            if line[:2] == "P2":
                P2 = re.split(" ", line.strip())
                P2 = np.array(P2[-12:], np.float32)

            if line[:2] == "P3":
                P3 = re.split(" ", line.strip())
                P3 = np.array(P3[-12:], np.float32)

            if line[:14] == "Tr_velo_to_cam" or line[:11] == "Tr_velo_cam":
                vtc_mat = re.split(" ", line.strip())
                vtc_mat = np.array(vtc_mat[-12:], np.float32)

            if line[:7] == "R0_rect" or line[:6] == "R_rect":
                R0 = re.split(" ", line.strip())
                R0 = np.array(R0[-9:], np.float32)

    data2["P2"]=P2.reshape(3, 4)
    data2["P3"]=P3.reshape(3, 4)
    data2["Tr_velo2cam"]=vtc_mat.reshape(3, 4)
    data2["R0"]=R0.reshape(3, 3)

    return data2

As shown in above codes, while processing frames in data/kitti/semi, there is no R0 in data/kitti/semi/calib/xxxxxx.txt, you use fixed R0 in your method. I want to know why use this fixed R0 and how to generate this fixed R0? Because you know that in kitti object detection dataset, each frame has different R0.

You can use mean R0 or randomly choose single R0 from detection dataset. There won't be much difference in performance.


[Fix #11123 ] Fix auto correction bug for Style/StringLiterals

Fix: https://github.com/rubocop/rubocop/issues/11123
Before:
a = {
  b: "{\"[\\\"*\\\"]\""
}

was corrected to:
a = {
  b: '{"["*"]"'
}

These two strings are not the same.
After my changes it should result in correct string:
a = {
  b: '{"[\"*\"]"'
}

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This looks good to me. Can you add a changelog entry? Please see the end of the PR check items for details.

@si-lens ping :-)

This looks good to me. Can you add a changelog entry? Please see the end of the PR check items for details.

Oh right, forgot about it!
There you go 😄

Thanks!


drivers, crypto: Add support for CMAC

This pull request introduces the necessary API changes to perform CMAC operations using the crypto API. The pull request also includes the necessary changes to support CMAC operations using the TinyCrypt backend.
These are a step towards implementing support for secure elements in LoRaWAN.
Kudos to @ceolin for pointing me to #9227 with an old prototype that included the same functionality.

Although the implementation will probably be a little more complex, it seems unusual to me to present a MAC using a cipher API. Normally a block cipher will output ciphertext as its primary operation. Unfortunately, we don't seem to have an API for hashes/MACs. One option would be to create that.

BTW, implementing this using the crypto API is something that makes sense. But it'd be nice to have a more uniform API around hashing and MAC generation.

Although the implementation will probably be a little more complex, it seems unusual to me to present a MAC using a cipher API. Normally a block cipher will output ciphertext as its primary operation. Unfortunately, we don't seem to have an API for hashes/MACs. One option would be to create that.

Agreed. I have flagged this PR as an RFC to reflect the fact that the API needs work. Reviewing the code, it seems like the API could use a general cleanup (why is the subsystem called crypto, but everything prefixed with cipher?).
I suspect we want to distinguish between the following related algorithms:

MAC algorithms that use a block cipher (e.g., CMAC/OMAC, and VMAC)
MACs based on cryptographic hashes (e.g., the HMAC family).
Cryptographic hashes

To start a session, we need to know the following:

Cipher algorithm, cipher key, and MAC algorithm. We can probably assume the cipher is encrypting. For VMACs, we need to know the parameters of the universal hash function.
MAC algorithm, hash function, key.
Hash function

Option 1: The not so intrusive option
I thin we could accommodate 1 without making large changes to the API. Treating CMAC as a mode is the least intrusive option, but it is ugly. We could potentially add CRYPTO_CIPHER_OP_DIGEST and CIPHER_MODE_CMAC/CIPHER_MODE_VMAC. We probably want to rename the enums in that case, but the rest of the API could remain largely the same. CMAC would then be described by CRYPTO_OP_DIGEST/CRYPTO_ALGO_AES/CRYPTO_MODE_CMAC.
For use case 2, we could just go with the proposal above and generalise cipher_algo to include cryptographic hashes. In that case, we would need to include HMAC as a mode. HMAC-SHA256 would then become CRYPTO_OP_DIGEST/CRYPTO_ALGO_SHA256/CRYPTO_MODE_HMAC.
Use case 3 could then easily be implemented by having a HASH mode. E.g.: CRYPTO_OP_DIGEST/CRYPTO_ALGO_SHA256/CRYPTO_MODE_HASH.
The main benefits of this approach is that it isn't particularly intrusive. We could keep the same begin/end session calls and any API changes could be patched up with a simple SED script.
The main drawbacks are:

Redundant parameters and state in the context structure for hashes and hash-based MACs.
Clunky API for simple use cases, particularly for plain hashes and ECB encryption.
Representing hash and crypto algorithms in the same enum feels a bit dirty.

Option 2: Separate begin_session flavours
We could add separate flavours of begin_session for the three different operation classes described above. There would be a lot of overlap between encryption and cipher-based MACs, but that might be OK.
We would probably want to define a base context struct and separate context structs for each of the operation types in that case since the parameters and the amount of state differs.
Operations from each flavour would take a context of the specific type. E.g., crypto_cmac would take a cipher_cmac_ctx and crypto_cipher_*_op would take a crypto_cipher_ctx.
Option 3: Extend context and drop algo, mode, and type from begin_session
Similar to option 2, but instead of separate session calls, encode all of the parameters in a super context that is a union of all the supported contexts. Individual operations take a pointer to the  super context.

We should probably also look at both PKCS#11 and the Arm PSA crypto API specification. Developing yet another crypto API just because we can't isn't particularly useful, especially since using another specification would make it easier to work with 3rd party code. PSA crypto is probably a better match to what we want in Zephyr.

We should probably also look at both PKCS#11 and the Arm PSA crypto API specification. Developing yet another crypto API just because we can't isn't particularly useful, especially since using another specification would make it easier to work with 3rd party code. PSA crypto is probably a better match to what we want in Zephyr.

The PSA API seems like a good starting point, especially since TF-M was merged the other day and we should use that as a backend if available. The only missing functionality compared to the current api would be the ability to execute operations asynchronously, but that’s probably not used.
Rewriting the API is a bigger project than I was planning on, so I don’t think I can justify that at the moment.

It might be worth asking one of the Linaro engineers working in the TF-M integration though. It seems like it would overlap with their interests.

cc @frkv

What motivated me to come up with this implementation was to add the missing pieces to implement a secure element interface for LoRaWAN. However, the current API needs quite a bit of work to support hardware secure elements (key derivation in hardware, key management, etc.) for that use case.
I agree with @d3zd3z that the effort would be better spent around a standardised and well-known API like PKCS11 or PSA that already exposes the require functionality. I have opened issue #25643 since there is a larger problem that needs to be solved.

Closing this PR since there is there doesn't seem to be a compelling reason to add CMAC to the current API without other major changes to the API.


Investigate a mechanism to hand write service specific customizations

Describe the feature
There are times where we need to make service specific customizations. One example is #214. Currently, we need to implement the customization via codegen, even if all the code is static (does not depend on smithy models).
It would be much simpler if we could implement these customizations directly as swift code (without needing to go through the code generation process). We still would only want these files to be included in their corresponding service module, which makes this tricky.
Investigate a way that we can write service specific swift files (and tests).
Use Case
N/A
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

not adding to GA as we are not blocked for any feature that needs this.

Moved to 2168


RUM-5110: Update models with KMP SDK source

What does this PR do?
Follow-up https://github.com/DataDog/rum-events-format/pull/214: update RUM and telemetry schema.
No code/tests changes needed.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.61%. Comparing base (29692c8) to head (80e6857).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2109      +/-   ##
===========================================
- Coverage    69.63%   69.61%   -0.01%
===========================================
  Files          715      715
  Lines        26566    26580      +14
  Branches      4454     4456       +2
===========================================
+ Hits         18497    18503       +6
- Misses        6845     6861      +16
+ Partials      1224     1216       -8

see 27 files with indirect coverage changes


VNC "Failed to Connect" error

Frequently when hitting the IP:port for my running container, I get a red bar at the top with a "Failed to Connect" message. This is resolved by restarting the container. This can have the unintended consequence of really mucking with the running crashplan instance.
I've also noticed that I can fix it by killing the xvnc process running inside the container itself.
There is nothing in the logs that looks relevant. Ideas on what to look for?

Do you see the problem with different browsers ?

Yes, I've tried with Edge, Chrome and Firefox. I've set CONTAINER_DEBUG to 1 but I'm not seeing any additional logging or indication of what is crashing/hanging. Is there anyway to turn on additional verbosity of the xvnc process?

CONTAINER_DEBUG already increases verbosity of xvnc...
Did you see the problem with the latest image ?  In this image, xvnc has been upgraded to the latest version.

The latest version has been up for 4 days now without the xvnc crash. That looks like it may have solved it.

Thanks for the update, closing this issue.


Add in env variables for git email and username for greenkeeper

Greenkeeper lockfile env variables

Greenkeeper lockfile updating is still failing and the best result I could find online is this https://github.com/greenkeeperio/greenkeeper-lockfile/issues/206 I am following the suggestion to expose and set these variables (even though they should be defaulted) in the hopes it finally works.

Deploy preview for gestalt ready!
Built with commit 497be10af458107ebbd13e04514752bbcb871ff6
https://deploy-preview-381--gestalt.netlify.com


feat: expand/collapse enhancement

Pre-Flight checklist

[ ] Screenshots and design review for any changes that affect layout or styling

[ ] Desktop screenshots
[ ] Mobile width screenshots

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
Closes https://github.com/mitodl/ocw-hugo-themes/issues/329
What's this PR do?
New enhanced design for expanding and collapsing course description, course meta-data and image description.
How should this be manually tested?

Verify that image description, course description and course info (meta-data) expands and collapse correctly when arrow icon is clicked/toggled.
Change the size of the content or test them on different courses having different sizes/lengths of content.
Test the above on multiple browsers and multiple screen sizes.

Screenshots (if appropriate)
Video link: https://drive.google.com/file/d/1R8yhyXMAMVmjZn9dphS0kjAjpxwbkwm2/view?usp=sharing

You're right @MAbdurrehman12 this one looks better. Let's merge this.


Fix Cypress tests and add them to the GitHub Actions workflow

The Cypress tests have broken after recent frontend changes. The Cypress tests should be fixed and be run as part of the Notification Dashboards GitHub Action workflow so it can be verified during PRs.
Also, the GitHub Actions should build the artifact and install it into OpenSearch Dashboards before running the tests to catch things like https://github.com/opensearch-project/notifications/pull/411.

Cypress tests were fixed in https://github.com/opensearch-project/notifications/pull/436 but keeping this issue open until they are added to the GitHub Actions workflow


I wish /docs/user-guide/connecting-to-applications-port-forward/ output to be updated

Console output are out-dated
-t is deprecated and should be --template

Fixed. http://kubernetes.io/docs/user-guide/connecting-to-applications-port-forward/


auto sharding strategy for theta sketch

I was going through the pr : https://github.com/apache/pinot/pull/5316
Can you please point me to how or where is this implemented. How do we define high cardinality threshold
I am running into issues where different sets can be different cardinality and error is high and wanted insights on how to tune theta params during my indexing phase . what is a reasonable theta threshold to decide high cardinality

Here is the doc for the function: https://docs.pinot.apache.org/configuration-reference/functions/distinctcountthetasketch
You may also learn more about theta sketch here: https://datasketches.apache.org/docs/Theta/ThetaSketchFramework.html
There is one parameter that can be passed in the function: nominalEntries. By default it is set to 4096, and you may try a higher value to get better accuracy (performance will be worse)

May be my question wasn't clear. I understand what theta sketches are , but trying to understand how you build auto sharding for some high cardinality segments when constructing theta sketch , what is considered high cardinality , what thresholds ?
IIUC intersection(theta_sketch(a) , theta_sketch(b)) can have high error rate when jaccard similarity is low or difference between cardinality of A and B sets are big , so you also shard the bigger set to have size smaller . Trying to understand better on how is this sharding implemented

The implementation for this support is in the DistinctCountThetaSketchAggregationFunction class.
With the current implementation, we don't shard the set. I think this can be a good optimization, and we need some research to decide a cardinality threshold to shard the set. We can also consider providing this threshold as a parameter to the function.
Do you want to help contribute this feature?


Add optional syncDbAfterWrite behavior and setting

The ARMI output database is created by the master node in parallel cases
and is actually written on a local scratch space during the run (for i/o
performance in large sweeps). There are some scenarios, however, where a
DB is needed by other MPI processes as they're doing their work (for
example, if a DB-derived history is needed). This feature just copies
the whole database from the local drive into the run's working directory
(often on a shared network drive) after every write.
This feature can be activted by setting the new syncDbAfterWrite user
setting to true.
Relatedly, MPI worker nodes now open the database with read-only
permissions after every DistributeState. This allows them to perform
DB-reading tasks during a run, now that the DB is available to them.
Also added optional Executer-level way to set a runPath.

tested manually. Travis will catch up soon.


Switch to make wgX interface to auto start on boot

Is your feature request related to a problem? Please describe.
restarting server would turn off all wgX interfaces
Describe the solution you'd like
it would be nice to add a switch to enable wgX interfaces to autostart on boot.
here are some quick commands we have to do on each interfaces
sudo systemctl enable<EMAIL_ADDRESS>sudo systemctl daemon-reload

Please refer to #293.


Fix formatting of "Show hash" area for arbitrary message signing

The arrow and text are misaligned vertically

I can fix this pretty quickly. Do you know how we want to align the text?
I can have it centered or stretching?
https://github.com/leather-wallet/extension/assets/2938440/4bb7b0a2-b141-4e86-af91-bef62d8db58e

I opened a PR changing it to be like this:

I'm not sure if thats exactly what we want but it fixes the misalignment at least.


fs/littlefs:littlefs shouldn't be used without C99 BOOL

Summary
littlefs is a c99 project, and it malfunctions with c89. See disscusion in https://github.com/littlefs-project/littlefs/pull/801.
To highlight this problem, littlefs added an assert in https://github.com/littlefs-project/littlefs/pull/801.
However, it is better to expose this when compiling. This patch adds a compiling error when C99 requirement is not met.
Impact
Littlefs
Testing
Compiling okay.

Can we either add CFLAGS += -std=c99 if C99 is a prerequisite or apply patch after tarball download to get it c89 compatible?

I re-inspected the code of littlefs and see that CFLAGS += -std=c99 is a must and code has designated initialiser, variable declaration in the middle of the scope and other C99 features.

Can we either add CFLAGS += -std=c99 if C99 is a prerequisite or apply patch after tarball download to get it c89 compatible?

-std=c99 is tool chain specific, it isn't good to turn on it in the common code.

But the littlefs code is anyway C89 in compliant no matter of a toolchain.
I just saw that CONFIG_C99_BOOL is selected based on __STDC_VERSION__ , so I'm fine with the change now.
#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
#  define CONFIG_C99_BOOL 1
#endif

Yes, I think it's enough to warn the user if they enforce c89 accidently.


Move samples to this repository

I was looking around at samples, and noticed these over here:
https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/talent-v4beta1-samples/jobs/v4
We really should have these in the samples/ dir in this repo, so it's consistent with the rest of the node.js repositories.

Those samples are not to be merged, they're pending a design implementation.
Talent v4beta1 samples will hit all 7 language client library repos in the coming weeks :)

Justin that link seems dead. I assume this has been resolved unless I simply don't have access?

Even better.  At some point, someone deleted the branch.  Now, this tab for nodejs is empty:
https://cloud.google.com/talent-solution/job-search/docs/libraries#client-libraries-usage-nodejs
There are however out of date samples here, that use the apiary based libs :|
https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/master/jobs

Even better. At some point, someone deleted the branch. Now, this tab for nodejs is empty:
https://cloud.google.com/talent-solution/job-search/docs/libraries#client-libraries-usage-nodejs

The branch talent-v4beta1-samples/ was merged into master and then deleted,  see https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/1801.
The Node.js tab in the docs uses sources from this repo. That got fixed in October.
I opened an issue in nodejs-docs-samples to delete the samples after making sure we don't use them in the docs anymore. See https://github.com/GoogleCloudPlatform/nodejs-docs-samples/issues/2103


Fixed window is not defined error in Node.js.

This allows server side rendering in Node.js, for example in a Next.js project.

Thank you.


Tried to implement left hand on wielding knife but I failed after numerous attempts...
anyone who can tell me whats wrong?
//Misc.cpp(Including some snippets so you know where I am at)
void Misc::leftKnife() noexcept
{
	if (config.misc.leftKnife) {

		static auto leftKnife = interfaces.cvar->findVar("cl_righthand");

		if (leftKnife->getInt()) return;

		const auto localPlayer = interfaces.entityList->getEntity(interfaces.engine->getLocalPlayer());
		const auto activeWeapon = localPlayer->getActiveWeapon();

		if (!activeWeapon || activeWeapon->getClientClass()->classId != ClassId::Knife)
			return;

		if (activeWeapon->getClientClass()->classId == ClassId::Knife && localPlayer->isAlive())
		{
			leftKnife->setValue("0");
		}
		else
		{
			leftKnife->setValue("1");
		}
	}
}

//GUI.cpp (Included some snippet so u know where I am)
        ImGui::Checkbox("Name stealer", &config.misc.nameStealer);
        ImGui::Checkbox("Fast plant", &config.misc.fastPlant);
		ImGui::Checkbox("Left Knife", &config.misc.leftKnife);
        ImGui::Checkbox("Bomb timer", &config.misc.bombTimer);
        ImGui::Checkbox("Quick reload", &config.misc.quickReload);
        ImGui::Checkbox("Prepare revolver", &config.misc.prepareRevolver);

//Config.cpp
        if (miscJson.isMember("Fast plant")) misc.fastPlant = miscJson["Fast plant"].asBool();
		if (miscJson.isMember("Left knife")) misc.leftKnife = miscJson["Left knife"].asBool();

//.. blablblabla

        miscJson["Name stealer"] = misc.nameStealer;
        miscJson["Fast plant"] = misc.fastPlant;
		miscJson["Left knife"] = misc.leftKnife;

//Config.h
        bool nameStealer{ false };
        bool fastPlant{ false };
		bool leftKnife{ 0 };
        bool bombTimer{ false };

Did you call it ?
In hooks.cpp

Did you call it ?
In hooks.cpp

Why would I need to call it, it's not a hook... I'm literally changing a cvar name? It's in the Misc Struct so I'd guess everything is already being called.

Add Misc::leftKnife();
In Hooks.cpp line 110 and see the magic.
If it didn't work then there's something wrong in your code.

Add Misc::leftKnife();
In Hooks.cpp line 110 and see the magic.
If it didn't work then there's something wrong in your code.

  It was a debug if and SEEMS LIKE I DIDNT DELETE IT COMPLETELY.
Sent with GitHawk

@ijre sorry for tagging you
and @effex1337
I've another small and last issue if you could try and give it a look at least.
It's related to a viewmodel x/y/z changer with slider.
For some reason my game crashes if I join a multiplayer game like instantly, if I remove everything in Misc.h Misc.cpp Config.h Config.cpp and just leave the null callbacks in the Hooks.cpp I can change the value of viewmodel x y z to whatever value I want without crashing whatsoever
Behold If I implement the feature with saving and in GUI ... CRASH INSTANTLY ON JOINING THE SERVER.
Also the configs look fucked up, for example I could have my settings saved under misc.leftKnife(); but they show up under spectatorlist for some reason? The values get saved but they can't be loaded for some reason??
//Misc.h struct
namespace Misc {
	void inverseRagdollGravity() noexcept;
	void updateClanTag(bool = false) noexcept;
	void spectatorList() noexcept;
	void sniperCrosshair() noexcept;
	void recoilCrosshair() noexcept;
	void watermark() noexcept;
	void prepareRevolver(UserCmd*) noexcept;
	void fastPlant(UserCmd*) noexcept;
	void leftKnife() noexcept;
	void viewModel() noexcept;
	void drawBombTimer() noexcept;
	void stealNames() noexcept;
	void quickReload(UserCmd*) noexcept;

//Misc.cpp function
void Misc::viewModel() noexcept
{
	if (config.misc.viewModel) {
		interfaces.cvar->findVar("viewmodel_offset_x")->setValue(config.misc.viewModel_x);
		interfaces.cvar->findVar("viewmodel_offset_y")->setValue(config.misc.viewModel_y);
		interfaces.cvar->findVar("viewmodel_offset_z")->setValue(config.misc.viewModel_z);
	}
}

//GUI.cpp implementation
        ImGui::Checkbox("Fast plant", &config.misc.fastPlant);
		ImGui::Checkbox("Left knife", &config.misc.leftKnife);
		ImGui::Checkbox("ViewModel", &config.misc.viewModel);
		if (config.misc.viewModel) {
			ImGui::SliderFloat("ViewModel X", &config.misc.viewModel_x, -10, 30);
			ImGui::SliderFloat("ViewModel Y", &config.misc.viewModel_y, -10, 30);
			ImGui::SliderFloat("ViewModel Z", &config.misc.viewModel_z, -10, 30);
		}

//Hooks.cpp under createMove (?) I tried putting it up in main Hooks() funct and it still worked but i dunno why i changed it here, saw someone mention it on UC.
	interfaces.cvar->findVar("viewmodel_offset_y")->onChangeCallbacks.size = 0;
	interfaces.cvar->findVar("viewmodel_offset_x")->onChangeCallbacks.size = 0;
	interfaces.cvar->findVar("viewmodel_offset_z")->onChangeCallbacks.size = 0;

//Config.cpp
        if (miscJson.isMember("Fast plant")) misc.fastPlant = miscJson["Fast plant"].asBool();
		if (miscJson.isMember("Left knife")) misc.leftKnife = miscJson["Left knife"].asBool();
		if (miscJson.isMember("Viewmodel")) misc.viewModel = miscJson["Viewmodel"].asBool();
		if (miscJson.isMember("ViewModel x")) misc.viewModel_x = miscJson["Viewmodel x"].asFloat();
		if (miscJson.isMember("ViewModel y")) misc.viewModel_y = miscJson["Viewmodel y"].asFloat();
		if (miscJson.isMember("ViewModel z")) misc.viewModel_z = miscJson["Viewmodel z"].asFloat();

//Config.cpp
        miscJson["Name stealer"] = misc.nameStealer;
        miscJson["Fast plant"] = misc.fastPlant;
		miscJson["Left knife"] = misc.leftKnife;
		miscJson["Viewmodel"] = misc.viewModel;
		miscJson["Viewmodel x"] = misc.viewModel_x;
		miscJson["Viewmodel y"] = misc.viewModel_y;
		miscJson["Viewmodel z"] = misc.viewModel_z;

//Config.h
        bool nameStealer{ false };
        bool fastPlant{ false };
		bool leftKnife{ false };
		bool viewModel{ false };
		float viewModel_x{ 0 };
		float viewModel_y{ 0 };
		float viewModel_z{ 0 };

and this is how my config looks upon saving...
		"Left knife" : true,
		"Max angle delta" : 255.0,
		"Menu key" : 45,
		"Name stealer" : false,
		"Prepare revolver" : false,
		"Prepare revolver key" : 0,
		"Quick reload" : false,
		"Radar hack" : true,
		"Recoil crosshair" : false,
		"Reveal ranks" : true,
		"Sniper crosshair" : false,
		"Spectator list" : true,
		"Viewmodel" : true,
		"Viewmodel x" : 8.9860000610351563,
		"Viewmodel y" : -3.7679998874664307,
		"Viewmodel z" : 6.6669998168945313,
		"Watermark" : false

Which looks pretty stupid as I clearly put it under left knife?  I couldn't debug.

I'll just create a pull request(maybe xd depends on my mood) I've been successful in it.

And i literally gave my code for left hand knife it works just had it :man_shrugging:

I fixed it long ago this is about something else please read it xd
Sent with GitHawk

All I had to do was to remove the useless check/return now I have another small issue with a viewmodel x y z uncapper/changer
Sent with GitHawk

@effex1337  the problem is that I'm just plain crashing when I'm dead with left knife on...

Lemme ask you something @deparle
Do you have a weapon when you're dead?
If you get this you should be able to debug better.

Lemme ask you something @deparle
Do you have a weapon when you're dead?
If you get this you should be able to debug better.

I fixed it, I was compiling an old version of my .dll using Debug preset instead of Release. Just a small bug.
Can you take a look at this, if im not bothering u ? https://github.com/danielkrupinski/Osiris/issues/497

void Visuals::custom_viewmodel() noexcept {
static ConVar* view_x = interfaces.cvar->findVar("viewmodel_offset_x");
static ConVar* view_y = interfaces.cvar->findVar("viewmodel_offset_y");
static ConVar* view_z = interfaces.cvar->findVar("viewmodel_offset_z");
static ConVar* bob = interfaces.cvar->findVar("cl_bobcycle");
static ConVar* impacts = interfaces.cvar->findVar("sv_showimpacts");//showimpacts (lazy to make new void for this)
ConVar* sv_minspec = interfaces.cvar->findVar("sv_competitive_minspec");
(int)((DWORD)& sv_minspec->onChangeCallbacks + 0xC) = 0;
sv_minspec->setValue(0);
bob->setValue(0.98f);
view_x->setValue(config.visuals.customviewmodel_x);
view_y->setValue(config.visuals.customviewmodel_z);
view_z->setValue(config.visuals.customviewmodel_y);
impacts->setValue(config.misc.showimpacts);//showimpacts (lazy to make new void for this)
}

Hf

Hf

@effex1337
I have already this feature the problem is saving it in the config...
for example I have everything with custom_viewmodel() under leftknife() yeah?
In the config, my custom_viewmodel x y z appear somewhere under spectator list so it never gets to be loaded, just saved...

ViewModel
viewModel

It's case sensitive while loading and saving Config

omggggggg thank you so much <3 love u man!
I'm RETARDED! didnt know that lol

:)

do u have discord?

Yeah discord.io/effex

Hey, sorry for the super late comment, but it's worth letting you know since effex didn't say anything; the reason the viewmodel stuff doesn't save under left knife is because when it saves it organizes everything alphabetically

No it doesnt need to be ordered correctly
It's just case sensitive and hes already fixed it.


Point mintinfo command to local node.

I want to know what is in the name registry of an eris-db container so I created a shell and ran the following command:
eris@5e725856816f:~/.eris$ mintinfo names
Post http://pinkpenguin.chaintest.net:46657: dial tcp <IP_ADDRESS>:46657: connection refused

I would expect mintinfo (and any similar commands) to be configured for the local node by default instead of  pinkpenguin.chaintest.net.

this has been updated to point to localhost in 0.10.3


Maintenance update

fixed #2
fixed #19; related test cases fixed
added DNS resolver abstraction: one is free to use any DNS library and two implementations included
unnecessary allocations removed
test code simplified
public API minimised for maintainability

Hi Dmitry,
Thanks a lot for all the work! I am going to merge it eventually, just travelling a lot at the moment. If you have another pull requests feel free to add them too!

I was going to investigate a couple issues your mentioned before (with
include and exists). Will you reopen them as defects?
On Tue, 7 Feb 2017, 07:46 Marek Denis<EMAIL_ADDRESS>wrote:

Merged #20 https://github.com/zaccone/spf/pull/20.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zaccone/spf/pull/20#event-951616279, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAJj_9nUVW6waH9I4W_G5RZt-BBHDXeQks5raCFugaJpZM4LsTtF
.

--
Kind regards
Dmitry Motylev

Some of the issues don't hold, as apparently later commits from the PR fixed them, but I still think there are two major issues right now:

https://github.com/zaccone/spf/blob/master/parser.go#L277-L278 .I reckon this should return true, Permerror, nil as per 5.2.  "include", and the table at the bottom of the section.

https://github.com/zaccone/spf/blob/master/parser.go#L299-L302 - we should return true here, otherwise, as mentioned in the review, Parser.parse() will not match that (invalid, faulty) term and simply skip, whereas general rule of thumb is to return immediately (4.4.  Record Lookup and 4.6.  Record Evaluation).

I was going to fix it tomorrow, but I will be happy to accept PRs. Please, just let's try to make smaller PRs, otherwise it's hard to review and merge. Ideally, one PR per feature.

Tomorrow is great.
From my point of view, API is pretty stable and it's safe to mention that
fact in readme
On Tue, 7 Feb 2017, 08:49 Marek Denis<EMAIL_ADDRESS>wrote:

Some of the issues don't hold, as apparently later commits from the PR
fixed them, but I still think there are two major issues right now:

https://github.com/zaccone/spf/blob/master/parser.go#L277-L278 .I
reckon this should return true, Permerror, nil as per 5.2. "include", and
the table at the bottom of the section.
https://github.com/zaccone/spf/blob/master/parser.go#L299-L302 - we
should return true here, otherwise, as mentioned in the review,
Parser.parse() will not match that (invalid, faulty) term and simply skip,
whereas general rule of thumb is to return immediately (4.4. Record Lookup
and 4.6. Record Evaluation).
I was going to fix it tomorrow, but I will be happy to accept PRs. Please,
just let's try to make smaller PRs, otherwise it's hard to review and
merge. Ideally, one PR per feature.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zaccone/spf/pull/20#issuecomment-277936712, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJj__T_PX2LCUzdXmxL04NHJ8P7Gdqvks5raDAigaJpZM4LsTtF
.

--
Kind regards
Dmitry Motylev


[REFACTOR] refactor the glue&squad data preprocessing scripts and move it to main API

Description
Refactor the existing data preprocessing scripts(glue and squad) to make it

appropriate for both BERT and XLNet.
more scalable for future models.
more efficient in squad preprocessing

Checklist
Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

Job PR-1031/15 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1031/15/index.html

Job PR-1031/16 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1031/16/index.html

Job PR-1031/17 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1031/17/index.html

Job PR-1031/20 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1031/20/index.html

@eric-haibin-lin Sure, I will run it. Actually I have test the output of the new pipeline against the origin one, and they are exactly the same, so hopefully the result of fine-tuning will be the same.


Cannot save model every epoch

There is a SerializeModelCallback, I tried but it seems to overwrite model again and again. And when training is done I get the finally model. But what I want is to get a few models (XXX-epoch01.p, XXX-epoch02.p XXX-epoch03.p ........) How can I do that?

You can use the -H flag to store model history. For example the command -s mymodel.p -H 60 will retain the 60 most recent model files, saved as mymodel_0.p, mymodel_1.p, and so forth.

Great. That's what I want. Thanks.


RM-205135 Release w_dio 5.3.1

Pull Requests included in release:

Patch changes:

include json packages

Requested by: @colefeisthamel-wf
Diff Between Last Tag and Proposed Release: https://github.com/Workiva/w_dio/compare/5.3.0...Workiva:release_w_dio_5.3.1
Diff Between Last Tag and New Tag: https://github.com/Workiva/w_dio/compare/5.3.0...5.3.1
The logs for the request that created this PR can be found here
This pull request can be recreated by clicking here

Security Insights
No security relevant content was detected by automated scans.
Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@Workiva/release-management-p we're good to go


Increase the maximum of blockSize to 64MB

What would you like to be added:
Increase the maximum of blockSize to 64MB.
the blockSize is limited to 16MB as below.
2023/02/24 19:20:09.873853 juicefs[92260] <INFO>: Meta address: sqlite3://myjfs.db [interface.go:402]
2023/02/24 19:20:09.874905 juicefs[92260] <WARNING>: block size is too large: 262144, use 16384 instead [format.go:182]
2023/02/24 19:20:09.891811 juicefs[92260] <INFO>: Data use hdfs://example.com:8020/myjfs/ [format.go:429]
2023/02/24 19:20:10.024762 juicefs[92260] <INFO>: Volume is formatted as {
  "Name": "myjfs",
  "UUID": "632b5b58-e0cd-4331-875a-a6e604044573",
  "Storage": "hdfs",
  "Bucket": "example.com:8020",
  "AccessKey": "user1",
  "BlockSize": 16384,
  "Compression": "none",
  "TrashDays": 1,
  "MetaVersion": 1
}

Why is this needed:
a large number of files are burdens to hdfs.
https://medium.com/arabamlabs/small-files-in-hadoop-88708e2f6a46
If the blockSize of JuiceFS is 16MB, at least 62,500 files would be generated in hdfs for storing 1TB data.
that's great pressure on our hdfs.
I think it is not easy to increase more than 64MB, because the chunk size is 64MB.
but, It looks possible to 64MB.
If there's no problem, I can work on this.
thanks

In JuiceFS, each block corresponds to an object in the object storage, and the blockSize is used as an unit for many strategies like readahead. The time cost, read amplification and failure rate may increase when the blockSize is too big. Thus, it's not recommended to increase the blockSize to 64 MiB.


feat: support to go back on settings lists

Added support for going backward in the location selection screen.

teşekkürler @berat


Invalid HTTP header field values

On Flutter channel beta and dev, requests to certain APIs are failing because of invalid http response header field values:
E/flutter (17842): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: HttpException: Invalid HTTP header field value: "246.792Âµs"
E/flutter (17842): #0      _HttpHeaders._validateValue  (dart:_http/http_headers.dart:626:9)
E/flutter (17842): #1      _HttpHeaders._addAll  (dart:_http/http_headers.dart:75:18)
E/flutter (17842): #2      _HttpHeaders.add  (dart:_http/http_headers.dart:66:5)
E/flutter (17842): #3      _HttpParser._doParse  (dart:_http/http_parser.dart:719:24)
E/flutter (17842): #4      _HttpParser._parse  (dart:_http/http_parser.dart:328:7)
E/flutter (17842): #5      _HttpParser._onData  (dart:_http/http_parser.dart:850:5)

This is not the case on channel stable. Every http library I know of is affected by this (dart http, dio, etc.) when you're not on the stable channel. I also tested it with some native libraries like Retrofit on Android which are not having those issues.

@zichangg Is this due to any of your recent changes? Did the HttpHeaders parsing change accidentally make it into any release before it was reverted?

This is because value is not UTF8 encoded. HttpParser decode the value using UTF8 and it will throw exception if it broke.
@sortie Not the recent one. But I made httpparser throwing if validation failed.

But is there a reason why it has to throw? Couldn't the parser simply ignore the value as it did before (I assume)? The average developer has no influence over what the API is sending back and is probably also more interested in parsing some JSON, XML, etc. in the body. In my case this one character μ is breaking the whole request, even though the JSON that's returned is totally fine.

But is there a reason why it has to throw?

Previously it was even worse. It broke without even notifying with a correct exception.

Couldn't the parser simply ignore the value as it did before (I assume)?

In terms of encoding scheme, what parser receives is only a stream of bytes. Some decoding schemes have to be applied here. We use UTF8 to decode the bytes to string.

Previously it was even worse. It broke without even notifying with a correct exception.

You certainly have more insights into this. All I can say is that the exact same request is successful on stable, but fails on beta. This is the header I get on stable:
{
  x-powered-by: rxstreamer-waqi/1.3,
  connection: keep-alive,
  date: Tue, 28 Apr 2020 19:45:35 GMT,
  transfer-encoding: chunked,
  access-control-allow-origin: *,
  content-encoding: gzip,
  vary: Accept-Encoding,
  content-type: application/json; charset=UTF-8,
  x-gen-time: 266.419Âµs,
  server: nginx
}

It doesn't throw any exception and more importantly I can access the response.body.

Oh. Forget about what i said. That's a different issue.
It is my mistake. https://dart-review.googlesource.com/c/sdk/+/138860
This is the fix.

/cc @pcsosinski @franklinyow @mit-mit - this is a accidental breaking change to HttpClient behavior, might warrant cherry pick into stable to prevent breaking people code.

Here's what happened:
Dart used to parse HTTP header as Latin-1 (by virtue of passing the individual bytes as input to String.fromCharCodes). 6a5b87f92c568f201caa95baed5581dd0f452164 began validating HTTP header names and values are composed of allowed characters in all code paths, including the HTTP parser. It wasn't caught that this change made the HTTP parser reject bytes 128 through 255, instead of parsing them as Latin-1 codepoints.
(To correct misleading information above, Dart does not decode headers as UTF-8. In fact, the problem is that the the server is sending the µ as UTF-8 which Dart used to decode as Âµ in Latin-1.)
This is technically a breaking change and wasn't intended/approved as such.
We should revert the breaking part of the change and cherry-pick it into the beta/stable channel.
I'll land Zichang's commit and update the cherry-pick request.

The fix has landed and the cherry-pick is being handled in https://github.com/dart-lang/sdk/issues/41701. We'll add a test to avoid this issue reappearing in https://github.com/dart-lang/sdk/issues/41706.

@sortie I'm not sure if this has been fixed now as part of #41706, because it's not on the flutter dev channel yet, but when a server returns characters like Ü, Ä or Ö in the response body for example (those are common german umlauts), then they are not properly decoded.
For example when the server returns this JSON object:
"properties": {
     "country": "Germany",
     "name": "Überlingen",
     "state": "Baden-Württemberg"
}

then the response.body from dart http looks like this:
"properties": {
     "country": "Germany",
     "name":"Ãberlingen",
     "state":"Baden-WÃ¼rttemberg"
}


App crashing on playstore , however the apk from android studio working fine.

please find the error log below:
java.lang.IllegalAccessError:
at io.flutter.plugins.GeneratedPluginRegistrant.registerWith (GeneratedPluginRegistrant.java)
at com.aleo.daksh_app.MainActivity.configureFlutterEngine (MainActivity.java)
at io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.onAttach (FlutterActivityAndFragmentDelegate.java:58)
at io.flutter.embedding.android.FlutterActivity.onCreate (FlutterActivity.java:13)
at android.app.Activity.performCreate (Activity.java:7340)
at android.app.Activity.performCreate (Activity.java:7331)
at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1275)
at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3106)
at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3269)
at android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:78)
at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1960)
at android.os.Handler.dispatchMessage (Handler.java:106)
at android.os.Looper.loop (Looper.java:214)
at android.app.ActivityThread.main (ActivityThread.java:7094)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:494)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:975)

@amitabhleo
can you provide your flutter doctor -v, your flutter run --release -v and the list of affected devices

@amitabhleo
can you provide your flutter doctor -v, your flutter run --release -v and the list of affected devices

here is the flutter doctor
/home/amitabhleo/Android/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel beta, 1.25.0-8.2.pre, on Linux, locale en_IN)
• Flutter version 1.25.0-8.2.pre at /home/amitabhleo/Android/flutter
• Framework revision b0a2299859 (5 days ago), 2021-01-05 12:34:13 -0800
• Engine revision 92ae191c17
• Dart version 2.12.0 (build 2.12.0-133.2.beta)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /home/amitabhleo/Android/Sdk
• Platform android-30, build-tools 30.0.3
• Java binary at: /usr/bin/java
• Java version OpenJDK Runtime Environment (build <IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04)
✗ Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/linux#android-setup for more details.
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).
[✓] Connected device (1 available)
• JKM AL00a (mobile) • DHE4C18C07005145 • android-arm64 • Android 9 (API 28)
! Doctor found issues in 2 categories.
Process finished with exit code 0

here is the flutter doctor
/home/amitabhleo/Android/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel beta, 1.25.0-8.2.pre, on Linux, locale en_IN)
• Flutter version 1.25.0-8.2.pre at /home/amitabhleo/Android/flutter
• Framework revision b0a2299859 (5 days ago), 2021-01-05 12:34:13 -0800
• Engine revision 92ae191c17
• Dart version 2.12.0 (build 2.12.0-133.2.beta)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /home/amitabhleo/Android/Sdk
• Platform android-30, build-tools 30.0.3
• Java binary at: /usr/bin/java
• Java version OpenJDK Runtime Environment (build <IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04)
✗ Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/linux#android-setup for more details.
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).
[✓] Connected device (1 available)
• JKM AL00a (mobile) • DHE4C18C07005145 • android-arm64 • Android 9 (API 28)
! Doctor found issues in 2 categories.
Process finished with exit code 0

name: daksh_app
description: A new Flutter application.
The following defines the version and build number for your application.
A version number is three numbers separated by dots, like 1.2.43
followed by an optional build number separated by a +.
Both the version and the builder number may be overridden in flutter
build by specifying --build-name and --build-number, respectively.
In Android, build-name is used as versionName while build-number used as versionCode.
Read more about Android versioning at https://developer.android.com/studio/publish/versioning
In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
Read more about iOS versioning at
https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.0+1
environment:
sdk: ">=2.2.2 <3.0.0"
dependencies:
flutter:
sdk: flutter
The following adds the Cupertino Icons font to your application.
Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^0.1.2
firebase_auth: ^0.15.3
cloud_firestore: ^0.13.6
firebase_storage: ^3.1.6
#image_picker: ^0.6.7+1
image_picker: ^0.6.7+21
geolocator: ^6.1.1
geocoding: ^1.0.5
dart_geohash: ^1.0.2
#google_maps_flutter: ^0.5.26+4
latlong: ^0.6.1
url_launcher: ^5.5.0
geocoder: ^0.2.1
characters: ^1.0.0
firebase_messaging: ^6.0.9
dev_dependencies:
flutter_test:
sdk: flutter
flutter_launcher_icons: ^0.7.5
flutter_icons:
android: "launcher_icon"
image_path: "assets/images/foogal.png"
For information on the generic Dart part of this file, see the
following page: https://dart.dev/tools/pub/pubspec
The following section is specific to Flutter.
flutter:
The following line ensures that the Material Icons font is
included with your application, so that you can use the icons in
the material Icons class.
uses-material-design: true
To add assets to your application, add an assets section, like this:
assets:
- assets/images/
- assets/json/
An image asset can refer to one or more resolution-specific "variants", see
https://flutter.dev/assets-and-images/#resolution-aware.
For details regarding adding assets from package dependencies, see
https://flutter.dev/assets-and-images/#from-packages
To add custom fonts to your application, add a fonts section here,
in this "flutter" section. Each entry in this list should have a
"family" key with the font family name, and a "fonts" key with a
list giving the asset and other descriptors for the font. For
example:
fonts:
- family: Schyler
fonts:
- asset: fonts/Schyler-Regular.ttf
- asset: fonts/Schyler-Italic.ttf
style: italic
- family: Trajan Pro
fonts:
- asset: fonts/TrajanPro.ttf
- asset: fonts/TrajanPro_Bold.ttf
weight: 700

For details regarding fonts from package dependencies,
see https://flutter.dev/custom-fonts/#from-packages

name: daksh_app
description: A new Flutter application.
The following defines the version and build number for your application.
A version number is three numbers separated by dots, like 1.2.43
followed by an optional build number separated by a +.
Both the version and the builder number may be overridden in flutter
build by specifying --build-name and --build-number, respectively.
In Android, build-name is used as versionName while build-number used as versionCode.
Read more about Android versioning at https://developer.android.com/studio/publish/versioning
In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
Read more about iOS versioning at
https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.0+1
environment:
sdk: ">=2.2.2 <3.0.0"
dependencies:
flutter:
sdk: flutter
The following adds the Cupertino Icons font to your application.
Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^0.1.2
firebase_auth: ^0.15.3
cloud_firestore: ^0.13.6
firebase_storage: ^3.1.6
#image_picker: ^0.6.7+1
image_picker: ^0.6.7+21
geolocator: ^6.1.1
geocoding: ^1.0.5
dart_geohash: ^1.0.2
#google_maps_flutter: ^0.5.26+4
latlong: ^0.6.1
url_launcher: ^5.5.0
geocoder: ^0.2.1
characters: ^1.0.0
firebase_messaging: ^6.0.9
dev_dependencies:
flutter_test:
sdk: flutter
flutter_launcher_icons: ^0.7.5
flutter_icons:
android: "launcher_icon"
image_path: "assets/images/foogal.png"
For information on the generic Dart part of this file, see the
following page: https://dart.dev/tools/pub/pubspec
The following section is specific to Flutter.
flutter:
The following line ensures that the Material Icons font is
included with your application, so that you can use the icons in
the material Icons class.
uses-material-design: true
To add assets to your application, add an assets section, like this:
assets:
- assets/images/
- assets/json/
An image asset can refer to one or more resolution-specific "variants", see
https://flutter.dev/assets-and-images/#resolution-aware.
For details regarding adding assets from package dependencies, see
https://flutter.dev/assets-and-images/#from-packages
To add custom fonts to your application, add a fonts section here,
in this "flutter" section. Each entry in this list should have a
"family" key with the font family name, and a "fonts" key with a
list giving the asset and other descriptors for the font. For
example:
fonts:
- family: Schyler
fonts:
- asset: fonts/Schyler-Regular.ttf
- asset: fonts/Schyler-Italic.ttf
style: italic
- family: Trajan Pro
fonts:
- asset: fonts/TrajanPro.ttf
- asset: fonts/TrajanPro_Bold.ttf
weight: 700

For details regarding fonts from package dependencies,
see https://flutter.dev/custom-fonts/#from-packages

It is affecting all devices. This was working fine  with the same code.

It is affecting all devices. This was working fine  with the same code.

Flutter is already up to date on channel beta
Flutter 1.25.0-8.2.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision b0a2299859 (5 days ago) • 2021-01-05 12:34:13 -0800
Engine • revision 92ae191c17
Tools • Dart 2.12.0 (build 2.12.0-133.2.beta)
Process finished with exit code 0

Flutter is already up to date on channel beta
Flutter 1.25.0-8.2.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision b0a2299859 (5 days ago) • 2021-01-05 12:34:13 -0800
Engine • revision 92ae191c17
Tools • Dart 2.12.0 (build 2.12.0-133.2.beta)
Process finished with exit code 0

@amitabhleo
are your experiencing crashes running it in release mode on physical device?
can you please provide the logs for flutter run --release -v

@amitabhleo
are your experiencing crashes running it in release mode on physical device?
can you please provide the logs for flutter run --release -v

This is on physical device when downloading from app store

This is on physical device when downloading from app store

Where do I generate the log from

Where do I generate the log from

@amitabhleo
making sure a physical device is attached run from terminal (not android studio)
cd <your app folder>
flutter run --release -v

it should behave like the final apk

@amitabhleo
making sure a physical device is attached run from terminal (not android studio)
cd <your app folder>
flutter run --release -v

it should behave like the final apk

I could not run this command however I copied the apk file and installed it on my phone, it worked without any error

I could not run this command however I copied the apk file and installed it on my phone, it worked without any error

I am uploading the app. bundle into playstore, here is the build.gradle file
def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
localPropertiesFile.withReader('UTF-8') { reader ->
localProperties.load(reader)
}
}
def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}
def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
flutterVersionCode = '3'
}
def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
flutterVersionName = '1.0.03'
}
apply plugin: 'com.android.application'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
def keystoreProperties = new Properties()
def keystorePropertiesFile = rootProject.file('key.properties')
if (keystorePropertiesFile.exists()) {
keystoreProperties.load(new FileInputStream(keystorePropertiesFile))
}
android {
compileSdkVersion 30
//ndkVersion 21.1.6352462
ndkVersion '22.0.7026061'
externalNativeBuild {
        cmake {

            version "3.10.2"
        }
    }

lintOptions {
    disable 'InvalidPackage'
    checkReleaseBuilds false

}

defaultConfig {
    // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
    applicationId "com.aleo.daksh_app"
    minSdkVersion 16
    targetSdkVersion 30
    //versionCode flutterVersionCode.toInteger
    versionCode = 39
    //versionName flutterVersionName
    versionName = '1.39.01'
    testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

    multiDexEnabled true
    versionNameSuffix '0'
    ndk {
        debugSymbolLevel 'SYMBOL_TABLE'
    }

}

signingConfigs {
    release {

        keyAlias keystoreProperties['key']
        keyPassword keystoreProperties['mihirmegha123']
        storeFile keystoreProperties['storeFile'] ? file(keystoreProperties['storeFile']) : null
        storePassword keystoreProperties['mihirmegha123']

    }
}
//not working
buildTypes {
    debug {
        // TODO: Add your own signing config for the release build.
        // Signing with the debug keys for now, so `flutter run --release` works.
        signingConfig signingConfigs.debug
        }
    }

buildTypes {
    release {
        // TODO: Add your own signing config for the release build.
        // Signing with the debug keys for now, so `flutter run --release` works.
        signingConfig signingConfigs.release

    }
}

}
flutter {
source '../..'
}
dependencies {
implementation 'com.google.firebase:firebase-messaging:21.0.1'
implementation 'com.google.firebase:firebase-analytics:18.0.0'
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test:runner:1.3.0'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.3.0'
implementation 'com.android.support:multidex:1.0.3'
implementation 'com.google.firebase:firebase-auth:19.4.0'
}
apply plugin: 'com.google.gms.google-services'
//apply plugin: 'com.android.application'

I am uploading the app. bundle into playstore, here is the build.gradle file
def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
localPropertiesFile.withReader('UTF-8') { reader ->
localProperties.load(reader)
}
}
def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}
def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
flutterVersionCode = '3'
}
def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
flutterVersionName = '1.0.03'
}
apply plugin: 'com.android.application'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
def keystoreProperties = new Properties()
def keystorePropertiesFile = rootProject.file('key.properties')
if (keystorePropertiesFile.exists()) {
keystoreProperties.load(new FileInputStream(keystorePropertiesFile))
}
android {
compileSdkVersion 30
//ndkVersion 21.1.6352462
ndkVersion '22.0.7026061'
externalNativeBuild {
        cmake {

            version "3.10.2"
        }
    }

lintOptions {
    disable 'InvalidPackage'
    checkReleaseBuilds false

}

defaultConfig {
    // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
    applicationId "com.aleo.daksh_app"
    minSdkVersion 16
    targetSdkVersion 30
    //versionCode flutterVersionCode.toInteger
    versionCode = 39
    //versionName flutterVersionName
    versionName = '1.39.01'
    testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

    multiDexEnabled true
    versionNameSuffix '0'
    ndk {
        debugSymbolLevel 'SYMBOL_TABLE'
    }

}

signingConfigs {
    release {

        keyAlias keystoreProperties['key']
        keyPassword keystoreProperties['mihirmegha123']
        storeFile keystoreProperties['storeFile'] ? file(keystoreProperties['storeFile']) : null
        storePassword keystoreProperties['mihirmegha123']

    }
}
//not working
buildTypes {
    debug {
        // TODO: Add your own signing config for the release build.
        // Signing with the debug keys for now, so `flutter run --release` works.
        signingConfig signingConfigs.debug
        }
    }

buildTypes {
    release {
        // TODO: Add your own signing config for the release build.
        // Signing with the debug keys for now, so `flutter run --release` works.
        signingConfig signingConfigs.release

    }
}

}
flutter {
source '../..'
}
dependencies {
implementation 'com.google.firebase:firebase-messaging:21.0.1'
implementation 'com.google.firebase:firebase-analytics:18.0.0'
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test:runner:1.3.0'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.3.0'
implementation 'com.android.support:multidex:1.0.3'
implementation 'com.google.firebase:firebase-auth:19.4.0'
}
apply plugin: 'com.google.gms.google-services'
//apply plugin: 'com.android.application'

I am attaching the new crash report.
java.lang.IllegalAccessError:
at io.flutter.plugins.GeneratedPluginRegistrant.registerWith (GeneratedPluginRegistrant.java:111)
at com.aleo.daksh_app.MainActivity.configureFlutterEngine (MainActivity.java)
at io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.onAttach (FlutterActivityAndFragmentDelegate.java:58)
at io.flutter.embedding.android.FlutterActivity.onCreate (FlutterActivity.java:13)
at android.app.Activity.performCreate (Activity.java:7159)
at android.app.Activity.performCreate (Activity.java:7150)
at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1272)
at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3001)
at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3156)
at android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:78)
at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1864)
at android.os.Handler.dispatchMessage (Handler.java:106)
at android.os.Looper.loop (Looper.java:205)
at android.app.ActivityThread.main (ActivityThread.java:6991)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:884)

I am attaching the new crash report.
java.lang.IllegalAccessError:
at io.flutter.plugins.GeneratedPluginRegistrant.registerWith (GeneratedPluginRegistrant.java:111)
at com.aleo.daksh_app.MainActivity.configureFlutterEngine (MainActivity.java)
at io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.onAttach (FlutterActivityAndFragmentDelegate.java:58)
at io.flutter.embedding.android.FlutterActivity.onCreate (FlutterActivity.java:13)
at android.app.Activity.performCreate (Activity.java:7159)
at android.app.Activity.performCreate (Activity.java:7150)
at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1272)
at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3001)
at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3156)
at android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:78)
at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1864)
at android.os.Handler.dispatchMessage (Handler.java:106)
at android.os.Looper.loop (Looper.java:205)
at android.app.ActivityThread.main (ActivityThread.java:6991)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:884)

I am uploading app bundle generated from android studio to the play store

I am uploading app bundle generated from android studio to the play store

Hi @amitabhleo
This might be related to https://github.com/flutter/flutter/issues/73649
Can you please provide the other build.gradle  from android and a minimal complete reproducible code sample?
Thank you

Hi @amitabhleo
This might be related to https://github.com/flutter/flutter/issues/73649
Can you please provide the other build.gradle  from android and a minimal complete reproducible code sample?
Thank you

here is the other build.gradle file
buildscript {
repositories {
google()
jcenter()
}
dependencies {
    classpath 'com.android.tools.build:gradle:4.1.1'
    classpath 'com.google.gms:google-services:4.3.4'
    classpath "androidx.multidex:multidex:2.0.1"

}

}
allprojects{
repositories {
google()
jcenter()
}
tasks.withType(JavaCompile) {
options.compilerArgs << "-Xlint:unchecked" << "-Xlint:deprecation"
}
}
    rootProject.buildDir = '../build'
    subprojects {
        project.buildDir = "${rootProject.buildDir}/${project.name}"
    }
    subprojects {
        project.evaluationDependsOn(':app')
    }

    task clean(type: Delete) {
        delete rootProject.buildDir
    }

here is the other build.gradle file
buildscript {
repositories {
google()
jcenter()
}
dependencies {
    classpath 'com.android.tools.build:gradle:4.1.1'
    classpath 'com.google.gms:google-services:4.3.4'
    classpath "androidx.multidex:multidex:2.0.1"

}

}
allprojects{
repositories {
google()
jcenter()
}
tasks.withType(JavaCompile) {
options.compilerArgs << "-Xlint:unchecked" << "-Xlint:deprecation"
}
}
    rootProject.buildDir = '../build'
    subprojects {
        project.buildDir = "${rootProject.buildDir}/${project.name}"
    }
    subprojects {
        project.evaluationDependsOn(':app')
    }

    task clean(type: Delete) {
        delete rootProject.buildDir
    }

Hi @amitabhleo
I've reproduced this issue using the same Gradle. plugin and published the app bundle to play store just yesterday, there was no crash https://github.com/flutter/flutter/issues/73649#issuecomment-758498416 and I gave complete reproduction and issue Is open
Closing as duplicate of https://github.com/flutter/flutter/issues/73649, please read the issue and provide a reproducible steps /code sample
It's better to track this from one issue since they are the same.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you

Hi @amitabhleo
I've reproduced this issue using the same Gradle. plugin and published the app bundle to play store just yesterday, there was no crash https://github.com/flutter/flutter/issues/73649#issuecomment-758498416 and I gave complete reproduction and issue Is open
Closing as duplicate of https://github.com/flutter/flutter/issues/73649, please read the issue and provide a reproducible steps /code sample
It's better to track this from one issue since they are the same.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


Use string concatenation instead of format method

We use our macros with the nunjucks templating
language, written for JavaScript. Use of the
format method is causing an error in this
context because it is not supported in JavaScript.
This switches use of format out for string
concatenation with the + operator, something
supported by both Python and JavaScript.

Where do we use nunjucks?  Is that a new thing?

@TheDoubleK we use it in the prototype.
👍


Sqlite3/Detail/*: Use basic types for templates.

Hi @hosiawak, could you please check on your MacOS? clboss-basic-template-2.tar.gz
Also can you check that these still compile on your FreeBSD?

@ZmnSCPxj  It compiles on both systems.

Wheee!


Revert #651

This reverts commit 83ae6194b3e4feb363ea9d061085a7ab76e35ffb, reversing
changes made to 17e8f75d879b4a63ec06932cc8fca3e5a6534395.

PR #651 caused  a regression in Expensify/App. So reverting the commit.
Related issue: https://github.com/Expensify/App/issues/37472
Fixed Issues
$ GH_LINK
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
What tests did you perform that validates your changed worked?

QA

What does QA need to do to validate your changes?
What areas to they need to test for regressions?

@aswin-s could you please update description to link correct issue "$ GH_LINK"

@aswin-s could you please update description to link correct issue "$ GH_LINK" Also add meaningful PR description And update tests and QA sections

Updated.

You have mentioned this commit 17e8f75 Sorry, I couldn't get the context. The mentioned commit updates babel version

Fixed the description. Message was auto added by merge commit. Also please hold until I hear back from @AndrewGable or @ntdiary. Not sure if I should revert the PR first or just raise a fix.

@aswin-s you might want to open a PR in App to update expensify-common version


Question about model architecture

Hello, I was looking through the implementation, and I was curious about how you made choices regarding what to use for the architecture. Looking at the original paper here, I saw conv filter sizes and channel numbers listed, but I don't see any listings of the number of blaze blocks to use per layer and such parameters listed.
I used this paper as a reference to understand the structure of BlazeBlocks, but is that what you based your implementation on? Or did you get your architecture parameters from a different paper, or did you just experiment with it yourself?

The original paper on arxiv did not mention the detailed architecture of the network.
While, on the google AI blog, the authors released an implementation for mobile APP. My previous selection of the number of blaze blocks and channels was mainly based on the visualization of their model.


Don't fully trust kafka metadata errors

Verify that we really got a leader back, even in the case where the error is not
LeaderNotAvailable. Might solve #245.
@nsd20463 does this fix your bug? If so I will merge it, but I would also suggest filing a ticket upstream that Kafka should really return LeaderNotAvailable if it's not going to send us a broker.

r: @drdee @yagnik
cc: @wvanbergen @snormore @mkobetic

Kind of shitty that this is necessary, but :shipit:


Add oneTBB

Add oneTBB

There is no stable download URL - please add skip-url-stability-check label


MacOS Installation Error

luarocks install Lua-cURL
Installing https://luarocks.org/lua-curl-0.3.13-1.src.rock
Error: Could not find header file for CURL
No file curl/curl.h in /usr/local/include
No file curl/curl.h in /usr/include
No file curl/curl.h in /include
You may have to install CURL in your system and/or pass CURL_DIR or CURL_INCDIR to the luarocks command.
Example: luarocks install lua-curl CURL_DIR=/usr/local
PS - curl is installed in the system
curl --version
curl 7.64.1 (x86_64-apple-darwin20.0) libcurl/7.64.1 (SecureTransport) LibreSSL/2.8.3 zlib/1.2.11 nghttp2/1.41.0
Release-Date: 2019-03-27
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS GSS-API HTTP2 HTTPS-proxy IPv6 Kerberos Largefile libz MultiSSL NTLM NTLM_WB SPNEGO SSL UnixSockets

to be able to build C library you also have to install header files.
Not sure what is the right way on a MacOS

same issue but on chromebook arm.
solution (my case):
https://imgur.com/a/Xb1bG8l

install libcurl4-gnutls-dev from package manager (not luarocks; may case: APT )

apt search libcurl4

sudo apt-get install libcurl4-gnutls-dev

find curl.h path

find /usr/ | grep curl.h
find /usr/ | grep libcurl

install Lua-cURL by luarocks with path

example:
sudo luarocks install Lua-cURL CURL_INCDIR=/usr/include/aarch64-linux-gnu/


feat(client): adapt openAPI "listDiffData"

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 10 (20.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 82.796%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tensorbay/client/dataset.py
2
10
20.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
5342

Relevant Lines:
6452

💛  - Coveralls


Added support for isolating sitemap URLs from the array and adding them to the sitemap index.

Had a case where it was necessary to generate sitemaps using another method as well as use this library (long story)
Modified the code so that if a URL contains "sitemap" and ends with ".xml" it'll assume it's a sitemap, remove it from the URLs, and add it to the sitemap index.
Scenarios:

There are under 50,000 URLs and at least one of the URLs is a sitemap: It'll generate the sitemap index containing the sitemap(s) found in the URLs and sitemap-0.xml will contain the URLs (with the sitemap URLs removed).
There are over 50,000 URLs and at least one of the URLs is a sitemap: It'll generate the sitemap index and sitemap-#.xml routes like normal (with the sitemap URLs removed), but all of the sitemaps found in the URLs will be added to the sitemap index.
There are only sitemaps in the URLs: It'll create the sitemap index with the sitemaps and nothing else.
There are no sitemaps in the URLs: It'll behave the same as the package has always behaved.

Notes:

Implementation could be improved but it works.
If someone uses sitemap-#.xml in their URLs and the package ends up generating that same path, I'm not sure what the behavior would be, I haven't tested that. For my extra sitemaps I use a different route structure than the library uses (recommended approach).
Sitemaps in the URLs must be on the base domain (didn't do any parsing to see if it's external)

Hey @RAMOhio, I will be happy to merge this if you add a test 🙂


Use JsonUtf8Encoding : Encoding

Escaping string character is hurt of performance of JSON serialization.
It is possible to reduce escape cost by creating custom UTF8 Encoding that includes JSON encoding/decoding.
for invoke internal FastAllocateString, it is necessary to inherit Encoding.
public class JsonUtf8Encoding : Encoding
{
    // called from GetString.
    // return CharCount is \" ... \" unescaped.
    public override int GetCharCount(byte[] bytes, int index, int count)
    {
        throw new NotImplementedException();
    }

    public override int GetChars(byte[] bytes, int byteIndex, int byteCount, char[] chars, int charIndex)
    {
        throw new NotImplementedException();
    }

    public override int GetMaxByteCount(int charCount)
    {
        throw new NotImplementedException();
    }

    public override int GetMaxCharCount(int byteCount)
    {
        throw new NotImplementedException();
    }
    public override int GetByteCount(char[] chars, int index, int count)
    {
        throw new NotImplementedException();
    }

    public override int GetBytes(char[] chars, int charIndex, int charCount, byte[] bytes, int byteIndex)
    {
        throw new NotImplementedException();
    }
}

Also, it is necessary to implement efficient UTF 8 encoding/decoding.
I found this article.
http://bjoern.hoehrmann.de/utf-8/decoder/dfa/
If there are any other good examples, please let me know.

@itn3000 is trying fast utf8 <-> utf16 utilities.
https://github.com/itn3000/unicode-convert-utilities
@ufcpp is building custom UTF8 decoder.
https://github.com/ufcpp/Utf8Utils
NStack is golang like new encoding system.
https://github.com/migueldeicaza/NStack
System.Text.Utf8String is span based new primitive.
https://github.com/dotnet/corefxlab/tree/master/src/System.Text.Utf8String/System/Text

Regarding utf-8:
http://nullprogram.com/blog/2017/10/06/
https://news.ycombinator.com/item?id=15423674
and related from https://github.com/dotnet/corefxlab/issues/1831

hi @neuecc  we badly need your help, do you have an idea or workaround for our issue? https://github.com/neuecc/Utf8Json/issues/224


Prevent Unnecessary Radio Button and Radio Button Group Rerendering

Discussion
I stumbled across this great repository for React patterns / anti-patterns and I realized that the current implementation of RadioButton and RadioButtonGroup is woefully guilty of
this React bad practice
class App extends PureComponent {
  render() {
    return <MyInput
      onChange={e => this.props.update(e.target.value)}/>;
  }
}

Why is this bad?
Because e => this.props.update(e.target.value) creates a new function, which has a different reference, which means that React's shallow equality check is always false, which means that this will always re-render 😭 .
Just to make sure, I ran the debugger in Storybook and on any RadioButtonGroup change every single RadioButton re-rendered.

Coverage increased (+0.004%) to 99.472% when pulling 7aef32b729fd47733d2df9027322d893973fade8 on prevent-unnecessary-radio-button-rerendering into 6ad42ee210bf58c9889ed1ca7fdf7eb0c55db510 on master.

Coverage increased (+0.004%) to 99.472% when pulling 0f8e0fca44abcb054f74ecbc964b7ee2ba6f08aa on prevent-unnecessary-radio-button-rerendering into 7e05e7f16bc5c8fc12c6f218705a0729952290de on master.


Android full range mesh

Hi,
can i use full range face detector with the face mesh solution?
Thank you in advance.

Soon(-ish, hopefully :))! We mention it for face detector, but the same underlying models will work with mesh when it's ready, tested, and approved.
https://developers.google.com/mediapipe/solutions/vision/face_detector/index#blazeface_full-range


[RFC] Entry removal in post-processing

This allows entries to be explicitly removed by a postprocess function.
In the future, I want to add support for a user-defined NeomakePostProcess(maker, entry) function that's called after the maker's postprocess function.  This will reduce the cognitive load and the need for maintenance for an end user that just wants to alter/remove some entries without worrying about dealing with a built-in maker directly.

Thanks!
NeomakePostProcess makes sense for me, too.
Could/should we do it through a hook / user command?

Could/should we do it through a hook / user command?

Using autocmd would work, too.  In that case, it would be better to pass the entire list to reduce the number of post-processing calls if there is more than one subscriber.  But, that would mean that the list should be modified by the subscribers.  I don't know if that qualifies as "easy" from a user perspective, though.

But, that would mean that the list should be modified by the subscribers. I don't know if that qualifies as "easy" from a user perspective, though.

I am not sure either, but it seems like using autocommands for hooks is somehow a well-defined interface.  OTOH passing/setting the context as global vars is a bit silly.
Let's go with this PR as-is for now?

OTOH passing/setting the context as global vars is a bit silly.

No more silly than having v:whatever 😜

Let's go with this PR as-is for now?

👍


Setting minimum LogLevel to Trace in AddHangfire configuration throws System.MissingMethodException

When i set minimum loglevel in AddHangfire configuration as below;
services.AddHangfire(config =>
{
    config.UseColouredConsoleLogProvider(Hangfire.Logging.LogLevel.Trace);
}

throws  System.MissingMethodException. After setting loglevel back to Debug level, exception no longer occurs.
Here is the full details of exception:

System.MissingMethodException: Method not found: 'MongoDB.Bson.BsonDocument MongoDB.Driver.UpdateDefinition1.Render(MongoDB.Bson.Serialization.IBsonSerializer1<!0>, MongoDB.Bson.Serialization.IBsonSerializerRegistry)'.
at Hangfire.Mongo.MongoWriteOnlyTransaction.SerializeWriteModel(WriteModel`1 writeModel)
at Hangfire.Mongo.MongoWriteOnlyTransaction.Log()
at Hangfire.Mongo.MongoWriteOnlyTransaction.Commit()
at Hangfire.RecurringJobManager.AddOrUpdate(String recurringJobId, Job job, String cronExpression, RecurringJobOptions options)
at TestOkur.Notification.Startup.UseHangfire(IApplicationBuilder app)
at TestOkur.Notification.Startup.Configure(IApplicationBuilder app)
at Microsoft.AspNetCore.Mvc.Internal.MiddlewareFilterBuilderStartupFilter.<>c__DisplayClass0_0.g__MiddlewareFilterBuilder|0(IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()

@NazmiAltun,
I tried to reproduce in my sample project: Hangfire.Mongo.Sample.AspNetCore.
I use the same configuration
services.AddHangfire(config =>
            {
                // Read DefaultConnection string from appsettings.json
                var connectionString = Configuration.GetConnectionString("DefaultConnection");

                var migrationOptions = new MongoStorageOptions
                {
                    MigrationOptions = new MongoMigrationOptions
                    {
                        Strategy = MongoMigrationStrategy.Migrate,
                        BackupStrategy = MongoBackupStrategy.Collections
                    }
                };
                //config.UseLogProvider(new FileLogProvider());
                config.UseColouredConsoleLogProvider(LogLevel.Trace);
                config.UseMongoStorage(connectionString, "hangfire-mongo-sample-aspnetcore", migrationOptions);
            });

Can you identify any differences betweem the two setups? what Mongo driver version are you using?
thanks

@gottscj Mongo Driver  Version 2.9.0
Hangfire.Mongo Version 0.6.3
I call the function as below;
services.AddHangfire(config =>
{
	config.UseColouredConsoleLogProvider(Hangfire.Logging.LogLevel.Trace);
	var migrationOptions = new MongoStorageOptions
	{
		MigrationOptions = new MongoMigrationOptions
		{
			Strategy = MongoMigrationStrategy.Migrate,
			BackupStrategy = MongoBackupStrategy.None,
		},
	};
	config.UseMongoStorage(
		ApplicationConfiguration.ConnectionString,
		$"{ApplicationConfiguration.Database}-Hangfire",
		migrationOptions);
});

Or you can check the source code of entire startup.cs here  : https://github.com/testokur/TestOkur.WebApi/blob/master/src/TestOkur.Notification/Startup.cs

@NazmiAltun,
It looks OK to me. Could you try MongoDriver 2.8.0? I will update to the latest mongo driver in next release

@gottscj  yeah it seems to be working with  MongoDriver 2.8.0 .

@NazmiAltun,
Ok, I will make target the new mongo driver for the next release. else a PR would be greatly appreciated. :)

@gottscj  I can wait for the next release. No rush  :)


Can't eject Borg brains or modules

Description
When you try to eject a brain or module from a Borg, nothing happens. There's no error message, either. I've had to resort to destroying the Borg's body to get their brain or modules out to transfer to another new Borg body.
Reproduction
Unlock and open a Borg
Try to eject anything from them
Additional context
Upstream report: https://github.com/space-wizards/space-station-14/issues/32987

Description
When you try to eject a brain or module from a Borg, nothing happens. There's no error message, either. I've had to resort to destroying the Borg's body to get their brain or modules out to transfer to another new Borg body.
Reproduction Unlock and open a Borg Try to eject anything from them
Additional context Upstream report: space-wizards/space-station-14#32987

This is goob problem, not wizden problem

you can use verb to eject battery thats it
probably related to being a decade behind upstream :trollface:

you can use verb to eject battery thats it probably related to being a decade behind upstream :trollface:

It's happening because of goob preferred name


jenkins: pub_test needs to start px4 in daemon mode

Addressing #12475. I remember this occurring in the past with our other tests. Jenkinsfile-SITL_tests are all run in daemon mode.
It looks like Jenkins does something weird with the interactive shell that shuts down px4.

That error is mavros related I believe.


Aop logging

To close #274
Aop logging activation is based on spring.aop/logging property

@MSaguer : thanks for this contribution :)
Can you rebase against main branch plz?

Before testing, I needed to add this, in application-fast.properties:
logging.level.tech.jhipster.beer=DEBUG

It means, it should be added by default -> I'll do another PR for this
Then, I started the application with fast profile and it works well:
2021-12-21 18:26:36.127 DEBUG 113111 --- [nio-8080-exec-1] t.j.b.a.i.p.rest.AuthenticationResource  : Enter: authorize() with argument[s] = [LoginDTO{username='admin', rememberMe=false}]
2021-12-21 18:26:36.565 DEBUG 113111 --- [nio-8080-exec-1] t.j.b.a.i.p.rest.AuthenticationResource  : Exit: authorize() with result = <200 OK OK,tech.jhipster.beer.account.infrastructure.primary.rest.AuthenticationResource$JWTToken@43d396f0,[Authorization:"Bearer eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiJhZG1pbiIsImF1dGgiOiJST0xFX0FETUlOIiwiZXhwIjoxNjQwMTkzOTk2fQ.dc7K4V4wPcpy0GVB4uGqYSzSu3EHxWffww6agf7icYFZQQB3r5GBklF_o71a9pnTO9tGhH6C2D1aULmFWmV28A"]>

Remarks taken into account but not tested yet. I'l do it tomorrow.
Now it's time to use the PC to display a film to the family 😄

@MSaguer : yes, take care of yourself and families. It's more important than Open Source projects, as it can wait :) Nothing is urgent, as we do it during our freetime ;)
Again, thanks so much for helping this project

Question about the logging.level.tech.jhipster.beer property initialization. I think it could be set with default value as following

defaut : info
fast : debug
test : info
Do you agree?

Yes agree @MSaguer

@MSaguer : forgot to ask this. Can you add the API to these tests plz ? https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/generate.sh#L22-L46

Just tested it, and the build will fail with JaCoCo:
[WARNING] Rule violated for class tech.jhipster.beer.technical.infrastructure.secondary.aop.logging.LoggingAspect: lines covered ratio is 0.57, but expected minimum is 1.00
[WARNING] Rule violated for class tech.jhipster.beer.technical.infrastructure.secondary.aop.logging.LoggingAspect: branches covered ratio is 0.40, but expected minimum is 1.00
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:21 min
[INFO] Finished at: 2021-12-22T14:27:23+01:00
[INFO] ------------------------------------------------------------------------

It's normal as there is no tests for LoggingAspect.
it looks not so easy to add. If you need help, ask me, and I'll try to help here.

Just for your information, there are some conflicts. I wanted to solve with phone but it doesn't work well :-D
Take your time to solve it plz, nothing urgent.

It was a good idea to stop trying to fix conflicts with your phone. There were more than one file to fix :)

Really great work @MSaguer !!


Out of the Abyss

Creatures from "Out of the Abyss" added.

Thanks, this looks great!
Please add "unique: true" to all of the unique monsters (i.e. specific, named characters like Baphomet) and then I can merge this.