Explore replacing libwpasupplicant.a with a pure Rust implementation

This should be a non-default feature (i.e. defaulting to the precompiled libwpasupplicant.a)
It seems feasible to do this and might give some benefits (like better compile-time optimizations, compile time feature selection, better integration with esp-hal). It will most probably only offer a subset of functionality
Downsides might be that this code won't be battle-tested. However, we can have a look at the CVEs and see if anything potentially might apply. Due to reduced functionality and the use of Rust many of those probably won't apply
Resources

https://github.com/kelvincheung/lw_supplicant
https://github.com/espressif/esp-idf/tree/master/components/wpa_supplicant
https://fuchsia.googlesource.com/fuchsia/+/refs/heads/main/src/connectivity/wlan/lib/rsn
IEEE Std 802.11™-2020

Hi,
Let me offer some 'ancient' information. Coming from a C-based implementation of on-chip Wi-Fi support to non-ESP-IDF OSes. In other words, enabling ESP32 on Zephyr and NuttX with Wi-Fi.
We found that a supplicant layer was not that greatly supported out there on microcontroller world. Furthermore, Espressif Supplicant solution was actually pretty good (size, performance) with the downside of having binaries. Then, since those projects don't like to deal with binaries within their kernel, we created wireless-drivers-3rdparty (later we ran into the problem that for everything we took from ESP-IDF, another repo was created. Then we consolidated everything we need from ESP-IDF in esp-hal-3rdparty and have deprecated the other).
We ended up deciding that we would settle for packing everything within the driver even after these OSes adopted some form of supplicant layer. Kind of like the ancient Wi-Fi cards did. Such decision is still valid today, even after these OSes adopted some form of supplicant layer. The main reason now is that decoupling the driver from the supplicant layer is not something fast or easy to do. Also... Binaries will always be there, so the Wi-Fi stack would always to be tainted anyway, this would add no feature (and potentially introduce bugs) and we had other things to focus on.


Hotfix: topicsdb memory leak

Makes logrecBuilder.ready channel buffered, so goroutines don't stuck on sending result even if no receivers.

Codecov Report

Merging #581 (8dcbd5b) into develop2 (ad65fb7) will decrease coverage by 0.11%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##           develop2     #581      +/-   ##
============================================
- Coverage     47.94%   47.82%   -0.12%
============================================
  Files           161      161
  Lines         10917    10916       -1
============================================
- Hits           5234     5221      -13
- Misses         5155     5166      +11
- Partials        528      529       +1

Impacted Files
Coverage Δ

topicsdb/search_async.go
65.38% <50.00%> (-4.43%)
:arrow_down:

inter/ascii_scheme.go
80.00% <0.00%> (-3.18%)
:arrow_down:

cmd/lachesis/params.go
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad65fb7...8dcbd5b. Read the comment docs.


feature (v0.0.2): implementation

Codecov Report

Merging #3 (5115c19) into main (de685ab) will decrease coverage by 5.00%.
The diff coverage is 95.00%.

@@             Coverage Diff             @@
##              main       #3      +/-   ##
===========================================
- Coverage   100.00%   95.00%   -5.00%
===========================================
  Files            1        1
  Lines            2       40      +38
  Branches         0        6       +6
===========================================
+ Hits             2       38      +36
- Misses           0        1       +1
- Partials         0        1       +1

Impacted Files
Coverage Δ

src/case_insensitive_dict/case_insensitive_dict.py
95.00% <95.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de685ab...5115c19. Read the comment docs.


Fix config path in README

The installation steps in README mistakenly instruct to copy config to  /etc/zabbix/zabbix_agentd.d, while in default configuration (at least in Zabbix 5.0), /etc/zabbix/zabbix_agentd.conf.d is used.

Thank you for your interest. But it's not an issue: in official Zabbix ppa the directory is called zabbix_agentd.d, while in Debian repo it's zabbix_agentd.conf.d. The users must choose by themselves.

Thanks, I suspected that it's called zabbix_agentd.d in some versions but didn't know for sure. In this case, it might be a good idea to mention this difference in README.

It's also a bit inconsistent that it says to copy config to zabbix_agent.d and then says to include zabbix_agent.conf.d.

I will try to address that, thanks.


update dependencies

Summary
update dependencies
Description
eslint-config-base 의 dependencies update
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

/canary-publish


build: update several dependencies

This PR updates several dependencies in scylla-tools-java: snakeyaml, Jackson, Snappy. Before the change,
security scanners (such as Trivy) reported that those dependencies were vulnerable to several "HIGH" severity CVEs. Those issues are fixed in newer versions of those libraries and after this PR the security scanner doesn't report any problems related to the updated dependencies.
Fixes #348
Fixes #349
Fixes #350

Unfortunately it looks like there is one problem with updated Snakeyaml dependency, as shown in a failing test in https://github.com/scylladb/scylladb/pull/16009: test_connectivity_with_cassandra_stress. I will investigate and fix it.

v2:

Updated Jackson dependencies to an even higher version (2.15.2 instead of previous 2.13.4). The failing Scylla test has shown that Java Driver also uses Jackson and there was a mismatch of versions between Jackson expected in Java Driver and Jackson in scylla-tools-java. After v2 changes, the versions should match.

I'll rerun Scylla CI with those v2 changes included and I'll update on this issue if they now pass.

Scylla CI passed with scylla-tools-java that contains this PR: https://github.com/scylladb/scylladb/pull/16009#issuecomment-1804466805

@scylladb/scylla-tools-maint please help with review.
There are customers that are waiting for this in order to have a new docker without security vulnerabilities.

scylladb/scylladb@7b08886e8d

@avikivity what's need to be done in order to backport this to older branches?
We need it in 2022.1.

Backport PRs:

https://github.com/scylladb/scylladb/pull/16149
https://github.com/scylladb/scylladb/pull/16150
https://github.com/scylladb/scylladb/pull/16151

@avelanarius please open a backport PR against 2022.1, there are non-trivial conflicts.

Asked @Bouncheck to try doing this backport while @avelanarius is out, we hope to get it merge tomorrow so we can release on Sunday.

Backport PR for 2022.1: https://github.com/scylladb/scylla-enterprise/pull/3620


Support read_sql in koalas

Requesting about read_sql() in koalas that they can do in pandas to read from external database.

It could be worked around as below for now:
kdf = spark.read.jdbc(...).to_koalas()


buid my project

how to build my project for production
create dists

When you launch this in production (NODE_ENV===production) in the first run it bundles all files and stores them in a file, so all consecutive requests read that file.


How to install and use puml-parser-php on Windows-10?

I use

Windows-10.
OpenServer.
I'm starting to learn php.

How do I install and use puml-parser-php on Windows-10?
Do I need to install plantuml?

I created a folder in OpenServer: c:\OpenServer\domains\puml-parser-php.
I opened the console in OpenServer.
I executed the command cd c:\OpenServer\domains\puml-parser-php
I executed the command composer require puml2php/puml-parser
I got folders and files.
vendor\
composer.lock
composer.json
What should I do next?

@it19862
Thanks for using it.

Do I need to install plantuml?

You do not need to INSTALL plantuml for this library.
If your goal is to run plantuml, this library may not be the right application for you. What kind of functionality do you want to implement? :)
Please refer to overview for more information on the use of this library.

I got folders and files.
vendor
composer.lock
composer.json

Assuming your goal is to parse the plantuml file, the next step would be something like this.

Create the plantuml file.

Refer to the sample in Usage

Perform analysis on the plantuml file as follows

 $lexer = new Lexer(PumlTokenizer::newInstance());
 $parser = new Parser($lexer);
 $ast = $parser->parse(__DIR__ . '/sample.puml');

Using the parsed results, implement the functionality you want to achieve


Pre-transform error: Failed to load url /popup.js

Describe the bug
It looks like popup page works as expected, but the console still print Pre-transform error: Failed to load url /popup.js

To Reproduce
https://github.com/yunsii/wxt-reproduction
Steps to reproduce the bug using the reproduction:

Install dependencies: pnpm i
Start dev mode: pnpm dev

Expected behavior
Is it a wrong log print?
Environment
  System:
    OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (16) x64 AMD Ryzen 7 5700G with Radeon Graphics
    Memory: 22.84 GB / 31.35 GB
    Container: Yes
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.4.0 - ~/.nvm/versions/node/v18.4.0/bin/node
    npm: 8.12.1 - ~/.nvm/versions/node/v18.4.0/bin/npm
    pnpm: 8.14.0 - ~/.nvm/versions/node/v18.4.0/bin/pnpm
  Browsers:
    Chrome: 121.0.6167.85
  npmPackages:
    wxt: ^0.16.8 => 0.16.8

Duplicate of #421, closing in favor of it. Thanks for the extra info 👍


Add link to ML.NET tutorial.

Add link to ML.NET tutorial that will be used for the demo.

@sonichi for time, since we know when / where our presentation is taking place, do you want me to update this page with that information?

@sonichi for time, since we know when / where our presentation is taking place, do you want me to update this page with that information?

I like that idea. @qingyun-wu

Done. I also updated some of the headings and added the learning objectives. Feel free to suggest any changes.


Add view only mode

Are there any plans to add a view only mode anyone could join? Right now that seems to be not possible and this was one of the bigger use cases for tmate.

https://github.com/owenthereal/upterm/pull/29?

Must have missed that somehow. Maybe it is missing docs in the right places.


fix: allow dash in deploy github url

👋  There is an error affecting forking repositories that are having a dash in the "group" URL (github.com/some-name/repository). This PR is fixing the PR to allow such names.

fixing https://github.com/cloudflare/workers.cloudflare.com/issues/132
fixing https://github.com/francis-du/url-shortener/issues/15

@eidam Good job~


[FLINK-32863][runtime-web] Improve Flink UI's time precision from sec…

What is the purpose of the change
Improve Flink UI's time precision from second level to millisecond level.
Brief change log
Improve Flink UI's time precision from second level to millisecond level, includes job duration, task duration, task start time, end time.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? not documented

@masteryhx +1 for also adjusting checkpoint precision.

@masteryhx Thank you for your suggestion.  I have adjusted the precision of checkpoint related time.  please review. cc @KarmaGYZ


Add handler scripts & periodic job for upstream image mirroring to ECR

The PR makes the following changes:

add skopeo binary to the docker image
add scripts for mirroring images
add periodic job for mirroring upstream imaeges to ecr

Cleanup:

remove unused boskos.py script

/retest

Resolved all comments & fixed merge conflicts. cc: @rajaskakodkar

Thanks @Priyankasaggu11929! Let's get this in post infra migration.
/hold

Post PR Merge steps:

grab the new tag of the test-image & replace the spec > container > image in the postsubmit-mirror-upstream-images-to-ecr post-submit job.
Make test changes in scripts/mirror-images/source-images.yaml file to trigger the post-submit job.


Too many error files? memorized

Traceback (most recent call last):
File "/usr/local/lib/python3.4/site-packages/newspaper/parsers.py", line 65, in fromstring
cls.doc = lxml.html.fromstring(html)
File "/usr/local/lib/python3.4/site-packages/lxml/html/init.py", line 706, in fromstring
doc = document_fromstring(html, parser=parser, base_url=base_url, **kw)
File "/usr/local/lib/python3.4/site-packages/lxml/html/init.py", line 600, in document_fromstring
value = etree.fromstring(html, parser, **kw)
File "lxml.etree.pyx", line 3032, in lxml.etree.fromstring (src/lxml/lxml.etree.c:68121)
File "parser.pxi", line 1786, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:102470)
File "parser.pxi", line 1667, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:101229)
File "parser.pxi", line 1035, in lxml.etree._BaseParser._parseUnicodeDoc (src/lxml/lxml.etree.c:96139)
File "parser.pxi", line 582, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:91290)
File "parser.pxi", line 683, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:92476)
File "parser.pxi", line 631, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:91904)
File "", line None
lxml.etree.XMLSyntaxError: line 777: b'ID logo already defined'
[Source parse ERR] http://liputan6.com
[Errno 24] Too many open files: '/root/.newspaper_scraper/memoized/liputan6.com.txt' <class 'OSError'> test.py 58
i got an error like this, basically its a simple crawler that crawl within a while: True, too many threads maybe?

I'm getting a lot of these errors as well:
[2015-03-12 00:02:41,640: WARNING/Worker-54] File "parser.pxi", line 582, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:91290)

2015-03-12 00:02:41,640 DEBG 'workers' stderr output:
[2015-03-12 00:02:41,640: WARNING/Worker-54] File "parser.pxi", line 683, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:92476)

2015-03-12 00:02:41,640 DEBG 'workers' stderr output:
[2015-03-12 00:02:41,640: WARNING/Worker-54] File "parser.pxi", line 631, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:91904)

This critical memory leak should have been fixed in: https://github.com/codelucas/newspaper/issues/177


Vectors in 3D don't adjust ArrowTip correctly

For example  vector = Vector((2,2,2)), the arrow tip will only align to the x-y plane which is really frustrating. I think it has to do with the way the tip is repositioned (rotation).
Strangely enough when you initially position the vector in the X-Y plane, then rotate it around a circle, it appears to maintain the correct positioning? I'd imagine something like that would be an adequate fix to it, as right now it's a simple degree rotation which doesn't encapsulate the third dimension.

I remember that problem with Vector. I solved it using this piece of code
myVec=CurvedArrow(start_point=ORIGIN,end_point=(2)*RIGHT+(2)*UP+(2)*OUT,angle=0*DEGREES,color=GOLD_D)
Hope this works for you.

Issue #774  may help you


unnable to connect to the esp

the device goes into the wifi configuration mode is successfully able to connect to my home network but when i enter the url provided in the serial monitor, it is not able to connect to the http server. But is says server is running when i enter the ip address.

To clarify then the IP address works but the more friendly http://device.local doesn't work?

On May 19, 2017, at 07:08, saikhurana<EMAIL_ADDRESS>wrote:
the device goes into the wifi configuration mode is successfully able to connect to my home network but when i enter the url provided in the serial monitor, it is not able to connect to the http server. But is says server is running when i enter the ip address.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

yeah. that's exactly what i am trying to say

That can sometimes be an issue with your router. It's using bonjour/mdns so make sure those services are compatible and enabled
Sent from my iPhone

On May 19, 2017, at 07:19, saikhurana<EMAIL_ADDRESS>wrote:
yeah. that's exactly what i am trying to say
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

can you please help me to find this option. i am not familiar with this networking stuff

Is there any workaround

Using the IP address is a good alternative.
Otherwise I'd need to know your OS and router information
Sent from my iPhone

On May 19, 2017, at 14:00, saikhurana<EMAIL_ADDRESS>wrote:
Is there any workaround
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

i use win10 and i have 2 routers. d-link and a binatone.
d-link DSL-2750U Wireless N 300 ADSL2
Binatone WR1500N

I am fine using the ip address. Can you explain the procedure

how to connect to the ir remote via ip adress. when i type the local ip address of the it, it just says "Server is running"

See the readme for the URL formatting. It's all spelled out very clearly there
Sent from my iPhone

On May 20, 2017, at 13:45, saikhurana<EMAIL_ADDRESS>wrote:
how to connect to the ir remote via ip adress. when i type the local ip address of the it, it just says "Server is running"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

is there a GUI when you use the local host method? is it accessible using the ip address

No there is no GUI accept for the initial wifi setup everything else is handled via URL parameters
Sent from my iPhone

On May 21, 2017, at 06:50, saikhurana<EMAIL_ADDRESS>wrote:
is there a GUI when you use the local host method? is it accessible using the ip address
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Separate Abilities System (With Standardized Animation Sets To Utilize)

https://github.com/SlayHorizon/godot-tiny-mmo-demo/issues/9#issuecomment-2307816286
"...the same animations can be easily shared across all characters without additionnal work."
I'll make a separate issue for separate ability system that calls upon a standardized set of animation so we can be free to use any animation set and have abilities can be used on any entity regardless of animation availability (but we should have a deep animation list to call from to make the best we can for what we have to work with)...
...With Flare the abilities (including attack abilities) were all shared even though the sprites had unique animation sets. So animations can be arbitrary if we have circle hit box abilities that Flare has used for attacks.
I think the logic flow was like this with Flare: ( https://github.com/flareteam/flare-engine )
Input
V
Ability start triggers
V
Ability calls on arbitrary sprite animation(s) to play
V
Finds Mouse / Controller Location on screen
V
Places closest allowable range of Ability X,Y coordinates to on screen location
V
Places the designated ability hit box circle size at X,Y coordinates location
V
Triggers ability effects of the ability with the designated ability hit box circle size at X,Y coordinates location
V
Ability continues for X seconds and or with more conditional effects or ends.
@dorkster Is this sort of close to correct for what Flare uses with its robust ability system?
So if we separate the abilities (including attacks) that trigger arbitrary animations for the affected entities and their sprites we can have the freedom of using any sprite set so long as the animations can be called / triggered by the ability system. We don't have to to worry about hands or not but instead we can look for animation amounts and getting a standard list of animation types to call for x seconds such as (Run / Walk Up, Down, Left, Right or Die, Attack, Cast, Idle, Swim, Climb etc. etc.).
Separate Abilities System is a more robust system that once made can gobble up any animation assets and pretty much all animations can be used efficiently and even if they lack animation type to call; placeholder animation sets can be used with duplicated / close enough approximations to rough out a demo. Such as say some sprite animation set lack a 'cast' animation. For a solution an attack / placeholder animation can be used / copy and paste can called 'cast' etc. this is a popular dev trick / method in bigger games like WoW, Baldur's Gate, Diablo etc.
I am wondering what steps are needed to implement a proper Separate Abilities System like with Flare for this Godot Tiny MMO demo? All thoughts and feedback are welcome. This is really cool and I hope it gets made so there are really great multiplayer dev tools for the community.

That's more or less how Flare works. Although we map the mouse/controller position to our in-game target before the ability triggers.
Also worth noting that the hit circle doesn't exist until the character's animation hits its "active" frames. So, for example, a sword swing will be able to damage the target when the blade appears to visually make contact, rather than when the character is holding their blade above their head. This isn't strictly necessary, but it creates a better cohesion between what the player can and can't see.

That's more or less how Flare works. Although we map the mouse/controller position to our in-game target before the ability triggers.
Also worth noting that the hit circle doesn't exist until the character's animation hits its "active" frames. So, for example, a sword swing will be able to damage the target when the blade appears to visually make contact, rather than when the character is holding their blade above their head. This isn't strictly necessary, but it creates a better cohesion between what the player can and can't see.

That makes sense. I suppose the mouse/controller mapping should be mentioned for its needed for things to work properly. Timing is a good detail for the ability system and that makes sense too.
I really like the options with the timing for making the say for your example the sword swing match / pair with the hit box and the visual data of the sword should be making contact with the target.
Its subtle but it gives lots of depth and organic feedback which is hard to describe but feels really good to the players when it works lol.


[stable/ipfs] fix statefulset api

Is this a new chart
No
What this PR does / why we need it:
Fixes https://github.com/helm/charts/issues/19516
Which issue this PR fixes
https://github.com/helm/charts/issues/19516
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/lgtm


[AngularJS - Leaflet] Invalid data passed to the polyline path

From @cleechtech on March 12, 2014 12:31
I'm trying to draw a path when a user clicks a certain element. In my view I have the directive:
<leaflet
		center="nairobi"
		paths="paths"
		markers="markers"
		defaults="defaults"
		height="600">
	</leaflet>

Then in my controller I fetch the data points and add them to $scope.paths
   // function to draw path on map
    $scope.drawRoute = function(shape_id){
        // get path coordinates
        Route.getCoords(shape_id, function(points){
            var newPath = {
                color:'red',
                weight: 4,
                latlngs: []
            };

            // create array of latlngs
            angular.forEach(points, function(point){
                 // each point looks like this: ["1001", "-1.320547", "36.70583"]
                var coord = {
                    lat: point[1],
                    lng: point[2]
                };
                newPath.latlngs.push(coord);
            });
            var pathName = shape_id;

            // add path to $scope
            $scope.paths[pathName] = newPath;

        }, function(error){
            $scope.routeToDraw  = error;
        });
    };

    // generate map
    angular.extend($scope, {
        nairobi: {
            lat: -1.284381,
            lng: 36.809031,
            zoom: 12
        },
        paths: {
            defaultPath: {
                color: 'red',
                weight: 4,
                latlngs: [
                        { lat: -1.284381, lng: 36.700974 },
                        { lat: -1.31349, lng: 36.699959 },
                        { lat: -1.311739, lng: 36.698589 }
                ],
            }
        },
        markers: {},
        defaults: {
            scrollWheelZoom: false
        }
    });

The defaultPath shows up fine when the page loads, but when I click an element I get an error:
[AngularJS - Leaflet] Invalid data passed to the polyline path angular.js:9383
TypeError: Cannot call method 'on' of undefined

How can I draw a path when a user clicks an element?
Copied from original issue: tombatossals/angular-leaflet-directive#323

From @tombatossals on March 19, 2014 10:31
Hi, please, could you implement the case in a working demo?
You could use this jsfiddle as a start:
http://jsfiddle.net/tombatossals/4PhzC/
Thanks for reporting


10790 prep - Create an experiments/ folder

For #10790
I will need to add 2 experiments-related files, so I figured I'd put all experiment-related files in experiments folders (in client and in test).
This PR consists of:

client/common/experiments.ts ➡ client/common/experiments/manager.ts
client/common/experimentGroups.ts ➡ client/common/experiments/experimentGroups.ts
test/common/experiments.unit.test.ts ➡ test/common/experiments/manager.unit.test.ts

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

DS job failing with

🤷♀


[raycluster controller] Make it clear that reconcilePods does not write to spec

Signed-off-by: Dmitri Gekhtman<EMAIL_ADDRESS>

Why are these changes needed?

Operators generally shouldn't write to the spec of the thing they manage.
I don't think the raycluster controller currently does that, but the logic around workersToDelete kind of makes it look that way.
This PR deep-copies worker group specs in the reconcile pods to make it clear that the spec is not being modified when we process workersToDelete.
Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

Definitely need to think a bit harder here.

Might add to this a method that clears the workersToDelete method following the pattern of the cloneset controller's truncatePodsToDelete method:
https://github.com/openkruise/kruise/blob/a639a6f55721bf2fc5254b0d4499ae94ef9a1851/pkg/controller/cloneset/cloneset_controller.go#L328

Might add to this a method that clears the workersToDelete method following the pattern of the cloneset controller's truncatePodsToDelete method: https://github.com/openkruise/kruise/blob/a639a6f55721bf2fc5254b0d4499ae94ef9a1851/pkg/controller/cloneset/cloneset_controller.go#L328

Eh, I've decided against this for now -- we have enough concerns that I'd prefer for now not to make the code more complicated. It's much simpler and safer to keep the workersToDelete list until the user or autoscaler removes it. The idea is that the operator will continue ensuring that the workersToDelete are gone until the user (or autoscaler) says otherwise.
For consistency with this line of thinking, I will actually modify the autoscaler to clean up workersToDelete when appropriate.
I will open a discussion issue so we can consider automated cleanup later.

Forgot to mention -- the operator does not currently write to spec or clean up workersToDelete.

Forgot to mention -- the operator does not currently write to spec or clean up workersToDelete.

Forgot to mention -- the operator does not currently write to spec or clean up workersToDelete.

Cool. I took a look at raycluster_controller.go, and I found r.Update only be called once. This PR does not change the existing behavior, so the logic makes sense to me.
https://github.com/ray-project/kuberay/blob/60de974b232eabcf8b9bcbd21d8f3c197ae52b20/ray-operator/controllers/ray/raycluster_controller.go#L152-L161

This PR was mostly me thinking out loud. I'm actually going to close this.


[Sample Onboard Request] Word-Add-In-Writing-Assistant

Owner:
xiruatms
ID:
Word-Add-In-Writing-Assistant
Title:
Word-Add-In-Writing-Assistant
Description:
This add-in demonstrates Word add-in capabilities to help users check errors, improve writing, and rephrase content.
Tags:
"JS", "React"
Time:
5mins to run.
Configuration:
"Ready for local debug" .
Thumbnail:
https://github.com/OfficeDev/Office-Samples/blob/main/Word-Add-in-WritingAssistant/assets/thumbnail.png
(Optional) Demo GIF:
https://github.com/OfficeDev/Office-Samples/blob/main/Word-Add-in-WritingAssistant/assets/sampleDemo.gif
(Source code in this Repo) Source Code PR:
Code in another Repo
(Source code NOT in this Repo) Sample URL:
https://github.com/OfficeDev/Office-Samples/blob/main/Word-Add-in-WritingAssistant
(Optional) Minimum Teams Toolkit Version:
Teams Toolkit version requirement to run the sample - minimum version
(Optional) Maximum Teams Toolkit Version:
Teams Toolkit version requirement to run the sample - maximum version

Suggest the following update to this sample README file:

Give a title to this README file.
Do not use name :"M365 Toolkit". Remove keyword: M365. Just use "Teams Toolkit"
The command name keep consistent with screenshot (or update your screenshot):

updated


Allow dry-running without a keypair

resolves #119
Updated aesophia to v3.2.0

I added tests for this; the latter will be introduced in a different PR


Desktop dApp

:tada: This PR is included in version 1.0.0-dev.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Is this just going to replace session stores? If not, what will it replace?

It will replace sessions stores


Implement and test datamodel::validator::UMessage

I'll take this.

Increasing priority to P0 as this is a blocker for the Zenoh transport implementation.
See: Message on SDV Working Group Slack


[Box] Always re-renders sx is changed on the forward ref Div

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Trying to mitigate re-rendering with Box. Normally wrapping in React.memo will do the job for most components
However with Box and Stack they forward their props to a div and so the Box/Stack won't re-render but the div will
causing the area to re-render always as well. Always getting props updated with (children, sx) changes were the sx is
always changing even then the sx value is memoized with useMemo which works on normal components.
const BOX = React.memo((props) => <Box {...props}/>

function MyComponent() {
   const [state, dispatch] = useReducer({input: ''}, (state, action) => ({...state, ...action}))

   const handleChange = useCallback((event) => dispatch({input: event.target.value}), [dispatch])

   const width = useMemo(() => ({minWidth: 120}), [])
   return (
   <>
      <Box>
         <TextField
           label={'input'}
           value={state.input}
           onChange={handleChange}
         />
      </Box>
      <Box sx={width}>
          Hello
      </Box>
   </>
   )
}

Expected behavior 🤔
For the wrapping of Box or Stack with React.memo to not cause re-rendering for that component if their props do not change.
Steps to reproduce 🕹
Steps:

Make a component
have an input or something that changes the components state to cause a component to re-render
have a Box or Stack wrapped with React.memo with a useMemo sx prop
using the React DevTools Profiler run some input changes and pause profile check and see that in fact the Box and Stack re-rendered

Context 🔦
There looks to be an issue with the forward ref for Box and Stack
Wanting to add React.memo to Box/Stack as to not always causing a re-render on these components and their children because of them wrapping their children.
I am not completely sure this is a super big deal but wanted to point it out. Its not that its a huge issue its usually .1 ms for each of these to render but if you have a lot that can be a problem. But was wondering if other components might have this issue.

  Output from `npx @mui/envinfo` goes here.

I am not 100% sure how React.memo does its shallow compare.
It should probably check reference on objects first to do an early bail out, but if that fails it compares the initial keys(?) and then primitive types.
Since you're always passing in a new object in the form of Hello (the child) it will always re-render.
The issue isn't your sx prop.
Try this.
const BOX = React.memo((props) => <Box {...props}/>

function MyComponent() {

  //Assume a far more complex child.
  const child = React.useMemo(() =>  Hello, [])

   const sx = useMemo(() => ({minWidth: 120}), [])
  const BOX = React.memo(() => <Box sx={width} > child </Box>, [sx.minWidth]>

   return (
   <>
      {BOX}
   </>
   )
}

I could be wrong, but try that out and see.


new Color("--acescg").space.coords[i].range does not match coordinates of actual colors

This color.js docs entry illustrates it: https://colorjs.io/docs/spaces#acescg
The range listed for each coordinate is 0 – 65,504.
Yet the color.js picker converts CSS "darkred" to color(--acescg 0.158 0.018 0.005), which is what I see when debugging a test page.
Based on the range values for acescc, -0.36 – 1.47, and the fact that color.js produces the correct display() color in lab(), I assume that it's the range values that are wrong, not the coordinates for the acescg color space.  But this official page says the range is correct:
https://docs.acescentral.com/specifications/acescg/
Is acescg using 0 – 1 as its range for coordinates?  Something is amiss.  I have tried this with a variety of colors and all the coordinates are in the 0 – 1 range.

I don't understand, why do you think the acescg output is wrong? Yes, they do not cap the gamut at SDR white [1, 1, 1], but allow for enormous headroom upt to 65,504, but yes, white will convert to color(--acescg 1 1 1) even if up to 65,504 is allowed.
Here is another source that has implemented ACES: https://acescolorspace.com/rgb. Results match Color.js.

My ignorance on display once again.  As I believe we discussed in another thread I wanted to use the range values to format coordinate values, number of decimals, padding, etc.  0 - 65504 would indicate to me that integer formatting is appropriate, but that's a mistaken assumption.
That sure is a lot of headroom.  Are there displays that can display it?  Or what is the reason for it?
I'll close this issue and make an exception to my formatting rules.  Thanks for the clarification.

Using that docs page's example values:
color = new Color("color(--acescg 25700 9480 20800)")
color.display() outputs lab(2818.6 1907.5 -597.81) which displays as a bright pink on Firefox, wait a minute....
color.display({space:"srgb"}).toString() outputs rgb(100% 100% 100%) which displays as white.
...I try this in the Color.js color picker on Chrome and it displays white, not pink.  So maybe Firefox is messing with my head.
Here is a codepen for lab(2818.6 1907.5 -597.81): https://codepen.io/sidewayss/pen/MWRNMgX
It's hot pink on Firefox and white on Chrome (on my Win11 machine).  Is Firefox nuts, or ahead of its time?  I'm recently reconsidering it as my default browser.
I see that Absolute XYZ D65 is the other color space with a wide range.  I see much less information about that space than acescg on the web.  Is that another space that must be constrained upon display?  Maybe I'll have to experiment some to figure it out...

I just tested on the latest MacOS and iOS versions of Safari via browserstack, and MacOS Safari matches Firefox, while iOS matches Chrome on my Win11 box.

I'm not sure exactly what the question is, but yes, those values are way outside the displayable gamut.

color.display({space:"srgb"}) outputs rgb(100% 100% 100%) which displays as white.

Color.js gamut mapping will set the color to white if lightness exceeds the SDR range.

I see that Absolute XYZ D65 is the other color space with a wide range. I see much less information about that space than acescg on the web. Is that another space that must be constrained upon display? Maybe I'll have to experiment some to figure it out...

Absolute XYZ is just XYZ scaled by the luminance. The selected luminance is arbitrary. So instead of a range of 0 - 1 for XYZ, you may scale it by Yw = 100. In the case of Color.js, they use a Yw of 203 as mentioned in ITU-R BT.2408-3.

Thanks for the Absolute XYZ info.
Putting aside Color.js, https://codepen.io/sidewayss/pen/MWRNMgX on MacOS Safari and Windows Firefox displays lab(2818.6 1907.5 -597.81) as a hot pink color, while iOS Safari and Windows Chrome display it as white.  I am deducing (hopefully correctly) that the pink is the result of gamut mapping, whereas the white is clamping aka clipping.  But the future is with gamut mapping and finding a way to display these colors, right?  Or are they simply two different approaches that will persist into the future?
This was causing me confusion because I couldn't understand how a non-displayable color could display in one space and not in another.  RGB doesn't seem to get gamut mapped on any of the browsers, and maybe not HSL or HWB either.  And I'm still not 100% clear about exactly how a gamut map functions, but there is info online about that - unless there's a specific source you'd recommend.  Seeing a specific example would be very helpful to understanding it, running the numbers.
Is there a way to get the rgb equivalent for the mapped values?  That hot pink color is displaying on my non-HDR monitor, so it's getting mapped into the integer rgb gamut.  The Safari and Firefox pinks look the same, so maybe they're using the same map?  Does Color.js provide those values as rgb or within gamut in the chosen color space?  This assumes a set of common gamut maps.

Absolute XYZ is just XYZ scaled by the luminance. The selected luminance is arbitrary. So instead of a range of 0 - 1 for XYZ, you may scale it by Yw = 100. In the case of Color.js, they use a Yw of 203 as mentioned in ITU-R BT.2408-3.

So instead of 0 - 1, all three ranges would be 0 - 203?  The docs page lists them as:
x 	Xa 	0 – 9,504.7
y 	Ya 	0 – 10,000
z 	Za 	0 – 10,888.3

@sidewayss IIRC, some browsers are always clipping lightness if it exceeds 100% Lab. Some browsers do not. I think this requirement may have been removed from the CSS spec. Anyway, all browsers are clipping in sRGB, but since some auto clamp lightness past 100% at parse time, the clip result will be either magenta or white depending.
So instead of 0 - 1, all three ranges would be 0 - 203? The docs page lists them as:
I belive SDR white is equivalent to whatever the white point is multiplied by 203, so something close to [192.9425531914893,<PHONE_NUMBER>9999997,<PHONE_NUMBER>0425533], but maximum HDR lightness, I think they are multiplying the white by 1000 cd/m2.

So that's "magenta", and any color lightness >100% will display that or white.  I should have tried a few more values in my codepen. I took for granted that the values for acescg in that example represented a valid display color that happened to be magenta.

So that's "magenta", and any color lightness >100% will display that or white.

No, if we are talking about clipping, you only get white if all channels of the RGB color are greater than or equal to 1.
To get magenta, you have to have the red and blue channel greater than or equal to 1 with the green channel very low. You can certainly have colors that cause other channel combinations to be greater than. In this one case, that is how it worked out.

Brief Background on ACES
So, the first ACES color space (AP0) was designed such that it fully encompasses the 1931 CIE chromaticity diagram. It was intended as a space for archival purposes, stored in an EXR 16 bit float file.
The idea was to be able to capture and store any film without concerns for clipping, regardless of future technology changes, providing a robust archival format. But…
In order to enclose the chromaticity inside a three point triangle, imaginary primaries were used. However as you can see from the diagram, the blue primary is negative. This makes AP0 inconvenient to work with as a practical intermediate for VFX or color grading, as a negative primary complicated what would otherwise be very simple math (I.e. for compositing).

So AP1 was created for ACEScg, for use in post production. AP1 still has imaginary primaries, but all are positive, and are still fairly close to the spectral locus. It’s larger than Rec2020/2100, and as with all spaces that use imaginary primaries, it is not possible to create an “ACES display”. 3D Look up tables (3D LUTs) are used to transform to smaller color spaces for viewing.
Side Notes
Linear
When working in a linear (gamma 1.0) space, the math is simple and additive as light is in the real world. Primaries can be somewhat arbitrary, based on the assumptions of Grassmann’s laws, and the area inside the primary coordinates defines the outer limit of the gamut.
CIE RGB and XYZ
CIE RGB also had a negative primary, particularly a problem in 1931 before computers. So they created the transform into XYZ as a useful standard observer space. XYZ still uses imaginary primaries, but none are negative. XYZ transformed to xyY forms the chromaticity diagram above.
Turn a Negative into a Positive…
You may be wondering, if CIE 1931 was derived from color matching experiments by adjusting Red Green Blue primaries to match monochromatic (spectrally pure) colored lights, how could there possibly be a negative or imaginary primaries?
Because for colors that could not be matched using only additive RGB, one of the primary lights was also added to the monochromatic test light. Then, the value of that primary light, as added to the test light, was subtracted from the results of the corresponding primary from the matching RGB values.

Thanks for all the info.  It's not easy to get a solid lay understanding of these color topics.  There are, as the Color.js docs say, dense, print editions available for sale, but not much in the way of higher-level explanations available online.  Maybe "mid-level" is what I'm looking for, "intermediate-level".
The 3D look-up table makes sense to me, as there are 3 coordinates.  I assumed that all gamut mapping was 3D in that sense.  I did a bunch of work programming in and for a multi-dimensional numerical database called Essbase, now owned by Oracle.  It was accompanied by a load of front-end spreadsheets/reports and back-end multi-dimensional tables.  That part I can grasp more quickly than other aspects of color spaces.  That's why I asked for an example in a previous comment in this issue.  It would all make a lot more sense to me if I could run some numbers through a spreadsheet and see the calculations in action.
fyi and fwiw - I will be formatting acescg as 0.000 and xyz-abs-d65 as 000.0.  It's a fixed space font with five characters available for each coordinate.  The 5-char limitation and range-to-format algorithm works well, except in these two cases (and whatever others I haven't fully tested yet).  And with these two changes, coords for visible colors are formatted properly for these two spaces.  If there's no Color.js or DOM error I assume the user text input is a valid CSS/Color.js value, so lab(2818.6 1907.5 -597.81) is valid and will exceed the 5 char limit, but it's also not a displayable color, so I'm ok with that.

@Myndex - thanks for your concern for my interface, but it's not exactly mission critical stuff.  It's one of currently three web pages for testing and demonstrating my js animation library, which for non-CSS-supported spaces uses Color.js to do the animation interpolation.  I'll be posting a link to it in a discussion group here at github/color.js sometime soon...
The user inputs start and end color values the same way as in the Color.js color picker app, as a CSSish string.  Then they select one or two color spaces (you can compare the way two different spaces interpolate the same line between start and end colors).  It displays the start, end, and current coordinates for each space using in a max 5-character format.  I want it to fit in a vertical/portrait mobile screen, thus the limit on the precision of the coordinates.  Underlying, unformatted float values are available via a button that copies the all the animation values by frame to the clipboard in a tab-delimited format so that I can paste them into a spreadsheet to validate them.
So it won't be perfect, but it will certainly be good enough for displayable colors according to CSS, your browser, and Color.js, in that order.  Here's a screenshot of the "controls" part of the page with some surrounding canvas that shows the midpoint of this animation/interpolation between these two colors across a98rgb vs jzczhz:

As for the reading list and other info, I'll take a look at it and hopefully digest it well.  Thanks.

Better yet, here's a screenshot using acescg:

Hi @sidewayss
Ahhh... that's helpful, so it says "lab" are you using LAB values?

That row, with the monitor icon and italics, is the "display" color space, which differs from the selected color space if CSS doesn't support the selected space on your device.  I am letting Color.js decide which display space to use, though Color.protototype.display() takes an object argument for options, so you can specify, for example: color.display{{space:"srgb"}), if you want to force a display space.  See here for Color.js docs on this topic: https://colorjs.io/docs/output#get-a-displayable-css-color-value

...and to be clear, the coordinates displayed in my web page are for the selected color spaces, not the displayed spaces.  I don't display the display values if they differ.  That's a whole other ball of wax that has nothing to do with the animation values or my code because the animation generates the coordinates in the selected space then uses Color.prototype.display() to apply the animation values to the target element's color-related property/attribute.

@Myndex - I just started to read through the Baldwin site (I've visited Lindbloom's site and already understand the math/matrices for conversions to/from all the CSS-supported color spaces).  Baldwin's start page leads with a Josef Albers-like graphic that animates colors via CSS.  I don't assume that there's a lot of interest in animating web page colors, but it's reassuring to see that someone is doing it.  I hope that the extended functionality provided by my upcoming js library is of use to at least a few folks out there.  Otherwise it has still been an educational venture for me.  It extends functionality for more than just colors, but integrating with Color.js (without importing it!) is pretty cool IMO.  We'll see if others agree...  Thanks again for all the info.

@facelessuser - I just stumbled on your ColorAide docs for gamut mapping.  It's the most useful reading I've done on the topic so far, especially starting with the specific mapping methodologies here: https://facelessuser.github.io/coloraide/gamut/#minde-chroma-reduction.
The bisect and "iterate until < JND" method is used in bezier curve calculations too, at least in the web browsers.  Not at all efficient, but it's the only way to animate timing curves in CSS beyond the few named "easeXX" curves.  Devices are getting more powerful all the time, so it matters less going forward.
It's good to see that both ColorAide and CSS/Color.js agree on LCh for gamut mapping, even though they choose a different variant.  I'm used to seeing so much disagreement or at least discord between the browsers regarding color.

The bisect and "iterate until < JND" method is used in bezier curve calculations too

Yeah, bisection is an easy way to approximate things, but as you'll note in the source you linked, bisect for Bezier is only used as a last resort and Newton is used to hopefully converge to an acceptable value without needing bisect, or at least get much closer before bisection is considered.
If a better guess could be initially made, you may even be able to eliminate the bisect. But yeah, I use Newton and fallback to bisect for Bezier as well. https://github.com/facelessuser/coloraide/blob/main/coloraide/easing.py#L67

It's good to see that both ColorAide and CSS/Color.js agree on LCh for gamut mapping, even though they choose a different variant.

Oh, you mean in relation to CIELCh vs OkLCh? If so, keep in mind, I do think OkLCh does a better job and I do make it available as well. I've considered changing the default to OkLCh, though I haven't yet. The only reason I have waffled about it is that even though CIELCh does not do as good a job, it currently performs predictably with more extreme cases while OkLCh breaks down in certain extreme cases. That's not to say CIELCh doesn't have its own issues, just that generally, it seems to give you something you can work with even in most more extreme cases, but it has its own issues as well.

I did mean "CIELCh vs OkLCh".  Even better than you all fully agree.  I wish the browsers could do likewise.
Now I understand in a basic way how gamut mapping is calculated.  But to go back to the start of this thread, the gamut map to display full-spectrum acescg is an entirely different sort of map, right?  I would think that it's just a matrix calculation like converting between any of the current CSS color spaces that are not RGB-restricted.  Or that it would be a straight scaling from 65.504 to 1 within the acescg space.

Now I understand in a basic way how gamut mapping is calculated.

At least when talking about chroma reduction. Some of the browser's concerns are valid, but mainly because they want to process images with the same gamut mapping algorithm. CSS, originally, was concerned more with preserving lightness and hue as there are specific benefits there.

But to go back to the start of this thread, the gamut map to display full-spectrum acescg is an entirely different sort of map, right? I would think that it's just a matrix calculation like converting between any of the current CSS color spaces that are not RGB-restricted. Or that it would be a straight scaling from 65.504 to 1 within the acescg space.

As noted before ACES was originally developed for archival purposes. They allow for absurd ranges of colors to be preserved. The headroom is insane in those spaces. I'm not sure how practical it is to try and display the full range up to 65504. A Rec. 2100 PQ value of [1, 1, 1] comes nowhere close to that limit:
>>> Color('rec2100-pq', [1, 1, 1]).convert('acescg')
color(--acescg 49.261 49.261 49.261 / 1)

When dealing with things like HDR lightness, you start moving into the area of tone mapping and such.
I think it is likely that many perceptual spaces may not even give you reasonable values once pushed to extremes like 65504.

In short, I'm not sure if representing the full range up to 65504 in ACESCG is useful.

In short, I'm not sure if representing the full range up to 65504 in ACESCG is useful.

That puts it in a different perspective.

When dealing with things like HDR lightness, you start moving into the area of tone mapping and such.

So tone mapping would be yet another factor in gamut mapping or an alternate methodology?  Necessary for the Absolute XYZ D65 space and 1000 cd/m2 for maximum HDR lightness mentioned above?

The current CSS gamut algorithm favors preserving lightness and hue, so often any lightness above the SDR max just becomes white, but if the lightness doesn't exceed the max SDR lightness, it will reduce chroma. If the perceptual space can't handle the extreme chroma very well, you'll get whatever it returns.
If you were gamut mapping to an HDR space, you could theoretically allow the max lightness to assume the HDR lightness. If you are going down to an SDR space and you want to preserve the contrast between colors, you need to make some decisions and scale lightness accordingly. Usually, such approaches will take into account the max lightness and min lightness of an image and scale accordingly.
I honestly haven't done much in this area yet. I have no idea exactly what CSS is recommending exactly.

Hi Issac @facelessuser and @sidewayss
Color Counting Conundrum

"...I'm not sure if representing the full range up to 65504 in ACESCG is useful....They allow for absurd ranges of colors to be preserved. The headroom is insane in those spaces. I'm not sure how practical it is to try and display the full range up to 65504..."

Indeed, ACES/ACEScg is not a display space, and not intended as such. The same can be said of ProPhoto and CIEXYZ. ACES spaces use imaginary primaries, and they need to be gamut mapped to a display space for viewing. ACES image channels stored in the EXR format most commonly use 16 bit half float linear (gamma 1.0).
With the potential of 65504 code values per color channel, $RGB-EXR = 281,062,861,144,064$ colors. So yea, more than ever likely to be utilized for a single image as viewed, but also, viewing is not the use case.
Skiing Color Slopes
Because the data is linear, it can be more useful to consider the number of photographic stops available—"number of colors" isn't informative per se. EXR encodes 30 stops with 1024 code values per stop, for each R, G, B channel, plus an additional 10 bonus stops at a lower precision. This is a range greater than that of the human eye, greater than the range of photographic film.
Compare this to 256 codes values per channel for the entire range for 8bit gamma encoded RGB (about 7-ish stops). By comparison, a 12-bit PQ-curve image can be about 28 stops, a 10 bit HLG is considered between 14 and 16 stops, a 10 bit DPX log is considered about 13 stops.
The Ys Have it, the Eyes Not So Much
"All these colors" and working in linear color space is not intended to facilitate viewing, it's intended for intermediate operations.
Visual effects, image compositing operations, archival storage, intermediate image exchange, etc. etc. all make good use of linear floating point color spaces. Color grading and compositing applications typically have working-spaces of 32 bit float per channel, or even 64 bit per channel float.
Sidenotes:
Click here for more on ACES/EXR/Linear

Additional notes to satisfy my prolixity.

See Dis-Play Run
ACES, ACEScg, and EXR are intermediate stage spaces/containers, not distribution/display spaces/containers. The overhead of linear floating point math and huge gamuts with imaginary portions that need gamut mapping to a display space is a terrible choice for delivery. And this goes for ProPhoto as well.
For delivery, sRGB or P3 in a PNG or JPG container are better, with colors already in the intended display space, including the inverse display gamma or TRC, held using Integer values and a limited bit depth.
Why Linear Needs Floating point
The number of bits needed for storing images in a linear color space is substantially higher than needed with a gamma or TRC encoded space, as encoding colors with a transfer curve (like 2.2 gamma or a perceptual curve, whatever) maximizing the available data space by distributing more data to darker colors. This is especially helpful for integer formats.
An advantage of linear (a straight line instead of a curve, i.e. gamma of 1) is that light in the real work behaves in a linear way. But integer formats are not well suited to use with linear. Having color light values encoded in linear has direct applications in compositing, where simple math can be used to add corresponding pixel color values together (additive mode) or multiply, ect, with the advantage that the result naturally emulate light in the real world.
Don't See This
The EXR format itself is a non-view format that can take arbitrary channels—in rendering CGI, it is common to render normals, geometry, lights, textures etc. as separate passes, and EXR can hold them all in a single file.

So does ACES work with standard gamut mapping methods, like MINDE Chroma Reduction?  Or does it have its own special algorithm?

So does ACES work with standard gamut mapping methods, like MINDE Chroma Reduction? Or does it have its own special algorithm?

Yes, it works. It is unlikely that you will need to gamut map to ACES as the allowable ranges are ridiculous. You will often be gamut mapping from ACES to a displayable space. Your mileage will vary with extreme values though. If you are working in ACES within reasonable gamuts, I see no reason why you could not gamut map to a displayable space. Some perceptual spaces will likely break down at extreme values as they are often modeled for the visible spectrum.
As an example, here is the ACES space (max range of [1, 1, 1]) gamut mapped to sRGB. It does fine.

If you had colors beyond ACES limit, I guess the gamut mapping to the ACES gamut could be less accurate or even completely inaccurate only because I don't know any perceptual space that is designed for those ranges. The reality is simply ACES is not a space you gamut to, you often gamut map from it.


arm docker image

Homework

[ ] I looked at nativefier --help and https://github.com/nativefier/nativefier/blob/master/API.md , no existing option fits my needs.
[ ] I searched existing issues, open & closed. Yes, my feature request is new.
[ ] I'm using the latest version available at https://github.com/nativefier/nativefier/releases

Problem statement
A clear and concise description of what the problem is. For example: Nativefier should provide a docker image for the arm architecture. I need it because I am using a M1 Mac.

Alternative solutions
A clear and concise description of workarounds you've considered/tried.

Originally posted by @wingoku in https://github.com/nativefier/nativefier/issues/1089#issuecomment-863230410

Context

Nativefier: (for example: 9.1.0)
Node.js: v16.13.0
Npm: 8.1.0
OS: Linux ubuntu-linux-20-04-desktop 5.4.0-91-generic #102-Ubuntu SMP Fri Nov 5 16:30:45 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux
Is it a regression? If yes, what's the last working / first broken version?
Additional context: (for example: "I'm behind a proxy, with configuration X and protocol Y")

@ronjouch
The docker build fails because wine is not available for arm alpine.
https://pkgs.alpinelinux.org/packages?name=wine&branch=edge
[parallels@fedora nativefier]$ uname -a
Linux fedora 5.11.12-300.fc34.aarch64 #1 SMP Wed Apr 7 16:12:21 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux
[parallels@fedora nativefier]$ sudo docker build -t local/nativefier .
Sending build context to Docker daemon  964.6kB
Step 1/16 : FROM node:12-alpine
12-alpine: Pulling from library/node
be307f383ecc: Pull complete
5f1a4fb2c7eb: Pull complete
303d48716aa7: Pull complete
f5a9282b20ab: Pull complete
Digest: sha256:8fad09b7620b2bc715cbba92e3313c64a797e453f560118576f1740a44584d5d
Status: Downloaded newer image for node:12-alpine
 ---> ce1b097ce235
Step 2/16 : LABEL description="Alpine image to build Nativefier apps"
 ---> Running in 9267a836a8cc
Removing intermediate container 9267a836a8cc
 ---> 442e7c066761
Step 3/16 : RUN apk update     && apk add bash wine imagemagick dos2unix     && rm -rf /var/cache/apk/*     && mkdir /nativefier && chown node:node /nativefier
 ---> Running in 808b3accfb0b
fetch https://dl-cdn.alpinelinux.org/alpine/v3.14/main/aarch64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.14/community/aarch64/APKINDEX.tar.gz
v3.14.3-71-gffbd3325d6 [https://dl-cdn.alpinelinux.org/alpine/v3.14/main]
v3.14.3-73-g89aa18397a [https://dl-cdn.alpinelinux.org/alpine/v3.14/community]
OK: 14815 distinct packages available
  wine (no such package):
ERROR: unable to select packages:
    required by: world[wine]
The command '/bin/sh -c apk update     && apk add bash wine imagemagick dos2unix     && rm -rf /var/cache/apk/*     && mkdir /nativefier && chown node:node /nativefier' returned a non-zero code: 1

By removing wine I got it to build on arm linux.
We also might want to provide different versions of the docker image for different platforms so someone only building apps for Linux doesn't need wine or the cached windows or mac electron binaries and someone building apps for windoes and linux doesn't need the cached mac binaries.
Linux arm version:
https://github.com/users/mattruzzi/packages/container/package/nativefier-arm

By removing wine I got it to build on arm linux.
We also might want to provide different versions of the docker image for different platforms so someone only building apps for Linux doesn't need wine or the cached windows or mac electron binaries and someone building apps for windoes and linux doesn't need the cached mac binaries.

Getting image source signatures
Copying blob be9b379f7fa3 skipped: already exists
Copying blob 4f4fb700ef54 skipped: already exists
Copying blob 3b8a9bc999d9 skipped: already exists
Copying blob ddad3d7c1e96 skipped: already exists
Copying blob b43f1e92cdca skipped: already exists
Copying blob f495dd034101 skipped: already exists
Copying blob 059fd9d9b04e skipped: already exists
Copying blob 3203efd4e40d skipped: already exists
Copying blob a77670c69a75 skipped: already exists
Copying blob 8bb195d94de4 skipped: already exists
Copying blob 491f01aec217 skipped: already exists
Copying blob 4f4fb700ef54 skipped: already exists
Copying config 53b5cb2696 done
Writing manifest to image destination
Storing signatures
53b5cb2696738ca6e479f88d51bc0302d4f2f31864663ee37fb75a24d2919b2b

That said, it won't run...
$ podman run --rm -v ./:/home/ nativefier/nativefier ...
Error: executable file `nativefier` not found in $PATH: No such file or directory: OCI runtime attempted to invoke a command that was not found

I haven't tried your version @mattruzzi, but I intend to later.

@ronjouch I am working on a ci script to create and publish an arm docker image with CircleCi.
https://github.com/mattruzzi/nativefier/blob/circleci-project-setup/.circleci/config.yml

I recommend upgrading the README for now to enforce the architecture:
docker build -t local/nativefier --platform=linux/amd64 .

This will allow folks on machine with an Apple CPU to build the amd64 container.


Adding setter to Application.DataTemplates

Allowing IoC containers to inject value into property.

If we're going to do this here, we should also do it on Control. In addition, being able to set it only once feels like a hack.
Before we move forward on this, could you explain why you need an IoC container to inject values into Application.DataTemplates? I've never come across such a thing being done? As far as I'm aware this wouldn't be supported in WPF/UWP either, right?

In WPF you can always add a merged dictionary to the application resources. All my applications register templates that way and it is working fine. Why isn't Application.DataTemplates internal? What is the usecase of that property? How are resources (Data Template's) resolved?

Why isn't Application.DataTemplates internal? What is the usecase of that property?

Sorry, not sure I understand. How would you add data templates if it was made internal?

What is the usecase of that property?

It's used for adding application-wide data templates.

How are resources (Data Template's) resolved?

They are searched in the DataTemplates property of each control and then in Application.DataTemplates.
Are you asking why DataTemplates aren't looked up in Resources like in WPF? That's because Resources is an unordered bag of key/values. WPF doesn't allow applying DataTemplates to interfaces, but I wanted to allow that (it's something I miss in WPF) but to do that you need ordering, because otherwise the interface that is matched will depend on the non-deterministic order that data templates are retrieved from the resources.

The problem with making things like DataTemplates settable is that the DataTemplates class is an AvaloniaList<> which implements INotifyCollectionChanged. Which means that if someone subscribes to collection changed notifications on it, and then it's changed they will stop receiving changed notifications.
Now that may not be a big problem in practise, I'm not sure - but it feels likely that it will bite someone at some point, and feels like bad practise. So I'd like to understand why making DataTemplates settable is required, and whether we could come up with another solution that doesn't have the same potential problem

I think there should be some way to add and remove a collection of templates in a elegant way like you can do with MergedResourceDictionary.
You can alway have your own collection of templates and add remove them from DataTemplates but that would produce notification event if you don't do it properly.
We don't need a setter for that scenario.

@amkherad please could you explain what you are trying to achieve, are you trying to add templates from a dynamically loaded assembly (plugin) or something like that? If we know what you want to do from a higher level there might already be a better way to do it.

What is the benefit of replacing DataTemplates with your own instance instead of just adding values to the existing one?

I'm going to close this as there's been no further discussion and I'm not convinced by the approach here. Thanks for the PR anyway, and feel free to reply if you think we should continue along this path.


Added safe deserialization impl

@ewencp Please review.

I don't see a reason this change should break anything, but just in case I kicked of the Connect system tests against this branch here.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6265/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6249/
Test PASSed (JDK 8 and Scala 2.12).

Blacklisting is a poor defense against known and unknown abuses of class constructors.  I apologize for criticizing without offering a better fix.  I see newer JDKs come with a programmatic object input filter configuration, as well as with a run-time java.security configuration, both of which were requested by JEP 290.
https://docs.oracle.com/javase/10/core/serialization-filtering1.htm
Is it possible to have a sensible white list in Kafka?  I know very little about it, sorry.


Upload Privacy Policy

Apple says "Starting May 1, 2024: You'll need to include approved reasons for the listed APIs used by your app's code to upload a new or updated app to App Store Connect."
Please add privacy policy so we can use this library
https://developer.apple.com/support/third-party-SDK-requirements/

It should be done by https://github.com/onevcat/Kingfisher/releases/tag/7.10.0


Update examples

What does this PR do?

Update examples according to https://github.com/huggingface/transformers/pull/28422/files.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


[REFACTORING] Longhorn Backup refactoring

While working on the csi snapshot support #304 I noticed more and more issues with our current backup interaction patterns.
As part of that work, I started looking into the addition of a VolumeBackup crd, that would be exported to the backupstore
with the actual backup metadata. This would allow us to add a backup-sync controller that would keep the local cluster state in
sync with the backupstore state, from that point onwards all the backup interaction would be happening declaratively via the VolumeBackup custom resource.
This would add a persistence layer to the backup operations and would solve issues like the below:

https://github.com/longhorn/longhorn/issues/1249
https://github.com/longhorn/longhorn/issues/1311

Together with the backup-sync controller it would be very easy to support multiple backup targets by introducing a BackupTarget crd. Which would allow for user defined backup strategies for example:
(daily -> Target A, weekly -> Target B, monthly -> Target C)
At the same time, this would allow for the removal of all Backup information from the Longhorn Volume custom resource.
Which should make the volume-controller and other controller logic more simple and straightforward. currently, there are a lot of updates to the Volume resource anytime a new block gets written the volume status would be updated, etc.
Which means the volume-controller needs to process the whole volume object again.

https://github.com/longhorn/longhorn/issues/844

For user experience, we also need to make sure all events/status of backup should be tracked, and users can understand what's the status of backups. ref: https://github.com/longhorn/longhorn/issues/627

I started writing some code for this while working on the csi snapshotter implementation, before realizing that this effort would risk the 1.1 release timeline. Therefore I moved this out of scope of the csi snapshot #304 implementation. So that we can prioritize separately, for 1.2 the roadmap currently includes application backups, so that might be a good time to continue work on this.
There seems to have been a poc of something like this previously https://github.com/longhorn/longhorn/issues/945
Need to sync up about the results of that POC.

Together with the backup-sync controller it would be very easy to support multiple backup targets by introducing a BackupTarget crd. Which would allow for user defined backup strategies for example:
(daily -> Target A, weekly -> Target B, monthly -> Target C)

Nice! I had the same idea when designing the VolumeBackup CRD.

This will be actually tackled in https://github.com/longhorn/longhorn/issues/2543.

@jenting Please reference related issues here, then continue the asynchronous backup here.

Current status:

[x] LEP PR prepare
[x] Code

[x] Pull the remote backup store

[x] Create BackupTarget CRD & implement the backup_target_controller
[x] Create BackupVolume CRD & implement the backup_volume_controller
[x] Create Backup CRD & implement the backup_controller

[x] Delete backup volume or backup in cluster

[x] Reconcile delete BackupVolume CR & remote backup volume in backup volume controller
[x] Reconcile delete Backup CR & remote backup in backup controller

TODO:

[ ] Code

[ ] snapshot back creation & reconcile in backup controller

Current status:

[x] LEP PR ready
[x] Code

[x] Pull the remote backup store

[x] Create BackupTarget CRD & implement the backup_target_controller
[x] Create BackupVolume CRD & implement the backup_volume_controller
[x] Create Backup CRD & implement the backup_controller

[x] Delete backup volume or backup in cluster

[x] Reconcile delete BackupVolume CR & remote backup volume in backup volume controller
[x] Reconcile delete Backup CR & remote backup in backup controller
[x] snapshot back creation & reconcile in backup controller

TODO:

[ ] Longhorn integration test
[ ] Fix

[ ] https://github.com/longhorn/longhorn/issues/627#issuecomment-869324153
[ ] https://github.com/longhorn/longhorn/issues/1249
[ ] https://github.com/longhorn/longhorn/issues/1311

Current status:

[x] LEP PR ready
[x] Code

[x] Pull the remote backup store

[x] Create BackupTarget CRD & implement the backup_target_controller
[x] Create BackupVolume CRD & implement the backup_volume_controller
[x] Create Backup CRD & implement the backup_controller

[x] Delete backup volume or backup in cluster

[x] Reconcile delete BackupVolume CR & remote backup volume in backup volume controller
[x] Reconcile delete Backup CR & remote backup in backup controller
[x] snapshot back creation & reconcile in backup controller

[x] Longhorn Integration Test

The following items depend on Longhorn backup refactoring. I'd prefer to fix it after the backup refactoring code merged.

[ ] Bug Fix

[ ] https://github.com/longhorn/longhorn/issues/627#issuecomment-869324153
[ ] https://github.com/longhorn/longhorn/issues/1249
[ ] https://github.com/longhorn/longhorn/issues/1311

[ ] Enhancement

[ ] https://github.com/longhorn/longhorn/issues/844

Wait for the frontend to add WebSocket notification when the backup target is unavaiable if the user clicks create backup or clicks Backup page.
QA could test this first with a valid backup target.

Verified with Longhorn v1.2.0-rc1
Validation - Partially Pass
Scenarios tested:

Backup of single/multiple volumes and restore - Passed
Interruption in the backups - Failed
DR volumes - Passed
Backup with backing image - Passed
Uninstallation of a set up with lots of backups in backup store. Failed
Clearing of the backups crd - Passed
Switching between the backup targets. - Failed

Failed test cases are tracked with below:

https://github.com/longhorn/longhorn/issues/2915
https://github.com/longhorn/longhorn/issues/2913
https://github.com/longhorn/longhorn/issues/2912
https://github.com/longhorn/longhorn/issues/2910

Thanks @khushboo-rancher well done. For remaining open issues planned in 1.2.1.


Replace "Secret Recovery Phrase" with "Secret Recovery Words"

Some wallets use "phrase" and others use "words".
It's not really a phrase, but a collection of words. I suggest we continue to use "Secret", to inform users specifically that this is a secret. Second is "Recovery", which explain that this is needed to recover their wallet. "Words" explains what it is.

Recovery Phrase

Why you choose that? Just collecting pros and cons =)

I have check with Google search results and we most definitively want to continue to use "Secret Recovery Phrase" / SRP.


add k_spin_lock() to doxygen prior to v3.0 release

Describe the bug
It seems that k_spin_lock() and friends are not getting linked in to documentation at https://docs.zephyrproject.org .
Please also mention any information which could help others to understand
the problem you're facing:

What target platform are you using? Any web browser
What have you tried to diagnose or workaround this issue? briefly chatted about in Discord / discussed in release meeting

To Reproduce

visit https://docs.zephyrproject.org/latest/reference/kernel/smp/smp.html
try to click on k_spin_lock()

Expected behavior
Should be brought to the Doxygen for k_spin_lock(), etc.
Impact
Spin Locks are fairly important in the Zephyr API, so I would say impact is significant.
Logs and console output
Environment (please complete the following information):

OS: N/A
Toolchain: N/A
Commit SHA or Version used: 84fd7f35d523d1f841ba955b5ddf93aca3e0210c

Additional context

link is also broken in v2.7.0, v2.6.0, v2.5.0, ..


Has the blog on the official ecarts website been cancelled？

This issue is not created by echarts-issue-helper and will be soon closed.

Yes, it has been removed from the website.


Improved description of Meeting Signing Teams App Sample

@aosolis @eoinobrien @Wajeed-msft can you please review the latest changes in the description of the readme file https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/309/commits/2771361b0c155bec89ecd8445e35a1812d42c027 so we can share more broadly? We added more functional description (scenarios, personas). Thanks


Update http://hieroglyph.io/ to contain Release 1.0 docs

Quick request, I would like to share http://hieroglyph.io/ with my team members, but the website PDF downloads as: Release 0.8.dev0 documentation
Can I ask that http://hieroglyph.io/ be configured for the recent Release 1.0 please.

It's a little embarrassing how long this issue was open, but I've:

updated hieroglyph.io
configured the github integration to keep it up to date automatically going forward

Thanks for reporting.


fix(docs): preferred typo

Summary

Fix a typo in docs.

Thanks for pointing that out. I've opened a new PR to address this https://github.com/biomejs/biome/pull/3730.


AutoMountTeamSites does not work for main site.

[Enter feedback here]
Hi there,
I was able to configure this setting and it runs correctly when the sharepoint library is not the default one.
To ilustrate that i have 2 document libraries (identical) but one sits at the default sharepoint site and the other at another site i created (Dev)
both deployed using the **Copy library ID **
i can see both at the registry
only the one where the library ID url contains /sites/Dev
webUrl=https://mydomain.sharepoint.com/sites/Dev&version=1
webUrl=https://mydomain.sharepoint.com&version=1
Can that be confirmed?
Thanks
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 04ad2f16-c861-7a1b-5c1d-e4601e8f3855
Version Independent ID: c47df4cd-f706-d807-5eac-172fba1e500f
Content: Use OneDrive policies to control sync settings - OneDrive
Content Source: OneDrive/use-group-policy.md
Service: one-drive
GitHub Login: @adeejoseph
Microsoft Alias: adjoseph

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

I can replicate that behaviour accross multiple tenants. Its not a (one tenant) kind of issue.


Feat: Polkadot v1.12 to v1.14 upgrade

Description
This PR is upgrading Runtime's and Node's dependencies from Polkadot-SDK release v1.12.0 to 1.14.0
Notes
Relevant upgrade's notes and comments.

Integrate builder fn in chain spec file.

Potential Breaking changes

[https://github.com/paritytech/polkadot-sdk/pull/4831]: treasury pallet: - remove unused config parameters
[https://github.com/paritytech/polkadot-sdk/pull/4596]: Frame: Consideration trait generic over Footprint and handles zero cost
[https://github.com/paritytech/polkadot-sdk/pull/3828]: [FRAME] Remove storage migration type
[https://github.com/paritytech/polkadot-sdk/pull/3820]: Remove deprecated calls from treasury pallet
[https://github.com/paritytech/polkadot-sdk/pull/4769]: Use real rust type for pallet alias in runtime macro

Kindly refer to the official Polkadot release report for further details: Polkadot v1.14.0

Polkadot release analysis: Polkadot v1.14.0 analysis

Process

[x] Bump workspace dependencies
[x] Fix issues
[x] Bump spec_ver for both testnet and mainnet Runtime.
[x] Bump node version if there were changes in the node. TBD

Codebase Upgrade Acceptance Criteria

[x] cargo check passes
[x] cargo test passes
[x] cargo build on -- release profile correctly builds
[x] try-runtime and runtime-benchmarks features compile
[x] Single node spinned up from binary works and generates blocks
[x] Zombienet network with 2 peers spawned with block-production config file generates blocks.

Runtime & Node Upgrade Acceptance Criteria

[x] Runtime upgrade works on Zombienet

[x] Node upgrade works on Zombienet

[x] Runtime upgrade works on Chopsticks

[x] Testnet
[x] Mainnet

[ ] Try-runtime passes with no pending migrations

[ ] Testnet
[ ] Mainnet

<!--- PR TEMPLATE CONTENT STARTS HERE -->
Types of Changes
Please select the branch type you are merging and fill in the relevant template.
<!--- Check the following box with an x if the following applies: -->

[ ] Hotfix
[ ] Release
[x] Fix or Feature

Fix or Feature
<!--- Check the following box with an x if the following applies: -->
Types of Changes
<!--- What types of changes does your code introduce? -->

[ ] Tech Debt (Code improvements)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Dependency upgrade (A change in substrate or any 3rd party crate version)

Migrations and Hooks
<!--- Check the following box with an x if the following applies: -->

[ ] This change requires a runtime migration.
[ ] Modifies on_initialize
[ ] Modifies on_finalize

Checklist for Fix or Feature
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->

[x] Change has been tested locally.
[ ] Change adds / updates tests if applicable.
[ ] Changelog doc updated.
[x] spec_version has been incremented.
[ ] network-relayer's events have been updated according to the blockchain events if applicable.
[ ] All CI checks have been passed successfully

Checklist for Hotfix
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->

[ ] Change has been deployed to Testnet.
[ ] Change has been tested in Testnet.
[ ] Changelog has been updated.
[ ] Crate version has been updated.
[ ] spec_version has been incremented.
[ ] Transaction version has been updated if required.
[ ] Pull Request to dev has been created.
[ ] Pull Request to staging has been created.
[ ] network-relayer's events have been updated according to the blockchain events if applicable.
[ ] All CI checks have been passed successfully

Checklist for Release
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->

[ ] Change has been deployed to Devnet.
[ ] Change has been tested in Devnet.
[ ] Change has been deployed to Qanet.
[ ] Change has been tested in Qanet.
[ ] Change has been deployed to Testnet.
[ ] Change has been tested in Testnet.
[ ] Changelog has been updated.
[ ] Crate version has been updated.
[ ] Spec version has been updated.
[ ] Transaction version has been updated if required.
[ ] All CI checks have been passed successfully

@Aideepakchaudhary
Please update MaxFreezes value according to https://github.com/paritytech/polkadot-sdk/pull/4615

@ayushmishra2005, we have addressed these changes here: https://github.com/Cerebellum-Network/blockchain-node/pull/460/commits/24faec1ff31c489643c14230fbc84e4f525af53a#diff-83841a9417ec6fb5ef0c00086b5af82c0b0cd8f83708e97a0c7a5f5d179757f3L451


feat: Added switch to set variable as secret

Adds a switch to set a variable as a secret.
Closes https://github.com/arcus-azure/arcus.scripting/issues/379

Looking at the code and testing the currently released version, it does not seem that this task worked correctly...
I changed Write-Host "#vso[task.setvariable variable=$Name] $Value" to Write-Host "##vso[task.setvariable variable=$Name] $Value". Note the extra #, otherwise the variable is not stored in the pipeline.


feat(gitpod): Automating GitHub Token and Handle Retrieval for GitPod

Now that the tool requires a GitHub token and handle to function properly, it's time to automate the retrieval of this data for GitPod. This PR aims to achieve that goal.
GitPod creates a temporary GitHub token and allows us to use the GitHub API to find the current GitHub handle linked to the GitPod user. We then populate the necessary environment variables with the data found in GitPod.
However, users still have the flexibility to change these values if needed. To inform users about this process, I've added the following messages:
Hello Bruno Verachten 👋

This tool needs a GitHub token to work.
GitPod created a temporary GitHub token for you: gho_c6OU8hxH9Ma6aDSWE3SvOLFXclsxHu1ZNZEg
We stored it in the GH_TOKEN environment variable.
If you want to use a different token, please set it in the GH_TOKEN environment variable.
If you want to know more about GitHub tokens, please visit https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens

This tool also needs a GitHub handle to clone and fork plugin repositories
We stored "gounthar" in the GH_OWNER environment variable.
If you want to use another GitHub handle, please set the GH_OWNER variable accordingly.

As a gentle reminder, we have already cloned two Jenkins plugin repositories: badge-plugin and build-timestamp-plugin.
You could, though, use other plugin repositories as well (like plot-plugin) by entering their name in the following java command.

You can now proceed with the modernizer tool thanks to the following commands:
java -jar plugin-modernizer-cli/target/jenkins-plugin-modernizer-999999-SNAPSHOT.jar --plugins badge-plugin,build-timestamp-plugin --recipes AddPluginsBom,AddCodeOwner

By the way, you can copy/paste from/to the terminal to execute the commands. Enjoy! 🚀
See https://www.gitpod.io/docs/configure/user-settings/browser-settings#browser-settings to know more.

These changes will streamline the setup process for users while still allowing for customization if needed.
Submitter checklist

[X] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[X] Ensure that the pull request title represents the desired changelog entry
[X] Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Works great! Thanks very much.


[Bug]: REPORT 08: ALL CITIES IN A CONTINENT; format issue

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Name
Bobby Walters
Description of the bug?
Output columns need formatting in All CAPS
Version
Develop Branch
Steps to Reproduce the Error
Enter Continent
africa
 All Cities In Continent: africa

City                                Country                                  District                       Population
Cairo                               Egypt                                    Kairo                          6789479
Kinshasa                            Congo, The Democratic Republic of the    Kinshasa                       5064000
Alexandria                          Egypt                                    Aleksandria                    3328196

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Updated in BigFix


Allow manually sending message with $this->messenger()->send()

Closes #13.

it's seem ok, thank you very much !


Adding support for templating languages?

Which version of the plugin are you using?
[X] Data Populator for Sketch
[ ] Data Populator for Adobe XD
Although it is simple and intuitive to use a flat object in JSON for populating the fields, there are some use cases where it might be helpful to use a templating language like Liquid. For instance, if we want to use loops and arrays.
Do you have any thoughts on how feasible it would be to add something like this?

@Simon-Tang we have no plans to add something like this and have not yet looked into feasibility. Maybe yourself, or developers you know might be interested in contributing the feature?


gobuster length filter

I am using gobuster and here is a question I did not found the answer.
It is how to filter the length of response.
This is the Error:
Error: the server returns a status code that matches the provided options for non existing urls. xxx => 200 (Length: 725). To continue please exclude the status code, the length or use the --wildcard switch
I need to find a dir which http status is 200 and length is not 725 . It seems that gobuster only support to filter the http status .Pls tell me it that how can I type the command if gobuster support length filter.
Thank you very much .

-s 200 -b "" --exclude-length 725 on the dev branch


Remove freeze of defaults, add warning for array/hash constant defaults

Relies on https://github.com/chef/mixlib-log/pull/10

I'm guessing there was some internal discussion about this that would be good to know as context?

@coderanger yeah, the issue is it showed up in another cookbook (this one using set_or_return directly). Much as I really want to simply fix the issue for everyone, I'm starting to worry that it will cause enough breaks that it will become an upgrade blocker for people. ("Please upgrade the cookbooks you depend on and restart your whole process.").  Upgrade blockers = less adoption, and dot releases aren't supposed to do that (much).

That is fair. I'll leave it in Poise as that is opt-in so it should be safe and we can put reverting this on the Chef 13 checklist?

@coderanger Sounds good! I've removed the warn_once functionality until we get mixlib-log worked out; you mind C/Ring it?
This should be less chatty than some warnings due to the fact that it happens on declaration rather than on use.

:+1: shouldn't block 12.5 on the warn_once stuffs.

Would you say that freezing defaults should be on the slate for 13? I can add it to the list :)

Yeah. It's in the RFC. I think we need to be a little more proactive about fixing cookbooks--like, add a rule to foodcritic or something. It would suck if 13 required an upgrade of all cookbooks everywhere rather than being mostly compat.


[Bug]: Doraemon_Jump Game No need of Reset button

Give a brief about the bug ✍
Description
In Doremon Jump There is reset button which is not needed as to play again and on pressing it , does not work also.

Hey @jaydeep099 , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#4241

Hey @jaydeep099 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @jaydeep099 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

@kunjgit Please check the pull request

/assign


Update Deployments.md

add contract

merged! thanks 🤙
Check out our step-by-step tutorials to learn more about zkSync


How to static link libplctag for windows ?

How to static link libplctag for windows ?
Thanks!

please refer to https://github.com/Joylei/plctag-rs/tree/master/crates/sys#static-build

@Joylei  Thanks , I compile in windows(powershell) ,
$env:PLCTAG_STATIC="yes"
cargo build --release

run the build application , error for not find plctag.dll
Can you explain more detail  ?
Thanks!

set PLCTAG_STATIC to one of "1", "true", "on"

@Joylei Thanks! It works!


SIBABRT while running the optimized tests under ubuntu 16.04

Hi,
I was very interested in trying this out, so I've followed the steps in the readme and got the tests to compile with a libc++ that I've compiled from llvm.
Then I tried running: build/linux_x64_clang5.0_optimised/test/run which caught a segfault and printed:
*** Error in `build/linux_x64_clang5.0_optimised/test/run': munmap_chunk(): invalid pointer: 0x00007ffe92d2ff78 ***

Seeing as this is probably some libc assert I ran it under gdb to get a better stack trace:
#0  0x00007ffff775b428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007ffff775d02a in __GI_abort () at abort.c:89
#2  0x00007ffff779d7ea in __libc_message (do_abort=do_abort@entry=2, fmt=fmt@entry=0x7ffff78b6e98 "*** Error in `%s': %s: 0x%s ***\n") at ../sysdeps/posix/libc_fatal.c:175
#3  0x00007ffff77aa698 in malloc_printerr (ar_ptr=0x0, ptr=<optimized out>, str=0x7ffff78b6ec0 "munmap_chunk(): invalid pointer", action=<optimized out>) at malloc.c:5006
#4  munmap_chunk (p=<optimized out>) at malloc.c:2842
#5  __GI___libc_free (mem=<optimized out>) at malloc.c:2963
#6  0x000000000027eb1a in std::experimental::coroutines_v1::coroutine_handle<void>::resume (this=0x8) at /usr/opt/llvm/include/c++/v1/experimental/coroutine:123
#7  cppcoro::single_consumer_event::set (this=0x0) at ./include/cppcoro/single_consumer_event.hpp:55
#8  _DOCTEST_ANON_FUNC_18()::$_15::operator()() const (this=<optimized out>) at test/shared_task_tests.cpp:215
#9  0x000000000027e01f in cppcoro::when_all_ready<cppcoro::task<void>, cppcoro::task<void> > (tasks=..., tasks=...) at /usr/opt/llvm/include/c++/v1/experimental/coroutine:123
#10 0x00000000002a4c0f in cppcoro::sync_wait<cppcoro::task<std::__1::tuple<cppcoro::task<void>, cppcoro::task<void> > > > (task=<optimized out>)
    at /usr/opt/llvm/include/c++/v1/experimental/coroutine:123
#11 0x000000000027d825 in _DOCTEST_ANON_FUNC_18 () at test/shared_task_tests.cpp:203
#12 0x000000000023d76a in doctest::Context::run (this=0x7fffffffdde8) at test/doctest/doctest.h:5641
#13 0x000000000023ea1e in main (argc=1, argv=0x7fffffffdee8) at test/doctest/doctest.h:5749

Which might suggest that __builtin_coro_resume is misbehaving, but I'm not sure as I'm still new to these additions.
clang-5.0 --version:
clang version 5.0.1-svn314893-1~exp1 (branches/release_50)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

Hope this is helpful, if I've missed anything let me know.

Hm, apparently it's already known: https://github.com/lewissbaker/cppcoro/issues/57
My bad. Closing.


Update the NMT dependency to latest master

Description
ref: https://github.com/lazyledger/lazyledger-core/issues/128#issuecomment-757082607
ref: https://github.com/lazyledger/nmt/pull/14

Codecov Report

Merging #130 (aa82b38) into master (0332760) will increase coverage by 0.07%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   60.33%   60.41%   +0.07%
==========================================
  Files         262      262
  Lines       23888    23888
==========================================
+ Hits        14414    14431      +17
+ Misses       7979     7959      -20
- Partials     1495     1498       +3

Impacted Files
Coverage Δ

types/shares.go
95.55% <ø> (ø)

types/block.go
77.97% <54.54%> (-0.29%)
:arrow_down:

libs/events/events.go
92.94% <0.00%> (-5.89%)
:arrow_down:

types/tx.go
81.13% <0.00%> (-3.78%)
:arrow_down:

statesync/syncer.go
78.96% <0.00%> (-0.80%)
:arrow_down:

blockchain/v0/pool.go
79.84% <0.00%> (-0.77%)
:arrow_down:

mempool/reactor.go
84.09% <0.00%> (-0.76%)
:arrow_down:

p2p/pex/pex_reactor.go
78.27% <0.00%> (-0.60%)
:arrow_down:

consensus/state.go
68.49% <0.00%> (ø)

proxy/multi_app_conn.go
48.05% <0.00%> (ø)

... and 3 more

Codecov Report

Merging #130 (aa82b38) into master (0332760) will increase coverage by 0.07%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   60.33%   60.41%   +0.07%
==========================================
  Files         262      262
  Lines       23888    23888
==========================================
+ Hits        14414    14431      +17
+ Misses       7979     7959      -20
- Partials     1495     1498       +3

Impacted Files
Coverage Δ

types/shares.go
95.55% <ø> (ø)

types/block.go
77.97% <54.54%> (-0.29%)
:arrow_down:

libs/events/events.go
92.94% <0.00%> (-5.89%)
:arrow_down:

types/tx.go
81.13% <0.00%> (-3.78%)
:arrow_down:

statesync/syncer.go
78.96% <0.00%> (-0.80%)
:arrow_down:

blockchain/v0/pool.go
79.84% <0.00%> (-0.77%)
:arrow_down:

mempool/reactor.go
84.09% <0.00%> (-0.76%)
:arrow_down:

p2p/pex/pex_reactor.go
78.27% <0.00%> (-0.60%)
:arrow_down:

consensus/state.go
68.49% <0.00%> (ø)

proxy/multi_app_conn.go
48.05% <0.00%> (ø)

... and 3 more


Task List Manager mini project stable version.

Task List Manager mini project stable version.
Features - Add , delete and filter tasks in a task list. Local storage is used to keep and track records of each

Hey @mihinduranasinghe , The app is really amazing, but there is a little bug there!
your app shows a weird behaviour on entering blank space character "  " as the name of the task.
Please look out to this.
Thank You! 😄

Thank you. I will look into that


identifierCodec and stringCodec in TagKey → codec and hashPrefixCodec

Both current names are confusing because both codecs serialize an identifier to a string.

Since the unprefixed codec is deprecated, could these two fields be named unprefixedCodec and codec respectively instead?

Since the unprefixed codec is deprecated, could these two fields be named unprefixedCodec and codec respectively instead?

How is it deprecated? I can't find the @Deprecated annotation.

The unprefixed codec is deprecated in data packs. When registry entry lists were introduced, Mojang has said that fields accepting unprefixed tag keys would be replaced with fields accepting registry entry lists instead.


DM: query-status returns empty information when task-mode is full and has no privilege about 'show master status'

What did you do?

Task configration like this:
task-mode: full
ignore-checking-items: ["binlog_enable"]
There has no privilege about 'show master status'  to upstream mysql
Use query-status check the status of task

What did you expect to see?
query-status can return normal.
What did you see instead?
query-status returns empty information.
Versions of the cluster
DM version (run dmctl -V or dm-worker -V or dm-master -V):
5.4.0

Upstream MySQL/MariaDB server version:

Downstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

How did you deploy DM: tiup or manually?

Other interesting information (system version, hardware config, etc):

current status of DM cluster (execute query-status <task-name> in dmctl)

querystatus will call updateSourceStatus and will query show master status，it should not return empty infomation when there has no privilege and only full mode.

introduced in https://github.com/pingcap/tiflow/pull/4049

Should this warning be returned?

Should this warning be returned?

I think we don't need it.


Deploy to bluemix doesn't work

I got an email saying that the deploy to bluemix isn't working. We need to investigate it.

I couldn't reproduce the issue, seems to be working for me.