Using Builds in Tekton pipelines

Given the simplicity of using Builds, it would be useful for a Tekton user to be able to use builds in a Tekton Pipeline as a part of a larger delivery process. Custom Tasks enable duck typing for plugging in other CRDs as tasks into a pipeline. It would be interesting to explore if Build resources could work as a custom task in Tekton.
apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
  name: example
spec:
  params:
  - name: pipeline-param
    default: hello
  tasks:
  - name: example-task
    taskRef:
      apiVersion: build.dev/v1alpha1
      kind: Build
      name: buildah-golang
    params:
    - name: task-param

have you got a take yet @siamaksade on the priority of such an exploration?  enough of a take to claim you preference on which milestone to target?
pending whatever answers you might have, grooming through the community meeting, etc. still seems warranted before any official assignment

have you got a take yet @siamaksade on the priority of such an exploration?  enough of a take to claim you preference on which milestone to target?
pending whatever answers you might have, grooming through the community meeting, etc. still seems warranted before any official assignment

@gabemontero It would be post GA IMO given that custom tasks are quite new (alpha) in Tekton.

@gabemontero It would be post GA IMO given that custom tasks are quite new (alpha) in Tekton.

@sbose78 asked for my input on this.
This certainly seems possible to do with Custom Tasks, but I think I need to understand Shipwright a bit better to understand how this improves the overall user experience.
My understanding is, when you tell Shipwright to run a Build, it turns around and asks Tekton to run a TaskRun, and Tekton tells K8s to run a Pod, etc. If that's all you get, adding Shipwright as as Custom Task would seem to only add a layer of abstraction, another hop to getting to the Pod that actually runs the work. This added layer of course adds another layer to debug when things inevitably go wrong.
Shipwright does provide a simpler API focused on building container images, so maybe the benefit is in constraining what the user can express to "build this image". The question is whether that's any simpler or more constrained than "run this Task that builds an image", which Tekton already supports without a Custom Task. I don't have enough context today to know for sure.
Perhaps the real benefit is in letting Shipwright users, who normally use Shipwright to simply build images in response to some trigger (source push, base image change, etc.), to integrate that with a Tekton Pipeline to explicitly kick off the build, instead of (or in addition to?) waiting for the trigger condition. I actually really like the simplicity that Shipwright promises -- "watch X, build an image" -- but I assume there are use cases where people want to graduate from the simple Shipwright case to a more complex pipeline, and this could help them slowly adopt that instead of having to throw everything out to restart with Tekton (or something else).
That turned into a lot more words than I originally expected, so I'm sorry about that -- tl;dr: I don't know if this is a good idea yet 😅 , let me learn some more and get back to you with ideas.

@sbose78 asked for my input on this.
This certainly seems possible to do with Custom Tasks, but I think I need to understand Shipwright a bit better to understand how this improves the overall user experience.
My understanding is, when you tell Shipwright to run a Build, it turns around and asks Tekton to run a TaskRun, and Tekton tells K8s to run a Pod, etc. If that's all you get, adding Shipwright as as Custom Task would seem to only add a layer of abstraction, another hop to getting to the Pod that actually runs the work. This added layer of course adds another layer to debug when things inevitably go wrong.
Shipwright does provide a simpler API focused on building container images, so maybe the benefit is in constraining what the user can express to "build this image". The question is whether that's any simpler or more constrained than "run this Task that builds an image", which Tekton already supports without a Custom Task. I don't have enough context today to know for sure.
Perhaps the real benefit is in letting Shipwright users, who normally use Shipwright to simply build images in response to some trigger (source push, base image change, etc.), to integrate that with a Tekton Pipeline to explicitly kick off the build, instead of (or in addition to?) waiting for the trigger condition. I actually really like the simplicity that Shipwright promises -- "watch X, build an image" -- but I assume there are use cases where people want to graduate from the simple Shipwright case to a more complex pipeline, and this could help them slowly adopt that instead of having to throw everything out to restart with Tekton (or something else).
That turned into a lot more words than I originally expected, so I'm sorry about that -- tl;dr: I don't know if this is a good idea yet 😅 , let me learn some more and get back to you with ideas.

@siamaksade thanks for this issue, I also see potential here for post-ga.
@ImJasonH currently the flow is as follows:

where:

an Strategy CRD holds a list of containers that define a series of steps in order to get-source-code+build-an-image+push-image. We embed this definition into the TaskRun during runtime. This provide us flexibility on defining different flavours on how to build, e.g. kaniko, buildpacks, buildkit, buildah, etc.
A Build defines "what" to build, e.g. where is my source code, where I want to push my image and which strategy to use for building.

The above image layouts the flow, it moves from a Build, to a BuildRun, then it uses the strategy to create the TaskRun and eventually the pod(done by Tekton).
The BuildRun CRD reference a particular Build instance. This means you can actually have N BuildRuns referencing the same Build, we call this 1 to N.
There is a Build controller, watches for Builds.
There is a BuildRun controller, watches for BuildRuns and TaskRuns.

I took a look on EP Custom Tasks, if we translate the current state to that approach, it might look like:

where:

Run CRD is manage by Tekton. I´m assuming this triggers the Pod creation in the background and in general runs to completion.
We keep our minimal Build API, that defines the "what".
We replace the BuildRun(shipwright) in favor of Run(Tekton), both should have the same goal, run to completion. However not having full control on the Run API, will force us to define our current BuildRuns API fields somewhere else.
We reduce our 2 controllers(Build/BuildRun), into a single one that monitors:

Build´s
Run´s , in order to see if we run to completion and to populate the Run Status.Condition.

The open questions I have(there might be more, I need to experiment with Custom Tasks from my side):

How can we avoid losing the flexibility we have today around defining the content of the TaskRun via our Strategies CRD´s.
We currently do not use Pipelines, we are only constrain to Tasks/TaskRuns
Can we ensure the 1 to N relationship between the Build and the Run?

@siamaksade thanks for this issue, I also see potential here for post-ga.
@ImJasonH currently the flow is as follows:

where:

an Strategy CRD holds a list of containers that define a series of steps in order to get-source-code+build-an-image+push-image. We embed this definition into the TaskRun during runtime. This provide us flexibility on defining different flavours on how to build, e.g. kaniko, buildpacks, buildkit, buildah, etc.
A Build defines "what" to build, e.g. where is my source code, where I want to push my image and which strategy to use for building.

The above image layouts the flow, it moves from a Build, to a BuildRun, then it uses the strategy to create the TaskRun and eventually the pod(done by Tekton).
The BuildRun CRD reference a particular Build instance. This means you can actually have N BuildRuns referencing the same Build, we call this 1 to N.
There is a Build controller, watches for Builds.
There is a BuildRun controller, watches for BuildRuns and TaskRuns.

I took a look on EP Custom Tasks, if we translate the current state to that approach, it might look like:

where:

Run CRD is manage by Tekton. I´m assuming this triggers the Pod creation in the background and in general runs to completion.
We keep our minimal Build API, that defines the "what".
We replace the BuildRun(shipwright) in favor of Run(Tekton), both should have the same goal, run to completion. However not having full control on the Run API, will force us to define our current BuildRuns API fields somewhere else.
We reduce our 2 controllers(Build/BuildRun), into a single one that monitors:

Build´s
Run´s , in order to see if we run to completion and to populate the Run Status.Condition.

The open questions I have(there might be more, I need to experiment with Custom Tasks from my side):

How can we avoid losing the flexibility we have today around defining the content of the TaskRun via our Strategies CRD´s.
We currently do not use Pipelines, we are only constrain to Tasks/TaskRuns
Can we ensure the 1 to N relationship between the Build and the Run?

Ah I think I understand where I was misunderstanding. In my mental model, the custom task controller would reach out to the (otherwise unmodified) Shipwright installation to create the BuildRun, which would reach back out to Tekton to run the TaskRun/Pod.
Your diagram seems to move creation of TaskRuns (or, perhaps direct Pod creation 🤔 ) into the custom task controller, thus ~duplicating/sharing logic from Shipwright's codebase to translate the BuildRun into a TaskRun. This is certainly less indirect, which is a good thing, but we'd still need Shipwright to be running on the cluster to validate BuildStrategies etc., unless we also want to split out and bundle that functionality with the CT controller.
So I still think it's still possible, and useful especially to help smooth out the transition for users from Shipwright->Tekton. Let me know if you want to prototype this, I'd be happy to contribute/review/lgtm or anything else you need.

Ah I think I understand where I was misunderstanding. In my mental model, the custom task controller would reach out to the (otherwise unmodified) Shipwright installation to create the BuildRun, which would reach back out to Tekton to run the TaskRun/Pod.
Your diagram seems to move creation of TaskRuns (or, perhaps direct Pod creation 🤔 ) into the custom task controller, thus ~duplicating/sharing logic from Shipwright's codebase to translate the BuildRun into a TaskRun. This is certainly less indirect, which is a good thing, but we'd still need Shipwright to be running on the cluster to validate BuildStrategies etc., unless we also want to split out and bundle that functionality with the CT controller.
So I still think it's still possible, and useful especially to help smooth out the transition for users from Shipwright->Tekton. Let me know if you want to prototype this, I'd be happy to contribute/review/lgtm or anything else you need.

It sounds like Custom Tasks might also be our path to integrating with Tekton Triggers, which currently disallows triggered creation of any non-Tekton resources. However, Triggers can create Custom Tasks Runs, which our controller could respond to by creating BuildRuns.
I have a simple PoC here: https://github.com/ImJasonH/build-task
I'd like to get it in a better state and see about bringing into Shipwright directly, eventually.

It sounds like Custom Tasks might also be our path to integrating with Tekton Triggers, which currently disallows triggered creation of any non-Tekton resources. However, Triggers can create Custom Tasks Runs, which our controller could respond to by creating BuildRuns.
I have a simple PoC here: https://github.com/ImJasonH/build-task
I'd like to get it in a better state and see about bringing into Shipwright directly, eventually.

https://tektoncd.slack.com/archives/CKUSJ2A5D/p1616445589005000 for the tl;dr ;-)

@ImJasonH that sounds promising, checking ...


revise gencomp and travis

/approve cancel

/approve cancel

@tengqm .
The changes improve the build of the component pages.
I still think it is a good idea to change CI/CD tools (these changes can be moved over).
What do you think about adding in the changes from (#195 ) to build gen-resourcesdocs?
Should be straightforward.

Add gen-resourcesdocs target to .travis.yml
Update the Makefile with a target such as:

genresources:
	cd gen-resourcesdocs && $(MAKE) kwebsite

@tengqm .
The changes improve the build of the component pages.
I still think it is a good idea to change CI/CD tools (these changes can be moved over).
What do you think about adding in the changes from (#195 ) to build gen-resourcesdocs?
Should be straightforward.

Add gen-resourcesdocs target to .travis.yml
Update the Makefile with a target such as:

genresources:
	cd gen-resourcesdocs && $(MAKE) kwebsite

@kbhawkey Adding the missing pieces.

@kbhawkey Adding the missing pieces.

@tengqm , The changes look good.
Do the targets run only if there are changes to be tested? I assumed each target would be evaluated as part of the merge check (regardless of changes to the source).
make gen-resourcesdocs

make: Nothing to be done for 'gen-resourcesdocs'.

The command "make gen-resourcesdocs" exited with 0.

@tengqm , The changes look good.
Do the targets run only if there are changes to be tested? I assumed each target would be evaluated as part of the merge check (regardless of changes to the source).
make gen-resourcesdocs

make: Nothing to be done for 'gen-resourcesdocs'.

The command "make gen-resourcesdocs" exited with 0.

/approve

/approve

/lgtm

/lgtm

@karenb  According to your suggestion, the top-level make target was genresources, not gen-resourcesdocs.
Currently, we are running the targets we specified in the .travis.yml. These targets are irrelevant to the changes made in a specific PR.

@karenb  According to your suggestion, the top-level make target was genresources, not gen-resourcesdocs.
Currently, we are running the targets we specified in the .travis.yml. These targets are irrelevant to the changes made in a specific PR.

@karenb According to your suggestion, the top-level make target was genresources, not gen-resourcesdocs.

Hi @tengqm .
-- I proposed that you add a target (could name whatever you want) for buliding gen-resourcesdocs from the main project Makefile.

Currently, we are running the targets we specified in the .travis.yml. These targets are irrelevant to the changes made in a specific PR.

-- Yes. I proposed that you add the correct target in .travis.yml to build gen-resourcesdocs. I was asking if the travis build was set to build if changes were detected or to build always.

@karenb According to your suggestion, the top-level make target was genresources, not gen-resourcesdocs.

Hi @tengqm .
-- I proposed that you add a target (could name whatever you want) for buliding gen-resourcesdocs from the main project Makefile.

Currently, we are running the targets we specified in the .travis.yml. These targets are irrelevant to the changes made in a specific PR.

-- Yes. I proposed that you add the correct target in .travis.yml to build gen-resourcesdocs. I was asking if the travis build was set to build if changes were detected or to build always.

@kbhawkey DO you mean this? https://github.com/kubernetes-sigs/reference-docs/blob/master/Makefile#L89-L90

@kbhawkey DO you mean this? https://github.com/kubernetes-sigs/reference-docs/blob/master/Makefile#L89-L90

Yes, I think we are referring to the same thing (not sure).

Yes, I think we are referring to the same thing (not sure).

@kbhawkey So the genresources target is working and is included in the travis config.

@kbhawkey So the genresources target is working and is included in the travis config.


Documentation for use as AXI4 Stream target

Hi,
Is there/can you provide documentation on how to use the DMA Controller as a target for an AXI4-Stream.
In this case, I am using the DMA controller in Renode. I am streaming data to the AXI4-Stream input interface of the VDMA. I want to direct this data to a memory peripheral on the system bus.
How can this be achieved?
I have seen the axi.robot  example file where the VDMA is configured to do a block transfer.
Configuring the VDMA writer the same way as in this example does not transfer any data to the memory peripheral.
From looking at the waveforms of the VDMA the stream data is reaching the TDATA input of the VDMA and there is one data value present on the w_data port of the VDMA however, this value is not sent on the system bus nor are any other values present on the w_data port on the writer.
Can you please advise?
Regards

Hi @p-owens,
you need to do a few things here:

Configure the FVDMA to accept AXI Stream on the input
Have the Full AXI/or Wishbone bus connected to a system bus to be able to access the memory (you need to use AXI wrapper if you use Renode)
run some software that will configure the DMA core to do the transfer, provide buffer etc (there are Linux drivers for the DMA you can reuse https://github.com/antmicro/linux-xlnx/tree/fastvdma-demo/drivers/dma/fastvdma)

With all the above in place you should be able to use the core with AXI Stream.
Can you share the waveform you mentioned? We could check what is wrong there

Thanks for the response @kgugala!
I'll get back to you in a little while with the waveform, I have to pick up this project again

Hiya @kgugala ,
Thanks for the pointers on rectifying the issue.
Please find attached a .zip with the waveform I referenced earlier, also I have included the .resc, .repl and Vtop files that I have used to produce the waveform.
In the waveform file, all the signals relating to the FVDMA are located in TOP->top->DMA
Let me know what you make of it.
Best,
Patrick
FVDMA.zip

@kgugala
Is there documentation available for the FVDMA driver?
I see that there was some added in 8ff0f07 however, there is very little information provided in those files!

Hi @p-owens!
Unfortunately, there's no FastVDMA driver-specific documentation. However, it does implement DMAEngine API so the one provided in kernel docs should be sufficient.
There's also some info provided in our blog note on co-simulation for Zynq with Renode. There's a little overview on how the driver works and how the driver demo can be reproduced.
Let us know if you need any more information.
Regards,
Wiktoria


Bug 1818788: Fix Operator Generation code

Problem:
If an operator is being upgraded that provides a required API whose GVK
has not changed since the previous version of the operator and
uses a skipRange instead of the Spec.Replaces field, OLM will:

Add the new operator to the generation, and marking the the APIs it
provides as "present".
Remove the old operator from the generation, marking the APIs it
provides as "absent", despite being provided by the new version of the
operator.
Attempt to resolve the "missing" apis, overwriting the the new version
of the operator with a copy that  does not have its Spec.Replaces field
set.

This causes OLM to fail the upgrade, where the old operator's CSV will
not be replaced and the new operators CSV will run into an intercepting
API Provider issue.
Solution:
Update OLM to remove the old operator from the current generation before
adding the new operator to the generation.

/approve

/lgtm

/test e2e-aws-olm

/cherry-pick 4.4

/cherry-pick release-4.4


Torii grpc handle entities_all query

Updated sqlx to 0.7.3 to enable regular expressions in queries
Grpc entities query clause can be omitted, this retrieves all entities
Fix entities_by_keys to return only entities that matches the specified model name + keys

huge if big


Kotlin script files (.kts)

ktfmt looks good so far! Only deficiency I have found is that it doesn't work on script (.kts) files. Any chance of adding this?

Looks like ktfmt is parsing the file as if it were a .kt file, expecting a top-level declaration.
$ cat > ~/temp/foo.kts
println("Called with args:")
args.forEach {
    println("- $it")
}

$ java -jar ktfmt-0.13-SNAPSHOT-jar-with-dependencies.jar ~/temp/foo.kts
~/temp/foo.kts:1:1: error: Expecting a top level declaration

Something inside Parser.kt causes kotlin-compiler to expect a .kt file instead of  .kts.
KotlinFileType.INSTANCE looks suspicious, but there's no kts equivalent.

Had to rollback the changes that added support for scripts, so reopening.

Are there any news regarding support for Kotlin Script files? It would be very useful to us as we are currently using ktlint but we would like to migrate to ktfmt for both normal and script Kotlin files.

@jdemeulenaere  glad you find ktfmt useful :)
Script support was added in https://github.com/facebookincubator/ktfmt/commit/c2cf421af2365aaa8c7e3cef358641559d127384, but unfortunately had to be rolled back because it hurt preserving some newlines, as well as newlines between package and the rest of the file when there are no imports. We'll get to it soon-ish, I hope.

There's now preliminary support in the main branch. It'll do undesirable things like surrounding every statement in newlines, but at least it ktfmt no longer chokes on kts files.

There's now preliminary support in the main branch. It'll do undesirable things like surrounding every statement in newlines, but at least it ktfmt no longer chokes on kts files.

Is there a snapshot for it?

Is there a snapshot for it?

I uploaded a snapshot to
<dependency>
  <groupId>com.facebook</groupId>
  <artifactId>ktfmt</artifactId>
  <version>0.20-SNAPSHOT</version>
</dependency>

see https://stackoverflow.com/questions/7715321/how-to-download-snapshot-version-from-maven-snapshot-repository for hwo to add the OSSRH snapshot repo to your Maven repo list.

I uploaded a snapshot to
<dependency>
  <groupId>com.facebook</groupId>
  <artifactId>ktfmt</artifactId>
  <version>0.20-SNAPSHOT</version>
</dependency>

see https://stackoverflow.com/questions/7715321/how-to-download-snapshot-version-from-maven-snapshot-repository for hwo to add the OSSRH snapshot repo to your Maven repo list.

Hi, everything seems to be ok now, with just a small problem : formatting scripts starting by a hashbang will fail
#!/usr/bin/env kscript
Is there any chance to support it ?

@cgrushko would you be open to a PR for the hashbang support via just peeking the first line and skipping it if it is a hashbang?

@ZacSweers was just implemented in https://github.com/facebookincubator/ktfmt/commit/d71487b6c76b23a5b4c580185c9e48f3694f0b96 :) next weekly release should pick it up.


[New feature] Add "replies count" field for Tweet

Is there a way to add the number of replies that a Tweet received? I think it would be similar to the favorites and retweets fields.
Wouldn't it be adding a line like this one?
tweet.replies = int(tweetPQ("span.ProfileTweet-action--reply span.ProfileTweet-actionCount").attr("data-tweet-stat-count").replace(",", ""))

After https://github.com/Mottl/GetOldTweets3/blob/master/GetOldTweets3/manager/TweetManager.py#L87

Great, man!
https://github.com/Mottl/GetOldTweets3/releases/tag/0.0.8
pip package updated as well:
https://pypi.org/project/GetOldTweets3/#history


Crash if git buttom pressed without file loaded

On Arch Linux (Asahi), opening lapce (0.1.3) via the terminal and clicking the git button without a file loaded causes a crash with the following text
"thread 'main' panicked at 'called Option::unwrap() on a None value', /build/.cargo/git/checkouts/druid-f6980810fb848923/9f86f23/druid/src/text/layout.rs:237:56"
EDIT: Changing to lapce-git (0.1.3) fixed the issue.

Fixed in master already


Fix Dev Install Tests

#1133 effectively disabled tests for conditional imports, Previously Jenkins was configured to use the "lint" image for a dev install. Because the lint image was changed to pytorch_vision in #1133, pytest was being invoked with -m vision, which effectively selected no tests.
This PR fixes that by explicitely specifying that dev install tests should be run on the mosaicml/pytorch:latest_cpu image, which should apply the marker -m 'not vision'

It appears this fixed the issue and the dev tests ran: https://ci.int.mosaicml.com/blue/organizations/jenkins/scratch%2Fcommand2/detail/command2/30649/tests


fix retrieve teams by HLG when externalUserUrl is configured

Closes #
A defect was found on Core Flow with following configuration: non-admin user always get empty team list
flow.externalUrl.team=
flow.externalUrl.user=${users.base.url}/internal/users/user.

Based on above configurations and code logic, the team Id list is get from flow.externalUrl.user which is mapped to higherLevelGroupId in flow_team collection, but the code logic is query against _id.
Changelog
Changed

For the case flow.externalUrl.user is configured but flow.externalUrl.team is not configured.  query  flow_team collection against higherLevelGroupId instead of **_id*.

Hey @amhudson this looked good to me. Can you add your thoughts?

Looks good to me also!


Review and improve test executions

Review tests executions implementation. This should cover UNIT, INTEGRATION and E2E tests

[ ] improve stability on tests in Github CI
[ ] get rid of retries if possible
[ ] improve speed of tests execution

Issue related with some workarounds applied: https://github.com/LeastAuthority/winden/pull/87

In #87, @donpui said:

Currently when we commit and pull request, two the same tests are running.

I understand we should avoid retrying, but do we need concurrent test at all?
As I'm trying to figure this out for other repositories, I've found this to be pretty common in .github/actions:
on:
  push:
    branches:
    - main
  pull_request:

This should avoid the test to be running twice when pull_request are made from branch created in the same repository (and not from forked one as I understand).
And if any one still want to manually trigger a test in a branch w/o creating a pull_request, we might want to add a workflow_dispatch event.
I've created #101 for this. Could that one be enough to tick the first task of this issue @donpui?

Now #101 has been merged, it should avoid running test concurrently for the same content.
However, concurrent tests may still occur whenever 2+ branches are updated with different commits around the same time.
Unless we want to ensure our integration test support concurrency, I guess we need to dig into the documentation to avoid it.
After what, we could disable the retry introduced in #87.

I don't understand how two parallel runs can interfere? Is there some global service(s) some of the tests rely on or...?

I don't understand how two parallel runs can interfere? Is there some global service(s) some of the tests rely on or...?

@donpui will correct me, but the problem I've bumped into in #92 had thrown Exceeded timeout of 5000 ms for a test:

failed 7 days ago in 6m 26s
Github won't allow me to search the logs, but I could smell that test failing after 6-7 minutes were good candidate:
failed Nov 4, 2022 in 7m 37s
failed Nov 1, 2022 in 6m 26s
failed Nov 1, 2022 in 6m 46s
failed Oct 6, 2022 in 7m 1s
...

@meejah, I suspect Github could be that global service.
Would that not make sense if they were limiting the resources available for the runners per repository?
@wuan: do you know if this could have something about what our 'spending limit'?

@btlogy, the runner time of a public repository does not affect the spending limit.

IME parallel runs are fine (e.g. if two branches are pushed "at the same time") in lots of other repos we work on.

@btlogy you are correct, we are talking about the same timeout error.
We are not using global services (I mean, our public services), however we run up local mailbox, relay and client docker containers in side github runner virtual machine. It can be that something just start earlier, then other servizes are fully operational. For example, when winden docker starts, it takes some time, while all wasm, js recompiles.
Maybe optimisation or refactor on client-ci is needed.
FYI. @JustusFT

If the tests are slow, okay they're slow -- but there's no reason to avoid concurrent runs (or stated the other way: how does avoiding concurrent runs help slow tests?).

Adding reference, there is Draft PR to try alternative way to run tests #105

While working on #171 and its fix #173, I've noticed the e2e test were randomly failing nearly 2 third of the time!
I had to re-build a couple of time the same commit to pass the check!
I'm not 100% sure the stability part of this issue was already covering these failure (too long ago).
But this is rather annoying when trying to fix the other little issues I've found.

In the context of #176, I've improved the workflow in #183 with some caching which should speedup the testes...


add KREWKAST

Thanks, @alexpietsch, for the contribution.
I looked at Krewkast and the content of the (video) podcast. Sadly, this is not matching with our definition of tech described in https://github.com/EngineeringKiosk/GermanTechPodcasts/blob/main/CONTRIBUTING.md#what-is-tech-in-this-context
If you listen to Krewkast regularly, have deeper insights and think differently, please let me know.

double checked. same conclusion: is fun to watch, but not a match for this list.

Thanks, @alexpietsch, for the contribution. I looked at Krewkast and the content of the (video) podcast. Sadly, this is not matching with our definition of tech described in https://github.com/EngineeringKiosk/GermanTechPodcasts/blob/main/CONTRIBUTING.md#what-is-tech-in-this-context
If you listen to Krewkast regularly, have deeper insights and think differently, please let me know.

Hey @andygrunwald @woolfg
the point I was referring to in CONTRIBUTING.md was "hardware". But I can also understand that I doesn't quiet fit to the list, since the focus is more on comsumer electronics. So I can understand your decision.
Have a nice day
Alex


CAdES: Fix SignerInfo attribute construction order.

Small fixup on the recent CAdES contribution.
Can be trigger if someone is using CMS_REUSE_DIGEST flag value.
Not a big issue, just a lack of logic ;)
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Ping @openssl: small fix quick to review.
The CAdES code addition was  one code block too far, my mistake.
I improve a bit asn1 fuzz test at the same time.

The travis failures are relevant.

@slontis : the CAdES verify feature changes and some additional tests are here : #8098
I will add the suggested tests in it.

@FdaSilvaYY is this code in 1_1 also?

The travis failure is related to the failing extended test (which is a known failure currently)

@FdaSilvaYY is this code in 1_1 also?

No, #7893 was just merged into master

Merged. Thanks @FdaSilvaYY. You probably will want to rebase your other PR now that this one has gone in.


Changes + extra testcase for hotfix 0.10.5

One commit is of necessary changes. The other is of a testcase which fails, but probably not because of CUDA; see issue #25.

Codecov Report

Merging #26 into hotfix-0.10.5 will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           hotfix-0.10.5      #26   +/-   ##
==============================================
  Coverage          87.19%   87.19%
==============================================
  Files                 35       35
  Lines               4606     4606
  Branches             939      939
==============================================
  Hits                4016     4016
  Misses               136      136
  Partials             454      454

Impacted Files
Coverage Δ

include/strf/detail/input_types/int.hpp
86.99% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6549b87...8206288. Read the comment docs.

@robhz786 : Would you like to take this over?


Option for no-nodejs-modules to pass when Node-specific environment detected

For no-nodejs-modules, I think it would be convenient to have an option to fail to enforce this when:

The file is pointed to by a node conditional export in package.json
The file has {env: {node: true}} applied to it

These conditions are more likely to suggest that the file or the entire package is Node only.
Such an option ought to help discourage packages which could be polyglot friendly from restricting their files or packages unnecessarily to Node.
While the second condition would be more likely to be accidentally added by a project and thus unduly suppress cases where a package could be poylglot but is not (and thus perhaps this condition could be made disable-able by option as well), I think this condition should be allowed as some projects may be Node only.

I'm a bit confused; no-nodejs-modules is only for use of node builtin modules. Its purpose is in no way to have "no modules designed for use in node".

This is not intended to prevent use in Node. It is intended to liberalize application of the rule, by option, so that Node-specific environments are exempted from the rule while allowing the rest of the code base to enforce the rule.
The rule states, "Can be useful for client-side web projects that do not have access to those modules." Such an option would better encourage this purpose by allowing for a convenient co-existence by which Node-specific code must be kept to its own files. The user would not need to specifically configure this rule for specific files, but it would instead be auto-detected for them.

Linter rules apply to both apps and packages. You’re saying you want the rule to decide how it behaves based on whether its package.json has “exports”, and points to it with a ”node” condition?
Everything that node could consume is a file meant for use in node - so the only case when a file wouldn't qualify is when it’s in a package with “exports”, and it’s not imported by any other file that’s a “node file”, and when it’s also referenced by a non-node exports condition?
That’s a ton of complexity that definitely doesn’t belong in this rule, setting aside that resolve doesn’t yet support exports at all, and that there’s no tool i know of that can reverse-map from a file to the exports entry that it may resolve to.
It’s very interesting to consider a totally new rule that’s meant for packages (not apps) and provides some guarantees about the dependency graphs for each condition - but i don’t think the tools exist yet to make it possible.

Linter rules apply to both apps and packages. You’re saying you want the rule to decide how it behaves based on whether its package.json has “exports”, and points to it with a ”node” condition?

Whether it has exports and points to it with a "node" condition OR env: {node: true}.

Everything that node could consume is a file meant for use in node - so the only case when a file wouldn't qualify is when it’s in a package with “exports”, and it’s not imported by any other file that’s a “node file”, and when it’s also referenced by a non-node exports condition?

No, by a "node file", I am talking about something already flagged by the user as Node-specific.
Of course most files can normally be used by Node. But unless a project needs Node-specific globals (as flagged well by env: {node: true}) or are intended as a Node-specific export, then a project might wish to assume that all other files in its projects not so marked are polyglot--i.e., they can potentially be run in any environment.
If the user has flagged their files already in one of the two manners, then such files would be allowed under this option to also require Node built-in modules. (Of course a user could override this in their ESLint overrides, insisting that specific files are not exempted, whether they meet the two conditions or not).
A project might wish to enforce a policy of having Node-specific entry files, browser-specific entry files, and having all other files be environment-independent--expecting an implementation, for example, whether from the Node entry or the browser one. For example, the Node entry file might require or import node-fetch and pass it to the function exported by the polyglot file, while the browser entry file might just pass in window.fetch to that function in the polyglot file. (And yes, as discussed elsewhere, I am aware there may be subtle differences by which the fetch implementations might not work the same in every way.)
I am thus saying that I want to put the burden of indicating that a file is Node-only on projects which either indicate node in package.json exports or by setting {env: {node: true}}. Once a project is flagged as Node-only, then all other files will be assumed not to support built-in Node modules either and will report errors on encountering them (but not the Node-specific ones).
Please note that this is only an additional option. I realize that some projects will wish to ban built-in modules even where the Node environment (and its globals) are used.
Thanks for your consideration.

ok, so let me repeat back to make sure i understand.
You want a way to have no-nodejs-modules ignore any code that meets any of the following criteria:

has env.node set to true
is referenced by the current package's "exports" field under a node condition

In general, all JS code in a node package is node-specific by default (altho the majority of that works automatically in a browser via a working node module bundler), and it's up to the package author to opt in to providing code for other environments, via the "browser" field, for example.
It kind of seems like your use case is that you want to be able to assume that code is universal by default (which means it doesn't use setTimeout, or any i/o including file or network or UI, or any globals outside of ecma262) - but that's not how packages work in the node ecosystem.

ok, so let me repeat back to make sure i understand.
You want a way to have no-nodejs-modules ignore any code that meets any of the following criteria:

has env.node set to true
is referenced by the current package's "exports" field under a node condition

Right.

In general, all JS code in a node package is node-specific by default (altho the majority of that works automatically in a browser via a working node module bundler), and it's up to the package author to opt in to providing code for other environments, via the "browser" field, for example.

If a browser-based package installs an npm package, and adds a script tag for a JavaScript file within node_modules (or does its own bundling from source and references that in a script tag), the code in an npm package is not Node-specific by default. It is whatever content is published within it--whether that code relies on browser globals or not.
But yes, the fields for special awareness of browser builds such as the browser field, or now browser within conditional exports as used by bundlers, as well as the leveraging of package.json dependencies by the likes of importly and @jsenv/importmap-node-module which convert the dependency information into import maps which can then be used in a browser without a build step for the source code which consumes it, have been grafted on top of the Node system, though noting this grafting has worked well, even to the extent that a good number of packages do so solely with browser builds. The Node package manager is nevertheless useful as a generic JavaScript package manager.

It kind of seems like your use case is that you want to be able to assume that code is universal by default (which means it doesn't use setTimeout, or any i/o including file or network or UI, or any globals outside of ecma262) - but that's not how packages work in the node ecosystem.

Yes, that is what I would like to do. (I might make an exception for allowing setTimeout and the like given my own general interest being more or less limited to the target environments of Node, the browser, workers, and perhaps with an eye to compatibility with Deno even though I am not using it myself currently, though I might be convinced to separate out setTimeout and friends as well if there are practical benefits for many users in doing so).
There's nothing to stop packages from working in this way as desired within the Node ecosystem. I and many others have done so; I would just like a way to enforce this to ensure proper structure and behavior in my own projects as well as a nudge to others (who might inherit such rules in their ESLint configs), to consider structuring their code in the same manner so as to benefit browser users. From my experience, most projects are open to doing so when it is meaningful for their code to be universal/polyglot, but they have simply relied on CJS-only source or distribution files, with Node built-ins mixed in, out of habit and inertia.

ok, so let me repeat back to make sure i understand.
You want a way to have no-nodejs-modules ignore any code that meets any of the following criteria:

has env.node set to true
is referenced by the current package's "exports" field under a node condition

Right.

In general, all JS code in a node package is node-specific by default (altho the majority of that works automatically in a browser via a working node module bundler), and it's up to the package author to opt in to providing code for other environments, via the "browser" field, for example.

If a browser-based package installs an npm package, and adds a script tag for a JavaScript file within node_modules (or does its own bundling from source and references that in a script tag), the code in an npm package is not Node-specific by default. It is whatever content is published within it--whether that code relies on browser globals or not.
But yes, the fields for special awareness of browser builds such as the browser field, or now browser within conditional exports as used by bundlers, as well as the leveraging of package.json dependencies by the likes of importly and @jsenv/importmap-node-module which convert the dependency information into import maps which can then be used in a browser without a build step for the source code which consumes it, have been grafted on top of the Node system, though noting this grafting has worked well, even to the extent that a good number of packages do so solely with browser builds. The Node package manager is nevertheless useful as a generic JavaScript package manager (and this was itself envisioned by the fact of engines allowing for other engines besides Node).

It kind of seems like your use case is that you want to be able to assume that code is universal by default (which means it doesn't use setTimeout, or any i/o including file or network or UI, or any globals outside of ecma262) - but that's not how packages work in the node ecosystem.

Yes, that is what I would like to do. (I might make an exception for allowing setTimeout and the like given my own general interest being more or less limited to the target environments of Node, the browser, workers, and perhaps with an eye to compatibility with Deno even though I am not using it myself currently, though I might be convinced to separate out setTimeout and friends as well if there are practical benefits for many users in doing so).
There's nothing to stop packages from working in this way as desired within the Node ecosystem. I and many others have done so; I would just like a way to enforce this to ensure proper structure and behavior in my own projects as well as a nudge to others (who might inherit such rules in their ESLint configs), to consider structuring their code in the same manner so as to benefit browser users. From my experience, most projects are open to doing so when it is meaningful for their code to be universal/polyglot, but they have simply relied on CJS-only source or distribution files, with Node built-ins mixed in, out of habit and inertia.

I think I’d encourage you to build your own eslint plugin for that, since there’s likely to be a number of rules that you want to be able to enforce it. I don’t think that it’d be worth the complexity here to try to support wishful thinking about what the ecosystem might become.

Ok...thanks for the consideration!

Btw, even if this isn't your cup of tea, if you have any ideas for rules and care to share, let me know, as I can only really think of those I mentioned.


git: clone freezes Sublime

git: clone does indeed clone the given repository, but Sublime becomes completely unresponsive while the cloning is taking place.
It would be nice to show the cloning progress instead and not freeze. It would also be nice if a new Sublime window opens with the cloned folder. It would also (final one, I promise) be nice if the suggested checkout folder isn't a subdirectory in the current project, but rather the first folder up the chain of folders starting from the current project that is not a git repo. In other words, that the cloned repo goes into a folder that is a sibling of the currently opened git repo.

Thanks for reporting, I havn't taken a look at the code. But here is some comments.

The It should be quite easy to add a async block around git: clone to stop it from running in that main thread and run in a background thread . The way git savvy is built we can't fix the progress bar :( , or we could , it just require more time then want I have free.
When selecting a git root, this is the function which create a proposal for path. It should use the open folder path as root is if it's not a repo. If it is a repo the take the parent folder as root.

All of that sounds reasonable.
I also checked the Sublime API - unfortunately it appears to be impossible to open a new sublime window with a given folder name through the API. Maybe directly through the executable? subprocess.Popen('subl ' + cloned_git_folder, ...) ?

@tailsu, Now it will open the newly cloned project in a new window.

I created a PR, I will see if any of the other contributes want to comment before I merge.
We should probably create a release soon.


coordinator: rework GetDefaultRouteInterface to get pod's default route nic

Thanks for contributing!

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #3296
Special notes for your reviewer:
In IPv6 mode, a non-existent network card is set through PodDefaultRouteNIC, but the Pod has an IPv6 default route, but a null value is returned, thus skipping the synchronization of the default route and making the Pod successfully created. However, the creation should fail at this time and prompt "net2 don't exist in pod"

no cherry-pick ?


FIX: small diverse fixes

Uses r#true, r#false and r#ref instead of false_value, true_value and ref_value
Uses binary internal representation and remove json serializarion/deserialization where not needed
fixes wasm types issues

@nhatcher Out of curiosity, what is the advantage of this change?

Uses r#true, r#false and r#ref instead of false_value, true_value and ref_value

@nhatcher Out of curiosity, what is the advantage of this change?

Uses r#true, r#false and r#ref instead of false_value, true_value and ref_value

It's just more consistent. When I wrote that code I didn't know you could use this notation to "sidestep" Rust reserved names. Without it I had to do a rename in the other side.


How to pass a dynamic parameter to the auth endpoint?

Is your feature request related to a problem? Please describe.
I use a custom auth provider. They support passing a login_hint parameter to pre-populate the user's email address. This is extremely helpful for offering easy login links for users from emails or other platforms. Is there no way to pass a dynamic parameter to the ./auth/login/[provider] endpoint?
Describe the solution you'd like
I would like to be able to pass dynamic parameters to the login page.
Describe alternatives you've considered
I would also be open to being able to link to my auth provider login page directly, which allows me to pre-populate the email. It appears that my session is not authenticated when it routes back to my application though. Looking at the network activity in my browser during a login, I'm assuming this is due to the reliance on the staticWebAppsAuthNonce value.
Any thoughts would be greatly appreciated!

It's not commonly known, but under the hood they use Easy Auth. Have a look at their wiki, it might be helpful: https://github.com/cgillum/easyauth/wiki/Login


Provision specific task

Is there a way to provision a specific task?
I want to run vagrant provision --provision-with post_provision_scripts instead of having to go through the entire provisioning but it's not working for me.

I think not as the vagrant provisioner is still the same, ansible.
If you're on the master branch (or have commit 8a05b75dcf51eb) you could get it to work by not using Drupal VMs own post_provisioning_scripts variable but instead extend vagrant with a shell provisioner. To do that you create a Vagrantfile.local with the following contents:
config.vm.provision "shell", path: "my-post-provisinoing-script.sh"

Then you can run vagrant provision --provision-with shell and it should work.

Technically you can also do this if you use Ansible outside Vagrant, or if Vagrant had a way to pass through tags to Ansible.
I don't use them in Drupal VM, but it's easy enough to add them, and if Vagrant supports them via CLI sometime (not just through the Vagrantfile config), I will add them.
With Ansible, you can just do something like ansible-playbook -i provisioning/inventory provisioning/playbook.yml --tags=post or something along those lines.

And yes, for now, the workaround would be to add what oxyc mentioned. I'll be tagging a new release once I get a few other upstream issues worked out, but for now that feature is available in master.

Thanks for the information guys.

See @joestewart's PR above for a nice approach here.


Single Operation Part 1 : CODECHEF OCTOBER LONG CHALLENGE 2022

@Lonewolf0502 Sir , Kindly assign this issue to me under Hacktober-Fest 2022 and labelled as hacktoberfest accepted.

Assign me the issue.

sure

@Lonewolf0502 Sir , here's full description : -
Problem Statement : -
Chef has the binary representation SS of a number XX with him. He can modify the number by applying the operation exactly once.
Chef wants to maximize the value of XX after performing the operation. Help Chef in determining the value of YY which will maximize the value of XX after the operation.
Output -

You can create pull request


Documentation: profile.XXX.debug can be u32 or bool

profile.XXX.debug is parsed as either an u32 or a bool https://github.com/rust-lang/cargo/blob/558eee4fbca56bdc4969e114ed2cc4ed7c3913bb/src/cargo/core/profiles.rs#L349
The documentation
only show an u32 in profile.test. It could be clearer to explain that both types are accepted.
As a result, cargo-deb only parses it as a bool (I will make a PR to fix this in a bit).
Something like this might do the trick?
debug = true       # (u32 or bool) Include debug information (debug symbols).
                   # Equivalent to`-C debuginfo=2` compiler flag.

Sounds good to me!


changed cryptic u gates to readable x and h

Summary
Fixes #1287
Changed cryptic looking u gates to readable x and h gates.
U(pi, 0, pi) --> X
U(pi/2, 0, pi) --> H
Details and comments

Nice! In reciprocals we have cu(2 * np.pi, 0, 0, 0, q0, q1) which is the same as cry(2 * np.pi, q0, q1), could you also update that?

Done @Cryoris !


change code for support python 3.4

I needed to use your code in python 3.4.
As brought no changes made to add function in python 3.4

Closed as inactive. Also see this pull request: https://github.com/innoteq/python-mpns/pull/3


Is resume-schema used?

Question about format of json file, is https://github.com/jsonresume/resume-schema used?

Nope.


Update Dockerfile to match setup.sh

Ran into issues with these mruby files missing so copied made updates to Dockerfile based on setup.sh

@lvela Looks nice! Thanks!


The render function is missing the output of the bools attributes

The bools attributes does not exist in the VirtualElement.


Add conversion functions for common types

Implements #117.

This change is

Shifted to #153
Closing this and deleting branch


fixing overflow issue

SUMMARY

Fixes text overflow display issues with new metric labels in Explore controls
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

@kgabryje maybe you can give this a quick review?

Thank you for making this fix! Can we also add a nowrap for saved metrics? When saved metric's name is long, the tooltip trigger jumps down to second line

Codecov Report

Merging #12129 (ed1502b) into master (2a23744) will decrease coverage by 2.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12129      +/-   ##
==========================================
- Coverage   66.22%   63.61%   -2.62%
==========================================
  Files         972      481     -491
  Lines       48098    29669   -18429
  Branches     4752        0    -4752
==========================================
- Hits        31852    18873   -12979
+ Misses      16108    10796    -5312
+ Partials      138        0     -138

Flag
Coverage Δ

cypress
?

javascript
?

python
63.61% <ø> (-0.60%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/db_engine_specs/presto.py
69.95% <0.00%> (-12.45%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.56% <0.00%> (-2.44%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

superset/models/core.py
88.07% <0.00%> (-0.82%)
:arrow_down:

superset/views/base_api.py
97.68% <0.00%> (-0.47%)
:arrow_down:

... and 498 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a23744...36bd2ea. Read the comment docs.

Thank you for making this fix! Can we also add a nowrap for saved metrics? When saved metric's name is long, the tooltip trigger jumps down to second line

Dang, didn't get this in.. will try to fix and open a new PR, if I can get to it. Maybe you'll beat me to it though :)


created a python program to create a complex password easily

Description
A short summary of what is included in your Pull Request.
Fixes #(issue_no)

[ ] Issue_no: <insert your issue no here>
[✔ ] Not applicable

Type of change
Choosing one or more options from the following as per the nature of your Pull request.

[ ✔] New project insert
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation Update

Project

Your Project Name: COMPLEX PASSWORD GENERATOR USING PYTHON

Short Description: This program creates a password according to the user's need.

Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.

[ ✔] I have named my files and folder, according to this project's guidelines.
[ ✔] My code follows the style guidelines of this project.
[ ✔] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
[ ✔] My changes do not produce any warnings.

the project is duplicated


Delivery report ordering

It seems that the delivery report callbacks/delegates are called "randomly" on the internal thread pool which results in losing the actual delivery order.
Example, see how offset goes from 7741 back to 7730 and then to 7743.
{"topic":"test.net","partition":"2","key":"","value":"44","offset":"7737","name":"producer_send_success","_time":"2017-01-25 13:55:26","_thread":"7"}
{"topic":"test.net","partition":"2","key":"","value":"45","offset":"7738","name":"producer_send_success","_time":"2017-01-25 13:55:26","_thread":"7"}
{"topic":"test.net","partition":"2","key":"","value":"46","offset":"7739","name":"producer_send_success","_time":"2017-01-25 13:55:26","_thread":"7"}
{"topic":"test.net","partition":"2","key":"","value":"49","offset":"7740","name":"producer_send_success","_time":"2017-01-25 13:55:26","_thread":"7"}
{"topic":"test.net","partition":"2","key":"","value":"52","offset":"7741","name":"producer_send_success","_time":"2017-01-25 13:55:26","_thread":"7"}
{"topic":"test.net","partition":"2","key":"","value":"32","offset":"7730","name":"producer_send_success","_time":"2017-01-25 13:55:26","_thread":"12"}
{"topic":"test.net","partition":"2","key":"","value":"53","offset":"7743","name":"producer_send_success","_time":"2017-01-25 13:55:26","_thread":"12"}
{"topic":"test.net","partition":"2","key":"","value":"54","offset":"7744","name":"producer_send_success","_time":"2017-01-25 13:55:26","_thread":"12"}

Delivery reports must retain their original order, preferably globally but at least per partition.

The ProduceAsync variant that has a DeliveryHandler callback parameter should be deterministic (if you're using that and calling of that is not deterministic, this is a problem I didn't know about).
We have the Task based variant as this is so idiomatic (task completion won't be deterministic). I need to put more thought into this than I have right at this minute, but we might be able to make the Task based method ordering deterministic using a custom scheduler or (thread pool with one thread) or something. Regardless of whether this turns out to be a viable solution in practice, it would have been good to think this through that far.

Right, I'm using the Task-based one, should I switch to the callback Produce()?
            var deliveryReport = Handle.ProduceAsync(topic, null, value);
            deliveryReport.ContinueWith((result) => HandleDelivery(result.Result));

Works much better with the IDeliveryHandler, thanks Matt!
We must make a big bold note of this behaviour in the Task-based Produce API.

Note: you could also call the Task ProduceAsync method synchronously buy Wait()ing on the task between calls (or by simply accessing the .Result property of the task). Performance will be abysmal though of course. ContinueWith doesn't block.
yep, this needs documenting pretty fully.

You should know better than telling me to use a sync produce interface ;)

closing this issue. it's core stuff that needs documenting which will be prioritized elsewhere.

I suggest keeping this one open until the documentation is fixed, otherwise it is easy to loose track


The subsequent chat conversation cannot automatically modify the code

Describe the bug
The model I use is gemini/gemini pro
In the first conversation, the project was successfully generated, but in subsequent modified conversations, it was unable to automatically modify the code, resulting in a project with errors for me
Link to the Bolt URL that caused the error
not have
Steps to reproduce

Create a project
Dialogue

Expected behavior
Is it a problem with the model I am using or something else? I need to clarify
Screen Recording / Screenshot
No response
Platform

Windows
Chrome

Additional context
No response

comment faites vous pour que gemini fonctionne. quel est votre configuration de env.local, chez moi impossible

评论 faites vous pour que Gemini fonctionne。这是 env.local 的 votre 配置，这是不可能的
I used Litellm

please try the latest version and let me know if you are still having this issue


backport jefftk's changes to branch 32

https://github.com/pagespeed/mod_pagespeed/commit/f3b09e2c66a81a5d419a87f171e87423b96707ec
and https://github.com/pagespeed/mod_pagespeed/commit/b094d532512330f7472f0710ac0fd051bf3f9c05

backported here
https://github.com/pagespeed/mod_pagespeed/commits/32_apachefetch_fix
testing and merging back to 32 when tests pass


Fix missing dependencies due to Aggregation through Join pushdown

Fixes https://github.com/prestosql/presto/issues/6138

BTW: I think this rule can be generalized. Currently there is:
    private static boolean groupsOnAllColumns(AggregationNode node, List<Symbol> columns)
    {
        return node.getGroupingSetCount() == 1 && new HashSet<>(node.getGroupingKeys()).equals(new HashSet<>(columns));
    }

but it seems that grouping keys must just contain all symbols from outer side

BTW: I think this rule can be generalized.

I applied the other comments. This could be looked into as a follow-up.


Problem with adding UI component to react-boilerplate project

When I try to import Semantic UI component to a project seeded with react-boilerplate
import { Icon } from 'stardust';

I am getting following error (actually two errors, one as listed, the other one with net module).
ERROR in ./~/debug/node.js
Module not found: Error: Can't resolve 'fs' in 'react-boilerplate\node_modules\debug'
 @ ./~/debug/node.js 170:16-30
 @ ./~/stardust/dist/lib/debug.js
 @ ./~/stardust/dist/lib/index.js
 @ ./~/stardust/dist/elements/Button/Button.js
 @ ./~/stardust/dist/elements/index.js
 @ ./~/stardust/dist/addons/Confirm/Confirm.js
 @ ./~/stardust/dist/addons/index.js
 @ ./~/stardust/dist/index.js
 @ ./app/containers/HomePage/index.js
 @ ./app/routes.js
 @ ./app/app.js
 @ multi main

I don't think this is an issue in your code, but I don't know how to debug it since webpack is a black box to me and I don't know why fs module is required in the browser. And also the chunks are not debuggable as well.
Also when the web is running, the error message is also displayed in browser window
.
But when the server is restarted Not found message is displayed in the browser window.
Steps to reproduce

git clone --depth=1 https://github.com/mxstbr/react-boilerplate.git
cd react-boilerplate
npm run setup
npm install stardust --save-dev
edit app\containers\HomePage\index.js, add
import { Icon } from 'stardust';

Any help will be appreciated, thank you.
Karel
PS: this was also reported to react-boilerplate

I had another look at it and after hacking the NPM module debug node.js file it works now. Which is strange since browser debug is referencing the node debug file (also the fs and net should have ringed the bell at the beginning).

It looks like an error with debug, though likely due to the webpack configuration preventing that module from loading fs correctly.  Glad to you got it to work.  Closing as this is out of scope for this project.

@kfrajtak I also encountered similar issue, and had to employ the same "fix".


Why skip legacy animation clip

I saw a validation added in AnimationClipExtension on Commit. Why we skip legacy animation clip now ?

thats only for preview , legacy/generic can be export merged with model itself , Export Animator+Selected AnimationClips


ReorderableListView top padding causes clipping of content

ReorderableListView, when using the padding parameter, does not pad the content of the list, but instead pads the entire list itself. This is not the expected result, and does not occur when padding the bottom either. It only occurs with top padding.
Steps to Reproduce

Create a ReorderableListView widget
Use the built-in padding parameter to add top padding to the list

Expected results:
It should mirror how padding works on ListView, where the top of the content is padded and not the entire list, so the content is initially padding but scrolling will still scroll through that area.
Actual results:
The content is clipped at the top, as if you have wrapped the outside of the list in a Padding widget.

Logs
flutter doctor -v
[✓] Flutter (Channel stable, 2.0.3, on macOS 11.3 20E5224a darwin-x64, locale en-CA)
    • Flutter version 2.0.3 at /Users/jagandeepbrar/Development/flutter
    • Framework revision 4d7946a68d (2 weeks ago), 2021-03-18 17:24:33 -0700
    • Engine revision 3459eb2436
    • Dart version 2.12.2

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] VS Code (version 1.55.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (1 available)
    • iPhone 12 Pro (mobile) • E5AE0F2A-C2B8-4DB0-821D-F9E76B046693 • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)

! Doctor found issues in 2 categories.

Reproducible Code & Images
Below are two images, where the red tiles are a regular ListView and blue is a ReorderableListView, both which have been padded with MediaQuery.of(context).padding.copyWith(top: 50.0, bottom: 50.0). As you can see, the top of the list is padded as expected on both, but on the ListView, the content scrolls past this padding, yet In a ReorderableListView, the content is clipped to that top padding. This does not occur on either when using bottom padding, however.

Images

Full Code Example
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('ListView Test'),
      ),
      body: PageView(
        children: [
          ListView.builder(
            itemCount: 100,
            itemBuilder: (context, index) => ListTile(
              title: Text(index.toString()),
              tileColor: Colors.red.withOpacity(0.50),
            ),
            padding: MediaQuery.of(context).padding.copyWith(top: 50.0, bottom: 50.0),
          ),
          ReorderableListView.builder(
            itemCount: 100,
            itemBuilder: (context, index) => ListTile(
              key: ObjectKey(index),
              title: Text(index.toString()),
              tileColor: Colors.blue.withOpacity(0.50),
            ),
            onReorder: (oIndex, nIndex) {},
            padding: MediaQuery.of(context).padding.copyWith(top: 50.0, bottom: 50.0),
          ),
        ],
      ),
    );
  }
}

Is this intentional or a bug? I've tried to fix it anyway.

Is this intentional or a bug? I've tried to fix it anyway.

I don't believe it is intentional, as ListView has not operated this way with padding for a very long time. Padding was only recently added as a property to ReorderableListView.
Thank you for making the PR!

Is this intentional or a bug? I've tried to fix it anyway.

I don't believe it is intentional, as ListView has not operated this way with padding for a very long time. Padding was only recently added as a property to ReorderableListView.
Thank you for making the PR!

@PixelToast told me it is intentional as stated in the code comments. But I completely agree with your point, let's see what flutter team thinks about this.

flutter doctor -v
[✓] Flutter (Channel master, 2.1.0-13.0.pre.444, on macOS 11.2.3 20D91 darwin-x64, locale en-AO)
    • Flutter version 2.1.0-13.0.pre.444 at /Users/pedromassango/Code/flutter_master
    • Framework revision 824b1ad3f8 (2 days ago), 2021-04-03 15:24:02 -0400
    • Engine revision e393800c63
    • Dart version 2.13.0 (build 2.13.0-196.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/pedromassango/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 54.1.4
    • Dart plugin version 203.7759

[✓] VS Code (version 1.54.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.2.3 20D91 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 89.0.4389.114

! Doctor found issues in 1 category.


How to use internationalization?

Hi. Does it work with yii2 i18n?

Hi, I added some internalizations (sk,cs,de,fr,pl,ru,es), also you can use your own, just have to configure the messages for calendar, just update to version 1.0.0 in your composer and update.
Yii::$app->i18n->translations['calendar'] = [
            'class' => 'yii\i18n\PhpMessageSource',
            'sourceLanguage' => 'en-US',
            'basePath' => '@vendor/marekpetras/yii2-calendarview-widget/messages',
            'fileMap' => [
                'calendar' => 'calendar.php',
            ],
        ];

Cheers,
Marek


The description of the donate page seems to use incorrect grammar

URL(s)
https://eslint.org/donate/
What did you do?
The donate page uses the following description, which contains a grammatical error:

Donate
ESLint relies on donations for ongoing maintenance and development. There are currently 184 companies, organizations, and individuals are donating $9,337.00 each month to help us out.

This description is rendered from the following:
https://github.com/eslint/eslint.org/blob/5d13b11ea92f99db005b34e2d8af5cf5ebc7e9e2/src/_data/sites/en.yml#L385-L388
What did you expect to happen?
I expected the description of the donate page to have correct grammar.
What actually happened?
The description of the donate page uses two instances of 'are' in its final sentence, and the second of which seems incorrect without a leading 'which' or similar correction.
Participation

[X] I am willing to submit a pull request for this issue.

Yup, nice catch. Please feel free to open a pull request to fix this.


Any reference code to support Clearkey (cenc:pssh in mpd)?

Hi
I am trying to build an app to support Clearkey with initData in mpd as <cenc:pssh/>. I was able to implement Clearkey using 'webm' and 'keyids' initDataType. Are there examples to do the same with cenc initDataType? from what I understand, Shaka player can parse <cenc:pssh/> if present but there does not seem to be a way to get access it. My application is trying to make an external license request rather than providing the license inline.
var licenseServerUrl = 'data:application/json;base64,' + window.btoa(license);

I'm not sure I understand the question.  Are you using a release version of Shaka (v1.x) or the latest code in the master branch?

I am using v1.6.4 for testing. In v1.6.4, shaka.player.DrmInfo.config can be set by implementing  shaka.player.DashVideoSource.ContentProtectionCallback and proving the preproccesor and postprocessor functions. I can set initData member with initDataType keyids and webm. I am trying to implement support for cenc type for ClearKey content protection scheme. Mpd already includes cenc:pssh xml element. As i understand, I do not need to overwrite initData as it should be populated from cenc:pssh box in mpd.  How can i get keyid information from that box in this callback and use it for license request url construction?

Here's the normal path:
If you don't specify init data in the callback, cenc:pssh content is used if present.  Init data is passed to the CDM in generateRequest(), and the generated request is sent via HTTP POST to the license server URL you configured.
The generated request for clearkey looks like this: https://w3c.github.io/encrypted-media/#clear-key-request-format
So if you want the key IDs, use a license request pre-processor to parse the request:
function preprocessClearKey(licenseRequestInfo) {
  var requestBinary = licenseRequestInfo.body;
  var requestText = String.fromCharCode.apply(null, new Uint8Array(requestBinary));
  var request = JSON.parse(requestText);
  var key_ids_base64 = request.kids;
  console.log(key_ids_base64);
}

Does that help?

Thanks Joey.
I was actually doing the same. But I found the issue with my
implementation. It was related to how I was handling multiple key
systemIds, including Youtube Clearkey system (org.youtube.clearkey).
Youtube key system was selected for my test video instead of what I was
expecting and licenseRequestInfo.body was empty in
shaka.player.DrmInfo.licensePreProcessorcall.
Thanks again for the support.
--
*Ashok Lalwani *| Product Manager - Video | m:<PHONE_NUMBER>
fastly.com | @fastly https://twitter.com/fastly | LinkedIn
http://www.linkedin.com/company/fastly
On Tue, Mar 29, 2016 at 1:47 PM, Joey Parrish<EMAIL_ADDRESS>wrote:

Here's the normal path:
If you don't specify init data in the callback, cenc:pssh content is used
if present. Init data is passed to the CDM in generateRequest(), and the
generated request is sent via HTTP POST to the license server URL you
configured.
The generated request for clearkey looks like this:
https://w3c.github.io/encrypted-media/#clear-key-request-format
So if you want the key IDs, use a license request pre-processor to parse
the request:
function preprocessClearKey(licenseRequestInfo) {
var requestBinary = licenseRequestInfo.body;
var requestText = String.fromCharCode.apply(null, new Uint8Array(requestBinary));
var request = JSON.parse(requestText);
var key_ids_base64 = request.kids;
console.log(key_ids_base64);
}
Does that help?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/google/shaka-player/issues/313#issuecomment-203094120

Happy to help!


Support

Hi
I am building an android application that supports streaming without downloading content.
If I use your embed sdk js in a webview, then the user experience is very bad.
So, I was thinking, If I become your gold backer, is there any way I can get the streaming url.
I can then load it using the native video api for android.
Please let me know what you think.

Hi! Next month I am going to implement "simple" API for end users. I think this should work for you.

is there a way to remove the controls which are not needed for my scenario??

for example i dont need the embed symbol so when using the below code is there something i should add to it??
 <div id="player" class="webtor" />     <script>         window.webtor = window.webtor || [];         window.webtor.push({             id: 'player',             magnet: 'magnet:?xt=urn:btih:08ada5a7a6183aae1e09d831df6748d566095a10&dn=Sintel&tr=udp%3A%2F%2Fexplodie.org%3A6969&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969&tr=udp%3A%2F%2Ftracker.empire-js.us%3A1337&tr=udp%3A%2F%2Ftracker.leechers-paradise.org%3A6969&tr=udp%3A%2F%2Ftracker.opentrackr.org%3A1337&tr=wss%3A%2F%2Ftracker.btorrent.xyz&tr=wss%3A%2F%2Ftracker.fastcast.nz&tr=wss%3A%2F%2Ftracker.openwebtorrent.com&ws=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2F',             on: function(e) {                 if (e.name == window.webtor.TORRENT_FETCHED) {                     console.log('Torrent fetched!', e.data);                 }                 if (e.name == window.webtor.TORRENT_ERROR) {                     console.log('Torrent error!');                 }             },             poster: 'https://via.placeholder.com/150/0000FF/808080',             subtitles: [                 {                     srclang: 'en',                     label: 'test',                     src: 'https://raw.githubusercontent.com/andreyvit/subtitle-tools/master/sample.srt',                     default: true,                 }             ],             lang: 'en',             i18n: {                 en: {                     common: {                         "prepare to play": "Preparing Video Stream... Please Wait...",                     },                     stat: {                         "seeding": "Seeding",                         "waiting": "Client initialization",                         "waiting for peers": "Waiting for peers",                         "from": "from",                     },                 },             },         });     </script>     <script<EMAIL_ADDRESS>charset="utf-8" async></script>
Thank you :)

Hey @vintikzzz , any update on this.
Thanks

Hey @vintikzzz ,sorry to bother you again but any update on the API development?
Thanks

Hey @vintikzzz ,sorry to bother you again but any update on the API development? Thanks

Any updates @vintikzzz ?
THanks

REST API is ready and it is now part of self-hosted installation. Later this week, I am going to make an integration to RapidAPI and I think this will be the best option for you!

REST API is ready, and it is now part of self-hosted installation. Later this week, I am going to make an integration with RapidAPI and I think this will be the best option for you!

Thank you very much @vintikzzz . Looking forward to it.

I finally published it as repidapi, here is a link

I have finally published it at repidapi, here is a link

Thanks @vintikzzz . I will try it ASAP.


Auto update configuration docs

Keep the configuration page consistent with ClickHouseSQLConf

looks like it is something that has already been implemented. Can I close it

Yes, UPDATE=1 ./gradlew test --tests=ConfigurationSuite, the golden result file is "docs/configurations/02_sql_configurations.md".


[.NET CORE 3.0] [5.0.0-rc5] Swagger UI not displaying

It works on my local but when I publish the API to Azure I got the following errors :
It doesnot see any swagger related js files.

/swagger/swagger-ui.css net::ERR_ABORTED 404 (Not Found)
/swagger/swagger-ui-bundle.js net::ERR_ABORTED 404 (Not Found)
/swagger/swagger-ui-standalone-preset.js net::ERR_ABORTED 404 (Not Found)
/swagger/swagger-ui-bundle.js net::ERR_ABORTED 404 (Not Found)
/swagger/swagger-ui-standalone-preset.js 404 (Not Found)

Here is my configuration :
 app.UseSwagger();
 app.UseSwaggerUI(c =>
            {
                c.SwaggerEndpoint("/swagger/v1/swagger.json", "Sample API");
                c.DocumentTitle = "Sample API Documentation";
                c.RoutePrefix = string.Empty;
                c.IndexStream = () => GetType().GetTypeInfo().Assembly.GetManifestResourceStream("SampleProject.API.Content.index.html");
                c.ShowExtensions();
                c.DocExpansion(DocExpansion.None);
            });
app.UseStaticFiles();

I use custom index.html. When I set a route prefix such as  "swagger",
I able to open swagger page on following url: {baseUrl}/swagger/index.html
But I don't want to use any route prefix.
Just want to see swagger on default start page.

Finally, I found the problem. It was about custom middleware. With adding IsSwagger control on the beginning of the invoke method solves the production problem!
private bool IsSwagger(HttpContext context)
        {
            return (context.Request.Path.StartsWithSegments("/index.html") || context.Request.Path.Value.Contains("swagger"));
        }

public async Task Invoke(HttpContext context)
  {
      if (context == null)
          throw new ArgumentNullException(nameof(context));

      if (IsSwagger(context))
          await next(context);
      else
      {
      ..
      }
  }


Replays being distributed by cloudflare

Patched to allow download of replays behind cloudflare
processor.py.zip

Awesome! Updated! Thank you!


[Bug]: can't create project in non-existing folder

Apache Hop version?
SNAPSHOT-20230210
Java version?
openjdk version "11.0.17" 2022-10-18
Operating system
Linux
What happened?
Observed behavior: when a project is created in a non-existing folder, Hop GUI shows a pop-up that asks the user if the folder needs to be created. The project dialog keeps focus, the yes/no options in this pop-up dialog can't be clicked,

Expected behavior: clickable yes/no options in the pop-up dialog.
Issue Priority
Priority: 2
Issue Component
Component: Hop Gui

It happens when the parent of the dialog isn't correct.  The parent of an SWT shell should always be the dialog where it is called.  I already fixed a number of instances where HopGui.getInstance().getShell() and this is probably another one of these cases.


[HOLD for payment 2023-02-13] [$1000] Web - Payment - The welcome message in Spanish not centered

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Preconditional: profile language is Spanish

Go to URL https://staging.new.expensify.com/
Login with any profile
Go to Settings -> Payments -> Add any payment method

Expected Result:
The welcome message is centered
Actual Result:
The welcome message in NOT centered
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Win / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01384da887bf662724
Upwork Job ID:<PHONE_NUMBER>835147264
Last Price Increase: 2023-02-02

Will follow along with the PR and take appropriate steps when applicable.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.65-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/14738

If no regressions arise, payment will be issued on 2023-02-13. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@Santhosh-Sellavel / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@Santhosh-Sellavel / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@Santhosh-Sellavel / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@Santhosh-Sellavel] Propose regression test steps to ensure the same bug will not reach production again.
[ ] [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

I updated the payout checklist above and will work on the reg test assessment.

I just realized the proposal for the reg test is actually on @Santhosh-Sellavel, I missed that we updated that step. I'll follow along for your assessment and the other answers to the checklist. Thank you!

Test Steps From PR itself looks good to me thoughts @strepanier03 & @luacmartins

I think those steps look good, but I'm not sure that we are adding internationalization steps to TestRail since that's behind a beta and is not a supported feature yet. I'd check with Applause on this one.

I'm pretty sure you're right @luacmartins. The last time I had an internationalization GH we did nothing for the regression test but I'll confirm with Applause and either make the GH or check off that part of the BZ checklist.

Sounds good! Thanks for checking @strepanier03!

@Santhosh-Sellavel - Could you please reply with answers to the checklist items here? Once we have that info I can update the checklist and pay out the job in Upwork. Thank you!

[x]  [@Santhosh-Sellavel / @luacmartins] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/13744
[x]  [@Santhosh-Sellavel / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/13744#issuecomment-1428953415
[x]  [@Santhosh-Sellavel / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed I guess, @luacmartins can you confirm though?
[x]  [@Santhosh-Sellavel] Propose regression test steps to ensure the same bug will not reach production again.
Steps here

Thank you @Santhosh-Sellavel, very much appreciated!

I'll check back again at the end of my day and if the invite and offer is accepted by then I'll pay out in Upwork.

@strepanier03 Accepted the invite, In case you are not aware, there is an option to hire straightaway instead of inviting first and followed by hiring. Let me know once the offer is sent thanks!

Oh thank you for the heads up @Santhosh-Sellavel - I'll look that up in their help docs, I didn't know about it!
You're paid out by the way, 👋 thanks for your hard work on this.


why 'img' ? It's 'src' instead

Hello, below is my code:
<BackgroundImage className={"img-carousel"} placeholder={this.state.placeholder} src={'http://imgtest.xxx.com/20170309232350329448'}> </BackgroundImage>
when I repace 'src' with 'img', image always fail to load, why document told us to use 'img'  ?
It is not until I read the source code did I found out, kinda waste of time.

Sorry, that slipped through the cracks some how. Thanks for pointing it out, it's been resolved.


How to use openssl-cmp function on openssl1.1.0

hello, since openssl3.0 can't use the features of openssl-cmp on my 32bit ARM platform, I now found your fork of CMP https://github.com/mpeylo/cmpossl/tree/cmp
Can you help me, how do I use openssl1.1.0 version, I checked README.md to support openssl1.1.0 version, but I compiled libcmp dynamic library, but how to use openssl1.1.0 on openssl- what about cmp?

There is unfortunately no CMP implementation in openssl-1.1.0 if this is the question you're asking.

marking as inactive, will be closed at the end of 3.4 dev barring further input


[onednn] Bumped version to 3.0.0 release.

@microsoft-github-policy-service agree

Please also remove libcopp:arm-uwp=fail from [VCPKG_ROOT]/scripts/ci.baseline.txt, there is "supports": "x64 & !uwp" in vcpkg.json.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 91dd61bd441a68b4017b61011d0350b2e6aeeccf -- versions
./vcpkg x-add-version --all

Please update the version database.

Please also remove libcopp:arm-uwp=fail from [VCPKG_ROOT]/scripts/ci.baseline.txt, there is "supports": "x64 & !uwp" in vcpkg.json.

Done! Is there anything else ?

git add -u && git commit
git checkout 91dd61bd441a68b4017b61011d0350b2e6aeeccf -- versions
./vcpkg x-add-version --all

I just did that now check if ok please.

Please also remove libcopp:arm-uwp=fail from [VCPKG_ROOT]/scripts/ci.baseline.txt, there is "supports": "x64 & !uwp" in vcpkg.json.

I think some wires got crossed here :D
https://dev.azure.com/vcpkg/public/_build/results?buildId=84590
REGRESSION: libcopp:arm-uwp failed with BUILD_FAILED. If expected, add libcopp:arm-uwp=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt.
I'm fixing


Incorporate Design Systems and DTA branding

Nice work. The header is 'Digital Guides' which makes sense as to make it part of guides.service.gov.au. However clicking on the the header link takes me back to Content Guide home. Is this a bit of a disconnect in navigation/IA?

It will make sense once it all goes to Prod as the links will be correct. The header link will all go to the Service Manual's homepage.


packets not forwarded to newly added endpoint

This issue is created for following up on #1085 since I can't re-open it.
Are the packets being forwarded to another pod in the service?
No, packets were being dropped. The service only have one pod.
We can't adjust the application to cycle its source port, since they are not under our control.
Wondering if calico creates IP table rules for kubernete services or only pods? If calico only creates ip table rules for pods, then I agree it should be fixed in kube proxy. If calico also handles the ip table rule creation for kube services, then I would think is better for calico to handle it.

Ah, sorry about that, didn't realise it would lock the issue to comments.
Calico does not program rules for service IPs.  The IPs have been converted to pod IPs before we see them.

Got it, so agree with you that it is better for kube to handle it then, since it is service ip rule.


Crash when using PowerToys Run

Microsoft PowerToys version
<IP_ADDRESS>
Installation method
Chocolatey
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
I just open the PowerToy Run, started to type, but the app stalled and then crashed
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19045.0
IntPtr Length: 8
x64: True
Date: 27/02/2023 14:11:35
Exception:
System.InvalidOperationException: Dispatcher processing has been suspended, but messages are still being processed.
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

/dup #18166

For any users that are able to replicate this consistently, can you please update to 0.68.1 and disable thumbnail generation to verify if it fixes the issue? Please let us know on #18166!

sure, but this is doesn't happens always


What are the hard-coded... codes, in the Prezi output?

Whilst working on my fork of this project I couldn't help but notice a couple of hard-coded codes within the Prezi output:
landing_data=bHVZZmNaNDBIWnNjdEVENDRhZDFNZGNIUE43MHdLNWpsdFJLb2ZHanI5N1lQVHkxSHFxazZ0UUNCRHloSXZROHh3PT0

and
landing_sign=1kD6c0N6aYpMUS0wxnQjxzSqZlEB8qNFdxtdjYhwSuI

Is it known what these codes are used for? I have never used the Prezi service before and looking at some public content on their site I noticed that these values seem to vary for each video.

I don't personally know. I presume they're some sort of identifier, but I don't use Prezi, personally. Hmm.

Looking at the names of the attributes they seem like they might be tracking codes. Do we know if the embeds will reliably work with these removed entirely?

I have sent an E-mail to Prezi to learn more about these attributes.


On screen click thorough notifications

Description of the new feature / enhancement
On screen notifications can be added for specific events:

Caps Lock
Keyboard layout change
Timer
Web Hook on localhost
System events

Every notification type can have a sound option, positioning (screen center, top right corner and etc.), color, text color and transparency, shape and etc.
Scenario when this would be used?
I was thinking of some events that can happen unnoticed, or events lack of a noticeable feedback. For example I've accidentally pressed caps lock and since I'm not looking on keyboard there is no way to know this until I've started typing. And if I'm typing a password that is masked by * I would never know that. The same for the language switch.
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/981


Sync finalizers for OAuth2Client resources

Fix for issue with colliding updates on Oauth2Client and eventing manifest (see issue)

/retest-required

/retest-required

/retest-required


Web UI shows lacking permissions for listing clusters after organization creation

Shortly after creating a new organization, I navigate to the Clusters page and see this:

The reason seems to be that role bindings haven't been created in the new organization's namespace yet.
Even after keeping this page open, the state does not change. To the user, this gives the false impression that they cannot create a new cluster in the organization.
A reload at this point turns the page into a functional state.
Expectation
The page should

automatically update to reflect that the user has permission to create a cluster.
show a message that permissions for the new organization might not be configured yet.

It seems as if role bindings are created only seconds after the namespace is in place. A refresh every 10 seconds, for example, would allow to catch the permission change early.
Details
This occurred on CAPI, both CAPA and CAPZ.

It might take a couple of minutes. For example, if we get a new org, permissions will be added as soon as the org  namespace is reconciled. This would happen instantly in operators based on kubebuilder but I  think it could be up to 5 minutes in this case since rbac-operator is older and based on our own operator functionality.

Thanks @anvddriesch ! In that case it would be good to add a message after org creation.


Some fixes for Go 1.13

Bumped Go min version to 1.13 to avoid incompatible builds
Fixed go-cloudstack module version (now correctly semantically versioned) -> Reported here https://github.com/xanzy/go-cloudstack/issues/125 - but was already fixed by the author
Fixed k8s module checksum -> Probably this issue https://github.com/kubernetes/kubernetes/issues/69040

@onitake can you update this and see if we should consider Go v1.15 now?

@onitake can you advise when this is ready for merging, thnx

Hi @rhtyd it's actually not necessary to require Go 1.15.
go.mod should reflect the minimum version required to build the module, which is 1.13. See here: https://golang.org/doc/go1.12#modules
But I'll gladly update the Dockerfile so 1.15 is used for standard builds. Are you ok if I commit this into this PR?
On another note:
Since Go modules are pretty much the standard now, it would probably be ok to drop the vendored dependencies. What do you think? go.mod and go.sum will ensure the right trees are fetched anyway.

I'm okay with the changes, but unable to review or test this. I can merge if you or any other collaborators can do a single review/lgtm and show any tests. Happy to merge then, thanks.

Thanks, @rhtyd .
It would be good if we have some automated builds/tests anyway. These kinds of PRs should be easy to test.

@onitake we've Travis integration for all apache repos, can we leverage that?

@onitake you may log a ticket with ASF INFRA (https://issues.apache.org/jira/projects/INFRA) to enable Travis support https://travis-ci.org/github/apache/cloudstack-kubernetes-provider

I think I can write a quick .travis.yml file to do a gobuild and a gotest.
For a proper integration test, we need some kind of of simulation of the CS API. If I remember correctly there is a container that can be used for this purpose? Do you know where I can find it and how to use it for automated testing?
Thanks!


Package naming: plural vs singular

Author the user story for this feature
As a user, I want to make sure that the code is well organized so I can get new features faster.
Is your feature request related to a problem? Please describe.
We might have some package naming mismatch:
data.adapter but data.repositories
data.model but presentation.models
Describe the solution you'd like
Come up with guidelines on when to use singular and plural package names.
Update documentation.
Update codebase according to the new guidelines.
Additional context
https://softwareengineering.stackexchange.com/questions/75919/should-package-names-be-singular-or-plural
cc: @solid-yuriiuvarov

BR: take time till the next week