Unity crashes in PeerConnection_Create

Hello! Whenever my application calls Microsoft.MixedReality.WebRTC.PeerConnection.InitializeAsync(), Unity crashes.
Here is a stacktrace from the Editor.log:
  at <unknown> <0xffffffff>
  at (wrapper managed-to-native) Microsoft.MixedReality.WebRTC.Interop.PeerConnectionInterop.PeerConnection_Create (Microsoft.MixedReality.WebRTC.Interop.PeerConnectionInterop/PeerConnectionConfiguration,intptr,intptr&) [0x0006f] in <d82031f03e4a471c85b553ce27ddc643>:0
  at Microsoft.MixedReality.WebRTC.PeerConnection/<>c__DisplayClass71_0.<InitializeAsync>b__0 () [0x00029] in <d82031f03e4a471c85b553ce27ddc643>:0
  at System.Threading.Tasks.Task.InnerInvoke () [0x00010] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Threading.Tasks.Task.Execute () [0x00011] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Threading.Tasks.Task.ExecutionContextCallback (object) [0x00006] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) [0x00073] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) [0x00004] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Threading.Tasks.Task.ExecuteWithThreadLocal (System.Threading.Tasks.Task&) [0x00054] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Threading.Tasks.Task.ExecuteEntry (bool) [0x0005e] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Threading.Tasks.Task.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem () [0x00002] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Threading.ThreadPoolWorkQueue.Dispatch () [0x00075] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback () [0x00000] in <437ba245d8404784b9fbab9b439ac908>:0
  at (wrapper runtime-invoke) <Module>.runtime_invoke_bool (object,intptr,intptr,intptr) [0x0001f] in <437ba245d8404784b9fbab9b439ac908>:0

And here is the thread stack trace from the error.log:
Stack Trace of Crashed Thread 25440:
0x00007FFD7B0831FA (Microsoft.MixedReality.WebRTC.N) Microsoft::MixedReality::WebRTC::DataChannel::Send
0x00007FFD7B087729 (Microsoft.MixedReality.WebRTC.N) Microsoft::MixedReality::WebRTC::DataChannel::Send
0x00007FFD7B087359 (Microsoft.MixedReality.WebRTC.N) Microsoft::MixedReality::WebRTC::DataChannel::Send
0x00007FFD7B082B33 (Microsoft.MixedReality.WebRTC.N) Microsoft::MixedReality::WebRTC::DataChannel::Send
0x00007FFD7B07DC10 (Microsoft.MixedReality.WebRTC.N) mrsPeerConnectionCreate
0x000001E5A96CDC10 (Microsoft.MixedReality.WebRTC) Microsoft.MixedReality.WebRTC.Interop.PeerConnectionInterop.PeerConnection_Create()
0x000001E5A96CC5BB (Microsoft.MixedReality.WebRTC) <>c__DisplayClass71_0.<InitializeAsync>b__0()
0x000001E50A7EED41 (mscorlib) System.Threading.Tasks.Task.InnerInvoke()
0x000001E50A7EE3FA (mscorlib) System.Threading.Tasks.Task.Execute()
0x000001E50A7EE23B (mscorlib) System.Threading.Tasks.Task.ExecutionContextCallback()
0x000001E50A7ECA79 (mscorlib) System.Threading.ExecutionContext.RunInternal()
0x000001E50A7EC2FB (mscorlib) System.Threading.ExecutionContext.Run()
0x000001E50A7EA9DB (mscorlib) System.Threading.Tasks.Task.ExecuteWithThreadLocal()
0x000001E50A7E825B (mscorlib) System.Threading.Tasks.Task.ExecuteEntry()
0x000001E50A7E7E63 (mscorlib) System.Threading.Tasks.Task.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
0x000001E50A7E2FD1 (mscorlib) System.Threading.ThreadPoolWorkQueue.Dispatch()
0x000001E50A7E1AA3 (mscorlib) System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()
0x000001E50A7E1EF5 (mscorlib) <Module>.runtime_invoke_bool()
0x00007FFD7D6DCBA0 (mono-2.0-bdwgc) mono_get_runtime_build_info
0x00007FFD7D662112 (mono-2.0-bdwgc) mono_perfcounters_init
0x00007FFD7D688E41 (mono-2.0-bdwgc) mono_threads_set_shutting_down
0x00007FFD7D68B4C1 (mono-2.0-bdwgc) mono_threads_set_shutting_down
0x00007FFD7D685A78 (mono-2.0-bdwgc) mono_threads_set_shutting_down
0x00007FFD7D685806 (mono-2.0-bdwgc) mono_threads_set_shutting_down
0x00007FFDE7467BD4 (KERNEL32) BaseThreadInitThunk
0x00007FFDE92ACE51 (ntdll) RtlUserThreadStart

Environment

Platform: Unity Editor
Player: UWP
Unity version 2019.3
Target device: HoloLens 2

Additional context
I am not using the ...MixedReality.Unity.PeerConnection class because we are developing a multi-peer solution and also are making our own signaling system. Finally, we are not using Audio/Video, only the data channel. We may like to use audio later, but want to get things working with data only for now.

0x00007FFD7B082B33 (Microsoft.MixedReality.WebRTC.N) Microsoft::MixedReality::WebRTC::DataChannel::Send
0x00007FFD7B07DC10 (Microsoft.MixedReality.WebRTC.N) mrsPeerConnectionCreate

That callstack transition is impossible, mrsPeerConnectionCreate() never calls DataChannel::Send(). This most likely means you use some mismatching API for mrwebrtc.dll and the Unity scripts.
See README.md:

Note: The master branch contains the code for the next release, and therefore sometimes contains breaking API changes from the latest stable release. It is therefore not guaranteed to work with NuGet packages, which are only available for stable releases. In particular, the Unity integration scripts are only guaranteed to be compatible with NuGet packages if copied from a release/* branch.

Thanks for following up quickly.
We re-integrated the library from scratch with v1.0.3, via the webrtc release/1.0 branch (made from this commit and these Nuget packages). The problem is still happening, and my call stack is the same, it still apparently calls DataChannel::Send().
We do not have a file called mrwebrtc.dll. I believe that is a rename of the WebRTC.Native.dll to avoid the periods right? Our understanding is that our native libraries should still be called Microsoft.MixedReality.WebRTC.Native.dll in v1.0.3.
Thank you for your help. We are committed to getting this working.

Yes, I edited my answer, this is Microsoft.MixedReality.WebRTC.Native.dll in v1.0.3. I think I have seen this erroneous callstack in the past, but can't remember the details.
I've tried the following:

git clone --recursive https://github.com/microsoft/MixedReality-WebRTC.git -b release/1.0 mr-webrtc-1.0 (note the --recursive is probably useless, I thought about that later)
Create a new Unity empty project
Close Unity
Copy the Assets folder of the GitHub clone (except the Scenes sub-folder) into the newly created Unity project
Download NuGet<EMAIL_ADDRESS>Copy Microsoft.MixedReality.WebRTC.dll and Microsoft.MixedReality.WebRTC.Native.dll to the new Unity project's Assets/Plugins/Win32/x86_64/ folder.
Open Unity and load the project
Add a new empty GameObject
Add a PeerConnection component and a NodeDssSignaler component
Configure PeerConnection.Signaler = NodeDssSignaler and set some dummy Local and Remote ID values
Press Play

The Unity Editor starts playing, the PeerConnection component loads the native DLL and initialize the underlying native peer connection and library, and the Unity console displays the messages:
Initializing WebRTC plugin...
Found video capture device '...'
WebRTC plugin initialized successfully.

All as expected.
I've also checked the content of the managed DLL with ILSpy, and the content of the native DLL with dumpbin, and everything looks OK. The signature of the mrsPeerConnectionCreate() method also matches, and all arguments have the correct size on both sides (native/managed). So I see no reason for that callstack unfortunately.
I've also tried something closer to your use case : deleted the components and added a new GameObject with a custom script containing only this:
using UnityEngine;
using Microsoft.MixedReality.WebRTC;

public class MyPC : MonoBehaviour
{
    PeerConnection pc = new PeerConnection();

    void Start()
    {
        // bug in 1.0, cannot pass config: null to InitalizeAsync()
        var config = new PeerConnectionConfiguration();
        pc.InitializeAsync(config).ContinueWith(t => Debug.Log("Initialized"));
    }
}

Again when pressing Play in the Editor there's no issue and I see the "Initialized" message.
Can you please try the steps above in a new project, so we can understand if the issue is related to something you do in your app, or some configuration that can repro outside your app, and know where to look next?

Thanks again, your response helped me work through (this part of) it. I'm still getting crashes, but they are different so I can make a new issue if I get too stuck.
I believe the issue was that I was calling PeerConnection methods before initialization was complete. Also, it seems like the native PeerConnection needs to be Initialized from the main thread? Not sure if you have found this to be true for yourself. Anyway, thanks for your help. I might be back for more as I get stuck on other crashes :)

I don't think there's any requirement to call InitializeAsync(). On UWP internally it defers to the UI thread to ask for camera/microphone permission, but that's about it. Did you see some issue with this?


Coverage reports failing to upload to Codecov from Dependabot PRs

Managed to fix this by simply regenerating the token.


Investigate secure oidc provider

ErickD mentioned an oidc provider used in our secure zone.
Investigate to see how to use it to decode jwt tokens

Using the info we got from Erick D, I was able to generate a jwt and then validate it against the identityServer keys it was generated from.  The trick is to use one of the public keys from the jwks endpoint provided by the Identityserver.
I had to do it in Python because our secure environment doesn't support ruby gems.  I'm converting it to Ruby now.
This post showed me how to do it in Python: https://stackoverflow.com/questions/68891213/how-to-decode-jwt-token-with-jwk-in-python


[occm] add max_retries_down support for octavia health monitors

What this PR does / why we need it:
The PR adds new max_retries_down option support for Octavia health monitors.
Which issue this PR fixes(if applicable):
fixes #2371
Special notes for reviewers:
n/a
Release note:

Add `max_retries_down` health monitors option support for OCCM LoadBalancer global config and service annotations"

/cherry-pick release-1.26

/cherry-pick release-1.27

/cherry-pick release-1.28

/approve

I'm not sure if I'm allowed to do this, let's check.
/lgtm

@dulek can you add lgtm?

I looked briefly yesterday but not deep enough to fully understand the PR. Earliest I can look properly is tomorrow, but don't feel the need to wait for me.

@mdbooth I'm working on #2370 as well. And according to the code change, it's better to merge #2373 fix first.

@zetaab, maybe you can take a look here.

@zetaab I was hoping that the #2373 will be first :\


Vickel: Watch Insta @kidbuild

Vickel requests the watch of the watch_keyword Insta @kidbuild. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Rejected by Cody Gray in Charcoal HQ. Reason: 'This is more specific than I'd like, especially since it's a watch.'


Question: Comparison with Kaitai?

Can you tell me how Fathom compares with Kaitai? They seem to be solving the same problem in a similar way. What are reasons one might choose Fathom over Kaitai or vice versa?
(Sorry to open an issue, but this repo doesn't have the Discussion section enabled.)

Fathom is still at an early stage, so in terms of practical application Kaitai can do more things right now. However what we are aiming for is to see if basing a data description language on dependent type theory gives us the power to handle structures that Kaitai cannot describe, such as the interdependencies between tables in OpenType, without being overwhelmed with complexity.

That answer is much more interesting than I could have hoped for! Super cool. I'm staring so I can check back in. I see the repo is ~3 years old. Is it a personal research project with high ambitions, or a "slow and steady wins the race" situation? How has progress been?

There has been a lot to do! To begin we needed to understand the fundamentals of how to implement a dependent type system with bidirectional type checking and normalisation by evaluation, and explore the different options for name binding and how best to implement them in Rust, along with some detours like providing really nice error messages :sweat_smile:
Our focus for the project has been supporting the OpenType font format since we use this in Prince (our PDF formatter product) via Allsorts (our Rust font library) and it's a large and complex format that could benefit from better tools. (The code to process fonts is time consuming to write, error prone, and often a target for security exploits). The Fathom description of OpenType is not fully complete, but includes a significant slice of the specification:
https://github.com/yeslogic/fathom/blob/main/formats/opentype.fathom
In particular it can handle some of the tricky aspects like the way the hmtx table can only be parsed after reading values taken from the hhea and maxp tables, and some other table interdependencies that I believe may go beyond what Kaitai can do without awkward workarounds. It can also express the way that the GSUB and GPOS layout tables are both trees with the same branching structure at the upper levels but different leaves, using parameterised definitions.
As Fathom has grown in complexity it has been convenient to experiment with new features in separate prototypes, like doodle, which has no type checking or syntax or fancy error messages at all but can parse JPEG, PNG, and GIF images, at least syntactically (it doesn't render the images, just traverses the image structure). Hopefully we can fold these new features back into Fathom as we shake out which ones work and release some demos as we go.
Ultimately I'd like to see this language capable of comfortably describing most of the binary formats we work with day to day, with tools to visualise and explore and validate them as needed. It's been a long project -- the Mercury prototype dates from 2014 -- and this is still an active area of research, but it seems promising!
Do you have a general interest in parsing binary file formats, or are there any specific data formats that you work with? It's always interesting to hear what other people are doing in this space.

There has been a lot to do!

Of course, that seems obvious now.
I assume your language will necessarily take a different approach to Kaitai and other similar efforts. But I wonder if the impedance mismatch is small enough to make it possible to translate from Kaitai's language to Fathom's, which would give you a nice library of formats with presumably very little effort. I've felt like other projects in various problem domains have missed out on some low hanging fruit by not doing something similar, and I wonder if it's because machine translation is perceived as intimidating by a lot of programmers. You don't strike me as such a person, though.
I had forgotten I stumbled on Fathom by way of Allsorts during a late-night fall down a rabbit hole. I think Documentation of OpenType shaping behavior  is a brilliant idea. I love projects like that. No, I don't have a particular binary format in mind that motivates my interest. The problem you are solving, though, simultaneously involves several of my intellectual interests: languages and parsing, the economies of specialization, really good abstractions—especially ones that compose really well...
If you are not already familiar with Raph Levien’s blog, you should check it out. I love his two articles on Simplifying Bézier paths and Parallel curves of cubic Béziers. He also has implementations in Rust on GitHub. There are more great things in his mental pipeline that I look forward to.


Python Bindings

As a plugin developer, I dont necessarily want to use Java to build my plugin. Python would be preferable
Maybe take a look at JEP for a solution to this

Anything javafx related will probably have to be java only 🤔

Closing this, as #42 will solve the underlying issue of "java is annoying to deal with, so I want a scripting language instead"


logout is called right away after login

I am trying to switch from oidc-client and I see that after login logout is called by oidc-client-ts. I noticed that when I remove from localStorage this item:

it starts logging in correctly.
This is oidc-client-ts settings:

Where is this item set?

To find out why its automatically logs out, you can enable logging within this library like described here.

This issue (question) staled, closing it for now.


Incorrect Phone length for Gabon

The current phone length for Gabon (7) is not the valid one: 9

Fixed with d56bf88


XLA: Cannot get IR on TPU

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Google Colab environment
TensorFlow installed from (source or binary): Google Colab environment
TensorFlow version (use command below): 2.5.0
Python version: 3.7

Describe the current behavior
Code is in https://github.com/hjmus/mock/blob/master/TPUs_in_Colab.ipynb. I was trying to get HLO IR when running tf.function on TPU, by using experimental_get_compiler_ir(), but run into the following error:
ValueError: No matching device found for '/job:worker/replica:0/task:0/device:TPU:1'

Describe the expected behavior
Be able to get IR when running on TPU.
Standalone code to reproduce the issue
https://github.com/hjmus/mock/blob/master/TPUs_in_Colab.ipynb
Other info / logs
The purpose of this exercise is to check out the IR generated for GSPMD (https://arxiv.org/pdf/2105.04663.pdf).
#comp:xla #XLA

I was able to reproduce the issue in tf v 2.5 and nightly,in v2.4 i am facing different error.Please find the gist of it here.

@hjmus
Can you please refer to this comment and let us know if it helps.

@Saduf2019
Hi Saduf2019, I was already using the suggested API:
try:
  tpu = tf.distribute.cluster_resolver.TPUClusterResolver()  # TPU detection
  print('Running on TPU ', tpu.cluster_spec().as_dict()['worker'])
except ValueError:
  raise BaseException('ERROR: Not connected to a TPU runtime; please see the previous cell in this notebook for instructions!')

tf.config.experimental_connect_to_cluster(tpu)  # <<= here
tf.tpu.experimental.initialize_tpu_system(tpu)
tpu_strategy = tf.distribute.experimental.TPUStrategy(tpu)

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Azure Service Data Integration with MLW Template

All Submissions:

[YES] Have you followed the guidelines in our Contributing document?
[YES] Have you added an explanation of what your changes do and why you'd like us to include them?
[YES] I have updated the documentation accordingly.
[YES] I have added tests to cover my changes.
[YES] All new and existing tests passed.
[YES] My code follows the code style of this project.
[YES] I ran lint checks locally prior to submission.
[YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

What is the current behavior?

Issue Number: N/A
What is the new behavior?

New template is added to the templates folder that performs the data integration using ml module
The SQL dataset/linked is removed as it was very specific to this use case and we wanted to have adf module as general as we can

Does this introduce a breaking change?

[NO]

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information

/DRAFT

/assign @TechnicallyWilliams  @nmiodice

ML is out of my area of expertise but I gave it a good one over. Templates along with tests present no red flags.


version 1.2.5? I saw there's a wheel, but what is the release?

Can't see a tag or release on github.
Thanks!

I assume it is this commit:
https://github.com/pythonlessons/mltu/commit/6daf202509b897740a0bd287f32c53baccfb8c1f
But it would be good to have a "proper" tag and equivalent release 🙏

@seidnerj Thank you for this, somehow made a release, but forgot to make it on GitHub... doing it now

@seidnerj Thank you, made a release :)

Thank you 🙂🙏


Pytest failing due to unexpected keyword argument 'omit_if_default'

The problem
Pytest fails due to unexpected keyword argument 'omit_if_default'
Expected behavior
pytest succeeds
Steps to reproduce the behavior
$ python -m pytest
ImportError while loading conftest '$HOME/repos/requests-cache/tests/conftest.py'.
tests/conftest.py:30: in <module>
    from requests_cache import ALL_METHODS, CachedSession, install_cache, uninstall_cache
requests_cache/__init__.py:7: in <module>
    from .backends import *
requests_cache/backends/__init__.py:7: in <module>
    from .base import BaseCache, BaseStorage, DictStorage
requests_cache/backends/base.py:22: in <module>
    from ..serializers import SERIALIZERS, SerializerPipeline, SerializerType, pickle_serializer
requests_cache/serializers/__init__.py:26: in <module>
    from .preconf import (
requests_cache/serializers/preconf.py:26: in <module>
    base_stage = CattrStage()  #: Base stage for all serializer pipelines
requests_cache/serializers/cattrs.py:55: in __init__
    self.converter = init_converter(factory, **kwargs)
requests_cache/serializers/cattrs.py:84: in init_converter
    converter = factory(omit_if_default=True)
E   TypeError: Converter.__init__() got an unexpected keyword argument 'omit_if_default'

### Environment
- requests-cache version: 0.9.7
- Python version: 3.10.7
- Platform: manjaro/arch

Can you show me the output of pip freeze? An older version of cattrs could be the problem.

Confirmed that this occurs with cattrs <=22.1. That's going to be a confusing error for most people, though, so I added handling for this in main. I could release a patch for this for 0.9 if needed, but first I'd like to figure out why cattrs didn't get updated. The pinned minimum version is 22.2, and that's in the package metadata, so pip/poetry/etc. should have updated that for you.
@gsalvatella Did you encounter this by checking out the requests-cache repo locally? Or did you install requests-cache from PyPI? If so, what version of pip (or other package manager) do you have?

I confirm that my system is using  cattrs==22.1.0.
This problem shows up both in locally checked out repo and during installation of the AUR package python-requests-cache.  I see now you have addressed this in https://aur.archlinux.org/packages/python-requests-cache. It seems indeed that the cattrs package version is correct in the arch repository, but for some reason it still shows 22.1 with pacman -Ss python-cattrs...

I think you can close this issue. python-cattrs has been updated now.

Good to know, thanks!


Add the ability to toggle the popup window

It would be nice to have a command that will toggle the popup . Right now when I call LspOverloadsSignature when it's already shown it just draws it again instead of hiding it

Hi @excvai - For sure. I've had this thought also. While my attention is on https://github.com/Issafalcon/neotest-dotnet at the moment, I have a couple things to sort out with that first, then I plan on making some more enhancements to lsp-overloads, including this.

@excvai - Sorry for the wait! Shame how the day job gets in the way! 😄
The linked PR is merged and should fix this issue, and some others.

@Issafalcon Are you talking about LspOverloadsSignatureAutoToggle? Unfortunately, it doesn't seem like solving my problem. Yes it prevents the signature from showing by default but what I wanted is the ability to hide the signature by executing LspOverloadsSignature when it's already shown. Right now LspOverloadsSignature works as it worked before

Hi @excvai - I mean that the built-in key mapping to close the signature window (when open) should enable you to get that "toggle" behaviour.
It was easier to implement this mechanism than to overload the LspOverloadsSignature command. So while it isn't a true 'toggle', the README shows how to create a toggle effect by mapping the same keybind in the config that closes the signature.
If you are unable to do this for whatever reason, let me know.

It works perfectly! Thanks!!!


TCPMappings! and test infrastructure improvements, round 1

TCPMappings work now (including with SNI) and we're combining HTTP KAT backend services into superpods, so instead of starting 80-something of them, we start... 3.

@richarddli and @nbkrause, if you folks can look at the docs I've added, that'd rock.

I added a couple comments on the docs, but the docs LGTM otherwise.


would like a pipeline for karma unit testing

A pipeline that would bundle configuration and running of karma, for both TDD and CI workflows.  Similar to https://github.com/kenzanlabs/pipeline-test-node, we want all karma configuration bundled and two methods

tdd - auto watches, reloads, for local testing
ci - single run, no watcher, for a build server

Repo has been created for this already. Will continue progress there.
https://github.com/kenzanlabs/pipeline-test-karma

@thescientist13
I'm not able to assign to myself, but I'm starting on this today.

@paul-barry-kenzan
Try now


Fix XHTML incompatibility (fix #5852)

What kind of change does this PR introduce? (check at least one)

[X] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[X] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[X] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[X] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[X] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This change is compatible with text/html and application/xhtml+xml documents.

Thanks a lot for the PR, this ended up being added at d3a161b
We should have merged the PR, I'm really sorry we didn't 🙇


[Bug]: incorrect npm command in docs

Version
Latest

Details
In the docs page, when looking at migration from vite to rsbuild seems like the commands for removing and vite dependencies and adding rsbuild dependencies are for yarn. You don't run add or remove with npm, as far as I know.
Reproduce link
Yuor docs
Reproduce Steps
Go to your docs page.

npm CLI supports add and remove too, they are aliases.
https://docs.npmjs.com/cli/v10/commands/npm-install#synopsis


[Feature request]: Update Icon (suggestion)

Version

[X] I'm using version 1.15.1

Existing requests

[X] I've checked Existing requests

Advanced Preferences

[X] I've checked Advanced Preferences

What operating system are you using?
macOS
Operating System Version
Sonoma 14.4.1
Problem description
It's not a problem really. I noticed the app icon isn't optimized - mainly its code.
Possible solution
I updated the app's icon design. I didn't change its overall look dramatically; but redrew it in 64px grid and rounded all of its anchors and handles' coordinates. The main purpose is to optimize the code (lighter file size) and to achieve a better legibility in smaller sizes.
Light mode:

Light mode (paused):

Dark mode:

Dark mode (paused)

Alternative solutions
I hope my edits make the icon more legible.
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi what files did you edit? there is a lot of files :)
https://github.com/hovancik/stretchly/tree/trunk/graphics
https://github.com/hovancik/stretchly/tree/trunk/app/images/app-icons


.set() method should add the key value if its not present

I have this JSON with me
[
    {
      "msg": "hello",
      "_uuid": "1483f2e6-1241-4e84-9fbf-503ce5ea64df"
    },
    {
      "msg": "hello",
      "child": {
        "timestamp": "any_timestamp"
      },
      "_uuid": "dbe96d86-4542-4bbd-b64e-f31d69fa735b"
    }
]

I am executing this code to update the timestamp value
DocumentContext collections_doc =<EMAIL_ADDRESS>== 'hi')].child.timestamp","new_timestamp");

Its just updating the first child.timestamp, is there any solution so that if object don't have any key, then it will be created.

@kallestenflo Any updates on this issue, mentioning you here because this might be the important one.


Add support for 17track.net package sensors

Description:
This PR adds support for package tracking via 17track.net. The platform provides sensors denoting the number packages in a current state ("In Transit", etc.) as well as individual sensors for each package that include tracking number, etc.
Related issue (if applicable): N/A
Pull request in home-assistant.io with documentation (if applicable): https://github.com/home-assistant/home-assistant.io/pull/7303
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: seventeentrack
    username: <USERNAME>
    password: <PASSWORD>
    show_archived: true
    show_delivered: true

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

Can be merged when build passes and comment addressed.


Children changes are not reflecting on ES.

@toluaina can you help me troubleshoot this issue?
PGSync version: 2.3.2 (pulled from main branch)
Postgres version: PostgreSQL 14.5 (Debian 14.5-1.pgdg110+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 10.2.1-6) 10.2.1 20210110, 64-bit
Elasticsearch version: 8.4.1
Redis version: redis-cli 6.0.16
Python version: 3.10
Problem Description: If I make any changes in child table. changes are not reflecting on ES. but, I get this instead in logs.

Mode: daemon
Additonal Info: I have added plugins for transformation.
Observation: If I rerun pgsync without daemon mode previous changes to child table will reflect to ES index.
schema.json
[
    {
        "database": "voice-analytics-2",
        "index": "calls-synced",
        "plugins": [
            "comment"
        ],
        "mapping": {
            "reactions": {
                "type": "nested"
            }
        },
        "routing": "call_id",
        "nodes": {
            "table": "calls_comments",
            "columns": [
                "id",
                "call_id",
                "text",
                "parent_id",
                "type",
                "call_location",
                "created_by",
                "created_at",
                "updated_at",
                "updated_by"
            ],
            "transform": {
                "rename": {
                    "id": "commentId",
                    "text": "commentText",
                    "parent_id": "parentId",
                    "created_by": "createdBy",
                    "created_at": "createdAt",
                    "updated_at": "updatedAt",
                    "updated_by": "updatedBy"
                }
            },
            "children": [
                {
                    "table": "calls_comments_reactions",
                    "columns": [
                        "code",
                        "created_at",
                        "created_by"
                    ],
                    "transform": {
                        "rename": {
                            "code": "reactionCode",
                            "created_by": "createdBy",
                            "created_at": "createdAt"
                        }
                    },
                    "label": "reactions",
                    "relationship": {
                        "variant": "object",
                        "type": "one_to_many",
                        "foreign_key": {
                            "child": [
                                "comment_id"
                            ],
                            "parent": [
                                "id"
                            ]
                        }
                    }
                }
            ]
        }
    }
]

Hard to tell from the screenshot.
Can you re-run bootstrap to ensure your changes to the db schema are up to date?
also I am guessing you made changes to calls_comments_reactions
does this work correctly without the transforms?
is there a reason why you have explicit foreign keys and is this correct for the db schema?

I had the same issue, can confirm - detects changes to child documents if transformation is removed

This should be addressed in the latest release.
Can you please try 2.5.0 or off the main branch please?


Feature/saa 462 add transfers to unlock events

Codecov Report
Patch coverage: 79.48% and project coverage change: +0.68 :tada:

Comparison is base (8aeaf88) 76.36% compared to head (d72680f) 77.05%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #223      +/-   ##
============================================
+ Coverage     76.36%   77.05%   +0.68%
- Complexity     1162     1188      +26
============================================
  Files           199      200       +1
  Lines          4951     4972      +21
  Branches        191      185       -6
============================================
+ Hits           3781     3831      +50
+ Misses         1051     1024      -27
+ Partials        119      117       -2

Impacted Files
Coverage Δ

...activitiesmanagementapi/util/TransformFunctions.kt
78.96% <70.00%> (+5.44%)
:arrow_up:

...tiesmanagementapi/service/ScheduledEventService.kt
81.96% <71.73%> (+3.01%)
:arrow_up:

...agementapi/client/prisonapi/api/PrisonApiClient.kt
99.29% <100.00%> (+0.04%)
:arrow_up:

...activitiesmanagementapi/common/LocalDateTimeExt.kt
100.00% <100.00%> (ø)

...s/hmppsactivitiesmanagementapi/entity/EventType.kt
100.00% <100.00%> (ø)

...tiesmanagementapi/model/PrisonerScheduledEvents.kt
100.00% <100.00%> (+5.26%)
:arrow_up:

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


TypeError: Union[arg, ...]: each arg must be a type. Got True.

models/huggingface.py includes some type indicators of the form
quantized: Optional[Union[True, str]] = None,

which in a clean Python 3.10.11 conda installation leads to an error
TypeError: Union[arg, ...]: each arg must be a type. Got True.

In Python 3.11 no error is thrown.
Possible solutions:

Set python_requires=">=3.11"
Change the type indicator to Union[bool, str]

Hi,
I also got this error. I was running a command that worked perfectly fine 2 weeks ago, but I pulled the latest code now and the same command is throwing error!
Is there any quick fix other than reverting to the branch I worked on!
Will be very much appreciated :)


Move scanning code outside of scannable.py

Description
The scan.scannable module contains deals with two topics: scanning documents and loading documents from files or commits.
The scanning code should be moved in a separate, secret-specific, module to make scannable simpler. This would improve the architecture of our code, for example the IAC commands use scannable to read files, but they do not need the secret-oriented scan() method.
Proposed reorganization

Rename the scan package to secret. This matches the existing iac package.
Move secret scanning code from scannable to secret:

Files.scan() to a secret.scan_files(files: Files) function.
Result, Error, Results as secret classes.

Move ScanCollection to output: it can't go to secret because it contains iac_result, so it's not secret-only
Move the rest of scannable (File, Commit, Files, CommitFile and related parsing code) to core.scannable
(Bonus) Move utils.ScanMode to secret
(Bonus) Move utils.Filemode to core.scannable, or remove it if it turns out we don't need it

Definition of Done

scan package does not exist anymore
core.scannable does not depend on any secret-related code (no import of pygitguardian, no network-related code)
core.scannable does not depend on any iac-related code

A suggestion : should we rename ScanMode to SecretScanMode for clarity and in case we introduce different modes for other scanning capabilities ?

A suggestion : should we rename ScanMode to SecretScanMode for clarity and in case we introduce different modes for other scanning capabilities ?

Good idea, amending the description.


chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml

Describe the PR
The package github.com/ghodss/yaml is no longer actively maintained. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml. It is actively maintained by Kubernetes SIG, and also widely used in K8s projects.
The notable change is that github.com/ghodss/yaml uses gopkg.in/yaml.v2 v2.2.2, but sigs.k8s.io/yaml uses gopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.
Relation issue
Additional context
https://github.com/ghodss/yaml
https://github.com/kubernetes-sigs/yaml

@Juneezee Thanks for your contribution.


🐞 Regression/Bug | Crowding column not collapsed properly on routes w/o crowding

Summary of changes
Asana Ticket: 🐞 Regression/Bug | Crowding column not collapsed properly on routes w/o crowding
Introduced a CSS class to add to the parent element to handle hiding all the crowding icons when needed.

Before getting review, please check the following:

[x] Does frontend functionality render and work correctly in IE?
[x] Have we load-tested any new pages or internal API endpoints that will receive significant traffic?
[x] Are interactive elements accessible to screen readers?
[x] Have you checked for tech debt you can address in the area you're working in?
[x] If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?
[x] Are the changes organized into self-contained commits with descriptive and well-formatted commit messages?

👍  Looks great!


[BEAM-12164]: add metrics for partition reads, queries, and latencies for Spanner Change Streams Connector

This change adds the following Dataflow custom metrics:

ACTIVE_PARTITION_READ_COUNT
QUERY_COUNT
DATA_RECORD_COMMITTED_TO_EMITTED_0MS_TO_1000MS_COUNT
DATA_RECORD_COMMITTED_TO_EMITTED_1000MS_TO_3000MS_COUNT
DATA_RECORD_COMMITTED_TO_EMITTED_3000MS_TO_INF_COUNT

@hengfengli it seems CI failure is unrelated?
11:06:10 * What went wrong:
11:06:10 Execution failed for task ':runners:flink:1.14:test'.
11:06:10 > Failed to store cache entry for task ':runners:flink:1.14:test'

@thiagotnunes Yes, it is unrelated.

this LGTM

Run Java PostCommit

LGTM


Add permissions to the kodata directory.

I suspect that this may be a source of problems reading kodata with nonroot,
but it is probably worth doing either way.

Additionally, windows can only set 0222, 0444, or 0666, none of which are executable.

For my curiosity do you have a reference/link?

@dprotaso this is copy/pasta from (IIRC) @evankanderson's comments elsewhere in this file.


CommonMark adherence

Is it possible to get this library there, or would it make more sense to crate a new one?
If it makes sense for this library.. what is there to do?

We found:

https://github.com/kivikakk/comrak
https://github.com/raphlinus/pulldown-cmark

the later of which we are using now.


Issues with single file requirements

I'm just getting started using this project to manage requirements/test cases.
I'm attempting to create a project that has one file per requirement (then the git log for that file captures the entire requirement history quite neatly).
I'm attempting to include multiple requirements under a single heading using the sphinx include directive, but sphinxcontrib-needs is complaining of duplicate requirement IDs. My best guess is that sphinxcontrib-needs is searching the tree for requirements irrespective of whether the documents are included in any TOC. So if i use the include directive i get two copies, and if i don't use it I have one copy of the requirement but it's not in the output. Does that make sense?
How can I structure my project so that I have one file per requirement (without having a separate heading for each requirement)?

update: i've gotten this to work by changing the file extension on the single-file requirements to confound whatever search is taking place. Not ideal.
Is there a better way?

This behavior is related to Sphinx itself.
Sphinx builds all rst/md files, whether they are included, referenced in toctree or something else.
It is enough to have somewhere a rst-file below your conf.py and it get built.
However, you can use the exclude_pattern: https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-exclude_patterns
So putting everything in a single folder, add it to exclude_pattern and then include wherever it is needed should work.
Or have a prefix for all of your requirement-files, like req_123.rst and use this in the pattern.

Thanks for the quick response! That gets me out of trouble

the way i solved this was by not excluding the files, but suppressing the "not included in any TOC" warnings by putting :orphan: directives at the top of each file, and then generating a list of the requirements using a needextract


Lookup by a ref attr

If the user has a unique ref attr with cardinality one, this allows them to use lookup to update an entity in the namespace using forward-name.id as the lookup key.
Here's an example:
If the user_prefs namespace has a unique link to users, then the developer can update user_prefs with:
tx.user_prefs[lookup("users.id", userId)].update({new_pref: 'new-value})

Updated the backend to support this with the admin api.
I attempted to solve the problem where you can't create a new entity with a lookup set the lookup value at the same time, but could not find any easy solutions, so I just gave it a better error message. Now when you do:
db.transact([
    tx.users[lookup('handle', 'h')].update({handle: 'h'})
]);

It will throw a validation error with message: "Updates with lookups can only update the lookup attribute if an entity with the unique attribute value already exists."

Woohoo!


Using auto-update

UpdateCache uses threadDelay. The dedicated process always wakes up every second even if no query is requested. We should use Control.AutoUpdate in auto-update to solve this issue.

Control.AutoUpdate simply uses threadDelay, so replacing it does not seem to change the situation.
https://hackage.haskell.org/package/auto-update-0.1.6/docs/src/Control.AutoUpdate.html#mkAutoUpdate
Wouldn't it be more important to calculate the time to sleep so that it is more efficient?

Control.AutoUpdate for TimeCache
Control.Reaper for UpdateCache

Control.AutoUpdate for TimeCache resolved by #16

Closing.


Fixes to cli ember support (followup on #4309)

In reference to comment: https://github.com/storybooks/storybook/pull/4309#issuecomment-427808091
This PR corrects app detection when 'react' has also been added to package.json and fixes detection of storybook configuration.

Thank you @fran-worley !


Use new streaming multi-part

We've added a streaming multi-part to REST. This is in support of optic API for now. But I'm guessing it could benefit DMSDK ExportListener by extension.  The goal would be to enable faster time-to-first-byte for export consuming applications.  For ExportListener this would allow sending the first documents to onDocumentReady listeners while the rest of the batch of documents is still being read.

Performance engineering didn't find the expected benefits.


Visualizing Attention Weights

Hi, thank you and congratulations on your excellent publication. I was wondering if there were ways to visualize attention weights with this pipeline. I am aware that this uses Dilated Attention and was wondering if you had any suggestions. Thanks for your help.

Hi thanks for reaching out! This is a good question. We haven't tried that because the LongNet internally avoids computing and storing the whole attention matrix to reduce the IO and memory cost.


Retool all of the sstv script into an sstv container image

I guess this is expanding to include the basic UI components too, lol.


Perform Memory Polynomial.vi in DPD RDLs won't work

The Memory Polynomial Results cluster that is fed with the output of the Apply Digital Predistortion.vi mainly has default values from the cluster constant. However, this cluster is then passed to the Download Waveform.vi which then works on the default waveform name (instead of the previously uesd one) and which doesn't have bandwidth, burst length or runtime scaling information to set them correctly to the SG.
In order to apply the changed values correctly to the SG a Set Script to Generate.vi is missing. That might be omitted, too, if the waveform name doesn't change, however I have experienced different results in the AM/AM plot when doing this compared to setting the script to generate again.

According to my understanding the set script is necessary to apply the playback library settings down to SG driver. I think it is mandatory.

Modified Perform Memory Polynomial.vi to pass the waveform parameters to memory polynomial results cluster. Changes are applied to commit https://github.com/NISystemsEngineering/rfic-reference-design-libraries-labview/commit/88000299dccf81e71159bcfdfe114fff1b07c476

Fixed the Set Script to Generate with commit fdccf2a9


updates Quarkus to 2.16.7

What this PR does:
Updates Quarkus to 2.16.7. This version will be in the 2.0.13 release, after that we are switching to Quarkus 3.

Had to cherry-pick test changes that we had to do with Quarkus 3.x from d816cb2, seems it was back-ported to 2.16.7 as well.
Same with 0df44df

@ivansenic Why new test cases for quarkus upgrade?

They are not new, just extracted inner classes to the concrete classes. This setup is not working anymore, there was some regression.


The ability to index a type by a key for another type

I would like the ability to do the following:
type HealthData = { health: number }

type HealthState = { amount: HealthData["health"] }

This would be useful for a use-case I have where I am generating "partial" types of components, and would like for them to be able to point back to the original types, but currently have to just use any.

oh just do
--!strict
type HealthData = { health: number }

type HealthState = { amount: typeof(({} :: HealthData).health) }

Neat trick! Though you must admit it's fairly clunky comparitively.

More conventionally, you can also just do this:
type HealthValue = number
type HealthData = { health: HealthValue }
type HealthState = { amount: HealthValue }

It does irk me that the relationship between all these types exists in text only, though. The type checker doesn't differentiate between a HealthValue and a number. The same is true in kiruda's solution too. It's the biggest flaw in the type system right now imo: every type is either just a primitive type, or a list of things which must be reduced to primitive types, so it renders type HealthValue = number into something that does nothing to help make the codebase more type safe except to signal to readers of code that these types are intended to be related and that a HealthValue  is supposed to be a thing even thought it actually isn't.

I'm going to put this and other issues suggesting features for type-level computation in the icebox for now - the use case makes sense, but we currently aren't ready to contemplate this class of features for the type checker, as we have a solid roadmap for type checker fundamentals and a large rework of much of type checking in progress. Once we're solid on that we will reevaluate issues from the icebox, but for now that makes tracking easier.


[Bug] monday.storage.instance.setItem does have wrong types

Describe the bug
For monday.storage.instance.setItem there seem to be wrong types.
Steps to reproduce

Embed the SDK in an app
Call monday.storage.instance.setItem
Check the parameter types that can be passed to the method

Also check implemented types: client-data.interface.ts

Expected behavior
According to the documentation and the implementation of the storage, it should be possible to also pass additional options like the previous_version attribute. Those types are not being reflected correctly in TS.
So I would assume the method to work like:
monday.storage.instance.setItem('some_key', myJsonData, {previous_version: previousVersion})

Context and environment
Tested using the sdk on client side in a widget.

I see that what you're stating is shown in one of the examples in the docs (in the Versioning example), but not in the methods tables. I could add the missing parameter, but I can't find a full list of the available options, and I don't want it to be incomplete. Is there a list buried somewhere with the possible options to be passed to setItem?

@yuhgto can you take a look at this? Do you have the options documented somewhere?

Hi @zivnadel,
I just got the confirmation from the monday crew that you can only pass previous_version inside the options. So should be fine to go only with this one attribute 👍🏻

@eidermaen the 'previous_version' is a string, right?

@zivnadel Correct, at least what I could see from the response object when running the code.

Fixed in #87


Feature: Better-Integrate Metric Details / Analysis Output

Feature Details
Analysis Output should act like the plots: It should show everything, but, when a site is selected, that site should be highlighted. Likewise, when a row is clicked, that site should become selected in the drop-down.
Example Code

Possible Implementation

Additional Comments
Like with the plots, we'll need to be careful that the multiple inputs defining the same variable play nice.

Note: This is out-of-scope for {gsm}, so we'll use js on the {gsm.app} side to implement it here specifically.


References in owned entities?

Is it possible to have relational columns / navigation properties in owned entities?
For example:
public class User {
  ...
}

public class Picture {
    ...
  public ICollection<Comment> Comments { get; }
}
public class Post {
    ...
  public ICollection<Comment> Comments { get; }
}

[Owned]
public class Comment
{
  public int UserId { get; set; }
  public User User { get; set; }

  public string Content { get; set; }
}

Where Picture and Post have an owned collection Comments, and each Comment has a reference to User.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d02e6748-42e0-000a-4945-42cd05a0b875
Version Independent ID: e3effbd0-07f2-423d-4032-1722e75adb37
Content: Owned Entity Types - EF Core
Content Source: entity-framework/core/modeling/owned-entities.md
Product: entity-framework
GitHub Login: @AndriySvyryd
Microsoft Alias: ansvyryd

Yes, this is supported. Have you run in any issues?

No, I have an existing model and wanted to ask before I start fiddling around.
Will re-open if I bump into any issues.
Thank you!

@AndriySvyryd Thank you, will report if I bump into issues.
Can a nested collection entity have an inner nested collection? How about a hierarchy?
I want to achieve this:
public class Blog {
  public int Id { get; set; }
  //shared owned collection of Comment
  public virtual ICollection<Comment> { get; set; }
}
public class Post {
  public int Id { get; set; }
  //shared owned collection of Comment
  public virtual ICollection<Comment> { get; set; }
}
public class Comment
{
  public int Id { get; set; }
  // should be the FK of either Blog or Post
  public int ForeignId { get; set; }
  //nested owned collection
  public virtual ICollection<Comment> { get; set; }
}

Is this possible?

Can a nested collection entity have an inner nested collection?

Yes, but you need to configure each level

How about a hierarchy?

Yes in theory, but I don't think it's supported in 2.2

@weitzhandler If the above is actually what you want to model it might make more sense to avoid owned collections and instead make Comment an abstract class without ForeignId with 4 implementations:
public class BlogComment : Comment
{
  public int BlogId { get; set; }
}
public class PostComment : Comment
{
  public int PostId { get; set; }
}
public class BlogCommentComment : BlogComment
{
  public int CommentId { get; set; }
}
public class PostCommentComment : PostComment
{
  public int CommentId { get; set; }
}

I can also show how to configure relationships if you'd like.
Obviously if your actual model is more complex this approach won't scale well.

Thanks for your response @AndriySvyryd.

First, I thought the Comments should have been hierarchical (like a tree), maybe it's not a good idea after all, and only allow 2 levels.
It would be nice if we can later to easily retrieve all data per user, will all comments be stored in a single table because of TPH?

The problem is I have more types I need Comments on, and I also have Vote for any of those types, and Vote should be applied to Comments too.
Is there a way to create a contained one-to-many relationship without having to have it all scattered over the entire place? In your last post, how did you mean on configuring with the ModelBuilder? For each Comment type set up a many-to-many?

I ended up creating two nullable FKs on Comment: PostId and CommentId, and set them up as two independent one-to-one optional relationships. Thank you for your advice!


Can't open http://<IP_ADDRESS>:8000

Maybe I'm being dense, but I can't seem to access the web server. I've got the containers running following the README, but navigating to HTTP://<IP_ADDRESS>:8000 brings up nothing.... What am I missing?

@writeson How do you start the app?

From a Mac terminal command line:
docker-compose -f deploy/docker-compose.yml --project-directory . up --build
Then in a browser trying to open either HTTP://localhost:8000 or HTTP://<IP_ADDRESS>:8000, neither seem to work for me.

The change you suggested, adding ./ in front of deploy/docker-compose.yml didn't fix the problem. However, adding:
ports:
  - 8000:8000

To the api service, and:
ports:
  - 3306:3306

To the db service, made HTTP://localhost/8000 return something, and the database visible to tools like DataGrip.
I am getting this message in the startup sequence though:
doug_fastapi-db-1   | find: '/docker-entrypoint-startdb.d/': No such file or directory

And HTTP://localhost:8000/health returns a 404

@writeson Yeah. Adding ports in docker-compose will definitely will solve the problem.
But I was suggesting you to try this command:
docker-compose -f deploy/docker-compose.yml -f deploy/docker-compose.dev.yml --project-directory . up --build
Because it overrides previous compose files.
Also, the correct URL for healthchecks is /api/health
You can check list of all URLs in swagger: /api/docs

It's totally ok. You'll learn everything soon. Also, by opening this issue, you may help someone who'll be struggling with the same problem as you.

where I can see the swagger UI, I have used the docker command you mentioned above. Also, I am new to this thing, can we have the documentation for this template?
As we run a fast API app on localhost, is it compulsory to require the docker?

You need to either set ports in you docker compose file, as mentioned here or find out container's IP and send request directly to it.

Docker is not required, but it makes working with application easier, because you don't need to spin up the database on your local machine.


Dashrews/ROX-13703 fix autocomplete test

Description
By default a deployment search appends a descending order by of the risk score.  So the primary order of a deployment is dictated by the risk score and not the field being searched.  This is how it works within the app.  With bleve it appears this sort was taking place after the fact whereas with Postgres it takes place with the query through the searcher.  So the test needs to utilize risk score to verify the results are returned in the order in which we expect them to be.
Checklist

[ ] Investigated and inspected CI test results
~- [ ] Unit test and regression tests added~
~- [ ] Evaluated and added CHANGELOG entry if required~
~- [ ] Determined and documented upgrade steps~
~- [ ] Documented user facing changes (create PR based on [openshift/openshift-docs]~(https://github.com/openshift/openshift-docs) and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
This is simply fixing a test.

lgtm.
The current changes are sufficient for now since the test is not enabled on postgres. Once you enable the test for postgres, you will have to update the Risk Score field on deployment as I pointed out on the JIRA.

@md2119
I did set the Risk Score on the deployment BUT I had to do so through the deploymentRanker.  Since we are using the datastore and not the store itself the risk score on the deployment is calculated/pulled from the deploymentRanker.  See:
	// Update deployment with latest risk score 	deployment.RiskScore = ds.deploymentRanker.GetScoreForID(deployment.GetId())
in upsertDeployment of central/deployment/datastore/datastore_impl.go
It is also now on for Postgres with the Makefile change.  Does any of that change your opinion on this PR?

🚢


DOC: Adding example of using Python logging with SimpleITK.

ITK issues warnings for several situations which are relevant for
debugging. These warnings are written to stderr or stdout. This is
primarily relevant for registration where the warning that not enough
points are available for estimating the similarity metric is
issued. This example illustrates how to re-route the file descriptors
so that the warnings are written to a log file.

We already have an example for integrating ITK logging and Python logging here:
https://github.com/SimpleITK/SimpleITK/blob/master/Examples/Logging/Logging.py
Having two would be confusing.
If there are messages that are occurring in ITK directly to stdout/stderr perhaps ITK should be fixed to use it's own logging system that we currently support.

There is also a pure Python logging module solution to the issue of redirecting stdout/stderr to a Python logging object.
https://stackoverflow.com/questions/19425736/how-to-redirect-stdout-and-stderr-to-logger-in-python
This more a Python logging solution and at SimpleITK one.


Bug: Warnings about optional dependencies being unavailable should be warnings at worst, not errors

For example, pf2e target damage includes an optional dependency for DF Template enhancements; If I enable it, the red warning MM+ pops implies it won't work without it, when, again, it's entirely optional.

I think this is resolved in v2.2.0 or v2.2.1... I will double check if so at some point.


Add fixes for the tests

This PR makes the following fixes to the tests:

The path is made robust.
Two imports were not correct.

Update: I am in the process of setting up CI on #8, and fixing the code to pass said CI on #9. Given that this PR is fixing some of the CI errors, I believe that it will be easier if we just merge the changes as they are currently and I finish it up on #9.


Redis doesn't work with Moodle 3.1 (and likely 3.2 as well)

We identified an issue with Moodle 3.1 when it's deployed with a Redis cache in our templates. It appears to be a Moodle issue, not a Redis issue, because this issue doesn't repro with Moodle 3.4 (or other later versions). It may be related to the Moodle issue but can't confirm precisely at this moment. We'll need to find out what versions of Moodle are incompatible with Redis and document that in our templates. Failure logs pasted below.
May 22 16:36:09 vmss-nfuv3b000001 moodle: [Tue May 22 16:36:09.250973 2018] [:error] [pid 35166] [client <IP_ADDRESS>:45204] Failed to connect to redis at redis-nfuv3b.redis.cache.windows.net:6379, error returned was: Failed to AUTH connection
May 22 16:36:09 vmss-nfuv3b000001 moodle: [Tue May 22 16:36:09.252688 2018] [:error] [pid 35166] [client <IP_ADDRESS>:45204] Failed talking to redis: Failed to AUTH connection

Update: The actual Moodle issue is this: https://tracker.moodle.org/browse/MDL-58311
Tried workaround (by a partner) is to overwrite lib/classes/session/redis.php from Moodle 3.3 branch. Will try that out myself.

Marked a P2 as this is an upstream issue and only exists in older versions of Moodle. Happy to accept patches if anyone is facing this issue.

Agreed. The Moodle bug tracker page says "Fixed Branches:
MOODLE_33_STABLE", so I suppose this issue will be there on Moodle 3.2 as well. Not sure, though, if this is a bug on us? Our templates could/should be more intelligent and checking this kind of incompatibility, but I'm not sure if we can do something like that with ARM language?

If there are many of these parameter incompatibilities we could consider providing a tool that will look at your properties file and warn of known issues. This could be a wrapper around the AZ CLI (or even an AZ CLI module) that would validate the parameters and perform the deployment in a single command.
That said, I'm just thinking aloud. I don't see this as a particularly hi priority item. If we get too many users hitting failures we could revisit solutions.

I can confirm 3.2 is affected, this is because redis requires authentication for sessions and that was only introduced in 3.3.

Considering anything below Moodle 3.5 is now EOL since May 2019 this issue can be closed


Create WebView Panel with custom size and position in vscode API

Now, when creating a new webview panel, I can specify the viewColumn, but I cannot specify which side and with what fixed size I want to open this panel.
For example, I want to open a panel from the bottom with a fixed height of 400px. For this I would like to do something like this:
vscode.window.createWebviewPanel(
      'webview', 'Webview',
      vscode.ViewColumn.Custom, // for custom column
      {
        viewPosition: vscode.ViewPosition.Bottom, // Up, Left, Right,
        viewSize: 400 // Fixed size for resizable side (for up and bottom it height, for left and right -- width),
        viewSize: 1/4 // Or maybe I want create panel with 25% size from available space for panels
      }
);

We don't give extension direct control over editor sizing and don't plan on adding this specifically for webviews (although, if we ever expose an API for controlling editor size, webview would should support it)
Webview views are often the better fit for cases where you'd want a specific sized webview


Revert "[BugFix][Cherry-Pick] Fix bug remove task_runs slow"

Reverts StarRocks/starrocks#29685

[FE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/scheduler/TaskRunHistory.java
0
1
00.00%
[25]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)


Mechanism for marking models as supporting system prompts

Hmmm... thinking about it, we actually have a bit of a precedent problem here.
llm-claude silently ignores system prompts, which caught me out already - I fed it a system prompt and it didn't work, but I didn't realize because I didn't get an error.
On that basis, an error would actually be a better solution.

Originally posted by @simonw in https://github.com/simonw/llm/issues/284#issuecomment-1724862381

This should be opt-in. That way llm-claude won't even need updating to support this - by NOT adding the flag for it supporting system prompts it will just start erroring.
Though that does mean that all the plugins that DO support system prompts will need to be upgraded ASAP when this gets released.


What will the final form of my predictions be?

Should probably be log returns, but very difficult to debug these and harder to see if it's learning.

When using log returns the network overfits to training dataset very easily.
But when using scaled prices the network generalises better

Use raw prices. Calculations on log returns don't work and calculations on inverse prices are a poor work-around.
-    Mention in report reasons for log returns poor performance
         -    Highly non-linear
         -    Crash in the middle of the dataset
         -    MSE is the evaluation metric and so safest option is a flat signal.
               Optimises towards this.


vscode-resource in WebviewPanel broken

VSCode Version: 1.48
OS Version: Windows 10

Hi! I am the author of the Handlebars Preview extension. The extension takes Handlebars templates, renders them to HTML and displays them in a WebviewPanel.
One of the key features of the extension is that it finds all img tags in a template, and changes the src attribute to a 'vscode-resource' URL to make them show up in the WebviewPanel.
After upgrading to the latest VS Code, I find to my dismay that this is now broken. To be honest, I can't tell whether this happened in v 1.48 or earlier, but it worked last time I tried a few months ago.
The code that carries out the transformations of the file URL's look like this:
// templateDocument is the current TextDocument opened
// elm is an instance of an img element

const newSrc = templateDocument.uri.with({
    scheme: 'vscode-resource',
    path: path.join(path.dirname(templateDocument.fileName), elm.attribs['src']),
}).toString();
elm.attribs['src'] = newSrc;

If I inspect the value of newSrc, I can see that it's been URL-encoded:

vscode-resource:c%3A%5Cwork%5Cwebapp%5Cwebapp%5Csource%5CZwiftly.Email%5CTemplates%5Cimages%5Cpackage.png

I don't think that is necessarily the issue though, because if I manually change that value to vscode-resource:c:\work\webapp\webapp\source\Zwiftly.Email\Templates\images\package.png it still renders as a broken image in the preview panel.
The root directory of the opened VS Code instance is c:\work\webapp\webapp\source\Zwiftly.Email\Templates\, so it's not an issue of the image being located outside the workspace.
Steps to Reproduce:

Clone the extension repository
Hit F5
In the debug instance of VS Code, open a folder that contains an image.
Create a new file called 'test.hbs', containing the code <img src="name-of-your-image.png" />
Run the command "Handlebars: Preview"
You will see a broken image in the webview panel.

If you put a breakpoint on line 131 of the file preview-panel-scope.ts then you can inspect the produced file URL.

I found that if I change the code to:
elm.attribs['src'] = Uri.file(path.join(path.dirname(templateDocument.fileName), elm.attribs['src'])).with({ scheme: 'vscode-resource' }).toString();

Then it works. Not sure why the other version has stopped working. Closing issue.


Trigger MilestoneConfirmedEvent when milestone has already been confirmed

Looking at RegisterBlockSolidEvent it would seem consistent that calling RegisterMilestoneConfirmedEvent for a past milestone also triggers it.
I am not sure, whether the previous behavior is expected anywhere, in that case maybe add a comment and ignore this PR.

The check was not needed because the node can not know the milestone before the coordinator created it.
There was no race condition possible. With RegisterBlockSolidEvent this was different, because we send the block to the node before we know it's BlockID. There is a race condition by high chance, thats why this extra logic was added there.
But I'm also fine to add this check for consistency, because not only the coordinator itself may use this function. :+1:


how to add this project to objective-c

There is a person who decided to rewrite it to ObjC, so you can have a look at that and use it if it works. :+1:
https://github.com/Mainstayz/DGElasticPullToRefresh


Updated README.md

I have made the following enhancements:
Added a feature (Efficient Search)
Added information about the Tech-Stack used for the project
Elaborated the Installation Steps.
Provided access to the MIT License
Thank You for assigning the issue!

mention Issue number you are resolving

@PatilHarshh Issue no. 26

Good Job @VShalini01 ! Looking Forward for more contribution

@PatilHarshh Can you please assign GSSoC label to the PR

Done !


Improve formatting of configuration.md

Started out to fix a formatting bug seen at https://docs.docker.com/registry/configuration/#/log, but ended up reformatting the whole file and doing some light rewriting. I do not believe I changed any "facts".
@stevvooe please nominate other reviewers.

Current coverage is 51.20% (diff: 100%)

Merging #2116 into master will decrease coverage by 10.02%

@@             master      #2116   diff @@
==========================================
  Files           129        129
  Lines         11416      11416
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           6990       5846   -1144
- Misses         3535       4821   +1286
+ Partials        891        749    -142

Powered by Codecov. Last update 2d50093...e2166f8

The diff looks good, but I haven't been able to untangle my conflicting docker installs to find a way to build and preview it. In the mean time, attaching these issues, which will be blessedly fixed when this is done. :)
Closes docker/docker.github.io/issues/986
Closes docker/docker.github.io/issues/983
Closes docker/docker.github.io/issues/968
Closes docker/docker.github.io/issues/927
Closes docker/docker.github.io/issues/899

LGTM
Commented on middleware section but that could be broken out later as well.

BTW thanks @mstanleyjones for making this change, its a pretty big cleanup and a huge improvement over what was there before.

The page https://docs.docker.com/registry/configuration/ is badly broken,  this fix needs to be pushed out.


Fix shutdown errors on Python 3.8

This PR is designed to remove the errors that occur during shutdown during batch execution on Python 3.8.
Closes #88

The Python 3.9+ failures/hanging above is due to the error reported in #87.  Thus, I have cancelled the remaining tests.  I believe this can be merged as it specifically addresses Python 3.8 only.


Return sequence ID to web UI when add customized trials

only reviewed backend code.

Included PR #1653


Adjust new queue stats accounting to work with original run_stats semantics

This PR adjusts the queue stats syncing so that RX/TX queue counters are always synced, ignoring run_stats. This addresses issue #1139.
Unfortunately, I think #1137 is still broken on this PR so I don't think it should be merged as-is. I'm concerned that having queue stats synced on separate apps is not actually going to work out in the end.

This approach had some flaws that makes it not worth merging. I will look into making a separate PR with some of the test changes which might be useful.


[EventRequest] Table 18 Customer - Get* Amount functions

We require adjustments to the amount calculation. To make this possible we would like to request the following publishers which allow us to use different calculation:

Add more fields in current event

[External] GetTotalAmountLCY() : Decimal
OnBeforeGetTotalAmountLCY(Rec,ReturnValue,IsHandled);
IF IsHandled THEN
EXIT(ReturnValue);
Publisher
LOCAL [IntegrationEvent] OnBeforeGetTotalAmountLCY(VAR Customer : Record Customer;VAR ReturnValue : Decimal;VAR IsHandled : Boolean)

In function  GetSalesLCY()  new event

[External] GetSalesLCY() : Decimal
OnBeforeGetSalesLCY(Rec,ReturnValue,IsHandled);
IF IsHandled THEN
EXIT(ReturnValue);
Publisher
LOCAL [IntegrationEvent] OnBeforeGetSalesLCY(VAR Customer : Record Customer;VAR ReturnValue: Decimal;VAR IsHandled : Boolean)

In function [External] CalcOverdueBalance() OverDueBalance : Decimal new event

OnBeforeCalcOverdueBalance(Rec,OverDueBalance,IsHandled);
IF IsHandeled THEN
EXIT;
Publisher
LOCAL [IntegrationEvent] OnBeforeCalcOverdueBalance(VAR Customer : Record Customer;VAR OverDueBalance: Decimal;VAR IsHandled : Boolean)

In Function [External] GetInvoicedPrepmtAmountLCY() : Decimal new event

OnBeforeGetInvoicedPrepmtAmountLCY(Rec,ReturnValue,IsHandled);
IF IsHandled THEN
EXIT(ReturnValue);
Publisher
LOCAL [IntegrationEvent] OnBeforeGetInvoicedPrepmtAmountLCY(VAR Customer : Record Customer;VAR ReturnValue: Decimal;VAR IsHandled : Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Autocomplete component does not show results by default when performing an asynchronous search.

🐛 Bug Report
Autocomplete component does not show results by default when performing an asynchronous search, these just show up if i lose the autofill focus and put the focus back on it.
To Reproduce
1.- Search autocomplete async (Results are not seen).
2.- Lose focus.
3.- Focus input (Show results).
UI Kitten and Eva version

Package
Version

@eva-design/eva
2.0.0

@ui-kitten/components
5.0.0

This issue duplicates https://github.com/akveo/react-native-ui-kitten/issues/1117, please see it for more details.


Java 8u252 compatibility

Java 8u252 has been released a few days ago and comes with support for cross-realm ticket delegation.
While testing (via ShinyProxy), obtaining service tickets failed silently. I found that this constructor does no longer exist:
https://github.com/openanalytics/containerproxy/blob/9d8295a2015ea5cdb1b0e9d05ec9cf4e0bd25e74/src/main/java/eu/openanalytics/containerproxy/auth/impl/kerberos/KRBUtils.java#L176-L179
The relevant commit is this, in jdk8u242:
https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/6e79bf791069#l9.16
Btw. it was kinda scary that no exception was thrown 😕

Hi @micheljung
Thank you for your contribution, this is fixed in the latest release (containerproxy 0.8.5 and shinyproxy 2.4.0)


Update maintainers email addresses

I believe these are correct, emailing to check... they came from public github info/commits etc.
cc @endophage @cyli @nathanmccauley @ecordell @diogomonica

So they all changed their company , should I follow it lol. 😅

Yep, you got me :)
On Tue, 13 Aug 2019 at 19:30, HuKeping<EMAIL_ADDRESS>wrote:

So they all changed their company , should I follow it lol. 😅
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/theupdateframework/notary/pull/1484?email_source=notifications&email_token=AAJ54S4X56NSNQDLVZXENP3QENU5JA5CNFSM4ILMO6N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HQPYA#issuecomment-521078752,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ54S43SVHZ5N424I747ZDQENU5JANCNFSM4ILMO6NQ
.

Lgtm, thanks!

ping @cyli @NathanMcCauley @diogomonica PTAL

LGTM


The server is crashing if I change the values for the spacing

Please report this error to the mod author.

Error while running event artillery-bombardment-remote::on_gui_value_changed (ID 86)
__artillery-bombardment-remote__/control.lua:418: bad argument #1 of 2 to '__newindex' (string expected, got number)
stack traceback:
        [C]: in function '__newindex'
        __artillery-bombardment-remote__/control.lua:418: in function '?'
        __artillery-bombardment-remote__/control.lua:477: in function <__artillery-bombardment-remote__/control.lua:475>5227.808 Error ServerMultiplayerManager.cpp:91: MultiplayerManager failed: "The mod Artillery Bombardment Remote (1.1.1) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event artillery-bombardment-remote::on_gui_value_changed (ID 86)
__artillery-bombardment-remote__/control.lua:418: bad argument #1 of 2 to '__newindex' (string expected, got number)
stack traceback:
        [C]: in function '__newindex'
        __artillery-bombardment-remote__/control.lua:418: in function '?'
        __artillery-bombardment-remote__/control.lua:477: in function <__artillery-bombardment-remote__/control.lua:475>"
5227.844 Info ServerMultiplayerManager.cpp:780: updateTick(24569526) changing state from(InGame) to(Failed)
5227.844 Quitting: multiplayer error.
5228.496 Info ServerMultiplayerManager.cpp:140: Quitting multiplayer connection.
5228.496 Info ServerMultiplayerManager.cpp:780: updateTick(4294967295) changing state from(Failed) to(Closed)
5228.497 Info UDPSocket.cpp:218: Closing socket
5228.497 Info UDPSocket.cpp:248: Socket closed
5228.497 Info UDPSocket.cpp:218: Closing socket
5228.581 Info UDPSocket.cpp:218: Closing socket
5228.581 Info UDPSocket.cpp:248: Socket closed
5228.582 Goodbye

It seems the slider is returning a number and the input wants a string.

This causes multiplayer servers to crash as well if a player enters a non numeric value or uses the sliders to adjust the pattern.
Players are now used to close these dialogs by using the e key which triggers the crash.

Posted the issue already on the mod forum, but it is exactly the same issue:
Error on value Change in the GUI of the Artillery Bombardment Remote. To reproduce the error just open the Artillery Bombardment Remote of the mod with right click and use one of the sliders. Then the attached error will likely occur (for us every time).
If typing a number value directly into the fields the error will not! occur. It is specifically an issue with the sliders and how they hand over there changed state.
As a workaround just typing the numbers and save them will work for now.
As a second workaround if other windows block the Artillery Bombardment Remotes -> Right Click GUI it its possible to disable the other mods (e.g. Module Inserter). Set the values by manually typing, save the game, then reactivate other mods.
991.039 Error MainLoop.cpp:1283: Exception at tick 22359191: The mod Artillery Bombardment Remote (1.1.1) caused a non-recoverable error.
Please report this error to the mod author.
Error while running event artillery-bombardment-remote::on_gui_value_changed (ID 88)
artillery-bombardment-remote/control.lua:418: bad argument #1 of 2 to '__newindex' (string expected, got number)
stack traceback:
[C]: in function '__newindex'
artillery-bombardment-remote/control.lua:418: in function '?'
artillery-bombardment-remote/control.lua:477: in function <artillery-bombardment-remote/control.lua:475>
991.039 Error ServerMultiplayerManager.cpp:91: MultiplayerManager failed: "The mod Artillery Bombardment Remote (1.1.1) caused a non-recoverable error.
Please report this error to the mod author.
Error while running event artillery-bombardment-remote::on_gui_value_changed (ID 88)
artillery-bombardment-remote/control.lua:418: bad argument #1 of 2 to '__newindex' (string expected, got number)
stack traceback:
[C]: in function '__newindex'
artillery-bombardment-remote/control.lua:418: in function '?'
artillery-bombardment-remote/control.lua:477: in function <artillery-bombardment-remote/control.lua:475>"

Seems like gui text boxes now intl accept actual text, so it needs to be converted to a string first.


[MXNET-507] Set dtype=int32 for ret_indices in ordering ops

Description
There are two problems in the ordering operators, i.e, topk, sort, argsort:

Only real_t is supported.

The indices are stored as real_t. This will cause error in the backward pass where the gradient are passed to the wrong locations.

For example, we can not run the following code in the previous version:

import mxnet as mx
import numpy as np
import mxnet.ndarray as nd

ctx = mx.cpu()

a = mx.nd.arange(54686454, ctx=ctx, dtype=np.int32)
a.attach_grad()

k = 10
with mx.autograd.record():
b = mx.nd.topk(a, k=k, ret_typ='value')
b.backward(mx.nd.ones((k,), ctx=ctx, dtype=np.int32))
a_grad = a.grad.asnumpy()
for i in range(-1, - k - 1, -1):
assert a_grad[i] == 1

I propose to fix this bug by changing the dtype of indices to int32. This will make the code backward incompatible. However, it only breaks some rare usages. Normally we will directly output the indices or use them to slice a tensor. The current change do not break these common usages. (I have used the other solution mentioned below.)
Another solution is to support an additional flag dtype for these operators (as suggested in https://github.com/apache/incubator-mxnet/issues/11031). The problem of this solution is that we cannot avoid a nested macro, which is extremely slow to compile. So I haven't solved it this way.
MACRO_SWITCH(dtype, DType, {
   MACRO_SWITCH(idtype, IDType, {
      ...
   });
});

This PR also fixes the issue reported in https://github.com/apache/incubator-mxnet/issues/10085 that ordering ops do not support kNullOp.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Arbitrary dtype (exclude float16) for ordering operators, tests
[x] For topk, argsort, add the dtype option to specify the type of the output indices, tests
[x] Fix the bug that ordering ops do not support kNullOp, tests

Comments

This change is backward incompatible. However, I think it's reasonable to set the dtype of indices to int32 because it does not break the common usage where we use these indices to slice a tensor. The change is backward compatible now.

After discussing offline with Eric, I'll add an additional dtype flag to make sure that the OP is backward compatible.

Feel free to remove "breaking" label when you're ready.

I think that it would be helpful if a check for the ranges of the floating point types is added. The recent addtion of dtype to multinomial implemented the check. https://github.com/apache/incubator-mxnet/blob/3eada3b32aeab5c8cdf7d507bcc3a986c9e5b91f/src/operator/random/sample_multinomial_op.h#L73-L76

Thanks a lot! I was just looking for such a check.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Deokjae Lee<EMAIL_ADDRESS>Sent: Monday, June 11, 2018 9:31:02 PM
To: apache/incubator-mxnet
Cc: Xingjian SHI; Author
Subject: Re: [apache/incubator-mxnet] [MXNET-507] Set dtype=int32 for ret_indices in ordering ops (#11134)
I think that it would be helpful if a check for the ranges of the floating point types is added. The recent addtion of dtype to multinomial implemented the check. https://github.com/apache/incubator-mxnet/blob/3eada3b32aeab5c8cdf7d507bcc3a986c9e5b91f/src/operator/random/sample_multinomial_op.h#L73-L76
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/apache/incubator-mxnet/pull/11134#issuecomment-396243589, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE8D7u7vceZYr3aWQORkAyQyQqv645Ntks5t7nEWgaJpZM4UYsvh.

Is it okay to merge this in?

@sxjscience any chance you could add a small update to the documentation saying that the output is sorted. thanks!


[CHANGE] Change EnableBackplaneNotifications to (inverted) SkipBackplaneNotifications

Is your feature request related to a problem? Please describe
The EnableBackplaneNotifications option in the FusionCacheEntryOptions type always felt slightly badly named, but never got to why. Now I do.
The word "enable" feel like we are enabling it, plus it felt like it was a kinda opt-in operation.
Instead backplane notifications are normally sent (if you setup a backplane, of course), just like the distributed cache is normally used (again, if you setup a distributed cache, of course).
Recently, I added the ability to SKIP the usage of the distributed cache if you need it. I also added the ability to (again) SKIP the read phase from the distributed cache if you need it.
And then, it clicked: "SKIP" was the right word, that described the right behaviour.
So, to recap: the normal flow is that if you setup a distributed cache and/or a backplane, they will be used.
But if you want though, you can SKIP certain operations for some calls.
Yeah, that is nice.
Describe the solution you'd like
Add a new SkipBackplaneNotifications option in the FusionCacheEntryOptions type, plus a new method to set it in a fluent-interface way, like the other options.
Use them instead of the old EnableBackplaneNotifications option and methods.
Of course the value of the 2 options are "inverted", meaning SkipBackplaneNotifications == !EnableBackplaneNotifications.
Ease of migration
To avoid annoying current users who may be using the old option excessively (even though it was needed in rare occasions), I will NOT remove the old prop/method but leave them there while marking them as [Obsolete] with a nice note to inform of the change (and maybe a link to this issue for more background).
This way existing code can continue to work, users will be warned of the change so that they'll be able to update their code, at their own pace.

The new v0.18.0 has been release 🎉
It includes this change, too.


Docs: add more information about parallel option

Repost from https://github.com/squizlabs/PHP_CodeSniffer/issues/1732:

I've just been looking into the parallel running option a bit more and am left with some questions.

When should you use this option ?
Does it work equally well with phpcs as well as phpcbf ?
What things should you take into consideration when determining the amount of parallel processes to use ?
What can go wrong ? Are there any type of sniffs which would be incompatible with parallel processing ?
Any thing else which behaves differently if parallel processing is turned on ?

It might be useful to add a section to the Wiki Advanced Usage page about this.

👉🏻 The thread in the original post contains lots of useful comments and would be a good starting point to start writing this up.

Best course of action would be to just automate it. Since the original thread phpstan and others started to use https://github.com/theofidry/cpu-core-counter for that

@mabar Nice idea and something which could be considered as a feature request some time in the future. Having said that, that doesn't negate the validity of the current issue which is about the lack of documentation for how things are now.

To answer your questions

When should you use this option ?

Ideally always, it speeds up analysis a lot

Does it work equally well with phpcs as well as phpcbf ?

It looks like it does. Even initial phpcbf run on large legacy codebases is quite fast.

What things should you take into consideration when determining the amount of parallel processes to use ?

If you don't plan to run the checks nonstop, it's fine to just use all cores. On huge codebases, it helps a lot. On small codebases using more cores than necessary slows down execution, but the speed gain is still massive and optimizing for each small package is just not worth it. Perhaps codesniffer itself may decide to use less cores than given available, based on overall amount of files and amount of cached and unchanged files.
Using --parallel=$(shell nproc || sysctl -n hw.logicalcpu || wmic cpu get NumberOfLogicalProcessors || echo 4) to use all cores worked for me just fine on Linux, Windows and Mac. It's practically the same thing that https://github.com/theofidry/cpu-core-counter does.
Note that the syntax using shell may be specific to Makefile

What can go wrong ? Are there any type of sniffs which would be incompatible with parallel processing ?

I am currently at exactly 200 sniffs from codesniffer and slevomat/coding-standard and never had issues related to parallel processing.

Any thing else which behaves differently if parallel processing is turned on ?

Error handling. I had some very long file, whose processing was stuck. I had to disable parallelism in order to identify the file. Sadly, I don't remember why exactly was it a problem.

When should you use this option ?

Ideally always, it speeds up analysis a lot

Caveat: it doesn't work on Windows.

What can go wrong ? Are there any type of sniffs which would be incompatible with parallel processing ?

I am currently at exactly 200 sniffs from codesniffer and slevomat/coding-standard and never had issues related to parallel processing.

Anecdotal evidence is not an answer. There are some sniffs which check things across a codebase - like the Generic.Classes.DuplicateClassName sniff. Those type of sniffs "remember" information about previously seen code and I can imagine that information cache will not work correctly when running in parallel. That's the kind of thing I'd like to see investigated to answer that question (and no, I haven't investigated this myself, if for no other reason than that I'm using Windows).

As per #419, parallelization is silently disabled if the pcntl extension is not available, how would be the best way to document this?
I'll kick-off with this suggestion to the Configuration Options page. Maybe we can also have one section in Advanced Usage, and link there if it needs further explanation/details?

Enabling Parallelization
By default, PHP_CodeSniffer will run using a single thread. To take advantage of parallel processing, you can set the default number of threads by using the parallel configuration option.
phpcs --config-set parallel 4
Note:  Parallel processing requires the 'pcntl' PHP extension. If the extension is not available, PHP_CodeSniffer will default to single-thread execution."

Documentation isn't enough, IMHO.

@mbomb007 Agreed. I'll be opening a proposal ticket for a --diagnose option in the foreseeable future. The rough outline of it is described in https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/419#discussion_r1546934609
That should hopefully cover your concern.

As per #419, parallelization is silently disabled if the pcntl extension is not available, how would be the best way to document this?
I'll kick-off with this suggestion to the Configuration Options page. Maybe we can also have one section in Advanced Usage, and link there if it needs further explanation/details?

Enabling Parallelization
By default, PHP_CodeSniffer will run using a single thread. To take advantage of parallel processing, you can set the default number of threads by using the parallel configuration option.
phpcs --config-set parallel 4
or
phpcs --parallel 4
Note:  Parallel processing requires the 'pcntl' PHP extension. If the extension is not available, PHP_CodeSniffer will default to single-thread execution."

@Luc45 Thank you for getting the docs started. I do think it needs to be fleshed out a little more.

It should definitely mention the ability to set --parallel at runtime via the CLI argument.
I think it may also be good to list the situations in which the parallel option has no effect/will not be respected (STDIN/interactive mode/high verbosity)
And some short guidance on how to set the value might also help - i.e. the limit is the number of Cores available on a system (?).
Probably also good to link the mention of the pcntl extension to the PHP manual ? This link seems appropriate: https://www.php.net/manual/en/pcntl.installation.php

While it doesn't directly address this issue, PR #447 is a proposal to improve the help screens, including improved information on the help screen about the --parallel option.
Reviews and testing of that PR would be appreciated.


Add BuildDefinition table to pipeline witness

/azp run tools - pipeline-witness

@Akhil-Kokkula Is this to make joins on definition name easier when trying to query data in the logs/timeline records table? If so, thank you thank you!!!!!


Unable to find lower version cakephp sparkpost code.

I have an old project. Client need to implement SparkPost email.  I want to SparkPost code in cakephp 2.x version. Please help me...

This plugin only supports the 3.x branch of CakePHP, and there are no plans to support 2.x at this time. 3.x was released in March 2015 and is superior in many ways to 2.x, which was why it was chosen as the platform for this plugin.
If you would like to attempt to implement a 2.x solution, you are certainly welcome to. I suggest you consult the Sparkpost PHP API docs and the CakePHP 2.x email documentation, specifically the section involving creating custom transports.

You are right. But this code also same. I tried to modify that code. Because my php version 5.3 so namespace and using alias not working for SparkPost code.

PHP 5.3.0 supports namespaces, but lower versions of CakePHP 2.x do not. You will have to write a custom classloader. Mark has a good article on this topic on his blog. Keep in mind the namespace path used in a CakePHP 3.x plugin will not be the same as the namespace path used in a CakePHP 2.x plugin.

@robojamison  I will try this way.
Thank a lot.
@chinmay235


support to bitcoind and mainnet

Hi, new to LN , wonder if it'd support the mainnet to try out a real working example also can I configure with bitcoind running on a separate server over RPC? Or is it only hard coded to btcd? I have bitcoind full node that wanted to use but setting up a complete new btcd node and syncing everything would be nightmare now

For now, it is a specific build of btcd on testnet. It's pretty easy to set it up on testnet if you follow https://github.com/lightningnetwork/lnd/blob/master/docs/INSTALL.md

bitcoind support will be added once the in-progress PR for #21 is up.
Closing.


Static files and matching

I updated a sample to use static files + endpoints + authz. To achieve the desired result I had to write a DIY static file endpoint matcher and it got me thinking.
RANDOM THOUGHT 1
We could add configurable static file matching to UseEndpointRouting. It would be useful when you want to run the file through APIs that use endpoints, e.g. AuthorizationMiddleware. There could be a couple of modes for matching:

The static files all live as endpoints provided by an endpoint datasource. High memory, long startup time, high perf
Or the endpoint for a static file is created on demand. Low memory, short startup time, low perf. This is what the authz sample is doing.

app.UseEndpointRouting(routes =>
{
    routes.MapApplication();
    routes.MapStaticFiles();
});

RANDOM THOUGHT 2
UseStaticFiles today is terminal if there is a matching file. If static files have endpoints then it could disappear from 3.0 templates and the static file could be returned at the end of the request pipeline.
Would there be performance considerations from doing this? It would mean static files experience the entire request pipeline, e.g. if authentication is enabled then static file requests would be authenticated.
Alternatively UseStaticFiles could remain present in templates, and if the request was matched to a static file endpoint in UseEndpointRouting then UseStaticFiles would do nothing more than invoke the endpoint and exit.

// @davidfowl @rynowak

Yes, StaticFiles is a prime candidate for cloning to work as endpoints. In this model I'd expect MapStaticFiles to take StaticFilesOptions and that there'd be a way to add metadata for any matches, like auth policies.
Don't forget about DefualtFiles or DirectoryBrowsing.

Or the endpoint for a static file is created on demand. Low memory, short startup time, low perf. This is what the authz sample is doing.

This is what I imagined. We want to check for the presence of the file in realtime (or with a cache) rather than computing them all upfront.
We might also define some wildcarding or rules so you can do multiple things.

re: template/guidance update - I totally agree. There are multiple choices about how this would work and only the application developer can decide what is best.
We've had the need for this in the past though. For instance there have been a bunch of issues with the spa fallback route. Sometimes you want to write a middleware that runs when nothing was matched.

This is what I imagined. We want to check for the presence of the file in realtime (or with a cache) rather than computing them all upfront.

Would the matcher do this? Right now it only supports matching static endpoints. What do you think of supporting dynamic endpoint selection in the matcher? We would want to:

Match to a dynamic endpoint
Match to a dynamic endpoint under a static path, e.g. use DFA to match /files and then dynamic endpoint selection would run.
Link generation to dynamic endpoints?

Would the matcher do this? Right now it only supports matching static endpoints. What do you think of supporting dynamic endpoint selection in the matcher?

I've imagined a feature like this in the past, but I don't understand why it would be needed for static files 🤷♂


chore: bump CNS and Windows NPM

What type of PR is this?
chore

What this PR does / why we need it:
Which issue(s) this PR fixes:

N/A
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

closing outdated PR