Sweep: rewrite the unilm/deltalm/test.py file to run a translation example from English to Arabic

the current code in the unilm/deltalm/test.py file produce error related to that there are some missing model configuration, I removed the code that produces these errors as I only want to run some inference but I got another error:
AttributeError                            Traceback (most recent call last)
 in <cell line: 7>()
5
6 # Create a new DeltaLM model instance
----> 7 model = DeltaLMModel.from_pretrained(
8     model_dir,
9     checkpoint_file=model,
2 frames
/content/drive/MyDrive/Translation Fine-Tuning/Exploring new models/unilm/deltalm/fairseq/fairseq/models/fairseq_model.py in from_pretrained(cls, model_name_or_path, checkpoint_file, data_name_or_path, **kwargs)
270         from fairseq import hub_utils
271
--> 272         x = hub_utils.from_pretrained(
273             model_name_or_path,
274             checkpoint_file,
/content/drive/MyDrive/Translation Fine-Tuning/Exploring new models/unilm/deltalm/fairseq/fairseq/hub_utils.py in from_pretrained(model_name_or_path, checkpoint_file, data_name_or_path, archive_map, **kwargs)
80         models = None
81     else:
---> 82         models, args, task = checkpoint_utils.load_model_ensemble_and_task(
83             model_path,
84             arg_overrides=kwargs,
/content/drive/MyDrive/Translation Fine-Tuning/Exploring new models/unilm/deltalm/fairseq/fairseq/checkpoint_utils.py in load_model_ensemble_and_task(filenames, arg_overrides, task, strict, suffix, num_shards, state)
441
442             if task is None:
--> 443                 task = tasks.setup_task(cfg.task, from_checkpoint=True)
444
445             if "task_state" in state:
AttributeError: 'NoneType' object has no attribute 'task'
I want you to fix this problem and make the necessary modifications to make it works and do the translation inference.

Checklist

[X] deltalm/deltalm/models/deltalm.py

• In the 'DeltaLMModel' class, modify the 'from_pretrained' method. Add a line of code to set the 'task' attribute in the 'kwargs' dictionary to 'translation' before calling the 'hub_utils.from_pretrained' function. The code should look like this:
kwargs['task'] = 'translation'
x = hub_utils.from_pretrained(
    model_name_or_path,
    checkpoint_file,
    **kwargs
)

[ ] deltalm/test.py

• Modify the 'model' variable assignment to include the 'task' attribute in the 'kwargs' dictionary. The code should look like this:
model = DeltaLMModel.from_pretrained(
    model_dir,
    checkpoint_file=model,
    bpe='sentencepiece',
    sentencepiece_model=spm,
    task='translation'
)

Sweep: apply these changes

Sweep: have you finished yet?


IR emitters on HP Spectre x360

On my HP Spectre x360 the IR emitters don't turn on when using Howdy on Manjaro KDE.
The video feed when testing howdy is grayscale (so I guess it's in IR mode?) and it does indeed draw a red circle around my face. The only thing not coming on are the two red lights next to the camera lens.
There is only one camera I could use:
~ > lsusb
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 003: ID 8087:0a2b Intel Corp. Bluetooth wireless interface
Bus 001 Device 002: ID 064e:3401 Suyin Corp. HP TrueVision FHD RGB-IR
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

I searched the available options and also tried all of them through with v4l2-ctl. None has an effect on the IR emitters:
~ > v4l2-ctl -l -d /dev/video0
brightness 0x00980900 (int)    : min=0 max=255 step=1 default=128 value=100
contrast 0x00980901 (int)    : min=0 max=255 step=1 default=32 value=32
saturation 0x00980902 (int)    : min=0 max=100 step=1 default=64 value=64
hue 0x00980903 (int)    : min=-180 max=180 step=1 default=0 value=0
white_balance_temperature_auto 0x0098090c (bool)   : default=1 value=1
gamma 0x00980910 (int)    : min=90 max=150 step=1 default=120 value=120
gain 0x00980913 (int)    : min=1 max=7 step=1 default=1 value=1
power_line_frequency 0x00980918 (menu)   : min=0 max=2 default=2 value=2
white_balance_temperature 0x0098091a (int)    : min=2800 max=6500 step=1 default=4000 value=4000 flags=inactive
sharpness 0x0098091b (int)    : min=0 max=7 step=1 default=2 value=2
backlight_compensation 0x0098091c (int)    : min=0 max=1 step=1 default=0 value=1
exposure_auto 0x009a0901 (menu)   : min=0 max=3 default=3 value=3
exposure_absolute 0x009a0902 (int)    : min=10 max=626 step=1 default=156 value=156 flags=inactive
exposure_auto_priority 0x009a0903 (bool)   : default=0 value=1

According to some posts I found that the IR camera should be at /dev/video2. I only have 0 & 1 which seems to be the root cause of my problem IMO.
Any help would be appreciated to find the cause of my problem. Thank you :)

I've searched for similar issues already, and my issue has not been reported yet.
Linux distribution (if applicable): Manjaro KDE
Howdy version (sudo howdy version): 2.6.1

It's quite common to only have a video0 and video1, my system has the same.  As for emitters #261 might help you

So I need to debug and dump my usb communication? Gonna be honest here, that's tough, and for me probably a show stopper.

I know that's difficult, and for almost all users it's too technical. There's simply no easy fix for this

Hello, go have a look on my repo : https://github.com/EmixamPP/linux-enable-ir-emitter.
I think you will find your answer, there everything is explained.
I remain available if you need help :smiley:

Thank you so much! I will try that but it could actually be that I don't have time for this in the next few weeks.
Ich will update here and in your config.txt when I get it (and a darn Windows VM) running.
I will close this issue.


Have PSModule resolve without Find-Module if version is explicity listed - Performance Improvement

Say I have a PSDepend that is:
@{
BuildHelpers                    = '1.1.4'
}
And I already have buildhelpers 1.1.4 installed. PSDepend should not do a find-module but accept that it is there. This would massively speed up dependency checking when a lot of modules are involved, since PSdepend doesn't run in parallel. If 'latest' is specified it will always find-module regardless.
I'll write a PR if you agree. I can write is as a parameter -FastVersionMatch or something.

PR #96 should have you covered. It would be great if you could give it a spin


Code churn on Master

I'm submitting a ...
[X] question about the decisions made in the repository

@katallaxie
While the enthusiasm is great, just slamming home changes without others having the opportunity to vet those changes kind of defeats the point of community & code review. 30 Commits directly to master, to include those to fix or remove features that shouldn't have landed between 27 Sept & 01 Aug.
It also means that everyone that uses the webpack-starter as a base project has to pick up those changes and merge them into what is usually a modified project, it gets tedious quickly.
I'm suggesting you start delivering changes as complete, tested & vetted sets of work through the standard pull request workflow that everyone else uses thus making the update process less labor intensive and less prone to blowing up peoples forks (which happened to me last week).
Landing your own code is generally frowned upon and for good reason. A second ( or multiple ) sets of eyes is never, ever a bad thing.

//cc @gdi2290

This was in my PR https://github.com/AngularClass/angular2-webpack-starter/pull/944. Which I had @gdi2290 ask to comment on.

Which you then merged yourself

Yep, if so this caused you trouble, then I apologize for that. I thought it would be best, as Angular is not final, to keep up with development to be stable or 'more' production ready as soon as possible. Perhaps it would be best to work with the gitflow and create a develop branch.

I'm not suggesting adding full gitflow as it usually feels like overkill, even for most of my professional stuff.
What I am suggesting is code not be committed directly to origin/master and rather using a standard pull request workflow where changes are PR'd, reviewed & then merged by a party != the authoring dev.

I fully agree on the review, and on the need to have all tests passed (fixed this with https://github.com/AngularClass/angular2-webpack-starter/commit/63b241953f9bf9d5c70fbb787b5738db7191989e), but I do not fully agree on the merge itself.


Data on PEPs in Cuba

We've been invited to crawl this: https://proyectoinventario.org/x-legislatura-la-asamblea-nacional-poder-popular-parlamento-cuba-2023-2028/

https://www.opensanctions.org/datasets/cu_inventario_legislatura/

https://github.com/opensanctions/opensanctions/pull/356

still needs to alert us in a year's time to check the maintenance situation and decide whether all positions can still automatically be set Current or not. https://github.com/opensanctions/opensanctions/pull/356#issuecomment-1684894698


Fix adding reset user without PUK to a team

Uh oh, I think tests are failing legitimately now --- or is it waiting for a server update?

server update
2017-08-03 19:06:21.454259807 +0000 UTC api.go:916: [D] - API call sig/multi error: bad keybase name given: 73a5bcf43d08ab1385fa3958aa354819%0 (error 2639)

cool hopefully the rerun will work

still waiting on new server...started another build


Making LogFilter::from_usize() public

Hi,
I'm using https://github.com/TeXitoi/structopt for CLI arguments and it has a nice feature called from_occurrences that it counts the number of vs when I pass -v and gives me a usize/u8.
I'm using that to select the LevelFilter for my logger.
Right now I have my own match, but it would be nicer if I could use the already existing LogFilter::from_usize() function (here: https://github.com/rust-lang-nursery/log/blob/master/src/lib.rs#L487 ) to convert it.
That way I won't need to worry about future changes to the LogFilter.
What do you think?
Thanks.

Hmm Ok, that's too bad.
I do think that other people had to write a function like this too, but thanks anyway :)

No problem, thanks again for the suggestion! This might be something we could revisit in the future.


Consider adding an MDC

Unlike in Java, it won't be inherited by child threads, but that seems fine IMO since you're probably caching threads between requests anyways.
http://logback.qos.ch/manual/mdc.html

This would almost certainly want to be in a separate crate.

Implemented!


Add a sample.env file in the demo directory containing the required values

The readme instructs the developer to create a .env file in the root of the demo directory. Consider adding a sample.env file so that the dev doesn't have to create the file and copy paste the values that are required to be populated in it.

Added on 3972507.


Cant run after creating MyClass.cs

Program.cs(9,13): error CS0246: The type or namespace name 'MyClass' could not be found (are you missing a using directive or an assembly reference?) [C:\Users\usjbro\mycproject\mycproject.csproj]
Program.cs(9,30): error CS0246: The type or namespace name 'MyClass' could not be found (are you missing a using directive or an assembly reference?) [C:\Users\usjbro\mycproject\mycproject.csproj]
The build failed. Please fix the build errors and run again.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8cc2e9c2-f333-f6a1-064e-790d950b684c
Version Independent ID: 25a4c9b9-2808-e296-df03-5837000dcbad
Content: Get started with C# and Visual Studio Code - .NET Core
Content Source: docs/core/tutorials/with-visual-studio-code.md
Product: dotnet-core
GitHub Login: @kendrahavens
Microsoft Alias: mairaw

Can you share the MyClass code? There is a specific note in the documentation when you create that class:

Add the code below to create your first class. Make sure to include the correct namespace so you can reference it from your Program.cs file.

Please double-check that the namespace defined in the MyClass code matches the namespace from the Program code.

Closing due to the lack of response.


import/order --fix works something wrong

First of all, I appreciate for developing and maintaining this plugin.🙏
I found malfunctions in import/order --fix operation.
I used this plugin and es-lint with lint-staged.
After I committed, I found import/order warnings in my IDE. (i set import/order level as WARN)
So I did es-lint --fix operation again, But that file has still warnings.
That file has almost 200 import lines.
{
    "eslint": "^5.16.0",
    "eslint-plugin-import": "^2.20.2",
}

Is it a bug? or Do I need something more?

I'm not sure what you're asking. Not all rules and warnings are autofixable; it's always expected that after autofixing, you still have to manually fix some things.

@ljharb Thanks for comment.
I just talked about import/order.
Is it possible code to exist not-sorted import statements After es-lint --fix?

@sshplendid yes, it may take multiple passes to fully autofix. Is that what you're seeing?


[Falcon40b] Prefill perf burndown

Tracks the open issues for Falcon40b prefill to hit target perf.
WIP!
Prefill
bfp8

Measured May 2nd, main@61b3856b7d42daf1888604b53a6090733e52f5be
1 GHz
Perf measurements based on 1 layer perf and extrapolated to 60 layers
Unidirectional AllGather
BFP8_B with HiFi2

Seqlen=2048
1 layer currently takes 15.42 ms
One-time ops: + 2.68 ms
Open Issues (bfp8 version):

CLL ops

[x] Bidirectional

~1.7 x speedup

[ ] 2-link AllGather

~1.7x speedup

[ ] ReduceScatter for MLP

2x faster than AllGather, saves 2.5 ms

[ ] Overlapped CCL

Could save up to 6.4 ms for perfect overlapping

[ ] #7461 Optimized SDPA, flash-attention style

Saves ~ 0.41 ms
(SPDA speedup estimated from 0.55 per SPDA as measured for our shapes for 800 MHz -> 0.41 SPDA for 1GHz)

[ ] Optimizing matmul_2d

TODO: estimate perf potential

[ ] Custom fused layernorm (mean, var is the same for both layernorms; gamma+beta separate)

saves ~ 0.5 ms

[ ] Distributed layernorm

TODO: estimate
We would need this to hide CCL time for AllGather before LN
This would enable us to parallelize the layernorm itself (1 slice, computation in parallel)

[x] Utilize all cores for FusedQKV

saves 0.11 ms

Open Issues (fp16 version):

CLL ops

[ ] Cast AllGathers to bfp8
[ ] Use bfp4 weights for FF1(+FF2)
[ ] 2-link AllGather

~1.7x speedup

[ ] ReduceScatter for MLP

2x faster than AllGather, saves ?? ms

[ ] Overlapped CCL

Could save up to ?? ms for perfect overlapping

[ ] #7461 Optimized SDPA, flash-attention style

Saves ~ ?? ms

[ ] Optimizing matmul_2d

TODO: estimate perf potential

[ ] Inplace layernorm + reduce num slices to 2
[ ] Custom fused layernorm (mean, var is the same for both layernorms; gamma+beta separate)

saves ~ 0.6 ms

[ ] Distributed layernorm

TODO: estimate
We would need this to hide CCL time for AllGather before LN
This would enable us to parallelize the layernorm itself (1 slice, computation in parallel)

WIP Projections:

Hiding CCL time completely
SPDA with estimated speedup from above
TODO: project potential MM optimization speedup (not considered yet)

milestone
single layer latency (ms)
full model latency (ms)
t/s
notes

current performance (bfp8)
15.42
925.4
2213
May 2nd, main@61b385, unidirectional AllGather

target @50%
5.47
328.2
6240

nvidia benchmark
10.9
654.6
3128

projected after burndown (bfp8)
8.4
511
4001

Target estimates see: https://docs.google.com/spreadsheets/d/1LawF5YIbAQC1c7vMJG7z-_qh1YXojpnWNvgLMBv5jC8
Assuming HiFi2, S=2048 has a target of 6240 tok/sec
6240 tok/sec target
6240/2048 = 3.05 batches / sec
3.05/1000 = 0.00304688 batches / ms
1/0.00304688 = 328.2 ms per inference
328.2/60 = 5.47 ms per layer

Seqlen=128
Assuming same optimizations as above. 2k is the harder regime, but optimizations should also apply to seqlen=128.
1 layer currently takes 1.71 ms
One-time ops: + 0.89 ms
WIP Projections:

Assumption: SPDA won't help us much here so no considered here
(AllGather 4x speedup + ) hiding CCL time considered
TODO: project potential MM optimization speedup (not considered yet)

milestone
single layer latency (ms)
full model latency (ms)
t/s
notes

current performance (bfp8)
1.71
102.61
1247.4
May 2nd, main@61b385, unidirectional AllGather

target @50%
0.83
50
2560

nvidia benchmark
1.4
84.04
1523

projected after burndown (bfp8)
1.24
75
1705

Assuming HiFi2 here, then S=128 has a target of 2560 tok/sec
2560 tok/sec target
2560/128 = 20 batches / sec
20/1000 = 0.02 batches / ms
1/0.02 = 50 ms per inference
50/60 = 0.83 ms per layer

Current perf breakdown: https://docs.google.com/spreadsheets/d/1YCIqrqJ6cPd0AVZs1DiXuEOOrPL9boYmEIFSDufKj6M/edit?usp=sharing
Branch: main@61b3856b7d42daf1888604b53a6090733e52f5be
System: t-3012 @ 1GHz

Most costly ops for S=128

fyi @pavlejosipovic @s-jovic @pavlepopovic @uaydonat

We already tested casting activations for AllGather to bfp4_b and that resulted in bad pcc (already for one layer), but using bfp8_b gave good pcc.

e2e perf issue: #8866


Remove the hr element as a candidate from mobile spacefinder

What does this change?
Remove the hr element as a candidate from mobile spacefinder
Why?
These elements have a large top margin (~50px), an ad would obviously be above this margin but spacefinder is unable to account for it, leading to ads being inserted a tad closer than we'd like to images if a hr follows an image.
With the introduction of the bypassMinBelow rule it's unnecessary to have it be a candidate anyway.
Before:

After:

Why is it unnecessary to have hr be a candidate with the introduction of the bypassMinBelow rule?

Why is it unnecessary to have hr be a candidate with the introduction of the bypassMinBelow rule?

Having hr's as candidates was part of throwing things at the wall to get ads working on list/ranked articles but it just turns out it's unnecessary!


problem to install the dependencies for ROS

hello everyone ,
Protonect example runs perfectly for me with the described modifications , but when im trying to install iai_kinect2 in my catkin workspace I got this when I run "  rosdep install -r --from-paths ." :
wissem@wissem-SVE14A15FFB:~/catkin_ws/src/iai_kinect2$ rosdep install -r --from-paths .
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
registration_viewer: Cannot locate rosdep definition for [kinect2_bridge]
kinect2_bridge: Cannot locate rosdep definition for [depth_registration]
kinect2_calibration: Cannot locate rosdep definition for [kinect2_bridge]
Continuing to install resolvable dependencies...
#All required rosdeps installed successfully
please help me !!

That's not a real problem. rosdep can't locate these packages because they are all part of the iai_kinect2 package. So everything worked fine.

ok I proceeded like you said , but when I run " rosrun kinect2_bridge kinect2_bridge "  windows does not came out , in the terminal everything works fine :
wissem@wissem-SVE14A15FFB:~/catkin_ws$ rosrun kinect2_bridge kinect2_bridge
parameter:
base_name: kinect2
sensor:
fps_limit: -1
calib_path: /home/wissem/catkin_ws/src/iai_kinect2/kinect2_bridge/data/
use_png: false
jpeg_quality: 90
png_level: 1
depth_method: opengl
depth_device: -1
reg_method: default
reg_devive: -1
max_depth: 12
min_depth: 0.1
queue_size: 2
bilateral_filter: true
edge_aware_filter: true
publish_tf: false
base_name_tf: kinect2
worker_threads: 4
[Freenect2Impl] enumerating devices...
[Freenect2Impl] 11 usb devices connected
[Freenect2Impl] found valid Kinect v2 @4:8 with serial<PHONE_NUMBER>42
[Freenect2Impl] found 1 devices
Kinect2 devices found:
0:<PHONE_NUMBER>42 (selected)
[Freenect2DeviceImpl] opening...
[Freenect2DeviceImpl] opened
starting kinect2
[Freenect2DeviceImpl] starting...
[Freenect2DeviceImpl] ReadData0x14 response
92 bytes of raw data
0x0000:  00 00 12 00 00 00 00 00 01 00 00 00 43 c1 1f 41    2e2e2e2e2e2e2e2e2e2e2e2e432e2e41
0x0010:  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    2e2e2e2e2e2e2e2e2e2e2e2e2e2e2e2e
0x0020:  0a 21 33 55 c2 00 17 20 00 08 00 00 10 00 00 00    2e2133552e2e2e202e2e2e2e2e2e2e2e
0x0030:  00 01 00 00 00 10 00 00 00 00 80 00 01 00 00 00    2e2e2e2e2e2e2e2e2e2e802e2e2e2e2e
0x0040:  31 33 00 00 00 0a 07 17 47 4d 53 33 33 35 2e 31    31332e2e2e2e2e2e474d533333352e31
0x0050:  58 00 00 00 00 00 00 00 00 00 00 00                582e2e2e2e2e2e2e2e2e2e2e
[Freenect2DeviceImpl] ReadStatus0x090000 response
4 bytes of raw data
0x0000:  01 26 00 00                                        2e262e2e
[Freenect2DeviceImpl] ReadStatus0x090000 response
4 bytes of raw data
0x0000:  0b 26 00 00                                        2e262e2e
[Freenect2DeviceImpl] enabling usb transfer submission...
[Freenect2DeviceImpl] submitting usb transfers...
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[TransferPool::submit] failed to submit transfer
[Freenect2DeviceImpl] started
device serial:<PHONE_NUMBER>42
device firmware: 4.3.3912.0.7
default ir camera parameters:
fx 364.981, fy 364.981, cx 258.011, cy 208.655
k1 0.0952851, k2 -0.279021, p1 0, p2 0, k3 0.0998465
default color camera parameters:
fx 1081.37, fy 1081.37, cx 959.5, cy 539.5
using sensor defaults for color intrinsic parameters.
using sensor defaults for ir intrinsic parameters.
using defaults for rotation and translation.
using defaults for depth shift.
camera parameters used:
camera matrix color:
[1081.3720703125, 0, 959.5;
0, 1081.3720703125, 539.5;
0, 0, 1]
distortion coefficients color:
[0, 0, 0, 0, 0]
camera matrix ir:
[364.9808959960938, 0,<PHONE_NUMBER>984375;
0,<PHONE_NUMBER>960938,<PHONE_NUMBER>507812;
0, 0, 1]
distortion coefficients ir:
[0.09528505802154541, -0.2790214121341705, 0, 0, 0.09984645247459412]
rotation:
[1, 0, 0;
0, 1, 0;
0, 0, 1]
translation:
[-0.052; 0; 0]
depth shift:
0
[DepthRegistration::New] Using CPU registration method!
[DepthRegistration::New] Using CPU registration method!
starting main loop
[kinect2_bridge] depth processing: ~0Hz (infms) publishing rate: ~0Hz
[kinect2_bridge] color processing: ~2148.35Hz (0.465473ms) publishing rate: ~12.9889Hz
[kinect2_bridge] depth processing: ~-nanHz (-nanms) publishing rate: ~0Hz
[kinect2_bridge] color processing: ~2145.99Hz (0.465986ms) publishing rate: ~14.983Hz
[TurboJpegRgbPacketProcessor] avg. time: 27.6729ms -> ~36.1364Hz
[kinect2_bridge] depth processing: ~-nanHz (-nanms) publishing rate: ~0Hz
[kinect2_bridge] color processing: ~2577.94Hz (0.387907ms) publishing rate: ~14.9827H
what's wrong ??

kinect2_bridge is not displaying any windows, it just published the images through ROS topics.
There is a problem with the USB: [TransferPool::submit] failed to submit transfer. There are a lot of issues to this problem, you could look at those to find a solution. In general, make sure you have a kernel >= 3.13, check with USB 3.0 controller you are using. Make sure that ldd libfreenect2.so points to the libusb in libfreenect2/depeds/libusb.
And GitHub is sending me notification whenever someone adds or comments on an issue, so there is no need in writing mails to inform me, that you have added a new comment.

Actually I think I have the same problem with @Wissou.
When I run "rosrun kinect2_bridge kinect2_bridge", there is a problem that "[TransferPool::submit] failed to submit transfer" and "[kinect2_bridge] depth processing: ~-nanHz (-nanms) publishing rate: ~0Hz".
My kernel is 3.13 and USB 3.0 seems all right.
$ lsusb
Bus 002 Device 002: ID 8087:0024 Intel Corp. Integrated Rate Matching Hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 004 Device 005: ID 045e:02c4 Microsoft Corp.
Bus 004 Device 004: ID 045e:02d9 Microsoft Corp.
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 003 Device 003: ID 045e:02d9 Microsoft Corp.
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 003: ID 04f2:b289 Chicony Electronics Co., Ltd
Bus 001 Device 004: ID 18d1:4ee1 Google Inc. Nexus 4
Bus 001 Device 002: ID 8087:0024 Intel Corp. Integrated Rate Matching Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
For libfreenect2.so, part of the results are as follows.
$ ldd libfreenect2.so
linux-vdso.so.1 =>  (0x00007ffdab585000)
libusb-1.0.so.0 => /home/libfreenect2/examples/protonect/../../depends/libusb/lib/libusb-1.0.so.0 (0x00007ff81e761000)
......
I don`t know how to solve my problems, could you give me some help?
Thank you so much!

Protonect is working and not printing any [TransferPool::submit] failed to submit transfer errors and kinect2_bridge is printing those errors, right?
To which libfreenect2.so does kinect2_bridge link? And does that one also link to /home/libfreenect2/examples/protonect/../../depends/libusb/lib/libusb-1.0.so.0 ?

Oh, I think you found the problem.
For "Protonect is working and not printing any [TransferPool::submit] failed to submit transfer errors and kinect2_bridge is printing those errors, right?", my answer is yes.
I checked $ldd ~/iai_kinect2/devel/lib/kinect2_bridge, it linked to /usr/local/lib/libfreenect2.so.
Then I $ldd /usr/local/lib/libfreenect2.so, it shows that
libusb-1.0.so.0 => /lib/x86_64-linux-gnu/libusb-1.0.so.0
Is there anything wrong with it or should it link to other location? THX!

Did you added the modifications to the cmakelists.txt from libfreenect2? If so, just make and sudo make install libfreenect2 and try again.

@wiedemeyer you are right. The problem is that I forgor to modify the CMakelists.txt out of my carelessness. Maybe you have the same mistake @Wissou and you can check it.
In the end, I have one more question. In rviz, if I use "Image", now I could get the visulization of all of the topics. But if I want to use "PointCloud2" or "Camera", they failed. Is it because I don`t set the correct Fixed Frame? I searched a lot and made some tries but they all failed.
Looking forwards to your reply!

For getting a point cloud, you need to start it using roslaunch. The launch file starts the nodes responsible for creating the point clouds.
As frame you have to select kinect2_link if I remember correctly.

Sorry its not kinect2_link... BTW, do you know where we could get the information of correct fixed frame? I mean it seems that information of fixed frame couldnt be found in Cmakelists.txt or package.xml. I

kinect2_rgb_optical_frame should work

Yes, it works!
Thank you so much for your help!

hello ,
sorry I was in travel , here what I got when I ldd .I did the modifications you mention above to Cmakelistes.txt from the beginning and my is kernel > 3.13 , but I still have the same problem with  [TransferPool::submit] failed to submit transfer :
wissem@wissem-SVE14A15FFB:~$ ldd /home/wissem/libfreenect2/examples/protonect/lib/libfreenect2.so
linux-vdso.so.1 =>  (0x00007ffed61b7000)
libusb-1.0.so.0 => /home/wissem/libfreenect2/depends/libusb/lib/libusb-1.0.so.0 (0x00007f6a8b5d3000)
can you help me ...

To which libfreenect2.so does kinect2_bridge link and to which libusb does that libfreenect2.so link?

Any update or can we close this issue?


Crash on nullable foreign keys with slices

Given the models:
from django.db import models

class Foo(models.Model):
    name = models.CharField(max_length=100, blank=True, null=True)

class PointsToFoo(models.Model):
    foo = models.ForeignKey(Foo, null=True)

And given the following settings (note the FkNullFix):
DATABASES['default'] = {'ENGINE': 'dbindexer', 'TARGET': 'native'}

DBINDEXER_BACKENDS = (
    'dbindexer.backends.BaseResolver',
    'dbindexer.backends.FKNullFix',
    'dbindexer.backends.InMemoryJOINResolver',
)

Querying for null foreign keys generates the following crash:
from django.test import TestCase
from artproject_debug.models import PointsToFoo

class DBIndexerNullableFK(TestCase):
    def test_dbindexer(self):
        filtered_queryset = PointsToFoo.objects.filter(foo=None)

        # force query to occur (yes, twice is necessary)
        list(filtered_queryset[:500])
        list(filtered_queryset[:500])

Traceback:
======================================================================
ERROR: test_dbindexer (artproject_debug.tests.DBIndexerNullableFK)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/wilfred/work/gap2/artproject_debug/tests.py", line 10, in test_dbindexer
    list(filtered_queryset[:500])
  File "/home/wilfred/work/gap2/django/db/models/query.py", line 85, in __len__
    self._result_cache.extend(self._iter)
  File "/home/wilfred/work/gap2/django/db/models/query.py", line 276, in iterator
    for row in compiler.results_iter():
  File "/home/wilfred/work/gap2/dbindexer/compiler.py", line 27, in results_iter
    self.convert_filters()
  File "/home/wilfred/work/gap2/dbindexer/compiler.py", line 19, in convert_filters
    resolver.convert_filters(self.query)
  File "/home/wilfred/work/gap2/dbindexer/resolver.py", line 31, in convert_filters
    backend.convert_filters(query)
  File "/home/wilfred/work/gap2/dbindexer/backends.py", line 68, in convert_filters
    self._convert_filters(query, query.where)
  File "/home/wilfred/work/gap2/dbindexer/backends.py", line 75, in _convert_filters
    self._convert_filters(query, child)
  File "/home/wilfred/work/gap2/dbindexer/backends.py", line 78, in _convert_filters
    self.convert_filter(query, filters, child, index)
  File "/home/wilfred/work/gap2/dbindexer/backends.py", line 167, in convert_filter
    self.fix_fk_null_filter(query, constraint)
  File "/home/wilfred/work/gap2/dbindexer/backends.py", line 184, in fix_fk_null_filter
    self.unref_alias(query, alias)
  File "/home/wilfred/work/gap2/dbindexer/backends.py", line 170, in unref_alias
    unref_alias(query, alias)
  File "/home/wilfred/work/gap2/dbindexer/backends.py", line 145, in unref_alias
    query.table_map[table_name].remove(alias)
ValueError: list.remove(x): x not in list

The FKNull fix modifies a lot of internal variables of the query (which is django.db.models.sql.Query here). When the query is reinitialized for the second call the table_map somehow reuses old columns lists (without the column that the fix removed) -- this already is bad.
Here's branch with a fix:
https://github.com/django-nonrel/django-dbindexer/tree/feature/nullable-foreign-keys-with-slices
I've inadvertent branched from develop with some previous tests merged, but it should be enough to change the table_map modification in unref_alias to modify a copy of list it contains:
query.table_map[table_name] = [t for t in query.table_map[table_name] if t != alias]

Moreover, it would be nice to just decrease the alias reference count in unref_alias (so we don't run into similar trouble with some future Django internal query code changes) -- but this would at least require more testing.

This fix won't work as-is with python2.5 as it uses collections.Mapping which was introduced in python 2.6

I'm testing with 2.5 (2.6 for Mongo) / 2.7 before pushing / merging now, so nothing like this should go unnoticed again :-) Can't see any Mapping on this branch, but going to reroll it anyway because too many insignificant changes have crawled in.

Retested and cleaned up:
https://github.com/django-nonrel/django-dbindexer/compare/feature/nullable-foreign-keys-with-slices-2


training process came out loss = nan

Hey Groups , thanks for the great work . I were using the template demo to reproduce the result , however during the traing process,the Loss=nan showed up , the program was still going on and on ,
the command was like
python train.py --opt configs/bagel.yaml
python train.py --opt configs/cat_armor.yaml

[ITER 1] Video Save Done! [03/06 17:25:29]
Training progress:  10%|███████████▍                                                                                | 490/5000 [03:31<30:44,  2.45it/s, Loss=nan]scale up theta_range to: [45, 105] [03/06 17:29:00]
scale up radius_range to: [4.9399999999999995, 5.225] [03/06 17:29:00]
scale up phi_range to: [-180, 180] [03/06 17:29:00]
scale up fovy_range to: [0.24, 0.6] [03/06 17:29:00]
Training progress:  20%|███████████████████████▏                                                                                | 990/5000 [06:57<26:05,  2.56it/s, Loss=nan]scale up theta_range to: [45, 105] [03/06 17:32:26]
scale up radius_range to: [4.693, 5.0] [03/06 17:32:26]
scale up phi_range to: [-180, 180] [03/06 17:32:26]
scale up fovy_range to: [0.18, 0.6] [03/06 17:32:26]
Training progress:  20%|███████████████████████▏                                                                                | 1000/5000 [07:01<26:54,  2.48it/s, Loss=nan

Also I tried not only sd-2-1 but also sd1.5 same issues

Hi, I also encounter this problem, did you solve it?


use children instead of childNodes

Since childNodes doesn't exist in IE11, this.element.childNodes would break.
[...this.element.children] explanation:

this.element.children returns a NodeList of the child nodes. This doesn't have the forEach method we have afterwards.
we then spread into a new array [...array] to convert a NodeList to a normal array. Babel converts the spread into something equivalent that IE11 can run.
we can now call forEach normally

👍
Thank you!


Counter API is overly restrictive

Currently Counter's API is:
https://github.com/prometheus/client_rust/blob/master/src/metrics/counter.rs#L76-L83
    /// Increase the [`Counter`] by 1, returning the previous value.
    pub fn inc(&self) -> N {
        self.value.inc()
    }

    /// Increase the [`Counter`] by `v`, returning the previous value.
    pub fn inc_by(&self, v: N) -> N {
        self.value.inc_by(v)
    }

which requires inc and inc_by to return the previous value. This is rarely needed for metric collecting use-case, and it hinders the ability to use per-thread thread-local accumulator to prevent contention (like this) and increase performance.

I believe a thread local counter will benefit the performance.


gb cgo support broken on OSX 10.10.3?

I tried a gb build of a project and got lots of errors from gb.
"_fdb_transaction_set_option", referenced from:
__cgo_eebe09c45e95_Cfunc_fdb_transaction_set_option in 000000.o
(maybe you meant: __cgo_eebe09c45e95_Cfunc_fdb_transaction_set_option)
"_fdb_transaction_set_read_version", referenced from:
__cgo_eebe09c45e95_Cfunc_fdb_transaction_set_read_version in 000000.o
(maybe you meant: __cgo_eebe09c45e95_Cfunc_fdb_transaction_set_read_version)
"_fdb_transaction_watch", referenced from:
__cgo_eebe09c45e95_Cfunc_fdb_transaction_watch in 000000.o
(maybe you meant: __cgo_eebe09c45e95_Cfunc_fdb_transaction_watch)
"_snappy_compress", referenced from:
__cgo_775f1b88ab3b_Cfunc_snappy_compress in 000002.o
(maybe you meant: __cgo_775f1b88ab3b_Cfunc_snappy_compress)
"_snappy_max_compressed_length", referenced from:
__cgo_775f1b88ab3b_Cfunc_snappy_max_compressed_length in 000002.o
(maybe you meant: __cgo_775f1b88ab3b_Cfunc_snappy_max_compressed_length)
"_snappy_uncompress", referenced from:
__cgo_775f1b88ab3b_Cfunc_snappy_uncompress in 000002.o
(maybe you meant: __cgo_775f1b88ab3b_Cfunc_snappy_uncompressed_length, __cgo_775f1b88ab3b_Cfunc_snappy_uncompress )

Thanks for the error report. Can you include a link to the source or instructions on how to reproduce a project that shows this.

I contacted your email regarding this issue.

@newhook can you please try now #301 has landed.

Timed out. I'm hoping this is fixed, please reopen if not.


Create cypress/browsers that supports Firefox 100 and Firefox 101

Make images for Cypress 10.x that include ff100 and ff101 for general consumption.

Closing this as we have images that support these now.


no such function: MagicalEntangle

I am having an issue with sqlite database. I just installed fresh logica and sqlite3 (pip install logica, apt install sqlite3) on Debian.
root@80dcb49fb4fc:/src# cat foo.l
@Engine("sqlite");

Foo(id:"E1", name:"Foo 1");
Foo(id:"E2", name:"Foo 2");

Bar(id:id, name:name) :- Foo(id:"E1", name:);

CountNotE1(count? += 1) distinct :- Foo(id:), ~Bar(id:);
root@80dcb49fb4fc:/src# python -m logica foo.l print CountNotE1 > foo.sql
root@80dcb49fb4fc:/src# cat foo.sql
WITH t_0_Foo AS (SELECT * FROM (

    SELECT
      'E1' AS id,
      'Foo 1' AS name
   UNION ALL

    SELECT
      'E2' AS id,
      'Foo 2' AS name

) AS UNUSED_TABLE_NAME  )
SELECT
  SUM(1) AS count
FROM
  t_0_Foo AS Foo
WHERE
  ((SELECT
    MIN(MagicalEntangle(1, x_3.value)) AS logica_value
  FROM
    t_0_Foo AS t_1_Foo, JSON_EACH(JSON_ARRAY(0)) as x_3
  WHERE
    (t_1_Foo.id = 'E1')) IS NULL);
root@80dcb49fb4fc:/src# sqlite3 ':memory:' '.read foo.sql'
Error: near line 1: no such function: MagicalEntangle
root@80dcb49fb4fc:/src#

Hello @mikko-ahonen !
Thank you for clear instructions to reproduce the error!
Yes, this is exected. Raw SQLite is generally missing some functions that advanced Logica functions need to be implemented, so Logica is enriching SQLite with more functions from Python. This includes MagicalEntangle function
which is used to disambiguate scope in aggregating expressions. You are using negation, which is implemented via aggregating expression and thus getting this error.
You can run only very simple programs via sqlite3 binary.
It is supposed that you'd run Logica program directly with logica like so:
$ python3 -m logica foo.l run CountNotE1
+-------+
| count |
+-------+
| 1     |
+-------+

Btw, in the rule Bar(id:id, name:name) :- Foo(id:"E1", name:); you don't have variable id assigned. It's probably intended to be as such Bar(id:id, name:name) :- Foo(id:, name:), id = "E1";.
Is this is a workable method for you?
If not, I'd be curious to learn about your usecase and we can try to find a solution.
Thank you!
Evgeny.

This is not really a problem for me, as I am executing the queries from python.
But I think this could bite others starting with the product. I would expect "print" command to print out sufficient functions so that I can copy paste the code into the SQLite command line tool.
This would help the debugging.
But like said, this is not blocking me or anything.

Just to add, I imagine typically people who are taking the product for a spin would do exactly like I did. So they probably use print because that shows you exactly what is happening, and then you can copy-paste it to command line SQL client. Also using SQLite is probably the first option because it does not require you to set iany server up. In many places in the public docs it appears as if only BigTable is supported which was a huge blocker for me. Luckily I tried it out anyway.

Yeah, that's a good point. I'll be clean up docs asap. Thank you!


Channel movement is still bugged

Solving puzzles drops them 2 spaces below the most recent green checkmark. Presumably this is either an issue with channel.move() or the way we're counting category channels.

I am "pretty" sure I've seen this problem in Bot-Be-Named before, I just cant remember the exact cause. I recommend just printing a list of channels and their positions. That's what explained the weirdness.
It was some combination of "Voice channels and/or categories themselves occupy positions" and "0 based indexing was really 1 based indexing" IIRC.


[Universal] Unpin docker-in-docker Feature version

https://github.com/devcontainers/images/pull/728 pins docker-in-docker Feature version to changes before https://github.com/devcontainers/features/pull/669.
v2.4.0 is failing docker startup 9/10 times in the universal image. It's strange that the Feature works perfectly, it is just causing issues with the universal image. See https://github.com/devcontainers/features/issues/671#issuecomment-1702809633

Closing as deployed!


Realsense Firmware Release Notes

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS> (old) /<IP_ADDRESS> (updated)

Operating System & Version
Linux (Ubuntu 16)

Kernel Version (Linux Only)
4.15.0-72-lowlatency

Platform
PC

SDK Version
Not sure

Language
Python

Segment
Robot

Issue Description
I am working on resolving an issue with bad values detected on of the IR channels of a RS camera that was fixed by power cycling the camera. I am curious to know if anything like this had been addressed since the last time we upgraded our firmware- where can I find the Release Notes for the firmware? I was able to find this page https://github.com/IntelRealSense/librealsense/wiki/Release-Notes, but it seems to be missing any reference to the older firmware version...

found the release notes here: https://www.intel.com/content/dam/support/us/en/documents/emerging-technologies/intel-realsense-technology/RealSense-D400-Series-Spec-Update.pdf


Add a game called Color blast!

it a fun game like destroying color shotting blocks please assign me @theDeviser

the issue has been assigned to you


第五步下载不了

总是显示
python3: can't open file 'rearrange_speaker.py': [Errno 2] No such file or directory
ERROR:root:File 'download_model.py' not found.

请问这样该怎么办

刚才又走了一遍流程，没有任何问题。很难判断你碰到了什么异常情况，通用建议是重启笔记本

现在显示无法连接到GPU后端了

colab免费额度到了，一天就6小时，等明天刷新再试

谢谢

现在是第三步出错了

AssertionError                            Traceback (most recent call last)
/content/VITS-fast-fine-tuning/preprocess_v2.py in
25         if speaker not in speakers:
26             speakers.append(speaker)
---> 27     assert (len(speakers) != 0), "No audio file found. Please check your uploaded file structure."
28     # Source 3 (Optional): sampled audios as extra training helpers
29     if args.add_auxiliary_data:
AssertionError: No audio file found. Please check your uploaded file structure.

请问这是怎么回事？

No audio file found. Please check your uploaded file structure.

请问该如何确认

前面步骤都没有出错

https://github.com/Plachtaa/VITS-fast-fine-tuning/blob/main/DATA.MD


Update Prometheus to 2023-08-03

This brings latest Prometheus up to 2023-08-03's 61daa30bb which includes https://github.com/prometheus/prometheus/pull/12626 which is the commit  I need.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.9 out of 15 committers have signed the CLA.:white_check_mark: roidelapluie:white_check_mark: beorn7:white_check_mark: krajorama:white_check_mark: bboreham:white_check_mark: marctc:white_check_mark: colega:white_check_mark: cuishuang:white_check_mark: gouthamve:white_check_mark: rfratto:x: shoce:x: gberche-orange:x: shichanglin5:x: fatsheep9146:x: juliusv:x: prymitiveshoce seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

There are quite a lot of changes here, including many @krajorama's changes for native histograms.
I think the most sensitive change is the one about switching to a linked list for chunks  https://github.com/prometheus/prometheus/pull/11818

@colega I changed this PR to draft to avoid accidentally merging it.


NLog 4.5 does not seem to work for projects on ASP.NET Core 1.1 targeting full .NET FW 4.6.1

Type:

Bug (possibly)

NLog version: 4.5
Platform: .Net 4.5
Current NLog config xml, but not relevant
In case of a BUG:

What is the current result?
The app crashes

What is the expected result?
The app does not crash and logs.

Did you checked the Internal log?
No

Please post full exception details (message, stacktrace, inner exceptions)
When the app starts this is what is logged in "Output" window in VS:
'WebApplication1.exe' (CLR v4.0.30319: DefaultDomain): Loaded 'C:\WINDOWS\Microsoft.Net\assembly\GAC_32\mscorlib\v4.0_<IP_ADDRESS>__b77a5c561934e089\mscorlib.dll'. Symbol loading disabled by Include/Exclude setting.
'WebApplication1.exe' (CLR v4.0.30319: DefaultDomain): Loaded 'R:\nlog45issue\WebApplication1\bin\Debug\net461\WebApplication1.exe'. Symbols loaded.
'WebApplication1.exe' (CLR v4.0.30319: WebApplication1.exe): Loaded 'R:\nlog45issue\WebApplication1\bin\Debug\net461\Microsoft.AspNetCore.Hosting.dll'. Symbol loading disabled by Include/Exclude setting.
'WebApplication1.exe' (CLR v4.0.30319: WebApplication1.exe): Loaded 'R:\nlog45issue\WebApplication1\bin\Debug\net461\Microsoft.AspNetCore.Hosting.Abstractions.dll'. Symbol loading disabled by Include/Exclude setting.
'WebApplication1.exe' (CLR v4.0.30319: WebApplication1.exe): Loaded 'C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\netstandard\v4.0_<IP_ADDRESS>__cc7b13ffcd2ddd51\netstandard.dll'. Symbol loading disabled by Include/Exclude setting.
'WebApplication1.exe' (CLR v4.0.30319: WebApplication1.exe): Loaded 'R:\nlog45issue\WebApplication1\bin\Debug\net461\Microsoft.Extensions.DependencyInjection.Abstractions.dll'. Symbol loading disabled by Include/Exclude setting.
An unhandled exception of type 'System.TypeLoadException' occurred in Unknown Module.
Method 'ConfigureAppConfiguration' in type 'Microsoft.AspNetCore.Hosting.WebHostBuilder' from assembly 'Microsoft.AspNetCore.Hosting, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' does not have an implementation.

Are there any workarounds? not sure

Is there a version in which it did work? NLog 5.0-beta09

Can you help us by writing an unit test? maybe (IMHO this is more related to application dependencies and configuration)

I followed the instructions from the WIKI (https://github.com/NLog/NLog.Web/wiki/Getting-started-with-ASP.NET-Core-(csproj---vs2017))
As the title specifies, my project is ASP.NET Core 1.1 targetting full .NET FW (v 4.6.1).
Here is a repo with the problem reproduced using instructions from the WIKI:  https://github.com/hiredgunhouse/nlog45issue

I think the problem is that NLog.Web.AspNetCore  is build on ASP.NET core 2 and not 1 for .NET 4.6.1
see nuget:

unfortunately we can't build 1 package with ASP.NET core 1  + ASP.NET core 2 support for the same platform.

Platform: .Net 4.5

Your config says 4.6
https://github.com/hiredgunhouse/nlog45issue/blob/master/WebApplication1/WebApplication1.csproj#L4

I suspect that is exactly the problem that you use abstractions from .NET Core 2.0 basically meaning you do not support earlier versions but I'm not .NET Core expert.
If this is true, does that mean NLog is not an option for .NET Core 1.x projects?
That's not what MS was promising to us with .NET Core :/
Regarding the reported platform, you bug template did not have 4.6 that's why I chose 4.5.

I suspect that is exactly the problem that you use abstractions from .NET Core 2.0 basically meaning you do not support earlier versions but I'm not .NET Core expert.

We do support ASP.NET Core 1, but only when using .NET Framework 4.5 or .NETStandard 1.5+
When you're using .NET Framework 4.6+ or .NETStandard 2+, we currently only support  ASP.NET Core 2

Ok, thanks for clarification. I'm closing the issue.
PS. Maybe it would be good to update the WIKI page I linked to.

I've updated the wiki pages with a warning.
See

https://github.com/NLog/NLog.Web/wiki
https://github.com/NLog/NLog.Web/wiki/Getting-started-with-ASP.NET-Core-(csproj---vs2017)
and https://github.com/NLog/NLog.Web/wiki/Getting-started-with-ASP.NET-Core-2

But it's not that strange requirement, if you check:
https://www.nuget.org/packages/Microsoft.Extensions.Logging/

Microsoft.Extensions.Logging 1.x supports only .NETStandard 1.1
Microsoft.Extensions.Logging 2.x supports only .NETStandard 2

and if you check:
https://docs.microsoft.com/en-us/dotnet/standard/net-standard

for .NET standard 2.0 you need .NET Core 2 or .NET standard 4.6.1
.NET 4.6 and  Microsoft.Extensions.Logging 1.x  is supported, but only with an older version of NLog.Web.AspNetCore


[BUG] Crash on launch.

Running your most recent v1.0.1, I'm getting a client crash on launch. From the crash log, I'm seeing repeated instances of this:
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Variable modifier method changeLimbDistance(FLnet/minecraft/class_1309;FFLnet/minecraft/class_4587;Lnet/minecraft/class_4597;I)F in alaskanativecraft.mixins.json:client.LivingEntityRendererMixin failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap alaskanativecraft-refmap.json
Which suggests the problem is in /src/main/java/com/github/platymemo/alaskanativecraft/mixin/client/LivingEntityRendererMixin.java. I took a look at the code, and can't find anything that looks terribly incorrect or out of place, so it might be a mod incompatibility issue. Full list of mods included below:
I'm running MultiMC, with Minecraft Version v1.16.5, LWJGL v3.2.2, Intermediary Mappings v1.16.5 and Fabric Loader v0.11.1.

It wasn't an incompatibility (thankfully, cause testing each mod would take a while lol), I just used name-based searching for variables in the mixin, which does not seem to work in production, so I switched to the safer ordinal based (which I should've used in the first place...).


fixed getStateSpace return type

Fix for Issue #535
Fix was tested in libcozmo's StateSpace class.

Before creating a pull request

[x] Document new methods and classes
[ ] Format code with make format

Before merging a pull request

[x] Set version target by selecting a milestone on the right side
[ ] Summarize this change in CHANGELOG.md
[ ] Add unit test(s) for this change

Thanks for the fix! @aditya-vk can you update the CHANGELOG?

Feel free to merge when Travis is happy!


Removed utils and scooby

This PR removes a dependency (scooby) and the utils/report module which appear to be unrelated to the core tephigram functionality.

Looks like this was originally added in https://github.com/SciTools/tephi/pull/58
I don't have a particularly strong preference for whether we keep it or not (although I do prefer a smaller codebase!)
It may be worth checking with @bjlittle ?

I'm not convinced as to what this adds (for the user) over doing:
$ conda info
$ conda list

Or for the user to install scooby themselves and do scooby.Report() on the command line.
For the developer it caused errors in the documentation build that I had to resolve, and is an additional dependency we have to stay on top of.
My vote: Benefits do not outweigh the overhead. But happy to keep it in if it is demonstratably useful

My vote: Benefits do not outweigh the overhead.

I'm inclined to agree. Investigating bugs usually needs back-and-forth anyway, so we'd be able to get the information in conversation with the raiser, and without the extra architecture.

@jamesp It is unrelated to the core of tephi and I'm happy to nuke it.
I was exploring the option of giving users an really simple one-liner option to capture their environment package dependency setup when reporting an issue, with the aim to helping tephi developers.
TBH it's a bit over-engineered and not worth the baggage, so let's purge it :+1:

@jamesp Can you also remove the reference to tephi/utils/* in the .coveragerc, then we're good to bank this :+1:


polyphony opcode inactive after key release

When setting polyphony=1, Sfizz limits the polyphony only on keys currently held.
If you have a long ampeg release and let go of the key (the sound keeps ringing), new notes do not cut off the previous ringing notes.

Yes most polyphony checks ignore released voices in their counting right now, which allows for clickless "killing" of notes. I have to check the behavior of other implementations.

When using
<region> sample=*saw ampeg_attack=0.1 ampeg_release=10 polyphony=1

in sforzando it does indeed cut the release phase short.
I think we'll need to consider an offed state on top of the released state for the voices.

Should be ok now you can reopen if it's not !

I could only test it briefly today, but it looks like both this and note_selfmask is working perfectly now. Thanks!


Breaking: t.end requires test.async, and t.plan will not auto end tests. Fixes #244.

See #244

Overall, I like it.
There are a few places where it creates some weirdness. All resolve around our async assertions (t.throws(rejectedPromise), t.throws(rejectedObservable)).
test('this does not work', t => {
  var promise = Promise.reject(new Error('foo'));

  t.throws(promise);
  // we do not return a promise, so AVA assumes this is a synchronous function
});

There are a number of easy ways around this this. The issue will be preventing user confusion.
(Ordered from best to worst workaround IMHO)
test('use async/await', async t => {
  var promise = Promise.reject(new Error('foo'));

  await t.throws(promise);
});

test('return the assertion promise', t => {
  var promise = Promise.reject(new Error('foo'));

  // t.throws returns a promise, so return it from our test function.
  return t.throws(promise);
});

test.async('legacy async with a plan', t => {
  t.plan(1);
  var promise = Promise.reject(new Error('foo'));

  // test is auto-ended once this resolves and we reach our plan count.
  t.throws(promise);
});

I like this last one the least. As previously stated, I think allowing t.plan() to auto-end tests is a bad choice that causes confusing false positives. Since we are biting the bullet with a major breaking change here, I would love to see us correct that as well.

(Ordered from best to worst workaround IMHO)

#1 is how I already use it and how it was intended. We should just document it better.

I think we have a resolution in https://github.com/sindresorhus/ava/issues/244, unless there's anything else that's still undecided? Could you rebase this PR?

This is ready for review.
// @sindresorhus @vdemedes
I have updated the docs to reflect the new behavior, with a few language tweaks along the way.

Looks good to me, except for a few inline comments :)
@vdemedes ?

✅from me.

Today is a major holiday in the US, so I won't be wrapping this up untill tomorrow.

@jamestalmage No worries at all. Enjoy Thanksgiving :D

Ahhh, Windows!
@sindresorhus - I'll start looking into it here, but can you just retrigger the build? I was watching that one, and it was running REALLY slow. I think something was wrong on that VM.

Done

OK, CI passed.
Are we good here? I think all concerns are addressed.

:+1: Excellent. I'm super excited about this!


fail to compile from repo

Tried to compile solo2 from the repo in order to get rid of the need to have a smartcard in my reader (which is built into ma laptop). But build fails.
Here's what I did:
git clone https://github.com/solokeys/solo2-cli.git solo2
cd solo2/
cargo build

Build runs fine for quite a while, but finally fails with this error message:
   Compiling solo2 v0.1.2 (/home/user/temp/solo2)
   Compiling serde_yaml v0.8.23
   Compiling serde-big-array v0.3.2
   Compiling toml v0.5.8
   Compiling ureq v2.4.0
error: there is no argument named `uuid`
   --> src/bin/solo2/main.rs:336:61
    |
336 |                     let url = format!("https://s2pki.net/s2/{uuid}/x255.txt");
    |                                                             ^^^^^^

error: could not compile `solo2` due to previous error

LinuxMint 20.3 (underlying Ubuntu 20.04) running here, rustc 1.57.0+dfsg1+llvm-0ubuntu1~20.04.1, cargo 0.58.0-0ubuntu1~20.04.1, gcc 9.3.0
I'd be happy to provide more info, pls feel free to ask.

You need to update to Rust 1.58 for the "format strings": https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html#captured-identifiers-in-format-strings.
I'll bump the rust-version entry in Cargo.toml.


Pass the ISPyB DCIDs from the ISPyB callback to the Zocalo one using the emitted document

Fixes #1192
Tidies up the implementation of emit in the PlanReactiveCallback and uses it to forward documents from the ISPyB callback to the Zocalo callback, after appending the DCIDS to it.
To test:

Run tests

Do we even need a separate run to trigger zocalo on. If the only reason we needed to do that was that we needed a valid ispyb deposition before we could trigger zocalo then just the fact we have an ispyb_id in the doc is enough for zocalo to be triggered? In fact it feels like this might mean we can entirely remove the inner runs and simplify the plans somewhat?

I think so, but can we investigate this in a different issue? This one is already getting kind of big, but I think it allows us to tidy up in a few different places, like #1199

Maybe, yes. Do you mean that we change the ISPyB callback to be a LiveDispatcher? It seems like a big job but it looks like it should work. The way I envisaged this heading is that, if I've understood correctly eventually there will be some message bus for documents which we should use instead anyway, to which everything can subscribe and emit back if needed, and this is preparatory in that at least all the callbacks are only getting and putting information into documents.

Yes, I think the ISPyB it could be a LiveDispatcher. Though it looks like LiveDispatcher only processes events, not start/stop docs so it may have to be something that just looks like a LiveDispatcher. Yes, I think we're envisaging the same thing. It just seemed a bit cleaner to me that rather than having to pass zocalo in as an emit, which seems like a special case, you think of it as the ispyb callback creating a new event stream that has ids on it, and you can later subscribe to it.

No, in src/hyperion/external_interaction/callbacks/main.py...

My bad, sorry.

I think so, but can we investigate this in a different issue?

Sure, https://github.com/DiamondLightSource/hyperion/issues/1204

I think it would only really be cleaner if we had more things to use it with than just this one case, which is the only one in the whole application. It's a lot of extra boilerplate to keep a list of subscriptions, manage dispatching to them, etc.

Not if we push the boilerplate into bluesky. But I think you've convinced me that it's overkill for now, worth keeping in the back of our minds as a possibility though. I will re-review this PR this afternoon


OpenID Connect :  ID Token iss claim does not match issuer

I am using the OpenID Connect implicit flow with response_type=id_token described on this page with the common tenant :
Authority: https://login.microsoftonline.com/common/v2.0
The configuration (https://login.microsoftonline.com/common/v2.0/.well-known/openid-configuration) shows :
issuer : "https://login.microsoftonline.com/{tenantid}/v2.0"
The configuration for the organizations tenant shows the same issuer. I don't know why there is a variable tenantid here in the first place, plus we have no idea what it refers to.
Per the OpenID Connect specifications (https://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation) :

The Issuer Identifier for the OpenID Provider (which is typically obtained during Discovery) MUST exactly match the value of the iss (issuer) Claim.

By using the common tenant, my ID Token contains :
iss : "https://login.microsoftonline.com/9188040d-6c67-4c5b-b112-36a304b66dad/v2.0"
The issuer doesn't exactly match the iss claim so the token can't be validated since it doesn't follow the protocol specifications.
The issuer matching this claim is the one available in the consumers tenant configuration (https://login.microsoftonline.com/consumers/v2.0/.well-known/openid-configuration).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d3746e5-5147-d996-ba4f-350fd1d086ef
Version Independent ID: afff03f1-16c3-9866-39b0-bdddd0e55d7d
Content: Microsoft identity platform and OpenID Connect protocol - Microsoft Entra
Content Source: articles/active-directory/develop/v2-protocols-oidc.md
Service: active-directory
Sub-service: develop
GitHub Login: @nickludwig
Microsoft Alias: ludwignick

@Khivar
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Hey @Khivar,
Yeah, that's expected behavior. Since /common can mean the user is a part of any AAD tenant or even the Microsoft account tenant (i.e., you're using a personal account), we can't put an actual tenant id into the issuer field returned by from the /common OIDC metadata endpoint or else nobody would be able to validate any tokens. Instead, we use {tenantid} which represents a placeholder for you to replace with the tenant id contained in the tid claim within your token. After replacement, this is what you compare against the iss claim for token validation.
You could also technically use the tenant specific OIDC metadata endpoint (by splicing the tenantid value returned in tid into the OIDC metadata url), but I recommend against this as it doesn't scale well.

Closing due to lack of follow up/no required docs changes

#please-close

hi i use spring boot with oauth2 client and want to use azure ad b2c as idp
my problem is issuer-uri in spring is
https://imaxspg.b2clogin.com/imaxspg.onmicrosoft.com/B2C_1_federated/v2.0/
to get well-known openid configuration
notice that i have put policy in url
but when spring do a http call to get meta data
issuer does not contain policy so spring would say
the Issuer provided in the configuration metadata did not match the requested issuer


Fix playground share link

Description

Closes #2526
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How to test

Check that share links work properly
Checklist

[x] I have tested this code

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.494%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5267

Relevant Lines:
13577

💛  - Coveralls


_check_for_inline_script needs to do more than just grep for 'run'

First, let me say, I think this project is awesome and I want to help make it better if I can.  :)
I'm creating this ticket as I wanted to have a discussion about how the ASA project identifies issues going forward.  I thought about creating a PR and adding some code myself but wanted to have a conversation first.
I think the _check_for_inline_script function needs to be modified to do more than just check for the presence of 'run' in the action step.  I understand that the GitHub Action hardening guide calls out inline scripts, but there needs to be a delineation between say a bash script is called from a remote location versus a run command that executes a binary in a specific action, like, say semgrep or npm.  Right now, _check_for_inline_script will create a lot of false positives for many legitimate uses of the run action.  Just take a look at the Semgrep Action: https://semgrep.dev/docs/semgrep-ci/sample-ci-configs/#sample-github-actions-configuration-file or the NPM Action:  https://github.com/actions/setup-node.  And there are thousands of others where the Action calls an executable inside the docker container that Action maps to.
tl;dr:
The use of 'run:' by itself should not be a finding, but if 'run:' calls a script or other insecure mechanism, then it should absolutely be a finding.
Let me know your thoughts.

Yeah, I definitely agree, and that's why I assigned a level of WARN to the check_for_inline_script. The intention is to only notify the developer that they have an inline script so as to remind them that these are potentially dangerous. This is the reason I've added the --ignore-warnings argument to ignore the checks that may be a bit noisy.
I could also just remove the check_for_inline_script because the check_for_script_injection check actually identifies the real security issue with using inline scripts and that's when you directly include a dangerous github.* variable in it.
If you would like to commit some code, please free to do so !! 🙂

I'm also going to be working on improving the granularity of some of these checks - this was only meant to be a Proof-of-Concept that I needed to create for an effort at my job to improve the security of our open-source projects.

Yup, it's a great proof of concept, and as I said, I'm a fan, so don't think I was being critical.  :)
There are at least two issues with inline "scripts":  one is the script injection attack that you point out where a malicious actor takes advantage of people calling github.* variables directly without the use of the intermediary variable.  The second issue involves calling remote scripts, or other remote configurations that malicious actors could change without the person calling the script knowing.  This is akin to the classic curl https://example.org/install.sh | sh , but only worse, because the remote configuration is being called with automation (GitHub Actions) and the source can change at anytime without anyone knowing.
Soooo, all of that is to say that I think check_for_inline_script should stay, but in a modified form where it's actually looking for these remote file type attacks.
We should also address if calling a script from inside the repo as part of the action is a separate detection or not.
Lemme do some research on the best way to introduce this function and I'll circle back.

That totally makes sense - we should be able to put together a regular expression regarding the remote script inclusion. Something along the lines of
(curl|wget|iwr|Invoke-WebRequest).*\|.*(sh|bash|iex|Invoke-Expression)

I'm also considering Windows PowerShell in the above regex even though they are less commonly as runners.

Closing issue since PR was created to address this issue.


Addition/Removal of Orders

In order to morph AB4 to FoodZoom, we need to allow for the addition and removal of orders.
This is a change which requires:

[ ] Change in Storage Structure (xml files to store order information)
[ ] Change in Modal
[ ] Change in Logic (add new commands + parsing for those commands)

We'll need to have a discussion on how our storage structure should look.


syntax refactor

Only syntax refactor,

remove unused return null;
a in b write in b.a will more clear;
wrappers only have one property helper;
_restore and _destroy were simplified as delete item.sortable.

Coverage decreased (-0.6%) to 99.383% when pulling b68ae26f0eaad6ca7bb647f5887b984eb3da0b9d on wuliupo:master into 4bb4493f18faa5c4a9aaa3780e4b173ccf5a1ea2 on angular-ui:master.

Coverage decreased (-0.6%) to 99.383% when pulling 8e728b45ed8a9175f185d6440c5b49b24b552442 on wuliupo:master into 4bb4493f18faa5c4a9aaa3780e4b173ccf5a1ea2 on angular-ui:master.

Please don't create a hure diff. Try not moving methods until the initial refactor gets reviewed.
Keep in mind that targeting the absolute min number of code lines can hurt the debug-ability of the code. Also refactoring chained method invocations to be in the same line can hurt the readability of the code.


Icons don't display on progress form

Seems most users don't have FontAwesome icons on the progress form.  Not sure why.  :thinking:

Appears to be fixed in v0.4.0


Be able to generate client from openapi specification for build

Feature idea
Following this project https://github.com/dcdh/formula-interpreter/blob/master/pom.xml
the openapi-generator-maven-plugin is used to generate client in typescript based on openapi yaml file produce by the quarkus-smallrye-openapi dependency.
The build is done this way:

build openapi yaml
generate typescipt client using openapi-generator-maven-plugin at prepare-package phase
Just after build the project using frontend-maven-plugin also at prepare-package phase

Regarding quinoa, building the openapi.yaml and the project is done in only one phase at build one. So I am not able generate my typescript client after openapi.yaml generation and before building the project.
So it will be nice if it was possible split the build into two: build for backend services and prepare-package for frontend one with the ability to do something between them (like code generation).
Regards,
Damien
Additional information

I understand what you are saying. I use Orval to generate my TypeScript for React Query from OpenApi right now I just do it as 2 steps.  Generate the OpenApi JSON then I copy that to my webui and run npm run codegen

I am using it using this kind of configuration:
application.properties:
quarkus.smallrye-openapi.store-schema-directory=src/main/webui/
mp.openapi.extensions.smallrye.operationIdStrategy=METHOD

package.json
{
// ...
  "scripts": {
    "dev": "orval --config ./orval.config.ts && react-scripts start",
    "build": "orval --config ./orval.config.ts && react-scripts build",
    "test": "react-scripts test --env=jsdom"
  },
// ...
}

This way endpoints are generated add dev starting and build stages. No need to generate next copy to webui

Wow this is awesome!  Going to try it tomorrow!

@dcdh ok i am adding this to the docs for other people in the future.


Maximum for cmd_idx?

I have a test case that ran for a very long time. I think it might have wrapped cmd_idx.
# ** Fatal: (vsim-3421) Value -2147483648 is out of range 0 to<PHONE_NUMBER>.
#    Time: 245549350 ns  Iteration: 1  Process: /my_vvc/cmd_executor File: UVVM/uvvm_util-2.15.1/src/protected_types_pkg.vhd Line: 188
# Fatal error in Subprogram t_protected_check_counters.decrement at UVVM/uvvm_util-2.15.1/src/protected_types_pkg.vhd line 188
#
# HDL call sequence:
# Stopped at UVVM/uvvm_util-2.15.1/src/protected_types_pkg.vhd 188 Subprogram t_protected_check_counters.decrement
# called from  UVVM/uvvm_util-2.15.1/src/methods_pkg.vhd 5798 Subprogram check_value_in_range
# called from  UVVM/uvvm_util-2.15.1/src/methods_pkg.vhd 6045 Subprogram check_value_in_range
# called from  UVVM/uvvm_vvc_framework-2.11.1/src/ti_protected_types_pkg.vhd 235 Subprogram t_vvc_activity.priv_report_vvc_activity
# called from  vip_my_vvc/src/vvc_methods_pkg.vhd 612 Subprogram update_vvc_activity_register
# called from  vip_my_vvc/src/my_vvc.vhd 230 Process cmd_executor
#
#  tb
#  UVVM/uvvm_util-2.15.1/src/protected_types_pkg.vhd 188 return [address 0x7feff09fc20e] Subprogram t_protected_check_counters.decrement
# called from  UVVM/uvvm_util-2.15.1/src/methods_pkg.vhd 5798 return [address 0x7feff0a27d8b] Subprogram check_value_in_range
# called from  UVVM/uvvm_util-2.15.1/src/methods_pkg.vhd 6045 return [address 0x7feff0a2e5c2] Subprogram check_value_in_range
# called from  UVVM/uvvm_vvc_framework-2.11.1/src/ti_protected_types_pkg.vhd 235 return [address 0x7feff0ae6978] Subprogram t_vvc_activity.priv_report_vvc_activity
# called from  vip_my_vvc/src/vvc_methods_pkg.vhd 612 return [address 0x7feff0d0b00e] Subprogram update_vvc_activity_register
# called from  vip_my_vvc/src/pixel_if_vvc.vhd 230 return [address 0x7fef8d2eb44d] Process cmd_executor

Hi,
I think you are right. The vvc_cmd_idx is a natural, hence its maximum value will be<PHONE_NUMBER>. First time I've seen anyone encounter this.
Br,
Marius

Hi Ronny,
I've done some checking and the error is triggered by the priv_check_counters() method wrapping on line 188 in the protected_types_pkg. We will add a fix that will perform some checks and print out a warning if the counter is about to wrap around - expect the fix to be included in the next release. In the meanwhile you can try to comment out line 180 and 188 in the protected_types_pkg.
Br,
Marius

Hi Ronny,
I've checked and actually this issue is due to a check_counter that wraps around. There is a bug in the check_counter method, but I also think we need to add an internal checker with some sort of alert messaging if the counter is reaching its upper limit. I think we can have this fix in our next release, and in the meanwhile you can make the fix yourself by changing from -1 to 1 in the protected_types_pkg:
   procedure decrement(       check_type : t_check_type;       number     : integer := -1     ) is
to
   procedure decrement(       check_type : t_check_type;       number     : integer := 1     ) is
Remember to fix both the declaration and body.
Br,
Marius

Fixed in v2021.05.26 release


Added support for JSON Feed version 1.1

Looks good. Thanks. I like your authors!

You are most welcome, had to keep the theme going!!


feat(chart/opensearch): add ability for serviceMonitor basicauth

Description
Right now there is non possibility to set a basicAuth configuration for the serviceMonitor. This PR adds it
Check List

[x] Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

[x] Helm chart version bumped
[x] Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon any update here? Thanks!

@peterzhuamazon any update here?

Hi @TheAlgo @prudhvigodithi please take another pass before I give an approval.
Thanks.

Pinging @prudhvigodithi @TheAlgo again to co-review.
Thanks!

@prudhvigodithi @TheAlgo @peterzhuamazon Another attempt at getting this merged!
Please review! Thank you!

Adding @TheAlgo @prudhvigodithi @DandyDeveloper @gaiksaya to take a look.
Thanks!

Hi Team,
When we can expect a 1.3.x version of this changes (#593 as well)?
Thanks,
Danish

As soon as this gets merged I will backport it.

Will rebase today

Ready for Review @TheAlgo @DandyDeveloper @gaiksaya @prudhvigodithi

As soon as this gets merged I will backport it.

Thanks much @eyenx !!

backport for #593 is here https://github.com/opensearch-project/helm-charts/pull/636

Thanks @eyenx we can get this merged.


Update read-editions.md to indicate 4.0 GA

@PatrickFarley

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


More Polygon and Line predicates

Add predicates for identifying polygons and lines within other polygons or touching other polygons or lines.

Fixed as of ccd1b5f43a8f06ab7114eb36b14eedf8b5dffcea


eth_contract_from_vk assumes the backend serializes public input data in the vkey

Problem
Trying to integrate eth_contract_from_vk of the SmartContract trait for a halo2 backend.
Barretenberg provides the number of public inputs in the vkey and handles commitments with each input.
However, Halo2 simply grabs the entire instance column (pub input wire polynomial) and commits to it. The snark-verifier package needed to generate evm contracts must know both the number of instance columns used AND the number of inputs for each column.
In practice, there is currently no way to use the existing acvm backend API and the halo2 verification key to generate a smart contract. We have gotten the functionality fully working and tested with different numbers of public inputs, however we have to hard-code the number of public inputs in eth_contract_from_vk.
Happy Case
As the halo2 backend currently exists, the minimum necessity would be to have the API optionally accept num_public_inputs: usize. This is because the backend currently only has one instance column and will only ever serialize the inputs in a single wire polynomial. Including this functionality would unblock the current halo2_backend work.
However, this limits the possibility of using multiple instance columns in halo2. Currently, the black box functionality is highly limited. However, with ECC and other functionality added, there is a possibility that the most efficient implementation uses another instance column rather than appending every public input to the single input column. In this case, it might be desirable to add an optional circuit: Circuit parameter as is required with [prove_with_pk](https://github.com/noir-lang/acvm/blob/fc3240d456d0128f6eb42096beb8b7a586ea48da/acvm/src/lib.rs#L141) (for one example). This would allow the circuit to compute the exact number of public values per instance column.
Alternatives Considered
Opening issues to investigate serializing the number of public inputs per instance column in the verification key for Halo2, though this is largely superfluous information to the verification of the proof
Additional Context
Largely open to suggestions/ other diagnostics to accomplish this goal
Would you like to submit a PR for this Issue?
No
Support Needs
No response

Pardon the stupid questions as I likely lack the essential knowledge and contexts:

have the API optionally accept num_public_inputs: usize

Isn't the number of public inputs determinable from the compiled ACIR?

add an optional circuit: Circuit parameter as is required with prove_with_pk

Do you mean exposing the option for Noir devs to access and tinker with multiple instance columns at the Noir level?

No they are good q's!

Isn't the number of public inputs determinable from the compiled ACIR?

Yes, if we pass in a circuit: Circuit parameter, we could call circuit.public_inputs() to obtain the absolute number of public inputs. Passing in num_public_inputs is just the absolute minimum but I think passing in the ACIR is preferable.

Do you mean exposing the option for Noir devs to access and tinker with multiple instance columns at the Noir level?

Probably not. This would be quite an interesting feature to control the proof composition from Noir, but this would clash with Noir's main goal of abstracting these parts of ZKP away from the dev.
Instead, I am thinking about Aztec contributors adding different backends into Noir. In the case of Halo2's backend, having access to the entire ACIR allows us to calculate how many public inputs are used in each instance column if we elect to add more instance columns as future black box functions are added.
As of the current halo2_backend, we wouldn't need to do anything more than call circuit.public_inputs()!

I think adding the Circuit to the function signature should be fine -- if possible, can you open a PR?

@kevaundray if this looks right, should I open pr's for nargo and acvm-backend-barretenberg as well to make sure things work with barretenberg?

if this looks right, should I open pr's for nargo and acvm-backend-barretenberg as well to make sure things work with barretenberg?

Nah, don't worry about this. We can handle this in the next release rollout as it'll be a small additonal change (You'd end up dealing with more of our changes that we would yours).


[PUI] User interface for barcode (receive) scanning

This PR adds the concept of actions for each known barcode model and implements an action to receive lines from POs.
Contains #5509
Closes #5748

Not stale!

Not stale


NSwag, csharp client generation SingleClientFromOperationId in c#

I'm trying to use NSwag in C# to generate a CSharp based httpClient from an OpenAPI spec.
The generated HttpClient has some issues which I know why are caused but I cannot seem to find anything in the settings to specify on how to generate it. It should be generated using the OperationGenerationMode as SingleClientFromOperationId
OpenApiDocument document = await OpenApiDocument.FromUrlAsync(webApplication.Configuration["GreenFlux:OpenAPIUrl"]);

CSharpClientGenerator cSharpCodeGenerator = new CSharpClientGenerator(
    document,
    new CSharpClientGeneratorSettings
    {
        ClassName = webApplication.Configuration["GreenFlux:ClassName"],
        CSharpGeneratorSettings =
        {
            Namespace = webApplication.Configuration["GreenFlux:Namespace"],
        },
        GenerateClientInterfaces = true,
        ClientClassAccessModifier = "internal",
    });

string openApiHttpClient = cSharpCodeGenerator.GenerateFile();

string filePath = Path.Combine(
    Directory.GetCurrentDirectory(),
    webApplication.Configuration["GreenFlux:Folder"],
    $"{webApplication.Configuration["GreenFlux:ClassName"]}.cs");

new FileInfo(filePath).Directory!.Create();

File.WriteAllText(filePath, openApiHttpClient);

@remus-corneliu  where you able to find out where to specify this when using NSwag via c# code?


What is the expected number of sets?

What should the expected number of sets be? The total number of sets of non-conflicting (at the row level) addresses?
For example, on a dual channel system, with 2 ranks/DIMM and DDR4 (16 banks), does that lead to 2 * 2 * 16 = 64 sets? Based on the default value of 8, I'm guessing that's not correct...

64, yes. The number of sets you specify is a minimum + you only need half of the sets to know all of them.Am 24.11.2018 23:55 schrieb travisdowns notifications@github.com:What should the expected number of sets be? The total number of sets of non-conflicting (at the row level) addresses?
For example, on a dual channel system, with 2 ranks/DIMM and DDR4 (16 banks), does that lead to 2 * 2 * 16 = 64 sets? Seems like too many if you have the default value at 8...
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.


@superset-ui/core and  @superset-ui/chart-controls npm packages not up to date.

@villebro
Is it possible to update npm packages for @superset-ui/core and @superset-ui/chart-controls?
Those are currently at version 1.5.0 in npm repo.
Not a huge issue but causes few issues when doing external plugin development.

@rusackas , Is there a tentative date as to when the packages will be updated?

The @superset-ui npm packages have been updated to match the latest 2.1.0 version of superset. I'll go ahead and close this ticket.

@eschutho ,
I tried using the packages, seems like the esm/lib folder isn't present in the package.

The same can be seen at https://www.npmjs.com/package/@superset-ui/core?activeTab=code

+1 on this — the packages are empty, making them completely useless. The 1.5.0 version of the package seems to have esm & lib folders with code in them though, so there must have been a bad release for 2.1.0.
Any update on this?

@villebro , @kakoni  , @rusackas
Any update on this?

@kakoni @villebro @rusackas @michael-s-molina @eschutho @harryspeedum @iest appreciate any updates on it. I don't see the lib and esm folders on the 2.1.0 version. The 1.5.0 version seems fine.

Hello team,
What steps are needed to publish the packages again?
Is this achievable using the GitHub Actions?
How can we assist with this?

@villebro , @kakoni , @rusackas , @eschutho
Would you have an update in this ? Thanks in advance 👍

We were just discussing this... I don't think I've personally done it since the pre-monorepo days. @eschutho might have some docs around it, or @villebro might know. I want to document it and make it part of the regular release process, but right now I'm a bit stumped too... I'll do more digging.


Detail and Edit Popup Buttons not working as updateRelatedObjectLinks doesn't find target elements

Hey there,
we are experiencing an issue with our current setup. We are using the TabularInline class to show related objects. Django admin creates buttons for viewing the edit (change) or detail pages. However, they are not working.
The reason is that the vanilla admin library uses updateRelatedObjectLinks() to replace the __fk__ part of the href by the real value. When using unfold, this part does not work. The jQuery function stops as no siblings are found and the fk remains unchanged, e.g. like this:
visibility
Now, when I replace the admin function with a custom one that deals with the - apparently changed - HTML it works again.
My adaption of the admin jQuery function (in plain Javascript):
function updateRelatedObjectLinks(triggeringLink) {
    const selectElement = triggeringLink;
    const parentElement = selectElement.closest('.flex-row');
    const siblings = parentElement.querySelectorAll('.view-related, .change-related, .delete-related');
    const value = selectElement.value;
    if (value) {
        siblings.forEach(function (elm) {
            const template = elm.getAttribute('data-href-template');
            const updatedHref = template.replace('__fk__', value);
            elm.setAttribute('href', updatedHref);
        });
    } else {
        siblings.forEach(function (elm) {
            elm.removeAttribute('href');
        });
    }
}

The original gets the siblings like that:
       const siblings = $this.nextAll('.view-related, .change-related, .delete-related');
without the parentElement.
I tried to overwrite the admin function with my own, but this is quite hacky. Am I doing something wrong or is there a problem in the way unfold creates the HTML for the TabularInline?
Thanks!

Hey Tobias, thank you very much for detailed report. I just rolled version 0.6.3. You can test it and let me know if everything is okay. You can test it on demo site as well:
https://unfoldadmin.com/demo/formula/race/1009/change/

Yes, now it works without my modifications, great!