Semver Check for Removing a Bound on Impl

Issue overview
I found out about this project and then recently happened to read this interesting article which included a note about an existing "semver hazard":

Interestingly, while it is true that you can remove bounds from a struct (today, at least) and be at semver complaint3, this is not the case for impls. For example if I have
impl<T: Copy> MyTrait for Vec<T> { }
and I change it to impl<T> MyTrait for Vec<T> this is effectively introducing a new blanket impl, and that is not a semver compliant change (see RFC 2451 for more details).

I've checked and making this change gives no warning so it seems to not be implemented yet. There's a chance the article is wrong as I actually am not 100% sure how to reproduce this semver uncompliant behaviour because I keep running into coherence rules stopping me from reproducing something in another crate that would be broken by this change. However given their Rust experience I would be inclined to take this claim at face value.

An aside on contributing
I'd be interested in implementing this, largely out of just general interest, and I was looking to make a PR with this in due time but I quickly got out of my depth.
I began to put forward some work to making this and I would note that I spent about 30-45 minutes fumbling around because I didn't know GraphQL but more importantly because I didn't understand where CrateDiff, ImplParent, etc. all come from. I eventually figured out it comes from trustfall-rustdoc-adapter and I would personally recommend linking to this, specifically to rustdoc_schema.graphql in Contributing.md to save others time.

My work so far
I'll start with an apology for the length of this section. If I had more time to familiarize myself I think I would be able to write significantly less about this. I'm essentially trying to dump the majority of the information I have as I don't know how to filter it down to the useful portions.
This actually seems to be a bit trickier than I initially expected to implement. To start with it seems that vital data, specifically the generics property on Impl has not been typed in graphql yet. This in of itself would not be a critical problem as there's many types that aren't but unfortunately it seems to be a quite complex property. Besides being a deep type it also uses enums and there's no examples as far as I can tell of an enum implementation elsewhere.
Here's an example of the json given: {"trait_bound":{"trait":{"name":"Into","id":"2:3190:150","args":{"angle_bracketed":{"args":[{"type":{"kind":"primitive","inner":"u8"}}],"bindings":[]}}}}}. Yes, some of these are union types in Rust code and should reflect that way in GraphQL more than likely.
This has been my first go at implementing it in trustfall-rust-adapter on the graphql side (sent as a txt file for brevity): Generic.txt. It's quite likely there's invalid syntax or the like here but I think this is how it'd have to be implemented. While there's a lot of missing variants in these enums (| {} is used to allow an unimplemented variant) if the mapping is going to be 1:1 this is how it should look like.
*I'm not actually sure what an edge actually is contextually, it seems to be used for anything that isn't simple like a boolean though.
Unfortunately I think it may be even more complex from the Rust side of the adapter, there's so many new types to adapt for starters and enums seem annoying. For this reason I think maybe it should be decoded into a graphql type that looks like this:
type GenericTraitBound {
     bound_str: String; # something like "T: Copy", "T: Into<u8>" etc.
}

If this is possible, the logic would be as simple as if bound_str from baseline becomes null it's a semver breaking change. As a side-effect its also easy to display, turning the accurate graphql back into a string seems quite painful. Unfortunately this does limit checking other bounds changes that could easily be breaking.

Hi David! This is awesome! Thanks for digging into cargo-semver-checks and Trustfall so deeply, and sorry for the sharp edges. I literally only yesterday pulled the adapter and schema out of this repo and into trustfall-rustdoc-adapter in #133, and #139 fixes the schema link in CONTRIBUTING.md exactly as you suggest, but sadly hasn't merged yet. Really unfortunate timing, and I'm sorry about that.
I've added this new semver issue to the list in #5, which is where we keep track of which lints are being implemented where.
If you're still interested in going for this, I'm happy to mentor and help out in whatever form is most useful.
Implementing generics and their bounds well in the schema is going to be a bit tricky because of their complexity and recursive nature (Foo<Bar<Baz<A>>, Quux<B>>), so this won't be the easiest lint to get started with: it will require multiple new vertex types, edges, and properties in the Trustfall schema, and they aren't going to be trivial to design.
If you'd like, I can also suggest an easier one where the schema and query are a bit more straightforward, so you don't have to jump right into the deep end.
Finally, here's a query playground where you can run some Trustfall queries against the rustdoc of the top ~100 crates on crates.io. It can't do comparisons between versions (no CrateDiff vertex type) but might still be useful for getting a hang of the query language: https://play.predr.ag/rustdoc

Is there a messaging platform outside of Github issues that we can communicate through more quickly? I would love to send back and forth some messages that don't fit into the niche buckets of what's in an issue. I decided to pivot towards implementing must_use as it seems to have been much easier, though I'm struggling to add any new property, I keep getting stuff like CompilationError(ValidationError(NonExistentPath(["CrateDiff", "baseline", "item", "attribute", "path"]))) despite my best efforts (it's in the graphql file and rust file etc. but I'm obviously missing something). I may attempt to pick this up later once I've done more.
There's a couple of things I would like to ask, for example what operations for @filter have been implemented. I found here a list of operations but the only one I've verified as working is has_substring and not_has_substring. But I have many other small questions like whether you'd like to implement a monorepo style you can always do what Rust does, a git subtree, to make PRs across what would otherwise be multiple repos easier etc. See this old issue with git subtree, as well as this article which touches on it.

Here's an example of the json given: {"trait_bound":{"trait":{"name":"Into","id":"2:3190:150","args":{"angle_bracketed":{"args":[{"type":{"kind":"primitive","inner":"u8"}}],"bindings":[]}}}}}. Yes, some of these are union types in Rust code and should reflect that way in GraphQL more than likely.

A hybrid approach between this and the bound_str approach might be best: have an interface type that all the "union" variants implement, and have the interface include the bound_str property while the types that implement the interface have the more detailed structure.
Trustfall isn't quite GraphQL (just syntactically equivalent so we get moder editor conveniences for free) and doesn't currently support unions. It's probably not that difficult add support for them, and I'm happy to mentor for that as well, but I'm not sure how many repos you're okay with touching with your first contribution here 😅

This has been my first go at implementing it in trustfall-rust-adapter on the graphql side (sent as a txt file for brevity): Generic.txt. It's quite likely there's invalid syntax or the like here but I think this is how it'd have to be implemented. While there's a lot of missing variants in these enums (| {} is used to allow an unimplemented variant) if the mapping is going to be 1:1 this is how it should look like.

It's quite difficult to review schemas in isolation like this — it's easy for a schema to look "completely fine" but then end up not supporting some key query. I'd recommend writing down some key queries together with the new schema and seeing how they might pan out.

*I'm not actually sure what an edge actually is contextually, it seems to be used for anything that isn't simple like a boolean though.

It's ultimately up to the person designing the schema to decide what makes sense to be an edge. Pretty much the only thing that must be an edge is if you have a one-to-many relationship between objects that aren't simple scalars or (nested) lists of such, like "items in a crate" i.e. the Crate -[item]-> Item edge. If you have a one-to-one relationship, you can choose to make it an edge or you can choose to "inline" one type into the other — this is purely a schema ergonomics decision.
If you have Twitter, ping me there and we can find a platform that works better? If not, shoot me an email at the email address in my commits?

Is there a messaging platform outside of Github issues that we can communicate through more quickly? I would love to send back and forth some messages that don't fit into the niche buckets of what's in an issue. I decided to pivot towards implementing must_use as it seems to have been much easier, though I'm struggling to add any new property, I keep getting stuff like CompilationError(ValidationError(NonExistentPath(["CrateDiff", "baseline", "item", "attribute", "path"]))) despite my best efforts (it's in the graphql file and rust file etc. but I'm obviously missing something).

I'm happy to debug this together. The error message sounds like you are trying to look up a path property on Attribute (CrateDiff -[baseline]-> Crate -[item]-> Item -[attribute]-> Attribute) but the schema says value is the only field on that type. Here's a playground link.

There's a couple of things I would like to ask, for example what operations for @filter have been implemented. I found here a list of operations but the only one I've verified as working is has_substring and not_has_substring.

Nice! The link you found is the predecessor project to Trustfall, which is similar in many ways. I'm sorry that Trustfall documentation is badly lacking at the moment — it's something I intend to spend significant time on in the rest of the year. A list of questions would be extremely helpful for me to know what docs to write first, so please send it over or just ask me and I'll write them down.
These are the supported operations and their names currently:
https://github.com/obi1kenobi/trustfall/blob/86b74b8336b4c1301d7a02d1309d684df58cf437/trustfall_core/src/graphql_query/directives.rs#L116-L139

But I have many other small questions like whether you'd like to implement a monorepo style you can always do what Rust does, a git subtree, to make PRs across what would otherwise be multiple repos easier etc.

On changing the repo style and similar broad questions, I defer to @epage. The top priority is to make #61 happen as quickly as possible and with no speed bumps, and everything else is in service of that.


Invalid Solution File

When importing Error:
The solution file is invalid. The compressed file must contain the following files at its root: solution.xml, customizations.xml, and [Content_Types].xml. Customization files exported from previous versions of Microsoft Dynamics 365 are not supported.

Hi there
You are most likely trying to import the source code zip, instead of the solution file.
Download either the Managed or Unmanaged release from here, then try importing again
https://github.com/scottdurow/power-drag-drop/releases


Lookup for some language codes returned by YouTube api fail

When using YouTubeSubtitleFile, some language codes still fail or are resolved to inaccurate.

Failed: iw (old code for Hebrew), should be he
Possibly inaccurate: zh-Hans (simpflified Chinese) should be zh-CN
Possibly inaccurate: zh-Hant (traditional Chinese) should be zh-TW

Possible workaround
Add special handlers in getlang_by_alpha2 to handle these edge cases.
We can't know know which other non-standard language codes are used by YouTube API so we'll have to implement such fixes on a case by case basis...

This was fixed in #37


Additional Class / File for Lab Assignments and PE

For Lab assignments and PE, can we create extra classes that can help our code to run aside from all the stated classes in the problem statement?
I tried creating extra classes for lab 2 (which must be separated into several files - 1 class in each file) and when I submit to CodeCrunch, there is an error because the test cases do not open the additional files that I created. So, the class is not declared.

Probably the Codecrunch tester tries to run only specific files that match and compares the output afterward. So, you might want to restrict your filenames to the ones required in the prompt.
For Lab2, Codecrunch doesn't actually need the .jsh test files on your submission because they will run it behind the screen as the autograder. So, having it in your submission is just pure redundancy. However, the reason why it's there is because it was automatically submitted from your PE Nodes for you to download it again back at home.

~/.backup should be a directory, not a file. To create such a directory, you can do mkdir ~/.backup. To make sure it is accessible for writing (it should be, unless something strange has occurred), you can change the permissions via chmod 644 ~/.backup

Just out of curiosity, I'm wondering what the reasoning is behind the restriction for CodeCrunch to only include the filenames required in the prompt?
It seems to me that restricting this forces everyone into one "correct" design for their classes, when in fact there might be multiple ways to solve the same problem - each with its own strengths & weaknesses. I'd think that giving us the space to explore & experiment with different designs will help us learn a lot more quickly & deeply why a certain design might be better than another.
I can't imagine it being a technical difficulty - including *.java files seems trivial enough. Maybe for security reasons then? Though that doesn't seem like a completely convincing reason to restrict our submitted filenames so heavily.

Turns out for the Project, there is no restriction on your class names except for the Simulator class and the driver classes. So, I guess it depends on how are you calling the other classes correctly.

That makes sense! I guess my question was more directed to the labs rather than the project.

But now we've found a general conclusion, good catch also 😉👍

Hm not sure if I'm missing something, but I wouldn't be able to edit this test9.jsh file in your example to /open my additional files right? Like, I'd be able to do it locally where I can edit test9.jsh but doesn't CodeCrunch use its own copies of the test files (that I cannot edit)?

Yes, PE nodes are giving u the test jsh files for your reference but whether you submit or modify them or not at all, Code Crunch will use their own test jsh files and overwrites your test jsh submission files.


Move encrypt from optimized module to rewrite module

For #3061.

Pull Request Test Coverage Report for Build 433

42 of 60 (70.0%)  changed or added relevant lines in 25 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 65.526%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/api/statement/CommonOptimizedStatement.java
0
1
0.0%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/sharding/engnie/ShardingSelectOptimizeEngine.java
1
2
50.0%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java
0
1
0.0%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java
0
1
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java
0
1
0.0%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/api/OptimizedStatementFactory.java
0
2
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java
0
5
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/segment/dml/predicate/AndPredicate.java
1
0.0%

Totals

Change from base Build 406:
0.4%

Covered Lines:
9616

Relevant Lines:
14675

💛  - Coveralls


Waveshare 3.5 inches LCD

Did anybody manage to make this display work with raspberry pi3?
In kernel config display drivers are being built as modules, but still no luck. LCD shows just white screen the moment I put power on. Tried to do some "echo 0 > /dev/fb0" and "tail -f /dev/input/touchscreen0", no reactions on touch too.

From this documentation it seems that it needs OOT drivers: http://www.waveshare.com/wiki/3.5inch_RPi_LCD_(A)#Driver . I don't think anyone worked in adding support for it.

Checked the archives there - probably you only need those overlays.

@metamorphling Were you able to make it work?

Hopefully you managed to make it work. It would be great if you give us some feedback. I'll close the ticket for now. Do comment if there is anything we can help with.


cant find github.com/arstd/mooo/misc/fetch

cant find github.com/arstd/mooo/misc/fetch

Thank you, i fixed it.


Vector3 - Change all methods that modify coords to use set() only

Hello,
I had a tiny scenario where I wanted to make an immutable vector3 class which just extends Vector3 and forbids to modify its data by overriding the set(), but then I saw there are multiple methods that manually modify the coords. I thought it'd be easier just to override the set(), so I PR'd my suggestion.
Thanks in advance

It make code more readable & more extensible. I always use thing like that in my own code to reduce error when updating one function and not the other one & size of my .java
But I get that performances may be reduce ☹
It would be nice to have some actual data about it to choose whether to increase function calls or duplicate code.

Vector3 (and Vector2) are so heavily-used that even small performance changes would likely be noticeable by someone. This sort of change would probably be welcome in places that don't have operations happening potentially hundreds or thousands of times per-frame. I would really like to be able to look at some benchmarks and say, "Wow, all platforms we target now inline method calls with no overhead!" but I don't think we're there yet. There's also the other issue that it really isn't very much work this saves, and it caters to a use-case in one application. If we are catering to use-cases in one application, I have a whole list of things I want to get into libGDX:

Standard-range colors ideally should either be primitives or immutable objects. Immutable objects would be the most API-compatible, but aren't great for GC.
Json should be able to handle Maps with non-String keys (on the Java side) by converting the keys to JSON Strings.
Way too much stuff, throughout the library, is private or package-private. If API stability is the only thing holding these back from being at least protected, mark them with an annotation to say the API is internal and can change in any commit.
Java 8. Come on. Even without the library, there are useful language features that work cross-platform. We aren't going to be able to target Java 7 at all much longer if using current JDKs; Java 20 can't target bytecode compatible with Java 7.

Seriously. Come on. Even GWT can target language level 11 if using a current GWT release (like 2.10.0, which works just fine with libGDX if the backend is built for it).

A pony.

The code improvement makes a lot of sense. That said, method calls on Android are very slow, especially for methods that are used a lot. This probably applies to Vector3 here? I have a matrix multiplication class, where and removed most method calls resulting in a lot higher performance. Code-wise it's not as nice, but it's a lot faster.
I vote to reject the pull request (not because it's bad, but because it can be slow).

The majority of contributors seem to be in favour of closing the PR, so closing it is. Thanks @GadWissberg for taking the time to propose the change, though!


[Feature Request] Add methods to OpenIdConnectConfiguration for FrontchannelLogoutSessionSupported and FrontchannelLogoutSupported

Version 6x represented the metadata properties mapped to {"frontchannel_logout_session_supported", "frontchannel_logout_supported"} as strings see: OpenIdConnectConfiguration
The spec has them as boolean.
Newtonsoft will deserialize boolean values into strings and set them to "True" or "False".
If we change the type to bool and follow the spec, we could break users.
The safest thing to do is to obsolete the existing properties in 7, remove them later and add new that are of type bool.
The hard part will be to come up with new property names.

missed the opportunity to do this.


Finetuning with CuLane dataset on a model trained with TuSimple

Hello,
I have tried to fine tune the laneatt_r18_tusimple.pth model, by running this command:
python main.py configs/laneatt/resnet18_culane.py --finetune_from pretrained/laneatt_r18_tusimple.pth --gpus 1
But at the end I still get Best metric: 0.0
Any idea of what could I cange to improve it?

Ok, I was linking to the wrong dataset. My bad


CaffeEmitter has not supported operator [ResizeBilinear].

When I turn a tensorflow pose model into caffe model, it prompts the error "CaffeEmitter has not supported operator [ResizeBilinear].", my tensorflow pose model has this operator, So how can I solve it?
I have two thoughts:

Firstly add the ResizeBilinear layer in cafffe, then I use mmdnn, Do mmdnn support newly add layers in caffe? What does mmdnn work?

Another thought is to convert tensorflow model to caffe model directly because ResizeBilinear layer doesn't have weights, so I can remove correlation ResizeBilinear layer in my model structure, then I add these layers in caffe model prototxt manually(Assuming I have implemented ResizeBilinear layer in caffe).

Hi @ujsyehao, we can set the input node of tensorflow parser to skip this node. @namizzz can help with the argument of TF parser.

Thank you @kitstar, I have implemented ResizeBilinear layer in caffe(own) and am testing the newly added layer.
I am looking forward to @namizzz instructions, Can you give me some details about mmdnn's conversion to caffe?

Hi @ujsyehao ,Here is the README

@namizzz Hi, the README doesn't include skip nodes, Can you tell me how to set the input node of tensorflow parser to skip this node?

@ujsyehao  Please read the whole command in this part
--inputShape 224,224,3 --dstNodeName FeatureExtractor/MobilenetV1/Conv2d_13_pointwise_2_Conv2d_5_3x3_s2_128/Relu6 --inNodeName Preprocessor/sub

Hi, @ujsyehao
If you can skip this node, you can get IR from Tensorflow and then convert it to caffe model code file.Now you only need to add this layer into the caffe model.

@namizzz Hi, when I turn IR to caffe model, it shows the error:

CaffeEmitter has not supported operator [ResizeBilinear].

So I add emit_ResizeBilinear function in caffe_emitter.py,

However, I do not know IR_node.get_attr()(what's the IR properties of ResizeBilinear op).

Hi @ujsyehao
As you say ,you need to skip this node in Tensorflow parser first ,then get IR file to convert it to Caffe model file, so you will not meet this problem in CaffeEmit. Thanks!

@namizzz I don't need to skip this node in Tensorflow, I can directly modify conversion/caffe/caffe_emitter.py to make it support ResizeBilinear operator, code shown below:

then modify conversio/caffe/graph.py add this:

Hi @ujsyehao ,OK! It's pretty good you can add this part by yourself. Fisrt you need to get the attribute from the source_node, and then add the necessary IR properties in "rename_ResizeBilinear" op in the TF parser. If you use TF model file (.pb), you need to modify the "tensorflow_frozenparser". If you use .ckpt ,you need to modify the "tensorflow_parser".
Here is the Contribution-Guideline.Thanks and sorry!

For ResizeBilinear operation, I only implement IR -> caffe now, so I need to implement caffe -> IR(get the attribute from the source_node), IR -> tensorflow(add IR properties in TF parser and modify tensorflow_*parser).
Thanks for your kind! I will do later.

Hi @ujsyehao , yes!
But there is something wrong I think if you need to turn a tensorflow pose model into caffe model.

implement TF to IR (get the attribute from the source_node and also add IR properties to IR node) in the TF parser file.
2.IR to Caffe (get IR properties above).

Thanks!


Add unit tests

The OribiRichTextKit unit tests have not yet been ported.
We should do this before releasing 0.2.

This is done in 0.2.


removed winapi

https://github.com/ziglang/zig/commit/d817a3c5173a4f9e41c5872e58733287c9686018
https://github.com/ziglang/zig/commit/e7ead9c5eacde7eda94d39380ec8b6d474d49607

Minor point, but these should be under std/os/windows.


[Doc Improvement] [maintain-published-app]

added page maintain-published-app.md

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/maintain-published-app.md
100
0
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/maintain-published-app.md
100
0
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/maintain-published-app.md
92
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/maintain-published-app.md
92
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/maintain-published-app.md
92
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/maintain-published-app.md
92
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/maintain-published-app.md
92
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
14
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
14
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
14
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
89
14
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
88
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
88
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
88
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
87
16
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
87
16
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
7
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-apps-for-anonymous-user.md
90
10
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
90
14
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-extensible-conversation-for-meeting-chat.md
95
3
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-tabs-for-meeting.md
92
19
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
94
13
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/in-meeting-notification-for-meeting.md
94
3
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/meeting-apps-apis.md
97
17
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
91
10
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-live-share-media-capabilities.md
90
5
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
92
17
link
:white_check_mark:

msteams-platform/bots/bot-basics.md
89
23
link
:white_check_mark:

msteams-platform/bots/bot-features.md
95
4
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
94
6
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/real-time-media-concepts.md
97
2
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/registering-calling-bot.md
94
11
link
:white_check_mark:

msteams-platform/bots/design/bots.md
92
17
link
:white_check_mark:

msteams-platform/bots/how-to/Teams conversational AI/teams-conversation-ai-overview.md
90
11
link
:white_check_mark:

msteams-platform/bots/how-to/add-power-virtual-agents-bot-to-teams.md
94
6
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/add-authentication.md
87
94
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/bot-sso-graph-api.md
91
3
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md
93
30
link
:white_check_mark:

msteams-platform/bots/how-to/get-teams-context.md
92
5
link
:white_check_mark:

msteams-platform/bots/what-are-bots.md
95
3
link
:white_check_mark:

msteams-platform/concepts/app-fundamentals-overview.md
89
12
link
:white_check_mark:

msteams-platform/concepts/authentication/authentication.md
93
4
link
:white_check_mark:

msteams-platform/concepts/build-and-test/deep-link-application.md
92
13
link
:white_check_mark:

msteams-platform/concepts/build-and-test/prepare-your-o365-tenant.md
93
8
link
:white_check_mark:

msteams-platform/concepts/build-and-test/share-in-meeting.md
92
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/add-default-install-scope.md
91
4
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
7
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-apps-for-anonymous-user.md
90
10
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
90
14
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-extensible-conversation-for-meeting-chat.md
95
3
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-tabs-for-meeting.md
92
19
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
94
13
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/in-meeting-notification-for-meeting.md
94
3
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/meeting-apps-apis.md
97
17
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
91
10
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-live-share-media-capabilities.md
90
5
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
92
17
link
:white_check_mark:

msteams-platform/bots/bot-basics.md
89
23
link
:white_check_mark:

msteams-platform/bots/bot-features.md
95
4
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
94
6
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/real-time-media-concepts.md
97
2
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/registering-calling-bot.md
94
11
link
:white_check_mark:

msteams-platform/bots/design/bots.md
92
17
link
:white_check_mark:

msteams-platform/bots/how-to/Teams conversational AI/teams-conversation-ai-overview.md
90
11
link
:white_check_mark:

msteams-platform/bots/how-to/add-power-virtual-agents-bot-to-teams.md
94
6
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/add-authentication.md
87
94
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/bot-sso-graph-api.md
91
3
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md
93
30
link
:white_check_mark:

msteams-platform/bots/how-to/get-teams-context.md
92
5
link
:white_check_mark:

msteams-platform/bots/what-are-bots.md
95
3
link
:white_check_mark:

msteams-platform/concepts/app-fundamentals-overview.md
89
12
link
:white_check_mark:

msteams-platform/concepts/authentication/authentication.md
93
4
link
:white_check_mark:

msteams-platform/concepts/build-and-test/deep-link-application.md
92
13
link
:white_check_mark:

msteams-platform/concepts/build-and-test/prepare-your-o365-tenant.md
93
8
link
:white_check_mark:

msteams-platform/concepts/build-and-test/share-in-meeting.md
92
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/add-default-install-scope.md
91
4
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
7
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-apps-for-anonymous-user.md
90
11
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
90
14
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-extensible-conversation-for-meeting-chat.md
95
3
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/build-tabs-for-meeting.md
92
19
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/design/designing-apps-in-meetings.md
94
13
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/in-meeting-notification-for-meeting.md
94
3
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/meeting-apps-apis.md
97
17
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-apps-in-meetings.md
91
10
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-live-share-media-capabilities.md
90
5
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
92
19
link
:white_check_mark:

msteams-platform/bots/bot-basics.md
89
23
link
:white_check_mark:

msteams-platform/bots/bot-features.md
95
4
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
94
6
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/real-time-media-concepts.md
97
2
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/registering-calling-bot.md
94
11
link
:white_check_mark:

msteams-platform/bots/design/bots.md
92
17
link
:white_check_mark:

msteams-platform/bots/how-to/Teams conversational AI/teams-conversation-ai-overview.md
89
18
link
:white_check_mark:

msteams-platform/bots/how-to/add-power-virtual-agents-bot-to-teams.md
94
6
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/add-authentication.md
87
98
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/bot-sso-graph-api.md
91
3
link
:white_check_mark:

msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md
93
30
link
:white_check_mark:

msteams-platform/bots/how-to/get-teams-context.md
92
5
link
:white_check_mark:

msteams-platform/bots/what-are-bots.md
95
3
link
:white_check_mark:

msteams-platform/concepts/app-fundamentals-overview.md
89
12
link
:white_check_mark:

msteams-platform/concepts/authentication/authentication.md
93
4
link
:white_check_mark:

msteams-platform/concepts/build-and-test/deep-link-application.md
92
13
link
:white_check_mark:

msteams-platform/concepts/build-and-test/prepare-your-o365-tenant.md
93
8
link
:white_check_mark:

msteams-platform/concepts/build-and-test/share-in-meeting.md
92
15
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/add-default-install-scope.md
91
4
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Created a new PR #8894 with the same content, hence closing this PR.


Allow different base href in index.html for flutter web app for build

Use case
If I want to release my flutter web app I run flutter build web. Unfortunately I then need to deploy my app to a non root URL e.g. http://server.org/myapp/ and therefore I have to manually correct the base href in the index.html
I would like to set the base href e.g. in the build command something like this "flutter build web -Dhref=/myapp/ or similar.
Of course I can always post process the index.html with sed, but this is a litle bit less integrated.
If I just edit the index.html file directly then the debug use case does not work anymore.
Proposal
Allow to set the base href during build time.
If something like this is possible already, I probably would have expected to find the documentation here: https://flutter.dev/docs/deployment/web

Angular has this feature:  ng build --base-href.   https://angular.io/cli/build   This is handy for deploying files to a CDN

Angular has this feature:  ng build --base-href.   https://angular.io/cli/build   This is handy for deploying files to a CDN

Hi @sturmf ,
As far as I understood, you are changing the base URL after you compile the project. Am I right? In that case, you should change the base URL of your Flutter web app by setting it in the index.html file in the web folder before you compile it:
<base href="/">

As the comment in the file states, the base URL should start and end with /.
This way, all resources used in your app will have the right base URL, making your app work correctly and preventing 404 errors.
I hope this is useful for your or others who end up here.

you should change the base URL of your Flutter web app by setting it in the index.html file in the web folder

I think this issue is about setting the base href of index.html dynamically when building for web. This would allow for a better continuous integration while developing. Especially if you want deploy builds from development branches into different webserver subdirectories.

Could try a workaround with sed:
sed -i 's#<base href="/">#<base href="/your-path-here">#g' build/web/index.html

Here is a link which can be helpful - https://flutter.dev/docs/development/ui/navigation/url-strategies
Also, if you want to comment that that line out, comment it in base_folder/web/index.html.
And the use the command flutter build web.

Another option is to replace <base href="/"> with <base href="/your/app/path/"> in web/index.html. Note: that's not build/web/index.html, but the source web/index.html file!
Benefits that work well for me:

It puts the base path in the source and therefore, if you want, under version control.
flutter run respects the path and points the browser to `localhost:port/your/app/path".
flutter build web copies the path into build/web/index.html.

As mentioned above Flutter web supports changing the base tag and also appears to work in a relative fashion if you remove the base tag.

i removed the  and it seems to work anywhere

Error: The base href in "web/index.html" must be absolute (i.e. start with a "/"), but found: <base href="$FLUTTER_BASE_HREF">.
For example, to serve from the root use:
<base href="/">

To serve from a subpath "foo" (i.e. http://localhost:8080/foo/ instead of http://localhost:8080/) use:
<base href="/foo/">

For more information, see: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base.
this is my error coming


Something wrong in modify_method_of_instance function

Thanks for your code. I encountered the following issue while trying to extend the context length of Qwen1.5-14B-Chat. Do you know how I can fix this Exception? Many THX!
Traceback (most recent call last):
  File "/***/envs/qwen/lib/python3.11/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/***/envs/qwen/lib/python3.11/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/***/Qwen1_5/longlm/LongLM/pred.py", line 63, in get_pred
    SelfExtend.apply(model, group_size, window_size, enable_flash_attention=use_flash, flash_attention_impl="flash_attn")
  File "/***/Qwen1_5/longlm/LongLM/SelfExtend.py", line 179, in apply
    raise Exception(f"Failed to modify the attention method of {arch_name}")
Exception: Failed to modify the attention method of Qwen2ForCausalLM

Under the setting of:

transformers   4.38.2
flash-attn   2.5.5

This Exception is for the case: the targeted instance has no designated attention module within it. It may caused by:
You load the model without flash attention but set enable_flash_attention = True, or the reverse case.
If possible, you may check the attention module's name by simple print(model) before calling SelfExtend.apply

Got it! THX!


Add clock sun record table

This pull request includes several updates to the camtraptor package, primarily focusing on adding new columns to the get_record_table() output (see #341), updating the package version, and adding new tests to ensure the correctness of the new functionality.
Updates to get_record_table() function:

get_record_table() now returns four new columns: longitude, latitude, clock (clock time in radians), and solar (solar time in radians).

Package version and dependency updates:

Updated the package version from 0.26.0 to 0.27.0 in the DESCRIPTION file.
Added activity (for getTime() used for clock column) and overlap (for sunTime() used for solar column) to the Imports section in the DESCRIPTION file.

New helper function:

Introduced a new helper function add_coordinates() to add deployment coordinates to observations based on deploymentID.

New tests:

Added tests to ensure warnings are returned if some observations have no timestamp, and to check that clock and solar values are always within the range [0, 2*pi].

Cool new feature Damiano, well done!


NFC: Remove trailing whitespace

Non functional change. Removing trailing whitespace.

Wow, thank you! This PR touches pretty much every file. Would it be possible to split it up into smaller PRs for the different components of the project? Otherwise handling all the merge conflicts might be difficult.

Yep sure no problem. Let me know how I should split this up into smaller PRs

Perhaps one simple heuristic might be by subdirectory? Given that all of this is NFC, we can group the changes arbitrarily, so I don't have a strong opinion.

OK sure so is it enough to subdivide into include, src and test?


Stop vendorising for releases in the future

It seems that releases is preparing a new version 2 that may solve the issues that made us add it into sdsstools in the first place, namely an incompatibility with the newer semantic-version packages. At that point we may want to stop including releases in sdsstools or add it as a dependency. We can still keep the sdsstools.releases hook for backwards compatibility.

releases has been removed as of 1.0.0.


Natural Weapon Stacking does not appear to work properly with Dragon Bloodline claws

Gave this a quick test (TTT-Base disabled because of ongoing bugs) and there's no stacking - elemental riders or size up.
Getting it to work with claws from the same element bloodline or the ones before the element shows up could be finicky and required dedicated logic because those are the same weapon "item" and enchantment but it isn't working cross-element with the full power ones either which shouldn't have any special behavior?

Interesting. I think this may be a vanilla bug with second bloodline. There only seems to be one set of (dragon) claws present despite having two dragon bloodlines.
Some testing results for reference

clawsdebug.txt

Multiple instances of the same weapon blueprint across multiple bloodlines should be fixable, but it will probably be messy.

For bloodrager, at least part of the problem is that claws are added by a big if... else if ... else if ... chain so it only adds the first matching set of claws.

Oh yeah, Bloodrager claws just plain old needs a refactor to work with this setup.
Also, natural weapon blueprints gets reused so often by the game and modders that I don't think you can have multiple instances of the same weapon be ignored safely? Preventing the same buff from being stacked is alreeady handled at the buff layer.

I already check for different buffs, so the issue is mostly just the way those buffs work, which is solvable

Should be fixed in 0.9.6


Release Performance Analyser Root Cause Analysis Framework

Security Review on-going

RCA is now part of the PA in ODFE 1.9.0 Release.
https://opendistro.github.io/for-elasticsearch/blog/odfe-updates/2020/07/Open-Distro-for-Elasticsearch-1.9.0-is-released/


Base dsq/dstx thresholold on the total number of up to date masternodes

Mixing on a newer version with small number of upgraded masternodes causes mixing txes to "stuck" - old nodes refuse to relay dstxes from new ones because they come from the same masternodes too often. Basing threshold on the total number of up to date masternodes and not only on a newer (enabled) ones should solve this. This however will cause mixing to fail if there are not enough masternodes on the needed protocol version (i.e. at least GetMinMasternodePaymentsProto()) but it's better to stop mixing than having funds kind of spent yet not confirmed for a long time.

Is this in some way related to enabling SPORK_10_MASTERNODE_PAY_UPDATED_NODES on mainnet later? If yes, might also need to bump MIN_MASTERNODE_PAYMENT_PROTO_VERSION_2

@codablock kind of. There is no mn proto version in dip3, so spork 10 is going to be deprecated and thus bumping MIN_MASTERNODE_PAYMENT_PROTO_VERSION_2 is not needed imo.


dropbox: fix tray menu with StatusNotifierItem trays

Motivation for this change
If dropbox can't load libappindicator, it will fallback to using the old
xembed protocol. If you (or your Desktop Environment) are running
something like KDE's XEmbed SNI Proxy, then you'll at least see an icon,
but clicking the icon won't give you menu.
Adding libappindicator to the env allows dropbox to fully integrate with
contemporary status trays, while still falling back to xembed if the
required DBus service is not present.
This should also be backported to (at least) the nixos-19.03 channel.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

backported to 19.03 in 1a27474d47465d83ee890060080392e40aea1fa9

:sparkles: Thanks for fixing this @cstrahan


Add Zendesk to the list of adopters

Codecov Report

Merging #785 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
- Coverage   86.67%   86.59%   -0.09%
==========================================
  Files          71       71
  Lines        2282     2282
  Branches       93       88       -5
==========================================
- Hits         1978     1976       -2
- Misses        304      306       +2

Impacted Files
Coverage Δ

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
97.29% <0%> (-2.71%)
:arrow_down:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
96.03% <0%> (-1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06dba42...5fd2c9f. Read the comment docs.

Excellent, thanks @erwan!


CMD+V bug with Tmux on macOS

Specifications
OS: Tested in OS X 10.10.5 and macOS 10.12.1
Term: Test in Terminal.app and iTerm2
Tmux 2.3.1
$ micro --version
Version: 1.1.2
Commit hash: c04a4ba
Compiled on October 24, 2016
STR:

Copy some text (e.g. echo test | pbcopy)

Open micro

Press CMD+V (note: not ctrl-V)

Expected behavior:
Like ctrl-V, it should paste text
Actual:
Control characters confuse Tmux. If multiple windows are open, causes Tmux to change windows. With one window open output is:
200~test
[201~

I don't seem to be experiencing this issue anymore.

Still seeing it here.
$ micro -version
Version: 1.3.2
Commit hash: 2f587c6
Compiled on September 15, 2017

$ tmux -V
tmux 2.5

iTerm 3.1.1.

Same issue, with one interesting caveat: pasting in micro works just fine when launched under screen.
However, it does not work fine when launched directly from shell or from tmux, with exactly the same issue as above: when pasting [200~ appears on the fist line and [201~ [200~ on all the pasted subsequent lines.

I'm seeing the same issue on Windows using Terminal. Pasting
#!/bin/bash
echo hello
echo world

within a tmux session results in
[200~#!/bin/bash
echo hello
echo world[201~]]

appearing in micro.
As a point of reference, pasting the same text in nano results in the desired output.


New Mali Drivers support Hardware Acceleration?

Hi David,
I was wondering if this would help in your development?
I stumbled across this:
http://krblogs.com/post/65347946766/mali-drivers-on-chromebook
Apparently the new drivers enables hardware-accelerated graphics rendering with X11.
If this has already been looked at and dismissed, please disregard.
Thanks!

Did anyone get anywhere with running a second X server (sorry to "bump" this !) ?
More than anything, I'd love to be able to run gnome shell with reasonable performance on my ARM chromebook.


Documentation: REST API for On Demand Data Gathering

Description
Documentation: REST API for On Demand Data Gathering
Type of change

Documentation update

Testing steps
N/A
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Patch coverage has no change and project coverage change: -0.06 :warning:

Comparison is base (d8a0d57) 69.41% compared to head (1c63004) 69.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
- Coverage   69.41%   69.36%   -0.06%
==========================================
  Files          25       25
  Lines        3649     3649
==========================================
- Hits         2533     2531       -2
- Misses        861      863       +2
  Partials      255      255

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LGTM, but we should check how it's rendered in https://developers.redhat.com/api-catalog/

yes we have. It theory Markdown should be recognized and rendered correctly, but who knows...


Alok 38

🛠 Fixes issue #
Improved the aesthetic and the readability of the README.md file.
📇 Changes proposed
Some aesthetic changes were proposed. Updated the same post approval.
✅ Check List (Mark all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] This PR contains changes in the documentation
[x] This PR contains changes in the Code of the project
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
Please suggest/advice if more enhancements are needed.

📷 Screenshots

🛠 Fixes issue #
Improved the aesthetic and the readability of the README.md file.
📇 Changes proposed
Some aesthetic changes were proposed. Updated the same post approval.
✅ Check List (Mark all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] This PR contains changes in the documentation
[x] This PR contains changes in the Code of the project
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
Please suggest/advice if more enhancements are needed.

📷 Screenshots

Please make the pr title more clear on what changes does this pr make and please dont edit the allcontributors file, I only have the rights that's why and please revoke the changes made to the all-contributors.src file

And which issue does this pr refer to, please mention it

I have updated the issue number. I think I have missed out on this on a couple of occasions. I apologize for the same. It won't happen again.

I have updated the issue number. I think I have missed out on this on a couple of occasions. I apologize for the same. It won't happen again.

No Problem @alok-38 , Take your time to work on this

I touched the .all-contributorsrc by mistake. How do I revoke it?


The purpose of choosing languages you're interested in

Hey there,
What does choosing specific languages you're interested in actually do? I opened this up in my local environment hoping to tackle issue #67
But now that I'm clicking specific languages and unclicking them I don't see any difference in the news feed. What is it exactly that they do? I was hoping to work on #67 and sort the news feed dynamically by chosen languages but now I'm thinking simpler and even just highlighting the items that contain a language that has been favorited.
Is this something that could be useful?
Thanks,
Dan

When you add your favorite technologies, each card becomes unique. For example, you can see Typescript news from Devto and Python stuff on Reddit. This makes it super flexible. But I get it, you're thinking about combining all articles into one feed and letting users pick and choose by tech or source. right?

Ah I didn't see trending was clickable.
This makes it way better!
Putting it into one feed and being able to filter by language or source would be cool but honestly the way you have it is top notch. Great extension!


Many warnings in deployment log

Version: main
Steps:
Create a service and view revison log in the UI
Example:
2023-07-31T07:20:31.047Z [WARN]  ignoring file "registry.terraform.io/hashicorp/random/3.5.1.json" as possible package for registry.terraform.io/hashicorp/random: filename lacks expected prefix "terraform-provider-random_"
2023-07-31T07:20:31.047Z [WARN]  ignoring file "registry.terraform.io/hashicorp/random/index.json" as possible package for registry.terraform.io/hashicorp/random: filename lacks expected prefix "terraform-provider-random_"
...

Environment

Walrus version: main 9735afb411c8b8bef83e11d048bb6a93494ac3ff
UI version: dev-f0b97d5

Test Result: pass


Minor changes needed in API-design-guidelines.md for CloudEvents

What type of PR is this?

correction

What this PR does / why we need it:
Certain minor points have been identified within the design guidelines that need to be changed for the CloudEvents content.
Some editorial changes for better readability added.
Which issue(s) this PR fixes:
Fixes #83
Special notes for reviewers:
Changelog input
Corrections for Event subscriptions and CloudEvents notifications implemented

@RubenBG7 @jordonezlucena Please review this PR as code owners.


feat: support syntax check

Summary
Support syntax check in Rsdoctor, default use users browserslist config to detective syntax

To supplement the e2e test, you can create a scenario with ecma version error and check sdk. And check Is there a corresponding error in the errors of getStoreData().
e2e/cases/doctor-webpack/plugins/plugin.test.ts

reopen in this pr https://github.com/web-infra-dev/rsdoctor/pull/655


Devops pipeline failed with timeout error

Describe the bug
Devops pipeline just started failing today. It was working as expected before. The project consists of some xml and html files.
To Reproduce
Steps to reproduce the behavior:

Commit and push a change to bit bucket
Build pipeline will be triggered
See the logs for the error

Azure Pipelines YAML File
trigger:

master

pool:
vmImage: ubuntu-latest
steps:

checkout: self
submodules: true
task: AzureStaticWebApp@0
inputs:
app_location: '/'
api_location: ''
output_location: ''
env:
azure_static_web_apps_api_token: $(deployment_token)`

Expected behavior
Build should succeed without error
Screenshots

Same as this issue. Lets use the earlier one to track: https://github.com/Azure/static-web-apps/issues/776

@miwebst : still this issue exists, we are getting the same error as before


ebextensions not executing

In my eb.yml I have the following under ebextensions
ebextensions:
  files:
    "/opt/elasticbeanstalk/hooks/appdeploy/pre/001_oracle.sh":
      mode: "000755"
      owner: root
      group: root
      content: |
        #!/usr/bin/env bash
        ...
        ...

When I deploy my application, the script isn't executed and the file /opt/elasticbeanstalk/hooks/appdeploy/pre/001_oracle.sh is not in the directory. Am I doing something wrong?

Hi @KidA001,
There's a bit of a trick to this - the ebextensions section of the yml file functionally creates files that would otherwise be in the ebextensions folder.
So you need to go one level deeper for files to end up on your server. Basically you need to specify an ebextension file that would create that file.
Rather than creating a new ebextensions file you could also package the files command with other commands in an ebextensions file - container_commands, packages, etc
An example:
ebextensions:
  files.config:
    files:
      "/opt/elasticbeanstalk/hooks/appdeploy/pre/001_oracle.sh":
        mode: "000755"
        content: |
            ...


feature resizing gifs

in Pillow, using image.resize() returns a resized image of the first frame only.

iterating and resizing each frame.
saving the resized frames as new gif,  and re-loading it.
there's an issue I can't find why it's happening - seems like the first frame breaks while resizing/saving,   therefore we save the frames from the second frame forward and setting the new frames number.
Probably resolves #14

Thanx for your pull request! I have to rethink the whole image part of the component especialy with the new awtrixid part.

Yeah I get it..
Glad I could help,  pls let me know if I can assist further.
Very cool project!  Thank you for your efforts! :)

In the upcoming release I remove the scaling feature, especially because of the 8x32 animation support.
So, if you find the time, you could provide a new pull request with this new requirements. If I find the time I will try, but without priority


Added missing caption to file object in object model

Thank you @HermanSchoenfeld for raising the PR. I see theses changes are already part of #234. Hence closing this PR. Looking forward for your contribution.


remove unused code, it does not happen

I remove some implements for GetDeviceLocalityAsync, because it does not happen.

Can one of the admins verify this patch?

Transfering this to @poxvoculi, because I think he wrote the code that relies on this check.

We might need this in the future. See https://github.com/tensorflow/tensorflow/pull/11392#issuecomment-315818751

@byronyi I think this PR is essentially just removing the error case
errors::Internal("Failed to find locality for ", device_name);
which cannot be hit, due to the immediately prior call to GetDeviceLocalityNonBlocking.
(Now a default value for DeviceAttributes.locality is returned, but perhaps an earlier version of GetDeviceLocalityNonBlocking could have returned an error if the table entry existed but had no locality value.)
How do you anticipate hitting this case in the future?

Sorry, I shall be fine with the changes here. As a side note, there could be three different cases here:

There's a valid table entry (the happy path)
There's no valid table entry, because the corresponding device attributes can't be found
There's no table entry at all, as the RPC has not returned from the remote

Correct me if I'm wrong, but now it seems the 2nd and 3rd cases could not be differentiated. Like you said, an early implementation could mark the 2nd case with an invalid table entry, and return false from GetDeviceLocalityNonBlocking (and thus we might need what will be removed in this PR). And for the current implementation, would there be any chances for the caller to keep refreshing the table for nonexistent device attributes, i.e. mistaken case 2 as case 3?

@byronyi In an earlier version of protobufs it was possible to distinguish a missing member from a default value.  That's no longer the case, so this line  should either return a default value or a good value set by RefreshDeviceStatus, and we can't tell which one.  In the future, if useful, we could set the default value to some distinguishable invalid value.

Thanks for the explanation! Very much helpful as always :)

Jenkins, test this please.


Add a "Join the Community" button at the top of the Community page

Current Behavior
The project site should be prominently encouraging new community members. A "Join the Community" button will help with this as shown in the mockup below.
Desired Behavior

@leecalcote sir do i need any animation in the button?

@gunjanmimo, yes, you can reuse style from the Subscribe button.

@leecalcote sir I have added the animation


map std.traits.mangleName directly to mangleof

There seems to be no difference in results anymore. The current implementation relies on a given mangling scheme, but his might change soon with https://github.com/dlang/dmd/pull/5855.

but shouldn't we at least undocument or even deprecate this function

Fine with me, but these are already too many options ;-)
Without deprecation it will likely linger forever, so I guess a deprecation (until June 2018?) should be better.

Without deprecation it will likely linger forever, so I guess a deprecation (until June 2018?) should be better.

Fair point. Looks reasonable to me.
CCing our deprecation tzar @jmdavis

Yeah, sounds like deprecation would be the right approach. I'd put
// @@@DEPRECATED_2018-06@@@

right above the comment (so that I can grep for it and move it along to being undocumented when next June rolls around) and something like
$(RED This is deprecated and will be removed in June 2018. Please use
      the `.mangelof` property instead, as there is no longer a difference
      between it and this trait.)

at the top of the ddoc comment. And then of course, the template itself would be marked with something like
deprecated("Please use the .mangleof property instead")

Thanks, added your messages. Unfortunately, the deprecation message does not seem to appear if attached to an enum value or the enclosing template.

Why do we need to deprecate this template? It is useful when used in combination with things like staticMap.

Why do we need to deprecate this template? It is useful when used in combination with things like staticMap.

Hmmm, I didn't consider that. If we keep it, the documentation should point to that use case, though. Do you have a nice example to add?

@ZombineDev @jmdavis Any updates on this? I can't imagine a sensible use case for this. Especially one that doesn't break if https://github.com/dlang/dmd/pull/5855 is merged.
Using mangleof for type reflection is not recommended anymore in favor of traits, so I think deprecation would still be appropriate.

Any updates on this? I can't imagine a sensible use case for this. Especially one that doesn't break if dlang/dmd#5855 is merged.

I am still in favor of going with a deprecation and as we now have two months to next release I would merge the deprecation. Any vetoers? @ZombineDev?

I'm fine with the deprecation. The template is trivial to write anyway.

Well, if someone really is using this in something like staticMap, then the deprecation will be annoying, but it is pretty easy to rewrite now. So, I'd probably favor keeping it and not deprecating it in order to avoid forcing folks to change code as well as to avoid forcing folks to write their own replacement when they need it as a template argument, but if you guys really want to deprecate it, I won't argue.

Ok, I've removed the deprecation. It didn't show up anyway (problems on enums?), which would cause a sudden breakage for someone not stumbling over the warning in the documentation.
Instead I changed the documentation to pretend it might still be useful and added a very simple documentation unittest calling staticMap.

@rainers feel free to auto-merge when ready.


fix padding in dpo trainer

What does this PR do?

The padding token in DPO trainer is wrongly set to 0 when tokenizer uses a different token id for padding and tokenizer is passed. This happens because the conditional statement is checking if padding value is None but if the default is 0, it is never None.

cc @younesbelkada

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

great catch thanks!


Containers namespaces

Here's a patch which (1) fixes a bug in  testContainerOutputInNamespeace so that it checks pods in the right namespaces, and also (2) an update to docker-containers E2E test to use namespaces properly.

@jayunit100 thanks for catching this; i actually have this fixed in a wip but forgot to peel off a separate PR.
LGTM, will merge monday.


Mypy type error on PostgresDsn with litteral string assignment

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.5.1
            pydantic compiled: True
                 install path: /.../venv38/lib/python3.8/site-packages/pydantic
               python version: 3.8.2 (default, Mar 11 2020, 00:29:50)  [Clang 11.0.0 (clang-1<IP_ADDRESS>)]
                     platform: macOS-10.15.4-x86_64-i386-64bit
     optional deps. installed: ['typing-extensions']

from pydantic import BaseSettings, PostgresDsn

class Cfg(BaseSettings):
    pg_dsn: PostgresDsn = "postgresql://user:password@localhost:5432/test"
    pg_min_size: int = 2
    pg_max_size: int = 10

Checking with Mypy gives the following error.
app/config.py:5: error: Incompatible types in assignment (expression has type "str", variable has type "PostgresDsn")

I'm assuming the other Dsn type definitions have the same issue, and AnyUrl would also.
Unfortunately I'm not familiar enough with typing extensions to hunt this down, but if you give me direction I can look into it.

I can confirm this also happens with EmailStr. I tried to disable init_typed (see docs), but errors remain.

init_typed relates to initialising the model, so is not related.
The best solution for you is probably to use:
if TYPE_CHECKING:
    PostgresDsn = str
else:
    from pydantic import PostgresDsn

We could modify networks.py to make this the default, but it would mean pg_dsn.password and access to all other attributes would cause an error in static type analysis.
EmailStr really can be changed in networks.py to
if TYPE_CHECKING:
    EmailStr = str
else:
    class EmailStr(str):
        ...

PR welcome for this.

Long term I guess it might be possible to extend the mypy plugin fix this, but that would require a lot of work and defining a master list of type equivalencies which would be quite a lot of work, see  https://github.com/koxudaxi/pydantic-pycharm-plugin/issues/36 and #1055


Add support for PGP/MIME encrypted messages with inner PGP/MIME signed part

Can you clarify what is meant by this issue? Is this PGP/MIME messages where the signature is inside the encrypted message, or multipart MIME messages where the signed part is inside another multipart?

@Diagoras What we meant was: http://tools.ietf.org/html/rfc3156#section-6.1

I see, so "sign then encrypt" instead of the OpenPGP "sign and encrypt". Thanks for the clarification.

@Diagoras exactly.

Related: #572

There is a bounty on this: https://www.bountysource.com/issues/815255-pgp-mime

Enigmail-1.9 extension for Mozilla Thunderbird has forcefully enabled by default PGP/MIME.
AFAIK the next version (2.0) will drop inline PGP.
This will create serious interoperability problems with K9 + OpenKeyChain since K9 does not yet support PGP/MIME.

@andrixnet This bug is not about general PGP/MIME support, which is being worked on. But thanks for the information about Enigmail, do you have a link that backs up the claim?

I hope I'm posting in the correct location here. I'm desperately trying to find out what the current status of PGP/MIME is. I can't find any information. @dschuermann "This bug is not about general PGP/MIME support, which is being worked on" .... So what is the actual issue for that? Who works on that.
I would like to send PGP/MIME emails with K9. So I'm wondering:

Does that already work? If so, what branch do I have to download?
If it doesn't work: Where can I continue the development? What is that status? How is it supposed to look on the UI?
There is the PGP/MIME milestone, but is also doen't have any open or closed issue that suggest the status of the implementation.

Can anyone help me to find that out?
Additionally there is also at least one PR claiming to fix this issue (#576), PR and issue are closed, but it is apparently not done. So why are they closed? I'm confused.

Hi,
I have subscribed to the Beta which is rolled out  through Google PlayStore and PGP/MIME is working for me. You need a PGP Provider though. I'm using OpenKeychain.
I hope this helps.
Am 7. November 2016 09:34:09 MEZ schrieb Andreas<EMAIL_ADDRESS>
I hope I'm posting in the correct location here. I'm desperately trying
to find out what the current status of PGP/MIME is. I can't find any
information. @dschuermann "This bug is not about general PGP/MIME
support, which is being worked on" .... So what is the actual issue for
that? Who works on that.
I would like to send PGP/MIME emails with K9. So I'm wondering:

Does that already work? If so, what branch do I have to download?
If it doesn't work: Where can I continue the development? What is
that status? How is it supposed to look on the UI?
There is the PGP/MIME milestone, but is also doen't have any open or
closed issue that suggest the status of the implementation.

Can anyone help me to find that out?
Additionally there is also at least one PR claiming to fix this issue
(#576), PR and issue are closed, but it is apparently not done. So why
are they closed? I'm confused.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/k9mail/k-9/issues/576#issuecomment-258774830

@ar- Work on PGP/MIME is done by @Valodim . See our blog post at https://www.openkeychain.org/k-9
AFAIK the milestone does not contain any issues because they have been resolved and the next K-9 Mail stable is on the horizon including better PGP/MIME support. Stay tuned.

It does contain issues - there's 6 open and 17 closed. Regardless, I think we are fairly close to a K-9 release. I know @Valodim wants to make more changes but personally I'd like us to do a release and then subsequently future releases if necessary to improve UX. If we have to do 5.201 or even 5.220 I'd rather than that these huge slow releases which block everything else.

I've actually been finished with my changes and pushing for a release for weeks, months even at this point. It's just that regressions like the attachment one keep coming up. I sure hope we can get to a tighter release cycle after this!


Issue with jQuery UI Dialog and nationalmode:false

Hey jackocnr
Didn't see the issues button :-) Sorry about that - I don't use Github that often.
My issue is with jQuery UI Dialogs (modal) and the intl-tel input. When I have nationalmode set to false, I need to click in the input field twice for it to get focus. With default settings (nationalmode: true), it works fine (1 click focus).
When you say you need a CodePen, what do you mean?
/rulzart

I tried removing e.preventDefault() in this clause:
        if (this.options.autoHideDialCode) {
            // mousedown decides where the cursor goes, so if we're focusing we must preventDefault as we'll be inserting the dial code, and we want the cursor to be at the end no matter where they click
            this.telInput.on("mousedown" + this.ns, function(e) {
                if (!that.telInput.is(":focus") && !that.telInput.val()) {
                    e.preventDefault();
                    // but this also cancels the focus, so we must trigger that manually
                    that.telInput.focus();
                }
            });
        }

And then it works with just 1 click. But dunno if it breaks some other functionality.

I mean can you setup a test case on this website: http://codepen.io/ so that I can see the problem.
If you want you can fork this existing codepen to get started: http://codepen.io/jackocnr/pen/yehvE

Closing due to inactivity.


invites: Allow users to invite without specifying any stream to join.

We now allow users to invite without specifying any stream to join.
In such cases, the user would join the default streams, if any, during
the process of account creation after accepting the invite.
It is also fine if there are no default streams and user isn't subscribed to any stream initially.

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I think if you uncheck all the boxes, the user should be invited with no subscribed streams. You made an explicit choice to not invite the user to default streams, so it doesn't make sense to still add the invited user to default streams at that point.

Chatting with @timabbott just now, we can have a checkbox under "Streams they should join":
[ ] Default streams for this organization
If it's checked, we hide the checkboxes part altogether, and use default streams at the time that the user joins. If it's unchecked, we show the checkboxes part and use the specific set of streams the user has specified.

I think if you uncheck all the boxes, the user should be invited with no subscribed streams. You made an explicit choice to not invite the user to default streams, so it doesn't make sense to still add the invited user to default streams at that point.

This was the behavior previously for multi-use invites where we allowed sending without selecting any streams.
Adding a new checkbox to subscribe to default streams sounds good. Will update the PR.

Updated the PR -

The user is now not subscribed to any stream, including default streams, if no stream was selected while inviting.
Added a couple of commits to fix a typo and add test.
Added checkbox to select default streams. Note that we do not show the option if there are no default streams in the realm.

This might need some changes in design. Should we make "Streams they should join" look like a heading?

This might need some changes in design. Should we make "Streams they should join" look like a heading?

I think it's OK, since it's consistent with the other labels.

If you change the default streams, it looks to me in manual testing like the default streams at the time that the invite was sent are used. My understanding of the plan for this was:

I think we use the default streams as of the time the invite was accepted currently, and it's fine to leave it that way; I think that's what users will generally prefer in the case that the user doesn't super have control over it.

But I don't feel super strongly either way about this detail.

Looks good to me otherwise! I really like that we end up hiding (by default) the not-super-stylish checkboxes extravaganza as a result of this change. :)

Anyway, @timabbott I think you can take a look at this point.

Merged after a tiny edit to the API changelog, thanks @sahil839!

I think it would likely be an improvement to make this new checkbox do ""
In any case, @sahil839 you can now do a PR backporting this to 6.x.

I think it would likely be an improvement to make this new checkbox get the default streams at the time the user accepts the invite, since that better fits user expectations... but that might require some additional fiddling and I don't want to block on that.
In any case, @sahil839 you can now do a PR backporting this to 6.x.

I missed the point about subscribing to the default streams at the time user accepts the invite. For this might need to send a special value to API, probably in a separate argument, like subscribe_to_default_streams_only and add this new field to PreregistrationUser and MultiuseInvite objects as well.
Will open a PR for backporting soon.


Bug: artisan config:cache

When running php artisan config:cache it fails.
Error
Fatal error: Call to undefined method Closure::__set_state() in /Users/anahkiasen/config-closures/bootstrap/cache/config.php on line 22

Fix
Did some research and found https://github.com/laravel/framework/issues/9625 and many othe disscussions, then I found https://github.com/tymondesigns/jwt-auth/issues/203#issuecomment-131386283 wich actually fixes it, will have a PR soon with the fix included.

https://github.com/phanan/koel/pull/409


Object Detection Secnario Page

Azure - guided
Local - non-guided

object detection is on the scenario page


Clearify UseNode@1 vs. NodeTool@0 usage

It looks like UseNode@1 is a newer version of NodeTool@0?
If this is the case then this page should be updated to mark this task as deprecated and link to UseNode@1.
Also, the pages https://learn.microsoft.com/en-us/azure/devops/pipelines/ecosystems/javascript and https://learn.microsoft.com/en-us/azure/devops/pipelines/process/tasks should then be updated to use UseNode@1.
If this is not the case then both pages should be updated to clearify the difference.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 07ed1dbe-4bd5-52a4-9373-32e1fbca211d
Version Independent ID: 07ed1dbe-4bd5-52a4-9373-32e1fbca211d
Content: NodeTool@0 - Node.js tool installer v0 task
Content Source: task-reference/node-tool-v0.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-tasks
GitHub Login: @steved0x
Microsoft Alias: sdanie

Related to #238.

Reactivating this one to track finding the difference between those two tasks and adding an update (or deprecation notice) to the article to provide that info.

@cremor I just got some information - they are the same task, the newer one has a simplified set of task inputs. I believe the name change was due to changing the pattern of tool installers with a "Use" prefix.
I will add a link to the older task to let folks know there is a newer version and I will group them in the TOC and index so they are together. The older version isn't marked as deprecated, but if it does get deprecated, the docs will pick that change up.

This change will be live today. Thank you for pointing it out and for your other feedback in 238.


Automatic behavior testing

I posted this in the forums and I'm making a request in the bug tracker so maybe the devs can keep this under their radar.

As I software developer, I tend to driven my development of software thought tests to assure the correctness of behavior with the code I'm writing and because this method of software development helps me find bugs when I introduce them by accident during the development process.
So, I was wondering why Godot have no automatic testing facilities to allow game developers assure the game behaves as they want. I see this feature for Godot not only useful during development, but also afterwards, specially for those authors writing books or making on-line classes on Godot: for them automatically checking what APIs are outdated or which lines of code don't work as they supposed to in new versions of Godot, making it easy to updated their material where it is required. Nowadays is very easy to find outdated code for different programming languages or frameworks, and Godot isn't going to be an exception.

In my my mind, this could consists of:

a way to simulate player input (touch in screen with finger or mouse pointer, button or key pressed, action triggered)

A way to move a node using simulated inputs until the node reach the target point, maybe?

a way to gather nodes properties after the input is sent and allow value comparison and yell error when the developer see it fit.
a way to set fixtures and tear down them before and after each test.
a way to take screenshots between steps of the test.

does it makes sense to record a video during each test? I mean, in the gamedev context.

The tests should be triggered from the command line (say: godot --test-node nodescene.tscn --test-script mytestscript.gd or godot --run-tests in the current game project directory and let Godot search a folder called "testing" with GDScripts defining the tests).

To be fair, Godot probably supports all of this (as long as globals and autoloads aren't used too much), you just have to bundle it in a nice GDScript framework :smile: :

Simulating player input is already possible by feeding custom InputEvent-s docs

Since inputs would count as actions just fine (might need slight tweaking in case they don't), nodes would move exactly as in the real game... unless you start pressing real inputs (workaroundable, as one can make a fake SceneTree, and pass only custom inputs)

Node properties of all kinds can be gathered via functions (get_pos...) or as properties (get("transform/pos")...). Comparing those properties should we relatively easy

Since properties might change between observations (or something else might happen, better not to risk it), one might pause the tree before running through the nodes.

Setting up fixtures is probably something scenes should do. To tear a fixture down, kill the scene (or even the scene tree), then instance another one (Note: might need killing/resetting global singleton nodes).

Again, a fake SceneTree is going to be easier to work with
Also, worth to note, anything that makes use of OS time, or ticks since start is not mockable, so code wisely :wink:

Making screenshots is very easy in Godot, and saving them should be simple as well docs

Videos are going to be harder to do, though making a 30fps one doesn't seem impossible (this might deserve another issue if it is really important).
Instead of videos, you can make a complete copy of the tree saved as a scene, with scripts removed, and add an AnimationPlayer with a Animation resource generated from all (or at least changed) properties of all nodes in the scene. Added and removed nodes might be simulated with hiding and showing, or with func call tracks.

Triggering a script from the command line is already possible with the -s flag docs. Probably a custom scene that does everything would be more useful though, since it would be able to have access to Singleton autoloads.

As an alternative solution, you can check OS.get_cmdline_args() for --run-tests in the main scene, and then change into the testing scene.

Small note: a single scene doing all tests won't be efficient because a test could crash the engine or propagate errors for next tests, which would force to fix issues one by one.

The hardest part in all of this IMO is making scenes and scripts completely isolated to be able to unit test, especially the singletons. Inherited and instanced scenes can get in the way, though if you rely on placeholder scenes and do a lot of signal passing you might be able to manage it. You will likely need to abstract away all the unmockable parts, like OS and FileSystem functions.
If you build a script which extends MainLoop, it's relatively easy to follow @bojidar-bg's advice to create a SceneTree manually and control the passing of frames by calling _iteration(delta) and _idle(delta). This also allows you to pass fake input events.

@vnen ok, let's say I do as @bojidar-bg suggests: how would I trigger the tests?

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about it here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

Currently Godot 3.0.2 has only this reference on anything related to testing:
--test <test>: Run a unit test ('string', 'containers', 'math', 'render', 'multimesh', 'gui', 'io', 'shaderlang', 'physics', 'oa_hash_map').

But there is the Gut project that seems to cover the requirements of this feature request.


Fix DetachSocketFilter

This fixes the error returned while trying to detach
" detaching BPF socket filter: invalid argument"

@iaguis could you take a look? I wonder why it worked for you?

@schu @iaguis did you have a chance to have a look ?