Replaced the bulk of the toolbox directory with Python fire CLI

Maintaining and creating new toolbox commands has become rather tedious
because of the awkward syntax of bash. Especially when trying to add
multiple optional flags to a single command. This PR replaces most
of the toolbox shell scripts with simpler Python files all launched
via the ./run.py script at the root of the repository.
Each command (sro, nfd, gpu_operator, cluster, etc) is specified
as a Python class in its own file under the toolbox directory. Each subcommand
is specified as a static method of that class. The parameters for the subcommands
are specified as regular Python method parameters. All those classes must be listed
inside ./run.py. Fire then automatically discovers all the methods of
those classes and generates a CLI.
The benefit of using Fire is that we get automatic arg parsing with free --help
which shows the available commands, available subcommands for each command, the
parameters, which parameters are required (positional) and which are optional (flags),
it shows the docstring of the subcommand method as the description for the subcommand.
I've also added plumbing to run ansible playbooks with ansible
parameters passed as a simple Python dictionary, so the code to create
a subcommand is almost as minimal as possible.

/test ?

/test nfd-operator-e2e-master

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

/test nfd-operator-e2e-master
/test nto-e2e-master

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

thanks for sharing Omer, I'm looking forward to diving into this PR :)
On Tue, Jul 13, 2021 at 9:54 PM Omer Tuchfeld @.***>
wrote:

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/openshift-psap/ci-artifacts/pull/214#issuecomment-879358338,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZVQIX7FHCXKSE7WY7OFVDTXSKVJANCNFSM5AFXZBJA
.

Weird flake, doesn't seem related to PR.
Trying again
/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

@ArangoGutierrez @jmencak @dagrayvid, any feedback on this PR?
personally I'm all 👍🏻 for approving this change, the bash toolbox entrypoint scripts were good enough for a starting point, but with the addition of new (&optional) parameters it became hard to maintain and extend. Python will make it more rigorous and well defined
@omertuc I'll try to deep dive into the code early this week !

@ArangoGutierrez @jmencak @dagrayvid, any feedback on this PR?
personally I'm all 👍🏻 for approving this change, the bash toolbox entrypoint scripts were good enough for a starting point, but with the addition of new (&optional) parameters it became hard to maintain and extend. Python will make it more rigorous and well defined
@omertuc I'll try to deep dive into the code early this week !

I am not an expert in Python, so all I can say is this will make it harder for me to review and contribute to this repo.
that's my 2 cents

@ArangoGutierrez @jmencak @dagrayvid, any feedback on this PR?
personally I'm all 👍🏻 for approving this change, the bash toolbox entrypoint scripts were good enough for a starting point, but with the addition of new (&optional) parameters it became hard to maintain and extend. Python will make it more rigorous and well defined
@omertuc I'll try to deep dive into the code early this week !

I am not an expert in Python, so all I can say is this will make it harder for me to review and contribute to this repo.
that's my 2 cents

Note that the Python you have to interact with on a daily basis is extremely minimal / trivial, it's basically glue to call the ansible playbooks:
e.g. take a look in:
https://github.com/openshift-psap/ci-artifacts/blob/0f84c8ed0c4c47f9569e7061680b0afb76290ac1/toolbox/nfd_operator.py
https://github.com/openshift-psap/ci-artifacts/blob/0f84c8ed0c4c47f9569e7061680b0afb76290ac1/toolbox/nfd.py
Even the gpu operator toolbox file which is the biggest is very straight forward / is mostly comments rather than code:
https://github.com/openshift-psap/ci-artifacts/blob/0f84c8ed0c4c47f9569e7061680b0afb76290ac1/toolbox/gpu_operator.py
I would argue that bash code like this:

Is much harder to deal with, even for someone who never tried Python and is relatively OK with bash.
We're not actually writing "Python code", we're just using the Python's Fire CLI library to automatically convert simple Python declarations into CLI so we can easily launch ansible playbooks

one remark, for discussion: what about moving build/root/usr/local/bin/ci_entrypoint_*.sh to eg toolbox/ci_scripts/gpu-operator.sh, etc and adding a simple fire wrapper to call them?
./run.py ci_scripts gpu-operator test_master_branch

run could also be integrated this way, so that we can move everything out of build/root and have a unified entrypoint (maybe with run being defined in the CI image as run.py?)
let me know what you think about it, can be a follow-up PR as well

Sounds good to me, definitely follow-up PR material though :)

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

/retest
/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

/test nfd-operator-e2e-master

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

/test gpu-operator-e2e
/test nfd-operator-e2e-master
/test sro-e2e-master
/test nto-e2e-master

hey @omertuc , seems pretty good to me!
maybe we can merge it before you fix the two docs typo I mentioned above, as all the tests are green?
\lgtm
\hold # I let you merge if you're good with everything you had in mind for this PR

hey @omertuc , seems pretty good to me!
maybe we can merge it before you fix the two docs typo I mentioned above, as all the tests are green?
\lgtm
\hold # I let you merge if you're good with everything you had in mind for this PR

s@\@/@g

/lgtm
/hold
-,-
On Tue, Jul 27, 2021 at 9:50 AM Omer Tuchfeld @.***>
wrote:

hey @omertuc https://github.com/omertuc , seems pretty good to me!
maybe we can merge it before you fix the two docs typo I mentioned above,
as all the tests are green?
\lgtm
\hold # I let you merge if you're good with everything you had in mind for
this PR
s@@@.***
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift-psap/ci-artifacts/pull/214#issuecomment-887292389,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZVQIW3L4E5GFKWGWO7OZLTZZQK7ANCNFSM5AFXZBJA
.

/unhold

/lgtm /hold -,-
…
On Tue, Jul 27, 2021 at 9:50 AM Omer Tuchfeld @.> wrote: hey @omertuc <@omertuc> , seems pretty good to me! maybe we can merge it before you fix the two docs typo I mentioned above, as all the tests are green? \lgtm \hold # I let you merge if you're good with everything you had in mind for this PR s@@@. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#214 (comment)>, or unsubscribe <github.com/notifications/unsubscribe-auth/ABZVQIW3L4E5GFKWGWO7OZLTZZQK7ANCNFSM5AFXZBJA> .

/approve?

/approve
On Tue, Jul 27, 2021 at 10:08 AM Omer Tuchfeld @.***>
wrote:

/lgtm /hold -,-
… <#m_6493350819601345117_>
On Tue, Jul 27, 2021 at 9:50 AM Omer Tuchfeld @.> wrote: hey @omertuc
https://github.com/omertuc @.** https://github.com/omertuc> ,
seems pretty good to me! maybe we can merge it before you fix the two docs
typo I mentioned above, as all the tests are green? \lgtm \hold # I let you
merge if you're good with everything you had in mind for this PR s@@@.*
— You are receiving this because you were mentioned. Reply to this email
directly, view it on GitHub <#214 (comment)
https://github.com/openshift-psap/ci-artifacts/pull/214#issuecomment-887292389>,
or unsubscribe <
github.com/notifications/unsubscribe-auth/ABZVQIW3L4E5GFKWGWO7OZLTZZQK7ANCNFSM5AFXZBJA>
.
/approve?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/openshift-psap/ci-artifacts/pull/214#issuecomment-887304619,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZVQIUKPORJAGSAME7GJP3TZZSRFANCNFSM5AFXZBJA
.

hey @omertuc , seems pretty good to me!
maybe we can merge it before you fix the two docs typo I mentioned above, as all the tests are green?
\lgtm
\hold # I let you merge if you're good with everything you had in mind for this PR

https://github.com/openshift-psap/ci-artifacts/pull/223


CD Report No of Suspected Cases

The number of new suspected cases for each disease in the CD report is always showing as 0 even if cases were reported for that week.
If you could please take a look...

This happened because we added all the weeks to the x-axis. It was looking for the last week, will sort it out.


NCCL Error on WSL2

When I am running both train and test of the model on single GPU (./tools/fp16/dist_train.sh ./projects/configs/bevformer_fp16/bevformer_tiny_fp16.py 1), I am getting this error:
RuntimeError: NCCL error in: ../torch/lib/c10d/ProcessGroupNCCL.cpp:911, unhandled system error, NCCL version 2.7.8
ncclSystemError: System call (socket, malloc, munmap, etc) failed.
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 439853) of binary

Do you know how to fix it?
PS: I am running it on WSL2

close dist train.

and use bn , not sycbn


heroku/nodejs-npm-install is erroring instead of gracefully failing detection, causing log spam

The heroku/nodejs-npm-install buildpack is currently erroring if a package.json is not found, rather than gracefully "failing" detect.
For example:
======== Output<EMAIL_ADDRESS>========
- Debug info
  - No such file or directory (os error 2)

! Error reading `package.json`.
!
! This buildpack requires `package.json` to complete the build but the file can’t be read.
!
! Use the debug information above to troubleshoot and retry your build.
!
! If the issue persists and you think you found a bug in the buildpack then reproduce the issue locally with a minimal example and open an issue in the buildpack's GitHub repository with the details.

err<EMAIL_ADDRESS>(1)

From:
https://github.com/heroku/cnb-builder-images/actions/runs/6870978876/job/18686993769#step:6:10

cc @colincasey @joshwlewis


Upgrade pulumi-terraform-bridge to v3.85.0

This PR was generated via $ upgrade-provider pulumiverse/pulumi-matchbox --kind=bridge --target-bridge-version=latest.

Upgrading pulumi-terraform-bridge from v3.83.0 to v3.85.0.

Superseded by #62


handling replicates

My colleague and I both separately installed macs2 <IP_ADDRESS>40616 (from macs2 --version) however our 2 installations seem to handle replicates for treatment/ChIP differently. According to macs2 callpeak --help one installation reads and combines files passed with '-t A B C' while the other treats the files as replicates using Liptak's method with weights.I have been trying to figure out why this is different if the versions are the same. In one case the version was installed from PyPI and in the other case from cloning the github repository.
Is it advisable to use the version on github or the official release? I would like to be able to use information from replicates and the release on PyPI is not doing that at the moment. Also can you direct me to any documentation about how replicates are weighted with Liptak's method?

Hmm... Sorry, I believe I forgot to remove this description from macs2 command line! While files passed by '-t A B C', all three files will be simply pooled. There is no Liptak's method involved. There is another method in the current github version 'macs2 cmbreps' which can combine replicates using Fisher's method to combine p-values.

Fixed in f614cafbc9c58ea520284b3fbf0e9f9ad3930d26
Sorry for the confusion!


[Proposal] wxPython wrapper for popup windows and panes

Glade code is pretty unreadable, yet we attempt to maintain it. I propose we create a wrapper which allows us to define pop-up window layouts simply and effectively as a simple hierarchy of calls, one call per window element, providing all the information needed to set up the window and calculate e.g. min, max and default sizes (and make it scale gracefully and with poise).
The following conceptual example is based on the settings window:

Ideas are not fully researched or formed, and are intended to be conceptual only.

Window is defined by a hierarchy of calls, one call per graphical wx element:

wxmk.panel([
    wxmk.sizerhorizontal([
        wxmk.sizervertical([
            wxmk.boxsizer([
                wxmk.radio(["Units",["mm", "cm", "inch", "steps"], other stuff),
                ], other stuff),
            wxmk.boxsizer("Language", [
                wxmk.dropdown(["English",...]], other stuff),
            ], other stuff),
        ], other stuff),
    ], other stuff),
], other stuff)

where other stuff defines e.g. min and max sizes, bindings, flags etc.

wxmk would do all the multiple native wx calls under the cover, including making the panels look both nice and consistent with margins etc. and applying any defaults and hidden interim sizers necessary to make it look nice and scale gracefully. It would also calculate minimum sizes etc. up and down the hierarchy.

Of course, wigets for individual controls or sizers can be assigned to variables if needed, and because these classes will be derived from the wx classes, the full power of wx is still available. Indeed, you can mix and match wx native and wxmk in the same app with no problems.

Because the definition is so simple, it should be easy to maintain and change. I believe that sorting the code for each window should allow for existing code to be coerced into this form on a 1-to-1 basis without too much difficulty.

For the checkbox list on the right of the settings window, we might even create a special wxmk control that does the whole thing under the covers with one call. Similarly we can subclass text fields to limit to numerics and extend functionality to have e.g. default actions for e.g. enter when in the field.

If this approach is agreed, I would propose to update settings.py first, creating the wxmk classes therein, and once that is working and bedded in, we can then migrate the wxmk code to wxmeerk40t.py and update all other windows and panes one by one.

I don't see this being that much easier. There is clearly some truth to the maintainability of the Glade code. There's not a very good builder for that stuff in wxPython. It's somewhat reasonable but I don't see this being easier to maintain. Since the main issue is still you want a dialog built in a gui-builder like Glade. And just generalizing that stuff doesn't seem to make that easier.
It's simply the case that the dialogs are not built in anything that is somewhat modular, and so copying out the relevant parts to make the window is still likely the best method forward. The power of building the gui in glade is that you get a wysiwyg frame.
If you have a glade pane or something I could certainly go through and integrate it into a meerk40t pane as needed. Or document the needed changes. But, hand building them with hand-building commands is nearly never going to be superior.

Really?

When you know what you want to display, it is easy to code it IMO. Tweaking it is as simple as moving lines elsewhere.
One call per GUI item is way better than 3-5 calls as at present.
Because Glade designs are done by eye, they are never going to look consistent. The extra functionality behind the scenes in this proposal will make the GUI much more consistent and less ... um ... glitchy looking. This is important for what you might call brand-image. If you want to "compete" with Lightburn, this is important.

Well if you want, you could try a large bit of gui. There's a need for a grbl controller that has values to set all the $ commands.

The idea being to allow the user to configure their GRBL devices and send that data to the backend through the character counting protocol. While it's not currently there, there is a notable need for a GRBL controller gui and a Ruida controller gui, as well as preferences for them. Not sure where the $ settings belong. But, the point remains that eventually supporting these would require having useful guis that can modify those settings.
The GRBL settings would look like a bit like the LaserGRBL settings and the Ruida settings would look a lot like RDWorks settings. Both of which would need rather extensive windows.

Sorry - but I think I need to start with one piece of existing code to write the wxPython wrappers.
Also, I have tried creating a GRBL device, but cannot open LaserGRBL settings.
If I code it for Settings and you like the concept, I can then code all other Windows. We should also be able to have common code for Panes and Windows - say files in /meerk40/gui/widgets which we import into Panes or Windows as needed.
Once I have coded existing widgets, we can then extend it to new settings.

I think there's actually pretty considerable overlap with this idea and the idea behind choices.
https://github.com/meerk40t/meerk40t/wiki/Tech:-Choices
The rightmost value there in Settings (which actually will be renamed to Preferences as confusing as that is, but it's a mac standard thing) is created by a dynamic list which isn't registered in the kernel yet, but easily could be as part of a choices set of values. Just as those choices are dynamically, we can dynamically make other choices with properties panes.
This provides, not a standard wrapper for designing the window, but a standard wrapper for defining what options we have and if we provide those options we can create dynamic interfaces that actually work rather robustly. So if we choices a value one place it will get altered in other places.
There's a couple needed updates:

The action type for choices needs to get added to PropertiesPanel
The dynamic Preferences here in Settings need to be converted to a choices set of value, and likely placed within wxmeerk40t.py for now (some of these are rarely used settings for things like the planner and just got dumped here).
The meerk40t/core/elements tree_operations_for_node currently returns a function with a bunch of attributes that are checked. This function should actually generate choices for a node instead. Then we could display this information in a panel, if we wanted to for some unknown reason.

There's likely a few other things that could help define how we should render this kind of alterable properties.

Now this wouldn't create necessarily create our windows as you propose but it does fit the central idea behind this Issue.  It might be possible to render other controls within our window so we get options for a ComboBox or a kernel.Channel (large text box that watches that given channel). And these might be able to render something relatively well. While it wouldn't have the fine-grain control it would slap together a display and let you click the things you need to change.

Choices is a complementary approach which I fully support. It effective decouples GUI from underlying functionality i.e. it places the definition of e.g. optimization options in the same MK plugin that provides the optimization. I might question whether it would be better as a dict of dicts rather than a list of dicts, but the underlying principle is IMO a good one.
The suggestion in this issue complements the above by abstracting wx window / panel / etc definitions to their simplest form and adding the glue functionality in common methods. This would simplify the creation / modification of MK gui windows / panes etc. and ensure that all aspects of the UI act consistently. It would also abstract away any O/S specific changes, and allow us to refine the UI further so as to e.g. prevent user typing alphabetic characters into numeric fields etc.
If this works and works well, it might be spun out into a separate wx toolkit, and possibly we could then get Glade to generate code for this directly in order to have a GUI designer.

If we do this we can probably also integrate support for unit-testing using this: https://wxpython.org/Phoenix/docs/html/wx.UIActionSimulator.html

I think choices has advanced to being pretty solid for this.
I would have no trouble creating either example in this Issue with a choices routine. The original note with the checkbox actually is choices now.


fix: ensure that DoStatus is called for u2f devices

Ran into #121 while trying to get setup with Duo + U2F. After comparing the flow in the code to the browser it looks like aws-okta isn't calling the Duo status endpoint properly. That is required to exchange the txid we get for something Okta will take.
I've tested this code with both U2F and Tokens and both now work.

I can confirm that this fixes my issue too.

Confirmed fix for me as well, though I'll have to open another ticket about the fact that it's not respecting that u2f is my default

Thanks so much @austinylin! Hoping to get a chance to test this early next week.

Well, I spent all morning trying to prove that this fix worked and it didn't. Then I realized I was on the wrong branch. Go me.

@nickatsegment What does release timeline typically look like?

@smiller171 It's pretty arbitrary, but I'm going to do one right now.

Nice!

v0.20.0 is hot off the presses.

@nickatsegment Do you know how long it takes for a release to make its way into Homebrew? I don't know anything about how that works

Generally we haven't touched it; we have our own internal homebrew for it.  Looks like last time our friend @logikal contributed the PR: https://github.com/Homebrew/homebrew-core/pull/36600

If no one beats me to it, I can do that tomorrow!

I opened the PR: https://github.com/Homebrew/homebrew-core/pull/38713

Thank you for taking care of that @vivianho! My apologies for not following through.


chore(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-k8s-27-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3255

Questions ?
Please refer to the Backport tool documentation


EscPosPrinter instantiate

When to use on iPad 17.2
        await EscPosPrinter.instantiate({
          target: ....,
          seriesName: getPrinterSeriesByName(....),
        });

Got the error
[Error: 2]

    "react": "^18.2.0",
    "react-native": "0.72.7",
    "react-native-esc-pos-printer": "^3.0.3",

Also with
 "react-native-esc-pos-printer": "^3.1.0",


Submit both forward and reverse reads fastq files to QIITA

We tried to submit already demultiplexed RAW files to QIITA associated with one project. The RAW files have already been demultiplexed. Each sample has two RAW files. I know the preparation metadata file, it can include run_prefix with correct sample run_prefix. But does it support for both forward and reverse reads? Does QIITA have workaround to handle that submission? Thanks for help.

Hi @mentorwan. You should be able to upload per sample FASTQs both forward and reverse files - if the run prefix contains the common prefix for both files (fwd/rev) it will populate the list automatically.
I will close the issue - if you need more help with this issue, feel free to drop an email to<EMAIL_ADDRESS>


Use RetDec's JSON output for ASM <-> C mapping

The new RetDec JSON C output contains info on token assembly addresses.
Use this info for ASM <-> C code association - what HexRays does with Tab.

Fixed in 3503eb67760f7ab3ca42ff89ea484e9395604d88. Release v1.0 will come shortly.


Problem with network (overlay)

After restart swarm works fine, but after a while, when some number or containers are created and running I am experiencing problem with network connection between containers (timeouts). I have noticed that it correlates with log entries:
Apr 19 11:36:23 node3 docker[3069]: time="2016-04-19T11:36:23.397441341+02:00" level=warning msg="2016/04/19 11:36:23 [WARN] serf: Query queue depth: 954\n"
Apr 19 11:36:23 node3 docker[3069]: time="2016-04-19T11:36:23.397524902+02:00" level=warning msg="2016/04/19 11:36:23 [WARN] serf: Event queue depth: 899\n"
Apr 19 11:36:24 node3 docker[3069]: time="2016-04-19T11:36:24.397677127+02:00" level=warning msg="2016/04/19 11:36:24 [WARN] serf: Event queue depth: 899\n"
Apr 19 11:36:24 node3 docker[3069]: time="2016-04-19T11:36:24.397806735+02:00" level=warning msg="2016/04/19 11:36:24 [WARN] serf: Query queue depth: 954\n"
Restart fixes the problem for a short time. I am using overlay networks.
Version:      1.10.3
API version:  1.22
Go version:   go1.5.3
Git commit:   20f81dd
Built:        Thu Mar 10 15:59:07 2016
OS/Arch:      linux/amd64

cc @mavenugo.

I see this with 1.11.0 and swarm-1.2.1-rc1.


Downstream RKE2 cluster issues

Environment:
Rancher v2.6.4 via Helm on RKE2 v1.21.10-rke2r2
Downstream environment:
Bare metal running ubuntu bionic/focal
Problem statement:
We have been deploying rancher provisioned clusters via RKE previously, but are in the process of testing RKE2 to allow for disabling kube-proxy to unblock Calico eBPF and DSR. The below issues have been encountered so far.
Issues:

RKE2 downstream clusters are missing rkeConfig in the api/v3/clusters/<cluster_id> endpoint appliedSpec while it is present for RKE clusters as the rancherKubernetesEngineConfig key. This key is very useful for idempotent comparisons before applying cluster configs via automation.

RKE2 downstream clusters are failing to upload s3 etcd backups when cloudCredentialName is provided with nodes showing --etcd-s3-access-key in their rke2.io/node-args, but no --etcd-s3-secret-key argument.

RKE2 downstream clusters default/kubernetes service points to first address in services prefix even when disable-kube-proxy: true is passed via config, causing kube-apiserver to be unreachable without adding KUBERNETES_SERVICE_HOST/KUBERNETES_SERVICE_PORT to consuming service namespaces.

Testing:

RKE2 clusters show their full config via the UI Cluster Management screen via Edit  YAML, but not via API.
Nodes create 2x snapshot entries per backup with 1 showing 0b. Verified adding "etcd-s3-secret-key" to /etc/rancher/rke2/config.yaml.d/50-rancher.yaml on node directly and restarting rke2-service resolves issue.
Verified services with kubernetes-services-endpoint configmap including KUBERNETES_SERVICE_HOST/KUBERNETES_SERVICE_PORT in the consuming service namespace allows them to reach kube-apiserver.

Expected:

API responses will include cluster config values for all Rancher provisioned clusters
Rancher provisioned RKE2 clusters will include all values required for s3 etcd backups.
Provide mechanism for supplying a host:port similar to https://docs.cilium.io/en/stable/gettingstarted/kubeproxy-free/

Thanks a lot for your help getting these resolved.

confirmed issue is resolved in 2.6.5


'trash list' is extremely slow

sudo timeout -s INT 60 flamegraph --freq 3000 -- trash list:

If I let the command complete (takes more than 3 minutes to list 10 trash item indicies) without interruptions:

Same here, both listing and restoring from trash takes a very very long time, compared to trashing which is instant.


Adding cifar-10 model for testing on image data

Adding a CNN model for testing on image data.
CIFAR-10 dataset was used for training the model

Please update the version in the nuspec, here: https://github.com/dotnet/machinelearning-testdata/blob/master/Microsft.ML.TensorFlow.TestModels.nuspec#L5

Done. Thanks for pointing this out.

In reply to: 416761421 [](ancestors = 416761421)


Add support for Lambda Response Streaming

AWS just announced Lambda Response Streaming which allows for a Lambda to provide a streamed multipart response instead of a one-shot response, as well as increasing response payload size limits.
This should allow for implementation of @defer and @stream with a lambda which is currently not possible.

I was excited to see this announcement too! But sadly, from the AWS blog post:

Neither API Gateway nor Lambda’s target integration with Application Load Balancer support chunked transfer encoding. It therefore does not support faster TTFB for streamed responses. You can, however, use response streaming with API Gateway to return larger payload responses, up to API Gateway’s 10 MB limit. To implement this, you must configure an HTTP_PROXY integration between your API Gateway and a Lambda function URL, instead of using the LAMBDA_PROXY integration.

Given that both the API Gateway and ALB implementation both buffer the response before returning it to the client; effectively making the benefits of @defer useless. The only implementations that support streaming are the Function URL and a direct invocation.
It is ill-advised to have a function URL directly called from the client as per AWS. There is no DDOS protection, no WAF, no rate limiting, etc., giving any malicious actor a URL to siphon money out of your pocket 😉.
I think this issue should be re-visited and implemented when either the buffering at API gateway is removed, or Function URLs can be locked down better (IAM secured access from CloudFront, rate limiting, etc.). CloudFront proxying to a Function URL is technically possible right now, but still requires the url to be "OPEN" as opposed to "IAM" authenticated. There is a feature request for CloudFront IAM signing, so we can add that to the list of things to wait for!


With auto_brace_complete enabled, selected text now gets wrapped by braces

Fixes #56581
Now it behaves the same as in 3.x

Any chance you could add some unit tests for this?

Added

Shouldn't it only work for one char braces? Because the CodeEdit::_handle_unicode_input_internal(const uint32_t p_unicode) accepts a single char so I think it's impossible to wrap selection with multi char braces. For example if you would try to wrap it with the /* and */ pair, upon entering the / character, it would replace the selection. It also works that way in 3.x

Yeah I don't expect it to pass, though nice to see the negative case for it.
Though in 4.0 outside a selection it should complete when you type the * in /*.

Yeah I don't expect it to pass, though nice to see the negative case for it.

So should I just add something like this
/* If inserted character is not a auto brace completion open key, replace selected text with the inserted character */
		code_edit->clear();
		code_edit->insert_text_at_caret("abc");
		code_edit->select_all();
		SEND_GUI_KEY_EVENT(code_edit, Key::KEY_1);
		CHECK(code_edit->get_text() == "1");

but with e.g the / character instead of 1?

Though in 4.0 outside a selection it should complete when you type the * in /*.

Yeah it already works that way

Going to guess it should be something like this:
/* If inserted character is multichar brace completion open key, it does not wrap */
code_edit->clear();
code_edit->insert_text_at_caret("\'\'abc");
code_edit->select(0, 2, 0, 5);
SEND_GUI_KEY_EVENT(code_edit, `\'`);
CHECK(code_edit->get_text() == "\'\'\'");

Ok so it turns out it can actually easily work also with multichar braces. So if in line ''abc , abc is selected and ' pressed should the behaviour be: '''abc''' or ''' ?

There doesn't seem to be much precedents for this in other editors, as it could also autocomplete to ''''''.
But for me personally, I would expect '''

Updated

Updated


[BUG]  Add Button for move contributors card

Description
@akshitagupta15june
Describe the bug:
A clear and concise description of what the bug is.
we can add left and right button in this contributions list
Expected behavior:
A clear and concise description of what you expected to happen.

we can add left and right button too

Actual behavior:
A clear and concise description of what actually happened.

currently they move autometically

Reproduction Steps
Steps to reproduce the behavior:

Go to 'home page'

Expected result:
A clear and concise description of what you expected to happen at each step.
Actual result:
A clear and concise description of what actually happened at each step.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context:
Add any other context about the problem here.

not currently needed


Refresh Auth tokens when expired

A few weeks after adding my gmail mailboxes, now the app fails to update the events for new emails. The response to an update is always 500 with "credentials not found in database for this account". I suspect this is because the Gmail refresh tokens expire after two weeks for unverified projects. It would be nice to have something like asking users to regrant access to their gmail mailboxes.

Working on it.

PR #17 fixes this issue.


Allow custom exit code in actions

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
I want to provide binds to execute various actions and exit fzf. This can be done with ctrl-y:execute-silent(echo -n {} | xclip -selection c)+abort, for example, to copy the selection. However, this exits with exit code 130 to the shell.
I would like these to not be treated as errors, so it would be nice to allow something like abort(int exit code) or a different action dedicated to 0 exit code (exit, quit, etc)

A more traditional approach would be to use --expect option and have your script decide what to do with the output.

A more traditional approach would be to use --expect option and have your script decide what to do with the output.

While I agree that would work for some cases, my idea was to have an action to open a file that would work everywhere I use fzf, by putting it in my default options. So --expect would work if I have a dedicated script and handle the output, but not on all calls to fzf.
This works pretty well today with the exception of the exit code - which is more of a minor annoyance for my exact use case

While I agree that would work for some cases, my idea was to have an action to open a file that would work everywhere I use fzf, by putting it in my default options. So --expect would work if I have a dedicated script and handle the output, but not on all calls to fzf.
This works pretty well today with the exception of the exit code - which is more of a minor annoyance for my exact use case

That's a good point. Your execute binding isn't doing anything specific to a certain type of input, so having it in the default options makes sense.

That's a good point. Your execute binding isn't doing anything specific to a certain type of input, so having it in the default options makes sense.

Hmm, on second thought, I don't think we need this.
Normally, fzf would print the selected entry and the script invoking it will proceed with the output. But when you do execute-silent(echo -n {} | xclip -selection c)+abort, fzf terminates without printing the current match. So it makes more sense that fzf exits with a non-zero code so that the caller knows that it shouldn't proceed. Not printing anything and exiting with 0 violates the protocol.

a minor annoyance

Can you explain why that bothers you? And have you considered using accept instead of abort?

Hmm, on second thought, I don't think we need this.
Normally, fzf would print the selected entry and the script invoking it will proceed with the output. But when you do execute-silent(echo -n {} | xclip -selection c)+abort, fzf terminates without printing the current match. So it makes more sense that fzf exits with a non-zero code so that the caller knows that it shouldn't proceed. Not printing anything and exiting with 0 violates the protocol.

a minor annoyance

Can you explain why that bothers you? And have you considered using accept instead of abort?

This is probably a different use case, but the issue seemed apropos.
It'd be nice to have custom exit codes (with 1,2 and 130 reserved for fzf) so you can process the returning string in different ways.
For example wanting to configure a command runner to have enter (exit code 0) run the selected command, but have a bind to have tab exit with a different code (say 40) and the script processing the output can use that string differently.
The command could be something like exit(error_code) and returning selection as an accept.

I think I need this too but maybe it can be solved in a different way?
I have a script that opens a list of git branches in one fzf window, and if you press the right arrow, it opens up a commit view for that branch in a sub fzf process using execute. When that sub fzf window exits, normally it would return control to the opening fzf process. I want to have additional controls in the sub fzf process, like binding ctrl-c to copy the commit sha. But it will always return control to the opening fzf process.
If I had custom exit codes, I could break out of both fzf processes and catch the custom code from the python script that controls the whole thing.

Closing as this is currently possible using become action.


TestRun.finished_on, when date change to None not persisting.

The workflow in Polarion, when updating the status of a TestRun to notrun or inprogress, is to change the finished_on field to None.
Changing the date to None is not persisting in pylero. Tried status change with pylero-cmd as well and same issue. Unclear at this time if pylero-cmd also tries to update finished_on or neglects the date change. Below is an example using pylero.
>>> tr = TestRun("example", project_id="my_project")
>>> print (tr.status)
notrun
>>> print (tr.finished_on)
None
>>> tr.finished_on = '2020-01-01T00:00:00.000'
>>> print (tr.finished_on)
2020-01-01T00:00:00.000
>>> tr.update()
>>> print (tr.finished_on)
2020-01-01T00:00:00.000
>>> tr = TestRun("example", project_id="my_project")
>>> print (tr.finished_on)
2020-01-01 00:00:00+00:00
>>> tr.finished_on = None
>>> tr.update()
>>> print (tr.finished_on)
None
>>> tr = TestRun("example", project_id="my_project")
>>> print (tr.finished_on)
2020-01-01 00:00:00+00:00
>>>

@sbertramrh

wondering whether you can do this from UI or not 🤔
first statement print(tr.finished_on) printing None is only a side effect stating tr.finished_on didn't return anything, meaning you couldn't possibly set None on this attribute
reasoning through this from a functional perspective, when you mention that a testrun is finished you can only set new date but not no date at all
afaik, above operation is invalid, pls let me know in which scenarios you want to reset finished_on to ~null value?

wondering whether you can do this from UI or not thinking
Yes you can from the UI and it is how I discovered the issue. I reset (state change from finished to notrun) a finished test run in the UI and was able to successfully rerun. I then used pylero to reset the status from finished to notrun, but after the test run, got an error in the logs that I was loading the results on an already finished run. That is when I dug in and realized the finished_on date was still set. I made sure to pay attention to the date during the state change in the UI. It says "Perform action Mark Not Run" in the dropdown and once it is selected the finished on date is blank. This also happens for in progress state.
first statement print(tr.finished_on) printing None is only a side effect stating tr.finished_on didn't return anything, meaning you couldn't possibly set None on this attribute
I am not sure how to unset or clear a datetime field but everything I read said using "None" should work and the interface accepted it and also returned it. But this is what I am trying to do, unset or clear the field.
reasoning through this from a functional perspective, when you mention that a testrun is finished you can only set new date but not no date at all
Yes I am not trying to change the status to finished, I am trying to change the status to notrun as well as clear the finished_on field so that I can then rerun the tests and properly update with the new status and date.
afaik, above operation is invalid, pls let me know in which scenarios you want to reset finished_on to ~null value?
operation is valid unless the GUI is broken.
Basically want to rerun an already executed test run. Need to keep a static test run id for a report that uses it.

Thanks @leelavg

It says "Perform action Mark Not Run" in the dropdown and once it is selected the finished on date is blank.

Ack, it seems to reset finished_on we need to change status field 🤔
Thanks for the usecase, I'll revisit this once again then 😀

so I re-looked into it and found we can't possibly reset finished_on field
I should've saved time by looking at already documented note 😅
https://github.com/RedHatQE/pylero/blob/920821c21649695280b843d7a306bfa57b8d598d/src/pylero/test_run.py#L656-L658
better not to touch this field from Pylero, I suggest not setting it at all however I'm unsure whether that's valid from compliance perspective or not 🤔

>>> from pylero.test_run import TestRun
>>> tr = TestRun(project_id="example", test_run_id="run_id")
>>> tr.status
'notrun'
>>> tr.finished_on
>>> tr.status = 'finished'
>>> tr.finished_on
>>> tr.update()
>>> tr = TestRun(project_id="example", test_run_id="run_id")
>>> tr.status
'finished'
>>> tr.finished_on
>>> tr.status = 'inprogress'
>>> tr.update()
>>> tr = TestRun(project_id="example", test_run_id="run_id")
>>> tr.status
'inprogress'
>>> tr.finished_on
>>> tr.update()
>>> tr = TestRun(project_id="example", test_run_id="run_id")
>>> tr.status
'inprogress'
>>> tr.finished_on
>>>

Thanks @leelavg for looking into this. I will have to figure out another way. Really trying to avoid doing this in the ui. btw I guess I am setting the date but my real need is to clear the date, i.e. set it to nothing. So not really the same thing as manipulating it to another date. I understand a bit of the dilemma in changing it but as I go through the gui that ability does exist so was hoping it could also be implemented here. From the UI if you have a run that is in status finished and you edit and change the status to not run, in-progress, it automatically clears the date for you. Then after the save you can see the finished_on date is empty.
Here is what polarion sends to me in email after updating the status from finished:
Total 5 (5 Passed, 0 Failed, 0 Blocked)
Project:	RHEL
Status:	Finished Not Run
Type:	Regression
Finished On:	2022-01-04 16:34
Thanks


Enhance LDAP Structs

Add functions to the LdapAuthenticationProvider to create Volumes and Volume mounts for the bind credentials and the CA certificate, to reuse this code in each operator. Also the secret keys 'user' and 'password' would then not be referenced explicitly in the operators anymore, preventing bugs. Something like this:
A POC has been implemented in https://github.com/stackabletech/operator-rs/compare/ldap-helper-functions
To allow manual changes to the volume mounts, they should also be exposed in a function.
use this functionality in 2 operators to test it out before merging and releasing it.

Is this part of an epic?

It was part of this semi-epic: https://github.com/stackabletech/issues/issues/322


Disable intermittent test TransactionLocalParticipantFunctionTest

Purpose

$subject and more details can be found in #23678

Codecov Report

Merging #23679 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23679   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb5885...47c261b. Read the comment docs.


Clean 5.0.1 app "Failed to compile" using npm start script

Describe the bug
I am using create-react-app 5.0.1. Created and started running a clean app using the following commands:
npx create-react-app myapp
cd myapp
npm start

Get the following webpack error:
Failed to compile.

Module not found: Error: Can't resolve 'D:\myapp\node_modules\webpack-dev-server\client\index.js?protocol=ws%3A&hostname=<IP_ADDRESS>&port=3000&pathname=%2Fws&logging=none&reconnect=10' in 'D:\myapp'
ERROR in Module not found: Error: Can't resolve 'D:\myapp\node_modules\webpack-dev-server\client\index.js?protocol=ws%3A&hostname=<IP_ADDRESS>&port=3000&pathname=%2Fws&logging=none&reconnect=10' in 'D:\myapp'

webpack compiled with 1 error
No issues found.

The website actually runs fine. It also builds ok with npm build.
Did you try recovering your dependencies?
Yes
npm --version
8.7.0

Environment
Environment Info:

  current version of create-react-app: 5.0.1
  running from C:\Users\steve\AppData\Roaming\nvm\v16.13.2\node_modules\create-react-app

  System:
    OS: Windows 10 10.0.19044
    CPU: (8) x64 Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz
  Binaries:
    Node: 16.13.2 - D:\Program Files\nodejs\node.EXE
    Yarn: 1.22.15 - D:\Program Files\nodejs\yarn.CMD
    npm: 8.7.0 - D:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.19041.1266.0), Chromium (100.0.1185.44)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    react: ^18.0.0 => 18.0.0
    react-dom: ^18.0.0 => 18.0.0
    react-scripts: 5.0.1 => 5.0.1
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce
npx create-react-app myapp
cd myapp
npm start

Expected behavior
I would not expect to see any errors.

I think it might have had to do with using it within a Google Drive directory.


TST:MNT: add 30 minutes to test data

pvlib python pull request guidelines
Thank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.
You may submit a pull request with your code at any stage of completion.
The following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:

[ ] Closes issue #731
[ ] I am familiar with the contributing guidelines.
[ ] Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
[ ] Updates entries to docs/sphinx/source/api.rst for API changes.
[ ] Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
[ ] Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
[ ] New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
[ ] Pull request is nearly complete and ready for detailed review.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):

At this point we don't know if this change to the NSRDB is intended and will be permanent.  Perhaps let's comment out comparison of the Minute field from the test, and hold this change to the data file. I've asked NREL about the NSRDB change.

@mikofski can you revert the change to test_psm3.csv for now?  Thanks for this patch.

FYI: codecov thinks this change reduces coverage by -1 lines, because there is one new line, the comment, or maybe because I commented out one line?
# unclear if NSRDB changes are permanent

Thanks @mikofski


Configurable Recent Files List Length

Please make the length of the Recent Files List a configurable option as you did for the Recent Projects List.

I haven't the means to build from source, so I will have to await a new release to see the results of your fix.  I appreciate the quick response, but thinking about why I seem to be making this request and looking more closely at the behavior of the Recent Files pop-up, I think the problem is only severe for those of us who use .multi/Sessions.  The old, hard-coded limit of 15 files would not have been so restrictive if your data model and logic retained a Recent Files list per Session.  That is probably not the fix you just made, but, on reflection, would really be the better way to solve this requirement.


deleteDestination != delete-Destination

this document shows "deleteDestination" AND "delete-Destination" (wish a dash).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c02ef818-5e53-4582-43a8-22f9f2b2872d
Version Independent ID: b8f45994-4ac2-f124-c613-b82316203b9f
Content: azcopy sync
Content Source: articles/storage/common/storage-ref-azcopy-sync.md
Service: storage
Sub-service: common
GitHub Login: @normesta
Microsoft Alias: normesta

Thanks for point that out! I have created a PR and the changes should go live later today.


[main] Update community files

Cron -knative-prow-robot
Produced by: knative-sandbox/knobots/actions/update-community
Details:

/retest

/test integration-tests-istio_net-gateway-api_main


Update thumbnail.ts

Short description of what this resolves:
fixes 3 typos in thumbnail api doc
Changes proposed in this pull request:

Ionic Version: 1.x / 2.x
2.x
Fixes: #
minor: fix typos

Thanks for the PR!


add django to examples

Adding different django flavors to examples by a request passed in from Phil.

Current dependencies on/for this PR:

main

PR #8   👈

This comment was auto-generated by Graphite.


SSH Remoting Documentation: Minor mistake in command

Hi, I just wanted to point out a small mistake in a command in the [SSH remoting documentation](https://github.com/PowerShell/PowerShell/tree/master/demos/SSHRemoting :
The command should be 'sudo service sshd restart' and not 'sudo service ssh restart'
It should be obvious by looking at the text above but it can be confusing if a command does not work out of the box.

Good catch! I got to verify my blog post too.
Thx!


[Flink 31170] [docs]The spelling error of the document word causes sql to fail to execute

Fix word spelling errors

Thanks @BoYiZhang for the fix, would you mind referring Apache Flink development guidelines to modify the commit message?


Abstract a few methods

This commit is abstracting some of the following methods:

Abstract node methods by Component
Abstract hostname methods by Component
Abstract FQDN Methods by Component

cc/ @opscode-cookbooks/delivery

Me like it!

@jonsmorrow any comments on this? This was your recommendation .. :smile:


bug) Fighting Style Dueling

Fighting Style Dueling: "When you are wielding a melee weapon in one hand and no other weapons..."
But it's not working properly right now.

Contrary to what is stated, a duel does not work if the opposing hand is empty.

I cannot help without a save or hero.

https://drive.google.com/file/d/10vJlTPCGwKUYM2g1ee1AtnDB7S3iy9af/view?usp=drive_link
save file


Add a reference to the Awario Data Sheet

Also add reference to Awario Data sheet as mentioned in blockstack/app-mining#30 (comment)
cc: @friedger @cuevasm

I think it's easier to just add columns on the existing sheet vs linking a separate one. Especially since in a month or two all that will be needed is a login vs. all the sheets


What is "Azure Cognitive Service"?

Should this read "Azure Cognitive Services" above, to refer to all the services you could use in your bot?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ffe447d-f0a8-f4b6-d572-ba2c3bba4aab
Version Independent ID: 6c1d9a6a-4cb3-f404-ce1f-940b443f0e34
Content: Azure Bot Service Introduction - Bot Service
Content Source: articles/bot-service-overview-introduction.md
Service: bot-service
Product: bot-framework
GitHub Login: @Kaiqb
Microsoft Alias: kamrani

Updated to "Azure Cognitive Services" to match the product name. This update should go live in a few days.


How to run all tests without editing test.cpp?

Following https://github.com/exercism/cpp/blob/master/exercises/leap/README.md to run all the tests for an exercise, I edit eg. leap_test.cpp to move or delete the line #if defined(EXERCISM_RUN_ALL_TESTS).
Is it possible to run all the tests without editing leap_test.cpp? This would be more convenient for me.
I tried make EXERCISM_RUN_ALL_TESTS=1 but it still only ran one test.

If it's relevant, my setup following https://github.com/exercism/cpp/blob/master/docs/TESTS.md
mkdir build
cd build
cmake -G "Unix Makefiles" ..
cd ..
make

You could tell cmake  to define EXERCISM_RUN_ALL_TESTS on the command line:
cmake -DEXERCISM_RUN_ALL_TESTS=1 ..

Also, if you want to run clang-tidy you might also want to add -DCMAKE_EXPORT_COMPILE_COMMANDS=1 to that.

Thank you, that worked perfectly


[fix]: Able to save a phone number with some spaces before and without +

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/36072
PROPOSAL: https://github.com/Expensify/App/issues/36072#issuecomment-1932994035
Tests

Same as QA step

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA step
QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Desktop
https://github.com/Expensify/App/assets/110545952/32fffae6-d5df-4493-bbda-a62fdcd14221

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/110545952/b672b5d4-465c-4703-a80e-c416d047ab7d

iOS: mWeb Safari
https://github.com/Expensify/App/assets/110545952/3ce1690d-cb56-4d0c-9d37-aa63a9c20684

iOS: Native
https://github.com/Expensify/App/assets/110545952/2cf12fa5-5945-414f-8429-677dab1fd58c

Android: mWeb Chrome

Android: Native
https://github.com/Expensify/App/assets/110545952/084bcacb-8ded-499a-b8ce-2647364eea1e

\I'm sorry that I'm doing it this late, but I started a thread on Slack to figure out the details of the expected behavior. I'm having second thoughts about presenting an error to the user.

One of the internal engineers pressed "Agree". Also, I believe that the common sense should be always prioritized.
I'm sorry to put the extra work on you. I'll ask you to pivot to that behavior.
On the optimistic side, I think the code diff might be quite small!

@GandalfGwaihir I don't think this is required. Sometimes we pivot during the PR implementation. If we get the PR approved by the internal engineer, we'll be fine.

Same as QA step

In the future, try to ensure that "Tests" make sense for engineers. "Same as QA steps" doesn't work if the QA steps mention stuff like "applause.expensifail account".

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome
https://github.com/Expensify/App/assets/2590174/7eaf8255-ebc0-400b-992f-460f02fac750

iOS: Native
https://github.com/Expensify/App/assets/2590174/2b139f5c-b46e-498f-b0bc-f57c5fde55dc

iOS: mWeb Safari
https://github.com/Expensify/App/assets/2590174/b29a909b-fe77-444b-9fa6-32f5c324d399

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/2590174/fc2fe3fc-f03a-44b7-a5f1-44e0afbc4fad

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.4.53-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.53-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fails on #include <string>

How do I avoid failing on #include <string>?
<stdin>:1:10: fatal error: string: No such file or directory

Do I have to add preprocessor to my path or something?

@danielcjacobs is #include <string> a C++-ism? I think this project only works with C code.

Oh yes, you're right, thanks


[removed]

[removed]
I'm very tired and I misunderstood something about the Updater app. Sorry, I closed the issue.
Btw thanks for making this project! 👍

Thanks and cheers :)


wagtail fails to send notifications to moderators when page is submitted for review

Describe the bug
When submitting a page for moderation in wagtail, the page successfully submits and saves itself, but wagtail displays an error message stating that notifications to moderators failed to send.
To reproduce

Log into wagtail in production.
Create a new page (for example, under "about") and fill in the title and page body.
Choose "submit for moderation" from the menu where the "save draft" button is.

note: tested this in qa and it works correctly. error only occurs in production.
Expected behavior
No error message would be displayed and moderators would be notified of the submission.
Screenshots

Device information

Device: Dell Latitude E5470 laptop
OS and version: Ubuntu 18.04.3
Browser and version: Firefox 68.0.1
Site version: 0.23.1

Additional context
Suspect this is because wagtail is attempting to send an email notification but is running into some sort of permissions error in production.

@thatbudakguy wagtail moderation notifications are actually working now, right? Wasn't there a config you added?

so, I believe the emails are correctly sent, but I think the error message still shows in production? haven't tested it in awhile though.

Ok. We can try to test it the next time we have content to post and see if it's resolved.


could not find base type anySimpleType in namespace http://www.w3.org/2001/XMLSchema

Hello,
I'm trying to generate the schema for STIX 1.2 (https://github.com/STIXProject/schemas), but any schema I try (tried cybox common and common that both have anySimpletype) always fails with the error:
> xsdgen -vv common.xsd # Note common is this file: https://github.com/STIXProject/schemas/blob/master/common.xsd
read common.xsd
setting namespaces to ["http://docs.oasis-open.org/cti/ns/stix/common-1"]
complexType ControlledVocabularyStringType: could not find base type anySimpleType in namespace http://www.w3.org/2001/XMLSchema

I do see this defined in the builtins but it doesn't seem to be picked up (pretty close to this one: https://github.com/droyo/go-xml/issues/112, but not the same error). Is there an XSD I should be passing despite the builtin?
Thanks!

After a bit more research, looks like anySimpleType was introduced with XSD 1.1 (https://www.liquid-technologies.com/Reference/XmlStudio/XsdEditorNotation_BuiltInXsdTypes.html), but XML file is defined with <?xml version="1.0" encoding="UTF-8"?>, not sure if that's something which is "legit"

Not sure what kind of usable code it outputs, but changing this line https://github.com/droyo/go-xml/blob/master/xsd/builtin.go#L96 to "AnySimpleType" prevents this error.

@StabbyCutyou found the bug, it was an oversight in https://github.com/droyo/go-xml/commit/d7de88e1dfd94ebd3b0562f49285b7809286a360
I've made the suggested change, @remiphilippe how does it look now?


Alerts with GoAccess

Can we have alerts with goAccess. For ex: If I am having a spike in errors like 404 or 500 can I trigger an alert through mail? It will be helpful to have a system monitoring health of my web server along with log analytics.

+1 from #1954.
For me, it would be very helpful if a spike in visitors could over n amount could execute a bash script or similar.
As for an email based alert, I believe a webhook based solution may be more beneficial and practical to more users. This would enable me to receive a notification within tools like Slack or Discord, alerting me to the fact that an incident had been identified, and action taken.
Thresholds could be as simple as x IP exceeded y predefined limit. Or something more complicated.

Any updates or ETA on this? Seems very useful!

@UpperCenter I'm thinking this could go out in v1.5, I can certainly bump this up. Thanks for the reminder!

Our company would also need this. GoAccess would be our go to solution, if alerts were supported. Mainly needed for tracking abnormal request behaviour. Like same IP sending multiple POST requests to same endpoint over a period of time would generate an error, that could be forwarded to Slack for example.

@allinurl Hey! Great work on 1.7, any chance this is still in the pipeline? 🙏

Alerts along #117 are top priority on the list. Stay tuned as these two will be out rather soon.


Compute: Instance.getStatus() comment differs from web documentation

Environment details

Compute
OS type and version: OSX 10.14.5
Java version: 12
google-cloud-java version(s): 0.100.0-alpha

Steps to reproduce

Inspect com/google/cloud/compute/v1/Instance.java, lines 420-423

Code example
  /**
   * [Output Only] The status of the instance. One of the following values: PROVISIONING, STAGING,
   * RUNNING, STOPPING, STOPPED, SUSPENDING, SUSPENDED, and TERMINATED.
   */
  public String getStatus() {
    return status;
  }

External references such as API reference guides used
https://cloud.google.com/compute/docs/instances/instance-life-cycle
Any additional information below
The web documentation lists the states PROVISIONING, STAGING, RUNNING, STOPPING, TERMINATED, and REPAIRING. The code comment lists
PROVISIONING, STAGING, RUNNING, STOPPING, STOPPED, SUSPENDING, SUSPENDED, and TERMINATED.
This is confusing - which set of states is correct?

Closing this issue as this has already been addressed here


Add spec for sites with path components

This was raised in issues 245 and 386, the latter specificially regarding wordpress blogs which often define a "site" as including a path component.
This behaviour is already supported by Faraday (the underlying HTTP client) so long as you specify relative paths when constructing the new URLs rather than absolute ones, e.g. "oauth/authorize" will work but "oauth/token" will not.
It might be desirable to handle this automatically for users by stripping leading / characters from the authorize and token URL options (which should really be called *_path?), but could also be handled through documentation.
This commit adds a spec demonstrating the use of relative paths as per issue 386.
https://github.com/oauth-xx/oauth2/issues/386
https://github.com/oauth-xx/oauth2/issues/245

Pull Request Test Coverage Report for Build 849

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 847:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

Pull Request Test Coverage Report for Build 849

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 847:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

@pboling Hi Peter.  I've had a poke through your 2.0.0 milestone issues and the one mentioned here seems to be the only one not already handled in some way.

@elliotcm Thank you x 💯


Refactor types module

Refactor the numba.types module into a subpackage.
Based on PR #1724.

Looks reasonable to me.  Main change (beyond chopping up the much-too-long types module) seems to be using None instead of pyobject in several locations.  Any concerns, @sklam?

I was just about to point out that unify_pairs behavior was changed in this PR.

Returning pyobject created a recursive import problem between the various submodules of numba.types, which is why I changed the convention to None.

At https://github.com/pitrou/numba/blob/types_refactor/numba/typeinfer.py#L43
Shouldn't this be changed as well?

At https://github.com/pitrou/numba/blob/types_refactor/numba/typeinfer.py#L43
Shouldn't this be changed as well?

Yes, you're right. Fixing it.

Alright, as soon as Travis-CI is happy, we can merge.


Alt+D hijacked by Saka Key (Address bar focus)

Unfortunately when Saka Key is enabled, the native Alt+D (to get to the address bar) doesn't work (SK must be hijacking the mapping). I'd still like to be able to use the D key for scrolling down etc. Possible to fix? Thanks.

You can use Ctrl+K instead (not while writing a comment here)

Thanks that's a decent workaround. I still feel like it shouldn't be hijacking that mapping out of the box - maybe that's just me though.

+1 for not hijacking alt-d, it's pretty handy


[TASK] : Data Cleaning

Story:
Date: 18-01-2022
Description:
Create a python script that performs data cleaning on the dataset
Estimated efforts: 3

Successfully committed the changes


Update list of selected rows on drag in table and plots

The afqb.table.settings.selectedRows is only updated correctly with "onclick" operation, but not with drag. Drag selection should also update this object.

Addressed by #239.


Checkpoint replaying very very slow

versions
thanos, version 0.27.0 (branch: HEAD, revision: f68bb366d18557a5347e6b38013f363ad5be05a4)
  build user:       root@708554d4fa46
  build date:       20220705-14:57:42
  go version:       go1.17.11
  platform:         linux/amd64

OS : RHEL8
Architecture
hashing (2 routers and 3 receivers with replica=3)
Commande line :
/usr/bin/thanos receive --http-address <IP_ADDRESS>:19904 --grpc-address <IP_ADDRESS>:19903 --remote-write.address <IP_ADDRESS>:19291 --label=thanos_replica="p1thanosprod02 " --tsdb.path=/projet/data/thanos/receive --tsdb.retention=1d --objstore.config-file=/etc/thanos/objstore.yaml --receive.default-tenant-id=prod
Object Storage Provider: S3
What happened:
After upgrading to 0.27, each restart of receiver takes more than 5min per tenant
What you expected to happen:
Fast replaying
Full logs to relevant components:

Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.874729523Z caller=receive.go:481 component=receive msg="hashring has changed; server is not ready to receive web requests"
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.874738059Z caller=receive.go:563 component=receive msg="updating storage"
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.874786265Z caller=multitsdb.go:311 component=receive component=multi-tsdb tenant=prod msg="opening TSDB"
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.87503383Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659520800000 maxt=1659528000000 ulid=01G9HWN8RCCDYYYRX0E998QM6J
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875081097Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659528000000 maxt=1659535200000 ulid=01G9J3GZZF4KCZXX7H04AFY8A9
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875107989Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659535200000 maxt=1659542400000 ulid=01G9JACQH1E7WDXKYGMA6QRA9E
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875132359Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659542400000 maxt=1659549600000 ulid=01G9JH8EFZ47ST4AEQVASCDMMY
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875152892Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659549600000 maxt=1659556800000 ulid=01G9JR45Q4S79TDXGXQE443GMW
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875172316Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659556800000 maxt=1659564000000 ulid=01G9JYZWYS6JPS062RAMVG7S95
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875191784Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659564000000 maxt=1659571200000 ulid=01G9K5VM6WA3THBP7N0T2WWDAN
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875210939Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659571200000 maxt=1659578400000 ulid=01G9KCQAYK2DTMVHDRPWG2PKHH
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875232684Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659578400000 maxt=1659585600000 ulid=01G9KKK2854PC83E81W22GMPR1
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875251863Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659585600000 maxt=1659592800000 ulid=01G9KTESFFPTBXZTABEVBE41B1
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875270352Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659592800000 maxt=1659600000000 ulid=01G9M1AGXV7V25TKD9ZA7GPR3G
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875289027Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659600000000 maxt=1659607200000 ulid=01G9M86862RR25NW64SR4YNV1E
Aug 04 13:14:38 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:38.875311507Z caller=repair.go:57 component=receive component=multi-tsdb tenant=prod msg="Found healthy block" mint=1659607200000 maxt=1659611617558 ulid=01G9M8Z6TTT1CMBYDVNFYXDSPP
Aug 04 13:14:39 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:39.110533063Z caller=head.go:493 component=receive component=multi-tsdb tenant=prod msg="Replaying on-disk memory mappable chunks if any"
Aug 04 13:14:39 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:39.1114571Z caller=head.go:527 component=receive component=multi-tsdb tenant=prod msg="On-disk memory mappable chunks replay completed" duration=886.864µs
Aug 04 13:14:39 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:14:39.111484133Z caller=head.go:533 component=receive component=multi-tsdb tenant=prod msg="Replaying WAL, this may take a while"
Aug 04 13:19:45 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:19:45.058705918Z caller=head.go:569 component=receive component=multi-tsdb tenant=prod msg="WAL checkpoint loaded"
Aug 04 13:19:47 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:19:47.44320823Z caller=head.go:604 component=receive component=multi-tsdb tenant=prod msg="WAL segment loaded" segment=30317 maxSegment=30323
Aug 04 13:19:48 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:19:48.963708983Z caller=head.go:604 component=receive component=multi-tsdb tenant=prod msg="WAL segment loaded" segment=30318 maxSegment=30323
Aug 04 13:19:50 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:19:50.558080352Z caller=head.go:604 component=receive component=multi-tsdb tenant=prod msg="WAL segment loaded" segment=30319 maxSegment=30323
Aug 04 13:19:52 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:19:52.336362645Z caller=head.go:604 component=receive component=multi-tsdb tenant=prod msg="WAL segment loaded" segment=30320 maxSegment=30323
Aug 04 13:19:52 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:19:52.385878218Z caller=head.go:604 component=receive component=multi-tsdb tenant=prod msg="WAL segment loaded" segment=30321 maxSegment=30323
Aug 04 13:19:52 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:19:52.943759516Z caller=head.go:604 component=receive component=multi-tsdb tenant=prod msg="WAL segment loaded" segment=30322 maxSegment=30323
Aug 04 13:19:52 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:19:52.943949553Z caller=head.go:604 component=receive component=multi-tsdb tenant=prod msg="WAL segment loaded" segment=30323 maxSegment=30323
Aug 04 13:19:52 p1thanosprod02 thanos[3417605]: level=info ts=2022-08-04T11:19:52.943968195Z caller=head.go:610 component=receive component=multi-tsdb tenant=prod msg="WAL replay completed" checkpoint_replay_duration=**5m5.947265781s** wal_replay_duration=7.88520992s total_replay_duration=5m13.833397584s

This is due to checkpoint replay (see checkpoint_replay_duration=5m5.947265781s)

I have same issue on version v0.26.0 and v0.27.0. (and maybe version v0.24.0? I forgot and lost log)
I have a large dataset which average 48,130 samples per second and I need to store it 7 days for fast query.
With 5 receivers set replica=3. There is about 17,465,271,337.6 samples stored in tsdb. And every time I need to run kubectl rollout restart (for change pod resource limit or upgrade version). It will take about 10 minute on "Replaying WAL".

Yeah this is becoming increasingly an issue for us as well, where replays on some replicas for some tenants can take ten(s) of minutes.
I guess it has been like this since at least a few versions (so my assumption is this is not related to any recent change); if it even is related to Thanos changes and not just the fact users handle more data. Either way this require more investigation and potential ideas on how to alleviate it.
I was also looking at the experimental snapshot-on-shutdown feature in TSDB (https://ganeshvernekar.com/blog/prometheus-tsdb-snapshot-on-shutdown/) and trying it in receive, but I'd need to first take a better look at this feature.

Memory snapshotting seems to be a TSDB option. Maybe it's just a matter of setting this flag when starting receiver TSDBs?

https://github.com/prometheus/prometheus/pull/10973 This commit has been merged to Prometheus main branch already. I think this is also worth trying to see if this could help.

I have now added possibility to use snapshot on shutdown in https://github.com/thanos-io/thanos/pull/5836, also the change @yeya24 mentions already landed in Thanos, so we should see improvements. Please try either or both solutions and let us know if you see improvements!

I will close this issue since the improvements from upstream Prometheus are already included.


Created downgrade method for MaterialProgress.

The MaterialProgress doesn't contain a downgrade method therefore it is impossible to downgrade because of this condition: https://github.com/google/material-design-lite/blob/master/src/mdlComponentHandler.js#L275-L278
This PR includes a downgrade method for MaterialProgress and removes the bars so they don't get duplicated upon upgrading.

Oh, we missed a component. Thanks for the PR! Lgtm.

lgtm.
Not really needed here since it is just removing nodes which is easily done in userland, but still useful.

Thanks :)
Removing the nodes isn't really an issue, I'm more interested in what happens within the deconstructComponentInternal  method.

What exactly are you interested in about it? I wrote it so I should be able to answer any questions you may have.

Just the way it removes the component from the createdComponents  list and updates the upgraded data attribute like all the other components :)

It removes the item from createdComponents by just splicing it's index.
It updates the upgraded attribute by:

Making an array from the existing value.
Getting the index of the downgraded component classname.
Splicing that place out of the array.
Re-assign the upgraded attribute by joining the array back together.

Thanks :)


Fixing Bug 1159105 in WPF Sample

Environment Details:
Application Name: .NETCore WPF
Microsoft .NET Core SDK Version <IP_ADDRESS>018
Microsoft .NET Core SDK 3.1.400 - preview (x86)
Visual Studio 2019 INT Preview 16.7 Preview 4
Screen reader: Narrator,NVDA[2020.1]
Prerequisite:
To use the samples with Git, clone the WPF-Samples repository with 'git clone https://github.com/microsoft/WPF-Samples'
After cloning the WPF-Samples repository, please open the solution file, WPF-Samples.sln in the root directory.
To build the samples, open the solution file in Visual Studio 2019 and build the specific project you’re interested in. You can then right-click on the project file and select Debug -> Start new instance to run the application
Steps to Reproduce:
Launch VS 2019 Int Preview
Navigate to Sample Applications and right click on the DatabindingDemo and click on build.
Then right click on DatabindingDemo then Click on Debug-->Start New Instance.
List of products screen should open.
Check whether the screenreader reads heading level1 for the "List of Items for Sale".
Actual:
While navigating through caps lock+Arrow key, Screenreader does not announce header 1 for the "List of Items for Sale".
Expected:
Screenreader should read header 1 for "List of Items for Sale".
User Impact:
Screenreader user unable to get whether the contents come under which header.
Recommendations:
Refer repository of bug fixes code snippets.

qq

/azp run


fix(cli): taurignore ignoreing folders not working for watch

Fixes #8901

Could you give an example of the .taurignore you're trying to fix?

This taurignore should ignore changes in web folder from watching but doesn't. changes in .next folder will cause rebuilding whole app.

@anatawa12 sorry for the long delay, I just tested the ignore file you posted and I didn't see any issues, all files were ignored except package.json
Would you mind providing a repro?

https://github.com/anatawa12/tauri-issue-8901 is the repository that I can reproduce this problem.
clone and run cargo tauri dev and then editing web/ignored/test file will cause rebuild of the crate.


Cherry-pick netaddr-0.8.0 upgrade on release-20.09

Motivation for this change
Updating to >= 0.7.20 fixes tests on macOS Catalina and newer:
        #   inet_pton has to be different on Mac OSX *sigh*
        assert IPAddress('<IP_ADDRESS>', flags=INET_PTON) == IPAddress('<IP_ADDRESS>')
>       assert int_to_str(0xffff) == '::<IP_ADDRESS>'
E       AssertionError: assert '::ffff' == '::<IP_ADDRESS>'
E         - ::<IP_ADDRESS>
E         + ::ffff

(cherry picked from commit c32441811f1b80de23c80d9acc89625235100685)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3Packages.netaddr

nixpkgs-review pr 100988  succeeded except for failed builds of pythonPackages.WSME which are unrelated to the netaddr upgrade. Those failures can be fixed by cherry-picking 143289ad5ba74c60e576534d0c760493f4497608 to release-20.09.


Feature/Added distance markers to the routing path

Adding distance markers each 5km.
Currently this is not configurable.
Addresses: https://github.com/nrenner/brouter-web/issues/169

Regarding the fact that this is not (yet) configurable, I'll create another issue for BRouter-web general configuration. I think having a settings for it there makes sense?

Thanks! Nice improvements to the original plugin, might be worth making a PR for your changes?


Dynamics Business Central

I observe that Power BI has a connection to user Dynamics Business Central as a data source. How do I do the same in Data Factory?

Dokumentinformasjon
⚠ Ikke rediger denne delen. Den kreves for koblingen docs.microsoft.com ➟ GitHub-problem.

ID: 4810e7d6-28ed-d956-44b6-77fe62b579e5
Version Independent ID: 98b5df43-40de-ee10-e63c-c5f15eca1a16
Content: Source transformation in mapping data flow - Azure Data Factory
Content Source: articles/data-factory/data-flow-source.md
Service: data-factory
GitHub Login: @kromerm
Microsoft Alias: makromer

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

For the record, using OData is a workaround. Not as elegant as The "Dynamics business central data connection" in Power BI, but it works. Only challenge with this approach is that Business Central requires you to select a company before you can assess the individual tables(endpoints). This justifies lowering the priority of this issue.

@DanielHolth  : At this time i don't think that we have a connector for that . Please go ahead add the same as request at : https://feedback.azure.com/forums/270578-data-factory . The ADF team does reviews the request and can plan it to impment in future .
We are closing this issue  , you can always re-open the issue if you think that appropriate .


Fix/update github actions

Fixes/updates the github actions build.
Also update dependencies

:+1:

:+1:

👍


Don't use finalizedBy

Or add some onlyIfs.
finalizedBy is executed even if a task was failed.

Connected: https://github.com/FIDATA/gradle-base-plugins/issues/74


Milestone 3

This is essentially the same thing as Milestone 2 because not a whole lot has changed. I just added the walkthrough and the repo issues section.

Coverage remained the same at 94.362% when pulling 1d47a47b969a0229f0d3856c99c957ddcb5530b9 on milestone-3 into b7cd7b5d89c514eacdf46e9e623f69e55976998e on dev.

Coverage remained the same at 94.362% when pulling 68fb3b3b1bbdf140d39745a729239e62dc8b29c8 on milestone-3 into b7cd7b5d89c514eacdf46e9e623f69e55976998e on dev.

Coverage remained the same at 94.362% when pulling 13a8bf8e16e2f73844c8d1537dd0b5f82717caf8 on milestone-3 into b7cd7b5d89c514eacdf46e9e623f69e55976998e on dev.


Store the new IndexedWork/Image models in the ingestor

For https://github.com/wellcomecollection/platform/issues/5449
This realises the models defined in #2071. I've copied across the display models from the catalogue-api repo, and removed the bits we don't need here (e.g. items will always get identifiers if available, whereas the catalogue-api repo adds/removes them based on the user-defined includes).
Then I've updated the works and images ingestor to use the new models, updated the index mappings to support them, and updated the tests to get them passing.

Closing as superseded.


Use Feature Gates to enable or disable features

There are a number of features that are being developed and likely to be
disabled by default in their early stage.
Instead of adding a temporary config for each feature and maintaining
them separately, this patch introduces Feature Gates to toggle the
features. It will be easier to choose code branch based on FeatureGates'
"Enabled" method and to promote features to beta and GA.
Closes #846

One more question: will this bring gates flags, like --featureGates=ClusterPolicy=true ?

One more question: will this bring gates flags, like --featureGates=ClusterPolicy=true ?

No, the library supports it but I didn't add that CLI flag as we use config file.

/test-all

/test-windows-conformance

Is there a way to reduce the per-feature overhead of changing yamls->featureset->feature?
On every new feature there are quite a lot of files to be changed, then reviewed merged etc and would be nice to have this more compact.
IDK if this is either possible and would rather stick to some standard.

Is there a way to reduce the per-feature overhead of changing yamls->featureset->feature?
On every new feature there are quite a lot of files to be changed, then reviewed merged etc and would be nice to have this more compact.
IDK if this is either possible and would rather stick to some standard.

Perhaps the feature list can be removed from yamls, I added it for convenience to edit, but we should have a doc to list experimental features and their stage anyway so user can refer to that doc to configure features.
For the change in antrea_features.go, I don't think it can be more compact than it is. Currently it needs two lines of code, one for feature name, one for its default value and stage.

/test-all
/skip-whole-conformance

/test-all

/test-windows-conformance

/test-windows-conformance

/test-windows-conformance

@antoninbas Sure, let's discuss whether antrea service proxy should be an experimental feature or an optional feature in #772


jozu hub compatibility

This should not be merged until after the Jozu Hub is launched
Updated docs to simplify pulling ModelKits by grabbing them from Jozu Hub.
Since we can only pull from Jozu Hub, not push, I left things like kit login and kit push pointing to ghcr.io. Once Jozu Hub can accept pushes we'll swap those over so new and existing users can see the ModelKits with more metadata and detail in the Hub.

@bmicklea maybe this could be turned into a Draft PR, to avoid accidentally merging it?

We can merge this now that the jozu.ml is working properly.


Feature: Move Python dependencies into extras

Describe what you are looking for
Pillow and NumPy aren't as heavy as PyTorch, but it would be nice to move those into a list of optional dependencies.
Can you contribute to the implementation?

[ ] I can contribute

Is your feature request specific to a certain interface?
It applies to everything
Contact Details
No response
Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Moreover, Pillow often causes version conflicts with other packages installed on the system. I've just noticed that in a USearch+StreamLit demo, where UCall comes as a dependency. We can have some custom annotation classes in UCall to mark pil.Image or np.ndarray arguments without explicitly importing them. On a related note, TenPack will be getting some useful functionality for tensors packaging and media parsing, that may come handy here.