room-join event cannot get inviteeList when name of invitee contains some emoji

Provide Your Network Information
Where is the location of your server? (i.e. City, or In/Out China)
Hong Kong
Run npm run doctor or wechaty run doctor(for docker user), paste output here
npm ERR! missing script: doctor
node -v: v8.0.0
npm -v: 5.0.0
Expected behavior
When users join the room, send a welcome message and friend requests to them.
Actual behavior
InviteeList cannot get the contact object that name contains some emoji.
I have tested for some cases. Some emoji like ring bell has no problem.
obj:
{ ......
name: '丁叮🛎',
...... }
But some other emoji like pumpkin cannot run correctly.
obj:
{ ......
name: '丁叮',
...... }
(This object is got in 'message' event by message.from(). By the way, on 'message' gets no problem with pumpkin emoji)
Steps to reproduce the behavior (and fixes, if any)
bot.on('room-join', (room, inviteeList, inviter) => {
        const nameList = inviteeList.map(c => c.name()).join(',');
        room.say(`歡迎新成員 ${nameList} 加入`);
    })

In this case, '歡迎新成員  加入' will be displayed in the room.
Paste the full output logs here with WECHATY_LOG=silly set
log.txt

I changed line 337 (or nearby?) in room.js from:
const filterValue = queryArg[filterKey];
into
const filterValue = util_lib_1.default.stripEmoji(util_lib_1.default.plainText(queryArg[filterKey]));
It seems ok. I have only tested 3-4 times. Hope it helps.

Yes, it helps.
However, what's the version of Wechaty were you using?
It seems we did it at https://github.com/Chatie/wechaty/blob/master/src/room.ts#L481
    const filterValue: string  = UtilLib.stripEmoji(queryArg[filterKey])

And ISSUE #64 is related to emoji need to be striped problem.

Oh, my Wechaty version is 0.8.91.

So did update to the latest version fix your issue?

No error and only warning is showed in version 0.8.110
But the contact still cannot be got

I just add your solution to the code base, please check the latest version(0.8.114 or above). Also refer to #64

The error still comes out seldom. Here is the warning message in another case:
12:16:44 WARN PuppetWebFirer fireRoomJoin() reject() inviteeContactList: , inviterContact: kk3hi3123
In this case, the name of invitee has no emoji but the contact object still cannot be got. I have tried to call room.memberList() but the invitee is not included in the list. And contact.avatar() returns "Error: Can not get avatar: not ready".

@kk3hi3123   Yes, I got a lot of this error too, because I use group-qrcode-image to invite people into the room, if people join in the room too fast(like 10 persons join in the room in one second), and it will get the error.

And sometimes even got the following error:
12:11:11 ERR PuppetWebFirer firmRoomJoin() inivter not found for 32e0cbe1-950e-4c2c-9fd5-90e927d6825b , `room-join` & `join` event will not fired

I suggest if cannot get inviter, it will fired room-join event too, then we can know exactly how many people join the room.

Moved to https://github.com/Chatie/wechaty-puppet-puppeteer/issues/27


IdeogramTrack() can't import chromosome length

Hi Robert et al.,
Just reporting this issue since DMRcate uses Gviz for plotting. This could be a temporary problem on my end and I'm happy to be told so. When I try to import a chromosome using IdeogramTrack(), it throws an error saying it can't access chromosome lengths:
> ideoTrack <- IdeogramTrack(genome = "hg38",chromosome = "chr22")
Error in value[[3L]](cond) :
  There doesn't seem to be any chromosome length data available for genome 'hg38' at UCSC or the service is temporarily down.
In addition: Warning messages:
1: In curlSetOpt(..., .opts = .opts, curl = h, .encoding = .encoding) :
  Error setting the option for # 3 (status = 43) (enum = 81) (value = 0x56228ca457b0): A libcurl function was given a bad argument CURLOPT_SSL_VERIFYHOST no longer supports 1 as value!
2: In value[[3L]](cond) :
  There doesn't seem to be any cytoband data available for genome 'hg38' at UCSC or the service is temporarily down. Trying to fetch the chromosome length data.

I have tried this on multiple machines with different internet connections, all working fine, so I don't think it's a connectivity problem. Here is the traceback and sessionInfo:
> traceback()
19: stop("There doesn't seem to be any chromosome length data available for genome '",
        genome, "' at UCSC or the service is temporarily down.")
18: value[[3L]](cond)
17: tryCatchOne(expr, names, parentenv, handlers[[1L]])
16: tryCatchList(expr, classes, parentenv, handlers)
15: tryCatch(ucscTableQuery(session, table = "chromInfo"), error = function(e) {
        stop("There doesn't seem to be any chromosome length data available for genome '",
            genome, "' at UCSC or the service is temporarily down.")
    })
14: value[[3L]](cond)
13: tryCatchOne(expr, names, parentenv, handlers[[1L]])
12: tryCatchList(expr, classes, parentenv, handlers)
11: tryCatch(ucscTableQuery(session, table = "cytoBandIdeo"), error = function(e) {
        warning("There doesn't seem to be any cytoband data available for genome '",
            genome, "' at UCSC or the service is temporarily down. Trying to fetch the chromosome length data.")
        tryCatch(ucscTableQuery(session, table = "chromInfo"), error = function(e) {
            stop("There doesn't seem to be any chromosome length data available for genome '",
                genome, "' at UCSC or the service is temporarily down.")
        })
    })
10: eval(expression, envir = callEnv)
9: eval(expression, envir = callEnv)
8: eval(expression, envir = callEnv)
7: .doCache(genomesToken, expression({
       if (!genome %in% as.character(genomes[, "db"])) {
           stop("'", genome, "' is not a valid UCSC genome.")
       }
       sessionToken <- paste("session", genome, sep = "_")
       session <- .doCache(sessionToken, expression({
           myUcscUrl <- getOption("Gviz.ucscUrl")
           tmp <- if (is.null(myUcscUrl)) browserSession() else browserSession(url = myUcscUrl)
           genome(tmp) <- genome
           tmp
       }), env, cenv)
       query <- tryCatch(ucscTableQuery(session, table = "cytoBandIdeo"),
           error = function(e) {
               warning("There doesn't seem to be any cytoband data available for genome '",
                   genome, "' at UCSC or the service is temporarily down. Trying to fetch the chromosome length data.")
               tryCatch(ucscTableQuery(session, table = "chromInfo"),
                   error = function(e) {
                     stop("There doesn't seem to be any chromosome length data available for genome '",
                       genome, "' at UCSC or the service is temporarily down.")
                   })
           })
       out <- getTable(query)
       if (all(c("chrom", "size") %in% colnames(out))) {
           out <- data.frame(chrom = out$chrom, chromStart = 0,
               chromEnd = out$size, name = "", gieStain = "gneg",
               stringsAsFactors = FALSE)
       }
       out
   }), env, cenv)
6: .cacheGenomes(genome = genome)
5: .local(.Object, ...)
4: initialize(value, ...)
3: initialize(value, ...)
2: new("IdeogramTrack", chromosome = chromosome, genome = genome,
       name = name, bands = bands, ...)
1: IdeogramTrack(genome = "hg38", chromosome = "chr22")
> sessionInfo()
R version 4.2.2 Patched (2022-11-10 r83330)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 18.04.6 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.7.1
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.7.1

locale:
 [1] LC_CTYPE=en_AU.UTF-8       LC_NUMERIC=C
 [3] LC_TIME=en_AU.UTF-8        LC_COLLATE=en_AU.UTF-8
 [5] LC_MONETARY=en_AU.UTF-8    LC_MESSAGES=en_AU.UTF-8
 [7] LC_PAPER=en_AU.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_AU.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] grid      stats4    stats     graphics  grDevices utils     datasets
[8] methods   base

other attached packages:
[1] Gviz_1.41.1          GenomicRanges_1.50.2 GenomeInfoDb_1.34.7
[4] IRanges_2.32.0       S4Vectors_0.36.1     BiocGenerics_0.44.0

loaded via a namespace (and not attached):
  [1] ProtGenerics_1.30.0         bitops_1.0-7
  [3] matrixStats_0.63.0          bit64_4.0.5
  [5] filelock_1.0.2              RColorBrewer_1.1-3
  [7] progress_1.2.2              httr_1.4.4
  [9] tools_4.2.2                 backports_1.4.1
 [11] utf8_1.2.3                  R6_2.5.1
 [13] rpart_4.1.19                lazyeval_0.2.2
 [15] Hmisc_4.7-2                 DBI_1.1.3
 [17] colorspace_2.1-0            nnet_7.3-18
 [19] tidyselect_1.2.0            gridExtra_2.3
 [21] prettyunits_1.1.1           bit_4.0.5
 [23] curl_5.0.0                  compiler_4.2.2
 [25] cli_3.6.0                   Biobase_2.58.0
 [27] htmlTable_2.4.1             xml2_1.3.3
 [29] DelayedArray_0.24.0         rtracklayer_1.58.0
 [31] scales_1.2.1                checkmate_2.1.0
 [33] rappdirs_0.3.3              stringr_1.5.0
 [35] digest_0.6.31               Rsamtools_2.14.0
 [37] foreign_0.8-82              XVector_0.38.0
 [39] dichromat_2.0-0.1           htmltools_0.5.4
 [41] base64enc_0.1-3             jpeg_0.1-10
 [43] pkgconfig_2.0.3             MatrixGenerics_1.10.0
 [45] ensembldb_2.22.0            dbplyr_2.3.0
 [47] fastmap_1.1.0               BSgenome_1.66.2
 [49] htmlwidgets_1.6.1           rlang_1.0.6
 [51] rstudioapi_0.14             RSQLite_2.2.20
 [53] BiocIO_1.8.0                generics_0.1.3
 [55] BiocParallel_1.32.5         dplyr_1.1.0
 [57] VariantAnnotation_1.44.0    RCurl_1.98-1.10
 [59] magrittr_2.0.3              GenomeInfoDbData_1.2.9
 [61] Formula_1.2-4               interp_1.1-3
 [63] Matrix_1.5-1                Rcpp_1.0.10
 [65] munsell_0.5.0               fansi_1.0.4
 [67] lifecycle_1.0.3             stringi_1.7.12
 [69] yaml_2.3.7                  SummarizedExperiment_1.28.0
 [71] zlibbioc_1.44.0             BiocFileCache_2.6.0
 [73] blob_1.2.3                  parallel_4.2.2
 [75] crayon_1.5.2                deldir_1.0-6
 [77] lattice_0.20-45             Biostrings_2.66.0
 [79] splines_4.2.2               GenomicFeatures_1.50.4
 [81] hms_1.1.2                   KEGGREST_1.38.0
 [83] knitr_1.42                  pillar_1.8.1
 [85] rjson_0.2.21                codetools_0.2-18
 [87] biomaRt_2.54.0              XML_3.99-0.13
 [89] glue_1.6.2                  biovizBase_1.46.0
 [91] latticeExtra_0.6-30         data.table_1.14.6
 [93] png_0.1-8                   vctrs_0.5.2
 [95] gtable_0.3.1                assertthat_0.2.1
 [97] cachem_1.0.6                ggplot2_3.4.0
 [99] xfun_0.37                   AnnotationFilter_1.22.0
[101] restfulr_0.0.15             survival_3.4-0
[103] tibble_3.1.8                GenomicAlignments_1.34.0
[105] AnnotationDbi_1.60.0        memoise_2.0.1
[107] cluster_2.1.4               ellipsis_0.3.2

Any fixes and/or suggestions would be much appreciated.
Best,
Tim

hi Tim,
I am afraid it might be related to internet connection to UCSC servers. I hope it works for you in the meantime.


Detaching a Script from a Node Produces Neither Warning nor Confirmation of the Action

Godot version
v4.1.1.stable.official [bd6af8e0e]
System information
Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Compatibility) - NVIDIA GeForce GTX 1060 (NVIDIA; <IP_ADDRESS>11) - Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 Threads)
Issue description
Many destructive actions provide you with a confirmation dialog.  However, the "detach script" function does not seem to be one of them.  The script will get silently detached from the selected node without any warning or confirmation.
Suggest that either a warning or a confirmation of the action be provided.  This is because an errant click can cause detachment and you might not notice it quickly enough to easily perform an Undo to resolve the issue.
Steps to reproduce
Simply press [Detach the script from the selected node.] on a node with a script attached.
Minimal reproduction project
N/A

I don't think it's necessary, as there is no loss from this action. We can simply undo the action or reattach the script since it hasn't been deleted. @Calinou could you please confirm if this is required?

Just remember that there are other actions in Godot that result in confirmation dialogs (e.g. deletion of a Node, deletion of an Animation) and they too are reversible via Undo actions -- but they still have confirmation dialogs.  Simply being able to Undo an action should not by itself be a good enough reason, IMHO.  Otherwise it would be a good enough reason to go and remove the existing confirmation dialogs for those other actions, simply because they are Undoable, right?
Remember that consistent behavior goes a long way when dealing with UI/UX issues.
The other thing to remember is that this particular action is a "silent" one.  If the user accidently disconnects a script, they may have no idea that they did it, and may be confused as to why something suddenly stopped working correctly in their game later on.  (Although that might just warrant a confirmation dialog.)
-=- James.

I agree. I thought that there would be no data loss by this action. But, when we export some variables or an array of variables and then disconnect the script, all the data gets lost. Even after undoing, we get the default value we set in the script. So, I think it's a good reason to do it.

...if only there was a way to reopen the issue... :)

I agree. I thought that there would be no data loss by this action. But, when we export some variables or an array of variables and then disconnect the script, all the data gets lost. Even after undoing, we get the default value we set in the script. So, I think it's a good reason to do it.

In this case, it makes sense to display a confirmation dialog if the script has exported properties with non-default values – or better, attempt to restore the custom property values.

Chiming in here having just gone through this myself. I too believe a confirmation is needed when detaching a script. A toast style notification would be an upgrade, but still easy to overlook when looking across 2 or more monitors. I would hope for something more concrete since these actions are often unintended, but can easily snowball.
The previous point made about this being a silent action is a very important one, and something that I don't believe is fixed even if the exported properties are restored, as going back to that state also undoes any other actions made since then. It may not even be on the list of history states depending on when you notice, or even more, you save and close the project.
In my case, I unknowingly detached the script on my camera in the scene I was working on. It had an exported array of variables with all my different camera shake types, each with their own list of settings dialed in. The scene I was working on was my main level, so my history panel was quickly filled with all different parts and pieces being added in and all their moves. It wasn't until I went to test the level did I see an error and realize what happened. Now I'm stuck between undoing the level I just built or setting my camera up from scratch.
It was a very disheartening lesson to learn. One I will do my best to take precaution against going forward, however I think the need for this to be an option is very real, and could serve to cast a wider net of protection than hindrance to the user experience.


Wait for Github callback to exit

:tada: This PR is included in version 5.12.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Array Extension

Hi @Anviking
Can you have a look of the changes I made please? - I've removed the array structs and I think I haven't break anything.
Cheers

Thanks! But I’m not sure about this. It's nice to lose the array structs, but the added try!in the test for parsing an [String]? from a nested dictionary, probably indicates that something's up.
I’m not sure whats going on there but probably that [T]is not conforming to Decodable as DecodableArray<T> does. This could be solved with lots of new overloads, but fewer is nicer.
So, I'd stick to the structs for now, unless I'm missing something here.

No problem @Anviking I understand and share the concerns ;)


feat(hardware): ot3: set per-axis max speeds

Currently, we can specify a linear speed that an individual move cannot
exceed. This limit is generally given by higher level code and is more
about scientific concerns (avoiding shaking, for instance) than about
robotics concerns.
However, there are also speed limits that are based on robotics
concerns. Any given axis has a speed it may not exceed due to physical
limits - the speed at which its dynamic friction overcomes its available
torque, the speed at which it's no longer possible to represent that
speed correctly in binary, etc - and that limit, too, must be
represented.
These speeds are properly part of an axis's constraints, so we add them
there.
We can implement the speed limit by making the input speed provisioned
on each Move object the smaller of the linear speed limit and the
projected axis-speed-limit-based value when we make a new Move object at
the beginning of a blend pass.
This happens by decomposing the linear speed through the move's unit
vector and comparing each component to the individual axis limit. If the
limit is lower, we can apply ratio between the axis speed limit and the
axis linear speed component to scale down the given speed.
Then, we can use the per-axis max speed values we've always had (and that have
been silently ignored) to actually provision the system constraints.
Closes RCORE-125

Tested on hardware and the pipette doesn't make adorable chirps anymore, but also everything is slower because all those config values weren't being restricted, so it's time to increase them


Should use norska-theme-search-infinite

Instead of copy-pasting the infiniteMasonry code of /maps, I should release a theme that includes the infinite scroll masonry and have both projects depend on it.
I could also create a norska-theme-search-sidebar for the more classic /monsters and /society

Done, norska-theme-search-infinite has been released and documented


Output stdout from long running task

Tested with following markdown:
This is how bashtestmd works.

You can start with long-running command

```sh,test-ci,bashtestmd:long-running,bashtestmd:wait-until=PING
$ ping <IP_ADDRESS>

And then do couple other commands.
This will just check exit code
$ date

This will compare output
$ echo "Hello world"
Hello world

and if output does not match, it will fail, and also prints output of the long running command
$ whoami
super-root```

and output is:
Running: 'ping <IP_ADDRESS>'
Waiting for process with PID: 33937 to have a match in /var/folders/cq/zfvc0h8s1199jjhrk2spc1mw0000gn/T/tmp.G4NeQNbryJ
.
Running: 'date'
Mon Sep  2 09:59:57 CEST 2024
Running: 'echo "Hello world"'
Running: 'whoami'
'super-root```
' not found in text:
'nikolai'
Output of the long running task:
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: icmp_seq=0 ttl=116 time=21.474 ms
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=116 time=15.565 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=116 time=22.328 ms
64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=116 time=51.119 ms
64 bytes from <IP_ADDRESS>: icmp_seq=4 ttl=116 time=19.185 ms
=========== END OF THE LONG RUNNING OUTPUT. Terminating...
demo-bash.sh: line 67: 33937 Terminated: 15          ping <IP_ADDRESS> >&$long_running_output

We should also bump the patch version number.


Add tracking fixes

This PR:

corrects dimension1 for Level 1 pageview to be <level 1 topic name> eg births, deaths, marriages and care
removes a gem-track-click attribute from the accordion wrapper as it's already set on the lists and was making the link click events fire twice; keeping it on the lists (instead of the wrapper) to be more explicit about what it impacts since the 'Show all' button also sets its (button click) tracking with a separate attribute inside the accordion
removes explicitly setting location or title on the accordion link clicks; this makes Document location URL and Document Title flow from the pageview directly so that they are the URL and title of the page the accordion is on (so similar to the current homepage implementation)

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

looks good to me


redeclipse: init at 1.6.0

Added a package for the FPS Red Eclipse. See https://www.redeclipse.net/.
Motivation for this change
I like the game and think others will as well. I also wanted to learn how to package for Nix.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Can you play the demo maps offline? Doesn't want to load them for me.

Can you play the demo maps offline? Doesn't want to load them for me.

Demo maps are recordings of server of old races. I think they have to be setup on servers to actually use them. They are rarely (if ever) used, so I'm a bit fuzzy on the details. But for a first install there won't be any.

@jtojnar I've merged your requested changes, but the marker won't go away. Can you check that the changes are there and fix the marker status on your end?

tested with nix-review, starts, I can edit stuff and play


Meagan

Hi Meagan, The problem with this pull request is that your version of the website wasnt up to date with the master, so we need to merge your's with the master first in your repository, then make the pull request. This will mean that your branch will incorporate the changes that kate made before (blog.html and updated link).

Hello there!
So after two months of git hiatus I've come back. In the terminal I did: 'git merge master' and it has not failed. It says it is already up to date.

I've tried this without success:
git checkout -b meagan origin/meagan
git merge master```

```git checkout master
git merge --no-ff meagan
git push origin master```

so I'll push another version to my profile and then close this request? :persevere:

I will fix it if you like

merged and pulled.
I hope that worked out how it was supposed to.

It probably has. Thanks! :)

Meagan, can you please fix the blog button, link it to the blog.html, commit the change and push ?


Update dependency Microsoft.Extensions.Configuration to 5.0.0

Fixes #5751
Description
This updates Microsoft.Extensions.Configuration from version 2.1.0 to 5.0.0 for TargetFramework netcoreapp3.1.
For netcoreapp2.1, version 2.1.0 must be kept because later versions are not compatible.
Specific Changes

Testing

Pull Request Test Coverage Report for Build 265143

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 75.769%

Files with Coverage Reduction
New Missed Lines
%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs
1
90.91%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs
2
90.91%

Totals

Change from base Build 264914:
-0.01%

Covered Lines:
23136

Relevant Lines:
30535

💛  - Coveralls


Running 'pip install snmpsim' with python2.6 installs snmpsim for python3.5

Hi!
I'm having problems installing snmpsim with python2.6.6, when I was using pip 1.3 is worked perfectly since it fetched the egg files but now when I'm using a newer version of pip it tries to use the wheel file. I had a look at pypi https://pypi.python.org/pypi/snmpsim/0.3.0 and found that the Py Version states 3.5 when I think it should be py2.py3.
I think this is the same problem described here: http://stackoverflow.com/questions/30438216/how-do-i-upload-a-universal-python-wheel-for-python-2-and-3
Have a nice day!

I had a look at pypi https://pypi.python.org/pypi/snmpsim/0.3.0 and found that the Py Version
states 3.5 when I think it should be py2.py3.

So it looks to me that the file itself is named properly on PyPI - snmpsim-0.3.0-py2.py3-none-any.whl. The only confusing place is PyPI HTML page where (otherwise universal) wheel is marked as belonging to version 3.5. Do you think this causes problems?
I just checked -- I can't manually edit that version number at PyPI, I can only bump simulator version and push it as a new release.
The SO question you linked seems a bit different -- they had wheel file named differently.
How do I replicate the issue you experience? I'm running modern pip (versions 7 and 9) under Python 2.6 and installation works for me.
Please, advise. Thank you!

I installed snmpsim on centos6 with python 2.6.6 and pip 7.1.0 in a docker container.
I verified that I indeed got snmpsim-0.3.0-py2.py3-none-any.whl as you said, the problem for me seems to be the shebang in /usr/bin/snmpsimd.py where it says #!/usr/local/bin/python3.5. This becomes a problem for me when executing snmpsim via scripts.
Thanks for the quick response and also thank you for making snmpsim I think it is awesome!

I can confirm this also happens with python 2.7.5 on centos7 and pip 8.1.2 and 9.0.1.  My workaround is modifying that shebang you mentioned to the path of my python binary.  Seems to work okay after that.
Pretty simple replication: spin up a vagrant centos box and yum install python2 and pip and then attempt a pip install.  If you go into the file /usr/bin/snmpsimd.py, you'll see the shebang.

Alright, I think it's a weird packaging issue. If I do wheel prior to err, than the evil shebang expansion does not occur. Let's see if it works in the new release?


bug: resume preview section bottom padding is too large on mobiles

Description
As title.
To Reproduce

Go to landing page and open it in a mobile browser
Scroll to resume preview section

Actual Behavior

Expected Behavior
Bottom padding should be the same with top padding, for symmetry.
[Optional] Screenshots
NA
Additional Context
NA

Fixed:


policies

how to add policies, via the OS client?

Hi @CrewTech,
Which types policies do you need? Snapshot Management (SM)? Index State Management (ISM)? Security rules?

Hi @CrewTech,
Which types policies do you need? Snapshot Management (SM)? Index State Management (ISM)? Security rules?

Hi, ISM)

I'm trying via HttpClient, but I think it's a crutch

The .net client doesn't provide any API for ISM plugin, but it is possible to interact with it.
I successfully created a sample policy using following code:
var json = new
{
	policy = new
	{
		description = "Example rollover policy.",
		default_state = "rollover",
		states = new[]
		{ new
			{
				name = "rollover",
				actions = new []
				{ new
					{
						rollover = new
						{
							min_doc_count = 1
						}
					}
				},
				transitions = Array.Empty<object>()
			}
		},
		ism_template = new
		{
			index_patterns = new[] { "log*" },
			priority = 100
		}
	}
};
var res = client.LowLevel.DoRequest<StringResponse>(HttpMethod.PUT, "_plugins/_ism/policies/sample_policy", PostData.Serializable(json), null);

Hope this helps!

The .net client doesn't provide any API for ISM plugin, but it is possible to interact with it. I successfully created a sample policy using following code:
var json = new
{
	policy = new
	{
		description = "Example rollover policy.",
		default_state = "rollover",
		states = new[]
		{ new
			{
				name = "rollover",
				actions = new []
				{ new
					{
						rollover = new
						{
							min_doc_count = 1
						}
					}
				},
				transitions = Array.Empty<object>()
			}
		},
		ism_template = new
		{
			index_patterns = new[] { "log*" },
			priority = 100
		}
	}
};
var res = client.LowLevel.DoRequest<StringResponse>(HttpMethod.PUT, "_plugins/_ism/policies/sample_policy", PostData.Serializable(json), null);

Hope this helps!

you're the best, thank you!


Improve the Unit Test for conf package & HTTP Probe

Fix Unit Test failed on Windows platform - Windows platform seems to leave the removed files a while, which could sometimes cause the unit test to fail.

Add the UT for HTTP probe - test coverage to 100%

Codecov Report
Base: 99.33% // Head: 99.65% // Increases project coverage by +0.31% :tada:

Coverage data is based on head (4c0fa3f) compared to base (882a021).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   99.33%   99.65%   +0.31%
==========================================
  Files          48       47       -1
  Lines        4085     4071      -14
==========================================
- Hits         4058     4057       -1
+ Misses         16        8       -8
+ Partials       11        6       -5

Impacted Files
Coverage Δ

daemon/daemon_unix.go

daemon/daemon_windows.go

daemon/daemon_linux.go
100.00% <0.00%> (ø)

probe/http/http.go
100.00% <0.00%> (+3.41%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


How to get value

hey, how can i get all chips values

same question

got it！
<jaspero-chips (selectedChange)="selectItems($event)"></jaspero-chips>
selectItems(machineList) {
    console.log(machineList); // here u can find a array is output
  }

@xiehongyang, awesome 👍
Sorry you had to solve it on your own though.


Add PostgreSQL as an DB variant

Would be great if PostgreSQL will be DB variant.

What do you mean? You can change db type by environment variables like docker run -e DB_TYPE=psql -e DB_HOST=psql_host ket4yii/php-censor. Or just pass your own config by volume docker run -v ~/config.yml:/var/www/html/app/config.yml ket4yii/php-censor(but now, I think it doesn't work and this config will be rewrited by template).
There is type: $DB_TYPE in template for env substitution.

I mean docker-compose file with PostgreSQL as storage instead of MySQL/MariaDB.

Ok. And I'm gonna do phpcensors and workers in the different containers. It's good for scalability, but I'm not sure that it's necessary. What do you think? It would be better if code of worker would be independent of phpcensor code(I mean, web part), but unfortunately we've got a lot of legacy from PHPCI and now it's not possible:disappointed:.

I am not very strong in the docker, but I think that will be great if every process will have separate container. But it doesn't matter on the practice.
The docker-compose file that I liked:
https://github.com/nouchka/docker-phpci/blob/master/docker-compose.yml

@corpsee added.


SAST Integration with GitLab will stop working in GitLab 15.0 (2022-05-22)

Hey folks! Just wanted to give you a heads-up on an upcoming deprecation from GitLab.
GitLab SAST schemas below 14.0.0 have been deprecated.
Expected Behavior
pkg/report/model/gitlab_sast.go#L88 is using a deprecated version:

SchemaVersion:   "13.1.0",

The latest version of the schema is 14.1.0. There are other schemas available; any version from 14.0.0 is supported.
From GitLab 15.0 (2022-05-22), any reports submitted using an unsupported version will be rejected.

It might be worth noting that GitLab's kics analyzer does not use the glsast report format directly but uses our shared report library for handling conversion from the raw SARIF output.
So this deprecation will not affect our existing integration, only those using the --report-formats glsast directly

Thanks a lot for the heads up @theoretick!
We will upgrade our GitLab SAST output to be compliant with v14 ASAP.


Invalid Error Status/Messaged are returned from the Consent Management API

Description:
Moved from: https://github.com/wso2/carbon-consent-management/issues/56
Some of the API error responses contain mismatching information.
ex:
Internal server error when sent "string" instead "integer" for {purposeID} to GET /consents/purposes/{purposeID} endpoint
Bad request, when entry is not found for the provided {purposeID} to GET /consents/purposes/{purposeID} endpoint
Need to check all the other API resources for the correct error responses.

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


Configurable dimensions

Hi,
your project is a handy tool for standard metrics like pageload time, visits and so on. Some metrics however require different dimensions, for instance all ecommerce related metrics.
How about a configurable option to change "ga:pagePath" in the default config to something different?
https://developers.google.com/analytics/devguides/reporting/core/dimsmets#view=detail&group=ecommerce

Hi @nichdiekuh
ah cool, could you send a PR and I can test it out?
Best
Peter


[stable/phabricator] Add apache exporter

What this PR does / why we need it:
This PR adds an Apache exporter to be used with Prometheus.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Also, a new version appears, can you bump it again?

/ok-to-test
/lgtm


Class-C problem

im using chirpstack v.4.8.1
i created device profile and enabled class-c, end node join the this device profile.
i sended queue on chirpstack but i cant see any message on end node
My end node acting still Class A
DEBUG schedule{dev_eui=5e9d1e0857cf25c1 downlink_id=3279385687}: chirpstack::downlink::data: Device must send its first uplink first
im using RAK3172 and i activated class-c

DEBUG schedule{dev_eui=5e9d1e0857cf25c1 downlink_id=3279385687}: chirpstack::downlink::data: Device must send its first uplink first

That should explain your issue. The device must send its first uplink before Class-C will be activated.


fix: support dash in property names (Pydantic generator)

Description
This enables the generated models for Pydantic to work for properties with dashes in the name.
The generated code now puts descriptions in the "description" argument of the Pydantic Field decorator, and puts the original, unconstrained, property name in the "alias" field. This is correct usage as per the Pydantic documentation
Also, dashes are allowed through in property key constrainer, so that a property name like "content-type" is converted into "contentType" instead of "contentMinusType".
Related Issue
I believe this fixes https://github.com/asyncapi/modelina/issues/1058 but apparently that has been closed with a fix to an mostly unrelated problem.
Checklist

[x] The code follows the project's coding standards and is properly linted (npm run lint).
[x] Tests have been added or updated to cover the changes.
[x] Documentation has been updated to reflect the changes.
[x] All tests pass successfully locally.(npm run test).

Additional Notes
With these changes the generated Pydantic model class can correctly deserialise and serialise the JSON object described by the schema in the updated generate-python-pydantic-models test:
{
   "requiredField"<EMAIL_ADDRESS>   "noDescription": "test",
   "options": 123,
   "content-type": "application/json"
}

Without this change Pydantic would ignore the "content-type" field since it would not know to map that to the models contentType property.
Note that this is technically a breaking change, since before users could use the "description" field in the JSON schema to set the "alias" field on the Pydantic model. This would be a misuse of the description field, though, since it is to decorate a user interface with information about the data produced by this user interface.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

7 of 8 (87.5%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 92.3%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/generators/python/presets/Pydantic.ts
7
8
87.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
5995

Relevant Lines:
6326

💛  - Coveralls

/rtm

@all-contributors please add @ahem for code, test, bug


update composer.json links

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Tests pass?
❌

Fixed issues
https://github.com/yiisoft/yii2/issues/18761

👍🏻


Config: Expected VALUE to exist in the process context

What version of Effect is running?
3.6.1
What steps can reproduce the bug?
Open the reproduction
What is the expected behavior?
I want the value from the config to be resolved
What do you see instead?
(FiberFailure) Error: (Missing data at NEXT_PUBLIC_CONFIG_VALUE: "Expected NEXT_PUBLIC_CONFIG_VALUE to exist in the process context")
Additional information
Initially, I received this error implementing a Convex Function. However, process.env also worked fine there. So I decided to create a reproduction. Unfortunately, it doesn't work too.

You can't access environment variables in the browser dynamically
They are inlined by the engine only when accessed directly
Literally like this process.env.NEXT_PUBLIC_MY_VAR
https://nextjs.org/docs/pages/building-your-application/configuring/environment-variables#bundling-environment-variables-for-the-browser
However, you can create a ConfigProvider from the inlined values and provide it
'use client';

import { useEffect } from 'react';
import { Config, Effect, ConfigProvider } from 'effect';

const NextConfigProvider = ConfigProvider.fromMap(
  new Map([
    [
      //
      'NEXT_PUBLIC_CONFIG_VALUE',
      process.env.NEXT_PUBLIC_CONFIG_VALUE!,
    ],
  ])
);

export default function Home() {
  useEffect(() => {
    console.log('process.env', process.env.NEXT_PUBLIC_CONFIG_VALUE);
    const result = Effect.runSync(
      Config.string('NEXT_PUBLIC_CONFIG_VALUE').pipe(
        Effect.withConfigProvider(NextConfigProvider)
      )
    );
    console.log('effect', result);
  }, []);

  return <div>{process.env.NEXT_PUBLIC_CONFIG_VALUE}</div>;
}

You're right. Forgot about that. Sorry.
The only thing is that it doesn't work in Convex Runtime, which is not a browser. The worst part about that is that it would be hard to create an easily accessible reproduction.

For environments that require static access you'll need a custom provider and to list explicitely the env variables, nothing we can do. Would be good to open this issue in convex to see if there is a prefix like next that would automatically inline variables


No Guild Property under IMessage

No guild property means I'm unable to access the server that contains the channel the message was sent to without iterating through the servers my bot is in.

You will have to cast the message channel to a guild channel (i.e. IGuildChannel or SocketGuildChannel) and get the Guild property from there.


temporarily set overflow to hidden instead of auto

Description of Proposed Changes
As discussed in https://github.com/alexmacarthur/slide-element/issues/29 setting the overflow value to "auto" during the animation causes a scrollbar to appear for the duration of the animation which seems to be counter to this library's goal.
Related Issue (if applicable)
https://github.com/alexmacarthur/slide-element/issues/29
Testing Steps
Animate a large element with this library at a slow speed and you will see a scrollbar appear on the edge of the element as it animates. After applying this patch that scrollbar should no longer appear.

Alternatively, if you prefer, I could raise a PR to do as the issue requests and make the value configurable.

I like it. Thanks for doing this! I'll do a new npm release once I'm at a computer.

You're very welcome, thanks for the quick review!


Implement and Propagate new Persistence API

This is all of #4097 and #4124 merged together and rebased on master.
TODOS

[x] Address review comments from https://github.com/mesosphere/marathon/pull/4124
[x] Write generic XRepository test and replace all of the existing ones
[x] Finish generic XRepository test (and make sure the underlying stores have full coverage too)
[x] Finish GroupRepositoryTest
[x] Fix MarathonHealthCheckManagerTest
[x] Fix MarathonSchedulerActorTest
[x] Fix GroupManagerTest
[x] Migrate EventSubscribers Storage
[x] Migrate FrameworkId Storage
[x] Add Concurrency Limiting to legacy ZKStore.
[x] Expand test coverage a bit more.
[x] Split off things required from MarathonConf in StorageModule into StorageConf.
[x] Merge proto "StoredGroup" into GroupDefinition.
[x] Add a ton more documentation/cleanup to Migration.
[x] Utilize DeploymentPlan.createdOrUpdatedApps instead of calculating a delta in GroupManager
[x] Add root caching to StoredGroupRepository
[x] Wire up "PreDriverStart" for EntityStores and LoadTimeCachingStore.

Optimistic/Future TODOs (future PRs likely)

Implement Garbage Collection for StoredGroups.
Change ZkPersistenceStore's Category type so that we can have
single nodes (where there is exactly one object instead of multiple)
Simulated Benchmarks to stress the storage layer with tens of
thousands of apps.

Major changes

New Persistence API with support for ZK, Memory, and Two caching
modes.
Move all storage related "stuff" into marathon/core/storage
Default the storage backend to the new ZK API.
Lazy storage of Groups (new API only) where Apps are stored
separately.
Only GroupRepository is allowed write access to AppRepository
Completely unify the persistence API between new and old, keeping
a single, simplified chain of Repositories.
Make versioned repositories explicit.
Prepare for a future where typesafe config is used as opposed to a
million command line options (storage supports it now).
Refactor migration a bit to differentiate new API vs old API (needs a
bit more work)
Run repository tests against all of the backing stores.
(in some cases) remove mocks and prefer the in memory implementation
where it otherwise makes sense (not to simulate errors, etc).
Add ZookeeperServerTest that will spin up/down a zk server and provide
a client on a ephemeral port. This has the major advantage of bringing
us closer to being able to run tests in parallel.

Minor changes

run scalastyle for test in compile, not test.
add plugin to auto-resolve documentation links
remove lots of Guice Injections for Storage.
Use immutable.Seq across the persistence layer.
Use OffsetDateTime (java8 time) for versioning in the new API
as it is strictly better than timestamp.
Make some traits have companion objects so they can be imported
instead of mixed-in.
Add a generic Sink stage that can drain into any collection, then wrap
the Akka Sink API in a companion.
Add some tooling for enriched Locks.
Add scala friendly API around typesafe config.
Add RichFuture that adds "asTry" which makes a future always complete,
but with a try instead (very nice for async/await)
Fix some oversight issues with CapConcurrentExecutions.

I would like to remove the actor from this and make it a
functional transform instead.

Add a SettableClock (the java8 time Clock) that lets you control time
a bit easier for testing.

Remaining TODOs

[ ] Fix GroupRepositoryImpl to not store the group if storing the apps fails (broken by the root caching, needs an additional test case that verifies the underlying store.
[ ] Cleanup Migration more

[ ] Add "if storedVersion > currentVersion -> fail" and "if storedFormat is new and current format is legacy -> fail"
[ ] Reenable all the tests for old migrations
[ ] Tests for new migration.
[ ] ensure all old entries are deleted after migrating to new.

[ ] Fix broken test case (MarathonSchedulerActorTest) - I still don't quite understand what is happening with this one. It fails pretty unreliably and seems to be a race between persisted deployments and cancellation.

Benchmarks and GC are coming... I'll stack them as separate PRs.


Photofinish reads a .photofinish.toml file in the current working directory and:

It outputs the fixture sets in the TOML file;
It issues POST requests against the endpoint we give (default: http://localhost:8081/api/collect) with the content of the fixture files as request body.

I think the README summarizes pretty well what photofinish does.
The objective is to keep photofinish in this repository as we could integrate further features and keep it as a dev cli but no hard feelings, we can split the two things. There are some things missing like a subcommand to drop the current database and recreate it, and the code is really a POC full of unwraps, but I wanted to reach some point where we had something usable as quickly as possible.

We have discussed a bit about this on slack but basically I see 3 things:

Missing a bit of documentation on how to compile/run this using cargo (maybe adding a job in the Makefile?)
The sap_system_discovery_*.json files seem to be missing the wrapping with the agent_id and discovery_type which causes the sap system discovery POST to fail. I'll sent a PR to address this as it falls outside of the scope of this PR
I noticed that it will report Successfully POSTed always when it is able to find an endpoint listening, even when it's the wrong endpoint (e.g. an endpoint which falls outside of the collector engine)

Thanks for this, I think it's going to be quite useful :-)

Ah sorry about that, the .photofinish.toml file that we have right now was meant mainly to test photofinish itself, I thought we could add another .photofinish.toml at the root level of the repo that we could populate with the actual suites :sweat_smile: anyway you're right, we just have to decide if we're gonna stick with this file or put the definitive one at the root level

This is indeed super-cool!! 😎
I'm wondering if we should move this into a dedicated repo, though, as it doesn't really share a single line of code with the root project.

@stefanotorresi it's something I would evaluate, actually we talked about it with @fabriziosestito and I was pretty much convinced that it needed a separate repo, but we decided then to leverage our monorepo-like structure to host the tools we write for ourselves :smile:

Let's move this to https://github.com/trento-project/photofinish right away.


Log user & project context

We should have some way to log which project and user is generating each log message. As it is, they are all piled together in the logs and we can't tell who or what is causing problems.

This is being done on each data update now. We can make it so every single API request logs it's requester, their access group, and the request's project/region, if there is one for that request.

Great, thanks @trevorgerhardt. Yeah it might be best to do this for every API request, at least until things are more stable.

This has been a helpful improvement.
Would it also be worth logging the network name and id, e.g. here https://github.com/conveyal/analysis-backend/blob/dev/src/main/java/com/conveyal/taui/controllers/WorkerController.java#L124?

Addressed in recent release


Running ccapture.js headless?

Does anyone know how to run ccapture.js headless - without opening a browser window? I'd love to use this on a server, but there are limits on what can be done.
If someone could shed some experience or light on this - much appreciated!

I haven't tried anything of the sort. Technically ccapture takes a canvas, so as long as you can produce one -or equivalent-, you should be good. For 2d canvas ,there's a few node modules, and for 3d, i've heard good things about headless-gl. If you can check those out for your case and report the results, I'm open to modify whatever is needed to get it working!

Did anyone managed to run it headless?
I tried to run it with phantom.js but I have issues when capturing frames :

my socket to ffmpegserver.js is disconnected at the very beginning
if I use png + tar, Tar.append fails with an empty input

If you can set up a repo with an example using phantom.js, i will take a look. Thanks!

Thanks, preparing it right now!

Here it is: https://github.com/cblavier/ccapture_headless

For anyone trying to use headless chrome with this project, note that currently headless chrome doesn't support file downloads (issue).

@fisch0920 I guess that's for the new chrome headless, not for phantom.js? does the rest work on chrome headless?

@spite yes, this is related to the newer chrome headless, not phantom.js.  Note that the rest works fine on chrome headless as far as I can tell, you just need to do some extra work to transfer the captured results to your server for processing as opposed to downloading it directly.  I'm using websockets to accomplish this.

Also @spite, I've generally loved using this project -- thank you so much for your excellent work!!


don't replace detector user when update

Signed-off-by: Yaliang Wu<EMAIL_ADDRESS>Description
In current implementation, when user update detector,  we will replace detector user as current user. In some cases, it may cause detector creator lose access of detector. Check more details in #124
Based on discussion with @skkosuri-amzn and PM, we plan to fix this issue quickly by blocking replacing detector user when update. User can't update detector user after creation.
Issues Resolved
https://github.com/opensearch-project/anomaly-detection/issues/124
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #126 (8e1f208) into main (ea22d59) will increase coverage by 0.29%.
The diff coverage is 60.00%.

:exclamation: Current head 8e1f208 differs from pull request most recent head 1da4bef. Consider uploading reports for the commit 1da4bef to get more accurate results

@@             Coverage Diff              @@
##               main     #126      +/-   ##
============================================
+ Coverage     75.97%   76.27%   +0.29%
- Complexity     2886     2892       +6
============================================
  Files           264      264
  Lines         12435    12431       -4
  Branches       1222     1221       -1
============================================
+ Hits           9448     9482      +34
+ Misses         2478     2428      -50
- Partials        509      521      +12

Flag
Coverage Δ

plugin
76.27% <60.00%> (+0.29%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...transport/IndexAnomalyDetectorTransportAction.java
72.46% <36.36%> (-1.83%)
:arrow_down:

...c/main/java/org/opensearch/ad/util/ParseUtils.java
63.71% <70.00%> (+9.96%)
:arrow_up:

...d/transport/AnomalyDetectorJobTransportAction.java
88.57% <100.00%> (ø)

...ransport/DeleteAnomalyDetectorTransportAction.java
48.91% <100.00%> (ø)

...d/transport/GetAnomalyDetectorTransportAction.java
57.55% <100.00%> (ø)

...ansport/PreviewAnomalyDetectorTransportAction.java
82.66% <100.00%> (ø)

src/main/java/org/opensearch/ad/model/ADTask.java
95.31% <0.00%> (-2.82%)
:arrow_down:

...java/org/opensearch/ad/task/ADBatchTaskRunner.java
87.82% <0.00%> (-0.87%)
:arrow_down:

...ain/java/org/opensearch/ad/task/ADTaskManager.java
72.99% <0.00%> (-0.23%)
:arrow_down:

... and 4 more


[delay] delaying a character too early when autotype is at certain speed

I seem to be the bringer of bad news again, and it's always about pausing the autotyper!
Using the string "abcdefg[delay]hijklmnop", the following happens:

As you can see, the delay happens one character too early. I'm using scribble v6.0.11 and GMS <IP_ADDRESS>9.
This only happens at certain autotype speeds, using the command scribble_autotype_fade_in(content, <speed>, 0, false), I gathered the following:

speed
character delay offset

0.1
0

0.2
-1

0.24
-1

0.25
0

0.26
-1

0.3
-1

0.34
-1

0.35
0

0.36
-1

0.4
-1

0.44
-1

0.45
-1

0.46
-1

0.5
0

0.75
-1

0.9
- 1

0.99
-1

1
0

2
0

I tried this on the master branch "dialogue" demo @ b1312ea376f9cf5583172af40e2d201be3103961 and delay seems to break in the same way when changing the speed on line 38 in obj_example_dialogue. Seems to be some kind of rounding thing? I'm not sure.
EDIT: To complicate everything, the input string seems to have an effect, too. I tested with "This is cu[delay]rious!" at speed 0.35 where it delayed too early, while on speed 0.25 it didn't. With the string "abcdefg[delay]hijklmnop" it delayed correctly on both speeds.

Known issue. Use a speed of 1 for now

Fixed for v6.0.13


The symbol shown in the accordion header is not correct

In the accordion header it shows the vaultSymbol (also know as the yToken) but it should show the token symbol. I've uploaded a PR to fix it: #82

Fixed in #82


Error with undefined type in target.type of formik.esm.js

🐛 Bug report
Current Behavior
Formik passes Object key/value to eventOrTextValue
Expected behavior
Should be passing DOM element?
Reproducible example
const RegionAddForm = props => {
        const {
                values,
                touched,
                data,
                errors,
                // handleChange,
                handleBlur,
                handleSubmit
        } = props;

        const ValidationSchema = Yup.object().shape(
            {
                name: Yup.string().required("Required"),
                lang: Yup.string().oneOf(
                    LanguageOptions
                ).required('Please select a language'),
                locale: Yup.string().required("Required")

            }
        );

        const handleChange = (e) => {
            console.log(e);
        }

        return (
            <Formik
                initialValues={
                    {
                        name: '',
                        description: ''
                    }
                }
                validationSchema={ ValidationSchema }
                onSubmit={ async (values, actions) => {
                        console.log("HELP ME");
                        await new Promise(r => setTimeout(r, 500));
                        actions.setSubmitting(false);
                        alert(JSON.stringify(values, null, 2));
                    }
                }
            >
                { props => (
                    <Form className="form-horizontal" onSubmit={props.handleSubmit}>
                            <Row>
                                <TextInput
                                    sz="1"
                                    label="Region Name"
                                    name="name"
                                    placeholder="Region Name"
                                    onChange={props.handleChange}
                                />
                            </Row>
                            <Row>
                                    <Col sm="12"> </Col>
                            </Row>
                            <Row>
                                <NewSelect
                                    size="2"
                                    label="Language"
                                    name="lang"
                                    placeholder="Select Language"
                                    options={LanguageOptions}
                                    meta={props.meta}
                                    {...props}
                                />

                                <NewSelect
                                    size="2"
                                    label="Locale"
                                    name="locale"
                                    placeholder="Select Locale"
                                    options={LocaleOptions}
                                    // options={[{id: 123, name: "balls"}, {id: 124, name: "other balls"}]}
                                />
                            </Row>

                            <Row>
                                <Col sm="12"> </Col>
                            </Row>

                            <Row>
                                <TextAreaInput
                                    sz="1"
                                    label="Description"
                                    name="description"
                                    value={values.description}
                                />
                            </Row>

                            <Row>
                                <SubmitCancelButtonInput
                                    sz="1"
                                    label="Add Region"
                                />
                            </Row>
                    </Form>
                )}
        </Formik>
    )
};

export const NewSelect = ({name, label, ...rest}) => (
    <>

            {label}

        <Field
            name={name}
            render={({field, form}) => {

                const handleChange = (value) => form.setFieldValue(name, value);
                const handleBlur   = () => form.setFieldTouched(name, true);
                const { onChange, onBlur, ...restField } = field;

                return (
                        <Select
                            id={name}
                            name={name}
                            className="react-select primary"
                            classNamePrefix="react-select"
                            onChange={onChange}
                            onBlur={handleBlur}
                            {...field}
                            {...rest}
                        />
                )
            }}
        />

    </>
);

Suggested solution(s)
Unsure
Additional context
Using react-select
Your environment

Software
Version(s)

Formik
2.1.5

React
16.13.1

TypeScript
3.9.5

Browser
chrome 84.0.4147.105 (Official Build) (64-bit)

npm/Yarn
YARN 1.13.0

Operating System
Windows 10 64bit - 2004 - build 19041.388

This occurs at this line:
      var target = eventOrTextValue.target ? eventOrTextValue.target : eventOrTextValue.currentTarget;
      var type = target.type,  <----
          name = target.name,
          id = target.id,
          value = target.value,
          checked = target.checked,
          outerHTML = target.outerHTML,
          options = target.options,
          multiple = target.multiple;
      field = maybePath ? maybePath : name ? name : id;

Doing a breakpoint on there, I can see that eventOrTextValue is equal to:
eventOrTextValue: {
    label: "Falkan Islands",
    value: "FA"
}

React Select doesn't return a DOM element to its onChange callback. Because the underlying component is not a native select element, a change event can't possibly exist. Above, you try to override onChange, but then you re-override it by passing all the props to Select at the end.
Below, I altered handleChange to use the SelectOption returned by React Select and passed that handler to onChange, removing onChange and onBlur from the ...restOfTheProps. Note that due to the ...rest, one may still pass onChange or onBlur to your NewSelect component, overriding this functionality entirely.
                // note that React Select returns the SelectOption on change, and not a value nor an event
                const handleChange = (option) => form.setFieldValue(name, option.value);
                const handleBlur   = () => form.setFieldTouched(name, true);
                const { onChange, onBlur, ...restField } = field;

                return (
                        <Select
                            id={name}
                            name={name}
                            className="react-select primary"
                            classNamePrefix="react-select"
                            onChange={handleChange} // should be handleChange
                            onBlur={handleBlur}
                            {...restField} // use restField because it doesn't include onChange nor onBlur
                            {...rest} // depending on what is passed here, you may override any of the props above
                        />
                )

Additional notes:

You may want to use Formik's handleChange and handleBlur, instead of setFieldValue and setFieldBlur, like
: handleChange(name, option.value).
You may want to wrap NewSelectFormProps.onChange with this functionality depending on whether you are using it.
TypeScript would make all these problems very obvious, though it comes with its own headaches.


Integration test for Kiali

This item is to create an integration test so that we know if there are incompatibilities between the version of Kiali that we ship.
For Istio 1.3 we had "last minute report about kiali not working: no release coordination with kiali except for community testing.   Was classified as P2 so no one picked it up.  No automated testing to cover it.  Solutions 1) be kiali agnostic, 2) incorporate kiali community in Istio community testing."
This is about a 3rd option, an integration test that queries Kiali rest API to verify that it is receiving telemetry from Istio.

We used to have an integration test that @gbaufake wrote a while ago. Not sure if that test somehow went away. But also, as I understand it, one problem wasn't that kiali wasn't starting or replying to requests; rather, it was because kubectl dashboard kiali was somehow creating a proxy that only forwarded or allowed http traffic (and because kiali by default was using https server-side, it was rejecting http requests). So that kind of issue we would need to figure out how to test as well.

@jmazzitelli
It still there on https://github.com/istio/istio/blob/master/tests/e2e/tests/kiali/kiali_test.go

The test is pretty basic, it just checks that kiali doesn't crash

@howardjohn
Right.
At the time, it was submitted we introduced a basic test cover the kiali pod creation by helm charts.

CC: @lucasponce

@esnible @howardjohn I've created an action in Kiali to not miss this one.
Definetely we may want to enrich the integration tests, with the backend API we can check a major set of features.
I don't know if Istio has some support for UI support, but I guess we can rely on Kiali Integration tests for the UI.
One action that probably would help if how we could automate that when there is some problem on this area we can create some notification that we can track and triage.
I mean, if I review https://github.com/istio/istio/commits/master all commits have failures in the CI, and that creates some distraction about "what CI is the important to look at" and probably we missed something.
So I wonder if there is some action we can add, to receive a notification when some of this CIs fails related a Kiali failure to put someone to look into.
Thanks

@lucasponce notifications of all postsubmit test failures are sent to the google group istio-oncall. This produces a lot of emails every day so I doubt many subscribe to this, but I actually look at every failure. This is an area we have been working on a lot -- if you look at PRs youll notice many are actually passing all tests -- a few months ago this literally never happened.
My point is, if there is a Kiali test and it starts failing it will be noticed

@jmazzitelli Is there an issue for the problem with istioctl dashboard kiali?
The command just does a port-forward to :20001, and then opens the browser to that address prefixed with http:.  I could see it failing if Kiali is serving HTTPS on 20001.

then opens the browser to that address prefixed with http:

That would be the problem then - it should have been opening it to use https.  But I think the helm chart has been changed to now start Kiali unsecured, so I am not sure if there is anything to do now. See the istio 1.3 branch - here you see the helm chart now installs Kiali without https: https://github.com/istio/istio/blob/release-1.3/install/kubernetes/helm/istio/charts/kiali/values.yaml#L61

Kiali has some molecule tests - requires access to a cluster with Istio installed. These exercise the operator but could be used for testing kiali itself. We could share these or reuse them in Istio somehow. See: https://github.com/kiali/kiali/tree/master/operator/molecule
I have not looked at the Istio testing framework to see how we could plug into it. I assume the test framework just starts up an Istio cluster and tests are run against it - so those molecule tests could be run with against the Istio started by this framework.

@jmazzitelli I wrote an integration test verifying istioctl can talk to Prometheus earlier this week.  Your tests could be structured similarly.
https://github.com/istio/istio/pull/17528
The Istio test framework is easy to use.  Write a function named Test... with RequiresEnvironment(environment.Kube).  The Run() method will be invoked only after an Istio cluster has been started.
func TestIstioctlMetrics(t *testing.T) {
 	framework.
 		NewTest(t).
 		RequiresEnvironment(environment.Kube).
...


Segmentation fault (core dumped) error when fine tuning wav2vec 2.0.

I'm trying to fine tune a pre-trained wav2vec 2.0 base model (no finetuning) on ~1h of data, with the following command:
python3 fairseq/train.py --distributed-world-size 1
"path/to/data"
--save-dir "path/to/checkpoint"
--fp16
--wer-args  '("/path/lm_librispeech_kenlm_word_4g_200kvocab.bin","/path/librispeech_lexicon.lst.txt",2,-1)'
--post-process letter
--valid-subset valid
--no-epoch-checkpoints
--best-checkpoint-metric wer
--num-workers 1
--max-update 13000
--sentence-avg
--task audio_pretraining
--arch wav2vec_ctc
--w2v-path '/path/wav2vec_small.pt'
--labels ltr
--apply-mask
--mask-selection static
--mask-other 0
--mask-length 10
--mask-prob 0.75
--layerdrop 0.05
--mask-channel-selection static
--mask-channel-other 0
--mask-channel-length 64
--mask-channel-prob 0.5
--zero-infinity
--feature-grad-mult 0.0
--freeze-finetune-updates 10000
--validate-after-updates 10000
--optimizer adam
--adam-betas '(0.9, 0.98)'
--adam-eps 1e-08
--lr 2e-05
--lr-scheduler tri_stage
--warmup-steps 1000
--hold-steps 5000
--decay-steps 8000
--final-lr-scale 0.05
--final-dropout 0.0
--dropout 0.0
--activation-dropout 0.1
--criterion ctc
--attention-dropout 0.0
--max-tokens 3840000
--seed 2337
--log-format json
--log-interval 500
--ddp-backend no_c10d
--update-freq 8
However , I'm recieving a segmentation fault error.
What could be the reason?
( Omiting the wer-args - performs as expected.
Performig the same , with a model trained on my language and my ngram language model,
resulted in the same error.)

Hi @SvPolina , I am also facing similar issue. Segmentation fault originates from the init method of KenLMdecoder class in w2ldecoder.py when operations on LM start's in memory. There were no issues till the loading part of LM.
I am still trying to find out the reason as it give similar error in the Librispeech arpa file too. If you find solution or any workaround do post it.

Thanks for reporting the issue. Can I know the version of PyTorch you are using?

I am using latest version of pytorch i.e 1.7.0

1.6.0

Hi @amant555, didn't solve the issue yet with the LM loading, but wanted to ask you another question.
I know that you are training on your language, and tried to fine-tune without the LM.
How was the success with it? in terms of wer/uer?

Hi @amant555, didn't solve the issue yet with the LM loading, but wanted to ask you another question.
I know that you are training on your language, and tried to fine-tune without the LM.
How was the success with it? in terms of wer/uer?

Hi @SvPolina, I was able to fine-tune my model and got decrease in my WER, CER and UER. I am working on different languages apart from English, so these results will be different from paper.
I have achieved:
WER 10-30
CER 5-6
UER 8-14
P.S
I am not so sure about UER as I peaked at it for few epochs only.

Hi @amant555, didn't solve the issue yet with the LM loading, but wanted to ask you another question.
I know that you are training on your language, and tried to fine-tune without the LM.
How was the success with it? in terms of wer/uer?

Hi @SvPolina, I was able to fine-tune my model and got decrease in my WER, CER and UER. I am working on different languages apart from English, so these results will be different from paper.
I have achieved:
WER 10-30
CER 5-6
UER 8-14
P.S
I am not so sure about UER as I peaked at it for few epochs only.

Thanks for replying,I'm also working on a non English alphabet. Would you mind sharing some guidance regarding the parameters you used? I'm trying with the original parameters , but observe only a slight decrease in UER (~95  ) while the WER remains 100.

CER 5-6

Hi @amant555, didn't solve the issue yet with the LM loading, but wanted to ask you another question.
I know that you are training on your language, and tried to fine-tune without the LM.
How was the success with it? in terms of wer/uer?

Hi @SvPolina, I was able to fine-tune my model and got decrease in my WER, CER and UER. I am working on different languages apart from English, so these results will be different from paper.
I have achieved:
WER 10-30
CER 5-6
UER 8-14
P.S
I am not so sure about UER as I peaked at it for few epochs only.

Thanks for replying,I'm also working on a non English alphabet. Would you mind sharing some guidance regarding the parameters you used? I'm trying with the original parameters , but observe only a slight decrease in UER (~95 ) while the WER remains 100.

Also,  what is the size of the data set you're training on? (train/fine-tune)

Hello @amant555 ,

I am still trying to find out the reason as it give similar error in the Librispeech arpa file too. If you find solution or any workaround do post it.

I was experiencing a similar issue; building wav2letter bindings with an older kenlm revision (I took rev e47088ddfae810a5ee4c8a9923b5f8071bed1ae8 but maybe there is no need to go that far) did the trick for me. Could you try that?

Hi @amant555, didn't solve the issue yet with the LM loading, but wanted to ask you another question.
I know that you are training on your language, and tried to fine-tune without the LM.
How was the success with it? in terms of wer/uer?

Hi @SvPolina, I was able to fine-tune my model and got decrease in my WER, CER and UER. I am working on different languages apart from English, so these results will be different from paper.
I have achieved:
WER 10-30
CER 5-6
UER 8-14
P.S
I am not so sure about UER as I peaked at it for few epochs only.

Thanks for replying,I'm also working on a non English alphabet. Would you mind sharing some guidance regarding the parameters you used? I'm trying with the original parameters , but observe only a slight decrease in UER (~95 ) while the WER remains 100. Also, what is the size of the data set you're training on? (pre-train/fine-tune)

I am training on 4200 hrs and fine-tuned on 100 hrs. 4200 hrs contains data of multiple languages.
Can you share the exact command used to fine-tune and num_updates/updates on which you got your last WER?

Hi @amant555, didn't solve the issue yet with the LM loading, but wanted to ask you another question.
I know that you are training on your language, and tried to fine-tune without the LM.
How was the success with it? in terms of wer/uer?

Hi @SvPolina, I was able to fine-tune my model and got decrease in my WER, CER and UER. I am working on different languages apart from English, so these results will be different from paper.
I have achieved:
WER 10-30
CER 5-6
UER 8-14
P.S
I am not so sure about UER as I peaked at it for few epochs only.

Thanks for replying,I'm also working on a non English alphabet. Would you mind sharing some guidance regarding the parameters you used? I'm trying with the original parameters , but observe only a slight decrease in UER (~95 ) while the WER remains 100. Also, what is the size of the data set you're training on? (pre-train/fine-tune)

I am training on 4200 hrs and fine-tuned on 100 hrs.
Can you share the exact command used to fine-tune and num_updates/updates on which you got your last WER?

Hi,
Here is the comand I'm using.
Practicaly,  everything is in accoradance with the guidance for 10h of fine-tuning.
train.py --distributed-world-size 2  '/path/data'
--save-dir "/path/save_dir"
--fp16
--post-process letter
--valid-subset valid
--no-epoch-checkpoints
--best-checkpoint-metric wer
--num-workers 4
--max-update 15000
--sentence-avg
--task audio_pretraining
--arch wav2vec_ctc
--w2v-path "/path/checkpoint.pt"
--labels ltr
--apply-mask
--mask-selection static
--mask-other 0
--mask-length 10
--mask-prob 0.65
--layerdrop 0.1
--mask-channel-selection static
--mask-channel-other 0
--mask-channel-length 64
--mask-channel-prob 0.256
--zero-infinity
--feature-grad-mult 0.0
--freeze-finetune-updates 0
--validate-after-updates 8000
--optimizer adam
--adam-betas '(0.9, 0.98)'
--adam-eps 1e-08
--lr 2e-05
--lr-scheduler tri_stage
--warmup-steps 1500
--hold-steps 6000
--decay-steps 7000
--final-lr-scale 0.05
--final-dropout 0.0
--dropout 0.0
--activation-dropout 0.1
--criterion ctc
--attention-dropout 0.0
--max-tokens 3840000
--seed 2337
--log-format json
--log-interval 500
--ddp-backend no_c10d
--update-freq 4

Command that you have used seems correct, I hope that your pre-training had converged before starting fine-tuning and files used in fine-tuning are in correct format. You can try to add more data in fine-tuning as there is a chance that 10 hrs might not be enough.
I don't know if this help but there was a similar scenario in which with 10 hr in fine-tuning, models wer stayed at 100 wer for around 30 epochs before comming down, it can be different depending on language you're fine-tuning.

Command that you have used seems correct, I hope that your pre-training had converged before starting fine-tuning and files used in fine-tuning are in correct format. You can try to add more data in fine-tuning as there is a chance that 10 hrs might not be enough.
I don't know if this help but there was a similar scenario in which with 10 hr in fine-tuning, models wer stayed at 100 wer for around 30 epochs before comming down, it can be different depending on language you're fine-tuning.

Thanks @amant555 , I'll try it out.

Command that you have used seems correct, I hope that your pre-training had converged before starting fine-tuning and files used in fine-tuning are in correct format. You can try to add more data in fine-tuning as there is a chance that 10 hrs might not be enough.
I don't know if this help but there was a similar scenario in which with 10 hr in fine-tuning, models wer stayed at 100 wer for around 30 epochs before comming down, it can be different depending on language you're fine-tuning.

Thanks @amant555 , I'll try it out.

Hi @amant555,  the fine-tuning seems to converge (WER: 20-30, UER: ~10, had to specify some additional flags ), but now I'm having trouble  running an inference with the checkpoints from the fine-tuning , getting  "RecursionError: maximum recursion depth exceeded", (originates at the build_model method from fairseq_task.py, fails on model.build_model() ) , is there a chance you've had a similar issue? using the English fine-tuned model works just fine.

@SvPolina  hi, can you share your solution, i'm pretraining and finetuning in chinese dataset and meet the same question. thank you.

@SvPolina hi, can you share your solution, i'm pretraining and finetuning in chinese dataset and meet the same question. thank you.

Hi @jiangtaojy ,
You can't fine-tune with language model or you're facing a problem even when fine-tuning without language model?

@SvPolina hi, can you share your solution, i'm pretraining and finetuning in chinese dataset and meet the same question. thank you.

Hi @jiangtaojy ,
You can't fine-tune with language model or you're facing a problem even when fine-tuning without language model?

@SvPolina  Without language model. When fine-tuning , the loss is decreasing but the wer value is always 100.

@SvPolina hi, can you share your solution, i'm pretraining and finetuning in chinese dataset and meet the same question. thank you.

Hi @jiangtaojy ,
You can't fine-tune with language model or you're facing a problem even when fine-tuning without language model?

@SvPolina Without language model. When fine-tuning , the loss is decreasing but the wer value is always 100.

try this:
python3 train.py --distributed-world-size 2  \ (depends on your GPU num.)
'/path/to/manifest/'
--save-dir "/save/dir/"
--fp16
--post-process letter
--valid-subset valid
--no-epoch-checkpoints
--best-checkpoint-metric wer
--num-workers 0
--max-update  15000
--sentence-avg
--task audio_pretraining
--arch wav2vec_ctc
--w2v-path "/path/to/checkpoint/from/training/checkpoint_last.pt"
--labels ltr
--reset-meters
--reset-optimizer
--reset-lr-scheduler
--apply-mask
--mask-selection static
--mask-other 0
--mask-length 10
--mask-prob 0.65
--layerdrop 0.1
--mask-channel-selection static
--mask-channel-other 0
--mask-channel-length 64
--mask-channel-prob 0.256
--zero-infinity
--feature-grad-mult 0.0
--freeze-finetune-updates 0
--validate-after-updates 8000
--optimizer adam
--adam-betas '(0.9, 0.98)'
--adam-eps 1e-08
--lr 2e-05
--lr-scheduler tri_stage
--warmup-steps 1000
--hold-steps 9000
--decay-steps 5000
--final-lr-scale 0.05
--final-dropout 0.0
--dropout 0.0
--activation-dropout 0.1
--criterion ctc
--attention-dropout 0.0
--max-tokens 3840000
--seed 2337
--log-format json
--log-interval 500
--ddp-backend no_c10d
--update-freq 4
--restore-file "/path/to/checkpoint/from/training/checkpoint_last.pt"

thank you, i'll have a try. can you explain which hyperparameter has the impact on the wer value?

@SvPolina hi, can you share your solution, i'm pretraining and finetuning in chinese dataset and meet the same question. thank you.

Hi @jiangtaojy ,
You can't fine-tune with language model or you're facing a problem even when fine-tuning without language model?

@SvPolina Without language model. When fine-tuning , the loss is decreasing but the wer value is always 100.

try this:
python3 train.py --distributed-world-size 2 \ (depends on your GPU num.)
'/path/to/manifest/'
--save-dir "/save/dir/"
--fp16
--post-process letter
--valid-subset valid
--no-epoch-checkpoints
--best-checkpoint-metric wer
--num-workers 0
--max-update 15000
--sentence-avg
--task audio_pretraining
--arch wav2vec_ctc
--w2v-path "/path/to/checkpoint/from/training/checkpoint_last.pt"
--labels ltr
--reset-meters
--reset-optimizer
--reset-lr-scheduler
--apply-mask
--mask-selection static
--mask-other 0
--mask-length 10
--mask-prob 0.65
--layerdrop 0.1
--mask-channel-selection static
--mask-channel-other 0
--mask-channel-length 64
--mask-channel-prob 0.256
--zero-infinity
--feature-grad-mult 0.0
--freeze-finetune-updates 0
--validate-after-updates 8000
--optimizer adam
--adam-betas '(0.9, 0.98)'
--adam-eps 1e-08
--lr 2e-05
--lr-scheduler tri_stage
--warmup-steps 1000
--hold-steps 9000
--decay-steps 5000
--final-lr-scale 0.05
--final-dropout 0.0
--dropout 0.0
--activation-dropout 0.1
--criterion ctc
--attention-dropout 0.0
--max-tokens 3840000
--seed 2337
--log-format json
--log-interval 500
--ddp-backend no_c10d
--update-freq 4
--restore-file "/path/to/checkpoint/from/training/checkpoint_last.pt"

@SvPolina  thank you, i'll have a try. can you explain which hyperparameter has the impact on the wer value?

@SvPolina hi, can you share your solution, i'm pretraining and finetuning in chinese dataset and meet the same question. thank you.

Hi @jiangtaojy ,
You can't fine-tune with language model or you're facing a problem even when fine-tuning without language model?

@SvPolina Without language model. When fine-tuning , the loss is decreasing but the wer value is always 100.

try this:
python3 train.py --distributed-world-size 2 \ (depends on your GPU num.)
'/path/to/manifest/'
--save-dir "/save/dir/"
--fp16
--post-process letter
--valid-subset valid
--no-epoch-checkpoints
--best-checkpoint-metric wer
--num-workers 0
--max-update 15000
--sentence-avg
--task audio_pretraining
--arch wav2vec_ctc
--w2v-path "/path/to/checkpoint/from/training/checkpoint_last.pt"
--labels ltr
--reset-meters
--reset-optimizer
--reset-lr-scheduler
--apply-mask
--mask-selection static
--mask-other 0
--mask-length 10
--mask-prob 0.65
--layerdrop 0.1
--mask-channel-selection static
--mask-channel-other 0
--mask-channel-length 64
--mask-channel-prob 0.256
--zero-infinity
--feature-grad-mult 0.0
--freeze-finetune-updates 0
--validate-after-updates 8000
--optimizer adam
--adam-betas '(0.9, 0.98)'
--adam-eps 1e-08
--lr 2e-05
--lr-scheduler tri_stage
--warmup-steps 1000
--hold-steps 9000
--decay-steps 5000
--final-lr-scale 0.05
--final-dropout 0.0
--dropout 0.0
--activation-dropout 0.1
--criterion ctc
--attention-dropout 0.0
--max-tokens 3840000
--seed 2337
--log-format json
--log-interval 500
--ddp-backend no_c10d
--update-freq 4
--restore-file "/path/to/checkpoint/from/training/checkpoint_last.pt"

@SvPolina thank you, i'll have a try. can you explain which hyperparameter has the impact on the wer value?

@jiangtaojy , for me, eventually the issue was the appropriate specification of the used checkpoint, so ( --restore-file , I know that --finetune-from-model can also be used) solved the problem.

Hey did anybody able to rectify segmentation  fault error yet?

Hey anybody able to rectify segmentation fault error yet?

Hi @amant555 ,
I've succeded to make a fine-tuning with the language model.

I didn't use the lm from :
https://dl.fbaipublicfiles.com/wav2letter/lexicon_free/librispeech/models/lm/lm_librispeech_kenlm_word_4g_200kvocab.bin

I've created my own :
https://deepspeech.readthedocs.io/en/v0.8.2/Scorer.html

For kenlm installation don't use:

-DCMAKE_BUILD_TYPE=Release -DKENLM_MAX_ORDER=20

Hey anybody able to rectify segmentation fault error yet?

Hi @amant555 ,
I've succeded to make a fine-tuning with the language model.

I didn't use the lm from :
https://dl.fbaipublicfiles.com/wav2letter/lexicon_free/librispeech/models/lm/lm_librispeech_kenlm_word_4g_200kvocab.bin

I've created my own :
https://deepspeech.readthedocs.io/en/v0.8.2/Scorer.html

For kenlm installation don't use:

-DCMAKE_BUILD_TYPE=Release -DKENLM_MAX_ORDER=20

That worked, thanks a lot @SvPolina .
I think you can close this issue now.

Hey anybody able to rectify segmentation fault error yet?

Hi @amant555 ,
I've succeded to make a fine-tuning with the language model.

I didn't use the lm from :
https://dl.fbaipublicfiles.com/wav2letter/lexicon_free/librispeech/models/lm/lm_librispeech_kenlm_word_4g_200kvocab.bin

I've created my own :
https://deepspeech.readthedocs.io/en/v0.8.2/Scorer.html

For kenlm installation don't use:

-DCMAKE_BUILD_TYPE=Release -DKENLM_MAX_ORDER=20

@SvPolina  I tried, but it seems did not work. the loss in train dataset is very low, but in test dataset is still high. I used my own dataset, and the preprocess in two datasets is same, can you help me?

@SvPolina hi, can you share your solution, i'm pretraining and finetuning in chinese dataset and meet the same question. thank you.

Hi @jiangtaojy ,
You can't fine-tune with language model or you're facing a problem even when fine-tuning without language model?

@SvPolina Without language model. When fine-tuning , the loss is decreasing but the wer value is always 100.

try this:
python3 train.py --distributed-world-size 2 \ (depends on your GPU num.)
'/path/to/manifest/'
--save-dir "/save/dir/"
--fp16
--post-process letter
--valid-subset valid
--no-epoch-checkpoints
--best-checkpoint-metric wer
--num-workers 0
--max-update 15000
--sentence-avg
--task audio_pretraining
--arch wav2vec_ctc
--w2v-path "/path/to/checkpoint/from/training/checkpoint_last.pt"
--labels ltr
--reset-meters
--reset-optimizer
--reset-lr-scheduler
--apply-mask
--mask-selection static
--mask-other 0
--mask-length 10
--mask-prob 0.65
--layerdrop 0.1
--mask-channel-selection static
--mask-channel-other 0
--mask-channel-length 64
--mask-channel-prob 0.256
--zero-infinity
--feature-grad-mult 0.0
--freeze-finetune-updates 0
--validate-after-updates 8000
--optimizer adam
--adam-betas '(0.9, 0.98)'
--adam-eps 1e-08
--lr 2e-05
--lr-scheduler tri_stage
--warmup-steps 1000
--hold-steps 9000
--decay-steps 5000
--final-lr-scale 0.05
--final-dropout 0.0
--dropout 0.0
--activation-dropout 0.1
--criterion ctc
--attention-dropout 0.0
--max-tokens 3840000
--seed 2337
--log-format json
--log-interval 500
--ddp-backend no_c10d
--update-freq 4
--restore-file "/path/to/checkpoint/from/training/checkpoint_last.pt"

@SvPolina thank you, i'll have a try. can you explain which hyperparameter has the impact on the wer value?

@jiangtaojy , for me, eventually the issue was the appropriate specification of the used checkpoint, so ( --restore-file , I know that --finetune-from-model can also be used) solved the problem.

@SvPolina I tried, but it seems did not work. the loss in train dataset is very low, but in test dataset is still high. I used my own dataset, and the preprocess in two datasets is same, can you help me?

@SvPolina hi, can you share your solution, i'm pretraining and finetuning in chinese dataset and meet the same question. thank you.

Hi @jiangtaojy ,
You can't fine-tune with language model or you're facing a problem even when fine-tuning without language model?

@SvPolina Without language model. When fine-tuning , the loss is decreasing but the wer value is always 100.

try this:
python3 train.py --distributed-world-size 2 \ (depends on your GPU num.)
'/path/to/manifest/'
--save-dir "/save/dir/"
--fp16
--post-process letter
--valid-subset valid
--no-epoch-checkpoints
--best-checkpoint-metric wer
--num-workers 0
--max-update 15000
--sentence-avg
--task audio_pretraining
--arch wav2vec_ctc
--w2v-path "/path/to/checkpoint/from/training/checkpoint_last.pt"
--labels ltr
--reset-meters
--reset-optimizer
--reset-lr-scheduler
--apply-mask
--mask-selection static
--mask-other 0
--mask-length 10
--mask-prob 0.65
--layerdrop 0.1
--mask-channel-selection static
--mask-channel-other 0
--mask-channel-length 64
--mask-channel-prob 0.256
--zero-infinity
--feature-grad-mult 0.0
--freeze-finetune-updates 0
--validate-after-updates 8000
--optimizer adam
--adam-betas '(0.9, 0.98)'
--adam-eps 1e-08
--lr 2e-05
--lr-scheduler tri_stage
--warmup-steps 1000
--hold-steps 9000
--decay-steps 5000
--final-lr-scale 0.05
--final-dropout 0.0
--dropout 0.0
--activation-dropout 0.1
--criterion ctc
--attention-dropout 0.0
--max-tokens 3840000
--seed 2337
--log-format json
--log-interval 500
--ddp-backend no_c10d
--update-freq 4
--restore-file "/path/to/checkpoint/from/training/checkpoint_last.pt"

@SvPolina thank you, i'll have a try. can you explain which hyperparameter has the impact on the wer value?

@jiangtaojy , for me, eventually the issue was the appropriate specification of the used checkpoint, so ( --restore-file , I know that --finetune-from-model can also be used) solved the problem.

@SvPolina I tried, but it seems did not work. the loss in train dataset is very low, but in test dataset is still high. I used my own dataset, and the preprocess in two datasets is same, can you help me?

HI @jiangtaojy ,

Try to fine-tune one of the provided trained models (tained on the libri data set)
Check you input data (.wrd , .tsv, .ltr , lexicon and dict files).

Hey anybody able to rectify segmentation fault error yet?

Hi @amant555 ,
I've succeded to make a fine-tuning with the language model.

I didn't use the lm from :
https://dl.fbaipublicfiles.com/wav2letter/lexicon_free/librispeech/models/lm/lm_librispeech_kenlm_word_4g_200kvocab.bin

I've created my own :
https://deepspeech.readthedocs.io/en/v0.8.2/Scorer.html

For kenlm installation don't use:

-DCMAKE_BUILD_TYPE=Release -DKENLM_MAX_ORDER=20

Without setting -DKENLM_MAX_ORDER, I am unable to train more than 6-gram LM
Is there any way to use a character level LM directly in some fairseq examples or do we need to write a decoder from scratch using Fairseq and Wav2Letter++ (Flashlight) as base

Hey anybody able to rectify segmentation fault error yet?

Hi @amant555 ,
I've succeded to make a fine-tuning with the language model.

I didn't use the lm from :
https://dl.fbaipublicfiles.com/wav2letter/lexicon_free/librispeech/models/lm/lm_librispeech_kenlm_word_4g_200kvocab.bin

I've created my own :
https://deepspeech.readthedocs.io/en/v0.8.2/Scorer.html

For kenlm installation don't use:

-DCMAKE_BUILD_TYPE=Release -DKENLM_MAX_ORDER=20

Without setting -DKENLM_MAX_ORDER, I am unable to train more than 6-gram LM
Is there any way to use a character level LM directly in some fairseq examples or do we need to write a decoder from scratch using Fairseq and Wav2Letter++ (Flashlight) as base

@alexeib Is there any solution to this problem? I see in the Wav2Vec 2.0 paper, the authors have used upto 20-25 gram character LMs but this does not seem possible with the current setup

Hey anybody able to rectify segmentation fault error yet?

Hi @amant555 ,
I've succeded to make a fine-tuning with the language model.

I didn't use the lm from :
https://dl.fbaipublicfiles.com/wav2letter/lexicon_free/librispeech/models/lm/lm_librispeech_kenlm_word_4g_200kvocab.bin

I've created my own :
https://deepspeech.readthedocs.io/en/v0.8.2/Scorer.html

For kenlm installation don't use:

-DCMAKE_BUILD_TYPE=Release -DKENLM_MAX_ORDER=20

Without setting -DKENLM_MAX_ORDER, I am unable to train more than 6-gram LM
Is there any way to use a character level LM directly in some fairseq examples or do we need to write a decoder from scratch using Fairseq and Wav2Letter++ (Flashlight) as base

@alexeib Is there any solution to this problem? I see in the Wav2Vec 2.0 paper, the authors have used upto 20-25 gram character LMs but this does not seem possible with the current setup

Has anyone found a solution to this problem? I get Segmentation fault (core dumped) when decoding with a 20-gram character based language model.

thats a problem with wav2letter. i had issues using kenlm models with order > 6 (i.e. not supported by default kenlm builds). you have to recompile wav2letter/flashlight with specific flags to enable this, but i am not sure exactly how to get this to work


Improve replies#search formatting

[x] Show reply icons (… they don't seem to always show? it's weird) (#607)
[x] Show reply timestamps (#600, #599)
[ ] Fix formatting of paragraphs & linebreaks around highlighting (it seems to be related to how the database handles things)

reply:

search:

Looks instead to be due to keyword search?

I think the last item of this is hard to do and probably not a worry, so I'm gonna close this for now.


email inputmask "isComplete" always returns true

Hi,
I have a simple email input field, defined like:
$("#email").inputmask("email");
And then goes simple check:
if  ( !$('#email').inputmask("isComplete") ) {
error handling here
}
However, when user inputs only first part of the email, isComplete always returns true.
How do i check email for completion?  The regex in your email mask definition contains the second part as required, but it doesn't check that.
Does isComplete work with dynamic masks? If not, what should i do to check validity of the user email?
Thank you in advance.

Just found, that it happens only when user inputs first part without @.
For example, if he enters "akornilov" and press Submit, isComplete returns true. However, if he enters "akornilov@", then isComplete returns false and requires the full email address.

I will have a look at it on monday.bThx for the extra info

clearIncomplete is not working for email in Version: 3.1.62 but was working in Version: 3.1.55
$("#Email").inputmask("email", { "clearIncomplete": true });
when i enter invalid email id and jump to next control text is not getting cleared, this was happening in previous version.


add Christmas Holiday Bangladesh

We already merged a Bangladesh PR. Could you verify if our implementation is correct? If not, please open a new PR to fix it. Thanks!


Fall 2016 Goals

I'd like to lay out some short-term objectives for this repo to get everyone's opinions about them. Some of them might not be great ideas, and I'd like to have that pointed out before I spend any energy on them.
Concrete Objectives

[ ] Get 100% test coverage and enforce it with CI
[ ] Implement more of the HTTP API Spec
[ ] Implement and enforce commit message standards (like signing off with name/license)
[ ] Rename PIP package and python module to be called ipfsapi

Fuzzy Objectives

[ ] Integrate project with Codacy for better code insight
[ ] Develop "good" documentation (Docstring and pydoc, I think)
[ ] Create a better developer on-ramp (add a CONTRIBUTING.md with good instructions for setting up the py-ipfs-api development environment)

Social Objectives

[ ] Have at least two people review the code for PRs before merging them (this requires critical mass in contributors)

Thoughts? Additions? I'd love some feedback.

All this LGTM! 👍

I have another thing that I noticed while working on #63:
Currently our exception handling/raising behaviour is all over the place and entirely undocumented, this leads to downstream projects catching errors from our underlying libraries, because it's the most reliable thing they can currently do.
Basically we need:

A list of exceptions (within reasonable limits) that we expect our underlying libraries to raise (things like connection and protocol errors mostly)
Exception handling code that will consistently catch and wrap these errors at the appropriate locations
Extra documentation in the Client API about which exceptions may be expected at each call (or probably ratter a separate section since the list will be very similar between all calls)
Hopefully some documentation in the internal APIs as well


clang-tidy: Fix readability-redundant-string-init in headers

Split from bitcoin/bitcoin#26705 as was requested in https://github.com/bitcoin/bitcoin/pull/26705#issuecomment-1353293405.
To test this PR, consider applying a diff as follows:
--- a/src/.clang-tidy
+++ b/src/.clang-tidy
@@ -12,17 +12,9 @@ readability-redundant-declaration,
 readability-redundant-string-init,
 '
 WarningsAsErrors: '
-bugprone-argument-comment,
-bugprone-use-after-move,
-misc-unused-using-decls,
-modernize-use-default-member-init,
-modernize-use-nullptr,
-performance-for-range-copy,
-performance-move-const-arg,
-performance-unnecessary-copy-initialization,
-readability-redundant-declaration,
 readability-redundant-string-init,
 '
 CheckOptions:
  - key: performance-move-const-arg.CheckTriviallyCopyableMove
    value: false
+HeaderFilterRegex: '.'

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews
See the guideline for information on the review process.
A summary of reviews will appear here.


Update LAB[MB-800]_M04_Lab01_Set_up_Inventory.md

Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:

Submitted by thecrmninja on behalf of MOC Labs Review


Arrow Marker broken when using a start and end point instead of pose.

It looks like with the latest change/addition of checking if the quaternion is valid has broken the arrow marker when using a start and end point. In the case of using a start and end point the pose has all zeros for the orientation which causes it to fail with a display error below. Now if I just set the pose orientation of my marker to (0,0,0,1) the marker shows but not correctly because it now uses the pose data instead of points. In the interim I have to calculate a pose for everything work.
Contains invalid quaternions (length not equal to 1)!

closing this under the assumption it was fixed in 1.12.15


Pass IOPS/Throughput to VMScaleSet in Create and Update

Resource Provider
What is the Azure resource provider your feature is part of?
Microsoft.Compute (CRP)
Description of Feature or Work Requested
Provide a brief description of the feature or work requested. A link to conceptual documentation may be helpful too.
We have introduced new properties that apply to DataDisks when StorageAccountType is UltraSSD_LRS. Please note that they do not apply to OSDisk currently.
diskIOPSReadWrite: Used to specify IOPS for the Data disk.
diskMBpsReadWrite: Used to specify throughput in MB per second for the Data disk.
These properties can be set or updated only via Create or Update on the VMScaleSet. At a VMScaleSet VM level, these properties are ReadOnly. This means that an update on the VMScaleSet VM cannot modify the values of these properties on the disk but a GET on the VMScaleSetVM would return these properties and they should be displayed to the user.
Minimum API Version Required
What is the minimum API version of your service required to implement your feature?
2019-07-01
Swagger Link
Provide a link to the location of your feature(s) in the REST API specs repo. If your feature(s) has corresponding commit or pull request in the REST API specs repo, provide them. This should be on the master branch of the REST API specs repo.
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/compute.json
Specific commit: https://github.com/Azure/azure-rest-api-specs/pull/7094/commits/e0a2452d7a449c0e278b3d9ecfcdcf4ac7d6eb4f
Target Date
If you have a target date for release of this feature/work, please provide it. While we can't guarantee these dates,
it will help us prioritize your request against other requests.
November 4, 2019

@qwordy add to S162

@robhat1

This feature is published. You can download the latest Azure CLI and use it.


Write article about GDPR

As a web developer I want to learn about the GDPR, how it affects my work, and what I need to do to be compliant with it.
See here for the relevant docs bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1460916
Note: We need to be careful here — we can't be seen to be giving legal advice, but we can give practical hints and tips, maybe even a checklist. We just need to be careful and provide disclaimers, in the same way we did for the WCAG docs.

[ ] Research what we should write about this.

[ ] Write a plan.

[ ] Get the plan checked by one of our legal folk.

[ ] Write the article.

Looks stalled and is not currently planned. Closing.


Do you know how to load arrays of data?

I'm doing a web and I want to load an array of projects
"data":
[
{
"id": 1, "titol": "BBB",
"tema": "Angular2",
"tipus": "Example",
"data": "10/07/2016",
"estat": "FINISHED",
"link": "http://davidmartinezros.com/Angular2/HelloWorld/",
"html": "My first Angular2 Component that prints something into screen ('Hello World').",
"repositori": "https://github.com/davidmartinezros/HolaAngular2"
},
...
Do you know if ngx-translate could access to {{ 'data[0].titol' | translate }} ?
And how to do it?
Thanks in advanced,
David

Looks like this has been discussed in this issue:
https://github.com/angular-translate/angular-translate/issues/1508


Make unused assertion list available.

Coverage increased (+0.03%) to 90.282% when pulling 4a5671429bfea379d3fb55c8fa3cdacd39d982cd on expose-unused into 3d30a9d15652adba24a7f6a12989c4d323001f86 on master.