CIV-4767 order without hearing changes

JIRA link (if applicable)
CIV-4767
Change description
Change text for order without hearing for small claims
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

closed until agreed on a double non-prod approach


chore: support the latest flutter version for the base project

executing flutter pub get in the base folder will result an error due to the Dart SDK being too low.
Note: no need to publish a new version for pub.dev

Thanks, will ask a colleague to review in the upcoming days.


fix: code a little more idiomatic

solve Clippy's issues and accept suggestions from it

Sorry to bother but for this specific PR can you give me the favor to add the label "hacktoberfest-accepted"?
If don't you consider it enough you don't worry I can understand it

ok

Done, thanks


ModuleNotFoundError: No module named 'redis'

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running ytb_up version 0.1.15 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
I'm using Python version 3.10.0.
Redis 3.5.3 Installed
Traceback (most recent call last):
File "C:\Users\Administrator\Desktop\youtube\tiktoka-studio-uploader\examples\onefile-example_tiktok_sessionid.py", line 1, in
from tsup.tiktok.sessionId.uploader import  upload2TiktokSessionId
File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\tsup-0.1.16-py3.10.egg\tsup_init_.py", line 25, in
from tsup.youtube.youtube_upload import YoutubeUpload
File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\tsup-0.1.16-py3.10.egg\tsup\youtube\youtube_upload.py", line 12, in
from tsup.utils.webdriver import (
File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\tsup-0.1.16-py3.10.egg\tsup\utils\webdriver_init_.py", line 10, in
from tsup.utils.webdriver.playwright_driver_async import PlaywrightAsyncDriver
File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\tsup-0.1.16-py3.10.egg\tsup\utils\webdriver\playwright_driver_async.py", line 28, in
from tsup.utils import tools
File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\tsup-0.1.16-py3.10.egg\tsup\utils\tools.py", line 44, in
import redis
ModuleNotFoundError: No module named 'redis'

can you try
git checkout -b publish_policy
and run pip install -r requirements.txt
then your command


Add Cursively to the benchmark suite.

My Cursively library is a lot different from most others.  Rather than work on a stream of UTF-16 encoded char values, it works directly on the input bytes, leaving it up to the caller to choose how to process the individual fields.
It produces its output in an unusual way as well: rather than something like IEnumerable<string> (or similar), it requires the caller to provide a series of callbacks (exposed as a visitor-pattern implementation) that accept slices of the original input.
As a result, Cursively has the potential to be the fastest CSV implementation that I've seen, by far, if you are willing to spend the extra effort to integrate it with your application, and you don't need too much of your data to be UTF-16 encoded (since you'd have to transcode the individual fields one-by-one, which is not very CPU cache friendly).
Since practically every member in this benchmark must be fully hydrated as separate UTF-16 string instances, for unknown reasons, I had originally just written a couple of comments on the Reddit thread where your post was linked, and then gave it a rest...
...until @MarkPflug pinged me a while later with his own benchmark suite and tipped me off that the interesting benchmarks in yours actually have enough duplicated strings that a string pool makes a big difference.
So I went ahead and tweaked his string pool to work with a UTF-8 source (and to use XXH64 for hashing, since I had an implementation lying around from when I got bored one day), and now I'm getting some pretty good timings with Cursively, even though "transcode everything to individual UTF-16 string instances" is roughly the worst-case scenario for Cursively when it's compared against solutions that are optimized to assume that this is what you need.

Side note, it would be interesting to see how everything stacks up when you add the [GcServer(true)] attribute to PackageAssetsSuite... in theory, solutions that care about the throughput like this will also be perfectly willing to tune the GC to maximize throughput, which this tends to do in most cases.

Side note, it would be interesting to see how everything stacks up when you add the [GcServer(true)] attribute to PackageAssetsSuite... in theory, solutions that care about the throughput like this will also be perfectly willing to tune the GC to maximize throughput, which this tends to do in most cases.

Haha, I didn't even realize there was a Reddit post! Great discussion, especially between you and @MarkPflug.
BTW, your implementation is awesome! I'm curious if xxHash is really the best for hash coding. Have you compared the performance to .NET newish HashCode helper struct? I agree with your point that there's good SIMD potential that could allow a custom hash code method to beat HashCode.
I agree that string[] is imperfect for a CSV line abstraction, especially a low-level, manual data mapping thing like what I am doing. Also, I agree a ReadOnlySpan<byte> is a safer assumption for a parser residing at the bottom of the stack, just above the byte stream. Why assume string if the user is just writing those bytes back somewhere else? Or going to another property type besides string? I was talking to one of my coworkers and we were coming to a very similar conclusion (/cc @loic-sharma).
The main benefit of string[] is that is really easy to understand and build on top of. I have to say a visitor pattern and writing some accumulation code necessitated by your VisitPartialFieldContents is a tall order for most use cases. (Apologies if I am misunderstanding). Maybe it could be possible to use IReadOnlyList<ReadOnlySpan<byte>> instead of string[], conceding that we must hold the whole line in memory? Should be doable if backed by an expanding buffer similar to MemoryStream but I haven't tried or thought too deeply yet.
I have been thinking about adding a data mapping benchmark with the same PackageAsset model -- essentially let each library do its own thing to saturate and even activate each "record" instance instead of forcing a string[]. This is maybe closer to a programming model that most people want to use with CSVs (as shown by the success of CsvHelper). I think @MarkPflug has benchmarks for data mapping... maybe we should put our heads together 😄.

Haha, I didn't even realize there was a Reddit post! Great discussion, especially between you and @MarkPflug.
BTW, your implementation is awesome! I'm curious if xxHash is really the best for hash coding. Have you compared the performance to .NET newish HashCode helper struct? I agree with your point that there's good SIMD potential that could allow a custom hash code method to beat HashCode.
I agree that string[] is imperfect for a CSV line abstraction, especially a low-level, manual data mapping thing like what I am doing. Also, I agree a ReadOnlySpan<byte> is a safer assumption for a parser residing at the bottom of the stack, just above the byte stream. Why assume string if the user is just writing those bytes back somewhere else? Or going to another property type besides string? I was talking to one of my coworkers and we were coming to a very similar conclusion (/cc @loic-sharma).
The main benefit of string[] is that is really easy to understand and build on top of. I have to say a visitor pattern and writing some accumulation code necessitated by your VisitPartialFieldContents is a tall order for most use cases. (Apologies if I am misunderstanding). Maybe it could be possible to use IReadOnlyList<ReadOnlySpan<byte>> instead of string[], conceding that we must hold the whole line in memory? Should be doable if backed by an expanding buffer similar to MemoryStream but I haven't tried or thought too deeply yet.
I have been thinking about adding a data mapping benchmark with the same PackageAsset model -- essentially let each library do its own thing to saturate and even activate each "record" instance instead of forcing a string[]. This is maybe closer to a programming model that most people want to use with CSVs (as shown by the success of CsvHelper). I think @MarkPflug has benchmarks for data mapping... maybe we should put our heads together 😄.

Regarding [GcServer(true)], I think it's an interesting test, but I think it should be a separate benchmark/variant. People may not want to tune in this way (depends on their application) so know both "workstation GC" and "server GC" are interesting data points.

Regarding [GcServer(true)], I think it's an interesting test, but I think it should be a separate benchmark/variant. People may not want to tune in this way (depends on their application) so know both "workstation GC" and "server GC" are interesting data points.

I'm curious if xxHash is really the best for hash coding. Have you compared the performance to .NET newish HashCode helper struct?

HashCode.Combine is xxHash32.  The linked PR has a really good discussion on the intent of the interface as well, such as why static int Combine<T1>(T1 value1)  exists.
Unrelated, I have a nice list of hashing functions for .NET listed in my .NET library : https://github.com/jzabroski/Home/#non-cryptographic-hashing-functions

I'm curious if xxHash is really the best for hash coding. Have you compared the performance to .NET newish HashCode helper struct?

HashCode.Combine is xxHash32.  The linked PR has a really good discussion on the intent of the interface as well, such as why static int Combine<T1>(T1 value1)  exists.
Unrelated, I have a nice list of hashing functions for .NET listed in my .NET library : https://github.com/jzabroski/Home/#non-cryptographic-hashing-functions

Also, it's a bit off-topic, but I have been meaning to add an answer to https://stackoverflow.com/questions/102742/why-is-397-used-for-resharper-gethashcode-override/

Also, it's a bit off-topic, but I have been meaning to add an answer to https://stackoverflow.com/questions/102742/why-is-397-used-for-resharper-gethashcode-override/

I'm curious if xxHash is really the best for hash coding. Have you compared the performance to .NET newish HashCode helper struct?

I went with XXH64 just because I had a port of it lying around.  I think XXH3 has properties that would make it favorable in this particular data set (particularly, it is supposedly much faster at dealing with short keys, which this has a lot of), I just didn't want to bother with all the work to port it, for what would likely be only a marginal improvement.
If you want to get really lost in this, check out this blog post written by the author of XXH3 and of, I think, XXH32 and XXH64.

I have to say a visitor pattern and writing some accumulation code necessitated by your VisitPartialFieldContents is a tall order for most use cases. (Apologies if I am misunderstanding).

airbreather/Cursively#21 / airbreather/Cursively#22 are there to layer more conventional ways of consuming the data on top of this, but it's not a high priority for me because it's actually a lot of work to flip the loop on its head, and I think there are plenty of other libraries that would fit better if that's how you wanted the data anyway.
The reason to do that layering would mainly be to just offer a way to use a single library for all your CSV processing instead of having to choose Cursively for cases where runtime efficiency matters more than developer productivity, and some other library for cases where that's reversed.  That said, .NET itself is filled with "start with this productive approach, drop down to more efficient code as needed" APIs, so it's not out of the question.
If the issue is just the accumulating from VisitPartialFieldContents, then I could write some intermediate visitor class that does this accumulation for you.  The reason why it's like this at the lowest level is to provide the greatest level of flexibility I can think of: it supports fields over 2 GiB, it gives you a way to gracefully stop early before a malicious input file pushes you into an OutOfMemoryException from trying to expand an accumulator buffer too big, it lets you use pointer math to get offsets from the beginning of the entire memory-mapped file, and I'm sure other stuff that I haven't even thought of that only works if you strictly get slices of the original input span(s).

Maybe it could be possible to use IReadOnlyList<ReadOnlySpan<byte>> instead of string[], conceding that we must hold the whole line in memory? Should be doable if backed by an expanding buffer similar to MemoryStream but I haven't tried or thought too deeply yet.

The specific idea of IReadOnlyList<ReadOnlySpan<byte>> can't work, because ReadOnlySpan<byte> is a ref struct, but it's fairly straightforward to create intermediate visitor base classes that transform the trio of VisitPartialFieldContents(ReadOnlySpan<byte>) / VisitEndOfField(ReadOnlySpan<byte>) / VisitEndOfRecord() into something else.
For example, we could have a visitor base class where all you have to implement is a method like:
protected override void VisitRecord(ReadOnlySpan<byte> fullLineData, ReadOnlySpan<int> firstIndex)
{
    // firstIndex[n] is the offset of the nth field's first byte in fullLineData
    // there's one extra slot at the end that always holds the value of fullLineData.Length.
    for (int i = 0; i < firstIndex.Length - 1; i++)
    {
        ReadOnlySpan<byte> field = fullLineData[firstIndex[i]..firstIndex[i + 1]];
        DoStuffWith(field);
    }
}

To completely get away from the users having to implement a visitor, I think it would be reasonably doable to write something that converts this to IObservable<T>, since that's a more standard way to model this concept of inverted loop ownership.  I actually was going to do that for Cursively at first, but the visitor-pattern approach had a better story for incrementally layering intermediate transformations (CsvReaderVisitorWithUTF8HeadersBase being one example of that), and the most obvious choices for T are all difficult to add stuff to without breaking callers.
In any event, from IObservable<T>, one could use the services from Rx.NET to manipulate it further, one such manipulation being to convert it into IEnumerable<T>, probably not worse than what I would wind up writing on my own.

I have been thinking about adding a data mapping benchmark with the same PackageAsset model -- essentially let each library do its own thing to saturate and even activate each "record" instance instead of forcing a string[].

Anything that doesn't strictly require UTF-16 is always a plus for Cursively.  Of course, the majority of the .NET ecosystem is built around using UTF-16 for strings, and although there's been lots of great progress towards making UTF-8 more than just "that thing that we have to keep converting to and from when we interact with the rest of the world", UTF-8 still feels like a second-class citizen.

I'm curious if xxHash is really the best for hash coding. Have you compared the performance to .NET newish HashCode helper struct?

I went with XXH64 just because I had a port of it lying around.  I think XXH3 has properties that would make it favorable in this particular data set (particularly, it is supposedly much faster at dealing with short keys, which this has a lot of), I just didn't want to bother with all the work to port it, for what would likely be only a marginal improvement.
If you want to get really lost in this, check out this blog post written by the author of XXH3 and of, I think, XXH32 and XXH64.

I have to say a visitor pattern and writing some accumulation code necessitated by your VisitPartialFieldContents is a tall order for most use cases. (Apologies if I am misunderstanding).

airbreather/Cursively#21 / airbreather/Cursively#22 are there to layer more conventional ways of consuming the data on top of this, but it's not a high priority for me because it's actually a lot of work to flip the loop on its head, and I think there are plenty of other libraries that would fit better if that's how you wanted the data anyway.
The reason to do that layering would mainly be to just offer a way to use a single library for all your CSV processing instead of having to choose Cursively for cases where runtime efficiency matters more than developer productivity, and some other library for cases where that's reversed.  That said, .NET itself is filled with "start with this productive approach, drop down to more efficient code as needed" APIs, so it's not out of the question.
If the issue is just the accumulating from VisitPartialFieldContents, then I could write some intermediate visitor class that does this accumulation for you.  The reason why it's like this at the lowest level is to provide the greatest level of flexibility I can think of: it supports fields over 2 GiB, it gives you a way to gracefully stop early before a malicious input file pushes you into an OutOfMemoryException from trying to expand an accumulator buffer too big, it lets you use pointer math to get offsets from the beginning of the entire memory-mapped file, and I'm sure other stuff that I haven't even thought of that only works if you strictly get slices of the original input span(s).

Maybe it could be possible to use IReadOnlyList<ReadOnlySpan<byte>> instead of string[], conceding that we must hold the whole line in memory? Should be doable if backed by an expanding buffer similar to MemoryStream but I haven't tried or thought too deeply yet.

The specific idea of IReadOnlyList<ReadOnlySpan<byte>> can't work, because ReadOnlySpan<byte> is a ref struct, but it's fairly straightforward to create intermediate visitor base classes that transform the trio of VisitPartialFieldContents(ReadOnlySpan<byte>) / VisitEndOfField(ReadOnlySpan<byte>) / VisitEndOfRecord() into something else.
For example, we could have a visitor base class where all you have to implement is a method like:
protected override void VisitRecord(ReadOnlySpan<byte> fullLineData, ReadOnlySpan<int> firstIndex)
{
    // firstIndex[n] is the offset of the nth field's first byte in fullLineData
    // there's one extra slot at the end that always holds the value of fullLineData.Length.
    for (int i = 0; i < firstIndex.Length - 1; i++)
    {
        ReadOnlySpan<byte> field = fullLineData[firstIndex[i]..firstIndex[i + 1]];
        DoStuffWith(field);
    }
}

To completely get away from the users having to implement a visitor, I think it would be reasonably doable to write something that converts this to IObservable<T>, since that's a more standard way to model this concept of inverted loop ownership.  I actually was going to do that for Cursively at first, but the visitor-pattern approach had a better story for incrementally layering intermediate transformations (CsvReaderVisitorWithUTF8HeadersBase being one example of that), and the most obvious choices for T are all difficult to add stuff to without breaking callers.
In any event, from IObservable<T>, one could use the services from Rx.NET to manipulate it further, one such manipulation being to convert it into IEnumerable<T>, probably not worse than what I would wind up writing on my own.

I have been thinking about adding a data mapping benchmark with the same PackageAsset model -- essentially let each library do its own thing to saturate and even activate each "record" instance instead of forcing a string[].

Anything that doesn't strictly require UTF-16 is always a plus for Cursively.  Of course, the majority of the .NET ecosystem is built around using UTF-16 for strings, and although there's been lots of great progress towards making UTF-8 more than just "that thing that we have to keep converting to and from when we interact with the rest of the world", UTF-8 still feels like a second-class citizen.


improve network IO using 1 CPU 1 socket

network IO can be improved using a relation of 1 CPU 1 Socket

#591 does not improve network IO


Identify links in About Activity

The app can't currently identify links in the about activity content. This should be rectified.

Working on it :+1:

No, this is the responsibility of the poster to properly format the description. I don't think we should display HTML in the app

Actually when I created an event, I entered "https://eventyay.com". This clearly got converted to Html formatted code. We could just extract out the link and parse it. Isn't that correct ?

Raise this issue to the server. Sending HTML from the API is not standard and unsafe

Great :+1:

I can't find any event which has links in about section. Where can I create an event for testing purposes?

Check Open Event Orga App


[Question] How to keep the devKey safe?

When initializing the SDK, the devKey is required. This means we need to either hardcode it in the code or use something like react-native-config to have it in a dotenv file. While the latter is better, both are vulnerable to any reverse engineering done to the app.
What are your recommendations to keep the devKey safe from attackers? Do we need to keep it safe or is it not an actual secret?
Cheers

Hi @danielfx90!
Thank you for opening this issue.
Please contact our support team<EMAIL_ADDRESS>


why reads become more

fastplong -w 128 -Q  -i ont.fq.gz -o fastplong.fq.gz
Trying to detect adapter sequence at read start
Detected: TGTACTTCGTTCAGTTACGTATTGCT
Trying to detect adapter sequence at read end
Found possible adapter sequence, but it's too short: AGCAATACGTAACT, specify -e AGCAATACGTAACT to force trimming using this adapter
WARNING: fastp uses up to 16 threads although you specified 128
Before filtering:
total reads: 100000
total bases:<PHONE_NUMBER>
Q20 bases: 292467773(26.2069%)
Q30 bases: 35884706(3.21549%)
After filtering:
total reads: 101516
total bases:<PHONE_NUMBER>
Q20 bases: 291912102(26.2175%)
Q30 bases: 35844471(3.2193%)
Filtering result:
reads passed filter: 101516
reads failed due to low quality: 0
reads failed due to too many N: 0
reads failed due to too short: 8
reads with adapter trimmed: 61654
bases trimmed due to adapters: 2500069
JSON report: fastplong.json
HTML report: fastplong.html
fastplong -w 128 -Q -i ont.fq.gz -o fastplong.fq.gz
fastplong v0.2.0, time used: 43 seconds

For some cases, the original reads contain adapters in the middle, this read will be broken into to two reads. So it may result in more reads after preprocessing.

thanks

you said that read will be broken into to two reads, but their have the same id, so i use software for assemble, such as flye, i will get error about
'ERROR: The input contain reads with duplicated IDs. Make sure all reads have unique IDs and restart. The first problematic ID was: f8d2154a-b23f-4bdf-bc8e-8e976c29b36e'.
what should i do about that

This is a good point, I will update it soon.

I updated it, can you try the latest v0.2.1.
The read names will be like:
@split-by-adapter-left-7ad44b78-0c37-41db-b96b-3282022252ca runid=a0f5a0ea22c0fd9853f62de5e7dcbe17a6fb757e read=26913 ch=12 start_time=2024-06-15T02:45:58.844793+00:00 flow_cell_id=FAX29329 protocol_group_id=huaxicxqdjhdt sample_id=no_sample barcode=barcode07 barcode_alias=barcode07 parent_read_id=7ad44b78-0c37-41db-b96b-3282022252ca<EMAIL_ADDRESS>
and
@split-by-adapter-right-7ad44b78-0c37-41db-b96b-3282022252ca runid=a0f5a0ea22c0fd9853f62de5e7dcbe17a6fb757e read=26913 ch=12 start_time=2024-06-15T02:45:58.844793+00:00 flow_cell_id=FAX29329 protocol_group_id=huaxicxqdjhdt sample_id=no_sample barcode=barcode07 barcode_alias=barcode07 parent_read_id=7ad44b78-0c37-41db-b96b-3282022252ca<EMAIL_ADDRESS>

thank you about write a nice software. so it can also handle reads become three parts?

thank you about write a nice software. so it can also handle reads become three parts?

It won't become three parts. It can only be split to up to 2 parts.

thanks. By the way, which article should i cite about Fastplong

thanks. By the way, which article should i cite about Fastplong

fastplong will be published in early 2025, before that you can cite the fastp paper.

Hi @sfchen, I cannopt find the latest v0.2.1 on github.


Update .pylintrc - disable unsubscriptable-object

@hopedisastro  you could merge this straight into your other branch so solve those linting issues!


Run full E2E matrix only when PR approved

There's no need to run the full E2E test matrix before a PR is approved
for testing, so adding a default test for most of the time and changing
the matrix job to run only when the ready-to-test label is present.
The label will be applied once 2 approvals are given on the PR, but can
also be added (or removed) manually as needed.
Signed-off-by: Mike Kolesnik<EMAIL_ADDRESS>

Sound like a good plan


Adding the HashiCorp providers to the Cloud Providers page

Related: #1879

Proposed changes

Unreleased product version (optional)

Related issues (optional)

@lukehoban I updated the PR to include a new Core Providers section - that's where we can add our big 4 :)
Is this better for you?


admin app requests list is broken for workspace with more than 1 workspace.

Description
def admin_apps_requests_list (https://github.com/slackapi/python-slackclient/blob/master/slack/web/client.py#L95) does not work for grid instance with more than 1 Workspace. team_id is required for grid instance with more than one workspace https://api.slack.com/methods/admin.apps.requests.list there isn't an option to allow team_id, so you'll get a stack trace when running this function.
What type of issue is this? (place an x in one of the [ ])

[x] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
slackclient version: 2.5.0
python version: Python 3.7
OS version(s): OSX 10.14.6
Steps to reproduce:

Grid instance with more than 1 workspace
Call admin_apps_requests_list

Expected result:
To get a list of apps in a workspace
Actual result:
What actually happened
Attachments:
Traceback (most recent call last):
  File "test.py", line 22, in <module>
    get_apps(slack_client)
  File "test.py", line 9, in get_apps
    print(slack_client.admin_apps_requests_list())
  File "/usr/local/lib/python3.7/site-packages/slack/web/client.py", line 97, in admin_apps_requests_list
    return self.api_call("admin.apps.requests.list", http_verb="GET", params=kwargs)
  File "/usr/local/lib/python3.7/site-packages/slack/web/base_client.py", line 171, in api_call
    return self._event_loop.run_until_complete(future)
  File "/usr/local/Cellar/python/3.7.6/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 583, in run_until_complete
    return future.result()
  File "/usr/local/lib/python3.7/site-packages/slack/web/base_client.py", line 226, in _send
    return SlackResponse(**{**data, **res}).validate()
  File "/usr/local/lib/python3.7/site-packages/slack/web/slack_response.py", line 176, in validate
    raise e.SlackApiError(message=msg, response=self)
slack.errors.SlackApiError: The request to the Slack API failed.
 It seems like that error is to due with the response from Slack rather than the client itself. Based on the code, the admin.apps.requests.list method should be able to accept any arguments, including the optional team_id. It looks like the error you're running into is that the team_id isn't valid.
When I was triaging this, I ran into this same error because I was passing in the team_id from oauth.access (which started with an E and was associated with the organizaiton, it seems like).
You may want to check you're using the correct team_id by calling admins.teams.list and verifying that the team_id you're passing in is correct (should start with a T). Please let me know if this problem persists, and if it does, perhaps provide the API call + params you're using.

@carchi8py Let me know if you need further help here. We're not observing any issues with the API and as Shay mentioned, the method in this library can accept team_id argument.

sorry i missed this earlier. This can be closed.

Thanks for your prompt response! Going to close this now.


Set smaller min width for main window

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Sets a smaller min width on the main window, allowing GB Studio to run maximised on devices with lower resolution screens (such as phones) or allow GB Studio to be tiled on medium resolution screens (such as low-end laptops).

What is the current behavior? (You can also link to an open issue here)
Only medium resolution screens can run GB Studio maximised, and only high resolution screens can tile GB Studio.

What is the new behavior (if this is a feature change)?
Min width of the main window has been adjusted to compensate for lower resolutions, allowing more devices to run GB Studio maximised or tiled.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Not that I'm aware of.

Other information:

Hi @patrickmollohan unfortunately this PR introduces some cropping of the UI on the Mac build as there's slightly less room because the window buttons are displayed inline in the toolbar

See how the window title only displays a single character and the play button is mostly cropped on the right of the screen.
About the absolute smallest we can get without requiring some design changes is 720px wide.

If you shrunk the search input and section button when the width reached a certain cutoff point you might just be able to fit to 600 though.

O gotcha, whoops! I tested on Linux and Windows but my Hackintosh is down atm. I originally tried 720px for my PinePhone, but even though the screen's resolution is 720x1440, it would not resize to fullscreen. I tried 700px next, which worked on my PinePhone, but I realised it wouldn't do the tiling like shown on my laptop, which is why I dropped it to 600px.

I don't have my Hackintosh back up and running just yet, but I added the 80px padding temporarily in the css file so I can approximate what it looks like (removed before submitting the commit). Changed the 600px min width to 640px (half of the width of 1280px wide monitors). When the window is above 720px, everything is normal. Below that, a few things are shrunk: the selector, the search bar, and the fixed spacer to the left of the build button. The selector could be further reduced by eliminating the arrow and the search bar could be even smaller (cutting out the ellipses). Looks a lot more functional on my end, but will need to be tested on macOS to make sure the build button isn't off-screen still.

Thanks @patrickmollohan that's looking good now on my Mac :-)

I'm starting to work on a UI refactor at the moment and I've already put in a test for a 600px wide toolbar in that version to make sure I don't cause a regression here when I eventually switch over https://ui.gbstudio.dev/?path=/story/components-toolbar--app-toolbar-small


Add linting for the ACL file

This adds a linter for the ACL file. Sometimes when deleting large amounts of ACL changes, it may be easy to accidentally forget to remove something, specifically duplicate keys.
For example, if you're removing a bunch of old ACL entries,  at a glance this change seems okay:

But once it's actually merged, it ends up like:
---
- resources:
  - method: ALL
    path: /foo/bar/.*
    path: /
  allow_all: true

Here, you'll have a duplicate path key, and you will end up restricting a previously valid endpoint.

Hmmm. Rather than do this in production code, should this get added as a lint step we can invoke from CI?

@nerdrew @tarcieri do you have opinions on this? I don't generally think of an API init call should be responsible for the linting. It's really more of an app level check at test time, since this means you can merge code, and then have it fail after it's deployed.

haha

I think another consideration is whether we should allow a yaml file with duplicate keys to block a deploy or not (i.e. tests fail, but can still be deployed). If we don't want it to block, then a linter sounds like a good choice.
Also fwiw, Ww do checks today in the initialize method (i.e. make sure required keys are present). But, I'm also happy to make this into a linter during test time.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


exclude main() from des.c

it will be nice to move main() into sample folder. in this case we could use your code as a library.

Hi @glory-man,
True. Although I would discourage using this code at all for any serious matter. In fact, I would discourage using any DES (or 3DES). This implementation is merely a coding exercise.
Cheers!


Swift compiler doesn't support turning off whole module optimization on certain projects

Description
I know, I know, this is really an SPM issue.  But the SPM people think I should file it here.  I'm just doing what they asked.  I hope we can avoid 👉 👈
This matters to me because of #70979, which I need to work around.
Reproduction

swift package init --type executable
add swiftSettings: [.unsafeFlags(["-no-whole-module-optimization"])] to the executable target
swift build -c release

Expected behavior
build completes successfully
Environment
swift-driver version: 1.87.3 Apple Swift version 5.9.2 (swiftlang-<IP_ADDRESS>.56 clang-15<IP_ADDRESS>.5)
Target: arm64-apple-macosx14.0
Additional information
No response

@MaxDesiatov Hello Max, I hope you don’t mind me tidying up the labels.
WMO control strikes me as as much a Swift build system feature as -c release. What exactly do you think the compiler is lacking in this situation? Does such a feature warrant a coordinated effort?

@AnthonyLatsis I am assuming your entire message (not just the first sentence) is directed at @MaxDesiatov.  No need to respond unless I've got that wrong.  Thanks.

What exactly do you think the compiler is lacking in this situation?

IDK, I'm not a compiler engineer to specifically point to an area of code in the compiler that's responsible for this. As clarified in the issue originally created on the SwiftPM repository, SwiftPM is just passing -no-whole-module-optimization flag to swiftc as is (unlike -c release), there's nothing we can do about it on our side if swiftc doesn't handle this flag well. And that's the reason we only allow these ad-hoc optimization settings to be passed to swiftc from SwiftPM via unsafeFlags, to warn users they'd be relying on specific swiftc tweaks at their own risk.

Forgive me, but although you may have tried to explain something in the original issue, nothing was clarified (as in actually made clearer) there.  It's as much a mystery to me why we're here as ever, and I'm pretty sure @AnthonyLatsis is in the same boat.  So please try not to assume that whatever message you've been trying to send was actually well-formed enough for anyone else to understand.
I don't know why you think swiftc is failing to “handle the flag well,” or even what you mean by that phrase.
The dependencies file being complained about is something that a build system would look for, not a compiler.  The only thing I can imagine that you mean (and because you really haven't clarified anything, I'm only guessing here, which runs the risk of wasting everybody's time) is that the build system expects the compiler to have generated the dependencies file, but it does not.  If I've guessed correctly at what you mean, the problem comes down to what the contract is between the compiler and the build system, and/or what promises swiftc makes to the world about generating such files.

As I suspected, the diagnostic comes from the build system(swift-llbuild).   Whether that is an SPM concern or a Swift concern is for the two of you to work out, I suppose.

Thank you for helping us chase that error down. Here is what I think we should do (not you, Dave):

Transfer this to the SPM repo. "I want SPM to support turning off WMO" is clearly a feature request that belongs there.
Reopen the issue this spun from and invite some swift-llbuild and swift-driver folks to discuss if there’s anything we could/should do about it.

@MaxDesiatov If this sounds reasonable to you, could you do the transfer? Perhaps you may also have some ideas on who to tag in the original issue.

Transfer this to the SPM repo. "I want SPM to support turning off WMO" is clearly a feature request that belongs there.

That's what https://github.com/apple/swift-package-manager/issues/7276 is (and what I was asking that the previous SPM issue to be repurposed for, but of course feel free to organize the issues any way you like).

I see, let us close this out then.

@AnthonyLatsis I think this leaves me stuck because I don't expect the underlying WMO bug to be easily diagnosed and it doesn't look like SPM can add a supported flag that works reliably without changes in other components.
The compiler could work around the problem by, when -no-whole-module-optimization is passed, first generating the dependencies file as though the flag hadn't been passed.  In fact I think there are command-line options to do that.  Yes, this same workaround could also surely be applied at the driver or swift-llbuild level… so I guess, with apologies, I'm reopening this and filing cross-referencing issues against both of those projects.  I don't know what else to do.


Capistrano integration breaks for latest 2.x release

The change introduced in https://github.com/capistrano/capistrano/commit/c971854ea7dc8ed26d9e858d57c203eccbb06d54 breaks your Capistrano 2 integration which expects Capistrano::VERSION to only be defined in Capistrano 3+.
I tried to write a failing test and fix the issue but failed with the test setup. The only insight I can provide is this: In the Capistrano runtime, the capistrano/version file is only loaded when invoking the help option via the CLI (see https://github.com/capistrano/capistrano/blob/legacy-v2/lib/capistrano/cli/options.rb#L118). So this constant is, in fact, never discovered. However, when I do my usual deploy call (bundle exec cap production deploy), for whichever reason it seems to be picked up.
To fix the issue, you probably need to require capistrano/version manually and adapt the version check something like the following: if defined?(Capistrano::VERSION) && Gem::Version.new(Capistrano::VERSION) >= Gem::Version.new(3).
In the meantime, I've solved my issue by manually requiring the proper files:
# require 'appsignal/capistrano'
require 'appsignal'
require 'appsignal/integrations/capistrano/capistrano_2_tasks'

Hope this helps at least a little bit. :)

Hi @clemens thanks for the info! I'll add this to the 0.11.13 release  :)

Fixed in master :)


Remove the unused junit4 dependency in managed ledger

Motivation
Remove the unused junit depency in managed ledger
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] no-need-doc

dependency change, no need doc

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@codelipenghui @lhotari @michaeljmarshall @merlimat @315157973 @hangc0276 PTAL, thanks


Error: Unknown parameter, 'measure_start_angle

When I start r2000 driver with latest code, I get this error on startup:
Is my firmware not up to date or something?
[r2000_node-2] protocol error: 0 success
[r2000_node-2] protocol error: 0 success
[r2000_node-2] [10/12/19 11:27:41:144:144954] [default] [info] UDP Connection: connecting to: <IP_ADDRESS>:60849
[r2000_node-2] protocol error: 0 success
[r2000_node-2] protocol error: 110 Unknown parameter, 'measure_start_angle'.
[r2000_node-2] terminate called after throwing an instance of 'std::invalid_argument'
[r2000_node-2]   what():  stoi

Available parameters:

{
"parameters":[
"vendor",
"product",
"part",
"serial",
"revision_fw",
"revision_hw",
"max_connections",
"feature_flags",
"radial_range_max",
"radial_range_min",
"radial_resolution",
"angular_fov",
"angular_resolution",
"ip_mode",
"ip_address",
"subnet_mask",
"gateway",
"scan_frequency",
"scan_direction",
"samples_per_scan",
"scan_frequency_measured",
"status_flags",
"load_indication",
"up_time",
"power_cycles",
"operation_time",
"operation_time_scaled",
"temperature_current",
"temperature_min",
"temperature_max",
"contamination",
"user_tag",
"device_family",
"mac_address",
"hmi_display_mode",
"hmi_language",
"hmi_button_lock",
"hmi_parameter_lock",
"ip_mode_current",
"ip_address_current",
"subnet_mask_current",
"gateway_current",
"system_time_raw",
"user_notes",
"locator_indication",
"scan_frequency_min",
"scan_frequency_max",
"sampling_rate_min",
"sampling_rate_max",
"hmi_static_text_1",
"hmi_static_text_2",
"hmi_application_text_1",
"hmi_application_text_2",
"hmi_static_logo",
"hmi_application_bitmap",
"operating_mode",
"emitter_type",
"filter_type",
"filter_width",
"filter_error_handling",
"filter_remission_threshold",
"filter_maximum_margin"
],
"error_code":0,
"error_text":"success"
}

This is not a firmware issue. I will get back to you regarding this.

measure_start_angle is a parameter for the r2300 LIDAR. Comment the line angle_min_max = protocol_interface->get_angle_min_max(handle_info.handle); in pf_interface.hpp and it should work.

I was successfully able to capture with an R2000 this week and did not experience this issue, so I think this has been resolved?

Yes, it was fixed in https://github.com/PepperlFuchs/ROS_driver/pull/14


Missing support for special characters in torrent client URL

My rutorrent password contains a ! character and as a result I cannot connect cross-seed to rTorrent.
Inputting the password as is rtorrentRpcUrl: "http://user:password!@rutorrent/RPC2",
Returns invalid URL error:
info: Validating your configuration...
(node:7) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_URL]: Invalid URL: http://user:password!@rutorrent/RPC2
    at onParseError (internal/url.js:258:9)
    at new URL (internal/url.js:334:5)
    at new RTorrent (/usr/src/app/dist/src/clients/RTorrent.js:52:68)
    at instantiateDownloadClient (/usr/src/app/dist/src/clients/TorrentClient.js:14:24)
    at Object.getClient (/usr/src/app/dist/src/clients/TorrentClient.js:22:9)
    at Object.doStartupValidation (/usr/src/app/dist/src/startup.js:9:44)
    at Command.<anonymous> (/usr/src/app/dist/src/cmd.js:109:29)
    at Command.listener [as _actionHandler] (/usr/src/app/node_modules/commander/index.js:907:31)
    at Command._parseCommand (/usr/src/app/node_modules/commander/index.js:1491:14)
    at Command._dispatchSubcommand (/usr/src/app/node_modules/commander/index.js:1436:18)
(node:7) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:7) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Escaping the character by using URL encoding (! = %21) / rtorrentRpcUrl: "http://user:password%21@rutorrent/RPC2",
Causes auth failure:
Info: Validating your configuration...
Error: Failed to reach rTorrent at http://user:password%21@rutorrent/RPC2

BTW, it would be cool if the log were more explicit as to the cause of the error being auth failure. I spent like an hour fiddling with the host block of the URL until I figured out the issue isn't there.
Anyway, special characters are essential for security when a web UI is exposed to the internet.
Maybe consider Base64 encoding? And perhaps break apart the setting like most apps do. Something like:
rtorrentHost: "http://host",
rtorrentRpcUrl: "RPC2",
rtorrentPort: "80",
rtorrentCreds: "dXNlcjpwYXNz", // Base64 encoded user:pass

Thanks.

This is an interesting bug…
My password contains lots of special characters and it works just fine.
I don't think it's the trailing exclamation point. You can see in the stack trace that it's failing at new URL which is part of the standard library for Node. When I tried creating your URL in the node REPL, it worked just fine:
> new URL("http://user:password!@rutorrent/RPC2")
URL {
  href: 'http://user:password!@rutorrent/RPC2',
  origin: 'http://rutorrent',
  protocol: 'http:',
  username: 'user',
  password: 'password!',
  host: 'rutorrent',
  hostname: 'rutorrent',
  port: '',
  pathname: '/RPC2',
  search: '',
  searchParams: URLSearchParams {},
  hash: '' }

Does your username/password contain any of the following characters?
/, \, ", @, :

To debug this, my suggestion is to go into the node REPL and try doing new URL("xyz") with the original url first, to confirm that it is indeed the URL constructor, and that my code isn't somehow mangling the URL along the way (unlikely but anything's possible). Then, I would recommend removing one suspicious character at a time from the user/pass until it starts working.

Sorry, I was tired when I made this post after hours of troubleshooting, and got things mixed up somehow. It's actually a trailing ? that causes the Node error–there's no other special character in the password, and none in the username. Originally I had @ in the password and that didn't work with cross-seed, so then I changed it to a string without special characters at all and that did work–hence my deduction that special characters are not supported. Then I figured it was time for a new password anyway which is how I ended up with the ? one, but there was never a !.
As for the Node output (not sure if this what you meant):
$ docker exec -ti cross-seed node
Welcome to Node.js v12.22.1.
Type ".help" for more information.
> new URL("http://****:*******?@rutorrent/RPC2")
Uncaught TypeError [ERR_INVALID_URL]: Invalid URL: http://****:*******?@rutorrent/RPC2
    at onParseError (internal/url.js:258:9)
    at new URL (internal/url.js:334:5)
    at REPL1:1:1
    at Script.runInThisContext (vm.js:120:18)
    at REPLServer.defaultEval (repl.js:442:29)
    at bound (domain.js:427:14)
    at REPLServer.runBound [as eval] (domain.js:440:12)
    at REPLServer.onLine (repl.js:777:10)
    at REPLServer.emit (events.js:326:22)
    at REPLServer.EventEmitter.emit (domain.js:483:12) {
  input: 'http://****:*******?@rutorrent/RPC2',
  code: 'ERR_INVALID_URL'
}
>

Support for percent-encoded URL components added in v2.5.2


Electronize is not running, if only .NET 8 is installed

We are using the latest nuget packages V23.6.2.
When we start 'electronize build ...', we get this error:
You must install or update .NET to run this application.
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64)
.NET location: C:\Program Files\dotnet
The following frameworks were found:
8.0.2 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
.NET 6 will be obsolete end of this year and .NET 8 was released last november.
when will be electron migrated to .NET 8 ?

I removed the bug label as this is not a bug. Applications are shipped with a specific framework dependency.
A newer version might / will be released for .NET 8, but right now we are still at .NET 6. As mentioned from your side the official support is still until later this year - so its totally fine.
If you want to fasten up development speed consider contributing to the project either via PRs or financially. Thanks for your support!


Fix crash in vortex subscriber when there is no filter

Fixes the crash in vortex manipulator where it was assuming that the filter is always not nil.

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "manipulate",
    "pr-id": "97",
    "commit-sha": "f1a84800e971e16b454bef6650fc34a90fb37140"
  }
]


tmt should automatically install rsync on SUT

Currently, if there's not rsync installed on the SUT, the execute step fail as it cannot sync the data.

Should be solved soon by #553


Fix ruf005

This attempts to fix https://github.com/charliermarsh/ruff/issues/3496.
It introduces the following changes:

The building of the new suggested expression is moved to a recursive function to handle cases with multiple concatenations on a single line.
The rule now also checks for concatenations of lists/tuples (for example a = [1] + [2]).  (I'm not sure if this behavior is desired, it's not directly related to the issue).
New tests to check the new behavior.

Do you mind adding some information to the PR summary around what needed to change, and why?

To be honest I'm not sure I went about it the right way, so if you think that there is a better way to solve the issue I don't mind redoing it another way or trying to tackle a different issue.
On another note, I have a question about the formatting of the test fixture. The following test always gets formatted by black during the pre-commit verify:
foo + [  # This will be preserved, but doesn't prevent the fix
]

Should I remove this test (and maybe include a replacement one), or if it better to use --no-verify when making a commit modifying the test fixture file ?

I'll take a look at this tonight and (hopefully) merge.


Syntax highlighting/intellisense breaks on django template statement

The following Django template code breaks the editors auto completion and highlighting for everything within the same script tag. Note that the code does run properly when executed.

Reproduce
Start a new django project. Open a template file (e.g. Index.html) and paste it in.
I'm using the dev build: https://github.com/Microsoft/PTVS/releases/tag/dev-2016-02-01
and VS Express for Web 2015 + update 1 (for what it's worth)
Note that escaping the opening template tag '{%' fixes the issue, but of course is not valid code when executed.

I have a feeling this may be unavoidable and we just aren't able to nest code blocks inside the HTML editor, but worth looking at and passing onto the editor team.
Perhaps @int19h knows for sure?

It is a known limitation. I believe this is fixable if only because Razor does it, but I don't know how exactly to do it - right now we're mostly relying on the stock implementation of Template... stuff that we inherit from, and that results in this behavior, so we'd probably need to override or completely reimplement quite a lot of stuff to wire it up.

We have a current issue (in VS 2017) with JavaScript support not working at all in our Django editor, but once that is resolved (in Roslyn and the Editor components) we should revisit this to see what has changed.


[CH] improve HashSelectorBuilder::build by executing built-in CH functions for columnarly executing

Description
benchmark in https://github.com/bigo-sg/gluten/tree/hash_use_function
The benchmark shows no performance improvement after changing.
$ ./build_gcc/utils/extern-local-engine/tests/benchmark_local_engine --benchmark_filter="BM.*process.*Function"
2024-01-23 16:53:50.824 <Warning> SignalHandler: LD_PRELOAD is not set, SignalHandler is disabled
2024-01-23T16:53:50+08:00
Running ./build_gcc/utils/extern-local-engine/tests/benchmark_local_engine
Run on (32 X 2100 MHz CPU s)
CPU Caches:
  L1 Data 32 KiB (x16)
  L1 Instruction 32 KiB (x16)
  L2 Unified 1024 KiB (x16)
  L3 Unified 11264 KiB (x2)
Load Average: 3.84, 4.49, 8.45
------------------------------------------------------------------------------
Benchmark                                    Time             CPU   Iterations
------------------------------------------------------------------------------
BM_processHashColumnWithoutFunction     561563 ns       561536 ns         1234
BM_processHashColumnWithFunction        724578 ns       724559 ns          968

No improvement, close it.


parse recharge date time format error

The recharge parsing function in io.py, line 191 "%Y-%m-%d" should be like "%Y-%m-%d %H:%M:%S", otherwise, the datetime cannot be loaded correctly. Or, all the recharge will be categorized in xxx_recharges__xxx__night__xxx because the time will be automatically encoded as midnight.
def _parse_recharge(data):
    dt = _tryto(lambda x: datetime.strptime(x, "%Y-%m-%d"),
                data['datetime'])

Thanks for opening this issue! Recharges can indeed include time and not only date. This issue has been fixed in f7cc04d, we're now loading either date either datetime entries automatically.
Please reopen this issue if it still doesn't work on your side.


windows Start white screen

Hi, ask me a question. I see Windows fluent_ The UI project didn't start with a white screen, but I looked at the startup code and didn't see where it was set. My project started with a white screen before the financial interface. I want to ask how to deal with it, because there are few reference materials and I don't know how to deal with it. Thank you

If your project was created on some recent versions, the window should be displayed after the first frame is rendered.
https://github.com/flutter/flutter/issues/41980


worker nodes are upgraded when they have label "user.cattle.io/upgrade-policy=prevent"

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Bring up a cluster - 1 etcd, 1 control plane and 5 worker nodes.
Max Unavailable worker = 1
Power down one of the worker nodes.
Update the following in cluster.yml

    kubelet:
      extra_args:
        max-pods: '124'

The cluster goes into Updating state.
The control and etcd nodes get upgraded.
The worker node which was powered down is stuck in upgrading.
Cluster state is stuck in Upgrading status.
Now label the powered down worker node with "user.cattle.io/upgrade-policy=prevent"
The upgrade automatically goes through.
The other worker nodes get upgraded. The cluster comes to Active state.
Now power on the Powered down worker node (N1).

Expected Result:
The worker node N1 should NOT get upgraded with max-pods = 124
Actual Result:
The worker node N1 gets upgraded with max-pods = 124
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master- head - commit id: e78e43fea
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): rke DO
Kubernetes version (use kubectl version):

1.15

With the new changes for labels, once a worker only node is attempted to be upgraded and fails in any way, it will be part of the maxunavailable set unless it's fixed or removed. Applying the label will not prevent it to be upgraded.


a-marker-camera doesn't fire markerFound/markerLost events correctly.

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
markerFound and markerLost events are only fired correctly by a-marker elements. a-marker-camera element incorrectly fires a markerFound event when the program starts, and never fires a markerLost event.
From digging, I believe the reason for this is that when changeMatrixMode === cameraTransformMatrix, it sets the parent to be camera instead of scene. In arjs-anchor.js, it sets _this.object3d.visible to equal _this.object3d.parent.visible, so _this._arAnchor.object3d.visible is never anything but true.
If the current behavior is a bug, please provide the steps to reproduce.

Open https://codepen.io/laurencenairne/full/MqLapN/
Check the log, you will see one entry for 'markerFound marker'
Bring a Hiro marker in front of your camera, then remove it out of frame
No further events are triggered.
To check what I'm saying about _this.el.object3d.visible and _this.el.sceneEl.object3d.visible not updating, I added a console log at line 157 of component-anchor.js in my local version of your repo:

console.log(this._arAnchor + "'s object3D is visible:" + this._arAnchor.object3d.visible);
With  you'll see this change from false to true as you present a Hiro marker. With  it will remain true no matter what you do.

What is the expected behavior?
I'd expect  to fire markerFound and markerLost events consistently just like .
If this is a feature request, what is motivation or use case for changing the behavior?
N/A
Please mention other relevant information such as the browser version, Operating System and Device Name

Desktop PC (Windows 10)
Chrome (v.69)

As a workaround I've used a-marker and just nested my a-video element inside it which localises it's position to said marker.

Hi
if you have found the bug, and tested it, you can make a PR for that! We'll be glad to look forward to it :)

This is what worked for me. If you wrap it the marker around a camera entity it will work like the a-marker-camera.
<a-entity camera look-controls>
  <a-marker markerhandler preset='custom' type='pattern' url='assets/patterns/marker.patt'>
     <a-entity obj-model="obj: #tree-obj; mtl: #tree-mtl"></a-entity>
  </a-marker>
</a-entity>


Branch Protection - Config File

It would be quite nice if branch protection could be configured in .harness or .gitness of the repositories, rather than storing this information within the database.

Thanks for the suggestion.  The current implementation stores rules in the database for security purposes — we need to restrict branch protection rule management to repository owners and ensure regular contributors with write access could not change rules. We don't have any immediate plans to augment the approach with a file-based configuration, however, we are open to a future enhancement if we see enough demand for this capability.

When the rules are stored in Git, this could enforce PRs against the main branch; to maintain security of rules.


is it possible to change the color of checkbox & ripple

Can you please guide me on how to change the color of checkbox and its ripple. Basically I want to customize this based on our app color theme.

Hi.
You would have to add a new prop, similar to the way the disabled prop works: https://github.com/mikemonteith/react-native-android-checkbox/blob/8d72a6c42f995ad3ce795d34571dcc5e1d9a8563/android/src/main/java/com/mikemonteith/reactnativeandroidcheckbox/CheckboxManager.java#L53-L56
Have a look at this android method to change the button color
https://developer.android.com/reference/android/widget/CompoundButton.html#setButtonTintList(android.content.res.ColorStateList)

Let me know if you can create a pull request to do this, or maybe someone else will? I don't have much free time at the moment, sorry.

I've managed to find some time. Working on this now, so will hopefully have a new release tonight

If you update to react-native-android-checkbox v3.1.1, you can now use the tintColor prop.
I've noticed that the latest react-native version has a native CheckBox component so I probably won't be maintaining this library any more, however there is no color option on the native component so you can still use this one if you need color

If you wanted to use the native CheckBox, you could probably change the color with android theme settings, but I'm not sure how.

Hi @mikemonteith,
Apologize for the delay response. Somehow it got missed
I would really like to appreciate you for finding time from your busy schedule and enabling the color feature
Thanks
Pranav


BUG: accordion in games.html is not opening

The games.html has text, photo, and video content.  When you click on the accordion, it should open to show the content, but it's not working now.
See plot.html for an example of a working accordion.

assign this to me , I will work on this

Thank you @Shubhangam333 you're assigned to this issue.

#112 Raised PR for this fix


fix typo

Summary

Changes

Closes:
Task list

[ ] For workflow changes, I have verified the Actions workflows function as expected.
[ ] For content changes, I have reviewed the style guide.

fixed in #16 Thanks @kenedyolisi !


Memory manager: introduce virtual memory regions and their calculations

Add device tree entry for virtual memory.
Refactor code to make it more readable and split defines into h file.
Add region calculations to share to application.

There are compilation errors in the code you submitted.

Well thats shamefull xD I must have introduced something while doing "cosmetic" changes. Ty very much.

Had to change position for some defines so they would be visible from application.

@nashif it looks like your change request is blocking this PR, can you check the updated code?


[PlutusLedgerApi] [Refactoring] Polish imports and exports

This

resolves #6098
moves a bunch of stuff shared among V1/V2/V3 into Common (see the PR review)
makes all imports in the Common/V1/V2/V3 modules qualified so that it's clear where definitions come from and whether they are inherited from Common or an earlier ledger language
fixes some formatting, adds a definition for consistency etc

I've made imports either qualified or explicit everywhere, since that what I gauge is preferable.


Update auto-draft workflow to use pull_request_target event

Currently the auto-draft workflow is failing on PRs submitted via forks [1]
This is due to using the pull_request event, it overrides permissions in the workflow to read-only to protect you from leaking secrets etc.
The pull_request event is required when building or running code from a pull request however this workflow is admin only so we should use pull_request_target
pull_request_target allows you to use write permissions on PRs originating from forks, it allows this because it doesn't use the PR content, like a config repo operates so is safe to do so.[2]
[1] https://github.com/openstack-k8s-operators/ci-framework/actions/runs/9017563161
[2] https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

/lgtm
/approve


Code completion for "Custom OpenAI Service"

By popular demand; fixes(?) #441

This should also fix #390, where commit message generation says "Messages can only be generated with OpenAI or Azure service". I've just pushed code changes that changes that tooltip text and the readme file.

OpenAI cannot be used at the moment because we don't support placeholders for prefix and suffix. Other than that, it seems to be working fine. The cool thing about this is that you can use two different models, I was using Llama 3 for chatting and CodeLlama 70B for code completions.


Delete most source code, rely on NDTensorsCUDAExt

Waiting for Jenkins tests to become enabled (https://github.com/ITensor/ITensorGPU.jl/pull/1#issuecomment-2098269923) before merging, probably some tests relying on unexported features will need to be updated.

Tests are finally passing. @kmp5VT I'll merge and register v0.2 and we can work on simplifying the tests in a follow-up PR.


I want to denormalize the output results

I can see how to do it in the informer，but in your code I don't see the parameter，can you help me?

Hi, you can find valuable instructions here.
https://github.com/thuml/Autoformer/issues/6


replace word hybrid with bwrap

This word - hybrid - is confusing.
https://github.com/OSC/ood-documentation/blob/efbffffa131c6790602a75168840b5baf521971d/source/install-ihpc-apps.rst?plain=1#L112
Instead now, we use brwap so this line here should just use it. Additionally, it should be an anchor reference to https://github.com/containers/bubblewrap.

Duplicate of another one that's coming.


[WIP] Ndarray cumsum

Description
Fixes #13001
Numpy has cumsum - takes sum cumulatively. This PR is its NDArray API equivalent.
Changes
Comments

@eric-haibin-lin wanted your help on 2 things

implementing forward function
wanted to confirm api should look like this -

mxnet.ndarray.cumsum(data=None, axis=_Null, keepdims=_Null, out=None, name=None, **kwargs)

or
mxnet.ndarray.cumsum(data=None, axis=_Null, out=None, name=None, **kwargs)

@mxnet-label-bot add [pr-work-in-progress, Feature request]

The in_grad is equal to cumsum(out_grad[::-1])

@reminisce for review

For GPU implementation please use CUB's scan: https://nvlabs.github.io/cub/structcub_1_1_device_scan.html

@ChaiBapchya Can you address the review feedback on this PR ?

@ChaiBapchya Thank you for your contribution! Could you please look into CI failure and get this PR ready for review/merge? Thanks!

Yes. Sorry for the delay.
On Wed, 22 May, 2019, 3:15 AM Karan Jariwala<EMAIL_ADDRESS>wrote:

@ChaiBapchya https://github.com/ChaiBapchya Thank you for your
contribution! Could you please look into CI failure and get this PR ready
for review/merge? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-mxnet/pull/14354?email_source=notifications&email_token=ACT3X67D5WKCU3LG6CKZYALPWRURHA5CNFSM4G4J4FUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV5I2OQ#issuecomment-494570810,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACT3X66EA6JPV26OCXSLJ53PWRURHANCNFSM4G4J4FUA
.

@ChaiBapchya  Any update on this? This operator is used in the recent ON-LSTM ICLR paper

Apologies for delay. Out on vacation. Will resume from July 4.

Any updates on this?

Handled by https://github.com/apache/incubator-mxnet/pull/15924
Closing in favor of that PR.


Inverter output not dropping to zero when going to sleep

I have a problem that every night when my inverter goes to sleep, the output doesn't drop to zero and it stays at that reading until the inverter wakes the next morning.
I restarted the addon right before taking the screenshot, that is why it went to zero.
My inverter is connecting with bluetooth.

Found the issue. Didn't have my lattitude set to negative so Sbfspot thought I was in the northern hemisphere.
Found it in this whirpool post https://forums.whirlpool.net.au/archive/30y8rl19

Closed


Latest changes from taktik

Thanks @fthuin we will wait for our PR to be included in iure-backend before moving forward :-)

https://github.com/antoinepairet/icure-backend/pull/58


chore: add type module to documentation package.json

#152  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Add ability for local persistence for memory adapters

🚀 The feature, motivation and pitch

We want to add ability for persisting local cache for memory adapters

Code Pointer:

Where pgvector adapter's local cache is defined: https://github.com/meta-llama/llama-stack/blob/4253cfcd7f59fedd4747f706db0fff5971e7c48d/llama_stack/providers/remote/memory/pgvector/pgvector.py#L159-L179
chromadb: https://github.com/meta-llama/llama-stack/blob/4253cfcd7f59fedd4747f706db0fff5971e7c48d/llama_stack/providers/remote/memory/chroma/chroma.py#L99-L114
weaviate: https://github.com/meta-llama/llama-stack/blob/4253cfcd7f59fedd4747f706db0fff5971e7c48d/llama_stack/providers/remote/memory/weaviate/weaviate.py#L115-L142

Similar example for inline::faiss memory provider: https://github.com/meta-llama/llama-stack/pull/375

Alternatives
No response
Additional context
No response

@yanxi0830 I would like to work on this issue if that's ok?

Not a bother @dineshyv. That seems a lot simpler alright.
Should this  be implemented in weaviate as well?

I think weaviate already has fallback in case of cache miss: https://github.com/meta-llama/llama-stack/blob/4253cfcd7f59fedd4747f706db0fff5971e7c48d/llama_stack/providers/remote/memory/weaviate/weaviate.py#L151

Thanks @dineshyv.
@yanxi0830 I think this Issue can be closed as implemented.


Multi block migrations

Partial https://github.com/paritytech/substrate/issues/13690 (on_poll in https://github.com/paritytech/substrate/pull/14279).

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2922411

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2922410

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2924520

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2924521

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2924588

@kianenigma am I right to assume we'll want to make it easy to test these with try-runtime-cli? Ideally should be as easy as on-runtime-upgrade, maybe make it auto-mine blocks until all multi-block migrations are complete, & provide a hook that runs once the migration is complete?

Does this pauses user tx and incoming XCM etc? because otherwise it will be bad.

Does this pauses user tx and incoming XCM etc? because otherwise it will be bad.

It pauses non-mandatory extrinsics in frame-executive by checking a flag. For XCM we probably need a suspension and resume hook additionally.
But now that Im thinking about this again; this would make it impossible to rescue if one of the migrations errors, since governance requires things like the referenda pallet.
So maybe in the case that something errors, it could be put into SafeMode to re-allow few extrinsics.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2929015

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2929014

@kianenigma am I right to assume we'll want to make it easy to test these with try-runtime-cli? Ideally should be as easy as on-runtime-upgrade, maybe make it auto-mine blocks until all multi-block migrations are complete & provide a hook that runs afterwards?

Good to think about it early, and yes I think it is possible with little effort. I believe follow-chain will already do everything needed to test an MBM?

But now that Im thinking about this again; this would make it impossible to rescue if one of the migrations errors, since governance requires things like the referenda pallet.
So maybe in the case that something errors, it could be put into SafeMode to re-allow few extrinsics.

I sometimes wish what if setCode was Mandatory? meaning it would always surpass weight limits and so on? For a relay chain it is fine, but it could allow a parachain to stall itself by doing a bad migration that is never included on the relay chain.
Somehow detecting faulty migrations, and going into a safe-mode is def. best. Let's review and merge those as well.
As of detection, I was thinking that each migration could have a MaxDuration: Option<BN>. If set, and not finished until reached, it will raise a flag. If not set, it means it can go on for ever.

Yeah a timeout could be useful.
We should have a tool to estimate how many blocks are required to complete the migration and then we can double it and make it as the timeout and if the migration did not complete, the chain enter in safe mode only allowing governance related features

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2933961

@kianenigma am I right to assume we'll want to make it easy to test these with try-runtime-cli? Ideally should be as easy as on-runtime-upgrade, maybe make it auto-mine blocks until all multi-block migrations are complete & provide a hook that runs afterwards?

Good to think about it early, and yes I think it is possible with little effort. I believe follow-chain will already do everything needed to test an MBM?

@kianenigma moving this discussion to a new issue: https://github.com/paritytech/substrate/issues/14291

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2943938

Obviously we need to suspend everything; that's the point of splitting out on_initialize() from poll().
We need to move pretty much all on_initialize() stuff into poll(), deprecate on_initialize() and on_finalize() and hard-deadline hooks into frame_system::Config allowing low-level pallets (basically just a few consensus pallets) to be registered for special start and/or end of block processing. Ideally we would have some way of ensuring that neither such a low-level pallet nor one which it might call into did not accidentally use this MBM or mandatory-extrinsic functionality. Because of this potential for contagion, we need to discourage HDH and ME functionality functionality as much as possible.
XCM queues would be processed in poll() so XCM would automatically be paused when MBM stopped calling poll(). The same is true for Scheduler.

While migrations are executed, only Mandatory transactions are allowed to execute. This is accomplished by implementing ExtrinsicSuspenderQuery for the pallet and querying it in frame-support before each non-mandatory TX. Concretely this means that these transactions will all error and still burn the users funds. Not ideal, but a very simple solution.

Isn't it simpler to just make the migration use all the block weight until finished by returning the all weight used in on_initialize ? if a block is full only mandatory extrinsics can go in.

Isn't it simpler to just make the migration use all the block weight until finished by returning the all weight used in on_initialize ? if a block is full only mandatory extrinsics can go in.

Hm yea that would be pretty simple. Do you think this would be enough @gavofyork?
Other discussions yielded that we want a runtime API that polls the MBM state and only include non-mandatory transactions into a block when there is no MBM ongoing. But that is more complicated to implement obviously.
We can also do both... just as additional security measure, since the runtime would panic on importing a block with non-mandatory otherwise.

my only concern was this:

Concretely this means that these transactions will all error and still burn the users funds.

but frame-executive mark extrinsics as invalid and they are not included in the block then it is better than absuing the weight system.
Also if we implement a post inherent like this https://github.com/paritytech/substrate/pull/10128
then we can exhaust the weight correctly after the inherents are executed.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2994845

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3000458

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3013817

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3013903

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3017237

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3091449

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3091450

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3092219

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3092555

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3092556

Is this more or less ready for final review?

Still first need to merge https://github.com/paritytech/substrate/pull/14414. I will ping you there for review when its ready.


angular lifecycles & ionic

In ionic 3 we used ngOnInit to get the height of the element and set a max height and apply some css to make it fade out at the bottom etc.
Now with ionic 4 this same logic does not seem to work and suddenly needs a timeout of x miliseconds which is variable per device etc so not an option.
I'd assume it would be a change in angular but could also maybe be a change in the way ionic renders content now ?
Some of this content is off screen and maybe thats why they return a height of 0 because their not fully rendered yet or something.
If any one has any idea about this or another way to determine the height of an element which can vary based on the content loaded in to it  (loaded from a angular service not a server call)

Please see #16152


Video Compression

Hi!
How can i have a compression between AVAssetExportPresetHighestQuality & AVAssetExportPresetMediumQuality please ?
The quality of medium quality is too low... But AVAssetExportPresetHighestQuality size is so big
Thanks

Hi @JulienLevallois
// Theses are just shortcuts
AVAssetExportPresetLowQuality
AVAssetExportPresetMediumQuality
AVAssetExportPresetHighestQuality

/* These export options can be used to produce movie files with the specified video size.
   The export will not scale the video up from a smaller size. The video will be compressed using
   H.264 (AVC) and the audio will be compressed using AAC.  Some devices cannot support some sizes. */
AVAssetExportPreset640x480
AVAssetExportPreset960x540
AVAssetExportPreset1280x720
AVAssetExportPreset1920x1080
AVAssetExportPreset3840x2160

// New HEVC (High Efficiency video coding) format:

AVAssetExportPresetHEVCHighestQuality
AVAssetExportPresetHEVCHighestQualityWithAlpha

/* These export options can be used to produce movie files with the specified video size.
   The export will not scale the video up from a smaller size. The video will be compressed using
   HEVC and the audio will be compressed using AAC.  Some devices cannot support some sizes. */
AVAssetExportPresetHEVC1920x1080
AVAssetExportPresetHEVC1920x1080WithAlpha
AVAssetExportPresetHEVC3840x2160
AVAssetExportPresetHEVC3840x2160WithAlpha

I suggest you experiment with these to find the compression you're happy with :)
PS: Please excuse the oh so long reply 😂

Will there be a video compression change-feature in YPImagePicker soon ?
To clarify, I mean some sort of button or dropdown-menu for the user to change video compression while having the picker open. (very similar to Apple's native "Video Format Control" option that eventually shows compression-quality right there where you need it, i.e. inside the camera app when recording a video.

There is 2022 year outside🎉 Old outdated issues are closing. Please search if there are already existing issues with the same problem before opening new ☮


Set up SSSS from banners

Design will come soon at https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=5050%3A31796.
Ask the user to create a recovery key (SSSS under the shell) when they need it, ie when they have e2e rooms or messages. The algorithm for this banner should be very similar to the key backup banner we already have.

Probably the final design: https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=5499%3A11754


🔧 A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction

How were you trying to build the app?
./gradlew assembleRelease
Full build logs
i wont show any logs bc the leak sensitive security info

Project dependencies
buildscript {
    ext {
        buildToolsVersion = "34.0.0"
        minSdkVersion = 23
        compileSdkVersion = 34
        targetSdkVersion = 34
        ndkVersion = "26.1.10909125"
        kotlinVersion = "1.7.10"

React-Native Version
latest version
Target platforms
Android
Operating system
Linux
Can you build the VisionCamera Example app?
No, I cannot build the Example app either
Additional information

[ ] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

i wont show any logs bc the leak sensitive security info

sorry, can't help you then.


Disk Not Ejected Properly after wake from sleep

Hello
i am using latest 0.9.6 with the helper kext aswell
T440P RTS5227 Big Sur 11.5.2
After wake from sleep get this notification saying the disk was not ejected properly, if i plug the same SD into an SD adapter or USB the notification does not exist.
Thanks

Such behavior is expected for now.


[auto-icons] Allow any image than .png

Feature Request
Would be nice to allow any .jpeg, .bmp etc.
So I don't have to have duplicate images in different formats.
I think sharp has a toFormat function that can output .png no matter what input is used.
And add some input file option or a glob for icon path search.

JPEG's can't have transparent pixels, so if you use one you're probably breaking Chrome's guidelines if you use one: https://developer.chrome.com/docs/webstore/images#icon-size

I think sharp has a toFormat function that can output .png no matter what input is used.

Doesn't sharp(path).png() already do this? Did you try setting a custom baseIconPath?

And add some input file option or a glob for icon path search.

WXT already automatically discovers icons without the auto-icons module. Why add support for this in auto-icons? What's your use-case?

I mean if I have a base icon of .jpg. or any other. Then convert it to .png using the toFile function:
sharp(input)
  .toFile('output.png', (err, info) => { ... });

Your code only scans for .png files and not .jpg or .bmp.
What I mean is if there IS any .bpm or ,jpg or .jpeg you CONVERT them into a .png using the .toFormat function so I can keep using .jpg inside my app without having 2 files 1 for icon and 1 for using in the extension.

I would suggest having a name like icon.* to support any .jpg, .bmp, jpeg, jpg etc. then you use the .toFormat function to convert them into a VALID .png file. For only use with icons.

OK, so you just want to add glob support to baseIconPath. Sure, I'm on board with that. You wanna open a PR?

Yeah sure I can do it!
I wanna add support for JPEG (.jpg, .jpeg, .jpe, .jfif)
PNG (.png)
GIF (.gif)
TIFF (.tiff, .tif)
BMP (.bmp)
HEIF (.heif, .heic)
AVIF (.avif)
WebP (.webp) etc.
But really in the end you convert them into a .png.
I'll make a pr. 👍

It's true that transparency will not work if trying to use with .jpg etc. Then you will have to use a .png from the start. But this is just for images that do not use transparency because that doesn't make sense to use jpg if you need transparency etc..

It's true that transparency will not work if trying to use with .jpg etc. Then you will have to use a .png from the start. But this is just for images that do not use transparency because that doesn't make sense to use jpg if you need transparency etc..

Yeah, but that goes against chrome's guidelines for normalizing extension icons:

There's nothing preventing you from doing it, but it will look bad in the end.
But I'm fine with using assets/icon.* and supporting JPEG. As long as PNG and other formats that support transparency are prioritized when there are multiple matches, that's fine.

True. But yeah it's nice with options.

My solution is overwirte the module as a new module module-auto-icons.ts under modules directory
import module from "@wxt-dev/auto-icons";
import { resolve } from "node:path";
import { defineWxtModule } from "wxt/modules";

export default defineWxtModule({
  ...module,
  setup: (wxt, options) => {
    module.setup?.(wxt, {
      baseIconPath: resolve(wxt.config.publicDir, "images/icon.svg"),
      grayscaleOnDevelopment: false,
      sizes: [256, 128, 96, 48, 32, 16],
      ...options
    });
  }
});

@breadgrocery as long as you extend .wxt/tsconfig.json in your projects tsconfig, WXT automatically adds type references like that so you shouldn't have to manually add that export.

@breadgrocery as long as you extend .wxt/tsconfig.json in your projects tsconfig, WXT automatically adds type references like that so you shouldn't have to manually add that import.

No, it didn't. I even explicitly specify in the types in tsconfig.json and still don't get the typings prompt. I don't know what happened.

Hmm, interesting, works for me. Was using it earlier today 🤔. If you've got a reproduction I'd appreciate you opening a separate issue.

Hmm, interesting, works for me. Was using it earlier today 🤔. If you've got a reproduction I'd appreciate you opening a separate issue.

My srcRoot is src instead of workspace root.  And it works when srcRoot  is workspace root.
This is my tsconfig.json.
{
  "extends": "./src/.wxt/tsconfig.json",
  "compilerOptions": {
    "types": ["naive-ui/volar", "unplugin-icons/types/vue", "@types/chrome"]
  }
}

And I find out that I must configure both include and types to get it work.
I'm not very familiar with TypeScript. Is there any other way?
{
  "extends": "./src/.wxt/tsconfig.json",
  "include": ["./wxt.config.ts"],
  "compilerOptions": {
    "types": ["naive-ui/volar", "unplugin-icons/types/vue", "@types/chrome", "@wxt-dev/auto-icons"]
  }
}


Readme Typo

Readme refers to a env/databases.env but should rather state env/database.env without the "s".

Fixed in 54773b3
Thanks


New Language pt-BR

Language
pt-BR

Hi, this has now been added to Crowdin.
You can add your translations here https://crowdin.com/project/battery-notes


TM overwrites bwapi.ini

The TM spits out a hard coded BWAPI.ini, so if you want to do something like have the sound turned on, you can't edit the bwapi.ini file in the required folders. If you do, the clients will still get stuck with the hard coded bwapi from the TM (this prevents changing any other settings for the .ini file too).

This is by design, since we want to make 100% sure that the BWAPI settings are changed specifically for each game. If you want, you can request a specific feature be added to the settings file, but as long as BWAPI uses the ini file, this won't change.


Model Versioning

_Add versioning to Models such that a Publisher can publish updates, and a Consumer can see the different versions _
Assumptions:

Acceptance Criteria
Given..., when..., then...

Well, this is going to be easy since our model repository already supports this. We can even tag an arbitrary version number as Production so pipelines can just refer to this logical version tag and always execute the version the model publisher has identified as current best. You can also pin your pipeline to a specific version number

Glorious

I didn't see it documented anywhere outside of the actual mlflow code, but models:/mymodel/latest does work without doing anything extra, unlike models:/mymodel/production which would need a specific version to be explicitly set as "Production" -- do we want to allow that behavior?

Closing as stale (or done?). Users can specify a model revision in the Hugging Face connector


Cranelift: Missing SIMD fma lowering for x86_64

👋  Hey,
It looks like we don't have any lowering for the fma instruction when used with SIMD types.
.clif Test Case
function %fma_f32x4(f32x4, f32x4, f32x4) -> f32x4 {
block0(v0: f32x4, v1: f32x4, v2: f32x4):
    v3 = fma v0, v1, v2
    return v3
}

Steps to Reproduce
cargo run -- compile --target x86_64 ./the-above.clif
Expected Results
A successful compilation.
Actual Results
We don't have this implemented
thread 'main' panicked at 'internal error: entered unreachable code: implemented in ISLE: inst = `v3 = fma.f32x4 v0, v1, v2`, type = `Some(types::F32X4)`', cranelift\codegen\src\isa\x64\lower.rs:808:9
n

Versions and Environment
Cranelift version or commit: main
Operating system: Windows
Architecture: x86_64
Extra Info
In #4460 I tried to implement this using the vfmadd231ps instruction, but I had issues encoding the instruction and I'd like some help.
It looks like that instruction is only available in VEX encoding (or EVEX for avx512 but I don't have a machine with that). Is our EvexInstruction encoder suitable for emitting VEX instructions, or are they completely different? Do we have a way to emit VEX instructions?
I'm not too familiar with x86 but I'd like to pick this up with some help.
cc: @abrown

Hm, so here are some thoughts:

ideally we would have implementations of this for every possible machine, e.g., your libcall implementation in #4460, an AVX implementation for machines that have that, an AVX512 implementation for machines that have that, etc. That is a lot of work, however, so I would propose we only do two of those here: a) the libcall implementation for very old machines and b) either an AVX or AVX512 implementation for newer machines
To decide "b," it helps to understand that (apologies if you know all this) AVX instructions use a VEX encoding, AVX512 instructions use an EVEX encoding, and that currently in Cranelift we have only really implemented EVEX. Adding a VEX encoding implementation would be nice, but it's a bit of work.
That particular instruction is available for 128-bit vectors (XMMs) in both the VEX encoding under the FMA flag and in the EVEX encoding under the AVX512VL and AVX512F flags. Those AVX512 flags are usually only available on server class CPUs but the FMA flag is likely available on most recent x86 machines. So, there seems to be a decent justification for implementing VEX encodings: if we add it, we can lower fma to a single instruction on more machines than the AVX512. (On the flip side, you could implement vfmadd231ps with the EVEX encoding but then not be able to run it locally.)
To implement VEX encodings, we would need to fill in codegen/src/isa/x64/encoding/vex.rs in much the same fashion as I did for evex.rs. In this case, however, we could follow the AVX instruction format guide in section 2.3 of Intel's Software Developer's Manual, Volume 2. With that in place, we would probably need think through how to emit AVX instructions; e.g., something like  Avx512Opcode but perhaps we want to be able to decide on the VEX/EVEX encoding at a later time (?). Finally, we would need a has_fma flag in codegen/meta/src/isa/x86.rs and to plumb that through in a few places.

Hopefully that information helps. Ping me on Zulip if you want to have a more "live" discussion.


global type doesn't match type definition: ExtraField(FieldName("naming"))

I used version v0.11.5 to compile rgb20, but this error occurred. How to solve it?

`interface: RGB20
globals:
spec:
ticker: DBG
name: Debug asset
details: "Pay attention: the asset has no value"
precision: 0
terms:
text: rgb20 asset
media: ~
issuedSupply: 1000
assignments:
assetOwner:
seal: opret1st:57b640f61013abcd7a1000ed59ca3bb86cebdfc00ab9b0da756b314b3d99f835:0
amount: 1000
`
I need to modify the rgb20 yaml file so that it can be compiled and passed

Fixed in develop branch


Scale property is not working properly in certain controls like ToolTip, Flyout etc.

Describe the bug
If the Scale property is applied to a parent control of a popup, the popup does not adjust the size. When applying the transform/scale property to the popup, the popup becomes double scaled. This issue is found in ToolTip, Flyout etc.
If scaling is applied to the Combo Box, the drop-down popup is scaled but its alignment is not properly.
Steps to reproduce the bug
Sample project simulating the above scenario is attached (TestApp.zip).
TestApp.zip

Open the Test Application solution in Visual Studio 2022
Rebuild in Debug mode
In TestApp, the Scale property is applied to parent control, then verify the controls are scaled except ToolTip, Flyout, CalendarView.
Apply Scale to the ToolTip control.
Verify the ToolTip is double scaled.

Expected behavior
No response
Screenshots
•	Scale property is applied to parent control, the parent control is scaled according to the scaled value,  But the popup is not scaled.

•	Scale Property is applied to ToolTip, the popup become double scaled.

•	Scale property is applied to parent control, the parent control is scaled according to the scaled value,  But the Flyout is not scaled.

•	Scale property is applied to the Combo Box, Both Combo Box and drop-down popup is scaled but its alignment is not proper.

•	Scale property is applied to CalendarDatePicker control, the parent control is scaled according to the scaled value,  But the popup is not scaled.

NuGet package version
Windows App SDK 1.6.1: 1.6.240923002
Packaging type
Packaged (MSIX), Unpackaged
Windows version
Windows 10 version 22H2 (19045, 2022 Update)
IDE
Visual Studio 2022
Additional context
For the behavior mentioned above,
Is this the proper way to apply the Scale property to Xaml control?
Is there any solution or workaround to solve this issue?

(Not directly related, but be aware it's not really advised to use the Scale property to scale upwards unless you're in an animation, as it doesn't re-render the element at the higher scale - so you're essentially just stretching the 1x render textured to the bigger scale, whereas a RenderTransform in XAML will actually render the element at that scale)


Cut-off text below the stats table (within the "BlackMarketGUI")

The title is rather self-explanatory, so no further explanation is really needed.
The following screenshot demonstrates the issue (contained within a red rectangle):

Screen resolution: 1920x1080
This issue is highly related to #34.

Text should no longer be cut-off as of BLT release.


Bottleneck in Graph Compilation

Marking recurrent connections gets very slow once the creature phenotypes get more complicated (see image below). Need to find a way to optimise this part if possible.

Not so much a solution but something may be able to alleviate the issues, could try utilising multithreading where possible.

Fixed (for now at least) in latest commit.

Problem still exists.
Another idea for reducing the initial complexity of the generated neural networks is to change how unaligned genes (disjoint and excess) are inherited.


parse vars

only parsing functions, macros, specials

There are different types of defs.  defonce is a standard.  but defcurried is one that appears in cljs.core.reducers


Function calls don't need the sql instance.

From what I can tell, the sql instance is never accessed from a function call. Seems like we can just drop it!

+1 nice @braddunbar!  Thank you!