Loading fonts from memory

I was looking into loading fonts from memory in addition to loading from file, in order to be able to easily distribute monomer programs as standalone binaries. Since it isn't possible at the time of writing, would you consider adding this to monomer? I attempted implementing it.
What I have in this PR doesn't work unfortunately. It compiles, but the text doesn't show up (see the labels in the modified todo example below). It's my first time using c2hs, so I must have got something wrong. I'm out of expertise, so I'm calling for help if anyone is interested in doing so.
The todo changes (and an additional dependency) are only there for testing easily. These changes should be reverted when it's finally working.

Screenshot

@klausweiss I'll take a look during the weekend.
What I would check first is if the loading functions are returning a valid status code (i.e., they are not failing to load the embedded binary content). I'd also validate that the file embedding is actually happening. Finally, I'd check the chs bindings (I added a comment there).

Thanks @fjvallarino!

What I would check first is if the loading functions are returning a valid status code (i.e., they are not failing to load the embedded binary content).

They do. 0, 1, 2, 3, ... for each consecutive call to the C function.

I'd also validate that the file embedding is actually happening.

Confirmed it's working, exactly the same bytes as in the input file.

Finally, I'd check the chs bindings (I added a comment there).

I've made some progress here. I've tried to use what's in nanovg-hs for this bit: https://github.com/cocreature/nanovg-hs/blob/cc8dfa0dc18a0792786c973b4e9a232fa7d3ecfd/src/NanoVG/Internal/FFIHelpers.hs#L24-L26
Now it randomly renders some dots where the text should be on labels:

I tried explicitly allocating memory for the bytestring (updated the PR with this code), but the results are same as above - randomly rendered dots.

Ok, I got this. I think it's the nanovg-hs code that might be a bit off.
I modified nanovg-hs to use the same trick with allocating memory for the font on my own to prevent it from being garbage-collected:
copyCUStringLenMemory (from, len) =
  let intLen = fromIntegral len
  in do
    to <- mallocBytes intLen
    copyBytes to from intLen
    return (to, len)

and made the NVGcontext free the font upon destruction. The results are shown in the image below (:

I'll open a PR to nanovg-hs to fix this later.

I had a play around locally and it works for me :smile:
I wonder if there should be a pointer in the docs to https://hackage.haskell.org/package/file-embed-<IP_ADDRESS>/docs/Data-FileEmbed.html or similar (this is what I used and I assume this is intended).
Also there is appWindowIcon that might benefit from something similar, to enable fully self-contained binaries.

@klausweiss I'm really sorry I missed this. I didn't see you had switched it to a PR ready for review.
I added a couple of comments. The PR looks great!

@klausweiss you did mention switching from Draft to Ready for Review in a previous comment, I just missed it :)
All looks good for me. I added a comment about choosing between your original design for the FontDef type or the alternative I proposed and, based on what you decide, I'm ready for merging.
Thanks!

All looks good for me. I added a comment about choosing between your original design for the FontDef type or the alternative I proposed and, based on what you decide, I'm ready for merging.

Ok. I'll revert the change for the sake of not having to hand-craft the lens instance and am happy to merge afterwards. Thanks for the assistance!

Thank you for the patience!

Also there is appWindowIcon that might benefit from something similar, to enable fully self-contained binaries.

@Dretch sounds good to me, happy to do this in a separate PR. Will need a couple days to find time for that though.

Sorry @Dretch, I didn't get round to doing this eventually. It's free for anyone to pick up.


Update CONTRIBUTING.md

Added a link to a video where Entity Framework Core team members guide you through the contributing process and provide advise and good practices.
Please check if the PR fulfills these requirements

[x] The code builds and tests pass (verified by our automated build checks)

[x] Commit messages follow this format
Summary of the changes
- Added a link to a video where Entity Framework Core team members guide you through the contributing process and provide advise and good practices.
  Fixes #bugnumber

[x] Tests for the changes have been added (for bug fixes / features)

[x] Code follows the same patterns and style as existing code in this repo

Review the guidelines for contributing for more details.

Not good


[BUG] Aqara Battery not reporting for some devices

Describe the bug
Of the 7 Aqara devices I have only 2 are reporting battery level. One that is reporting is a contact sensor, but the other 2 are not reporting. The other that is reporting is a water sensor. They are each connected to a different zigbee repeater. Other non-reporting devices are connected to the same repeaters (Centralite plug) and directly to the coordinator (Conbee 2).
To Reproduce
Steps to reproduce the behavior:

Connect devices via ZHA
Allow devices to complete setup.
View Device listings

Expected behavior
Battery levels are expected to report.
Screenshots
If applicable, add screenshots to help explain your problem.
New Screenshot Sep 11, 2020 09:52 Central time
A new 3rd battery is now reporting

Old screenshot Sep 11, 2020 09:28 Central time

Additional context
I have attempted to reinstall ZHA. After deleting, but before reinstalling I deleted the entities and devices from the core.entity_registry and core.device_registry files. I have restarted multiple times. I have waited 12+hours to allow time for something to happen, but no change.
System Health
arch	x86_64
chassis	vm
dev	false
docker	true
docker_version	19.03.11
hassio	true
host_os	HassOS 4.13
installation_type	Home Assistant OS
os_name	Linux
os_version	5.4.63
python_version	3.8.3
supervisor	242
timezone	America/Chicago
version	0.114.4
virtualenv false
Radio
Conbee 2
Device Signatures
Provided in order on the screenshot
Basement Door
Zigbee info
IEEE: 00:15:8d:00:05:22:43:46
Nwk: 0x4650
Device Type: EndDevice
LQI: Unknown
RSSI: Unknown
Last Seen: 2020-09-11T09:01:54
Power Source: Battery or Unknown
Quirk: zhaquirks.xiaomi.aqara.magnet_aq2.MagnetAQ2
{
  "node_descriptor": "<NodeDescriptor byte1=2 byte2=64 mac_capability_flags=128 manufacturer_code=4151 maximum_buffer_size=127 maximum_incoming_transfer_size=100 server_mask=0 maximum_outgoing_transfer_size=100 descriptor_capability_field=0>",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x5f01",
      "in_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0xffff"
      ],
      "out_clusters": [
        "0x0000",
        "0x0004",
        "0x0006",
        "0xffff"
      ]
    }
  },
  "manufacturer": "LUMI",
  "model": "lumi.sensor_magnet.aq2",
  "class": "zhaquirks.xiaomi.aqara.magnet_aq2.MagnetAQ2"
}

Basement Drain Water Sensor
Zigbee info
IEEE: 00:15:8d:00:04:77:6c:4e
Nwk: 0x79ea
Device Type: EndDevice
LQI: Unknown
RSSI: Unknown
Last Seen: 2020-09-11T08:09:03
Power Source: Battery or Unknown
Quirk: zhaquirks.xiaomi.aqara.wleak_aq1.LeakAQ1
{
  "node_descriptor": "<NodeDescriptor byte1=2 byte2=64 mac_capability_flags=128 manufacturer_code=4151 maximum_buffer_size=127 maximum_incoming_transfer_size=100 server_mask=0 maximum_outgoing_transfer_size=100 descriptor_capability_field=0>",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x0402",
      "in_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0x0500"
      ],
      "out_clusters": [
        "0x0019"
      ]
    }
  },
  "manufacturer": "LUMI",
  "model": "lumi.sensor_wleak.aq1",
  "class": "zhaquirks.xiaomi.aqara.wleak_aq1.LeakAQ1"
}

Basement Outlet
Zigbee info
IEEE: 08:6b:d7:ff:fe:6e:47:3a
Nwk: 0xd38f
Device Type: Router
LQI: 95
RSSI: -82
Last Seen: 2020-09-11T09:46:14
Power Source: Mains
{
  "node_descriptor": "<NodeDescriptor byte1=1 byte2=64 mac_capability_flags=142 manufacturer_code=4174 maximum_buffer_size=82 maximum_incoming_transfer_size=82 server_mask=11264 maximum_outgoing_transfer_size=82 descriptor_capability_field=0>",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x0100",
      "in_clusters": [
        "0x0000",
        "0x0003",
        "0x0004",
        "0x0005",
        "0x0006",
        "0x0b05"
      ],
      "out_clusters": [
        "0x0003",
        "0x0006",
        "0x0019"
      ]
    }
  },
  "manufacturer": "Centralite Systems",
  "model": "4200-C",
  "class": "zigpy.device.Device"
}

Corner Lamp
Zigbee info
IEEE: 08:6b:d7:ff:fe:6e:6d:5e
Nwk: 0xdf8f
Device Type: Router
LQI: 255
RSSI: -47
Last Seen: 2020-09-11T09:48:10
Power Source: Mains
{
  "node_descriptor": "<NodeDescriptor byte1=1 byte2=64 mac_capability_flags=142 manufacturer_code=4174 maximum_buffer_size=82 maximum_incoming_transfer_size=82 server_mask=11264 maximum_outgoing_transfer_size=82 descriptor_capability_field=0>",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x0100",
      "in_clusters": [
        "0x0000",
        "0x0003",
        "0x0004",
        "0x0005",
        "0x0006",
        "0x0b05"
      ],
      "out_clusters": [
        "0x0003",
        "0x0006",
        "0x0019"
      ]
    }
  },
  "manufacturer": "Centralite Systems",
  "model": "4200-C",
  "class": "zigpy.device.Device"
}

Front Door
Zigbee info
IEEE: 00:15:8d:00:05:42:27:18
Nwk: 0x5cbd
Device Type: EndDevice
LQI: 255
RSSI: -45
Last Seen: 2020-09-11T09:29:18
Power Source: Battery or Unknown
Quirk: zhaquirks.xiaomi.aqara.magnet_aq2.MagnetAQ2
{
  "node_descriptor": "<NodeDescriptor byte1=2 byte2=64 mac_capability_flags=128 manufacturer_code=4151 maximum_buffer_size=127 maximum_incoming_transfer_size=100 server_mask=0 maximum_outgoing_transfer_size=100 descriptor_capability_field=0>",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x5f01",
      "in_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0xffff"
      ],
      "out_clusters": [
        "0x0000",
        "0x0004",
        "0x0006",
        "0xffff"
      ]
    }
  },
  "manufacturer": "LUMI",
  "model": "lumi.sensor_magnet.aq2",
  "class": "zhaquirks.xiaomi.aqara.magnet_aq2.MagnetAQ2"
}

Kitchen Motion
Zigbee info
IEEE: 00:15:8d:00:05:2b:3d:76
Nwk: 0x0e99
Device Type: EndDevice
LQI: 255
RSSI: -46
Last Seen: 2020-09-11T09:17:49
Power Source: Battery or Unknown
Quirk: zhaquirks.xiaomi.aqara.motion_aq2.MotionAQ2
{
  "node_descriptor": "<NodeDescriptor byte1=2 byte2=64 mac_capability_flags=128 manufacturer_code=4151 maximum_buffer_size=127 maximum_incoming_transfer_size=100 server_mask=0 maximum_outgoing_transfer_size=100 descriptor_capability_field=0>",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x0107",
      "in_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0x0400",
        "0x0406",
        "0x0500",
        "0xffff"
      ],
      "out_clusters": [
        "0x0000",
        "0x0019"
      ]
    }
  },
  "manufacturer": "LUMI",
  "model": "lumi.sensor_motion.aq2",
  "class": "zhaquirks.xiaomi.aqara.motion_aq2.MotionAQ2"
}

Living Room Motion
Zigbee info
IEEE: 00:15:8d:00:05:72:a0:7f
Nwk: 0x5bd3
Device Type: EndDevice
LQI: 255
RSSI: -50
Last Seen: 2020-09-11T09:17:58
Power Source: Battery or Unknown
Quirk: zhaquirks.xiaomi.aqara.motion_aq2.MotionAQ2
{
  "node_descriptor": "<NodeDescriptor byte1=2 byte2=64 mac_capability_flags=128 manufacturer_code=4151 maximum_buffer_size=127 maximum_incoming_transfer_size=100 server_mask=0 maximum_outgoing_transfer_size=100 descriptor_capability_field=0>",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x0107",
      "in_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0x0400",
        "0x0406",
        "0x0500",
        "0xffff"
      ],
      "out_clusters": [
        "0x0000",
        "0x0019"
      ]
    }
  },
  "manufacturer": "LUMI",
  "model": "lumi.sensor_motion.aq2",
  "class": "zhaquirks.xiaomi.aqara.motion_aq2.MotionAQ2"
}

Magic Cube 2
Zigbee info
IEEE: 00:15:8d:00:04:2d:6e:1b
Nwk: 0x3536
Device Type: EndDevice
LQI: 255
RSSI: -52
Last Seen: 2020-09-11T09:39:27
Power Source: Battery or Unknown
Quirk: zhaquirks.xiaomi.aqara.cube.Cube
{
  "node_descriptor": "<Optional byte1=2 byte2=64 mac_capability_flags=128 manufacturer_code=4151 maximum_buffer_size=127 maximum_incoming_transfer_size=100 server_mask=0 maximum_outgoing_transfer_size=100 descriptor_capability_field=0>",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x6f01",
      "in_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0x0019"
      ],
      "out_clusters": [
        "0x0000",
        "0x0003",
        "0x0004",
        "0x0005",
        "0x0012",
        "0x0019"
      ]
    },
    "2": {
      "profile_id": 260,
      "device_type": "0x6f02",
      "in_clusters": [
        "0x0003",
        "0x0012"
      ],
      "out_clusters": [
        "0x0003",
        "0x0004",
        "0x0005",
        "0x0012"
      ]
    },
    "3": {
      "profile_id": 260,
      "device_type": "0x6f03",
      "in_clusters": [
        "0x0003",
        "0x000c"
      ],
      "out_clusters": [
        "0x0003",
        "0x0004",
        "0x0005",
        "0x000c"
      ]
    }
  },
  "manufacturer": "LUMI",
  "model": "lumi.sensor_cube",
  "class": "zhaquirks.xiaomi.aqara.cube.Cube"
}

Stairwell Door
Zigbee info
IEEE: 00:15:8d:00:05:22:43:2c
Nwk: 0xb8d8
Device Type: EndDevice
LQI: 239
RSSI: -64
Last Seen: 2020-09-11T09:25:11
Power Source: Battery or Unknown
Quirk: zhaquirks.xiaomi.aqara.magnet_aq2.MagnetAQ2
{
  "node_descriptor": "<NodeDescriptor byte1=2 byte2=64 mac_capability_flags=128 manufacturer_code=4151 maximum_buffer_size=127 maximum_incoming_transfer_size=100 server_mask=0 maximum_outgoing_transfer_size=100 descriptor_capability_field=0>",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x5f01",
      "in_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0xffff"
      ],
      "out_clusters": [
        "0x0000",
        "0x0004",
        "0x0006",
        "0xffff"
      ]
    }
  },
  "manufacturer": "LUMI",
  "model": "lumi.sensor_magnet.aq2",
  "class": "zhaquirks.xiaomi.aqara.magnet_aq2.MagnetAQ2"
}

Zigbee Coordinator
Zigbee info
IEEE: 00:21:2e:ff:ff:05:ee:40
Nwk: 0x0000
Device Type: Coordinator
LQI: 6
RSSI: 3
Last Seen: 2020-09-11T09:20:38
Power Source: Mains

do you get sensor entities for battery created?

BTW, I'm not sure Centralite plugs are good routers for xiaomi. Didn't have luck with mine, as it was always falling off those.
Do you get device readings when you trigger the devices?

Confirm the devices are online and are sending the updates. They should report battery about every hour, but if they fall off the network, then you won't get the battery.
Confirm you get the sensor entities representing the battery

@dmulcahey should we add all entities associated with the device in the signature?

They are sensor battery types.

A couple more are reporting now. Maybe it is just because I have restarted several times?

I'm just now learning that Aqara devices don't play well with all repeaters.  I've read that sometimes you can put the Aqara devices in pair mode and they'll reconnect without other actions.
I'll replace the Centralite plugs with Tradfri when they get back in stock. I found them on this list: https://community.hubitat.com/t/xiaomi-aqara-devices-pairing-keeping-them-connected/623/5

after a restart it may take till next battery report (about an hour) for it to update and pop up in the device list.

@dmulcahey should we add all entities associated with the device in the signature?

We could... up to you. Doesn’t matter to me


Reshaping rank fix

Current reshapeHW function works only for 4 rank tensors, fix it to work with any rank variant

доне


Submission for challenge2024 meets erros.

I used to run the baseline code and got the submission.gz file. Then I submitted this file for the challenge20204 but met this error.

And here's my model card which was created for the submission.

创建好了模型，也登录了

为什么还是无效的命令nie捏

我的sub有2个G，这个是不是不太全

我的sub有2个G，这个是不是不太全

啊这样吗，可是我那个就是跑的这个命令啊
./tools/dist_test.sh projects/configs/bevformer/bevformer_base_occ_test.py work_dirs/bevformer_base_occ/epoch_24.pth 8 --format-only --eval-options 'submission_prefix=./occ_submission'

This is a server-side error and we are looking into it. We will back soon.

This is a server-side error and we are looking into it. We will back soon.

What about this issue now?

This is a server-side error and we are looking into it. We will back soon.

What about this issue now?

My fault, it works now.


Are there any known reasons Grafana intermittently fails with an EOF error when querying Druid with increasing frequency as it approaches real time

I am using the Druid data source for Grafana and have a query that runs every 5 seconds to retrieve and display data. The plugin seems to work fine when querying over a huge amount of historic data but will fail with increasing frequency as I query data closer to 'now' even though the total data I'm requesting is far smaller than the amount it is capable of. The error is
Unexpected EOF
I have checked the query and it is valid and I've queried the same data with the same query 10 minutes later and it worked. Can any one think of a reason why this might be happening ?
Thanks in advance

Hm, I have no real clue, but if you copy/paste that query into druid console or any other client, does it works instantly fine ? or do you have to wait 10 minutes or so as well before it works properly ? just to discard or not the grafadruid side of it.


Update core about GHCR to make unique with platfrom

PR
https://github.com/UffizziCloud/uffizzi_app/pull/167


Tab Size in Jupyter Notebook Does Not Respect Settings

Bug: Tab Size in Jupyter Notebook Does Not Respect Settings

Steps to cause the bug to occur

Go to VS Code Settings (File -> Preferences), adjust Editor: Tab Size (editor.tabSize) to a value different from 4 (I have 2).
Start an empty notebook (potentially restart VS Code) and try using the tab key
Tab size is still 4

Relevant parts of VS Code settings.json
{
    "editor.tabSize": 2,
    "editor.detectIndentation": false,
    "[python]": {
      "editor.tabSize": 2
    }
}

Actual behavior
Tab size is always 4
Expected behavior
Tab size should respect the setting editor.tabSize in VS Code
Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Local
Extension version: 2020.4.76186
VS Code version: 1.44.2
Setting python.jediEnabled: true
Python and/or Anaconda version: 3.7.6 (Conda)
OS: Windows
Virtual environment: conda

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

@alxga . Thanks for reporting this issue. As it's currently implemented the jupyter notebook is a separate webview and not a real instance of the vscode editor. While we've put in what support we can, it currently does not respect a number of editor settings and commands. While we can't solve this in the short term vscode is adding support for notebook editing as a core part of vscode so when those support comes on line this issue should be resolved.
#10496 is our issue tracking this native notebook support.

Thanks for your feedback. This issue will likely be addressed once VS Code adds native support for editing notebooks. Please see https://github.com/microsoft/vscode/issues/91987.


Error: .storage not found

Hi,
in a vue/vuex project, the build fails:
 ERROR  Failed to compile with 1 errors
This relative module was not found:
* ./storage in ./node_modules/nedb-core/lib/persistence.js

My code is as simple as:
var Datastore = require('nedb-core')

Any suggestion?
Thank you

I have a similar problem:
persistence.js:30 Uncaught Error: Cannot find module './storage'
    at webpackMissingModule (persistence.js:30)
    at new Persistence (persistence.js:30)
    at new Datastore (datastore.js:55)
    at Module../src/index.js (index.js:21)
    at __webpack_require__ (bootstrap:785)
    at fn (bootstrap:150)
    at Object.0 (Utils.js:256)
    at __webpack_require__ (bootstrap:785)
    at checkDeferredModules (bootstrap:45)
    at Array.webpackJsonpCallback [as push] (bootstrap:32)
    at main.chunk.js:1
webpackMissingModule @ persistence.js:30
Persistence @ persistence.js:30
Datastore @ datastore.js:55
./src/index.js @ index.js:21
__webpack_require__ @ bootstrap:785
fn @ bootstrap:150
0 @ Utils.js:256
__webpack_require__ @ bootstrap:785
checkDeferredModules @ bootstrap:45
webpackJsonpCallback @ bootstrap:32
(anonymous) @ main.chunk.js:1
index.js:1437

./node_modules/nedb-core/lib/persistence.js
Module not found: Can't resolve './storage' in 'C:\Daten\Projects\theme-manager\node_modules\nedb-core\lib'

This is old, but shows up in searches so I thought I would post this for anyone else that stumbles across this repo.
You probably want to use the repo that this was forked from: https://github.com/louischatriot/nedb. Depending on your needs, you might want to pick a different project altogether.
See this discussion for more info: https://github.com/louischatriot/nedb/issues/492#issuecomment-521083426


Apply pep8 rules in api and www/views

Most of the changes are simple indentation and blank lines spaces. There was
also some import fixes that shuldn't change any behavior.
Probably the biggest change was in the method has_permission() of
PatchewPermission class (api/rest.py). Firstly the use of backslash inside
braces is redundant (to break lines). So n order to remove the backslashes
and trying to make the permission conditions more readable I've tried the
following approach.
If these changes be accepted I'm willing to continue applying it on other files.

Checking the broking tests...


MIPS: No medium_level_il for cross ref

Trying to get the MLIL for a call to a function. The only cross ref that it shows is where the address of the function gets stored to a register to then be called with $t9. Getting the mlil at the jalr $t9.
Asm:
...
lw $v0, -0x7fb4($gp) {puts@GOT}
move $t9, $v0
jalr $t9
...

Attempt at getting the mlil:
>>> puts = bv.symbols['puts@GOT']
>>> refs = bv.get_code_refs(puts.address)
>>> refs
[<ref: mipsel32@0x4007d4>]
>>> func, addr = refs[0].function, refs[0].address
>>> llil = func.get_low_level_il_at(addr)
>>> llil
<il: $v0 = [$gp - 0x7fb4].d>
>>> llil.medium_level_il
>>>

In this toy example it is easy to just iterate over the block and find the MLIL_CALL that takes in that example. However, another case that i have seen would require iterating to multiple blocks between the assignment and the call.

This also applies to PPC.
Asm:
lis r11, 0x1002 {0x10020000}
lwz r11, -11888(r11) {__libc_start_main@GOT}
mtctr r11
bctr

Python:
>>> refs = bv.get_code_refs(sym.address)
>>> refs
[<ref: ppc@0x1000afa4>]
>>> func, addr = refs[0].function, refs[0].address
>>> llil = func.get_low_level_il_at(addr)
>>> llil
<il: r11 = [r11 - 0x2e70].d>
>>> llil.medium_level_il
>>>

Also still having this issue.
I can find the loads of the GOT function, but cannot find the jalr use of the loaded register -- instead I just get the phi node instruction in the exit basic block

This issue is now fixed in build 2.1.2449-dev


sanitize.css v4 plan

Good news! I’ll have some time to resolve the remaining sanitize.css issues and release v4. Here are the major changes I’m planning. I’d love your feedback.
Normalize

Everything (not reset) from normalize.css v4.

Being kept

Remove margin and padding (margin: 0; padding: 0).
Remove tapping delay (touch-action: manipulation).
Remove the text decoration on links.
Remove the list style within navigation sections.
Fills default to the text color (fill: currentColor).
Limit the resize to vertical on text areas.
Remove repeated backgrounds by default background-repeat: no-repeat.
Specify default text selection styles.
Specify default form styles.

Being removed

Don’t reset borders border-style: solid; border-width: 0;. While I really enjoy not worrying about border-style. Unfortunately, like overflow: hidden, it comes with unexpected consequences that make it not worth the benefits.
Autohiding scrollbars (-ms-overflow-style: -ms-autohiding-scrollbar;).

Being considered

Be border box aggressive (* { box-sizing: border-box; }).
Inherit all font properties (* { font: inherit; }).
Move page background to body (from :root).
Default flex to columns (flex-flow: column).
Default flex shink to 0 (flex-shrink: 0;).

Not being considered

Inherited display (display: inherit).
Hidden overflow (overflow: hidden) because it creates unexpected consequences.
Relative position (position: relative) because it creates unexpected consequences.

Default flex to columns (flex-flow: column).

I don't understand why this would be necessary. Is there any problem out there?

I was having some problems so a I made a project called sanilize.css. It is a combination of sanitize and Normalize. It also removes some unexpected rules from sanitize.css like border-style: solid; border-width: 0.
Happy to hear sanitize.css is moving on :smile:

Sweet, I agree with the list you've made, not really much to add or argue about. However I do think setting default flex values should be considered even if I though I dislike the standard value we have today for flex.

Thanks for the feedback. At this time, it seems wisest to really cut down on the resets and focus on the defaults people really want and rarely redefine themselves on any element. Things like flex-flow will be cut. FWIW, it was a default passed around Twitter and incorporated in css-layout. Check out that project to see their defaults. Let me know what you think.
I plan on sanitize.css v4 being a kind of normalize.css with border-box and sprinkled inherit to make things behave similarly, and (I think) more sanely. Again, these defaults are for things you wouldn’t intend to overwrite later. This brings margin into question, actually. As much as zeroing out margin is great for most navigations, it’s not great when you’re writing p and ul tags in your content.
I really want this to be a library that helps people build a better web based on develop preferences, but never accidentally throwing the baby out with the bathwater, as they say.

I will definitely have a closer look into this, will report with more detailed feedback.

v4 is released!


chore(functions): clean up existing helloworld samples

[x] Use dataProvider.
[x] Make test variables camelCase.

I'm going to hold off on this until #1197 is merged.

#1197 was merged - I scrapped the old PR in favor of a new branch, though.
(@grayside this one use url.)


Please How to install mangas in theme

Please Make tutorial video please

About what? How to use it? Or how to install it?
TBH, I never make/edit video before. So i don't know if i'm able to "make it" or "make it good enough"...


Issue exporting 3D Models from Scene Hierarchy

When I export a 3D model from the Scene Hierarchy, even it's in another parent, also export 3D models from other things

If you choose export "Skin Deformers", this problem will happen when you choose something that contains LimbNode, but LimbNode father or childis in other things.

It doesn't seems the problem, it's like in Unity Studio assign like Combined Root Meshes, and the 3D model I want to export it's fusioned with the other meshes, and then, causes in a broken 3D model that it's des-organizated and gives me pieces from other Combined Root Meshes

Unity combine meshes of static objects at build time. Asset contains several submeshes, and those submeshes corresponts to initial meshes in Unity. The thing is MeshFilter and MeshRenderer components knows nothing abount submesh's index, only whole mesh reference.
Other problem is about objects with same material but different texture property for this metarial still combining in same mesh. So the best you can do is export submeshes as different fbx-es and apply materials for each one separetly

I cannot seem to do that with scenes from Before The Storm. It just generated one big fbx which totally looks like a twisted up ball of geometry. I will look into this again. I'm using the latest 0.8.


Fixed issue when promises return arrays

Changed concat to push because concat partially flattens arrays but you never actually want to do that here.

Nice catch @felzix


ISSUE-74 Technical Debt

Coverage decreased (-0.7%) to 92.234% when pulling 54463cc210dbdcc2ce7b82e6fbe96cd42e577ce6 on issue-74 into 4a3dbb3a9474b78d7e9b612d0227bcaa774ab8e4 on master.


File modification time does not work

Description
It looks like last modificaiont time does not work. I always see something like 1970-01-01 00:00:00+00:00
Version Info
No response

This happens because last_modified is not added to indexing_column_types.
https://github.com/iterative/datachain/blob/f7fdf6b70f323c74f6bbf8bfb9ae08b66755d00c/src/datachain/lib/file.py#L125-L133


[Telegram] How correctly retrieve the phone number from the message?

Bot Info
SDK Platform: .NET
SDK Version: <IP_ADDRESS>
Active Channels: Telegram
Issue Description
Hi!
In Telegram it is possible to output 2 special buttons:

request_contact - If True, the user's phone number will be sent as a contact when the button is pressed. Available in private chats only;
request_location - If True, the user's current location will be sent when the button is pressed. Available in private chats only.

(this is done in a similar way https://github.com/Microsoft/BotBuilder/issues/3642)
Message from bot I get in the usual way:
private async Task MessageReceivedAsync(IDialogContext context, IAwaitable<IMessageActivity> result)
{
    var message = await result;
...

If user clicks on the button "request_location", coordinates come in the message.Entities property.
If user clicks on the button "request_contact", there is no phone number in any special property (message.Text, message.Attachments, message.Entities).
The phone number is only present in the message.ChannelData property with a bunch of other service information:
"contact":
{
	"phone_number":"...",
	"first_name":"...",
	"last_name":"...",
	"user_id": 123456789
}

How correctly retrieve the phone number?
if(
	String.IsNullOrEmpty(message.Text) &&
	message.Attachments.Count == 0 &&
	message.Entities.Count == 0
	) {

	// Looking "contact" node in message.ChannelData property
}

Or there is a more elegant solution?

This seems like a reasonable way considering where the data is stored.  What are your concerns?

@verdysh Accessing the message.ChannelData property is the correct way of getting this data.

@JasonSowers, this method seemed too cumbersome to me and I had fears that I was doing something wrong. So I decided to clarify this.
@nwhitmont, thanks!


moves to root

git hack now changes directory to the git root directory before running steps.

Super easy! Please add an integration test that starts out in a folder that doesn't exist on the main branch. Here are the respective specs for that situation when using git sync: https://github.com/Originate/git-town/tree/master/features/git-sync/folder_does_not_exist_on_main_branch

Feature test looks awesome. Thanks @aricahunter.

@aricahunter is off the project, so I'm taking this over. I have added more feature tests, and wasted another 2 hours on Git's really strange side effects on user shells when run in subshells. From my perspective this edge case is small enough to not invest more energy into this.

This stumped me for a bit but I believe the error that occurs when you run the command makes sense.
Adding -b when running cucumber gives you a much better error since it will print the full backtrace. The only error I got without -b was No such file or directory - getcwd (Errno::ENOENT) with no stack trace.
So the feature has a new_folder, but its committed. Thus when you run git-hack, new_folder is not stashed because it is not uncommitted. Thus when you try to move into new_folder on the  new-feature, you get an ENOENT.

Cool trick to use -b, this is pure gold! With your hint, I was able to make the test run by extending the GT framework to only cd into the initial directory if it exists. The problem here was that when we compile the list of steps, the directory exists, but later when the steps run it doesn't. I also added another spec where the new directory is not committed, so we cover the cases when the new directory is committed and when it is not, and git hack works beautifully in both now. Thanks for the help with this!

Committed in https://github.com/Originate/git-town/commit/94e5114e7acf695cb57f89e193bb34ddaaf1ae47


chore: add test schema library package

This commit adds the initial version of a new package, @aws-amplify/graphql-schema-test-library, which is intended to contain a collection of schemas that can be shared among teams for common validation.
cc: @alharris-at. Are there any specific schemas you'd like to see included here? I'd like to balance including schemas that codegen can test and finds useful, while not duplicating the CLI's full test suite.

Codecov Report

Merging #9562 (5eea348) into master (b653441) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9562      +/-   ##
==========================================
+ Coverage   52.59%   52.60%   +0.01%
==========================================
  Files         820      821       +1
  Lines       45518    45534      +16
  Branches     9722     9724       +2
==========================================
+ Hits        23939    23955      +16
  Misses      19577    19577
  Partials     2002     2002

Impacted Files
Coverage Δ

...s/amplify-graphql-schema-test-library/src/index.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b653441...5eea348. Read the comment docs.


find-tarballs.nix does not find all tarballs for gnu-config

Describe the bug
maintainers/scripts/find-tarballs.nix should locate all the downloads any given package relies on, but for gnu-config it fails to locate some necessary downloads.
Not sure if this is a bug in find-tarballs.nix or if this is a stylistic flaw that may appear anywhere across nixpkgs, but happened to be noticed here in the gnu-config package.
Steps To Reproduce

Pass gnu-config package to find-tarballs.nix & search the output for a specific URL that should appear.
$ nix-instantiate --json --eval --strict "<nixos-23.11/maintainers/scripts/find-tarballs.nix>" --arg expr "with import <nixos-23.11> {}; [ gnu-config ]" | python3 -m json.tool | grep -Fe 'https://git.savannah.gnu.org/cgit/config.git/plain/config.guess?id='
$ echo $?
1

Expected behavior
Instead of no matches, the specific URL should appear in the output of find-tarballs.nix.
Additional context
The missing sources are introduced in a let expression in gnu-config's derivation.
let
  rev = "28ea239c53a2d5d8800c472bc2452eaa16e37af2";

  # Don't use fetchgit as this is needed during Aarch64 bootstrapping
  configGuess = fetchurl {
    name = "config.guess-${builtins.substring 0 7 rev}";
    url = "https://git.savannah.gnu.org/cgit/config.git/plain/config.guess?id=${rev}";
    hash = "sha256-7CV3YUJSMm+InfHel7mkV8A6mpSBEEhWPCEaRElti6M=";
  };
  configSub = fetchurl {
    name = "config.sub-${builtins.substring 0 7 rev}";
    url = "https://git.savannah.gnu.org/cgit/config.git/plain/config.sub?id=${rev}";
    hash = "sha256-Rlxf5nx9NrcugIgScWRF1NONS5RzTKjTaoY50SMjh4s=";
  };
in

Instead of listing these as srcs, gnu-config's unpackPhase copies the downloaded files in.
unpackPhase = ''
    runHook preUnpack
    cp ${configGuess} ./config.guess
    cp ${configSub} ./config.sub
    chmod +w ./config.sub ./config.guess
    runHook postUnpack
  '';

There's no comment indicating why srcs was avoided in this case so if there would be a reason to do so it would be kind to document it.
I assume that find-tarballs.nix would find these properly if they were brought in by a srcs attribute, but I haven't attempted to verify that. I'm not sure find-tarballs.nix would be able to find these otherwise, but gnu-config definitely does not build without these downloads being available. So this does seem to fall within the remit (This expression returns a list of all fetchurl calls used by ‘expr’.) of what find-tarballs.nix's was intended to be able to do but doesn't in this case.
Regardless of where the bug is considered to be, this issue affects the reproducibility of nixpkgs in cases where there is no Internet connection and where the substituters and build machine haven't ever built gnu-config before.
Notify maintainers
If this is an issue in gnu-config:
@emilytrau @dezgeg
If this is an issue in find-tarballs.nix, it's not clear who the maintainers would be and it's not listed in .github/CODEOWNERS, so I'm just @ ing everyone who contributed to that script. Sorry for the spam.
@edolstra @rapenne-s @vcunat @roberth @xworld21
Metadata
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.75-1.qubes.fc37.x86_64, Debian GNU/Linux, 12 (bookworm), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/home/user/.local/state/nix/profiles/channels/nixpkgs`

Add a :+1: reaction to issues you find important.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/pre-rfc-implement-get-deps/43418/1


$componentController test helper has different DI results.

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.
Do you want to request a feature or report a bug?
I am reporting a bug.
What is the current behavior?
When using a component in angular 1.5.8 I am able to inject $element into the component controller. It works fine running in the browser. But when used in testing the $componentController's DI errors with unknown provider $elementProvider.
What is the expected behavior?
I Expect it to work in test or in the app.
What is the motivation / use case for changing the behavior?
The behavior is inconsistent.
Which versions of Angular, and which browser / OS are affected by this issue? Did this work in previous versions of Angular? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.
1.5.8
Chrome

$element, $attrs and $scope are locals that are injected into the controller. Even when using a compiled template, they are not fetched by the di. So when you call your $componentController, simply add them in the "locals" argument: `$componentController('name', {$element: yourjqLiteWrappedElement, $attrs: ...})


Design Guidelines: Supporting Cancellations and Timeouts

Write design guidelines for supporting cancellations and timeouts in Azure SDKs

[ ] .NET Guidelines
[ ] Java Guidelines
[ ] JavaScript Guidelines
[ ] Python Guidelines

done


(PUP-9448) Rephrase ILLEGAL_ASSIGNMENT_VIA_INDEX to not use a/an. add…

… period

CLA signed by all contributors.

include in single PR with multiple commits


Catch and redirect /classification and /synonyms on species pages

e.g.
http://www.gbif.org/species/100067046/classification
http://www.gbif.org/species/2333694/synonyms

Duplicate of https://github.com/gbif/portal-feedback/issues/366


chore: add vs code workspace

The current developer workflow is a bit all-over-the-place. With this PR, I want to make an end to this.
Meet: VS Code workspaces
Goal
Create a single developer experience for all core contributes.
Open the workspace with $ code workspace.code-workspace
Features
All code in one single vscode instance!

Yet... all build tasks right there when pressing CTRL+B (or F1 "Run build task")

And... all run tasks right there in the drop down!

@wmeints do you also want to take a look at this PR? Is this enough documentation to get devs started with the vscode workspace?

Good work!


Decoder error in Edge since Edge 16

Have you read the FAQ and checked for duplicate issues:
What version of Shaka Player are you using: 2.2.3
Can you reproduce the issue with our latest release version: yes, and previous versions as well
Can you reproduce the issue with the latest code from master: yes
Are you using the demo app or your own custom app: using my own, but can reproduce on demo app as well
If custom app, can you reproduce the issue using our demo app: yes
What browser and OS are you using: WIndows 10, edge
What are the manifest and license server URIs:
(you can send the URIs to<EMAIL_ADDRESS>instead, but please use GitHub and the template for the rest)
Test page was sent in email.
What did you do?
Try to play a DRM protected media
What did you expect to happen?
playback starts
What actually happened?
error is thrown from video element, no license request is sent
Additional data
since the fall creators update of Windows build 1709 with Edge 41.16299.15.0/Edge HTML16.16299 and IE11 11.15.16299.0 any PlayReady DRM playback fails with either error 3014 data [4] or error 3016, data [4, c00d3ee98].
It doesn't happen on previous windows build (1703) and previous Edge/IE11 versions.
I will send a test page that shows the issue separately via the email.

Hi @TheModMaker, were you able to observe the issue with the test page I sent?

I have reproduced your issue with the test page you sent, as well as in our demo app.  The Shaka Player error codes 3014 and 3016 tend to indicate decoder errors.  The MS-specific error code (c00d3e98) seems to indicate a decoder failure as well.
I have not analyzed the content itself, but this could be a regression in Microsoft's decoders.  I'm not sure what you can do to debug further in Edge.  I suggest you file a bug with Microsoft here: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/
If you file a bug with MS and share the bug link with me, I can forward it to some folks at Microsoft who may be able to help you further.

Someone from Microsoft just informed me that the error code c00d3e98 is a media error about an unsupported format.  You should definitely file a bug with Edge and link back to it here so we can help get it to the attention of the right people.

Our friends at Microsoft reproduced the bug with your test page, and have filed an internal bug on this, reference ID 14554354.  Hope that helps!

@joeyparrish thank you so much!!! is there any external reference I can get to the internal reference ID?

Not that I have been able to find.  But if you file a bug of your own, you can reference that in the report, so that Microsoft can link the two together.  Through your own filing, you may be able to get status updates from them when they solve the issue.

@OrenMe Could you say what tools you are using to package/encrypt the media when you are having these issues?
I am encountering the same issues with media from Shaka Packager, but have been able to get successful playback in Edge 16 with DASH CENC(Widevine + PlayReady) content from Bento4.
@joeyparrish Would you have any more insights into what the actual issue is here, and if there might be any changes in the media packaging/encryption that could work around this issue?

Thanks @joeyparrish. One of the big differences I can see in the media from Shaka Packager vs from packagers where playback is working, is that from Shaka Packager, the first 2 segments are not encrypted(clear), where as in the other cases I have been testing all segments are encrypted.

Interesting.  You can control that clear lead in Shaka Packager.  Are you willing to re-package some content to test that theory?  Try with --clear_lead 0 if you're using the command-line packager.  (The default is 10s.)

It looks related to https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12658991/.  We have a workaround in Shaka Packager to make it work in Edge 15 by swapping the order of sinf and avcC boxes. Looks like this is broken in Edge 16 too. @joeyparrish We should talk to our friends at Microsoft again about this long time bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12658991/.

@joeyparrish @kqyang I just re-packaged my content with --clear_lead 0 and confirm I am now getting successful playback in Edge 16.

I am having same issue on Edge, IE after Fall Creator Update. It is hard to re-package contents since I have many contents. Is there any solution without re-packaging contents?
If there is any update please share information. Thanks.

I am having same issue on Edge, IE after Fall Creator Update. It is hard to re-package contents since I have many contents. Is there any solution without re-packaging contents?
If there is any update please share information. Thanks.

@leejonghyeon0106, since the issue is in Edge/IE/Windows, there's nothing Shaka Player can do to fix it.  Please leave a comment on the external bug report and ask Microsoft for solutions/workarounds: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12658991/

@joeyparrish @kqyang Did you ever here anything further from the Edge team on this?

@zshenker I heard that they already had it fixed in latest Edge (Windows Insider) and they are investigating providing fixes to older versions of Edge, but I haven't verified myself. Can you test and verify if it is really fixed?

The latest copy of Edge I have is Edge/16.16299, on which I can still reproduce the error.

The external issue is still in an open state: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12658991/

If it is fixed, it should be in their later Feb or March release, i.e. in release 17xxx. 16299 is released last September.

I have Edge/16.16299(Win10) browser and had problems with plaready protected dash content. This issue gave me a solution, it is a packager not encrypting the first segment. Quick fix was to change startNumber="2" and content worked but 10s was skipped in the start. Unfortunately I have no control of the packager so must contact the provider.

I have tested the page included in the internal bug report referenced with ID 14554354 and it seems to be working on Edge 17 preview
I will be setting something up to reproduce this the external bug https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12658991/ -- since I read above they are pretty related, hopefully that one will be resolved too..
I am keeping my eye on this...

We have others reporting that this has been fixed in the latest release of Edge.  Please update!


Bump requirements

Bump requirements

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Blocked, We should generate a new cassette for adyen.

We can update all requirements except for Adyen and open a task to bump Adyen later.

We can update all requirements except for Adyen and open a task to bump Adyen later.

But the main goal of this task is to update Adyen because the old version not working correctly.

But the main goal of this task is to update Adyen because the old version not working correctly.

OK 👍

OK 👍


Double-click on a table in search results opens 'Model root' tab

System information:

Windows 10 64 bit
DBeaver <IP_ADDRESS>908041900

Connection specification:

DB2

By searching for a table in a database connection, double-clicking on it from the results list opens up a '#root' tab instead of opening the table for viewing/editing.

Can't reproduce. Could you write a bit more details.

Does context menu work on search results?
Please post a screenshot of results table
Are there anything related in debug/error log? https://github.com/dbeaver/dbeaver/wiki/Log-files

I think it happens when you have results from multiple schemas.

is it still actual?

It still happens sometimes

A quick workaround is right click + Edit

there is no update on ticket for a long time, it will be closed.
if it is still actual for you - feel free to reopen the ticket


Hurtworld OnPlayerChat hook breaks if a message is null

This may only be an issue with Covalence, I just need to check it out.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Is this still an issue? Tried both OnUserChat and OnPlayerChat in a covalence plugin and OnPlayerChat in a HW plugin and I was unable to reproduce any errors with the hook.

I'm not sure, I tested yesterday and couldn't reproduce it, so I'm not sure what was causing it before.

Closing as I can no longer reproduce this.


spacing between search bar and language button

There is less spacing between the search bar and the language when on mobile version. I would like to work on it

Thanks, you are assigned!

Actually, the screenshot you took is from "the old website". The homage is still in that infrastructure and we don't plan to do any work in there.
The new homepage is being developed by @erickzhao in this Pull Request and its preview.
I'll close this issue as it is out-of-scope, but if you see any problems in that PR please let us know!


add Graf-Anton-Günther-Schule

Link to the website: https://gymnasium-gag.de/
Proof of a long-term CS course: https://gymnasium-gag.de/?p=618 (see Sekundarbereich II (Jg. 11/12-13))
For proof of the email domain see point 6 of this document.

@mavolin Pull request merged. Thank you!


replace read_column! macro with generic

Hi @andygrove, this is sparked by the comment that I saw on your PR in arrow. I've managed to replace the read_column macro with a generic function. I hadn't looked at the binary macro, but can take a stab at it if this is useful so far.

I forgot to mention, the tests pass, I've added null handling for reference, but don't have a parquet file to test right now. Might also need rustfmt as I don't have it yet on this machine.


RFC: Real World Commerce Example

It would be great to see a more complete picture how would Next.js can be used with multi currency, multi country store (different stock sources) with a larger catalogue with at least 20 categories of products with amount of products enough to demonstrate pagination, dynamic filtering etc. While current demo does demonstrate the basics it does not give a glimpse to a real world solution and approaches to scaling it. I believe such demo would be more pursue more developers to take next.js in consideration when building an online store.

Absolutely, are you willing to draft the spec with me?

Absolutely, are you willing to draft the spec with me?

Absolutely, are you willing to draft the spec with me?
Sure, currently I am working on porting a store to Next.js that has all of the above mentioned features and more. So I can hopefully can contribute by sharing my experience so far.

Absolutely, are you willing to draft the spec with me?
Sure, currently I am working on porting a store to Next.js that has all of the above mentioned features and more. So I can hopefully can contribute by sharing my experience so far.

As a reference: https://www.vuestorefront.io

As a reference: https://www.vuestorefront.io

@timuric Golden, feel free to use this space. Will open an RFC soon.

@timuric Golden, feel free to use this space. Will open an RFC soon.

Cool. I would brake down all features in separate comments.
Feature: Multi country store
Any store that operates in multiple regions would have a country selector which would have an impact on at least few essential things:
• Currency & Price
• Delivery info
• Stock availability
Similar the way Next.js handles language preferences it would be necessary to detect default country the user is based and apply these settings in cookies and reflect them in the URL path. Similar to language it would be necessary to automatically select appropriate country without having it explicitly in the URL.
Consider a case where a product is featured in social media ads or a tweet, customers normally would be automatically directed to a relevant store for their region.
As an example a link on social media would look like: https://demo.vercel.store/product/lightweight-jacket and would redirect users to something like this https://demo.vercel.store/[country]/[language]/product/lightweight-jacket
Country detection is not as trivial as a language locale which sent by the browser, however some CDNs like Cloudflare do provide country info in headers when proxying the request to the application server, hopefully this can be achieved with Vercel as well.

Cool. I would brake down all features in separate comments.
Feature: Multi country store
Any store that operates in multiple regions would have a country selector which would have an impact on at least few essential things:
• Currency & Price
• Delivery info
• Stock availability
Similar the way Next.js handles language preferences it would be necessary to detect default country the user is based and apply these settings in cookies and reflect them in the URL path. Similar to language it would be necessary to automatically select appropriate country without having it explicitly in the URL.
Consider a case where a product is featured in social media ads or a tweet, customers normally would be automatically directed to a relevant store for their region.
As an example a link on social media would look like: https://demo.vercel.store/product/lightweight-jacket and would redirect users to something like this https://demo.vercel.store/[country]/[language]/product/lightweight-jacket
Country detection is not as trivial as a language locale which sent by the browser, however some CDNs like Cloudflare do provide country info in headers when proxying the request to the application server, hopefully this can be achieved with Vercel as well.

Example of dynamic and static data on the page:
Consider a product page where mostly data is static with few exceptions like Wishlist aka Favorite button
A straightforward solution would be to use getServerSideProps to get user specific state of that button, however that would downplay all static generation benefits that most of us like about in Next.js.
At this point there is no guide about how to best mix dynamic and static data and perhaps it is something that yet to come in form of a new feature, but it would be great to at least have an example that can be used as reference.
Here is a reference to a relevant discussion:
https://github.com/vercel/next.js/discussions/11424#discussioncomment-281713

Example of dynamic and static data on the page:
Consider a product page where mostly data is static with few exceptions like Wishlist aka Favorite button
A straightforward solution would be to use getServerSideProps to get user specific state of that button, however that would downplay all static generation benefits that most of us like about in Next.js.
At this point there is no guide about how to best mix dynamic and static data and perhaps it is something that yet to come in form of a new feature, but it would be great to at least have an example that can be used as reference.
Here is a reference to a relevant discussion:
https://github.com/vercel/next.js/discussions/11424#discussioncomment-281713

Consider a case when navigation and footer have elaborate data structures with images and lots of categories. For example: https://www.gucci.com/
How would one decide to fetch such components, with current setup it would mean that navigation and footer data would be fetched with every page request, which is pretty wasteful.

Consider a case when navigation and footer have elaborate data structures with images and lots of categories. For example: https://www.gucci.com/
How would one decide to fetch such components, with current setup it would mean that navigation and footer data would be fetched with every page request, which is pretty wasteful.

Hi
I'm building Multi currency and Multi language store using vercel and Big commerce. the only issue currently I'm having is nextJS is blocking calls to location API so multi-currency and multi-language are not working see link below
https://commerce-hupmzfomo.vercel.app/

Hi
I'm building Multi currency and Multi language store using vercel and Big commerce. the only issue currently I'm having is nextJS is blocking calls to location API so multi-currency and multi-language are not working see link below
https://commerce-hupmzfomo.vercel.app/

Nextjs is not blocking you. It's browser behaviour. If you access geoip by https (you are using http). It will work

@eclipse3161  did you ever get your multi-currency working?

Yes  ---- On Sun, 13 Jun 2021 14:14:38 -0700  @.***  wrote ----
@eclipse3161  did you ever get your multi-currency working?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

Yes  ---- On Sun, 13 Jun 2021 14:14:38 -0700 @.*** wrote ---- @eclipse3161 did you ever get your multi-currency working? —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

How did you get the cart to work? With bigcommerce my cart always returns in the default currency

Hey there! Thank you for your contribution. We have decided to take Next.js Commerce in a new direction and will be closing out current PRs and issues due to this change. Please see this PR for more details: #966


Spans not exported to Zipkin with property 'spring.sleuth.sampler.probability' set to value 1

I'm developing application using Spring Boot (2.1.4) running on Kubernetes.
Spans from my application aren't exported to Zipkin while property 'spring.sleuth.sampler.probability' is set to value 1.
[2019-05-17T09:59:07.083Z][http-nio-8080-exec-9] TRACE; [service,71283846f6dd8fc3c096c1eae7e35142,8b3124a796b24061,false] ; org.springframework.cloud.sleuth.log.Slf4jScopeDecorator; Starting scope for span: 71283846f6dd8fc3c096c1eae7e35142/8b3124a796b24061
[2019-05-17T09:59:07.083Z][http-nio-8080-exec-9] TRACE; [service,71283846f6dd8fc3c096c1eae7e35142,8b3124a796b24061,false] ; org.springframework.cloud.sleuth.log.Slf4jScopeDecorator; With parent: -4569251557263847102
[2019-05-17T09:59:07.109Z][http-nio-8080-exec-9] TRACE; [service,71283846f6dd8fc3c096c1eae7e35142,8b3124a796b24061,false] ; org.springframework.cloud.sleuth.log.Slf4jScopeDecorator; Closing scope for span: 71283846f6dd8fc3c096c1eae7e35142/8b3124a796b24061

I set this property via Consul and verified via Actuator (endpoint actuator/configprops) that it is set properly:
                "spring.sleuth.sampler-org.springframework.cloud.sleuth.sampler.SamplerProperties": {
                    "prefix": "spring.sleuth.sampler",
                    "properties": {
                        "probability": 1
                    }
                },

Is there any additional property/header/configuration that could prevent sending spans by Sleuth to Zipkin?

I'm more than certain that you're trying to trace an endpoint that is ignored by default. Where do you send your request to?

Below are example requests (logs from Istio-proxy sidecar container):
[2019-05-17T12:19:49.949Z] "POST /api/admin/dictionaries/pages HTTP/1.1" 200 - "-" 78 1036 151 148 "<IP_ADDRESS>" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.157 Safari/537.36" "e0b550fe-269c-467f-bd87-cec5fe7bba26" "test.env:31380" "<IP_ADDRESS>:8080" inbound|8080|http|service.services.svc.cluster.local - <IP_ADDRESS>:8080 <IP_ADDRESS>:0 -
[2019-05-17T12:20:02.100Z] "GET /api/admin/dictionaries/1 HTTP/1.1" 200 - "-" 0 57 24 22 "<IP_ADDRESS>" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.157 Safari/537.36" "5f037a6c-ceff-42e2-8e28-34afd2925a1a" "test.env:31380" "<IP_ADDRESS>:8080" inbound|8080|http|service.services.svc.cluster.local - <IP_ADDRESS>:8080 <IP_ADDRESS>:0 -
[2019-05-17T12:20:02.105Z] "POST /api/admin/dictionaries/1/values/pages HTTP/1.1" 200 - "-" 79 1851 68 67 "<IP_ADDRESS>" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.157 Safari/537.36" "08ac4ef6-96f0-460b-a052-e9ba01e89718" "test.env:31380" "<IP_ADDRESS>:8080" inbound|8080|http|service.services.svc.cluster.local - <IP_ADDRESS>:8080 <IP_ADDRESS>:0 -
[2019-05-17T12:20:02.238Z] "POST /api/institutions/pages HTTP/1.1" 200 - "-" 99 459 42 42 "<IP_ADDRESS>" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.157 Safari/537.36" "ff4bc751-a19e-458c-bf65-cbfa5e439254" "test.env:31380" "<IP_ADDRESS>:8080" inbound|8080|http|service.services.svc.cluster.local - <IP_ADDRESS>:8080 <IP_ADDRESS>:0 -

Doesn't istio already set the tracing headers?

Yes, Istio already sets tracing headers as below:
2019-05-17 13:14:51.072 TRACE [microservice-example,3cec6bab7c68679f458d44c09de3286c,10f5ce0b6ca21bbb,false] 7 --- [nio-8080-exec-6] o.s.c.sleuth.log.Slf4jScopeDecorator     : Starting scope for span: 3cec6bab7c68679f458d44c09de3286c/10f5ce0b6ca21bbb
2019-05-17 13:14:51.074 TRACE [microservice-example,3cec6bab7c68679f458d44c09de3286c,10f5ce0b6ca21bbb,false] 7 --- [nio-8080-exec-6] o.s.c.sleuth.log.Slf4jScopeDecorator     : With parent:<PHONE_NUMBER>406549612
2019-05-17 13:14:51.077 DEBUG [microservice-example,3cec6bab7c68679f458d44c09de3286c,10f5ce0b6ca21bbb,false] 7 --- [nio-8080-exec-6] o.s.w.f.CommonsRequestLoggingFilter      : Before request [uri=/api/admin/dictionaries;headers=[host:"test.env", user-agent:"PostmanRuntime/7.13.0", accept:"*/*", cache-control:"no-cache", postman-token:"3d2efef2-44cf-4394-990b-d9b167af56bc", accept-encoding:"gzip, deflate", content-length:"20", x-forwarded-for:"<IP_ADDRESS>", x-forwarded-proto:"http", x-request-id:"3f8a319f-c6b2-4d70-8192-8f9cfb9db1cb", x-envoy-internal:"true", x-b3-traceid:"3cec6bab7c68679f458d44c09de3286c", x-b3-spanid:"10f5ce0b6ca21bbb", x-b3-parentspanid:"458d44c09de3286c", x-b3-sampled:"0", Content-Type:"application/json;charset=UTF-8"]]
2019-05-17 13:14:51.081  INFO [microservice-example,3cec6bab7c68679f458d44c09de3286c,10f5ce0b6ca21bbb,false] 7 --- [nio-8080-exec-6] p.c.b.e.c.c.TestHttpsContriller          : Received request for /api/admin/dictionaries endpoint
2019-05-17 13:14:51.083 DEBUG [microservice-example,3cec6bab7c68679f458d44c09de3286c,10f5ce0b6ca21bbb,false] 7 --- [nio-8080-exec-6] o.s.w.f.CommonsRequestLoggingFilter      : REQUEST DATA: uri=/api/admin/dictionaries;headers=[host:"test.env", user-agent:"PostmanRuntime/7.13.0", accept:"*/*", cache-control:"no-cache", postman-token:"3d2efef2-44cf-4394-990b-d9b167af56bc", accept-encoding:"gzip, deflate", content-length:"20", x-forwarded-for:"<IP_ADDRESS>", x-forwarded-proto:"http", x-request-id:"3f8a319f-c6b2-4d70-8192-8f9cfb9db1cb", x-envoy-internal:"true", x-b3-traceid:"3cec6bab7c68679f458d44c09de3286c", x-b3-spanid:"10f5ce0b6ca21bbb", x-b3-parentspanid:"458d44c09de3286c", x-b3-sampled:"0", Content-Type:"application/json;charset=UTF-8"]]
2019-05-17 13:14:51.085 TRACE [microservice-example,3cec6bab7c68679f458d44c09de3286c,10f5ce0b6ca21bbb,false] 7 --- [nio-8080-exec-6] o.s.c.sleuth.log.Slf4jScopeDecorator     : Closing scope for span: 3cec6bab7c68679f458d44c09de3286c/10f5ce0b6ca21bbb

Does this mean that Istio should sends this span to Zipkin on behalf of microservice if it sets tracing headers?

You need to set the sampling in istio, it is likely marking the traces as not sampled through the headers it generated

Yup @devinsba is right. The request comes in to a spring sleuth application already ubsampled .

Default value of PILOT_TRACE_SAMPLING environment variable was set to 1.0
Thanks!


Removeal of jQuery - how to bind grid?

Describe the problem your feature will solve.
I like that you are talking about removing jQuery. Great.
How do you bind to a dom node? Is this possible now?
$('#myGrid').w2grid({}) - replace this with what?
tried
const grid = new w2grid({});
const node = document.querySelector("#myGrid");
grid.render(node);
and a few other variants.
no dice.

(I know you still need jQuery etc now, we don't use jQuery anywhere else and would like to use this "directly" not as a jQuery plugin)

After evaluating the removal, it appears that it would not be as easy, nor do I think will bring much benefit. JQuery is a quality lib and it is very actively supported. Respect to jQuery team. At least query selector part of it (sizzle) is more advanced than css selectors). However, the effort is made to make w2ui  ES6 native. Work is being done in this regard quite a bit.
Here is by the way an example how ES6 native w2ui will look like https://github.com/vitmalina/w2ui/blob/master/es6mods/start.js,

For 1.5.x version, here is a starter project that shows how to use it with ES6 modules w2ui-srater

Ok will try your querySelectorAll example, I assume that's what you meant. I tried with the actual node I guess you're saying render() needs a nodelist and not a node/element. Will try that out next week. Thank you for the information.

It needs a node, not list, my bad. Please modify the code

Removing jQuery is a bad decision that has in my opinion no reason.
Why remove jQuery ? I don't see a good reason ...
Better decoupling ui and data sources would be a good thing.

@LucaGabi removing JQuery is something that has been requested by some users over the past few years. But that does not mean it will happen anytime soon. As Vitali already pointed out, it would be a huge task with very little benefit.


Hydrostatic balance

Your forecasting system used 13 levels instead <=5 in others similar systems
The hydrostatic balance equation can greatly improve your system.
You could add to the loss function the hydrostatic balance discrepancy in each of the layers:
( (Tv_i+Tv_{i+1})/2 + g/R * (H_{i+1}-H_{i}) / log(p_{i+1}/p_i) )^2 -> min
where
g = 9.8065 m/s^2 is the gravitational acceleration
R = 287.04 is gas constant for air
Tv [K] = T [K] *(1+Q [kg/kg]/(Q + R/Rv)) is virtual temperature
Rv = 461.51 is gas constant for vapor

Thanks for the suggestion! Yeah, I can try adding that. I'm hoping to train these models on even more levels and variables than in the paper, and at a finer resolution.

@all-contributors please add @byphilipp  for ideas


filtering over night hours, winter months

The current implementation of the filter doesn't allow a user to select over night hours or winter months.
Possible solutions: switch to box selections instead of a brush for each month/hour, or switch to a radial plot.

switch to a radial bar chart for hours and months

example of circular brushing

example of radial toggle for months


Newest a.16 update breaks theming.

After updating zen-browser. I noticed that some of the elements were unthemed, the only one I know so far is this:

I'm not experienced in theming, so I am unaware of whats causing this issue. Any further assistance is greatly appreciated.

Hi @undefinedcode0,
I just updated my Zen Browser to latest a.16 version, however I see no impact on my Catppuccin Setup:

Could please confirm if you have any theme Zen Mod installed? (try disabling all mods, to see if this gets resolved)
Or have you been tinkering with the new Zen's Customize Theme option?

Hi @undefinedcode0,
I just updated my Zen Browser to latest a.16 version, however I see no impact on my Catppuccin Setup:

Could please confirm if you have any theme Zen Mod installed? (try disabling all mods, to see if this gets resolved)
Or have you been tinkering with the new Zen's Customize Theme option?

No, I don't have additional Zen Mods installed. I kept the theming as is and I have not tinkered with it.

Not sure if this will help but, every time I relaunch the browser. The theming works perfectly fine until the selected page is loaded. https://i.imgur.com/t6bXzo2.gif

Mmmm, based on that behavior it seems there is some CSS overwriting the Catppuccin Theme.
What I can see is that:

Catppuccin Theme loads first
Then a second CSS overwrites it once Zen fully loads.

That is why we see it flashing for a second there.
I have tested with a brand new profile as well on my end and no issues could be found.
Troubleshooting
Browser Theme
Make sure you have selected the Dark (or light if you would like to use Latte)  theme selected in your Zen Browser, you can view it in about:addons > Themes

Custom CSS / Mod / Custom Theme
To discard any possible custom CSS affecting the browser can you test the theme in a Brand New Zen Profile?
You can click on your Profile Picture in the Zen Toolbar and click the "+" symbol to create it.

Then apply the Catppuccin Theme to this profile, if it works, then this tell us there could be some custom CSS, Mod or Theme affecting your Catppuccin Theme
Let me know the results!

Mmmm, based on that behavior it seems there is some CSS overwriting the Catppuccin Theme.
What I can see is that:
1. Catppuccin Theme loads first

2. Then a second CSS overwrites it once Zen fully loads.

That is why we see it flashing for a second there.
I have tested with a brand new profile as well on my end and no issues could be found.
Troubleshooting
Browser Theme
Make sure you have selected the Dark (or light if you would like to use Latte) theme selected in your Zen Browser, you can view it in about:addons > Themes

Custom CSS / Mod / Custom Theme
To discard any possible custom CSS affecting the browser can you test the theme in a Brand New Zen Profile?
You can click on your Profile Picture in the Zen Toolbar and click the "+" symbol to create it.

Then apply the Catppuccin Theme to this profile, if it works, then this tell us there could be some custom CSS, Mod or Theme affecting your Catppuccin Theme
Let me know the results!

Yes, I had made sure I'm using dark mode for the 'mocha' theme. After applying the theme to a new profile. The theming issue still persists either way. The only temporary fix I know of is switching Dark mode off and on.

Something that I recently discovered is that opening a Private Window fixes the CSS override issue. I'm not sure what is overriding CSS, but I'll look into it.

After looking more further into the root directory of my profile folder, userContent.css and userChrome.css seem to be the only *.css files present.

Thanks for your reports @undefinedcode0 @SolsticeSpectrum ,
It finally affected me as well, so I do not have to make guesses anymore:

Interestingly only on MacOS, Linux seems to be working fine so far.
Now I am curious, what platform are you on?
I will take a look at this later today, probably pushing an update tonight.

Im on Windows 10 IoT LTSC 21h2 x64

Can confirm this is also happening to me on Linux (Arch, KDE Plasma 6.2, Wayland - if any of that matters), but switching to another theme in about:addons then back to the default Dark theme fixes it for me as well.

I am on Windows 11

Hey everyone!
Just pushed an update that should fix this issue, please test it and let me know your results.


Incorporate callback function to handle exceptions in objective functions

At the moment, if an evaluation of the objective function crashes, the whole optimiser crashes. This is a problem especially with global optimisers such as DifferentialEvolution when they sweep a large parameter space. Adding a callback function to the optimisers would allow us to handle these exceptions.
We need to decide on how to implement them, but in any case we should let the users implement their own if they choose so.

Is this still a problem and if so can you provide an example

Let's hold it for now, as this problem has not surfaced for a while so we don't have a specific example to use.


some remapping choices

There are two remapping changes that would make playing Metroid Returns a lot better with controllers.

An option to make R2 and L2 buttons work as mirrors of the R1 and L1 buttons respectively (this would help on many games that don't support R2 and L2.
Making the right analog stick work as combination of the left stick and the L1 button. (this would only help with metroid returns but some other games would take advantage of it with a different button as the camera toggle).

I would also add to this to be able to swap the RT/RB/LT/LB mappings so that the analog triggers would map to L and R and the shoulder buttons would map to ZR and ZL, basically opposite of their current mapping.  For games like Mario Kart 7 and Super Smash Bros, the mapping of the X-Input controller feels backwards compared to playing on the system itself or playing similar games with a Game Cube controller.


SWARM-1116: Health API has moved to another package

Align with changes in master

Depends on https://github.com/wildfly-swarm/wildfly-swarm/pull/398

Needs to be tested when core is merged. Locally examples passes

retest this please

FYI, this still won't pass until the main CI build has completed and -deploy CI has done

ok, thanks for the heads up

i'll merge it tomorrow morning

retest this please

retest this please


Feature: change db session handling after_request to middleware

There is no guarantee that downstream users will not overwrite the after request hook, so the best way to manage is by wrapping send in middleware.
e.g.,:
class DBSessionMiddleware(MiddlewareProtocol):

    def __init__(self, app: ASGIApp) -> None:
        self.app = app

    async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
        if scope["type"] == "http":
            async def send_wrapper(message: Message) -> None:
                if message["type"] == "http.response.start":
                    if 200 <= message["status"] < 300:
                        await AsyncScopedSession.commit()
                    else:
                        await AsyncScopedSession.rollback()
                    await AsyncScopedSession.remove()

                await send(message)

            await self.app(scope, receive, send_wrapper)
        else:
            await self.app(scope, receive, send)

Closed in 0963119ebd508101fc3054afd80545e6d695386c


Update "Commits" API reference in "About protected branches" docs

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-status-checks-before-merging
What part(s) of the article would you like to see updated?
The link in the Require status checks before merging section of the About protected branches page says "Repositories", but refers to "Commits" part of the API docs.
I think it should say "Commits" instead of "Repositories". Also, I think we should update the link to more specific part of the docs - commits/statuses.
Additional information
No response

@fstavela Thank you for opening an issue and linking it to your PR! ✨


Fix build

Apparently microsoft broke the URLs that "vscode" 1.1.28
was using to download vscode.d.ts.

BTW, the so-called guide for migrating away from the "vscode" module is at https://code.visualstudio.com/api/working-with-extensions/testing-extension#migrating-from-vscode

Thank you for your contribution !


cannot add ipv6 address on debian

Hi,
I'm evaluating your module to see if I could use it both on debian and redhat. And If I could at the same time enable IPv6.
Unfortunately, it seems that adding an IPv6 address in the debian interfaces file does not work because this is duplicating the interface name :
adding the following :
iface eth0 inet6 static
    address 2001:db8::c0ca:1eaf
    netmask 64
    gateway 2001:db8::1ead:ed:beef

yelds this :
$ puppet resource  --debug --modulepath puppet/ network_config
Debug: Runtime environment: puppet_version=3.7.4, run_mode=user, ruby_version=1.8.7
Debug: Failed to load library 'selinux' for feature 'selinux'
Error: Could not run: Malformed debian interfaces file; cannot instantiate network_config resources`

The parser seems OK If I replace eth0 with eth1 or eth0:6, but debian is not and there is no IPv6 address configured.
Am I doing something wrong ?

kinda surprised i haven't run into this.

I've run into the same issue, but in my case, it was trying to use the module for an interface where both ipv4 and ipv6 are defined (the default in rackspace cloud)
The offending line is:
iface eth0 inet static
    address <IP_ADDRESS>
    netmask <IP_ADDRESS>
    gateway <IP_ADDRESS>
iface eth0 inet6 static
    address 2001:4801:7819:74:be76:4eff:fe11:8a7a
    netmask 64
    gateway fe80::def
    dns-nameservers <IP_ADDRESS> <IP_ADDRESS>

and the resulting error is:
Feb 20 14:06:41 cp2-test200215133412 puppet-user[31226]: Wrapped exception:
Feb 20 14:06:41 cp2-test200215133412 puppet-user[31226]: invalid address

we'll have to add the inet-family to the namevar.

I'm working on a partial fix that will probably never get merged (b/c the real fix sounds really complicated). It basically just ignores ipv6 entries when there are duplciates. I'll share when I'm done, but this is more of a temporary fix so that I can move on ;)

yea, i looked into a quick-fix myself, however, i think we'll have to extract the interface into its own variable, that is not name…

This looks like a duplicate of #99, so closing in favor of that.


Startup script repl

#391

what is step-by-step the workflow for using this? That should be mentioned in the README.
I would think invoking something from Nvim would be more useful, rather than making the user choose from a list.

I updated the README. I don't know if this is already enough documentation.
I would also prefer the invocation through nvim, but it has one flaw:
When I use the :term feature to start a terminal and then e.g. IPython I am perfectly able to connect to the current instance. But the current buffer (the one i get using nvim.current.buffer) is the terminal buffer wher IPython runs and not the one I wanted to modify through the REPL initially.
Hope this gif makes it a little bit clearer:

Actually, I don't think it makes sense to put this in pynvim repo. Most pynvim users won't have the scripts/ AFAIK. So if anything this should be a plugin or maybe contrib/ in the neovim repo.

Ok, what would you think of putting it in the pynvim module or in a submodule and not as a startup script but as a function?
If you think it's not worth the hassle that`s also fine. Just found it easier to use than the standard procedure.

Ok, what would you think of putting it in the pynvim module or in a submodule and not as a startup script but as a function?

That was my first thought. I guess it makes sense because then Nvim core only needs to look for that function. The function can be mentioned by nvim_set_client_info. I think open_repl might be a good name.


[bug] 5.3.3 breaking typescript

same as #507

Seems that something goes wrong in the automatic release, that doesn't happen when building locally, will investigate.

Upgraded the CI infra, and that seems to fix the issue, should be fixed in 5.3.4


Resolves: Add GitHub Codespaces configuration

ready-to-start GitHub Codespaces configuration with all necessary tooling

in addition, it provides basic tools for:

.NET development
GitHub support
overall more pleasant VS Code experience

The configuration consists of:

"image": - a declaration of the Docker image that the Codespace container is created from (this is a list of images and code examples that work with GitHub Codespaces)

"mcr.microsoft.com/vscode/devcontainers/dotnet:0.201.7-3.1" - the Codespace container runs from an Ubuntu 20.04 image with .NET Core SDK installed (0.201.7 is the latest .NET Core SDK Docker image tagged version)

"settings": - a list of VS Code settings to be applied automatically after the Codespace container is created (.editorconfig overrides these)

"workbench.colorTheme": "Default Dark+" - sets the theme of the VS Code workbench to the Default Dark+ theme
"terminal.integrated.defaultProfile.linux": "pwsh" - sets the default VS Code terminal to PowerShell Core

extensions: - a list of VS Code extensions that are automatically installed after the Codespace container is created

"eamodio.gitlens" - provides git information directly inside the code
"ms-dotnettools.csharp" and "VisualStudioExptTeam.vscodeintellicode" - provide basic Visual Studio tooling
"ms-vscode.powershell" - provides the functionality of Windows PowerShell ISE inside VS Code
"cschleiden.vscode-github-actions" and "redhat.vscode-yaml" - provide YAML and GitHub Actions support
"bierner.markdown-preview-github-styles" and "ban.spellright" - provide assistance with writing Markdown documentation
"jmrog.vscode-nuget-package-manager" - provides use of the NuGet library through the Command Palette
"coenraads.bracket-pair-colorizer" - sets different colors for each nested pair of brackets
"vscode-icons-team.vscode-icons" - provides a huge set of icons for the VS Code explorer
"editorconfig.editorconfig" - attempts to override user/workspace settings with those in the .editorconfig

"postCreateCommand" - is a string of commands separated by && that execute after the container has been built and the source code has been cloned

This GitHub Codespace configuration can also be used locally with the Remote - Containers extension for VS Code. It automatically creates and runs a Docker container based on the devcontainer.json configuration inside the repo, so anyone could work on the project from any computer, without the need to install anything other than VS Code and Docker.
Resolves #982

We tried to build the projects with the Contribution instructions on the following platforms: Ubuntu 20.04 (Codespace & GHA) и Windows Server 2019 (GHA). These errors appear on every single platform.

Closing as API Port was deprecated in favor of binary analysis in .NET Upgrade Assistant.


Occasional crash at WebPImageCreateWithData

Met an unusual crash.

Any idea on what happened?

Crashed here

Crashed here

Hello, have you solved this problem? I also encountered this problem, can you tell me how to solve it?

Crashed here

Hello, have you solved this problem? I also encountered this problem, can you tell me how to solve it?

Hello, I tried to upgrade libwep to v1.2.0, but I am not sure if the problem could be solved since it's an unusual crash. Need to observe for a while

@skyxian @kimi14314 At what probability does it happen in production? I need more information to investigate into it, such as os version, more detailed stack traces etc.

"EXC_BAD_ACCESS · Attempted to dereference null pointer"
Seems to be a multi-thread problem. Probability is about 1% in production.

"

Has this problem been solved?  I also encountered this problem in production（KingfisherWebP version = 1.3.0 ,device model: = iPhone 8p，os = 14.7.1）, but i couldn't reproduce.

Has this problem been solved?  I also encountered this problem in production（KingfisherWebP version = 1.3.0 ,device model: = iPhone 8p，os = 14.7.1）, but i couldn't reproduce.

It shouldn't be a multithreaded problem, since webp decoding is totally a blocking operation. From this stack trace I assume it might be caused by some memory pressure. How much memory used and left on the device when this crash occurred?

Has this problem been solved?  I also encountered this problem in production（KingfisherWebP version = 1.3.0 ,device model: = iPhone 8p，os = 14.7.1）, but i couldn't reproduce.

It shouldn't be a multithreaded problem, since webp decoding is totally a blocking operation. From this stack trace I assume it might be caused by some memory pressure. How much memory used and left on the device when this crash occurred?

Thanks!
Your guess may be correct.

Is there any solution to this problem

这个问题解决了吗？我在生产中也遇到过这个问题（KingfisherWebP version = 1.3.0 ,device model: = iPhone 8p，os = 14.7.1），但无法重现。

它不应该是一个多线程问题，因为 webp 解码完全是一个阻塞操作。从这个堆栈跟踪我认为它可能是由一些内存压力引起的。发生此崩溃时，设备上已使用和剩余多少内存？

谢谢！
你的猜测可能是正确的。

is there any solution，When the memory is low

any update here? same issue at low memory case

Previously, the use of webp was closed due to a crash. After the recent two versions were opened, this crash ranks in the top two positions. I can provide the following information. Can the author help analyze how to solve it?

Previously, the use of webp was closed due to a crash. After the recent two versions were opened, this crash ranks in the top two positions. I can provide the following information. Can the author help analyze how to solve it?

![w4r6ZgROS3](https://github.com/yeatse/KingfisherWebP/asset

s/9349361

The crash seems to have occurred in models below iphoneXR，And it all happens in the WebPAnimDecoderDelete(dec) method

Actually this crash comes from the previous line: memcpy(bufCopy, buf, bufsize);. As we discussed earlier, this is fundamentally an out-of-memory issue, that we failed to copy the decoded image buffer for future use. In my personal experience, memory issues are more likely to occur on devices with 3GB RAM. For more details on this topic, please refer to this article.
To resolve this crash and prevent similar issues in the future, you should pay close attention to your app's overall memory usage. Here are a couple of methods that can help:

Set Kingfisher's memory cache to a lower limit: https://github.com/onevcat/Kingfisher/wiki/Cheat-Sheet#cache
Add a ResizingImageProcessor after WebPProcessor to downscale your result image

I will release a new version later that returns a null image instead of crashing when low memory occurs; however, it is still important for you to implement these changes.
@skyxian

Thank you very much, I will modify the existing code according to your suggestion, and look forward to your new release version

Released 1.4.1

现实上这个崩溃来自上一步：以memcpy(bufCopy, buf, bufsize);备将来使用。根据我的个人经验，内存问题更可能发生在配备了3GB RAM的设备上。有关于此主题的更多详细信息，请参阅附件。
要解决此崩溃并阻止将出现类似问题，您应该密切注意应用的整体内存使用情况。以下是一些可以提供帮助的方法法：

将 Kingfisher 的内部存储设置为下载：https ://github.com/onevcat/Kingfisher/wiki/Cheat-Sheet#cache
添加一个ResizingImageProcessorafterWebPProcessor以缩小小结果图像

之后我会发布一个新版本，它会返回一个空间图像，而不是在内存不及时崩溃；但是，实际应用这些更改对您来说仍然很重要要。
@skyxian

"添加一个ResizingImageProcessorafterWebPProcessor以缩小小结果图像"
是这样设置吗：
options?.append(.processor(ResizingImageProcessor(referenceSize: size)))
options?.append(.processor(WebPProcessor.default))

现实上这个崩溃来自上一步：以memcpy(bufCopy, buf, bufsize);备将来使用。根据我的个人经验，内存问题更可能发生在配备了3GB RAM的设备上。有关于此主题的更多详细信息，请参阅附件。
要解决此崩溃并阻止将出现类似问题，您应该密切注意应用的整体内存使用情况。以下是一些可以提供帮助的方法法：

将 Kingfisher 的内部存储设置为下载：https ://github.com/onevcat/Kingfisher/wiki/Cheat-Sheet#cache
添加一个ResizingImageProcessorafterWebPProcessor以缩小小结果图像

之后我会发布一个新版本，它会返回一个空间图像，而不是在内存不及时崩溃；但是，实际应用这些更改对您来说仍然很重要要。
@skyxian

"添加一个ResizingImageProcessorafterWebPProcessor以缩小小结果图像"
是这样设置吗：
options?.append(.processor(ResizingImageProcessor(referenceSize: size))) options?.append(.processor(WebPProcessor.default))

Resizing 放 WebP 后面

这两个调换下先后  webp动图就不动了

这两个调换下先后 webp动图就不动了

1.5.2 版本之后动图可以使用 AnimatedImageView 了，会自动根据 View 的实际大小压缩图片