Inefficient Node Class Provisioning

Description
Observed Behavior:
Karpenter does not seem to make very intellegent choices on how to provision node classes. It seems to just select the cheapest choice without understanding cluster wide imbalances. In my case, Karpenter selects many c7i.24xlarge, occasionaly choosing c7i.48large. It has no interest in the r7i's and m7i's because they are more expensive? As my cluster scales, the imbalance between cluster cpu utilization (70%~) and memory utilization (95%) grows larger. This means im wasting almost 30% of my cluster cpu which is actually the more expensive component of ec2's vs the memory.
Expected Behavior:
Karpenter to scale intelligently, using all available instance-family types to maintain a healthy cpu vs memory utilization ratio.
For example it may realize it should scale 3 c7i's down to 2 r7i's, saving $
Reproduction Steps (Please include YAML):
---
apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
  name: dev-48s
spec:
  providerRef:
    name: eks129
  consolidation:
    enabled: true
  weight: 9
  labels:
    provisioner: m7is
  requirements:
    - key: "karpenter.k8s.aws/instance-family"
      operator: In
      values: ["c7i", "r7i", "m7i",]
    - key: "karpenter.k8s.aws/instance-size"
      operator: In
      values: ["24xlarge", "48xlarge",]
    - key: "topology.kubernetes.io/zone"
      operator: In
      values: ["us-east-1a", "us-east-1b", "us-east-1c", "us-east-1d", "us-east-1f",]
    - key: "kubernetes.io/arch"
      operator: In
      values: ["amd64"]
    - key: "karpenter.sh/capacity-type"
      operator: In
      values: ["on-demand"]
    - key: kubernetes.io/os
      operator: In
      values:
        - linux
  kubeletConfiguration:
    maxPods: 250
  limits:
    resources:
      cpu: "17280"

Versions:

Chart Version: 0.32.4
Kubernetes Version (kubectl version): 1.29

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

For the example given, I checked and the OD price for 3x c7i.24xlarge is cheaper than 2x r7i.24xlarge.  Can you provide some more specifics with the resources requested (e.g. output of kubectl describe node the-node-name)?

Im seeing
3 * $4.284/hour (c7i.24xlarge) = $12.852 / hour -> https://instances.vantage.sh/aws/ec2/c7i.24xlarge
2 * $6.350/hour (r7i.24xlarge) = $12.7 / hour -> https://instances.vantage.sh/aws/ec2/r7i.24xlarge
That wasnt the best example because the numbers end up being very close but the main idea here is karpenter seems to not have a cluster perspective of instance family imbalances.
With my provisioner yaml, i end up with 50+ c7i's, 0 r7i's, 0 m7i's. My CPU utilization is around 68% and my memory utilization is 97%. I expect karpenter to understand that there is a lack of balance and instead have cluster utilization of around 90% cpu and 90% memory.
As a work around i have to add a new provisioner with a higher weight (10), a small spec.limits.resources.cpu, and only include one instance family (r7 or m7). This work around is manual and requires constant tuning as i have to take a guess at how many m7's or r7's i need to achieve the 90% cpu and 90% memory balance.
Without the workaround, my bill is significantly higher than it needs to be :(

I see your numbers now, not sure what I was looking at previously.

With my provisioner yaml, i end up with 50+ c7i's, 0 r7i's, 0 m7i's. My CPU utilization is around 68% and my memory utilization is 97%. I expect karpenter to understand that there is a lack of balance and instead have cluster utilization of around 90% cpu and 90% memory.

Karpenter is optimizing for cost, not reducing waste in the cluster.  To do this, when it consolidates it will either:
a) replace 1-N nodes with a single node

Quick follow up question that's been a bit unclear to me:
In the considerations for "replace 1-N nodes with a single node" does that kick in if the replacement costs exactly the same in terms of stated costs, e.g. will Karpenter try to replace two m5.4xlarge with a single m5.8xlarge if it's able otherwise to provision both? In my case, since we don't right size our daemonsets, 8xlarges are more efficient for us, in practice though we seem to see Karpenter not "combining up" to larger nodes, even though fewer is better for us.

I haven't seen that behavior @dlmather. I agreed that it would be beneficial.


Data Pipelines: Backend

This depends on #116. Once we can parse a data pipeline out of a query, we need to do something useful with it.

This was fully implemented by #127. Will file follow-on issues for extending support in a few ways.


Revert "Allow assisted parameters of the same type"

This is a manual revert of
12cfeac1fa03282b59f56522b2c2649da7066f27. Some files have
diverged too much making automated revert hard.
Closes #81. Closes #121. Closes #140.

I had no idea what I'm doing

Is this simply going back to the previous implementation where qualifier annotations are required when providing multiple items of the same type (instead of matching by parameter name)?

Yes. Incremental annotation processors mean you can never rely on parameters names being present. If you don't want to create an annotation, you can use @Named("foo").

@JakeWharton fine if I release 0.6.1 with this change?

Waiting on #158 to land

It is very much not a patch release, either, since it dramatically changes the behavior.

Cool, will leave it to you then


Create XeonMedia

This workflow is going to do a neat installation of node dependencies, cache/restore it all.
name: Node.js CI
on:
push:
branches: ["main"]
pull_request:
branches: ["main"]
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Set up Node.js
  uses: actions/setup-node@v4
  with:
    node-version: '16.x'

- name: Install dependencies
  run: npm install || yarn install

- name: Build the project
  run: npm run build --if-present

fearless.js


Include update command when vue-cli can be updated

What problem does this feature solve?
There are so many different update syntaxes around these days it's hard to keep up with all of them.  It would be great if vue-cli follows the example of node and npm and when an update is available also provide the exact command needed to update.
What does the proposed API look like?
-- An update is available.  Use this to update:
npm install -g @vue/cli

Working on that: https://github.com/vuejs/vue-cli/pull/3926

Landed in v4.


New Data format with more information in Travel Planner

Hello @clearminds! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file custom_components/hasl3/haslworker/__init__.py:

Line 223:80: E501 line too long (111 > 79 characters)
Line 243:80: E501 line too long (86 > 79 characters)
Line 245:80: E501 line too long (105 > 79 characters)
Line 246:80: E501 line too long (91 > 79 characters)
Line 247:80: E501 line too long (118 > 79 characters)
Line 254:80: E501 line too long (99 > 79 characters)
Line 255:80: E501 line too long (82 > 79 characters)
Line 256:80: E501 line too long (89 > 79 characters)
Line 258:80: E501 line too long (120 > 79 characters)
Line 259:80: E501 line too long (101 > 79 characters)
Line 260:80: E501 line too long (133 > 79 characters)
Line 263:80: E501 line too long (86 > 79 characters)
Line 264:80: E501 line too long (86 > 79 characters)
Line 265:80: E501 line too long (84 > 79 characters)
Line 266:80: E501 line too long (84 > 79 characters)
Line 267:80: E501 line too long (109 > 79 characters)
Line 268:80: E501 line too long (92 > 79 characters)
Line 269:80: E501 line too long (99 > 79 characters)
Line 276:80: E501 line too long (82 > 79 characters)
Line 277:80: E501 line too long (82 > 79 characters)
Line 280:80: E501 line too long (87 > 79 characters)
Line 281:80: E501 line too long (106 > 79 characters)
Line 285:80: E501 line too long (87 > 79 characters)
Line 286:80: E501 line too long (104 > 79 characters)
Line 300:80: E501 line too long (92 > 79 characters)
Line 301:80: E501 line too long (83 > 79 characters)
Line 304:1: W293 blank line contains whitespace
Line 306:80: E501 line too long (84 > 79 characters)
Line 309:80: E501 line too long (95 > 79 characters)
Line 312:80: E501 line too long (97 > 79 characters)
Line 321:38: E111 indentation is not a multiple of four
Line 321:38: E117 over-indented
Line 323:38: E111 indentation is not a multiple of four
Line 323:38: E117 over-indented
Line 325:38: E111 indentation is not a multiple of four
Line 325:38: E117 over-indented
Line 327:33: E265 block comment should start with '# '
Line 346:80: E501 line too long (95 > 79 characters)
Line 376:80: E501 line too long (80 > 79 characters)
Line 380:80: E501 line too long (90 > 79 characters)
Line 383:80: E501 line too long (127 > 79 characters)
Line 500:80: E501 line too long (86 > 79 characters)
Line 535:80: E501 line too long (86 > 79 characters)
Line 630:80: E501 line too long (81 > 79 characters)

Will now close due to inactivity and new conflicts.


Output of emojis seems to be somewhat broken

Expected Behavior
I am seeing some odd character output with certain emojis. Not all emojis, but certainly some, are not being output correctly.
Current Behavior
When asking Llama2 model to respond using mostly emojis, some are output as follows:

🏋\u200d♀💪🏼👟🥊🚀🎉🤩👍

The \u200d plus the female symbol seems to be some kind of encoding issue
Environment and Context
llama-cpp-python Version: 0.1.77 (latest at time of writing)
Python Version: 3.11.4
Platform: Apple M1 Macbook 16GB
Llama2 Model: llama-2-7b-chat.ggmlv3.q4_1.bin via https://huggingface.co/TheBloke/Llama-2-7B-Chat-GGML
Steps to Reproduce
Here is a basic example, using the model file noted above, that seems to reliably re-create the issue
from llama_cpp import Llama

prompt = """
[INST] <<SYS>>
You are a helpful, respectful and honest assistant. Always answer as helpfully as possible, while being safe.
<</SYS>>

Show me a list of fitness related emojis.[/INST]
"""

llm = Llama(
    model_path="models/llama-2-7b-chat.ggmlv3.q4_1.bin",
    n_gpu_layers=1,
    n_ctx=2048,
    n_batch=512,
    f16_kv=True,
    verbose=True
)

llm(prompt=prompt)

Produces the following output:

{'id': 'cmpl-61a22458-6094-4ebc-9498-eac52c29570d',
'object': 'text_completion',
'created':<PHONE_NUMBER>,
'model': '/Users/thomas/Hobbies/fff-pledge/llama-2-7b-chat.ggmlv3.q4_1.bin',
'choices': [{'text': '🏋\u200d♀💪🏼👟🥊🚀🎉🤩👍',
'index': 0,
'logprobs': None,
'finish_reason': 'stop'}],
'usage': {'prompt_tokens': 58, 'completion_tokens': 40, 'total_tokens': 98}}

I have tried multiple versions of the llama2 model, from TheBloke, and despite the overall performance differences, the specific issue I am seeing remains.

I've been doing some further digging and the issue may be related to the underlying way the models are generated using llama.cpp
I have run a similar test just using the llama.cpp console interactive mode application, thus taking llama-cpp-python out of the equation, and have had similar results:
I'm pasting a screenshot below because pasting the chars here, they seem to be getting lost:

Specifically, look at the "person meditating" emoji, and it has the same female symbol adjacent to the emoji as well as the placeholder chars where my terminal has no idea what the character should be.
However, this comment in the llama.cpp repo would suggest that there may be an implementation fix that could resolve the problem here:
https://github.com/ggerganov/llama.cpp/issues/2231#issuecomment-1646723003
I have zero idea where to even start in this codebase to see if thats an applicable fix, but if any of the maintainers here would point me to the right place to get started, I'd be willing to give it a bash.

It would seem like this might be the cause: https://github.com/abetlen/llama-cpp-python/blob/66fb0345e8ade77d8eb3ae8103d1954e9a88d7ef/llama_cpp/llama.py#L1053
It attempts to decode each individual token, in this case the byte is part of a multibyte sequence. It errors (which is ignored) and you end up with a blank text representation of the token. We could put in a patch as suggested above but I don't know if that goes against the design intent for this function.

Related: https://github.com/abetlen/llama-cpp-python/issues/372


Update project from database - Schema Compare always ignores logins

Version: 1.48.0-insider (user setup)
Commit: 8a715ed3b1e87153e46651b920367170564eb376
Date: 2024-02-15T12:58:00.069Z
VS Code: 1.82.0
Electron: 25.9.8
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631
Steps to Reproduce:

Create a database and add this to it:

CREATE LOGIN [Apps_login] WITH PASSWORD = '***'
GO

CREATE USER [Apps_user] FOR LOGIN [Apps_login]
GO

Create a blank new database project
Update project from database
In the Schema Compare window, the SqlUser is the only thing that shows, even if I go into Options and check the box for Login and everything else
Apply changes result in build error: SQL71501: SqlUser: [Apps_user] has an unresolved reference to SqlLogin [Apps_login].

If I create a project directly from database, the login is there.


Check that a column name is a certain data type

Describe the feature you'd like
I would love to enforce rules in the warehouse that if a column is called "LOAD_TIMESTAMP" it has to be TIMESTAMP_NTZ data type.
Additional context
Just good to apply rules for a large team.

@culpgrant the check-name-contract should do the trick for this! Try this hook:
- id: check-column-name-contract
   args: [--pattern, "LOAD_TIMESTAMP", --dtype, TIMESTAMP_NTZ]

Closing this but feel free to reopen if this doesn't solve your case.


Added questions functionality.

deleted:    blog/migrations/0007_auto_20191220_0300.py
new file:   blog/migrations/0007_post_isquestion.py
new file:   blog/migrations/0008_answer.py
modified:   blog/models.py
modified:   blog/static/blog/main.css
new file:   blog/templates/blog/answers.html
new file:   blog/templates/blog/ask_question.html
modified:   blog/templates/blog/base.html
modified:   blog/templates/blog/home.html
modified:   blog/templates/blog/post_detail.html
modified:   blog/templates/blog/post_form.html
modified:   blog/templates/blog/user_post.html
modified:   blog/urls.py
modified:   blog/views.py

[ ] Fixes issue #41 : "Add features to ask a Question"
[x] Other checks

Reason for pull request:
"o add questions functionality"
Description of changes or additions:
"Posts model has new column isQuestion"
"New model 'Answer' created"

Screenshots:
"Insert screenshots here if available"

@Kartik-Sama The questiona answer template is good for me. Few changes:

The question asked should not be displayed in the blog forum. Good to have a separate question forum where all the questions and answers should be displayed and the option to add new question should be available. Rename the "Ask Question" to Question forum.
I think there should be no option to add comments to any question.

@deepak2431, I have done corresponding changes, please review the PR.
Thank you.

@Kartik-Sama Awesome work! Thanks :)


Possible Enhancements: Usage of quad-frames instead of bi-frames

Here is a possible way of improving DAIN:
Instead of getting frame X-1 and frame X+1 to get frame X, what about frames X-3, X-1, X+1 and X+3?
With that it can enhance accuracy by acquiring more context, but that leads to some problems:
what if some of the frames are from different scenes? what should it do?
Are there already scene identification for bi-frame interpolation within DAIN?

It surely can benefit from more source images. You can find some from Xiangyu's paper or my previous work. Scene change detection is not difficult to do.


Update dep

Webpack 2.2 Final
Latest Angular

Coverage remained the same at 100.0% when pulling efa5a10308941d60dfcf22685418c6bd4c56600c on update-dep into 8bd542ffc78eff8f3504a0dfc67919737d80b079 on master.

Coverage remained the same at 100.0% when pulling 717da9ae2acffc6c5e6714195c6002cd344534f8 on update-dep into 8bd542ffc78eff8f3504a0dfc67919737d80b079 on master.

Coverage remained the same at 100.0% when pulling 717da9ae2acffc6c5e6714195c6002cd344534f8 on update-dep into 8bd542ffc78eff8f3504a0dfc67919737d80b079 on master.

Coverage remained the same at 100.0% when pulling eb3447962735145214b6ac95aa8e5ebd7efe5e07 on update-dep into 8bd542ffc78eff8f3504a0dfc67919737d80b079 on master.


feat(mcclient): add k8s cluster monitor component disable option

What this PR does / why we need it:

Does this PR need to be backport to the previous release branch?:

release/3.7

/area climc

/lgtm

/approve


Place shared_bundle_XX.html files at the right level and allow configuring it

Today I tweaked bundle.js in my installed polymer-build module and started to play with minEntrypoints option to test how it works.
Here is the issue I faced: now, my shared bundles include paths like src/components/app/my-app/my-app.html, while real path to shell will be just components/app/my-app/my-app.html.
In short, it would be nice to have shared_bundle_1.html and others (actually I have 20 shared bundles for minEntrypoints = 3) placed into the separate directory rather than project root.
The reason is my app architecture: I believe that placing bower_components inside of the src is not a good idea and so I do some tricks.

index.html is located inside of the src directory, while bower_components dir is outside:

root/
|
|--src/
|    |--components/
|    |--images/
|    |--index.html
`--bower_components/

For production, I have slightly different structure:

root/
|
|--components/
|--images/
|--bower_components/
`--index.html

To make this work, after bundling I use the following copy task to put them into dist:

function copyVulcanized () {
    return gulp.src([
       VULCANIZE_CACHE + '/src/components/app/**/*-app.html',
       VULCANIZE_CACHE + '/src/components/pages/**/*-page.html'
    ], { base: VULCANIZE_CACHE + '/src' })
    .pipe(gulp.dest(GULP_CACHE))
    .pipe($.size({
        title: 'vulcanize'
    }));

Those files listed via globs are shell and fragments (as of now, bundled build also contains lots of other stuff, see this issue).
In order to have shared bundles working, I need to rewrite paths somehow, because shell links, as well as assetpath attributes (and maybe other rewritten stuff too), are pointing to the src directory, which does not exist in production build.
But placing shared bundles in the right place would end up with relative paths like ../../my-app/my-app.html, which is exactly what I want to reach.
What about making directory for shared bundles configurable? @usergenic WDYT?
/cc @FredKSchott as this path for shared bundles should be passed as some option from polymer-project-config, as well as minEntrypoints number.

@web-padawan we don't actually recommend putting bower_components inside src/ in any of our templates, so your source setup isn't very odd, except for maybe index.html being inside `src/. We may or may not need to shore up options around the entrypoint file to make that work in all tools, but it should be ok.
However, I'd really recommend against changing the layout of your files between development and production. The main reason is that if relative paths change like that, then tools are going to not be able to find files in one of the two environments, and you'll need many fragile fixups of your source to change paths from development to production.
For instance, index.html would have paths like ./components/my-app.html in development that would need to change to /components/my-app.html in production. Or if you choose to use production paths, then tools like the bundler and linter won't find the files.
If you just keep your development layout at production, you can avoid all that work.
Is there a reason why you can't do a layout like:
root/
|--index.html
|--src/
|    |--components/
|    |--images/
`--bower_components/

Well, now when you're back from vacation I'm going to clarify my reasoning here.
You are totally right about keeping development layout in production.
I wasted some time when dancing with assetpath RegEx etc.
In fact, the only reason is that we are using docker and no one had provided a setup for Polymer projects by the time when I started migrating the project I'm working on from Polymer 0.5
So, we actually mount some directories from the host machine to container, and for production, our dockerfile looks like this:
FROM nginx:1.11.0-alpine

COPY dist/ /var/www/my-app/
COPY nginx/ /etc/nginx/

And for development we just mount another directory, which looks like this:
        volumes:
        - ./src/:/var/www/my-app/
        - ./vendor/:/var/www/my-app/vendor/
        - ./nginx/:/etc/nginx/

Atually I'm not sure about how to rewrite it better, because I'm not really want to mount project root directory too, and for sure I need to keep existing folder structure, without rewriting any imports.
BTW, there was a question in Slack about official docker image recently. And I think this might be useful to have one in the future.

What if we just place shared bundles at the same level as shell is located? That would be quite enough.
IMO, this also makes sense because users might want to process bundles at some point and globs like components/my-app/**/* would be fine in this case.

This should be easy enough when https://github.com/Polymer/polymer-bundler/issues/483 and https://github.com/Polymer/polymer-build/pull/189 both land.

Here's how you can do this with the new stuff (on master - about to release)
const {generateCountingSharedBundleUrlMapper} = require('polymer-bundler');

mergeStream(project.sources(), project.dependencies())
    .pipe(project.bundler({
      // This mapper generates shared bundle files at:
      // `path/to/shared/bundle_1.html`, `path/to/shared/bundle_2.html`
      urlMapper: generateCountingSharedBundleUrlMapper('path/to/shared/bundle_')
    });

If this won't solve for your issue, please re-open

This works fine, thanks! 👍
Just decreased gzipped shell size from 291 Kb to 166 Kb, thanks to excluding large imports like ace and d3 and placing them to separate bundles.
Actually I have 45 bundles with following snippet:
        .pipe(project.bundler({
            strategy: bundler.generateShellMergeStrategy(polymerJSON.shell, 4),
            urlMapper: bundler.generateCountingSharedBundleUrlMapper('src/components/shards/bundle-')
        }))


Remove RawGit dependency (jsDelivr+GitHack)

This removes the RawGit dependency, which is winding down (fixes #564).
PR #570 suggests using GitHack, which "functions exactly the same."
Unfortunately, #570 doesn't fix the issue where it really maters, see https://github.com/google/code-prettify/issues/564#issuecomment-447660969.
For the actual scripts, I used jsDelivr, which seems to have an decent backing.
Elsewhere (mostly: samples, documentation) I used GitHack, because jsDelivr does not support serving HTML content with the appropriate Content-Type.
These usages should really be moved to GitHub Pages (would fix #422).
See the next comment for why I didn't use GitHack for everything.

GitHack, suffers from the same issue RawGit did, which lead to its demise.
Quoting the website:

I need guaranteed 100% uptime. Should I use raw.githack.com?
Probably not.
raw.githack.com is a free service and cannot provide any uptime or support guarantees, even for CDN URLs. While I do my best to keep things running, things sometimes go wrong. Sometimes there are network or provider issues outside my control, sometimes abusive traffic temporarily affects response times, and sometimes I break things (although I try really hard not to).
Since I run raw.githack.com in my spare time, with my own money and with free CDN hosting by CloudFlare, it has a budget that's probably less than you pay for coffee in a given month. My goal is to help other open source developers get their projects up and running, but if you need to serve files that are crucial to your business, you should probably pay for a host with well-funded infrastructure and uptime guarantees.

Hopefully jsDelivr is reliable enough to hard code into the source.

I'll pull this PR locally, check that the generated sources all rebuild nicely, then be ready to merge it into master.
How time sensitive is this?  I'd like to post an announcement to https://groups.google.com/forum/#!forum/js-code-prettifier and give people time to read it and be ready in case there's any trouble.
Ideally this change wouldn't happen over the US holidays when many people are out of the office.
How does landing this change second week of January sound?

I don't think it's time sensitive at all, just something that needs to be fixed, eventually.
RawGit will continue to work until at least October 2019, according to the website.

That is good.

Sending out email to support group now.

Announcement at https://groups.google.com/forum/#!topic/js-code-prettifier/IFHev_kLm30
Will add link to README.

https://github.com/google/code-prettify/commit/f20e1523dfd916f2502e212ec14e30a27ad50ec9 might introduce a merge conflict with this PR since it cherrypicks this PR's changes to the README and adds a link at the top to the migration announcement.

jsdelivr is serving version 0.1.0 of code-prettify, which still references rawgit  (https://www.jsdelivr.com/package/npm/code-prettify). This is probably because there has not been an official release of this repo since this fix was merged. Is there a planned release date for code-prettify before rawgit goes away?

I can confirm the issue. It seems jsdelivr caches things pretty much "forever", which I didn't know. I'm sorry.
There's an issue tracking that behavior and I'm trying to figure out the best way forward.

OK, so this was a bug with jsDelivr.
Previously cached URLs have been purged from the CDN (but, obviously, not client devices).
I can confirm all files are now current and being served with:
cache-control: public, max-age=604800, s-maxage=43200
So, 7 day private, 12h shared cache. Previously was one year, immutable.
Clients who got the "immutable" cached version need to purge their caches before October.

@ncruces Will request access.  Thanks for investigating.


Author References Synchronization

What does this pull request aim to achieve? 💯
Synchronize the author's name, photo, and type reference at posts and comments when someone changes any of this information at his profile or at the org profile.
Closes #574
Supersedes #526
For performance reasons, we have an author document at Posts and Comments that is a copy of the authors name, type, photo, and location. The three first need to be synced, that is, when the user updates the name, type or photo of his account or of his organization, the author subdocuments for his posts and comments need to also be updated to reflect this change.
The author's location, per requirements, is NOT updated at the subdocuments when the author changes his location at his profile.

The changes requested by @adisen were the same as mine and definitely resolved now so I will go ahead and merge.


chore(stoneintg-1008): stop referenciing spec.containerImage

The integration service has begun using status.lastPromotedImage as the source of truth for the GCL. Initially the spec.containerImage field was used as a fallback until components could migrate to the new field.  Now that all elligible components have been manually migrated to the new field, we can remove references to the old field in our code.
This will end the errors caused by the integration and build services both attempting to write to spec.containerImage.
Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@20c02e8). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage        ?   64.05%
=======================================
  Files           ?       49
  Lines           ?     6093
  Branches        ?        0
=======================================
  Hits            ?     3903
  Misses          ?     1843
  Partials        ?      347

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


DOCS: CNAME change

Hi in order to have the DNS resolve nicely
can we please point a CNAME record from rust-driver.docs.scylladb.com to scylladb.github.io. More info at https://sphinx-theme.scylladb.com/stable/github-pages#setting-up-a-custom-domain. We have done this for all the projects thus far. As I don't have write access it is not something I can do.

@avikivity do you have superpowers to change the configuration for this repo and add a custom domain for github pages?

Yes, and so do you.

@lauranovich I activated github pages for this repository, but somebody still needs to add a CNAME DNS entry for the scylladb.com domain and its rust-driver subdomain, and I don't have access to that. Until that happens, it won't work.
Also, github pages seem to fail to build because they cannot resolve the docs/source/index.md symlink, even though it points to ../../README.md and is valid if you check out the repository. I have no idea how to debug github pages stuff so I'm leaving it as is, pull requests welcome. Here's the error for reference:
The page build failed for the `main` branch with the following error:

The symbolic link `/source/index.md` targets a file which does not exist within your site's repository. For more information, see https://docs.github.com/github/working-with-github-pages/troubleshooting-jekyll-build-errors-for-github-pages-sites#symlink-does-not-exist-within-your-sites-repository.

For information on troubleshooting Jekyll see:

  https://docs.github.com/articles/troubleshooting-jekyll-builds

OK this is outside of the scope of the current issue. please file another issue on this error. @dgarcia360 should take a look at it

@psarna I can change dns, but I need to know the entry details (CNAME and target name)

@avikivity I think that it should be a copy-paste of the java driver config, but with "rust" instead of java, so the CNAME record should go like that:

rust-driver.docs.scylladb.com -> scylladb.github.io

(that's just an educated guess from using dig on our driver docs pages)

Ugh, the dns provider is broken.

It's back up, and I added the record.

I've set up the domain. Now everyone can visit http://rust-driver.docs.scylladb.com and marvel at the 404 error, because it looks like the automatic script hasn't created the stable directory in the gh-pages branch. As I have no clue how these pages work, I hope somebody (@dgarcia360?) will be able to fix it with a pull request.

@psarna - I'll do that.

We don't have a stable branch though. We could create one, but I looked at java-driver's conf.py and it also doesn't contain a stable branch. Instead, it does some elaborate tricks to rename one of the versions to stable (ref: https://github.com/scylladb/java-driver/blob/2e4c2bc2f7f676db8621fd4cdd35b377c468d8eb/docs/source/conf.py#L201-L206). I don't fully grasp what's the idea behind all that, but perhaps we should have a similar script for all drivers. The other difference I noticed is that the java driver explicitly lists some branches with released versions as BRANCHES, while the Rust driver only lists main. We already have a release (0.1.0), so maybe it should be listed instead? Again, I don't have enough context to really understand what I'm talking about here.

Meanwhile, good news is that since currently the only branch we generate the docs for is main, this link works: http://rust-driver.docs.scylladb.com/main/


Maximum call stack size exceeded

I am getting an error.
RangeError: Maximum call stack size exceeded   at join (native) while use checklist- model.
Any idea?

Issue has been fixed. I used data- attributes which checklist-model.


Fix focus on tab selection

When you select the terminal tab, the terminal should be ready to type

strange. I have the latest version (0.9.8) and I still must click on the window after switching tabs to have the cursor become active. This is on Mac OS X. Would be nice to have focus enabled as soon as the term2 tab is selected.


Training from scratch on local MSCOCO data on A100

Hi,
I can not find any resource on how to train this model on local available MSCOCO dataset using GPU. Could you please provide some training guide for that? I know the code is for running on TPUs, what will be the changes required to train on GPUs?
Regards,
Dipendra

The code works for both TPUs and GPUs in pretty similar ways. The instructions given in the README is for GPU (in finetuning setup). For training from scratch on COCO, please refer to this issue #3. Hope this helps.

Thank you for your reply. Could you please also shed some light on how to train on a custom dataset available locally when training from scratch? I have MSCOCO dataset available on my local disk and I tried running the training by setting config.data_dir argument to the /datasets/coco - which contains the entire file but it failed.

If you only train on COCO dataset, the tensorflow_datasets module will download COCO dataset automatically, and you only need to additionally download the annotation file as instructed in README. If you have other datasets that are not in tensorflow_datasets, you will need to write a wrapper class using tf.Data which implements extract method as shown here.

Thank you for your reply. Could you please also shed some light on how to train on a custom dataset available locally when training from scratch? I have MSCOCO dataset available on my local disk and I tried running the training by setting config.data_dir argument to the /datasets/coco - which contains the entire file but it failed.

Hello there, did you train on your custom dataset ?


vs code 1.15.1 build .net core 2.0 fail

build in visual studio 2017 successful
and dotnet successful
but build vs code 1.15 fail throw "The terminal will be reused and press any key to close"
tasks.json:
{
// See https://go.microsoft.com/fwlink/?LinkId=733558
// for the documentation about the tasks.json format
"version": "2.0.0",
"tasks": [
{
"taskName": "build",
"command": "dotnet build",
"type": "shell",
"group": "build",
"presentation": {
"reveal": "silent"
},
"problemMatcher": "$msCompile"
}
]
}
launch.json
{
"version": "0.2.0",
"configurations": [
{
"name": ".NET Core Launch (web)",
"type": "coreclr",
"request": "launch",
"preLaunchTask": "build",
"program": "${workspaceRoot}/coach.platform.api/bin/Debug/netcoreapp2.0/coach.platform.api.dll",
"args": [],
"cwd": "${workspaceRoot}/coach.platform.api",
"stopAtEntry": false,
"launchBrowser": {
"enabled": true,
"args": "${auto-detect-url}",
"windows": {
"command": "cmd.exe",
"args": "/C start ${auto-detect-url}"
},
"osx": {
"command": "open"
},
"linux": {
"command": "xdg-open"
}
},
"env": {
"ASPNETCORE_ENVIRONMENT": "Development"
},
"sourceFileMap": {
"/Views": "${workspaceRoot}/Views"
}
},
{
"name": ".NET Core Attach",
"type": "coreclr",
"request": "attach",
"processId": "${command:pickProcess}"
}
]
}

@flyliao this isn't really a C# extension issue. But we can see if we can help troubleshoot a bit.
First, what OS are you on? What is your shell?
Second, here is the what a C#-extension-generated tasks.json will look like. By any chance does it work better?
Assuming it doesn't, can you test if you get the same error with just a super generic program (ex: on Windows: cmd /c echo hello on Linux/Mac: or bash -c echo hello)
{
    "version": "0.1.0",
    "command": "dotnet",
    "isShellCommand": true,
    "args": [],
    "tasks": [
        {
            "taskName": "build",
            "args": [
                "${workspaceRoot}\\clicon.csproj"
            ],
            "isBuildCommand": true,
            "problemMatcher": "$msCompile"
        }
    ]
}

Tks!
runing win 10 Enterprise Edition,your solution in .net core 1.1 is ok,but upgrade .net core 2.0 is fail.

If you go to File->Preferences->Settings, what do you have any terminal settings customized? What do you have for these too?
  "terminal.explorerKind": "integrated",

  // Customizes which terminal to run on Windows.
  "terminal.external.windowsExec": "C:\\WINDOWS\\Sysnative\\cmd.exe",

BTW, in case this turns out to be useful, here is where that string comes from: https://github.com/Microsoft/vscode/blob/aca45c46d6dee4b9c7cde2fdd5e39f615904a777/src/vs/workbench/parts/tasks/electron-browser/terminalTaskSystem.ts#L429


yo node-webkit "Potentially unhandled rejection" on Mac

$ yo node-webkit

     _-----_
    |       |
    |--(o)--|   .--------------------------.
   `---------´  |    Welcome to Yeoman,    |
    ( _´U`_ )   |   ladies and gentlemen!  |
    /___A___\   '__________________________'
     |  ~  |
   __'.___.'__
 ´   `  |° ´ Y `

? What do you want to call your app? Allowed characters ^[a-zA-Z0-9]+$ oodo
? A little description for your app?
? Would you mind telling me your username on GitHub? karan
? Do you want to install one of the node-webkit examples? No
     info Get GitHub informations
✔ Github informations successfully retrieved.
   invoke   node-webkit:download
? Do you want to download node-webkit? Yes
? Please specify which version of node-webkit you want download: (v0.10.5)
     info     Check if version "v0.10.5" is available for download.
? Please specify which version of node-webkit you want download: v0.10.5
? Which platform do you wanna support? MacOS 64
     info     Creating folder structure for node-webkit source.
✔ Created: "resources/node-webkit"
✔ Created: "resources/node-webkit/MacOS64"
✔ Created: "tmp"
     info     Downloading node-webkit for MacOS64
 conflict     Wrong content type for MacOS64
Potentially unhandled rejection [3] Wrong content type for MacOS64 (WARNING: non-Error used)

I'm on node v0.10.35 and Mac x64 (Mavericks).

I get this when downloading the macosx 32 version. I will have a look at this.

his seems to be fixed with issue #61 and can be tested with the version in the repository.


[WebAssembly] ASSERTION 2257: ChakraCore v1.11.7

Hello
I have validated that the test case for https://github.com/Microsoft/ChakraCore/issues/5985 runs correctly with a Debug version of ChakraCore and the small test case but there still seems to be something wrong when running against our tests and still receiving the following:
ASSERTION 2257: (/Users/Jimmy/websharp/projects/ChakraCore/lib/Backend/IRBuilderAsmJs.cpp, line 1044) !IsLoopBody() || offset <= GetLoopBodyExitInstrOffset()
 Failure: (!IsLoopBody() || offset <= GetLoopBodyExitInstrOffset())
Illegal instruction: 4

Not sure how to create a small repo of this either.  Is there some way to help narrow this down even further?

Chakra version https://github.com/Microsoft/ChakraCore/commit/e6e25c3a5ec0f4d2bda13eb6f9b06550d91daddb

Do you have any crash dumps or anything like that? Can you pass custom switches to chakracore? If so, -bgjit- -lic:1 might make repro more consistent.
Do you have a larger repro which I can run using ch?

I will try the custom switch.  Also, will try to get a larger repro that you can run using ch.

Hello Mike
I ran the tests using Charka debug build version:  https://github.com/Microsoft/ChakraCore/commit/ca582450de28ef6179e9648030190f0eaa7eea74
The test file can be found here:
If you can not access it please let me know.  Should be accessible by everyone.
The output as follows:

/Users/Jimmy/websharp/projects/ChakraCore/out/Debug/bin/ch/ch runtime.js -args --run hello.exe
Arguments: --run,hello.exe
Loaded: hello.exe
Loaded: mscorlib.dll
initializing mono runtime
>>mono_wasm_runtime_ready
WASM: Initializing.....
ASSERTION 12765: (/Users/Jimmy/websharp/projects/ChakraCore/lib/Backend/IRBuilderAsmJs.cpp, line 1044) !IsLoopBody() || offset <= GetLoopBodyExitInstrOffset()
 Failure: (!IsLoopBody() || offset <= GetLoopBodyExitInstrOffset())
Illegal instruction: 4

Run with -bgjit- -lic:1 option as described above.
/Users/Jimmy/websharp/projects/ChakraCore/out/Debug/bin/ch/ch -bgjit- -lic:1 runtime.js -args --run hello.exe
Arguments: --run,hello.exe
Loaded: hello.exe
Loaded: mscorlib.dll
initializing mono runtime
ASSERTION 12772: (/Users/Jimmy/websharp/projects/ChakraCore/lib/Backend/IRBuilderAsmJs.cpp, line 1044) !IsLoopBody() || offset <= GetLoopBodyExitInstrOffset()
 Failure: (!IsLoopBody() || offset <= GetLoopBodyExitInstrOffset())
Illegal instruction: 4

Let me preface the above two runs saying that it sometimes passes.  I have gone up to 20 calls before it fails with the errors above.
Here is the output from a successful run:
/Users/Jimmy/websharp/projects/ChakraCore/out/Debug/bin/ch/ch runtime.js -args --run hello.exe
Arguments: --run,hello.exe
Loaded: hello.exe
Loaded: mscorlib.dll
initializing mono runtime
>>mono_wasm_runtime_ready
WASM: Initializing.....
WASM: Hello, World!

@lewing ^

I'm not a ChakraCore developer, but tried to download the test case and could not access it.

Thank you for letting me know @renatahodovan.
Try this one: https://www.dropbox.com/s/l4h3uw0cdvb9st1/interp-sample.zip?dl=0

@MikeHolman So far using chakra build from chakra repo: https://github.com/Microsoft/ChakraCore with the fix Microsoft/ChakraCore#6072 applied all the tests are running through. Have executed tests locally with the build multiple times.
Thanks so much.
Do you guys know when a new version will be out so we can switch our CI tests back on for Chakra?

It's probably a late hit, but I played with various automatic reduction approaches[1][2] applied on the provided test case and got the attached results[3]. I've posted the reduced version in case you need a regression test for the fix.
[1] https://github.com/renatahodovan/picire
[2] https://github.com/renatahodovan/picireny
[3] Results:
mono.js    : 497995 B   -> 1592 B
mono.wasm  : 1684878 B  -> 1782 B
mono.wast  : 25748578 B -> 5512 B
runtime.js : 9243 B     -> 234 B
mono-config.js got manually inlined where it's used
the managed directory is not needed to reproduce the issue
minimal.zip

The next release will be out on May 14, and it will contain this fix.

So the 1.11.8 did not contain this fix?  Thank you for the information because I was in the process of creating a new issue against the release.

Yeah, unfortunately fix went in a little too late to make 1.11.8.


Types used in WorkerExtensionStartup must be public

The registered startup types are used in code gen applied to the application project. If they're not public, that will lead to compilation errors in the target.
Two changes should be made:
1 - The source generator should only use public types. Emit a compilation warning so end users know the extension services are not being registered.
2 - An analyzer should enforce the visibility of types used with the WorkerExtensionStartupAttribute

@fabiocav This was already addressed, wasn't it? Are we able to close this issue?


Adding HyperlinkUnderlineVisible resource for Hyperlink(Button)

Adding the HyperlinkUnderlineVisible resource for the Hyperlink and HyperlinkButton components.
This is part of internal task 30997431.
The new resource is similar to ListViewBaseItem's ListViewBaseItemRoundedChromeEnabled which I moved out of the theme-specific sections as a single declaration is enough.
Tested the behavior in conjunction with the task 30997431 changes in 21H1 OS.

/azp run


Atom package documentation web page should handle relative image URLs.

Github supports relative URLs for things like images in markdown files. The Atom generated package docs do not.
For example compare these:
https://atom.io/packages/nuclide-flow
And:
https://github.com/facebook/nuclide/tree/master/pkg/nuclide/flow
The relative image URLs work in the github page, but not the Atom page.

@thedaniel Thanks for taking a look

I filed an issue on the repo for the site, will close this when it's fixed.

Yea that one's been a trip-up for many a newbie package developer since the start.

This issue was moved to atom/atom.io#14


Appear as a local disk

Hi all, is there a way to have the disk appear in explorer the same way the C: drive does for example?  I've tried DokanOptions.FixedDrive and DokanOptions.RemovableDrive and these both appear differently.  Reason I ask is I want to run CrystalDiskInfo or similar benchmarking tool against my implementation and these don't support disks as represented by Dokan (at least not the way I have it, perhaps).  Thanks!

@jchristn Have you tried to use the mount manager option?

I have not!  Do you have a link for more information (or example)?  Thanks!

@jchristn Not on computer right now :'( sorry but there should be some documentation linked to the enum and more on Microsoft website.

Hi @Liryna I'm not finding this.  Any help would be appreciated - even a starting point.  Thanks!

https://github.com/dokan-dev/dokan-dotnet/blob/6707dfd8e59ea57f73a23e9095ffc0399c4c118f/DokanNet/DokanOptions.cs#L37

Oh, sorry I didn't think you were referring to DokanOptions.  I will try this!

Weird, still not accessible in CrystalDiskInfo (not seen as a local drive).  What tools do you and the team use to benchmark performance for Dokan-based volumes?  Maybe I just need to align with those tools.

CrystalDiskInfo is probably more looking at a block disk device and not a fs files benchmark.
https://dokan-dev.github.io/dokany-doc/html/ Testing a File System

Thanks!  I'll report back if I have any issues.  Appreciate your help.


Identifiers validation failed for dataset Cambridge University Herbarium (CGE)

Identifier validation failed for the dataset Cambridge University Herbarium (CGE):

Crawler attempt: 4
Publishing organization: Cambridge University Herbarium (CGE)
Publishing country: UNITED_KINGDOM
Installation: Cambridge University Herbarium
Number of occurrences indexed for this dataset at the time of the issue: 2
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 2783 total records; 2783 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/4193591/step

New IDs sample:

Old IDs sample:

1CE1B945-4E3C-41A1-BB4B-0283A4B984E5
A3787F9F-5EEF-4066-ACC5-1067F72FE9A3

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Cambridge University Herbarium (CGE) : https://doi.org/10.15468/bhfj55.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Cambridge University Herbarium (CGE):

Crawler attempt: 5
Publishing organization: Cambridge University Herbarium (CGE)
Publishing country: UNITED_KINGDOM
Installation: Cambridge University Herbarium
Number of occurrences indexed for this dataset at the time of the issue: 2
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 2783 total records; 2783 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/4193592/step

New IDs sample:

Old IDs sample:

1CE1B945-4E3C-41A1-BB4B-0283A4B984E5
A3787F9F-5EEF-4066-ACC5-1067F72FE9A3

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Cambridge University Herbarium (CGE) : https://doi.org/10.15468/bhfj55.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


SASS-840 gift aid journey tests

Description
Please include a brief summary of the change you've made and the issue that it fixes.
Add a link to the relevant story in Jira
SASS-840
Checklist PR Reviewer
Before Reviewing

[x]  Have you pulled the branch down?
[x]  Have you assigned yourself to the PR?
[x]  Have you moved the task to “in review” on JIRA?
[ ]  Have you checked to ensure all dependencies are up to date?

Whilst Reviewing

[ ]  Have you run the journey tests?
[ ]  Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?

After Reviewing

[ ]  Have you checked for merge conflicts?
[ ]  Have you checked to make sure there are no builds in the pipeline before you merge?
[ ]  Have you moved the task to “in pipeline” on Jira?

[x]  Have you addressed warnings where appropriate?

After PRs been Reviewed

[ ]  Have you checked for merge conflicts?

webdriver-factory can be upgraded from 0.20.0 to 0.21.0


chore: save in builder queue

Description

How has this been tested?

Checklist

[ ] changelog was updated with notable changes
[ ] documentation was updated

/e2e --tests sdk,substrafl

End to end tests: :hourglass_flowing_sand: STARTING


Build failure: coder

Steps To Reproduce
Steps to reproduce the behavior:

build coder (Tested on https://github.com/NixOS/nixpkgs/commit/a0b3b06b7a82c965ae0bb1d59f6e386fe755001d)
NIXPKGS_ALLOW_UNFREE=1 nix build --impure nixpkgs#coder

Build log
Gist
Additional context

Fails on x86_64-darwin with nixpkgs-unstable on https://github.com/NixOS/nixpkgs/commit/a0b3b06b7a82c965ae0bb1d59f6e386fe755001d
Builds correctly if pointing to https://github.com/NixOS/nixpkgs/commit/835736de35faba3e57a7a4becc6b7e472ae72317

Notify maintainers

@ghuntley @urandom2
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-darwin"`
 - host os: `Darwin 21.6.0, macOS 10.16`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.1`
 - channels(carlo): `"home-manager, nixpkgs"`
 - channels(root): `""`
 - nixpkgs: `/Users/carlo/.nix-defexpr/channels/nixpkgs`

@carloaromando maybe https://github.com/NixOS/nixpkgs/pull/253235 fixes the issue ? You can help test it

@kirillrdy I tried, but the build still fails on x86_64-darwin. I'll share the build log in the PR

Still an issue on NixOS rev 1042fd8b148a9105f3c0aca3a6177fd1d9360ba5

I just build this on Darwin without issues, but I am not sure why it is not being evaluated on Hydra anymore.
[{"drvPath":"/nix/store/1vzyz4mh0npxlqnpkskvnx8mzc8xx7vg-coder-2.13.4.drv","outputs":{"out":"/nix/store/klzmxpxxd42zi65khr5ldpwbrbf7hpsm-coder-2.13.4"},"startTime":1724288168,"stopTime":1724288171}]

Coder now builds successfully on both aarch64-darwin and x86_64-darwin on the current master. Hydra doesn't build it because it depends on terraform, which has an unfree license and Hydra doesn't build unfree packages.


updates for demo

added async apis
move namespaces
made sure BinaryData content-type flows
added openai helpers

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.CloudMachine


search by name

hello there is it possible to search video by name using this library

This library is only for streaming videos, search can be done using<EMAIL_ADDRESS>

oh thanks


Update discordRPCLoadStrings.json

No description provided. - Please explain what you want to pull.
I'm probably not a bot, and this isn't an automatic message.


Totals in Pivot table are incorrect

Expected results
the sum function must aggregate the sum of the column,
the mean function must aggregate the mean of the column,
etc
Actual results
sum, max, mean, std, var aggregation functions shows  max values in pivot table
Screenshots
http://prntscr.com/118rk0k
http://prntscr.com/118rkhu
http://prntscr.com/118rkvx
How to reproduce the bug

Go to 'chart explore'
choose vizualization type - Pivot table
Scroll down to Pivot Options
choose "show totals" and aggregation function sum, max, mean, std, var

Environment

superset version: superset version 1.01
python version: python --version 3.8.5
node.js version: node -v v10.19.0

looks like the error is related to #11658

I am also having this issue. I was having it on 0.38 and am still experiencing it on 1.0.

@Artem-fb thanks for reporting, could you test it in Pivot Table 2? This should not be an issue in the new plug-in.

@junlincc  thank you for the answer. I'm not sure that I understand what is plug-in? I just have to update my version from 1.01 to 1.10 or install something additionally?

Please consider adopting Pivot Table V2, and let us know if you see any similar issue there.

Closing since this has gone silent for over a year now. Hopefully everyone's happy with Pivot Table V2.... we'll likely deprecate the legacy one before long!


Simple minimal prototype of isomorphic application

Just create a simple minimal prototype of isomorphic web application using

catberry on frontend #78
finch on backend #112
PostgreSQL as a database
Any database migration mechanism from #114
TypeScript as a frontend language

Once we have such application we can experiment with it on different infrastructures.
Please, create a separate branch in the LogList git repo and replace everything in it with the prototype. In the future we will make more LogList related changes to the prototype and eventually when it's ready we will merge everything into master.

According to the architecture diagram in #78 the prototype will consist of two projects: one for frontend with catberry and TypeScript, and another one for backend with finch, database and other backend stuff.
For this prototype I'll place both projects in one repo. But I'm not sure if it is right in general. Maybe in the future we are going to reconsider that.

лорва

@rexim, I had discussion with @pragmadash regarding using TypeScript with Catberry and currently I think that you should take a timeout at this problem. This is a separate task and I'll try to create some minimal implementation myself.

@ForNeVeR ok, sure. Should I reassign this issue on you?

Or maybe we should create a new one specifically for TypeScript with Catberry?

Agreed. Created #117.

Um, guise? Isomorphic apps are kinda more complicated than that.
First and foremost, there's no magic in catberry that somehow will make your app isomorphic. It still needs something to run server-side JS. And by something I mean node.js. Can't circumvent that. (Well, you can mikel your own server-side js thingamabob, but still...)
Second, nobody -- and I mean nobody needs isomorphism "just 'cause, y'know". Please refer to this fine article for the elaboration of the point. Do not go full frontal hipster, please. You need iso when time-to-presentation actually becomes a bottleneck in your conversion funnel. FFS, we do not even need to measure any conversion -- it's not like we are monetizing LogList in any way, shape or form. So, transition to isomorphic SPA will only complicate things for the devs without producing any value whatsoever.
And third -- writing isomorphic apps is not problem-solving hard. It's complicated, yes -- because there's a lot of mundane and boring stuff to take care of. So, not an achievement. A second-to-last bullet point in your CV, maybe.
Stay frosty. And never, ever, cut a deal with a dragon.


Update FW from file

Background
Now we can choose fours variants updates - from internal storage
Changes

Interface for copy updater file to local storage (and third realization)
New Update state for choose file
UpdatePending - model for update from URI or Official
Custom dialogs
Not save custom choose to db

Test plan
In future

Chech manifest file - throw new Exception
Deeplink from web updater

We have to check the contents of the tgz folder and if the manifest is there. I was able to "update" this file - https://update.flipperzero.one/builds/firmware/0.67.2/flipper-z-any-scripts-0.67.2.tgz


vm.expectRevert() doesn't catch error messages from libraries

Helper Contract:
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

import {ERC20} from "solmate/tokens/ERC20.sol";
import {SafeTransferLib} from "solmate/utils/SafeTransferLib.sol";

contract Helper {
    ERC20 public token;

    constructor(ERC20 _token) { token = _token; }

    function doSafeTransfer(address to, uint256 amount) external {
        SafeTransferLib.safeTransfer(token, to, amount);
    }
}

Test Example:
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

import {Test} from "forge-std/Test.sol";
import {Helper} from "../src/Helper.sol";
import {MockERC20} from "solmate/test/utils/mocks/MockERC20.sol";
import {SafeTransferLib} from "solmate/utils/SafeTransferLib.sol";

contract LibraryTest is Test {
    Helper public helper;
    MockERC20 public token;

    function setUp() public {
        token = new MockERC20("MockToken", "TST", 18);
        helper = new Helper(token);
    }

    // This doesn't work.
    function testRevertTransfer() external {
        vm.expectRevert(bytes("TRANSFER_FAILED"));
        SafeTransferLib.safeTransfer(token, address(0xBEEF), 1e18);
    }

    // This works fine.
    function testRevertHelperTransfer() external {
        vm.expectRevert(bytes("TRANSFER_FAILED"));
        helper.doSafeTransfer(address(0xBEEF), 1e18);
    }
}

Repo with reproducible error: https://github.com/pedrommaiaa/Foundry-Library-Error

I'm not sure if this is an issue with forge-std or with forge, so feel free to direct me to a better place if necessary.

expectRevert is a forge cheatcode, and I see there's also an issue there, so going to close this one in favor of that one


If Webhooks fails it returns array for userErrors

  webhookStatus.success
        ? console.log(
        `--> Successfully registered subscriptions_update webhook! for ${shop}`
        )
        : console.log(
        "--> Failed to register subscriptions_update webhook",
        webhookStatus.result.data.webhookSubscriptionCreate.userErrors[0].message);

Commit 718f6cc3af3d3f9ea3d2e49f45671cfe5790dc6d fixes this issue by logging only userErrors instead of the message.
Thank you!


Add line-height to checkbox label::after

Some fonts need to get a different line-height, so that the font-awesome-icon inside the label::after is not positioned well.
This changes should fix that.

Hi, @Artem-Schander !
Do you sure that need this changes?

I would not insist. For me it worked out better that way, but do make a few tests and decide by yourself

Thanks1


GitHub: Issue and PR templates

Three templates:

Bug report template
Feature request template
Pull request template

Lifted these from Agones, and tweaked to adjust for this project.
Feedback definitely welcome!

Thanks for the approval!
Just making a note to not merge this until after we do our 0.2.0 release.


Fix the rust bindings

and change the package name..tree-sitter-CMake is very bad package name

I'm not sure what the files in the test directory is for

I also updated the dependencies, can you rebase your PR?

I'm not sure what the files in the test directory is for

I think put some test example is better,so I make such dir..

There is a corpus directory that contains the test files for testing the grammar already so I'm not sure why you have another test directory. Also, the files in test directory are just there with no instructions on how to use them, so it's really confusing.

I will remove it , sorry ,I know little about treesitter

no worries

I have trouble rebase.. I think I should make another pr

what's wrong? i can guide you through it also

what's wrong? i can guide you through it also

I will make another.. I am not familiar with git rebase.. sorry


MultiMiner on Mac - app is not responding

Hello guys,
i need help about this topic, i sucessfully download all software required, but when i run the MultiMiner app, it will display (downloading BFG Miner) and then it will fall down and app dont responding :( Any tips please? I really want to mine with CPU and GPU together :/ @nwoolls

i resolved this by manually downloading BFGMiner, multiminer app then opened fine


Improve Automation

Task List
Push/PRs

[x] Check dist is most up to date prior to merge into main
[x] Check that a local RSS file parses correctly
[x] Add dependency-review action for checking bad dependency merges

Publishing (aka Push with tags)

[x] Create a release on a new tag pushed to production

Closing this issue, as 'initial iteration' is complete. More advanced scenarios could follow later in separate issues.


Convert mnist eager model to use a convolutional model.

This change is

Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.

demos/mnist_eager/model.ts, line 19 at r1 (raw file):

const conv2OutputDepth = 16;
const conv2Weights = dl.variable(
    dl.randomNormal([5, 5, conv2InputDepth, 16], 0, 0.1) as dl.Tensor4D);

s/16/conv2dOutputDepth

demos/mnist_eager/model.ts, line 23 at r1 (raw file):

const fullyConnectedWeights = dl.variable(
    dl.randomNormal(
        [7 * 7 * conv2OutputDepth, 10], 0,

s/10/LABELS_SIZE
here and in the bias initializer
bring back LABELS_SIZE

demos/mnist_eager/model.ts, line 27 at r1 (raw file):

const fullyConnectedBias = dl.variable(dl.zeros([10]) as dl.Tensor1D);

// Loss function

do we need these comments above loss and model? seems clear from the function name :)

demos/mnist_eager/model.ts, line 34 at r1 (raw file):

// Our model
function model(inputXs: dl.Tensor2D): dl.Tensor2D {
  const xs = inputXs.as4D(-1, 28, 28, 1);

move 28 out to a constant (where we had image size, you can replace)

demos/mnist_eager/model.ts, line 38 at r1 (raw file):

  // Conv 1
  const layer1 = dl.tidy(() => {
    return xs.conv2d(conv1Weights, 1, 'same').relu().maxPool([2, 2], 2, 0);

can you move these to consts, and below?
const strides = 2; const pad = 0;

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions, all commit checks successful.

demos/mnist_eager/model.ts, line 27 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
do we need these comments above loss and model? seems clear from the function name :)

doesn't hurt... :). Its similar to the comment above train() and just aids reading for a new person imo

Comments from Reviewable


Date picker calendar settings

Can the date picker calendar be changed from Monday to Sunday instead of Sunday to Saturday?

Hi katrila,
This is usually controlled with a system-level setting

The newer version of the editable grid will take this setting into consideration and show the calendar view accordingly.

Hello @katrila,
We are happy to inform you that the new version of Editable Table is now available!
You can now set the "first day of week" system-level settings and the calendar view will be changed accordingly.
Please, kindly, update the control version and check if you are able to get your desired results. If you have any questions, don't hesitate to ask!

Closing this bug as the issue is fixed in the 1.1.0 version.


Add reference to Multi-Region SQL AOAG deployment

Please consider adding a reference in the Related Resources section for Configure a SQL Server Always On availability group across different Azure regions, as this model for the data tier which is being presented in this architecture.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: be033e7f-d78f-f63f-c9b5-f08130315704
Version Independent ID: d66f5650-fffb-79a6-ee59-40eaad06cd4f
Content: Multi-region N-tier application - Azure Architecture Center
Content Source: docs/reference-architectures/n-tier/multi-region-sql-server.yml
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @doodlemania2
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 381387

Thank you for responding @david-stanford .
We will be closing this issue now as we have an internal bug already in our backlog related to this request .
Thank you.


Custom Ping/Pong handling

There is no customization of the Ping/Pong messages sent/read to/from the server.
The assumption is that the server is always sending timestamps in milliseconds, but this is not always the case.
A common scenario for a WSS server is to send custom message (e.g. with ping UUID) and expect that same message in pong response. Not necessarily a timestamp.
Could we add a mechanism to allow the user to provide some logic for the Ping/Pong messaging process?
The way I see it, we could add an enum HeartbeatMode in Config, with multiple choice like HeartbeatMode::TimeStamp or HeartbeatMode::Custom("always-send-this-string") or HeartbeatMode::None (disable heartbeat logic) or HeartbeatMode::Random...
There could be better ways to implement this customization, but I believe adding this feature would benefit the lib.
Thanks

Also, according to the RFC: https://datatracker.ietf.org/doc/html/rfc6455#section-5.5.2
Ping/Pong should contain the same message, so while sending & expecting timestamps can be one way to measure server latency, there seem to be other preferred approaches when it comes to wss.

Okay I've added custom configuration for the heartbeat modes.
Right now it's only TimeStamp and Custom.
I'm not so sure how Random would work, do you want to also have some additional logic behind it, or just sending random values like UUID's or just integers?

Thanks for adding that change!
For Random, I would have gone with UUID, however, I believe this is a bit too specific for the lib, or at least I don't have a general use case in mind for now.
Now that you added the logic to support Custom, this should be easy to add Random if ever someone comes with a use case not too specific to their issue.


Apache_up shows 0 even my apache_exporter is on

When I type my apache_exporter on URL, I can see it is ON right now.

HOWEVER, I try to figure its graph out, it tells apache_up is 0.

Even though I can access my web server and it works normally.
What should I do to solve this problem?

hi,
You can click on "Metrics" to see all the data.
http://<IP_ADDRESS>:9117/metrics
On Fri, Jan 4, 2019 at 12:58 AM janeunbi<EMAIL_ADDRESS>wrote:

When I type my apache_exporter on URL, I can see it is ON right now.
[image: 1]
https://user-images.githubusercontent.com/46011780/50669125-b5f39b00-1006-11e9-9816-b234adb9f7bf.PNG
HOWEVER, I try to figure its graph out, it tells apache_up is 0.
[image: 2]
https://user-images.githubusercontent.com/46011780/50669142-d885b400-1006-11e9-8bfb-cda257091458.PNG
Even though I can access my web server and it works normally.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Lusitaniae/apache_exporter/issues/53, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AADj1SBk69PXSm9VyPcYnMrtuUHPM0dpks5u_qcjgaJpZM4ZpAYC
.

hi @Lusitaniae
Thank you for your reply
nope it doesn't work, I can see the all metrics provided.
I can't understand why value of apache_up comes out 0 even the apache_exporter and apache still working on.


No Cedar-supported app detected

Created a new rails + heroku app, tried to push for the first time with this buildpack and it failed. The error is:
Push rejected, no Cedar-supported app detected
anyone have similar issues? I made sure I have a Gemfile file (seems like the common problem to produce this error). Any help is appreciated!

Oops - just realized this is the same as the first issue (however wasn't resolved). I've created the ini file in the root directory - here is the full stacktrace.
Aruns-MBP:oracle arunnijhawan$ git push heroku master
Counting objects: 580, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (525/525), done.
Writing objects: 100% (580/580), 72.57 MiB | 98.00 KiB/s, done.
Total 580 (delta 193), reused 0 (delta 0)
remote: Compressing source files... done.
remote: Building source:
remote:
remote: -----> Fetching custom git buildpack... done
remote:
remote:  !     Push rejected, no Cedar-supported app detected
remote: HINT: This occurs when Heroku cannot detect the buildpack
remote:       to use for this application automatically.
remote: See https://devcenter.heroku.com/articles/buildpacks
remote:
remote: Verifying deploy...
remote:
remote: !	Push rejected to stark-woodland-7753.
remote:
To https://git.heroku.com/stark-woodland-7753.git


No template directive send when toggle tumbs up

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

Hi everyone,
This problem is the same as #1072
I implemented the "now playing" card, and I clicked the thumbs up button on Alexa APP
But I didn't receive directive event.
Could help me check this issue?
Here is my log
log.TXT
What is the expected behavior?

When I clicked the thumbs up on Alexa APP , SampleApp would receive the directive event includes the string "{"selected":true,"name":"THUMBS_UP","enabled":true,"type":"TOGGLE"}"
What behavior are you observing?

SampleApp didn't receive the directive event.
Provide the steps to reproduce the issue, if applicable:

Open Alexa App, and play "The Weekend" station on iHeartRadio
Click the "thumbs up" button
Check the SampleApp have get the directive event

Tell us about your environment:

What version of the AVS Device SDK are you using?
  <1.9.0>

Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[x] Other - tell us more: arm-linux embedded system

Tell us about your OS (Type & version):

[x] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hi!
It looks like an issue and we are going to investigate it. We will update this issue once we have any news.
Thank you for reporting it!

This issue is fixed on the cloud side.  Please re-open this issue if it's still reproducible.  Thanks!


Translate values in code comments and examples

https://github.com/angular/angular/issues/11405

Looks like the solution for now is to create a fake template with translations only and then pass the data to some service, and then use it, ugly but should work


Ensuring CSV sets factory class before metadata parsing

Ensuring CSV sets factory class before metadata parsing
dbd24b8ee1c6adc5907ef95a93dbe0fdd745ad79
Prior to this commit, if we had configured bulkrax such that we were
allowing for our model import to come from multiple fields
(e.g. from: ['model', 'work_type']) and the CSV had work_type as the
column name, we would get an error as follows:
NoMethodError:
  undefined method `method_defined?' for nil:NilClass
    # ./app/models/concerns/bulkrax/has_matchers.rb:128:in `field_supported?'
    # ./app/models/concerns/bulkrax/has_matchers.rb:157:in `multiple?'
    # ./app/models/concerns/bulkrax/has_matchers.rb:34:in `block in add_metadata'
    # ./app/models/concerns/bulkrax/has_matchers.rb:31:in `each'
    # ./app/models/concerns/bulkrax/has_matchers.rb:31:in `add_metadata'
    # ./app/models/bulkrax/csv_entry.rb:77:in `block in add_ingested_metadata'
    # ./app/models/bulkrax/csv_entry.rb:75:in `each'
    # ./app/models/bulkrax/csv_entry.rb:75:in `add_ingested_metadata'
    # ./app/models/bulkrax/csv_entry.rb:43:in `build_metadata'

Tracing this line it is because the factory_class is nil.  And if the
model column were to be a later column, any columns that occurred before
we established the factory class may have been skipped.
With this commit, we're echoing the functionality introduced in #705 and #703.
Related to:

https://github.com/scientist-softserv/britishlibrary/issues/211
https://github.com/samvera-labs/bulkrax/pull/705
https://github.com/samvera-labs/bulkrax/pull/703

Closes #718
Update spec/fixtures/csv/factory_class_test.csv
f47505d321630c45f2782fddc5392767465951a1
Co-authored-by: Benjamin Kiah Stroud<EMAIL_ADDRESS>

This looks good, however I'm kind of curious why the multiple field mapping wasn't working 🤔 Is multiple field mapping a problem for other properties as well?

This looks good, however I'm kind of curious why the multiple field mapping wasn't working 🤔 Is multiple field mapping a problem for other properties as well? @jeremyf

The underlying problem is that there is something in the processing that raised a NameError which meant we had a a nil.  Another confounding problem is that during the import, the factory_class can change.
The below method is that code and it does a lot of work:
def factory_class
  fc = if self.parsed_metadata&.[]('model').present?
         self.parsed_metadata&.[]('model').is_a?(Array) ? self.parsed_metadata&.[]('model')&.first : self.parsed_metadata&.[]('model')
       elsif self.mapping&.[]('work_type').present?
         self.parsed_metadata&.[]('work_type').is_a?(Array) ? self.parsed_metadata&.[]('work_type')&.first : self.parsed_metadata&.[]('work_type')
       else
         Bulkrax.default_work_type
       end

  # return the name of the collection or work
  fc.tr!(' ', '_')
  fc.downcase! if fc.match?(/[-_]/)
  fc.camelcase.constantize
rescue NameError
  nil
rescue
  Bulkrax.default_work_type.constantize
end


Underscore not being installed, as part of steps in README?

This might be my n00bness with npm/node.
However, I followed the instructions in the README - namely running npm i --save hubot-group-alias , and adding hubot-group-alias to external-scripts.json.
However, when I try to startup Hubot, I get:
bash-3.2$ bin/hubot
connect deprecated multipart: use parser (multiparty, busboy, formidable) npm module instead node_modules/hubot/node_modules/express/node_modules/connect/lib/middleware/bodyParser.js:56:20
connect deprecated limit: Restrict request size at location of read node_modules/hubot/node_modules/express/node_modules/connect/lib/middleware/multipart.js:86:15
[Thu Mar 12 2015 14:52:09 GMT+1100 (AEDT)] ERROR Unable to load /Users/victorhooi/Dropbox/mongodb/glados/scripts/groups: Error: Cannot find module 'underscore'
  at Function.Module._resolveFilename (module.js:336:15)
  at Function.Module._load (module.js:278:25)
  at Module.require (module.js:365:17)
  at require (module.js:384:17)
  at Object.<anonymous> (/Users/victorhooi/Dropbox/mongodb/glados/scripts/groups.coffee:10:7, <js>:4:7)
  at Object.<anonymous> (/Users/victorhooi/Dropbox/mongodb/glados/scripts/groups.coffee:10:1, <js>:67:4)
  at Module._compile (module.js:460:26)
  at Object.loadFile (/Users/victorhooi/Dropbox/mongodb/glados/node_modules/hubot/node_modules/coffee-script/lib/coffee-script/coffee-script.js:182:19)
  at Module.load (/Users/victorhooi/Dropbox/mongodb/glados/node_modules/hubot/node_modules/coffee-script/lib/coffee-script/coffee-script.js:211:36)
  at Function.Module._load (module.js:310:12)
  at Module.require (module.js:365:17)
  at require (module.js:384:17)
  at Robot.loadFile (/Users/victorhooi/Dropbox/mongodb/glados/node_modules/hubot/src/robot.coffee:217:9, <js>:164:20)
  at Robot.load (/Users/victorhooi/Dropbox/mongodb/glados/node_modules/hubot/src/robot.coffee:239:9, <js>:187:30)
  at Shell.loadScripts (/Users/victorhooi/Dropbox/mongodb/glados/node_modules/hubot/bin/hubot:93:5, <js>:94:13)
  at Shell.emit (events.js:104:17)
  at Object.Readline.createInterface.next (/Users/victorhooi/Dropbox/mongodb/glados/node_modules/hubot/src/adapters/shell.coffee:59:9, <js>:104:17)
  at /Users/victorhooi/Dropbox/mongodb/glados/node_modules/hubot/node_modules/readline-history/readline-history.js:112:21
  at ReadStream.onend (/Users/victorhooi/Dropbox/mongodb/glados/node_modules/hubot/node_modules/readline-history/readline-history.js:52:21)
  at ReadStream.emit (events.js:129:20)
  at _stream_readable.js:908:16
  at process._tickCallback (node.js:355:11)

It seems in this case, underscore wasn't installed as part of the npm install.
Is there another step that we need to do as well?

I should mention that I added the following to my package.json in my Hubot directory:
    "underscore": "1.8.2"

After re-running npm install, I didn't get the missing package error messages.
Is this something that should be mentioned as part of the README? underscore doesn't seem to come installed by default with Hubot?

I can't see in that trace that the error is -- it looks like it might be caused from a different package.
npm install should automatically put underscore in the proper directory.
I just tried updating the dependcies and pushed a new version, so try installing again or using npm update.

I think I just got bitten by a similar issue -- this looks like it's because of a longstanding feature/bug in npm about trying to handle duplicate dependencies. (See https://github.com/npm/npm/issues/1341)
This has been fixed in npm 3, AFAIK.
The other solution I had was deleting the module from node_modules and making sure nothing higher-up in the install chain has underscore a depedency, which shouldn't really be more than 1 level of checking.


Fix position of pop-up issue editor to be always on the screen

"When you click on an issue, the pane/window comes up at the top of the page rather than top of screen (you sometimes have to scroll up quite a lot)
It sometimes also changes width depending on the chat function below and can take up whole screen, pop up window should be limited width so not to be whole screen"
Maybe also just limit t width of the pop-up and-or the chat in it.

Done a while ago. May still change the pop-up view to be one of the top level tabs in the app, for consistency.


script,util/packer: Bump Ubuntu base images

ping @lmars
This should fix the release build.

LGTM


Add option to choose version to install

Users should be able to choose what version they want to install, as well as any derivative images.
For instance, I might not want Canasta 1.2.0 if it is the most recently released version. Instead, I could want Canasta 1.1.2 for backwards compatibility reasons. Or, I might want to use the hardened version of Canasta or even Open CSP on Canasta. None of this is possible at the moment.

I'm interested in contributing to this project GSOC2023 and  I would like to work on issue #34. Can someone assign it to me, or can you tell me anyone working on this issue.

I noticed that there hasn't been any progress on this issue for two weeks, and I believe that this isn't a very difficult issue. Moreover, some others have already completed the work, so please forgive me, @jeffw16 , I couldn't help but resolve this issue.

@chl178 sure, this is assigned to you now


Add groups to node section

Hi!
First of all thank you so much for making this project! It's so far saved me quite a bit of time on my own Godot project.
However, my project requires that the nodes that I'm generating have groups (this is normally done in Godot by manually assigning a node to a group in the inspector). It looks like groups was on your todo-list based on the code comments, so I tried my best to implement them. Implementing these changes locally has allowed me to export nodes with groups.
I'm relatively new to Python development and I wasn't sure how to test my changes, so please let me know if this is an acceptable change, and if it's not I would appreciate some direction to make it so.

The change looks great! To test it and make sure it's working I'd recommend either adding a new case in test_parser.py or simply adding some groups to this last test case:
https://github.com/stevearc/godot_parser/blob/89d9d25a867e84003fc4c4474ba27ff6e7bcdf0e/tests/test_parser.py#L82-L90
Tests are currently failing because of lint. It looks like black was updated to have some different formatting preferences. You can apply those changes by running tox -e format.

Thank you for the direction! I've done the formatting and added some test code to cover my additions. Please let me know if there's anything else I need to do.

Thanks for the submission!


Question: Why reject and not resolve promise for already loaded file?

What is the reasoning behind rejecting a promise with the error Error: no file to load has been found, if you're trying to load an existing module you should use the 'inject' method instead of 'load'." if the file or files are already loaded? Why did you choose not to resolve it?

Because it usually means that there is a problem with your code. If it's what you really want, you can add an error callback to your promise to catch the rejection.


Parser does not handle reference in external file

I am using swagger-codegen(v2.2.1) for java-jaxrs and my file structure is given below
|____static
| |____json-schema
| | |____error.json
| | |____error_details.json
| | |____link_description.json
| |____swagger.json

swagger.json is referring to error.json which in turn is referring to error_details.json and link_description.json.
In error.json if I provide reference "$ref":"error_details.json" swagger codegen cannot find error_details.json and is not working. But, if I provide reference as "$ref":"./json-schema/link_description.json" (relative to swagger.json) then codegen works fine, but swagger-ui breaks.

@abhijith-prabhakar does it work if you put "./error_details.json" instead of "error_details.json"?

Yes, I have tried it.  It gives below error
io.swagger:swagger-codegen-maven-plugin:2.2.1:generate failed: Unable to load RELATIVE ref: ./error_details.json
       	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
       	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
       	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)

Oh, I think this was fixed in https://github.com/swagger-api/swagger-parser/pull/284
This was merged to master after the last release (1.0.22).

I worked with Ron and Tony to test out latest snapshot release of both codegen and parser.  It was not fixed in those as well.  It would nice if someone can double check.

Oh, I think I understand why is this happening. This is a bug indeed.

Thanks for checking.  Any ETA on the fix?

Should be fixed now.


DBZ-1402 Support for JDK 8

Supersedes https://github.com/debezium/debezium/pull/1039

LGTM, just awaiting the re-triggered build, will then rebase and apply.
Thanks a lot for your continued effort on this, @brbrown25 and thanks for wrapping it up, @jpechane! Very nice that we now can move the container images to JDK 11.

Applied 🎉 !

Thanks so much for the opportunity!
Brandon Brown
(240) 506-8335 (m)

On Nov 25, 2019, at 5:27 AM, Gunnar Morling<EMAIL_ADDRESS>wrote:

LGTM, just awaiting the re-triggered build, will then rebase and apply.
Thanks a lot for your continued effort on this, @brbrown25 and thanks for wrapping it up, @jpechane! Very nice that we now can move the container images to JDK 11.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Version 1.1.0 doesn't do anything

-showall doesn't print anything, in fact the whole thing doesn't print anything:

Also I think your release notes are wrong - the source code mentions --showall, not -showall. But that didn't print anything for me, either.

Ah, went over my head. I made a change where it won't display a terminal on a release build. I'll add this fix in v1.1.1
I went ahead and fixed the typo in the release notes

Fixed in v1.1.1


Group all tasks into a clear group

What has changed
Group all tasks to the ruler group.
Why was it changed
Sometimes, we want to double-click the task directly through the Gradle panel to execute it, but the task is currently distributed in the group called other, and it is not quickly retrieved.
Related issues
N/A

Great idea, thanks a lot for the PR!

这是来自QQ邮箱的自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

这是来自QQ邮箱的自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


Add Japanese PDF reader

I created a loader (JapanesePDFReader) to parse Japanese PDFs. Please review it.
Changes

Added JapanesePDFReader class. This class uses the pdfminer.six library to parse Japanese PDFs that the existing PDFReader cannot.

Reasons for changes

The existing PDFReader had a problem of garbling some Japanese PDFs. This is probably due to the character encoding, as the PyPDF2 library used in PDFReader does not support parsing characters other than utf8.
As an example of a PDF that garbles, I give the following URL.

https://www8.cao.go.jp/chosei/koubun/about/shikumi/g_bun/kenshuu.pdf

Thank you for your cooperation.

Thanks for the PR and looks good! My only comment is: is it correct to name this loader JapanesePDFReader? Wouldn't it work for many other languages?

Thank you for the review. Sorry for the delay. Here is the intention of my last commit.

I named it CJKPDFReader. CJK stands for Chinese, Japanese, and Korean languages. As you correctly pointed out, pdfminer.six can read languages other than Japanese, so I was not confident that JapanesePDFReader was an appropriate name, but I saw that pdfminer.six’s docs said “support CJK languages”, so I thought it would be suitable to use this as the class name. https://github.com/pdfminer/pdfminer.six#:~:text=CJK languages and vertical writing scripts support

I also improved the text extraction process. The previous code sometimes failed to extract text, but the current code works better. Here is an example of a PDF that the current code can parse, but the previous code could not. https://www.beret.co.jp/books/tachiyomi/images/563.pdf

Got it -- thanks! I'll update the readme.


CI examples for each SDK

What is the issue?
Need examples of how to run Dagger pipelines in the major CI providers with each SDK: Go, Python, Node.js (TS/JS)
CIs:

GitHub Actions
CircleCI
Jenkins
GitLab
Azure DevOps - Azure Pipelines
Tekton
Travis
AWS CodeBuild/Pipeline
Jenkins X
Drone / Woodpecker
GCP CloudBuild
Buildkite
Argo
Zuul
Bitrise
CodeFresh
etc https://github.com/dagger/dagger/discussions/1677

For example:
to run a Python SDK pipeline in GitHub Actions,
have simplified example like https://github.com/dagger/dagger/pull/3774/files#diff-e07285aaf3bcc46d779c86a6995427342bfe0d222b9416cf459d3ecdb7be6bc9
or
https://github.com/patrikbraborec/good-ci-cd/blob/main/.github/workflows/pipeline.yml

In addition to the CI examples, I would like to see docker examples on linux/macos/windows.
By this I mean the environment for the given sdk to be setup inside of a docker container. I've made also an example to explain what I mean https://github.com/marcindulak/dagger-dood-nodejs, it could be improved. I believe setting the environment with docker is needed in order to further approach a reproducibility between the local development environment of dagger, running on a developer machine and the environment in a CI provider. For simple examples this may not matter, but it will be useful for complex pipelines, and when reporting dagger bugs, like https://github.com/dagger/dagger/issues/3857.
Additionally I would like the examples of different CIs, and generally all dagger examples (especially the complex ones) to be tested https://github.com/dagger/dagger/issues/2552#issuecomment-1259973039.

I agree that we should have this. Ideally, each code sample should be embedded in a tutorial which explains how to use it and provides proper context. The structure as I see it is:

code sample in a separate snippets file (so it gets tested and can be reused)
tutorial listed in "guides" page which embeds the code sample and provides steps/walkthrough
a "code samples" page under each SDK category in docs, which lists all available code samples

This allows a user to discover code samples in at least two ways ie. see all available samples via the "code samples" page (good for exploration) or find a specific sample and associated tutorial with detailed steps (good for specific problem solving).

Github: https://github.com/vikram-dagger/node/blob/main/.github/workflows/main.yml.keep
Gitlab: https://github.com/vikram-dagger/node/blob/main/.gitlab-ci.yml

GitLab Node.js SDK:
.docker:
  image: docker:${DOCKER_VERSION}-git
  services:
    - docker:${DOCKER_VERSION}-dind
  variables:
    DOCKER_HOST: tcp://docker:2376
    DOCKER_TLS_VERIFY: '1'
    DOCKER_TLS_CERTDIR: '/certs'
    DOCKER_CERT_PATH: '/certs/client'
    DOCKER_DRIVER: overlay2
    DOCKER_VERSION: '20.10.16'

.dagger:
  extends: [.docker]
  before_script:
    - apk add npm

build:
  extends: [.dagger]
  script:
    - npm run mydaggerscript

.docker:
  image: golang:1.19-alpine
  services:
    - docker:${DOCKER_VERSION}-dind
  variables:
    DOCKER_HOST: tcp://docker:2376
    DOCKER_TLS_VERIFY: '1'
    DOCKER_TLS_CERTDIR: '/certs'
    DOCKER_CERT_PATH: '/certs/client'
    DOCKER_DRIVER: overlay2
    DOCKER_VERSION: '20.10.16'
.dagger:
  extends: [.docker]
  before_script:
    - apk add docker-cli
build:
  extends: [.dagger]
  script:
    - go run main.go
    ```

Going to start with this approach.

Will re-open if more needed here.


Define multiple project subdirectories

Hey,
I have a repo that contains several sbt projects in multiple subdirectories. This action currently fails with:
plugins;stewardDependencies' exited with code 1
  /root/scala-steward/workspace/repos/myorg/myrepo doesn't appear to be an sbt project.
  If you want to start sbt anyway, run:
    /root/bin/sbt -sbt-create

Is it possible to make scala steward run in each one of the subdirectory independent projects?
Cheers, and thanks for the great project!

Hey @dimisjim, this is resolved by Scala Steward itself, it's not specifically related with the action.
Nonetheless, here you can find the answer to your question.

You can add <YOUR_REPO>/.scala-steward.conf to configure how Scala Steward updates your repository.
# It is possible to have multiple scala projects in a single repository.
# In that case the folders containing the projects (build.sbt folders)
# are specified using the buildRoots property. Note that the paths
# used there are relative and if the repo directory itself also contains
# a build.sbt the dot can be used to specify it.

# Default: ["."]
buildRoots = [ ".", "subfolder/projectA" ]

thanks, that did it!


Use all span kinds as default for metrics

Hi everyone, if this change doesn't make sense or if I missed something to configure the span kind feel free to close the PR.
Which problem is this PR solving?
Background: The span kind for some services could have another value then "SPAN_KIND_SERVER", e.g. the spans from Istio are using "SPAN_KIND_CLIENT". Because of the default span kind and the fact that the span kind is not configureable in the frontend (the query parameter is never set in the API calls) it was not possible to use the service performance monitoring with some services.
Short description of the changes
Instead of just using "SPAN_KIND_SERVER" as the default span kind for the metrics, the default value now includes all span kinds.

@ricoberger that would create a lot of noise IMHO in the metrics expected in SPM. Say, 1 server call has downstream 1000 calls to other dbs, queues and other services. With the suggested approach, all the spans will be used to calculate metrics for that 1 server call.

Closing this PR for now. Feel free to re-open if you wish to discuss further.

Hi, sorry I completely forgot about this. It's definitely ok to close the PR we tested this further during the last weeks and implemented a solution in our Jaeger frontend, where the user can select the span kind.

we tested this further during the last weeks and implemented a solution in our Jaeger frontend, where the user can select the span kind.

Nice one @ricoberger! Would you be open to contributing what you've done to the https://github.com/jaegertracing/jaeger-ui/ project? I think it's a valid use case to query on non-server span kinds and would be valuable to others in the community.

@albertteoh  a dropdown in Jaeger UI's Monitor tab to select the span kind, and perhaps cache that selection per service
This feature is applicable, if not is there any workaround to accomplish this for now?


Update to latest standards

Update versions, Makefile and whatnot to the latest standards for Sansible roles.

Closed by #12


(Request) Add ability to set download directory

As the title say, i would like to set a different directory than the downloads folder.

Hi, yep, that's a good suggestion, will do, thanks. :)

Added to the v0.0.2.
Thank you for contributing.


R scripts for data importing and processing to assess initial feasibility of "starting metformin within 10d of pos. SARS-CoV-2"

Hi Venexia,
Here are initial R scripts supposed to do the following:

Import/extract feather dataset from OpenSAFELY including basic type formatting of variables
Process the data: a) combine some categories, b) apply the diabetes algorithm, c) apply primary endpoint window (28 days) and create final outcome and exposure/treatment variables, d) add a treatment window period (grace period) that can be changed flexibly
Apply the data quality assurance and data completeness criteria
Apply the eligibility criteria
Summarize how many initiated treatment within applied grace period

I end up with three 1-line tables:

n_qa_excluded (how many excluded due to which quality assurance and data completeness criteria)
n_excluded (how many of those excluded due to which eligibility criteria)
n_treated (how many of those treated with metformin within applied treatment window (= grace period, for now at 10 days) and beyond)

Protocol here: https://docs.google.com/document/d/1Vptfzx-S981m7Th1FIDbAjwe1iUchrXFh0Y6HrVzrDQ/edit#heading=h.fim3pqbbhatr
I am sure I could have structured it a bit simpler since I based it on the (rather complex) sequential trial repo from Linda/John, but if we go down that line, then probably good to have it already.
Also, still I need to add the three 1-line tables to my yaml as an action.
Thanks a lot for your initial review - looking forward to your comments!
Best,
-Alain

Hi @alainamstutz - given that the  dataset-definition PR is now approved, do you want to merge the dataset-definition branch to main and rebase this branch so I can test the code fully before I do my review? Or would you rather I provide high level comments on the R code now?

Hi @alainamstutz. Great work on getting so much code done this week. I have added (hopefully!) helpful comments to the code and highlighted some repetitions that should be removed.
My main feedback is that this script needs to be split up and incorporated as a couple of actions. My current thinking is that might look like this:

Action 1: Data preprocessing - this would include combining categories, applying the diabetes algorithm (diabetes_algo()), any cleaning
Action 2: Quality assurance
Action 3: Eligibility criteria
Action 4: TTE stetup  - this would include stuff like applying the primary endpoint window (28 days) and add a treatment window period (grace period) that can be changed flexibly
Action 5: Feasibility  - this is the calc_n_treated stuff that might not be in the final version of the project in this form

There are a couple of reasons to split this up. Firstly, many things are happening in this script. If any one of them goes wrong and causes an error, you will lose all your progress if they are in one action. Secondly, particularly while you are exploring the feasibility, you may well be making tweaks to actions 4 and 5. There is no need to rerun data preprocessing and QA every time you make a tweak (unless the tweak requires it). Third, for downstream actions, OpenSAFELY reads in all outputs saved in the dependency actions. There is no need for later actions to read in tables detailing how many people were excluded from the study so best to separate them off.
Hope this is clear and helpful. Let me know if you want to meet to discuss.

P.S. I would also recommend increasing your population size in the dummy data so you have a bit more data to play with!

Hi @venexia - great comments! Quick one: With separate "Actions" I guess you mean separate yaml actions = separate R files for the 5 actions outlined above?


Add missing dependency to documentation

Compilation fails with error nlohmann/json.hpp: No such file or directory.
This is solved (on Debian 12) with
sudo apt install nlohmann-json3-dev
I suggest adding this as a dependency to the README (next to libsqlite3-dev and cmake).

Dependency was added to README in 4f033ad.