Add ser/de support for JSON or WorkerIdentity

What changes are proposed in this pull request?
Allow WorkerIdentity to be de/serialized to JSON and Java serialization format.
Why are the changes needed?
To be able to be embedded in WorkerInfo and other data objects that need to be de/serialized to JSON.
Does this PR introduce any user facing changes?
No.

Mostly looks good. Only one question: what about overhead of serialization and deserialization operations?

what about the overhead of serialization and deserialization operations?

I can do a microbench for that.

This is the benchmark for various ser/de and hashing operations: https://gist.github.com/dbw9580/9678c99e1738be780e54f6cf31ef3c17
Benchmark                                         Mode  Cnt         Score        Error  Units
WorkerIdentitySerdeBench.gsonDeserialization     thrpt    6    596424.879 ±  47869.911  ops/s
WorkerIdentitySerdeBench.gsonSerialization       thrpt    6    940358.153 ±  29705.502  ops/s
WorkerIdentitySerdeBench.hashByFunnel            thrpt    6  17272970.709 ± 508777.100  ops/s
WorkerIdentitySerdeBench.hashByString            thrpt    6    691748.287 ±  23444.105  ops/s
WorkerIdentitySerdeBench.jacksonDeserialization  thrpt    6    754241.763 ±  23733.690  ops/s
WorkerIdentitySerdeBench.jacksonSerialization    thrpt    6   1704082.174 ± 100981.785  ops/s

When both using default configurations, Jackson is significantly faster than Gson.
Hashing using a hasher and a funnel is two orders of magnitude faster than first turning the identity object to a string and hashing that string.

This is the benchmark for various ser/de and hashing operations: https://gist.github.com/dbw9580/9678c99e1738be780e54f6cf31ef3c17
Benchmark                                         Mode  Cnt         Score        Error  Units
WorkerIdentitySerdeBench.gsonDeserialization     thrpt    6    596424.879 ±  47869.911  ops/s
WorkerIdentitySerdeBench.gsonSerialization       thrpt    6    940358.153 ±  29705.502  ops/s
WorkerIdentitySerdeBench.hashByFunnel            thrpt    6  17272970.709 ± 508777.100  ops/s
WorkerIdentitySerdeBench.hashByString            thrpt    6    691748.287 ±  23444.105  ops/s
WorkerIdentitySerdeBench.jacksonDeserialization  thrpt    6    754241.763 ±  23733.690  ops/s
WorkerIdentitySerdeBench.jacksonSerialization    thrpt    6   1704082.174 ± 100981.785  ops/s

When both using default configurations, Jackson is significantly faster than Gson.
Hashing using a hasher and a funnel is two orders of magnitude faster than first turning the identity object to a string and hashing that string.

cool that u did the benchmark : ) , then in that case, pick one, if jackson is much faster, use jackson and get rid of gson.
if hashByFunnel is much faster then keep that as well, but make sure there isnt any known issue.

alluxio-bot, merge this please


App Configuration Provider version update

Description
Updating the version after release.

API change check
API changes are not detected in this pull request.


[Feature Request]: Adding download report button in every table for admin

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I will use the same approach that i used for the dashboard download report button.
So that the admin can use the report everywhere
Use Case
Admin engagement
Benefits
Admin enhancement
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@VaibhavArora314 I have to spilt this into 2 to 3 issues because all will have the route,controller and frontend integration, what you think?

@VaibhavArora314 I have to spilt this into 2 to 3 issues because all will have the route,controller and frontend integration, what you think?

Split this into 2 and don't split by frontend and backend work as then we won't be able to preview it. Split it into 2 parts in which the 1st part will have the download option for the first few options and in the 2nd part for the remaining.


maxSizeY does not work

Hi,
if i'm setting maxSizeY of an gridster item i can't resize it anymore. it doesn't matter if maxSizeY is null, undefined or possible value. max size x does work properly.
Example:
http://jsfiddle.net/tv9cjqv0/3/

There seems to be a mistake in http://jsfiddle.net/tv9cjqv0/3/.
maxSizeY: "item.minSizeY" should be maxSizeY: "item.maxSizeY".
For me it works fine with that change.


handling booloption(s)

hey ikt!
i am still using your menu base every day, i love so much. sorry to keep bothering, i hope you don't mind. i am having an issue with booloption which is hurting my performance because i have a stupidly low end pc.
i handle a bool like god mode, like this:
dogodmode ? godmode(1) : godmode(0);
obviously, not the best way to do this, i look at menyoo base a bit back, it seems to have a good way to handle this. but i HATE the menyoo base hahaha
do you have any advice for me to handle the bool better?
thank you,
Benjamin

Please give more context, I'm not sure what you're trying to do here.

sorry, i would like to toggle god mode (for example) without turning it on/off every tick with this check:
dogodmode ? godmode(1) : godmode(0);

This problem isn't related to this library.
You could toggle a boolean by using doing something like this:
myMen.BoolOption("Toggleable", myBooleanVariable, { "This will be toggled when this option is chosen." });

I suggest you go to GTAForums or the GTA5-Mods forums and ask there.

sorry, i don't think we are understanding each other :)
i am using gtavmenubase and when i toggle a bool, i do not want it to be handled in these ways:
if (menu.BoolOption("Godmode", dogodmode)) {
     dogodmode ? godmode(1) : godmode(0);
}

or
menu.BoolOption("Godmode", dogodmode);

void ontick() {
    dogodmode ? godmode(1) : godmode(0);
}

the problem is i only want something to happen when it is turned on/off, which is what example 1 does but example 2 is spam.
how ever, while example 1 is solution, i like the style of example 2 more... how would you suggest to do this?
thank you

if (myMenu.BoolOption("Toggleable", myBooleanVariable, { "This will be toggled when this option is chosen." })) {
	if (bool) doSomething();
	else doSomethingElse();
}

? Read the comment above it, the function itself returns true on pressing accept (enter), and inside this block you can check the new value.

it's good, but is not a prettier way to do this?

Prettier?


add example on how to add correlation_id when using hypercorn and FastAPI

Closes #78

Thanks @nesies. I think it would be nice if we were able to boil this down to just the line of code that were unique to hypercorn (and same for the other example sections), since quite a lot of the code is shared between examples - but I guess it doesn't hurt that much to just have full examples 👍


Is it possible to add a BlurFilter to a line?

I'm attempting to add a blur effect to a single line. I've been following the BlurFilter demo in the docs (except that they are using a circle instead of a line). My shape disappears completely unless I remove the shape.cache call. Is this possible with a line or is blur limited to specific shapes?
`function drawShape() {
var shape = new createjs.Shape();
shape.graphics.setStrokeStyle(10, "round")
.beginStroke(colorPalette.shape[0])
.beginFill(colorPalette.shape[0])
.moveTo(200,400)
.lineTo(1500,400);
shape.cursor = "pointer";
var blurFilter = new createjs.BlurFilter(50, 50, 1);
shape.filters = [blurFilter];
var bounds = blurFilter.getBounds();
shape.cache(-50+bounds.x, -50+bounds.y, 100+bounds.width, 100+bounds.height); // Code works if I remove this line
updateStage(shape); // Utility function that calls addChild and update on stage
}`

Answered this here: http://stackoverflow.com/questions/38173637/easeljs-is-it-possible-to-add-a-blurfilter-to-a-line/38188295#38188295


Add random keyword to Cargo.toml

r? @huonw
(rust_highfive has picked a reviewer for you, use r? to override)

Thanks!


Fix npm audit warnings for node extensions

Coverage increased (+12.9%) to 96.667% when pulling b56d5bf1faf4cb21dbeee79f1faa8208435fc693 on fix-node-extension-audit into 2fce3ef77a78f4b073f41e7e39a464bfe144c881 on dev.


Granting permissions to the server application... fails

$ ./create-azure-ad-server-app.sh
...
  ],
  "servicePrincipalType": "Application",
  "signInAudience": "AzureADMyOrg",
  "tags": [],
  "tokenEncryptionKeyId": null
}
Granting permissions to the server application...
Operation failed with status: 'Forbidden'. Details: 403 Client Error: Forbidden for url: https://graph.windows.net/62197e77-e709-4001-b7fe-93b5fadbeb59/oauth2PermissionGrants?api-version=1.6

$ az --version | head -n 1
azure-cli (2.0.52)

Any clue about what goes wrong?

Upon further investigation this is clearly about the content of manifest-server.json. Do I need to add my own values here? Or something else? My azure account should already be an administration account.
az ad app permission grant --api 00000002-0000-0000-c000-000000000000 --id b74ea588-85e1-4fdb-bec7-5f3cbb6de907 --scope "User.Read"
Operation failed with status: 'Forbidden'. Details: 403 Client Error: Forbidden for url: https://graph.windows.net/62197e77-e709-4001-b7fe-93b5fadbeb59/oauth2PermissionGrants?api-version=1.6


Model weights

Please share the model weights through Google Drive. I can't download it from Baidu Drive.

Thank you!

When I want to download weights from google drive I see this:
You need access
Request access, or switch to an account with access.
Please fix it.

When I want to download weights from google drive I see this:
You need access
Request access, or switch to an account with access.
Please fix it.

When I want to download weights from google drive I see this: You need access Request access, or switch to an account with access. Please fix it.

Sorry about that, fixed now.

Thank you.


17020 — Migrate calendar picker to PressableWithFeedback/WithoutFeedback

Details

This PR migrates CalendarPicker component from using TouchableOpacity and Pressable to PressableWithFeedback and PressableWithoutFeedback. Styling and how this component works shouldn't be changed.
Fixed Issues

$ https://github.com/Expensify/App/issues/17020
PROPOSAL: https://github.com/Expensify/App/issues/17020
Tests

Navigate to Personal Details section and then to Date of Birth
Try to change a Birth date
Verify that changing works as expected

[X] Verify that no errors appear in the JS console

Offline tests

Same as Test steps
QA Steps

Same as Test steps

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/61146594/fb01705e-5df3-408f-9089-0e4d942ae251

Mobile Web - Chrome
https://github.com/Expensify/App/assets/61146594/0c571094-74bc-43b6-b351-12fe05fb8812

Mobile Web - Safari
https://github.com/Expensify/App/assets/61146594/86beb9eb-2202-4bf2-afea-9afcd0bcfad0

Desktop
https://github.com/Expensify/App/assets/61146594/6fb28977-6b0e-4be5-8181-5934920cf2ae

iOS
https://github.com/Expensify/App/assets/61146594/edc818e8-ea3f-4da2-8610-81ce7d544f34

Android
https://github.com/Expensify/App/assets/61146594/c3762cf4-f0a0-4366-9f74-1838445d3e50

@cristipaval I'm not sure what to say, I'm assign to the issue associated with this PR as the software mansion employee
@Santhosh-Sellavel Thanks for review I'll adress all the issues ASAP

Damn! 🤦
Sorry @robertKozik! I didn't know you are from SM

@cristipaval no worries! 👌🏼 Sometimes I cannot believe myself that I'm from there 😆

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

All your @cristipaval

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.23-1 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
cancelled 🔪

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.23-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Fixing autochunking

The dask autochunking in the latest master was extremely slow since #932. After some investigation, it turned out to be because I asked the static_name_maps to be removed; this was not correct. Putting them back now
In the meantime, I'll investigate the dask chunking further

I've tested the impact of these changes in this simulation on GEMINI. The figure is from this notebook. The first two commits are in red, they still include the rechunk_callback_fields. The branch as it is up to commit 0403d91 is shown in yellow. Both have a significant speed up in the chunksizes 128, 256 and auto and removing the rechunk_callback_fields does not seem to have a real impact on the speed.

I've tested the impact of these changes in this simulation on GEMINI. The figure is from this notebook. The first two commits are in red, they still include the rechunk_callback_fields. The branch as it is up to commit 0403d91 is shown in yellow. Both have a significant speed up in the chunksizes 128, 256 and auto and removing the rechunk_callback_fields does not seem to have a real impact on the speed.

Thanks for this analysis, @reint-fischer! Good to see that with this fix, the odd slowdown for chunksize='auto' goes away, and performance is as expected
@ckehl, what do you think? Should we merge this entire branch? Or only the first two commits (and revert 8f982f7b08b085be0c893385e57a43e248c70ef3 and 0403d9189e54ec36b3577d44aa86533e0e5dc165 that removes the fieldfilebuffer.rechunk_callback_fields)

Thanks for this analysis, @reint-fischer! Good to see that with this fix, the odd slowdown for chunksize='auto' goes away, and performance is as expected
@ckehl, what do you think? Should we merge this entire branch? Or only the first two commits (and revert 8f982f7b08b085be0c893385e57a43e248c70ef3 and 0403d9189e54ec36b3577d44aa86533e0e5dc165 that removes the fieldfilebuffer.rechunk_callback_fields)

I ran the performance notebook again with the branch as of the latest commit, and here it seems not much has changed in terms of performance.

I ran the performance notebook again with the branch as of the latest commit, and here it seems not much has changed in terms of performance.


publish: disable btn on form changes

the dirty prop of Formik stores if the form was changed.
for text field, the setFieldValue is called only onBlur, when the
cursor leaves the field.
if the user edit the text field, without leaving it, the dirty prop
will not change value.
partially fixes #794

Corner case:

the user edits/changes a text field
the user leaves the field, without putting the focus anywhere else
the user clicks the Publish button
the Publish btn becomes disabled

https://user-images.githubusercontent.com/2089455/155186771-16dfbfd0-7421-4bdb-a47e-8a7729bd81d0.mp4
This is because, when the user clicks on the Publish btn:

the onBlur of the text field triggers
the dirty of the form becomes True
the Publish button is disabled before the click event

Possible workarounds:

we refactor the form that the Publish btn triggers a Save first. This would fix everything?
we add a small tooltip to the disabled Publish btn explaining why (fix errors/save first/no files uploaded yet), see how here
we add a label close to the btn saying Unsaved changes when there are unsaved changes, at least is explains why the Publish btn is disabled.

After discussions, this is not a great solution.
The ideal solution, which will be implemented later on is:

enable form auto-save (optional)
automatically save when publishing


Export configuration of demo website doesn't work anymore

Hello,
On the demo website, when you click export to export current configuration, it open a new blank page and then, nothing happen...

Same problem here. Is that project died? :(

also, #16 explains why

IE11 opens a page which URL is data:image/png;base64.... but still nothing happens

Also opening in Safari works - however, the image is static. I wonder if this is only an issue with the demo, and if I install the dependecy locally in my project, it might work?


fix(content-switcher): fix code syntax in readme

Overview
Wasn't rendering correctly on website

Since it doesn't look like the site uses asides, I removed the syntax for asides to ensure correct rendering on site.

👍 ✅

👍 ✅


Calling EnvelopesApi.createEnvelope with a callback causes a superagent error

return this.envelopesApi.createEnvelope(this.accountId, {'envelopeDefinition': env}, (error, data, response) =>{
                logger.debug(response);
            });

When this is run, the following error is generated:
Warning: superagent request was sent twice, because both .end() and .then() were called. Never call .end() if you use promises
request-base.js:235
Warning: .end() was called twice. This is not supported in superagent

This causes the resulting response text to contain 2 JSON objects which casues a JSON.parse sytax error:
text: '{"envelopeId":"00000000-0000-0000-0000-000000000000","uri":"/envelopes/00000000-0000-0000-0000-000000000000","statusDateTime":"2020-07-07T06:33:22.2700000Z","status":"sent"}{"envelopeId":"00000000-0000-0000-0000-000000000000","uri":"/envelopes/00000000-0000-0000-0000-000000000000","statusDateTime":"2020-07-07T06:33:22.2700000Z","status":"sent"}'

All good, found the issue. Soz.


Roslyn style rules csharp_space_between_parentheses don't have false value in doc

Issue description
Roslyn rule option csharp_space_between_parentheses don't have value false in list of available values.
I checked these two related threads:

https://github.com/MicrosoftDocs/visualstudio-docs/issues/1461 (@gewarren said about none value)
https://github.com/MicrosoftDocs/visualstudio-docs/issues/513 (@gewarren said about false value)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cf6d446d-5426-c75f-1210-4f998a4c6eba
Version Independent ID: 8811a4cf-6a12-89ca-ac2b-4ee16c7c59b9
Content: C# formatting options - .NET
Content Source: docs/fundamentals/code-analysis/style-rules/csharp-formatting-options.md
Product: dotnet-fundamentals
GitHub Login: @gewarren
Microsoft Alias: gewarren

Associated WorkItem - 189689

Please reopen:
This section specifies twice about how any other value (including false) disables the setting. It does this first in the option table with the description "Never add spaces between parentheses" for "false (or any other value)".
Then immediately after the table: "If you omit this rule or use a value other than control_flow_statements, expressions, or type_casts, the setting is not applied."
I think the intent for a false value is for the spaces between parentheses to be ignored, meaning new spaces are not added, but neither are existing spaces removed. The "Never add spaces" description and the "setting is not applied" statement below it might technically mean the same thing, but the wording is ambiguous and potentially redundant.
But both descriptions don't address the underlying issue: the documentation does not specify a default option value. It appears to be the only formatting option that doesn't have one (37 option names, 36 default values). It seems like the default could be false or maybe ignore, but shouldn't it at least be something?


Add HTTP User-Agent header to API calls

Fix issue #232

LGTM -- thank you for the contribution!
There are styling changes that I didn't expect, but we are planning on a round of maintenance work (#235) and I'd like to get this PR merged sooner rather than later.

Actually i'm use pycharm to edit, and style changing happened because of it. could you label this pull request with hacktoberfest-accepted? thanks

Thanks @Alireza-Sampour!


Add support for "make install"

This patch adds support for installation of Tiny3D into $N64_INST.
The main benefit of this is that it simplifies usage of Tiny3D in different projects as there is no more a $T3D_INST variable to set in the environment.
This PR creates a new file t3d-inst.mk, a variant that is installed as $N64_INST/include/t3d.mk. This file is extremely minimal: it just adds -lt3d to LDFLAGS and define a macro for the $N64_INST/bin/gltf_to_t3d tool. I'm honestly not even sure if this would be required anymore. We could simply part with the concept of a t3d.mk and let user Makefiles just add N64_LDFLAGS += -lt3d to link with Tiny3D.
For instance, this is the diff currently required fo a sample to build with the installed version of Tiny3D:
diff --git a/examples/12_uv_gen/Makefile b/examples/12_uv_gen/Makefile
index e60fd8d..f23f02f 100644
--- a/examples/12_uv_gen/Makefile
+++ b/examples/12_uv_gen/Makefile
@@ -2,7 +2,7 @@ BUILD_DIR=build
 T3D_INST=$(shell realpath ../..)

 include $(N64_INST)/include/n64.mk
-include $(T3D_INST)/t3d.mk
+include $(N64_INST)/include/t3d.mk

 N64_CFLAGS += -std=gnu2x -Os

Is the above much better than the following?
diff --git a/examples/12_uv_gen/Makefile b/examples/12_uv_gen/Makefile
index e60fd8d..bf2ad11 100644
--- a/examples/12_uv_gen/Makefile
+++ b/examples/12_uv_gen/Makefile
@@ -1,10 +1,9 @@
 BUILD_DIR=build
-T3D_INST=$(shell realpath ../..)

 include $(N64_INST)/include/n64.mk
-include $(T3D_INST)/t3d.mk

 N64_CFLAGS += -std=gnu2x -Os
+N64_LDFLAGS += -lt3d

 PROJECT_NAME=t3d_12_uv_gen

@@ -25,7 +24,7 @@ filesystem/%.sprite: assets/%.png
 filesystem/%.t3dm: assets/%.glb
        @mkdir -p $(dir $@)
        @echo "    [T3D-MODEL] $@"
-       $(T3D_GLTF_TO_3D) "$<" $@
+       $(N64_BINDIR)/gltf_to_t3d "$<" $@
        $(N64_BINDIR)/mkasset -c 2 -o filesystem $@

 $(BUILD_DIR)/$(PROJECT_NAME).dfs: $(assets_conv)

Obviously t3d.mk keeps the door open in case other changes are necessary. Not sure which would be, though.

I personally like the idea of abstracting the act of adding T3D to your Makefile behind a one-liner that includes t3d.mk so I'd be in favor of keeping it unless there are some obvious drawbacks to doing that

Is this our new recommendation for any new "plugin" to libdragon? The convention is then having a .mk file in $(N64_INST)/include. There is one more thing we need to standardise and that is how to "install" the plugin. A root makefile makes sense but the tools one should also be included in that I believe.
Thinking on how this will be handled in the cli, it will create a submodule for the plugin, make install it and the code includes the .mk file to use the plugin library.

Thanks for the changes!
I see 3 main scenarios to support:

Global install would be what this PR adds, so just an easy install globally, and users don't have to worry about other things like Env vars.

A local install: use-cases being pinning a version or having a custom modified t3d bound to a project, without having to globally re-install when switching projects.
This would almost work, but the headers now point to the wrong global directory without a .mk file.

Dev install: (working on t3d itself) is pretty much the same, just that the example projects are used to develop so they need to trigger a recompile of t3d.
This should be unaffected here.

I think i would want to keep the t3d.mk, and inside the file check if a T3D_INST is set or not.
If it is set, it would do the same things as now: setting the lib / include / gltf  path to T3D_INST.
If not set, it would only set the lib via N64_INST, and nothing else.
This should allow to drive which t3d install use via an env. from the outside, or makefile.
And it would be backwards compatible with users using t3d.mk + T3D_INST right now.

One doubt I have is switching between local vs global library requires a change in the consuming makefile which will also be required to build a dockerized project even though t3d is apparently “local”. It would be best if we could have a single entrypoint. It is a little weird that docker users use the global method.
@HailToDodongo maybe you already mean to install a single mk that will be compatible with both based on the env. variable but won’t require a change going forward. Still the old installs with local mk will continue to work. Is thar what you suggest?

Yes, there would be no braking change in both the PR as of now, and with a version that checks T3D_INST in t3d.mk.
In fact nothing would change at all by default for both new, old and docker users.
The fact that build.sh now always installs it globally is not an issue, since you are not forced to actually use it there
But it would allow you to now omit T3D_INST and letting it "fall-back" to the global install.

Just noticed, this PR references t3d-inst.mk which doesn't exist
I misread as the current t3d.mk being installed under that name, if it doesn't then the T3D_INST check i mentioned would not be needed

I've pushed an update. Now there are two supported installation:
Global install
Use make install to install Tiny3D into N64_INST (next to libdragon). Then a project can simply include the mk file to link Tiny3D:
include $(N64_INST)/include/n64.mk
include $(N64_INST)/include/t3d.mk

Local install
If a project wants to have a local version of Tiny3D (for location modifications, or just pinning), it is sufficient to include the mk from the local copy:
include $(N64_INST)/include/n64.mk
include path/to/t3d.mk

The local copy must still be built by itself, no dependency between the project and the library build system is added.
T3D_INST is no more. I've updated the README too.
I've renamed the library itself from t3d.a to libt3d.a as this allows to use the -l GCC option, which is more standard.
In the future it might be nice if the local installation mode also automatically rebuilt tiny3d if necessary, so that it is built just like it's part of the hosting project, but this can be a separate PR.

Only thing I would comment on here is how T3D headers are copied. Splitting them off into a separate folder and targetting that would be the more proper way to do it but doing it like this is fine unless T3D starts growing a bunch more APIs in the future.

Well, if you check your /usr/include, it is a mixed bag of headers for all dev packages you ever installed on your computer. The general idea of having a single prefix is that it is already part of your include path, so you can just include files from there, and even link library just with -Lname without having to have special paths (and/or .mk files) for each and every library you have installed in your computer.

Perhaps my previous comment wasn't clear enough. I was referring to splitting off headers on the side of Tiny3D's repo (making an include folder here), not on the installation folder side.


[Bug] InsertRowCommand not work, cellValue not showing

Before you submit this issue, have you checked the following

[X] Is this really a problem?
[X] I have searched the Github Issues for similar issues, but did not find anything.

Affected packages and versions
v0.1.7
Reproduction link

Expected behavior
To execute InsertRowCommand that can be work. Just insert row but not insert cellValue.
Actual behavior
execute InsertRowCommand can not work.
System information
No response

Thank you for your question, we will fix it as soon as possible


Updated testing b-values with a more realistic set

Fixes #10
Tried to update the unit testing b-values with literature-supported values. the values are obtained from a public dataset.
I found other values as well in this paper: https://onlinelibrary.wiley.com/doi/10.1002/mrm.26783

12 b-values (1.4, 5, 10, 20, 35, 50, 75, 100, 201, 401, 602, and 802 s/mm2)

@etpeterson  @oliverchampion  Not sure which one has the better representation so please try both and let me know.
Values source:
https://figshare.com/articles/dataset/IVIM_dataset/3395704?file=5305246

Unfortunately that whole file needs to be regenerated if the b-values change. I responded in more detail in the issue.


Unite any-pair and pair in input

pair? and any-pair? basically do almost the same thing.
Try to find a way to merge them

Linked to: #43


Is theme Full Screen?

Thanks in advance for the great work. Not sure if its a bug or I installed improperlly. But shluld it be full screen, if not how would I make these changes? Please see depicted screenshot using rails 7.

While I don't know if this is the proper way, this is how I achieved it :)

body.active_admin #wrapper {
  max-width: 98% !important;
}

@media only screen and (min-width : 993px) {
    body.active_admin #wrapper {
    width: 98% !important;
  }
}

@media only screen and (min-width : 601px) {
  .container, body.active_admin #wrapper {
    width: 98% !important;
  }
}


Feature/openlayers amplify

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This example demonstrates how to use OpenLayers with Amazon Location Service and AWS Amplify.
https://dev.to/aws-heroes/building-a-map-application-with-amazon-location-service-openlayers-and-aws-amplify-2f54

Hi @dayjournal, thank you for opening this PR.
Please give me a few days to review the PR and provide comments.
I'll be in touch here once I have reviewed, but you can expect a reply by early next week at the latest.

Hi, @dreamorosi , OK!
Please let us know if you have any questions.

Hi, @dreamorosi. I have modified my PR.

@dreamorosi Thank you!!


[BUG] quick_start_coco.ipynb demo fails

Bug Report Checklist

[x] I provided code that demonstrates a minimal reproducible example.
[ ] I confirmed bug exists on the latest mainline of AutoGluon via source install.
[x] I confirmed bug exists on the latest stable version of AutoGluon.

Describe the bug
I am unable to run the AutoMM Detection demo (quick_start_coco).  I've tried in different environments and keep getting an error with being unable to import mmcv.  A demonstration notebook is attached.  Note that this is despite the presence in the script of !mim install "mmcv==2.1.0".
Expected behavior

To Reproduce
An example script with the output I saw is attached.  Basically, I can't get the demo to run either on SageMaker Studio Lab or in a SageMaker Notebook instance.
quick_start_coco.ipynb.zip.
Screenshots / Logs

Installed Versions

# Replace this code with the output of the following:
from autogluon.core.utils import show_versions
show_versions()

A kernal restart is required if the package is installed in the notebook. Closing the issue. Feel free to reopen it if restarting the notebook kernel does not help.


fix: allow spaces in DB names

SUMMARY

When adding a database, we currently .trim() its name on inputChange, preventing users from typing spaces:
https://user-images.githubusercontent.com/1534870/112527680-899bd480-8d60-11eb-9ad5-fbeabfa1968b.mov
With this fix, we trim only when validating, testing the connection, editing or creating:
https://user-images.githubusercontent.com/1534870/112527746-9caea480-8d60-11eb-874f-0605c5be56f2.mov
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See above.
TEST PLAN

See above.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

LOVE this!

/testenv up


board: arm: add initial support for Silabs Happy Gecko EFM32HG

Added Gecko SDK for Silabs Happy Gecko EFM32HG family
Signed-off-by: Marcio Montenegro<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@18f366c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6078   +/-   ##
=========================================
  Coverage          ?   52.76%
=========================================
  Files             ?      414
  Lines             ?    40210
  Branches          ?     7791
=========================================
  Hits              ?    21217
  Misses            ?    15782
  Partials          ?     3211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f366c...ea37559. Read the comment docs.

Hi Kumar,
My first idea was to  submit  1 pull request for Gecko SDK and another pull
for board,examples,docs, etc...
On Fri, Feb 9, 2018 at 12:38 PM, Kumar Gala<EMAIL_ADDRESS>wrote:

@galak requested changes on this pull request.
Also, we need to be able to test code, so would need an SoC port & board
port that uses EFM32HG before this gets accepted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zephyrproject-rtos/zephyr/pull/6078#pullrequestreview-95438943,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGH6SYKn8KUYLLw_2QTj8238XRbTpJAzks5tTFhsgaJpZM4R_8KA
.

Hi Kumar,
My first idea was to  submit  1 pull request for Gecko SDK and another pull
for board,examples,docs, etc...

Its best to have it all in one PR, but just separate commits, one for the SDK import, one for SoC, and one for board.

You can have a look here on how to structure the commits: https://github.com/zephyrproject-rtos/zephyr/pull/271/commits

@galak This pull request is obsolete and can be closed. It is part of https://github.com/zephyrproject-rtos/zephyr/pull/6945

Olá,
Eu acabei de assinar o abaixo-assinado "Duarte Nogueira: LIBERTEM A
ELEFANTE BAMBI" e queria saber se você pode ajudar assinando também.
A nossa meta é conseguir 200.000 assinaturas e precisamos de mais apoio.
Você pode ler mais sobre este assunto e assinar o abaixo-assinado aqui:
http://chng.it/zVM9JvLdfC
Obrigada/Obrigado!
Marcio


avoid too much error logs for non-fatal errors in data-path

These logs are only printed on read/write error path, I think it's good to have these error messages logged, otherwise we don't know where went wrong and why.
Do you have a case that these logs seem not necessary? I may have missed anything.

These logs are only printed on read/write error path, I think it's good to have these error messages logged, otherwise we don't know where went wrong and why.
Do you have a case that these logs seem not necessary? I may have missed anything.

In some cases, non-fatal errors such as disk full errors can generate a large amount of useless logs (which only require user attention). Therefore, I believe that errors related to read/write request are better suited for metrics rather than logs.

Sound reasonable to me. @eryugey Any comments?


Unify alphabets

This PR unifies all alphabets into a single alphabet OnTheFlyAlphabet. Further, the PR includes updates to functions using alphabets to reflect introduced changes.
This PR covers the basic unification of alphabets as agreed upon in the last meeting. Additional modifications to alphabets which were suggested in the meeting will be added gradually when the wrapper is removed.
Merging this PR allows us to remove NfaWrapper as proposed in #55.

I have no problems with the PR, so we can merge it.


data: Panquesito7

Changes proposed

Update my profile.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Note to reviewers
None.

Rest looks good to me, but I think we recently removed the color feature in milestones, and default it to grey.
So, we might not need the color key in milestones anymore.

Should I remove them in this PR or?

Should I remove them in this PR or?

Yep, it would be great if you remove those from this PR.


Acquiring more labelled training images

Currently the 0.0.4 dataset provides 125 training images of each class.  If we want to train on more images, are there any resources to make it easier to acquire more labelled images that are valid and unambiguous, or do we need to re-implement the tasker evaluation ourselves?
If we use the IDs in bird-or-bicycle/bird_or_bicycle/metadata/0.0.4/, it looks like we can get close to 1000 more images of birds that have been verified by taskers, but no more images of bicycles are available for training from there.  Anything else I am missing?

I don't think we've collected more high quality labeled examples in train. The extra dataset has something like 27k more images that we've found helpful for training a classifier. I've been able to train a single linear layer on top of ImageNet features using the extra dataset to get ~99% test accuracy. But as you say, they're not filtered correctly.

Thank you.  Seems like getting more images of bicycles might take the most work.  In my random sample of bicycles from extras/, 1/20 (5%) looked to me like they meet the requirements; I took another random sample, and 4/34 (12%) looked to me like they met the requirements; though I see from tasker_labels_0.0.4.csv that about 289/1322 (22%) met the requirements.  I'm not sure why there was such variability among those three estimates (perhaps you all did some filtering before feeding images to taskers? or perhaps I just got unlucky in my random samples?).  So if we filter extras, I'm guessing we might be able to obtain ~ 10000 good training images of birds and between 800-3000 good training images of bicycles, but this will require us to do the filtering ourselves.  Thanks for the information.


ZH-trans: add kubeadm_alpha_phase_certs_apiserver

ZH-trans: add kubeadm_alpha_phase_certs_apiserver-etcd-client.md

@xichengliudui Sorry, I just want to say our current base branch is release-1.12.
If you find not fixed there, we need to fix in v1.12 first.
After that we can have a zh-i18n v1.12 release.
Thanks!

/hold

looks like the base branch is not originally from release-1.12, a new PR might be required

/hold cancel
/lgtm
/approve

11960


compilation error in platformio

flatform espressif 5.3.0 mcu esp32-s2
arduino framework
src/main.cpp: In function 'void handleLed()':
src/main.cpp:88:44: error: 'class FSWebServer' has no member named 'getRequest'; did you mean 'handleRequest'?
WebServerClass* webRequest = myWebServer.getRequest();

With latest release, library should compile without problems with Platformio (tested)


Update db command

Please rename Hello to the corresponding class name on each file.
We use I at the beginning of each interface name not at the end. To be consistent with the rest of the project, please rename your interfaces as well.

Fixed issues that you mentioned

This is the output of db -h command:
display commands for working with databases

USAGE
  $ liara db COMMAND

COMMANDS
  db backup  manage backups for a database
  db create  create a new database
  db list    list available databases
  db ls      list available databases
  db off     stop a database
  db on      resize a database
  db remove  remove a database
  db resize  resize a database
  db rm      remove a database
  db start   start a database
  db stop    stop a database

Let's remove the db off and db on commands.

To create subcommands for the backup command, you don't need to do it manually. You should create a directory for it in the db directory, like this:
db/
    list.js
    create.js
    backup/
        list.js
        create.js

Please review again. If there are still issues, let me know.

After merging this, we will release a beta version so we can use these new commands before launching them.

At least i can fix my bugs😅
Mohammad Hossein Ebadollahi @.***> schrieb am Mi., 27.
Sept. 2023, 16:07:

After merging this, we will release a beta version so we can use these new
commands before launching them.
—
Reply to this email directly, view it on GitHub
https://github.com/liara-cloud/cli/pull/123#issuecomment-1737312576, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANMCQZZEXKW6F33DGFSDXHLX4QMZLANCNFSM6AAAAAA4EEWUKY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Please make sure to do the requested changes.

I downloaded the backup file, included the table flags in the db:backup:list command, and utilized the bytes package. What other tasks do I need to complete? I simply did not implement the suggestion for the db:create command regarding network flags. This is because I would like to prompt the user for the network if they do not provide the --network flag.


Enable istio monitoring using external prometheus

Describe the feature request
we are looking to have one monitoring dashboard for whole kuberenets ( logging, istio, services that not running with istio proxy).
We deployed pormetheus and grafana using stable helm versions:
helm install -f ./monitoring/prometheus-values.yaml stable/prometheus --name prometheus --namespace monitoring
And
helm install -f ./monitoring/grafana-values.yaml stable/grafana --name grafana --namespace monitoring
Our prometheus values file: (yaml)
prometheus-values.txt
Is there any way that we can configure our promethues to get data from istio?
Describe alternatives you've considered
An alternative option that we tried is to connect our grafana to two promethues sources ( one external, and one from istio) it succeeds to connect but we don't see any data coming when we install an istio mesh dashboard

@douglas-reid this url throwing 404.

This is now the URL: https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/charts/prometheus/templates/configmap.yaml

I'll also add that the new istio/installer comes with prom operator configuration as well, which should provide a mechanism for this as well.
Closing for now.

I think we should use Prometheus Federation to resolve your question. We are tring this..

We have  already deployed prometheus on k8s cluster , and the how the istio using the existed prometheus?

These yaml works for me
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: prometheus-oper-istio-controlplane
  namespace: istio-system
  labels:
    release: prometheus
spec:
  jobLabel: istio
  selector:
    matchExpressions:
      - {key: istio, operator: In, values: [mixer,pilot,galley,citadel,sidecar-injector]}
  namespaceSelector:
    any: true
  endpoints:
  - port: http-monitoring
    interval: 15s
  - port: http-policy-monitoring
    interval: 15s

apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: prometheus-oper-istio-dataplane
  namespace: istio-system
  labels:
    monitoring: istio-dataplane
    release: prometheus
spec:
  selector:
    matchExpressions:
      - {key: istio-prometheus-ignore, operator: DoesNotExist}
  namespaceSelector:
    any: true
  jobLabel: envoy-stats
  endpoints:
  - path: /stats/prometheus
    targetPort: http-envoy-prom
    interval: 15s
    relabelings:
    - sourceLabels: [__meta_kubernetes_pod_container_port_name]
      action: keep
      regex: '.*-envoy-prom'
    - action: labelmap
      regex: "__meta_kubernetes_pod_label_(.+)"
    - sourceLabels: [__meta_kubernetes_namespace]
      action: replace
      targetLabel: namespace
    - sourceLabels: [__meta_kubernetes_pod_name]
      action: replace
      targetLabel: pod_name

original post: https://zhuanlan.zhihu.com/p/281747776


api::path::resource_dir does not return correct path for AppImage bundle

Describe the bug
The resource directory for the appimage bundle should be relative to the APPDIR variable (something like /tmp/.mount-xxxx/), but the system wide resource dir is returned instead.
To Reproduce
Steps to reproduce the behavior:

Print the results of api::path::resource_dir when running the appimage bundle

Expected behavior
A path relative to APPDIR is returned.
Platform and Versions (please complete the following information):

OS: Linux
Node: 15.8.0
NPM: 6.14.11
Yarn: 1.22.10
Rustc: 1.50.0
Additional context
Add any other context about the problem here.
Stack Trace

This should be an easy fix. Just have to check if the APPDIR variable is set and if so return paths relative to it. I'm going to try and solve this one, and hopefully should have a PR soon.


Command Help Fixes

The help messages embedded in each of the command line utilities are now printing. I removed parseHelp() and the Help struct from cmdr. I removed the Usage() function that gave Help as its receiver. I removed the unused PrintHelp() function. The help string for the top-level sous command was modified to match what the tests expect. Subcommands have individual short descriptions when described in the help message of the parent command. Modified the tests to expect much longer help messages.

Current coverage is 59.59% (diff: 100%)

Merging #233 into master will decrease coverage by 0.12%

@@             master       #233   diff @@
==========================================
  Files           128        128
  Lines          6766       6740    -26
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           4041       4017    -24
+ Misses         2363       2361     -2
  Partials        362        362

Powered by Codecov. Last update 80a600e...907d5d0

I consider this to be "better," not "fixed." I'm happy to keep going. This is passing what tests we have and no longer losing the bulk of help messages, so I'd like to get these changes into master sooner rather than later.

Totally agree! Cheers!


feat: add simple progress indicator

Fixes #143

@jokasimr docs build often hangs and it looked like hanging again so I canceled/rerun the job.
And it seems like there is a merge conflict...?

@YooSunYoung the merge conflict is fixed now.
Do you think the hanging is caused by this change or is that something old?


Current Problems

So far, PyBroom can remove unused variables. But the problem I am facing is that there are a lot of possible scenarios where the current code would not work. Like here:
i=0
h=0
print(h)

So, ideally, the "i" variable should not be kept, but it would, since "print" has the letter i in it.
Or here:
blah='''blah
blah='''

The "blah" variable isn't doing anything, but it would still be kept because the program finds two "blah=" instances.
Another scenario:
blah='blah'
blah_a='blah'
blah_a_a='blah'

Since all the variable names have the word "blah" in them, it would keep everything except for the last one. If I added something like "print(blah_a_a)" it would keep all the variables.
So I need help coming up with solutions to these problems. And after a lot of thinking I am still completely at a loss for how to write the code for these solutions, so it would be very helpful if you could give me the actual code I need to solve these problems.

The repository is now public! :)


StringValueTooLong message:"string value is too long. It has been truncated to 1024 characters." props:"{value:/callback#access_token=...}

Related to #49 - I am still getting warnings about a string being too long and thus truncated in versions 6+ of angular-application-insights.
I seems this issue was fixed in 5.0.4 but somehow it's made its way back in.

It seems like it's related to the applicationinsights-js underlying package itself, can we see if there's an issue over there - maybe they're working on it - if not we should definitely raise it up to them, maybe it's an easy fix we can get a PR in to fix it over there :+1:

I also have this warning.
Using :

<EMAIL_ADDRESS>"~7.2.0"
"@markpieszak/ng-application-insights": "^7.0.1"

It seems this may be an existing issue within ApplicationInsights-JS itself, https://github.com/Microsoft/ApplicationInsights-JS/issues/286
Are there many tracking events firing off too quickly that's maybe causing this to happen?

This issue is now fixed? https://github.com/Microsoft/ApplicationInsights-JS/issues/751
However it's only in the 2.0.0 release, so you plan to upgrade this library to use the new version?

Ahh I didn't see they moved to 2.0!
Ok let me make the necessary changes - hopefully there aren't too many big ones and I can get an upgrade for the library here.

Just giving some context here from the JS SDK. App Insights limits the length of strings for telemetry. The warning only reflects the app insights world and the actual string is not truncated at all, only in the telemetry will it be truncated.
The referenced fix will not get rid of the warning. It only changed the fact that now the console warning shows the full, untruncated string. Disabling verboseLogging (or the equivalent for this SDK) should suppress the warning.


YouTube videos aren't playing

Your browser does not currently recognize any of the video formats available

This is a very well known issue. The only way to get around it right now is to switch to the Chromium Branch.
Instructions for how to do that can be found here: https://www.solsticegamestudios.com/forums/threads/tutorial-switching-to-chromium-branch.849/


Log flooded with k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:156: Failed to watch *unstructured.Unstructured: unknown

Fixing #1914 with #1920 unearthed these log messages "flooding" the log, every 30-40 secs.
We should probably address them.
E0308 10:51:01.933073       1 reflector.go:127] k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:156: Failed to watch *unstructured.Unstructured: unknown
E0308 10:51:48.171557       1 reflector.go:127] k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:156: Failed to watch *unstructured.Unstructured: unknown
E0308 10:52:26.532414       1 reflector.go:127] k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:156: Failed to watch *unstructured.Unstructured: unknown
E0308 10:53:12.454226       1 reflector.go:127] k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:156: Failed to watch *unstructured.Unstructured: unknown
E0308 10:53:53.316304       1 reflector.go:127] k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:156: Failed to watch *unstructured.Unstructured: unknown
E0308 10:54:50.151394       1 reflector.go:127] k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:156: Failed to watch *unstructured.Unstructured: unknown
E0308 10:55:48.143438       1 reflector.go:127] k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:156: Failed to watch *unstructured.Unstructured: unknown
E0308 10:56:40.053902       1 reflector.go:127] k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:156: Failed to watch *unstructured.Unstructured: unknown

What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Diagnose information (use subctl diagnose all):
Gather information (use subctl gather)
Cloud provider or hardware configuration:
Install tools:
Others:

Depends on: https://github.com/submariner-io/submariner-operator/pull/2126

@mkolesnik is this still valid?

This is still happening even after the K8s upgrade:
[cluster1] E0830 16:14:52.314739       1 reflector.go:138] k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *unstructured.Unstructured: unknown
We don't specifically watch the Unstructured type anywhere. I winder if this is related to the Secrets resource syncer.

Let’s try removing that then: https://github.com/submariner-io/submariner-operator/pull/2253


Move Sonos services to sonos domain

Breaking Change:

Sonos-specific services have been moved from the media_player domain to the sonos domain. For example, media_player.sonos_join has become sonos.join.
Services sonos.set_sleep_timer, sonos.clear_sleep_timer, sonos.update_alarm and sonos.set_option now require the entity_id parameter and will not target all when it is missing. You can use all to target all.

Description:
Move Sonos services to sonos domain.
While we are breaking things anyway, I added support for ENTITY_MATCH_ALL though I made it optional for join/snapshot services where it is common to target all.
Related issue (if applicable): fixes #15089
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9380
Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox.
[X] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

@amelchio Something funky is going on since this was implemented... I use a flow which does:
snapshot, stop, unjoin, join, announce, wait, restore.
It now cuts off 1 second into the announce, I can reproduce this easily by making a simple flow with:
snapshot, join, announce.... the announce is always cut off.

@Swiftnesses Please open an issue -- we can't track problems on merged PRs.


Provide support for ssh-sk for Nova

Provide ssh-sk based keys for use within Nova providing users with the ability to further secure SSH access to their instances.
This has been achieved with by bumping the cryptography package to version 43.0.0 which includes https://github.com/pyca/cryptography/pull/10608.

@mnasiadka not sure why it is failing to build. I see INFO:kolla.common.utils:Added next task BuildTask(nova-compute) to queue and then nothing from nova-compute until the end when it says "failed": [{"name": "nova-compute", "status": "building"}]


feat(NumberTheory/Padics/RingHoms): add the equivalence between the residue field of Z_p and ZMod p

We construct the equivalence between the residue field of Z_p and ZMod p in terms of the IsLocalRing.ResidueField declaration.
Co-authored-by: María Inés de Frutos Fernández @mariainesdff

bors d+

bors r+


⚠ Bofrost.at has degraded performance

In 8c3670f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1349 ms

Resolved: Bofrost.at performance has improved in 3b2bd6f after 308 days, 20 hours, 59 minutes.


Added new test cases for below OPAL features

1. Hardware monitoring sensors(hwmon driver) using sensors utility
2. Switch endian sys call test which is implemented in linux git repository

For the above two features source files OpTestSensors.py and OpTestSwitchEndianSyscall.py are implemented in common directory
op_ci_fvt.py,test_op_fvt.py : In these files will keep adding new OPAL feature test functions, which are implemented in common directory.
op-fvt-basic.xml : In this xml file calling above test functions inorder to execute the above test functions
op-ci-bmc-run : In this file imported op_ci_fvt, inoreder to invoke the test case.
Signed-off-by: Pridhiviraj Paidipeddi<EMAIL_ADDRESS>

Committed the latest script with required changes


unicode_names2_generator as build dependency

Because generator is now deterministic, we can use it as build dependency.
And finally formatting and CI for formatting
closes #16
closes #15

Not that I'm against this change, but what does non-determinism have to do with being used as a build-dep?

No problem if everything is perfect.
But suppose we have glitch on hash or random function at edge case. With deterministic build, the full database can be tested and it guarantees the generated code doesn't have bug even if there is bug on hash or random.
With non-deterministic build, users randomly will get bugs by each build time in rare chance.

it looks like you ran rustfmt in addition to your changes in the unicode_names2_generator as build dependency commit. Could you insert a commit with only the rustfmt changes before that commit, so the commit can be read more easily?

thanks


Improve error message when spooker isn't in the path

https://github.com/CCBR/SINCLAIR/issues/53#issuecomment-1804795695

potential solution: https://github.com/CCBR/SINCLAIR/issues/53#issuecomment-1805919908

will need to propagate this fix to cruise, sinclair, and the nextflow template.


will EOS support brain key?

as subject, will EOS support brain key? just like BTS,ETH, the private key could be generated from the random words of specified dictionary, seems currently, the private key is generated from random seed.

This is not directly built into the EOSIO platform, nor is it currently in our plans.
If you still have the problem and wish to discuss further, please post it in https://eosio.stackexchange.com. To keep things organized, Github issues are intended for bugs reporting and features tracking, and Stack Exchange is the right place for any technical support discussions. Thanks!


tf.size() has no documentation

https://www.tensorflow.org/api_docs/python/tf/size
Example: "Returns the number of elements in the tensor. It equals the length of the flattened tensor."

@danijar, I want to contribute to this issue. Can you help me in doing so?
I am completely new to this world of open source.

Sorry, I can't assist you with the workflow. CONTRIBUTING.md would be a good place to get started.

@lamberta @goldiegadde Is this issue being worked on? If not, can I submit a PR?

Submitted a PR @danijar @lamberta

Thank you @copperwiring 🚀


[Event Request] Table 11401 "CBG Statement Line" in function CreateGenJournalLine

Please add a OnAfterCreateGenJournalLine event in the function CreateGenJournalLine
procedure CreateGenJournalLine(var GenJnlLine: Record "Gen. Journal Line")
var
CBGStatement: Record "CBG Statement";
begin
TestField("Account No.");
...
...
if GenJnlLine."VAT Calculation Type" <> GenJnlLine."VAT Calculation Type"::"Full VAT" then
        if ("Debit VAT" <> 0) and ("Debit VAT" <> GenJnlLine."VAT Amount") then
            GenJnlLine.Validate("VAT Amount", "Debit VAT")
        else
            if ("Credit VAT" <> 0) and (-"Credit VAT" <> GenJnlLine."VAT Amount") then
                GenJnlLine.Validate("VAT Amount", -"Credit VAT");

OnAfterCreateGenJournalLine(GenJnlLine,Rec)
end;
[IntegrationEvent(false, false)]
local procedure OnAfterCreateGenJournalLine(var GenJnlLine: Record "Gen. Journal Line"; CBGStatementLine: Record "CBG Statement Line");
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


cargo-audit: 0.13.1 -> 0.14.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/cargo-audit/versions.
meta.description for cargo-audit is: "Audit Cargo.lock files for crates with security vulnerabilities"
meta.homepage for cargo-audit is: "https://rustsec.org"
meta.changelog for cargo-audit is: ""
Updates performed

Rust version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.14.0 with grep in /nix/store/78s7cs5v89s41643nn4q0jc9v45b1irz-cargo-audit-0.14.0

directory tree listing: https://gist.github.com/f32f896f88f7bff313885f17a290eb23

du listing: https://gist.github.com/cdf4c277aad845f356e330ccaf229c3c

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
cargo-audit

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/78s7cs5v89s41643nn4q0jc9v45b1irz-cargo-audit-0.14.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-audit https://github.com/r-ryantm/nixpkgs/archive/fb42b9f4eda3c839136e58920b6680a3e5279a48.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/78s7cs5v89s41643nn4q0jc9v45b1irz-cargo-audit-0.14.0
ls -la /nix/store/78s7cs5v89s41643nn4q0jc9v45b1irz-cargo-audit-0.14.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-audit

Maintainer pings
cc @basvandijk for testing.

Result of nixpkgs-review pr 115905 run on x86_64-linux 1

1 package built:

cargo-audit


Use netty-socketio in Spring Boot

I'm using spring boot for some of my projects. So far Netty-socketio works great besides Tomcat, where Tomcat uses port 8080 and netty-socketio uses port 9000. Is it possible to somehow put them both on to the same port where netty-socketio be on 8080 along with Tomcat?
I know Netty and Tomcat are two different servers but maybe there is a way to marry them together?

Hi! I think it's hard to do this because of difference in protocols: socketio uses low-level network layer but tomcat uses servlets. To integrate them together you can write a servlet, i think.

Hi,
Any pointers towards that?
I mean porting this to tomcat.


Default opacity to 1 when fill color is set

Changelog / Overview

Enhancement for #1682
Set fill opacity to 1 by default when fill color is set

Motivation

When fill color is set it doesn't make sense to default opacity to 0, as the user would expect to see the fill color
Explanation for Changes

Makes it more intuitive setting colors

Testing Status

I needed to change the default opacity to None to handle 0 opacity from opacity that is not set. This is because svgs have their own defaults for opacity and fill color and this change would change that behaviour otherwise
Further Comments

Checklist

[X] I have read the Contributing Guidelines
[X] I have written a descriptive PR title (see top of PR template for examples)
[X] I have written a changelog entry for the PR or deem it unnecessary
[X] My new functions/classes either have a docstring or are private
[X] My new functions/classes have tests added and (optional) examples in the docs
[X] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[ ] The PR title is descriptive enough
[ ] The PR is labeled correctly
[ ] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

There was a lengthy discussion about this (or a very much related issue, didn't compare details) in #956, where it was decided not to implement this change.
Personally I feel that a more intelligently behaving fill_opacity makes sense, but I don't like that the behavior of set_color (which calls set_stroke and set_fill) is also changed with this PR.

There was a lengthy discussion about this (or a very much related issue, didn't compare details) in #956, where it was decided not to implement this change.
Personally I feel that a more intelligently behaving fill_opacity makes sense, but I don't like that the behavior of set_color (which calls set_stroke and set_fill) is also changed with this PR.

Ah I didn't realise there was a discussion about this before. So the scenario where it would affect set_color is when a user initially sets the fill, it then flips from defaulting to 0 to 1 and then it will remain at 1 when calling set_color? That behaviour seems okay to me if the user has already intended to set a fill, but I read through the other discussion and I guess there is a differing opinions on it. I guess my PR is also incomplete then because I would need to do the same for set_fill for it to be consistent
My personal experience was similar to the @sparshg who originally created the other PR. When I started using manim I was confused as to why set_fill didn't seem to be doing anything

I've now also read your code (which I should have done before, apologies): your approach and what was proposed in #956 are certainly different. I was worried that this PR changes the behavior of set_color such that whenever the fill opacity was not explicitly set to 0, set_color would also set the fill opacity to 1 -- such that Square().set_color(RED) would have produced a square with red fill.
I think that the behavior you propose here is more user friendly: after all, the case that someone explicitly specifies a fill_color upon mobject creation but simultaneously wants a fill opacity of 0 is rather strange. It is natural to expect that when a fill color is set, the mobject will actually be colored that way -- and on top of that, the old behavior can still be restored by setting fill_opacity=0.
Assuming this PR doesn't introduce problems with SVG parsing (where, if necessary the old behavior could be kept by setting fill_opacity=0 in SVGMobject.__init__), I think this is a good idea.

@behackl, my PR didn't change the behavior of set_color(), It has exactly same behavior as now, nothing changed, just added optional opacity parameter if you want to adjust both together.
The only things my PR did is
set_fill/set_stroke "If the opacity parameter is not passed, AND the fill/stroke is transparent, make the fill/stroke opaque"
which still makes absolute sense to me, why would you even fill color in transparent object without passing opacity.
This PR also does the same thing, but only during object initialization.
I still don't know why my PR was closed (except that it became a bit messy)

Assuming this PR doesn't introduce problems with SVG parsing (where, if necessary the old behavior could be kept by setting fill_opacity=0 in SVGMobject.__init__), I think this is a good idea.

I couldn't see any issues in svgs, they have the opacity defaulting to 1 and fill for paths at least seem to default to black. I did some testing with svgs but am mostly relying on the existing tests. Do you think having this same behaviour in set_fill is needed?

I think that's fine, and I actually don't see how it could produce any issue since when fill_opacity is None, manim interprets it  anyway as a 0.

I think that's fine, and I actually don't see how it could produce any issue since when fill_opacity is None, manim interprets it anyway as a 0.

Ok cool, and do you think this behaviour should also be extended to set_fill()? This PR currently only does it on initialisation

I think that's fine, and I actually don't see how it could produce any issue since when fill_opacity is None, manim interprets it anyway as a 0.

Ok cool, and do you think this behaviour should also be extended to set_fill()? This PR currently only does it on initialisation

I haven't thought of that, but sure it should be. The best way would be to create a property fill_color and to ensure that opacity is not None when the color is changed.

Maybe for another PR ?

So is this PR good to merge? Seems like it's stalled a bit...

So is this PR good to merge? Seems like it's stalled a bit...

Isn't there some consensus not to do it?

So is this PR good to merge? Seems like it's stalled a bit...

Isn't there some consensus not to do it?

Don’t think there’s a consensus either way tbh

So is this PR good to merge? Seems like it's stalled a bit...

I’m still in favour of taking this PR a little further to add this behaviour to the setters as well as the constructor, maybe we should open a discussion on discord to come to an agreement

Yes, I think we should have a (GitHub?) discussion about this, and it would be good to hear the opinion of both the core devs and the community.
Here is an attempt at boiling this situation down to two questions we might be able to have a meaningful discussion over:

From a UI/UX point of view, does it make sense that setting some property also changes the values of other mobject properties? Could there be cases where this behavior is not desireable? And if so, would, say, an INFO log entry be sufficient to make a user aware of this?
Is the situation for fill colors / opacity special enough to justify breaking the paradigm that set_property-methods should only interact with the property they are setting?

I'll close this PR. As mentioned in my previous comment, we should have a discussion about this, and if we decide to go through with this, change it consistently.


Output APK isn't accessible

Continued from https://github.com/bitrise-steplib/steps-google-play-deploy/issues/22
Build # is 4d804c79c6912ba3
Please help...
EDIT: wtf..... got the file from bitrise deploy, it's only 15 bytes. When using cat on it I get this:
sjelin.is.cool
What's going on here???
EDIT: FOUND THE PROBLEM.
https://github.com/angular/webdriver-js-extender/issues/14
^ this issue has been raised elsewhere. closing now

BUILD SUCCESSFUL

Total time: 4 mins 31.094 secs
Move apk files...
find "." "-path" "*.apk" "!" "-path" "*-unaligned.apk"
copy ./platforms/android/build/outputs/apk/android-release.apk to /bitrise/deploy/android-release.apk
copy ./node_modules/webdriver-js-extender/built/built/built/built/spec/command_tests/totally_real_apk.apk to /bitrise/deploy/totally_real_apk.apk
  1 attempt failed:
file already exists at: /bitrise/deploy/totally_real_apk.apk
  Retrying...
copy ./node_modules/webdriver-js-extender/built/built/built/spec/command_tests/totally_real_apk.apk to /bitrise/deploy/totally_real_apk20170510065708.apk
  1 attempt failed:
file already exists at: /bitrise/deploy/totally_real_apk.apk
  Retrying...
copy ./node_modules/webdriver-js-extender/built/built/spec/command_tests/totally_real_apk.apk to /bitrise/deploy/totally_real_apk20170510065709.apk
  1 attempt failed:
file already exists at: /bitrise/deploy/totally_real_apk.apk
  Retrying...
copy ./node_modules/webdriver-js-extender/built/spec/command_tests/totally_real_apk.apk to /bitrise/deploy/totally_real_apk20170510065710.apk
The apk path is now available in the Environment Variable: $BITRISE_APK_PATH (value: /bitrise/deploy/totally_real_apk20170510065710.apk)
Move mapping files...
find "." "-path" "*/mapping.txt" "!" "-path" ""
No mapping file matched the filters
|                                                                              |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                         | 280 sec  |
+---+---------------------------------------------------------------+----------+

                                          ▼

+------------------------------------------------------------------------------+
| (6<EMAIL_ADDRESS>                                             |
+------------------------------------------------------------------------------+
| id: deploy-to-bitrise-io                                                     |
| version: 1.2.9                                                               |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: bash                                                                |
| time: 2017-05-10T06:57:12Z                                                   |
+------------------------------------------------------------------------------+
|                                                                              |

=> Preparing step ...

Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
installing your bundle as root will break this application for all non-root
users on this machine.
Fetching gem metadata from https://rubygems.org/.
Fetching version metadata from https://rubygems.org/.
Using bundler 1.14.6
Installing plist 3.2.0
Installing rubyzip 1.1.7
Installing ipa_analyzer 0.1.0
Bundle complete! 3 Gemfile dependencies, 4 gems now installed.
Gems in the group test were not installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.

=> Running the step ...

========== Configs ==========
 * Build URL: https://www.bitrise.io/build/4d804c79c6912ba3
 * Build's API Token: 042P_uEt9fiEnCBz3GR40A
 * is_compress: false
 * deploy_path: /bitrise/deploy/totally_real_apk20170510065710.apk
 * notify_user_groups: everyone
 * notify_email_list:
 * is_enable_public_page: true

## Deploying single file

# Deploying apk file: /bitrise/deploy/totally_real_apk20170510065710.apk
--> Analyze the apk
W/zipro   ( 4381): Error opening archive /bitrise/deploy/totally_real_apk20170510065710.apk: Invalid file
ERROR: dump failed because no AndroidManifest.xml found
  (i) apk_info_hsh: {:file_size_bytes=>15, :app_info=>{:app_name=>"", :package_name=>"", :version_code=>"", :version_name=>"", :min_sdk_version=>""}}
--> Create a Build Artifact on Bitrise
 (i) File Size: 0.0 MB
--> Upload the apk
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    15    0     0  100    15      0     55 --:--:-- --:--:-- --:--:--    55
--> Finish the Artifact creation

## Success
(i) You can find the Artifact on Bitrise, on the [Build's page](https://www.bitrise.io/build/4d804c79c6912ba3)
|                                                                              |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                  | 6.35 sec |
+---+---------------------------------------------------------------+----------+

                                          ▼

+------------------------------------------------------------------------------+
| (7<EMAIL_ADDRESS>                                               |
+------------------------------------------------------------------------------+
| id: google-play-deploy                                                       |
| version: 1.2.2                                                               |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: go                                                                  |
| time: 2017-05-10T06:57:19Z                                                   |
+------------------------------------------------------------------------------+
|                                                                              |
INFO[06:57:19] Start installing (golang) with apt-get
INFO[06:57:19]  * [OK] Step dependency (go) installed, available.

Configs:
- JSONKeyPath: https://con***3e6
- PackageName: com.streaka.plantguard
- ApkPath: /bitrise/deploy/totally_real_apk20170510065710.apk
- Track: beta
- UserFraction: 0.5
- WhatsnewsDir:
Deprecated Configs:
- ServiceAccountEmail:
- P12KeyPath:
- UntrackBlockingVersions: true

Authenticating
Authenticated client created

Create new edit
 editID:<PHONE_NUMBER>3099026970

Upload apks
Failed to upload apk, error: googleapi: Error 403: Invalid APK file., apkInvalidFile
|                                                                              |
+---+---------------------------------------------------------------+----------+
| x |<EMAIL_ADDRESS>(exit code: 1)                       | 6.14 sec |
+---+---------------------------------------------------------------+----------+
| Issue tracker: https://github.com/bitrise-io/steps-google-play-deploy/issues |
| Source: https://github.com/bitrise-io/steps-google-play-deploy               |
+---+---------------------------------------------------------------+----------+

+------------------------------------------------------------------------------+
|                               bitrise summary                                |
+---+---------------------------------------------------------------+----------+
|   | title                                                         | time (s) |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                      | 3.21 sec |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                             | 43 sec   |
+---+---------------------------------------------------------------+----------+
| ✓ | Do anything with Script step                                  | 1.07 sec |
+---+---------------------------------------------------------------+----------+
| ✓ | Build Tools Install                                           | 131 sec  |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                       | 1.89 sec |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                         | 280 sec  |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                  | 6.35 sec |
+---+---------------------------------------------------------------+----------+
| x |<EMAIL_ADDRESS>(exit code: 1)                       | 6.14 sec |
+---+---------------------------------------------------------------+----------+
| Issue tracker: https://github.com/bitrise-io/steps-google-play-deploy/issues |
| Source: https://github.com/bitrise-io/steps-google-play-deploy               |
+---+---------------------------------------------------------------+----------+
| Total runtime: 472 sec                                                       |
+------------------------------------------------------------------------------+

INFO[06:57:24]
INFO[06:57:24] Submitting anonymized usage information...
INFO[06:57:24] For more information visit:
INFO[06:57:24] https://github.com/bitrise-core/bitrise-plugins-analytics/blob/master/README.md

EDIT: FOUND THE PROBLEM.

Ahh, so problem solved, right? @jpike88
Sorry for not getting back faster. We did check your reports and we thought that it most likely caused by something in your code/project config (not in your bitrise config or step), but as a policy we don't say that it's an issue somewhere in your code unless we can reasonably prove it first.


1.4.3 upgrade

Fixes #ISSUSE_ID
Changes proposed in this pull request:

Check mailbox configuration when submitting. Contributor Guide

1

finish


Karate chop should crit

I've discovered that Karate Chop didn't always crit for Gen 1.

Thanks for catching this!


Not able to send messages

Before we start...

[X] I've searched existing issues, but my problem hasn't been reported yet.
[X] I've read the documentation (including notes on error messages and rate limiting), but my problem is something else.
[X] I've tested the behaviour on Skype for Web, and it works there but not with SkPy.

Summary
I'm trying to send message but it's not working, It was working properly yesterday.
Code sample
from skpy import Skype

sk = Skype(username, password)

ch = sk.contacts['user-id'].chat # 1-to-1 conversation
ch.sendMsg('ok')

Code output
('400 response from POST https://azeus1-client-s.gateway.messenger.live.com/v1/users/ME/conversations/user-id/messages', <Response [400]>)

Explain your code
I'm just sending a normal message.
SkPy version
v0.10.6
Python version
3.11.4
Anything else?
No response

You didn't include the full output, so I can't see what the response from Skype was.
From the issue form:

Set the SKPY_DEBUG_HTTP=1 environment variable so that requests to the Skype API are logged.

Are you sure you're still able to message the user?
I get these 400 errors when trying to send to a chat I no longer have access to.


chore: import repository https://github.com/hughexp/jx-aspnet-app-02.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


(Data) Errors

The Data Errors subsection of [R2]RML core specification might need some updating, perhaps also considering revised test cases.

IMO the spec in R2RML is ok in this section. Apart from minor "syntactic-sugar" changes (database by source, etc) I don't think that we need to change the rest.

Shouldn't we also define errors here? I noticed that things are all different here regarding Data Errors in engines.
Some exit, some do their 'best' to map the rest, etc. even though they should give an error.
However, the latter is not very clear in the R2RML spec, could we maybe define how the error should be reported?
Example: 'Should return error' --> Error X is returned because of Y

the spec says
A conforming [R2RML processor](https://www.w3.org/TR/r2rml/#dfn-r2rml-processor) may, however, allow other operations that do not require inspecting or returning these [RDF terms](https://www.w3.org/TR/r2rml/#dfn-rdf-term), and thus may provide partial access to an [output dataset](https://www.w3.org/TR/r2rml/#dfn-output-dataset) that contains data errors. Nevertheless, an [R2RML processor](https://www.w3.org/TR/r2rml/#dfn-r2rml-processor) should report data errors as early as possible.

So... @DylanVanAssche are you proposing to be a bit more explicit with the behavior of the enignes?

@dachafra Yes, a little bit more explicit about this:

should report data errors

Reporting errors is really vague.
Would be great if we could have a set of known errors with IDs & IRIs like:

Invalid mapping rules

Incomplete Logical Source
Missing Triples Map/Subject Map/ ...
Invalid reference (broken XPath for example)
...

Data error

Invalid blablabla

Unknown error (when it doesn't fit anywhere in the defined ones)

This way, you can properly test in the test cases if a test case expects an error you return the right error.
Example: failure because of a data error, not because you made accidentally a typo in the test case mapping rules.
How exactly the engine reports this, doesn't really matter I think since that depends on the implementation, programming language, etc. Some may use exit codes, others return RDF describing the error code, etc.

I made a list of them a while ago, maybe not 100% complete, but close: https://docs.google.com/spreadsheets/d/1he_dk9IxCLsSCzSzPjBlXfTIKVycpEDhgjbnFDh8JJU/edit?usp=sharing

@dachafra Yes, a little bit more explicit about this:

should report data errors

Reporting errors is really vague. Would be great if we could have a set of known errors with IDs & IRIs like:

Invalid mapping rules

Incomplete Logical Source
Missing Triples Map/Subject Map/ ...
Invalid reference (broken XPath for example)
...

Well, invalid mappings will be reported by SHACL shapes right? Do engines need to still validate the mapping rules?

Data error

Invalid blablabla

Unknown error (when it doesn't fit anywhere in the defined ones)

Agree, but this is more a "good-to-have", move to best practices repo? (not sure)

This way, you can properly test in the test cases if a test case expects an error you return the right error. Example: failure because of a data error, not because you made accidentally a typo in the test case mapping rules.
How exactly the engine reports this, doesn't really matter I think since that depends on the implementation, programming language, etc. Some may use exit codes, others return RDF describing the error code, etc.

Well, invalid mappings will be reported by SHACL shapes right? Do engines need to still validate the mapping rules?

Yes, that's the idea for mappings.

Agree, but this is more a "good-to-have", move to best practices repo? (not sure)

Fine for me, but this would make the behavior of engines more predictable.
It is not a hard requirement though, just a suggestion :)

I made a list of them a while ago, maybe not 100% complete, but close: https://docs.google.com/spreadsheets/d/1he_dk9IxCLsSCzSzPjBlXfTIKVycpEDhgjbnFDh8JJU/edit?usp=sharing

this is super valuable!! Can I added to the agenda?

@dachafra Euhm sure, FYI this is only a list I made from experience when dealing with engines and their code. Nothing scientific :sweat_smile:

Fine for me!


Messages Not Disappearing After Sending in Copilot Chat

Problem statement
When interacting with Copilot chat, you will notice that messages are not disappearing after being sent.
Expected Behavior:
The sent message should disappear after being sent for a cleaner and more intuitive user experience.
Having user messages disappear after sending would contribute to a better user experience (UX).

Can I work on this?

@Arindam200 would you be looking to combine this issue here, with this issue #61 as well? they are slightly related and the button could just be to reset the copilot chat. let me know if you have any thoughts here and we can get some solid steps together.

perfect sounds good! will assign you to them and you can connect them both to the same PR

Just to give an update, I'm working on this.
Will send a PR Soon

sounds great @Arindam200, mention this issue when you have a PR up 👍


VS Code Live Server Problem

What version of @tailwindcss/jit are you using?
0.1.17
What version of Node.js are you using?
14.15.3
What build tool (or framework if it abstracts the build tool) are you using?
postcss-cli
What browser are you using?
Chrome
What operating system are you using?
Windows 10
Reproduction repository
https://github.com/mcajongbah/tailwind-jit.git
When the HTML file is updated, the compiler updates the classes but the browser just flickers but doesn't apply the related changes. I'm not sure whether it's a tailwind jit plugin problem(doesn't happen with the tailwind plugin itself) or that of the live server extension. Changes only apply after you manually reload the page

For what it's worth I have this same sort of issue and I don't use a VSCode live server (not sure what that is?). I run a webpack dev server as part of a Rails app and the majority of the time I need to save the file to trigger the compilation, but the browser seems to reload before the new styles are done. I have to trigger another save in VSCode to trigger another refresh, and things seem to go through and change the second time.