Panic when execute tk.Encode

Error msg:
thread '' panicked at src/lib.rs:86:54:
failed to cast tokenizer
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
thread '' panicked at core/src/panicking.rs:221:5:
panic in a function that cannot unwind
stack backtrace:
0:        0x10c94f736 - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::hcaf66bc4c0c453df
1:        0x10c99685b - core::fmt::write::hc9c5f1836b413410
2:        0x10c944752 - std::io::Write::write_fmt::h49df280499063c09
3:        0x10c951fe8 - std::panicking::default_hook::{{closure}}::h52c0b2f44f6107c5
4:        0x10c951c2e - std::panicking::default_hook::h5a6cf31501c161b2
5:        0x10c952dc3 - std::panicking::rust_panic_with_hook::hda4640ee332466e9
6:        0x10c952662 - std::panicking::begin_panic_handler::{{closure}}::haa3060694b34ea3d
7:        0x10c94fc19 - std::sys::backtrace::__rust_end_short_backtrace::h8eb44913cfe71457
8:        0x10c9522dc - _rust_begin_unwind
9:        0x10c9c111c - core::panicking::panic_nounwind_fmt::hfed0a2f12e4318b1
10:        0x10c9c11ca - core::panicking::panic_nounwind::h659854746b9fc37d
11:        0x10c9c13e5 - core::panicking::panic_cannot_unwind::hd982c2e1ccbf0ef4
12:        0x10c61c464 - _encode
13:        0x10c5a521a - __cgo_8af6c9406da8_Cfunc_encode
thread caused non-unwinding panic. aborting.
SIGABRT: abort
PC=0x7ff805ad814a m=11 sigcode=0
signal arrived during cgo execution

This seems to be an occasional issue, and it doesn't occur in most cases.

@qihuang0 can you paste a code snippet to reproduce this? e.g. what was the input to cause the panic? Also what version of the library are you using.


make _sanity.system compaliant error of "Can't locate Test/Simple.pm in @INC"

Describe the bug
make _sanity.system compaliant error of "Can't locate Test/Simple.pm in @INC"
To Reproduce
LANG=ja_JP.UTF-8 bash /apsarapangu/disk1/yansendao/aqa-tests/TKG/../../jvmtest/functional/MBCS_Tests/coin/test.sh
Expected behavior
run test success.
Screenshots

Additional context
after install perl module by command:
sudo perl -MCPAN -e'install "Test::Simple"'

the error message is miss：

May be we can change descript "Please Install from https://www.perl.org/get.html" to install Test::Simple by bash command sudo perl -MCPAN -e'install "Test::Simple"'

Believe that Test::Simple is in Perl v5.6.2 and up, so should available in the prescribed version outlined in Test Prereqs which is v5.10.1 or above.
One supposes that we could check the version and exit with a clearer message.  This version checking typically is done in TKG from getPrerequisiteInfo() but for now I believe we just print to console a warning...  and do not exit if prereqs are not correct.

Believe that Test::Simple is in Perl v5.6.2 and up, so should available in the prescribed version outlined in Test Prereqs which is v5.10.1 or above.
One supposes that we could check the version and exit with a clearer message. This version checking typically is done in TKG from getPrerequisiteInfo() but for now I believe we just print to console a warning... and do not exit if prereqs are not correct.

My perl is 5.16.3, but doesn't have Test::Simple default.

Believe that Test::Simple is in Perl v5.6.2 and up, so should available in the prescribed version outlined in Test Prereqs which is v5.10.1 or above.
One supposes that we could check the version and exit with a clearer message. This version checking typically is done in TKG from getPrerequisiteInfo() but for now I believe we just print to console a warning... and do not exit if prereqs are not correct.

On ubuntu20.04.4, the perl version is v5.30.0, it doesn't have Test::Simple module by default.


Better management of layer control addition/removal of items

This PR adds a better management of the layer control, now it will show/hide the layers control items correctly based on the "layerOptions", "showOnSelector" property.
This example has been improved to show this new functionality too:
http://tombatossals.github.io/angular-leaflet-directive/examples/0212-layers-hide-overlays-on-selector-example.html

Why do so many Prs fail then pass?
I

Looks like this passes now so lgtm


1.10.2 Controller having 200MS of lag when crafting Machine is missing.

Issue description:
A RS System was crafting a HV Solar Panesl which needs a insane amount of Iron beeing smelted.
Some of my testers removed the furnace and it caused a huge issue because the controler did land in a lag loop. It killed hte server.
What happens:
a HV Solar Panel was requested and someone remvoed a vital component out of the crafting loop.
What you expected to happen:
Not to cause 200MS lag.
Steps to reproduce:

Make Recipes that take at least 8 steps and its so expensive that it takes up to 5-8k things to be smelted.
2: Remove the smelter.
...

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: 2221
Refined Storage: 1.2.24

Does this issue occur on a server? [yes/no]
yes.
Fix Suggestion:
Add a Crafting Timeout. If the process is frozen lets say for a minute or something with no item crafting at all it should cancle the crafting.
Because no crafting recipe should wait longer on things then 10000 ticks.
What i mean is not when 1 step is frozen for 10000 ticks because it could be that other steps are still working next to it. I mean then the crafting task did nothing for 10000 ticks. (i mean injected Items or Extracted Items)

did you even check previous issues? -.-
duplicate of #838

Yes but mine is different.  It doesnt notice that a crafting machine is missing. (Can only happen with Crafters that try to craft with a different machine)

Removing a link in the chain shouldn't be causing extreme lag. The process should just be stuck. But it does boil down to it doing to my tries to insert it, which is exactly what #838 is about. Also the proposed fix to keep track of time is not a good solution as it takes to many resources and what if a task legit takes more time then that threshold we set?


Resizing with fallback decorations can cause viewport protocol error

Easy to reproduce with examples/triangle-opengl. Resize the window, until its width and or height become zero or negative. The window closes and the app exits with wp_viewport@33: error 0: all values must be either positive or -1.
Remedy: set a minimum window size. glfw should do this during window initialization for wayland windows, because the default behaviour is obviously non-sensible.
Also: When running any of the examples with a wayland window, I always get libEGL warning: DRI2: failed to create dri screen.

Thank you for the bug report! This should be fixed for all paths now with b61f3fc4796a5b998d70aeb5e4723ea8b681403d. Please let me know if you would like the credit line changed.

Thanks for the credit, though you can leave it out, since it was just a bug report. Otherwise "Nat!" or "mulle_nat" would be preferred. Thanks for all the work on glfw3.

A good bug report is just as helpful as a PR. Updated with dbf7cfc4dc69517cd8618ca01c49053aa9373f63.


Rewrite servicePath to rewritePath if available

Hi,
First of all, this is one of the best projects out there which save me so much time being free of hassle. (: Yet, one functionality I'd like to be able to make use of seems missing. Here it is: I want the proxy to match a service with the beginning of the request path as it's already been possible and rewrite the path before forwarding the request to the matching service as follows:
docker service create --name go-demo \
    -e DB=go-demo-db \
    --network go-demo \
    --network proxy \
    --label com.df.notify=true \
    --label com.df.distribute=true \
    --label com.df.servicePath=/demo/* \
    --label com.df.rewritePath=/* \
    --label com.df.port=8080 \
    vfarcic/go-demo

This would forward requests for http://domain/demo/ to http://serviceName/ and some other requests for http://domain/demo/admin to http://serviceName/admin. I've browsed through the articles in this repo and performed some searches but found out no way to rewrite request paths. Is this functionality available or do you have any plans about it?

This is definitely a good feature to add. I'm a bit overwhelmed with work right now. I'll do my best to implement it as soon as I can.

I've tried to put Portainer / Visualizer behind docker-flow-proxy, but couldn't make them work... I suspect some path rewrites would make it work.

@jmkhael
Hi, you must read this -> https://github.com/portainer/portainer-docs/blob/master/docs/source/faq.rst#how-can-i-configure-my-reverse-proxy-to-serve-portainer-using-haproxy
I solved creating a pair of templates on /consul-template dir.
If you reconfigure service via api, the api parameters "consulTemplateBePath" and "consulTemplateFePath" need to point your template files.
Else, if you use swarm-listener, you must add labels to service like this.
--label com.df.consulTemplateFePath=/consul_templates/[FE template path]
--label com.df.consulTemplateBePath=/consul_templates/[BE template path]
The only problem here is that templates are statics and you can't profit for other services.
Now I'm looking the code to make this possible creating an independent function for parse the templates like auto-generated config.
Look this functions:
https://github.com/vfarcic/docker-flow-proxy/blob/master/reconfigure.go#L264
https://github.com/vfarcic/docker-flow-proxy/blob/master/reconfigure.go#L281
Only auto-generated replace the parameters with "Execute" method and this can be in other function to use the replace after template loaded. Then we can create parametrized templates or satatics.
tmplFront, _ := template.New("consulTemplate").Parse(srcFront)
tmplBack, _ := template.New("consulTemplate").Parse(srcBack)
var ctFront bytes.Buffer
var ctBack bytes.Buffer
tmplFront.Execute(&ctFront, sr)
tmplBack.Execute(&ctBack, sr)
return ctFront.String(), ctBack.String()

Good Job @vfarcic ;)

Ping @fuertesb :)

@Xustyx thank you for the message and the links.
I am using Docker Flow Proxy without Consul, a.k.a. with the New Swarm Mode. Is there a way to set templates for this mode too?

@jmkhael
Yes, it's the second way that I posted.

Else, if you use swarm-listener, you must add labels to service like this.
--label com.df.consulTemplateFePath=/consul_templates/[FE template path]
--label com.df.consulTemplateBePath=/consul_templates/[BE template path]

Great, i'll give it a go. the consul part in the commands and labels mislead me :)

@jmkhael
Yeps, the label keys are not appropriate at this point, because consul is not needed now, and I use image path /consul_templates  but you can store your templates in other.
Remember map the directory with templates with image path with mount, or build a new docker image adding the templates.
docker service create \
--name proxy \
-p 80:80 \
-p 443:443 \
--network proxy \
--constraint 'node.labels.nas == templates' \
--mount type=bind,src=/home/docker/templates,dst=/consul_templates \
-e MODE=swarm \
-e LISTENER_ADDRESS=swarm-listener \
vfarcic/docker-flow-proxy

@Xustyx You're right. The directory name is not appropriate anymore. It all started with Consul and evolved from there. I should probably change the name to /templates in one of the next releases.

I just added the ability to rewrite paths. It is available in the release 1.111.
Please see Rewriting Paths section of the documentation for more info.
I'd appreciate any feedback you might give on this feature. Please try it out and let me know if you notice any problems or have a suggestion for improvement.

Hey @vfarcic,
Thank you very much for implementing this feature, it works like a charm!

No, it was just for testing, nothing relevant to do with any deployment strategy. They might have been named red and black if I just wanted. (:

Hi again, @vfarcic
It may still be a better choice to use a directive such as http-request set-path %[path, regsub({{.ReqPathSearch}}, {{.ReqPathReplace}})] instead because regrep ... scans the entire request buffer searching for regex matches while http-request set-path ... directive does only a quick scan of the request path.
Note: The regsub function handles arguments doing the same operation as the well-know sed utility with "s/<regex>/<subst>/" so it differs from regrep that handles arguments as PCRE by default. There is a flag for regsub known as -r to enable extended regex handling which may come handy in some cases but I think basic replace functionality will meet the requirements for most of the use-cases.
regsub: https://cbonte.github.io/haproxy-dconv/1.8/configuration.html#regsub
Set the URL path: https://www.haproxy.com/doc/aloha/7.0/haproxy/http_rewriting.html#set-the-url-path
PCRE Regex to SED: http://stackoverflow.com/a/24832550/1973424

You're right. It should be better if we replace it with http-request. Would you like to give it a try and submit a pull request?


ROX-25995: Add feature flag for scan schedule report jobs

Description
This PR adds a new feature flag to support scan schedule report jobs in the UI
User-facing documentation

[x] CHANGELOG is updated OR update is not needed
[x] documentation PR is created and is linked above OR is not needed

Testing

[x] inspected CI results

Automated testing
No tests needed

[ ] added unit tests
[ ] added e2e tests
[ ] added regression tests
[ ] added compatibility tests
[ ] modified existing tests
[x] no tests modified

/retest

/retest-required


IE9 Double click deletes Item

In all the demos when you double click with IE9 the Element will be deleted.
http://marceljuenemann.github.io/angular-drag-and-drop-lists/demo/#/nested
The problem is that the dragstart event will be fired on a doubleclick. Then it starts to drag and just disappears.
I looked at the code but couldnt find it yet. If i find it I will post it here
Greetings
Jannis

Seems to work as long as Documents Mode = Standard, regardless if IE version.  Any chance this will get fixed ?  Other than this double click issue, I'm very happy with this lib...

This issue also manifests itself when you drag an item "outside" of a dropzone; the item never unhides itself because the .dndDraggingSource class is never removed.


Task: remove searchbar from MapControlBar.tsx

Now that the geocoder search bar has been integrated into the PropertyMap.tsx via react-map-gl, we can remove the search bar from the MapControlBar.tsx component.

Hi, I've opened a pr that should close this issue here #115.


[CORE] Remove unnecessary case match in getAttrForAggregateExpr

What changes were proposed in this pull request?
There are many processes in the getAttrForAggregateExprs method that construct aggregateAttr and index for specific aggFuncs. In fact, the patterns of these processes are consistent. They iterate over inputAggBufferAttributes of aggFunc, transform them, and insert them into aggregateAttr. Then, they increase the count in index for each insertion. The logic for validating the supported modes of different aggFuncs is the only specific part, which can be extracted separately.
How was this patch tested?
Exists CI

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3629_time.csv
log/native_master_11_06_2023_d57fdf26f_time.csv
difference
percentage

q1
33.90
33.34
-0.552
98.37%

q2
24.90
24.84
-0.059
99.76%

q3
37.81
38.31
0.492
101.30%

q4
37.06
37.40
0.345
100.93%

q5
70.83
70.83
0.000
100.00%

q6
7.93
7.74
-0.187
97.65%

q7
85.37
85.97
0.601
100.70%

q8
86.42
84.68
-1.734
97.99%

q9
122.52
124.39
1.871
101.53%

q10
52.92
54.67
1.743
103.29%

q11
20.30
19.96
-0.341
98.32%

q12
27.03
24.52
-2.516
90.69%

q13
48.93
50.37
1.441
102.95%

q14
17.30
18.50
1.198
106.93%

q15
33.06
32.09
-0.969
97.07%

q16
16.50
16.51
0.005
100.03%

q17
103.39
100.90
-2.496
97.59%

q18
147.83
148.27
0.442
100.30%

q19
14.98
14.74
-0.238
98.41%

q20
30.18
30.95
0.768
102.55%

q21
227.56
225.06
-2.502
98.90%

q22
13.18
13.61
0.423
103.21%

total
1259.91
1257.65
-2.261
99.82%

I will raise a pr to fix the extension problem.


CB-11304 Introduce 7.2.9 Cloudera Runtime

See detailed description in the commit message.

Backport of #10042.


Should \cite be \citep?

I see a lot of the citations use \cite, which doesn't wrap the citation in parentheses. We may need someone to change these citations
(the top paragraph uses \cite, but my paragraph below uses \citep; the difference is that my citations are wrapped in citations, which is typically the standard format)

I have a hacky solution right now that just changes all instances of \cite to \citep (it's just one line but can be commented out easily, lmk if it causes issues)


Security Key

Authenticate Users on the Systems/Applications you make available to them or make them unlock the data they store in their Storages/Servers with a key that only they can access. Requires Security Key (Hardware).

Just so you're aware, reviews from non-organization members could sometimes be valuable but do not count towards the 2 review requirement, and this pull request is closed anyways so here it especially is just spam.
The notable problem with this is extension is that despite being called "Security Key" it does not actually provide any security as it is client-side-only

Oh


feat: Syntax for environment types now works with generics

Description

Problem*
The syntax for closure environment types that I added in https://github.com/noir-lang/noir/pull/2357 is sub-optimal as it does not play well with generics.
Resolves: https://github.com/noir-lang/noir/issues/2334
Summary*

As suggested in https://github.com/noir-lang/noir/pull/2357#discussion_r1298487380 this PR changes it changed from fn[envarg1, envarg2](arg1, arg2, ...) -> ret to fn[env_type](arg1, arg2, ...) -> ret so that a named generic can be used an environment.

Additional error checking is also added, since the new syntax allows passing any type as an environment, but the only valid ones are Unit/NamedGeneric/Tuple.

Added tests for generic closure environments

Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

After testing out this PR, I think it is too confusing to report the error in a different source location. Can you add source locations to UnresolvedTypes so that the error location is correct?

I've added spans to UnresolvedType, the error now looks like this:
error: asdkj is not a valid closure environment type
  ┌─ /home/vitkov/code/repos/metacraft-labs/noir/proj/src/main.nr:4:16
  │
4 │ fn bad(foo: fn[asdkj]() -> Field) {
  │                ----- Closure environment must be a tuple or unit type

I thought about submitting a new PR, but it turned out not to be that massive of a change, so I dropped it in here so we can get it done faster


E

Can you play other games other than for chat?

If you use it with SteamVR, it should work for any game that supports vive trackers. Note that, since the tracking quality is lower, you probably shouldn't expect it to be very useful for things like kicking stuff in blade and sorcery etc.


pip install failed

Installation failed
I followed your instructions:

git clone https://github.com/Ashish7129/Graph-Sampling.git
cd Sampling
pip install -e
See error:

I tried the second way
1.download the zip file and move to its directory.
2.pip install Sampling
3.See error:

--macOS python2.7

Hi all, have a look to the updated version ( Only for python 3)


makes terrain tiles show cables

About the PR
Apparently lots of tiles didn't show cables and pipes under them so I've set them as subfloors. Enjoy. No more hiding cables in sand until we get working shovel prying.

this has made a lot of maps very ugly that have indoor areas using these


[Admin] Fix broken link

Docs Build status updates of commit c9fc083:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/application-specific-api-model.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[Feature Request] Magical height: 'auto' for

Hello, thank you for this wonderful library!
This library is amazing, I was trying height: 'auto' for .
But I notice that  seems not supporting this feature, it would be wonderful for supporting it, or other method for achieving  + height: 'auto'.
Thank you very much!!!

@rockmandash auto is supported
demo: https://codesandbox.io/embed/pmjomxn60
api: https://github.com/drcmda/react-spring/blob/master/API-OVERVIEW.md#animating-auto
where did you have problems?

@drcmda Thank you for your reply!
Sorry, I didn't make my question clear, my bad!
I was trying to do this:
<Transition from={{ height: 0 }} enter={{ height: 'auto' }} leave={{ height: 0 }}>
  {toggle && Component}
</Transition>

I found out this didn't work, so I was wondering if  can also support Magical height: 'auto', or is there any method to do this?
Thank you for your amazing library again!

Transition internally is also just a wrap around spring, auto should work. For instance, try this example:
https://codesandbox.io/embed/j150ykxrv
and change 100 to 'auto'

@drcmda Thank you!
Now I know I need more context, thank you!

When it doesn't work, it's probably because it needs more context, like parents positioning isn't absolute or relative, or the parent has zero height/width + overflow, something like that.

When I try height: "auto" on the enter, I get
TypeError: Cannot read property 'props' of null
    at Object.fixAuto [as inject]```

Changing positioning on parent seems to have no effect and the parent does not have zero height. Any idea what I am misunderstanding?

@dvnrsn i didn't check against the case where a spring returns undefined, it should be fixed now.

Thanks, were module references changed in 5.5.2?
https://codesandbox.io/s/m86qjl8kp

Yes, should be, but doesnt look too good there, i have no idea what "globals" is supposed to be. I'll take a look ...

Dammit, something is seriously wrong - my macbook was dropping keys and i had it sent in, im on windows now and it seems to resolve files differently. :-S

@dvnrsn now it should be fine: https://codesandbox.io/s/lpqkzk9137
I made some changes to your sandbox. you wouldn't see any height transition because there's no css overflow, with height set to 100 on the inner element, the outer element would simply flow over without any visual effect. I've also set it to absolute, because when you toggle it out it would take space, shifting a newly appearing element out of the way.

@dvnrsn one more thing, your sandbox has react/react-dom 16.3.1 in there, everything before 16.4.1 had a sever bug in there regarding getDerivedStateFromProps, in react-springs case this would make exit-transition elements stick around. They've fixed it since then.

Thanks @drcmda for the amount of work you've already put into this library, I'm a huge fan.
I'm working on a tree component where I want to animate child nodes into view, and this can happen some levels deep. It seems that the outer 'auto' height transition does not respond well to the inner 'auto' height transition. Example: https://codesandbox.io/s/o75k1knl6q
Is this a bug of the framework or should I approach this differently?

edit, looking at your example, i think this is something else. it doesn't calculate height properly, which most likely means it doesn't have enough context - let me check ...

Ok, auto is definitively broken - again :-S react-animated-tree is down aswell with latest react-spring. Will fix.

Agreed, appreciate all the work. @wilcoschoneveld thanks for the post. I was having this delayed nested height animation jump issue locally but was not able to replicate on codesandbox so I figured it was something with my code and gave up.

@wilcoschoneveld @dvnrsn hang in there i'm almost done. i implemented some part of spring from scratch using react 16 lifecycles and trying to clean it up as best as i can in order to make the most complelx stuff like auto not such a headbreaker. I'll be fixed very soon.

<EMAIL_ADDRESS>(and newer, if available) should take are of "auto"

Cool! I couldn't get 5.6.1 to work with the example though; https://codesandbox.io/s/o75k1knl6q. Are there still issues?

@wilcoschoneveld looks like it :( , i only checked the demos on the frontpage which started working again. auto is really messing me up these days ...

Hi do you know why it doesn't work with v8? Thanks
Demo: https://codesandbox.io/s/3wwxnmw51

@DominicTobias not sure why, but if you remove attribute native from , it seems to be working


Strict type checking not propagating properly from config files

Describe the bug
I am trying to use the new flag for strict type matching. I set it in my JSON config file like this
    ...
    "inputDelay": 0,
    "strict_input_type_checking": true,
    "publications": [
        {
    ...

But when looking at the function in NamedInputInfo->checkTypeMatch The boolean flag for type setting is still false.
What is the expected behavior?
I expect that when this flag is set strict type matching will be enforced on all topics for this federate.
To Reproduce
Set "strict_input_type_checking" for any federate in the JSON config file while also ensuring a type mismatch is present and run the federate. Currently it will not complain about the mismatch.
Environment (please complete the following information):
Ubuntu 16.04
HELICS 2.0 Beta 2

This issue is fixed, closing out this one


Cluster curator status roll up tweaks and add structure for upgrade + upgrade hooks

Issue:  https://github.com/open-cluster-management/backlog/issues/11733

/hold


sql/analyzer: add rule to fix field's indexes in inner joins

Fixes #180
Signed-off-by: Manuel Carmona<EMAIL_ADDRESS>

It seems st is failing, don't review yet

@ajnavarro now CI passes, it's ready to review!

@ajnavarro @erizocosmico
I changed the PR to address all cases. Now there is a rule resolveGetFieldIndexes in charge of set the correct index for the GetField expressions referencing this value to the sql.Node that contains that expression.
Thus, the resolveColumns rule doesn't set these indexes anymore and we avoid the usage of the global row's indexes based on the final schema.

@mcarmonaa You can do the same logic calling Expressions() method on the nodes that you need into a rule. I cannot see the need of TransformExpression() method.

@ajnavarro, calling Expressions you will get the expressions for this node, but you must add a different implementation to generate a new node with its expressions changed for each node subtype(inner join, project, etc) in the rule.
Having the method TransformExpressions you have that specific implementation done in each node, which I think it's better.

Yes, but you can do it in a rule checking the type of the node depending on the case.

@erizocosmico can you have a look?

@erizocosmico ping

@erizocosmico ping?


require("react/addons") is deprecated

Hi,
I have been using React 0.14.0-alpha3 and I see this warning:
require("react/addons") is deprecated. Access using require("react/addons/{addon}") instead.
See the image attached.

Hey @danielsoner, thanks for reporting, I haven't looked at React 0.14 yet. I'll try to do a cleanup soon and address these deprecations / changes.

That sounds good!

I wasn't using react/addons anyway, I just converted the code to ES2015 and removed these references, I'll publish a new version soon.


LinuxParser.Kernel does not return correct string

Function needs to be updated so that it returns the proper value of the linux kernel defined in /proc/version. As it stands, right now the function returns the string "version" instead of string directly after version. All images used in the C++ course showing the htop display have the kernel field showing "version" instead of the proper value.
I'm more than happy to fix this, just give me a shout.

Hi @djhanove
Thanks for flagging the issue. Can you raise a PR, so that we can review it precisely?

I don't have the bandwidth for this currently, and opened this issue almost a year ago. Not sure why you are closing the issue unless it has been patched by someone else

We've got that. See this commit. It has now been resolved.


Take into account opacity of ascendants when checking if the element is visible

Currently only the hinted element's opacity is checked when checking if an element is visible. But sometimes the element is inside a container with opacity: 0. An example of that is YouTube player's controls.
javascript - How to check if an element is transparent (opacity) because of some parent element? - Stack Overflow

Thinking more about this, if I manage to do #44 using the first block ancestor, this is probably not gonna be necessary as the hint will be inside that container.


New Sequence Diagram & Arch Docs.

Does this help communicate what is happening with ENTRYPOINT & CMD?

cc @mnapoli

Looks great, that's much clearer!


Atomicity of instruction fetch

The OS-A platform spec used to have the following clause.  We deleted it because we decided it was a better fit for the RVA20 and RVA22 profiles than for the OS-A platform.  But we never got around to adding it to the profiles.
(As a reminder, the intent of this clause is to support runtime patching of aligned 4-byte instructions.)
Within main-memory regions, aligned instruction fetch must be atomic, up to
the smaller of ILEN and XLEN bits. In particular, if an aligned 4-byte word
is stored with the `sw` instruction, then any processor attempts to execute
that word, the processor either fetches the newly stored word, or some previous
value stored to that location.  (That is, the fetched instruction is not an
unpredictable value, nor is it a hybrid of the bytes of the old and new
values).

Is the "In particular" and after intended as non-normative?
Is "aligned instruction fetch" just intended to qualify as not an exception?  It's not clear how the "aligned" qualifier matters matters (i.e., why not drop the qualifier?).  Perhaps talk about the MIN(ILEN, XLEN) as pertaining to naturally-aligned regions?

The "in particular" shouldn't be normative.
As to the latter point, that just reads like an equivalent rephrasing to me, but we can give it a shot.  I guess it's debatable whether the non-normative text is even needed.
Within main-memory regions, fetching a naturally aligned instruction of up to
the smaller of ILEN and XLEN bits must be atomic.

NOTE: This requirement facilitates runtime patching of aligned instructions.
For example, if a 4-byte instruction is stored to a 4-byte-aligned address
with the `sw` instruction, overwriting another 4-byte instruction, and then
any hart attempts to execute that word, that hart will execute either the old
instruction or the new instruction.

If ILEN=48 and XLEN=64 then what is the requirement?  I normally think of naturally-aligned as only applying to powers of 2.

If ILEN=48, the requirement should still be 32 bits.
Given this is all hypothetical (there are no standard instructions longer than 32 bits currently defined), we could just simplify this text to say 4 bytes.  Once ILEN grows to 64, we can revisit this platform requirement if so desired.
The new version would be:
Within main-memory regions, fetching a naturally aligned instruction of up to
four bytes must be atomic.

The first sentence of the note provides useful motivation.  I'd remove the example.

OK, I'll make a PR.


Close accepted TURN listener connections

Description
To the best of my knowledge, connections accepted from the provided net.Listener would never be closed, even if there was an error.
This changes them to be closed at the top of the connection handling goroutine. I didn't touch the connections from packet conn configs because I didn't want to change the behavior (parent code might already be doing defer conn.Close()).
I had to refactor the NewServer method a bit to avoid hitting the gocognit linter. The only real changes I made were to the connection handler goroutine in the net.Listener goroutine.
Reference issue
None
cc @coadler @kylecarbs

I created a new PR based on the latest master in #306  as this seems to be outdated.


Example code

It'd be nice to be able to look at and play with the code of the example mentioned in the README.

Just updated the readme with a link to the demo's source code. It's using OPENRNDR.

Awesome! Will check it out!


Aliases might be incompartible with PHP 7.4 Preloading feature

Environment details

OS: docker php:7.4-fpm
PHP version: php:7.4
Package name and version: latest (2.8.0)

Steps to reproduce
I have an issue with aliases in Symfony app optimized for PHP 7.4 preloading feature. It loads all the required classes at once and conflicts with the aliases file which leads to numerous errors like
Cannot declare class Google_Http_REST, because the name is already in use in /app/vendor/google/apiclient/src/aliases.php on line 27

Could you please make it optional or add checking that those classes are not defined yet?
For those who have the same issue possible solutions are

stick to 2.7.x (unfortunately not my case because I use it indirectly via lib with dependency like ^2.x)
in a build script wipe out aliases file with echo '<?php' > ./vendor/google/apiclient/src/aliases.php

stick to 2.7.x (unfortunately not my case because I use it indirectly via lib with dependency like ^2.x)

Btw you can still "fix" this yourself my (temporary) making it a root dependency in your project for 2.7, so you wouldn't have to resort the build step. At least I would like to think so that this should work.

@mfn I solved the conflict by adding
    "require": {
        "google/apiclient": "2.7.2 as 2.8.0"
    }

to composer.json. Though I have to retest the functionality for any possible issues because of that blatant substitution 🤞 😄

Thank you for reporting this, I will look into how to fix it. In the meantime, you can just require google/apiclient:2.7.2 rather than use an alias for 2.8.0 as you do above:
    "require": {
        "google/apiclient": "2.7.2"
    }

@Ttakeleif this is now fixed! Update to v.2.8.1 and you'll be all set!

@bshaffer I can confirm the issue is fixed.

Does this mean the class_exists line in src/aliases.php is no longer needed?

@snoogans235 is it possible this will fix your issue?
https://github.com/googleapis/google-api-php-client/pull/1991

@bshaffer Is this solved in 2.8.3? because I still get the warnings.
PHP Warning:  Can't preload already declared class Google_Utils_UriTemplate

I got the same for 2.8.3

After merge this PR preload send warnings.
https://github.com/googleapis/google-api-php-client/pull/1995

I'm not sure that this fix has been sufficient. I am running v. 2.9.1 of "google/apiclient" and I get the following output:
  Can't preload already declared class Google_Utils_UriTemplate in /code/platform/vendor/go
 ogle/apiclient/src/aliases.php on line 64
  Can't preload already declared class Google_Task_Runner in /code/platform/vendor/google/a
 piclient/src/aliases.php on line 63
  Can't preload already declared class Google_Task_Retryable in /code/platform/vendor/googl
 e/apiclient/src/aliases.php on line 62
  Can't preload already declared class Google_Task_Exception in /code/platform/vendor/googl
 e/apiclient/src/aliases.php on line 61
  Can't preload already declared class Google_Service_Resource in /code/platform/vendor/goo
 gle/apiclient/src/aliases.php on line 60
  Can't preload already declared class Google_Service_Exception in /code/platform/vendor/go
 ogle/apiclient/src/aliases.php on line 59
  Can't preload already declared class Google_Service in /code/platform/vendor/google/apicl
 ient/src/aliases.php on line 58
  Can't preload already declared class Google_Model in /code/platform/vendor/google/apiclie
 nt/src/aliases.php on line 57
  Can't preload already declared class Google_Http_REST in /code/platform/vendor/google/api
 client/src/aliases.php on line 56
  Can't preload already declared class Google_Http_MediaFileUpload in /code/platform/vendor
 /google/apiclient/src/aliases.php on line 55
  Can't preload already declared class Google_Http_Batch in /code/platform/vendor/google/ap
 iclient/src/aliases.php on line 54
  Can't preload already declared class Google_Exception in /code/platform/vendor/google/api
 client/src/aliases.php on line 53
  Can't preload already declared class Google_Collection in /code/platform/vendor/google/ap
 iclient/src/aliases.php on line 52
  Can't preload already declared class Google_Client in /code/platform/vendor/google/apicli
 ent/src/aliases.php on line 51
  Can't preload already declared class Google_AuthHandler_Guzzle7AuthHandler in /code/platf
 orm/vendor/google/apiclient/src/aliases.php on line 50
  Can't preload already declared class Google_AuthHandler_Guzzle6AuthHandler in /code/platf
 orm/vendor/google/apiclient/src/aliases.php on line 49
  Can't preload already declared class Google_AuthHandler_Guzzle5AuthHandler in /code/platf
 orm/vendor/google/apiclient/src/aliases.php on line 48
  Can't preload already declared class Google_AuthHandler_AuthHandlerFactory in /code/platf
 orm/vendor/google/apiclient/src/aliases.php on line 47
  Can't preload already declared class Google_AccessToken_Verify in /code/platform/vendor/g
 oogle/apiclient/src/aliases.php on line 46

Can this issue perhaps be reopened?

@nmeirik they fixed it in google\apiclient, but the same issue exists in google\apiclient-services library which is not fixed.
My bug report.

@nmeirik I missed your comment because this issue is closed. Were you able to get it resolved? If not can you open a new issue? Thanks.

@bshaffer I realized that is was just a warning and not a blocker as I initially thought, so I moved on.

There is no such thing as "warning and not a blocker". Whenever you have warnings AND ALSO a crash for which you seek support, the first question you'll get asked is "are there any warnings"?


Link documentation of an example how to use this with fast-changing dirty functions.
Closes #842
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[x] Read the Contributing Guide
[x] Perform a code self-review
[x] (n.a.) Comment the code, particularly in hard-to-understand areas
[x] Add documentation
[x] Add hook's story at Storybook
[x] (n.a.) Cover changes with tests
[x] Ensure the test suite passes (yarn test)
[x] Provide 100% tests coverage
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[x] Make sure types are fine (yarn lint:types).

@streamich stumbled into another review, made an aesthetic fix and did a history-rewriting commit assuming you haven't pulled it yet.

:tada: This PR is included in version 13.25.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


R.head doesn't support lazy evaluation

See http://bit.ly/1jJphwL

Lazy evaluation is only supported with transducers. See the modified sample code: http://bit.ly/1PeYfZT
The problem is that I don't see a way to collect the "first" (if any) item with transducers.

And I'm not really following what output you'd expect from this if there was support for lazy evaluation.  What output would there be?

See my version, @CrossEye the map function is only called twice, so i=2.

Maybe i'm still foggy-brained after the weekend.  I didn't see the point of twice.

Called once, surely?

We used to include a LazyList extension, but that was removed in #857 as it wasn't getting any love.  If that has something that interests you, we could certainly revive it.  We could also rework it in terms of the iteration protocol.

The problem is that I don't see a way to collect the "first" (if any) item with transducers.

I'm not overly familiar with transducers, but I believe this is something that the @@transducer/result method can take care of.
e.g. If we borrow the implementation of the existing transducer for take and just override the @@transducer/result property to be R.head:
xhead = xf => R.assoc('@@transducer/result', R.head, _xtake(1, xf));
R.into([], R.pipe(xhead, R.map(mapFn)), array); //=> [2, 1]

Still, you're intoing into an array.

Yep, I'll put that down to pre-coffee brain.
You should be able to use transduce instead of into, but in any case it's stepping away from the intent of this PR.


A11y: Employee Management - error handling on detail pages for VO

When entering Role or Employee details (either upon creation or editing existing details) if an input is empty or otherwise invalid and gives an error, VO gives no indication there was an error, where the error is, or what needs to be done.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-39643
[created from NEXT-39643, comment 513176]

[public]

FixVersion Change: <IP_ADDRESS>

This issue will be / was solved in Shopware version <IP_ADDRESS>.
[created from NEXT-39643, comment 519546]


Explicit return type should be the same as explicit property definition

🔎 Search Terms
"generic function return type doesn't resolve implicit assignment", "using explicit types to break circular references", "using explicit types to break circular references"
🕗 Version & Regression Information

I made this in 4.9.5 and checked 5.2.2 in the playground. I have not tested this in previous versions but it most likely applies to those as well.

⏯ Playground Link
code I expect to work
code that actually works, but seems unnecessary
💻 Code

type SPPTypeTree<T, R extends string> = { [K in string & keyof T]: SPPTypeTree<T[K], `${R}/${K}`> } & { __: R }
type SPPF_Test<T extends SPP_Type> = (e: SPPTypeTree<T, "">) => any[];

class SPP_dir<T extends SPP_Type> {
  constructor(public attr: {
    arrayList?: SPPF_Test<T>,
  }) {

  }
}

class SPP_Type {
  val?: "kfdsjklfdsjkl"
}
class SPP_Member<T extends SPP_Type> {
  constructor(ctor: { new(): T }, ...dirs: SPP_dir<T>[]) { }
}
function SPP_Test_Func<T extends SPP_Type>(
  ctor: { new(): T; },
  arrayList: (x: SPPTypeTree<T, "">) => any[],
): SPP_Member<T> {
  return new SPP_Member(ctor, new SPP_dir({ arrayList }));
}

class SPP_Test_1 extends SPP_Type {
  Name = new String();
  other = SPP_Test_Func(SPP_Test_2, x => [x.other.__])
}

class SPP_Test_2 extends SPP_Type {
  Name = new String();
  other = SPP_Test_Func(SPP_Test_1, x => [x.other.__])
}

🙁 Actual behavior
The lines
other = SPP_Test_Func(<class>, x => [x.other.__])

give the error
Type of property 'other' circularly references itself in mapped type '{ val: SPPTypeTree<"kfdsjklfdsjkl", "/val">; Name: SPPTypeTree<String, "/Name">; other: SPPTypeTree<any, "/other">; }'.

which is true, but changing the property definition to
other: SPP_Member<SPP_Test_1> = ...

makes this message go away.
🙂 Expected behavior
I would expect that the explicit return type of the function SPP_Test_Func would be enough to also make the message go away since there is no question what the inferred type is supposed to be. If setting the type on the property itself makes it go away, setting the same type (with explicit generics or inferred from explicit arguments, as in my example) on the return type of the function should also be enough.
Additional information about the issue
No response

Type circularities may issue an error. In some cases there is deferred checking that will let you get away with a circularity, but those deferrals are not contractual guarantees that any equivalent representation will also be deferred.


error: unexpected reserved word

I am getting a error when trying to run on windows.
C:\binance-dca-bot-main>npm run start

><EMAIL_ADDRESS>start C:\binance-dca-bot-main
> node ./src/index.js

(node:18324) ExperimentalWarning: The ESM module loader is experimental.
file:///C:/binance-dca-bot-main/src/index.js:59
await runBot();
^^^^^

SyntaxError: Unexpected reserved word
    at Loader.moduleStrategy (internal/modules/esm/translators.js:88:18)
    at async link (internal/modules/esm/module_job.js:41:21)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node ./src/index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\AppData\Roaming\npm-cache\_logs\2021-05-21T08_46_23_456Z-debug.log

C:\binance-dca-bot-main>

What version of node are you using? Node 13+ is required to run the bot

my bad :p
this is now working, great job. Something simple, I like.
>node -v
v12.18.2
>node -v
v14.17.0


How to remove moduleId: module.id from component?

Hi, since I have webpack, moduleId: module.id is not needed.  In fact, it will cause an error.  How can I configure the tool to not include it?
Could you explain a little bit how to use your Configuration instruction?
Thanks!

This is documented in the movie.  It's a bit difficult to understand.


Weird behavior when value converter object parameter contains an array

When I pass an array in an object parameter to a value converter a la:

    ${database.key}
    ${database.companies}
    ...

The value converter runs, the array is passed into it and the data looks fine, the correct number of results are returned and displayed, but the values are empty:

If I remove the array or make it empty, the results are normal:

Stripped out everything in the value converter to make sure it wasn't anything with that, still the same result:
export class ObjectFilterValueConverter {
    toView(array: any[], config: any) {
        return array;
    }
}

Am I missing something here or does this look like a bug?

I think this may be a bug that is fixed in the upcoming release- not 100% sure though.  To confirm could you replace the ['key', 'companies'] part of the binding expression with foo and then add a property named foo to your vm with a value of ['key', 'companies']?
The issue/fix I'm thinking of is https://github.com/aurelia/templating-resources/issues/100

Yep, that's probably what it is then. Tried what you said and it worked. I'll close this as duplicate. Thx!

nice! thanks for reporting/checking :dancers:


rowClass API pass rowIndex parameter

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[*] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

body-row component only pass row into rowClass API.
Expected behavior

pass rowIndex too
Reproduction of the problem
What is the motivation / use case for changing the behavior?
in version 9.3.1 , I can use row.$$index%2 to set different class for even/odd row.
since $$index was removed , it's not working anymore.
Please tell us about your environment:

Table version: 10.4.0

**Angular version: 4.4.3

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Language: [all | TypeScript X.X | ES6/7 | ES5]

I miss this feature as well

Is there any way to extract row index now?
I was using (activate)=someFn($event) to pass index value, but now there is no info about index of clicked row index anywhere(or I cant find it).

IMHO, this is a huge missing attribute. The only way to stripe a table is to use css and pseudo-class selectors :nth-child(odd), etc. At least, I think that would work but that's only one use case. There are lots of other things that the $$index is useful for.
For a much richer grid experience, look into datatables.js or maybe PrimeNG. No disrespect to the folks who cobbled together this grid but it just isn't as capable or well-documented as datatables. This issue hasn't been touched in 18 months and it's still an issue in the current 11.x version.

Any update on this?

I'll just say that I'm currently building an Angular 9 app using Datatables.net and I have pretty much every feature I could want including row click events and expandable sections, grouping, sorting, row IDs, dynamic data updating and support for Observables. There are other addins available that I'm not even using so...it's extremely complete. I'd advise switching if you can. The documentation is very thorough and there's an active community supporting it. (I'm not affiliated with datatables in any way, just an avid user.)


LDSv2 fixes

This is based on https://github.com/istio/istio/pull/4253, with some cleanup and fix a couple of test cases.

try setting up your IDE for auto lints and/or run linters before the PR
(circleci is a bit overloaded so it helps if you don't have basic linter failures)

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
ad9fcf6889ffa506405304864e3028c8f69a8666
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ack, I have to remember to run make lint...
Fixed the issues, PTAL.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
ad9fcf6889ffa506405304864e3028c8f69a8666
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
adb2a7b1affaa2375c01a03c0abe87f7aa8cc120
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

As we discussed before, the LDSv2 is using the same mechanism as EDSv2, i.e. push and consistent code. Once RDSv2 is ready we can evaluate which needs to change, please don't force people to use control plane when not needed.

Please sync with master, and let's try to make this more incremental, more people are working on LDS now and we need to break changes in smaller pieces.

Moved to https://github.com/istio/istio/pull/4377 due to merge conflicts.


[Important] [Windows] Distortion of window while starting up

After upgrading to Flutter 3.22.1, Window manager is causing the entire UI to be glitched out (distorted) initially after launch.
This is how it looks

If I turn off/comment out windowManager.ensureInitialized and windowManager.waitUntilReadyToShow function calls, the app shows up completely fine except the Title bar is visible (as expected).
There are no errors/exceptions being thrown at the Console. So, I guess this is caused any embedder change in Flutter engine?

Reverting back to Flutter 3.19.x fixes the issue though

Upstream issue: https://github.com/KRTirtho/spotube/issues/1553
Thanks for your amazing work and the plugin @lijy91 ❤
Please fix this as soon as possible. Lots of users are affected by it.

There were lots of changes in the Windows embeder EGL which probably lead to this kind of issues.
Special focus: https://docs.flutter.dev/release/release-notes/release-notes-3.22.0#desktop

I encountered the same problem, but I found a solution that requires modifying the size in the main.cpp default file to be the same as the set minimum value to fix it。

I tried your fix but the issue comes back after opening the app 2/3 times.

There's a workaround suggested by Far Se on Flutter Discord that allows to use Flutter v3.22.x with window_manager in Windows
    WidgetsBinding.instance.addPostFrameCallback((Duration timeStamp) async {
      if (Theme.of(context).platform != TargetPlatform.windows) return;
      await Future<void>.delayed(const Duration(milliseconds: 100), () {
        windowManager.getSize().then((Size value) {
          windowManager.setSize(
            Size(value.width + 1, value.height + 1),
          );
        });
      });
    });

Add following in the root App's (the very first widget) initState method

OK，I will try this. Thinks.

This method is feasible, but I think it may be better。
WidgetsBinding.instance.addPostFrameCallback((Duration timeStamp) async {
if (Theme.of(context).platform != TargetPlatform.windows) return;
await Future.delayed(const Duration(milliseconds: 100), () {
windowManager.getSize().then((Size value) {
windowManager.setSize(
Size(value.width + 1, value.height + 1),
);
windowManager.setSize(
Size(value.width, value.height),
);
});
});
});

I also encountered this issue, but the suggested solution didn't worked for me - on Flutter 3.24.3.
Somewhere in the widget tree, after creating the MaterialApp, a Lottie was being played using a controller - but it was rendering only when it was done loading from the asset file. So I decided to have something rendering while the lottie was loading and it worked.

hey @lijy91 if you can look into this issue when you get time? Lots of users are suffering for this.
I'm also not finding any clue why this might happen.

I found a hacky solution.
await windowManager.maximize();
await windowManager.unmaximize();

We also have this issue in AppFlowy, we ended up switching to bitsdojo on windows rather than window_manager.
I want to switch back, but the workarounds are hacky (and not usable for all cases) and ends up with a bad user experience.

On Spotube's case, both window_managerand bitsdojo_window are having the same issue. How well does bitsdojo_window work for AppFlowy?

On Spotube's case, both window_managerand bitsdojo_window are having the same issue. How well does bitsdojo_window work for AppFlowy?

It has the same issue, but seems to happen less frequently, not really anything I can prove though.
We prefer window_manager though.


Add github action to docs

Closes #154

Codecov Report

Merging #157 (b3666e4) into main (567b5ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   95.66%   95.66%
=======================================
  Files          33       33
  Lines        1868     1868
=======================================
  Hits         1787     1787
  Misses         81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567b5ad...b3666e4. Read the comment docs.

awaiting changes to github action before approval/merge is completed.

@leestott this is ready for review/merge


NA Compatibility when using XGBoost

XGBoost allows NA values (that is part of its power).  We should explicitly test NA as a particular feature value when appropriate, and also think of a way to display it in the feature_dependence_plot.  It should also be compatible to have NA in the explain_prediction_difference.

Hey! Encountered this exact problem and have a recommendation.
np.nanmax() and np.nanmin() will exclude null values. This was causing issues within the model_xray() method.
The changes can be made in the following line of code:
col_values = np.linspace(np.min(self.data_values[:,column_num]),
                    np.max(self.data_values[:,column_num]),resolution)

This has been resolved.  Thanks for the fix @bholligan !


Change Header Animation / Update Images

Changed Header Animation to SVG
changed images on "How Voting works"
fixed small error on "chrysalis-network.svg"
add style for "object" in style.css

Note: Visual Studio Code changed format while saving - everything should still work

Can you please resolve conflicts? You might just need to do a new change request and void style formating.


Package view should specify compatible elm versions

Since Elm is an evolving language, not all packages can run on all elm versions.
It'll be helpful if when viewing a package, it'll show which elm versions it's compatible with, so one shouldn't have to use elm-package install to find out the package DOESNT actually support her version.

For now, you can use the unofficial elm-package-info browser extension which aims at testing some improvements (including the supported elm version) without requiring changes to the server.
Firefox extension Chrome extension

Each package now has an "About" page that includes the compatible elm version.
Also a warning is displayed for package not compatible with last elm version.


Windows end of line issue

Hi,
I compiled ippsample project on Windows and I noticed some EOL issue (CRLF instead of LF) on output job file.
When you use _write method, you have to add _O_BINARY flag else each LF character is replaced with a CRLF pair in the output.
Regards

[master 441587f] Add O_BINARY flag to all open calls that expect to read/write binary data (Issue #181)

This problem still exists in the ippeveprinter


An error when  compiling the project

[offsets] error: open /tmp/offsets-tool936573941/runtime/_obj/go_asm.h: no such file or directory
exit status 1
Makefile:100: recipe for target 'build/go_asm_offsets.inc' failed
make: *** [build/go_asm_offsets.inc] Error 1

I just try to compile it with  make run-vbox.
i find that there is no go_asm.h in my $GOROOT/pkg/include/.
so please help me,thanks!

The offsets tool (tools/offsets/offsets.go) constructs a build script that triggers the go compiler to generate the go_asm.h file (it won't be present in your $GOROOT).
Are you currently trying to compile on linux or are you using the provided Vagrantfile? If compiling on linux what is the version of Go installed on your system?

the version of Go is go 1.10 and I did compile on Linux.
so the content of  go_asm.h  I found is empty . I have tried to exec the build.sh by hand . But it also complain that there is no file go_asm.h
I comment the code //  defer os.RemoveAll(workDir) and I found that build.sh seems incomplete.
1 export GOOS=linux
 2 export GOARCH=amd64
 3 WORK="/tmp/offsets-tool534867582"
 4 alias pack='go tool pack'
 5
 6 #
 7 # runtime/internal/atomic
 8 #
 9
10 mkdir -p $WORK/b003/
11 cat >$WORK/b003/importcfg << 'EOF' # internal
12 # import config
13 EOF
14 cd /home/tmacy/go/src/github.com/golang/go/src/runtime/internal/atomic
15 /home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/compile -o $WORK/b003/_p
16 /home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/asm -trimpath $WORK/b003
17 /home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/pack r $WORK/b003/_pkg_.
18 /home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/buildid -w $WORK/b003/_p
19
20 #
21 # runtime/internal/sys
22 #
23
24 mkdir -p $WORK/b005/
25 cat >$WORK/b005/importcfg << 'EOF' # internal
26 # import config
27 EOF
28 cd /home/tmacy/go/src/github.com/golang/go/src/runtime/internal/sys
29 /home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/compile -o $WORK/b005/_p
30 /home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/buildid -w $WORK/b005/_p
31
32 #
33 # runtime
34 #
35
36 mkdir -p $WORK/b002/
37 cat >$WORK/b002/importcfg << 'EOF' # internal

I modify the code to  generate the build.sh
export GOOS=linux
export GOARCH=amd64
WORK="/tmp/offsets-tool003421175"
alias pack='go tool pack'

#
# runtime/internal/atomic
#

mkdir -p $WORK/b003/
cat >$WORK/b003/importcfg << 'EOF' # internal
# import config
EOF
cd /home/tmacy/go/src/github.com/golang/go/src/runtime/internal/atomic
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/compile -o $WORK/b003/_pkg_.a -trimpath $WORK/b003 -p runtime/internal/atomic -std -+ -buildid rQHkuJftQwly8P_1-qnZ/rQHkuJftQwly8P_1-qnZ -goversion go1.10 -D "" -importcfg $WORK/b003/importcfg -pack -asmhdr $WORK/b003/go_asm.h -c=4 ./atomic_amd64x.go ./stubs.go
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/asm -trimpath $WORK/b003 -I $WORK/b003/ -I /home/tmacy/go/src/github.com/golang/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -o $WORK/b003/asm_amd64.o ./asm_amd64.s
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/pack r $WORK/b003/_pkg_.a $WORK/b003/asm_amd64.o # internal
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/buildid -w $WORK/b003/_pkg_.a # internal

#
# runtime/internal/sys
#

mkdir -p $WORK/b005/
cat >$WORK/b005/importcfg << 'EOF' # internal
# import config
EOF
cd /home/tmacy/go/src/github.com/golang/go/src/runtime/internal/sys
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/compile -o $WORK/b005/_pkg_.a -trimpath $WORK/b005 -p runtime/internal/sys -std -+ -complete -buildid BM7gIj_s66jvLrpQ3VUK/BM7gIj_s66jvLrpQ3VUK -goversion go1.10 -D "" -importcfg $WORK/b005/importcfg -pack -c=4 ./arch.go ./arch_amd64.go ./intrinsics.go ./stubs.go ./sys.go ./zgoarch_amd64.go ./zgoos_linux.go ./zversion.go
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/buildid -w $WORK/b005/_pkg_.a # internal

#
# runtime
#

mkdir -p $WORK/b002/
cat >$WORK/b002/importcfg << 'EOF' # internal
# import config
packagefile runtime/internal/atomic=$WORK/b003/_pkg_.a
packagefile runtime/internal/sys=$WORK/b005/_pkg_.a
EOF
cd /home/tmacy/go/src/github.com/golang/go/src/runtime
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/compile -o $WORK/b002/_pkg_.a -trimpath $WORK/b002 -p runtime -std -+ -buildid 85mKbK3qN7k-quHak2B-/85mKbK3qN7k-quHak2B- -goversion go1.10 -D "" -importcfg $WORK/b002/importcfg -pack -asmhdr $WORK/b002/go_asm.h -c=4 ./alg.go ./atomic_pointer.go ./cgo.go ./cgo_mmap.go ./cgo_sigaction.go ./cgocall.go ./cgocallback.go ./cgocheck.go ./chan.go ./compiler.go ./complex.go ./cpuflags_amd64.go ./cpuprof.go ./cputicks.go ./debug.go ./defs_linux_amd64.go ./env_posix.go ./error.go ./extern.go ./fastlog2.go ./fastlog2table.go ./float.go ./hash64.go ./hashmap.go ./hashmap_fast.go ./heapdump.go ./iface.go ./lfstack.go ./lfstack_64bit.go ./lock_futex.go ./malloc.go ./mbarrier.go ./mbitmap.go ./mcache.go ./mcentral.go ./mem_linux.go ./mfinal.go ./mfixalloc.go ./mgc.go ./mgclarge.go ./mgcmark.go ./mgcsweep.go ./mgcsweepbuf.go ./mgcwork.go ./mheap.go ./mprof.go ./msan0.go ./msize.go ./mstats.go ./mwbbuf.go ./netpoll.go ./netpoll_epoll.go ./os_linux.go ./os_linux_generic.go ./panic.go ./plugin.go ./print.go ./proc.go ./profbuf.go ./proflabel.go ./race0.go ./rdebug.go ./relax_stub.go ./runtime.go ./runtime1.go ./runtime2.go ./rwmutex.go ./select.go ./sema.go ./signal_amd64x.go ./signal_linux_amd64.go ./signal_sighandler.go ./signal_unix.go ./sigqueue.go ./sigtab_linux_generic.go ./sizeclasses.go ./slice.go ./softfloat64.go ./sqrt.go ./stack.go ./string.go ./stubs.go ./stubs2.go ./stubs_asm.go ./stubs_linux.go ./symtab.go ./sys_nonppc64x.go ./sys_x86.go ./time.go ./timestub.go ./trace.go ./traceback.go ./type.go ./typekind.go ./unaligned1.go ./utf8.go ./vdso_linux.go ./vdso_linux_amd64.go ./write_err.go
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/asm -trimpath $WORK/b002 -I $WORK/b002/ -I /home/tmacy/go/src/github.com/golang/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -o $WORK/b002/asm.o ./asm.s
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/asm -trimpath $WORK/b002 -I $WORK/b002/ -I /home/tmacy/go/src/github.com/golang/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -o $WORK/b002/asm_amd64.o ./asm_amd64.s
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/asm -trimpath $WORK/b002 -I $WORK/b002/ -I /home/tmacy/go/src/github.com/golang/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -o $WORK/b002/duff_amd64.o ./duff_amd64.s
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/asm -trimpath $WORK/b002 -I $WORK/b002/ -I /home/tmacy/go/src/github.com/golang/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -o $WORK/b002/memclr_amd64.o ./memclr_amd64.s
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/asm -trimpath $WORK/b002 -I $WORK/b002/ -I /home/tmacy/go/src/github.com/golang/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -o $WORK/b002/memmove_amd64.o ./memmove_amd64.s
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/asm -trimpath $WORK/b002 -I $WORK/b002/ -I /home/tmacy/go/src/github.com/golang/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -o $WORK/b002/rt0_linux_amd64.o ./rt0_linux_amd64.s
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/asm -trimpath $WORK/b002 -I $WORK/b002/ -I /home/tmacy/go/src/github.com/golang/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -o $WORK/b002/sys_linux_amd64.o ./sys_linux_amd64.s
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/pack r $WORK/b002/_pkg_.a $WORK/b002/asm.o $WORK/b002/asm_amd64.o $WORK/b002/duff_amd64.o $WORK/b002/memclr_amd64.o $WORK/b002/memmove_amd64.o $WORK/b002/rt0_linux_amd64.o $WORK/b002/sys_linux_amd64.o # internal
/home/tmacy/go/src/github.com/golang/go/pkg/tool/linux_amd64/buildid -w $WORK/b002/_pkg_.a # internal

#

and then make run-vobx . The output is
[offsets] error: failed to execute build script
More info:
./alg.go:8:2: can't open import: "runtime/internal/sys": open $WORK/b005/_pkg_.a: no such file or directory
./asm_amd64.s:6: #include: open /home/tmacy/go/src/github.com/golang/go/pkg/include/go_asm.h: no such file or directory
./sys_linux_amd64.s:10: #include: open /home/tmacy/go/src/github.com/golang/go/pkg/include/go_asm.h: no such file or directory
fatal error: runtime: out of memory

so that why I ask  the previous question. It is the first time that i see the process of Go compile.I still learning.

Thanks for sharing the above info. I haven't tried compiling against Go 1.10 yet so I am not sure why it is failing. I will investigate further and try to come up with a fix.
In the meantime can you try compiling with Go 1.9 and let me know if that works for you?

I change the Go compiler to Go 1.9.4 and it seems that error .
but an new error come out
[sed] extracting LMA and VMA from constants.inc
[gcc] pre-processing arch/x86_64/script/linker.ld.in
[go] compiling go sources into a standalone .o file
[objcopy] create kernel.Kmain alias to gopheros/kernel/kmain.Kmain
[objcopy] globalizing symbols {_rt0_interrupt_handlers, runtime.g0/m0/physPageSize}
[ld] linking kernel-x86_64.bin
build/go.o:(.data+0x18)：‘x_cgo_munmap’undefined references
Makefile:48: recipe for target 'build/kernel-x86_64.bin' failed
make: *** [build/kernel-x86_64.bin] Error 1

I build the Go compiler  from github.com/golang/go and change the branch to origin/release-branch.go1.9 .  The version is  go version go1.9.4 linux/amd64.
Maybe some pkg need rebuild ?


[Improvement] integrate audit log framework for Iceberg REST server

What would you like to be improved?
#3973 add an audit log framework and provides a default audit writer, but it couldn't work with IcebergRESTServer, the main reason is the Iceberg REST event is defined in iceberg-rest-server module, while the default writer defined in core module.
How should we improve?
To make the default audit works for both Gravitino server and Iceberg REST server, I propose to add an auditInfo interface, all events should implement it, the default audit log writer could get the audit info from all the event.

welcome comments, cc @hanwxx @jerryshao


Subscription Authorization error because of not waiting for connection_ack after connection_init

Describe the issue
We see authotization errors for almost every Subscription that is started by GraphQL-Flutter on our server (GraphQL-Java).

The connection_init message contains an Authorization header (added via initialPayload). On the server, the auth token is added to the Websocket session for later access.
The start message is received immediately after connection_init.  While processing the start message, the server requires the auth token from the Websocket session to identify the user.
Both messages are processed in separate Threads. The Thread processing connection_init often has not finished adding the auth token to the Websocket session when the start thread requires it. So the subscription fails because no auth token is available.

Expected behavior
After sending connection_init the GraphQL client must wait for connection_ack (or maybe connection_error) before sending start.
This is also described in the GraphQL over WebSocket Protocol.
To Reproduce
If this is really required, I could provide a Java server and a Dart client showing the issue.
device / execution context
We have seen this problem with a GraphQL-Flutter v5.0.0 client on Android and a GraphQL server implemented in Java, but it probably occurs everywhere.
additional notes
It seems that the ApolloGraphQL project has/had the same issue:
https://github.com/apollographql/subscriptions-transport-ws/issues/339
https://github.com/apollographql/subscriptions-transport-ws/pull/767

A similar issue is described in #916 when reconnecting. But we see this problem on the initial connection as well.

I implemented a workaround on the server side for this behavior (not waiting for connection_ack / connection_error before sending start):
We set a value in the session after processing the connection_init message. When processing the start message, we wait until that value is available (with a timeout that produces a failure if it takes too long instead of waiting forever).
The implementation is a bit more complicated than I can describe here because I used non-blocking I/O to avoid waiting threads.
Of course, another behaviour of graphql-flutter would be better than requiring a workaround on the server that makes graphql-flutter unusable for (authenticated) subscriptions for many people, I guess.


Release 0.1.0

Prerequisites

[x] Have at least Editor level access to quilkin Google Cloud project.
[x] Local git remote upstream points at git@github.com:googleforgames/quilkin.git.

Steps

[x] Review that closed issues have appropriate tags for the changelog.
[x] Review that merged PRs have appropriate tags for the changelog.
[x] Run git remote update && git checkout main && git reset --hard upstream/main to ensure your code is in line
with upstream.
[x] Update Cargo version for release

[x] Edit the version field in ./Cargo.toml and remove the -dev suffix.
[x] Edit the quilkin-macros dependency in ./Cargo.toml and remove the -dev suffix.
[x] Edit the version field in ./macros/Cargo.toml and remove the -dev suffix.

[x] cd to ./build/release and run make to submit the cloud build
[x] Download all the artifacts from the cloud build.
[x] Move the CHANGELOG.md to the root of this repository, replacing any previous versions.
[x] Review license.html to ensure that there aren't any new MPL, GPL, LGPL, or CDDL dependencies from the last
release. If there are:

[x] Add the dependencies to
archive_dependencies.sh
so that the source is archived in the container image.
[x] Reset checklist back to "run make to submit the cloud build", and start from there again.

[x] Run cd macros && cargo publish --dry-run and ensure there are no issues.
[x] Run cargo publish --dry-run and ensure there are no issues.
[x] Submit these changes as a PR, and merge with approval.
[x] Create a Github release using the
Github release template.

[x] Populate the tag with v0.1.0, description, and relevant changelog sections.
[x] Attach all the remaining cloud build artifacts to the release.

[x] Run git remote update && git checkout main && git reset --hard upstream/main to ensure your code is in line
with upstream.
[x] Run git checkout -b release-0.1.0 && git push upstream to create a release branch.
[x] Publish to crates.io/crates/quilkin-macros: run cd macros && cargo publish
[x] Publish to crates.io/crates/quilkin: run cargo publish
[x] Submit the release.
[x] Post an announcement to the mailing list.
[x] Post to the Twitter account.
[x] Update Cargo version for development

[x] Edit Cargo.toml and increment the minor version and apply the -dev suffix to the
version.
[x] Edit the quilkin-macros dependency in ./Cargo.toml and increment the minor version
and apply the -dev suffix to the version.
[x] Edit the version field in ./macros/Cargo.tomland increment the minor version
and apply the -dev suffix to the version.

[x] Submit this change as a PR, and merge with approval.

Congratulation! 🎉 You have successfully released Quilkin!

Closing, as we have completed all the steps!