Project Test Case #2

Summary
Currently unable to pass Test Case 2.
Description
I'm not sure why the customer is not joining the wait queue. I already have a method that checks if the server is available/has an open queue but Customer 4 is being served immediately instead of joining the queue when they should, in theory, join the waiting queue as the server has just begun to serve Customer 2 (Customer 2 served and Customer 4 arrived happen at the same time, 1.5). I've checked my PQ and it is being set to compare event times and then subsequently compare customer numbers if event times are the same.
Screenshots (if any):
The test case is below, for reference.
2 1 0.500 1.000 0.600 1.000 0.700 1.000 1.500 1.000 1.600 1.000 1.700 1.000

hi, just by judging from the output I think most likely it is due to the checking condition of going from Arrive -> Wait or Serve I faced similar problem myself and it really can be either the condition or when the customer actually join or leave the queue. I think you can start debugging by code tracing your execute() from Arrive Event and think about when should the server state be updated. for eg should customer leave from Serve -> Done or when Done is executed

Hi,
Another possible mistake that I can think about is that you did not update the Server correctly after it serves a Customer.
Hope it helps!

Hi thanks for the suggestions. However I've now run into a different problem - Customer 4 is now leaving immediately without joining the queue.
Currently my implementation is such that my nextEvent method will return a new Event and Server pair. My server currently uses integers to track the length of their queues, and then the queues would adjust accordingly as long as the length is less than qmax.
What I did was re-implement the updating of the server's next available time such that the server will not be available until the last customer in the queue is served. I've tried to update the queues in the WaitEvent by decreasing the queue count, but to no avail so far...

Is the queue count decreasing successfully, BOTH within the class and outside the class? Try debugging with print statements (or an IDE if you're using that).
I remember forgetting to update either of those. It may help to make a separate, universal method for updating queue count to make things easier to keep track of.

@eLTehh Thanks for the tip!
I've tried running 3.in and 4.in into the simulator as well, and it seems like the problem is very likely the server not being updated outside the Server class, since the cases are returning me outputs like "Customer 1 done serving by 2" when it should be 1.
Since it works for test case 1 it definitely is not because the server isn't being updated within its own class.
I'll try again by implementing the method to update my ImList of Servers in the Simulator.


Keydive stuck on Starting DRM Player Launch Process

$ keydive -w --functions $HOME/Downloads/func.xml -v

2024-10-14 19:04:32 [I] KeyDive: Version: 2.0.9
2024-10-14 19:04:32 [I] Core: Device: Pixel 7 (32091FDH200459)
2024-10-14 19:04:32 [I] Core: SDK API: 34
2024-10-14 19:04:32 [I] Core: ABI CPU: arm64-v8a
2024-10-14 19:04:32 [I] Core: Script loaded successfully
2024-10-14 19:04:32 [I] KeyDive: Watcher delay: 1s
2024-10-14 19:04:32 [D] KeyDive: Analysing...
2024-10-14 19:04:32 [W] Core: Library not found: libwvaidl.so
2024-10-14 19:04:32 [I] Core: Library: android.hardware.drm-service.widevine (/apex/com.google.android.widevine/bin/hw/android.hardware.drm-service.widevine)
2024-10-14 19:04:32 [D] Script: Hooked (0x5ecbd93f60): wvcdm::Properties::UsePrivacyMode
2024-10-14 19:04:33 [D] Script: Hooked (0x5ecbdd1c70): wvcdm::CdmLicense::PrepareKeyRequest
2024-10-14 19:04:33 [D] Script: Hooked (0x5ecbe5a410): zgtjmxko
2024-10-14 19:04:33 [I] Script: Library liboemcrypto.so was not found
2024-10-14 19:04:33 [I] KeyDive: Process: 831 (android.hardware.drm-service.widevine)
2024-10-14 19:04:33 [I] KeyDive: Successfully hooked

I've attempted to use my own extracted widevine functions xml, as well as one provided for my device here: https://forum.videohelp.com/threads/414789-KeyDive-Beyond-Android-SDK-33
MagiskFrida running, server running, tested with pidof frida-server which successfully returned pid. L1 was also reverted back to L3 with liboemcrypto disabler.
Playing widevine video, whether through chrome, firefox, bitmovin, disney+, nothing seems to start the extraction. Here I can provide the XML I extracted from my device:
android.hardware.drm-service.widevine.xml.zip

got a bit further by running keydive with drm video running, and then refreshing. here are the verbose logs:
keydive -d 32091FDH200459 -w --functions $HOME/android.hardware.drm-service.widevine.xml -v
2024-10-14 19:08:11 [I] KeyDive: Version: 2.0.9
2024-10-14 19:08:11 [I] Core: Device: Pixel 7 (32091FDH200459)
2024-10-14 19:08:11 [I] Core: SDK API: 34
2024-10-14 19:08:11 [I] Core: ABI CPU: arm64-v8a
2024-10-14 19:08:11 [I] Core: Script loaded successfully
2024-10-14 19:08:11 [I] KeyDive: Watcher delay: 1s
2024-10-14 19:08:11 [D] KeyDive: Analysing...
2024-10-14 19:08:11 [W] Core: Library not found: libwvaidl.so
2024-10-14 19:08:11 [I] Core: Library: android.hardware.drm-service.widevine (/apex/com.google.android.widevine/bin/hw/android.hardware.drm-service.widevine)
2024-10-14 19:08:11 [D] Script: Hooked (0x5ecbd936e8): wvcdm::Properties::UsePrivacyMode
2024-10-14 19:08:11 [D] Script: Hooked (0x5ecbdcca84): wvcdm::CdmLicense::PrepareKeyRequest
2024-10-14 19:08:11 [D] Script: Hooked (0x5ecbe58cbc): ehmduqyt
2024-10-14 19:08:11 [I] Script: Library liboemcrypto.so was not found
2024-10-14 19:08:11 [I] KeyDive: Process: 831 (android.hardware.drm-service.widevine)
2024-10-14 19:08:11 [I] KeyDive: Successfully hooked
2024-10-14 19:08:17 [D] Script: [+] onEnter: UsePrivacyMode
2024-10-14 19:08:17 [D] Script: [-] onLeave: UsePrivacyMode
2024-10-14 19:08:17 [D] Script: [+] onEnter: UsePrivacyMode
2024-10-14 19:08:17 [D] Script: [-] onLeave: UsePrivacyMode
2024-10-14 19:08:17 [D] Script: [+] onEnter: PrepareKeyRequest
2024-10-14 19:08:17 [D] Script: [+] onEnter: UsePrivacyMode
2024-10-14 19:08:17 [D] Script: [-] onLeave: UsePrivacyMode
2024-10-14 19:08:17 [D] Script: [-] onLeave: PrepareKeyRequest
2024-10-14 19:08:17 [D] Cdm: Failed to set challenge data: Error parsing message
2024-10-14 19:08:17 [D] Cdm: Receive client id:

{
  "application_name": "com.android.chrome",
  "origin": "73AFE289899F92630A7FEC75D2D53007",
  "package_certificate_hash_bytes": "8P1sW0EPJcslw7UzRsiXL64w+O50Ed+RBICtay1g24M=",
  "company_name": "Google",
  "model_name": "Pixel 7",
  "architecture_name": "arm64-v8a",
  "device_name": "panther",
  "product_name": "panther",
  "build_info": "google/panther/panther:14/AP2A.240905.003/12231197:user/release-keys",
  "widevine_cdm_version": "18.0.0@341113000",
  "oem_crypto_security_patch_level": "0",
  "oem_crypto_build_information": "{\"soc_vendor\":\"L3_28613\",\"soc_model\":\"ARM 64 bit\",\"ta_ver\":\"18.1.0+May  1 2023_06:32:58_\",\"uses_opk\":false,\"tee_os\":\"none\",\"tee_os_ver\":\"0.0.0\",\"form_factor\":\"L3\",\"implementer\":\"Widevine\",\"fused\":false}"
}

As we were able to discuss on discord, your problem was linked to a bad private saved function. With your help I was able to identify the problem and correct this bad function. However, to prevent this type of problem from occurring again in other use cases I added a new option -s or --skip which allows this automatic detection and hook to be passed "like ci" function had not yet been registered.


Update 20240702

updates freyja
updates nextclade
fixes extra rows in vadr (closes https://github.com/UPHL-BioNGS/Cecret/issues/344)
added mpox ref (closes https://github.com/UPHL-BioNGS/Cecret/issues/342)
adjusts versions of tools in summary file
fixes multifasta summary file issue (closes https://github.com/UPHL-BioNGS/Cecret/issues/148)

Closes https://github.com/UPHL-BioNGS/Cecret/issues/345


Assertion when creating too much files in the same directory

lfs_file_sync: Assertion `entry.d.type == LFS_TYPE_REG'  failed
This happens when we create a directory and then a lot of files in the root directory.
The issue is reproduced by the attached test.
test_multiple_files.sh.txt
test_multiple_files.log

Good catch and thanks for creating a great issue. The test case helped tremendously.
It looks like it was an issue with the directory chain appending not updating the internal directory structure. This issue doesn't show itself in mkdir, since it doesn't use the directory structure afterwards. Unfortunately, the existing tests against extending the directory chain were all made using mkdir.
Does this patch look good to you?
https://github.com/geky/littlefs/compare/fix-multi-block-append-files

It's great! Thanks for the fix


SLA querys have different results

I was looking at the commands to list all of the SLAs and found 2 ways to get the data.  On closer inspection the commands return different results.  Do you know why these commands return different results?
PS C:\Users\jwebb6> (Invoke-RscQuerySla).Nodes.count
131
PS C:\Users\jwebb6> (Invoke-Rsc "query {clusterSlaDomainConnection{nodes{name,id}}}").Nodes.count
491
PS C:\Users\jwebb6>

Hi @krobar1
I think that's due to the way the cmdlet handles defaults.
It looks like the Invoke-RscQuerySla cmdlet returns a list of Global SLAs (RSC-Managed). Try the following:
Get a list of Global SLAs
Invoke-RscQuerySla or Invoke-RscQuerySla -GlobalFilterList
Now try getting a list of Cluster SLAs
Invoke-RscQuerySla --ClusterDomainList
Let me know if that returns the correct numbers.
Thanks
Rynardt

Ok. That verifies our understanding of which SDK pulls what information.
PS C:\temp> Invoke-RscquerySla -GlobalFilterList
Count Edges Nodes                                                                                PageInfo

131       {2023-01-11T18-54-15Z_Uruaguay_LATAM_USTRY14RBRKBU01, 8 Weeks Retention, AMUS_CKU1_NDB_UDB_LO_0100, AMUS_CKU1_PDB_UDB_LO_YEARLY…} RubrikSecurityCloud.Types.PageInfo
PS C:\temp> Invoke-RscquerySla -ClusterDomainList
Count Edges Nodes                                                              PageInfo

491       {1102_testvol_sla, 7day_Repli_Retention, AArgentina Temp, AATemp…} RubrikSecurityCloud.Types.PageInfo
PS C:\temp>

Scrubbing old issues ... I believe this is resolved, please re-open if not.


Error loading preference bundle for tweak.

Describe the bug
What’s up? I purchased two tweaks this week
callled Dope Convos and Genesis. When I went so settings, I get this error for both of these tweaks. What can I do to solve these errors?
To Reproduce
Steps to reproduce the behavior:

Go to settings
Click on Tweaks
Scroll down to DopeConvos
See error

**Screenshots

Device (please complete the following information):

iOS Version: 13.5
iOS Device: iPhone XS Max
unc0ver Version: 5.0.0

Place an "x" between the brackets if true:

[x] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

Logs
If applicable, add logs or error messages here.

I also have tweaks that should work, but dont, on my SE2, yet still work on my old SE both on 13.5, even with all usual supporting tweaks installed (rocketbootstrap, applist, preference loader) some tweaks just refuse to work with u0.. at guess its either install bracketed tweaks.. if there already installed, devs need to update there tweaks. Unless (this is a long shot & i also doubt) its an issue with substitute & it's compatibility with substrate made tweaks (if thats even a thing lol) 🤷🏼♂

Facing the same with scorpion, airport, Lynx and other tweaks as well.

This seems to be an A12+ issue. The (or... one?) cause of it is described in #2045 . You'll need to wait for the developer to update and recompile the tweak.

What preferenceloader are you using?

Yes I'm using iPad 8 A12 and my iPad OS version is 14.2. Using Unc0ver 6.1.0 to jailbreak and when installing some tweaks its still not work. Still no solution?


chore: release main

:robot: I have created a release beep boop
create: 1.0.8
1.0.8 (2024-03-31)
Bug Fixes

publish attempt - 5 (c93a8a6)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/templ-project/create/releases/tag/create-v1.0.8 :sunflower:


Tune QPDF::getCompressibleObjGens

A couple of minor changes to container types.
The only controversial bit is a change to loop detection, which only uses the object id (not the generation number). As a result, in files with accessible indirect references  x y R and x z R, y != z, getCompressibleObjGens may exclude one of x y R and x z R, and possibly other objects only accessible through them.
I don't think its worth the cost of checking for this possibility, otherwise there should also be a test case for this.

X Y n and X Y n+k are not allowed to both be defined. If X Y n+k exists, then X Y n is automatically null. Coincidentally, I was just rereading this in the spec yesterday since I'm thinking about adding better support for incremental updates. As long as this change is not going to mess that up, it should be okay based on your description. I haven't looked at the change yet but will scrutinize it. I may add some tests for generation anyway -- I haven't thought about it since the very beginning, and I'm not 100% sure it's right (though I have no reason to believe it isn't). I know QPDFWriter assumes generation = 0, and I will have to address that. Or at least it did. Maybe I fixed it already. I can't remember. Weird to think I've had qpdf for almost half my life.

X Y n and X Y n+k are not allowed to both be defined. If X Y n+k exists, then X Y n is automatically null.

I realized that. I guess there are three questions

is it legal for an (effectively dangling) reference to X n R to exist (in a reachable object) , if the current generation is n + k ?

how likely is it to happen in practice, and if so, how likely is it that X n R is scanned before X n+k R?

if it happens, is it acceptable that qpdf treats the X n+k R as non-compressible?

If we need to deal with this case, we would need to either ensure that dangling references are not included in the visiting set, or are only included if the next entry in the object table has a different object id.

Ugh, qpdf is broken with handling of generations because of a bug that has been there since the very beginning.

qpdf allows two different generations to exist together. I can't believe I made that mistake 20 years ago and it's been sitting there undetected all this time.

Probably this bug has been hiding since qpdf correctly handles PDFs that delete and reuse objects per the spec. It's just that it would not handle certain types of errors that viewers handle properly; as such, people are not likely to create files like this, and there's probably no reason for the problem to have ever occurred. To be specific, in qpdf, if you create, say 4 0 obj, then delete it, then create 4 1 obj, qpdf will still resolve 4 0 R, which should now be considered null. I will have to see what the implications of this are and how hard it is to fix. Anyway, it does seem that this bug was actually in qpdf 2.0, the very first open source release of qpdf.

I made my Ugh comment before I read your comment. Objects with generation > 0 are never compressible.

I realized that. I guess there are three questions
* is it legal for an (effectively dangling) reference to X n R to exist (in a reachable object) , if the current generation is n + k ?

Yes. This is normal.

* how likely is it to happen in practice, and if so, how likely is it that X n R is scanned before X n+k R?

This is the normal case. What order it is scanned in will depend on how the file is referenced. When an object is deleted by incremental update, all the places where it was previously referenced will contain dangling references. Unless the incremental update replaces all the objects that referenced the deleted object, then the dangling references will stay around and be null.

* if it happens, is it acceptable that qpdf treats the X n+k R as non-compressible?

qpdf must treat X n+k R as non-compressible. There is no provision in the PDF spec for objects with generation != 0 to be compressed.

If we need to deal with this case, we would need to either ensure that dangling references are not included in the visiting set, or are only included if the next entry in the object table has a different object id.

qpdf is broken in some cases here. I added some expected fail tests to illustrate this. I will scrutinize this change to make sure that it's okay with my refreshed understanding of generations including qpdf's current broken behavior regarding them.

Let me amend my previous comments. I'm thinking ahead to incremental update. Right now, QPDFWriter never writes a generation > 1, so this is free to return ObjGen with generation > 1. They won't have generation > 1 once they are written because QPDFWriter will renumber them.

I think we can't take this as it is. However, in the vast majority of cases, particularly where object streams are in use, there are no objects with generation > 0. I think a small tweak that mantains a set for things with generation > 0 would fix this. Do you want to try it? If not, I can.

I know it's late for you already.

I already made a fix. I will push up to a branch and add a test. If it works, I'll take it, and that will grab this change with it.

Objects with generation > 0 are never compressible.

I knew that, (but failed to think of it). In any case, such an object mar refer to compressible objects that are not otherwise reachable.

I am creating a meaningful test for this.

I'll have something up in a few minutes.

@m-holger Please see #1110. The new test files were completely hand-generated since I don't have qpdf support for updating xref tables with incremental updates at this time. (But I have emacs lisp functions to help me generate xref tables and migrate around PDF files.)

I knew that, (but failed to think of it). In any case, such an object mar refer to compressible objects that are not otherwise reachable.

Right -- I made sure to do that in my test file.

Right -- I made sure to do that in my test file.

well, almost...fixing my test to actually do that.


port to kernel 4.1

this code is not fully ported and debugged. Only analog input and analog output have been tested. Also it will not work with previous kernels.

Hey there, I would love to help test this. Is there anything specific I should test first?
Cheers

I think you should test whatever is implemented. Here, check if analog inputs and outputs are working.
It would not be wise to merge this code because not all functions are supported. If someone can work on other functions, it will be great.
Thanks for your efforts.

Aditya, can comment on what is supported and tested in the orignal bonescript?
Shaun, for the moment only analog input and analog output have been tested. Also, do not use node version 0.12.xx, stick with 0.10.xx

Digital input and output should be allright now, as well interrupts on digital inputs. The dependencies for serial and i2c are removed. Overlays have been replaced by the overlays that ship with capemanager 4.1.

Original bonescript functions are listed in this wiki with examples.
https://github.com/theoctal/octalbonescript/wiki

Let me know how to take this forward. Should I create new branch and merge PR there? We will merge to main repo when everything is stable.

I'm not conversant in all the working of github. But presume that your suggestion is fine. Please let me know if i should take any action.
----Origineel Bericht----
Van<EMAIL_ADDRESS>Datum : 18/09/2015 07:49
Aan<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS>Onderwerp : Re: [octalbonescript] port to kernel 4.1 (#46)
Let me know how to take this forward. Should I create new branch and merge PR there? We will merge to main repo when everything is stable.
—
Reply to this email directly or view it on GitHub.

Also note that i've made improvements after the initial pull request. The latest version is stored at github:
https://github.com/ruth0000/octalbonescript_capemgr4_1
----Origineel Bericht----
Van<EMAIL_ADDRESS>Datum : 18/09/2015 07:49
Aan<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS>Onderwerp : Re: [octalbonescript] port to kernel 4.1 (#46)
Let me know how to take this forward. Should I create new branch and merge PR there? We will merge to main repo when everything is stable.
—
Reply to this email directly or view it on GitHub.

Hi, just wanted to let you know that I have incorporated some of changes from your PR to master branch. I have published new version 1.1.0-beta so everyone can test it on 4.1 kernel. If everything goes fine, you can expect new stable version with 4.1 kernel support by this Sunday.

I need your help to understand the changes you made in DTS files. Let's chat some day when you are free.

I request you to submit changes to the DTS files to this repo: https://github.com/cdsteinkuehler/beaglebone-universal-io It's repo which maintains the universal-cape files for linux kernel.


Provide a basic example of UWP Json usage

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Node.js Foundation Community Committee Meeting 2019-08-08

Time
UTC Thu 08-Aug-2019 16:00 (04:00 PM):

Timezone
Date/Time

US / Pacific
Thu 08-Aug-2019 09:00 (09:00 AM)

US / Mountain
Thu 08-Aug-2019 10:00 (10:00 AM)

US / Central
Thu 08-Aug-2019 11:00 (11:00 AM)

US / Eastern
Thu 08-Aug-2019 12:00 (12:00 PM)

London
Thu 08-Aug-2019 17:00 (05:00 PM)

Amsterdam
Thu 08-Aug-2019 18:00 (06:00 PM)

Moscow
Thu 08-Aug-2019 19:00 (07:00 PM)

Chennai
Thu 08-Aug-2019 21:30 (09:30 PM)

Hangzhou
Fri 09-Aug-2019 00:00 (12:00 AM)

Tokyo
Fri 09-Aug-2019 01:00 (01:00 AM)

Sydney
Fri 09-Aug-2019 02:00 (02:00 AM)

Or in your local time:

http://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Community Committee+Meeting+2019-08-08&iso=20190808T16
or http://www.wolframalpha.com/input/?i=04PM+UTC%2C+Aug+08%2C+2019+in+local+time

Links

Minutes Google Doc: https://docs.google.com/document/d/12H75ARza1LpKoZ6DUZH-Vy5EwiiT7fGjASuieSymTLs/edit

Agenda
Extracted from cc-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/admin

Tracking issue for update on CPC and Board Meetings #395

nodejs/community-committee

Towards less conflicts from biases/assumptions in communication styles/conventions #507
Removing labels in archived repos #505
Charter Update to Reflect New OpenJS Foundation #499
Node.js Social Media Community Collaboration #444
Node.js Collection – Next Steps #439

Invited

CommComm Members: @nodejs/community-committee

Observers/Guests
Feel free to follow along on the YouTube live stream, or attend meeting as a guest
by calling in to Zoom, using the links below. If you will be attending as a guest,
please comment on this issue to let us know you'll be joining.
Notes
The agenda comes from issues labelled with cc-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting

Link for participants: https://zoom.us/j/527273462
For those who just want to watch: https://www.youtube.com/channel/UCQPYJluYC_sn_Qz_XE-YbTQ

Invitees
Please use the following emoji reactions in this post to indicate your
availability.

:+1: - Attending
:-1: - Not attending
:confused: - Not sure yet

I'll be joining as an observer/guest today :)

I will be helping run this today, since Adam will be on a flight 👍


QUESTION: RTL Support

If it is possible for your perfect work to support RTL (right to left) directions for the admin panel

yes would you please be kind enough to provide us a Right to Left version of your code?
thanks alot

Hi all, please try the pre version of v1.27.0 with a right sidebar, if you mean this with your issue. :)

AdminLTE v2 doesn't support out of the box RTL & Bootstrap also has no RTL support.
AdminLTE v3.1.0 will bring this support with an Custom Boostrap v4 for RTL support.

So how to make it RTL

See https://github.com/mmdsharifi/AdminLTE-RTL which supports RTL via CSSJanus. Perhaps you can use or collaborate?
Or use CSSJanus directly in this project. See php-cssjanus or  node-cssjanus.


scan: segmentation fault while fetching authorized user

Description
scan throws segmentation fault.
What did you expect to happen?
$ chain-bench scan --repository-url github.com/Dentrax/cocert --access-token $TOKEN

What happened instead?
Error line: https://github.com/aquasecurity/chain-bench/blob/25fe2336cefc0ebf6ba664a26ee13f6d927a0714/internal/scm-clients/clients/clients.go#L32
2022-07-07 17:12:19 INF 🚩      Fetch Starting
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x17370bb]

goroutine 1 [running]:
github.com/aquasecurity/chain-bench/internal/scm-clients/clients.FetchClientData({0x7ff7bfeff380, 0x1}, {0x7ff7bfeff357?, 0x1?})
        /home/runner/work/chain-bench/chain-bench/internal/scm-clients/clients/clients.go:32 +0x9b
github.com/aquasecurity/chain-bench/internal/commands.NewScanCommand.func1(0xc00020e280?, {0x18f4738?, 0x4?, 0x4?})
        /home/runner/work/chain-bench/chain-bench/internal/commands/scan.go:22 +0xac
github.com/spf13/cobra.(*Command).execute(0xc00020e280, {0xc000175f80, 0x4, 0x4})
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:856 +0x67c
github.com/spf13/cobra.(*Command).ExecuteC(0xc00020e000)
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:974 +0x3b4
github.com/spf13/cobra.(*Command).Execute(...)
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:902
github.com/aquasecurity/chain-bench/internal/commands.Execute({0x1a41c1c?, 0xc0000021a0?})
        /home/runner/work/chain-bench/chain-bench/internal/commands/root.go:21 +0x32
main.main()
        /home/runner/work/chain-bench/chain-bench/cmd/chain-bench/main.go:12 +0x27

Additional details (base image name, container registry info...):

Hey @Dentrax , as @rgreinho suggested please try to add https in the beginning of the url and check if its still happening


可以支持下Firefox吗？

Firefox 57+后使用了与Chrome Extension API高度兼容的WebExtensions API，或许可以尝试兼容下。
而且AOM（Firefox的附加组件商店）上架是免费的

官网提示不支持，实际上在AMO上是能搜到安装的。。。

Sorry for the confusion. I do have plans to update the website but have
been kept too busy to do so recently. I will try to push an update by next
week.
On Wed, Feb 28, 2018 at 4:27 AM 花生PeA<EMAIL_ADDRESS>wrote:

官网提示不支持，实际上在AMO上是能搜到安装的。。。
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zacyu/bilibili-helper/issues/445#issuecomment-369175670,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABpnAdDtIZTyhBXhhgaqt1kSykPMMORMks5tZRvpgaJpZM4SWUsQ
.

--
Zac Yu
(412) 690-0688  |<EMAIL_ADDRESS>| zacyu.com

Maybe you can update the README.md first.


add generic support for http routes registering #2227 #2457

Codecov Report
Patch coverage: 36.36% and project coverage change: +0.02% :tada:

Comparison is base (e0e0043) 79.22% compared to head (2b1d509) 79.25%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2807      +/-   ##
==========================================
+ Coverage   79.22%   79.25%   +0.02%
==========================================
  Files         633      630       -3
  Lines       52242    51910     -332
==========================================
- Hits        41391    41142     -249
+ Misses       8808     8739      -69
+ Partials     2043     2029      -14

Flag
Coverage Δ

go-1.15-386
?

go-1.15-amd64
?

go-1.16-386
?

go-1.16-amd64
?

go-1.17-386
?

go-1.17-amd64
?

go-1.18-386
?

go-1.18-amd64
?

go-1.19-386
79.23% <36.36%> (+<0.01%)
:arrow_up:

go-1.19-amd64
?

go-1.20-386
?

go-1.20-amd64
79.25% <36.36%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

net/ghttp/ghttp_server_service_handler.go
59.85% <36.36%> (-0.15%)
:arrow_down:

... and 9 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

golangci 提示的地方是不是需要处理一下

golangci 提示的地方是不是需要处理一下

done


Drc 07 add GitHub actions

@AlexandraArntsen  this will create a test run of the tact tool every time the development or master branches are updated with code.

wrong branch


Chrome Icon

The size of the Chrome icon is smaller than the rest.

I don't have this issue.

Could you provide a screenshot or similar?

Its not really a big issue actually. Just my OCD acting up. If other people dont have this issue, maybe this bug is only on my phone.

Upon checking this, both Chrome and the Dailer have the correct sizes, however contacts is smaller and messages is off the centre. I'll make a PR for making contacts bigger and bringing messages to the centre (but I think its off because it has a bit sticking out. if its in the centre then it'll look off).

This is due to scaling done by the launcher, not the icons themselves.
I'll be closing & marking this issue as a duplicate as it's already been mentioned in #230


Fix tab group sync

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixing https://github.com/facebook/docusaurus/issues/8473
Test Plan

Test Syncing tab choices section of Docusaurus Tabs page. Syncing feature should work as expected.
Test Query string section of the same page. "Android, iOS" tab group should be synced and URL query params should change on select.

Test links

Deploy preview: https://deploy-preview-8483--docusaurus-2.netlify.app/
Related issues/PRs

https://github.com/facebook/docusaurus/issues/8473
https://github.com/facebook/docusaurus/pull/8225

Thanks
Will review this more deeply later, but in the meantime this PR breaks the querystring feature.
Opening this in a new session (clean/empty localstorage) should focus the iOS tab, but it doesn't anymore:
https://deploy-preview-8483--docusaurus-2.netlify.app/docs/markdown-features/tabs/?current-os=ios#query-string

Thanks for trying, but I'm going to open a different PR with a totally different way to handle things (useSyncExternalStore)
The current legacy way is not ideal and I'd like to get rid of this provider and react state synchronisation. As we can see, this leads to subtle bugs and is overly complex

@slorber No problem! I was concerned about adding more to the context too, and now excited to see a better implementation :smile:

Thanks
Closing this PR in favor of https://github.com/facebook/docusaurus/pull/8486
Can you help review and let me know if you see any issue?


Users need to know they can use GOV.UK Verify whether or not they already have an account

'I do not think I am registered with GOV.UK'

'User assumed they already had a Verify account on this page'

Not seeing this issue in Round 3


fixed Elastic Ips costings

removed Region mapping from elastic ips ( ec2 )

Thanks for the pull request,chanakyacool
The build is currently failing.  If you re-record the ElasticIPs cassette is should pass. Simply
rm fixtures/vcr_cassettes/AWSCosts_ElasticIPs.yml` bundle exec rake
If the tests pass commit and update the PR.
thanks.

@srbartlett  i will close this pull request and fix the failing tests , i had re-recorded the cassettes but it failed again ..
i would create a new pull request so with every thing in green :smile:


Create fails with Floating IP pool not found

Working my way through the readme instructions.
I have a network which is apparently external - from Horizon:
Name	Subnets Associated	Shared	External
ilab	ilab <IP_ADDRESS>/16     Yes	Yes

However if I try to run molecule create without specifying fip_pool I get an error:
"msg": "ResourceNotFound: 404: Client Error for url: http://<IP_ADDRESS>:8774/v2.1/os-floating-ips, Floating IP pool not found."}

This a Neutron-managed network so "floating IP pools" don't exist. I tried setting network name as the fip_pool but that fails with:
"msg": "Timeout waiting for the floating IP to be attached."

Ok sorted, sort of. I was using the default molecule.yml. This sets fip_pool from MOLECULE_OPENSTACK_FIP_POOL, which if thats not set, fails (ends up as empty string?). Commenting out the fip_pool key under platform makes it work.

Ok sorted, sort of. I was using the default molecule.yml. This sets fip_pool from MOLECULE_OPENSTACK_FIP_POOL, which if thats not set, fails (ends up as empty string?). Commenting out the fip_pool key under platform makes it work.

Hi @sjpb.
Thank you for reporting this. As you found out commenting out fip_pool from molecule.yml solves it due to this.
In any case I think that either:

this needs to be documented for other users hitting this problem or
create.yml needs to be updated so that if fip_pool is empty or the env_var passed to it is undefined then floating_ip_pools should be omitted

The second approach is better as it will work out of the box for both external and non-external networks. I'll have a look later this week

Hi @sjpb.
Thank you for reporting this. As you found out commenting out fip_pool from molecule.yml solves it due to this.
In any case I think that either:

this needs to be documented for other users hitting this problem or
create.yml needs to be updated so that if fip_pool is empty or the env_var passed to it is undefined then floating_ip_pools should be omitted

The second approach is better as it will work out of the box for both external and non-external networks. I'll have a look later this week


Add a application registration

This PR provides application registration function.
https://github.com/tootsuite/documentation/blob/master/Using-the-API/API.md#apps
Usage.
func main() {
	ac := mastodon.NewAppClient(&mastodon.AppConfig{
		Server:       "https://mstdn.jp",
		ClientName:   "Test App",
		RedirectURIs: "urn:ietf:wg:oauth:2.0:oob",
	})

	app, err := ac.RegistrationApp()
	if err != nil {
		log.Fatal(err)
	}

	c := mastodon.NewClient(&mastodon.Config{
		Server:       "https://mstdn.jp",
		ClientID:     app.ClientID,
		ClientSecret: app.ClientSecret,
	})

	...
}

No need to make instance like appClient. Please make simple func like below.
func RegisterApp() (*Application, error) {
  //
}

LGTM.

Thank you

Thank you so much for review!
I Fixed it to a simple function.
I was wondering where to place http.Client, but I put it in AppConfig.
Is this OK?
type AppConfig struct {
	http.Client

Usage.
func main() {
	app, err := mastodon.RegisterApp(&mastodon.AppConfig{
		Server:       "https://mstdn.jp",
		ClientName:   "Test App",
		RedirectURIs: "urn:ietf:wg:oauth:2.0:oob",
	})
	if err != nil {
		log.Fatal(err)
	}

	c := mastodon.NewClient(&mastodon.Config{
		Server:       "https://mstdn.jp",
		ClientID:     app.ClientID,
		ClientSecret: app.ClientSecret,
	})

	...
}

Thank you so much for merging!

I was wondering where to place http.Client, but I put it in AppConfig.
Is this OK?

This is my expected.


Fix formatting

There is no need to do that because we don't edit that file manually. This file is generated by go-bindata.


InboundShipments:create_inbound_shipment_plan issue (TypeError: quote_from_bytes() expected bytes)

Hello,
I have been successfully using the mws package with the orders API.  I'm now trying to use the InboundShipments API and I'm running into issues.  I've been trying to narrow it down with simple code as such :+1:
inboundShipments = mws.InboundShipments(
    access_key=settings.get['az_access_key'], secret_key=settings.get['az_secret_key'],
    account_id=settings.get['az_seller_id'],auth_token=settings.get['az_auth_token']
)
address = {
    "name": settings.get['companyName'],
    "address_1":settings.get['address1'],
    "address_2": settings.get['address2'],
    "city": settings.get['city'],
    "district_or_county": settings.get['district'],
    "state_or_province": settings.get['region'],
    "postal_code": settings.get['postal'],
    "country": settings.get['country']
}
inboundShipments.set_ship_from_address(address)

items=[ {'sku': '012-34-5678', 'quantity': 50},  {'sku': '123-45-6789', 'quantity': 100} ]

inbound.create_inbound_shipment_plan(items,label_preference='SELLER_LABEL')

this yields the following error:
`
File "/usr/local/lib/python3.8/dist-packages/mws/mws.py", line 1045, in create_inbound_shipment_plan
return self.make_request(data, method="POST")
File "/usr/local/lib/python3.8/dist-packages/mws/mws.py", line 229, in make_request
request_description = calc_request_description(params)
File "/usr/local/lib/python3.8/dist-packages/mws/mws.py", line 89, in calc_request_description
encoded_value = quote(params[key], safe='-_.~')
File "/usr/lib/python3.8/urllib/parse.py", line 839, in quote
return quote_from_bytes(string, safe)
File "/usr/lib/python3.8/urllib/parse.py", line 864, in quote_from_bytes
raise TypeError("quote_from_bytes() expected bytes")
TypeError: quote_from_bytes() expected bytes
`
I'm on the latest 0.8.9 installed from Pip
Thanks!

While technically latest on PyPI is 0.8.10, that's a moot point, as this is a known issue in code on master branch. We've corrected for issues like this on develop branch, which will eventually overwrite master for a 1.0 release.
For a quick fix, you will need to write your quantities as strings ({'quantity': '100'}, for example).
Seems fair to backport our cleaning logic from develop into here and cut a new patch release to cover it, though. Thank you!

Thank you for the reply.
Yes, I've tried passing quantities as strings:
items=[ {'sku': '012-34-5678', 'quantity': '50'},  {'sku': '123-45-6789', 'quantity': '100'} ]

I still get the same error, however.

Update:  I just tried this with the Develop branch with no success as well (though for a different reason).  I will create a separate issue for this

Just updating this to be more clear.  On the 0.8.x branch, this does not appear to work, even when the quantities are passed as strings

This may be something in your settings, then. Is settings['postal'] an int?
I've still got to get that cleaning code in there to sort this out properly without these edge cases. 😓

@GriceTurrble
I don't currently have v 0.8.x installed, but I do believe that you are correct - the postal code was being returned as an Int, so I'm sure that is the problem.  Thanks!


Uninstall-PSResource should have a PassThru parameter

Summary of the new feature / enhancement
Uninstall-PSResource should have a PassThru parameter for the caller to get the list of resources uninstalled.
Proposed technical implementation details (optional)
No response

Thanks @ThomasNieto we thought verbose made more sense in this case, but I am understanding that could make it more difficult to automate a check against the uninstall


Update Storage-Spaces-Direct-Hardware-Requirements.md

Thanks, Elden - you should see this change live Friday afternoon.

Thanks!
From: Liza Poggemeyer<EMAIL_ADDRESS>Sent: Friday, December 15, 2017 10:42 AM
To: MicrosoftDocs/windowsserverdocs<EMAIL_ADDRESS>Cc: Elden Christensen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/windowsserverdocs] Update Storage-Spaces-Direct-Hardware-Requirements.md (#306)
Thanks, Elden - you should see this change live Friday afternoon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fwindowsserverdocs%2Fpull%2F306%23issuecomment-352080795&data=04|01|eldenc%40microsoft.com|40d7c54491dc438014f808d543eb80ae|72f988bf86f141af91ab2d7cd011db47|1|0|636489601115754360|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=gK3Ac43jPZwCkJV4TQzwOpezgYd0Q2eWK6nXWY%2BUYGM%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAXId_xNUJx3iGer1tyDy86R1M9_UWK5Yks5tAr1sgaJpZM4RD0M6&data=04|01|eldenc%40microsoft.com|40d7c54491dc438014f808d543eb80ae|72f988bf86f141af91ab2d7cd011db47|1|0|636489601115754360|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=%2Fy5bqVCXkfL2n9pg7JfSIDDkRXnxSY32cdA4BZU%2Bpxc%3D&reserved=0.


Performance and Laziness

It appears there's no laziness at all in hyperapp -- no diff of props:
https://github.com/hyperapp/hyperapp/blob/f29647bf9da4bc281078abcacd116031f9fb0c3e/src/app.js#L159-L163
Have you tried this out in a large application with 1000s of nodes?

There's also no batching for vnodes at the moment, but there used to be. There are more than a couple things we could do to optimize the vdom implementation.
Here's a repaint perf test.

there's no laziness at all
Would that be something you can help with?

See also:

https://github.com/hyperapp/hyperapp/issues/13

@jbucaran please consider implementing https://github.com/krausest/js-framework-benchmark, it is much more representative of real-world performance.
the only thing dbmonster tests is initial creation and .className and .textContent (or .nodeValue) replacement; it doesnt test complex reconciliation cases, track-by-key bindings or dom mutations that cause reflow/restyle.

@leeoniya Thanks! That's next on my list.

Can you help with that?

Sure! Let me see what I can do.

oh wait, I just realized there's no composition of components here...

@ccorcos What do you mean?

@jbucaran maybe #2, haha. @ccorcos ?

yes, every similar. there needs to be some way of combining components together. Hyper isnt so scalable in terms of breaking up components and reusing them by combining them together. For example:
const TwoCounters = app({
    model: {
        one: Counter.model,
        two: Counter.model,
    },
    update: {
        one: ({one, two}) => ({two, one: Counter.update(one)})
        two: ({one, two}) => ({one, two: Counter.update(two)})
    },
    view: ({one, two}, actions) =>
        <div>
            {Counter.view(one, actions.one)}
            {Counter.view(one, actions.two)}
        </div>
})

Then laziness could be introduced where Counter one doesnt need to be rerendered when Counter two changes...

@ccorcos This is not supported since https://github.com/hyperapp/hyperapp/pull/77.
<MyComponent propts=...>children</MyComponent>

I got news. I'm using https://wildlyinaccurate.com/todomvc-perf-comparison as the benchmark runner. I'm not yet done cleaning up the implementation, but  here are some preliminary results:

Clearly there's much work to be done to improve the vdom engine. Currently no optimizations are in place, so I expect these numbers to improve over time as I work on the engine, but at least we are not the slowest.

We are almost like Angular, it's not okey. But yea.
Can you add choo? So we can see how we are compared to it which is similar and uses real dom.

from that screenshot, there's not a single recent version lib there; the fastest impl (Mithril) is using an ancient 0.1.21.
take my word for it, just bench this: https://github.com/krausest/js-framework-benchmark

@tunnckoCore This is time consuming, so I can't promise I'll add it soon, I'
@leeoniya I just forked lhorie's implementation of the benchmark and added mine, I wasn't really paying attention to the version of the other libraries.
Do you have any idea how to get started with the krausest/js-framework-benchmark benchmarks? The README does an incredible good job at not explaining that and from all the other benchmarks I've seen, this one looks more challenging.

Do you have any idea how to get started with the krausest/js-framework-benchmark benchmarks?

Yes. The implementation itself is easy, though actually running the bench is less easy - i usually leave the latter to @krausest since he does this for the majority of pull requests and merges.
There are two versions of the bench, and you can implement one or both: -keyed and -non-keyed. Here are examples of my impls with domvm [1][2]. Your package.json should have a build-prod script [3] that bundles and compiles your app as needed.
Other than that, all you have to make sure is that it behaves correctly in the browser, like vanillajs and vanillajs-keyed. Youc an get an idea of the perf from the console timers that are called from your impl, but the actual bench will extract the numbers from Chrome's timeline in a very stable/reproducible way between runs.
[1] https://github.com/krausest/js-framework-benchmark/tree/master/domvm-v2.0.1-keyed/src
[2] https://github.com/krausest/js-framework-benchmark/tree/master/domvm-v2.0.1-non-keyed/src
[3] https://github.com/krausest/js-framework-benchmark/blob/master/domvm-v2.0.1-keyed/package.json#L7

Also, I'm not sure what it means, but FWIW HyperApp was actually the fastest in the async version of the benchmark. 😄

You clearly are aware of something I am not.

I've done impls of a lot of benchmarks. This one is by far the most representative of expected perf and highly stable between runs due to its methodology. Basically, this bench tends to accurately reflect the performance results of all other benches and covers enough surface area not to only test a couple specific cases (like dbmon). There's nothing TodoMVC bench will tell you that you won't find out more thoroughly and with better feedback from js-framework-benchmark.
There are other good ones, like uibench and vdom-benchmark but they don't have the most up-to-date impls of other libs, so it's difficult to compare vs most recent lib versions. They also dont have great output for assessing relative perf in an intuitively-colored scale.

Also, I'm not sure what it means, but FWIW HyperApp was actually the fastest in the async version of the benchmark. 😄

If your implementation or lib is async, rather than relying on the console timers, you should open up chrome's timeline view and record the perf between actions. Then look at "Scripting time", etc in the pie chart.

I added some hints how to start your implementation in the README of js-framework-benchmark at the bottom. Just let me know if that helps. If you have specific questions don't hesitate to ask.

@jbucaran I bet the bigger the app, the worse hyper will perform. try that benchmark with a website that has 1000s of components

@ccorcos of course, absolutely, because each "app" can sucks more than the framework with which it is built. :D

well my point is if you wanted to build a custom visualization or some kind of dashboard, the lack of laziness is going to become a problem. i dont mean to be a put-down -- I like what you guys are building here

@ccorcos Do laziness only applies to components? I revisited your example and now I get what you were saying. 👍

Related question: does hyperapp currently re-use old DOM nodes when rendering?

/cc @ccorcos @tunnckoCore @dodekeract @sotojuan
tl;dr

HyperApp has decent performance.
Optimized engines like Inferno and Mithril are unequivocally faster, but there is no extraordinary advantage.
Choo has consistently the poorest performance of all the tested frameworks.

I followed @leeoniya's suggestion and implemented the js-framework-benchmarks. I still need to create the PR, but I wanted to share the results right away.
HyperApp's numbers in the TodoMVC benchmarks before were alright-ish, but some runs actually yielded better numbers than others.
Why is that? I suspect my TodoMVC implementation is half the issue. Object.assign is heavily used to clone list items and there are virtually no mutations. The other half, I presume, is deleting items, like the graph below shows.
Results

Hardware

Notes

Compare with @krausest's results here, that used similar hardware.

Is HyperApp slow? Not at all. It's faster than some, and slower than others, but the difference is what matters, and that difference is minimal.

Is HyperApp heavy? HyperApp shines here. Memory usage after page load and after benchmarks remained consistent, even beats Inferno.

What's the next action? Improve HyperApp's vdom engine. Focus on the first detected weakness: deleting items.

To me the most interesting result is create 1,000 rows where hyperapp is twice as fast as all the others whereas create 10,000 is in the range of others. I think you managed to trick my benchmark runner in this case I'm afraid I wouldn't take that result as granted...

@krausest Did you mean just as a fast?

Update
Removing items is fixed and went from 1.83 down to 1.40, 🎉.
I just need to cut a new release now.

Yep, that was my mistake when adding the frame, it's fixed already. 🙇

Some improvements: https://github.com/hyperapp/hyperapp/pull/124.

Just curious, what led you to implement another view renderer instead of using an existing one? File size?

@nichoth 🤔 I can think of two reasons: one is file size; I am willing to trade some performance for less bytes. If you look at the git history you'll see we went from virtual-dom, to morphodom, then Snabbdom and finally the current custom engine.
After https://github.com/hyperapp/hyperapp/pull/124 lands we'll be 1869 bytes, <=1500 without the Router. So, 1kb is more of a stretch now, but it's still in the same range.
Also, speed will have improved significantly. See the js-framework-benchmarks above 🔥.
The other reason is: I wanted the entire source of truth in a single place.
Whenever I try to understand how some library X works, I'm often disappointed that I have to go through dozens of modules, also with deps themselves, and sometimes not written by the same person, which usually translates to quite different coding styles.

Should we consider using switch statements for perf improvement? They create lookup tables and are optimized for string evaluation especially

@selfup 🤔  If it makes things any faster, then why not, I guess. Won't switch statements take more space than if else?

@jbucaran they have low entropy. With gzip it shouldn't matter.

I think we can close here and continue to track future optimization efforts in #183.
Since 0.8.0, and with the introduction of keys, our patch/diff algorithm became more complex (but also more powerful and useful). Performance is now around 1.34~1.37, which is still fine.

V2's new patch algorithm (based on Superfine) is significantly faster than V1. Here are the benchmark results. To maximize performance, the benchmarked example app makes use of memoization to boost the rendering perf of table rows that are not affected by state changes. This technique will eventually make it into core as described in #721.


gwt-ol3 for GWT 2.7 on Maven?

Hi TDesjardins,
can you deploy on Maven Central also the last version of gwt-ol3 for GWT 2.7? if possible?
Unfortunately, at the moment, I can't use the latest version (for GWT 2.8) because in the environment where I deploying my web-app several components are developed/compiled using GWT 2.7, and this last is shared by all.
Thanks.
Regards,
Francesco

Hello @francescomangiacrapa ,
what about using Jitpack for now?
The latest Tag for GWT 2.7 branch is v1.3.0 :
https://jitpack.io/#TDesjardins/gwt-ol3/v1.3.0
Regards
Tino

Hi @TDesjardins,
thanks for your reply.
I will test Jitpack solution asap in order to use gwt-ol3 v1.3.0
I think it is a great idea.
Regards,
Francesco

O.k. you can reopen this issue if you have problems with that.


Query Param Silently Remove param query value if it is over 1000

Issue
The issue here is that if I have a really long query param(over 1000) ie. test?ids[]=1&ids[]=2..., it will truncate the value after length over 1000. This is because the qs library has a default parameterLimit of 1000 which then it won't parse any more value after. It seems in express body parser, this issue also exists but it returns an error if it is over a limit. https://github.com/expressjs/body-parser#parameterlimit

I know you can override the default query parser with my own, however I think this is very dangerous because the api shouldn't silently return incorrect value without warning. This issue is also coming from 2 layer of library deep so it is not easy to figure out for user of expressjs in my opinion.
Fix

it should either return an error(similar to body parser), because I think this shouldn't silently remove value without alerting the engineer

Alternatively we should set the parameterLimit limit to infinite(in qs options), this way if the user want to change the limit, they can knowingly change it, the users who are not aware of this won't be affected.

I can help with the PR if the above makes sense.

I think the exported query parse middleware should allow an overwrite of req.query
  return function query(req, res, next){
    var val = parseUrl(req).query;
    req.query = queryparse(val, opts);

    next();
  };

instead of
  return function query(req, res, next){
    if (!req.query) {
      var val = parseUrl(req).query;
      req.query = queryparse(val, opts);
    }

    next();
  };

so that the users can do
app.use(express.query({ parameterLimit: 10000 }));

A quick workaround for this is
app.use(function (req, res, next) {
  (req.query = undefined), next();
}, express.query({ parameterLimit: 10000 }));

oh nice fix, that would work for my case, although I guess my main concern is still on that it silently removes query param if someone is not aware what is happening.

Those are very good best practices, I do still think it make sense to error or at least not remove values. A example is if you have a query param that is less than 1000 limit but with a large size, you will get a 414 URI Too Long error in your request, this makes so much sense to me so you can actually debug and figure out what was wrong instead of silently having a data integrity issue.
However I do realized it is a rare case if at all you would want to have such large query parameter in your request, so I am fine with what you have to fix this issue as well!

fwiw I’d be willing to accept an option in qs that throws when exceeding the parameterLimit instead of silently truncating - then express could pass through both options so users can configure them as needed.

If this option was available we would make sure it is passed through and tested on this end.
Also, for OP: I would consider not passing that many query params. There are more efficient ways to pass data to the server and what you describe of passing more than 1000 would for sure be an area you can improve your application by removing.

Filed https://github.com/ljharb/qs/issues/515 in case anyone wants to discuss and implement it.


Styles dont work when use next-routing in dev mode

Bug report
Styles dont work when use next-routing in dev mode
Describe the bug
In the development mode, no styles are going to the components when navigating through links for components.
The style file in .next / statics / style.css does not update, when changing to another url
To Reproduce
use next-routing
use sass with css-modules
Start the server, move to a different page
The creation of the chunk for the page begins, but the styles will not be created for the page
Expected behavior
That when navigating through the URL in the development mode, css will be updated
Screenshots
pic
System information

Version of Next.js: [6.1.1]

+1. This bug is real
I'm using next-less plugin

github.com/zeit/next-plugins. This is unrelated to next.js core.

@timneutkens its core! Webpack config in core work not correctly


Do your ROUGE project support Chinese evaluation?

Do your ROUGE project support Chinese evaluation?

Do your ROUGE project support Chinese evaluation?

Please refer https://github.com/JialeGuo/py_rouge_zh


[Update] - Change Tracer to match new Tracer integration scheme

https://github.com/wandb/wandbot/blob/d44f8de35600b87bd992d2c4930c893a5b8e54a9/src/wandbot/chat/chat.py#LL66C9-L73C10

NVM saw that you can use tracer directly


[Feature] Socket.io

Informations

Type
Version

Improvement
2.x

Description
Add a package on top of Socket.io. Goal: simplify Socket.io integration with Ts.ED.

WebSocket,
Decorators (@SocketCtrl, @Event)

Example
import {WebSocket, Socket, IO, OnConnection, OnDisconnect, Event, Args} from "ts-express-decorators/socketio";

@WebSocket("/chat") // support Namespacing and Injectable to another Service or Controller
class ChatWS implements OnConnection, OnDisconnect {
    constructor() {}

   $onConnection(socket, io)  {

   }

   $onDisconnect(socket, io) {

   }

   @Event("eventName")
   method(@Args() arguments: any[], @Socket socket, @IO io) : void {

   }
}

Acceptance criteria

[ ] WebSocket can use the socket namespace,
[ ] WebSocket instance can be injected to another Service or Controller

I was searching for web socket support in ts-express-decorators, and then found this.
Looking forward to it 👍

Just noticed that this feature was postponed.  Could you please explain what's the best way to integrate Web Socket into Ts.ED?

Hi @CarterLi,
Sorry about that, I didn't have a time to start this feature.
In the meantime, you have an example with Socket.io here https://romakita.github.io/ts-express-decorators/#/tutorials/socket-io
Project example: https://github.com/NodeLabs/techday-node/tree/solution
See you,
Romain

Thanks for your explanation @Romakita

https://github.com/Romakita/ts-express-decorators/tree/feat_socket_io


Fix world in object-factory.md

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Thanks @alizoj


Printing test numbers for describe/it

I am not sure if I have missed a config or so ...
But the current output I get is:
MyFirstDescribeSpec
    ✓ first it() within the describe (735ms)
    ✓ second it() within the describe (321ms)
    ✓ third it() within the describe (287ms)
MySecondDescribeSpec
    ✓ first testcase (735ms)
    ✓ second testcase (321ms)

Is it possible to show which number of the testcase. Something like:
1. MyFirstDescribeSpec
    ✓ 1.1 first it() within the describe (735ms)
    ✓ 1.2 second it() within the describe (321ms)
    ✓ 1.3 third it() within the describe (287ms)
2. MySecondDescribeSpec
    ✓ 2.1 first testcase (735ms)
    ✓ 2.2 second testcase (321ms)

And if there are nested describes, we can just make it 1.1.1 and so on
While I know a progress bar is not feasible because of how karma works. If I know approx that my test suite has 100 describes - this would be very useful for me to know the progress so far.

I would like to be assigned this issue as a part of Hacktoberfest 2022

@devansh7061 that's great! All you need to do is create a feature branch or fork.
Once you've developed the feature, you'll need to write unit tests to make sure the coverage doesn't drop and all of the CI passes. Then we can safely merge it and I can publish a new package to npm.
For Hacktoberfest, you can just make a change to the documentation as well and submit a PR. There's not a requirement for level of work. This can be a decent sized feature and take some time depending on how quick you can get a test environment setup.
Let me know if you need help configuring your test environment.

Cool will get back to you as soon as I'm done implementing this feature
Regards
Devansh
On Tue, Oct 18, 2022, 10:19 PM Tom M @.***> wrote:

@devansh7061 https://github.com/devansh7061 that's great! All you need
to do is create a feature branch or fork.
Once you've developed the feature, you'll need to write unit tests to make
sure the coverage doesn't drop and all of the CI passes. Then we can safely
merge it and I can publish a new package to npm.
For Hacktoberfest, you can just make a change to the documentation as well
and submit a PR. There's not a requirement for level of work. This can be a
decent sized feature and take some time depending on how quick you can get
a test environment setup.
Let me know if you need help configuring your test environment.
—
Reply to this email directly, view it on GitHub
https://github.com/tmcgee123/karma-spec-reporter/issues/97#issuecomment-1282697408,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATZZACBRFB7TN5PKBV5X643WD3IIRANCNFSM53GGON2Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add Feedback link to doc site

Added the Feedback link to the nav bar to collect user feedback.
Hi Jack @jackjia-ibm , wondering if you know a way to add this link to each page, right after the Propose content change in GitHub link?  This link goes to a documentation survey form. Thanks in advance!

Hi Jack @jackjia-ibm , that's a good point! We have many sections on navbar now and with more content coming in the future, we might have the possibility to add more sections. I'll open an issue and see how we can reorganize them. Thanks!

Looks good... nice addition to the docs site :+1:


Remove commitment shifting

https://github.com/MinaProtocol/mina/issues/14628
proof-systems PR: https://github.com/o1-labs/proof-systems/pull/1377

Superseded by https://github.com/o1-labs/o1js-bindings/pull/250


Added syntax highlighting in xml result, removed leading spaces

XML feed highlighting using prismjs added.

Coverage remained the same at 13.251% when pulling 71d7656f8eaeb3cd3fbd15d6552b1eddd5c54c43 on enigmaeth:master into 02d8eee5d3de4ea00d4a9ec7ba42985d362bbbd6 on fossasia:master.

Coverage remained the same at 13.251% when pulling 0c111ca9f0693a68e8f37c3ed84cd4bc54b9e749 on enigmaeth:master into 02d8eee5d3de4ea00d4a9ec7ba42985d362bbbd6 on fossasia:master.

Coverage remained the same at 13.251% when pulling d1fb5673727eb054cdab71fbf0ad9e85b5e9ea4c on enigmaeth:master into 02d8eee5d3de4ea00d4a9ec7ba42985d362bbbd6 on fossasia:master.

Coverage remained the same at 13.251% when pulling c2ec1eb73134b1e11f0ce1d9ab3d05e238583c63 on enigmaeth:master into 02d8eee5d3de4ea00d4a9ec7ba42985d362bbbd6 on fossasia:master.

Coverage remained the same at 13.251% when pulling c2ec1eb73134b1e11f0ce1d9ab3d05e238583c63 on enigmaeth:master into 02d8eee5d3de4ea00d4a9ec7ba42985d362bbbd6 on fossasia:master.

Coverage remained the same at 13.251% when pulling 628c61f970372641049fb57ae85bd2c1a15b7271 on enigmaeth:master into 02d8eee5d3de4ea00d4a9ec7ba42985d362bbbd6 on fossasia:master.

Coverage remained the same at 13.251% when pulling 10f4fc39c825dc32beaf15599fbf05dcf4146f8e on enigmaeth:master into 02d8eee5d3de4ea00d4a9ec7ba42985d362bbbd6 on fossasia:master.

Coverage remained the same at 13.251% when pulling 19b2327cf0066bc6912a56f85fb3418fa7ebe280 on enigmaeth:master into 02d8eee5d3de4ea00d4a9ec7ba42985d362bbbd6 on fossasia:master.


fix doc creation on py2

sphinx.ext.napoleon uses 'objclass', 'im_class' on py2 instead of 'qualname'.

[Current coverage][cc-pull] is 84.00%

Merging [#9][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@           master         #9   diff @@
========================================
  Files          21         21
  Lines        2951       2951
  Methods         0          0
  Branches        0          0
========================================
  Hits         2479       2479
  Misses        472        472
  Partials        0          0

Powered by Codecov. Last updated by [7b069bf...067ddb7][cc-compare]
[cc-base-branch]: https://codecov.io/gh/etingof/pyasn1/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/etingof/pyasn1/compare/7b069bf0267c3ff5520a3e8f8c6919bfb5d558f9...067ddb7755cdf98998259dca98edbc5584cc6cb5
[cc-pull]: https://codecov.io/gh/etingof/pyasn1/pull/9?src=pr


Removed beep(); from examples of usage

gutil.beep() has been removed from gulp-util. So it should be removed from examples of usage in README file too.

https://github.com/gulpjs/gulp-util/blob/d9ac71348542d8c5413fe118ed599f9e7a83aa1a/index.js#L9


Use base realm to serve host app assets

TODO:

[x] setup script to establish sym links in dev env
[x] update deploy to push host dist into the base realm in hosted env
[x] test thru bare origin realm
[x] host realm-server's dom-test container
[ ] update README.md to reflect the different build types and how to start the app and how to run the tests

This PR uses the base realm to host the ember assets (and test assets used for the realm server's DOM test which tests the realm's ability to serve an ember app). The key here is that we actually update the webpack build to add a path prefix to the assets that correlates to where the assets are now  served on the base realm. This is important because not only does the index.html need to be updated, the dynamically loaded chunk.js files that webpack adds logic to request properly need to be loaded from the same place. This results in an index.html that is incompatible with an ember-cli hosted app.
This PR includes the ability to build 2 kinds of apps: an app that can be hosted by ember cli--useful for development, and an app that can be hosted by the realm server where the assets come from the base realm (this can also be used for development too). The normal ember-cli hosted app is run in the same way, via pnpm start in the host package. For the app that uses base realm to serve it's assets, start the an ember build watch using pnpm start:build and then start your realm server(s) (which should include the base realm). Navigate to the realm server in your browser to view the host app for the specific realm server--in this mode the host assets will come from the base realm.
Also, a new capability fell out of this approach, which is actually pretty cool that allows a server to serve both a hosted realm and a local realm from the same server. This capability is enabled via a flag on the server start script --hostLocalRealm. When this flag is enabled, the http://server-name/local becomes available which serves the local realm. We have enabled this flag on the realm server that serves the base realm in development, such that you can visit http://localhost:4201/local to view the local realm. As well as http://localhost:4201/base will show the base realm's app. (might be kinda fun to turn this on in staging)
Additionally, to run the realm server's DOM tests, navigate to http://localhost:4201/base/__tests (on the base realm). This will run the realm servers DOM tests in QUnit.
As part of deployment, we perform 2 types of builds: a build for the ember app hosted by s3/cloudfront and a build for the ember app hosted by the realm server,  so that you can visit either the current staging env (s3/cloudfront hosted app) or you can visit a realm server directly in your browser. We might want to discuss retiring the ember app that is hosted by s3/cloudfront (although we probably still want to use this infra to host the dist.zip that the realm server consumes).
As part of this in dev mode, when you start the base realm server (either individually or via start:all) symlinks are automatically created so that the base realm reflects the current build (as well as any realm server DOM test updates). And in the deploy scripts we deploy the ember build to the base realm as part of the deployment process. This uses the same zip file approach to download the zip from s3/cloudfront, although we no longer use the fastboot zip. The fastboot zip does not respect the ember-cli-build config that we performed for webpack to alter the asset path. As such we build a dist for the realm server hosting, zip it up, and push to s3 in a separate step during the host deploy.
Finally, another change that this introduces is to no longer deploy to the server that hosts only the base realm. We were actually never using this server (we might in the future) so this will speed up deployments by just not deploying to that server (that server is still running, though, if we change our minds in the future).

I'm a little conflicted about hosting the test assets in the base realm. we only ever use this for dev and CI--in staging and prod it would actually require us hosting a test realm in order to work. As part of supporting this we had to add custom logic into the realm and server modules to support the test routes. seems overkill for something that is not used in prod. Id suggest going back to running an http server just for these tests and getting rid of the special test logic in our server and realm modules.

Set the publicAsssetURL at runtime using global variable instead of at build time with env var

it would be better if we didn't need to use a zip for the dist. and instead all assets are served via http

It looks like the runtime global to set the public asset path, __webpack_public_path__ does seem to work.


How i can change the pivot point?

Like the title, when i watched some youtube video on old version you can change the pivot point
But i can't find it anywhere on v1.2.3
Hope someone can help me, thanks.

Hello! Have you tried enabling one of the transformer gizmos (translate, rotate, scale) and double clicking somewhere on the scene?

Hello! Have you tried enabling one of the transformer gizmos (translate, rotate, scale) and double clicking somewhere on the scene?

ah seem like it, but double click are not really accurate but i think i have to deal with it for now


Fix security issue in dependencies

Landed in https://github.com/metarhia/config/commit/15fd8e223704c9c6a8ccdf7f5569783155c098a0


Using customized icon in menu items

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

What happened?
Hello, I need to use customized icon in menu. Using a static path did not resolve the issue. The component sends a GET request to retrieve the icon. I aim to serve the icon from the project's path
https://engage.cloud.microsoft/main/org/siemens.com/threads/eyJfdHlwZSI6IlRocmVhZCIsImlkIjoiMjg5ODUwMjM5MTMwMDA5NiJ9?trk_copy_link=V2
What type of frontend framework are you seeing the problem on?
React
Which version of iX do you use?
v2.4.1
Code to produce this issue.
https://github.com/gdilarainann/ix-menu.git

You placed the image in the source folder it must be part of the asset folder or import it how your bundler required it.
e.g https://vitejs.dev/guide/assets.html
I close this issue because its no issue of the library.


The model has been talking nonsense all along

Hi, Sorry for hear that, SpikeGPT is primarily an experimental product and has not undergone processes like Supervised Fine-Tuning (SFT) and Reinforcement Learning from Human Feedback (RLHF). These processes are essential for ensuring more natural and coherent conversations.


doesn't work :(

I installed the AP on my RPI3b+ , fresh install and up to date with latest Raspbian Stretch Lite, and nothing else is running, after reboot i can't login anymore with SSH, and no WiFi signal at all :(

I forgot to mention anbout the kernel version:
uname -a
Linux 28 4.19.42-v7+ #1219 SMP Tue May 14 21:20:58 BST 2019 armv7l GNU/Linux

Thank you for bringing this to my attention. I will take a look when I have time!

good luck !!


fix(guide):add warning about dividing with zero to article.

text : "When dividing always check that the divisor ( in this example "b" ) is not equal to 0 ,dividing with 0 will cause your program to crash."

Description

Pre-Submission Checklist
Common mandatory requirements

[x] This pull request targets the master branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/
(e.g. fix/signin-issue)
[x] Reviewed necessary guidelines in CONTRIBUTING.md.

By submitting this pull request, I have verified the following:

[x] Added descriptive name to pull request. (mandatory)
Your PR should NOT be called Update index.md, since it does not help the maintainer understand what has been changed.
Good Guide PR title examples:
fix(guide): Git - edit Git Commit article
feat(guide): PHP - create PHP section and add Data Structures article

Good Coding challenge PR title examples:
fix(coding): add tests to Basic HTML challenge
fix(coding): update instructions to CSS Grid challenge

Good Learning platform PR title examples:
fix(platform): fixed sign in api
fix(platform): removed css from editor

Issues Closures

[ ] Addressed currently open issue. (replace XXXXX with an issue no in next line)

Closes #XXXXX
Since this change is a copy edit or translation for Guide articles or Coding Challenges:

[x] I confirm no plagiarized, duplicate, or repetitive content that has been directly copied from another source.
[x] I am adding only https links to external sources.
[x] I am not adding short links instead of full URLs to webpages.
[x] I have followed the recomended style guides for the copy edit.

Requirements, for changes which are NOT simple copy editing or translations:
You may skip the below ONLY if your changes do not touch tests, ui logic, api-server, etc. Your PR may not be accepted, if you did not meet these mandatory requirements. Simply put, we can't assume it will work if we never saw it working.
Since this change adds, updates or removes coding challenge tests:

[ ] I completed the coding challenge locally, and the changes look good.
[ ] Other tests or user stories in instructions are not affected.

Since this change is for the Learning platform (UI, logic, etc.):

[ ] I confirm my changes look good by running freeCodeCamp locally.
[ ] All new and existing tests pass the command npm test.

(Optional) Additional Context and Screenshots:

@ThomasPapapaschos Awesome! Thanks! Congrats on your first open source contribution to this repository!


[FEA] Masking for MultiMessage Type

This would allow for several non-adjacent rows to be included in a single MultiMessage instance.
Currently MultiMessage only supports an offset+count, so in the worst case scenario of filtering (#83) a single message containing 1024 rows coming into the filter stage could result in up to 512 messages being emitted.
Masking would allow for only a single message to be emitted.

I started looking into this a bit, just wanted to jot down my thoughts before I move on to something else.
The MultiResponseProbsMessage messages contain both the original dataframe (meta) along with a cupy probabilities array (probs).
For the filter stage we use the probs array to determine which rows in the dataframe to include in the output.
I think the idea here was to use numpy's Masked arrays for this (https://numpy.org/doc/stable/reference/maskedarray.html). However cupy doesn't appear to support this https://github.com/cupy/cupy/issues/2225.
We could instead maintain a third mask array which would simply be the detections array:
detections = (x.probs > self._threshold).any(axis=1)
Alternately we could look into using cudf's mask or query methods

I see now, this is what we want to do:
detections = (x.probs > self._threshold).any(axis=1)
x.meta.loc[detections, :]

@jarmak-nv done


feat: strip prefix regex

resolve: #133
Hi I have implemented a feature to strip a regex pattern from the commit message before parsing the the message.
Currently this works via config file, however, I would like to have it as flag as well, but didnt manage to get it working as excepted. When defining the flags as clap options they would not be used for some reason. Perhaps the default value from the config would overwrite them.
As I am not familar with rust, I copied what I saw for other options. So please review careful and let me know if there is any issue.

It looks good. I still have to check out and test. After 1 week I should find more time to add the cli and merge this PR

Let's add the command line flag in another pr and merge this already


Implement DECIMAL type

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-10818
The TPC-H benchmarks correctly specify that all MONEY columns are DECIMAL type (precision and scale are not specified). We currently use DataType::Float64 which is much lighter than a true Decimal type.
To be a valid benchmark we need to ensure we support the same precision as the reference implementation.

@alamb any idea about how to start this?

Hi @j-a-m-l, I see arrow-rs has supported Decimal, maybe we can directly change here https://github.com/apache/arrow-datafusion/blob/22a7d74e9dece44adb790b5ea3fca27d26a2fe51/datafusion/src/sql/planner.rs#L312  cc @alamb

@j-a-m-l  I think a @xudong963  has a good point that Arrow already includes some support for DecimalArrays.
A  good place to start then be to write some tests in sql.rs that create a TableProvider with a column of DecimalArray type and try to run some basic sql
The typical order I would try is something like
// projection
SELECT col + 4 ... FROM table_with_decimal_col

// filter
SELECT col  FROM table_with_decimal_col where col < 5

// sort
SELECT col  FROM table_with_decimal_col order by col

// grouping / aggregatie
SELECT sum(col)  FROM table_with_decimal_col;
SELECT count(other_col)  FROM table_with_decimal_col group by col

Writing those tests is probably a good way to figure out how to plumb through the support in DataFusion -- I would also recommend doing it in that order (projection, filter, sort, grouping / aggregation)

Thanks @xudong963 and @alamb

Is there any plan for implementation Decimal Type for datafusion?
@alamb

Hi @j-a-m-l, do you have time to work on this?

Is there any plan for implementation Decimal Type for datafusion? @alamb

I want to take some tasks to support the decimal data type in the datafusion.

Is there any plan for implementation Decimal Type for datafusion?

I don't know of any plans other than what is on this ticket. As I mentioned in https://github.com/apache/arrow-datafusion/issues/122#issuecomment-956212828 I think figuring out what subtasks are needed (by writing some tests and trying out what works / doesn't work) is a good first step

No, @xudong963. Currently I don't have enough time to do that, and I'll probably focus first on fixing other issues that I've found, such as https://github.com/apache/arrow-datafusion/issues/1173.

Here are several other issues that seem to be related to DECIMAL:

https://github.com/apache/arrow-datafusion/issues/174
https://github.com/apache/arrow-datafusion/issues/210
https://github.com/apache/arrow-datafusion/issues/1233

Thanks for the feedback.
I will begin to support DECIMAL datatype.
Please assign this issue to me @alamb

[ ] create external csv table with decimal data type in SQL parse and logical plan.
[ ] select column with decimal datatype
[ ] support function(example min,max,count,sum)
[ ] support expr evaluation (using in select, filter and other clause)
[ ] support cast

In order to implement decimal in datafusion, we should ref some data type rules, like spark data type and type coercion.
Now, the numerical data type just support some native type and the type coercion rules are simple. if we add the decimal data type, the type checking, type cast, type promotion and precision checking are all need to be considered.

https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_plan/expressions/coercion.rs
and
https://github.com/apache/arrow-datafusion/blob/4687899957463ce81c4795a6d35d31320db0252b/datafusion/src/physical_plan/type_coercion.rs
are the two places I know of in DataFusion today that do this type coercion
On Mon, Nov 22, 2021 at 9:33 PM Kun Liu @.***> wrote:

In order to implement decimal in datafusion, we should ref some data type
rules, like spark data type
https://spark.apache.org/docs/3.2.0/sql-ref-datatypes.html and type
coercion
https://spark.apache.org/docs/3.2.0/sql-ref-ansi-compliance.html#type-promotion-and-precedence
.
Now, the numerical data type just support some native type and the type
coercion rules are simple. if we add the decimal data type, the type
checking, type cast, type promotion and precision checking are all need to
be considered.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/arrow-datafusion/issues/122#issuecomment-976109767,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADXZMNH25DW2NQZKCQ75BDUNL4OBANCNFSM43S4FY3Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I know of in DataFusion today that do this type coercion

yep, Now I just try to support some simple demo code for decimal. For example function(min,max) and just Projection the column with decimal data type (without any operation and functions)
The rule of conversion in the above two files should be refactored, If we want to align the behavior with PG database exactly.
In the PG database, decimal and other numerical data type can be convert to each other, and in some case the varchar also can be convert to a decimal data type. The rules may be complexed

In my opinion, we can support some simple and right rules first, and support other complex features later

I think this is a great idea -- taking stock / consolidating the existing coercion logic might be a good place to start (before you try to extend it to support Decimal)


AWS/EKS: Support for IAM authentication

I am trying to connect a postgres_exporter instance running on AWS EKS (managed Kubernetes platform) to a managed AWS/RDS instance using IAM authentication methods as described here: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.IAMDBAuth.Connecting.AWSCLI.PostgreSQL.html
My attempt to use an initContainer to obtain the access token (which is valid for a limited period of time only) works just fine:
      initContainers:
      - args:
        - -c
        - "echo \"Generating RDS authentication token\" && /usr/bin/aws rds generate-db-auth-token --hostname $(RDS_HOST) --port $(RDS_PORT) --username $(POSTGRES_USER) --region $(AWS_DEFAULT_REGION) > /etc/postgresql-exporter/aws-rds/connection && cat /etc/postgresql-exporter/aws-rds/connection"
        command:
        - /bin/sh
        envFrom:
        - configMapRef:
            name: map_that_holds_my_environment_variables
        # This image contains only the AWS CLI and since Amazon hasn't officially released a
        # container image (yet), I had to roll my own... :-(
        image:<PHONE_NUMBER>123.dkr.ecr.eu-central-1.amazonaws.com/library/awscli:v1.16.247
        imagePullPolicy: IfNotPresent
        name: generate-db-auth-token
        resources:
          limits:
            cpu: 100m
            memory: 120Mi
          requests:
            cpu: 100m
            memory: 100Mi
        securityContext:
          allowPrivilegeEscalation: false
          capabilities:
            drop:
            - ALL
        volumeMounts:
        - mountPath: /etc/postgresql-exporter/aws-rds
          name: config
          readOnly: false

As you might see, the initContainer writes an RDS connection string into a file which I put onto a shared volume (tmpDir) that is accessible from the main container (postgres-exporter). Now comes the tricky part: This connection string contains the full postgresql connection string.
Example (credentials obfuscated):
my-rds-instance-name.abcdef1x2y3z.eu-central-1.rds.amazonaws.com:5432/?Action=connect&DBUser=prometheus_exporter&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Expires=900&X-Amz-Date=20191104T190218Z&X-Amz-SignedHeaders=host&X-Amz-Security-Token=SfxcvIvYXdzEEQaDGuApMrWVOItKG756iKMA4if966d5Th%2BB9IXSv6ZDGI2DXcxkO9YP1jp8oY189vtQuh1dsG7h45Uv3waOWx76gKXp%2F8D2OT2WaD8iL0P9g36VkXVD1J6RNfsdKwshSw%2B5qOuODo%2F1B%2B6ZKrQ%2BHv5oIHODixnZH8jD9NgyjVPHcqB4PTVYTaelOJtL1tQ484g5d3vT8iGvdEpaRLdLzW3IM2wPuWyvuw9R7eqwbolUHrgEIpWphsRUmIhT3tV%2BIxwjm76y093zQQViDauAEjsGQjUyw4brYN%2B7uuADcfT%2BLlQtczTZUFoobfhw%2F2zN3BqJVozuMOLYCJU9v5zkegZY8ikp%2FwWyVM0cmHF%2BsS4p54OYRGfG8NxObgOjFIxdcVvV%2FiQf%2Ff3F3fYn2WZyod3ERqHQlOvqnO6QYG0TS0kGpTHD6IknlCksVDxf%2F3akpA8O70HIq4XR4qj0jJLoAQZoMGbjDeOzm3QoGo%2FWLysVQBA1K0%2BArcnVpIQZfg6e2LtsBuyG%2BasiIqX52PW2aZ915GNldEJC8cJEKo3hSi664HuBTLyAVzWy%2B36zzWfFTx%2FKZqmPljoIdf5pIyGPhr9HN5Srv2qEBB6939Eueb1F7t2HLCQPlhZF8TrdEnAeW8qM3JihgICQldUxcpjxBFsDxhTgMe%2Fdvftl%2BCL7W74N2%2FLNofVEwDrVTwAa4XZw9TUNkrTxPVKXJl%2B7vwqPvGjfmCljANUgNW9JPg2ctAn0O7T%2F2ZoJdnFessUJ17%2F73bgQVaFJyQNq9n87J8pILqf1YUlU%2FS7eePOcVEO0Rn%2FTQyKQhcatTwAoebPgHEC04%2FbEw3PQFNtdd5C5J2y29FQEN9Pe%2BOKNCNaQAtMgq9Jlul2ljkr98tC&X-Amz-Credential=ADIAWZGGSLFRQZT43XHR%2F20191104%2Feu-central-1%2Frds-db%2Faws4_request&X-Amz-Signature=8df675ac12530eb757bffb3818681d0ff361b4e79226c0a31aac546b92e1080a

Unfortunately, it is not possible, to use that string when using the official Docker image of the postgres_exporter, because there is no way to construct the DATA_SOURCE_URI environment variable from a file like that. Overriding the container's entrypoint would be an option:
  command:
  - sh
  args:
  -c
  - "DATA_SOURCE_URI=\"postgresql://$(cat /etc/postgresql-exporter/aws-rds)\" /postgres_exporter"

But right now it is not an option, since the container does not contain a shell (which is actually a good thing when considering best container security practices, I assume).
... any help/ideas appreciated.
PS:
After having thought about it for quite some time, I suppose, a DATA_SOURCE_URI_FILE environment variable might solve all my issues. Would that make for an acceptable PR?

@headcr4sh Your PR is great but i'm wondering how you are triggering a token update every 15 minutes since the password expires every 15?

@robbiet480 Unfortunately, I was not able to solve any further issues with the postgres_exporter in conjunction with EKS and IAM-based ServiceAccounts.
So... I was not able to trigger the token update. :-(
(Using the posgres_exporter was just a proof-of-concept and I did not proceed any further, unfortunately,...)


Toggle breakpoints should respect multiple cursors

Issue Type: Bug
If I set the cursor on multiple lines (Highlight "throw" ,  press Ctrl + D, with the Sublime Keystrokes selected, this has the effect of highlighting the matching text on multiple lines)  the set a Breakpoint (F9) I only get a single Breakpoint set. My expectation is that at each highlighted line the Breakpoint is set.
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:55:08.091Z)
OS version: Linux x64 5.1.18-200.fc29.x86_64
Extensions (2)

Extension
Author (truncated)
Version

csharp
ms-
1.21.0

sqltools
mtx
0.19.6

This is a fair feature request and it makes sense to me. Assigning it to on-deck - so I will look into it once I find time.
Also adding help wanted. Myabe somebody is interested in providing a PR to tackle this.
Code pointer https://github.com/Microsoft/vscode/blob/cf03ea3729dc37e439d724267ad29dc5840f903a/src/vs/workbench/contrib/debug/browser/debugEditorActions.ts#L38

I took a stab at this. First time looking at the vscode source and I have a couple questions. Work is here mayaswrath/vscode@4c2a3af2c8026002388910dc208ea284e05fddbc. I used editor._getCursors() to get the positions of the cursors. This function is commented as internal, so I am not sure if I should be using it. I am used to the _ prefix notation as being internal to a class. I see no other way to get the position of all the cursors, so if this is not allowed, seems like a bigger task.
I assumed a test should go with this but there are no existing test for the debug editor actions. I didnt really see any tests for any editor actions (just the Line Operations test, but those only require an editor so are self contained). I see no easy way to create a DebugService, most of its dependencies don't have a mock. Seems like a smoke test would be pretty easy but I wasnt sure if that is the correct place for something like this. The smoke tests seemed pretty lean. What kind of tests are expected for a PR on something like this.
Also I have never done a public PR before, I assumed that should be done once its complete, hence why I linked to my fork. Is that proper procedure, or should I have just made a PR.

@mayaswrath feel free to create a PR with your provisional work and we can continue the discussion there. Thanks

Fixed via #79065


Add custom build script to ignore standalone admin

Description
Add custom build script to ignore standalone admin
Issues Resolved

Closes https://github.com/opensearch-project/security/issues/1809

Testing
Built locally with a custom manifest for 1.3.2 pointing to this change
% ./build.sh manifests/1.3.2/opensearch-1.3.2.yml --component security
Installing dependencies in . ...
Installing dependencies from Pipfile.lock (d422cd)...
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 5/5 — 00:00:00
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
Running ./src/run_build.py manifests/1.3.2/opensearch-1.3.2.yml --component security ...
2022-04-29 20:05:46 INFO     Building in /tmp/tmpsgjiquwj
2022-04-29 20:05:46 INFO     Building OpenSearch (x64) into /local/home/petern/git/opensearch-build/tar/builds/opensearch
2022-04-29 20:05:46 INFO     Skipping OpenSearch
2022-04-29 20:05:46 INFO     Skipping common-utils
2022-04-29 20:05:46 INFO     Skipping job-scheduler
2022-04-29 20:05:46 INFO     Skipping ml-commons
2022-04-29 20:05:46 INFO     Skipping alerting
2022-04-29 20:05:46 INFO     Skipping asynchronous-search
2022-04-29 20:05:46 INFO     Skipping index-management
2022-04-29 20:05:46 INFO     Building security
2022-04-29 20:05:46 INFO     Executing "git init" in /tmp/tmpsgjiquwj/security
2022-04-29 20:05:46 INFO     Executing "git remote add origin https://github.com/peternied/security.git" in /tmp/tmpsgjiquwj/security
2022-04-29 20:05:46 INFO     Executing "git fetch --depth 1 origin build-break-1.3.2" in /tmp/tmpsgjiquwj/security
2022-04-29 20:05:47 INFO     Executing "git checkout FETCH_HEAD" in /tmp/tmpsgjiquwj/security
2022-04-29 20:05:47 INFO     Executing "git rev-parse HEAD" in /tmp/tmpsgjiquwj/security
2022-04-29 20:05:47 INFO     Checked out<EMAIL_ADDRESS>into /tmp/tmpsgjiquwj/security at 4d17d1ceddd714e017333e2463cdf8b44c0196eb
2022-04-29 20:05:47 INFO     Executing "bash /tmp/tmpsgjiquwj/security/build.sh -v 1.3.2 -p linux -a x64 -s false -o builds" in /tmp/tmpsgjiquwj/security
+ getopts :h:v:q:s:o:p:a: arg
+ case $arg in
+ VERSION=1.3.2
+ getopts :h:v:q:s:o:p:a: arg
+ case $arg in
+ PLATFORM=linux
+ getopts :h:v:q:s:o:p:a: arg
+ case $arg in
+ ARCHITECTURE=x64
+ getopts :h:v:q:s:o:p:a: arg
+ case $arg in
+ SNAPSHOT=false
+ getopts :h:v:q:s:o:p:a: arg
+ case $arg in
+ OUTPUT=builds
+ getopts :h:v:q:s:o:p:a: arg
+ '[' -z 1.3.2 ']'
+ [[ ! -z '' ]]
+ [[ false == \t\r\u\e ]]
+ '[' -z builds ']'
+ mkdir -p builds
+ ./gradlew assemble --no-daemon --refresh-dependencies -DskipTests=true -Dopensearch.version=1.3.2 -Dbuild.snapshot=false -Dbuild.version_qualifier=
To honour the JVM settings for this build a single-use Daemon process will be forked. See https://docs.gradle.org/7.3/userguide/gradle_daemon.html#sec:disabling_the_daemon.
Daemon will be stopped at the end of the build

> Task :compileJava
/tmp/tmpsgjiquwj/security/src/main/java/org/opensearch/security/ssl/transport/SecuritySSLRequestHandler.java:178: warning: non-varargs call of varargs method with inexact argument type for last parameter;
            Method getInnerChannel = wrappedChannelCls.getMethod("getInnerChannel", null);
                                                                                ^
  cast to Class for a varargs call
  cast to Class[] for a non-varargs call and to suppress this warning
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 27s
8 actionable tasks: 8 executed
++ find . -path '*build/distributions/*.zip' -not -name '*standalone.zip'
+ zipPath=./build/distributions/opensearch-security-<IP_ADDRESS>.zip
+ echo 'FIXING BUILD BREAK 1.3.2'
FIXING BUILD BREAK 1.3.2
+ echo 'COPY ./build/distributions/opensearch-security-<IP_ADDRESS>.zip/*.zip'
COPY ./build/distributions/opensearch-security-<IP_ADDRESS>.zip/*.zip
+ mkdir -p builds/plugins
+ cp ./build/distributions/opensearch-security-<IP_ADDRESS>.zip ./builds/plugins
2022-04-29 20:06:15 INFO     Recording plugins artifact for security: plugins/opensearch-security-<IP_ADDRESS>.zip (from /tmp/tmpsgjiquwj/security/builds/plugins/opensearch-security-<IP_ADDRESS>.zip)
2022-04-29 20:06:15 INFO     Checked /tmp/tmpsgjiquwj/security/builds/plugins/opensearch-security-<IP_ADDRESS>.zip (<IP_ADDRESS>)
2022-04-29 20:06:15 INFO     Skipping performance-analyzer
2022-04-29 20:06:15 INFO     Skipping cross-cluster-replication
2022-04-29 20:06:15 INFO     Skipping dashboards-reports
2022-04-29 20:06:15 INFO     Skipping opensearch-observability
2022-04-29 20:06:15 INFO     Created build manifest /local/home/petern/git/opensearch-build/tar/builds/opensearch/manifest.yml
2022-04-29 20:06:15 INFO     Done.

Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Why is a custom script needed?

@peterzhuamazon this change is on the 1.3 branch.  We need the custom build script to ignore the standalone-admin zip that was created.

The error provided in the issue points to this line. Looke like the artifact name opensearch-security-<IP_ADDRESS>-securityadmin-standalone.zip doesn't match the required format -{version}.zip. Can we fix the version of security-standalone zip file instead of ignoring it.
  File "/var/jenkins/workspace/distribution-build-opensearch/src/build_workflow/opensearch/build_artifact_check_plugin.py", line 20, in check
    raise BuildArtifactCheck.BuildArtifactInvalidError(path, f"Expected filename to include one of {self.target.compatible_component_versions}.")
build_workflow.build_artifact_check.BuildArtifactInvalidError: Artifact opensearch-security-<IP_ADDRESS>-securityadmin-standalone.zip is invalid. Expected filename to include one of ['<IP_ADDRESS>'].

https://github.com/opensearch-project/security/issues/1809#issuecomment-1113683708

@peterzhuamazon this change is on the 1.3 branch. We need the custom build script to ignore the standalone-admin zip that was created during the build. The standalone-admin is not present in 2.0.0+ builds.

2.0.0 does not have this zip. 1.3.2 still has this zip.
I dont think the change is in 1.3 if that is the case.
If we have the change in both branch then 1.3.2 should not have the zip.

I dont think the change is in 1.3 if that is the case.

This pull request isn't targeting main, its pointed to the 1.3 branch.  We don't want to maintain a custom build script in security as 2.0+ does not require it.

Can we fix the version of security-standalone zip file instead of ignoring it?
The standalone tools have never been included in the distribution release, and are removed from the build system entirely in 2.0+ releases.

Let's go with the backport since it's the quickest fix for this. @peternied @peterzhuamazon

Let's go with the backport since it's the quickest fix for this. @peternied @peterzhuamazon

While I would like to backport that change its a breaking change from 1.3.1 -> 1.3.2. This pull request keeps the original build process that was used in the 1.3.1 release.

I dont think the change is in 1.3 if that is the case.

This pull request isn't targeting main, its pointed to the 1.3 branch. We don't want to maintain a custom build script in security as 2.0+ does not require it.

That makes sense. Let's merge this one then.

Thanks for the input everyone - getting extra eyes when managing changes between multiple branches/codebases is super useful.

Codecov Report

Merging #1811 (4d17d1c) into 1.3 (598acdc) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3    #1811      +/-   ##
============================================
+ Coverage     64.66%   64.67%   +0.01%
- Complexity     3220     3221       +1
============================================
  Files           247      247
  Lines         17363    17363
  Branches       3086     3086
============================================
+ Hits          11228    11230       +2
- Misses         4586     4587       +1
+ Partials       1549     1546       -3

Impacted Files
Coverage Δ

...ecurity/configuration/StaticResourceException.java
0.00% <0.00%> (-25.00%)
:arrow_down:

...nsearch/security/dlic/rest/api/AuditApiAction.java
63.82% <0.00%> (-4.26%)
:arrow_down:

...earch/security/ssl/util/SSLConnectionTestUtil.java
95.45% <0.00%> (+2.27%)
:arrow_up:

...urity/ssl/transport/SecuritySSLNettyTransport.java
73.40% <0.00%> (+4.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598acdc...4d17d1c. Read the comment docs.


Can make a cat big?

too small..

@TianaJ3
I too would like to display the cat on a larger scale. But I'm not very familiar with Windows App.
I know that it may be done by using CSDeskBand, but I don't know if it works on the latest Windows OS.

@Kyome22 can this feature is possible to apply in future?

@cuten222
I have no plan at this time. I have tried twice before but have given up because of the difficulty.