napari bundled app does not work - napari-0.4.17-Windows-x86_64.zip

🐛 Bug & To Reproduce
Hi,
I've downloaded and installed the windows bundled app and I get the following error:
C:\Users\oren>C:\Users\oren\AppData\Local\Programs\napari\python\python.exe -m napari
Traceback (most recent call last):
  File "runpy.py", line 194, in _run_module_as_main
  File "runpy.py", line 87, in _run_code
  File "C:\Users\oren\AppData\Local\Programs\napari\\app\napari\__main__.py", line 565, in <module>
    sys.exit(main())
  File "C:\Users\oren\AppData\Local\Programs\napari\\app\napari\__main__.py", line 561, in main
    _run()
  File "C:\Users\oren\AppData\Local\Programs\napari\\app\napari\__main__.py", line 327, in _run
    viewer = Viewer()
  File "C:\Users\oren\AppData\Local\Programs\napari\\app\napari\viewer.py", line 65, in __init__
    _initialize_plugins()
  File "C:\Users\oren\AppData\Local\Programs\napari\\app\napari\plugins\__init__.py", line 46, in _initialize_plugins
    mf = PluginManifest.from_distribution('napari')
  File "C:\Users\oren\AppData\Local\Programs\napari\\app_packages\npe2\manifest\schema.py", line 228, in from_distribution
    raise ValueError(
ValueError: Distribution {name!r} exists but does not provide a napari manifest

C:\Users\oren>

Environment
Windows 10 & also in windows server 2012
I'm installing with pip now, and it is working, but the bundled app not working

Thanks @psobolewskiPhD! with the .exe it does start, but when I click

I get this:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
File ~\AppData\Local\napari-0.4.17\envs\napari-0.4.17\lib\site-packages\napari\_qt\qt_viewer.py:735, in QtViewer._open_files_dialog(self=<napari._qt.qt_viewer.QtViewer(0x262c1da1f40)>, choose_plugin=False)
    732 hist = get_open_history()
    733 dlg.setHistory(hist)
--> 735 filenames, _ = dlg.getOpenFileNames(
        dlg = <PySide2.QtWidgets.QFileDialog(0x262d91282d0) at 0x00000262D7C2C440>
        self = <napari._qt.qt_viewer.QtViewer(0x262c1da1f40) at 0x00000262C43A05C0>
        trans = <napari.utils.translations.TranslationBundle object at 0x00000262BCD3FD30>
        hist = ['C:\\Users\\oren']
        hist[0] = 'C:\\Users\\oren'
        QFileDialog = <class 'PySide2.QtWidgets.QFileDialog'>
        QFileDialog.DontUseNativeDialog = PySide2.QtWidgets.QFileDialog.Option.DontUseNativeDialog
    736     parent=self,
    737     caption=trans._('Select file(s)...'),
    738     directory=hist[0],
    739     options=(
    740         QFileDialog.DontUseNativeDialog
    741         if in_ipython()
    742         else QFileDialog.Options()
    743     ),
    744 )
    746 if (filenames != []) and (filenames is not None):
    747     for filename in filenames:

AttributeError: PySide2.QtWidgets.QFileDialog.getOpenFileNames(): unsupported keyword 'directory'

Eep, another bug! Sorry about this.
I can reproduce this without the bundle on my mac with pyside2.
I will make a new issue for this.
AttributeError                            Traceback (most recent call last)
File ~/Dev/miniforge3/envs/nap-test/lib/python3.10/site-packages/napari/_qt/qt_viewer.py:735, in QtViewer._open_files_dialog(self=<napari._qt.qt_viewer.QtViewer(0x6000008e1810)>, choose_plugin=False)
    732 hist = get_open_history()
    733 dlg.setHistory(hist)
--> 735 filenames, _ = dlg.getOpenFileNames(
        dlg = <PySide2.QtWidgets.QFileDialog(0x600000851180) at 0x16bb672c0>
        self = <napari._qt.qt_viewer.QtViewer(0x6000008e1810) at 0x16fcf2140>
        trans = <napari.utils.translations.TranslationBundle object at 0x14f201930>
        hist = ['/Users/piotrsobolewski']
        hist[0] = '/Users/piotrsobolewski'
        QFileDialog = <class 'PySide2.QtWidgets.QFileDialog'>
        QFileDialog.DontUseNativeDialog = PySide2.QtWidgets.QFileDialog.Option.DontUseNativeDialog
    736     parent=self,
    737     caption=trans._('Select file(s)...'),
    738     directory=hist[0],
    739     options=(
    740         QFileDialog.DontUseNativeDialog
    741         if in_ipython()
    742         else QFileDialog.Options()
    743     ),
    744 )
    746 if (filenames != []) and (filenames is not None):
    747     for filename in filenames:

AttributeError: PySide2.QtWidgets.QFileDialog.getOpenFileNames(): unsupported keyword 'directory'

Looks like the bug being fixed here https://github.com/napari/napari/pull/5492/files for pyside6 also affects pyside2.

Looks like the bug being fixed here #5492 (files) for pyside6 also affects pyside2.

I was sure that I had tested it, and because of this, I select only PySide6. I need to revalidate it.
@orena1 At this moment, I can only suggest opening files using the drag-and-drop mechanism. We will work to fix this asap.

Thanks @Czaki I installed it with pip and it is working, just wanted to let you know about the probelm.

@sheldonsebastian
The issue has been fixed, but the fix isn't released yet, so it won't be in the official releases bundles until we make a new napari release.
However, we do have experimental Nightly builds of the bundle app (which will have the fix):
https://github.com/napari/napari/releases/tag/latest
You want to look at the .sh, the .pkg and the .exe which all use the conda backend.

The mac one also doesn't run. Here's the traceback I get:
Traceback (most recent call last):
  File "napari.app/Contents/Resources/app/napari/__main__.py", line 565, in <module>
    sys.exit(main())
  File "napari.app/Contents/Resources/app/napari/__main__.py", line 561, in main
    _run()
  File "napari.app/Contents/Resources/app/napari/__main__.py", line 218, in _run
    from napari import Viewer, run
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "<frozen importlib._bootstrap>", line 1055, in _handle_fromlist
  File "napari.app/Contents/Resources/app/napari/_lazy.py", line 48, in __getattr__
    submod = import_module(
  File "napari.app/Contents/Resources/Support/Python/Resources/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "napari.app/Contents/Resources/app/napari/viewer.py", line 8, in <module>
    from .components.viewer_model import ViewerModel
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app/napari/components/__init__.py", line 19, in <module>
    from .layerlist import LayerList
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app/napari/components/layerlist.py", line 9, in <module>
    from ..layers import Layer
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app/napari/layers/__init__.py", line 11, in <module>
    from .base import Layer
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app/napari/layers/base/__init__.py", line 1, in <module>
    from .base import Layer, no_op
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app/napari/layers/base/base.py", line 14, in <module>
    from npe2 import plugin_manager as pm
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app_packages/npe2/__init__.py", line 8, in <module>
    from ._dynamic_plugin import DynamicPlugin
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app_packages/npe2/_dynamic_plugin.py", line 19, in <module>
    from ._plugin_manager import PluginManager
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app_packages/npe2/_plugin_manager.py", line 30, in <module>
    from ._command_registry import CommandRegistry
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app_packages/npe2/_command_registry.py", line 10, in <module>
    from .manifest import utils
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app_packages/npe2/manifest/__init__.py", line 2, in <module>
    from .schema import ENTRY_POINT, PluginManifest
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app_packages/npe2/manifest/schema.py", line 18, in <module>
    from .contributions import ContributionPoints
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app_packages/npe2/manifest/contributions/__init__.py", line 2, in <module>
    from ._configuration import ConfigurationContribution, ConfigurationProperty
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app_packages/npe2/manifest/contributions/_configuration.py", line 5, in <module>
    from ._json_schema import (
  File "napari.app/Contents/Resources/app_packages/shiboken2/files.dir/shibokensupport/__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "napari.app/Contents/Resources/app_packages/npe2/manifest/contributions/_json_schema.py", line 84, in <module>
    class _JsonSchemaBase(BaseModel):
  File "pydantic/main.py", line 179, in pydantic.main.ModelMetaclass.__new__
  File "pydantic/typing.py", line 395, in pydantic.typing.resolve_annotations
TypeError: __init__() got an unexpected keyword argument 'is_class'


Live review table doesn't respect pagination

Not sure how to make this one work, but right now the socket just fills up the table infinitely. Ideally after the pagination length the results would be dropped from the screen.
Also if you are on a page > 1 and a new request comes in you get taken back to page 1, which shows all results, I think.

@dcalvom if this one is too hard to handle elloquentyl (I can see a lot of problems of having to manage both pagination and live loading) maybe we have a toggle that enables/disables the live loading. If it is enabled there is no pagination, if disabled there is? Just a thought.

Closed by https://github.com/samtecspg/articulate/commit/58a7f589ee60127bb0673174fdeabe0633bec056


Incomplete Submission

Here is my submission. It is mostly the sample code from the jsfiddle site. Spent time reading svg and javascript.
video.zip

If you want, keep going with the project and I will review It once its done


Organize issues into Projects and more labels

Currently everything is mixed in, but it would be beneficial to have them structured. For example, I am more interested in the decompiler part of the Ghidra, so having a Decompiler project at https://github.com/NationalSecurityAgency/ghidra/projects with "TODO, In progress, Done" columns would be a top notch. It also makes sense to use the labels for a more fine grained structuring inside the projects.

More labels would be helpful

I agree, I'll work on this.  The default GitHub set is a decent start but our pull-requests and issues have grown large and need better organization.

I've begun the process, so I am going to close this out.  It will develop and improve over time.

@ryanmkurtz is it possible to allow the author of an issue/pull-request to add labels?

What do you see under the labels drop-down when you create a new issue?

What do you see under the labels drop-down when you create a new issue?

There is no labels drop-down.

Hmmm, did there used to be before I added all of these new labels?

Hmmm, did there used to be before I added all of these new labels?

No, there were never any labels available.
You can choose from issue templates. The screens available are as follows:

@ryanmkurtz so according to the information here only those with write-access can apply labels. While a bit invasive I wonder if it is possible to have a bot of some sort or another way to have labels added automatically if the title contains a magic string. Maybe something like [Bug] would cause the bug label to be applied and the tag would be automatically stripped from the title.


Pytorch XLA/PJRT TPU support

Feature request
Pytorch XLA/PJRT TPU support for bitsandbytes
Motivation
Would allow for faster and more memory efficient training of models on TPUs.
Your contribution
Happy to provide TPUs.

+1
please!


Restore {@inheritDoc} behavior

{@inheritDoc} now takes the summary and description from the interface that
was implemented.
This parially fixes #1505. I think {@inheritDoc} now works as before. But not fully as requested in #1505

@mvriel I don't know if this was the original functionality of this tag. But I think is was like this?

The 'original' functionality of this tag was that it could only be used in a description (not in the summary) since summaries don't support the inline tag functionality (marked with the braces).
What it did then was import the parent description into the location of the {@inheritDoc} tag so that you could combine the two descriptions into one.
When you omit the summary and description then these are automatically inherited from the parent element (default inheritance behaviour).
Symfony and Doctrine later introduced a usage of {@inheritDoc} that it would mean 'inherit all information from the parent element' when used on its own in a DocBlock.
So:
/**
 * {@inheritDoc}
 */

is equal to omitting the DocBlock as far as phpDocumentor is concerned.
phpDocumentor adopted this behaviour to be compatible with the expectations from Doctrine and Symfony users but only under the condition that is was the only tag in a DocBlock.

I modified this fix. So it works as expected. Somehow the original functionality was broken for interfaces.


GitHub Docs Out-of-Date

The links to the documentation for this project are not working.

Fixed. Sorry, I just changed my username.


add dropdown for location type on person page

currently all location types are shown as Districts

currently all location types are shown as Districts

just realised that this causes a challenge for the synchronization with the table
e.g. what category is displayed when all location types are displayed in the table?

and I also just realized that the chart isn't showing all locations as districts, but only districts. I think there's a misunderstanding about the data here. Some locations that were previously districts were moved to other catgories, but only in the Documents table

We could still add the dropdown. That would mean that the basis for the calculations would change: choose location type from dropdown -> draw chart based on the active rows and the column corresponding to the location type selected


Modifying the description or the about of the page in a certain way locks me out and I have to start from scratch.

I got this error by editing the settings and changing the description and about. I copied the description to the about section and I think that this caused the problem.
[<IP_ADDRESS>] out: Unhandled Error [<IP_ADDRESS>] out: Traceback (most recent call last): [<IP_ADDRESS>] out:   File "/usr/lib/python2.7/dist-packages/twisted/protocols/basic.py", line 571, in dataReceived [<IP_ADDRESS>] out:     why = self.lineReceived(line) [<IP_ADDRESS>] out:   File "/usr/lib/python2.7/dist-packages/twisted/web/http.py", line 1655, in lineReceived [<IP_ADDRESS>] out:     self.allContentReceived() [<IP_ADDRESS>] out:   File "/usr/lib/python2.7/dist-packages/twisted/web/http.py", line 1730, in allContentReceived [<IP_ADDRESS>] out:     req.requestReceived(command, path, version) [<IP_ADDRESS>] out:   File "/usr/lib/python2.7/dist-packages/twisted/web/http.py", line 826, in requestReceived [<IP_ADDRESS>] out:     self.process() [<IP_ADDRESS>] out: --- <exception caught here> --- [<IP_ADDRESS>] out:   File "/usr/lib/python2.7/dist-packages/twisted/web/server.py", line 184, in process [<IP_ADDRESS>] out:     resrc = self.site.getResourceFor(self) [<IP_ADDRESS>] out:   File "/usr/lib/python2.7/dist-packages/twisted/web/server.py", line 701, in getResourceFor [<IP_ADDRESS>] out:     return resource.getChildForRequest(self.resource, request) [<IP_ADDRESS>] out:   File "/usr/lib/python2.7/dist-packages/twisted/web/resource.py", line 98, in getChildForRequest [<IP_ADDRESS>] out:     resource = resource.getChildWithDefault(pathElement, request) [<IP_ADDRESS>] out:   File "/usr/lib/python2.7/dist-packages/twisted/web/resource.py", line 201, in getChildWithDefault [<IP_ADDRESS>] out:     return self.getChild(path, request) [<IP_ADDRESS>] out:   File "/usr/local/lib/python2.7/dist-packages/txrestapi/resource.py", line 63, in getChild [<IP_ADDRESS>] out:     return maybeResource(callback)(request, **args) [<IP_ADDRESS>] out:   File "/usr/local/lib/python2.7/dist-packages/txrestapi/resource.py", line 19, in inner [<IP_ADDRESS>] out:     result = f(*args, **kwargs) [<IP_ADDRESS>] out:   File "/root/store/api/restapi.py", line 56, in _authenticate [<IP_ADDRESS>] out:     func(self, request) [<IP_ADDRESS>] out:   File "/root/store/api/restapi.py", line 212, in get_profile [<IP_ADDRESS>] out:     parse_profile(p, None if temp_handle == "" else temp_handle) [<IP_ADDRESS>] out:   File "/root/store/api/restapi.py", line 192, in parse_profile [<IP_ADDRESS>] out:     request.write(str(bleach.clean(json.dumps(profile_json, indent=4), tags=ALLOWED_TAGS))) [<IP_ADDRESS>] out: exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\xa0' in position 356: ordinal not in range(128)

I can't replicate this. Maybe someone else can. It would be help to see which field in the profile has the invalid characters.

Try this in the about section:
"Ask questions about OpenBazaar. Anything goes!
Manned by two friendly humans.
Languages supported: English, French"
It died again.

Maybe the new line characters? What's the maxlengh on the about section?

Could be the spaces. That typed in without spaces seems to work.


dotnet: Update all major dependencies (major)

This PR contains the following updates:

Package
Type
Update
Change

Microsoft.Extensions.Configuration (source)
nuget
major
8.0.0 -> 9.0.0

Microsoft.Extensions.DependencyInjection (source)
nuget
major
8.0.1 -> 9.0.0

Microsoft.Extensions.Http (source)
nuget
major
8.0.1 -> 9.0.0

Microsoft.Extensions.Options.ConfigurationExtensions (source)
nuget
major
8.0.0 -> 9.0.0

Microsoft.Extensions.Options.DataAnnotations (source)
nuget
major
8.0.0 -> 9.0.0

mcr.microsoft.com/vscode/devcontainers/dotnet
final
major
0-6.0-bullseye-slim -> 1-6.0-bullseye-slim

:warning: Warning
Some dependencies could not be looked up. Check the warning logs for more information.

Release Notes

dotnet/runtime (Microsoft.Extensions.Configuration)
v9.0.0: .NET 9.0.0
Release
What's Changed

[release/9.0] BinaryFormatter tests improvements by @adamsitnik in https://github.com/dotnet/runtime/pull/107540
[release/9.0] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/runtime/pull/107474
[release/9.0] Branding for GA by @carlossanlop in https://github.com/dotnet/runtime/pull/107879
[release/9.0] Update dependencies from dotnet/source-build-externals by @dotnet-maestro in https://github.com/dotnet/runtime/pull/107914
[release/9.0] Update dependencies from dotnet/icu by @dotnet-maestro in https://github.com/dotnet/runtime/pull/107918
[release/9.0] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro in https://github.com/dotnet/runtime/pull/107916
[release/9.0] Update dependencies from dotnet/cecil by @dotnet-maestro in https://github.com/dotnet/runtime/pull/107915
[release/9.0] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/runtime/pull/107938
[release/9.0] Update dependencies from dotnet/source-build-externals by @dotnet-maestro in https://github.com/dotnet/runtime/pull/107982
[release/9.0] Update dependencies from dotnet/cecil by @dotnet-maestro in https://github.com/dotnet/runtime/pull/107983
[release/9.0] Remove invalid assert in RSAOpenSsl by @github-actions in https://github.com/dotnet/runtime/pull/107952
[automated] Merge branch 'release/9.0-rc2' => 'release/9.0' by @github-actions in https://github.com/dotnet/runtime/pull/107928
[release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro in https://github.com/dotnet/runtime/pull/107937
[release/9.0] Update dependencies from dotnet/roslyn by @dotnet-maestro in https://github.com/dotnet/runtime/pull/107984
[release/9.0] Mitigate JsonObject performance regression. by @github-actions in https://github.com/dotnet/runtime/pull/108014
[release/9.0] Fix SG nullability annotations for required and init properties. by @github-actions in https://github.com/dotnet/runtime/pull/108013
[release/9.0] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108016
[release/9.0] Treat -rtm as stable sdk version band by @lewing in https://github.com/dotnet/runtime/pull/107997
[release/9.0] dont try to capture threadId for NativeAOT by @github-actions in https://github.com/dotnet/runtime/pull/108088
[release/9.0] Update dependencies from dotnet/runtime by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108140
[release/9.0] Fix createdump 'stack smashing detected' error on arm64 by @github-actions in https://github.com/dotnet/runtime/pull/108208
[release/9.0] [browser] Fix fingerprinting and loadAllSatelliteResources=true by @github-actions in https://github.com/dotnet/runtime/pull/108198
[automated] Merge branch 'release/9.0-rc2' => 'release/9.0' by @github-actions in https://github.com/dotnet/runtime/pull/108006
[release/9.0] More doc updates for source-of-truth assemblies by @carlossanlop in https://github.com/dotnet/runtime/pull/108257
[release/9.0] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108142
[release/9.0] Update dependencies from dotnet/roslyn by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108061
[release/9.0] Update dependencies from dotnet/cecil by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108192
[release/9.0] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108193
[release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108194
[release/9.0] Update dependencies from dnceng/internal/dotnet-optimization by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108139
[release/9.0] Reduce funceval abort by @github-actions in https://github.com/dotnet/runtime/pull/108256
[release/9.0] Update sign-diagnostic-files.yml to skip dac sign in staging by @hoyosjs in https://github.com/dotnet/runtime/pull/108218
[release/9.0] Root the System.Runtime EventSource by @github-actions in https://github.com/dotnet/runtime/pull/108348
[release/9.0] Fixing SetSlice, Reshape, TryCopyTo. by @github-actions in https://github.com/dotnet/runtime/pull/108282
[release/9.0] Update dependencies from dotnet/sdk by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108141
[release/9.0] Update dependencies from dotnet/source-build-externals by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108436
[release/9.0] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108438
[release/9.0] Update dependencies from dotnet/roslyn-analyzers by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108367
[release/9.0] Update dependencies from dotnet/runtime by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108391
[release/9.0] Update dependencies from dotnet/cecil by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108437
[release/9.0] Update System.Formats.Nrbf ref sources and restore package description by @github-actions in https://github.com/dotnet/runtime/pull/108467
[release/9.0] [aot] mono_aot_split_options: reset state after a backslash by @github-actions in https://github.com/dotnet/runtime/pull/108212
[release/9.0] Fix devirtualization across genericness in the hierarchy by @MichalStrehovsky in https://github.com/dotnet/runtime/pull/108470
[release/9.0] [cdac][cdac-build-tool] Don't let msbuild rewrite the resource name by @github-actions in https://github.com/dotnet/runtime/pull/108296
[release/9.0] Fix InlineArray swift lowering in mono by @jkurdek in https://github.com/dotnet/runtime/pull/108483
[release/9.0] Backport PR #108311 - Fix statics issue with barriers by @davidwrighton in https://github.com/dotnet/runtime/pull/108347
[release/9.0] Fix wrong Region Info Names by @github-actions in https://github.com/dotnet/runtime/pull/108524
[release/9.0][PERF] Backport python pipeline changes for performance tests by @caaavik-msft in https://github.com/dotnet/runtime/pull/108412
[release/9.0] Fix IndexOf Optimization Code by @github-actions in https://github.com/dotnet/runtime/pull/108562
[release/9.0] Updated tsaoptions.json to direct issues to runtime owners by @github-actions in https://github.com/dotnet/runtime/pull/108451
[release/9.0] JIT: Null out SSA def nodes upon removal in RBO by @github-actions in https://github.com/dotnet/runtime/pull/108548
[release/9.0] Fix LINQ Last() in ConcatNIterator to also check base case (Concat2Iterator) by @github-actions in https://github.com/dotnet/runtime/pull/108664
[release/9.0] Merge RC2 changes into 9.0 by @ericstj in https://github.com/dotnet/runtime/pull/108677
[release/9.0] Update the component resources for the VS descriptions by @marcpopMSFT in https://github.com/dotnet/runtime/pull/108304
[release/9.0] Update dependencies from dotnet/runtime by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108595
[release/9.0] Update dependencies from dotnet/sdk by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108597
[browser][debugging][release/9.0] Removed trailing command that results in a warning by @github-actions in https://github.com/dotnet/runtime/pull/108584
[release/9.0] Fix IL2104 link by @github-actions in https://github.com/dotnet/runtime/pull/108533
[release/9.0] linux/arm64: Verify TLS resolver code by @github-actions in https://github.com/dotnet/runtime/pull/108564
[release/9.0] Tweak Invariant IndexOf logic by @github-actions in https://github.com/dotnet/runtime/pull/108728
[release/9.0] Update field references in property accessors by @github-actions in https://github.com/dotnet/runtime/pull/108222
[release/9.0] [mini] Don't use Unwind Backtrace on android-amd64 by @github-actions in https://github.com/dotnet/runtime/pull/108294
[release/9.0] [wasm] Fixes for issue #108519 by @github-actions in https://github.com/dotnet/runtime/pull/108650
[release/9.0] [mono] Fix alloca builder creation by @github-actions in https://github.com/dotnet/runtime/pull/108654
[release/9.0] Backport "JIT: Run single EH region repair pass after layout" by @amanasifkhalid in https://github.com/dotnet/runtime/pull/108715
[Ppc64le] binaryformatter and tensors tests fix by @alhad-deshpande in https://github.com/dotnet/runtime/pull/108120
[release/9.0] Add DefaultMemberAttribute to Test.CoreLib by @github-actions in https://github.com/dotnet/runtime/pull/108258
[release/9.0] [wasm] Include browser targets if RID is not wasi-wasm by @github-actions in https://github.com/dotnet/runtime/pull/108434
[release/9.0] [browser] Make boot json file name configurable by @maraf in https://github.com/dotnet/runtime/pull/108708
[release/9.0] Update dependencies from dotnet/source-build-externals by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108787
[release/9.0] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108598
[release/9.0] Update dependencies from dotnet/roslyn by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108326
[release/9.0] bgc deadlock fix by @github-actions in https://github.com/dotnet/runtime/pull/108774
[release/9.0] Remove string.Trim{,Start,End}(ReadOnlySpan) ref-API by @bartonjs in https://github.com/dotnet/runtime/pull/108777
[release/9.0] Arm64: Use TYP_SIMD8 for AddAcross by @github-actions in https://github.com/dotnet/runtime/pull/108805
[release/9.0] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108844
[release/9.0] Fix optimization of Vector512 AndMask + NotMask to AndNotMask by @github-actions in https://github.com/dotnet/runtime/pull/108803
[release/9.0] Bump Microsoft.Private.Intellisense to 2024101.1 by @carlossanlop in https://github.com/dotnet/runtime/pull/108766
[release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108481
[release/9.0] Switch SwiftSelf<T> position requirement to last by @github-actions in https://github.com/dotnet/runtime/pull/108856
Use default timeout of 30s. by @ilonatommy in https://github.com/dotnet/runtime/pull/108835
[release/9.0] Fix CET debugger stepping over CALL instructions by @tommcdon in https://github.com/dotnet/runtime/pull/108872
[release/9.0] Remove managed EH code frames from stack trace by @github-actions in https://github.com/dotnet/runtime/pull/108831
[release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108898
Port NuGet Audit back to 9.0 by @ericstj in https://github.com/dotnet/runtime/pull/108854
[release/9.0] fix guid version > 7 by @github-actions in https://github.com/dotnet/runtime/pull/108351
[release/9.0] Stable branding for GA by @carlossanlop in https://github.com/dotnet/runtime/pull/108899
[release/9.0] Update dependencies from dotnet/source-build-externals by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108927
[release/9.0] Update dependencies from dotnet/roslyn-analyzers by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108691
[release/9.0] Update dependencies from dotnet/cecil by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108788
[release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108482
[release/9.0] Update dependencies from dotnet/roslyn by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108975
[release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108910
[release/9.0] Update dependencies from dotnet/runtime by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108842
[release/9.0] Couple minor docs updates by @github-actions in https://github.com/dotnet/runtime/pull/108453
[release/9.0] Update dependencies from dotnet/icu by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108516
[release/9.0] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108751
[release/9.0] Update dependencies from dotnet/sdk by @dotnet-maestro in https://github.com/dotnet/runtime/pull/108843
[release/9.0] Ignore *.pp files in .gitignore by @github-actions in https://github.com/dotnet/runtime/pull/109003
[release/9.0] Make System.Formats.Asn1 triple slash documentation the source of truth by @github-actions in https://github.com/dotnet/runtime/pull/108995
[release/9.0] Ensure a null PublicKey is supported on assembly refs by @github-actions in https://github.com/dotnet/runtime/pull/108928
[release/9.0] Fix handling of appending keywords to boolean schemas. by @github-actions in https://github.com/dotnet/runtime/pull/108248
[release/9.0] Update the JSON schema exporter to reuse schemas more aggressively. by @github-actions in https://github.com/dotnet/runtime/pull/108800
[release/9.0] Initialize m_fInPlaceSS by @github-actions in https://github.com/dotnet/runtime/pull/109013
[release/9.0] Handle building host test assets with stabilized package versions by @github-actions in https://github.com/dotnet/runtime/pull/109031
[release/9.0] Fix nativeaot outerloop by @github-actions in https://github.com/dotnet/runtime/pull/109009
[release/9.0] Initialize managed and native values in the ICustomMarshaler marshaler to null when the other is null. by @github-actions in https://github.com/dotnet/runtime/pull/109096
[release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro in https://github.com/dotnet/runtime/pull/109051
[release/9.0] Permit unencrypted key exports from CNG by @github-actions in https://github.com/dotnet/runtime/pull/109134
[release/9.0] Bump downlevels for 9.0 by @lewing in https://github.com/dotnet/runtime/pull/109288
[release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro in https://github.com/dotnet/runtime/pull/109323

Full Changelog: https://github.com/dotnet/runtime/compare/v9.0.0-rc.2.24473.5...v9.0.0

Configuration
:date: Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
:warning: Warning: custom changes will be lost.


Clarify ExtractTextPlugin Better, Review Externals Section

This was someone who took the time to express their concerns about where and how to find the information listed below.
Here are the things I had the most trouble with in the beginning:
- Externals. I still have trouble wrapping my head around this directive.
- Multiple output paths for multiple entry points (it wasn't intuitive to make the entry point key a relative path and I had to discover this method on stack overflow).
To be fair, a proper set of documentation for webpack would be a several hundred page book.
Edit: I see my second point still isn't mentioned anywhere in the old or new docs. Specifically:
  const ExtractCSS = new ExtractTextPlugin('[name].css');
  ...
  entry: {
    ['./app/bundle']: './source/app/index.js',
    ['./admin/bundle']: './source/admin/index.js'
  },
  output: {
    path: './build/',
    filename: '[name].js'
  }
  ...
would create:
  build/
    app/
      bundle.js
      bundle.css
    admin/
      bundle.js
      bundle.css

Easily Summarized. I think its fair we should create issues for ExtractTextPlugin and document it a little more thoroughly I think some don't realize there is no such thing as a css entry and that everything is a js bundle in the end besides emitted assets. (like a css bundle). As well as Externals.

Awesome, thanks. If the answer to my confusion is "you're doing it wrong and here's what you should be doing" I'm open to that. 😄  Also, the new docs really are fantastic. Keep up the good work!

Hi,
Do the following links help? I think they are misnamed though.
Code splitting libraries - Explains multiple entry points.
Code splitting with CSS - Explains the extract text plugin
Externals config - Explains externals configuration. Lots of todos.
Maybe these can be enhanced with the missing info?

Added function example to externals: https://github.com/webpack/webpack.js.org/pull/783

The pages listed in https://github.com/webpack/webpack.js.org/issues/416#issuecomment-262707459 have gotten updates in the meanwhile. What remains to be done/clarified?


Bugfix doc improvements

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f7515ce) 96.43% compared to head (2b54cdd) 96.62%.
Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   96.43%   96.62%   +0.18%
==========================================
  Files          86       86
  Lines        6898     6953      +55
==========================================
+ Hits         6652     6718      +66
+ Misses        246      235      -11

Flag
Coverage Δ

unittests
96.62% <98.61%> (+0.18%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

spacepackets/cfdp/pdu/ack.py
100.00% <ø> (ø)

spacepackets/cfdp/pdu/eof.py
97.64% <ø> (ø)

spacepackets/cfdp/pdu/file_data.py
92.73% <ø> (ø)

spacepackets/cfdp/pdu/finished.py
96.29% <ø> (ø)

spacepackets/cfdp/pdu/helper.py
89.62% <100.00%> (+11.95%)
:arrow_up:

spacepackets/cfdp/pdu/keep_alive.py
94.28% <ø> (ø)

spacepackets/cfdp/pdu/metadata.py
96.10% <ø> (ø)

spacepackets/cfdp/pdu/prompt.py
96.15% <ø> (ø)

spacepackets/cfdp/tlv.py
95.70% <100.00%> (ø)

tests/cfdp/pdus/test_ack_pdu.py
98.27% <100.00%> (+0.27%)
:arrow_up:

... and 8 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Plugin not loading on Velocity

Describe the bug

2FA version 1.6.3 can't load on Velocity. Also, velocity-plugin.json doesn't exist inside the plugin.
How To Reproduce

Expected behavior

The plugin should load correctly.
Screenshots and Videos

Server Information

OS: Ubuntu 20.04
Java Version: 17

Additional context

Older versions of 2FA, have the velocity-plugin.json file inside.

The plugin does not support Velocity.

Then you should remove the part in the plugin's description and spigot page, that has support for Velocity.

Right, maybe you forgot to add "velocity-plugin.json" inside the project, feel free to create a PR adding this and obviously tested and it works :)

Ok, I tried adding the old velocity-plugin.json, and it worked. I already tried to install 2FA in my backend servers and it works perfectly. I'll create a pull request right now.


Resize column widget on PaginatedDataTable2

Widget to resize columns manually. It can be anabled by setting to true the resizeable variable in the DataColumn2 constructor.
https://user-images.githubusercontent.com/5269947/169674825-17f5f538-7c22-417e-8b41-297605912657.mov

Thanks for submitting the PR, the feature seems great. Though there're a few issues:

There're failing unit test (try running them locally via VSCode)

There's an exception when resizing window size

There's still lag/misallignment when dragging and resizing a row. Might there be an old version in PR? Tested in Chrome and as macOS desktop app

JIC, here's my flutter doctor -v output
[✓] Flutter (Channel stable, 3.0.1, on macOS 12.3.1 21E258 darwin-x64, locale en-GB)
• Flutter version 3.0.1 at /private/var/user/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision fb57da5f94 (3 days ago), 2022-05-19 15:50:29 -0700
• Engine revision caaafc5604
• Dart version 2.17.1
• DevTools version 2.12.2
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /var/user/Library/Android/sdk
• Platform android-31, build-tools 31.0.0
• ANDROID_HOME = /var/user/Library/Android/sdk
• Java binary at: /Applications/Android Studio 4.1 Preview.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 13.4)
• Xcode at /Applications/Xcode.app/Contents/Developer
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• CHROME_EXECUTABLE = /Applications/chrome_no_cors.sh
[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio 4.1 Preview.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
[✓] VS Code (version 1.67.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.40.0
[✓] Connected device (2 available)
• macOS (desktop) • macos  • darwin-x64     • macOS 12.3.1 21E258 darwin-x64
• Chrome (web)    • chrome • web-javascript • Google Chrome 101.0.4951.64
[✓] HTTP Host Availability
• All required HTTP hosts are available

Fixed the failing unit tests and the exception when resizing the window.
I notice the lag/missaligment problem only if resizing too fast or when I try to shrink the column below the minimum (in the later case I think there is nothing we can do).
If I resize the column not too fast, there doesn't seem to be missaligments. I'll try to find a solution for this, let me know if you have a clue.

Codecov Report

Merging #93 (16fc3b8) into main (8f37004) will decrease coverage by 2.15%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   88.38%   86.23%   -2.16%
==========================================
  Files           3        3
  Lines         818      857      +39
==========================================
+ Hits          723      739      +16
- Misses         95      118      +23

Impacted Files
Coverage Δ

lib/src/paginated_data_table_2.dart
92.70% <6.25%> (-5.09%)
:arrow_down:

lib/src/data_table_2.dart
92.59% <50.00%> (-1.92%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f37004...16fc3b8. Read the comment docs.

Added a sample for DataTable2, please note that thus sample has minWidth set. In that case resizing is not applied

By default DataTable2 expands to it's container, it's width is determined by the number of pixel LayoutBuilder provides. I.e. the default scenario is that DataTable2 doesn't have a fixed width, should anyone want a fixed width, the control must be wrapped in limmiting widget.
For the cases when viewport becomes to narrow and Columns get condensed to non-reasonable widths there's a minWidth property which stops shrinking
Speaking of resizing columns expected behaviour:

By default no total width of the table is changed, extending or shrinking a column is achieved via redistributing available width
[Optional] we can consider adding a feature to let darg rightmost column and get total width changes to the DataTable2

Here're some thoughts which I'm not quite sure yet in terms of implementability/consictency, your considerations are welcome:

It is a common practice to resize column when clicking at column border, changing cursor to resize - idiomatic for Desktop
Cursors are not available at touch devices, in that case we need that dragable icon
We might need some way of controling when to show the dragable widget or not - either let developers control that behavior or present some helper to make the choise of Dekstop vs Touch -> the general tradeoff of explicit/predicatble vs implicit/handy in default cases
When changing column width we can either make it fixed width (and it will stay fixed when table width changes) or we can adjust ratio for that column so that it changes proportionaly to table width change
When implementing width change via border mouse down, we either treat the colukn to the left being the subject of width change. Or it migh require a more complicated approach when both columns must be treated as subjected to change

One more thing, DataTable2 is stateless while PaginatedDataTable2 is statefull, apparently dragging columns will require to adress that issue cause it might be to reasonable to have that behavior implemented in both widget. Yet making DataTable2 stateful might be a poor option cause it is treated as direct replacement to Flutter's DataTable which is statless - not usre if switching DataTable2 to staefull might present any challenges in this regard

By default no total width of the table is changed, extending or shrinking a column is achieved via redistributing available width

I don't see any problem resizing the total width of the table when resizing a column, it's not uncommon. In other platforms that implement resizing columns it works this way, and I think if you want resizable columns you should expect variable table width. And if, for example, all the columns are defined with fixed width, I don't see another way other than resizing the table. Maybe if the columns are defined with proportional widths, we could shrink the columns first to its minimum before growing the table.

[Optional] we can consider adding a feature to let darg rightmost column and get total width changes to the DataTable2

I think this could be a bit cumbersome, specially for large tables with many columns, you would have to scroll to the rightmost column in order to give more space for other columns. It would be much easier if the table grows/shrink with the column.

Here're some thoughts which I'm not quite sure yet in terms of implementability/consictency, your considerations are welcome:...

I agree with this, we could design a draggable widget that is both compatible with desktop and mobile, or give an option to select which mode you want to use (desktop / mobile) or put some parameters to customize the looks. I'll see what I can do.

One more thing, DataTable2 is stateless while PaginatedDataTable2 is statefull, apparently dragging columns will require to adress that issue cause it might be to reasonable to have that behavior implemented in both widget. Yet making DataTable2 stateful might be a poor option cause it is treated as direct replacement to Flutter's DataTable which is statless - not usre if switching DataTable2 to staefull might present any challenges in this regard

Yeah, this is a tricky subject, I didn't implement column resizing on DataTable2 to keep it stateless. Maybe we should clarify in the code comments that the function onColumnResized must be implemented to do the actual resizing. We could also create a new stateful widget, or just keep the implementation on PaginatedDataTable2.
Another thing I found, I tested this feature on another computer on Linux and I found the lag / misalignment problem a bit worse, I'll see if I can find a better approach for the resizing.

I made some progress on the pending tasks. These are the major changes:

Now when resizing columns, the non fixed width columns are resized first before resizing the table
If a non fixed width column is resized, it's treated as fixed
Added customizable resize widget. It can be set to desktop or mobile mode, customize it's color and real time rendering

I'm wondering if it would be best to create a new stateful DataTable class to implement the resizing there and keep all the implementation in a data table. Let me know your thoughts.

Speaking of column resizing, please see below an interesting bug. Please not that at the beginning of the video resizing columns leads to flexing all rows around. Yet when you change width of the Name column all other columns to the right get resized while column to the left are untouched - the second part IMO is the right behaviour:
https://user-images.githubusercontent.com/7947027/172431912-4cb1f128-2df8-40c7-809d-276366b32ddc.mov
Here's how I see resizing behaviour:

Resizing column leads to it's change of width via taking or giving space to whatever columns there're to the right, space to the left must be fixed/untouched
By default the total width of StatefulDataTable2 should remain unchanged, until StatefulDataTable2.lockTableWidth is set to false

Also a separate example (1st level route) is required for the resizing scenarious with 2 subroute - one depicting PaginatedDataTable2 and another StatefulDataTable2, that will make examples easer to understand

The refactor you made looks good, I'll start working with that and the other proposed changes.

Speaking of column resizing, please see below an interesting bug. Please not that at the beginning of the video resizing columns leads to flexing all rows around. Yet when you change width of the Name column all other columns to the right get resized while column to the left are untouched

The actual behavior is a bit awkward, but it was intended this way: all the columns with proportional size (fixedWidth property set to null) to he left or right  get resized, the columns defined with the fixedWidth property don't. When a proportional width column is resized, it's treated as fixed width, that's why  on the second part of the video the columns to the left are no longer resized.

By default the total width of StatefulDataTable2 should remain unchanged, until StatefulDataTable2.lockTableWidth is set to false

It could be implemented, but with the actual behavior, if lockTableWidth is set to true and all the columns are set with fixedWidth, the resizing will not be possible. Maybe the fixed columns should be resized too. I'll see what I come up with.

IMO, fixedWidth is was not the best choice of naming, something like absoluteWidth would be more relevant. It's just an alternative way of defining default or standard sizing behavior for columns - you either define pixels and assume column doesn't respond to table width changes or provide relative size via S, M or L. None of the options must force the resizing logic to ignore any of the 2 kinds of rows. After all we have the resizable column type with a separate flag devoted to controlling locking or unlocking resizing, no need to add another parameter (checking if column is fixedWidthSize). Though adding a documentation remark of stateful table regarding fixed column sizes might be useful.
Speaking of implementation detail, I think that looking into using fixed width columns to achieve column resizing upstream with zero to None changes to DataTable2 might be a good option. I.e  in the StatefulDataTable2 on resizing thr build() method can instantiate a new table supplying it with clones of provided columns BUT having their fixedWidth set to specific values.
Note, a method on ColumnSizeControl controller can be added to reset column width adjustments.

Thanks for tidying up the examples and presenting a new one!

Thanks for your feedback maxim. I haven't had much time to work on this lately, an yes the refactor is still work in progress, if you like I could do partial commits so you can see the progress and give some feedback.
In order to avoid passing DataTable2.buildResizeColumnWidget in the constructor, I thought I may create another private class inheriting DataTable2 to build the widget there overriding DataTable2._buildHeadingCelland keep DataTable2 as clean as possible.
Something similar may be done with  ColumnDataController, but I'll see it when I rework the resizing logic. I still may need to get the actual column sizes that are calculated in DataTable2._calculateDataColumnSizes though.
Another question I have, what do we do if we have a StatefulDataTable2 with a mix of fixed and non-fixed width columns and the window resizes? The actual behavior of DataTable2 is to resize only non-fixed-width columns. If we treat all columns as fixed, do we resize all columns proportional regardless of their initial settings? or resize only the rightmost column? and if some columns are not resizable? should they keep their initial settings?. I implemented the current logic to maintain this behavior of DataTable2. Rebuilding DataTable2 was one of the approaches I tried earlier but I think I discarded it for this reason.

Another question I have, what do we do if we have a StatefulDataTable2 with a mix of fixed and non-fixed width columns and the window resizes? The actual behavior of DataTable2 is to resize only non-fixed-width columns. If we treat all columns as fixed, do we resize all columns proportional regardless of their initial settings? or resize only the rightmost column? and if some columns are not resizable? should they keep their initial settings?. I implemented the current logic to maintain this behavior of DataTable2. Rebuilding DataTable2 was one of the approaches I tried earlier but I think I discarded it for this reason.

IMO, if a column is resized it keeps that size no matter if the width of parent is changed. Should the parent grow and all columns have their widths altered, they should stay that way. The only column changing it's width should be the rightmost one.
Optionally there can be a special mode which can adjust manually altered columns proportionally to parent change - though that mode is not trivial to describe (e.g. what if there's already a horizontal scroll bar and table total width is greater than viewport)

Hi @nerdknight , should you still be looking at the PR... I think I've come up with a more elegant solution to having state which allows to keep DataTable2 stalest and avoid creating StatefulDataTable2. You can use a stateful widget inside and builder pattern to feed column width's inside. You can check the recent commit and SyncedScrollControllers widget.

Hi @maxim-saplin, I looked into the solution you proposed an it seems good to me, I think it would be better to keep the functionality inside DataTable2. I'll try to implement column resizing with this method and let you know.
Regarding the behavior of the columns when resizing, I still have some doubts on how should it behave in certain configurations. I'll make a video with examples so we can define the whole behavior before starting to code it.

Thanks!

I've been able to implement successfully the refactor you suggested. I had to to implement it in the same place as SyncedScrollControllers, so I added the ColumnDataController and some other things I need to SyncedScrollControllers. The other way would be to create another widget to implement the resizing logic and then instantiate this builder inside the another builder. I think is more cleaner to make SyncedScrollControllers more general purpose, It may need to be renamed.
I removed ResizableDataColumn2 and added  isResizable property to DataTable2.
Let me know what you think.

There is the push, I implemented it as you suggested in a separate widget. I also update the examples.

Hey there. It is taking me time to review the changes. I'm going slowly as there's a lot of new code and not trivial one. Started with refactoring attempting to make the changes easier to understand.
I'm still not very happy with the behaviour of resizing of a column and having leftmost columns changing sizes as well, that seem a bit odd to me. Though I am still not well squatted with the code to be specific of implementation suggestions.

I'm still not very happy with the behaviour of resizing of a column and having leftmost columns changing sizes as well, that seems a bit odd to me. Though I am still not well aquainted with the code to be specific of implementation suggestions.

Looks like you've changed that behaviour in the recent commits. Thanks!

I'm still not very happy with the behaviour of resizing of a column and having leftmost columns changing sizes as well, that seems a bit odd to me. Though I am still not well aquainted with the code to be specific of implementation suggestions.

Looks like you've changed that behaviour in the recent commits. Thanks!

Hi Maxim, yes the previous behavior was a bit odd. Now columns to the left don't change size, the columns to the right resize if they are defined with proportional size. Let me know if you have any suggestions.

@maxim-saplin Could you close this branch ?

@maxim-saplin is it done ?

@maxim-saplin is it done ?

It is not

@nerdknight

@maxim-saplin
?


Make testcheck optional as a virtual module.

It turns out that on a full test run at FB, simply requiring testcheck actually slows the test run down by about 20 %. Since I do not expect it to be used throughout the codebase but rather only in a few tests, I decided to change this feature to be optional.
It can now be explicitly required by doing require('jest-check'). This new way of installing the module also allows us to get rid of the global config object passing, yay!
cc @davidmccabe

Cool!
I don't know if testcheck is going to work for us long term, because its performance is so poor. But we can keep the same interface if we  rewrite it.

@davidmccabe are you planning to rewrite it? That would be great. I really believe it would be awesome to ship this for all engineers at FB with a reasonable default perf :)


Convert Cesium plugin to use goog.module

The entire Cesium plugin has been converted to use goog.module. I cleaned up somethings we were doing in the plugin that resulted in compiler errors using ES classes.

Some Cesium classes like Cesium.TilingScheme are really abstract classes and don't provide any functional code. The Cesium class/object is not available until the library is loaded, so we had code to defer creating extending classes until that happens. This was a little strange with modules/classes, so I changed the Cesium externs to make the original constructor an interface instead. This is much cleaner, and has no side effects given Cesium's implementations were all empty anyway.
Some Cesium mixins also needed to load async after the library loaded, so I cleaned up those files to a more consistent and module-friendly pattern.
We frequently used Object.defineProperties to add get/set functions to Cesium plugin classes. ES classes can use get/set directly, so I refactored all of those so the resulting code is much cleaner.
We had some janky code to replace the OLCS camera class with our own, because we didn't want to use their view listener. We were using all of the other code, so I dropped the class replace and instead replaced setView_ (the view change handler) on the OLCS class with an empty function. This has the same end result, but in a less janky manner.

There were some functions in src/os/ui/icons.js that were on the os.ui namespace, which caused similar problems to the noted os.ui.window references. To resolve this and hopefully better prep for converting that file, I moved all functions to os.ui.icons, provided that namespace, and added deprecated references to the old function paths. I fixed all references in OpenSphere, and external projects will see a deprecation warning if they're using the old functions.


Restructure Wemo since it now supports Lights and (soon) Motion Sensor

Should now be a platform, rather than a switch.

I have a working implementation for Wemo led support in home-assistant , but it is not integrated with the discovery component so I hadn't made it a PR yet. I have tried to rework it similar to how the Nest thermostat was done, but got stuck on not having the add_devices callback available.
https://github.com/jaharkes/home-assistant/tree/wemo_leds

If you like I'll do some basic restructuring - and then it should be easy for you to add your PR.

Sounds good to me.

@balloob Is there already a component that uses discovery - and then decides whether to create lights, switches or sensors based on device type? Would like to copy some of the code if there is...

Verisure discovers sensors, locks, switches and alarm devices. Have a look
at that.
17. feb. 2016 18:53 skrev "Greg Dowling"<EMAIL_ADDRESS>
@balloob https://github.com/balloob Is there already a component that
uses discovery - and then decides whether to create lights, switches or
sensors based on device type? Would like to copy some of the code if there
is...
—
Reply to this email directly or view it on GitHub
https://github.com/balloob/home-assistant/issues/1291#issuecomment-185324367
.


v0.8.1 release accidentally included HTTPRoute Timeouts in experimental CRD

What happened:
As reported by @skriss, the v0.8.1 release was actually created from the main branch and not the release-0.8 branch. This means that HTTPRoute timeouts were accidentally included in the release.
What you expected to happen:
The v0.8.1 release should have been created from the release-0.8 branch and should not have included timeouts. As follow ups we need to:

Work on process improvements to ensure this can't happen again
Determine if we want to release a v0.8.2 release that rolls back HTTPRoute timeouts

There is more discussion in the Slack thread that reported this.

We ended up releasing the same API in v1.0, and I don't believe this did any damage after all. Closing this out.


1753/twig test

Ticket: #1753

Coverage increased (+0.1%) to 94.302% when pulling a787340759b84d75d276eae6125b742b4382f57d on 1753/twig_test into<PHONE_NUMBER>79568a8def46b7141d7a1da1cb6c94 on master.


Kubernetes PR broke 300_internet_edge_test.sh

vagrant@ubuntu-14:~/src/github.com/weaveworks/scope/integration$ ./300_internet_edge_test.sh
Test short lived connections from the Internet
339ed943494b97835d0585333d94ec2ef551d091d412b734535d46de7fd6db85
Weave Scope is reachable at the following URL(s):
  * http://<IP_ADDRESS>:4040/
  * http://<IP_ADDRESS>:4040/
11845b1722455e5ccf885051a202ac797cc199ec76e75e9676d60446b1f9653e
/home/vagrant/src/github.com/weaveworks/weave/test/assert.sh: line 76: 15729 Terminated              do_connections
test #1 "curl -s http://host1.us-central1-a.positive-cocoa-90213:4040/api/topology/containers?system=show | jq -r '[.nodes[] | select(.label_major == "nginx")] | length'" failed:
	expected "1"
	got "0"
test #2 "curl -s http://host1.us-central1-a.positive-cocoa-90213:4040/api/topology/containers?system=show | jq -r '.nodes[""].adjacency | contains([""])'" failed:
	expected "true"
	got nothing
2 of 2 tests failed in 15.675s.

I suspect something has changed such that it is taking more that 5s to send the first report.  If you extend the timeout to 20s it passes.  Would be good to get to the bottom of though, probe shouldn't take that long to send first report.

This test only works on GCE (which is awful), but even on GCE, I can't replicate this. I would be very surprised if it is related to the Kubernetes changes.


finish the prometheus work

we now have prometheus metrics , but we havent yet automated their deployment in kpng-local-up.sh.  LEts make sure:

the KPNG client publishes metrics
that we scrape the KPNG brain
We launch prometheus https://github.com/prometheus-operator/prometheus-operator on startup of KPNG and toggle it to scrape the KPNG services

ideally we should be able to make pretty pictures that show for example how many add,sync,watch,opitem types and so on are triggered so that we can use it to instrospect how adding large amounts of services/endpoints work

/assign

/assign
@emabota, lmk what you're working on so we can split this work. Ping me in Slack if you prefer

Hi @jaehnri, I haven't started working on this yet. Go ahead, pick whichever you want!

/assign
@jaehnri are you already working on this issue? if yes or no, I would like to help out and contribute.

/assign

Hello @adeniyistephen and @jaehnri Iwill like to help out and contribute

awesome, let's just wait for @jaehnri to reach out back,

I haven't really started it. @Asiya-Yunusa @adeniyistephen, you can go ahead and pick it up.
/unassign

@adeniyistephen when can we start please?

sure, you can go ahead and read on the task, I'll do the same too - and we can discuss our findings/understanding on Slack by tomorrow.

partially done but nobody has confirmed we have comprehensive metrics for the op_items etc yet

@jayunit100 Nice one, I would run it and see how it looks. I don't know if I'm missing something, but I can't find ClusterRole system:auth-delegator. https://github.com/kubernetes-sigs/kpng/blob/3cb507a18ac1fd8c3f6f2fdb51ee4a3dbcdf7c42/hack/metrics/metrics-server.yaml#L81

hi everybody , I started on this last week , merged some changes and have some more in the pipeline => will post in slack when I have some nice e2e stuff to look at !  ( should be soon )


Documentation for CertificateRevoke is incorrect

Looking at the docs under both Latest and 8.0, both show certificates/{id}/revoke as a POST in the example. In my testing against 8.0 this returned a 405 METHOD NOT ALLOWED.
The documentation is also not clear on what data should be send with the request and in what format. It shows data=None in the header right above where I linked: put(certificate_id, data=None) however if you actually don't pass any data the endpoint returns a 400: BAD REQUEST. There is no link to acceptable values for crlReason. I tried Googling and found this page and tried "UNSPECIFIED" but that also returns a 400: BAD REQUEST with message {"message": "Validation Error.", "reasons": {"crlReason": "Not a valid choice."}}.
Lastly even though comments is listed as "comments": "Additional details if any" - implying that it is optional - I could not get a successful revocation without supplying comments.

Hi @evan-chaney, thank you for bringing up the gap in documentation. I have made changes as per the suggestion.

The request type is changed to PUT in Example request:
The crlReason and comments are both optional, now specified so in the doc. You may want to pass {} since Accept: application/json for the endpoint. I could revoke with and without crlReason and/or comments. If you can please share the error that you see without supplying comments, I can take a look.
I have added link to acceptable values for crlReason

I can confirm that supplying just {} for the data works. My error without comments was me not passing any data. The changes on the docs look good. Thanks for the quick response!


Update package.json

Adding myself back as a contributor, as I initially created this library.

Coverage remained the same at 65.426% when pulling 302f05fbda405690fdf779c48abac1cf7fdabb26 on emilyrose:patch-1 into 1d9c47f05bfb66543aca1de7a4d3b392ea0a6ff0 on spark:master.

Looks like the author was changed about 5 months ago, and we should have moved your name into the contributor list, sorry about that!  Thanks for the PR.

Welcome back Emily!


Passing data to modal form bootstrap

I have been attempting to pass data passed to the html template from bottle app that contains pony orm elements and I cannot get it to load the data from the id that I have passed. Can I get some help?
Below is the posted HTML and JQuery
(Button to open modal form)

 Ingredient
 Quantity
 Edit
 Remove

							% for ingredient, custing in zip(ingredients, inventory):

{{ingredient.IngredientName}}
{{custing.Quantity}}

									** ** (Primary Culprit)

							% end

(Modal Form)

Edit Ingredient

×

 Change quantity of ...

 Quantity:

Submit Changes

(JQuery)
$('#edit_ingredient_modal').on('show.bs.modal', function (event) {
var button = $(event.relatedTarget) // Button that triggered the modal
var ingredient = button.data('ingredient') // Extract info from data-* attributes
// var ingredient_name =
// If necessary, you could initiate an AJAX request here (and then do the updating in a callback).
// Update the modal's content. We'll use jQuery here, but you could use a data binding library or other methods instead.
var modal = $(this)
modal.find('.modal_text').text('Change quantity of ' + ingredient)
modal.find('.modal-text input').val(ingredient)
})
Thanks

This is not bottle-related. Please ask a javascript, jquery or bootstrap community for help.


Various minor grammar and similar fixes

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   78.13%   78.13%
=======================================
  Files          17       17
  Lines        2946     2946
=======================================
  Hits         2302     2302
  Misses        644      644

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eae333...92d4228. Read the comment docs.

Thanks!


BTW, Mastodon – Simplified Federation is compatible with Mastodon v4 now, too!

Hi I just noticed your add-on.
I am the maker of “Mastodon – Simplified Federation” and I could just announce a new release that finally fixes the issue of making it compatible with v4.
I see you did some stuff differently than we, especially your content script is somewhat different:
https://github.com/raikasdev/mastodon4-redirect/blob/master/src/m4redirect.js
So if there is way for collaboration or improving the extensions, we can surely do so. PRs are always welcome and I have already ideas for improvements (see https://github.com/rugk/mastodon-simplified-federation/issues/86).

Hey! Shared a idea!


Request: PreText Return & Tab behavior

When I have a PreText element, I need to hit the return key twice in order to go to the next line - as if the first return press didn't do anything.
It would be great if the tab key inserted a tab (or 4 spaces) for indenting pre-code. I tried doing this for a PR but I can't get it to work, somewhere there's an \n inserting itself and prevents be from going back to the content using arrow keys.
In-line with 2., if the line is indented with a tab, it would be cool if hitting the return key would also implement the same indentation on the next new line.

@bfintal believe a fix for the issues you mentioned here are now in place, I'm moving the enhancement suggestions to a separate issue so they can be discussed further.


[FLINK-36247][cdc-connector] Fix potential transaction leak during MySQL snapshot phase

FLINK-36247
remove connection.setAutoCommit(false)

@leonardBang PTAL


Feature/link info #175

Description
Added link info the MalcolmJS, this also has the ability to delete a link.
Added a range of performance optimisations as well.
Testing instructions
Add a set up instructions describing how the reviewer should test the code

Review code
Check Travis build
Review changes to test coverage
run the site, bring up a layout and click a link - see the info, try changing the source port as well as deleting the link with the button

Agile board tracking
connect to #175
connect to #235
connect to #232
connect to #252
closes #175
closes #235
closes #232

Codecov Report

Merging #254 into version1 will decrease coverage by 2.14%.
The diff coverage is 64.02%.

@@             Coverage Diff             @@
##           version1    #254      +/-   ##
===========================================
- Coverage     91.65%   89.5%   -2.15%
===========================================
  Files            67      69       +2
  Lines          1869    1944      +75
  Branches        299     311      +12
===========================================
+ Hits           1713    1740      +27
- Misses          139     180      +41
- Partials         17      24       +7

Impacted Files
Coverage Δ

src/infoDetails/infoElement.component.js
100% <ø> (ø)
:arrow_up:

src/layout/block/blockWidget.component.js
80% <ø> (ø)
:arrow_up:

src/layout/layout.component.js
53.33% <0%> (-10.67%)
:arrow_down:

...ets/attributeDetails/attributeDetails.component.js
100% <100%> (ø)
:arrow_up:

src/malcolm/worker/worker.builder.js
100% <100%> (ø)

src/mainMalcolmView/mainMalcolmView.container.js
93.54% <100%> (+0.95%)
:arrow_up:

src/malcolm/malcolmSocketHandler.js
100% <100%> (ø)
:arrow_up:

src/malcolm/malcolmHandlers/attributeHandler.js
96.96% <100%> (-0.09%)
:arrow_down:

...s/attributeSelector/attributeSelector.component.js
100% <100%> (ø)
:arrow_up:

src/malcolm/reducer/navigation.reducer.js
91.17% <20%> (-3.67%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f577a9...d820a81. Read the comment docs.

Reviewed the code myself


Merge rerun results when --flaky-test-attempts is used

flakyTestAttempts runs tests multiple times. Currently any failures will be reported as a failure in Flank, even if the test passes on retry.
Fetch the test rerun results, and consider the full history of a test to determine if it's passed or not.

Current situation. If --flaky-test-attempts is set to >0 and any of the tests in the matrix fail, FTL will rerun the matrix and place the rerun results in a subdirectory called rerun_#. Here's a sample run with flaky-test-attempts=3 where one test always passed and one always failed:
results/2019-03-07_00-15-58.110000_IbGW
results/2019-03-07_00-15-58.110000_IbGW/JUnitReport.xml
results/2019-03-07_00-15-58.110000_IbGW/CostReport.txt
results/2019-03-07_00-15-58.110000_IbGW/HtmlErrorReport.html
results/2019-03-07_00-15-58.110000_IbGW/flank.yml
results/2019-03-07_00-15-58.110000_IbGW/MatrixResultsReport.txt
results/2019-03-07_00-15-58.110000_IbGW/shard_0
results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait
results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait/test_result_1.xml
results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait-rerun_2
results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait-rerun_2/test_result_1.xml
results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait-rerun_3
results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait-rerun_3/test_result_1.xml
results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait-rerun_1
results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait-rerun_1/test_result_1.xml
results/2019-03-07_00-15-58.110000_IbGW/matrix_ids.json

Right now, flank will aggregate all the result producing a JUnitReport.xml with 8 total tests and 4 failures. Instead of 8 result, we'd really like 2 results (one for each unique test executed).
Proposed solution:

Merge the redundant test results from each shard into the top-level xml result file (results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait/test_result_1.xml)
If a test ultimately passed, but was flaky (i.e. failed either the first time or in at least once in one of the reruns), mark the test as flaky in the xml file like so: <testcase name="testPasses" classname="com.example.app.ExampleUiTest" time="0.0" "flaky="true">. A possible future optimization, we could report the flaky rate (number of failures/total attempts), but I'd like to keep the initial version simple.

An alternative to 2. could be to dump the flaky info to a separate file inside each shard, but to me, it seems like keeping it in one location would be desirable.
A couple of questions I haven't looked into yet:

will flank roll up the flaky="true" attributes to the top-level JUnitReport.xml? (if not, we'd need to do that)
what happens if repeatTests and flakyTestAttempts is used in the same config? I don't see a case where that would be needed. If so, we should probably add that validation to the doctor.

Sounds like a great idea. But I'd suggest valuing the JUnit XSD specifications, meaning I think the (2) approach would be more suitable, even though (1) would be more userfriendly. Maybe we could also dump the flaky results into the properties of the report to contain e.g. a comma-separated list of all flaky testcases?

what happens if repeatTests and flakyTestAttempts is used in the same config?

I think we'd want to repeat them normally. It does seem like a weird use case.

will flank roll up the flaky="true" attributes to the top-level JUnitReport.xml? (if not, we'd need to do that)

I think modifying the report to include the data we need makes sense. The iOS JUnit is already custom from FTL so following JUnit XSD exactly isn't possible.

what happens if repeatTests and flakyTestAttempts is used in the same config?

I think we'd want to repeat them normally. It does seem like a weird use case.
I thought the whole idea of repeatTests was to measure flakiness of a test. It would seem redundant to use that in conjunction with flakyTestsAttempts, since you'd want the raw data anyway. Or am I missing another use case?

A couple more small questions

since we're now merging the xml from the rerun directories (e.g. results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait-rerun_1/test_result_1.xml), do we still want to leave them in the results directory or delete them to avoid confusion?
do we tweak the name of the aggregate shard result xml file to imply that it was merged? (e.g. results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait/test_result_merged.xml)

I thought the whole idea of repeatTests was to measure flakiness of a test.

That's my use case for it. The idea is simply repeating tests though. If I wanted to check for something else, like performance measurement to average the metrics, we may want both repeat and flaky test attempts.

since we're now merging the xml from the rerun directories (e.g. results/2019-03-07_00-15-58.110000_IbGW/shard_0/NexusLowRes-28-en-portrait-rerun_1/test_result_1.xml), do we still want to leave them in the results directory or delete them to avoid confusion?

We should probably leave them since the folder structure is intended to mirror what's on GCS. We're not deleting them on GCS so deleting them locally would be surprising I think.

2. do we tweak the name of the aggregate shard result xml file to imply that it was merged?

Yeah if we are generating the file by merging XML then naming it appropriately makes sense.

the reruns are executed in parallel

how it will consider the last rerun then?

I think we'll download the results from all runs


Moulinette

I just updated to the newest version of Foundry VTT this am (Version 11 build 313). My Moulinette tools are not there any more. I tried uninstall and reinstall on all Moulinette packages to no avail. This was working on my prior v11 build a couple of days ago. Is this just an issue related to the update and Moulinette will be updated shortly to work with the latest version?

I also upgraded to build 313 and the module still works as expected. Could you check the console logs (F12) to see if there is any issue blocking Moulinette modules to load?

Ok. I am in the Moulinette discord server at the moment. My screen name is Dorothear.
Sent from my iPhone
On Oct 9, 2023, at 2:09 PM, Sven Werlen @.***> wrote:

Attachments have not been kept (by GitHub). I can't see them.
I'm also available on Discord (#dorgendubal). It might me easier for me to help you on this.
—
Reply to this email directly, view it on GitHubhttps://github.com/SvenWerlen/moulinette-core/issues/70#issuecomment-1753442386, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDEWVP375VW3OO3NH7TES2TX6Q4W5AVCNFSM6AAAAAA5Y5O76CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTGQ2DEMZYGY.
You are receiving this because you authored the thread.Message ID: @.***>

The issue was caused by the fact that FoundryVTT sometimes deactivates modules during a migration.
After re-enabling them under "Modules management", everything was back and running again.


Is it possible to change the visibility of sources?

Hi,
i was wondering if there is an option to set the visibility of sources in a scene. I animated a little overlay for a game, which should be visible when ingame and invisible when i'm in the main menu. I searched throught the sourcesservice.py and source.py files to find a method which does that, but i could not find anything. I also tried to set every "visible" option in the properties to false and then update the source properties with "set_properties_form_data", but that did'nt work either, the settings were updated but the overlay was still visible. Can you help me out with that?
Thanks

I am not 100% confident I have understood what you have tried; hopefully this will help.
Each scene contains scene nodes. Each scene node is either a folder or a scene item, which refers to a source. That way different scenes can contain the same source (e.g. your logo or a chat box).
So you don't make a source invisible, you make a scene item inside a scene invisible.

The steps are to find your scene (listallscenes.py or spin.py give examples of doing that.).
Find the appropriate scene item (spin.py gives an example of that.)
On the scene_item, you can call set_visibility(False). If you want more granularity (i.e. independently affect whether YOU can see it, whether the stream can see it or whether your local recording can see it, set_settings can be used. An example of the use of set_settings can be seen in ex_scenenodes.py)

Unfortunately, there is no test code for set_visible yet, so I can't point to an example of it working, but I just did an ad hoc test and it is making the item invisible. (I found a separate bug, but that probably won't affect you!)
If this doesn't help, and there is an actual bug with PySlobs, happy to reopen this.

Thank you very much.
I was not aware of scene items, i just used the scenes and sources as i would do it in streamlabs itself, so no subelements such as nodes or items.
But now everything works fine.
Thanks


Dragging selected text on Safari 6 shows the whole editor moving

OS: Mac OS
Browser: Safari 6.0.2
CodeMirror: 3.1+
Url: http://codemirror.net/demo/search.html
to reproduce:

select some text
drag the selected text

During the dragging the whole editor ( .CodeMirror-scroll ) will be moving with the mouse.
( Once dropped, only the selected text is re-positioned, as expected. )

Also happening in Epiphany 3.22.0 with Webkit 2.14.0.

This is a issue that's difficult if not impossible to solve with the fundamental approach currently taken by CodeMirror.
We are working on a rewrite (CodeMirror 6) that will address this issue, and we are currently raising money for this work: See the announcement for more information about the rewrite and a demo.
Note that CodeMirror 6 is by no means stable or usable in production, yet. It's highly unlikely that we pick up this issue for CodeMirror 5, though.


Routes do not fire with mapped within init action

If you do the following
add_action('init', function () {
    Routes::map('url', function () {});
});

The route is never invoked

Thanks @parisholley! I just saw yr PR come in; let's pick up the conversation there and then once things are good close the issue:
https://github.com/Upstatement/routes/pull/1

closed by https://github.com/Upstatement/routes/pull/2, thanks @parisholley!


Updated license file

This PR updates the license file to add the MIT license and include references to Manning Publications. Could you please review, @raulraja @juanpedromoreno? Thanks!

LGTM


E2E Tests: remove logoutUser step

Navigating to /wp-login.php?action=logout directly will return a 403 response, cluttering the test output.
The explicit logout prior to the login should not be needed, as one can login without that, and the login step would error if not working correctly.

This makes the e2e tests fail :( . Is there anyway of just clicking the link the admin bar to logout?

This makes the e2e tests fail :( . Is there anyway of just clicking the link the admin bar to logout?

I'd like to avoid the logout if possible. I should have never added that in my PR in the first place. WordPress allows logging in as a different user without logging out first.
Interestingly, the login works just fine like this on WordPress 5.7, but it fails on WP 5.3. So looking into that currently.

random thought today: try to delete all cookies before logging in


Count events that are read by not written because there's no sink defined for that route

Is your feature request related to a problem? Please describe.
I want to ensure that eventsRead and eventsWritten match, but if I'm using routes to filter events by not specifying sink, I cannot tell what part of the delta is from my route specific issues vs potential data loss from the writers.
Describe the solution you'd like
Emit a metric for events that are no-op'd from an empty route
Describe alternatives you've considered (Optional)
Don't emit eventsread for these scenarios. This is less desirable because I want to match eventsRead to the number of writes/records in my source system.
Emit as eventsWritten. This solves the problem of "correctness", but could be confusing if the number of items in OpenSearch actually differs from this amount.
Additional context
N/A

Sounds like a good idea.


Upstream Targets

Hello,
I have tried many versions of kong with Konga for implementing upstreams.
However i am not able to list/add the targets that are configured. I get Method not allowed error.
I am currently using kong 0.11.0 aws image (also tried docker kong image).
I was reading thru the issues reported and saw issue 81 with similar issue and was closed pointing to a kong issue.  When i use the kong rest api to add/update upstream/list they work fine. However they don't show up in konga.
When  i use the kong dashboard (another tool for kong administration), i do not see this issue.
That lists the targets and weights properly.
Is this something konga can address.
Thanks

I was able understand this issue from kong (issue 110 and https://github.com/Kong/kong/issues/2840) and the workaround.
I will wait for the next kong release.
Thanks

@mynameisgv , the only reason i haven't fixed it yet it is because its a Kong regression that they fixed but not yet published an official release with that fix.
Konga's proxy routes to Kong Admin Api are not hardcoded but dynamically generated.
So in that case is not simply an issue of just adding a / in one route. I would have to do some monkey patching explicitly for the target routes, publish a version and the undo that again when the version of Kong fixing that issu gets published.
That's why I decided to leave it as it is for now in hopes that they're going to publish a version soon.
If the de

@pantsel Thank for the update.
I did understand the issue. I will wait for the kong release with the permanent fix  instead of applying some hacks.
Thanks


Add a clear function to all backends

This supersedes the other half of https://github.com/mirage/irmin/pull/1015, along with https://github.com/mirage/irmin/pull/1070. The implementation is mostly unchanged from the original.

The CI failures here are to do with the fact that the tests try to clear the Branch, Commit and Node stores concurrently (here) and the implementation of clear tries to Ref.remove concurrently (here). This causes failures in git-unix.fs, via some combination of ENOENT and ENOTEMPTY on rmdir.
Serialising either parallel operation fizes the tests magically, but perhaps there's a bug here we should look into? (Either in the clear implementation or in OCaml-Git.) What do you think, @dinosaure & @samoht?

I think it would be nice it Git.Ref.remove would be resilient to concurrent calls. Is the issue a race between Git.Ref.remove and G.reset?

Looks like a race between G.reset on the node store and G.reset on the commit store (i.e. Node.clear and Commit.clear race with each other, but neither races with Branch.clear).
BEGIN CLEAR node
+32749237us irmin.http      [DEBUG] POST /clear/trees
S+133593us irmin.http-srv  [DEBUG] connection 16 closed
BEGIN CLEAR commit
+32749327us irmin.http      [DEBUG] POST /clear/commits
S+133743us irmin.http-srv  [DEBUG] new connection 17
reset begin
S+133814us git-unix.fs     [DEBUG] Dir.delete _build/test-db-git/.git/objects
S+133867us irmin.http-srv  [DEBUG] new connection 18
reset begin
S+133916us git-unix.fs     [DEBUG] Dir.delete _build/test-db-git/.git/objects
S+134274us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects/pack
S+134324us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects/pack
S+134475us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects/info
S+134511us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects/info
S+134655us git-unix.fs     [DEBUG] unlink _build/test-db-git/.git/objects/ef/c92c40591c9e7d03c1483f80f32e6be5999ba1
S+134676us git-unix.fs     [DEBUG] unlink _build/test-db-git/.git/objects/ef/c92c40591c9e7d03c1483f80f32e6be5999ba1
S+134725us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects/ef
S+134750us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects/ef
S+134926us git-unix.fs     [DEBUG] unlink _build/test-db-git/.git/objects/3a/1d47a6ba0c8d02e0cfa2aa8e7d4fcc797207c0
S+135011us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects/3a
S+135110us git-unix.fs     [DEBUG] create a new directory _build/test-db-git/.git/objects/info.
S+135218us git-unix.fs     [DEBUG] unlink _build/test-db-git/.git/objects/60/9e18d6f7ba0b482c772e53c45cc76aa3062c4b
S+135256us git-unix.fs     [DEBUG] create a new directory _build/test-db-git/.git/objects/pack.
S+135304us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects/60
S+135340us git-unix.fs     [DEBUG] Dir.delete _build/test-db-git/.git/refs
S+136169us git-unix.fs     [DEBUG] unlink _build/test-db-git/.git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391
S+136245us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/refs/heads
S+136270us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects/e6
S+136436us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/refs/tags
S+136486us git-unix.fs     [DEBUG] unlink _build/test-db-git/.git/objects/75/16192931292291d14548aaa06e47ce99f305a0
S+136511us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/refs
S+136536us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects/75
S+136599us git-unix.fs     [DEBUG] rmdir _build/test-db-git/.git/objects
S+136661us git-unix.fs     [DEBUG] [Dir.delete_dir] error: Unix.Unix_error(Unix.ENOTEMPTY, "rmdir", "_build/test-db-git/.git/objects")
reset end

Perhaps it's only necessary to call reset on one of these stores? It's a bit difficult to see through the functor maze :slightly_smiling_face:

yea it's probably not necessary to call reset on the 3 stores. Just calling it once should be enough -- or maybe it should take a global lock to avoid concurrent calls to G.reset (and we should check it's fixed in the next release of ocaml-git /cc @dinosaure)

I think it would be nice it Git.Ref.remove would be resilient to concurrent calls.

On my side, the new version of Git should not occur an error if it tries to remove a non-existent reference (for Store - including deletion of directories - and Mem impl.) - so I believe it's safe if 2 concurrent threads want to delete the same reference, at least, the implementation does nothing. I can add a test about that.

Is the issue a race between Git.Ref.remove and G.reset?

Again, it seems safe to do a concurrence between Ref.remove and Git.reset on the reference heap where the second action does not try to delete directories but only files (for the Store impl.) and the operation, as Ref.remove, is resilient if the file does not exist.
So, we can consider the issue as fixed for the next release of Git (I'm still on the split of my PR).

Deletion of a reference
Reset of the Git store

Would you mind fixing the Travis-CI issue (let* is not available on 4.07)? Happy to merge once everything is green!

CI passes now. I added dep on ocaml-syntax-shims from irmin-test to avoid going back to the pre-let-operator world :slightly_smiling_face:

Thanks!


Added some rebuses

Some new rebuses

Pull Request Test Coverage Report for Build 229

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.71%

Totals

Change from base Build 227:
0.0%

Covered Lines:
113

Relevant Lines:
125

💛  - Coveralls


Stites k2 testing

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Expected Result:
Describe what you think should've happened
Actual Result:
Describe what actually happened
Action Performed:
Break down in numbered steps
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork

Done


Assumption all labs are being run in Skillable

Most labs have the phrase
Note: Use the credentials of the User1- account listed on the Resources tab on the right side of the lab session window.
I know Skillable uses a right hand side resources tab, others do not
Indeed everything on godeploy is left hand side and no resources tab at all.
Now when this is in class its manageable but students get very easily confused (sadly) please write all instructions so they are ALH agnostic.
Cheers
Ed

Hi Ed,
pls feel free to submit the wording that you'd consider most suitable via a PR
rgds
Marcin

Hi marcin
I don’t have access to all ALH setups , so cannot assist to any level of accuracy I  am afraid …
However most of them embed the credential details in in line text with the ability to paste directly in to the VM
Using a specific option only available to customers of one platform is both confusing and leads to difficulties on remote courses where you can't wander round the class showing quickly.
I have transitioned to skillable on the last 6 months so it doesn't affect me but I do feel for accessibility it is essential
Yours
Ed
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: polichtm @.>
Sent: Saturday, November 30, 2024 12:46:23 AM
To: MicrosoftLearning/AZ-140-Configuring-and-Operating-Microsoft-Azure-Virtual-Desktop @.>
Cc: Ed Baker @.>; Author @.>
Subject: Re: [MicrosoftLearning/AZ-140-Configuring-and-Operating-Microsoft-Azure-Virtual-Desktop] Assumption all labs are being run in Skillable (Issue #301)
Hi Ed,
pls feel free to submit the wording that you'd consider most suitable via a PR
rgds
Marcin
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/AZ-140-Configuring-and-Operating-Microsoft-Azure-Virtual-Desktop/issues/301#issuecomment-2508759932, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFSCV5JLON3TLC4CRC3RR232DEDF7AVCNFSM6AAAAABSVG7FJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYG42TSOJTGI.
You are receiving this because you authored the thread.Message ID: @.***>


Avoid deployment-summary related crashes

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
When full deployment information isn't downloaded yet, there can be some undefined values where previously there were defined values. This needs to be accounted for everywhere, otherwise crashes occur.

If nysdot-hopr is causing conflicts I'd suggest having that PR block this one.