Provide openfast the motion of the floating platform through simulink (or some other way)

Hello
I have started learning Openfast. I want to provide openfast the motion of the floating platform through simulink (or some other way) at every time step of the simulation, and openfast will give me the reaction force of the floating platform. At the same time, hydrodynamics and mooring will not affect the movement of the floating platform.
Key points of clarification:
To achieve my target I need to learn the development side of Openfast but I want to know where should I start.
Is it a difficult job and possible to be done in 2 months.
Can anyone gives me key step I have to follow to get to my target (just mention main things I have to learn to get to my target)
I will highly appreciate the expert's remarks and suggestions. Thanks

Dear @cc200528,
Regarding prescribing the platform motion in the ElastoDyn module of OpenFAST, this topic has been discussed previously, e.g., see: https://github.com/OpenFAST/openfast/issues/617.
Regarding learning OpenFAST, see a related question answered here: https://github.com/OpenFAST/openfast/discussions/1339.  The new user documentation to be released in OpenFAST v4.0 is also a quite useful getting started guide: https://github.com/OpenFAST/openfast/pull/308.
Best regards,

Dear jjonkman,
Thank you for your answer. It was very helpful.
But I still have some questions, what I want to know is, If I want to use ExtPtfm module to prescribe an existing semi-submersible floating platform motion in r-test, what should I do? Do I need to produce the reduced matrices (M,C and K) and reduced loads for the floating platform using a high-fidelity FEM software.
Please give me help and provide me with the specific key steps of useing ExtPtfm module to prescribe an existing semi-submersible floating platform motion.

Dear @cc200528,
The ExtPtfm module of OpenFAST is useful if you are using a sequentially coupled workflow, in which you generate or are given the reduced matrices (M, C, K) and reduced loads (F), of the substructure.  NREL has not provided software for you to generate these matrices/vectors, but if you are using a sequentially coupled workflow, I would assume you are using other software that would generate these for you.  If you are not using other software, I would suggest modeling the substructure directly in SubDyn/HydroDyn/MoorDyn rather than using ExtPtfm.
FYI: A sequentially coupled workflow is more commonly used in fixed-bottom wind than it is in floating wind, given the more active coupling between the turbine and floater in floating wind.
Best regards,

Dear jjonkman,
I'm coming back to you to report my progress on this. I used to try adding ExtPtfm to a semisubmersible floating offshore wind system.The following is the Guyan input file.

I shut down five platform freedoms except PtfmPitch. I have a question, when I change the value of the K matrix or the C matrix, the result of PtfmPitch does not change, why?When I change the M matrix or F, the value of PtfmPitch changes.
Best regards,

Dear @cc200528,
I'm not sure.  I would expect the ExtPtfm mass, damping, stiffness, and force to all play a role in the platform-pitch response.
Best regards,


Can the delay to update state be decreased?

I use Home Assistant which, in turn, uses pyeconet for its Econet integration. I noticed that every time I tried to change my hot water heater's mode (e.g. from "eco" to "high_demand") there would sometimes be a significant delay of minutes until the change would actually happen. This is counter to the official Android app which makes the change immediately.
I scrubbed through the code and noticed that there appears to be a 300 second minimum amount of time required to elapse before any communication goes back to Rheem which likely explains this behavior I'm seeing.
Can you explain why this significant delay was chosen? It also results in long waits between temperature updates (5 minutes I guess). I'm interested to know whether it could possible be made to be customizable to be a shorter span of time or if there were other reasons behind the decision. Thanks.

The new API is using push updates and should be merged to HA soon.


Enable scripts/validate without golint

Depends on #1167

What's wrong with golint?

Nothing, just haven't taken the time to go through and fix all of the golint errors. All three are currently disabled, so I'd rather have gofmt and vet than nothing.


Adding validate command.

The validate command simply re-uses some of the functions from import_.py to validate the contents of a .repos file in vcstool or rosinstall format. This is useful for validating hand-modified files or for CI validation of vcstool-based workspace repos.

Adding more functionality.

The validate command now works for all client types except bzr (there is no "check repo existence/validity" command for Bazaar that I can find).

Before diving into the actual patch can you please clarify the scope of the new validate command and what is supposed to check for. A few things which come to my mind: well formed input file, referenced URLs exist / are fetchable, referenced versions exists.

Hey, Dirk. So, you have the general idea correct regarding the functionality. There is just one exception: I have not currently found a way to test to see if the referenced version exists on the remote repo. So, here is the current feature list for the validate keyword that I've been working off of in my head (mostly to support https://github.com/autowarefoundation/autoware/issues/2163):

Validate that the .repos or .rosinstall file is valid YAML syntax.
Validate that each endpoint URI exists and is reachable.
Validate that the endpoint is the correct type of repo or file as provided in the .repos or .rosinstall file.
Do all of the above without pulling the contents of the remote repo or file.

I have not currently found a way to test to see if the referenced version exists on the remote repo.

For specific hashes which are not HEAD of any of the branches I am not aware of a way to do that (purely focusing in git). But ls-remote will give you all branch and tag names which you could use to validate. And maybe print a message / warning if a hash is given which is not a HEAD.

@dirk-thomas - Since this only applies to git and is not always reliable (as you mentioned, only works if the hash is HEAD on a branch which, I would assume, is usually not the case since the intent to tying to a hash is usually to avoid new feature additions/changes), are you OK with accepting the PR in it's current form or do you want me to attempt adding this feature first?

It actually looks like Mercurial handles this even better than git. Mercurial has the command hg identify -r <REV> <URL> which will identify if a revision (branch, tag, or hash) exists on the remote. I'll work on adding at least these two.

@dirk-thomas - I have added version-based validation to hg and svn. I added pseudo-validation to git which will show a warning if the URL is valid but the contents of the version: attribute could not be verified. I also added a more comprehensive list2.repos file for testing the validate command. I'm not sure if you want to use this for the other tests as well but it contains one entry of each type and a version: tag of each type (hash, tag, and branch) for those that support them.

@dirk-thomas (I know you're super busy - just wanted to hit you up with a ping in case you forgot)

Thanks for getting to this. Everything in your feedback looks spot-on. Some of what you replaced has a lot to do with me not being as fluent in Python as I am in C++ so I appreciate the help. I'm good with the state of the PR if you are!

I added one more minor change to consolidate the test repos. The second repos file only contains additional hg/svn repos and the test runs for both: a0801a4cad266a1124ec9fb1e8d77388d9056a44.


"Unable to validate an undefined value" raised on a not required property

I have a swagger def like
    "MyType": {
      "type": "object",
      "required": [
        "name"
      ],
      "properties": {
        "name": {
           "type": "string",
        },
        "some": {
          "$ref": "#/definitions/Something"
        }
  }

validation of an object
{
 name: 'zzz'
 some: null
}

fails with "Unable to validate an undefined value: some'"
can it be a warning? The null value is not dissalowed by swagger def for the 'some' field, isn't it?

and same with arrays.

Nullable fields are not really allowed by the swagger definition.  You can leave a field out and if it is not required it will pass validation but you can only have a nullable field if you include 'x-nullable': true in the definition.
{
    required: [ 'id', 'count' ],
    properties: {
        id: {
            type: 'number',
            description: 'The object id'
        },
        count: {
            type: 'number',
            description: 'A number',
            'x-nullable': true
        }
    }
}

will allow validation of the object
{
    id: 1,
    count: null
}

I have added a unit test of your exact sample (fixed the object) and it does pass validation.  Can you send me a complete definition and a complete data object that fails.  The smallest failing sample would be best and then I can confirm if it is behaving as expected or not.

Thank you for clarifying! The object and model in your test perfectly replecate the problem so I have nothing new to send and setting 'x-nullable': true fixes it.


Clone all commits to load docs history correctly

Fetch all the commits to let hugo know file history.
Benefit:

Show docs history correctly
Minimize the publish commit. The deploy action will only modify those files being modified in current PR, not all the files.

LGTM


Import cupy leads to AttributeError?

Hello! I've just installed CuPy through pip and when I try to import it, or use it CUDA with SpaCy, I get this error :

import cupy
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\Jonathan\AppData\Local\Programs\Python\Python37\lib\site-packages\cupy_init_.py", line 57, in
from cupy import fft  # NOQA
File "C:\Users\Jonathan\AppData\Local\Programs\Python\Python37\lib\site-packages\cupy\fft_init_.py", line 1, in
from cupy.fft._fft import fft  # NOQA
File "C:\Users\Jonathan\AppData\Local\Programs\Python\Python37\lib\site-packages\cupy\fft_fft.py", line 9, in
from cupy.fft import config
File "C:\Users\Jonathan\AppData\Local\Programs\Python\Python37\lib\site-packages\cupy\fft\config.py", line 13, in
from cupy.fft._callback import get_current_callback_manager  # NOQA
File "cupy/fft/_callback.pyx", line 35, in init cupy.fft._callback
AttributeError: 'NoneType' object has no attribute 'split'

Do you guys know a fix for this? I can't seem to find anything on Google (I'm using CUDA 11.1)

Hi @JoPet123, this is a duplicate of #4352, which was just resolved recently (#4355). A couple of questions:

Did you install cupy via pip install cupy?
Are you on Windows?

The fix is to install the pre-built wheel, which in your case is pip install cupy-cuda111.

Hi @JoPet123, this is a duplicate of #4352, which was just resolved recently (#4355). A couple of questions:

Did you install cupy via pip install cupy?
Are you on Windows?

The fix is to install the pre-built wheel instead of building from source, which in your case is pip install cupy-cuda111.

Hello!
Yes I am on Windows and I did install it with pip install cupy.
Should I run pip uninstall cupy before installing cupy-cuda111?
Thank you

Yes, uninstall it first, or there'd be bizarre conflicts.

Thank you, it seems to be working, I'll close the issue now :)


Have some text on the volunteers dashboard similar to the text on the login screen

Thank you for your interest in volunteering with us! You can volunteer to help us with a specific project, event, going to the homeless shelters with us or helping us out around the office. Whatever it is, you are guaranteed to leave with a full heart and ear to ear smile!

Duplicate from #70


Add support for HuggingFace's TensorFlow models

New Feature:
This PR implements support for HuggingFace's TensorFlow models, solving #125.
It also adds a notebook that shows a use case with BERT.
Example of usage:
from speedster import optimize_model
from transformers import TFAutoModel, AutoTokenizer

# Make sure to always load a matching tokenizer and model!
tokenizer = AutoTokenizer.from_pretrained("bert-base-cased")
model = TFAutoModel.from_pretrained("bert-base-cased")

# Let's load some data and tokenize it
test_string = "This is a sentence!"
tokenized_inputs = tokenizer(test_string, return_tensors="np")

dynamic_info = {
    "inputs": [
        {0: "batch", 1: "num_tokens"},
        {0: "batch", 1: "num_tokens"},
        {0: "batch", 1: "num_tokens"},
    ],
    "outputs": [{0: "batch", 1: "num_tokens"}, {0: "batch"}],
}

# Run Speedster optimization
optimized_model = optimize_model(
  model, input_data=[tokenized_inputs], dynamic_info=dynamic_info
)

Minor changes:

Added a warning when dynamic_info is not provided with HuggingFace models
The final report on the optimized model now contains also the name of the compiler used
Fix a tvm issue when using the PyTorch implementation with gpu
Added dynamic shape support for optimized models converted from TensorFlow to ONNX
Fixed an issue that caused a wrong output shape for the models optimized with the neural compressor
Enabled openVINO compiler when using python 3.10

@valeriosofi why was the azure test cancelled?

@valeriosofi why was the azure test cancelled?

Because there was a bug, so there was no reason to perform the tests, they would have failed

Closes #125 and #103


Navigate to the GitHub page when clicking the profile image

The app should be able to navigate to the GitHub page somehow.

Maybe by clicking the profile image?

Thanks for the PR:https://github.com/hackjutsu/Lepton/pull/47


Crash List

Version
3.0.1 (412b94e)
Seed
R730-VFJM-XZHL5EXK9Y900N0JJWR1V08H10H5JZZZ89Z
Scenario
RE 3 (Jill)
Player Character
Jill(RE3)
What happened?
Event: Event Crash
Room: 202 Parking Lot Back
Enemies: Zombie Dogs
Carlos NPC: Regina(DC)
Occurs: Zombie Breaking through the Police Car Door causes crash It happens after hearing the sound of Carlos firing his assault rifle.
Event: Cutscene Crash
Room: 202 Parking Lot Back
Enemies: Zombie Dogs
Mikhail NPC: Barry (RE1)
Occurs: Beginning of Cutscene when you return to the Cable Car.
Event: Cutscene Crash
Room: 214 Power Station, 204 Power Station Front
Enemies: Nemesis, Hunters
Occurs: Using the Escape through the emergency door choice when the zombies are pounding at the power plant door, after the door opens and the cutscene starts theres no zombies(Hunters) around and the game crashes before Nemesis introduces them to his Rocket Launcher.
Event: Immediate Crash
Room:  CT Piano Room
Enemies: Nemesis
Occurs: From any door opening once you are inside the room it causes a crash regardless if Nemesis has broken through the glass.

@killerlilm do you have any saved games you can share before each of these crashes?

oh sure i have a few
biorand.zip

I've noticed the same crash on another seed at the same location and involving the same police car
Police Car Break Open Crash
Room: 202 Parking Lot Back
Enemies: Brain Sucker
Police Car break open crash
Room: 103 Warehouse Street
Enemy: Brain Sucker
I believe if there is any enemies that aren't zombies after the door opens it crashes immediately.


⚠ SceneTime has degraded performance

In 9b8479f, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1375 ms

Resolved: SceneTime performance has improved in 16051d9 after 10 minutes.


Annotation argument names are null

Hi :) I'm working on a project that uses kastree (even if it's no longer maintained) and I was wondering if anyone has ideas about why annotation argument names are null. Maybe my mistake?
This is the annotation class
@Target(
    AnnotationTarget.EXPRESSION,
    AnnotationTarget.FUNCTION
)
@Retention(AnnotationRetention.SOURCE)
annotation class ProduceVideo(
    val path: String,
    val length: Double = 10.0,
    val frameRate: Int = 30,
    val multiSample: Int = 0
)

And this is what I get when I println(node.anns)
[AnnotationSet(target=null,
  anns=[Annotation(names=[ProduceVideo], typeArgs=[],
  args=[
    ValueArg(name=null, asterisk=false, expr=StringTmpl(elems=[Regular(str=media/filters-201.mp4)], raw=false)),
    ValueArg(name=null, asterisk=false, expr=Const(value=5.0, form=FLOAT))])]),
    AnnotationSet(target=null, anns=[Annotation(names=[Code], typeArgs=[], args=[])]
)]

As you can see the name is null. Can @JvmName be of any help?
I tried looking into convertValueArg to see if I could obtain the name but it seems to be null there already
    open fun convertValueArg(v: KtValueArgument): Node.ValueArg {
        val nn = v.getArgumentName()
        if(nn != null) {
            println("---> ${v.name} ${nn.asName}")
        } else {
            println("---> ${v.name}")
        }
        return Node.ValueArg(
            name = v.getArgumentName()?.asName?.asString(),
            asterisk = v.getSpreadElement() != null,
            expr = convertExpr(v.getArgumentExpression() ?: error("No expr for value arg"))
        ).map(v)
    }

edit: just to make it clear, I would like to get the names path, length, frameRate and multiSample so I know what the value refers to.

I no longer have the time to support this library, sorry. You may find https://github.com/kotlinx/ast or similar to work better.

I understand. Good luck with your current projects! :-)


Multiple "see also" generates incorrect link

See see also for transduce

@raine fixed this in ramda/ramda.github.io#15. This reminds me, though, that I need to update the website to reflect the v0.15.1 changes.

Closing then


Failed on AbDb file: 1qd0_0H

Describe the bug
cdrclu failed on 1qd0_0H
To Reproduce
Steps to reproduce the behavior:

Running environment

Version used: 0.1.1
Operating system and version: Ubuntu 22.04

Input data: AbDb 1qd0_0H
Running commands:

$ cd tmp
$ cdrclu -db /AbDb -o tmp -c L3 1qd0_0H

Error

[01/02/24 14:59:25] WARNING  1qd0_0H chain chain_type='H' not exist ...                                                                                app.py:171
14:59:25 {/home/vscode/.conda/envs/abag_analysis/lib/python3.11/site-packages/cdrclass/examine_abdb_struct.py:282} [ERROR] examine_abdb_struct - pdb1qd0_0H chain_type='L' does not exist ... FAILED [MainThread]
                    WARNING  1qd0_0H chain chain_type='L' not exist ...                                                                                app.py:171
Traceback (most recent call last):
  File "/home/vscode/.conda/envs/abag_analysis/bin/cdrclu", line 8, in <module>
    sys.exit(app())
             ^^^^^
  File "/home/vscode/.conda/envs/abag_analysis/lib/python3.11/site-packages/cdrclass/app.py", line 930, in app
    main(args=args)
  File "/home/vscode/.conda/envs/abag_analysis/lib/python3.11/site-packages/cdrclass/app.py", line 906, in main
    results, metadata = worker(
                        ^^^^^^^
  File "/home/vscode/.conda/envs/abag_analysis/lib/python3.11/site-packages/cdrclass/app.py", line 779, in worker
    criteria, struct_df, metadata = process_single_mar_file(
                                    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vscode/.conda/envs/abag_analysis/lib/python3.11/site-packages/cdrclass/app.py", line 176, in process_single_mar_file
    criteria["chain_length_okay"] = assert_seqres_atmseq_length(struct_fp=struct_fp,
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vscode/.conda/envs/abag_analysis/lib/python3.11/site-packages/cdrclass/examine_abdb_struct.py", line 356, in assert_seqres_atmseq_length
    assert len(seq) >= len(atmseq[cid])
                           ~~~~~~^^^^^
KeyError: 'A'

Expected behavior
NA
Screenshots
NA
Additional context
NA

Issue Overview:
The file pdb1qd0_0H.mar (AbDb version: 20220926) contains chain mapping information that the current parsing logic misinterprets. Specifically, the hapten is being incorrectly processed as if it were a protein chain.

Encountered Problem:
The error arises when the parser incorrectly treats the hapten indicated in the file as a protein chain, which is not the intended behavior.
This issue could lead to inaccurate molecular structure representations and analyses.
Proposed Solution:
Need to refine the parsing logic to accurately distinguish between protein chains and non-protein entities such as haptens - 🤔 try biopandas.
Implementing a check that differentiates these entities before parsing can prevent such errors.
Additional Information:
Attached is a screenshot of 1qd0H_0H for visual reference:
Screenshot of 1dq0H_0H

Expected Outcome:
Enhance the accuracy of the chain mapping process and ensure that non-protein entities are not misclassified.


Extremely blurry panorama.

So im currently working on making a custom main menu, instead of a slideshow i really wanted to use a panorama. For some unknown reason the panorama comes out really blurred. I've tried all sorts of image resolutions and the images themselves are clear, however as soon as i set them up to be used as a panorama it becomes extremely blurred. Below ill add a sample of the image, and then a sample of how the panorama turns out.
I'm trying to use quarks panorama creator, even tried using the standalone version. I hear custom main menu has its own panorama creator but ive no idea how that works.

under panorama, I'm pretty sure there's a "blur" : "true" in your mainmenu.json. if you just deleted it entirely, try replacing it and typing "blur" : "false" instead.


[Feature] use QOS command to check if app service is ready

What is the purpose of the change
Add one QOS command to check application is ready or not!
Brief changelog
M dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
A dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/impl/Ready.java
M dubbo-plugin/dubbo-qos/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.qos.command.BaseCommand
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:

[] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[x] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

I will try again later


0.7.2 monitoring hangs in pytest

With the config added in benc-pytest-monitoring, 5762f434f518488881f3dae9cd18d29a25423c4c
pytest hangs after test completion:
$ pytest parsl/tests/test_bash_apps/test_apptimeout.py  --config parsl/tests/configs/local_threads_monitoring.py
============================= test session starts ==============================
platform linux -- Python 3.7.2+, pytest-4.0.2, py-1.8.0, pluggy-0.9.0
rootdir: /home/benc/parsl/src/parsl/parsl/tests, inifile: pytest.ini
plugins: xdist-1.26.1, ordering-0.6, forked-1.0.2, cov-2.6.1
collected 1 item

parsl/tests/test_bash_apps/test_apptimeout.py .                          [100%]

=========================== 1 passed in 3.65 seconds ===========================

The corresponding monitoring _hub.log shows:
2019-03-18 17:32:07.166 monitoring_hub:180 [INFO]  Monitoring Hub initialized
2019-03-18 17:32:07.774 monitoring_hub:232 [INFO]  Terminating Monitoring Hub
2019-03-18 17:32:07.774 monitoring_hub:235 [INFO]  Waiting Hub to receive all messages and terminate
2019-03-18 17:32:10.791 monitoring_hub:238 [INFO]  Received STOP from Hub
2019-03-18 17:32:10.791 monitoring_hub:241 [INFO]  Terminating Hub
2019-03-18 17:32:10.835 monitoring_hub:232 [INFO]  Terminating Monitoring Hub
2019-03-18 17:32:10.835 monitoring_hub:235 [INFO]  Waiting Hub to receive all messages and terminate

which looks as if the monitoring hub is trying to shut down twice.
Vague hypothesis: perhaps once when DFK is closed, and once when __del__ is called by the garbage collector?
It's possible that this doesn't happen in manual tests because the garbage collector probably never tries to collect a MonitoringHub (or anything else) because the process is ready to exit; but if my hypothesis is right, this might cause similar hanging behaviour in interactive use.

I think your hypothesis is right. Currently, MonitoringHub waits for a STOP message from Hub before exiting since we want all the messages to be received. For the first time, MonitoringHub can receive that STOP message from Hub, But for the second time, the Hub is already closed, and the MonitoringHub would never receive that message -- thus it hangs.

It's probably more in consistent with how other resources are managed in parsl to perform the shutdown when the DFK shuts down, and avoid using __del__ entirely


Dependabot improvements

Description
This PR contains two Dependabot related improvements:

Dependabot can generate commit messages that don't comply with our commitlint rules. To prevent those from failing our CI checks, we now ignore them from commit linting. This required changing the configuration file from JSON to JavaScript.

By default, Dependabot creates commits with type "chore". Changed the type to "deps" which is the correct type for dependencies in our projects. "chore" was particularly problematic because it doesn't cause release-please to create a new release.

Related Issue(s)
RAT-201

HAUKI-ADMIN-UI branch is deployed to platta: https://hauki-pr403-admin-ui.dev.hel.ninja :rocket::rocket::rocket:

e2e tests result is success for https://hauki-pr403-admin-ui.dev.hel.ninja :laughing::tada::tada::tada:


Updated Travis and Added support for PR services

Added New rubocop.yml (based on Hound.ci)
Updated Travis rubies
Fixed Rakefile
Added support for coveralls.io

See: https://github.com/stevendaniels/jibe_ruleset_bot/pull/2 for the nice PR checks available.


Update CMake files for rosidl_typesupport_opendds_cpp and restructure opendds_cmake_module

Change the CMake of the rosidl_typesupport_opendds_cpp package to:

Remove the irrelevant parts related to RTI Connext: check ABI, call to their server version of IDL preprocessor, generate their DDS type support files, etc.
Add files that will be generated by opendds_idl to the list of generated files.

Please provide a description for why this change is required. Also be sure to involve @kuznetsovmoci since these changes seem to revert a lot of what he changed especially when it comes to find_package(OpenDDS).

Please provide a description for why this change is required. Also be sure to involve @kuznetsovmoci since these changes seem to revert a lot of what he changed especially when it comes to find_package(OpenDDS).

I checked out PR #3 created by Mike for this repo. From what I saw, the changes in this PR for rosidl_typesupport_opendds_cpp do not revert Mike's changes. It makes incremental changes, especially to cmake/rosidl_typesupport_opendds_cpp_generate_interfaces.cmake, which will be executed when building a package with a custom msg file. There are some parts of the current CMakeLists.txt file that I think needs to be changed though.
I agree that my changes for the package opendds_cmake_module may need to be canceled to incorporate with OpenDDS's CMake module. In this case, we will still need to work on this package since some parts of it, e.g., the Python scripts under folder opendds_cmake_module/ currently don't do anything sensible at all.


Bluetooth: host: Add feature check for periodic adv functions

Adds a check for the BT_LE_FEAT_BIT_PER_ADV bit for each
function related to periodic advertising, including sync and
PAST transfer.
Also updated some of the similar return codes from ENOTSUP
to EOPNOTSUPP as that is more descriptive as to why the
function returns an error.
Signed-off-by: Emil Gydesen<EMAIL_ADDRESS>Fixed https://github.com/zephyrproject-rtos/zephyr/issues/33421

FWIW, based on POSIX EOPNOTSUPP and ENOTSUP may have the same value, so not sure we benefit much by trying to make this distinction: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html

FWIW, based on POSIX EOPNOTSUPP and ENOTSUP may have the same value, so not sure we benefit much by trying to make this distinction: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html

From your link:

Not supported (may be the same value as [EOPNOTSUPP]).

So it may, or may not. The value of the two errno codes in lib/libc/minimal/include/errno.h in Zephyr are not the same at this point.
I'm not saying that we should necessarily changed all occurrences of ENOTSUP to EOPNOTSUPP, but I still believe the latter is a better return code to use for this.

@Thalley yes, I know minimal libc distinguishes between these, however Zephyr does support building with other libc's as well. I don't have a particularly strong opinion on this and didn't intend to block this if you prefer to proceed with EOPNOTSUPP

I have a slightly preference for EOPNOTSUPP, but I guess if you and the other code owners (@joerchan  and @Vudentz ) prefer ENOTSUP then we'll just go with that.

From what i can tell EOPNOTSUPP seems to be a network error code since it's documentation mentions socket.
Do you prefer it to indicate not supported in the controller?
I don't have a strong opinion on this either but I would prefer it to be consistent in the usage, and we use ENOTSUP everywhere else currently apart from in PAST.

From what i can tell EOPNOTSUPP seems to be a network error code since it's documentation mentions socket.
Do you prefer it to indicate not supported in the controller?
I don't have a strong opinion on this either but I would prefer it to be consistent in the usage, and we use ENOTSUP everywhere else currently apart from in PAST.

My preference stems from the description of ENOTSUP in libc:
#define ENOTSUP 35      /* Unsupported value */

Personally I don't think value === function. For consistency we can use ENOTSUP
Regarding the "socket" naming, that reasoning could be applied to EBUSY as well:
#define EBUSY 16	/* Mount device busy */

Where most of our uses has nothing to do mount devices, but rather just an invalid state.
and ENOTCONN
#define ENOTCONN 57     /* Socket is not connected */

Which actually also uses the "socket" naming.
I don't want to fight excessively over this, and if both of you (@jhedberg  and @joerchan ) prefer ENOTSUP, I'll update that (Also needs to be updated in the recently merged VOCS implementation).

Yes, I saw that. The wording of the manpage is different though: ENOTSUP         Operation not supported (POSIX.1-2001)
In general the wording don't always match up with how we use it, I can see that. I think unless we want to have 2 different types of "not supported" we should just use the one.

Yes, I saw that. The wording of the manpage is different though: ENOTSUP Operation not supported (POSIX.1-2001)
In general the wording don't always match up with how we use it, I can see that. I think unless we want to differentiate between 2 different types of "not supported" we should just use the one.

That would be the manpage on Linux, right? Which uses POSIX.1-2001 (which funny enough, w.r.t. @jhedberg comments about the value, state that ENOTSUP and EOPNOTSUPP should have distinct values).
Anyways, I'll change all uses of EOPNOTSUPP to ENOTSUP for consistency. I'll also fix the uses in VOCS and my AICS PR.


ROX-19474: Edit email subject/body template for reports

Description
This PR adds the ability to edit the email subject and body for scheduled reports
Screenshots

You'll notice that there is a new field for a delivery destination. Clicking on the button link will open up a modal to edit the email subject and body. We set a default value for both.

Also hovering over the tooltip will display a hint

An empty subject and body will indicate that the default subject and body should be used. We display the default text as placeholders in the input fields

You can edit the email subject and body in the modal. Notice the character count below the input field. There is also a "Clear to default" button that will clear the input field and display the default text again using the placeholder.

You can click on the "Preview" tab to see a preview of your email. You can check what will be displayed depending on whether CVEs were found or not. Also, depending on whether you used the default template or a custom one, you'll see a difference in the email body text

You'll notice that the text changes when you edit the email subject and/or body and apply your changes.

The tooltip will also change

@sachaudh per discussion led by Charmik,
The following use case is for user who's reading the email not the email template in the application.
Not sure if we already covered it but note that this is an empty state message to the email body,
We should replace the configured default/custom message with the following when no vulnerabilities are found. The user would see this message in their email platform.
"Red Hat Advanced Cluster Security (RHACS) for Kubernetes has identified no workload CVEs in the images matched by the following report configuration parameters."

@dvail @vjwilson @zhenpesky please take a look at the screenshots for the updates to this PR and let me know if you're good with them. I made a few changes to the UX because of UI reasons so let me know if those are acceptable:

There were issues with updating the default email subject text whenever the report name and/or scope name changed and also being able to determine if the email subject was indeed the default or actually a custom value. I decided to simplify things by making things more explicit. If the emailSubject or emailBody is empty, then we are using the default text for that field.
The modal will now show a placeholder text for the email subject and email body showing the default text
The Restore default button is changed to a Clear to default button. When clicked, it will clear the input field to show the default value using the placeholder text

@dvail @vjwilson @zhenpesky please take a look at the screenshots for the updates to this PR and let me know if you're good with them. I made a few changes to the UX because of UI reasons so let me know if those are acceptable:

There were issues with updating the default email subject text whenever the report name and/or scope name changed and also being able to determine if the email subject was indeed the default or actually a custom value. I decided to simplify things by making things more explicit. If the emailSubject or emailBody is empty, then we are using the default text for that field.
The modal will now show a placeholder text for the email subject and email body showing the default text
The Restore default button is changed to a Clear to default button. When clicked, it will clear the input field to show the default value using the placeholder text

@sachaudh I think think is fine the only thing is that we should keep it consistent with the phase "Reset to default" which was recently implemented in the notifier for resetting the distribution list.

@sachaudh I think for the first time trigger to open the email template modal, the 'Apply' button should be disabled since no changes have been made. If users have entered the custom value but reset back to default, enable the 'Apply' button because this behavior of leaving it empty by cleaning up the text / resting the text is considered a change. users then need to be aware of this change they made by clicking the 'Apply' button to take effect.

@zhenpesky @dvail @vjwilson I updated the screenshots with the latest changes. It should be ready to be reviewed again

@zhenpesky @dvail @vjwilson I updated the screenshots with the latest changes. It should be ready to be reviewed again

@sachaudh The "Canel" button should be a link button instead of a secondary button. Every else looks good to me.


[DOC]: Example for extending the conductor to get workflow status listener

What are you missing in the docs
No Documentation is available that shows how can we extend conductor and use its listeners. I want to extend the conductor for Workflow Status Listener
Proposed text
Need proper documentation and an example on how conductor can be extended and custom code can be send with conductor deployment

Hi @karanbhola , We will update the documentation for this. however, in the meantime, we always welcome community contribution. These are the high-level steps to extend the workflow status listener.

Implement the interface WorkflowStatusListener in the conductor-community.
These are some of the samples from the community,


Improve AtlasTexture's Documentation

See https://github.com/godotengine/godot/issues/5660#issuecomment-1257704120.
Reduces repetition, rearranges sentences to improve structure, attempts to be more impersonal ("clips" -> "is_clipped") and consistent with other more common classes.
Also remove outdated snippet from the description ("cannot be tiled in nodes such as TextureRect" is no longer true in master).

I see what you did there! https://github.com/godotengine/godot/pull/66509

Thanks!


s3: clarify function of s3:prefix condition key

Makes clear for newcomers to IAM, who may not know that policies always filter requests, that the condition filters requests from being allowed instead of filtering keys from the result by prefix.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for taking the time to submit a PR. This page with the list of actions, resources, and conditions that we publish in the IAM user guide is automated based on content from each service so we can't edit it. It just gets overwritten the next time that I publish. I will pass your feedback along to the S3 team to see if they want to implement the feedback.

I passed ticket #P36711468 to the S3 team with your feedback.


ModuleNotFoundError: No module named 'requests' when executing jax.distributed.initialize() on TPU Pods

Description
import jax
jax.distributed.initialize()

Error:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/ayaka/nfs_share/venv/lib/python3.11/site-packages/jax/_src/distributed.py", line 168, in initialize
    global_state.initialize(coordinator_address, num_processes, process_id, local_device_ids)
  File "/home/ayaka/nfs_share/venv/lib/python3.11/site-packages/jax/_src/distributed.py", line 47, in initialize
    clusters.ClusterEnv.auto_detect_unset_distributed_params(
  File "/home/ayaka/nfs_share/venv/lib/python3.11/site-packages/jax/_src/clusters/cluster.py", line 55, in auto_detect_unset_distributed_params
    coordinator_address = env.get_coordinator_address()
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ayaka/nfs_share/venv/lib/python3.11/site-packages/jax/_src/clusters/cloud_tpu_cluster.py", line 54, in get_coordinator_address
    return cls._get_worker_endpoints()[0].split(':')[2] + ':8476'
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ayaka/nfs_share/venv/lib/python3.11/site-packages/jax/_src/clusters/cloud_tpu_cluster.py", line 74, in _get_worker_endpoints
    return get_metadata('worker-network-endpoints').split(',')
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ayaka/nfs_share/venv/lib/python3.11/site-packages/jax/_src/clusters/cloud_tpu_cluster.py", line 23, in get_metadata
    import requests  # pytype: disable=import-error
    ^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'requests'

I think requests should be automatically installed when installing JAX.
What jax/jaxlib version are you using?
jax 0.4.14
Which accelerator(s) are you using?
TPU
Additional system info
No response
NVIDIA GPU info
No response

Thanks - I think that makes sense. It looks like requests is only imported in jax/_src/clusters/cloud_tpu_cluster.py, so it would probably be better as a TPU-only requirement. Perhaps we could include it in in the optional requirements for jax[tpu]?
Tagging @skye who knows a lot more about cloud TPU runtimes – what do you think?

I agree it should be required for jax[tpu]. I think it used to be at some point actually, but was removed because we didn't need it anymore (but now we do!).


Repackage Fleet microservice as an Appsody application

This is a work-in-progress to repackage the fleet microservice as an Appsody application (named fleet-ms).
So far:

Merged the existing project with a newly generated Appsody project (using the java-openliberty stack and default template).
Copied the basic env entries from the Helm chart into the app-deploy.yaml, with default values that should work in a dev environment.
Fixed integration tests for this microservice.
Changed service name in fleet-ms/chart/fleetms/templates/service.yaml as Appsody generates a new service name.
Updated the github actions script, .github/workflows/dockerbuild.yaml, to use Appsody build.
Removed $(app.location) in the server.xml file to be fleetms.war

Notes:
For now we have an interim docker image in app-deploy.yaml, however once you run the github actions pipeline, a new image will be created in your specified image registry. We can then update the app-deploy.yaml image.
To do:

Update the README
Remove the Helm chart
PRs on refarch-kc integration tests and for kc-ui service name update to make this work with the other microservices.
Move fleet-ms and voyages-ms into their own separate repositories.

Being labeled as a work-in-progress, I am assuming that this is not ready to be merged yet? Or do you think we should merge it and then you will rebase your changes for the ToDo items on top of this merged code base?

@osowski This can be merged now, same as previous ones.

Can you update the GitHub Actions CI workflow as well, so that once this is merged it will kick off with an Appsody build?
Reference: https://github.com/ibm-cloud-architecture/refarch-kc-ms/blob/master/.github/workflows/dockerbuild.yaml#L78-L97

@osowski I have updated the workflow dockerbuild.yaml.


Dynamic Supervisor OIDC Clients proposal

Technical Proposal: "Dynamic Supervisor OIDC Clients"
Release note:
NONE

Thanks Ryan. I've left a bunch of thoughts as I read through - apologies in advance for anything I've misunderstood (a few times later points you made clarified my earlier questions) or for which I lack the relevant background :)

@absoludity I'm not sure why, but GitHub won't let me reply to your comment which said "That would be different to most other client definitions, wouldn't it? (not that it's a reason not to do so)".
I'm not sure what you mean by that comment. Could you explain? Thanks!


Uncaught TypeError: Cannot read property 'stop' of undefined

Looks like there might be a regression with v1.1.0.
The line that errors out is: https://github.com/tsuyoshiwada/sweet-scroll/blob/b0fee7600f3d0ae94d898e73eb366d736e8e6bcb/src/sweet-scroll.js#L264
The code that caused it is here:
  const input = document.querySelector(/* snip */);
  const container = document.querySelector(/* snip */);
  if (input && container) {
    const scroller = new SweetScroll({ duration: 200 }, container);
    scroller.toElement(input);
  }

Thanks for Issues 😃
I think the DOMContentLoaded has not been called.
It does not work in the following code?
// ...

if (input && container) {
  const scroller = new SweetScroll({
    duration: 200,
    initialized() {
      this.toElement(input);
    }
  }, container);
}

This code is called long after DOMContentLoaded is fired, it looks like this regression might be from your recent change to make the getContainer callback fire asynchronously (https://github.com/tsuyoshiwada/sweet-scroll/blob/28a3b90bd80e79b1d1f4c125c7bff0970f5ec0a7/src/sweet-scroll.js#L463).

I could be wrong but I think that makes a lot of the example on the README no longer valid

Using the initialized option does work btw, but I think this qualifies as a breaking change that might affect other people using the library like I am.

Oh, that makes sense...
I was just worried point to when want to update to v1.1.0.
I need your advice.
Currently, the inside get to container element waiting for DOMContentLoaded and load events.
By abolishing it entirely, can eliminate the asynchronous processing, such as initialized().
README will be in the following such description.
document.addEventLlistener("DOMContentLoaded", () => {
  const sweetScroll = new SweetScroll({ /* options */ });
  // ...
}, false);

Thank you for your valuable comments.

If probably went the above changes, it is likely to be released as v2.0.0.

I like that idea, I think it's pretty rare that people will be trying to get things to scroll before the DOM is actually loaded. It's generally a best practice for people to avoid running scripts until the DOM has actually been built anyways.

I think so, too. I heard that and was relieved 😃
Scheduled to v2.0.0 release that next week.
Thanks!

Hi @nickclaw.
Just it has been updated to v2.0.0.
Please check when you have time.
Thanks!

@tsuyoshiwada looks pretty good, unfortunately still getting the same error -- just for a different reason.
It looks like that in 2.0 if the container isn't found to be scrollable, this.tween is never set. In my case the container's children aren't always big enough to enable scrolling so it fails. If that's your intention that's fine, although in my opinion it'd be nicer to silently do nothing in that case.

Thanks you for check.
If possible would like to issue an error if can not find a scrollable element. (Because it will hinder debugging unless an error occurs.)
However, if there seems to be a need, I will consider a little.

If possible, I'd be happy if you give me the minimum sample code that can not find a container. (I think that it would be better if a fundamental solution could be made.)

@nickclaw Error handling was improved with v2.0.1.
Will keep silent unless explicitly specify the outputLog option.
Please check when you have time.

Sweet I'll check it out. Thanks a lot for all your help.

Your welcome. Thank you for giving me good advice ✨


#233 - saving subscribers for new features.

Still needs to do a validation of the email in the client, handle same email entered more then once.

O.K, I added the subscription to get new features under the "make discussion".

Sorry for all the comments... I hope they make sense. If you think otherwise, please let me know.
Once these are fixed we can merge.

No problem at all. I did all the changes but the feature-dialog modal still doesn't work without the show method. I pushed the latest changes. When I try to open the modal dialog, I see that the screen fades but the modal won't come up. What might be the problem?

See my one comment. If it still doesn't work then using show() is fine too, though.

I tried - still doesn't work.

That's fine, but it still seems to be like it should be feature-dialog-template there, no?

O.K, I brought back the show function and now removed the href and now it works fine. Otherwise it just didn't work.


Order of "changes in Pull Request" viewlet is wrong.

Closing as a duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/6


Can't pull module published in harbor

What version of CUE are you using (cue version)?

$ cue version
v0.8.0

Does this issue reproduce with the latest stable release?
yes
What did you do?
I published a module to harbor container registry (v2.7.1-6015b3ef) with:
env CUE_REGISTRY=harbor.local/playground/cue
env CUE_EXPERIMENT=modules
exec cue mod publish v0.0.1
published<EMAIL_ADDRESS>
I see the module published under the path cue/github.com/{org}/cue in harbor and v0.0.1 in the tags.
Then I tried to use the module
env CUE_REGISTRY=harbor.local/playground/cue
env CUE_EXPERIMENT=modules
env CUE_DEBUG=http
exec cue mod tidy

-- module.cue --
module: "github.com/{org}/app/config"
language: {
	version: "v0.8.0"
}

-- app.cue --
package config

import (
	"github.com/{org}/cue@v0"
)

What did you expect to see?
The module fetched from harbor and imported into app.
What did you see instead?
{"time":"2024-03-22T10:02:27.370752-04:00","level":"INFO","msg":"http client->","info":{"id":1,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/tags/list?n=1000","contentLength":0,"header":{"User-Agent":["Cue/v0.8.0 (cmd/cue) Go/go1.22.1 (darwin/arm64)"]}}}
{"time":"2024-03-22T10:02:27.370791-04:00","level":"INFO","msg":"http client->","info":{"id":2,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/{org}/tags/list?n=1000","contentLength":0,"header":{"User-Agent":["Cue/v0.8.0 (cmd/cue) Go/go1.22.1 (darwin/arm64)"]}}}
{"time":"2024-03-22T10:02:27.370808-04:00","level":"INFO","msg":"http client->","info":{"id":3,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/{org}/cue/tags/list?n=1000","contentLength":0,"header":{"User-Agent":["Cue/v0.8.0 (cmd/cue) Go/go1.22.1 (darwin/arm64)"]}}}
{"time":"2024-03-22T10:02:27.518144-04:00","level":"INFO","msg":"http client<-","info":{"id":2,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/{org}/tags/list?n=1000","statusCode":401,"header":{"Content-Length":["152"],"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:27 GMT"],"Docker-Distribution-Api-Version":["registry/2.0"],"Set-Cookie":["sid=d4d1e1db91b5e5879ed84f22382894dd; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"Www-Authenticate":["Bearer realm=\"https://harbor.local/service/token\",service=\"harbor-registry\",scope=\"repository:playground/cue/github.com/{org}:pull\""],"X-Request-Id":["61f8023e1a502faae8913655dbe21d14"]},"body":"{\"errors\":[{\"code\":\"UNAUTHORIZED\",\"message\":\"authorize header needed to send HEAD to repository: authorize header needed to send HEAD to repository\"}]}\n"}}
{"time":"2024-03-22T10:02:27.518204-04:00","level":"INFO","msg":"http client->","info":{"id":4,"method":"GET","url":"https://harbor.local/service/token?scope=REDACTED&service=REDACTED","contentLength":0,"header":{"Authorization":["Basic REDACTED"],"User-Agent":["Cue/v0.8.0 (cmd/cue) Go/go1.22.1 (darwin/arm64)"]}}}
{"time":"2024-03-22T10:02:27.523084-04:00","level":"INFO","msg":"http client<-","info":{"id":1,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/tags/list?n=1000","statusCode":401,"header":{"Content-Length":["152"],"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:27 GMT"],"Docker-Distribution-Api-Version":["registry/2.0"],"Set-Cookie":["sid=76463f38177d3e80f8d5685dfc89c551; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"Www-Authenticate":["Bearer realm=\"https://harbor.local/service/token\",service=\"harbor-registry\",scope=\"repository:playground/cue/github.com:pull\""],"X-Request-Id":["7456c7606085394ee5740eefc551b071"]},"body":"{\"errors\":[{\"code\":\"UNAUTHORIZED\",\"message\":\"authorize header needed to send HEAD to repository: authorize header needed to send HEAD to repository\"}]}\n"}}
{"time":"2024-03-22T10:02:27.523092-04:00","level":"INFO","msg":"http client<-","info":{"id":3,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/{org}/cue/tags/list?n=1000","statusCode":401,"header":{"Content-Length":["152"],"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:27 GMT"],"Docker-Distribution-Api-Version":["registry/2.0"],"Set-Cookie":["sid=097b00277e1189f5f1d2cad11172d932; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"Www-Authenticate":["Bearer realm=\"https://harbor.local/service/token\",service=\"harbor-registry\",scope=\"repository:playground/cue/github.com/{org}/cue:pull\""],"X-Request-Id":["1485588f115f3c10b8f7244f2929f805"]},"body":"{\"errors\":[{\"code\":\"UNAUTHORIZED\",\"message\":\"authorize header needed to send HEAD to repository: authorize header needed to send HEAD to repository\"}]}\n"}}
{"time":"2024-03-22T10:02:28.061769-04:00","level":"INFO","msg":"http client<-","info":{"id":4,"method":"GET","url":"https://harbor.local/service/token?scope=REDACTED&service=REDACTED","statusCode":200,"header":{"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:28 GMT"],"Set-Cookie":["sid=a1bf44f99b2496bfa19f7e650b950cbe; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"X-Request-Id":["2ec9fd10119cfba0a582d286f08718df"]},"body":"{\"token\":\"[REDACTED]\",\"access_token\":\"\",\"expires_in\":1800,\"issued_at\":\"2024-03-22T14:02:28Z\"}"}}
{"time":"2024-03-22T10:02:28.061853-04:00","level":"INFO","msg":"http client->","info":{"id":5,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/{org}/tags/list?n=1000","contentLength":0,"header":{"Authorization":["Bearer REDACTED"],"User-Agent":["Cue/v0.8.0 (cmd/cue) Go/go1.22.1 (darwin/arm64)"]}}}
{"time":"2024-03-22T10:02:28.061879-04:00","level":"INFO","msg":"http client->","info":{"id":6,"method":"GET","url":"https://harbor.local/service/token?scope=REDACTED&service=REDACTED","contentLength":0,"header":{"Authorization":["Basic REDACTED"],"User-Agent":["Cue/v0.8.0 (cmd/cue) Go/go1.22.1 (darwin/arm64)"]}}}
{"time":"2024-03-22T10:02:28.112703-04:00","level":"INFO","msg":"http client<-","info":{"id":5,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/{org}/tags/list?n=1000","statusCode":200,"header":{"Content-Length":["62"],"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:28 GMT"],"Set-Cookie":["sid=f3c4439928e9209f17e0bbcf4e95cc24; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"X-Request-Id":["00ec9faafaa53ee4ec58e786639e624f"]},"body":"{\"name\":\"playground/cue/github.com/{org}\",\"tags\":[\"v0.0.1\"]}\n"}}
{"time":"2024-03-22T10:02:28.570383-04:00","level":"INFO","msg":"http client<-","info":{"id":6,"method":"GET","url":"https://harbor.local/service/token?scope=REDACTED&service=REDACTED","statusCode":200,"header":{"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:28 GMT"],"Set-Cookie":["sid=272a9ecff71586d11ec668384e519372; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"X-Request-Id":["5ea9921514c507802ebf59d8e7db2318"]},"body":"{\"token\":\"[REDACTED]\",\"access_token\":\"\",\"expires_in\":1800,\"issued_at\":\"2024-03-22T14:02:28Z\"}"}}
{"time":"2024-03-22T10:02:28.570458-04:00","level":"INFO","msg":"http client->","info":{"id":7,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/tags/list?n=1000","contentLength":0,"header":{"Authorization":["Bearer REDACTED"],"User-Agent":["Cue/v0.8.0 (cmd/cue) Go/go1.22.1 (darwin/arm64)"]}}}
{"time":"2024-03-22T10:02:28.570549-04:00","level":"INFO","msg":"http client->","info":{"id":8,"method":"GET","url":"https://harbor.local/service/token?scope=REDACTED&service=REDACTED","contentLength":0,"header":{"Authorization":["Basic REDACTED"],"User-Agent":["Cue/v0.8.0 (cmd/cue) Go/go1.22.1 (darwin/arm64)"]}}}
{"time":"2024-03-22T10:02:28.619798-04:00","level":"INFO","msg":"http client<-","info":{"id":7,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/tags/list?n=1000","statusCode":404,"header":{"Content-Length":["93"],"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:28 GMT"],"Set-Cookie":["sid=6b7c1fcc5a1b5ebe57855e47e59b994c; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"X-Request-Id":["47fbdf786a2ae80604d959f6ea855839"]},"body":"{\"errors\":[{\"code\":\"NOT_FOUND\",\"message\":\"repository playground/cue/github.com not found\"}]}\n"}}
{"time":"2024-03-22T10:02:28.752204-04:00","level":"INFO","msg":"http client<-","info":{"id":8,"method":"GET","url":"https://harbor.local/service/token?scope=REDACTED&service=REDACTED","statusCode":200,"header":{"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:28 GMT"],"Set-Cookie":["sid=0156ad25d07b49d032a441b44b4ca674; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"X-Request-Id":["cc1423c433fabbebfc253fb3bee0ec85"]},"body":"{\"token\":\"[REDACTED]\",\"access_token\":\"\",\"expires_in\":1800,\"issued_at\":\"2024-03-22T14:02:28Z\"}"}}
{"time":"2024-03-22T10:02:28.752272-04:00","level":"INFO","msg":"http client->","info":{"id":9,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/{org}/cue/tags/list?n=1000","contentLength":0,"header":{"Authorization":["Bearer REDACTED"],"User-Agent":["Cue/v0.8.0 (cmd/cue) Go/go1.22.1 (darwin/arm64)"]}}}
{"time":"2024-03-22T10:02:28.803437-04:00","level":"INFO","msg":"http client<-","info":{"id":9,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/{org}/cue/tags/list?n=1000","statusCode":200,"header":{"Content-Length":["70"],"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:28 GMT"],"Set-Cookie":["sid=5720dfea1980f1a9adf06e5c8f0e0a48; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"X-Request-Id":["f357d92a0bb3a6bef7578487967a88a5"]},"body":"{\"name\":\"playground/cue/github.com/{org}/cue\",\"tags\":[\"v0.0.1\"]}\n"}}
failed to resolve "github.com/{org}/cue@v0": 404 Not Found: not found: repository playground/cue/github.com not found

In one of the responses you can actually see the version but it still fails
{"time":"2024-03-22T10:02:28.803437-04:00","level":"INFO","msg":"http client<-","info":{"id":9,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/{org}/cue/tags/list?n=1000","statusCode":200,"header":{"Content-Length":["70"],"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:28 GMT"],"Set-Cookie":["sid=5720dfea1980f1a9adf06e5c8f0e0a48; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"X-Request-Id":["f357d92a0bb3a6bef7578487967a88a5"]},"body":"{\"name\":\"playground/cue/github.com/{org}/cue\",\"tags\":[\"v0.0.1\"]}\n"}}

It seems like this issue here is that the Harbor registry is returning a not-found error code that isn't part of the OCI specification.
Specifically in this response aboe:
{"time":"2024-03-22T10:02:28.619798-04:00","level":"INFO","msg":"http client<-","info":{"id":7,"method":"GET","url":"https://harbor.local/v2/playground/cue/github.com/tags/list?n=1000","statusCode":404,"header":{"Content-Length":["93"],"Content-Type":["application/json; charset=utf-8"],"Date":["Fri, 22 Mar 2024 14:02:28 GMT"],"Set-Cookie":["sid=6b7c1fcc5a1b5ebe57855e47e59b994c; Path=/; HttpOnly"],"Strict-Transport-Security":["max-age=15724800; includeSubDomains"],"X-Request-Id":["47fbdf786a2ae80604d959f6ea855839"]},"body":"{\"errors\":[{\"code\":\"NOT_FOUND\",\"message\":\"repository playground/cue/github.com not found\"}]}\n"}}

We can see the the error code is NOT_FOUND, which isn't one of the error codes mentioned in the spec.
Technically this should probably be considered a bug in the registry implementation, but we should be able to work around it by inspecting the HTTP status as well as the error code.


split sql_process_store into multiple files

Why make this pull request?
split a large file into smaller ones
What has changed
no logic change
[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

API change: ...
Golang SDK change: ...
Server Component 1: ...
Server Component 2: ...

How to test this pull request?
no change in logic, just move to other files
Checklist before merge
[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch
[ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch
[ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

Can we split for all the APIs to be consistent?

xxx_complete_wait_until.go
xxx_complete_execute.go
xxx_common.go


fix: tags may be string

tags can be string
such as:
  ---
  tags: blog
  ---

#544

Hey, I have actually fixed this in my local 1.9.0 branch, however I like the other changes you have made so I will go ahead and merge this. Thanks for taking the time to fix this :)

Is it possible for tags to be a number type? Maybe it would be more robust to check if it not an array rather than checking if it is a string?

You're right. Thanks for pointing that out!

Thanks, this looks pretty good I'll go ahead and pull it in :)


Text visibility and copy button issue

Description
Text visibility and copy button issue on meshery catalog page.
The meshery Ui and Meshery Cli text isn't visible in the dark mode and the copy button isn't working.
Link : https://meshery.io/catalog -> import any catalog item
Expected Behavior
The text should be visible and the copy button should work as intended.
Screenshots
https://github.com/meshery/meshery.io/assets/91362589/7fb6ae91-fb1b-48ff-9ace-46dfa48ae5ee
Enviroment:

OS: Mac Linux Windows
Browser: Chrome Safari Firefox
Version:
Device: Desktop Mobile

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

can i work on this issue

@DarrenDsouza7273 Yeah go ahead

In addition to the issue that has pointed out, the colors used in the tabbed menus is atrocious.

thanks @leecalcote

@vishalvivekm am currently working on the copy button facing some issues with it but the text visibility is done, i dont think so the "copied" text is necessary as for now so should i just create a pr for the text visibility? and then later on we can discuss regarding the "copied" text which gets triggered when we press the copy button.

@vishalvivekm we can have a discussion regarding the "copied" text on trigger during the weekly meeting

That'll be really helpful @DarrenDsouza7273,
Would you please add this as an agenda item into the meeting minutes ?

@vishalvivekm i definitely will give me like 10 mins

@vishalvivekm should i create a pr for the text?

You can create a pr for the text visibility and push the copy button commits to the same branch. If that makes sense to you...

@vishalvivekm should i create a pr for the text visibility?

@DarrenDsouza7273 Thanks, there are two PRs open.
Would you check if they do cover and propose a fix for this issue.
#1148 #1114 // @Savio629

#-1148 is related to catalog #-1114 is a pr related to this same issue. Thanks for pointing out that the pr for the issue was already created. @vishalvivekm Should we close this issue?

Yes closing this issue is ideal @Savio629
Please offer your reviews gents, on the PR proposing a fix @Savio629 @DarrenDsouza7273 : https://github.com/meshery/meshery.io/pull/1151

Closing as completed via #1153


[SPARK-46535][SQL][3.4] Fix NPE when describe extended a column without col stats

What changes were proposed in this pull request?
Backport  [#44524 ] to 3.4 for [SPARK-46535][SQL] Fix NPE when describe extended a column without col stats
Why are the changes needed?
Currently executing DESCRIBE TABLE EXTENDED a column without col stats with v2 table will throw a null pointer exception.
Cannot invoke "org.apache.spark.sql.connector.read.colstats.ColumnStatistics.min()" because the return value of "scala.Option.get()" is null
java.lang.NullPointerException: Cannot invoke "org.apache.spark.sql.connector.read.colstats.ColumnStatistics.min()" because the return value of "scala.Option.get()" is null
	at org.apache.spark.sql.execution.datasources.v2.DescribeColumnExec.run(DescribeColumnExec.scala:63)
	at org.apache.spark.sql.execution.datasources.v2.V2CommandExec.result$lzycompute(V2CommandExec.scala:43)
	at org.apache.spark.sql.execution.datasources.v2.V2CommandExec.result(V2CommandExec.scala:43)
	at org.apache.spark.sql.execution.datasources.v2.V2CommandExec.executeCollect(V2CommandExec.scala:49)
	at org.apache.spark.sql.execution.QueryExecution$$anonfun$eagerlyExecuteCommands$1.$anonfun$applyOrElse$1(QueryExecution.scala:98)
	at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$6(SQLExecution.scala:118)
	at org.apache.spark.sql.execution.SQLExecution$.withSQLConfPropagated(SQLExecution.scala:195)
	at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$1(SQLExecution.scala:103)

Does this PR introduce any user-facing change?
How was this patch tested?
Add a new test describe extended (formatted) a column without col stats
Was this patch authored or co-authored using generative AI tooling?
No

@MaxGekk @yaooqinn @LuciferYang @guykhazma , this is a backport to 3.4 for #44524 can u please review this

@MaxGekk I have enabled GAs in my fork


PYNQV2.4 sdbuild error

PYNQ version: v2.4
Board name: zynq7020

I set the environment on ubuntu16.04, petalinux 18.3 vivado 18.3 for PYNQ v2.4. While I was make the PYNQ image, it throw an error and ask me to check the version of qemu. It is a new VM environment, and my qemu version is 2.8.0, I don't know where is wrong.
alinx@ubuntu:~/Downloads/PYNQ/sdbuild$ sudo make BOARDS=zynq7020  PREBUILT=./prebuilt/bionic.arm.2.4.img

[sudo] password for alinx:

/usr/bin/qemu-arm-static -version | fgrep 2.8.0
Makefile:299: recipe for target 'qemu_check_arm' failed
make: *** [qemu_check_arm] Error 1

alinx@ubuntu:~/Downloads/PYNQ/sdbuild$ qemu-arm-static -version
qemu-arm version 2.8.0
Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers

I delet the checkenv and

PYNQ version: v2.4
Board name: zynq7020

I set the environment on ubuntu16.04, petalinux 18.3 vivado 18.3 for PYNQ v2.4. While I was make the PYNQ image, it throw an error and ask me to check the version of qemu. It is a new VM environment, and my qemu version is 2.8.0, I don't know where is wrong.
alinx@ubuntu:~/Downloads/PYNQ/sdbuild$ sudo make BOARDS=zynq7020  PREBUILT=./prebuilt/bionic.arm.2.4.img

[sudo] password for alinx:

/usr/bin/qemu-arm-static -version | fgrep 2.8.0
Makefile:299: recipe for target 'qemu_check_arm' failed
make: *** [qemu_check_arm] Error 1

alinx@ubuntu:~/Downloads/PYNQ/sdbuild$ qemu-arm-static -version
qemu-arm version 2.8.0
Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers


Finetuning benchmarking experiments

This branch was used in running QLoRA benchmarking experiments using different GPU setups and configs. It also includes few LoRA experiments.

Added DDP as an option.
Default to 128 samples in alpaca_sample.
Added sql dataset for training.
Constant lr_scheduler is now a no-op to avoid the cpu-offloading overhead, which requires more investigation. In early experiments we've observed that having lr_scheduler.step() while using cpu-offloading slows down training by a factor of 1.5.
Added wd to adamw optimizer.
Refactor auto-wrap policy to its own function like other utilities.
Added a custom qlora module (adapted from PEFT), in early benchmarking experiments it is observed to be more memory efficient compared to PEFT but a longer training run might be required to verify there isn't any bugs.
Set SDPA as the attention implementation, with torch 2.2 release it supports flash-attn 2 implementation and best kernel will be picked by default. This might not be that necessary since HF already uses it as the default for the known models but it is more of a comment.

import torch
# Will throw kernel not available error when attn_mask is used.
# Optionally use the context manager to ensure one of the fused kernels is run
query = torch.rand(32, 8, 128, 64, dtype=torch.float16, device="cuda")
key = torch.rand(32, 8, 128, 64, dtype=torch.float16, device="cuda")
value = torch.rand(32, 8, 128, 64, dtype=torch.float16, device="cuda")
attn_mask = torch.ones(128, dtype=torch.bool, device="cuda")
with torch.backends.cuda.sdp_kernel(enable_flash=True,
                                    enable_math=False,
                                    enable_mem_efficient=False):
    torch.nn.functional.scaled_dot_product_attention(query,key,value,attn_mask=attn_mask)

Turn gradient clipping off by default, similar to lr_scheduler.step() this introduces a significant slow down (3x-4x) when used with cpu-offloading, llama-recipes uses a scheduler which is only stepped at the end of each epoch. For fancier schedulers like cosine annealer that step with param updates, this needs more investigation.

Looking good! @warner-benjamin want to skim then merge?


Shortcut crashes when removed from SuperView and ColorScheme set to null

Describe the bug
Manifests in TGD when trying to delete a Shortcut

Error
Value cannot be null. (Parameter 'scheme')
   at System.ArgumentNullException.Throw(String paramName)
   at System.ArgumentNullException.ThrowIfNull(Object argument, String param
Name)
   at Terminal.Gui.ColorScheme..ctor(ColorScheme scheme)
   at Terminal.Gui.Shortcut.SetColors()
   at Terminal.Gui.Shortcut.set_ColorScheme(ColorScheme value)
   at TerminalGuiDesigner.SelectionManager.Clear(Boolean respectLock) in D:\
Repos\TerminalGuiDesigner\src\SelectionManager.cs:line 105
   at TerminalGuiDesigner.Operations.DeleteViewOperation.DoImpl() in D:\Rep
...

To Reproduce
Steps to reproduce the behavior:

Add a Shortcut to view area
Select it with rectangle selection
Press Delete
See error

Expected behavior
SetColors should handle this situation
Basically more null handling in SetColors please such that if base.ColorScheme is null it doesn't bomb

@tznind when you file bugs, can you please set the label, project, and milestone so I don't have to do it?


ci: setup semantic release

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

v2.0.1
GitHub release

Your semantic-release bot :package::rocket:


Turn on text-based chat

Hi Devs,
I have an iOS application where I use 'Twilio Video iOS SDK' and configure the twilio-video-app-ios. Now I want to add "interactive live streaming" to this application. It says on Twilio Live that you also support text-based chat, but I couldn't see anything about text-based chat in the twilio-live-interactive-video. How can I turn on text-based chat?

I'm just a user of this, so this may be inaccurate, but I had interactive chat by default when I only updated the environment keys with my Twilio info, did a serverless:deploy, then connected as a host (created new room) and a speaker. I suspect you only connected additional users as viewers? They may have considerably less features.

Hi, the ReactJS app and the reference backend has implemented the text chat feature that uses Twilio Conversations. This is not yet implemented for the iOS app in this repo.
The create-stream endpoint in this repo does configure a new conversation. And all the endpoints to create or join a stream have a chat grant added to the token that is returned. And so you should be able to implement chat on iOS using the conversations SDK with this token. You could look at the ReactJS code for an example of how to use the conversations SDK. There is also some example iOS code for the conversations SDK although it is not integrated into a video app.

Hey @HakanSAYAR - we have added chat to the iOS app, powered by Twilio Conversations. Thanks again for the feature request, and please let us know if there's anything else!


blocked by CORS policy has ramped up

Javier,
I'm not sure if Instagram is purposely causing trouble with acquiring remote instagram feeds but I've been watching the messages on my JS console and their changes to CORS policy have increased the number of JS "Instagram Feed: Request failed" errors dramatically.
On Monday everything was fine but on Wednesday I noted that several installations of jquery.instagramFeed were reporting a single fail and then rendering the feed. Today, I am able to render the feed but all 8 attempts are reporting failure in my JS console.
On a related note, I built and maintain the Drupal integration module for your JS library and there are currently some ~3000 installations so I am motivated to keep an eye on things.
Cheers,
Andrew

It is Google. The problem is temporary. I have got it in one moment, but now everything is ok.

It's Google? I'm not sure that I understand how that's occurring but I do see that now some feeds that were showing 8 errors and not resolving are now showing with a single error and one is now showing with no errors.
Is there anything we can do to mitigate the issue?
Thanks,
Andrew

Is there anything we can do to mitigate the issue?

I am afraid not. The current solution (several tries, alternative google proxy and caching) is the best we have.

are now showing with a single error and one is now showing with no errors.
You can reduce the number of errors in the console by changing the host parameter.
https://github.com/jsanahuja/jquery.instagramFeed/issues/125#issuecomment-792589859

Thanks for pointing out the host parameter. I hadn't seen that earlier. I'll give that a shot and see how it responds.
Cheers,
Andrew

@mahotilo, thanks for the tip about the host parameter. I believe that is the fix. I've updated my module to use it and it seems to have completely fixed it.
I'll close the issue.
Cheers,
Andrew

The real workaround is proxying the request and use GraphQL (`user_id`` parameter)

Awesome! I'll have to do some R&D locally on this but that might be something I add to the Drupal module. There are some really great features in your library. It makes adding and configuring a feed a breeze.
Thanks,
Andrew


add backend logic to disable/enable course subscriptions

store disabled_courses as set of course ids in admin table in DB
set up disable_course, enable_course endpoints
create add_disabled_course, remove_disabled_course methods in Database class
when constructing list of waited classes for email notifications, do not add class to list if its corresponding course is disabled
add is_course_disabled flag to disable/enable course switches and show/hide disabled label on course page

Disable Course Subscriptions
https://user-images.githubusercontent.com/63625700/130334728-51104cb3-39e1-4070-bb33-33439f582a8a.mov
Enable Course Subscriptions
https://user-images.githubusercontent.com/63625700/130334791-5492a378-2aa7-459a-b67f-635abf98bdd5.mov

thanks for the video tests as well :)


Add CIS v1.3.0 section 2.1 to 2.15 docs

Is your feature request related to a problem? Please describe.
CIS section 2.1 to 2.15 benchmark and controls should have supporting documents.
Describe the solution you'd like
Add documents for section 2.1 to 2.15 benchmark and controls.
Describe alternatives you've considered
N/A
Additional context
N/A

duplicate


Make sure toNormal is eventually done even if Count is called often

Our app, for various reasons, always calls Count after adding a bunch of items. This has the unfortunate side effect that toNormal never gets called - because Count calls mergeSparse and this resets the size of tmpSet to zero. Thus the size of tmpSet is never big enough for maybeToNormal to trigger toNormal.
The end result is we have a sparseList of millions of items, and Count is very slow (hundreds of milliseconds).
This patch fixes this by checking if the threshold is reached during Count.

Thanks for the comment, I moved the check and made the other necessary changes. Also, I added a test that shows the issue we had is fixed.

Thanks so much!


Adding modern components such as carousel, cards, modals, popovers, ...

What do you think about adding modern components (that's how I call them) in the framework? Such as popovers, carousel, cards, ...
Also, what do you plan for your framework? Something more complex and complete like Bootstrap, Semantic UI or stay simple with minimal things such as what you already implemented?
Let me know what you think about those components, I would like to implement them if you are okay.

Hey TotomInc! In terms of complexity, I'd like to keep JavaScript of the framework for now and focus on it being a simple(ish) CSS framework. It will never be as bare bones as something like http://getskeleton.com/, but PaperCSS could stand to benefit from popovers, cards, and other "modern components".
So go for it! I'd love to see you add those.

My idea too was to keep out Javascript of the framework, I'll try to do some popovers and cards.

Sounds great, excited to see it!

It's currently looking like that. Need to finish a few things and I'll send a PR if that's okay for you.

That looks awesome! Love it!

@TotomInc what are your thoughts on cards? I think that's the next low hanging fruit for modern components. Thank you again for making the popovers, they look great!

I'll see what I can do with cards. 👍

A basic card look like this.

Can this ticket be closed now?

Yes this ticket can be closed and if there are more moderns components to add, I'll do it as a new feature.


Missing module property in package.json

The version of Ajv you are using
6.4.0
The environment you have the problem with.
Browser
Your code (please make it as small as possible to reproduce the issue).
Not a code problem.
The problem occurs when I try to minify my app assets in a reactjs env. The issue is described at create-react-app.
There is a simple fix for it though. Just add the module property in package.json, alongside main, that points to "dist/ajv.min.js".
Ideally, the main should point to the CommonJS dist file for nodejs compatibility (as the other party also suggests).
I can make a PR if needed.
If your issue is in the browser, please list the other packages loaded in the page in the order they are loaded. Please check if the issue gets resolved (or results change) if you move Ajv bundle closer to the top.
Results in node.js v4.
Results and error messages in your platform.

The problem occurs when I try to minify my app assets in a reactjs env. The issue is described at create-react-app.

That is some other issue, as this package only uses ES5 - there is no ES6 code here.

@epoberezkin the issue is described in the create-react-app readme I referenced, the error is just a simple message.
It started happening after I added this lib as dep, so I investigated and figured out that adding the module property to this lib's package.json fixes it (as the create-react-app suggested it would).
After digging deeper, I discovered it is caused by the uri-js dependency that this lib has (lib/compile/resolve.js#L3))).
For some reason, create-react-app uses the esnext from uri-js and it fails.
Adding the module prop to this lib's package.json seemed to have fixed the problem during build, but perhaps I should open an issue on the uri-js side or create-react-app.

I've just tried it out and the issue doesn't occur if I use 6.3.0.
It's a bit strange though, because the uri-js's main points to a compatible commonjs source, but for some reason, create-react-app picks up the other source (the esnext).
I'll investigate further and keep you updated.

@rolandjitsu I think it maybe an issue in create-react-app, I'd say it's worth reporting to them. Looks like they may be not picking it correctly from sub-dependencies.
I am not certain whether exposing build artefacts via package.json is the correct solution, some other opinions on the issue could be helpful here. To me it seems that the place for them is your app config (or html head) and you should not be using them as part of build process, only if you use them separately.
In this way if you just load ajv.bundle.js as a separate script file in the browser, whether from the package, or from cdnjs, it will "just work", as it exposes globals to be compatible with the most module systems. So you should be able to simply use global Ajv and also use require('ajv') in the browser.
If you are including ajv in your bundle it doesn't seem correct to use a bundled file, you should use the file in package.json main property. If some build system can't work with it, the issue should be addressed in that build system rather than here.

@epoberezkin Most likely yes, I will create a repo and report it.
I agree with that the main should still point to the source, but adding the browser property is actually helpful for build systems that look for a bundle that's compatible in the browser. Check the specs for it.

Just to chime in: we're using ajv in very standard webpacked and babeled environment.  The uri-js version used ends up importing with argument spread. It's a bit wild that the only module we need to include in transpilation is uri-js because of ajv and its incompatibility with ie11. Is anyone looking at this issue at the moment?
uri-js has 2 open issues at the moment, both pertaining to this, but they haven't budged either in the 24 days the issue has been open.
Just wanted to chime in, and say that this isn't just a create-react-app issue, it's a bit more widespread for anyone wanting interop with ie11

I started to use ajv last weekend in my create-react-app projects and stumbled on this as well. create-react-app can not minify uri-js.
I'm using version 6.5 of ajv.
Would be nice if this could be solved.

I would like this fixed too. I have too include /node_modules\/uri-js/ in my webpack javascript rule when consuming this library.

Ajv will pick it up, no update is necessary - npm update should fix it for you (or reinstall)

Thanks for the tip @epoberezkin, Ajv is working fine with create-react-app now!


Dev

For this React capstone project I build a mobile web application to check a list of metrics (numeric values) that we create making use of React and Redux.

Select an API that provides numberic data about a topic that I liked
Build one page with a list of items that could be filtered by some parameters
Build one page for the item details
Home page

When the page loads, the webapp shows the list of categories that could be filtered out by some parameter.
Along with the category name, you will display some numeric values per category that come from the API.
When the user clicks (or taps) on a category item, the application navigates to the details page.
Details page
In the details page, the webapp retrieves data from the API to show detailed data in the category.
When the user clicks on the "Back" button (<), the user navigates to the home page.

Create unit tests for pure functions in your Redux code.
Create integration tests for your application using the React Testing Library.
Style my components to match the design provided.
Add search filter bar
Deploy the project and test for final details.
Record a video for your project.
Create a good README and PR description.

Hello @rloterh ,
Thanks for the review but please I don't know how to go about it.
Could you please be of help.

@Christabelle143
You can simply create a new Pull Request, with the merge request from feature branch into dev branch. You can then use same Pull Request title and description, and then resubmit your project using the newly created Pull Request link.
Cheers! 😃

hey @rloterh
Please i still don't undersatnd you

I still don't understand how am to go about it.

@Christabelle143
We have discussed this via slack.
Cheers! 😃


pip install pyenv fails on OSX

pip install fails to install on OSX both on python 2.7.12 and python 3.5.2 (pip install and pip3 install)
Python 2:
$ pip install pyenv
Collecting pyenv
  Downloading pyenv-20150113.1.tar.gz
Building wheels for collected packages: pyenv
  Running setup.py bdist_wheel for pyenv ... error
  Complete output from command /usr/local/opt/python/bin/python2.7 -u -c "import setuptools, tokenize;__file__='/private/var/folders/z9/wg6pkrvs1l9c5vq01vfzsy4w0000gn/T/pip-build-BxfZRo/pyenv/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" bdist_wheel -d /var/folders/z9/wg6pkrvs1l9c5vq01vfzsy4w0000gn/T/tmpjzhB1gpip-wheel- --python-tag cp27:
  running bdist_wheel
  running build
  installing to build/bdist.macosx-10.11-x86_64/wheel
  running install
  Cloning into '/Users/<user>/.pyenv'...
  Cloning into '/Users/<user>/.pyenv/plugins/pyenv-doctor'...
  Cloning into '/Users/<user>/.pyenv/plugins/pyenv-installer'...
  Cloning into '/Users/<user>/.pyenv/plugins/pyenv-pip-rehash'...
  Cloning into '/Users/<user>/.pyenv/plugins/pyenv-update'...
  Cloning into '/Users/<user>/.pyenv/plugins/pyenv-virtualenv'...
  Cloning into '/Users/<user>/.pyenv/plugins/pyenv-which-ext'...

  WARNING: seems you still have not added 'pyenv' to the load path.

  # Load pyenv automatically by adding
  # the following to your profile:

  export PATH="$HOME/.pyenv/bin:$PATH"
  eval "$(pyenv init -)"
  eval "$(pyenv virtualenv-init -)"

  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/private/var/folders/z9/wg6pkrvs1l9c5vq01vfzsy4w0000gn/T/pip-build-BxfZRo/pyenv/setup.py", line 33, in <module>
      cmdclass=dict(install=PyenvInstall),
    File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 151, in setup
      dist.run_commands()
    File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 953, in run_commands
      self.run_command(cmd)
    File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 972, in run_command
      cmd_obj.run()
    File "/usr/local/lib/python2.7/site-packages/wheel/bdist_wheel.py", line 232, in run
      self.distinfo_dir)
    File "/usr/local/lib/python2.7/site-packages/wheel/bdist_wheel.py", line 364, in egg2dist
      raise ValueError(err)
  ValueError: Egg metadata expected at build/bdist.macosx-10.11-x86_64/wheel/pyenv-20150113.1-py2.7.egg-info but not found

  ----------------------------------------
  Failed building wheel for pyenv
  Running setup.py clean for pyenv
Failed to build pyenv
Installing collected packages: pyenv
  Running setup.py install for pyenv ... error
    Complete output from command /usr/local/opt/python/bin/python2.7 -u -c "import setuptools, tokenize;__file__='/private/var/folders/z9/wg6pkrvs1l9c5vq01vfzsy4w0000gn/T/pip-build-BxfZRo/pyenv/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /var/folders/z9/wg6pkrvs1l9c5vq01vfzsy4w0000gn/T/pip-1nGV5T-record/install-record.txt --single-version-externally-managed --compile:
    usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
       or: -c --help [cmd1 cmd2 ...]
       or: -c --help-commands
       or: -c cmd --help

    error: option --single-version-externally-managed not recognized

    ----------------------------------------
Command "/usr/local/opt/python/bin/python2.7 -u -c "import setuptools, tokenize;__file__='/private/var/folders/z9/wg6pkrvs1l9c5vq01vfzsy4w0000gn/T/pip-build-BxfZRo/pyenv/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /var/folders/z9/wg6pkrvs1l9c5vq01vfzsy4w0000gn/T/pip-1nGV5T-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /private/var/folders/z9/wg6pkrvs1l9c5vq01vfzsy4w0000gn/T/pip-build-BxfZRo/pyenv/

It would be nice to be able to pip-install pyenv and not rely on brew, git-cloning or system package managers.

https://github.com/yyuu/pyenv/issues/387#issuecomment-261269695


Rake task for nuking temp files

What it says on the tin. I'm just adding a rake task for making it easy to delete files inside the Fake AWS root directory.

Very cool :+1:


Business glossary search problem

Affected module
Yes, it impact the UI.
Describe the bug
Hey all. I would be happy if you help me. We have version 12 of Open Metadata installed and having trouble searching for business terms. The problem is that when you create 2 identical business terms in different glossaries and then delete one of them, the search does not return results, although one of the terms is still in the Glossary, but the search does not find it. Reindexing ElasticSearch didn't help.
To Reproduce
Screenshots or steps to reproduce:
I created 2 business glossaries and added 2 term crowns to them (screenshot #1). I then deleted the business glossary called Business Term 2 and searched for the term Restruct. As a result, OMD gives an error (screenshot #2).
I guess you can now try to search for the term Restruct in the search and see this problem in sandbox v13.0.

Expected behavior
I expected the search to work correctly and return the desired business term.
Version:

OS: [e.g. Windows 10]
OpenMetadata version: [e.g. 12.0 и 13.0]

Additional context

support link https://openmetadata.slack.com/archives/C02B6955S4S/p1670498595714649

@harshach,
Record video for you with error protection. I hope it helps
https://user-images.githubusercontent.com/120117425/206653529-3acb9e4d-24fe-48e9-a515-fa3aebf7621a.mp4

Thanks @AnnaShevchuk23 fixed the issue
https://user-images.githubusercontent.com/38649/206757470-e89464a7-008b-426f-a965-db281b23494d.mov


manifest: mcuboot upgrade

Upgraded mcuboot to version which have following issue
fixed:
Redundant 'source "$(ZEPHYR_BASE)/Kconfig.zephyr"
in 'boot/zephyr/Kconfig'
https://github.com/JuulLabs-OSS/mcuboot/pull/649
Within this version upgrade the default swap algorithm for nRF devices
was changed to move swap instead of swap using scratch.
https://github.com/JuulLabs-OSS/mcuboot/pull/645
Moved mcuboot code to non-deprecated GPIO API if it available.  This avoids
deprecation warnings in the build.
https://github.com/JuulLabs-OSS/mcuboot/pull/648
Signed-off-by: Andrzej Puzdrowski<EMAIL_ADDRESS>

rebased, please merge as master currently point a mcuboot version form PR :(

@nvlsianpu please rebase so that CI is rerun after the topic-gpio merge

Whoops; yeah, I'd assumed this would make it in before topic-gpio.

Merging as hotfix


[Cleaning] Code clean and refactoring depricated code

Released in https://github.com/afrostalin/FireNET/commit/b87af7e55e8decd741138e81d7bf3a3608e306b2

Released in https://github.com/afrostalin/FireNET/commit/b87af7e55e8decd741138e81d7bf3a3608e306b2


Update Button Border Radius

Pills style border radius for buttons

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.644%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1984

Relevant Lines:
2031

💛  - Coveralls


Fortran Best Practice: Type Casting in Callbacks

The chapter Type Casting in Callbacks needs some work.

No links to external gists or pastebin entries, the document must be self-contained
Generally more text actually explaining what is going on in the sections
Better flow of explanation rather than multiple example

The chapter starts by saying
"There are essentially five different ways to do type casting, each with its own advantages and disadvantages.
The methods I, II and V can be used both in C and Fortran. The methods III and IV are only available in Fortran. The method VI is obsolete and should not be used."
If you are going to refer to items by number, you should provide a numbered list. What are the 6 methods? Looking at the headings, I see 7:

Work Arrays
General Structure
Private Module Variables
Nested functions
Using type(c_ptr) Pointer
transfer() Intrinsic Function
Object Oriented Approach

Best is to rewrite the whole chapter and focus on a few of the available approaches which we find are best practice. At least we should remove the obsolete methods from this chapter.


Spanish Translation Review

Hi @rehrar, I've been working in a spanish translation for the Monero Revuo. I created a branch called Translation. Hope this is the correct way on working. I also have been working with ErCiccione in the monero localization group and have learned how to work with github(I'm still are...). I was the same guy from last year who told you that was interested in working on spanish translations. Hope you remember. If you have any comments please let me know. Thank you for all your work. :)

Anything else that needs to be done for this to be merged?

The translation needs reviewing. I will be adding the pdf file during the day. Just adding the images.

Hi @rehrar, I found some spelling mistakes and made the corrections. Also, we(spanish community) have been working on the monero terminology for coherent translations, so I made some changes in the latest update. Hope everything is okay :).

Hi @erciccione,
Was taking a look at the PR and the Monero Ecosystem - Revuo Monero branch and it has not been updated with the pdf and .sla file translation. I'm just leaving you a reminder about these files so they can be reviewed by any other contributor, or if the can be merged with the Revuo Monero so anyone can see the files and use them. I'm not sure if I need to do anything else. Thanks :).

I'm not sure of what you mean @lh1008 , i see the files correctly. What we need is @rehrar to merge this PR to update them

Thank you @rehrar, sorry for the pressure. I thought there was something missing out. :) Great day!


Allow youtu.be URLs as input

Add support for the youtu.be URLs in addition to the existing full URL support.

Feature added.


Update box infos

Updates the box info module with the new layouts proposed by UX team.
The biggest difference in relation of the old info box component is the fixed position for titles and buttons, respectively on the top and bottom of the box. It was necessary to create a new HTML structure to make it happen and to the old not to be deprecated.
So I created three new classes inside the box (.ls-box-head, .ls-box-body, .ls-box-footer) to improve it's control. The head and footer are positioned with absolute position with a fixed height and the body's height is variable with the content.
The boxe's height now are controlled with flexbox, just for moderns browsers. We recommend all users to upgrade their's browsers to get a better experience.
Close #1587

:+1:

@itumoraes good solution. Flex box is life!
One question: Where there is an example with ls-box-footer ?

@deividmarques You will find an example on /documentacao/componentes/box-info/


Using gulp to uglify, lint and test

Have you thought about using gulp to minify, lint and test this excellent module? Let me know and I can send a PR with a custom gulp script.

I haven't yet decided, but it's something I would like to do on my own accord (I'm a little particular on how I set up task runners). I appreciate the offer and the other fixes/suggestions.

No problem whatsoever =)


Filtering by Active status

It would be great to see only active votings. Currently a user has to scroll through all votings to find active ones.

@dns7030 We are working on something and plans for this in the near future. Thanks

For further feature request please see: https://features.snapshot.org/feature-requests


Use .gitkeep instead of multiple empty .gitignores

discussed in #12

I just read about it as well, it's explained well in https://stackoverflow.com/questions/7229885/what-are-the-differences-between-gitignore-and-gitkeep

I think that we really don't want those files at all, /bootstrap and /storage are created during Laravel app runtime, for caching and other stuff.
I was kinda wrong to add empty .gitignores, should we add storage and bootstrap to our main .gitignore in the root of project?

Yes! Something like https://github.com/github/gitignore/blob/main/Laravel.gitignore

Good point, that's probably how Laravel development on git is supposed to work.