[WebUI] Add QuickPhrasesComponent, MiniBarComponent, and related app states

Fixes #165.
The QuickPhrasesComponent is composed of PhraseComponents that are controlled by gaze-clickable scroll-up and scroll-down buttons. See screenshot:

Currently, the phrases input to QuickPhrasesComponent instances are hardcoded in the AppComponent. Follow-up PRs will retrieve them from a remote API endpoint.
The AppComponent now has a number of AppState enum values controlling its overall state. See the left side of the screenshot above for the left nav buttons that allows the user to switch between the different quick phrase sets and the abbreviation expansion mode. The button at the bottom-left corner minimizes the app to a gaze-clickable button that can expand the app back to the previous non-minimized state. See screenshot:

These buttons are all gaze-clickable.
Related changes in this PR:

Unit tests are added for the new components: QuickPhrasesComponent and MiniBarCompoent
Unit tests are updated for the existing component: AppComponent
In ExternalEventsComponent, allow unregistering of previously registered keypress callbacks. This is now necessary because AbbreviationComponent can now get destroyed and re-created in the AppComponent depending on its state. So we want to avoid leaking previous callback registrations.
In cefsharp.ts API, allow specification of a container (parent) view port (DOMRect), so that elements that are invisible due to scroll state can be skipped when registering gaze-clickable button boxes. This is used in QuickPhrasesComponent when there are many elements causing overflow and scrolling. See screenshot above.

Thanks for the review, @antonkastgoogle.


DVISA-596: (feature) localization

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature: Localization for numbers and strings

What is the current behavior? (You can also link to an open issue here)
German localization was applied to all numbers

What is the new behavior (if this is a feature change)?
The library must get its localization initialized, then the localized numbers and strings will be applied

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes, the library needs to get its localization initialized

Other information:

We agreed to apply the changes to a previous master version


Change box back to non-lazy creation

While it did save time on the initial ingest of data, there have been may side cases where lazy loading caused issues down the road in hard to predict ways. For 4.0 I am planning to change back to convert on store.

Fixed in 4.0


added feature for admin users to be able to change topic

Description
feat: add endpoint to update help center topics (Admin only)

Implemented PATCH /api/v1/help-center/topics/{article_id} endpoint
Added logic to handle topic updates for authorized admin users
Replaced old topics with updated topics in the mock database
Added unit tests to verify authorized access, input validation, and successful updates
Ensured unauthorized users receive proper error responses

Resolves: #121
Related Issue (Link to issue ticket)
https://github.com/hngprojects/hng_boilerplate_nestjs/issues/121

Motivation and Context
This change is required to provide a secure way for administrators to update existing help center topics. The primary problem it solves is ensuring that only authorized users (specifically admins) can modify the content of help center topics. This helps maintain the integrity and accuracy of the information provided in the help center, ensuring that users receive reliable and updated information.

How Has This Been Tested?
How Has This Been Tested?
We tested the feature to make sure it works as expected.

I confirmed that an admin can update a topic, and the changes are saved correctly in the mock database.
I verified that unauthorized users get a 403 Forbidden error and their updates don't affect the database.
I checked that invalid input, like an empty title, results in a 422 Unprocessable Entity error with the right message.
I used a mock database to simulate real database operations and reset it before each test to ensure accurate results.

These tests ensure the endpoint functions correctly, handles errors properly, and maintains data integrity.

Screenshots (if appropriate - Postman, etc):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

My test requires me to use some dependencies which are buggy from the main
code.
I will provide more details later
On Wed, Jul 24, 2024, 6:36 PM Akanni Modupe Adegoke <
@.***> wrote:

@.**** requested changes on this pull request.
In api/v1/models/article.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690191240
:

+from sqlalchemy import Column, String, DateTime
+from sqlalchemy.ext.declarative import declarative_base
+import uuid
+import datetime

+Base = declarative_base()
+
+class Article(Base):

tablename = 'articles_table'

article_id = Column(String, primary_key=True, index=True, default=lambda: str(uuid.uuid4()))
title = Column(String, unique=True, nullable=False)
content = Column(String, nullable=False)
createdAt = Column(DateTime, default=datetime.datetime.utcnow)
updatedAt = Column(DateTime, default=datetime.datetime.utcnow, onupdate=datetime.datetime.utcnow)

There's an existing Blog model, make use of that
In api/v1/schemas/article.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690193097
:

+from pydantic import BaseModel
+from datetime import datetime
+from typing import Optional

+class ArticleBase(BaseModel):

title: str
content: str

+class ArticleCreate(ArticleBase):

pass

+class ArticleUpdate(ArticleBase):

pass

+class Article(ArticleBase):

article_id: str
createdAt: Optional[datetime]
updatedAt: Optional[datetime]

class Config:

   from_attributes = True

make use of the blog schema
In tests/v1/test_help_center.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690193583
:

+from fastapi.testclient import TestClient
+from ...main import app

+client = TestClient(app)
+
+def test_update_topic_response_data():

pass

+def test_update_topic_authorization():

pass

+def test_update_topic_input_validation():
you didn't write tests for your end points
—
Reply to this email directly, view it on GitHub
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#pullrequestreview-2197369040,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APTFAV6AE7TTBHJJHJLDVXTZN7QYPAVCNFSM6AAAAABLM5OC3WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJXGM3DSMBUGA
.
You are receiving this because you authored the thread.Message ID:
<hngprojects/hng_boilerplate_python_fastapi_web/pull/357/review/2197369040
@github.com>

Like when trying to use the admin user dependency I get an error message
"user object has no attribute is_super_admin and I don't want to touch your
files
On Wed, Jul 24, 2024, 6:41 PM Solomon Uche @.***> wrote:

My test requires me to use some dependencies which are buggy from the main
code.
I will provide more details later
On Wed, Jul 24, 2024, 6:36 PM Akanni Modupe Adegoke <
@.***> wrote:

@.**** requested changes on this pull request.
In api/v1/models/article.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690191240
:

+from sqlalchemy import Column, String, DateTime
+from sqlalchemy.ext.declarative import declarative_base
+import uuid
+import datetime

+Base = declarative_base()
+
+class Article(Base):

tablename = 'articles_table'

article_id = Column(String, primary_key=True, index=True, default=lambda: str(uuid.uuid4()))
title = Column(String, unique=True, nullable=False)
content = Column(String, nullable=False)
createdAt = Column(DateTime, default=datetime.datetime.utcnow)
updatedAt = Column(DateTime, default=datetime.datetime.utcnow, onupdate=datetime.datetime.utcnow)

There's an existing Blog model, make use of that
In api/v1/schemas/article.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690193097
:

+from pydantic import BaseModel
+from datetime import datetime
+from typing import Optional

+class ArticleBase(BaseModel):

title: str
content: str

+class ArticleCreate(ArticleBase):

pass

+class ArticleUpdate(ArticleBase):

pass

+class Article(ArticleBase):

article_id: str
createdAt: Optional[datetime]
updatedAt: Optional[datetime]

class Config:

   from_attributes = True

make use of the blog schema
In tests/v1/test_help_center.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690193583
:

+from fastapi.testclient import TestClient
+from ...main import app

+client = TestClient(app)
+
+def test_update_topic_response_data():

pass

+def test_update_topic_authorization():

pass

+def test_update_topic_input_validation():
you didn't write tests for your end points
—
Reply to this email directly, view it on GitHub
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#pullrequestreview-2197369040,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APTFAV6AE7TTBHJJHJLDVXTZN7QYPAVCNFSM6AAAAABLM5OC3WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJXGM3DSMBUGA
.
You are receiving this because you authored the thread.Message ID:
<hngprojects/hng_boilerplate_python_fastapi_web/pull/357/review/2197369040
@github.com>

Changes made as requested.
On Wed, Jul 24, 2024 at 6:46 PM Solomon Uche @.***>
wrote:

Like when trying to use the admin user dependency I get an error message
"user object has no attribute is_super_admin and I don't want to touch your
files
On Wed, Jul 24, 2024, 6:41 PM Solomon Uche @.***>
wrote:

My test requires me to use some dependencies which are buggy from the
main code.
I will provide more details later
On Wed, Jul 24, 2024, 6:36 PM Akanni Modupe Adegoke <
@.***> wrote:

@.**** requested changes on this pull request.
In api/v1/models/article.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690191240
:

+from sqlalchemy import Column, String, DateTime
+from sqlalchemy.ext.declarative import declarative_base
+import uuid
+import datetime

+Base = declarative_base()
+
+class Article(Base):

tablename = 'articles_table'

article_id = Column(String, primary_key=True, index=True, default=lambda: str(uuid.uuid4()))
title = Column(String, unique=True, nullable=False)
content = Column(String, nullable=False)
createdAt = Column(DateTime, default=datetime.datetime.utcnow)
updatedAt = Column(DateTime, default=datetime.datetime.utcnow, onupdate=datetime.datetime.utcnow)

There's an existing Blog model, make use of that
In api/v1/schemas/article.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690193097
:

+from pydantic import BaseModel
+from datetime import datetime
+from typing import Optional

+class ArticleBase(BaseModel):

title: str
content: str

+class ArticleCreate(ArticleBase):

pass

+class ArticleUpdate(ArticleBase):

pass

+class Article(ArticleBase):

article_id: str
createdAt: Optional[datetime]
updatedAt: Optional[datetime]

class Config:

   from_attributes = True

make use of the blog schema
In tests/v1/test_help_center.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690193583
:

+from fastapi.testclient import TestClient
+from ...main import app

+client = TestClient(app)
+
+def test_update_topic_response_data():

pass

+def test_update_topic_authorization():

pass

+def test_update_topic_input_validation():
you didn't write tests for your end points
—
Reply to this email directly, view it on GitHub
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#pullrequestreview-2197369040,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APTFAV6AE7TTBHJJHJLDVXTZN7QYPAVCNFSM6AAAAABLM5OC3WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJXGM3DSMBUGA
.
You are receiving this because you authored the thread.Message ID:
<hngprojects/hng_boilerplate_python_fastapi_web/pull/357/review/2197369040
@github.com>

This code below is throwing error during test because user.is_super_admin
the dict object was accessed using dot notation.
And all the test so far in the repo, none has used authentication hence no
one as noticed.
def get_super_admin(db: Session = Depends(get_db), token: str = Depends(
oauth2_scheme)):
user = get_current_user(db, token)
if not user.is_super_admin:
raise HTTPException(
status_code=status.HTTP_403_FORBIDDEN,
detail="You do not have permission to access this resource",
)
return user
On Wed, Jul 24, 2024 at 7:07 PM Solomon Uche @.***>
wrote:

Changes made as requested.
On Wed, Jul 24, 2024 at 6:46 PM Solomon Uche @.***>
wrote:

Like when trying to use the admin user dependency I get an error message
"user object has no attribute is_super_admin and I don't want to touch your
files
On Wed, Jul 24, 2024, 6:41 PM Solomon Uche @.***>
wrote:

My test requires me to use some dependencies which are buggy from the
main code.
I will provide more details later
On Wed, Jul 24, 2024, 6:36 PM Akanni Modupe Adegoke <
@.***> wrote:

@.**** requested changes on this pull request.
In api/v1/models/article.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690191240
:

+from sqlalchemy import Column, String, DateTime
+from sqlalchemy.ext.declarative import declarative_base
+import uuid
+import datetime

+Base = declarative_base()
+
+class Article(Base):

tablename = 'articles_table'

article_id = Column(String, primary_key=True, index=True, default=lambda: str(uuid.uuid4()))
title = Column(String, unique=True, nullable=False)
content = Column(String, nullable=False)
createdAt = Column(DateTime, default=datetime.datetime.utcnow)
updatedAt = Column(DateTime, default=datetime.datetime.utcnow, onupdate=datetime.datetime.utcnow)

There's an existing Blog model, make use of that
In api/v1/schemas/article.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690193097
:

+from pydantic import BaseModel
+from datetime import datetime
+from typing import Optional

+class ArticleBase(BaseModel):

title: str
content: str

+class ArticleCreate(ArticleBase):

pass

+class ArticleUpdate(ArticleBase):

pass

+class Article(ArticleBase):

article_id: str
createdAt: Optional[datetime]
updatedAt: Optional[datetime]

class Config:

   from_attributes = True

make use of the blog schema
In tests/v1/test_help_center.py
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#discussion_r1690193583
:

+from fastapi.testclient import TestClient
+from ...main import app

+client = TestClient(app)
+
+def test_update_topic_response_data():

pass

+def test_update_topic_authorization():

pass

+def test_update_topic_input_validation():
you didn't write tests for your end points
—
Reply to this email directly, view it on GitHub
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#pullrequestreview-2197369040,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APTFAV6AE7TTBHJJHJLDVXTZN7QYPAVCNFSM6AAAAABLM5OC3WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJXGM3DSMBUGA
.
You are receiving this because you authored the thread.Message ID:
<hngprojects/hng_boilerplate_python_fastapi_web/pull/357/review/2197369040
@github.com>

the user model has been updated, pull from dev branch

I have done that I know the user model is being updated but the test is
still complaining the test wants the attribute to be accessed as a
dictionary using the get method and not with Dot notation. When I try this
on my branch it worked but I didn't want to edit the model so that it
doesn't break other people's code
On Wed, Jul 24, 2024, 7:11 PM Akanni Modupe Adegoke <
@.***> wrote:

the user model has been updated, pull from dev branch
—
Reply to this email directly, view it on GitHub
https://github.com/hngprojects/hng_boilerplate_python_fastapi_web/pull/357#issuecomment-2248628461,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APTFAV57BUZ3IAXIJPL2VRTZN7U6RAVCNFSM6AAAAABLM5OC3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYGYZDQNBWGE
.
You are receiving this because you authored the thread.Message ID:
<hngprojects/hng_boilerplate_python_fastapi_web/pull/357/c2248628461@
github.com>


Fix #736: use ms vs. s resolution on all times

This corrects my mistake when porting node's time handling code.  They assume seconds in a lot of places, and have to multiply/divide by 1000 to get proper units.  We always use ms times, so this fixes things everywhere.  I've added better test coverage for it too.

Codecov Report

Merging #739 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #739   +/-   ##
=======================================
  Coverage   86.63%   86.63%
=======================================
  Files          16       16
  Lines        1736     1736
=======================================
  Hits         1504     1504
  Misses        232      232

Impacted Files
Coverage Δ

src/stats.js
100% <100%> (ø)
:arrow_up:

src/filesystem/implementation.js
83.72% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec51a1...9b496e7. Read the comment docs.


Does it work well in "ssh-remote' mode?

I am using vsCode with "Remote-SSH" extension. So should I install node in my server?

Hey @LuckyErving
I am not actually sure how this would work haha. Have you tried it and found it worked? I am very curious


preprocess.py reduce

Hi,
I am trying to run preprocess.py and there is an unresolved reference to reduce:
charset = list(reduce(lambda x, y: set(y) | x, structures, set()))
however, if I:
from functools import reduce
I then get the error.

Traceback (most recent call last):
File "preprocess.py", line 88, in
main()
File "preprocess.py", line 60, in main
h5f.create_dataset('charset', data = charset)
File "C:\Users\dmcclymo\AppData\Local\Continuum\Anaconda3\lib\site-packages\h5py_hl\group.py", line 105, in crea
taset
dsid = dataset.make_new_dset(self, shape, dtype, data, **kwds)
File "C:\Users\dmcclymo\AppData\Local\Continuum\Anaconda3\lib\site-packages\h5py_hl\dataset.py", line 93, in mak
_dset
tid = h5t.py_create(dtype, logical=1)
File "h5py\h5t.pyx", line 1450, in h5py.h5t.py_create (C:\Minonda\conda-bld\h5py_1474482825505\work\h5py\h5t.c:16
File "h5py\h5t.pyx", line 1470, in h5py.h5t.py_create (C:\Minonda\conda-bld\h5py_1474482825505\work\h5py\h5t.c:15
File "h5py\h5t.pyx", line 1531, in h5py.h5t.py_create (C:\Minonda\conda-bld\h5py_1474482825505\work\h5py\h5t.c:15
TypeError: No conversion path for dtype: dtype('<U1')

ok i can turn it into a string this way
    string_of_charset = ""     for x, i in enumerate(charset):         string_of_charset+=str(i[0])

I ran into the same problem. The problem went away when I went to Python2.7 by creating a Python 2.7 environment to run the code in. I did this using
conda create -n Python27 python=2.7
If you want to run in Python 3, this post might be helpful: one of the responders suggests using np.string_() instead of str.

In Python 3.6 I tried:
charset = np.string(charset)_
It did away:
TypeError: No conversion path for dtype: dtype('<U1')
However, it raised:
TypeError: Broadcasting is not supported for complex selections

Just add from functools import reduce

I have same error ....
TypeError: Broadcasting is not supported for complex selections.
Someone solved?


Maid-1464 handshake

Implementation of handshake handling. Usage of " changed to '

r? @ustulation
(maidsafe_highfive has picked a reviewer for you, use r? to override)

r? @Viv-Rajkumar


Add index and resource tuning for postgres ghcr image to support postgres benchmark in sf1

🗣 Description

Add index and tune resource to speed up tpch scale factor 1 queries in postgres
Use scale factor 1 for postgres tpch benchmark tests

🔨 Related Issues

🤔 Concerns

@peasee Different query engines optimizers plans the query differently, the same query may have completely different plan in different query engines, for example, mysql and postgres, therefore the index to speed up queries are not necessarily the same. For example, the
CREATE INDEX idx_part_p_partkey ON part (p_partkey); index, which is critical to speed up postgres tpch q20, is not added in mysql index. That's why the index file is not reused.


updated template for next steps with warning and contact info

this is the updated template we looked at last week


Fixed the missing v in tag output

Current dependencies on/for this PR:

main

PR #87   👈

This comment was auto-generated by Graphite.


Zero out resolved address before calling accept

If the client is a Unix Domain Socket that has not bound to an address, then the sun_path in the sockaddr_un struct is not filled on an accept at the server. (Refer man page for unix - man 7 unix for more details)
Without zeroing it out, we are setting the peer uri to a garbage string.

****************************************************************

libgrpc.so

     VM SIZE                                              FILE SIZE
 ++++++++++++++ GROWING                                ++++++++++++++
  +0.3%     +16 src/core/lib/iomgr/tcp_server_posix.cc     +16  +0.3%
      +2.5%     +16 on_read                                    +16  +2.5%

 -+-+-+-+-+-+-+ MIXED                                  +-+-+-+-+-+-+-
  -0.0%     -16 [None]                                    +208  +0.0%

  [ = ]       0 TOTAL                                     +224  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

..how is this causing an issue?

[microbenchmarks] No significant performance differences

Replied offline - without this grpc_endpoint_get_peer() would end up returning a string like 'unix:?��'


🐛 (frontend) hide "go to course" button for unstarted course runs and display the approx. waiting time before the course starts

Bug Report
Problematic Behavior
The 'Go to course' button is now displayed even for course runs that have not started yet.  Users can click on it, which either redirects them to the LMS dashboard with the message 'The course you are looking for does not start until {date}' (in the best scenario), or results in a 500 error.
Expected behavior/code
Gray out the 'Go to course' button for standard users, display the enrollment confirmation message, along with the approximative time remaining before the start of the course (https://github.com/openfun/richie/commit/9f5b51a2eb9f233b1d1b7b485966e794479e7adf).
Steps to Reproduce

Log in to https://studio.richie.education/ as an admin
Enter a future course start date on this page: https://studio.richie.education/settings/details/course-v1:edX+DemoX+Demo_Course.
Log out from https://studio.richie.education/
Log in as a student at https://edx.richie.education/login.
From https://demo.richie.education/fr/cours/?availability=coming_soon&limit=21&offset=0, enroll in a course run starting soon
The 'Go to course' button is available without mentioning a future start date.

Environment

All Richie platforms (production)

Possible Solution

This commit seems no longer being in use: https://github.com/openfun/richie/commit/9f5b51a2eb9f233b1d1b7b485966e794479e7adf
It's possible it was removed when the course runs list was ported to React (v2.23.0): https://github.com/openfun/richie/compare/v2.22.0...v2.23.0 ? I haven't identified the specific change yet.
Other possible leads:

https://github.com/openfun/richie/blob/master/src/frontend/js/widgets/SyllabusCourseRunsList/components/CourseRunEnrollment/index.tsx#L312
https://github.com/openfun/richie/commits/292da354dc276c85b0a600dc30a23be258b1d1fb/src/frontend/js/widgets/SyllabusCourseRunsList/components/CourseRunEnrollment/index.tsx (commit history)

Additional context/Screenshots
richie-go-to-future-course-runs.webm

Hi @NamFra I'm going to investigate this issue. Thank you for giving lots of informations 👌


JBQA-13276 introduce possibility to use CacheManager.

I also think we should update licenses in all files in this repository to include JBoss/Red Hat copyright. WDYT?

This is contribution to upstream version of the HTTP/2 jmeter sampler which initial version wasn't done by us. Even though the original creator doesn't seem to update the original one or accept merge requests, and we have done quite extensive update to the plugin, I am not sure.

The changes LGTM, merging.


Write image to tmp directory instead of encoding it.

The capture function returns the image Base64 encoded. I'd propose to add another mode to the capture function:
Instead of returning the image to the callback, we write it to the <Application_Home>/tmp directory using a UUID as the filename. The callback just receives the UUID instread of the Base64 encoded data.
I could implement this feature easily but first wanted to check if anyone comes up with a better idea :D
Edit: Just saw, that you have already implemented this functionality. Thank you very much :+1:
There is just one thing that I would add: Add a property to options to specify a subfolder in the <Application_Home> directory.

Agreed about having a configurable subfolder. It should probably default to a subfolder like "RCTCamera".
We did not use the tmp directory by default because it may be cleared out between app restarts, but in some applications this is probably desirable behaivor.
Which leaves the question of desigining the options around this. Something like
targetBaseDirectory enum("documents", "tmp") - defaults to documents
targetSubDirectory string - defaults to "RCTCamera"
However I can see target options getting unwieldy quickly.

I think one option would be easier to use:
targetDirectory defaulting to "documents/RCTCamera".
( If the directories used in targetDirectory don't exist we can easily create them. )

I believe the only two valid base directories are Documents and tmp... and Maybe Library. So I would definitely want to enum that value.
As a seperate question, perhaps targetOptions should be its own config object, much like source is an object in Image
targetOptions: {
  temp: (bool),
  subDirectory: (string),
}

Just throwing out ideas, I like to keep things explicit, but I know Loch likes to keep things tidy.

Just a thought - what if target could be memory, disk, or a directory? disk would basically just be a default directory like we're already doing it.

I think it makes more sense to add some options when using the target disk, because when you define disk and target, you have two captureTarget's with nearly the same functionality.
But in the @lwansbrough gets to decide, and I'd be really happy to start implementing this new feature :D

After thinking about this more, and reading other peoples thoughts in various issues, I think there are several issues that need to addressed, perhaps with signifigant API changes:

Make default target be disk
Make default directory /tmp
Rename memory to base64String
Add targetDirectory  configuration option (like @lukasreichart originally proposed)

This I think will solve a few concerns. Saving to /tmp as a default simplifies the naive implementation. Renaming memory to base64String is both more explicit, and opens up the possibility for using memory to store the captured image in memory in some singleton, which may be a useful performance optimization for apps that need extremely low latency access and manipulation of the captured image.
As it appears this is going to be the defacto camera solution for react-native, now is probably a good time to open up the API discussion and refactor if necessary. In the meantime adding targetDirectory is probably the most obvious first step.

I'm in favour of doing whatever is best for the community, so let's decide what that is. What @lukasreichart and @rt2zz have proposed seems like a pretty solid solution. If anyone has objections or comments we'd like to hear them.

So I may be wanting to look at this soon, except with a twist:  to see how I can build out a solution using Swift (because that's all I know -- to an extent, too).  Perhaps something that is invoked once the image is obtained.  And that "something" will/should provision the proposed solution above (which I like)...

This issue is a bit dated. there is now a target="temp" option for both android and iOS thanks to @christopherdro :+1:

@rt2zz Just a heads up, I believe this applies only to photos. Temp directory for videos needs to still be added.


More pyworkflow unittests; adds coverage info/badge

A few tweaks to the README to add status badges and a placeholder image of Pyworkflow.
Added ~20% coverage with new unit tests for the Pyworkflow package. Now broken up between a few test files and organized slightly better. There's still a lot of duplicate code for setup/node config that I'm not sure the best way to handle. If anyone has ideas/best practices on how to better set up a test rig and temp data files, please let me know!

Looks great! Make sure you omit the tests themselves in .coveragerc (unless this is done by default?), otherwise the results count the huge number of test lines both in the numerator and denominator.
I've had a lot of success with pytest as a test runner over the unittest one. You don't have to change any of the tests, just add pytest and pytest-cov as dependencies, and then configure a pytest.ini file to make sure the tests are detected correctly. I think we'd also remove the "run if __main__" clauses from the tests. Later today I'll track down an example of a configuration that works, if we're interested in using pytest. (The docs are pretty good too.)
Regarding test data files, I think the easiest way (without having to configure setup.py to package static files) is to abstract all the node JSON objects into a .py file that has an importable constant:
TEST_DATA = {
    "good_node" : {
        "node_id": ...,
        "node_key": ...
    },
    ...
}

then import it in all the tests. Removes the overhead of the setup methods.


ORION-2803: put includeTags behind an optional flag

Description
Putting includeTags functionality for fsoc ks commands behind an optional flag
Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[x] I have read the contributing guidelines
[x] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[x] Functionality is documented
[x] All code style checks pass
[x] New code contribution is covered by automated tests
[x] All new and existing tests pass

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8fa634f) 26.88% compared to head (9364b5b) 26.88%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   26.88%   26.88%
=======================================
  Files          44       44
  Lines        4564     4564
=======================================
  Hits         1227     1227
  Misses       3242     3242
  Partials       95       95

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[T3A4][W14-A3] Yong Jia Wern

Ready for review

As mentioned during tutorial, consider whether exiting is the best way to handle this exception. :)


Error when using awesome config

Error:
OS: FreeBSD 13

What that error has to do with NetworkMgr?


Adding testing

To simplify development we should probably have some basic tests. Could the code for the practice problem be refactored and then used for this?

pizza.py works as testing currently. We might still want to add more, but we can at least test all args currently.


Add support for ATLAS translator?

Would it be possible to add support for ATLAS translator? I personally think it's translations are better than google translate's.

Apologies for not having responded to this issue earlier.
I've taken a look at ATLAS and I currently feel it would be too much effort to support it, given the interest.
Keeping the issue open to gauge any potential additional interest.

I would appreciate Any method of offline translation. Atlas is usually my goto although its quality isn't near googles, its usually much faster.

Going to close this. For English there are far better alternatives for offline translation with this.


[stable/prometheus] Fix default non-HA state for alertmanager

Signed-off-by: Vesa Laakso<EMAIL_ADDRESS>Is this a new chart
No
What this PR does / why we need it:
Since enableMeshPeer is false by default, cluster.listen-address should be empty.
Commit 5b4f507 caused regression and it is passing string as a parameter which is wrong. Documentation https://github.com/prometheus/alertmanager/blob/master/README.md#high-availability explicitly says cluster listen address should be defined like --cluster.listen-address= without passing an empty string.
Which issue this PR fixes
Regression caused by commit 5b4f507
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/prometheus])

/assign
/ok-to-test

/lgtm


basic conservative rasterization support for Vulkan & DX12

Sorta fixes #3637
Only provides the very basic option of enabling/disabling overestimation rasterization. This is almost everything DX12 has to offer anyways except the optional SV_InnerCoverage support, but leaves out even more Vulkan goodies (e.g. underestimation, various device properties, configurable extra-over-estimation, conservative raster of lines...).
Availability of the coverage variable is the most important missing thing but could later be exposed as an additional feature flag (debatable, since this is not how Vulkan does it, so more of a device property?)
Probably more controversial about this PR: validate_creation_desc_support
I didn't want to repeat feature check code over all devices so I created a function on the desc that validates against features (and made unallowed use of DEPTH_CLAMP an error since this was close by..). Imho this is the only sane way forward for stuff like this since more often than not there needs to be a check somewhere but the philosophy of having this on this level and in that particular place might be questionable.
Tested this with wgpu - I already have wgpu and wgpu-rs branches ready with a sample that can swap back and forth between enabled and disabled conservative rasterization. Going to look like this:

PR checklist:

[x] make succeeds (on *nix)
[ ] make reftests succeeds -- failed in alloc, seems unrelated thread 'main' panicked at 'removal index (is 0) should be < len (is 0)', library/alloc/src/vec.rs:1066:13
[x] tested examples with the following backends: Vulkan, DX12

Looks great @Wumpf , thank you for adding this!
I share the concern about validate_creation_desc_support. The problem is - how do we consistently draw the line between what we validate and what not? A loooot of things can be validated. In some places the cost is nothing, in another the cost can be visible. Right now the balance is - validate the minimum, i.e. just the feature set on device creation, that's pretty much it! Everything else is just "oops, unexpected stuff came", it's not really validation. Adding the check for conservative and depth clamping, while leaving all the other 100 pipeline states, seems like a wrong balance to me.
So that "check somewhere" should be in wgpu, which is safe. Would you mind removing the validate_creation_desc_support check from the PR?

Alright, makes sense. Done!

Bors r+

On Mar 14, 2021, at 04:45, Wumpf @.***> wrote:

Alright, makes sense. Done!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


[mpw5a] OpenLane errors out: [ERROR DRT-0074] No ap for PIN/fastio_in[16].

Description
mpw5a caravel based OpenLane installation.
OpenLane errors out: [ERROR DRT-0074] No ap for PIN/fastio_in[16].
I examined DEF/GDS and everything. There seems no reason for this to happen.

I suspected that the pin was too small, but increasing or decreasing pin width does not change anything.
I suspected that it didn't reach the main logic area, but increasing the length didn't change anything
I changed type of the pin from FIXED to PLACED, but didn't get any changes.
Used a def generated by OpenLane itself. It works.
The pin's layer (met2) matches the direction of the pin.
Location in DEF matches the locations in run's def.

Things I didn't check:
Should the pins be located on some grid? Didn't find any information about this. If so, where is it documented?
Why I am trying to use a DEF and not locations generated by OpenLane pin config? Because I can't specify specific locations of the pins, including metal, spacing and width in any other way.
UPD: Tried shifting some pins by 10nm in case of OpenLane generated DEF. Still succesful, so GRID issue is not likely.
Environment
Python: v3.9.5

Kernel: Linux v5.11.0-49-generic

Distribution: ubuntu 21.04

Container Engine: docker v20.10.10

OpenLane Git Version: 2021.11.23_01.42.34

---

PDK Version Verification Status: OK

---

Git Log (Last 3 Commits)

commit e1883edfbcc8c7e96491158521522b7a66541745

Author: Manar<EMAIL_ADDRESS>
Date:   Mon Nov 22 07:59:18 2021 -0600

    Update resizer (#726)

commit 6245b0e675d0e6751bdfc5362c545efe29d1077c

Author: Manar<EMAIL_ADDRESS>
Date:   Fri Nov 19 13:38:50 2021 -0600

    Fix sram install (#724)

    Also disable by default

commit e0e6fbc1bd90d1c73aae19769d997da8c3c47512

Author: Manar<EMAIL_ADDRESS>
Date:   Fri Nov 19 12:30:08 2021 -0600

    Add option for enabling/disabling repair_tie_fanout (#722)

    * Add option for enabling/disabling repair_tie_fanout

    * add escape characters

    * Add option for enabling sta report power

Reproduction Material
tar gz containing two designs carrack_wrapper:
carrack_wrapper.tar.gz
carrack wrapper is the workspace used to generate the def with command: ./flow.tcl -interactive -file designs/carrack_wrapper/interactive.tcl
carrack_wrapper_user:
carrack_wrapper_user.tar.gz
carrack_wrapper_user is design that errors out command: ./flow.tcl -design carrack_wrapper_user -tag carrack_wrapper_user -overwrite
Manually generated or_issue archive:
or_issue.tar.gz
or_issue command: python3 ./scripts/or_issue.py -s scripts/openroad/droute.tcl /openlane/designs/carrack_wrapper_user/runs/carrack_wrapper_user/tmp/routing/17-addspacers.def
Successful runs (see "thing I checked") are not included. Reproduction takes about 1 hour and 2GB of space.
Expected behavior
No error and properly placed PnR GDS with pins from my def as an output :)
Logs
[INFO DRT-0165] Start pin access.

[ERROR DRT-0074] No ap for PIN/fastio_in[16].

terminate called after throwing an instance of 'std::runtime_error'

  what():  DRT-0074

[ERROR]: during executing: "openroad -exit /openlane/scripts/openroad/droute.tcl |& tee >&@stdout /openlane/designs/carrack_wrapper_user/runs/carrack_wrapper_user/logs/routing/19-tritonRoute.log"

[ERROR]: Exit code: 1

[ERROR]: Last 10 lines:

child killed: SIGABRT

[ERROR]: Please check openroad  log file

[ERROR]: Dumping to /openlane/designs/carrack_wrapper_user/runs/carrack_wrapper_user/error.log

[INFO]: Calculating Runtime From the Start...

[INFO]: flow failed for carrack_wrapper/2022.02.10_17.00.33 in 0h6m12s

[INFO]: Generating Final Summary Report...

[INFO]: Design Name: carrack_wrapper

Run Directory: /openlane/designs/carrack_wrapper_user/runs/carrack_wrapper_user

Source not found.

----------------------------------------

LVS Summary:

Source: /openlane/designs/carrack_wrapper_user/runs/carrack_wrapper_user/results/lvs/carrack_wrapper.lvs_parsed.gds.log

Source not found.

----------------------------------------

Antenna Summary:

No antenna report found.

[INFO]: check full report here: /openlane/designs/carrack_wrapper_user/runs/carrack_wrapper_user/reports/final_summary_report.csv

[INFO]: Saving Runtime Environment

[ERROR]: Flow Failed.

    while executing

"try_catch $::env(OPENROAD_BIN) -exit $::env(SCRIPTS_DIR)/openroad/droute.tcl |& tee $::env(TERMINAL_OUTPUT) [index_file $::env(tritonRoute_log_file_ta..."

    (procedure "detailed_routing_tritonroute" line 6)

    invoked from within

"detailed_routing_tritonroute"

    (procedure "detailed_routing" line 13)

    invoked from within

"detailed_routing"

    (procedure "run_routing" line 54)

    invoked from within

"run_routing"

    (procedure "run_routing_step" line 10)

    invoked from within

"[lindex $step_exe 0] [lindex $step_exe 1] "

    (procedure "run_non_interactive_mode" line 43)

    invoked from within

"run_non_interactive_mode {*}$argv"

    invoked from within

"if { [info exists flags_map(-interactive)] || [info exists flags_map(-it)] } {

	puts_info "Running interactively"

	if { [info exists arg_values(-file)..."

    (file "./flow.tcl" line 356)

Your pin is off the manufacturing grid:
- fastio_in[16] + NET fastio_in[16] + DIRECTION INPUT + USE SIGNAL
  + PORT
    + LAYER met2 ( -140 -2000 ) ( 140 2000 )
    + FIXED ( 122434 **3193985** ) N ;

See "MANUFACTURINGGRID 0.005 ;" in your LEF.  Since the pin shape itself is illegal no valid access can be made to it.

How was your pin placement generated?

Your script is quite complicated and hard to follow.  However 122.434 from DEF  is nowhere near
puts [expr 329.99000 - 189.52 + 69.785 + 0.28]
210.535
So you must have a bug.  That isn't rounding error.

I think you are looking at the wrong pin:
puts [expr 241.89 - 189.52 + 69.785 + 0.28]
122.43499999999997
shows the issue.  Try
set pos [expr 241.89 - 189.52 + 69.785 + 0.28]
puts [expr round($pos * 1000) / 1000.0]
122.435

I think it was fixed. Found the code line: https://github.com/The-OpenROAD-Project/OpenROAD/blob/9afb4fd0ca5fe8568c32aac33847211b9689800a/src/ppl/src/IOPlacer.tcl#L288
How to know if this commit made to the OpenRoad used by me?

EDA layout tools generally use integer DBU to avoid such floating point issues (see https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/docs/contrib/DatabaseMath.md).
The router has an internal check but it is more to make sure that it isn't creating such problems rather than checking user inputs.  We could apply it to the user pins as a pre-check.  I'll open an issue for that.
I'm not sure about your link to IOPlacer.tcl.  The issue was in your or_ioplace.tcl script.

https://github.com/The-OpenROAD-Project/OpenROAD/issues/1634

@maliberty
Hi,
Issue still persists. Called:
place_pin -pin_name "wbs_sel_i[1]" -layer met2 -location [list 516.67 2.0] -pin_size [list $met2_pin_width $pin_length]

Which results in following lines in DEF:
    - wbs_sel_i[1] + NET wbs_sel_i[1] + DIRECTION INPUT + USE SIGNAL

      + PORT

        + LAYER met2 ( -140 -2000 ) ( 140 2000 )

        + FIXED (<PHONE_NUMBER> ) N ;

I just tried
place_pin -pin_name {clk} -layer met2 -location {2.0 512.915} -pin_size {4 0.28}
write_def foo.def

and see
PINS 54 ;
    - clk + NET clk + DIRECTION INPUT + USE SIGNAL
      + PORT
        + LAYER met2 ( -2000 -140 ) ( 2000 140 )
        + FIXED ( 2000 512915 ) N ;

so I can't reproduce your issue.  Please try with the latest openroad.

Could you try the mpw5a version? I am not not upstream version.

Okay. Just so you know, this is not critical right now, as a workaround has been made.
For upstream I will implement a warning for this in the current apply def template. As for OpenRoad, you already created an issue.

wrong issue. sorry.


^[[D appears in terminal when clicking on links

Version: 1.53.0-insider
Commit: 4f2341834e646360e603953b62bf6c6020b07a29
Date: 2021-01-22T08:55:11.282Z
Electron: 11.2.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.2.0

configure "editor.multiCursorModifier": "ctrlCmd"
git clone https://github.com/microsoft/monaco-editor.git
npm install
npm run simpleserver
try to open the link printed in the terminal using alt+click:

https://user-images.githubusercontent.com/5047891/105504297-e11db580-5cc7-11eb-9073-b9f8298732b3.mp4

https://github.com/microsoft/vscode/pull/114669/https://github.com/microsoft/vscode/issues/101136 was meant to fix this yesterday, @meganrogge can you verify whether it's fixed?

https://github.com/microsoft/vscode/pull/114669/https://github.com/microsoft/vscode/issues/101136 was meant to fix this yesterday, @meganrogge can you verify whether it's fixed?

@meganrogge I am quite confident I am on latest (I mentioned that in my OP):
Commit: 4f2341834e646360e603953b62bf6c6020b07a29
Date: 2021-01-22T08:55:11.282Z

https://user-images.githubusercontent.com/5047891/105536250-53a28b80-5cf0-11eb-9c00-a344fd0bbb30.mp4

@meganrogge I am quite confident I am on latest (I mentioned that in my OP):
Commit: 4f2341834e646360e603953b62bf6c6020b07a29
Date: 2021-01-22T08:55:11.282Z

https://user-images.githubusercontent.com/5047891/105536250-53a28b80-5cf0-11eb-9c00-a344fd0bbb30.mp4

I just got a vscode update and I can reproduce also on:
Version: 1.53.0-insider
Commit: ed72c64b87ede96fb51bc16870f9d2ecbf4fcc57
Date: 2021-01-22T17:17:02.999Z
Electron: 11.2.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.2.0

It might be a problem specific to macOS ?

I just got a vscode update and I can reproduce also on:
Version: 1.53.0-insider
Commit: ed72c64b87ede96fb51bc16870f9d2ecbf4fcc57
Date: 2021-01-22T17:17:02.999Z
Electron: 11.2.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.2.0

It might be a problem specific to macOS ?

hmm, I'm thinking the upstream setting that I've exposed in VS Code is only looking for alt. So you are correct this is now just a mac issue.

hmm, I'm thinking the upstream setting that I've exposed in VS Code is only looking for alt. So you are correct this is now just a mac issue.

regardless of OS, this is how that feature is set:
altClickMovesCursor: config.altClickMovesCursor && editorOptions.multiCursorModifier === 'alt'
so I have no idea how that feature is still getting activated for you

regardless of OS, this is how that feature is set:
altClickMovesCursor: config.altClickMovesCursor && editorOptions.multiCursorModifier === 'alt'
so I have no idea how that feature is still getting activated for you

@alexdima thanks for the report, I managed to repro it and fix. The issue happened when you changed multiCursorModifier after creating the terminal in question.

@alexdima thanks for the report, I managed to repro it and fix. The issue happened when you changed multiCursorModifier after creating the terminal in question.

🎉 I've just tried it out on latest, and I no longer see ^[[D

🎉 I've just tried it out on latest, and I no longer see ^[[D


diagnostics: 3.0.0-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository diagnostics to 3.0.0-1:

upstream repository: https://github.com/ros/diagnostics.git
release repository: https://github.com/ros2-gbp/diagnostics-release.git
distro file: rolling/distribution.yaml
bloom version: 0.11.1
previous version for package: 2.1.3-2

diagnostic_aggregator
* Use node clock for diagnostic_aggregator and diagnostic_updater (#210 <https://github.com/ros/diagnostics/issues/210>)
* Contributors: Kenji Miyake

diagnostic_updater
* Merge pull request #217 <https://github.com/ros/diagnostics/issues/217> from boschresearch/ros-time-for-frequency-stat
* Allow clock instance to be set from outside in FrequencyStatus
* Use node clock for diagnostic_aggregator and diagnostic_updater (#210 <https://github.com/ros/diagnostics/issues/210>)
* Use DiagnosticStatus.msg values instead of creating bytes manually (#193 <https://github.com/ros/diagnostics/issues/193>)
* Contributors: Arne Nordmann, BasVolkers, Kenji Miyake, Marco Lampacrescia

self_test
* Return the actual future from async_send_request (#209 <https://github.com/ros/diagnostics/issues/209>)
* Contributors: Chris Lalancette

Hm, I'm not really sure I want to release self_tests here.  I may need to do some additional work, please don't merge this yet.

Apparently self_test was failing to build in Rolling back in October, so we had removed it.  I think it is worthwhile bringing it back, so I'm going to go ahead and merge this.


storageRebate is not withdrawn from the gas fee

Steps to Reproduce Issue
Use the TS sdk to send a transaction and dry run it first
    const signer = new RawSigner(keypair, provider)
    const unsigned_transaction = {
      inputCoins: [some id],
      recipients: [some recipient],
      amounts: [some amount],
      gasBudget: 1000
    }

    const gasBudget = await signer.getGasCostEstimation({
      kind: 'paySui',
      data: unsigned_transaction,
    })

    const transaction = await signer.paySui({
      ...unsigned_transaction,
      gasBudget
    })

Expected Result
The transaction should succeed
Actual Result
The transaction fails with InsufficientGas because storageRebate is not withdrawn from the fee as it's indicated here
{ computationCost: 152, storageCost: 64, storageRebate: 32 }

System Information
running SUI localnet from main branch

This storage rebate is applied after gas is charged. This means if computation is 100 units, and rebate is 10, there should be 100 units available during execution because 100 units will first be charged before the rebate is applied. Hence we should not be counting the rebate in the estimator.

@Sceat please feel free to confirm if this does not fix your issue

#7594 does fix the problem yes thanks


Having a Q.Confirm but wanting to display the yellow warning triangle from the Q.Warning dialog

Hi JaiQ,
I want to use the Q.Confirm Dialog (letting the user make an active decision) but instead of the "calm" blue theme I want to have the same Image, Font- and Background Color like the Q.Warning Dialog.
I have looked into this and searched this github repository here regarding how to do this but didn't find much.
Challenge:
How would I temporarily Change the appearance of the Q.Dialog to a similar look like Q.Warning for one specific Situation but not Change the Q.dialog appearance permanently. (or creating a clone of the Q.Confirm dialog --> e.g. a Q.WarningConfirm dialog)
Thanks again for your time and Support in advance.
With Kind regards,
John

Hi John,
Q.Confirm("test", () => { },
new ConfirmOptions { DialogClass = "s-MessageDialog s-WarningDialog" });

should do the trick.
You may also do add an extra class of your own like
new ConfirmOptions { DialogClass = "s-MessageDialog s-WarningDialog s-MyStyle" })
then style s-MyStyle with css;
Regards,
Volkan

Hi JaiQ,
that works perfectly (your first recommendation). Such an elegant, painless way...
Thank you again very much for your Support
and with Kind regards,
John


ComboBox display issues

there are a handful of combo box issues that make the component hard to use.
attached is a capture with a box with 50 elements. the popup is scrollable, but it appears above the top of the page if it is too close.
https://user-images.githubusercontent.com/24465214/143321478-8b9735b9-be88-46d8-b565-ea6b096d0dec.mp4
<main>
  hello
  <ComboBox
    value="6"
    items={Array.from(Array(50).keys()).map((i) => ({
      name: `Item ${i}`,
      value: i.toString(),
    }))} />
</main>

similarly, if scrolling you can get the combobox to be cut off.
https://user-images.githubusercontent.com/24465214/143322057-363dbb82-1416-4a8b-9ebd-b1a375ef6909.mp4
also, it can be cut off with overflow:hidden css.

At the moment it's done this way because

a) The native controls get around this by rendering the flyout out of window bounds.
b) Due to us using position: absolute; for flyout positioning rather than a dedicated library, it makes checks for this kind of thing slightly more difficult.

Obviously this isn't ideal on the web though, since it's not possible to render DOM contents outside of the viewport. I think the ideal solution here is to check if the flyout anchor's getBoundingClientRect.top() is less then zero, then render the flyout as it would be if the first item was selected. I'll see what I can do in a bit about this.
Alternatively, we could use a library like floating-ui for positioning logic, but I don't like the idea of bundling more javascript than we already need.

Reopening since #48 wasn't intended to close this.


App still maintained?

With no activity for almost 2 years now: do you still maintain this app, @calintat?

Sadly, I no longer have the time to work on Explorer. That might change in the future, but in the meantime, I'm happy to accept some pull requests (and even publish the changes on the Play Store) if you have any ideas on how to make the app better.

Sad indeed – but thanks for your answer! I'm no dev, so my contribution is rather different (and that's also the reason I'm asking).
May I suggest to keep this issue open, and update+close it in case you pick up again? I just marked your app as currently not actively maintained, and would like to remove that mark again then :smiley:


implemented 0.5 in-memory stream multiplexer

this implements code for an in-memory stream multiplexer. It was a bit tedious to write and with all the sync code has potential for race conditions if I screwed up, so it needs to be heavily tested with the go race detector.

Cool


UI Clicks won't work with inherited implementation of NVRHand

I wanted to inherit the NVRHand class to include some new features (initially interactable object highlighting) but found that after inheriting the class and replacing the NVRHand scripts on the controllers with it, I am unable to click on elements in world-space canvases. I removed my code from the class, and found that even an empty class definition still breaks the UI clicks, so this should be easily reproducible by creating a new script with the contents
namespace NewtonVR {     public class NVRHandExtended : NVRHand     {} }
apply that to a controller on the rig, and disable the original NVRHand script.

Hi Scatterlogical,
When you say World-Space Canvases, you mean the floating GUI in the example scene? The one behind the door?
With NewtonVR Ver 0.94, I created a class NVRHandExtended : NVRHand, and if I removed the original NVRHand component from the Left/Right hand gameobjects and replaced it with NVRHandExtended, I was able to use the GUI normally.
Did you make sure to re-reference the Left/Right hand gameobjects in the NVRPlayer Left/Right hand fields? It could be that because the fields are of type NVRHand, they're retaining the reference to the disabled scripts. Try removing the vanilla NVRHand scripts entirely.

I've implemented object highlighting and dual handed interactions, it feels
crazy that we are all repeating each other's work. Any way we can share
this stuff better?
As a side note, I could really use a good object highlighting shader, my
solutions so far have looked crappy on most objects. let me know if you
found something good!
On Mon, Nov 14, 2016 at 7:19 PM, Nicholas Abel<EMAIL_ADDRESS>wrote:

Hi Scatterlogical,
When you say World-Space Canvases, you mean the floating GUI in the
example scene? The one behind the door?
With NewtonVR Ver 0.94, I created a class NVRHandExtended : NVRHand, and
if I removed the original NVRHand component from the Left/Right hand
gameobjects and replaced it with NVRHandExtended, I was able to use the GUI
normally.
Did you make sure to re-reference the Left/Right hand gameobjects in the
NVRPlayer Left/Right hand fields? It could be that because the fields are
of type NVRHand, they're retaining the reference to the disabled scripts.
Try removing the vanilla NVRHand scripts entirely.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TomorrowTodayLabs/NewtonVR/issues/67#issuecomment-260536199,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE3l1sr2LD0G9nkvHGujE7ufQBPeNhPQks5q-SSmgaJpZM4KEvsx
.

Thanks for reporting this. I'm not seeing this if I set LeftHand and RightHand on the player. This may have been fixed in 0.9. Let me know if you're still having this issue.


Deps

"binaries" are generated via setuptools this leaves a runtime dependency on setuptools, thus it needs to be a requirement.

Current coverage is 98.32% (diff: 100%)

Merging #348 into development will not change coverage

@@           development       #348   diff @@
=============================================
  Files               38         38
  Lines             2925       2925
  Methods              0          0
  Messages             0          0
  Branches           145        145
=============================================
  Hits              2876       2876
  Misses              43         43
  Partials             6          6

Powered by Codecov. Last update 6e811bf...2a6112a

OK, that didn't work, rebase properly.


Not an issue, but question to maintainer

Hi, great work. I have question regarding VestaCP running in container. What is the purpose of this? You are actually maintaining Ubuntu which is in container, not a real host where container is running? So what's the purpose? Also, maybe I am wrong but the point is to have one process in container, not quite big number included there :) What do you think?

@dusansusic agree.  I actually responded to the same question here when I initially created this container: https://forum.vestacp.com/viewtopic.php?f=18&t=12953

Since it's a monolithic image, it does defeat the purpose of docker/microservice design. Of course, it was for a different purpose. I just want to host with VESTA but didn't want to blow away or mess up my external VPS setup.

I also wanted something I can control, experiment, and also help me learn more about the inner working of Vesta.  This give me to confident of doing whatever I want inside of the container and completely reset it to any state that I want.
I also run this in Production and have script on VestaCP cron to backup to AWS s3.  I have full confident of being able to quickly restore my VestaCP to any VPS providers (DigitalOcean, Linode, Vultr, etc..) in a disaster recovery situation.

Also, Vesta is currently moving very slow, see all the issues here (https://github.com/serghey-rodin/vesta/issues).  With the container, I was able to experiment with new features such as: Panel and email SSL, multiple php fcgi and fpm, nginx pagespeed, custom nginx templates, and so on.
This panel has provide me with better understanding of Vesta.  I also use it to validate bugs and experiment with new features.  I apply my experience to help out on various Vesta repo issues here (https://github.com/serghey-rodin/vesta/pull/1355) and is slowly working on getting these features into Vesta.  It's been slow because Vesta is currently moving very slowly.


Not able to use in material3

Describe the bug
It's showing compile error, Please check the below error showing in android studio. It's for colors and elevation property :

@Composable
public fun SSJetPackComposeProgressButton(
    type: SSButtonType,
    width: Dp,
    height: Dp,
    onClick: () -> Unit,
    assetColor: Color,
    buttonState: SSButtonState,
    buttonBorderStroke: BorderStroke?,
    blinkingIcon: Boolean,
    cornerRadius: Int,
    speedMillis: Int,
    enabled: Boolean,
    elevation: [Error type: Unresolved type for androidx.compose.material.ButtonElevation]?,
    colors: [Error type: Unresolved type for androidx.compose.material.ButtonColors],
    padding: PaddingValues,
    alphaValue: Float,
    leftImagePainter: Painter?,
    rightImagePainter: Painter?,
    successIconPainter: Painter,
    failureIconPainter: Painter,
    successIconColor: Color,
    failureIconColor: Color,
    text: String?,
    textModifier: Modifier,
    fontSize: TextUnit,
    fontStyle: FontStyle?,
    fontFamily: FontFamily?,
    fontWeight: FontWeight?,
    hourHandColor: Color,
    customLoadingIconPainter: Painter,
    customLoadingEffect: SSCustomLoadingEffect,
    customLoadingPadding: Int
): Unit

More error details given by android studio
Cannot access class 'androidx.compose.material.ButtonColors'. Check your module classpath for missing or conflicting dependencies
Cannot access class 'androidx.compose.material.ButtonElevation'. Check your module classpath for missing or conflicting dependencies

To Reproduce
Cope paste the code from given in readme
Expected behavior
It should not give any compile time error.
Screenshots

Smartphone (please complete the following information):
All Devices
Additional context
I am forking this lib and make it compatible to material3
Thanks for this awesome lib.

@Purvesh-Dodiya: Please check this issue

how to make it work.

Thanks. Solving this after 2 years. @AdminQQZ @yashwantgowla-simform

@hiteshsarsava Apologies for the delay. We are going to release additional features going forward. Please stay tuned and help us with your feedbacks. Thank you!!


Support for asynchronous request

Does the library support asynchronous requests ?

No sorry it doesn't - it supports only synchronous requests.


Store encrypted values in new DB column.

Relates to #3315
When encrypting secrets, store the serialized JSON in the database. When decrypting, attempt to fetch from the new column and then fall back to the old one.
In a subsequent PR, I will migrate all existing secrets to the new structure.
Some more unit testing of the crypto engine was added in this PR.
Tested locally with a mix of old and new credentials.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[x] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 50.259% (+0.1%) from 50.137%
when pulling ceea2691dcd894df2c10cadd9ea9d5640cc8791f on store-encrypted-data-in-db
into 00160754ff851269f8cacb76d7611c599f9146cc on main.


Feature Request

Middle wheel mouse scrolling in the chat box would be awesome!
Love this addon!!

Thanks for your suggestion, it's part of the "Chat Tweaks" now:
https://github.com/shagu/ShaguTweaks/commit/415f7574d14cb366b63eb96464474e67d866d8ef


Sax

Do you guys have any plans for sax? We are starting to be needing it, might implement it. So was going to check if you had started it or had any ideas/concerns

The standard encoding/xml package has very low performance, so the only way to parse huge XML files is SAX parsers: https://github.com/golang/go/issues/21823


[Tests] for charts

@pratu16x7 I'd like to have a crack at this. I was going to go with Jasmine, but do you have any preference on testing framework?

@tom-sherman I am not a collaborator but I'd suggest you take a look at https://github.com/facebook/jest
I find it unbelievable that the project of this size, with 10k stars and 3k of monthly downloads doesn't have a single test.


Add support for writing stacks with SIGUSR1

@runcom @umohnani8 @rhatdan PTAL

/test all

/test kata-containers

/test e2e_rhel

/test kata-containers

Kata still complaining but this LGTM

@runcom Updated.

/test all

/test kata-containers

@runcom @mrunalp sorry with the inconsistent Kata CI here... We have some problems with the type of VM being assigned to our CI, meaning that sometimes they don't have the expected nested support, and we simply cannot run Kata on them.

@sboeuf okay, thanks for the info!

/test kata-containers

/lgtm


Mobile UI fixes

Minor mobile UI fixes needed.

"This is the development version of Oma.helsinki"

Close indicator (x) overlaps with text.

Landing page front: "Don't worry we have the answers! See help"

Arrow too small

Landin page services: "Not a user?"

Arrow too small

Screenshots in comments below.

Landing page, Services, Featured services: when page loads, koro-shape flashes on screen.

Probably because some of the contents is not available first and added after page load, which causes some flashing


Space between the Moocs cards has been reduced

#83 @smaranjitghose as suggested, I've  reduced the space between the cards and added some more cards to the moocs section.

Cards are overlapping a lot. Please fix this in the next PR

@smaranjitghose sure. Will do it.


Update index.md

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Greenstand is a growing repository with a great amount of people working it that's fighting poverty and climate change and poverty, and thus should be added to this list. The repositories I've suggested are for the overview of the repo and the Web Map, as well as the Android app.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

I'm not sure why this failed, the error message seemed unrelated

Failure:
collections::made-in-africa collection#test_0007_fails if a user, organization, or repository has been renamed [/home/travis/build/github/explore/test/collections_test.rb:90]:
Expected ["made-in-africa: praekelt/vumi has been renamed to praekeltfoundation/vumi", "made-in-africa: praekelt/junebug has been renamed to praekeltfoundation/junebug"] to be empty.
6429 runs, 151246 assertions, 1 failures, 0 errors, 0 skips
rake aborted!
Command failed with status (1)
/home/travis/build/github/explore/vendor/bundle/ruby/2.5.0/gems/rake-12.3.2/exe/rake:27:in <top (required)>' /home/travis/.rvm/rubies/ruby-2.5.1/bin/bundle:30:in block in '
/home/travis/.rvm/rubies/ruby-2.5.1/bin/bundle:22:in <main>' /home/travis/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in eval'
/home/travis/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `'
Tasks: TOP => test
(See full trace by running task with --trace)
Inspecting 8 files

Looks like https://github.com/github/explore/pull/496 is already following my suggestion, so I'll get that merged in and leave this open to continue the discussion.

I've merged in https://github.com/github/explore/pull/496. If you agree with my comments you can go ahead and close this pull request. Thanks again for your contributions.

That sounds like a fair assessment. I agree.


Week 3 Hacks Review Ticket

[x] Link to AppLab Quiz
[x] Link to AppLab Quiz Blog
[x] Link to Create Performance Task Planning/Draft
[x] Link to Personal Scrum Board

2.7+
I really like Emaad's Quiz and one thing I really liked was his creativity on this quiz. He really showed off his creativity on this quiz. I really saw it on the home page. I also liked that after answering each question, the score was told. Additionally, I like how he added an answer key at the end of the quiz which is really useful for anyone, and I am considering adding it to my quiz.
His blog showed the process of him making his quiz, but I do feel there was a lot of text, but some images would have been really useful to really see his process.
I also liked his post about how he plans on creating a performance task and how he really showed how he was able to get the points in a specific area of the create performance task.


.Net: 400 Bad request on GetChatCompletionsAsync with data config Beta8

Describe the bug
In dot net when calling the methods GetStreamingChatCompletionsAsync or GetChatCompletionsAsync I'm getting the following error:
{"error": {"requestid": "7518344f-0174-4007-bbd1-e21010acc0b8", "code": 400, "message": "Validation error at #/stop/str: Input should be a valid string\nValidation error at #/stop/list[str]: List should have at least 1 item after validation, not 0"}}.
I literally copied the code from the dot net -> examples. Find below my code:
var chatCompletion = new AzureOpenAIChatCompletionWithData(new AzureOpenAIChatCompletionWithDataConfig()
{
    CompletionModelId = <modelId>,
    CompletionEndpoint = <apiEndpoint>,
    CompletionApiKey = <apiKey>,
    DataSourceEndpoint = <apiEndpoint>,
    DataSourceApiKey = <apiKey>,
    DataSourceIndex = <indexName>
});

var chatHistory = chatCompletion.CreateNewChat();
var ask = "How did Emily and David meet?";
chatHistory.AddUserMessage(ask);

await foreach (var result in chatCompletion.GetStreamingChatCompletionsAsync(chatHistory))
{
    await foreach (var message in result.GetStreamingChatMessageAsync())
    {
        Console.Write(message.Content);
    }
}

Find below the screenshot of the packages I'm currently using:

Hitting this issue also, attempting to follow the example here https://github.com/microsoft/semantic-kernel/blob/main/dotnet/samples/KernelSyntaxExamples/Example54_AzureChatCompletionWithData.cs

Thanks for reporting this issue; we're going to look into this. Can you confirm that it's only an issue with AzureChatCompletionWithData?

AzureChatCompletionWithData

I have found the root cause. It is not only with AzureChatCompletionWithData. The issue is in the method FromRequestSettings(AIRequestSettings? requestSettings, int? defaultMaxTokens = null) from class OpenAIRequestSettings. When requestSettings is null, it creates a new instance with no StopSequences value. If i add the value for StopSequences property, the call to Azure Open AI succeeds, otherwise we get the mentioned error.

@SantanaEduardo  Thank you, is there any sample on how I can set the StopSequences ? or if you can provide us a sample with a OpenAPIRequestSettings. My code looks like below
var chatCompletion = new AzureOpenAIChatCompletionWithData(ConfigHelper.GetCompletionWithDataConfig());
var chatHistory = chatCompletion.CreateNewChat();
// First question without previous context based on uploaded content.
var ask = "some question?";
chatHistory.AddUserMessage(ask);
AIRequestSettings aIRequestSettings = new AIRequestSettings { };
var chatResult = (await chatCompletion.GetChatCompletionsAsync(chatHistory))[0];
var chatMessage = await chatResult.GetChatMessageAsync();
var response = chatMessage.Content;
var toolResponse = chatResult.ModelResult.GetResult().ToolContent;

@SantanaEduardo Thank you, is there any sample on how I can set the StopSequences ? or if you can provide us a sample with a OpenAPIRequestSettings. My code looks like below
var chatCompletion = new AzureOpenAIChatCompletionWithData(ConfigHelper.GetCompletionWithDataConfig()); var chatHistory = chatCompletion.CreateNewChat();
// First question without previous context based on uploaded content. var ask = "some question?"; chatHistory.AddUserMessage(ask);
AIRequestSettings aIRequestSettings = new AIRequestSettings { }; var chatResult = (await chatCompletion.GetChatCompletionsAsync(chatHistory))[0]; var chatMessage = await chatResult.GetChatMessageAsync();
var response = chatMessage.Content; var toolResponse = chatResult.ModelResult.GetResult().ToolContent;

You can just add a second parameter to the overloading method which expects requestSettings. Something like:
var result = chatCompletion.GetChatCompletionsAsync(chatHistory, new AIRequestSettings()             {                 ModelId = "<modelId>",                 ExtensionData = new Dictionary<string, object>()                 {                     { "MaxTokens", _promptOptions.ResponseTokenLimit },                     { "Temperature", _promptOptions.ResponseTemperature },                     { "TopP", _promptOptions.ResponseTopP },                     { "FrequencyPenalty", _promptOptions.ResponseFrequencyPenalty },                     { "PresencePenalty", _promptOptions.ResponsePresencePenalty },                     { "StopSequences", new string[] { "bot:" } }                 }             });

@SantanaEduardo  Unfortunately the same error occurred

@SantanaEduardo Unfortunately the same error occurred

Try with following values. Consider that Temperature,TopP,FrequencyPenalty, and PresencePenalty must have double values.
ExtensionData = new Dictionary<string, object>()
{
    { "MaxTokens", 4000 },
    { "Temperature",  0.7 },
    { "TopP", 1 },
    { "FrequencyPenalty", 0.5 },
    { "PresencePenalty", 0.5 },
    { "StopSequences", new string[] { "bot:" } }
}

All .Net issues prior to 1-Dec-2023 are being closed. Please re-open, if this issue is still relevant to the .Net Semantic Kernel 1.x release. In the future all issues that are inactive for more than 90 days will be labelled as 'stale' and closed 14 days later.


Adds foldMapA and foldMapA1

These are variants of foldMap that combine monoid/semigroup values inside of an applicative using liftA2 (<>). They can be used to do things like fmap mconcat . traverse f in a single traversal.

Wouldn't it make sense to just drop base<4.12? I don't think anybody will ever test with such an old GHC.

@ysangkok Since there is some discussion elsewhere about what versions of base we should support, I would rather just keep this PR as-is and address the bounds in a separate PR.

@ysangkok Since there is some discussion elsewhere about what versions of base we should support, I would rather just keep this PR as-is and address the bounds in a separate PR.

Agreed on both points (dropping it and doing so in a separate PR)


feat/nougat: integrate nougat from facebook research

Is your feature request related to a problem? Please describe.
Facebook released some package for improved pdf parsing https://github.com/facebookresearch/nougat
Describe the solution you'd like
it would be amazing if this was integrated into unstructured.

Nougat (Neural Optical Understanding for Academic Documents) is a 350M parameters ViT model that performs an OCR task for processing mathematical formulas of scientific documents into a markup language.
Scientific knowledge is predominantly stored in books and scientific journals, often in the form of PDFs. However, the PDF format leads to a loss of semantic information, particularly for mathematical expressions. This feature enhances accessibility to scientific knowledge in the digital age!

We have an model with a similar architecture already integrated in Unstructured, please check Chipper in our documentation. https://github.com/Unstructured-IO/unstructured

You can also process documents with nougat and then feed the markdown output into unstructured which accepts markdown files


allow deserializing time instances as RFC 3339 strings

 Lesbare Timestamps für Quell-JSONs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 16 (75.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 85.345%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

datatypes/src/primitives/time_instance.rs
12
16
75.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
28267

Relevant Lines:
33121

💛  - Coveralls

bors merge


Docs

Coverage decreased (-73.7%) to 26.263% when pulling e53e55f848fd402b41d75466d18dc96fd5b94acc on docs into 309500473de9d6eae9a15853196ee07430f801ac on master.

Coverage remained the same at 100.0% when pulling b5d638b3083c478d2df6090013c3f1afa64ecf0b on docs into 309500473de9d6eae9a15853196ee07430f801ac on master.


jspm compatibility

I tried using this library using jspm.
The file loads, the callback function of parseURL is never called.
Is this an incompatibility with jspm?
Any ideas?

I'm not familiar with jspm, but as long as it loads the js file in /dist/rss-parser.js everything should work normally.
There are some issues in the browser with CORS - most public RSS feeds don't allow you to fetch them from the browser without a proxy.  The callback should still be called though.
Happy to help debug if you're able to share more details.

Marking as closed - if anyone else has issues with jspm feel free to re-open


Message Type - Block Code

PatternFly component reference
Design Spec
Chat message that displays a block of code. PF component to be extended with additional styling.
Supports:

Code language indicator
Syntax highlighting
Copy to clipboard action

CodeBlockMessage component created and styled. Uses package to highlight syntax (applied obsidian theme). Will need to wire up to the Message component to display.


Impedance and Weight are stored in the DB only for 10 days

Hi,
When I wanted to look at my weight development over the past months I realized that the weight and impedance are stored only for 10 days.
Is this an error in my installation or is this intended?
The point in having this integration in the first place is for me to see how I develop over time. Would highly appreciate if this can be changed
KR
Milan

I think there is no link with the bodymiscale.

I have the same question. I just installed it, and I wanted to somehow display the development. Is there a way to store the measured data for years?

How long they are stored in the DB has nothing to do with this component.
On the recorder integration you can change the purge_keep_days settings, which has as default 10 days.
Please be aware that depending on our system increasing this value can have negative affects.


Removed azure-core-management so that it does not get built releasing

# DO NOT EDIT THIS FILE	# DO NOT EDIT THIS FILE
# This file is generated automatically and any changes will be lost.

Yeah, let's get confirmation from @mitchdenny

That's fine. Think of that more like a scare tactic for now :) it will hopefully be code generated in the future.


OLM operatorhubio infinite loop

Greetings not sure if this should go to the OLM repo but it only appears when installing falcon-operator.
The operatorhubio-catalog pods infinitely loop and never start.
➜  statefulissue git:(main) ✗ kgp
NAME                                READY   STATUS        RESTARTS   AGE
catalog-operator-765c45774c-qnvnw   1/1     Running       0          3h49m
olm-operator-9bb87877b-sc6rn        1/1     Running       0          3h49m
operatorhubio-catalog-2rh49         0/2     Terminating   0          0s
operatorhubio-catalog-2tfwp         0/2     Terminating   0          2s
operatorhubio-catalog-kf255         0/2     Terminating   0          1s
packageserver-5657dcbc44-895vq      1/1     Running       0          3h47m
packageserver-5657dcbc44-fd2pn      1/1     Running       0          3h47m`
Examples of an error i could grab was:
1)
Pod 'operatorhubio-catalog-gb84h': error 'pods "operatorhubio-catalog-gb84h" not found', but found events.
Events:
  Type     Reason     Age   From               Message
  ----     ------     ----  ----               -------
  Normal   Scheduled  5s    default-scheduler  Successfully assigned olm/operatorhubio-catalog-gb84h to gke-cluster-2-20-default-pool-d4df75be-l0sr
  Normal   Pulled     4s    kubelet            Container image "gcr.io/REDACTED/falcon-container:6.31.0-1409.container.x86_64.Release.US-2" already present on machine
  Normal   Created    4s    kubelet            Created container crowdstrike-falcon-init-container
  Warning  Failed     4s    kubelet            Error: failed to create containerd task: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: rootfs_linux.go:76: mounting "/var/lib/kubelet/pods/7
f7ea6dd-d50e-44a8-a867-477f055222f8/volumes/kubernetes.io~empty-dir/crowdstrike-falcon-volume" to rootfs at "/tmp/CrowdStrike" caused: stat /var/lib/kubelet/pods/7f7ea6dd-d50e-44a8-a867-477f055222f8/volumes/kubernetes.io~empty-dir/crowdstrike-falcon-volume: no such file o
r directory: unknown`

@isimluk thoughts on this issue?

@redhatrises, I have spent considerable amount of time of time trying to reproduce this, but had no luck.
@jshsp, is there anything particular (I mean non standard) worth mentioning on your cluster? Which version of OLM are you running?

Its all pretty standard - GKE environments - it also happened on different version of kubernetes.
It was the latest version of OLM at the time which was:

version: v0.19.1

@jshsp Is it still an issue with olm in your environment then?

I managed to get the the reproducer. Although, I got different error, I can see the crash loop.

Closing as there is no further movement on this, please re-open if the error is still persisting or there are further questions around this.


[WIP] Vertex AI Model Handler Prototype

Adds the POC for a Vertex AI model handler + a very simple example to the Python SDK.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Re-created and iterated on in #27091 since master was well ahead of where this PR was started.


Request: :3 smile

This is really old and popular one, which users miss in my apps. I fixed it locally, but
Current Facebook form (worse):

Former Facebook form (better):

Usually means something like:

which unicode standard code is used for this?

@WebReflection I'm currently trying to find some Unicode reference, but unfortuately without success.

beside some quirk code manipulated for Apple legacy reasons, this project adhere to Unicode standard.
We don't have FB or BB Forum emoticons here, we have emoji. If these are not defined by the standard, we won't block any random code that might collide in the future with a different standard symbol.
It's a pity because I like your work, but if there's no official code for it, I'm afraid it won't happen.

@WebReflection I've found some webapps using U+1F924 for :3 emoticon, but I think these two should be separate. Maybe this is missing in Unicode at all

@WebReflection I'll try to fill in this request to Unicode team (after googling how to do it first)

the ml is<EMAIL_ADDRESS>good luck :-)

I'll flag it as invalid until we have a code point to use

I sent an email with proposal, but that email address is not working (none of Unicode email address is working at the moment). Emails are returned back with server error :/ unlucky today

The procedure for proposing an emoji is described at Unicode’s emoji pages.
Drooling Face 🤤 may be appropriate, although it’s not the meaning I would have associated with :3 intuitively, and I would have expected a preference of either :)' or :)~ for it instead. The English Wikipedia’s list of emoticons shows it as a variant of smiling or being happy and hence of ☺🙂😊😀😁, but having cleaned up this article in the past I know that it’s not saying much.

@Crissov I know, you can see my proposal according to Unicode’s emoji pages I tried to send to both<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Proposal for CURLY LIPS Emoji.pdf

unicode@ is a mailing list for public discussion that you need to be subscribed to – don’t send it there. docsubmit@ should work, assuming you followed the Subject: header convention: “UTC Document Submission: Proposal for Curly Lips emoji”.
Your PDF is missing some inline emojis.

@Crissov I know, I tried docsubmit first, then many more, but none of them is working. By now I communicate with Unicode staff by contact form trying to find some alternative contact solution.

Okay. Note that UTC150 is this week, so they may be busy with that.

@Crissov not sure what your analysis has to do with code points. Are you mixing up emoticons with emoji or I am missing some context?
I have suggested a Mailing list, not sure what's that down vote neither.
There is indeed where I've been interacting for years now with the Unicode standard people.
I'll try to point this bug in there too, but suggesting not to subscribe? why is that? It's a welcoming ML.
Regards

Let's see how this goes.

Finally communication through website contact form lead to finding the issue and fixing it on Unicode side and I sent my proposal once more (for sure). @WebReflection thank you for your quick action

@WebReflection The thumb-down was because it sounded like you were suggesting to propose the emoji on the mailing list – that’ll just lead to pointers to /emoji/selection.html or /pending/proposals.html.

@dvorapa it looks like many raised the name issue, which is not aligned with what the rest of the world thinks about :3 meaning.
Just as heads up

@WebReflection :+1:

JFTR, in Skype, typing a :3 emoticon results in a sitting full-body kitty cat graphic being displayed, i.e. same result as with (cat).

Google products (Gmail, Hangouts, Chat) convert :3 (as well as :X), (=^..^=),  (=^.^=) and =^_^=) to Smiling Cat Face :smile_cat: nowadays. Two of my sources for Facebook emoticons – would be glad to find an official reference – also call it “Kitty”, hence probably 🐱, just one has it listed as “Curly lips emoticon”.
No major implementation seems to support the extended variant with hyphen nose, :-3.

I don't use Google products but it seems there is a conflict between Google+Skype's cat and Facebook's curly lips/enamored (to me two different emoticons). Recently I've got an email from Unicode, that proposed emoticon was merged into a bigger group of emoticons Unicode is working on and the whole group will be released together once it will be finished as a whole.

Finally it looks like Unicode in Emoji v11 (7th February) finally added the curly face emoji as "woozy face" with the following meaning:

tired
emotional
drunk
So this could finally be solved

"Woozy face" likely isn't going to be rendered as something closer to :-3, but the beauty of emoji is that you can use them in any way you prefer.


WIP: Lev 7.0

Adds outputs option which must declare all outputs and their sources

class MyRoutine
  lev_routine outputs: { title: :_self,
                         description: { name: DescriptionRoutine, as: :desc }
                         _verbatim: [SubRoutine, :totally_exists, { name: OtherSub, as: :other }] }
end

Adds a set function which sets the attributes mentioned in the outputs map

class MyRoutine
  lev_routine outputs: { title: :_self }

  def exec
    set(title: 'Hello, world')
  end
end

result = MyRoutine.call
result.title #=> 'Hello, world'

When you use run it sets all mapped attributes automatically

class OtherSub
  lev_routine outputs: { description: :_self }

  def exec
    set(description: 'Wow a description')
  end
end

class SubRoutine
  lev_routine outputs: { title: :_self, description: OtherSub }

  def exec
    set(title: 'Hello world')
    run(:other_sub)
  end
end

class MyRoutine
  lev_routine outputs: { _verbatim: { name: SubRoutine, as: :sub } }

  def exec
    run(:sub)
  end
end

result = MyRoutine.call

result.title #=> 'Hello world'
result.description #=> 'Wow a description'

first note on things to add / put back better: errors, working with activerecord errors (converting to lev), handlers, lev_form_for.

Also, finishing up ability to kill a background job would be good.

@jpslav Errors work begun with spec/errors_spec.rb , lib/lev/errors.rb, lib/lev/errors/error.rb, and #transfer_errors_from #fatal_error and #nonfatal_error in lib/lev/routine.rb
Feel free to let me know how I can make it more robust. I'm pretty sure #errors should just be the collection of Error instances instead of the #to_s version, but I thought this was a good first step

Currently lev's fatal_error won't actually rollback the DB state if the lev routine is called from inside a non-lev transaction. We could potentially either use requires_new: true when creating the transaction (in which case Lev should rollback its own internal state but not the outer transaction) or, if we want to rollback the entire thing, have Lev raise its own class of rollback error and/or maybe monkeypatch ActiveRecord::Transaction to rollback properly when that error is caught.

This is because Lev raises ActiveRecord::Rollback, which is caught and silently ignored by nested transactions: http://api.rubyonrails.org/classes/ActiveRecord/Transactions/ClassMethods.html#module-ActiveRecord::Transactions::ClassMethods-label-Nested+transactions

OBE

OBE


update bazaar plugin dependency

Hey, I just made a Pull Request!

upgrade @date-io/luxon to 2.* breaks the DataPicker in this plugin.
Previous commit: b47965b
related PR: https://github.com/backstage/backstage/pull/9223
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Hey :wave: this looks good, but we'd love to get a unit test in here that actually uses the date picker or something in order to catch this from happening next time 🙏


"Evaluate" does not use regional settings for number formatting (uses . instead of ,)

System Information (please complete the following information):

Model Builder Version: <IP_ADDRESS>0302
Visual Studio Version: 2022 17.1.4

Describe the bug
Evaluating the trained model when using single data is harder because I have to swap periods for commas, as we're using commas as decimal separators here (nb-no).
To Reproduce
Steps to reproduce the behavior:

Set comma as decimal separator
Train data using Tab-separated data (or any ohter I guess). The data uses . as decimal separator.
Go to Evaluate.
The Evaluaton will fail if I don't replace periods with commas, which can be time consuming.

Expected behavior
The number format should use the computers regional settings.
Screenshots

#1913

Sorry about this issue. It looks to be a duplicate of 1913. To work around the problem, you should be able to change the "." to ","
Please follow 1913 for updates on a fix. Thanks for reporting!


[TwigComponent] Html-like attributes aren't parsed correctly

Some attributes are not parsed correctly and throw exceptions or render badly when using html-like syntax.
All these ones works fine:
<twig:foo id="bar" />

{% set id = 'bar' %}
<twig:foo :id="id" />
<twig:foo id="{{ id }}" />

{% set id = 'foo' %}
{% set idSuffix = 'bar' %}
<twig:foo :id="id ~ idSuffix" />

But these ones aren't working as expected:
{% set id = 'bar' %}
<twig:foo id="prefix-{{ id }}" />

Twig\Error\SyntaxError:
Expected attribute name when parsing the "<twig:foo" syntax.

{% set id = 'bar' %}
<twig:foo id="{{ id }}-suffix" />

{# No exception, but only the id var is passed to the template: #}

{# Instead of: #}

{% set id = 'bar' %}
<twig:foo :id="id ~ '-suffix'" />
<twig:foo :id="'prefix-' ~ id" />

Twig\Error\SyntaxError:
Unexpected character "\".

Note: the last one came after I updated my dependencies to get #824, so I think it is a regression because it was working fine before.

Hi!
I just tried all of these (thanks for the GREAT report, btw) and they all work fine. About 1 hour ago, I merged #827, which really overhauled all of this handling. If you grab that commit and still have problems, definitely let me know.
Cheers!

Hi @weaverryan,
you are right, I just pull the latest changes and now it works like a charm.
I was unlucky to update my dependencies a few hours too early :D
Thanks a lot !

Haha, indeed - it was unlucky timing!


Fix typo on egressIPv6 test

Same egressIP object with same name can happen when running the whole test suite. In such a case, the test fails because it is already finding an egressIP called "egressip". This fix resolves that.

/cherry-pick release-4.15