Adding oc binary to bin path for multi stage test infra

What type of PR is this?
/kind feature
What does does this PR do / why we need it:
Adding oc binary to bin path for multi stage test infra
Which issue(s) this PR fixes:
Fixes NA
How to test changes / Special notes to the reviewer:
👀

@openshift/openshift-team-developer-productivity-test-platform We have started working on the migration to template based test to multi-stage test in the pr - https://github.com/openshift/release/pull/9431. In one of the step we need to copy the oc binary into the test container PATH as there is no direct inbuilt mechanism available in multi-stage based test yet.
Currently we just added a shell script in the pr https://github.com/openshift/odo/pull/3362, so that it provides a prerequisite to verify our odo test through pr -  https://github.com/openshift/release/pull/9431 against multistage infra without breaking our master as we still run on template based test.
This time we are more careful because we have already broken the master after we merged the pr - https://github.com/openshift/odo/pull/3351, so it seems any change in the docker file does not reflect in the log - https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_odo/3351/pull-ci-openshift-odo-master-v4.5-integration-e2e/1272481792233836544/artifacts/build-logs/root.log until we merge that in, is it expected ?, can you please verify the Dockerfile in pr - https://github.com/openshift/odo/pull/3362.

/lgtm

@openshift/openshift-team-developer-productivity-test-platform My lgtm is based on the reference - https://github.com/openshift-knative/serverless-operator/tree/master/openshift/ci-operator/build-image. I am unable to verify the current dockerfile changes locally because I am not sure how prow test infra consumes the Dockerfile. It would be great if you share the steps to verify such changes locally. cc_ @girishramnani

@amitkrout Using Dockerfile from the base branch (and not from the PR) is intentional behavior for building build roots: which seems to be your case (https://github.com/openshift/release/blob/master/ci-operator/config/openshift/odo/openshift-odo-master.yaml#L2-L4) so that behavior is expected.
Not sure what I am supposed to verify in that Dockerfile though - looks correct to me, it will add a script into your build root image. It is really not treated in any special way by the test platform, we basically just create an OpenShift build with your repository and that dockerfile as an input.

@amitkrout Using Dockerfile from the base branch (and not from the PR) is intentional behavior for building build roots: which seems to be your case (https://github.com/openshift/release/blob/master/ci-operator/config/openshift/odo/openshift-odo-master.yaml#L2-L4) so that behavior is expected.
Not sure what I am supposed to verify in that Dockerfile though - looks correct to me, it will add a script into your build root image. It is really not treated in any special way by the test platform, we basically just create an OpenShift build with your repository and that dockerfile as an input.

@petr-muller Thanks.
However i am doubtful in line number https://github.com/openshift/odo/pull/3362/files#diff-01f4ec918b634e024905add2f91a58abR9 because when i am building the docker file locally i am getting the error
Step 3/4 : COPY openshift-ci/build-root/check-oc.sh .
COPY failed: stat /var/lib/docker/tmp/docker-builder034733928/openshift-ci/build-root/check-
oc.sh: no such file or directory

Steps i followed:
$ pwd
/Users/amit/go/src/github.com/openshift/odo
$ git fetch upstream pull/3362/head:pull_3362
$ git checkout pull_3362
$ docker build -t localbuild openshift-ci/build-root/
[...]
Step 3/4 : COPY openshift-ci/build-root/check-oc.sh .
COPY failed: stat /var/lib/docker/tmp/docker-builder034733928/openshift-ci/build-root/
check-oc.sh: no such file or directory

@petr-muller I think test platform will also face the similar issue, no ?
NOTE: However docker build works when i replace line number 9 with COPY ./check-oc.sh .

I would like to be 100% sure that this doesn’t break CI before I approve it. So can we try that?

I would like to be 100% sure that this doesn’t break CI before I approve it. So can we try that?

Lets wait how @petr-muller sees the failure which i hit locally. As i mentioned above i am not sure if test platform will face the same issue or not. Ping @petr-muller

I'm sorry, but I'm really no expert on image builds, neither local not the ones in OpenShift. Test platform really only creates OpenShift builds, nothing more complicated than that. If you need support about OpenShift builds you'll need to talk to that openshift team (it used to be Developer Experience but it recently split afaik).

I'm sorry, but I'm really no expert on image builds, neither local not the ones in OpenShift. Test platform really only creates OpenShift builds, nothing more complicated than that. If you need support about OpenShift builds you'll need to talk to that openshift team (it used to be Developer Experience but it recently split afaik).

Even we are not concern about the build, actually i was trying it locally because i thought that the same way test platform consumes the Dockerfile. NVM, we will stick to your previous comment https://github.com/openshift/odo/pull/3362#issuecomment-645297535.
@girishramnani Please feel free to apply approve label

I would like to be 100% sure that this doesn’t break CI before I approve it. So can we try that?

@girishramnani We can confirm it just by creating separate branch and merge the updated Dockerfile in so that it won’t affect master. Then we can create a test pr in release repo to test the change, but i am not sure if this doable through the job config file, Anyway i have asked for suggestion in testplatform forum.

I would like to be 100% sure that this doesn’t break CI before I approve it. So can we try that?

@girishramnani We can confirm it just by creating separate branch and merge the updated Dockerfile in so that it won’t affect master. Then we can create a test pr in release repo to test the change, but i am not sure if this doable through the job config file, Anyway i have asked for suggestion in testplatform forum.

@girishramnani @prietyc123 As per the slack conversation, branch concept won't work. However, there is a hack we can use without breaking the master. Just need to create a Dockerfile in a separate context or a different Dockerfile name in same context within build-root and call the docker file in odo job configuration file.
Step 1:
Create a Dockerfile in openshift-ci/build-root/multistage/Dockerfile
$ cat openshift-ci/build-root/multistage/Dockerfile
# Dockerfile to bootstrap build and test in openshift-ci

FROM registry.svc.ci.openshift.org/openshift/release:golang-1.12

RUN yum -y install make wget gcc git httpd-tools

# This is a temporary change to make sure that it should run on both template based as well as multi-stage test
# will remove this change once we completely migrate to multi-stage test infra
COPY openshift-ci/build-root/check-oc.sh .
RUN ./check-oc.sh

OR
Create a Dockerfile in openshift-ci/build-root/Dockerfile.multistage
$ cat openshift-ci/build-root/Dockerfile.multistage
# Dockerfile to bootstrap build and test in openshift-ci

FROM registry.svc.ci.openshift.org/openshift/release:golang-1.12

RUN yum -y install make wget gcc git httpd-tools

# This is a temporary change to make sure that it should run on both template based as well as multi-stage test
# will remove this change once we completely migrate to multi-stage test infra
COPY openshift-ci/build-root/check-oc.sh .
RUN ./check-oc.sh

Step 2:
Merge this change into master
Step 3:
Create a odo job pr in https://github.com/openshift/release for verification. For example, replace dockerfile_path: openshift-ci/build-root/Dockerfile with dockerfile_path: openshift-ci/build-root/multistage/Dockerfile or dockerfile_path: openshift-ci/build-root/Dockerfile.multistage as per the steps you followed in Step 1 at line number https://github.com/openshift/release/blob/master/ci-operator/config/openshift/odo/openshift-odo-master.yaml#L4
Step 4:
Verify the job pr
Step 5:
If it works then merge it, else
Step 6:
Go to step 1 and update the Dockerfile to fix failure, then follow till Step 5
You can do cleanup step later
Clean up steps
Step 1:
Create a pr in odo repo to bring the updated Dockerfile to the previous structure and merge in, For example
$ ls openshift-ci/build-root/
Dockerfile      OWNERS          README.md       check-oc.sh

Step 2:
Create a pr in https://github.com/openshift/release to start using the updated Dockerfile path at line number https://github.com/openshift/release/blob/master/ci-operator/config/openshift/odo/openshift-odo-master.yaml#L4 and merge in.

However, there is a hack we can use without breaking the master. Just need to create a Dockerfile in a separate context or a different Dockerfile name in same context within build-root and call the docker file in odo job configuration file.

Thanks @amitkrout I think this is the perfect approach we can think of currently to avoid master break and get unblocked on multistage porting. I will implement the suggested change and do the clean up later.

Create a Dockerfile in openshift-ci/build-root/multistage/Dockerfile

+1

/lgtm

/test v4.5-integration-e2e

Checking http://nodejs-app-8080-app-zoacvglyfr.apps.ci-op-jfb2szlt-a9fea.origin-ci-int-aws.dev.rhcloud.com, for Hello nodejs UPDATED
try 0 of 90
Running curl with args [curl http://nodejs-app-8080-app-zoacvglyfr.apps.ci-op-jfb2szlt-a9fea.origin-ci-int-aws.dev.rhcloud.com]
Deleting dir: /tmp/378768619/abcd
Replacing "Hello" with "Hello odo" in /tmp/378768619/server.js
[curl]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[curl]                                  Dload  Upload   Total   Spent    Left  Speed
[curl]
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    42    0    42    0     0    755      0 --:--:-- --:--:-- --:--:--   763
[curl] Hello nodejs UPDATED world from node.js!

/retest

@kadel I would let you approve this one as you have been reviewing it from the start

/approve

/refresh


Adding active state to the navbar links

Describe the feature

When a particular navbar is clicked, the activated link should be in a different color.
As of now, when a particular nav link is clicked we couldn't identify which is clicked

Add ScreenShots

Now I am in the Transactions page.
But the transactions word is not highlighted by a different color

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@swetha5157 I would love to work on this issue. Kindly please assign me.

@swetha5157 assigned

Thankyou @RitiChandak for assigning this issue to me..


Whitepaper update (Clock synchronisation mechanism)

Whitepaper updated:

Clock synchronisation mechanism added
Lottery flow is corrected to match lower number of VRF evaluations
Appendix with a list of symbols added
Notations are fixed throughout the text
Structure and minor text fixes

Since last review:

Validation & maintenance algorithms added;
Lottery logic is fixed (separate committee identifiers added);
Notations and formatting are consistent within the text (or almost consistent);
Bibliography is extended with direct links.

WP_v1.1.pdf


Upgrade to Gradle 6

Context
Upgrade to Gradle 6.
Describe the solution you'd like
Upgrade the Gradle version used in build process to the newest 6 version.
This task can be divided into phases:

PoC - just build with Gradle 6 and try to estimate how much effort is to migrate
Upgrade -  actual upgrade, probably each module will be migrated simultaneously, starting with gradle plugins.
Verification - ensure are CI pipelines are working.

Additional context
Consider using Gradle Update for the future updates.

@oskarjerzyk please prepare fix for knotx-docker, knotx-gradle-plugins and knotx-starter-kit.


password error

Describe the bug
password error
To Reproduce

set Urocissa/gallery-backend/.env PASSWORD=123456
error log
2024-11-29T06:34:28Z WARN Urocissa::router::post::authenticate::_
Data guard Json < String > failed: Parse("123456", Error("invalid type: integer 123456, expected a string", line: 1, column: 6)).
2024-11-29T06:34:28Z WARN rocket::server::_
No 422 catcher registered. Using Rocket default.
^C2024-11-29T06:37:06Z WARN rocket::server
set PASSWORD=aabbcc
error log
024-11-29T06:39:37Z INFO Urocissa::public::config
config.json not found. Using default configuration.
2024-11-29T06:39:37Z WARN Urocissa::router::fairing
Unauthorized access attempt via fetch.
2024-11-29T06:39:37Z WARN rocket::server::_
No 401 catcher registered. Using Rocket default.

Dear @zhaoxueye,
I've implemented a fix in commit 2af1f7d that should resolve the issue you've encountered.
Please follow these steps to update to the latest version:
Update Instructions

Pull the Latest Changes from the Repository
Navigate to the project directory and pull the latest updates:
git pull

Rebuild the Frontend
Navigate to the gallery-frontend directory:
cd ./Urocissa/gallery-frontend

Build the frontend:
npm run build

Rebuild the Backend
Navigate to the gallery-backend directory:
cd ./Urocissa/gallery-backend

Build and run the backend using Cargo:
cargo run --release

Please let me know if this resolves the issue or if you need any further assistance, and kindly verify if the problem has been fixed.
Remark: After updating the password, you must restart the backend.


Probably worth adding android-support-v4 to build.gradle

Context: http://stackoverflow.com/a/17375109/198348
Useful when using ShadowApplication and so on.
I'll fill in the details/add a PR later.

Yeah this is a problem.
@erd I believe Robolectric 3 will fix this issue. Is that true?

Yes, Robolectric 3 will not have a dependency on the support-v4 library.

@erd I guess it'll still need to be installed via the sdk then. I reckon we add it as a dependency in the readme and add it to the compile dependencies until Robolectric 3 is out.


No correct behaivor of modal

The ion-autocomplete modal doesn't behaves like a normal modal and than gives me problems. For example, I can´t show a Ionic confirmation modal with the ion-autocomplete showing (appears behind the ion-autocomplete)

Hi @sebrojas14,
could you maybe provide a codepen where I can reproduce this issue? Then I can have a look at it.
Thanks and regards,
Guy

As soon as possible

How can I use ion-autocomplete on codepen? there is a CDN?

Ready: http://codepen.io/anon/pen/bprxwd

Hi @sebrojas14,
I just checked the codepen and you solution with chaning the z-index is the only way to solve that. By default Ionic has the following z-indexes: https://github.com/driftyco/ionic/blob/v1.1.1/scss/_variables.scss#L720 and therefore we need to set the z-index to 11 in the ion-autocomplete.css and this solves the issue. Would that be a solution for you? If yes I will change that and commit it to master.
Thanks for finding this issue!
Regards,
Guy

I don't know, because as I told you, with that z-index appears the popup but not the backdrop, so is not a complete solution, it has to be anotehr way.

I see the backdrop within the browser (Chrome). Can you maybe use the latest master with the changed CSS with the z-index set to 11? I also use the latest official Ionic version 1.2.4. What version do you use?

I use Ionic 1.2.4. What do you mean with "I see the backdrop within the browser (Chrome)" do you see it or do you see it in the page code?

I see the backdrop with the adapted (added the ionicPopup call) test html I use for the e2e tests: https://github.com/guylabs/ion-autocomplete/blob/master/test/e2e/ion-autocomplete.multiple-select.e2e.html :

And I see it in your codepen:

Yes but the backdrop should be over the ion-autocomplete, or not?

Sorry for the late reply. I just checked again and now I get your point with the backdrop ;). Well in this case there is no other way than doing it this way (setting the z-index to 11). Maybe you could also add a drop shadow to the dialog box with CSS such that this gets a little bit disconnected from the autocomplete modal. See https://forum.ionicframework.com/t/how-to-style-ionicpopup-alert/3228/5 for an example.

Hi,
I will close the issue as wont fix. Please reopen it if there is another option on how to fix this.
Thanks and regards,
Guy


Fix new coming bugs!

https://github.com/nanomq/nanomq/issues/1863

Need more benchmark tests

indeed, there is definitely performance degradation.


fix: wrong code on README.md

What does this change do?
fix README
Is it related to an exisiting bug report or feature request?
Pre-merge checklist

[x] I've read CONTRIBUTING.md
[ ] I've rebased my changes against the current HEAD of origin/master (if necessary)
[ ] I've added new test cases to verify my change
[ ] I've regenerated toml.hpp (how-to)
[ ] I've updated any affected documentation
[ ] I've rebuilt and run the tests with at least one of:

[ ] Clang 8 or higher
[ ] GCC 8 or higher
[ ] MSVC 19.20 (Visual Studio 2019) or higher

[ ] I've added my name to the list of contributors in README.md

That was not an error. Those are C++17 string view literals.

Having said that, it looks like the example is missing using namespace std::literals;. You could change your PR to add that and I'll accept it.


fail to build and install debian package in ubuntu 20.04

Describe the bug
fail to build and install debian package in ubuntu 20.04.
Platform
adl-s with ubuntu 20.04
Codebase
acrn-hypervisor commit id:3d8fa8094941077f8ee15a3def0f5e79a201a173
with the following debian patches:
0001-Update-gitignore-to-ignore-Eclipse-project-config.patch 0006-hv-Fixup-serial.conf-permissions.patch
0002-board-inspector-Fix-sys.path-for-all-internal-module.patch 0007-debian-Handle-etc-serial.conf.patch
0003-dm-Use-libdrm-library-for-drm-access.patch 0008-dm-Remove-dependency-on-libuuid.patch
0004-Adding-initial-native-Debian-packaging-for-ACRN.patch 0009-debian-Remove-build-dependency-on-uuid-dev.patch
0005-debian-Add-docker-build-helpers.patch 0010-Update-d-changelog.patch
Scenario
Building ACRN 3.0 for boards: adl-s-crb, cfl-k700-i7, nuc11tnbi5, tgl-vecow-spc-7100-Corei7, whl-ipc-i5
The scenarios used are:
adl-s-crb: partitioned, shared, hybrid, hybrid_rt
cfl-k700-i7: partitioned, shared, hybrid, hybrid_rt
nuc11tnbi5: partitioned, shared, hybrid
tgl-vecow-spc-7100-Corei7: partitioned, shared, hybrid
whl-ipc-i5: partitioned, shared, hybrid, hybrid_rt
To Reproduce
Steps to reproduce the behavior:

git clone acrn-hypervisor with 3d8fa8094941077f8ee15a3def0f5e79a201a173

add debian 10 patches

cd acrn-hypervisor

gbp buildpackage --git-ignore-new

See error:
gbp:info: Performing the build
dpkg-buildpackage -us -uc -ui -i -I
dpkg-buildpackage: info: source package acrn-hypervisor
dpkg-buildpackage: info: source version 3.0~2.gbp6418b0
dpkg-buildpackage: info: source distribution UNRELEASED
dpkg-buildpackage: info: source changed by Helmut Buchsbaum<EMAIL_ADDRESS>dpkg-source -i -I --before-build .
dpkg-buildpackage: info: host architecture amd64
dpkg-checkbuilddeps: error: Unmet build dependencies: acpica-tools (>= 20200326) python3-xmlschema
dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting
dpkg-buildpackage: warning: (Use -d flag to override.)
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui -i -I failed
gbp:error: 'debuild -i -I' failed: it exited with 29

copy debian package built from 21.04 ubuntu on TGL to 20.04 ubuntu on ADL-S

dpkg -i *.deb

The following packages have unmet dependencies:
acrn-devicemodel : Depends: libc6 (>= 2.33) but 2.31-0ubuntu9.7 is to be installed
Depends: libsdl2-2.0-0 (>= 2.0.12) but 2.0.10+dfsg1-3 is to be installed
Depends: acpica-tools (>= 20200326) but 20190509-1 is to be installed
acrn-lifemngr : Depends: libc6 (>= 2.33) but 2.31-0ubuntu9.7 is to be installed
acrn-tools : Depends: libc6 (>= 2.33) but 2.31-0ubuntu9.7 is to be installed
acrnd : Depends: libc6 (>= 2.33) but 2.31-0ubuntu9.7 is to be installed
grub-acrn : Depends: grub-efi-amd64
python3-acrn-board-inspector : Depends: python3-xmlschema but it is not installable
install-fail-adl-s.txt
Expected behavior
no error
but now it's complex to install some dependent lib.

Just follow the procedure given in https://github.com/projectacrn/acrn-hypervisor/pull/7398, but build for Ubuntu Focal Fossa:
user@host:~/work/acrn-hypervisor$ DISTRO=focal VENDOR=ubuntu debian/docker/acrn-docker-build.sh --git-ignore-branch

This will provide any missing packages and the correct dependencies. Do not forget to use the provided local APT repository on the target system for easy installation!
ATTENTION: Ubuntu & Debian ALWAYS use an initrd together with their kernel images. This is required to integrate with their system properly. As a consequence youe need a respective scenario providing a Linux_initrd, which is referred to in the grub-acrn package to build prober grub configurations at install time. This is why I provided shared+initrd scenarios for nuc7i7dnh and kontron-COMe-mAL10, which are the platform I have tested with.
BTW, on kontron-COMe-mAL10 I also testes Ubuntu 20.04 successfully.
P.S.: Please use at least commit b7f50ef980edaf6c7d51b72984d889edf0ba006e on master to apply the changes.

Package install and use has been proven to work with kontron-COMe-mAL10/shared-initrd on a Ubuntu 20.04 server distribution as described in https://github.com/projectacrn/acrn-hypervisor/pull/7398.


Contains Duplicate

You are given an integer array nums and two integers indexDiff and valueDiff.

Find a pair of indices (i, j) such that:

i != j,
abs(i - j) <= indexDiff.
abs(nums[i] - nums[j]) <= valueDiff, and
Return true if such pair exists or false otherwise.

I know the solution, Please assign me this issue.

hey can you please assign this to me for hacktoberfest2022


Mp/prod migration prep 2.3

fix s3 upload path
include scripts with reltool deployment
bypass orgs with missing users/clients/admins group
2.3.0 (pending final preprod validation)

ping @chef/lob

Some more changes here. I updated this so that we will still proceed with migration even if required groups are missing, just because of the number of cases I'm seeing in preprod where those groups are missing (~1700) is fairly high. This way, at least the container exists for the orgs, though if they decide to use it they'll need further assistance from support.

Also corrected an issue in which the comment stated we were adding acls to admins group, but we were actually adding to users a second time.


Interface app with schematic's REST API

The app currently interfaces with schematic through reticulate and as a result requires the host to install schematic and its dependencies. This is problematic if the host cannot install system libraries, for example on shinyapps.io. Using schematic's REST API with, for example, httr, would drastically simplify installation of the app by removing all python dependencies. First we need to determine which schematic endpoints Data Curator App requires and which are exposed through the REST API.

@afwillia closing this issue since we have others opened for that.


setItemPadding missing for Hybrid List, SwitchGroup and Accordion

When you touch the Properties for itemPadding
it mentions method setItemPadding (which isn't in the docs)
for Hybrid Accordion, List and SwitchGroup

Ditto for CheckBoxGroup and RadioGroup


Archlinux stats API

I love the idea to have an API with Archlinux statistics. It would be great to include in the json the timestamp of when the data was obtained. It would also be very useful to include information about the installed packages, available packages, distributions, etc.
I would love to contribute to the project, but I have never used haskell, the documentation to install and run the scraper would be very useful to be able to contribute with the development of the API. :hammer_and_pick:

I'll try get some instructions for how to install and run this tomorrow! Thanks for the suggestion.
There is a frontend project that uses this data as well at https://github.com/chrissound/ArchPackageCompareStats

@MrcRjs hello once again, sorry it's been a lot longer then I anticipated!
I've included a Dockerfile for this project (if it's helpful at all).
But otherwise for development you'd need to install stack (https://haskell-lang.org/get-started). After that it should be a simple stack exec. If you do run into any issue - let me know and I'll try my best to help.
It may be useful to have some understanding of Haskell though.

That Dockerfile is very useful 👍  Thank you @chrissound!


Apply attribute cantrips to skills

Thanks a bunch @seawalk24! Again!
Did you do a bit of checking the math by hand to see if the new values are right? Looks good to me if so.

@amoeba Yes, the math checks out.

Great, much appreciated.


Nested Comments Syntax Highlighting

Came across a section with a {% comment %} / {% endcomment %} tag around a block, which had then been wrapped with another {% comment %} tag set.

The second closing {% endcomment %} isn't picked up as a closing tag and the syntax highlighting doesn't reflect that. It seems to stop the syntax highlighting at the first {% endcomment %} regardless of the number of open {% comment %} tags

This came from trying to find a missing {% endcomment %} tag which turned out to be the parent in the nested comment tree, because the syntax highlight didn't pick it up, it wasn't immediately obvious that there was an unclosed comment tag other than theme-check bringing it up as missing.
This seems to only happen within a nested comment block, if the parent is left without a closing tag, the next opening {% comment %} tag works fine

Thanks for the report btw! Sorry took so long to fix 🙈


feat: use new api on programme listing page

Description
Music year: {owa_music_year}

Programme page to use new api
2023 api fixtures
update test

Issue(s)
Fixes #
How to test

Go to https://deploy-preview-2350--oak-web-application.netlify.thenational.academy
Click on programme listing pages, should look the same

Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

There are only two legacy programme listing pages (maths and combi sci ks4) and they both seem to work fine.

Looks like these two programmes are missing the legacy prefix on the database, i've flagged it with the other squads and have added fix for these programmes for now.

:tada: This PR is included in version 1.400.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Min SDK

PR based on #113  that :

increases the minimum SDK version to 14
updates all fragments and activities to use android.app.Fragment
remove unnecessary library (PreferenceFragment)

That actually is a good reason.
If this PR would have been base on the master, I would probably merge it after a short test. But since this also includes #113, I'll wait with it because I'd like to hear a word on #113 from @Doplgangr.

I know that I'm nitpicking. Except for the unclean reverted commit, this PR should be ready to merge.

Since I manually merged #113 into the master without e7281a5 and a585b56, you have to rebase this PR onto the current master:
git checkout master
git pull upstream master
git checkout min_sdk
git rebase master
git push origin -f

(Command just in case)

@L-Henke  thanks for the commands, I'm a not so good with Git

@L-Henke  thanks for the commands, I'm not so good with Git.

I looked into the recent activities and all seemed fine for me. The swift jump of SDK version really allows a better freedom in development and I'd love that.
(Currently it seems like there is no really serious bugs in the production version, so that those left out by the SDK version would most likely continue using the old version without too much problem.)
P.S.Sorry for being left out, I've been working on an upcoming exam but I'll be right back.


Compilation error: "error: identifier 'mask' is undefined"

I'm trying to compile mxnet on an Ubuntu 16.04 machine, and I've been getting multiple instances of this error when compiling (I pulled earlier today)

mxnet/src/operator/./broadcast_mask_op-inl.h(50): error: identifier "mask" is undefined

This is when it's trying to compile the broadcast_mask_op.cu file (when compiling it for CUDA). It's happening during the macro expansions mentioned below.
Line 50 - ElementwiseMaskForward
  MSHADOW_TYPE_SWITCH(ret->type_flag_, DType, {
    mshadow::Tensor<xpu, 2, DType> out = ret->FlatTo2D<xpu, DType>(s);
    ASSIGN_DISPATCH(out, req,
      // TODO(bing): swap because requirement of inplace, change mshadow later
      mask(rhs.get<xpu, 1, DType>(s), lhs.FlatTo2D<xpu, DType>(s)));
  });

Line 72 - ElementwiseMaskBackward
  MSHADOW_TYPE_SWITCH(lhs_grad->type_flag_, DType, {
    mshadow::Tensor<xpu, 2, DType> mout_grad = out_grad.data.FlatTo2D<xpu, DType>(s);
    mshadow::Tensor<xpu, 2, DType> mlhs_grad = lhs_grad->FlatTo2D<xpu, DType>(s);
    mshadow::Tensor<xpu, 1, DType> mrhs_data = rhs.data.get<xpu, 1, DType>(s);
    ASSIGN_DISPATCH(mlhs_grad, req_lhs_grad,
      // TODO(bing): swap because requirement of inplace, change mshadow later
      mask(mrhs_data, mout_grad));
  });

I've had a look around the source code myself, but I'm unable to determine what this 'mask' may be (I presume it's meant to be a function).
Any ideas/help would be appreciated.

http://mxnet.io/get_started/ubuntu_setup.html

That helped, might suggest sorting out the CMakeLists.txt file to use all the necessary libraries and error if it can't find them in Linux.


Re-training Suzuki dataset fails

Hi, thanks for your great work. I have some issues when trying to retrain the model on the Suzuki dataset with different train/val split.
I can successfully run the checkpoint you provided, and the RMSE is great. However, I tried to re-train Bert on Suzuki, the results are super weak. The loss cannot decrease, and the final predicted yields are the same. I used the default hyperparameters provided for training Buchwald-Hartwig, so this also might be the problem of hyperparameters. The prediction figure in evaluate dataset is as follow.

Here is my training script:
data_path = './data/Suzuki-Miyaura/random_splits/random_split_0.tsv'
output_dir = './trained_model/suzuki_miyaura/random_split_0'

split = 4096
# Data load
df = pd.read_csv(data_path, sep='\t')
# df = df.sample(frac=1)
# df.to_csv()
train_idx = df.index[:split].values
test_idx = df.index[split:].values

train_df = df.iloc[:split][['rxn', 'y']]
test_df = df.iloc[split:][['rxn', 'y']]
train_df.columns = ['text', 'labels']
test_df.columns = ['text', 'labels']

mean = train_df.labels.mean()
std = train_df.labels.std()
train_df.loc[:,'labels'] = (train_df['labels'] - mean) / std
test_df.loc[:, 'labels'] = (test_df['labels'] - mean) / std

print(train_df['labels'])
print(train_df['labels'].mean(), train_df['labels'].std())

# Load model
model_args = {
     'num_train_epochs': 15, 'overwrite_output_dir': True,
    'learning_rate': 0.00009659, 'gradient_accumulation_steps': 1,
    'regression': True, "num_labels":1, "fp16": False,
    "evaluate_during_training": False, 'manual_seed': 42,
    "max_seq_length": 300, "train_batch_size": 16,"warmup_ratio": 0.00,
    "config" : { 'hidden_dropout_prob': 0.7987 },
    "wandb_project": "rxn_yields",
    "wandb_kwargs": {
        "entity": "cjpcool",
    },
}

model_path =  pkg_resources.resource_filename(
                "rxnfp",
                f"models/transformers/bert_pretrained" # change pretrained to ft to start from the other base model
)

yield_bert = SmilesClassificationModel("bert", model_path, num_labels=1,
                                       args=model_args, use_cuda=torch.cuda.is_available())

yield_bert.train_model(train_df, output_dir=output_dir, eval_df=test_df)

Is there any problem in my script? If it might be caused by the unsuitable hyperparameters, could you provide them for re-implementing your results?
I greatly appreciate your brilliant work, and look forward to your response!

I've resolved this issue by setting "evaluation_during_training" to "true" by referring https://github.com/rxn4chemistry/rxn_yields/issues/7


[Bug] For users outside of Europe the entire app is non-functional unless you manually adjust the date.

Module
Dashboard
Describe the Bug
The next.js web UI for tinybirds analytics is broken for users that are not in Europe.  It will not show any data except for the 'users in the last 30 minutes' widget.
Per @tb-peregrine

This is actually a bug that we're aware of - the time select defaults to UTC - not local time, so when you select "Today" you're seeing tomorrow when it gets late in the day in the US. If you update the time selector, it should fix the problem.

Here's the full conversation in Slack:

Expected Behavior
All expected data should be shown.
To Reproduce
Load the web UI in the United States.
Details
No response

Hi @grempe!
First of all, thanks a lot for testing the Starter Kit, and taking the time to open these very useful issues.
We are on it, and we'll keep you posted here.
Thanks again, and sorry for the inconvenience 🙏

Hi @grempe, this should be now solved, thanks to @rmorehig.
I'll check tonight, when dates in UTC and EST are different, just to be 100% sure.

Possible typo.
https://github.com/tinybirdco/web-analytics-starter-kit/pull/26#discussion_r981128102

I am seeing the dashboard display data correctly now. Thx


x/pkgsite: Add button to toggle between light and dark theme

What is the URL of the page with the issue?
https://pkg.go.dev/fmt
What is your user agent?
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0
Screenshot
Not applicable.
What did you do?
I searched for a button to toggle the current theme from dark to light.
What did you expect to see?
A button with a sun/moon icon to switch between the light and dark theme.
What did you see instead?
Nothing.

See https://github.com/golang/go/issues/47421#issuecomment-893481259 :)


sorry, I try to use this method to remove my pdf's watermark, but error be happened. Can you detail describe the method one again? Here's what I did when I executed the error. Thanks ~~

c:\python\Python37-32\Remove-PDF-Watermark-master\src>pdf-watermark-removal.py -s=2 -o=output.pdf abc.pdf
2018-09-13 18:10:05,724 - INFO - Processing page 1/60
Traceback (most recent call last):
File "C:\python\Python37-32\Remove-PDF-Watermark-master\src\pdf-watermark-removal.py", line 129, in
main()
File "C:\python\Python37-32\Remove-PDF-Watermark-master\src\pdf-watermark-removal.py", line 119, in main
process_page(pdf, i, i < args.skip)
File "C:\python\Python37-32\Remove-PDF-Watermark-master\src\pdf-watermark-removal.py", line 80, in process_page
img = Image.frombytes(mode, size, data)
File "C:\Python\Python37-32\lib\site-packages\PIL\Image.py", line 2368, in frombytes
im.frombytes(data, decoder_name, args)
File "C:\Python\Python37-32\lib\site-packages\PIL\Image.py", line 799, in frombytes
raise ValueError("not enough image data")
ValueError: not enough image data

Seems the PDF file you want to process does not contain any image in the first page. Note that the script can only process scanned documents. If you are sure about that, try to skip the first page in your case.


Add die icon to Icon component

Make the item available in version 3 since it's available in version 2. PRs 632 and 636

code LGTM; not sure if it needs a review on Chromatic?

Probably not..  It has already been checked by @sai-san in the master branch.

I just realized the icon is misplaced. They are ordered alphabetically, but
since I originally gave it the name 'random' i placed it before the
'search' icon.
On Mon, 17 Oct 2022 at 12:10, Lucas Werkmeister @.***>
wrote:

@.**** approved this pull request.
code LGTM; not sure if it needs a review on Chromatic?
—
Reply to this email directly, view it on GitHub
https://github.com/wmde/wikit/pull/640#pullrequestreview-1143885448, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW5WN6D6MVO7C6AX5PRJQDWDUQ2TANCNFSM6AAAAAARG4IMFY
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Guergana Tzatchkova
Software Engineer
Wikimedia Deutschland e. V. | Tempelhofer Ufer 23-24 | 10963 Berlin
Phone: +49 (0)30 219 158 26-0
https://wikimedia.de
Keep up to date! Current news and exciting stories about Wikimedia,
Wikipedia and Free Knowledge in our newsletter (in German): Subscribe now.
https://www.wikimedia.de/newsletter/
Imagine a world in which every single human being can freely share in the
sum of all knowledge. Help us to achieve our vision!
https://spenden.wikimedia.de
Wikimedia Deutschland – Gesellschaft zur Förderung Freien Wissens e. V.
Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter
der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für
Körperschaften I Berlin, Steuernummer 27/029/42207.

I noticed that but wasn’t sure it was worth pointing out :sweat_smile: do you want to fix it?

The thing is that it's already merged in the other brach. Tbh i don't think
it's worth changing it in the master branch at least because it has been
released already.

Yeah, I think it’s fine as it is. If we want (and remember it in time), we can reorder the types next time we go to add one.


AMD GPUs cloud instances for MIGraphX development

Hi,
I would like to contribute to ROCm/MIGraphX.. however I dont have AMD gpu. I tried with AWS EC2 G4 (it has only AMD Radeon Pro V520 instance) which doesnt support ROCm. Kindly let me know if any another available cloud instances support ROCm?.

Please stay tuned... Azure has MI300X instances on preview mode currently. Alternatively, you could try building the CPU version. That way if you want to contribute to overall improvements to the graph compiler, you still are able to.

very well, thanks!


Gas coupons

Today, we cannot create recursive types that depend on non-dropable types. The most noticeable (and probably only) example is Felt252Dict which has Destruct but not Drop (squash must be called before the program terminates to guarantee safety).
The problem with types like Array<Felt252Dict> or Felt252Dict<Felt252Dict> is that we cannot write Destruct for them, which is no_panic (calling destruct must not panic). The reason is that we must loop over the array and call squash in each iteration. To compile, the loop must call the withdraw_gas libfunc (to pay for the iteration), which can panic if there is insufficient gas.
Gas coupons allow us to write recursive functions which do not call withdraw_gas, thus making types such as Array<Felt252Dict> possible to write. The idea is that every function has an associated coupon type, Foo::Coupon, alongside new libfuncs for buying the coupon coupon_buy()-> Foo::Coupon and call_with_coupon(..., __coupon: Foo::Coupon). The gas cost of coupon_buy is the cost of Foo, and the gas cost of call_with_coupon is constant (hardcoded in the compiler).
The following example shows how we can use the concept of coupons to define Array<Felt252Dict<T>>.
type Array<T> = Array<(T, ())>;
type Array<Felt252Dict> = Array<(Felt252Dict, DictArrayDestruct::destruct::Coupon)>

pub impl ArrayImpl<T> of ArrayTrait<T, -Drop<T>> {
    fn append(ref self: Array<T>, value: T) nopanic {
        // here we buy the coupon
    }

    fn pop_front(ref self: Array<T>) -> Option<T> nopanic {
        // here we reimburse for the coupon
    }

}

impl DictArrayDestruct of Destruct<Array<Felt252Dict<u8>> {
    fn destruct(self: Array<Felt252Dict<u8>) {
        match self.pop_front() {
            Option::Some((dict, c)) => {
                dict.squash();
                self.destruct(__coupon = c);
            },
            Option::None => {},
        };
    }
}

Note that the basic Array<T> becomes an array of pairs, where the second type is a coupon, which is the unit type in cases where we don't care about coupons. The coupon for Array<Felt252Dict> is associated with the function DictArrayDestruct::destruct. Since the recursive call to destruct is done with the coupon, the compiler knows it does not need to inject a withdraw_gas instruction in destruct; the coupon pays for a single iteration of the destruct function (note that it does not attempt to cover the price of dict_squash, but only that of the loop, the costs for dict squashing is pre-paid on dict operations, i.e. the cost of dict_squash is considered to be 0 by the gas solver). By changing the Array type always to be an array of tuples and implementing the array trait differently only for none droppable types, we were able to define a none panicking destruct.

Coupons are now supported.
What is missing is high level support for a general array of destructible objects.


Add serializer and deserializer for NaiveDate

Contribute to LIG-4120

Current dependencies on/for this PR:

main

PR #26   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 4, 1:57 AM: @zhenlu merged this pull request with Graphite.


OpenVPN on 16.03-beta fails because it can't ask for a password.

Basic info
To make sure that we are on the same page:

Kernel: Linux NdNdNx 4.4.3 #1-NixOS SMP Thu Feb 25 20:01:36 UTC 2016 x86_64 GNU/Linux
System: <IP_ADDRESS>8621 (Emu)
Nix version: nix-env (Nix) 1.11.2
Nixpkgs version: <IP_ADDRESS>8621

Describe your issue here
After upgrading from 15.09 to 16.03-beta, openvpn units aren't able to ask for a password.
Expected result
When running start openvpn-myvpn I am prompted for my VPN credentials.
Actual result
OpenVPN fails with the following logs:
[grahamc@NdNdNx:~]$  start openvpn-myvpn
==== AUTHENTICATING FOR org.freedesktop.systemd1.manage-units ===
Authentication is required to start 'openvpn-myvpn.service'.
Multiple identities can be used for authentication:
 1.  System administrator (root)
 2.  grahamc
Choose identity to authenticate as (1-2): 2
Password:
==== AUTHENTICATION COMPLETE ===
Job for openvpn-myvpn.service failed because the control process exited with error code. See "systemctl status openvpn-myvpn.service" and "journalctl -xe" for details.

[grahamc@NdNdNx:~]$ systemctl status openvpn-myvpn.service
● openvpn-myvpn.service - OpenVPN instance ‘myvpn’
   Loaded: loaded (/nix/store/6h7lhxr9m2kfwvlz4jrafds5yr12dwg6-unit-openvpn-myvpn.service/openvpn-myvpn.service; ba
   Active: inactive (dead)

Mar 17 09:48:18 NdNdNx openvpn[15546]: Thu Mar 17 09:48:18 2016 neither stdin nor stderr are a tty device, can't ask for Auth pas
Mar 17 09:48:18 NdNdNx openvpn[15546]: Thu Mar 17 09:48:18 2016 Exiting due to fatal error
Mar 17 09:48:18 NdNdNx systemd[1]: openvpn-myvpn.service: Main process exited, code=exited, status=1/FAILURE
Mar 17 09:48:18 NdNdNx systemd[1]: Failed to start OpenVPN instance ‘myvpn’.
Mar 17 09:48:18 NdNdNx systemd[1]: openvpn-myvpn.service: Unit entered failed state.
Mar 17 09:48:18 NdNdNx systemd[1]: openvpn-myvpn.service: Failed with result 'exit-code'.
Mar 17 09:48:19 NdNdNx systemd[1]: openvpn-myvpn.service: Service hold-off time over, scheduling restart.
Mar 17 09:48:19 NdNdNx systemd[1]: Stopped OpenVPN instance ‘myvpn’.
Mar 17 09:48:19 NdNdNx systemd[1]: openvpn-myvpn.service: Start request repeated too quickly.
Mar 17 09:48:19 NdNdNx systemd[1]: Failed to start OpenVPN instance ‘myvpn’.

On 15.09 I did have to run sudo systemd-tty-ask-password-agent --watch to be prompted for the password, however the new behavior is openvpn fails immediately.
Steps to reproduce

Have a VPN which requires a username and password to log in, where the password is a rotating key and is not able to be saved in a credential file.
Use the configuration reference below ...
Attempt to connect

Configuration:
  services.openvpn.servers.myvpn = {
    autoStart = false;
    config = ''
      client
      dev tun
      proto udp
      remote VPNDOMAIN 1194
      resolv-retry infinite
      nobind
      persist-key
      persist-tun
      key-direction 1
      comp-lzo
      verb 3
      auth-user-pass
      auth-nocache
      ca /root/vpn/myvpn/ca.crt
      cert /root/vpn/myvpn/cert.crt
      key /root/vpn/myvpn/key.key
      tls-auth /root/vpn/myvpn/ta.key
      reneg-sec 0
    '';
  };

Temporary Workaround
Cat the service file and execute it manually:
/nix/store/7zigjvcbgfrs26a197bgswlr9clb402g-openvpn-2.3.8/sbin/openvpn --config /nix/store/2jh3wjhzrg96dryv4d3a7rcah3jz2z98-openvpn-config-myvpn

and it will connect and prompt for the password correctly.

It appears this can be fixed by backporting 38afa836b3d9eba56a4686ff81980b98921130e2 to 16.03.

Already done in 115cb2f7800574afadf98f8869d1655f0075b4ee.

Thank you!


add Digest Agent

Similar to Email Digest Agent, except it will emit a digest event
instead of sending email. It could be useful to send digest message
through meanings other than email.

Nice @xu-cheng, this is a cool idea!  You may want to queue up the event ids instead of the full payloads, then load the events from received_events.where(ids: memory['event_ids']) so that the memory in the DB doesn't grow too large?

Updated to store event ids. But I have no luck to load events back, would mind to help me to sort this out?

Figured it out :)
Add
@checker.sources << agents(:bob_rain_notifier_agent)
@checker.sources << agents(:bob_weather_agent)

in your "should emit a event" spec so that the Agents are actually wired together.

Thanks. Now it works as expected.

This looks great to me!  The only other question that I have is whether you should add support for sorting the output payloads by events_order like the WebsiteAgent, RSSAgent, and DataOutputAgent?  See description_events_order and sort_events.  I think it might be as simple as:
events = sort_events(received_events.where(id: self.memory["queue"]).order(id: :asc).to_a)

(Does that look right, @knu?)

Sorry about the delay, but may I ask how to use events_order in form_configurable?

Hmm, good question.  It may only work in the JSON editor view?  @knu

@cantino I think that is true, form_configurable does not a dynamic options structure. Could we add support to use the JSON editor only for certain attributes?

I was thinking that form_configurable mode still showed the optional JSON editor, but I'm remembering incorrectly.  I guess for now we could either make this not form_configurable, or not use events_order until someone needs it.  I'm fine with either.

OK, I kept form_configurable and removed events_order. Because I found form_configurable quite helpful to format final message.

Nice @xu-cheng!  Is this done?  I haven't manually tested it, but I trust that you have.  We can merge when you're ready.

Yes, it's done.

Thanks for contributing this!


Switch to postcss + css variables

Also simplify site and build steps and some general cleanup.
I was experimenting with switching this over to post-css for a while now, and here is the result of that work.  The main advantage is that style.css is based on css variables, so doing things like dark mode are a bit easier, since you can just switch out pointer vars and things like that.
wdyt @ungoldman ?

Oh, one other thing, I fixed a bug in post-css cli, so landing this will depend on that: https://github.com/postcss/postcss-cli/pull/286

The other ope questions would be:

How to handle the website.  Maybe put this version in /v2/style.css and also ship a copy of the old version at the current URL. Or should we just recommend unpkg urls only?
Is this a path you want to go down?
Should we support dark mode out the box?

Also, I should still go through the docs and website to make sure all that info is up to date.

Notes for darkmode support via @feross

https://twitter.com/feross/status/1142878047617425408
https://webkit.org/blog/8840/dark-mode-support-in-webkit/
https://bugs.chromium.org/p/chromium/issues/detail?id=939811
https://github.com/feross/color-scheme-change

Hey @bcomnes, I'm out on vacation for a few more days so I won't be able to give this a full review until next week. However at a glance, this looks like a lot of different major breaking changes! I get the sense that in addition to switching to postcss, there are also changes in where the distribution files are kept, how source files are organized, possibly changes in design, a new dark mode that I'm not sure how to review, major bumps for almost all dependencies, major readme file changes, changes to CI setup, and probably other stuff I'm not yet aware of? In summary this is ... unreviewable? It would be a lot easier to review if this were broken up into PRs with separate concerns. I can't reasonably say this is OK to merge when I have no idea how much has changed and what this will break.

Yeah sorry, the work resulted from wanting to iterate on what was here in a somewhat breaking way.  I originally was intending to create a personal fork with these changes, but I figured it would be worth offering them up as an upstream change before I settle for that.
Basically it boils down to these changes:
Switch to using css variables instead of sass variables
CSS variables make it easier to support dark mode themes and generally can assist in simplified theming when it comes to colors and such.  It also makes it easier to support the serif variant.  All you need it to override a var instead of use a different css file.
Support dark mode by default
Still a WIP but it would be a nice addition I think to support this by default.
Move the preprocessor to postcss
Provides a lot of the same features, with a syntax closer to theoretical future css.   Personal preference, not sure where you are on this one.
Reorg the website
This work came out of the original motivation (soft personal fork to achieve the above goals) and was finished before I decided to offer up the changes to you in this repo.

How to reconcile.  Are you interested in any of the above changes landing here? I'm guessing maybe the css-var support and dark mode?  The post-css and website reorg were mainly the path I took to try those out and are the bigger change.
In terms of what would break.  The release would be a breaking change 2.0.  The website would be updated, and people consuming from unpkg without a major version number might break.  Also old browser that don't support css vars would break.
The other alternative is to do a soft fork, maybe like @bret/style.css or something.

Sorry @bcomnes, I don't mean to be keep blocking your PR, I've just had no time at all in the last month for open source. 😭
If you want to just keep going with it feel free to do the soft fork, I'll try to pull it down and do a real review soon. 🤞

No problem at all 🤗 happy to converge in the future if it makes sense


Add more options to animation

Hey! Amazing repository.
I already integrated in a sample app using ionic 2 here and it worked perfectly!
I was wondering if you are planning on adding more options like play, pause and stop animations, as well as set loop or autoplay. I'd like to contribute to this repo, but I'm not certain how.
thank you so much for doing this! :1st_place_medal:

Thanks for issuing this repo!
I made a little change to support loop and autoplay feature on release 0.0.4
I'll continue working on some animation instances features, but If you want to do some contribution, I'm more than happy to see your pull requests, or would you like me to add you into contributors?

Nice! I'd love to be one of the contributors. I'll take a look on what I can do now to help, but if you already have some suggestions in mind, please let me know! Perhaps open an issue so I have some guidance?
What do you think?
Thanks!

Cool! I already added you as a contributor.
One more thing I've done today is, I output an animation instance from the component, which could use instance features.
And another thing in my mind is, in theory this component doesn't support multiple animation views, because here (I didn't test it yet...)
Please add any new features if you need :-)
Thanks a lot!


More robust and dynamic multi-slicing TPU training

The current way multi-slicing training is not robust or reliable on spot instances.
There have been some discussion inside CRFM and with GCP team on this topic. I create this issue to capture the main ideas and threads.
Main Objectives

Implement a more robust system that will provision multiple TPU slices and allocate workload on available slices, by constantly monitoring the status of slices.
Take a step further, to use Ray to coordinate multiple training jobs on single slice as well as a single training runs on multi slice

Challenges

For spot instances in TRC, we could not directly use GKE service. It is due to lack of ability to disable TPU billing via GKE. Therefore, many of the tricks and techniques implemented on GKE is not available to us, including Pathways,

Possible Ideas
Use Ray for scheduling
Allen Wang from Google proposed to use Ray to schedule and run workloads through slices. He put together a quick gist on how to run both single and multi-slice workloads via Ray (>= 2.10.0). This covers the job scheduling aspect and will work regardless if the cluster is provisioned directly on VMs or on GKE.
To mitigate potential race conditions, Allen also added placement groups to pre-reserve existing TPU pod slices (ray_tpu.py) and an example of how it can be used to run tasks (ray_tpu_task.py)
David's summarization:

We would spin up a ray head node as a job scheduler
tpu slices register with the head node (each worker runs ray start)
we launch a multislice tpu job by getting a set of named worker 0s, setting the env variables, then launching the real job

Use a host to coordinate work and communicate gradients
@dlwh 's idea:

spin up individual slices as more or less atomic units.
They run their own SPMD job as levanter instances.
However, they also phone home to some coordinator machine.
coordinator assigns work units (batches) to slices, tells them how to communicate the gradients. JAX has an experimental “jax.lax.infeed” and “jax.lax.outfeed” for sending and receiving values from the host. The host receives the appropriate gradients from the device (using outfeed), communicates them to the other hosts (using a tree or something fancy), then sends the accumulated gradients via infeed.
The trick will be scheduling this to maximize throughput, since I don’t know how to tell XLA how long something will take.
To make things reproducible, you’ll have to be very careful, ensuring that you reduce batches in the same order even in the presence of slices dropping out. To do this, you will likely have to either use a lot of host memory and/or accept recomputing batches.

These two ideas can be fused pretty well I think, fwiw.

I could reproduce Allen's script on single slice v4 TPU, but not on multi-slices. It should not be a blocker for now, if we are not prioritizing multi-slice training.
Now I think more of it, I realized that this is not the shortest path. I should instead take reference of Marin's existing Ray + TPU framework for launching data preparation jobs. It seems to be a more applicable guide.
I will try to follow https://github.com/stanford-crfm/marin/tree/main/infra#maintaining-a-ray-cluster and build a PoC for training.

sounds like a good plan! The main difference is that Allen's script handles multi-node TPU slices, which the marin cluster doesn't bother with.

I will run experiment with larger TPU nodes then


[Question] What is the difference between https://catalog.redhat.com/ and https://operatorhub.io/

Can someone help to answer this question? Thanks.
FYI @horis233

got some info from https://www.redhat.com/en/blog/new-kubernetes-operatorhub-red-hat-openshift-enable-hybrid-cloud-flexibility-enterprises

But what is the guidance for where to publish my operators, in Red Hat OpenShift Certified Operators or community operators?

I have two questions for this topic:
Q1:

According to my surmise, in OCP 4.3,  the operators within provider type RED HAT are certified operators provided by Redhat. The only exception is the Container-native virtualization.

Q2:
I find many operators are provided by both Community and Certified . Should our operators be published to both of them as well?

I also have a question for this topic:
The repository says it is the source of all operators, what are the difference upstream-community-operator and community operators?
I found none is the subset of the other. This means some operators which are in upstream-community-operator are not in community operators and vice versa. Plus on the operator page, I see some of the operators on the RedHat catalog which are not even a part of any of upstream and community. Are they getting served from any other repo?

@here this question is coming very often so I opened this issue https://github.com/operator-framework/community-operators/issues/1776
From my understanding (I am not a Red Hat employee nor a maintainer of this repository):

the folder upstream-community-operators of this repository is made for operators that will work on vanilla kubernetes
the folder community-operators of this repository is made for operators that will work on OpenShift (the tag "community" in the OpenShift console)
the RedHat certified tag in the OpenShift console is for operators that are provided through the Red Hat marketplace and made for commercial partners of Red Hat. This is meant to be the "officially and commercially supported operators"

@RyuunoAelia I am working on a tool that will install a given CSV into the cluster. I tried installing a community-operator from community-operator/community-operators (Not meant for k8) into the k8 cluster, and it worked fine. So I am now interested in knowing what is the actual difference, apart from upstream are preferred for the Kube clusters.

@rvsingh011 most probably (most it not all) operators made for OpenShift will work on a vanilla k8s cluster as-is.
OpenShift is a kubernetes cluster with more security stuff on top of it. So generally if an application runs on OpenShift it will run on k8s. In the case of an operators, you generally don't want it to modify automatically your security settings, so they should work on k8s.


chore(headless): add commerce entry to quantic use case mappings

Adding the current browser commerce headless distribution as a static resource in Salesforce is not compatible with the LWC environment.
To enable Coveo Headless Commerce in Salesforce, a commerce use case needs to be added to the quanticUseCaseEntries to support this functionality effectively.
#4677
https://coveord.atlassian.net/browse/KIT-3741

Jira created : https://coveord.atlassian.net/browse/KIT-3741


Allowing ports to be string so that they can be variable refs

Description
Safety checklist

[x] This change is backwards compatible and safe to apply by existing users
[x] This change will NOT lead to data loss
[x] This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?
Manually

@bigbitbus excellent suggestion


add materialization to run results table

Adds the materialization field to the dbt_run_results table, addressing ELE-847.

Thank you @arilmav!
Code works as expected 👌🏻
I think that it would also be good to change the views model_run_results and snapshot_run_results to select the materialization from the results instead of the metadata model.
This will make the view more accurate, as it will handle the case of a change in materialization (will show the relevant materialization for each run and not the current one).
To maintain backward compatibility and avoid NULLs, I suggest coalesce(run_results.materialization, models.materialization).
Want to add that to the PR as well?

Thank you @arilmav! Code works as expected 👌🏻
I think that it would also be good to change the views model_run_results and snapshot_run_results to select the materialization from the results instead of the metadata model. This will make the view more accurate, as it will handle the case of a change in materialization (will show the relevant materialization for each run and not the current one). To maintain backward compatibility and avoid NULLs, I suggest coalesce(run_results.materialization, models.materialization).
Want to add that to the PR as well?

Done!


Increase timeout for nREPL

@pratik-fractl I think some formatting changes unrelated to the fix is there in the PR, can you please revert those?


set data to be cached to fix bug where files were always being resized

Hi, thank you for your PR!  Can you please elaborate on the issue you were having, explain your change, and provide a test case showing this fixes it?  I am happy to look into the issue further.
Right now, this change appears to fail all the caching tests and several others (after I fix the failing lint due to the trailing semicolon):
$ npm run test                                                                                [18:48:28]

><EMAIL_ADDRESS>test
> eslint *.js test/**.js && ava

  ✔ generates html with svg
  ✔ generates html without svg
  ✔ generates html without manifest
  ✔ errors on file not found
  ✔ errors on not square img
  ✔ errors on too large apple padding
  ✖ generates from test png
  ✖ generates from test svg
  ✖ caches given same src and dest
  ✖ generates with extra manifest data
  ✖ generates without manifest
  ✖ does not cache if skipCache specified
  ✖ does not cache if options differ
  ✖ generates from arbitrarily sized square pngs
  ✖ generates from arbitrarily sized square pngs with apple padding override
  ✖ does not cache if file modified
  ─

  generates from test png

  test/test.js:54

   53:   t.is(expectSvg, fs.existsSync(path.join(outDir, expectedFiles['svg'])));
   54:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['ico'])));
   55:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['apple'])));

  Value is not truthy:

  false

  › assertCorrectIcons (test/test.js:54:5)
  › test/test.js:96:9

  generates from test svg

  test/test.js:53

   52:
   53:   t.is(expectSvg, fs.existsSync(path.join(outDir, expectedFiles['svg'])));
   54:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['ico'])));

  Difference:

  - true
  + false

  › assertCorrectIcons (test/test.js:53:5)
  › test/test.js:89:9

  caches given same src and dest

  test/test.js:53

   52:
   53:   t.is(expectSvg, fs.existsSync(path.join(outDir, expectedFiles['svg'])));
   54:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['ico'])));

  Difference:

  - true
  + false

  › assertCorrectIcons (test/test.js:53:5)
  › test/test.js:163:9

  generates with extra manifest data

  test/test.js:53

   52:
   53:   t.is(expectSvg, fs.existsSync(path.join(outDir, expectedFiles['svg'])));
   54:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['ico'])));

  Difference:

  - true
  + false

  › assertCorrectIcons (test/test.js:53:5)
  › test/test.js:112:9

  generates without manifest

  test/test.js:53

   52:
   53:   t.is(expectSvg, fs.existsSync(path.join(outDir, expectedFiles['svg'])));
   54:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['ico'])));

  Difference:

  - true
  + false

  › assertCorrectIcons (test/test.js:53:5)
  › test/test.js:103:9

  does not cache if skipCache specified

  test/test.js:53

   52:
   53:   t.is(expectSvg, fs.existsSync(path.join(outDir, expectedFiles['svg'])));
   54:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['ico'])));

  Difference:

  - true
  + false

  › assertCorrectIcons (test/test.js:53:5)
  › test/test.js:182:9

  does not cache if options differ

  test/test.js:53

   52:
   53:   t.is(expectSvg, fs.existsSync(path.join(outDir, expectedFiles['svg'])));
   54:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['ico'])));

  Difference:

  - true
  + false

  › assertCorrectIcons (test/test.js:53:5)
  › test/test.js:224:9

  generates from arbitrarily sized square pngs

  test/test.js:54

   53:   t.is(expectSvg, fs.existsSync(path.join(outDir, expectedFiles['svg'])));
   54:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['ico'])));
   55:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['apple'])));

  Value is not truthy:

  false

  › assertCorrectIcons (test/test.js:54:5)
  › test/test.js:133:11
  › async test/test.js:118:3

  generates from arbitrarily sized square pngs with apple padding override

  test/test.js:54

   53:   t.is(expectSvg, fs.existsSync(path.join(outDir, expectedFiles['svg'])));
   54:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['ico'])));
   55:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['apple'])));

  Value is not truthy:

  false

  › assertCorrectIcons (test/test.js:54:5)
  › test/test.js:155:11
  › async test/test.js:140:3

  does not cache if file modified

  test/test.js:54

   53:   t.is(expectSvg, fs.existsSync(path.join(outDir, expectedFiles['svg'])));
   54:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['ico'])));
   55:   t.assert(fs.existsSync(path.join(outDir, expectedFiles['apple'])));

  Value is not truthy:

  false

  › assertCorrectIcons (test/test.js:54:5)
  › test/test.js:210:9

  ─

  10 tests failed

Hi @elvece it has been over a year -- if you have any notes in reply to my comment above I am happy to take another look.

Hi @elvece it has been over a year -- if you have any notes in reply to my comment above I am happy to take another look.

Hi there, apologies, I spaced on this. Let me revisit this week and address your comment.

@NJAldwin I'm having trouble re-creating this on my machine (macOS 14.5), but the issue a  previous co-worker on Linux (don't have system details) had was that the favicon files (specifically the apple-touch-icon.png, icon-192.png, and icon-512.png) were being regenerated every time the project was built, causing a git difference (example). IIRC the change I made fixed this for him, but I see now that it's probably not the right solution. Since I cannot re-create, I will close this PR and re-open with the appropriate details should it occur again.


BUG: fail in call to generate_dict_da in train_model function in train_network.py

I'm trying to run the train_model function from the train_network.py file, and I get the following error message: "ValueError: need more than 2 values to unpack"
It's caused by this line:
https://github.com/neuropoly/axondeepseg/blob/2def1c0a022b009ba9c81ae96e9b3f36ab66f150/AxonDeepSeg/train_network.py#L52
that calls this one:
https://github.com/neuropoly/axondeepseg/blob/2def1c0a022b009ba9c81ae96e9b3f36ab66f150/AxonDeepSeg/train_network_tools.py#L82
It could be related to the changes in the config_file. https://github.com/neuropoly/axondeepseg/issues/114

@oumayb could you post (or copy-pase) the config_network file you're trying to use?

Sure, it's this one:
{
"learning_rate_decay_period": 24000,
"batch_norm_decay_decay_period": 16000,
"learning_rate_decay_type": "polynomial",
"batch_norm_decay_decay_activate": true,
"learning_rate_decay_activate": true,
"learning_rate_decay_rate": 0.99,
"batch_norm_decay_ending_decay": 0.9,
"depth": 4,
"weighted_cost-activate": true,
"weighted_cost_balanced-activate": true,
"weighted_cost_balanced-weights": [
1.1,
1,
1.3
],
"weighted_cost_boundaries_sigma": 2,
"weighted_cost_boundaries_activate": false,
"batch_norm_activate": true,
"thresholds": [
0,
0.2,
0.8
],
"trainingset_patchsize": 512,
"learning_rate": 0.001,
"downsampling": "convolution",
"batch_size": 8,
"da-type": "all",
"da-random_rotation-activate": false,
"da-noise_addition-activate": false,
"da-elastic-activate": true,
"da-shifting-activate": true,
"da-flipping-activate": true,
"da-rescaling-activate": false,
"n_classes": 3,
"batch_norm_decay_starting_decay": 0.7,
"trainingset": "SEM_3c_512",
"size_of_convolutions_per_layer": [
[
5,
5,
5
],
[
3,
3,
3
],
[
3,
3,
3
],
[
3,
3,
3
]
],
"dropout": 0.75,
"convolution_per_layer": [
3,
3,
3,
3
],
"features_per_convolution": [
[
[
1,
16
],
[
16,
16
],
[
16,
16
]
],
[
[
16,
32
],
[
32,
32
],
[
32,
32
]
],
[
[
32,
64
],
[
64,
64
],
[
64,
64
]
],
[
[
64,
128
],
[
128,
128
],
[
128,
128
]
]
]
}

@oumayb yes it's related to the issue I raised that you mentioned. You'll just need to do the following renamings in your file:
weighted_cost_activate -> weighted_cost-activate
da-random_rotation-activate -> da-2-random_rotation-activate
da-noise_addition-activate -> da-5-noise_addition-activate
da-elastic-activate -> da-3-elastic-activate
da-shifting-activate -> da-0-shifting-activate
da-flipping-activate -> da-4-flipping-activate
da-rescaling-activate -> da-1-rescaling-activate

@mathieuboudreau thanks a lot, it solved my issue.
I also changed:
weighted_cost_boundaries_sigma -> weighted_cost_boundaries-sigma
weighted_cost_boundaries_activate -> weighted_cost_boundaries-activate
but I'm not sure about the first one.


s3_auth_v4: multiple same name fields signing fix

When signing multiple header fields with the same name AWS auth v4
seems to combine them into a single field by white-space trimming the
fields' values from the beginning and end and concatinating them by
using a comma in the order they are received. If same name header
fields already contain multiple values they are considered as a single
value headers during the trimming/concatenation.
This is undocumented behavior, discovered by reverse engineering
experiments, AWS signature calculation spec is not quite clear
about this case (unspecified, see CanonicalHeaders section).

Cherry-picked to 8.1.x
Cherry-picked to v9.0.x branch.


Upgrade to Pydantic 2.5.3 while still using v1 underneath

Fixes https://github.com/mom1/api-client-pydantic/issues/273

@mom1 what do you think?

If you want to support both versions we can change imports to something like:
try:
    #pydantic2
    import pydantic.v1 as pydantic
except ImportError:
    #pydantic1
    import pydantic

@ddorian take a look at this #287, what do you think?

Closing since https://github.com/mom1/api-client-pydantic/pull/287 was merged.
Looking forward to the new release.


Add a stub for script command

Hey,
this is not a complete implementation obviously, but I think a complete one is not even feasible (unless you want to include a Lua interpreter in this gem). :smile:
I encountered this after updating to redlock-0.1.4, they introduced script loading into the locking mechanism and that's when my test suite broke, since mock_redis does not yet respond to #script.
What do you think the best solution here would be? :)
I'm leaning towards that mock_redis should at least pretend to understand everything a regular Redis connection can.
Thank you for your gem!

Looks like evalsha also needs to be defined.

Hey @tomasv, thanks for the pull request! Sorry for the delay in response.
Would you also consider submitting a pull request for EVALSHA?


ng new failes with "package install failed" due to npm ERR! Unexpected end of JSON input while parsing near '...imple-git":"^1.65.0",'

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting

Command (mark with an x)
- [ x] new

Versions
Angular CLI: 7.0.6
Node: 8.12.0
OS: win32 x64
Angular:
...

If npx command is available on your system, maybe you can try
npx @angular/cli new demo-app --skip-install

@prabh-62 , thanks for response.
with npx command, I was able to create angular project successfully however when doing npm install from demo-app gives me same error
Also tried with --skip-git but no luck

Try
> yarn install

Instead of npm install. You may need to download yarn package manager from internet

it seems to be working with yarn. but then I will have always have to do two step.

ng new demo-app --skip-install
yarn install

:(


Inline Styling Gets Messy

Alright, I was working on trying to get the following text to generate using SnakeMD:

There are 100 points on the exam. Please write your answers on the test sheets, and of course don’t forget to write and sign your name on the top sheet. Consider the space allotted as an indication of the expected length of the answer. Summaries of relevant Javadoc APIs are included in the handout. Please do not write on the handout , and return it with your exam. If you need to look up the Javadoc API for anything else or for more detail, your instructor will have a browser open on a computer in the classroom for you to use.

With the following code:
doc.add_block(
    snakemd.Paragraph([
        snakemd.Inline(
            'There are 100 points on the exam.  Please write your answers on the test sheets, and of course don’t forget to write and sign your name on the top sheet. Consider the space allotted as an indication of the expected length of the answer. Summaries of relevant Javadoc APIs are included in the handout. Please '
        ).italicize(),
        snakemd.Inline(
            'do not write on the handout '
        ).italicize().bold(),
        snakemd.Inline(
            ', and '
        ).italicize(),
        snakemd.Inline(
            'return it '
        ).italicize().bold(),
        snakemd.Inline(
            'with your exam.  If you need to look up the Javadoc API for anything else or for more detail, your instructor will have a browser open on a computer in the classroom for you to use.'
        ).italicize()
    ])
)

In the original design, I figured we would defer as much of the structure as possible to the user. This runs perfectly in line with the way folks already format their strings using concatenation. In other words, users would be expected to get their spacing right, just as you would with something like: "Hello, " + input("What is your name?").
The problem is that when styles are applied, they are applied to the individual inline units and there are some nastier bugs that can unexpectedly occur. For example, the code above produces the following nightmare:

_There are 100 points on the exam. Please write your answers on the test sheets, and of course don’t forget to write and sign your name on the top sheet. Consider the space allotted as an indication of the expected length of the answer. Summaries of relevant Javadoc APIs are included in the handout. Please **do not write on the handout **, and __**return it **_with your exam. If you need to look up the Javadoc API for anything else or for more detail, your instructor will have a browser open on a computer in the classroom for you to use.

To me, the whitespace should not affect the output but it seemingly does. Therefore, the correct code would be:
doc.add_block(
    snakemd.Paragraph([
        snakemd.Inline(
            'There are 100 points on the exam.  Please write your answers on the test sheets, and of course don’t forget to write and sign your name on the top sheet. Consider the space allotted as an indication of the expected length of the answer. Summaries of relevant Javadoc APIs are included in the handout. Please '
        ).italicize(),
        snakemd.Inline(
            'do not write on the handout'
        ).italicize().bold(),
        snakemd.Inline(
            ' , and '
        ).italicize(),
        snakemd.Inline(
            'return it'
        ).italicize().bold(),
        snakemd.Inline(
            ' with your exam.  If you need to look up the Javadoc API for anything else or for more detail, your instructor will have a browser open on a computer in the classroom for you to use.'
        ).italicize()
    ])
)

In other words, anywhere we are applying both italics and bold would need to be free of trailing and leading spaces. I believe the reason this ends up being an issue is because adjacent Inline elements have italics which cause problems when running into each other.
 They shouldn't have to really even know markdown to use the library, but they'll be stuck solving markdown bugs as a result.
Now, the solution would be applying italics to the entire Paragraph and bold to the key elements. Or in a broader sense, SnakeMD should maybe have the capability to aggregate repeated styles. Something to think about for sure!

A dream of mine would be to borrow the f-string syntax somehow, so users basically would never have to touch the Inline object. For example, something like this would be wonderful:
doc.add_paragraph("{'How Now':italics} {'Brown':italics&bold} {'Cow':italics})

And in fact, Inline could be embedded in f-strings, but the Inline element would be lost completely. Hmmm....


Use preferred citation format for EIPs

This uses the preferred citation format for EIPs.
The preferred citation format is documented at https://github.com/ethereum/EIPs#preferred-citation-format

Merged, published and the edge caches have been flushed. Looks good!
Thanks! :)


Error trying to build - run - debug

I'm trying to build and run the extension from source, but the extension does not activate on the Extension Development Host. But, if I package the extension (vsce package) and install the VSIX file, it works perfectly.
I did take a look at the Contributing wiki (https://github.com/Microsoft/vscode-pull-request-github/wiki/Contributing#build-and-run), but it seems a regular environment (no special steps/dependencies). Except the Architecture section, where you describe Some features and bugs may require making changes to VSCode itself instead of the extension 😬 .
On my first attempt, it was raising errors about webviewIndex.js missing.
After packaging the extension and debugging it again, the webviewindex.js error was replaced by Activating extension 'GitHub.vscode-pull-request-github' failed: t.onDidChangeDecorations is not a function.
Tracing the error, the latest location was at prsTreeDataProvider.ts, at its constructor
this._disposables.push(vscode.window.registerDecorationProvider(DecorationProvider));

Any ideas what I could be doing wrong/what am I missing?
Thank you

On my first attempt, it was raising errors about webviewIndex.js missing

Running yarn watch in a clean state I see this myself, but it then gets corrected. There are three webpack tasks that get run, one for the extension and then two for the webviews, if possible we should make it so that the extension one always runs after these.

After packaging the extension and debugging it again, the webviewindex.js error was replaced by Activating extension 'GitHub.vscode-pull-request-github' failed: t.onDidChangeDecorations is not a function.

Ah, right now the insider's version of VSCode is required to run the extension. There were some changes to the proposed API we adopted that are only in that version. I'll add a note about this in the contributing guide!

Hello! I have a little bit of a different issue, but it relates to the build not working so I thought I'd comment here. Please let me know if I should open a separate issue.
I was looking at the Contributing wiki as well and following the instructions, but came across a couple issues. I am using git 2.22.0, yarn 1.22.10 and VSCode Insiders 1.51.0-insider

When using Node.js >= 8.9.3, < 9.0.0 like the wiki says, I get the following error: error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^10.17 || >=12.3". Got "8.17.0"

updating Node.js to ^10.17 || >=12.3 shows errors when installing fsevents, and while it does seem to say it is optional, running yarn watch fails because of fsevents

running npm install instead of yarn install seems to install fsevents properly, but running yarn watch afterwards shows a warning:

    WARNING in ./node_modules/diagnostic-channel-publishers/dist/src/azure-coretracing.pub.js
    Module not found: Error: Can't resolve '@opentelemetry/tracing'

and throws the following error
ERROR in /Users/ejkim/Desktop/Git Repos/vscode-pull-request-github/src/test/view/reviewCommentController.test.ts
    [tsl] ERROR in /Users/ejkim/Desktop/Git Repos/vscode-pull-request-github/src/test/view/reviewCommentController.test.ts(121,4)
          TS2322: Type '{ threadId: string; uri: vscode.Uri; range: vscode.Range; comments: never[]; collapsibleState: vscode.CommentThreadCollapsibleState.Expanded; label: string; readOnly: boolean; dispose: () => void; }' is not assignable to type 'GHPRCommentThread'.
      Object literal may only specify known properties, and 'readOnly' does not exist in type 'GHPRCommentThread'.

@RMacfarlane If you have any insights into how I can get past these issues I'd greatly appreciate it! :)

Hi, I had some more time to dig into the last error I mentioned, I was able to fix the issue by setting the upstream remote and pulling from master. It's my first time trying to contribute to an open source project so I missed something simple 😅
I'm guessing the issue with npm install vs yarn install is probably an issue specific to me. Although I believe the Node.js version issue would pop up for others too. Maybe the Contributing wiki can be updated to show Node.js versions that work with current modules?

Thanks for pointing out the Node.js version problem, I've updated the Contributing wiki to the correct version!
I'm not entirely sure why yarn install would have failed for you. 🤔  npm install and yarn install sometimes resolve dependency versions slightly differently, I always use yarn. fsevents should be optional on Windows and Linux

Just to let you know, I was able to build and run/debug the extension 🎉
I updated my fork with the latest commits and re-cloned the repo. To avoid any external dependency issues I decided to open the repo on a Remote Development (using the Node 10 and TypeScript template), and it worked just fine.
I experienced the same first time issue while runningyarn watch, but after the second run, the error disappeared. This time, I remembered to copy the log:
    [./src/issues/issueFeatureRegistrar.ts] 38.4 KiB {extension} [built]
        + 542 hidden modules

    ERROR in ./src/github/activityBarViewProvider.ts
    Module not found: Error: Can't resolve '../../media/activityBar-webviewIndex.js' in '/workspaces/vscode-pull-request-github/src/github'
     @ ./src/github/activityBarViewProvider.ts 20:38-88
     @ ./src/view/reviewManager.ts
     @ ./src/extension.ts

    ERROR in ./src/github/issueOverview.ts
    Module not found: Error: Can't resolve '../../media/webviewIndex.js' in '/workspaces/vscode-pull-request-github/src/github'
     @ ./src/github/issueOverview.ts 20:26-64
     @ ./src/github/pullRequestOverview.ts
     @ ./src/commands.ts
     @ ./src/extension.ts
Child webviewIndex.js:

Thanks you so much for your help.


positioning of the "Untitled" text in Simulator

Describe the bug
the positioning of "Untitled" text after opening of the simulator is not justified in some screen size
To Reproduce
Steps to reproduce the behavior:

Go to 'https://circuitverse.org/'
Click on 'Simulator'
Reduce the screen size to less than 991px
See the Blue colored "Untitled" after toggling on the navbar, the text is hidden from the left side to some extent

Expected behavior
The text "Untitled" should have been directly below the other navbar options
Screenshots
The original behaviour

The expected behaviour

Device Information [optional]:

OS: Windows 10 (using WSL2)
Browser : Chrome

Are you working on this issue? (Yes/No)
Yes, I want to work on the issue

I would like to work on this issue, please assign it to me

Yes, I want to work on this issue.

https://github.com/CircuitVerse/CircuitVerse/pull/1935#issue-524508858

@shivamkushwah0 Please have a look at the new Simulator at https://beta.circuitverse.org/simulator

@Shivansh2407 is the new simulator in new_UI branch of the codebase......i was looking at the old simulator.....where is the codebase for the new simulator??

@Shivansh2407 is the new simulator in new_UI branch of the codebase......i was looking at the old simulator.....where is the codebase for the new simulator??

check new_UI branch public/src folder


[ContactBundle] Make additional information sortable (Email, Phone, Address, ...)

By @chirimoya from https://github.com/sulu-cmf/SuluContactBundle/issues/3

@chirimoya Can this be closed? Looks to me like the list is sortable by email:


Changed find_by_name to find_by_xpath in fill()

When dealing with a page where the name is set dynamically we were not able to use fill() or attach_file() as it was accepting name as a parameter, so changed it to xpath as we can always get a xpath which is unique

With #933 merged in, I don't see this PR as necessary anymore.


Generalised similarity implementation

Abstract similarity method as a generalised function:
It runs
Jaccard,
Cosine etc. similarity functions.

Won't fix.


Refactor net TCP tests to use a common TCPListenNotify class.

This PR shaves some more complexity off of writing new TCP tests by adding the _TestTCP class, a common TCPListenNotify implementation. You create the _TestTCP instance anf pass it the two TCPConnectionNotify classes you want to use (for the client and server side) and it handles the creation of the listener and connection sockets, and passing of your notifiers to them in the appropriate places.
The hope is that this makes it easier to write additional TCP tests to cover currently untested behaviour.

I think this is worthy of a CHANGELOG entry.

Is it?  I don't know how it affects the user or the release.

actually as its private, you are correct


Task - Filter descriptors [was: Filter descriptors  interface]

There is a request from a user to be able to download the list of descriptors and the states.
This probably could be implemented as a Filter.
The filter options:
New

[ ] All descriptors - no param, just click search, as in all filters
[ ] Matching term, curator selects term_location (one of name, short_name, description, description_name, key_name) then adds text (single option, no and/or)
[ ] observation_matrix_id and observation_matrix_id[] Descriptors from a particular matrix
[ ] type  descriptor_type and descriptor_type[]

"Boolean"

[ ] Descriptors with/without/both observation_matrices - observation_matrices
[ ] Descriptors with/without/both observations - observations
[ ] Descriptors with character states that are missing scores/have scores - character_states
[ ] Descriptors that do/not have depictions on observations - observation_depictions

Existing

[ ] Tags facet - Desriptors with a Tag
[ ] Users facet
[ ] Identifiers facet
[ ] Notes facet

Make the list downloadable in a text format with options: each state on a separate line, or all states inline with the descriptor.

Make the list downloadable in a text format with options: each state on a separate line, or all states inline with the descriptor.

@proceps can you describe further what the goal of this format is?  Are they looking for a paper worksheet?

Yes, a collaborator told me he wants to download a list of descriptors in publication ready format. One of the requirements, is that not all the states of the descriptors are used in one particular matrix, only those which are in this matrix should be included to the list.


invalid plugin ID 'OreAlerts'

This shows on startup.
Invalid plugin ID 'OreAlerts'. Plugin IDs should be lowercase, and only contain characters from a-z, dashes, underscores or dots. Please see the in-existent SpongeDocs link for details. The plugin will be still loaded currently, however this will be removed soon. Please notify the author to update the plugin as soon as possible.

Fixed in my pull request.


portability for other devices

portability for other devices like responsive window size

made available for non-mini tablets


Pod install for Demo hangs on Openssl install

Summary
Pod install for Demo hangs on Openssl install, furthermore the cpu was at maximum clock for the whole time. I've waited for at least 15 minutes without any response from pod install command
Steps to reproduce
Run pod install from the Demo folder
What is the current bug behavior?
Nothing, the cpu is at 100% for the whole time while it is installing openssl
What is the expected correct behavior?
Install the dependencies and try the demo
Relevant logs and/or screenshots
SlimShady:Demo anas$ pod install
Analyzing dependencies
[!] The version of CocoaPods used to generate the lockfile (1.5.3) is higher than the version of the current executable (1.4.0). Incompatibility issues may arise.
Fetching podspec for `PIATunnel` from `..`
Downloading dependencies
Installing OpenSSL-Apple (1.1.0h)
^C[!] Cancelled

Have the same issue but it stops with the following message on "pod install"
`
Analyzing dependencies
Downloading dependencies
Installing OpenSSL-Apple (1.1.0h)
[!] /bin/bash -c
set -e
./build-libssl.sh --version=1.1.0h
./create-openssl-framework.sh dynamic
Build options
OpenSSL version: 1.1.0h
Targets: ios-sim-cross-x86_64 ios-sim-cross-i386 ios64-cross-arm64 ios-cross-armv7s ios-cross-armv7 tvos-sim-cross-x86_64 tvos64-cross-arm64 macos64-x86_64 macos-i386
macOS SDK: 10.14
iOS SDK: 12.1
tvOS SDK: 12.1
Number of make threads: 8
Configure options:  no-deprecated
Build location: /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153
Downloading openssl-1.1.0h.tar.gz...
Building openssl-1.1.0h for iPhoneSimulator 12.1 x86_64...
Logfile: /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153/bin/iPhoneSimulator12.1-x86_64.sdk/build-openssl-1.1.0h.log
Configure...
Make (using 8 thread(s))...
Building openssl-1.1.0h for iPhoneSimulator 12.1 i386...
Logfile: /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153/bin/iPhoneSimulator12.1-i386.sdk/build-openssl-1.1.0h.log
Configure...
Make (using 8 thread(s))...
Building openssl-1.1.0h for iPhoneOS 12.1 arm64...
Logfile: /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153/bin/iPhoneOS12.1-arm64.sdk/build-openssl-1.1.0h.log
Configure...
Make (using 8 thread(s))...
Building openssl-1.1.0h for iPhoneOS 12.1 armv7s...
Logfile: /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153/bin/iPhoneOS12.1-armv7s.sdk/build-openssl-1.1.0h.log
Configure...
Make (using 8 thread(s))...
Building openssl-1.1.0h for iPhoneOS 12.1 armv7...
Logfile: /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153/bin/iPhoneOS12.1-armv7.sdk/build-openssl-1.1.0h.log
Configure...
Make (using 8 thread(s))...
Building openssl-1.1.0h for AppleTVSimulator 12.1 x86_64...
Logfile: /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153/bin/AppleTVSimulator12.1-x86_64.sdk/build-openssl-1.1.0h.log
Configure...
Make (using 8 thread(s))...
Building openssl-1.1.0h for AppleTVOS 12.1 arm64...
Logfile: /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153/bin/AppleTVOS12.1-arm64.sdk/build-openssl-1.1.0h.log
Configure...
Make (using 8 thread(s))...
Building openssl-1.1.0h for MacOSX 10.14 x86_64...
Logfile: /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153/bin/MacOSX10.14-x86_64.sdk/build-openssl-1.1.0h.log
Configure...
Make (using 8 thread(s))...
Building openssl-1.1.0h for MacOSX 10.14 i386...
Logfile: /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153/bin/MacOSX10.14-i386.sdk/build-openssl-1.1.0h.log
Configure...
Make (using 8 thread(s))...
Problem during make - Please check /Users/oberon/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0h-cd153/bin/MacOSX10.14-i386.sdk/build-openssl-1.1.0h.log
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100 5295k  100 5295k    0     0  12.6M      0 --:--:-- --:--:-- --:--:-- 12.6M
`

(macOS Mojave: 10.14.1)

Hello,
Sorry, but I join the team recently and I didn't see your messages before.
We are preparing a new release very soon where I explain how to fix this issue in the README file. The problem is compiling the openssl framework with the current version of Xcode and support iOS9 at the same time. (you need the iOS9 SDK installed in the computer).
If you change your min version to iOS 11 in the Podfile the problem will be fixed. If you want to keep iOS 9, you must follow these steps:

Download Xcode 7 from Apple
Install Xcode 7 in Applications/xcode7
sudo xcode-select -switch /Applications/xcode7/Xcode.app/Contents/Developer
Clean all the pod cache from the computer
pod install ... etc
sudo xcode-select -switch /Applications/Xcode.app/Contents/Developer

I hope this can help you guys!
Regards,
Jose.

I have the same problem. I changed the version to iOS 11 in Podfile. But i still have the error.
[!] /bin/bash -c
set -e
./build-libssl.sh --version=1.1.0j
./create-openssl-framework.sh dynamic
Build options
OpenSSL version: 1.1.0j
Targets: ios-sim-cross-x86_64 ios64-cross-arm64 tvos-sim-cross-x86_64 tvos64-cross-arm64 macos64-x86_64
macOS SDK: 10.14.4
iOS SDK:
tvOS SDK:
Number of make threads: 4
Configure options:  no-deprecated
Build location: /Users/melisaozturk/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0j.2-e88e1
Downloading openssl-1.1.0j.tar.gz...
Building openssl-1.1.0j for iPhoneSimulator  x86_64...
Logfile: /Users/melisaozturk/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0j.2-e88e1/bin/iPhoneSimulator-x86_64.sdk/build-openssl-1.1.0j.log
Configure...
Make (using 4 thread(s))...
Problem during make - Please check /Users/melisaozturk/Library/Caches/CocoaPods/Pods/Release/OpenSSL-Apple/1.1.0j.2-e88e1/bin/iPhoneSimulator-x86_64.sdk/build-openssl-1.1.0j.log
xcrun: error: SDK "iphoneos" cannot be located
xcrun: error: SDK "iphoneos" cannot be located
xcrun: error: unable to lookup item 'SDKVersion' in SDK 'iphoneos'
xcrun: error: SDK "appletvos" cannot be located
xcrun: error: SDK "appletvos" cannot be located
xcrun: error: unable to lookup item 'SDKVersion' in SDK 'appletvos'
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100 5285k  100 5285k    0     0  1664k      0  0:00:03  0:00:03 --:--:-- 1665k


Fix SEP-8 action_required return condition

What
Fix SEP-8 action_required return condition.
Why
The code was using the wrong condition check.

Preview is available here:http://stellar-demo-wallet-pr174.previews.kube001.services.stellar-ops.com/


onedrivesdk.ChildrenCollectionRequest.get_next_page_request: AttributeError: 'ChildrenCollectionPage' object has no attribute '_next_page_link'

Error: AttributeError: 'ChildrenCollectionPage' object has no attribute '_next_page_link'
Terminal output:
0 : 20180408_155657.jpg
1 : 20180408_160051.jpg
2 : 20180408_160150.jpg
<class 'onedrivesdk.model.children_collection_page.ChildrenCollectionPage'>
0 : 20180414_181319.jpg
1 : 20180418_164440.jpg
2 : test2.jpg
The thread 'MainThread' (0x4580) has exited with code 0 (0x0).
Traceback (most recent call last):
File "C:\Users\pto\source\repos\OneDrivePhotoOrganizer\OneDrivePhotoOrganizer\OneDrivePhotoOrganizer.py", line 89, in
collection = onedrivesdk.ChildrenCollectionRequest.get_next_page_request(collection, client).get()
File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\lib\site-packages\onedrivesdk\request\children_collection.py", line 105, in get_next_page_request
if collection_page._next_page_link:
AttributeError: 'ChildrenCollectionPage' object has no attribute '_next_page_link'
Steps to reproduce:
... auth part...
`
src_folder = "/test/src"
dst_folder = "/test/dst/"
collection = client.item(path=src_folder).children.request(top=3).get()
for count, item in enumerate(collection):
print("{} : {}".format(count,item.name))
while (collection is not None):
collection = onedrivesdk.ChildrenCollectionRequest.get_next_page_request(collection, client).get()
print(type(collection))
for count, item in enumerate(collection):
print("{} : {}".format(count,item.name))
`

@pertoft that simply means there isn't another page. Instead of returning None, it throws an exception. I agree that should be changed to returning None, though.
Considering helping the community by letting them find this issue, if it makes sense, consider closing.

Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #209 for more information


v3.3.1 Cherry-pick

[x] Saravanan Balasubramanian: fix: workflow.duration' is not available as a real time metric (#8181) fbb43b242
[ ] Alex Collins: fix: Authentication for plugins. Fixes #8144 (#8147) 0e707cdf6
[x] Alex Collins: fix: Correctly order emissary combined output. Fixes #8159 (#8175) e7008eada
[x] Alex Collins: fix: Add instance ID to workflowtaskresults (#8150) 9101c4939
[x] Ming Yu Shi: fix: add /etc/mime.types mapping table (#8171) 715f6ced6
[x] William Van Hevelingen: fix: Limit workflows to 128KB and return a friendly error message (#8169) 6d6e08aa8
[x] Alex Collins: fix: Remove need for get pods from Emissary (#8133) af26ff7ed
[x] Saravanan Balasubramanian: fix: Fix the TestStopBehavior flackiness (#8096) 4d4890454
[x] Vignesh: fix: pod deleted due to delayed cleanup. Fixes #8022 (#8061) 6855f4c51

@alexec  can you help me to cherry pick below commit?
Alex Collins: fix: Authentication for plugins. Fixes https://github.com/argoproj/argo-workflows/issues/8144 (https://github.com/argoproj/argo-workflows/pull/8147) https://github.com/argoproj/argo-workflows/commit/0e707cdf69f891c7c7483e2244f5ea930d31b1c5


Add Maps Service Data Samples

In order to test this before its released:

Download azure-maps-service.
Install it locally pip install azure-maps-service-preview-2.0.zip.
Run the samples by following the README.md file. For all samples set the env variable SUBSCRIPTION_KEY to your subscription key.

This is ready to be reviewed again.

Python Codegen generated by CI:
creator
elevation
geolocation
render
route
search
timezone
traffic
weather


Dynamic import errors without assignment

Dynamic import (e.g. import('abc')) still gives an Unexpected token import error unless the promise is assigned to a variable.
https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAodxhgXATgawGdUBjOAO0IBcwBLAWwAcwBeOpvKgCgHIBDAEYkeASgDcqBowB0VABYBTcl3pwAJqwB8YMpTgwF0+AHMV6kQBowC3Li06KhfYZNcbuEePSpMYNXAVCch4aHAJJDlxufiFRWUVlVQ0WbV0nAyM4UyTLa1t7NOdM03dPMSA
// works
const imp = import('abc');
imp.then(mod => console.log(mod), err => console.log(err));

// doesn't work
import('abc').then(mod => console.log(mod), err => console.log(err));

Should this be closed @mikaelbr?

Yep. Should be working with the changes from 3eaa8faa48ad796d680c00d9677f953189c4075f


Added Managed / Hosted Services

I felt this model is different enough it deserves it's own section.

I love the idea of separate section, Sentry being listed as open core brought me to the issues page :-)
Also, is Gitlab hosting their free code? They are a bit of an outlier, as they are publishing some code (gitlab EE) that you can't use without a paid licence. Do we still call that open source here? Or would the EE part be considered proprietary (like in open core)?

I'm not sure if Gitlab.com is Gitlab CE or GitlabEE. I would say the
company is doing both the Managed Service and Core / Premium Closed model.

Just checked: https://about.gitlab.com/gitlab-com/ says it "Runs GitLab Enterprise Edition with issue tracking, wikis, and CI.". So it's an Open Core Managed Service :-)

beautiful. thank you for your help!