Support pinging 1.3 and earlier servers (FE ping)

MC 1.3.2 doesn't support the FE01 ping (added in 1.4.4), but there may be some other way to ping it. Doesn't seem to be well-documented that I could find, but I think it supports FE00?

Try fefd_tcp:

There is also a fefd_tcp ping, but it returns only the MOTD and player count so it is not exposed by this module.

FE01 ping on 1.3.2 and 1.2.5 fails with:
java.io.IOException: Received string length longer than maximum allowed (19712 > 16)
ping_fefd_tcp also fails:
java.io.IOException: Bad packet id 253

Actually it's just "FE", for 1.3: http://wiki.vg/index.php?title=Protocol&oldid=933#Server_List_Ping_.280xFE.29 1.3.1 protocol - https://gist.github.com/barneygale/1235274
	//Send 0xFE: Server list ping
	fwrite($fp, "\xFE");

	//Read as much data as we can (max packet size: 241 bytes)
	$d = fread($fp, 256);

sending this works on 1.2.5, getting back:
�A Minecraft Server�0�20
FE01 also works, but the full FE01FA... I'm sending for 1.6:
    socket.write(new Buffer('fe01'+
        'fa'+ // plugin message
        '000b'+'004D0043007C00500069006E00670048006F00730074'+ // MC|PingHost,
        '0007'+ // 7+len(hostname)
        '4a'+   // protocol version (74, last)
        '0000'+''+ // hostname TODO
        '00000000' // port TODO
        ,'hex'));

trips up 1.3.2 and earlier. 19712 is 4d00 hex, so it looks like it is falling over on the MC|PingHost varint length (no varints in 1.3.2)

Added ping_fe, it works on 1.3.2 and 1.2.5 (no protocol/game version information, but perhaps can infer from lack of other pings, reference https://github.com/deathcap/node-minecraft-ping/issues/4 Uber-ping/meta-ping: try different pings, return what works)


Companywhyus

Current coverage is 57.54%

Merging #81 into master will not affect coverage as of c837dfb

@@            master     #81   diff @@
======================================
  Files           13      13
  Stmts          179     179
  Branches         0       0
  Methods          0       0
======================================
  Hit            103     103
  Partial          0       0
  Missed          76      76

Review entire Coverage Diff as of c837dfb

Powered by Codecov. Updated on successful CI builds.


Code Generation Duplicates Characteristic

When generating a customer code, if the function is called more than once, the old code is not removed from the characteristics which can cause confusion as to which is the valid characteristic.
Generation function should remove the old one.

This will require a characteristic removal or update functions.


Improve Layer._is_in_values performance

The _is_in_values function is performing a type & value check which could be more efficient if It would be done inversely (type & value).
I noticed this when adding several (thousands) feature attributes to a layer.

https://github.com/mapbox/vector-tile-base/pull/22


feat: support Number, SemVer, DateTime condition

Follows the impl of go sdk (https://github.com/FeatureProbe/server-sdk-go/commit/efb657cc94cdd47748371892e3f3bcec466a1d1d)

Codecov Report

Merging #7 (10b5948) into main (0c26231) will decrease coverage by 0.13%.
The diff coverage is 77.01%.

@@             Coverage Diff              @@
##               main       #7      +/-   ##
============================================
- Coverage     77.76%   77.62%   -0.14%
- Complexity      227      259      +32
============================================
  Files            31       31
  Lines           823      894      +71
  Branches         53       59       +6
============================================
+ Hits            640      694      +54
- Misses          150      160      +10
- Partials         33       40       +7

Impacted Files
Coverage Δ

...n/java/com/featureprobe/sdk/server/model/Rule.java
76.19% <ø> (ø)

...a/com/featureprobe/sdk/server/model/Condition.java
79.48% <72.22%> (-6.48%)
:arrow_down:

.../main/java/com/featureprobe/sdk/server/FPUser.java
75.00% <100.00%> (-6.82%)
:arrow_down:

...m/featureprobe/sdk/server/model/ConditionType.java
100.00% <100.00%> (ø)

...m/featureprobe/sdk/server/model/PredicateType.java
100.00% <100.00%> (ø)

.../java/com/featureprobe/sdk/server/model/Split.java
87.80% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Hi @HeZean ,
Terribly sorry, this feature has been developed，thanks again for your contribution。

Hi @gangb-tech, feeling kinda sorry for conflicting with your #8, but I just checked and make sure that this PR works almost same with yours.


Linewidth defaults to >=1 px on PNG export

I have set linewidth to 0.75px, but in the PNG export it seems to be getting rounded up to 1.

Thanks for the report. This will be fixed in the next release.


DBFS file handle that supports both reading and writing

Follow up to #249.

@nfx Leaving this PR in draft for early feedback. This needs more work on tests for better coverage of the write path.

Codecov Report
Base: 42.53% // Head: 42.53% // No change to project coverage :thumbsup:

Coverage data is based on head (effffb6) compared to base (41ce268).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   42.53%   42.53%
=======================================
  Files          42       42
  Lines        2464     2464
=======================================
  Hits         1048     1048
  Misses       1336     1336
  Partials       80       80

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


How to check if a service is running or not?

I have a question regarding the availability of microservices created, how can we check if a service is running or not ?  So, for each service, we have an event receiver running using: python main.py, what if one service failed to run for some reason, how can we check by code if a certain service is running or not? In case the service is not running we need to show a message saying that this service is not running. Thank you.

This is a good enhancement request. I will note it down to be implemented. Thanks.


[CI/CD] Refactor Cypress Workflow

Description

Fix the integration test case in the Cypress integration suite
Add a dashboard status check in the integration CI workflow
Separate cypress test suites into its own GH runner
Setup cypress tests directories for different testing categories

The current state is that the workflow of Dashboards observability plugin E2E test is able to be run and the the cypress framework can work properly (see log here: https://github.com/RyanL1997/dashboards-observability/actions/runs/7145888298/job/19462486749). However, the test cases is still failing, and it should be resolved in the follow up PR for #1040.
Issues Resolved

Resolve https://github.com/opensearch-project/dashboards-observability/issues/1039
Relate https://github.com/opensearch-project/dashboards-observability/issues/1040

Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Transferring some of the conversation between me and @ps48 here: this PR will also refactor the current workflow structure and separate the test cases into parallel runs

The refactor has been done. The test cases have been separated into its own GH runner. We have also setup the directory for future splitting of the test classes. The sample run is here: https://github.com/RyanL1997/dashboards-observability/actions/runs/7145888298/job/19462486749
(cc: @ps48, @Swiddis , @mengweieric, @joshuali925 )

Still LGTM -- One nit: notebook is the only one that doesn't have a _test suffix, would like to keep them consistent.


New Window?

I am using horsemanjs to login to a website.
After login, it clicks a link. I am able to write till this step.
Then, a javascript event fires and a new popup window opens.
How to write code to move to the newly opened window? And I have to write code inside the new window.
For example: In this https://github.com/johntitus/node-horseman/issues/41  html code,  instead of the below popup message, if a new child window opens, how should I write code for that new window?
<!DOCTYPE html>

    <meta charset="utf-8">
    <title>Confirm check</title>

Confirm?

Thanks.

That is something horseman v2 does not handle well. It has been fixed in v3 (see #100).
The behavior of v3 is not entirely set yet, but using it would fix your problem...

How do I get v3 ?

It's not released, but you can install the current WIP version with npm install johntitus/node-horseman#wip-v3.

You'll probably want to set the switchToNewTab option @LuckyLillia.


add bundle resources to .gitignore

When you contribue to the documentation, using RVM & bundle creates new files locally.
They are dev specific to let's add them to .gitignore

Codecov Report

Merging #2675 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2675   +/-   ##
=======================================
  Coverage   80.29%   80.29%
=======================================
  Files          59       59
  Lines        4537     4537
=======================================
  Hits         3643     3643
  Misses        894      894

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2f039...4ca0895. Read the comment docs.

Codecov Report

Merging #2675 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2675   +/-   ##
=======================================
  Coverage   80.29%   80.29%
=======================================
  Files          59       59
  Lines        4537     4537
=======================================
  Hits         3643     3643
  Misses        894      894

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2f039...4ca0895. Read the comment docs.


Door opener exposed?

I don't have the door opener exposed as an entity in Home Assistant. As far as I can tell from the manual, it should be available. Is this correct?
I would like to be able to open the door by scanning an NFC tag.

My installation does not include a door opener/lock.
Is there another user that can provide more info?

I'm experimenting with adding this in the configuration.yaml but have not go it working. It seems the sensors turn to unavailable once I connect the Niko Video doorbell cable directly to my network
curl -u admin:<password> "http://<address>/api/v1/dooropener _
 pulse"

Solution: while Access Control was enabled in the NHC Programming Software, the video unit itself wasn't (named "Access Control 1", one line below the general Access Control toggle). After disabling the NHC integration, restarting HA and re-enabling the integration, I can now see "Access Control" as an entity, including the lock.
This still leaves the question why the cURL commands mentioned in the API don't work. For more sophisticated automations it might be useful to use those commands, so I'd still be interested to hear your thoughts on this if you have any.


Add more julia tests

This PR reproduces the tests that we have in xtensor-python. Current issues.

CxxWrap's add_lambda function takes its third argument (the pointer to operator())  const, which prevents the use of functors where operator() is not const qualified.
Question: is there a deep reason for the third argument of add_lambda to be const? cc @barche

Unlike numpy arrays, in Julia, N-D arrays with different numbers of dimensions have different types. So in order to return an array with a number of dimension determined at runtime (such as for numpy-style broadcasting), we must create the type at runtime, which is what we do in the specialization of ConvertToJulia::operator().
Now, when using module.method with a function, this uses mapped_return_type which relies on the typedefs of mapped_return_type. By chance, regardless of the dimension, this is always jl_array_t*.
For this reason, even though we use dynamic type mapping, we must override static_type_mapping for the typedefs here.

Nope, it not accepting non-const operators was a bug :)

Nope, it not accepting non-const operators was a bug :)

Thanks. PS: Actually my PR did not address that but only the forwarding issue. In the case LambdaT is const, operator() is still of const type. Looking at a better way to infer the signature now.

@barche would it make sense to add a static assert that attribute types of functions passed to method are not reference types?

What do you mean by attribute types?

I mean that binding foo(ArrayRef<double>& x) does not work but foo(ArrayRef<double> x) does. The former yields a dangling reference.

Did you try that? I get a compile error when I use a non-const ref:
error: non-const lvalue reference to type 'cxx_wrap::ArrayRef<double, 1>' cannot bind to a temporary of type 'jl_array_t *'

With a const ref it does work, the temporary returned from the conversion survives until the function is done.

Although if you want to use the ArrayRef to modify the underlying julia array, it should be non const, so passing it by value is recommended right?

Hum, un-commenting example1 triggers an "unknown function" error in the Julia on both Linux and Windows.

If I'm reading the code correctly, you're returning a nullptr in static_type_mapping::julia_type, that would be a likely cause for the segfault.
Regarding the const ArrayRef: yes, to call a non-const method on that passing by value is better, even though you could always copy the const ref and it would still modify the same array.

So the issue is that the type mapping is not static since I compute the Julia type dynamically based on the dimension of the jlarray.

The static part of the mapping is used to determine the signature of the function passed to ccall, but julia_type is used at runtime when the Julia wrapper methods are generated. Having this return a nullptr will attempt to create a Julia method with a return or argument type that is a nullptr, so this will crash when the module is loaded by wrap_module.

What is the consequence of apply_array_type being called with the wrong number of dimensions in this context?

I would just omit the type parameters then, returning the base type using e.g.
return cxx_wrap::julia_type("AbstractArray");

@barche FYI,

cxx_wrap::julia_type("AbstractArray"); was accepting things such as Reshaped Arrays which would result in segfaults.
Then I used cxx_wrap::julia_type("Array"); which only accepts dense column-major arrays (the assumption that I am making here). It would still accept items with the wrong data type and segfault.
Now I actually use Array{T} where T is the data type.

// Array{T}
return (jl_datatype_t*)apply_type(
    jl_get_global(jl_current_module, jl_symbol("Array")),
    jl_svec1(cxx_wrap::julia_type<T>())
);

Also, in the CI, I noticed that Julia's Int is either int64_t or in32_t depending on the platform, which is ptrdiff_t. I was thinking that having a jl_int_t typedef might be nice.

Julia already defines int_t and uint_t for these, but they are well hidden in dtypes.h, which is included from julia.h.

Cool! Thanks for the info
Do you plan on releasing CxxWtap 0.4 soonish?  Or should I not wait for it before tagging a first release of xtensor-julia?

As far as I can tell the basics needed to split off the C++ part of CxxWrap into a separate package is now complete, so I think I can tag 0.4, yes. One thing I would still like to check before is how VS2017 and VS2015 can be supported at the same time.

Eventually, it would be nice to have a clear story of how we handle not vendoring binary artefacts and headers in the the julia package directory, for contexts such as Anaconda or linux distributions.
For examples, having a flag for build.jl to pass another installation prefix for cmake.


Full update and rework of Talent Management Application and associated Lab documentation

Hi Olga and Bob,
Here is the pull request that contains all of the committed changes, that includes the following updates to this sample application:

Migration to latest version of .NET (6)
Migration to latest version of Teams JavaScript SDK
Migration to latest version of Graph SDK (away from Beta)
Migration to latest version of Bot Framework SDK (and associated code changes)
Include working proactive messaging
Full update and replacement of old lab docs with new lab docs
Replaced old sign-in methods for Tabs/Bot with new Azure AD (non-interactive) SSO
Removed SharePoint Framework stuff as no longer required in this sample
Removed Connectors as this was replaced in this sample by the Proactive Messaging bot
Added Bot Logging middleware (useful for troubleshoot responses)
Added endpoints that enable proactive app install (via Graph) and bot messaging
Added ProactiveMessaging.html basic web-page, to demonstrate how app install and messaging can work in Bots

We have plans in the near future to:

Add Universal Actions in Adaptive Cards, and also to demonstrate how you can send the same card into both Teams and Outlook at the same time
Replace HTML styling with Fluent UI components
Fix bug with Personal Tab OpenPositionsPersonalTab.html, where it doesn't expand once clicked upon

Hope that is allright, please do let us know if you want us to discuss these changes with you before you commit them.
Thanks,
Jack Lewis and Scott Perham
(GPS UK Teams Apps CSAs)

@oljago @BobGerman FYI :)


[9.x] Adds new inspiring quote

This pull request adds a new inspiring quote, from this YouTube video: https://www.youtube.com/watch?v=Ic_Kkmzm3uQ.

Haha - I'm fine with not including myself 😅


pull request for e2e test at 01/02/2017 23:15:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Love

Thanks for working on this project! I love it. Please keep working on this app more. Finish it and publish on Fdroid and Play store as an open source app. You'll get a lot of users!

Could you make it click system navigation buttons? Back and Home buttons?

Thank you. but I'm working on something else. I hope you can look over my project and find it useful for your own app.

I've been playing with your app in Android Studio. I wanted to make it able to click the navigation buttons, and I was able to do it. But there was something else I wanted to do, but I just couldn't imagine how to do it.
I want the coordinate widget to be movable during autoclicking. I understand that the view must have FLAG_NOT_TOUCHABLE in order to click. So I think I want to make a loop to set this flag just right before clicking and un-set right after clicking.
What do you think is the best place to make this loop? May I ask to see how you'd do it? You're the only one who can teach me :(

I got what you said, but it seems hard to make it. I'll figure it out though.


Supporting custom backend for all accelerator.

@umchand, I think we can close this because of #5299. Please take a look and share comments/questions.


Make CI jobs run inside Github actions

Per the discussion from #3712, we would like to investigate the possibility of running our CI jobs themselves inside Github actions.
Couple of known caveats:

Github actions can't be dependent on other Github actions.
Github actions don't support all the architectures we build for, so our tests will have to be decoupled from deploys (building and pushing images to quay). This might be a good thing for performance reasons

Another detail:
Right now master branch builds and tag pushes do the same set of CI tests that PRs do. Then, if and only if the tests pass, the deploy stage runs.
If we move tests into GitHub Actions, we lose that coupling and conditional logic. There was some discussion in a community meeting that we could perhaps remove the CI tests from master and tag builds due to the fact that we know commits that make it into master have already been tested during the CI run for the originating PR.

Closed by #4253


Test Pod I/O Stress Against External Persistent Storage Solutions

According to the discussion thread, Pod I/O stress injection has not been tested against external persistent storage assets.
It would be ideal if this could be done at least against popular, cloud based external persistent storage solutions like Azure File solution, GCE Persistent Disks, AWS EBS, EFS and etc.

Duplicate of https://github.com/litmuschaos/litmus/issues/3108


Correction for raw affiliation CBGP, INRA, CIRAD, IRD, Montpellier SupAgro, Univ. Montpellier, Montpellier, France.

Correction needed for raw affiliation CBGP, INRA, CIRAD, IRD, Montpellier SupAgro, Univ. Montpellier, Montpellier, France.
raw_affiliation_name: CBGP, INRA, CIRAD, IRD, Montpellier SupAgro, Univ. Montpellier, Montpellier, France.
new_rors: 03rnk6m14;051escj72;05q3vnk25;05kpkpg04;05h7ddb14
previous_rors: 03rnk6m14;051escj72;05q3vnk25;05kpkpg04
works_examples: W3173801783;W4249891764;W4230369854
contact: 78b9b7c21fd0b20f4806007e1dac82f0:37881d87514ee8d942acebed683ed0f76e5e @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


Corrected readme for formatCurrency

Description
Just noticed that the readme was incorrect. When using formatCurrency with form: 'short' it said that it will return:

Examples: CHF 1,25, € 1,25 EUR, OMR 1.250, $ 1.25 USD.

We just used this library in this PR and it doesn't return USD and EUR at the end. The sentence should say:

Examples: CHF 1,25, € 1,25, OMR 1.250, $ 1.25

Also matches what the test says.
Type of change

[ ]  Patch: Bug (non-breaking change which fixes an issue)
[ ]  Minor: New feature (non-breaking change which adds functionality)
[ ]  Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

Had a closer look at the CSB define API. It doesn't make sense to add a specific example just for formatCurrency, but I did create one for the main NotFound example. Thoughts @kaelig ?

I really like that code sandbox you provided. I know CSB is heavily used in Polaris. Is there any way we can link to that code sand box you created in this readme in a way that is scalable?

Thanks! Nothing comes to mind, but I've encountered doc sites that have links to Glitch or RunKit that are automatically generated, you could look into this!


ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.  Please set the JAVA_HOME variable in your environment to match the location of your Java installation. Could not install the app on the device, read the error above for details. Make sure you have an Android emulator running or a device connected and have set up your Android development environment: https://facebook.github.io/react-native/docs/getting-started.html

Description:
Please provide a clear and concise description of what the bug is. Include screenshots if needed.
Please test using the latest React Native release to make sure your issue has not already been fixed: https://reactnative.dev/docs/upgrading.html

ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/getting-started.html
React Native version:
Run `react-native info` in your terminal and copy the results here.

Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.
Issues without reproduction steps or code are likely to stall.

Expected Results
Describe what you expected to happen.

Snack, code example, screenshot, or link to a repository:
Please provide a Snack (https://snack.expo.io/), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
You may provide a screenshot of the application if you think it is relevant to your bug report.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

Can you make sure to fill out the template?


docker stack deploy with configs don't work properly

From the command line, this works properly:
docker stack deploy --compose-file domfuzz_stack.yml domfuzz_stack
The services are deployed and everything works as expected.
Using the exact same domfuzz_stack.yml file in portainer...
From portainer.
Select Stacks.
Select Add stack
Upload domfuzz_stack.yml
Name the stack domfuzz_stack
Select deploy the stack.
It fails to deploy, stating file central_fuzzmanager.env not found.
Here is the domfuzz_stack.yml
version: '3.3'
services:
  domfuzz:
    image: dockerregistry.internal:5000/docker_domfuzz:latest
    depends_on:
      - fuzzmanager
    deploy:
      replicas: 4
      restart_policy:
        condition: on-failure
    configs:
      - central_fuzzmanager
    networks:
      - overlay

configs:
  central_fuzzmanager:
    file: central_fuzzmanager.env

networks:
  overlay:

Under prtainer's Configs section.
my central_fuzzmanager.env Config is present and contains the proper information.

Description

Steps to reproduce the issue:

Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?
Technical details:

Portainer version:
1.15.2
Target Docker version (the host/cluster you manage):
17.09.0-ce
Platform (windows/linux):
Linux
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer):
Started via compose file
portainer:
image: dockerregistry.internal:5000/portainer/portainer:latest
depends_on:
- fuzzmanager
deploy:
mode: global
placement:
constraints:
- node.role == manager
ports:
- "<IP_ADDRESS>:9000:9000"
container_name: docker_portainer
volumes:

keep portainer data across containers.
  - type: bind
    source: ./portainer_data
    target: /data
  - type: bind
    source: /var/run/docker.sock
    target: /var/run/docker.sock
networks:
  - overlay

Target Swarm version (if applicable):
Browser:
Chrome

Hi @kkuehl
I believe that this is related to your compose file, especially the configs section:
configs:
  central_fuzzmanager:
    file: central_fuzzmanager.env

If you check the compose file documentation for configs at https://docs.docker.com/compose/compose-file/#configs-configuration-reference you'll see that using file here will make Docker search for the central_fuzzmanager.env at the specified path and thus will not work when using Portainer as you cannot provide the config this way.
Here, you'll want to use the external property instead:
configs:
  central_fuzzmanager:
    external: central_fuzzmanager.env

This will make Docker use the config named central_fuzzmanager.env when deploying the stack (you still need to create that config inside Portainer).
Tell me if this helps.

They way I had my .yml file was working outside of portainer, but thank you.
I now have:
version: '3.3'
services:
  domfuzz:
    image: dockerregistry.internal:5000/docker_domfuzz:latest
    depends_on:
      - fuzzmanager
    deploy:
      replicas: 4
      restart_policy:
        condition: on-failure
    configs:
      - central_fuzzmanager.env
    networks:
      - overlay

configs:
  central_fuzzmanager.env
    external: true

networks:
  overlay:

portainer.io UI properly shows my central_fuzzmanager.env config details.
I can still properly deploy this stack with
docker stack deploy -c my_file.yml my_stack

When I paste the above contents into the stack editor
name the stack test stack and then click deploy stack
I get the following:
central_fuzzmanager.env no such file or directory

It works fine with the following steps:

Create a new config named mytestconfig inside Portainer UI
Create a new stack with the following content:

version: '3.3'
services:
  web:
    image: nginx:latest
    deploy:
      replicas: 1
      restart_policy:
        condition: on-failure
    configs:
      - mytestconfig
    networks:
      - overlay

configs:
  mytestconfig:
    external: true

networks:
  overlay:

The stack is deployed and the config can be accessed.
I believe that your error come from:
configs:
  central_fuzzmanager.env
    external: true

Which should be:
configs:
  central_fuzzmanager.env:
    external: true

So, I tracked down the issue.

First I create a the config within portainer.
I deploy a second that references the config.
Note that there is an error about /data/compose/stack_name/config_name missing.
I manually copied the config file into /data/compose/stack_name/config name and things work fine.

@kkuehl have you tried the instructions I posted above?

Yes, my .yml file is similar to yours.
Tested on 1.15.5 as well.
When I manually copy the config file into compose/stack_name/
things work fine.

Here is my current test yml
version: "3.3"
This is a domfuzz test container used to test the new central_fuzzmanager configs
mechanism. The env_file method does not work in swarm mode.
services:
domfuzz_firefox:
build: ./domfuzz_firefox
image: dockerregistry.internal:5000/domfuzz_firefox:latest
container_name: domfuzz_firefox
cap_add:
- ALL
ulimits:
core: -1
deploy:
replicas: 4
restart_policy:
condition: on-failure
env_file:
- ./central_fuzzmanager.env
configs:
- central_fuzzmanager.env
networks:
- overlay
configs:
central_fuzzmanager.env:
external: true
networks:
overlay:

I believe that you need to upload a file because of the following lines in your compose:
    env_file:
     - ./central_fuzzmanager.env

Here, you require a file named central_fuzzmanager.env to be available in the root folder of the compose file.
You could work-around this by declaring environment variables in the Portainer UI or to put your compose file and .env file into a public git repository and deploy the stack using that repository.
Note: for clarity purposes, I'd recommend not using the same name for environment files and configs.

docker stacks are supposed to ignore the env_file: from the docker compose yml file.

@kkuehl watch out, you're not referring to the correct documentation.
But you're right, env_file seems to be not supported with stack deploy, it's kinda hidden in the docs: https://docs.docker.com/compose/compose-file/#variable-substitution

Working for me as of right now:
# top level config entries:
configs:
  some-config:
    external: true

# services definitions
services:
  app:
    configs:
      - source: some-config
        target: /path/to/mount/inside/container


Status of the repository

I've been planning to remove the GoogleCast dependency for a long time and this repo seems to be exactly what I'm looking for but the last commit is from three years ago. Is anyone using it for production apps and has had any problems with changes to the Cast protocol being incompatible with the current state of this framework?
Also, maybe it's possible to drop all dependencies but swift-protobuf and add support for spm.
In case someone is interested I could take a look at spm support.

I'd be very interested thank you.


fix: v25 app hash when syncing

What is the purpose of the change
we see apphash issues with this code path between blocks 16841115 and block 17004043, we ignore this code path for the purposes of syncing the node

Still confused me that there is a minimum height for activating this. That seems wrong, but can try it


[Feature][Cherry-Pick][Branch-2.5] Support IAM in Lake, Load and Export

What type of PR is this：

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Cherry-Pick from: #15121, #15835, #15890
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_be_unittest


Business Critical service tier Generation 5 compute platform table displays incorrect vCore counts for BC_Gen5_32 and BC_Gen5_48 performance levels

BC_Gen5_32 says 48 vCores and BC_Gen5_48 says 64 vCores; should be 32 and 48 vCores respectively.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96489790-4e4c-e461-7f5d-1e6f3f9d7d1b
Version Independent ID: eba2b7ce-ff3c-3adb-3ffb-295d31e97b6f
Content: Azure SQL Database vCore-based resource limits
Content Source: articles/sql-database/sql-database-vcore-resource-limits.md
Service: sql-database
GitHub Login: @CarlRabeler
Microsoft Alias: carlrab

@scarson I am confused why I am not seeing what you are seeing...https://docs.microsoft.com/en-us/azure/sql-database/sql-database-vcore-resource-limits

@CarlRabeler I realize I didn't specify it's the one under Elastic Pools, not Single Databases.
This is straight from the markdown:

@CarlRabeler I also noticed that the instance types under Elastic Pool - General Purpose service tier - Generation 5 compute platform are incorrectly prefixed "BC" instead of "GP".

Thanks – PR pending now
From: scarson<EMAIL_ADDRESS>Sent: Tuesday, May 15, 2018 2:09 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Carl Rabeler<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Business Critical service tier Generation 5 compute platform table displays incorrect vCore counts for BC_Gen5_32 and BC_Gen5_48 performance levels (#8655)
@CarlRabelerhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCarlRabeler&data=02|01|Carl.Rabeler%40microsoft.com|9072d0c7f1234e722e4a08d5baa80b53|72f988bf86f141af91ab2d7cd011db47|1|0|636620153265520315&sdata=0D2QoMx0Ja1y7QQRmoPe2T95byoP6trR%2Fkjh%2FSekw8E%3D&reserved=0 I also noticed that the instance types under Elastic Pool - General Purpose service tier - Generation 5 compute platform are incorrectly prefixed "BC" instead of "GP".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F8655%23issuecomment-389314063&data=02|01|Carl.Rabeler%40microsoft.com|9072d0c7f1234e722e4a08d5baa80b53|72f988bf86f141af91ab2d7cd011db47|1|0|636620153265530324&sdata=7qvB4B5u6JNZj2E7awtpDRAVtgEDdC8xplkBdCgrGjE%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMCBn5okAliUbt7fS_lnkF3zTToKJaUeks5ty0PcgaJpZM4UANgT&data=02|01|Carl.Rabeler%40microsoft.com|9072d0c7f1234e722e4a08d5baa80b53|72f988bf86f141af91ab2d7cd011db47|1|0|636620153265530324&sdata=9s1H1YYVj5bsPuQO5h4XJ7ny9%2F6k2Xnmd1tzi2PAPF8%3D&reserved=0.

@scarson We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


April buildpack upgrade

What
April buildpack upgrade. Deployed to dev01
How to review

Check it matches the email draft in the story and ensure the email makes sense
send out or poke me to send out the email
Mark the story as blocked with the date when the PR should be merged
Wait until the given date, then merge the PR to upgrade the buildpacks

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

This needs tidying up before merging. It's related to

https://github.com/alphagov/paas-auditor/pull/16
https://github.com/alphagov/paas-accounts/pull/16
https://github.com/alphagov/paas-prometheus-endpoints/pull/12
https://github.com/alphagov/paas-billing/pull/142

Assume that's what's causing the CI fails too

Assume that's what's causing the CI fails too

Yes, I think (/hope) so

Updated apps to golang 1.17 in order to have overlap between current and updated buildpacks.


Add test coverage for codegen frontend

I don't follow. None of these tests deal with visibility.

DaggerCodegen reflects on some classes that are in the same package and hence visible and deemed accessible by the JVM. Reflecting on classes that are in other packages and package visible could lead to IllegalAccessError as far as I know, so by just moving the tests to com.example this would be caught, if ever happens. Having tests in separate package would resemble the real world more where users would be createing their own Components.

Sure but that's not tied to this PR which is for adding coverage for exception cases.


API not working.

Change
let obj = JSON.parse(UrlFetchApp.fetch('https://fantasy.espn.com/apis/v3/games/ffl/seasons/' + year + '?view=proTeamSchedules').getContentText());
to this
let obj = JSON.parse(UrlFetchApp.fetch('https://lm-api-reads.fantasy.espn.com/apis/v3/games/ffl/seasons/' + year + '?view=proTeamSchedules').getContentText());
Appears to work.

There's a very big update I just did and overwrote the original single massive JavaScript file. Make a copy of the Google Sheet and see how it goes!


PMID:29975113 dma1 checkpoint paper

abnormal protein localization to mitotic spindle pole body during anaphase B
desc of
FYPO:0000939  abnormal protein localization to mitotic spindle pole body
normal temporal protein localization
desc of
FYPO:0003627  normal protein localization
(I don't want to recapitulate all of the multiple  places that it is normal over time)

normal temporal protein localization

Does this mean you want a "normal" term analogous to FYPO:0006606 ! abnormal temporal protein localization pattern?

yes, if that means that the protein localizes normally to multiple places ovr time.
However,
normal temporal protein localization
has a number of descendants:
https://www.pombase.org/term/FYPO:0006606
but probably many others can go under here.
I didn't really understand why
decreased protein localization to heterochromatin at centromere outer repeat
was under here?
and
abnormal protein localization to mitotic spindle pole body during anaphase B
could be...
Most proteins are temporally localized.... I thought about it for a minute or two and then I parked it.

normal temporal protein localization

Does this mean you want a "normal" term analogous to FYPO:0006606 ! abnormal temporal protein localization pattern?

yes, if that means that the protein localizes normally to multiple places over time.

Well, sort of, but for the abnormal term I've interpreted it specifically as meaning that a dynamic pattern of localization to one place is assessed over time and found to differ from wild type (so I wouldn't just use it to group anything with "localization to x during y").
I'll try to make that clearer in the text def.

[FYPO:0006606] has a number of descendants: ..
I didn't really understand why decreased protein localization to heterochromatin at centromere outer repeat was under here?

Not asserted; inferred by the reasoner for (erm) reasons that I don't see at a quick glance. Either I've botched a logical def (which would be easy to fix) or there's some connection in PATO that leads to inferences that I didn't intend (might be harder, or at least slower, to fix).
The only things I asserted to be is_a FYPO:0006606 are:
FYPO:0006188 decreased rate of protein exchange in actomyosin contractile ring
FYPO:0006359 decreased protein exchange at pericentric heterochromatin
FYPO:0006360 increased protein exchange at pericentric heterochromatin
FYPO:0006370 decreased protein exchange at subtelomeric heterochromatin
FYPO:0006607 abnormal intermittent protein localization to Cdr2 medial cortical node complex
I'll have a closer look next week.

OK got it. If you make the def clearer for the dynamic part.
I'll   just put normal protein localization  for dma1

note to self: oddball inferences due to pato:57  is_a pato:2323, but that's  probably ok, so work around it in fypo

new term
abnormal protein localization to mitotic spindle pole body during anaphase B FYPO:0006640
renamed FYPO:0006606, edited text def, deleted xp
edit file: 47ad3a835a58e6c143b7c8f204006ebf4f8b7789
release: 81e41b8f7725fd2c5603f84cb1d9faa9007dcb91


Need a base64 instead of save

I want only base64 of converted pdf.

Did you get anywhere with this?

To get a blob:  const blob = pdf.output('bloburl'). use the build method.


Allow configuring name

Addresses https://github.com/cronitorio/cronitor-kubernetes/issues/39. This should keep existing behavior if the new annotations aren't added.
I haven't modified, or ran any tests... and it looks like we don't have CI. I'll see what I can do to get my env set up (I prefer keeping everything dockerized, though)
Checklist

[x] Add functionality
[ ] Verify tests
[ ] Update readme

@dudo Dang you're fast! I just opened the repo to start working on this :)
I'll take a look through your PR, and am happy to help as you'd like. I also haven't looked into running the test suite locally, but it should run here via GH actions. I'm not sure why that didn't kick off when you opened that initial PR. I'll take a look at that now.

Hey @aflanagan! I don't think those test failures are related to my changes. I'll punt to you.


ionic-datepicker: Disable dates are clickable in windowsPhone8

Hi,
I'm using this js in android,ios and windows for selecting date ,Disable dates are working fine in android and ios , buts in windows disable dates are still able to select .
can you please help me on this .
if possible please provide  unminified   js version

There must be some issue with pointer events css.
For those dates which are disabled i am applying pointer_events_none css class which has css as below.
pointer-events: none;
color: #aaaaaa !important;

This link might help you


[Enhancement] LocalOMRSMetadataCollection validations should not bypass consistency of underlying repositories

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Many (most?) operations in the LocalOMRSMetadataCollection apply validations prior to actually running a write operation against the real metadata collection (underlying repository). For example, updateEntityClassification:

Retrieves the EntityDetail for the entity being classified from the real metadata collection (using getEntityDetail).
Checks over various aspects of that retrieved entity, including aspects of classifications within it.
If these pass, validate that a user is permitted to do the operation via the security verifier / connector.
If those all pass, then actually run the operation against the real metadata collection (updateEntityClassification in this example).

If the real metadata collection is using an eventual consistency model which it handles itself i.e. across a cluster of servers, then (1) may not behave as expected due to the ordering of operations that are self-managed by the underlying real metadata collection (and whether the given node that (1) happens to run against within that cluster is at the same level of consistency as previous write operations).
If (1) fails, or more problematically returns information about that EntityDetail which does not actually accurately reflect the current state of that EntityDetail, then the entire set of subsequent validation steps may either fail outright or (worse) proceed and end up risking silently clobbering some other interim update.
This introduces challenges in particular for (3), though, since currently the interfaces for (3) require that a full object (EntityDetail) is used for the security verification rather than the simple reference information about the entity (i.e. its GUID) that is received by the LocalOMRSMetadataCollection operation itself.
Expected Behavior
Since the underlying metadata collection is also responsible for validating prior to running its operations, on the one hand most of these validations should be redundant in the LocalOMRSMetadataCollection. The exception is the security verification, though, which appears to only exist in the LocalOMRSMetadataCollection (it doesn't appear to be part of the base OMRSMetadataCollection interfaces).
The hope would be that for a clustered metadata collection that self-manages its own consistency (like XT), we can:

enforce the consistency model we require directly in the plugin repository connector itself (to ensure that all write operations are appropriately ordered to avoid clobbering per #5707)
not have this consistency model violated by the validations done at the facade level (LocalOMRSMetadataCollection), which may themselves inadvertently prevent valid operations from executing
still apply the appropriate security verifier / connector constraints against the operations being run

However, to do this, it would seem we will need to:

allow a LocalOMRSMetadataCollection in which validations are switched off (or more accurately, are pushed down to rely entirely on the underlying real metadata collection applying those validations)
include the application of the security verifier / connector in this push-down (i.e. be able to configure that verifier / connector to be used directly within the real metadata collection rather than the LocalOMRSMetadataCollection facade)

Alternatives
If pushing down the security verifier / connector to run directly in the real metadata collection (the only place where a consistent read operation to retrieve the full EntityDetail object against which to validate could be guaranteed in distributed cluster) is not viable, then we may need to resort to either:

having that security verifier / connector make its decision based on much more limited information (just the GUIDs received by the LocalOMRSMetadataCollection interface itself, not the retrieved full object details)
rely on the underlying repository to apply some kind of "speculative" operation to return back the result of what it would have applied assuming the user is permitted to do so, then based on this returned result from the underlying real metadata collection apply the security verifier / connector in the LocalOMRSMetadataCollection, and then assuming it passes push yet another call back to the real metadata collection to actually do the persistence of the speculative work (e.g. something along the lines of a 2-phase commit).

(The latter option seems to me to be very cumbersome, and likely to be very expensive (if even feasible?) for many repositories, while the former seems like it will probably be insufficient -- we won't know just from the GUIDs e.g. what classifications that entity actually possesses, which may be the core drivers to a security decision.)
Any Further Information?
Based on all of this, it seems like the most robust approach is to ensure that the security verifier / connection can be applied directly within the real metadata collection (?)
Would you be prepared to be assigned this issue to work on?

[X] I can work on this

The layer above is doing very similar operations.  For example, if we create an entity, the next operation is often to add a relationship to it which involves retrieving the entity.   There are also security checks going on in the layer above so I am not sure it is possible to push down this problem.
However, I am keen to optimise the calls to the repositories whilst still preventing a rogue repository from corrupting the cohort's metadata.  So it may be work looking at which validations could be removed because the risk is worth the gain?
In the case where a guid is requested but not found, we could add similar logic in the topic listeners that assumes GUIDs are probably (eventually) valid and retry the retrieval a few times after a short sleep.  This does not of course help with the old version of an update being retrieved but could reduce problems seen higher up?


tests: Wait for feature-gate changes to be propagated

What this PR does / why we need it:
Give feature-gate changes some time to be propagated in this test:
HookSidecars [rfe_id:2667][crit:medium][vendor:cnv-qe@redhat.com][level:component] VMI definition with sidecar feature gate disabled [test_id:2666]should not start with hook sidecar annotation

We had in this weekly report three failures, all because the changes were not yet propagated.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/cc @petrkotas
/cc @slintes
/cc @dhiller

/cc @phoracek

/lgtm
/approve

/retest

Hook sidecar test did not fail in all the runs. Merging to increase test stability.

/cherrypick release-0.20


feat: add /generator path

Description
Add /generator path:

in first iteration generate only two official templates, html and markdown
add middleware for validation template parameters

Initialize /src structure:

separate logic: controllers (logic for route and their initialization), services (business logic and helpers)
add global middleware to catch all ProblemException error
add global middleware to validate AsyncAPI document being sent
add global middleware to validate request body based on operation's schema from OpenAPI Document
add unit tests

OpenAPI document:

change name of allowed templates, before html and markdown, now @asyncapi/html-template and @asyncapi/markdown-template
add required fields to the Problem schema

Some insights:
I think that we should go with names of paths with verbs like in our CLI, so /generator should be /generate, in future /validate, /convert, /bundle etc. I know that we decided go with REST patterns, but it doesn't work, really, I always wrote (in tests and source code) /generate path rather than /generator so it's more natural.
cc: @smoya @jonaslagoni @fmvilas @derberg
If you want share your opinions @BOLT04 I would be grateful, but if you don't have time, it's okay :)

Yeah, I'd not go with REST design for this API. Pure RPC seems a better fit IMHO. All methods will be POST and paths will always be verbs. The rest of the info can be provided in the request payload. Like you said, @magicmatatjahu, just like a CLI.

I just want to drop a comment regarding the whole design pattern used on this app. We are currently following some sort of MVC pattern, which it is enough for simple applications IMHO (like this one today).
However, I can detect and I would say even foresee that the logic on this API will be very similar, in part, to what the CLI does nowadays.
What about moving into a more Hexagonal Architecture pattern, where we can reuse most of the logic of both apps but the only (or mostly) thing that changes are ports and adapters?
Maybe worth discussing this in a new issue or discussion.

I just want to drop a comment regarding the whole design pattern used on this app. We are currently following some sort of MVC pattern, which it is enough for simple applications IMHO (like this one today).
However, I can detect and I would say even foresee that the logic on this API will be very similar, in part, to what the CLI does nowadays.
What about moving into a more Hexagonal Architecture pattern, where we can reuse most of the logic of both apps but the only (or mostly) thing that changes are ports and adapters?
Maybe worth discussing this in a new issue or discussion.

@smoya @BOLT04 Thanks for review and for feedback!
Honestly, about hexagonal architecture, I don't think so that it will be good idea. CLI (as @BOLT04 noted) has models and command, server-api will have controllers/routes (and some services). Even if we wanna create reusable parts (like services) we should see that for CLI/Server-API given service can be significantly different for two given environments. For example the generator - on the server side we have to generate in temporary folders and send the zip, in the CLI we generate in the folder specified by the user. I can say that currently we are using quasi-hexagonal pattern due to the fact that every tool in our organization is separate library and can be easily integrated into every environment. Why make life difficult for yourself, make wrappers/adapters in one, shared place and then again in another place, whether it is a server or CLI? 🤷🏼

@smoya @BOLT04 Thanks for review and for feedback!
Honestly, about hexagonal architecture, I don't think so that it will be good idea. CLI (as @BOLT04 noted) has models and command, server-api will have controllers/routes (and some services). Even if we wanna create reusable parts (like services) we should see that for CLI/Server-API given service can be significantly different for two given environments. For example the generator - on the server side we have to generate in temporary folders and send the zip, in the CLI we generate in the folder specified by the user. I can say that currently we are using quasi-hexagonal pattern due to the fact that every tool in our organization is separate library and can be easily integrated into every environment. Why make life difficult for yourself, make wrappers/adapters in one, shared place and then again in another place, whether it is a server or CLI? 🤷🏼

Maybe its time to change the generator :).
Anyway, I will move this into a separate issue so we are not completely blocking this pr.

Anyway, I will move this into separate issues so we are not completely blocking this pr.

@smoya could you add the link for the issue afterward here? I'd like to follow that discussion 🙂

I see some code smells from SonarCloud. I will merge that PR with chore: to not trigger release, because we don't have yet integrated needed packages to release automation, I will also fix that issues in the next PR and we can release 0.1.0 :)

@smoya @BOLT04 Thanks for review and for feedback!
Honestly, about hexagonal architecture, I don't think so that it will be good idea. CLI (as @BOLT04 noted) has models and command, server-api will have controllers/routes (and some services). Even if we wanna create reusable parts (like services) we should see that for CLI/Server-API given service can be significantly different for two given environments. For example the generator - on the server side we have to generate in temporary folders and send the zip, in the CLI we generate in the folder specified by the user. I can say that currently we are using quasi-hexagonal pattern due to the fact that every tool in our organization is separate library and can be easily integrated into every environment. Why make life difficult for yourself, make wrappers/adapters in one, shared place and then again in another place, whether it is a server or CLI? 🤷🏼

Maybe its time to change the generator :).
Anyway, I will move this into separate issues so we are not completely blocking this pr.

@magicmatatjahu @BOLT04 I created a discussion about this topic with a more expanded context. You might want to look at it https://github.com/asyncapi/parser-js/issues/401


It doesn't actually denoise nor debounce

I see that denoise and debounce are actually implemented and they work. I think you should close this issue now.

Thanks, I forgot


Injector cannot resolve non-instantiable argument with a default value

What steps will reproduce the problem?
Create a method with a typed object with a private constructor (the object is only instantiable via named constructors) but set the default argument to null. Example:
class SomeService
{
    public function __construct(SetCookie $cookie = null) { ... }
}

Then, call Injector::make on the class name.
What is the expected result?
I expect the injector to be able to resolve even when the class cannot be instantiated since there is a default value that can be passed.
What do you get instead?
I get an error saying that the class cannot be instantiated.
Additional info

Q
A

Version
1.0.2

PHP version
7.4

Operating system
ubuntu

I can implement the improvement in a PR if you are willing to merge it. I think this is a very reasonable expectation.

Would you please pull request a failing test? It's not completely clear about your case. You have a public constructor in your example but you're talkin about private one.

@samdark Thanks for your suggestion. Writing the test case I realised it passes, so there is something else I'm doing wrong on my end. Thanks for your time!

Well,  I think this call could be improved:
if ($class !== null) {
            $argument = $this->container->get($class);
            $state->addResolvedValue($argument);
            return true;
        }
        return false;

Maybe we should catch a possible exception from the inner container get() call and attempt to fallback to something else, like a possible default argument?
I acknowledge the fact that this is very particular to my issue, but exceptions are documented in the PSR-11 spec so maybe is not a good idea to ignore them.

@mnavarrocarter would you please pull request a test with your specific case?

Maybe we should catch a possible exception from the inner container get() call and attempt to fallback to something else, like a possible default argument?

It happens on a higher level
https://github.com/yiisoft/injector/blob/4f89e76c433a7bf28b516705973ab0d158b092e9/src/Injector.php#L184

@samdark @roxblnfk Don't mind me. There is not a problem or bug with this. :)


Added android InApp closebutton on UI

As intended, I added a InApp close button for android.
It uses the refactor options branch did by @nleclerc, so you can easily specify (or not) the showAndroidClose option. It will be false by default, and the option is ignored by iOS.

This will be a breaking change, so has been moved to the 3.0.0 milestone

@Stending Hey! This PR also seems to include the commits pushed to the #45 PR - could we close the other PR and update the title/description of this PR to include all the changes?

I think it wouldn't be a problem!
I have another branch based on this one (#48) by the way, maybe you could wait for my PR (it'll be done in 1 hour max) and close #45 and #48?

@Stending - that works for me - please bear in mind we plan on waiting until the 3.0.0 release before these changes will be readily available to the 'public'. So, if the new Pull Request doesn't have breaking changes or doesn't specifically rely on this, it may be worth basing off of master?

Covered by #60


isMandatory checkbox is disabled but not checked

<EMAIL_ADDRESS>
Browser(s) version(s):
Version 111.0.5563.64 (Official Build) (64-bit)
Description of the issue/feature:
isMandatory checkbox is disabled but not checked

Hey @guanacone sorry for the late reply 👋🏻.
We investigated your issue and couldn't reproduce it with any version above 3, neither with the web component integration nor with the react integration. Some further questions to investigate on our side would be:

Can you provide the exact version of @porscheofficial/cookie-consent-banner-react you installed?
Have you tried upgrading the package to the latest version?
Does the issue come up when the banner is first rendered and no settings were submitted yet or when you trigger the cookie banner programmatically again via triggerCookieConsentBanner()?
Do you apply any special styling to the element?

If you could provide a code sandbox or similar, this would be even better.
Thank you for your request and the patience. 🙌🏻


bundle exec (1.1.rc) gem list uses parent Gemfile under tmux+rvm

RVM devs (@mpapis) say they have resolved their tmux issues, and suggest that, what remains is of this, is a Bundler issue:
Given a tmux panel, a sub-folder and it parent-folder, both folders contain a Gemfile.  Now cd child; bundle exec gem list returns the parent's Gemfile listing.  However in a plain gnome terminal bash session the correct gem list is shown - child's.

just to make it clear I only suggested using the release version of bundler (1.0.21)

@mpapis, ack. that. A release candidate is precisely for catching these sorts of issues.  I don't think anyone reads anything accusatory in your suggesting 'take it to Bundler' - in case they do I've clarified the initial report.

I'm beginning to think this is a manifestation of issue #865

Hmm, maybe this is a regression of issue #291


chore: remove ampersand from package description

The ampersand confuses nupkg when generating Windows installers from
electron-builder.
The referenced issue talks about an issue where the ampersand is present
on the application name, but anything that gets into the .nuspec XML
file, including the description, triggers the issue.
See: https://github.com/electron-userland/electron-builder/issues/517
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

The latter comments in that thread imply that there's a workaround?

@lurch The workaround seems to be:

@initPRAGMA just use nsis target (default target for Windows now).

Which we don't want to do, since we want to generate Squirrel installers to implement auto updates in the future.

Ping @lurch

The pedant in me says that electron-builder ought to fix their scripts to escape things properly, but the pragmatist in me says all the CI tests are passing so I'll approve ;-)

Haha, I'll see if I can escape it somehow after the electron-builder transition.


Add back elixir tests to make check

Overview
Add back the elixir tests to make check. I want to use this branch to try and fix any flaky tests.
Testing recommendations
Elixir tests should pass more consistently
Related Issues or Pull Requests
https://github.com/apache/couchdb/issues/1902
Checklist

[ ] Code is written and works correctly;
[ ] Changes are covered by tests;
[ ] Documentation reflects the changes;

I will try after travis is happy with this PR.

@garrensmith you broke Jenkins.
Good place to start: https://builds.apache.org/blue/organizations/jenkins/CouchDB/detail/master/499/pipeline
Some of those are being killed because test runs are taking > 1h. Ycan relax that delay in Jenkinsfile but that's not great that our tests are taking 1h


Fixed broken rollback migratio in processes' name

This is a migration fix added by https://github.com/rails/solid_queue/commit/76d2c0f62e60663407bf0bba384e8d667f9cc3e3.
Since up is a change to NOT NULL, down must undo it.

Hey @rosa, I did not report the GitHub issue as I think it was a simple mistake.
This is not that big a problem, but it is a source of confusion and has been corrected.


Backups delayed by 1 week

Every time I want to reference a message from the past week, I have to go into the app and force a manual backup.  Why is there a 1 week delay?
version 1.5.10
phone: Motorola Droid Turbo 2

Closing as duplicate. Please try the beta: http://github.com/jberkel/sms-backup-plus/#beta


Improve deserialize_ignore_any

Mention it in the Changelog
Add test cases
Describe the secondary use case.

@lovasoa Since you contributed the function.

@lovasoa Since you contributed the function.

bors r+

bors r+


This error occurred on the android4.4.2 system tablet (screen size 10.1 inches).

There isn't enough information here to have an issue.

https://github.com/afollestad/material-camera/releases/tag/0.2.2


ESLint, Typings Declaration File?

I am happy to write a typescript typings declaration file for the project.
Also I suggest using AirBnB's eslint file.

We're currently reworking how this library works, let's wait for that to happen before adding typings. Thanks a lot for the offer though, I'll definitely come back to it!
Part of that change will be to use prettier for formatting the code, which will already take care of a lot of the advantages of airbnb's config. I'd prefer to maintain the remaining settings in this repo (it won't be that many anyway).

Having typings would be awesome !

There is already a pretty large conversion of the codebase to a newer flavor of es6... adding type support would either need to be done by https://flow.org or typescript.
Flow would be the easiest to begin implementing, while typescript would require another rewrite... not sure if that would be desirable.
When minimally implemented (as needed, in effective areas), flowtype can be really beautiful. Otherwise it can turn your codebase into a monster you never want to touch again.

I'm actually finding myself in the position of rewriting this to TypeScript right now. When I'm done or close to it, I'll throw it up on GitHub.

@ColtonProvias @kiwileaks78  @condulum I've started a fork with a typings ... feel free to help out!
Pull Request:
https://github.com/coinbase/gdax-node/pull/108
Fork:
https://github.com/JakeRad/gdax-node
npm install command:
npm install github:JakeRad/gdax-node

Merged it! :D


feat: expose new vars

Description
Expose new security group variables for terraform-ibm-base-ocp-vpc
https://github.com/terraform-ibm-modules/terraform-ibm-ocp-all-inclusive/issues/241
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
Expose new security group variables for terraform-ibm-base-ocp-vpc
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

@jor2 I think you have some typos

I'm going to have to update all the other modules, is there an easier way?

/run pipeline

:tada: This PR is included in version 2.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Added more sites and cava wp mapping

Overview
This PR adds more sites for CAVA and additional columns.

Still waiting for an additional icon column for sites Mapping interface.

Pull Request Test Coverage Report for Build 351

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 348:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


DPL-067-2 Prevent Tag Clashes on PBMC Pooling Plate (S)

User story
As a developer, I would like to prevent tag clashes on creating the PBMC Pooling Plate, as pools contain many untagged samples, cause a tag clash when they are added to a well in the destination plate
See original story DPL-067
UPDATE:
Implementing a "compound" sample https://lucid.app/lucidchart/3b5d0823-4c0b-44ef-b314-e9f29eb3e696/edit?beaconFlowId=7BAFD3068DF71E5F&page=0_0#?referringapp=slack
Who are the primary contacts for this story
James
Harriet
Stuart
Stef
Acceptance criteria
To be considered successful the solution must allow:
SS Database:

[x] Remove all things tag_depth
[x] Revert the existing aliquot_tags_and_tag2s_are_unique_within_receptacle index, to include the new column above

Dependencies
This story is blocked by the following dependencies:

See original story DPL-067
Sequencescape PR DPL-067-2

Additional context
MLWH:
The uniqueness constraint in the WH uses ‘aliquot_index’ which is a value we generate specifically for NPG. In many ways it operates similarly to the proposed new column (in that it resents per pool, and increments for each aliquot in the pool). However, unlike the proposed solution it: 1) Uses a separate table. 2) Is only populated for the sequencing lanes at batch release. 3) Is guaranteed to be unique within a pool. There’s also a bit of added complexity to avoid assigning a few ‘magic’ numbers which downstream processes may be making assumptions based of previous conventions.

TODO:

[ ] DPL-067 build_pools dynamically
[ ] update CSV
[ ] rename tag_position to tag_depth, and in index
[ ] tests in SS
[ ] tests in Limber
[ ] tests in SS Gem
[ ] refactor the depth generation  in transfer_request_attributes method  (currently test_position)
[ ] Update Pooling Plate Presenter, display id of pool OR number or samples in pool/well

Create branch of this existing branch

Post Tag Clash meetings:

[ ] Create a new branch from this branch
[ ] On the new branch, revert back all tag_depth, from aliquots table and revert back the index

Closing, as this branch was to add a tag_depth column, which has now been reverted. Original story https://github.com/sanger/limber/pull/833


refactor(transform): fix doc comments for methods generated by inherit_variants! macro

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3195  👈
#3194
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


couchdb2: 2.1.2 -> 2.2.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/couchdb/versions.
meta.description for couchdb2 is: '"A database that uses JSON for documents, JavaScript for MapReduce queries, and regular HTTP for an API"'.

Checks done (click to expand)

built on NixOS
Warning: no invocation of /nix/store/ysnyafnam2nca74lkxdl13fk3czv0ns5-couchdb-2.2.0/bin/couchdb.cmd had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/ysnyafnam2nca74lkxdl13fk3czv0ns5-couchdb-2.2.0/bin/couchup had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/ysnyafnam2nca74lkxdl13fk3czv0ns5-couchdb-2.2.0/bin/couchdb had a zero exit code or showed the expected version
/nix/store/ysnyafnam2nca74lkxdl13fk3czv0ns5-couchdb-2.2.0/bin/couchjs passed the binary check.
/nix/store/ysnyafnam2nca74lkxdl13fk3czv0ns5-couchdb-2.2.0/bin/remsh passed the binary check.
Warning: no invocation of /nix/store/ysnyafnam2nca74lkxdl13fk3czv0ns5-couchdb-2.2.0/bin/.couchdb-wrapped had a zero exit code or showed the expected version
2 of 6 passed binary check by having a zero exit code.
0 of 6 passed binary check by having the new version present in output.
found 2.2.0 with grep in /nix/store/ysnyafnam2nca74lkxdl13fk3czv0ns5-couchdb-2.2.0
directory tree listing: https://gist.github.com/2e62180aacadfbd665d72746a8f42664
du listing: https://gist.github.com/d193816a3178412fe6ecd937562f43cc

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 841d3a5da3a55f37e6a6b803b3515979bf63ceb8 && nix-shell --pure -I nixpkgs=. -p couchdb2

cc @garbas for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: couchdb2
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: couchdb2
Partial log (click to expand)
checking for references to /build in /nix/store/ysnyafnam2nca74lkxdl13fk3czv0ns5-couchdb-2.2.0...
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/ysnyafnam2nca74lkxdl13fk3czv0ns5-couchdb-2.2.0

Failure on aarch64-linux (full log)
Attempted: couchdb2
Partial log (click to expand)
./yarr/yarr/RegexJIT.h:73:10: note: candidate: void JSC::Yarr::RegexCodeBlock::set(int)
     void set(MacroAssembler::CodeRef ref) { m_ref = ref; }
          ^~~
./yarr/yarr/RegexJIT.h:73:10: note:   no known conversion for argument 1 from 'JSC::LinkBuffer::CodeRef {aka JSC::MacroAssemblerCodeRef}' to 'int'
make[1]: *** [config/rules.mk:1475: RegexJIT.o] Error 1
make[1]: Leaving directory '/build/js-1.8.5/js/src'
make: *** [config/rules.mk:754: default] Error 2
builder for '/nix/store/spbsmvx3zxnhk6l145dcw3ci139xylbz-spidermonkey-1.8.5.drv' failed with exit code 2
cannot build derivation '/nix/store/17saw3gk277kwq6lyd4xbzmam00g8irw-couchdb-2.2.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/17saw3gk277kwq6lyd4xbzmam00g8irw-couchdb-2.2.0.drv' failed

aarch64 failure of dependency spidermonkey_1_8_5 has been around for a while, unrelated.

@GrahamcOfBorg test couchdb

Success on x86_64-linux (full log)
Attempted: tests.couchdb
Partial log (click to expand)
couchdb2: exit status 0
couchdb1: running command: sync
couchdb1: exit status 0
test script finished in 31.12s
cleaning up
killing couchdb2 (pid 609)
killing couchdb1 (pid 621)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/xihh2vbrsbscdmbvblhjqmxnrs7xk8al-vm-test-run-couchdb

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: couchdb2, spidermonkey_1_8_5
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: couchdb2, spidermonkey_1_8_5
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: couchdb2, spidermonkey_1_8_5
Partial log (click to expand)
/nix/store/byl5mw0nx94gq45ngxf381d9vj348yiz-couchdb-2.2.0
/nix/store/6aabjdz4sfani2m3ygcfaismj1rmxgac-spidermonkey-1.8.5

Timed out, unknown build status on aarch64-linux (full log)
Attempted: tests.couchdb
Partial log (click to expand)
cannot build derivation '/nix/store/a1mwrkqasrqhlish7fvhnlx74vv71gli-nixos-system-couchdb2-18.09.git.af30ea9.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0cn5lw98ii03njdzyxdi9q56fc26z34c-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/w09582p6mciw9f2fdr43gq16lgqnlcr0-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nfsr0f7rycgrv2vk1nysh310zb0aa6hr-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/zd0c2yx4cpnxcqpqdyaxk0mbmysbdip8-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6fw3r7qnz5grgz3mbsksm0z46a8g319l-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/xlmsfaqcwnj64nq51dnn5ib8hf3jibgj-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/zqd4aycrksm7n48s82cd0pxyshlrmghx-nixos-test-driver-couchdb.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/9pc6xp7xia77wmcbaihxy8n0mr09wwvn-vm-test-run-couchdb.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9pc6xp7xia77wmcbaihxy8n0mr09wwvn-vm-test-run-couchdb.drv' failed


Implement new "Content band checkmarks" section/pattern

Problems/Motivation

This ticket is part of the phase 3 effort, which is to migrate all of the remaining components/patterns in AEM over to Franklin. See EPIC for more detail (MERATIVE-765)
Section > Section Content band checkmarks
Note: part of this work is to clean up the naming in Franklin to ensure it aligns with our Design Systems.

Sharepoint Doc Structure

https://merative.sharepoint.com/:w:/r/sites/Merative.comWebsite/_layouts/15/Doc.aspx?sourcedoc={C32AC9D0-6DF0-4720-A997-A30236C6CEDF}&file=section-content-band-checkmarks.docx&action=default&mobileredirect=true&cid=f46d268f-57e8-43fd-b154-1f67521ddb11
https://main--merative2--hlxsites.hlx.page/block-library/sections/section-content-band-checkmarks
Need to create a new section for this called "Section content band checkmarks"
Variations needed white background and bone background

Design/Specs

Figma link - https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=1459%3A12919&mode=design&t=0mcFm2zGMxvLkL3D-1

Dev Checklist

Open a PR on the Franklin repo project - https://github.com/hlxsites/merative2
Follow the PR template and include written testing instructions
Once, the PR has been merged, make sure to update "Block Library" (see link) to include the block content entry structure for this variation.

Corresponding JIRA ticket

https://jira.sdlc.merative.com/browse/MERATIVE-780

I saw someone was working on a block-library page, but I see it need some style help.
https://239-sidekickupgrade--merative2--hlxsites.hlx.page/tools/sidekick/library.html?plugin=blocks&path=/block-library/sections/section-content-band-checkmarks&index=1

Thanks @helms-charity . @nimithshetty17  is working on this one and will open a PR for this when ready.


Depositing stETH could be under the "Capital" section, not "Community"

The Community Section is for community contributions.
The Capital Section and tab is used for depositing the stETH.
So basically IMO some of the content currently in the Community tab with depositing and claiming could be moved the Capital tab for better experience. Really nice to see this working in this version!

Looks like the issue has been fixed. I'm closing it.


How do you parse lon and lat in a view

Hi, I just installed Geocoder and it works great, except I'm having a bit of glitch getting the lat and lon values. Here's how I call it in the controller within Phoenix:
{:ok, geo} = Geocoder.call("Toronto, ON")
And this is my result on <%= geo %> in the view template:
protocol Phoenix.HTML.Safe not implemented for %Geocoder.Coords{bounds: %Geocoder.Bounds{bottom: 43.45829699999999, left: -79.639219, right: -79.00248100000002, top: 43.8554579}, lat: 43.653226, location: %Geocoder.Location{city: "Toronto", country: "Canada", country_code: "CA", formatted_address: "Toronto, ON, Canada", postal_code: nil, state: "Ontario", street: nil, street_number: nil}, lon: -79.3831843}. This protocol is implemented for: Atom, BitString, Date, DateTime, Decimal, Ecto.Date, Ecto.DateTime, Ecto.Time, Float, Integer, List, Map, NaiveDateTime, Time, Tuple

I figured it out, unless there's a better more idiomatic way to do this in the controller.
{:ok, geo} = Geocoder.call("Paris, France")
lat = geo.lat
lon = geo.lon
I also need to be able to do radius search by distance, i.e. everyone within 25 miles of a certain lon and lat.
Would it be better to do that in postgis or some other recommended dep plugin?

They @AppyCat. The geocoder package currently does not support searching a distance. Since you probably want to find data points associated wih geocoords and considering geocoder doesn't know your data, doing this on DB level seems like a good way to go.
Also, a slight improvement on getting just the lat/lng values:
{:ok, %{lat: lat, lon: lng}}  = Geocoder.call("Berlin, Germany")

Thanks. I go it working with Earthdistance and Cube extensions added to Postgres with this Ecto query:
def in_area do
Member
|> Ecto.Query.where([m], fragment("earth_box(ll_to_earth(lon, lat), distance) @> ll_to_earth(?, ?)", m.latitude, m.longitude))
|> Repo.all
end

On Oct 30, 2017, at 6:12 AM, Carsten Zimmermann<EMAIL_ADDRESS>wrote:
They @AppyCat https://github.com/appycat. The geocoder package currently does not support searching a distance. Since you probably want to find data points associated wih geocoords and considering geocoder doesn't know your data, doing this on DB level seems like a good way to go.
Also, a slight improvement on getting just the lat/lng values:
{:ok, %{lat: lat, lon: lng}}  = Geocoder.call("Berlin, Germany")
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/knrz/geocoder/issues/36#issuecomment-340439223, or mute the thread https://github.com/notifications/unsubscribe-auth/ANAKcFvAvjXdb1K2zIGGlu-mxG7l_BXLks5sxcswgaJpZM4QKNnZ.


protein homohexamerization

I would like to see "protein homohexamerization” added to the GO ontology under the parent terms "protein homooligomerization” (GO:0051260) and “protein hexamerization” (GO:0034214).  The definition could be "The formation of a protein homohexamer, a macromolecular structure consisting of six noncovalently associated identical subunits.”  Example can be found in PMID:20161783.

Do we really want to continue down this route of activities? We discussed this a little last week.

I really thing these are components. If this is really important to capture, we could add to 'protein containing complex':

protein dimer
-protein trimer
protein tetramer
(and even the homo and hetero version of those).

Would that be a solution ?
Thanks, Pascale

Definitely sounds good.  I've long thought that dimer, trimer, etc belonged in cellular component.

Links to this old and still undecided ticket:
https://github.com/geneontology/go-ontology/issues/11094

@ukemi Can we put this on the top of the list for the next editors call ?

Personally I would prefer not to represent stoichiometry in GO.
It seems out of scope. We already have a simple  independent system to capture this , but to me it isn't really a cellular component or localization either.

We capture stoichiometry in the CP directly (and for each participant of the complex), not by using GO annotations. And we don't really annotate the assemblers beyond "complex assembly/scaffolding" etc terms.

Hi
I am fine with MF: homodimerization being CC homodimer.
However, can we keep MF: GO:0042802 identical protein binding
And change the parent of GO:0043496 regulation of protein homodimerization activity
This has 29 manual expt annotations.
To > regulation child of GO:0042802 identical protein binding
Ruth

Also Val
please would you explain how PomBase captures this in a 'simple independent system' and why PomBase feels it is necessary to capture this data.
Thanks
Ruth

Well we have always captured it if it is reported,  because it is there, but we didn't ask to put it into GO because it seems out of scope. So we just record it in a separate table. I don't really want to convert it all to GO annotation as it doesn't really seem  to be a good fit?
Its something I'm not even sure it is much used by our community.
I thought we had discussed many times over the years to move this out of GO ....it just seems to be orthogonal  info to F,P and C to me....

Our system basically involves  recording
monomeric
homomeric(2)
homomeric(4)
heteromeric(2)
heteromeric(10)
(we need to add a number to capture the stoichiometry)
We display this in a separate section of the gene page. It doesn't really link to the information captured by GO annotation.

I've always thought that IF (big if) the dimer/etc. is self-assembling, it is an important point. However, I also realize that there could be other factors that could influence the rate of an assembly so we have self-assembly processes that could be regulated (say by phosphorylation/dephosphorylation).
If not 'self-assembling' then  doesn't protein complex assembly already suffice?
Anyways, if we wanted to scratch these and move them to cc, I would not object.

Hi all,
I see @ValWood 's point but if people find it convenient I think these are fine as CC.
WRT assembly - would it not be sufficient to just have 'GO:0065003 protein-containing complex assembly'? is it really a different process to assemble a dimer versus a trimer, etc ?
Pascale

What was the resolution to this?

My recollection was that there was general agreement that biological process terms of this type are NOT appropriate since there are not general processes involved in dimerization, homoheximerization, etc.
I am not clear on whether or not there was agreement that having component terms to represent these types of terms would be appropriate.

So, I would

decline this request, which would close this ticket but
DO we OBSOLETE all terms under GO:0042802 identical protein binding (there appears to be just  one, homodimerization (or merge it into 42802)
the process terms are a mess
Protein protein homooligomerization,

the process terms are a mess
Protein protein homooligomerization,

Agreed, and the annotations for most of these are just  "things that  form oligomers"
absolutely no indication  that these are involved in the process of "homooligomerization"
I'd obsolete them all.....
We agreed to get rid of these lots of times. I'm sure it is in the minutes of more than one consortium meeting....

First one I looked at:
http://www.uniprot.org/citations/22486860
In support of this model we demonstrated that TgCactin is present in a protein complex and can oligomerize.

I just accidentally deleted my thread with the scope; #!!$#; @ValWood  you replied to my  partial response that I accidentally saved and then lost. Friday; I'm getting too old for this.
Basically, I was going to suggest that they are all protein complex assembly (because the parent for all of them is GO:0051259, protein complex oligomerization (strangely there is no link between this term and protein complex assembly).

Harold you said this:
So, I would
decline this request, which would close this ticket but
DO we OBSOLETE all terms under GO:0042802 identical protein binding (there appears to be just one, homodimerization (or merge it into 42802)
the process terms are a mess
Protein protein homooligomerization,

I thought you just changed your mind; )

No @ValWood , there was actually more following the "Protein protein homooligomerization.
And a weird one is protein heximerization, a child of protein heterooliogomerization,; it's def says either identical or non-identical subunits; that was I flag as a draw and quarter (beyond just kill)!

Definitely not changing mind

I think we should obsolete. I don't think that merging into 'protein complex assembly' would be correct since many annotations represent that the protein is part of the complex (including the complex Stan was proposing to annotate, as far as I can tell - @slaulederkind please correct me if this is wrong.
I think some people have objections because they want to capture the stoichiometry of complexes (or perhaps other reasons?)
Would anyone that have objections please explain the reasoning? (should we email go-consortium to get a wider response ?)
Thanks, Pascale

It was discussed lots of times, but in most detail at the Barcelona meeting
It is not clear from the minutes or the actions precisely what the decision was (there ia an action item but it is rather vague):
https://docs.google.com/document/d/1NonH97s8xEpDdx6DfonKPKI_RdHbbG-yft85UZtUmF0/edit#
but I thought the action was to get rid of the process terms, which are largely  used correctly to represent 'binding' rather than assembly.
Perhaps it just wasn't implemented? Maybe @paolaroncaglia  remembers (you presented on the issue at this meeting?)

Hi @ValWood et al,
Here's the ticket I created just before leaving a year ago, it collects links to discussions and proposals, including what were the latest ones at that time:
https://github.com/geneontology/go-ontology/issues/13036
Good luck :-)
Paola

@paolaroncaglia Thank you!


feat: parseWithCheerio pierces iframe elements

Following the recent update adding the shadow root expansion to the parseWithCheerio method, it would be nice if we could expand iframe elements (their contents) in a similar manner.
While replacing the iframe element in a browser could cause some styling / security issues, I'm assuming it's just a simple XML tree modification for Cheerio.

Looks like unless explicitly allowed, we cant access the content of an iframe from another origin at all. I was trying to get the HTML from inside the iframe of giscus comments and you only get null from the iframe.contentDocument in there.

You're talking about DOM API, right? I think there should be some way to look into the iframes from the Playwright orchestration (at least the docs say so).


Add more UT for Gluten

(you don't have to strictly follow this form)

Add more UT for Gluten:

[x] #85
[x] Add a gluten-ut module for migrating some spark test cases.

A clear and concise description of what is the intended usage scenario is.

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

please add concrete tasks

Spark SQL 的 UT 中，catalyst 和 SQL core 中的 UT 大概 9000 个左右；
Spark UT 大致分类：

文臣提到的 expression 单测，在 sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions 目录下，这类是对所有 expression 的一个测试，主要是通过 ExpressionEvalHelper 来执行 expression 并验证结果，这里有很多 function，如果 Gluten 集成，需要修改这里的 function；

迁移到 Gluten-374 进行跟踪。

Spark UT 详细列表及分工见 Gluten-374


Bump mio version

Warning: Only compilation is tested, runtime isn't
I first thought these changes were required for Redox support (#844) because I thought we'd need to modify miow. But we don't, since cargo is nice enough to automatically select newer, semver compatible, versions. Since I already did this, I'm sending it here. But really, I don't care if you don't merge it

winapi is part of the public API and cannot be bumped to 0.3.x as this would be a breaking change. I'm less sure off the top of my head about miow.

miow depends on winapi, so no I guess


More Data needs to be added

We need to add more data in the exerciseData.json file which includes various types of workout exercises and unique exercises

Hello there!
I am eager to contribute and address the issue concerning the addition of more data to the exerciseData.json file. To ensure an extensive collection of workout exercises, I will conduct thorough research to gather various types of workout routines, emphasizing uniqueness and diversity.
I am committed to organizing the data in a meticulously structured manner, maintaining seamless integration with the existing entries. Prior to implementing any changes, I will diligently review the current dataset to prevent redundancies and optimize the user experience.
Once the updates are finalized, I will promptly submit a pull request encompassing the new exercise data. This will enable the review process, allowing for valuable feedback and constructive suggestions, if any.
I look forward to making substantial contributions to enhance the value of the exerciseData.json file for all users. Kindly provide any specific guidelines or preferences you would like me to adhere to throughout this endeavor.
Thank you for the opportunity to contribute!
Best regards,
Mohsin-mw

I've created a PR adding few more exercises to the exercise.json file


DateTime format not ISO 8601

I realized that the date format in the results for a UTCDateTimeAttribute field for a pynamodb model was being sent on the results as '2021-06-07 17:40:59.538481+00:00' notice this is not ISO 8601 format which is used in JavaScript and commonly used in web applications.
https://github.com/yfilali/graphql-pynamodb/blob/master/graphene_pynamodb/converter.py#L30
Changing the code in the above line to instead of converting to String it converts to DateTime, will make the output of the datetime attribute to be output in ISO format.
Digging around I noticed there was this issue in graphene: https://github.com/graphql-python/graphene/issues/136 which is very similar to this but it was addressed in graphene. If I understand correctly they suggested creating a custom DateTime graphene scalar type, but then went ahead and introduced the new scalar in the library.
I can submit a PR if needed, I just don't know if this would be the optimal solution.

FWIW, this appears to be breaking ISO 8601 date parsing in swift from graphene, throwing:

Error Domain=NSCocoaErrorDomain Code=2048 "Cannot parse 2023-06-26T21:17:10.122457+00:00. String should adhere to the preferred format of the locale, such as 2023-06-27T03:19:52Z." UserInfo={NSDebugDescription=Cannot parse 2023-06-26T21:17:10.122457+00:00. String should adhere to the preferred format of the locale, such as 2023-06-27T03:19:52Z.}


Merge develop to cmd-develop

What
We need to get cmd-develop up-to-date with the large collection screen refactoring work. This branch is taken off of develop, so will get cmd-develop fully up-to-date.
How to review
Check that tests pass and that the refactored collections screen and CMD functionality still works as expected (since these two are the biggest divergences on develop vs cmd-develop).
Who can review
Anyone but me.

⚠ This PR has been superseded by https://github.com/ONSdigital/florence/pull/300 ⚠
The reason is that on this branch I had accidentally squashed all of the commits from develop into a single commit, removing the history of commits and meaning the branch appeared out-of-date with develop & master, even though code-wise it wasnt'. The new PR fixes has the code changes made on this branch to fix the conflict, but retains the commit history too.


gates do not like being one block away from each other

they also don't see each other but can dial with admin tool

Fixed

Fixed


Remove applicant deletion

Notion ticket link

[RCD] Modify User Deletion Feature
Checklist

[ ] My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
[x] I have run the appropriate linter(s)
[x] I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@ChinemeremChigbo Does this remove deletion for all permit holders? The requirement is to only remove for users who have completed applications.

@ChinemeremChigbo Does this remove deletion for all permit holders? The requirement is to only remove for users who have completed applications.

Ahh, Alas, I was confused by the Notion ticket description. I have modified this to only hide the deletion option for Applicant's whose mostRecentApplication's processing status is completed.


Console Output Problem

I'm new to the P5.js.Please tell me how to get console outputs in this extension.

Hey @VishwaNavod, apologies for the delay.
You can open the console by opening the command palette (ctrl+P) and typing in "developer console". On that screen there's a "console" tab where all the logs go to.


Can you help me find the links about the calling of pretrained moder for inference under C++ environment

Can you help me find the resource about the demo showing the calling of pretrained moder for inference under C++ environment?
I have training a model using Tensorflow2.4.x, and want to use it for inference in C++ environment, but I cannot find related resource in this project.

Hi @v3551G !
Could you check these two threads on the building and use Tensorflow C++ api.
1 (build tensorflow c api) , 2 (load and make inference with g++ ) . Thank you!


Configuration.ArrayElementSeparator related.

Hi,
Configuration.ArrayElementSeparator field is not used at some places.
Ref. following code...
mRawValue = string.Format("{{{0}}}", string.Join(",", strings));
Hardcoded ',' is used?

Fixed.


Is this a bug?

When I loop sending queries to get a small(this is key,130 Bytes) html document long time,I can get one err like this:
(spdy) 2015/07/14 17:52:08 error_handling.go:17: Error: Received PROTOCOL_ERROR on stream 0. Closing connection.
RoundTripper returned a response & error; ignoring response
And if I get two errors above continuous,the client will block cause the DefaultMaxIdleConnsPerHost is 2,and when occur this error,not produce t.connLimit[req.URL.Host].And it will block at dial() function at line 108:<-t.connLimit[u.Host] cause it wanna consume but nobody produce.
And why the server will response this error?Does some error occured in the client?

This should hopefully be fixed in 65e8ed3. Is this library being used in the server too? It's difficult to say what's going on without further context.

Yes,the lib is used in the server.But has some bugs and have fixed.My friends has commit some patches to you.This 65e8ed3 has fixed the block issue,but not fix bugs in source.If I use this client to test the server's qps,the server close the connection more often and client will rebuild the connection.