Textual definition update:

Hi GO,
Would it be possible to modify the name, definition and cross-reference (Rhea) of the following terms? It would be consistent with other sirtuin reactions
Thanks
Sylvain

GO:0061690; F:lipoamidase activity;
Change the name to:
NAD-dependent protein lipoamidase activity
New definition:
Catalysis of the reaction: (R)-N6-lipoyl-L-lysyl-[protein] + H2O + NAD+ = 2''-O-lipoyl-ADP-D-ribose + L-lysyl-[protein] + nicotinamide
New Xref: RHEA:63640 (not yet public)
PMID:25525879

GO:0047708; F:biotinidase activity;
Change the name to:
NAD-dependent protein biotinidase activity
New definition:
Catalysis of the reaction: H2O + N6-biotinyl-L-lysyl-[protein] + NAD+ = 2''-O-biotinyl-ADP-D-ribose + L-lysyl-[protein] + nicotinamide
New Xref: RHEA:70479 (not yet public)
PMID:25525879

GO:0061690; F:lipoamidase activity;   <<<<<< could now be synonym
Change the name to:
NAD-dependent protein lipoamidase activity
New definition:
Catalysis of the reaction: (R)-N6-lipoyl-L-lysyl-[protein] + H2O + NAD+ = 2''-O-lipoyl-ADP-D-ribose + L-lysyl-[protein] + nicotinamide
New Xref: RHEA:63640 (not yet public)
PMID:25525879
Current Def is broader and does not involve NAD: note that xref  MetaCyc:RXN-13031  reaction also does NOT invoke use of NAD
GO:0047708; F:biotinidase activity;  <<< new proposed synonym
Change the name to:
NAD-dependent protein biotinidase activity
New definition:
Catalysis of the reaction: H2O + N6-biotinyl-L-lysyl-[protein] + NAD+ = 2''-O-biotinyl-ADP-D-ribose + L-lysyl-[protein] + nicotinamide
New Xref: RHEA:70479 (not yet public)
PMID:25525879
Current def Catalysis of the reaction: biotin amide + H2O = biotin + NH3 is broader
EC xef: EC:<IP_ADDRESS>  Biotin amide + H(2)O <=> biotin + NH(3)  Broader
Current RHEA RHEA:13081 mapping to the ec is also broader and does not evoke NAD.
So there is a problem here with the renaming and def change in that I don't think these are simple replacements unless I hear that RHEA is obsoleted RHEA:13081
Would new rhea be a child? is it also mapping to the EC:

Hi Harold,
I guess @kaxelsen will be the appropriate person to reply to your question.
But I think that you are right. NAD-dependent protein biotinidase activity is a different activity not related to GO:0047708; F:biotinidase activity and we should therefore request a new term.
I was confused because of some misannotation, a curator using GO:0047708; F:biotinidase activity to describe NAD-dependent protein biotinidase activity.
Would it be possible to create a new term?
NAD-dependent protein biotinidase activity
definition:
Catalysis of the reaction: H2O + N6-biotinyl-L-lysyl-[protein] + NAD+ = 2''-O-biotinyl-ADP-D-ribose + L-lysyl-[protein] + nicotinamide
New Xref: RHEA:70479 (not yet public)
PMID:25525879
Thanks
Sylvain

This is a completely parallel discussion to the one in #22836. There seems to be two types of enzymes: a hydrolase type (EC 3.5.1.-) and an NAD-dependent transferase type (EC 2.3.1.-) (e.g. sirtuins). These two types use different chemistry and are unrelated, so there has to be terms for each.
RXN-13031 is a hydrolysis reaction. We do not have an equivalent in Rhea as it is based on an unpurified activity, for which the protein is not known. (pmid:21768091)

This makes much more sense. I will make two terms today.

Suggest parent? We don't seem to have the base (EC:2.3.1.-)

will use Transferring groups other than amino-acyl groups GO:0016747 as parent

[Term]
+id: GO:0106419
+name: NAD-dependent protein lipoamidase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: (R)-N6-lipoyl-L-lysyl-[protein] + H2O + NAD+ = 2''-O-lipoyl-ADP-D-ribose + L-lysyl-[protein] + nicotinamide." [PMID:25525879, RHEA:63640]
+xref: RHEA:63640 {source="skos:exactMatch"}
+is_a: GO:0016747 ! acyltransferase activity, transferring groups other than amino-acyl groups
+property_value: creation_date 2022-02-24T17:53:27Z xsd:dateTime
+created_by: hjd
[Term]
+id: GO:0106420
+name: NAD-dependent protein biotinidase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: H2O + N6-biotinyl-L-lysyl-[protein] + NAD+ = 2''-O-biotinyl-ADP-D-ribose + L-lysyl-[protein] + nicotinamide." [PMID:25525879, RHEA:70479]
+xref: RHEA:70479 {source="skos:exactMatch"}
+is_a: GO:0016747 ! acyltransferase activity, transferring groups other than amino-acyl groups
+property_value: creation_date 2022-02-24T17:55:29Z xsd:dateTime
+created_by: hjd


Add I2S HIL test

ESP32 and ESP32-S2 are not tested since I wasn't able to get it to work there.
However, this test might be really helpful since it's the only test where circular DMA is tested. Also, I2S tends to be hard to test manually

LGTM, thanks! Regarding ESP32 and S2, it's i2s or hil related issue?

I2S ... I wasn't able to get loopback working there. But since especially a lot of DMA code is shared it's still very helpful for those targets

Awesome .... the frequency on H2 is apparently so slow it takes forever to transmit the data. Will disable the test for H2 here and open an issue

Awesome .... the frequency on H2 is apparently so slow it takes forever to transmit the data. Will disable the test for H2 here and open an issue

Feel free to add it here https://github.com/esp-rs/esp-hal/issues/1524 if you prefer

Sorry, let's just disable that interrupt test. I have no idea was is introducing the variability in the latency.


fix status code string appears twice

Fix status string in response message appears twice if color-output feature is not enabled.
=== Response for POST http://localhost:3000/api/login
=> Status         : 200 OK OK

->
=== Response for POST http://localhost:3000/api/login
=> Status         : 200 OK

@CaoKha cool, thanks for the fix. Will be in next release.


This package does not build with GHC 9.4.8.

what I do
% git remote -v
origin	https://github.com/pxqr/base32-bytestring.git (fetch)
origin	https://github.com/pxqr/base32-bytestring.git (push)
% git rev-parse @
3a6fe39aa734fd053baababdc8afa413999c8cd1
% ghc --version
The Glorious Glasgow Haskell Compilation System, version 9.4.8
% cabal build
Build profile: -w ghc-9.4.8 -O1
In order, the following will be built (use -v for more details):
 - base32-bytestring-<IP_ADDRESS> (lib) (first run)
Preprocessing library for base32-bytestring-<IP_ADDRESS>..
Building library for base32-bytestring-<IP_ADDRESS>..
[1 of 3] Compiling Data.ByteString.Base32.Internal ( src/Data/ByteString/Base32/Internal.hs, /tmp/base32-bytestring/dist-newstyle/build/x86_64-linux/ghc-9.4.8/base32-bytestring-<IP_ADDRESS>/build/Data/ByteString/Base32/Internal.o, /tmp/base32-bytestring/dist-newstyle/build/x86_64-linux/ghc-9.4.8/base32-bytestring-<IP_ADDRESS>/build/Data/ByteString/Base32/Internal.dyn_o )

src/Data/ByteString/Base32/Internal.hs:73:1: error:
    Parse error in pattern: unpack5Ptr In a function binding for the ‘@’ operator.
                            Perhaps you meant an as-pattern, which must not be surrounded by whitespace
   |
73 | unpack5Ptr !tbl bs @ (PS fptr off sz) =
   | ^^^^^^^^^^^^^^^^^^
Error: cabal: Failed to build base32-bytestring-<IP_ADDRESS>.

what should happen
Running cabal build should build the package.
discussion
The reason for this error is that the parsing of @ has become white space sensitive, I think since the proposal https://github.com/ghc-proposals/ghc-proposals/pull/229, so in this case white space about the @ needs to be cut away.

After removing the white space about all @ characters and replacing inlinePerformIO with unsafePerformIO, I have this package build. Here is the patch:
diff --git a/src/Data/ByteString/Base32/Internal.hs b/src/Data/ByteString/Base32/Internal.hs
index aa7c5b3..29a9720 100644
--- a/src/Data/ByteString/Base32/Internal.hs
+++ b/src/Data/ByteString/Base32/Internal.hs
@@ -70,7 +70,7 @@ padCeilN !n !x
 -----------------------------------------------------------------------}

 unpack5Ptr :: Ptr Word8 -> ByteString -> ByteString
-unpack5Ptr !tbl bs @ (PS fptr off sz) =
+unpack5Ptr !tbl bs@(PS fptr off sz) =
   unsafePerformIO $ do
     let unpackedSize = dstSize $ BS.length bs
     BS.create unpackedSize $ \ dst -> do
@@ -164,7 +164,7 @@ cleanup io = unsafePerformIO $
     handler (ErrorCall msg) = return (Left msg)

 pack5Ptr :: Ptr Word5 -> ByteString -> Result ByteString
-pack5Ptr !tbl bs @ (PS fptr off sz) =
+pack5Ptr !tbl bs@(PS fptr off sz) =
   cleanup $ do
     let packedSize = dstSize $ BS.length bs
     BS.createAndTrim packedSize $ \ dst -> do
@@ -176,7 +176,7 @@ pack5Ptr !tbl bs @ (PS fptr off sz) =
     lookupTable ix
         | x == invIx = error $ show (w2c ix) ++ " is not base32 character"
         | otherwise  = x
-      where x = inlinePerformIO (peekByteOff tbl (fromIntegral ix))
+      where x = unsafePerformIO (peekByteOff tbl (fromIntegral ix))
     {-# INLINE lookupTable #-}

     dstSize x = d + if m == 0 then 0 else 1
@@ -248,10 +248,10 @@ pack5 (PS fptr off len) bs

 isInAlphabet :: Ptr Word5 -> Word8 -> Bool
 isInAlphabet !tbl !ix =
-  inlinePerformIO (peekByteOff tbl (fromIntegral ix)) /= invIx
+  unsafePerformIO (peekByteOff tbl (fromIntegral ix)) /= invIx

 pack5Lenient :: DecTable -> ByteString -> Either String ByteString
-pack5Lenient tbl @ (PS fptr _ _) bs =
+pack5Lenient tbl@(PS fptr _ _) bs =
   unsafePerformIO $ do
     withForeignPtr fptr $ \ !tbl_ptr -> do
       return $! pack5 tbl $ BS.filter (isInAlphabet tbl_ptr) bs

I have not checked if the package works as it should though.


[libSyntax] Make parsing of attributes more structured

Add significantly more structure to the way the attributes are parsed in libSyntax by no longer parsing the arguments as a TokenList. This way we can also parse @_specialize attributes correctly which can have a GenericWhereClause as one of its arguments.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@rintaro Unless you have any further comments, I'll be merging this tonight.


Set a limit on the number of configs

Dataset https://huggingface.co/datasets/Muennighoff/flores200 has more than 40,000 configs. It's too much for our infrastructure for now. We should set a limit on it.

see also #1366

Is it something that could be validated here? https://github.com/huggingface/datasets-server/blob/main/services/worker/src/worker/job_runners/dataset/config_names.py#L63 (Raise an exception if the dataset has more than N configs and avoid running children jobs) or should we try to process first N configs?

Exactly, we should raise an error here

Some stats:
> db.cachedResponsesBlue.aggregate([{$match: {kind: "config-parquet-and-info"}}, {$group: {_id: "$dataset", count: {$sum: 1}}}, {$sort: {count: -1}}, {$limit: 20}])
{ _id: 'Muennighoff/flores200', count: 12881 }
{ _id: 'facebook/flores', count: 10719 }
{ _id: 'allenai/nllb', count: 2656 }
{ _id: 'yhavinga/ccmatrix', count: 2394 }
{ _id: 'vialibre/splittedspanish3bwc', count: 1751 }
{ _id: 'nanom/splittedspanish3bwc', count: 1751 }
{ _id: 'red_caps', count: 1742 }
{ _id: 'lmqg/qa_squadshifts_synthetic_random', count: 1500 }
{ _id: 'Helsinki-NLP/tatoeba_mt', count: 824 }
{ _id: 'Zaid/tatoeba_mt', count: 824 }
{ _id: 'bigscience/P3', count: 660 }
{ _id: 'BigScience/P3', count: 660 }
{ _id: 'Muennighoff/multi_eurlex', count: 530 }
{ _id: 'codeparrot/github-code', count: 496 }
{ _id: 'codeparrot/github-code-clean', count: 496 }
{ _id: 'adamlin/daily_dialog', count: 485 }
{ _id: 'thewall/jolma_unique', count: 461 }
{ _id: 'thewall/jolma', count: 461 }
{ _id: 'CodedotAI/code_clippy_github', count: 384 }
{ _id: 'sil-ai/bloom-captioning', count: 376 }

we could set the limit at 3000


Scan stuck - endless FUTEX ETIMEDOUT

When running a SCAN process in a docker container, the scan process never ends and gets stuck.
I enabled DEBUG but I couldn't find any useful information. I used linux 'strace' tool inside a container to attach to 'java' process and its threads. this is an extract of the output I get after a few minutes of normal execution:
43    futex(0x7f656809ab28, FUTEX_WAKE_PRIVATE, 1) = 0
43    getrusage(RUSAGE_THREAD, {ru_utime={tv_sec=1, tv_usec=692087}, ru_stime={tv_sec=2, tv_usec=129479}, ...}) = 0
43    futex(0x7f656809ab7c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=299999021} <unfinished ...>
52    <... futex resumed>)              = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=49999063}) = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=15999248}) = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=33999606}) = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=49999171}) = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=49998563}) = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=49998269}) = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=49998896} <unfinished ...>
43    <... futex resumed>)              = -1 ETIMEDOUT (Connection timed out)
43    futex(0x7f656809ab28, FUTEX_WAKE_PRIVATE, 1) = 0
43    getrusage(RUSAGE_THREAD, {ru_utime={tv_sec=1, tv_usec=692087}, ru_stime={tv_sec=2, tv_usec=129620}, ...}) = 0
43    futex(0x7f656809ab7c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=299998802} <unfinished ...>
52    <... futex resumed>)              = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=49998805}) = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=49997408}) = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=49998236}) = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0
52    futex(0x7f656817867c, FUTEX_WAIT_PRIVATE, 0, {tv_sec=0, tv_nsec=49997979}) = -1 ETIMEDOUT (Connection timed out)
52    futex(0x7f6568178628, FUTEX_WAKE_PRIVATE, 1) = 0

Is it reproducible for a specific repo to scan that you can share?

Please reopen if this is still reproducible.


unknown field 'buffer'

With the new OpenCL cl.h file there is a change where an anonymous enum is giving troubles:
github.com/go-gl/cl/v1.2/cl
../../../../go/extern/src/github.com/go-gl/cl/v1.2/cl/package.go:726: unknown field 'buffer' in struct literal of type C.struct__cl_image_desc
I don't know how to properly solve this other than (temporarily) using the v1.2 cl.h header. Maybe there is a way to let cgo handle that enum?

It is the OpenCL 2.0 cl.h that causes this, i forgot to mention...


Wrong X-Forwarded-Proto

Using beta.7 with nginx the X-Forwarded-Proto on a tls secured ingress resource is set to http instead of https even when the route is accessed using https.

Hi, I was wondering whether you managed to resolve this? I think I may have a similar issue as described here: #894
Thanks,


Can't Download the latest CopilotStudioKit

When trying to download the latest version of the solution in the installation instruction readme, the link returns a not found page. #47

Still isn't working

The download link has been fixed.


feat(dev):  hmr websocket use the port of location.port

Use the port of location.port which support the develop mode with nginx proxy.
Due to the cookie policy, if you want to request to the online service in local development, you must use the same domain of online service.
So there comes an idea of proxy the  https://3000.onlinedomain.com to local https://localhost:3000
In webpack this works fine, the hot reload websocket url  will be wss://3000.onlinedomain.com. However in vite, it uses the PORT in config now, which will be https://3000.onlinedomain.com:3000, which will cause an ssl error. And this pull request is aim to use the location.port instead of config.

the check seems to be an issue with circleci. It's passed in local.

Correct me if I'm wrong but I believe this should no longer be necessary after b753478 which allows you to separately configure hmr ports.


Documentation for WebApi nested paths feature

Adds documentation for the feature that introduces "automatic" support for nested paths: https://github.com/OData/WebApi/pull/2456
I've added a brief page in the routing section and a more detailed guide in the how-to section.

I've set as is a draft until v7.6 is released.

Docs Build status updates of commit f372ea7:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md
:x:Error

Details

Odata-docs/webapi/nested-paths-routing.md
:x:Error

Details

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md

Line 10, Column 16: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-core-v7.6.md'.
Line 10, Column 87: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-v7.6.md'.
Line 36, Column 54: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1?view=odata-aspnetcore-7.0' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 36, Column 54: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1?view=odata-aspnetcore-7.0' will be broken in isolated environments. Replace with a relative link.
Line 36, Column 54: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1?view=odata-aspnetcore-7.0. Otherwise, remove the view parameter.

Odata-docs/webapi/nested-paths-routing.md

Line 10, Column 16: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-core-v7.6.md'.
Line 10, Column 87: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-v7.6.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e30c700:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md
:x:Error

Details

Odata-docs/webapi/nested-paths-routing.md
:x:Error

Details

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md

Line 10, Column 16: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-core-v7.6.md'.
Line 10, Column 87: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-v7.6.md'.
Line 36, Column 54: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1?view=odata-aspnetcore-7.0' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 36, Column 54: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1?view=odata-aspnetcore-7.0' will be broken in isolated environments. Replace with a relative link.
Line 36, Column 54: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1?view=odata-aspnetcore-7.0. Otherwise, remove the view parameter.

Odata-docs/webapi/nested-paths-routing.md

Line 10, Column 16: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-core-v7.6.md'.
Line 10, Column 87: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-v7.6.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a7b08db:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md
:x:Error

Details

Odata-docs/webapi/nested-paths-routing.md
:x:Error

Details

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md

Line 10, Column 16: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-core-v7.6.md'.
Line 10, Column 87: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-v7.6.md'.
Line 36, Column 54: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 36, Column 54: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1' will be broken in isolated environments. Replace with a relative link.

Odata-docs/webapi/nested-paths-routing.md

Line 10, Column 16: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-core-v7.6.md'.
Line 10, Column 87: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-v7.6.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2bc04f2:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md
:x:Error

Details

Odata-docs/webapi/nested-paths-routing.md
:x:Error

Details

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md

Line 10, Column 16: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-core-v7.6.md'.
Line 10, Column 87: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-v7.6.md'.
Line 36, Column 54: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 36, Column 54: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1' will be broken in isolated environments. Replace with a relative link.

Odata-docs/webapi/nested-paths-routing.md

Line 10, Column 16: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-core-v7.6.md'.
Line 10, Column 87: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-v7.6.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ab65237:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

Odata-docs/webapi/nested-paths-routing.md
:x:Error

Details

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md
:warning:Warning

Details

Odata-docs/webapi/nested-paths-routing.md

Line 10, Column 16: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-core-v7.6.md'.
Line 10, Column 87: [Error-include-not-found] Invalid include link: '../includes/appliesto-webapi-v7.6.md'.

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md

Line 36, Column 54: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 36, Column 54: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnet.odata.singleresult-1' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 3ad5dd4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/TOC.yml
:white_check_mark:Succeeded
View

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/nested-paths-routing.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6c41f5d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/TOC.yml
:white_check_mark:Succeeded
View

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/nested-paths-routing.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit af87290:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/TOC.yml
:white_check_mark:Succeeded
View

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/nested-paths-routing.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cd9c7c4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/TOC.yml
:white_check_mark:Succeeded
View

Odata-docs/webapi/automatic-nested-paths-with-enable-nested-paths.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/nested-paths-routing.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


feat(auction2): First pass rebuild /auction/id

This is a first-pass at rebuilding/refactoring the /auction/id page. Most of this work involved taking apart the old page to the point where I understood it well enough to work on it, and then went through and tried to to simplify the control flow, file count and organization as much as humanly possible while still preserving some of the logic that existed previously. Most of the hard work here was untangling things since it crossed numerous sides of force, from old force apps, to new force apps, to old server-side logic to new. All this said, there's some copy 🍝 in here from old (meaning new v2/Auction) app that could likely be cleaned up further.
A couple things to note:

I've only worked against the happy path. Meaning:

Staging auction was created in https://joe.artsy.net/job/gravity-staging-create-auction-on-demand/

Bid on those artworks, they always succeeded

Haven't tested any of the numerous failing paths that the logic accounts for

Still need to write tests

Still need to verify identity verification flows still work

Need to wait on MyBids component (ask out to design)

Still need to add promoted sale rail

Example with header. NO Bidding (old auction engine / staging copy): http://localhost:5000/auction2/heritage-urban-art-companion

Example that you can bid on; created from jenkins: http://localhost:5000/auction2/chris-moction

Now that this thing is together to the point where it's actually possible to develop for I think a good next task would be to write up control flow document for all possible auction states and verify each case executes properly.
Also, sorry for lack of git history here. This thing was honestly too insane to think about apart from just smearing paint all around and being patient.

@mzikherman / @bhoggard - Needless to say, this has not been QA'd yet -- however, I don't expect the structure and whatnot to change much and feel fairly confident that folks could work in parallel in this v2/Apps/Auction2 folder on the timed bidding stuff (if you need to get started soonish). Otherwise, just going to moving getting this closer to completion and will let you know when its done. Things should come together pretty fast once this is merged.


page 640, Section <IP_ADDRESS>, $\theta$ parameterization

What is $\theta$ in equation 19.30? $p(y)$ and $p(z)$ are parameterized w.r.t. $\theta$. Based on the ensuing discussion it is not clear how $p(y)$ or $p(z)$ depend on $\theta$. My understanding is that $\theta$ represent the parameters of the decoder network $f$. Does it imply that $p(y)$ and $p(z)$ are part of the decoder network?
I wonder if it could be possible to either clarify what $\theta$ is and how $p(y)$ or $p(z)$ depend on it or otherwise remove the $\theta$ parameterization in $p(y)$ and $p(z)$ to avoid confusion?

fixed


tautulli: 2.2.4 -> 2.6.1

Motivation for this change
Upstream update, cleanup of the code to reduce the size of the closure (it contained stuff to build rpm and windows launcher), and migration to python3
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

I guess the flags datadir or config can help to avoid this. Don't know why a program would expect its folder to be writable place

Result of nixpkgs-review pr 104496 1

1 package built:

tautulli

LGTM, with that small nit.


Add Kopia Repository Server based Blueprint for MySQL Application

Change Overview
Add Kopia Repository Server based Blueprint for MySQL Application
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[x] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Issues

fixes #issue-number

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

Working on adding README

@r4rajat


Binary code background is misaligned after crop

I attached two pics, one with how it's supposed to look vs how it looks
I used the crop for featured artwork version, in a featured artwork showcase
On steam.design it looks aligned properly.
I also tried to switch between Full Screen/Original in Steam's background settings, but it didn't help.
The link to the background is [this]

This is a backend issue, assigning @TrueCarry


Provide backward compatibility for #124

First pr for issue #344 , focus on backward compatibility for #124

Closed for lint fix.


Sharing session cookies on IOS does not work

Bug description:
We open a webview to login on our system. The login session is persisted with session cookies. When the webview has finished the login, we expect react native fetch to have the cookies and thus to be able to retrieve APIs.
On Android, it works great. On iOS, session cookies seem to be synced from webview to native.
To Reproduce:
To reproduce i have created a minimal app with a webview to Wikipedia: https://github.com/jccazeaux/rn-webview-cookies-issue
Wikipedia has a login similar to our case with session cookies (if you uncheck "Keep me logged in").
 An alert will display the effective called url.

If cookies are correctly used (on Android) : the effective url will be https://en.m.wikipedia.org/wiki/Special:Notifications
If cookies are not sent (on iOS) : the effective url will be https://en.m.wikipedia.org/w/index.php?returnto=Special%3ANotifications&returntoquery=&title=Special:UserLogin&warning=echo-notification-loginrequired&centralAuthAutologinTried=1&centralAuthError=Not+centrally+logged+in (Wikipedia redirects to login page)

If you let keep me logged checked, wikipedia will set persistent cookies (for 1 year). Persistent cookies seem to be correctly synced.
Expected behavior:
On iOS and Android, alert displays
URL is [${response.url} ](https://en.m.wikipedia.org/wiki/Special:Notification)
 => Connexion successful

Screenshots/Videos:

Environment:

OS: iOS
OS version: 14+
react-native version: 0.74
react-native-webview version: 13.10.2

Hi,
I did some digging, in RNCWebViewImpl.m, line 1832
      [self syncCookiesToWebView:^{
        [wkWebViewConfig.websiteDataStore.httpCookieStore addObserver:self];
      }];

Completion Handler seems to never be called. Thus the observer is not set and synchronisation not done. This is due to setCookie completionHandler not called in syncCookiesToWebview function when called here. Don't know why...
I tried to add the addObserver outside the completionHandler
      [self syncCookiesToWebView:^{
        [wkWebViewConfig.websiteDataStore.httpCookieStore addObserver:self];
      }];
      [wkWebViewConfig.websiteDataStore.httpCookieStore addObserver:self];

The synchronization seems to work fine

Any idea?

I found something. The function syncCookiesToWebView is called two times

Line 1832 : here the completionHandler will add the observer to sync cookies from webview to sharedHTTPCookieStorage. It's broken because completionHandler is never called
Line 838 : here we write cookies to webview before loading request

For obscure reasons, on the second call to syncCookiesToWebView the completionHandler is correctly called. Otherwise we wouldn't even load anything in the webview.
This behaviour seems very similar to this reported bug https://developer.apple.com/forums/thread/99674 . It has not been fixed. The described workarounds did nothing here.
But if we connect the observer for cookie changed on the second call to syncCookiesToWebView it fixes the bug. All works fine.
I will provide a PR with this patch

Hi, this is a blocking issue for us. Will the PR be viewed by someone?

Same problem, fixed by this fix https://github.com/react-native-webview/react-native-webview/pull/3470
thanks !

Hi! The problem still persists on iOS. I've tried adding a session cookie in the request header from the new version (13.10.6) of the webview with the parameters sharedCookiesEnabled={true} and thirdPartyCookiesEnabled={true}. And it keeps returning me to the login screen. Any ideas? How can I configure the webview so that I can navigate freely with the session cookie set in the header?

Currently I have it like this:
const dataReq = {
uri: https://mydomain/${currentURI},
headers: {
Cookie: cookie, //cookie extracted from CookieManager
}

This issue was for the synchronization of cookies from WebView (cookies set by web content) to native. For your case I would set the cookie in native via react-native-cookies library. It should be synchronized in webview at launch.

I can confirm that the new release also fixed problems with cookies that I had on iOS using version 13.8.4 of WebView. Thanks @jccazeaux


Plugin issue with multiple panels

This PR aims to solve an issue I encountered with this plugin with a mutli-panel Filament application.
Debug report: https://flareapp.io/share/x5M4dJX7
The plugin would check if it was enabled during registerRenderHooks however, it end up globally attempting to render@livewire('menu-logins') even for panels where the plugin was not added.
I had to register an additional panel inside the test MenuLoginsTest. Let me know if you would rather a separate test case file for this issue.

Thank you very much for your contribution!


Add lfence on jumps to macro implementations

Hi!
Here are lfences for jumps to macros. Please double checks the offset at line 262 (in the new code).
Thanks!
Flavien

Because of the lag behind the dev branch, I've moved this PR into a separate commit (9ce990f). The issue is now fixed in 1.3-dev, and will be merged into main with the next release


Typed dataclass source instead of tuple

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 11 (0.0%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 5.917%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

swimprotocol/transport.py
0
1
0.0%

swimprotocol/worker.py
0
1
0.0%

swimprotocol/members.py
0
3
0.0%

swimprotocol/packet.py
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

swimprotocol/packet.py
1
0%

Totals

Change from base Build 845647246:
-0.03%

Covered Lines:
60

Relevant Lines:
1014

💛  - Coveralls


Updating README

This cookbooks README is failing to inform about new functionality that has been added. We probably should update it a bit.

I'm about to do a release and will update the README as part of the release.  Thanks for the heads up!

Readme updated: https://github.com/rayrod2030/chef-prometheus/commit/305db97ef1f741c9f8df736d39897a1261ad5dae

Alright, that's great!


Cliff Hanger

There's enough in revision control to play the game now, if you don't care if it's not faithful to the original arcade experience.
But there's a lot to do, partially because Cliff Hanger has needs Dragon's Lair doesn't, and partially because it's the second game, so several things are going to become more generic to handle multiple games, not specifically for this game.

[x] #7
[x] Move games/*.lua to games/*/game.lua
[x] Make games/cliff/icon.bmp
[x] Make games/cliff/sprites.bmp with a sprite atlas.
[x] Add a way to upload texture atlases to the platform code.
[x] Add a way to blit from the atlas to the screen, on top of the laserdisc video.
[x] Add a way to clear the screen to a specific color, overriding laserdisc video.
[x] Add a way to draw unfilled rectangles (Cliff Hanger needs this, specifically).
[x] Have the game specify all its draws during its tick processing.
[x] Implement drawing in SDL target.
[x] Implement drawing in libretro target.
[x] Implement scoring.
[x] Implement the Cliff Hanger in-game HUD
[x] Implement the hints UI that tells you what move to press when it's time.
[x] Implement the failure/success UI
[x] Implement the continue UI
[x] Implement the game over because you lost UI
[x] Implement the game over because you won UI
[x] Implement the title screen
[x] Implement the credits screen
[x] Implement the high score screen
[ ] Should we save high scores?

...probably other things.

Maybe let's not make this texture atlases but just loose .bmp files. It's not like there are many of them.

In the ROMs, Cliff Hanger's rectangles are just glyphs, like one might draw with ASCII chars, not special line drawing code.

Made a ton of progress on this, but I have to write the libretro implementation of all the new drawing stuff before I commit this stuff or it'll break.

Pushed a bunch of work on this. libretro target needs better image scaling code, but it's usable for now.

I'm probably not going to implement the actual high score entering UI for now, and just leave the high score list as the cabinet's default. It can be added later, but I'll declare this work done before then.

Screw it, UI for entering your initials is in. We don't save the high scores anywhere atm, so they reset when you quit the game, but oh well.
I declare Cliff Hanger done!


Uncrafting Table crashing 1.20.1 Fabric

MC 1.20.1 + Fabric 0.14.24
Mods:

architectury-9.1.12-fabric.jar
cloth-config-11.1.106-fabric.jar
fabric-api-0.90.7+1.20.1.jar
RoughlyEnoughItems-12.0.674.jar
mcpitanlibarch-1.8.1-1.20.1-fabric.jar
UncraftingTable-fabric-1.2.8.jar

Crash when click on UncraftingTable interface buttons.

Versions -

mcpitanlibarch-1.7.8-1.20.1-fabric.jar
UncraftingTable-fabric-1.2.6.jar

everything OK

Crash report
crash-2023-11-08_15.04.47-client.txt

mcpitanlibarch-1.8.2-1.20.1-fabric.jar
UncraftingTable-fabric-1.2.8.jar
Same issue.

mcpitanlibarch-1.8.2-1.19.2-forge
UncraftingTable-forge-1.2.8
same for me

mcpitanlibarch-1.8.3-1.20.1-fabric
UncraftingTable-fabric-1.2.8
Same issue.

Does the same on forge
UncraftingTable-forge-1.2.8
mcpitanlibarch-1.8.2-1.20.1-forge
latest.log
crash-2023-11-26_16.17.47-client.txt

mcpitanlibarch-1.8.4-1.20.1-fabric
UncraftingTable-fabric-1.2.8
Same issue.

i am having the same issue on forge playing minecraft version 1.19.2:
forge 43.3.0
architectury-6.5.85-forge
mcpitanlibarch-1.8.3-1.19.2-forge
UncraftingTable-forge-1.2.8
the full crash report is here:
crash-2023-11-28_18.53.53-client.txt
java.lang.NoSuchMethodError: 'net.minecraft.network.FriendlyByteBuf net.minecraft.network.FriendlyByteBuf.m_130079_(net.minecraft.nbt.Tag)' 	at ml.pkom.uncraftingtable.UncraftingScreen.lambda$initOverride$1(UncraftingScreen.java:75) ~[UncraftingTable-forge-1.2.8.jar%23146!/:?] {re:classloading}
is the significant part for me
given it's showing up on both forge and fabric under the same circumstances i think it's reasonable to include it here for context / further data

mcpitanlibarch-1.8.4-1.19.2-forge
UncraftingTable-forge-1.2.9
all good, this can closed now

thank you for your reporting!


CommandSpec: Tab-completion for subcommand arguments

EDITED
Not sure if this is a bug or a feature request. (Also, I think this is the correct place to file this. Please forgive me if that's incorrect.)
The issue I'm having is the automatic tab-completion that is done when using the CommandSpec API. In my setup, I have a top level command that has three subcommands. The tab completion works for filling in the three subcommands as expected:

However, I'd like to set the arguments for subcommands. When I use the .setArguments() on a child CommandSpec, it seems to always just repeat the selected subcommand:

This happens both for when I set the subcommand to accept no arguments using 'none()', and also with the 'choices()' call I'd like to use to autocomplete the available options.
EDIT: So actually, the completion DOES work for the subcommands if you start typing a valid option. So, I think the bug is that it completes the subcommand name when you don't type anything. The expected behavior would be to show the comma separated list of available completions and cycle through them on further Tab presses.
Here's the simplified code I'm using to build the commands:
		HashMap<String, String> test = new HashMap<String, String>();
		test.put("moduleA", "moduleA");
		test.put("moduleB", "moduleB");

		this.subCommands.put(Arrays.asList("list"), CommandSpec.builder()
				.setDescription(Texts.of("List status of modules"))
				.setArguments(none())
				.setExecutor(new ListSubcommand())
				.build());

		this.subCommands.put(Arrays.asList("enable"), CommandSpec.builder()
				.setDescription(Texts.of("Enable specified module"))
				.setArguments(seq(choices(Texts.of("moduleName"), test)))
				.setExecutor(new EnableSubcommand())
				.build());

		this.subCommands.put(Arrays.asList("disable"), CommandSpec.builder()
				.setDescription(Texts.of("Disable specified module"))
				.setArguments(seq(choices(Texts.of("moduleName"), test)))
				.setExecutor(new DisableSubcommand())
				.build());

		this.cmdSpec = CommandSpec.builder()
				.setDescription(Texts.of("Manage modules"))
				.setExtendedDescription(Texts.of("List, enable/disable modules"))
				.setChildren(this.subCommands)
				.build();

System details:
Forge: <IP_ADDRESS>7
Sponge: 1.8-1371-2.1DEV-433
Java: 1.8.0_20
I just switched to the latest dev build of Sponge to make sure the behavior was still present.

Or, if there are too many options to suggest (such as listing online players, or a lot of keys in a choices map), can we print a message saying there are too many options and more context is needed?

To add on to this, when using the Cookbook example "WorldsTest" command /tpworld, the first parameter (a player) is correctly entered using tab complete however when tab is pressed again it switches to the next parameter (a world). It does this because the first argument has been correctly entered (player name) however we should only cycle the next parameter set (world list) if there is a space on the end of the tab list string. I probably didn't explain that too well, so here's an example:
/tpworld  would give you a tab completion list of all players on the server. Perfect.
/tpworld GenericPlayer would switch tab completion list to all currently loaded worlds, which is not what we want to do. Although we have entered a parameter, if we press tab here we want to cycle the list of players, not the next parameter set- all currently loaded worlds.
/tpworld GenericPlayer  would, as it should be, cycle all worlds.

@verbeto So you mean "/tpworld GenericPlayer" vs. "/tpworld GenericPlayer "

Somehow my [press tab here] parts decided to be removed, but it's fixed now.
@boformer

@zml2008 Can this be fixed soon?

Ok, the issue here seems to be an ambiguity in what having another argument means. Currently, the argument parsing code trims spaces off of the ends of commands, which means that a user wanting to complete their current argument and a user wanting completions for the beginning of the next argument both appear the same to the commands system. I need to think about how to expose this to the argument parsing code. Maybe adding a hasTrailingSpace() method to CommandArguments, or an empty last argument? neither seem super great to me

Empty last argument seems to be most logical?
Spaces delimit arguments, and there is a space at the end, but does this screw with the parsing at all?

Well, in a lot of argument parsers empty arguments are stripped -- so unless the spaces are explicitly escaped one space is the same as 50 to the final argument parser. However, the end of the string is kind of a special case :/

Seeing that this issue is quite old, can anyone re-test this issue to see if it's still an issue?

@gabizou @zml2008 : I've confirmed this on the latest SpongeForge.

Anything like the hasTrailingSpace() method would also be needed in the TabCompleteCommandEvent to detect the space between getCommand() and getArguments().
See this forum post.

No, that would be the difference between getArguments being {""} and {} (1-element array of empty string vs 0-element array) -- which shouldn't be difficult to implement (besides String.split being dumb)

@zml2008 Am i missing something? As far as i see getArguments() currently returns all arguments in one String on this event and not an Array?

hm, then might have to make it an Optional


Trees: Support branch methods

Currently, the code hardcodes exactly three methods (value, name and tpe) which can be declared in a @branch trait.
This is an attempt to support other methods as well, although it still is not flexible enough to support methods in a branch which is a parent of another branch.
Required for #2207 to work.

@tgodzik you were right about the rabbit hole, but this looks to work. if we merge this, i also have an adjusted version of your #2207 submission (although i am not clear how to share that with you).
as usual, it might be easier to review my code one commit at a time, rather than all at once. they are all individually packaged :)

@tgodzik you were right about the rabbit hole, but this looks to work. if we merge this, i also have an adjusted version of your #2207 submission (although i am not clear how to share that with you).
as usual, it might be easier to review my code one commit at a time, rather than all at once. they are all individually packaged :)


row.delete() not deleting row, instead is just formatting row

I am attempting to delete a row from my sheet entirely using the index from sheet.getRows(), instead of just clearing the values and clearing colour format. A little information: I am not using a form, instead, I am using a Discord bot to get responses from users, and posting their responses to the sheet using this library. I need the row to be deleted entirely as for this remove function, you are able to remove any rows, even ones with values on both sides of them.
Here is my code, please tell me if I have made a mistake, I have gone over all the documentation already, in attempt to check if I have missed another method I could use instead.

What I get after the function is run:

vs what I need: (The last row being deleted entirely)

The cell-based methods and row-based methods are not really designed to be used together.
If you stick with row-based method calls, it should do the trick.
If you absolutely need to interact the the cell based methods (for example to deal with formatting) then after you delete the row, you must reload the cell data.

The cell-based methods and row-based methods are not really designed to be used together.
If you stick with row-based method calls, it should do the trick.
If you absolutely need to interact the the cell based methods (for example to deal with formatting) then after you delete the row, you must reload the cell data.

Apologies for the delay in response, but how would I reload the cell data
correctly?
On Wed, Jan 20, 2021 at 2:47 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

The cell-based methods and row-based methods are not really designed to be
used together.
If you stick with row-based method calls, it should do the trick.
If you absolutely need to interact the the cell based methods (for example
to deal with formatting) then after you delete the row, you must reload the
cell data.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-763246400,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXTNW2J4XHGWFAOZESTS2YRYRANCNFSM4V4VOCHA
.

Apologies for the delay in response, but how would I reload the cell data
correctly?
On Wed, Jan 20, 2021 at 2:47 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

The cell-based methods and row-based methods are not really designed to be
used together.
If you stick with row-based method calls, it should do the trick.
If you absolutely need to interact the the cell based methods (for example
to deal with formatting) then after you delete the row, you must reload the
cell data.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-763246400,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXTNW2J4XHGWFAOZESTS2YRYRANCNFSM4V4VOCHA
.

So when you call sheet.loadCells, it loads a range of cells into a cache.
Using the row-based API doesn't use or affect that cache - so if the rows have the data you need, you wouldnt even need to load the cells at all.
But if you do really need the cells, you can reload them by calling loadCells again, or potentially calling sheet.resetLocalCache() which would clear out that cache completely and then call loadcells again.

So when you call sheet.loadCells, it loads a range of cells into a cache.
Using the row-based API doesn't use or affect that cache - so if the rows have the data you need, you wouldnt even need to load the cells at all.
But if you do really need the cells, you can reload them by calling loadCells again, or potentially calling sheet.resetLocalCache() which would clear out that cache completely and then call loadcells again.

So basically, after I delete a row, I should reset the cache and then load
the cells to do certain things?
On Tue, Jan 26, 2021 at 7:06 PM Theo Ephraim<EMAIL_ADDRESS>wrote:

So when you call sheet.loadCells, it loads a range of cells into a cache.
Using the row-based API doesn't use or affect that cache - so if the rows
have the data you need, you wouldnt even need to load the cells at all.
But if you do really need the cells, you can reload them by calling
loadCells again, or potentially calling sheet.resetLocalCache()
https://theoephraim.github.io/node-google-spreadsheet/#/classes/google-spreadsheet-worksheet?id=fn-resetlocalcache
which would clear out that cache completely and then call loadcells again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-767687500,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXTOXTJIMMTWRAS7AJDS33ZDDANCNFSM4V4VOCHA
.

So basically, after I delete a row, I should reset the cache and then load
the cells to do certain things?
On Tue, Jan 26, 2021 at 7:06 PM Theo Ephraim<EMAIL_ADDRESS>wrote:

So when you call sheet.loadCells, it loads a range of cells into a cache.
Using the row-based API doesn't use or affect that cache - so if the rows
have the data you need, you wouldnt even need to load the cells at all.
But if you do really need the cells, you can reload them by calling
loadCells again, or potentially calling sheet.resetLocalCache()
https://theoephraim.github.io/node-google-spreadsheet/#/classes/google-spreadsheet-worksheet?id=fn-resetlocalcache
which would clear out that cache completely and then call loadcells again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-767687500,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXTOXTJIMMTWRAS7AJDS33ZDDANCNFSM4V4VOCHA
.

I'm using the cell-based method to load the values of specific cells so I
can loop through them to see which one has, let's say, got the formula of
'= 1+1', and if it has that formula, I push it to an array.
Here is the code:
[image: image.png]
On Tue, Jan 26, 2021 at 8:01 PM Theo Ephraim<EMAIL_ADDRESS>wrote:

What are you doing with the data? You may be able to just use the
row-based methods and avoid cells altogether.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-767722347,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXXIQ6RXB3PB4EJJDMDS337PPANCNFSM4V4VOCHA
.

I'm using the cell-based method to load the values of specific cells so I
can loop through them to see which one has, let's say, got the formula of
'= 1+1', and if it has that formula, I push it to an array.
Here is the code:
[image: image.png]
On Tue, Jan 26, 2021 at 8:01 PM Theo Ephraim<EMAIL_ADDRESS>wrote:

What are you doing with the data? You may be able to just use the
row-based methods and avoid cells altogether.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-767722347,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXXIQ6RXB3PB4EJJDMDS337PPANCNFSM4V4VOCHA
.

I tried using what you said to me, or at least what I understood, and
weirdly enough, it still doesn't delete the row properly and instead just
formats it...
[image: image.png]
On Wed, Jan 27, 2021 at 11:34 AM Beta<EMAIL_ADDRESS>wrote:

I'm using the cell-based method to load the values of specific cells so I
can loop through them to see which one has, let's say, got the formula of
'= 1+1', and if it has that formula, I push it to an array.
Here is the code:
[image: image.png]
On Tue, Jan 26, 2021 at 8:01 PM Theo Ephraim<EMAIL_ADDRESS>wrote:

What are you doing with the data? You may be able to just use the
row-based methods and avoid cells altogether.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-767722347,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXXIQ6RXB3PB4EJJDMDS337PPANCNFSM4V4VOCHA
.

I tried using what you said to me, or at least what I understood, and
weirdly enough, it still doesn't delete the row properly and instead just
formats it...
[image: image.png]
On Wed, Jan 27, 2021 at 11:34 AM Beta<EMAIL_ADDRESS>wrote:

I'm using the cell-based method to load the values of specific cells so I
can loop through them to see which one has, let's say, got the formula of
'= 1+1', and if it has that formula, I push it to an array.
Here is the code:
[image: image.png]
On Tue, Jan 26, 2021 at 8:01 PM Theo Ephraim<EMAIL_ADDRESS>wrote:

What are you doing with the data? You may be able to just use the
row-based methods and avoid cells altogether.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-767722347,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXXIQ6RXB3PB4EJJDMDS337PPANCNFSM4V4VOCHA
.

What happens if you dont call any cell-based methods, just load rows, and then delete one?

What happens if you dont call any cell-based methods, just load rows, and then delete one?

It still didn't delete the row entirely, here is the updated code.
[image: image.png]
On Thu, Jan 28, 2021 at 12:08 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

What happens if you dont call any cell-based methods, just load rows, and
then delete one?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-768610974,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXUEEV4WK2GL3SSWMJLS4CFFPANCNFSM4V4VOCHA
.

It still didn't delete the row entirely, here is the updated code.
[image: image.png]
On Thu, Jan 28, 2021 at 12:08 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

What happens if you dont call any cell-based methods, just load rows, and
then delete one?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-768610974,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXUEEV4WK2GL3SSWMJLS4CFFPANCNFSM4V4VOCHA
.

Not sure why, but your images aren't coming through :(

Not sure why, but your images aren't coming through :(

That's weird-
Here's links for them:
1st: https://i.imgur.com/Ssaw29V.png
2nd: https://i.imgur.com/Csin2QC.png
3rd: https://i.imgur.com/ft9CQ0h.png
On Thu, Jan 28, 2021 at 12:52 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

Not sure why, but your images aren't coming through :(
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-768631528,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXWHIHEMQPECXPSRQV3S4CKMLANCNFSM4V4VOCHA
.

That's weird-
Here's links for them:
1st: https://i.imgur.com/Ssaw29V.png
2nd: https://i.imgur.com/Csin2QC.png
3rd: https://i.imgur.com/ft9CQ0h.png
On Thu, Jan 28, 2021 at 12:52 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

Not sure why, but your images aren't coming through :(
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-768631528,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXWHIHEMQPECXPSRQV3S4CKMLANCNFSM4V4VOCHA
.

Generally just one tip - if you set the first row in your sheet with meaningful headers ("userid", "username", "reason", "staff"), then when youre reading rows you get properties with those names (ex: row.userid)
To be honest, I'm really not sure what is going on. I just wrote a simple example to load rows and delete one and I do see it being removed completely. Are you sure there aren't some concurrent requests happening at the same time?
Also I'm not sure why youre calling loadInfo right before the delete - although it shouldn't affect anything.

Generally just one tip - if you set the first row in your sheet with meaningful headers ("userid", "username", "reason", "staff"), then when youre reading rows you get properties with those names (ex: row.userid)
To be honest, I'm really not sure what is going on. I just wrote a simple example to load rows and delete one and I do see it being removed completely. Are you sure there aren't some concurrent requests happening at the same time?
Also I'm not sure why youre calling loadInfo right before the delete - although it shouldn't affect anything.

That's interesting as mine doesn't-
I am 100% sure that there aren't concurrent requests occurring at the same
time.
I will try something tomorrow to see if it does, by chance, work then,
although I highly doubt it will with my luck :(
Also, I added that as after loading the cells and getting what I required
from them and resetting the cache, I had to call loadInfo again after doing
that, in order to get the rows in the doc.
On Thu, Jan 28, 2021 at 1:50 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

Generally just one tip - if you set the first row in your sheet with
meaningful headers ("userid", "username", "reason", "staff"), then when
youre reading rows you get properties with those names (ex: row.userid)
To be honest, I'm really not sure what is going on. I just wrote a simple
example to load rows and delete one and I do see it being removed
completely. Are you sure there aren't some concurrent requests happening at
the same time?
Also I'm not sure why youre calling loadInfo right before the delete -
although it shouldn't affect anything.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-768654717,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXUO5LCPPV7PCKNVI5LS4CRD7ANCNFSM4V4VOCHA
.

That's interesting as mine doesn't-
I am 100% sure that there aren't concurrent requests occurring at the same
time.
I will try something tomorrow to see if it does, by chance, work then,
although I highly doubt it will with my luck :(
Also, I added that as after loading the cells and getting what I required
from them and resetting the cache, I had to call loadInfo again after doing
that, in order to get the rows in the doc.
On Thu, Jan 28, 2021 at 1:50 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

Generally just one tip - if you set the first row in your sheet with
meaningful headers ("userid", "username", "reason", "staff"), then when
youre reading rows you get properties with those names (ex: row.userid)
To be honest, I'm really not sure what is going on. I just wrote a simple
example to load rows and delete one and I do see it being removed
completely. Are you sure there aren't some concurrent requests happening at
the same time?
Also I'm not sure why youre calling loadInfo right before the delete -
although it shouldn't affect anything.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-768654717,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXUO5LCPPV7PCKNVI5LS4CRD7ANCNFSM4V4VOCHA
.

One thing I do feel the need to ask you is if there are multiple requests
at once, but all are to do actions of different spreadsheets, would it be
able to do this, or not? This is a requirement for me, so I am really
hoping it's a yes..
On Thu, Jan 28, 2021 at 2:15 AM Beta<EMAIL_ADDRESS>wrote:

That's interesting as mine doesn't-
I am 100% sure that there aren't concurrent requests occurring at the same
time.
I will try something tomorrow to see if it does, by chance, work then,
although I highly doubt it will with my luck :(
Also, I added that as after loading the cells and getting what I required
from them and resetting the cache, I had to call loadInfo again after doing
that, in order to get the rows in the doc.
On Thu, Jan 28, 2021 at 1:50 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

Generally just one tip - if you set the first row in your sheet with
meaningful headers ("userid", "username", "reason", "staff"), then when
youre reading rows you get properties with those names (ex: row.userid)
To be honest, I'm really not sure what is going on. I just wrote a simple
example to load rows and delete one and I do see it being removed
completely. Are you sure there aren't some concurrent requests happening at
the same time?
Also I'm not sure why youre calling loadInfo right before the delete -
although it shouldn't affect anything.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-768654717,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXUO5LCPPV7PCKNVI5LS4CRD7ANCNFSM4V4VOCHA
.

One thing I do feel the need to ask you is if there are multiple requests
at once, but all are to do actions of different spreadsheets, would it be
able to do this, or not? This is a requirement for me, so I am really
hoping it's a yes..
On Thu, Jan 28, 2021 at 2:15 AM Beta<EMAIL_ADDRESS>wrote:

That's interesting as mine doesn't-
I am 100% sure that there aren't concurrent requests occurring at the same
time.
I will try something tomorrow to see if it does, by chance, work then,
although I highly doubt it will with my luck :(
Also, I added that as after loading the cells and getting what I required
from them and resetting the cache, I had to call loadInfo again after doing
that, in order to get the rows in the doc.
On Thu, Jan 28, 2021 at 1:50 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

Generally just one tip - if you set the first row in your sheet with
meaningful headers ("userid", "username", "reason", "staff"), then when
youre reading rows you get properties with those names (ex: row.userid)
To be honest, I'm really not sure what is going on. I just wrote a simple
example to load rows and delete one and I do see it being removed
completely. Are you sure there aren't some concurrent requests happening at
the same time?
Also I'm not sure why youre calling loadInfo right before the delete -
although it shouldn't affect anything.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-768654717,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXUO5LCPPV7PCKNVI5LS4CRD7ANCNFSM4V4VOCHA
.

Very odd. You can see that the row delete call internally is calling deleteRange

see https://github.com/theoephraim/node-google-spreadsheet/blob/master/lib/GoogleSpreadsheetRow.js#L55
see https://developers.google.com/sheets/api/reference/rest/v4/spreadsheets/request#deleterangerequest

You could try calling that directly to the google API and see what happens.
I'm also curious what would happen if calling deleteDimension instead - although deleting a "range" that is a full row I'd think should should be equivalent to deleting a "dimension".
As for making concurrent requests, if they are on different sheets, no problem. If they are on the same sheets, I dont think there's anything stopping you but it could cause issues, as your local cache of the sheet data can get out of sync with the remote version.
Generally the handling of row deletion needs work, as right now I dont think the row number of the other loaded rows gets updated. Should be relatively easy to fix that though.
When working with cells it can get tricky because we can't always infer what google's reply will be. For example when updating a formula, we dont know what the value will be.

Very odd. You can see that the row delete call internally is calling deleteRange

see https://github.com/theoephraim/node-google-spreadsheet/blob/master/lib/GoogleSpreadsheetRow.js#L55
see https://developers.google.com/sheets/api/reference/rest/v4/spreadsheets/request#deleterangerequest

You could try calling that directly to the google API and see what happens.
I'm also curious what would happen if calling deleteDimension instead - although deleting a "range" that is a full row I'd think should should be equivalent to deleting a "dimension".
As for making concurrent requests, if they are on different sheets, no problem. If they are on the same sheets, I dont think there's anything stopping you but it could cause issues, as your local cache of the sheet data can get out of sync with the remote version.
Generally the handling of row deletion needs work, as right now I dont think the row number of the other loaded rows gets updated. Should be relatively easy to fix that though.
When working with cells it can get tricky because we can't always infer what google's reply will be. For example when updating a formula, we dont know what the value will be.

One thing - if you want to give me access to the doc (or a copy of it with any sensitive info removed) I can take a look?
share with<EMAIL_ADDRESS>

One thing - if you want to give me access to the doc (or a copy of it with any sensitive info removed) I can take a look?
share with<EMAIL_ADDRESS>

Alright, much obliged, I'll look into calling the google API in a bit!
As for giving you access, I have given you access to a sheet called "Copy
of Initial Backend (Do not share)"
On Thu, Jan 28, 2021 at 2:25 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

Very odd. You can see that the row delete call internally is calling
deleteRange

see
https://github.com/theoephraim/node-google-spreadsheet/blob/master/lib/GoogleSpreadsheetRow.js#L55
see
https://developers.google.com/sheets/api/reference/rest/v4/spreadsheets/request#deleterangerequest

You could try calling that directly to the google API and see what happens.
I'm also curious what would happen if calling deleteDimension instead -
although deleting a "range" that is a full row I'd think should should be
equivalent to deleting a "dimension".
As for making concurrent requests, if they are on different sheets, no
problem. If they are on the same sheets, I dont think there's anything
stopping you but it could cause issues, as your local cache of the sheet
data can get out of sync with the remote version.
Generally the handling of row deletion needs work, as right now I dont
think the row number of the other loaded rows gets updated. Should be
relatively easy to fix that though.
When working with cells it can get tricky because we can't always infer
what google's reply will be. For example when updating a formula, we dont
know what the value will be.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-768667932,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXW3FCNSI3PB4PE25YLS4CVHNANCNFSM4V4VOCHA
.

Alright, much obliged, I'll look into calling the google API in a bit!
As for giving you access, I have given you access to a sheet called "Copy
of Initial Backend (Do not share)"
On Thu, Jan 28, 2021 at 2:25 AM Theo Ephraim<EMAIL_ADDRESS>wrote:

Very odd. You can see that the row delete call internally is calling
deleteRange

see
https://github.com/theoephraim/node-google-spreadsheet/blob/master/lib/GoogleSpreadsheetRow.js#L55
see
https://developers.google.com/sheets/api/reference/rest/v4/spreadsheets/request#deleterangerequest

You could try calling that directly to the google API and see what happens.
I'm also curious what would happen if calling deleteDimension instead -
although deleting a "range" that is a full row I'd think should should be
equivalent to deleting a "dimension".
As for making concurrent requests, if they are on different sheets, no
problem. If they are on the same sheets, I dont think there's anything
stopping you but it could cause issues, as your local cache of the sheet
data can get out of sync with the remote version.
Generally the handling of row deletion needs work, as right now I dont
think the row number of the other loaded rows gets updated. Should be
relatively easy to fix that though.
When working with cells it can get tricky because we can't always infer
what google's reply will be. For example when updating a formula, we dont
know what the value will be.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/430#issuecomment-768667932,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLKKXW3FCNSI3PB4PE25YLS4CVHNANCNFSM4V4VOCHA
.

Closing for now - please reopen if you are still stuck!


Partial hack for issue #73

It is working for basic cases I tested on (for example, when validator finds violations on the properties from the shape, which the start shape is extending, and stops there), but is probably not enough in general.

Hi @Gnomus042 , could you look at the 20 validation errors in Travis?

1literalPlus_Is1_Ip1_La,Io1
1dotRef1_overReferrer
1dotInline1_overReferrer
1val1IRIREF_v1v2
NOT1NOTvs_passIv1
...

Hi @ericprud! I've resolved all failing tests :)


Fix #117

Merge #155 and #156 first. This adds the commit for fix of #117.

Coverage decreased (-1.7%) to 76.27% when pulling 945fa920fbe8b21bd4683f06886ddc73273b728d on sorpaas:fix-117 into 62c666799bddde409a407bb6671fdb980e9a4a1a on ethereumproject:master.

Coverage decreased (-1.7%) to 76.27% when pulling 945fa920fbe8b21bd4683f06886ddc73273b728d on sorpaas:fix-117 into 62c666799bddde409a407bb6671fdb980e9a4a1a on ethereumproject:master.

Coverage decreased (-1.7%) to 76.27% when pulling 945fa920fbe8b21bd4683f06886ddc73273b728d on sorpaas:fix-117 into 62c666799bddde409a407bb6671fdb980e9a4a1a on ethereumproject:master.


has_add_permission() takes exactly 2 arguments (3 given)

I keep getting this error.
TypeError at /admin/resources/weblink/

has_add_permission() takes exactly 2 arguments (3 given)

Request Method:     GET
Request URL:    http://localhost:8000/admin/resources/weblink/
Django Version:     1.6.10
Exception Type:     TypeError
Exception Value:

has_add_permission() takes exactly 2 arguments (3 given)

Exception Location:     /Users/neo/projects/project_name/env/lib/python2.7/site-packages/feincms/admin/tree_editor.py in get_results, line 206
Python Executable:  /Users/neo/projects/project_name/env/bin/python
Python Version:     2.7.5
Python Path:

['/Users/neo/projects/project_name',
 '/Users/neo/projects/project_name/env/lib/python27.zip',
 '/Users/neo/projects/project_name/env/lib/python2.7',
 '/Users/neo/projects/project_name/env/lib/python2.7/plat-darwin',
 '/Users/neo/projects/project_name/env/lib/python2.7/plat-mac',
 '/Users/neo/projects/project_name/env/lib/python2.7/plat-mac/lib-scriptpackages',
 '/Users/neo/projects/project_name/env/lib/python2.7/lib-tk',
 '/Users/neo/projects/project_name/env/lib/python2.7/lib-old',
 '/Users/neo/projects/project_name/env/lib/python2.7/lib-dynload',
 '/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7',
 '/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/plat-darwin',
 '/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib-tk',
 '/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/plat-mac',
 '/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/plat-mac/lib-scriptpackages',
 '/Users/neo/projects/project_name/env/lib/python2.7/site-packages']

Server time:    Mon, 28 Sep 2015 11:50:32 +0200

Sorry, that was because of confusion between default django behavior and feincms one.

Out of interest, which version of FeinCMS did you use?

I am using 1.10.1 - I guess this is same behavior in older versions too.


Upgrading @tinacms/cli from 0.59.0 -> 0.60.0 breaks language props for custom Code component in rich-text

Description
When upgrading @tinacms/cli from 0.59.0 -> 0.60.0 , the syntax highlighting with react-prism-renderer seems to break. It seems to apply the
Steps to reproduce

git clone git@github.com:c-kirkeby/portfolio-next.git tinacms-language-bug
cd tinacms-language-bug
git checkout 5adcb80620af26cd5e435ced097c6f65fc689697
npm install
npm install<EMAIL_ADDRESS>npm run dev
Navigate to http://localhost:3000/blog/syntax-highlighting
At this point, a language prop of typescript gets passed to the custom Code component defined in my custom TinaMarkdown wrapper component.
Stop the dev server and run `npm install<EMAIL_ADDRESS>Start the dev server back up npm run dev
Repeat step 7.
At this point the language prop gets passed as undefined.

I originally had this issue with the latest versions of tinacms and @tinacms/cli; I just went ahead and determined when the breaking change was introduced.
Expected result
Since I've defined the language field on the Code template, I would expect that it gets passed like it does in 0.59.0.
Actual result
It seems the pre-0.60.0 isn't passing the right language field.
Environment
Tinacms Package Versions
tinacms 0.64.2
@tinacms/cli 0.60.0

Tools

Tool
Version

browser
Firefox 96.0 (64-bit)

os
Zorin OS 16 (Ubuntu)

node
16.13.2

npm
8.13

@c-kirkeby I think that the types might have been off in our Markdown renderer component (believe it is fixed now in latest version).  Can you try using props.lang instead?


Milestone 1: Article (Background)

Explanation of the components and logic of a federation.
References to similar work that has been developed and that we use for inspiration.

See https://github.com/federatedbookkeeping/research/blob/main/Article/Article.pdf and https://github.com/pondersource/CYB/tree/main/Manuel_file_dump


Staff-visible audit log for application history

It would be useful if the WHC staff could also see the log of all application activity. This exists in the audit log of the app, but there's currently no interface for it.

This was supposed to be the history log in the ACL view, but it's badly buggy.


.btn-file hover supersedes other btn classes

.btn-file does not work well in conjunction with other btn color classes.

I don't think btn-file intent was to effect the other classes since there is only 1 style for file buttons (it used to be but it was removed)  can you check with UX?

I figured it wasn't the intent, so the fix is already merged in. I referenced the issue in the pull request, but forgot to close out the issue.


[NUMBERS-109] - Cleanup pom files

Coverage remained the same at 92.8% when pulling 4544f88c82831d948509e32eb453b7e83ca54ebe on khmarbaise:NUMBERS-109 into 7e5a4b9c83363ee5f9caddd2dc19f11d25ffd560 on apache:master.


data grid should not clone items collection before projection

this causes problems if the items collection is more complex than a data bag, and serious problems if the item types are complex types with inherited read only property getters.

this may cause problems because the hierarchical filtering is altering the projected items collection, so we need to clone it to keep the original untouched.

my thought is that items collections should not be limited to data bags, so performing the clone as is must be altered. We could do some basic heuristics to check if the first item in the list is an object and refuse cloning at that point.

the final answer is that items collections should be aware that they will be cloned and must support this behavior. this means avoiding property getters and using functions instead.


Add initial implementation of the ActiveSpansExporter.

Looks like this implementation gives a breakdown of spans by name and also
a way to query them. Notably, these are in-flight spans.
The "active span" here is different than another library which uses active
to indicate it the current implicit span in context. There's no strict
relationship to that here. Eventhough no need to be vocab parity with
others seems in-flight or running would work (start run end!). Just
thoughts not important ones.

Codecov Report

Merging #356 into master will increase coverage by 0.8%.
The diff coverage is 93.22%.

@@             Coverage Diff             @@
##             master     #356     +/-   ##
===========================================
+ Coverage     88.96%   89.77%   +0.8%
- Complexity      545      566     +21
===========================================
  Files            93       94      +1
  Lines          2121     2171     +50
  Branches        163      174     +11
===========================================
+ Hits           1887     1949     +62
+ Misses          199      181     -18
- Partials         35       41      +6

Impacted Files
Coverage Δ
Complexity Δ

...pl/src/main/java/io/opencensus/trace/SpanImpl.java
97.45% <ø> (+4.45%)
45 <0> (+5)
:arrow_up:

...o/opencensus/trace/export/ExportComponentImpl.java
100% <100%> (ø)
4 <1> (ø)
:arrow_down:

...encensus/trace/export/ActiveSpansExporterImpl.java
100% <100%> (ø)
12 <12> (?)

...va/io/opencensus/trace/TraceComponentImplBase.java
93.75% <100%> (+1.44%)
5 <0> (ø)
:arrow_down:

.../java/io/opencensus/trace/StartEndHandlerImpl.java
86.66% <82.6%> (-13.34%)
7 <7> (+3)

...o/opencensus/trace/export/ActiveSpansExporter.java
81.81% <0%> (+81.81%)
1% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461b4ed...12949aa. Read the comment docs.

Other possible names (using in flight) are:

InFlightSpanStore
InFlightSpansExporter
InFlightSpanTracker

What do you prefer?

InFlightSpanStore

works best in my brain. We are tracking and querying and somehow this
seems to be ok for both!

I will do the change in a separate PR.

PTAL


Calico ebpf + wireguard packet drops

Current Behavior
Wireguard interface seems to be dropping packets:
 tc -s qdisc show dev wireguard.cali
qdisc noqueue 0: root refcnt 2
 Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
 backlog 0b 0p requeues 0
qdisc clsact ffff: parent ffff:fff1
 Sent<PHONE_NUMBER>3 bytes 3670344 pkt (dropped 1103, overlimits 0 requeues 0)
 backlog 0b 0p requeues 0

And I couldn't find much in bpf debug logs, but after putting them back to Info level noticed these kind of messages:
         kubelet-5448    [000] .... 43491.309127: 0: CALI-C: NAT miss.
 elasticsearch[e-16767   [000] .... 43513.076161: 0: CALI-C: NAT miss.

And calico-node.log logs just in case.
Possible Solution
Maybe disabling wireguard or disabling ebpf but that would require cluster redeployment which I hope to avoid.
Steps to Reproduce (for bugs)
Setup kops cluster with the following calico settings:
networking:
  calico:
    mtu: 8941
    encapsulationMode: vxlan
    crossSubnet: true
    awsSrcDstCheck: Disable
    bpfEnabled: true
    wireguardEnabled: true
    bpfLogLevel: Info

Or these:
networking:
  calico:
    mtu: 8941
    encapsulationMode: ipip
    crossSubnet: true
    awsSrcDstCheck: Disable
    bpfEnabled: true
    wireguardEnabled: true
    bpfLogLevel: Info

Context
We are running a platform where many components are talking to ElasticSearch and seeing intermittent disconnects all the time:

Two production clusters are affected right now as we haven't noticed the issue on time. Initial settings for calico ipPool:
spec:
    blockSize: 26
    cidr: <IP_ADDRESS>/11
    ipipMode: CrossSubnet
    natOutgoing: true
    nodeSelector: all()
    vxlanMode: Never

Yesterday tried changing to vxlan as this page suggests not to use IPIP mode, so one of the cluster has this Ippool setup but errors persist:
spec:
    blockSize: 26
    cidr: <IP_ADDRESS>/11
    ipipMode: Never
    natOutgoing: true
    nodeSelector: all()
    vxlanMode: CrossSubnet

Your Environment

Calico version:

calicoctl version
Client Version:    v3.17.1
Git commit:        8871aca3
Cluster Version:   v3.17.1
Cluster Type:      kops,bgp,kdd,k8s

Orchestrator version (e.g. kubernetes, mesos, rkt):

kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-14T05:15:04Z", GoVersion:"go1.15.6", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.7", GitCommit:"1dd5338295409edcfff11505e7bb246f0d325d15", GitTreeState:"clean", BuildDate:"2021-01-13T13:15:20Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

Operating System and version:

Linux ip-10-151-38-111 5.4.0-1035-aws #37-Ubuntu SMP Wed Jan 6 21:01:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Disabling wireguard improved situation a lot (errors are basically non-visible for our customer), but I still see the same errors in ElasticSearch every 2-3 hours about master node disconnected after failing 3 consecutive checks, so probably issue is partially related to ebpf data plane. (pods aren't getting restarted, just connection issues)

Changing daemonset to this image finally resolved the problem, current setup without errors:
calicoctl version
Client Version:    v3.17.1
Git commit:        8871aca3
Cluster Version:   v3.19.0-0.dev-13-ga9bbeb301daa-dirty
Cluster Type:      kops,bgp,kdd,k8s

IPPool:
spec:
    blockSize: 26
    cidr: <IP_ADDRESS>/11
    ipipMode: Never
    natOutgoing: true
    nodeSelector: all()
    vxlanMode: CrossSubnet

FelixConfiguration:
spec:
    bpfLogLevel: ""
    ipipEnabled: true
    logSeverityScreen: Info
    reportingInterval: 0s
    vxlanEnabled: true

At one point during migration from IPIP encapsulation, VXLAN interface wasn't being created on nodes before until this option was addded to felixconfiguration: vxlanEnabled: true even though we expected kops to do that for us.

@fasaxc could you follow up and label this issue?

Does fasaxc/calico-node:ct-syns-2 fix the issue for you?  That change has merged now.

@fasaxc yes, it did, together with disabling wireguard.  So, now waiting for next kops releases that would include that version

Does it work if you re-enable wireguard?

I don't think so. That was my first step to try that image - didn't work. Then I disabled wire guard - less errors but didn't work still. Then I tried image again with disabled wire guard and errors went away

Are the disconnects after the connection has been open for a long time?  BPF mode has connection timeouts to clean up the BPF conntrack table, for example.

see the same errors in ElasticSearch every 2-3 hours about master node disconnected after failing 3 consecutive checks

Are the checks once per hour?  I think our connection timeout is an hour with no packets so you could hit that.

Are the checks once per hour? I think our connection timeout is an hour with no packets so you could hit that.

If I am not mistaken, checks are done as discovery mechanism all the time, not sure about exact frequency but probably something like once per minute. All the settings here are in terms of seconds and we didn't configure anything special.

qdisc clsact ffff: parent ffff:fff1
 Sent<PHONE_NUMBER>3 bytes 3670344 pkt (dropped 1103, overlimits 0 requeues 0)

Does suggest that our BPF program is dropping packets.
CALI-C: NAT miss.

Is normal; that just means that a particular connection was not NATted.
I'd expect this log if the BPF program drops a packet:
Final result=DENY ...

do you see that in the BPF trace?  We'd need some context around the log too to figure out what went wrong.

@mlushpenko I've set up a BPF/wg cluster and provisioned an Elastic cluster with ECK.  What should I expect to see now; how can i see the errors?  What do I need to do to trigger an error?

@fasaxc we have setup where ES nodes are on different nodes (sometimes also in different zones, but not the case for the  clusters where we've noticed issues). I don't believe platform load has any affect on this, so likely you will start seeing errors pretty soon as it is discovery for ES that is failing. MTU values are the same 8941? Apart from that, not sure what other conditions are needed. I could provide kops template optionally.
Maybe a week ago we've updated cluster via kops and calico image was reverted to the original one and errors came back. So, at least behaviour is consistent.
Values for elastic/elasticsearch chart version 7.5.1:
podAnnotations:
  iam.amazonaws.com/role: k8s-elasticsearch
esJavaOpts: -Xms4g -Xmx4g
resources:
  requests:
    memory: 4Gi
    cpu: 512m
  limits:
    cpu: 2000m
    memory: 5Gi
persistence:
  enabled: true
volumeClaimTemplate:
  storageClassName: gp3
  resources:
    requests:
      storage: 50Gi
rbac:
  create: true
podSecurityPolicy:
  enabled: true
securityContext:
  runAsUser: 1000
esConfig: # log level can be TRACE to get even more data
  elasticsearch.yml: |
    xpack.monitoring.collection.enabled: true
    script.allowed_types: inline, stored
    logger.org.elasticsearch.cluster: INFO
esMajorVersion: 7
imagePullPolicy: "IfNotPresent"
clusterName: elasticsearch
roles: # that's the default
  master: "true"
  data: "true"
  ingest: "true"
updateStrategy: RollingUpdate # that's the default
replicas: 3
nodeSelector:
  type: es-instance
tolerations:
  - key: type
    operator: Equal
    value: es-instance
    effect: NoSchedule
maxUnavailable: 1
antiAffinity: "hard"

@mlushpenko thanks for the follow-up.  Where would I see the errors?  Would they be in the ES logs?

Yes, you should see in ES logs that nodes are failing and being added/removed to the cluster, I can't find proper stacktrace in kibana right now, but see at least this message from the period when they were failing

I don't see this on a kubeadm cluster on GCP, using wireguard.  It's a small cluster with only Elastic running on it.  @mlushpenko can you tell us more about your cluster?  Where is it running, how did you set it up?  What's the underlying network?

@fasaxc you used wireguard and ebpf together, right? Apparently, it also happens just with ebpf, as current settings on one of the clusters that was failing recently (until image is changed back manully) are these:
networking:
    calico:
      awsSrcDstCheck: Disable
      bpfEnabled: true
      bpfLogLevel: Info
      crossSubnet: true
      encapsulationMode: vxlan
      ipipMode: Never
      mtu: 8941

just realised that in this case MTU should probably be 8951 according to this table. Would you expect packet drops due to that? But if MTU would be the cause, then new image wouldn't help, right?
Do you want full kops state file? (you'll need to change some values)
We use calico CNI as defined here and I've provided our settings.

One more option (a bit harder) I can think of is to try reproducing this on our test environment and then perhaps you would be interested to do some pair programming session to investigate. But we are not a paying customer and likely the next upgrade of the cluster will be sufficient or we have a workaround of just not using ebpf, so up to you if this sounds interesting.

I am closing this issue because it is very old refering to 3.18 while we are at 3.27 now and much has changed. Sorry for not following up back then :disappointed: . If it is still an issue with newer versions, feel free to reopen or file a new issue.


doc(behavior_path_planner): fix lane change document

Description
Fix lane change document to comply with the current implementation.

Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@shmpwk
Seems like the spell check is unrelated to the updated documents.