Position Independent Code

Hello!
From what I can gather, cortex-m-rt doesn't currently support being compiled with position independent code.
I would like to have multiple applications on the flash, and have the bootloader chooses which one to run by just changing the VTOR.
Is it possible to have this work?

Unfortunately Rust doesn't really support this for the thumb targets yet; there's some more info here:

https://github.com/rust-lang/rust/issues/54431
https://freenode.logbot.info/rust-embedded/20210214#c6910695
#320

It might work for some limited applications if vtables and perhaps statics weren't used, but in general it's not currently supported. You could possibly imagine the bootloader doing some runtime patching or moving code around to make it work, but it wouldn't be simple.

I see, thanks for the links!
I'll follow rust-lang/rust#54431.


Cannot Retrieve Information from SingletonTypeSymbol

Description:
There is no way to retrieve the name or documentation of a SingletonTypeSymbol in Package APIs. (SingletonTypeSymbol does not have any APIs as it seems).

Do you have an example on what you were trying to do? Generally type symbols don't have metadata associated with them. e.g.,
# A type def for a singleton type
type Foo 10;

Foo f = 10;
20 s = 20;

In the above use of 10 in the type def, that's a singleton type. But the documentation in the line above that is not a part of that singleton type. That documentation is a part of the type def Foo.
To better understand the difference, consider the second case, where 20 is used as a type. That's also a singleton type, but it's directly used as a singleton type. Which means no meta data for it.

Had an offline chat with @ThisaruGuruge regarding this. So the requirement was something like the following:
# This is a constant
const FOO = "foo";

# This is a type
type Bar <cursor>FOO;

So previously, if we looked up the symbol at the illustrated cursor position, it returned a singleton type IINM, due to #26284. But now, when we look up the symbol, it returns the constant symbol for FOO, from which the documentation is accessible. This addresses the above concern right?

Thank you, @pubudu91. This will solve the issue.


[HOLD for payment 2023-11-17] Desktop - App redirection - Logged in with different accounts App crashed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.96-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Login with account A in the desktop app
Login with account B in the web app
Navigate to the user profile page in the web app
Refresh the browser
A prompt should appear asking to 'Open the link in New Expensify'
Click on it and wait for the desktop app to open

Expected Result:
Verify the user profile page for account B is displayed in the desktop app
Actual Result:
Logged in with different accounts App crashed
Issue reproduced when try to sign in with Apple Id/ Chrome
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/83ea862d-c64c-40a7-9d2e-9403cc5b9901
https://github.com/Expensify/App/assets/78819774/06a3a9a5-1c98-4673-94ae-089446560fb1
View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @aimane-chnaif

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Managed to reproduce:

Double checking in the PR to see if that's the cause.

Posted here, if I don't get a reply from Margelo tomorrow morning I will probably revert the PR.

Hey, I am checking! Could you explain why do you think it caused the regression?

I believe its more likely a regression from this PR:

https://github.com/Expensify/App/pull/24482#issuecomment-1798440156

Hey, the offending PR is this one:
https://github.com/Expensify/App/pull/28927
It introduced this line without adding proper null checking
https://github.com/Expensify/App/blob/24184e4a987aba011b5231680da66dcef11f6a24/src/pages/home/report/ReportActionCompose/Suggestions.js#L49
Reverting this PR (this change) fixes the crash

Hey, the offending PR is this one:
#28927
It introduced this line without adding proper null checking
https://github.com/Expensify/App/blob/24184e4a987aba011b5231680da66dcef11f6a24/src/pages/home/report/ReportActionCompose/Suggestions.js#L49
Reverting this PR (this change) fixes the crash

But this PR is in production.

Tested, it's working well now!

@bfitzexpensify Time to pay this one 😄

Missed it as a Weekly, sorry all!
Payment summary:
Contributor: @allroundexperts to be paid $500 via manual request
C+: @aimane-chnaif to be paid $500 via Upwork - offer sent

Upwork payment complete, @aimane-chnaif please complete the BZ checklist when you get a chance - thanks!

Great, thanks! Let's close this out.

$500 payment approved for @allroundexperts based on this comment.


Include install instructions for Ubuntu in the 'Install' section of the documentation

See original issue on GitLab
In GitLab by [Gitlab user @LaurenceUrhegyi] on Jun 21, 2018, 17:37
Background
Although we have instructions to install Debian on the Install pages of the docs, they should include specific instructions for Ubuntu.
Task description

[ ] Add specific instructions for Ubuntu on the Install pages of the docs.

Acceptance Criteria

[ ] Link to the newly added instructions

In GitLab by [Gitlab user @phildawson] on Jun 26, 2018, 13:20
assigned to [Gitlab user @phildawson]

In GitLab by [Gitlab user @jennis] on Jun 28, 2018, 12:48
I'm using an Ubuntu VM with BuildStream installed.
Just so that you're aware: I do recall having some difficulties installing BuildStream on an Ubuntu VM, but I can't remember what they were exactly.
Now, having just reviewed the source of each dependency package, it seems as if the installation process should be identical to that described for Debian Stretch (here).
Which means that installing BuildStream on Ubuntu should be straight forward.
It's worth noting that I am using a Debian backports repository on an Ubuntu machine (included in the sources.list file), which works fine AFAIK, but I'm not sure whether this is a sensible thing to do or not. Perhaps trying to avoid using this was the difficulty I was having...

In GitLab by [Gitlab user @tlater] on Jun 29, 2018, 13:16
We have a CI image for ubuntu 18 now: https://gitlab.com/BuildStream/buildstream-docker-images/tree/master/testsuite/ubuntu-18
Any instructions should probably be based on that image.

In GitLab by [Gitlab user @phildawson] on Jul 2, 2018, 10:10
mentioned in commit 30f7aac5db2d3b8fed9b9376d6f61215f4d7a190

In GitLab by [Gitlab user @phildawson] on Jul 2, 2018, 13:54
mentioned in commit e048a2f67a900665c38e1267f941b387eaf7e013

In GitLab by [Gitlab user @phildawson] on Jul 2, 2018, 13:59
mentioned in merge request !525

In GitLab by [Gitlab user @phildawson] on Jul 2, 2018, 14:33
mentioned in commit a1e7bea86d871538cd85902d8d389dcb13d18f0e

In GitLab by [Gitlab user @phildawson] on Jul 2, 2018, 14:47
mentioned in commit 712df14a1dc9988374cfac06d5ecd8794d476537

In GitLab by [Gitlab user @phildawson] on Jul 2, 2018, 14:47
mentioned in commit e74f891cbfb7ec1e971f56499a6a2f41a9aeb57f

In GitLab by [Gitlab user @phildawson] on Jul 2, 2018, 15:42
mentioned in commit 5a1acdcd134ae6dff7b032db5a6d24b329c212bd

In GitLab by [Gitlab user @phildawson] on Jul 4, 2018, 19:27
mentioned in commit 431e74844d7189a1895d3f19a111fdac95f4d3bf

In GitLab by [Gitlab user @jmacarthur] on Jul 19, 2018, 09:55
assigned to [Gitlab user @jmacarthur]

In GitLab by [Gitlab user @jmacarthur] on Jul 19, 2018, 10:15
unassigned [Gitlab user @jmacarthur]

In GitLab by [Gitlab user @phildawson] on Jul 23, 2018, 10:28
mentioned in commit 66af3d0d65cd2e0d67960aac04baa03be9cd4938

In GitLab by [Gitlab user @phildawson] on Jul 24, 2018, 10:13
mentioned in commit dc457bb5f5916ddda18f67e2b026ff02e5e56213

In GitLab by [Gitlab user @phildawson] on Jul 26, 2018, 12:15
mentioned in commit 346c1eee84f4719b170f8b31974a904d9bb7acd3

In GitLab by [Gitlab user @phildawson] on Jul 27, 2018, 12:11
mentioned in commit d9a5f795dfa78f8c4478ebc83a37e7f6e9c637bd

In GitLab by [Gitlab user @phildawson] on Jul 30, 2018, 11:59
mentioned in commit 14fa42c993eea247ddfa4c844ecd8bfbfd8cfbee

In GitLab by [Gitlab user @phildawson] on Jul 30, 2018, 12:12
mentioned in commit<PHONE_NUMBER>32d1e3513bb0f713af71ba18d989c4

In GitLab by [Gitlab user @jjardon] on Aug 1, 2018, 17:30
mentioned in commit c4981cde06a4326ef82dc8f3a08535d637b6b554

In GitLab by [Gitlab user @jjardon] on Aug 1, 2018, 17:31
mentioned in commit 547d20b2a8cef1f0c7dc261aede62f7e95713220

In GitLab by [Gitlab user @jjardon] on Aug 1, 2018, 18:28
closed via merge request !525

In GitLab by [Gitlab user @jjardon] on Aug 1, 2018, 18:28
mentioned in commit 592c90616284adaba5a30fae56dad3760226dee4


Click not working with persist interval

Not sure if I'm missing some part of config since I see this was implemented, but when I have the next, prev, play/pause buttons set with persistent interval they don't work. Setting them to interval works, but is obviously not ideal.
i3blocks version 1.4-4
Ubuntu 18.04

Click events for persistent blocklets are supported since i3blocks version 1.5 (check the last item of the Features section of the README), you need to upgrade.

Not sure how I missed that I suppose that's what I get for doing this late at night.
Thanks for the quick help!


[HUDI-4756] Remove assume.date.partitioning configuration

Change Logs
Remove  assume.date.partitioning config from Hudi
Impact
Hudi cannot rely turning this configuration to do some optimization.
But this simplifies the logic of the codebase, and removes the special logic of handling for partition creation.
Risk level (write none, low medium or high below)
After we confirm that no tables are using this config, no users should be impacted.
Documentation Update
Old documentations about this config should be removed.
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Create a new one instead.


fix: first attempt at parameterising actions

There's butter on my face!

There's butter on my face!

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Raspberry Pi GPIO Cover Invalid Config

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.34.4
Python release (python3 --version):
5.4.2
Component/platform:
cover.rpi_gpio
Description of problem:
Adding the state_pull_mode to the config results in the following error.
Invalid config for [cover.rpi_gpio]: [state_pull_mode] is an invalid option for [cover.rpi_gpio]. Check: cover.rpi_gpio->covers->0->state_pull_mode. (See ?:?). Please check the docs at https://home-assistant.io/components/cover.rpi_gpio/
Expected:
state_pull_mode should work as described in the config documentation
Problem-relevant configuration.yaml entries and steps to reproduce:
cover:
  platform: rpi_gpio
  covers:
    - relay_pin: 10
      state_pin: 11
      state_pull_mode: 'DOWN' #Tried with single, double and no quotes as well.

@turbokongen and @fabaff can you take a look at this for me? I've tried to find the error in code, but it all looks good to me.

According to the code it should be
cover:
  platform: rpi_gpio
  state_pull_mode: 'DOWN'
  covers:
    - relay_pin: 10
      state_pin: 11

Is that working for you?

@Danielhiversen thank you.

Tested and works, closing issue.

It is the same for the relay_time parameter.
It would be great if you can help improve the documentation for the component.
In the upper right corner of any documentation page, you will find "Edit this page on GitHub".
Follow the link and submit your suggested change.
Demonstrated here: https://youtu.be/dRfk9JAlPJk?t=1h16m17s4

Will do!


404 URL in Webserver Python Error Output

Docs Update Description
The following error message from the fides webserver command has a 404 URL
There are missing required configuration variables. Please add the following config variables to either the fides.toml file or your environment variables to start Fides:

security.app_encryption_key
security.oauth_root_client_id
security.oauth_root_client_secret
Visit the Fides deployment documentation for more information: https://docs.ethyca.com/fides/deployment
*Side note, above documentation link yields 404. Will open separate issue.

Additional context

I can take this issue but can someone let us know which link it should be directed to? Is it this: https://ethyca.com/docs/dev-docs/configuration/deployment ?

confirmed with product management this is the correct link


docs: Add documentation for EverCrypt AEAD, Curve25519, and HKDF.

Hope this doesn't get tiring :-) I have a feeling that we might want to discuss here a bit. That's why this PR is a bit smaller. I will probably make another one for EverCrypt tomorrow. But that should be it for a few days

Thanks for the review!
There might be a better (and more aesthetic) way to document the tag and key lengths. But it is certainly helpful to already have something in the docs. So this is a bit of an best effort for now.


Pass response as an extra parameter in log_response

This means that when using a formatter inherited django.utils.log.ServerFormatter to log responses, in addition to logging the status_code, you can also log the body (response.body) or some other attribute of a Response object.

Hello @rodolvbg! Thank you for your first contribution.
I'm not that convinced about this change, for the following reasons:

Except for docs or tests improvements, there is the expectation to have an accepted ticket for any change to the Django source code.
The response object can be huge, adding this on every logging call could increase memory usage considerably.
There are no tests for this change.
The proposed change would also imply a change in the method's docstring, and in the published docs as ref/logging.

Considering the points mentioned above, my suggestion is for projects needing the response available for logging to override the method and customize it accordingly. I believe we should close this PR based on that, but I'd appreciate hearing your thoughts first.

Closing per comment.


harden provider upload

can we direct people who have county errors to file issues on Github?
as for an e-mail we can use for when the application is public-facing, let's discuss on Slack.

@viviandien We could - would that be too technical for some users?

@bcherny let's use<EMAIL_ADDRESS>for now please (does not exist yet but will soon)


database storage implemented

database storage implemented #43

Whew, merge conflicts resolved. Will go through this one more time tomorrow and then finally merge it.

okay

created sign up and login form #39

Great work on the database @ankitgarg1234! Merging your PR.

Welp, something broke. We're looking into it

@ankitgarg1234 we're experiencing two bugs right now.

When logged in from two different systems, if one page is refreshed, it takes the session of the other person who is logged in (checked out both locally and on deployment)
When browser is closed and opened again to localhost, it is already logged in but when you send a message, it's sent from an 'undefined' username, after which the server crashes.

A user has connected
Received a chat message
undefined
D:\git\chatApp\node_modules\mongoose\lib\document.js:2913
    this.$__.validationError = new ValidationError(this);
                               ^

ValidationError: message validation failed: email: Path `email` is required.
    at model.Document.invalidate (D:\git\chatApp\node_modules\mongoose\lib\document.js:2913:32)
    at D:\git\chatApp\node_modules\mongoose\lib\document.js:2704:17
    at D:\git\chatApp\node_modules\mongoose\lib\schematype.js:1280:9
    at processTicksAndRejections (node:internal/process/task_queues:78:11) {
  errors: {
    email: ValidatorError: Path `email` is required.
        at validate (D:\git\chatApp\node_modules\mongoose\lib\schematype.js:1277:13)
        at D:\git\chatApp\node_modules\mongoose\lib\schematype.js:1260:7
        at Array.forEach (<anonymous>)
        at SchemaString.SchemaType.doValidate (D:\git\chatApp\node_modules\mongoose\lib\schematype.js:1210:14)
        at D:\git\chatApp\node_modules\mongoose\lib\document.js:2696:18
        at processTicksAndRejections (node:internal/process/task_queues:78:11) {
      properties: {
        validator: [Function (anonymous)],
        message: 'Path `email` is required.',
        type: 'required',
        path: 'email',
        value: undefined
      },
      kind: 'required',
      path: 'email',
      value: undefined,
      reason: undefined,
      [Symbol(mongoose:validatorError)]: true
    }
  },
  _message: 'message validation failed'
}

yep sure


-init option doesn't do anything

$ cat ocamlinit
#use "topfind";;
#thread;;
#require "core async";;

$ utop

utop # Oloop.with_toploop ~init:"ocamlinit" Oloop.Outcome.merged ~f:(fun t -> eval t "open Core_kernel.Std" >>| fun x -> Ok x);;
- : Oloop_outcome.merged Outcome.t Core_kernel.Std.Or_error.t =
Core_kernel.Result.Ok
  (`Uneval
    (`Typetexp
       ({Location.loc_start =
          {Lexing.pos_fname = "//toplevel//"; pos_lnum = 1; pos_bol = 0; pos_cnum = 5};
         loc_end = {Lexing.pos_fname = "//toplevel//"; pos_lnum = 1; pos_bol = 0; pos_cnum = 20};
         loc_ghost = false},
        <abstr>, Typetexp.Unbound_module (Longident.Lident "Core_kernel")),
     "Error: Unbound module Core_kernel\n"))

It's not an issue with relative paths. Passing the absolute path to init doesn't change the behavior.

I just pushed support for -noinit in 361f5229952e17267f0887f0d3df755d24a32351, and it also doesn't seem to have any effect.
In fact the behavior is the opposite of what I expected. With both -noinit and -init not passed, I was expecting my default ~/.ocamlinit file to get picked up by oloop, but it isn't.

~init:file could simply issue a #use "file" (possibly searching first the file at standard locations).

~init:file could simply issue a #use "file"

Yes, but I feel that's avoiding the issue, which is that command line options to ocaml-top are not getting activated. Maybe the technique of mutating Clflags isn't right.

Both options are used by Toploop.load_ocamlinit:
let load_ocamlinit ppf =
  if !Clflags.noinit then ()
  else match !Clflags.init_file with
  | Some f -> if Sys.file_exists f then ignore (use_silently ppf f)
              else fprintf ppf "Init file not found<EMAIL_ADDRESS>f
  | None ->
     if Sys.file_exists ".ocamlinit" then ignore (use_silently ppf ".ocamlinit")
     else try
       let home_init = Filename.concat (Sys.getenv "HOME") ".ocamlinit" in
       if Sys.file_exists home_init then ignore (use_silently ppf home_init)
     with Not_found -> ()

One may add this function to oloop-top but then the question is what we do about its possible output (indicating a problem).  Maybe it is better to add Oloop.init that is inspired by this function be that indicates an error through its return value?

Okay, I suppose for init and noinit, it might be easiest to implement this functionality directly in oloop. Also, then we can provide noinit in OCaml 4.01.0 without any problem.

Please test more.  The following
utop # Oloop.with_toploop Oloop.Outcome.merged ~f:(fun t -> init ~init_file:"ocamlinit" t >>=? fun () -> eval t "open Core_kernel.Std" >>| fun x -> Ok x);;

seems to work.

Ahh... I see why I'm getting merge conflicts now.  :)

fafa8c09eb18176658048f2310856efdea4a2d27 does compile on both 4.01.0 and 4.02.1, but I still feel it is a hack. We've now implemented ourselves something the OCaml toplevel is supposed to already be doing.

I have to go right now, but I'll do a release later so at least we get into opam.

@agarwal In principle, I agree: if possible, we should use the functionality provided by the toploop library.  In this case however, the functionality is in load_ocamlinit and this function is not exported (not speaking about the need to make this code conditional since Clflags.noinit is only available on recent versions of OCaml).
Note that the current implementation is not without flaws either.

It does not report an error when there is an error in the included file.
The current directory of the main program may be different from the one of the toploop instance, in which case the detection of the existence of the file is bogus.

The functionality should probably be moved to oloop-top into a function alike load_ocamlinit and a special input command (i.e. make the value sent to the toploop be a variant) should trigger it.

I reopen the issue so that we do not forget to find a satisfactory solution.

Ok, thanks for the explanation.

Hope you like the new implementation.  It handles both issues that the previous one had.


target: remove extra https prefix

The image url already comes with an https prefix, adding it again results in broken images for Target links.

Thank you!


Show "Disabled" state in github-actions-indicators

Closes #6529

This is my first PR. I'm good at VanilaJS and Chrome Extensions but not TypeScript.
Blaming my code is Welcome!

May the next PR will be Impl #6443.
I've implemented it through the details component, but not Just with SVG Icon.
My low css skill is going to bother me.

Thank you for maintaining this awesome project.

Test URLs
https://github.com/134130/134130/actions
Screenshot

Thank you for your contributions!


BUG: Seg Fault when st_aswkb() to arrow

Minimal reproducible example
duckdb version: 0.9.2
OS: MacOS Sonoma 14.2.1 - M2 arm64
I ran this script on lldb, and I had to attach it to a pyarrow 12 to (same reason of than https://github.com/duckdb/duckdb/issues/9371#issuecomment-1766409004)
import duckdb
import gc

for i in range(20):
        sql_str = "select st_aswkb(geom) from foo"
        s = "load spatial; load httpfs"
        view_str = "create or replace temporary view foo as select * from st_read('https://raw.githubusercontent.com/ibis-project/testing-data/master/geojson/zones.geojson')"

        con = duckdb.connect()
        con.execute(s)
        con.execute(view_str)
        v = con.sql(sql_str)

        we = v.arrow()
        gc.collect()
        print(i)

run on lldb
>>> lldb python repro-geo-segfault.py
(lldb) run

0
1
2
3
4
5
Process 6324 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x310a15d12340)
    frame #0: 0x000000010aa25438 spatial.duckdb_extension`std::__1::__tree<long long, std::__1::less<long long>, std::__1::allocator<long long>>::destroy(std::__1::__tree_node<long long, void*>*) + 24
spatial.duckdb_extension`std::__1::__tree<long long, std::__1::less<long long>, std::__1::allocator<long long>>::destroy:
->  0x10aa25438 <+24>: ldr    x1, [x1]
    0x10aa2543c <+28>: bl     0x10aa25420               ; <+0>
    0x10aa25440 <+32>: ldr    x1, [x19, #0x8]
    0x10aa25444 <+36>: mov    x0, x20
Target 0: (python) stopped.

Hi!
I am unable to reproduce this in the CLI and at first glance I don't think this is related to the spatial code. DuckDB has no knowledge of what the blob contains when it converts it into pyarrow so I'd assume that the crash is due to a bug in the general duckdb blob->pyarrow binary conversion code, but I'll have to investigate more to say for sure.

@Maxxen any chance you had some time to look at this?
I noticed that when I'm on duckdb 0.9.1 I don't hit this problem. It also seems to be only happening on mac M2 arm64, none of the folks with linux machines have been able to reproduce. But I can consistently reproduce it.

Hi! Me and @Tishj sat down and looked through this and we think we've figured out what the issue is. Thankfully it seems to originate in spatial (related to state kept around in the st_read table function binding) and not DuckDB core so even if I wont have time to fix this until after next DuckDB release we should be able to squash it In the following stable spatial version.

Thank you @Maxxen and @Tishj

I think this may have been fixed in #271, could you try with v0.10.0 and the latest nightly build (I just merged so its gonna be an hour or two until it gets uploaded) and see if it still occurs? If its still occurring I'll sit down with Thijs again and do a proper debugging session.

Max, I'll give this a try tomorrow and I'll get back to you.

@Maxxen I run the reproducer with duckdb v0.10.0 and installing the spatial extension from the nightly and did not seg fault 🎉
What's the release cycle for the spatial extension, so we can update couple of things in our end? Currently this issue breaks some of our geospatial blogs rendering.

@Maxxen Any idea when the next release of this extension will ship?
I'm hitting this segfault pretty regularly now.

@cpcloud Yes! Next DuckDB release is scheduled for next week, and the latest spatial extension will be distributed alongside it.

Re: Release cycle. DuckDB extensions don't really support versioning yet so the release cycle of our extensions is more or less tied to DuckDB's  own release cycle. Previously when DuckDB itself had longer releases cycles (like the almost 6 months between 0.8 and 0.9) we basically "overwrote" extensions for the latest stable version manually every now and then with a later build to push bugfixes and/or new features, but I think now that we are trying to do shorter bug-fix release cycles for DuckDB (1-2 months) we won't be doing that anymore.

Closing this one as it is resolved in the recent release. Thanks for your work @Maxxen


Reversed how build calls eslint/test workflows

#557  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite


Clearly highlight the relationship between SP creation and RBAC enforcement

This document is quite useful, but please consider the following feedback which I have as a result of trying to follow this.

The logical connection between the following sections "Assign RBAC roles using the Azure portal" and "Authenticate from an application" has not been highlighted (although they are closely related) - this is the essence of this guide

Altering the sequence of sections might help i.e. the section "Assign RBAC roles using the Azure portal" should be placed after "Authenticate from an application". The "Assign RBAC roles using the Azure portal" deals with creating the Service Principal which in turn is used to assign roles (RBAC process)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8719fae6-003f-f9a8-aba4-639db206780b
Version Independent ID: d3426eb2-66eb-99d4-ce9f-7daf1adf7c25
Content: Authenticate an application to access Azure Event Hubs resources
Content Source: articles/event-hubs/authenticate-application.md
Service: event-hubs
GitHub Login: @spelluru
Microsoft Alias: spelluru

We have assigned the issue to the content author . They will evaluate & update the document as appropriate

#in-progress

Fixed. #please-close


In comparison page, Glamorous now deprecated

In the comparison page, it says:

React is often done via CSS-in-JS solutions (e.g. styled-components, glamorous, and emotion)

However, Glamorous is now deprecated and unmaintained, so maybe it should not be mentioned here anymore?

That makes perfect sense! Would you want to work on a PR?

Closing this as related PR was merged 👍


Use Breadcrumbs to track user location and allow for user to be able to easily see where they are on the site.

User Story(s):
As a User, I want to be able to easily identify the page I am on at any given time and to be able to know where I came from.
Description: Add breadcrumbs to enhance navigation.

Already added in base implementation with Bootstrap: https://getbootstrap.com/docs/5.3/components/breadcrumb/. However, may need some bug fixes. Will look into it.


Desktop version - My portfolio

Created a version of the portfolio adapted for screens bigger than 768px.
Added media queries to all sections.

Hi!
The issues detailed were already solved. Please let me know if there's anything else I should work on.
Thanks 😃


Customer/department doesn't make much sense

We'd chatted about this last week, @wpaven - I'd done the exercise of pulling 'department' into a domain object but then it seems peculiar that customers have departments.
One option is to change department to something like 'segment'.  The existing values you 'load data' workspace would work ok for segment, even if the meaning of the model is a stretch.
Another would be to introduce another person into the model, a sales agent.  A sales agent could be a person who works for the company, and have a department and name and email, but not a billTo or shipTo.
This approach would complexify the model.  Let's work out in this issue what to do and change the workspaces.

updated to segment.


Starterkit installation fails for any starterkit without a package.json

https://github.com/pattern-lab/patternlab-node-cli/blob/master/bin/init.js#L101-L160

[x] https://github.com/pattern-lab/starterkit-mustache-demo
[x] https://github.com/pattern-lab/starterkit-mustache-base
[x] https://github.com/pattern-lab/starterkit-mustache-acidtest
[x] https://github.com/pattern-lab/starterkit-mustache-foundation
[x] https://github.com/pattern-lab/starterkit-mustache-bootstrap
[x] https://github.com/pattern-lab/starterkit-mustache-materialdesign

@bmuenzenmeyer Can you explain on this one?

so we've had problems with npm/requiring starterkits in the past because their package.json files were missing a scripts entrypoint. this was a placeholder issue to make mention of all "official" starterkits that are still to be changed, like: https://github.com/pattern-lab/starterkit-mustache-bootstrap
i will turn this into a to-do list

Oh I missed that, thanks! I will also try to think about a way to check for existence without a package.json

@bmuenzenmeyer I noticed that https://github.com/pattern-lab/starterkit-mustache-base cannot be installed via npm because no package.json …

@raphaelokon all starterkits are done. feel free to retest that suite you showed me earlier.

@bmuenzenmeyer Cheers for updating the starter kits

https://github.com/pattern-lab/starterkit-mustache-materialdesign/blob/master/package.json This one is still missing a main I guess

ugh. repushed. check again! off to bed for me

Enjoy! Works now – tests do pass. This will be fixed with the next bigger release.

Closing as this is a won't fix for global installs until we hit #32


Added scroll_step for slider

Added scroll_step for slider. This allows you to change the slider value by the value of scroll_step by scrolling the mouse wheel
Added an example of using this feature.
Also now, if negative values are passed to 'step_by' or 'scroll_step`, this will mean disabling the function

This feature is strongly related to step_by, so I added a little logic in case the user wants to use both at the same time. If step_by and scroll_step are used, then scroll_step = step. I'm not sure if this is the right solution, so you can offer your ideas.

What is the use case being solved here? Using the scroll wheel to move a slider is nice, but does it require a separate scroll_step setting? Alternatives would include:

Moving the slider as many points as the user scrolled (would work great for smooth scroll inputs such as touch-pads)
Moving the slider by the step_by size for each discreet scroll tick on discreet scrollers (i.e. mouse wheels)

When would you want step_by and scroll_step to be different?

When would you want step_by and scroll_step to be different?

I don't think there are situations where it makes sense to use them together, but I did it from the point of view that an egui user may mistakenly use both of these functions.


Trying to get embedded jpg base 64 code (from the images in the pdf itself)

I've been busy with this for weeks and I can't get it done, I've been searching everywhere and I'm honestly lost. I could find the new image name the pdf.js give them and their sizes (width and height) but I need to reproduce the picture outside of just the pdf viewer.
I'm making a application which loads in a pdf design (from a design company) and dynamically adds that specific design into a list with more design from people to choose from. But I can't even start that part since I'm lost on finding jpg data.
If anyone has any idea on how to gather this data I'd really appreciate it!
Kind regards,
Rick

Closing since this answered and out-of-scope for PDF.js itself. If the suggestion above does not work, you could try using the imageLayer canvas parameter (https://github.com/mozilla/pdf.js/blob/9a115b41dede03b76cc4cd73319d77857a466a43/src/display/canvas.js#L421) or getting the image data from e.g., https://github.com/mozilla/pdf.js/blob/9a115b41dede03b76cc4cd73319d77857a466a43/src/display/canvas.js#L443.

我已经忙了好几个星期了，但是我做不完，我一直到处搜索，老实说我迷路了。我可以找到pdf.js赋予它们的新图像名称及其大小（宽度和高度），但是我需要在pdf查看器之外复制图片。
我正在制作一个应用程序，该应用程序加载了pdf设计（来自设计公司），并动态地将特定设计添加到列表中，供更多人选择。但由于找不到jpg数据，我什至无法开始这一部分。
如果有人对如何收集这些数据有任何想法，我将不胜感激！
亲切的问候，
瑞克

你好，您说的“我可以找到pdf.js赋予它们的新图像名称及其大小（宽度和高度）”，这一步如何实现的呢


new: Add Storybook support

Add documentation on setting up and using Storybook with Moon
Closes #539

@itsezc You'll need to add the entry to sidebar.js also.


Remove alert when user deletes a single bid

@eordano @abarmat the card on trello mentions a notification I'm not seeing, are we skipping that?


Use CESU-8 decoder if UTF-8 decoder fails (issue #2299)

Closes #2299

DEX format uses Modified UTF-8 which includes:
Code points in the range U+10000 … U+10ffff are encoded as a surrogate pair, each of which is represented as a three-byte encoded value.
...
MUTF-8 is actually closer to the (relatively less well-known) encoding CESU-8 than to UTF-8 per se.

Based in this, I suggest this change:

If decoding fails for a UTF-8 "String block", then try to use CESU-8.
I didn't want to always use CESU-8 because it's not clear that it is the actual decoder that should be used, but it does seem to work for the specific examples I tried.
I wrote some unit tests for StringBlock#decodeString. I didn't add tests at a higher level, i.e., decoding an APK and verifying the resources' values as in DecodeArrayTest.

Thanks!


Upgrade tracing to the next major version

Motivation
tracing has a medium-priority security fix:
https://github.com/chronotope/chrono/issues/499
https://rustsec.org/advisories/RUSTSEC-2020-0159
(Zebra uses UTC, so our direct uses of chrono are safe.)
Tasks

All these tracing crates need to be upgraded together:

tracing-subscriber: https://github.com/ZcashFoundation/zebra/pull/2956
tracing-error: https://github.com/ZcashFoundation/zebra/pull/2948
tracing-journald: https://github.com/ZcashFoundation/zebra/pull/2949

Remove the exceptions for these crates in deny.toml.

I ran into a few roadblocks trying to update tracing. The first issue is that abscissa-core hasn't been updated to use the newer version of tracing-subscriber, so we'll have to wait for a new release of it. The master branch of the repository has already been updated with the new version of tracing-subscriber, but there hasn't been a release with it yet.
The second issue is that the sentry-tracing dependency is in the same situation. The master branch has been updated, but there hasn't been a release with it yet.
The third issue is that there is no tracing-flame release that's compatible with tracing-subscriber version 0.3.1. I tried to work around this by changing the dependency to use the Git repository directly on the tracing-subscriber-0.3.1 tag, but that split the tracing dependency in two, one from crates.io and one from Git. Trying to move all dependencies to the Git version leads to issues with indirect dependencies.
A think a solution to this problem might be to use dependency patching, but I'm not sure if it's worth trying this now or simply delaying this issue.

I think we should delay until we have all of the required NU5 (and prior) validation in place. Seems like too much effort when there is a lot of other work that is much higher priority than this and definitely needs to get done in the next few sprints

I'll reschedule this for sprint 25, we can check if the ecosystem has caught up by then.
I'll also add the checks for the crates Janito mentioned to the list of tasks in the ticket.

https://github.com/ZcashFoundation/zebra/pull/3265


optimize: rollback of global transactions ahead of time #4422

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
当tm端的channel与tc端断开时，很大可能是因为tm宕机了，如果tm宕机说明tm无法决议事务，但是调用链可能已经到了最后一步，假设这个tm调用了10个微服务，那么在AT下已经锁定了非常多的数据，而默认的timeoutrollback的时间是60秒，tm的宕机会导致数据被锁定60秒不可用，这是比较恶劣的
解决方案：
1.通过绑定channelInactive的事件处理，并需要增加开关，因为有可能由于网络问题误判，导致回滚了事务，所以默认开关应该是关闭的，不提前回滚全局事务
2.拥有提前rollback权限的是begin的那个tc，其余tc即便感知到tm断线，也不应该进行rollback，避免出现同时进行rollback或者其中一台tc与tm断开连接导致的误判，所以粒度可以控制在begin的tc上
Ⅱ. Does this pull request fix one issue?
#4422
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #4475 (9306250) into develop (01a1ff9) will decrease coverage by 0.08%.
The diff coverage is 19.51%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##             develop    #4475      +/-   ##
=============================================
- Coverage      48.83%   48.76%   -0.08%
+ Complexity      4182     4176       -6
=============================================
  Files            743      743
  Lines          26626    26654      +28
  Branches        3333     3328       -5
=============================================
- Hits           13002    12997       -5
- Misses         12219    12254      +35
+ Partials        1405     1403       -2

Impacted Files
Coverage Δ

...c/main/java/io/seata/common/ConfigurationKeys.java
0.00% <ø> (ø)

...n/src/main/java/io/seata/common/DefaultValues.java
0.00% <ø> (ø)

...ta/core/rpc/netty/AbstractNettyRemotingServer.java
0.00% <0.00%> (ø)

...o/seata/server/coordinator/DefaultCoordinator.java
45.41% <0.00%> (-0.80%)
:arrow_down:

...oconfigure/properties/server/ServerProperties.java
27.50% <25.00%> (-0.63%)
:arrow_down:

...re/src/main/java/io/seata/core/rpc/RpcContext.java
44.44% <85.71%> (+3.90%)
:arrow_up:

...er/src/main/java/io/seata/server/ServerRunner.java
50.00% <0.00%> (-15.39%)
:arrow_down:

...torage/file/store/FileTransactionStoreManager.java
59.16% <0.00%> (-1.29%)
:arrow_down:

...very/registry/zk/ZookeeperRegisterServiceImpl.java
61.02% <0.00%> (-0.74%)
:arrow_down:

...datasource/exec/mysql/MySQLUpdateJoinExecutor.java
77.07% <0.00%> (-0.57%)
:arrow_down:

... and 3 more

rollback转异步处理

Due to code conflicts and age, if you are still interested in participating in the community, please resubmit this pr to the 2.x branch after resolving the conflict.
由于代码冲突以及年代久远，如果你还有兴趣参与到社区，请解决完冲突后重新请提交这份pr至2.x分支中


feat: added the optionality to present cards in a single row with horizontal scroll, using swiper library.

Out of curiosity, why did you delete your branch and close the PR?

Created a new PR


[Suggestion] Add topic section named "Built with vue-iscroll-view" in readme

Hi, I have used your component in my own project.  The list page of my web app implements the smooth scrolling with vue-iscroll-view in vertical and horizontal direction. To show more live demos for the users and make them know more about what your component can achieve, I suggest that add
topic section named "Built with vue-iscroll-view" in readme.md, as does the bootstrap offcial website(http://getbootstrap.com/2.3.2/), and I will be able to add the QR code of my list page as a demo in this part.
I'm looking forward to your reply.

QR code & descriptions is unneeded, a list of entries is enough.

Hi, I have dropped the QR code and descriptions, the topic section named 'Built with vue-iscroll-view' still remains.


Debug Console's typeahead behavior deferens from conventinal

Hi, this one if form UX department.
Behavior of typeahead/autocomplete behavior if debug console is different from behavior of intellisense in vscode or console typeahead in the browser. It requires user to hit Tab to complete the suggestion and then enter to accept, while everywhere else enter (along with tab) works to accept/complete the suggestion. In the browser second 'Enter' hit causes execution.
Would be great to sync the interactions, because ... muscle memory :)

Thank you for reporting this issue/request. I have filed a feature request on the team that owns the "Debug Console". Thanks!


Investigate git-fast-import exit code 1

It looks like imports that don't actually import anything might result in exit code 1. I need to verify where that's coming from, what it means (since it's not in the manpage), and then special case as appropriate.

It looks like this is actually the importer not recognising previously written commits in some cases:
warning: Not updating refs/heads/tags/head-version (new tip bd3f831f0d63cfcaa78c3bb5c49d7f7b5c45958a does not contain 17b10b30edf4628feea7363e081cba478a7f2085)
warning: Not updating refs/tags/head-version (new tip bd3f831f0d63cfcaa78c3bb5c49d7f7b5c45958a does not contain 17b10b30edf4628feea7363e081cba478a7f2085)
warning: Not updating refs/heads/tags/branch-b-version (new tip a84898ef39b6b72fa78e0694db9464c90bfe2e48 does not contain d906e3158bc715e40983b1328f3b91a5bf2fd3cc)
warning: Not updating refs/tags/branch-b-version (new tip a84898ef39b6b72fa78e0694db9464c90bfe2e48 does not contain d906e3158bc715e40983b1328f3b91a5bf2fd3cc)

Specifically, the problem here is the fake commits we create for tags: we shouldn't recreate them if they haven't changed, and if they have, then we need to move forward rather than tag an unrelated commit.

Fixed in #26.


add shorthand functions for serialization

to facilitate serialization and deserialization of models and collections of models, we're adding static helper functions.
More details to be found at https://github.com/microsoft/kiota/issues/3406
For serialization we need:

Serialize(contentType, model): string
Serialize(contentType, model): stream
SerializeCollection(contentType, models): string
SerializeCollection(contentType, models): stream
Serialize(model): stream (maps to same one passing the json content type as a constant)
Serialize(model): string (same)
Serialize(models): stream (same)
Serialize(models): string (same)

Note: if converting from stream to string is trivial we can ommit the string overloads
Note: if another parameter for the serialization method needs to be added, feel free to do so
Note: if both a string and and stream method need to be added, but can't have the same name, name the string methods with AsString suffix
Note: if the Json methods and the ones accepting the same content type can't have the same namde/would need to be aliased in the consuming code to avoid conflicts, as a ToJsonSuffix (full convention with string SerializeCollectionToJsonAsString)

For deserialization we need:

Deserialize(contentType, stream, createTFromDiscriminatorMethod): T
Deserialize(contentType, string, createTFromDiscriminatorMethod): T
Deserialize(contentType, stream): T (uses reflection, only if possible, calls into the previous one)
Deserialize(contentType, string): T (same)
DeserializeCollection(contentType, stream, createCallback): T[]
DeserializeCollection(contentType, string, createCallback): T[]
reflection version x2
Json equivalent with constant for all the previous

Note: the same notes as serialization apply
Note: if the collection and single methods can have the same name, make them same

Customers that could benefit from this
https://github.com/microsoftgraph/msgraph-sdk-php/issues/1556
https://github.com/microsoftgraph/msgraph-sdk-php/issues/1471


For the TaxiBJ

Hi
It seems that TaxiBJ could not download from the url
Can you please provide other ways to download this dataset?
Thanks a lot

Hi
It seems that TaxiBJ could not download from the url
Can you please provide other ways to download this dataset?
Thanks a lot

I also find that the official url of TaxiBJ is unavailable.  But I have no right to re-release this dataset due to copyright issues.
You can contact the authors of TaxiBJ.

Thanks a lot anyway!
------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2020年7月1日(星期三) 上午10:09
收件人<EMAIL_ADDRESS>抄送: "MrZQ"<1015204805<EMAIL_ADDRESS>主题: Re: [liulingbo918/ATFM] For the TaxiBJ (#2)
Hi
It seems that TaxiBJ could not download from the url
Can you please provide other ways to download this dataset?
Thanks a lot
I also find that the official url of TaxiBJ is unavailable.  But I have no right to re-release this dataset due to copyright issues.
You can contact the authors of TaxiBJ.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


vite-plugin-theme-preprocessor and ElementPlus

I'm not sure if this is an issue of the library but I'm having problems when using this with ElementPlus.
Example repository: https://github.com/naftis/element-plus-theming (based on this: https://github.com/element-plus/element-plus-vite-starter)
Error: Some CSS variables don't get loaded

How should I configure ElementPlus to work with this library? I load this file in multipleScopeVars: https://github.com/naftis/element-plus-theming/blob/master/src/styles/theme/default.scss with @forward but all of the CSS variables don't load.
It seems like every variable changed in @forward seem to get unloaded.

Thanks for your feedback.
I fixed it in @zougt/some-loader-utils v1.3.5,Please reinstall @zougt/vite-plugin-theme-preprocessor.

Hello, example repository: https://github.com/naftis/element-plus-theming
For some reason it doesn't work properly when changing the theme here:

The background should go black, and the "Tag 1" has undefined CSS variables 🤔

Thank you very much for help.

You should use toggleTheme on this way:

To

@GitOfZGT Thank you :)
https://goofy-booth-e1e803.netlify.app/ the element-plus primary color works in the navigation:

There is another issue though, the Button colors don't change to pink:

It seems to add the variables to style -attribute:

Do you think this is element-plus issue or vite-plugin-theme-preprocessor issue?

element-plus issue or vite-plugin-theme-preprocessor issue?

I also found this problem some time ago, that is element-plus did, theme plugin can not change it, see https://github.com/element-plus/element-plus/issues/4263


Fix unmatched parenthesis in doc

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[ ] C++ Guidelines
[ ] Doxygen docs
[ ] Unit tests
[ ] No unwanted commits/changes
[ ] Descriptive title/description

[ ] PR is single purpose
[ ] Related issue listed

[ ] Comments in source
[ ] No typos
[ ] Update changelog
[ ] Not work-in-progress
[ ] External references or docs updated
[ ] Self review of PR done
[ ] Any breaking changes?

I am curious, how did you catch this? Is our migration guide otherwise functionally correct?

I was reported by one of our customers.

/check-enforcer override


Quick.Config.Json

JSON string is incorrect when saved to disk
is missing "}"
�{
"UserName": "",
"Password": "",
"UseBiometrics": false
from this class:
TAppConfig = Class(TAppConfigJson)
private
FUsername:String;
FPassword:String;
FUseBiometrics:Boolean;
published
property UserName:String read FUsername write FUsername;
property Password:String read FPassword write FPassword;
property UseBiometrics:Boolean read FUseBiometrics write FUseBiometrics;
end;

Sorry, i've tested and works ok. What version of QuickLib are you using? Git Latest version or Delphinus repository  or GetIt repository?


Straight throws a "Could not find package bind-key ..." error when trying to install use-package

What's wrong
I tried installing use-package with straight.el, but i get an error: "Could not find package bind-key..."
(straight-use-package 'god-mode) works, but not (straight-use-package 'use-package)
I've also previously installed use-package from melpa with package.el without any problem.
I'm testing straight.el on an emacs -q instance on windows 10
Directions to reproduce
launch emacs with emacs -q
execute this in scratch:
(defvar bootstrap-version)
(let ((bootstrap-file
       (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
      (bootstrap-version 5))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously
         "https://raw.githubusercontent.com/raxod502/straight.el/develop/install.el"
         'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))
(straight-use-package 'use-package)

complete buffer output report of straight-bug-report
(straight-bug-report
  :pre-bootstrap
  (setq straight-repository-branch "develop")
  :post-bootstrap
  (straight-use-package 'use-package)
  (with-current-buffer straight-process-buffer
    (message "%s" (buffer-substring-no-properties (point-min) (point-max)))))
```

Test Case
(straight-bug-report
  :pre-bootstrap
  (setq straight-repository-branch "develop")
  :post-bootstrap
  (straight-use-package 'use-package)
  (with-current-buffer straight-process-buffer
    (message "%s"
	     (buffer-substring-no-properties
	      (point-min)
	      (point-max)))))

Test run at: 2021-10-11 17:17:13
system-type: windows-nt
straight-version: prerelease Uknown version. See *straight-process*
emacs-version: GNU Emacs 27.2 (build 1, x86_64-w64-mingw32) of 2021-03-26

Output
Bootstrapping straight.el...
Bootstrapping straight.el...done

Test run with version: prerelease
 Uknown version. See *straight-process*

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/"
$ "git" "clone" "--origin" "origin" "--no-checkout" "https://github.com/melpa/melpa.git" "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/melpa/" "--no-single-branch"

Cloning into 'c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/melpa'...

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/melpa/"
$ "git" "branch" "-r"

  origin/HEAD -> origin/master
  origin/faq
  origin/make-improvements
  origin/make-recipe-fail
  origin/master
  origin/tarsius-pending
  origin/update-cask-ci
  origin/vertico

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/melpa/"
$ "git" "checkout" "-B" "master" "origin/master"

Branch 'master' set up to track remote branch 'master' from 'origin'.
Your branch is up to date with 'origin/master'.
Reset branch 'master'

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/melpa/"
$ "git" "submodule" "update" "--init" "--recursive"

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/"
$ "git" "clone" "--origin" "origin" "--no-checkout" "https://github.com/emacs-straight/gnu-elpa-mirror.git" "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/gnu-elpa-mirror/" "--no-single-branch"

Cloning into 'c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/gnu-elpa-mirror'...

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/gnu-elpa-mirror/"
$ "git" "branch" "-r"

  origin/HEAD -> origin/master
  origin/master

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/gnu-elpa-mirror/"
$ "git" "checkout" "-B" "master" "origin/master"

Branch 'master' set up to track remote branch 'master' from 'origin'.
Your branch is up to date with 'origin/master'.
Reset branch 'master'

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/gnu-elpa-mirror/"
$ "git" "submodule" "update" "--init" "--recursive"

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/"
$ "git" "clone" "--origin" "origin" "--no-checkout" "https://github.com/dimitri/el-get.git" "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/el-get/" "--no-single-branch"

Cloning into 'c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/el-get'...

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/el-get/"
$ "git" "branch" "-r"

  origin/2.stable
  origin/3.stable
  origin/4.stable
  origin/HEAD -> origin/master
  origin/jd/methods-autoload
  origin/master
  origin/next
  origin/refactoring

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/el-get/"
$ "git" "checkout" "-B" "master" "origin/master"

Branch 'master' set up to track remote branch 'master' from 'origin'.
Your branch is up to date with 'origin/master'.
Reset branch 'master'

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/el-get/"
$ "git" "submodule" "update" "--init" "--recursive"

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/"
$ "git" "clone" "--origin" "origin" "--no-checkout" "https://github.com/emacs-straight/emacsmirror-mirror.git" "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/emacsmirror-mirror/" "--no-single-branch"

Cloning into 'c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/emacsmirror-mirror'...

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/emacsmirror-mirror/"
$ "git" "branch" "-r"

  origin/HEAD -> origin/masteRebuilding all packages due to build cache schema change
Looking for gnu-elpa-mirror recipe -> Cloning melpa...
Looking for gnu-elpa-mirror recipe -> Cloning melpa...done
Looking for emacsmirror-mirror recipe -> Cloning gnu-elpa-mirror...
Looking for emacsmirror-mirror recipe -> Cloning gnu-elpa-mirror...done
Looking for emacsmirror-mirror recipe -> Cloning el-get...
Looking for emacsmirror-mirror recipe -> Cloning el-get...done
Looking for straight recipe -> Cloning emacsmirror-mirror...
Looking for straight recipe -> Cloning emacsmirror-mirror...done
Building straight...
Building straight...done
Cloning use-package...
Cloning use-package...done
Building use-package...
Building use-package -> Building bind-key...
Building use-package -> Building bind-key...done
Building use-package...
Building use-package...done
r
  origin/master

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/emacsmirror-mirror/"
$ "git" "checkout" "-B" "master" "origin/master"

Branch 'master' set up to track remote branch 'master' from 'origin'.
Your branch is up to date with 'origin/master'.
Reset branch 'master'

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/emacsmirror-mirror/"
$ "git" "submodule" "update" "--init" "--recursive"

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/build/straight/"
$ "git" "show" "-s" ^"--format=^%d ^%h ^%cs^"

fatal: not a git repository (or any of the parent directories): .git

[Return code: 128]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/"
$ "git" "clone" "--origin" "origin" "--no-checkout" "https://github.com/jwiegley/use-package.git" "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/use-package/" "--no-single-branch"

Cloning into 'c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/use-package'...

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/use-package/"
$ "git" "branch" "-r"

  origin/HEAD -> origin/master
  origin/gh-pages
  origin/master
  origin/next
  origin/revert-617-lexical-bindings
  origin/revert-645-fix-report
  origin/split-bind-key

[Return code: 0]

$ cd "c:/Users/user/AppData/Local/Temp/straight.el-test-iZb2iS/straight/repos/use-package/"
$ "git" "checkout" "-B" "master" "origin/master"

Branch 'master' set up to track remote branch 'master' from 'origin'.
Your branch is up to date with 'origin/master'.
 Updating recipe r...")
  signal(error ("Could not find package bind-key. Updating recipe r..."))
  error("Could not find package %S. Updating recipe reposit..."  I'm guessing this has to do with the lack of symlinks on Windows. That's not our main issue, though.
Everything else looks like it is succeeding, though.
Can you show the directory listing for your straight/build/ direrctory?


GraphicalModel::addVariable uses size_t instead of IndexType

Here, IndexType should be used instead of size_t. Cannot use GraphicalModel::addVariable when my IndexType and LabelType is int instead.
Also, there is generally a mismatch between the argument types of the graphical model space functions and the graphical model functions. The type of the GraphicalModel::addVariable argument is IndexType, but in case of DiscreteSpace::addVariable it is LabelType. Both are usually identical, but the existence of different space template parameters should not require them to be identical.

fixed. Thanks for pointing this out.


Ingress Default Backend doesn't know JSON

Implement a default backend for the nginx-ingress that speaks html and json. This is required for various clients to be able to detect and report an error.

This might do the trick https://github.com/kubernetes/ingress-nginx/tree/master/images/custom-error-pages. Gets the format from the request and responds accordingly.

Replaced by custom backend that knows JSON and HTTP. Backend will respond accordingly. Which errors are handled by the backend has to be configured in the ingress cm. Done this for 404, 500 errors. Can we close the issue?

We want this in all kubernikus control planes. Has this already happend? /cc @auhlig

Just admin cluster for now. I'll roll this out to the other regions today and close this issue afterwards.


not working, please help

You have to install xmpp, install the requirements first.

Execute the setup.py then it will install it all.


fix: do not close gocql.iter() on error

When gocql.MapExecuteBatchCAS returns an error, the iterator can be set to nil. In that case, defer iter.Close() can cause an nil pointer deference (panic). This patch fixes this bug.

Coverage increased (+0.05%) to 67.64% when pulling c569bb0f3d3fd33c24c6e7c556775bf1bbd42bb2 on gocql into e21f25622ad89920808d7f6a6007c3ee16bb87ad on master.

Coverage increased (+0.05%) to 67.64% when pulling c569bb0f3d3fd33c24c6e7c556775bf1bbd42bb2 on gocql into e21f25622ad89920808d7f6a6007c3ee16bb87ad on master.


mavlink: Trigger reconnection from receiver_loop if any recv error happens

Fixes #305

Tested. I killed the ardupilot manager on BlueOS, and we can see here that the error occurred and the task that tried the reconnection was the receiver:
2023-11-28T23:59:24.738986Z DEBUG                                     MavlinkCamera-0 ThreadId(25) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:25.740069Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:26.740951Z DEBUG                                     MavlinkCamera-0 ThreadId(25) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:27.741779Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:28.743703Z DEBUG                                     MavlinkCamera-0 ThreadId(25) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:29.744966Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:30.568338Z ERROR                                         MavReceiver ThreadId(03) receiver_loop: src/mavlink/manager.rs:94: Failed receiving message from Mavlink Connection: Io(Error { kind: UnexpectedEof, message: "failed to fill whole buffer" })
2023-11-28T23:59:30.746592Z DEBUG                                     MavlinkCamera-0 ThreadId(25) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:31.568675Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:31.572556Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:31.747955Z DEBUG                                     MavlinkCamera-0 ThreadId(25) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:32.572827Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:32.576659Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:32.749223Z DEBUG                                     MavlinkCamera-0 ThreadId(25) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:33.576867Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:33.580625Z  INFO                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:212: Successfully connected
2023-11-28T23:59:33.750502Z DEBUG                                     MavlinkCamera-0 ThreadId(25) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:34.750962Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:35.752510Z DEBUG                                     MavlinkCamera-0 ThreadId(25) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:36.081611Z ERROR                                         MavReceiver ThreadId(03) receiver_loop: src/mavlink/manager.rs:94: Failed receiving message from Mavlink Connection: Io(Error { kind: UnexpectedEof, message: "failed to fill whole buffer" })
2023-11-28T23:59:36.753488Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:37.081911Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:37.085629Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:37.753809Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:38.085818Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:38.089590Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:38.755189Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:39.089767Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:39.093509Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:39.756642Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:40.093702Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:40.097620Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:40.758044Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:41.097834Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:41.101626Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:41.759417Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:42.101815Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:42.105617Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:42.760833Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:43.105822Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:43.109576Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:43.762169Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:44.109769Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:44.113592Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:44.763659Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:45.113772Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:45.117495Z ERROR                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:216: Failed to connect, trying again in one second. Reason: Os {
    code: 111,
    kind: ConnectionRefused,
    message: "Connection refused",
}.
2023-11-28T23:59:45.765052Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:46.117649Z DEBUG                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:208: Connecting...
2023-11-28T23:59:46.123146Z  INFO                                         MavReceiver ThreadId(03) receiver_loop:connect{address="tcpout:<IP_ADDRESS>:5777"}: src/mavlink/manager.rs:212: Successfully connected
2023-11-28T23:59:46.766141Z DEBUG                                     MavlinkCamera-0 ThreadId(25) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:47.767342Z DEBUG                                     MavlinkCamera-1 ThreadId(26) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent
2023-11-28T23:59:48.768509Z DEBUG                                     MavlinkCamera-0 ThreadId(25) heartbeat_loop{component_id=100}: src/mavlink/mavlink_camera.rs:159: Heartbeat sent


fix: remove module cache in sandbox plugin

This module cache came up as problematic with the presence of multiple versions of a package in a given dependency closure. In our case, we have minipass 4.2.8 and 7.0.4 (required by glob 9.3.2 and path-scurry 1.10.1 respectively) in a given closure. These are strictly not compatible with each other, so resolving minipass from glob should yield 4.2.8 and from path-scurry should yield 7.0.4. The module cache however results in everything getting the same version, as we are keying only by name sans version.
Log output I added to illustrate the point:
DEBUG NOAH BEGIN:
        IMPORTER<EMAIL_ADDRESS>DEBUG NOAH RETURN RESOLVE:
        IMPORTER<EMAIL_ADDRESS>        RESOLVED<EMAIL_ADDRESS>DEBUG NOAH BEGIN:
        IMPORTER<EMAIL_ADDRESS>DEBUG NOAH RETURN WOULD-BE CACHE:
        IMPORTER<EMAIL_ADDRESS>        RESOLVED<EMAIL_ADDRESS>DEBUG NOAH RETURN RESOLVE:
        IMPORTER<EMAIL_ADDRESS>        RESOLVED<EMAIL_ADDRESS>
from the following diff to 0.19.0:
diff --git a/esbuild/private/plugins/bazel-sandbox.js b/esbuild/private/plugins/bazel-sandbox.js
index 84f0921..32ccaa7 100644
--- a/esbuild/private/plugins/bazel-sandbox.js
+++ b/esbuild/private/plugins/bazel-sandbox.js
@@ -28,15 +28,27 @@ function bazelSandboxPlugin() {
           }
           otherOptions.pluginData.executedSandboxPlugin = true

+          if (importPath === 'minipass') {
+            console.error(`DEBUG NOAH BEGIN: \n\tIMPORTER ${otherOptions.importer}`)
+          }
+
           // Prevent us from loading different forms of a module (CJS vs ESM).
           if (pkgImport.test(importPath)) {
-            if (!moduleCache.has(importPath)) {
+            const isNotCached = !moduleCache.has(importPath)
+            if (isNotCached) {
               moduleCache.set(
                 importPath,
                 resolveInExecroot(build, importPath, otherOptions)
               )
             }
-            return await moduleCache.get(importPath)
+            const res = await moduleCache.get(importPath)
+            if (importPath === 'minipass' && !isNotCached) {
+              console.error(`DEBUG NOAH RETURN WOULD-BE CACHE: \n\tIMPORTER ${otherOptions.importer}\n\tRESOLVED ${res.path}`)
+            }
+            // only for log output clarity
+            if (isNotCached) {
+              return res
+            }
           }
           return await resolveInExecroot(build, importPath, otherOptions)
         }
@@ -62,6 +74,14 @@ async function resolveInExecroot(build, importPath, otherOptions) {
     return result
   }

+  const res = correctImportPath(result, otherOptions, false)
+  if (importPath ==='minipass') {
+    console.error(`DEBUG NOAH RETURN RESOLVE: \n\tIMPORTER ${otherOptions.importer}\n\tRESOLVED ${res.path}`)
+  }
+  return res
+}
+
+function correctImportPath(result, otherOptions, firstEntry) {
   // If esbuild attempts to leave the execroot, map the path back into the execroot.
   if (!result.path.startsWith(execroot)) {
     // If it tried to leave bazel-bin, error out completely.

The one thing Im unsure about is the comment about avoiding loading both ESM and CJS, Im not sure if theres an easy reproducer somewhere or a test case in this repo that covers it cc @vpanta

Test plan

Manual testing; please provide instructions so we can reproduce:

This issue was being worked on as part of a series of issues that cropped up when upgrading to 0.19.0, including https://github.com/aspect-build/rules_esbuild/pull/201. As such, the manual testing I did was the same as mentioned over there, except for a different commit: github.com/sourcegraph/sourcegraph/commit/51503969643612665485aa8e6e150566b6863d54 with target //client/web/dev:esbuild-config-production_bundle

Have you been able to reproduce this in a test at all? Or any understandable way in your repo that you can describe here?

@vpanta can you take a look at this and maybe try it out? I believe you had a reason for this cache originally in https://github.com/aspect-build/rules_esbuild/pull/160

So just for some context, this plugin was originally something I created internally for Fullstory and decided to upstream. The module cache was added because certain modules were getting dual-loaded by esbuild depending on their import-semantics: if it came from a require, it would load the CJS version of the module, and if it was from an import statement, it would load the ESM version of the module. If I remember correctly, this was at best causing bloat in our bundle but at worst causing full breakages (when something like react would double-load). Generally FWICT it was caused by certain modules having only one form and then, when transitively loading the module A via module B's lone CJS form, module A would be duplicated as CJS.
I don't think I have explicit tests for this case, as it was something inherent to our internal build.
Take all this with a grain of salt, YMMV. I'm not sure of the best way to approach this to be honest, because your case is perfectly valid.

Thanks for the reply 🙏
Copying from my conversation with Jason:

on what I believe is the last error Im coming across, Im getting a quite confusing one:

 ✘ [ERROR] Could not read from file<EMAIL_ADDRESS>
     node_modules/.aspect_rules_js/object-inspect@1.13.1/node_modules/object-inspect/index.js:68:26:
       68 │ var utilInspect = require('./util.inspect');
          ╵                           ~~~~~~~~~~~~~~~~

The weird part is that<EMAIL_ADDRESS>(with a .js suffix) does exist, and adding the following to the bazel-sandbox plugin makes the build succeed

           const res = await resolveInExecroot(build, importPath, otherOptions)
           if (importPath.includes('util.inspect')) {
             res.path = res.path + ".js"
           }

No idea how to explain this

Does this sound similar to the issue you came across that you solved with the module cache? @vpanta

First off, sorry, I saw this question and completely forgot about it.
But yeah, that actually looks like some kind of ESM/CJS incompatibility? Because ESM requires file extensions but CJS can appropriately assume them. I dunno why a require call would fail without a file extension :(

I think I'd like to merge this then. @Strum355 did you have any thoughts on a test for this or is that not worth your time right now?


Replace jq with jq-in-the-browser

Codecov Report

Merging #30 into master will increase coverage by 1.57%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #30      +/-   ##
========================================
+ Coverage   98.42%   100%   +1.57%
========================================
  Files          16     16
  Lines         127    127
========================================
+ Hits          125    127       +2
+ Misses          2      0       -2

Impacted Files
Coverage Δ

src/jq-web.js
100% <100%> (+66.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbeea16...9a239c5. Read the comment docs.


Can we add Copyright section in footer of part documentation page.

Is your feature request related to a problem? Please describe.
There is no Copyright section in the footer of the page.
Screeshot

Additional context
In this part would like to add.

@starrohan999 Thanks for raising this issue, but I think we have to first implement the footer and then we can do other things like footer.

Ok sure @atharvagadkari05  Sir

Please assign it to me


A port to zgui

anyway to port this to zgui ?
https://github.com/zxvnme/zgui

would be a fun project to take on if you have little coding experience

i can if someone walks me through it. i ready to learn and spend shit load of time with it. would be great if that port happens

I personally think imgui is amazing and with the customization options it has, it would be better to focus efforts elsewhere unless you really want zgui. I couldnt walk you through it in less than a couple hours.

Yes, it is possible, but you have to do it on your own.

https://github.com/danielkrupinski/Explit


Get longest common prefix

I want to segment a long string
Expect:
use patricia_tree::PatriciaMap;

let mut map = PatriciaMap::new();
map.insert("foo", 1);
map.insert("foobar", 2);
assert_eq!(map.get_longest_common_prefix("fo"), "fo");
assert_eq!(map.get_longest_common_prefix("fobaz"), "fo");

Current:
use patricia_tree::PatriciaMap;

let mut map = PatriciaMap::new();
map.insert("foo", 1);
map.insert("foobar", 2);
assert_eq!(map.get_longest_common_prefix("fo"), None);
assert_eq!(map.get_longest_common_prefix("fobaz"), None);
assert_eq!(map.get_longest_common_prefix("foo"), Some(("foo".as_bytes(), &1)));
assert_eq!(map.get_longest_common_prefix("fooba"), Some(("foo".as_bytes(), &1)));
assert_eq!(map.get_longest_common_prefix("foobar"), Some(("foobar".as_bytes(), &2)));
assert_eq!(map.get_longest_common_prefix("foobarbaz"), Some(("foobar".as_bytes(), &2)));

Thank you for creating this issue.
Unfortunately, I'm busy this week. I will see the detail and reply several days later.

Hi, I saw the issue detail.
The method name (get_longest_common_prefix()) may lead to misunderstandings, but the method description and example suggest, the current behaviour is the intended one.
I think that we need to implement a new method to archive the behaviour you want to do.
(If you are interested in implementing this method, your contribution would be welcomed.)

Thank you for taking the time to review my issue report and provide clarification. I want to contribute but I'm still a rust newbie.
Please don't feel any obligation, but if you happen to have some bandwidth to implement this, many users would find it useful.

It's acceptable to implement the method, but could you please explain its use case?
(I would like to know whether this method is truly helpful for users.)

I hope to use patricia_tree in an input method program to store a Chinese character encoding dictionary (because Chinese characters cannot be input directly with the keyboard), for example, "ni" means "你" and "hao" means "好". The user will not always enter the complete encoding, when the user only enters "nih", I hope to be able to split it into ["ni", "h"], and then I can query the encoding of the two words separately and output these two words.
I hope my explanation can make sense to you.

I see. Thank you for your explanation!


[Enhancement] Method rr(EventMeshMessage, long) throws alternative exception from catch block without history

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request

located at:
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPPubClient.java line 85
analysis and explanation:
This method catches an exception, and throws a different exception, without incorporating the original exception. Doing so hides the original source of the exception, making debugging and fixing these problems difficult.
Describe the solution you'd like
Print exception messages or use the logger to record exception messages.
Are you willing to submit PR?

[x] Yes I am willing to submit a PR!

I'd like to fix it.


Support u128/i128

Is the check for integer128 support still needed? It's supported since Rust 1.26.
Is it okay to have a dependency to serde just for serde::serde_if_integer128? Alternatives are to implement something similar in this crate, or provide it in "slog".

@dpc I inlined the serde build script/cfg-flag. Please review.


teacher model does not in eval mode?

https://github.com/facebookresearch/unbiased-teacher/blob/main/ubteacher/engine/trainer.py#L286
It seems that your teacher model does not freeze model weight and convert to eval mode？

I asked a similar question here the other day #47

Do you compare the experimental results of eval mode and training mode? I am experimenting on my data set, and there is probably a 2 point difference in results


Explore reversing the synch of patients to be initiated from REDCap instead of from the Helper.

If we can fire a webhook from REDCap upon every add of a record to the REDCap project, we can make the integration of REDCap and the Helper realtime.

REDCap team told us our REDCap instance won't support data entry triggers.

We can look into manual triggers. Redcap supports advanced link, that can initiate request to the Helper App

NU IT does not support this.


ODBC v0.5.2 is incompatible with DataFrames v0.11 and prevents a DataFrames upgrade to v0.11.

The master is compatible with the new DataFrames so I think they just need to tag a new release. In the meantime you can install and use the mater with Pkg.checkout("ODBC").


Persistance?

Where do I have to add a volume to not loose my data?

You should add a volume to elasticsearch: docker-compose.override.yml
version: '3.5'
services:
  elasticsearch:
    volumes:
      - ./data/es:/usr/share/elasticsearch/data


Fix accidently starting all onTaskType extensions when running any task; fixes #175821

This fixes issue #175821 by only starting extensions of the task's type when trying to reload task after a workspace save.
The original issue falsly is marked as closed, the bug itself isn't resolved; this PR fixes it for good.
To test them:

open vscode and manually install any extension that has an onTaskType activation event such as rust-lang.rust-analyzer.
create an new empty folder with nothing else than an package.json with following content:{
  "scripts": {
    "test": "echo 'sucessfull runned npm-task'"
  }
}

now press F1 and use Tasks: Run Task, select npm (to discover npm tasks) and run npm: test
vscode now also activates the rust extension which was previously not loaded; this is indicated by the new rust-analyzer item in the statusbar which only gets added once the extension is loaded

Does this also fix the issue where launch configs with prelaunchTask will enable everything as well?

It should; when testing with following configuration, no additional extensions are activated:

.vscode/task.json:{
    "version": "2.0.0",
    "tasks": [
  	  {
  		  "type": "npm",
  		  "script": "test",
  		  "group": "test",
  		  "problemMatcher": [],
  		  "label": "run 'npm: test'",
  	  }
    ]
}

.vscode/launch.json:{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Program",
            "skipFiles": [
                "<node_internals>/**"
            ],
            "program": "${workspaceFolder}/t.js",
            "preLaunchTask": "run 'npm: test'"
        }
    ]
}

I tried your above steps and am not seeing the extension get activated when I run an npm task (no status bar item). When I run a command from that extension, I do see it.
https://user-images.githubusercontent.com/29464607/228937058-f198fd3c-5db0-4d61-b578-b24d777704ef.mov

I see it work when I use a different extension with onTaskType though. Looks like they've removed that

Whoops, I forgot my own repro steps :D. It needs to be a preLaunchTask set to ${defaultBuildTask}, and then one of the tasks in tasks.json needs to have
"group": {
  "kind": "build",
  "isDefault": true
}

Even if it doesn't fix that case, this is still a good improvement!
(Also, I suppose for clarity: I do not work on VS Code despite the "Member" tag)

It needs to be a preLaunchTask set to ${defaultBuildTask}

Looked into it and it's not the task that is the problem; it's the variable: when launching, it first tries to resolve all variables present inside the config:
https://github.com/microsoft/vscode/blob/b9202b64081bb1267792a8d2d023e4c746ed0f73/src/vs/workbench/contrib/debug/browser/debugService.ts#L479
When i replace the line above with following code, it works:
let resolvedConfig = configByProviders;
resolvedConfig.preLaunchTask = 'run \'npm: test\'';

I think it's best to fix this issue in another PR, or should it better be included in this one?

Digged depper into this and it seems that the current behaviour regarding ${defaultBuildTask} is correct:
https://github.com/microsoft/vscode/blob/b9202b64081bb1267792a8d2d023e4c746ed0f73/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts#L305-L306
When resolving ${defaultBuildTask}, vscode needs to find all buildtasks first to then filter out the default ones; since all extensions can contribute tasks, all extensions need to be launched here.
I think it's best to discuss this behaviour and any possible change in this in a new issue.

Yes @Mai-Lapyst you are correct in your understanding and that is why I said in the original issue that the behavior was expected.


ShaderMask is broken.

Something like the following code used to work, and now no longer works.
This code should put a fading edge at the top of the block so the children fade away to the background color as they go under the mask.  Now the entire block goes away.  In my use case I see a chunk of area that is fully faded away that isn't faded away when just the shader mask is removed.
Future main() async =>
  runApp(new Container(
      decoration: new BoxDecoration(backgroundColor: new Color(0xFF808080)),
      child: new ShaderMask(
          shaderCallback: _createShader,
          child: new Block([
            _createColoredBox(0xFFFF0000),
            _createColoredBox(0xFF0FF000),
            _createColoredBox(0xFF0000FF),
            _createColoredBox(0xFFFFFF00)
          ]))));

Widget _createColoredBox(int hexColor) => new Container(
    height: 300.0,
    decoration: new BoxDecoration(backgroundColor: new Color(hexColor)));

// Fading edge colors need to be pure white with some value of alpha to properly fade the children.
ui.Shader _createShader(Rect bounds) => new LinearGradient(
    begin: Point.origin,
    end: new Point(0.0, 100.0),
    colors: [const Color(0x00FFFFFF), const Color(0xFFFFFFFF)],
    stops: [0.0, 1.0]).createShader();

This problem can also be demonstrated with the "Swipe Away" (card_collection.dart) widget example. Select "Let the sun shine" from the drawer:
android: I/flutter : -- EXCEPTION CAUGHT BY RENDERING LIBRARY -------------------------------
android: I/flutter : The following exception was raised during paint():
android: I/flutter : 'packages/flutter/src/rendering/object.dart': Failed assertion: line 330: '!needsCompositing' is not true.
android: I/flutter : The following RenderObject was being processed when the exception was fired:
android: I/flutter : RenderShaderMask
android: I/flutter : That RenderObject had the following owner:
android: I/flutter : ShaderMask ← Stack ← Padding ← DecoratedBox ← ⋯
android: I/flutter : Stack trace:
android: I/flutter : #0      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:27)
android: I/flutter : #1      PaintingContext.pushShaderMask (packages/flutter/src/rendering/object.dart:330)
android: I/flutter : #2      RenderShaderMask.paint (packages/flutter/src/rendering/proxy_box.dart:591)
android: I/flutter : #3      RenderObject._paintWithContext (packages/flutter/src/rendering/object.dart:1042)
android: I/flutter : #4      PaintingContext.paintChild (packages/flutter/src/rendering/object.dart:93)
android: I/flutter : #5      RenderBox&ContainerRenderObjectMixin&RenderBoxContainerDefaultsMixin.defaultPaint (packages/flutter/src/rendering/box.dart:819)
android: I/flutter : #6      RenderStack.paintStack (packages/flutter/src/rendering/stack.dart:428)
android: I/flutter : #7      RenderStackBase.paint (packages/flutter/src/rendering/stack.dart:383)

We've started using compositing more.  I don't think we can afford to have paint operations that the compositor doesn't understand anymore.

Step 1: https://github.com/flutter/engine/pull/2248


Too much gap between courses in Added Pane

Padding / gap needs to be adjusted

Should... be fixed by #702


Docs.MS Release Updates for azure-ai-formrecognizer

Update docs metadata and targeting for release of azure-ai-formrecognizer

Docs Build status updates of commit 2936be6:
:clock10: Full build: the average full build time is 83 min(s) 42 sec(s), this is based on the last 695 build(s) for this repository.


Use available validator image instead of pulling for AWS

Attempt to use an image that's already available in the VM rather than trying to pulling an image no matter what. This has the net result of always using the image that's already available for AWS.
What does this PR do? / Related Issues / Jira
This PR attempts to minimize the amount of network egress calls the AMI needs to make before running its checks. In OSD-16098, it was noticed that docker pull was timing out due to a missing proxy configuration. Instead of solving it directly (as importing a custom trust bundle for docker to trust is not trivial), this PR reorganizes the script such that it attempts to use the pre-pulled image first.
Logs
These three failures are "expected" for now and should be fixed by the new set of AMIs that come from OSD-16171
System log:
USERDATA BEGIN
ff90d2cf6dd20607fefb21677668764a175de1103978b71b290f5e2a6c3450a9
Using IMAGE: ff90d2cf6dd2
Validating tagging.us-east-1.amazonaws.com:80
Validating registry.redhat.io:443
Validating quay.io:443
Validating sso.redhat.com:443
Validating sso.redhat.com:80
Validating pull.q1w2.quay.rhcloud.com:443
Validating openshift.org:443
Validating console.redhat.com:443
Validating console.redhat.com:80
Validating quay-registry.s3.amazonaws.com:443
Validating cert-api.access.redhat.com:443
Validating api.access.redhat.com:443
Validating infogw.api.openshift.com:443
Validating mirror.openshift.com:443
Validating api.openshift.com:443
Validating cart-rhcos-ci.s3.amazonaws.com:443
Validating registry.access.redhat.com:443
Validating ocm-quay-production-s3.s3.amazonaws.com:443
Validating quayio-production-s3.s3.amazonaws.com:443
Validating ec2.amazonaws.com:443
Validating iam.amazonaws.com:443
Validating route53.amazonaws.com:443
Validating sts.amazonaws.com:443
Validating events.amazonaws.com:443
Validating events.pagerduty.com:443
Validating api.deadmanssnitch.com:443
Validating nosnch.in:443
Validating inputs1.osdsecuritylogs.splunkcloud.com:9997
Validating http-inputs-osdsecuritylogs.splunkcloud.com:443
Validating observatorium.api.openshift.com:443
Validating ec2.us-east-1.amazonaws.com:443
Validating elasticloadbalancing.us-east-1.amazonaws.com:443
Validating servicequotas.us-east-1.amazonaws.com:443
Validating servicequotas.us-east-1.amazonaws.com:80
Validating tagging.us-east-1.amazonaws.com:443

Not all endpoints were reachable:
Unable to reach events.amazonaws.com:443 within specified timeout after 3 retries: Get "https://events.amazonaws.com": dial tcp: lookup events.amazonaws.com on <IP_ADDRESS>:53: no such host
Unable to reach tagging.us-east-1.amazonaws.com:80 within specified timeout after 3 retries: Get "http://tagging.us-east-1.amazonaws.com": dial tcp <IP_ADDRESS>:80: connect: connection refused
Unable to reach servicequotas.us-east-1.amazonaws.com:80 within specified timeout after 3 retries: Get "http://servicequotas.us-east-1.amazonaws.com": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
USERDATA END

❯ ~/git/openshift/osd-network-verifier/osd-network-verifier egress --subnet-id subnet-02537289237936c1c --security-group-id sg-094091624bada491b --region us-east-1
Using region: us-east-1
Created instance with ID: i-068fbf16f2e95c92b
Summary:
printing out failures:
 - egressURL error: events.amazonaws.com:443
 - egressURL error: tagging.us-east-1.amazonaws.com:80
 - egressURL error: servicequotas.us-east-1.amazonaws.com:80

printing out exceptions preventing the verifier from running the specific test:
printing out errors faced during the execution:
Failure!

Codecov Report

Merging #184 (01de391) into main (ee383d0) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   10.06%   10.04%   -0.02%
==========================================
  Files          17       17
  Lines        1143     1145       +2
==========================================
  Hits          115      115
- Misses       1018     1020       +2
  Partials       10       10

Impacted Files
Coverage Δ

pkg/verifier/aws/aws_verifier.go
20.71% <ø> (ø)

pkg/verifier/aws/entry_point.go
0.00% <0.00%> (ø)

pkg/verifier/gcp/entry_point.go
0.00% <0.00%> (ø)

pkg/verifier/gcp/gcp_verifier.go
0.00% <ø> (ø)

/hold
/lgtm

/unhold


Added the spec under spec/issues for the issue id 730

Added the spec to check the issue #730 related to swagger doc not getting generated when one grape API app is mounted in another grape API app.

Coverage remained the same at 99.213% when pulling c484adb503695b2bf57b673f3a37ecc59cf2c394 on bhaskarshankarling:spec_for_the_issue_730 into 02ede028a3cfe6facc17207af4071f76ba3df698 on ruby-grape:master.

Coverage remained the same at 99.213% when pulling c484adb503695b2bf57b673f3a37ecc59cf2c394 on bhaskarshankarling:spec_for_the_issue_730 into 02ede028a3cfe6facc17207af4071f76ba3df698 on ruby-grape:master.

Coverage remained the same at 99.213% when pulling c484adb503695b2bf57b673f3a37ecc59cf2c394 on bhaskarshankarling:spec_for_the_issue_730 into 02ede028a3cfe6facc17207af4071f76ba3df698 on ruby-grape:master.

Coverage remained the same at 99.213% when pulling c484adb503695b2bf57b673f3a37ecc59cf2c394 on bhaskarshankarling:spec_for_the_issue_730 into 02ede028a3cfe6facc17207af4071f76ba3df698 on ruby-grape:master.

Coverage remained the same at 99.213% when pulling c484adb503695b2bf57b673f3a37ecc59cf2c394 on bhaskarshankarling:spec_for_the_issue_730 into 02ede028a3cfe6facc17207af4071f76ba3df698 on ruby-grape:master.

mmh … shouldn't it be fail?

mmh … shouldn't it be fail?

Yes, I am also wondering why it passed. Since I am new to CI and everything, I thought it is showing green only for removing offences pointed out by rubocop. The second spec is still failing at my local.

mmh … shouldn't it be fail?
https://github.com/ruby-grape/grape-swagger/pull/735#issuecomment-448542399. What about this previous comment generated by bot, it says that it appreciates the failing spec, that means the spec is failing.

mmh … shouldn't it be fail?

Please let me know if I have done anything wrong in the specs.