Figaro not loading config in application.rb for Rails v4.2

Just updated to Rails v4.2.0, and noticed that Figaro is no longer setting the environment in application.rb as it used to in Rails v4.1:
module MyApp
  class Application < Rails::Application
     ENV['SET_BY_FIGARO'] # => nil
     Figaro.env.SET_BY_FIGARO # => nil
  end
end

Everything still works from an initializer though... although I do need access to the values sooner to use in the config files.

Would you be willing to contribute a failing test?

I'll give it a go. I managed to fix it by adding Figaro.load to the top of the class Application... bit.

Hello. @laserlemon , I am having the same problem with rails 4.2, where none of my environment variables were getting set. I added Figaro.load to the top of my application class as well and it worked. No require 'figaro' needed like in some of the other troubleshooting threads I saw.

There's already a test that asserts that ENV is set immediately after the Rails application is defined, exactly as is described in the initial code example. This test is run against Rails 4.2. Until somebody can produce a failing test, I'm not able to reproduce the problem. @fny, any luck with a test?

Would it be enough if I set up a sample rails application?
On Tue, Apr 21, 2015 at 10:24 PM, Steve Richert<EMAIL_ADDRESS>wrote:

There's already a test
https://github.com/laserlemon/figaro/blob/7d950c1c100f93142373ed9a1ef00868fa9d30a5/spec/rails_spec.rb#L40-L48
that asserts that ENV is set immediately after the Rails application is
defined, exactly as is described in the initial code example. This test is
run against Rails 4.2. Until somebody can produce a failing test, I'm not
able to reproduce the problem. @fny https://github.com/fny, any luck
with a test?
—
Reply to this email directly or view it on GitHub
https://github.com/laserlemon/figaro/issues/186#issuecomment-95000290.

It would be a start. The test suite actually generates a brand new Rails 4.2 app and then modifies it in different ways to test its behavior, so it'd still be best if you could write/commit a failing test.

I'm actually not sure about where to put this in the tests, but it's simple to reproduce:
Here's the repo: https://github.com/fny/figaro_fail/commits/master
With a vanilla Rails 4.2 app (rails new figaro_fail) and a basic Figaro setup (say we've got a config key "hello: howdy"), the following breaks upon running the app: https://github.com/fny/figaro_fail/commit/6f738b47567dc23a5bacccad8a164ee39f468225
And it's easily fixed by adding this line:
https://github.com/fny/figaro_fail/commit/97e2f116424131d1e5f7cf36651267885fef7813

Okay, thanks. I just did a little digging and here's what I came up with…
My test works because this is the code I test to ensure configuration is available immediately following application inheritance:
module Example
  class Application < Rails::Application
    config.foo = ENV["foo"]
  end
end

This works. I'll get to why.
On the other hand, this code will not work:
module Example
  class Application < Rails::Application
    puts ENV["foo"]
  end
end

The reason the first example works and the second doesn't is because the before_configuration hook (the earliest hook available) that Figaro ties into doesn't run until the new instance of the Example::Application is initialized. Initializing the singleton application instance happens when the instance method is called on the Example::Application class. It just so happens that the config class method delegates to instance.
So the fact that my example evaluates config before it evaluates ENV["foo"] avoids the issue by initializing the instance just in time. In your example, by the time you evaluate ENV["foo"], the instance has yet to be initialized.
Off the top of my head, I'm not sure how to get around this, outside of the Figaro.load workaround you've already come up with. Thoughts?

So I'm thinking this is a regression in Rails, since this was working before Rails 4.2. The problem you stated is exactly correct, the before_configuration hook is actually never run until config is called for the first time, which lazily loads a config instance. So, this actually works too:
module Example
  class Application < Rails::Application
    config
    puts ENV["foo"]
  end
end

I'd say the smartest thing to do would be to add a note in the documentation and submit an issue about the regression to Rails.

Issue submitted. :point_up:

That's one hell of an issue submission. :clap:
Thanks!

:+1:

Just wanted to confirm that I had the same issue. I fixed it by adding an initializer with  Figaro.load.

omg,  just wasted an hour of my life debugging this. wtf do we need to run spring stop for our variables to update.

bin/spring stop

this is awesome

@bobzhen That command fixed it for me. I'm just in my dev environment right now but would I have to run that in production as well?

This was fixed with https://github.com/rails/rails/pull/26216 thank goodness!


Add decoding logic for all EntryPoint V6 Error codes

Current code has the logic for decoding AA21 error from EP. Need to add decoding logic for all other error codes as well.
List of error codes can be found in in error types file
Steps to follow

Add new class representing a error code in src/service/errorDecoder/providers/entrypoint/decoders directory.
Reference error file for AA21 Error can be used to create other error files.

Add the error class instance in errorDecoderMap in EntryPointV6ErrorResolver class.

@tomarsachin2271 will start working on this issue from tomorrow (9th december)

For all error codes, should we have a reference transaction (if exists) to make it easier assert the decoder behavior?
or
simulate the error scenario on local bundler?
@tomarsachin2271

I had this idea of adding simulation as well, but simulation on local bundler wouldn't make much sense as SA related errors can't be simulated and neither the execution errors on local geth node because of different in states.
We can actually add simulation at later stages to give more insights about the error.

Hey @kanthgithub any progress on this?

working on AA25, AA40 Decoders. will be making separate PR for each decoder. @tomarsachin2271

for AA25 where it compares the accountNonce from nonceManager of userOp.sender & actual nonce passed in userOp
the check is:

for this, i want to query the accountNonce
import { BigNumber } from 'ethers';
let nonce = BigNumber.from(userOp.nonce);
let key = nonce.shr(64);
const expectedAccountNonce = entryPointContractInstance.callStatic.nonceSequenceNumber(userop.sender, key)

In Error Description:
I want to set the expectedNonce and then also actualNonce.
is this ok approach?
@tomarsachin2271 @iamonuwa


from ludwig import LudwigModel error

Describe the bug
from ludwig import LudwigModel
gives me error:
ImportError: cannot import name 'LudwigModel'
Expected behavior
executing without error
Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

OS: [e.g. iOS] Windows 10
Version [e.g. 22]
Python version 3.6
Ludwig version 0.1

Can you please just run python in you virtual environment and then type from ludwig import LudwigModel? You are probably just not using an interpreter that has access to the pip package you installed.

I had only one environment (in anaconda), I use spider to execute script.   I should create new virtual enviroment in anaconda?
    Dnia 20 marca 2019 19:29 Piero Molino<EMAIL_ADDRESS>napisał(a):

     Can you please just run  python  in you virtual environment and then type  from ludwig import LudwigModel ? You are probably just not using an interpreter that has access to the pip package you installed.

—  You are receiving this because you authored the thread.  Reply to this email directly,  github.com view it on GitHub , or  github.com mute the thread .

Within your anaconda environment please try to do what i suggested before. If it works, it means that it's an issue with spyder / runfile and not with Ludwig.

Python 3.6.8 |Anaconda custom (64-bit)| (default, Feb 21 2019, 18:30:04) [MSC v.1916 64 bit (AMD64)] on win32   Warning:  This Python interpreter is in a conda environment, but the environment has  not been activated. Libraries may fail to load.  To activate this environment  please see  conda.io conda.io   Type "help", "copyright", "credits" or "license" for more information.  >>> from ludwig import LudwigModel    looks like it works   what should I do now?
    Dnia 20 marca 2019 19:29 Piero Molino<EMAIL_ADDRESS>napisał(a):

     Can you please just run  python  in you virtual environment and then type  from ludwig import LudwigModel ? You are probably just not using an interpreter that has access to the pip package you installed.

—  You are receiving this because you authored the thread.  Reply to this email directly,  github.com view it on GitHub , or  github.com mute the thread .

I'm not familiar with spyder and runfile, so I'm not sure how you would go make it run there.
I would suggest to just run from ludwig import LudwigModel directly in spyder without using runfile.
Anyway we made sure that it is not an issue related with Ludwig. so you probably want to ask for help about your issue with spyder and runfile on StackOverflow.

In your virtual environment,  go to lib/python3.6/site-packages/ludwig/
now open init.py and add below code to :
from ludwig.api import LudwigModel
from ludwig.cli import CLI

If you do that, the import time will skyrocket


How to get all CSS rules?

Hi guys!
I want to get all CSS rules on pages.
I try to do it but I don't understand how to get it.
My code:
var context = BrowsingContext.New(AngleSharpConfiguration.Default.WithCss());
var document = await context.OpenAsync(req => req.Content(content));
var sheets = document.StyleSheets.ToList().Cast<ICssStyleSheet>();
sheets.First().CssText //<-- contains only full rule as string (e.g. .class{ font-size: 20px })

I inspect this rule in debugging and uncover that implementation has SelectorText and few other helpful properties.
How can I get SelectorText from rule?

It's close.
var content = "<style>h1 { color: red } h2 { color: blue }</style>";
var context = BrowsingContext.New(Configuration.Default.WithCss());
var document = await context.OpenAsync(req => req.Content(content));
var sheets = document.StyleSheets.ToList().Cast<ICssStyleSheet>();
var sheet = sheets.First();
var rules = sheet.Rules;
var h1rule = rules.OfType<ICssStyleRule>().First(r => r.SelectorText == "h1");
var colorDeclaration = h1rule.Style.Where(m => m.Name == "color");

So the sheet follows the CSSOM, which is also fully defined by the W3C. Due to the static type nature of C# you'll need to check for types and use the right casts, e.g., a node in the CSS stylesheet that is a style need (consisting of selector + declarations) you'd get via the ICssStyleRule interface.
Hope that helps!
(Usually this issue would be moved to AngleSharp.Css, but I left it here since others may also stumble across the same question)


Can't access website

OS/Platform
Windows
Installed
https://ungoogled-software.github.io/ungoogled-chromium-binaries/
Version
103.0.5060.53
Tested upstream?

[X] I have tried reproducing this issue in Chrome and it could not be reproduced there
[X] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there

Description
Unable to access Disqus
How to Reproduce?
disqus.com
Actual behaviour
Video: https://streamable.com/ke8dwy
Expected behaviour
Video
Relevant log output
No response
Additional context
No response

here working fine, same version
try to play with Settings->Privacy and security->Security->Secure DNS... maybe the one you're using now resolves the site to a server where your country is banned?

Do you have a video tutorial?

here working fine, same version.
i think it's more about network and dns problem, not the appilication itself


Feature/features

Features
Overview
This PR adds the features inside the modal:

Feature Item
Feature List

@weberjavi It will live inside features folder. But I think it will add a lot of complexity. What do you prefer? 2 easy components to use or one complex? I think it's better to have more components than one mega component that do everything. I've been thinking a lot about this...
Also, there are more components related to features like this one:

I'm thinking that I will need to create this structure
Features/
  raw-item/
  raw-list/
  selected-item/
  selected-list/
  target-item/
  target-list/

What do you think?

@weberjavi It will live inside features folder. But I think it will add a lot of complexity. What do you prefer? 2 easy components to use or one complex? I think it's better to have more components than one mega component that do everything. I've been thinking a lot about this...
Also, there are more components related to features like this one:

I'm thinking that I will need to create this structure
Features/
  raw-item/
  raw-list/
  selected-item/
  selected-list/
  target-item/
  target-list/

What do you think?

I like the idea of having the different features cards inside the features folder each one as a different component. I think it would scale on a simpler way, and also maintenance, refactoring and extension would be more manageable.
I'm all in with this 👌🏻

I like the idea of having the different features cards inside the features folder each one as a different component. I think it would scale on a simpler way, and also maintenance, refactoring and extension would be more manageable.
I'm all in with this 👌🏻


set_rate_attitude(): ignores requested rate

Hi,
Working with SITL, I see that as the SITL starts working it sends various messages at given rates.
For example the attitude message is sent every 250ms.
When I run:
telemetry.set_rate_attitude(1.0);
It does not have any affect on the message rate.
So is true for other "set rates".
What do I need to do to overcome this?
Thanks

Is this PX4?

arducopter

telemetry.set_rate_attitude(1.0);

1/4=0.25=250ms, does 1 = 250ms?

Ok, I need to try to reproduce this with ArduCopter? Can I reproduce it with just SITL?

Can I reproduce it with just SITL?

@ygratz , do you have any comment? for my cases, I am using Arducopter on cubeorange. I am not sure can it be reproduced using SITL.

Is this still an issue?

No – it is not an issue anymore.
This behavior was because I connected using MAXProxy, which sets the messages rates by itself.
From: Julian Oes @.>
Sent: Monday, May 20, 2024 7:49 AM
To: mavlink/MAVSDK @.>
Cc: Yoram Gratziany @.>; Mention @.>
Subject: Re: [mavlink/MAVSDK] set_rate_attitude(): ignores requested rate (Issue #2188)
Is this still an issue?
—
Reply to this email directly, view it on GitHubhttps://github.com/mavlink/MAVSDK/issues/2188#issuecomment-2119660979, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6N4KDXI6STAGZJKZRHMNNLZDF6FLAVCNFSM6AAAAAA72ZPDTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGY3DAOJXHE.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/mavlink/MAVSDK/issues/2188#issuecomment-2119660979", "url": "https://github.com/mavlink/MAVSDK/issues/2188#issuecomment-2119660979", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
Default Profile
*********************************************************************************************** Please consider the environment before printing this email ! The information contained in this communication is proprietary to Israel Aerospace Industries Ltd. and/or third parties, may contain confidential or privileged information, and is intended only for the use of the intended addressee thereof. If you are not the intended addressee, please be aware that any use, disclosure, distribution and/or copying of this communication is strictly prohibited. If you receive this communication in error, please notify the sender immediately and delete it from your computer. Thank you. Visit us at: www.iai.co.il

Aha, thanks for the note!


Feature/ch17697/update kucoin api for colab notebook

fix kucoin.
colab : https://colab.research.google.com/drive/1UONBlveolUKUb_3YwQe1uscT24Znd-0Z?usp=sharing

need to revise the instruction

error running on kucoin

error running on kucoin

fixed just the notebooks used for test was not up to date.

KuCoin is working now. maybe add more decimal places for pairs that has low price value

On ascendex, the trade matches but not sure why the index number is skipping some numbers.

getting this error when I run MAPS/USDT pair, other pairs are ok.

duplicate orders on ascendex, OMI/USDT : 2021-07-13 to 2021-08-13 06:15:25


move remaining components out of shared folder to root level

https://dfedigital.atlassian.net/browse/TEVA-2255
moves components out of shared folder to root level. left process steps alone as @josephhull676 is working seperatly to move the last instance usage of that to the newer steps component

Review app deployed to https://teaching-vacancies-review-pr-3503.london.cloudapps.digital


Parse error in struct typedef

typedef struct mi_heap_area_s {
  size_t x;
} mi_heap_area_t;

==> unexpected token at line 9 column 3, expected '<typedef_name>', '}'
Notice also the wrong line number!
Curiously, this works:
typedef struct mi_heap_area_s {
  void* x;
} mi_heap_area_t;

Thanks for the report!
The parse error should be fixed by 3c8d0f489f2ad9453144a915ad5f92aac2320fce.
Line numbers are a known issue: they correspond to the source after preprocessor expansion, rather than the original input, so not very helpful.


*_summaryline.tsv columns do not match the descriptions in the wiki

Hi,
I am running PHoeNIX v1.0.0 and the columns in the *_summaryline.tsv file do not appear to match the column name descriptions on the wiki page (https://github.com/CDCgov/phoenix/wiki/Running-PHoeNIx#outputs). Specifically, there appear to be more columns in the output than what are listed on the wiki.
According to the wiki the file should contain columns: ID, QC_Outcome, Coverage, Genome_Length, Assembly_Ratio_(STDev), number_of_Scaffolds, Species, MLST_Scheme_1, MLST_1, MLST_Scheme_2, MLST_2, GC_%, Beta_Lactam_Resistance_Genes, Other_AR_Genes, Hypervirulence_Genes, AMRFinder_Point_Mutations, QC_Reason.
Below is an example of the output I got:
Isolate1     PASS    1       86.26   2814526 1.0409 (N/A)    24      Staphylococcus sp.T93   99.92% ANI_match        ANI_REFSEQ      saureus ST8     NA      -       32.69   Staphylococcus(96.14%) aureus(14.19%)        Staphylococcus(100.00%) aureus(99.66%)  blaI_of_Z_NG_047499.1,blaR1_NG_051774.1,blaZ_NG_055997.1,mecA_6_BX571856,mecR1_NG_051163.1      ant(6)-Ia_NG_047395.1,apH-Stph_HE579073,aph(3')-IIIa_NG_047418.1,dha1_BA000018,fosB-Saur_NG_065844.1,lmrS_CP000046.1,mepA_AY661734.1,mph(C)_NG_047991.1,msr(A)_NG_055998.1,norA_D90119,sat4_NG_048072.1,tet(38)_NG_048134.1       No hypervirulence genes found   No point mutations found
Does this look normal? Also, do you know if these columns will stay consistent?
Thanks!

Hi @johnsonj161, you are correct that we are behind on documentation. Thanks for bring that to our attention. I just updated the summary line column details.  Just to make sure its all correct, can you please send reply with the command you used to run this and send the output uploaded as the Phoenic_Output_Report.tsv file that comes out of PHoeNIx. I need to be able to see the spacing as it is in the file to see where something might have gone wrong.
In terms of it staying consistent, we will do our best to not change things too much as I realize people will probably write code based on the output. However, I do think there is room for improvement in how we present the AR data so I would anticipate we might change that a bit in the future. We are happy to take suggestions or requests for improvement if you have them. Let me know if this answers your question.

@johnsonj161, the *_summaryline.tsv should have the same columns in the same order as Phoenix_Output_Report.tsv. The Phoenix_Output_Report.tsv basically just concats the  *_summaryline.tsv files together so there shouldn't be a difference. The isolate specific report. I see the Plasmid_Incompatibility_Replicons in the code for version 1.0.0 (which is what you should be running). I am not sure what version of the pipeline you are running (when was it pulled?). Can you use nextflow run cdcgov/phoenix -r main -profile singularity -entry PHOENIX --input manifest.csv --kraken2db absolute/path/to/kraken2db/ --outdir absolute/path/to/directory and let me know the output? Also, if you want to email me the sample I can try it on my end<EMAIL_ADDRESS>to figure out the issue.
I can add a header to the *_summaryline.tsv in the next release for ease in interpreting it.

I am new to Nextflow and nf-core, so I am not sure where to find my version number. Would you be able to guide me on this? I am also not the person who installed the version I am working with, but I know it was installed 9/20/2022. Hope that is informative.
I tried running the command you have above and am now running into an error with spades (see below).
NOTE: Process PHOENIX:PHOENIX_EXTERNAL:SPADES_WF:SPADES (isolate1) terminated with an error exit status (1) -- Error is ignored
I don't know if this would be better discussed in a new issue thread?

@johnsonj161 based on that date then you are running the dev version and not an official release (official first release was 10/12/2022). If you run the following command nextflow run cdcgov/phoenix -r v1.0.0 -profile singularity -entry PHOENIX --input manifest.csv --kraken2db absolute/path/to/kraken2db/ --outdir absolute/path/to/directory the -r parameter pulls a specific version. By default it pulls the latest version. The version is printed out every time the pipeline runs. It will look like this:

And the second question would be best discussed though a different thread. Please include what information there is in .command.out and .command.err files for the SPAdes step. To find these files you will want to follow the nextflow full work path ( work would be in the directory you ran the command and there will something like [g7/7gdt3l] next to the SPADES step in nextflow that is the rest of the path). So those .command files will be in work/g7/7gdt3l...... not here 7gdt3l is just the start of that folder name its a long string of random stuff just use the tab key to auto complete. Hopefully, that makes sense.

Thank you, @jvhagey. It makese sense that my original question was likely due to me using an older version. I will create a new thread regarding the new issue.


Install Tasks runs every time

It seems like this plugin doesn't take advantage of gradle's incremental build system very well.
Even when there have been no changes to the list of dependencies the plugin seems to consistently install dependencies that were loaded by the last build.
:PlexxiCorePythonAPI:pinRequirements UP-TO-DATE
:PlexxiCorePythonAPI:createVirtualEnvironment UP-TO-DATE
:PlexxiShell:processResources UP-TO-DATE
:PlexxiCorePythonAPI:installLinks UP-TO-DATE
:PlexxiCorePythonAPI:installSetupRequirements
Install setuptools-19.1.1 ........................................... [SKIPPING]
Install wheel-0.26.0 ................................................ [SKIPPING]
Install pip-7.1.2 ................................................... [SKIPPING]
Install setuptools-git-1.1 .......................................... [SKIPPING]
Install pbr-1.8.0 ................................................... [SKIPPING]
Install argparse-1.4.0 .............................................. [SKIPPING]
:PlexxiCorePythonAPI:installBuildRequirements
Install Babel-1.3 ................................................... [SKIPPING]
Install Jinja2-2.3 .................................................. [SKIPPING]
Install Pygments-2.0 ................................................ [SKIPPING]
Install Sphinx-1.4.1 ................................................ [SKIPPING]
Install alabaster-0.7.1 ............................................. [SKIPPING]
Install colorama-0.3.5 .............................................. [STARTING]
.... Some task output from a parallel task here
Install (0:01.567 s) ................................................ [FINISHED]
Install docutils-0.11 ............................................... [SKIPPING]
Install flake8-2.5.4 ................................................ [SKIPPING]
Install imagesize-0.7.1 ............................................. [SKIPPING]
Install mccabe-0.2.1 ................................................ [SKIPPING]
Install pep8-1.5.7 .................................................. [SKIPPING]
Install pyflakes-0.8.1 .............................................. [SKIPPING]
Install pytz-2016.4 ................................................. [STARTING]
Install (0:03.192 s) ................................................ [FINISHED]
Install six-1.10.0 .................................................. [SKIPPING]
Install snowballstemmer-1.1.0 ....................................... [SKIPPING]
:PlexxiCorePythonAPI:copyPythonSources UP-TO-DATE
:PlexxiCorePythonAPI:installPythonRequirements
Install jsonpickle-0.6.1 ............................................ [SKIPPING]
Install pytz-2013b .................................................. [STARTING]
Install (0:03.631 s) ................................................ [FINISHED]
Install requests-2.4.3 .............................................. [SKIPPING]
:PlexxiCorePythonAPI:installTestRequirements
Install argparse-1.4.0 .............................................. [SKIPPING]
Install colorama-0.3.7 .............................................. [STARTING]
Install (0:01.275 s) ................................................ [FINISHED]
Install coverage-3.7.1 .............................................. [SKIPPING]
Install nose-1.3.7 .................................................. [SKIPPING]
Install py-1.4.29 ................................................... [SKIPPING]
Install pytest-cov-2.2.1 ............................................ [SKIPPING]
Install pytest-xdist-1.14 ........................................... [SKIPPING]
Install pytest-2.9.1 ................................................ [SKIPPING]
Install jsonpickle-0.6.1 ............................................ [SKIPPING]
Install pytz-2013b .................................................. [STARTING]
Install (0:02.861 s) ................................................ [FINISHED]
Install requests-2.4.3 .............................................. [SKIPPING]

This ends up slowing down my build significantly.

After running with the --debug flag I think I see the reason:

15:57:48.904 [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationWorkerRegistry] Worker root.25 started (4 in use).
15:57:48.904 [INFO] [org.gradle.execution.taskgraph.AbstractTaskPlanExecutor] :PlexxiCorePythonAPI:installSetupRequirements (Thread[Daemon worker Thread 33,5,main]) started.
15:57:48.904 [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationWorkerRegistry] Worker root.24 completed (3 in use)
15:57:48.904 [LIFECYCLE] [class org.gradle.internal.buildevents.TaskExecutionLogger] :PlexxiCorePythonAPI:installSetupRequirements
15:57:48.904 [DEBUG] [org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter] Starting to execute task ':PlexxiCorePythonAPI:installSetupRequirements'
15:57:48.904 [INFO] [org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter] Putting task artifact state for task ':PlexxiCorePythonAPI:installSetupRequirements' into context took 0.0 secs.
15:57:48.904 [DEBUG] [org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter] Determining if task ':PlexxiCorePythonAPI:installSetupRequirements' is up-to-date
15:57:48.904 [INFO] [org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter] Executing task ':PlexxiCorePythonAPI:installSetupRequirements' (up-to-date check took 0.0 secs) due to:
  Task has not declared any outputs.
15:57:48.904 [DEBUG] [org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter] Executing actions for task ':PlexxiCorePythonAPI:installSetupRequirements'.
15:57:48.905 [DEBUG] [org.gradle.api.internal.artifacts.ivyservice.ivyresolve.CachingModuleComponentRepository] Found artifact 'setuptools.tar.gz (pypi:setuptools:19.1.1)' in resolver cache: /Users/jonathanleitschuh/.gradle/caches/modules-2/files-2.1/pypi/setuptools/19.1.1/af692dda49236c9f71385ee663daceaf9a7f8da5/setuptools-19.1.1.tar.gz

I think that its the PipInstallTask that needs to be updated to have at least one output.
Offtopic: Issue 100! :D

Looks like colorama and pytz are being installed at different versions for different configurations.
We don't use the Gradle cache for that task, but we do validate that we don't install something if it's already there.

Good eyes.  Thats exactly what im seeing.  Shouldn't gradle's dependency resolution automatically pick the latest version or are these really two different configurations?  I would think each configuration would have their own venv tho, thats kinda the point of configurations, to break the project up into modules.

Caching disabled for task ':common:installBuildRequirements' because:
Build cache is disabled
Task ':common:installBuildRequirements' is not up-to-date because:
Task has not declared any outputs despite executing actions.
https://docs.gradle.org/4.0/userguide/more_about_tasks.html#sec:up_to_date_checks
What this means for build authors is simple: you need to tell Gradle which task properties are inputs and which are outputs. If a task property affects the output, be sure to register it as an input, otherwise the task will be considered up to date when it’s not. Conversely, don’t register properties as inputs if they don’t affect the output, otherwise the task will potentially execute when it doesn’t need to. Also be careful of non-deterministic tasks that may generate different output for exactly the same inputs: these should not be configured for incremental build as the up-to-date checks won’t work.

This issue if solved I feel will help alot of users. I have a use case where I am creating a task which inherits from PipInstallTask. Even though I define outputs I still inherit the lack a parallelisation.

In my case these are the tasks affecting me :
installPythonRequirements' is not up-to-date because:   Task has not declared any outputs despite executing actions.
And
:installTestRequirements' is not up-to-date because:   Task has not declared any outputs despite executing actions.
As well as 1 custom one.
Do we feel a fix to PipInstallTask could fix these also or would these tasks need their own defined outputs.

I think it is required to revisit all tasks inpygradle and think about input/output concept.
In that case the build process will be faster and works in the same way.
p.s. Topic for another issue - is proper dependency substitution. I am not sure but assume that the reason of not possibility to make something like:
configurations.python {   resolutionStrategy.dependencySubstitution {     substitute module("${lib.common}") with project(':python-common:common')   } }
is related to this question (as incorrect output of the task packageSdist)


Won't connect to broker, no output

Try as I might I can't seem to get this to work.
Config:
broker.url=tcp://<IP_ADDRESS>:1883
broker.username=garulf
broker.password=PASSWORD
mqtt.topic.profile=home/open-cue-mqtt/profile
mqtt.topic.sdk=home/open-cue-mqtt/sdk

Maybe you can point me to what I may be doing wrong?

do you have java installed, do you see something in the logs of the mqtt broker?

Java for windows is installed.
Mosquitto log:
2021/09/24 13:32:26     Granting 'sc-mosquitto' unix ownership on /volume1/@appstore/mosquitto/var
2021/09/24 13:32:26     upgrade mosquitto 1.6.15-12 End postupgrade ret=[0]
2021/09/24 13:32:32     upgrade mosquitto 1.6.15-12 Begin start-stop-status start
2021/09/24 13:32:33     upgrade mosquitto 1.6.15-12 End start-stop-status start ret=[0]
2021/09/24 13:32:33     upgrade mosquitto 1.6.15-12 Begin /bin/rm -rf /volume1/@tmp/pkginstall
2021/09/24 13:32:33     upgrade mosquitto 1.6.15-12 End /bin/rm -rf /volume1/@tmp/pkginstall ret=[0]
2021/10/27 15:55:01     (system) trigger mosquitto 1.6.15-12 Begin start-stop-status stop
2021/10/27 15:55:02     (system) trigger mosquitto 1.6.15-12 End start-stop-status stop ret=[0]
2021/10/27 18:47:00     (system) trigger mosquitto 1.6.15-12 Begin start-stop-status start
2021/10/27 18:47:02     (system) trigger mosquitto 1.6.15-12 End start-stop-status start ret=[0]

Which Windows version do you use? I only tested 10

Edition	Windows 10 Home
Version	21H1
Installed on	8/5/2021
OS build	19043.1466
Experience	Windows Feature Experience Pack 120.2212.3920.0

I can look at it later when I'm at my windows machine

I can look at it later when I'm at my windows machine

Thank you I'd appreciate it. Is there some sort of log that I can check for errors?

you can change your config to force a config parse error, to see where it hangs

you can change your config to force a config parse error, to see where it hangs

I'm not sure what it's doing. Seemingly it's connected but not sending the messages for some reason.

You know, you also have to use and run open-cue-service and the mqtt adapter only receives messages and do not send any to the mqtt Broker.

You know, you also have to use and run open-cue-service and the mqtt adapter only receives messages and do not send any to the mqtt Broker.

That was it! I was expecting a topic of the current profile. But yes sending a message does work:


Relax err test to account for different dev paths

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce

[x] Refactor, no breaking changes

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[x] Lint and unit tests pass with my changes
[ ] I have added tests that prove my fix is effective/works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes are merged and published in downstream modules

Reviewers: @michael-ciniawsky, @ertrzyiks

Coverage remained the same at 100.0% when pulling 802c95dc2426cc23f28e9d0d4da29136afcbf4d1 on duncanbeevers:test-path-regex into e65855e8aee3fe56c5cced16debce390b2f5fde4 on michael-ciniawsky:master.


FEAT: Added new API to get requests

Issue Ticket Number

#1881

Description
Added changes to get requests by type, id, requestedBy,state.
Documentation Updated?

[ ] Yes
[x] No

Under Feature Flag

[x] Yes
[ ] No

Database Changes

[ ] Yes
[x] No

Breaking Changes

[ ] Yes
[x] No

Development Tested?

[x] Yes
[ ] No

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes

All change in PR #1883


Force field parsing behavior

Only parse files with known extensions in force field directory.

I have reduced the complexity of the force field and build file-parsing wrappers.
The wrappers can be further simplified by merging load_ff_library and load_build_files, this would however require the load_ff_library to take a forcefield object as input and not a simply a name. (i.e. in gen_itp.py, an empty forcefield has to be created and provided to load_ff_library. ) I guess this would also be okay, opinion @fgrunewald?
p.s I will fix the relevant tests later if the layout of the wrappers is okay.

I realized that when loading the buildfiles from the force field directory, the get_parser() function would complain about the force field files that it encounters.
Does the fix in the `FORCE_FIELD_PARSERS' make sense? @fgrunewald

it was a difficult delivery, but I think the library loading is now fixed. Can you have a look at it @fgrunewald ?

I copied a code snippet that captures and checks if the logger threw the correct Warning from some other test in the codebase. But for some reason, this caused pkg_resources to throw a DeprecationWarning only when the tests were run by GH and this broke the test somehow. I could not reproduce the error locally, but a nicer way of capturing the Warning fixed the issue.
And the regression tests all passed btw.


Suggestion: Move game loading to a separate thread.

When Minecraft is loading, most of the loading process is handled by the rendering thread, as indicated by the game logs:
[Render thread/INFO]: [Spectrum] Starting Common Startup
[Render thread/INFO]: Registered the class blah.blah.blah.............
[Render thread/INFO]: Created: 512x256x1 minecraft:textures/atlas/beds.png-atlas

However, since the rendering thread is responsible for the, well, rendering, this can cause the loading process to appear frozen to the user. Windows may even display a message stating that "Minecraft isn't responding," even though the game is still loading.
To address this issue, one solution would be to move the rendering process to a separate thread. Alternatively, a dedicated loading thread could be created to handle the loading process separately from the rendering thread, resulting in a smoother and more enjoyable loading experience for the user.

at that point the mod'd need to be rebranded since it'd be a thread management mod


Implement or matching when chaining where Fuzzy

When searching across multiple columns, if the query would normally return a match with ONE whereFuzzy, that result is not returned if  second column query returns null.
Would it be possible to built an OR function to return a better result set in that instance ?
I.e.
User::whereFuzzy('name', 'jd')
->orWhereFuzzy('email', 'gm')
->first();

Unfortunately, I'm not sure that such functionality is possible, or if it is, my guess is that it would not be a trivial undertaking to implement and would likely lead to unforeseen edge cases.
The reason for this, is that whereFuzzy doesn't just add a WHERE statement to the SQL query, it also uses addSelect, orderBy and having statements to enable relevance calculations:
return $builder
    -> addSelect(static::pipeline($field, $native, $value))
    -> orderBy('relevance_' . str_replace('.', '_', $field), 'desc')
    -> having('relevance_' . str_replace('.', '_', $field), '>', 0);

That said, my inclination may be wrong, so I'm not against a PR adding it. If you feel it would be of use and would like to see it implemented, feel free to submit something :)

Thanks for replying !  I’ll have a dig-in 👍🏼


Android-sdk installation error

Description
Using the creation script for Windows 2022 (runner-images-win22-20230118.1) the step : Android-sdk fails
The error is :
Exception in thread "main" java.lang.UnsupportedClassVersionError: com/android/prefs/AndroidLocationsProvider has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
==> vhd:     + CategoryInfo          : InvalidData: (:) [Install-AndroidSDKPackages], ParentContainsErrorRecordException
==> vhd:     + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Install-AndroidSDKPackages
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
We build the image on a VM on our own, we do not use GitHub or Azure Devops ...
Image is : win22 20230109.1
https://github.com/actions/runner-images/releases/tag/win22%2F20230109.1
Is it regression?
Yes, win22/20230109.1 (https://github.com/actions/runner-images/releases/tag/win22%2F20230109.1)
Expected behavior
The image is build without error.
Actual behavior
The image is not build
Repro steps
Reproduce the error is quite easy :
Run :
Import-Module .\helpers\GenerateResourcesAndImage.ps1
GenerateResourcesAndImage `
    -SubscriptionId xxxxx
    -ResourceGroupName "xxxxx" `
    -ImageGenerationRepositoryRoot "$pwd" `
    -ImageType Windows2022 `
    -AzureLocation "xxxxx"

Wait for the error message :)

Hello @saoullabit, this is a duplicate of issue #6960.
We have fixed this issue several days ago. Could you please update your fork repository to use the latest versions of files?
We will close this issue as a duplicate, if you have any questions feel free to reach us.


Language highlight with diff on markdown in articles and books

About
Resolves #86 .
Use the similar way with diff-highlight plugin of markdown-it-prism.
Links
https://zenn.dev/kkiyama117/scraps/05094a5e9f8db8
Others
may conflict with #103.

TODO

Add CSS for diff-highlight

I don't know your favorite design, see also https://github.com/PrismJS/prism/blob/master/plugins/diff-highlight/prism-diff-highlight.css

check we can use diff-highlight plugin

mdPrism in zenn-markdown-html omits loadPrismPlugin, so expression in #86 does not work, but it may work well if mdPrism load plugins with the same method as `markdown-it-prism's.

TODO

Add CSS for diff-highlight

I don't know your favorite design, see also https://github.com/PrismJS/prism/blob/master/plugins/diff-highlight/prism-diff-highlight.css

check we can use diff-highlight plugin

mdPrism in zenn-markdown-html omits loadPrismPlugin, so expression in #86 does not work, but it may work well if mdPrism load plugins with the same method as `markdown-it-prism's.

@kkiyama117
Thanks always! I'll review it later.

@kkiyama117
Thanks always! I'll review it later.


Merge latest Lisk Server

What was the problem?
This PR resolves #62

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


[14.0.0] Enable the wasmtime serve command by default

This enables the serve subcommand by default on the CLI instead of having it behind an off-by-default feature. In general our default build is the "most featureful" while we still retain the ability to turn off everything if desired for custom builds. This additionally matches the current main branch where through other refactorings the serve command is now enabled by default.

For the main branch this happened in https://github.com/bytecodealliance/wasmtime/pull/7282 through other refactorings but I don't want to backport that whole PR, so this is a customized feature for the 14.0.0 branch. This'll get included with the upcoming point release next week.


[FIX] Cleanup code

What does this do / why do we need it?
Cleanup code
What should your reviewer look out for in this PR?

removed unused import-aliases
errors must start with non uppercased letter

Do you need help or clarification on anything?
Don't think so 🙂
Which issue(s) does this PR fix?
Nothing, just cleanup code

removed unused import-aliases
errors must start with non uppercased letter
preallocated slices

mostly good, just the one nit

@sdboyer fixed by 2f5dec1

It's great news 🎉


Gradient doesn't exist/ becomes None for conv_transpose layers

System information

Custom code
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS Catalina
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.0
Python version: 3.6.8
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source):N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior
I get a warning
WARNING:tensorflow:Gradients do not exist for variables ['mrf__block_2/conv2d_transpose_5/kernel:0', 'mrf__block_2/conv2d_transpose_5/bias:0'] when minimizing the loss.
when trying to backprop loss for a specific layer in my model. The gradients keep turning out to be None regardless of optimizer.
Describe the expected behavior
The gradients should exist for these layers.
Code to reproduce the issue
This is the model in question:
import tensorflow as tf
import tensorflow.keras.layers as layers
from tensorflow.keras import Model

class MRF_Block(Model):
  def __init__(self, out_channels, num_inputs, use_deconv=True,
               kernel_size=(3,3), strides=(1,1), padding='same'):
    super(MRF_Block, self).__init__()

    # Add the conv/deconv layers.
    for i in range(num_inputs):
      # Convolve input tensors to output tensors of same channel depth (# of channels)
      conv_layer = layers.Conv2D(out_channels, kernel_size, strides=strides, padding=padding)
      setattr(self, f'conv_{i}', conv_layer)

      # Deconv input tensors. Input tensor at index i will be upsampled by factor 2^(n_inputs - (i+1))
      # Eg: if input tensors are [t1, t2, t3], t1 will be upsampled x 4, t2 upsampled x 2, t3 not upsampled.
      if use_deconv:
        deconv_layer = layers.Conv2DTranspose(out_channels, kernel_size, padding='same',
                                              strides=(2**(num_inputs-(i+1)), 2**(num_inputs-(i+1))))
        setattr(self, f'deconv_{i}', deconv_layer)

  ## inputs: a list of tensors being inputted to the block.
  def call(self, inputs):

    # Make #channels the same for input tensors (smallest depth)
    convolved = []
    for i, t in enumerate(inputs):
      conv = getattr(self, f'conv_{i}')
      convolved.append(conv(t))

    # Upsample to largest (h, w) resolution
    largest_res = max(inputs, key=lambda t: t.shape[1] * t.shape[2])
    resized = []
    for i, t in enumerate(convolved):
      deconv = getattr(self, f'deconv_{i}', lambda t: t)
      up_sampled = deconv(t)

      # Use bilinear resizing if resolution of optional conv_transpose doesn't match
      if up_sampled.shape[1:3] != largest_res.shape[1:3]:
        up_sampled = tf.image.resize(t, size=largest_res.shape[1:3])

      resized.append(up_sampled)

    # Fuse by summing
    return sum(resized)

And then running this code is what results in the error:
t = tf.random.normal((2, 224, 224, 3))
optimizer = tf.keras.optimizers.SGD()

mrf = MRF_Block(12, 2)
with tf.GradientTape() as tape:
    preds = mrf([t, t])
    loss = tf.keras.losses.BinaryCrossentropy(from_logits=True)(tf.random.normal((2, 224, 224, 12)), preds)
gradients = tape.gradient(loss, mrf.trainable_variables)
optimizer.apply_gradients(zip(gradients, mrf.trainable_variables))

Changing SGD() to Adam() yields the same warning. Is it a problem with how the model is defined? Repeatedly running the above code yields the same warning (with/without reinitialising the optimizer).
Other info / logs
None at the moment.

@Dieblitzen Can you please provide a minimal reproducible code in colab as I cannot reproduce this issue. Thanks!

Sure. Here is the link
https://colab.research.google.com/drive/1e8IQIeqOvecb2xu-otMfXMmIgpEDnaKK

Please go through the similar issue here and let me know if it helps @Dieblitzen

I saw that issue earlier, but I find it odd that no matter how many times I run the code (in the colab link) it always emits that warning. How can the gradients systematically always be zero for those conv_transpose bias and kernel terms, no matter how many times I run it?

Please look at my gist where the warning is no longer present here

@gowthamkpr Yes that surpasses the warning, but my question is why are the gradients for those bias/weight terms always 0? Even if I manually set the gradients to 0 using the code you shared, I still find that the gradients are 0 for every run. Do you know why this is happening?

@Dieblitzen Your code has a bug, it should be:
if up_sampled.shape[1:3] != largest_res.shape[1:3]:
        up_sampled = tf.image.resize(up_sampled, size=largest_res.shape[1:3])

not:
if up_sampled.shape[1:3] != largest_res.shape[1:3]:
        up_sampled = tf.image.resize(t, size=largest_res.shape[1:3])


feat: controlflow verbose

require: https://github.com/oxc-project/oxc/pull/5879

Adding a new option to control displaying implicit error edge.
verbose

disable verbose

Gonna merge and fix on main.


Conversion of AR-2019 from PHP to Next.js

Closing https://github.com/CUCentralAdvancement/cu-giving/issues/53

[ ] Identify and convert all links.
[ ] Fix issues related to global Next.js CSS affecting annual report CSS.
[ ] Migrate slide content from Contentful to JSON flat files and Cloudinary as applicable.
[ ] Change background image for video elements.


[BUG] No webhook / not running check group

Describe the bug
check-group installed from the marketplace does not run on selected repos
To Reproduce
Steps to reproduce the behavior:

Go to github marketplace and install the app for a specific repo
follow setup doc / create .github/checkgroup.yml
Create PR with change that triggers workflows
no checkgroup check occurs

Expected behavior
I expected to see a Check Group check that passed once the specified checks in the .github/checkgroup.yml passed. Instead it isn't listed in the checks
Screenshots

Additional context
My suspicion is that there needs to be a webhook setup to call out to your service. I looked and didn't see one created either at the repo level or at the organization level.
Let me know if there is any other info i can provide or anything i can do to help! this project looks perfect for my use case and i'd love to get it up and running. Many thanks!

Hi @paulijones! Thanks for trying out the project :)
I took a look at the log and found that it's because heroku server is out of free hours... I guess since we are approaching the end of this month...

so there are a few near future solutions for this that I will implement after this busy week with my 9to5 job:

there is an ongoing migration from heroku to vercel as the service provider which should avoid this issue since vercel calculates usage by seconds whereas heroku will round anything under 30 minutes to 30 minutes (this will also improve response time since vercel doesn't have server warm up time)
Continue paid heroku for a few more weeks until the migration is done. It turns out that I cancelled the paid service before the migration is done. This should be fairly easy, but I want to check if it's urgent for people to keep the service up between now and the end of this month since I few users that I know was pretty busy with other stuff recently

Thanks for the quick response! We aren't using it yet and were just looking to see if it would solve our problem, nothing that can't wait another week.
I'd be happy to help with the migration if you have steps laid out. I don't know vercel, but it wouldn't be the first (or last) time i migrated things away from heroku :laughing:
If it does work for us, we would be looking to use this in our main path for one of our production products. I'm a little worried about pr's suddenly being blocked at the end of each month. Have you considered either a paid tier or a guide for self-hosting the docker image? i'd happily consider either if it works for us.

Thanks for helping out! The migration is pretty much just copying over a ton of credentials.
I just migrated it in #564. The migrated pipeline might bring up some issues since vercel is a pretty opinionated platform. Please bring it up in issue if anything seems off.

Yes, I am thinking about hosting a more reliable version like 98% uptime but have been debating what is the best way to pull it out.
There is a dockerized self-hosted solution available, but I don't really recommend it since the time it takes to configure/maintain the webhooks and credentials is too long, and it really defeats the purpose of providing an easy to use/understand automation.
For now, after migrating to Vercel, the monthly cap is gone, and we don't need to worry about traffic for a while until the active user count exceed 500 by estimation... My current plan is to monitor the usage, when it goes anywhere near 50% of the limit, I will separate out some sort of paid version which runs on high reliability AWS lambda.

Oh also, since the promotion season in my 9to5 job is about to finish, I will have significantly more time to work on this. If you have some timeline for your project or some feature wish list, you can add it here or email me so that I can take into consideration when I plan my time :)


[CORE] Fix miss RowToColumnar with columnar table cache in AQE

What changes were proposed in this pull request?
Since https://github.com/apache/spark/pull/43484 Spark supports cache columnar batch, then outputsColumnar of AQE can be true. It breaks the assumption that the output is always row-based. This pr makes fallback policy compaible with this behavior.
How was this patch tested?
add test

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4104_time.csv
log/native_master_12_19_2023_521cad261_time.csv
difference
percentage

q1
32.40
32.55
0.156
100.48%

q2
24.85
25.18
0.337
101.36%

q3
38.69
37.70
-0.987
97.45%

q4
37.89
39.88
1.993
105.26%

q5
71.78
71.42
-0.363
99.49%

q6
7.23
5.41
-1.823
74.79%

q7
87.52
87.04
-0.482
99.45%

q8
87.14
86.34
-0.796
99.09%

q9
127.43
122.28
-5.153
95.96%

q10
44.87
44.36
-0.511
98.86%

q11
21.50
20.12
-1.381
93.58%

q12
25.95
26.74
0.793
103.06%

q13
46.21
46.35
0.142
100.31%

q14
18.50
17.44
-1.061
94.26%

q15
29.66
29.09
-0.574
98.07%

q16
15.72
15.70
-0.028
99.82%

q17
102.43
102.87
0.441
100.43%

q18
151.62
149.94
-1.678
98.89%

q19
13.92
12.78
-1.138
91.83%

q20
27.90
28.17
0.266
100.95%

q21
230.30
227.31
-2.994
98.70%

q22
13.91
13.95
0.042
100.30%

total
1257.42
1242.62
-14.797
98.82%


Remove console.log('Live reload enabled.');

Hi,
Thank you for the package, but please remove the console.log('Live reload enabled.'); code. I'm using dev tool a lot and I feel a bit weird to see that words while I'm debugging my code.
Thank you.

@satrya this code is in the original live-server library so I can't remove it, but you can do it yourself.
Open ~/.atom/packages/atom-live-server/live-server/injected.html and remove the code, save the file and restart atom editor.
If the log message is still there, try to clear the browser cache.

I see, thank you @jas-chen

@jas-chen

@satrya this code is in the original live-server library so I can't remove it, but you can do it yourself. Open~/.atom/packages/atom-live-server/live-server/injected.html and remove the code, save the file and restart atom editor.

Where in visual studio code can I do the same?

Hi, Thank you for the package, but please remove the console.log('Live reload enabled.'); code. I'm using dev tool a lot and I feel a bit weird to see that words while I'm debugging my code.
Thank you.

same problem with me . it little bit irritating, how to resolve


Appstudio update test-component-pac-qbps

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-qbps-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
21 seconds
sast-snyk-check

✅ Succeeded
36 seconds
build-container

✅ Succeeded
9 seconds
inspect-image

✅ Succeeded
40 seconds
clamav-scan

✅ Succeeded
9 seconds
deprecated-base-image-check

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
9 seconds
label-check

✅ Succeeded
9 seconds
show-summary

✅ Succeeded
9 seconds
show-sbom

Pipelines as Code CI/test-component-pac-qbps-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
21 seconds
sast-snyk-check

✅ Succeeded
36 seconds
build-container

✅ Succeeded
40 seconds
clamav-scan

✅ Succeeded
9 seconds
deprecated-base-image-check

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
9 seconds
inspect-image

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
9 seconds
label-check

✅ Succeeded
9 seconds
show-sbom

✅ Succeeded
9 seconds
show-summary


Document some jmx metrics

Question on slack:
For jmx metrics such as numberofleakedqueries, querieskilledduetooutofmemory, blockednodes, and assignedqueries under clustermemorypool and clustermemorymanager, are they cumulative count since cluster start, or are they a running average of say 5m... not sure how to find documentation on these, so any help would be appreciated!
Answer from @martint :
NumberOfLeakedQueries: number of queries currently believed to be leaked. Generally, it goes up, but due to possible race conditions, it’s possible some suspected leaked queries will clear out later.
QueriesKilledDueToOutOfMemory: cumulative since restart.
BlockedNodes: number of currently blocked nodes. It can go up or down as the state of nodes changes.
AssignedQueries: current number of queries. It can go up or down as the state changes.

Looking at this I am not sure where to document JMX more. The only JMX related info we have in the docs for now is the JMX connector. Should it be added there? Or do we need some other JMX section @martint ?

Maybe the section in the wiki is a good start: https://github.com/prestosql/presto/wiki/Monitoring

Yeah.. I think we might want to look at porting that info in the site .. do you agree @martint @electrum ?

I stumbled on this issue while searching for presto monitoring. One thing that will be helpful is a list of key metrics that one should monitor. There are more than 5k JMX metrics out of the box. The list in the wiki is a start but doesn't seem to cover everything. It'll be useful if that is revised. A template grafana dashboard will be great.

I started with porting the wiki content .. what do we want to add minimally to merge this @martint @electrum @dain and then delete the wiki page (or replace with link)

@raags a grafana dashboard could be useful but would have to be a separate largish effort.

I reopened and left assigned to me for now. Once the new docs are published I will remove the content on the wiki page and replace it with a link to the docs. Going forward we will expand that jmx page as well.

This is all done.


[BUG] Footer is floating on zoom out, improve layout so footer will always be at bottom

Describe the bug
The layout will be better if the footer sticks always at the bottom even if there is no content in the page.
To Reproduce
Website: https://www.thecyberhub.org/blogs
Local: http://localhost:3000/blogs
Expected Behavior
Footer sticks at the bottom.
Screenshot/ Video

Code of Conduct

[X] I agree to follow this project's Code of Conduct

hey @nirajpdn
Thanks for submitting this issue

If you are interested in this issue, let us know, will assign this issue to you.

@kabir0x23 Sure. I will work on it after completing #185

@kabir0x23 Sure. I will work on it after completing #185

Okay nice

@kabir0x23 please assign this issue to me.

assign this issue to me, I am interested to work on this.

assign this issue to me, I am interested to work on this.

Awesome, I have assigned this issue to you

Is this issue resolved ?

Is this issue resolved ?

Nope, this issue is still available.

Assign it to me.

Done


DOC: change a few floats to integers in docstring examples

Before this PR, the scipy refguide check fails when I use the numpy development branch. After this PR, the refguide check passes.

LGTM, thanks Alex


Exceptions not appearing in logs

I am not able to see runtime exceptions. I am not sure what change I made that caused it to happen.
I tried flutter run -v and Android Studio's Run and Logcat (Verbose). All of those three do not print out any exceptions.
I am able to see all exceptions using Android Studio's Debug, which will stop the application on every exception and only show it as an object in the object view.
Flutter version 0.5.9-pre.30
Framework revision 33c4cd0f39
Engine revision e54bc4ea18
Dart version 2.0.0-dev.69.5.flutter-eab492385c

Fixed in latest master branch.


[beta] Revert #9133, moving to git HEAD dependencies by default

This PR reverts #9133 on the beta branch. The reason for this is that I would like to take some more time to investigate fixing https://github.com/rust-lang/cargo/issues/9352 and https://github.com/rust-lang/cargo/issues/9334. I think those should be relatively easy to fix but I would prefer to not be too rushed with the next release happening soon.
We realized today in the cargo meeting that this revert is likely to not have a ton of impact. For any projects using the v3 lock file format they'll continue to use it successfully. For projects on stable still using v2 they remain unaffected. This will ideally simply give some more time to fix these issues on nightly.

r? @ehuss
(rust-highfive has picked a reviewer for you, use r? to override)

:warning: Warning :warning:

Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.52.0. Please double check that you specified the right target!

Thanks!
@bors r+

:pushpin: Commit c1fdb4c2126b535e5757e2c30de9a90d3b235a8e has been approved by ehuss

:hourglass: Testing commit c1fdb4c2126b535e5757e2c30de9a90d3b235a8e with merge bf397482f257cdc31c7f088df051c69f24effe85...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing bf397482f257cdc31c7f088df051c69f24effe85 to rust-1.52.0...


Prohibit the use of tf.control_dependencies.

See #1794  for background

I don't know if we could or it is safe enough to check sys.gettrace if we are really under a debugger and to enable only that case.

the __debug__ directive is very simple to use and specifically targeted for our use case. We'll use that and it's easy to turn off.


Add GHA CI

Also convert README.md -> README.adoc and add badges

"ctest can run test suite"
"GHA CI is supported"
"Basic cmake subdir support"
"README is adoc"
"README has badges"
"FindThreads in CML"


Generate tarball release

Feature

Since there are no tarball files released for this package here on GitHub or on PyPi, is it possible to generate/compile one either here or on pypi. Working on building this for conda-forge.
Thank you!
Alternatives

Additional context

Hi @rluria14 , thanks for this issue. We are making a minor refactoring to the codebase and will be creating a bundle soon after (and also publish on PyPi). I will comment here once that is done so that you know when to pick it up.

@karthikprasad thanks!

The release is now out https://github.com/facebookresearch/pytorch-dp/releases/tag/v0.1-beta.1

The release is now out https://github.com/facebookresearch/pytorch-dp/releases/tag/v0.1-beta.1

perfect, thanks again.


Illegal Value issue

Weather Plus BridgeERROR[Weather Plus Bridge DB70@Today@Today@UV Index] characteristic was supplied illegal value: number 12 exceeded maximum of 10

Fixed in v3.2.7


Background & Inspiration Section

Hey Ed. I forgot I added these notes back in November. This chunk of text may be too lengthy for README.md. Please feel free to edit, or move to other documentation, or ignore...

Thanks Peter!


Should params arrays be declared nullable?

There a few cases to consider here (assume nullability enabled):
Array that contain nullable types (object?), value types (int), and non-null reference types (object)
Should there be guidance on if the params array be declared nullable?
Proposal:
CONSIDER: Declare params arrays as non-nullable.
This aligns with built-in methods such as string.Format.

After discussion, this is unlikely to provide much value. Though good to declare non-nullable the impact is low and the value add is also low.


Make possible to execute dynamic queries.

Queries with dynamic column count/type.

Fix issue #106

Related issue #106 can be fixed.


Add CodeTour

With the CodeTour extension for VScode it is possible to record Tours with comments and explain the structure of the project.
https://marketplace.visualstudio.com/items?itemName=vsls-contrib.codetour
This is a nice approach to make code easier to understand for new developers, so I want to try that.

Sadly a code tour is for an application which changes a lot a lot of work because the code tour doesn't consider changed line numbers.
Therefore I close this for now. A codetour is for files which are very static / stable.


docs(mempool/lanes): Add technical design section to ADR

Closes #3138
Rendered

PR checklist

[X] Title follows the Conventional Commits spec

The first part of this PR is clearly a spec.

And the use of FIFO order, partial order there is something to review. Lets come up with new names, lets having a subsection about ordering, please, because this is a source of confusion.

@cason Thanks for all the feedback. I removed the cache spec; it does not belong here and I will leave it for another PR. For now, I simplified the explanation of the "received for the first time" definition, which was the reason to include the cache spec.


feat: a new feature for HBASE components

Describe what this PR does / why we need it
A new feature for HBASE chaos experiments is introduced in this PR. For now hbase has been supported by ChaosBlade, this new feature would help to expand the boundary of tool ability to further more.
Does this pull request fix one issue?
fixes #323

Describe how you did it
Currently, chaosblade supports fault injection for tables using delay and throwCustomException methods, and on this basis, it expands to support fault injection for columns using delay and throwCustomException methods.
Describe how to verify it
blade create hbase delay --column coloumn1 --time 1000  --pid 12345
blade create hbase throwCustomException --exception  java.lang.Exception --column column2 --pid 12345

Special notes for reviews

新增加的文件 添加开源licence
done

新增加的文件 添加开源licence

done


intelligent protector user guide file

Just a friendly note - the /docs/intelligent protecter user guide is actually an INSTALL GUIDE.  The name is misleading.

Or a DEVELOPERS GUIDE?

@noelmcloughlin
did u used  this project in product environment?

No - it was mentioned in a Bi-weekly technical discussion meeting so I just reviewed the document.


TypeScript: attribute mapping in generated interface is incorrect

Describe the bug
I have attributes in my AsyncApi file that are of the format:
aa_00_fooBar
After using TypeScriptGenerator to generate the interfaces, the outputs in the generated interface are of the format:
aa_00FooBar
As visible, the second _ is missing, with the following string title-cased instead of camel-cased.
How to Reproduce
Version 1.9.0
Code to generate a typescript file with the generated interfaces:
import { TypeScriptGenerator } from "@asyncapi/modelina";
import { createWriteStream, readFileSync, unlinkSync } from "fs";

const OUTPUT_FILE = "output.ts";

const generator = new TypeScriptGenerator({ modelType: "interface" });
const contractJsonString = readFileSync("contract.json", { encoding: "utf-8" });
const contract = JSON.parse(contractJsonString);

export async function generate(): Promise<void> {
  const models = await generator.generate(contract);
  unlinkSync(OUTPUT_FILE);
  var stream = createWriteStream(OUTPUT_FILE, { flags: "a" });
  for (const model of models) {
    stream.write(model.result + "\n");
  }
  stream.end();
}

if (require.main === module) {
  generate();
}

contract.json
{
  "asyncapi": "2.6.0",
  "info": {
    "title": "Test",
    "version": "0.0.1"
  },
  "channels": {
    "test/test": {
      "publish": {
        "message": {
          "$ref": "#/components/messages/test"
        }
      }
    }
  },
  "components": {
    "messages": {
      "test": {
        "payload": {
          "type": "object",
          "additionalProperties": false,
          "properties": {
            "aa_00_testAttribute": {
              "type": "string"
            },
            "aa_01_testAttribute": {
              "type": "string"
            },
            "aa_02_testAttribute": {
              "type": "string"
            }
          }
        }
      }
    }
  }
}

output.ts
interface AnonymousSchema_1 {
  aa_00TestAttribute?: string;
  aa_01TestAttribute?: string;
  aa_02TestAttribute?: string;
}

Expected behavior
Attributes in AnonymousSchema_1 should be as such:
interface AnonymousSchema_1 {
  aa_00_testAttribute?: string;
  aa_01_testAttribute?: string;
  aa_02_testAttribute?: string;
}

hey @dansiemens1, yea this does indeed seem like a bug 🤔
Property name's are constrained here: https://github.com/asyncapi/modelina/blob/d7f38e42f3fcef480b2c462b0d88de188c2c66a8/src/generators/typescript/constrainer/PropertyKeyConstrainer.ts#L37C21-L37C46
Would appreciate any help fixing it 🙏

@jonaslagoni Do you see this as just a problem with underscore or wider than that? If it's just an underscore issue we could change FormatHelpers.toCamelCase to something like:
  static toCamelCase(renderName: string): string {
    return renderName
      .split('_')
      .map((word) => camelCase(word))
      .join('_');
  }

All for it @danielslalom  👍
I dont know of any other problems.

When proposing the change, please target the next branch as this is a breaking change.

Hey @danielslalom let me know if you need any help 🙂


Fix the app store on the simulator

Python's tarfile doesn't append a "/" to directory names like MicroPython does, so the root directory detection fails. Normalise the names by removing the "/" and then adding it back when returning the root directory name.

I've only tested this on the simulator and the app store appears to be down now, hence the handling of the 404 response from the demo server.

The app store is now working again, if you could have a test of this and let u know if its working it'd be appreciated :)

I've tested this on the badge and it works


Move to cchardet instead of chardet

The latest version of chardet (3.0.4) does not support windows-1250, which causes issues which I've seen used for a couple Polish and Czech logs. It seems unlikely that it will anytime soon (as the two main developers have both said they are not really working on it anymore).
cchardet seems to be more actively developed these days, and does support windows-1250.

Two test logs that I've seen affected by this:
cs_1250.log
pl_1250.log


feat(icons): add mario icon

One more to #65 .

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Error during multi-regression training / ValueError: arrays must all be same length

(featurize.py:17787): Gdk-CRITICAL **: 13:59:10.995: gdk_cursor_new_for_display: assertion 'GDK_IS_DISPLAY (display)' failed
audio-features-44c7f080-e56a-11ea-9f66-380025122270: 100%|███████| 5010/5010 [00:10<00:00, 456.12it/s]
numerical
-------------
Traceback (most recent call last):
  File "featurize_csv_regression.py", line 417, in <module>
    df, filename=csv_featurize(options.input, options.output, settings, options.target)
  File "featurize_csv_regression.py", line 383, in csv_featurize
    df = pd.DataFrame(newdict)
  File "/home/jim/.local/lib/python3.6/site-packages/pandas/core/frame.py", line 411, in __init__
    mgr = init_dict(data, index, columns, dtype=dtype)
  File "/home/jim/.local/lib/python3.6/site-packages/pandas/core/internals/construction.py", line 257, in init_dict
    return arrays_to_mgr(arrays, data_names, index, columns, dtype=dtype)
  File "/home/jim/.local/lib/python3.6/site-packages/pandas/core/internals/construction.py", line 77, in arrays_to_mgr
    index = extract_index(arrays)
  File "/home/jim/.local/lib/python3.6/site-packages/pandas/core/internals/construction.py", line 368, in extract_index
    raise ValueError("arrays must all be same length")
ValueError: arrays must all be same length

This seems to be a problem only with multiple featurizations. May need to look at the loop in the csv_features_regression.py script

Fixed with https://github.com/jim-schwoebel/allie/commit/fa69b40ea018b2459f4765ad38216b23ce28e732


[Request For External] Report 10412 - Check (Check/Stub/Stub) - Variables

Describe the request
Hello,
Can you please move the variables from Report 10412  to Protected
Here is the list of variables to be updated to Protected
protected var

PreprintedStub: Boolean;
OneCheckPrVendor: Boolean;
ApplyMethod: Option Payment,OneLineOneEntry,OneLineID,MoreLinesOneEntry;
BalancingType: Enum "Gen. Journal Account Type";
CompanyAddr: array[8] of Text[100];
CheckToAddr: array[8] of Text[100];
CustLedgEntry: Record "Cust. Ledger Entry";
VendLedgEntry: Record "Vendor Ledger Entry";
RemainingAmount: Decimal;
CurrentLineAmount: Decimal;
LineAmount: Decimal;
LineDiscount: Decimal;
TotalLineAmount: Decimal;
UseCheckNo: Code[20];
BalancingNo: Code[20];
CheckNoText: Text[30];
CheckDateText: Text[30];
CheckAmountText: Text[30];
Stub2LineNo: Integer;
Stub2DocNo: array[50] of Text[35];
Stub2DocDate: array[50] of Date;
Stub2LineAmount: array[50] of Decimal;
Stub2LineDiscount: array[50] of Decimal;
Stub2PostingDesc: array[50] of Text[100];
Stub2DocNoHeader: Text[30];
Stub2DocDateHeader: Text[30];
Stub2AmountHeader: Text[30];
Stub2DiscountHeader: Text[30];
Stub2NetAmountHeader: Text[30];
Stub2PostingDescHeader: Text[30];
DescriptionLine: array[2] of Text[80];

Additional context
We would like use for extension
Internal work item: AB#499270

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: .


Handing of required/nullable is in schemas not correct

After looking at a SO post, I've realized we're not quite handling required correctly.  The nullable property (which defaults to false) was added in OpenAPI v3 (there is no analog in Swagger v2).
(Note in the below tables, when I say required: true I mean "the property is included in the required array".)
Serialization

required
nullable
Output generation

false
false
Property may be missing or present, but, if present, must not be null

false
true
Property may be missing or present, and, if present, may be null

true
false
Property must be present and must not be null

true
true
Property must be present but may be null

Currently we do not do anything with nullable.  We treat required: true as (required: true, nullable: false), and required: false as (required: true, nullable: true).
It's not entirely clear what we should do for Swagger v2, which does not support nullable.  I would suggest that, for backward compatibility, we retain the current behavior there.  Since OpenAPI v3 support/use in Guardrail is still relatively new, we can correct the behavior without too much collateral damage.
Deserialization
The spec is (I think) a little underspecified here; I think we should be as permissive as possible:

required
nullable
Input parsing

false
false
Allow null and treat it as not-present

false
true
Anything goes

true
false
Property must be present and non-null

true
true
Allow not-present and treat it as null

I'm not 100% sure, but I think we currently treat required: true as (required: true, nullable: false) and required: false as (required: false, nullable: true).
Other Stuff
The next question: how do we represent the tri-state of (absent, present-but-null, present) in our generated APIs?  (I have some thoughts here but will add as a comment later.)
As a somewhat-off-topic rant, I'm a little annoyed that OpenAPI didn't just follow JSON schema here and allow an array for type:, so you'd do type: [ "string", "null" ] instead of using nullable: true.

Only considering Java here.
Strawman value type:
public abstract class PropertyValue<T> {
    public static class Absent<T> extends PropertyValue<T> {}

    public static class Null<T> extends PropertyValue<T> {}

    public static class Value<T> extends PropertyValue<T> {
        private final T value;

        private Value(final T value) {
            this.value = value;
        }

        public T getValue() {
            return this.value;
        }
    }

    private static final Absent<?> ABSENT = new Absent<>();
    private static final Null<?> NULL = new Null<>();

    public static <T> PropertyValue<T> absent() {
        return (PropertyValue<T>) ABSENT;
    }

    public static <T> PropertyValue<T> nulled() {
        return (PropertyValue<T>) NULL;
    }

    public static <T> PropertyValue<T> value(final T value) {
        return new Value<>(requireNonNull(value, "value cannot be null"));
    }

    public static <T> PropertyValue<T> valueOrAbsent(final Optional<T> value) {
        return value.map(PropertyValue::value).orElse(absent());
    }

    public static <T> PropertyValue<T> valueOrNull(final Optional<T> value) {
        return value.map(PropertyValue::value).orElse(nulled());
    }

    PropertyValue() {}

    public boolean isAbsent() {
        return this insanceof Absent;
    }

    public boolean isNull() {
        return this instanceof Null;
    }

    public Optional<T> getValue() {
        return this instanceof Value ? Optional.of(((Value<T>) this).getValue()) : Optional.empty();
    }
}

Serialization
The POJO Builder method for a (required: false, nullable: true) value would look like:
Builder withFoo(final PropertyValue<String> value);

Having to construct a PropertyValue instance might be annoying, so we could consider extra builder methods like:
Builder withAbsentFoo();
Builder withAbsentFoo(final Optional<String> foo);  // converts empty to absent
Builder withNullFoo();
Builder withNullFoo(final Optional<String> foo);  // converts empty to null
Builder withFoo(final String foo);  // requires a non-null value

I don't really love the explosion of methods there, but I don't want people to have to use PropertyValue.  If we like this a lot, we could even eliminate PropertyValue entirely in favor of these five methods.
For all other (required, nullable) cases we wouldn't need PropertyValue at all, because it becomes either a two-state (where we'd take Optional directly and convert empty into absent or null depending on what's allowed) or one-state (a non-null bare value, since a value is required).
For Jackson, to do this properly, we have to require a minimum of Jackson 2.6, when JsonInclude.Include.NON_ABSENT was introduced.
We can use the @JsonInclude annotation:

required
nullable
Annotation Value
Property Signature

false
false
NON_ABSENT
Optional<T>, can be empty or of

false
true
NON_NULL
Optional<T>, can be null, empty, or of

true
false
(none)
T, disallow null

true
true
(none)
Optional<T>, can be empty or of

Another option is to eschew the annotations and Optional/null and write our own custom JsonSerializer instance for each class.  This is probably easier to generate, and easier to prove that it's correct, but the generated code will be less readable.
Deserialization
For deserialization we almost do the right thing already.
For (required: true, nullable: true) we do the wrong thing, and treat it as nullable: false; in this case we should be using Optional<T>.
For the (required: false, nullable: true) case, we do the right thing, but we lose information.  The receiver of the object cannot tell the difference between absent and null.  For a server PATCH implementation, for example, this distinction might be important: absent might mean "don't update this property" and null might mean "unset the value of this property".  For that case it could be useful to expose PropertyType and have convenience methods like boolean isAbsent() and boolean isNull(), as well as Optional<T> getValue().

Implementation in Guardrail
I think we need to refactor ModelProtocolTerm's TransformProperty.  There's a bunch of common stuff there that should be handled in the same way regardless of the protocol generator.  Perhaps break out the non-common parts such as:

ExtractDefaultValue
ExtractDependency
RenderParameterTerm

And then the generic ProtocolGenerator class will be responsible for building the ProtocolParameter instance with that information, plus the generic information (empty to null behavior, required/nullable status, raw property name, and (in the future) redaction state).
The required/nullable status should be modeled as such:
sealed trait PresenceRequirement
case object Optional extends PresenceRequirement
case object OptionalNullable extends PresenceRequirement
case object Required extends PresenceRequirement
case object RequiredNullable extends PresenceRequirement

It seems that x-nullable is a widely-used vendor extension for Swagger v2 specs, which lack nullable.  The official swagger parser's v2-to-v3 converter will look for x-nullable and propagate that value to nullable.

After some more thought, I'm actually thinking about just using Optional<Optional<T>>  for the (required: false, nullable: true) case.  It's slightly awkward, to be sure, but I don't really like the idea of an awkward wrapper ADT either.  And that particular case will likely not be that common, maybe?  The other cases can be represented by T or Optional<T>.

I think that could be ok. The assumptions are:

nullable: true is not common enough to need special casing
If it does end up needing special casing, overloading the builder methods allows gradual migration to new behavior
Explicitly hard-coding Some(fooOpt) vs barOptOpt communicates intent, the types being uncommon can guide users to discover the nullability without reading the docs.

hey guys, i come here from #570 :) has there been any more thinking about how to go about this?
I feel that for swagger 2, the behaviour for required: false should be configurable - because if you are a client and the service is implemented in such a way that null fields are not supported you are screwed otherwise

I haven't really had time to look into this again.  After some working on a branch, I found it's a lot harder to do properly than I thought.  I would like to revisit it at some point.
While Swagger 2 doesn't officially support it, a lot of people use x-nullable there, to the point where the Swagger folks added support for it to the official parser, so that should be fine for v2 users.
The thing I'm concerned about now is that we've had (incorrect) v3 support for so long that if we change it now, we'll break specs and code that expect the old behavior.

A little more background:  The last time I played with this, I was using a custom type for the tristate (not-present, present-but-null, present-with-value), and I think I decided that as ugly as it may seem to look, using Option[Option[T]] is actually the best choice.
The difficultly then becomes teaching the serializers and deserializers to play nice with that representation.  I think circe is now used in a way that it wouldn't be so hard (manually making Encoders/Decoders instead of using .forProductN()), but for jackson, I'd need to switch to manually writing serializers/deserializers rather than relying on jackson's annotations, which is a pain and makes the generated code a ton more verbose than it is now (on the other hand, it makes the ser/deser with jackson much more flexible).
It wouldn't be too hard to get started on this, however: TransformProperty in ModelProtocolTerm would need to be changed so instead of passing isRequired, it would pass a tri-state, and then the individual impls could decide how to determine the final type of the property when it constructs the ProtocolParameter.  So it requires only a little bit of core work, and after that it's all in the generators. @tomasherman I think you're mainly interested in the scala side of the house, yeah?  If you wanted to get started on this, I think it wouldn't be too bad; as I said, the circe bits are are probably eaier to handle than jackson.  I wouldn't mind starting off a branch with the core work if you'd feel more comfortable with that.

I'm going to implement this for scala/circe. Here is the approach I'm going to use that I would like to validate.
Here is the mapping between required/nullable to a type:

Required
Nullable
PropertyRequirement
Type

true
false
Required
T

true
true
RequiredNullable
Option[T]

false
false
Optional
Option[T]

false
true
OptionalNullable
Option[Option[T]]

Here is current behavior:

Type
Required
PropertyRequirement

Encoder
true
Required

Decoder
true
Required

Encoder
false
RequiredNullable

Decoder
false
OptionalNullable

It's obvious that if we want to keep backwards compatibility, a single PropertyRequirement won't work as there is different behavior for encoders and
decoders. Also it's even more complicated OptionalNullable should have a type Option[Option[T]] but it currently expects only Option[T].
So here is what I propose:

Add a new variant of PropertyRequirement: OptionalLegacy which decodes the same as OptionalNullable but has type Option[T]
Eventually make default PropertyRequirement configurable.

one thing that me nad @strnad disagree about and could use some guidance from you guys is how required:false, nullable: true should be represented ... im a little worried that Option[Option[T]] is pretty confusing and i would prefer something like
sealed trait Presence[A] {
def map; flatMap; getOrElse; toOption;
}
case class Present(a: A) extends Presence[A]
case class Missing extends Presence[Nothing]

and the value would then be represented as Present(Some(x)) Present(None) or Missing
what do you think? I think it adds clarity at the cost of small ADT which i think is worth it

I think for scala I would prefer the small ADT for this, as Option[Option[T]] is not at all clear.  Do put the ADT in common code via framework support defs, instead of re-defining it for each DTO class.  Adding some behavior to it (as you suggest) to allow map/flatmap/etc. is a nice touch.
For java I will probably do Optional<Optional<T>>, unfortunately, as 1) ADTs in java are annoying and verbose, 2) since java has to use builder pattern, I can still make the API nice and avoid exposing that gross type signature.
@blast-hardcheese should definitely weigh in here tho.


after night 12 isha time change , it show next day data before fajr

prayerTimes.ishaStartTime : 2023-11-25 18:30:15.000+0600 it should be 2023-11-24 18:30:15.000+0600
prayerTimes.ishaEndTime : 2023-11-26 05:01:00.000+0600 it shuld be 2023-11-25 05:01:00.000+0600
I checked it at 3 am 2023-11-25 but before Fajr, it should remain the same as the 2023-11-24 start time of Isha After Fajar I think it should be changed

it will be solve in next update ...
thank you


Dark Mode for Home Page

Current Behavior
By default, the home page has some light and some dark sections. That is good for viewing site in light mode, but in dark mode the whites don't look so good.
Desired Behavior
I want to add an option for dark mode, which will change the following sections (which are by default white) to dark:

About

Sponsors

FAQ

Contact Us

Screenshots / Mockups
These sections could use a dark mode:

Can I work on this issue as part of GSSOC 23?

I am working on it bro.

Okay.


local variable 'r' referenced before assignment in ee_export_image_collection

Environment Information

Wed Feb 08 08:39:21 2023 EST
OS | Linux | CPU(s) | 40 | Machine | x86_64
Architecture | 64bit | Environment | Jupyter
Python 3.9.7 (default, Sep 16 2021, 13:09:58) [GCC 7.5.0]
geemap | 0.19.6 | ee | 0.1.338 | ipyleaflet | 0.17.2
folium | 0.14.0 | jupyterlab | 3.5.3 | notebook | 6.5.2
ipyevents | 2.0.1 |   |   |   |
Intel(R) oneAPI Math Kernel Library Version 2021.4-Product Build 20210904 for Intel(R) 64 architecture applications

Description
I am tried to download imagery that was preprocessed on Google Earth Engine using ee_export_image_collection, but I am occasionally running into an 'error' where the function stops downloading and prints the following message:
Exporting 7/323: 20190203T160459_20190203T160859_T18TUN.tif
Generating URL ...
Downloading data from https://earthengine.googleapis.com/v1alpha/projects/earthengine-legacy/thumbnails/8d961ce67171185b859b027bd6cfd8c4-12ef7e4cf535293448fb4a6299ddc8b8:getPixels
Please wait ...
An error occurred while downloading.
local variable 'r' referenced before assignment
I am not sure what 'r' is, but it is not a part of my script.
What I Did
# Cloud masking algorithm for Sentinel-2 clouds
def maskS2clouds(image):
    qa = image.select('QA60')
    neighbor_size = 30         # 30 pixels or 300 meters
    quality_threshold = 0.05   # above 5% of cloud or shadow would be masked

    # Bits 10 and 11 are clouds and cirrus, respectively.
    cloudBitMask = 1 << 10
    cirrusBitMask = 1 << 11

    # Both flags should be set to zero, indicating clear conditions.Both flags should be set to zero, indicating clear conditions.
    mask = qa.bitwiseAnd(cloudBitMask).eq(0) \
      .And(qa.bitwiseAnd(cirrusBitMask).eq(0))

    """
    *  Account for shadow effect and use neighborhood average
    """
    # calculate the neighborhood average (NA) fraction of cloud (SCL 8-10)
    cldPrbNA = image.select('SCL').gte(8).And(image.select('SCL').lte(10)) \
        .reduceNeighborhood(**{
            'reducer': ee.Reducer.mean(),
            'kernel': ee.Kernel.circle(neighbor_size)
        }).rename('cldPrbNA')

    # calculate the neighborhood average (NA) fraction of shadow (SCL 3)
    cldShadowNA = image.select('SCL').eq(3) \
        .reduceNeighborhood(**{
            'reducer': ee.Reducer.mean(),
            'kernel': ee.Kernel.circle(neighbor_size)
        }).rename('cldShadowNA')

    # the NA fraction of clouds and shadow
    cldTotalNA = cldPrbNA.add(cldShadowNA)

    # Update the mask, cldTotalNA should be lower than quality_threshold defined above
    mask = mask.And(cldTotalNA.lt(quality_threshold))
    return image.updateMask(mask).divide(10_000) \
        .addBands(cldPrbNA).addBands(cldShadowNA) \
        .copyProperties(image, ['system:time_start'])

# Calculate EVI for the scene
def addVegetationIndices(image):
    EVI = image.expression(
        '2.5 * ((NIR - RED) / (NIR + 6 * RED + 7.5 * BLUE + 1))',
        {
            'NIR': image.select('B8'),
            'RED': image.select('B4'),
            'BLUE': image.select('B2')
        }).rename('EVI')

    # Return the masked image with NIRv and EVI bands.
    return image.addBands(EVI)

##################################################################
# Specify download region and prepare scene
##################################################################

region = ee.Geometry.Polygon(
    [float(args.left), float(args.top),
     float(args.left), float(args.bottom),
     float(args.right), float(args.top),
     float(args.right), float(args.bottom)], None, False)

# Setup Sentinel-2 image collection over study region with low(ish) cloud cover
site_images = ee.ImageCollection("COPERNICUS/S2_SR_HARMONIZED") \
    .filterBounds(region) \
    .filter(ee.Filter.lt('CLOUDY_PIXEL_PERCENTAGE', 80)) \
    .map(maskS2clouds).map(addVegetationIndices) \
    .map(lambda x: x.clip(region)).select(['EVI'])

# Download data
geemap.ee_export_image_collection(site_images, out_dir='.')

This appeared to be the issue. I added some additional code to remove images with no bands, and everything seems to be working now. Thank you!


Translation broken on mobile view

Translate
[skin-dark]
other = "sombre"
[skin-light]
other = "clair"
OK on desktop view
Broken on mobile view

Uncaught TypeError: Cannot read property 'includes' of undefined
at setMetaColor ((index):534)
at HTMLAnchorElement. ((index):596)


use 'it' instead of 'test'

What docs page needs to be fixed?

Section: Reducers
Page: https://redux.js.org/usage/writing-tests

What is the problem?
When using sentences like "should handle a todo being added to an empty list", shouldn't we use the 'it' function instead of 'test'?
Like explained here: https://stackoverflow.com/questions/45778192/what-is-the-difference-between-it-and-test-in-jest
What should be changed to fix the problem?
change 'test' to 'it', in the code example.

This is a preference thing that doesn't add any clarity to these docs. Some teams adopt it instead of test, but for the sake of examples, test is a bit more explicit than requiring someone to know what jest's aliases are. If this really bothers you, you could open a PR for these changes, but IMO it's not necessary whatsoever.

For me it doesn't matter, just for who uses the docs, not to create a confusion with the stackoverflow answer. I understand that 'test' is clearer, so maybe it's better to change the description that's passed to the test function. Anyway, whatever you decide of course : ).


Refactor/remove interface from api

Two major points from my side (nitpicks come later)

I'd change a lot of occurrences from *API to 'only' API, as no copies will be made most of the time since they are in a slice or map
I'd still call the ApiMap ApiMap, not APIs. APIs sound more like a slice, not a Map, what it is in the end (and used as such, which makes for me the important difference. If it would be used only with methods, I would not care, but the object is used as a map everywhere)

I also need to have a deeper look

naming APIs is same approach sas type Environments map[string]EnvironmentDefinition and it leads to the point where inner implementation is going to be closed and exposed only via well defined functions and methods.

naming APIs is same approach sas type Environments map[string]EnvironmentDefinition and it leads to the point where inner implementation is going to be closed and exposed only via well-defined functions and methods.

Those are bad, and a future refactoring of mine would be to get rid of them.
The map[] is really not useful and usually results in duplicate information. For APIs, where we have a lot and need to look it up often, it makes sense.
But for the naming, I'd still go with ApiMap.
Environments does not sound like a map[string]Env, nor does Projects. Sound more like Env[] and Project[].

Please also add documentation to all public functions/types that you added. For this PR I would argue to keep it to all changes in the internal/api package as it's the main focus


test coverage is low

Currently, coverage is pretty low. We need to decide on ignoring files correctly in .coveragerc that cannot be tested, and also add more tests.

I think this has to be related to Coveralls not finding our files correctly. It runs the tests, but on the website none of the files can be viewed. When I click on the files it says "source not available".