Suddenly it does not work anymore

I'm using this plugin and I really like it.
But suddenly it didn't work anymore. I uninstalled and installed it but nothing changed.
What can I do about this?

Hello @JeroenvanRensen !
In the latest version, I've switched to Semantic Token API. Now Syntax Highlighter uses current theme colors out-of-box. You can refer this section of the docs.
Kindly check that semantic highlighting is enabled in your settings.json using any of these methods:
"editor.semanticHighlighting.enabled": true,
"editor.semanticTokenColorCustomizations": {
    "enabled": true,
    "[Material Theme High Contrast]": {
        "enabled": true,
    }
},

If you use Syntax Highlighter for C++ I would recommend also disable enhanced C++ colorizations "C_Cpp.enhancedColorization": "Disabled,". Otherwise, two highlighting systems may interfere.

Hi @EvgeniyPeshkov,
Thank you very much for your quick and detailed answer.
I currently use the settings as mentioned below, but they aren't 100% the old color settings. Do you have an array for those settings?
However, thank you very much for this great plugin!
Jeroen
"editor.semanticTokenColorCustomizations": {
    "enabled": true,
    "[Default Dark+]": {
        "enabled": true,
        "rules": {
            "type":  "#26A69A",
            "namespace": "#00897B",
            "function": "#00BCD4",
            "variable": "#42A5F5",
            "number": "#90A4AE",
            "string": {
                "foreground": "#90A4AE",
                "italic": true
            },
            "comment": {
                "foreground": "#546E7A",
                "fontStyle": "italic"
            },
            "variable.readonly.defaultLibrary": "#A89F9B",
            "macro": "#7E57C2",
            "keyword": "#7986CB",
            "operator": "#9575CD",
            "type.modification": "#00897B",
            "punctuation": "#A1887F"
        }
    }
}

Hi @JeroenvanRensen ! Sorry for the delay.
Here is the config I use to make colors exactly like they were before:
"editor.semanticHighlighting.enabled": true,
"editor.semanticTokenColorCustomizations": {
    "enabled": true,
    "[Current Theme]": {
        "enabled": true,
        "rules": {
            "type": "#26A69A",
            "namespace": "#00897B",
            "function": "#00BCD4",
            "variable": "#42A5F5",
            "number": "#90A4AE",
            "string": "#90A4AE",
            "comment": "#546E7A",
            "variable.readonly.defaultLibrary": "#A89F9B",
            "macro": "#7E57C2",
            "keyword": "#7986CB",
            "operator": "#9575CD",
            "type.modification": "#00897B",
            "punctuation": "#A1887F"
        }
    }
},

@EvgeniyPeshkov Thank you very much!


Re-enable skipped unit tests

Replacing required_torch_version utility function with required_minimum_torch_version. The old function was causing several tests to be skipped on runners that use torch 2.x

LGTM, might be good to switch to use something like packaging to help prevent issues like this in the future though.

Added this in the latest commit and refactored the required_*_torch_version functions to just required_torch_version


feat(queryByCurrentValue)

What: It adds queryByCurrentValue, getByCurrentValue, queryAllByCurrentValue and getAllByCurrentValue.

Why: getByValue cannot get elements with value property (it only checks DOM value attributes)
(Discussed at #166)

How: Added a set of (get|query)(All)?ByCurrentValue methods.

Checklist:

[ ] Documentation
[x] Tests
[ ] Ready to be merged
[ ] Added myself to contributors table

Feel free to give any feedbacks.

Closes #158

Thanks for the review. I made changes regarding your three comments.

Looks good! Just need docs and a test to execute line 358 (the error state for queryAllBy...) to keep coverage at 100%.
Also it might be nice to add an integration test for fireEvent.change() with getCurrentValue.

@alexkrolick I've added a test to check if it throws.
@kentcdodds I've renamed and updates the README.md. I didn't know how to edit it, so it's kind of a draft. Where do you want to put the section in the document? And how do you want to explain it to users? Take a look at the doc and let me know. Besides, I'm not a native English speaker, so pretty much worried about it 😅

@kentcdodds done! I've used container instead of document.body since I found out other parts of the doc used container.

Looks like we're missing some coverage. You can open the coverage report in the browser in coverage/lcov-report to see what's missing.

@kentcdodds coverage 100% done

Updated the doc. Thanks for pointing it out @alexkrolick

:tada: This PR is included in version 3.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Awesome! Thank you :) This merge made my day!!!


Inference speed on ubuntu20.04 is more than twice as slow as inference speed on ubuntu18.04

Description
I use servers with AI Accelerator PCIe Card.
ubuntu18.04
I installed ubuntu18.04 (kernel version 4.18 or lower) and configured it according to Get started with the M.2 or Mini PCIe Accelerator
At this time, I installed libedgetpu1, not libedgetpu1-std, but libedgetpu1-max.
In particular, the following command.
sudo apt-get install gasket-dkms libedgetpu1-max

After setting this up, I ran the inference process multiple times, and it took about 4 milliseconds after the second inference.
It varies depending on the inference process, but it is between 3.5 and 4.5 milliseconds.
ubuntu20.04
On the same physical server, I reinstall ubuntu20.04 (kernel version 4.19 or higher)  and run in this manual I set it up in the same way, including the car section.
I reinstalled ubuntu20.04 (kernel version 4.19 or higher) on the same physical server and set it up, including "Workaround to disable Apex and Gasket" section of Get started with the M.2 or Mini PCIe Accelerator
I installed libedgetpu1-max as I did on ubuntu18.04
sudo apt-get install gasket-dkms libedgetpu1-max

In this case, when I let the inference process run multiple times, it took about 11.2 milliseconds after the second inference.
It varies depending on the inference process, but it is between 11.0 and 11.4 milliseconds.
Requests
Is there a setting to make ubuntu20.04 infer at the same speed as ubuntu18.04 (about 4ms)?
If there are problems on the pycoral side, I want them fixed.
Click to expand!
Issue Type
Performance
Operating System
Ubuntu
Coral Device
No response
Other Devices
No response
Programming Language
Python 3.6, Python 3.9
Relevant Log Output
No response

@arrowkato Please paste the output of below commands from both the machines:

modinfo gasket
modinfo apex
uname -a

The configuration with Ubuntu 20.04 and Python 3.9.7 and pycoral 2.0.0 was slow to the extent described top message.
The configuration of Ubuntu20.04 and Python3.9.10 and pycoral 2.0.0 was almost as fast as the configuration of ubuntu18.04 and python3.6 and pycoral1.0.1.
So the problem for us was solved.
Thank you.


Transfer Learning with pre-trained models

Transfer learning can significantly improve model performance with less training data. Adding examples using pre-trained models (e.g., VGG16, ResNet) for tasks like image classification or feature extraction.
Proposed Examples:

Include code for fine-tuning the pre-trained model on a new dataset
Demonstrate the process of feature extraction using pre-trained models
Provide detailed comments and explanations of each step

Benefits:

Enhances the repository by including advanced neural network techniques
Helps users understand and implement transfer learning in their projects
Shows the performance improvements achievable with transfer learning compared to models trained from scratch

Additional Context:

Transfer learning is particularly useful when dealing with limited data, as it leverages the knowledge gained from large datasets used to train the pre-trained models.
Examples can be implemented in Jupyter notebooks to provide an interactive learning experience.

@sanjay-kv I am GSSOC'24 Contributor and would like to work on this issue.

@sanjay-kv I am GSSOC'24 Contributor and would like to work on this issue.

@ShaikArshidBanu Let me know if you would like to collab with @Neha1073

@sanjay-kv  I would like to work alone.

please assign this task to me


Can I delete the recording I shared on terminalizer?

Hi support team,
I shared some recording I really wanted to delete, but I can't seem to find any doc related to delete a recoding

Hello,
Yes you can. There is an edit icon beside the title of the recording. Click on it then you will find the way to delete it.


Added MichaelClifford as OWNERS

Added MichaelClifford as OWNERS

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign tumido after the PR has been reviewed.
You can assign the PR to them by writing /assign @tumido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

add yourself to owners and reviewers too :)

/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: MichaelClifford
To complete the pull request process, please assign tumido after the PR has been reviewed.
You can assign the PR to them by writing /assign @tumido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[Tesero y Gloria] New sheet

Changes / Comments

New Character Sheet for "Tesero y Gloria", by the publisher @Tenfes
This is a cleaned up version of #5684 where I placed the the new sheet in a separate folder from the old TyG sheet, fixed the filenames, uploaded sheet logo. By not replacing the old sheet folder, this PR could be approved whether the old sheet is kept or not.
The sheet.json still lacks the authors roll20id
The sheet submission does not comply with Minimum Standards as it uses a few <table> to layout things, but considering it's otherwise seems good, and is made by the publisher, there could be a reason to approve it anyway.

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

@Tenfes, if you mention your roll20 id here, I can add it to the PR, and then things should be fine.
The "roll20 id" can be found by going to your profile, and looking at the url. My Roll20 account for example is https://app.roll20.net/users/1223200/andreas-j , where that number is my roll20id.

Hi, sorry for the delay,
I already rewrote the code without the table styling, but I'm having some
trouble putting the folder into the pull again. Sorry, I'm quite new to
programming, this is my first work. Could I send the folder to you here so
you could put it back into GitHub? I would be very thankful.
Greetings,
Telmo
El dom., 17 nov. 2019 a las 13:32, Andreas J<EMAIL_ADDRESS>escribió:

@Tenfes https://github.com/Tenfes, if you mention your roll20 id here,
I can add it to the PR, and then things should be fine.
The "roll20 id" can be found by going to your profile, and looking at the
url. My Roll20 account for example is
https://app.roll20.net/users/1223200/andreas-j , where that number is my
roll20id.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/pull/5685?email_source=notifications&email_token=ANZK3M7EV3T7BOOMBBVKFALQUE2WPA5CNFSM4JOJTTP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEIK2YQ#issuecomment-554741090,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZK3M3BXJ5NL6SWXNQQPITQUE2WPANCNFSM4JOJTTPQ
.

You can share the new version of the sheet with a Gist, and I'll copy and update the changes, no problem.

Thank you! Here is the gist for the html and css, the other items are the
same.

El dom., 17 nov. 2019 a las 13:49, Andreas J<EMAIL_ADDRESS>escribió:

You can share the new version of the sheet with a Gist
https://gist.github.com/, and I'll copy and update the changes, no
problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/pull/5685?email_source=notifications&email_token=ANZK3M4XKDNUZYRVNXUCOZTQUE4V5A5CNFSM4JOJTTP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEILEXI#issuecomment-554742365,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZK3M6AI2OFMCIXLBC6E3TQUE4V5ANCNFSM4JOJTTPQ
.

That sheet version looks same as the first one, I see all the same tables still exist.

That can't be, the name (nombre), gloria, fama, etc are all in columns now,
not in tables. I only left there the tables for the equipment (weapons and
protections), and the ones at tab of Monstruos for the attacks.
El dom., 17 nov. 2019 a las 14:17, Andreas J<EMAIL_ADDRESS>escribió:

That sheet version looks same as the first one, I see all the same tables
still exist.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/pull/5685?email_source=notifications&email_token=ANZK3M774SZWVWHCKNY5ILDQUFAABA5CNFSM4JOJTTP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEILXRA#issuecomment-554744772,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZK3M76YXJ32RPJEYFUPE3QUFAABANCNFSM4JOJTTPQ
.

Oh you changed one table, I missed that. Still, you have all those other tables. We will see on Monady when Roll20 reviews these, if that is enough changes.
Did you found out your roll20id ? It can be found if you go to your roll20 profile, and look at the numbers in the URL, like I pointed out.

There are 4 tables in total: Características, Armas, Protecciones y Ataques
(in Monstrruos), ¿is that still a lot? I don't have a clear idea of how
much would be too much :(
Oh, and right, i got my id: 101803
El dom., 17 nov. 2019 a las 14:41, Andreas J<EMAIL_ADDRESS>escribió:

Oh you changed one table, I missed that. Still, you have all those other
tables. We will see on Monady when Roll20 reviews these, if that is enough
changes.
Did you found out your roll20id ? It can be found if you go to your
roll20 profile, and look at the numbers in the URL, like I pointed out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/pull/5685?email_source=notifications&email_token=ANZK3M63XS7Z3AG6OLQGTADQUFCYDA5CNFSM4JOJTTP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEIMG5Q#issuecomment-554746742,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZK3M4MME3LHSTJIIMIJ33QUFCYDANCNFSM4JOJTTPQ
.

According to the Minimum Requrements:

Proper HTML Syntax. Proper HTML syntax is encouraged to increase accessibility and make the code maintainable for community contributions. As a general standard a <table> element should only be used for tabular data. The <table> shall not be used for layouts. All new sheets are expected to use proper containers elements such as <div> and <span> elements. Your HTML file must not use <head> or <body> tag, or your character sheet may not load in the virtual tabletop.

This is a PR that was turned down by Roll20, due to using <table> for layout.
If it's important for you to get the sheet approved next week, changing all tables now would be a good idea, to avoid the risk of getting delayed.
If you're in no hurry, then just wait until you get Official Roll20 response on Monday, and see if you can avoid doing more work on the sheet. Considering you're the author of the game system itself, it's possible Roll20 might soften the minimum demands, but we will see what they say tomorrow.
You can look at the things I pointed out, and decide what you do.
I do not know 100% what Roll20 will say, I'm just pointing out the guidelines they have made for us and how they have decided previously so that you can do things now, instead of hearing more or less the same from Roll20.

OK, thanks for all your help ^^
El dom., 17 nov. 2019 a las 15:05, Andreas J<EMAIL_ADDRESS>escribió:

According to the Minimum Requrements
https://wiki.roll20.net/Building_Character_Sheets#Minimum_Requirements:
Proper HTML Syntax. Proper HTML syntax is encouraged to increase
accessibility and make the code maintainable for community contributions. As
a general standard a <table> element should only be used for tabular
data. The <table> shall not be used for layouts. All new sheets are
expected to use proper containers elements such as <div> and <span>
elements. Your HTML file must not use <head> or <body> tag, or your
character sheet may not load in the virtual tabletop.
This is a PR that was turned down
https://github.com/Roll20/roll20-character-sheets/pull/5548 by Roll20,
due to using  for layout.
If it's important for you to get the sheet approved next week, changing
all tables now would be a good idea, to avoid the risk of getting delayed.
If you're in no hurry, then just wait until you get Official Roll20
response on Monday, and see if you can avoid doing more work on the sheet.
Considering you're the author of the game system itself, it's possible
Roll20 might soften the minimum demands, but we will see what they say
tomorrow.
You can look at the things I pointed out, and decide what you do.
I do not know 100% what Roll20 will say, I'm just pointing out the
guidelines they have made for us and how they have decided previously so
that you can do things now, instead of hearing more or less the same from
Roll20.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/pull/5685?email_source=notifications&email_token=ANZK3M73M52CL36VUH2YQK3QUFFSDA5CNFSM4JOJTTP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEIMYZQ#issuecomment-554749030,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZK3MZ5MRILNHPW6CD7A63QUFFSDANCNFSM4JOJTTPQ
.

I'll cleanup the code some more, so that future changes to the sheet should be easier to make.

@Tenfes There you heard it.
I'd suggest you continue from my version of the sheet to do the rest of the conversion, instead of yours. Unfortunately I won't have time to help further in the near future, but this submission just needs the <table> converted and then it's fine.

Yep, is a pein, but I understand... thanks so mucho for your help!
El lun., 18 nov. 2019 a las 20:21, Andreas J<EMAIL_ADDRESS>escribió:

@Tenfes https://github.com/Tenfes There you heard it.
I'd suggest you continue from my version of the sheet to do the rest of
the conversion, instead of yours. Unfortunately I won't have time to help
further in the near future, but this submission just needs the
converted and then it's fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/pull/5685?email_source=notifications&email_token=ANZK3M7BLMDGWQTST4SV2ZDQULTLJA5CNFSM4JOJTTP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELTELA#issuecomment-555168300,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZK3MZWC2DDE55MHBX6QJDQULTLJANCNFSM4JOJTTPQ
.

@Tenfes I added your changes into this PR, your where misplaced withing the old forder and didn't have the updated images. But with this I'm sure the sheet is ready to be approved next Monday.


taxonomic scope of "renal system development"

Prompted by AGR expression ribbon discussion
id: GO:0072001
name: renal system development
namespace: biological_process
def: "The process whose specific outcome is the progression of the renal system over time, from its formation to the mature structure. The renal system maintains fluid balance and contributes to electrolyte balance, acid/base balance, and disposal of nitrogenous waste products. In humans, the renal system comprises a pair of kidneys, a pair of ureters, urinary bladder, urethra, sphincter muscle and associated blood vessels." [GOC:mtg_kidney_jan10, GOC:yaf, http://en.wikibooks.org/wiki/Human_Physiology/The_Urinary_System]
synonym: "urinary system development" BROAD [GOC:yaf]
synonym: "urinary tract development" BROAD [GOC:yaf, PMID:17881463]
is_a: GO:0048731 ! system development
intersection_of: GO:0048731 ! system development
intersection_of: results_in_development_of UBERON:0001008 ! renal system
relationship: part_of GO:0001655 ! urogenital system development

What is the intended taxonomy scope here? The accompanying kidney paper explicitly mentions tubules (which includes drosophila, but would exclude C elegans). Indeed the term has been used for Dmel but not Cele.
The uberon class follows the def of the GO class, taking the kidney paper as reference. But it is mapped to excretory system in WBbt, which makes it implicitly broader than GO. Also, since Uberon treats it broader, GO does not inherit a TC that excludes Cele, if that is the intention.
I'm not sure if all the following is true for the Cele excretory system, I think so?
"...maintains fluid balance and contributes to electrolyte balance, acid/base balance, and disposal of nitrogenous waste products"
It's not really clear that we require a term that is broad enough to cover Dmel + verts yet exclude Cele. We already have http://amigo.geneontology.org/amigo/term/GO:0061326 "renal tubule development" which groups Dmel Malpighian tubules and true renal tubules, why do we need an additional level of Dmel + vert grouping?
Seems most straightforward to explicitly broaden the already broad "renal system" and relabel "excretory system" and include Cele. Of course, such broad pan-metazoa system-level groupings should be used with caution .e.g in gene propagation

@vanaukenk, I'll let you comment on this one. I don't recall discussing worms at the renal meeting, but if I recall correctly we did want to include flies.

"Seems most straightforward to explicitly broaden the already broad "renal system" and relabel "excretory system" and include Cele. Of course, such broad pan-metazoa system-level groupings should be used with caution .e.g in gene propagation."
I agree that a more general term of "excretory system development" would be useful and we could use that for C. elegans.  "renal system" is not used much at all in the C. elegans literature; "excretory system" is the preferred way of describing the analogous system in worms.
However, if we relabel the existing "renal system development" to be "excretory system development", then I think we'll need to revise the parentage in GO because the C. elegans excretory system is not mesodermally derived as the current part_of relation between "renal system development" and "urogenital system development" would imply.

Hi @vanaukenk. I'm not seeing the relationship to the mesoderm in AmiGO2. Where are you seeing it?

@ukemi
I was tracing that through UBERON.
In GO, 'renal system development' is part_of 'urogenital system development' and in UBERON, 'genitourinary system' (exact synonym: urogenital system ) (UBERON:0004122) has an is_a relation to 'mesoderm-derived structure' (UBERON:0004120).

Fixed to be specific to vertebrates.
(it's still a bit odd to have a genital + renal system grouping for many inverts? the coupling makes sense for verts where there are shared structures and development? at least the terminology 'urogenital system' seems a bit vertebratey)

I agree it is very verebratey.

Yes, it is vertebratey.
I just did a TPC search on the C. elegans literature for 'urogenital'.  The returned citations are referring to the vertebrate system in the intro or discussion section of papers, and not many papers are returned (49 out of a corpus of 23613 possible papers).

Hmm. So it seems that we would not only have to rename the renal system to be the excretory system, which doesn't seem to be much of a stretch. But we would have to sever the part_of link in Uberon between the new 'excretory system' and 'genitourinary system'. Then we would have to reassign the appropriate part_of renal system classes in UBERON to be part_of 'genitourinary system'. If we could reason over the partonomy in UBERON I think we would get correct classification in GO.

So it seems that we would not only have to rename the renal system to be the excretory system, which doesn't seem to be much of a stretch.

Yep

But we would have to sever the part_of link in Uberon between the new 'excretory system' and 'genitourinary system'. Then we would have to reassign the appropriate part_of renal system classes in UBERON to be part_of 'genitourinary system'.

Yes. We should always think carefully when removing links in the ontology if this will impact users. However, I think that by having part-ofs at the appropriate level will work here, as we should not be annotating directly to high level terms like renal/excretory system.
We already have links from specific embryonic classes like nephric ridge. Would also add to kidney.

If we could reason over the partonomy in UBERON I think we would get correct classification in GO.

Yes. We can start with mutual asserts just to ensure we don't lose info.

Good point, and what about CO2? But what we really want is this:
maintains fluid balance and contributes to electrolyte balance, acid/base balance, and disposal of nitrogenous waste products
ie we want something analagous to the renal system. Is there a better name we can use?

well osmoregulatory systems but that gets you ionocytes in fish and amphibians too.

The system needs to encompass the worm system that "...consists of just three unicellular tubes (canal, duct, and pore), a secretory gland, and two associated neurons. " https://dx.doi.org/10.1534%2Fgenetics.116.189357 as well as the pronephrose, mesanephrose and adult kidneys of vertebrates.    It looks like we need some sort of liquid excretory system.  Since in verts the colon/lower intestine contributes to fluid balance, electrolyte balance, acid/base balance, it is difficult to generalize by function enough to encompass C. elegans and verts without encompassing portions of the digestive system.

I think the main differentia, which I am not sure how to express succinctly is that the renal system and the C. elegans excretory cells  remove nitrogen waste, and provide osmoregulatory function to the non-gut  portion of the organism.  In fish and birds the renal products end up in the coacal chamber as do the outputs from the digestive system so the the entire system can't be physically disjoint.

The plot thickens. @mdolanme pointed out that we have 'renal system process' with exact synonym 'excretory system process'. I think we need to change this synonym to broad based on this discussion.

Should we at least have a do not annotate on it? Shouldn't you always know a more specific term?
Of direct annotations (93), all are in vertebrates, 18 are experimental.

I just spent the day going through all of the MGI annotations to renal system development and was able to change all of them to more specific terms describing either a more specific developmental process or at least point to more specific anatomical structures. A lot of these annotation were made before the kideny development project was done, so I suspect the terms I used didn't exist at the time. I think @cmungall 's suggestion is the most practical. We should mark the renal system development term a 'do not manually annotate' term and ask for annotation review of the remaining annotations.

Annotation review suggested in:
https://github.com/geneontology/go-annotation/issues/2392

'do not manually annotate'

why not use ''do not annotate'?

Fine with me.

@ukemi I've added 'do not annotate' to GO:0072001 renal system development
If that resolves this issue, please close the ticket.
Thanks, Pascale

Thanks! :-)

Hopefully it will work, but I can't see why it shouldn't. The taxon restriction on renal system is much looser, only_in some eumetazoa.

Fingers crossed!


planning: /chat/completions Documentation and Roadmap

Goal

Our /chat/completions should have parameters similar to OpenAI

Check if our implemetation is aligned
Create planning:  roadmap issues if it not supported yet
Goal: communicate that we are committed to OpenAI compatibility

Tasklist

[ ] Itemize Roadmap issues (once Dan approves, we will create Roadmap issues)
[ ] Update Swaggerfile

@nguyenhoangthuan99 - Please transfer https://github.com/janhq/internal/issues/160 to this issue (can be public)

API reference: https://platform.openai.com/docs/api-reference/chat/create
Missing supported fields from /v1/chat/completions API:

store boolean or null Optional Defaults to false Whether or not to store the output of this chat completion request for use in our model distillation or evals products. To support this, we should come up with an architecture to save and store output of chat completion requests of user. (e.g. MinIO for storage and postgres for DB).
metadata object or null Optional Developer-defined tags and values used for filtering completions in the dashboard.

This also require some logics to save result to DB then user can query later.
logit_bias map Optional Defaults to null. Modify the likelihood of specified tokens appearing in the completion. Accepts a JSON object that maps tokens (specified by their token ID in the tokenizer) to an associated bias value from -100 to 100. Mathematically, the bias is added to the logits generated by the model prior to sampling. The exact effect will vary per model, but values between -1 and 1 should decrease or increase likelihood of selection; values like -100 or 100 should result in a ban or exclusive selection of the relevant token. -> need to confirm llamacpp support this or not, but this might be nice to have feature.  Issue: https://github.com/janhq/cortex.llamacpp/issues/263
logprobs boolean or null Optional Defaults to false. Whether to return log probabilities of the output tokens or not. If true, returns the log probabilities of each output token returned in the content of message. This feature is partially supported, need up update cortex.llamacpp to return logprob when use stream/ non stream mode. Issue: https://github.com/janhq/cortex.llamacpp/issues/262

The result should look like this:
{
  "id": "chatcmpl-123",
  "object": "chat.completion",
  "created":<PHONE_NUMBER>,
  "model": "gpt-4o-mini",
  "choices": [
    {
      "index": 0,
      "message": {
        "role": "assistant",
        "content": "Hello! How can I assist you today?"
      },
      "logprobs": {
        "content": [
          {
            "token": "Hello",
            "logprob": -0.31725305,
            "bytes": [72, 101, 108, 108, 111],
            "top_logprobs": [
              {
                "token": "Hello",
                "logprob": -0.31725305,
                "bytes": [72, 101, 108, 108, 111]
              },
              {
                "token": "Hi",
                "logprob": -1.3190403,
                "bytes": [72, 105]
              }
            ]
          },
          {
            "token": "!",
            "logprob": -0.02380986,
            "bytes": [
              33
            ],
            "top_logprobs": [
              {
                "token": "!",
                "logprob": -0.02380986,
                "bytes": [33]
              },
              {
                "token": " there",
                "logprob": -3.787621,
                "bytes": [32, 116, 104, 101, 114, 101]
              }
            ]
          },
          {
            "token": " How",
            "logprob": -0.000054669687,
            "bytes": [32, 72, 111, 119],
            "top_logprobs": [
              {
                "token": " How",
                "logprob": -0.000054669687,
                "bytes": [32, 72, 111, 119]
              },
              {
                "token": "<|end|>",
                "logprob": -10.953937,
                "bytes": null
              }
            ]
          },
          {
            "token": " can",
            "logprob": -0.015801601,
            "bytes": [32, 99, 97, 110],
            "top_logprobs": [
              {
                "token": " can",
                "logprob": -0.015801601,
                "bytes": [32, 99, 97, 110]
              },
              {
                "token": " may",
                "logprob": -4.161023,
                "bytes": [32, 109, 97, 121]
              }
            ]
          },
          {
            "token": " I",
            "logprob": -3.7697225e-6,
            "bytes": [
              32,
              73
            ],
            "top_logprobs": [
              {
                "token": " I",
                "logprob": -3.7697225e-6,
                "bytes": [32, 73]
              },
              {
                "token": " assist",
                "logprob": -13.596657,
                "bytes": [32, 97, 115, 115, 105, 115, 116]
              }
            ]
          },
          {
            "token": " assist",
            "logprob": -0.04571125,
            "bytes": [32, 97, 115, 115, 105, 115, 116],
            "top_logprobs": [
              {
                "token": " assist",
                "logprob": -0.04571125,
                "bytes": [32, 97, 115, 115, 105, 115, 116]
              },
              {
                "token": " help",
                "logprob": -3.1089056,
                "bytes": [32, 104, 101, 108, 112]
              }
            ]
          },
          {
            "token": " you",
            "logprob": -5.4385737e-6,
            "bytes": [32, 121, 111, 117],
            "top_logprobs": [
              {
                "token": " you",
                "logprob": -5.4385737e-6,
                "bytes": [32, 121, 111, 117]
              },
              {
                "token": " today",
                "logprob": -12.807695,
                "bytes": [32, 116, 111, 100, 97, 121]
              }
            ]
          },
          {
            "token": " today",
            "logprob": -0.0040071653,
            "bytes": [32, 116, 111, 100, 97, 121],
            "top_logprobs": [
              {
                "token": " today",
                "logprob": -0.0040071653,
                "bytes": [32, 116, 111, 100, 97, 121]
              },
              {
                "token": "?",
                "logprob": -5.5247097,
                "bytes": [63]
              }
            ]
          },
          {
            "token": "?",
            "logprob": -0.0008108172,
            "bytes": [63],
            "top_logprobs": [
              {
                "token": "?",
                "logprob": -0.0008108172,
                "bytes": [63]
              },
              {
                "token": "?\n",
                "logprob": -7.184561,
                "bytes": [63, 10]
              }
            ]
          }
        ]
      },
      "finish_reason": "stop"
    }
  ],
  "usage": {
    "prompt_tokens": 9,
    "completion_tokens": 9,
    "total_tokens": 18,
    "completion_tokens_details": {
      "reasoning_tokens": 0
    }
  },
  "system_fingerprint": null
}

n integer or null Optional Defaults to 1. How many chat completion choices to generate for each input message. Note that you will be charged based on the number of generated tokens across all of the choices. Keep n as 1 to minimize costs. -> need to check if llama.cpp support this option. Issue: https://github.com/janhq/cortex.llamacpp/issues/264

service_tier string or null Optional Defaults to auto.
Specifies the latency tier to use for processing the request. This parameter is relevant for customers subscribed to the scale tier service:
If set to 'auto', and the Project is Scale tier enabled, the system will utilize scale tier credits until they are exhausted.
If set to 'auto', and the Project is not Scale tier enabled, the request will be processed using the default service tier with a lower uptime SLA and no latency guarentee.
If set to 'default', the request will be processed using the default service tier with a lower uptime SLA and no latency guarentee.
When not set, the default behavior is 'auto'.
When this parameter is set, the response body will include the service_tier utilized.

stream_options object or null Optional Defaults to null Options for streaming response. Only set this when you set stream: true. -> need to update cortex.llamacpp to support this. Issue: https://github.com/janhq/cortex.llamacpp/issues/265

The following fields cannot be supported directly with cortex.cpp and need road map for it in the enterprise version:

store boolean or null Optional Defaults to false Whether or not to store the output of this chat completion request for use in our model distillation or evals products. To support this, we should come up with an architecture to save and store output of chat completion requests of user. (e.g. MinIO for storage and postgres for DB).

metadata object or null Optional Developer-defined tags and values used for filtering completions in the dashboard.

This also require some logics to save result to DB then user can query later.

service_tier string or null Optional Defaults to auto.
Specifies the latency tier to use for processing the request. This parameter is relevant for customers subscribed to the scale tier service:
If set to 'auto', and the Project is Scale tier enabled, the system will utilize scale tier credits until they are exhausted.
If set to 'auto', and the Project is not Scale tier enabled, the request will be processed using the default service tier with a lower uptime SLA and no latency guarentee.
If set to 'default', the request will be processed using the default service tier with a lower uptime SLA and no latency guarentee.
When not set, the default behavior is 'auto'.
When this parameter is set, the response body will include the service_tier utilized.

modalities and audio: reference: https://platform.openai.com/docs/api-reference/chat/create#chat-create-modalities. We need a roadmap to support multimodalities for audio.

user : reference: https://platform.openai.com/docs/api-reference/chat/create#chat-create-user.

[x] Linked documentation to this issue in this PR #1589


Do the default models include BERT embeddings?

Just curious if the default models (specifically benepar_en2 or benepar_en2_large) include BERT embeddings? I see references to BERT and ELMo in the training section. Do we need to do that training ourselves if we want a parser to use those embeddings, or are they already included?
And more importantly, even if the default models don't include BERT/ELMo embeddings, is it worth doing the training?
Thanks!

These are both BERT-based models; sorry that this isn't clear. benepar_en2 is based on BERT-base-uncased, and benepar_en2_large is based on BERT-large-uncased.

Great, thanks for clarifying.
On Fri, May 17, 2019, 2:57 AM Nikita Kitaev<EMAIL_ADDRESS>wrote:

These are both BERT-based models; sorry that this isn't clear. benepar_en2
is based on BERT-base-uncased, and benepar_en2_large is based on
BERT-large-uncased.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nikitakit/self-attentive-parser/issues/24?email_source=notifications&email_token=AEJHJXLKPR7VKQZ3GCFLZM3PVZJMVA5CNFSM4HNO7CRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVT5IVI#issuecomment-493343829,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEJHJXPH7DL7CJMS2IGNVH3PVZJMVANCNFSM4HNO7CRA
.


x/mobile/cmd/gomobile: build doesn't honor -target

$ gomobile build -target=misc .

builds an apk for android rather than exiting with unknown -target, misc. error.
cc/ @crawshaw @hyangah

As the explanation was not added to the CL description, it is:
addBuildFlags is called multiple times at initialization, so the String method returns a different pointer for the different commands. That means the pointer is from the wrong flag set for all but the last registered command, which is cmdBind.


Add possibility to set number of threads for parallel run

To give user control of number of threads to use.
Default to 4.

@mialeska, renamed parameter to data.provider.thread.count


Setting the API key as a global environment variable is probably not so safe

Setting a global environment variable is okayish if you are in a protected environment such as a Docker image on a protected server, but probably not so great when it's a global variable available to the whole user system. Maybe a configuration file or starting Julia in a separate shell with the environment variable set would be better.

Thanks! I definitely see the value in keeping the API key somewhere other than an environment variable. Do you think Preferences.jl would be an appropriate solution? I haven't used it before but it looks like it's intended for this kind of thing. I'll give it a go.

The Preferences.jl approach in https://github.com/ThatcherC/ReplGPT.jl/pull/4 went pretty well! I do like the idea of obscuring the keys, but I haven't come across a good way to do that yet so I think I'll save that feature for a future PR.

Using https://github.com/JuliaCrypto/Nettle.jl to encrypt the API key could be an excellent option.

Using https://github.com/JuliaCrypto/Nettle.jl to encrypt the API key could be an excellent option.

But where do you leave the key in a open source repository? Still, encrypting it with some key is better than nothing, I guess.

Sorry, I do not fully follow. Why would one store the encrypted API key in an open-source repo rather than in their system?

Sorry, I do not fully follow. Why would one store the encrypted API key in an open-source repo rather than in their system?

The idea of encryption is that only people who have the key can read the information. The problem is: Where would ReplGPT.jl leave the key? Everybody can read the source code of ReplGPT.jl. Maybe, on second thought, it is better to not encrypt because then at least a leak can be detected like happened in #8.

I see! I was imagining using a password per user to encrypt the key.


Expose Deal Proposal CID through GraphQL endpoint

@raulk for retrievals, I assume you don't care about Proposal CID, but rather retrieval DealID -- that's what is tracked in the FSM for retrievals I think.

Also do you need on chain deal ID for Storage or is ProposalCID sufficient?

@willscott 's PR above attempts to get more data but doesn't actually work. I want to confirm the minimum viable set of things you need, which based on my existing knowledge of markets software is ProposalCID for Storage Deals and Retrieval DealID for retrieval deals (which based on my knowledge of markets software, unless it's changed, are how the FSMs are key'd)

Thanks for checking. Let's go with your call @hannahhoward. For storage deals I think the ProposalCID would be enough as that's what enables us to correlate with the journal, but the DealID would be good to have, as you noted. For retrievals, I agree with you.

these are now available


raft: leader reponnds to learner read index message

In a cluster with 1 leader and 1 learner, read request in learner will get an empty read index.
pick from: https://github.com/etcd-io/etcd/pull/10590

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Great Catch, CI failed

PTAL  @Hoverbear @hicqu

LGTM

LGTM


[tests-only][full-ci] update owncloud core commit id

Description

updates owncloud/core commit id for the tests

Part of

https://github.com/owncloud/QA/issues/711

Description

updates owncloud/core commit id for the tests

Part of

[QA][CI] Bump Latest commit id [Dec 27 - Jan 07] owncloud/QA#711

please add [tests-only] to the PR title and rerun CI ;-)

@kiranparajuli589 when you sort out expected-failures changes for fileVersionAuthor.feature then please do a similar PR to the edge branch of cs3org/reva


How can onboarding the Azure Arc-enabled kubernetes to Sentinel?

[Enter feedback here]
Hi
I have found this docs about the onboarding the Azure Arc-enabled Server to sentinel, but how can i onboarding the Azure arc-enabled kubernetes cluster to Sentinel or not?
Thanks~
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: aac75d49-3e7a-a81f-5ccc-2033ae6cfe5a
Version Independent ID: a5a3de1a-da47-96e5-93f0-2ee7e98b5aeb
Content: Onboard Azure Arc-enabled server to Microsoft Sentinel - Azure Arc
Content Source: articles/azure-arc/servers/scenario-onboard-azure-sentinel.md
Service: azure-arc
Sub-service: azure-arc-servers
GitHub Login: @johnmarco
Microsoft Alias: johnmarc

@msyinjie
Thanks for your feedback! We will investigate and update as appropriate.

Duplicate of #https://github.com/MicrosoftDocs/azure-docs/issues/116377


flutter/engine does not build with Bazel

We may eventually be required to add a Bazel build support in order to build our engine binaries on specific parts of Google's infrastructure.  (Not urgently, but there are factors suggesting to me that we may eventually need to.)
There has been at least some discussion of GN/Bazel conversion tools:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/wl1T6XX2gg8
GN, being a meta build system, might just have a Bazel generator these days, I don't know.
FYI @tvolkert @chinmaygarde @cbracken

The engine builds with Blaze internally. I don't believe we have any intention of supporting external Bazel builds, but if this is still needed please re-open.

@cbenhagen It is strongly desired at my company! Please reopen.

Please reopen. This is needed.

The engine now builds with Blaze internally.

Only a subset of targets build internally and none of the apps shipping use artifacts built from those internal Bazel rules. It is certainly not production ready or anywhere close to it. There are also aren't any efforts underway to close the gap in supported targets with the GN rules. The minimal rules present are used for prototyping small engine changes in that environment. Supporting build rules for multiple build systems in parallel is a massive undertaking.

It is strongly desired at my company

This issue only relates to Flutter Engine builds and not Flutter applications themselves. Can you confirm you need to build a custom engine using Bazel?

Can you confirm you need to build a custom engine using Bazel?

Thanks for the clarification. We only require flutter applications. I retract my previous comment.

We only require flutter applications.

Thanks for clarifying. Can you file a bug for the same? I don't see that issue filed already so it may not be on the teams radar.

Unfortunately, I think it was already filed and declined in #19680. Specifically https://github.com/flutter/flutter/issues/19680#issuecomment-460797316.

FWIW I'd imagine that if you wanted to just write flutter rules youself it's probably not actually a massive undertaking if you were to build on top of https://github.com/cbracken/rules_dart


Add a test: correct # of digits but wrong format

I copied over a test that I think is important from the Ruby version. It
checks that the number of digits might be correct while the formatting
of the phone number string might be wrong.
I think that the key to this exercise is to check for the 3-3-4 format,
where the separators can be anything, but there needs to be a group of 3
digits followed by another group of 3 digits followed by another group
of 4 digits, optionally prefixed with a single "1".
When I added this test to my initial iteration, the suite failed. Most
of the other submissions I saw would, I believe, also fail. So I think
this test is important for clarifying the problem space.

Oh, nice! Did you check that the example solution passes with the new test?

I just ran the test suite with the example solution, and it fails. The very first transformation in the example, and in my initial solution and a lot of the other solutions I saw submitted, is to strip all non-digit characters from the string. This means that "1a2a3a4a5a6a7a8a9a0a" is valid, when the test says that it should be invalid.
I'm not quite sure of a quick fix to make the example pass--except, I guess, to turn it into my final solution. Thoughts on how to proceed here?

Feel free to replace it with your solution. I'm sure others will jump in later if they have improvements.

I added my change to the example solution. I guess another approach could be do define valid separators (plus signs, parentheses, hyphens, spaces, and periods?) and strip only those then check to see if there are any non-digits left in the result, but this approach does that all in one pass while changing the focus of the problem to be to look for the 3-3-4 pattern of US phone numbers.

With the reference solutions we aim for code that is as straight forward as possible, without necessarily making it exemplary. The solution is used only to validate the test suite (though not all languages have continuous integration in place.
Thanks for taking the time to improve the exercise.