BSI Range-Encoding: add documentation

All new PQL functionality should be described in the query language section.
A brief overview of range encoding storage and operations should be added to the data model section.
A brief usage example should be added to the tutorial section (taxi data could work for this).

Documentation for SetFieldValue, Average and Sum are in PR https://github.com/pilosa/pilosa/pull/816 but there's no docs for the Xor call.

I created #853 to address Xor documentation.

fixed by #816


Fix Opportunity behavior with unicode characters

Fix #1695. It is already deployed on http://xymus.net/opportunity/ (Take a look at http://xymus.net/opportunity/?meetup_id=B962ECD89E0AE40FF888569AE8D816B36F128E10)

You mangeled Aléxis because you cannot find a non-ascii character in Alexis Laferrière?

+1

:shipit:

@privat, I was too lazy to write my last name...

Rerolled with a better implementation of to_percent_encoding.


more connected clients than allowed

I have setup redis client with setConnectionPoolSize(64) . At heavy load when I check the Redis server it shows connected clients to be  284. I am running 4 replicas of application. I expect it should never go above 64*4 = 256.
No other app is currently connected nor any manual connection has been done to the redis server.
I am not sure whats the exact reason here.
Redis version : 4
Redisson client version : 3.12.5

Do you use RBatch object?

How many Pubsub connections did you define in configuration?

@mrniko I have not defined any Pubsub connection by myself. Its using default one with subscriptionConnectionMinimumIdleSize = 1.
I am not using any PubSub functionality, so I would expect it to be at 1 all the time.
So even if I consider 4 connections for Pubsub accounting 4 replicas, still total connections seems to be more than allowed with redis server.

same redis server version 4.x & same redis client version 3.12.5 & same performace 260+ connections, and it's single server with ConnectionPoolSize(64) and no subscriptionConnection settings :
ss|grep 6379|wc -l
265

I've tested that set subscriptionConnection to 0, nothing changed.
it will cause that, when application pod crashed or network corrupted, the redis server will stuck at so many connetion requests in serveral seconds due to redis single thread, and it cannot execute any other command.
This can only be reproduced in high concurrency scene.
BTW, we are upgrade from version below 3.10.1, because  3.10.1 fix the issue "https://github.com/redisson/redisson/issues/1811"(The connection can not reconnect), maybe this patch cause this uncontrolled connections issue?
We are testing 3.14.1 now.

same redis server version 4.x & same redis client version 3.12.5 & same performace 260+ connections, and it's single server with ConnectionPoolSize(64) and no subscriptionConnection settings :
ss|grep 6379|wc -l
265

I've tested that set subscriptionConnection to 0, nothing changed.
it will cause that, when application pod crashed or network corrupted, the redis server will stuck at so many connetion requests in serveral seconds due to redis single thread, and it cannot execute any other command.
This can only be reproduced in high concurrency scene.
BTW, we are upgrade from version below 3.10.1, because  3.10.1 fix the issue "https://github.com/redisson/redisson/issues/1811"(The connection can not reconnect), maybe this patch cause this uncontrolled connections issue?
We are testing 3.14.1 now.

@BEWINDOWEB did you finish your testing with 3.14.1? I think we might be experiencing the same issue.

@BEWINDOWEB did you finish your testing with 3.14.1? I think we might be experiencing the same issue.


Namespace issue on windows using laragon

and this is the namespace its generating

namespace C:\laragon\www\laravel\app\Http\Controllers;

also experiencing this issue on windows using Xampp

Hi guys,
Rather annoying this one, as it seems to be intermittent.
Just click "Next" again and all should be well.
I think it's an issue with Composer not loading the new namespace correctly on the first go. I actually put in code to cope with this in the Beta, but either I didn't solve it, or it's cropped up again.
Let me know if that does or doesn't solve it, and I'll look again.

Actually, think this is going to be me not testing on Windows, and my code to resolve namespaces from file paths using windows backslashes is probably borked.
I'll look to fix this in the next 24 hours, sorry for the inconvenience!

I did try to click "next" but it wouldn't let me so I just returned pass on the install check to bypass it. It wanted to set the namespace to the actual file location as I would find it in Windows but the namespace set for all my controllers is set as "App\Http\Controllers"
Using these two workarounds has let me continue to work with sketchpad

Just to update you fellas, I've just tried installing on Parallels, but served using Valet's share command.
Install worked correctly, first time. I'll take another look at the namespacing code again; hopefully I can get it to break, then mend it.

OK, bug squished. Just do the following to update to 1.2.7:
composer update davestewart/sketchpad

If it isn't fixed, just let me know here.

Did a fresh install and everything went smoothly. Namespace in ExampleController.php was correct out of the box
Thanks!


[Request] Prepare plugin documentation for Packer.io ingestion

Hello UpCloud team, fellow Packer maintainer here interested in helping getting the UpCloud builder registered on Packer.io.
Plugin documentation for third party plugins can be automatically ingested by the Packer.io build job, by adding an entry for a third party plugin here.
But before, the documentation can be consumed there are few things that need to be done on the plugin side.

[x] Place plugin documentation into a separate docs directory with a sub-directory for each component type. - See Packer Plugin Scaffolding for examples.
[x] Packer plugin documentation as a zip file along side the plugin releases in a file called docs.zip - In the scaffolding repo we have an example goreleaser file with configuration on line 12, and 82 for including the docs.zip within the plugin release.
[x] Once the documentation is ready, and being released along side the plugin binaries you can open a Pull request against Packer with an entry for the UpCloud builder in the remote-docs file.

Note
This plugin doesn't currently have a lot of configuration options. But you may find it helpful to know that the Packer team has released, as part of the Packer Plugin SDK, a packer-sdc command that can be used for generating documentation for plugin configuration options using code comments - please see the command documentation here.

Documentation updated and latest version 1.3.0 released at #25. We'll work on the remote-docs PR next.

Docs ingestion PR ready at https://github.com/hashicorp/packer/pull/11587


Shooting Dinosaurs

This feature would make it so the dinosaurs would be able to shoot laser projectile as well. Those projectiles would go dowwn vertically (towards the player). Dinosaurs could be shooting every 2 seconds.

This feature has been implemented.


No unnecessary re-rendering with onElementsClick

Fixes #16

thanks @lutovich , really appreciated

@gor181 thanks!
I've also tried to add some simple unit tests with Jest but it did not work.
There appeared some dependency issue with npm:
$ npm install --save-dev jest babel-jest babel-polyfill
npm WARN package.json<EMAIL_ADDRESS>No license field.
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm ERR! Darwin 15.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "--save-dev" "jest" "babel-jest" "babel-polyfill"
npm ERR! node v4.4.7
npm ERR! npm  v2.15.8
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
Not sure how to solve it, I'm really new to all this Javascript stuff.
I can submit tests as a separate PR if you know how to fix this dependency problem.

Hey @lutovich ,
I have been using mocha so far, but would be more than happy to checkout Jest.
If you have code by hand please be kind to submit a PR and I'll take a look.
Cheers!

btw, try node 5 and npm 3.
if you use nvm it's easy as nvm install 5


Updated master branch

Synced master branch

@petrosagg, I am not sure it's the right way to sync our master with the latest docker's.
I have created a v1.12-resin tag of our current master snapshot. Feel free to withdraw this PR and update master to have 1.13.

We work on resin-os/docker branch


fix: correctly handle invalid input in sudoku-solver

Changes:

fix: check whether the input is a valid board state in SudokuSolver.validate before attempting to solve it.

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes freeCodeCamp/freeCodeCamp#48307

Please add the hacktoberfest-accepted label to this PR if you decide to merge it. Thanks!

To go off what they were saying, their solution does appear to fix the problem. I've prepared a test case for it and appended it near the end. The test being called "Cannot Solve Invalid Input".
https://pastebin.com/bYjNdkC4


fix(types): add build to export a js file to include the faker instance (for runtime)

Codecov Report

Merging #61 (1985f81) into release (d068698) will decrease coverage by 6.32%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           release      #61      +/-   ##
===========================================
- Coverage   100.00%   93.67%   -6.33%
===========================================
  Files           22       23       +1
  Lines          257      332      +75
  Branches        27       50      +23
===========================================
+ Hits           257      311      +54
- Misses           0        8       +8
- Partials         0       13      +13

Impacted Files
Coverage Δ

packages/generator/src/lib/index.ts
54.54% <0.00%> (-45.46%)
:arrow_down:

packages/generator/test/e2e/test-classes.ts
61.53% <0.00%> (-38.47%)
:arrow_down:

packages/generator/src/index.ts
66.66% <0.00%> (-33.34%)
:arrow_down:

.../generator/test/integration/common/test-classes.ts
87.17% <0.00%> (-12.83%)
:arrow_down:

packages/reflect/src/lib/class-reflector.ts
95.23% <0.00%> (-4.77%)
:arrow_down:

packages/reflect/src/lib/property.ts
100.00% <0.00%> (ø)

packages/parser/src/lib/class-parser.ts
100.00% <0.00%> (ø)

packages/reflect/src/decorators/index.ts
100.00% <0.00%> (ø)

packages/generator/src/lib/mock-builder.ts
100.00% <0.00%> (ø)

packages/generator/src/lib/mock-factory.ts
100.00% <0.00%> (ø)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d068698...1985f81. Read the comment docs.


Discussion: commnutity driven development

The Problem
As someone who has moaned about this for about the past year we currently have a GREAT project and it is very popular, but you (@neuecc are a very busy person), we have until recently been in a situation where there were a myriad of good quality PRs building up with no one able to action them.
There has also been a big shift in the Unity/.Net landscape over the past year or so where things are shifting to .net standard, and Unity is starting to support a newer version of .net as well as their new package manager etc.
Given the large amount of change it has meant that people have started to wonder if they can use this library because no one was able to provide fixes outside of the owner, and there was no roadmap/guidance on if we were going to be able to start taking advantage of some of the newer features coming out.
How to solve it?
Not entirely sure, so currently I would say it would be best to move UniRx (and related projects) into an organisation on github (its free to do for public repos) and then see if any of the community would be willing to become a maintainer. This would need to be someone who has experience with the library, has used it in depth and the owner would trust to make decisions if they were unable to do so.
Given the community is generally a bit quiet these days I am not sure if you would find many people but at least you have the ability to delegate some responsibility to others so if you are unable to maintain the library for a period there will be others who can help out.
This would require more communication between those maintainers though to agree on the roadmap and the direction of the lib, so the quality and responsibility of the framework does not get eroded too much.

This is all easier said than done, but I really think that this library has a large potential user base in the game dev community (not just in unity) but this could only be realized if there is a community behind it not just a single person.
(Also just want to say thank you very much for your time and efforts so far @neuecc although myself and others may complain from time to time it is a time consuming and often thankless endevour making open source frameworks for others, so thank you for coming back to us and taking the time to discuss these points).

If anyone wants to put themselves forward to potentially become a maintainer please post so we can take numbers of who would have the time/knowledge to assist with the backlog of PRs and ongoing direction of the lib.

Hello ! I would be ready to give a hand here as I'm using UniRx daily at work.

I'm sorry @neuecc , but shouldn't we take a look at this ?

I hope this doesn't die, what a great project.
A few thoughts:
It's probably quite difficult to find people who:

are highly experienced in rx,
and are highly experienced in unity,
and have the time and motivation to maintain such a large foss project

all while filling in the big shoes of @neuecc's work so far.
Plus, we have the higher level dilemma of how the project should go in relation to System.Reactive.
I agree with what @grofit says in #324 about possible long term goals of the project involving splitting and refactoring out a lot of stuff, but of course that brings another massive chunk of long-term thought and work to the table.
I'm not sure that a single extra dedicated maintainer will cut it with everything considered, but it's a good first step at least. Though it's been two years and still no response at all (though there has been a small amount of maintenance by @neuecc), so I'm not sure what we can do.

The problem here is that almost everything outside of unity uses rx.net with varying success depending on deployment platform, it also is a lot faster than it originally was when neuecc first made unirx, and unirx is GREAT inside of unity as it has loads of helpers that make using rx far simpler.
This is only now becoming a problem as unity has opened its ecosystem up a bit more so a lot of devs can now use .net standard dlls etc, and there are plenty of open source rx related projects which could now be useful in unity.
From what I remember previously rx.net works fine in desktop apps with unity and other JIT deployment scenarios, but falls over with IL2CPP or AOT scenarios without major headaches (Which I think someone got working to some extent in one of the related issues here), so my hope was that we could get some focus on isolating and well documenting the issues with getting rx.net working on unity (with most operators etc, we have a repo over here for testing stuff https://github.com/grofit/unity-rx-test) then we could look at seeing what parts of unirx are super valuable to devs (like EveryUpdate etc) then see if we can somehow build them on top of rx.net, this way less unirx code to maintain as the core/linq parts go away and we use default ones (assuming no optimised versions needed), then unirx becomes less of a headache to manage as its just rx.net with more stuff, rather than it being a bespoke rx.net implementation with more stuff.


Enable C++11 compatibility

This address issue #6

Hi @iamOgunyinka, I'd love some feedback on this if you feel like it.

@iamOgunyinka how should I interpret the "thumbs up" 😄 ?

"Ok, I will have a look at it and let you know after I find some time"
"I reviewed it, it looks good, go ahead and merge"

haha I'm so so sorry, @jkalias, I actually thought I left a comment in the morning. I'll take a look at it after work today and will leave a comment before tomorrow. My apologies.

All good, no rush, I just wasn't sure. I should be thanking you 👍

@iamOgunyinka any feedback would be great and deeply appreciated 😬

What kind of person promises to do something and would not come through two days later?! I'm sorry I'll do it right now, no more delays.

If I understand correctly, the main take from this PR is to remove the dependency on C++17's optional (and if initialization) and thus make the library available for C++11 users. On this premise, I'd say it does look good.
However, I would advice that you improve the optional class. Right now, it has a bool and an int, which is quite good but it "confines" the use to only an integer (and you thus, cannot reuse this library part in the future when you need an optional <string> or vector or any other type). So, if this isn't too much to ask, could you maybe check reimplement the optional as a class template that would take any type? A very naive implementation would be for the class to have just a T* as its data member and its value set to nullptr by the default constructor. Other constructor can initialize it if the user supplied a value to it.
To make it a bit compatible (or an opt-in) to the standard's optional, you could provide an operator= that assigns to it and operators * and -> that can dereference it -- followed by other member functions like has_value etc. That way you can have an #ifdef that uses std::optional if compiled with C++17 or greater OR use functional_veector::optional<T> in the absence of that, without changing the client's code.
My apologies that this comment came late, work has kept me busy.

If I understand correctly, the main take from this PR is to remove the dependency on C++17's optional (and if initialization) and thus make the library available for C++11 users. On this premise, I'd say it does look good.

This is correct. I wanted to make the library available for C++11, since there are a lot of legacy code bases and not everyone is on the bleeding edge of the latest standard.

However, I would advice that you improve the optional class. Right now, it has a bool and an int, which is quite good but it "confines" the use to only an integer (and you thus, cannot reuse this library part in the future when you need an optional <string> or vector or any other type). So, if this isn't too much to ask, could you maybe check reimplement the optional as a class template that would take any type? A very naive implementation would be for the class to have just a T* as its data member and its value set to nullptr by the default constructor. Other constructor can initialize it if the user supplied a value to it.

I though about that as well. I considered also existing replacements for a backwards compatible optional type, like this or this. However, I have two concerns:

I want to keep the external dependencies to an absolute minimum.
Currently I only need an optional<int>, and designing a full-blown general solution seemed like an overkill at this stage.

To make it a bit compatible (or an opt-in) to the standard's optional, you could provide an operator= that assigns to it and operators * and -> that can dereference it -- followed by other member functions like has_value etc. That way you can have an #ifdef that uses std::optional if compiled with C++17 or greater OR use functional_veector::optional<T> in the absence of that, without changing the client's code.
My apologies that this comment came late, work has kept me busy.

First of all, there is no need to feel bad or apologize. I completely realize that everybody has his/her own schedule, and all OSS efforts are done purely on a voluntarily basis. So, I should be apologizing for taking up your time, and thanking you for your feedback.

Edit: This is a sample implementation I could come up with. I do not know if this can be usable in any way in your code because I didn't test to see if it could be returned from a function. Oh and thinking about it now, it has no operator bool(), so you can't really test if it has a value without calling ::has_value.

Ok, cool, I will have a look at it and let you know what my findings are.

Ok, cool, I will have a look at it and let you know what my findings are.

No problem.


Python script worked once and then I got (fork/exec "": no such file or directory)

Hi,
Is there a log file or any advice I could get about troubleshooting this issue?
I'm trying to run a script that sends the context of a file in and infinite loop, when that "variable changes it changes what it sends...
this is the code im using with some variations...
this is what is get when trying to connect to the server:

Fri, 22 Jul 2016 23:48:04 +0000 | ERROR  | process    | url:'http://<IP_ADDRESS>:8000/' id:'1469231284916529497' remote:'.home.' command:'websocketd/socket' origin:'http://<IP_ADDRESS>' | Could not launch process websocketd/socket  (fork/exec websocketd/socket: no such file or directory)

Fri, 22 Jul 2016 23:54:18 +0000 | ACCESS | session    | url:'http://<IP_ADDRESS>:8000/' id:'1469231658663742139' remote:'.home.' command:'websocketd/socket' origin:'http://<IP_ADDRESS>' | DISCONNECT
dont know why would it disconnect as the script if an infinite loop.
Thanks.

Could you add your command line, how you starting websocketd with that program?

On that case:

./websocketd/websocketd --port=8000 ./websocketd/socket

I've also tried from the actual directory...

./websocketd --port=8000 ./socket

also tried with the devconsole, which wont work for me, tried browsing to end htt://point also adding the "path to file" at the end of the address in the browser, no luck...

./websocketd/websocketd --port=8000 ./websocketd/socket.py --devconsole

Hm.. Does the script itself work when you run it as ./websocketd/socket or ./websocketd/socket.py --devconsole  or  ./socket.py ?

I'm using linux. The script it self and it work.
Are you saying that the dev console command would be:
script_name --devconsole
haven't managed to figure out how to run the devconsole...
what do you mean by adding "env -i" in front of it? on the websocketd command? could you please give me an example of how to implement this? I've tried...
command:
pi@raspberrypi:~/websocketd $ ./websocketd --port=8000 env -i ./socket.py
result:
Sun, 24 Jul 2016 01:31:55 +0000 | ACCESS | session    | url:'http://<IP_ADDRESS>:8000/' id:'1469323915905171628' remote:'.home.' command:'/usr/bin/env' origin:'http://<IP_ADDRESS>' | CONNECT
Sun, 24 Jul 2016 01:31:55 +0000 | ERROR  | stderr     | url:'http://<IP_ADDRESS>:8000/' id:'1469323915905171628' remote:'.home.' command:'/usr/bin/env' origin:'http://<IP_ADDRESS>' pid:'1246' | /usr/bin/env: ./socket.py: No such file or directory
Sun, 24 Jul 2016 01:31:55 +0000 | ACCESS | session    | url:'http://<IP_ADDRESS>:8000/' id:'1469323915905171628' remote:'.home.' command:'/usr/bin/env' origin:'http://<IP_ADDRESS>' pid:'1246' | DISCONNECT

also:
pi@raspberrypi:~/websocketd $ ./websocketd env -i --port=8000 ./socket.py
Sun, 24 Jul 2016 01:43:04 +0000 | INFO   | server     |  | Serving using application   : /usr/bin/env -i --port=8000 ./socket.py
Sun, 24 Jul 2016 01:43:04 +0000 | INFO   | server     |  | Starting WebSocket server   : ws://raspberrypi:80/
Sun, 24 Jul 2016 01:43:04 +0000 | FATAL  | server     |  | Can't start server: listen tcp :80: bind: permission denied

command:
sudo python env -i socket.py
result:
python: can't open file 'env': [Errno 2] No such file or directory
also:
pi@raspberrypi:~/websocketd $ sudo python env -i socket.py
python: can't open file 'env': [Errno 2] No such file or directory
pi@raspberrypi:~/websocketd $ ls
bootstrap.html  count.sh  openboot.sh  socket.py  websocketd
CHANGES         LICENSE   README.md    var        websocketd-0.2.11-linux_arm.zip
pi@raspberrypi:~/websocketd $ sudo python env -i ./socket.py
python: can't open file 'env': [Errno 2] No such file or directory

script running:
pi@raspberrypi:~/websocketd $ sudo python socket.py
on
on
on
on
on
on
hello
hello
on
hello
on
on
Traceback (most recent call last):
  File "socket.py", line 41, in <module>
    time.sleep(.5)
KeyboardInterrupt
pi@raspberrypi:~/websocketd $

I've modified the script to print the valued in a file "variable" and print hello when a key is pressed...
edit on the original script:
try:
                c = sys.stdin.read(1)
                #print(repr(c))
                print("hello")
            except IOError:
                with open('var', 'r') as myfile:
                    data=myfile.read().replace('\n', '')
                    print(data)
            time.sleep(.5)

See, you're running your script as  sudo python socket.py, while websocket would end up running it as just  ./socket.py in example above..
You need to use command that works. So in your case it's websocketd [options] sudo python socket.py...  You can potentially move sudo (I don't know why you're using it)... and you can move python to script's headline and adding executable bit to script.py permissions. But one rule always applies  "command you're using behind websocketd should work on it's own too"

And --devconsole is just one of the options, you could use it in websocketd command line before actual command.

Hi,
this is just a bad habit of mine, the script runs without sudo fine...
pi@SmartDoor:~ python websocketd/socket.py off off off Traceback (most recent call last):   File "websocketd/socket.py", line 51, in <module>     time.sleep(1) KeyboardInterrupt pi@SmartDoor:~ $
but still get this with websocketd...
pi@pi:~ $ websocketd/websocketd --port=8081 websocketd/socket.py Wed, 27 Jul 2016 11:03:35 +0100 | INFO   | server     |  | Serving using application   : websocketd/socket.py Wed, 27 Jul 2016 11:03:35 +0100 | INFO   | server     |  | Starting WebSocket server   : ws://SmartDoor:8081/ Wed, 27 Jul 2016 11:04:27 +0100 | ACCESS | session    | url:'http://<IP_ADDRESS>:8081/' id:'1469613867249537063' remote:'.home.' command:'websocketd/socket.py' origin:'http://<IP_ADDRESS>' | CONNECT Wed, 27 Jul 2016 11:04:27 +0100 | ERROR  | process    | url:'http://<IP_ADDRESS>:8081/' id:'1469613867249537063' remote:'.home.' command:'websocketd/socket.py' origin:'http://<IP_ADDRESS>' | Could not launch process websocketd/socket.py  (fork/exec websocketd/socket.py: no such file or directory) Wed, 27 Jul 2016 11:04:27 +0100 | ACCESS | session    | url:'http://<IP_ADDRESS>:8081/' id:'1469613867249537063' remote:'.home.' command:'websocketd/socket.py' origin:'http://<IP_ADDRESS>' | DISCONNECT

Again, you add "python" in first command line and decide to omit it in second one, you need
websocketd/websocketd --port=8081 python websocketd/socket.py

Hi,
Thanks for you suggestion I haven't been able to try this, I have put this on hold for the time being. Just thought I'd get back to you on this, at the moment im implementing the "socket" on bash.
Thanks.


Remove joinType validation

All join types are supported, so this validation could never fail.

@seut please review

what about natural joins? afaik they are supported by our parser...

natural joins results in a different JoinCriteria instance - the validation for that is still there.


No IP generated in Ubuntu 18

Versions:

Version of Chef-Provisioning: 2.7.1
Version of Chef-Provisioning-vSphere: 2.3.1

Platform Details

Version of vSphere/vCenter: <IP_ADDRESS>00 Build 8024368
Version of ESXi:VMware ESXi, 6.5.0, 7388607

Scenario:

I'm trying to build a new VM with ubuntu 18 but the network card does not load automatically and event if I connect it manually while the VM is booting up, the VM fixe ip does not update.
Steps to Reproduce:

Create a template with Ubuntu 18 and generate a new VM with chef-provisioning-vsphere under :boostrap_options =>{ :customization_spec => { :ipsettings => ip: "<IP_ADDRESS>"}}
Expected Result:

No IP generated as it uses now Netplan in Ubuntu 18 and that I specify the chef code
Actual Result:

You need to make sure you installed the vmtools from vcenter and not the open source version of vmtools that comes with Ubuntu. I found the open source version of vmtools doesn't fully work so the network and vm guest os calls to apply settings into the OS never happens.


Export koa-bodyparser as a CommonJS module

This matches the codebase here better: https://github.com/koajs/bodyparser/blob/master/index.js#L28

Hey, I'm the one who did the initial contribution for koa-bodyparser, as well as koa-send, koa-static, and koa-views. Would you be interested in fixing the exports for the other three modules I mentioned as well?
As a side note, there should probably a mention in the CONTRIBUTING.md that modules meant to be used with Node should be CJS exports...

Thanks for looking. I’d be happy to help update other libraries, but since this is my first PR here, I’d like to get this landed first and go from there.

As a side note, there should probably a mention in the CONTRIBUTING.md that modules meant to be used with Node should be CJS exports...

Sounds like a great PR. 😉

So folks using flow-typed can not use require() at all? It seems like the typedef should mimic what the library exports. If they export a CJS module, shouldn't we define the types as CJS compatible?

Just my opinion, but I agree with @KevinGrandon that the exports should follow whatever the original module uses. If ES6 exports are used in the type definition, it enforces users to use import syntax. If a module is typed as CJS, both require and import will work.
I don't think client-side stuff is a problem to always use import, but for server-side Node stuff a lot of people just use require and don't bother transpiling import -> require so they will have issues. An example of this problem: https://github.com/chalk/chalk/issues/264

If a module is typed as CJS, both require and import will work.

Is that the case? From what I can tell, the keyword import isn't supported in CJS.

Sorry, let me clarify. I meant that if a flow-typed libdef uses module.exports, the end-user can use either require syntax or import syntax. This is because babel will convert the CJS module.exports to an export default assuming you're using a plugin like env.
But yeah, it's true that you can do require('modulename').default to get a flow-typed libdef that uses ESM to work.

Wouldn't it be nice if we just had one way to put JS into modules? 😂
Okay, that makes sense. We'll have the module type reflect the library. @saadq would you mind updating the contributing guide?

They can require it, they'll just need to use the requite('').default syntax.

But this is bundle system specific and would not work with a normal node module for typical required code.

Interesting. I don't work much with Node. Can you expand on what bundle system allows the require('').default syntax?

Interesting. I don't work much with Node. Can you expand on what bundle system allows the require('').default syntax?

There are various transpilers which provide the .default property, but this is not a native node property. Webpack, babel, typescript can all generate this depending on config, but not all bundlers do.

Got it. That seems like a compelling enough argument to follow the module pattern of the library. @GAntoine thoughts?

Just need sign-off from @GAntoine.
Can you also add/update documentation to the CONTRIBUTING.md in the correct place to discuss this decision?

Yeah I'm not thrilled about this change, but considering the arguments above, this PR is the least painful of both approaches. I'll go ahead and get it merged, and any updates to the docs can be made in another PR.


feat(resolver): check for infinite recursion

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (17a6f63) 89.48% compared to head (c6dd0d6) 89.48%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   89.48%   89.48%
=======================================
  Files         207      207
  Lines       42767    42772    +5
=======================================
+ Hits        38268    38274    +6
+ Misses       4499     4498    -1

Files Changed
Coverage Δ

crates/oxc_resolver/src/error.rs
100.00% <ø> (ø)

crates/oxc_resolver/src/lib.rs
93.02% <100.00%> (+0.16%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove docs for creating custom metrics records

Motivation
Remove docs for creating custom metrics records
JIRA: https://issues.jboss.org/browse/AGDROID-783
Description
The rest of the outdated documentation related to metrics were removed in #219.
The init metrics are now sent automatically and the other existing metrics record which is related to the security checks is documented in the doc files for that module, as such there are no longer references on how to send individual (hence possibly custom) records.
Additional Notes
Revised from #212 after mailing list discussion.

Actually this docs are kinda useful for contributors. We still have them for contributing section in IOS SDK. So let's not remove them. Just not link it in end user docs.

Rejecting the removal in favor of just moving the existing file


Rename Logger to SentryLogger or similar

Please consider renaming the Logger type to something that does not collide with all kinds of logging implementations.

@kuhnroyal that's a fair point, thanks.

PR's welcomed btw :)


texlive: add missing perl dependencies for latexindent

Motivation for this change
Resolves: #35537
Improves on previous version #54518
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @volth @romildo
cc #55933

Forgot to mention. This was tested by running:
nix-shell -p "texlive.combine { inherit (texlive) scheme-minimal latexindent; }" \
  --pure --run latexindent

Is it indeed needed / useful for this to have the perl deps propagated here? I'm tracking down recent regression that caused shebang length to explode and looking for possible causes, is why I'm asking :).

@dtzWill Yes, it is needed. When doing the original #54518 I initially tried to add things manually, but there were too many needed "higher order" dependencies, so I had to go for lib.closePropagation there.

On Fri, 10 May 2019 05:48:14 -0700, Dmitry Kalinkin<EMAIL_ADDRESS>wrote:

@dtzWill Yes, it is needed. When doing the original #54518 I initially tried to add things manually, but there were too many needed "higher order" dependencies, so I had to go for lib.closePropagation there.

D'oh, okay.  Thanks and +1 for only propagating them reluctantly
when other efforts were insufficient :).
For now I've kludged it locally which seems to have
fixed my problem but it's not really suitable otherwise.
( 986fcbc6480ce7a9dbb88a58f113580fcab4011a for the curious)
Hopefully the recent efforts re:managing perl deps will improve things,
some of the shebang lines we create are just silly :D.

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/59537#issuecomment-491276726Non-text part: text/html

+1 for only propagating them reluctantly when other efforts were insufficient :)

Actually the reason for adding dependencies manually was because the use of lib.closePropagation is discouraged for some reason. I'm not knowledgeable about Perl, but all imports there were unconditional, so I did not expect to be able to cut down any dependencies that way. If that was possible, then those should have been fixed in the relevant perl packages instead. Also, setting dependencies manually is not very maintainable.
Judging from conclusions of #55786 your workaround appears to be an actual canonical solution. Perhaps we should merge it to fix "latexindent" on macOS.

For some reason applying 986fcbc6480ce7a9dbb88a58f113580fcab4011a doesn't fix the issue, I still get the same error on macOS:
# nix-shell -p "texlive.combine { inherit (texlive) scheme-minimal latexindent; }" --pure --run latexindent
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 20: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 21: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 22: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 23: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 26: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 27: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 30: syntax error near unexpected token `('
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 30: `my %switches = (readLocalSettings=>0);'

Even though the shebang is much shorter now:
# head /nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent
#!/nix/store/vk301av7nr86gpql9hpxcw4j9nbr9vms-perl-5.28.2-env/bin/perl -I/nix/store/65h67v6ilwvjp8xqrr73q0yhw4rdhpaa-perl-5.28.2/lib/perl5/site_perl -I/nix/store/vk301av7nr86gpql9hpxcw4j9nbr9vms-perl-5.28.2-env/lib/perl5/site_perl -I/nix/store/65h67v6ilwvjp8xqrr73q0yhw4rdhpaa-perl-5.28.2/lib/perl5/site_perl -I/nix/store/vk301av7nr86gpql9hpxcw4j9nbr9vms-perl-5.28.2-env/lib/perl5/site_perl -I/nix/store/65h67v6ilwvjp8xqrr73q0yhw4rdhpaa-perl-5.28.2/lib/perl5/site_perl -I/nix/store/vk301av7nr86gpql9hpxcw4j9nbr9vms-perl-5.28.2-env/lib/perl5/site_perl -I/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/lib/perl5/site_perl
#   latexindent.pl, version 3.5.3, 2018-10-13
#
#       This program is free software: you can redistribute it and/or modify
#       it under the terms of the GNU General Public License as published by
#       the Free Software Foundation, either version 3 of the License, or
#       (at your option) any later version.
#
#       This program is distributed in the hope that it will be useful,
#       but WITHOUT ANY WARRANTY; without even the implied warranty of


Weapons do 0 damage

Current/Expected Behavior
Weapons deal 0 damage against all entities.
Plugins are all up-to-date.
Steps To Reproduce
No steps it just started happening soon after the most recent updates.
No conflicting plugins.
Log File
logs.zip
Anything else?
Thanks for your interest!

I reproduced the same problem. The solution is to set the damage as a float instead of an integer value.

This has been fixed for while... make sure to use latest


Seminar Style Tutorials?

It's been proposed that we break up our tutorials into smaller chunks that are two-hour long segments.  Can we develop a curriculum of "seminars" that gets people to the "I'm read for a hackathon!" stage.

See this doc:  https://hackmd.io/EobPwspVRZGl3f3bgPFH1g

I've started a Google Doc to flesh out the seminar series for the first 3-6 months:
https://docs.google.com/document/d/1sEYXyT7SMbwJdgY-poGf--tYkIBn9zN-srnaLFxLa2o/edit#

This is moved to https://github.com/NCAR/python-tutorial so should we close this issue?

Yeah.  Maybe we should reference this issue in the https://github.com/NCAR/python-tutorial issue and then close this.


SW-1425 Add manual state flag to accessions

The new version of the app will allow users to manually edit accession states.
There will still be some automatic state transitions but far fewer than before,
and they will follow a different set of rules.
Add support for manual state management in the data model, including the rules
for automatic transitions. This is tracked on a per-accession basis and an
accession can be moved back and forth between manual and automatic state
management, though the conversion is a bit lossy since the list of valid states
isn't the same in the two worlds.
This only changes the data model and the transition rules; the API behavior
remains the same as before. If you GET an accession whose state was manually
set to one of the newly-introduced states, it will be automatically converted
to one of the previously-existing states for backward compatibility.

Current dependencies on/for this PR:

main

PR #562

PR #563

PR #564   👈

This comment was auto-generated by Graphite.

Marking this as a draft because the list of new state transition rules still needs final approval from the product team. But if they ask for tweaks to the rules, the changes will most likely be limited to AccessionModel.getManualStateTransition() and the rest of the PR should remain unchanged.


BlockLexer.parse() is not idempotent

I would expect that calling parse two times with the same value would return the same result; however, it appears to append.
>>> import mistune
>>> lexer = mistune.BlockLexer()
>>> lexer.parse('foo')
[{'type': 'paragraph', 'text': 'foo'}]
>>> lexer.parse('foo')
[{'type': 'paragraph', 'text': 'foo'}, {'type': 'paragraph', 'text': 'foo'}]

The parse method actually behaves like feed. To archive your goal:
lexer = mistune.BlockLexer()

def block_parse(text)
    lexer.tokens = []
    return lexer.parse(text)

No, I can't change the BlockLexer.parse, it should behave like feed.

Thanks for the explanation and suggestion. That’s essentially what I implemented myself.
Are you open to a PR to add a block_parse() function so that an idempotent parser is available natively?

From: Hsiaoming Yang<EMAIL_ADDRESS>Sent: Saturday, December 16, 2017 12:28:42 AM
To: lepture/mistune
Cc: Tommy Falgout; Author
Subject: Re: [lepture/mistune] BlockLexer.parse() is not idempotent (#147)
The parse method actually behaves like feed. To archive your goal:
lexer = mistune.BlockLexer()
def block_parse(text)
lexer.tokens = []
return lexer.parse(text)

No, I can't change the BlockLexer.parse, it should behave like feed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/lepture/mistune/issues/147#issuecomment-352164673, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAp7l9dy_F5nXvbUmSI51LSPUOAMJq2Hks5tA2MZgaJpZM4REAI-.

@lastcoolnameleft Thanks, but no. There is a plan to rewrite mistune, but currently I don't have much time, since my focus is on https://github.com/lepture/authlib
This is not a bug, I don't think it is very important.


Move string based arguments to boolean to better integration on jenkins

Removed --cleanup-clusters as it is the default behaviour, all clusters are deleted by default at the end of the execution.
Added --preserve-clusters to allow clusters to not be removed after execution.

This is because having a --cleanup-clusters True working by default and needing to explicity define --cleanup-clusters False is harder to transport to every job or execution. Boolean parameter is easier to integrate.

--cleanup  [True|False] has been also moved to boolean parameter, so now it is only required to use --cleanup when we want to delete working folder and all its content, and do nothing if we want to preserve it (default)

@morenod the code and all looks fine. My question is do we want to change the default behavior to NOT clean up clusters. In the scale testing that I've done we generally leave them on for a few hours to see how other components respond.

As we are managing it with a parameter, both defaults are ok, we only have to determine which we want, and create a parameter to remove or to preserve, and extend that choice in the same way to the job, to avoid needing to negate the parameter, to keep the code easy to read.
If default is to remove everything, we need the preserve. If we want to keep clusters created always, I will restore the cleanup and adapt the job.
On both cases, the most important thing is to have a boolean parameter, cleanup or preserve both are ok


Use release version of the JUnit5 dependency in the JUnit5 tests and JUnit5 example modules

See this modules:

JUnit5 tests
JUnit5 examples

Can I take this one?

Of course!

Submitted PR #38. Please review and let me know if it looks ok.

Looks great, thank you!


merge package template from Kronos-Tools/npm-package-template

package.json

chore(engines): update<EMAIL_ADDRESS>from template

.travis.yml

chore(travis): merge from template .travis.yml

Coverage remained the same at 83.108% when pulling 0431cd75a240a8c1aa3f6541f22aa8f799d345e8 on template-sync-1 into c2fe8886e61759d15d6f9e872cfc3840527b5540 on master.

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   86.59%   86.59%
=======================================
  Files           1        1
  Lines         194      194
=======================================
  Hits          168      168
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fe888...0431cd7. Read the comment docs.


Add DevOps Docs

solves #48

@gigincg can you review this.
I am not sure why we need docs for the CI files. A few of it looks redundant.

@dauntlessnomad @gigincg Please review the PR

@tellmeY18 whats the status here!!!!!

Finishing up the last bit of changes. Will commit the changes tonight.

Merged as a base DevOps Doc. @tellmeY18 Do file an issue to clean this up to improve quality separately


eBPF Standardization

Hi folks,
This is not a regular issue about Solana's rbpf.
I'm writing to let you know that there is an undergoing effort to define a more formal specification of eBPF, and to publish it as a “standard” for eBPF (to be hosted by the eBPF Foundation). This specification tries to account for the different implementations existing to date, including in Linux, ebpf-for-windows, uBPF, and the initial rbpf project too.
I know that Solana has been using eBPF, but there are not many bonds between your community and the rest of the BPF developers/users on other platforms (as far as I know). You are likely the main users of rbpf, so I thought I'd let you know, in case you want to get involved in this effort (if you wanted to be compliant to the standard in the future - the original rbpf may need some adjustments to be compliant, and I have no idea to what extent Solana's fork diverged from it), or at least so that you are aware of it.
Some relevant links:

The ongoing discussion is on the Linux BPF mailing list here.
There was a talk on the topic last week at LPC, although mostly addressing technical points raised while writing the doc.

Of course, everybody's welcome to join the discussions.

Hey 😊
Thanks for the heads up - those docs look great!
solana_rbpf has diverged significantly from eBPF and we have started calling our variant SBF to better reflect that. That said we did fix and harden a bunch of things in rbpf and have been talking about potentially contributing back some of our changes. It's just a bit tricky since we have diverged a lot in project structure etc.

Oh, I hadn't noticed that you were involved here. Good, more ties than I thought, then :)
OK, SBF as a name makes sense to me in that case. That's a good move, makes it less confusing.
Regarding upstreaming your changes to rbpf, I'm totally open to that, it would be great! The initial project has been pretty inactive so there shouldn't be much in terms of conflicts. About the changes on the project structure, I don't mind too much if it changes, given that you're the actual users of it. I'd like rbpf to comply with the eBPF standard under preparation, so maybe there will be friction around that (I don't know), but otherwise I'm pretty open.


[SPIKE: 2 hrs] Automate setting up Grafana alerting via grafonnet

Context
In #5062, @sunu had difficulty creating alerts automatically via grafonnet. The current work-around is a one-time manual step to enable alerting in the grafana UI.
There is more experience within 2i2c staff members with using grafonnet, so perhaps we may find a way to unblock this with a spike?
Task list
 - [ ] Investigate whether or not it is possible to setup grafana alerting automatically via grafonnet

Definition of Done

[ ] We have learned whether grafana alerting can be automatically setup via grafonnet
[ ] The learnings of this spike have been added to this issue as a comment

We are attempting to use prometheus alertmanager instead so I now this issue is redundant https://github.com/2i2c-org/infrastructure/issues/5062#issuecomment-2504753105
We can reopen if alertmanager path proves unworkable


FilesMetadataEmitter reports wrong file count when importing multiple files

When importing files from a folder (s3a://bucket/path/folder) or using a glob (s3a://bucket/path/file-0*), class FilesMetadataEmitter logs a wrong file count. The count is always one more than the actual file count:
[main] INFO com.exasol.cloudetl.emitter.FilesMetadataEmitter - Found total of '101' files in path 's3a://bucket/path*'.

When importing a single file, FilesMetadataEmitter logs correctly Found total of '1' files in path 's3a://bucket/path/file.parquet'.
### Tasks
- [ ] Reproduce the problem

Cannot reproduce this issue. Even on s3 bucket, connector shows proper amount of files in the logs


EntityIdResolver fails on entities when the id is not called id

The EntityIdResolver currently only supports the getId functionality because it makes the assumption that every entity calls the property id and therefore the method getId. Via the Doctrine metadata you can find out which field is the actual id and it can be accessed using the property accessor of symfony.
http://stackoverflow.com/questions/6128914/how-to-get-doctrine2-entity-identifier-without-knowing-its-name
Combined primary keys is a different story and I don't think this can be supported as easily.

You may want to take a look at the IdReader class from the Symfony Doctrine bridge for some inspiration.

Can't this bundle simple use this IdReader class?

That's a good idea, I wonder why it's in the Form namespace though

It's designed completely for the ChoiceLoader of the Form component. Maybe we can make it more standalone before using it?
E.g., it uses the RuntimeException from the Form component and triggers messages which mentions the choice field type.

@WouterJ @xabbuh should be fixed #17, your reviewing skills are more than welcome!


feat: entries for Jefferson County Public Schools (Jeffco)

This PR creates entries for Jefferson County Public Schools.
Domains include:

https://jeffcoschools.us/
https://jeffcopublicschools.us/
http://jeffco.k12.co.us/

@Fyko Pull request merged. Thank you!


Login

Cloned repo
install and what not.
dfx deploy
App starts locally
clicking Login
http://localhost:4943/?canisterId=undefined#authorize

Fix: Correct this in vite.config.js, to the actual env variable:
const internetIdentityUrl =
process.env.DFX_NETWORK === "local"
? http://localhost:4943/?canisterId=${process.env.CANISTER_ID_INTERNET_IDENTITY}
: https://identity.ic0.app;

Good catch, thanks. The name of the variable changed with some dfx version. Added change to latest version.


Focus jumps when selecting component inside a modal

Version
6.1.4
Browser and OS info
Edge Version 100.0.1185.39 / Windows 10
Steps to reproduce
In an app with a modal open, select the Modal from the apps list in the leftmost column. Then expand a component to see its children. Select a child.
What is expected?
The left 2 columns remain the same, and the right column displays details of the selected component.
What is actually happening?
The selected app in the left most column reverts back to the main app, instead of the selected modal. The components column displays components of the main app instead of the modal. The component details show for the selected component.

We're using a QGlobalDialog in the Quasar framework on Vue 3

This is happening to me, using QGlobalDialog as well.
Vue Extension 6.6.3
Been happening for a long time by the look of it.


Throttle not launching in non-composed mode

Reason for change:
Here is a part of a launch file, where we trying to launch throttle as a node:
            Node(
                package="topic_tools",
                executable="throttle",
                name="throttle_odom",
                respawn=True,
                output="screen",
                emulate_tty=True,
                arguments=log_levels,
                parameters=[
                    *get_config(
                        os.path.join(
                            dir, "throttle-params.yaml"
                        )
                    ),
                ],
            ),

yaml:
/**:
  throttle_odom:
    ros__parameters:
      throttle_type: "messages"
      input_topic: "odometry/filtered"
      output_topic: "~/odometry/filtered"
      msgs_per_sec: 1.0

We face this error while executing the launch file:

Changes in this PR:

changed the we use args in main()

Results:

ros2 topic echo /odometry/filtered

This also works if you need a temporary fix:
Node(
package='topic_tools',
executable='throttle',
name='throttle',
output='screen',
arguments=['messages', 'odom', '10.0', 'odom/throttle'],
)

This also works if you need a temporary fix:
Node( package='topic_tools', executable='throttle', name='throttle', output='screen', arguments=['messages', 'odom', '10.0', 'odom/throttle'], )

Thanks, but we already merged the PR into our fork, so no need for temporary fix))


No file type icon preview in Windows Explorer

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.60.2
OS Version: Windows 10 20H2

Cannot find File Icon Previews with the specific file type.
I tried a complete reinstall after clearing all data. I have installed custom file icon themes, but I'm currently using the Seti theme.
I have included a photo of the file icon for a python file. I have Python 3.9 installed.

https://github.com/microsoft/vscode/issues/105681


Pull request descriptions aren't being HTML-escaped

E.g. On http://24pullrequests.com/organisations/twbs

The pull request whose title starts with "Whitelist" has an <li> in its description
The pull request whose title is "Add docs for #15340" has a <select> in its description

Thanks for that @cvrebert, it turns out the emoji javascript library we're using unescapes the escaped html from rails, I've disabled emoji for now.


Kindly add all remaining countries to countries.geo.js

Hi,
Kindly add all remaining countries to countries.geo.js and update this file. Also Geo Polygon coordinates showing wrong for India Map.
Kindly Refer for correct India Map https://www.mapmyindia.com/api/advanced-maps/WebSDK-LiveDemo/mapmyindia_addgeojson_polygon.
I want updated countries.geo.js.
Kindly do he needful

Hi,
Any update.
If you are busy then kindly let me know where i can get pending countries Geo polygon data which are given in \node_modules\react-svg-worldmap\dist\countries.geo.js

Please send a PR directly if you know how to update it, that's the point of open-source :)
AFAIK, we directly downloaded the data from an open data registry (I can't remember which one). If you want to make any corrections, feel free to.

@Josh-Cena @yanivam
How can I import the data in countries.geo.ts? I am getting this error in a NextJS app

My code is:
import countries from 'react-svg-worldmap/dist/countries.geo';

const data: Data = countries.features.map((country) => {
  return { country: country.I, value: 0 };
});

Hey @kul1010,
Thank you for the request. Our map is an open source map from NASA and does not have all of the ISO codes on Wikipedia intentionally because we did not want to make this map political in any way. We simply wanted an easy to import map component but we did not want to get into any disputes as to our data and so we chose an open source map that already exists. If you wish to add missing countries to the geo.js file, you can file a PR in which you make the changes locally and we will review whether or not they are controversial. We intentionally tried to stay away from any political conflicts that arise from this issue and we are also working on a feature to let users make their own maps but have not had the time to put that together quite yet. Thank you for your patience as it has been an incredibly busy time for me personally.
Yams

Hi, referencing #137 - can you clarify which map this pulls from, from NASA? e.g. a URL to the source. This doesn't appear to be included anywhere, in the readme or the license, so it'd be helpful regardless to document this.
(I think it's optimistic to avoid politics when it comes to country borders, but it'd be good to provide options to choose from at the very least).

Hey, I have clarified in the README


Resize image

Is there an existing issue for this?

[X] I have searched the existing issues

Flutter Quill version
10.8.5
Steps to reproduce
Hi, I'm using quill to insert images. But when I resize the image (especially after uploading it via Delta) it doesn't work or creates too much space. I'd like to know how to solve it. Thanks,
Expected results
When making the change, resize the image correctly, and do not create a margin between the items above it.
Actual results
The first insertion (without editing) generates extra space, and when I edit it, it doesn't work.
Additional Context

Screenshots / Video demonstration
[Upload media here]

Logs
[Paste your logs here]

Can you provide a video or a image example about this?

Closing the issue as we didn't receive a response, however, if you still have a question, consider creating a discussion. Related #2248


feat: pin sdk dependencies to match across repos

going to try pinning deps across the following repos to see if all can be updated/published successfully:

integrations-sdk
function-templates
stedi-cli

Closing as this didn't seem to fix the issue when I tested locally.


Support diagram styles customization under "Style" tab

Support diagram styles customization under "Style" tab when nothing is selected.
Asked in DID - 6941

Hi, is this the same meaning as the question I am raising in here?
https://github.com/jgraph/drawio-desktop/discussions/1254

It might be, but this is the right project to report editor issues.


Fixed code coverage script

Now the code coverage correctly reports cross package code coverage (like explained here https://github.com/ory/go-acc and here https://www.ory.sh/golang-go-code-coverage-accurate/)
The CI script now puts together all coverage (from unit tests and integration tests) and generate a final report in html
Signed-off-by: Francesco Guardiani<EMAIL_ADDRESS>

You can check out the coverage report here https://app.circleci.com/pipelines/github/cloudevents/sdk-go/848/workflows/3175875f-2f8a-40be-afe3-1d64688a41d6/jobs/823/artifacts

LGTM


Returns error message when "edit theme" is clicked

Re-installed VS 2017 today, works fine now! Appears to have been conflicting with another plugin


Add iopipe helper module example

The helper module allows a user to use methods like .mark and .log throughout the application, not just in the "main" module.

I can point to the invocations in the IOpipe dashboard for review.


Observing mismatches in values captured in log vs waveform for doe rand testcase

Hi,
We are trying to run smoke_test_doe_rand testcase and we are observing that the values which are seen in sim log are not matching the values from waveform and are also mismatching with the expected values which we are generating through .doe_test_vector.py file.

deobfuscated value of UDS is stored in KV3 and here we see that the data inside KEY_ENTRY[3][11] to KEY_ENTRY[3][4] is getting captured correctly in logs for output the rest locations are not getting captured correctly inside logs, same behaviour we are seeing for Field entrpy also first 4 DWORDS are getting captured correctly whereas the last 4 DWORDS are not captured incorrectly, can you please confirm if any other configurations needs to be enabled for this , kindly comment on this issue.
Thanks,
Navya

I am not able to recreate this issue in our environment.
Does this test fail every time, or was it just this particular set of test vectors that mismatched?

Yes , everytime it fails .

We're not able to reproduce this failure in our environment.
Are you running on caliptra_top_tb?

Yes running on caliptra_top_tb , and the test vectors are generating through  .doe_test_vector.py file.

Can you please let me know if im missing on any thing, updating the steps below which im doing
->copying the doe_test_gen.py to the sim area
->executing make script for program.hex generation
-> updating $system("python3 doe_test_gen.py"); with python3 version
->make script for simulation

Can you attach logs from the simulation, and the generated doe test vector file? That might help me reproduce it on our end.

please find the doe_test_vector.txt file generated
2f5c9f67039ed245c67dfce7482498fb93c7e52111f497d1abaa2b3d35db8e36
e717334a7e82fa18580e158304ddf891
c0d34baf2b9b923bb7f705d3d92344db03d860835eafba2ea1350e3b65e61d9506f731c069f70883172a1d97442115ef
0f468d9106b9b97f905ba4c06e0ca79efb624407281ed50132ef0a1851a0384736db73bfb24a60dd30d5e450e65eeac1
2f5c9f67039ed245c67dfce7482498fb93c7e52111f497d1abaa2b3d35db8e36
2a9a9138d13e772b3baf12cf1a9c5143
58751f41f30094c19c1a53b1064efc0609b9f4758f31579164bb75c4875602fa
784b2244ab88ee79863081a0adcb7db9ffdd68a41a4f3dcdeb68f4f660cefbe1

I ran with this set of generated vectors and everything passes. I did some sanity checks and confirmed the values by inspection too. Do other tests pass in your environment?
You'll need to do some debug on your end. First confirm that doe block is getting the correct values for obf key, uds, and IV. If those are correct, the output from DOE should be correct.


Pivot Columns / Group Header Incompatibility as of 6.5.2

What version of React-Table are you using?
6.5.3 & 6.5.2,  Working as of 6.5.1
What bug are you experiencing?
The table does not render when you have a configuration with pivoted columns that are not grouped and aggregated columns which are grouped. If all columns are grouped, three is no issue.
Uncaught TypeError: Cannot read property 'Header' of undefined

        let PivotParentColumn = pivotColumns.reduce(
          (prev, current) =>
            prev && prev === current.parentColumn && current.parentColumn,
          pivotColumns[0].parentColumn
        )

        let PivotGroupHeader = hasHeaderGroups && PivotParentColumn.Header
        PivotGroupHeader = PivotGroupHeader || (() => Pivoted)

Use https://codesandbox.io/s/X6npLXPRW (by clicking the "Fork" button) to reproduce the issue.
Broken (6.5.3):  Notice that first and last name are not grouped
https://codesandbox.io/s/wyvor42vw
Working (6.5.3)  Notice that first and last name are now grouped
https://codesandbox.io/s/n780jz8600
Working (6.5.1): First and last name are not grouped, but the table is still working
https://codesandbox.io/s/l599vz8277
What are the steps to reproduce the issue?

Have a configuration where you have pivot columns which are not grouped and aggregated columns which are grouped.
Render the table

This should be fixed in the latest version

It seems this was never fixed. I tried with every version from 6.5.2 to 6.7.6 and it's not working.

It won't currently work with the code provided by scrawfor because it defines parents for every columns except the pivoted ones. If no columns have parents, it works.

Still not working.  Considering a fork as this is mission-critical.

I am having this issue as well.

This is not fixed, workaround is to put pivoted column into a header group as well.


Unable to add healthchecks to upstream {"healthchecks":"healthchecks is an unknown field"}

NOTE: GitHub issues are reserved for bug reports only.
Please read the CONTRIBUTING.md guidelines to learn on which channels you can
seek for help and ask general questions:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#where-to-seek-for-help
Summary
SUMMARY_GOES_HERE
Unable to add health checks to upstream
Steps To Reproduce

Add a new upstream with healthchecks
i am using standard json given on website

{
"name": "solrupstream",
"healthchecks": {
"active": {
"concurrency": 10,
"healthy": {
"http_statuses": [ 200,202 , 302 ],
"interval": 0,
"successes": 0
},
"http_path": "/solr/",
"timeout": 1,
"unhealthy": {
"http_failures": 0,
"http_statuses": [ 429, 404, 500, 501,
502, 503, 504, 505 ],
"interval": 0,
"tcp_failures": 0,
"timeouts": 0
}
},
},
"slots": 100

}
Getting following error
Additional Details & Logs

Kong version ($ kong version) kong version
0.11.2

Kong debug-level startup logs ($ kong start --vv)

Kong error logs (<KONG_PREFIX>/logs/error.log)

Kong configuration (registered APIs/Plugins & configuration file)
Standard Kong Configuration with no plugins

Operating System
bitnami image on GCP -

cat /etc/*-release
PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
NAME="Debian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org

See https://github.com/Kong/kong/blob/master/CHANGELOG.md#released - please upgrade your Kong installation to 0.12 or above to use the new healthchecks feature.


OpenMC-mgxs-plot

hi everyone,
I have created a mgxs in OpenMC13-3 and want to Plot the fission Cross section for U235, and get this error:
fig = openmc.plot_xs('U235', ['fission'])

File "/dss/dsshome1/0C/ge25kij2/.local/lib/python3.8/site-packages/openmc/plotter.py", line 169, in plot_xs
for this, types in reactions.items():
AttributeError: 'str' object has no attribute 'items'
can anyone help me sollte this error?
thank you
Mary

From the documentation
reactions ([dict](https://docs.python.org/3/library/stdtypes.html#dict)) – keys can be either a nuclide or element in string form or an openmc.Material object. Values are the type of cross sections to include in the plot.

You are passing a string, 'U235, which is the wrong type.
Also I don't think this is the right GitHub repo you opened the issue in.


Safari bug: Input fields issue

To reproduce: Start typing and see diff. between placeholder and text

Fixed!


Determine SnowEx Sites of Interest

What we want, what we need to avoid.

SnoTel sites within 5km of 1 or more SnowEx sites listed as CSV and SHP files under my file directory


Question: Why is using RML file slower than YARRRML

When testing the usage of yarrrml versus rml mapping file (with the rml file being a conversion of yarrrml, so the same mappings), yarrrml is slightly quicker (+-10%).
When looking in the code of morph-kgc, yarrrml is converted to rml when using it as mapping config. So how come it is quicker? Is this because yarrrml is easier to load in than rml?

This might have been because the the rml mapping seem to also map the graph, but yarrrml does not. More research needed.


chore: sort exercises and adjust difficulties

Result from the script with adjustments from #76 comments.
Closes: #73

Great! Could you also run bin/configlet fmt -y -u?


Don't use enter to autocomplete

It's kind of a pain to evaluate short variables quickly since the autocomplete gets in the way. For example, I can't quickly type n and then hit enter, since it autocompletes to new. Considering that this is a REPL and you'd expect people to want to hit enter pretty often to evaluate things, doing autocomplete feels wrong to me.

@patrickgaskill I'll disable autocomplete selection on enter :+1:

Made it optional and turned off by default. (fixed in v2 branch)

Thanks!

Merged to master


Investigate missing somatic evidence in 21.09 submission

Reported by Irene on Slack:

I am noticing a decrease in the number of evidence for eva_somatic  (from 13 477 to 12 325). I am not sure if you’ve introduced any changes that I’m not aware of.
So far I’ve compared the associations (targetFromSourceId/diseaseFromSourceMappedId) that we are missing and RCV000427788 is one example. There’s no evidence string for this accession in the file you submitted, although it is present in ClinVar.
 diseaseFromSourceMappedId      | EFO_0000198
 targetFromSourceId             | ENSG00000119772
 alleleOrigins                  | [somatic]
 allelicRequirements            | [Somatic mutation]
 clinicalSignificances          | [likely pathogenic]
 cohortPhenotypes               | [MYELODYSPLASTIC SYNDROME, SUSCEPTIBILITY TO, Myelodysplastic syndrome, Myelodysplastic syndrome, somatic]
 confidence                     | no assertion criteria provided
 datasourceId                   | eva_somatic
 datatypeId                     | somatic_mutation
 diseaseFromSource              | Myelodysplastic syndrome
 diseaseFromSourceId            | C3463824
 literature                     | null
 studyId                        | RCV000427788
 variantFunctionalConsequenceId | SO_0001583
 variantId                      | 2_25234373_C_G
 variantRsId                    | rs147001633
only showing top 5 rows

In [514]: new_es.filter(col('targetFromSourceId') == 'ENSG00000119772').filter(col('diseaseFromSource') == 'Myelodysplastic syndrome').first()

The example RCV is actually present in the evidence strings but with no allele origins, so it defaults to eva rather than eva_somatic.  We shouldn't ever have evidence without allele origins so this definitely seems like a regression.
21.09:
{
  "datasourceId": "eva",
  "datatypeId": "genetic_association",
  "allelicRequirements": [
    "Somatic mutation"
  ],
  "clinicalSignificances": [
    "likely pathogenic"
  ],
  "confidence": "no assertion criteria provided",
  "studyId": "RCV000427788",
  "targetFromSourceId": "ENSG00000119772",
  "variantFunctionalConsequenceId": "SO_0001583",
  "variantId": "2_25234373_C_G",
  "variantRsId": "rs147001633",
  "cohortPhenotypes": [
    "MYELODYSPLASTIC SYNDROME, SUSCEPTIBILITY TO",
    "Myelodysplastic syndrome",
    "Myelodysplastic syndrome, somatic"
  ],
  "diseaseFromSource": "Myelodysplastic syndrome",
  "diseaseFromSourceId": "C3463824",
  "diseaseFromSourceMappedId": "EFO_0000198"
}

Vs. 21.06:
{
  "alleleOrigins": [
    "somatic"
  ],
  "datasourceId": "eva_somatic",
  "datatypeId": "somatic_mutation",
  "allelicRequirements": [
    "Somatic mutation"
  ],
  "clinicalSignificances": [
    "likely pathogenic"
  ],
  "confidence": "no assertion criteria provided",
  "studyId": "RCV000427788",
  "targetFromSourceId": "ENSG00000119772",
  "variantFunctionalConsequenceId": "SO_0001583",
  "variantId": "2_25234373_C_G",
  "variantRsId": "rs147001633",
  "cohortPhenotypes": [
    "MYELODYSPLASTIC SYNDROME, SUSCEPTIBILITY TO",
    "Myelodysplastic syndrome",
    "Myelodysplastic syndrome, somatic"
  ],
  "diseaseFromSource": "Myelodysplastic syndrome",
  "diseaseFromSourceId": "C3463824",
  "diseaseFromSourceMappedId": "EFO_0000198"
}

Okay, allele origin is present in ClinVarAssertion but not in the ReferenceClinVarAssertion...  I think the next steps are to answer the following:

Is the situation the same for all the missing somatic evidence strings?
Is this a recent change in ClinVar?
Is this an intended change?

Then we can figure out what we need to do.

Thank you for your investigation!
If I may add something on the first open question that you raise, I have extracted which are the missing studies that are not present in any ClinVar evidence in this submission.
I got a set of the 3 following RCVs, which are indeed accessions that have been deleted:
+------------+
|     studyId|
+------------+
|RCV000431957|
|RCV000425153|
|RCV000432594|
+------------+

Therefore, I presume the situation you mention above is the root source of the issue.

Just to confirm, this is indeed a recent change in the ClinVar data (i.e. since the last submission): it looks like about 1300 records have had allele origins removed from the RCV.  So there's no error in the processing pipeline, but we will have to determine how to appropriately handle this for the next submission, e.g. by parsing another part of the XML.
Thanks again @ireneisdoomed for bringing this to our attention!

Hi @apriltuesday!
Thank you very much for looking further into it. Since this is apparently coming from upstream I have a question:
If you take the above mentioned RCV000427788 as an example, you can see that the Origin annotated for the SCV is still somatic. As well as the type of mutation reported in the paper. I checked this was the case for 4 more accessions. Do you think we:

should manually convert this evidence into somatic? or
should remove the offending accessions out of the germline dataset?

Hi again!
I want to let you know that the intended approach for our upcoming release is to be cautious with the data and remove those accessions from the eva dataset. I have uploaded an updated version of your submission to the bucket (otar012-eva/cttv012-2021-09-23.json.gz). This file no longer contains 1301 accessions that account for a decrease of 1310 evidence.
Thank you so much for your investigations. For the next release, we would love to bring them back. Since the somatic tag can be seen on their web, could you please revise if there is a more proper field in ClinVar's file to extract this information?
Cheers!

Absolutely, we'll be looking into how to bring these back accurately, and also probably adding some quality checks so we can catch these sorts of anomalies before submission.  I'll keep this issue updated!

The allele origins are not present at all in the reference record but only in the submitted records, which is what's shown on the ClinVar website.  We don't currently process the SCVs as the information should be aggregated into the reference record by ClinVar (which is I presume what they'll be fixing), and we're not currently planning to do so as it would require a significant amount of work and likely duplicates the work ClinVar already does to generate RCV records.
It's also unclear right now the full implications of us parsing SCVs as well as RCVs.  For example, in the June ClinVar XML there were about 30k records with (minor) discrepancies between SCVs and RCVs in the alleleOrigins field alone, though only the 1301 you uncovered actually had an impact on the classification of the final evidence strings. Assuming the situation is similar for other fields, we'd need a coherent strategy to reconcile such discrepancies.
Let me know if that all makes sense.  For the upcoming submission, as the deadline is coming up soon we'll manually check whether these RCVs have been fixed by ClinVar, and if not we'll continue to drop them as you suggest.

Makes perfect sense @apriltuesday. Thank you very much for the details.

Just confirming that these RCVs are present in the 2022.02 submission with somatic data type, so closing this issue.

Thanks!


[Workspaces] Take into account virtual desktops

Description of the new feature / enhancement
Only the active virtual desktop is included in workspaces. Please consider taking into account other virtual desktops as well.
Scenario when this would be used?
I have usually one virtual desktop for (deep) work and another virtual desktop for personal stuff like music, mails etc. This enabled a clear separation (e.g. work vs other things). It would be great if PowerToys Workspaces could support virtual desktops as well.
Supporting information
No response

totally agree on this!

I was SO excited for Workspaces because I hoped exactly for this. Windows, by default, does a "good enough" job of remembering where my open applications sat on the screen and FancyZones helps with ironing out the kinks. But I tend to work from home sometimes, and there I switch from using a large, office screen, to using just the laptop. And in that case using virtual desktops is a must, which Windows completely fails to handle.

Totally agree on this one.
At the office i use a widescreen divided into 3 FancyZones. I use 3 Windows desktops on this screen, with several programs in different desktops, and it would be wonderful if i with only one Workspace shortcut could start all programs on all desktops at once. In addition i also often work from home, where i use a standard screen, and with one workspace for this one.
This would be a game changer.

I fully support the addition of this feature to PowerToys/Workspace. A potential solution is adding a toggle in the settings to allow users to include or exclude virtual desktops. In the workspace editor window, the physical desktops (monitors) could be represented vertically, while virtual desktops are displayed horizontally. This would effectively create a matrix layout for visualizing the workspace.
For example, if you have 4 virtual desktops and 2 monitors, the editor could display something like this:
+-------+-------+-------+-------+
| M1 VD1| M1 VD2| M1 VD3| M1 VD4|
+-------+-------+-------+-------+
| M2 VD1| M2 VD2| M2 VD3| M2 VD4|
+-------+-------+-------+-------+

where M stands for Monitor, and VD stands for Virtual Desktop.
This is just a suggestion for visualizing the workspace layout. As for the implementation, I don’t feel confident providing coding suggestions 😅.

The option to open a workspace on a specific virtual desktop and do this on start-up would indeed be fantastic!
Workspaces would also seem to provide an opportunity to specify which instances of applications (or windows) should stay open on all virtual desktops.
Currently the setting "Show this window on all desktops" needs to be applied on reboot, presumably because Windows has no way of storing which window has that setting applied.
Since Workspaces allow specific instances of applications (windows) to be launched (and remembered) it would seem possible to provide a flag to specify that they stay open on all desktops which could be applied to the window once launched.

Any updates on when this might become a feature? @plante-msft

Any updates on when this might become a feature? @plante-msft

@0xDeadcell we definitely want this feature, but the Virtual Desktop APIs we need to make it work are largely private and we are required to use public APIs.
We're investigating how to work around this, but as a result this item has a longer lead time since we're effectively blocked right now.

Absolute must have.

This feature would be game changing!


leaderboard.js and sidebar.js not passing test

They don't pass the renders without crashing test, I think the tests just need updating.
src/client/components/leaderboard/leaderboard.test.js

  ● renders without crashing

    TypeError: Cannot read property 'includes' of undefined

      14 |     let passed = this.props.passedUsers;
      15 |     function hasPassed(_idx) {
    > 16 |       return passed.includes(_idx.toString());
         |                     ^
      17 |     }
      18 |
      19 |

src/client/components/sidebar/sidebar.test.js

  ● renders without crashing

    TypeError: Cannot read property 'length' of undefined

      31 |   render() {
      32 |     let dealtCard = getDealtCard(this.props.G);
    > 33 |     const isLastToPass = this.props.G.passed.length === this.props.ctx.numPlayers-1 && !this.props.G.passed.includes(this.props.playerID)
         |                                              ^
      34 |
      35 |     return (
      36 |

Resolved by #102


[Bug] fixed the delay in the pledge activity digest spinner

What ❓

Paired with @eoji on fixing the delay in the NotificationsActivity it was due the emissions of the userInput and userOutput being in separate observables.

How to QA? 🤔

Upon deselecting 'Project activity' if I have 'Daily summary' as my chosen value, the spinner will first change from 'Daily summary' to 'Twice a day summary', then close. If I re-enable 'Project activity', it will start from 'Twice a day summary'.

It should now just collapse the spinner without changing the values.

See 👀

nice!


Fix Windows builds on Docker + add all option for arch/platform

So like many things, this fix started simple, with me just wanting to fix the Docker Windows builds to fix #997.
However, tugging at that thread uncovered more threads, and here we are. I do have the pure Docker fix in its own commit which I could create a PR for separately if desired, but I figured I'd put all these related fixes in one PR. In fixing the Docker issue, I was able to convert over to Alpine (accomplishing the closed #890). As part of testing this Docker issue, I wanted to make sure I could still build Windows (and all other platforms) with all supported architectures. In researching which platforms supported which archs in electron, I came across a nifty arch option: all. (https://electron.github.io/electron-packager/master/interfaces/electronpackager.options.html#arch). Which led me to discover the equivalent platform option (https://electron.github.io/electron-packager/master/interfaces/electronpackager.options.html#platform). And these seemed like a good way to ensure the Docker gets tested well.
So in this PR:

Docker builds for Windows are fixed (fixes #997 )
Switched over to use alpine (as was indicated as desired in https://github.com/nativefier/nativefier/issues/375#issuecomment-304247033) - which may mean #375 is likely fixed as well.
Fixed bug where Docker has the wrong line endings when copying from a Windows host
Fixed the invalid arm arch to armv7l
Add npm t to the docker build to ensure tests pass before we start trying to do builds
Allow use of the electron packager "all" platform to build for all supported platforms

NOTE: When specifying all for platform, and no user agent is specified, a generic chrome user agent will be calculated that omits OS and Arch

Allow use of the electron packager "all" arch to build for all supported archs
Add a message to help the user when trying to build Mac apps on Windows as a non-Admin (currently an unhelpful exception)

@ronjouch I have removed the all code. Testing the Linux apps generated under the Dockerfile and verifying the is-admin changes on my Windows box. Please hold off on merging until I can verify both.

@TheCleric merging. Great work, thanks!

@TheCleric merging. Great work, thanks!

You're welcome. Thanks for helping me get it through.

I'll cut a release soon-ish.

Released in v42.4.0. Thanks!


Automatic binding of $data params in component

Sometimes you have a component which does not have a viewModel associated (like an outlet view, or just a 'plain' component). In these cases it is often desirable to be able to bind to an objects properties without having to register and supply a separate viewModel to do that simple operation yourself.

  <component params="$data: $data"></component>

The previous would instantiate the component and pass the data to it using the $data context reference. Footwork would recognize the $data params attribute and use its value to extend the default (blank) viewModel. This would enable you to write a template which bound to these properties without having to write your own viewModel:

Note you could pass this same $data to an outlet via:
router.outlet('outletName','thingToDisplay', {
  params: {
    $data: {
     propertyOnDataObject: 'someValue'
    }
  }
});

This would allow you to write bindings in an view template which uses this data.

$viewModel as the indicator to footwork to use the supplied data as a viewModel seems more descriptive after some playing around with the syntax:

  <component params="$viewModel: $data"></component>

Resolved with $viewModel as mentioned above in: b7fa2053d8a303e6402f5e15dd8382582acc5565


Setting for dot → comma

In Germany, the decimal point is used instead of the period for real numbers (2→,←40 instead of 2→.←40). This is the default setting on the numeric keypad.
It would be helpful if this could be configured in the settings so that the hand can remain over the numeric keypad instead of always having to switch to the main keyboard.
I know that I could reconfigure the numeric keypad, but then I have to work this way in all other programs, so it's not an option.

This is mostly the same as #21. Unfortunately, this plugin is a thin wrapper over mathjs, which doesn't support this feature (and it looks like it never will). It looks like it can be supported for users that don't use the more complex features, but it will be fragile.


Deprecate set_conf_file

In-tree, all usage of 'set_conf_file' is implementing the same
pattern (with some inconsequential differences).
To reduce copy-paste and get closer to dropping support for
'set_conf_file', we include this pattern into the built-in set of
patterns.
'set_conf_file' is causing issues for future extensions,
e.g. multi-image support, and is also the source of a lot of
duplicated code.
Note support for 'set_conf_file' is not dropped, it is only marked as
deprecated.

@pfalcon : FYI

Codecov Report

Merging #13948 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13948      +/-   ##
==========================================
- Coverage   52.29%   52.25%   -0.04%
==========================================
  Files         307      307
  Lines       45429    45429
  Branches    10506    10506
==========================================
- Hits        23756    23740      -16
- Misses      16887    16899      +12
- Partials     4786     4790       +4

Impacted Files
Coverage Δ

subsys/testsuite/ztest/include/ztest_assert.h
38.88% <0%> (-38.89%)
:arrow_down:

subsys/testsuite/ztest/src/ztest.c
65.28% <0%> (-7.44%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e731bdc...fdee915. Read the comment docs.


MM-20527: Migrate 'components/user_list_row' module to TypeScript

Summary
This  PR migrates 'components/user_list_row' module to TypeScript and converts to it to FC
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/13713
JIRA: https://mattermost.atlassian.net/browse/MM-20527
Release Note
NONE

Hello @sinansonmez,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-tests

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/227409

Test results: https://mattermost-cypress-report.s3.amazonaws.com/227409-b5a2c5e-onprem-ent-webapp-pr-10860-mm-ee-test:b5a2c5e/mochawesome.html

/update-branch

Thanks @sinansonmez
Tested, looks good to merge.
E2E report - no PR related failures.


bump approved HPE DL360 Gen9 firmwares in ansible-eol branch

mainboard: 2.80
iLo: 2.77

Tested in production! ;)

I already did that, let me check if I have to backport a change into the ansible-eol branch

Looks like ansible-eol is still missing the bits.

Let me check


Respect trailing whitespace on toggle

When toggling a checkbox, remaining whitespace not respected and removed.
Please note the whitespace on first lines!
This
- [ ] Checkbox
  This is on second line
- [ ] Checkbox

become this when toggle the first Checkbox
- [ ] Checkbox [2019-03-03]
  This is on second line
- [ ] Checkbox

Hi @gaponcode, thanks for asking, I've never noticed that 😄
Do you expect to have the whitespaces after the date like
- [ ] Checkbox [2019-03-03]

?

@PKief I think the best is that always when a date is added or not, it should preserve the whitespace at end of the line for explicit MarkDown linebreaks.
Note: The same 'trimming' is taken, when NO date is added and only the checkbox is toggled! Here the same, the whitespace should be preserved.
Thanks for your fast response! :-)

I changed the behavior to respect the whitespaces at the end of the line. You can find the updated version of this extension on the marketplace 👍


Support setting parameters for a provider

It seems OpenSSL 3.0 provider doesn’t have Engine Ctrl commands support programmatically from application which was there in OpenSSL 1.1.1 or before.
We are working in adding provider support to qatengine which relies on Engine ctrl command for supporting features such External polling, heuristic polling, etc where application interacts with engine using the Engine ctrl API for polling and act as an interface between engine and application (async_mode_nginx) for set and get params to and from engine.
Is there any other way that this could be achieved via provider as without engine ctrl support we will not be able to support  these features that engine framework supports.
Details about Features that use engine ctrl in here

Yes and no. There is a way to pass configuration parameters from a config file to a provider. There isn't a way to pass parameters dynamically for a running provider.
See the following man page for details (Section "Core parameters"):
https://www.openssl.org/docs/man3.0/man7/provider-base.html

@mattcaswell Is there any plan to support it as we would need this support for the features mentioned above.

Looks like we should have had a provider set params call to let this happen.
There is a very kludgy was to do this using get params which I'd not recommend.

IMO we can add that in 3.1

Now the question is if those set_params should be global per-provider or libctx specific. IMO they should be libctx specific.

That would imply that the get params should also be libctx specific.  They are currently global but are limited to constant information.  Once we've got mutable state in providers, the get needs to be able to retrieve it.
Agreed, 3.1 is possible.

Perhaps the libctx vs global state could be a decision for each provider?

Perhaps the libctx vs global state could be a decision for each provider?

Perhaps. What I mean is that the provider should be able to recognize if the set_params() was associated with a particular libctx where it is loaded.

Such parameters have nothing to do with the core.

I am not saying they have. I'm just saying that the provider needs to associate the call with a core handle.

Just checking if there are any plans to implement this or any alternacive way in providers ?


[ CONFIGURE SELECTED COMPONENT MENU ] Implementation of string param type

@mvdnet Is the string parameter type not working? I implemented it but it hasn't gotten a proper test yet.

I see now that a text model was added to the scriptlibrary, and the text param type does not work properly. I'll get that fixed.

This is fixed in commit 010b944f300d663d3ff1fb6e9424a20aba5590ae


[CELEBORN-1337] Remove unused fields from HeartbeatFromApplicationResponse

as discussed in https://github.com/apache/celeborn/pull/2398, this PR removed unused fields from HeartbeatFromApplicationResponse, without adding WorkerId Type

Merge to main(v0.6.0) and branch-0.5(v0.5.1)


qxcompiler: allow JSDoc comments in the format used elsewhere (type before variable name)

qooxdoo JSDoc comments are backwards from the rest of the world. Everyplace else, the type comes before the variable name; in qooxdoo, it's reverse. Suggest that the compiler allow recognizing it either way, so we could slowly migrate to the industry standard.

This should be fixed relatively soon because the APIViewer displays no parameter info if the correct jsdoc syntax is used.

done with https://github.com/qooxdoo/qooxdoo-compiler/pull/546


add empty chunk handling, importing python crate dependencies, tx filtering by address, support for new datatypes in python crate

Motivation

Closes #137, also pip did not install polars and some other libraries, this was also fixed.
Added filtering transactions by --address, which acts as an OR over filtering by --to-address and --from-address.
Adding the argument --write-empty to prevent from writing empty dataframes to disk
Added support for the new datatypes in the python crate

Solution

added the packages and versions into the build file
created a closure that copies the conditions of to and from filtering, adding the from-address into env.execution, and creating a global vector to log the tx hashes that have been moved (in order to prevent duplicates that arise from async)
added support for the flag, and added a couple lines that checks the dataframes shape. If shape is 0 and --write-empty is false, then it will continue rather than write to disk.
allowed the python crate to take in the new datatypes (like transaction), I can't take much of the credit, this was mostly already supported.

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

heyo. everything is looking great on the pr. the last thing is get_addresses(). does request.addresses() have everything you need to avoid the get_addresses() function?


Make it possible to use multiple filters on a dash

Currently, it is not possible to set up a custom command that takes two or more arguments, corresponding to two or more filters on the dashboard. It would be very helpful if this functionality was added.
For example, let's say I have a dashboard that tracks the number of new customers. Currently, I can add a date filter, and ping Lookerbot by saying /looker dashboard this month. However, I can't add another filter beyond the date. If I wanted to get all new customers this month who were larger than $1,000, I can't say /looker this month >1000.
Having the ability to pass multiple arguments into Lookerbot would be super helpful.

Thanks @ArvindIntercom. This is a duplicate of #28, so I'm closing this in favor of that issue. We definitely want to figure out how to do this. It's a little tricky to figure out the right syntax for this, as mentioned on that issue. Would love suggestions!

Hey Wil,
Maybe you could wrap the arguments in braces?
For example:
1 filter with two inputs
/looker dashboard [arg1,arg2]
2 filters with 1 input each
/looker dashboard [arg1] [arg2]
Or maybe you could allow the user to specific the filter field to force looker to use specific filters:
1 filter titled ‘App Name’
/looker dashboard app_name: ‘Intercom’
2 filters titled ‘App Name’ and ‘Date Range’
/looker dashboard app_name: ‘Intercom’ date_range: ’this moth’
Just a couple ideas, excited to see where you guys take Lookerbot, people were definitely impressed!
-Arvind

On Mar 29, 2016, at 4:58 PM, Wil Gieseler<EMAIL_ADDRESS>wrote:
Thanks @ArvindIntercom https://github.com/ArvindIntercom. This is a duplicate of #28 https://github.com/looker/looker-slackbot/issues/28, so I'm closing this in favor of that issue. We definitely want to figure out how to do this. It's a little tricky to figure out the right syntax for this, as mentioned on that issue. Would love suggestions!
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/looker/looker-slackbot/issues/34#issuecomment-203162743


[Bug]: Curtain/Motor/Shutter control disable wrong button

Requirements

[X] I checked the troubleshooting section in the README to verify that I have the latest Mushroom version.
[X] I did a search to see if there is a similar issue or if a pull request is open.
[X] I have read the state of card mod support (in pin issues) and understand card mod support is not provided in this repository.

Current Behavior
When shutter is open the modal shows "close" and viceversa.
Other the the wrong display mode, I can not bring down shutter due to the disabled button and viceversa

Expected Behavior
Like little weeks ago, when the shutter is open the modal show "open" and viceversa.
Maybe a wrong state of the "sensors" or a problem with the modal? maybe the sensors return 100 instead of 0 and viceversa?
Steps To Reproduce
No response
Context
YAML state
current_position: 0
device_class: blind
icon: mdi:window-shutter
friendly_name: Tapparella cucina
supported_features: 15

Environment
- Browser: Chrome 130.0.6723.117
- HA Version: 2024.11.1
- Mushroom: 4.1.0

Anything else?
No response

What integration are you using for your cover? Mushroom is using the logic from Home Assistant (0% is closed, 100% is open). If your entity doesn't respect that, it must be an issue in the integration you are using.

Ok so maybe it is related to Zigbee2MQTT
https://github.com/Koenkk/zigbee2mqtt/issues/24755


Consider removing EasyHttp

Consider removing EasyHttp in favour of a framework that doesn't have a JSON dep. Seems bad to force people to install a JSON nuget package as well.
Open to PR's on this :) :+1:

Any further consideration of PR #17? I can probably rebase it on 1.2 if you like.