Cdr-1902 Implement Move Operation

Updates move workflow to work against fcrepo4

Adds unit and integration tests
Adds move log
Currently removes reporting on move operations to users

Adds helper methods to ObjectPathFactory and ObjectPath classes to make them more usable, adds unit test
Removes getGroups method from AgentPrincipal class in favor of getPrincipals

I have delete/restore and move over in persistence since they are update operations that could reasonably be used outside of the services web application (services-camel or some other api), and that is the package where update operations have been contained historically (DigitalObjectManager, update pipeline).  Some of our modules aren't very well defined, and persistence could use a revisit.  That is something I am still hoping to get to, possibly before this migration is completed.


New Mojo for Build Execution Graph

Add a Mojo to create an "execution graph" of a multi-module project. Such graphs can show how the Build of a multi-module project can be parallelized.
Algorithm to create the execution graph:

Loop over the reactor (via MavenSession)

Create an edge from the current project to all "downstream" projects
If there is already an edge to one of the current "downstram" projects, remove it (keep the longest path to it)

See also: https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3

How is this coming along?

This is a bit more complicated than I originally thought. And there is not much time to work on that at the moment.

Version 4.0.0 will be on Maven Central soon.

I've tested this and it works to show the module structure of a project, but its not an execution graph. In a multi-threaded build the order of execution is something only known after it has occurred. This can be seen using the opentelemetry-maven-extension and examining the results in Jaeger/Zipkin etc. It will show where threads were not being maximized and which module(s) were holding things up.
The build order Maven gives at the start of the reactor log is a simplified directed acyclic graph. This list is unaffected by the number of threads.
For this plugin though, I would like to see a goal that produces a complete DAG of the build. This will show when a given module MUST be executed before any other module. This is different to the current reactor goal's graph because it considers the dependencies which do affect the build order. It will also by necessity work out any cyclic dependencies.


uploading unicode csv

when I upload a utf8 based csv file I get the following error:
'latin-1' codec can't encode characters in position 0-3: ordinal not in range(256)
I tried to add ?charset=utf8 to my SQLALCHEMY_DATABASE_URI but still no luck

I don't think it has BOM. see the attached sample file
test.csv.zip

@aboganas which superset version do you use?

First, I really appreciate your help. Thanks sooooo much
I'm using the latest version 0.27.0, but I'm using python 2. I will try to switch to python 3 to see if it solves the problem

@zhaoyongjie just tested with python3; unfortunately still same problem. Any help, will be greatly appreciated.

Thanks for the help; the problem was not sitting the correct charset that correspond to the database exactly.


Add Komoot announcement

To be filled with the announcement text. Will ping once it is ready for review.

Wow this is nice, congraz!

Ready for review.

https://twitter.com/maplibre/status/1646078355576442882
https://www.linkedin.com/posts/maplibre_we-are-happy-to-announce-that-komoot-has-activity-7051845054025359360-Msvr
https://mastodon.social/@maplibre/110185102079530725


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED
https://github.com/justswaporg/justlists/blob/main/example.justlists.ts
Checklist

[x] I understand that this is not the place to request a token listing.
[x] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[ ] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL:
JustList Name:
Link to the o

Please submit the correct information, invalid information will cause the issue to close


Various additions

css tweaks
use data() shorthand
create geneset search component with dummy species and temporary species select checkboxes (to be replaced by a multi-select in the future)
create sortable and paginated table component
make textbox component into controlled component
make debug func to generate dummy table data
make basic "Browse" page

Okay after some consideration I'm just going to merge this. This PR doesn't really do anything critical. Marco will review future PRs of significance.

Okay after some consideration I'm just going to merge this. This PR doesn't really do anything critical. Marco will review future PRs of significance.


Incorrect error thrown on transferFrom

Currently after the fix for #32 the error thrown when baseToken has no or insufficient allowance to Funnel is InsufficientRenewableAllowance
This does not reflect the actual cause of error which is the lac of underlying baseToken allowance.

The plan is to only apply baseToken allowance check on the external allowance() function, this satisfies EIP-20 requirement of allowance() returning the amount that can be transferFrom().
transferFrom() no longer checks baseToken allowance as the base erc20 will handle the case correctly.


OnFurnaceSwitch

Add hook to a furnace being turns on at off. Returns the player activating it, whether it is being turned on or off, and the furnace being interacted with.
(Not entirely sure what file to modify for the pull request)

This can't be pulled with the hooks that were unflagged, the path change, or the added dependencies. There also should not be any hash changes, did you use a different branch?

I forked off the develop branch, can you add the hook or should I try again?


Facing ImportError while trying to use get_currencies() without private key initialisation

Using version 0.3.2:
Traceback:
ImportError: dlopen(/Users/{venv}/lib/python3.6/site-packages/coincurve/_libsecp256k1.cpython-36m-darwin.so, 2): Library not loaded: /usr/local/opt/gmp/lib/libgmp.10.dylib
Referenced from: /Users/{venv}/lib/python3.6/site-packages/coincurve/_libsecp256k1.cpython-36m-darwin.so
Reason: image not found

on macos python 3.6.4 got the same error, with or without key.
brew install gmp
solved the matter for me, but don't know why.


Fractions functionality issue #395

Targetting issue #395.
Dunder methods for all Fractions functions.
The Fraction functions are still there, I don't know if you want to temporarily keep them for backwards compatibility or to be replaced entirely with dunder methods.
Also created Fraction.norm and Fraction.ceil class methods which could replace ceil_fraction and norm_fraction.

I would remove the old methods.
One plan for this was also that it is merged after #397, such that add mul etc have support for Union[int, Fraction].

That's fine.  #397 is pretty much ready to go. I'll come back to this when its merged.

I had to modify a few different things so that Self in Unions was accepted.
Currently running something like:
from opshin.tests.utils import eval_uplc
from opshin.std.fractions import Fraction
a = Fraction(5,7)
b = Fraction(11,13)

source_code = """
from opshin.std.fractions import *
from typing import Dict, List, Union

def validator(a: Fraction, b: Union[Fraction, int]) -> Fraction:
    return a + b
"""
ret = eval_uplc(source_code, a,b)

Works but running eval_uplc(source_code, a, 5)
Returns the following error:
Traceback (most recent call last):
  File "/home/wppj21/Workshop/opshin/test_class.py", line 121, in <module>
    ret = eval_uplc(source_code, a, 5)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wppj21/Workshop/opshin/opshin/tests/utils.py", line 35, in eval_uplc
    raise ret
  File "/home/wppj21/miniconda3/envs/opshin/lib/python3.11/site-packages/uplc/machine.py", line 111, in eval
    stack.append(self.return_compute(step.context, step.value))
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wppj21/miniconda3/envs/opshin/lib/python3.11/site-packages/uplc/machine.py", line 171, in return_compute
    return self.apply_evaluate(context.ctx, context.val, value)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wppj21/miniconda3/envs/opshin/lib/python3.11/site-packages/uplc/machine.py", line 210, in apply_evaluate
    res = eval_fun(*arguments)
          ^^^^^^^^^^^^^^^^^^^^
  File "/home/wppj21/miniconda3/envs/opshin/lib/python3.11/site-packages/uplc/ast.py", line 745, in wrapped_fun
    assert isinstance(
           ^^^^^^^^^^^
AssertionError: Argument 0 has invalid type, expected type <class 'uplc.ast.BuiltinInteger'> got <class 'uplc.ast.PlutusInteger'> (PlutusInteger(value=5))

Is this an bug in uplc or have I made an error somewhere?

There is a bug in OpShin, likely something we overlooked in #397.
When something is a Union[x,y] it is PlutusData. However for int and other primitive types I usually assume they are unwrapped into builtin data. Here there must be some missing unwrapping of int after casting it via isinstance. Note that addition can not be done with PlutusData and requires unwrapping via UInt before.

Try
def validator(x: Union[int, A]):
  if isinstance(x, int):
     print(x+2)

There is likely also another edge case in #397
def validator(x: int):
   y : Union[int, A] = x
   if isinstance(y, int):
     print("foo")

will likely crash

Is CI not working at the moment?

Great, thanks for the update. I think Travis is currently broken, I wanted to migrate to Github actions anyways and am preparing #406 for this. Will merge it into this branch to check that the tests are now still passing.

It looks like Self is a 3.11 only feature of typing. In previous python versions this is instead solved using literal strings like "Fraction".

Ah, I'll rewrite them all as literal strings then.

coverage: 89.428% (+0.02%) from 89.406%
when pulling bdf142f4b018392cb0850e96c8eb18dc75a9c4a2 on SCMusson:feat_frac_dunder
into 6f99124f990f47557a65d95c372788e5733e664e on OpShin:dev.

The fraction code looks great now. Unfortunately I still found (and added) 2 failing cases for #397.

I'll get to work on those

Thank you for those test cases, the first one I really should have thought of myself but I wouldn't have thought of the test_Union_builtin_cast_direct. I had to modify them so that the tests were correct so It might be worth you checking to make sure I didn't break the test.

Your modifications of if-expressions made me think... caught another bug :)

Sorry about the never ending new crashing examples... the last ones added are out of scope though (since not even properly implemented for unions of plutus data), I created #408 dedicated for them. also its not a problem if an expression does not compile.

Any update on this? :)

Apologies, I almost forgot I was supposed to be working on this. I've got the IfExp working now

Great, thank you! This will be part of the next version 0.24.0. Please submit your wallet address for the bug bounty :)

If this also signals the completion of #397 the same address can be used for the payout of that bounty too.

Paid out both #367 and #395
https://adastat.net/transactions/c62300dc553ae877376c7bb281997faf453cd5776c16db4e75b14584efbc76ce


Fix appending nodes

Description
This happens when there are multiple version of a word on a sententence and you attempt to append multiple of the same word to the sentence. In the test case the is the word we want to replace "language" and then a version of it "languages" that would not trigger the text not found error. Now the proper error is thrown and multiple instances of the word are not appended.

published in 0.4.1
https://www.npmjs.com/package/aracari/v/0.4.1


-webkit-line-clamp style binding not getting updated in Chrome/Safari

Vue version
3.3.0-alpha.4
Link to minimal reproduction
https://sfc.vuejs.org/#eNqdVE2P2zYQ/StT9eAWsKQA7Un1pi3S9FQEBVr0pAslje3JUiSXH7YXxv73PsqS43WCHAIYMjlf781wZs7F785Vh8RFU2xC78XFt62R0Vkf6f3JKTOoTvO/fIq09XakVVW/s+PksmoNUWv4NBkPvFVJRzpnaQ8Ta9jE0FwEdBdsnYUv+L60ZlNfgXGJPDqtIuNGtEHw2auMcHtLf1nPI4kLaaTBauspSCQ1clwD1QTuI8fkSQ3iJPRidsRaYkV/gE9PnUY4OIDgaAdL0UuI8pS4ondahUDKRdCmqHqJQsH2YsNTQjhCFOsV4QNzmDj2GTF1osjYEL1aTzIxPbtoA+1lZKPYhoo+qJGUiUwmmX5No4pRgBXpkMkR7zL9g9UpuiyUA3tAqbTLxP5jUOySRsajOsmYwprYAwBkACZDAptOOjZDGrMKISJrnQL5FD3cgnLCBirgZM5DZhahmM0AsHBCevhV317n91GQ7GJMGoZAUD1S11rdPMBNDGQcFc9sKvp7r8KF2IUNGQkC9ppliyRhz9ut4IHgO3midsoL7MVkW13Rnyn0nK+j2hnUaYnsFYfp8RBYoaPBWzItUM11SLDXHJIaVLWp75svt+q1PYt1cRmTclSu+hiswQhNvd7OitAW1+5vCwxMvrfFPkYXmroO2z5P0cdQWb+rcao8HhIvU3EYy87bY2CPwG0xDcsco4YQ3VF6FII9+6/FvDP9LO40gxhBpLLMdF4DrydwkMN0wDGgHNTnMXloi7vitAU1IT5rhupMq/LI3aPEUovhEi6jWzV0ceGBfqWVwTiuqMFUGQ5gUcwgGUbbSPUCWmfUrzDIEI9A33vePqy+X9FvvZb+8aoH3AN9t5xvcM7nV4T+2dsjujWEzOpyGzEDK3pBie6YbOpLVW7aYdpd1z32pZ1oMA+I/HoPrvC2Wem8xQMu3TIV5Xojis8Orh/S2LGfm4HI81MSz0NDW6UDX+UzaEM/zaK8Zi/f/D+oqH74cYnt8wCaT0hLRV4HnSrwxW09PTmF3joeptJUd32xhMbmKo8yxH1DP795406/XMSDBNTvuaGlYTq7qG4kpfXYX0gJ7RylV3o2sbhvtT022LXDwGYWZ9zykw6zjz0mYdJOqdwQndpnIdknH6xvsB0Ey9rP4fq8/hpsrsRLCBQhJ46Mi5f/AUkEg/0=
Steps to reproduce
Open the repro in Chrome or Safari and click the "Show more" link. Repeat in Firefox to see it working.
What is expected?
When clicking the link the element style binding should be updated from -webkit-line-clamp: 3; to -webkit-line-clamp: none; (or vice versa). This functions correctly in Firefox but not in Chrome or Safari
What is actually happening?
The initial value of the style binding is set correctly, however clicking the link doesn't update it.
System Info
No response
Any additional comments?
This appears to be something unique to the -webkit-line-clamp style. I've tried other styles such as height which work as expected, and even styles with the -webkit prefix such as -webkit-box-orient are able to be updated correctly. I've tried using camel case for the attribute name and every other solution I can think of but I can't figure out why issue this is occurring in such a specific way.

Update: setting the value to unset or initial instead of none fixed the issue!


Generate index.html (partial) from scratch

Is it possible to let favicons generate the index.html from scratch?
I want to include it as partial in jade layout template.
Currently I just specify an empty dummy HTML file -
it would be even nicer if I could just pass "true" to that option key
and favicons would generate the HTML file purely from scratch.
Edit: So favicons will populate an empty file with markup
and further runs will then update the non-empty HTML file. -
But what if the markup template in favicons itself is changed?
Will the existing, outdated markup just stay in the updated HTML file
(replace options would replace existing/known markup elements)?
Thank you and
with best regards

Added in<EMAIL_ADDRESS>Just specify a filename like html: 'index.html' and it'll write a blank file.


SW16cSTG2

closes #709
May be slightly over engineered, could be a more simple way to do it
Orders previous SWE decom and keeps only the last, orders current SWE decom and keeps only the first, then if there is no DEC in previous SWE, checks they have the same SWE reason, failing if they do not.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (15179c5) 95.27% compared to head (b128d6e) 95.27%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   95.27%   95.27%
=======================================
  Files         313      313
  Lines        7717     7717
=======================================
  Hits         7352     7352
  Misses        365      365

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


More missing null checks

Current coverage is 66.59%

Merging #12 into master will increase coverage by +0.03% as of 5bf6c5b

@@            master     #12   diff @@
======================================
  Files            4       4
  Stmts         1881    1883     +2
  Branches         0       0
  Methods          0       0
======================================
+ Hit           1252    1254     +2
  Partial          0       0
  Missed         629     629

Review entire Coverage Diff as of 5bf6c5b

Powered by Codecov. Updated on successful CI builds.

merged, thanks!


Generate helper based on existing tailwind configuration

I'd like this provide this helper for my specific tailwind configuration. Is it possible to generate what classes/values are configured for tailwind?
After a quick scan, it looks like tailwindClasses is the file that drives which classes/values to use.
Thanks!

I'd like this provide this helper for my specific tailwind configuration. Is it possible to generate what classes/values are configured for tailwind?
After a quick scan, it looks like tailwindClasses is the file that drives which classes/values to use.
Thanks!

I’m not sure I fully understand, you would like to provide your own custom tailwind values and have it reflect on the different helpers?
If yes then exactly, tailwindClasses.ts is the one providing it. Should I close the issue?

Sorry for not getting back sooner. But yes, I was looking to generate tailwindClasses.ts based on my custom tailwind.config.js. It's all good though! Thank you for getting back to me!


fixed missing "view" errors under windows

changed condition under which errors from calling the viewer are shown such that a missing executable throws an error on the user console

what does that  # weirdness comment mean?

@jan-glx this may very well be me being stupid, but I noticed that SumatraPDF sometimes returns an error code of 1 when invoked the second and subsequent times. [Thus, to clarify, this happens even if SumatraPDF is on the path, it is correctly invoked the first time, etc. etc.] With your modification, if an error occurs---even this mysterious error code 1---a forward search is not performed. This seems undesirable.
That said, if you have any wisdom to offer on SumatraPDF's error code, that would be very welcome!

forward search works fine for me with the modification;
through you are right: it does show an Error: 1 if Sumatra is already running.
The Sumatra call as well returns 1 if the pdf is removed in the meantime and Sumatra shows Error loading ...
@kjk is it the supposed behavior of Sumatra (v3.1.1 x64) to always exit with code 1 if another instance is already open?

It is indeed how it works today because we set retCode to default of 1 and then do https://github.com/sumatrapdfreader/sumatrapdf/blob/master/src/SumatraStartup.cpp#L726.
It's probably not the right behavior but it is what it is.

@jan-glx : sorry, I got confused---indeed forward search works regardless of the error. So the only issue is whether or not to report an error of 1, when we know this is not "really" an error. @kjk what do you recommend? I'd rather not show an error message unless it's necessary---no need to needlessly worry the user, no?
If so, I'd keep the existing check for errors greater than 1 if you don't mind...

If you can use DDE, a way to fix that would be to see if sumatra is running, and if yes, open the file with DDE (https://github.com/sumatrapdfreader/sumatrapdf/blob/master/src/SumatraStartup.cpp#L242).

@kjk I found that, but it requires installing a couple extra packages, of which one (Edge) is pretty large, and the other (NDde) is not actively maintained anymore. [Also, I'm not sure one can install NDde automatically on Atom.] So, it seems that using a command-line switch is the best solution. Thanks for jumping in!

I changed it now such that the "no error" error upon calling Sumatra while it is already running is not shown, but the "Command not found" error is shown. This is achieved by inspecting the stderror message, which is empty in the former case.

Looks good! I'm merging this to master, and thanks @jan-glx .


ASP.NET Core MVC - Binding to model at runtime

Hi, would anyone know if the following is possible?:
https://stackoverflow.com/questions/55765427/asp-net-core-mvc-binding-to-model-at-runtime
I managed to do this in ASP.NET with the following model binder:
public class IRuntimeBindableModelBinder : DefaultModelBinder {
    public override object BindModel(ControllerContext controllerContext, ModelBindingContext bindingContext) {
        var newBindingContext = new ModelBindingContext() {
            // In the original method you have:
            // ModelMetadata = ModelMetadataProviders.Current.GetMetadataForType(() => bindingContext.Model, typeof(TModel)),
            ModelMetadata = ModelMetadataProviders.Current.GetMetadataForType(() => bindingContext.Model, bindingContext.Model.GetType()),
            ModelName = bindingContext.ModelName,
            ModelState = bindingContext.ModelState,
            PropertyFilter = bindingContext.PropertyFilter,
            ValueProvider = bindingContext.ValueProvider
        };

        return base.BindModel(controllerContext, newBindingContext);
    }
}

However from looking at the source, it seems model binding has been rewritten in ASP.NET Core.

It looks like this is a question about how to use ASP.NET Core. While we do our best to look through all the issues filed here, to get a faster response we suggest posting your questions to StackOverflow using the asp.net-core-mvc tag.

Thanks, I've already posted it on StackOverflow and opened a bounty to get more attention but I'm yet to receive a response.
I guess posting it over the Easter holiday was not the best of ideas. However since it's more of an advanced topic I hoped someone on the team would have more of an idea.

WebApplication1.zip
I've attached a very basic sample application incase it helps.

Someone has posted a solution on the referenced StackOverflow post.


The desktop DigitalClock position option is broken

Here's my config for the Digital clock widget:
{
	#Digital clock widget
	digitalClock = {
		position = {
			#Defines the position of the digital clock
			horizontal = 1400;
			vertical = 100;
		};
		size = {
			#Defines the size of the digital clock
			width = 409;
			height = 86;
		};
		date = {
			enable = true;
			format.custom = "d.MM.yyyy";
			position = "belowTime";
		};
		settings.Appearance.showDate = true;
	};
}

Anything wrong with my config ?

Idk if that can help but both of my screens have a res of 1080p


@ngtools upgrade breaks everything, webpack: Failed to compile

Using "@ngtools/webpack": "^1.10.0", in my package.json file works fine, but when upgrading to "@ngtools/webpack": "^1.10.1", everything breaks.
I get many failures, starting like this:
Module not found: Error: Can't resolve '.../src/node_modules/@angular/common'
...
Module not found: Error: Can't resolve '.../src/node_modules/@angular/common/http'
...
Module not found: Error: Can't resolve '.../src/node_modules/@angular/core'
...
webpack: Failed to compile

By reverting back to "@ngtools/webpack": "^1.10.0", everything works fine again.
Is this a known issue?
Here's my package.json file:
{
...
  "dependencies": {
    "@angular/animations": "^5.2.6",
    "@angular/common": "^5.2.6",
    "@angular/compiler": "^5.2.6",
    "@angular/core": "^5.2.6",
    "@angular/forms": "^5.2.6",
    "@angular/http": "^5.2.6",
    "@angular/platform-browser": "^5.2.6",
    "@angular/platform-browser-dynamic": "^5.2.6",
    "@angular/router": "^5.2.0",
    "@biesbjerg/ngx-translate-extract": "^2.3.4",
    "@ngx-translate/core": "^9.1.1",
    "@ngx-translate/http-loader": "^2.0.1",
    "bootstrap": "^4.0.0",
    "classlist.js": "^1.1.20150312",
    "core-js": "^2.5.3",
    "http-server": "^0.11.1",
    "ie-shim": "^0.1.0",
    "jquery": "^3.3.1",
    "ng-recaptcha": "^3.0.3",
    "ngx-cookie-service": "^1.0.10",
    "popper.js": "^1.12.9",
    "reflect-metadata": "^0.1.12",
    "rxjs": "^5.5.6",
    "zone.js": "^0.8.20"
  },
  "devDependencies": {
    "@angular-devkit/build-optimizer": "^0.4.2",
    "@angular/cli": "~1.7.1",
    "@angular/compiler-cli": "^5.2.0",
    "@angular/language-service": "^5.2.0",
    "@compodoc/compodoc": "^1.0.7",
    "@cypress/webpack-preprocessor": "^1.1.3",
    "@ngtools/webpack": "^1.10.1",
    "@types/hammerjs": "^2.0.35",
    "@types/jasmine": "~2.8.3",
    "@types/jasmine-expect": "^3.8.1",
    "@types/jasminewd2": "~2.0.2",
    "@types/jquery": "^3.3.0",
    "@types/node": "^9.4.6",
    "@types/source-map": "^0.5.7",
    "@types/uglify-js": "^2.6.30",
    "@types/webpack": "^3.8.8",
    "add-asset-html-webpack-plugin": "^2.1.2",
    "angular2-template-loader": "^0.6.2",
    "awesome-typescript-loader": "^3.4.1",
    "codelyzer": "^4.0.1",
    "compression-webpack-plugin": "^1.1.7",
    "copy-webpack-plugin": "^4.4.1",
    "cross-env": "^5.1.3",
    "css-loader": "^0.28.9",
    "eslint": "^4.18.1",
    "eslint-config-standard": "^11.0.0",
    "eslint-plugin-angular": "^3.2.0",
    "eslint-plugin-cypress": "^2.0.1",
    "eslint-plugin-import": "^2.9.0",
    "eslint-plugin-node": "^6.0.0",
    "eslint-plugin-promise": "^3.6.0",
    "eslint-plugin-standard": "^3.0.1",
    "exports-loader": "^0.7.0",
    "expose-loader": "^0.7.4",
    "extract-text-webpack-plugin": "^3.0.2",
    "favicons-webpack-plugin": "^0.0.7",
    "file-loader": "^1.1.9",
    "find-root": "^1.1.0",
    "gh-pages": "^1.1.0",
    "html-webpack-plugin": "^2.30.1",
    "image-webpack-loader": "^4.1.0",
    "imports-loader": "^0.8.0",
    "inline-manifest-webpack-plugin": "^3.0.1",
    "istanbul-instrumenter-loader": "^3.0.0",
    "jasmine-core": "^2.99.1",
    "jasmine-expect": "^3.8.3",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~2.0.0",
    "karma-chrome-launcher": "^2.2.0",
    "karma-cli": "~1.0.1",
    "karma-coverage": "^1.1.1",
    "karma-coverage-istanbul-reporter": "^1.4.1",
    "karma-jasmine": "~1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "karma-mocha-reporter": "^2.2.5",
    "karma-remap-coverage": "^0.1.5",
    "karma-sourcemap-loader": "^0.3.7",
    "karma-webpack": "^2.0.9",
    "modernizr": "^3.5.0",
    "ngc-webpack": "^4.1.2",
    "node-sass": "^4.7.2",
    "normalize-scss": "^7.0.1",
    "npm-check": "^5.5.2",
    "npm-run-all": "^4.1.2",
    "optimize-js-plugin": "^0.0.4",
    "parse5": "^4.0.0",
    "preload-webpack-plugin": "^2.2.0",
    "raw-loader": "^0.5.1",
    "rimraf": "^2.6.2",
    "sass-loader": "^6.0.6",
    "script-ext-html-webpack-plugin": "^1.8.8",
    "sonarqube-scanner": "^2.0.2",
    "source-map-loader": "^0.2.3",
    "string-replace-loader": "^1.3.0",
    "style-loader": "^0.20.2",
    "stylelint": "^9.1.1",
    "stylelint-config-sass-guidelines": "^4.1.0",
    "stylelint-order": "^0.8.1",
    "stylelint-scss": "^2.4.0",
    "stylelint-webpack-plugin": "^0.10.3",
    "svg-url-loader": "^2.3.1",
    "to-string-loader": "^1.1.5",
    "ts-node": "^5.0.0",
    "tslib": "^1.9.0",
    "tslint": "~5.9.1",
    "tslint-eslint-rules": "^5.0.0",
    "tslint-loader": "^3.5.3",
    "tslint-sonarts": "^1.4.0",
    "typedoc": "^0.10.0",
    "typescript": "^2.7.2",
    "uglifyjs-webpack-plugin": "^1.2.0",
    "url-loader": "^0.6.2",
    "webpack": "^3.11.0",
    "webpack-dev-middleware": "^2.0.5",
    "webpack-dev-server": "^2.11.1",
    "webpack-dll-bundles-plugin": "^1.0.0-beta.5",
    "webpack-merge": "~4.1.0",
    "webpack-stats-graph": "^1.0.8"
  },
...
  "resolutions": {
    "remap-istanbul": "0.9.6"
  }
}

I tried to narrow down which NPM module it was which was causing the issue for hours yesterday...this is also related to issue 1970.  If you change your node_modules folder to be relative to baseUrl property in tsconfig.json and tsconfig.webpack.json then you should be all set.  I have validated both scenarios work...using the existing path for @angular/* in tsconfig and using @ngtools/webpack 1.10.0 and also using relative path for @angular/* using @ngtools/webpack 1.10.1
@gdi2290 I will get around to submitting a PR later this morning for this once I get back to my desk

Seeing this also :(

I think this should be fixed in PR #1975
The solution for it already posted in #1974

I managed to get this to work with @ngtools/webpack 1.10.2 by changing
"paths": {
      "@angular/*": ["node_modules/@angular/*"]
    },

to
"paths": {
      "@angular/*": ["../node_modules/@angular/*"]
    },

in tscongig.webpack.json

Guys, I have the exact same issue, and I guess there is something wrong with the version of node (v.8x) and npm that I was using for Ubuntu 18.04.
Here is what I did that solve the problem:

Remove the folder: rm -r node_modules
If you don't have curl: -> sudo apt install curl
Add the new version to the library: -> curl -sL https://deb.nodesource.com/setup_10.x | sudo bash -
sudo apt install nodejs  /*This will install npm as well
npm install /* that is it

I run ng serve again, and all the problems are gone.
I still have the @ngtools/webpack in my package.json or package-lock.json.
Above is everything I did for the fix.
First time posting, hope this help~!


[AMBARI-23043] Table or view not found error' with livy/livy2 interpreter on upgraded cluster to Fenton-M30

What changes were proposed in this pull request?
I've added chnages to reset_interpreter_settings() method. After my cahnges during reset interpreter.json config, we also will add new properties/groups/options. Earlier we added only new setting_key section.
How was this patch tested?
On upgraded (RU/EU) cluster added my changes and restart zeppelin. Changes were successfully added and zeppelin start work fine. Tested interpreters to check new chenges in interpreter.json.
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/733/
Test FAILed.
Test FAILured.


Update colab_wnet_training.ipynb

I added some changes to the documentation.
I downloaded and run the notebook in colab, didn't use wand, and everything run well.
I got the weights in my results folder as expected.

@Timokleia Looks great ! Let me know when it's ready for review

hey @C-Achard it is ready!


pull request for e2e test at 12/25/2016 21:26:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Handle empty masks for Tpeak

write_tmax fails when the mask is empty in more recent versions of numpy (as np.min/max now raises an error when passed an empty array).

This fixed things for my local test. I strongly suspect this can be merged with no unintended failures resulting.


Bolt brief alerts while going offroad

possibly due to a delay in CAN ignition's falling edge

pandaStates published the CAN ignition change too late. The actual CAN ignition source falls before ACC faulted rises:


Measures to debug Bazel's Xcode ingestion flake

Fork Bazel's Xcode autoconfigure for usability improvements and debugging
Fork and improve Bazel's xcode configuration code. This is not a measure to fix
the problem, but to debug it and unblock CI. Github actions is incrediblly
flaky but Bazel should deal with a flaky host better and this is a weak point
(https://github.com/bazel-ios/rules_ios/issues/361)
Bazel puts this error in the build file which is a problem on the CI because it
swallows the error and it requires a user to clean --expunge. Bazel requires
the user to expunge because it thinks the repository was successfully written.
Probably a better pattern is to fail, but that won't shed light on the problem.
This is not just broken for CI but local developers. The plan is to use
rules_ios CI to reproduce this and gather more information then propose a fix
when we know more info.
Ammedum: I have confirmed with this PR, it's related to host over-subscribing
on GitHub Actions. This at least improves it because the user doesn't have to
expunge. PR to fix that to follow.

Will circle back on this next week, proposing to Bazel:
https://github.com/bazelbuild/bazel/pull/14328


WAWLA Enchantment Descriptions?

WAWLA adds descriptions for various enchantments. Would it be possible to add support for such a thing? If you give me a run down of what each enchantment does, I could add support into the mod for you even.
Example (taken from another mod):
https://user-images.githubusercontent.com/5614902/33523744-f60bcdc0-d7db-11e7-8c59-ae130b990d50.png

Resolving this myself, should've read the description.


Include the missing S3 policy in AWS getting started guide

File: themes/default/content/docs/clouds/aws/get-started/deploy-changes.md
Hello,
just wanted to point out that the web address pointing to the S3 hosted web service is returning 403 on a freshly created aws account when following the getting started guide.
After some digging i found the missing policy in the aws-ts-native template, and confirmed the example works as expected after appending it to the source file.
// Set the access policy for the bucket so all objects are readable
const bucketPolicy = new aws.s3.BucketPolicy("bucketPolicy", {
    bucket: bucket.id, // refer to the bucket created earlier
    policy: pulumi.jsonStringify({
        Version: "2012-10-17",
        Statement: [{
            Effect: "Allow",
            Principal: "*",
            Action: [
                "s3:GetObject",
            ],
            Resource: [
                pulumi.interpolate `${bucket.arn}/*`, // limit the policy to the files in this bucket
            ],
        }],
    }),
});

My suggestion would be to include this policy or (a more limited version only targeting the index.html file) and drop the vague warning message, to avoid first time users having unexpected errors.

Hey @a-sync thank you for raising this! We will work on getting this updated.


Limit IDM configuration list/exports for IDC

The IDM command for IDC lists too many configuration endpoints that may not be accessible to the user. The same goes for the export command.

We have been keeping up with this as good as possible. Closing.


Improve readme related to #138

We improving readme this PR based on #138 request.

Thank you :+1: !!


Drivers

You should add drivers.iso for the most common OS inside the App Folder such a toolbox in other emulation apps.
It can help a lot.
temporary the SPICE driver that in Windows 9x worked for me.
Thanks.

SPICE drivers seem to be a little too big to include every OS, what if it downloaded your respective OS's SPICE drivers on a per-VM basis?

Agreed, it's too big to distribute for all different OS. Once I get to writing a user guide, I will include the links.


deb uninstaller fails due to wrong line endings

At least on Windows (haven't tested the others), the .deb package's .prerm script fails due to incorrect line endings.
error message
~$ sudo apt-get remove hebi-robotics-scope
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be REMOVED:
  hebi-robotics-scope
0 upgraded, 0 newly installed, 1 to remove and 674 not upgraded.
After this operation, 107 MB disk space will be freed.
Do you want to continue? [Y/n] y
(Reading database ... 150842 files and directories currently installed.)
Removing hebi-robotics-scope (1.7.5-3) ...
/var/lib/dpkg/info/hebi-robotics-scope.prerm: line 9: syntax error: unexpected end of file
dpkg: error processing package hebi-robotics-scope (--remove):
 installed hebi-robotics-scope package pre-removal script subprocess returned error exit status 2
dpkg: too many errors, stopping
Errors were encountered while processing:
 hebi-robotics-scope
Processing was halted because there were too many errors.

E: Sub-process /usr/bin/dpkg returned an error code (1)

contents of the .prerm script
#!/bin/bash
set -e
if [ -d /run/systemd/system ] && [[ "" != "" ]]; then
    # Shut down any installed services before we uninstall or upgrade to avoid the files changing underneath them.
    # Whilst some programs can handle this, others cannot because they open and close files during runtime and expect
    # them to be consistent. We default to the safest approach.
    systemctl stop  2>/dev/null || true
fi^M

after removing the ^M it works.

confirmed that creating the package on macOS does not suffer from this issue

Thanks for the bug report! The fix for this will ship in the next release. We've also audited places where similar patterns were in use and changed the underlying utility code to not depend on the system line separator, as it's not the right thing to do.


Cannot set breakpoint to files in symbolic linked directory

Expected Behavior
Hit breakpoints in files.
Actual Behavior

NTVS Version: 1.4.10918.1
Visual Studio Version: 15.4.0
Node.js Version: 6.11.0

Steps to Reproduce

Created a folder 'A'
Create a js file 'index.js' in 'A'
Create a directory 'LinkA' linked to 'A'
Set a breakpoint in 'index.js' located in 'LinkA' and start debugging

Did you happen to try this with Node 8, does that work?

I have tried nodejs 8.7.0, the same.

Thanks for trying.
What exactly do you mean by "linked to 'A'"?

Execute in cmd 'mklink LinkA /D A'

We're no longer making changes to the node 6 debugger, if this reproduces in Node 8 please create a feedback item in VS, so the righ team can take a look.


com.vmware.api.vcenter.vm.too_many_matches when looking at all vms on a cluster

[X] I am using the latest SDK version
[X] This API is compatible with my vCenter version (You can get the info from 'vcenter_version' in each sample)
[X] I have searched existing issues and Troubleshooting wiki

Environment

sdk package version:
vapi-client-bindings 1.5.0
vapi-common-client 2.10.2
vapi-runtime 2.10.2
vmc-app-python-sdk <IP_ADDRESS>.2.11053635
vmc-client-bindings 1.3.1

python version:
Python 3.6.4

vSphere version:
Version <IP_ADDRESS>00 Build 9451637

Operating System/Shell (used to run SDK-based apps):
Windows 7

Steps or code snippet to reproduce
cluster_names = {'domain-c28004'}

vms_list = vsphere_client.vcenter.VM.list(VM.FilterSpec(clusters=cluster_names))

Actual behavior
Looping through all the clusters to find the vm's on that cluster as such:
And I am getting the:
com.vmware.vapi.std.errors_client.UnableToAllocateResource: {messages : [LocalizableMessage(id='com.vmware.api.vcenter.vm.too_many_matches', default_message='Too many virtual machines. Add more filter criteria to reduce the number.', args=[])], data : None}
Doesn't happen in our lab either, but there's only a handful of vm's there vs an enterprise worth in the production vm environment. The cluster this seems to choke on has 152 virtual machines on it.
Expected behavior
Returns list of all vm's on requested cluster regardless of count.

@klainn list() returns maximum 1000 objects as stated in the API doc: https://vmware.github.io/vsphere-automation-sdk-python/vsphere/6.7.1/com.vmware.html#com.vmware.vcenter_client.VM.list. The filter spec takes a list of cluster IDs, not names. You can only use vm names in the VM list() filter spec. Here is an example how to get cluster ID: https://github.com/vmware/vsphere-automation-sdk-python/blob/master/samples/vsphere/vcenter/helper/cluster_helper.py. Can you confirm if you have only 152 VMs in your vCenter? If you have more than 1000 vms, please use more filters to reduce the scope.

But that's the problem. The project requirement is that if a VM exists in the vcenter instance I'm working with, I need to be able to see it regardless of any filter conditions. The only filter condition the business is interested in is exists==true.
Do you have a suggestion on how to use filters but still get every virtual machine?

I will discuss this use case with the team.
Meanwhile, are all vms in the same container (cluster/resource_pool/folder/datastore/folder)? Do you organize them in any ways? If so, then probably you can iterate the container and then list vms in each container?

They are sorted by Datacenter, then folders. The one datacenter I'm struggling with has 7300 vms on it and I can't find a filter that searches something that returns 1000 or fewer. In this particular datacenter, one folder has 5100 vms alone. Multiple clusters in that folder have more than 1000 vms, etc.
A esx host shouldn't have more than 1000 machines on it. That seems highly unlikely. I see there's a Hosts.list() function but I'm not immediately seeing a way to list all the vms on a esx host. Seems like it should be possible though.

Ok, so maybe not.
My end goal is to produce a simple list that will update a table that has 2 columns, cluster_name, virtual_machine_name.
I can get all the vms by querying all the hosts. But I'm struggling to get the cluster the vm is on using your code from above, I still have to search clusters with more than 1000 machines and I get the original error.
This is the code I'm using. It feels like this should be more easily done. This code produces the too many vm's error from above.
import requests
import urllib3
from vmware.vapi.vsphere.client import create_vsphere_client
from com.vmware.vcenter_client import VM
import sys

def createConnection():
    session = requests.session()
    session.verify = False
    urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)

    vsphere_client = create_vsphere_client(
        server='<redacted>',
        username='<redacted>',
        password='<redacted>',
        session=session
    )

    return vsphere_client

def getVMSonHost():
    vsphere_client = createConnection()
    # Get all Hosts
    host_list = []
    all_hosts = vsphere_client.vcenter.Host.list()
    for hst in all_hosts:
        host_list.append(hst.host)

    # Get all VMs on Host
    vm_list = []
    for esx_host in host_list:
        print('Looking in: {}'.format(esx_host))
        vms = vsphere_client.vcenter.VM.list(VM.FilterSpec(hosts={esx_host}))
        vm_list.append([vm.name for vm in vms])

    # Try to get cluster of VM
    vm_cluster_list = []
    all_clusters = vsphere_client.vcenter.Cluster.list()

    for vm_name in vm_list:
        for cluster in all_clusters:
            vms = vsphere_client.vcenter.VM.list(VM.FilterSpec(clusters={cluster.cluster}))
            if vm_name in [vm.name for vm in vms]:
                print('{} on {}'.format(vm_name, cluster.name))
                vm_cluster_list.extend([cluster.name, vm_name])
                break
    return vm_cluster_list

giant_vm_list = getVMSonHost()
print(giant_vm_list)

The Error:

Traceback (most recent call last):
  File "C:/Users/<me>/PycharmProjects/vmware_api_test/filter_vms_by_esx_host.py", line 51, in <module>
    giant_vm_list = getVMSonHost()
  File "C:/Users/<me>/PycharmProjects/vmware_api_test/filter_vms_by_esx_host.py", line 43, in getVMSonHost
    vms = vsphere_client.vcenter.VM.list(VM.FilterSpec(clusters={cluster.cluster}))
  File "C:\Users\<me>\PycharmProjects\vmware_api_test\venv\lib\site-packages\com\vmware\vcenter_client.py", line 3178, in list
    'filter': filter,
  File "C:\Users\<me>\PycharmProjects\vmware_api_test\venv\lib\site-packages\vmware\vapi\bindings\stub.py", line 317, in _invoke
    return self._api_interface.native_invoke(ctx, _method_name, kwargs)
  File "C:\Users\<me>\PycharmProjects\vmware_api_test\venv\lib\site-packages\vmware\vapi\bindings\stub.py", line 275, in native_invoke
    self._rest_converter_mode)
com.vmware.vapi.std.errors_client.UnableToAllocateResource: {messages : [LocalizableMessage(id='com.vmware.api.vcenter.vm.too_many_matches', default_message='Too many virtual machines. Add more filter criteria to reduce the number.', args=[])], data : None}

Has to be a better way to get this than the path I'm going down.

How about iterate clusters and then hosts inside each cluster?
import requests
import urllib3
from vmware.vapi.vsphere.client import create_vsphere_client
from com.vmware.vcenter_client import VM, Host
import sys

def createConnection():
    session = requests.session()
    session.verify = False
    urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)

    vsphere_client = create_vsphere_client(
        server='',
        username='',
        password='',
        session=session
    )

    return vsphere_client

def getVMSonHost():
    vsphere_client = createConnection()

    vm_cluster_list = []
    clusters = vsphere_client.vcenter.Cluster.list()
    for cluster_summary in clusters:
        hosts = vsphere_client.vcenter.Host.list(Host.FilterSpec(clusters={cluster_summary.cluster}))
        for host_summary in hosts:
            vms = vsphere_client.vcenter.VM.list(VM.FilterSpec(hosts={host_summary.host}))
            for vm in vms:
                vm_cluster_list.append([cluster_summary.name, vm.name])

    return vm_cluster_list

giant_vm_list = getVMSonHost()
from pprint import pprint
pprint(giant_vm_list)

Yeah that seems solid. The result count is a little different but maybe not a big deal. Very cool.


It's a weird error when initializing AsyncWebServer if #include "HomeSpan.h"

Here is my code
#include <ESPAsyncWebServer.h>
#include "HomeSpan.h"

AsyncWebServer server(80); // Or any other port

void setup() {}
void loop() {}

After uploading it successfully to my ESP32 C3 Super Mini, I got this error
00:07:28.439 -> Build:Feb  7 2021
00:07:28.439 -> rst:0x3 (RTC_SW_SYS_RST),boot:0xf (SPI_FAST_FLASH_BOOT)
00:07:28.439 -> Saved PC:0x403cf94c
00:07:28.439 -> SPIWP:0xee
00:07:28.439 -> mode:DIO, clock div:1
00:07:28.439 -> load:0x3fcd5810,len:0x438
00:07:28.439 -> load:0x403cc710,len:0x90c
00:07:28.439 -> load:0x403ce710,len:0x2624
00:07:28.439 -> entry 0x403cc710

Sorry, I'm unfamiliar with the details of the ESPAsyncWebServer and its use is not specifically supported in HomeSpan.  The Async server may or may not work --- I believe others may have used it successfully with HomeSpan, but I've not tried.
Though I'm not planning to adding support for Async compatibility (to the extent it can be done), HomeSpan is nevertheless fully compatible with the Arduino-ESP32 basic WebServer library --- there are some examples in the HomeSpan Tutorials that demonstrate how this works.

Thank you. I will check the examples 🙏


popup and labeled buttons

button label left angle icon is on top of the popup.

@amirmasoud, Please provide a test case as per our contribution guidelines, you may fork this jsfiddle
Closing this till you provide a test case.

Couldn’t reproduce as of 2.2.9.


Default Backup Jobs Are Not Marked As Completed on SQL Server 2019 on Linux

Description of the issue
Following a fresh system reboot, the first backup operation initiated by the SQL Agent succeeds.  All subsequent runs complete all parts of the backup operation, but do not return upon completion, making the SQL Agent believe the backup operation is running endlessly.
This issue can be seen on the SQL Agent's sqlagent.out logfile.  Affected Jobs start, but are never marked as completed via a 184 message, such as example below.
2021-01-05 15:52:41 - ? [184] Job completion for DatabaseBackup - USER_DATABASES - LOG is being logged to sysjobhistory
The only workaround I've found is to manually stop the SQL Agent Job, after which the job is marked as completed.
As only one instance of a job can be running at a time, this blocks backup jobs as they are 'already running'.
All other operations included in the Maintenance Solution do not suffer from this issue.
SQL Server version and edition
Microsoft SQL Server 2019 (RTM-CU8) (KB4577194) - 15.0.4073.23 (X64)   Sep 23 2020 16:03:08   Copyright (C) 2019 Microsoft Corporation  Standard Edition (64-bit) on Linux (Oracle Linux Server 7.9)
Version of the script

SchemaName
ObjectName
Version
Checksum

dbo
CommandExecute
2020-12-31 18:58:56
415773187

dbo
DatabaseBackup
2020-12-31 18:58:56
763543791

dbo
DatabaseIntegrityCheck
2020-12-31 18:58:56
-1311663888

dbo
IndexOptimize
2020-12-31 18:58:56
-1087133113

What command are you executing?
Any of the default backup Jobs included in the MaintenanceSolution.sql script.

Further research shows this was caused by a low CPU core count.  Increasing the number of CPU cores available to SQL Server resolved the issue.

Further research shows this was caused by a low CPU core count.  Increasing the number of CPU cores available to SQL Server resolved the issue.


buildspec.yml env variables are not available locally

In the current solution it is planned to define environment variables in buildspec.yml.
Those variables are not available in the makefile targets when you execute them locally.
It should be possible to use the same makefile targets in codebuild and locally.

I'm not sure I understand the issue here, could you describe the issue with and example ? Currently the makefile targets can be used locally.

the local makefile is working now (at least in  project infra-geoadmin-tests since the merge of https://github.com/geoadmin/infra-geoadmin-tests/pull/2).
But we have to define the same env variables twice:

Makefile https://github.com/geoadmin/infra-geoadmin-tests/blob/develop/Makefile#L16
buildspec.yml https://github.com/geoadmin/infra-geoadmin-tests/blob/develop/buildspec.yml#L5

I think this should not be addressed here because this is just a service template and it doesn't have currently any variable. I suggest to have this directly resolved inside the infra-geoadmin-test repo.
In my opinion the service repository should not have any environment configuration values, this should be part of the end-to-end testing repository and deployment repository.
So if you are I'll close this issue ?

there are env variables in this template:
https://github.com/geoadmin/template-service-flask/blob/master/buildspec.yml#L5
and the same variable are specified a second time in the Makefile:
https://github.com/geoadmin/template-service-flask/blob/master/Makefile#L12
if thats ok to set them two times, yes we can close this issue.


Readme for Stripe

Hello
When you prepare documentations how use stripe and firebase?
Thanks

Meant to grab this the other day, will get it today


Automate cargo-generate updates

See https://discord.com/channels/691052431525675048/1258521739395203174/1271602001502928937 for more context.

Duplicate of https://github.com/TheBevyFlock/bevy_quickstart/issues/129

Whoops, my bad!


Library should bundle katex as a full dependency

This may have already been rectified in a previous commit, however it needs to be verified

This works as expected


TrueLayer Signing PHP

Note: Some more scenarios to test: https://github.com/TrueLayer/truelayer-signing/pull/16

Note: Some more scenarios to test: #16

Cheers, will look and add what needs adding 🙏🏻

Note: Some more scenarios to test: #16

Done both.

fyi https://github.com/TrueLayer/truelayer-signing/issues/23#issuecomment-984552744

fyi new scenario: https://github.com/TrueLayer/truelayer-signing/pull/29


[BEAM-939] Use the credentials from GcpOptions instead of relying on BigtableOptions

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

This allows for us to create a version of the service depending on the PipelineOptions passed in at this time. This uses a function which takes in the contextual PipelineOptions and creates a service from it allowing us to not serialize the Credentials within the BigtableOptions.

R: @dhalperi @tgroh

LGTM. I'm working on https://issues.apache.org/jira/browse/BEAM-950, after which I'm going to roll most of this back and do the work in setup again.


[AutoPR] containerservice/resource-manager

Created to accumulate context: containerservice/resource-manager

(message created by the CI based on PR content)

Codecov Report

Merging #4760 into master will decrease coverage by 4.34%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #4760      +/-   ##
==========================================
- Coverage   53.73%   49.39%   -4.35%
==========================================
  Files       10328     6417    -3911
  Lines      217144   180633   -36511
==========================================
- Hits       116686    89215   -27471
+ Misses     100458    91418    -9040

Impacted Files
Coverage Δ

...shift_managed_cluster_aad_identity_provider_py3.py
45.45% <50%> (-4.55%)
:arrow_down:

...afactory/azure/mgmt/datafactory/models/__init__.py
50.67% <0%> (-49.33%)
:arrow_down:

...ights/azure/applicationinsights/models/__init__.py
51% <0%> (-49%)
:arrow_down:

...services/language/textanalytics/models/__init__.py
51.16% <0%> (-48.84%)
:arrow_down:

...iveservices/search/entitysearch/models/__init__.py
51.25% <0%> (-48.75%)
:arrow_down:

azure-eventgrid/azure/eventgrid/models/__init__.py
51.25% <0%> (-48.75%)
:arrow_down:

...ration/azure/mgmt/datamigration/models/__init__.py
51.27% <0%> (-48.73%)
:arrow_down:

...ure/mgmt/recoveryservicesbackup/models/__init__.py
51.46% <0%> (-48.54%)
:arrow_down:

...ce/azure/mgmt/containerinstance/models/__init__.py
51.8% <0%> (-48.2%)
:arrow_down:

...tiveservices/search/videosearch/models/__init__.py
52.08% <0%> (-47.92%)
:arrow_down:

... and 4438 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 095af34...444d796. Read the comment docs.

@lmazuel can you help us on this, What are the next steps ? Thanks

@lmazuel ping

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/containerservice/resource-manager/readme.md

Working on generating https://github.com/azure/azure-rest-api-specs/blob/master/specification/containerservice/resource-manager/readme.md for you!!!

Nothing to rebuild, this PR is up to date


CDPS-738: Make update alert use lockTimeout

The original PR also had a part which showed a different error message when it received a 423, do you need to include it?

The original PR also had a part which showed a different error message when it received a 423, do you need to include it?

Thanks Steve, yes we should include something similar.


nextflow loading uses removed yaml.safe_load()

When attempting to run sbpack_nf, I ran into an error when the the yaml.safe_load() function was invoked, but this function has been deprecated in ruamel.yaml since 0.15. By contrast, the ruamel.yaml module specified in requirements.txt is ruamel.yaml >= 0.16
https://github.com/rabix/sbpack/blob/a016df2eed21ba419ec3ef3be478ee48bd279087/sbpack/noncwl/nextflow.py#L115
https://github.com/rabix/sbpack/blob/a016df2eed21ba419ec3ef3be478ee48bd279087/sbpack/noncwl/nextflow.py#L189

Full error output:
Uploading file /Users/josh/Projects/scpca-nf_20240408-105600.zip, please wait for the upload to complete.
Upload complete!
Local file /Users/josh/Projects/scpca-nf_20240408-105600.zip deleted.
Traceback (most recent call last):
  File "/Users/josh/Projects/scpca-cavatica/.pixi/envs/default/bin/sbpack_nf", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/josh/Projects/scpca-cavatica/.pixi/envs/default/lib/python3.11/site-packages/sbpack/noncwl/nextflow.py", line 272, in main
    sb_app = nf_wrapper.generate_sb_app(sb_entrypoint=args.entrypoint)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/josh/Projects/scpca-cavatica/.pixi/envs/default/lib/python3.11/site-packages/sbpack/noncwl/nextflow.py", line 174, in generate_sb_app
    self.sb_wrapper['inputs'] = self.generate_sb_inputs()
                                ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/josh/Projects/scpca-cavatica/.pixi/envs/default/lib/python3.11/site-packages/sbpack/noncwl/nextflow.py", line 135, in generate_sb_inputs
    nf_schema = ruamel.yaml.safe_load(f)
                ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/josh/Projects/scpca-cavatica/.pixi/envs/default/lib/python3.11/site-packages/ruamel/yaml/main.py", line 1105, in safe_load
    error_deprecation('safe_load', 'load', arg="typ='safe', pure=True")
  File "/Users/josh/Projects/scpca-cavatica/.pixi/envs/default/lib/python3.11/site-packages/ruamel/yaml/main.py", line 1039, in error_deprecation
    raise AttributeError(s, name=None)
AttributeError:
"safe_load()" has been removed, use

  yaml = YAML(typ='safe', pure=True)
  yaml.load(...)

instead of file "/Users/josh/Projects/scpca-cavatica/.pixi/envs/default/lib/python3.11/site-packages/sbpack/noncwl/nextflow.py", line 135

            nf_schema = ruamel.yaml.safe_load(f)

I realize the pypi version is way behind... installing the release candidate now.


Added isReplaying boolean on StreamingEventProcessor

Added isReplaying method on StreamingEventProcessor.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Sonar complains because the TrackingEventProcessor test resides in a different module. Hence, the coverage point will be ignored.


feat: 🎸 Use genesis hash to generate next Asset ID

Description
Update the logic for generating next Asset ID for an account (to include genesis hash as well)
Breaking Changes
NA
JIRA Link
DA-1332
Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward

:tada: This PR is included in version 26.0.0-alpha.5 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 26.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


bump versions to pre 2.13 versions

i'v started moving to 2.13.1
in this PR:

bump up versions to "pre 2.13" state (as for 2.12.10)
do basic abstraction over Logger and provide some dumb implementations
throw out slogging

problems moving to 2.13.1

bunch of errors while trying to compile fo scalajs

i need some help with this process

Would you mind submit all formatting changes as a separate PR & base code changes on top of the formatting branch? So it would be much easier to review any actual changes related to 2.13

Done in #94. Closing


Creating an Intermediate Language?

Are you planning to make an intermediate language, like LLVM, or just direct translation between scratch-js, Scratch 2, and Scratch 3?

Internally, that's exactly what's going on! The Project class is that intermediate format, and the stuff in /io is used to convert between external formats and the intermediate scratch-js version.


Add asynchronous status checks for DBProxy

Description of changes:
The DBProxy APIs put the resource into creating state for ~10 minutes before becoming available, as well as deleting before it is gone. This PR copies the systems we use for DBInstance, which has the same properties, into custom hooks for DBProxy. It also updates the tests for DBProxy to use proper fixturing and to use a autogenerated resource name suffix (so tests don't collide).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm

/retest

Merging as is since test failures are not relevant (#133 is testing in parallel)


Issue 7 Resolved

Issue: 7
Short description of what this resolves:
Changes proposed in this pull request and/or Screenshots of changes:

Your forked repo was not up to date with the main repo, kindly pull the changes to your local machine first and then add the changes you have made  and then put another PR to avoid merge conflicts.


navigate fields with tab/backtab

Fixes #15.

I am somewhat divided over this one. But I already assumed arrow keys had nothing to do in passwords so...


Crash of ESC key pressed

I've successfully built from latest release on Fedora 23 x64.
It starts OK but when I press ESC key, simply whole app crash.
The only error I receive is:
 Failed to tell parent about crash.

At least 5 tickets describe this issue - closing.


[INF] Enable torch compile for inference

Hi @oelayan7 do you have sample code using this feature?  Or does it turn on by default?  I wonder if I can try it with CPU accelerator.

Hi @delock,
No, it isn't run by default. The function .compile() needs to be called.
This changed was adopted in a similar way that was done in zero and for training, which used CompileWrapper that was removed in https://github.com/microsoft/DeepSpeed/pull/5581 and a new approach was introduced.
This change was adopted from the all old PRs before.

@tjruwase the failing tests are because an HTTP failure with HF.
Can you please retrigger? (couldn't find a way to do that)

@tjruwase @tohtana @umchand Can anyone trigger the CI please?

@loadams Thanks!
I fixed the formatting issue, can you please retrigger?

@loadams I don't think the failures are related.

@loadams I don't think the failures are related.

Correct, working on getting this merged despite some hiccups in our tests not related to your PR.

@loadams I don't think the failures are related.

@oelayan7 Correct, working on getting this merged despite some hiccups in our tests not related to your PR.

@oelayan7 - we believe we should be merging all the CI fixes today and will get this merged shortly after that.


Moon phase emoji when clear at night with one-line output format

Similar to #52 but for the one-line output format - would it be possible to show the moon phase emoji from the m flag as the c output emoji, instead of ☀, when the weather is clear between dusk and dawn?

It is a good idea.
What about this emoji: ⛅
What should be shown in this case instead?
Or should we leave it as it is?

Thanks! Yeah it's a shame that there isn't a moon behind cloud emoji yet.
It probably depends on if it's important to keep the output to just one emoji. If so, I'd probably support keeping ⛅ for now and hope that a new emoji is eventually added. Otherwise an alternative could be just having the moon phase followed by a cloud, e.g 🌗☁ . I think that would be my preference of the two but it does go a bit against the grain of the other single emoji outputs.

I like the two emojis approach better, because it allows you to pass the information not only about the weather condition, but also about the moon phase.
The last question: when it should switch into the night mode?
Between dusk-dawn or between sunset-sunrise?

I can see arguments for both but now I'm leaning towards sunset-sunrise, since between sunset-dusk and dawn-sunrise you would never be able to see the sun but could sometimes see the moon depending on its phase.

Actually, in some cases even sunrise alone may take 43 hours, but usually it is not so long. Ok, so you want to go more aggressive, and take the longer interval.
Ok, it will be n for this condition:
n    Weather condition, with Moonphase instead of Sun for sunny nights

Fee free to add it, and send me a PR. It is here:
https://github.com/chubin/wttr.in/blob/master/lib/view/line.py#L250

Sorry I haven't learned how to write Python yet so don't think I'll be able to actually submit the PR myself. Hopefully I'll learn soon and come back to it if this is still open!


Related Project Monikers

Description
Right now the potential structure of the NodeJS+JSF Governance Structure (Stage 0) describes three entities for Projects that are supported by, or related to this organization:

Incubator
Sandbox
Commons.js

Incubator
"An official process for a project to become a project and get representation in CPC. Mentorship from CPC + CommComm." – Entities that are 'on their way' to becoming a top-level project.
Sandbox
"A place for projects to live that want to benefit from being in the foundation but do not intend to graduate to a Top Level Project." – A 'neighboring' project that supports and is supported by the foundation.
Commons.js
"Resources and initiatives available to non-foundation projects. CI, travel scholarships, mentorship, etc." – Initiatives and/or projects that revolve around and affect/are affected by the foundation.
Problem
During a recent Joint Foundation Bootstrap Meeting, the consensus was against these names as representative monikers for those entities, and we need to find ones that represent what they are well.
Resolution
Let's come up with great names for these entities! 🙌

We should also add "Graduate" or "Top Level Project" as monikers to iterate on - I've seen those used interchangeably in various places!

We may also want to include "Constellation Project" since this is something that does seem to be coming up, though I'd want other's +1s on adding it before it is added 👍

Just throwing out ideas but maybe:

Basic Member Project
Incubation Member Project
Full Member Project
Constellation Member Project

To replace sandbox, incubating, top level and constellation.

One reason we need to define "Constellation Member Project"  I was interpreting it as a major project like Kubernetes/Node.js around which other projects form a Constellation.  In that context the Constellation projects are those that might get their own board set etc.

There's something about the current monikers that are slightly confusing to me, and I wonder if this disambiguation makes sense:
Commons.js is a proposed program that provides foundation resources such as a travel grant etc. or  to any open source project, via some process developed and overseen by a $foundation committee. The exact services available are dependent on the budget and discretion of that committee.
Sandbox, Incubation, Top Level, and Constellation are proposed designations given to projects that have been accepted into the foundation based on their lifecycle and some TBD metrics.
If that's the correct (read: everyone else's) understanding, I propose we focus this issue on the designations and table discussion of the programs until we're much farther along as the program doesn't have direct implications for the bylaws.

Closing this as we have landed the majority of these changes and have another issue to dig into the commons


[feature request] store checksum for files

Hi,
Have you thought about storing a checksum for files somewhere to make it possible to detect corruption?
I'm thinking about changing my file format for firmware binaries to include a checksum, but I'm wondering whether it wouldn't be better to do at file system level (mostly because my firmware files are currently just a ROM dump and I like to keep things simple :wink:)

If you want a checksum then store it outside of file-system, either in the file or somewhere else.

I agree. Adding crc as a fs feature is very specific, and would also force each write to reread the whole file each time to be robust. Also, one crc (e.g. 16bit ccitt) might not suit some other, so I feel it best leaving this to the user.


Transform NREL ATB

Overview
Closes #3507.
What problem does this address?
(almost) adds normalized NREL ATB tables.
What did you change?
tracked in the issue tasklist
Remaining Questions/Next steps

[x] table name help plz! the smallest table rn is just three different rates so it feels easy to name it something about rates. but the other two have much more/varied info in them so I named them based on the additional unique PK... but that doesn't feel right
[x] is unstacker_of_tables okay (both the name and the thing it does)? it feels hacky to have it just be a place that compiles the unstacking params for all of the tables but it felt very easy to use
[x] I haven't yet made these assets into an asset factory bc i assume there is going to be unique cleaning to be done even though rn they are all

Testing
How did you make sure this worked? How can a reviewer verify this?
# To-do list
- [ ] If updating analyses or data processing functions: make sure to update or write data validation tests (e.g.,  `test_minmax_rows()`)
- [x] Update the [release notes](../docs/release_notes.rst): reference the PR and related issues.
- [x] Review the PR yourself and call out any questions or issues you have
- [x] Ensure docs build, unit & integration tests, and test coverage pass locally with `make pytest-coverage` (otherwise the merge queue may reject your PR)
- [ ] For minor ETL changes or data additions, once `make pytest-coverage` passes, make sure you have a fresh full PUDL DB downloaded locally, materialize new/changed assets and all their downstream assets and [run relevant data validation tests](https://catalystcoop-pudl.readthedocs.io/en/latest/dev/testing.html#data-validation) using `pytest` and `--live-dbs`.
- [ ] For significant ETL, data coverage or analysis changes, once `make pytest-coverage` passes, ensure the full ETL runs locally and [run data validation tests](https://catalystcoop-pudl.readthedocs.io/en/latest/dev/testing.html#data-validation) using `make pytest-validate` (a ~10 hour run). If you can't run this locally, run the `build-deploy-pudl` GitHub Action (or ask someone with permissions to). Then, check the logs on the `#pudl-deployments` Slack channel or `gs://builds.catalyst.coop`.

okay i think this is ready for a re-review. my remaining wonderings are:

[ ] are the tables names okay? the tables ended up being pretty clean/clear about what type of info is in what type of table
[ ] should i squish the additional parameter into the non-additional param? see comment... i think yes.
[ ] i copied and pasted a lot of the field descriptions from nrel's extensive docs. i think they are descriptive and reasonable


[Snyk] Upgrade react-intersection-observer from 9.5.3 to 9.8.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade react-intersection-observer from 9.5.3 to 9.8.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 5 versions ahead of your current version.
The recommended version was released 24 days ago, on 2024-02-22.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.79%. Comparing base (c727b3f) to head (42c5f93).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   66.79%   66.79%
=======================================
  Files          43       43
  Lines         521      521
  Branches       76       76
=======================================
  Hits          348      348
  Misses        168      168
  Partials        5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[csrng] Add SVAs to check for unexpected pushes to the genbits FIFO

The ready signal of the genbits FIFO is not considered when pushing the FIFO which may raise concerns. However, by inspecting the command stage FSM, one can see that the FSM only ever triggers the generation of more bits if the genbits FIFO is empty.
This commit documents these findings in the RTL and adds some SVAs to check that 1) the FSM indeed only ever enters the stage where it requests more bits after finding an empty FIFO and 2) that the genbits FIFO is only ever pushed in the in the FSM states where this can be expected.
This resolves lowRISC/OpenTitan#16563.

Thanks for the feedback @andreaskurth ! I've implemented your suggestion and I am merging this now. CI ran through successfully before.


generating spectra with 'point' region type results in negative x_wid value

Using

current XGA version from git repository;
SAS version 21.0.0 which could be the cause of this error in which case this may be a feature request for compatibility with future SAS versions

For context, I was following the tutorial notebook for spectroscopy.
demo_src = PointSource(182.2416, 45.67667, 0.9254, name='PG1206+459')

demo_src = evselect_spectrum(demo_src, 'point')

demo_src = power_law(demo_src, 'point', redshifted=True)

for sp in demo_src.get_spectra('point'):
    sp.view()

This code was failing to plot the errorbars when calling the view methods due to x_err being negative.
Upon investigating, the power_law fitting was also silently failing.
Manually printing the x_wid array which is used as the error in the view method showed the culprit to be the last value in the array for all the spectra;
This is the printed x_wid array for<PHONE_NUMBER>PN Spectrum, though MOS1 and MOS2 were similarly affected
array([ 2.62950361e-03,  2.62750685e-03,  5.24950027e-03,  2.62250006e-03,
        5.23899496e-03,  2.61649489e-03,  1.04490072e-02,  7.81700015e-03,
        7.79950619e-03,  5.19049168e-03,  7.77098536e-03,  5.17101586e-03,
        2.58250535e-03,  2.58047879e-03,  5.15550375e-03,  7.71850348e-03,
        5.13601303e-03,  1.28054768e-02,  5.10850549e-03,  2.55149603e-03,
        5.09750843e-03,  7.63151050e-03,  5.07798791e-03,  5.07101417e-03,
        7.59199262e-03,  1.00975037e-02,  5.03799319e-03,  5.03152609e-03,
        1.00409687e-02,  1.00150108e-02,  4.99749184e-03,  7.48452544e-03,
        9.95746255e-03,  7.45251775e-03,  4.96149063e-03,  4.95550036e-03,
        7.42301345e-03,  1.23459995e-02,  4.92948294e-03,  4.92501259e-03,
        9.83601809e-03,  4.91148233e-03,  7.35950470e-03,  7.35050440e-03,
        9.78749990e-03,  1.22149885e-02,  1.21960044e-02,  9.74398851e-03,
        4.86850739e-03,  9.72950459e-03,  1.45825148e-02,  4.85497713e-03,
        1.21349692e-02,  4.85002995e-03,  1.45500302e-02,  4.84997034e-03,
        1.45400167e-02,  1.21150017e-02,  1.45399570e-02,  1.45400763e-02,
        4.84997034e-03,  4.85002995e-03,  7.26991892e-03,  1.21300220e-02,
        9.71001387e-03,  1.21400356e-02,  9.71496105e-03,  9.72497463e-03,
        9.73004103e-03,  1.46099925e-02,  7.30496645e-03,  1.21900439e-02,
        7.31998682e-03,  1.95399523e-02,  1.46750808e-02,  1.22449994e-02,
        1.22550130e-02,  1.71749592e-02,  7.36999512e-03,  1.22900009e-02,
        1.47650242e-02,  2.21749544e-02,  9.86999273e-03,  2.22250223e-02,
        1.97849870e-02,  2.22899914e-02,  1.98299885e-02,  3.22750211e-02,
        2.48550177e-02,  2.48800516e-02,  9.95993614e-03,  3.23799849e-02,
        3.24100256e-02,  2.74449587e-02,  4.99200821e-02,  2.49749422e-02,
        6.24550581e-02,  7.24749565e-02,  2.24950314e-02,  7.24899769e-02,
        2.75000334e-02,  6.24949932e-02,  3.24999094e-02,  2.25000381e-02,
        5.50000668e-02,  8.99999142e-02,  5.25000095e-02,  3.50000858e-02,
        6.74999952e-02,  5.49999475e-02,  7.99999237e-02,  5.50000668e-02,
        7.99999237e-02,  7.24999905e-02,  1.67500019e-01,  1.37500048e-01,
        6.99999332e-02,  1.05000019e-01,  1.47500038e-01,  9.00001526e-02,
        4.49998379e-02,  1.44999981e-01,  1.74999952e-01,  5.75001240e-02,
        3.25000048e-01,  1.77500010e-01,  1.54999971e-01, -6.13508204e+00])

I also manually modified the view method to use the absolute value of the x_err in order to force the spectrum plot;
Forced Spectrum plot;

I suspect this may be due to my SAS version 21.0.0 being incompatible however the cluster sample used in the Spectroscopy tutorial notebook did not fail so it may be a problem in selecting 'point' regions for spectrum.

So originally I thought XSpec was failing due to the spectra generated by SAS, turns out it was actually failing due to the issue fixed in #942 (which was why I switched from the release version to the current github version) and me not properly removing my xga_output files and xga just reusing the old XSpec scripts.
This caused the model fits to fail and the Spectrum.view() method to fall-back to show_model_fits=False behaviour. Just nuking every xga_ouput file I could find on my system was enough to fix the code I was using to produce the expected output.
However, I still think there may be a problem with the Spectrum.view() method as manually disabling the model fits with
sp.view(show_model_fits=False)

Still causes a negative xerr value for the errorbar plot.
I still wonder if this may be due to my SAS version but need someone else to test this...

Thanks for writing this out so nicely Toby, and I'm sorry for the slow response, I've been very busy recently. I'm also coming across what sounds like the same problem in one of my spectral plots:
ValueError                                Traceback (most recent call last)
Cell In[4], line 5
3 for sp in src.get_spectra(src.r500):
4     print(sp.obs_id, sp.instrument)
----> 5     sp.view()
6 print('\n\n\n')
File /mnt/ufs18/home-218/turne540/code/XGA/xga/products/spec.py:1662, in Spectrum.view(self, figsize, lo_lim, hi_lim, back_sub, energy, src_colour, bck_colour, grouped, xscale, yscale, fontsize, show_model_fits, save_path)
1658 if not show_model_fits:
1659     # Plotting the data, accounting for the different combinations of x-axis and y-axis
1660     if back_sub:
1661         # If we're going for background subtracted data, then that is all we plot
-> 1662         plt.errorbar(x_dat, src_sub_bck_rate.value[:, 0] / per_x, xerr=x_wid,
1663                      yerr=src_sub_bck_rate.value[:, 1] / per_x, fmt="+", color=src_colour,
1664                      label="Background subtracted source data", zorder=1)
1665     else:
1666         # But if we're not wanting background subtracted, we need to plot the source and background spectra
1667         plt.errorbar(x_dat, src_rate.value[:, 0] / per_x, xerr=x_wid, yerr=src_rate.value[:, 1] / per_x, fmt="+",
1668                      color=src_colour, label="Source data", zorder=1)
File ~/software/anaconda3/envs/xga_dev/lib/python3.9/site-packages/matplotlib/pyplot.py:2564, in errorbar(x, y, yerr, xerr, fmt, ecolor, elinewidth, capsize, barsabove, lolims, uplims, xlolims, xuplims, errorevery, capthick, data, **kwargs)
2558 @_copy_docstring_and_deprecators(Axes.errorbar)
2559 def errorbar(
2560         x, y, yerr=None, xerr=None, fmt='', ecolor=None,
2561         elinewidth=None, capsize=None, barsabove=False, lolims=False,
2562         uplims=False, xlolims=False, xuplims=False, errorevery=1,
2563         capthick=None, *, data=None, **kwargs):
-> 2564     return gca().errorbar(
2565         x, y, yerr=yerr, xerr=xerr, fmt=fmt, ecolor=ecolor,
2566         elinewidth=elinewidth, capsize=capsize, barsabove=barsabove,
2567         lolims=lolims, uplims=uplims, xlolims=xlolims,
2568         xuplims=xuplims, errorevery=errorevery, capthick=capthick,
2569         **({"data": data} if data is not None else {}), **kwargs)
File ~/software/anaconda3/envs/xga_dev/lib/python3.9/site-packages/matplotlib/init.py:1442, in _preprocess_data..inner(ax, data, *args, **kwargs)
1439 @functools.wraps(func)
1440 def inner(ax, *args, data=None, **kwargs):
1441     if data is None:
-> 1442         return func(ax, *map(sanitize_sequence, args), **kwargs)
1444     bound = new_sig.bind(ax, *args, **kwargs)
1445     auto_label = (bound.arguments.get(label_namer)
1446                   or bound.kwargs.get(label_namer))
File ~/software/anaconda3/envs/xga_dev/lib/python3.9/site-packages/matplotlib/axes/_axes.py:3642, in Axes.errorbar(self, x, y, yerr, xerr, fmt, ecolor, elinewidth, capsize, barsabove, lolims, uplims, xlolims, xuplims, errorevery, capthick, **kwargs)
3639 res = np.zeros(err.shape, dtype=bool)  # Default in case of nan
3640 if np.any(np.less(err, -err, out=res, where=(err == err))):
3641     # like err<0, but also works for timedelta and nan.
-> 3642     raise ValueError(
3643         f"'{dep_axis}err' must not contain negative values")
3644 # This is like
3645 #     elow, ehigh = np.broadcast_to(...)
3646 #     return dep - elow * ~lolims, dep + ehigh * ~uplims
3647 # except that broadcast_to would strip units.
3648 low, high = dep + np.row_stack([-(1 - lolims), 1 - uplims]) * err
ValueError: 'xerr' must not contain negative values


Batch count dissapears.

Batch count is essential for an unattended generation, especially with current times. I don't know if there is any technical reason for its disappearance, but if not, it should be included.

should be

the batch count is added, please update the extension

Updated and runs fine. thank you so much!


nixVersions.unstable: 2.22.0 -> 2.22.1

Changes: https://github.com/NixOS/nix/compare/2.22.0...2.22.1
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The commit message is wrong, and should reference nixVersions.nix_2_22 or nixVersions.latest. We removed nixVersions.unstable.

Updated PR description and the commit to mention nixVersions.latest.

Thanks @trofi :)


Fix crash when getUserPlaylists is called with no userId

Two assignments were called in the wrong order.  The options object ends up assigned to "callback", causing a crash later when the callback is run.

More specifically, it crashed when called like this:
api.getUserPlaylists({}, callback)
I'm surprised this didn't break the test which seems to call the function incorrectly (options is supposed to be required, according to docs):
api.getUserPlaylists(callback)
This might need further review to make sure it works correctly in that case, if it's supposed to.

Thanks @longears! I think the problem is that I wasn't testing the case in which no userId is provided, but options is. I will add a small test and will draft a new release.


[Bug] [Writer] hdfs temp folder has not been cleaned up #4321

Purpose of this pull request

Check list
close: https://github.com/apache/incubator-seatunnel/issues/4321

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

This is just to delete the directory when commit, and the directory should still exist after the task exits.

You mean it shouldn't be deleted?

This is just to delete the directory when commit, and the directory should still exist after the task exits.

You mean it shouldn't be deleted?

It is only deleted after the commit end, and will be created later, but the directory still exists after the task end, and the temporary directory should be deleted when the task exit.

commit结束后才删除

这只是提交时删除目录，任务退出后目录应还存在。

你的意思是它不应该被删除？

commit结合后才删除，面会创建，但任务结合后该目录仍然存在，任务退出时应删除该临时目录。

This is just to delete the directory when commit, and the directory should still exist after the task exits.

You mean it shouldn't be deleted?

It is only deleted after the commit end, and will be created later, but the directory still exists after the task end, and the temporary directory should be deleted when the task exit.

Can you give me some implementation hints I don't see how to tell if this task is over

This is just to delete the directory when commit, and the directory should still exist after the task exits.

You mean it shouldn't be deleted?

It is only deleted after the commit end, and will be created later, but the directory still exists after the task end, and the temporary directory should be deleted when the task exit.

Can you give me some implementation hints I don't see how to tell if this task is over

This is just to delete the directory when commit, and the directory should still exist after the task exits.

You mean it shouldn't be deleted?

It is only deleted after the commit end, and will be created later, but the directory still exists after the task end, and the temporary directory should be deleted when the task exit.

Can you give me some implementation hints I don't see how to tell if this task is over

I tried to delete the temporary directory in the close method before, but found that the close method will not be called when the task exits. The engine use flink. I have not thought of a better way to solve it.

This pull request not make sense, I will close it, if you have any other questions, please reopen it and send an email to<EMAIL_ADDRESS>


SWS-117 CORS config flag

does this require any update to the readme?

@abonas the README does document all the env var/config settings - so technically yes.
However, I question if we want to maintain that section of the README. It might get out of date quick if people don't remember to keep updating it. So it may be best if we just get rid of it.
That said, without it, we really don't have a place that documents the config settings. Not sure where we could document it now other than the README.
So I'm not sure what to do.

See PR #58  - I added the missing configs to README


Data doesn't update with either XRANGE or TS.RANGE

Summary
I expect that the data updates continuously when Streaming is checked. However, in practice I have to manually press the "Refresh" button:

This is the same for both the XRANGE and TS.RANGE command. Strangely, the plot does move with the expected interval (100 ms) but there is no new data.
Is this behaviour intended or not?
In any case, thanks for this great data source plug-in!
Relevant information
Grafana 9.1.6
grafana-redis-datasource 2.1.1

@frederikaalund Probably, streaming implementation in Grafana was changed since we implemented it for Grafana 8. It was working as expected on the version we tested it.
I hope Redis team will look into it.

I found a workaround where streaming works: Set the time range end a little into the future. E.g., from now-5m to now+1m. I don't know why this workaround works. It seems silly. 😄

I found a workaround where streaming works: Set the time range end a little into the future. E.g., from now-5m to now+1m. I don't know why this workaround works. It seems silly. 😄

Interesting, glad it works for you. Streaming is a unique feature supported only by handful number of plugins.


add readme for example and remove the reference to internal code

Enhance our example by following changes, fixes #3421.

Add readme with details
Remove the references to the code inside the internal folder.

@xieyuschen, thank you for this PR. Unfortunately, we can't merge this contribution. The documentation changes are not up to our standards language-wise, I'd have to rewrite every single sentence if I wanted to accept this change.

@xieyuschen, thank you for this PR. Unfortunately, we can't merge this contribution. The documentation changes are not up to our standards language-wise, I'd have to rewrite every single sentence if I wanted to accept this change.

Thanks for your feedback:)

@xieyuschen, thank you for this PR. Unfortunately, we can't merge this contribution. The documentation changes are not up to our standards language-wise, I'd have to rewrite every single sentence if I wanted to accept this change.

So if the documents is messy now, how about the code?
I think that it's better for user to run our example without any flags.
(I would like to enhance the documents also, is it acceptable once it's up to the level wish?)

What's the problem? The flags are all explained:
❯ go run example/main.go -h
Usage of *****/main:
  -bind value
    	bind to
  -qlog
    	output a qlog (in the same directory)
  -tcp
    	also listen on TCP
  -v	verbose
  -www string
    	www data

What's the problem? The flags are all explained:

❯ go run example/main.go -h

Usage of *****/main:

  -bind value

    	bind to

  -qlog

    	output a qlog (in the same directory)

  -tcp

    	also listen on TCP

  -v	verbose

  -www string

    	www data

The flags are all explained

Agree with you, but shall we provide a default value if the user would like to run without set flag?
Such as a default host like(https://localhost:port) both on client and server side.


Hotel + SSL?

I'm trying to use hotel with a few apps and one in particular requires me to use SSL locally. Does hotel support this at all, or will I need to stick with something like Apache or Nginx?

Hi @mgerton,
It's not currently supported.
Are you using a self-signed cert in dev?
I think it should be possible to use hotel + Apache in conjunction.

Yep, I have a self-signed cert locally. Currently using nginx to run my app (PHP-based) since the built-in PHP dev server doesn't support SSL :cry:
If I wanted to use hotel on top of something like nginx, how would that work? The documentation mainly specifies servers that are run from the command line rather than webservers like Apache/Nginx that run in daemons. I guess I'm not sure what the start/stop functionality of hotel would do exactly?
That said, for other projects, I've been using it and I enjoy it, so thanks for the work you've done! :smile:

The documentation mainly specifies servers that are run from the command line rather than webservers like Apache/Nginx that run in daemons.

Yes it's not currently possible, but I plan to add support for them.

That said, for other projects, I've been using it and I enjoy it, so thanks for the work you've done!

Thank you :)

Yes it's not currently possible, but I plan to add support for them.

Available in v0.4.7 :) just add s to http and an exception for hotel self-signed cert.


Remove "Edit on Github" from header & Commit SHA Revision from Footer on readthedocs.org built docs

Details
Hello,
When using http://readthedocs.org with the ReadTheDocs theme is it possible to remove the following elements? If so, how? I couldn't find anything in the documentation about this, if I overlooked it, please point me in the right direction.

Edit on Github link in header
In footer there's a "Revision #######" after the copyright message. Is there a way to remove this?

Thanks!

Project: Not specific to any project nor build.
Build #: Not specific to any project nor build.

Yes, with template overrides in your _template path. The Sphinx docs have some more on this if you are unfamiliar.

Thanks @agjohnson. I checked out http://www.sphinx-doc.org/en/stable/templating.html as well as a few other issues as well as StackExchange and I'm stumped.
If you can help specifically with the "Edit on Github" piece I'd greatly appreciate it, if not, I understand and you can go ahead and close the issue.
Thanks for everything. :+1:

@agjohnson Seems this is discussed in #681 and #743, however, it's not working based on my understanding of the issue. I also added in the suggested details from https://github.com/snide/sphinx_rtd_theme/issues/205 to no avail.
It looks like the lines are actually not related to layout.html, but actually breadcrumbs.html as seen in https://github.com/snide/sphinx_rtd_theme/blob/master/sphinx_rtd_theme/breadcrumbs.html#L16-L19.
Are you saying to override this I should grab the full breadcrumbs.html, add this to my repo in a _templates folder, then it should work?
Thanks!

I ended up figuring this out myself and updated my StackOverflow question about this with the answer.
http://stackoverflow.com/questions/36019670/removing-the-edit-on-github-link-when-using-read-the-docs-sphinx-with-readthed


Handlers Failing to Chain

Update 2 | Notes for Global Use
Global use seems to be failing for handlers that have a middleware with the following type: (req: BunRequest, res: BunResponse, next?: (err?: Error) => {}, err?: Error) => void | Promise<any> . Once I removed the err?: Error from my cors handler it was registering globally. I could then proceed to use it as follows:
app.use(cors());

Update 1 | Fix for Chaining
Got a solution for the chaining:
bunrest/src/server.ts
private openServer(...args): Server {
   // other code

   // middlewares hander
   if (that.middlewares.length !== 0) {
      const plainMid = that.middlewares.filter(mid => req.path.startsWith(mid.path) || mid.path === '*');

      // rest of code
   }
}

Slightly altering the plainMid variable makes all the difference. Now middlewares in route handlers chain such as:
app.get("/path", middleware1, middleware2, async (req, res) => {
   // code
});

Original Issue
So I was having issues with the Express cors package and began creating one that is fully compatible and typed with bunrest (ideally for release as a package down the road). That being said, my middlewares are not chaining. I have a custom auth middleware to handle API keys and what not which is crucial, however, my cors is only being hit when there's a preflight (I have to specifically add it to router.options). Here is what I have:

auth.ts
authRouter.post(
	"/logout",
	cors({
		allowedHeaders: ["X-API-KEY", "X-AUTH-TOKEN"],
		methods: ["GET", "POST", "PATCH"],
		origins: ["https://www.test.dev"],
	}),
	authMiddleware,
	async (req, res) => {
		try {
			await doSomething();

			res.status(200).json({ success: true });
		} catch (ex) {
			res.status(500).json({ success: false });
		}
	}
);

cors.ts
NOTE: this is a stripped down version
export default function cors(options?: CorsOptions) {

	const _isOrigin = (header: string): boolean => {
		if (Array.isArray(origins)) return origins.includes(header);
		else return true;
	};

	const middelware: Handler = (req, res, next?, err?) => {
				console.log("hit");

				// @ts-ignore
				const host = req.headers["host"];
				const isvalidOriginNoPreflight = _isOrigin(host);

				if (!isvalidOriginNoPreflight) {
					res.status(400).send("");
				}

				// @ts-ignore
				next();
		}
	};

	return middelware;
}

authMiddleware.ts
export const authMiddleware: Handler = (req, res, next?, err?) => {
	const isValid = validateStuff();

	if (!isValid) {
			res.status(401).json({
				message: "Access Denied",
			});
		} else {

			// @ts-ignore
			next();
		}
	} else {
		res.status(400).json({ message: "Invalid credentials provided." });
	}
};

I am sending my request from Postman localhost, so when I only include the cors middleware it rejects my request due to the host not being part of the origins. Equally, when I only include the authMiddleware it does what it should. However, when I chain them, only the last middleware works. So if it goes cors, then authMiddleware; only the auth middleware will run and vice versa.
Additionally, the global app.use(req, res, next?, err?) => {...} does not hit the cors (express or my custom one) middleware if I put it in there.
Other Relevant Info:
Bun version: v1.0.7
bunrest version: v1.3.6
platform: ubuntu 20.04 (docker image)
node installed: yes
node version: v18.18.2

Confirm that the chaining works as intended now. I am currently using:
bunrest v1.3.8
bun v1.1.4


[Question]: I can't set  vm.max_map_count

Describe your problem

The 'screen' is not successful. Please refer to:
https://stackoverflow.com/questions/41192680/update-max-map-count-for-elasticsearch-docker-container-mac-host


fix: maintain agent mutate even when already mutated

Description
Removes the checks on the agent webhook for effecting already patched gitops related resources:

fluxcd-oci-repo
fluxcd-helm-repo
fluxcd-git-repo
argocd-repository
argocd-application

The reasoning for removing the this check is that during the regular lifecycle of gitops tools is that they will re-apply the manifests to make sure the cluster reflects the correct state; this means that fluxcd will override the mutated repos to point to something outside of zarf's control, e.i. clear web endpoints that might not be accessible.
Note
So I did not add tests for removing the check on pods... My logic is that pods are static through their lifecycle once they start, so zarf would only need to mutate them once.
Related Issue
Fixes #3146
Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

Nice work so far! Since this PR is strictly removing code rather than adding code can you delete the test cases involving an already patched Zarf agent, both existing and new

So the thought process in why I added the tests for patching even if they already have the labels is so that it leaves some tests for future developers to not remove that functionality... I can remove the tests if you would still like

Thank you Austin, I will update the PR to apply the changes!

@AustinAbro321 Hey, updated the PR to remove the extra tests and added the logic for checking the url against the zarf state registry url. Let me know if that is good

LGTM, but I'd like to get a review from another one of the @zarf-dev/maintainers before merge

No problem! I figured it was a medium sized change so it is all good to get more eyes on things

Small change otherwise things look good.

@AustinAbro321 and @phillebaba
I updated the PR per @phillebaba comments