feat: initial version

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Couldn't delete container

Currently we can not delete container using pool.Pool without correct session token because despite omitting session token during container deletion the default one will be used (that isn't compatible with required container session token).
The following test shouldn't fail:

import (
	"context"
	"fmt"
	"math"
	"strconv"
	"testing"
	"time"

	"github.com/nspcc-dev/neo-go/pkg/crypto/keys"
	"github.com/nspcc-dev/neofs-sdk-go/acl"
	"github.com/nspcc-dev/neofs-sdk-go/container"
	"github.com/nspcc-dev/neofs-sdk-go/policy"
	"github.com/nspcc-dev/neofs-sdk-go/pool"
	"github.com/stretchr/testify/require"
)

func TestContainerDelete(t *testing.T) {
	ctx := context.Background()

	// have to use key with sufficient amount of gas to create container
	key, err := keys.NewPrivateKey()
	require.NoError(t, err)

	pb := new(pool.Builder)
	pb.AddNode("s01.neofs.devenv:8080", 1, 1)

	opts := &pool.BuilderOptions{
		Key:                     &key.PrivateKey,
		NodeConnectionTimeout:   4 * time.Second,
		NodeRequestTimeout:      4 * time.Second,
		ClientRebalanceInterval: 40 * time.Second,
		SessionExpirationEpoch:  math.MaxUint32,
	}

	p, err := pb.Build(ctx, opts)
	require.NoError(t, err)

	pp, err := policy.Parse("REP 3")
	require.NoError(t, err)

	cnr := container.New(
		container.WithPolicy(pp),
		container.WithOwnerID(p.OwnerID()),
		container.WithCustomBasicACL(acl.ReadOnlyBasicRule))

	cnrID, err := p.PutContainer(ctx, cnr)
	require.NoError(t, err)

	fmt.Println(cnrID)

	err = p.WaitForContainerPresence(ctx, cnrID, pool.DefaultPollingParams())
	require.NoError(t, err)

	err = p.DeleteContainer(ctx, cnrID)
	require.NoError(t, err)

	time.Sleep(3 * time.Second)

	_, err = p.GetContainer(ctx, cnrID)
	require.Error(t, err)
}

First check in NeoFS SN that it does not process session token with object context as token with empty container context in container service.
Then we may ignore default session token in all container related operations in pool.

First check in NeoFS SN that it does not process session token with object context as token with empty container context in container service.

Storage node attaches any token that client provided. If client provides session token without container context, it does not throw any errors. It should be fixed in https://github.com/nspcc-dev/neofs-node/issues/1045
Meantime pool should not attach session tokens to container service requests.


Python Interpreter Only Half-Way Functioning in Extension: play button invisible, 'Select Python Interpreter' unresponsive, etc

Environment data

VS Code version: 1.52.1
Extension version (available under the Extensions sidebar): v2020.12.424452561
OS and version: Ubuntu 18.04.5 LTS
Python version (& distribution if applicable, e.g. Anaconda): python 3.6.9
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: N/A
Relevant/affected Python-related VS Code extensions and their versions: N/A
Value of the python.languageServer setting: Jedi (occurs with Pylance as well)

Expected behaviour

Python interpreter is displayed in the bottom left hand corner.
Green play button in top right corner is visible and executes code in the terminal.
Code is checked by extension and errors are underlined.

Actual behaviour

Green play button to run code is invisible but still works when clicked (aka the terminal pops up and runs the script with the value of python.pythonPath, which for me is \usr\bin\python3.6).
Error appears saying "Python is not installed. Please download and install Python before using the extension." Additionally, the "Select Python Interpreter" button is unresponsive to selecting a new interpreter.
No errors are underlined in the code.

This happened overnight about a month ago. It might be related to permissions but I'm not sure what/where permissions would have to be changed. I hope it's a quick fix, I've been looking thru the errors since this started happening and I can't find errors that explain how to fix this issue. Thanks for what y'all do!
Steps to reproduce:
I'm not sure how to reproduce it since it results from regular set-up for the extension.

Logs
User belongs to experiment group 'ShowPlayIcon - start'
User belongs to experiment group 'ShowExtensionSurveyPrompt - control'
User belongs to experiment group 'DebugAdapterFactory - experiment'
User belongs to experiment group 'PtvsdWheels37 - experiment'
User belongs to experiment group 'UseTerminalToGetActivatedEnvVars - control'
User belongs to experiment group 'LocalZMQKernel - experiment'
User belongs to experiment group 'CollectLSRequestTiming - control'
User belongs to experiment group 'CollectNodeLSRequestTiming - experiment'
User belongs to experiment group 'EnableIPyWidgets - experiment'
User belongs to experiment group 'RunByLine - experiment'
User belongs to experiment group 'CustomEditorSupport - control'
User belongs to experiment group 'pythonaa'
User belongs to experiment group 'pythonSendEntireLineToREPLcf'
> conda --version
> pyenv root
> python3.7 ~/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python3.6 ~/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python3 ~/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python2 ~/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python ~/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> /usr/bin/python3.6 ~/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> conda info --json
Error 2021-01-08 14:19:50: Detection of Python Interpreter for Command python and args  failed as file  does not exist
Error 2021-01-08 14:19:50: Detection of Python Interpreter for Command python2 and args  failed as file  does not exist
Error 2021-01-08 14:19:50: Detection of Python Interpreter for Command python3 and args  failed as file  does not exist
Error 2021-01-08 14:19:50: Detection of Python Interpreter for Command python3.6 and args  failed as file  does not exist
Error 2021-01-08 14:19:50: Detection of Python Interpreter for Command /usr/bin/python3.6 and args  failed as file  does not exist
> pyenv root
> pyenv root
> pyenv root
> pyenv root
Error 2021-01-08 14:19:51: Failed to get interpreter information for '/usr/bin/python2.7' [Error: Command failed: "/usr/bin/python2.7" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/interpreterInfo.py"
/usr/bin/python2.7: can't open file '/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py': [Errno 2] No such file or directory

	at ChildProcess.exithandler (child_process.js:304:12)
	at ChildProcess.emit (events.js:223:5)
	at maybeClose (internal/child_process.js:1021:16)
	at Socket.<anonymous> (internal/child_process.js:430:11)
	at Socket.emit (events.js:223:5)
	at Pipe.<anonymous> (net.js:664:12)] {
  killed: false,
  code: 2,
  signal: null,
  cmd: '"/usr/bin/python2.7" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/interpreterInfo.py"'
}
Error 2021-01-08 14:19:51: Failed to get interpreter information for '/usr/bin/python2' [Error: Command failed: "/usr/bin/python2" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/interpreterInfo.py"
/usr/bin/python2: can't open file '/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py': [Errno 2] No such file or directory

	at ChildProcess.exithandler (child_process.js:304:12)
	at ChildProcess.emit (events.js:223:5)
	at maybeClose (internal/child_process.js:1021:16)
	at Socket.<anonymous> (internal/child_process.js:430:11)
	at Socket.emit (events.js:223:5)
	at Pipe.<anonymous> (net.js:664:12)] {
  killed: false,
  code: 2,
  signal: null,
  cmd: '"/usr/bin/python2" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/interpreterInfo.py"'
}
Error 2021-01-08 14:19:51: Failed to get interpreter information for '/usr/bin/python' [Error: Command failed: "/usr/bin/python" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/interpreterInfo.py"
/usr/bin/python: can't open file '/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py': [Errno 2] No such file or directory

	at ChildProcess.exithandler (child_process.js:304:12)
	at ChildProcess.emit (events.js:223:5)
	at maybeClose (internal/child_process.js:1021:16)
	at Socket.<anonymous> (internal/child_process.js:430:11)
	at Socket.emit (events.js:223:5)
	at Pipe.<anonymous> (net.js:664:12)] {
  killed: false,
  code: 2,
  signal: null,
  cmd: '"/usr/bin/python" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/interpreterInfo.py"'
}
Error 2021-01-08 14:19:51: Failed to get interpreter information for '/usr/bin/python3.6' [Error: Command failed: "/usr/bin/python3.6" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/interpreterInfo.py"
/usr/bin/python3.6: can't open file '/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py': [Errno 2] No such file or directory

	at ChildProcess.exithandler (child_process.js:304:12)
	at ChildProcess.emit (events.js:223:5)
	at maybeClose (internal/child_process.js:1021:16)
	at Socket.<anonymous> (internal/child_process.js:430:11)
	at Socket.emit (events.js:223:5)
	at Pipe.<anonymous> (net.js:664:12)] {
  killed: false,
  code: 2,
  signal: null,
  cmd: '"/usr/bin/python3.6" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py" "/home/mrobertson/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/interpreterInfo.py"'
}

...
And it just repeats itself over and over again, throwing out the same error about not finding pyvsc-run-isolated.py but for the different interpreters I have on my machine (I've checked and the file indeed does not exist). If I need to just add that file, where can I get it?

You have a bad install (hence the missing file); try:

Uninstalling the extension
Quitting VS Code (to force it to clean up)
Launching VS Code again
Installing the extension again

You have a bad install (hence the missing file); try:

Uninstalling the extension
Quitting VS Code (to force it to clean up)
Launching VS Code again
Installing the extension again

Thanks!

Thanks!


Chisel emits unknown widths as <?>

This is no longer part of the FIRRTL spec and is not supported by Scala FIRRTL
See ucb-bar/firrtl#68

Fixed with 39b612b7490090d4be5a324c810c54e79b8e0736


The +name-only options for Clap-files does not operate with fzf search syntax

Instructions: Replace the template text and remove irrelevant text (including this line)
Warning: if you don't fill this issue template and provide the reproducible steps the issue could be closed directly.

When I open the Clap-files with +name-only option and type word devfreq.
Clap-files show me the correct results like below. It show only files containing the word devfreq.

If I type word 'devfreq to get exact-match results. accroding to following fzf search syntax
I expected only files that has the exact name of devfreq to be shown.

Token
Match type
Description

sbtrkt
fuzzy-match
Items that match sbtrkt

'wild
exact-match (quoted)
Items that include wild

^music
prefix-exact-match
Items that start with music

.mp3$
suffix-exact-match
Items that end with .mp3

!fire
inverse-exact-match
Items that do not include fire

!^music
inverse-prefix-exact-match
Items that do not start with music

!.mp3$
inverse-suffix-exact-match
Items that do not end with .mp3

But, when I type 'devfreq, the directories are also shown.
That is, both file and directories are shown like below

Clap debug
            has ctags: Universal Ctags 0.0.0 (+json)
            has cargo: 1
            has maple: /home/kitak/my-settings/bundle/vim-clap/bin/maple
           maple info: version 0.1.43 (git v0.43-1-g31b0b3b), compiled at: 2023-04-20 07:15:05.544219667 -07:00, built for x86_64-unknown-linux-gnu by rustc 1.68.2 (9eb3afe9e 2023-03-27).
        rustc version: rustc 1.68.2 (9eb3afe9e 2023-03-27)
     Current FileType:
Third Party Providers: []
       Global Options:
    let g:clap#autoload_dir = '/home/kitak/my-settings/bundle/vim-clap/autoload'
    let g:clap#popup#display = {'shrink': function('46'), 'open': function('<SNR>32_create_display'), 'shrink_if_undersize': function('45')}
    let g:clap#popup#preview = {'line_count': function('<SNR>31__line_count'), 'show': function('47'), 'hide': function('48'), 'clear': function('49'), 'add_highlight': function('51'), 'get_lines': function('<SNR>31__get_lines'),
 'getbufvar': function('<SNR>31__getbufvar'), 'setbufvar_batch': function('<SNR>31__setbufvar_batch'), 'setbufvar': function('<SNR>31__setbufvar'), 'win_is_valid': function('<SNR>31__win_is_valid'), 'goto_win': function('<SNR>31_
_goto_win'), 'set_syntax': function('50')}
    let g:clap#provider_alias = {'gfiles': 'git_files', 'hist:': 'command_history', 'hist/': 'search_history'}
    let g:clap_background_shadow_blend = 50
    let g:clap_disable_bottom_top = 0
    let g:clap_disable_matches_indicator = v:false
    let g:clap_disable_run_rooter = v:false
    let g:clap_enable_background_shadow = v:false
    let g:clap_enable_debug = v:false
    let g:clap_enable_icon = 0
    let g:clap_forerunner_status_sign = {'done': '•', 'running': '!', 'using_cache': '*'}
    let g:clap_insert_mode_only = v:false
    let g:clap_multi_selection_warning_silent = 0
    let g:clap_no_matches_msg = 'NO MATCHES FOUND'
    let g:clap_open_action = {'ctrl-v': 'vsplit', 'ctrl-x': 'split', 'ctrl-t': 'tab split'}
    let g:clap_open_preview = 'always'
    let g:clap_popup_border = 'rounded'
    let g:clap_preview_direction = 'AUTO'
    let g:clap_preview_size = 5
    let g:clap_providers_relaunch_code = '@@'
    let g:clap_search_box_border_style = 'nil'
    let g:clap_search_box_border_symbols = {'nil': ['', ''], 'curve': ['', ''], 'arrow': ['', '']}
  Provider Variables:
                     []

That's expected as +name-only is only intended to work with fuzzy matching which is the default searching behavior, the exact and inverse matching still operates against the full line content.


Edge detect filters

Add filters for edge detection, possibly including gaussian difference, Laplace, sobel

A repository of filters can be found here: http://www.jhlabs.com/ip/filters/

Edge detection (sobel) and a sharpen filter is added in 0.6.1


Client: return log root or no root at all on GetEntry

The log is useful for gossip.

This has been implemented.
However, it will probably be removed soon as LogRoots will soon only be returned by GetEpoch and GetLatestEpoch.  Anything referencing a LogRoot will need a call to those APIs first.


parentage of GO:0016533 cyclin-dependent protein kinase 5 holoenzyme complex

Hi,
I think this term's relationships need adjusting:
At least in human, the CDK5 (Q00535) complexes have both cytoplasmic and nuclear relationships, depending on the isoform of the activator: p35 (CDK5R1, Q15078) and p39 (CDK5R2, Q13319) localise CDK5 to the cytoplasmic side of the plasma membrane while the proteolytic p25 (CDK5R1, PRO_0000004795) localises the complex to the nucleus (PMID: 18507738).
The other issue is that it is not cyclin-dependent even though that's what the name says. It's named because of sequence homology to other CDKs but has it's own activator molecules (see above). Although, parent term GO:0000307 cyclin-dependent protein kinase holoenzyme complex does not contain cyclin as the activator in the def so it should be fine.
Birgit
Reported by: bmeldal
Original Ticket: geneontology/ontology-requests/10963

@bmeldal
What needs to be done exactly ?
Thanks, Pascale

[x] Subcellular location: no action as it can't have part_of relationship to cytoplasm AND nucleus.

Fix GO:0016533 cyclin-dependent protein kinase 5 holoenzyme complex:
Main problem: CDK5 is NOT cyclin-activated but has its own activators: CDK5R1 or CDK5R2. This needs to be fixed in the following term names and defs:

[ ] Re-name to GO:0016533 cyclin-dependent protein kinase 5 holoenzyme complex

[ ] delete "holo" in "holoenzyme" as the complex always consists of the kinase CDK5 + activator subunit? There are no children that have different enzymes.

[ ] fix def of GO:0016533 cyclin-dependent protein kinase 5 holoenzyme complex:

A protein complex that activates cyclin-dependent kinase 5; composed of regulatory and catalytic subunits.

A protein complex that has protein serine/threonine kinase activity; in mammals composed of catalytic subunit CDK5 and regulatory subunits CDK5R1 or CDK5R2. Contrary to its gene symbol, CDK5 is not cyclin-dependent.

[ ] is_a Parentage: should be is_a GO:1902554 serine/threonine protein kinase complex NOT GO:0150005 enzyme activator complex

[ ] capable_of relationship: replace GO:0016534 cyclin-dependent protein kinase 5 activator activity (which applies to the activator subunit of the complex, not the complex itself) with GO:0004674 protein serine/threonine kinase activity (which it should inherit from new is_a parent anyway)

I think that's it - famous last words...
Birgit


Update our sample release schedule

This PR brings our release cadence documentation (the sample schedule) into line with our current reality, and makes a few minor modifications and clarifications, particularly emphasizing the CHANGELOG being up-to-date.
You can view the changes here: https://github.com/cfpb/cfgov-refresh/blob/69c22928ee950ce5bd0cf88057d71a12ea60bac9/docs/release-cadence.md

👍 :shipit:


Could not Compile ARM Compute library on Raspberry Pi

Output of 'strings libarm_compute.so | grep arm_compute_version':
Platform: Raspberry Pi 5
Operating System: Raspberry Pi Bookworm OS
GCC version: g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/arm-linux-gnueabihf/12/lto-wrapper
Target: arm-linux-gnueabihf
Configured with: ../src/configure -v --with-pkgversion='Raspbian 12.2.0-14+rpi1' --with-bugurl=file:///usr/share/doc/gcc-12/README.Bugs --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-12 --program-prefix=arm-linux-gnueabihf- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-libitm --disable-libquadmath --disable-libquadmath-support --enable-plugin --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-sjlj-exceptions --with-arch=armv6+fp --with-float=hard --disable-werror --enable-checking=release --build=arm-linux-gnueabihf --host=arm-linux-gnueabihf --target=arm-linux-gnueabihf
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.2.0 (Raspbian 12.2.0-14+rpi1)

Problem description:  I have followed the instructions provided in this page: https://developer.arm.com/documentation/ecm0752397/ac/Install-and-build-the-Arm-Compute-Library-on-Pi
ACL version: 20.02.1
This used to work in the past. But when I tried this on my new raspberry pi 5 board I get the below error:
Installing ARM Compute library 20.02.1
scons: Reading SConscript files ...
Mkdir("build")
scons: done reading SConscript files.
scons: Building targets ...
scons: arm_compute' is up to date. scons: support' is up to date.
scons: building associated VariantDir targets: build/utils
g++ -o build/utils/CommonGraphOptions.o -c -Wall -DARCH_ARM -Wextra -pedantic -Wdisabled-optimization -Wformat=2 -Winit-self -Wstrict-overflow=2 -Wswitch-default -std=gnu++11 -Woverloaded-virtual -Wformat-security -Wctor-dtor-privacy -Wsign-promo -Weffc++ -Wno-overlength-strings -Wlogical-op -Wnoexcept -Wstrict-null-sentinel -march=armv7-a -mthumb -mfpu=neon -mfloat-abi=hard -Wno-ignored-attributes -O3 -D_GLIBCXX_USE_NANOSLEEP -DARM_COMPUTE_CPP_SCHEDULER=1 -DEMBEDDED_KERNELS -Iinclude -I. -I. utils/CommonGraphOptions.cpp
g++ -o build/utils/GraphUtils.o -c -Wall -DARCH_ARM -Wextra -pedantic -Wdisabled-optimization -Wformat=2 -Winit-self -Wstrict-overflow=2 -Wswitch-default -std=gnu++11 -Woverloaded-virtual -Wformat-security -Wctor-dtor-privacy -Wsign-promo -Weffc++ -Wno-overlength-strings -Wlogical-op -Wnoexcept -Wstrict-null-sentinel -march=armv7-a -mthumb -mfpu=neon -mfloat-abi=hard -Wno-ignored-attributes -O3 -D_GLIBCXX_USE_NANOSLEEP -DARM_COMPUTE_CPP_SCHEDULER=1 -DEMBEDDED_KERNELS -Iinclude -I. -I. utils/GraphUtils.cpp
In file included from ./utils/Utils.h:36,
from ./utils/ImageLoader.h:32,
from utils/GraphUtils.cpp:34:
include/libnpy/npy.hpp: In function ‘std::string npy::pyparse::write_tuple(const std::vector&)’:
include/libnpy/npy.hpp:298:42: error: ‘ostream_iterator’ is not a member of ‘std’
298 |     std::copy(v.begin(), v.end()-1, std::ostream_iterator(ss, delimiter.c_str()));
|                                          ^~~~~~~~~~~~~~~~
include/libnpy/npy.hpp:33:1: note: ‘std::ostream_iterator’ is defined in header ‘’; did you forget to ‘#include ’?
32 | #include
+++ |+#include
33 | #include
include/libnpy/npy.hpp:298:60: error: expected primary-expression before ‘>’ token
298 |     std::copy(v.begin(), v.end()-1, std::ostream_iterator(ss, delimiter.c_str()));
|                                                            ^
scons: *** [build/utils/GraphUtils.o] Error 1
scons: building terminated because of errors.
I think this is because of the strictness enforced by newer versions of g++ compiler in Bookworm OS.  Does this repo need a code update to include proper headers?
Any help or direction is appreciated.
Thanks

Hi @pegasus-git

ACL version: 20.02.1

Could you please try updating to v24.09 ?
The command git clone https://github.com/Arm-software/ComputeLibrary.git should have gotten the latest release. See below:
~/test/ComputeLibrary$ git log
commit c61bd3387403b76d618915ccebf5e9585f52a071 (HEAD -> main, tag: v24.09, origin/main, origin/HEAD)
Author: Jenkins<EMAIL_ADDRESS>Date:   Wed Sep 25 16:09:05 2024 +0000

    Compute Library v24.09

Hope this helps

Hi @morgolock
Thank you for your reply.
I was following MathWorks (MATLAB) recommendation to use v20.02.1 as that was the latest they support, My installation instruction very similar to those mentioned in https://developer.arm.com/documentation/ecm0752397/ac/Install-and-build-the-Arm-Compute-Library-on-Pi except instead of the latest version, I download the 20.02.1.

Hi @pegasus-git
The problem is the combination of toolchain and ACL version, you're using an old version of ACL 20.02 along with a fairly recent toolchain gcc 12. This won't work unfortunately.
You have two options:

Get an older toolchain to build 20.02, you could try with gcc 6.4 which can be downloaded from https://releases.linaro.org/components/toolchain/binaries/
Update to 24.09 and use gcc 12

Hope this helps


Python Language Server is using ~30% CPU

We have written the ne
Issue Type: Performance Issue
It seems the python-language-server.exe use not less than 30% of the CPU frequently recently. But after all, it doesn't need that much CPU consumption at all. I don't know exactly why! Can someone look at this problem quickly? It's a good extension before something goes wrong.
Extension version: 2018.6.0
VS Code version: Code 1.30.0 (c6e592b2b5770e40a98cb9c2715a8ef89aec3d74, 2018-12-11T22:29:11.253Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 1800)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.90GB (2.00GB free)

Process Argv

Screen Reader
no

VM
67%

Process Info
CPU %	Mem MB	   PID	Process
    1	   131	 16896	code main
    0	   112	  3416	   shared-process
    3	   209	  8712	   window (Extension: Python - Visual Studio Code)
    0	    85	 12128	     extensionHost
    1	    68	 11776	   window (Issue Reporter)
    1	   165	 12860	   gpu-process
    0	    73	 19160	   window (undefined)

Workspace Info
;

eded data into your clipboard because it was too large to send. Please paste.

Can you confirm for us that you are using Jedi or the Microsoft Python Language Server? In your settings.json, if you should see "python.jediEnabled": "true"  then Jedi is enabled.
Try disabling Jedi if that is currently enabled (or enabling it if it is currently disabled) and let us know if there is any change.
Also, please do give us as much detail about your workspace as you can, including (if possible) a sample to help up reproduce what you are seeing.
Thanks!

Yes, I used the extend-package:  Python before the problem occurred. The Python-language-server in it has occupied a large number of CPUs frequently since December. It's really annoying, but it doesn't need so much computation at all, does it? It should do a good service quietly.
Later I switched to jedi, which was the same function, but as usual, the CPU fan was quiet, and that's what happened.
But I think the Python-language-server should do better, right?
Thank you for your reply！

Any update on this ? My CPU is hitting 100% on MAC

@rmkcodes & @canvas-J - Please do see issue #3724, there is a repro there that we are currently following up on with our upstream team.
The current workaround seems to be to enable Jedi in the settings for your workspace (thereby disabling the language server).
I'm going to close this issue in favour of #3724.


Support *.jsm and/or package.json glob field

In addition to (or replacement of?) the goofy /(^|;)\s*export\s+[{*\w]/ detection regex, parse blacklisted files are modules if the resolved path extension is .jsm or there is an available module detection glob defined.
Discussion: https://github.com/nodejs/node-eps/issues/13
For the link back readers: I can imagine a system defaulting the module detection glob to **/*.jsm if no package.json is found, or the designated field is not present. :sweat_smile:
Then, deprecate the glob in Node 8 or 10 since new code will likely use *.jsm to avoid the burden of maintaining a correct glob.
This has the flexibility of a glob-based config solution without necessitating config (especially for new code!), and the simplicity of an extension-based solution without necessitating extension change.
Environments that want to avoid parsing JSON have to eat the cost of the extension change, but something has to give in that case.

Closing in deference to #270


[Enhancement]: PoC for pip based operator/pipeline packaging

Is there an existing issue for this?

[X] I have searched the existing issues

What would you like to be added?
Add scripts and templates for pip based op/pipeline packaging.
Why is this needed?
No response
Anything else?
No response

is it possible to guess whether the code in a directory is an operator or pipeline? using the source code itself.
@junjiejiangjjj

is it possible to guess whether the code in a directory is an operator or pipeline? using the source code itself. @junjiejiangjjj

The pipeline has no py files.

is it possible to guess whether the code in a directory is an operator or pipeline? using the source code itself. @junjiejiangjjj

The pipeline has no py files.

we are planning to add .py file, to support training


Add examples of how to set TTL for CNAME?

I have been trying tyo change the TTL for CNAME records in Azure DNS via the az cli but have failed. Any examples of how to do this would be appreciated!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39f6048c-aa9b-7dba-52e0-78cacc1a8c8f
Version Independent ID: 38b3a686-0778-964f-863a-6eead046ea7d
Content: CLI Example - Create a DNS zone and record for a domain name - Azure
Content Source: articles/dns/scripts/traffic-manager-cli-create-dns-zone-record.md
Service: traffic-manager
GitHub Login: @vhorne
Microsoft Alias: victorh

@yooakim , I will do a repro and provide you a solution.

@yooakim , You cannot set the TTL for the existing record set via CLI. You can define the TTL during the time of creation.
You can use REST API to do it as mentioned here:https://docs.microsoft.com/en-us/rest/api/dns/recordsets/update
Or you can do it with Portal.

How can we add a feature request for setting the TTL via the CLI? @msrini-MSFT


remove secondary data config from the data prop

Fixes #7109

remove secondary data config from the data prop so that we don't have a huge config hindering code readability

@richard-cox I don't know how to improve this further, since moving it to a method. It cannot be a const because it needs to access this values. Wasn't able to create a custom method and access it from the mixin, also. If you have a further idea, please let me know. 🙏
QA testing
No major changes were done, just moving stuff around to improve code readability. Generally just check if PV, PVC and Workloads create + edit views are working properly and loading data to select inputs.

Rebase done


Commenting on history

RedditJS doesn't seem to be able to distinguish between articles/threads where commenting is permissible and when the article/thread is archived and no longer writable.
BTW, thanks for making this!  I've been using marionette and have been pleased with how it works.  This app is pretty nifty!

When does reddit disable comments on a post?  After one year?
There is no property in the API that indicates comments are disabled.
Here's an example post over a year old and its disabled http://www.reddit.com/r/AskReddit/comments/12ly88/is_there_anything_that_truly_annoys_you_but.json

It's live now
You can see comments disabled on this old post https://redditjs.com/r/AskReddit/comments/12ly88/is_there_anything_that_truly_annoys_you_but

You are cool!  Funny thread.  It would be nice if they had an "archived" or such property.  Thanks!


[samples] (Scenarios) Fix implicit any usage in the Analyze web downloads sample

Fixes #436.
When this restriction was added to Office Scripts, the sample in question was not updated to match.
Some of the code spacing is also updated to reflect the current spacing standards in the Code Editor.

Docs Build status updates of commit 00dc630:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 00dc630:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/scenarios/analyze-web-downloads.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Added the filter validation on api validator

This pr will be re opened when the https://github.com/madgik/MIP-Engine/pull/132 is merged.


Initial implementation (& discussion)

I haven't tested this at all yet, so it's definitely not ready, but there are a few things I thought it'd be worth talking about at this point.

How do we want to deal with the various content types that can be sent?
What do we want for the response? Is plain text enough? What about reading response headers?
Is the free monad overkill?

I spent a while trying things out for point 3, including a couple of ways of implementing it without using purescript-free, but it did seem silly not to take advantage of what we already have there. However, I'm acutely aware of the amount of machinery being used to enact a pretty trivial task. But then I guess it doesn't have to be super fast, as it's unlikely that people will need to make a lot of requests together, and even if they do the AjaxRequest type is still available to be used directly if so desired.
Any feedback is welcome, but I am intending to check things over and actually try running the code before calling it done! So really it's more the questions about the implementation that I'm looking for input on right now.

Looks nice to me. It's nice to see Free being used some more.
Thinking out loud, maybe something like RebindableSyntax for >>= would let you constrain things like limiting to one method, or one URL.
Have you considered using something like purescript-options for the AJAX request object?
Maybe a bunch of newtypes and a type class would be a nice way to handle the various content types? newtype PlainText, newtype JSON, etc.
For the response, something like Foreign seems like a decent default for the low-level API, which you could then layer abstractions on top of.

Even though I raised the point originally in the API discussion I became less concerned about setting the method or URL more than once - I figured the compositional advantage of not restricting that might be worth it. For example, you might want to make most of a request in one place, and then override the method or endpoint later on before running it, while keeping headers or content or something.
I did end up putting something in for the content types, but it depends on these additions to purescript-dom - which I don't know if we want to add necessarily, but it seemed sensible to have canonical foreign types for those things.
JSON isn't a "native" type for XHR, but it probably would be nice to have a combinator that handles that, but then I don't know what type to use for that either! Could be forall a. { | a}, could be Foreign, could be Json from purescript-argonaut etc. so again I left that out for now. Json would be the "best" solution, but pulling argonaut in to this is probably overkill.
I hadn't even thought of purescript-options actually, but yeah, that would probably work.
Foreign probably is the way to go for the response too, given it can be one of a number of types. Perhaps there could be two ways of running a request, one returning Foreign and the other (Foreign, [Header]) or something like that.

There is an option to set expected response type i.e.
class Responsable a where
  toStr :: a -> String

request = do
  ...
  expected Json

there is an option to set expected type
foreign import data RawResponse :: *

class Response a where
  to :: RawResponse -> a

instance rJson :: Response Json where
  ...

-- then add response type to AffjaxRequest

Or we can use
data Response a = ApplicationJson String | XML String | RawText String

and check response type in ffi function

@cryogenian The 2nd approach won't work, because the client has to "request" the type of response -- the browser will lazily compute it if possible (for example, if you request XML, it will be parsed as XML, but not if you request text).
The 1st approach might work for this. Then users call the to function (hopefully by some better name :smile: ), to convert from the response to something that is provably obtainable from the XMLHttpRequest (i.e. responeBody, responseXML, responseTxt). Argonaut's JSON type could implement such a thing.

Would it be possible to just tag the request and response types with the type of the response data to ensure that they're compatible?
So a Request Blob would result in a Response Blob or whatever, and then you provide smart constructors to create requests with a finite set of acceptable content types.

The request content type has no connection to the response unfortunately as the request content-type header does not determine the response. They don't even have the same set of potential types (supposedly there is an XHR JSON response, although I don't know how you're supposed to get one as application/json content-type response headers don't trigger it, along with some moz-specific stuff).

Sorry, I was thinking of the Accept header.

Oh, maybe I misunderstood too, AjaxRequest is already parameterised with the send-content-type, did you mean just adding another parameter to cover the responses also?

Yes - maybe it doesn't make sense, I've been kind of dipping in and out of the conversation. But it seems to make sense to be able to say "this is what I expect in the response, fail if it's anything else". You can handle it when you get the response using foreign, argonaut, or whatever, but this seems to assert a little extra type safety between request and response. It changes the meaning of the errors to "the server is probably doing something wrong".

Yeah, request and response types can't be tied together, but it would be nice to tie request / response encoders & decoders to mime types, so you can get those errors like @paf31 mentioned.

class AjaxRequestable a where
  mimeType :: MimeType
  to :: a -> Foreign

class AjaxResponsable a where
  mimeType :: MimeType
  from :: Foreign -> Either Error a

:+1:
Could make it forall req res. (IsForeign res) => AjaxRequest req res perhaps then?

Oh, or that :)

I'll try and address the remaining response-related things tomorrow, I've made the Header and Verb stuff local to affjax now.
Header is just as bad as it was before, if not worse considering I've not provided a set of default HeaderHeads, but I figured for now I'd just go with something simple that will work until we have a proper HTTP library. Maybe this is still wrong though, as I guess to get correctly typed Header values we can't separate the value from the HeaderHead.

Yes, the Header must be a sum type, where each term encodes the type-safe values possible by its constructor. So maybe the right thing to do in the short term is something quick & dirty, e.g.:
data Header = Unknown String String -- or data Header = Header String String

A well-done, type-safe HTTP library would be useful here as well as for any node.js HTTP libraries.
Oh, forgot to mention another problem with http, that is, it doesn't separate RequestHeader from ResponseHeader, and the two are actually quite different; they share a few terms but are conceptually and semantically distinct. Most types of request headers don't make sense in responses, and visa versa.

I'm having some difficulty with switching over to using AjaxRequestable.

If I change the content property to a
create a NoContent value with AjaxRequestable instance
update defaultRequest to use that and be typed as AjaxRequest NoContent

affjaxRequest doesn't work out anymore, as the type in State is expected be AjaxRequest NoContent.
However, if I keep content as Maybe a it becomes annoying to use, as making a simple call without setting some content results in errors like No instance found for Network.Affjax.Request.AjaxRequestable u15626.

One option would be to make content's type Foreign, but that doesn't seem like a very good idea.
At first I wanted to implement AjaxRequestable's to as being a -> Content, which would also solve this I think, but I ran in to a difficulty there as well.
Currently Content's a parameter is for the ArrayViewContent constructor, I was going to make use Exists ArrayView so we could drop the parameter from Content, but @paf31 pointed out on IRC that allows any kind of nonsense - which is also true with Content a at the moment. Perhaps having ArrayViewContent use a sum type as its argument that restricts the possible set to sensible types is the way to go, although not entirely convenient.

Ok, found a middle ground. I introduced a foreign AjaxContent type, which is basically just Foreign but with more meaning at least.
The AjaxRequestable class has a bunch of default instances for the "low level" content types to allow those to be posted, I'm not 100% sure on the mime types provided for those, but the idea is they will make it easier to produce AjaxRequestable instances for higher level types rather than necessarily be relied on directly.

I'm starting a new branch, I think using purescript-options might be a better approach.


Brackets autocompletion in Console

The Console in Firefox does autocompletion for brackets of all kind which makes it much faster to type JavaScript expressions without any errors. The Console in Edge does not. However, the Snippets editor in Sources does. This seems inconsistent and it would be great if Console also closed brackets automatically.

This seems like a very good user convenience to add, indeed. VS Code also does this by default it seems. So I'm willing to bet that more people expect this to happen by default than not. But it might still be worth adding a setting for people to turn it off in case they don't like it.


1.9 tag still not found

On https://hub.docker.com/r/tcnksm/gox/tags/ ,
README was updated but 1.9 tag still not found 😢

Sorry for late. Pushed image.

Thanks a lot ☺

FYI: latest looks still 1.7 .


Putting a MongoCursor document into an array while iterating crashes HHVM (Segmentation fault)

In general, I am getting frequent HHVM crashes using MongoFill. Specifically, I am observing HHVM crashing with a seg fault when I put a MongoCursor document into an array while iterating over the MongoCursor result obj (example below). I'm getting no helpful errors beyond "Core dumped: Segmentation fault" in /var/log/hhvm/error.log, a WSOD in the browser with a "502 Bad Gateway" http status and a cryptic Stacktrace (below).
To give some context - this is code that worked without errors using PHP-FPM.
Here is an example:
$m = new MongoClient();
$db = $m->mydb;

$response = array();

$items = $db->mycollection->find();
foreach ($items as $item) {
  $response[] = $item; // This causes Seg Fault
}

I can work around this by only pulling out the fields that I want. For example:
...
foreach ($items as $item) {
  $item2 = array();
  $item2['field1'] = $item['field1'];
  $item2['field2'] = $item['field2'];
  $response[] = $item2; // No more Seg Fault
}

This may have something to do with internal iterator_to_array() conversion that is happening but I'm not at all sure.
Here is my stacktrace log: http://pastebin.com/raw.php?i=gsFTXG8N I don't know what most of it means but maybe I'm missing something obvious.
I'm currently trying to recompile HHVM in debug mode in hopes it will give me more helpful error messages. However for some reason at 100% of the "make" process I get an error while "Linking CXX executable hhvm" (maybe out of memory?). So this is the best I can do for now. Please refer to the Stacktrace for HHVM version info.

this still happen in the new HHVM versions?


using HttpMockSequence with BatchHttpRequest

I am trying to switch over to batching our inappproduct updates and I can't figure out how to avoid this exception in my automated tests:
    result = batch.execute(http=self._http)
  File "/Users/rosslarner/udemy-py3-env/lib/python3.4/site-packages/oauth2client/util.py", line 137, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "/Users/rosslarner/udemy-py3-env/lib/python3.4/site-packages/googleapiclient/http.py", line 1303, in execute
    self._execute(http, self._order, self._requests)
  File "/Users/rosslarner/udemy-py3-env/lib/python3.4/site-packages/googleapiclient/http.py", line 1252, in _execute
    header = 'content-type: %s\r\n\r\n' % resp['content-type']
nose.proxy.KeyError: 'content-type'

It was all working fine with HttpMockSequence when I wasn't batching the requests. Any ideas on how to get this to work?

I figured out how to make this work by adding content-type and boundary headers, e.g.,:
class MobileTestCaseMixin:
    """A mixin for shared setup and helper functions for mobile tests"""

    def get_mocked_http(self):
        course_json = self.datafile('course.json')

        batch_response = """--batch_foobarbaz
Content-Type: application/http
Content-Transfer-Encoding: binary
Content-ID: <randomness+1>

HTTP/1.1 200 OK
Content-Type: application/json
Content-Length: 14
ETag: "etag/pony"\r\n\r\n{}

--batch_foobarbaz--""".format(course_json)
        batch_response = bytes(batch_response, 'utf-8')
        return HttpMockSequence([
            ({'status': '200'}, self.datafile('discovery.json')),
            ({'status': '200', 'content-type': 'multipart/mixed; boundary="batch_foobarbaz"'},
                batch_response),
            ({'status': '200', 'content-type': 'multipart/mixed; boundary="batch_foobarbaz"'},
                batch_response),
            ({'status': '200', 'content-type': 'multipart/mixed; boundary="batch_foobarbaz"'},
                batch_response),
            ({'status': '200', 'content-type': 'multipart/mixed; boundary="batch_foobarbaz"'},
                batch_response),
            ({'status': '200', 'content-type': 'multipart/mixed; boundary="batch_foobarbaz"'},
                batch_response)
        ])

    def datafile(self, filename):
        f = open(os.path.join(os.path.dirname(settings.BASE_DIR),
                 'udemy/mobile/tests/' + filename),
                 'r')
        data = f.read()
        f.close()
        return data

Might be good to add to the docs for HttpMockSequence, although the tests are another form of documentation (just harder to find!). Anyway, thanks for the tests!


Default Behavior for launch function defined using @autogluon_register_args

Issue Tracker for today's talk:
Dummy reporter should be automattically provided during the function call, which enables user to lanch a single run for debug purpose.

addressed


Add --no-verify flag

It is possible that acme_tiny.py runs on a webserver which can't
connect to it's own loadbalancer from the inside. The --no-verify
will skip the local verification step.

See https://github.com/diafygi/acme-tiny/pull/107

Is this still a "very uncommon case"?

I agree with your comment on the other thread about it not being necessary to continue verifying it after the initial setup, but I also agree that this isn't a common enough issue to justify adding a new option. My suggestion would be to remove the verification step entirely and provide an external means to verify your server setup. This would solve your issue while also making acme-tiny easier to audit.

This will remove ~10 lines of code - I like that plan.

Just used the fork to sign my cert. Why has this not been added to the master?

@diafygi stated in #107 that this is an uncommon case :-(

Awesome project btw. :)
I don't think the use-case for --no-verify is that uncommon. As mentioned in #122, the number of related issues/PRs is also climbing.
I'm not 100% sure which I'd prefer - but I'm leaning toward adding the flag. The two choices (excluding the choice of simply leaving it alone) are as follows:
a) remove the verify code
b) add the --no-verify flag
Pros of removing the verify code:

Less code with similar end-result
Pros of adding the --no-verify flag:
Magnitudes-quicker running/debug time with a bad config
No unnecessary load on the ACME service

hello
i'm a (nearly) completely happy user of acme-tiny :)
but i too ran into this problem, "fixed" it myself in the code and wanted to send you a pull request only to see that there are already three open for the exact same feature.
our setup is as follow:
firewall ---> imap/webserver
with the two servers beeing on different machines but in the same subnet.
now when letsencrypt wants to verify the certificate for the imap server, i simply redirect on the firewall the requests to port 80 of the webserver and i'm fine. but not when the webserver itself wants to do the same thing... i don't wanna install an webserver on the other machine either (not to speak of an additional firewall in front of it...) so it would be cool to have this --no-verify flag :)
just in case you needed other cases where this problems occure, maybe it isn't that uncommon :)
thx!

In Wikimedia's beta cluster, we have Varnish listening on HTTP and Nginx on HTTPS, with Varnish redirecting these HTTP acme-challenge requests to HTTPS.
But of course, until you have a valid certificate set up, Nginx will be serving a broken self-signed certificate, causing urllib to throw an exception unless you use a hack like https://gerrit.wikimedia.org/r/#/c/247587/3/modules/letsencrypt/files/acme_tiny.py
This would also be helpful in our case.

@andreasscherbaum could you please do PR to my fork, https://github.com/frezbo/acme-tiny

@frezbo Looks like you got it integrated already?

@andreasscherbaum I forgot that I applied your patch previously, it has been a great help, i was getting errors when running script, thanks to you everything is resolved.

Good evening,
I run in exactly the same issue described in #11. It could be resolved only trying the steps  xxdesmus mentioned in comment- 162134072.
In my case internal and external DNS resolution is working just fine. I would like to see this PR merged.
Kind regards,
Tronde

@Tronde check my fork of acme-tiny, i have merged the --no-verify option.

@frezbo Thanks for your hint. I just started using your fork as well.

 Got me though, I didn't read the source. I guess that's the joke....
How on earth is this considered ok? It means the well-known location has to be configured system-wide instead of vhost-wide. Does the script even pass the HOST header properly to hit vhosts? That means I now have to automate commenting out the default server for nginx...

Added --disable-check option in 4.0.0+


Add prop to disable opening images in a new tab

Ref: https://github.com/bigbinary/neeto-kb-web/issues/4574

[ ] Add a openImageInNewTab prop (true by default). If it is falsy, the rendered images should not open in a new tab when clicked.
[ ] Add a data migration in neetoKB to rollout this behaviour to all the images.

Refer: https://vimeo.com/853679057/ca6ab51d56
@gaagul _a

@AbhayVAshokan Since we are already in the works of running a migration to update the structure of images in neetoKb, I think it will be better if we update the existing migration to make this small change in styles instead of running a whole new data-migration, Please let me know your thoughts on this.

Agreed. Please add the necessary changes and mention the same as a comment


Autofocus search box on load

What's the issue with setTimeout? Why complicate the code?
Promises are good (ahem, debatable) when the logic is reactive and long and
confusing. What's being done here is simple stuff.
On Apr 3, 2017 19:28, "Milind L"<EMAIL_ADDRESS>wrote:

@milindl commented on this pull request.
In frontend/src/app/components/search/search.component.ts
https://github.com/pclubiitk/student-search/pull/8#discussion_r109423087
:

@@ -106,6 +107,7 @@ export class SearchComponent implements OnInit {
this.years = year.filter(this.onlyUnique).sort();

   this.loading = false;

 setTimeout(_=>{this.searchBox.focus();});

Consider using a Promise if that is possible?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pclubiitk/student-search/pull/8#discussion_r109423087,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ75pM_WOMoI95uBMp0TiL-fhPDGbqX9ks5rsPrkgaJpZM4Mw-ds
.

lgtm 👍

When and how will this be deployed?

Good Question. I wanted to ask you about this :P . We have an automated docker build, but once its finished, we have to manually deploy this. Is there a better way of doing this? (webhook received by nginx does some stuff?)

Yes, we have an internal CI, which can do some privileged stuff. @sakshamsharma should create an account for pclub stuff. We can create secret private keys and deploy it onto pclub servers by relaunching dockers.

The webhook way is doable as well.
It was described here when I wrote about the internal deployment of pclub.in using webhooks and secret deploy-keys stored in travis (not git tree).
I'll create an account on jenkins when I restart the docker tomorrow, along with a volume mount.

The link where you have described is actually too complex compared to what we have to do in Jenkins. In jenkins, you can create a secret resource and inject it as part of the job. I can walk through this whenever @yashsriv is free after you reboot jenkins.
OT: I thought it was @navya/hackconf that inspired you to do the static deployment with encrypted keys via travis (I remember discussing some aspects of this with you). But saw that you have credited it to a different gist: https://gist.github.com/domenic/ec8b0fc8ab45f39403dd )


Additional template engine support

Hello everyone,
I don't know if there's a specific reason to choose nunjucks over other template engines, but wouldn't it be nice to give users a chance to choose their favourite template engine?
There're nice alternatives to nunjucks, here you can find the list of most commonly used/followed* ones:

Pug.js/Jade (10,244 stars)
handlebars (9,891 stars)
mustache.js (8,988 stars)
Hogan.js (4,378 stars)
doT.js (2,613 stars)
Swig (2,401 stars)
EJS (2,656 stars)
dust.js (1,471 stars)
twig.js (801 stars)

I hope you can at least consider this request. Many others who uses Express or Koa for some time are not familiar with nunjucks unless they didn't integrate it themselves. And this makes things a bit harder than they should for beginners. For example recursive includes and layouts and partials are not that much easy to manage as pug or handlebars in nunjucks.
*: number of stars as of 2016-03-06

@gokaygurcan Nunjucks has support for almost everything you would ever need and if something is missing, i would love to consider that.
Now couple of reasons why not the option of multiple templating engines

Koa/Express are simple ( nice ) libraries and have very different nature from Adonis, so i will not make any comparisons here.

Adonis is tightly coupled, let's take the example of CSRF protection http://adonisjs.com/docs/2.0/security#csrf-protection. Now Adonis gives you a pre-built helper to put CSRF tokens right into your views, without any extra effort. Giving the choice of 100 different template engines will remove this flexibility.

At the end, my goal is not take the functionality away, but to spend my hardwork on build stable solutions, which should save everyone's time. And keeping everything open will add a lot of unnecessary boilerplate and you have configure everything to get started

Thanks for your reply.
I'm not saying that nunjucks doesn't have any of these features. I'm just saying that it's hard to use than the rest of them. If, for instance, CSRF protection is the reason to use nunjucks, I'd rather implement it in a custom way and go with handlebars. It's probably not the whole reason though, so, anyways.
Maybe this is my lack of knowledge but this is really hard to do in nunjucks when compare it with handlebars for example:
https://gist.github.com/gokaygurcan/96d2253058bfafe43319
(it doesn't allow me to create sub-directories, so all - characters are actually /characters)
Again, I don't want to have 100 different options. But it would be nice to have at least one or two more. I just listed the most common ones so maybe people can say their opinion or something. Sticking with one option, which is not that much common and widely used, is not a good thing for this kind of project imho.

Sorry i don't see any point in including multiple templating engines.

Okay, good luck.

@gokaygurcan Pug was a must-have for me (lots of mixins I use across projects/platforms), so I've written a simple pug provider for adonis https://www.npmjs.com/package/adonis-pug
It should be straight forward to write your own for other engines

Hey @webdevian,
Thanks for letting me know. I'm more into Sinatra-like frameworks. That and the authors response made me decide to move away from Adonis.

Nunjucks takes approximately 5 minutes to learn, if you cannot spend this time to use a new framework that not the author problem. 😄

I don't agree but also don't want to make this become a pissing contest. As you said earlier,

Pug was a must-have for me
Handlebars is the same to me. Since the author had no plans for it, I didn't spent my precious time on it.

Yes, I spent some time on Nunjucks, also created a PR to make it supported in express-generator package too. But Adonis is not a long term solution for me. And here we are now.
Thank again for unofficial Pug support. And I believe the keyword is unofficial in this context ;)


math_brute_force: Factor out GetTernaryKernel

Use a common function to create the kernel source code for testing 3-argument math builtins.  This reduces code duplication.  1-argument and 2-argument math kernel construction will be factored out in a future PR.
Change the kernels to use preprocessor defines for argument types and undef values, to make the CTS code easier to read.
Co-authored-by: Marco Antognini<EMAIL_ADDRESS>Signed-off-by: Marco Antognini<EMAIL_ADDRESS>Signed-off-by: Sven van Haastregt<EMAIL_ADDRESS>

Merging as agreed on the October 4th teleconference.


Insufficient privileges when changing settings on my own project

Component
server
Describe the bug
Using Gitea and the latest Woodpecker, I added some projects and am able to run CI jobs on them. However, whenever I change settings, like the timeout, it says I have insufficient privileges. I only have the one user.
System Info
{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-4891f104"}

Additional context
Thank you!

Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server.

Confirming with same setup here, Woodpecker from master with Gitea.
Additional info: You don't even need to change the settings, just saving them (PATCH https://<woodpecker>/api/repos/<org>/<repo>) returns a 403 with the body Insufficient privileges.

This bug was maybe introduced by #513

@sometato can you tell us what username you use on gitea (login) & the config to start woodpecker server
if you dont want to tell the username please replace it with "sometato" or so

ok found the issue - if you are no woodpecker-admin and do change IsTrusted or Timeout ... it will fail due to permission
https://github.com/woodpecker-ci/woodpecker/blob/5e6b38e0e701e25b3a7cfd5dade3df0e16c7781d/server/api/repo.go#L111-L114
I'll create a "hotfix" but we need to address this with different anlages:

disable with hint in UI if it need instance-admin permissions
make these values configurable (not as now just hard coded)

Awesome! Thank you so much!
Is there a woodpecker-server image I can use to test this out with?

Awesome! Thank you so much!
Is there a woodpecker-server image I can use to test this out with?

You can test the latest master with `:next|

You can test the latest master with :next

It works, thank you!


Change the response format from logger output to a structured JSON response

By using a JSON response format, this allows uniqush clients to know if the API was successful.
API clients will be able to easily determine the reason an API failed, without resorting to heuristics (checking if the response contains a certain string).
Additionally, it is much easier for clients to process the outcome of a push, when a push involves more than one device.

bump version from 1.5.x to 1.6.0, since the API response format changed. No change in functionality or api request format. (or should this be a major version change, instead?)

(This is mostly the same as what we use internally.
The original author's commits were edited to remove a field that wasn't used by upstream.
Additionally, go fmt was run on every commit, and some commits were squashed)
Barely related to issue #55 (Related in the sense that the responses are much easier to parse)
Also fixes #71
Examples
Example return value of /subscribe (after indenting), with fake data
{
  "errorMsg": null,
  "code": "UNIQUSH_SUCCESS",
  "requestId": null,
  "service": "fooserv",
  "from": "a.b.c.d:39317",
  "subscriber": "foo.1234",
  "pushServiceProvider": "apns:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
  "deliveryPoint": "apns:bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb",
  "messageId": null
}

Example return value of /push
{
  "droppedDetails": [],
  "failureDetails": [],
  "successDetails": [
    {
      "code": "UNIQUSH_SUCCESS",
      "requestId": "56c3cb5f-RnIk4aFK4c7xKjcwtt143Q==",
      "service": "fooserv",
      "from": "a.b.c.d:37360",
      "subscriber": "foo.1234",
      "pushServiceProvider": "apns:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
      "deliveryPoint": "apns:bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb",
      "messageId": "apns:apns:cccccccccccccccccccccccccccccccccccccccc-78"
    }
  ],
  "droppedCount": 0,
  "failureCount": 0,
  "successCount": 1,
  "date":<PHONE_NUMBER>,
  "type": "Push"
}

Example return value of /addpsp:
{
  "details": {
    "code": "UNIQUSH_SUCCESS",
    "messageId": null,
    "deliveryPoint": null,
    "pushServiceProvider": "apns:8fa8483afc5f4461117c8c2d61b36e7b6c8d3eb2",
    "subscriber": null,
    "from": "<IP_ADDRESS>:42532",
    "service": "myservice",
    "requestId": null
  },
  "status": 0,
  "date":<PHONE_NUMBER>,
  "type": "AddPushServiceProvider"
}

EDIT: the comment about including errorMsg was outdated - this wasn't part of the original commit. It was added later, as part of a larger change.

Code lgtm otherwise, I mean we have reviewed this extensively and are running it on production :) I'd say let's bump the version to 2.0.0. Could you perhaps rebase+squash David Jeong's commits, too?

Squashed David Jeong's commits.
Updated the version to 2.0.0.
Printed newline after the curl response in apns-test.sh(The response itself no longer ends with a newline)


DevTools can't inspect views that aren't windows or single view of a mobile app

For some reason it's now tightly coupled with application lifetimes (those aren't guaranteed to be present at all) and only shows windows or the main view. So it's no longer possible to inspect any embedded TopLevels.
Since it's a regression from 0.10.x I'm considering to revert https://github.com/AvaloniaUI/Avalonia/pull/6771

I don't agree to copletaly revert the PR. Original PR can manage both path, see this. If you want, I can fix the current behavior to handle both molality.

Hi, @kekekeks
What  is issue you found?
I have moditfy following file:
./samples/MobileSandbox/App.xaml.cs
    public class App : Application
    {
        public override void Initialize()
        {
            AvaloniaXamlLoader.Load(this);
        }

        public override void OnFrameworkInitializationCompleted()
        {
            if (ApplicationLifetime is IClassicDesktopStyleApplicationLifetime desktopLifetime)
            {
                desktopLifetime.MainWindow = new MainWindow();
            }
            else if (ApplicationLifetime is ISingleViewApplicationLifetime singleViewLifetime)
            {
                singleViewLifetime.MainView = new MainView();
            }

            base.OnFrameworkInitializationCompleted();
+            this.AttachDevTools(new()
+            {
+                StartupScreenIndex = 1,
+            });
        }
    }

./samples/MobileSandbox.Desktop/Program.cs
 using System;
 using Avalonia;
+using Avalonia.Controls;
+using Avalonia.Controls.ApplicationLifetimes;

 namespace MobileSandbox.Desktop
 {
     static class Program
     {
         [STAThread]
-        static int Main(string[] args) =>
-            BuildAvaloniaApp()
+        static int Main(string[] args)
+        {
+            var lt = new MyClass();
+            var app = BuildAvaloniaApp()
                 .StartWithClassicDesktopLifetime(args);
+            lt.Start();
+            return app;
+        }

         /// <summary>
         /// This method is needed for IDE previewer infrastructure
@@ -18,4 +25,17 @@ public static AppBuilder BuildAvaloniaApp()
                 .UsePlatformDetect()
                 .LogToTrace();
     }
+
+    class MyClass : ISingleViewApplicationLifetime
+    {
+        public Control MainView { get ; set; }
+        public void Start()
+        {
+            var host = new MainWindow()
+            {
+                Content = MainView,
+            };
+            host.Show();
+        }
+    }
 }

And i try run, it work as expected.

try attaching devtools to a window when running without application lifetime
try attaching devtools to embedded toplevels in WindowsInteropTest test app

Note, that application lifetimes has always been an entirely optional feature and is documented as such. Even ApplicationLifetime is nullable. Nothing in the framework should break if there is no registered lifetime.
This is important for various embedding scenarios like this one:
https://user-images.githubusercontent.com/1067584/218268515-ede3a3d6-2e20-46ad-83da-4a77353fe4cc.mp4

OK! I got it. Can you give me a sample repo to try and fix this?

@workgroupengineering
AppMain.zip
[STAThread]
public static void Main(string[] args)
{
    BuildAvaloniaApp().Start(AppMain, args);
}

private static void AppMain(Application app, string[] args)
{
    app.Run(new MainWindow());
}

public static AppBuilder BuildAvaloniaApp()
    => AppBuilder.Configure<App>()
        .UsePlatformDetect()
        .LogToTrace();


A few StateMachine unit tests don't fully test what they purport to

I'm not sure if this is right place to report this, because it's not a bug in the app itself, but it's an issue I noticed in the unit tests, which I think may be considered a bug.
As a specific example, consider the TestCursorKeysMode test in OutputEngineTest.cpp:
TEST_METHOD(TestCursorKeysMode)
{
    StatefulDispatch* pDispatch = new StatefulDispatch;
    VERIFY_IS_NOT_NULL(pDispatch);
    StateMachine mach(new OutputStateMachineEngine(pDispatch));

    mach.ProcessString(L"\x1b[?1h", 5);
    VERIFY_IS_TRUE(pDispatch->_fCursorKeysMode);

    pDispatch->ClearState();

    mach.ProcessString(L"\x1b[?1l", 5);
    VERIFY_IS_FALSE(pDispatch->_fCursorKeysMode);

    pDispatch->ClearState();
}

The second half of this test is assumedly meant to prove that the given escape sequence will reset the cursor keys mode. However, the _fCursorKeysMode flag is false by default, so you could replace that escape sequence with almost anything, including removing it altogether, and the test would still pass.
There are similar problems with TestCursorBlinking, TestCursorVisibility, and possibly also TestAltBufferSwapping.
When I added a similar test, I got around the problem by explicitly setting the flag I was testing to the opposite of what was expected, but I'm not sure if that is the best approach. Another possibility might be using std::optional<bool> instead of just a bool, so the default value could then be a nullopt, and it wouldn't be possible to pass the test based on the default value alone. The downside of that approach is the VERIFY steps become a little more complicated.

To add: this is the right place to report this. There certainly are lots of test gaps, and places where our infrastructure could be improved. Any contributions to help us catch those and fix them is greatly appreciated :)


feat: support SARIF as the reporting format

Description
SARIF is the industry standard for vulnerability reporting and should be adopted as the de-facto report format.
Use Case
Ability to import SARIF reports into 3p tools i.e. CodeCatalyst.
Proposed Solution
Change/add a new output format for reports using SARIF.
Other information
No response
Acknowledge

[X] I may be able to implement this feature request
[ ] This feature might incur a breaking change

This would be nice to have, but I don't think it's currently possible for a few reasons.

cdk-nag only works within the constraints of Aspects. There is no way to know in advance what the "last Aspect" is which is why a CSV format is used. We can append to the end of a file, but can't do any post processing

Aspects currently don't have the concept of line numbers or files, errors are reported on construct path. Line numbers and file location are required for SARIF


launch.bat not working

line 10, in
from playsound import playsound
ModuleNotFoundError: No module named 'playsound'

RUN CMD
pip install playsound


Matcher to check if a list contains an item with a cetain property set to a value

Hi!
I have a feature request. I have a list of objects and would like to verify that one of the items has a specific property with a certain value. Kind of like this:
usersList shouldContainItemWith(User::id equalTo adminUserId)
This could also be inverted to verify that the items do not contain an item with a certain value, e.g. to verify that something has been removed from the list of items.
Is there an existing way of doing this? If not, do you want me to create a pull request?

Try shouldExist
On Wed, 9 Oct 2019 at 09:57, Christopher Dambakk<EMAIL_ADDRESS>wrote:

Hi!
I have a feature request. I have a list of objects and would like to
verify that one of the items has a specific property with a certain value.
Kind of like this:
usersList shouldContainItemWith(User::id equalTo adminUserId)
This could also be inverted to verify that the items do not contain an
item with a certain value, e.g. to verify that something has been removed
from the list of items.
Is there an existing way of doing this? If not, do you want me to create a
pull request?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kotlintest/kotlintest/issues/1039?email_source=notifications&email_token=AAFVSGR5Q44YRQOAHJLJNALQNXWM7A5CNFSM4I7AUGDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HQVHMTQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFVSGWKDMFZXASL3HEEFVDQNXWM7ANCNFSM4I7AUGDA
.

You are right,
usersList shouldExist { user -> user.id == adminUserId }
gives the same result. Although I feel like the code my first comment is more readable, it is not worth a pull request.
Thanks!

You could do usersList.forSome { it.id shouldBe adminUserId } as well
On Wed, 9 Oct 2019 at 13:49, Christopher Dambakk<EMAIL_ADDRESS>wrote:

You are right,
usersList shouldExist { user -> user.id == adminUserId }
gives the same result. Although I feel like the code my first comment is
more readable, it is not worth a pull request.
Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kotlintest/kotlintest/issues/1039?email_source=notifications&email_token=AAFVSGWD3KJT2ZJOBOWRG3DQNYRUDA5CNFSM4I7AUGDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY5VRI#issuecomment-540138181,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFVSGTLCUPTJ3TYXBLJC5TQNYRUDANCNFSM4I7AUGDA
.

forSome would not give the expected result in our situation, it will not succeed if our admin user is the only user in the list.
On another note, I notice that description for both shouldExist and forSome are missing from the list of matchers found here: https://github.com/kotlintest/kotlintest/blob/master/doc/matchers.md
Is it coming or should it be created a new issue?

forSome is documented on the inspectors page as it's not a matcher.
It should work for your use case, even if the admin is the only user.
On Fri, 11 Oct 2019 at 01:22, Christopher Dambakk<EMAIL_ADDRESS>wrote:

forSome would not give the expected result in our situation, it will not
succeed if our admin user is the only user in the list.
On another note, I notice that description for both shouldExist and
forSome are missing from the list of matchers found here:
https://github.com/kotlintest/kotlintest/blob/master/doc/matchers.md
Is it coming or should it be created a new issue?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kotlintest/kotlintest/issues/1039?email_source=notifications&email_token=AAFVSGXZH4J22HS63ILGUGDQOALQPA5CNFSM4I7AUGDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA66PEY#issuecomment-540927891,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFVSGUV5AOTM3RX6GVSFYDQOALQPANCNFSM4I7AUGDA
.

Ah, I see, I found it under inspectors. But as it is described there: "if NONE pass or ALL pass then we consider that a failure" - meaning that if the admin user is the only user in the list, it will fail.
shouldExists was the way to go in our case 👍 But I still miss a description of it under Collections on the matchers page. I looked there when writing my test and ended up writing my own matcher which did the same. :)

@Kerooker we should link to inspectors under the collections matchers section so it's more obvious they exist.
@Dambakk We probably need a forSomeOrAll whatever that is, forAtLeastOne ?


Scaled icon.ico so it's actually used

Scaled icon.ico so it's actually used (rendered icon.ico into the icon folder with all the different sizes in gimp)
no cl no fun
only remaining things that need to be changed are Resources/Textures/Logo/logo.svg and BuildFiles/Mac/Space Station 14.app/Resources/ss14.icns but both of those need the original vector graphic for the logo which I don't have but can recreate if needed.

I think this somehow instead crashed the server, doubt it.


linux support

hi @TheCherno !
was wondering if this project will also be suitable for linux.
i honestly just cant afford a decent windows laptop.
Best,
Andrew

I would suggest you have a look at PR #27 this shows/discusses the necessary changes to make the project work on Linux.

Glfw, imgui and glad are crossplatform so the only thing you need to do is change up how to compile the project. The dllexport atuff works differently on linux

Closing since the question has been answered.


Need to add a handler to check the SSL handshake completion event

Description:
We need to add another handler to check the state of the SSL handshake completion event. And we need to add the rest of the handlers to the pipeline only after checking whether the SSL handshake has completed successfully. Other wise client will start writing the request even though the SSL handshake has failed.

Closing the issue as this is fixed without adding a handler.


chore(deps): update dependency @types/aws-lambda to v8.10.116

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@types/aws-lambda (source)
8.10.115 -> 8.10.116

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "after 8am and before 5pm every weekday" (UTC).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: terraform-module/edge-lambdas/pnpm-lock.yaml
 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your pnpm version is incompatible with "/tmp/renovate/repos/github/pleo-io/spa-tools/terraform-module/edge-lambdas".

Expected version: 8.x
Got: 7.32.4

This is happening because the package's manifest has an engines.pnpm field specified.
To fix this issue, install the required pnpm version globally.

To install the latest version of pnpm, run "pnpm i -g pnpm".
To check your pnpm version, run "pnpm -v".

 You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Incorrect expression

0 0 12 1 1/2 ? *
At 12:00 PM, on day 1 of the month, every 2 months
Error:
Fatal error:  Uncaught InvalidArgumentException: 6 is not a valid position

Hello @donriga !
This package is no longer being worked on, and has moved over to https://github.com/dragonmantank/cron-expression. If possible, please upgrade to the newest version of dragonmantank/cron-expression.
As for this issue, it looks like you have 7 parameters in your expression... depending on the version of his library you are using, you can only have 6 (with the 6th position being Year, which is now removed). The error is badly worded, as it's saying that the 6 position in the array is not valid, but it's counting starting at 0 like a normal PHP array.


Makefile stop stripping v-prefixed tags.

Current coverage is 65.60% (diff: 100%)

Merging #290 into master will not change coverage

@@             master       #290   diff @@
==========================================
  Files           132        132
  Lines          6753       6753
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           4430       4430
  Misses         1964       1964
  Partials        359        359

Powered by Codecov. Last update be44476...3870189


Vault preferres HCL

Hello,
Hashicorp wants to use HCL instead of JSON for configuration. There is also a comment about this problem also here and I've added to a comment here too.
I had to switch from the Debian package to the Archive method, which is not a problem but it took a bit time, to understand, why it wasn't working. After the switch and getting most parts up and running, I tried to add service registration to Consul, but the JSON wasn't parsed correctly.
It seems, it wasn't fixed correctly, as I still get:
2022-11-04T11:35:23.879+0100 [WARN]  unknown or unsupported field consul found in configuration at /etc/vault/config.json
2022-11-04T11:35:23.879+0100 [INFO]  proxy environment: http_proxy="" https_proxy="" no_proxy=""
2022-11-04T11:35:23.887+0100 [INFO]  core: Initializing version history cache for core
2022-11-04T11:35:23.889+0100 [INFO]  core: raft retry join initiated

with:
    extra_config      => {
      cluster_addr => "https://${::fqdn}:8201",
      api_addr     => "https://${::fqdn}:8200",
      service_registration =>  {
         consul            => {
          address           => "${::fqdn}:8501",
          token             => $consul_agent_token,
          scheme            => https,
          tls_cert_file     => $tls_cert_file,
          tls_min_version   => 'tls12',
          tls_cipher_suites => 'TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_RSA_WITH_AES_256_GCM_SHA384,TLS_RSA_WITH_AES_128_GCM_SHA256',
          service_tags      => "vault",
        }
      }
    },

It works, but the message "unknown or unsupported field consul found" is still there. And also the question is .. how to handle the systemd file, when install_method package / repository is used.
cu denny

I created my own vault module to manage our vault instances at my job, which outputs HCL. I will get a PR started to add HCL output to this module. Some of my code is pretty opinionated, so hopefully, @bastelfreak doesn't mind too much and we can merge the two modules into one.

It's even worse, I just tried to install, spent 2 hours not understanding why my parameters from the module weren't used -- there is a /etc/vault.d/vault.hcl which is used and the config.json is completely ignored.
If you try to delete the vault.hcl file, vault refuses to run:
Jan  8 14:54:58 vault systemd[1]: vault.service - "HashiCorp Vault - A tool for managing secrets" was skipped because of an unmet condition check (ConditionFileNotEmpty=/etc/vault.d/vault.hcl).
It's /lib/systemd/system/vault.service has a condition to forbid it to run if the hcl file is not present...
ConditionFileNotEmpty=/etc/vault.d/vault.hcl
As is, the puppet-vault module is totally unusable.

The problem with HCL is that, as far as I know, there's no native way in Ruby nor Puppet to generate it. For JSON, we can just use a Puppet Hash and throw it into to_json_pretty(). That makes it quite simple to manage it.

As is, the puppet-vault module is totally unusable.

To be fair that's not true. it depends which package you're using. If your source add the condition I suggest to use a systemd::dropin_file that clears ConditionFileNotEmpty or adjusts the file ending.
If someone has an idea for easy HCL generation I'm happy to talk about it.

Agreed, my comment was a bit harsh, sorry. Probably a result of the lost time.
The source is the debian repo for hashicorp, configured by this module via the hashi_stack module, so nothing fancy here, just the last official source :/
root@vault:~# apt-cache policy vault
vault:
Installed: 1.15.4-1
Candidate: 1.15.4-1
Version table:
*** 1.15.4-1 500
500 https://apt.releases.hashicorp.com bookworm/main amd64 Packages
100 /var/lib/dpkg/status
In order to use the config.json...
root@vault:/etc/vault.d# ls -l
total 8
-rwxr-x--- 1 vault vault  276 Jan  8 13:20 config.json
-rw-r--r-- 1 vault vault    0 Dec  5 02:49 vault.env
-rw-r--r-- 1 vault vault 1053 Jan  8 14:54 vault.hcl.orig
Commenting out the condition gives:
Jan  8 15:39:40 vault vault[12899]: error loading configuration from /etc/vault.d/vault.hcl: stat /etc/vault.d/vault.hcl: no such file or directory
... aaaand I found out why.
I use:
vault::install_method: 'repo'
Which gives in manifests/config.pp:
'repo':    { $real_manage_service_file = false }
So...
vault::manage_service_file: true
Jan  8 15:59:58 vault (vault)[13955]: vault.service: Failed to locate executable /usr/local/bin/vault: No such file or directory
So:
vault::bin_dir: '/usr/bin'
Did the final trick.
For the HCL, besides a ERB template (like the ntp module), I have no idea.


Remove references to auto-generated in Monitoring README

What
Change these lines in the NodeJS Monitoring README. Do not explicitly state that it is an auto-generated library. Also, do not say that "a handwritten layer is not yet available".
Why
GAPIC-only libraries will become the norm as the code generators become capable of producing client libraries faster than we can hand-write them. We do not want to lead with calling them "auto-generated", since that can have negative connotations and is not the defining feature of the library design.
Stating that "a handwritten layer is not yet available" suggests that one might eventually be available. We don't want to lead developers to believe that they might eventually have a different surface to work with (apart from major version updates).
Notes
@callmehiphop I think @landrito originally did this, but I could not assign this ticket to him. Could you or @stephenplusplus give him, @jmuk, and @swcloud the necessary permission to own issues here? Thanks!
FYI @omaray

I wrote those lines, and I think the distinction is very important currently, as there are no docs for the generated API or precedent for an API that doesn't have our conventions; most popularly, the hierarchy between resource types in any given API, i.e. Storage > Bucket > File (storage({ auth }).bucket('bucket-name').file('file-name')) and the ways you can stat/interact with them (object.get(), object.getMetadata(), object.exists(), object.delete(), etc).

Do not explicitly state that it is an auto-generated library.

Why not?
I think a document or addition to the README would be very welcome to explain how we intend to mix autogenerated and generated APIs. And if we're not ready for that yet, which I assume we aren't, I think the Monitoring document in its current form is an appropriate way to communicate the state of things now.

Stating that "a handwritten layer is not yet available" suggests that one might eventually be available. We don't want to lead developers to believe that they might eventually have a different surface to work with (apart from major version updates).

I agree on that. I assumed at the time we were going to offer handwritten layers for all generated APIs. Changing this to simply "a handwritten layer is not available for this API." is sufficient.

Mainly because "auto-generated" is not a selling point and isn't the defining feature of the layer. We are currently kicking around better terms to use for the various layers. I'm okay with acknowledging that Monitoring does not have a layer that the other client libraries have, as long as it doesn't sound like it's a sub-optimal experience as a result. I'm interested in @omaray's opinion on this issue.
BTW, if there are idioms that you're using across all/most APIs, we should discuss what they are and whether we can move them into GAPIC/GAX.

Gotcha, that makes sense. Any names you're considering that you want to share here? Maybe some more eyes on it would help spark some winners. What are the defining features of the generated APIs, from a non-contributor's perspective?
On the idiom note, I'll kick off an issue on the gax repo.

I don't think there's anything secret about it, and I agree that more eyes & brains would generate better results. Let me check with my teammates before exposing their brainstorming to the whole world. :)
Thanks, Stephen.

Issue sent over in https://github.com/googleapis/gax-nodejs/issues/71

Thanks, Stephen.

The README has been updated to use a template made by @omaray. I made a PR to our staging repo to show the change. @bjwatson does the contents of this readme work for you?

@landrito I'm referring to the hand-written README for the google-cloud-node repo.

@stephenplusplus https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2526 didn't fix this issue.
Whether or not we want to fix this is up to @omaray and @lukesneeringer. It's a product messaging decision.

cc @eoogbe who marked that PR as a fix for this issue (which is why it was auto-closed when the PR merged)

As far as I can tell, the README no longer has the offending lines, so this should be closed.

https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2526/files#diff-04c6e90faac2675aa89e2176d2eec7d8R625

Oh that README. I didn't even notice it was there. Sorry about that.

The new location has no mentions of auto-generated: https://github.com/googleapis/nodejs-monitoring


Nightly builds

Find a way to do automatic nightly builds

https://www.electron.build/auto-update
guides:
https://medium.com/how-to-electron/how-to-add-auto-updates-to-your-electron-application-an-up-to-date-guide-d62794a0467d

windows autoUpdate seems to be different
https://blog.avocode.com/get-that-damn-windows-auto-update-working-on-electron-b60945a6cfdf

http://bretahajek.com/2016/11/electron-builder-appveyor-travis-ci-memory-king/

@Skytrias looks like your comments really pertain to #16 though I have yet to read the links.

https://github.com/electron-userland/electron-builder/blob/master/docs/multi-platform-build.md

https://github.com/electron-userland/electron-build-service

It appears to suggest travis and appveyor can do the builds for us.
Also I can use docker so I don't have to log into windows to constantly build.
Builds are slow but I think that is simply due to creating the asar file.

https://docs.travis-ci.com/user/deployment/releases/

https://github.com/electron-userland/electron-builder/issues/1751

i think nigthly builds arent something were looking into anymore right?


fix some typos

I digged into the debugging code and found some typos, I fixed them.
There is actually a misspelled property, I just added a todo note, so extensions won't break.

@jens1o,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@jens1o, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

@jens1o Thanks
@alexandrudima you might want to fix the typo Jens found

Thanks! Done!