Fix the emote_tag=None issue

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

For (future) reference, the traceback: https://gist.github.com/pajlada/e99162e23c849d43a864b1650f12f239


Defunct project?

Ahoy!
Is this project still in use or under development?
If it’s run its course - I’m interested in the “pwm” package name on Pypi for a generic “Pulse Width Modulation” wrapper.
Thank you.

very gentle nudge


[bug]: Unable to download models from CivitAI

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Linux
GPU vendor
Nvidia (CUDA)
GPU model
No response
GPU VRAM
No response
Version number
next
Browser
FF
Python dependencies
No response
What happened
I cannot seem to download most models from CivitAI. I get an error like this:

Test install URLs, all seem to be parsed by the installer properly but all give the same kind of error:
https://civitai.com/models/323284/mandelbrot-fractal-style-sdxl
https://civitai.com/models/5952/experience?modelVersionId=137204
https://civitai.com/api/download/models/362448?type=Model&format=SafeTensor
What you expected to happen
Models install from CivitAI
How to reproduce the problem
No response
Additional context
No response
Discord username
No response

It appears the CivitAI API has changed and now returns an array for this value instead of a string. This breaks our pydantic models. I didn't realize that we were implementing CivitAI's API schemas internally. That's bound to cause issues, we'll have to continually update our models as their API changes. Maybe metadata should just be a dict[str, Any]?

Civitai hasn’t changed its API documentation, so this is a bit annoying. I didn’t attempt to copy the API schema, but just pulled out a subset of fields that would be useful. I do not think we want to pull the entire JSON from Civitai because it is HUGE and filled with images and (sometimes ugly) comments.


Unneeded padding on warning component?

Noticed that the govuk-warning-text__text element has padding left that includes an extra 15px to compensate for a negative margin left (see below, dotted outline added by me to show boundary of component). Seems like this could be removed and the padding decreased, but there must be a reason for it?

Originally posted by @andysellick in https://github.com/alphagov/govuk-design-system-backlog/issues/71#issuecomment-443679660

For reference, it looks like this was copied from Elements.

Yep, but removing the negative margin and reducing the padding appears to be the same:
- margin-left: -$govuk-gutter-half;
- padding-left: 65px;
+ padding-left: 50px;

That's weird, I've asked Andy if he wants to do a PR for this...

I am busy, but I'd like to contribute (if only to experience the process) so I'll try to raise a PR soon (also it's not a huge change). Thanks!

@andysellick will leave this open for you when you get a second then.

@nickcolley @36degrees Do you think the icon should be vertically aligned to the middle of the paragraph, like in the example, or the top or the paragraph?

@nickcolley I just think it scans better if the icon is at the top of the paragraph. You would naturally scan left to right, not left, down, up, right...if you see what I mean.


Link Rot: navy.mil

The following links are returning non-successful (non 2**, 3**) status codes. This ticket serves as a reminder of the problem and gives an issue to link the "ignore" and "fix" commits.
Problematic Link(s): (Limit to one domain)

https://www.history.navy.mil/research/histories/ship-histories/danfs/m/mervine-ii.html

Issue Summary:

[ ] The entire domain seems to be having problems or is unreachable, expected to resolve on its own.
[ ] A link has been moved.
[ ] A link has legitimately been removed.
[ ] This is likely a routine aging of a short-link (or similar).
[x] Other, please note.

Appears to only be failing from the build machines.

Fixed in #87.


Parameters when transitioning states

It looks like there is currently no way to provide external information when transitioning states, I read the source code for send, and the examples (such as fetch) seem to internalise the external effect so that the data is available within effect. Apologies if I did a poor job of looking.
My use case is moving data from a subscription callback into the state machine. I need to manage an external lifecycle (add/remove subscriber), and data is supplied to me via callback to the subscriber. Firebase's realtime database is a concrete example:
const [state, send] = useStateMachine({firebaseValue: …})({
  initial: 'loading',
  states: {
    loading: {
      on: {
        SUCCESS: 'loaded',
        FAILURE: 'error',
      },
      effect(_, update, /* ??? */) {
        update(context => /* External value would be placed into the context here. */)
      },
    },
    // …
  },
})

React.useEffect(() => {
  // A hypothetical `send` API with parameters.
  const success = value => send('SUCCESS', value)
  const failure = error => send('FAILURE', error)
  const ref = firebase.database().ref('some/path')
  // Manage the subscriber lifecycle.
  ref.on('value', success, failure)
  return () => {
    ref.off('value', success)
  }
)

I realise it would be possible to achieve this with a ref, but I would prefer not having one foot in the door in terms of state and context.

Hi, good question. This is by design - Ideally, changing the state machine context is always a consequence of the state machine itself transitioning. It should never come from the outside.
You could instead make your whole firebase connection from within the state machine:

const [state, send] = useStateMachine({firebaseValue: …})({
  initial: 'loading',
  states: {
    loading: {
      on: {
        SUCCESS: 'loaded',
        FAILURE: 'error',
      },
      effect(send, update) {

        const success = value => {
          update(context => ({value, ...context}))
          send('SUCCESS')
        }
        const failure = error => {
          update(context => ({error, ...context}))
          send('FAILURE')
        }
        const ref = firebase.database().ref('some/path')
        // Manage the subscriber lifecycle.
        ref.on('value', success, failure)
        return () => {
          ref.off('value', success)
        }

      },
    },
    // …
  },
})

l

Thanks for the clear and detailed reply, @cassiozen!

Closing for now, please feel free to reopen.


[OpenStack] Errors of pkb.py when it excuted benchmarks

vi test.sh
export OS_USERNAME=admin
export OS_PASSWORD=admin
export OS_TENANT_NAME=admin
export OS_PROJECT_NAME=admin
export OS_AUTH_URL=http://<IP_ADDRESS>:5000/v2.0
source test.sh
nova list -> succeed
+--------------------------------------+----------------------------------------------+---------+------------+-------------+---------------------------------------------------------------------+
| ID                                   | Name                                         | Status  | Task State | Power State | Networks                                                            |
+--------------------------------------+----------------------------------------------+---------+------------+-------------+---------------------------------------------------------------------+
| 01249794-bfa7-4b21-be99-7f38a7a59cb7 | murano-clmonijmazrklz-gateway-1-rpy22hhl3w7q | ACTIVE  | -          | Running     | kkk-network-dcd0da153ea64e10a399bb50d7f6c451=<IP_ADDRESS>, <IP_ADDRESS> |
| a8ecea03-0820-4651-938f-b79c582240d9 | murano-clmonijmazrklz-kube-1-jb32dpvxxpjw    | ACTIVE  | -          | Running     | kkk-network-dcd0da153ea64e10a399bb50d7f6c451=<IP_ADDRESS>, <IP_ADDRESS> |
| dd2da4e5-5e49-45b3-9b79-799e44635214 | murano-clmonijmazrklz-kube-2-mlkgm22dfgw6    | ACTIVE  | -          | Running     | kkk-network-dcd0da153ea64e10a399bb50d7f6c451=<IP_ADDRESS>, <IP_ADDRESS> |
| 02349f64-be0e-425e-a4f5-991179deaf75 | murano-clmonijmazrklz-kube-3-h23riiwgkede    | ACTIVE  | -          | Running     | kkk-network-dcd0da153ea64e10a399bb50d7f6c451=<IP_ADDRESS>, <IP_ADDRESS> |
| 6f73bf01-fe76-4e90-a7c7-128778e4c586 | qemu-agent-base-image                        | ACTIVE  | -          | Running     | net04=<IP_ADDRESS>, <IP_ADDRESS>                                 |
| 8ac91c7d-8ac3-4ba0-93bf-e34869fd98d6 | test                                         | SHUTOFF | -          | Shutdown    | net04_ext=<IP_ADDRESS>; net04=<IP_ADDRESS>                        |
| ea1e7e40-5aef-4468-8dee-4fe4b54616cd | test11                                       | ACTIVE  | -          | Running     | net04=<IP_ADDRESS>; net04_ext=<IP_ADDRESS>                       |
+--------------------------------------+----------------------------------------------+---------+------------+-------------+---------------------------------------------------------------------+
and tcpdump has captured each communication's packets
20:32:29.668262 IP <IP_ADDRESS>.commplex-main > <IP_ADDRESS>.51162: Flags [.], ack 360, win 235, options [nop,nop,TS val 614597284 ecr 9164198], length 0
20:32:29.674133 IP <IP_ADDRESS>.54779 > <IP_ADDRESS>.8774: Flags [S], seq 239138154, win 14600, options [mss 1460,sackOK,TS val 9164200 ecr 0,nop,wscale 7], length 0
20:32:29.678780 IP <IP_ADDRESS>.8774 > <IP_ADDRESS>.54779: Flags [S.], seq<PHONE_NUMBER>, ack 239138155, win 28960, options [mss 1260,sackOK,TS val 614597286 ecr 9164200,nop,wscale 7], length 0
20:32:29.678821 IP <IP_ADDRESS>.54779 > <IP_ADDRESS>.8774: Flags [.], ack 1, win 115, options [nop,nop,TS val 9164203 ecr 614597286], length 0
20:32:29.679051 IP <IP_ADDRESS>.54779 > <IP_ADDRESS>.8774: Flags [P.], seq 1:238, ack 1, win 115, options [nop,nop,TS val 9164203 ecr 614597286], length 237
20:32:29.718431 IP <IP_ADDRESS>.8774 > <IP_ADDRESS>.54779: Flags [.], ack 238, win 235, options [nop,nop,TS val 614597297 ecr 9164203], length 0
But, When it excuted pkb.py with option parameters...that wasn't response communicatin packets.
[root@localhost ~]# tcpdump -ni eth0 host <IP_ADDRESS>
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on eth0, link-type EN10MB (Ethernet), capture size 65535 bytes
(No response w/ target ip)
./pkb.py --cloud=OpenStack --machine_type=m1.medium --image=TestVM --benchmarks=ping --openstack_public_network=net04_ext --openstack_private_network=net04
./pkb.py --cloud=OpenStack --benchmarks=unixbench --openstack_tenant=admin --openstack_username=admin --openstack_auth_url=http://<IP_ADDRESS>:5000/v2.0/
./pkb.py --cloud=OpenStack --benchmarks=unixbench --os_auth_url=http://<IP_ADDRESS>:5000/v2.0/
pkb.log
2016-01-28 20:51:31,619 143950a9 MainThread pkb.py:445 INFO     PerfKitBenchmarker version: v1.0.1-103-g5a2c738
2016-01-28 20:51:32,012 143950a9 MainThread pkb.py:402 INFO     Flag values:
--openstack_tenant=admin
--openstack_username=admin
--openstack_auth_url=http://<IP_ADDRESS>:5000/v2.0/
--cloud=OpenStack
--benchmarks=unixbench
2016-01-28 20:51:32,013 143950a9 MainThread publisher.py:524 DEBUG    Using publishers: [<LogPublisher logger=<logging.RootLogger object at 0x7fd2002cc3d0> level=20>, <PrettyPrintStreamPublisher stream=<open file '', mode 'w' at 0x7fd207de9150>>, ]
2016-01-28 20:51:32,129 143950a9 MainThread unixbench(1/1) disk.py:119 INFO     No legacy->new disk type map for provider OpenStack
2016-01-28 20:51:32,486 143950a9 MainThread unixbench(1/1) pkb.py:382 ERROR    Error during benchmark unixbench
Traceback (most recent call last):
File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/pkb.py", line 338, in RunBenchmark
spec.ConstructVirtualMachines()
File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/benchmark_spec.py", line 262, in ConstructVirtualMachines
vm = self._CreateVirtualMachine(vm_spec, os_type, cloud)
File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/benchmark_spec.py", line 344, in _CreateVirtualMachine
return vm_class(vm_spec)
File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 48, in init
self.firewall = os_network.OpenStackFirewall.GetFirewall()
File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/network.py", line 51, in GetFirewall
benchmark_spec.firewalls[key] = cls()
File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_network.py", line 35, in init
self.__nclient = utils.NovaClient()
File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/utils.py", line 116, in init
auth_token=self.__auth.get_token(),
File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/utils.py", line 61, in get_token
return self.GetConnection().get_token(self.__session)
File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/utils.py", line 47, in GetConnection
self.__authenticate()
File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/utils.py", line 51, in __authenticate
import keystoneclient.v2_0.client as ksclient
ImportError: No module named keystoneclient.v2_0.client
2016-01-28 20:51:32,494 143950a9 MainThread unixbench(1/1) pkb.py:510 ERROR    Benchmark 1/1 unixbench (UID: unixbench0) failed. Execution will continue.
2016-01-28 20:51:32,494 143950a9 MainThread unixbench(1/1) pkb.py:516 INFO     Benchmark run statuses:
Name       UID         Status
unixbench  unixbench0  FAILED
Success rate: 0.00% (0/1)
2016-01-28 20:51:32,495 143950a9 MainThread unixbench(1/1) pkb.py:518 INFO     Complete logs can be found at: /tmp/perfkitbenchmarker/run_143950a9/pkb.log
What do I focus of that resolution for perfkit test w/openstack ?

@mateusz-blaszkowski @meteorfox Can you of you respond to this.  Thanks.

@michael92437558

File "/usr/local/bin/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/utils.py", line 51, in __authenticate
import keystoneclient.v2_0.client as ksclient
ImportError: No module named keystoneclient.v2_0.client
2016-01-28 20:51:32,494 143950a9 MainThread unixbench(1/1) pkb.py:510 ERROR Benchmark 1/1 unixbench (UID: unixbench0) failed. Execution will continue.

Seems like you don't have the keystoneclient package with at least python-keystoneclient==2.0.0, try upgrading to 2.0.0.
pip install -Iv python-keystoneclient==2.0.0

Let me know how it goes. :)

@meteorfox Do we need to add python-keystoneclient to one of the requirements files? I don't see it in requirements-openstack.txt or requirements.txt.

@noahl python-novaclient pulls the keystoneclient package as well. What I'm thinking is that they have an old version of the novaclient which is probably why they have an old version of keystoneclient.

@noahl We could pin the dependencies to a particular version instead of always getting the latest.
I've tested on my lab with the these and works fine:
python-keystoneclient==2.1.1
python-novaclient==2.35.0

There are some breaking chanes in In the later versions of novaclient (>3.0), they deprecated the ability to create block storage volumes from the Nova API, now the cinderclient library must be used.
We need to address this sometime soon, but first we need to decide if we are going to change the OpenStack provider to

use the OpenStack CLI  through Subprocess like the other providers, or
stick to using the python libraries directly like we have been doing

Perhaps in addition to specifying the version, we should have a setup step in PKB that uses pkg_resources to check for required packages and warn/fail if they're not present. A similar check can take place in providers.LoadProvider for the provider-specific requirements file.

@meteorfox @noahl
That problem was solved when I installed each clients of keystone&nova
python-keystoneclient==2.1.1
python-novaclient==2.35.0
Thank u guys

@michael92437558 I'm glad you got it working.
@meteorfox @skschneider let's specify the versions in requirements.txt as a quick fix. I like the idea of doing a runtime check in the longer-term.

@michael92437558 - thanks for closing.
Just for the record, I'd like to say on this bug that #829 and #834 together should prevent this from happening again.


Bluetooth: mesh: Fix Heartbeat Subscription Status

This fixes Heartbeat Subscription Status parameters returned from
Heartbeat Subscription Get/Set messages.
Mesh Profile Specification quotes have been added to make this clear.
Note:
This patch introduces regression in MESH/NODE/CFG/HBS/BV-02-C, which
seems to have a bug, thus:
Test Spec Errata has been created for MESH/NODE/CFG/HBS/BV-02-C (CASE0040580)
Moreover, PTS issue created for MESH/NODE/CFG/HBS/BV-01-C (CASE0040579)
Signed-off-by: Mariusz Skamra<EMAIL_ADDRESS>

I've got feedback to my TSE, and seems that it is similar to the TSE 9610 (rejected).
There is an explanation that "only if the source and destination are unchanged, then the periodLog being set to 0 keeps the count from resetting" . So current heartbeat_sub_set behaviour is correct.
Moreover there is existing Spec Errata that shall clarify this in Spec.

I've got feedback to my TSE, and seems that it is similar to the TSE 9610 (rejected).
There is an explanation that "only if the source and destination are unchanged, then the periodLog being set to 0 keeps the count from resetting" . So current heartbeat_sub_set behaviour is correct.
There is existing Spec Errata that shall clarify this in Spec.

So this PR should be closed without merging?

Yes, closing


problem with XGB

I'm running QSPRPred in anaconda environment with python 3.9.
I tried to run the following command sequentially  and got an error at the end.
I think data_CLI and model_CLI ran OK but pred_CLI  had a problem.
$ python -m qsprpred.data_CLI -i parkinsons_pivot.tsv -pr GABAAalpha -r true -sf 0.15 -fe Morgan
$ python -m qsprpred.model_CLI -pr GABAAalpha -r REG -me -s -m XGB
$ python -m qsprpred.predict_CLI -i parkinsons_pivot.tsv -pr GABAAalpha -r REG -m XGB
{
"base_dir": ".",
"debug": false,
"random_state": 1,
"input": "parkinsons_pivot.tsv",
"output": "predictions",
"ncpu": 8,
"gpus": [
"0"
],
"smilescol": "SMILES",
"properties": [
[
"GABAAalpha"
]
],
"regression": [
true
],
"model_types": [
"XGB"
],
"no_preprocessing": false,
"no_git": false
}
XGB
Traceback (most recent call last):
File "/opt/anaconda/envs/drugex/lib/python3.9/site-packages/qsprpred/predict_CLI.py", line 184, in
QSPR_predict(args)
File "/opt/anaconda/envs/drugex/lib/python3.9/site-packages/qsprpred/predict_CLI.py", line 134, in QSPR_predict
predictions = predictor.predictMols(smiles_list)
File "/opt/anaconda/envs/drugex/lib/python3.9/site-packages/qsprpred/models/interfaces.py", line 490, in predictMols
predictions = self.predict(dataset)
File "/opt/anaconda/envs/drugex/lib/python3.9/site-packages/qsprpred/models/models.py", line 302, in predict
return self.model.predict(X)
File "/opt/anaconda/envs/drugex/lib/python3.9/site-packages/xgboost/sklearn.py", line 601, in predict
return self.get_booster().predict(test_dmatrix,
File "/opt/anaconda/envs/drugex/lib/python3.9/site-packages/xgboost/sklearn.py", line 271, in get_booster
raise XGBoostError('need to call fit or load_model beforehand')
xgboost.core.XGBoostError: need to call fit or load_model beforehand

Hi, seems like the trained model perhaps did not save properly. Can you confirm this is still the case in the latest development version? Installation like this:
pip install<EMAIL_ADDRESS>
Again, very sorry for the late reply.

Closed for inactivity. Let us know if you still need help.


Include in ssh.config is not parsed / respected

I have an Include in my ssh config file for more config file, but those aren't parsed / respected. Is there a solution for this?
Example:
Include config.test

This is definitely shy's fault. Honestly, I think it's because I didn't know about Include when I wrote shy.
Just to confirm, your config.test file is just a regular ssh config that gets included as part of the main file, right? I can look into making this feature work.


Add delete all lessons of a person function

LGTM! However, some checks seems to be failing, can take a look and fix them before we merge

Haven't tested this new function yet so the checks are failing. Will create new issue for junit once merged.

Perhaps you can override it and just make it return null for now and implement it later. So that our checks do not let any possible issues go through for this PR.

Perhaps you can override it and just make it return null for now and implement it later. So that our checks do not let any possible issues go through for this PR.

@NorbertLoh @Chronoxy errors fixed


[balsa] Do not signal error on POST method with no Content-Length.

This is for consistency with http-parser behavior.
Tracking issue: #21245
Signed-off-by: Bence Béky<EMAIL_ADDRESS>Commit Message: [balsa] Do not signal error on POST method with no Content-Length.
Additional Description: This is for consistency with http-parser behavior.
Risk Level: low, changed code protected by existing default-false runtime flag.
Testing: //test/common/http/http1:codec_impl_test
Release Notes: n/a
Platform Specific Features: n/a
Runtime guard: envoy.reloadable_features.http1_use_balsa_parser

/assign @yanavlasov

/wait


Define strategy for dealing with multiple supported versions of Flink on Decodable Custom Pipelines

Now that we have support for Flink 1.16 and 1.18 for Decodable Custom Pipelines, we probably should also have two separate SDK versions aligning with that.

CC @nicoweidner.

I'll look into this. Likely there'd be two multiple flavours of the SDK, one for each Flink version supported by Decodable custom pipelines, i.e. 1.16 and 1.18 at this point.


add ability to hide musics that aren't unlocked yet.

Is your feature request related to a problem? Please describe.
Yes because you can't currently see easier what songs you have unlocked yet and which you have and rather you need to scroll through 600 songs to see which you haven't unlocked yet.
Describe the solution you'd like
Similar button to quest page but it would hide the unlocked songs and leave only the ones that you haven't unlocked.
Describe alternatives you've considered
hides the ones that you haven't unlocked yet and leaves the ones that you have.
Additional context
Search to search the songs that you want to play.

Looking into this. 👍🏻

I feel like this is a pretty niche feature. Music tracks, unlike quests, are not as often the target of completion since the music cape is much less useful and desirable than the quest cape.

This was added in #8779


Inline project creation works differently on Windows and MacOS

Version
4.5.6
Reproduction link
https://gist.github.com/de-soul/c886ced22396ffa448f57978554d5960#file-vue-cli_create-full-project_bug-js
Environment info
WINDOWS

C:\Develop>vue info

Environment Info:

  System:
    OS: Windows 10 10.0.19041
    CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
  Binaries:
    Node: 12.18.2 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 6.14.8 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 85.0.4183.102
    Edge: Spartan (44.19041.423.0), Chromium (85.0.564.51)
  npmGlobalPackages:
    @vue/cli: Not Found

C:\Develop>vue -V
@vue/cli 4.5.6

MACOS

~/Develop $ vue info

Environment Info:

  System:
    OS: macOS 10.15.6
    CPU: (4) x64 Intel(R) Core(TM) i5-8210Y CPU @ 1.60GHz
  Binaries:
    Node: 12.18.2 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.14.5 - /usr/local/bin/npm
  Browsers:
    Chrome: 85.0.4183.102
    Firefox: 70.0.1
    Safari: 13.1.2
  npmGlobalPackages:
    @vue/cli: 4.5.6

Steps to reproduce
Try to run this command on Windows and macOS with npm and vue-cli
vue create test-app --inlinePreset '{"useConfigFiles":true,"plugins":{"@vue/cli-plugin-babel":{},"@vue/cli-plugin-pwa":{},"@vue/cli-plugin-router":{"historyMode":true},"@vue/cli-plugin-vuex":{},"@vue/cli-plugin-eslint":{"config":"prettier","lintOn":["save","commit"]}},"vueVersion":"2","cssPreprocessor":"stylus"}'
What is expected?
Successful project creation
What is actually happening?
The project is successfully created in macOS.
In Windows it gives an error:
ERROR  CLI inline preset is not valid JSON: '{useConfigFiles:true,plugins:{@vue/cli-plugin-babel:{},@vue/cli-plugin-pwa:{},@vue/cli-plugin-router:{historyMode:true},@vue/cli-plugin-vuex:{},@vue/cli-plugin-eslint:{config:prettier,lintOn:[save,commit]}},vueVersion:2,cssPreprocessor:stylus}'

Inline project creation works differently on Windows and MacOS
P.S. Github not displayed backslashes correctly, so correct command and error output in my gist available by the link on the top

On Windows, you need to escape double quotes in command line arguments, while the slash doesn't need to be escaped.

The command-line arguments are processed by the shell first, so technically it's a caveat of PowerShell, not Vue CLI.


Referenced schema dropped from output

Hello,
I'm facing the problem, that my referenced Schema is dropped from the generated swagger-ui components (missing in api.json file as well).
After providing some openapi schemas, they are only added to the final swagger components when they referenced a request or response as a body.

define openapi Schema.A and Schema.B
Schema.A has a property referencing Schema.B
Having a ktor route with Schema.A as response body only.
install SwaggerUI feature with schemasInComponentSection = true

In the resulting Swagger-UI Schema.B is missing as a component and in the response body description of previously defined route.
Is that an issue, or what can I do?

Hi,
i'm not quite sure i understand the problem you are facing correctly. Could you maybe provide some code showing the issue, i.e. how you are defining your body/schemas ?


Point.toVector: point, offset

Marked as status/ready for test in 0.0.2-STAGING by CI build #4.

Marked as status/tested in 0.1.0-SNAPSHOT by CI build #3.


Updated gitignore to include client/dist

Now this should be good to go!

Thank youuu. I think maybe the title should say not include, but I can't see a way to change it so I'll go ahead and merge.

Unless it'll let you edit it?


[Loot Tracker] Add an option to automatically reset loot tracker after killing a separate target from the one it was tracking

Sometimes I would forget to right click the bag icon in the Loot Tracker and hit 'reset all' would be nice to add an option so it automatically resets the Loot Tracker if you were to kill for example, a Blue dragon after you were tracking Gargoyles.

Duplicate of #4659


Commando Package Recategorization

The Problem
Originally CommandoVM categories were created to align with Kali Linux, however it has become apparent that its categorization of packages tends to lump several categories into one (ex. Exploitation). We seek to bring clarity to how tools are categorized and to update outdated category names, where relevant.
The Solution
Deprecated categories:

Active Directory - almost all packages we have are for Active Directory, making this overly broad
Cloud - with how integrated Azure is becoming with Active Directory, tools for them are increasingly intertwined, making it harder to categorize something as only specific to cloud.
Evasion - evasion is technically a part of tooling within multiple categories
Information Gathering - renamed to "Reconnaissance" to align with MITRE ATT&CK
Password Attacks - ambiguous title. Renamed to "Credential Access" for clarity and to align with MITRE ATT&CK
Vulnerability Analysis - unnecessary category with an ambiguous title
Web Application - deprecated in favor of a web profile for CommandoVM

New Categories:

Credential Access - renamed from "Password Attacks"
Lateral Movement - moved some tools from "Exploitation" here
Payload Development - moved some tools from "Exploitation" and almost all from "Evasion" here
Persistence - moved some tools from "Exploitation" here
Privilege Escalation - moved some tools from "Exploitation" here
Reconnaissance - renamed from "Information Gathering"

@Ana06 @mr-tz are you folks okay with us making this sweeping change?


Exercise #5 : KDC-ERR-BADOPTION

Hi, I have been trying to follow your tutorial to get into AD security and it has  been very helpful so far. However, I am stuck on exercise 5. When I attempt to execute any of the commands:
`Invoke-Rubeus -Command "s4u /user:taskservice /aes256:390F5466C4FCCB8A04955838C3890D067050B3035886ED97D8D96912E8E70C01 /impersonateuser:bwillis /msdsspn:cifs/adsec-01.contoso.com /ptt"
Invoke-Rubeus -Command "s4u /user:taskservice /aes256:390F5466C4FCCB8A04955838C3890D067050B3035886ED97D8D96912E8E70C01 /impersonateuser:bwillis /msdsspn:host/adsec-01.contoso.com /ptt"
Invoke-Rubeus -Command "s4u /user:taskservice /aes256:390F5466C4FCCB8A04955838C3890D067050B3035886ED97D8D96912E8E70C01 /impersonateuser:bwillis /msdsspn:rpcss/adsec-01.contoso.com /ptt"`
I get the following error:
KRB-ERROR (13) : KDC_ERR_BADOPTION
Any idea why that might be occuring? I have also installed SMBv1 on machine adsec-01.

Hi,
did you verify that the delegation permissions for user taskservice are set correctly?
It should be enabled for constrained delegation with protocol transition and the SPNs in the allow list should match the SPNs you used in the rubeus command.
These things are initially set by the setup script referenced during lab setup but maybe something went wrong there.
Christoph

Thanks for your response, turns out it was due to me having changed the computer names initially (from adsec-00/adsec-01 to server0/server1). The delegation permissions were registered for adsec-00.contoso.com and adsec-01.contoso.com and it was fixed once I added the entries for the changed names.

Classic ;) good to hear it works for you now.


Added numerical sorting and Story testing scenarios

Description
Before

After

@hughess  - Considering adding a custom sorting option for unique string + number scenarios

Checklist

[ x ] For UI or styling changes, I have added a screenshot or gif showing before & after
[x] I have added a changeset
[ ] I have added to the docs where applicable
[ ] I have added to the VS Code extension where applicable

@ItsMeBrianD  It the UI-test failure related to my code changes?

No they've been having issues for a while


without  >- in template.....No way to get out of Kiosk mode

Have 4 modes in my setup:
input_select:
  mode:
    name: Mode selection
    icon: mdi:account-settings
    options:
     - Normal
     - Full house
     - Kiosk
     - Developer
#    initial: Normal

never used the Kiosk mode before, so all this input_select does is change the Theme state, to indicate the Kiosk mode is truly on.
Trying the feature on CH now with this:
kiosk_mode: >
  {{ is_state('input_select.mode','Kiosk') }}

enables the Kiosk mode just fine, really nice.
selecting one of the other modes after that, does make the input_select change state, and all other things belonging to that particular state.
It doesn't however stop the Kiosk mode! No way to get out of that, other than using the disable_ch suffix...
config:
#https://maykar.github.io/custom-header/#configuration/main
#header_text:

## all default
#disabled_mode: false
kiosk_mode: >
  {{ is_state('input_select.mode','Kiosk') }}

compact_mode: true

#footer_mode: true
#disable_sidebar: false
#hide_header: false
#hide_help: false
#hide_unused: false
#hide_refresh: false
hide_config: true
#hide_raw: false

# https://maykar.github.io/custom-header/#configuration/buttons
#menu_hide: false
#voice_hide: false
#options_hide: false
#menu_dropdown: false
#voice_dropdown: false
#reverse_button_direction: false
#button_icons:

button_text:
  options: >-
    {{ hours24 }}:{{ minutesLZ }} - {{state_attr('weather.home_darksky','temperature') }}°
#
#    {{ hours12 }}:{{ minutesLZ }} {{ AMPM }} -  <ha-icon icon={{states('sensor.weather_icon')}}></ha-icon>
#    {{state_attr('weather.home_darksky','temperature') }}°

show_tabs: >
  {% if not is_state('input_select.mode','Developer') %}0 to 21, 26 to 28
  {% else %} 0 to 28
  {% endif %}

# https://maykar.github.io/custom-header/#configuration/exceptions
exceptions:
  - conditions:
      user: Gezin, redacted
    config:
      show_tabs: 0 to 3,6,15 to 18
      voice_hide: true
      options_hide: true
  - conditions:
      user_agent: iPhone
    config:
      menu_hide: true
#      voice_hide: false
      options_hide: hide
  - conditions:
      user_agent: iPad
    config:
      menu_hide: true
#      voice_hide: false
      options_hide: hide

# https://maykar.github.io/custom-header/#configuration/tabs
#chevrons: true
#indicator_top: false
#default_tab:
#reverse_tab_direction: false
#hide_tabs: An array or comma separated string of tabs to hide, more info below
#show_tabs: An array or comma separated string of tabs to hide, more info below
#hidden_tab_redirect: true

tab_icons:
  alarm: >-
    {{states('sensor.alarm_panel_icon')}}
  phones_tablets: >-
    {{states('sensor.presence_icon')}}
  weer_klimaat: >-
    {{states('sensor.weather_icon')}}
  alarmclock: >-
    {{'mdi:alarm-off' if is_state('sensor.next_alarm','Not set') else 'mdi:alarm'}}

tabs_color:
  phones_tablets: >-
    {{state_attr('sensor.family_home','icon_color')}}

CH 1.0.6 HA 103.0
just tested it with this template:
kiosk_mode: >-
  {{ states('input_select.mode') == 'Kiosk'}}

and that does work alright, as does this:
kiosk_mode: "{{ states('input_select.mode') =='Kiosk'}}"

and:
kiosk_mode: >-
  {{ is_state('input_select.mode','Kiosk') }}

will  add 'format templates needs >-' to title
can close this, and maybe set a general issue for the template specifics? Its a bit of a guess right now, since as you can see in my config, not all templates (see tabs_color and show_tabs) need the >- for multiline

This is just a function of YAML. Using > rather than >- will always add a trailing \n to what is returned. In your case that would make a boolean into a string. I will think on ways to maybe help this situation, but I don't want to essentially remove a feature of YAML when someone might be expecting the normal functions of yaml, if that makes sense.
https://symfony.com/doc/current/components/yaml/yaml_format.html

ok understood.
just don't get it then why the 2 other templates work fine

Which 2? The other two examples? That would be because no \n is added so the returned value is still a Boolean true or false. Otherwise its returning a string true\n or false\n. Booleans can't have anything added to them.
Or if you're referring to your other two templates, they're already strings. So adding a \n to them just adds a new line, which may be empty.

i meant the show tabs
show_tabs: >
  {% if not is_state('input_select.mode','Developer') %}0 to 21, 26 to 28
  {% else %} 0 to 28
  {% endif %}

is this a string?
and kiosk mode:
kiosk_mode: >-
  {{ is_state('input_select.mode','Kiosk') }}

which is a boolean

Yup, hide_tabs is a string. Anything that contains letters or can contain letters is a string. For example ranges are a string since it contains "to" I then process that an convert it to an array of index numbers in that range. Same thing with using a view's path or title in hide tabs, I process that from the string to the index number it matches.

I clicked on the kiosk mode and cannot get out of it.  Home assistant still works through lovelace/tab1  //tab 2 ect but cannot get back to the menu to change anything.  I can get to the config files through samba.  please help!

Ok, I found my way out. I removed the customer header folder.  config/www/community/custom-header

https://maykar.github.io/custom-header/#intro/notes
"If you need to restore the default header add ?disable_ch to the end of your URL: http://<IP_ADDRESS>:8123/lovelace/1?disable_ch"


code scanning

This should allow scanning on both rust and typescript

@kdy1 can you take a look at this cargo deny failure:
2024-08-03 07:43:46 [ERROR] failed to fetch crates: error: failed to load manifest for workspace member `/github/workspace/deps/swc/crates/swc_allocator`

Caused by:
  failed to read `/github/workspace/deps/swc/crates/swc_allocator/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

2024-08-03 07:43:46 [ERROR] `cargo metadata` exited with an error: info: syncing channel updates for 'nightly-2024-07-21-x86_64-unknown-linux-musl'
info: latest update on 2024-07-21, rust version 1.81.0-nightly (506[9](https://github.com/nodejs/amaro/actions/runs/10226392465/job/28296579024?pr=36#step:4:10)85649 2024-07-20)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'rust-docs'
info: installing component 'rust-std'
info: installing component 'rustc'
info: installing component 'rustfmt'
error: failed to load manifest for workspace member `/github/workspace/deps/swc/crates/swc_allocator`
referenced by workspace at `/github/workspace/deps/swc/Cargo.toml`

Caused by:
  failed to read `/github/workspace/deps/swc/crates/swc_allocator/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

cc @nodejs/security-wg added security audit


chore(master): release 1.1.6

:robot: I have created a release beep boop
1.1.6 (2023-04-05)
Miscellaneous

deps: update dependency @wayofdev/secretlint-config to v2.0.7 (7ca4b7e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/keywind/releases/tag/v1.1.6 :sunflower:


Does jit understand monkeypatched methods?

🐛 Bug
Tensor.register_hook is currently not supported by Thunder.
In Lightning Fabric, we use this once for error checking that the user properly called backward. https://github.com/Lightning-AI/pytorch-lightning/blob/096b063d6eeb41567409f4a6b9bac6f5af28ed93/src/lightning/fabric/wrappers.py#L232-L233
Since this hook is not critical, as it's only meant to avoid user errors, I would like to be able to monkeypatch it externally.
However, it doesn't seem like it has an effect with Thunder:
To Reproduce
import torch
from lightning import Fabric
from lightning.fabric.wrappers import _FabricModule
import thunder

model = torch.nn.Linear(1, 1, bias=False, device="cuda")
x = torch.randn(1, 1, device="cuda", requires_grad=True)

fabric = Fabric(accelerator="cuda", devices=1)
model = fabric.setup(model)

# monkeypatch what's causing trouble
assert isinstance(model, _FabricModule)
assert model._register_backward_hook is not None
model._register_backward_hook = lambda *_: None

model = thunder.jit(model)

y = model(x)
y.backward()
print(y)
print(x.grad)

Which fails as Thunder doesn't support register_hook
AttributeError: The torch language context has no method register_hook

Interestingly, a non-fabric snippet doesn't fail so there is something funny going on:
import thunder
import torch

class Wrapper(torch.nn.Module):
    def __init__(self):
        super().__init__()
        self.model = torch.nn.Linear(1, 1, bias=False)

    def forward(self, x):
        y = self.model(x)
        self.register_hook(y)
        return y

    def register_hook(self, tensor):
        tensor.register_hook(self.hook)

    def hook(self, _):
        print("hi")

model = Wrapper()
x = torch.randn(1, 1)

model.register_hook = lambda *_: None

model = thunder.jit(model)

y = model(x)
y.backward()

Ignore this. The answer is yes. Looks like this is a Fabric bug


QA Testing: Improve messaging in the add members to channel modal

QA testing needed for issue https://github.com/mattermost/mattermost-server/issues/17707
Issue Description
From the channel menu, when you click "Add Members" there is a modal that states "Up to 20 can be added at a time". This message is confusing and only necessary if the user actually tries to add more than 20 people. To fix this:

Remove the text "You can add 20 more" from the modal

If the user adds 20 people to the input box, then show a message "Up to 20 can be added at a time" and do not allow them to type any more characters unless they remove a user from the input area

Design link: https://www.figma.com/file/U10zzjkOQd5bO2ekAnllpt/Add-Members-to-Channel?node-id=513%3A1
User story: https://community-daily.mattermost.com/core/pl/smbwy1w68jg6b8h17kjqyn6ojr

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please  join our "Developers" community channel.
New contributors please see our Developer's Guide.
JIRA: https://mattermost.atlassian.net/browse/MM-35366

There is no design in that Figma link can you update it?


Rewrite Scheduler (TaskQueue, TaskTracker) to not have mutable shared state and race conditions

This is an epic. See

Replace TaskQueue/OfferMatcher with an actor based implementation #1741
Redesign TaskTracker #462

and maybe more.

Done! Unfortunately, there are other classes that still have them...


feat: add support to use SQLAlchemy async sessions

Description

Add AsyncSession dependency;
Add open_async_session async context manager;

TODO:
~- [ ] doc in readme~ in another PR

looks good!
Did bring me back to look at #16 , do you think we should get back onto that PR and add similar 'bug fix' to this PR? Otherwise you still have that pesky bug of middlewares not running on failed commits, and logs etc not being captured properly as an effect.

yes, we must


Feature/sup 10039/update branch ci

Description of the Change

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Relates to #4433.


chktex reports issues from the wrong files

When you run chktex on a file which imports other files, where those other files produce warnings/errors, those warnings or errors are reported in the original file incorrectly.

Same goes for lacheck.

ALE doesn't use errorformat and so on at all.
I don't use chktex myself. If anyone wants to have a go at fixing this, go for it. If not, I'll get to it eventually.

Alright I will give it a try for both lacheck and chktex.
Unfortunately I did not yet find the code which further processes the returned (by linter handler) list of dictonaries.
call add(l:output, {
      \   'bufnr': a:buffer,
      \   'lnum': l:match[1] + 0,
      \   'col': 0,
      \   'text': l:match[2],
      \   'type': 'W',
      \})

in ale_linters/tex/lacheck.vim
Is there support for a key:value pair for the filename already?
I would propose to not just ignore out-of-file errors, since tex's \input{otherfile.tex} calls act exactly like if the input was written in the current file.

Is there support for a key:value pair for the filename already?

I'm not sure what you mean by this. All items returned from the callback function should be errors to display for the file being checked.

So the returned list is a list of dictionaries, and each dictionary contains keys like:
bufnr,lnum,col,text,type. What I meant is how this dictionary (for a single error) gets further processed for display in the loc list. And especially whether there exists some dedicated key in the dictionary for a filename?

Only the buffer number is used for setting errors. Each buffer in Vim has a number, and the buffer number is recorded when ALE starts checking a file. This buffer number is passed around everywhere, and then the buffer number is used to set the errors for a given buffer.
For fixing the bug for this GitHub issue, the way to go about it is to first check if the lines of output from chktex return the filenames the errors and warnings are for. If the command can either return the filename being checked, or something like '<stdin>', etc., then either can be used to filter the matches down to only those for the file being checked.
I don't know too much about chktex myself.

Of course. I would just love to preserve the files and put them in the loc-list, since the loc-list of capable of also allowing jumps to other files.

I think this was fixed a while ago. If someone can paste some output from the command where this is a problem, I'll add a test for it and fix that.

Hi, this is still an issue with both chktex and lacheck. I'm using Vim 8.0 on Debian, newly-installed ALE from github, chktex 1.7.6, and lacheck 1.26. I haven't used syntax checkers in the past, so I probably won't use proper jargon. Haven't set any options in ale, so everything should be at its default state.
MWE: Two files, one of which \inputs the other. The inputted file has a simple error (no nonbreaking space before a \ref).
File 1 (ale_test.tex):
\documentclass{article}
\begin{document}
\section{Test}\label{test}
\input{ale_input}
\end{document}

File 2 (ale_input.tex):
Here is a reference in the input file without a nonbreaking space: \ref{test}.

We expect ALE to highlight line 1 in ale_input.tex. Actual result is that line 1 is marked in both files. Both display this warning when the cursor is on line 1:
perhaps you should insert a `~' before "\ref"

If I move the \ref in ale_input.tex to a different line, the reported error in ale_test.tex moves accordingly.
Both chktex and lacheck check \input'd files. Here's the output from lacheck when I run it by hand:
~/test $ lacheck ale_test.tex
** ale_input:
"ale_input.tex", line 1: perhaps you should insert a `~' before "\ref"

And chktex:
~/test $ chktex ale_test.tex
ChkTeX v1.7.6 - Copyright 1995-96 Jens T. Berger Thielemann.
Compiled with PCRE regex support.
Warning 2 in ale_input.tex line 1: Non-breaking space (`~') should have been used.
Here is a reference in the input file without a nonbreaking space: \ref{test}.
                                                                  ^
No errors printed; One warning printed; No user suppressed warnings; No line suppressed warnings.
See the manual for how to suppress some or all of these warnings/errors.

So this might be fixable by changing the regex used to match the current filename.
Additional note: if I open ale_test.tex from outside its directory, we don't get this error. This is because chktex and lacheck fail to find the error in ale_input.tex, because they can't find the file:
~ $ lacheck test/ale_test.tex
** ale_input:
"test/ale_test.tex", line 4: Could not open "ale_input"

~ $ chktex test/ale_test.tex
ChkTeX v1.7.6 - Copyright 1995-96 Jens T. Berger Thielemann.
Compiled with PCRE regex support.
chktex: WARNING -- Unable to open the TeX file `ale_input'.
Warning 27 in test/ale_test.tex line 4: Could not execute LaTeX command.
\input{ale_input}
^^^^^^
No errors printed; One warning printed; No user suppressed warnings; No line suppressed warnings.
See the manual for how to suppress some or all of these warnings/errors.


Resources render props replaces each others when it doesn't make sense

SETUP
Let's say on one page you have the following resourceProvider, let's call it A:
<ResourceListProvider
          crudThunks={crudThunks}
          resource={YOUR_RESOURCE}
          replace
          autoFetch
          params={monthParams}
        >
          {({entities}) => /** some business logic **/}
 </ResourceListProvider>

And then on another page you have this resourceProvider with different properties than A, let's call it B
<ResourceListProvider
      crudThunks={crudThunks}
      resource={YOUR_RESOURCE}
      autoFetch
      path="some-custom-path-on-your-backend"
    >
      {({entities}) => /** Some business logic **/}
  </ResourceListProvider>

Expected Behavior
Entities from B and A are different and don't impact each others
Actual Behavior
When B is rendered the first time, entities come from the custom path without any issues, if you happen to render A on the same page, B will provide entities from A to its children which doesn't make sense.

Update: This was solved by creating a different RESOURCE and adding said RESOURCE to createReducersForResources and createActivityReducersForResources, this is really confusing and should be documented somewhere.


Fixed delta applied on the wrong values

First of all thanks for this plugin, this saves me a lot of time for debugging!
I encountered an issue where camera rotation and speed were either too fast or too slow when I turned vsync on or off.
Rotation and translation were framerate dependant, camera sensitivity shouldn't be multiplied with the delta as the MouseMotion event values already represent the actual mouse speed, and the velocity should.
I tweaked the default values to accommodate the changes, but those are completely arbitrary as they were not fixed in the first place, let me know if the new ones seem good to you

Yeah, you're right, it should be the other way around. LOL, what was I writing?


Unable to push or pull changes.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v20.1.0
Amplify CLI Version
12.5.0
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
Yes I push change by setting default value with =
Describe the bug
report-1696522050966.zip
Expected behavior
I got this error 🛑 Syntax Error: Expected Name, found "=". when I pull or push graphQL models change
Reproduction steps

add = in model like  this :
type User
@model
@auth(rules: [{allow: public}, {allow: private, operations: [read]}]) {
id: ID!
isFavorite: Boolean
logo: String
status: String = "active" # the issue line
}
push change with amplify push

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Tanks you @josefaidt and @AnilMaktala but I already change = to @default but I cannot push my change I still have 🛑 Syntax Error: Expected Name, found "=". when I run amplify push

Hi @MARCTELLY, Thank you for the response. Could you please run below command and send us the report?
amplify diagnose --send-report.
please refer here

you can fin the report on #Describe the bug here https://github.com/aws-amplify/amplify-category-api/issues/1929#issue-1930369173

Hey @MARCTELLY, Thank you. It appears that the problem lies within the CapitalPool model. Would you please try removing = UNSPECIFIED and test it again?

hey @AnilMaktala. Thank you for the response. I already tried that, but did not work so I removed the env and I created the new one

Hey @MARCTELLY, Thank you for the response. Have you created the new schema model as recommend in the comment above?

Hey @AnilMaktala thank you. Yes I created as you recommande


Is there a ready-to-go Docker image?

Hi, I was wondering if there is a ready-to-go Docker image that I can install on my Synology nas. Using Docker on the Synology nas goes to a GUI, so I really don’t know how to install your container without using the GUI.
TIA

Closed due to no response!


Add tSNR computation from fMRI data in batch_processing

To inspire people as well as to be sensitive to modifications on fmri-related functions, it would be good to add this quantification in the batch_processing.
Lines to add:
sct_fmri_compute_tsnr -i fmri_crop_moco.nii.gz
sct_extract_metric -i fmri_crop_moco_tsnr.nii.gz -f fmri_crop_moco_mean_seg_manual.nii.gz -o tsnr.txt

And then to extract results:
echo "fmri/tSNR: " `awk -F"," ' {print $9}' fmri/tsnr.txt | tail -1`

Closing as I've grouped all of the ideas into one issue here: https://github.com/neuropoly/spinalcordtoolbox/issues/3250


@types is still broken for rx-lite

TypeScript Version:  next (2.1.0-dev.20161012)
The problems I raised in #9725 are still present. TypeScript 2 still refuses to recognise the "rx-lite" module declared by "@types/rx".
Code
npm init
npm install typescript@next rx @types/rx --save

tsconfig.json
{
  "compilerOptions": {
    "module": "es6",
    "target": "es5",
    "moduleResolution": "node",
    "types": [
      "rx"
    ]
  },
  "files": [
    "import-rx-lite.ts"
  ],
  "exclude": [
      "node_modules"
  ]
}

import-rx-lite.ts
import * as Rx from 'rx-lite';

./node-modules/.bin/tsc

Expected behavior:
It should work.
Actual behavior:
import-rx-lite.ts(1,16): error TS2307: Cannot find module 'rx-lite'.

Example Project
https://github.com/jonrimmer/ts-types-bug

The published @types/rx package contains a types-metadata.json file with a declaredModules collection that includes "rx-lite". So why doesn't TypeScript recognise this module, even when the "rx" types are explicitly referenced via tsconfig.json?
Does TypeScript even pay attention to types-metadata.json? Is the format documented anywhere? Is the types-2.0 definition resolution process documented anywhere? Is there any documentation on how to write a types-2.0 compliant type definition? Is there any documentation on how to author definitions that contain multiple modules?

--traceResolution will help you understand what TypeScript is doing when trying to resolve types for a module.

@kitsonk Thanks for the tip. Unfortunately the output isn't too useful in this case. It makes it clear that TypeScript is trying to resolve "rx-lite" by looking in the standard places—@types/rx-lite—and failing, but it doesn't tell me anything about how it should resolve it when its contained in a non-standard place—@types/rx

My findings:

types-metadata.json seems to be equivalent to the definitions.json talked about in the types-publisher documentation. Despite it being included in the definition npm package and including all the relevant data, it doesn't look like TypeScript actually uses it for resolution purposes. So it seems it's a red herring.

Types-2.0 packages have the concept of an "entry" definition, which is usually called index.d.ts. This is the definition that will end up being set in the typings field of the @types/whatever/package.json. All packages in node_modules/@types will be "visible" by default, but this just means their entry definition is included. Any other definition files in the package will be ignored, unless they're referenced by the entry definition file.

This is what is wrong with the definitions in @types/rx.  It does reference a file called rx-lite.d.ts, but this doesn't actually define the rx-lite module, a different file called rx.lite.d.ts does.

The compilerOptions.types field in tsconfig.json is supposed to be a way to restrict which packages in node_modules/@types are visible by default, but you can abuse it to load specific files within a package that wouldn't otherwise be found, although you have to be careful of some issues with the path lookup strategy. A full filename will not work, because TypeScript will always append a ".ts" to it:

types: [
  "rx/rx.lite.d.ts"
]

But this will:
types: [
  "rx/rx-lite.d"
]

And, because the types field is really intended to restrict which packages from node_modules/@types are automatically visible, you'll have to also include any additional packages that you want visible, e.g. those containing global declarations.

It seems there is an undocumented triple-slash reference feature where you can specify the attribute "types" instead of "path" and TypeScript will try to load it using the
You can combine this with my earlier finding about referencing package contents in order to include a file within a types package that wouldn't be included by default, or found by the regular package lookup algorithm:
/// <reference types="rx/rx.lite">
import * as Rx from 'rx-lite';

The declaration files under https://github.com/DefinitelyTyped/DefinitelyTyped/blob/types-2.0/rx should be split into other packages, e.g.: rx-lite, rx-lite-aggregates-compat, rx-lite-angular, rx-lite-angular-compat, rx-lite-async, rx-lite-async-compat, rx-lite-backpressure, rx-lite-backpressure-compat, rx-lite-coincidence, rx-lite-coincidence-compat, rx-lite-compat, rx-lite-dom, rx-lite-dom-ajax, rx-lite-dom-ajax-compat, rx-lite-dom-compat, rx-lite-dom-concurrency, rx-lite-dom-events, rx-lite-dom-events-compat, rx-lite-dom-html, rx-lite-experimental, rx-lite-experimental-compat, rx-lite-extras, rx-lite-extras-compat, rx-lite-joinpatterns, rx-lite-joinpatterns-compat, rx-lite-testing, rx-lite-testing-compat, rx-lite-time, rx-lite-time-compat, rx-lite-virtualtime, rx-lite-virtualtime-compat

Should be fixed with https://github.com/DefinitelyTyped/DefinitelyTyped/pull/13652.


Minor fix in bower.json file

It was a mistake in the main path

Same mistake in the package.json – could you bundle that change in this PR as well, please?

Thanks :+1:


Disable GPU Brand not working

Description
I expected that NVIDIA would be removed if I switched that setting to off, but it wasn't.
Neofetch version
2.0.1
Screenshot
gpu_brand="on"
GPU: NVIDIA GeForce GTX 750 Ti

gpu_brand="off"
GPU: NVIDIA GeForce GTX 750 Ti

Verbose log
gist/07bb652a6366e6acff98daeb828be886

I can reproduce this, working on a fix now.

Fixed.
It looks like I'm going to have to do another minor release tomorrow.


catch downstream kokkos dependency

PR Summary
As suggested by @mauneyc-LANL this let's the spackage for ports of call catch the kokkos dependency for packages that depend on ports-of-call..

PR Checklist

[x] Any changes to code are appropriately documented.
[x] Code is formatted.
[x] Install test passes.
[x] Docs build.

Depending on spack version, this may need to be regressed.

@mauneyc-LANL approves. Merging.

not avail in spack 16.3 which we depend on. Cancelling MR for now.


add more info to warning error when making requests in Python client

When the Python client makes a HTTP request to the server and it fails, the client logs a message with attempt, etc. Add request URL and method to this message.

LGTM.

Coverage remained the same at 88.791% when pulling a96436d90b37c31ec83b5db106fa024c02bc1746 on irontable:master into 09e6e2b17d82d8f5c194b8a05572d9461caf546e on Netflix:master.


fix: SimpleCalculator.ini file has missing dependencies in LV examples

Solved in issue https://github.com/solitontech/SLL-Drona/issues/44


github action to upload algo templates to the release assets

tested https://github.com/Project-MONAI/research-contributions/actions/runs/4925546389
this workflow is manually dispatched and by default will upload the tar.gz file to algo_templates https://github.com/Project-MONAI/research-contributions/releases/tag/algo_templates
cc @mingxin-zheng

Thank you @wyli . The workflow is a time-saver.


New external_deps build

This is WIP - so far I just tested the build script and the game on Mac.
I included some of the commits from #561 that weren't too entangled with the package registration stuff. @illwieckz Let me know if there are any other commits there that would be important to include for the new build.

I'm gonna merge #561 in all cases, so cherry-picking instead of rebasing makes everyone's life harder with the only benefit of increasing the risk of introducing mistakes.
The M1 mac stuff are very welcome anyway ! 👍

I'm gonna merge https://github.com/DaemonEngine/Daemon/pull/561 in all cases

Why? AFAIK no one else said they liked the package registration stuff.
By the way, I found that the JPEG NASM stuff still works without any changes. CMAKE_ASM_NASM_COMPILER or whatever gets populated from the NASM environment variable.

Why? AFAIK no one else said they liked the package registration stuff.

No one else expressed any opinion against it as well.
And it fullfills my need of a script that acts consistently with the
documentation by design because the documentation is produced by the same
code that does the actions.

Usually we consider that a pull request should have a favorable review before being merged. More people should be for the change than against it.

Sure, I'm fine with a merge first too
On Wed, Jun 22 2022 at 15:55:46 -07:00:00, slipher
@.***> wrote:

@slipher commented on this pull request.
In external_deps/build.sh:

@@ -5,34 +5,33 @@
set -e
set -u

-# Dependencies version. This number must be updated every time the
version
-# numbers below change, or packages are added/removed.
+# This should match the DEPS_VERSION in CMakeLists.txt.
+# This is mostly to ensure the path the files end up at if you build
deps yourself
+# are the same as the ones when extracting from the downloaded
packages.
DEPS_VERSION=5
That can only be done after the new builds are on the server. I want
to merge first before doing the final builds.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID:
@.***>

I'll have to test this for producing both Linux, Windows and macOS deps archive because that was the initial purpose of starting such work: I was never able to do it myself before and if I can't it means I cannot know if someone else can.
That's also why I'm in favor of turning the version to 6 before merging because by doing that, one has to generate the version 6 deps archives and re-run the checks of this PR on them, meaning we would have checked that this code can generate archives our CI can validate.
If we turn to 6 after the merge, we would have merged the code without any checks.

All right, I uploaded the new packages and changed the version to 6.

I get this on macOS:
../unvanquished-release-scripts/build-release -j$(nproc) macos-amd64
[…]
make[2]: *** No rule to make target `external_deps/macosx64-5/lib/libgmp.a', needed by `daemonded'.  Stop.
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [daemon_build/CMakeFiles/ttyclient.dir/all] Error 2
make[1]: *** [daemon_build/CMakeFiles/client.dir/all] Error 2
make: *** [all] Error 2
ERROR INTERNAL: macos-amd64 build failed

Ah it's a bug in build-release…


EVM Performance Rig Ownership Transfer

### Tasks
- [ ] https://github.com/eosnetworkfoundation/product/issues/225

Not Doing


Fill in the auto-testing

This PR adds back the missing auto-testing that should have been in v1.0.0. The correctness of the package should not be affected because I personally have a local testing project that tests this package in a production-alike environment, and that local project performed in a satisfactory way.
In other words, v1.0.0 was released with a "trust me bro" badge, and this PR confirms and therefore removes the badge.

Roadmap:

[ ] Ensure the default settings are respected
[ ] Test that file cache eviction really evicted items
[ ] Test that database cache eviction really evicted items

The features are basically complete; only some clean-ups remain.

Added the promised test cases (self-contained!)
Changed minimum PHP requirement to 8.2
Reorganized the README

This is complete.


Form config changes for SSL configs of MTLS

Sub tasks - https://app.zenhub.com/workspaces/templates-pod-642d00683718250012716861/issues/gh/appsmithorg/appsmith/31326

Blocked on the FE dependency. Once the FE is done then we can start this on the backend.
Slack thread - https://theappsmith.slack.com/archives/C040LHZN03V/p1709233659123049?thread_ts=1706863929.438519&cid=C040LHZN03V


The break window not always shown on top of other windows

Prerequisites

[x] I'm using latest version: v0.20.0
[x] I've checked Known issues

Description
The break window doesn't always show on top of other windows. It does with e.g. the browser, but it doesn't with e.g. Eclipse IDE. Therefore, when working for some time with the IDE I miss all the breaks.
Toggling full screen mode doesn't change anything - when fullscreen, only the edge parts of the break window is are visibile (unless other app windows are displayed fullscreen).
Operating system: Windows 10. Only one monitor.
Worked fine before updating to 0.20.0

Hi there and thanks for report.
I haven't changed anything regarding that functionality so I guess it's bug in electron. Will have to check when I have time.
Version of eclipse has not changed?

Version of eclipse has not changed?

It has, but I upgraded a couple of days before updating Stretchly and didn't observe this behaviour in between.

I've also noticed this behaviour in Windows 10.
I'm not using Eclipse but I haven't noticed which programmes are active when it happens.

I was able to replicate. I'll try to reproduce with basic electron app.

can you guys try this version? https://we.tl/t-yfTrO9nbbu

Thank you, installing now.  I'll try it over the next few (work) days and let you know if I notice it happening again.

Ok, been using this version for the rest of the day and it's been working as normal with the break reminder appearing always on top on all displays.

I have same problem.
When I'm using chrome and Pycharm, the break window not always prompt properly, but I still could receive the notification.
OS: Windows 10 1903

@zhangchenkai can you also try build from https://we.tl/t-yfTrO9nbbu?

@zhangchenkai can you also try build from https://we.tl/t-yfTrO9nbbu?

@hovancik Yes, it works better. At least for now, nothing has went wrong.
Thank you, and your software.

Awesome, thanks guys for testing! I will try to make new release asap.

I also tried the new version for a few hours on Friday and it seems to work ok, thanks!

I've released new version today with the fix. I hope it works because this was really weird fix :D

Thanks, quick work!
On Sun, 14 Jul 2019 at 20:05, Jan Hovancik<EMAIL_ADDRESS>wrote:

I've released new version today with the fix. I hope it works because this
was really weird fix :D
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hovancik/stretchly/issues/425?email_source=notifications&email_token=AEMQ53XCJTJZSYXSRAPWKOLP7N2H5A5CNFSM4H647REKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4LLSI#issuecomment-511227337,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEMQ53QHRRZ6NOUYABSOPO3P7N2H5ANCNFSM4H647REA
.


Lesson 04 and 05 uniform buffer color does not change.

Windows 10
Visual Studio 2017
In lesson 04 using a uniform buffer for me the rectangle is always green and changing the color in the Constant does not do anything.
In lesson 05 the color should be animated but it is always constant.
Changing the pos from a float2 to a float4 seems to fix the issue or just removing the pos from the Constant struct.

So sorry I'm late to replying, got no notification of this issue!! 😫 You're absolutely right, no idea how I missed it. The problem was that all members of a constant buffer need to be 16-byte aligned, this has been fixed in the latest commit and added a comment to explain. Thanks a million.

No worries! Glad you got to it anyway.


Tweak temporary file management logic

I have had some issues with Screen2Gif, it kept crashing out of the blue, though it worked well the day before. After trying out many things, going back to an older version - the problem persisted.
Eventually I noticed that it is a problem with free space (lack thereof). After freeing up 6 GB on the volume, Screen2Gif worked for a while and then kept crashing again. I was back to no free space.
Upon further inquiry, I found that %TMP%\Screen2Gif had 36 GB of stuff in it, and it included files that were successfully exported to .stg projects from within Screen2Gif earlier.
What I think it necessary:

Warn about low free space
Clean up the temporary directory after the program quits

Currently, the only automated way to clean up the temp folder is by enabling the "Automatically remove old projects" (it's enabled by default). With this option enabled, project older than 5 days will be deleted (during the startup of the editor).
I know that the ActionStack ('undo' and 'redo') takes a lot of disk space and I just adjusted the app to clear those files after closing a project (since they are not loaded next time the project is opened).
Also, just to check, are you running a version greater than v2.8.1?
Because v2.8 had a bug with the process that erases the temp files.

I added the option for automatically erasing projects, with a configurable maximum age in days. For example, you can set to erase projects older than 1 day.
Also, the app will warn about the free space.
This changes will be available with v2.12 or 2.11.1


Expired Domain!

The domain, mediaelementjs.com, is expired! (23/07/2017)

@johndyer can you take care of this please?

Thanks! Updating...
On Sun, Jul 23, 2017 at 11:50 AM, Rafael Miranda<EMAIL_ADDRESS>wrote:

@johndyer https://github.com/johndyer can you take care of this please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mediaelement/mediaelement/issues/2324#issuecomment-317273729,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANE0w-EDHxVPRXifrt12jmSu1rO3r6-ks5sQ5YQgaJpZM4Ogh6E
.

--
John Dyer - http://j.hn/

@alexetgus Thanks for reporting this. Please star us to continue supporting this project

@alexetgus Website is back! Thanks @johndyer for taking care of this


New version: uCSV v0.1.5

Registering package: uCSV
Repository: https://github.com/cjprybol/uCSV.jl
Created by: @cjprybol
Version: v0.1.5
Commit: ef072dcfa05dd2d5d2890856669ed7355295ee0a
Git reference: HEAD

This can be closed. I was able to resolve the auto-merge issues in an earlier attempt https://github.com/JuliaRegistries/General/pull/37395
Thank you all for the great documentation that helped me work through the conflicts I hit!


Solace Read connector: RetryCallable mechanism

This is the 2nd PR for the Solace Read connector (addresses #31440).
It depends on the #31476 (root).
The files that are added/modified in this PR, comparing to the #31476:

build.gradle
RetryCallableManager.java
RetryCallableManagerTest.java

This mechanism will be used for any network calls, such as creating and starting a message receiver (will be added in following PRs).

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @damondouglas

R: @damondouglas


Conditional Helper issue/help

Hi, is is possible somehow to use setIfTruthy not only inside modals?
I'm building some blocks that will be posted as a message and I want to show a particular block based on condition.
Please let me know if this is possible.

figured this one also.
return buildBlocks(
            [
                Section({ text: '*You are awesome!* :raised_hands:\n\n' }),
                Divider(),
            ],
            setIfTruthy(content.paymentRequestedBy, [
                Section({ text: `text` })
                    .accessory(
                        Image({ imageUrl: content.product.imageUrl, altText: content.product.name })
                    ),
            ]),


Revert back to previous (macOS) installer

Downgrade to previous installer until we can resolve issue with the new installer not working on fresh install.

I think I'd rather see us root cause the problem with the new installer.  I don't have a good intuition on what could break by going back to the old installer now.


Newtypes for uid_t, gid_t and pid_t.

Right now the ptrace* functions are broken because of #614. I'd like to see that fixed before this.

@asomers Is that changelog entry OK for you?

It all looks good to me.  The last step is to squash your commits.  BTW, thanks for not squashing them until now; it's easier to review the unsquashed changes.

Done. I don't like squashing because it wipes history, that's why I didn't squash until asked. :)

Yeah, GitHub's interface is terrible about tracking revisions to things. I much prefer GitLab's interface for PRs where it will keep every revision, squashed or not, and let you see how things changed. Makes it nice to not have these final "alright now squash everything" discussions.

@kixunil even though you squashed the commits, you didn't fixup the commit message.  The commit message still describes changes between revisions that no longer exist.  Could you please clean up the wording?

Sorry about that, I don't squash commits often (I probably did it only once two years ago). I hope it's fine now.

bors r+

I'm not sure, but I think that buildbot might timeout when bors does a branch rename instead of a merge commit.  If that's true, then this shouldn't timeout a second time, because there have been commits in the meantime.
bors r+

Ok, I figured it out.  Buildbot isn't building the merge commit because the author has a non-ascii character in his name, and buildbot 0.9.5 has an issue with that.  I'll wait until Bors times out again, then I'll merge this PR manually.
https://github.com/buildbot/buildbot/issues/3078

because the author has a non-ascii character in his name

Ouch, is this issue specific for the buildbot or are non-ASCII names non-standard/forbidden in git author names? (I've never had a problem with it until now.)

@Kixunil it's a bug in BuildBot, and it's already fixed upstream.  I just haven't upgraded our buildbot server to that version yet.  For now, I'm going to bypass bors and merge directly.


Fix race condition on admission error

What type of PR is this?
/kind bug
What this PR does / why we need it:
The assumed status must be written before starting the admission goroutine. Otherwise, there is a race when requeuing, which needs to read the status.
In a separate commit: remove unnecessary log skip from integration tests.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
This bug is unlikely to happen in production, as the goroutine first does an API call before attempting a requeue, which is slow.

/lgtm


Dagger 2: NoClassDefFoundError: dagger/producers/ProducerModule

up vote
0
down vote
favorite
I am trying to integrate Dagger 2 with eclipse and the libs that I have used are as follows:
dagger-2.0.jar
dagger-compiler-2.0.jar
guava-13.0.1.jar
javawriter-1.0.5.jar
javax.annotation-api-1.2.jar
javax.inject-1.jar
Java Compiler -> Annotation processing has been enabled All the above have been added to the Factory Path
But I get the following error when I build the project: Description Resource Path Location Type
Internal compiler error: java.lang.NoClassDefFoundError: dagger/producers/ProducerModule at dagger.internal.codegen.ComponentProcessor.initSteps(ComponentProcessor.java:90)    BuildConfig.java    /DIDemo/gen/com/example/didemo  line 0  Java Problem
Could someone please help?

Dagger 2 is here: https://github.com/google/dagger.


Embed config-relative paths as a substring

Problem
Config env vars as far as I can tell cannot embed relative paths as a substring.
Proposed Solution
It would be useful to be able to set env vars like this for dependencies that need to compile C libraries.
[env]
CFLAGS = ["-I", { value = "include", relative = true }]

Notes
Useful if needed to modify how a library compiles for wasm32-unknown-unknown

Thanks for the report. It's a bit unclear what you want to achieve. Can you share a more complete example for your use case? Will environment variable expansion #10789 helps?
Besides, an unstable flag -C can change the current directory. Please have a look whether it is useful in this situation.

I think #10789 might work if it can expand env vars set within the cargo.toml.
For this feature request, it is to emulate setting the env var on the command line like CFLAGS="-I$(pwd)/include"

Pretty much understood. Just to me feel a bit awkward to have a nested { relative = "…" } inside an array. Personally I am looking forward to #10789 more.
@rustbot label +S-needs-design +I-nominated-to-discuss -S-needs-info

Slight bikeshed: this seems like it could be written more simply as { relative-path = "include" }.

@rhgndf Could you please expand on your use case here? When we discussed this in a Cargo meeting, we weren't clear on exactly what the use case was. In particular, could you explain why this is relative to the config rather than the package root, and why -I include does not work? Are you looking to have a user-global environment variable with a relative path on it?

It seems like when compiling a dependency's C file the relative path does not start from the cargo.toml path. Maybe it starts from the dependency package root instead? I would like to use this feature to include some header files not present in wasm32-unknown-unknown in order to make the C source files from the dependency compile successfully.

Where is the .cargo/config.toml you expect Cargo to read, and where did you execute cargo build from?
Note that Cargo configurations .cargo/config.toml are probed starting from the current working directory. Any path not at the probe path will be ignored.
It would be helpful if you could provide a concrete layout of the project or a reproducible example.

Here's an example: https://github.com/rhgndf/configrelative


Importing PoS chain merged from clique fails with error

It seems there is an issue importing post-merge blocks when the chain being merged from uses
clique consensus. I found this issue while trying to create a hive test involving besu.
Steps to Reproduce (Bug)

Download genesis.json and chain.rlp. They are contained in  clique-bug.zip

Run besu like this: besu --logging=INFO --data-storage-format=BONSAI --genesis-file=genesis.json  --min-gas-price=1 --tx-pool-price-bump=0 --network-id=3503995874084926 --host-allowlist=* --rpc-http-enabled --rpc-http-api=DEBUG,ETH,NET,WEB3,ADMIN --rpc-http-host=<IP_ADDRESS> --rpc-ws-enabled --rpc-ws-api=DEBUG,ETH,NET,WEB3,ADMIN --rpc-ws-host=<IP_ADDRESS> --engine-host-allowlist=* blocks import --run --skip-pow-validation-enabled --from=chain.rlp

Expected behavior: chain.rlp should be imported successfully up to block 2000.
Actual behavior:
2023-11-01 15:00:09.565+00:00 | main | INFO  | BlocksSubCommand | Importing from /chain.rlp
2023-11-01 15:00:10.673+00:00 | pool-10-thread-1 | WARN  | CliqueExtraData | Expected a CliqueExtraData instance but got null. Reparsing required.
java.lang.RuntimeException: Error importing block 64

Versions
besu/v23.10.2-dev-236779d3/linux-x86_64/openjdk-java-17

@jframe any insight into this? I am not sure if any of the clique tweaks made it back into Besu main that may have caused issue here.

Investigated and unrelated to #6164, parsing error is unrelated to protocol schedule.

@jframe any insight into this? I am not sure if any of the clique tweaks made it back into Besu main that may have caused issue here.

It doesn't look like this is related to the clique non-empty block mining changes I made. I quickly tested this on 23.10.1 before my change and it's failing there too.
Think the cause is that are running the clique block miner when we do block import and it's failing to parse the extra data after we import the pos blocks. So we should just not run the block miner. More complex than it sounds though as clique ignores the miner-enabled flag.

Any news here? Can this be resolved at all?

@jframe bumping this back up. Let's discuss.


PERF: Deal with Ray's poor performance on data larger than 2 GiB on macOS

In https://github.com/ray-project/ray/issues/20388, it turned out that the Ray object store performs very poorly on Mac when it's storing more than about 2 GiB. Ray's solution, https://github.com/ray-project/ray/pull/21224, was to limit the size of the object store to 2 GiB. The result is that ray spills to disk for data in the range of 2 GiB to 10 GiB, where Modin is supposed to perform much better than pandas.
In #4335, we overrode the 2 GiB limit to start Ray with Modin's usual object store size, but it seems that the slow object store is even worse than spilling to disk (see #4713).
For now I think we should do the following:

[ ] Accept spilling to disk instead of increasing object store size (#4713)
[ ] Document that Modin on ray on mac has poor performance on data larger than 2 GB
[ ] Raise very loud warnings when a Modin user tries to use ray on mac
[ ] Confirm whether Dask can do better than ray on mac for large datasets for a representative set of tasks.

[ ] If so, make Dask the default execution engine on macs.

cc @modin-project/modin-ray

When the disk spilling is happened (due to 2GB limit), how slow is it compared to Dask & windows Ray when the spilling is invoked due to high memory usage? Do you guys have some number?

how slow is it compared to Dask & windows Ray when the spilling is invoked due to high memory usage?

@rkooo567 to answer your question, I did some performance testing of 3 common kinds of embarrassingly parallel operations in pandas and Modin. I don't have access to a Windows machine, so I tested on my mac and linux (specs for both machines below). Both the mac and linux machines had eight cores, though the linux one had twice as much RAM. Still, I think the difference in RAM didn't matter, because these benchmarks weren't maxing out memory usage on the mac. (and there was no spilling on ray even when using a default object size of 10 GB).
In each case, spilling to disk on Mac is either much better or roughly the same as not spilling to disk, so we should accept the ray limit on the object store size (#4713). However, Ray with the smaller object store is slightly slower than dask on the applymap (~1.3x as long), about 1.4x as long as dask on apply, and about 1.5x as long as dask on read_csv. linux is normally fastest, sometimes by a lot (e.g. 50% in read_csv).
It would be really nice if ray could work around the macOS mmap bug and have a faster object store instead of limiting the object store size and spilling to disk. Otherwise, depending on how Dask does on a wider variety of benchmarks, Modin might need to make Dask the default engine on macs.
Please let me know whether that assessment makes sense. Detailed results are below.
Element-wise apply

Benchmark script
import modin.pandas as pd
import numpy as np
from modin.config import BenchmarkMode
import time

BenchmarkMode.put(True)

# Warm ray up
test_df = pd.DataFrame(np.random.randint(0, 100, size=(2**9, 2**9)))
test_df.applymap(lambda x: x)
del test_df

df = pd.DataFrame(np.random.randint(0, 100, size=(2**20, 2**8)))
start = time.time()
df.applymap(lambda x: x)
end = time.time()
print(f'apply took: {end - start}')

pandas
Mac: 87.25 sec
Linux: 98.91 sec
ray on linux
11.98 sec
mac
dask
(10.26, 10.22) sec
with modin's current ray object store
11.98
with default ray object store
The benchmark script just added import ray and ray.init() before creating the dataframes.
I got spilling to disk and the applymap was 12.92 sec.
column-wise apply

Benchmark script
import modin.pandas as pd
import numpy as np
from modin.config import BenchmarkMode
import time

BenchmarkMode.put(True)

# Warm ray up
test_df = pd.DataFrame(np.random.randint(0, 100, size=(2**9, 2**9)))
test_df.applymap(lambda x: x)
del test_df

df = pd.DataFrame(np.random.randint(0, 100, size=(2**20, 2**8)))
start = time.time()
df.apply(lambda col: col)
end = time.time()
print(f'apply took: {end - start}')

pandas
Mac: (5.957 sec, 5.706 sec)
Linux: 3.488 sec
ray on linux
1.655 sec
mac
dask
(2.247, 2.174, 2.642) sec
with modin's current ray object store
17.97 sec
with default ray object store
spill to disk and get (3.354 sec, 3.167 sec, 3.484 sec)
read_csv

Generate CSV script
  import modin.pandas as pd
  import numpy as np

  df = pd.DataFrame(np.random.randint(0, 100, size=(2**21, 2**8)))
  df.to_csv("2mebi_by_256.csv", index=False)

Benchmark script
  import modin.pandas as pd
  import numpy as np
  from modin.config import BenchmarkMode
  import time

  BenchmarkMode.put(True)

  # Warm ray up
  test_df = pd.DataFrame(np.random.randint(0, 100, size=(2**9, 2**9)))
  test_df.applymap(lambda x: x)
  del test_df

  start = time.time()
  df = pd.read_csv("2mebi_by_256.csv")
  end = time.time()
  print(f'read_csv took: {end - start}')

pandas
mac: (31.37, 33.36) sec
linux: 40.57
ray on linux
9.371 sec (with spilling to disk)
mac
dask
(14.90, 13.11) sec
current modin object store
29.35 sec
default ray object store
(21.93, 20.64, 20.42) sec
Appendix: specs
Mac specs:

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS Monterey
Computer model: MacBook Pro (16-inch, 2019)
Memory: 16 GB 2667 MHz DDR4
Processor: 2.3 GHz 8-Core Intel Core i9
Modin version (modin.__version__): cc713c5c9055f717ac891cd1fccbd08987e169cd
Python version: 3.10.4
Pandas version: 1.4.3
Ray version: 1.13.0

The Ubuntu EC2 instance:

AMI name: ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-20211129
instance type: t2.2xlarge
Ubuntu 20.04.3 LTS
8 physical CPUs
Memory: 32 GiB
Ray: 1.12.0
Python: 3.9.7
Modin: 0.15.2
pandas: 1.4.3


Contributors - alphabetical order

Also, I see that for alphabetical order, my name "Ri" should be above "Ro". If there are further edits to the file, please fix that. (Otherwise I'll do a PR in a week or so.)
- @rartino

I believe the alphabetical order is for the last names.
However, for you is was indeed mixed up "Ar" before "Av".
This should be fixed in the API spec repository as well!
Originally posted by @CasperWA in https://github.com/Materials-Consortia/materials-consortia.github.io/pull/3#issuecomment-513397546

I'll write a PR if no one else does. We might also want to check all authors to check that everyone is in the right order.

This was closed by #194


Save the value of file-name-handler-alist during loadtime

This commit saves the file-name-handler-alist in a radian variable so that it is accessible during load time (I needed this to opened a compressed file for example).

LGTM, thanks.


Visualizations: Add x-axis label to 2x2 and RxC plots

The variable name should appear as a label below the X-axis. Right now, the X-axis shows the labels for the values, but not the name of the variable.

Tested several studies, seems the issue has been fixed, closing ticket.


Automated cherry pick of #4499: Update remaining images to use ubuntu:22.04 base image

Cherry pick of #4499 on release-1.7.
#4499: Update remaining images to use ubuntu:22.04 base image
For details on the cherry pick process, see the cherry pick requests page.

/skip-all


fix update java version for building broker&extension to jdk17

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


ndk/event: Replace open-coded bool getters with bitflags wrappers

And "correct" their ABI to match how it is used in the actual NDK getter functions.  Also add missing aliases and upstream documentation where sensible.

CC @rib, I've been thinking about this to make our wrapper types more consistent, but it may be more inconvenient to use now except in the case when checking multiple flags at once...

We should also do this for ndk::configuration::DiffResult, which most likely benefits from the autogenerated Debug implementation too.


Drop Python 3.6 Support

As numpy 1.20.0 drops support for python 3.6, we will be dropping support for it in an upcoming release.

Done in #265


Standard liquidation event data

Resolves https://github.com/CarmineOptions/derisk-research/issues/223.
Added pydantic model for liquidation event  for better code modularization.

@djeck1432 Please review this. I made sure to test to prevent prior mistake.


Add support for icon url's (not only default emojis)

Example usage:
echo "testing iconurl" | ./slacktee.sh -u $HOSTNAME -p \
        --iconurl "http://global.download.synology.com/download/pkg_img/Docker/1.6.2-0036/thumb_256.png"

Update the README to reflect changes

Thank you for the great pull request!
I think we can support icon's url in -i option, like -i "http://global.download.synology.com/download/pkg_img/Docker/1.6.2-0036/thumb_256.png".
If you agree with my idea, I will tweak your code a little bit and merge it into master.
What do you think?

I have no problem doing this myself - I didn't want to hijack the -i :-)

You're welcome!


Not working when in Project View - Android

It works perfectly when my Project View is Project:

However the moment I switch to Android it does not work anymore:

Even un-grouping and then grouping again does not change it.

Please read readme 'limitations'

Ups okay. My bad is there really nothing we can do?

Yes, we can't do anything with it.


Non-breaking White Space

Apparently a   is it's own unicode character, but glyphhanger is not picking it up, so when I use the outputted code to make a subset font it is always falling back to the main font if a   is on the page.

I managed this by manually adding the character to the whitelist flag.
--whitelist=U+00A0


README.md new instructions JSON + bash scripts

GCE changed the way to get a JSON-file. Mostly a text copy from Authentication JSON File.
Extra bash scripts that eases manual testing. Partially fixes #8. Requires PR #45.

Thanks @smartbit! Can you merge master back in? I'll merge it.

Away from computer till Sunday 31th, will do upon return. Hope it can wait.

No problem

Merged back master. Got no conflicts with the base branch.


[Hotfix|Enhance] Fixing issues static file and logger, validate url

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@90621d6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   23.62%
=========================================
  Files             ?       10
  Lines             ?      419
  Branches          ?        0
=========================================
  Hits              ?       99
  Misses            ?      312
  Partials          ?        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90621d6...ccdc4a7. Read the comment docs.


chore(renovate): attempt to group all eslint deps

trying to fix renovate

Current dependencies on/for this PR:

main

PR #95   👈

This comment was auto-generated by Graphite.


Update to Raspbian Stretch

It would be very nice if the installer could be updated to Raspbian Stretch. I tried it but it's not working and I switched back to Jessie.

Sorry, was on the wrong repo.


The VULN-27015 patch can't be applied to 2.4.7-p1

Issue in ./help/troubleshooting/known-issues-patches-attached/security-update-available-for-adobe-commerce-apsb24-40-revised-to-include-isolated-patch-for-cve-2024-34102.md
The VULN-27015 patch can't be applied to 2.4.7-p1

A change like this would have saved me a lot of time: https://github.com/AdobeDocs/commerce-knowledge-base.en/pull/54

Hi @jbruni I reached out to some subject matter experts internally to confirm if we should make this change to the article. Jira here https://jira.corp.adobe.com/browse/MSKB-2681

Thanks, @barnato-v
The change does not need to be necessarily as suggested here.
The important thing is to avoid people at version 2.4.7-p1, like me, to waste time trying to apply the patch. It results in an error.
Maybe the subject matter experts can release another version of the patch, compatible with 2.4.7-p1... this would be ideal. (Technically, the patch be identical to the "hotfix"... anyway, let the experts do their part...)
Thank you!


classfication demo error

@danielsuo I use cuda7.5 and cudnn v5 and the latest marvin, while i am run the classification demo, i got the Segmentation fault, which the gdb says " 0x00007ffff2ace01d in cudnnDropoutGetStatesSize ()
from /usr/local/cudnn/v5/lib64/libcudnn.so.5", i have no idea how to fix it. Is there anything wrong?
by the way, i got the right response when i run mnist demo,the following is what i do when i run the classification demo：

install cuda7.5 by the .run file and get the graphic driver ok;
download the cudnn-7.5-linux-x64-v5.0-rc.tgz unzip the "include and lib64" to "/usr/local/cudnn/v5"
download marvin and compile
download the classification model and data
run the  demo

output is:
Hello, World! This is Marvin. I am at a rough estimate thirty billion times more intelligent than you. Let me give you an example.
=====================================================================================================================================
[New Thread 0x7ffff0598700 (LWP 17850)]
[New Thread 0x7fffe7bff700 (LWP 17851)]
MemoryDataLayer dataTrain loading data:
75.4819 MB
name:image dim[4]={256,3,227,227}
0.5 KB
name:label dim[4]={256,1,1,1}
301.928 KB
name:imagenet1000 227x227x3 mean image dim[3]={3,227,227}
MemoryDataLayer dataTest loading data:
75.4819 MB
name:image dim[4]={256,3,227,227}
0.5 KB
name:label dim[4]={256,1,1,1}
301.928 KB
name:imagenet1000 227x227x3 mean image dim[3]={3,227,227}
=====================================================================================================================================
Layers:                                                                        Responses:
dataTest
data[4]={256,3,227,227} RF[1,1] GP[1,1] OF[0,0]
label[4]={256,1,1,1} RF[1,1] GP[1,1] OF[0,0]
conv1 weight[4]={96,3,11,11} bias[4]={1,96,1,1}
conv1[4]={256,96,55,55} RF[11,11] GP[4,4] OF[0,0]
relu1
norm1
norm1[4]={256,96,55,55} RF[11,11] GP[4,4] OF[0,0]
pool1
pool1[4]={256,96,27,27} RF[19,19] GP[8,8] OF[0,0]
conv2 (2 groups) weight[4]={256,48,5,5} bias[4]={1,256,1,1}
conv2[4]={256,256,27,27} RF[51,51] GP[8,8] OF[-16,-16]
relu2
norm2
norm2[4]={256,256,27,27} RF[51,51] GP[8,8] OF[-16,-16]
pool2
pool2[4]={256,256,13,13} RF[67,67] GP[16,16] OF[-16,-16]
conv3 weight[4]={384,256,3,3} bias[4]={1,384,1,1}
conv3[4]={256,384,13,13} RF[99,99] GP[16,16] OF[-32,-32]
relu3
conv4 (2 groups) weight[4]={384,192,3,3} bias[4]={1,384,1,1}
conv4[4]={256,384,13,13} RF[131,131] GP[16,16] OF[-48,-48]
relu4
conv5 (2 groups) weight[4]={256,192,3,3} bias[4]={1,256,1,1}
conv5[4]={256,256,13,13} RF[163,163] GP[16,16] OF[-64,-64]
relu5
pool5
pool5[4]={256,256,6,6} RF[195,195] GP[32,32] OF[-64,-64]
fc6 weight[2]={4096,9216} bias[1]={4096}
fc6[4]={256,4096,1,1} RF[355,355] GP[0,0] OF[0,0]
relu6
drop6
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff2ace01d in cudnnDropoutGetStatesSize ()
from /usr/local/cudnn/v5/lib64/libcudnn.so.5

I fix this by adding a line in the Malloc() function -->init(), the in.size() is 0 in constructor function,but it become to 1 in the Malloc() function, however, we only call init()  in the constructor function, which resize some variables to 0;

We moved the resize function to the Malloc function and out of init.
Thanks for this!


fix linter errors

okay, I refactored it to translate the response into the log/buildlog type. It's a little wonky, so I'd love to hear if this seems like a reasonable approach. The crutch/limitation basically centers around the brigade API returning a string rather than a JSON object of the form {"message": "ohai there"}.

hmm... will have to fix the views. One sec

k, done

...nope. Back to the drawing board.

So from what I've read, translating the backend's response (from brigade-api) from a string to an Observable<Log> is a no-no. If the backend returns a string, then we should be using interfaces that match that backend.
If you know of a way to fix this, I'd love to see that! For the time being, would it be better to just move forward with this as-is then fix it in the API?

Yeah, I tried in an earlier version to use .map to translate the object but was getting lost in translation. I'll give it another shot today and see if I can figure it out.

k, I think I got it fixed now and figured out how to use Observables haha :) manual tests all seem to work!


[WIP] Multistaging

Build finished.

Build finished.

Build finished.

Build finished.

Build finished.

Multicontainer was released in 2.12.0. No need for this WIP PR anymore.


Alternate syntax with names

Without partial application, using the pipeline operator, you need to create extra functions, which is bad. But there's an argument to be made that having names for the parameters is good.
let result = tokenize(code, tokenizeOpts)
  |> tokens => parse(tokens, parseOpts)
  |> ast => transform(ast, transformOpts)
  |> transformed => generate(transformed, generateOpts);

This proposal gets rid of the extra functions, but it's also gets rid of the names which is not the primary goal.
let result = tokenize(code, tokenizeOpts)
  |> parse(?, parseOpts)
  |> transform(?, transformOpts)
  |> generate(?, generateOpts);

What if we used an alternate syntax (or extended the proposed syntax) to require (or allow) names for the placeholders:
let result = tokenize(code, tokenizeOpts)
  |> parse(?tokens, parseOpts)
  |> transform(?ast, transformOpts)
  |> generate(?transformed, generateOpts);

let maxGreaterThanZero = Math.max(0, ...?values);

maxGreaterThanZero(1, 2); // 2
maxGreaterThanZero(-1, -2); // 0

I personally think that this is easier to read, but more importantly there is value for tooling.
Example: DevTools
If you want to create a conditional breakpoint, it would be useful to have a name to go off of.
Break when: `Array.isArray(ast)`

Example: Type Checkers
Placeholder "?ast" was expecting an Object, but it received an Array.

I don't feel specifying names here makes sense, as they would be unobservable if partial application uses eager evaluation (which is the current consensus view). Also, you would not be able to set a breakpoint that could be hit inside of the partially applied function call.
Type checkers would not have this issue, as they can determine the resulting signature of the partial function and use the argument names of the original function. I've already experimented with this in TypeScript and its fairly trivial.