WifiWizard.connectNetwork always fires success

When I call WifiWizard.connectNetwork(), it fires the success callback even if I add a random network that's not mine, with a random passphrase. Running 0.2.11 on Android 4.1.1. My code:
if(typeof window.WifiWizard !== "undefined") {

    WifiWizard.addNetwork(WifiWizard.formatWPAConfig(networkName, passPhrase), function(){

        console.log("Added network '"+networkName+"' to the list of known networks.");

        WifiWizard.connectNetwork(networkName, function(){

            console.log("Connected to network '"+networkName+"'."); // Always logged

        },function(err){

            console.log("Failed to join network '"+networkName+"'.",err);

            deferred.reject('notConnected');

        });

    }, function(err){

        console.log("Failed to add network '"+networkName+"'.",err);

        deferred.reject('errorAddingNetwork');

    });

}else{
    deferred.reject('Wifi Wizard plugin not available.');
}

The behavior seems to be different in 0.2.10. There, connectNetwork properly calls the error callback, but the error message is empty, not allowing me to distinguish authentication failed from connection failed.

I'm working on an actual fix for this issue but it needs further testing, at least for WPA networks. The idea is Android at any given time lets you access the WPA supplicant state. When entering a wrong network key the supplicate state should attempt to handshake and then disconnect.
Thanks for bearing with me on this. It's a pretty huge issue right now but not the easiest to fix.

@hoerresb any update on this, I too find myself wanting to know whether or not I have actually successfully connected, or otherwise, when I have failed to do so, after calling connectNetwork...

@hoerresb Please can we get some form of an update regarding this. The success callback should only be triggered if the network specified was successfully connected to and not if the plugin just worked. It is really annoying having to implement a workaround.
For those interested I implement a wait of 5 seconds in the success callback which then compares the currently connected SSID with the specified one that was to be connected to. If they match, I assume the connection has worked and move the user onto the next stage and if they don't, I ask them to re-connect.


setup precommit hook

Current Behavior

Desired Behavior

Implementation

Acceptance Tests

Mockups

Contributor Guide

🎨 Wireframes and designs for Layer5 site in Figma (open invite)

open PR https://github.com/layer5io/sistent/pull/52

done


Change README.md

I've just installed and it has failed with yo node then I've search some information and I've found the #53 so I've installed the generator by using npm i<EMAIL_ADDRESS>-g and it works.
I'm suggesting to add this information in the README.md or change the stable version to 0.4.2

The current version should work just fine. Current version is 0.7.0.

Should but don't. I've already checked in another computer.
First test: Mac OSX Yosemite 10.10
Second test: Xubuntu 14.04
Both cases: npm 2.6.0

What errors are you receiving? I just ran it on Ubuntu without any problems.

~ yo node

/usr/local/lib/node_modules/generator-node/node_modules/yeoman-generator/lib/base.js:445
  this.env.sharedFs.on('change', writeFiles);
                    ^
TypeError: Object #<Object> has no method 'on'
    at run (/usr/local/lib/node_modules/generator-node/node_modules/yeoman-generator/lib/base.js:445:21)
    at Environment.run (/usr/local/lib/node_modules/yo/node_modules/yeoman-environment/lib/environment.js:319:20)
    at /usr/local/lib/node_modules/yo/cli.js:110:9
    at Environment.resolver.lookup (/usr/local/lib/node_modules/yo/node_modules/yeoman-environment/lib/resolver.js:49:32)
    at init (/usr/local/lib/node_modules/yo/cli.js:86:7)
    at pre (/usr/local/lib/node_modules/yo/cli.js:64:3)
    at Object.<anonymous> (/usr/local/lib/node_modules/yo/cli.js:161:1)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)

Yes, might be. @SBoudrias?

Update yo


fix(sqs-consumer.js): support batch handler

:tada: This PR is included in version 1.23.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Script updates, dependency updates

Nothing too big here, just a few tweaks of package.json's scripts and updated a few dependencies. Everything seemed to work just the same as before with the updated deps.

thanks @woodb !


Position tracker

Moved out position tracker.

i bet this fails flake8...

you can run that locally ;)

lol, yeah but it fails through qexec hm. I guess if I'm not passed in a PositionTracker, I should make one to make 100% backwards compat.

Also, the position_proxy and proxy_error were meant as developmental stopgaps. though, if I replace them it'd be too much typing :(

HM. I'm starting to think that there needs to be something between perf tracker and position_tracker/performance_periods. Either that or perf tracker needs to be more generalized. the qexec bencharkmark source uses PerformancePeriod as a mini perf tracker.


MSBUILD : error MSB1009: Project file does not exist.

Currently I cannot build the project using the magic builder . It seems weird to me because I check that the project file pvpgn.sln is available in build folder but msbuild cannot find it.
Please take a look in the log file I attached. Thank you so much.
Log.txt

Hi Harpy, thank you for your support.
I got Magic Builder from Release page so I think there is no problem with it. I also used the latest cmake version from cmake.org. The issue seem more strange to me that I can use the msbuild manually to build it. Hmm I will give a try on another PC on tmr and let you know if It work :)

The same happened on others PCs :(

I'm having the same issue. Any chance this can get looked into asap? :)

@DronkieGit Can you post logs?

@RElesgoe Where would i find that?

https://pastebin.com/Q8CV1nw5

I can look into the issue remotely via Teamviewer tomorrow. Write me your ID and Password on<EMAIL_ADDRESS>4 Feb at 8:00 UTC (or 12:00 UTC).

@HarpyWar Thanks, but no thanks. I'd rather not have someone i don't know prod around on my pc :)
If someone else with the same issue wants to do it, i'd love to know if you guys found a fix though.


Got Error on Loading Game Data

Describe the bug
When i tried to load Game data from slot 1 the screen from the screenshot appeared.
To Reproduce
Expected behavior
I expected the Game to Load the Data i saved in Slot 1.
Screenshots

Platform (please complete the following information):

OS: Windows 10 Pro for Workstations 19042.1415
Version: GB Studio 3.0.2

Additional context

This happens when you load an outdated save

@maxoakland - not really. IF you have a saved slot then it works, but if you don't one, it will kernel panic. Also using the "if game data saved" even seems to not work and the result is fail if you try to load when no saves are present (instead of displaying a message).

I see, Thanks!


Linker error when trying to call init() in PosColorVertex

Error	LNK2001	unresolved external symbol "public: static struct bgfx::VertexLayout PosColorVertex::ms_layout" (?ms_layout@PosColorVertex@@2UVertexLayout@bgfx@@A)
What might be causing it?

unresolved external symbol == you're not linking bgfx...

Ask questions like these here: https://gitter.im/bkaradzic/bgfx

Thanks for quick reply, I've checked my links and they seem right, I've posted my question on gitter.


[问题] <为什么lora微调base模型需要的显存比微调chat模型要高？>

是否已有关于该错误的issue或讨论？ | Is there an existing issue / discussion for this?

[X] 我已经搜索过已有的issues和讨论 | I have searched the existing issues / discussions

该问题是否在FAQ中有解答？ | Is there an existing answer for this in FAQ?

[X] 我已经搜索过FAQ | I have searched FAQ

当前行为 | Current Behavior
No response
期望行为 | Expected Behavior
No response
复现方法 | Steps To Reproduce
No response
运行环境 | Environment
- OS:
- Python:
- Transformers:
- PyTorch:
- CUDA (`python -c 'import torch; print(torch.version.cuda)'`):

备注 | Anything else?
No response

请参考README中的说明。


add tests and autogeneration KernelList

Small merge again to reach a stable build:

Adding more unity test
Adding autogeneration script for KernelList.h, to be extended for other files in future

Issue detected for Buffer of type Int, unsigned int, etc. #46

Codecov Report

Merging #47 (f2da8a0) into master (1c54b2d) will increase coverage by 0.52%.
The diff coverage is 34.61%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   43.09%   43.62%   +0.52%
==========================================
  Files         181      182       +1
  Lines        3304     3280      -24
  Branches     1792     1755      -37
==========================================
+ Hits         1424     1431       +7
  Misses        381      381
+ Partials     1499     1468      -31

Impacted Files
Coverage Δ

clic/includes/core/cleOperations.h
58.33% <ø> (ø)

tests/add_image_and_scalar_test.cpp
40.00% <ø> (+2.50%)
:arrow_up:

tests/add_image_weighted_test.cpp
33.33% <ø> (+1.51%)
:arrow_up:

tests/block_enumerate_test.cpp
43.75% <ø> (+2.57%)
:arrow_up:

tests/connected_component_labelling_box_test.cpp
46.15% <ø> (+4.97%)
:arrow_up:

tests/copy_test.cpp
47.36% <ø> (+2.36%)
:arrow_up:

tests/detect_maxima_test.cpp
46.15% <ø> (+4.97%)
:arrow_up:

tests/difference_of_gaussian_test.cpp
46.15% <ø> (+4.97%)
:arrow_up:

tests/flag_existing_labels_test.cpp
50.00% <ø> (+3.33%)
:arrow_up:

tests/gaussian_blur_test.cpp
46.66% <ø> (+4.56%)
:arrow_up:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c54b2d...f2da8a0. Read the comment docs.

Great ... out of the blue, vcpkg fail at install in CI ...

CI is fixed ...
This PR is ending my effort to clean/stabilize the current code.
Next stop: SWIG -> Python wrapper!


rbd: Implement FenceClusterNetwork and UnfenceClusterNetwork

Add implementation for FenceClusterNetwork and UnfenceClusterNetwork grpc calls.

FenceClusterNetwork: allows to blocks access to a CIDR block by
creating a network fence using blocklisting.

Ceph operation: ceph osd blocklist add <ip>

UnfenceClusterNetwork: allows unblocking the access to a
CIDR block by removing it from the network fence.

Ceph operation: ceph osd blocklist rm <ip>

Since the controller is not available yet, e2e will be added later.
Currently, all the grpcs have been manually tested and verified.

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

/retest ci/centos/mini-e2e/k8s-1.22

Tested the FenceClusterNetwork and UnfenceClusterNetwork grpcs locally using a custom grpc client for NetworkFence operation written on top of  https://github.com/ceph/ceph-csi/pull/2745.
Everything seems to be working as expected :)

/retest ci/centos/mini-e2e-helm/k8s-1.23

changes needed for the unit-tests, give me a confidence boost that it all works as expected :)
The commit rbd: add network fencing utils should be placed before the service implementation. It should be possible to build (and test) ceph-csi after each single commit. If that is not possible, git bisect will fail and finding the change that introduced an error becomes more difficult.

Thanks for the suggestions, the test looks much cleaner now! Also rearranged commit as required :+1:

ci/centos/mini-e2e/k8s-1.22

/retest ci/centos/mini-e2e/k8s-1.22

/retest ci/centos/mini-e2e/k8s-1.22

/retest ci/centos/mini-e2e-helm/k8s-1.22

/retest ci/centos/mini-e2e-helm/k8s-1.22

/retest ci/centos/mini-e2e-helm/k8s-1.22


RTL Support

There is none.

i don't understand

There is none.

Did you read the status the project?
Considering you did not provide any description to the issue I do not know what you want. If you want to fork the project and implement RTL support yourself you are welcomed to.


Make traits public.

These modules need to be public so users of nova can implement the traits and create circuits.

Aha, you fixed this while I was working. Thanks.


Almost impossible to copy and move files on Windows

I never really had problems using Wsidav on a linux environment.
The thing is: I'm now using Windows and since official Windows Webdav doesn't work, I stick to wsgidav. I can open files without problems from a wsgidav mount point, but I can't copy files to a wsgidav folder. I just can't. Sometimes it says "No space left" which is not true since I got 80gb free on both source and destination folders.
I have this problem on Windows since version 2.x.x. I thought it would change when I've updated, but the same thing happens.
I'm using it with auth=anonymous since I don't know how to use authentication on Windows.

Same problem using Android accessing a wsgidav folder.

I assume you mean that you have problems when the WebDAV client is Windows based, such as the Mini-Redirector that is used by the > net use ... command?
Or does it make a difference on what OS the WsgiDAV server runs?
The mini.redirectors are known to have problems, sometimes they can be fixed by implementing a kind of quirks mode in the server behavior.
Could you give some more details, please:

What OS windows Version are you using for client and server? Could you share the configuration?
How do you connect to WebDAV (Access a mapped drive via commond line, use Fiel Explorer, ...)?
Could you post a snippet of the WsgiDAV log in verbose mode, that shows the problem?
Are you aware of another WebDAV server that works better, when you connect to that (so we can compare the access logs)

I had the same problem using an Android client (Smart File Manager and Astro File Manager) and using both Windows 7 and Windows 10.

Some testing:
                Server:  Win 10      macOS
  Win File Explorer:     slow(1)     slow(1)
  Win 'net use w':       slow(1)     slow(1)
  Mac Finder:            fast(2)     fast(2)

(1): Windows MiniRedir copies large files fast enough (a raw 6 MB PUT takes only 0.1 sec).
Deleting multiple files is also ok.
Problem: copying many files seems to introduce some 1 second delays between single requests per file!
No matter if SSL is enabled or not.
No matter if authentication is used or not.
No matter if on Windows the 'Automatically detect settings' option is disabled or not.
This is a single copy sequence for 6MB file:
14:45:13.110 - "PROPFIND /" length=0, depth=0, elap=0.000sec -> 207 Multi-Status
< ... 1.0 second ...>
14:45:12.079 - "PROPFIND /Foto 2 - Kopie (2).JPG" length=0, depth=0, elap=0.000sec -> 404 Not Found
14:45:13.126 - "PUT /Foto 2 - Kopie (2).JPG" length=0, elap=0.016sec -> 201 Created
< ... 1.0 second ...>
14:45:14.157 - "LOCK /Foto 2 - Kopie (2).JPG" length=197, depth=infinity, elap=0.000sec -> 200 OK
14:45:14.204 - "PROPPATCH /Foto 2 - Kopie (2).JPG" length=443, depth=0, elap=0.000sec -> 207 Multi-Status
14:45:14.204 - "HEAD /Foto 2 - Kopie (2).JPG" elap=0.000sec -> 401 Not Authorized
< ... 1.1 seconds ...>
14:45:15.393 - "PUT /Foto 2 - Kopie (2).JPG" length=6122453, elap=0.156sec -> 204 No Content
14:45:15.409 - "PROPPATCH /Foto 2 - Kopie (2).JPG" length=295, depth=0, elap=0.016sec -> 207 Multi-Status
14:45:15.409 - "UNLOCK /Foto 2 - Kopie (2).JPG" elap=0.000sec -> 204 No Content

Other problems on Windows include:

The network mapping seems to fail for unknown reasons sometimes when re-connecting etc.

Exactly. I don't have trouble using connecting to wsgidav on Ubuntu with rclone or whatever.

I really didn't expect that this is so easy, but the first result googling "windows 7 webdav performance issues" actually fixed this for me on Windows 7. Windows 10 works fine.
http://oddballupdate.com/2009/12/fix-slow-webdav-performance-in-windows-7/
I think this is definitely no wsgisav issue, as the same happens for me when connecting to a Nextcloud server.

Okay, I'm sorry. I didn't read the whole issue very carefully. I do not experience this issue as I'm not using the default Filesystem provider and cheroot but rather a custom implementation + Gevent. Using the default configuration, the Windows clients are SLOW.
Using Gevent fixes these issues for me:
from gevent import monkey
monkey.patch_all()
from gevent.pywsgi import WSGIServer
from wsgidav.wsgidav_app import WsgiDAVApp

config = {
    "host": "<IP_ADDRESS>",
    "port": 8000,
    "provider_mapping": {
        "/": "/Users/Steffen"
    },
    "verbose": 1,
    "simple_dc": {
        "user_mapping": {
            "*": True
        }
    }
}

app = WsgiDAVApp(config)

http_server = WSGIServer(("", 8000), app)
http_server.serve_forever()

So: seems to be an issue with cheroot.

@gabriellluz It‘d be great if you could check if using --server=gevent fixes your performance issues.

Some more information when running WsgiDAV on Windows 10 and accessing it with Fileexplorer from the same machine:

Run wsgidav --host <IP_ADDRESS> --server ANY, connect to http://localhost:8080/:
File Explorer is extremely slow (1-3 seconds delay between every file operation) when connecting to 'localhost'
No matter if: cheroot/gevent, SSL on/off, authenticated/anonymous
I assume this is a problem with my person local Network or DNS configuration.
E.g. using gevent:

Run wsgidav --server gevent --host <IP_ADDRESS>, connect to http://<IP_ADDRESS>:8080/
Accessing using the IP address works fast with gevent:

Run wsgidav --server cheroot --host <IP_ADDRESS>, connect to http://<IP_ADDRESS>:8080/
Accessing using the IP address still slow with cheroot:

Run wsgidav --server cheroot --host <IP_ADDRESS>, connect to http://<IP_ADDRESS>:8080/
Increasing thread count to 100 for cheroot improves it:

Run wsgidav --server cheroot --host <IP_ADDRESS>, connect to http://<IP_ADDRESS>:8080/
Increasing cheroots thread count to 256 improves it even more:

I will increase the default thread count for cheroot in the next release, but it is also already configurable, for example in wsgidav.yaml:
# ============================================================================
# SERVER OPTIONS

# server: "cheroot"
server_args:
    # File Explorer needs lot of threads (see #149):
    numthreads: 256

The next MSI installer should also include gevent.

Increasing the number of threads for cheroot may be a workaround, but the root cause may be a problem that is currently addressed here: cherrypy/cheroot#91

@mar10 Please test this with Cheroot v8.1.0

@webknjaz Did only a smoke test, but it seems to be fixed. Thanks!


Fix alignment when using multiple scripts

Hi,
I noticed when using multiple scripts the alignment needed some fixing which PR handles.
Stephen

Fixed thd FC109 error by removing the provider param from package; I guess if people want to set some OS specific provider they can use edit_resource.

Hi @stevendanna - any update on this?

@shoekstra Apologies on this, I had planned to look at this package over my winter holiday but just failed to get to it.
Overall, I am +1 on the formatting changes, but I am hesitant to make a change to the API of this package.  We don't know if any users are currently using the provider param so removing it would be a breaking change for those users.  Perhaps we can add a foodcritic comment to ignore that violation for now and then mark this as a TODO for the next major release?

@stevendanna no problem, I'll update the PR to just include the format fix.

Hey @stevendanna, fix has been reverted and replaced with a TODO, added FC109 to .foodcritic to make the tests green.  Hope that works!

Thanks!


use

Summary of problem or feature request

Code snippet of problem

System details

Operating System
PHP Version
Laravel Version
Laravel-Datatables Version

Use? composer require yajra/laravel-datatables.


Design of media.Sample

https://github.com/pion/webrtc/wiki/PlanningV3#api-should-deal-in-timeduration-and-abstract-away-samplerate

API should deal in time/duration and abstract away SampleRate

media.Sample is confusing. Users shouldn't have to understand the sample-rates of Video vs Audio.

I'd like to suggest to drop media.Sample from v3 API because of the following reasons:

Transformation rtp.Packet -> Sample is lossy.
As reported in pion/rtp#69, roundtrip transformation rtp.Packet -> Sample -> rtp.Packet loose some RTP header flags.
Supporting all of rtp.Packet, media.Sample, binary makes the API complex.
On v2, Track implemented all of Read/ReadSample/ReadRTP and Write/WriteSample/WriteRTP. They are functionally duplicated and will make Track implementation complicated. (A processor of the data should have all of Read/ReadSample/ReadRTP and Write/WriteSample/WriteRTP, and should support all input/output combinations.)

Sample based Tracks can be defined using https://github.com/pion/webrtc-v3-design/pull/24

I feel good about this, closing!
Internally we just deal with RTP, and give a public API that can do samples.


b.functions.source is undefined

Does not work

I'm getting related error in Chrome, which I traced to b.functions.source being undefined:
Cannot set property '__init' of undefined
type: 'custom:mini-climate'
entity: climate.upstairs

fixed in v1.0.2


Two-subscription test that actually works and fix.

Sigh. The previous test, despite my best efforts, wasn't actually working properly. I think this one does.

Oh, you know what, if you stop one subscription things will break as well: https://github.com/apollostack/apollo-client/blob/master/src/ObservableQuery.ts#L65-L66
Will add to this PR

Ok, I realised this was only half the story, and in fact you can't unsubscribe to a single sub either.
I'd like to fix it but the code for tracking this stuff is a complete mess:

queryManager.addObservableQuery
queryManager.addQuerySubscription
queryManager.startQuery

Are all in fact variants on the same thing. And the listener is created in QueryManager.ts yet the sub function is created in ObservableQuery.ts. Uggh.
I need a consult.

Probably related: https://github.com/apollostack/apollo-client/issues/703

@helfer I'm not sure exactly when I am going to look at this, (maybe next week?) so if you want to merge of it apart from the failing test or something, that might make sense.
At the moment I think you can subscribe twice OK now, you just can't subscribe twice then unsubscribe once right now.

@tmeasday yeah, I think it might make more sense for us to clean up the code and fix it during the upcoming refactoring. I'm trying to merge everything I can today so we can refactor without worrying too much.

Ok, well maybe instead we should just cherry pick the tests across into the refactoring. Up to you.

Yeah, +1 for the tests. Although right now they're failing since I merged that other PR :(

Also, calling result() on an ObservableQuery can kill its subscription due to this.
And thus calling setVariables or setOptions can also unsubscribe (since in some cases they call result).

Fixed in #791


how do i get it to list player heads in a gui for every player on the server

          how do i get it to list player heads in a gui for every player on the server

Originally posted by @ArcaneLegend1 in https://github.com/SamJakob/SpiGUI/issues/21#issuecomment-1700613120

for (Player player : Bukkit.getOnlinePlayers()) {
newbutton................
menu.addbutton(newbutton);
}

This works fine, but only creates one page of heads. Is SpiGUI capable of auto-generating next/previous page buttons, or do I have to do them manually ?

SpiGUI should automatic generate pages as necessary...


FP16/BF16 support on AMD

Hi,
Might it be possible to add FP16/BF16 support on AMD?
Thank you!

soon 😉

Thanks! Is there any timeline on AMD support?

I should have asked you sooner: What issues are you experiencing when trying to run with AMD? Is it on Windows, or is it not supported by ROCm?
As far as I know, only xformers, flash attention, and maybe sample packing (since it might require masking from one of those two) don't work. Apart from that, I think everything else works fine assuming your GPU is compatible with ROCm and you have enough VRAM.

@xzuyn what kind of speeds are you getting from it?
Theoretically, it has 30% more TFLOPs than an RTX 4090. What are your observations?

Hi,
I got an error about bf16 not being supported on the GPU. Maybe this is something with the GPU itself? It's a rx6800

Couldn't reproduce this with rocm-6.0.0 and gfx100 (7900XTX). Bitsandbytes had errors (even trying to do a simple import on interactive python) and axolotl would not run anything.

I downgraded from ROCm 6 because I had issues. 5.7.3 was the latest version of 5.7, and it's been working for me.


Add validation for cilium.giantswarm.io/ipam-mode annotation on `Cl…

…uster` CR creation.
towards: https://github.com/giantswarm/giantswarm/issues/26975
this PR adds a new validation on Cluster CR creation that checks the cilium ipam mode annotation has a valid value.
Further checks (during update) will be added in future PRs.

Looks good! this only affects vitange right? I mean nothing to do with CAPI

the Cluster CR is used by capi as well, but I am not sure if this admission controller is running on capa MCs

Looks good! this only affects vitange right? I mean nothing to do with CAPI

the Cluster CR is used by capi as well, but I am not sure if this admission controller is running on capa MCs

It's not.


Updated: postman-canary 7.20.0-canary02

${}

504d0eee-608c-4537-874d-1dc3ec88317d

Newer version of postman-canary (7.22.0-canary05) is now available in master. 2f97b68b471c3f9a3923febcf7c3bb1e7081ae8a


Storage FileShare

hi,
According to the MSDN docs, there are many activities you can perform on a file share:
https://msdn.microsoft.com/en-us/library/azure/dn166997.aspx
the only actions available in the SDK are:

Create
CreateIfNotExists
Delete
DeleteIfExists

After I have created a share, how can i read the properties of a share / make sure that share exists on subsequent requests?
Thanks
Paul

@stack72 this is mostly because we implemented only the parts we needed in other projects. Is your requirement just to make sure share exists?

Hi @ahmetalpbalkan
Thanks for getting back to me on this. Ideally, I would be able to set the ACLs and Metadata on the share. So I think ideally, needing the full operations that are documented would be useful here
Paul

@stack72 hmm we have the similar methods in blob.go, porting them to file.go should not be a big deal. Would you be willing to send a PR?

I've opened up a PR at #395 in which I ported most of the blob operations to file which I needed to create a terraform file share resource

Closed via #395


Add permissions block to push-tag-create-release.yml

Description
Updates the push-tag-create-release workflow to include a permissions block.
See github permissions doc here.

Open to suggestions on how to test this one, I don't want to run the action without additional guidance from someone familiar with it (I see there's some stuff with "draft" in the workflow but I'd still like some confirmation on how I can test the changes here work without disrupting our release messaging/process)


ZEPPELIN-2998. Fix bug in restarting interpreter in scoped mode

What is this PR for?
Fixed the bug mentioned in https://github.com/apache/zeppelin/pull/2554#discussion_r136703878
What type of PR is it?
[Bug Fix]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-2998

How should this be tested?

Unit test is added

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@Leemoonsoo  Please help review. Thanks

LGTM!

Merge if no more discussion


Enable rewriting certain inner joins as filters.

The main logic for doing the rewrite is in JoinableFactoryWrapper's
segmentMapFn method. The requirements are:

It must be an inner equi-join.
The right-hand columns referenced by the condition must not contain any
duplicate values. (If they did, the inner join would not be guaranteed
to return at most one row for each left-hand-side row.)
No columns from the right-hand side can be used by anything other than
the join condition itself.

HashJoinSegmentStorageAdapter is also modified to pass through to
the base adapter (even allowing vectorization!) in the case where 100%
of join clauses could be rewritten as filters.
In support of this goal:

Add Query getRequiredColumns() method to help us figure out whether
the right-hand side of a join datasource is being used or not.
Add JoinConditionAnalysis getRequiredColumns() method to help us
figure out if the right-hand side of a join is being used by later
join clauses acting on the same base.
Add Joinable getNonNullColumnValuesIfAllUnique method to enable
retrieving the set of values that will form the "in" filter.
Add LookupExtractor canGetKeySet() and keySet() methods to support
LookupJoinable in its efforts to implement the new Joinable method.
Add enableRewriteJoinToFilter feature flag to
JoinFilterRewriteConfig. The default is disabled.

Testing strategy:

Add join-to-filter conversion tests to JoinableFactorWrapperTests.
Add getRequiredColumns tests to individual query engines.
Add getNonNullColumnValuesIfAllUnique tests to LookupJoinable and IndexedTableJoinable.
Extend BaseCalciteQueryTest's QueryContextForJoinProvider to also
provide query contexts that enable this rewrite.
Add some new tests to CalciteQueryTest that are designed to exercise
this rewrite. (And some existing tests did, too.)

Looks good. Out of curiosity, given that we exclude null values, how are null values in the left table matched?

I was thinking that because it's an inner join, null values from the left table are supposed to be dropped anyway. (That's why I didn't allow this optimization to trigger for left joins.)

Looks good. Out of curiosity, given that we exclude null values, how are null values in the left table matched?

I was thinking that because it's an inner join, null values from the left table are supposed to be dropped anyway. (That's why I didn't allow this optimization to trigger for left joins.)

Got it. Thanks for clarifying.

@abhishekagarwal87 any other thoughts?


Kubernetes 1.7.1

This change is

Fixes #1034

@lachie83,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@JiangtianLi can you note in here when Windows v1.7.1 builds are available? @lachie83 not a blocker for this PR.

@seanknox Sure, will update here.

@lachie83 go ahead and merge after CI passes, whenever you're ready.

@acs-bot test this please

@lachie83 I tried deploying this today for testing and I ran into an issue with heapster-nanny container. It seems that in addon-resizer:2.0 /pod_nanny has removed some of the flags using in the heapster deployment; e.g. threshold and estimator. which prevented the heapster pod to reach a running status


⚠ ClamAV has degraded performance

In f433b04, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 251 ms

Resolved: ClamAV performance has improved in d15e95d after 24 minutes.


The version 1651 had broken MessageConstructorLibrary

Hi,
(I had some problem with the /denizen debug -r)

Server version : CraftBukkit version git-Spigot-2cf50f0-2b93d83 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)
Denizen version : version: 1.0.2-SNAPSHOT (build 1651), core version: 1.15 (Build 152)

Post your script and a full debug log as recorded by -r

http://old.mcmonkey.org/paste/50154

Post your script and a full debug log as recorded by -r

Full debug : http://old.mcmonkey.org/paste/50158
Scripts :
(MCL) https://one.denizenscript.com/haste/50159
(My script) https://one.denizenscript.com/haste/50160

Do not use % definition syntax, especially not mixed with symbols like > (which is the result of <&gt> tag.
Use <def[name]> to read definitions.


Safari on macOS completely butchers Progress Radials

Current Behavior
Not sure if this is currently a known issue but Progress Radials (linear and indeterminate) get rendered very strangely in Safari on my machine, running macOS 13.3.1. I have tested in Chrome and there is no issue, AND in Safari on my iPhone, so  it's just Safari being Safari again. I'm not sure if theres anything that can happen on this side of the equation to fix this, but considering Safari has ~20% of the web browser marketshare it might be worth looking into.
https://user-images.githubusercontent.com/107384739/234224204-b501e602-0516-449b-82e6-6e55c57da7e6.mp4
Reproduction / Steps To Reproduce
You just need to visit the homepage (or here) in Safari on a Mac.
Anything else?
No response

We had a similar Safari animation bug at my previous company. Sadly, that was nearly a year ago and I can't remember how we fixed it...
I just remember that it definitely was a case of Safari being Safari.

It looks fine on my end, what iOS version are you using?

@lia-07 I'm probably going to need more information for how to reproduce this. I'm running macOS 13.2 and Safari 16.3 and I'm not seeing this issue. I've tried resizing the window.

This component has not undergone any notable changes in weeks if not months, so I think someone would have reported this if this was a common issue. Can you provide your Safari version and perhaps try in Incognito to confirm no extensions are affecting the display please.

Can't replicate, no response. Closing this out.

Can't replicate, no response. Closing this out.

Sorry! I haven't been on GitHub in a while and I had email notifications off.
I am on Safari version 16.4 (186<IP_ADDRESS>.23), and still have the issue in Private windows.

I'll reopen and plan to update and test again. But if we can't replicate we may not be able to help here. Currently you're the only person to report this issue.

@lia-07 I've now updated to macOS Ventura 13.3.1, which includes Safari 16.4. This means I should match you, however I'm still unable to replicate the issues you're seeing.

I do note a slight wobble on Safari that I don't see on other browsers, like Chrome, but nothing as pronounced as you showed above.
https://user-images.githubusercontent.com/1509726/236318352-f6db5b56-35fc-4108-8bb0-74fbda55e8b5.mp4
I've tried different themes and resizing the window to different sizes. Nothing I'm throwing at this is allowing me to replicate the issue you're seeing. I mentioned above, but you're the first and only user to report this issue, so I hate to say but I worry something may be amiss on your end.
If you can find more specific steps to reproduce, please share and again I'll be happy to reopen this issue. Likewise I'll keep my ear to the ground if anyone else reports a similar issue. But unless I can reproduce, I can't debug or resolve the issue. I hope you understand and sorry we can't do more!

I just created another user account on the same machine and it didn't have this problem at all, so obviously it's a problem on my end. The thing is, even after uninstalling my adblocker, clearing cache, and restarting the computer, the issue persisted. Weird.
Anyway, I'm sorry for wasting your time.

That is so weird. No problem at all, just sorry to hear that was happening. If you happen to discover a cause let us know. Thanks!


Different source and target for same event

Hello!
Let's assume the following state machine:

stateDiagram-v2
    [*] --> A
    A --> B: event_2
    A --> C: event_3
    B --> A: event_1
    B --> C: event_4
    C --> D: event_4
    D --> A: event_1

So event_1 triggers the transition from:

B --> A
D --> A

But event_4 triggers the transition from (different source and target in each case):

B --> C
C --> D

If I understood correctly this would result in the following code:
from finite_state_machine import StateMachine, transition

class ExampleStateMachine(StateMachine):
    initial_state = "A"

    def __init__(self):
        self.state = self.initial_state
        super().__init__()

    @transition(source=["B", "D"], target="A")
    def event_1(self):
        print("Transitioning to A by event_1")

    @transition(source="A", target="B")
    def event_2(self):
        print("Transitioning to B by event_2")

    @transition(source="A", target="C")
    def event_3(self):
        print("Transitioning to C by event_3")

    @transition(source="B", target="C")
    @transition(source="C", target="D")
    def event_4(self):
        pass

The problem is with event_4 since it would require two different transitions
  @transition(source="C", target="D")
  @transition(source="B", target="C")
  def event_4(self):
      pass

But when I try to run this machine, I get the following error message:
fsm = ExampleStateMachine()
fsm.event_2()
fsm.event_1()
fsm.event_2()
fsm.event_4()  # <- InvalidStartState exception raised here
fsm.event_4()
fsm.event_1()
fsm.event_3()
fsm.event_4()
fsm.event_1()

finite_state_machine.exceptions.InvalidStartState: Current state is B. event_4 allows transitions from ['C'].

Now I am not sure where my thinking error is. Is my code wrong or are multiple transitions really not supported?
Thanks a lot!

Possible workaround inspired by:

https://github.com/Shuttl-Tech/simple-state-machine#what-if-my-function-has-2or-more-possible-transitions
https://stackoverflow.com/questions/35312226/can-you-code-a-django-fsm-transition-that-targets-an-arbitrary-state

from finite_state_machine import StateMachine, transition

class ExampleStateMachine(StateMachine):
    initial_state = "A"

    def __init__(self):
        self.state = self.initial_state
        super().__init__()

    @transition(source=["B", "D"], target="A")
    def event_1(self):
        print("Transitioning to A by event_1")

    @transition(source="A", target="B")
    def event_2(self):
        print("Transitioning to B by event_2")

    @transition(source="A", target="C")
    def event_3(self):
        print("Transitioning to C by event_3")

    @transition(source="B", target="C")
    def _transition_to_C(self):
        print("Transitioning to C by event_4")

    @transition(source="C", target="D")
    def _transition_to_D(self):
        print("Transitioning to D by event_4")

    def event_4(self):
        if self.state == "C":
            self._transition_to_D()
        if self.state == "B":
            self._transition_to_C()

Running this machine seems to work fine:
fsm = ExampleStateMachine()
fsm.event_2()
fsm.event_1()
fsm.event_2()
fsm.event_4()  # <- works
fsm.event_4()
fsm.event_1()
fsm.event_3()
fsm.event_4()
fsm.event_1()

Transitioning to B by event_2
Transitioning to A by event_1
Transitioning to B by event_2
Transitioning to C by event_4
Transitioning to D by event_4
Transitioning to A by event_1
Transitioning to C by event_3
Transitioning to D by event_4
Transitioning to A by event_1

For reference, the desired finite state machine implemented with transitions which you also talked about in your talk:
from transitions import Machine, State

class SomeClass:
    pass

class StateA(State):
    def enter(self, event_data):
        print("Entering State A")

    def exit(self, event_data):
        print("Exiting State A")

class StateB(State):
    def enter(self, event_data):
        print("Entering State B")

    def exit(self, event_data):
        print("Exiting State B")

class StateC(State):
    def enter(self, event_data):
        print("Entering State C")

    def exit(self, event_data):
        print("Exiting State C")

class StateD(State):
    def enter(self, event_data):
        print("Entering State D")

    def exit(self, event_data):
        print("Exiting State D")

states = [StateA(name="A"), StateB(name="B"), StateC(name="C"), StateD(name="D")]

transitions = [
    {"trigger": "event_2", "source": "A", "dest": "B"},
    {"trigger": "event_3", "source": "A", "dest": "C"},
    {"trigger": "event_1", "source": "B", "dest": "A"},
    {"trigger": "event_4", "source": "B", "dest": "C"},
    {"trigger": "event_4", "source": "C", "dest": "D"},
    {"trigger": "event_1", "source": "D", "dest": "A"},
]

some_object = SomeClass()

machine = Machine(some_object, states=states, transitions=transitions, initial="A")

Here, the finite state machine works as expected:
print(f"Initial State: {some_object.state}")

print()
print("Calling event_2")
some_object.event_2()
print(f"Now in State: {some_object.state}")

print()
print("Calling event_1")
some_object.event_1()
print(f"Now in State: {some_object.state}")

print()
print("Calling event_2")
some_object.event_2()
print(f"Now in State: {some_object.state}")

print()
print("Calling event_4")
some_object.event_4()  # <- works
print(f"Now in State: {some_object.state}")

print()
print("Calling event_4")
some_object.event_4()
print(f"Now in State: {some_object.state}")

print()
print("Calling event_1")
some_object.event_1()
print(f"Now in State: {some_object.state}")

print()
print("Calling event_3")
some_object.event_3()
print(f"Now in State: {some_object.state}")

print()
print("Calling event_4")
some_object.event_4()
print(f"Now in State: {some_object.state}")

print()
print("Calling event_1")
some_object.event_1()
print(f"Now in State: {some_object.state}")

Initial State: A

Calling event_2
Exiting State A
Entering State B
Now in State: B

Calling event_1
Exiting State B
Entering State A
Now in State: A

Calling event_2
Exiting State A
Entering State B
Now in State: B

Calling event_4
Exiting State B
Entering State C
Now in State: C

Calling event_4
Exiting State C
Entering State D
Now in State: D

Calling event_1
Exiting State D
Entering State A
Now in State: A

Calling event_3
Exiting State A
Entering State C
Now in State: C

Calling event_4
Exiting State C
Entering State D
Now in State: D

Calling event_1
Exiting State D
Entering State A
Now in State: A

And illegal transitions are still not possible:
print(f"Current State: {some_object.state}")
print("Calling event_4")
some_object.event_4()
print(f"Now in State: {some_object.state}")

Current State: A
Calling event_4

->
transitions.core.MachineError: "Can't trigger event event_4 from state A!"

@ptrstn Thanks for the detailed write-up!
Right now each transition function is limited to a single transition decorator. The workaround you posted looks like it works, but definitely not the cleanest solution as you are working around the limitations of this library.
A couple of months ago, I refactored the @transition decorator implementation from a function to a class. With this new class-based approach, we can store metadata about each State Machine inside of the class object. When performing a transition, we can do a match on source state to make sure the correct transition decorator is applied.
Things I'm thinking about

does it make sense to have more than 1 decorator per transition function?

very easy to add another function with a decorator to do the same thing, but this could result in code duplication
I have built state machines using transitions that only used a proceed transition function to move the machine thru the various states so I get the use case

what happens if 2 transition decorators have the same source state? which decorator is respected? should we raise an Exception if a state machine is built this way?
how does django-fsm handle this situation? I would need to work through an example
re: simple state machine's solution for handling payment failure and payment success

there is an on_error parameter that would be a better solution for this use case

What are your thoughts?
(Right now it's Advent of Code season, I probably won't be able to try out a solution until next year. Definitely open to discussing it further to find the best solution)

does it make sense to have more than 1 decorator per transition function?

I was thinking the same first, but I am not sure how else you would address this problem. Maybe a dictionary of transition values rather than just a single value or list? I think this would break the current public interface though.

what happens if 2 transition decorators have the same source state? which decorator is respected? should we raise an Exception if a state machine is built this way?

I would raise an AmbiguousTransition or UndeterministicBehaviour Exception or something like that.

how does django-fsm handle this situation? I would need to work through an example

Unfortunately I have no experience with this module, but from what I've read in their GitHub documentation, it looks like they also only support one @transition decorator

I just checked what the transitions package does when two transitions have the same source state. It seems like it just does whatever was set first.
stateDiagram-v2
    [*] --> A
    A --> B: event_2
    A --> C: event_3
    B --> A: event_1
    B --> C: event_4
    C --> D: event_4
    C --> A: event_4
    D --> A: event_1

transitions = [
    {"trigger": "event_2", "source": "A", "dest": "B"},
    {"trigger": "event_3", "source": "A", "dest": "C"},
    {"trigger": "event_1", "source": "B", "dest": "A"},
    {"trigger": "event_4", "source": "B", "dest": "C"},
    {"trigger": "event_4", "source": "C", "dest": "A"},
    {"trigger": "event_4", "source": "C", "dest": "D"},
    {"trigger": "event_1", "source": "D", "dest": "A"},
]

-> ignores {"trigger": "event_4", "source": "C", "dest": "D"}
transitions = [
    {"trigger": "event_2", "source": "A", "dest": "B"},
    {"trigger": "event_3", "source": "A", "dest": "C"},
    {"trigger": "event_1", "source": "B", "dest": "A"},
    {"trigger": "event_4", "source": "B", "dest": "C"},
    {"trigger": "event_4", "source": "C", "dest": "D"},
    {"trigger": "event_4", "source": "C", "dest": "A"},
    {"trigger": "event_1", "source": "D", "dest": "A"},
]

-> ignores {"trigger": "event_4", "source": "C", "dest": "A"}

For this issue in django-fsm, see:

https://github.com/viewflow/django-fsm/issues/122


JBDS-3867 file names should include version match file name on RHCP

Current coverage is 78.74% (diff: 93.75%)

Merging #500 into master will increase coverage by 0.09%

@@             master       #500   diff @@
==========================================
  Files            25         25
  Lines          2309       2413   +104
  Methods         396        397     +1
  Messages          0          0
  Branches        197        196     -1
==========================================
+ Hits           1816       1900    +84
- Misses          493        513    +20
  Partials          0          0

Powered by Codecov. Last update 51cac08...aab03eb

test this

test this

test this

test this

https://github.com/dgolovin/developer-platform-install/blob/443a624bcb0cbe5a19c8b940cf1a77e282821165/requirements-darwin.json#L9 - I think that should say darwin instead of linux
Otherwise the PR looks good.

That is correct, I was fixing it step by step, but obviously didn't pay to much attention to mac and linux versions. Thanks for review @jrichter1!


Update DeviceSetup.md

Fixed typo

Docs Build status updates of commit 6cd1a06:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/tutorials/quickstarter/DeviceSetup.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


WIP: Roundtrip to/from RecordBatch through a DataFrame [WIP]

Do Not Merge: Just to get eyes from @eerhardt

Closing this. Have enough data to make a clean patch now.


Throw error if HMM peaks can not be computed.

Explain your changes:
I changed _populate_trans_mat so that it will throw an exception if the parameters provided lead to sufficiently low probability states such that all of the transition states are -Inf.   Added some tests to verify that this state is caught.  Check that p_to_p = 1 leads to all positions being called peaks for reasonable data.
Does this close any issues?

Closes #13
Any comments?  Anything in particular you need feedback on?
PR checklist

[x] I have written tests for my changes where needed and made sure they pass locally.

Whoops, just need to delete that binary file.  Being fiddly, so planning to do that after dinner

Codecov Report

Merging #35 (db79fef) into main (97c4490) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   98.72%   98.73%
=======================================
  Files           6        6
  Lines         628      632    +4
=======================================
+ Hits          620      624    +4
  Misses          8        8

Flag
Coverage Δ

unittests
98.73% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

rendseq/make_peaks.py
99.07% <100.00%> (+0.01%)
:arrow_up:

tests/test_make_peaks.py
98.52% <100.00%> (+0.02%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Partially addresses #28 but doesn't close it.

I think that should solve all your requested changes, if so let me know and I can squash + merge! :)


add brave browser support

Brave browser supports chrome extensions but for whatever reason the Fulcro Inspect extension is not loading my app
I downloaded the extension in Chrome too and verified that my app is indeed being loaded when using Chrome. So seems to be something specific to Brave support.
I'll resort to using the Chrome browser for now, but wanted to report that at least for me Fulcro Inspect isn't working w Brave

Hello, it does work on Brave, but you have to allow cookies, not sure why, but this works:

great, thanks 👍


"Token billing" should use cardReference to supply the tokenised card

The Token Billing page describes the ability for a gateway to store a permanent or long-term credit card in the gateway account, and reference that card using a token. The token is called cardReference here.
This driver supports this token billing, but refers to the card token as token instead of cardReference. It needs to be switched around for consistency.
Some additional discussions here:
https://github.com/thephpleague/omnipay-sagepay/issues/25

Thinking about this a little more, Sage Pay has a storeToken flag that must be set on each use of the token in order to keep it permanent. Without that flag being set on the next use, it will be deleted on that use.
So it could be argued that Sage Pay supports both single-use and permanent tokens. Our use of setToken() vs setCardReference() in a transaction could be an implicit use of the storeToken flag. So setToken in a payment would always ask for the token to be thrown away after use, and setCardReference would always ask for the token to be stored for future reuse.
I will check whether it is possible to tokenise a credit card using AJAX, as that could open up many possibilities. I have not seen that done in this gateway API, since both Direct and Server APIs use the site's IP address as a security check (the ONLY real security check TBH, which is a little crazy, especially on shared hosting). However, using Sage Pay Server to just capture the credit card details in an iframe as a one-off token, then creating the actual transaction server-to-server (Sage Pay Direct) is very possible, and could make a lot of sense in some use-cases.

Hello, great work on this. Looking promising.
I'm still getting a little confused:
In order to get the request I need to do some action, eg: $request = $gateway->purchase($purchase); but at this point i need to provide the $options = [] argument to purchase which required card, so not sure when in the logic to apply $request->setCardReference()

Yes, that can be a little confusing, but it's due to the origins of Omnipay.
The CreditCard class holds both the credit card details and the billing and shipping user details. If you are sending any of those details into Omnipay then you need to use the CreditCard class. You may just set the CC details (number, expiry etc,) or just set the user details (billing names, address etc.) or both. In a future release of Omnipay, 4.0+, I would like to see these separated. In the meantime, just be aware this class serves two purposes.
The second thing to know is that options can be set in two main ways. These are equivalent, they set the card reference the same in both cases. Just use whichever is most useful to you in the context, or mix the two. You may have all the options up front, so pass in the array. You may build them up bit-by-bit, so use the setter methods. That's a feature across all Omnipay drivers for all options:
$request = $gateway->purchase();
$request->setCardReference('{abc123}');

and
$request = $gateway->purchase(['cardReference => '{abc123}']);

I'll update this page to explain the different ways the options can be added:
https://omnipay.thephpleague.com/api/authorizing/

I see, card is always required as the contact name/info + billing/shipping is used. I tested omitting the card details and this seems to work now, eg:
// $card = CreditCard object
$card
    ->setNumber(null)
    ->setCvv(null)
    ->setExpiryMonth(null)
    ->setExpiryYear(null);

// perform payment request
$request = $gateway->purchase([
    'amount' => $paymentData->amount,
    'currency' => strtoupper($paymentData->currency),
    'description' => $paymentData->description,
    'card' => $card,
    'cardReference' => $savedCard->getReference(),
    'transactionId' => $transactionId,
]);

This worked fine, so that is fantastic. I think I am going to have to clean up my code to handle whether the request is a "new card" or a "savedcard" and using $request->setAmount() and similar functions will be cleaner to handle this condition, so thank you for informing me of those methods!
Is this token persistent (until deleted?) using this method? purchase([ 'cardReference' => '{X}' ]) ? There is mention of a cardReference/token being deleted after the purchase completed.

You don't need to do the set null stuff on the card, as all those parameters start out as null if you don't set them at all.
If you pass in a cardReference then it will be persistent. If you pass in the same saved card as a token then it will be treated as single-use and will NOT persist on the gateway. So if you know you will only be using it once as a part of your UX flow, then pass it in as token. If you know you want to reuse it, then pass it in as a cardReference.
Either way, you cannot get a list of tokens from the gateway, so you are 100% responsible for making sure you delete them when no longer needed (explicitly or by using as a token). They will be automatically deleted when the card expires too.
You can explicitly tell the gateway whether to keep the card or not using the storeToken parameter, but I would recommend not doing that. Just use token or cardReference and this driver will take care of making sure the token is deleted for you.

I would like to get this PR release ASAP, so any feedback and details of how well it runs in your application would be appreciated to help get that moving. Note that this full cardReference support is only in PR #90, from this branch: https://github.com/academe/omnipay-sagepay/tree/issue89

I tested your example and it is working fine, I just need to clean up my code a bit. I'm going to read over the documentation readme now and let you know if anything is confusing to me (someone who isn't literate in all the Payment Processing terminology and process flow so not sure how much it will help).
At first glance under "Generating a Token or CardReference"

$request->CreateToken() - transaction option to generate a token with a transaction.

I couldn't find this method, should it be camelCase ? I see a setCreateToken in the class. Maybe a magic method or typo?
I will feedback with anything else.

A typo. Thanks.
One thing I am very much aware of, is that it must really be read with the Sage Pay documentation to hand. To pull in all the details that are specific to that gateway (e.g. the values that some parameters accept) would make the README extremely long. But maybe that's what it needs...?

In the example code it shows creating a gateway in this style:

create('SagePay\Direct')

However you can also do:

create('SagePay_Direct')

Does this matter? Or is it handled by Omnipay repo and not the adapter.

Both underscore and backslash are supported:
https://github.com/thephpleague/omnipay-common/blob/master/src/Common/Helper.php#L135
I think the _ came from the early PSR-0 autoloaders before namespaces were a thing.

Super minor typo: $cardReference = $response->getCardReference();; double ;;

I can confirm everything is working as expected for me. In my setup, Omnipay sits on a REST API, details are passed with the param savecard, if set it will call:
$request = $gateway->createCard([
    'card' => $card,
    'name' => 'test',
    'currency' => $paymentData->currency,
]);

$response = $request->send();
$cardReference = $response->getCardReference();

And then save the $cardReference returned, I have used the card reference for subsequent payments successfully.
I have a small question regarding this, does new CreditCard([]) confirm the authenticity of the card or would only performing a purchase request do this? (thus letting Sagepay authenticate the card is real). I know CreditCard has some validation for checking types, country and card number, but I wonder how far it goes.
My thought is, when in my control flow would I save the token on my end to allow reference later on, before purchase or after purchase.

I don't believe createCard does any verification on the card. It may do some simple validity checks such as a Lunn check and future expiry date. But so far as contacting the account is concerned, I don't think it does, but best check out the Sage Pay Token Billing documentation.
Yes, you would save the token for later use. It will remain available for later use until it is either used (without saving) or you explicitly delete it, or its expiry date is reached. It is not not a temporary token that may last for only a couple of minutes, as used on AJAX-based gateways. So you could capture the card details on Monday, and use it to take a payment on Tuesday.
One thing about your REST API, if you are using Sage Pay Direct, then the CC details will be passing through your application, so be aware you need to be PCI checked. That is very important to be aware of. If using Sage Pay Server, then the PCI checks are not as rigorous, since the CC details do not do near your application.

When you say "It will remain available for later use until it is either used (without saving) or you explicitly delete it", do I need to save the token each time I request do a request? or can the same token be used, for example:
$cardReference = $response->getCardReference();

$request = $gateway->purchase([ 'cardReference' => $cardReference ]);
$request = $gateway->purchase([ 'cardReference' => $cardReference ]);
$request = $gateway->purchase([ 'cardReference' => $cardReference ]);
...

or would this not work? The "Used - Without Saving" seems a bit confusing.

So long as you use it as a cardReference as you have shown, then this driver will make sure it is saved. There are other fields set in the background to tell Sage Pay to save it.
If your second purchase used a 'token' => $cardReference instead, then the third one would fail because the token would be gone. I'm assuming you do a ->send() on each of your lines of code above.

Thanks for all the hard work, I will talk with my manager to make sure all PCI stuff is dealt with, I'm just integrating the interface since in the past we've always used an SDK (paypal sdk, stripe sdk, sagepay sdk...) and it becomes frustrating when trying to maintain a core ecommerce platform.
Everything for my needs is working great and you have cleared up a lot of knowledge for me, I am super grateful. Right now Ive got the PR checked out on testing. Will switch back to master once you merge.

Cool. Much of what we have here will apply to most other Omnipay drivers. There are at least a hundred of them once you start looking.
PCI be very careful about. It may be really easy to bypass it and just use a gateway that appears to work. But if caught, especially after a data breach, it can bring a company down, especially with new laws coming up.

This got merged a while ago.


Feature request: OAuth access token authorization

I need support for OAuth access token authorization feature.
https://developer.kintone.io/hc/en-us/articles/360001562353/
setting the access token in the Authorization: Bearer header.
This feature has been waiting for a long time ago.
https://github.com/kintone/kintone-basejs-sdk/pull/65
https://github.com/kintone/kintone-js-sdk/issues/32

@r3-yamauchi
Thank you for your feedback!
We're planning to support this header in the future release.

@r3-yamauchi
We've just added a support OAuth access token as #149 .
We'll release a new version that includes this in a few weeks.
Thank you for reporting this!

対応ありがとうございます！

@r3-yamauchi
We released this feature in v1.2.0 .


Create a swagger document for the /v2/hooks API

Use goswagger to generate clients for it that deis/builder can use.
I've volunteered to do so, but not tied this with any release, as it would be a nice to have.

@helgi, could this be closed in favor of #811?

sure


Good news - AlfaFold 3 OSS

https://www.nature.com/articles/d41586-024-03708-4

"Anyone can now download the AlphaFold3 software code and use it non-commercially. "
And the license is CC BY-NC-SA 4.0.
CC have this to say about CC Software licenses: https://creativecommons.org/faq/#can-i-apply-a-creative-commons-license-to-software

CC BY-NC is not open source.
https://opensource.org/definition-annotated see point 6.


Missing node.serviceAccount.annotations in values.yaml

Issue #, if available:
564
Description of changes:
Added a default annotation for the SA.
ref.: https://github.com/awslabs/mountpoint-s3-csi-driver/issues/173#issuecomment-2209120237
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you for the contribution again @netikras!

@unexge
too many thanks for a contribution this small, if you asked me :smile:


Start a dev-mode container section has incorrect docker run command

Hi, the command on this page is not working.
The same appears on Docker docs so I don't know who is the original author.
Link is: https://docs.docker.com/get-started/06_bind_mounts/
(this is where actually I'm following the tutorial trying to learn more about containers and images)
docker run -dp 3000:3000
-w /app -v ${PWD}:/app
node:12-alpine
sh -c "yarn install && yarn run dev"
should be
docker run -dp 3000:3000 ^
-w /app -v "%cd%:/app" ^
node:12-alpine ^
sh -c "yarn install && yarn run dev"
Thanks,
Pieter

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e42a144-9901-78d8-1082-a1c5b35a3602
Version Independent ID: 34e7cab6-29bd-cb03-f100-a186b407a23f
Content: Docker tutorial - Part 5: Use bind mounts
Content Source: docker/tutorials/use-bind-mounts.md
Product: visual-studio-windows
Technology: vs-azure
GitHub Login: @nebuk89
Microsoft Alias: ghogen

@psiegers -- Pieter, thank you for your research & feedback.  I am looking into this issue.

@ghogen -- Gordon, please review this change in private PR 8296.

The following command worked for me on Windows using VS Code's terminal (Powershell) from within the getting-started/ directory.
$ docker run -dp 3000:3000 -w /app -v ${PWD}/app:/app node:12-alpine sh -c "yarn install && yarn run dev"

I couldn't get %cd% to output anything. Also, either I missed the directions for which directory to be in when running the command, or they're not there. So I assumed we should be in the getting-started directory and appended /app after _${PWD}.

@joshmakar -- Josh, thank you for your followup.


Type 'undefined' is not assignable to type 'string' (reduced from a null-able function parameter)

TypeScript Version:  2.2.1
Code
function foo(bar: string | undefined = '') {
    bar = undefined;
//  ^ Type 'undefined' is not assignable to type 'string'.
}

Possibly related to #13826.

This is a duplicate of #14406

you can work around it by doing bar = <string | undefined>''

@krisselden Nice try but that will make the variable string | undefined when entering the function.

This is really a design limitation in the existing system. See https://github.com/Microsoft/TypeScript/pull/12033 for more details on why and how it was implemented.
The crux here is outside the function the type is string | undefined. in side the function, since there is a default, the undefined is stripped out of the type leaving you with only string. This means that the type annotation is not really changing any thing, it is still string | undefined for the caller, and string within the function body.

@mhegazy But can't we just do something similar with something like:
let p: string | undefined = '';
// here `p` has type `string`
p = undefined; // no error

I understand that sometimes if we write (p = '') in parameter list we would want the type of p to be string, but maybe we should treat p: string | undefined = '' differently as it explicitly specifies the type of p.

Yes, I think there is a difference between "I said this could be undefined for callers" vs "this can always be undefined"

We have talked in the past about distinguishing yet another "empty" value called missing, which would allow us to distinguish between things like f() and f(undefined) or {} and { x: undefined }. That's the missing piece here. It would allow the compiler to distinguish these cases:
function f(x: string = '') {
  x.length // ok
  x = undefined // error!
}
function g(y: string | undefined = '') {
  y.length // ok, undefined was removed by narrowing
  y = undefined // ok
}
f(undefined) // error!
g(undefined) // ok!

By letting the assigned type of x: string | missing and y: string | undefined | missing. This additional type would let the compiler disallow the call f(undefined) but allow g(undefined). And inside the function the default initialiser would remove both undefined and missing, so the type of both would be string. However, in g, the assigned type of y would still allow assignment of undefined.
If we added missingType, default initialisers and ? would add it; I'm not sure if there would be syntax in the language for it. There probably wouldn't be any values at all of type missing because it signifies the absence of values.
We did not add this feature for a few reasons.

It is complex: the compiler would need yet another null-like type and control flow would have to correctly narrow it when used in parameters and object literals.
It only applies to a couple of cases — default initialisers and object literal assignability. These cases are both of limited scope; common usage won't encounter the distinction very often.
The intent of ? vs | undefined in object literals [1] is a lot less clear. This change would break code and it's not clear that the object literal break is a desired one.

The mixture of complexity, limited applicability and possibility of unwanted breakage sank this feature. We might re-visit this in the future, but I don't think our decision will change.
[1] To be consistent object literal ? should add missing instead of undefined as well:
type A = {
  a?: number,

  other1: number | undefined,
  other2?: number | undefined,
  other3: number
}
let o: A = {
  a: undefined // error! Previously ok

  // missing other1: error before and after
  // missing other2: ok
  other2: undefined // also ok before and after
  // missing other3: error before and after


New package: RadiantCommunity.GtkRadiant version 1.5.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Closes #115056.
Tested and works fine.
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/116360&drop=dogfoodAlpha

I really doubt that icculus.org would "prohibit distribution or use by third parties". :-)

@wingetbot waivers Add Validation-Domain

/azp run


Update GenericComponent.tsx

Add undefined check before referring contexts object in getAxisCanvas/getMouseCanvas functions. Current code works(npm start) fine but will lead to error like "TypeError: Cannot read property 'mouseCoord' of undefined" in jest snapshot generation process.

Checklist

[Yes] My commits follow Conventional Commits
[Yes] documentation is updated

When does this occur? I'm currently rewriting the library so I can add a test case in to cover it.


Aps migration - Polybase

Aps migration - Polybase

@ms-arali,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Issue Pulling The Status On My Dragino LPS8 915

Hello....I am trying to get my DATA Only gateway registered on the network and after I run the command "helium_gateway key info". I get the error below:
Error: Service(Service(tonic::transport::Error(Transport, hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 146, kind: ConnectionRefused, message: "Connection refused" })))))
I am including my logs below:
Mon Feb 28 10:22:00 2022 user.notice iot_keep_alive: Internet Access OK: via eth1
Mon Feb 28 10:22:00 2022 user.notice iot_keep_alive: use WAN or WiFi for internet access now
Mon Feb 28 10:22:15 2022 user.notice iot_keep_alive: Internet Access OK: via eth1
Mon Feb 28 10:22:15 2022 user.notice iot_keep_alive: use WAN or WiFi for internet access now
Mon Feb 28 10:22:20 2022 daemon.err uhttpd[4050]: wc: /tmp/logfile.log: No such file or directory
Mon Feb 28 10:22:20 2022 daemon.err uhttpd[4050]: sh: 2000000: unknown operand
Mon Feb 28 10:22:23 2022 daemon.err uhttpd[4050]: wc: /tmp/logfile.log: No such file or directory
Mon Feb 28 10:22:23 2022 daemon.err uhttpd[4050]: sh: 2000000: unknown operand
Mon Feb 28 10:22:23 2022 daemon.err uhttpd[4050]: killall: logread: no process killed
Mon Feb 28 10:22:26 2022 daemon.info fwd[20924]:
Mon Feb 28 10:22:26 2022 daemon.info fwd[20924]: ################[PKT_SERV] no report of this service ###############
Mon Feb 28 10:22:26 2022 daemon.info fwd[20924]: PKTUP~ [server2] JSON: {"stat":{"time":"2022-02-28 16:22:26 UTC","rxnb":0,"rxok":0,"rxfw":0,"ackr":0.0,"dwnb":0,"txnb":0,"pfrm":"SX1308","mail":"dragino-1f7e68@dragino.com","desc":"Dragino LoRaWAN Gateway"}}
Mon Feb 28 10:22:26 2022 daemon.info fwd[20924]: PKTUP~ [server] JSON: {"stat":{"time":"2022-02-28 16:22:26 UTC","rxnb":0,"rxok":0,"rxfw":0,"ackr":0.0,"dwnb":0,"txnb":0,"pfrm":"SX1308","mail":"dragino-1f7e68@dragino.com","desc":"Dragino LoRaWAN Gateway"}}
Mon Feb 28 10:22:30 2022 user.notice iot_keep_alive: Internet Access OK: via eth1
Mon Feb 28 10:22:30 2022 user.notice iot_keep_alive: use WAN or WiFi for internet access now
What am I missing here? Thank you.

the heliujm_gateway service actually needs to be running before you can talk to it. How was helium-gateway installed?

the heliujm_gateway service actually needs to be running before you can talk to it. How was helium-gateway installed?

I have installed it and I did start the Helium Gateway Service, but it is taking forever to start up. I installed the latest version of the Helium Dragino alpha.22.ipk.

for me everythings was working until 2:00 am ( western time -7 ).  I tried all the solutions from here from different firmware et gateway-rs and it's still the same.  The problem could be with the connection with Helium to give new animal name ?

Same here with lps8 868. Gui says:

gateway-rs status
No Gateway-rs Connected

| gateway-rs version | helium_gateway 1.0.0-alpha.22

  | Hostpot key | NULL!

  | Hostpot animal name | NULL!

I start the Helium service by initiating the following start command. It as been going on for almost 24 hours now and all I get is the following screen capture. I do no know how long this is supposed to go on for. Any idea what I am missing here? Thank you.

gateway-rs status

the heliujm_gateway service actually needs to be running before you can talk to it. How was helium-gateway installed?

I just installed using these commands:
Dowload
wget -O helium-gateway-v1.0.0-alpha.22-dragino.ipk https://github.com/helium/gateway-rs/releases/download/v1.0.0-alpha.22/helium-gateway-v1.0.0-alpha.22-dragino.ipk
Installation
opkg install /tmp/helium-gateway-v1.0.0-alpha.22-dragino.ipk
I can not get the status.......I run the command and I get the results above in my previous posts. Thanks.

sorry then why do you close this?

sorry then why did you close this issue?

I never closed it. I did not even know it was closed. Someone else might have?

sorry then why did you close this issue?

I never closed it unless I was not paying attention and did it by accident. I did not even know it was closed. Can I reopen it?
Your account closed the issue for sure:

sorry then why did you close this issue?

I never closed it unless I was not paying attention and did it by accident. I did not even know it was closed. Can I reopen it?
Your account closed the issue for sure:

Yes I saw it before. So I see there is a bug in Alpha 22 so I am downgrading to Alpha 21.

Note that this release https://github.com/helium/gateway-rs/releases/tag/v1.0.0-alpha.23 should fix the issue

Note that this release https://github.com/helium/gateway-rs/releases/tag/v1.0.0-alpha.23 should fix the issue

Thank I downloaded it and tried it out and I get the below error:

Do you know how I can fix this? Image Metadata not found invalid image type. Thank you.

Now this issue is resolved. All of this because of bad firmware, but thank you for your help.

Yeah looks like you were confused between a gateway-rs release and a dragoon firmware release? This repo is really not responsible for or able to help with dragino firmware support.
I’m glad you got it working. Was it just a dragino firmware update?

I’m glad it’s working for you. The alpha software releases will contain bugs and I’m sorry you had issues


add velocity proxy support

add docs (presumably to README and/or website)
potentially fix bug with it too apparently it might not work? 🤷

TODO: Add actual docs.
But in essence the way you will have to set up your velocity is to not forward any player information (it must behave like vanilla. Not like bungeecord default or velocity modern). Hyperion is offline only as well afaik. Might want to add support for those handshakes in the future.

TODO: Add actual docs.
But in essence the way you will have to set up your velocity is to not forward any player information (it must behave like vanilla. Not like bungeecord default or velocity modern). Hyperion is offline only as well afaik. Might want to add support for those handshakes in the future.

definitely had it online thur velocity at one point but changed a bit

Velocity can be in online mode. But the forwarding data that velocity would usually send is leading to crashes. And velocity already handles the user authentication anyways.

Velocity can be in online mode. But the forwarding data that velocity would usually send is leading to crashes. And velocity already handles the user authentication anyways.

yea ok we are on same page... yea short term all making this online would be by using a proxy (say velocity)
what is th ebenefit of using the default velocity forwarding method aside from it working out of the box? if it makes sense would you be interested in makign a PR to fix it so it works out of the box?

It is pretty easy to implement and has the added benefit of being able to get a players actual ips and a few other things. You can also set it up so that you require a key from the proxy (thus making sure no one can just bypass the firewall and impersonate others). Valence already has this implemented so it is not that complicated to do. Still not the highest priority

It is pretty easy to implement and has the added benefit of being able to get a players actual ips and a few other things. You can also set it up so that you require a key from the proxy (thus making sure no one can just bypass the firewall and impersonate others). Valence already has this implemented so it is not that complicated to do. Still not the highest priority

meh ok... hm.. well feel free to impl actually. think it will be useful for testing & new contributors

Still splitting the Issue to make it more clear that you can actually run it already and prioritize it differently.

Freeing this for others since I don't have anything specific done yet. I would also consider this Issue as completed if #703 is implemented and it is documented somewhere on how to switch between the forwarding modes.


Add/aws profile option

Hello, I added a cli argument to let users to pass the name of the awscli configured profile to use when running the command.
I think it is very useful especially on machines, like mine, where there are multiple aws configs configured.
Please let me know if in some way the style of the update doesn't match your own style, and feel free to update it yourself. I'm very new to go language 😄
Thanks,
Simone

:+1: for this configuration option! Would be great to get this into the tool :)
Perhaps the ability to use the AWS_PROFILE env variable instead of a cli flag would be nice too


Manage issues

We should auto label issues when they are raised especially now we have the issue and feature issue templates
we should also add the needs triage tag

We can do this via actions

is this easily scalable?
I kinda want to set at org level and forget :)

What labels should we be adding to what, and how should we be triaging things?


[BUG]When the remote client locks the system or enters the password input screen, the remote control screen displays black

Quasar version
1.4.0
Server installed .NET version
.NET 4.5.2
Server operating system
Windows 10/Server 2019/2016
Client installed .NET version
.NET 4.5.2
Client operating system
Windows 10/Server 2019/2016
Build configuration
Release
Describe the bug

**When the remote host is in the state of user input password, or the system such as WindowsServer 2019 is in the lock state, it cannot display the remote desktop properly！！！**However, you must manually enter the password on the remote host to enter the desktop
How to reproduce

You can use WindowsServer 2008 2019 2022. After RDP leaves, you cannot enter it again, and the remote desktop displays a black background
Common Windows11 When you enter the startup password in Windows10, the remote desktop cannot be displayed normally and turns black

Expected behavior
Should display normally but cant
Actual behavior
The remote desktop is all black
Additional context
No response

Now I understand, thank you. Unfortunately it's a known issue and not fixed yet:

https://github.com/quasar/Quasar/issues/733

#733

UAC？

User Access Control

-----> https://github.com/quasar/Quasar/issues/733


support create tag/branch

Why are the changes needed?

(For example: The Arctic Flink dataStream API has already supported this configuration: 'scan.startup.mode', but it is not available with Flink SQL. We should expose this configuration to users when they are using Flink SQL.)
Brief change log
(For example:)

Add the 'scan.startup.mode' configuration to the ArcticScanContext in the flink modules
The Flink 1.12 and 1.14 versions are affected.
Add the documentation in the flink chapter

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Codecov Report

Merging #16 (c911f75) into master (f66d287) will decrease coverage by 0.05%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
- Coverage     48.71%   48.67%   -0.05%
+ Complexity      584      582       -2
============================================
  Files            46       46
  Lines          4368     4368
  Branches        508      508
============================================
- Hits           2128     2126       -2
- Misses         2005     2009       +4
+ Partials        235      233       -2

Flag
Coverage Δ

trino
48.67% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


DrawTextureEx, DrawTexturePro, ect, not drawing

I was trying to draw scaled textures and I was not able to. While DrawTexture works, any of the other texture drawing methods that allow for scaling seem to be broken.
If I try this zig code:
const std = @import("std");
const rl = @import("raylib");

const window_width = 800;
const window_height = 600;

pub fn main() anyerror!void {
    rl.InitWindow(window_width, window_height, "Nemo Font Converter");
    rl.SetTargetFPS(60);

    var img = rl.GenImageChecked(512, 512, 12, 12, rl.RED, rl.BLUE);
    defer rl.UnloadImage(img);

    var tex = rl.LoadTextureFromImage(img);
    defer rl.UnloadTexture(tex);

    while (!rl.WindowShouldClose()) {
        rl.BeginDrawing();
        rl.ClearBackground(rl.WHITE);
        var pos = rl.Vector2{ .x = 0, .y = 0 };
        rl.DrawTextureEx(
            tex,
            pos,
            @as(f32, 0),
            @as(f32, 2),
            rl.WHITE,
        );

        rl.EndDrawing();
    }

    rl.CloseWindow();
}

I only get a while screen, while the same code in C gives me the correct result:
#include "raylib/src/raylib.h"

int main() {
    InitWindow(800, 600, "Textur test");
    SetTargetFPS(60);

    Image img = GenImageChecked(512, 512, 12, 12, RED, BLUE);

    Texture2D tex = LoadTextureFromImage(img);

    while (!WindowShouldClose()) {
        BeginDrawing();

        Vector2 pos = { .x = 0, .y = 0 };

        DrawTextureEx(tex, pos, 0, 2, WHITE);

        EndDrawing();
    }

    UnloadImage(img);
    UnloadTexture(tex);
}

I have tried with both system and compiled raylib and get the same results. I am using macOS:
INFO: Initializing raylib 4.0
INFO: DISPLAY: Device initialized successfully
INFO:     > Display size: 1920 x 1080
INFO:     > Screen size:  800 x 600
INFO:     > Render size:  800 x 600
INFO:     > Viewport offsets: 0, 0
INFO: GL: Supported extensions count: 43
INFO: GL: OpenGL device information:
INFO:     > Vendor:   Apple
INFO:     > Renderer: Apple M1
INFO:     > Version:  4.1 Metal - 76.3
INFO:     > GLSL:     4.10

❯ zig version
0.10.0-dev.378+40b3c9a59

Well this seems to be the same type of issue: https://github.com/ziglang/zig/issues/10560, and the cause is that the C abi compatibility is not complete yet: https://github.com/ziglang/zig/issues/1481. The  ARM: struct & union parameters is still not implemented, so this should be the issue here.

I could verify that indeed this was the issue by creating a wrapper function in c:
#include "../raylib-zig/raylib/src/raylib.h"

void _DrawTextureExWrapper(Texture2D tex, float x, float y, float rotation, float scale, Color color) {
    Vector2 pos = { .x = x, .y = y };
    DrawTextureEx(tex, pos, rotation, scale, color);
}

When I called this function from zig, rendering of the texture worked as expected.

Late to the party, but wanted to throw this out there:
https://github.com/pfgithub/mousegame
This project is old, but seems to have an interesting approach to working around this in the aptly named 'workaround' c, h, and zig files.  Not sure how well it works in practice, but  wanted to put it here for others to find and spur on more creative solutions, if nothing else.

The way mousegame works around the issue indeed seems to be the only way at the moment. For raylib 3.0 there is the workaround branch, but since struct parameters are supported on x86_64 it's no longer maintained. Fixing these C ABI issues is way out of scope for raylib-zig, but feel free to update the branch with a PR

With https://github.com/ziglang/zig/issues/1481 being closed, could you check this again?

Passing structs smaller than 16 bytes is still broken when enabling any of the release optimizations in the latest 0.11.0-dev compiler. This breaks raymath completely, as it relies heavily on Vector2 and Vector3. Only solution is to stick to debug builds, for now.

https://github.com/ziglang/zig/issues/14262

The way mousegame works around the issue indeed seems to be the only way at the moment.

Another workaround is adding unused fields to the C structs. E.g. giving Vector3 a w component and assigning a default 0 in the zig bindings.

https://github.com/ziglang/zig/issues/13830 and by extension https://github.com/ziglang/zig/issues/14262 are closed. Could you check this again?

Didn't retest the changes. But as long as these bindings officially only target zig 0.10.X, we should keep the issue open. The fix for sub-16 byte structs only exists in the 0.11.X branch.

Good note. Once 0.11 is released I'll update the binding accordingly and all this will hopefully work


How I can get the edited images?

Hi, thanks for your excellent work! I ran "ns-viewer --load-config {outputs/.../config.yml} " and get the edited 3D gs models,and how can I get the edited images 2D images?

Hi, there, you need to render your images from your 3D model, see https://github.com/ActiveVisionLab/gaussctrl?tab=readme-ov-file#movie_camera-render-your-results


push! performance tweaks

This PR should speed up pushing to typical, multileveled Trace objects and reduces allocations, but comes at the cost of simple Trace object performance. @HenriDeh What do you think?
using ReinforcementLearningTrajectories
using ReinforcementLearningTrajectories: AbstractTrace
using BenchmarkTools

t = Traces(;
a=[1, 2],
b=Bool[0, 1]
)

@btime push!(t, (; a=3, b=true))
# After: 283.039 ns (7 allocations: 224 bytes)
# Before: 184.911 ns (7 allocations: 192 bytes)

t = CircularArraySARTTraces(;
capacity=3,
state=Float32 => (2, 3),
action=Float32 => (2,),
reward=Float32 => (),
terminal=Bool => ()
)

@btime push!(t, ((state=ones(Float32, 2, 3), action=ones(Float32, 2))))
# After: 408.960 ns (10 allocations: 528 bytes)
# Before: 1.146 μs (22 allocations: 816 bytes)

Codecov Report

Merging #37 (e025c89) into main (1f2be9a) will decrease coverage by 0.25%.
The diff coverage is 77.77%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   69.34%   69.09%   -0.25%
==========================================
  Files          13       12       -1
  Lines         561      563       +2
==========================================
  Hits          389      389
- Misses        172      174       +2

Impacted Files
Coverage Δ

src/traces.jl
83.52% <77.77%> (-0.72%)
:arrow_down:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


constructor attempt 1

So, I've been inspecting values with the debugger and came up with a solution for class constructors.
Since I don't know the internals of typescript, it might not be an entirely safe version (for some reason, I had to cast a string to any).
This version is not yet trying to resolve the missing access modifiers.

I see - but I saw it too late.
I guess if we both work on these issues we need to align. I've implemented support, too - but reusing the getFunctionType. I also added support for private and protected modifiers.

no worries. It was good to get a little more into the code and maybe help out at some other time.


x/image/font: wrong rendering of intersecting paths

What version of Go are you using (go version)?

$ go version
go version go1.11.1 windows/amd64

What did you do?
Parse APL386 true type font with github.com/golang/freetype/truetype and render U+2262 with golang.org/x/image/font Drawer.DrawString.
I'll update with a link to example code and images shortly.
What did you expect to see?
A rendering of the rune, that has intersecting paths. The intersecting regions should be filled (with black color).
What did you see instead?
Intersecting regions are not filled, they are left white.

Here is example code with rendered images:
https://github.com/ktye/goissues/tree/master/28932


add: Danilo Donado

Description
Hi there. I'm new to open-source coding and interested in helping, developing new skills, and connecting with people.
Related Issues
Adding my profile data.
Changes Proposed
Following the instructions and making the pull request as suggested.
Checklist

[ ] I have read and followed the Contribution Guidelines.
[ ] All new and existing tests passed.
[ ] I have updated the documentation to reflect the changes I've made.
[ ] My code follows the code style of this project.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@DaniloDO Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


Advenced log system

Advenced log system

You shouldn't rely on the debug event to log your commands.
There is an event called 'commandRun' use that to log your commands and usage.


[OCPNODE-521] Add CRD ImageDigestMirrorSet and ImageTagMirrorSet

Add CRD ImageDigestMirrorSet and ImageTagMirrorSet to have API for epics:

https://issues.redhat.com/browse/OCPNODE-521: different API for two saprate lists for digest
image pull and tag image pull using mirrors.
https://issues.redhat.com/browse/OCPNODE-810: add an option for user to choose if the source of
the mirror should be denied if the mirrors pull failed.

Enhancement: https://github.com/openshift/enhancements/pull/929

@umohnani8 @mrunalp PTAL

@mtrmac PTAL.

/approve

/lgtm

/label docs-approved

/label

/label px-approved
/label qe-approved


webpack4 sideEffects:false cause compile error

when set sideEffects=false causes module.id==null then throw exceptions, how to solve that?
RuntimeTemplate.moduleId(): Module<EMAIL_ADDRESS>has no id. This should not happen.

It looks like you just deleted our issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please open a new issue with filled issue template.


mimalloc 2.1.7 & 1.8.7

Before adding new features and new modules, please go to issues to submit the relevant feature description first.
Write good commit messages and use the same coding conventions as the rest of the project.
Please commit code to dev branch and we will merge into master branch in feature
Ensure your edited codes with four spaces instead of TAB.

增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

Please add only one version per pr for ci test

since a newer version than 1.8.7 is already present, the CI won't test it anyway, it only tests the last one, right?

since a newer version than 1.8.7 is already present, the CI won't test it anyway, it only tests the last one, right?

right, this would require an improved test script, or commenting out the higher version first to test the lower version.

Improve test script or make two package
mimalloc1 -> 1.x
mimalloc -> 2.x

I don't think we should split packages by their version except in some cases (like openssl)
maybe we could somehow extract added version in the test script, based on git diff perhaps

add_version_branch("1.x", "2.x")
-- Test script will test 1.x and 2.x latest version


⚠ Bofrost.be has degraded performance

In f9e44a1, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1292 ms

Resolved: Bofrost.be performance has improved in 1201038 after 8 minutes.


How to set environment variable before pushing to two repos?

Hi,
I am trying to push to two different AWS ECR repos in different AWS regions. Here is my config:
[
      "@codedependant/semantic-release-docker",
      {
        "dockerTags": [
          "{{version}}"
        ],
        "dockerImage": "repo1",
        "dockerRegistry": "account.dkr.ecr.us-east-1.amazonaws.com"
      }
    ],
    [
      "@codedependant/semantic-release-docker",
      {
        "dockerTags": [
          "{{version}}"
        ],
        "dockerImage": "repo2",
        "dockerRegistry": "account.dkr.ecr.us-east-2.amazonaws.com"
      }
    ]

I authenticate with the AWS ECR before running semantic-release (npx semantic-release --extends ./.releaserc.json --debug).
I would like to set an environment variable (change the AWS_REGION) before running the second push. Is there a way to specify this before running the push in code here? I want to avoid having two separate semantic-release jobs in my CI file to prevent bumping the version twice.
Thanks in advance!

Spoke too soon. I guess I could just slot in semantic-release/exec in between the two plugins to export my variable.
Is there a way around this using this plugin? If not, that's fine :)

There isn't a way to do that with this plugin specifically, no. But the exec plugin seems like a fine way