Spelling and typo fixes

Fix some types in Transaction.rs and encode.rs

BTW. In Fedimint someone introduced https://github.com/crate-ci/typos and it's really nice - focused around low false positives, so it catches what it's confident in, and doesn't require too much maintenance. So far so good.

CI failure is unrelated to this PR.


Steam startup fix

When launching Assassins creed 2 through steam an extra handshake has to occur between steam and ubisoft connect. Due to this, umod was exiting before the game had time to open and the textures were not injected.
A demonstration of this can be seen in the following video. The console states that the game has closed and the playstation textures are not applied.
I found that the opening time varied quite a bit and I adjusted the delay time to try and strike a balance between allowing enough time for steam to sort itself out but also not wait too long.

Thanks for taking the time to check this out 👍

Thanks for this change. I'll have to tweak around with it when .NET 9 releases cause that's when I plan on doing a big rewrite on this project. Right now I'm just collecting all of the information to know what I need to fix for that eventual rewrite.


RandomForest segfaults once deserialized.

When using the python interface, if we serialize and then deserialize a RandomForest object, we will get a segfault if we try to call the apply_regression method from the deserialized object. See the code below for an example.
#!/usr/bin/env python
# coding: utf-8

import shogun as sg
import numpy as np

# Create random features
X_train = np.random.normal(0, 1, (100, 5))
betas = np.random.normal(0,1, 5)
y_train = np.dot(X_train, betas)

X_test = np.random.normal(0, 1, (10, 5))
y_test = np.dot(X_test, betas)

features_train = sg.create_features(X_train.T)
features_test = sg.create_features(X_test.T)
labels_train = sg.create_labels(y_train)
labels_test = sg.create_labels(y_test)

# Create the random forest object
mean_rule = sg.create_combination_rule("MeanRule")
rand_forest = sg.create_machine("RandomForest", labels=labels_train, num_bags=5,
                                seed=1, combination_rule=mean_rule)

rand_forest.train(features_train)
labels_predict = rand_forest.apply_regression(features_test)

# Serialize the model
model_file_path = './sample_model.json'
sg.serialize(model_file_path, rand_forest, sg.JsonSerializer())

# Deserialize the model and return
deserialized_rand_forest = sg.as_machine(sg.deserialize(model_file_path, sg.JsonDeserializer()))
labels_train_predict = deserialized_rand_forest.apply_regression(features_test)

Hmmm, I guess this is why the random forest meta example sometimes fails locally... Have you tried to run it in gdb yet?

Hmmm, I guess this is why the random forest meta example sometimes fails locally... Have you tried to run it in gdb yet?

Nope, I still need to check properly.

The stacktrace is the following:

From what I can tell is that m_root contains a nullptr. It seems like that is the default value in the default constructor. And you can see that it says there that m_root has not been added to the parameter framework, so it is not being serialised. I am not sure why it is not being registered as an SGObject though? That should work fine.

Thank you @gf712 for the insight!

If we add m_root as a parameter we will get the following messages once we try to deserialize:
[06/09/20 10:45:49 error] Could not create 'BinaryTreeMachineNode' class
[06/09/20 10:45:49 warning] Error while deserializeing RandomCARTree: ShogunException: Could not create 'BinaryTreeMachineNode' class

The issue should be caused because of this reason below here (taken from the source code).
// the problem is "CARTree"/"RandomCARTree" can't be cloned because
// they inherit from TreeMachine which is templated and can't be
// created in class_list
// SG_ADD((std::shared_ptr<SGObject>*)&m_root,"m_root", "tree structure");

I am not super familiar with the serialization framework, so are there any possible ways to make it work again?

Hmm I see, it needs the template parameter. @vigsterkr I guess we just need to add a non templated TreeMachineNode?

Got a segfault as well deserializing a random forest using c++ (develop version and release 6.1.4). Same issue was presented in previous issues, latter discussed a workaround:
https://github.com/shogun-toolbox/shogun/issues/3481
https://github.com/shogun-toolbox/shogun/issues/4242
Is there any update to this issue?

Got a segfault as well deserializing a random forest using c++ (develop version and release 6.1.4). Same issue was presented in previous issues, latter discussed a workaround:
https://github.com/shogun-toolbox/shogun/issues/3481
https://github.com/shogun-toolbox/shogun/issues/4242
Is there any update to this issue?


CSS Guidelines

Congratulations with the new site and and the beta.0 milestone looks really good.
I am missing examples for typography and everything css related like bootstrap have it.
Last, does material2 have a responsive grid based on flexbox?
Thanks

See #205 and https://github.com/angular/flex-layout/

I would prefer a "normal" grid. I have tried the flex-layout demo and it is slow to layout its elements.


⚠ Bofrost.lu has degraded performance

In 8ed12d4, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1312 ms

Resolved: Bofrost.lu performance has improved in 0beb63d after 6 minutes.


feat: Add additional labels to containerdisks

What this PR does / why we need it:
Add additional labels to containerdisks which can carry information like an
appropriate instancetype or preference to use with the containerdisk.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Merge after #74
Release note:

Provide labels with default instancetype and preference in containerdisks

Looks like pull-containerdisks-test is not happy. Can you please take a look?

@jcanocan That is fixed by rebasing on #74 + https://github.com/kubevirt/project-infra/pull/3214 :)

@jcanocan That is fixed by rebasing on #74 + kubevirt/project-infra#3214 :)

All right! Thanks!
/lgtm

/lgtm cancel

/retest-required

Great! Thanks for the code and for answering my concerns.
/lgtm

/lgtm

/approve


Base simulators got merged

Description

BaseTeleportationSimulator logic was merged into BaseInteractionSimulator.
Type of change

[x] Chore

Relates

https://github.com/Innoactive/Creator-Pro/pull/74

Why is this change necessary?

Why is this change necessary?

@SimonTheSourcerer asked for it when reviewing #48, but we never write it down anywhere.

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


replace http.request with the request library to be able to use proxies

Added request module to enable proxies specified by environment variables:
HTTP_PROXY and HTTPS_PROXY

Looking.

LGTM.

<EMAIL_ADDRESS>published.


Minimum require laravel 5.2 not 5.1

Filesystem::dirname and ressoure_path are not present in laravel 5.1
i will try to get it working on 5.1 and then do a PR

Noticed this myself.  Also, even after forcibly publishing the config, it still throws the resource_path is undefined error from the root config file.

I'm working on this matter at the moment.

The package now supports laravel 5.1 by using proper methods. Please check version 1.1.0 https://github.com/themsaid/laravel-langman/releases/tag/v1.1.0

Getting Language file  .php not found now.  But the original error is gone.

@stygiansabyss on what command? also can you share your language files structure?

File structire: https://infinit.io/_/iJtG2ee
Command: langman:show base
Command output: https://infinit.io/_/egi9AB9

@stygiansabyss I can't regenerate the issue on laravel 5.1 PHP7.
It has something to do with the command not reading the given filename.

In the commands, the parseKey method is aiming to set the file and key.  But if it throws the undefined offset exception, nothing sets the file.  Changing it to the following has seemed to fix it.
    /**
     * Parse the given key argument.
     *
     * @return void
     */
    private function parseKey()
    {
        try {
            list($this->file, $this->key) = explode('.', $this->argument('key'));
        } catch (\ErrorException $e) {
            $this->file = $this->argument('key');
            // If explosion resulted 1 array item then it's the file, we
            // leave the key as null.
        }
    }

But fixing that brought up another potential problem.  Does this package handle array values?  I have this in the base.php lang file.
<?php

return [
    /*
    |--------------------------------------------------------------------------
    | Menu Translations
    |--------------------------------------------------------------------------
    */
    'menu'    => [
        'admin'     => 'Admin',
        'moderator' => 'Mod',
    ],

And I am getting back:
[ErrorException]
strstr() expects parameter 1 to be string, array given

Nope, array values and sub directories are not supported at the moment. I'm working on these issues.
Are you on PHP7 or lower while adding this fix?

I am on 5.6.11 locally.  Server runs 7.

In the tableRows() method I changed it to the following and it seems to work.
        foreach ($this->files as $language => $file) {
            foreach ($filesContent[$language] = $this->manager->getFileContent($file) as $key => $value) {
                if (! $this->shouldShowKey($key)) {
                    continue;
                }

                if (is_array($value)) {
                    foreach ($value as $valueKey => $singleValue) {
                        $newKey = $key .'.'. $valueKey;

                        $output[$newKey]['key'] = $newKey;
                        $output[$newKey][$language] = $singleValue;
                    }
                } else {
                    $output[$key]['key']     = $key;
                    $output[$key][$language] = $value;
                }
            }
        }

<?php

namespace Themsaid\Langman\Commands;

use Illuminate\Console\Command;
use Themsaid\Langman\Manager;
use Illuminate\Support\Str;

class ShowCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'langman:show {key} {--c|close}';

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $description = 'Show language lines for a given file or key.';

    /**
     * Filename to read from.
     *
     * @var string
     */
    protected $file;

    /**
     * Key name to show results for.
     *
     * @var string
     */
    protected $key;

    /**
     * The Languages manager instance.
     *
     * @var \Themsaid\LangMan\Manager
     */
    private $manager;

    /**
     * Array of requested file in different languages.
     *
     * @var array
     */
    protected $files;

    /**
     * ListCommand constructor.
     *
     * @param \Themsaid\LangMan\Manager $manager
     *
     * @return void
     */
    public function __construct(Manager $manager)
    {
        parent::__construct();

        $this->manager = $manager;
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $this->parseKey();

        $this->files = $this->filesFromKey();

        $this->table(
            array_merge(['key'], $this->manager->languages()),
            $this->tableRows()
        );
    }

    /**
     * The output of the table rows.
     *
     * @return array
     */
    private function tableRows()
    {
        $allLanguages = $this->manager->languages();

        $output = [];

        foreach ($this->files as $language => $file) {
            foreach ($filesContent[$language] = $this->manager->getFileContent($file) as $key => $value) {
                if (! $this->shouldShowKey($key)) {
                    continue;
                }

                if (! is_array($value)) {
                    $output[$key]['key']     = $key;
                    $output[$key][$language] = $value;
                } else {
                    $output = $this->getArrayValues($output, $key, $language, $value);
                }
            }
        }

        // Now that we collected all existing values, we are going to
        // fill the missing ones with emptiness indicators to
        // balance the table structure & alert developers.
        foreach ($output as $key => $values) {
            $original = [];

            foreach ($allLanguages as $languageKey) {
                $original[$languageKey] = isset($values[$languageKey]) ? $values[$languageKey] : '<bg=red>  MISSING  </>';
            }

            // Sort the language values based on language name
            ksort($original);

            $output[$key] = array_merge(['key' => "<fg=yellow>$key</>"], $original);
        }

        return array_values($output);
    }

    /**
     * Array of requested file in different languages.
     *
     * @return array
     */
    private function filesFromKey()
    {
        try {
            return $this->manager->files()[$this->file];
        } catch (\ErrorException $e) {
            $this->error(sprintf('Language file %s.php not found!', $this->file));

            return [];
        }
    }

    /**
     * Parse the given key argument.
     *
     * @return void
     */
    private function parseKey()
    {
        try {
            list($this->file, $this->key) = explode('.', $this->argument('key'));
        } catch (\ErrorException $e) {
            $this->file = $this->argument('key');
            // If explosion resulted 1 array item then it's the file, we
            // leave the key as null.
        }
    }

    /**
     * Determine if the given key should exist in the output.
     *
     * @param $key
     *
     * @return bool
     */
    private function shouldShowKey($key)
    {
        if ($this->key) {
            if (! $this->option('close') && $key != $this->key) {
                return false;
            }

            if ($this->option('close') && ! Str::contains($key, $this->key)) {
                return false;
            }
        }

        return true;
    }

    private function getArrayValues($output, $key, $language, $value)
    {
        foreach ($value as $valueKey => $singleValue) {
            $newKey = $key . '.' . $valueKey;
            if (is_array($singleValue)) {
                $output = $this->getArrayValues($output, $newKey, $language, $singleValue);
            } else {
                $output[$newKey]['key']     = $newKey;
                $output[$newKey][$language] = $singleValue;
            }
        }

        return $output;
    }
}

Made this version of the ShowCommand class.  Works well actually.
~/Code/Personal/HatFilmsNew(branch:new*) » php artisan langman:show servers
+-------------------------+---------------------------------------------------------------------------------------+
| key                     | en                                                                                |
+-------------------------+---------------------------------------------------------------------------------------+
| menu.main               | Servers                                                                               |
| item                    | Server                                                                                |
| page_title              | Server List Management                                                                |
| messages.deleted        | Server entry deleted.                                                                 |
| messages.updated        | Server entry updated.                                                                 |
| messages.created        | Server entry created.                                                                 |
| labels.game             | Game                                                                                |
| labels.name             | Server Name                                                                           |
| labels.type             | Type                                                                                |
| labels.description      | Description                                                                           |
| labels.address          | Server Address                                                                        |
| labels.password         | Server Password                                                                       |
| views.index.title       | Server List                                                                           |
| views.index.information | Server Information                                                                    |
| views.index.name        | Server Name                                                                           |
| views.index.type_name   | Server Type                                                                           |
| views.index.address     | Server Address                                                                        |
| views.index.password    | Server Password                                                                       |
| views.index.description | Description                                                                           |
| views.index.type        | Type                                                                                |
| views.index.game        | Game                                                                                |
| manage.create.title     | Create a new server                                                                   |
| manage.edit.title       | Update server                                                                         |
| manage.help             | If this is a game server, select it here.  If the type is not GAME, leave this blank. |
+-------------------------+---------------------------------------------------------------------------------------+

@stygiansabyss nice :) can you please submit a PR ?

Working on that now sir.

@stygiansabyss please notice that I pushed a new release, v1.1.1 with fixes for the PHP5 issue. The package now is tested on PHP 5.5.9, 5.6, and 7.

I'm closing this issue, please open a new issue in case you had any other problems.


$(( $(x) ... )) highlighting has different scopes than $(x)

There is highlighting for both of these lines, but it is inconsistent:
changed=$(echo "$gitstatus" | egrep "^ [MR]" | wc -l)
plus=$(($(echo "$gitstatus" | egrep "^[ C]A" | wc -l) + $(echo "$gitstatus" | egrep "^\?\?" | wc -l)))

Scopes are different for:

echo, egrep,  wc (probably all the same rule)
the egrep's match text
the wc's -l flag

Should be resolved by cdd7eb44fe08ae58053fc0fcabd6026523afbe93.


Script error when accessing a document created by ProseMirror example on dashboard

Description:
Script error when accessing a document created by ProseMirror example on dashboard
After creating the document of the ProseMirror example of the JS SDK, there seems to be a script error occurring when accessing the document on the Dashboard.
In the example, the selection is saved as a byte array type in the document to propagate it to the peers.

However, this seems to be causing a script error when performing JSON.parse on the Dashboard.
Why:

can I try this?

@DongjaJ Sure.
The error occurs when assigning a byte array(Uint8Array) to a document.
https://github.com/yorkie-team/yorkie-js-sdk/blob/c12ef2583ad0f85c4774eea30f8451a93262f0d3/test/integration/primitive_test.ts#L58-L68

I found the following error in the process of re-creating this issue.

create the document of the ProseMirror example of the JS SDK
access the document on the Dashboard
click another tab (ex. Project overview, api, setting...)

And I could not recreate Error on this issue

We have stabilized yorkie.Tree until the v0.4.7 release. For now, the error described in this issue does not recur for now.
For https://github.com/yorkie-team/dashboard/issues/130#issuecomment-1656606798:
I have confirmed that the issue described in the comment still occurs in development mode. This is only happening in the development environment, so I guess it is related to the development mode.


Linux Snap Packing

Hello,
I am the developer on a project called Electron Player and I recently moved to use your package for the Linux version of the app (couldn't get Mac working but that's another problem). I package the app using electron-builder and for one of my publishing platforms, I am using snapcraft as it is popular on Linux. I had to pull the update changing to your package as I noticed it would not launch and after some debugging, I am pretty sure the cause is your package. It works outside of the snap environment but inside it does not. Snapcraft sandboxes applications running in it and looking at the logs it is blocking a sysctl call. I assume whatever this call is it is being blocked and is causing everything after to fail and hence the app to never launch. Is there a possible fix for this? My codebase is linked above and the error it is showing in the snap developer logs when starting the application is below. I also need to try and fix this as fast as possible as I moved to your package as a fix to the broken Netflix player, one of the main functions of the application.
= AppArmor =
Time: Jun 18 19:22:14
Log: apparmor="DENIED" operation="open" profile="snap.electronplayer.electronplayer" name="/proc/11538/setgroups" pid=11538 comm="electronplayer" requested_mask="w" denied_mask="w" fsuid=1000 ouid=1000
File: /proc/11538/setgroups (write)
Suggestion:
* adjust program to not access '@{PROC}/@{pid}/setgroups'

All your help will be appreciated

Hi,
I took a quick look and this appears to be a feature of the linux sandboxing that Chromium uses. I don't have time for a deeper delve into this right now as I'm on PTO for another week but I would suggest trying to pass the --no-sandbox option when you start Electron and see if it makes a difference.

Thanks that helped fix the problem. There was a bug fix in the latest alpha version of electron-builder which disables the sandbox for the snap version of the application.


APIError should make message more readily available to end users

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe.
Currently you can access the APIError's code but not the message that is also returned with it. This seems to have been an oversight.
Describe the solution you'd like.
A new property called "message" that returns the message, just like how the code is returned by the "code" property.
Describe an alternate solution.
N/A
Anything else? (Additional Context)
No response

Once this is merged, it makes solving #136 slightly easier as well...or at least fewer lines of code.


fix(ws): Handle a ws erroring

This should fix https://sentry.turret.streamjar.io/streamjar/beta-bot/issues/1317/

Coverage decreased (-2.06%) to 97.938% when pulling 1d0bba252f1cd42b6464375d1282cbcc761d4365 on fix/crash-on-ws-error into ca2f142ed7b24847bb10fefe0a3e3925367cac35 on master.


error in running pre-processing step

$ python run_preprocessing.py -m train
Traceback (most recent call last):
File "run_preprocessing.py", line 17, in
from dataset import run_preprocessing_BraTS2017_trainSet, run_preprocessing_BraTS2017_valOrTestSet
File "/home/poornachandra/Downloads/brats_github/BraTS2017-master/dataset.py", line 22, in
from utils import reshape_by_padding_upper_coords
File "/home/poornachandra/Downloads/brats_github/BraTS2017-master/utils.py", line 16, in
import theano.tensor as T
File "/home/poornachandra/anaconda2/lib/python2.7/site-packages/theano/init.py", line 124, in
from theano.scan_module import (scan, map, reduce, foldl, foldr, clone,
File "/home/poornachandra/anaconda2/lib/python2.7/site-packages/theano/scan_module/init.py", line 41, in
from theano.scan_module import scan_opt
File "/home/poornachandra/anaconda2/lib/python2.7/site-packages/theano/scan_module/scan_opt.py", line 60, in
from theano import tensor, scalar
File "/home/poornachandra/anaconda2/lib/python2.7/site-packages/theano/tensor/init.py", line 17, in
from theano.tensor import blas
File "/home/poornachandra/anaconda2/lib/python2.7/site-packages/theano/tensor/blas.py", line 155, in
from theano.tensor.blas_headers import blas_header_text
File "/home/poornachandra/anaconda2/lib/python2.7/site-packages/theano/tensor/blas_headers.py", line 987, in
if not config.blas.ldflags:
File "/home/poornachandra/anaconda2/lib/python2.7/site-packages/theano/configparser.py", line 332, in get
val_str = self.default()
File "/home/poornachandra/anaconda2/lib/python2.7/site-packages/theano/configdefaults.py", line 1408, in default_blas_ldflags
check_mkl_openmp()
File "/home/poornachandra/anaconda2/lib/python2.7/site-packages/theano/configdefaults.py", line 1252, in check_mkl_openmp
raise RuntimeError('To use MKL 2018 with Theano you MUST set "MKL_THREADING_LAYER=GNU" in your environement.')
RuntimeError: To use MKL 2018 with Theano you MUST set "MKL_THREADING_LAYER=GNU" in your environement.

Hi there,
it seems like your theano installation does not work. If that is the case then this is not an issue related to our project.
Try running the following command from your shell:
python -c "import theano"
Regards,
Fabian
PS: The error message you got gives you a hint what to do.

To use MKL 2018 with Theano you MUST set "MKL_THREADING_LAYER=GNU" in your environement.

Thanks for the input Sir...
On Mon, Feb 12, 2018 at 1:41 PM, Fabian Isensee<EMAIL_ADDRESS>wrote:

Hi there,
it seems like your theano installation does not work. If that is the case
then this is not an issue related to our project.
Try running the following command from your shell:
python -c "import theano"
Regards,
Fabian
PS: The error message you got gives you a hint what to do.
To use MKL 2018 with Theano you MUST set "MKL_THREADING_LAYER=GNU" in your
environement.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MIC-DKFZ/BraTS2017/issues/1#issuecomment-364852155,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXsXKCXMAT__PR8oExqxPPIHi_yCZtZEks5tT_JMgaJpZM4SA5PB
.

--
warm regards,
Poornachandra S
+91-9901913049


[stable/spinnaker] This allows for ephemeral halyard deployments

This give you the ability to deploy to clusters without pvc support.
Co-authored-by: Paul Czarkowski<EMAIL_ADDRESS>Co-authored-by: JJ Asghar<EMAIL_ADDRESS>Signed-off-by: JJ Asghar<EMAIL_ADDRESS>Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/lgtm


Fix 'character maps to ' issue on windows

Fixes #21

Hey @koaleksa, thanks a lot for the PR and fixing the issue! I was just wondering whether this could break the behavior in certain cases where the markdown file was not saved as utf-8? I think this is still much better than leaving it out as in the original, though. Should it maybe be at least overridable via a CLI argument? Do you have any thoughts about this?

Hi @raethlein, there are probably very few reasons why one would want to write a text file (markdown in particular) with any other encoding these days. An argument could be made, of course... If there are such users, the code will still run for them as function simply opens the file in write mode and replaces the content, but the encoding will indeed change for them under their feet.
I think, for a lightweight tool, I'd advocate for keeping things simple and adding options only when there's specific expressed interest, rather than going by unlikely scenarios, honestly. However, a CLI override would be trivial to implement so if you'd still prefer to expose the option, I'll be happy to amend this PR.
Thank you guys for the awesome tool, btw. 👍
For some interesting read on this topic, I suggest having a look at PEP597

Thanks a lot for your detailed thoughts and I totally agree with your assessment! I am going to merge it then :)


chore(docs): add README

add README.md

@sbyse Is the naming of app is solid? Saferplace, SaferPlace or Safer Place for users?


Support Request: Need Recommendation for DI

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[x] Support request
[ ] Other... Please describe:

Current behavior
Currently, there is no clear way to inject services/tokens for use with rtk-query.

Expected behavior
I would like to inject HttpClient for use as a custom query function. The sample code below intends to use fetchFn, but that may not be the actual solution. The only problem I'm trying to solve is providing HttpClient, then using that for network requests.

Minimal reproduction of the problem with instructions
// features.api.ts
import { createApi } from 'ngrx-rtk-query';
import { configureBaseQuery } from '@app/shared/data-access/+store';

export const featuresApiKey = 'featuresCache';
const cacheTags = {
    enabledFeatures: 'enabledFeatures'
};

export const featuresApi = createApi({
    reducerPath: featuresApiKey,
    tagTypes: Object.values(cacheTags),
    baseQuery: configureBaseQuery('/api'),
    endpoints: (build) => ({
        getEnabledFeatures: build.query<Array<string>, string>({
            query: (organizationId) => ({
                url: `/organizations/${organizationId}/features`
            })
        })
    })
});

export const { useGetEnabledFeaturesQuery } = featuresApi;

// configure-base-query.ts
export const configureBaseQuery = (endpointUrl: string, maxRetries: number = 0): BaseQueryFn => {
    return retry(
        fetchBaseQuery({
            // fetchFn: httpClient,
            baseUrl: `${endpointUrl}`,
            prepareHeaders: (headers: Headers, api) => {...}
        }),
        { maxRetries }
    );
};

What is the motivation / use case for changing the behavior?
We sometimes use angular services rather than rtk-query for network requests. We want our HttpInterceptors to work for both rtk-query and angular services.
Environment

Angular version: 12.2.0

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [x] Edge version 95.0.1020.30

@SaulMoro Thanks for the response. I haven't had a chance to circle back to this yet. We've decided to move forward by putting interceptor logic somewhere that both angular interceptors and rtk middlewares can use.
I like the injector idea, but we have to jump through a few hoops to ensure we don't end up with circular dependencies. Especially with Nx.


Install VirtualBox and Docker Toolbox from cask

Sorry, it's obvious that over time I had made a number of commits that I never pushed. I promise to be more diligent in the future!


LFS storage

Currently, the ismrmrdviewer repository is neutered by the fact that the ismrmrd organization is out of LFS storage.
This means noone can pull or push to ismrmrdviewer or indeed any forks, due to the novel way GitHub registers LFS storage.
Our options are:

Remove LFS objects from ismrmrdviewer (this means all tests data).
or
Pay for LFS.

@hansenms Could you guys be persuaded to sponsor the LFS data?

@dchansen we don't really have a practical way of sponsoring that.
The data is not really used as test data as such (it is not needed at build time or in a pipeline).....more example data, so I think there are probably other options. Like putting the test in some other public data repo. That would be my suggestion.

Turns out uninstalling git lfs from the repo solves the issue.


Don't merge "src/"

I don't know if/how this works, apparently this time submodule src/ is in here (but wasn't last time?) I don't know if that actually has any influence on a merge - I tried using git submodules a loooong time ago and only remember that it was painful (but I find a lot of git-things painful).
This should get rid of all "Unhandled Promise Rejection" messages and fix one or two issues, for example with test 0.9.6.
Later tonight, hopefully, the PR for the actual RMFB repo.

I'll try again.


chore(metrics): expose MetricsInterface as return type of single metric and further improve API docs

Summary
Changes

Please provide a summary of what's being changed

This PR started out with the goal of modifying the return type of the Metrics.singleMetric() method to use MetricsInterface instead of Metrics. This small change allows for easier customization of the utility and avoids a cyclical type reference.
While working on this, I realized that the MetricsInterface was out of date and had no documentation whatsoever, which means its API page is empty and there's no contextual documentation in the IDE when customers hover any of the interface or properties.
At that point the goal shifted towards making sure the methods and their API docs in the Metrics class and the MetricsInterface were aligned. In doing so, I also noticed that some of the public methods were somewhat under documented and at least in some cases, there were opportunities to either clarify the purpose of the method or add a code snippet.
This ended becoming a seizable PR that further improved on the work started by @am29d in a previous PR and complemented the API docs added in that PR by expanding some of the descriptions and introducing a bunch of links between methods/sections.
For example, now the API docs for the addMetric() method goes in detail on how to use the method but also links to other relevant parts of the API docs:

This work was enabled by @am29d's work on fixing our TypeDoc setup and making sure links are properly rendered & followed. I have applied this type of pattern across the entire Metrics package and also made sure all code samples and wording is consistent across API docs & README.
Finally, while there, I noticed that we had a public method named throwOnEmptyMetrics() which was severely under documented and that didn't do what I'd have expected it to do. I marked it as deprecated in favor of a newly added method setThrowOnEmtpymetrics(enabled: boolean) which is clearer on its purpose and is also aligned with other similar public setter methods in terms of naming.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3132

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

The 2 accepted issues marked by SonarCloud are related to the deprecated method still being used in the unit tests. For now I marked them as such since these tests will be refactored soon when moving the utility to Vitest, and the method will eventually be removed in the next major version.


Issue while installing caddy

Info:

Docker version ($ docker --version): 19.03.1
Laradock commit ($ git rev-parse HEAD): 71372ef12bccd4fc9af5175739e84b52aeffd3e9
System info (Mac, PC, Linux): PC
System info disto/version:

Issue:
It runs step 1,2,3/7, but in step 4 it stops at github.com/go-acme/lego (download) download it seems that it doesnt find the package: package github.com/go-acme/lego/v3/acme: cannot find package "github.com/go-acme/lego/v3/acme" in any of:...

Expected behavior:
Success on step 4 I guess?

Reproduce:
with ./docker-start.sh

Relevant Code:
the log output

$ ./docker-start.sh
Building caddy
Step 1/7 : FROM zuohuadong/caddy:alpine
 ---> 737043e11080
Step 2/7 : LABEL maintainer="Huadong Zuo<EMAIL_ADDRESS> ---> Using cache
 ---> 844a1b76b9e0
Step 3/7 : ARG plugins="cors"
 ---> Using cache
 ---> 717aa7ad9107
Step 4/7 : RUN caddyplug install ${plugins}
 ---> Running in a6b5550ef7ae
installing cors...
github.com/captncraig/cors (download)
github.com/caddyserver/caddy (download)
github.com/google/uuid (download)
github.com/flynn/go-shlex (download)
github.com/mholt/certmagic (download)
github.com/go-acme/lego (download)
Fetching https://golang.org/x/crypto/ocsp?go-get=1
Parsing meta tags from https://golang.org/x/crypto/ocsp?go-get=1 (status code 200)
get "golang.org/x/crypto/ocsp": found meta tag get.metaImport{Prefix:"golang.org/x/crypto", VCS:"git", RepoRoot:"https://go.googlesource.com/crypto"} at https://golang.org/x/crypto/ocsp?go-get=1
get "golang.org/x/crypto/ocsp": verifying non-authoritative meta tag
Fetching https://golang.org/x/crypto?go-get=1
Parsing meta tags from https://golang.org/x/crypto?go-get=1 (status code 200)
golang.org/x/crypto (download)
package github.com/go-acme/lego/v3/acme: cannot find package "github.com/go-acme/lego/v3/acme" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/acme (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/acme (from $GOPATH)
package github.com/go-acme/lego/v3/acme/api: cannot find package "github.com/go-acme/lego/v3/acme/api" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/acme/api (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/acme/api (from $GOPATH)
package github.com/go-acme/lego/v3/certcrypto: cannot find package "github.com/go-acme/lego/v3/certcrypto" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/certcrypto (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/certcrypto (from $GOPATH)
package github.com/go-acme/lego/v3/challenge: cannot find package "github.com/go-acme/lego/v3/challenge" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/challenge (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/challenge (from $GOPATH)
package github.com/go-acme/lego/v3/log: cannot find package "github.com/go-acme/lego/v3/log" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/log (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/log (from $GOPATH)
package github.com/go-acme/lego/v3/platform/wait: cannot find package "github.com/go-acme/lego/v3/platform/wait" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/platform/wait (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/platform/wait (from $GOPATH)
Fetching https://golang.org/x/net/idna?go-get=1
Parsing meta tags from https://golang.org/x/net/idna?go-get=1 (status code 200)
get "golang.org/x/net/idna": found meta tag get.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at https://golang.org/x/net/idna?go-get=1
get "golang.org/x/net/idna": verifying non-authoritative meta tag
Fetching https://golang.org/x/net?go-get=1
Parsing meta tags from https://golang.org/x/net?go-get=1 (status code 200)
golang.org/x/net (download)
Fetching https://golang.org/x/text/secure/bidirule?go-get=1
Parsing meta tags from https://golang.org/x/text/secure/bidirule?go-get=1 (status code 200)
get "golang.org/x/text/secure/bidirule": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/secure/bidirule?go-get=1
get "golang.org/x/text/secure/bidirule": verifying non-authoritative meta tag
Fetching https://golang.org/x/text?go-get=1
Parsing meta tags from https://golang.org/x/text?go-get=1 (status code 200)
golang.org/x/text (download)
Fetching https://golang.org/x/text/unicode/bidi?go-get=1
Parsing meta tags from https://golang.org/x/text/unicode/bidi?go-get=1 (status code 200)
get "golang.org/x/text/unicode/bidi": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/unicode/bidi?go-get=1
get "golang.org/x/text/unicode/bidi": verifying non-authoritative meta tag
Fetching https://golang.org/x/text/unicode/norm?go-get=1
Parsing meta tags from https://golang.org/x/text/unicode/norm?go-get=1 (status code 200)
get "golang.org/x/text/unicode/norm": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/unicode/norm?go-get=1
get "golang.org/x/text/unicode/norm": verifying non-authoritative meta tag
package github.com/go-acme/lego/v3/certificate: cannot find package "github.com/go-acme/lego/v3/certificate" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/certificate (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/certificate (from $GOPATH)
package github.com/go-acme/lego/v3/challenge/resolver: cannot find package "github.com/go-acme/lego/v3/challenge/resolver" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/challenge/resolver (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/challenge/resolver (from $GOPATH)
package github.com/go-acme/lego/v3/registration: cannot find package "github.com/go-acme/lego/v3/registration" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/registration (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/registration (from $GOPATH)
github.com/klauspost/cpuid (download)
github.com/hashicorp/go-syslog (download)
github.com/lucas-clemente/quic-go (download)
package github.com/lucas-clemente/quic-go/h2quic: cannot find package "github.com/lucas-clemente/quic-go/h2quic" in any of:
        /usr/local/go/src/github.com/lucas-clemente/quic-go/h2quic (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/lucas-clemente/quic-go/h2quic (from $GOPATH)
github.com/russross/blackfriday (download)
Fetching https://gopkg.in/natefinch/lumberjack.v2?go-get=1
Parsing meta tags from https://gopkg.in/natefinch/lumberjack.v2?go-get=1 (status code 200)
get "gopkg.in/natefinch/lumberjack.v2": found meta tag get.metaImport{Prefix:"gopkg.in/natefinch/lumberjack.v2", VCS:"git", RepoRoot:"https://gopkg.in/natefinch/lumberjack.v2"} at https://gopkg.in/natefinch/lumberjack.v2?go-get=1
gopkg.in/natefinch/lumberjack.v2 (download)
exit status 1
 ✗ cors
ERROR: Service 'caddy' failed to build: The command '/bin/sh -c caddyplug install ${plugins}' returned a non-zero code: 1

Hi @jacoboospina
because the base image is outdated
You can update your Dockerfile to latest version if you not required to install plugin

Hello... @ahkui
so you mean my caddy->Dockerfile is outdated? Should I replace with the code you referenced this issue?

Hi @jacoboospina

so you mean my caddy->Dockerfile is outdated? Should I replace with the code you referenced this issue?

If you need install extra plugin then use my reference, otherwise use this

I only need cors plugin... so this is my Dockerfile:
FROM zuohuadong/caddy:alpine

LABEL maintainer="Huadong Zuo<EMAIL_ADDRESS>
ARG plugins="cors"

## ARG plugins="cors cgi cloudflare azure linode"

RUN caddyplug install ${plugins}

EXPOSE 80 443 2015

WORKDIR /var/www/public

CMD ["/usr/bin/caddy", "-conf", "/etc/Caddyfile","-agree"]

Still doesnt work I'm having same mistake:
$ docker-compose build caddy
Building caddy
Step 1/7 : FROM zuohuadong/caddy:alpine
 ---> 737043e11080
Step 2/7 : LABEL maintainer="Huadong Zuo<EMAIL_ADDRESS> ---> Using cache
 ---> 03857a4aa5e1
Step 3/7 : ARG plugins="cors"
 ---> Using cache
 ---> e681a094ad8d
Step 4/7 : RUN caddyplug install ${plugins}
 ---> Running in f29655fbce63
installing cors...
github.com/captncraig/cors (download)
github.com/caddyserver/caddy (download)
github.com/google/uuid (download)
github.com/flynn/go-shlex (download)
github.com/mholt/certmagic (download)
github.com/go-acme/lego (download)
Fetching https://golang.org/x/crypto/ocsp?go-get=1
Parsing meta tags from https://golang.org/x/crypto/ocsp?go-get=1 (status code 200)
get "golang.org/x/crypto/ocsp": found meta tag get.metaImport{Prefix:"golang.org/x/crypto", VCS:"git", RepoRoot:"https://go.googlesource.com/crypto"} at https://golang.org/x/crypto/ocsp?go-get=1
get "golang.org/x/crypto/ocsp": verifying non-authoritative meta tag
Fetching https://golang.org/x/crypto?go-get=1
Parsing meta tags from https://golang.org/x/crypto?go-get=1 (status code 200)
golang.org/x/crypto (download)
package github.com/go-acme/lego/v3/acme: cannot find package "github.com/go-acme/lego/v3/acme" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/acme (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/acme (from $GOPATH)
package github.com/go-acme/lego/v3/acme/api: cannot find package "github.com/go-acme/lego/v3/acme/api" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/acme/api (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/acme/api (from $GOPATH)
package github.com/go-acme/lego/v3/certcrypto: cannot find package "github.com/go-acme/lego/v3/certcrypto" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/certcrypto (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/certcrypto (from $GOPATH)
package github.com/go-acme/lego/v3/challenge: cannot find package "github.com/go-acme/lego/v3/challenge" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/challenge (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/challenge (from $GOPATH)
package github.com/go-acme/lego/v3/log: cannot find package "github.com/go-acme/lego/v3/log" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/log (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/log (from $GOPATH)
package github.com/go-acme/lego/v3/platform/wait: cannot find package "github.com/go-acme/lego/v3/platform/wait" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/platform/wait (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/platform/wait (from $GOPATH)
Fetching https://golang.org/x/net/idna?go-get=1
Parsing meta tags from https://golang.org/x/net/idna?go-get=1 (status code 200)
get "golang.org/x/net/idna": found meta tag get.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at https://golang.org/x/net/idna?go-get=1
get "golang.org/x/net/idna": verifying non-authoritative meta tag
Fetching https://golang.org/x/net?go-get=1
Parsing meta tags from https://golang.org/x/net?go-get=1 (status code 200)
golang.org/x/net (download)
Fetching https://golang.org/x/text/secure/bidirule?go-get=1
Parsing meta tags from https://golang.org/x/text/secure/bidirule?go-get=1 (status code 200)
get "golang.org/x/text/secure/bidirule": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/secure/bidirule?go-get=1
get "golang.org/x/text/secure/bidirule": verifying non-authoritative meta tag
Fetching https://golang.org/x/text?go-get=1
Parsing meta tags from https://golang.org/x/text?go-get=1 (status code 200)
golang.org/x/text (download)
Fetching https://golang.org/x/text/unicode/bidi?go-get=1
Parsing meta tags from https://golang.org/x/text/unicode/bidi?go-get=1 (status code 200)
get "golang.org/x/text/unicode/bidi": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/unicode/bidi?go-get=1
get "golang.org/x/text/unicode/bidi": verifying non-authoritative meta tag
Fetching https://golang.org/x/text/unicode/norm?go-get=1
Parsing meta tags from https://golang.org/x/text/unicode/norm?go-get=1 (status code 200)
get "golang.org/x/text/unicode/norm": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/unicode/norm?go-get=1
get "golang.org/x/text/unicode/norm": verifying non-authoritative meta tag
package github.com/go-acme/lego/v3/certificate: cannot find package "github.com/go-acme/lego/v3/certificate" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/certificate (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/certificate (from $GOPATH)
package github.com/go-acme/lego/v3/challenge/resolver: cannot find package "github.com/go-acme/lego/v3/challenge/resolver" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/challenge/resolver (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/challenge/resolver (from $GOPATH)
package github.com/go-acme/lego/v3/registration: cannot find package "github.com/go-acme/lego/v3/registration" in any of:
        /usr/local/go/src/github.com/go-acme/lego/v3/registration (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/go-acme/lego/v3/registration (from $GOPATH)
github.com/klauspost/cpuid (download)
github.com/hashicorp/go-syslog (download)
github.com/lucas-clemente/quic-go (download)
package github.com/lucas-clemente/quic-go/h2quic: cannot find package "github.com/lucas-clemente/quic-go/h2quic" in any of:
        /usr/local/go/src/github.com/lucas-clemente/quic-go/h2quic (from $GOROOT)
        /root/lib/caddy/gopath/src/github.com/lucas-clemente/quic-go/h2quic (from $GOPATH)
github.com/russross/blackfriday (download)
Fetching https://gopkg.in/natefinch/lumberjack.v2?go-get=1
Parsing meta tags from https://gopkg.in/natefinch/lumberjack.v2?go-get=1 (status code 200)
get "gopkg.in/natefinch/lumberjack.v2": found meta tag get.metaImport{Prefix:"gopkg.in/natefinch/lumberjack.v2", VCS:"git", RepoRoot:"https://gopkg.in/natefinch/lumberjack.v2"} at https://gopkg.in/natefinch/lumberjack.v2?go-get=1
gopkg.in/natefinch/lumberjack.v2 (download)
exit status 1
 ✗ cors
ERROR: Service 'caddy' failed to build: The command '/bin/sh -c caddyplug install ${plugins}' returned a non-zero code: 1

This base image(zuohuadong/caddy:alpine) outdated, because the author don't have update.
 I'm closing this issue.


bump to 0.9.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

6ca03ee025c457601aeae65c9b9cd96dece2854734678d5527c744020dae1128

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender


Detect Display Zoom

Detect if the display is zoomed or not

If you are talked about zoom feature in accessibility it's not going to be supported now. May be later, I can't tell.


Increase code coverage for Bundle.cpp

The goal is at least 80% code coverage for Bundle.cpp.
Signed-off-by: The Mathworks Inc<EMAIL_ADDRESS>

Codecov Report

Merging #248 into development will increase coverage by 0.7%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           development     #248     +/-   ##
==============================================
+ Coverage        81.59%   82.29%   +0.7%
==============================================
  Files              119      119
  Lines             7898     7898
==============================================
+ Hits              6444     6500     +56
+ Misses            1454     1398     -56

Impacted Files
Coverage Δ

framework/src/bundle/BundleManifest.cpp
93.57% <0%> (+18.34%)
:arrow_up:

framework/src/bundle/Bundle.cpp
97.25% <0%> (+19.78%)
:arrow_up:

Referencing #235


feat: introduce compile error if compiling with atomic on

This change introduce a compile error if the toolchain is using a target with atomics. It looks like at least on the the QingKe V4 atomics are suspiciously broken.
There is also a feature you can enable unsafe-trust-wch-atomics you can enable to remove this compile error
See issue: https://github.com/ch32-rs/ch32-hal/issues/59

Published as v0.5.0


vSphere deploy fails in upload elastic runtime setep

This is due to the pivnet cli not being present in the fetch directory.
upload-er-tile:
chmod: missing operand after '+x'
Try 'chmod --help' for more information.

I'm currently investigating this too as it's a blocker for me.

This is due to issue #25. To workaround temporarily, look at that issue and fix the globs line.

Perfect thanks - i Just discovered that too... you beat me to it!


Bulk API does not set Content-Type: application/x-ndjson

Which version of Elastic are you ussing?
[ ] elastic.v2 (for Elasticsearch 1.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[x] elastic.v5 (for Elasticsearch 5.x)
Please describe the expected behavior
The Elasticsearch documentation states that when using the Bulk API,  the Content-Type header should be set to application/x-ndjson.
Please describe the actual behavior
The requests this library sends do not set this header. Offending area of code seems to be https://github.com/olivere/elastic/blob/release-branch.v5/bulk.go#L237 - it should pass a content-type through, but doesn't.
Any steps to reproduce the behavior?
Make a bulk API request and check the server logs. A complaint about the missing content-type is issued.
We're observing this in  gitlab-elasticsearch-indexer and I don't see a good way to fix it without an upstream patch. Happy to prepare a PR for this if it'd be welcomed?

Yes, I've seen this message in the log as well, then checked the ES source and found it to be non-critical. Doesn't mean I don't want to fix it, but I have to refactor the PerformRequest method to do that correctly. It should be a good job for the v6 update that's going to be done in the next weeks.

Great, thanks for picking this up!


Fixed deck name pulling more than just the header

Fix for issue #24

Tell me if you want me to do anything extra

Thanks @MicahGV
A test would be good, similar to what I did here https://github.com/jasonwilliams/anki/blob/master/src/markdown/parsers/tests/cardParser.test.ts

Sure man

I ended up adding some additional linter config so when I created new files I wouldn't have to care about swapping it over from my default. Also, I hope it's alright if I only focused on the deckName method for the tests.

@MicahGV this is fantastic, those tests are awesome.
Thanks!


feat: added shimmer effect

Description

Added shimmer effect in all doctors page
Related Issues*

Fixes #172

## Checklist
- [x] I have forked the repo and pushed the changes according to contribution guidelines.
- [x] I have tested these changes locally.
- [x] I have tried to maintain the consistency of the code.
- [x] I have tested these changes locally.
- [x] I have updated the documentation accordingly.

@itsmohit097 Kindly assign this PR to me and add relevant labels .


Packages for Ubuntu 18.04

When will packages for Ubuntu 18.04 be made available for download?
https://www.arangodb.com/download-major/ubuntu/

We are currently working hard on finishing ArangoDB 3.4. The release candidate (RC) for 3.4 will be made available soon. This will be announced on the usual channels, such as our website and our community Slack. 3.4 will stay for some time in the RC phase before it will be made generally available GA.

For those looking for installation guide of ArangoDB on Ubuntu 18.04, below is a helpful guide:
https://computingforgeeks.com/how-to-install-arangodb-on-ubuntu-18-04/

Nice read @jmutai ;
Maybe you can fix the arangosh font by cut'n'pasting via a usual editor, so the color is seeded out,
or pick it from here:
                                       _
  __ _ _ __ __ _ _ __   __ _  ___  ___| |__
 / _` | '__/ _` | '_ \ / _` |/ _ \/ __| '_ \
| (_| | | | (_| | | | | (_| | (_) \__ \ | | |
 \__,_|_|  \__,_|_| |_|\__, |\___/|___/_| |_|
                       |___/

Thanks, @dothebart  for the comment.
I made the change and it looks great now.


Bump MSRV to 1.46 and release version 0.17.0

Our bitflags dependency decided to bump their minimum supported Rust version, so we must do the same.
Fixes #272 (which is long, long overdue)

Follow up to the MSRV discussion: naga, the Rust glsl compiler, had the same issue with their own MSRV and resolved it by making it incompatible with 1.3: https://github.com/gfx-rs/naga/blob/v0.6/Cargo.toml#L18-L19


Listing regions errors with "requires authentication"

Hello,
I got a service token created which has been validated as working with other API operations.
Trying to list regions:
regions, err := d.client.Regions.List(ctx, &planetscale.ListRegionsRequest{})
	if err != nil {
		fmt.Print(err.Error())
		return
	}

however this fails with
Requires authentication

I've enabled all permissions across the db and org for my service token but still returns this error. Am I doing something wrong probably or is this an actual issue with the sdk/API?
Update: I might need to go through the d.client.Organizations.ListRegions func instead, but then I don't get the difference between the two?

Sorry for the delay in responding to this. Yes, you'll want to use d.client.Organizations.ListRegions.
Context:
Service tokens are scoped to an organization. We have a small number of endpoints that are outside of the organization scope (such as d.client.Regions.List).
The difference between these endpoints is that d.client.Regions.List returns all regions we have available (to the currently logged in user). d.client.Organizations.ListRegions returns all regions available to an organization.
These two lists are in most cases identical. But for some organizations (such as those who use PlanetScale Managed), they have a different list of available regions.


Error with Angular 1.5.8

I see following in my Bower.
├─┬ ng-jwplayer#0.2.2
│ └── angular#1.5.8 incompatible with ~1.4.2 (1.4.14 available, latest is 1.6.0-rc.1)
Is there a challenge running this directive with 1.5.8?

No, it should work with 1.5.8. Need to update the dependency

Thanks @dkarchmer. Just tested it. I did work. I am not sure if bower is packaging 1.4.2 and 1.5.8 in my final distribution. I do have this in my bower.
"resolutions": {
"angular": "1.5.8",
"angular-cookies": "1.5.8"
}


Support gen 1 of the Powerview Hub?

It seems that the 1st gen Powerview hub is not supported. Can that be added?
I have installed the app on my Homey and once the IP address has been entered and the devices is turned on in Homey, it does see the scenes but they are not executed...
My assumption is that this is not a bug but that only newer hubs are supported even though there is no word on the app page about such a limitation.

The beta version in the Athom app store did not work with my v1 hub. The current github version is already working without any problems, not sure why an updated beta is not released yet on the Athom store, I am not from HUSS / Luxaflex / Athom..
In case you need help on installing a version from github source codd, please let me known.

Thanks! Will give it a try this weekend.
I think I can work it out but thanks for the offer. If I don't succeed, I'll reach out.

Did you manage to try? Does it work?

Did install the latest version from github. That didn't give a problem.
But didn't have time to solve the next issue: the scene that the hub nows are executed but the Luxaflex blinds don't move. Not even when using the Powerview app. No clue yet why because it used to work from the Powerview app. Hope to find time this weekend to further investigate

Fixed most issues today.
First, I identified that the Powerview app mistakenly thought that the batteries were empty. All are connected with a power adapter and don't use batteries... Refreshed the status in the Powerview app and 2 out of 3 started working again. The 3rd worked also after I disconnected and reconnected the power.
Second, the scenes appeared to be OK but when I went into the scene config and changed the position of the blinds just a fraction and the hit the button 'use current position' (or whatever it is called in English...) only then did they become responsive. No clue why, but this seems to have fixed it.
What remains is that a second scene command isn't executed from a flow in Homey. This has to be a timing issue because when I use the Powerview App, executing 2 scenes immediately after one and another doesn't work either. Yet, what I see in the Homey flow is, that the 2nd command isn't even executed. If I test the flow, the first command gets the green checkmark but the second command doesn't. It even doesn't start spinning (meaning it is trying to execute). I tried with a 10 seconds delay but that didn't resolve the issue.
The reason why I have 2 commands in a row is that I'm not convinced that the blinds always respond. A typical flow that is triggered when I want to almost close the open blinds is this: 1) close the blinds completely and 2) open them just a little.  May not be needed, but in case either one fails, the end-result is still giving the effect that I want: keeping the sun out.

There is a new version of the app available in the Athom App store which should work on the v1 hub.


Fixed iPad layout

That PR fixed the issue #96. Now the layout on iPad won't be anymore buggy (backgrounds fits...)
Nevertheless, the iPad's layout is still not really nice. Some easy customisation could improve that, for example: more static cells in the tableview, making the subviews always centered. That's not a priority, but could be another issue "nice to have".

Nice!

Well done.


Setup TRSS PR build via Netlify

Deploy Configure in Netlify:
Base directory: test-result-summary-client
Build command: npm ci --production --legacy-peer-deps;REACT_APP_CONNECT_ADOPTIUM_API=true CI=false npm run build;
Publish directory: test-result-summary-client/build

Opened issue at Eclipse: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/2105

Just for the record, please see Netlify docs for File-based configuration (netlify.toml): https://docs.netlify.com/configure-builds/file-based-configuration/


next-i18next not work in function component

I used the next-18next example. example url, and modified the i18n.js:
const { localeSubpaths } = require("next/config").default().publicRuntimeConfig;
const NextI18Next = require("next-i18next/dist/commonjs");

module.exports = new NextI18Next({
  otherLanguages: ["de"],
  localeSubpaths,
  detection: {
    order: ["querystring", "navigator"],
    lookupQuerystring: "lang"
  }
});

I added detection, then it worked well.  the request url : http://localhost:3000/?lang=de
But then I modified the index.js. I changed 'class' into function compnent:
import React from "react";
import PropTypes from "prop-types";

import { i18n, Link, withNamespaces } from "../i18n";

function Homepage(props) {
  const { t } = props;
  return (
    <React.Fragment>
      <button
        type="button"
        onClick={() =>
          i18n.changeLanguage(i18n.language === "en" ? "de" : "en")
        }
      >
        {t("h1")}
      </button>
      <Link href="/second-page">
        <button type="button">{t("to-second-page")}</button>
      </Link>
    </React.Fragment>
  );
}

Homepage.getInitialProps = async function(ctx) {
  return {
    namespacesRequired: ["common", "footer"]
  };
};

export default withNamespaces("common")(Homepage);

we used the url:  http://localhost:3000/?lang=de,  but detecting querystring was not work well.

I'm currently facing the same issue any progress? @huanglijiao

I can't replicate a problem using the code above, but maybe I'm not looking for the right bug.
When I use the above code and navigate to http://localhost:3000/?lang=de I see German and when I navigate to http://localhost:3000/?lang=en, I see English.  The one thing that I do see that may be an issue is that the 'lang query parameter does not change when you change the locale by clicking the button.  But, if this was even considered an issue, it would be a react-i18next or i18next issue, I believe.
@wcisco17 and @huanglijiao - Can you elaborate on what is not working?

Please provide a reproducible repository.

maybe you can refer to the demo. demo url

@huanglijiao I can't do npm install in that repo - it fails with a 404 on some package.

@isaachinman maybe you can try! some package can not affect “npm run dev”.

This works as expected for regular locales. It seems like you may be pointing out that regional locales are not supported yet. See #279.

@isaachinman you mean next-i18next can only support en and de ?  not support Chinese?

@isaachinman react-i18next can support Chinese?


Partial solution to Issue #308

This is partially solving #308
I wasn't able to test the functionality using the method from_csv_hash_with_headers because it wouldn't change the original values it was given, but only the local ones. So trying to increment the number I was testing by one, was impossible for the original value.
I found that I needed to pass the &block argument to from_csv and it's children to pass blocks correctly as it did not work otherwise.
I passed a very simple block, the file contains two lines and four fields, I am unsure if that's enough because it doesn't check many cases, it just checks if the functionality is there, and it's up to the user to go crazy with it.
This is my first contribution ever, I'd love to hear your thoughts.

I believe, that solving the issue "there are no test for <featurename>" includes some analysis for "how <featurename> should be used".
For all I can understand from discussion in https://github.com/SciRuby/daru/issues/308, expected usage of block passing to from_csv is "additional processing for each row".
So, "intuitive" example would be something like this:
df = Daru::DataFrame.from_csv('path/to/some.csv') { |row|
 [row[0].to_i, row[1] || 'Default', Date.parse(row[2]) ....
}

...which probably means you should not only write tests but adjust functionality itself.

@zverok You're right that's how it should work.

Closed due to no further progress.


[BUG] copilot error infinite loop

Describe the bug / 描述问题
SyntaxError: Invalid token in placeholder: '=""'
https://github.com/sunner/ChatALL/assets/428820/be83ba9f-a7cf-44e1-a1da-d76f4de3d647
To Reproduce / 复现步骤
SyntaxError: Invalid token in placeholder: '=""'
https://github.com/sunner/ChatALL/assets/428820/be83ba9f-a7cf-44e1-a1da-d76f4de3d647
Expected behavior / 期望行为
SyntaxError: Invalid token in placeholder: '=""'
https://github.com/sunner/ChatALL/assets/428820/be83ba9f-a7cf-44e1-a1da-d76f4de3d647
Screenshots / 截图
No response
Devtools Info / 开发者工具信息
SyntaxError: Invalid token in placeholder: '=""'
https://github.com/sunner/ChatALL/assets/428820/be83ba9f-a7cf-44e1-a1da-d76f4de3d647
OS and version / 操作系统版本
Windows 10
ChatALL version / ChatALL 版本
v1.61.92
Network / 网络
No
Additional context / 其它相关信息
No response

Anyone?

Sorry for the inconvenience. I wish I can fix this in the weekend.

I tried several ways to reproduce this problem. But failed.......
Have you ever tried prompting copilot in the inner browser window of ChatALL?

solved with
ChatALL-1.63.97-win-x64


Broken Process Pool - maybe not RAM related

I keep running into the same problem trying to run my analysis in fmriprep.
This is the command I'm running in the Mac terminal:
docker run -m="11.5g" --memory-swap="40g"  -ti --rm -v /Users/Blake/Documents/angular/Nifti:/data:ro -v /Users/Blake/Documents/angular:/out -v /Users/Blake/licenses/freesurfer/license.txt:/opt/freesurfer/license.txt poldracklab/fmriprep:latest /data /out/out participant --ignore fieldmaps
And I keep getting this same error:

exception calling callback for <Future at 0x7f9f2a882240 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/local/miniconda/lib/python3.6/site-packages/nipype/pipeline/plugins/multiproc.py", line 143, in _async_callback
result = args.result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.
exception calling callback for <Future at 0x7f9f2a805e80 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/local/miniconda/lib/python3.6/site-packages/nipype/pipeline/plugins/multiproc.py", line 143, in _async_callback
result = args.result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.
exception calling callback for <Future at 0x7f9f2a7c3438 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/local/miniconda/lib/python3.6/site-packages/nipype/pipeline/plugins/multiproc.py", line 143, in _async_callback
result = args.result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.
exception calling callback for <Future at 0x7f9f2a727ba8 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/local/miniconda/lib/python3.6/site-packages/nipype/pipeline/plugins/multiproc.py", line 143, in _async_callback
result = args.result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.
exception calling callback for <Future at 0x7f9f2a769f98 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/local/miniconda/lib/python3.6/site-packages/nipype/pipeline/plugins/multiproc.py", line 143, in _async_callback
result = args.result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.
exception calling callback for <Future at 0x7f9f2a757c88 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/local/miniconda/lib/python3.6/site-packages/nipype/pipeline/plugins/multiproc.py", line 143, in _async_callback
result = args.result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.
exception calling callback for <Future at 0x7f9f2a796940 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/local/miniconda/lib/python3.6/site-packages/nipype/pipeline/plugins/multiproc.py", line 143, in _async_callback
result = args.result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/local/miniconda/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.

I've updated to fmriprep 1.2.5 (I was getting the same error on 1.2.3 before I updated)
Also manually updated nipype after receiving the same error several times
Tried running the analysis on just one participant after I kept getting the same error trying to run it on nine. Running it one participant just lead to me arriving at the same error faster.

Any help would be much appreciated and I can send through more information if necessary.

I managed to get it working by using the plugin you suggested, thank you.


published self hosting .exe does not has blank app attributes

Describe the bug
I have an asp.net core app, using latest 2.2 version. I set the Product Name and Description under Package tab in Project > Properties. The compiled .dll file has the correct attributes under Details tab. But when I publish and it becomes an .exe it loses those attributes and they blank.
Expected behavior
For the published self hosting .exe to have the same product name, description and version as the .dll.

Thanks for contacting us, @sprocket99.
@vijayrkn can you please look into this as this is publishing related? Thanks.

For VS issues, please open a developer community issue. Documentation - https://developercommunity.visualstudio.com/content/problem/post.html?space=8

Is this VS related? You can publish without using VS, using dotnet publish I believe.


Multi-Admin Site Issue

When attempting to set up a multi-admin site, I encounter an error. After investigation, I believe this issue is caused by the hardcoded URL {% url "admin:toggle_sidebar" %} in template.
Error Message
Reverse for 'toggle_sidebar' not found. 'toggle_sidebar' is not a valid view function or pattern name.

first_page

Expected Behavior
I expect to be able to create multiple admin sites with their own URLs and configurations. However, the hardcoded URL seems to be preventing this from happening.
Reproducible Steps

admin.py

from django.contrib.admin import AdminSite
from apps.relay.models import XXModel
from unfold.admin import ModelAdmin

class UserAdminSite(AdminSite):
    site_header = "xxx"
    site_title = "xxx"
    index_title = "xxx"

user_admin_site = UserAdminSite(name="user_admin")

class XXAdmin(ModelAdmin):
    list_display = ("id", "user", "created_at", "updated_at")

user_admin_site.register(XXModel, XXAdmin)

urls.py
urlpatterns = [
    path("admin/", admin.site.urls),
    path("user_admin/", user_admin_site.urls),
]

o i found that i should use from unfold.sites import UnfoldAdminSite rather than from django.contrib.admin import AdminSite    from https://unfoldadmin.com/blog/migrating-django-admin-unfold
thanks for your great work 💗


Add dynamic options lists for blocks

We need a way to customize blocks depending on the node being edited. To address this, I found myself doing a few things:

Replaced the big, global CategoryFactory with a BlockBuilder that is instantiated for the currently selected block script. I don't super like how I did this - in particular that both picker.gd and block_canvas.gd instantiate their own (redundant) BlockBuilder instances. Getting it right means further adjusting how data flows between these things.
(I don't actually like the name BlockBuilder since it implies we're using the Builder pattern, which was my original intent but it is not what it is doing. Probably just BlockFactory would make sense).
But the big thing this gives us is BlockBuilder has a single function which generates a single big list of blocks, including variable blocks. It knows what node our block script belongs to. I think that is a reasonable thing for it to know, but we could specify some rules here like "don't do anything that makes it impossible to move a block script to another node."
With that said, I broke the variables category here - categories in general are a disaster in this branch - as well as
setup_custom_blocks() in node scripts.
I added a concept of extension scripts for block definitions. This is an extra GDScript property, so you can optionally attach a plain old Object with some functions defined. I did this for animationplayer_play.tres. We should take the time to actually specify an API here, and perhaps a BlockExtensionScript base class just to be sure. For now, I just have animationplayer_play.gd with func get_defaults_for_node(context_node: Node). It's a little broken still.
 The remaining work is pretty much go through and delete some now-obsolete code, fix some GUT tests, and fix one stubborn new bug (probably from clumsy rebasing) where a block script isn't loading if it has loose non-Entry blocks placed in it.
While I was here, I tore out some unnecessary optimization around BlocksCatalog / BlockFactory / CategoryFactory. I feel a bit guilty doing it, but I don't think we need to do any kind of indexed lookups here. A function that iterates through all the blocks and looks at their category names and then forgets about it is fine for the scale at hand.
A brave person in the future might come back and improve our plumbing a bit so we're passing a single BlockFactory from main_panel.gd down to its children instead of creating two different ones (one for the canvas and one for the picekr). But I think we're fine for the moment.
 So I took that out, and now BlockFactory has a single instantiate_block_by_name which has some smarts to generate a block right there if the name follows a particular "block_name:parameter" format.
To make that work, I also changed block_script_serialization.gd so all of our AST <-> block conversions are storing just the block name, instead of the whole block definition. (This was necessary because it doesn't know enough to deal with block factories, but previously it was talking to BlocksCatalog). I think that's fine (it means later on we instantiate from the name instead of from the definition), but if you know confidently either way I'd love to know before I break everything with that change :) If it does break everything, I have a slightly more complicated alternative in mind.

One last opinionated change here: my template editor / options list stuff came with a side-effect in our generated code: the AST to code block stuff helpfully wraps strings in quote marks, except when those strings come from an options list. We can't do that anymore since the value it sees is always just a string now :)
To address that, I added a way to specify a parameter substitution that won't be quoted: just {{parameter}} instead of {parameter}.

This then fails with error:
Parser Error: Identifier "ui_up" not declared in the current scope.

Oops! That happened because I removed some quote marks that were supposed to be there while I was tweaking all the blocks with options lists. The action_name property is always a STRING_NAME so it needed to be quoted. I fixed it by changing the code template to say "Input.is_action_{{action}}('{{action_name}}')" (with the new {{param}} syntax) so it's clear what we're expecting). And I changed the display template to have the correct type for that parameter, but option lists are troublesome because we just end up with whatever type is in the options list regardless of the parameter type. Maybe something should print a warning when there's a mismatch :thinking:

Thank you for your thorough review @dbnicholson ! It was super helpful. I got rid of the BlockFactory stuff, merged things back somewhat, but pulled that not-quite-one-time BlockCatalog setup outside of BlockScript and added a BlockEditorContext singleton which gives us effectively what I was getting out of that previous arrangement: a single thing that says "this is the block code node and block script we are looking at," along with a signal which fires when that changes.
Need to squash some commits and apparently fix some lingering issues with Godot 4.2.2 :cry: - but those should be small things. How's it looking at this point?

This is all rebased, passing tests, and ready to review :)

@dylanmccall @dbnicholson I gave it a quick test, and found the following error. Adding a "change rotation by" to the "on process" leaves the _on_process empty, thus failing with syntax error.

@dylanmccall @dbnicholson I gave it a quick test, and found the following error. Adding a "change rotation by" to the "on process" leaves the _on_process empty, thus failing with syntax error.
EDIT
In the output I see:
  res://addons/block_code/code_generation/block_ast.gd:120 - Trying to assign value of type 'float' to a variable of type 'String'.
  res://addons/block_code/code_generation/block_ast.gd:120 - Trying to assign value of type 'float' to a variable of type 'String'.

 Fixed :)


feat: Added new resource module Managed DevOps Pools - avm/res/dev-ops-infrastructure/pool

Description

This PR introduces the new Managed DevOps Pools as requested in https://github.com/Azure/Azure-Verified-Modules/issues/1217.
Adding @AlexanderSehr and @surajguptha for code review
Pipeline Reference

Pipeline

Type of Change

[x] Update to CI Environment or utilities (Non-module affecting changes)
[ ] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[x] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] I have run Set-AVMModule locally to generate the supporting module files.
[x] My corresponding pipelines / checks run clean and green without any errors or warnings

Hi @johnlokerse, please see my comments (with context) on the module proposal issue: Azure/Azure-Verified-Modules#1217 (comment)
Please don't merge this PR until the name adjustments requested there have been implemented. Thank you! CC: @AlexanderSehr

Fixed!

Fixed!

Thanks for the quick change, @johnlokerse!
Unfortunately, I'll need to ask for one more minor change. As per the naming convention for resource modules, the RT segment of the name must be in singular form.
Can you please change pools to pool everywhere in the code and at file/folder level? The correct full name is avm/res/dev-ops-infrastructure/pool.
I've updated this on the module proposal issue. I apologize for the inconvenience that not noticing this one was in plural form may have caused.
Thank you!

@AlexanderSehr, @johnlokerse, I've just submitted the necessary PR for the MAR manifest (a prerequisite for this PR to be merged). I'll let you know when it's merged.

Official public preview announcement from the PG: https://aka.ms/hellomdp

@matebarabas Done! Changed from pools to pool.
@AlexanderSehr I think the Bicep template is as done as it can get for now. Can you do a re-review?
A few things to know / questions:

The comment on observedCertificates if it's intended empty. The answer is yes. It is a required property, but is not used yet as far as I know. I asked the PG to see where this property is used in the portal, but no answer yet.
There is a quota on compute cores, different per region. I have tested in westeurope and raised the quota since I was rolling out multiple MDP resources. How to deal with this in the AVM automated test? (after merge)
Is there an Azure DevOps environment that we can run the test in during the AVM automated test? (after merge)
All static tests are valid, except for these points (which are worked on):

@AlexanderSehr, @johnlokerse, I've just submitted the necessary PR for the MAR manifest (a prerequisite for this PR to be merged). I'll let you know when it's merged.

MAR PR merged, so it's no longer blocking you.

@elizatargithub7, I'd like to assign this issue to you as the primary module owner, but I can't, due to GitHub paging issue we have, caused by the large Azure organization. Can you please try to self-assign this issue? Thanks!

@AlexanderSehr, @johnlokerse, I've just submitted the necessary PR for the MAR manifest (a prerequisite for this PR to be merged). I'll let you know when it's merged.

MAR PR merged, so it's no longer blocking you.

@AlexanderSehr @matebarabas
What actions are required to let the static validation succeed? It's currently failing on:

Owning team needs to be in the codeowners
Module identifier should be listed in issue template
Should have an expected telemetry identifier

perty is used in the portal, but no

Hey @johnlokerse,
regarding the locations it may make sense to hardcode them to a given location - that should very likely not be WestEurope as that one is quite busy. For that prupose you can introduce a different parameter in the test, e.g., enforcedLocation = ''' and use that for the test. You can then also remove the resourceLocation` parameter from the test and essentially exlude yourself from the location rotation.
Regarding the DevOps Environment not yet, but I guess we can create one any time. @matebarabas, can you take care of that? That is, create an ADO environment we can target for testing.
Regarding the remaining tests

With the latest update of the telemetry, that test should pass

For the codeownersfile to pass, we need the to-be module owner (@elizatargithub7) to create the required groups

avm-res-devopsinfrastructure-pool-module-owners-bicep (parent: avm-technical-reviewers-bicep)
avm-res-devopsinfrastructure-pool-module-owners-contributors (parent: avm-module-contributors-bicep)

in the Azure org and set their parent teams respectively. That's what will effectively grant the permissions to approve PRs for this module etc.

Finally, regarding the issue template, you can just add the entry at the correct alphabetically location in the dropdown of set template

@AlexanderSehr, I'm not sure about what exactly the ask is (and what are its implications). Can we please have a quick chat about it internally, tomorrow morning? Thanks!
FYI, I just drew Eliza's attention to the teams to be created and provided her with some more context.

Thanks for the review @AlexanderSehr I will take a look at those. Also, will look at the location suggestion 😃
FYI, @matebarabas and @AlexanderSehr, the Azure DevOps organization and Managed DevOps Pools must be in the same tenant to work. Therefore, AzDo needs an Entra ID connection that is the same tenant as the Managed DevOps Pools resource.

Thanks for the review @AlexanderSehr I will take a look at those. Also, will look at the location suggestion 😃
FYI, @matebarabas and @AlexanderSehr, the Azure DevOps organization and Managed DevOps Pools must be in the same tenant to work. Therefore, AzDo needs an Entra ID connection that is the same tenant as the Managed DevOps Pools resource.

On that note we may need @jtracey93's help, permission-wise. @jtracey93, could you try and create a test org & project in the AVM tenant?

Thanks for the review @AlexanderSehr I will take a look at those. Also, will look at the location suggestion 😃
FYI, @matebarabas and @AlexanderSehr, the Azure DevOps organization and Managed DevOps Pools must be in the same tenant to work. Therefore, AzDo needs an Entra ID connection that is the same tenant as the Managed DevOps Pools resource.

On that note we may need @jtracey93's help, permission-wise. @jtracey93, could you try and create a test org & project in the AVM tenant?

Let me try now

@AlexanderSehr & @johnlokerse - created one and a project in it: https://dev.azure.com/avmtestorg/dev-ops-infrastructure-pool-bicep-test

@AlexanderSehr you will have access to the entire ADO org with your account.
Let me know if anything else is needed

The next step will likely be #3015, that is to enable contributors to configure tenant specific values in a secure way.

@AlexanderSehr Implemented your feedback and re-ran deployment tests and they are deployed successfully (Defaults, Max and WAF). The only thing left is the update of the codeowners file, after that is implemented I can do an e2e test and show a green status badge.

@AlexanderSehr & @johnlokerse - created one and a project in it: https://dev.azure.com/avmtestorg/dev-ops-infrastructure-pool-bicep-test

@AlexanderSehr you will have access to the entire ADO org with your account.
Let me know if anything else is needed

@jtracey93 @AlexanderSehr Awesome! I forgot to mention that the deployment principal also requires permissions to create the AzDo agent pool. Permissions like this on organisation level should be enough:

@matebarabas @elizatargithub7 Are there any updates regarding the codeowners file? I would like to get this module out to the public. 😃

@matebarabas @elizatargithub7 Are there any updates regarding the codeowners file? I would like to get this module out to the public. 😃

Aside from the CODEOWNERS file, you'll probalby want this PR being merged first: #3015 . I hope we can agree on the approach this week and push it out.

@matebarabas @elizatargithub7 Are there any updates regarding the codeowners file? I would like to get this module out to the public. 😃

Thanks for your patience, @johnlokerse! I just pinged @elizatargithub7 internally to follow up on the remaining steps.

@matebarabas @elizatargithub7 Are there any updates regarding the codeowners file? I would like to get this module out to the public. 😃

Aside from the CODEOWNERS file, you'll probalby want this PR being merged first: #3015 . I hope we can agree on the approach this week and push it out.

Let me know when #3015 is merged so I can do my thing 😄

Thanks for your patience, @johnlokerse! I just pinged @elizatargithub7 internally to follow up on the remaining steps.

As I didn't hear back from @elizatargithub7 (currently on annual leave), I took the action and created the required 2 GitHub teams, making her maintainer of both.
@johnlokerse, this in theory should allow you to continue with the publication steps, once all other findings of the review are complete.

Thanks for your patience, @johnlokerse! I just pinged @elizatargithub7 internally to follow up on the remaining steps.

As I didn't hear back from @elizatargithub7 (currently on annual leave), I took the action and created the required 2 GitHub teams, making her maintainer of both.
@johnlokerse, this in theory should allow you to continue with the publication steps, once all other findings of the review are complete.

He can, yes. But we still should merge #3015 first.

Any preparations I can do beforehand for the merge?

@AlexanderSehr I see that #3015 is merged to main 😄 What things are expected from me for this change?

@AlexanderSehr I see that #3015 is merged to main 😄 What things are expected from me for this change?

Hey @johnlokerse,
there is already a Wiki article ready to be merged. You can already few it's content here.
It's a pretty quick setup, just requiring a KeyVault, a GitHub variable with it's name & the secret you want to pass into your test files :)

@AlexanderSehr I see that #3015 is merged to main 😄 What things are expected from me for this change?

Hey @johnlokerse, there is already a Wiki article ready to be merged. You can already few it's content here. It's a pretty quick setup, just requiring a KeyVault, a GitHub variable with it's name & the secret you want to pass into your test files :)

Looks good! I will take a look at it tomorrow. If I am scanning through my solution, the only thing I have to add is a link to the DevOpsInfrastructure principal right?

@AlexanderSehr I think I have the blocking issue too. MDP is a resource module 😃  See: https://github.com/johnlokerse/bicep-registry-modules/actions/runs/10683920384/job/29613128825#step:4:218.
@matebarabas  Also, I see that the codeowners file is not set yet is that correct? https://github.com/johnlokerse/bicep-registry-modules/actions/runs/10683920384/job/29613129309#step:4:263

@matebarabas Also, I see that the codeowners file is not set yet is that correct? https://github.com/johnlokerse/bicep-registry-modules/actions/runs/10683920384/job/29613129309#step:4:263

@johnlokerse, that seems correct. Just to clarify, this is not done by the core team, but rather by the module owner (or the person who works on the module's code) in the same PR where the code itself is first published to main. Could you do this? All you need to do is to add a record for the related team that would look like this: /avm/res/dev-ops-infrastructure/pool @Azure/avm-res-devopsinfrastructure-pool-module-owners-bicep @Azure/avm-module-reviewers-bicep - just please make sure you insert the new line so that the whole file is still alphabetically ordered. Thank you!

@AlexanderSehr I think I have the blocking issue too. MDP is a resource module 😃 See: https://github.com/johnlokerse/bicep-registry-modules/actions/runs/10683920384/job/29613128825#step:4:218.
@matebarabas Also, I see that the codeowners file is not set yet is that correct? https://github.com/johnlokerse/bicep-registry-modules/actions/runs/10683920384/job/29613129309#step:4:263

See comment 😉

@AlexanderSehr @matebarabas Feedback is implemented! Running tests...

@AlexanderSehr It's green!

@AlexanderSehr It's green!

That's great news. That only leaves us with the setup on our end using the Org @jtracey93 created. 💪
On that note, I wonder if you'd want to have any advice/notes that you'd like to add to the readme (like the things you mentioned here), or if you feel that the offical docs are good enough and folks will figure it out.
In case you want to, I just want to raise awareness for the fact that you can add a section with the header ## Notes in the readme and the generator will actually preserve anything you've written there. Including images (that should be in a src folder, if I'm not mistaken)

@AlexanderSehr It's green!

That's great news. That only leaves us with the setup on our end using the Org @jtracey93 created. 💪
On that note, I wonder if you'd want to have any advice/notes that you'd like to add to the readme (like the things you mentioned here), or if you feel that the offical docs are good enough and folks will figure it out. In case you want to, I just want to raise awareness for the fact that you can add a section with the header ## Notes in the readme and the generator will actually preserve anything you've written there. Including images (that should be in a src folder, if I'm not mistaken)

I will add a note that the principal used for deployment needs permissions in Azure DevOps. The rest is documented on the docs 😄

@jtracey93 Happy to help if needed, just send me a ping 😃

@jtracey93 Happy to help if needed, just send me a ping 😃

Thanks @johnlokerse, I'll try to set the pre-reqs up latest next week

Hi @johnlokerse, please see my comments (with context) on the module proposal issue: Azure/Azure-Verified-Modules#1217 (comment)
Please don't merge this PR until the name adjustments requested there have been implemented. Thank you! CC: @AlexanderSehr

Hey @matebarabas, the PR looks good from my side. As you're the one person that still has a 'requeste change' open that is blocking the merge, please also take a look and approve it as you see fit :)

@matebarabas Let me know if anything needs to be fixed or done on my side 😁

@matebarabas Let me know if anything needs to be fixed or done on my side 😁

Apologies, this got stuck. 😊It was about changing the module name to plural. I've approved it now, please feel free to merge this, whenever you're ready. Thanks!

@matebarabas Who can merge this PR? I believe @AlexanderSehr is OOF.

@matebarabas Who can merge this PR? I believe @AlexanderSehr is OOF.

Alright, I've just merged it. Thank you for all your efforts put into this! I'll proceed with the index updates.

Static validation failed (module not published): https://github.com/Azure/bicep-registry-modules/actions/runs/10927846592

@matebarabas Strange did not change anything after approval from @AlexanderSehr. I see the problem though and I am fixing it as we speak 😄

@matebarabas Fixed issue in the PR (magic number) #3333