ColorField does not accept pasting lower case hex code

Provide a general summary of the issue here
When pasting a lower case hex code (e.g. #e84e0f) into the ColorField, it stays empty. Pasting a upper cased one (e.g. #E84E0F) works.
🤔 Expected Behavior?
ColorField accepts pasting a lower cased hex code.
😯 Current Behavior
ColorField stays empty after pasting a lower cased hex code.
💁 Possible Solution
No response
🔦 Context
No response
🖥 Steps to Reproduce
https://codesandbox.io/p/sandbox/reverent-sun-c9cd2t

Copy lower cased hex code (#e84e0f)
Paste lower cased hex code in ColorField
Unexpected: ColorField stays empty (paste not working)

Version
react-aria-components 1.5.0
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
MacOS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

I've just tried this on Chrome on my Mac both in the sandbox and in our docs, it appears to work.
Could you provide a video showing it reproducing? Maybe I missed a step.


Add creation time for files and folders

Hello,
I have tested this dahliaOS version and the Files app does not support creation time (crtime/btime) for local folders and files.
https://github.com/dahliaOS/releases/releases/tag/201215-x86_64
Here more information about file system timestamps:
https://wiki.sleuthkit.org/index.php?title=Mactime_output

(Let's see if this works... Linked to PRO-63)


Request for Users

First, love your fork of this!
I like the one stop shop for everything, i saw a request to limit users to only viewing and not actually downloading or deleting anything. Along with that I think that adding something like [PlexRequest] (http://plexrequests.8bits.ca/) would be great. Users could request shows and then the admin could go in and approve them.

Personally I have no interest in this feature. I tried to add I limited account (read access) since it was requested but no one seemed to be willing to test everything so I just dropped it.

Aaah, well I would be willing to test if you ever wanted to try again. Not
a huge deal for me either. Will plan on just sending them to PlexRequest
directly and using HTPC Manager for myself.
Billy Schlotter
<EMAIL_ADDRESS>about.me/wschlotter
On Fri, Nov 6, 2015 at 10:04 AM, Hellowlol<EMAIL_ADDRESS>wrote:

Personally I have no interest in this feature. I tried to add I limited
account (read access) since it was requested but no one seemed to be
willing to test everything so I just dropped it.
—
Reply to this email directly or view it on GitHub
https://github.com/Hellowlol/HTPC-Manager/issues/384#issuecomment-154449064
.

I dont know if this is only me, but seems like "users" are able to do what every they want except going to settings ?
As a "users" I can:
CP: add and remove to wanted list
SAB: delete history and items in queue, add to queue, pause, set limit
Snoarr: add and remove show

Your right, s user can do everything except changing settings.
The original request was to protect the settings. I wanted a login page this was the result. :p

Den 23. des. 2015 kl. 03.27 skrev nockstarr<EMAIL_ADDRESS>I dont know if this is only me, but seems like "users" are able to do what every they want except going to settings ?
As a "users" I can:
CP: add and remove to wanted list
SAB: delete history and items in queue, add to queue, pause, set limit
Snoarr: add and remove show
—
Reply to this email directly or view it on GitHub.

Anybody still want this?

Yes, I do.
On Feb 7, 2016 2:11 AM, "Hellowlol"<EMAIL_ADDRESS>wrote:

Anybody still want this?
—
Reply to this email directly or view it on GitHub
https://github.com/Hellowlol/HTPC-Manager/issues/384#issuecomment-180974122
.

@wschlotter i was referring to the request part. I have already added a new account type with limited access. (They can only add stuff)

Before you start diving into the request features too much, in addition to plex requests, check out this thread reworking it for emby & dropping some of the cruft out:
http://emby.media/community/index.php?/topic/30653-so-asking-again-has-anyone-done-anything-like-plexpy-for-emby-yet/

He mentioned a wrapper for emby api in Python that's good news. I was bored yesterday so I have already started in the backed regarding this. It might end up like of my many half finished branches so no promises.

Fine by me. I never did learn to program.  Sigh . . .

Having this incorporate requests for movies and tv would be very nice since you already have Sonarr, CP, and the database support.


Allow connections over IPv6

owserver seem to bind to ::1 by default sometimes

Verified that node-owfs works with both IPv4 and IPv6.
This didn't seem to be doing anything:
var socket = new net.Socket({
    type: 'tcp4'
});

owserver only seems to listen on a single port family. For example this will only listen on IPv4:
####################### OWSERVER ########################

server: port = 4304

(tested using owfs version 2.8p15-1)


Bumped version to indicate updates

Thanks @freeagent-apollok  - we are working on release-3.0.0 as the next release will contain breaking changes.


:warning: Action Required: Replace Deprecated gcr.io/kubebuilder/kube-rbac-proxy

Description
:warning: The image gcr.io/kubebuilder/kube-rbac-proxy is deprecated and will become unavailable.
You must move as soon as possible, sometime from early 2025, the GCR will go away.

Unfortunately, we're unable to provide any guarantees regarding timelines or potential extensions at this time. Images provided under GRC will be unavailable from March 18, 2025, as per announcement. However, gcr.io/kubebuilder/may be unavailable before this date due to efforts to deprecate infrastructure.

If your project uses gcr.io/kubebuilder/kube-rbac-proxy, it will be affected.
Your project may fail to work if the image cannot be pulled. You must take action as soon as possible.

However, if your project is no longer using this image, no action is required, and you can close this issue.

Using the image gcr.io/kubebuilder/kube-rbac-proxy?
kube-rbac-proxy was historically used to protect the metrics endpoint. However, its usage has been discontinued in Kubebuilder. The default scaffold now leverages the WithAuthenticationAndAuthorization feature provided by Controller-Runtime.
This feature provides integrated support for securing metrics endpoints by embedding authentication (authn) and authorization (authz) mechanisms directly into the controller manager's metrics server, replacing the need for (https://github.com/brancz/kube-rbac-proxy) to secure metrics endpoints.
What To Do?
You must replace the deprecated image gcr.io/kubebuilder/kube-rbac-proxy with an alternative approach. For example:

Update your project to use WithAuthenticationAndAuthorization:

You can fully upgrade your project to use the latest scaffolds provided by the tool or manually make the necessary changes. Refer to the FAQ and Discussion for detailed instructions on how to manually update your project and test the changes.

Alternatively, replace the image with another trusted source at your own risk, as its usage has been discontinued in Kubebuilder.

For further information, suggestions, and guidance:

📖 FAQ and Discussion
💬 Join the Slack channel: #kubebuilder.

NOTE: This issue was opened automatically as part of our efforts to identify projects that might be affected and to raise awareness about this change within the community. If your project is no longer using this image, feel free to close this issue.

We sincerely apologize for any inconvenience this may cause.
Thank you for your cooperation and understanding! :pray:

Yes, this proxy is deprecated and we should stop using it.
FYI, this proxy originates in https://github.com/brancz/kube-rbac-proxy and a container image is available in Quay.io (quay.io/brancz/kube-rbac-proxy).


dev-2016

What's this ?

private String apiUrl = "http://localhost/yii2/bets/webtask.php";
I'm assuming this was not meant to be a PR?

Doesn't look like trying to comply with Valve's ToS either. 😄

Oh, sorry, I missclick somewhere when try to update my fork.


Close view controller on scene, because we need the extra objects

When the segue is not exactly in the view controller, but in the scene, we should generate those segues as well.
This might not be a very good fix, but it seems to be the easiest.

Possibly related to https://github.com/mac-cain13/R.swift/issues/223, https://github.com/mac-cain13/R.swift/issues/224.

Thanks for creating a PR! Seems that #249 will fix this also and I'll merge that one.


Gutenberg Question

wp feature img not in gutenberg right column but there in classic editor?.
My misstake or not ?
regard

Hi @FranckPiazza I'm not familiar with Gutenberg but normally the bundle doesn't interfere with WordPress admin functionnality, but I will take a look asap

I have another twig render pb withe the $context post,
I have add social block in éditor :
The render in the source look like this :
`

`
I have add in app.js

require('../../public/edition/wp-includes/css/dist/block-library/style.css');
require('../../public/edition/wp-includes/js/dist/i18n.min.js');
require('../../public/edition/wp-includes/js/dist/block-library.min.js');

But its still not working, when in dd(the_content()); in the page controle the source is ok but not with the context in the twig.
I have something to do ?
Regards

Hi @FranckPiazza I have pushed a fix for that, could you tell me if it's ok for you now ?
In fact post.content was not filtered using apply_filters( 'the_content', $content ); that was the issue


check app file is sync to containerSymbolsFolder

It helps in my sync problem, I'm not sure if it is global usable.
Issue: #1299

if you move the block one line up (inside the if statement), meaning that you only wait for it if the file was copied.
Then I will take it.
Thanks

I have copy/pasted your code and included it myself because another partner ran into the same issue this evening.
Thanks for your contribution.


How to use it with composition api

Please add a documentation about how to use this cookies in composition api and <script setup> in Vue3

Hi, added to the v1.0.2 release:
https://github.com/KanHarI/vue3-cookies/blob/master/README.md


3d renderable mesh

[ ] Textures
[ ] Shaders
[x] Mesh
[x] 3d context

Mesh and 3d context made in #35


[BrokenLinksH2] Fixed the link path

Fixed the link path

@v-sidlama : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit f4c70b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-community-training/frequently-asked-questions/faqs-general.md
:bulb:Suggestion
View
Details

microsoft-community-training/frequently-asked-questions/faqs-general.md

Line 161, Column 4: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/industry/training-services/microsoft-community-training/' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@v-sidlama : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit 7619dc6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-community-training/frequently-asked-questions/faqs-general.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@v-sidlama : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit a78d6ef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-community-training/frequently-asked-questions/faqs-general.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#sign-off

@v-sidlama: I'm sorry - only the author of this article, @nikotha, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


GitFlow support

Add support for detecting tags for repos using git flo, support can usually be detected using the .git/config or looking for tags under the release/ namespace (but only when using the default configuration).
git config --local -l

Good idea! if you can submit a pull request I'd be happy to merge it, or I'll try to update it once I got enough time.

I hacked out a rough implementation of this last night so will send over a PR once i have tidied it up a bit.

I have made some general improvements over at #3 that will serve as the base for getting this functionality added.

First pass is up here: https://github.com/nblackburn/git-version-bumper/tree/feature/gitflo-support


Tensorrt RTSP Server

@jkjung-avt,
First off thank you for your work!  I wish I could give you 10 stars!  I have more of a question than an issue.  Are you aware of a python-based rtsp server that easily integrates with your code (trt_yolo.py) like the python mjpeg-sever does (in trt_yolo_mjpeg.py)?
I would like to stream yolo detections like the trt_yolo_mjpeg.py script does except with an rtsp server instead of a mjpeg sever.
Any recommendations are greatly appreciated.
Thanks!

Thanks for your endorsement.
I don't currently have a plan to add RTSP server support to the code (I welcome such a pull request, though).  You could probably refer to how I create a VideoWriter with a GStreamer pipeline in the trt_modnet example.
https://github.com/jkjung-avt/tensorrt_demos/blob/1f8773b3f6091d2e3441c0d6ce5714e332421f8d/utils/writer.py#L20-L24
https://github.com/jkjung-avt/tensorrt_demos/blob/1f8773b3f6091d2e3441c0d6ce5714e332421f8d/trt_modnet.py#L154-L155
https://github.com/jkjung-avt/tensorrt_demos/blob/1f8773b3f6091d2e3441c0d6ce5714e332421f8d/trt_modnet.py#L133
https://github.com/jkjung-avt/tensorrt_demos/blob/1f8773b3f6091d2e3441c0d6ce5714e332421f8d/trt_modnet.py#L164-L165
And try to replace the filesink with something that produces a RTSP stream.  Reference:

https://forums.developer.nvidia.com/t/how-to-generate-rtsp-stream-with-gstreamer-in-tx2/75876
https://stackoverflow.com/questions/13744560/using-gstreamer-to-serve-rtsp-stream-working-example-sought

@jkjung-avt, Thanks for the reply!  I'm sure I will find a solution from your recommendations.  I consider this issue closed.


Added a smooth scroll between different sections of the page using jquery

Related Issue
None
Fixes:  #267
Description
I have made the scroll between the different parts of the page smoother using the help of jquery. The link to the jquery has been attached in a script tag so there is no need to download it as a dependency
Issue Number-#267
Feature enhancement

[ ] I have made this change from my own.
[ ] I have taken help from some online resources.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.

Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!
@Durgeshwar-AI


Fix name param to ZoneName in Get-TargetResource - Fixes #63

This change is

Thank you for sending in this PR! Looking good! Just one thing, could you please add an entry to the Unreleased section of the README.md?
Also, maybe you need to change the PR title to Fix name param to ZoneName in Get-TargetResource - Fixes #63. It will then auto close the issue when merged, not sure if the current PR title will do that :thinking:
The unit test did not catch this, and looking at the unit test it really needs an overhaul, so I suggest merging this without a need for adding this change to the unit test. But if you'd like trying out Pester and adding a tests for this change to the unit test, then you are more than welcome, but don't feel that you have to.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

I won't have time atm to look into the unit tests. I can try to look into it when I can make some free time.

@kwirkykat The unit test did not catch this, and looking at the unit test it really needs an overhaul, so I suggest merging this simple PR without a need for adding this change to the unit test. If you like this to be added to the unit test @gerane says he can do that when he get free time.

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@gerane Sorry it took so long to merge this simple fix.


Objective isn't working with silk

What is your Quests version / build number (do not say "latest")?
3.9.5
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
If you want a stage where players need to mine certain blocks they can't mine those blocks with Silk Touch.
If applicable, can you provide an example quest from quests.yml using Pastebin.com?

This is intentional to allow players to mine blocks without having to progress their quest. Please see the final "Pro-tip" in https://github.com/PikaMug/Quests/wiki/3-‐-Quests-Editor


Adding Aspirator, Shaker, and Magnetic Block Components to Library

Part of EC552 HW2.

Repo appears to have been deleted


Add a badge to run tutorials in Google Colab

This PR brings three changes:

It changes the Sphinx prologue of each tutorial to show badges instead of text (cf. current behavior).
It adds a Google Colab badge which takes the user straight to a Colab-hosted version of the notebook.
It adds a few cells at the top of the quickstart.ipynb notebook with installation instructions (i.e. a cell with !pip install lightkurve and some explainer text).  These extra cells are intended to make it easy for a user to install lightkurve when opening the notebook in Colab.  These extra cells have the metadata "nbsphinx": "hidden" so they are not shown in sphinx.  However these extra cells may confuse users who already have lightkurve installed, and they are inconsistent with our recommendation to install lightkurve using conda, so I'm not yet convinced this is the right solution.

Preview:

/cc @gully

Codecov Report

Merging #485 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   86.86%   86.86%
=======================================
  Files          28       28
  Lines        5101     5101
=======================================
  Hits         4431     4431
  Misses        670      670

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 531a837...4593c32. Read the comment docs.

I removed the changes to quickstart.ipynb from this PR for now, so we can just merge the new badges and worry about dependency management in the cloud separately.
@gully Can you have a look and merge if happy?

Indeed, dependency management in the cloud is an issue.  When I tried naively to run one of the notebooks, I got:
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-73a736ec1f11> in <module>()
----> 1 from lightkurve import search_targetpixelfile
      2 # First we open a Target Pixel File from MAST, this one is already cached from our previous tutorial!
      3 tpf = search_targetpixelfile(6922244, quarter=4).download()
      4
      5 # Then we convert the target pixel file into a light curve using the pipeline-defined aperture mask.

ModuleNotFoundError: No module named 'lightkurve'

---------------------------------------------------------------------------
NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.

To view examples of installing some common dependencies, click the
"Open Examples" button below.
---------------------------------------------------------------------------


Recommend to add new parameters to view the specific information of cso file

Recommend to add new parameters to view the specific information of cso file ,Such as block size, cso format,how many blocks are compressed by deflate (percent of the total), how many blocks are compressed by lz4, and how many blocks are stored with uncompressed......
for example:
maxcso --info input.cso

I second this. Am currently looking for a way to get this sort of information from already compressed CSO files, and am coming up short. Was hoping maxcso could do this, but it appears it doesn't.


zoomToShowLayer doesn't fire callback when using CircleMarkers

How to reproduce

Leaflet version I'm using: 1.3.1
Leaflet.MarkerCluster version I'm using: 1.3.0
Browser (with version) I'm using: Chrome 67.0.3396.87
OS/Platform (with version) I'm using: macOS High Sierra
Add three circle markers to the map (in my case, 2 in Hong Kong and 1 in the Phillipines - see example).
Zoom out so all three markers cluster together.
Call zoomToShowLayer passing the Phillipines marker.

What behaviour I'm expecting and which behaviour I'm seeing
Expecting the zoomToShowLayer callback to be fired. It's not fired because it's checking for an icon on the marker before firing the callback, which doesn't exist on a CircleMarker. The Hong Kong buttons because the parent (i.e. the cluster) has an icon.
if ((layer._icon || layer.__parent._icon) && !this._inZoomAnimation) {
Minimal example reproducing the issue
Clicking on Zoom to Marker 1 doesn't open the popup.
http://jsfiddle.net/7cxwu248/28/

It does work for marker 2 and 3 though, which look to be equivalent other than location as far as I can tell?
Weird bug though.

Hi,
Seems that it works for spiderfied Circle Markers (i.e. Markers 2 and 3 in the provided example) because in that case the callback is executed once "spiderfied" event fires, whether the Layer has an _icon or not.
https://github.com/Leaflet/Leaflet.markercluster/blob/4cea2dfba189972c7ce06a0ab3cbc9cc8aa0b694/src/MarkerClusterGroup.js#L544-L556
Since the check for layer._icon and layer.__parent._icon is to know whether they are visible (added) on map or not, we could simply use map.hasLayer instead (if it is not on map, it is collected in a cluster, or not part of this cluster group at all…)
Updated JSFiddle: https://jsfiddle.net/7cxwu248/39/
BTW this is the same case on the next lines:
https://github.com/Leaflet/Leaflet.markercluster/blob/4cea2dfba189972c7ce06a0ab3cbc9cc8aa0b694/src/MarkerClusterGroup.js#L558-L560
It is less of a problem, since in this case we move first then execute the callback, instead of just executing the callback.

The CDN version still has the old code or am I missing something?
<EMAIL_ADDRESS>

Well, version 1.4.1 still has the _icon check, the following is from sources:

zoomToShowLayer: function (layer, callback) {

		if (typeof callback !== 'function') {
			callback = function () {};
		}

		var showMarker = function () {
			if ((layer._icon || layer.__parent._icon) && !this._inZoomAnimation) {
				this._map.off('moveend', showMarker, this);
				this.off('animationend', showMarker, this);

				if (layer._icon) {
					callback();
				} else if (layer.__parent._icon) {
					this.once('spiderfied', callback, this);
					layer.__parent.spiderfy();
				}
			}
		};

		if (layer._icon && this._map.getBounds().contains(layer.getLatLng())) {
			//Layer is visible ond on screen, immediate return
			callback();
		} else if (layer.__parent._zoom < Math.round(this._map._zoom)) {
			//Layer should be visible at this zoom level. It must not be on screen so just pan over to it
			this._map.on('moveend', showMarker, this);
			this._map.panTo(layer.getLatLng());
		} else {
			this._map.on('moveend', showMarker, this);
			this.on('animationend', showMarker, this);
			layer.__parent.zoomToBounds();
		}
	},

You could patch the library using Leaflet class include, as done in the above updated JSFiddle.

I downloaded the sources and made my changes, I just realized this repo is not maintained anymore.


Change the framework to use attributes

(edit: Changed the formatting heavily,)
This's a very unfinished pr and as such needs all of these checked:
main things to do first

[x] Getting the right data out of the function provided by the user and make the appropriate output function for the Command trait (this is due to the reason that i want to mostly mimic the functionality of the current command! macro, and one of it is the choice of ignoring the message/args arguments)
[x] Arg parsing (again, a functionality from the command! macro)
[x] Splitting out the whole Command trait with the right data from the attributes and from the function.
[ ] Change the framework to adjust it to the new design.

minor

[x] Change tabs to spaces from my lazyness.
[x] Change the wildcard versions defined in Cargo.toml for serenity_attributes to actual versions so the crate can be uploaded to crates.io.

Discarded ideas

[x] Possibly change the whole framework usage to attributes, but the question lies, where should the attribute for configuring the framework go? (Well, i think just the commands part of it is fine to use attributes, so i'm checking this off and the one below)
[x] Add support for Before/After hooks. (Look up)
[x] Add support for rest args, e.g fn command(..., arg1: String, rest_after_arg1: (String|Vec<String>)) { ... } (Code was becoming too complex, TOO complex, and wasn't really easy to do, so i'm just discarding this.)

the seventh item on this list sounds like something that could have been fixed with an editor setting change,

Oh actually it seems vscode was smart enough to not put tab characters in places of spaces.
Guess i was a bit lucky, but thanks anyway.

#ConflictingFiles
src/ext/framework/mod.rs

I know, but i still have to change many things in the framework to see if all of this'd work as expected.
So it's low priority.

Okay well, the branch's pretty much messed up now (what i get for rebasing wrong) but also, i can't really figure out the way i should be editing the framework to adapt it to attributes. As no matter what i try (4 times if you mind), it still won't work.
So i'm just gonna make a new pr, however, with just the serenity_attributes and a bare bones command.rs and let it as a up for grabs for those who could manage to change the framework in a way i was intending to have in this pr (mainly the Framework::register method), and'd work.
For those who can't edit the repo directly, because of them not being "maintainers", you can just go to my fork, make a local repo out of it, do the edits, then by doing a pr to my fork. Everything else about this'll be handled by me afterwards.
(And yes, i'll credit you.)


Capture image

I implemented a frame saving protocol that:

Allows the user to call save frames from BroadcastActivity
Gives him control over the size and destination of the screenshot (via a ScreenShot object).
Returns info to the BroadcastActivity to keep the client updated on the state of the screenshot
Occurs on a parrallel thread => minimum interference with user experience.

I'm considering this pull request more of a call for review - if you see errors in the code, want to run it by your test suites or anything, this'll be a great time for it.
To understand how this works, I'd suggest first checking out the ScreenShot class in android/streaming folder.
The follow the process to save the frame:
0) create Screenshot object with desired fields.

call saveframe from the BroadcastActivity
sends message to the encoder to saveframe
which calls inputWindowSurface.saveframe method (passing screenshot objects all the way through)
generates new bitmap on alternate thread, and sends messages to cameraHandler to inform about the status of the save.
Handling these callback messages from saveframe to the camera: the methods are easily overriden by the client so he/she can write his own interpretation of how the UI should react.

To see how it looks on a project, check out my cineios_test project on Github. What I do is send the screenshot (with some scaling), and then override the saveframe callbacks to update the color of a button based on the state of the frame save.
I hope this is clear and look forward to feedback.

Thanks for the PR @lgorse. It looks like a lot of work went into this. I appreciate it. We'll have a look over here, run it on some devices, and then merge it in.

Don't forget my last commit today (Feb 14) which fixed the issue with filenames getting re-generated because I grabbed them with a new Timestamp every time. Issue fixed.

Hey @lgorse , it didn't break anything so I merged this in. I also updated to gradle 1.0.0 as you updated runProguard to minifyEnabled and it's a good thing to do. Can you update either the Readme and/or the example app (CineIOExampleApp) demonstrating the screenshot feature?

Hey thanks!
I'll take care of updating the readme this week - sorry for the delay.
On Tue, Feb 17, 2015 at 8:14 PM, Thomas Shafer<EMAIL_ADDRESS>wrote:

Hey @lgorse https://github.com/lgorse , it didn't break anything so I
merged this in. I also updated to gradle 1.0.0 as you updated runProguard
to minifyEnabled and it's a good thing to do. Can you update either the
Readme and/or the example app (CineIOExampleApp) demonstrating the
screenshot feature?
—
Reply to this email directly or view it on GitHub
https://github.com/cine-io/cineio-broadcast-android/pull/13#issuecomment-74808912
.

--

Laurent Gorse
MBA, class of 2013
Stanford Graduate School of Business
650.644.9188
<EMAIL_ADDRESS>gsb.stanford.edu|Facebook: StanfordGSB http://facebook.com/StanfordGSB
|Twitter: @StanfordBiz http://twitter.com/StanfordBiz


Revert VERSION bump to 1.11.0-dev

This was due to an accident from #21431
Signed-off-by: Tibor Vass<EMAIL_ADDRESS>

LGTM


Updating to V17 removes autoscaling groups

Hi team, i am updating our eks terraform module from v 13 to v 17 and i noticed in the terraform plan that it removes the autoscaling groups, any idea why?
 ~ resources              = [
          - {
              - autoscaling_groups              = [
                  - {
                      - name = "eks-xxxx"
                    },
                ]
              - remote_access_security_group_id = ""
            },

I think it just recreating by new autoscaling group, there was probably few changes causing this. Paste a full resource planning to show what exactly is forcing replacement

Sure, here it is:
  # module.eks.module.node_groups.aws_eks_node_group.workers["monitoring"] must be replaced
+/- resource "aws_eks_node_group" "workers" {
      ~ ami_type               = "CUSTOM" -> (known after apply)
      ~ arn                    = xxx" -> (known after apply)
      ~ capacity_type          = "ON_DEMAND" -> (known after apply)
      ~ disk_size              = 0 -> (known after apply)
      ~ id                     = "xxx" -> (known after apply)
      ~ instance_types         = [ # forces replacement
          + "m4.large",
        ]
      ~ node_group_name        = "xxx" -> (known after apply) # forces replacement
      + node_group_name_prefix = (known after apply)
      ~ release_version        = "ami-04d9a86ec8fd40b1f" -> (known after apply)
      ~ resources              = [
          - {
              - autoscaling_groups              = [
                  - {
                      - name = "eks-xxx"
                    },
                ]
              - remote_access_security_group_id = ""
            },
        ] -> (known after apply)
      ~ status                 = "ACTIVE" -> (known after apply)
        tags                   = {
            "environment"                                  = "develop"
            "k8s.io/cluster-autoscaler/enabled"            = "true"
            "kubernetes.io/cluster/purple-next-kubernetes" = "owned"
        }
      ~ version                = "1.18" -> (known after apply)
        # (5 unchanged attributes hidden)

      ~ launch_template {
            id      = "lt-05a94441c6486ccbe"
          ~ name    = "xxx" -> (known after apply)
            # (1 unchanged attribute hidden)
        }

        # (1 unchanged block hidden)
    }

there are breaking changes, please take a look into https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/docs/upgrades.md how to upgrade module


Add .zarr file loading for faster upfront training

Adds a new segment_to_ome.py utility based on existing scroll_to_ome.py for converting segments into .zarr format for faster loading, and an implementation of .zarr array loading in one of the training scripts

Thank you Seth for your PR
After looking over the scroll2zarr adjustments, i have some questions:

what is the difference between the scroll_to_ome.py and the segment_to_ome.py?
scroll_to_ome.py can also take the "input_tiff_dir" argument as path_so_segment/layers as tif/jpg input stack and then output the zarr as the argument "output", ie segment_id.zarr


ScrollToEnd() is inefficient

AvalonEdit ScrollToEnd() is inefficient -- it sets ScrollOffset to infinity, and relies on the bounds check in arrange() to restore a sane ScrollOffset.
Unfortunately, this has the effect of destroying all cached visual lines. This makes ScrollToEnd() inefficient in log-viewer style applications that frequently append to the document and call ScrollToEnd().

@dgrunwald is there a workaround for log-viewer style applications?

Using ScrollToVerticalOffset was considerably more efficient.  I had added a method to an inherited class that looked like this:
/// <summary>
/// Similar functionality to ScrollToEnd but considerably more efficient.
/// </summary>
public void ScrollToLastLine()
{
    this.ScrollToVerticalOffset(this.TextArea.TextView.GetVisualTopByDocumentLine(this.LineCount));
}

This works mostly well with one exception.  When the last wraps (or even possibly any line, need to test) it goes to the visual top of the last line.. but the wrapped portion is still out of view (when I also need that in view).  I've tried to account for that by obtaining the line height but have been unsuccessful thus far on that front.  I wanted to share this regardless in case it helps anyone out.

This appears to work with wrapping:
See if this words.  I had it in an inherited class but you get the idea.  It seems to perform as well as ScrollToVerticalOffset and also takes it all the way to the bottom (including wraps).  I haven't tested it extensively but I'm going to.
/// <summary>
/// Similar functionality to ScrollToEnd but considerably more efficient.
/// </summary>
public void ScrollToLastLine()
{
    this.ScrollTo(this.LineCount, 0);
}


Feature request: Support environment type scoped variables

This would allow for users to add environment variables to the project (or the environment) and only be consumed if the environment type matches production or development, depending on how the environment variable is added.
One use case is where you need to pre-seed all development environments with variables on their first deployment, but you don't want these in your production environment. The only way to do this currently is to have them defined in the project, and then in the production environment specify an override variable (and the user may have to have some logic to maybe even ignore this variable etc...)

CUrrently you can set a project-scope var, and then a prod env-scope override, but this may be confusing?


document what to do in case of multiple target frameworks

This is very likely not the end of this story but should help people overcome one of the first obstacles the might face.

We should make the analysis task multi-targeting aware to help prevent this.
Essentially, if the task is called with TargetFrameworks nonempty, then the task should be called again with each separate TFM and the outputs collected together in some way. I'll send a PR with an example and we can work through the specifics

It would actually be simpler than KeepAChangelog since the package we're talking about here wouldn't have any DLLs - the short version is you would make a package (let's call it FSharp.Analyzers.Build) with the following layout:
<root>
- build
- - FSharp.Analyzers.Build.targets
- buildMultitargeting
- - FSharp.Analyzers.Build.targets

and in the build targets you'd just put the logic for a single-TFM run of the analyzers (since the build logic in NuGet packages is guaranteed by the .NET SDK to only run for a single TFM). then, in the buildMultitargeting targets you'd have the 'new' target that knows how to handle invoking analysis for each TFM specified (since the buildMultitargeting logic in NuGet packages is guaranteed by the .NET SDK to only run in the 'outer', multi-TFM context.

Not needed anymore because we have https://github.com/ionide/FSharp.Analyzers.SDK/pull/139


[MM-44155] Handle call_end event

Summary
PR adds an handler for the new "call_end" event. When this is received for a call we are connected to we leave the call immediately by forcing a disconnect.
Ticket Link
https://mattermost.atlassian.net/browse/MM-44155
Checklist

[x] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.

Device Information
This PR was tested on physical Android device (10Q).
I don't expect any difference on iOS as no native code was altered but to be thorough could you please give it a try @cpoile?
Release Note
Added handler for new call_end event

Related PRs
https://github.com/mattermost/mattermost-plugin-calls/pull/87

Do you want me to take over and fix those two? (Or I can fix 1 and you can fix 2 by adding the slash command handler on the server side PR?)

@cpoile
Sure. For 2 I originally implemented it as an handler but then moved to API call since I added the confirm dialog which wasn't possible otherwise. Ideally we should do the same here but I am happy to defer that work as it's a bit more involved. This PR is not about implementing the feature really but more like making sure all the clients respect and react to the event.

@streamer45 I've added the code to exit the call screen when the call is ended, and I added the /call end hook for mobile. It works the same as on desktop.
Interesting problem: the way that we're returning resp.Err doesn't work with plain fetch and/or mobile's Client4.doFetch -- I think we should take a look at that and make sure it does because I can't get the error text, I just assume an error means there was a permissions problem. Please take a look if you can, would appreciate help here.
Tested on - Android: 12, Pixel 6
iOS: 15.3.1, iPhone 7 plus
Looks like (on ios, screen is yellow cause it's late):

Thanks @cpoile , looks great! :raised_hands:
As for the fetch issue, I verified it works nicely on browser. The problem here is that the wrapping client assumes errors are returned in the format the server uses:
https://github.com/mattermost/mattermost-mobile/blob/1d299d02f0e829194061f478124a76999b11715d/app/client/rest/base.ts#L362-L373
I am okay with being consistent so I'll go ahead and update the other PR which should get us what we need here.

Addressed in https://github.com/mattermost/mattermost-plugin-calls/pull/87/commits/0373584b5b5f95fb34f4c8274c601e4d114db802, please give it another try.

@streamer45 Yep, that was it. Thanks, it was getting late, that helped.
Also handling the permissions pre-emptively like you're doing in https://github.com/mattermost/mattermost-plugin-calls/pull/87
Looks like:

Thanks @cpoile, great team work on this one 💯

Cherry pick is scheduled.


Added Git-Github Content and learning resources

@Adam-pw from next time keep in mind to add description while sending PRs
Wait to get this PR reviewed .

Okay sir, I'll keep that in mind from the next time.

Leave this PRs for review by @kartikver15gr8


Added my profile on LinkFree

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Please Revert the changes from the package-lock.json and package.json files. Let us know if you need any help.

How can I revert specific files? Need help.

Please Revert the changes from the package-lock.json and package.json files. Let us know if you need any help.

How can I revert specific files? Need help.

Simply just copy the content from the LinkFree's main ( Original Files ), paste, and commit it to your fork repo files. ( only just package-lock.json, and package.json files. )


Update to follow phonopy update for spglib v2.5

Codecov Report
Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.42%. Comparing base (16fee1e) to head (79725c8).
Report is 10 commits behind head on develop.

Files
Patch %
Lines

src/phelel/velph/cli/init/init.py
60.00%
2 Missing :warning:

src/phelel/velph/cli/utils.py
85.71%
2 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #16   +/-   ##
========================================
  Coverage    73.42%   73.42%
========================================
  Files           74       74
  Lines         5211     5223   +12
========================================
+ Hits          3826     3835    +9
- Misses        1385     1388    +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Upgrade to aruba 0.8.

Mmmh... Will have a look tomorrow.

BTW: We're working on running tests with appveyor to have reliable builds on windows as well.

@maxmeyer / @dg-ratiodata -- now we're getting a new failure from aruba:
  1) Persistence failures when `config.example_status_persistence_file_path` is configured to a file path for which we lack permissions emits a helpful warning to the user, indicating we cannot read from it, and still runs the spec suite
     Failure/Error: write_file_formatted "spec/1_spec.rb", "
     NoMethodError:
       undefined method `write' for File:Class
     # /home/travis/build/rspec/bundle/ruby/1.9.1/gems/aruba-0.8.1/lib/aruba/creators/aruba_file_creator.rb:25:in `write'
     # /home/travis/build/rspec/bundle/ruby/1.9.1/gems/aruba-0.8.1/lib/aruba/api/filesystem.rb:123:in `write_file'
     # ./spec/support/aruba_support.rb:49:in `write_file_formatted'
     # ./spec/integration/persistence_failures_spec.rb:33:in `block (4 levels) in <top (required)>'
     # ./lib/rspec/core/example.rb:386:in `instance_exec'
     # ./lib/rspec/core/example.rb:386:in `instance_exec'
     # ./lib/rspec/core/hooks.rb:357:in `run'
     # ./lib/rspec/core/hooks.rb:521:in `block in run_owned_hooks_for'
     # ./lib/rspec/core/hooks.rb:520:in `each'
     # ./lib/rspec/core/hooks.rb:520:in `run_owned_hooks_for'
     # ./lib/rspec/core/hooks.rb:607:in `block in run_example_hooks_for'
     # ./lib/rspec/core/hooks.rb:606:in `reverse_each'
     # ./lib/rspec/core/hooks.rb:606:in `run_example_hooks_for'
     # ./lib/rspec/core/hooks.rb:476:in `run'
     # ./lib/rspec/core/example.rb:433:in `run_before_example'
     # ./lib/rspec/core/example.rb:211:in `block in run'
     # ./lib/rspec/core/example.rb:439:in `block in with_around_and_singleton_context_hooks'
     # ./lib/rspec/core/example.rb:396:in `block in with_around_example_hooks'
     # ./lib/rspec/core/hooks.rb:478:in `block in run'
     # ./lib/rspec/core/hooks.rb:618:in `block in run_around_example_hooks_for'
     # ./lib/rspec/core/example.rb:281:in `call'
     # ./lib/rspec/core/example.rb:281:in `call'
     # ./spec/support/sandboxing.rb:14:in `block (3 levels) in <top (required)>'
     # ./lib/rspec/core/sandbox.rb:29:in `sandboxed'
     # ./spec/support/sandboxing.rb:7:in `block (2 levels) in <top (required)>'
     # ./lib/rspec/core/example.rb:386:in `instance_exec'
     # ./lib/rspec/core/example.rb:386:in `instance_exec'
     # ./lib/rspec/core/hooks.rb:389:in `execute_with'
     # ./lib/rspec/core/hooks.rb:620:in `block (2 levels) in run_around_example_hooks_for'
     # ./lib/rspec/core/example.rb:281:in `call'
     # ./lib/rspec/core/example.rb:281:in `call'
     # ./lib/rspec/core/hooks.rb:619:in `run_around_example_hooks_for'
     # ./lib/rspec/core/hooks.rb:478:in `run'
     # ./lib/rspec/core/example.rb:396:in `with_around_example_hooks'
     # ./lib/rspec/core/example.rb:439:in `with_around_and_singleton_context_hooks'
     # ./lib/rspec/core/example.rb:209:in `run'
     # ./lib/rspec/core/example_group.rb:559:in `block in run_examples'
     # ./lib/rspec/core/example_group.rb:555:in `map'
     # ./lib/rspec/core/example_group.rb:555:in `run_examples'
     # ./lib/rspec/core/example_group.rb:521:in `run'
     # ./lib/rspec/core/example_group.rb:522:in `block in run'
     # ./lib/rspec/core/example_group.rb:522:in `map'
     # ./lib/rspec/core/example_group.rb:522:in `run'
     # ./lib/rspec/core/example_group.rb:522:in `block in run'
     # ./lib/rspec/core/example_group.rb:522:in `map'
     # ./lib/rspec/core/example_group.rb:522:in `run'
     # ./lib/rspec/core/runner.rb:115:in `block (3 levels) in run_specs'
     # ./lib/rspec/core/runner.rb:115:in `map'
     # ./lib/rspec/core/runner.rb:115:in `block (2 levels) in run_specs'
     # ./lib/rspec/core/configuration.rb:1632:in `with_suite_hooks'
     # ./lib/rspec/core/runner.rb:114:in `block in run_specs'
     # ./lib/rspec/core/reporter.rb:77:in `report'
     # ./lib/rspec/core/runner.rb:113:in `run_specs'
     # ./lib/rspec/core/runner.rb:89:in `run'
     # ./lib/rspec/core/runner.rb:73:in `run'
     # ./lib/rspec/core/runner.rb:41:in `invoke'
     # ./exe/rspec:4:in `<top (required)>'
     # script/rspec_with_simplecov:42:in `load'
     # script/rspec_with_simplecov:42:in `<main>'

It's failing on 1.9.2.  File.write was a new API added in MRI 1.9.3.  Does aruba support 1.9.2?  RSpec still does...

Mmmh... I checked on 1.9 only. I added 1.9.2 to travis build and modified the check. Jesus... I didn't expect that pain on upgrading aruba....

I pushed the change to aruba/master. Can you try this one?

@maxmeyer -- your changes to aruba master fixed 1.9.2, but now we're getting a ton of warnings on JRuby that we don't get from aruba 0.6.2.  Any ideas?

One thing is a warning generated from a new gem we're using, I filed an issue for that https://github.com/egonSchiele/contracts.ruby/issues/178. But the HOME-warning, is new to me. I had quite strange issues with PATH on jruby I worked around. I'm not sure, there seems to be a problem with ENV.  Maybe it's even a thread-issue, but that's really a guess.

I will try to get jruby running on my virtual machine... Maybe I can reproduce the error. Although I could not reproduce the PATH issue with jruby locally.

"Perfect." At least I can reproduce the HOME-variable warning.

I've some troubles to reproduce the failure when I run specific example. You can safely ignore the env vars. I only need them to make jruby run and do not "destroy" my mri-gems.
GEM_ROOT=~/.gem/jruby/ GEM_PATH=~/.gem/jruby/ GEM_HOME=~/.gem/jruby/ jruby --2.0 script/rspec_with_simplecov                    # Fails
GEM_ROOT=~/.gem/jruby/ GEM_PATH=~/.gem/jruby/ GEM_HOME=~/.gem/jruby/ jruby --2.0 script/rspec_with_simplecov ./spec/            # Fails
GEM_ROOT=~/.gem/jruby/ GEM_PATH=~/.gem/jruby/ GEM_HOME=~/.gem/jruby/ jruby --2.0 script/rspec_with_simplecov ./spec/rspec/      # Succeeds
GEM_ROOT=~/.gem/jruby/ GEM_PATH=~/.gem/jruby/ GEM_HOME=~/.gem/jruby/ jruby --2.0 script/rspec_with_simplecov ./spec/rspec/core/ # Succeeds

Using the new bisect functionality rspec told me, the errors do not depend on the order. Is the "true" or just a hint?
JRUBY_OPTS="-Xcext.enabled=true" GEM_ROOT=~/.gem/jruby/ GEM_PATH=~/.gem/jruby/ GEM_HOME=~/.gem/jruby/ jruby --2.0 script/rspec_with_simplecov --seed 123 --bisect
Bisect started using options: "--seed 123"
Running suite to find failures... (2 minutes 21.7 seconds)
Starting bisect with 15 failing examples and 1767 non-failing examples.
Checking that failure(s) are order-dependent... failure is not order-dependent

Bisect complete! Reduced necessary non-failing examples from 1767 to 0 in 14.14 seconds.

The minimal reproduction command is:
  rspec './spec/integration/filtering_spec.rb[1:1,1:2:1,1:3:1,1:4:1,1:4:2,1:5:1,1:5:2]' './spec/integration/order_spec.rb[1:1:1,1:2:1,1:3:1,1:3:2,1:4:1,1:5:1]' './spec/integration/persistence_failures_spec.rb[1:1:1:1,1:1:2:1]' --seed 123

Ok. Our test suite now runs on Ruby 1.9.2 as well without any problems. I'm still working on the HOME-variable thing.

Can it be that simple?
require 'rspec/expectations'

module RSpec
  class Scope
    include RSpec::Matchers
  end

  def self.scope(&block)
    Scope.new.instance_eval(&block)
  end
end

I fixed the HOME-variable problem. It was a bug in Jruby - see jruby/jruby#3162 and https://github.com/reuben-sutton/jruby/commit/4fad5ded23de90a780b150253d8664cf6f43dc8e. I worked around that one and rspec and cucumber test suite runs fine on my local machine. Only rubocop complains.

What do I have to do to get the fixes?

#dup on ENV.to_h. :smile:

Damn.... Didn't understand your question first. Use aruba#master.

I kicked the build.  Now it's failing with:
(::) failed steps (::)
undefined method `unescape' for Aruba::Platforms::UnixPlatform:Class (NoMethodError)
./features/step_definitions/additional_cli_steps.rb:106:in `/^I have run `([^`]*)`$/'
features/command_line/init.feature:27:in `And I have run `rspec --init`'
Failing Scenarios:
cucumber features/command_line/init.feature:25 # Scenario: Accept and use the recommended settings in `spec_helper` (which are initially commented out)

Oh. Sorry. We moved from Aruba::Platform to Aruba.platform. I didn't realize, that you configured aruba in your '.gemspec'. Sorry for the false positive information about the passing build. I didn't check my local Gemfile properly.
Now I'm running the build with:
GIT
  remote: https://github.com/cucumber/aruba
  revision: 507b66327d21bbbb61dc1c97a28f79aa43a6e62f
  specs:
    aruba (0.8.2)
      childprocess (~> 0.5.6)
      contracts (~> 0.9)
      cucumber (>= 1.3.19)
      ffi (~> 1.9.10)
      rspec-expectations (>= 2.99)

The result is this:
[git:update-aruba]% be rake
/usr/bin/ruby -w -I/home/xgvndeg/.gem/ruby/2.2.2/bundler/gems/rspec-support-f82e762eb550/lib:/home/xgvndeg/data/projects/rspec-core/lib /home/xgvndeg/data/projects/rspec-core/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
Run options:
  include {:focus=>true}
  exclude {:ruby=>#<Proc:./spec/spec_helper.rb:102>}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 9334
....................................................................................................................................*......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................*...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................*..........................................................................................................

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) RSpec::Core::Formatters::Helpers format duration with mathn loaded returns 'x minutes xx.x seconds' formatted string
     # lib/mathn.rb is deprecated in Ruby 2.2
     # ./spec/rspec/core/formatters/helpers_spec.rb:58

  2) RSpec::Core::Metadata for an example points :example_group to the same hash object as other examples in the same group
     # Cannot maintain this and provide full `:example_group` backwards compatibility (see GH #1490):(
     Failure/Error: expect(b[:description]).to eq("new description")

       expected: "new description"
            got: "group"

       (compared using ==)
     # ./spec/rspec/core/metadata_spec.rb:138:in `block (3 levels) in <module:Core>'
     # ./spec/support/sandboxing.rb:14:in `block (3 levels) in <top (required)>'
     # ./spec/support/sandboxing.rb:7:in `block (2 levels) in <top (required)>'

  3) RSpec::Core::Formatters::HtmlFormatter produced HTML with mathn loaded is identical to the one we designed manually
     # lib/mathn.rb is deprecated in Ruby 2.2
     # ./spec/rspec/core/formatters/html_formatter_spec.rb:105

Finished in 15.96 seconds (files took 0.83086 seconds to load)
1802 examples, 0 failures, 3 pending

Randomized with seed 9334

/usr/bin/ruby -S bundle exec cucumber
Using the default profile...
.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

270 scenarios (270 passed)
1318 steps (1318 passed)
3m2.277s

You need to change this:
 Given /^I have run `([^`]*)`$/ do |cmd|
   fail_on_error = true
-  run_simple(Aruba::Platform.unescape(cmd), fail_on_error)
+  run_simple(Aruba.platform.unescape(cmd), fail_on_error)
 end

I think #unescape has some value and I'm going to move it to #extract_text. And just a warning: Every method from platform should not be considered to be part of the public api of aruba: https://github.com/cucumber/aruba/blob/master/lib/aruba/platforms/unix_platform.rb#L10. I think we need to be more strict about that. For now you can leave the method above.

I will also have a look into your build failures on JRUBY tomorrow.

I think #unescape has some value and I'm going to move it to #extract_text. And just a warning: Every method from platform should not be considered to be part of the public api of aruba: https://github.com/cucumber/aruba/blob/master/lib/aruba/platforms/unix_platform.rb#L10. I think we need to be more strict about that. For now you can leave the method above.

We're only using Aruba::Platform because @dg-ratiodata introduced it in 2a972dc653ade00b8cc935b166653708f4f5b530 -- and now you're telling us it's not public and we can't rely on it?  In master we are using unescape, which is a clearly documented public API of aruba 0.6.2:
https://github.com/cucumber/aruba/blob/v0.6.2/lib/aruba/api.rb#L459-L470
...and in exchange for spending hours trying to upgrade, we are now apparently migrating to a less stable API.
This upgrade process for Aruba is taking more of my time than I've ever spent dealing with Aruba in the 4-5 years I've worked on RSpec -- and aruba 0.6.2 is working just fine for us.  And the benefit of upgrading seems to be an unstable API.  At this point, I can no longer devote time my personal time to upgrading us, and I don't think I want to upgrade while aruba is in this period of API instability.  I'll be happy to try again when you've made some sort of public commitment to API stability (such as SemVer -- presumably in 1.0?) but until then we can just sit tight on an old version.  If one of you wants to put the effort into upgrading us and keeping us current against new Aruba versions I'd be happy to merge those PRs but I don't have the time to do that myself.
Closing.

Sorry, @myronmarston that it is such a unpleasant upgrade procedure. I really did not foresee that.
And to the Aruba::Platform-thing. @dg-ratiodata and @maxmeyer are the same person - me - I need to use a separate account during normal business hours. Sorry for giving such a  recommendation and submit private API-code to rspec.
I am going to fork rspec-core and activate travis to get some better feedback for different rubies. JRuby really gave me quite a hard time. Unfortunately I'm not able to reproduce all issues on my local machine. Maybe there's even another bug in child_process on jruby. :-/


Incorporate updates to queries

This draft PR prototypes the approach and interface for adding updates (additions and deletions) to an ivf_flat query.  Since the development of the API was to intended to be iterative, only one function was initially prototyped: qv_query_heap_infinite_ram.

The function takes three additional arguments: an updates array, update_ids, and a validity vector
Overloads are provided with and without the original arguments
A single function implements the two overloads using constexpr to include or omit the code for processing the updates.
Per the Notion document, the algorithm performs the ivf query as normal (without updates). The updates are processed by first deleting elements from the top k information returned from the ivf query.  Then a flat query is conducted on the vectors to be added and those results are merged with the original results.
The above process and API modifications can be readily applied to all other ivf query functions.

Since this is a prototype API, the functionality has not yet been tested.

Closing for now, we can come back and reference this functionality as we need to.


Possible charting improvements

Charts appear to coerce axis values to numbers if they "look" like a number even if they are coerced as a string in SQL. The result is that the bar chart renders as a continuous chart rather than categorical values
Charts with continuous values appear to be anchored at zero by default (haven't tested negative numbers) even if there are number values at or near zero. An alternative, arguably better default would be to set the min and max values that of the data. I am not sure if this is related to #139?

These are the two that I noticed thus  far, but there may be more as my team/org uses it more. I do acknowledge that the charting capability is not the core feature of SQLPad, however for quick visualizations it can be useful especially for less technical folks who don't want to or don't know how to export to CSV and then load it up into another application.

Charts appear to coerce axis values to numbers if they "look" like a number even if they are coerced as a string in SQL.

This is legacy of a poor decision I made long ago 😓
Because JavaScript has no support for BigInts, it is somewhat common for node.js drivers to store bigints as strings. I opted to try and detect whether a string was a number, and categorize it accordingly. This brought a lot of pain since there are some numbers that need to stay strings (like leading 0s), or numbers that are actually text for labels or something.
The current state of this is that the strings that contain numbers are left as strings when they are returned from the API, but they are given the number type, and turned into a number when charting.
The charting library has different kinds of dimension types for data (https://api.taucharts.com/datasource/) and I believe numbers are automatically set to measure.
I think the proper solution to all this is to pull the data types from the database query response if available, and then map those to a data type. Strings of numbers that are intended to be strings per the database should stay strings, and they should only be cast to JavaScript numbers if the database says it's actually a number. I think this information available for most of the drivers in use, I'm just not looking forward to building and testing a majority of them.

Charts with continuous values appear to be anchored at zero by default

I'll have to look into this. I haven't used the charting much, and it hasn't really been changed much in the last 3 years (other than keeping it up-to-date with various refactors).
I think its worth improving the visualization capabilities.

Thanks for the reply.

I think the proper solution to all this is to pull the data types from the database query response if available, and then map those to a data type

Yes agreed that would be the most foolproof.
Understood that the charts have not been a high priority. I agree they are a nice-to-have, but aren't necessarily the core value-add of this application.


Exception while download in progress..

Hi Vassim, I'm getting below error while downloading..can u help please thanks!
`INFO     Logging in ...
INFO     Analyzing ...
INFO     Downloading files ...
INFO     Downloading *************.mp4
INFO     Logged Out!
ERROR    Unknown Exception
ERROR    ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/response.py", line 298, in _error_catcher
yield
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/response.py", line 380, in read
data = self._fp.read(amt)
File "/usr/lib/python3.4/http/client.py", line 529, in read
return super(HTTPResponse, self).read(amt)
File "/usr/lib/python3.4/http/client.py", line 568, in readinto
n = self.fp.readinto(b)
File "/usr/lib/python3.4/socket.py", line 374, in readinto
return self._sock.recv_into(b)
File "/usr/lib/python3.4/ssl.py", line 769, in recv_into
return self.read(nbytes, buffer)
File "/usr/lib/python3.4/ssl.py", line 641, in read
v = self._sslobj.read(len, buffer)
ConnectionResetError: [Errno 104] Connection reset by peer
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/linuxacademy_dl/cli.py", line 220, in main
la.download()
File "/usr/local/lib/python3.4/dist-packages/linuxacademy_dl/linux_academy.py", line 155, in download
self._course.download()
File "/usr/local/lib/python3.4/dist-packages/linuxacademy_dl/course.py", line 99, in download
asset.download()
File "/usr/local/lib/python3.4/dist-packages/linuxacademy_dl/assets.py", line 139, in download
self.save_to
File "/usr/local/lib/python3.4/dist-packages/linuxacademy_dl/downloader.py", line 105, in call
self.hls_download(download_info, final_path)
File "/usr/local/lib/python3.4/dist-packages/linuxacademy_dl/downloader.py", line 80, in hls_download
itm.raw, hls_data['key'], iv
File "/usr/local/lib/python3.4/dist-packages/linuxacademy_dl/hls_decrypt.py", line 83, in decrypt
cipher.decrypt(self.chunk_stream.read(1024 * AES.block_size))
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/response.py", line 397, in read
raise IncompleteRead(self._fp_bytes_read, self.length_remaining)
File "/usr/lib/python3.4/contextlib.py", line 77, in exit
self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.4/dist-packages/requests/packages/urllib3/response.py", line 316, in _error_catcher
raise ProtocolError('Connection broken: %r' % e, e)
requests.packages.urllib3.exceptions.ProtocolError: ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))
`

@crisarceramos Thank you for reporting this issue. Please make sure that you have a good Internet connectivity there. These kind of issue mostly happens with poor Internet connectivity. Any way I'll add a try .. except block to handle that exception! If you are still facing this issue, please run the application with --debug switch and paste the log here!

Hello, I am having the same issue.
with --debug:
INFO     Debug log file created at /home/mradmin/linuxacademy-dl/log/log_2017-03-10T13:02:29.638145.log DEBUG    Python: CPython 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609] DEBUG    Platform: Linux-4.4.0-53-generic-x86_64-with-Ubuntu-16.04-xenial [#74-Ubuntu SMP Fri Dec 2 15:59:10 UTC 2016] DEBUG    OS: Linux - Ubuntu 16.04 xenial INFO     Logging in ... INFO     Analyzing ... INFO     Downloading files ... INFO     Skipping already existing file /opt/wget/Linux Academy/70-532/1 - Welcome/1 - Welcome to the 70-532 Certification Prep Course.mp4 INFO     Skipping already existing file /opt/wget/Linux Academy/70-532/1 - Welcome/2 - Course Objectives  Goals.mp4 INFO     Skipping already existing file /opt/wget/Linux Academy/70-532/1 - Welcome/3 - Certification and Best Practices.mp4 INFO     Skipping already existing file /opt/wget/Linux Academy/70-532/6 - Rewind and Next Steps/1 - Next Steps.mp4 INFO     Skipping already existing file /opt/wget/Linux Academy/70-532/5 - Design and Implement Azure PaaS Solutions and Services/1 - Design Azure App Service Web Apps.mp4 INFO     Skipping already existing file /opt/wget/Linux Academy/70-532/5 - Design and Implement Azure PaaS Solutions and Services/2 - Design Azure App Service API Apps.mp4 INFO     Skipping already existing file /opt/wget/Linux Academy/70-532/5 - Design and Implement Azure PaaS Solutions and Services/3 - Implement Azure Functions.mp4 INFO     Skipping already existing file /opt/wget/Linux Academy/70-532/5 - Design and Implement Azure PaaS Solutions and Services/4 - Implement API Management.mp4 INFO     Downloading /opt/wget/Linux Academy/70-532/5 - Design and Implement Azure PaaS Solutions and Services/5 - Develop Azure App Service Logic Apps.mp4 INFO     Logged Out! ERROR    Unknown Exception ERROR    ("Connection broken: error(104, 'Connection reset by peer')", error(104, 'Connection reset by peer')) Traceback (most recent call last):   File "/usr/local/lib/python2.7/dist-packages/linuxacademy_dl/cli.py", line 206, in main     la.download()   File "/usr/local/lib/python2.7/dist-packages/linuxacademy_dl/linux_academy.py", line 155, in download     self._course.download()   File "/usr/local/lib/python2.7/dist-packages/linuxacademy_dl/course.py", line 102, in download     asset.download()   File "/usr/local/lib/python2.7/dist-packages/linuxacademy_dl/assets.py", line 135, in download     self.save_to   File "/usr/local/lib/python2.7/dist-packages/linuxacademy_dl/downloader.py", line 119, in __call__     self.hls_download(download_info, final_path)   File "/usr/local/lib/python2.7/dist-packages/linuxacademy_dl/downloader.py", line 80, in hls_download     itm.raw, hls_data['key'], iv   File "/usr/local/lib/python2.7/dist-packages/linuxacademy_dl/hls_decrypt.py", line 83, in decrypt     cipher.decrypt(self.chunk_stream.read(1024 * AES.block_size))   File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/response.py", line 397, in read     raise IncompleteRead(self._fp_bytes_read, self.length_remaining)   File "/usr/lib/python2.7/contextlib.py", line 35, in __exit__     self.gen.throw(type, value, traceback)   File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/response.py", line 316, in _error_catcher     raise ProtocolError('Connection broken: %r' % e, e) ProtocolError: ("Connection broken: error(104, 'Connection reset by peer')", error(104, 'Connection reset by peer')) INFO     Please report this issue on https://github.com/vassim/linuxacademy-dl/issues. Make sure you are using the latest version. Be sure to call linuxacademy-dl with the --debug flag and include its complete output.

Hi Guys. I tried to reproduce this problem, but failed. I think this is happening because of some issues in the server side! If you guys are still facing this problem, please re open this issue! Thank you!


Usage of raw Environment Variables

Hello,
i'm missing the capability to set an environment variable for the Backing Application.
I would like to see the Variable:
JBP_CONFIG_OPEN_JDK_JRE="{ jre: { version: 11.+ } }" inside the app
Instead the variable is put into SPRING_APPLICATION_JSON={}
and it's not possible to deploy the Backing Application with JAVA11 on Cloud Foundry.
Am i missing something?

You can set the use-spring-application-json property to false in order to use raw environment variables. Sorry, this setting seems to be missing from our docs. We could probably handle this better too, making sure any java buildpack vars remain in the environment even if use-spring-application-json is true.


Update minimum version pin of GitPython to fix vulnerability.

Update minimum version of GitPython to 3.1.34 to fix resource leak issue introduced via a path traversal vulnerability in versions prior to 3.1.34.

I made this in error. Vulnerability is not mitigated in 3.1.34.


Build for linux-aarch64 as well

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge/pynng this is ready for review


Get test tree on java 8+

Unit tests help validate design choices. Notably #778 defines apis which might be useful for lambdas or even method references, but nuance is hard to see because we are limited to < java 8. If we were on java 8, we could practice the api against lambdas and method references with throwing signatures.

Do you think that we should convert all unit tests to Java 8, or just add a few Java 8 test suites for the APIs that could use lambdas?

retrolambda the test source tree is an option if building with JDK 1.7 is required.

Java8 is already added to Travis CI.

I'm not sure I understand.  Does this mean that we don't need to build with Java 7 now, and we can change the source compatibility in build.gradle?

My apologies, I thought this issue was only about testing with Java8. If it's about adding test suites that are specific to Java8 syntax, then it's not yet resolved.

Does this mean that we don't need to build with Java 7 now, and we can change the source compatibility in build.gradle?

No, although we removed Java7 build from Travis CI, we still need to keep Java7 compatibility (reasons bing https://github.com/census-instrumentation/opencensus-java/pull/1690#issuecomment-457956501).


Bug: mute audio button (in navbar) does not pause/stop playback.

After clicking the audio button in the navbar and pressing play on the audio controls, playback does not pause or stop when the navbar audio button is pressed again (even though the playback controls disappear).
This leaves the user with no way to stop audio playback: if they press the navbar audio button again to bring back the playback controls and try to press the play/pause button, a new audio playback starts (in addition to the first one, resulting in confusing layered audio) rather than pausing the existing audio playback.

Added to #249


Caching docsgpt

What kind of change does this PR introduce? (New Feature Caching)
The changes are applied in the BaseLLM class to ensure that all LLM queries (both standard and streaming) benefit from

Caching of responses to improve performance.
Token usage tracking for monitoring API costs.
The concrete LLMs implementations now automatically apply caching and token tracking without modifying their core logic.

Why was this change needed? (You can also link to an open issue here)

#1295

Other information

The addition of caching and token usage tracking was necessary to improve performance and reduce redundant API calls for LLM queries. This change also allows monitoring of token usage for better cost management. By caching the results of similar requests, repeated queries can retrieve cached responses, thus saving time and reducing API costs.

Additionally, the use of decorators makes the code more modular, allowing the caching and token tracking logic to be applied across different LLM implementations without modifying each one.

Testing is coming soon

@dartpain  Hi Alex as we discussed on Discord this is possible feature please review and let me know!

@dartpain Hi Alex I have made change to cache the whole conversation if cache hit as you suggestion.

adapt test case on test_anthropic.py

   def test_gen(self):
        messages = [
            {"content": "context"},
            {"content": "question"}
        ]
        mock_response = Mock()
        mock_response.completion = "test completion"

        with patch("application.cache.make_redis") as mock_make_redis:
            mock_redis_instance = mock_make_redis.return_value
            mock_redis_instance.get.return_value = None
            mock_redis_instance.set = Mock()

            with patch.object(self.llm.anthropic.completions, "create", return_value=mock_response) as mock_create:
                response = self.llm.gen("test_model", messages)
                self.assertEqual(response, "test completion")

                prompt_expected = "### Context \n context \n ### Question \n question"
                mock_create.assert_called_with(
                    model="test_model",
                    max_tokens_to_sample=300,
                    stream=False,
                    prompt=f"{self.llm.HUMAN_PROMPT} {prompt_expected}{self.llm.AI_PROMPT}"
                )
            mock_redis_instance.set.assert_called_once()

def test_gen_stream(self):
        messages = [
            {"content": "context"},
            {"content": "question"}
        ]
        mock_responses = [Mock(completion="response_1"), Mock(completion="response_2")]

        with patch("application.cache.make_redis") as mock_make_redis:
            mock_redis_instance = mock_make_redis.return_value
            mock_redis_instance.get.return_value = None
            mock_redis_instance.set = Mock()

adapt test case on sage_maker

def test_gen(self):
        with patch('application.cache.make_redis') as mock_make_redis:
            mock_redis_instance = mock_make_redis.return_value
            mock_redis_instance.get.return_value = None

            with patch.object(self.sagemaker.runtime, 'invoke_endpoint',
                            return_value=self.response) as mock_invoke_endpoint:
                output = self.sagemaker.gen(None, self.messages)
                mock_invoke_endpoint.assert_called_once_with(
                    EndpointName=self.sagemaker.endpoint,
                    ContentType='application/json',
                    Body=self.body_bytes
                )
                self.assertEqual(output,
                                self.result[0]['generated_text'][len(self.prompt):])
            mock_make_redis.assert_called_once()
            mock_redis_instance.set.assert_called_once()

    def test_gen_stream(self):
        with patch('application.cache.make_redis') as mock_make_redis:
            mock_redis_instance = mock_make_redis.return_value
            mock_redis_instance.get.return_value = None

            with patch.object(self.sagemaker.runtime, 'invoke_endpoint_with_response_stream',
                            return_value=self.response) as mock_invoke_endpoint:
                output = list(self.sagemaker.gen_stream(None, self.messages))
                mock_invoke_endpoint.assert_called_once_with(
                    EndpointName=self.sagemaker.endpoint,
                    ContentType='application/json',
                    Body=self.body_bytes_stream
                )
                self.assertEqual(output, [])
            mock_redis_instance.set.assert_called_once()

make cache by whole conver list cache_key = gen_cache_key(*messages)

Just pushed some minor changes with singleton + docker handling + error handling
I also removed some docstrings there.

@holopin-bot @fadingNA  Thank you!

@dartpain youre welcome Alex


Cannot select words when confirming seed when using increased font size

Only 4 of the 12 words can be selected in the Confim Seed view when confirming the 12 words seed. The remaining words fall outside of the screen and cannot be selected when using an increased font size.
To Reproduce

Increase mobile font size
Open app
Goto "Settings"
Select "Seed backup"
Enter PIN
Select "Press and Hold to Reveal"
Select "Continue"

Expected behavior
All 12 words can be selected.
Actual behavior
Only 4 of the 12 words can be selected.
Syrius Mobile

Version: v0.4.0
OS: Android 14, Samsung Galaxy S24

Workaround
Reset default font-size and backup seed.

This is also an issue when using a 24 words seed phrase. The remaining words fall outside of the screebn, even with normal font-size.

Fixed in v0.5.2.


Can I estimate the memory usage of sharp to load a file given the file size and format?

Question about an existing feature
Is it possible to estimate the memory usage of a the simplest sharp pipeline given file size and format of the input file?
What are you trying to achieve?
I am deploying lambda functions that are using sharp to load and process tiff, jpeg, png files that could range to few kb to gigabytes.
I'm creating one function per format and file size range that are given different memory allocation and VIPS_DISC_THRESHOLD based on the file size.
So far I've been adjusting those ranges based on failures. And I found that the file sizes was not giving consistent memory usage and had to increase the memory allocated for smaller file size to cope with few cases.
Or seeing large file size consuming a lot less memory than smaller ones.
I wonder if there is a more reliable way to go about it.
The memory allocated I'm curious about is only for the simplest pipeline operation, and it doesn't need to be accurate but rather consistent.

  new Promise((resolve, reject) => {
    const image = sharp(fileBuffer, {
      density: 300,
      // limitInputPixels is also defined for each ranges,
      failOnError: false,
    });

    image.withMetadata();

    if (isPng) {
      image.rotate().png();
    } else {
      image.rotate().jpeg({
        quality: 100,
      });
    }

    image.toBuffer((err, buffer, info) => {
      if (err) {
        reject(err);
      } else {
        resolve({ buffer, info });
      }
    });
  });

I understand if there is no consistent way to go about this, any clue is appreciated.

When you say "file size", do you mean the size in bytes of the file, or the dimensions of image based on header metadata? For the former, unlikely, for the latter, maybe but you'll need to experiment.
Remember that with AWS Lambda you get more CPU time when you request more RAM, so my advice is usually to give it as much memory as possible as that'll be more efficient in terms of time, money and maybe even energy consumption.
https://sharp.pixelplumbing.com/install#aws-lambda

I meant file size in bytes. I don't know the dimensions of the files at that point (I actually use sharp to know it).
I could work around to get the dimensions, but given my requirement, your comment on the time and energy consumption make a lot of sense.
For info thats what i got now:
const sizes = [
      { size: '3mb', memorySize: 768 },
      { size: '4mb', memorySize: 1280 },
      { size: '120mb', memorySize: 2048 },
      { memorySize: 4096 },
];

I'm thinking of getting rid of that now and run with 2048m with a fallback to 4096m on failure.
thank you

I've started to develop a library based on this, to provide boilerplate code to deploy lambda function that use sharps with sensible default.
My goal is to ship with two pre-coded lambda tasks that handle converting images and on-fly resizing, which will provide the basis to setup any type of tasks.
https://github.com/rawpixel-vincent/sharp-lambda-boilerplate/pull/1


prometheus-libvirt-exporter: init at 2.3.3 and add the prometheus module

Description of changes
This adds the libvirt exporter for prometheus and the relevant exporter module.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg eval

@ofborg build prometheus-libvirt-exporter

@FliegendeWurst all done.

Formatting CI failed

Please go to the Nixpkgs root directory, run nix-shell, then:
nixfmt 'nixos/modules/services/monitoring/prometheus/exporters/libvirt.nix' 'pkgs/by-name/pr/prometheus-libvirt-exporter/package.nix'
Make sure your branch is up to date with master, rebase if not.


Square Wave Plot

Suggestion:
One of the things that I am using this library for is plotting square waves for IO signals, specifically they are on or off statuses.
I am currently using a scatterplot to perform this operation, so what I do is take my input data and extrapolate the extra data in order to get the nice square wave look, by adding in additional points (that do not exist in the data).
For example, if the state were to change from 0 to 1, I would add in an intermediate point of y=0 where the X value is the same as the X value where Y=1
So this works fine as to what's currently available, but I wonder if a new plot type would make sense here, That can handle that interaction automatically in the rendering phase instead of having additional points introduced into the data set

would a step plot help? https://scottplot.net/cookbook/5.0/Scatter/ScatterStep/

I didn't even see that in the cookbook!
I'll play around and close this if it meets the idea, which I believe it will. Thanks!


standardize on LLM_MODEL env var

This is what's currently in the README, as this user pointed out: https://github.com/OpenDevin/OpenDevin/pull/234

Merging this since it's broken


Update confetti-rain.js

Enable setting a custom number of confetti particles

Thanks @mmelo for adding this configuration. Correct me if I'm wrong, but shouldn't we have a default value for that configuration?
The old MAX_PARTICLES should be the default in case people  don't set this new prop.
What do you think?

Hey @san650, thank you for the quick reply, please mind this bit here I kept MAX_PARTICLES count as a default so it doesn't break, nor will anyone need to pass it as a config if not needed. cheers!

@mmelo Thanks for contributing!

Thank you for the quick reply @san650 and for the merge 🙏


Unable to create Wireless interface: Parent Interface Required

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
I am running 	OPNsense 22.7.1-amd64 FreeBSD 13.1-RELEASE OpenSSL 1.1.1q 5 Jul 2022 (default installation) on Proxmox 7.2, with passthrough Wifi card to OPNsense.
I cannot see any WIFI card in ifconfig but I know that it is detected with system, when I try to assign it to interface in GUI it tells me:

To Reproduce
Steps to reproduce the behavior:

Interfaces: Wireless: Devices -> add new device (fails here when confirming)

Describe alternatives you considered
I also tried to create wlan0 with ifconfig command, what then appeared in ifconfig  but when i tried to assigne the wlan0 in OPNsense GUI to wireless interface same error
Additional context
# uname -a
FreeBSD OPNsense.test.com 13.1-RELEASE FreeBSD 13.1-RELEASE stable/22.7-n250212-a26d6065f1f SMP amd64

# sysctl net.wlan.devices
net.wlan.devices: iwm0

# pciconf -lv
iwm0@pci0:1:0:0:        class=0x028000 rev=0x10 hdr=0x00 vendor=0x8086 device=0x24fb subvendor=0x8086 subdevice=0x2110
    vendor     = 'Intel Corporation'
    device     = 'Dual Band Wireless-AC 3168NGW [Stone Peak]'
    class      = network

# dmesg | grep iwm0
iwm0: <Intel(R) Dual Band Wireless AC 3168> mem 0xfe800000-0xfe801fff irq 16 at device 0.0 on pci1
iwm0: hw rev 0x220, fw ver 22.361476.0, address 14:18:c3:06:df:4c
iwm0: <Intel(R) Dual Band Wireless AC 3168> mem 0xfe800000-0xfe801fff irq 16 at device 0.0 on pci1
iwm0: hw rev 0x220, fw ver 22.361476.0, address 14:18:c3:06:df:4c
iwm0: <Intel(R) Dual Band Wireless AC 3168> mem 0xfe800000-0xfe801fff irq 16 at device 0.0 on pci1
iwm0: hw rev 0x220, fw ver 22.361476.0, address 14:18:c3:06:df:4c
iwm0: <Intel(R) Dual Band Wireless AC 3168> mem 0xfe800000-0xfe801fff irq 16 at device 0.0 on pci1
iwm0: hw rev 0x220, fw ver 22.361476.0, address 14:18:c3:06:df:4c
iwm0: <Intel(R) Dual Band Wireless AC 3168> mem 0xfe800000-0xfe801fff irq 16 at device 0.0 on pci1
iwm0: hw rev 0x220, fw ver 22.361476.0, address 14:18:c3:06:df:4c
iwm0: <Intel(R) Dual Band Wireless AC 3168> mem 0xfe800000-0xfe801fff irq 16 at device 0.0 on pci1
iwm0: hw rev 0x220, fw ver 22.361476.0, address 14:18:c3:06:df:4c

# nano /etc/rc.conf
legal.intel.license_ack=1
if_iwm_load="YES"
iwm3168fw_load="YES"
wlan_wep_load="YES"
wlan_ccmp_load="YES"
wlan_tkip_load="YES"

# nano /boot/loader.conf.local
if_iwm_load="YES"
iwm3168fw_load="YES"
legal.intel_iwi.license_ack=1
if_ath_load="YES"
wlan_wep_load="YES"
wlan_ccmp_load="YES"
wlan_tkip_load="YES"

# kldstat
Id Refs Address                Size Name
 1   95 0xffffffff80200000  215db98 kernel
 2    1 0xffffffff8235e000   5b9378 zfs.ko
 3    1 0xffffffff82918000     4b58 if_enc.ko
 4    1 0xffffffff8291d000     3b18 pflog.ko
 5    3 0xffffffff82921000    741a8 pf.ko
 6    1 0xffffffff82996000    2c858 if_iwm.ko
 7    1 0xffffffff829c3000     35d0 if_ath.ko
 8    2 0xffffffff829c7000     2df8 ath_dfs.ko
 9    2 0xffffffff829ca000     6478 ath_rate.ko
10    2 0xffffffff829d1000    70108 ath_hal_ar9300.ko
11    2 0xffffffff82a42000    40e70 ath_hal_ar5416.ko
12    3 0xffffffff82a83000    2d400 ath_hal_ar5212.ko
13    2 0xffffffff82ab1000    12008 ath_hal_ar5211.ko
14    2 0xffffffff82ac4000     d038 ath_hal_ar5210.ko
15    1 0xffffffff82ad2000     ba48 if_gre.ko
16    1 0xffffffff82ade000     e4d0 if_bridge.ko
17    2 0xffffffff82aed000     7870 bridgestp.ko
18    1 0xffffffff82af5000     f460 carp.ko
19    1 0xffffffff82b05000     ab48 opensolaris.ko
20    1 0xffffffff82b11000     7f30 virtio_console.ko
21    1 0xffffffff82b19000    181d0 if_lagg.ko
22    2 0xffffffff82b32000     3538 if_infiniband.ko
23    1 0xffffffff82b36000     e318 pfsync.ko
24    1 0xffffffff82b45000    fda80 iwm3168fw.ko
25    1 0xffffffff83118000     3250 ichsmb.ko
26    1 0xffffffff8311c000     2180 smbus.ko
27    1 0xffffffff8311f000    16308 qat.ko
28    1 0xffffffff83136000     20f0 coretemp.ko
29    1 0xffffffff83139000     39c0 ng_socket.ko
30    4 0xffffffff8313d000     aac8 netgraph.ko
31    1 0xffffffff83148000     31c8 ng_ether.ko
32    1 0xffffffff8314c000     53f8 ng_netflow.ko
33    1 0xffffffff83152000     31e8 ng_ksocket.ko

Expected behavior
I want to use the wireless card as AP.

looks like a regression in https://github.com/opnsense/core/commit/3ef64ab8ea09d2f0aea801578e985499b8e0d772, should be fixed with https://github.com/opnsense/core/commit/c11df998cb9ee1ae61b45e326d150b4889dd17d5
Try locally via a console with:
opnsense-patch c11df99

looks like a regression in 3ef64ab, should be fixed with c11df99
Try locally via a console with:
opnsense-patch c11df99

Amazing Thank you!
I even ordered new Wifi card... But maybe it will be even better with new card, if FreeBSD should be better supported for that card.