Minor rewording for clarification

Attempted to clarify the wording around the 800 country code, which is distinct from the 800 area code, and was initially confusing (to me).

This change is

I signed it!

 Thanks! Can you also make the same change for the 8th falsehood that refers to 00800 numbers?

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Getting 403 errors for bosh cck tasks

sandbox@ubuntu-bastion:~$ bosh cck
Acting as user 'admin' on deployment 'cf' on 'photon-bosh-sandbox'
RSA 1024 bit CA certificates are loaded due to old openssl compatibility
Performing cloud check...

Director task 313
  Started scanning 17 vms
  Started scanning 17 vms > Checking VM states. Failed: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' } (00:00:10)

Error 100: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' }

Task 313 error

For a more detailed error report, run: bosh task 313 --debug

Full operations like bosh deploy or bosh delete deployment work fine. An intermediate operation like bosh cck. --details don't add any additional meaningful info. This may be related with a token refresh.

Tracked as https://www.pivotaltracker.com/story/show/129565427

Tested cpi dev.3 and get the same message. Output below:
andbox@ubuntu-bastion:~$ photon vm stop 4f00ae99-89c3-4008-b9c6-5a30c0012ad1 && photon vm delete 4f00ae99-89c3-4008-b9c6-5a30c0012ad1 && bosh cck
Using target 'https://<IP_ADDRESS>:443'
STOP_VM completed for 'vm' entity 4f00ae99-89c3-4008-b9c6-5a30c0012ad1
Using target 'https://<IP_ADDRESS>:443'
DELETE_VM completed for 'vm' entity 4f00ae99-89c3-4008-b9c6-5a30c0012ad1
Acting as user 'admin' on deployment 'concourse' on 'photon-bosh-sandbox'
RSA 1024 bit CA certificates are loaded due to old openssl compatibility
Performing cloud check...

Director task 46
  Started scanning 3 vms
  Started scanning 3 vms > Checking VM states. Done (00:00:11)
  Started scanning 3 vms > 2 OK, 0 unresponsive, 1 missing, 0 unbound. Done (00:00:00)
     Done scanning 3 vms (00:00:11)

  Started scanning 1 persistent disks
  Started scanning 1 persistent disks > Looking for inactive disks. Done (00:00:00)
  Started scanning 1 persistent disks > 1 OK, 0 missing, 0 inactive, 0 mount-info mismatch. Done (00:00:00)
     Done scanning 1 persistent disks (00:00:00)

Task 46 done

Started        2016-09-02 06:54:53 UTC
Finished           2016-09-02 06:55:04 UTC
Duration           00:00:11

Scan is complete, checking if any problems found...

Found 1 problem

Problem 1 of 1: VM with cloud ID '4f00ae99-89c3-4008-b9c6-5a30c0012ad1' missing.
  1. Skip for now
  2. Recreate VM for 'web/0 (a2ad4133-1f70-4415-a080-a22904e032d8)' without waiting for processes to start
  3. Recreate VM for 'web/0 (a2ad4133-1f70-4415-a080-a22904e032d8)' and wait for processes to start
  4. Delete VM reference
Please choose a resolution [1 - 4]: 2

Below is the list of resolutions you've provided
Please make sure everything is fine and confirm your changes

  1. VM with cloud ID '4f00ae99-89c3-4008-b9c6-5a30c0012ad1' missing.
     Recreate VM for 'web/0 (a2ad4133-1f70-4415-a080-a22904e032d8)' without waiting for processes to start

Apply resolutions? (type 'yes' to continue): yes
Applying resolutions...

Director task 47
  Started applying problem resolutions > VM with cloud ID '4f00ae99-89c3-4008-b9c6-5a30c0012ad1' missing. (missing_vm 7): Recreate VM for 'web/0 (a2ad4133-1f70-4415-a080-a22904e032d8)' without waiting for processes to start. Failed: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' } (00:00:01)

Error 100: Error resolving problem '12': photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' }

Task 47 error

For a more detailed error report, run: bosh task 47 --debug
sandbox@ubuntu-bastion:~$ bosh task 47 --cpi
Acting as user 'admin' on 'photon-bosh-sandbox'

RSA 1024 bit CA certificates are loaded due to old openssl compatibility
Director task 47

Task 47 error

Seems to be a new issue with recreating vm/disk. Would you please try "bosh task 47 --debug" to get the log?

sandbox@ubuntu-bastion:~$ bosh task 47 --debug
Acting as user 'admin' on 'photon-bosh-sandbox'

RSA 1024 bit CA certificates are loaded due to old openssl compatibility
Director task 47
I, [2016-09-02T06:55:13.409012 #23155] [0x2ac3d8463108]  INFO -- TaskHelper: Director Version: 1.3262.3.0
I, [2016-09-02T06:55:13.409580 #23155] [0x2ac3d8463108]  INFO -- TaskHelper: Enqueuing task: 47
I, [2016-09-02 06:55:13 #26778] []  INFO -- DirectorJobRunner: Looking for task with task id 47
D, [2016-09-02 06:55:13 #26778] [] DEBUG -- DirectorJobRunner: (0.000179s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [] DEBUG -- DirectorJobRunner: (0.000345s) SELECT * FROM "tasks" WHERE "id" = 47
I, [2016-09-02 06:55:13 #26778] []  INFO -- DirectorJobRunner: Found task #<Bosh::Director::Models::Task @values={:id=>47, :state=>"queued", :timestamp=>2016-09-02 06:55:13 UTC, :description=>"apply resolutions", :result=>nil, :output=>"/var/vcap/store/director/tasks/47", :checkpoint_time=>2016-09-02 06:55:13 UTC, :type=>"cck_apply", :username=>"admin", :deployment_name=>"concourse", :started_at=>nil}>
I, [2016-09-02 06:55:13 #26778] []  INFO -- DirectorJobRunner: Starting task: 47
I, [2016-09-02 06:55:13 #26778] [task:47]  INFO -- DirectorJobRunner: Creating job
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000122s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000109s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000488s) SELECT * FROM "deployments" WHERE ("name" = 'concourse') LIMIT 1
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000125s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000202s) SELECT * FROM "tasks" WHERE "id" = 47
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000113s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000202s) SELECT * FROM "tasks" WHERE "id" = 47
I, [2016-09-02 06:55:13 #26778] [task:47]  INFO -- DirectorJobRunner: Performing task: #<Bosh::Director::Models::Task @values={:id=>47, :state=>"queued", :timestamp=>2016-09-02 06:55:13 UTC, :description=>"apply resolutions", :result=>nil, :output=>"/var/vcap/store/director/tasks/47", :checkpoint_time=>2016-09-02 06:55:13 UTC, :type=>"cck_apply", :username=>"admin", :deployment_name=>"concourse", :started_at=>nil}>
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000129s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000089s) BEGIN
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000431s) UPDATE "tasks" SET "state" = 'processing', "timestamp" = '2016-09-02 06:55:13.895693+0000', "description" = 'apply resolutions', "result" = NULL, "output" = '/var/vcap/store/director/tasks/47', "checkpoint_time" = '2016-09-02 06:55:13.895833+0000', "type" = 'cck_apply', "username" = 'admin', "deployment_name" = 'concourse', "started_at" = '2016-09-02 06:55:13.895760+0000' WHERE ("id" = 47)
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.001024s) COMMIT
I, [2016-09-02 06:55:13 #26778] [task:47]  INFO -- DirectorJobRunner: Acquiring deployment lock on concourse
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: Acquiring lock: lock:deployment:concourse
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000124s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000111s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000117s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000525s) SELECT count(*) AS "count" FROM "locks" WHERE (("name" = 'lock:deployment:concourse') AND ("uid" = 'a8a5fb35-5f0c-4064-b581-102a2b7f308d')) LIMIT 1
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000111s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000077s) BEGIN
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000372s) INSERT INTO "locks" ("name", "uid", "expired_at") VALUES ('lock:deployment:concourse', 'a8a5fb35-5f0c-4064-b581-102a2b7f308d', '2016-09-02 06:55:24.902121+0000') RETURNING *
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.007437s) COMMIT
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: Acquired lock: lock:deployment:concourse
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000121s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000107s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000423s) SELECT count(*) AS "count" FROM "deployment_problems" WHERE ("id" IN ('12')) LIMIT 1
I, [2016-09-02 06:55:13 #26778] [task:47]  INFO -- DirectorJobRunner: Applying problem resolutions
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000131s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000108s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000197s) SELECT * FROM "deployment_problems" WHERE ("id" IN ('12'))
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000691s) SELECT * FROM "instances" WHERE ("id" = 7) LIMIT 1
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000269s) SELECT * FROM "instances" WHERE ("id" = 7) LIMIT 1
I, [2016-09-02 06:55:13 #26778] [task:47]  INFO -- DirectorJobRunner: VM with cloud ID '4f00ae99-89c3-4008-b9c6-5a30c0012ad1' missing. (missing_vm 7): Recreate VM for 'web/0 (a2ad4133-1f70-4415-a080-a22904e032d8)' without waiting for processes to start
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: Recreating Vm: web/0 (a2ad4133-1f70-4415-a080-a22904e032d8))
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: Deleting Vm: web/0 (a2ad4133-1f70-4415-a080-a22904e032d8))
D, [2016-09-02 06:55:13 #26778] [] DEBUG -- DirectorJobRunner: Renewing lock: lock:deployment:concourse
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.003933s) SELECT * FROM "deployments" WHERE "id" = 2
D, [2016-09-02 06:55:13 #26778] [] DEBUG -- DirectorJobRunner: (0.000986s) SET standard_conforming_strings = ON
D, [2016-09-02 06:55:13 #26778] [] DEBUG -- DirectorJobRunner: (0.000101s) SET client_min_messages = 'WARNING'
D, [2016-09-02 06:55:13 #26778] [] DEBUG -- DirectorJobRunner: (0.000116s) SET DateStyle = 'ISO'
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000221s) SELECT * FROM "tasks" WHERE "id" = 47
I, [2016-09-02 06:55:13 #26778] [task:47]  INFO -- DirectorJobRunner: Deleting VM
D, [2016-09-02 06:55:13 #26778] [task:47] DEBUG -- DirectorJobRunner: External CPI sending request: {"method":"delete_vm","arguments":["4f00ae99-89c3-4008-b9c6-5a30c0012ad1"],"context":{"director_uuid":"101da2c9-f611-4f1b-891e-9742cc25e7d9"}} with command: /var/vcap/jobs/cpi/bin/cpi
D, [2016-09-02 06:55:13 #26778] [] DEBUG -- DirectorJobRunner: (0.002344s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [] DEBUG -- DirectorJobRunner: (0.000116s) SELECT NULL
D, [2016-09-02 06:55:13 #26778] [] DEBUG -- DirectorJobRunner: (0.001447s) UPDATE "locks" SET "expired_at" = '2016-09-02 06:55:24.925077+0000' WHERE (("name" = 'lock:deployment:concourse') AND ("uid" = 'a8a5fb35-5f0c-4064-b581-102a2b7f308d'))
D, [2016-09-02 06:55:14 #26778] [task:47] DEBUG -- DirectorJobRunner: External CPI got response: {"result":null,"error":{"type":"Bosh::Clouds::CloudError","message":"photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' }","ok_to_retry":false},"log":"2016-09-02T06:55:14Z INFO Begin action delete_vm\n2016-09-02T06:55:14Z INFO Raw action arguments: []interface {}{\"4f00ae99-89c3-4008-b9c6-5a30c0012ad1\"}\n2016-09-02T06:55:14Z INFO Deleting VM: 4f00ae99-89c3-4008-b9c6-5a30c0012ad1\n2016-09-02T06:55:14Z INFO Detaching disks\n2016-09-02T06:55:14Z INFO Stopping VM\n2016-09-02T06:55:14Z ERROR Error encountered during action delete_vm: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' }\n"}, err: , exit_status: pid 26804 exit 0
E, [2016-09-02 06:55:14 #26778] [task:47] ERROR -- DirectorJobRunner: Error resolving problem '12': photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' }
E, [2016-09-02 06:55:14 #26778] [task:47] ERROR -- DirectorJobRunner: /var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh_cpi-1.3262.3.0/lib/cloud/external_cpi.rb:119:in `handle_error'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh_cpi-1.3262.3.0/lib/cloud/external_cpi.rb:88:in `invoke_cpi_method'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh_cpi-1.3262.3.0/lib/cloud/external_cpi.rb:52:in `delete_vm'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/vm_deleter.rb:29:in `block in delete_vm'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/error_ignorer.rb:9:in `with_force_check'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/vm_deleter.rb:28:in `delete_vm'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/vm_deleter.rb:16:in `delete_for_instance'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/cloudcheck_helper.rb:49:in `delete_vm_from_cloud'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/cloudcheck_helper.rb:67:in `recreate_vm'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/cloudcheck_helper.rb:62:in `recreate_vm_skip_post_start'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/problem_handlers/missing_vm.rb:20:in `block (2 levels) in <class:MissingVM>'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/problem_handlers/base.rb:83:in `instance_eval'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/problem_handlers/base.rb:83:in `apply_resolution'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/problem_resolver.rb:65:in `block in apply_resolution'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/problem_resolver.rb:24:in `block in track_and_log'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/event_log.rb:99:in `advance_and_track'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/problem_resolver.rb:22:in `track_and_log'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/problem_resolver.rb:64:in `apply_resolution'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/problem_resolver.rb:43:in `block in apply_resolutions'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/dataset/actions.rb:139:in `block in each'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:669:in `block (2 levels) in fetch_rows'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:861:in `block in yield_hash_rows'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:855:in `times'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:855:in `yield_hash_rows'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:669:in `block in fetch_rows'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:175:in `execute'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:525:in `_execute'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:341:in `block (2 levels) in execute'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:546:in `check_database_errors'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:341:in `block in execute'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/database/connecting.rb:251:in `block in synchronize'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/connection_pool/threaded.rb:105:in `hold'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/database/connecting.rb:251:in `synchronize'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:341:in `execute'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/dataset/actions.rb:952:in `execute'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/adapters/postgres.rb:669:in `fetch_rows'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/sequel-4.32.0/lib/sequel/dataset/actions.rb:139:in `each'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/problem_resolver.rb:34:in `apply_resolutions'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/jobs/cloud_check/apply_resolutions.rb:38:in `block in perform'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/lock_helper.rb:13:in `block in with_deployment_lock'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/lock.rb:53:in `lock'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/lock_helper.rb:13:in `with_deployment_lock'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/jobs/cloud_check/apply_resolutions.rb:37:in `perform'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/job_runner.rb:94:in `perform_job'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/job_runner.rb:32:in `block in run'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh_common-1.3262.3.0/lib/common/thread_formatter.rb:49:in `with_thread_name'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/job_runner.rb:32:in `run'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/jobs/base_job.rb:10:in `perform'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/jobs/db_job.rb:24:in `block in perform'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/jobs/db_job.rb:72:in `block (3 levels) in run'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/eventmachine-1.0.4/lib/eventmachine.rb:1046:in `block in spawn_threadpool'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/logging-1.8.2/lib/logging/diagnostic_context.rb:323:in `block in create_with_logging_context'
D, [2016-09-02 06:55:14 #26778] [] DEBUG -- DirectorJobRunner: Lock renewal thread exiting
D, [2016-09-02 06:55:14 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000616s) SELECT NULL
D, [2016-09-02 06:55:14 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000349s) SELECT NULL
D, [2016-09-02 06:55:14 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000202s) SELECT NULL
D, [2016-09-02 06:55:14 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.001180s) DELETE FROM "locks" WHERE (("name" = 'lock:deployment:concourse') AND ("uid" = 'a8a5fb35-5f0c-4064-b581-102a2b7f308d'))
D, [2016-09-02 06:55:14 #26778] [task:47] DEBUG -- DirectorJobRunner: Deleted lock: lock:deployment:concourse uid: a8a5fb35-5f0c-4064-b581-102a2b7f308d
E, [2016-09-02 06:55:14 #26778] [task:47] ERROR -- DirectorJobRunner: Error resolving problem '12': photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' }
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/jobs/cloud_check/apply_resolutions.rb:41:in `block in perform'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/lock_helper.rb:13:in `block in with_deployment_lock'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/lock.rb:53:in `lock'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/lock_helper.rb:13:in `with_deployment_lock'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/jobs/cloud_check/apply_resolutions.rb:37:in `perform'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/job_runner.rb:94:in `perform_job'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/job_runner.rb:32:in `block in run'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh_common-1.3262.3.0/lib/common/thread_formatter.rb:49:in `with_thread_name'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/job_runner.rb:32:in `run'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/jobs/base_job.rb:10:in `perform'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/jobs/db_job.rb:24:in `block in perform'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/bosh-director-1.3262.3.0/lib/bosh/director/jobs/db_job.rb:72:in `block (3 levels) in run'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/eventmachine-1.0.4/lib/eventmachine.rb:1046:in `block in spawn_threadpool'
/var/vcap/packages/director/gem_home/ruby/2.3.0/gems/logging-1.8.2/lib/logging/diagnostic_context.rb:323:in `block in create_with_logging_context'
D, [2016-09-02 06:55:14 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000190s) SELECT NULL
D, [2016-09-02 06:55:14 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000127s) BEGIN
D, [2016-09-02 06:55:14 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000527s) UPDATE "tasks" SET "state" = 'error', "timestamp" = '2016-09-02 06:55:14.585470+0000', "description" = 'apply resolutions', "result" = 'Error resolving problem ''12'': photon: { HTTP status: ''403'', code: ''AccessForbidden'', message: '''', data: ''map[]'' }', "output" = '/var/vcap/store/director/tasks/47', "checkpoint_time" = '2016-09-02 06:55:13.895833+0000', "type" = 'cck_apply', "username" = 'admin', "deployment_name" = 'concourse', "started_at" = '2016-09-02 06:55:13.895760+0000' WHERE ("id" = 47)
D, [2016-09-02 06:55:14 #26778] [task:47] DEBUG -- DirectorJobRunner: (0.000860s) COMMIT
I, [2016-09-02 06:55:14 #26778] []  INFO -- DirectorJobRunner: Task took 0.698524497 seconds to process.

Task 47 error

Another instance of this 403 error appears under the following conditions:
bosh disks --orphaned
RSA 1024 bit CA certificates are loaded due to old openssl compatibility

+--------------------------------------+------------+-----------------+---------------------------------------------------------------+-----+-------------------------+
| Disk CID                             | Size (MiB) | Deployment Name | Instance Name                                                 | AZ  | Orphaned At             |
+--------------------------------------+------------+-----------------+---------------------------------------------------------------+-----+-------------------------+
| fde356ae-c138-433e-92f5-e168f42ac45f | 3000       | cf              | diego_database-partition/df6c312d-95c4-439a-bf5d-0d600422594a | az1 | 2016-09-06 21:23:47 UTC |
| ebcb2004-6b15-4c7d-9270-e14ddd440ffc | 3000       | cf              | diego_cell-partition/d96aa784-60fb-4864-9a2a-c1272b1c2f6d     | az1 | 2016-09-06 21:23:45 UTC |
| f1513951-8482-48f0-9213-b2d38d3ca1ba | 3000       | cf              | etcd_server-partition/938e9135-8ffc-400d-aa25-ee08822632f5    | az1 | 2016-09-06 21:23:42 UTC |
| 3e2c743c-2a19-40a1-b134-166e55961523 | 50000      | cf              | nfs_server-partition/eb8582be-000a-48ba-b4c1-6b5cb2c174c7     | az1 | 2016-09-06 21:23:41 UTC |
| 906687ca-6dc1-4d9d-abba-f6dd3dad72ef | 50000      | cf              | mysql-partition/ae6c31c9-e824-4b2b-9939-29b8d60b992c          | az1 | 2016-09-06 21:23:40 UTC |
| b77621ab-be83-4e9a-b82b-8b7041321141 | 50000      | cf              | diego_brain-partition/fc1e8104-1062-4885-8708-61119175e56f    | az1 | 2016-09-06 21:23:40 UTC |
| 6c274e41-3a78-4e46-8266-620980098eea | 30000      | concourse       | db/3705ecf8-1df6-4e0b-8fa5-98c6de3696a2                       | az1 | 2016-09-02 07:14:49 UTC |
+--------------------------------------+------------+-----------------+---------------------------------------------------------------+-----+-------------------------+

One or more of these disks were already deleted using photon disk delete <id>, and yet they are still in the DB. The solution for this would be a bosh cleanup --all, but the 403 error appears again:
bosh cleanup --all
Acting as user 'admin' on 'photon-bosh-sandbox'
RSA 1024 bit CA certificates are loaded due to old openssl compatibility

Director task 207
  Started deleting orphaned disks
  Started deleting orphaned disks > 6c274e41-3a78-4e46-8266-620980098eea
  Started deleting orphaned disks > 906687ca-6dc1-4d9d-abba-f6dd3dad72ef
  Started deleting orphaned disks > b77621ab-be83-4e9a-b82b-8b7041321141
  Started deleting orphaned disks > 3e2c743c-2a19-40a1-b134-166e55961523
  Started deleting orphaned disks > f1513951-8482-48f0-9213-b2d38d3ca1ba
  Started deleting orphaned disks > ebcb2004-6b15-4c7d-9270-e14ddd440ffc
  Started deleting orphaned disks > fde356ae-c138-433e-92f5-e168f42ac45f
   Failed deleting orphaned disks > ebcb2004-6b15-4c7d-9270-e14ddd440ffc: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' } (00:00:01)
   Failed deleting orphaned disks > 6c274e41-3a78-4e46-8266-620980098eea: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' } (00:00:01)
   Failed deleting orphaned disks > 906687ca-6dc1-4d9d-abba-f6dd3dad72ef: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' } (00:00:01)
   Failed deleting orphaned disks > b77621ab-be83-4e9a-b82b-8b7041321141: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' } (00:00:01)
   Failed deleting orphaned disks > fde356ae-c138-433e-92f5-e168f42ac45f: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' } (00:00:01)
   Failed deleting orphaned disks > f1513951-8482-48f0-9213-b2d38d3ca1ba: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' } (00:00:01)
   Failed deleting orphaned disks > 3e2c743c-2a19-40a1-b134-166e55961523: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' } (00:00:01)
   Failed deleting orphaned disks (00:00:01)

Error 100: photon: { HTTP status: '403', code: 'AccessForbidden', message: '', data: 'map[]' }

Task 207 error

Cleanup complete

The CPI log is:
bosh task 207 --cpi
Acting as user 'admin' on 'photon-bosh-sandbox'

RSA 1024 bit CA certificates are loaded due to old openssl compatibility
Director task 204
2016-09-07T20:31:06Z INFO Begin action delete_stemcell
2016-09-07T20:31:06Z INFO Raw action arguments: []interface {}{"684ec597-1568-4308-a5d3-e6bccdaf224b"}
2016-09-07T20:31:06Z INFO DeleteStemcell with stemcell_cid: '684ec597-1568-4308-a5d3-e6bccdaf224b'
2016-09-07T20:31:06Z INFO Beginning stemcell deletion
2016-09-07T20:31:06Z INFO Waiting on task: &photon.Task{ID:"44303b91-d7e0-4b81-b8b1-853a1001711e", Operation:"DELETE_IMAGE", State:"COMPLETED", StartedTime:1473280251000, EndTime:1473280251000, QueuedTime:1473280251000, Entity:photon.Entity{ID:"684ec597-1568-4308-a5d3-e6bccdaf224b", Kind:"image"}, SelfLink:"https://<IP_ADDRESS>/tasks/44303b91-d7e0-4b81-b8b1-853a1001711e", Steps:[]photon.Step{}, ResourceProperties:interface {}(nil)}
2016-09-07T20:31:06Z INFO Action response: <nil>
2016-09-07T20:31:06Z INFO End action delete_stemcell

Task 207 error

@RamXX: Thanks for this. We have a fix for the VM and we started working on a fix for disk deletes yesterday as I suspected the test you are doing by deleting a disk out of band might be another failure scenario that would run into issues.
Would you be able to send us a complete list of failure scenario tests you are performing so we can address them all before we give you another drop of the CPI?
@cppforlife: Are these failure scenarios covered by BATs?

@molteanu The typical test that we run is the "pull the rug" test, where we stop+delete a BOSH-controlled VM from the photon CLI and then do a bosh cck, or simply wait a minute or two for the resurrector to kick in. That definitely triggers the 403 error.
The other test we started doing yesterday was the one I posted above, attempting to delete orphaned resources that may or may not be there.
Overall, cck is the mechanism that we trust to fix inconsistencies between what BOSH believes the world to be, and what the IaaS is really doing. Network is also typically a component of this, but given the very simple networking model in Photon at the moment is not necessary.

We released a new version of the CPI which should address all these failures and a few other issues we discovered while testing these scenarios: https://github.com/cloudfoundry-incubator/bosh-photon-cpi-release/commit/bb57eb27dcb6e7dd49000534a2ea35702605f449


fix(util/platform): Protect against null value before attempting .slice()

Don't worry about the failing tests… BrowserStack's Safari isn't playing nice today…

great! can you squash the commits and force push? then I'd merge that asap :)

Shoot, I just messed up this squash. Gimme a minute to fix it.

My brain wasn't awake yet. This should be good.

Thx!


Find in Files trimming input text

Godot version:
3.3 stable
OS/device including version:
linux
Issue description:
Find in files does not honour white space at start or end, causing invalid results, which in many instances results in hundreds of erroneous results making searching impossible, even when 'whole words' is used (hoping it might honour whitespace). As screenshot only words with a space at start and end was required, but the input is trimmed causing all these results...

Steps to reproduce:

search for something with a space
the search trims the input

This is due to various .strip_edges() calls in editor/find_in_files.cpp. Most of those should be removed.

Thanks, that sounds embarrassingly like something I could have searched for in github web code view (not having the code downloaded)...
I did search the proposals to see if anyone had put in a suggestion to incorporate regex searches as that would be just lovely :)

These were intended to avoid typos though.

Ok, but surely a search facility shouldn't be trying to presume what you
wanted to find...
On Thu, 6 May 2021, 10:31 Marc, @.***> wrote:

These were intended to avoid typos though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/48464#issuecomment-833381796,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCERRKBTTIA6CFP4SF4SCTTMJOV3ANCNFSM44DRRTOQ
.

@Calinou Any specific convention I should use to decide which calls to leave in code and which to remove?

@Calinou Any specific convention I should use to decide which calls to leave in code and which to remove?

I haven't taken a look thoroughly, but make sure to tweak and test the behavior for both Find in Files and Replace in Files actions.

Looks like the call in FindInFilesDialog::get_folder should be kept since I cannot think of a scenario where a folder name should or even could have a leading/trailing whitespace.
I'd assume the call in get_search_text is what is causing this issue specifically. Also to me it seems like we should remove the call _on_result_found() as that would lead to technically inaccurate results? If the user searches hello then the result should include hello not hello as thats not entirely accurate.
I'll check out replace in files as well and of course run some tests.. That just leaves the question brought up by @Zylann, is removing these what we want to do or would that inhibit other search functionality like whole words from performing its job?

I'll check out replace in files as well and of course run some tests.. That just leaves the question brought up by @Zylann, is removing these what we want to do or would that inhibit other search functionality like whole words from performing its job?

Maybe we should strip edges only when not performing a whole-word search.


v2 and v3 active at the same time ?

Hi ,
may be it's a stupid question, but it is possible to have both integrations chomupashchuk V2 and fustom v3 both installed and active at the same time ?

https://github.com/fustom/ariston-remotethermo-home-assistant-v3/issues/103


Release/1.0.2

This bumps the version to 1.0.2.

Ok thanks, I'll bare that in mind for future, but I'm going to merge this one 👍


Uio focus styling

[ ] This pull request has been linted by running npm run lint without errors
[ ] This pull request has been tested by running npm run start and reviewing affected routes
[ ] This pull request has been built by running npm run build without errors
[ ] This isn't a duplicate of an existing pull request

Description

This PR adds focus and hover styling to uio contrast options.
Steps to test

run npm run start
select a uio contrast option using the uio tab in the top right corner of webpage
focus and hover over different elements on the webpage
repeat step 3 for the other webpages on website

Expected behavior:
Clear and appropriate focus/hover styling should appear on all webpages when uio contrast options are implemented.
Additional information
N?A

Related issues
closes #231

This PR needs to be merged AFTER PR #230

When running locally the latest commit works fine but "show preferences" is not working in deploy preview. Console shows following error:

@TeddTech I wonder if your built version is pulling in a different version of Infusion than the one you are testing with locally? Looking at your changed files it looks like it is pulling in a dev release of Infusion, but not one generated off of dev release from @cindyli's branch. Are you using npm link locally, that could explain it.

Hey @lliskovoi,
This PR contains some focus styling I did for the uio-contrast options
https://deploy-preview-233--wecount.netlify.app/

@TeddTech UIO is totally broken in this pull request. There's no way Lisa or anyone can test this pull request. Please fix it, probably first by merging in add-uio pull request. Thanks.

@TeddTech UIO is totally broken in this pull request. There's no way Lisa or anyone can test this pull request. Please fix it, probably first by merging in add-uio pull request. Thanks.

@lliskovoi this PR if fix and is free to check out the deploy preview

The search box is missing its border by default with UIO high contrast themes. The border only shows up on focus or hover. It should show up by default. I don't think this box needs special hover styling. At focus, the focus in the input box should be enough.

Ready for review

Having trouble correcting iPad views

Ready for review

The border of the search container on the mobile style doesn't look great:

There is an outstanding error in this PR that I feel should be addressed in a separate issue.

@cindyli there are inconsistent hover/focus colours for the last 3 uio contrast themes. Buttons, links, and uio preference panel have different hover/focus colours. I am thinking about addressing this issue in a separate PR. What are your thoughts?

@cindyli there are inconsistent hover/focus colours for the last 3 uio contrast themes. Buttons, links, and uio preference panel have different hover/focus colours. I am thinking about addressing this issue in a separate PR. What are your thoughts?

@TeddTech I agree this could be addressed separately if it is an issue.
From what I learnt from @jobara about the last three low contrast themes is they are designed with different set of colors for links, selected texts etc to match contrast themes on Windows (See @jobara's reply on SJRK pull request).
It feels to me the hover/focus style for links is correct. But the hover/focus style for UIO buttons ("show perferences", "hide preferences" and "reset") is in question.
@jobara and @lliskovoi, what do you think?


Function.prototype.toString

This is a fun bit of the spec: it doesn't have to be the actual code! "An implementation-dependent representation of the function is returned." This means we can whatever we want, provided we return a vaild FunctionDeclaration. So i propose returning "function () { throw new Error('ts2c doesn't store the source code of functions!'); }" if toString is called.

Well... I think .toString() was used quite often to find the name of the function.
Otherwise, yes, it should be fine to return smth like function myFunction() { [native code] }


Fix typo about SSL_CONF_FLAG_CMDLINE

I believe it should be SSL_CONF_FLAG_CMDLINE instead of SSL_CONF_CMDLINE in the document. The later seems doesn't exists.

Checklist

[x] documentation is added or updated

This pull request is ready to merge

Merged
6c014da0b2d84f657a6ea5145b5e90ddc9913ebe Fix typo about SSL_CONF_FLAG_CMDLINE


Re-add gunicorn to requirements file

What? and Why?

What does this pull request change/fix? Why was it nessessary?
Gunicorn was removed in the previous commit

Checklist

CHANGELOG.md updated? (if required)

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   96.59%   96.59%
=======================================
  Files           2        2
  Lines         264      264
=======================================
  Hits          255      255
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c55d52...aa95cd9. Read the comment docs.


Change language?

Hi!
I just tried your excellent app! It seems to work great, but I'm having trouble translating instructions from the internet in English, to my native language, Swedish. Is there a way to set Policy Plus to english, even though my Windows is set to a different language? Would help with following tutorials greatly!

I just implemented this in https://github.com/Fleex255/PolicyPlus/commit/14c0bf30db3472997b0562da3bdb7a80fe967c40. There is now a Set ADML Language option in the File menu that you can use to change the preferred language code. The code for US English is en-US.
The debug build has been updated. Please give that a try and let me know if there are any issues. Thanks!

@Fleex255 Awesome! Much appreciated!

It works great, thanks!


Review how AGENTS database is described on the IDN Catalogue Project page

The AGENTS database is used in the catalogue and MET form (https://metadata.idnau.org/ ) (add Custom Agent) and is accessible via log-in (https://agentsdb.idnau.org/) but is otherwise invisible to the user.

[ ] create a space for the description of the AGENTs DB somewhere on the Catalogue Project page
[ ] describe the AGENTS DB generally
[ ] describe how the AGENTS DB is used in the scoring
[ ] describe the future workflow for being added to the AGENTS DB


IConfigurationSource change causes Providers Load() to be called twice ... by design?

It looks to me that providers Load() method is being called twice now (RC2 bits). Once when the Build() method is called on ConfigurationBuilder and then again when ConfigurationRoot is constructed.  Is this intended?

Nope, we should pick one of these Load calls only.  @divega have a preference which class owns calling Load?

@dtillman good catch!
@HaoK it seems that

@dtillman good catch!
@HaoK it seems that ConfigurationRoot already has logic to load providers because of Reload(), and it seems cleaner to constrain the responsibility of the builder to just build the list of providers and pass it to the root, so I would vote for removing the call to Load() in the builder.

9a8825a6399be31c16e78c2313136ae0c26c09e0


Black screen when using full-screen mode from wine version 9.18

Software information
Name of the game: Dwarf Fortress,BG3_dx11,Terraria, etc
System information

GPU:NVIDIA GeForce RTX 3060
Driver:560.35.03 witch open kernel module
Wine version:  9.18-9.19
DXVK version: 2.4.1
egl-wayland: 1.1.16
xwayland: 24.1.2
Kernel: 6.11.2
DE: KDE Plasma 6.2 / Kwin
wayland: 1.23.1

Log files
game.log
When the game is started in full screen mode, only black screen is visible and the game hangs. Problem reproduced on all DX games.
The game can be run in window mode without problems.
This issue is seen on versions 9.18-9.19, version 9.17 and below not affected.
I sent the information about the error wine, but it was not considered because the problem appears only on dxvk, everything works on wined3d. https://bugs.winehq.org/show_bug.cgi?id=57275

Does DXVK 2.4 work?

One more thing to try here: does the problem go away if you revert to Nvidia drivers 535?

Do DXVK 2.4 or current master work?

Unfortunately downgrading to 2.4/ build from source code on github did not solve the problem.

One more thing to try here: does the problem go away if you revert to Nvidia drivers 535?

Unfortunately I can’t downgrade the video driver version now. But it is unlikely that this would have fixed the situation, as it has not been a problem before.

Yeah, see above, it's not our bug. Running at native resolution should resolve the issue though.

Yeah, see above, it's not our bug. Running at native resolution should resolve the issue though.

1920x1080 is "native resolution" for me .
Unfortunately, wine bugzilla does not pay attention to the messages related to dxvk work. Is there any way to more clearly point out the problem ? I can add a link to this discussion, but they will most likely ignore it.

I can't reproduce the issue when running at native res, but other than that the symptoms of the issue are the same.
If you can build your own wine, you could try reverting this commit (linking to github mirror because winehq seems to be down).

Out of curiosity does it work if when using wined3d launch dx11 Baldurs Gate 3 with WINE_D3D_CONFIG=renderer=vulkan? It use will use wined3ds vulkan renderer instead of OpenGL (d3d11 only)

Out of curiosity does it work if when using wined3d you launch dx11 Baldurs Gate 3 with WINE_D3D_CONFIG=renderer=vulkan? It will use wined3ds vulkan renderer instead of OpenGL (d3d11 only)

Without DXVK? Yes

you could try reverting this commit

I'll try

Candidate workaround:
https://github.com/doitsujin/dxvk/tree/swapchain-workaround

Edit: nvm, this doesn't even seem to fix it

Not working fully, but the game now does not hang completely, sound continues to play

I'll try

By default, the 32 bit version of wine is build, looking for information on how to change it.

I updated the branch, with that I get at least the FFXIV benchmark to run on my laptop again, which is what I've been using for testing.

By default, the 32 bit version of wine is build, looking for information on how to change it.

Built x64 version, but it didn’t solve the problem. Gamescope also not working.

Did you try the updated DXVK workaround?

Did you try the updated DXVK workaround?

I rebuild the swapchain-workaround branch with new changes and now it works for both my  assembled  wine and the wine from the package. This applies to games: Bg3_x11  Warhammer 40,000 Rogue Trader
But some games still don’t work. For example Dwarf Fortress, terraria, Dead Cells.
Sorry for the long answer, I checked different games/ combinations

From the Dwarf Fortress log:
err:   Presenter: Failed to acquire from fresh swap chain multiple times.
err:     Desired size:    1920x1080
err:     Surface size:    1920x1080
err:     Surface limits:  1920x1080 - 1920,1080
err:     Returning desired size as a last resort, this might be out of spec!

This is so weird, it's just giving us the same surface size that we'd use anyway...
Assuming this is a 64-bit game, can you run with validation layers enabled (VK_INSTANCE_LAYERS=VK_LAYER_khronos_validation DXVK_DEBUG=validation)? This might shine some light on what winevulkan is trying to do there, but I think that's firmly past the point where we can fix it on our end.

I’m not sure if dwarf fortress 64 bit game, additionally run deadcels.
deadcels.log
dwarffortress.log

hm yeah, nothing suspicious in there unlike in the non-native resolution case.
Very weird.

Is there anything else I can help with?

This is probably a Wine regression that I introduced in 9.18, working on it.

Description of the problem is similar, but I’m not sure it’s the same error. I had no problems with launching vulkan versions of games

I can also report to face this problem but with Star Citizen, since 9.18 DXVK start with:
04b4:fixme:system:NtUserQueryDisplayConfig flags 0x2, paths_count 0x7ffffe1fe338, paths 0x7fffff601ec0, modes_count 0x7ffffe1fe33c, modes 0x70218bb2f180, topology_id (nil) semi-stub
04b4:fixme:system:NtUserQueryDisplayConfig flags 0x2, paths_count 0x7ffffe1fe338, paths 0x7fffff601ec0, modes_count 0x7ffffe1fe33c, modes 0x70218bb2f180, topology_id (nil) semi-stub
warn:  D3D11DeviceContext::QueryInterface: Unknown interface query
warn:  db6f6ddb-ac77-4e88-8253-819df9bbf140
065c:fixme:dwmapi:DwmEnableMMCSS (1) stub

Then proceeds to spam the log with:
info:  Presenter: Actual swap chain properties:
info:    Format:       VK_FORMAT_B8G8R8A8_UNORM
info:    Color space:  VK_COLOR_SPACE_SRGB_NONLINEAR_KHR
info:    Present mode: VK_PRESENT_MODE_FIFO_KHR (dynamic: yes)
info:    Buffer size:  3840x2160
info:    Image count:  5
info:    Exclusive FS: 1

Well I finally got the correct build of wine WoW64 and can confirm that the patches from  @rbernon  https://bugs.winehq.org/attachment.cgi?id=77218&action=diff  really fix the situation and allow to run any game through normal (unmodified) DXVK version 2.4.1. Thanks for your participation, I hope these corrections will be included in wine 9.20
I’m not sure if I should "close" the discussion, so I’ll leave it open for now.

I can confirm that the wine 9.20 release completely fixed the problem for me. Thanks for your participation


No way to start text entry with the shift key pressed

This is a feature supported at least on iOS (and probably android).
Take for example the iOS Notes app, which when you start a new note the shift-key is pressed for you.
I'm not aware of any way to achieve that from flutter at the moment.
Reported from http://stackoverflow.com/questions/42747394/flutter-inputfield-keyoard

FYI @cbracken

Looks like this is the interface:
https://developer.apple.com/reference/uikit/uitextinputtraits/1624447-autocapitalizationtype?language=objc

And this is where we set ours:
https://github.com/flutter/engine/blob/059ab3a47165d98cb1d7ac5e2a2e4b50abf39832/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm#L138

Verified that when I was reporting this I was using too old of a gallery.  What the Stack Overflow poster was requesting is now the behavior in Flutter, however there is no way to change that.  Updating title.

Notes for future: we now expose autocapitalizationType (and most other UITextInputTraits properties), so it should be a matter of wiring it up in the framework and ensuring we've got an Android equivalent.
For  analogous code, see the handling of TextInput.setClient in FlutterTextInputPlugin.m and in lib/src/services/text_input.dart in the framework.

Just ran across a Flutter app with a sign-up page and would have been nice to have this so that the First and Last name fields started with a capital by default.

@eseidelGoogle Any Update on this?

On both iOS, text fields start auto-capitalised by default for regular text fields. Password/URL/email fields start lower-case by default.
We have not yet wired up a means to control autocapitalizationType from the framework. We use thumbs-up count to help prioritise work, so definitely +1 if manual control over autocapitalisation type for fields is something that you'd like to see.

Here is a workaround option using a formatter to capitalize the first character.
class SentenceCaseTextFormatter extends TextInputFormatter {
  @override
  TextEditingValue formatEditUpdate(TextEditingValue oldValue,
      TextEditingValue newValue) {
    return new TextEditingValue(
      text: toBeginningOfSentenceCase(newValue.text),
      selection: newValue.selection,
    );
  }
}

Fields with type TextInputType.text or TextInputType.multiline this should now be sentence-case by default on both iOS and Android.
We still haven't made the more general fix to make this manually specified, so still holding this issue open; I'll also re-title to more accurately reflect the proper solution.

Adding a bit more detailed list of TODOs for anyone who'd like to pick this up:
What we expose today is TextInputType, which drives which keyboard is used with EditableText and TextField widgets. Today, this implicitly drives the auto-capitalisation behaviour, which effectively amounts to 'non-obscureText text/multiline fields use sentence caps.'
To implement this, you'd need to:

Add a new enum (maybe TextCapitalizationType) in text_input.dart.
Add capitalizationType to TextInputConfiguration.
Add capitalizationType to EditableText and TextField.
Deserialise and handle capitalizationType in TextInputPlugin.java for the Android side.
Deserialise and handle capitalizationType in FlutterTextInputPlugin.mm for the iOS side.

Example of auto-cap's text as a TextInputFormatter.
https://gist.github.com/slightfoot/32fcb2dd419f6554b5f8a0d06989a5d3

@cbracken
some gave me a workaround where the input value is changing to capitalizing the first letters nicely
https://gist.github.com/slightfoot/32fcb2dd419f6554b5f8a0d06989a5d3
but I was wondering if there's a way I can make the keyboard change to caps as well when the formatter changes

I have noticed it's easier to use newValue.copyWith(text: changedText) or something like that, I'm pulling that from memory.

Disabling auto - capitalization for email and password fields seems like a no brainer what am I missing here?

Any updates here? I'd like this feature to disable auto-caps in text form fields for things like usernames, which people normally do not capitalize.

The text capitalization does not work on non-deafult keybaords. Is it going to be a fix for this or this is not planned?


#1413 Handle non existing collection

Thank you for your contribution to the KodaDot NFT gallery.
👇  _ Do a quick check before the merge.
PR type

[x] Bugfix
[ ] Feature
[x] Refactoring

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything works
[ ] I found edge cases

What's new?

[x] PR closes #1413
[ ] <brief_description_of_what_I've_added>

Had issue bounty label ?

[x] Fill up your KSM address: [Payout]
(https://kodadot.xyz/transfer/?target=EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU)

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI, a screenshot for others, is best to understand changes.

Perfect, I’ve sent the payout https://kusama.subscan.io/extrinsic/0x492a42b310c6c87dea4984f01c7844a79dd64e70173cbefe1768a88b35fd5bbf
Let’s grab another issue and get rewarded!
https://github.com/kodadot/nft-gallery/issues/


not updating race condition fix

This patch fixes #216 by tracking the updating status and refusing to close watchers while the new bundle is being generated. Previously, a race condition would remove watchers from fwatchers when 2 parallel 'update' events would use the same data structures.
This issue is easy to replicate on a big project by doing: while true; do touch main.js; done. Before, this would stop watchify from tracking changes to main.js very quickly. With this fix, watchify keeps on cranking.

lgtm! somewhat related, how do you feel about scheduling the update event on a debounce instead of a throttle?

oh wait... if you choose not to call bundle() on update, then nothing ever sets updating back to false. updating = true should probably happen in the b.on('bundle', ...), right?

When I put updating=true in the bundle event, the test suite hangs, so I put it back where it was previously.

Ah because this line in browserify should read output.pipe(concat(...));. The tests pass in a callback to bundle() instead of reading from the output stream. When used in that form, because of that bug, end never happens and the tests hang.
I'm stuck at work right now, but I can fix that later tonight.

Fixed upstream issue in browserify 11.0.1.

Nice! Just tried https://github.com/substack/watchify/commit/227be4e3849fc8b35d35d017f2091975a846d2aa and the tests pass now :smile:

shoot, looks like this didn't fix my issue... Maybe it's related to the fsevents issue :(


Use react for client rendering

It's finished! Restructured the client-side code to use React to render everything. The file structure got a bit chaotic but the code is better handled and a bit more responsive than before.

Good job! I'm still learning React, so maybe I'll take a look at how you made it, if you don't mind.

Thanks, and yeah I don't mind at all, that's the benefit of Open Source!

Thanks, my mod manager is open source too, but don't waste your time looking at the source code, it's still very chaotic.

Haha that's all part of the fun, hope you enjoy making it.

Of course I enjoy making it!  Why else would we do it? :D


Lots of disconnect, and as result - node is down

On some my nodes pool I see a lot disconnection, reconnection, and as result, I have status - down.
And it is applicable for almost 200 nodes!

No connection to server ts1.na.
Authenticated. Nice to see you connected again.
Disconnected from ts1.na. Retry at random intervals.

for example - https://securenodes1.na.zensystem.io/nodes/349713595/detail
And logs is:
2020-07-22 07:34:28 UTC -- Authenticated. Nice to see you connected again.
2020-07-22 07:34:28 UTC -- Received action: updateServers {"action":"updateServers","servers":["ts2.eu","ts1.eu","ts3.na","ts1.na","ts4.na","ts5.eu","ts4.eu","ts6.eu","ts3.eu","ts2.na"]}
2020-07-22 07:34:28 UTC -- Updated server list
2020-07-22 07:34:28 UTC -- Received action: get stats {"action":"get stats"}
2020-07-22 07:34:28 UTC -- Stats: send initial stats.
2020-07-22 07:34:28 UTC -- Received action: get config {"action":"get config"}
2020-07-22 07:34:28 UTC -- Saved servers=ts2.eu,ts1.eu,ts3.na,ts1.na,ts4.na,ts5.eu,ts4.eu,ts6.eu,ts3.eu,ts2.na
2020-07-22 07:34:29 UTC -- Stat check: server:ts1.na blocks:764256  peers:8  bal:0.0194  isValidBal:true  queueDepth:0  lastChalBlock:764204  lastExecSec:136.26
2020-07-22 07:34:29 UTC -- Received action: statsAck {"action":"statsAck","server":"ts1.na"}
2020-07-22 07:34:29 UTC -- Stats received by ts1.na
2020-07-22 07:34:55 UTC -- Stat check: server:ts1.na blocks:764256  peers:8  bal:0.0194  isValidBal:true  queueDepth:0  lastChalBlock:764204  lastExecSec:136.26
2020-07-22 07:34:55 UTC -- Received action: statsAck {"action":"statsAck","server":"ts1.na"}
2020-07-22 07:34:55 UTC -- Stats received by ts1.na
2020-07-22 07:37:05 UTC -- Disconnected from ts1.na. Retry at random intervals.
2020-07-22 07:37:06 UTC -- No connection to server ts1.na.
2020-07-22 07:37:21 UTC -- No connection to server ts1.na.
2020-07-22 07:37:36 UTC -- No connection to server ts1.na.
2020-07-22 07:37:45 UTC -- Reconnect attempts 1 39.4 seconds
2020-07-22 07:37:45 UTC -- Connected to server ts1.na. Initializing...
2020-07-22 07:37:45 UTC -- Checking t-address...
Node t_address (not for stake)=znjKdqmx6yX3ZgRWcJKDdodv76yCp47YbXT
2020-07-22 07:37:45 UTC -- Checking private z-addresses...
Balance for challenge transactions is 0.0194
Using the following address for challenges
zcHRNstoShbMuFSTPGHEvr28n3UDNJwSMgQr7SJsKEo1rPf4RoV81AvHYfu7VhRd27JVG8sf2QSbWEfJVXZCdn1ErJWfsRS
2020-07-22 07:38:19 UTC -- Disconnected from ts1.na. Retry at random intervals.
2020-07-22 07:38:21 UTC -- No connection to server ts1.na.
2020-07-22 07:38:36 UTC -- No connection to server ts1.na.
2020-07-22 07:38:51 UTC -- No connection to server ts1.na.
2020-07-22 07:39:03 UTC -- Reconnect attempts 1 44.6 seconds
2020-07-22 07:39:03 UTC -- Connected to server ts1.na. Initializing...
2020-07-22 07:39:03 UTC -- Checking t-address...
Node t_address (not for stake)=znjKdqmx6yX3ZgRWcJKDdodv76yCp47YbXT
2020-07-22 07:39:03 UTC -- Checking private z-addresses...
Balance for challenge transactions is 0.0194
Using the following address for challenges
zcHRNstoShbMuFSTPGHEvr28n3UDNJwSMgQr7SJsKEo1rPf4RoV81AvHYfu7VhRd27JVG8sf2QSbWEfJVXZCdn1ErJWfsRS
2020-07-22 07:39:04 UTC -- Authenticated. Nice to see you connected again.
2020-07-22 07:39:04 UTC -- Received action: updateServers {"action":"updateServers","servers":["ts1.eu","ts2.eu","ts2.na","ts4.na","ts4.eu","ts1.na","ts3.eu","ts3.na","ts5.eu","ts6.eu"]}
2020-07-22 07:39:04 UTC -- Updated server list
2020-07-22 07:39:04 UTC -- Received action: get stats {"action":"get stats"}
2020-07-22 07:39:04 UTC -- Stats: send initial stats.
2020-07-22 07:39:04 UTC -- Received action: get config {"action":"get config"}
2020-07-22 07:39:04 UTC -- Saved servers=ts1.eu,ts2.eu,ts2.na,ts4.na,ts4.eu,ts1.na,ts3.eu,ts3.na,ts5.eu,ts6.eu
2020-07-22 07:39:04 UTC -- Stat check: server:ts1.na blocks:764257  peers:8  bal:0.0194  isValidBal:true  queueDepth:0  lastChalBlock:764204  lastExecSec:136.26
2020-07-22 07:39:04 UTC -- Received action: statsAck {"action":"statsAck","server":"ts1.na"}
2020-07-22 07:39:04 UTC -- Stats received by ts1.na
2020-07-22 07:39:04 UTC -- Exception closed. See server for detail.
2020-07-22 07:40:59 UTC -- Stat check: server:ts1.na blocks:764258  peers:8  bal:0.0194  isValidBal:true  queueDepth:0  lastChalBlock:764204  lastExecSec:136.26
2020-07-22 07:40:59 UTC -- Received action: statsAck {"action":"statsAck","server":"ts1.na"}
2020-07-22 07:40:59 UTC -- Stats received by ts1.na
2020-07-22 07:41:43 UTC -- Disconnected from ts1.na. Retry at random intervals.
2020-07-22 07:41:51 UTC -- No connection to server ts1.na.
2020-07-22 07:42:06 UTC -- No connection to server ts1.na.
2020-07-22 07:42:21 UTC -- No connection to server ts1.na.
2020-07-22 07:42:26 UTC -- Reconnect attempts 1 43.4 seconds
2020-07-22 07:42:26 UTC -- Connected to server ts1.na. Initializing...
2020-07-22 07:42:26 UTC -- Checking t-address...
Node t_address (not for stake)=znjKdqmx6yX3ZgRWcJKDdodv76yCp47YbXT
2020-07-22 07:42:26 UTC -- Checking private z-addresses...
Balance for challenge transactions is 0.0194
Using the following address for challenges
zcHRNstoShbMuFSTPGHEvr28n3UDNJwSMgQr7SJsKEo1rPf4RoV81AvHYfu7VhRd27JVG8sf2QSbWEfJVXZCdn1ErJWfsRS
2020-07-22 07:42:28 UTC -- Authenticated. Nice to see you connected again.
2020-07-22 07:42:28 UTC -- Received action: updateServers {"action":"updateServers","servers":["ts2.na","ts4.na","ts3.eu","ts1.na","ts4.eu","ts2.eu","ts6.eu","ts3.na","ts1.eu","ts5.eu"]}
2020-07-22 07:42:28 UTC -- Updated server list
2020-07-22 07:42:28 UTC -- Received action: get stats {"action":"get stats"}
2020-07-22 07:42:28 UTC -- Stats: send initial stats.
2020-07-22 07:42:28 UTC -- Received action: get config {"action":"get config"}
2020-07-22 07:42:28 UTC -- Saved servers=ts2.na,ts4.na,ts3.eu,ts1.na,ts4.eu,ts2.eu,ts6.eu,ts3.na,ts1.eu,ts5.eu
2020-07-22 07:42:28 UTC -- Stat check: server:ts1.na blocks:764258  peers:8  bal:0.0194  isValidBal:true  queueDepth:0  lastChalBlock:764204  lastExecSec:136.26
2020-07-22 07:42:28 UTC -- Received action: statsAck {"action":"statsAck","server":"ts1.na"}
2020-07-22 07:42:28 UTC -- Stats received by ts1.na
2020-07-22 07:42:29 UTC -- Cert check:pass certvalid=true ip6Match=true  Hostname  1646-z.dyn.zenstake.io matches CN *.dyn.zenstake.io

What is wrong?

Hi.  I took a look at your nodes on the tracking server and many of them do have a very high reconnect rate. There are many with about 150 over the last 24 hours.  Some over 300.   Nodes in other domains average about 5-8 over a 24 hour period as do many of your other nodes.
I pinged the node listed from the tracking server and received a 39% packet loss.
I suspect there is some network issue either with your provider or somewhere between your systems and the tracking servers.
Another possibility is overload.  If your servers are very busy, the nodetracker may be dropping connections. The log above indicates about 40 seconds to reconnect. Is there any correlation between server load and disconnect times?
I also noticed in the log some lines that are not standard.  If you have made other modifications make sure there are no inadvertent changes to things like the connection check timer.
This does not appear to be any issue on the tracking server side.
If this continues and you need some more help, I suggest submitting a ticket at support.horizen.global.

Hm, it does not help to us.
This issue appeared several days ago. a week ago all was is god.
And it is very strange to see like this downtime situations:

Where the normal situation is:


Properly type generated proto extensions.

Sync from internal repo--by removing the unnecessary and unparameterized Extension type on the LHS of the generated extension fields, the proper type should be inferred by Dart type system.

This change was merged with #401.


Colab training

How to use:

Checkout this branch with a manual install (python environment rather than .exe)
Run an instance of the notebook: https://colab.research.google.com/drive/18Y1W7WIxSCtvo-c8sNTXYrcu4QzFOEE0?usp=sharing
Go to the training page and select 'Colab notebook'
Copy & paste the ngrok url (.ngrok.io) into the "Remote URL" field and select other fields as expected

Feature added in different branch


Problems with Android 2.3.3

There seems to be an issue with this plugin and  the Android 2.3.3 webbrowser.
From what we have learned during initial debugging, the problem seems to reside within the following code.

currentTab: function() {
		var $tabs = this.element,
		$navbtns = $tabs.find("a");
		return this.element.find('.ui-btn-active').parent().prevAll().length;
},

and will fail here:

$content.children('#' + $navbtns.eq($this.currentTab()).attr('href')).addClass('ui-tabs-content-active');

Is this still an issue with the new version?

Closing this old thing.


Move regularize to single eval

The test is failing and it's because node.items contain Datum in single eval tree while node.items contain Molecule for multi eval tree. @mjohnson541 Is there a reason why it's set up this way? I think it makes more sense to me for node.items to contain Datum.

@mjohnson541 ok I fixed the issue. This is ready for another review


Use 7zip to extract .tar.gz file as gzip+tar produced incorrect files

Codecov Report

Merging #3992 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3992   +/-   ##
=======================================
  Coverage   70.59%   70.59%
=======================================
  Files         427      427
  Lines       27521    27521
  Branches     4208     4208
=======================================
  Hits        19429    19429
  Misses       6834     6834
  Partials     1258     1258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18838f5...9f27ca1. Read the comment docs.

@yugangw-msft can you take a look at this?


Can't connect to mattermost

My work team uses mattermost and I would love to get this setup but I'm having some issues.
Starting matterircd with:
matterircd -debug -mminsecure -mmserver redacted -mmteam redacted
Then through CIRC:
/server <IP_ADDRESS>
Here I see the MOTD and verify that I'm connected to the IRC server.  Next I run:
/msg mattermost login redacted redacted
I get the following error in the irc client:
mattermost  There doesn't appear to be an api call for the url='/api/v3/users/0/50000'.  Typo? are you missing a team_id or user_id as part of the url?
Following this advice I try starting matterircd with the url with my team id appended.  It's the same URL i would use if I wanted to join my team chat through the browser.  When I try logging in here I get the error: mattermost  model.client.connecting.app_error /
Any ideas?

What is your matterircd version ?
What is your mattermost version ?

OK I missed a detail in the README.  Almost working, I connect to the server and auto join all the channels, but I don't receive any channel communication, can only transmit messages.  Will create a new issue with the version info.


add SetNamespace method for EnvSettings, in order to set namespace in helm sdk

add SetNamespace method for EnvSettings, in order to set namespace in helm sdk
Signed-off-by: yxxhero<EMAIL_ADDRESS>
What this PR does / why we need it:
fix https://github.com/helm/helm/issues/10215
Special notes for your reviewer:
add SetNamespace method for EnvSettings, in order to set namespace in helm sdk
If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

Tried change with linked issue, still does not seem to work without explicitly calling os.Setenv("HELM_NAMESPACE", "testchart"). Does this require a call to EnvSettings.SetNamespace()?
The action.Configuration.Init() call initiliazes the secrets but I don't see a namespace is set:
https://github.com/helm/helm/blob/932d2a98a2a01c069aaefb25b12c1ece1f1879d5/pkg/action/action.go#L376
To fix this issue do we need to set the namespace in "secret" case of the action.Configuration.Init(), like in the "memory"?
https://github.com/helm/helm/blob/932d2a98a2a01c069aaefb25b12c1ece1f1879d5/pkg/action/action.go#L397

@zonggen Thanks for your verification.

Why not make the namespace field public? Why do we need to introduce getters (.Namespace()) and setters (.GetNamespace())?
See the conversation in https://github.com/helm/helm/pull/10148.


mv register_schema() to impl

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #552 (681f2aa) into master (174226c) will increase coverage by 1.12%.
The diff coverage is 75.16%.

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   74.94%   76.07%   +1.12%
==========================================
  Files         146      156      +10
  Lines       24314    27055    +2741
==========================================
+ Hits        18223    20581    +2358
- Misses       6091     6474     +383

Impacted Files
Coverage Δ

ballista/rust/client/src/columnar_batch.rs
0.00% <ø> (ø)

ballista/rust/client/src/context.rs
0.00% <0.00%> (ø)

ballista/rust/core/src/client.rs
0.00% <ø> (ø)

ballista/rust/core/src/datasource.rs
0.00% <ø> (ø)

ballista/rust/core/src/error.rs
0.00% <ø> (ø)

...ta/rust/core/src/execution_plans/shuffle_reader.rs
0.00% <0.00%> (ø)

...ust/core/src/execution_plans/unresolved_shuffle.rs
50.00% <ø> (ø)

ballista/rust/core/src/memory_stream.rs
60.00% <ø> (+60.00%)
:arrow_up:

ballista/rust/core/src/serde/physical_plan/mod.rs
100.00% <ø> (ø)

...ista/rust/core/src/serde/physical_plan/to_proto.rs
49.38% <0.00%> (-1.24%)
:arrow_down:

... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174226c...681f2aa. Read the comment docs.

Thanks @wqc200 ! Can you please explain the reason for this proposed API change ?
It seems strange to me, for example, for wanting to extend the built in InformationSchema provider -- though I suspect you have a reason for wanting to do so. It would help to know what the reason was

@alamb thanks
I'm going to call the DataFusion Context from an external program, and I'm going to dynamically add a schema to the catalog in the DataFusion Context, so I need to add an API to the DataFusion Context.
To sum up, I needed the ability to call DataFusion Context from the outside.

My concern about with adding a register_schema to the trait is that that will force all catalog providers to allow new schemas to be added, even for those where it might not make sense.
I think you can dynamically add a schema to the catalog if you install / use a MemoryCatalogProvider directly and retain a handle to it. The code would look something like:
        let catalog = MemoryCatalogProvider::new();
        let catalog = Arc::new(catalog);
        // register catalog with the context, but keep an `Arc` to it for later
        ctx.register_catalog("my_catalog", catalog.clone());
        // ... stuff ...
        // Now, at some time later, add my_schema to the previously registered schema
        catalog.register_schema("my_schema", Arc::new(schema));

The key is to maintain a reference to catalog. There might be other examples in the tests too that could help

@alamb
`
pub struct Execution {
datafusion_context: ExecutionContext,
}
impl Execution {
pub fn new() -> Self {
let mut datafusion_context = ExecutionContext::with_config(
ExecutionConfig::new()
);
    Self {
        datafusion_context,
    }
}

}
impl Execution {
/// Create a new execution context for in-memory queries
pub fn try_init(&mut self) {
for (catalog_name, schema_map) in catalog_map.iter() {
let catalog = MemoryCatalogProvider::new();
let catalog = Arc::new(catalog);
self.datafusion_context.state.catalog_list.register_catalog(catalog_name.clone(), catalog);
        for (schema_name, _) in schema_map.iter() {
            if schema_name == meta_util::INFORMATION_SCHEMA_NAME {
                continue;
            }

            /// will output an error, MemoryCatalogProvider has not copy impl
            catalog.register_schema(schema_name.as_str(), schema);
        }
    }
}

pub fn register_schema_too(&mut self, catalog_name: String) {
    /// What should I do here
    let schema = Arc::new(MemorySchemaProvider::new());
    let catalog_provider = self.datafusion_context.state.catalog_list.catalog(catalog_name.as_str()).unwrap();
    catalog_provider.register_schema(schema_name.as_str(), schema);
}

}
`

@alamb
pub struct Execution {
    datafusion_context: ExecutionContext,
}

impl Execution {
    pub fn new() -> Self {
        let mut datafusion_context = ExecutionContext::with_config(
            ExecutionConfig::new()
        );

        Self {
            datafusion_context,
        }
    }
}

impl Execution {
    /// Create a new execution context for in-memory queries
    pub fn try_init(&mut self) {
        for (catalog_name, schema_map) in catalog_map.iter() {
            let catalog = MemoryCatalogProvider::new();
            let catalog = Arc::new(catalog);
            self.datafusion_context.state.catalog_list.register_catalog(catalog_name.clone(), catalog);

            for (schema_name, _) in schema_map.iter() {
                if schema_name == meta_util::INFORMATION_SCHEMA_NAME {
                    continue;
                }

                /// will output an error, MemoryCatalogProvider has not copy impl
                catalog.register_schema(schema_name.as_str(), schema);
            }
        }
    }

    pub fn register_schema_too(&mut self, catalog_name: String) {
        /// What should I do here
        let schema = Arc::new(MemorySchemaProvider::new());
        let catalog_provider = self.datafusion_context.state.catalog_list.catalog(catalog_name.as_str()).unwrap();
        catalog_provider.register_schema(schema_name.as_str(), schema);
    }
}

@wqc200  I think you need to keep the Arc to catalog. How about something like this:
 pub fn register_catalog_and_schema(&mut self) {
        for (catalog_name, schema_map) in catalog_map.iter() {
            let catalog = MemoryCatalogProvider::new();
            let catalog = Arc::new(catalog);

            // -->  make sure you keep a copy of the `catalog`, so pass in a `clone()` (of the ARC)
            self.datafusion_context.state.catalog_list.register_catalog(catalog_name.clone(), catalog.clone());

            for (schema_name, _) in schema_map.iter() {
                /// This should now be ok
                catalog.register_schema(schema_name.as_str(), schema);
            }
        }
    }

@alamb  I want to register a schema in the following function. What should I do?
    pub fn register_schema_another(&mut self, catalog_name: String) {
        /// **What should I do here**
        let schema = Arc::new(MemorySchemaProvider::new());
        let catalog_provider = self.datafusion_context.state.catalog_list.catalog(catalog_name.as_str()).unwrap();
        catalog_provider.register_schema(schema_name.as_str(), schema);
    }

@wqc200  how about something like the following (downcast the reference via as_any):
   pub fn register_schema_another(&mut self, catalog_name: String) {
        let schema = Arc::new(MemorySchemaProvider::new());
        let catalog_provider = self.datafusion_context.state.catalog_list.catalog(catalog_name.as_str()).unwrap();
        // ** try to cast catalog provider to MemoryCatalogProvider
        let catalog_provider = catalog_provider.as_any()
                .downcast_ref::<MemoryCatalogProvider>()
                .expect("Catalog provider was a MemoryCatalogProvider");
        catalog_provider.register_schema(schema_name.as_str(), schema);
    }

@alamb
Yes, that can be done.
However, this is a relatively complicated way to write, adding to the cost of learning and presenting difficulties for a Rust novice.

However, this is a relatively complicated way to write, adding to the cost of learning and presenting difficulties for a Rust novice.

Yes I agree -- perhaps we can add some examples / tests to help out new people

I think software design and development should be simple and easy to use.

Again, I agree -- there are parts of Rust that are definitely not 'obvious' in the way I have found languages like Python to be.

@Dandandan  or @returnString  do you have any thoughts on this API change -- I think getting some other perspectives might help

Hrm, I think if we're moving this to the interface, we need to codify some notion of "unsupported operation". That's actually why I left it out initially - registering a schema inside e.g. the information_schema catalog doesn't really make sense, because it's a read-only projection of DB internals, and I didn't want to commit to more public API than was necessary.
In my DataFusion-powered projects, I typically treat ExecutionContext instances as immutable which simplifies a lot of the setup. Essentially this entails creating catalogues using concrete types like MemoryCatalogProvider and then just attaching those to a new context, so I can work with the type-specific impls, rather than just trait methods. I'm not sure how widely adopted this is as a methodology, but I've found it works well!
For example, if I were building a traditional database, here's how I'd execute queries:

build the list of catalogs (and internally, schemas/tables) the user has permissions to access (this relies on out-of-band data)
create an execution context populated with said catalog list
run the query using the context
discard the context

Obviously this relies on the context setup being quite cheap, but I don't see any moves toward making that a particularly intensive process 😄

Had to remind myself how all the catalog code works, but we do support registering tables into a schema via the trait. However, the trait method has a default impl which fails:
fn register_table(
	&self,
	name: String,
	table: Arc<dyn TableProvider>,
) -> Result<Option<Arc<dyn TableProvider>>> {
	Err(DataFusionError::Execution(
		"schema provider does not support registering tables".to_owned(),
	))
}

So if we wanted to do this for registering schemas into catalogs, we should probably use the same style of fallible operation.

For example, if I were building a traditional database, here's how I'd execute queries:

In IOx we took a very similar approach to what you describe: 🤣  https://github.com/influxdata/influxdb_iox/blob/main/server/src/db/access.rs#L201


Clone buffers containing serialized GFX responses into player compartment before use

This fixes a truly bad performance fault in handling of BitmapData data.
r? @mbebenita

r+ with nits fixed.

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

src/base/dataBuffer.ts, line 155 [r1] (raw file):
FromArrayBuffer doesn't clone all of the state in the current DataBuffer. Perhaps we should call this function something else.

Comments from the review on Reviewable.io

FromArrayBuffer doesn't clone all of the state in the current DataBuffer. Perhaps we should call this function something else.

I went the other way and just made it clone all of the state.


Remove PVS-Studio comments

Ahh, hello and welcome.
I see you made an attempt at #644.

Yes, sorry this is my first time working on a project and I was having some trouble haha

On Aug 26, 2020, at 2:59 PM, Daniel Stevens<EMAIL_ADDRESS>wrote:
Ahh, hello and welcome.
I see you made an attempt at #644 https://github.com/OutpostUniverse/OPHD/issues/644.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/OutpostUniverse/OPHD/pull/675#issuecomment-681063937, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3O2EUF764MLM55EJIIF5TSCVLSNANCNFSM4QMEF62Q.

No worries. I specifically marked that one as "easy" for people to come by and try their hand at. Got to start somewhere.

Heya!
Good start? Unsure why you closed it versus continuing on to take care of the rest of the messages.
Anyway, hoping to see more contributions from you going forward!


frontend fixes

PR Title/Tagline
What does this PR change and why?
How to Test

Please add or build upon a testing card to the Notion page and link it here

Fix button in Notes Modal, Change font in Utility Partner Modal, get rid of register button

Database change / migration to run
Environment config change
Breaking API change

Related Github Issues

#[Number of Issue]
Or, remember to link to an issue on the sidebar

Related PRs

#PRNUMBER

Checklist

[ ]  Database schema docs have been updated or are not necessary
[ ]  Code follows design and style guidelines
[ ]  Code is commented with doc blocks
[ ]  Tests have been written and executed or are not necessary
[ ]  Latest code has been rebased from base branch (usually develop)
[ ]  Commits follow guidelines (concise, squashed, etc)
[ ]  Github issues have been linked in relevant commits
[ ]  Relevant reviewers (Senior Dev/EM/Designers) have been assigned to this PR

Closes #146


Broken Link in 'Build Components and Pipelines'

On this page https://www.kubeflow.org/docs/components/pipelines/sdk/build-component/
Under section "Create a container image for each component"
See the Docker file for the example XGBoost model training program mentioned above.
Docker file points to https://github.com/kubeflow/pipelines/blob/master/components/deprecated/dataproc/train/Dockerfile that returns 404

/assign difince

As I see the files in dataproc have been deleted by PR https://github.com/kubeflow/pipelines/pull/5045
@chensun, could you give me an advice how to deal with this issue in the best way


Rendering with implicit batches instead of make_batch

This actually looks pretty good, you saved 30 lines. :+1:

The common practice though is to either put "Fixes #6" in the description (or "Closes X") or in the commit message, and github will close the associated issue automatically when you merge the PR.

@kvark - right, thanks!


Lollipop battery saver move disables tile slide animations

Other animations still appear such as the tiles growing when they combine. I can either disable all animations while on low battery or reenable tile slide animations

It appears that TranslateAnimations will still animate just not ObjectAnimator. I can switch the tile animations to this.
http://developer.android.com/reference/android/view/animation/TranslateAnimation.html


Install Twistlock as a service

Hi,
could you tell me the full command to install l Twistlock as a service ? because I do not understand wget xxx.
Many thanks.

@alobaidan this approach is currently not supported; you will have to compile the code and run the install script. Thanks!


SSH Agent forwarding does not work with "terminal.integrated.inheritEnv": true

VSCode Version: 1.42.1
OS Version: Ubuntu 18.04

Steps to Reproduce:

Set "terminal.integrated.inheritEnv": true in settings
Use remote development environment to connect to a remote machine
In the remote terminal, execute cat $SSH_AUTH_SOCK
Should say something like cat: /foo/bar: No such file or directory

This means that ssh cannot contact the ssh agent. Using ssh -v  within the terminal should reveal something like
vs code debug1: pubkey_prepare: ssh_get_authentication_socket: No such file or directory
which I believe is related to the wrongly sett SSH_AUTH_SOCK.

Does this issue occur when all extensions are disabled?: Not tested.
My understanding is that inheritEnv sets the SSH_AUTH_SOCK to the path on the local machine, which of course is not available on the remote. One solution could be that SSH_AUTH_SOCK does not inherit/reset everything, but skips certain variables such as this one.

This also affects things like X11-forwarding, in which DISPLAY is wrongfully set.
I believe it was the Python extension which detected that I was running Anaconda which suggested setting "terminal.integrated.inheritEnv": true, and this subsequently caused all of these other side effects.

/duplicate https://github.com/microsoft/vscode-remote-release/issues/1835


Change from anago.reader import load_data_and_labels to from anago.data.reader import load_data_and_labels

Not sure why this issue is closed.  It is still valid and causing confusion + there are several code instances which need to be changed too.

Never mind. I was using the pip version. Closing this.
Time for update the version on pip? or a versioned Markdown doc for the users who installed from pip?


Code reorganisation and file naming

After issue #8 I though this might be a point to bring up.
How would you go about the naming of the files and distributing the code in them? I suppose the "general" stuff that applies to any array type would go into numgo.go. For the Arrayb-specific methods we have bool.go. Where would you like the Array64-specific code?
It might be clearer to just have

numgo.go: General stuff applying to any array type
array64.go: A new file that holds Array64-specific code
arrayb.go: bool.go renamed, containing Arrayb-specific code.

Just an idea, I'm open for any other suggestions

Sound good.  We could use nDim.go instead of numgo.go so users don't expect anything special in the file named the same as the package.


close pulsar client

The plug-in failed to start because the client connection was suddenly closed。
My log info：
[2022-06-02T03:13:35,400][INFO ][org.apache.pulsar.client.impl.ConnectionPool] [[id: 0x700bd97f, L:/<IP_ADDRESS>:48410 - R:pulsar-broker-2.pulsar-broker.test.svc.cluster.local/<IP_ADDRESS>:6650]] Connected to server
[2022-06-02T03:13:35,413][INFO ][org.apache.pulsar.client.impl.ProducerImpl] [persistent://public/default/alert_index] [null] Creating producer on cnx [id: 0x700bd97f, L:/<IP_ADDRESS>:48410 - R:pulsar-broker-2.pulsar-broker.test.svc.cluster.local/<IP_ADDRESS>:6650]
[2022-06-02T03:13:35,836][INFO ][org.apache.pulsar.client.impl.ProducerImpl] [persistent://public/default/alert_index] [pulsar-10-24] Created producer on cnx [id: 0x700bd97f, L:/<IP_ADDRESS>:48410 - R:pulsar-broker-2.pulsar-broker.test.svc.cluster.local/<IP_ADDRESS>:6650]
[2022-06-02T03:13:35,886][INFO ][org.apache.pulsar.logstash.outputs.Pulsar][main][7184de15b248de902ecc2f4a34dff0ad07d10e45c1e01e88f608d0a926e59a8c] Create producer pulsar-10-24 to topic persistent://public/default/alert_index , blockIfQueueFull is true,compressionType is NONE
[2022-06-02T03:13:36,010][WARN ][com.scurrilous.circe.checksum.Crc32cIntChecksum][main][7184de15b248de902ecc2f4a34dff0ad07d10e45c1e01e88f608d0a926e59a8c] Failed to load Circe JNI library. Falling back to Java based CRC32c provider
[2022-06-02T03:13:36,519][INFO ][org.apache.pulsar.client.impl.ProducerImpl] [persistent://public/default/alert_index] [pulsar-10-24] Closed Producer
[2022-06-02T03:13:36,520][INFO ][org.apache.pulsar.logstash.outputs.Pulsar][main] close producer pulsar-10-24 for topic persistent://public/default/alert_index
[2022-06-02T03:13:36,520][INFO ][org.apache.pulsar.client.impl.PulsarClientImpl][main] Client closing. URL: pulsar://pulsar-broker.test.svc.cluster.local:6650
[2022-06-02T03:13:36,532][INFO ][org.apache.pulsar.client.impl.ClientCnx] [id: 0xaf6d9341, L:/<IP_ADDRESS>:44562 ! R:pulsar-broker.test.svc.cluster.local/<IP_ADDRESS>:6650] Disconnected
[2022-06-02T03:13:36,538][INFO ][org.apache.pulsar.client.impl.ClientCnx] [id: 0x700bd97f, L:/<IP_ADDRESS>:48410 ! R:pulsar-broker-2.pulsar-broker.test.svc.cluster.local/<IP_ADDRESS>:6650] Disconnected
[2022-06-02T03:13:36,557][INFO ][org.apache.pulsar.logstash.outputs.Pulsar][main] close pulsar client
[2022-06-02T03:13:36,577][INFO ][logstash.javapipeline    ][main] Pipeline terminated {"pipeline.id"=>"main"}
[2022-06-02T03:13:36,693][INFO ][logstash.pipelinesregistry] Removed pipeline from registry successfully {:pipeline_id=>:main}
[2022-06-02T03:13:36,815][INFO ][logstash.runner          ] Logstash shut down.
Have any of you encountered this problem？

hi, @fyzn12, can you show me your logstash configuration ? so we can try analysing the reason of problem

hi, @fyzn12, can you show me your logstash configuration ? so we can try analysing the reason of problem

Thank you. I have found the cause of the problem and solved it. I did not set the schedule attribute when I used elasticsearch as input, which caused logstash to shut down once it was started

@fyzn12 thanks for your reply. This issue will be closed soon. ^.^


Can't build *adt.Vertex from same *build.Instance in multiple goroutines

What version of CUE are you using (cue version)?

$ cue version

cue version v0.0.0-20230912145313-0e9584387f3f

go version go1.21.1
      -buildmode exe
       -compiler gc
  DefaultGODEBUG panicnil=1
     CGO_ENABLED 1
          GOARCH amd64
            GOOS linux
         GOAMD64 v1
             vcs git
    vcs.revision 0e9584387f3fa0fa6b0a5c509d75c0088481df96
        vcs.time 2023-09-12T14:53:13Z
    vcs.modified true

Does this issue reproduce with the latest stable release?
Yes.
What did you do?
I execute code like from multiple goroutines:
		func(instance *build.Instance) {
			_, err := runtime.New().Build(nil, instance)
			if err != nil {
				t.Fatal(err)
			}
		}

Runnable testcase:

https://github.com/cue-lang/cue/pull/2597

What did you expect to see?
No panics.
What did you see instead?
=== RUN   TestX
panic: runtime error: index out of range [2] with length 2

goroutine 131 [running]:
cuelang.org/go/internal/core/runtime.resolveFile(0xc000782070, 0xc000133f80, 0xc0002c4b40, 0x4?)
	/home/bozaro/joom/cue/internal/core/runtime/resolve.go:157 +0xf85
cuelang.org/go/internal/core/runtime.(*Runtime).ResolveFiles(0xd469d8?, 0xc0002c4b40)
	/home/bozaro/joom/cue/internal/core/runtime/resolve.go:52 +0x1b7
cuelang.org/go/internal/core/runtime.(*Runtime).Build(0xc000780018, 0x0, 0xc0002c4b40)
	/home/bozaro/joom/cue/internal/core/runtime/build.go:69 +0x19c
cuelang.org/go/internal/core/runtime.(*Runtime).buildSpec(0xc000780018, 0x41ae6b?, 0xc0002c4960, 0xc00040c870)
	/home/bozaro/joom/cue/internal/core/runtime/build.go:150 +0x2cc
cuelang.org/go/internal/core/runtime.(*Runtime).Build.func1(0x0?)
	/home/bozaro/joom/cue/internal/core/runtime/build.go:64 +0x8a
cuelang.org/go/cue/ast.(*File).VisitImports(0xc000784150?, 0xc0000d9f10)
	/home/bozaro/joom/cue/cue/ast/ast.go:996 +0x87
cuelang.org/go/internal/core/runtime.(*Runtime).Build(0xc000780018, 0x0, 0xc0002c4960)
	/home/bozaro/joom/cue/internal/core/runtime/build.go:62 +0x16c
cuelang.org/go/internal/core/adt_test.TestX.func1(0xd44128?)
	/home/bozaro/joom/cue/internal/core/adt/eval_test.go:177 +0x1dd
created by cuelang.org/go/internal/core/adt_test.TestX in goroutine 19
	/home/bozaro/joom/cue/internal/core/adt/eval_test.go:173 +0x198

runtime.New() contains builtins index and inject builtins definitions by mutatiting *build.Instance instance on first Build execution.
This also means that, strictly speaking, *build.Instance cannot be reused with different runtime.New() object even in single goroutine mode.

These APIs are currently not safe for concurrent use - for example, see https://github.com/cue-lang/cue/issues/460 and https://github.com/cue-lang/cue/issues/1746. This is something we want to improve for sure, and in fact @rogpeppe has sent a few changes already, although right now we are prioritizing issues relating to correctness and evaluator performance.
This issue might be a duplicate of 1746, but I think it's worth keeping it open for the sake of ensuring that your reproducer is fixed as well.


Add option to run docker container as root user (fixes #57)

@turboderp would it be possible to move exllama_sessions from the home directory to the exllama directory? This makes more sense in my opinion.

I added an option to specify a different directory for storing sessions. Maybe it makes sense for docker, idk. But generally storing user data in the application directory isn't a good idea, I think. For now that directory reflects the repo, and eventually it may turn into a library and/or pip package stored somewhere in a conda environment, which is not a good place to start putting potentially sensitive information by default. I think.
Also, thinking about it I'm not really sure how the docker image running in user mode could ever take ownership of files that don't already belong to the user? I guess running in root would solve it, but idk. I'll pull the changes, just let me know if you want to add in the --sessions-dir argument so I can squash it into a single commit.

You're actually correct, storing user data in the application directory is not what I wanted to go for, just a configurable directory so I can set it to a standard path in the docker container. So --sessions-dir is a good solution.

Also, thinking about it I'm not really sure how the docker image running in user mode could ever take ownership of files that don't already belong to the user?

Sorry, I'm not sure what you mean by that. The non-root user inside the docker container is different from the user at the host, since the container runs in an isolated namespace and has its own filesystem.

Do you need to add it to the commit before I merge it?

I started a new pull request #83


split -f catalog.json -e catalog.* fails

The lower level code requires a json path with 2 or more elements and this ends up just being catalog

@fsuits I'm pretty sure we fixed this?

@butler54 this is still an issue - I'm looking at split currently.
For catalog.* I guess we want catalog.json to be stripped to contain only the uuid, and all other items are split off?


Adding support for feature omnistack_clusters throughput

Signed-off-by: KalpanaBhardwaj<EMAIL_ADDRESS>Description
Adding support for feature omnistack_clusters throughput
Issues Resolved
Defect fix for adding filters in do_get method  for PR #66
Check List

[x] New functionality includes testing.

[x] All tests pass($ tox).

[x] New functionality has been documented in the README if applicable.

[x] New functionality has been thoroughly documented in the examples (please include helpful comments).
[x] New endpoints supported are updated in the endpoints-support.md file.

[x] Changes are documented in the CHANGELOG.

@KalpanaBhardwaj, Need update in the CHANGELOG.md for the issue addressed in PR

Variable name is not matching with name passed in the method should be filters
Thanks Hemant, the suggestion commit was already in progress. Its done.

@KalpanaBhardwaj, Need update in the CHANGELOG.md for the issue addressed in PR

Its done.

@KalpanaBhardwaj, Need update in the CHANGELOG.md for the issue addressed in PR

Done.


Download SNV frequency table and lineage table filtered by location/date range

Hello,
This site is my go-to resource for identifying lineages based on mutations in wastewater, and I've been sharing it with colleagues who really appreciate it, too.  I am now looking specifically for mutations common in California within a date range (for example to check my primers against the prevalent sequences or to know what SNVs I might expect to find in specific wastewater samples).
There are two tables I'm interested in being able to download:

A table of the data shown in the second bar from the left on the locations page (says "AA SNVs" or "NT SNVs" on the top, depending on the applied filters) - see screenshot below.
A filtered version of the full lineage table obtained by clicking "download" > "consensus mutation". Here, the applied filters do not appear to have any effect- perhaps should be a separate issue.

Thanks in advance,
Rose

Hi Rose,

A table of the data shown in the second bar from the left on the locations page (says "AA SNVs" or "NT SNVs" on the top, depending on the applied filters) - see screenshot below.

To get the data for the legend, you can select "Download Aggregate Data" (see picture below)

This results in a CSV file, where each unique combination of mutations is aggregated to a row. The mutations are in the form pos|ref|alt, and are delimited by semicolons. To get the frequencies of single mutations, you'll have to pull apart that mutation string and count each mutation as you go through the rows

I understand this is a bit of work, so I'll make a download item that splits this up and collapses by date like you requested.

A filtered version of the full lineage table obtained by clicking "download" > "consensus mutation". Here, the applied filters do not appear to have any effect- perhaps should be a separate issue.

You're correct - the consensus mutations are calculated across the entire dataset and are not computed based on the user's selections.
I can add a checkbox into the "download" -> "consensus mutation" dialog that specifies whether to use the whole dataset or just the sequences from the user selection.
We're currently working on a refactor of some of the core components of the site – so these changes can't be implemented immediately... maybe a week or two? I'll let you know when it's live.
Albert


Added SchemaFirst test with resolver

Summary of the changes (Less than 80 chars)

Detail 1 - added schema first test equal code what is in DOCS
Detail 2 - added snapshot

Addresses #bugnumber (in this specific format)
Related to Docs update..
https://github.com/ChilliCream/hotchocolate-docs/pull/112
https://github.com/ChilliCream/hotchocolate-docs/pull/113

/AzurePipelines run

@damikun thanks for you contribution!


Remove superfluous const parameters from function declarations

Discussed in https://github.com/GraphicsProgramming/learnd3d11/discussions/106

Originally posted by JuanDiegoMontoya March 29, 2022
For non-reference, non-pointer function prototype parameters, const is superfluous and has no effect. It only serves to clutter the API and does not provide any guarantee to the caller. See this SO answer for more info.
Suggestion: remove const from non-reference, non-pointer-like parameters in function declarations, and keep them in function definitions to maintain const-correctness where it matters, for example:
class DearImGuiApplication final : public Application
{
public:
    ...
    void OnResize(
        int32_t width,
        int32_t height) override;
    ...
};

void DearImGuiApplication::OnResize(
    const int32_t width,
    const int32_t height)
{
    ...
}

#74 is mentioned in the discussion, ignore it for this issue and treat it as another PR


admin/unadmin not work

simply the command admin  or admin  not working, and also the unadmin. simply the console doesn't tell anything

removed rocket, admin/unadmin working.
(If can help the server has webpermission activated)

Does this answer your question? https://github.com/RocketFoundation/Rocket.Unturned/blob/master/Commands/CommandAdmin.cs

Oh, but now the question is how to admin or unadmin people when webpermission are activated?

Why do you think its deactivated

if (!R.Settings.Instance.WebPermissions.Enabled)

if the webpermission is activate it doesn't admin people, right?
On webpermission file you can't set server admin, right?
With webpermission enabled you can't admin people from console, right?
??

Yep.

So, how can i admin someone with webperm on?

Not at all, Webpermissions makes it easy to manage multiple servers with permissions, for sake of security tho /admin is disabled, so changes in the webpermissions directly reflect onto the game servers. Imagine one of your mods making himself admin, then getting kicked out of staff - he'd still be admin everywhere.