How to load models?

Hello!
It's so exciting to discover this library, thank everyone for the effort!
It might be a dummy question, but -  could you please tell how load models? SmartPedal has the dropdown interface option, what about amp?
Thank you!

Glad to hear you are excited about it, and not a dumb question at all.  The amp is intended to be more like a traditional guitar plugin, with no extra setup other than the VST, so the models are packed into the executable when compiling.  Here are the steps to change out the models:

Open up the project in Projucer and add your json models as a Resource. Right click "Resources", add existing files, and make sure to check "Binary Resource".

Open the Visual Studio solution (or other target IDE). You should see the new .json model files under "Resources" in the solution explorer.

Open PluginProcessor.cpp and edit lines 208 or 219 (this determines which model is used on the Lead or Clean channel):
(208)  WaveNetLoader loader2(BinaryData::bluej_fullD_p0153_json);    -->
WaveNetLoader loader2(BinaryData::YOUR_NEW_LEAD_MODEL_json);
 (219)  WaveNetLoader loader2(BinaryData::bluej_clean_p0088_json);   -->
                     WaveNetLoader loader2(BinaryData::YOUR_NEW_CLEAN_MODEL_json);

Where "YOUR_NEW...MODEL" is just the filename of your json file. You can edit either one, or both, but keep in mind they are separately trained models.

Build SmartAmp in Release mode.

If you have any issues let me know, but that should do it.  If you have new models that you don't mind sharing I'd love to add them to the repo!

Hi Keith, thanks for the quick feedback and detailed instruction, it's helpful,
I wanted to experiment and upload the available SmartPedal and WaveNet model into Amp capabilities.
As far as I understand, the new model creation requires 2 audio samples - from clean in and effect out.
What about this? I'm dreaming about the super feature - upload one file (e.g. extracted solo stem, converted to FT32 .wav) and get .json with the particular tone. Then use it in the SmartAmp to be able to control EQ and other parameters,
Please share your thoughts!

I've thought some about that, it might be possible but it would be a very difficult problem to solve. The first part would be extracting a single guitar from the song.  Say you wanted to extract Led Zeppelin's Stairway to Heaven solo guitar; there are lot's of layers in the same frequency range.  I've seen a few different source separation software out there, but none that extract a guitar track yet.
If this could be done, there would then be the question of how to get a clean track.  For the WaveNet technology, it needs a source signal to apply the "filter" of the WaveNet model over.  Maybe through some method of machine learning you could generate a clean track based on the target track.
The next problem to tackle is that the WaveNet model is limited by the specific impulse it can handle (I think the paper states somewhere around 50ms). This can be extended at the cost of processing power.  So it can handle distortion pedals and tube amps well, because what you play takes less than 50ms to run through the circuit. Things like reverb and delay extend out longer in time from the initial note, so you'd need a different kind of capture technology for that part of the signal.
The short answer is, I think it's possible and somebody will figure it out in the near future, but going from this code to that idea is a big leap. Glad you brought it up though!

Hi Keith,
Sharing my draft model - it's just fo the testing. Not real amp or pedal yet, it's only a clean guitar recorded and applied amp plugin. I've got very good results using https://github.com/keyth72/PedalNetRT,
Uploaded the custom model in the SmartGuitarAmp and hear something unexpected, like noise, delays, scratches and hyper distortion. The same result with WaveNetVA. Both works fine on the out-the-box models. I've probably built a plugins wrong (Xcode, release, eigen), could you please try the model on your configuration?
My gear and flow:

macOS 10.15.7 (19H2)
iRig HD2 (24/192 sound card)
Ableton 10 lite
Saved input files as wav, 32, mono with normalization.
converted_model.json.zip

Thank you!!

Update: seems the question is related to the model conversion: https://github.com/keyth72/PedalNetRT/issues/2,
thank you

Issue resolved by reducing model size, closing


Bump framework version

$subject

We can skip the PR builder since this is only a addition of a constant


chore: added a note about .dockerignore

Hey, I just made a Pull Request!

added a reference for .dockerignore to avoid some build problems

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

Noice!
I'm confused about the checks though - Why is Vale check being categorized under the TechDocs Project board workflow. 🤔
They are separate workflows.

Noice!
I'm confused about the checks though - Why is Vale check being categorized under the TechDocs Project board workflow. 🤔
They are separate workflows.


download aurora database snapshot failed

I want to deploy aurora for parsing  aurora data fast just like ethereum.
When run ./setup.sh, log shows curl: (22) The requested URL returned error: 404.
The reason is  https://snapshots.deploy.aurora.dev/snapshots/mainnet-latest and  https://snapshots.deploy.aurora.dev/158c1b69348fda67682197791/ are invalid.

same issue, expecting answer@JonathanLogan @acoshift

same issue, expecting answer@JonathanLogan @acoshift
Downloading genesis file.
Uncompressing genesis file.
Downloading database snapshot
Fetching... this can take some time...
curl: (22) The requested URL returned error: 404 Not Found
Fetching... this can take some time...
curl: (22) The requested URL returned error: 404 Not Found
Fetching... this can take some time...
curl: (22) The requested URL returned error: 404 Not Found
Fetching... this can take some time...
curl: (22) The requested URL returned error: 404 Not Found

This is because ssl cert expired for
https://snapshots.deploy.aurora.dev
It has hsts so there is no way to access the snapshot unless there is alternative mirror or they renew the cert.
Hoping this gets resolved asap

is this resolved yet guys?

not yet

Think they resolved the https issue.
The script saves a hidden file in the folder to dertermine the latest.
In your partner-relayer-deploy folder you need to rm .latest to remove the latest config file
an easier alternative is to remove the whole partner-relayer-deploy folder and clone again.
after that running setup.sh will work.


agda-categories: Unbreak the build (trivial hash change)

Apparently, v0.1.4 was released twice. The current version of the build points to the first edition of v0.1.4, which is no longer attached to the tag "v0.1.4" on GitHub. Hence currently, downloading fails. This commit adjusts the hash to appropriately refer to the second edition of v0.1.4.
I could not test this fix for lack of memory.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 102334 run on x86_64-darwin 1

1 package built:

agdaPackages.agda-categories

Result of nixpkgs-review pr 102334 run on x86_64-linux 1

1 package failed to build:

agdaPackages.agda-categories

Thank you for the quick review, @alexarice! I obtained the correct hash using:
nix-prefetch-git https://github.com/agda/agda-categories v0.1.4

This command should not use any cache.
To others following along: The failures reported by @SuperSandro2000 are spurious, probably because compilation failed because there was not enough memory. As @alexarice confirmed that it works, I believe this is good for merge!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/280


[Bug] Inconsistency in handling v24 PICS XMLs in PICS TOOL 2.0

Describe the bug
Online PICS Tool 2.0 does not seem to process the XML files v24 correctly. Number of test cases and description does not seem consistent with PICS 1.6.15 Matter 1.2 Fall release 2023 (rev 24).
Please see the results using the same set of PICS v24 on both PICS tool releases

Steps to reproduce the behavior

Open PICS tool v2.0
Upload PICS files v24 (Matter 1.2)

Expected behavior
Correct files are processed and list of applicable test cases is generated
Log files
No response
PICS file
No response
Screenshots
No response
Environment
No response
Additional Information
No response

Deprioritized.


M04-Unit 4 - Change Bastion Subnet to /26 from /24

Module: M04
Lab: Unit 4 Create and configure an Azure load balancer
Task: 01
Step: 12
Description of issue
The UI for creating a VNET switches randomly currently between a "new" and "old" approach, which is causing confusion in some labs. In this one, the "new" UI doesn't allow you to configure the CIDR block to be /24, it will default to /26. One could change this in the subnet configuration, but I like the fact that it doesn't default to /24 because this would be unnecessary big. I'd like to suggest changing the instructions to use /26 for Bastion and that way both UI users have at least the same outcome.
Relevant screenshots

[like]  Elias Estevao reacted to your message:

From: Marco Estrada @.>
Sent: Tuesday, October 10, 2023 2:18:03 PM
To: MicrosoftLearning/AZ-700-Designing-and-Implementing-Microsoft-Azure-Networking-Solutions @.>
Cc: Subscribed @.***>
Subject: Re: [MicrosoftLearning/AZ-700-Designing-and-Implementing-Microsoft-Azure-Networking-Solutions] M04-Unit 4 - Change Bastion Subnet to /26 from /24 (Issue #223)
The new UI is now the constant, so please update the instructions to create the Bastion host.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/AZ-700-Designing-and-Implementing-Microsoft-Azure-Networking-Solutions/issues/223#issuecomment-1755521418, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6Y5CWCT3B46Y4637HDDKL3X6VKJXAVCNFSM6AAAAAA3LRZBJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJVGUZDCNBRHA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

This has been fixed. Thank you.

[heart]         Elias Estevao reacted to your message:

From: Jill Leary @.>
Sent: Tuesday, October 24, 2023 8:44:45 PM
To: MicrosoftLearning/AZ-700-Designing-and-Implementing-Microsoft-Azure-Networking-Solutions @.>
Cc: Elias Estevao @.>; Comment @.>
Subject: Re: [MicrosoftLearning/AZ-700-Designing-and-Implementing-Microsoft-Azure-Networking-Solutions] M04-Unit 4 - Change Bastion Subnet to /26 from /24 (Issue #223)
This has been fixed. Thank you.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/AZ-700-Designing-and-Implementing-Microsoft-Azure-Networking-Solutions/issues/223#issuecomment-1778008378, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6Y5CWDMTVKYGHQH26BRGMTYBASD3AVCNFSM6AAAAAA3LRZBJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZYGAYDQMZXHA.
You are receiving this because you commented.Message ID: @.***>


tabset and Angucomplete conflict

Using angucomplete from:
https://github.com/darylrowland/angucomplete
Or angucomplete-alt from:
https://github.com/ghiden/angucomplete-alt
Both seemingly result in a "conflict" as selectedobject/selected-object remains undefined even after being selected. Upon removing the angucomplete directive from the tabset interior, selected-object became defined.
Edit:
Also noticed that trying to use something like

 input type="text" ng-model="blah"

Also remains undefined for blah. Set a $scope.$watch on blah as well to no avail.

Can you show a reproduction via Plunker? Taking a quick look at the angucomplete code, I notice no usage of ng-model though, which looks suspicious on first glance.
Also, is there any reason why typeahead wouldn't satisfy your needs?

Closing due to insufficient information - feel free to provide more information if this is a UI Bootstrap issue in particular.


FancyZones: Request: include initial position&size when using Win+Arrow

It would be nice to not only have the defined zones in the "loop" when using keys "Win+arrow" to switch into zones but also include the initial window size & position (only until the window is not in a zone). So this would enable you to go to the zones but if nothing fits you can just go back to the original state.

Hi @tunsdruff
can you please add your suggestion to https://github.com/microsoft/PowerToys/issues/166 so we keep all the ideas/suggestions about restoring the original position in one place?
I'll close this one as duplicate.
Thanks.


Remove uses of deprecated classes in javax.security.cert

Efforts are underway in the OpenJDK project to remove the long deprecated-for-removal classes in the package javax.security.cert. These classes were introduced for backwards compatibility concerns with the unbundled JSSE release for JDK 1.2/1.3, but their use have been discouraged since they were introduced.
It would be good to update Tomcat to not depend on / use these archaic APIs.
See https://bugs.openjdk.org/browse/JDK-8227024 and the corresponding CSR https://bugs.openjdk.org/browse/JDK-8227395

Thanks for the PR.
Note for reviewers: There is a default method in Java 17 (but not Java 11) so this change is safe in Tomcat 11 but can't be back-ported to earlier versions.


Add note on CommandResults readable_output arg

Status
Ready
Related Issues
N/A
Description
Small change: added a note in the row of the CommandResults table for the readable_output arg to specify how to create a War Room entry only, and not write any data to context, because I had a client ask about this. Feel free to rephrase or move the note to a different part of the page, as you see fit.
Screenshots
N/A

what is the status here?


Direct reverse proxying with Traefik without Nginx for Ketcher deployment

Background
Hello,
I have successfully deployed Ketcher using an Internet-Traefik-Nginx-Indigo stack with the following configuration:
services:
  nginx:
    image: nginx:1.25.0-alpine
    container_name: nginx
    restart: always
    volumes:
      - ~/ketcher/nginx/conf.d:/etc/nginx/conf.d:ro
      - ~/ketcher/remote:/srv/www:ro
    labels:
      - traefik.enable=true
      - traefik.http.routers.ketcher.entryPoints=websecure
      - traefik.http.routers.ketcher.rule=Host(`chem.domian.com`)
      - traefik.http.routers.ketcher.service=ketcher
      - traefik.http.services.ketcher.loadbalancer.server.port=80
    networks:
      - traefik

  indigo:
    image: epmlsop/indigo_service
    container_name: indigo
    restart: always
    environment:
      - PYTHONPATH=${INDIGO_SERVICE_PYTHONPATH:-/srv/indigo-python}
      - INDIGO_UWSGI_RUN_PARAMETERS=--plugin python3 --py-autoreload=1
      - PYTHONDONTWRITEBYTECODE=1
    ports:
      - 8002:8002
    command: supervisord -n
    networks:
      - traefik

networks:
  traefik:
    external: true

server {
  listen 80;
  keepalive_timeout 5;

  location / {
    root /srv/www;
    index index.html;
    try_files $uri $uri/ @indigoservice;
  }

  location @indigoservice {

    add_header 'Access-Control-Allow-Origin' '*' always;
    add_header 'Access-Control-Allow-Methods' 'POST, GET, PUT, DELETE, OPTIONS' always;
    add_header 'Access-Control-Allow-Headers' 'Accept, Content-Type' always;
    add_header 'Access-Control-Max-Age' '86400' always;
    include uwsgi_params;
    uwsgi_pass indigo:8002;
  }
}

Solution
This setup allows me to directly access Ketcher via chem.domian.com. However, I am wondering if there is a way to eliminate Nginx from this stack and use Traefik as the direct reverse proxy instead.
Any guidance or suggestions on how this might be possible would be greatly appreciated. Thank you for your time and assistance.

I just notice the name of the docker image I used above is epmlsop/indigo_service:latest which was created 5 years ago.
curl -X GET 'http://localhost:8080/v2/indigo/info'
{
  "Indigo": {
    "version": "1.3.0beta.r355-g4846731c linux64"
  }
}

The latest image name of indigo service is epmlsop/indigo-service:latest and the lastest official release version is epmlsop/indigo-service:1.10.0
Below is my update configuration:
services:
  nginx:
    image: nginx:1.25.0-alpine
    container_name: nginx
    restart: always
    volumes:
      - ~/ketcher/nginx/conf.d:/etc/nginx/conf.d:ro
      - ~/ketcher/remote:/srv/www:ro       # you should download latest ketcher-remote-2.9.0.zip and unzip into ~/ketcher/remote
    labels:
      - traefik.enable=true
      - traefik.http.routers.ketcher.entryPoints=websecure
      - traefik.http.routers.ketcher.rule=Host(`chem.domain.com`)
      - traefik.http.routers.ketcher.service=ketcher
      - traefik.http.services.ketcher.loadbalancer.server.port=80
    networks:
      - traefik

  indigo:
    image: epmlsop/indigo-service:latest   # or you can use: image: epmlsop/indigo-service:1.10.0
    container_name: indigo
    restart: always
    networks:
      - traefik

networks:
  traefik:
    external: true

server {
  listen 80;
  keepalive_timeout 5;

  location / {
    root /srv/www;
    index index.html;
    try_files $uri $uri/ @indigoservice;
  }

  location @indigoservice {

    add_header 'Access-Control-Allow-Origin' '*' always;
    add_header 'Access-Control-Allow-Methods' 'POST, GET, PUT, DELETE, OPTIONS' always;
    add_header 'Access-Control-Allow-Headers' 'Accept, Content-Type' always;
    add_header 'Access-Control-Max-Age' '86400' always;
    proxy_pass http://indigo:80;
  }
}


implement RestrictedExpression::new_entity_uid() (or similar)

Category
User level API changes
Describe the feature you'd like to request
I want to be able to "manually" create entities which refer to other entities
my use case:
I have two entities defined in my policy schema file
        "entityTypes": {
            "Client": {
                "shape": {
                    "type" : "Record",
                    "attributes" : {
                        "id": { "type": "String" }
                    }
                }
            },
            "User": {
                "memberOfTypes": ["Role"],
                "shape": {
                    "type" : "Record",
                    "attributes" : {
                        "id": { "type": "String" },
                        "client": { "type": "Entity", "name": "Client" }
                    }
                }
            },

then I create user entity like this
        let attrs = HashMap::from_iter([
            (
                "id".to_string(),
                RestrictedExpression::new_string(self.id.to_string()),
            ),
            // FIXME: we are building a `record` here while the type of
            // "client" here is really `Entity`. This seems to work but
            // need to confirm further on `cedar` slack
            (
                "client".to_string(),
                RestrictedExpression::new_record([(
                    "id".to_string(),
                    RestrictedExpression::new_string(self.client.id.to_string()),
                )]),
            ),
        ]);

        let user_entity = Entity::new(uid, attrs, parents);

note that I use new_record method to create an entity (and it works!)
Describe alternatives you've considered
an alternative with using new_record (which probably shouldn't work) is described above
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

(Sorry for the delayed response.) Thanks for the suggestion, we agree that would be useful! We've added it to our backlog for now, but we also marked it as "good first issue" since this is a small API change that we would love a PR for 😉


Only show tooltip on :focus-visible, not :focus

Closes https://github.com/github/primer/issues/2926

Part of https://github.com/primer/react/pull/4224 now


Can #8592 be reopened?

& is escaped by json.Marshal.
  I was dealing with a title, "Pump & Hand", when I came across this issue.
Alternatively, json.Encoder isn't equivalent since it appends \n.
buffer := &bytes.Buffer{}
encoder := json.NewEncoder(buffer)
encoder.SetEscapeHTML(false)
err = encoder.Encode(canon)
b = bytes.TrimRight(buffer.Bytes(), "\n")

If encoder had: newline bool for new lines, as bradfitz suggested for html escaping on the original issue #8592, that would be a step forward.

Ah yes, @89z has the same problem.  mvdan's comment appears to be the conclusion.  Thank you.


Enable Sanitizer in Debug Build and Unit Tests

Brief feature description
Add the following compiler flags for the Linux (and MacOS build, if possible)
-fsanitize=address -fsanitze=undefined. All unit tests have to run without undefined behavior, memory leaks or other funky memory effects.
Detailed information
We can a avoid a wide variety of bugs when this is activated in the github CI.

Is this setting required only for CI build ?

Yeah, I would recommend to use the settings only for the CI.
@elfenpiff Opinions?

Don't forget you also need to scan the output for the different types of errors that asan and ubsan output. UBSan usually uses the normal gcc/clang warning format but saying "runtime error" instead of "warning" or "error.
ASan output looks a bit more like valgrind. You have the LeakSanitizer and AddressSanitizer failures to scan for.

I would also suggest activating some additional ubsan flags:
-fsanitize=float-divide-by-zero:
Detect division by zero on floats. I would expect this to never happen on a safety critical project.


Create a backends folder for winit and baseview

I moved the winit and baseview crates into a backends folder to make the intent clearer and also group our backends nicely. This may also come in handy if we decide to add more or different backends to vizia.

Closing this out in favor of #171.


new styles

Description
This PR implements an initial restyling of the GUI. All changes here should be purely aesthetic. Any change in functionality is unintended -- this should be validated and corrected if needed.

Notes

There should no longer be any hard-coded colors in the code base. Rather, everything is specified by a 7-color palette. Most of that happens inside of components/_viewer/view/main.py, where a simple templating scheme is used to replace named colors in the qss with rgb values.
There are three other places in the code base where we import and use the palette as well, due to needing to style elements that I could not figure out how to style using the same global qss

components/_window/view.py
components/_layers_list/view/list.py
util/range_slider.py
Perhaps in a future PR we can figure out how to consolidate even future -- ideally we would only invoke the palette in one place!

There are two color palettes included in this PR -- light and dark -- and more can be added over time! See screenshots above.
I replaced all the icons and upgraded them to vectors. There is now a folder resources/icons/svg with a base vector version for each icon, and then a copy of each icon generated to match our templates inside resources/icons/light and resources/icons/dark. A script in util/icons.py  pragmatically generates icons with the appropriate colors based on our color themes, and can be invoked using python -m napari.util.icons. I moved the existing cursor icons into resources/icons/cursor but otherwise didn't touch them.
This is currently untested on Windows and Linux. It may look terrible! We should discuss whether to fix that before merging.

Some remaining issues

[ ] The splitter handle is barely visible in dark mode and I was unsuccessful at styling it, could keep trying, but we have also discussed eliminating it in favor of an explicit button
[ ] The spacing between the front/back and delete push buttons is inconsistent with the other buttons in the shape layer
[ ] There is a weird offset in the title for the labels layer due to the existence of a push button within the properties tab which somehow messes with the overall sizing (possibly similar to the above issue)

Type of change

[x] New feature (non-breaking change which adds functionality)

References

I based my icons off a free icon sample set called Nova (either using directly or modifying)
Thanks to @sofroniewn @kne42 @mathisonian for design help and guidance!

How has this been tested?

[x] All tests pass with my change (I think!)

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas

Hello @freeman-lab! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file napari/components/_viewer/view/main.py:

Line 60:80: E501 line too long (81 > 79 characters)

In the file napari/components/_window/view.py:

Line 33:80: E501 line too long (82 > 79 characters)
Line 33:83: W291 trailing whitespace
Line 34:13: E128 continuation line under-indented for visual indent
Line 39:69: W291 trailing whitespace
Line 40:13: E128 continuation line under-indented for visual indent

In the file napari/layers/_base_layer/view/properties.py:

Line 40:65: W291 trailing whitespace

In the file napari/layers/_labels_layer/view/controls.py:

Line 30:1: W293 blank line contains whitespace

In the file napari/util/icons.py:

Line 1:64: W291 trailing whitespace
Line 49:9: E231 missing whitespace after ','
Line 60:80: E501 line too long (80 > 79 characters)
Line 64:80: E501 line too long (83 > 79 characters)
Line 66:28: W292 no newline at end of file

In the file napari/util/range_slider.py:

Line 235:80: E501 line too long (84 > 79 characters)
Line 237:80: E501 line too long (86 > 79 characters)

In the file napari/util/theme.py:

Line 24:1: E302 expected 2 blank lines, found 1
Line 25:10: E231 missing whitespace after ','
Line 27:16: W292 no newline at end of file

Amazing @freeman-lab - are these the icons you used https://www.webalys.com/nova/free-icons.html
Good to have a link in the PR so we can find them again

It looks amazing - just playing with the dark pallette now.
There's an issue with the focus policies, where you need two clicks to change a button now instead of just one if the container widget isn't already in focus. I.e. select a markers layer, then click on one of the markers buttons that isn't selected (say either zoom, or create new marker). The first click will pull focus to that whole column, and the second click will change the button. Would be nicer if it was just one click. I'd say this can come in a follow-up PR if needed though

I also have two top-bars on my screen - see where it says napari

I say we can ignore this though for now too and then in a follow-up PR completely replace the top bar with out own custom one that has the correct stylings / drag functionality and an editable name

@freeman-lab can you provide a little more detail around the procedure for adding new icons (i.e. you place icon in a certain folder, then you run your custom script, then you run pyrcc5 resources.qrc -o resources_rc.py ?) If we move to qtpy as described in #235 then you'll also need to change the import in the qt.py file to be from qtpy and not PyQt5

:heart_eyes:
A few comments about the app (not the code):

as cool as it looks, I think using an allcaps font for the layer name is a mistake. People will definitely want to pick mixed-case layer names and we should not obscure that info
it's also a pretty interesting choice from someone so allergic to capitalization. :joy:
shuffle colors is now an untickable tickbox instead of a button. That's weird.
In the contrast (clim) sliders, I'm not a fan of the interval being the exact same color as the slider handles. I think that should be a different color.
the rightmost margin is too big. Actually I think we have way too much margin space all over and we should basically stretch the viewport all the way from the title bar to the status bar (or the sliders, depending on the dimension), and then work from there. With regards to the buttons, there is a UX principle that as far as I know has not fallen out of favor, which is that buttons should be big and have minimal to no margin between them (as this is essentially wasted space for targeting). I guess you want margins when one of the buttons is "delete all my data" =P, but for the tool bar they really should be maximally big.
the shapes icon has an impossible (from our current functionality, at least) shape, so maybe use a simple closed polygon. ;)
The "new label layer" icon seems to me like a new image layer icon. I suggest a little label tag, like this one. (But not that one. The edges don't ever line up, which blows my mind!)

With regards to how we theme, I disagree with @sofroniewn that we should pass theme= as a kwarg to the viewer app. This is a setting that I think should be OS-wide, and it should be settable via a suitable config file in ~/.config/napari (or equivalent OS-appropriate directory) and it should affect all viewers equally. We can provide a function, napari.set_theme, for convenience. The values should be light, dark, and os to get the setting from the OS. I get @freeman-lab's point that we should use dark by default, and am ok with that, but I can imagine many users wanting it to follow their OS's setting.
I do agree with @sofroniewn that whatever we do, an example on how to switch themes would be very nice. =)
btw I can confirm that the theming works fine in Ubuntu 18.04. =)
As someone who has struggled with retina/hi-DPI display config in Linux, a global scaling setting for font and icon sizes would be very much appreciated! Firefox has this and it is super nice. (GNOME still only supports integer scaling!!!)

Thanks both! Replies:
@sofroniewn

I can definitely add a few sentences on how to bundle and build the icons, where should that go?  CONTRIBUTING.md?
The two title bars is super weird! I'd love to play with it on your machine for a bit to see if we can't quickly track that down.
I don't totally understand the focus issue (or how this PR would have changed it!), can we go over that one in person?

@jni

Removed the forced uppercase =p For the record, I like all lowercase, or where visually appealing, I also like a mix of all lowercase and all uppercase. But here, I agree, give people freedom.

Improved the shape icon and used your suggested label icon (with lined up edges, of course). Nice idea! Here they are:

For margins, I spent a fair bit of time playing with it, hear your concerns, but have some justifications :) Right margin is slightly bigger to give space for the scroll bar, left and right have more space than I'd like visually to give room for the splitter handles, and then top is set to match the others. In fact, with left and right panels collapsed, the spacing is equal and pretty minimal on all sides. I'd say, if/when we get rid of the splitters, we revisit tightening the margins up?

I disagree about making the slider interval color different, I really like how it looks! Maybe we can put this one to a vote :)

The shuffle colors "tickbox" should have been clickable (just small), but here are a couple options with the the larger more proper button, preference?

@sofroniewn and @jni

I agree with @jni's approach to applying themes via some kind of global configuration, eventually accessible via a "settings" panel. That's what I had in mind, but I didn't want to introduce the  config concept in this PR :) Want me to try and at least add a napari.set_theme as part of this change? It'll actually be a bit complex, cause changing the theme requires reapplying stylesheets and adjusting properties on a few objects... surely doable!

@freeman-lab let's hold off on the napari.set_theme - that can come later.
I'd leave the slider interval color to be the same for now.
For shuffle colors - could have shuffle colors: ["shuffle"] as text then button

Ok made a few more changes

Added notes on building icons to CONTRIBUTING.md
Converged (hopefully) on a style for the shuffle button (used @sofroniewn 's suggestion)

LGTM!

i also vote for the lighter interval slider fill since it makes it more apparent that the circles at the end are full circles, independent of the fill, and can be grabbed!

I think @kne42 clearly articulated what I couldn't quite put my finger on with the single-color style: it makes the handles and slider seem like one solid object, which does not invite one to grab the ends and move them.

@jni so interesting how we see this so differently! To me the different colors makes it seem like the handles can be disconnected from the selected interval.
Anyway, didn't want to steamroll this one, we were just eager to merge this prior to finishing the dims refactor, happy to open another PR or Issue to discuss further :)


Weather web app using java with frontend

Describe the project you want to add with tech stack

To make this  project i have used html, css, js and java.
Expected behavior

user can input a city name and he/she will get some information of weather as shown in snapshot
Screenshots (optional)

Assign this issue to me so i can make a pr..... From GSSoC'23

Project already present

hey @pranjay-poddar, in this project I have used java for processing weather API and I have used maven build tool.
I have checked that in java projects folder we don't have weather web app so I think we can add this in java projects.


Failed refactors (due to rope errors) leave zombie processes

Environment data

VS Code version: 1.25.1
Extension version (available under the Extensions sidebar): 2018.7.1
OS and version: Ubuntu 16.04
Python version (& distribution if applicable, e.g. Anaconda): Anaconda 3.6.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Relevant/affected Python packages and their versions: rope managed by conda, version 0.10.7

Actual behavior
When refactors fail due to rope errors (as has been documented in other issues), the process of a Python call to refactor.py does not exit.
Expected  behavior
Failed refactors should have the process exit nicely.
Steps to reproduce:

I used this case, based on someone else's issue reporting refactoring failing:

class MyClass():
    def __init__(self, A):
        self.A = A

    def bb(self, b):
        self.b = b
        pass

    def CC(self):
        pass

Trying to refactor-rename b in self.b fails (stacktrace seen in the output log below).
Check code --status in the terminal and see that the refactoring process calls did not exit: (PIDs 4077 and 4078)

matt@Rocko:~$ code --status

Version:          Code 1.25.1 (1dfc5e557209371715f655691b1235b6b26a06be, 2018-07-11T15:40:20.190Z)
OS Version:       Linux x64 4.4.0-131-generic
CPUs:             Intel(R) Core(TM) i7-4700MQ CPU @ 2.40GHz (8 x 2398)
Memory (System):  7.68GB (0.36GB free)
Load (avg):       1, 1, 1
VM:               0%
Screen Reader:    no
Process Argv:     /usr/share/code/code --unity-launch
GPU Status:       2d_canvas:                    enabled
                  flash_3d:                     enabled
                  flash_stage3d:                enabled
                  flash_stage3d_baseline:       enabled
                  gpu_compositing:              enabled
                  multiple_raster_threads:      enabled_on
                  native_gpu_memory_buffers:    disabled_software
                  rasterization:                disabled_software
                  video_decode:                 unavailable_software
                  video_encode:                 enabled
                  vpx_decode:                   unavailable_software
                  webgl:                        enabled
                  webgl2:                       enabled

CPU %	Mem MB	   PID	Process
    0	   110	  3739	code main
    0	    24	  3741	   zygote
    0	   244	  3787	     window (refactor.py - test - Visual Studio Code)
    0	   173	  3863	       extensionHost
    0	    71	  3959	         electron_node server.js
    0	    16	  4015	         /home/matt/anaconda3/envs/learn/bin/python completion.py
    0	    16	  4036	           /usr/bin/python3.5 /home/matt/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/jedi/evaluate/compiled/subprocess/__main__.py /home/matt/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles
    0	    16	  4077	         /home/matt/anaconda3/envs/learn/bin/python refactor.py /home/matt/Code/test
    0	    16	  4078	         /home/matt/anaconda3/envs/learn/bin/python refactor.py /home/matt/Code/test
    0	    55	  3866	       watcherService
    0	    47	  3931	       searchService
    0	   110	  3898	     shared-process
    0	   205	  4124	     shared-process
    0	    94	  3774	   gpu-process

Workspace Stats:
|  Window (refactor.py - test - Visual Studio Code)
|    Folder (test): 126 files
|      File types: txt(111) py(4) properties(2) properties~(2) xml~(1) xml(1)
|                  pyc(1) md(1)
|      Conf files:

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
Starting Jedi Python language engine.
##########Linting Output - pylint##########

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

Refactor failed. expected string or bytes-like object
[<FrameSummary file refactor.py, line 294 in watch>, <FrameSummary file refactor.py, line 275 in _process_request>, <FrameSummary file refactor.py, line 206 in _rename>, <FrameSummary file refactor.py, line 117 in refactor>, <FrameSummary file refactor.py, line 138 in onRefactor>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/refactor/rename.py, line 25 in __init__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 19 in eval_location2>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 113 in get_primary_and_pyname_at>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 47 in eval_str2>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 32 in eval_node2>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/ast.py, line 41 in walk>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/ast.py, line 41 in walk>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/ast.py, line 39 in walk>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 155 in _Attribute>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/pynamesdef.py, line 42 in get_object>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/pyobjectsdef.py, line 69 in get_parameter>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/utils/__init__.py, line 29 in newfunc>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/pynames.py, line 188 in get>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/pyobjectsdef.py, line 40 in _infer_parameters>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/utils/__init__.py, line 41 in newfunc>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/soi.py, line 47 in infer_parameter_objects>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/soi.py, line 130 in _parameter_objects>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/type_hinting/providers/inheritance.py, line 21 in __call__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/type_hinting/providers/composite.py, line 19 in __call__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/type_hinting/providers/docstrings.py, line 46 in __call__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/type_hinting/providers/numpydocstrings.py, line 20 in __call__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/numpydoc/docscrape.py, line 138 in __init__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/textwrap.py, line 430 in dedent>]
Refactor failed. expected string or bytes-like object
[<FrameSummary file refactor.py, line 294 in watch>, <FrameSummary file refactor.py, line 275 in _process_request>, <FrameSummary file refactor.py, line 206 in _rename>, <FrameSummary file refactor.py, line 117 in refactor>, <FrameSummary file refactor.py, line 138 in onRefactor>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/refactor/rename.py, line 25 in __init__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 19 in eval_location2>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 113 in get_primary_and_pyname_at>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 47 in eval_str2>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 32 in eval_node2>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/ast.py, line 41 in walk>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/ast.py, line 41 in walk>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/ast.py, line 39 in walk>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 155 in _Attribute>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/pynamesdef.py, line 42 in get_object>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/pyobjectsdef.py, line 69 in get_parameter>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/utils/__init__.py, line 29 in newfunc>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/pynames.py, line 188 in get>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/pyobjectsdef.py, line 40 in _infer_parameters>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/utils/__init__.py, line 41 in newfunc>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/soi.py, line 47 in infer_parameter_objects>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/soi.py, line 130 in _parameter_objects>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/type_hinting/providers/inheritance.py, line 21 in __call__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/type_hinting/providers/composite.py, line 19 in __call__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/type_hinting/providers/docstrings.py, line 46 in __call__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/oi/type_hinting/providers/numpydocstrings.py, line 20 in __call__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/numpydoc/docscrape.py, line 138 in __init__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/textwrap.py, line 430 in dedent>]

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:1375  INFO no standard startup: panel is active
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:4103 Overwriting grammar scope name to file mapping for scope source.python.
Old grammar file: file:///usr/share/code/resources/app/extensions/python/syntaxes/MagicPython.tmLanguage.json.
New grammar file: file:///home/matt/.vscode/extensions/magicstack.magicpython-1.0.12/grammars/MagicPython.tmLanguage
e.register @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:4103
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:270 [Extension Host] vscode-icons is active!
2/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:2364 Refactor failed. expected string or bytes-like object [<FrameSummary file refactor.py, line 294 in watch>, <FrameSummary file refactor.py, line 275 in _process_request>, <FrameSummary file refactor.py, line 206 in _rename>, <FrameSummary file refactor.py, line 117 in refactor>, <FrameSummary file refactor.py, line 138 in onRefactor>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/refactor/rename.py, line 25 in __init__>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 19 in eval_location2>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 113 in get_primary_and_pyname_at>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 47 in eval_str2>, <FrameSummary file /home/matt/anaconda3/envs/learn/lib/python3.6/site-packages/rope/base/evaluate.py, line 32 in eval_node2>, <FrameSummary f...
e.onDidNotificationChange @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:2364

This should be addressed by #10440


Add cf_role to the attributes of the 'id' dimension

To follow CF Conventions, discrete datasets with a station dimension (no standardized name, so id works too) should have a cf_role attribute with a value "timeseries_id". This is what allows the right dimension to be easily identified, similarly to the axis attribute for lon/lat.
http://cfconventions.org/cf-conventions/cf-conventions.html#time-series-data

It is strongly recommended that there should be a station variable (which may be of any type) with the attribute cf_role=”timeseries_id”, whose values uniquely identify the stations.

Yes, I will add this to the DEH dataset and any other dataset further on.
On a site note, I think that after the change is made, we should keep the documentation mentioning the cf_role attribute in xhydro's documentation so that users are aware of this if they decide to provide their own datasets


Improve visibility of STAC specification citation

The https://github.com/radiantearth/stac-spec/blob/master/CITATION.cff file should probably be embedded in other locations, such as:

https://stacspec.org/en/about/stac-spec/
https://stacspec.org/en/get-involved/
https://stacspec.org/en/about/

Unless one is aware of this specific file and the repository, it is not obvious for non-developers to figure out this reference.

I guess this is a stac-site issue, so moving...


SASS language syntax coloring

There seems to be problem with SASS language syntax colouring

The property value has italics styles (which should not happen)
From line 9 to line 16, the property has different color comparing other lines

SASS
CSS

Are you using any additional plugins for sass syntax highlighting?

Are you using any additional plugins for sass syntax highlighting?

Yes, I've this extension install syler.sass-indented

I think that might be changing it, when I had a quick peek it seemed the same.

Seems like an external plugin was causing this issue.
Nonetheless, I had a look at sass highlighting and it works flawlessly with the Catppuccin 0.2.0 update so I'll be closing this issue for now.


Add ability for __post_init__ method to be defined.

If this method is defined for a class, it will get executed at the end
of __init__.  Previously, there was no way to extend what was
done during __init__ when using @attr.s.

Current coverage is 100% (diff: 100%)

Merging #111 into master will not change coverage

@@           master   #111   diff @@
====================================
  Files           8      8
  Lines         466    467     +1
  Methods         0      0
  Messages        0      0
  Branches      105    105
====================================
+ Hits          466    467     +1
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 4849dc1...6106e0d

Late to the party, but yes absolutely post conversion

I’ve fixed it up so we don’t have ping-pong over minutiae anymore, thank you very much for your contribution!
I’ve decided to rename __post_init__ to __attrs_post_init__ for consistency with __attrs_attrs__ and to be explicit about it’s heritage.
If someone has good arguments against it, feel free to open a new issue before 16.3.0 is out.


fatal: could not read Username for 'https://github.com': terminal prompts disabled

I have integrated Fastlane On Jenkins. Fastlane Could not download the repo. It throws following error.

- [ ] fatal: could not read Username for 'https://github.com': terminal prompts disabled
- [ ] 02:00:17 [02:00:17]: Exit status: 128
- [ ] 02:00:17 [02:00:17]: Error cloning repo, please make sure you have read access to the repository you want to use
- [ ] 02:00:17 [02:00:17]: Run the following command manually to make sure you're properly authenticated:

But everything works fine when Fastlane is Run on Terminal. Am I missing something?
Note:- Fastlane's Lane triggered via Jenkin works fine in Generating IPA etc but It cannot download or clone the REPO from GIT.
New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

[INSERT OUTPUT HERE]
Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
[INSERT OUTPUT HERE]

Without any information on your setup, it's hard to diagnose your issue. This sounds like the build machine doesn't have credentials to your scm.  Likely due to Jenkins shell environment for your job.

Jenkins is set with all credentials. Jenkins Can download my source code repo. But Fastlane could not clone the Certificate Repo when Run Via Jenkins Shell.
Same works when Fastlane is run on Terminal.

Yeah, that's because fastlane doesn't have the git credentials.  My guess is Jenkins does, but the session fastlane is running in does not.  If it will run on the same machine manually, then it's in the system keychain.  You need to either unlock the keychain or provide the credentials via jenkins.
Personally, id use ssh.  Https is a pain to deal with in CI environments from my experience.

I would also suggest to use ssh and private key.

Add unlock_keychain action in before_all.

first, check the login keychain name in ~/Library/Keychains/ folder.
add the following code in before_all section.

    unlock_keychain(path: "login.keychain-db",
                    password:ENV['MAC_USER_PASSWORD'])

Got it working now.
Uninstalled Jenkins. Installed it via brew. It works now. Too strange though. Did the same when installed via package installer it did not work..


Create 322-Coin-Change.cs

File(s) Modified: 322-Coin-Change.cs
Language(s) Used: c#
Submission URL: _https://leetcode.com/submissions/detail/781818639/_

Thanks, @notauserx!


IMG_EXTENSIONS lost "." for webp

#  torchvision/datasets/folder.py
IMG_EXTENSIONS = ('.jpg', '.jpeg', '.png', '.ppm', '.bmp', '.pgm', '.tif', '.tiff', 'webp')

webp =>.webp

@xialeizhou Thanks for reporting.
Could you send a PR fixing this.

Can I take this up and send a PR?

@Ashok93 Sure Why not !

@surgan12 Thanks! Pull request ref https://github.com/pytorch/vision/pull/836

Fixed via #836
Thanks @Ashok93

@Ashok93  it also has some lint errors .
Can you try and fix them too. ?

@surgan12 Can you specify the linting issue? I cannot find it and it seems okay.

@surgan12 the linting issues are on my side, no need to fix them now

I'll be fixing the linting issues now


Module assumes grafana 2.5 but grafana says 4.1.2 is newest (on debian/ubuntu)

The grafana docs for installing on debian/ubuntu indicate that the current stable version of grafana is 4.1.2.
But puppet-grafana thinks the most recent should be 2.5.0.  Even when setting manage_package_repo => false and version => '4.1.2', version 2.5.0 is installed.

FYI, working on this in the Voxpupuli fork (welcome to cherry-pick those changes in here too, @bfraser).
https://github.com/voxpupuli/puppet-grafana/pull/61


chore: bdd-spring-1576842528 to 0.0.1

chore: Promote bdd-spring-1576842528 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Issue on WIndows 11 - 'Specific module could not be found" - steamworks.js

Some of my players reported that on Windows 11 game won't run as Steamworks.js module can not be found. Same version works on other configurations ect.
Anybody spotted this issue? Do they need to install node.js on system?

I ran into the same error after building the app in MacOS. I fixed it with this suggestion.


Add corpus source upload command to upload files to a Corpus.

I am not sure the backend support for this is working as of yet, but at least this will unblock experimentation.

I'm going to YOLO this one. Bark if you are upset


It is a simple game but too different than other all games like Sokoban plus etc...
Please try this game do you know one think that I made many games but because of a technical problem I'm unable to publish them I am trying for many days to get sprig.
Pushing boxes to the goal.
file=https://editor.sprig.hackclub.com/?id=3b00414247eb684842b4651245548ddb
How to play your game?
WE CAN MOVE THE CHARACTER IN THE GAME using W, S, A, and D. With "j" we can restart the level
file=(https://editor.sprig.hackclub.com/?id=3b00414247eb684842b4651245548ddb)
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game

e name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file.

Thanks for PR!

simple_puzz

The checks for your PR are failing, try checking your fork for merge conflicts and the like.

Closing due to inactivity.


[Feature Request] Initialize Avatar Editor with character .glb link / Partial customization

I believe this issue might actually be two, but here goes.
Are there plans to support the initialization of the avatar editor with an already existing character? As if updating an existing character. For example, adding the field Init glb URL in RpmWebViewWidget, allows users/developers to specify an existing character (with a valid URL) and use it as the basis for the avatar editor.
Assuming the existence of the previous feature, my second question is if there are partial editing capabilities. For example, allowing the changing of the outfit but not of the head.

The Webview doesn't have the capability of editing the previously created avatar, I don't think there are plans for supporting it. You can send a feature request to the customer support team if you want.
In theory, you can achieve this by using the custom avatar creator(Alpha). It has an AvatarId field, but it only can be used by the owner of the avatar.
For the second question, in theory, you can achieve what you want by modifying the custom avatar creator UI blueprints. But afterwards you would need to apply manual changes if you decide to update the your version with the new changes.


Ensure we can reload files on the fly

Most configuration files aren't expected to change online, but if they need to be reloaded we should take that into consideration.

Because we define_method to make subsequent calls faster, this isn't possible. We would need to see that there is no compelling performance reason for using define_method before doing this.


[DOCS] Fixed typo in REST API docs

:mag: Description
Issue References 🔗

Describe Your Solution 🔧

fix the typo in REST API docs

Types of changes :bookmark:

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[x] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

cc @bowenliang123

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (e1e7772) to head (e8937f1).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6658   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         683     683
  Lines       42205   42205
  Branches     5756    5756
======================================
  Misses      42205   42205

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for the contribution. Merged to master (1.10.0), branch-1.9 (1.9.3) and branch-1.8 (1.8.3).


[SCB-399] fix incorrect file name of spring bean xml in samples

Signed-off-by: zhengyangyong<EMAIL_ADDRESS>Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

most of them named "pojo.xxx",seems copy & paste and may make confusion

Coverage increased (+0.006%) to 87.221% when pulling 12213f8ee9b1b00a1ffc5010695ee7a122b2988e on zhengyangyong:SCB-399 into 2231ed6450cfe6cfe58afe6f964be8df1234080b on apache:master.


Cop requiring for space around interpolation

There is a cop that forbids adding space around string interpolation #1836
It would be good if there was an opposite cop, which requires space around string interpolation:
# Good
"some #{ interpolated } string"

# Bad
"some #{interpolated} string"

Good addition of functionality IMO. But it should be implemented as a configuration option for SpaceInsideStringInterpolation rather than as a new cop:
Style/SpaceInsideStringInterpolation:
  EnforcedStyle: no_space
  SupportedStyles:
    - space
    - no_space

Yep, you're totally right.
On Sunday, June 14, 2015, Jonas Arvidsson<EMAIL_ADDRESS>wrote:

Good addition of functionality IMO. But it should be implemented as a
configuration option for SpaceInsideStringInterpolation rather than as a
new cop:
Style/SpaceInsideStringInterpolation:
EnforcedStyle: no_space
SupportedStyles:
- space
- no_space
—
Reply to this email directly or view it on GitHub
https://github.com/bbatsov/rubocop/issues/1971#issuecomment-111841014.

I'm wondering what is best default for this cop. I personally prefer without spaces, because it eliminates any possible confusion and it's more closer to interpolated string comparing to version with spaces around variable. Any reasons why it would be better to use spaces around variable as default?

I can't recall having seen spaces around interpolated strings in any Ruby book, blog post or source code. In my opinion, RuboCop should not need to support this particular style.

@bquorning I think so too, but some of guys in my team prefers spaces around, so I'm trying to find constructive arguments why spaces around could be used. The only one argument I heard is "it looks more clean/nice with spaces around, similar to ruby hash'es or blocks".

@sauliusgrigaitis That's a perfectly valid argument, but the string interpolation section of The Ruby Style Guide prescribes no spaces so that has to be the default (until someone gets a pull request that changes this recommendation merged into the style guide).

The ruby community, based upon code publicly available, prefers no spaces. It isn't even close. We have looked at the question before. I will look for the threads.

@sauliusgrigaitis. My position with team members advocating variant is that we default to the community standard unless and until we have substantial reason to diverge from the standard. It works for us. Part of my argument is that the community standard has the embedded wisdom of many. Having and using the standard makes interacting with the community much easier. I go on with more arguments than these as needed to ensure our variance is substantiated by our need not just desire.

Yeah, the default will remain no_spaces. There's little point in the discussing this right now, it's more important to implement the alternative config first.

it's more important to implement the alternative config first.

As I recall it, you have often commented that RuboCop shouldn’t (and cannot) support all different style preferences. As mentioned in my earlier comment above, I have never seen spaces around interpolated strings anywhere, and I don’t think there’s any need for the RuboCop codebase to support this style.
For rare styles like this, I’d rather advocate for writing a custom cop that you then load as an extension. I am doing that in at least one place where RuboCop and I disagree :-)

Even rubocop sorce contains spaces around string interpolation https://github.com/bbatsov/rubocop/blob/master/spec/rubocop/cop/style/unneeded_capital_w_spec.rb#L14

Rails also has a lot of places where interpolation is with spaces, like this https://github.com/rails/rails/blob/master/activesupport/test/core_ext/object/to_param_test.rb#L7 .
I personally prefer without spaces for variables interpolation, but what about one-liners that are interpolated, like this https://github.com/rails/rails/blob/master/railties/lib/rails/generators.rb#L181 ?

Even rubocop source contains spaces around string interpolation

Touché. Obviously, my argument doesn’t hold.

As I recall it, you have often commented that RuboCop shouldn’t (and cannot) support all different style preferences. As mentioned in my earlier comment above, I have never seen spaces around interpolated strings anywhere, and I don’t think there’s any need for the RuboCop codebase to support this style.

This is something which I'm fine with supporting. It's not super uncommon.

Even rubocop source contains spaces around string interpolation

Haha. Guess you found a bug in the cop. :-)

That's not a bug. It's lack of dogfooding in rubocop project.

That's not a bug. It's lack of dogfooding in rubocop project.

RuboCop is run on RuboCop's code for every PR; that's why I'm sure this is a bug.

Hehe. That's good discussion. So if rubocop contributors actually doesn't follow that rule in style guide (obviously for some reason contributor used spaces) and no one noticed that for long time, then maybe it's something wrong with this rule.

Humans are unreliable reviewers. Everyone makes mistakes and misses things from time to time. This is why we have RuboCop. :-)

Humans and RuboCop are both unreliable as its already proven above :) But that's not my main point.
I'm questioning this rule in general. Looks like spaces around are obviously used in various projects . In my opinion for more complex interpolations it looks better with spaces, but for basic variables interpolation I prefer no spaces. As you see there are various arguments for spaces (written in comments above), so maybe it's worth to discuss this rule.

This issue is not the place for such a discussion. Pretty much every rule gets questioned by someone, so nothing new here. :-) Let's implement the config option that was requested and be done with it.

@bbatsov I think in general this type of discussion is at the root of my love/hate relationship with rubocop. In particular, the coding styles used @devfu differ quite a bit from the “consensus”, in was that we’ve decided improve readability. The number of cops that don’t offer any configuration (other than on/off) mean that just about every rubocop update, we’re finding new cops to disable. Long term, this means our style isn’t actually being enforced, and discourages us from using rubocop in general.
I agree that this isn’t the place for this discussion, but where is that place?

The number of cops that don’t offer any configuration (other than on/off) mean that just about every rubocop update, we’re finding new cops to disable.

We have to start from somewhere and we usually start just from the most popular options. The project is always evolving and no popular convention was ever shot down. I'm extremely busy, however, and simply don't have the time to implement every option myself, so it's often up to the RuboCop users to extend it in the ways they want to.

I agree that this isn’t the place for this discussion, but where is that place?

Either a dedicated issue for the general problem or our mailing list/gitter channel.

Regarding this comment: https://github.com/bbatsov/rubocop/issues/1971#issuecomment-112694828

Even rubocop source contains spaces around string interpolation

I've corrected these three occurrences in my PR (#) to add this space configurable option.
However, there was not a bug in this cop.  These instances of spaces around interpolation were only in single-quoted strings used in one different spec.


BDD test for delete functionality

Updated rest_api.js
Updated wishlists.feature
Behave test for deleting a wishlist

Codecov Report

Merging #87 (2f9c281) into main (62528cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   97.08%   97.08%
=======================================
  Files           7        7
  Lines         378      378
=======================================
  Hits          367      367
  Misses         11       11

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Lock CM to owner enhancement

Add the ability to lock the machines to the owner who placed them. It can be set up like Thermal Expansions locking system. Expanding on this concept you can add guests/friends to your locked machine too.

Add a config to remove this feature please. Some servers are raid/grief.

Currently working on a 1.10.2 version, the 1.7.10 version is not being maintained anymore, sorry.
Closing all issues not relevant for the new version.


Error when setting both enablePullUp and enablePullDown to false

When I set both  enablePullUp and enablePullDown to false, RefreshController instance has its position property null.
This results in a crash and inability to scroll the child. Here's the stack trace:
I/flutter ( 4862): ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
I/flutter ( 4862): The following NoSuchMethodError was thrown during performLayout():
I/flutter ( 4862): The getter 'context' was called on null.
I/flutter ( 4862): Receiver: null
I/flutter ( 4862): Tried calling: context
I/flutter ( 4862):
I/flutter ( 4862): When the exception was thrown, this was the stack:
I/flutter ( 4862): #0      Object.noSuchMethod (dart:core-patch/object_patch.dart:50:5)
I/flutter ( 4862): #1      RefreshPhysics.createBallisticSimulation (package:pull_to_refresh/src/internals/refresh_physics.dart:250:42)
I/flutter ( 4862): #2      ScrollPositionWithSingleContext.goBallistic (package:flutter/src/widgets/scroll_position_with_single_context.dart:146:43)
I/flutter ( 4862): #3      IdleScrollActivity.applyNewDimensions (package:flutter/src/widgets/scroll_activity.dart:149:14)
I/flutter ( 4862): #4      ScrollPosition.applyNewDimensions (package:flutter/src/widgets/scroll_position.dart:490:14)
I/flutter ( 4862): #5      ScrollPositionWithSingleContext.applyNewDimensions (package:flutter/src/widgets/scroll_position_with_single_context.dart:106:11)
I/flutter ( 4862): #6      ScrollPosition.applyContentDimensions (package:flutter/src/widgets/scroll_position.dart:461:7)
I/flutter ( 4862): #7      RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:1256:20)
I/flutter ( 4862): #8      RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter ( 4862): #9      _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter ( 4862): #10     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter ( 4862): #11     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter ( 4862): #12     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter ( 4862): #13     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter ( 4862): #14     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter ( 4862): #15     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter ( 4862): #16     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter ( 4862): #17     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter ( 4862): #18     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter ( 4862): #19     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter ( 4862): #20     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter ( 4862): #21     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter ( 4862): #22     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter ( 4862): #23     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter ( 4862): #24     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter ( 4862): #25     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter ( 4862): #26     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
I/flutter ( 4862): #27     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
I/flutter ( 4862): #28     RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1496:7)
I/flutter ( 4862): #29     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:765:18)
I/flutter ( 4862): #30     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:346:19)
I/flutter ( 4862): #31     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:701:13)
I/flutter ( 4862): #32     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:285:5)
I/flutter ( 4862): #33     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1016:15)
I/flutter ( 4862): #34     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:958:9)
I/flutter ( 4862): #35     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:874:5)
I/flutter ( 4862): #39     _invoke (dart:ui/hooks.dart:236:10)
I/flutter ( 4862): #40     _drawFrame (dart:ui/hooks.dart:194:3)
I/flutter ( 4862): (elided 3 frames from package dart:async)

Error was encountered with this configuration:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.7.8+hotfix.4, on Mac OS X 10.14.5 18F132, locale it-IT)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
[✓] iOS tools - develop for iOS devices
[✓] Android Studio (version 3.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2019.2)
[✓] VS Code (version 1.36.1)
[✓] Proxy Configuration

you can remove SmartRefresher from ListView if you don't need to pull-down-refresh or pull-up-load


ValueError: start can't be >= end (level_cum_sum >= level_cum_sum)

Hi,
i want to use traces to convert an unevenly spaced Time Series to an evenly spaced one (like the example in the docs). When doing this the following error is raised:
"ValueError: start can't be >= end (level_cum_sum >= level_cum_sum)"
My TimeSeries looks like below when i print it to the console 1. Thus level_cum_sum is ordered and i removed duplicates.
The line raising the error is:
"regular = time_series.moving_average(10, pandas = True)"
I assume there is an error on my side, not a bug. The error message does not help myself much (more or less new to Python, but experienced in other languages).
Any help would be much appreciated.
Best regards,
Jannis
SortedDict(None, 1000, {'level_cum_sum': lagHoursCorrectedCumSum
4.730833        10.0
8.776111        20.0
8.882778        30.0
10.854722       40.0
12.983611       50.0
13.745000       53.0
17.923889       63.0
20.740833       69.0
20.747500       70.0
24.512500       73.0
25.074167       74.0
30.734722       84.0
32.031944       94.0
32.270556      100.0
36.824722      110.0
37.970278      120.0
38.818889      122.0
40.390278      132.0
41.816944      142.0
42.810833      145.0
45.745278      155.0
46.010278      157.0
46.018889      158.0
48.935000      168.0
50.605000      178.0
51.175000      188.0
52.663889      198.0
52.685000      200.0
56.738611      208.0
61.617222      218.0
...
419.344444    1550.0
423.516667    1560.0
426.186389    1569.0
427.395000    1579.0
429.465556    1589.0
429.522222    1590.0
429.528333    1591.0
430.611111    1601.0
435.259722    1611.0
436.240278    1621.0
438.515278    1630.0
439.875833    1640.0
441.641111    1650.0
443.168056    1656.0
443.173611    1657.0
448.372222    1667.0
451.460833    1677.0
454.263333    1687.0
465.015000    1697.0
468.279722    1706.0
471.472222    1716.0
473.009444    1724.0
473.701389    1727.0
473.785833    1728.0
478.067500    1738.0
483.246389    1748.0
484.898333    1758.0
485.238056    1768.0
488.893611    1778.0
488.960278    1780.0
Name: level_cum_sum, dtype: float64})

Thanks for asking the question! That is indeed a cryptic error message.
It looks like the error is due to having a mix of strings and floats as the "measurement points" in the time series: you mostly have floats as the time points, but have one time point in the TimeSeries set as the string "level_cum_sum".
If you could attach the code that you used to generate the time series, I'd be happy to take a look.

Hi Mike,
thanks for the quick response!
I guess the Preprocessing should not be relevant, so here is the part just before the call leading to the error:
**levels.to_excel('levels.xlsx')
print type(levels)
print levels.dtypes
time_series = traces.TimeSeries(data=levels)
regular = time_series.moving_average(10, pandas = True)
print regular**
print type level returns <class 'pandas.core.frame.DataFrame'>
print levels.dtypes returns level_cum_sum    float64
I attached the levels DataFrame as xlsx-File:
levels.xlsx
Does that help or do you need more information?
Best regards,
Jannis


Save supported extensions in one place

Right now ".csx" string is hardcoded in AbstractLoadDirectiveCompletionProvider, MainViewModelBase (maybe other places too). There should be ether a setting or some constant array with supported types, because adding support for other types later might be a headache.

AbstractLoadDirectiveCompletionProvider is only applicable to .csx (there is no #load in a .cs file).
MainViewModelBase should probably use the constant DocumentViewModel.DefaultFileExtension, but since it needs to be without the . I thought it'd be easier to leave it as is. Besides, for the dialog also needs a description.
For now, let's just leave it as is. I haven't gotten requests to support .cs in RP itself (there was one request for the standalone control which doesn't use the view models at all.)


Earlier Version Of Script

This is an earlier version of the script that handled with and without --cu_unet very well.  It puts everything into a single folder, per model version, with or without the ControlledUnet.mlmodelc, depending on the command argument.
I am going to go back to this version, and try to update it with the split and zip pieces from your current version.  Again, I will go one step at a time.  I will try to get the file name split/merge added first, probably this evening.

Thank you


can a node be used both as master and worker?

for homelab, teh resource is quite restrictive and i would like to use master to host workload as well. is it possible?

Yes, servers nodes also run the kubelet, and do not by default create any taints that would prevent scheduling of workload pods.

Yes, servers nodes also run the kubelet, and do not by default register any taints that would prevent scheduling of workload pods.

So if i have 3 master (ha with embedded etcd) and 2 agents, the workload by default will be scheduled to all 5 nodes?

Correct.

Many thanks


The plugin advance_pdf_viewer uses a deprecated version of the Android embedding.

Running "flutter pub get" in my_flutter_app...                5.7s
The plugin advance_pdf_viewer uses a deprecated version of the Android embedding.
To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.
If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.
my pubsec.yaml
dependencies:
  flutter:
    sdk: flutter

  advance_pdf_viewer: ^2.0.0

Downgrade Flutter

@M-Thanos

Downgrade Flutter

Are you serious? This is an answer from the developer? Bullshit!

hi . any update for this . im using flutter version 2.8.1

Any update?

Any updates?

Only update link to : https://github.com/erluxman/pdf_flutter

This is what happen when you depends on the library made by the guy from nowhere.


Pull in changes from Laravel

Some of the language changes are a bit dodgy.

Can we actually remove the password stuff that laravel ships with? Do we actually use it?

We don't use it :)


Drop k4DataSvc in favor of PodioDataSvc

As discussed in #100 k4DataSvc is effectively just a very thin wrapper around PodioDataSvc and can be removed. This issue is mainly for keeping track of the removal and for related discussions.

k4DataSvc is used in many repos both in key4hep and other organizations so it's a fair amount of work for not much gain:

https://github.com/search?q=org%3Akey4hep k4DataSvc&type=code
https://github.com/search?q=org%3AHEP-FCC k4DataSvc&type=code
https://github.com/search?q=org%3Acepc k4DataSvc&type=code
Alternatively we could move everything to k4DataSvc and remove PodioDataSvc since it's only used internally in this repo. I guess it makes sense if you're using key4hep that the name is k4DataSvc

There is another DataSvc FCCDataSvc that effectively does the same as k4DataSvc.
@kjvbrt @BrieucF is that still in use to the best of your knowledge?

There might be a technical reason for this split(?) At least simply merging PodioDataSvc into k4DataSvc and moving that to the core k4FWCore library, results in
[warning] library [k4FWCorePlugins] exposes factory [k4DataSvc] which is declared in [libk4FWCore.so] !!

and then subsequently runtime crashes with:
[k4run] : Configurable k4DataSvc not found in module k4FWCore.k4FWCorePluginsConf
Traceback (most recent call last):
  File "/home/tmadlener/work/key4hep/k4FWCore/k4FWCore/scripts/k4run", line 129, in <module>
    load_file(file)
  File "/home/tmadlener/work/key4hep/k4FWCore/k4FWCore/scripts/k4run", line 26, in load_file
    exec(file.read(), {})
  File "<string>", line 22, in <module>
TypeError: 'NoneType' object is not callable

There is another DataSvc FCCDataSvc that effectively does the same as k4DataSvc.
@kjvbrt @BrieucF is that still in use to the best of your knowledge?

Hi Thomas, yes FCCDataSvc is used in some places outside of the Key4hep/HEP-FCC organizations but I can do the modification where I know it is used and advertise the change to the relevant mailing lists to warn people if it is decided to remove FCCDataSvc.

We removed it some places, but not all, yet.

OK. Thanks for checking. We could put in some deprecation warning log message before completely removing it. That would at least make people aware if they are checking their logs.


FW load feature availability on KMMO for OCP

When will FW load feature from upstream [https://github.com/kubernetes-sigs/kernel-module-management/pull/17] be available on downstream KMMO repo for OCP?

Hi @hershpa, that was backported in https://github.com/rh-ecosystem-edge/kernel-module-management/pull/52. Closing this issue.


Warning agora-rtc-sdk-ng dependencies on CommonJS or AMD

Hi, is it possible to fix this warning?
Warning: agora.service.ts depends on 'agora-rtc-sdk-ng'. CommonJS or AMD dependencies can cause optimization bailouts.

Hey @NarHakobyan. Which version of Angular you are using ?

I just checked it out in both v9 and v11. There is no warning in library. @NarHakobyan

We are using angular version ^11.0.0

import { NgxAgoraSdkNgService } from 'ngx-agora-sdk-ng'; Are you using this line of code for importing ?
The library that I have developed is not a CommonJS module. It's normal Angular library.
I hope this link will useful for you. To disable these warnings, you can add the CommonJS module name to allowedCommonJsDependencies option in the build options located in angular.json file. https://angular.io/guide/build#configuring-commonjs-dependencies.
"build": {
  "builder": "@angular-devkit/build-angular:browser",
  "options": {
     "allowedCommonJsDependencies": [
        "lodash"
     ]
     ...
   }
   ...
},


Unhandled rejection ReplyError: CROSSSLOT Keys in request don't hash to the same slot

Hello there,
I am using ioredis to enable redis cluster usage to set and purge keys. On purging keys, I get the above error. The purge happens anyway. When I use the redis instance in expressjs middleware I get this error otherwise I dont.
I am using 4.10.x as the express version.
Thanks for the help.

This sounds like an issue with either the redis package or your application.  If you post a comprehensive example we can help debug, but otherwise I would look at what you are calling to redis with.

`var express = require('express');
var expressSession = require("express-session");
var sessionStorage = require('connect-redis')(expressSession);
var redis = require('ioredis');
var config = require('./config');
var app = express();
var client = new redis.Cluster([{
host: config.session.host,
port: config.session.port,
password: config.session.pass,
ttl: config.session.ttl
}]);
app.use(expressSession({
unset: "destroy",
saveUninitialized: false,
resave: false,
secret: config.session.secret,
store: new sessionStorage({
client: client,
ttl: config.session.ttl,
prefix: '{sess}.'
}),
key: "authorization.sid",
cookie: {maxAge: config.session.maxAge}
}))
app.use(bodyParser.urlencoded({extended: true}));
app.use(bodyParser.json());
app.post('/login', function(req, res) {
if(req.user) {
return res.redirect('/home');
}
if (req.body.username === 'Anu' && req.body.password === 'Password') {
	req.logIn({name: 'Anu'}, function(err) {
		return res.redirect('/home');
	})
} else {
	return res.send(400);
}

})
app.get('/logout', function(req, res) {
req.logout();
})
var port = process.env.PORT || '3000';
app.listen(port);
`
A very rough sample. Nothing complicated. On req.logout() I am getting the above unhandled error.

Note: I get this error only when I use it in the express middleware and not when using the io-redis package seperately.

Okay. I have raised the same in ioredis

The issue opened in ioredis explains the resolution. Closing over here.


how to dump db data directly instead enter interactive mode

I need use below command to list all data
LiteDB.Shell.exe
-->enter interactive mode
open mydb
db.myconnection.find
How to use single command to get data and not enter interactive mode
thanks

LiteDB.Shell Usage:
LiteDB.Shell [myfile.db] --param1 value1 --params2 "value 2"
Parameters:
--exec "command"   : Execute an shell command (can be multiples --exec)
--run script.txt   : Run script commands file
--pretty           : Show JSON in multiline + indented
--exit             : Exit after last command

I find this is not listed in the document.
@mbdavid

I'm closing the issue as the question has been resolved. Please note that, in the upcoming LiteDB v5,  the LiteDB.Shell has been removed in favor of LiteDB Studio.


OTP verification system for SignIn functionality-#203

Description
I have implemented an OTP verification system on the SignUp page, which allows users to verify their phone numbers via OTP before completing the sign-up process. Additionally, I have updated the Firebase version to 9.4.1, as newer versions were not supporting OTP verification via phone number properly.
Motivation and Context
This change is required to enhance the security of the sign-up process by ensuring that users verify their phone numbers via OTP.
It fixes issue - #203
How Has This Been Tested?
1 Attempting to sign up with a phone number and ensuring an OTP is sent.
2 Entering the OTP to verify the phone number.
3 Checking that after 10 OTP requests in a day, the phone verification field disappears, and the user can sign up without phone verification.
4 Verifying that other sign-up functionalities work as expected without any regression.
Screenshots (if appropriate):

Now the phone verification process will happen in SignUp page only

Only when user has verified his/her phone number then he/she will be directed to the SignIn page

If 10 sms has already been sent in a day for Otp verification then Phone Otp verification field will be removed
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@mr0nerd don't forget to give a ⭐

It's already stared :-) @MAVRICK-1


When having two player instances playing, stopping one instance triggers exiting fullscreen mode on both

Browser: 54.0.2840.100 (64-bit)
OS: Ubuntu 16.04 LTS
Clappr Version: 0.2.64
Steps to reproduce:

Create two player instances and start both
Switch first player to fullscreen mode
Stop the second player
I was expecting the first player to remain in fullscreen mode but it doesn't

Currently, Clappr player rely on prefixed fullscreenElement document api attributes to detect if browser is in fullscreen : (webkitFullscreenElement, mozFullScreenElement, msFullscreenElement, webkitFullscreenElement, webkitFullscreenElement) - Which explains the current "global" behaviour.
If attribute is null, then browser is not in fullscreen mode, otherwise the attribute contains the element which has requested fullscreen.
@core : To fix/implement this behaviour, maybe add a unique id (a data-XXX attribute ?) to playback element and check for it if attribute is not null ? (not sure it is the best/elegant way to do)

@kslimani you're right about the reason, good catch.

If i am not wrong, enter fullscreen require a user action (ie: click or touch). So if one player is in fullscreen, the scenario you describe cannot happen. (you can't click on the other player if other one is in fullscreen)

I'm sorry, I thought that there could be cases where you call the method to enter full screen.

You can request fullscreen programmatically but it will be denied by the browser if it is not trigger from user click.
Another possible funny scenario could be to create a plugin which add a new button in first player media controls which trigger fullscreen on second player :smile:

Ok I think I open an PR this week about this issue, I just had do make sure what was supposed to be the behavior.


Friends List

Extend user controller to populate friends
Extend user model to include friends
Test add / remove friend insomnia
Refactor app for async await

Integrated under: commit 170552bce7f36654eb75e2e2a3181042e99b9c41 .


Store multiple events within a single note

I would also love for some functionality of scraping event information from the daily notes! Of course it wouldn't have the full amount of capabilities of a full event page, (dragging and dropping would probably be a pain to enable) but being able to quickly add an event name, start and end time within for a day would be amazing.

Originally posted by @wychwitch in https://github.com/davish/obsidian-full-calendar/issues/6#issuecomment-1045033205
You could specify as much event info as you want using inline dataview fields, and the plugin would "fill in the blanks" using the page's frontmatter. So you could have a page with fullCalendar_date: 2022-02-22, and then bullet points with [startTime:: 5:00pm] [endTime:: 7:15pm] would be able to be populated on the calendar.
You would be able to edit any field specified in-line from the calendar as well. But page-wide fields would be locked. To move an event to a different date in this example, you would have to manually move it to a different note.
Relying on custom frontmatter means that you could easily integrate this with your daily note / periodic note templates, but you're not locked into those formats.

Yessss this sounds perfect!!! Exactly the functionality i had in mind

I think it would be nice if we can use this along with the manual adding of events directly in calendar since its much faster.
events added to the same day from calendar are added to the note for that particular day

@yanly007 when inline notes are added I'll make sure to add a setting to create new notes within a daily note.

i'd posted on another thread about the style that the itinerary plugin uses.  that one uses full0-calendar for display as well.  you can see how they gather events from files and how they allow event specification.  if you want events in the yaml front matter, could you perhaps make the event spec an array of events?  that way you can use the same UI and the like,  but you pull multiple from a note and when someone edits, you find that event in the array.  should be less code change than using events in the body of notes.


Write a spec file

write a spec file to run the script and set up a repo like https://github.com/aspiers/opensuse-spotify-installer

I've forked the repo and will work on this

I've got the spec file finished for this (sorry it took longer than expected).

@jonlandrum Awesome, can you open a Pull Request please?
We'll close this when the pull is merged.

@paolorotolo certainly. I fell asleep last night trying to read about building an RPM to make sure I've got the spec file right, sorry for not opening the pull request earlier.

Also, you'll notice line 9 is commented out: #Requires:   binutils. That's the part I wanted to test. It appears RPM is very good at determining dependencies, but I haven't been able to confirm if it can pick up the binutils dependency or not.