Adding support for bf16_full_eval

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss I have enabled bf16_full_eval and verified the same with t5 inference.
Can you review it?

@bhargaveede please also update (1) summarization README file to include this extra argument for t5-3b prediction example, (2) performance targets in test for both G1 and G2.

@regisss  Can your review and merge this?

@regisss Can we merge this?

Looks good to me. We can merge it once @regisss also reviews.

I'll review it this week :+1:


RuntimeError: nonzero is not supported for tensors with more than INT_MAX elements

❓ Questions & Help
I use function dense_to_sparse in torch_geometric/utils/sparse.py, when I set my batch size to 20, everything is fine. However, when I set my batch size to 30 or 40, I got an error:
  File "/home/syh/lib/python3.6/site-packages/torch_geometric/utils/sparse.py", line 18, in dense_to_sparse     index = tensor.nonzero().t().contiguous() RuntimeError: nonzero is not supported for tensors with more than INT_MAX elements,   file a support request
My packages' version are as follows:
torch                 1.7.1+cu110 torch-cluster         1.5.8 torch-geometric       1.6.3 torch-scatter         2.0.5 torch-sparse          0.6.8 torch-spline-conv     1.2.0
And the function dense_to_sparse is

def dense_to_sparse(tensor):
r"""Converts a dense adjacency matrix to a sparse adjacency matrix defined
by edge indices and edge attributes.

Args:
    tensor (Tensor): The dense adjacency matrix.
 :rtype: (:class:`LongTensor`, :class:`Tensor`)
"""
assert tensor.dim() == 2
index = tensor.nonzero().t().contiguous()
value = tensor[index[0], index[1]]
return index, value

I don't know how to fix the problem, can you help me?
Thanks.

 Looks like the maximum index is larger than INT_MAX.

 Looks like the maximum index is larger than INT_MAX.

My adjacency matrix is very big, its size is [2, 266900], can I adjust INT_MAX myself?

I guess that‘s not a problem with the number of edges, but rather withedge_index.max(). Please ensure that values inside edge_index are in the range [0, num_nodes - 1].


Add batch processing in datetime model

Summary

Added batch processing to the datetime model, enabling the handling of multiple datetime data entries simultaneously.

Implementation

Introduced a batch processing method to support handling multiple datetime entries.

Verification

The newly added test cases were confirmed to pass.

@CodiumAI-Agent /review

@CodiumAI-Agent /review

PR Reviewer Guide 🔍
Here are some key observations to aid the review process:

⏱ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Possible BugThe method convert_batch uses a list comprehension that incorrectly applies the convert_timestamp_by_digits method to each element of the list without considering different timezone adjustments for each timestamp.
Data ValidationThe data_check method in DatetimeModelValidator class should handle potential division by zero error when converting milliseconds to seconds.

@CodiumAI-Agent /review

@CodiumAI-Agent /review

PR Reviewer Guide 🔍
Here are some key observations to aid the review process:

⏱ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Error HandlingThe exception handling in the batch conversion method might suppress the stack trace of the original exception, which can hinder debugging.
Data ValidationThe data validation for Unix time does not account for negative values or non-integer inputs, which could lead to unhandled exceptions or incorrect conversions.


throwing Error after adding it to a newly created nuxt 3 project

I am getting this error when added in a newly created nuxt 3 project
Cannot restart nuxt:  Cannot read properties of undefined (reading 'resolveAlias')                                                                                15:23:23
  at Object._default (node_modules\@nuxtjs\i18n\src\index.js:34:42)

Version:
"@nuxtjs/i18n": "^7.0.3"
Added in tsconfig.json
    "types": [
      "node",
      "@nuxt/types",
      "@nuxtjs/i18n",
   ]

Nuxt 3 is not supported at the time of writing.
Work on Nuxt 3-compatible version is progressing in https://github.com/nuxt-community/i18n-module/tree/next branch (released as @nuxtjs/i18n-edge package


bug: Not Able to use frames.js in their Next.js Project

Is there an existing issue for this?

[X] I have looked through the existing issues

Which method was used to setup Scaffold-ETH 2 ?
git clone
Current Behavior
In changing the layout.tsx file of next I tried to implement the code of frames.js to creating frame giving me error

Expected Behavior
This should be load the layout of frames.jsx as this actually happening in normal next.js enviornment.
Steps To Reproduce
No response
Anything else?
No response

in layout.tsx when I'm using fetchMetadata import it's giving the error. else it's running.

Hey @anuragasawa20, could you please provide a minimal reproducible repo link? With cloning the SE-2 and adding frame.js with minmal changes to it?

Closing this for now


Sardist version

updating resId for sardist open data resource

I forgot to change the repo to the dfo-mar-odis when creating the request, this can be ignored.


ERA-10399: Fixing unit tests

What does this PR do?

Fixes broken unit test for <PrintTitle />

Relevant link(s)

Tracking tickets: ERA-10399

just wondering if fixing the import wouldn't solve the issue instead of changing the coverage of the test? based on the logs from the gh actionthat seemed to be the only issue 🤔

just wondering if fixing the import wouldn't solve the issue instead of changing the coverage of the test? based on the logs from the gh actionthat seemed to be the only issue 🤔

The previous test case was not working, you are right the error in the build points to the import statement, but once fixed the test case was broken, so I decided to add just a simple working test case, also since the some coverage is missing I created a ticket to add it later

Do we understand what caused the test to fail?


implement dynamodb external manifest store

part of #1183
This PR implements a DynamoDB backed ExternalManifestStore.
TODO

[x] add testing (use dynamodb local in CI)

just comment changes. Going to lance w/o CI, previous all green


Sending multiples emails with data

Hi @djagya,
I'm writing here like "an issue" but it would be new feature on the API.
I saw that SparkPost it's able to send multiples emails using custom data for each user, like the example below:
{
  "campaign_id": "campaign_name",
  "recipients": [
    {
      "address"<EMAIL_ADDRESS>      "metadata": {
        "unique_id": 1212
      },
      "substitution_data": {
        "nome": "Name 1",
        "nova_senha": "axIjU2"
      }
    },
    {
      "address"<EMAIL_ADDRESS>      "metadata": {
        "unique_id": 7862
      },
      "substitution_data": {
        "nome": "Name 2",
        "nova_senha": "asCADe12"
      }
    }
  ],
  "content": {
    "template_id": "template_id_publish"
  }
}

I didn't find anything that configure this JSON on Yii2's API, so it would be great to have this feature on Yii2's API. This could improve even more the development on Yii2 saving unnecessary looping.
What do you think about that? Did you solve this case with another solution?
Thanks.

Hi,
thanks for your interest in my extension!
Yes, actually I thought about that feature recently, but decided to wait until someone will really need this :)
Agreed, it should be implemented within yii extension, maybe even as a simple proxy layer between you and actual php-sparkpost library.
So yes, i'll implement that soon!

Hi @djagya,
Great to see your interesting on this feature.
I will be waiting for new releases and following this this API.
Great job =]

Hi @fasfelipe,
sorry for the long delay.
Please review the changes I made, I think it should be enough.
Let me know if it's ok and I'll close the issue!

I'm closing the issue, supposing it's enough.

Thanks @djagya.
Sorry for delay, I will test your API next week, but thanks for attention.


refactor: use dataset API for resizeDisableAnimation

Refactor the resizeDisableAnimation with the dataset API.

Codecov Report

Merging #1948 (186b76e) into master (ab917b0) will decrease coverage by 17.15%.
Report is 1597 commits behind head on master.
The diff coverage is 31.26%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           master    #1948       +/-   ##
===========================================
- Coverage   54.85%   37.71%   -17.15%
===========================================
  Files          49      271      +222
  Lines        1659     9814     +8155
  Branches      406     2144     +1738
===========================================
+ Hits          910     3701     +2791
- Misses        671     5879     +5208
- Partials       78      234      +156

Files Changed
Coverage Δ

...ts/sbb-accordion-item/sbb-accordion-item.events.ts
100.00% <ø> (ø)

.../sbb-accordion-item/sbb-accordion-item.stories.tsx
0.00% <0.00%> (ø)

...mponents/sbb-accordion-item/sbb-accordion-item.tsx
0.00% <0.00%> (-37.21%)
:arrow_down:

...components/sbb-accordion/sbb-accordion.stories.tsx
0.00% <0.00%> (ø)

...ents/sbb-action-group/sbb-action-group.stories.tsx
0.00% <0.00%> (ø)

...onents/sbb-alert-group/sbb-alert-group.stories.tsx
0.00% <0.00%> (ø)

src/components/sbb-alert/sbb-alert.stories.tsx
0.00% <0.00%> (ø)

...onents/sbb-autocomplete/sbb-autocomplete.events.ts
100.00% <ø> (ø)

...ents/sbb-autocomplete/sbb-autocomplete.stories.tsx
0.00% <0.00%> (ø)

...-breadcrumb-group/sbb-breadcrumb-group.stories.tsx
0.00% <0.00%> (ø)

... and 57 more

... and 219 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Setting default branch incorrectly to master

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Our default branch is main, but super-linter sets a non-existent branch named master ([INFO]   The default branch for this repository is set to: master), so it errors-out with [FATAL]   Neither master, nor origin/master exist in /tmp/lint.
Expected Behavior
It should set the default branch to the default set for the repo, e.g.:
$ git config --global init.defaultBranch
main

Super-Linter version
v6.3.0

Relevant log output
$ docker run --pull=always -e FILTER_REGEX_EXCLUDE="(\.pylintrc|migrations|.*\.xlsx|static\/bootstrap.*)" -e LINTER_RULES_PATH="/" -e IGNORE_GITIGNORED_FILES=true -e RUN_LOCAL=true -v "/Users/rleach/PROJECT-local/TRACEBASE/tracebase:/tmp/lint" "ghcr.io/super-linter/super-linter:slim-v6.3.0"
slim-v6.3.0: Pulling from super-linter/super-linter
Digest: sha256:8d7419597b489a0beee985b13e141d92a0fd5f65a30e7a398a99ac62d68b5341
Status: Image is up to date for ghcr.io/super-linter/super-linter:slim-v6.3.0
--------------------------------------------------------------------------------

                              /@@#///////@@/(@//@%/(@.@(       @@
                          @@//////////////////////////////#*  @@@
                        @////@//(///////////@@@@@///@//@/@**//@@(
                      @///////@///////////////@@@@    (           @,
                     @/(&/@////////////////////                     @
                    @////////////////////////@@                      @
                  @%////////(//////////%/////&@            @@       *,@           ______________
             @@@@@/@/#/////(&//////////////////                       .@         /              \
        *@@@@@.    .%///(//@//////////////////&.   .@@,                 @%      / Don't mind me  \
      @@%           .&@&&/@.@//&/////(//////////    @@@@@@@@@         .. &@    / I'm just looking \
    @@%               @@@@@   @&/////////////////#   @/       V  @@/ ,@@@ @   <  for some trash... |
@@@%                   @@@@        .%@@@@//////#@ @   @@         @     .,.     \__________________/
                                          @@@/@(  (@@@@% @/\      %
                                           @@@@(    .     .@@/\   #
                                             @                  %@%

--------------------------------------------------------------------------------
2024-04-01 14:46:51 [INFO]   ---------------------------------------------
2024-04-01 14:46:51 [INFO]   --- GitHub Actions Multi Language Linter ----
2024-04-01 14:46:51 [INFO]    - Image Creation Date: 2024-02-29T07:13:35Z
2024-04-01 14:46:51 [INFO]    - Image Revision: e0fc164bba85f4b58c6cd17ba1dfd435d01e8a06
2024-04-01 14:46:51 [INFO]    - Image Version: e0fc164bba85f4b58c6cd17ba1dfd435d01e8a06
2024-04-01 14:46:51 [INFO]   ---------------------------------------------
2024-04-01 14:46:51 [INFO]   ---------------------------------------------
2024-04-01 14:46:51 [INFO]   The Super-Linter source code can be found at:
2024-04-01 14:46:51 [INFO]    - https://github.com/super-linter/super-linter
2024-04-01 14:46:51 [INFO]   ---------------------------------------------
2024-04-01 14:46:51 [INFO]   - Validating all files in code base...
chktex: chktex: WARNING -- Could not find global resource file.
ChkTeX v1.7.8 - Copyright 1995-96 Jens T. Berger Thielemann.
Compiled with POSIX extended regex support.
rubocop: 1.60.2
perl:
This is perl 5, version 38, subversion 2 (v5.38.2) built for x86_64-linux-thread-multi

Copyright 1987-2023, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5 source kit.

Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl".  If you have access to the
Internet, point your browser at https://www.perl.org/, the Perl Home Page.
xmllint: xmllint: using libxml version 21106
   compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 HTTP DTDValid HTML C14N Catalog XPath XPointer XInclude Iconv ISO8859X Unicode Regexps Automata Schemas Schematron Modules Debug Zlib Lzma
ansible-lint: ansible-lint 24.2.0 using ansible-core:2.16.4 ansible-compat:4.1.11 ruamel-yaml:0.18.6 ruamel-yaml-clib:0.2.8
eslint: v8.57.0
markdownlint: 0.39.0
snakefmt: snakefmt, version 0.10.0
cpplint: Cpplint fork (https://github.com/cpplint/cpplint)
cpplint 1.6.1
Python 3.12.2 (main, Feb  7 2024, 22:13:24) [GCC 13.2.1 20231014]
editorconfig-checker: 2.7.2
gitleaks: v8.18.2
phpstan: PHPStan - PHP Static Analysis Tool 1.10.48
asl-validator: 3.8.2
actionlint: 1.6.27
installed by building from source
built with go1.22.0 compiler for linux/amd64
tekton-lint: 1.0.0-beta.9
terrascan: version: v1.18.11
terraform: Terraform v1.7.4
on linux_amd64
2024/02/28 15:15:23 traces export: Post "http:///dev/otel-grpc.sock": http: no Host in request URL
2024/02/28 15:15:23 traces export: Post "http:///dev/otel-grpc.sock": http: no Host in request URL
R: R version 4.3.1 (2023-06-16) -- "Beagle Scouts"
Copyright (C) 2023 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-musl (64-bit)

R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under the terms of the
GNU General Public License versions 2 or 3.
For more information about these matters see
https://www.gnu.org/licenses/.
shellcheck: ShellCheck - shell script analysis tool
version: 0.9.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
jscpd: 3.5.10
black: black, 24.2.0 (compiled: no)
Python (CPython) 3.12.2
prettier: 3.2.5
php: PHP 8.2.15 (cli) (built: Jan 18 2024 16:40:05) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.15, Copyright (c) Zend Technologies
textlint: v14.0.3
npm-groovy-lint: GroovyLint: Successfully processed CodeNarc:
CodeNarc version 3.3.0
npm-groovy-lint version 14.2.2

Embeds:
CodeNarc version 3.3.0
- Groovy version 3.0.9 (superlite)
renovate-config-validator: (node:226) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
37.214.0
golangci-lint: golangci-lint has version 1.56.2 built with go1.22.0 from 58a724a0 on 2024-02-15T20:35:23Z
kubeconform: v0.6.4
golangci-lint: golangci-lint has version 1.56.2 built with go1.22.0 from 58a724a0 on 2024-02-15T20:35:23Z
gherkin-lint: Version command not supported
eslint: v8.57.0
scalafmt: scalafmt 3.8.0
stylelint: 15.11.0
sqlfluff: sqlfluff, version 2.3.5
bash-exec: Version command not supported
google-java-format: google-java-format: Version 1.20.0
phpcs: PHP_CodeSniffer version 3.8.0 (stable) by Squiz and PHPCSStandards
terragrunt: terragrunt version v0.55.9
psalm: Psalm 5.22.1@e9dad66e11274315dac27e08349c628c7d6a1a43
pylint: pylint 3.1.0
astroid 3.1.0
Python 3.12.2 (main, Feb  7 2024, 22:13:24) [GCC 13.2.1 20231014]
shfmt: v3.8.0
snakemake: 8.5.3
mypy: mypy 1.8.0 (compiled: yes)
eslint: v8.57.0
coffeelint: 5.2.11
tflint: TFLint version 0.50.3
+ ruleset.terraform (0.5.0-bundled)
cfn-lint: cfn-lint 0.85.2
flake8: 7.0.0 (mccabe: 0.7.0, pycodestyle: 2.11.1, pyflakes: 3.2.0) CPython 3.12.2 on
Linux
spectral: 6.11.0
clj-kondo: clj-kondo v2024.02.12
eslint: v8.57.0
ts-standard: 12.0.2
eslint: v8.57.0
protolint: protolint version 0.47.6(80ba08f)
raku: Welcome to Rakudo™ v2023.11.
Implementing the Raku® Programming Language v6.d.
Built on MoarVM version 2023.11.
prettier: 3.2.5
hadolint: Haskell Dockerfile Linter 2.12.0
checkstyle: Checkstyle version: 10.13.0
clang-format: clang-format version 17.0.5 (https://github.com/llvm/llvm-project.git 98bfdac5ce82d1679f8af9a57501471812ab68d7)
ktlint: 1.1.1
yamllint: yamllint 1.35.1
dart: Dart SDK version: 3.3.0 (stable) (Tue Feb 13 10:25:19 2024 +0000) on "linux_x64"
isort:
                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.13.2
eslint: v8.57.0
htmlhint: 1.1.4
sql-lint: 1.0.0
checkov: 3.2.26
lua: Lua 5.3.5  Copyright (C) 1994-2018 Lua.org, PUC-Rio
standard: 17.1.0
2024-04-01 14:46:51 [INFO]   --------------------------------------------
2024-04-01 14:46:51 [INFO]   Gathering GitHub information...
2024-04-01 14:46:51 [INFO]   RUN_LOCAL has been set to: true. Bypassing GitHub Actions variables...
2024-04-01 14:46:51 [INFO]   Successfully validated GITHUB_WORKSPACE: /tmp/lint
2024-04-01 14:46:51 [INFO]   The default branch for this repository is set to: master
2024-04-01 14:46:51 [INFO]   --------------------------------------------
2024-04-01 14:46:51 [INFO]   Validating the configuration
.git
2024-04-01 14:46:55 [INFO]   The master branch doesn't exist in /tmp/lint
2024-04-01 14:46:55 [INFO]   The origin/master branch doesn't exist in /tmp/lint

Steps To Reproduce
docker run --pull=always -e FILTER_REGEX_EXCLUDE="(\.pylintrc|migrations|.*\.xlsx|static\/bootstrap.*)" -e LINTER_RULES_PATH="/" -e IGNORE_GITIGNORED_FILES=true -e RUN_LOCAL=true -v "/Users/rleach/PROJECT-local/TRACEBASE/tracebase:/tmp/lint" "ghcr.io/super-linter/super-linter:slim-v6.3.0"

Anything else?
We just switched from slim-v4.x.x to slim-v6.3.0 and I haven't been able yet to get it to run locally.  I was running v4 locally for years on a nearly daily basis.  I'm on macOS.  I also had to stop using USE_FIND_ALGORITHM due to this bug.
It's quite possible there's something wrong in my setup, because another person on our team does not get this error and we're using the same command.  But either way, I cannot figure out what the issue is.

Figured out a work-around.  I just added -e DEFAULT_BRANCH=main to my command.

Hi @hepcat72 !
Auto-selecting the default branch works on GitHub Actions only, as you can see from the README by looking at the description of the DEFAULT_BRANCH variable. :)
Glad that you found a workaround.

There must be more to this though. My boss has a Linux laptop. His also says it selects the "master" branch, but his local linking runs do not fail with an error about the branch not existing. Could you explain what is going on there?

And I didn't have this issue in v4. Is this failure to lint and complaining about a non-existent branch a new behavior?

What's more is, the documentation gives an example of how to run locally, and that example says you should be able to run with a command, and that command does not include a setting of DEFAULT_BRANCH. Is that documentation outdated?


ENH Add gha-dispatch-release repo

Adds https://github.com/silverstripe/gha-dispatch-release
Issue

https://github.com/silverstripe/gha-ci/issues/137

Taking a different approach


Components "Invalid DOM property `class``?"

Found this while removing the background video from #6 (but this is unrelated as it happens in my master local branch). It seems to be suppressed on live.
Unless this is related to updated dependencies in the PR that addresses #6, which could someone please check against your own local master, I don't know what is up. Doesn't look like it is causing any issues, yet...

Didn't realize, this issue was created. Since the change was under 10 characters, I did it during the following commit: a63e7d5c60e0f69da14d87b9b4cb5aa6ec55e210. Although, I didn't realize it was only a local error which makes it worth exploring why JSX syntax equires className be used locally, but the live version is fine with HTML style  usage of"class" ,


Revision publishing gets stuck when ISCN registration is toggled

Tasks

[ ] Find the reason of publishing got stuck and fix it

References

Slack

should be fixed in #2890 together


Protocol tests issue 16

Description

This PR fixes DOTNET-7357 issue 16. Issue 16 Incorrectly capitalizing boolean values in headers for both rest-xml and rest-json protocol

(Review manual changes) commit b7eaa1febe7- Fixes for issue 16.
(Reference generated changes) N/A

MERGE into protocol-tests feature branch only
Builds on prior PR: https://github.com/aws/aws-sdk-net/pull/3268
Merge order: 114 (I'm going to start mine from 100 and increment to keep separate from Bo's)
Ticket: DOTNET-7357
Motivation and Context

Testing

N/A - the test cases are the protocol tests. A final dry-run will be done on the protocol-tests feature branch once everything is merged into the feature branch.
Screenshots (if appropriate)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have read the README document
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

This PR is not matching the commit for issue 16's change, I may have to wait for the others to be merged or something. Going to close this one for now.


add helm repo

see https://github.com/cubefs/cubefs-helm/pull/34

Can the following features be supported?

helm repo add  https://github.com/cubefs/cubefs-helm.git
helm install cubefs --version v3.3.2

Otherwise I don't know what version combination should be used.


nss build failure when using --zlib-compat (API incompatability?)

The Mozilla package nss (latest 3.47.1 release) builds against upstream zlib-1.2.11 but fails to build against latest zlib-ng 5bd3c582908503135fd8d6326ca0e2a6a947b44f with  --zlib-compat enabled:
/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.80-devel/toolchain/bin/host-gcc -o Linux4.4_x86_64_gcc_glibc_PTH_64_OPT.OBJ/zip.o -c -O2 -fPIC  -m64 -pipe -ffunction-sections -fdata-sections -DHAVE_STRERROR -DLINUX -Dlinux -Wall -Wshadow -Werror -DXP_UNIX -UDEBUG -DNDEBUG -D_REENTRANT -DNSS_NO_INIT_SUPPORT -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -I/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.80-devel/toolchain/include -I/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.80-devel/toolchain/include/nspr -I./../dist/Linux4.4_x86_64_gcc_glibc_PTH_64_OPT.OBJ/include -I./../dist/public/ -I./../dist/private/ -I/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.80-devel/toolchain/include/nspr -I../../dist/Linux4.4_x86_64_gcc_glibc_PTH_64_OPT.OBJ/include -I../../dist/public/ -I../../dist/private/ -I../../dist/public/nss -I../../dist/public/nspr -I../../dist/public/libdbm -I../../dist/Linux4.4_x86_64_gcc_glibc_PTH_64_OPT.OBJ/../public/security -I./include  -I/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.80-devel/toolchain/include/nspr -I../../../dist/Linux4.4_x86_64_gcc_glibc_PTH_64_OPT.OBJ/include -I../../../dist/public/nss -I../../../dist/private/nss -I../../../dist/public/seccmd  zip.c
zip.c: In function 'JzipAdd':
zip.c:325:28: error: passing argument 2 of 'handle_zerror' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
         handle_zerror(err, zstream.msg);
                            ^
zip.c:92:1: note: expected 'char *' but argument is of type 'const char *'
 handle_zerror(int err, char *msg)
 ^
zip.c:335:36: error: passing argument 2 of 'handle_zerror' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
                 handle_zerror(err, zstream.msg);
                                    ^
zip.c:92:1: note: expected 'char *' but argument is of type 'const char *'
 handle_zerror(int err, char *msg)
 ^
zip.c:368:32: error: passing argument 2 of 'handle_zerror' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
             handle_zerror(err, zstream.msg);
                                ^
zip.c:92:1: note: expected 'char *' but argument is of type 'const char *'
 handle_zerror(int err, char *msg)
 ^
zip.c:464:28: error: passing argument 2 of 'handle_zerror' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
         handle_zerror(err, zstream.msg);
                            ^
zip.c:92:1: note: expected 'char *' but argument is of type 'const char *'
 handle_zerror(int err, char *msg)
 ^
cc1: all warnings being treated as errors
make[3]: *** [../../coreconf/rules.mk:393: Linux4.4_x86_64_gcc_glibc_PTH_64_OPT.OBJ/zip.o] Error 1
make[3]: Leaving directory '/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.80-devel/nss-3.47.1/nss/cmd/signtool'
make[2]: *** [../coreconf/rules.mk:101: libs] Error 2
make[2]: Leaving directory '/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.80-devel/nss-3.47.1/nss/cmd'
make[1]: *** [coreconf/rules.mk:101: libs] Error 2
make[1]: Leaving directory '/home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.80-devel/nss-3.47.1/nss'

Tail end of build log: http://ix.io/22Pz
The following nss patch is a temporary workaround to build nss against zlib-ng (I think it works - I'm not a C-coder!) but presumably this nss change should not be necessary in --zlib-compat mode:
diff --git a/nss/cmd/signtool/zip.c b/nss/cmd/signtool/zip.c
index aeb5d6c..82f7ac5 100644
--- a/nss/cmd/signtool/zip.c
+++ b/nss/cmd/signtool/zip.c
@@ -89,7 +89,7 @@ my_free_func(void *opaque, void *address)
 }

 static void
-handle_zerror(int err, char *msg)
+handle_zerror(int err, const char *msg)
 {
     if (!msg) {
         msg = "";

This build failure is present when building nss for the x86_64 host (using the "system" zlib ie. zlib-ng), so it is not a cross-compile issue.
LibreELEC nss-3.47.1 build package: https://github.com/LibreELEC/LibreELEC.tv/pull/4022
LibreELEC zlib-ng test branch: https://github.com/LibreELEC/LibreELEC.tv/compare/master...MilhouseVH:le10_zlib-ng (depends on https://github.com/LibreELEC/LibreELEC.tv/pull/4023)

Forgot to mention, gcc is 9.2.0.

That code snippet is invalid and gcc is correct when it triggers an error. You can't assign string literal to non-const pointer as it would make non-local variable appear out of its scope.

Thanks but as I say, I'm not a C-coder and I just wanted a quick & dirty fix in order to progress the rest of the distro build (so that I could find any other issues, which I now have).
Obviously the ABI breakage is the bigger issue, and I've raised a couple of other issues along the same lines with other packages.
A github "ABI Break" label might be useful!

I'm just reiterating the reasons why there is some differences that we are unlikely to "unfix" even if that means our API is not 100% drop-in replacement. The rest might be fixed by people who are more familiar with the code.

gcc is triggering an error because z_stream.msg is const in zlib-ng, where it's non-const in zlib per default (unless ZLIB_CONST is set). That's arguably not zlib compatible even when using --zlib-compat.
As for the snippet, it's setting a non-const local pointer to a pointer somewhere in .rodata. That's not invalid. Also, it's mozilla, it compile tested on your toaster.

This makes me wonder why ZLIB_CONST is not set for stock zlib, probably another example of legacy code being used instead of the (slightly) more modern code.
We'll need to add some workarounds for compat mode, so compat mode uses zlib-compatible function definitions and types.

@dhewg The issue is in code lines:
if (!msg) {
         msg = "";

This is only valid when msg is "const char *" because in that case compiler makes sure the string literal is copied if the value is not overwritten when the scope exits the function.

@mtl1979 I'm not sure about invalid, maybe weird or oldschool ;) It's still accepted by C compilers (there's -Wwrite-strings to catch those). In any case, there's no string literals being copied, it's just a function-scope pointer assignment.
But back to the issue, nss could also just be fixed to make it ZLIB_CONST compatible?

@dhewg Converting string literals to "char *" is deprecated and as such invalid when using strict validation rules.

That I can agree with :D
Now zlib-ng has to decide if it want's to be compatible with that deprecated way (which is unfortunately the default for zlib) or if it want to be just ZLIB_CONST compatible.

zlib-ng clearly has limit for how old compilers we are going to support... That conversion has been deprecated since early gcc 4.x builds, so clearly far beyond what we have planned supporting... Currently we do not support any compiler older than 2013...

This should have been resolved in https://github.com/zlib-ng/zlib-ng/pull/704.


graylog: 2.4.3 -> 2.4.4

Motivation for this change
https://www.graylog.org/post/announcing-graylog-v2-4-4
includes security fix, please cherry-pick to release-18.03 :slightly_smiling_face:
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build graylog

Success on aarch64-linux (full log)
Attempted: graylog
Partial log (click to expand)
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-amd64-solaris.so
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-x86-freebsd-5.so
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-x86-solaris.so
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-ia64-hpux-11.sl
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-ia64-linux.so
shrinking /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/lib/sigar/libsigar-sparc-solaris.so
patching script interpreter paths in /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4
/nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4/bin/graylogctl: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4...
/nix/store/yd05llvfamccp6aqw06h6h0il8fbamrd-graylog-2.4.4

Success on x86_64-linux (full log)
Attempted: graylog
Partial log (click to expand)
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-amd64-linux.so
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-s390x-linux.so
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-ppc64-linux.so
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-sparc64-solaris.so
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-x86-freebsd-6.so
shrinking /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/lib/sigar/libsigar-x86-linux.so
patching script interpreter paths in /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4
/nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4/bin/graylogctl: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4...
/nix/store/gmn56cahv180z6zakmlf63ga4d7qb8hs-graylog-2.4.4

Success on x86_64-darwin (full log)
Attempted: graylog
Partial log (click to expand)
source root is graylog-2.4.4
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file graylog-2.4.4/plugin/graylog-plugin-threatintel-2.4.4.jar
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
patching script interpreter paths in /nix/store/jrgvwg5an63b5zss924rcvndixvcf9vf-graylog-2.4.4
/nix/store/jrgvwg5an63b5zss924rcvndixvcf9vf-graylog-2.4.4/bin/graylogctl: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/jrgvwg5an63b5zss924rcvndixvcf9vf-graylog-2.4.4

This package is missing a runtime dependency on jre:
$ ./graylogctl
which: no java in (/home/xxx/bin:/home/xxx/bin:/run/wrappers/bin:/etc/profiles/per-user/xxx/bin:/home/xxx/.nix-profile/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin)

Apparently graylogctl needs a wrapper with JAVA_HOME set to ${jre}.

@GrahamcOfBorg build graylog

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: graylog
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: graylog
Partial log (click to expand)
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-sparc64-solaris.so
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-amd64-freebsd-6.so
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-ppc-linux.so
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-ia64-linux.so
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-x86-freebsd-5.so
shrinking /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/lib/sigar/libsigar-x86-solaris.so
patching script interpreter paths in /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4
/nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/bin/.graylogctl-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4...
/nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4

Success on x86_64-darwin (full log)
Attempted: graylog
Partial log (click to expand)
source root is graylog-2.4.4
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file graylog-2.4.4/plugin/graylog-plugin-threatintel-2.4.4.jar
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
patching script interpreter paths in /nix/store/a6qlhmbcb9br8siws5x0cqminsgnvhjx-graylog-2.4.4
/nix/store/a6qlhmbcb9br8siws5x0cqminsgnvhjx-graylog-2.4.4/bin/.graylogctl-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/a6qlhmbcb9br8siws5x0cqminsgnvhjx-graylog-2.4.4

result/bin/graylogctl start
Starting graylog-server ...
/nix/store/7rzlmlgzvwpvappi16z3nzrk5l6m6yi6-graylog-2.4.4/bin/.graylogctl-wrapped: line 60: log/graylog-server.log: No such file or directory

Is the default LOG_FILE=${LOG_FILE:=log/graylog-server.log}  intended to be a relative path? This fails if the log directory doesn't exist.

@xeji: can we merge this anyway?
It has been this way since Graylog was included in nixpkgs. On NixOS is is not an issue as Graylog is usually used via the Graylog module.
If you feel strongly about it I will create a separate issue tracking this.

No problem, let's leave this as is if it doesn't hurt.


Consider logging item adds/removes during evaluation

This issue https://github.com/KirillOsenkov/MSBuildStructuredLog/issues/113 brings up a point: items added and removed during evaluation are not logged, so the log doesn't have any trace of it.
We should consider logging item removes (not sure if logging item adds is valuable because items added and not removed are logged per project).
I'm on the fence but I think triage should discuss and consider.

Yeah, that's an interesting one. One wrinkle is that removes aren't necessarily "removed" as in added and then removed, thanks to lazy item evaluation. That collapses
<ItemGroup>
  <X Include="*.cs" />
  <X Remove="*.xaml.cs" />
</ItemGroup>

into basically
<ItemGroup>
  <X Include="*.cs" Exclude="*.xaml.cs" />
</ItemGroup>

In the OM, items are annotated with the XML element that caused them to come about. Maybe we could  add something similar to the binary log format?

Good idea. I've opened a new issue to track that work:
https://github.com/Microsoft/msbuild/issues/2473


BAU: Fixes task role kms key permissions

Jira link
BAU
What?
I have added/removed/altered:

[x] Added kms key for persistence

Why?
I am doing this because:

This is needed to be able to persist files as part of daily updates

@willfish we probably want to merge this now otherwise we'll block main.


Non-responsive behavior in semantics(input fields)

Hey, I have input fields that do not behave like they should.
I defined them within a form and gave them xx wide field attributes, but instead of having both the label AND the input field to be shrinked accordingly, only the input field is being shrinked when I make my screen smaller.
My video shows how the input is reduced into a very small field, instead of shrinking BOTH the label on the left hand side and the input. Also my modal steps in the modal header dont work as they should, as the icons get out of their position.
Thanks in advance.
In the video you see the input field having the correct size, but then when shrinking the window, the field gets way too small, while the label on the left hand side keeps its size.

Opprett forslag

                                        <button class="ui teal labeled icon button">

                                            Leverandør
                                        </button>
                                        <input type="text" placeholder="Søk leverandør" id="txtbxSupplierModal" />

                                    <button class="ui teal labeled icon button">

                                        Ordretype
                                    </button>

                                    <select class="ui search dropdown">
                                        <option value="">State</option>
                                        <option value="AL">RE</option>
                                        <option value="AK">LO</option>
                                    </select>

                                <button class="mini ui button">

                                    Ny
                                </button>

Can you create a JSFiddle  to replicate the issue?


Endpoint treated as unprotected resource

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Important: Please fill in your exact version number above, e.g<EMAIL_ADDRESS>Framework
Description
The endpoint is treated as unprotected resource and the token is not attached
 getScopesForEndpoint(endpoint) {         if (this.msalConfig.framework && this.msalConfig.framework.unprotectedResources) {             this.getLogger().info("msalConfig.framework.unprotectedResources is deprecated, use msalAngularConfig.unprotectedResources");         }         // if user specified list of unprotectedResources, no need to send token to these endpoints, return null.        => const isUnprotected = this.isUnprotectedResource(endpoint);         if (isUnprotected) {             return null;         }
Error Message
Security

[ ] Is this issue security related?

Regression

[ ] Did this behavior work before?
Version:

MSAL Configuration
 MsalModule.forRoot({       auth: {         clientId: 'c607918f-57a3-4fb0-a9a8-57e632320f66', // This is your client ID         authority: 'https://login.microsoftonline.com/bff885d4-2f3a-409f-9b5f-a78b659f192d', // This is your tenant ID         redirectUri: window.location.origin,         //redirectUri: 'https://jwt.ms',       },       cache: {         cacheLocation: 'localStorage',         storeAuthStateInCookie: isIE, // Set to true for Internet Explorer 11       },     }, {       popUp: !isIE,       consentScopes: [         'api://36fa87ac-27cc-43fa-ab4a-02151effb2c4/api-access',         'user.read',         'openid',         'profile',       ],       unprotectedResources: [],       protectedResourceMap: [         ['http://localhost:8080/api/echo',['api://36fa87ac-27cc-43fa-ab4a-02151effb2c4/api-access']],         ['https://graph.microsoft.com/v1.0/me', ['user.read']]       ],       extraQueryParameters: {}     })
// Provide configuration values here.
// For Azure B2C issues, please include your policies.

## Reproduction steps
```js
// Provide relevant code snippets here.
// For Azure B2C issues, please include your policies.

Expected behavior
Token should be attached when calling http://localhost:8080/api/echo
Browsers/Environment

[x ] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari
[ ] IE
[ ] Other (Please add browser name here)

Hi,
sorry. It was obviously my fault. It works now. There must be a guard defined for the route. Then the token will be attached.


⚠ Secret Website 3 has degraded performance

In d04cabd, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 1967 ms

Resolved: Secret Website 3 performance has improved in bc0ff4b.


add displayName to components on left side

This makes it a little easier to figure out which documents
go in which section on the left.

This is failing the usual DataFlow test. I'm not going to bother rerunning it because the change seems harmless to me.
We are running React 17 so it is safe to use .displayName = .... We do this in other components that use the mobx-react observer( wrapper.
This section of the mobx docs spells out several options of which this is one:
https://mobx.js.org/react-integration.html#displayname

@kswenson yes I've seen those comments about avoiding React.FC. I found this though: https://tinytip.co/tips/react-vfc/ so I think either using VFC in React <18 or just sticking with FC in >= 18 seems OK to me. But I guess that can all be skipped when we don't need to set the displayName.  I do kind of like the displayName approach over all of the others in the mobx-react docs since it is more obvious what the purpose is.


feat: refactor plexamp package, add support for darwin aarch64 and amd64

Things done
Added aarch64 and x86_64 plexamp packages for darwin. Not sure if this is release notes worthy so omitted for now.

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin (rosetta)
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@Synthetica9 or @killercup, you have time to review?


deps: update @camunda/form-linting to v0.2.1

Related to https://github.com/camunda/camunda-modeler/issues/3361

✅


[Task]:  Create custom environment variable, not bound to any datasources

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

create endpoint for environment variable creation

@sribalajig we will tackle this in datasource environments 2.0


Fix a crash when resolving overloads of C++ virtual methods

The isOverload() method needs to account for situations where the two
methods being compared don't have the same number of arguments.
rdar://problem/39542960
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@330450 91177308-0d34-0410-b5e6-96231b3b80d8
(cherry picked from commit 53113aaa3194cd8dbfa106ad9460e124db6f2570)

@swift-ci test and merge


cuda10 is not compatible with torch below 1.0

Dear author:
I want to ask that if your code run at cuda10?
If can't, should I change your code to torch1.0,or change my cuda to lower version?
Thank your for you work! Looking forward to your reply！

Great!

I have successfully run the code with cuda 10

May I ask you which version of pytorch have you installed ?

I have successfully run the code with cuda 10

Please let us know what are the configurations you used to run it on cuda 10

I have successfully run the code with cuda 10

Could you give us the configurations you use? Thank you ahead!

My solution is (with cuda10.1):

rm -rf build
mkdir build && cd build
cmake -D CUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda ..
make

My solution is (with cuda10.1):

rm -rf build
mkdir build && cd build
cmake -D CUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda ..
make

@Holycomfort
Can you let me know your python version?
I got this error

raise ImportError("torch.utils.ffi is deprecated. Please use cpp extensions instead.")

my configuration is
cuda : 10.0.110
torch : 1.4.0
python : 3.7.10
conda : 4.8.3
thank you.

@crazy-bot

I have deleted the conda environment. As far I remember it was pytorch 1.3.1

hello, did you have any problem with using torch 1.3.1 related to ffi error?
i got this error

Traceback (most recent call last):
File "/home/ygkim/point_cloud/Relation-Shape-CNN/utils/build_ffi.py", line 4, in
from torch.utils.ffi import create_extension
File "/home/ygkim/anaconda3/envs/rscnn4/lib/python3.7/site-packages/torch/utils/ffi/init.py", line 1, in
raise ImportError("torch.utils.ffi is deprecated. Please use cpp extensions instead.")
ImportError: torch.utils.ffi is deprecated. Please use cpp extensions instead.

people tell me that this error comes from torch version mis-match. they say we should use torch version 0.4.1...
how did you do it?

@pixar0407 Have you solved this problem?

raise ImportError("torch.utils.ffi is deprecated. Please use cpp extensions instead.")

I also encountered the same error


FEATURE: Command Line Args

When running gulp I want to be able to specify a specific version/type via the cli

Support for --version
Support for --type

As per #26:

Due to plugin guidelines, I will not be adding the args to the plugin.
You can add them into your gulpfile and parse accordingly.
https://stackoverflow.com/questions/4351521/how-to-pass-command-line-arguments-to-node-js

There is however now #35 which allows you to easily use gulp-prompt also.

Thanks @Kingdutch


Cancel Annotation

If you cancel an annotation through the UI, it leaves the draw rect on the canvas.
To reproduce ~ Draw new annotation, Editor Shows, Press Cancel button, annotation remains on screen.

Yes, that’s a bug/known issue, sort of. (Or at least a consequence of the AnnotationLayer class being unfinished :-)


Bug on a form with multiple FileUpload fields.

Describe the bug
In a form try to add multiple different FileUpload fields, in the database when we upload files/pictures everything is fine ( Files url's are correct ).
But on preview ( edit ) mode, the latest uploaded file is being shown for all FileUpload fields.
To reproduce
Steps to reproduce the behavior:

Go to a form where there is multiple FileUpload Fields
Fill theses fields with files/pictures
Go to edit record or refresh the page
You can see the latest uploaded file is on all the fields.

Expected behavior
Each field of type FileUpload has his own uploaded file.
Context

Package version: 1.8.1
Livewire version: 2.3
Laravel version: 8.34
Browser: Chrome

@danharrin Are the fixes for multiple file uploads in the latest release?

@danharrin
@ryangjchandler Ow it's been fixed in the latest release, my bad.


Geiser's eval-last-sexp doesn't give any useful error messages on failure

Evaluating an undefined variable or a syntax error doesn't give any error messages at all. Loading the same in the repl behaves as expected.
I'm using version 20170704.1044 from elpa. Emacs 25.2.1 with Spacemacs. Petize Chez 9.4.1

I think my last pr fixes this.

what scheme? how are you starting geiser? have you an example of what
you are evaluating? how are you evaluating it (what keyboard shortcut,
if any)? what do you see in the log buffer that pops-up after
C-u M-x geiser-show-logs (and the perform the evaluation)?  does
evaluating a valid expression work?
thanks.

Chez 9.4.1
I use C-c C-z to start the repl usually , bound to switch-to-geiser
Example I'm evaluating (+ 1 1), I see => 2 in the modeline. Evaluate (+ 1 a) without defining a, I see nothing in the modeline. No error is reported. I use geiser-eval-last-sexp for this bound to , e e (spacemacs).
This is what I have in the logs.

INFO: REQUEST: <1>: (begin (import (geiser)) (write `((result ) (output . ""))) (newline))
INFO: RETORT: ((result) (output . ""))
INFO: <1>: processed

M-x geiser-version says<EMAIL_ADDRESS>But I see (define-package "geiser" "20170827.1755") in geiser-pkg.el.

I have tested and reproduced the problem. should be a bug. I will fix it.

@ChaosEternal I notice the same behaviour. Echoing the output to minibuffer on success as well as failure is probably what we need.

I think I cannot just simply patch the geiser-mode.el since it is a chez specific problem.
I guess the root cause is that the geiser-chez.el does not have display-error defined.

After comparing geiser-chez.el and geiser-guile.el, I am now pretty sure that lack of display-error in geiser-chez.el is the root cause.
Finding out the root cause is one thing, but fixing it is a big story.
I need to investigate how error handling and debugging work in geiser and maybe it is needed to complete the geiser-chez.el.
keep tuned.
for a quick  fix,
use this patch:
modified   elisp/geiser-chez.el
@@ -103,6 +103,11 @@ This function uses geiser-chez-init-file' if it exists."      (compilation-setup t)      (geiser-eval--send/wait "(begin (import (geiser)) (write ((result ) (output . ""))) (newline))")))

+
+(defun geiser-chez--display-error (module key msg)

(and key (message key) key))

;;; Implementation definition:
(define-geiser-implementation chez
@@ -120,7 +125,7 @@ This function uses `geiser-chez-init-file' if it exists."
(exit-command geiser-chez--exit-command)
(import-command geiser-chez--import-command)
(find-symbol-begin geiser-chez--symbol-begin)

;; (display-error geiser-chez--display-error)

(display-error geiser-chez--display-error)
;; (external-help geiser-chez--manual-look-up)
;; (check-buffer geiser-chez--guess)
;; (keywords geiser-chez--keywords)

@@ -103,6 +103,11 @@ This function uses `geiser-chez-init-file' if it exists."
     (compilation-setup t)
     (geiser-eval--send/wait "(begin (import (geiser)) (write `((result ) (output . \"\"))) (newline))")))

+
+(defun geiser-chez--display-error (module key msg)
+  (and key (message key) key))
+
+
 ;;; Implementation definition:

 (define-geiser-implementation chez
@@ -120,7 +125,7 @@ This function uses `geiser-chez-init-file' if it exists."
   (exit-command geiser-chez--exit-command)
   (import-command geiser-chez--import-command)
   (find-symbol-begin geiser-chez--symbol-begin)
-  ;; (display-error geiser-chez--display-error)
+  (display-error geiser-chez--display-error)
   ;; (external-help geiser-chez--manual-look-up)
   ;; (check-buffer geiser-chez--guess)
   ;; (keywords geiser-chez--keywords)

@jaseemabid use the patch in PR #220 , this version avoids a geiser-debug window from opening.

@jaor with PR #220 , I think this issue is resolved. I suggest we close this issue and open another feature requesting issue addressing the debug functionality of chezscheme support.


Update dependencies.

Including going to tsdb 0.7.0.
Signed-off-by: Brian Brazil<EMAIL_ADDRESS>

:+1:


Added more information to command history analyzer

Added some more aggregated information about your command history
# Totals

Command count: 53863
Days usage: 166
Average commands / day: 324
Commands with hats: 8592 (0%)

Checklist

[/] I have added tests
[/] I have updated the docs and cheatsheet
[/] I have not broken the cheatsheet

i haven't read the PR, but that percentage looks off to me 😄

i haven't read the PR, but that percentage looks off to me 😄

Oh I forgot to multiply with 100 of course :D

fixed

I'm not happy! :D
You're now incrementing decoratedMarkCommandCount for every decorated target. The reason I had it the way it was before is that I only want to increment it per command as the name suggests.


Unable to perform symmetric decryption when --encryptor.type=EC flag is used and the private key is locked with a password.

Tessera fails to perform symmetric decryption on a locked private key when the --encryptor.type=EC flag is used.
Steps to reproduce:

Create a keygenconfig.json file with the following parameters:

{
"encryptor": {
    "type":"EC",
    "properties":{
        "symmetricCipher":"AES/GCM/NoPadding",
        "ellipticCurve":"secp256r1",
        "nonceLength":"24",
        "sharedKeyLength":"32"
    }
  }
}

Execute the following command to create the password.txt file:

nodePassword=password
echo -e "$nodePassword\n$nodePassword" > password.txt

Execute the following command to generate the tessera node keys:

java -jar /path-to-tessera.jar/tessera.jar --encryptor.type=EC -configfile keygenconfig.json -keygen -filename tm < password.txt

After starting the Tessera node the following message is appeared in the log files:

Software Versions:
Java Version: openjdk version "11.0.10"
Tessera Version: 21.1.1
OS: Linux Ubuntu 20.10 Groovy 5.8.0-45-generic

Please use the command line to pass all the encryptor parameters:
java -jar tessera.jar -keygen --encryptor.type EC --encryptor.ellipticCurve secp256r1 --encryptor.symmetricCipher AES/GCM/NoPadding --encryptor.nonceLength 24 --encryptor.sharedKeyLength 32 -filename tm < password.txt

The quorum-examples scripts will be updated shortly.


Add Azerbaijan University of Economics

@nazir92 First stage of verification passed, official domain is unec.edu.az as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


add .pub-cache back to .gitignore

Fixes https://github.com/flutter/flutter/issues/128635
In https://github.com/flutter/flutter/commit/1fd84f88e915427c88fb1d38c052150c76e27b4f, we renamed the .pub-cache entry in the .gitignore file to .pub-preload-cache, and ensured the packaging script was now populating that directory. However, for users who already had this directory from downloading an earlier archive but used flutter upgrade to get the latest code, they now had a .gitignore file that was no longer ignoring their .pub-cache directory.
Now, when these users try to flutter upgrade again, the tool tries to verify if their checkout is clean, and will exit early if not directing the user to either stash or commit these changes, or do flutter upgrade --force which will try to update their branch anyway (and which would succeed since there would be no git conflict). These change adds back the .pub-cache entry to .gitignore, which won't retroactively fix broken releases, but will at least ensure if they flutter upgrade --force once to get this fix, they won't need to again.

test-exempt: configuration change
but bonus points for actually testing it. obviously the simple test is just literally checking the file contains what you expect, but the more elaborate test would be checking that the scenario you describe works as expected.

test-exempt: configuration change
but bonus points for actually testing it. obviously the simple test is just literally checking the file contains what you expect, but the more elaborate test would be checking that the scenario you describe works as expected.

I considered writing a test, but I'm not sure there would be much value. I'm not too worried about .pub-cache in particular regressing, ideally I would have a test that verifies we never remove anything from .gitignore, only add things (with a special allow-list for special cases where handle deleting the file from checkouts before/after upgrading).
However we don't currently have infra for seeing the diff associated with the current PR (we can't check the current commit because there may be multiple commits in a PR, and the HEAD commit may not have the offending change).

the more elaborate test would be checking that the scenario you describe works as expected.

This would be difficult to do. Ideally you would download a prebuilt archive and then flutter upgrade to the current commit you're testing, but then that feature branch commit won't exist upstream. And I think doing something like git remote add ... is a bad idea, and would break, as it's quite complicated all the places we fetch commits from across our CI processes.
Also we'd have the problem of which older archive to grab. The perfect test would grab all published release archives ever and ensure they can successfully upgrade to the commit under test.

Would it be worth adding a comment to the .gitignore cautioning against about removing entries?

See previous comment (I forgot to mark it as a review)

Done

In https://github.com/flutter/flutter/commit/1fd84f88e915427c88fb1d38c052150c76e27b4f, we renamed the .pub-cache entry in the .gitignore file to .pub-preload-cache

Just a small correction for later context. This was not a rename:

The FLUTTER_ROOT/.pub_cache was an actual pub cache that flutter pub would use
The .pub-preload-cache contains package archives, and on first run they are extracted to the user-level pub-cache (eg ~/.pub_cache on mac).

In 1fd84f8, we renamed the .pub-cache entry in the .gitignore file to .pub-preload-cache

Just a small correction for later context. This was not a rename:

The FLUTTER_ROOT/.pub_cache was an actual pub cache that flutter pub would use
The .pub-preload-cache contains package archives, and on first run they are extracted to the user-level pub-cache (eg ~/.pub_cache on mac).

Understood. I meant the effective change to the .gitignore, but I should have been more clear.


feat(doc): Clarify the duty of maintainers and committers

Motivation

Clarify the duties of maintainers and committers. Normally, one maintainer can only focus on a specific domain.
Types of changes

[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Bugfix (non-breaking change which fixes an issue)
[x] Documentation Update (if none of the other choices apply)
[ ] So on...

Verifying this change

[x] Make sure that the change passes the testing checks.

This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

This can be verified in development debugging
This can be realized in a mocked environment, like a test cluster consisting in docker

(or)
This change MUST reappear in online clusters, or occur in that specific scenarios.
Does this pull request potentially affect one of the following parts:

[ ] Master
[ ] MetaNode
[ ] DataNode
[ ] ObjectNode
[ ] AuthNode
[ ] LcNode
[ ] Blobstore
[ ] Client
[ ] Cli
[ ] SDK
[ ] Other Tools
[ ] Common Packages
[ ] Dependencies
[ ] Anything that affects deployment

Documentation

[x] doc
[ ] doc-required
[ ] doc-not-needed
[ ] doc-complete

Review Expection

[x] in-two-days
[ ] weekly
[ ] free-time
[ ] whenever

Matching PR in forked repository

PR in forked repository:

+1

+1

+1

+1

According to the voting results from pull request https://github.com/cubefs/cubefs/pull/3430, the current pull request has the same content. We will merge it directly without waiting for 2 weeks.

+1


Update Go to 1.16.12

Is this something we want only on MacOS? We seem to use 1.16.7 everywhere else.

There's a PR on the datadog-agent repo (& on the builders repos) to also update the Go version there.


SimpleSchema.oneOf Issue (simple example included)

Below is the example case. If I un-comment type: FirstSchema and comment out the next line, no error is produced. Thus: when the type is specifically FirstSchema there is not error but if the type is oneOf a list that includes FirstSchema, an error is produced, which is not the intent of oneOf (unless my understanding is mistaken). Shouldn't oneOf test for String, then Number, then FirstSchema, and pass once it tests FirstSchema to be a match?
// Import
import SimpleSchema from 'simpl-schema';

// Instantiate
Test = new Mongo.Collection('test');

// Define Schema
ZeroSchema = new SimpleSchema({
	zeroAlpha: Number,
	zeroBravo: Number
});
FirstSchema = new SimpleSchema({
	firstAlpha: String,
	firstBravo: String
});
SecondSchema = new SimpleSchema({
	secondAlpha: String,
	secondBravo: {
		//type: FirstSchema,
		type: SimpleSchema.oneOf(String, Number, FirstSchema, ZeroSchema)
	}
});

// Attach Schema
Test.attachSchema(SecondSchema);

// Sample Data
myData = {
	secondAlpha: "test",
	secondBravo: {
		firstAlpha: "test",
		firstBravo: "test"
	}
};
Test.insert(myData); // Error: secondBravo.firstAlpha is not allowed by the schema

Also interesting note: if I do type: SimpleSchema.oneOf(String, Number, FirstSchema), i.e., remove the ZeroSchema part, it validates/inserts successfully.

Migrating to node-simple-schema.


Underflow error when using GPU memory overhead

What is the issue?
GPUs:

AMD RX 6800 XT (16 GB VRAM)
NVidia GTX 970 (4 GB VRAM)

I have discovered a very odd and very dangerous problem in ollama. I am running OpenWebUI on a machine that has a ROCm device (main GPU; 16 GB VRAM) and a CUDA device (ancient old NVidia GPU). The NVidia GPU has 4 GB of VRAM and I use it as a secondary GPU for small models like embedding, etc.
I'm using the CUDA variant of the OpenWebUI docker image, which it allows to run vector search re-ranking models on CUDA. This loads the reranking model (BGE reranker in my case) onto the Nvidia GPU.
All of this is fine and dandy. But the problem comes when ollama tries to run the actual main LLM I'm using (Qwen2.5 14b q5_K_M in this case).
For some reason, it seems to completely skip choosing the ROCm GPU as the GPU to load the model on, and tries to load it on the CUDA device, which promptly fails. It doesn't even fall back to CPU. This persists through restarts of ollama. No matter what, it will not consider the AMD GPU or CPU for loading any LLM, and essentially renders OpenWebUI non-functional.
I've narrowed it down to OpenWebUI loading the reranker model on the CUDA device. If OpenWebUI is shut down, everything starts working fine again in ollama. Everything also works fine in OpenWebUI until it loads the reranker model.

But presumably this isn't specifically because of OpenWebUI. I imagine it would happen with anything external to ollama that takes over the CUDA device.

I can provide debug logs if necessary.
OS
Linux, Docker
GPU
Nvidia, AMD
CPU
AMD
Ollama version
0.5.1,0.4.7

Logs are necessary.

ollama-debug-log.txt
Logs are attached. At first you can see it running the BGE embedding model on the NVidia GPU, and Qwen2.5 (Acree Supernova, to be more specific) on the AMD GPU. But then it starts trying to load Qwen2.5 on the CUDA device repeatedly.

Few more details on this: rocm-smi reports that VRAM is emptied after the model stops, so it's not like the main GPU is full. At least not on the hardware itself. Dunno what ollama thinks.

Well, 16k exabytes sounds like it would definitely be enough space to load a language model. :thinking:
I updated the title of the bug for easier searching. Thanks for figuring it out! For now I've disabled the memory overhead and things work much better (at least until I run into context errors, which is why I had the overhead set in the first place).


PostgresML Auto Configuration

This pull request adds AutoConfiguration for PostgresML.
Checklist:

Sign the contributor license agreement ✅
Rebase your changes on the latest main branch and squash your commits ✅
Add/Update unit tests as needed ✅
Run a build and make sure all tests pass prior to submission ✅

Fixes #242

Added @AutoConfiguration(after = JdbcTemplateAutoConfiguration.class), copyright headers and updated to recent changes to embedding api (now implementing the core 'model' abstract API classes).
Thanks you very much!

merged in usrivastava92-postgresml-auto-configuration


Aid packages should be bundled based on the supplier

Is your feature request related to a problem? Please describe.

When creating aid packages should be bundled based on the supplier

Describe the solution you'd like

Bundle the aid packages based on the supplier

This is the correct behaviour


End to end test flow

@seren Is this branch intended for merging? I see references to sandbox, for example, so perhaps this got pushed to Github for safekeeping.
If this is intended for merging, I'll pull in the rest of the team for review.

Yes, but it's a bit out of date. Let me merge in the changes and rebase.

I think this is ready for review.

Adding the Automate team for review.


Sometimes uploads fails or queued, then don't upload.

Summary:
Our friend John Lubbock says, "I wonder if you know why when I upload photos on the Commons app, sometimes they say 'Failed' or 'queued', and don't upload?".
Device and Android version:
Samsung S9+
Commons app version:
2.8.2
Screen-shots:

Would you like to work on the issue?
^_^ no.

Where did John post, @neslihanturan ? I'd like to ask him about the method he used to upload (Nearby? Share? etc)

I asked same question too, will update once the answer comes. He asked from twitter, I don't think he has a github account.

He said contributions were from main screen.

Could you point us to the conversation on Twitter please?

Sorry, I'm not familiar with Twitter and didn't know you could send private messages on it - I thought he tweeted it, haha. If it's a private message then never mind. Could you ask him how often it happens for him, and if the queued pictures ever succeeded? Also, he has confirmed he is on 2.8.2?

Yes he confirmed he is on 2.8.2 with about page screenshoot.
He said uploads don't succeed afterwards.
He said sometimes.

Yann posted in beta feedback:

Some files stay in the queue. I can't upload or remove them, except by uninstalling the application. File chosen from the gallery on Android. It happens repeatedly if a file already exists with the same name. AFAIK it only happens from 2.8. It happens even if I upload one file at a time.

Do you think the changes that we made to file uploads in 2.8 might be the culprit? @neslihanturan could you please ask John if he has a rough idea of when the problem started for him?

Wanted to bump this issue as we have another report on google groups:
Picture just ends up as queued.

The only thing shown is the file name all the other items are blank even though I filled them in. Anyway the whole app doesn't work here on Android 8.0. Bye.

I guess the main question at the moment is whether this issue can conceivably be solved in a reasonable time before our upload backend overhaul in next year's PG proposal. It seems to be a high priority issue, but we are already behind on all of our deadlines.

Yann has informed me that v2.8.4 does not solve this problem for him. I have been talking to Jim Henderson, who reports a similar issue with queued uploads.
@neslihanturan , after you are done with your main UI PR, could you please go through your PR with the file upload changes, and see if anything that you changed could have caused this?
I suggest you try with an Android 8.0 or 8.1 emulator. So far all of the reports appear to be from that version. I just need to confirm with Jim about his Android version

FYI my Android version is 7.1.1, and it is the latest update on my J5. Thanks for trying to fix this, it is rather annoying.

@Yannf Thanks for chiming in! Could you please elaborate on what you mean by "first picture in a series", by detailing the steps you take and the results? E.g.

Open app, tapped gallery button, select picture, enter title/desc etc. Picture ends up queued forever.
In app, tapped gallery button again shortly after that and selected another picture, entered title/desc. Picture upload succeeds

So on and so forth?

If I upload several pictures successively, usually only the first fails. And it seems the App crashes (it closes without warning).

@misaochan Will take this up

I was actually trying to debug this issue on Google Pixel. Seems like something is wrong with the api's.
So the issue is that while trying to upload an image from google photos app, (ie. share photo). Although the MIME type received in the intent is jpeg for which we send jpg to our backend, we get an error response <?xml version="1.0" encoding="UTF-8"?> <api servedby="deployment-mediawiki-09">    <error code="verification-error" info="File extension ".jpg" does not match the detected MIME type of the file (image/png).">       <details>          <detail>filetype-mime-mismatch</detail>          <detail>jpg</detail>          <detail>image/png</detail>       </details>       <docref xml:space="preserve">See https://commons.wikimedia.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce&gt; for notice of API deprecations and breaking changes.</docref>    </error> </api>
which states that it was expecting png while we sent the file as jpeg. I tried hard coding the image extension to png and the upload succeeded [Shocking]. I could add an exception where in I could check if the photos are uploaded from google photos make them png by default. Doesnot seems right but would fix the upload fail cases from google photos. Also, from the code i can conclude that this should be happening since quite a while as say the comments as well, TODOing to add fix for uploads via Google Photos,. @misaochan @neslihanturan  What do you guys suggest ?

Actually not a backend bug, Although in the image info, Google Photo shows that the image is png but while sharing it, in the intent it shows that the image is jpeg and hence our backend rejects that because of which the upload fails

@ashishkumar468 thanks for digging it! I think you are very close since we recently implemented some changes about file extensions. We convert some extensions to .jpeg or .jpg (I am not really sure but can check).

@neslihanturan Yes, we convert jpeg to jpg  but that is not causing any trouble. The issue is that google photos app is giving the mime type for png images as jpeg which is causing the api to fail.

Hi,
On Tue, 9 Oct 2018, 00:29 Ashish Kumar<EMAIL_ADDRESS>wrote:

@neslihanturan https://github.com/neslihanturan Yes, we convert jpeg to
jpg but that is not causing any trouble. The issue is that google photos
app is giving the mime type for png images as jpeg which is causing the api
to fail.

But it only happens sometimes, and it seems in specific circumstances.
Yann Forget

@Yannf Yes and that is what is causing the api's to fail at least in my case. AFAIK, upload does not fail always, right ?

No, not always.
I checked my software. I am using the default Gallery application version
<IP_ADDRESS> on Android, in case it matters.
Yann Forget
On Tue, 9 Oct 2018, 00:36 Ashish Kumar<EMAIL_ADDRESS>wrote:

@Yannf https://github.com/Yannf Yes and that is what is causing the
api's to fail at least in my case. AFAIK, upload does not fail always,
right ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/1878#issuecomment-427946212,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFfmLT7K9jfqibJKUdJ30HuBcJgYLJQCks5ui6IwgaJpZM4WY5aT
.

@Yannf  and the uploads are failing in that as well ?. It would be great if you could attach the logs ?

@misaochan  The main job would be to validate the file extension somehow locally. As I have mentioned earlier, even if the extensions are png google photos are giving the MIME type as jpeg. We will have to figure out a way to validate file extensions. Apart from this indefinite  progress in notification failed uploads, happening on my device due to the same reason and also faced by Jim as well would be resolved if we are able to add a patch for this.

Yes, we certainly need to check the file extension locally. I would be surprised if the error lies in the Google Photos API though, as I haven't been able to find any reports of that. I would have thought that it is our app erroneously assigning the MIME type as .jpeg, due to the hack I mentioned above.

@misaochan  @neslihanturan  I have added a fix for MIME type detection, although could not find a logical bug in the method which actually attaches the extension. Although the flow needs to be refactored a bit which we can take later on. Seems like this will add a fix for the image extension issue. Raising a PR for the same

Had a basic question although , do the releases not go through master branch, as I could conclude from the thread that the issue went through the branch 2.8-release. If so, which branch am I supposed to make the PR to ? I had solved the issue on a branch cut from 2.8-release. Do I need to do it from master. It would be great if some one could clarify the same


documentation: add browser compatibility

We should know into the main readme the brower comatibility :D

Would be great! I duplicated it in #693 (sorry)


Updating node doesn't update node

When updating the nodes in the graph (e.g. removeNode, assignCallbackNode), the node doesn't get updated since the original node is already in the trash.

This issue has been fixed in MIVisionX-Conformance branch. Tot will also be fixed when openvx 1.3 is ready.


(repost-ish) card viewing

to view their collection, a user would use !collection and the bot would spit out a list of their cards formatted like
(card name) (card ID) with each card in its own line. in use something like Name Here (and other naming stuff) [IDtag]
to view a card in their collection, a user would use !view <card ID>
if they have that card in their collection, then same sort of display as the way the !draw commands shows cards (with name, id, embed)
if they don't bot would say smthn like @user, you don't have that card in your collection!

since collections will probably end up getting very long, perhaps some sort of thing with the embed where you can scroll through pages? like maybe a limit of 9 cards per page (simulating a trading card holder page), then you use a reaction to scroll back and forward different pages

Current progress:

!view command added
Bot outputs working embed
Embed color and picture are selected from the first card in the database

To-Do:

Add ability to view specific card ID
Add pages for easier viewing

Feature finished.
!view- view cards in user's collection
!cardview- display cards in server database
!cardview  - displays specific card


xenos should be able to eject people from hypersleep pods

people are abusing them to stall the round

they could before the blacklist pr

alternatively people in cryopods should not be counted for round end (or they should be instantly deleted by the cryopod)


Showing tooltip removes space between trigger s

In some code that is inside an HTML table if you have two spans with tooltips separated with an space, after the tooltip is shown in the first word the space is lost.
In this example John Doe, after show the tooltip in John you see JohnDoe.

This is javascript that we use for tooltips
$('.signtul-keyword').tooltip({ 'placement': 'bottom'})

This is the HTML

John Doe

This is the Css
.signtul-keyword:hover {
    background-color: #cccccc;
}

You might think why we have that complicated HTML but this is not in our control. This is a field the user can change so we should expected code disorder like this.
Any idea about why the Tooltip does not work in this HTML and how can we fix it?

JS Bin of the example: http://jsbin.com/moqimo/2/edit
Confirmed in Mac Chrome.

Hi @cvrebert!
You appear to have posted a live example (http://jsbin.com/moqimo/2/edit), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 19, column 87: The width attribute on the td element is obsolete. Use CSS instead.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Without obsolete width attribute: http://jsbin.com/catisi/1/edit

This is also an issue with any inline-block elements separated by space.

The problem derives from from the fact that the tooltip div is inserted right next to the hovered element - in this case span which is an inline element. This breakes HTML for some browsers and may distort displaying inline elements as well.
I see two solutions here:

usage of   is sufficient
modification of bootstrap's Tooltip.show() function - instead of inserting it next to the element:
this.options.container ? $tip.appendTo(this.options.container) : $tip.insertAfter(this.$element)
it could be inserted e.g at the end of the document:
this.options.container ? $tip.appendTo(this.options.container) : $("body").append($tip)

It's also sufficient to add display: inline-block; to this target span:
http://jsbin.com/zicire/2/edit

Yeah, I'm fine punting on this given the inline-block solution and that this is just how HTML handles the white spaces between elements. Also giving thought to, in v4, changing from JS-based tooltips to only CSS-based ones. Might avoid some of this, but who knows.

@peterblazejewicz @mdo As I said an HTML solution is not valid because the HTML is managed by the user.

And does the container option not help at all?

@mdo can you explain me a littel bit more about the `container' option? Is in the HTML or modifying the JS fo Boostrap?

@ricardopolo the problem is that content is added/replaced as is - within your elements as explained - try to attach tooltips to a most parent container of your text and see difference, using your sample:
$(function () {
  $('.signtul-keyword').tooltip({ 'placement': 'bottom', 'container': 'table'});
});

@peterblazejewicz options works!!!! Thank you.
But... the HTML is not controlled by me, so in some ocassions it is not inside a table.
Using
 $('.signtul-keyword').tooltip({ 'placement': 'bottom', 'container': 'table'});

Works for this scenario, but not when the HTML is not inside a table.
Any idea?

@ricardopolo - some parent - and it needs to be unique OK?, which holds your generated, dynamic content. We just don't know - for such questions like please use http://stackoverflow.com/questions/tagged/twitter-bootstrap

Using @peterblazejewicz the issue was fixed.
For our case, calling:
$('.signtul-keyword').tooltip({ 'placement': 'bottom', 'container': '.keyword-container'})

Fixes the issue. Keyword container is the Div withing the tooltips appear.


Lodash

This PR solves this issue and many other similar issues
#306
First i needed lodash to use this library https://github.com/cape-io/lodash-humps (i have not found similar for underscore, and decided to use only lodash in whole project instead of 2 similar libs)
Then recursive lodash-humps caused "call stack size exceeded", and i have decided to use independent non-recursive lib https://github.com/sindresorhus/camelcase-keys , but lodash have already been integrated. All the tests, but one (should not be problem to get userAgent), passed successfully.
Lodash is more modern and more actively evolving than underscore, so i think it is good idea to use it.
@huttarichard @IvanMMM please tell your opinion, and accept this if agree.

Nic job @dilame love it!

Nice job :)


[PE-D] Misleading phrase in user guide

In this sentence, it seems to suggesting that list command does not take in any parameter, where in fact it does.

Labels: type.DocumentationBug severity.Medium
original: 1001mei/ped#8

"Must fix" Bug.
Since list now takes in arguments for sorting feature to work.


[9.x] Add streamed content test assertion

This PR adds an assertStreamedContent() assertion that allows response()->streamDownload() feature tests to be shortened from:
$response = $this->get('/download')
    ->assertOk()
    ->assertDownload('foobar.txt');

$this->assertSame($response->streamedContent(), 'foobar');

To a more succinct:
$this->get('/download')
    ->assertOk()
    ->assertDownload('foobar.txt')
    ->assertStreamedContent('foobar');

Reverted because tests were failing.

@ziadoz tests were failing for a different reason. Can you maybe resend this?

@driesvints Apologies, yes I'll take a look at the tests and reopen this. 👍

@driesvints Here's the fixed PR: https://github.com/laravel/framework/pull/45298


Filtered Stream AddFollow Returning Mentions

Following a user for a filtered stream is returning matched tweets from mentions. Not all mentions though. I was expecting only tweets from the user to be matched.
var stream = Stream.CreateFilteredStream();
stream.AddFollow(14260960);
stream.MatchingTweetReceived += (sender, argus) =>
{
}
var task = stream.StartStreamMatchingAnyConditionAsync();

I am not sure what are your expectations but please check the MatchOn property :
var fs = Stream.CreateFilteredStream();
fs.MatchOn = MatchOn.UserMentionEntities | MatchOn.Follower;; // .... whatever you want

Reference : https://github.com/linvi/tweetinvi/issues/530


Unable to use bitsandbytes in mac m1

Installed bitsandbytes package using this repo (!pip install -U git+https://github.com/rickardp/bitsandbytes.git) but doesn't seem to work on mac m1 as getting error "PackageNotFoundError: bitsandbytes" when trying to use the same.
I ran a trace (!python -m bitsandbytes) on my jupyter notebook and got below output:
Traceback (most recent call last):
File "/Users/prasantapanja/anaconda3/lib/python3.10/runpy.py", line 187, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
File "/Users/prasantapanja/anaconda3/lib/python3.10/runpy.py", line 146, in _get_module_details
return _get_module_details(pkg_main_name, error)
File "/Users/prasantapanja/anaconda3/lib/python3.10/runpy.py", line 110, in _get_module_details
import(pkg_name)
File "/Users/prasantapanja/anaconda3/lib/python3.10/site-packages/bitsandbytes/init.py", line 6, in
from . import cuda_setup, utils, research
File "/Users/prasantapanja/anaconda3/lib/python3.10/site-packages/bitsandbytes/research/init.py", line 1, in
from . import nn
File "/Users/prasantapanja/anaconda3/lib/python3.10/site-packages/bitsandbytes/research/nn/init.py", line 1, in
from .modules import LinearFP8Mixed, LinearFP8Global
File "/Users/prasantapanja/anaconda3/lib/python3.10/site-packages/bitsandbytes/research/nn/modules.py", line 8, in
from bitsandbytes.optim import GlobalOptimManager
File "/Users/prasantapanja/anaconda3/lib/python3.10/site-packages/bitsandbytes/optim/init.py", line 6, in
from bitsandbytes.cextension import COMPILED_WITH_CUDA
File "/Users/prasantapanja/anaconda3/lib/python3.10/site-packages/bitsandbytes/cextension.py", line 11, in
lib = ct.cdll.LoadLibrary(binary_path)
File "/Users/prasantapanja/anaconda3/lib/python3.10/ctypes/init.py", line 452, in LoadLibrary
return self._dlltype(name)
File "/Users/prasantapanja/anaconda3/lib/python3.10/ctypes/init.py", line 374, in init
self._handle = _dlopen(self._name, mode)
OSError: dlopen(/Users/prasantapanja/anaconda3/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cpu.dylib, 0x0006): tried: '/Users/prasantapanja/anaconda3/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cpu.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/prasantapanja/anaconda3/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cpu.dylib' (no such file), '/Users/prasantapanja/anaconda3/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cpu.dylib' (no such file)

That would be probably because no one has built the package and put it into a module for Python and the wheels. The traceback indicated that bitsandbytes_cpu.dylib is not found, so it hasn't been installed and likely not built in this repository yet. Not sure off anyone has started building this or not.

Thank you @unixwzrd for your comments. Make sense.

I’ve been looking at options for this used of bitsandbytes not supporting Apple Silicon M1 and M2 processors and it seems the necessary pieces are already in libraaries Apple shops, though some work with Metal will need to be done. However, I have seen what’s going on here with the ggml library development since it looks like it has promise. I am also I. The process of testing various methods for accessing LLMs on Apple Silicon M1 M2 processors and there is some progress being made. This is where I am trying to keep my progress updated for now.. Maybe there’s a better place, but this will also alow collaboration.

This package is not ready to be pip installable. As per the README, build using “make” (requires cmake) then use distutils setup.py.
My idea is to build binary wheels for all supported platforms (already done in HitHub actions but not published to pip). I don’t think it is worth the effort of supporting pip install from source to be honest.
please note that CPU and Apple Silicon support is nowhere near complete and not in a usable state.

hello rickardp, can i ask what the status of this port is and what you might need help with?

Hi @bghira. Good to hear, there's certainly a need for more hands on the porting to MPS. The current status is that I plan to help out, but I am waiting on the device abstraction to settle (https://github.com/TimDettmers/bitsandbytes/pull/898). Then we need to get the CPU pipeline working and all unit tests green on the mac. Then we can port piece by piece to gradually get better MPS coverage. At least that's the plan in my head, but please feel free to join the discussions over at the upstream
https://github.com/TimDettmers/bitsandbytes/discussions/990
I will close this issue now since the original PRs from this fork has been merged to main.


php-cs-fixer got broken for linux user after fixing the issue 6 for windows user

Hi,
I use Linux Ubuntu 16.04. I have well installed php-cs-fixer for atom 1.9.8.
$ php-cs-fixer
PHP CS Fixer version 1.11.6 by Fabien Potencier

Usage:
  command [options] [arguments]

Options:
  -h, --help            Display this help message
  -q, --quiet           Do not output any message
  -V, --version         Display this application version
      --ansi            Force ANSI output
      --no-ansi         Disable ANSI output
  -n, --no-interaction  Do not ask any interactive question
  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

Available commands:
  fix          Fixes a directory or a file
  help         Displays help for a command
  list         Lists commands
  readme       Generates the README content, based on the fix command help
  self-update  Update php-cs-fixer.phar to the latest version.
  selfupdate   Update php-cs-fixer.phar to the latest version.

The problem comes with config of php-cs-fixer with atom. In fact, package requires:

a PHP Executable path (which is by defaut php) (for linux user it must be empty which is not possible with actual version of the  package) (see isse #6 )
a PHP-CS fixer Executable path (which is simply for linux user php-cs-fixer (without the use of PHAR file))

Consequently, when I run php-cs-fixer from atom I get this error: Could not open input file: php-cs-fixer.
I can generate this error message with this console command:
php php-cs-fixer fix Class.php
    Could not open input file: php-cs-fixer

So, can you @pfefferle make PHP Executable path optional (not compulsory)???
thanks,

@pfefferle  May be we just should change the config here https://github.com/pfefferle/atom-php-cs-fixer/blob/master/lib/php-cs-fixer.coffee#L12 as follows:
phpExecutablePath:
  title: 'PHP executable path'
  type: 'string'
  default: ''   # in stead of 'php'
  description: 'the path to the `php` executable'

I changed the lib/php-cs-fixer.coffee as I mentionned earlier. Then, I select the text on which I will run the php-cs-fixer and below is the error I am getting...
Do you think @pfefferle that it would better to create a phar file for php-cs-fixer?

Atom Version: 1.9.8
System: Ubuntu 16.04.1
Thrown From: php-cs-fixer package, v2.5.9
Stack Trace
Uncaught TypeError: Bad argument
At /usr/share/atom/resources/app.asar/src/buffered-process.js:262

TypeError: Bad argument
    at TypeError (native)
    at ChildProcess.spawn (internal/child_process.js:278:26)
    at Object.exports.spawn (child_process.js:379:9)
    at BufferedProcess.module.exports.BufferedProcess.spawn (/usr/share/atom/resources/app.asar/src/buffered-process.js:190:44)
    at new BufferedProcess (/usr/share/atom/resources/app.asar/src/buffered-process.js:52:14)
    at Object.module.exports.PhpCsFixer.fix (/home/amine/.atom/packages/php-cs-fixer/lib/php-cs-fixer.coffee:125:19)
    at atom-workspace.subscriptions.add.atom.commands.add.php-cs-fixer:fix (/home/amine/.atom/packages/php-cs-fixer/lib/php-cs-fixer.coffee:72:84)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app.asar/src/command-registry.js:260:29)
    at CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app.asar/src/command-registry.js:3:61)
    at CommandRegistry.module.exports.CommandRegistry.dispatch (/usr/share/atom/resources/app.asar/src/command-registry.js:160:19)
    at AtomEnvironment.module.exports.AtomEnvironment.dispatchContextMenuCommand (/usr/share/atom/resources/app.asar/src/atom-environment.js:1110:28)
    at EventEmitter.outerCallback (/usr/share/atom/resources/app.asar/src/application-delegate.js:342:25)
    at emitThree (events.js:110:13)
    at EventEmitter.emit (events.js:188:7)

Commands
     -4:54.1.0 settings-view:open (atom-pane.pane.active)
     -4:08.1.0 core:select-all (atom-text-editor.editor.is-focused)
     -4:05.7.0 php-cs-fixer:fix (atom-text-editor.editor.is-focused)
  3x -3:05.4.0 core:backspace (atom-text-editor#php-cs-fixer.fixers.editor.mini.is-focused)
     -2:57 core:select-all (atom-text-editor.editor.is-focused)
     -2:54.1.0 php-cs-fixer:fix (atom-text-editor.editor.is-focused)
     -0:52.1.0 settings-view:open (atom-text-editor.editor.is-focused)
     -0:00.1.0 php-cs-fixer:fix (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "projectHome": "/home/amine/NetBeansProjects"
  },
  "php-cs-fixer": {
    "executeOnSave": false,
    "fixers": "fix",
    "level": "symfony",
    "showInfoNotifications": true
  }
}

Installed Packages
# User
atom-autocomplete-php, v0.18.9 (active)
atom-beautify, v0.29.10 (inactive)
atom-symfony2, v0.2.1 (active)
php-cs-fixer, v2.5.9 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.51.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.43.0 (inactive)
base16-tomorrow-dark-theme, v1.1.0 (inactive)
base16-tomorrow-light-theme, v1.1.1 (inactive)
one-dark-ui, v1.3.2 (active)
one-light-ui, v1.3.2 (inactive)
one-dark-syntax, v1.2.0 (active)
one-light-syntax, v1.2.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.5.2 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.0 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.0 (active)
bookmarks, v0.41.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.39.0 (active)
fuzzy-finder, v1.3.0 (active)
git-diff, v1.1.0 (active)
find-and-replace, v0.198.0 (inactive)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.1 (active)
image-view, v0.58.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (active)
metrics, v0.53.1 (active)
notifications, v0.64.1 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.238.2 (active)
snippets, v1.0.2 (active)
spell-check, v0.67.1 (active)
status-bar, v1.4.1 (active)
styleguide, v0.46.0 (active)
symbols-view, v0.113.0 (inactive)
tabs, v0.98.1 (active)
timecop, v0.33.1 (active)
tree-view, v0.208.0 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.34.0 (active)
whitespace, v0.32.2 (active)
wrap-guide, v0.38.1 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.0 (active)
language-csharp, v0.12.1 (active)
language-css, v0.36.2 (active)
language-gfm, v0.86.0 (active)
language-git, v0.13.0 (active)
language-go, v0.42.0 (active)
language-html, v0.44.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.22.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.0 (active)
language-less, v0.29.3 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.0 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.68.5 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.52.0 (active)
language-shellscript, v0.22.3 (active)
language-source, v0.9.0 (active)
language-sql, v0.21.1 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.8 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages

I managed to download php-cs-fixer.phar from https://github.com/FriendsOfPHP/PHP-CS-Fixer and I put it in the folder ~/.composer/ so that:

a PHP Executable path is php
a PHP-CS fixer Executable path is: ~/.composer/php-cs-composer.phar

But now I am getting this error: Could not open input file: ~/.composer/php-cs-fixer.phar
So what's wrong??
For you information, running the console php ~/.composer/php-cs-composer.phar Class.php command is successful.
Thanks in advance

It seems that Atom has Problems with the home folder (~) please try the complete path to the php-cs-fixer executable (if it is the phar file or the php file, shouldn't make a difference)

BTW: I also use the absolute path to my php executable: /use/bin/php

My Settings:

Problem solved!!!
I have a symfony project working on, so advise me to use the symfony level or the psr2?
Thanks...


Top Post Feed From Hash Tag

Is there a way to get information from a hashtag
Post Number#
Top Post
From Top post 1, get total number of likes?
Is there a limit to how many likes you can get from the media, i.e. max 120 or 1000?

Considering the low activity rate in this community, it's going to be most unlikely to get an answer...