uart_isr_register for idf v5 up (IDFGH-10195)

Is your feature request related to a problem?
Please can you add the possibility to add own interrupt handling function with uart_isr_register to version 5.like in versions 4, because otherwise we can not use the v5 without this feature.
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
No response

It seems there is no way to write low-latency UART code with IDF v5. Is there a specific reason this function got removed?

Same for me, I can't upgrade to V5 for some of my boards, is there a workaround to implement low latency/high throughput UART avoiding the fat ISR set up by uart_driver_install?

This deprecation has me worried as well.  I've wasted many hours trying to get a basic LINbus driver working reliably on the high-level UART driver.  I need to go lower-level to make the BREAK detection and synchronization robust.
Some references to my LIN driver woes:
https://github.com/espressif/esp-idf/issues/4537#issuecomment-1433671118
https://esp32.com/viewtopic.php?t=8181
BTW I would love to see some example code using the UART at low-level with interrupts.  It would be great if this low-level driver can work on UART2, while leaving the default UART for console output.

I just ran into the same problem when porting my application from 4.4 to 5.1.2.  I just copied the code from 4.4 into my driver:
#include "esp_check.h"
esp_err_t uart_isr_register(uart_port_t uart_num, void (*fn)(void *), void *arg, int intr_alloc_flags,  uart_isr_handle_t *handle)
{
    int ret;
    ESP_RETURN_ON_FALSE((uart_num < UART_NUM_MAX), ESP_FAIL, UART_TAG, "uart_num error");
    UART_ENTER_CRITICAL(&(uart_context[uart_num].spinlock));
    ret = esp_intr_alloc(uart_periph_signal[uart_num].irq, intr_alloc_flags, fn, arg, handle);
    UART_EXIT_CRITICAL(&(uart_context[uart_num].spinlock));
    return ret;
}

Manually changing files of the ESP-IDF is something I wouldn't recommend. I have just added this code into my project. It works and I haven't come across any issues so far.

For conversion from IDF V4 to V5 drop the 'install driver' and uart_isr_free/register commands. Keep the uart_param_config functions and use esp_intr_alloc to hook the interrupt.
Something like this:
#include "hal/uart_ll.h"
#include "soc/interrupts.h"
static void IRAM_ATTR my_uart_isr( void *arg )
{
if( UART1.int_st.txfifo_empty_int_st ) {
// build reply
uart_ll_write_txfifo(&UART1, "sendstr",7 );
uart_clear_intr_status(UART_NUM_1, UART_TXFIFO_EMPTY_INT_CLR);
return;
}
if( UART1.int_st.parity_err_int_st ) {
uart_clear_intr_status(UART_NUM_1, UART_PARITY_ERR_INT_CLR);
return;
// handle other interrupt sources and clear them.
if( UART1.status.rxfifo_cnt ) {
// read bytes from UART1.fifo.rxfifo_rd_byte until UART1.status.rxfifo_cnt == 0
uart_clear_intr_status(UART_NUM_1, UART_RXFIFO_FULL_INT_CLR);
}
}
const uart_config_t uart_config = {
.baud_rate = 9600,
.data_bits = UART_DATA_8_BITS,
.parity = UART_PARITY_EVEN,
.stop_bits = UART_STOP_BITS_1,
.flow_ctrl = UART_HW_FLOWCTRL_DIABLE,
.source_clk = UART_SCLK_APB,
};
uart_isr_handle_t isr_handle;
ESP_ERROR_CHECK(uart_param_config(UART_NUM_1, &uart_config ));
ESP_ERROR_CHECK(uart_set_pin(UART_NUM_1, 17, 18, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE));
ESP_ERROR_CHECK(uart_set_line_inverse(UART_NUM_1,UART_SIGNAL_TXD_INV));
ESP_ERROR_CHECK(esp_intr_alloc(ETS_UART1_INTR_SOURCE, (void *)NULL, my_uart_isr, NULL, &isr_handle,));
uart_intr_config_t uintr_cfg = {
.rxfifo_full_thresh = 1,
.intr_enable_mask = (UART_RXFIFO_FULL_INT_ENA_M)
};
uintr_cfg.txfifo_empty_intr_thresh = 1;
uintr_cfg.intr_enable_mask = (UART_RXFIFO_FULL_INT_ENA_M | UART_TXFIFO_EMPTY_INT_ENA_M);
ESP_ERROR_CHECK(uart_intr_config(UART_NUM_1,&uintr_cfg));
uart_intr_config_t intr_config = {
.intr_enable_mask = UART_TX_DONE_INT_ENA_M | UART_RXFIFO_TOUT_INT_ENA_M,
};
ESP_ERROR_CHECK(uart_isr_free(UART_NUM));
ESP_ERROR_CHECK(uart_isr_register(UART_NUM, uart_intr_handle, NULL, ESP_INTR_FLAG_IRAM, NULL));
ESP_ERROR_CHECK(uart_intr_config(UART_NUM, &intr_config));

ESP_ERROR_CHECK(uart_isr_register(UART_NUM, uart_intr_handle, NULL, ESP_INTR_FLAG_IRAM, NULL));

Aren't you calling exactly the function that is not available in V5? This was the whole point of the post.

ESP_ERROR_CHECK(uart_isr_register(UART_NUM, uart_intr_handle, NULL, ESP_INTR_FLAG_IRAM, NULL));

Aren't you calling exactly the function that is not available in V5? This was the whole point of the post.

Error in copying. I changed it. By mistake I had quoted the previous comment. Those three lines are not needed.


Roadmap

RoadMap
Beta 1: released
Beta 2: released
Release Candidate 1:
[ ] Implement Unix builds
[ ] Full testing of Unix version

Release
[x] Beta 1 release
[x] Beta 2 release
[ ] Release Candidate
[ ] wxWidgets 3.2.0 (unless significantly delayed)
[ ] Final test pass

After the switch to building with a static runtime libraries, I tested this on a Unbuntu distro using Wine 5.0.3 and it ran fine even using the default Windows 7 mode (it does look better when set to Windows 10 mode). The setup program we release with also worked fine using Wine.
I still want to get a native Unix build working, but we're no longer blocked on not having anything that works on Linux. Note that we won't be releasing Linux binaries -- way too many Linux versions for me to support directly.


Feat/set image on drag n drop

Closes #1945
This PR addresses the above issue in that when a user drags and drops an image file, it will upload to Cloudinary, but does not set the value of the field properly.
This was due to an issue with the persist method in the next-tinacms-cloudinary package not returning an appropriate Media object.

Tinkering with this a bit more. Seems like the imageSrc isn't updated in the form values consistently.

How can we test this?

@DirtyF this would have to be tested int he mono repo. Check out this file to get started

Latest on this effort:
@dwalkr I've implemented your suggestions on the changeset and adding some inline comments to explain some choices.
Digging into Cloudinary docs some more, looks as though the upload API only accepts image video raw and auto. Essentially we're only going to be sending files, so we'll explicitly set that on the response formatting.
Finally, I have not been successful with the two onChange calls. Removing the empty string check allows for things to work as expected. There is a rabbit hole to go down for sure to ensure how this can work with other Media Store implementations. For the sake of the immediate, since we're leaning into the Cloudinary solution we could proceed and come back to the issue as needed.


KAFKA-7021: Update upgrade guide section for reusing source topic

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@vvcephei @mjsax @bbejeck

@mjsax comments addressed.

Cherry-picked to 2.0


Fix tests to use fake timers to support running tests in d…

Changes

Fix tests to use fake timers

@daiproxomhoa to test locally

[delete] branch

any issues with time-slot-bar-helper.spec.ts? noticed that also uses dayjs for time formatting

any issues with time-slot-bar-helper.spec.ts? noticed that also uses dayjs for time formatting

Looking at the tests, it doesn't seem to have any time conversion elements involved.

forcing a timezone so that the snapshot tests are generated consistently, referencing solutions from https://stackoverflow.com/questions/56261381/how-do-i-set-a-timezone-in-my-jest-config
note that we're not able to test timezones dynamically with this


Define pattern for calling trait RpcMethod in forest-cli attach

Once this is done, the following should be bound:

MpoolPushMessage

#4358


feat(form events): Create unified observable and signal data accessors for form events

Context
Broached in Discussions #334 and Issue #376
Stackblitz: https://stackblitz.com/edit/stackblitz-starters-nbicus?file=src%2Fform-events-utils.ts
Usage
End feature - two functions (or more if there is interest, see end notes)
function allEventsObservable<T>(form: AbstractControl<T>): Observable<{
    value: T;
    status: FormControlStatus;
    touched: boolean;
    pristine: boolean;
}>

function allEventsSignal<T>(form: AbstractControl<T>): Signal<{
    value: T;
    status: FormControlStatus;
    touched: boolean;
    pristine: boolean;
} | {
    readonly value: T;
    readonly status: FormControlStatus;
    readonly pristine: boolean;
    readonly touched: boolean;
}>

with usage like
import { allEventsObservable, allEventsSignal } from 'ngxtension/form-events';

@Component({
    // ....
    template: `
        <form [formGroup]="form">
            <label for="firstName">Name</label>
	    <input formControlName="firstName" name="firstName" />
        </form>
    `,
})
export default class FormEventsComponent {
        // ....
	form$ = allEventsObservable(this.form);
	$form = allEventsSignal(this.form);
}

and end values after calling the signal or subscribing like this, where there is always an initial value for either.
{
   "value": {
      "firstName": "Jerry",
    },
    "status": "VALID",
    "touched": true,
    "pristine": false
}

Process on PR
I submitted this as a draft for a few reasons

Tests for the observable are outstanding as I am not that familiar with testing them yet. If this utility is considered then I will figure that out and make some.
There could be more utilities like this, but I don't want to overwhelm. For example, non exported functions which are helper functions for the end two functions could be beneficial to expose. For the 4 types of form data (value, status, pristine, touched), there is two types of helpers that could be exported as well: type narrowing: function isStatusEvent<T>(event: ControlEvent | T): event is StatusChangeEvent or this for getting the values of individual pieces of the form's data as either observables or signals: function statusEvents$<T>(form: AbstractControl<T>): Observable<StatusChangeEvent>/function $statusEvents<T>(form: AbstractControl<T>): Signal<StatusChangeEvent | undefined>. For the moment being, all of these helpers even if they are not used are included in the util file, though ones not directly used are commented out. They do not all have initial values, since that was done for the two functions that are the focus of this PR. But if these helpers are to be considered then they can be refactored to have initial values.
There are two other form events that this unified control events API exposes: submitted and reset. However, those are moreso what I call for a lack of technical terms "event events"; they do no have synchronous accessors like the other four types of events. And that makes sense, as they are events that happen at a given point of time but they do not necessarily make sense to keep track of synchronously. It could probably been done and I have some ideas for that, but I want to see interest in the other functionality of this proposed util first.

One pain discussed in #365 is when forms are passed as inputs to different components. To my knowledge, doing so while retaining types and also being able to key off of valueChanges/statusChanges as well as these events requires some hacky solutions, which I outline in the issue. To remedy this, I can extend the functionality of this util to take in different parameters, so that the form is passed down as a signal input, and allEventsObservable can take form: AbstractControl<T> | Signal<AbstractControl<T>>, and allEventsSignal could take form: Observable<AbstractControl<T>> | AbstractControl<T>. Here is a proof of concept doing it with a similar util that I made with valueChanges
https://stackblitz.com/edit/ptxmym-pggt7i?file=src%2Fapp%2Fchild%2Fchild.component.ts

I am fairly satisfied with this as is after tweaking a few things. If nobody has any sort of questions or suggestions then I will mark this as an official PR in the next day or two. Though of course those are welcomed then too.

One thing I have considered but I am leaving out unless people want: equivalent event property names. For example, untouched in addition to already having touched, dirty in addition to pristine, etc.
Is that a thing people would want? My inclination is to keep things simple but be open to more. And for the moment being, the exposed state of the signal and observable have the essentials and other data could be derived from there.
As I think out loud, I could see people wanting valid rather than just status: 'VALID' | 'INVALID' | 'PENDING' | 'DISABLED' (aka FormControlStatus) .

One thing I have considered but I am leaving out unless people want: equivalent event property names. For example, untouched in addition to already having touched, dirty in addition to pristine, etc.

Link to example of what I mean. Names of functions WIP: https://stackblitz.com/edit/4gahmc?file=src%2Fexample%2Fform-event-utils.ts
Output
Form Unified Properties + Form Derived Properties all in one
{
  "value": {
    "firstName": "",
    "lastName": ""
  },
  "status": "INVALID",
  "touched": false,
  "pristine": true,
  "valid": false,
  "invalid": true,
  "pending": false,
  "dirty": false,
  "untouched": true
}

another state with a value
{
  "value": {
    "firstName": "Test",
    "lastName": ""
  },
  "status": "VALID",
  "touched": true,
  "pristine": false,
  "valid": true,
  "invalid": false,
  "pending": false,
  "dirty": true,
  "untouched": false
}

One thing I have considered but I am leaving out unless people want: equivalent event property names. For example, untouched in addition to already having touched, dirty in addition to pristine, etc.

After making the example and messing around with it I decided to add these

If this is to be approved, should I make the documentation page now or after? I don't want to presume but also I am willing to write it up now if the feature is to be considered.

Note: I realized that despite the return signature, quirks of the forms API and values, it tends to when used return a partial. Despite .getRawValue, despite { nonNullable: true }, etc. I think I have been a bit pulled away from noticing this directly due to how some of my approaches of using it in effect kind of coerces partials.
I am going to try some tweaks on a few things to see if I can either avoid it becoming partials, and at worst just explicitly mark that it is effectively giving partials for value properties and some links to how to work with that.

@michael-small I'll respond to your question in #365 here to keep it all in once place. As I understand you are looking to provide a way to make the form values not a partial type.
Of course I'm lacking some context here, and not sure if this is the best approach, but I was able to get this to work. First you could add an overload:
export function allEventsObservable<T>(
	form: AbstractControl<T>,
): Observable<FormEventData<T>>;
export function allEventsObservable<T>(
	form: AbstractControl,
): Observable<FormEventData<T>>;

export function allEventsObservable<T>(
	form: AbstractControl,
): Observable<FormEventData<T>> {

and then this would allow manually passing in the type if you wanted to force the value type to not be a partial, e.g. this would give you a partial type:
	form$ = allEventsObservable(
		this.form,
	);

and this would allow you to supply the non-partial type:
	form$ = allEventsObservable<ReturnType<typeof this.form.getRawValue>>(
		this.form,
	);

Not sure if that's exactly what you want or if it's the best approach, but maybe you could play around with that

Not sure if that's exactly what you want or if it's the best approach, but maybe you could play around with that

This is good stuff, I'll experiment with this. Overloads and util types are something I don't think about that often but this opens a lot up. Thank you for taking the time to give feedback/advice.

Pinging @nartc because I have made significant changes since this was originally marked as ready. Apologies for making so many changes and edits ever since marking this PR as ready... and then spreading that out via a bunch of comments and edits. I hope I didn't make too much noise, but I don't want to drown this out: I am now confident that it is ready.
Two biggest changes

value can be optionally stronger typed as T and not Partial<T> thanks to Josh
Edge case where ngOnInit value sets may not be accounted for in value now accounted for using RXJS defer. With new test.

If there is anything that is needed (docs, changes, clarification) then I am happy to help.

Woo, thank you for including this feature! I'll write up a doc page and put in a PR for that soon.

@michael-small
Before adding the docs page, I'd like to take this for a review, and maybe update some stuff first.
First thing I'd like to update is the naming of these functions. When working with signals I'd like to not see the signal name in the function so we can have sth like:
status = formStatus(this.form);  // status is a signal

status$ = fromFormEvents(this.form); // status$ is an observable that gets created from form events

allEventsSignal doesn't make much sense imo, because we are converting all those events to a unified signal, so the function loses the events meaning somehow. What do you think about the fromStatus function name? It immediately gives you an idea on what it will produce.
allEventsObservable naming is fine, but I'd like to have a more streamlined name. What do you think about fromFormEvents ? It uses the from* pattern like some other rxjs creation operators, and feels normal when being used.

I agree that the naming could be better and aught to change. However, I do have some thoughts about "status" due to forms having a .status. Going to think on this and some possible alternatives if you don't mind.
Also I have one other question about if it's too late to export some of the typing for the utils as well. Since changes to the source are due with these proposed changes anyways, this has been something on my mind.

I'll follow up with more later tonight when I have more time

@eneajaho
This is mostly what I already said, but slightly more thought out. And I had an idea for a unified kind of name for both the signal and observable version.
Here is a link to it renamed and used in a Stackblitz to get a feel for it in action: https://stackblitz.com/edit/stackblitz-starters-qoq8b9?file=src%2Fmain.ts

Form Util Naming - Your Idea for Observable naming, my idea for the Signal naming?

What do you think about the fromStatus function name? It immediately gives you an idea on what it will produce.

The name of "status" crossed my mind before, but part of the issue is that there is a FormControlStatus. There is also an issue with an alternative that I considered about referring to it as a "value", as FormControlValue is also closely tied to form data. However, I do think that your idea for naming makes more sense. I would be open to formStatus for the observable utility, but it may also make sense to workshop a different word to key off of.

status$ = fromFormEvents(this.form); // status$ is an observable that gets created from form events

fromFormEvents makes the most sense with the observable version in my mind. I think that would be best.
Taken together... what if the signal variant was
fromFormState(this.form)

I know that "from" is more RXJS-y, but it is also making state "from" a form. I feel like this naming would make them more apparently tied together, and Event is to RXJS as State is to Signals.

PS - while we will be tweaking the utility's code...
Whenever we agree on naming, can I also make sure to export the type FormEventData<T> as it is good to have. Especially in conjunction with the signalSlice's exported type Source like my Stackblitz example.


Helper Method For Acquiring NodeId

I have been playing with this plugin and it seems like nodeId is used very regularly. The method for acquiring the nodeId is very easy, but probably still deserving of a helper so people aren't writing boiler plate everywhere. The method for acquiring the nodeId is a little bit opaque if you have never used it before.
Domains where NodeId is used:

Accessibility -- HEAVY
CSS -- HEAVY
DOM -- HEAVY
DOMDebugger
Profiler

The helper would likely look like:
get nodeId(selector) {
        let _document = browser.cdp('DOM', 'getDocument');
        return browser.cdp('DOM', 'querySelector', {nodeId: _document.root.nodeId, selector});
}

Implemented in https://github.com/webdriverio/webdriverio/pull/2918


SRS - fix reflection questions

Apparently, the reflection questions are out of sync according to https://gitlab.cas.mcmaster.ca/courses/capstone/-/issues/3, so I'm updating them. Not sure if we actually need the new questions maybe we should ask the TA? I'm just making the PR so we can quickly merge if needed.

Merge whenever Maybe we'll get an answer from the TA before tomorrow's deadline?


Waiting for loaded window

Hi,
I'm using FlaUI to autmatic tests for WinForms application on Windows Server 2016. I'm looking for best way to wait for loading window of an application. I tried Thread.Sleep(time) but I think it's not good because it waste time if window is loaded faster than expected time. Now I use this method:
public void WaitUntilWindowAppears(Window window, int waitFor = 15000)
        {
            Stopwatch watch = new Stopwatch();
            watch.Start();
            while (window==null && watch.ElapsedMilliseconds < waitFor)
            {
                System.Threading.Thread.Sleep(1000);
                window= Automation.GetDesktop().FindFirstChild(cf => cf.ByName("Name")).AsWindow();
            }
            watch.Stop();
        }

Is there any better method/idea to do this?

Have a look at the Retry class.
You could use something like Retry.WhileNull(() => Automation.GetDesktop().FindFirstChild(cf => cf.ByName("Name"))); There are plenty of configuration options for the retry methods. Check them out. There is some documentation here: https://github.com/Roemer/FlaUI/wiki/Retry

After adding second argument of type TimeSpan it works as I wanted. Thanks a lot!


Adding resource move related FAQ for Azure Files backup

@mepand : Thanks for your contribution! The author(s) have been notified to review your proposed change.


React Native Update 0.55.4

This issue is being created to keep track of our progress towards updating to React Native v0.55.4 as well as some dependency updates.
Dependencies

Dependency
Old Version
New Version
Notes

moment
2.21.0
2.22.1

node-forge
0.7.2
0.7.5

react-native-device-info
0.21.2
0.21.5

react-native-exception-handler
2.7.1
2.7.5

react-native-fcm
14.1.3
15.0.2

react-native-google-analytics-bridge
5.6.2
5.6.3

react-navigation
1.5.8
1.5.11
Last working version

react-native-sortable-list
0.0.21
0.0.22

react-native-popup-menu
0.12.3
0.12.6
Last working version

react-native-vector-icons
4.5.0
4.6.0

react-navigation-header-buttons
0.0.5
1.0.0

Dev Dependencies

Dependency
Old Version
New Version
Notes

babel-eslint
8.2.2
8.2.3

babel-jest
22.4.3
22.4.4

enzyme-to-json
3.3.3
3.3.4

eslint-plugin-flowtype
2.46.1
2.46.3

eslint-plugin-import
2.9.0
2.12.0

eslint-plugin-react
7.7.0
7.8.2

jest
22.4.3
22.4.4

Blocked updates

Dependency
Old Version
New Version
Notes

react-native
0.54.4
0.55.4
Blocked by issues with compiling for android with react-native-maps

react-native-maps
refer to package.json
0.21.0
Blocked by pending react-native issue https://github.com/facebook/react-native/issues/16906

react-native-popup-menu
0.12.3
0.13.1
Requires rn v0.55.+

Breaking updates

Dependency
Old Version
New Version
Notes

redux
3.7.2
4.0.0
Makes us have to update redux-persist

redux-persist
4.10.2
5.9.1
Incompatible with previous states. Have to write custom experimental migrations or wipe all user data

react-navigation
1.5.8
2.0.1
Breaking API changes. Requires refactoring

React native update is currently blocked by https://github.com/facebook/react-native/issues/16906

Based on the state of things, we should hold off on updating to v55 of react native, as well as hold off on updating redux-persist, redux, and react-navigation. react-navigation made significant breaking changes that will drastically affect our Router setup. I think it's best to wait and see if some issues are resolved in the future.

We will be staying on React Native 0.54.4 for now, but we should be able to upgrade in the next milestone. Will attempt again after the completion of Parking & Messaging projects.

React Native upgrade blocking issue https://github.com/facebook/react-native/issues/16906 has been resolved in RN 57.3+

Starting in March 2019, App Store Connect requires iOS builds be compiled with Xcode 10.1 or later.
App Center does not support Xcode 10.1 and RN 0.55 (our current version) - waiting on a response
App Center may support Xcode 10.1 and RN 0.57+ (TBD) - testing that this is correct
From Apple:

Dear Developer,
We identified one or more issues with a recent delivery for your app, "UC San Diego". Your delivery was successful, but you may wish to correct the following issues in your next delivery:
SDK Version Issue - This app was built with the iOS 11.4 SDK. Starting March 2019, all iOS apps submitted to the App Store must be built with the iOS 12.1 SDK or later, included in Xcode 10.1 or later.
After you’ve corrected the issues, you can use Xcode or Application Loader to upload a new binary to iTunes Connect.
Best regards,
The App Store Team

Issues #397 & #398 track the current progress of the react native platform upgrade. Closing


[FLINK-14547][table-planner-blink] Fix UDF cannot be in the join condition in blink planner

What is the purpose of the change

This pr fix UDF cannot be in the join condition in blink planner*

Brief change log

In the method visit(CallExpression callExpression) of JoinExpressionVisitor, When the objectIdentifier field of CallExpression is null, it will create a unresolved CallExpression.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks @HuangXingBo for you contribution, can you add a test?

Thanks @JingsongLi , I have added test method testUDFInJoinCondition in JoinITCase(batch/stream table).

LGTM +1

@HuangXingBo Thanks a lot for fixing the problem. The fix looks good. Besides, it would be better if we change the IT test to UT test. IT test is costful.

Thanks for the fixing @HuangXingBo .  I agree with @hequn8128 , a unit test for plan verifying is enough.

Thanks for @hequn8128 and @wuchong , I have replace the IT test with UT test.

Thanks for @hequn8128 review, I have remove the stream test at the latest commit.

@HuangXingBo Thanks a lot for the update. And thanks for the review and suggestions from @wuchong @JingsongLi
LGTM. Merging...


UTXOs appear locked to the user

A user reported a UTXO (A) as unavailable in Leather. And they had to use another wallet to access the funds 0.007 BTC to send it out.
It looks like there were only 12 blocks between this confirmation and the other transaction (B) sending it out. So I wonder if there was an error that caused the address balance not to update. Outdated API perhaps?
The user thinks the UTXO was locked, although it contained no inscription and I see no other reason for it to have been locked/unavailable.
The user reported seeing this before on sats that return to the wallet after a transaction (leftover inputs basically). I wonder if the wallet is affected because it contains a lot of history 376 transactions. And according to the user a total of 69 UTXO's (mostly minor ones).
bc1qzl5xt45gazvj2j4su2xdm5tftqkckgst5hhald

Have we seen this again? I'm closing as stale, but please reopen if we have.


test_streaming_upload_from_file_to_presigned_url fails

Steps to reproduce
make test on a fresh copy of master.
Expected result
All tests pass.
Actual result
One S3 test (test_streaming_upload_from_file_to_presigned_url) produces an error:
ERROR: tests.test_s3.test_s3.test_streaming_upload_from_file_to_presigned_url
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dawn.james/dev/github.com/dawngerpony/moto/.venv/lib/python3.7/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/Users/dawn.james/dev/github.com/dawngerpony/moto/moto/core/models.py", line 98, in wrapper
    result = func(*args, **kwargs)
  File "/Users/dawn.james/dev/github.com/dawngerpony/moto/tests/test_s3/test_s3.py", line 1048, in test_streaming_upload_from_file_to_presigned_url
    bucket.create()
  File "/Users/dawn.james/dev/github.com/dawngerpony/moto/.venv/lib/python3.7/site-packages/boto3-1.14.6-py3.7.egg/boto3/resources/factory.py", line 520, in do_action
    response = action(self, *args, **kwargs)
  File "/Users/dawn.james/dev/github.com/dawngerpony/moto/.venv/lib/python3.7/site-packages/boto3-1.14.6-py3.7.egg/boto3/resources/action.py", line 83, in __call__
    response = getattr(parent.meta.client, operation_name)(*args, **params)
  File "/Users/dawn.james/dev/github.com/dawngerpony/moto/.venv/lib/python3.7/site-packages/botocore-1.17.6-py3.7.egg/botocore/client.py", line 316, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/dawn.james/dev/github.com/dawngerpony/moto/.venv/lib/python3.7/site-packages/botocore-1.17.6-py3.7.egg/botocore/client.py", line 635, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (IllegalLocationConstraintException) when calling the CreateBucket operation: The unspecified location constraint is incompatible for the region specific endpoint this request was sent to.

Notes

The fix appears to be simple, I have included it in #3079, but I thought I should raise a separate issue anyway.
I'm not sure why this is happening today, I'm pretty sure it wasn't happening yesterday, but the fix seems harmless so I see no problem in making it.

All tests should have the region specified. Locally, boto3 might pick up the region from the AWS config, but as Travis doesn't have any AWS config, our build should always fail with a missing region.
Not sure why it didn't.. but your PR definitely fixes it. Thanks :)


add support for arm-based runners

Fixes the issue https://github.com/leonsteinhaeuser/project-beta-automations/issues/71

Please ignore the failed labels thing. I always forget that I need to patch the CI actions.


Zipcode limited in Central Texas

When I input the actual zipcodes for DPS locations in Austin, it only registers the Pflugerville Megacenter and outside of Austin according to the set miles.
"WARNING -> No location found for zipcode: 78750" etc.
Please advise?

I'm seeing a similar warning too. Running it locally. It's not really finding any location even with a 100 mi radius.
Plus I see this error which I think is because no locations were found:

log.error(No Available location found! Nearest location is ${response[0].Distance} miles away! Please change your config and try again!);

Any ideas/suggestions @phamleduy04 ?

@TheRegent76 , @asvin-kumar . Can you try to use the CityName option on config.yml instead of zipcode?

@phamleduy04 I tried 'Austin' this morning and it returned New Braunfels, 'which is 43 miles away'. The DPS scheduler website returns 'Austin South', when 'Austin' is inputted, and 'Pflugerville, Austin South, Temple, Killeen, Cameron' when Zip and Pflugerville are inputted.  Pflugerville has a mega center, but Austin has 2 more locations that are not listed in the DPS website right now. The Georgetown area also has a DPS center and is closer to Austin than the other locations they list.
Could the program be returning less choices because DPS is somehow restricting the available offices internally?

@TheRegent76 , Yes since the program is using the same DPS system as the official one, so if the official one is returning fewer cities, the app will returning the same data

makes sense! thx
On Thu, Aug 15, 2024 at 10:37 AM Duy Pham Le @.***>
wrote:

@TheRegent76 https://github.com/TheRegent76 , Yes since the program is
using the same DPS system as the official one, if the official one is
returning fewer cities, the app will return the same data
—
Reply to this email directly, view it on GitHub
https://github.com/phamleduy04/texas-dps-scheduler/issues/170#issuecomment-2291558897,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJXP4TFYWC3Q2RI6YMTKOWLZRTDJ7AVCNFSM6AAAAABMPF7VT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGU2TQOBZG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add Pony language

https://github.com/search?utf8=✓&q=extension%3Apony+new&type=Code&ref=searchresults

+1 - It would be great if my pony projects could start seeing syntax highlighting, especially https://github.com/jemc/pony-zmq, which is becoming fairly complex.
In terms of adoption, it's also worth noting that exercism.io will soon have a Pony track of exercises.

+1 - Pony is one of the more promising languages around.

Hi @manveru. Thanks for opening up this Pull Request. As per the contributing guidelines we try to only add new languages to Linguist when they have a significant level of adoption (hundreds of repositories) and by the looks of things there are currently only ~200 .pony files on GitHub.
Please feel free to open a new PR in the future as adoption increases.

Linguist is also used by libraries.io. So linguist is now a point of bottleneck
With a fast growing community we would like to see syntax highlighted code. It's not a big ask
With almost 1000 followers on the core ponyc repo, its already evident that its popular enough
The quantity of repositories is not a good measure of significance for a new language, or its quality.
The sooner highlighting and libraries.io is in place, the better for tracking adoption rates.

Please reconsider the guidelines for pony and other programming languages that are clearly not hobby projects or side projects for inclusion in github as soon as possible or improve the contributing guidelines so that false measures of significance ( quantity, LOC, number of files ) don't preclude adding languages at an early stage of adoption.
It would be more polite, and a far better way to support new developer communities who can then benefit simply by levelling the field and offering our users the same experience on github as established languages. The lack of highlighting may actually hurt, hinder or diminish adoption rates.
As such, github is offering a disservice to its users, many of whom are polyglots, at the cost of them,
the new languages themselves, and commercial github users ( such as me ) with public and private repos where all the languages I use benefit from highlighting.
@manveru Thanks for the PR. You're a champion! :)
@arfon Please reconsider

@manveru @darach I'd be happy to merge a pr of the changes to lib/linguist/languages.yml to https://github.com/librariesio/languages to enable some Pony bits on https://libraries.io, of course once GitHub starts marking repos languages as Pony everything will start working automatically.

Thanks @andrew. Pints soon!

+1 :)

+1.
Well said @darach.

+1

:+1:

CI failure looks unrelated ("An error occurred while installing byebug (7.0.0), and Bundler cannot continue").

Thanks for the comment @darach.
I'm not sure that I agree with your comments about 'false measures of significance' but clearly Pony us gaining some significant community interest and so I'm happy to revisit this.

CI failure looks unrelated ("An error occurred while installing byebug (7.0.0), and Bundler cannot continue").

@jemc yep, let's get this merged and I'll try and dig into the Travis stuff later.
This change will go live in the next release of Linguist (next week some time).

@arfon +1
Tip of the hat to you for reopening and reconsidering. I do hope the contribution policy can be adapted to clarify what is reasonable and what isn't such that there's no ( or at least less ) ambiguity on what determines significance. Clearly the maintenance burden of a gazillion hobby projects isn't tenable or scalable but there needs to be some wiggle room for serious and promising languages like pony who may be light on significance by a single measure alone.

+1
I think we'll see some significant adoption soon.

+1 - Pony compares nicely with Go, Rust, OCaml, and Erlang. It is the highest performing actor language, while eliminating manual actor management.


Comment of Oracle

Description
When some comments sql submitted, but the soft fell in error, what should I do?
DBeaver Version
Dbeaver 7.2.4
Operating System
No response
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Hello @clearLove8080
Could you please provide the log files? You can find instructions here: https://dbeaver.com/docs/wiki/Log-files/. Thank you.

there have been no updates for a long time. If the issue is still actual - feel free to reopen it.


[Feature Request] Initial Integration of Workflows from LlamaIndex

Workflows provide an easy way to declare how something gets executed. Naturally, this means we should extend this concept to llama-agents
Now, there are a number of work items and different UXs to figure out. But a minimal first step, I propose

enabling workflows to be launched as service -- WorkflowService
creating a basic simple orchestrator, that routes purely based on service name (and could be exapanded to handle failures, retries, etc.)

What this WILL NOT address just yet

improving how services are created
improving how to launch a full llama-agents system

The above would be covered in future PRs

Moving this into some more separate issues, since this is really two in one
#179
#178


Insert pointer to object into parent object

In my project, we construct a lot of json::objects from scratch and then serialize it. It often happens, that a function creates a single 'inner' object, lets call it inner, which then has to be wrapped in multiple slightly different parent objects. These parent objects are then serialized.
So basically I am doing the following:
const object inner = createInner();
object parentA = createParent("foo");
object parentB = createParent("bar");
parentA["inner"] = inner; // copy happening :(
parentB["inner"] = inner; // copy happening :(
doSomething(serialize(parentA));
doSomething(serialize(parentB));

The problem here is that I have to create a copy of inner for each parent prior to the serialization. I can't move inner into parent because it's needed by multiple parents.
What I would like to do instead, is to just "link" inner into the parent with a (shared) pointer or something similar, so I can still serialize the whole parent object in a single call, but I don't have to copy the inner object. Basically I want to do something like this:
parentA["inner"] = &inner;

This is more or less how it works in JavaScript where everything is done with references and to actually "deep-copy" an object you have to do JSON.parse(JSON.stringify(obj)).
Is there a way to solve this problem with boost::json? Obviously the method above doesn't work for good reasons, but I'm wondering if I can do some magic with the memory resource objects, a custom type or a custom serializer?

I'm afraid, I don't see how this can be done with Boost.JSON. As an alternative, I can suggest keeping your data in a custom type, and then directly serialize from that type into JSON. We don't yet support direct serialisation, but I'm working on it. I suspect, I won't finish the work before the deadline for 1.86 release, so this means you'll have to wait until 1.87.
If you do need to stick to json::objects, then I don't have even a potential solution for you.

Thanks for the insights! I will experiment a bit with custom types, maybe I can make it work. The thing is, we're looking for an alternative to nlohmann's library, mainly because of the high memory usage of JSON objects. Having to copy the objects is even worse. Currently I'm serializing the inner and parent objects separately and then merge the raw strings....that works but it's really fragile and cumbersome.
Anyway, thanks again and I think this can be closed as I don't have any concrete idea how to implement it.


Implement the MultiCollect group

It would be the group retrieved with: Multi.collect()
Here are some of the methods from this group (on a Multi<T>):
Uni<T> first();
Uni<T> last();
Uni<List<T>> asList(); // Accumulate the results in a list
Uni<X> with(Collector<? super T, A, ? extends X>) // see https://docs.oracle.com/javase/8/docs/api/java/util/stream/Collector.html
Uni<X> in(Supplier<X> producer, BiConsumer<X, T> add)
Uni<Map<K, T>> asMap(Function<? super T, ? extend K> keyProducer)
Uni<Map<K, V>> asMap(Function<? super T, ? extend K> keyProducer, Function<? super T, ? extend V> valueProducer)
Uni<Map<K, Collection<T>>> asMultiMap(...)
Uni<Map<K, Collection<V>>> asMultiMap(...)

Merged in #1


[5.3] Minor code optimization in Manager

Makes that line a little too long :/

elseif is not required when we are only checking for two things. So something like this:
if (isset($this->customCreators[$driver])) {
    return $this->callCustomCreator($driver);
}

$method = 'create'.Str::studly($driver).'Driver'
if (method_exists($this, $method)) {
    return $this->$method();
}

So we only build the string if required, and avoid the line length issue.

Agree with Lidbetter, I thought the same. @taylorotwell okay for this one?


fix(costmodels): open cost model wizard from empty state action button

closes #955
//cc @dchorvat1

Codecov Report

Merging #958 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #958   +/-   ##
=======================================
  Coverage   74.44%   74.44%
=======================================
  Files         187      187
  Lines        3557     3557
  Branches      667      667
=======================================
  Hits         2648     2648
  Misses        817      817
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a86531...8cfcf97. Read the comment docs.

Thanks @dlabrecq


In Search of Knowledge book search step has empty requirements list in overlay

Ideally, this requirements text should not be shown because there are no requirements.

Should be fixed now, the issue was a Protect from Magic tip wasn't appearing.


"Office 365 authentication and identity" Content missing which is suppose to be as per https://docs.microsoft.com/en-us/office365/enterprise/hybrid-modern-auth-overview

"Office 365 authentication and identity" Content missing which is suppose to be as per https://docs.microsoft.com/en-us/office365/enterprise/hybrid-modern-auth-overview
Have it checked and update accordingly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077406d8-bff1-496e-3ea2-b38558fd9355
Version Independent ID: 57db3dec-2250-2dee-fd1a-ec6656911798
Content: Office 365 URLs and IP address ranges
Content Source: Enterprise/urls-and-ip-address-ranges.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@NeeranjanShettar Thank you for this feedback
I will make sure to get this over to the Enterprise team for investigation.
The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@NeeranjanShettar A fix to the original article at https://docs.microsoft.com/en-us/office365/enterprise/hybrid-modern-auth-overview is in progress.

Thanks, Joe.. How about for this article where "Office 365 authentication and identity" Content missing which is suppose to be as per https://docs.microsoft.com/en-us/office365/enterprise/hybrid-modern-auth-overview ? is it something Enterprise team are going to modify the statement in the original article ?
Thanks in advance.

Is there any update ?

@NeeranjanShettar Sorry for the delay. The article has been updated to point to the new rows in the "Office 365 URLs and IP address ranges." Thanks for letting us know.

Excellent, really appreciated.


WIP: #26 Render markdown to static content

Create class/component StaticContent
Add package Marked
Use 'marked' to parse markdown to static html and show right next to the markdown by dangerouslySetInnerHTML

@trinhlaosu This pull request has wrong purpose.


DefinePlugin definition not set in ReactJS v16 Component

Bug report

What is the current behavior?
Definitions defined in DefinePlugin from webpack is not referencable or not set in ReactJS component
If the current behavior is a bug, please provide the steps to reproduce.
From any webpack config driven react app, use DefinePlugin in the webpack config, set some definition, access the same from a ReactJS v16 component

What is the expected behavior?
Expecting DefinePlugin definitions to be able to reference inside ReactJS v16 components

Other relevant information:
webpack version:  4.3.0
Node.js version: 8.11
Operating System: Mac OS X
Additional tools: babel

Thanks for your report. It would be great if you reduce your issue to a small reproducible example. Best put this example into a github repository together with instructions how to get to the problem.

Never mind
I had to completely kill existing web pack builds and rebuild totally to get this resolved, not sure if it is some kind of cache issue
If we are in watch mode, the plugin effect is not visible, so we have to stop, remove built bundle and then rebuild to see the effect
Hence I am closing this issue


Address NetStat noise level when sudo and/or lsof are not operating a…

…s expected
This commit reduces the log chatter emitted by NetStat.Platform.LINUX when
sudo/lsof fail or do not produce the expected results.  The block message
emitted when sudo/lsof fails is enhanced to include the PATH environment
variable value, eliminate the logged stack trace, and be emitted only the
first time the condition is encountered.  Code is also added to log when
lsof returns no TCP results as would happen when the /proc file system
lacks network support.

@akomakom @cljohnso : is there a possibility to update either the Jenkins file or azure file to add a step to build inside a docker container ?

@akomakom @cljohnso : is there a possibility to update either the Jenkins file or azure file to add a step to build inside a docker container configured the same way (lo interface used only) ?

FYI, there is a way to reproduce the current issue with lsof to confirm that the new behaviour is tested.
See PR: https://github.com/Terracotta-OSS/terracotta-utilities/pull/36
The idea is to use GA to setup a build running on a docker container (MS Zulu 8):
name: Making some noodles

on:
  workflow_dispatch:
  pull_request:
  push:
    branches:
      - master
      - lsof # just to be able to run all these builds on our own fork
jobs:
  container:
    runs-on: ubuntu-latest
    container: mcr.microsoft.com/java/jdk:8-zulu-cento
    steps:
      - uses: actions/checkout@v2
      - name: Test with Maven
        run: ./mvnw clean verify -V -B -D"maven.artifact.threads=64" -D"org.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn" -DfailIfNoTests=false -Dtest=NetStatTest

Of course this config needs to be updated if we add that to the project. Right now, it enables to run the build inside a forked branch.
Here is the build output from my fork: https://github.com/mathieucarbou/terracotta-utilities/runs/5246636625
The same error is encountered:
org.terracotta.utilities.test.net.NetStat$HostExecutionException: Failed to obtain active TCP ports using 'lsof'

********************************************************************************
Obtaining a full set of in-use TCP ports requires use of 'sudo' to execute
'lsof'; add sudoers permissions to allow this.  For example, add a line like the
following to the bottom of the '/etc/sudoers' file (using 'sudo visudo'):
    %sudo   ALL=NOPASSWD: /usr/bin/lsof
Ensure an appropriate group or username is used in place of '%sudo' and the
correct path to 'lsof' is used.
********************************************************************************

So I strongly suggest we make use of GA build for this project... Both to enable  macos builds and also inside docker container builds. This is the second PR for which I am building a GA script to verify.

So I strongly suggest we make use of GA build for this project... Both to enable macos builds and also inside docker container builds. This is the second PR for which I am building a GA script to verify.

Done in PR: https://github.com/Terracotta-OSS/terracotta-utilities/pull/36. Merging this PR will add the macos / container builds and also Java 11 builds that were missing.

The latest update to the commit stream
. Changes how PortManager.diagnosticReleaseCheck interprets an empty response from NetStat.info() (disables the release check)
. Adds TestSupport.sudoLsofWorks to enable the skipping of tests in environments where sudo/lsof don't behave as expected
. Skips PortMangerTest.testReleaseCheckEnabled and NetStatTest.testInfo on Linux platforms where sudo/lsof aren't cooperative
@chrisdennis would suggested making the TestSupport.sudoLsofWorks more Hamcrest-like.  I agree with his proposal but prefer to take that on at another time.  (I prefer to get this and the other PR -- with CI updates -- merged sooner than later.)

If possible, I'd like someone to try this out in a Docker image of some ilk.

You can check the results of my test branch here: https://github.com/mathieucarbou/terracotta-utilities/actions/runs/1884731142
The test branch contains a merge of #35, #32, #37


Update mkdocs-contributor-guide to include mike dependency

This PR improves the documentation for the contributors.
I wanted to contribute to kserve/website and I could not get the webiste running locally with the proposed documentation.
We need to install mike in order to make mkdocs serve work.

/assign @andyi2it

@AlexandreBrown Thanks for the fix! Can you help sign off the commit with the instruction ?

@yuzisun Done

Thanks @AlexandreBrown !
/lgtm
/approve


Release Issue with aws-sam-translator 1.23.0

aws-sam-translator 1.23.0   is deployed with its tests package to pypi.
This causes conflicts with other projects and causes downstream issues with people using other test runners.
Could this be fixed in a patch release please.

Looks like there is different behavior between sdist and whls. Tests are excluded from sdist by our current setup but not whls.
For now, use the sdist if this is impacting you.

This should no longer be the case with 1.24.0.
Closing


Implementa a sessão

@thebergamo RFR

Current coverage is 96.78% (diff: 96.66%)

Merging #70 into backend will increase coverage by 0.64%

@@            backend        #70   diff @@
==========================================
  Files            15         21     +6
  Lines           311        467   +156
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            299        452   +153
- Misses           12         15     +3
  Partials          0          0

Powered by Codecov. Last update aabd929...0e25ad2

@thebergamo RFR


Trouble using DeepExplainer

AttributeError: module 'keras.backend.tensorflow_backend' has no attribute '_SESSION'
I get this error when using a keras neural network as a model. I have checked the keras module and there is no _SESSION attribute to be found. It looks like deep_tf.py checks if there is an open tensor flow session but also cheks for this _SESSION attribute. Is it possible to fix this error?

Hello, I have the same error. I'm trying to use the DeepExplainer on my Keras model.

I finally figured it out. You have to downgrade your keras version to 2.2.5. The latest shap version in pip just works on keras 2.2.5

This is fixed on master now :)

Hi @slundberg ,
When I am running this code, I am getting the following error. I have tried installing/uninstalling few combinations of tensorflow/keras. Nothing seems to resolve it. Can you kindly advise? Thank you.
Error:
nonlinear_mxts_mode is set to: DeepLIFT_GenomicsDefault
AttributeError                            Traceback (most recent call last)
 in
6     kc.convert_model_from_saved_files(
7         'my_model.h5',
----> 8         nonlinear_mxts_mode=deeplift.layers.NonlinearMxtsMode.DeepLIFT_GenomicsDefault)
9
10 #Specify the index of the layer to compute the importance scores of.
/usr/local/lib/python3.7/site-packages/deeplift/conversion/kerasapi_conversion.py in convert_model_from_saved_files(h5_file, json_file, yaml_file, **kwargs)
398             layer_config["config"]["weights"] = layer_weights
399
--> 400     return model_conversion_function(model_config=model_config, **kwargs)
401
402
/usr/local/lib/python3.7/site-packages/deeplift/conversion/kerasapi_conversion.py in convert_sequential_model(model_config, nonlinear_mxts_mode, verbose, dense_mxts_mode, conv_mxts_mode, maxpool_deeplift_mode, layer_overrides, custom_conversion_funcs)
444     batch_input_shape = model_config[0]['config'][KerasKeys.batch_input_shape]
445     converted_layers.append(
--> 446         layers.core.Input(batch_shape=batch_input_shape, name="input"))
447     #converted_layers is actually mutated to be extended with the
448     #additional layers so the assignment is not strictly necessary,
/usr/local/lib/python3.7/site-packages/deeplift/layers/core.py in init(self, batch_shape, **kwargs)
199         self._num_dims = len(batch_shape)
200         self._shape = batch_shape
--> 201         self.activation_vars = tf.placeholder(
202                                  dtype=tf.float32, shape=batch_shape,
203                                  name="inp"+str(self.get_name()))
AttributeError: module 'tensorflow' has no attribute 'placeholder'
Code:
from tensorflow.keras.layers import Dense, Input, LSTM
from tensorflow.keras.models import Model
from tensorflow.keras.models import Sequential
from tensorflow.keras.models import load_model
import deeplift
from deeplift.conversion import kerasapi_conversion as kc
classifier = Sequential()
classifier.add(Dense(16, activation='relu', kernel_initializer='random_normal', input_dim=88))
classifier.add(Dense(8, activation='relu', kernel_initializer='random_normal'))
#Output Layer
classifier.add(Dense(1, activation='softmax', kernel_initializer='random_normal'))
#Compiling the neural network
classifier.compile(optimizer ='adam',loss='binary_crossentropy', metrics =['binary_accuracy'])
classifier.fit(X_train,Y_train, batch_size=100, epochs=5)
classifier.save('my_model.h5')
deeplift_model =
kc.convert_model_from_saved_files(
'my_model.h5',
nonlinear_mxts_mode=deeplift.layers.NonlinearMxtsMode.DeepLIFT_GenomicsDefault)
find_scores_layer_idx = 0
deeplift_contribs_func = deeplift_model.get_target_contribs_func(
find_scores_layer_idx=find_scores_layer_idx,
target_layer_idx=-1)
scores = np.array(deeplift_contribs_func(task_idx=0,
input_data_list=[X],
batch_size=10,
progress_update=1000))


fix: set recursion bail point based on system limits

Hello, thanks for your useful project!
I was analysing a very big S3 bucket (big in size and # objects) and the layout algorithm exceeded my recursion limit, which is clearly less than the 1,000,000 bail point set in _squarify.
This PR just sets the bail point based on python's reported recursion limit (minus a little headroom for other calls).
I'm afraid I can't really provide a useful test case, I hope this is useful nonetheless.

Thank you much!


Adding Ultrasound Sensors into Starndard Turtlebot4

Hello,
I am currently integrating ultrasound sensors into the Turtlebot4 Standard robot. Having successfully connected and configured the sensors, my next step is to initiate the sensor topic upon the robot's startup. I believe the robot's services are started with the turtlebot4_bringup package, particularly the standard.launch.py file. However, I haven't been able to locate this package on the robot. Could you please confirm if I am on the right track? If so, could you provide information on the location of the turtlebot4_bringup package and the standard.launch.py file?
Additionally, I need to modify the URDF of the robot to incorporate the sensor positions. If you could guide me to the location of that file as well, I would greatly appreciate it.
Thank you in advance.
Best regards,
Itsasne

You are indeed on the right track. To make those changes you should build the packages from source. If you did locate the files and modify them, they would be overwritten when you update the packages next. A rough outline of steps are (I have erred towards a mid level of detail not knowing your background with programming / ROS and to help others who may read this):
Building from source

Create a workspace on your robot
Clone the turtlebot4 and turtlebot4_robot packages into it, source ros and then build the packages
Once you can successfully built your packages then you can move on to modifying them

Modifying the packages

As you deduced the turtlebot4_bringup package has the launch files, specifically standard.launch.py which is the top level launch file.
The urdf files are found in the turtlebot4 common package. Specifically turtlebot4.urdf.xacro is going to be your top level urdf.

Setting up the robot to use the locally built packages

Link to your custom workspace using the turtlebot4-setup tool:

run turtlebot4-setup
navigate to ROS Setup -> Bash Setup
select WORKSPACE_SETUP
enter the path to your local setup.bash for your workspace. This will allow the turtlebot4 setup tool to locate and source these packages. e.g. /home/administrator/ros_ws/install/setup.bash

Reinstall the turtlebot4 service using the turtlebot4-setup tool under Robot Upstart -> Install.

run turtlebot4-setup
navigate to ROS Setup -> Robot Upstart
select Install and agree as necessary
Now your robot should automatically run your local build whenever it is turned on.

During local testing you may want to be able to launch directly instead of always restarting the service to adopt new changes. You can do this, just go under the Robot Upstart section again and stopping the service. Then you can call the launch files directly as per normal without interference and see the output in your terminal.


Update linmath to upstream.

This fixes bug in linmath.h unused function: quat_mul_vec3
Linmath is taken from upstream: https://github.com/datenwolf/linmath.h
Added function definition: degreestoradians

Author dwolowb not on autobuild list. Waiting for curator authorization before starting CI build.

Author dwolowb not on autobuild list. Waiting for curator authorization before starting CI build.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Thomas Paine seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Oh right, due to policy you'll have to sign the CLA. Should be as simple as clicking the link and agreeing to it.

Author dwolowb not on autobuild list. Waiting for curator authorization before starting CI build.

Author dwolowb not on autobuild list. Waiting for curator authorization before starting CI build.

Author dwolowb not on autobuild list. Waiting for curator authorization before starting CI build.

Hi, this pull request is now passing all checks. There was a warning on windows about float/double conversion that has been fixed with explicit float casts.
As a recap, then changes made:

Update linmath.h from upstream.
Add degreestoradians function.
Cast doubles as floats in unused function: mat4x4_arcball

As a note the linmath.h added in this PR does not contain the copyright at the top of the file.

Because linmath.h isn't from this repo, I'm not sure whether it should have a copyright for people who didn't write it.
Thank you for going ahead and fixing the compiler issues. I'll go ahead and merge it in :)


Intro notebooks fail

Steps to reproduce: start the notebooks with ./notebook.sh, opened two demos and click "Restart kernel and re-run the whole notebook".
Introduction-to-GraphBLAS-with-Python fails with the following error:
with MIN:
    C = A + B
draw_op(A, '+', B, C)

---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-4-b2cffb484ccb> in <module>
----> 1 with MIN:
      2     C = A + B
      3 draw_op(A, '+', B, C)

NameError: name 'MIN' is not defined

This would seem easy to fix with MIN -> min. However, that does not solve the problem because it results in an AttributeError: __enter__ (see below)
Intro-Prez fails with the following error:
with min:
    C = A * B

draw_op(A, '*', B, C)

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-9-05d8ab4e12d3> in <module>
----> 1 with min:
      2     C = A * B
      3
      4 draw_op(A, '*', B, C)

AttributeError: __enter__

There are also subsequent errors with the min_plus semiring missing and later module 'pygraphblas.binaryop' has no attribute 'div' in PageRank.

Thanks @szarnyasg I fixed them up and repushed them.  The difference is that I've removed many of the names from the top level namespace of the package, to get to an "automatic" operator, you can do binaryop.TIMES  or the non-automatic form of INT64.TIMES or binaryop.TIMES_INT64 to be explicit. Since operators aren't imported into the top level namespace, it's a lot smaller and faster to import.  About to do a 3.2.2 release and am redoing the docker image builds a bit to remove some of the file pollution in there as well.


toJSON not deleting fields in associations

In activity.js (some model)
    // One-Way association with User model
    createdBy: {
        model: 'user'
    },

In user.js:
    toJSON: function() {
        var obj = this.toObject();
        delete obj.password;
        delete obj.createdAt;
        delete obj.updatedAt;
        return obj;
    }

When I retrieve Activity object,
         "createdBy": {
             "name": "John Smith",
             "password": "$2a$10$D6zIThptFHyzA48mOwPUPOSaO83z0Mlw6JAuXgiKUJhCuz.ZIgj1q",
             "createdAt": "2015-02-09T19:38:48.016Z",
             "updatedAt": "2015-02-16T18:24:55.001Z",
             "id": "54d90cc8d9b60440148bdea3"
         },

Quick fix:
in activity.js toJSON function:
        if (obj.createdBy) {
            delete obj.createdBy.createdAt;
            delete obj.createdBy.updatedAt;
            delete obj.createdBy.password;
        }

A generic solution would be great.

Good call @NizarBlond.  Thanks for the note.

hey @NizarBlond, @sgress454  I'll be taking a look at this today. I'll come back later if found something.

@NizarBlond I'm using following model definition. The toJSON method is filtering out correctly in Activity.js. Did you define toJSON within attributes block in User's model ?
Any other guidance in order to replicate the issue?
// User.js

module.exports = {
  attributes: {
    password : {
      type : 'string'
    },

    toJSON: function() {
      var obj = this.toObject();
      delete obj.password;
      delete obj.createdAt;
      delete obj.updatedAt;
      return obj;
    }
  }
};

// Activity.js

module.exports = {
  attributes: {
    createdBy: {
      model: 'user'
    }
  }
};

// Result when retrieving an activity
{
    "createdBy": {
        "id": 1
    },
    "id": 1,
    "createdAt": "2015-03-24T16:18:43.220Z",
    "updatedAt": "2015-03-24T16:18:43.220Z"
}

@NizarBlond Would it be more accurate to say that toJSON is not being executed when associations are being retrieved?

So, is this a bug? Has it been resolved?


On Checking prerequisits

When running DeployAzGovViz section I get the following error msg
Initializing Az Module Complete
Running Az PowerShell Script
/usr/bin/pwsh -NoLogo -NoProfile -NonInteractive -Command /home/runner/work/_temp/ca514f13-cd11-4a71-bf5c-34ed2b880d6d.ps1
CodeRunPlatform: GitHubActions
Testing if repository 'https://github.com/Ashley72/AzGovViz' is accessible from the public
Test returned statusCode: '200' - 'https://github.com/Ashley72/AzGovViz' is accessible from the public!
Assuming and insisting that you do not want to publish your tenant insights to the public - throw
Exception: /home/runner/work/AzGovViz/AzGovViz/pwsh/prerequisites.ps1:39
Line |
39 |              throw
|              ~~~~~
| ScriptHalted
Error: Error: The process '/usr/bin/pwsh' failed with exit code 1

Hi @Ashley72  you need to set your repository to be private for the rest of the setup to proceed


Fix that shouldUseWeakMemoryCache code was lost during merge conflict

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...
Pull Request Description
This is a bug that during when I'm solving the merge conflict from master to 5.x branch. The shouldUseWeakMemoryCache property does not do anything. So this PR fix it.

Codecov Report

Merging #2421 into 5.x will increase coverage by 0.06%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##              5.x    #2421      +/-   ##
==========================================
+ Coverage   67.41%   67.48%   +0.06%
==========================================
  Files          47       47
  Lines        6668     6676       +8
==========================================
+ Hits         4495     4505      +10
+ Misses       2173     2171       -2

Flag
Coverage Δ

#iOS
68.44% <50%> (+0.07%)
:arrow_up:

#macOS
67.21% <ø> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

SDWebImage/SDMemoryCache.m
71.42% <50%> (-2.07%)
:arrow_down:

SDWebImage/SDWebImageManager.m
81.3% <0%> (-0.82%)
:arrow_down:

SDWebImage/SDWebImageDownloader.m
81.08% <0%> (-0.34%)
:arrow_down:

SDWebImage/SDWebImageDownloaderOperation.m
86.88% <0%> (+2.95%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4823e...42caecf. Read the comment docs.


Refactor concurrency handling in connect command

Description:

Refactored the concurrency handling in the connect command by replacing custom goroutine management with errgroup for cleaner and more reliable concurrency handling.
Updated go.mod and go.sum to include the new dependency on golang.org/x/sync v0.10.0.
Simplified error handling while maintaining functionality.

Codecov Report
Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (4902fa5) to head (7fb2de6).

Files with missing lines
Patch %
Lines

pkg/cmd/connect.go
82.35%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   80.65%   80.62%   -0.03%
==========================================
  Files          19       19
  Lines        1556     1533      -23
==========================================
- Hits         1255     1236      -19
+ Misses        262      258       -4
  Partials       39       39

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: execute Git hook within DDev

Resolves OTDEVOPS-310
Someone able to test this approach with Magento and Bitbucket Pipelines as well?
I'm in the phase of setting up Testing Suite for my very first time (shame on me). Not being able to use the PhpStorm Git integration is a deal breaker for me so I figured to create a solution for this problem.

I would prefer to see this as a major version number, and forcing commands to be run within DDEV. We should not be using git within the DDEV environment, but on the host instead.

@youwe-petervanderwal could you  also list this new feature in the README.md please?


Have you compared SFA3D with complex_yolov4? Which algorithm is better?

Hi @vivi0604
I prefer SFA3D because of its practical applications in terms of balancing both accuracy and speed (both training and inference phases).
The ComplexYOLO model requires us to choose good pre-defined anchors that is not an easy task for the rotated boxes detection.


feat: add ci-cd

Pull Request Type
Dictionary of Definitions here:
https://ben.balter.com/2015/12/08/types-of-pull-requests/

[x] Just a heads up 🙆
[ ] Sanity check 🏃♂
[ ] Work in progress (WIP) 🏗
[ ] Early feedback ✍
[ ] Line-by-line review 📝
[ ] Pull request to a pull request 🔀

Description
Added Circle CI for our CI/CD! We can run our unit, integration, etc tests via here!
Screenshots (optional)
[Upload optional screenshots, but encouraged for FE tasks]
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] If it is a core feature, I have added thorough tests.
[x] Extended the README / documentation, if necessary
[x] My changes generate no new warnings
[x] Is the code readable? Prefer to see more self-explanatory and consistency
[x] Is the code tested properly? i.e. where appropriate, we're testing well-explained failures, behaviours, fixes, etc

Memes Are welcomed

Test's are finally passing!


Filter should eliminate cinematographer

Describe the bug
rg -w -e actor -e actress -e writer -e director -e producer
doesn't filter out "director of cinematography"
To Reproduce
rg -wNz nm0183770 title.principals.tsv.gz | rg -w director | head -1
tt0320920	8	nm0183770	cinematographer	director of photography	\N
Expected behavior
Don't return fields that have director of photography, only ones that have director in a field by itself

Fixed.
Also added a -a switch to generateXrefData.sh which allows all jobs, not just actor, actress, writer, director, and producer

Fixed.
Also added a -a switch to generateXrefData.sh which allows all jobs, not just actor, actress, writer, director, and producer


Jenkinsfile Modification: Unexpected End-of-Comment Behavior

When running the AddOrModernizeJenkinsFile recipe, the generated comment does not create a new line. As a result, the subsequent buildPlugin statement is appended to the comment, rather than starting on a new line.
You can see this issue in this pull request.
Reproduction Steps

Run the AddOrModernizeJenkinsFile recipe on a plugin with an outdated Jenkinsfile.

Expected Behavior
The recipe should add a new line and carriage return after the comment.
Actual Behavior
The comment does not create a new line, and the buildPlugin statement is appended to it.

Is it and issue with plugin modernizer or rewrite-jenkins ? From wat I remember we don't modify and Jenkinsfile here but just use a recipe from rewrite-jenkins

Or even with rewite-groovy that fail to parse a correct LST ?

Yes, that's also what I think, but I prefer to have it logged here before forgetting about it.

What is strange is that the newline is in the OpenRewrite recipe.

This is an issue with the groovy parser.
Rewrite-jenkins do a wrong assertion
https://github.com/openrewrite/rewrite-jenkins/blob/a53f97d154aaf26b85cfb771bf80bc4fae767701/src/test/java/org/openrewrite/jenkins/ModernizeJenkinsfileTest.java#L109
We will need to fix it before doing other Jenkinsfile modification. For the moment we just need to add the file if missing

Possible fix by https://github.com/openrewrite/rewrite-jenkins/pull/85
I'v tested the use case on rewrite groovy. Was not able to reproduce the issue
At the end was only because the YAML block was trimming empty line when creating the text file

That's why https://github.com/jenkins-infra/plugin-modernizer-tool/pull/524/files didn't show the issue
I would suggest we use exclusively this even if overwriteExisting: false I would prefer we are not harmless for the moment and don't override the file until we are able to parse it and perform modification to it
This is tracked by https://github.com/jenkins-infra/plugin-modernizer-tool/issues/531
Closing the issue then


Update target API level

As you may have noticed by Play Console, the app is currently only available on devices running Android OS at or below the app's target API level (i.e. 28). Any new update must target API level 33 or above. (Play Console Help)
I am willing to work on this app and contribute some maintenance and feature code.
As a starting point, I suggest updating the dependencies and other build configurations.

Yeah I stopped maintaining this since I stopped using trello.
If you're willing to take it over I'm happy to give you admin access.

That's fine. But can I count on you for code reviews or issue discussions?
I have created a pull request for this issue #41
After that, I want to work on the architecture and implement some new components / migrate some current components to make the code more maintainable.

Well as an admin you wont need code reviews. I don't have time to do that. Happy to to discuss whatever every once in a while though.

Okay. So would you please merge the PR or give me access to do that?

I've added you as collaborator. Let me know if that lets you merge.

All right. I merged the PR ^^
Currently I don't have a Play Console account, but I can get one if needed.

You're gonna need one if you want to publish these changes.

I'll let you know as soon as I get an account.


add tests to validate that fees are working

Create unit tests to verify correctness of non-zero fees. There are a few cases to consider:

single large note > amount + cumulative fees --> success
single small note < amount + cumulative fees --> failure
multiple smaller notes > amount + cumulative fees --> success
multiple smaller notes < amount + cumulative fees --> failure
exact note for amount + another large note > amount + cumulative fees --> success
exact note for amount + another small note < amount + cumulative fees --> failure

tagging https://github.com/penumbra-zone/web/pull/690 for visibility.


Make non-deterministic tests deterministic by injecting state through RethinkDB

One example of this that I found is TestPipelineTransientFailure which fails a random number of times and then succeeds. To control this test a little better, I want to write a utility that can be used anywhere a job needs a PRNG, but stores the PRNG state in RethinkDB, so that every time we run the test, the jobs we start see the same sequence of random numbers, and the test always takes the same amount of time.

Hmm but wouldn't we need those PRNG to be persistent across databases? (Or keystores, if we replace 'rethink' w 'etcd')
This would be helpful to make CI a bit less jittery, but only if it persists across data stores I think.

Updating title 'rethink' -> 'etcd'

We made integration tests run in sequence, which has made them relatively more stable. Since this seems to ameliorate the issue, and this issue is stale, I'm closing it.


Replace WebClient with HttpClient across DDS

DDS codebase uses WebClient extensively, this should be replaced throughout by HttpClient as WebClient is deprecated in .NET Core.

[x] DlcsWebClient
[x] Storage Service API Client
[ ] Many other small usages

Closing this as we can't tick the last box in this phase of work - we have done all the Milestones 1-3 usages.


Uncaught TypeError: Cannot read property 'map' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 1.2.4
System: Mac OS X 10.11.1
Thrown From: jupyter-notebook package, v0.0.3
Stack Trace
Uncaught TypeError: Cannot read property 'map' of undefined
At /Users/duy/other/git/atom-notebook/lib/notebook-editor.js:268

TypeError: Cannot read property 'map' of undefined
    at NotebookEditor.loadNotebookFile (/Users/duy/other/git/atom-notebook/lib/notebook-editor.js:268:42)
    at new NotebookEditor (/Users/duy/other/git/atom-notebook/lib/notebook-editor.js:41:12)
    at openURI (/Users/duy/other/git/atom-notebook/lib/main.js:71:80)
    at Workspace.module.exports.Workspace.openURIInPane (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:454:22)
    at Workspace.module.exports.Workspace.open (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:393:19)
    at TreeView.module.exports.TreeView.openSelectedEntry (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/tree-view/lib/tree-view.js:736:31)
    at TreeView.module.exports.TreeView.entryClicked (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/tree-view/lib/tree-view.js:462:18)
    at tree-view-file.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/tree-view/lib/tree-view.js:183:26)
    at space-pen-div.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:4435:9)
    at space-pen-div.elemData.handle (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:4121:28)

Commands
     -2:34.1.0 core:paste (atom-pane.pane.active)
     -1:29 tree-view:remove (span.name.icon.icon-file-text)

Config
{
  "core": {}
}

Installed Packages
# User
api-workbench, v0.8.6
jupyter-notebook, v0.0.3
linter, v1.11.3
linter-reek, v2.1.0
react, v0.12.10

# Dev
No dev packages

The offending line: https://github.com/jupyter/atom-notebook/blob/19245eea52aeccf945e0aca25115c9a67f2f7516/lib/notebook-editor.js#L268
Can you paste the contents of your notebook file? It looks like it doesn't have a cells property...did you try to open an empty ipynb file?

https://github.com/jupyter/atom-notebook/commit/929f08d0ff925fc321fefbcc16906f5776c9e092 should fix this. Test against atom-notebook 0.0.4 and let me know for sure.


How to use with picasso.

It's still unavailable now, read the "todo" section in README please.

I see.

其实只是个下载器，无所谓picasso和glide.


FIX-#4845: Fixed KeyError from __getitem_bool for single row dataframes

Signed-off-by: Bill Wang<EMAIL_ADDRESS>
What do these changes do?

Adds check in __getitem_bool for 1 dimensional objects and corresponding test. Resolves KeyError issue with trying to index a dataframe at a boolean value df[True].

[x] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date
[x] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

@Billy2551 there might be a merge conflict, so I would pull from upstream and rebase your changes.