Add Milwaukee

@dabreegster I was able to follow the instructions in the docs to add Milwaukee as a map. I ended up doing one for the entire city and another box for the Oak Creek area (which is one area of research for me currently). Please let me know if you need anything else from me.

Hi Trevor!

You can remove elevation_input/query; that's not meant to be committed. Part of the import process tries to run a Docker container that for gathering SRTM elevation data. But the container isn't on DockerHub yet, so it literally only works on my machine -- I still need to finish productionizing this part. In the meantime, we could also add elevation_input/query to .gitignore to prevent other people from hitting this issue.

The boundaries are huge. The smaller one, Oak Creek, comes out to 167MB for the final map (data/system/us/milwaukee/maps/oak_creek.bin). There's not a specific limit in place, but it's going to be hard to iterate quickly on large areas like this -- just try loading Oak Creek in the UI when running in debug mode (compiling without --release). I would recommend splitting into smaller pieces, which can overlap if needed. An example for Paris:

It may take a bit of trial-and-error to tune the size. It also depends what you're looking to study. In Seattle, we've carved out a bunch of small regions just to focus on particular roads:

git rm elevation_input/query should work. Adding a file to .gitignore doesn't automatically remove it from version control, it just prevents it from being added accidentally later

Sorry for all of the commits @dabreegster I am a bit rusty. Should be straightened out now. I tried to select much smaller areas, hopefully, the sizes are tolerable.

No worries, I remember how long figuring out gitignore took the first time.
The map size is much better now! Two more tweaks, and I think we're good to go.

Rename the map to just downtown. Since the maps are already scoped to a country and city, I'm trying to avoid repeating downtown_milwaukee in the map name
Let's adjust the downtown boundary to this:

boundary
1
     -87.89968013763428    43.023772650062504
     -87.88320064544678    43.025749189659685
     -87.87135601043701    43.05962282888517
     -87.93572902679443    43.06106517973023
     -87.9391622543335    43.02261179555704
     -87.89968013763428    43.023772650062504
END
END

The one in the PR right now winds up looking like this:

This is due to #32. Through trial and error, I figured out that we were clipping the southern edge of https://www.openstreetmap.org/relation/5900827, and the algorithm that tries to create water polygons got confused. If we just cover the full southern end of it, it looks much better:

Thank you for the new bbox!

Thanks for the patience with this process! Everything here looks good, so I'll squash merge and push the pre-built maps to S3.


Exception: TypeError('Operator() takes no arguments')

Hi, I had some issue to run devito, please see below codes:
(Looks like once I added from devito.checkpointing import *, the error will come out.
Error:
`
Trying to allocate more memory for symbol u than available on physical device, this will start swapping
TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_82665/464761434.py in
43
44     # For illustrative purposes, assuming that there is enough memory
---> 45     op_imaging = ImagingOperator(model, geometry, image, space_order)
46
47     vv = TimeFunction(name='vv', grid=model.grid, staggered=None, time_order=2, space_order=space_order)
/tmp/ipykernel_82665/2604718868.py in ImagingOperator(model, geometry, image, space_order, save)
23     image_update = Eq(image, image - u * v)
24
---> 25     op = Operator(([stencil] + res_term + [image_update]), subs=model.spacing_map)
26     return op
27
TypeError: Operator() takes no arguments
`
Here are all codes related to this:
`def ImagingOperator(model, geometry, image, space_order, save=True):
v = TimeFunction(name='v', grid=model.grid, time_order=2, space_order=8)

u = TimeFunction(name='u', grid=model.grid, time_order=2, space_order=8,
                 save=geometry.nt)

eqn = model.m * v.dt2 - v.laplace - model.damp * v.dt

stencil = Eq(v.backward, solve(eqn, v.backward))

dt = model.critical_dt
residual = PointSource(name='residual', grid=model.grid,
                       time_range=geometry.time_axis,
                       coordinates=geometry.rec_positions)
res_term = residual.inject(field=v, expr=residual * dt**2 / model.m)

image_update = Eq(image, image - u * v)

op = Operator(([stencil] + res_term + [image_update]), subs=model.spacing_map)
return op

`
then
op_imaging = ImagingOperator(model, geometry, image, space_order, save=False)
Thanks.

Hi @FJGEODEV , did you try some problem that indeed will allocate more memory on your device?
What was the size of the problem you tried?

Hi, the system memory is good enough. I tried to
define this first:
op_imaging = ImagingOperator(geometry, image, space_order, save=False)
then import those:
    from devito import DevitoCheckpoint, CheckpointOperator
    from devito import ConditionalDimension
```

In this way, it works good. This is kind of workaround, but I am still not sure what's going on with them.


[FLINK-31719][Build/Shaded] Update Netty to 4.1.91.Final

Flink CI run with this updated version: https://dev.azure.com/martijn0323/Flink/_build/results?buildId=4058&view=results


⚠ Bofrost.at has degraded performance

In ad0fc27, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 915 ms

Resolved: Bofrost.at performance has improved in 9171bd2 after 7 minutes.


Invalid bearer token

I used this token in Prometheus config.
using tcpdump checked HTTP headers from prometheus to gateway:
User-Agent: Prometheus/2.10.0
Content-Length: 8805
Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJPbmxpbmUgSldUIEJ1aWxkZXIiLCJpYXQiOjE1NzE4NDg3ODYsImV4cCI6MTYwMzM4NDc5OSwiYXVkIjoid3d3LmV4YW1wbGUuY29tIiwic3ViIjoianJvY2tldEBleGFtcGxlLmNvbSIsIm5hbWUiOiJteV9wcm9tb18wMSJ9.09gkgEpCu9ryGCRc2DolJDNh5gVY7HG8otAIt0XmdFU
but still getting "Invalid bearer token" in response.  Signing key is provided to gateway. What is wrong with y JWT? What gateway is expecting in JWT payload? Is there any debug log flag which will provide more information from gateway?

Hey,
it's poorly documented because I did not expect anyone to use the gateway at the moment.
Take a look at these struct tags, which represent the expected payload in the Bearer tokens: https://github.com/weeco/cortex-gateway/blob/master/gateway/tenant.go#L7-L11


Support fuzzy matching on the absolute paths of files/resources

We now apply fuzzy matching on the (absolute) path of files/resources,
which allows fuzzy matching to work even if the user has a partial
absolute path or subpath which is rooted in folders outside of the
workspace folders.
I left a FIXME in the code  - I'm not sure if we should try to add a minimum score threshold or maybe think of another way to avoid really fuzzy matches (e.g. typing someRelativelyLongString and having tiny matches across tens of path components due to long absolute paths). Please let me know what you think.

It looks like the tests are failing due to changes in the search behavior causing more results than before especially for simple searches - maybe to work around this, we should only do this behavior for searched contains path separators? Any opinions?

The remaining test failures are because the fuzzy matching now gives many more matches since short queries like site.* in FileSearchEngine Files: *.* without derived: match against fragments of path components. Any suggestions on how to improve this? Maybe we shouldn't we shouldn't support fuzzy matching on the absolute paths, only exact matches?

What is the issue this is trying to address?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

Sorry, missed this. The main motivation is that we have files in our code-workspaces which are referenced currently via their folder-relative path, but in many places elsewhere, the paths given are relative to the monorepo. This causes issues when searching, since the monorepo path is longer than the relative path and then search doesn't work.


.RDP Password Attribute

Allow password to be stored in .RDP file, parsed and settings
updated, this will allow for dynamic .RDP files to be created with
complete login credentials, using this method the username, server and
password will no longer be visible within process lists.
Also fixed bug with username being
set to null by command line processor if the command line parameter not specified but the value set from the .RDP files.
Usage: create .RDP file, add line
password:s:XXXXXX where XXXXXX is the password

@freerdp-bot test

@freerdp-bot test please

@bigpjo Sorry for the change of mind, just found this issue when retesting your pull.

As a remark: Although this is a possible solution we haven't added "password" support in .rdp files yet because you then possibly have files lying around with plain passwords. So if you don't wan't to show the user/server/domain/password in the processes list you probably also don't want to have the password  in files. I think currently the best solution is to create a wrapper script and use /from-stdin.

I appreciate that storing plain text passwords in the file are not ideal and this is not a suggestion/change I would recommend without a specific goal in mind, there are a number of other open source projects dependent on starting FreeRDP from a command line, it is these projects that would benefit from this change as it would be possible to create .RDP files with a password, start the process and delete the file after. Not ideal but a solution.
If it would be of benefit, I could also add another command line parameter to delete the .RDP file once the process is started to ensure that there are not 100's of .RDP files with passwords left around but this would still be user choice.
In .RDP files there is a hashed password field password 51, the issue with this is that you need a windows API call for the RDP client to decrypt this and send it to establish the report session, this will not work I believe in a linux/mac/unix env making this type of change non portable.
Any comments welcomed, in the grand schema of things, this pull request is not a major contribution to an excellent project

My 2 euros cents: previous version of mstsc on mac used to support the password in clear.

@bigpjo Agree with the necessity of storing the password in some cases.
As for other projects, as @bmiklautz already pointed out providing the password via stdin is probably a better solution (but also far from perfect)
The hashed password option is, as you correctly asserted, not an option without introducing some kind of password manager dependency
That aside, if you fix the check for allowing command line to override RDP username you got my vote ;)

@freerdp-bot test

@freerdp-bot test, come on


SPIKE: Determine path forward to add offset-based pagination to Tina

Summary
As a developer I want to research possible options for implementing offset-based pagination and their technical impact so that I can determine the best path forward for adding it to Tina.
Expected Results

Research complete (including pieces like GraphQL, dynamo, level, the CMS, etc)
PoC created if needed
Review findings with team
Create necessary cards for completing the work

Notes
Related: https://github.com/tinacms/tinacms/issues/2859
Questions to answer:

What kind of pagination do we want to offer? (like Smashing? like Amazon? just forward/back?)
What are the tradeoffs with going one direction over the other?
What is the impact to adding this pagination to the CMS?

Need to confirm whether SM and/or PS need this and if so, which "flavor" do they need?


fix manifest.json config file

Fix manifest.json config file
Add dummy icons
Add dummy content script and style

@Joblyn The fix looks good.  @MartyOfMCA have tried to load the extension after the icon fix? I would like a feedback on how the icons fit once they are loaded on chrome.


Upgrade to Golang v1.19.x

Is Golang 1.19 ready to be used in the productization pipeline?

Is Golang 1.19 ready to be used in the productization pipeline?

Yes. Container images are now available.
cc @gsaslis


Adding Bounds Control's Configuration files to SharedAssets

Overview
BoundsControl.cs provides the capability for customizing visuals through Configuration (profile) files. However, currently, there are no configuration files in the assets. Users have to use configuration files under specific example (Cheese.prefab) which can cause problems when those prefabs are deleted or removed from the project.

Changes

Fixes: #9829

Screenshots
Added two types of configuration files - volumetric and slate. These config files were extracted from Cheese.prefab and Slate.prefab.

/azp run


Idea: Group transformations according to engine support

Adding new flags to apply special sets of transformations would be really handy while using the CLI.
This idea is be able to transform only unship ES6 features.
# Only transform staged features (classes, template strings, ...).
# Don't transform `for of` since it is shipped.
$ 6to5 --v8_es_staging test.js

See #272 for previous discussion. Basically it's hard/impossible to restrict these in scope, especially when these engines are forever updating.


[FEATURE REQUEST] Let me decide if I want RVC to automatically cut the audios of the dataset in the preprocessing stage

Hello!
It would be very useful if the automatic trimming of the audios could be omitted in the preprocessing stage of the dataset, since there are many cases in which one has several audios cut perfectly in spoken or sung phrases and RVC trims in a bad way those audios, causing zero-second audios with noises or parts of the phrases cut, causing errors in the f0 extraction stage (bc no f0 to extract from zero seconds audios lol) and leading to a bad training.
Thanks!

done

Thank you for implementing my suggestion. It works but not 100%, it looks like RVC wants to keep cutting the audios anyway. The numbers of audio segments remain the same as the original directory, but it looks like they were cut anyway at the beginning and/or end abruptly, (making audios with near zero seconds duration) plus the audios are out of order and there are audios that differ from their original length as state above.
Thank you for your effort.

@ShiromiyaG maybe can help you

@Mixomo Can you join the AIHispano discord server and call me to help me test this function? I'm @ShirouG there


Doesn't work in Russia

Describe the bug
Unfortunately, doesn't work in Russia.
To Reproduce
To be in Russia with MTS provider and standard DNS from the ISP.
Expected behavior
Doesn't work on sites blocked by the ISP.
Screenshots

Desktop (please complete the following information):

OS: Manjaro Linux x64 KDE Plasma 5
Browser: Firefox
Version: 66.0.3 x64
GUI: w/o
NodeJS: 11.14.0
NPM: 6.9.0
Installation method: root with flag -g (npm -g)

@AlexMak58  you can query your desired website using  " dig " and check the returned DNS lookup response too see if it is the correct response or is it just some random internal IP from your ISP  ,or  you could use an encrypted DNS provider  or DoH , DNS over HTTPS in the first place  .

@AlexSysadmin I did not quite understand what should end up. Should I get my ISP DNS address?

@AlexMak58 No , if you are using linux
just run this command : dig  google.com
replace google with the website you are trying to visit , like
dig  facebook.com
and see if the response you get is a valid IP address ,
next try using a public DNS server like google , and run the query again ,.using this command
dig @<IP_ADDRESS> facebook.com
or any website you are trying to visit and is filtered , compare their responses , and paste the dig results here .

A similar problem: #37


Styled-components theme maxWidth props not working

Environment

npx envinfo --system --binaries --npmPackages styled-components,babel-plugin-styled-components --markdown --clipboard
Reproduction

https://www.webpackbin.com/bins/-KeeZCr0xKfutOfOujxN
https://codesandbox.io/s/rkmNRByE4
Steps to reproduce
Expected Behavior
Actual Behavior

Hey, @rshah9 you're not making it easier by not posting a reproduction, I tried something like this and it totally works:
https://codesandbox.io/s/styled-components-v0xrj
Let me know if that's what you had in mind.

Going to close due to lack of repro, thanks for helping with the example @lekterable


Do not clip the TODO comments in Markdown export; it hides valuable information and breaks Markdown syntax

Example:
- __NOTE__ _@sompylasar_ The `display: inline-block;` here to have this element size match its content, i.e. the image itself, so that the `to...

Result:

NOTE @sompylasar The display: inline-block; here to have this element size match its content, i.e. the image itself, so that the `to...

Hi @sompylasar. You can use All instead of Text in showInTable config. This should include the whole found line (including the todo text itself, which is not perfect). Try it out.
NB: I think I spotted a bug in the current published version with the All setting, which in some situations sat it to the same as Text. This will be fixed in the upcoming version.


Pex should trust any host passed via --index or --find-links.

The underlying pip calls don't assume this and error out, e.g.:
E   	WARNING: The repository located at www.antlr3.org is not a trusted or secure host and is being ignored. If this repository is available via HTTPS we recommend you use HTTPS instead, otherwise you may silence this warning and allow it anyway with '--trusted-host www.antlr3.org'.
E   	ERROR: Could not find a version that satisfies the requirement antlr_python_runtime==3.1.3 (from versions: none)
E   	ERROR: No matching distribution found for antlr_python_runtime==3.1.3
...
E   	Exception caught: (pex.resolver.Unsatisfiable)
...
E   	  File "/b/f/w/pants/backend/python/subsystems/pex_build_util.py", line 278, in _resolve_multi
E   	    allow_prereleases=python_setup.resolver_allow_prereleases)
E   	  File "/b/f/w/pex_root/install/pex-2.0.2-py2.py3-none-any.whl.b89b057c31d08e6bebdb4531720b75237c56588e/pex-2.0.2-py2.py3-none-any.whl/pex/resolver.py", line 195, in resolve
E   	    raise Unsatisfiable(str(e))
E
E   	Exception message: Executing /usr/bin/python2.7 -s -m pip --disable-pip-version-check --isolated -q --cache-dir /home/nobody/.cache/pants/python_cache/requirements/CPython-2.7.12 download --dest /tmp/tmpj2dt894x/resolved --index-url https://pypi.org/simple/ --find-links http://www.antlr3.org/download/Python/ antlr_python_runtime==3.1.3 failed with 1

Related to #803 in that --trusted-host is a pip network option, but I can't see a reason to expose this directly vs assume it from indexes / find_links.


Script security-checker security:check returned with error code 1

Project created using:
composer create-project symfony/symfony-demo
Composer version 1.7.2
returns an error:
Executing script security-checker security:check [KO]
 [KO]
Script security-checker security:check returned with error code 1
!!
!!  Symfony Security Check Report
!!  =============================
!!
!!   // Checked file: symfony-demo/composer.lock
!!
!!     --------------------------------
!!
!!   * CVE-2018-14773: CVE-2018-14773: Remove support for legacy and risky HTTP headers
!!     https://symfony.com/blog/cve-2018-14773-remove-support-for-legacy-and-risky-http-headers
!!
!!   ! [NOTE] This checker can only detect vulnerabilities that are referenced in
!!   !        the SensioLabs security advisories database. Execute this command
!!   !        regularly to check the newly discovered vulnerabilities.
!!
!!
Script @auto-scripts was called via post-install-cmd

Composer update
fixes the problem

just ran into this, too.

Forcing http-foundation version > v4.1.1 would help.

that's because https://github.com/symfony/demo/pull/846 is not merged yet

Closing because #846 has just been merged. Please, report any other issue that you may find related to this. Thanks!


Question about protocol status

DevAAC sends any request to get info by protocol status ? @DSpeichert

No, it doesn't. It pulls all the information from the database at the moment.


Have not figured how to catch "Inspector.detached"

Hello "cyrus-and",
I am trying to catch the event when an existing remote chrome debugger session is terminated because the user opened in the tab the chrome developer tools.
chrome.Inspector.enable();
chrome.Page.enable();
chrome.once('ready', function() {
chrome.on('event', function (message) {
console.log("chrome event:"+JSON.stringify(message));
});
chrome.Inspector.detached(function(response){
console.log('Inspector for tab detached');
});
});
This code will capture events like "Page.loadEventFired" without any issue but it will never capture "Inspector.detached".
I am using "chrome-remote-interface": "^0.12.3", thank you for your help.
#JLS01
For reference:
Upon disconnnection, the outgoing client will receive a detached event. For example: {"method":"Inspector.detached","params":{"reason":"replaced_with_devtools"}}
From: https://developer.chrome.com/devtools/docs/debugger-protocol

That happens because the WebSocket is closed by Chrome before any Inspector.detached is sent through it. I'm not sure if that's the intended behavior or a bug. In any case it does not seem compliant with the reference:

Upon disconnnection, the outgoing client will receive a detached event.

A trivial solution might be emitting a detach event upon the close event of the WebSocket, so at least one can intercept the disconnection event. Let me better look into it...

Thank you very much for looking into this!

So it seems a bug with the ws library which interprets the disconnection as an abnormal close event (code 1006) and fails to deliver the last message.This didn't happen with earlier versions, so as a quick fix you can force chrome-remote-interface to use ws version "0.4.32" (which I tried and works).
In the meanwhile if I'll be able to reproduce this in a minimal example I'll file an issue to ws.

Outstanding turn-around time for this workaround "cyrus-and" ! I can confirm that forcing "ws": "^0.4.32" in package.json of  chrome-remote-interface is fixing this issue for now. Thanks again.

I am seeing in the issue "ws- code 1006" comments that you are digging deeper yourself into this ws bug. I appreciate your efforts as using "ws": "0.4.32" is clearly only a workaround ("ws": "0.4.32" is causing itself as side effect unfortunately other instabilities using chrome-remote-interface) !

Actually there's a better workaround which works even with the latest version of ws. Replace this line with:
    self.ws = new WebSocket(url, {'perMessageDeflate': false});

This disables the compression extension, which appears to be the cause of the issue. I will push this workaround if they'll take too long to fix the issue. After all having the compression enabled is a good thing.

This solves indeed the problem of the event Inspector.detached and works with "ws": "^1.1.1". Thank you cyrus-and!


Expose ListView velocity when scrolling

This was closed, but it would be nice to expose it so people can do what they will with it. All the potential use cases are impossible to predict.
https://github.com/flutter/flutter/issues/26418
As one example use case:

We want to dismiss the keyboard when a use begins scrolling a list, but we don't want to close it if a list is just passively scrolling.

So we need to tell if the change event was driven by physics, or by the users direct touch.
An easy way to do this is with velocity, if it's 0 for 2 updates in a row we know user is dragging:
  double _prevVel = -1;
  void _handleResultsScrolled() {
    final vel = _controller.position.activity?.velocity;
    if (vel == 0 && _prevVel == 0) {
      FocusManager.instance.primaryFocus?.unfocus();
    }
    _prevVel = vel ?? _prevVel;
  }

Then we can do something like this, where the keyboard closes when user initiates scroll, but not when the scroll 'throw' is finishing:
https://user-images.githubusercontent.com/736973/193720604-ef0583e6-985c-4e1f-af77-7872018f9785.mp4

Thanks for the report @esDotDev. The original issue was closed since a community plugin was developed to address the proposal. But looking at both the plugins, they don't seem to be maintained or updated with latest framework versions.
Although, I came across this link and wondering if it would be helpful in your case or not ?

This is possible using other means, but importing an entire pkg and introducing a new dependency, just to access an API that is already there seems extremely odd.
Who not just remove the @protected? Clearly the team needed it for their tests, is it to crazy to think developers might want it too. What does it hurt to expose this read-only value? Quite baffling to keep it locked off.

Thanks for the feedback. Treating this as a proposal.

Another use case for this: We want to have some logic that will "snap" a scrolling list to the closest location, if it slows down enough.
To do this, we need to be able to distinguish between the user dragging the list, or the list being driven by physics. We only want to run the snapping logic, if the user is not touching the list.
So in this case, it is the opposite to the use case above:
void maybeSnapToPosition(){
  bool isUserScrolling = _controller.position.activity?.velocity == 0;
  if(isUserScrolling) return;
  /// etc...
}


Fixing bug with "weekend" flag on Week in year, e.g. "2020-W02-WE"

This was actually raised in a StackOverflow question - see https://stackoverflow.com/questions/59615953/luis-test-tool-datetime-different-than-locally-resolved-datetime
Basically, the TimexResolver is ignoring if the timex has a "weekend" attached to it, to get the start and end of the period.

wow, that was quick! thanks!

Roy (Stack Overflow Poster)

glad to help!


Investigate use/recommendation of 'provided' scope for connectors

Benefit:  3rd party connectors - Reduce likelihood of incompatibilities with base egeria code & make easier to build
When we builds a connector in egeria we express dependencies on a variety of modules - be it in gradle or maven, most likely as compile&run .  Those dependencies would include various egeria packages as well as third party packages that might be unique to the connector
We then build the jar with dependencies, those classes will get pulled into the uber jar
If the connector is always hosted in the server chassis, at runtime, some of these classes are already found.  Plus the version from the connector since by adding to loader.path it may also be in the classpath as defined by the spring classloader.
So there could be two versions of the same library. If they’re the same we’d not notice. If they differ we would.
(We don’t currently use shading in terms of renaming).
Where connectors are being developed outside the egeria tree the risk of this is more pronounced
Ideally we could consider clarifying what the egeria 'platform' is, and referencing any packages in that platform as 'provided'. To assist in this we would also need a strict definition of the platform, such as a maven bom
We could also recommend this approach to third party developers to reduce any issue of mismatched code
It may also be that we need to be more careful and explicit in building our assembly in expressing what is packaged. Using maven scope only may not be flexible enough. But to have nothing too much work. Gradle tries to add flexibility by having ‘configurations’ which can be treated differently (ie for a client, server etc). The net question is the same though. what exactly do we want to distribute, what do we want to load…

Currently we only use 'provided' scope for gaian & derby - since both relate to libraries we do not ourselves ship, and instead require them to be in-situ on the target (somewhat of a similar scenario)
Gradle lends itself better to a broader range of configurations -- for example we could far more easily lay out seperate trees in the assembly for 'clients', server, utilities, and in each case define the core common set that would be suited as 'provided'.
Draft set of tasks

[ ] Identify core set for server chassis
[ ] Do we need a maven bom to reflect
[ ] checking if any build ordering impact
[ ] ensuring assembly has all 'provided' libraries ie in lib (ideally making use of scope)
[ ] updating build of connectors accordingly
[ ] reflecting same in gradle
[ ] looking at commonality for clients

Currently we only use 'provided' scope for gaian & derby - since both relate to libraries we do not ourselves ship, and instead require them to be in-situ on the target (somewhat of a similar scenario)
Gradle lends itself better to a broader range of configurations -- for example we could far more easily lay out seperate trees in the assembly for 'clients', server, utilities, and in each case define the core common set that would be suited as 'provided'.
Draft set of tasks

[ ] Identify core set for server chassis
[ ] Do we need a maven bom to reflect
[ ] checking if any build ordering impact
[ ] ensuring assembly has all 'provided' libraries ie in lib (ideally making use of scope)
[ ] updating build of connectors accordingly
[ ] reflecting same in gradle
[ ] looking at commonality for clients

Makes sense. One comment. I assume that when we have multiple database connectors, there could / would be clashing classes e.g. different jdbc drivers. And different connectors would depend on different parts of the Server Chassis. For integration connectors and governance action framework connectors. I am thinking we should group the 'provided' library content per consuming connector, for ease of consumption.

Makes sense. One comment. I assume that when we have multiple database connectors, there could / would be clashing classes e.g. different jdbc drivers. And different connectors would depend on different parts of the Server Chassis. For integration connectors and governance action framework connectors. I am thinking we should group the 'provided' library content per consuming connector, for ease of consumption.

@davidradl I think the jdbc drivers themselves will have unique names. if they have an uber jar with other dependencies there is a risk (there always is) of divergent versions, though those libs may use shading - worthy of more checks. But I don't think the top level driver per se will be an issue.
For the server chassis, even though connectors may depend on different egeria modules at runtime, I'm thinking for simplicity we need to define a limited set of 'platforms' - maybe only one - that will ALWAYS be there.
However Most recently we have created a stripped down chassis which only has the very minimal capabilities. This can be assumed to always be there, but many other egeria modules something like a view service may depend on may, or may not, be there.
In that case whilst we can use 'provided' scope in the build process, we need more... We need to ensure code is always dynamically loaded, and that errors are sensibly detected and reported, as deciding what is present in the chassis at runtime becomes more of a deployment question
In essence we need to move the focus on that assembly from the build process to deployment - but to do this in such a way that anyone deploying can do it fairly easy. With say 5, 10 modules that might be viable. with 200-400+ (in egeria) we need more.
Thinking about this more, provided scope is only part of the approach - it adds the build flexibility, but doesn't solve the problem of the deployer getting the environment right.

@davidradl I think the jdbc drivers themselves will have unique names. if they have an uber jar with other dependencies there is a risk (there always is) of divergent versions, though those libs may use shading - worthy of more checks. But I don't think the top level driver per se will be an issue.
For the server chassis, even though connectors may depend on different egeria modules at runtime, I'm thinking for simplicity we need to define a limited set of 'platforms' - maybe only one - that will ALWAYS be there.
However Most recently we have created a stripped down chassis which only has the very minimal capabilities. This can be assumed to always be there, but many other egeria modules something like a view service may depend on may, or may not, be there.
In that case whilst we can use 'provided' scope in the build process, we need more... We need to ensure code is always dynamically loaded, and that errors are sensibly detected and reported, as deciding what is present in the chassis at runtime becomes more of a deployment question
In essence we need to move the focus on that assembly from the build process to deployment - but to do this in such a way that anyone deploying can do it fairly easy. With say 5, 10 modules that might be viable. with 200-400+ (in egeria) we need more.
Thinking about this more, provided scope is only part of the approach - it adds the build flexibility, but doesn't solve the problem of the deployer getting the environment right.

No need to have dependencies at all.
At runtime, if jar is missing from the lib folder,  will ClassNotFoundException will be catch and wrapped and logged in audit log.
For that I need to change a little the https://github.com/odpi/egeria/pull/4347 . In the PR I moved the dependencies in profile, but if they are removed works just fine if the JARs are in the lib folder.
Already test that.
PS: I kept dependencies in the PR to be able to merge it before other changes.

No need to have dependencies at all.
At runtime, if jar is missing from the lib folder,  will ClassNotFoundException will be catch and wrapped and logged in audit log.
For that I need to change a little the https://github.com/odpi/egeria/pull/4347 . In the PR I moved the dependencies in profile, but if they are removed works just fine if the JARs are in the lib folder.
Already test that.
PS: I kept dependencies in the PR to be able to merge it before other changes.

@bogdan-sava I am looking of https://github.com/odpi/egeria-connector-ibm-information-server/blob/master/datastage-adapter/src/main/java/org/odpi/egeria/connectors/ibm/datastage/dataengineconnector/DataStageConnector.java which has an import org.odpi.openmetadata.frameworks.connectors.properties.ConnectionProperties;
So this is a dependancy that needs to be resolved at compile time. It is brought in using
   <dependency>
                <groupId>org.odpi.egeria</groupId>
                <artifactId>open-connector-framework</artifactId>
                <version>${open-metadata.version}</version>
                <scope>provided</scope>
            </dependency>

This means that the dependancy should be provided at runtime.
So without the provided dependancy in the pom file it would not compile.

@bogdan-sava I am looking of https://github.com/odpi/egeria-connector-ibm-information-server/blob/master/datastage-adapter/src/main/java/org/odpi/egeria/connectors/ibm/datastage/dataengineconnector/DataStageConnector.java which has an import org.odpi.openmetadata.frameworks.connectors.properties.ConnectionProperties;
So this is a dependancy that needs to be resolved at compile time. It is brought in using
   <dependency>
                <groupId>org.odpi.egeria</groupId>
                <artifactId>open-connector-framework</artifactId>
                <version>${open-metadata.version}</version>
                <scope>provided</scope>
            </dependency>

This means that the dependancy should be provided at runtime.
So without the provided dependancy in the pom file it would not compile.

Yes - provided is needed for compile time (there will be a gradle equiv).
The main assembly I think also should be changed so that we provide the dependencies in server/lib or similar - not just connectors, but all. The chassis should be much leaner by default - as indeed you added in optional profile definition @bogdan-sava . I don't think we need the uber jar for the chassis long term, though do need to be ok with the dev use case also.
Note though some experimentation/investigation is needed here -- for example if we remove dependencies, we also - in maven at least - remove the control of build ordering. We also change how the assembly is built, as it may no longer know what dependencies to include, so need to adopt an alternative mechanism for this (gradle may make this easier)
I think we should start considering making this change in the next, or next+1 dev iteration ie Feb/Mar.

Yes - provided is needed for compile time (there will be a gradle equiv).
The main assembly I think also should be changed so that we provide the dependencies in server/lib or similar - not just connectors, but all. The chassis should be much leaner by default - as indeed you added in optional profile definition @bogdan-sava . I don't think we need the uber jar for the chassis long term, though do need to be ok with the dev use case also.
Note though some experimentation/investigation is needed here -- for example if we remove dependencies, we also - in maven at least - remove the control of build ordering. We also change how the assembly is built, as it may no longer know what dependencies to include, so need to adopt an alternative mechanism for this (gradle may make this easier)
I think we should start considering making this change in the next, or next+1 dev iteration ie Feb/Mar.

When looking at the postgres connector specifically & trying a fix for this generic issue there, I note that gradle now has 'compileOnly' which is pretty much what we want for 'provided' :-)
However clarification over what can be assumed to be present, modifying assemblies to include all the libs as jars (not an uber jar), plus docs still need to be worked here, ie in the base

When looking at the postgres connector specifically & trying a fix for this generic issue there, I note that gradle now has 'compileOnly' which is pretty much what we want for 'provided' :-)
However clarification over what can be assumed to be present, modifying assemblies to include all the libs as jars (not an uber jar), plus docs still need to be worked here, ie in the base

I would advocate for the approach of using the provided scope and still allowing a semi-uber-jar for the connector to be built (with its unique dependencies, but leaving out the Egeria dependencies), for these reasons:

This will ensure that we have a singular "release" with pre-defined depedencies (critically versions) baked-in
Should significantly improve the ability for us to identify issues and debug them accordingly (rather than needing to second-guess what versions of libraries someone might be running alongside the connector)
Will also mean that our code analysis mechanisms (security, etc) will identify potential issues with the baked-in dependencies (don't think there'd be any way for us to do this if users are manually choosing their dependency versions in the /lib directory?)

This is the approach I've taken in both the IGC and Atlas connectors (at least, explicitly including only the non-Egeria dependencies in the uber jar they each build, though I may not be explicitly using the provided scope)...

I would advocate for the approach of using the provided scope and still allowing a semi-uber-jar for the connector to be built (with its unique dependencies, but leaving out the Egeria dependencies), for these reasons:

This will ensure that we have a singular "release" with pre-defined depedencies (critically versions) baked-in
Should significantly improve the ability for us to identify issues and debug them accordingly (rather than needing to second-guess what versions of libraries someone might be running alongside the connector)
Will also mean that our code analysis mechanisms (security, etc) will identify potential issues with the baked-in dependencies (don't think there'd be any way for us to do this if users are manually choosing their dependency versions in the /lib directory?)

This is the approach I've taken in both the IGC and Atlas connectors (at least, explicitly including only the non-Egeria dependencies in the uber jar they each build, though I may not be explicitly using the provided scope)...

Also note that any recommendations should comment on use of snapshots (and usr of -U or the gradle equiv) - see https://github.com/odpi/egeria-database-connectors/issues/14 . This is more relevant in the initial stages of building a new connector alongside core dev work, whilst when using a stable base using the last released version of egeria is 100% the way to go.
Leaving any further eval/doc on this until we've made base packaging changes ~ Feb 2021 to unpack dependencies in our assembly

Also note that any recommendations should comment on use of snapshots (and usr of -U or the gradle equiv) - see https://github.com/odpi/egeria-database-connectors/issues/14 . This is more relevant in the initial stages of building a new connector alongside core dev work, whilst when using a stable base using the last released version of egeria is 100% the way to go.
Leaving any further eval/doc on this until we've made base packaging changes ~ Feb 2021 to unpack dependencies in our assembly

This is part of the work to slim down the chassis - @bogdan-sava assigned to you to manage/coordinate but feel free to reassign particular changes needed back once you've figured out the overall approach.

I think what we need to make this work (an what is tried to be suggested above) is

Clarity on what the base platform is -- ie what can we always assume is present. This can be a packaging pom (we'd need to exclude this from the dependency check)
Use of 'provided' or 'compileOnly' for the scope of this 'base platform' dependency
Building jar-with-dependencies OR inclusion in 'lib' directory of all additional modules that are regular dependencies (ie compile or Implementation) (this is where the extra dependencies needed for a particular connector come in)

This would extend not just to connectors, but everything outside the core platform, so for example 'optional' OMAS modules etc.
I think we're both saying the same thing?

Other potential impacts

Maven assembly
Gradle assembly
CI/CD process - publishing of artifacts
Docs around use of additional connectors
Developer information on compile/debug ie in intellij (but also cli)

If this direction sounds good I"m fine we close this issue, and create a new clean issue to track the implementation. This can be a high level issue to which we attach child issues (those can then be independently assigned & worked on & merged). First step being to edit a sequence of steps to get us to the goal.
One thing I'm wondering is whether to skip the maven version of this and just go gradle. the downside is it could delay the work as gradle builds needs verification/some completion. However last time we rejigged this area the maven assembly/build was problematic. I'm somewhat neutral.


Applying styles to future text through a HTML select option

I want to apply a color style to the text through HTML select option elements
Since opening a select menu needs the focus, the editor loses it so I can't apply the inline-style to the Editor State for the upcoming text.
It would only work for a text already selected.
Is there any sort of hack to handle this case or is it just impossible ?

I've been tricking my editor components by keeping in local state the selectionState when the select element gets the focus.  The hasFocus has been manually changed to true in order to properly put the inline styles at the collapsed cursor position
Then, when a select value is toggled (onToggle), the modified editorState with the memorized selectionState are used to apply the inline styles

Hello, can i ask you for some example code of this problem? I have same problem as you had and it will be very helpfull for me when i will see your solution.
Thanks a lot

Sorry, I don't have access anymore to the piece of code related to this issue.
I can't help 😞


ActionView::Template::Error: wrong number of arguments (3 for 1..2)

Hi,
I'm trying to update rails from 3.2.18 to 4.0.9 and I'm receiving that error message lots of times, I have no idea what to do to fix it as you can see there is nothing non-trivial in application.html.erb, the same happens to other tag helpers like image_tag.
I created a gist with the only information I have, it seems it ends up being something in between of sass-rails and sass, not sure though.
https://gist.github.com/Davidslv/862c57b5490d2576e19a
Thank you for your help!

+1 @philipgiuliani

+1 it helped.

:+1: 3.2.19 -sass version helps me....Thanks guys

saved me. excellent - thank you!


feat: implement mutation rejection for facility submission

Resolves #639
Related to #636
🔧 What changed
This implements the functionality of the reject button to reject a facility submission. Before it just logged. Now if I click, the facility will be rejected and moved in tabs.
It also contains a custom function that will allow us to pass GQL requests and retry recursively.
🧪 Testing instructions

Run the local backend

yarn dev:startlocaldb

yarn dev

Then start the frontend

yarn dev:localserver

Reject a submission and you can see how it changes as shown in the After screenshot

📸 Screenshots

Before

After

This is the submission list before I reject Stephanie Mills

and after with the rejection seen in the separate tab

Ok @ermish. Added all of your feedback! Hopefully it is good to go now


Error during the build on version 17.12.0

Hello,
I just upgraded the library version to 17.12.0. I'm using the lara-cyan theme and I encountered the following error during the build:
Undefined variable.
21 │     outline-offset: $inputFocusOutlineOffset;
node_modules/primeng-sass-theme/theme-base/_mixins.scss 21:21                         focused-input()
node_modules/primeng-sass-theme/theme-base/components/input/_autocomplete.scss 22:13
@import node_modules/primeng-sass-theme/theme-base/_components.scss 10:13
@import node_modules/primeng-sass-theme/themes/lara/lara-dark/cyan/theme.scss 13:9
It appears that the variable does not exist in the _variables.scss file of that theme. Could you please take a look?
Thank you very much and best regards.

Hi, I have checked the file and exists the variable in the line 58

Did you upgrade your library?

Hello,
The issue exists in the dark version of the theme, not in the light one.
Thank you

Hello, The issue exists in the dark version of the theme, not in the light one.
Thank you

I have checked the dark and the line is included too:

Maybe I'm checking in the wrong place. Could you confirm @cetincakiroglu if this problem exists or if i'm in the correct file. If not tell me what is the file and I can make the PR

Same issue here.
@SoyDiego it seems that what gets installed via NPM is not the same as the source files:

Perhaps an issue in your deployment process?

Same issue here.
@SoyDiego it seems that what gets installed via NPM is not the same as the source files (both themes, version 17.12.0):

Perhaps an issue in your publish process?

Are you using NPM to install it?
I think Primetek doesn't have a official package for that. Can you share the link?
Always I cloned the project and compiled my styles and then my final .css files I used in my projects.

Indeed, I'm using NPM 10. And I thought I could simply install the primeng-sass-theme package to avoid doing that manually every time there is a new release:
"primeng-sass-theme": "github:primefaces/primeng-sass-theme#17.11.0",
But as I can see, there are some differences between the source code and the code that gets "installed" using NPM.
As I said, this was my initial idea to reduce the manual work in maintaining the theme in sync with PrimeNG. In fact, it seems I'm not the only one who wants to avoid this manual work: in https://github.com/primefaces/primeng-sass-theme/issues/62
Do you think this is something the PrimeNG team can have a look at? At least ensuring that installing via github:primefaces/primeng-sass-theme#17.11.0 gets the same code as if we would download the ZIP file from https://github.com/primefaces/primeng-sass-theme/releases

Maybe this PR makes it work? https://github.com/primefaces/primeng-sass-theme/pull/113

Digging a bit more into this, I think there is a mismatch in the tag 17.12.0 itself. I mean, checking the source code directly in that tag (https://github.com/primefaces/primeng-sass-theme/blob/17.12.0/themes/lara/lara-light/_variables.scss) , I can see that the variable $inputFocusOutlineOffset; is indeed missing:

Indeed, I'm using NPM 10. And I thought I could simply install the primeng-sass-theme package to avoid doing that manually every time there is a new release:
"primeng-sass-theme": "github:primefaces/primeng-sass-theme#17.12.0",
But as I can see, there are some differences between the source code and the code that gets "installed" using NPM.
As I said, this was my initial idea to reduce the manual work in maintaining the theme in sync with PrimeNG. In fact, it seems I'm not the only one who wants to avoid this manual work: #62
Do you think this is something the PrimeNG team can have a look at? At least ensuring that installing via github:primefaces/primeng-sass-theme#17.12.0 gets the same code as if we would manually download the ZIP file from https://github.com/primefaces/primeng-sass-theme/releases

I'm not part of Primetek only a contributor but I think they are not interested (I don't remember why in create a NPM package, maybe i'm wrong, I don't know 100%).

Digging a bit more into this, I think there is a mismatch in the tag 17.12.0 itself. I mean, checking the source code directly in that tag (https://github.com/primefaces/primeng-sass-theme/blob/17.12.0/themes/lara/lara-light/_variables.scss) , I can see that the variable $inputFocusOutlineOffset; is indeed missing:

And there is a newer commit in the main branch adding such missing variable: 07ee7cf
So I guess it's just matter or replacing the latest 17.12.0 release to point to the latest commit

If I understood ok, maybe they created the tag before this commit. Will see if generating a new tag, the problem is solved. We need to wait for Primetek team

Yeah, that's right. Fortunately in the meantime I can simply add the commit hash to get the latest changes:
`"primeng-sass-theme": "primefaces/primeng-sass-theme#07ee7cfd98df828a9bdd31eb4f5424e700832409",

Yeah, that's right. Fortunately in the meantime I can simply add the commit hash to get the latest changes:
"primeng-sass-theme": "primefaces/primeng-sass-theme#07ee7cfd98df828a9bdd31eb4f5424e700832409"

That's good alternative idea at the moment. Thanks for share it


adds decimal to page count

Hi there, I'd like to revisit my pull request from last year (https://github.com/isaaclyman/novel-word-count-obsidian/pull/3).
Since you have added word counts separately, I think, the problem you mentioned last time that you'd like there to be a comma to separate the 1,000 thousander digits seems to no longer be an issue.
My change to toFixed(1)  adds a single decimal to the page count. Unlike Microsoft Word and the like, where you can see how much of the next page you've filled up with your text, so that the whole number of pages is enough, in Obsidian I find it useful to have a single decimal so you can see how much text you actually have.
No worries if this still isn't to your liking, just thought I'd bring it up again :)
Thanks!

Hey, thanks for bringing this back up. I can see why it would be valuable to you.

Since you have added word counts separately, I think, the problem you mentioned last time that you'd like there to be a comma to separate the 1,000 thousander digits seems to no longer be an issue.

I don't understand what you mean here. Can you explain in a little more detail? Specifically I'm not sure what has changed in the plugin that would make comma separators irrelevant.
If I do add this feature, it will be a configuration point in the settings, not forced on all users. I'll need to take a look at the settings and weigh pros and cons. Keep in mind I've rejected quite a few requests to add more configurability, since the settings page already seems very complicated for a word count plugin. It would help your case a lot if you could find any other plugin users who want this feature.

Sorry, that was a little unclear.
I wasn't trying to say that the comma separators are now irrelevant but that at some point in the past year you've added a change so that the comma separator does not disappear if you switch to the toFixed(1) version for the page count. That's all.
So the comma separator stays for the word count. It may be gone for the page count, but honestly I'm not sure how many people have notes with more than a thousand pages, so I don't really think the separator comma for the page count is so important.
I'll ask on the forum if anyone else would profit from this change :)
Thanks!

Great, please do and drop a link if people respond one way or the other.
One small point of disagreement, I don't think it's out of reach or even uncommon to have a vault with 1000+ pages. Or even just to prefer the page count without the decimal portion. But again, I'm giving it a good think.

OK, fair point, though I was talking about a single note. I do also have many, many pages in my vault, but I usually split them because after a while a single note becomes unwieldy. But that's just me :)
Should I get any responses, I'll link them here, and if there is another way to show me more accurately how much text I have in a note, I'm always open for suggestions. Really like your plugin!
Thanks :)

I thought of a way to do this without complicating the interface. Please update to v2.10.0 and see the new count type "Page Count (decimal)".


Fix code style guide problems for PEP8 and Flake8

The CI system picked up non-conformance issues with recent changes to the ebuild generator.
Fix lines that exceed 79 characters and remove an used chunk_count variable.

This resolves issues raised by #304 and #305


Correct SA picked for DS DM11 In Test 9.8 V.3.0.10

Correct SA picked for DS DM11 In Test 9.8 V.3.0.10
SA 61 believed to be correct, based on Test 8.2 ... as it is MIL Off
Start Test 9.8 - DM11: Diagnostic data clear/reset for active DTCs
07:31:50.0618 Destination Specific DM11 Request to Exhaust Emission Controller (61)
07:31:50.0630 18EA3DF9 [3] D3 FE 00 (TX)
07:31:50.0958 1CE8FF3D [8] 00 FF FF FF F9 D3 FE 00
Acknowledgment from Exhaust Emission Controller (61): Response: ACK, Group Function: 255, Address Acknowledged: 249, PGN Requested: 65235
// 61 should NACK DS requests for DM11
// Failure message is missing; known issue
// expected DM11 query for SA 0 is step 9.8.3.
... ... ... ...
Start Test 9.2 - DM12: Emissions related active DTCs
07:31:41.8203 Global DM12 Request
07:31:41.8212 18EAFFF9 [3] D4 FE 00 (TX)
07:31:41.8223 18FED417 [8] 00 FF 00 00 00 00 FF FF
DM12 from Instrument Cluster #1 (23): MIL: off, RSL: off, AWL: off, PL: off, No DTCs
07:31:41.8254 18E8FF4C [8] 01 00 FF FF FF D4 FE 00
Acknowledgment from Communications Unit, Radio (76): Response: NACK, Group Function: 0, Address Acknowledged: 255, PGN Requested: 65236
07:31:41.9400 18FED400 [10] 43 FF 34 04 05 01 30 02 13 01
DM12 from Engine #1 (0): MIL: on, RSL: off, AWL: off, PL: not supported
DTC 1076:5 - Engine Fuel Injection Pump 1 Fuel Control Valve, Current Below Normal Or Open Circuit - 1 times
DTC 560:19 - Transmission Driveline Engaged, Received Network Data In Error - 1 times
// Is 560:19 really an HD OBD DTC?
07:31:41.8358 18FED427 [8] 47 FF A8 00 01 01 FF FF
DM12 from Management Computer #1 (39): MIL: on, RSL: off, AWL: on, PL: not supported
DTC 168:1 - Battery Potential / Power Input 1, Data Valid But Below Normal Operational Range - Most Severe Level - 1 times
07:31:41.8454 18FED43D [8] 03 FF 00 00 00 00 FF FF
DM12 from Exhaust Emission Controller (61): MIL: off, RSL: off, AWL: off, PL: not supported, No DTCs
WARN: <IP_ADDRESS>.a - Engine #1 (0) reported > 1 active DTC
End Test 9.2 - DM12: Emissions related active DTCs

6.9.8 DM11: Diagnostic data clear/reset for active DTCs
<IP_ADDRESS> Actions:
a. DS DM11 (send Request (PGN 59904) for PGN 65235) to each OBD ECU without DM12 active MIL on DTC, based on the list created in step <IP_ADDRESS>.52
b. Wait 5 seconds before checking for erased data.
<IP_ADDRESS> Fail criteria:
a. Fail if any ECU partially erases diagnostic information (pass if it erases either all or none).
b. Fail if one or more than one ECU erases diagnostic information and one or more other ECUs do not erase diagnostic information.  See section A.5.
<IP_ADDRESS> Actions2:
a. DS DM11 to each OBD ECU with DM12 active MIL on DTC, based on the list created in step <IP_ADDRESS>. b. Wait 5 seconds before checking for erased data.
<IP_ADDRESS> Fail criteria2:
a. Fail if any ECU partially erases diagnostic information (pass if it erases either all or none).
b. For systems with multiple ECU’s, fail if one ECU or more than one ECU erases diagnostic information and one or more other ECUs do not erase diagnostic information.

No changes required


Invisible object

There's an invisible object that doesn't allow to click on some photos:
e.g. http://<IP_ADDRESS>/fichas/3517

Fixed in c8259057341be85471c920db9153def853e6a206


Issue using the Datepicker of a Treeview from DAG List

Steps to reproduce:

Go to Airflow main UI
Select the Treeview Icon next to a DAG
Change the "Number of runs" to another value and click Go
A HTTP 500 error is displayed because the parameter "root" has the value of "None" instead of being empty.

May I ask which version of airflow you are using? I think this has been fixed in master.

Works on the updated version of Airflow


[Feature] add colouring to the vector map loader for traffic lights left markers

Status
PRODUCTION / DEVELOPMENT
Description
Solves #987
Todos

[X] Tests

[X] Ubuntu 14.04
[x] Ubuntu 16.04

[X] Documentation

Steps to Test or Reproduce

Load Vector Map with Left traffic signals using Runtime Manager or command line and TF for the Vector Map
Open Rviz and change fixed frame to world
Add visualization by topic /vector_map MarkerArray type

@amc-nu I actually do not understand what the change here is. To visualize left traffic signals? if yes, which ones above are left traffic signals?


Implement EntityKindPicker for the catalog

This change implements the EntityKindPicker as discussed in https://github.com/backstage/backstage/issues/9616#issuecomment-1255149636.
It is much the same as the CatalogKindHeader but follows the picker models instead to make it more visible.
The selected filter is propagated between CatalogKindHeader and EntityKindPicker with an effect on the filters both places.

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thank you @freben . I have updated per your suggestions. PTAL.

Thank you for contributing during Hacktoberfest 🍂! You can claim the Backstage Hacktoberfest Holopin at https://bck.st/hacktoberfest-holopin 🙌🏻


Implement get backend by id

Client implementation of vulcand backend by id
https://docs.vulcand.io/api.html#get-backends

Completed with https://github.com/acazau/docker_vulcand_sidekick/pull/10


Mouse without borders with vertically stacked screens not working without wrap

Microsoft PowerToys version
0.73.0
Installation method
PowerToys auto-update
Running as admin
Yes, although same behaviour as admin or not
Area(s) with issue?
Mouse Without Borders
Steps to reproduce

Have 2 PCS connected with mouse without borders
disable the 'devices in a single row' setting
Arrange the screens vertically so the two machines are stacked on top of each other in the device layout UI
disable the wrap mouse setting
try to navigate up from the bottom screen / down from the top screen - the mouse gets stuck and cannot move over the border (it seems to work only one way round so try the other vertical arrangement if it is ok)
try switching the vertical arrangement so top and bottom are the other way around - the mouse without borders screen layout UI glitches and puts them back to horizontal
try switching on the wrap mouse setting and arranging them vertically - this seems to work but then both up and down move mouse to the other screen

✔ Expected Behavior
Arranging screen vertically in either orientation without mouse wrapping should have the expected single border between screens
❌ Actual Behavior
Mouse cannot cross the border between screens as the layout suggests.
Device layout supports all vertical arrangements
Sometimes it is not even possible to arrange the screens in the desired vertical arrangement - it seems to reset to a horizontal arrangement, or the only vertical arrangement that it allows is upside down with the top screen at the bottom, which mandates the mouse wrap option.
Other Software
No response

Just tested this in v0.74 and still not working. You can see here how when trying to set the vertical arrangement it seems to crash and reset to horizontal:

Found a workaround. If you enable the setting to display the old mouse without borders UI then you can use that to arrange the screens and it works

I had the same problem, the solution from alastairtree worked for me. Now I have another problem. On one PC, I have a 3-monitor setup, and on the second PC, I have one monitor above another monitor. How do I choose which monitor the second PC should connect from?


Fix crash when parsing HTML encoded quote

The quotes are HTML encoded, not URL encoded. This causes the crash reported in #7 when encountering a percent character. For example in:
http://api.icndb.com/jokes/504
{ "type": "success", "value": { "id": 504, "joke": "Chuck Norris programs occupy 150% of CPU, even when they are not executing.", "categories": ["nerdy"] } }

Hey @danbtl !
LGTM, thank you for the PR!


Prefer std::array over C-style array

Jenkins Build Summary
Built from this commit
Built at 20180508 - 04:03:32
Test Results

Build Type
Log
Result
Status

Author Check
null
JoeLoser is not a collaborator!
FAIL :red_circle:

Some of this code uses an iterator to get a pointer to the data (e.g. pointer data() { return reinterpret_cast<pointer>(pn.begin()); })
I'd rather not use the iterator as I don't think it's guaranteed to be a pointer to the data (someone might define a bounds checking debug iterator, for example). We could use either &pn[0] or pn.data(); either would be fine with me.

@seelabs sorry for the slow response - I blame CppNow :P
I'll take a look more closely at this neighborhood of code and take your feedback into account when I get some time tonight or tomorrow. Thanks!

@JoeLoser You're at CppNow!?! Nice! We often have people from ripple at these conferences, but not this year. No rush on addressing the feedback, whenever you get around to it is great. If you don't have time just let me know and I'm happy to do it too, but I figured you'd want to do it.

@seelabs took the CppNow conversation to email, but I just force pushed some changes in response to your code feedback earlier.  Please let me know if I didn't interpret your comment correctly.  I agree that it surely didn't follow the element of least surprise in handing back pn.begin() instead of pn.data().

Closed and reopened as https://github.com/ripple/rippled/pull/2514


Yarn install raises import declaration conflict

Plugin install is also failing silently for me:

I tried to linked it localy after git cloning it, and got the following error:
error<EMAIL_ADDRESS>The engine "yarn" is incompatible with this module. Expected version ">=1.15.2". Got "1.12.3"
After updated yarn, I'm getting this error while running yarn install:
node_modules/@salesforce/core/lib/config/configStore.d.ts:4:10 - error TS2440: Import declaration conflicts with local declaration of 'ConfigContents'.

4 import { ConfigContents } from './configStore';

Originally posted by @FabienTaillon in https://github.com/forcedotcom/dependencies-cli/issues/4#issuecomment-573788995

@FabienTaillon try remove the conflict, i.e. rm<EMAIL_ADDRESS>May need to remove yarn.lock before running yarn install again.

Fixed with version 2.0.1 by raising @salesforce/core and @salesforce/command versions.


search app: allow different main entities to co-existing in the same schema

On rbk-dev, there are 2 sets of tables---Protocol and Cell_Line.
I set Protocol as a default. However, when I try to explicitly go to the search app with Cell_Line (or its related tables) as an argument, the app keeps spinning. The search seems to support only one main entity per schema. This needs to be changed.

@svoinea what's the status on this? What do I need to do to make them co-exist?

On rbk-dev, I have:

"moved" the content of the Resource2 schema under the Resource schema
dropped the Resource2 schema
updated schema_name='Resource' where schema_name='Resource2' in the _ermrest.model_table_annotation and _ermrest.model_column_annotation tables

Seems to work w/o doing any code modifications.

I am closing this issue as it is no longer relevant.


Use ethers.constants.HashZero instead of NULL_BYTES32

Is your feature request related to a problem? Please describe.
We're currently using a custom constant NULL_BYTES32 all over the place: https://github.com/ethereum-optimism/contracts/blob/74f8f791839a91f3ea7f7d6fcb9136f05754e36d/test/helpers/constants.ts#L20-L21
It'd be much better if we used ethers.constants.HashZero so that we can outsource these constants to one place. Same idea as #329.
Describe the solution you'd like
Replace all instances of NULL_BYTES32 with ethers.constants.HashZero. Please be careful not to replace NON_NULL_BYTES32 by accident!

I am working on this now :)


Reset settings to default

I was able to load Diablo II once with CNC and I entered fullscreen using alt+enter. Now if I try to load the game again it defaults to fullscreen because savesettings was set to 1 and I cannot actually see the game window, it stay in the taskbar but cannot be viewed.

settings are always saved into ddraw.ini so you can just delete it and cnc-ddraw will create a new ddraw.ini with default settings. Or you can just extract ddraw.ini from the the download again into your game folder.
If you have the game installed in the program files folder then make sure you run it as admin, otherwise windows will use some compatibility settings that load a copy of ddraw.ini from a different folder

Seems to have worked, thanks!

nice :+1:


[ONNX] Add Einsum converter

As title
cc @mbrookhart @AndrewZhaoLuo
thanks @AndrewZhaoLuo for maintaining https://tvm.apache.org/docs/dev/relay_add_op.html, this doc was super helpful!

This is really nice! CC @ZihengJiang @hzfan

Thanks @anwang2009 @AndrewZhaoLuo @mbrookhart @junrushao1994


Terms for non-searchable presets are included in translation resource

Take e.g. the new emergency=yes dummy preset, it has "searchable": false, but its "terms" is still in presets.yaml, causing translators to see the string <translate with synonyms or related terms for 'Emergency Access Yes', separated by commas> in Transifex.
I think this is unnecessary since it's not searchable anyway.

Even though a user can't create a preset like that directly, an unsearchable preset will be used if it matches real data in OSM, or if a user manually edits the tags.

So that example - deleting the amenity tag from a hospital with emergency=yes - is not likely to happen, but unsearchable presets are also used for displaying many of other deprecated tags (like landuse=farm or craft=tailor), so we should have the name translated.
Think of these presets as:  things we wish did not exist in OSM, but they do and so we have to recognize them.

I am aware of everything you just said, but it is not what I asked. Kindly reread my original post more thoroughly.

I was saying that their terms should not appear in the translation resource. Translating those is no use, since you can't find them anyway.

Ok, sorry I did read this quickly.  I agree there is no reason to ask people to translate the terms.

No problem :)

This is done..


Maven proxy config works from windows PC, but not RH Jenkins node

Here is the situation:  I use a cert along with a proxy to access the nvd.  It works on windows and not on a RH box.  I get an error "Using the configured proxy username and password" but I'm haven't configure them.  Any ideas?
Win10 client:

Proxy setting in ~/.m2/settings.xml with server and port
Cert file in $JAVA_HOME/jre/lib/security/cacerts
-Djavax.net.ssl.trustStore=/path/to/cacerts also worked
-Ddownloader.quick.query.timestamp=false was also required to stop failing 95%
Apache Maven 3.3.9
Java version: 1.8.0_45, vendor: Oracle Corporation

RH server:

Proxy setting in ~/.m2/settings.xml
Cert file in $JAVA_HOME/jre/lib/security/cacerts
Also tried -Djavax.net.ssl.trustStore=/path/to/cacerts
Apache Maven 3.3.9
Java version: 1.8.0_212, vendor: Oracle Corporation

The proxy has worked on my desktop with the configs above, but I can't get it to work on the RH box.  I don't have CLI access but I can modify jobs.
I use the following parameters to run it (or use a config in the POM):

 mvn org.owasp:dependency-check-maven:3.3.4:aggregate

Here is the error I get:
[DEBUG] Checking for updates from: https://nvd.nist.gov/feeds/xml/cve/2.0/nvdcve-2.0-2005.xml.gz
[DEBUG] Checking for updates from: https://nvd.nist.gov/feeds/xml/cve/2.0/nvdcve-2.0-2014.xml.gz
[DEBUG] Available Protocols:
[DEBUG] SSLv2Hello
[DEBUG] SSLv3
[DEBUG] TLSv1
[DEBUG] TLSv1.1
[DEBUG] TLSv1.2
**[DEBUG] Using the configured proxy username and password**
[WARNING] Unable to download the NVD CVE data; the results may not include the most recent CPE/CVEs from the NVD.

No Username or Password is defined that I can find on either box.  I've looked in the global settings and my settings, and I've also tried to override them from the command line.
I've read some articles about NTLM but haven't been able to understand enough to test.

Modify the job to run the mvn help:effective-settings for your project on both boxes and compare them.
The log message appears to stem from https://github.com/jeremylong/DependencyCheck/blob/6cad6f389c4fd0f745d267116989c14106be9a2c/utils/src/main/java/org/owasp/dependencycheck/utils/URLConnectionFactory.java#L96
Which is guarded by non-null username and password from the proxy. From a quick first look at the source of those (dependency-check) Settings they appear to be resolved from the Maven Settings object for the active proxy (the first in Maven's proxy list that is 'active' unless also the property 'mavenSettingsProxyId' is set, in that case it returns the Maven Settings proxy that has that Id.

Thanks for that effective settings goal. really great tool.
Here is the proxy section for both machines.  There are differences in the server section with multiple username/password/id's, and an additional repository on the RH box, but nothing different related to the proxy.
  <proxies xmlns="http://maven.apache.org/SETTINGS/1.1.0">
    <proxy>
      <username />
      <password />
      <host>proxy.foo.blah.com</host>
      <nonProxyHosts>*.blah.com|*.blah.com</nonProxyHosts>
      <id>proxy</id>
    </proxy>
  </proxies>

Any ideas?


Security PIN protocol

Hello, I'd love to help knock off one of your TODOs with adding the security PIN features, but need to know the protocol for doing so. Do you have the protocol documented anywhere, or could send me the procedure for the security PIN?

Unfortunately there are no protocol docs. The code and docs in this app is the closest thing we have to publicly available docs.
If you wish to try and implement this missing feature my suggestion is to download the Android app, enable bluetooth logging, and look at the packets being sent to reverse engineer the protocol.
Sorry I can't be of more assistance.


mujoco.lib is missing in 211

Discussed in https://github.com/deepmind/mujoco/discussions/99

Originally posted by MyelinsheathXD December 28, 2021
mujoco.lib is missing in 211?
Am I missing smth ? Since visual studio requires .lib to load  dll functions at load time..

@MyelinsheathXD My bad, I'll make a replacement zip with these added.

I've updated the Windows zip.


exports is not defined after build, works fine in dev mode

🐛 Bug Report
Prerequisites

[x] I'm using the latest version of Docusaurus.
[ x I have tried the npm run clear or yarn clear command.
[x] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io
[x] I have read the console error message carefully (if applicable)

Description
I am developing a plugin to embed jupyter notebook into docusaurus (see screenshot below). The dependencies developed in Typescript and built with 'module:  commonjs. This works fine with docusaurus start(dev mode). I can also build fine withdocusaurus build. However, when I run docusaurus serve, I receive ReferenceError: exports is not defined`. The relevant block code is pasted after the images.

    46932: function(e, t, n) {
        "use strict";
        n.r(t);
        var o = n(4730);
        Object.defineProperty(t, "__esModule", {
            value: !0
        });
        var r = n(75445)
          , i = function() {
            function e(e) {
                var t = this;
                this._onIOPub = function(e) {
                    switch (e.header.msg_type) {
                    case "execute_result":
                    case "display_data":
                        break;
                    case "update_display_data":
                        t._output = e.content,
                        console.log(t._output),
                        t._stateChanged.emit()
                    }
                }
                ,
                this._future = null,
                this._output = null,
                this._stateChanged = new r.Signal(this),
                this._sessionContext = e
            }
            return e.prototype.execute = function(e) {
                var t, n, o;
                this._sessionContext && (null === (t = this._sessionContext.session) || void 0 === t ? void 0 : t.kernel) && (this.future = null === (o = null === (n = this._sessionContext.session) || void 0 === n ? void 0 : n.kernel) || void 0 === o ? void 0 : o.requestExecute({
                    code: e
                }))
            }
            ,
            (0,
            o.Z)(e, [{
                key: "future",
                get: function() {
                    return this._future
                },
                set: function(e) {
                    this._future = e,
                    e && (e.onIOPub = this._onIOPub)
                }
            }, {
                key: "output",
                get: function() {
                    return this._output
                }
            }, {
                key: "stateChanged",
                get: function() {
                    return this._stateChanged
                }
            }]),
            e
        }();
        exports.default = i
    },

With the typescript plugin being compiled with "module": "ESNext" in tsconfig.json , I get TypeError: Class constructor t cannot be invoked without 'new'

I have hacked a bit the @docusaurus/core/lib/babel/preset.js and changed the logic for isServer:
...
        presets: [
            !isServer
                ? [
                    require.resolve('@babel/preset-env'),
                    {
                        targets: {
                            node: 'current',
                        },
                    },
                ]
...

In that case, with the typescript plugin complied in ESNext, the Client build fine, the server fails with TypeError: str.startsWith is not a function, but yarn serve run well.
I came as temporary workaround to change the babel.config.js to point to a local preset with that patch.

Hi,
I'm not sure it can be considered a bug and don't even know what to do why this issue if I can't run/inspect any code that fails, so I'm closing it until it's proven there's a bug in Docusaurus.
I'm willing to support you integrating Jupyter Notebook in Docusaurus, and we can continue the discussion here if you need help/support, but I'll need to see/run your code myself to be helpful. Also I'm not familiar at all with Jupyter Notebook 😅

Not sure at all if it is a bug, I have just followed the PR wizard...
I think it is more a matter of webpack configuration. I agree a reproducer is needed and will provide one at some point.
Feedback from the user land: Docusaurus is great and will be even greater with a few examples of typescript plugins.

@echarles how did you fix the first error?    Do you have a local babel.config.js? Is it automatically used or does it need to be added in the docusaurus config in some way?
Can you share the babel.config.js file?

@tony My case was a docusaurus plugin for which I have defined the following configuration (no babel.config.js). It will not help as the configuration is very specific to my development, but here it is.
export default function (
  _context: LoadContext,
  options: PluginOptions,
): Plugin<void> {
  const isProd = process.env.NODE_ENV === 'production';
  return {
    name: 'docusaurus-plugin-jupyter',
    getThemePath() {
      return path.resolve(__dirname, './theme');
    },
    configureWebpack(_config: Configuration, isServer: boolean) {
      return {
        mergeStrategy: {
          'module.rules': 'prepend',
          'plugins': 'prepend',
        },
        module: {
          rules: [
            {
              test: /.*lib0.*\.m?js/,
              resolve: {
                fullySpecified: false
              }
            },
          ],
        },
        plugins: [
          new ProvidePlugin({
            process: 'process/browser'
          }),
        ]
      };
    },
  };
}

@echarles thank you - i will look at it as an example / for inspiration
To clarify, that config is your docusaurus.config.js?   I'm not that code is for. It seems to be a docusaurus plugin?

@tony This is some code for a docusuarus plugin in the src/index.ts, a bit like https://github.com/facebook/docusaurus/blob/master/packages/docusaurus-plugin-ideal-image/src/index.ts

I ran into the exact same issue as @echarles. The Docusaurus plugin I was developing ran fine in development mode but broke with the ReferenceError: exports is not defined message when building for production. It appears to be related to Webpack.
After much trial and error, I determined the root cause in my own plugin was using a React class component as a Docusaurus theme element. When I refactored the component into a React function component instead, the plugin built and ran in production with no problems. For reference, this file here from my plugin breaks the output from Docusaurus build, and this file here runs smoothly.
Leaving this comment for anyone else who stumbles across this issue.

@davidtimmons Your problem is because you have set "module": "commonjs" which should nearly be always avoided when transpiling themes. We now have a bit of a guideline here: https://docusaurus.io/docs/next/advanced/architecture
Sometimes Webpack seems to be able to understand exports but not always. Probably class gets transpiled that causes exports to stay as a symbol. You should follow our practice of doing double transpilation, for example, in this package: https://github.com/facebook/docusaurus/tree/main/packages/docusaurus-theme-search-algolia
Related issue: https://github.com/facebook/docusaurus/pull/2074

@Josh-Cena: Thank you for pointing out the upcoming architecture diagram and the Algolia package. They are both illuminating. I quite like the structure of the Algolia package. After refactoring my plugin to incorporate the two separate module structures suggested in these resources, I can confirm that React class and function components both work equally well with Docusaurus theme files. As you say, what I originally suspected must just be an artifact of how Webpack works. I appreciate the tips!


Autobahn ci

Hello, this is an attempt to resolve #2
I extended the test server and added another app that runs the autobahn docker image. Since i don't know much about Trail or Nomad i only made the test server compile.
The result is that autobahn and the test server run with riot and at some point the test server crashes and i think this makes autobahn crash too, you can see an example of this running here: https://github.com/francoganga/nomad/actions/runs/8206841697/job/22446832225
I added a step for uploading the resulting report, but i could not test it for the reason i mentioned
I probably should mention that im a bit new to ocaml so do let me know if there are things to fix.
Also this is my first pr,  sorry if  the commits are a mess

Also i didn't know how to build the test server so i added a dune file, i don't know if thats ok

Hi @francoganga! This PR looks like a great start ✨ – we can probably do a few small things to get it merged, and then improve on it.
First thing would be to run the formatter, you can do this with dune fmt. That should format all the new OCaml code you've written.
Second would be how the Autobahn Riot app is defined. We probably want something a little more like this to be more idiomatic with Riot, but also to encapsulate the docker spawning process and make sure the Autobahn Riot app doesn't terminate immediately.
module Autobahn = struct
  let spawn_docker args = ...

  let init () =
    let docker_pid = spawn_docker args in
    (* after spawning the OS process, we want to keep the riot Autobahn app alive,
       so we just _wait_ to receive a message *)
    match receive () with
    | _ -> failwith "should never have received a message"

  let start () =
    let pid = spawn init in
    Ok pid
end


action core.remote fails with 'invalid or unsupported key' when username and private_key specifed

When I have paramiko enable in configuration:
use_paramiko_ssh_runner = True

Then running
stanley@stackstorm:~$ st2 run core.remote cmd=echo hosts=host1 username=user1 private_key=/tmp/id_rsa

Fails with
.
id: 560a792802ebd547018c93ea
status: failed
result:
{
    "traceback": "  File "/usr/lib/python2.7/dist-packages/st2actions/container/base.py", line 99, in _do_run
    runner.pre_run()
  File "/usr/lib/python2.7/dist-packages/st2actions/runners/ssh/paramiko_ssh_runner.py", line 130, in pre_run
    connect=True
  File "/usr/lib/python2.7/dist-packages/st2actions/runners/ssh/parallel_ssh.py", line 55, in __init__
    connect_results = self.connect(raise_on_any_error=raise_on_any_error)
  File "/usr/lib/python2.7/dist-packages/st2actions/runners/ssh/parallel_ssh.py", line 85, in connect
    raise NoHostsConnectedToException(msg)
",
    "error": "Unable to connect to any one of the hosts: [u'host1'].

 connect_errors={
  "host1": {
    "failed": true,
    "traceback": "  File \"/usr/lib/python2.7/dist-packages/st2actions/runners/ssh/parallel_ssh.py\", line 239, in _connect\n    client.connect()\n  File \"/usr/lib/python2.7/dist-packages/st2actions/runners/ssh/paramiko_ssh.py\", line 122, in connect\n    conninfo['pkey'] = self._get_pkey_object(key=self.key_material)\n  File \"/usr/lib/python2.7/dist-packages/st2actions/runners/ssh/paramiko_ssh.py\", line 482, in _get_pkey_object\n    raise paramiko.ssh_exception.SSHException(msg)\n",
    "return_code": 255,
    "succeeded": false,
    "error": "Cannot connect to host. Invalid or unsupported key type"
  }
}"
}

But after disabling paramiko use_paramiko_ssh_runner = False it works (the same key file, permissions and user)
.
id: 560a7abe02ebd5056c8cb17f
status: succeeded
result:
{
    "host1": {
        "failed": false,
        "stderr": "",
        "return_code": 0,
        "succeeded": true,
        "stdout": ""
    }
}

I have found an old issue on paramiko https://github.com/paramiko/paramiko/issues/340 . So I tried chaning format of rsa key to remove leading  and trailing ..KEY.. parts, but with no luck.

Please use:
st2 run core.remote cmd=echo hosts=host1 username=user1 @private_key=/tmp/id_rsa

private_key parameter needs to contain contents of a private key and not a path. Putting @ in front of the parameter allows you to specify a path to a file which content is then read and stored in the parameter value.

@Kami thank you for your help.
I tried with @ just now, and the error is the same.
I have also tried to assign contents of the key with
KEY=$(cat /tmp/id_rsa)

Then
st2 run core.remote cmd=echo hosts=backup.ai-traders.com username=aitbackup private_key=$KEY

Still the same.

Can you please gist the output of the following command:
st2 --debug run core.remote cmd=echo hosts=host1 username=user1 @private_key=/tmp/id_rsa

Keep in mind that this will include the raw content of the private key file in the log, but at this point it looks like it's something weird going on we the key so we need to check that. The best thing to do is to generate a one-time key you will use for debugging.

Sure. Here is the command and output https://gist.github.com/tomzo/5c4c79c0a576cde1a95f
host and username is little different than what I said so far.
I am just trying out stackstorm, there are no sensitive information there, key is a dummy anyway.

OK. Sorry. Now I see myself. The key was still missing the trailing and leading --- Key --- elements after my initial experiments.
It works with @ now.
Thanks for help.

Np :)
I also pushed a change which will throw a more user-friendly exception is user passes in something which looks like a path and not key material (https://github.com/StackStorm/st2/pull/2024).


Consideration of ABAP Language Version

Introduction of new method: get_abap_version
Get the ABAP language version information of attached XML file and pass it to fm for creation

#1566

Hi Thomas,
Can we close https://github.com/larshp/abapGit/pull/1569 plus https://github.com/larshp/abapGit/pull/1602 and have this PR fix #1566 ? The changes look similar

Thanks 👍


TA help: i movie

Create a section for TAs on how to use imoview and quicktime to record audio and manipilate it with i movie


[Example] ggml: add test for set input twice

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


Database Table Columns disappears

Laravel Version: 5.5.28
Voyager Version: 1.0.11
PHP Version: 7.1.5
Database Driver & Version: 10.3.3-MariaDB & MySQL 5.7
Server version: 10.3.3-MariaDB-log - mariadb.org binary distribution
Database client version: libmysql - 5.6.34

Description:
Suddenly without any editing anything, the Database Table Column and its contents disappear. Instead of showing the database column and its values, the field is showing source values.
I think something is coming from external and blocking to load the assets which are responsible to load the database table column contents.
I have checked the source code and the recent changes but could not find the issue.

Steps To Reproduce:
I don't know.

Is this still a problem? Or did you find a solution?

Hello @emptynick,
Thanks for your response. I had found the solution to the problem.
Thanks for asking!


Logger API is very inconsistent

Proposed refactor
Currently, the API across loggers is very inconsistent. They all attempt to implement an common interface pattern by inheriting from LightningLoggerBase, but all of them then turn around and violate the interface in one way or another.
I therefore propose to have a really long hard look at the logger APIs, and to figure out a common interface for them all. Internally, all of the loggers naturally work a bit differently and they all have their quirks, but the point of a common interface is to hide these idiosyncrasies from the user.
Motivation
A common interface for loggers allows the user to quickly and easily replace one logger with another one, and to not worry about each individual type of logger.
Pitch

Investigate all loggers individually and together
Identify functionality that should be provided by them all
Implement a common interface for these loggers
Implement each individual logger to follow the interface exactly

cc @justusschock @awaelchli @akihironitta @tchaton @borda @edward-io @ananthsub

@nils-werner do you have specific feedback for loggers? We started an investigation of logger APIs here: https://docs.google.com/document/d/1xHU7-iQSpp9KJTjI3As2EM0mfNHHr37WZYpDpwLkivA/edit#heading=h.g6ftsmnvn08y
You can add comments/thoughts here based on what you think is missing.
A difficulty is that the underlying implementations themselves are very different, across Tensorboard, Weights & Biases, MLFlow, CSV loggers, etc. Some support certain features while others don't, and this percolates up to the base Logger API

The idea of implementing a LoggerBase and deriving all specializations from it is to provide a common API for all of them. That way you can inject any logger you like, as long as its interface derives from LoggerBase (in compiled languages, this would even be checked at compile time).
However this principle is not being followed, and all loggers implement their own interface. You cannot simply replace one logger with another.


Do not show claims_supported items for 'hidden' resource / scope in Discovery Document

[x] I read and understood how to enable logging

Issue
Why do I see claims under claims_supported that are associated only to an IdentityResource / ApiScope where ShowInDiscoveryDocument is false? The claims are supported, but I would expect not to see those because the 'parent' (IdentityResource / ApiScope) is hidden. Why would I hide the supported scope as the related claim(s) remain visible?
Since it is not possible to hide claims, I think it would be nice if the list of claims_supported can be reduced by not showing claims that are associated to hidden IdentityResources / ApiScopes only. Like already is the case for disabled resources / scopes.
Steps to reproduce the problem
Start IdentityServer4 and go to the discovery document: http://localhost:5000/.well-known/openid-configuration There are scopes_supported and claims_supported.
Disable 'My API' in ApiResources. Claims are removed from list.
Enable 'My API' again and set ShowInDiscoveryDocument = false for ApiScope 'My API'.
Claims remain visible on the list, while the scope is removed. Expected: claims are removed from the list.
Relevant parts of the log file

Thanks - that sounds like a bug.
In the meantime you can completely disable the claims_supported section in the discovery document via the discovery options.

fixed.


Support service suppression

Be able to remove a service from another module/feature.
c.f. discussion in https://github.com/OrchardCMS/Orchard2/pull/843

Can't you just replace?

I changed the title, it's not about supporting this attribute, but defining a solution that works, whatever it is. Read the linked PR comments as it explains it doesn't work right now.

Okay, still confused as replace should work. :/

Maybe I broke it at some point with multi-tenant support. I don't know if we have any test for this.

I can look into this over the next few days and submit a pull request. I'll make sure to add a couple unit tests.
@Jetski5822, Replace will now work again if you get latest with my change, but there's some cases with FeatureTypeProvider that I want to check. For example I expect issues if a IPermissionProvider was Replaced since that is used by the FeatureTypeProvider.

Some initial work in my branch on this which includes a failing unit test for the TypeFeatureProvider issue ('CanReplaceDefaultServiceWithCustomService'):
https://github.com/jrestall/Orchard2/commit/bf5dae7198dcb5c2874d833b40984143c5c0751e
https://github.com/jrestall/Orchard2/commit/03633b98d33e5c0fb64f5307de110b0e624daaec
Hopefully the unit test helps clarify the issue Nick. I'll see what I can do for a fix when I get a chance.

Ah yes!!... It was broken, due to each service having separate registration, so replace would never had worked. Your stuff fixed that.
Good work so far @jrestall

This issue could be closed now.


Research outputs are not dowloading as csv

A user reported that the Research Outputs are not included when selecting the CSV download option.

Added research output and related works below the plan's narrative.


What's the correct way to start a manual charge?

Version of the custom_component
Version: latest
Configuration
Tesla Model 3 + Easee Home charger. Car set to charge to 100%, Smart charging is enabled, and it should be done at 7 AM.
 I've been using the integration for 2-3 days now, and with great success, but I always have that "what if it doesn't charge" in the back of my head. I am using your card example:

However, as you might be able to see, I have added my Easee Home charger at the bottom as a switch. And surely enough, when I enable the switch, the car starts charging manually.
HOWEVER, and this is probably entirely my fault, charging stopped randomly at 03:44 tonight, but I don't know why.

As you can see, the integration reported that charging was set to true between 3 AM and 7 AM, however, I started charging at 02:03 AM, by enabling the charger. I did NOT press the "Manual start" button. Is this the problem?
Also, take a look at this. I did turn on the charger at 02:03, but nothing turned it off until 05:00 (and then on again 1 second later). So the charger never turned off around 03:44, yet it stopped charging the car at about 85% SoC:

Let me know if you want more data.

To start with, it's not recommended to use the switch in the Easee integration to control the charger. Instead the recommended way is described here.
That you turned on the charger at 02:03 shouldn't be a problem.
That the charging control from the integration turned off the switch at 05:00 was most likely because the initial charging schedule was 03:00-05:00.
However, since the charger stopped charging at 03:44, the target SOC was not reached at 05:00, and the integration made a new charging schedule 05:00-07:00, and sent a turn on command to the switch at 05:00:01.
This quickly turning off and then on again is a known bug that will be fixed #124.
However, in your case the problem seems to be that the charger stopped at 03:44. But from the information you have provided, there is nothing that indicated that the charger was stopped by the integration.
Do you know why the charging was stopped at 03:44?
As for your question in the title of the issue, to press the "Manually start charging"-button would be good way to manually start charging. Note that this will not deactivate the smart charging. If there is a scheduled charging 03:00-05:00, and you manually start at 02:03, then the integration will stop the charging at 05:00.

Thanks for the reply @jonasbkarlsson
What is the difference between switch.charger and setting the current on all 3 phases to something? If the current is always set to 16A on 3 phases, and I turn on the charger, it will start charging at 16A on 3 phases. Why set it to 16 (and 0) with easee.set_circuit_dynamic_limit when I have the switch available to me?

Do you know why the charging was stopped at 03:44?

No, unfortunately I do not. I just started a charge about an hour ago at 18%, by pressing the "Manually start charging" button (instead of enabling the charger with the switch), and now I have 3.5 hours to check the state. Still not sure why it stopped at 03:44 out of the blue. All my data checks out. I wish the Easee charger would show how each charge was started and stopped, so we can debug it easier.

As I have understood it, using the switch will change some configuraton memory in the charger. This memory is not meant to be changed often. So the lifetime of the charger could become shorter if one does this too often. (I have no idea what too often would be.) The developers of the Easee integration recommends to use easee.set_circuit_dynamic_limit instead.

Aha, I see. I will go change that, then.
Can I tell your integration not to use that switch anymore? Or do I have to delete it and add it again?

Unfortunetely not. You would need to delete it and add it again. But Home Assistant will assign the same name for the new instance, so you would only need to redo the inital configuration, and then set the configuration entities to what you had before, and then everything should work again.

Sounds good - will try it out and report back!

So it's not really working for me. I can't really get the buttons to function correctly. Calling the service isn't quite working either. Charger is enabled.
No matter what I did to the buttons, or called the service, the car would not charge. I had to manually go into the Easee app and start the charge, which I did at around 11:10 PM. I also enabled the manual charging using the button from your example, which calls the automation that sets all 3 phases to 16A.
However, at 00:00 (cheapest time and 8 minutes ago), the charging suddenly stopped and now it won't resume again automatically. I suspect it's because of the issue #124 you mentioned, because I can see in the log, that it changed from off to on in a second.

The car is NOT charging in this state.
Also, when I plug the car in, it starts charging automatically no matter what hour of the day. Do I need a 4th automation that tells it to stop charging? Because at that point, it doesn't seem very smart anymore.
Let me know what you think.

First, just to make sure, you need to remove any schedules that you might have programmed in the Easee charger.
And then you need to have the two automations that changes the max current for the three phases.
And then you need to verify that it works.

Connect the car to the Easee charger (at a time the car is less charged than the target SOC)
Press "Manually start charging"
Check that the car now is be charged.
Press "Manually stop charging"
Check that the charging is stopped.
Press "Manually start charging"
Check that the car now is be charged.

If this didn't work, there is likely some errors in the two automations. It is working for others.

It's really, really not consistent :( Yesterday night and today it worked fine. Maybe I just need to keep my hands off the manual buttons, because they've caused a lot of issues for me.

So it has been running automatically for a while now, and I think it's safe to say that it works, as long as I don't manually start the charge 😆 If it comes to that, I will keep an eye out. Thanks!
On a quick note: Do you happen to have a card handy, that can display stuff like "charge starting in x hours" based on the attributes? I could make it myself, but I'd rather ask around first.

Good to hear that it works! There are some examples on how to show attributes here #38