AICamera demo failed with latest caffe2 on Android

Hi,
I am trying to run the AICamera demo app with latest caffe2 built but it failed with either USE_MOBILE_OPENGL ON or OFF. So I think the problem may not be from the new GL backend USE_MOBILE_OPENGL. Anyone has been successfully run AICamera demo app with latest caffe2 built?
Thanks

Which build error message do you have? cc @bwasti

It's not an build error. But the AI Camera app crashed with the caffe2 libs built from caffe2 tip repo while it ran well with the pre-built libs provided with the AICamera repo.
So I think there may be some compatibility between the AICamera app and latest Caffe2 tree.

@rlegithub I just tried with current HEAD of caffe2, with USE_MOBILE_OPENGL turned off (./scripts/build_android.sh -DUSE_MOBILE_OPENGL=OFF) it works. I have updated the caffe2 version in my fork: https://github.com/bddppq/AICamera

I got the same runtime error even with  USE_MOBILE_OPENGL turned off
./scripts/build_android.sh -DUSE_MOBILE_OPENGL=OFF
Someone has any idea?
here is a callstack:
`SIGSEGV (signal SIGSEGV: address access protected (fault address: 0xffffffffa5524fe0))
std::function<void (void*)>::function(std::function<void (void*)> const&) functional:2410
void std::__shared_ptr<void, (__gnu_cxx::_Lock_policy)2>::reset<void, std::function<void (void*)> >(void*, std::function<void (void*)>) shared_ptr_base.h:1029
caffe2::Tensorcaffe2::CPUContext::raw_mutable_data(caffe2::TypeMeta const&) tensor.h:520
caffe2::GivenTensorFillOp<float, caffe2::CPUContext>::GivenTensorFillOp(caffe2::OperatorDef const&, caffe2::Workspace*)
std::unique_ptr<caffe2::OperatorBase, std::default_deletecaffe2::OperatorBase > caffe2::Registerer<std::string, caffe2::OperatorBase, caffe2::OperatorDef const&, caffe2::Workspace*>::DefaultCreator<caffe2::GivenTensorFillOp<float, caffe2::CPUContext> >(caffe2::OperatorDef const&, caffe2::Workspace*)
std::_Function_handler<std::unique_ptr<caffe2::OperatorBase, std::default_deletecaffe2::OperatorBase > (caffe2::OperatorDef const&, caffe2::Workspace*), std::unique_ptr<caffe2::OperatorBase, std::default_deletecaffe2::OperatorBase > ()(caffe2::OperatorDef const&, caffe2::Workspace)>::_M_invoke(std::_Any_data const&, caffe2::OperatorDef const&, caffe2::Workspace*)
caffe2::(anonymous namespace)::TryCreateOperator(std::string const&, caffe2::OperatorDef const&, caffe2::Workspace*)
caffe2::CreateOperator(caffe2::OperatorDef const&, caffe2::Workspace*, int)
caffe2::SimpleNet::SimpleNet(std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*)
caffe2::CreateNet(std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*)
caffe2::CreateNet(caffe2::NetDef const&, caffe2::Workspace*)
caffe2::Workspace::RunNetOnce(caffe2::NetDef const&)
caffe2::Predictor::Predictor(caffe2::NetDef const&, caffe2::NetDef const&, caffe2::Workspace*)
::Java_facebook_f8demo_ClassifyCamera_initCaffe2(JNIEnv *, jobject, jobject) native-lib.cpp:56`

Thanks a lot for the pointer @bddppq. I will give it a try with your fork and will let you know the result.

@bddppq I have tried your fork but it does not work. Could you share which device you was able successfully run the app with latest Caffe2?
Thanks

Add a bit more debug infor here:
When running with new libs saw this in adb logcat: A/libc: Fatal signal 11 (SIGSEGV), code 2, fault addr 0xd15003e4 in tid 8498 (AsyncTask #1)

@rlegithub I was running it on a Galaxy S7. Which device did you use?

@bddppq I ran on Asus Zen. Precisely, I actually could run the app built from your fork. However, when I tried to copy the caffe2 libs from your fork to replace the libs in the original AICamera repo then the app failed! Did you do anything special with your fork helped it work?

@rlegithub You need to not only copy the new libs files (both the caffe2 libs and protobuf libs) but also the header files.
Actually let's merge my fork to the main repo, we need the newer version of caffe2 for another use case anyway.

Ah that explains it. Yeah, I think if your fork is stable & good, we should merge it to the main.
Thanks,

@rlegithub It has been merged to the main repo now. Thanks to @bwasti .


fix(icgm): make sensor compatible and more aligned with simulator

Added in 1) a few necessary compatibility changes for the simulator 2) some design changes 3) some stylistic changes. Would be great to review async or together ASAP.

Keeping cas/icgm branch open for now since the simulator refers to it for the Insulet pulse analysis


Update free-programming-books-pl.md

Add C language book and course.

Great additions! Observation: Looks like the polish page does have many of the authors listed; we like to recognize them where appropriate.


Fixed typo on link in SQL DB Technical Overview

Hi @jangelfdez, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@jangelfdez : Thanks for your contribution to the Azure documentation! The author, @shontnew, has been notified to review your proposed change.

Thanks @shontnew , closing the PR then


Using GitHub Action Bot to run build Workflow

Current dependencies on/for this PR:

main

PR #125   👈

This comment was auto-generated by Graphite.


Add antctl CLI command to run post-installation checks

This is a subtask for https://github.com/antrea-io/antrea/issues/5896
Regardless of the installation method for Antrea, it would be useful to have an antctl CLI command to quickly validate an Antrea installation and identify possible problems with the cluster. In essence, this command would serve a similar purpose as cilium connectivity test, which currently runs 69 connectivity tests.
We should probably start with a small set of tests initially (which by the way may not be limited to connectivity). If we have a robust and flexible framework, we can easily add new tests over time as needed.
Note that there is a fine line between post-installation checks and e2e tests. We want to avoid too much redundancy between the 2, and post-installation checks should ideally run pretty fast, so that users can run them after each installation and get results quickly.

cc @kanha-gupta

I have an idea for a specific post-installation test, once #6133 (which defines the framework) is merged: when Antrea is deployed with encryption enabled (e.g., with Wireguard), we should include a test to validate that inter-Node Pod-to-Pod traffic is indeed encrypted. I think this could give users confidence that encryption is working correctly.

I have an idea for a specific post-installation test, once #6133 (which defines the framework) is merged: when Antrea is deployed with encryption enabled (e.g., with Wireguard), we should include a test to validate that inter-Node Pod-to-Pod traffic is indeed encrypted. I think this could give users confidence that encryption is working correctly.

Hi @antoninbas, The idea Sounds good to me :)

Closing the issue as we have added the framework and a selection of tests. More tests will be added over time.


Razor file compilation in ASP.NET Core not working

The guide explained for "Razor file compilation in ASP.NET Core" is not working anymore. If you follow the exact steps mentioned on the page it will result in a System.ArgumentNullException for the MapControllerRoute.
See my issue in details here at stack overflow:
https://stackoverflow.com/questions/71717192/net-6-mvc-enabling-razor-runtime-compilation-breaks-program-cs

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a83deb2-e035-bb66-be4f-68709bcad341
Version Independent ID: 16438f35-f35d-c097-0903-ec17e83e051e
Content: Razor file compilation in ASP.NET Core
Content Source: aspnetcore/mvc/views/view-compilation.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hi @kmai-universe. We verified that the instructions in this article are correct during a recent update, and I've just double-checked that it all works without issue. At this point, we'd usually recommend asking a question on Stack Overflow, but you've already done that. As I don't believe that this is an issue with the docs, I'll close this issue, but if you find the solution to your problem and feel it's worthy of being added to the docs, we can consider reopening this later.


Retrieve all the possible values

I am an undergraduate student and i am working on a project about a perfect interactive/smart house. I need to make a retrieve request and take all the possible values/restrictions from a resource's properties.
e.g. i have an air-condition for a resource and it's property is an enum for state: { 'on', 'off', 'sleep' }. Making a retrieve request gives me a string. How can i get all its' possible values?
Thanks! :)

I think that is what "introspection" is for - to inspect a device's capabilities and schema. I'm not sure if and how that works with iotivity-node though.

@VasilisCh device properties follow a schema. Some properties are specified as "enum", in which case the schema lists all possible values.

Hello, I have the same problem.
I participate in a project that we have to automatic generate respective GUI application in which
the user can control (i.e. change values of the properties) of the connected smart devices.
For example, in case of the air-condition enum state { 'on', 'off', 'sleep' }, we would like to generate
e.g.

ON
OFF
SLEEP

In addition, restrictions of numbers (e.g. possible values temperature of air-condition) etc.
Is there any way to retrieve possible values, restrictions etc.?
Thank you in advance! :)

@VasilisCh if you have any other concerns about the way iotivity-node works, please file another issue!


Change month selection place

Expected Behavior / Goal

I need to change month selection place , it should be either on right side or left side rather than top. Something like attached screenshot.

You can set your own layout and arrange the elements as you like. You can do this by creating a layout with the name "item_calendar.xml" in the layout directory: https://developer.android.com/studio/write/add-resources.html#resource_merging

Thank you for your reference , but i need to implement when i change month and year  , add particular month's day with day name , using this library i have tried this but in that i am having issue with generating days. Can you please guide me ?

if i have been given a month value 7 or anything  , how can i point this calendar to that month , what should be my start date , can i use month value to decide pointers position?


Add support to seek from start on transcoding

This enables to pass -ss 'hh:mm:ss' to ffmpeg as a way of seeking from the beginning when transcoding to mp4.
Need to figure out a way to pass the user input to this function (--seek), and also to make this parameter appear before -i.
#119

To update it on the user input is the big problem..

I don't know node.js, but we can use a parameter file (name as a constant) that will be read in this function and will contain hh:mm:ss.
This is not a good practice but will work as a workaround.

This commit works from file.
Just a POC, so needs error handling and such.

OK, after a bit of looking around this code, figured how to get user input for this to work :)
You misled me a bit, as it was like getting the '--tomp4' option there, in the variable ctx.options..
Still needs to figure out a way to push the '-ss' parameter before '-i'.

Any updates on this?

@uraid I can not see code for actually killing and replacing Transcoder processes as you describe it. Are you planning to work more on this?

@artheus Nope. I don't plan to work on this anymore.


Sudden collapse

It is said that the use of electricity storage box and molecular converter during operation will cause the server card machine and the players to drop off the line collectively!

Please specify that. What is the actual issue?

Please specify that. What is the actual issue?

i'll upgrade hardware ofthe server latter，if it happened again. i'll reply you as soon as posssible

Seems to be fixed. Close for now


Fix a typo in the Installation section of the README file

Fix a typo in the Installation section of the README file, by changing the package name from league/common to omnipay/common similar to https://omnipay.thephpleague.com/installation/

Thank you.


lager_event message queue growth  [JIRA: RIAK-2433]

Hi folks!
We've hit instances where a burst of traffic into lager will cause the lager_event message queue to grow substantially, to the point where lager is still emptying out several hours later. This causes a system-wide slowdown as lager has switched synchronous mode to cope.
A bit goofy, but something that's bit us a few times as our system has a bursty traffic pattern.
I've put together a repository to reproduce, called burst. You can see it in action here:
(burst@walden)1> spawn(burst, run, [10000,100]), recon:proc_window(message_queue_len, 10, timer:seconds(10)).
[{<0.311.0>,28728,
  [lager_event,
   {current_function,{lager_default_formatter,make_printable,
                                              1}},
   {initial_call,{proc_lib,init_p,5}}]},
 {<0.1040.0>,0,
  [{current_function,{gen,do_call,4}},
   {initial_call,{burst,wrkr,3}}]},
 {<0.1630.0>,0,
  [{current_function,{gen,do_call,4}},
   {initial_call,{burst,wrkr,3}}]},
 {<0.2220.0>,0,
  [{current_function,{gen,do_call,4}},
   {initial_call,{burst,wrkr,3}}]},
 {<0.2810.0>,0,
  [{current_function,{gen,do_call,4}},
   {initial_call,{burst,wrkr,3}}]},
 {<0.7981.0>,0,
  [{current_function,{gen,do_call,4}},
   {initial_call,{burst,wrkr,3}}]},
 {<0.8571.0>,0,
  [{current_function,{gen,do_call,4}},
   {initial_call,{burst,wrkr,3}}]},
 {<0.9161.0>,0,
  [{current_function,{gen,do_call,4}},
   {initial_call,{burst,wrkr,3}}]},
 {<0.3852.0>,0,
  [{current_function,{gen,do_call,4}},
   {initial_call,{burst,wrkr,3}}]},
 {<0.4442.0>,0,
  [{current_function,{gen,do_call,4}},
   {initial_call,{burst,wrkr,3}}]}]

The challenge we have is that there's not much control on the user side once lager_event backs up. For our use case, once you blow past some higher high-water-mark, it'd be desirable just to start dropping log messages, rather than pool them up for later emission.
We'd be happy to do the work. Would this be in-line with lager's handling philosophy?
/cc @JoseManuelRodriguez @miriampena

That's been on the wishlist for a while. There's currently an open PR #248 that kills the event handler and restarts it once it exceeds some threshold and both @macintux and I were ... unsure that was the right behavior.
I think what you're proposing sounds more palatable. Do you have any thoughts @Vagabond?

I am open to either suggestion, if the logging pressure is that high you're kind of stuck.

Killing the worker is definitely the easier route.

@Vagabond Agreed on that. What do you think of #248?  We've been somewhat wary of it mostly due to the semantics of a kill/restart.

For what it's worth, kill/restart would be sufficient for our needs.
On Wed, Mar 9, 2016 at 08:51 Mark Allen<EMAIL_ADDRESS>wrote:

@Vagabond https://github.com/Vagabond Agreed on that. What do you think
of #248 https://github.com/basho/lager/pull/248? We've been somewhat
wary of it mostly due to the semantics of a kill/restart.
—
Reply to this email directly or view it on GitHub
https://github.com/basho/lager/issues/324#issuecomment-194392828.

@blt If y'all want to rebase #248 against 3.1.0 and try it out, I would be grateful for the work and feedback on its efficacy.

@mrallen1 It's a plan. Expect I'll get back to you later in the day.

:candy: thanks!

As this has been merged, I'm going to close it.


[Suggestion Request] Metro Style Charts Framework working with Mahapps.

Hi Guys.
I`m looking for a metro style charts framework which can work with Mahapps perfectly.
By right, I have found one named 'WPF Metro UI Charts' (http://gamandelkowcharts.codeplex.com/), but I don`t kown whether it can work good because it has stopped updating since Oct 8, 2015.
Can anyone give me some suggestions ?

my favourite: https://github.com/beto-rodriguez/Live-Charts

I second LiveCharts - I have started integrating it with my app, and I love the layout / design.  Additionally, it is also very actively maintained, which is important - they even have a Gitter room that is always in use.


Taxi q experiment panics

Using go1.14.1 with https://github.com/aunum/gold/commit/8dedf68d0993b8fb4355edfc560c1567ea9fb80c I get a panic in taxi experiment:
go run -trimpath ./pkg/v1/agent/q/experiments/taxi/main.go
ℹ  tracking data in /var/folders/zy/lzyp__pd7vx6762s5jcgkkl80000gn/T/stats.104998610.json
ℹ  connecting to existing container "stupefied_taussig"
✔  connected to server "gym"
✔  created env: f07159db-890d-45ca-a295-aa9e383507de
ℹ  serving agent api/ui on http://localhost:39421
ℹ  running for 5000 episodes
✖  rpc error: code = Unknown desc = Exception calling application: 'int' object has no attribute 'ravel'
goroutine 1 [running]:
runtime/debug.Stack(0x75, 0x0, 0x0)
        runtime/debug/stack.go:24 +0x9d
runtime/debug.PrintStack()
        runtime/debug/stack.go:16 +0x22
github.com/aunum/log.fatalf(0xc0007e0100, 0x1c76e46, 0x3, 0xc0007e1f28, 0x1, 0x1)
        github.com/aunum/log@v0.0.0-20200321163253-24c356e939b0/log.go:77 +0x11d
github.com/aunum/log.Fatalf(...)
        github.com/aunum/log@v0.0.0-20200321163253-24c356e939b0/log.go:64
github.com/aunum/log.Fatal(0xc0007e1f28, 0x1, 0x1)
        github.com/aunum/log@v0.0.0-20200321163253-24c356e939b0/log.go:109 +0xa3
github.com/aunum/gold/pkg/v1/common/require.NoError(...)
        github.com/aunum/gold/pkg/v1/common/require/require.go:18
main.main()
        command-line-arguments/main.go:36 +0x303
exit status 1

ah I think this is because I haven't pushed the new container, let me check

thanks for catching this, new container is pushed, just tested on master. Let me know if you have any trouble

So, I've checked this and I still get the same thing despite updating to https://github.com/aunum/gold/commit/bb713ddf1b77c4274386aecc501e4870e5c5d61c
Should I do something else?

try and remove your docker images, to do all would be docker rmi $(docker images) and run it again

I've already remove most of the images that could have been on my machine related to this project but I don't want to remove all the images that I've got.
Do you mind disclosing what concrete images should I be looking for to remove?

yep so you want this image https://hub.docker.com/layers/sphereproject/gym/latest/images/sha256-40a69154793915701befb2b9edcf442edd3e0e6ad485dfe511b3e1d03a79bbe1?context=explore but remove any sphereproject/gym images and try and repull

Alright so it started successfully on my Mac and I wanted to be double sure about this so I launched it on my Ubuntu PC and I got this
go run -trimpath ./pkg/v1/agent/q/experiments/taxi/main.go
ℹ  tracking data in /tmp/stats.443086550.json
ℹ  no existing containers found, creating new...
ℹ  creating local server
✔  connected to server "gym"
✔  created env: 2304e38e-c0cf-4935-804d-85f0056fb48b
ℹ  serving agent api/ui on http://localhost:23295
✖  exit status 3
goroutine 1 [running]:
runtime/debug.Stack(0x1d, 0x0, 0x0)
        runtime/debug/stack.go:24 +0x9d
runtime/debug.PrintStack()
        runtime/debug/stack.go:16 +0x22
github.com/aunum/log.fatalf(0xc000300100, 0x107a886, 0x3, 0xc00030fe20, 0x1, 0x1)
        github.com/aunum/log@v0.0.0-20200321163253-24c356e939b0/log.go:77 +0x11d
github.com/aunum/log.(*Logger).Fatalf(...)
        github.com/aunum/log@v0.0.0-20200321163253-24c356e939b0/logger.go:42
github.com/aunum/log.(*Logger).Fatal(0x18a9ed0, 0xc00030fe20, 0x1, 0x1)
        github.com/aunum/log@v0.0.0-20200321163253-24c356e939b0/logger.go:74 +0x9e
github.com/aunum/gold/pkg/v1/agent.(*Base).View(0xc00042a000)
        github.com/aunum/gold/pkg/v1/agent/base.go:148 +0x9f
main.main()
        command-line-arguments/main.go:20 +0x19d
exit status 1

when
docker images | grep sph                                   monkey@pc
sphereproject/gym                 latest                                  82f491fd7f9e        41 minutes ago      1.88GB

hrm my linux box is down at the moment, let me see if I can spin one up in the cloud an reproduce

what version of ubuntu?

this should be running https://github.com/skratchdot/open-golang/blob/master/open/exec.go#L13 I'm curious if xgd-open http://google.com works

what version of ubuntu?

18.04

Hah, maybe it comes from the fact that I was running this via ssh. Then xdg-open would fail (I guess?)

ah that would make sense, so you could comment out https://github.com/aunum/gold/blob/master/pkg/v1/agent/q/experiments/taxi/main.go#L20 which opens the browser and visualizes the agent, you could always add terminal logging if you want to go that route.

Alright, so this seems to be a non-issue. I'd maybe add a log or something helping out the user with a similar issue in the future.

good call added a log message in https://github.com/aunum/gold/pull/8


Refactor tests for ops

Part 2. Closes #5976
Second part of refactor. This touches only the tests.
Currently have created 2 separate files so that the diff is slightly easier to review. I can merge those files back to test_ops.py if needed. :smile:
cc @pmeier

Thanks @oke-aditya ,
Before moving large section of tests into separate files, I think it might be worth reaching consensus in https://github.com/pytorch/vision/issues/6020 first. I'm a bit wary about such changes as they're really not as free as they might seem.
Do you think it'd be possible to make the relevant changes in this PR while still preserving the current file structure?

Yes @NicolasHug I get your point. The idea is

Currently have created 2 separate files so that the diff is slightly easier to review. I can merge those files back to test_ops.py if needed. smile

Let's finish reviewing and adjusting the code, i will eventually move back code to same file. I took it out so that I could analyse it independently and made it slightly easier to run tests. We won't create this file structure at end of PR.

I will get back to this on Tuesday. I'm shifting homes this week 🏡.

I think this weekend might give me some time. :(

@oke-aditya No worries. We thankfully managed to merge the PR that cleaned up the code prior the release. This is less urgent.

@oke-aditya Do you need help finishing this? I have some dedicated time this afternoon (UTC +2 time) so I can review the code and/or help finishing it. Let me know. :ok_hand:

Hey I'm back on this. Was about to give time on this today. I have finally settled in new (or perhaps old?) home town :smile:

Hey I'm back on this. Was about to give time on this today. I have finally settled in new (or perhaps old?) home town smile
Feel free to help in reviewing as Philip is on PTO.

I will. Good luck with what remains. :+1:

Hi @NicolasHug , @datumbox , @YosuaMichael could someone please review the PR as Philip is having a well deserved PTO :)

Need to check the area one. Probably there is something

Any other concerns apart from the area tests? I will have a look on Friday.

I think that's all on my side, thanks @oke-aditya

@oke-aditya I see you asked for another review. My understanding from your above comment is that you will still try to fix the situation on the area test in this PR, right? If that's the case, I recommend to mark it as draft and reopen once ready for reviews. If you want a review now, let me know and I'll make some time.
Thanks for the contribution as always! :)

@oke-aditya Any more help/review needed here? I have some time this Friday for OSS, so let me know. Thanks. :ok_hand:

Seems we are very close to finish this. Sadly I'm busy at office and sunsetting my old laptop to move onto new one. (it's gonna take some time etc)
You can help me wrap up this PR by simply sending a PR to my fork of torchvision. On this branch. I can merge that.
Then Just ping Nicolas / Vasilis if anything else is needed.

Seems we are very close to finish this. Sadly I'm busy at office and sunsetting my old laptop to move onto new one. (it's gonna take some time etc)
You can help me wrap up this PR by simply sending a PR to my fork of torchvision. On this branch. I can merge that.
Then Just ping Nicolas / Vasilis if anything else is needed.

Alright @oke-aditya, will do this on Firday and let you know. Good luck resetting your computer (I hope you have some of your dot files saved somewhere. :smile: )

Yeah the challenge is that the new laptop has GPU. And I never had GPU locally before. So setting up that with nvidia drivers, building torchvision from source etc is gonna be a cool challenge.
(Yes till now I did all contributions or learn deep learning without GPU :) colab was my messiah)

@oke-aditya compiling from source with GPU should be seamless. If it's not, we will take your PR, thank you very much. 😄

Yeah hopefully :) Doing it first time. All should go well 😊

Major blockers are cleared!
I could successfully build pytorch from source. Which is sadly needed as torch with cuda 11.7 binaries aren't available in nightlies yet :(
I should wrap up the PR by Wednesday 🤠

@NicolasHug how do we go about this ? Is it good to go?

@oke-aditya seems there is a related issue with the linter:
diff --git a/test/test_ops.py b/test/test_ops.py
index 53637baf3..db2ba4776 100644
--- a/test/test_ops.py
+++ b/test/test_ops.py
@@ -3,7 +3,7 @@ import os
 from abc import ABC, abstractmethod
 from functools import lru_cache
 from itertools import product
-from typing import Tuple, Callable, List
+from typing import Callable, List, Tuple

 import numpy as np
 import pytest

I can fix that 😃. Anything else apart from that?

So I have fixed the required issues. I see that even more improvements can be done. And especially we need to address #6317
and add tests accordingly. I will follow up with a new PR.


Dropdown Component demo page rightDrop

Directions section on the the Link.
http://foundation.zurb.com/docs/components/dropdown.html#
Problem:
rightDrop and downDrop behave the same. rightDrop is not working properly i guess. Is it only me?
Here screenshots.

Seems to work well here. http://codepen.io/rafibomb/pen/eprLdO There does seem to be an issue with the docs example though which is a version that has not been released. So 5.3.3 does not seem to have this issue.

It is working now on windows/chrome. The above pictures from mac/chrome.

It is still looks the same. I am on mac. I tried Chrome / Firefox / Safari.


Update request: unl0kr 2.0.0 → 3.0.0

Package name: unl0kr
Latest released version: 3.0.0

Current version on the unstable channel: 2.0.0
Current version on the stable/release channel: ?

[x] Checked the nixpkgs pull requests

Notify maintainers

Unl0kr has a new home in https://gitlab.com/postmarketOS/buffybox.
CC @tomfitzhenry

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

PR for this is here

https://github.com/NixOS/nixpkgs/pull/362825


Refactor methods and stuff

Coverage increased (+0.7%) to 58.765% when pulling 896adf3d9aab7732f35424c0469ec7cdf3bc80bc on refactor into fa08bdf8e10e61fa4a6cab8be152bc4efe8eadd1 on master.


Create Sui Release Notes

What are the existing URLs containing the issue, if any?
https://docs.sui.io/learn#see-whats-new
https://github.com/MystenLabs/sui/blob/main/RELEASES.md
https://discord.com/channels/916379725201563759/974444055259910174
https://github.com/MystenLabs/sui/releases
How would you describe the issue? (What needs changing?)
We have release-related information everywhere. See above plus Notion pages for each release.
Where should this information land if new? (Learn, Build, Explore, Contribute.)
In a distinct Releases section of Contribute, IMHO. Randall to decide.
What changes are needed to support this new feature or product? (A simple overview, detailed procedures?)
We need a release process, expanding upon the existing internal template. And we need to publish first to the docs and then link from Discord, IMO.
Who is the audience for that information? (App developers, investors, creators, validators, someone else?)
Everyone.
What precisely must they do with it? (Configure a new service? Process some output?)
Get it to everyone.

I saw this from Francois yesterday for version 0.6.4:
https://github.com/MystenLabs/sui/pull/3692
But the last release we listed on docs.sui.io is 0.6.1:
https://docs.sui.io/learn#see-whats-new
But I do also see now:
https://github.com/MystenLabs/sui/releases/tag/devnet-0.6.2
https://github.com/MystenLabs/sui/releases/tag/devnet-0.6.3
Do we announce dot releases? I am asking the same question in Slack.

Related, someone is suggesting a node update channel:
https://discord.com/channels/916379725201563759/916379726640193608/1004519882966171648

I'm adding @huitseeker for collaboration on announcing releases that may break full nodes.

Adding @bhenhsi for his help on developing the release notes plan and then distributing updates for releases.

I'd like to explore incorporate a release entry associated with each release in the repo. Would make it easy to find them, and adding info to the release page would be required to push out a new version. Could even link to a page with more details if desired.
https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases
We did this for Amazon Braket: https://github.com/aws/amazon-braket-sdk-python/releases

I'd like to explore incorporating a release entry associated with each release in the repo. Would make it easy to find them, and adding info to the release page would be required to push out a new version. Could even link to a page with more details if desired. https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases
We did this for Amazon Braket: https://github.com/aws/amazon-braket-sdk-python/releases

This looks like:
https://github.com/MystenLabs/sui/releases
Seems like we just need consistency. What was your process?

I'd like to explore incorporating a release entry associated with each release in the repo. Would make it easy to find them, and adding info to the release page would be required to push out a new version. Could even link to a page with more details if desired. https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases
We did this for Amazon Braket: https://github.com/aws/amazon-braket-sdk-python/releases

This looks like: https://github.com/MystenLabs/sui/releases
Seems like we just need consistency. What was your process?

@randall-Mysten, any progress here? We have another release today.

this is an engineering issue

this is an engineering issue

Please explain. You said you helped with release notes previously. And I've certainly done so many times throughout my career. Further, you offered a specific path a la Amazon earlier.
Are you saying you have no intention of helping with release notes?

While we figure out where and how the canonical release notes will land, let's give folks a persistent path to Discord:
https://github.com/MystenLabs/sui/pull/4103

Unless there are objections, I will take this back from @randall-Mysten  so we can start to make the excellent process @ebmifa followed last week repeatable. More to come.

I have now reworked the Release Checklist Template and associated release notes instructions to be much more clear. Now sending out for review.

And I've raised the issue of redundant docs on the release process internally to see if we can dedupe and archive the old.


Mutiny is creating zombie thread on delayIt() which are not doing anything after certain time

We have retry mechanism in our application which waits for some time (2 seconds) and then do the retry.
If we use this in our application throughput is getting dropped to absolute zero after 2 -3 days, thread are going into unresponsive state.
Attached screenshots of our JVM dashboard.
Code block which we have in our mutiny pipeline is as below.
return
          Uni.combine().all().unis(delayUni, refreshedCredentialsUni)
              .asTuple()
              .onItem()
              .delayIt()
              .by(Duration.ofSeconds(Math.min(backOffDuration, getMaxBackoff())))
              .onItem()
              .transformToUni(r -> cspResponseUni)

I have found similar thread here --> https://github.com/smallrye/smallrye-mutiny/issues/786

Once we disable this delay, our throughput reduction problem is solved and we are not seeing this issue anymore.
But we need mechanism wherein the above code should work seam lessly.

Are you running in Quarkus? There were a leak in the Jboss scheduler used in Quarkus.
As a workaround, you could define your own executor to execute the delay (instead of using the default one).

@cescoffier
Yes, we are running in Quarkus.
Despite supplying an external thread pool we are still observing the same behavior.
engineExecutorService = Executors           .newFixedThreadPool(engineThreadPoolSize, new DefaultThreadFactory("worker"));
emitting on below thread pool
.emitOn(EngineThreadPool.getEngineExecutorService());

Ah no, sorry, not using emitOn, but onItem().delayIt().on(executor).by(..)

We haven't supplied an external pool in that pipeline.
Should we do that ?

@jponge do you know if the JBoss executor leak got fixed?

Hum @dmlloyd might know better

If you're referring to https://github.com/jbossas/jboss-threads/issues/139 then yes it was fixed.

Awesome! Thanks @dmlloyd !
Closing this issue.


Add bundle-release target and use it in release ci lane

Running hack/bump_versions.sh in the end of make bundle overrides
what is set by kustomize. This hurts the OLM lane since it
changes the bundle manifests to use local images.
Creating a separate target for release PRs solves this issue.

we can close this one now :) https://github.com/metallb/metallb-operator/pull/77 merged


dockerfile not using elixir:1.9

During setup following the steps in the readme, I encountered:
** (Mix) You're trying to run :pleroma on Elixir v1.8.2 but it has declared in its mix.exs file it supports only Elixir ~> 1.9
Changed dockerfile from elixir:1.8 to elixir:1.9, and it worked.

latest elixir even is 1.10
would update accordingly


[VS] Navigate To does not function as expected for guests due to missing backing implementation

Like #43, Visual Studio's "navigate to" feature relies on search capabilities not yet implemented.  Consequently it does not always find the expected files.  We need to round out the implementation.
Unfortunately, while this is a "feature level" amount of work the result of it feels like a bug when you try to use the base feature set. Originally marked as a bug, it is effectively a feature request

This feature has been implemented in the latest Live Share update for Visual Studio! Let us know if you run into any issues with and, and thanks again everyone for all the great feedback! 👍


Bump octoxlabs from 0.2.2 to 0.2.3 in /docker/octoxlabs

Status
Ready
Related Content Pull Request
This will be added after this image deployed to demisto docker hub organization.
Description
Update octoxlabs package to 0.2.2
Also details: https://github.com/octoxlabs/py-octoxlabs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ogulcan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add some advice when the user network connection is bad

closing in favor of https://github.com/mconf/bbb-mobile-sdk/issues/273


fix: Showing Warning on search #1487

Related Issue
Showing Warning on search
Closes #1487

Description
I have found corrupted images and fixed them.

Screenshots
https://github.com/JasonDsouza212/free-hit/assets/90599826/8e7d2cb5-e788-4c0b-9d9f-c2ce1e592184

Checklist

[X] My code adheres to the established style guidelines of the project.
[ ] I have included comments in areas that may be difficult to understand.
[X] My changes have not introduced any new warnings.
[X] I have conducted a self-review of my code.

@JasonDsouza212
Kindly merge it

@soubhik-111 I dont think this can solve the issue you have addressed

@JasonDsouza212
Hello,
It already solved the issue I addressed how?
The answer is Browser have few security restriction which shows for corrupt or high risk route.
Therefore I have changed the images of the five which are found rish by Google console.
Thank You

You have removed images of many tools can you add the images


[SPARK-21492][SQL][Follow Up] Reimplement UnsafeExternalRowSorter in database style iterator

What changes were proposed in this pull request?
Reimplement the iterator in UnsafeExternalRowSorter in database style. This can be done by reusing the RowIterator in our code base.
Why are the changes needed?
During the job in #26164, after involving a var isReleased in hasNext, there's possible that isReleased is false when calling hasNext, but it becomes true before calling next. A safer way is using database-style iterator: advanceNext and getRow.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT.

cc @cloud-fan

Test build #112547 has started for PR 26229 at commit 5623c7a.

Merged build finished. Test PASSed.

Test build #112547 has finished for PR 26229 at commit 5623c7a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112547/
Test PASSed.

Thanks Wenchen.


moved heirarchy keyspace name from constant to configuration

Hi @SaipradeepR, pls review and merge the req

Verify the name of the keyspace hierarchy.store.keyspace.name=dev_hierarchy_store


Fixes #49: Public Ip Address Not Set at Startup for Network Interface

This seems to be working for me.


feat: 模拟器新版本

解决滚动问题

Codecov Report
Base: 4.93% // Head: 4.93% // No change to project coverage :thumbsup:

Coverage data is based on head (8eadfbd) compared to base (7b6678c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #573   +/-   ##
======================================
  Coverage    4.93%   4.93%
======================================
  Files         153     153
  Lines        3138    3138
  Branches      801     801
======================================
  Hits          155     155
  Misses       2600    2600
  Partials      383     383

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Pydocstyle convention = "google" does not work as expected

Minimal reproduction:
pyproject.toml
[tool.ruff]
select = ["D"]

[tool.ruff.pydocstyle]
convention = "google"

testruff.py
def some_function(n):
    """Return some result.

    Args:
        n: Number.
    """

Running ruff testruff.py gives:
testruff.py:1:1: D100 Missing docstring in public module
testruff.py:2:5: D213 Multi-line docstring summary should start at the second line
testruff.py:2:5: D407 Missing dashed underline after section ("Args")
Found 3 error(s).
1 potentially fixable with the --fix option.

However, as specified in pydocstyle docs, D213 and D407 should not be checked for the Google docstring convention.

Yeah, this is known but not good. It's documented here. In short, we only use convention to help with some of the checks themselves, and not to configure which checks are enabled. For that, you have to go through select and ignore. (There are example, proper configurations present in the linked FAQ.)
I'll consider making convention automatically add the relevant checks to select. I wanted to keep select "pure" in this way but it might be too confusing as-is.

I'll play around with this now, maybe it'll turn out clean.

Apologies, I missed that section of the README. Thanks for pointing me to it.
Feel free to close this if you prefer to keep the current behaviour.

The current setup is confusing enough that I'm slightly embarrassed by it, which is a sign that I should probably fix it 😅
I'll use this issue to track the work, if that's okay.

@charliermarsh Thanks for the quick solution here! I have one comment on the approach you implemented:
Could it be more intuitive if the convention = "google" actually populates the ignore list rather than the select list? Before your change, my settings looked like this:
[tool.ruff]
select = [
    "D",  # pydocstyle
]
ignore = [
    # Google docstring convention
    "D203", "D204", "D213", "D215",
    "D400", "D404", "D406", "D407", "D408", "D409", "D413",
    # Docstrings not required
    "D100", "D101", "D102", "D103", "D104", "D105", "D106", "D107"
]

[tool.ruff.pydocstyle]
convention = "google"

My thinking was that by adding select = ["D"], I 'enable' pydocstyle. And then by specifying the convention, I configure it to behave the way I want.
Now my settings look like this:
[tool.ruff]
select = []
ignore = [
    # Docstrings not required
    "D100", "D101", "D102", "D103", "D104", "D105", "D106", "D107"
]

[tool.ruff.pydocstyle]
convention = "google"

This feels weird, because it is not clear that I ever 'enabled' pydocstyle, but I am ignoring error codes for it and configuring it. By making the configuration populate the ignore list, I could have a settings file that makes sense to my way of thinking:
[tool.ruff]
select = [
    "D",  # pydocstyle
]
ignore = [
    # Docstrings not required
    "D100", "D101", "D102", "D103", "D104", "D105", "D106", "D107"
]

[tool.ruff.pydocstyle]
convention = "google"

Curious to hear your thoughts about this!

And another note: the VSCode extension now no longer underlines docstrings, even if they would raise an error code.

Yeah I think what you're describing makes sense. I can make that change.

And another note: the VSCode extension now no longer underlines docstrings, even if they would raise an error code.

Is it possible that you're using the bundled version of the extension, which hasn't yet been updated?

And another note: the VSCode extension now no longer underlines docstrings, even if they would raise an error code.

Is it possible that you're using the bundled version of the extension, which hasn't yet been updated?

Oh yeah that's probably it!

I'll cut a new pre-release in a bit :)
You can also point the extension to an interpreter or hard-code the path to the Ruff binary in the extension settings.

Hello, I understand that this change may be seen as an improvement over the previous behavior, but the current behavior is still lacking imo. Starting with this
[tool.ruff]
select = [
    "D",  # pydocstyle
]
ignore = [
    # Docstrings not required
    "D1"
]

[tool.ruff.pydocstyle]
convention = "google"

It will turn off all rules not part of the Google convention, including rules that are still compatible. How could one get all rules except the ones in conflict with the convention, i.e. to maximize the number of checks whilst being in line with the convention? It forces us to abandon the convention config altogether, as it leaves no way for us to turn on compatible-but-not-included rules. I like the explicitness of setting "convention = X" rather than a bunch of D codes, but it seems that can only be had if you are not interested in rules in addition to the convention at the moment.


Generate browser guide from AsciiDoc

@jexp @JMHReif should we take some time to review this together? it's been open for a while


updates per machine docs pr#3799

@nathanleclaire @ mrburrito please review these changes to AWS driver docs, same as on Update AWS Credentials lookup to use AWS default provider chain.
@nathanleclaire can these changes be published on docs site, or do we have to wait for future release with regard to any driver code changes?
Signed-off-by: Victoria Bialas<EMAIL_ADDRESS>

closing, dev already submitted https://github.com/docker/docker.github.io/pull/37

Should I ask them to take the changes out of the Machine PR?

@nathanleclaire I think they already did. We duplicated the PRs to github.io, so I closed mine (this one) and didn't merge it. The new dev-created PRs are merged already to github.io (see https://github.com/docker/docker.github.io/pull/37 and https://github.com/docker/docker.github.io/pull/36) and up on docs.docker.com: https://docs.docker.com/machine/drivers/aws/
I think it's all good, unless you still see these same docs updates on the Machine repo in an open PR, then yes you can remove them, but I believe we are about to scrub that docs repo and replace it with a README if we haven't done so already.
Ping @johndmulhausen , are you about to also nuke: https://github.com/docker/machine/tree/master/docs and leave the README there?
For now, I think we could manage that single docs/reference/ folder over on https://github.com/docker/docker.github.io/tree/master/machine until we have automated CLI docs generation.

@nathanleclaire @londoncalling Yes, I have this PR to do the nuking: https://github.com/docker/machine/pull/3804

@nathanleclaire do you want me to remove the docs changes from the machine PR? I figured I'd leave them in until docs were completely migrated to the common location.


Add front/back culling toggling to rlgl.h

This enables a few techniques such as rendering inverted hull outlines with more simplicity.

@GithubPrankster I'm afraid I'm not adding those functions, anyone requiring them can use OpenGL calls directly.


Add standard npm start script + rm unnecessary make step

make setup (i.e. make) in the dev tutorial seems an unnecessary step. When I open try.html without running that first, badges load from my local server.

Without this, npm start runs node server.js, which starts the server on port 80 on all interfaces. That won't work in my dev setup. For that matter, it won't work for most people's dev setup. Before making this change, though, we should make sure npm start is not being used on the server.


Indent in code in numeric list

Code within numeric list lost indent. Example (working fine, here on github):
Indent in code:
int main() {
    // ...

Indent in code in numeric list:

int main() {
    // ...

Parsedown:

Duplicate of #466

I'll take another look into this issue soon—I think it might be slightly easier to solve this as part of the 2.0 update. One problem I can see related to performance is that it requires checking whether each line begins a block (of sufficient precedence) so as to decide whether to strip the indent, this can probably be optimised to a marker search in most cases. Precedence rules around this may be more complicated to solve in the general case, but I'll take a look.

Closing and tracking underlying issue directly: https://github.com/erusev/parsedown/issues/707


bug: Inaccurate documentation for param reloadOnDisconnect of CoinbaseWalletConnector

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.10.10
Current Behavior
When using CoinbaseWalletConnector the documentation says reloadOnDisconnect defaults to true, however it seems to default to false

The issue seems to come from the type Options that is a union with CoinbaseWalletSDKOptions, which do indeed default reloadOnDisconnect to true
Expected Behavior
The documentation in question matches the implementation.
Steps To Reproduce

Start a new project with wagmi
Instantiate a CoinbaseWalletConnector in a code editor that supports documentations

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

Thanks! Fixed at https://github.com/wagmi-dev/references/commit/e607ee27a27c826e998f9634a33a14cdeeca07c3


Environment/connection of each tab cannot be distinguished (despite connection color)

DBeaver allows each connection to have a type (defined in the General settings), and each connection type to have a color. This allows associating a color to any connection, to easily and quickly distinguish several connections (see ticket #7271 for a screenshot).
While the current implementation prevents sending a request to the wrong environment, it could be even more useful if it allowed quickly identifying which editor/console the user wants to go to. For example, I can have 2 editors both on the "group" table open at the same time, but in different environments. Currently, both just have the name "group", and they both have the same text and background colors, so to determine which one is on the environment I want, I would have to know the tab's position by heart, check the tooltip, or try until I get to the right one.
It would be a lot more efficient if the tab (itself) conveyed its associated connection through color - whether that is using the connection type's color as the tab's background color or otherwise.
This issue applies to DBeaver 6.3.4.

thanks for suggestion

I would also love to see the background colour of the tabs match the connection type colour of the rest of the tab (when connection type colours are used). It would make it much easier to see at a glance which tabs are connected to which databases.

will be implemented in #15760


mud deploy fails if there is no system

deployer expects the System.json abi to be available in the forge output, but it's only if it is referenced somewhere in the project

fails here: https://github.com/latticexyz/mud/blob/712866f5fb392a4e39b59cd4565da61adc3c005f/packages/cli/src/deploy/resolveConfig.ts#L40

no longer an issue after reworking system deploys for multi-namespace support


Simultaneously upload gnomAD v4.0.0 wgs and wes file

Helllo, I want to use combined values in gnomAD v4.0.0 (wgs & wes) file.
Is there any method for doing this ?

Hello @heomanism,
Thank you for your question.
You can download both WGS and WES and query them together and concatenate the output.
Something like:
database_location_WGS = "database_location_WGS"
database_location_WES = "database_location_WGS"
db_WGS = gnomAD_DB(database_location_WGS, gnomad_version="v4")
db_WES = gnomAD_DB(database_location_WES, gnomad_version="v4")

res_WGS = db_WGS.get_info_from_str("21:9825790:C>T", "AF")
res_WES = db_WES.get_info_from_str("21:9825790:C>T", "AF")

pandas.merge([res_WGS, res_WES]) # please adjust this, probably you would have to rename values

Thank you for quick answer :)
However, I want values the sum of the WGS and WES results, like the Total column in this image!
If not available, I will calculate it based on your code for each value :)

You'll need to calculate it on your own. Thank you for the question, and please don't hesitate to reopen or raise new issues if you have more questions.

Hello, I try to calculate allele frequency in each ancestry using WGS + WES data.
But, I need allele number of each ancestry, but gnomAD_DB give me only allle frequency(AF) of each ancestry only.


Creation of Events Page | Showing Events of GDG on Campus RCCIIT

@rishicds please assign this to me.

assigned @Shariq2003

Thanks for assigning, will try my best to deliver asap

@rishicds please review my PR and also assign Issue #25 and #26 to me


Clair CI improvements

Due the disk space limitation of GH runners, I was unable to update clair workflow in the same way as clamav workflow. It works with docker but thee is not enough space for buildah builds, I also cannot rearrange order of steps as I did in clamAV.
https://github.com/redhat-appstudio/hacbs-test/pull/62


Improve TemporalNullValueAnalyzer to be more customizable

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7f4aeb8) to head (d76db8a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #409   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           96        96
  Lines         2445      2452    +7
  Branches       217       219    +2
=========================================
+ Hits          2445      2452    +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add statistics to gateway

Statistics about incoming and outgoing payments wikk help the operators to manage liquidity.

New gateway-cli command would be a nice first step

@elsirion is anyone hacking at this yet? would love to give it a shot (first time contributor🙂)

Go for it! Feel free to ask questions here or in discord if you have any.

Closing as a duplicate of #2624 which is more detailed.


Fix for "_pywhispercpp module could not be found" didn't fix module could not be found.

Original issue: https://github.com/abdeladim-s/pywhispercpp/issues/34
I'm having the same issue when using pip install pywhispercpp despite it successfully installing. Seems like something is broken on windows still.
DLL load failed while importing _pywhispercpp: The specified module could not be found.
  File "C:\Users\user\Desktop\faster-whisper\main.py", line 1, in <module>
    from pywhispercpp.model import Model
ImportError: DLL load failed while importing _pywhispercpp: The specified module could not be found.```

Any advice would be helpful. I tried adding the whisper.dll as advised in issue 34, it didn't fix it. Reinstalled the package, same issue.

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

@UsernamesLame,
I don't have access to a Windows Machine to do some tests but based on #34, if you put the whisper.dll file in site-packages and used this script it should work basically!
If not, could you please use this method to check which DLL file is missing!

@abdeladim-s I tried all the solutions, none of them worked. So I tried reinstalling the package, and now it doesn't even register with Pyhon that it exists. So I tried a venv, and again Python doesn't recognize whispercpp as a package.

@abdeladim-s I tried adding the DLL, same issue. Is there a particular reason pywhispercpp doesn't auto build / come with whisper.dll?

Ok, so I miss-read what was written and put the DLL in pywhispercpp's folder, it works in site-packages
However, this is a ABSOLUTELY DISGUSTING FIX so being the Python developer I am, I wrote a equally disgusting fix.
from pathlib import Path
from zipfile import ZipFile
from io import BytesIO
import pywhispercpp

whisperdll_zip = BytesIO()

whisperdll_zip.write(urlopen("https://github.com/ggerganov/whisper.cpp/releases/download/v1.5.4/win32-x86-64_whisper.dll.zip").read())
whisperdll_zip.seek(0)

with ZipFile(whisperdll_zip) as whisper:

    with open(Path(pywhispercpp.__path__[0]).absolute().with_name("whisper.dll"), "wb") as file:
        file.write(whisper.read("whisper.dll"))```

Auto installs it to site-packages. And in the event you do want to include this as a helper script, I'm licensing it also under the MIT license. It's my way of saying thanks for developing pywhispercpp :)

Replace the URL in whisperdll_zip with https://github.com/ggerganov/whisper.cpp/releases/download/v1.6.0/win32-x86-64_whisper.dll.zip for the latest DLL that is much more optimized.

@abdeladim-s I tried adding the DLL, same issue. Is there a particular reason pywhispercpp doesn't auto build / come with whisper.dll?

@UsernamesLame, There was a change in the repo a while ago to build the bindings against the whisper.cpp as a target library, and so in the build process it does not copy the generated .dll file to the wheel. I tried to fix this for linux and it seems to be working, but for Windows it didn't work, I need to have access to a Windows machine to do some debuging!

Ok, so I miss-read what was written and put the DLL in pywhispercpp's folder, it works in site-packages
However, this is a ABSOLUTELY DISGUSTING FIX so being the Python developer I am, I wrote a EQUALLY DISGUSTING fix.
from urllib.request import urlopen
from pathlib import Path
from zipfile import ZipFile
from io import BytesIO
import pywhispercpp

whisperdll_zip = BytesIO()

whisperdll_zip.write(urlopen("https://github.com/ggerganov/whisper.cpp/releases/download/v1.5.4/win32-x86-64_whisper.dll.zip").read())
whisperdll_zip.seek(0)

with ZipFile(whisperdll_zip) as whisper:

    with open(Path(pywhispercpp.__path__[0]).absolute().with_name("whisper.dll"), "wb") as file:
        file.write(whisper.read("whisper.dll"))

This auto installs it to site-packages. And in the event you do want to include this as a helper script, I'm licensing it also under the MIT license. It's my way of saying thanks for developing pywhispercpp :)

Thank you very much for taking the time to write the fix, it's not disgusting at all :sweat_smile:
But, we need to find a way to include the dll -against which the package was built- with the wheel.
Let's keep this issue open, others will find the script useful for sure, at least until a good fix is pushed.

I'm glad you like the script. I guess I'm a contributor now 😅
It's almost midnight here (Canada) so I'm going to sleep but I did fork the repo.
I haven't worked with PD11, but I'll try and get up to speed tomorrow and submit a few pull requests.
I'm not going to lie, I'm not the best with git so please be patient when I do pull requests.
I want to help clean up this library a bit and simplify the windows experience.
Unrelated:
I also was wondering about professing multiple files in a row and if I need to re-initialize whisper or if I can reuse the in memory model without carrying contexts between files.
Sorta like serial transcribing without tainting different files from different contexts.
Any ideas on that front?
Anyways, goodnight for now. Looking forward to making some pull requests.

Of course, please go ahead, PRs are always welcome! 😄
And don't worry about git, just make sure to wrap the related changes in their specific commit so we can easily review them together.

By the way, if you succeeded in building the project from the source, could you please pull the latest commit and give it a try?
I believe I found the issue with the missing DLL and pushed a small fix. If you could also build the wheel and check if the whisper.dll file is included in the pywhispercpp/lib folder, that would be awesome!

Regarding your question:
I'm not entirely sure what you mean, but if I understand correctly, yes you can process multiple files in a row with the same model in memory, because, as far as I know, there's no concept of context here -unlike with LLMs, for example-.
However, I might be wrong, so if you run some tests and find anything related to this, please share it with me!

Of course, please go ahead, PRs are always welcome! 😄 And don't worry about git, just make sure to wrap the related changes in their specific commit so we can easily review them together.
By the way, if you succeeded in building the project from the source, could you please pull the latest commit and give it a try? I believe I found the issue with the missing DLL and pushed a small fix. If you could also build the wheel and check if the whisper.dll file is included in the pywhispercpp/lib folder, that would be awesome!
Regarding your question:
I'm not entirely sure what you mean, but if I understand correctly, yes you can process multiple files in a row with the same model in memory, because, as far as I know, there's no concept of context here -unlike with LLMs, for example-. However, I might be wrong, so if you run some tests and find anything related to this, please share it with me!

I tried to install from wheel and source, from wheel thelib folder isn't created. From source it's created, but doesn't contain whisper.dll
Also to build from source, you must have all the MSVC tools installed. I only had the compiler and it refused to build. Just a heads up on that.

Reading through d452d8b, I have a feeling  dll_files = os.path.join(self.build_temp, 'bin', 'Release', '*.dll') is the offending line.
Shouldn't it be Release then bin? Let me check how it built on my computer. I'm really not a C++ person so this is like speaking french to me, and I'm not a Québécois.

Of course, please go ahead, PRs are always welcome! 😄 And don't worry about git, just make sure to wrap the related changes in their specific commit so we can easily review them together.
By the way, if you succeeded in building the project from the source, could you please pull the latest commit and give it a try? I believe I found the issue with the missing DLL and pushed a small fix. If you could also build the wheel and check if the whisper.dll file is included in the pywhispercpp/lib folder, that would be awesome!
Regarding your question:
I'm not entirely sure what you mean, but if I understand correctly, yes you can process multiple files in a row with the same model in memory, because, as far as I know, there's no concept of context here -unlike with LLMs, for example-. However, I might be wrong, so if you run some tests and find anything related to this, please share it with me!

I tried to install from wheel and source, from wheel thelib folder isn't created. From source it's created, but doesn't contain whisper.dll
Also to build from source, you must have all the MSVC tools installed. I only had the compiler and it refused to build. Just a heads up on that.

Yes, you'll need MVS to compile the project, but no worries.
I set up a VM yesterday to debug it, and here is the resulting wheel: wheel.zip.
Give it a try! Extract the zip, install it in a virtual environment, and check if it works.

Reading through d452d8b, I have a feeling  dll_files = os.path.join(self.build_temp, 'bin', 'Release', '*.dll') is the offending line.
Shouldn't it be Release then bin? Let me check how it built on my computer. I'm really not a C++ person so this is like speaking french to me, and I'm not a Québécois.
Edit:
I think my blind stab in the dark hit the mark!
\pywhispercpp\build\temp.win-amd64-cpython-312\Release\_pywhispercpp\bin\Release
So it should be
dll_files = os.path.join(self.build_temp, 'Release', '_pywhispercpp', 'bin', 'Release', '*.dll')
if I am right. Let me quickly patch my local copy.
Edit:
Patch didn't work. Let me actually read setup.py fully before patching it.
Edit 2:
Somewhere along the way we're losing the temp build directory / getting the wrong directory, I'm not sure why or how. Like, it is building the DLL but then failing to copy it.
Edit 3:
So this is definitely outside of my comfort zone, but I can tell you that whisper.dll needs to be copied to pywhispercpp/lib now instead of site packages breaking my old script.

It's okay, Thanks for the time you put into this. I believe the folder is correct, at least based on yesterday's debugging.
I think your script will still work if someone installs the library from PyPI. Until the next release, the whisper.dll should go into the lib folder so it will be loaded at runtime.

Thank you for the kind words. Let me try that new wheel you made and report back!

Update on the wheel:
ERROR: pywhispercpp-1.2.0-cp311-cp311-win_amd64.whl is not a supported wheel on this platform.
That's odd.

I tried cloning from git and installing the latest build.
Could not find module 'c:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\pywhispercpp\lib\_pywhispercpp.cp312-win_amd64.pyd' (or one of its dependencies). Try using the full path with constructor syntax.
  File "C:\Users\Felix\Desktop\faster-whisper\main.py", line 1, in <module>
    from pywhispercpp.model import Model
FileNotFoundError: Could not find module 'c:\Users\Felix\AppData\Local\Programs\Python\Python312\Lib\site-packages\pywhispercpp\lib\_pywhispercpp.cp312-win_amd64.pyd' (or one of its dependencies). Try using the full path with constructor syntax.```

Seems like the windows install *is extremely finicky*

Update on the wheel:
ERROR: pywhispercpp-1.2.0-cp311-cp311-win_amd64.whl is not a supported wheel on this platform.
That's odd.

I think because you are using Python 3.12, The wheel is built with Python 3.11

I tried cloning from git and installing the latest build.
Could not find module 'c:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\pywhispercpp\lib\_pywhispercpp.cp312-win_amd64.pyd' (or one of its dependencies). Try using the full path with constructor syntax.
  File "C:\Users\Felix\Desktop\faster-whisper\main.py", line 1, in <module>
    from pywhispercpp.model import Model
FileNotFoundError: Could not find module 'c:\Users\Felix\AppData\Local\Programs\Python\Python312\Lib\site-packages\pywhispercpp\lib\_pywhispercpp.cp312-win_amd64.pyd' (or one of its dependencies). Try using the full path with constructor syntax.

Seems like the windows install is extremely finicky

Always Windows like this :sweat_smile:

I think it's the famous whisper.dll file as usual.
However, pulling the latest changes should resolve it basically.
The GitHub action for windows completed successfully as well, and here is the resulting wheel for Python 3.12.wheel.zip

I tried cloning from git and installing the latest build.
Could not find module 'c:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\pywhispercpp\lib\_pywhispercpp.cp312-win_amd64.pyd' (or one of its dependencies). Try using the full path with constructor syntax.
  File "C:\Users\Felix\Desktop\faster-whisper\main.py", line 1, in <module>
    from pywhispercpp.model import Model
FileNotFoundError: Could not find module 'c:\Users\Felix\AppData\Local\Programs\Python\Python312\Lib\site-packages\pywhispercpp\lib\_pywhispercpp.cp312-win_amd64.pyd' (or one of its dependencies). Try using the full path with constructor syntax.

Seems like the windows install is extremely finicky

Always Windows like this 😅
I think it's the famous whisper.dll file as usual. However, pulling the latest changes should resolve it basically. The GitHub action for windows completed successfully as well, and here is the resulting wheel for Python 3.12.wheel.zip

Hell froze! IT JUST WORKED ON WINDOWS AFTER A REINSTALL FROM PIP!
I guess we can close this issue?

Nice :+1:
The wheel I provided worked ? Or the wheel from PyPI ?
If you have a gpu accelerator, can you test if it's working ? the wheel I provided is compiled with Vulkan!

Nice :+1:
The wheel I provided worked ? Or the wheel from PyPI ?
If you have a gpu accelerator, can you test if it's working ? the wheel I provided is compiled with Vulkan!

The wheel from PyPi. I tried it first. I was shocked how it instantly worked 😂

It's probably because whisper.dll is still somewhere in your environment :sweat_smile:

It's probably because whisper.dll is still somewhere in your environment 😅

I made sure to delete it before re-installing! it's finally working!

that's wierd! It shouldn't be working, because I didn't push any new version to PyPI yet :sweat_smile:

It's probably because whisper.dll is still somewhere in your environment 😅

I made sure to delete it before re-installing! it's finally working!

that's wierd! It shouldn't be working, because I didn't push any new version to PyPI yet 😅

Something you changed in one of the recent updates fixed it! Anyways, I guess we can close this one.

Yes maybe. That's a good thing anyways :)


Remove PersistentState/ and PersistentVariable<>

After a proper implementation of the persistent Variables in #307 I forgot to remove the two previous attempts. This PR takes care of that.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.08%. Comparing base (df0aa2e) to head (1ab6c14).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   93.84%   94.08%   +0.23%
==========================================
  Files          38       36       -2
  Lines        1008      947      -61
  Branches       18       15       -3
==========================================
- Hits          946      891      -55
+ Misses         62       56       -6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.