Generating (Python) API documentation with govuk-eleventy-plugin

Hi 👋 ,
Firstly, thanks for a great plugin - it's been really useful for a few projects, e.g. https://pg-bulk-ingest.docs.trade.gov.uk/ and https://stream-unzip.docs.trade.gov.uk/
One thing though that I'm not quite sure how to do is integrating govuk-eleventy-plugin / 11ty with some sort of system for generating API documentation from source code, and specifically for Python, say using https://github.com/pdoc3/pdoc.
I wonder if anyone has any tips/suggestions on how to tackle this?
Thanks!
Michal

So have the seeds of a solution using https://github.com/NiklasRosenstein/pydoc-markdown, which can be called as a process and outputs to stdout to cross the Javascript/Python boundary
So in eleventy.config.js can have something like this:
const util = require('util');
const execFile = util.promisify(require('child_process').execFile);
eleventyConfig.addGlobalData("api", async () => {
    const { stdout, stderr } = await execFile('pydoc-markdown', ['-p', 'stream_unzip'])
    return stdout;
});

And this then makes api available in content files, just as {{ api }}.
And if more customisation is needed, pydoc-markdown offers more "raw" JSON output:
eleventyConfig.addGlobalData("api", async () => {
    const { stdout, stderr } = await execFile('pydoc-markdown',  ['-p', 'stream_zip', '--dump'])
    return JSON.parse(stdout)
});

And then can be used in content files more manually
{%- for member in api["members"] -%}
{{ member["name"] }}

{%- endfor -%}


Fix Carousel on Web to match Native experience

The Carousel component on web doesn't swipe and the image ratio is off

[ ] image ratios seem to be broken. it's a square on ios (and presumably android) but a long rectangle on web. the ratio should work the same way on web as it does local
[ ] swiping doesn't work on web

carousel on web:

carousel on ios:

possible solutions

react-native-gesture-handler: check out the SwipeableTable example located here:

The file on expo is:

here's how to get to the example on your phone (after scanning QR code):

swiping works correctly and we would just need to copy over their Swipeable and pass in the right props to the carousel component

fix the ScrollView swiping. This one feels a little trickier. Since it's implemented already, maybe there's a hack somewhere or we're missing somethign?

I can't see how we can use the Swipeable component to fix the carousel. Check https://docs.swmansion.com/react-native-gesture-handler/docs/component-swipeable/, swipeable is only used to add action buttons to swipeable components, how would we use this to replace swiping of scroll view.

As for the aspect ratio issue, it was caused because default height was hard-coded to 250, which looked weird when put on a very wide screen (web browser). I changed it to a value more dependent on the screen size.

@YoussefHenna thanks for letting me know!
height: that makes sense, but lets keep it 250 cause we only support mobile web right now (so maybe it should be wrapped in an aspect ratio instead?), otherwise lets make it 275 and see what it looks like
component-swipeable: ohh i see what you mean, woops! i think the way you did it is great, thanks!!


feat!: throw an error, if module cannot be resolved

Previously, if we could not resolve the path we just passed it down to server.transformRequest in hopes that it would work. However, this is not how it actually works in Vite - the frontend part will throw an error if the path is not resolvable during the transform phase.
This leads to several issues:

People expect that Vitest takes tsconfig.json into account, but it doesn't (src/file is not resolved into <root>/src/file.ts, we just pass it down without an importer to server.transformRequest and it is resolved relative to root by accident)
Coverage receives unresolved URL (<root>/src/file is not a valid path, it doesn't have an extension)
This creates duplicate entries in the module graph for the same module (it's possible to have both <root>/src/file.ts and src/file in the module graph)

This PR now throws an error, if the module cannot be resolved. This doesn't affect modules that were mocked by vi.mock (even if they are not installed).

@antfu Nuxt will fail if it doesn't return anything.

Hello, our project uses Vitest and this change is making our tests break. We've just recently started using this amazing library for unit testing and we're using the Sveltekit framework. If someone is going through something similar, help would be much appreciated 😄
Here are the logs, we've tried installing vite-tsconfig-paths but that didn't seem to work either.
⎯⎯⎯⎯⎯⎯ Failed Suites 2 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  src/lib/server/utils/activity.utils.spec.ts [ src/lib/server/utils/activity.utils.spec.ts ]
Error: Cannot find module '__sveltekit/paths'.

- If you rely on tsconfig.json to resolve modules, please install "vite-tsconfig-paths" plugin to handle module resolution.
 - Make sure you don't have relative aliases in your Vitest config. Use absolute paths instead. Read more: https://vitest.dev/guide/common-errors
 ❯ node_modules/.pnpm/@sveltejs+kit@1.20.1_svelte@3.55.1_vite@4.1.4/node_modules/@sveltejs/kit/src/runtime/client/utils.js:5:31
      3| import { assets } from '__sveltekit/paths';
      4| import { version } from '__sveltekit/environment';
      5| import { PRELOAD_PRIORITIES } from './constants.js';
       |                               ^
 Test Files  2 failed | 1 passed (3)
      6|
      7| /* global __SVELTEKIT_APP_VERSION_FILE__, __SVELTEKIT_APP_VERSION_POLL…
 ❯ node_modules/.pnpm/@sveltejs+kit@1.20.1_svelte@3.55.1_vite@4.1.4/node_modules/@sveltejs/kit/src/runtime/client/singletons.js:3:31

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: {
  "code": "ERR_MODULE_NOT_FOUND",
}
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯

 FAIL  src/lib/trpc/routers/certificate/createCertificate.spec.ts [ src/lib/trpc/routers/certificate/createCertificate.spec.ts ]
Error: Cannot find module '$env/dynamic/private'.

- If you rely on tsconfig.json to resolve modules, please install "vite-tsconfig-paths" plugin to handle module resolution.
 - Make sure you don't have relative aliases in your Vitest config. Use absolute paths instead. Read more: https://vitest.dev/guide/common-errors
 ❯ src/lib/server/singletons.ts:1:31
      1| import { env } from '$env/dynamic/private';
       |                               ^
      2| import { PrismaClient } from '@prisma/client';
      3| import { Configuration, SMTPApi } from './adapters/sendinblue/apiclien…
 ❯ src/lib/trpc/routers/certificate/createCertificate.ts:3:31

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: {
  "code": "ERR_MODULE_NOT_FOUND",
}
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/2]⎯

      Tests  2 passed (2)
   Start at  19:54:24
   Duration  3.22s (transform 404ms, setup 0ms, collect 633ms, tests 16ms, environment 535ms, prepare 3[27]

 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

@fell-lucas please, provide a separate reproduction


COM-388 (Add popover)

Please delete checklist items and sections that are not relevant
Checklist

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Please check if the PR fulfills these requirements

[x] Tests for the changes have been added (for bug fixes / features)
[x] Storybook or docs have been added / updated (for bug fixes / features)

COM-388
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Storybook Link

As per the comment in https://github.com/cmpsr/composer/pull/872#issuecomment-1852270974. This PR will be closed


Make sure DLUT.RAM is emitted if using LUT-RAMs.

Trying out suggested fix for #1625

A200T vendor is green this go around. I'm gonna re-run, but this might fix #1625 for now?


installing mxnet for python  in windows.

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
Operating System:
windows 10
Compiler:
The package used (Python/R/Scala/Julia):
python
MXNet version:
is it not possible to install mxnet using python in windows 10 OS for CPU?
Or if installed from source:
MXNet commit hash (git rev-parse HEAD):
If you are using python package, please provide
Python version and distribution:
If you are using R package, please provide
R sessionInfo():
Error Message:
Please paste the full error message, including stack trace.
Minimum reproducible example
if you are using your own code, please provide a short script that reproduces the error.
Steps to reproduce
or if you are running standard examples, please provide the commands you have run that lead to the error.

What have you tried to solve it?

have you try to use this https://github.com/yajiedesign/mxnet/releases ?

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.


Python Dropout op will not return directly when keep_prob =1

Python Dropout op uses the following code to check keep_prob value:
if tensor_util.constant_value(keep_prob) == 1:   return x
If keep_prob is placeholder,  tensor_util.constant_value(keep_prob) will return None,  if statement will always be false.
In python/ops/nn_test.py
When test keep_prob value (testDropoutPlaceholderKeepProb), it only test keep_prob in [0.1, 0.5, 0.8],
We should add the case of keep_prob = 1.0 test.

@ppwwyyxx , should this be fixed or not? Thanks.

I don't because I didn't see a bug. The behavior given a placeholder is correct.

If the value of keep_prob placeholder is 1, dropout should return directly. But the current code will not.
For inference, it is reasonable to set keep_prob to 1 to skip dropout op. The current code cannot skip dropout.

Nagging Assignee @tatatodd: It has been 17 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 32 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


zombie on creating looper

Hi Micah,
Great project - love it. Looking at some Rust projects myself (previously done audio in C/C++) and found your Loopers-jack code.
Playing around with it now - getting some "zombified" messages from JACK when adding a looper instance. Is this expected?
I have lots of experience with message-passing and C/C++ audio app design, could provide some input/design ideas for implementing "real-time-safe" looper additions, however I thought better to ask first if this is a known issue, and perhaps you've thought of a good way to solve it too??
Side note, I might try getting this ported to LV2 for use on the MOD Devices effects box; https://moddevices.com/
Great work, looking forward to messing with it a bit more. -Harry

Thanks for taking a look! Can you try again with the latest master? Before 306c03660494ffd522e37c267470432437dc1ab5, jack ports were incorrectly being registered on the audio thread when a new looper was created.

Hi Micah!
Just re-tested and its working fine now. Strange thing is, I didn't even rebuild Loopers! (I had previously tested git-master already). I had only just re-installed the OS here, and setup JACK stuff, so with a reboot inbetween perhaps there were some RT permission issues with getting Jackd working... so apologies for the noise here, I can't reproduce this, so will mark as closed.
Haven't got to using Loopers yet with real instruments, but will provide feedback when I have. Regards, -Harry


Just return early when forEach* method is called and the Buffer is no…

…t readable / writable
Motivation:
We should just return when there is nothing to read or write and not throw when forEach* methods are called.
Modifications:

Add early returns
Add unit tests

Result:
More consistent and less surpising behaviour

@normanmaurer I'm working on porting SslHandler to buffer, and it uses empty buffers a lot when doing handshakes. It turns out it would be convenient for it, if the callbacks always fired, but got empty/zero-capacity buffers. The existing SSLEngines already understands the meaning of such buffers.
What do you think? Would that be reasonable alternative behaviour?

I guess that could be fine as well ...

I had a go at that, but it turns out to be pretty weird behaviour for composite buffers. Let's keep it as is for now, and I'll think of something else for SslHandler.


Custom styles example?

Can someone point me to how can custom styles be applied? I'm using Tailwind.
I'm extending the form as per docs but I can't figure out how to add the className to the element
 multilineComponent={"select"} /* your custom Multiline */

Thank you!

Hey @netdesignr , we use Tailwind and love it too. The docs are indeed lacking a little bit on that section, so I'll leave an example here of a form I customized for a particular project, I hope it helps:
import * as React from 'react'
import type { FormProps } from 'remix-forms'
import { Form } from 'remix-forms'
import type { SomeZodObject } from 'zod'
import Button from '~/components/button'
import { cx } from '~/framework/common'

function RemixForm<Schema extends SomeZodObject>(props: FormProps<Schema>) {
  return (
    <Form<Schema>
      fieldComponent={(props) => (
        <div
          {...props}
          className={cx(
            'flex flex-col text-left focus-within:text-blush',
            props.className,
          )}
        />
      )}
      labelComponent={(props) => (
        <label
          {...props}
          className={cx('mb-1 px-3 text-sm text-current', props.className)}
        />
      )}
      inputComponent={React.forwardRef<
        HTMLInputElement,
        JSX.IntrinsicElements['input']
      >(({ type = 'text', ...props }, ref) => (
        <input
          ref={ref}
          type={type}
          {...props}
          className={cx(
            'rounded border-gray-light px-3 py-4 transition-all focus:border-blush focus:ring-blush',
            props.className,
          )}
        />
      ))}
      multilineComponent={React.forwardRef<
        HTMLTextAreaElement,
        JSX.IntrinsicElements['textarea']
      >((props, ref) => (
        <textarea
          ref={ref}
          {...props}
          className={cx(
            'rounded border-gray-light px-3 py-4 transition-all focus:border-blush focus:ring-blush',
            props.className,
          )}
        />
      ))}
      selectComponent={React.forwardRef<
        HTMLSelectElement,
        JSX.IntrinsicElements['select']
      >((props, ref) => (
        <select
          ref={ref}
          {...props}
          className={cx(
            'rounded border-gray-light px-3 py-4 transition-all focus:border-blush focus:ring-blush',
            props.className,
          )}
        />
      ))}
      buttonComponent={(props) => (
        <Button
          variant="primary"
          size="lg"
          contained
          type="submit"
          {...props}
        />
      )}
      fieldErrorsComponent={(props) => (
        <small
          {...props}
          className={cx('mt-1 px-3 text-salmon', props.className)}
        />
      )}
      globalErrorsComponent={(props) => (
        <small
          {...props}
          className={cx('mt-1 px-3 text-salmon', props.className)}
        />
      )}
      errorComponent={(props) => (
        <span
          {...props}
          className={cx('text-xs font-semibold text-current', props.className)}
        />
      )}
      renderField={({ Field, ...props }) => {
        const { label, required, errors } = props
        return (
          <Field {...props}>
            {({ Label, SmartInput, Errors }) => (
              <>
                <Label className={cx(errors && '!text-salmon')}>
                  {label}
                  {required && ' *'}
                </Label>
                <SmartInput
                  className={cx(errors && '!border-salmon !text-salmon')}
                />
                <Errors />
              </>
            )}
          </Field>
        )
      }}
      {...props}
    />
  )
}

export default RemixForm

Hi @gustavoguichard, this is exactly what I was looking for! I tried everything but did think it takes a function with the props :)

Is this library open for contributions? I could submit a more up to date documentation

Hey, @netdesignr! Thank you for creating this issue and for offering to contribute with documentation! We appreciate it a lot :muscle: :pray:
I just added an example to our Get Started page. Do you think this example would have helped you learn the API?

Hi @danielweinmann, I think that should have just helped me. I was looking around for some source where you've used it but didn't realise it was hidden inside the remix-forms-site repo. Having said that, it would have been better if at least one example existed directly on Get started page so you won't necessarily have to go away from the docs.

Awesome! That's great feedback :D
I'm going to leave this issue open until we have a better solution. Feel free to send a PR to remix-forms-site if you have an idea about how to make this clearer. Thank you!

Closing this because people seem to be learning how to create their components with the current solution. We'll open a new one when the time comes to make it better.


Fixed typographical error, changed architechture to architecture in README.

@ninjudd, I've corrected a typographical error in the documentation of the memcache project. You should be able to merge this pull request automatically. However, if this was intentional or if you enjoy living in linguistic squalor, please let me know and create an issue on my home repository.

We do not enjoy living in linguistic squalor!


cjson.so: undefined symbol: lua_rotate

Hi，
I use luajit 2.1.0-beta3 and lua-cjson 2.1.0-1 from http://luarocks.org，I print a error "cjson.so: undefined symbol: lua_rotate" when running. I search that "lua_rotate" is a new add in lua 5.3. But there has the note in lua-cjson 2.1.0-1 require lua > 5.1 not 5.3. So, which lua version is need by lua-cjson 2.1.0-1？luajit 2.1.0-beta3 and lua-cjson 2.1.0-1 not match?
Thank you.

I use lua-cjson 2.1.0 with lua 5.3.3 ,it is ok but it get the same error with you when I use lua 5.2.4


adds coords on surfaces, & pre-smoothing for curv

Unfolded coords now generated as a surface metric too, is especially needed if using surfaces other than 32k.
Also added smoothing to mid-surface prior to curvature calculation (thanks @Bradley-Karat for testing out parameters for this step)
Unrelated: Fixed config yml issue that always added rule 'all', even if target rule specified from command-line

[x] initial testing of the rules
[x] run entire workflow on a subject and examine results

Seems to be working fine, so merging this in


Allow multiple APK uploads #14

A couple of changes to allow an array of apks to be uploaded instead of just one. The multiple apks target different architectures. Fixes issue #14

Thanks!


After upgrading to 2.3.8, the prompt file does not exist

It might caused by compilation failure. The connector with MySqlData is using MySql.Data 8.0.32 which might has some issues in some specific situation.
I can think of 2 solutions:
Solution 1: use MySqlBackup.NET with MySqlConnector
https://www.nuget.org/packages/MySqlBackup.NET.MySqlConnector/
MySqlConnector is more stable than MySql.Data.
Solution 2: Downgrade MySqlBackup.NET to version 2.3.7
Here's the guide:
https://stackoverflow.com/questions/10206090/how-can-i-install-an-older-version-of-a-package-via-nuget

Ok，Thinks，I Will Use MySqlBackup.NET.MySqlConnector/


Bump kiali capabilities to Deep Insights

Bumping the capabilities to Deep Insights based on the following reasons:

The custom resource Kiali exposes metrics at :9090/metrics
It integrates with Grafana, Jaeger and Prometheus for graphs, tracing and logging
Also provides a monitoring dashboard

/test all


fix(donation): Making donation a configurable parameter

:tada: This PR is included in version 1.4.6 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Enterprise IDP login ends up with authentication error

How To Reproduce:
Create an enterprise IDP.
Setup an application and add the IDP to signin method
Try out a sample with that Application.
Please note - you may use either OIDC or SAML.
Expected behavior:
Users should be able to login without any failure.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


fix: Publish bots one at a time to prevent LUIS 429 errors

Description
Publish bots to Azure one at a time (similar to local publish starting bots one at a time) to prevent LUIS rate exceeded errors.  This sometimes happens when we use a low TPS authoring key, or when multiple bots are using the same key.
In the long run we should use a js 'semaphore' or rate limiter on the sensitive publish and build controller endpoints, or turn the lubuild.Builder into a service.
Task Item
closes #7807

@boydc2014 , @srinaath , here's our luBuilder buildcommand in builder.ts:
    const buildResult = await this.luBuilder.build(luContents, config.authoringKey, config.botName, {
      endpoint: authoringEndpoint,
      suffix: config.suffix,
      keptVersionCount: 10,
      isStaging: false,
      region: config.region,
      directVersionPublish: directVersionPublish,
    });

We don't appear to use luisAPITPS, retryCount or retryDuration for lubuild (defaults to 5, 1, 1000 respectively).
Should we also tweak this options?  Maybe lowering luisAPITPS will be enough to prevent this issue entirely.

https://docs.microsoft.com/en-us/azure/cognitive-services/luis/luis-limits#authoring-resource-limits
So looking at the LuisAPITPS in bf-lu it looks it chunks the luis content with default being 5 before sending it for publishing. So, when three bots are hitting the same service at the same time it is definitely possible that 15 transactions are done in an instant which leads to the error. Have you tried tweaking those options on a set of 3-4 bots in a botproject  @taicchoumsft?
We are actually doing a lubuild even on bot start but we dont encounter the error as bots are started synchronously which aligns with what you have done in this PR.
I think for R14, the preference would be

Tweak the parameters. Ideal, as we can still continue parallel builds. With retry mechanism we may achieve the robustness in builds
Synchronous solution that you have built. Deployment will be slower but its a hit we could take as the deployment in general is a slow process.

The ideal solution of course like you said is a service for lubuild on Composer side that processes the queue to prevent overloads.

https://docs.microsoft.com/en-us/azure/cognitive-services/luis/luis-limits#authoring-resource-limits
So looking at the LuisAPITPS in bf-lu it looks it chunks the luis content with default being 5 before sending it for publishing. When three bots are hitting the same service at the same time it is definitely possible that 15 transactions are done in an instant which leads to the error. Have you tried tweaking those options on a set of 3-4 bots in a botproject @taicchoumsft?
We are actually doing a lubuild even on bot start but we dont encounter the error as bots are started synchronously which aligns with what you have done in this PR.
I think for R14, the preference would be
Option 1) Tweak the parameters. Ideal, as we can still continue parallel builds. With retry mechanism we may achieve the robustness in builds
Option 2) Synchronous solution that you have built. Deployment will be slower but its a hit we could take as the deployment in general is a slow process.
The ideal solution of course like you said is a service for lubuild on Composer side that processes the queue to prevent overloads.

Thanks for the feedback @srinaath .  Yes sounds good, I'll experiment more to see if these luBuild tweaks will work first.

@srinaath @taicchoumsft
The two options are both valid approaches as we've discussed in last chat. I will prefer the second which makes it sequential over the option than tweaking the parameters, because of the follow reasons

There is certain limitation of tweaking the parameter, the smallest value you can give to LUISTPS is 1, which means if you have >5  projects, your totally TPS will still be >5 and will potentially hit an error.
There is no good way to tweaking the parameter, you probably have to MAXTPS(5)/COUNT_OF_PROJECTS, which is not guaranteed to work and it requires you plugin through the data needed.

@srinaath @taicchoumsft
The two options are both valid approaches as we've discussed in last chat. I will prefer the second which makes it sequential over the option than tweaking the parameters, because of the follow reasons

There is certain limitation of tweaking the parameter, the smallest value you can give to LUISTPS is 1, which means if you have >5  projects, your totally TPS will still be >5 and will potentially hit an error.
There is no good way to tweak the parameter, you probably have to do MAXTPS(5)/COUNT_OF_PROJECTS, which is not guaranteed to work and it requires plugging through the extra information needed, touching probably many interfaces.

Thanks @boydc2014! Talked to @srinaath yesterday, we agreed take this change first (let me know if I missed something @srinaath) , instead of tweaking the lu configs, and later go in to add the LUbuilder service at a later date when/if needed.

@taicchoumsft Can we get this PR merged so that @lauren-mills can check if multiple bot publish does not error it in the nightly tomorrow?

@taicchoumsft Can we get this PR merged so that @lauren-mills can check if multiple bot publish does not error it in the nightly tomorrow?

Thanks @srinaath , just merged.


Change tooltip for default console

Recently "Get default console" is displayed as a tooltip for console action on the main page.
Change it to text similar to the old one in User Portal.

https://github.com/oVirt/ovirt-ui-components/pull/33

merged


[engine] Migrate build_and_test_linux_release to LUCI

We are already building the linux engine release version but we are not running the tests. We need to start running the tests and delete the cirrus configuration:
https://github.com/flutter/engine/blob/master/.cirrus.yml#L7

\cc @liyuqian


React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

This is with latest<EMAIL_ADDRESS>

Any updates on this ? those warnings getting really annoying :/


Upgrade to .NET 4.5?

For a couple of things we need to upgrade to .NET 4.5.
Please comment if this is an issue for you.

The only potential problem I can think of is that you will end support for win xp / server 2003.

For my case I am (finally) moving our Interop and build stuff to a newer generation OS, so no worries here.

is that you will end support for win xp / server 2003

Like Microsoft did? ;-)
But yes that's why I ask.


Implement source_files and files for test section

Both are a list of globs of files that should be copied into the test directory.

I think this is the issue I just ran into?
thread 'main' panicked at 'not yet implemented: Test files is not yet implemented!', src/packaging.rs:611:13

With a test section in my recipe.yaml:
test:
  files:
    - ./tests/
  commands:
    - tree ./
    - pytest

Did #230 resolve this, or was that something different?

Yep, it did! :)


Include vagrant-vbguest in the readme command

Although the vagrant-vbguest Vagrant plugin is listed as a preqrequisite on the readme page, the command given doesn't include it. If one tries to setup the 2-node cluster by copying/pasting instructions, the mapped folders on the Windows node won't work as expected (they exist as symlinks, but accessing their content will fail)

/lgtm

/approve


[locale] Fix incorrect inflections in cs locale

The problem was created in this PR and this PR fixes it.

How can I help to merge this?

Can someone fix this, how can I verify the checks?

Whats the Status here?

@indexxd  @idoodler already merged via https://github.com/moment/moment/pull/6191


ci: 🐝 move dprint format to GitHub workflow and update plugins

Description
Move dprint format check from local pre-commit hook to GitHub workflow, since pre-commit hook is no longer maintained.
Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

Current dependencies on/for this PR:

main

PR #26   👈

This comment was auto-generated by Graphite.


Provide better error messages about disabled insecure HTTP connections

Context:
https://flutter.dev/docs/release/breaking-changes/network-policy-ios-android
https://medium.com/flutter-community/solving-the-new-https-requirements-in-flutter-7abe240fbf23
Can we update the error message to include the fix? Instead of just saying that HTTP is blocked, we could tell people to either a) replace the URL with an HTTPS connection or b) enable HTTP (with all the caveats)
This is the kind of friction point that we can easily mitigate.

@mehmetf can we fix this before the next stable cut?

FYI @timsneath

Possible things we can do:

Include a link in the error message that explains all this such as: https://flutter.dev/docs/release/breaking-changes/network-policy-ios-android. I think embedding all this information in the error message itself is likely too much. I can push this through.

We can consider changing the Flutter Android embedding to add <IP_ADDRESS> to the list of allowed addresses. I would not want to do this because it would mean release apps are also allowed to connect to this address and that's not good.

We could change the flutter tooling to add android:usesCleartextTraffic="true" automatically to debug AndroidManifest.xml so users don't run into issues while debugging. I am not sure how feasible it is but I have seen similar code changes to tooling for iOS 14 that required additional plist attributes for debugging. I don't have bandwidth to do this unfortunately.

I have opened a PR to update the main article. Right now, the #1 google hit when someone searches this error message + flutter is https://flutter.dev/docs/release/breaking-changes/network-policy-ios-android.
It is unlikely that we can provide a 2-3 sentence solution. It will be more confusing. For instance, in most cases, HTTPS is not feasible. What if I just want to debug something? What if I am trying to connect to my local server? Allowing all cleartext traffic has serious caveats that won't fit to an error message. For instance, Apple might reject your app.
I am all for lower friction but it doesn't feel like we can do much else here. If you have an exact error message in mind, happy to hear it :)

I think a simple message that says something like "Change your app to use
the HTTPS protocol, or visit this page for other solutions:
https://blah.blah.blah" or similar will be just fine, honestly. Even if
it's the #1 search result, we should do everything we can to signpost
solutions. Does that make sense?
On Fri, Nov 6, 2020 at 5:40 PM Mehmet Fidanboylu<EMAIL_ADDRESS>wrote:

I have opened a PR to update the main article. Right now, the #1
https://github.com/flutter/flutter/pull/1 google hit when someone
searches this error message + flutter is
https://flutter.dev/docs/release/breaking-changes/network-policy-ios-android
.
It is unlikely that we can provide a 2-3 sentence solution. It will be
more confusing. For instance, in most cases, HTTPS is not feasible. What if
I just want to debug something? What if I am trying to connect to my local
server? Allowing all cleartext traffic has serious caveats that won't fit
to an error message. For instance, Apple might reject your app.
I am all for lower friction but it doesn't feel like we can do much else
here. If you have an exact error message in mind, happy to hear it :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/69685#issuecomment-723370724,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARWL66PCXSYUVZOG42UMR3SOSQPTANCNFSM4TJAASMA
.

Upstream Dart CL open for this: https://dart-review.googlesource.com/c/sdk/+/171020

/cc @mit-mit since I foresee some pushback on the CL and would like to come to a workable solution for our users.

Yep. One alternative as I mentioned in the CL description is to let embedder customize the error message.

@aam this is fixed now, correct?  (and has rolled into the framework with https://github.com/flutter/flutter/pull/83119)

Yes, the changes were rolled into the engine, so when --disallow-insecure-connections flag is used the better error message will be given to the user/developer.
I am not sure whether anything needs to be changed in flutter framework to start using this flag though. Could not find any tests around this functionality in flutter.

@zanderso ^---

FYI, the fix was reverted in https://github.com/flutter/engine/pull/26371 (and will be re-applied)

The fix did reland as https://github.com/flutter/engine/pull/26400, we still need to figure out next steps.

By next steps do you mean figuring out how to expose this to internal and external tooling? /cc @xster for internal tooling, @jonahwilliams for external tooling.

Do we actually want to disallow insecure connections by default, or does this behavior only make sense in a stricter environment like g3? We can certainly expose the flag to allow users to turn it on, but I'm not sure how much use that would get unless there are folks asking for it.

@jonahwilliams Maybe off by default with a tool flag to enable it for release builds?

But this is a runtime flag, it can only be provided when the tool launches the application. In order to support builds with this, we'd need to also teach the engine to read this value from a define in the snapshot.

I'm not up to speed with all the work that @mehmetf did in this space, but looking at https://github.com/flutter/engine/pull/20218 it seems that intent was to use android/ios configuration options to determine whether insecure connections are allowed or not.

Ahh, if its configured via metadata in the android manifest we don't need to do anything in the tool as far as I can tell. We could add a flag to override the setting, but the user might just as easily change their manifest.

At the moment, the default value of the flag allows insecure connections to any domain. Internal tooling may override that default, but I don't have a pointer to that code handy.

external engine flag disallow-insecure-connections with default value is defined here https://github.com/flutter/engine/blob/b71a2fd8f50ecd66b7e65192ef3077a7d0d76f52/shell/common/switches.h#L192
flipped over from "disallow" to may_insecurely_connect_to_all_domains for internal use here:
https://github.com/flutter/engine/blob/b71a2fd8f50ecd66b7e65192ef3077a7d0d76f52/shell/common/switches.cc#L261

@tvolkert wrote

the current status that insecure network connections are disabled with no way to enable them -- and that we want to allow app-level overrides by plumbing through platform-native configuration directives (such as android:usesCleartextTraffic for Android)?
...the error messages have been improved...

@zanderso wrote

Further platform specific plumbing is needed, yes.

That's the current state of things.

From Android triage: It looks like the error messages themselves have been fixed, which is what the original issue was about.
At this point any follow up work for platform-specific plumbing should be filed as a separate issue. Please feel free to re-open if you disagree!


Bug Report

Dark mode Everything shows in white expect the divider
On enabling dark mode the suggestion and place holder text not showing
Enable Dark mode in your android phone

[ ] iOS
[x] Android
[ ] Web

Any workaround available?

For placeholder you will need to specifically set the text color, https://github.com/FaridSafi/react-native-google-places-autocomplete/issues/863#issuecomment-1492879498. I am not sure what suggestion is, but you can set any styling you require there


Could you build notification for mobile?

I think notifications are very important for mobile app

Hope this soon.
I also see that Taiga does not have responsive. They must fix this in this term 6.
I think they should update everything for mobile soon in this term.

I'm closing this issue because as for now it is not possible to implement this feature. Feel free to reopen if you have any ideas/suggestions or updates


WebGL not working on Windows Embedded Sp1

Hi all,
I have an issue with Electron v0.32.2 x64 build that Chromium does not have in Windows Embedded Standard:

I am trying to open get.webgl.org in electron but it cannot initialize the egl. Any ideas?

Can you try if WebGL works in Chrome 45?

v45 as requested the exact same.

This is my builds fault, the prebuilt exe works fine. Any idea on what could cause this?


Fix "Function not implemented" issue using php-local

We are checking if $_POST exist OR if it is not empty but it should be: we use $_POST only if it exist AND it is not empty

Thanks @AshDevFr
FYI: @durasj


Support for random url embedding

Like facebook extracts title, preview image and description of a web page, can that be added to embed.js as well?
If not, can you point to a repo which can be used for the same? Can add that to embed.js and happy to send you a pull request.

Hi @mastersilv3r ,
There are limitations to it due to cross domain restrictions. You need to have your own server to crawl and save their data. You can create your own server and use this service with embed.js. I have just added this feature a few days ago. Docs are still not updated.
 openGraphEndpoint : 'https://opengraph.io/api/1.0/site/${url}',
 onOpenGraphFetch:function(data){
	data.hybridGraph.success = data.error ?  false : true;
	return data.hybridGraph;
}

You can see a demo here. You can see the discussion here

Thanks ritesh. Also for the awesome library.


morpheus-graphql: support megaparsec 9

Could you allow morpheus-graphql to support megaparsec 9 please?
This is currently blocking Stackage Nightly from updating to megaparsec-9: commercialhaskell/stackage#5632

hi @juhp. i already relaxed bounds in september. see morpheus-graphql-core 0.15.1 bounds are  >= 7.0.0     && <  10.0.0

Yes, thanks but morpheus-graphql.cabal still depends on megaparsec < 9
See https://hackage.haskell.org/package/morpheus-graphql-0.15.1

i released version 0.16.0
https://hackage.haskell.org/package/morpheus-graphql does not used megaparsec at all.
and
https://hackage.haskell.org/package/morpheus-graphql-core has upper bound <10

Thank you


resource-manager: Clean up HVPA usages and mutations

How to categorize this PR?

/area auto-scaling
/kind cleanup
What this PR does / why we need it:
This PR is the 5th PR related to the HVPA removal. The first 4 PRs were:

https://github.com/gardener/gardener/pull/10796
https://github.com/gardener/gardener/pull/10800
https://github.com/gardener/gardener/pull/10851
https://github.com/gardener/gardener/pull/10853

This PR cleans up HVPA usages and mutations in the resource-manager. Currently the resources has the following two HVPA logics:

The managedresource controller does not overwrite replicas and resources if the controller (Deployment, StatufulSet, ...) is scaled by HVPA.
The high-availability-config webhook mutates HVPA's min and max replicas depending on HA's failureToleranceType and component's type (controller/server)

Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:

[x] I will keep in draft state until the above-mentioned previous PRs from the HVPA removal story are merged.

Release note:

The resource-manager is no longer HVPA-aware.

/lgtm


Cert-manager chart v1.16.0 Schema validation - Issue with global parameters

I have an umbrella chart having cert-manager as a dependency with custom hooks to configure Issuers on post-install/upgrade.
With version v1.16.0, the breaking change about Helm schema validation rejects all the global parameters it does not recognize.
The definition of global (see https://helm.sh/docs/chart_template_guide/subcharts_and_globals/#global-chart-values) is:

Global values are values that can be accessed from any chart or subchart by exactly the same name.

Hence, the helm-tool mentioned under https://cert-manager.io/docs/releases/release-notes/release-notes-1.16/#helm should not reject unknown global and raise an error such as:

Instead, it should either ignore the global parameters or just mark them as a warning that they are not recognize by cert-manager.

After a little research, it seems that using patternproperties would be a way to allow global parameters not required by cert-manager

With #43 globals no longer sets additionalProperties: false. This was to solve similar issues like cert-manager/cert-manager#7329
This should solve your issue once we release cert-manager 1.16.1

Any ETA about cert-manager 1.16.1 release?

We just released cert-manager v1.16.1.


[Android 11, v2.1-rc4] Recording compression setting is not respected

Set the bitrate to 192 kbps with AAC-HE compression, it still records with only 128 kbps.
(Btw. there is no WAV format option shown with my device yet FLAC is available so that's a minor issue for the time being.)

Set the bitrate to 192 kbps with AAC-HE compression, it still records with only 128 kbps.

This is how FDK AAC encoder works.  I guess that you don't want to use HE for such large bitrate values - just use LC instead.

there is no WAV format option

It's not included because FLAC is better option for lossless recording.  Recording to uncompressed WAV wears out phone's storage device.


RigidBody with polygon shape has weird physics.

Godot version: Master f527a6946
Issue description:
RigicBody2D nodes with polygon shapes have some weird physics.

Steps to reproduce:
Try the example project with visible collision shapes enabled (can't draw polygons not even with _draw yet).
Modify the polygon keeping the lower vertex position and the result is always the same.
Link to minimal example project:
brokenrigid.zip
Added an extra rigid body for a more strange effect.

Related to #7136, was potentially fixed for 3D in #7426.
Basically, the center of mass is assumed to be at the Rigidbody2D's origin, which is why those shapes don't fall nicely. So, if you move the ColisionPolygon2D a bit to the left, it all works.
Additionally, there seems to be some unrelated problem of the rigidbody going to sleep even in some unstable positions because its velocity becomes too small for a moment. If you disable "can sleep", it should be a bit better.

@bojidar-bg I see, will close this because is clearly a center of mass issue.
I've seen some sleep related problems with simple shapes a couple of months ago, I'll check if can be reproduced again and open another issue for that.


add parameterization for host and port

Host and port can be specified by either a environment variable or a
dedicated command line parameter. Command line parameters will be preferred
over environment variables, which will be preferred over the application
defaults.
addresses #40

Codecov Report

Merging #43 (9f485b1) into master (be72a73) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   85.46%   85.46%
=======================================
  Files          14       14
  Lines         516      516
=======================================
  Hits          441      441
  Misses         55       55
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be72a73...9f485b1. Read the comment docs.

Thanks for your review and comments. I would like to have some more clarification to meet the requirements. Does this imply not to have the option to pass host und port parameters via command line? Should I keep the environment variables as an alternative way to override the configuration in the config yaml?

@mindcrime-ilab I think that there's no need to support either flag nor environment variable.
Exposing it in the config yaml file alone is sufficient.

Looks good, thank you for your contribution!

Released in v1.7.0


make sveltekit look more idiomatic

Using the $app/env we can make this look much more idiomatic. While still ensuring the code only runs in the browser.
The compiler is not entirely happy as it still complains:
svelte-carousel doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have "type": "module" or an .mjs extension for the entry point). Please contact the package author to fix.

but the resulting code seems to work fine

Released in 1.0.20

For me, this doesn't work... I'm getting the following error:
Cannot use import statement outside a module
/home/lena/bespinian/bespinian.io-svelte/node_modules/svelte-carousel/src/main.js:1
import Carousel from './components/Carousel/Carousel.svelte'
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at Object.compileFunction (node:vm:360:18)
    at wrapSafe (node:internal/modules/cjs/loader:1048:15)
    at Module._compile (node:internal/modules/cjs/loader:1083:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1173:10)
    at Module.load (node:internal/modules/cjs/loader:997:32)
    at Module._load (node:internal/modules/cjs/loader:838:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:170:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:528:24)

Furthermore, $app/env was renamed to $app/environment in<EMAIL_ADDRESS>https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md#100-next445 so the example given in the readme is not correct anymore.


great-theorems:0.1.0

I am submitting

[x] a new package
[ ] an update for a package

Description: Straightforward and functional theorem/proof environments.
I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

Thank you :)


Add pull request check for linked issues to CI workflow

Pull Request Description
(replace this text with your description)

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

No linked issues found. Please add the corresponding issues in the pull request description.  Use GitHub automation to close the issue when a PR is merged

The fix for Build conda package can be found here: https://github.com/alteryx/evalml/pull/3978


Bug: delete all policies when management + hub hosted mode

Bug: delete all policies when management + hub hosted mode

I don't know what is red-hat-trusted-app-pipeline
Red Hat Trusted App Pipeline Failing after 1s — Failed

@yiraeChristineKim could you please change the commit title to reflect the fix and not the bug description?

@yiraeChristineKim could you please make this PR in the upstream?

@yiraeChristineKim could you please make this PR in the upstream?

Oh you right I forgot that Thanks!


Netgear API multiple listening error on same port

When I try to listen to the same port multiple times with the Netgear API, I get the error that the port is already listening.
Would you help me with this topic?

@zeynepkoyun seems like you're not closing NetGear properly. Can you fill the template properly as need to know what machine/OS are you running? Or version of vidgear you're using, and so on. Plus, I need terminal debug logs to be able to solve this issue, so kimdly set logging=True in NetGear and then, paste the output from terminal here, whenever this issue happens.

Also @zeynepkoyun If you're okay with providing code here, then I'll able to resolve it more quickly.

Hi @abhiTronix
Actually, I want different clients to listen to the same port and show the video image simultaneously, so I should be able to reconnect to the same port without closing it.

Also @zeynepkoyun If you're okay with providing code here, then I'll able to resolve it more quickly.
client = NetGear(
address="<IP_ADDRESS>",
port="1025",
protocol="tcp",
pattern=2,
receive_mode=True,
logging=True,
**options
)

I want to enable connection by more than one client via Netgear API as in the above line of code.

Hi @abhiTronix
Actually, I want different clients to listen to the same port and show the video image simultaneously, so I should be able to reconnect to the same port without closing it.

Nope, that's not how NetGear API or its backend ZMQ works. A port once bind cannot be called again with a new connection until it closed properly. If you want multiple clients with one server, why don't you use its Multi-Clients mode: https://abhitronix.github.io/vidgear/latest/gears/netgear/advanced/multi_client/#multi-clients-mode-for-netgear-api

@zeynepkoyun also, if you're comfortable with showing image/video on browser to multiple users at same time then see our Webgear and Webgear_RTC APIs.

@abhiTronix Thank you for your answers, but here is: With Netgear, I broadcast multiple cameras over different ports, then I receive all the frames sent by the server on the client side.
However, when a different person wants to listen to the same port, I get the error that the port is already in use.

@zeynepkoyun i think you're looking for UDP, but NetGear API only supports TCP, that's why it's impossible to do so. However good news is that you use either Webgear or Webgear_RTC API instead which both supports multiple clients on same port in the network. Check advanced examples to get started.


RP-35 Refactor excel importers

Refactor excel importers.

Fixed by https://github.com/zwieback/old-relef-parser/pull/69


Fix the env var name to override default http client timeouts

This PR fixes the env var name to override default http client timeouts. Users should set OP_CONNECT_CLIENT_REQ_TIMEOUT to override the timeout.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@0429e1e). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage        ?   76.96%
=======================================
  Files           ?       27
  Lines           ?     1980
  Branches        ?        0
=======================================
  Hits            ?     1524
  Misses          ?      456
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


I can't join some pods

I join one pod, but another I cannot.  What could be the reason for this?
$ k debug selection-staging-798847b54b-g6nf9
container created, open tty...
bash-5.1# hostname
selection-staging-798847b54b-g6nf9
bash-5.1# exit
exit

$ k debug selection-db-staging-5974f5b9c9-8lqp7
error execute remote, error sending request: Post http://<IP_ADDRESS>:10027/api/v1/debug?command=%5B%22bash%22%5D&container=docker%3A%2F%2F84a34bba16510f36e4a3e044cd339eaa89af3c8f360b921fbcad60f548784fac&image=nicolaka%2Fnetshoot%3Alatest: dial tcp <IP_ADDRESS>:10027: connect: connection refused
error: error sending request: Post http://<IP_ADDRESS>:10027/api/v1/debug?command=%5B%22bash%22%5D&container=docker%3A%2F%2F84a34bba16510f36e4a3e044cd339eaa89af3c8f360b921fbcad60f548784fac&image=nicolaka%2Fnetshoot%3Alatest: dial tcp <IP_ADDRESS>:10027: connect: connection refused

Hi!
Try to activate:
hostNetwork: true
And try to use this command, this helps to me.
kubectl-debug -n monitoring monitoring-prometheus-node-exporter-6f4ls --agentless=true --port-forward=true --agent-image=aylei/debug-agent:v0.1.1

If it works change in daemonset.yaml
image: aylei/debug-agent:latest
To
image: aylei/debug-agent:v0.1.1

Also I have changed ports in daemonset.yaml from 10027 to 10028 (strange network problem: Predicate PodFitsHostPorts failed)
Good luck!


Add ability to run commands before trying to connect

While the code is a bit "quick and dirty", it works like a charm and allows you to define connections like this:
[[database]]
Name = 'server'
Provider = 'postgres'
DBName = 'foo'
URL = 'postgres://postgres:password@localhost:${port}/foo'
Commands = [
  { Command = 'ssh -tt remote-bastion -L ${port}:localhost:5432', WaitForPort = '${port}' }
]

So you can easily connect to remote servers as well! You can even chain commands to connect to a remote server and then a postgres container running in a remote k8s cluster:
[[database]]
Name = 'container'
Provider = 'postgres'
DBName = 'foo'
URL = 'postgres://postgres:password@localhost:${port}/foo'
Commands = [
  { Command = 'ssh -tt remote-bastion -L 6443:localhost:6443', WaitForPort = '6443' },
  { Command = 'kubectl port-forward service/postgres ${port}:5432 --kubeconfig /path/to/kube.conf', WaitForPort = '${port}' }
]

I've noticed this needs a little bit more work to make it robust (does not cleanly stops all commands when making multiple connection in one session). Will make some tweaks this weekend...

OK... It's quite a bit more involved as before as I needed some plumbing to be able to keep track of running commands in such a way that they would cleanup before the program exited. With these changes it now works very nicely and no matter how the app is stopped (pressing q, Ctrl-C or sending SIGINT or TERM) the commands are always properly stopped.
Next to that I added some logic for testing if a command started listening on the requested port (see the updated example in the opening post of this PR) and tried to provide a little bit more feedback to the user.
Besides the functional changes needed for the commands to work properly, I think I make 3 semi unrelated changes. If you want I can revert them, but I think they make sense:

I removed the panic's from main.go
I renamed loglvl to loglevel so its more consistent with logfile (which is also written in full)
I updated the label on home.Tree from connection.Name+connection.Provider to just connection.Name.

The last one is mainly because practically all my names are too long for the tree width and there is a bug in how the cutoff is handled so next to loosing the last part (which makes sense) I also don't see the first few chars. I would ask/suggest to just use the connection.Name for now and maybe revert that once the behavior is fixed or changed.
Let me know if you have any questions or comments.

The code is way better now thanks.
I might have some remarks on the way you use context. But there are side remarks.
It could be addressed in a later refactoring.
Here are my feedbacks:

the context shouldn't be stored in Application, but passed from one method to another.
I'm unsure you need to stored the context canceller in the struct either.
you could move the signal check things in a method that create the context.
The context could be created in main.go
waitforport should pass the context. Avoiding to retry if the context is done.

I'm well aware of how the context could/should be used in a well designed application, but properly implementing it into the current codebase would be close to a full rewrite 🙈
So I opted to not try and change everything at once, but instead focus on the bits I wanted to add and make small improvements in the surrounding parts to make that possible.

I agree. That's why I said your change were OK, and the code is way better now.
And yes, it might need a pure rewrite

Updated WaitForPort so it takes a context which is set on the dailer and is checked when sleeping in between connection attempts. There are still many things that can be added and/or improved regarding both the code and functionality in this PR, but for now I think this provides enough functionality for most use cases.

I'm well aware of how the context could/should be used in a well designed application, but properly implementing it into the current codebase would be close to a full rewrite 🙈
So I opted to not try and change everything at once, but instead focus on the bits I wanted to add and make small improvements in the surrounding parts to make that possible.
I actually started with a function that returns a context in main, more of less exactly how you are proposing 😉, but the current layout of the app is not realy designed to work that way as it uses lots of global variables to store types (like the main Application type) that are being called from locations all over the code.
Properly restructering that in a more idiomatic layout would be a reasonably big change that should be a PR on itself in my opinion (and should be endorced by @jorgerojas26 as the owner/maintainer of this code).
Edit: Not proposing such a rewrite by the way! I like the tool and love to fix bugs that bug me or contribute features I'm missing, but I do have a (quite) busy day job as well 😊

Maybe the discussions we had here, could be quoted in a dedicated issue about a possible refactoring that would make the app more idiomatic, especially the context.
The issue might be closed then,but at least there will be a track of the discussion in an issue

I'm well aware of how the context could/should be used in a well designed application, but properly implementing it into the current codebase would be close to a full rewrite 🙈
So I opted to not try and change everything at once, but instead focus on the bits I wanted to add and make small improvements in the surrounding parts to make that possible.
I actually started with a function that returns a context in main, more of less exactly how you are proposing 😉, but the current layout of the app is not realy designed to work that way as it uses lots of global variables to store types (like the main Application type) that are being called from locations all over the code.
Properly restructering that in a more idiomatic layout would be a reasonably big change that should be a PR on itself in my opinion (and should be endorced by @jorgerojas26 as the owner/maintainer of this code).
Edit: Not proposing such a rewrite by the way! I like the tool and love to fix bugs that bug me or contribute features I'm missing, but I do have a (quite) busy day job as well 😊

Maybe the discussions we had here, could be quoted in a dedicated issue about a possible refactoring that would make the app more idiomatic, especially the context.
The issue might be closed then,but at least there will be a track of the discussion in an issue

That is a really good idea. I sadly did not know about Context api when i started building lazysql (remember this is my first touch on Go). So, that refactor would be a good idea.

@jorgerojas26 just added a commit with some documentation, so guess this one should be ready now as well.


Add Option to Clear Upinks Heard Layers

Need UI for this? I was thinking that closing the info pane could clear the map selection. We could introduce a 'collapse' button to preserve the map selection but hide the info pane.

I was thinking the same!

Via Siegfried in community chat:

ability to deselect a selected mapped hex by tapping/double tapping again

I think this could be implemented as a tap to select/ tap to deselect - like a checkbox. It'd be a good additional interaction alongside the collapse/close buttons.


What's mean with Ghost directory path? ghost or ghost/core ?

Create a ghost-static.json in your Ghost directory???
➜  ghost ghost-static
env: node\r: No such file or directory

Follow this guide to install Ghost locally: https://docs.ghost.org/docs/install-local
Install ghost-static globally
Create the ghost-static.json inside the Ghost directory. It's the same directory from where you run ghost start
Start Ghost
Type ghost-static to scrape your local instance

thx!


HAWQ-573. Refix the bug as last fix has imported more warning messages.

As we changed the allocate resource logic, which means we add resource into GlobalQueryResources before we actually allocate the resource, it has a possibility that we allocate failed and want to return it. Then it return failed and report warning messages, which should not be reported. So this fix is to judge and mark if it should report the message.

LGTM

+1


Windows: [TP3] Fix certificate directory for registry

Signed-off-by: John Howard<EMAIL_ADDRESS>@swernli
This PR is part of the proposal described in docker/docker issue 10662 to port the docker daemon to Windows. Windows doesn't have an /etc directory :) @calavera I had to undo some of your const*.go changes as the _windows and _unix files now have more than just const in them.

sounds good.
munge? what about something more descriptive, like cleanPath? :smile:

Yeah :) Updated.

Crazy Windows CI results - seen this on two PRs this afternoon. Not sure if some bad merge has gone in, or CI strangeness again. Experimental has been having catastrophic errors since mid afternoon. Restarted 3 times, same result.

Windows CI will be fixed by GH15336

And it is fixed. Yay green CI

LGTM

LGTM


Publishing a library with Spago

Coming from @f-f's comment here (very end of the comment):

You can use spago to develop libraries, the only part that require you to use pulp and bower are versioning and publishing on bower. The reasons why this is required are stated here.
In general you'll have a bower file, but it's only necessary that it contains the right list of dependencies, the version can be * (at least for adding it to the package set).
Basically all of this can be automated, and this would mean having spago version and spago publish

Followed by my comment here (very end of comment):

Perhaps I should clarify that statement. The point is that you can't publish docs to Pursuit unless you are using bower at some point. While it may be possible to use spago to create libraries, I'm not sure whether that would be a good idea because I could "patch" a dependency in my package set before doing that and potentially break expectations.
So, perhaps that could work but only if the package set did not include any overrides or additions?

The topic of "how do I publish with spago" is coming up quite often recently, so I though I'd recap the current situation:

The context is that the PureScript ecosystem uses the Bower registry as a "unique names registry". So in order to "publish" a package one needs to add it there, and eventually to package-sets.
Consequentially, package-sets requires (full instructions here) that packages in it:

are in the Bower registry
use pulp version (because this gives versions with vX.Y.Z)
use pulp publish (because AFAIK there's no specification on how to publish a package other than "what the compiler and pulp do")

So for the time being one can develop normally with spago, and then when they want to publish they have to:

make a bowerfile that includes the spago dependencies
run pulp version
run pulp publish
One example of packages published in this way is purescript-rave (/cc @reactormonk: is all of this accurate?)

To address your concern about people "patching dependencies": the fact that the above workflow is required (in particular bower i -p has to succeed in order for the package being good for the package set) means that people can only depend on published packages.
I.e. for what concerns "publishing" it doesn't matter if a package compiles with spago or psc-package, it has to compile with bower. So everything is fine on this side :)

There are a few desiderable things that we could do (in this order):

document the current workflow in a section of the README
add spago new-version command to upgrade the version in your spago.dhall (we don't have this config key yet) - akin to pulp version.
An alternative design is that we could skip having an explicit version field, and just rely on what git tells us. I.e. we search for vX.Y.Z tags, and we add and push a new one
add spago publish to publish to both the bower registry and package-sets. It would:

generate an ephemeral bower.json in the .spago directory (the idea is that this generation is deterministic starting from the spago.dhall, so you don't actually need to version the bower.json file). The versions of packages listed there can come from the package set or can even be * (I think there are drawback to either choice)
call git and bower commands in the background to publish a git tag and publish on the bower registry (this would require that bower is installed)
print out a link to open an issue in package-sets about adding the package there (basically #72)

Can confirm, is accurate.

To address your concern about people "patching dependencies": the fact that the above workflow is required (in particular bower i -p has to succeed in order for the package being good for the package set) means that people can only depend on published packages.
I.e. for what concerns "publishing" it doesn't matter if a package compiles with spago or psc-package, it has to compile with bower. So everything is fine on this side :)

Gotcha. That addresses the concern I raised then.
I know I read somewhere that packages are required to be published to the Bower registry before they can be added into the package set to avoid Haskell's problem of splitting the ecosystem. However, I don't see an explanation of that written anywhere in this project. (Maybe it was stated in the Slack chatroom?)
I also realize that you've explained these things multiple times elsewhere, so perhaps this just needs a centralized place that links to all of those?

@JordanMartinez

I know I read somewhere that packages are required to be published to the Bower registry before they can be added into the package set to avoid Haskell's problem of splitting the ecosystem. However, I don't see an explanation of that written anywhere in this project. (Maybe it was stated in the Slack chatroom?)
I also realize that you've explained these things multiple times elsewhere, so perhaps this just needs a centralized place that links to all of those?

Yeah this is documented in the package-sets contributing guidelines I linked above, and the explanation was purposefully left out from Spago's docs so far, as I didn't have a clear plan forward and didn't want to confuse readers.
I think at this point the plan is quite clear - TL;DR: use pulp for now, and then implement version and publish here in Spago before 1.0 - as detailed in my above comment

the explanation was purposefully left out from Spago's docs so far, as I didn't have a clear plan forward and didn't want to confuse readers.

Makes sense.

Yeah this is documented in the package-sets contributing guidelines I linked above

I'm going to be nit-picky here: the words used there are "should" not "required"/"must".
Also, I recall reading that section earlier and it wasn't immediately clear to me that publishing to bower was necessary, partly because pulp version is mentioned first to address a seemingly unimportant issue and then bower is later mentioned. Once one understands the full context, the reference to pulp version makes sense: "Oh, I need to do that because I need to publish first to bower and using semver is best handled by pulp."
Until the plan gets implemented, would you mind if I submit a PR that clarifies that contributing guideline a bit more?

Until the plan gets implemented, would you mind if I submit a PR that clarifies that contributing guideline a bit more?

Sure, I think having clear contribution guidelines in package-sets is faily independent from any implementation plan here 🙂

Ok. I'll make this a goal for the upcoming week

I opened #203 and #204 to keep track of the implementation work for this, so this is safe to close 😊


cpp: Explicitly enable cpp17

Public-Facing Changes
None
Description
I though that conan would automaticlaly do this, but apparently this is not the case: https://github.com/conan-io/conan-center-index/pull/16500#issuecomment-1463916745
Anyway, it's still a good practice to enable it explicitly in case it is build without conan

In the mcap repo we use set(CMAKE_CXX_STANDARD 17). Is there a difference?

It is basically the same, but set_target_properties allows for a more fine-grained control


[extended tests] are broken currently (BoringSSL fails)

Did a dummy commit test using https://github.com/openssl/openssl/pull/8634

(FWIW: you can sign into travis-ci and AppVeyor with your GitHub account and then you will automatically get ci jobs triggered for all branches which you push to your clone, even without having to create a pull request.)

Partially addressed by #8793. That fixes the boringssl test failure. krb5 and pyca are also currently failing though.

Hmm. Actually it only seems to be pyca that is failing in travis not krb5 (I had a local failure of krb5 which was due to an environmental issue).
I also seem to have an environmental issue with pyca which is preventing me from investigating the travis issue. When I attempt to run the pyca tests using this:
./config shared enable-external-tests
make
make TESTS=test_external_pyca V=1 test

I get this:
  generating cffi module 'build/temp.linux-x86_64-2.7/_constant_time.c'
  generating cffi module 'build/temp.linux-x86_64-2.7/_openssl.c'
  building '_openssl' extension
  creating build/temp.linux-x86_64-2.7/build
  creating build/temp.linux-x86_64-2.7/build/temp.linux-x86_64-2.7
  x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fdebug-prefix-map=/build/python2.7-3hk45v/python2.7-2.7.15~rc1=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I/usr/include/python2.7 -c build/temp.linux-x86_64-2.7/_openssl.c -o build/temp.linux-x86_64-2.7/build/temp.linux-x86_64-2.7/_openssl.o -Wconversion -Wno-error=sign-conversion
  build/temp.linux-x86_64-2.7/_openssl.c:498:10: fatal error: openssl/opensslv.h: No such file or directory
   #include <openssl/opensslv.h>
            ^~~~~~~~~~~~~~~~~~~~
  compilation terminated.
  error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

  ----------------------------------------
  Failed building wheel for cryptography
  Running setup.py clean for cryptography
Failed to build cryptography
Could not build wheels for cryptography which use PEP 517 and cannot be installed directly
../../util/shlib_wrap.sh sh ../../test/recipes/95-test_external_pyca_data/cryptography.sh => 1
not ok 1 - running Python Cryptography tests
#   Failed test 'running Python Cryptography tests'
#   at ../test/recipes/95-test_external_pyca.t line 27.
# Looks like you failed 1 test of 1.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests

Test Summary Report
-------------------
../test/recipes/95-test_external_pyca.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=1, 10 wallclock secs ( 0.03 usr  0.00 sys +  6.98 cusr  0.73 csys =  7.74 CPU)
Result: FAIL
Makefile:205: recipe for target '_tests' failed
make[1]: *** [_tests] Error 1
make[1]: Leaving directory '/home/matt/dev/openssl-write'
Makefile:203: recipe for target 'tests' failed
make: *** [tests] Error 2

I never used to have this problem, so I don't know what changed.
Perhaps @reaperhulk or @tiran might be able to help me?

I can look at the problem this weekend. CI appears to be failing with a variety of errors related to the error stack, but your local issue looks like it just can't find your include directory so CFLAGS may resolve that (and replicate the travis issue). Either way I'll try to replicate locally and figure out what's going on.

but your local issue looks like it just can't find your include directory

Right...but why not? Since I invoked this via make TESTS=test_external_pyca V=1 test from the root of the openssl dir I expect all required flags etc to be setup automatically by the test suite....but for some reason that hasn't happened?

Not sure on that front, but I replicated this by building from master and linking cryptography directly against it in my own env. Here's a C reproducer (adapted from demos/evp/aesccm.c) that produces the expected tag output on OpenSSL 1.1.1 but fails on 3.0.0-dev
#include <stdio.h>
#include <openssl/bio.h>
#include <openssl/evp.h>

/* AES-CCM test data from NIST public test vectors */

/* [Alen = 32, Plen = 0, Nlen = 13, Tlen = 16] */

/* Key = f9fdca4ac64fe7f014de0f43039c7571 */

/* Count = 165 */
/* Nonce = 5a8aa485c316e9403aff859fbb */
/* Adata = a16a2e741f1cd9717285b6d882c1fc53655e9773761ad697a7ee6410184c7982 */
/* CT = 1859ac36a40a6b28b34266253627797a */
/* Result = Pass */
/* Payload = 00 */

static const unsigned char ccm_key[] = {
    0xf9, 0xfd, 0xca, 0x4a, 0xc6, 0x4f, 0xe7, 0xf0, 0x14, 0xde, 0x0f, 0x43,
    0x03, 0x9c, 0x75, 0x71
};

static const unsigned char ccm_nonce[] = {
    0x5a, 0x8a, 0xa4, 0x85, 0xc3, 0x16, 0xe9, 0x40, 0x3a, 0xff, 0x85, 0x9f,
    0xbb
};

static const unsigned char ccm_adata[] = {
    0xa1, 0x6a, 0x2e, 0x74, 0x1f, 0x1c, 0xd9, 0x71, 0x72, 0x85, 0xb6, 0xd8,
    0x82, 0xc1, 0xfc, 0x53, 0x65, 0x5e, 0x97, 0x73, 0x76, 0x1a, 0xd6, 0x97,
    0xa7, 0xee, 0x64, 0x10, 0x18, 0x4c, 0x79, 0x82
};

static const unsigned char ccm_pt[] = {
};

static const unsigned char ccm_ct[] = {
};

static const unsigned char ccm_tag[] = {
    0x18, 0x59, 0xac, 0x36, 0xa4, 0x0a, 0x6b, 0x28, 0xb3, 0x42, 0x66, 0x25,
    0x36, 0x27, 0x79, 0x7a
};

int main(int argc, char **argv)
{
    EVP_CIPHER_CTX *ctx;
    int outlen, res;
    unsigned char outbuf[1024];
    printf("AES CCM Encrypt:\n");
    ctx = EVP_CIPHER_CTX_new();
    /* Set cipher type and mode */
    EVP_EncryptInit_ex(ctx, EVP_aes_128_ccm(), NULL, NULL, NULL);
    EVP_CIPHER_CTX_ctrl(ctx, EVP_CTRL_AEAD_SET_IVLEN, sizeof(ccm_nonce),
                        NULL);
    /* Set tag length */
    EVP_CIPHER_CTX_ctrl(ctx, EVP_CTRL_AEAD_SET_TAG, sizeof(ccm_tag), NULL);
    /* Initialise key and IV */
    EVP_EncryptInit_ex(ctx, NULL, NULL, ccm_key, ccm_nonce);
    /* Set plaintext length: only needed if AAD is used */
    EVP_EncryptUpdate(ctx, NULL, &outlen, NULL, sizeof(ccm_pt));
    /* Zero or one call to specify any AAD */
    EVP_EncryptUpdate(ctx, NULL, &outlen, ccm_adata, sizeof(ccm_adata));
    /* Encrypt plaintext: can only be called once */
    EVP_EncryptUpdate(ctx, outbuf, &outlen, ccm_pt, sizeof(ccm_pt));
    EVP_EncryptFinal_ex(ctx, outbuf, &outlen);
    /* Get tag */
    EVP_CIPHER_CTX_ctrl(ctx, EVP_CTRL_AEAD_GET_TAG, 16, outbuf);
    /* Output tag */
    printf("Tag:\n");
    BIO_dump_fp(stdout, outbuf, 16);
    printf("Expected Tag:\n");
    BIO_dump_fp(stdout, ccm_tag, 16);
    EVP_CIPHER_CTX_free(ctx);
}

Most of (maybe all, haven't checked yet) of the failing tests are because current master doesn't appear to properly handle empty plaintext for CCM.

Ah - perfect - thanks. I can reproduce the problem. The culprit seems to be #8676.

The big issue here is how out == NULL and in == NULL are interpreted in the backend's do_cipher() function.
Some backends (notably chacha20/poly1305) interpret in == NULL as a "final" call, while others (such as aes_ccm) interpret in == NULL && out != NULL as a "final" call.
The essence of this is that sometimes, it's simply a real bad idea to call EVP_EncryptUpdate with in = NULL, while it's tolerated in other cases.
#8676 catered for the way chacha20/poly1305 handled it.  We obviously have to fine tune this a bit better...

@levitte any thoughts on how best to fine tune this?

@levitte

In Fedora I've added out == NULL to the in == NULL condition which fixes the Python issue and should not break the #8675. Not sure it is the right thing though.

I lost track of this...
Is this still an issue?

Travis is currently broken due to an unrelated issue, but the external tests build has been passing in travis:
https://travis-ci.org/openssl/openssl/jobs/649179363
However, we "solved" the issue by disabling the pyca external test (20e6631c73cf). So the pyca external tests are still broken.

However, we "solved" the issue by disabling the pyca external test (20e6631). So the pyca external tests are still broken.

I created issue #11068 as a reminder.


Update crypto submodule to mbedcrypto-0.1.0b

Update crypto submodule to mbedcrypto-0.1.0b.

CI failure is Doxygen warning and FreeBSD timing test

Merged into development-psa. Can now be closed.


Document how to add the HostPath storage driver

Is your feature request related to a problem? Please describe.
Manifests that include PersistentVolumeClaims do not work.
Describe the solution you'd like
I would like documentation on how to install and configure the HostPath driver. I'm not interested in HA storage, etc.
Describe alternatives you've considered
None
Thanks!

Struggling with this too; is it possible to get that to work? If so, a few pointers in the general direction would be very helpful.

I prefer to use volume of the hostpath type directly.
An example:
$ k3s kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.3-k3s.6", GitCommit:"da4e14f160174f356b1d95198f48439971cc8a85", GitTreeState:"clean", BuildDate:"2019-02-24T05:21+00:00Z", GoVersion:"go1.11.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.3-k3s.6", GitCommit:"da4e14f160174f356b1d95198f48439971cc8a85", GitTreeState:"clean", BuildDate:"2019-02-24T05:21+00:00Z", GoVersion:"go1.11.4", Compiler:"gc", Platform:"linux/amd64"}
$ alias k="k3s kubectl"
$ cat pod-hostpath.yaml
apiVersion: v1
kind: Pod
metadata:
  name: test-pd
spec:
  containers:
  - image: k8s.gcr.io/test-webserver
    name: test-container
    volumeMounts:
    - mountPath: /test-pd
      name: test-volume
  volumes:
  - name: test-volume
    hostPath:
      path: /data
      type: Directory
$
$ k apply -f pod-hostpath.yaml
pod/test-pd created
$ k get pods
NAME                   READY   STATUS    RESTARTS   AGE
http-8654dd748-fjdkc   1/1     Running   0          9m22s
test-pd                1/1     Running   0          13s
$ k get pod test-pd -o yaml
apiVersion: v1
kind: Pod
......
    name: test-container
    resources: {}
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /test-pd
      name: test-volume
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: default-token-vz4pc
      readOnly: true
  dnsPolicy: ClusterFirst
......
  volumes:
  - hostPath:
      path: /data
      type: Directory
    name: test-volume
  - name: default-token-vz4pc
    secret:
      defaultMode: 420
      secretName: default-token-vz4pc
status:
......
    restartCount: 0
    state:
      running:
        startedAt: "2019-02-28T11:24:20Z"
  hostIP: <IP_ADDRESS>
  phase: Running
  podIP: <IP_ADDRESS>
  qosClass: BestEffort
  startTime: "2019-02-28T11:24:19Z"
$
$ k cluster-info
Kubernetes master is running at https://localhost:6443
CoreDNS is running at https://localhost:6443/api/v1/namespaces/kube-system/services/kube-dns:dns/proxy

To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.
$

If switch to CSI implementation, I need to install Provisioner, Driver, Attacher and Registrar plugins, which seems too complex. It goes against the original intention of k3s to pursue simplicity and lightness.
The following two articles describe the content related to the CSI host-path for reference:

https://kubernetes-csi.github.io/docs/example.html
https://github.com/Azure/kubernetes-volume-drivers/tree/master/csi/hostpath

Just my 2 cents. ☸☸ :smiley:

My use case is for CI. If I change from PVC then it's not testing my config. Also, one particular application uses Helm to package and uses dependencies. Those dependencies use PVC. It'd be easier for me to install a plugin.

an example for setting up a host-path-provisoner #85 (https://github.com/rancher/k3s/issues/85#issuecomment-468293334)

@warmchang hostPath volumes are always owned by root; this complicates things considerably when using pre-built containers that run their process(es) as another user. The localPath provisioner described in #85 does pretty much the same but via PVCs, which don't seem to suffer from the owned-by-root issue.

Agree. I'm trying the local path solution now and it seems good so far. I'd
be happy with that and I may submit a PR for the docs later.
On Sun, Mar 10, 2019, 7:30 AM flxs<EMAIL_ADDRESS>wrote:

@warmchang https://github.com/warmchang hostPath volumes are always
owned by root; this complicates things considerably when using pre-built
containers that run their process(es) as another user. The localPath
provisioner described in #85 https://github.com/rancher/k3s/issues/85
does pretty much the same but via PVCs, which don't seem to suffer from the
owned-by-root issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rancher/k3s/issues/75#issuecomment-471306077, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFYQKY4tkwdT5oGZd84u4leiEEOD6Mmpks5vVQjfgaJpZM4bVanP
.

https://rancher.com/docs/k3s/latest/en/storage/


Snapshot names don't include directory names

What happened?
Using subdirectories is supported by glob, but the resulting snapshot files don't include the sub directory names. cargo insta test --review fails to recognize the two test cases as different.
$ tree -f input
input
├── input/case1.txt
└── input/sub
    └── input/sub/case1.txt

1 directory, 2 files

Reproduction steps

Create simple Rust project with insta
mkdir -p input/sub/
touch input/case1.txt input/sub/case1.txt
Use glob!("input/**/*.txt") to match on all test cases.

use std::fs;

glob!("inputs/**/*.txt", |path| {
    let input = fs::read_to_string(path).unwrap();
    assert_snapshot!(input.to_uppercase());
});

Run insta

Insta Version
1.21.2 (yaml, glob)
rustc Version
rustc 1.65.0 (897e37553 2022-11-02)
What did you expect?
I was expecting insta to support this, as glob seems to support /**/. Code wise, I expect insta to detect subdirectories, and store their name in the snapshot file name it creates.

That doesn't seem great but I need to figure out how to fix this without breaking existing snapshots. Maybe with a custom glob parser the prefix could be detected and removed.

Thanks for implementing this feature! I've tested it and can confirm that it works well. Great job!


Updated XML code formatting of SettingsOverridesType

@OlegKarasik : Thanks for your contribution! The author, @rwike77, has been notified to review your proposed change.

@OlegKarasik  Hi, thanks for the update.  Looks good.  #sign-off


Blank web page (no login prompt)

Successfully installed TRACCAR Windows 64 (startup logs attached), when I go to localhost:8082, I get this JS error. Did I miss something on install?

LOG
STATUS | wrapperm | 2015/08/25 21:10:01 | Traccar service installed.
STATUS | wrapper  | 2015/08/25 21:11:27 | --> Wrapper Started as Service
STATUS | wrapper  | 2015/08/25 21:11:27 | Java Service Wrapper Community Edition 64-bit 3.5.26
STATUS | wrapper  | 2015/08/25 21:11:27 |   Copyright (C) 1999-2014 Tanuki Software, Ltd. All Rights Reserved.
STATUS | wrapper  | 2015/08/25 21:11:27 |     http://wrapper.tanukisoftware.com
STATUS | wrapper  | 2015/08/25 21:11:27 |
STATUS | wrapper  | 2015/08/25 21:11:27 | Launching a JVM...
INFO   | jvm 1    | 2015/08/25 21:11:29 | WrapperManager: Initializing...
INFO   | jvm 1    | 2015/08/25 21:11:31 | [MLog-Init-Reporter] INFO com.mchange.v2.log.MLog - MLog clients using slf4j logging.
INFO   | jvm 1    | 2015/08/25 21:11:34 | [WrapperSimpleAppMain] INFO com.mchange.v2.c3p0.C3P0Registry - Initializing c3p0-<IP_ADDRESS> [built 16-June-2015 00:06:36 -0700; debug? true; trace: 10]
INFO   | jvm 1    | 2015/08/25 21:11:35 | [WrapperSimpleAppMain] INFO com.mchange.v2.c3p0.impl.AbstractPoolBackedDataSource - Initializing c3p0 pool... com.mchange.v2.c3p0.ComboPooledDataSource [ acquireIncrement -> 3, acquireRetryAttempts -> 30, acquireRetryDelay -> 1000, autoCommitOnClose -> false, automaticTestTable -> null, breakAfterAcquireFailure -> false, checkoutTimeout -> 0, connectionCustomizerClassName -> null, connectionTesterClassName -> com.mchange.v2.c3p0.impl.DefaultConnectionTester, contextClassLoaderSource -> caller, dataSourceName -> 31o1bi9bshuvwe1yqxl4g|78e112dd, debugUnreturnedConnectionStackTraces -> false, description -> null, driverClass -> org.h2.Driver, extensions -> {}, factoryClassLocation -> null, forceIgnoreUnresolvedTransactions -> false, forceSynchronousCheckins -> false, forceUseNamedDriverClass -> false, identityToken -> 31o1bi9bshuvwe1yqxl4g|78e112dd, idleConnectionTestPeriod -> 600, initialPoolSize -> 3, jdbcUrl -> jdbc:h2:C:\Program Files\Traccar\data\database, maxAdministrativeTaskTime -> 0, maxConnectionAge -> 0, maxIdleTime -> 0, maxIdleTimeExcessConnections -> 0, maxPoolSize -> 15, maxStatements -> 0, maxStatementsPerConnection -> 0, minPoolSize -> 3, numHelperThreads -> 3, preferredTestQuery -> null, privilegeSpawnedThreads -> false, properties -> {user=******, password=******}, propertyCycle -> 0, statementCacheNumDeferredCloseThreads -> 0, testConnectionOnCheckin -> true, testConnectionOnCheckout -> false, unreturnedConnectionTimeout -> 0, userOverrides -> {}, usesTraditionalReflectiveProxies -> false ]
INFO   | jvm 1    | 2015/08/25 21:11:39 | [WrapperSimpleAppMain] INFO org.eclipse.jetty.util.log - Logging initialized @12124ms
INFO   | jvm 1    | 2015/08/25 21:11:41 | [WrapperSimpleAppMain] INFO org.eclipse.jetty.server.Server - jetty-9.2.13.v20150730
INFO   | jvm 1    | 2015/08/25 21:11:42 | [WrapperSimpleAppMain] INFO org.eclipse.jetty.server.handler.ContextHandler - Started o.e.j.s.ServletContextHandler@34be3631{/api,null,AVAILABLE}
INFO   | jvm 1    | 2015/08/25 21:11:42 | [WrapperSimpleAppMain] INFO org.eclipse.jetty.server.ServerConnector - Started ServerConnector@147d2d14{HTTP/1.1}{<IP_ADDRESS>:8082}
INFO   | jvm 1    | 2015/08/25 21:11:42 | [WrapperSimpleAppMain] INFO org.eclipse.jetty.server.Server - Started @14488ms

it looks like ExtJS library is missing. Possibly Internet access issue?

should the library be local or is the code going out and bringing it in (which may be a setting for IE/browser?)

It is retrieved from CDN (cdnjs.cloudflare.com).

security settings in IE - all solved, thnks!
On Tue, Aug 25, 2015 at 3:59 PM, Anton Tananaev<EMAIL_ADDRESS>wrote:

It is retrieved from CDN (cdnjs.cloudflare.com).
—
Reply to this email directly or view it on GitHub
https://github.com/tananaev/traccar/issues/1374#issuecomment-134754266.

--
Brian Collins
Chief Operating Officer, intterra
<EMAIL_ADDRESS>http://youtu.be/DVPOYjhkBEo
719-310-6041
www.intterragroup.com http://www.intterragroup.com/


NextHopSummary.py doesn't work for NX-OS

This script hasn't be written to match NX-OS style routes.

Script was updated to account for this a while ago -- closing old issue.


Add Auto Comment Feature to Improve Collaboration

Issue Description:
As an active contributor to your open-source project, I believe that implementing an auto-comment feature would greatly enhance collaboration and communication within the project. This feature would automatically generate comments in response to specific events, such as when an issue is opened, a pull request is created, an issue is assigned, or an issue is unassigned.
Feature Details:

When an issue is opened, the auto-comment should greet the author and provide a brief acknowledgement and request for additional context.
When a pull request is opened, the auto-comment should greet the author, express gratitude, and remind them to follow the project's contributing guidelines.
When an issue is closed, the auto-comment should thank the author for their contribution and encourage further engagement.
When an issue is assigned to someone, the auto-comment should notify the assignee and encourage them to start working on it.
When an issue is unassigned from someone, the auto-comment should notify the assignee about the change and suggest reassignment if they are offline.

Benefits:

Improved communication and engagement with contributors.
Provides clear instructions and acknowledgements for various events.
Enhances collaboration by setting expectations and providing reminders.
Reduces manual effort by automating comment generation.

Acceptance Criteria:

The auto-comment feature should be implemented using the "wow-actions/auto-comment" GitHub Action.
Comments should be appropriately customized for each event, mentioning relevant parties and providing the necessary information.
The auto-comment workflow should trigger on the following events: issues opened, pull requests opened, issues closed, issues assigned, and issues unassigned.
The feature should be added to the project's existing GitHub Actions workflow file.

Additional Context:
Feel free to ask any questions or seek clarification regarding the auto-comment feature. I'm excited about contributing to your project and believe this enhancement will greatly benefit its community.

I guess you raised the same issue with same words in another repository as well ! Don't mind but I think spamming same issues might conflict with code of conduct of GSSoC.

Rule is that the you can't submit same code in pull request and Auto commit workflow  is different for  repo to repo

@PiyushKalyanpy, do we want this feature?

Yes, we can add an auto comment feature to our project. @lalitmee

I would like to work on this . please assign me this


What does A[spine] mean?

In 03-holes/Main.hs, I wonder how is Γ ⊢ rhs : A[spine] supposed to be understood (in the documentation of inverse). The notation X[something] wasn't introduced in the same file before, so I am a bit confused. I saw this notation being used in other places to mean "something may occur free in X" or to mean "X after substitution with something", but I am not sure what is meant in our case.

The notation is for applying a parallel substitution to something. So t[s] means replacing all free variables in t with corresponding terms in s.
The typing rule for substitution is: when Γ ⊢ t : A and s : Sub Δ Γ, then Δ ⊢ t[s] : A[s]. For example, given x : Nat ⊢ (x, suc zero) : Nat × Nat and (x ↦ zero) : Sub () (x : Nat) then () ⊢ (x, suc zero)[x ↦ zero) : Nat × Nat which is equal to () ⊢ (zero, suc zero) : Nat × Nat.
Instead of (x ↦ zero) : Sub () (x : Nat), we can use the notation () ⊢ (x ↦ zero) : (x : Nat), or in general Γ ⊢ s : Δ for Γ and Δ contexts and s being a mapping from vars to terms.

or in general Γ ⊢ s : Δ for Γ and Δ contexts and s being a mapping from vars to terms

Your example () ⊢ (x ↦ zero) : (x : Nat) is more like Δ ⊢ s : Γ.


[Bug]:  ffmpeg exited with code: error

What happened?
A bug happened!
Plugin Version
v1.0.x (Supported)
HomeBridge Version
v1.3.x (Supported)
NodeJS Version
v14 (Supported)
Operating System
Docker
Relevant log output
Enter this code with your HomeKit app on your iOS device to pair with Homebridge:

    ┌────────────┐
    │ 031-45-155 │
    └────────────┘

Starting to advertise 'Homebridge 17A6 1D7B' using bonjour-hap backend!
[8/26/2021, 4:26:32 PM] Homebridge v1.3.4 (Homebridge 17A6) is running on port 52754.
[8/26/2021, 4:26:32 PM] [Sonos] listening on http://<IP_ADDRESS>:36582/notify
[8/26/2021, 4:26:32 PM] [Sonos] closed http://<IP_ADDRESS>:36582/notify
[8/26/2021, 4:26:32 PM] [Sonos] listening on http://<IP_ADDRESS>:36582/notify
[8/26/2021, 4:26:32 PM] [Sonos] found 1 households
[8/26/2021, 4:26:32 PM] [Sonos] Sonos_UgCRajVo7pjO7Q5VxXAuaKEnYG: RINCON_542A1B61517001400 [Default Room]: associated S2 zoneplayer
[8/26/2021, 4:26:34 PM] [EufySecurity] Entryway looks station but it's not could imply some errors Type: 31
[8/26/2021, 4:26:34 PM] [EufySecurity] Restoring existing accessory from cache: Entryway
[8/26/2021, 4:26:34 PM] [EufySecurity] Entryway has no battery
[8/26/2021, 4:26:34 PM] [EufySecurity] Restoring existing accessory from cache: Entryway
[8/26/2021, 4:26:34 PM] [Sonos] warning: heartbeat 1, drift 408
[8/26/2021, 4:26:34 PM] [Sonos] Sonos_UgCRajVo7pjO7Q5VxXAuaKEnYG: found 1 S2 zone players in 1 zones
[8/26/2021, 4:26:34 PM] [Sonos] └─ Default Room
[8/26/2021, 4:26:34 PM] [Sonos]    └─ RINCON_542A1B61517001400 [Default Room]: SYMFONISK Bookshelf (S21) (master, airPlay)
[8/26/2021, 4:26:34 PM] [Sonos] Default Room Sonos: set Status Fault from 0 to 1
[8/26/2021, 4:26:34 PM] [Sonos] Default Room Sonos: set Status Fault from 1 to 0
[8/26/2021, 4:26:34 PM] [Sonos] Default Room Sonos: get Remaining Duration: return 0s
[8/26/2021, 4:26:37 PM] [Sonos] warning: heartbeat 3, drift 1244
[8/26/2021, 4:29:58 PM] [Sonos] Default Room Sonos: set Track from "Le Click - Tonight Is The Night" to "Gheorghe Gheorghiu - Doi Ochi Caprui"
[8/26/2021, 4:34:00 PM] [Sonos] Default Room Sonos: set Track from "Gheorghe Gheorghiu - Doi Ochi Caprui" to "Alessia feat. Pavel Stratan - Vorbe letale (by Bros Project)"
[8/26/2021, 4:37:48 PM] [Sonos] Default Room Sonos: set Track from "Alessia feat. Pavel Stratan - Vorbe letale (by Bros Project)" to "C-Block - Block"
[8/26/2021, 4:42:51 PM] [Sonos] Default Room Sonos: set Track from "C-Block - Block" to "Modern Talking - You Are Not Alone"
[8/26/2021, 4:44:45 PM] [Sonos] Default Room Sonos: get Remaining Duration: return 0s
[8/26/2021, 4:44:52 PM] [EufySecurity] Entryway fetchSnapshot: No Snapshot found
[8/26/2021, 4:45:03 PM] [EufySecurity] Entryway fetchSnapshot: No Snapshot found
[8/26/2021, 4:47:51 PM] [Sonos] Default Room Sonos: set Track from "Modern Talking - You Are Not Alone" to "Dimitri Vegas & Like Mike - Stay A While (Official Audio)"
[8/26/2021, 4:49:23 PM] [EufySecurity] Entryway fetchSnapshot: No Snapshot found
[8/26/2021, 4:49:34 PM] [EufySecurity] Entryway fetchSnapshot: No Snapshot found
[8/26/2021, 4:49:44 PM] [EufySecurity] Entryway fetchSnapshot: No Snapshot found
[8/26/2021, 4:49:49 PM] [EufySecurity] Starting video stream: 1280 x 720, 30 fps, 299 kbps (AAC-eld) Entryway
[8/26/2021, 4:49:49 PM] [EufySecurity] FFmpeg exited with code: 1 and signal: null (Error) Entryway
[8/26/2021, 4:49:49 PM] [EufySecurity] Stopped video stream. Entryway
[8/26/2021, 4:49:55 PM] [Homebridge UI] [homebridge-eufy-security] Terminating child process...
[8/26/2021, 4:49:55 PM] [Homebridge UI] [homebridge-eufy-security] Child process ended
[8/26/2021, 4:51:17 PM] [Sonos] Default Room Sonos: get Remaining Duration: return 0s
[8/26/2021, 4:51:17 PM] [Sonos] Default Room Sonos: get Remaining Duration: return 0s

With latest update rc.13 stream started to work perfectly! Thx! The only thing for me now which is not quite good is snapshots, it doesn't seem to update properly.


Feature Request: save export settings as file

Sorry if this is already documented somewhere, but I didn't see anything...
For the purposes of a collaborative project, it would be helpful to be able to save the export settings for an automatic export as a file. The resulting bib (yaml, etc) file from an automatic export can have various formats depending on what options were used when exporting. It may be difficult to convey to a collaborator exactly what options to click on/off etc to get the same results. If we could just import a file with all of the settings included it would make that much easier.
For example, I needed to provide a long list of settings here: https://github.com/fernphy/ferncal/pull/8#issue-1314053326

Sorry for not posting the log, here it is: HIHJBF3G-apse

@joelnitta: I haven't tried this yet, but there's now an "Import BetterBibTeX preferences..." button in BBT's "Import" preference tab. You probably need to first export some item with the "BetterBibTeX JSON" translator, which will give you a file that includes all settings, see #1942.
@retorquere: An analogous "Export BetterBibTeX preferences..." button in BBT's "Export" preference tab would be nice, perhaps in the "Miscellaneous" subtab.  This should be more intuitive. When I saw the "Import prefs" button, I looked for an "Export prefs" button, but couldn't find one. I guess it should only export the "config/preferences" data and perhaps "version". Maybe this is already planned, as it's mentioned in the other issue.