fix the reconcile flow

If the tfjob has already terminated, we don't need to check activedeadline and backofflimit.
Originally, even the job has terminated it still checks the Activedeadline and appends the event to it.
So the event that shows the job failed after it succeeded might happen as follow,
the log of tf-operator will also keep showing the failure massage of past Activedeadline
Events:
  Type    Reason                   Age                  From         Message
  ----    ------                   ----                 ----         -------
  Normal  SuccessfulCreatePod      27m                  tf-operator  Created pod: dist-mnist-for-e2e-test-worker-0
  Normal  SuccessfulCreateService  27m                  tf-operator  Created service: dist-mnist-for-e2e-test-worker-0
  Normal  ExitedWithCode           27m                  tf-operator  Pod: default.dist-mnist-for-e2e-test-worker-0 exited with code 0
  Normal  TFJobSucceeded           27m                  tf-operator  TFJob dist-mnist-for-e2e-test successfully completed.
  Normal  TFJobFailed              2m8s (x51 over 27m)  tf-operator  TFJob dist-mnist-for-e2e-test has failed because it was active longer than specified deadline

  {"filename":"record/event.go:221","level":"info","msg":"Event(v1.ObjectReference{Kind:\"TFJob\", Namespace:\"default\", Name:\"dist-mnist-for-e2e-test\", UID:\"a0fca1b0-1a59-11ea-b297-42010af000e3\", APIVersion:\"kubeflow.org/v1\", ResourceVersion:\"49317\", FieldPath:\"\"}): type: 'Normal' reason: 'TFJobFailed' TFJob dist-mnist-for-e2e-test has failed because it was active longer than specified deadline","time":"2019-12-09T08:53:31Z"}

In this MR, I reorder the checking process so if the job has terminated(Succeed, Failed), it will return instead of further reconcile.

This change is

/assign @gaocegege @richardsliu
Can you help me to review the PR?
Thanks!

Travis tests have failed
Hey @ChanYiLin,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
1st Build
View build log

     hack/verify-codegen.sh

Generating deepcopy funcs
Generating clientset for tensorflow:v1 at github.com/kubeflow/tf-operator/pkg/client/clientset
Generating listers for tensorflow:v1 at github.com/kubeflow/tf-operator/pkg/client/listers
Generating informers for tensorflow:v1 at github.com/kubeflow/tf-operator/pkg/client/informers
Generating defaulters for tensorflow/v1
Generating OpenAPI specification for tensorflow/v1
diffing hack/../pkg against freshly generated codegen
diff -Naupr hack/../pkg/apis/tensorflow/v1/openapi_generated.go hack/../_tmp/pkg/apis/tensorflow/v1/openapi_generated.go
--- hack/../pkg/apis/tensorflow/v1/openapi_generated.go	2019-12-09 10:23:39.679629679 +0000
+++ hack/../_tmp/pkg/apis/tensorflow/v1/openapi_generated.go	2019-12-09 10:22:33.000000000 +0000
@@ -125,14 +125,14 @@ func GetOpenAPIDefinitions(ref common.Re
 					Properties: map[string]spec.Schema{
 						"activeDeadlineSeconds": {
 							SchemaProps: spec.SchemaProps{
-								Description: "Specifies the duration (in seconds) since startTime during which the job can remain active before it is terminated. Must be a positive integer.",
+								Description: "Specifies the duration (in seconds) since startTime during which the job can remain active before it is terminated. Must be a positive integer. This setting applies only to pods where restartPolicy is OnFailure or Always.",
 								Type:        []string{"integer"},
 								Format:      "int64",
 							},
 						},
 						"backoffLimit": {
 							SchemaProps: spec.SchemaProps{
-								Description: "Number of retries before marking this job as failed. This setting applies only to pods where restartPolicy is OnFailure or Always.",
+								Description: "Number of retries before marking this job as failed.",
 								Type:        []string{"integer"},
 								Format:      "int32",
 							},
hack/../pkg is out of date. Please run hack/update-codegen.sh

     goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/*.go,pkg/util/*/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"

=== RUN   TestSetTypeNames
--- PASS: TestSetTypeNames (0.00s)
=== RUN   TestSetDefaultTFJob
--- PASS: TestSetDefaultTFJob (0.00s)
=== RUN   TestIsChieforMaster
--- PASS: TestIsChieforMaster (0.00s)
PASS
coverage: 27.7% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/listers/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/common/jobcontroller, github.com/kubeflow/tf-operator/pkg/common/util/v1/testutil, github.com/kubeflow/tf-operator/pkg/common/util/v1/unstructured, github.com/kubeflow/tf-operator/pkg/control, github.com/kubeflow/tf-operator/pkg/controller.v1/tensorflow, github.com/kubeflow/tf-operator/pkg/logger, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1	0.044s	coverage: 27.7% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/listers/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/common/jobcontroller, github.com/kubeflow/tf-operator/pkg/common/util/v1/testutil, github.com/kubeflow/tf-operator/pkg/common/util/v1/unstructured, github.com/kubeflow/tf-operator/pkg/control, github.com/kubeflow/tf-operator/pkg/controller.v1/tensorflow, github.com/kubeflow/tf-operator/pkg/logger, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/version
=== RUN   TestValidateV1TFJobSpec
time="2019-12-09T10:26:01Z" level=error msg="TFJobSpec is not valid: Image is undefined in the container of Worker"
time="2019-12-09T10:26:01Z" level=error msg="TFJobSpec is not valid: There is no container named tensorflow in Worker"
--- PASS: TestValidateV1TFJobSpec (0.00s)
PASS
coverage: 20.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/listers/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/common/jobcontroller, github.com/kubeflow/tf-operator/pkg/common/util/v1/testutil, github.com/kubeflow/tf-operator/pkg/common/util/v1/unstructured, github.com/kubeflow/tf-operator/pkg/control, github.com/kubeflow/tf-operator/pkg/controller.v1/tensorflow, github.com/kubeflow/tf-operator/pkg/logger, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation	0.046s	coverage: 20.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/listers/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/common/jobcontroller, github.com/kubeflow/tf-operator/pkg/common/util/v1/testutil, github.com/kubeflow/tf-operator/pkg/common/util/v1/unstructured, github.com/kubeflow/tf-operator/pkg/control, github.com/kubeflow/tf-operator/pkg/controller.v1/tensorflow, github.com/kubeflow/tf-operator/pkg/logger, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/version
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow/v1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/tensorflow/v1	[no test files]
=== RUN   TestGenGeneralName
--- PASS: TestGenGeneralName (0.00s)
PASS
coverage: 0.5% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/listers/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/common/jobcontroller, github.com/kubeflow/tf-operator/pkg/common/util/v1/testutil, github.com/kubeflow/tf-operator/pkg/common/util/v1/unstructured, github.com/kubeflow/tf-operator/pkg/control, github.com/kubeflow/tf-operator/pkg/controller.v1/tensorflow, github.com/kubeflow/tf-operator/pkg/logger, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/common/jobcontroller	0.023s	coverage: 0.5% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/listers/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/common/jobcontroller, github.com/kubeflow/tf-operator/pkg/common/util/v1/testutil, github.com/kubeflow/tf-operator/pkg/common/util/v1/unstructured, github.com/kubeflow/tf-operator/pkg/control, github.com/kubeflow/tf-operator/pkg/controller.v1/tensorflow, github.com/kubeflow/tf-operator/pkg/logger, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/version
?   	github.com/kubeflow/tf-operator/pkg/common/util/v1/testutil	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/common/util/v1/unstructured	[no test files]
=== RUN   TestCreatePods
--- PASS: TestCreatePods (0.01s)
=== RUN   TestCreateService
time="2019-12-09T10:26:34Z" level=info msg="Controller test-tfjob created service empty_service"
--- PASS: TestCreateService (0.00s)
=== RUN   TestCreateServicesWithControllerRef
time="2019-12-09T10:26:34Z" level=info msg="Controller test-tfjob created service empty_service"
--- PASS: TestCreateServicesWithControllerRef (0.00s)
=== RUN   TestClaimServices
--- PASS: TestClaimServices (0.00s)
PASS
coverage: 24.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/listers/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/common/jobcontroller, github.com/kubeflow/tf-operator/pkg/common/util/v1/testutil, github.com/kubeflow/tf-operator/pkg/common/util/v1/unstructured, github.com/kubeflow/tf-operator/pkg/control, github.com/kubeflow/tf-operator/pkg/controller.v1/tensorflow, github.com/kubeflow/tf-operator/pkg/logger, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/control	0.068s	coverage: 24.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/tensorflow/v1/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/client/listers/tensorflow/v1, github.com/kubeflow/tf-operator/pkg/common/jobcontroller, github.com/kubeflow/tf-operator/pkg/common/util/v1/testutil, github.com/kubeflow/tf-operator/pkg/common/util/v1/unstructured, github.com/kubeflow/tf-operator/pkg/control, github.com/kubeflow/tf-operator/pkg/controller.v1/tensorflow, github.com/kubeflow/tf-operator/pkg/logger, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/version
=== RUN   TestNormalPath
time="2019-12-09T10:26:41Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:41Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:41Z" level=info msg="Reconcile TFJobs test-tfjob" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: worker-0" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=Worker expected=1, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: worker-0" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (4.214056ms)" job=default.test-tfjob
time="2019-12-09T10:26:41Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:41Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:41Z" level=info msg="Reconcile TFJobs test-tfjob" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: ps-0" job=default.test-tfjob replica-type=ps uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: ps-1" job=default.test-tfjob replica-type=ps uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=PS expected=2, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: ps-0" job=default.test-tfjob replica-type=ps uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: ps-1" job=default.test-tfjob replica-type=ps uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: worker-0" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: worker-1" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: worker-2" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: worker-3" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=Worker expected=4, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: worker-0" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: worker-1" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: worker-2" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: worker-3" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (1.270164ms)" job=default.test-tfjob
time="2019-12-09T10:26:41Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:41Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:41Z" level=info msg="Reconcile TFJobs test-tfjob" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=PS expected=2, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=Worker expected=4, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (611.509µs)" job=default.test-tfjob
time="2019-12-09T10:26:41Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:41Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:41Z" level=info msg="Reconcile TFJobs test-tfjob" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: ps-1" job=default.test-tfjob replica-type=ps uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=PS expected=2, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: ps-1" job=default.test-tfjob replica-type=ps uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: worker-2" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: worker-3" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=Worker expected=4, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: worker-2" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: worker-3" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (673.01µs)" job=default.test-tfjob
time="2019-12-09T10:26:41Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:41Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:41Z" level=info msg="Reconcile TFJobs test-tfjob" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="Ignoring inactive pod default/worker-2 in state Succeeded, deletion time <nil>"
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: ps-1" job=default.test-tfjob replica-type=ps uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=PS expected=2, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: ps-1" job=default.test-tfjob replica-type=ps uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: worker-3" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=Worker expected=3, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: worker-3" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (1.478247ms)" job=default.test-tfjob
time="2019-12-09T10:26:41Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:41Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:41Z" level=info msg="Reconcile TFJobs test-tfjob" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=PS expected=2, running=2, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=Worker expected=4, running=4, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (588.495µs)" job=default.test-tfjob
time="2019-12-09T10:26:41Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:41Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:41Z" level=info msg="Reconcile TFJobs test-tfjob" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: ps-1" job=default.test-tfjob replica-type=ps uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=PS expected=2, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: ps-1" job=default.test-tfjob replica-type=ps uid=
time="2019-12-09T10:26:41Z" level=info msg="Need to create new pod: worker-3" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=Worker expected=4, running=1, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="need to create new service: worker-3" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:41Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (1.102501ms)" job=default.test-tfjob
time="2019-12-09T10:26:41Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:41Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:41Z" level=info msg="Reconcile TFJobs test-tfjob" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="Ignoring inactive pod default/ps-1 in state Succeeded, deletion time <nil>"
time="2019-12-09T10:26:41Z" level=info msg="Ignoring inactive pod default/worker-0 in state Succeeded, deletion time <nil>"
time="2019-12-09T10:26:41Z" level=info msg="Ignoring inactive pod default/worker-1 in state Succeeded, deletion time <nil>"
time="2019-12-09T10:26:41Z" level=info msg="Ignoring inactive pod default/worker-2 in state Succeeded, deletion time <nil>"
time="2019-12-09T10:26:41Z" level=info msg="Ignoring inactive pod default/worker-3 in state Succeeded, deletion time <nil>"
time="2019-12-09T10:26:41Z" level=info msg="Ignoring inactive pod default/ps-0 in state Succeeded, deletion time <nil>"
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=PS expected=0, running=0, failed=0" job=default.test-tfjob uid=
time="2019-12-09T10:26:41Z" level=info msg="TFJob=test-tfjob, ReplicaType=Worker expected=0, running=0, failed=0" job=default.test-tfjob uid=
E1209 10:26:41.662494   10390 event.go:259] Could not construct reference to: '&v1.TFJob{TypeMeta:v1.TypeMeta{Kind:"TFJob", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"test-tfjob", GenerateName:"", Namespace:"default", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Spec:v1.TFJobSpec{ActiveDeadlineSeconds:(*int64)(nil), BackoffLimit:(*int32)(nil), CleanPodPolicy:(*v1.CleanPodPolicy)(0xc0006e3460), TTLSecondsAfterFinished:(*int32)(nil), TFReplicaSpecs:map[v1.TFReplicaType]*v1.ReplicaSpec{"PS":(*v1.ReplicaSpec)(0xc00070a840), "Worker":(*v1.ReplicaSpec)(0xc00070ab00)}}, Status:v1.JobStatus{Conditions:[]v1.JobCondition(nil), ReplicaStatuses:map[v1.ReplicaType]*v1.ReplicaStatus{"PS":(*v1.ReplicaStatus)(0xc0003c2510), "Worker":(*v1.ReplicaStatus)(0xc0003c25c0)}, StartTime:(*v1.Time)(0xc0007161a0), CompletionTime:(*v1.Time)(nil), LastReconcileTime:(*v1.Time)(nil)}}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Normal' 'TFJobSucceeded' 'TFJob test-tfjob successfully completed.'
time="2019-12-09T10:26:41Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (3.642967ms)" job=default.test-tfjob
--- PASS: TestNormalPath (0.03s)
=== RUN   TestRun
time="2019-12-09T10:26:41Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:41Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:41Z" level=info msg="Starting TFJob controller"
time="2019-12-09T10:26:41Z" level=info msg="Waiting for informer caches to sync"
time="2019-12-09T10:26:41Z" level=info msg="Starting 1 workers"
time="2019-12-09T10:26:41Z" level=info msg="Started workers"
time="2019-12-09T10:26:42Z" level=info msg="Shutting down workers"
--- PASS: TestRun (0.50s)
=== RUN   TestAddTFJob
time="2019-12-09T10:26:42Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:42Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:42Z" level=info msg="Starting TFJob controller"
time="2019-12-09T10:26:42Z" level=info msg="Waiting for informer caches to sync"
time="2019-12-09T10:26:42Z" level=info msg="TFJob test-tfjob is created."  Not counted in backoff limit." job=default.test-tfjob uid=
time="2019-12-09T10:26:46Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (611.912µs)" job=default.test-tfjob
--- PASS: TestBackoffForOnFailure (0.00s)
=== RUN   TestAddPod
time="2019-12-09T10:26:46Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:46Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:46Z" level=info msg="Starting TFJob controller"
time="2019-12-09T10:26:46Z" level=info msg="Waiting for informer caches to sync"
time="2019-12-09T10:26:46Z" level=info msg="Starting 1 workers"
time="2019-12-09T10:26:46Z" level=info msg="Started workers"
--- PASS: TestAddPod (0.10s)
=== RUN   TestClusterSpec
--- PASS: TestClusterSpec (0.00s)
=== RUN   TestIsDistributed
--- PASS: TestIsDistributed (0.00s)
time="2019-12-09T10:26:46Z" level=info msg="Shutting down workers"
=== RUN   TestRestartPolicy
--- PASS: TestRestartPolicy (0.00s)
=== RUN   TestExitCode
time="2019-12-09T10:26:46Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:46Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:46Z" level=info msg="Starting TFJob controller"
time="2019-12-09T10:26:46Z" level=info msg="Waiting for informer caches to sync"
time="2019-12-09T10:26:46Z" level=info msg="Reconcile TFJobs test-tfjob" job=default.test-tfjob uid=
time="2019-12-09T10:26:46Z" level=info msg="Ignoring inactive pod default/worker-0 in state Failed, deletion time <nil>"
time="2019-12-09T10:26:46Z" level=info msg="Pod: default.worker-0 exited with code 130" job=default.test-tfjob replica-type=worker uid=
E1209 10:26:46.398240   10390 event.go:259] Could not construct reference to: '&v1.TFJob{TypeMeta:v1.TypeMeta{Kind:"TFJob", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"test-tfjob", GenerateName:"", Namespace:"default", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Spec:v1.TFJobSpec{ActiveDeadlineSeconds:(*int64)(nil), BackoffLimit:(*int32)(nil), CleanPodPolicy:(*v1.CleanPodPolicy)(0xc000414b70), TTLSecondsAfterFinished:(*int32)(nil), TFReplicaSpecs:map[v1.TFReplicaType]*v1.ReplicaSpec{"Worker":(*v1.ReplicaSpec)(0xc000235080)}}, Status:v1.JobStatus{Conditions:[]v1.JobCondition(nil), ReplicaStatuses:map[v1.ReplicaType]*v1.ReplicaStatus{"Worker":(*v1.ReplicaStatus)(0xc000409f00)}, StartTime:(*v1.Time)(nil), CompletionTime:(*v1.Time)(nil), LastReconcileTime:(*v1.Time)(nil)}}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Normal' 'ExitedWithCode' 'Pod: default.worker-0 exited with code 130'
time="2019-12-09T10:26:46Z" level=info msg="Need to restart the pod: default.worker-0" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:46Z" level=info msg="TFJob=test-tfjob, ReplicaType=Worker expected=1, running=0, failed=1" job=default.test-tfjob uid=
E1209 10:26:46.398365   10390 event.go:259] Could not construct reference to: '&v1.TFJob{TypeMeta:v1.TypeMeta{Kind:"TFJob", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"test-tfjob", GenerateName:"", Namespace:"default", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Spec:v1.TFJobSpec{ActiveDeadlineSeconds:(*int64)(nil), BackoffLimit:(*int32)(nil), CleanPodPolicy:(*v1.CleanPodPolicy)(0xc000414b70), TTLSecondsAfterFinished:(*int32)(nil), TFReplicaSpecs:map[v1.TFReplicaType]*v1.ReplicaSpec{"Worker":(*v1.ReplicaSpec)(0xc000235080)}}, Status:v1.JobStatus{Conditions:[]v1.JobCondition(nil), ReplicaStatuses:map[v1.ReplicaType]*v1.ReplicaStatus{"Worker":(*v1.ReplicaStatus)(0xc000409f00)}, StartTime:(*v1.Time)(0xc0006dece0), CompletionTime:(*v1.Time)(nil), LastReconcileTime:(*v1.Time)(nil)}}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Warning' 'TFJobRestarting' 'TFJob test-tfjob is restarting because 1 Worker replica(s) failed.'
time="2019-12-09T10:26:46Z" level=info msg="need to create new service: worker-0" job=default.test-tfjob replica-type=worker uid=
time="2019-12-09T10:26:46Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (531.426µs)" job=default.test-tfjob
--- PASS: TestExitCode (0.00s)
=== RUN   TestAddService
time="2019-12-09T10:26:46Z" level=info msg="Starting 1 workers"
time="2019-12-09T10:26:46Z" level=info msg="Started workers"
time="2019-12-09T10:26:46Z" level=info msg="Shutting down workers"
time="2019-12-09T10:26:46Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:46Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:46Z" level=info msg="Starting TFJob controller"
time="2019-12-09T10:26:46Z" level=info msg="Waiting for informer caches to sync"
time="2019-12-09T10:26:46Z" level=info msg="Starting 1 workers"
time="2019-12-09T10:26:46Z" level=info msg="Started workers"
--- PASS: TestAddService (0.10s)
=== RUN   TestFailed
time="2019-12-09T10:26:46Z" level=info msg="Shutting down workers"
time="2019-12-09T10:26:46Z" level=info msg="Creating TFJob controller"
time="2019-12-09T10:26:46Z" level=info msg="Creating Job controller"
time="2019-12-09T10:26:46Z" level=info msg="TFJob=test-tfjob, ReplicaType=Worker expected=3, running=0, failed=1" job=default.test-tfjob uid=
E1209 10:26:46.502398   10390 event.go:259] Could not construct reference to: '&v1.TFJob{TypeMeta:v1.TypeMeta{Kind:"TFJob", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"test-tfjob", GenerateName:"", Namespace:"default", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Spec:v1.TFJobSpec{ActiveDeadlineSeconds:(*int64)(nil), BackoffLimit:(*int32)(nil), CleanPodPolicy:(*v1.CleanPodPolicy)(0xc0006e3e90), TTLSecondsAfterFinished:(*int32)(nil), TFReplicaSpecs:map[v1.TFReplicaType]*v1.ReplicaSpec{"Worker":(*v1.ReplicaSpec)(0xc0000f0580)}}, Status:v1.JobStatus{Conditions:[]v1.JobCondition(nil), ReplicaStatuses:map[v1.ReplicaType]*v1.ReplicaStatus{"Worker":(*v1.ReplicaStatus)(0xc00035c960)}, StartTime:(*v1.Time)(0xc000698940), CompletionTime:(*v1.Time)(nil), LastReconcileTime:(*v1.Time)(nil)}}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Normal' 'TFJobFailed' 'TFJob test-tfjob has failed because 1 Worker replica(s) failed.'

Hey @ChanYiLin,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 18b88040-1a72-11ea-8ac4-55ffd8dc6fb9

/retest

Could you please update pytorch-operator, too?

Could you please update pytorch-operator, too?

Sure, no problem!

Hey @ChanYiLin,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 52f49570-1af2-11ea-b9ce-6f43500ed087

Hey @ChanYiLin,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: d26bab50-1af6-11ea-b9ce-6f43500ed087

Since there is no more reconcile after completion, does it also solve #965?

I think so.

Since there is no more reconcile after completion, does it also solve #965?

Yes, by moving isSucceeded(tfjob.Status) || isFailed(tfjob.Status) to the top
this PR avoid checking the backofflimit and activedeadline for those complete job and preventing the events being appended to the job.
The complete job will only do the cleanup process(if set to cleanup) then return nil(if no status update)
I think it can help to improve the performance the issue mentioned.

Does it improve the performance issue in #965?  After a relook, It looks like the the return conditions are exactly same as before. Cleanup check will happen for every reconcile call(before and after the changes) and if job status hasn't changed, the control returns instead of further reconcile(before and after the changes)
However, this PR will solve  the specific ActiveDeadline events issue that is raised as successful/failed check happens before ActiveDeadline check.
I can merge this unless you have some thoughts on it.

@johnugeorge  Yes you can merge this PR first, I think this is enough for this PR. Also I can create the same PR to the pytorch-operator then. Thanks!
For the performance issue, we can discuss in #965 . However this PR indeed prevent checking backofflimit and activedeadline for those complete jobs which might have some help.

Great. Thanks @ChanYiLin
/approve


[Question]

I noticed that the adhan-dart is giving plus 1hr for Asr time. For example I was expecting to give 17:15 instead of 18:15.
Do you know why?
final params = CalculationMethod.karachi.getParameters();
params.madhab = Madhab.hanafi;
prayerTimes = PrayerTimes.today(myCoordinates, params,   utcOffset: _dateTime.timeZoneOffset);

Assalamualaikum,
You might want to change the Madhab. as Asr calculations vary much by Madhab.
Another thing to keep in mind: If you want the PrayerTime result in your device timezone then don't pass utc-offset.
Thanks.

That fix it. Many thanks @iamriajul !


The "Dock Tile Timeout" setting not applied in macOS 14 Sonoma beta 4

In macOS 14 Sonoma beta 4, "Toggle privileges" from the Dock menu (Control + Click) always toggles the privileges after 20 minutes, no matter what value I choose from Settings --> Dock Tile Timeout menu.

Yes, that's an issue we are currently working on with Apple. Unfortunately it's nothing we can fix on our end but we are confident that the problem will be fixed by Apple.

I have same issue with Ventura 13.5.1 is this expected?
I tried manually setting the time out and doing through profile but it just doesn't seem to bring user back to standard

I'm seeing this as well no timers are working since 13.5.1 and I just updated to 13.6 and it's still not working.

I am on 13.5.2 and I am seeing issues persists. I do not see anything that indicates DockToggleTimeout.

Hello, I have the same issue. The TImeOut (distributed through a Configuration profile) is not enforced anymore. This is a serious problem.

Hi, on sonoma 14.3 i have the same issue.


hasPaymentMethod() return false even if the user have several payment methods available

Cashier Version: 10.5.1
Laravel Version: 7.2.0
PHP Version: 7.3.9
Database Driver & Version: Mysql

Description:
hasPaymentMethod() return false even if the user have several payment methods available
Steps To Reproduce:
use addPaymentMethod() to add one or more payment methods
then call hasPaymentMethod()
It will return false even if the user have several payment methods
public function hasPaymentMethod()
{
return (bool) $this->card_brand;
}
and if card_brand have never been updated, then it will always return false

hasPaymentMethod determines if the Billable model has a default payment method. You'll need to add a default payment method first.

Also: if you have your webhooks properly set up it'll always keep your default payment method in sync through the customer.updated event.

yes, but if the user don't have any of his payment methods marked as default, then it will not help
and the method is called hasPaymentMethod(), not hasDefaultPaymentMethod()

@rabol the reason for this is that Cashier v10.x is the first version that supports multiple payment methods so this method wasn't renamed properly. I'll send in a PR to deprecate the current method and implement a new one.

Calling addPaymentMethod() should update the 'card_brand' field

Definitely not. That's only for the default payment method.

Send in a PR for this here: https://github.com/laravel/cashier/pull/838


How to make this script fast ?

Downloading 100 images take about 10 minutes on a fast internet connection, any idea how to make it fast ? thanks

To be honest being a scraper the script is kinda fast.
I think the problem is related to your setup, because for 100 images doesn't take more than 1-2 minutes in my case.

@lorenzo how you doing it ?

Hi! Everything fine! You?
Lorenzo
Il giorno 1 ott 2019, alle ore 01:20, whatneuron <notifications<EMAIL_ADDRESS>ha scritto:
@lorenzohttps://github.com/lorenzo how you doing it ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/hardikvasa/google-images-download/issues/269?email_source=notifications&email_token=AKISYG7MXK7KQUM32LCJT53QMKCTBA5CNFSM4IY5OJC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD77MT2A#issuecomment-536791528, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKISYG7Q44QVRXS3XQDZUI3QMKCTBANCNFSM4IY5OJCQ.

great, can i see your implementation of code as it's slow for me

AFIK: Try thumbnails only as they're pulled from google directly. Where as the full images are dependent on the actual websites you're pulling from.


Code for Array rotation

Sorry for putting so much PR's. This is my first time in Open-source and I really want to work it out. Thank you.

I've made the necessary changes. You can check now


Something wrong with "Running locally" instruction.

h:\node - directory with node-v12.18.0-win-x64.
h:\factorio-lab - this repository.
versions:
h:\factorio-lab>node -v
v12.18.0

h:\factorio-lab>npm version
{
  'factorio-lab': '1.1.7',
  npm: '6.14.4',
  ares: '1.16.0',
  brotli: '1.0.7',
  cldr: '37.0',
  http_parser: '2.9.3',
  icu: '67.1',
  llhttp: '2.0.4',
  modules: '72',
  napi: '6',
  nghttp2: '1.41.0',
  node: '12.18.0',
  openssl: '1.1.1g',
  tz: '2019c',
  unicode: '13.0',
  uv: '1.37.0',
  v8: '7.8.279.23-node.37',
  zlib: '1.2.11'
}

Install angular/cli:
h:\factorio-lab>npm install -g @angular/cli
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
H:\node\ng -> H:\node\node_modules\@angular\cli\bin\ng

><EMAIL_ADDRESS>postinstall H:\node\node_modules\@angular\cli
> node ./bin/postinstall/script.js

+<EMAIL_ADDRESS>added 271 packages from 206 contributors in 7.647s

It's okay for now. Try to start:
h:\factorio-lab>npm start

><EMAIL_ADDRESS>start h:\factorio-lab
> ng serve

An unhandled exception occurred: Cannot find module<EMAIL_ADDRESS>
... cutted lot of bugs ...

Looks like I left out the step to run npm ci or npm install before running npm start.


Same Name, overwrite - incomplete downloads

First of all, Thank you for this amazing tool..
Second.. I have a folder with about 350 gig of .lynda files in it  (on a laptop 760gig drive)
and i'm not even close to being done.. lol .. but I freed up a 1 TB, copied everything over & SQLite file..
(from what i have read, it looks like they changed things up).. i have been holding these files for a couple months.. this project got put on hold.. i also saved a copy of the extracted Desktop App that I can use without using the download one everytime.. so i do have an old(er) version if that matters.
background.. 16yrs PHP and all front-end tech, Python, VB.NET, some C++.. the only C# is changing existing scripts, never studied it tho.. (which came in handy here)..
i am running from a batch file, here it is:
thanksLynda.bat (lol)
@ECHO OFF

PUSHD "D:\d"

ECHO Current dir: "%CD%"

LyndaDecryptor /D "D:\ldc_courses" /OUT "D:\ldc_converted" /DB "D:\db\db.sqlite"

PAUSE

PUSHD "D:\"

so let me begin with 2 or 3 problems I have found:
(I am compiling w/ Visual Studio Enterprise 2015)
* Yes, there are names that are the same, as i found out the hard way

as you can see, what I did was add,
* Decryptor.cs *
var courseID = "[" + CleanPath(videoInfo.CourseID) + "]";
newPath = Path.Combine(OutputDirectory.FullName, courseID + "___" + CleanPath(videoInfo.CourseTitle), ....
(for simpleTitle & complexTitle)

I found this out because I was seeing the:
[DEC] File " + decryptedFilePath + " exists already but seems to differ in size...
so i added some Console.ReadKey(); and i kept deleting the done ones, then made a test folder & ran from there, narrowed it down. but honestly it has made it easier for me to also have the CourseID (as I have ALOT of videos & I wanna keep track)
that fixed that issue.. :+1:
* I know some of the courses haven't finished downloading yet,  (maybe 5%), (sorry, i know..)
i am on a different 8 core sooo.. trying to make due without restarting downloading and finishing all of them yet. I downloaded these on my programming machine and if your like me, you run outta room very quickly.
the next problem is:

System.ArgumentException: Illegal characters in path.
it's as close to the root path as I can get, no spaces in path names, the names from Lynda should be safe, so I don't get it..  i am not sure if once the program gets to a folder that hasn't been downloaded all the way, if that's what creates the error?
But I have been stumped.. I have tried looking up C# - ArgumentException, Exceptions.. if you seen what my code is turning into, you would laugh at me.. I have tried all these (together)
WriteToConsole("[TJ01] e.ToString: " + e.ToString() + Environment.NewLine + Environment.NewLine, ConsoleColor.Red);
WriteToConsole("[TJ02] e.Message: " + e.Message + Environment.NewLine + Environment.NewLine, ConsoleColor.Red);
WriteToConsole("[TJ03] e.Source.ToString: " + e.Source.ToString() + Environment.NewLine + Environment.NewLine, ConsoleColor.Red);
throw new Exception(e.Message);

So to summarize.. I am not sure if this error is caused from half downloaded files (which by the way I been running the program, removing the folder of the CourseID it fails at, then re-run.. done that 20 or so times so far) or if there is a possibility of some illegal character in the path or filename, but I noticed you created a function for that  CleanPath( ) and Decryptor( ) => InvalidPathCharacters function, but i doubt that is what it is..
How or what code can I add to "step over" unfinished download and/or path character error ??
any help would be greatly appreciated.. or if anyone experienced anything similar ?

no response, no help in 4 days?

Just as an update.. thank you for all the overwhelming comments..  👎
I fixed all my own issues.. and continued on for an amazing 680GIG of awesomeness.. now i study all the time.
just one question for the author.. how did you come up with the key? i tried changing 1 semicolon to a period and that rendered the video useless.. so however you did it, its THE only one that would work.. my question is how did you come across that?

You need to reverse-engineer the official client, and it's just written inside. Pretty much the same way one can tell that a has of the video number is used to get the caption filename.

(finally someone exists.. lol)..
Thank you.. I will have to remember that.. and that sounds about right about looking inside.. I'm surprised when they push an update they dont change it. thanks again..

@Dev-iL ,  📫
Thanks for the reply.. its been awhile.. been programming & learning.
Anyways, a year later I needed this again & i wanted to read my old issue so its easier to make changes to the newer ver. & I remember the key I asked about.. I thought there was another way.. so i glanced.. low & behold
DesktopLdc -> Lynda -> Resources -> Settings
I dont want to list it here, 'someone', from 'somewhere' might be doing a huge elastic search.. lol
but it's separated into 2 parts..  I was asking before in case it changed & the author disappeared.. I see he hasn't updated the new extension..
What do you think the APP_KEY & the SECRET_KEY are for? anything useful?  😜


Add CommitID to CreateMergeRequestDiscussionOptions

While not explicitly stated in the documentation [1] the commit_id field
must be specified when creating a MR discussion (aka thread) with comments
on a commit.
Add a CommitID to the CreateMergeRequestDiscussionOptions struct.
[1] https://docs.gitlab.com/ee/api/discussions.html#create-new-merge-request-thread
Signed-off-by: Prarit Bhargava<EMAIL_ADDRESS>

I hate to ask but ... after this is merged can you also do a release?  TIA

Released v0.51.0


Run litmus test suite on travis

I noticed that litmus is failing on the master branch but we did not notice which changeset broke it as travis is not executing the litmus test suite.
So I'm adding a script to install litmus and modified the .travis.yml file in order to run it before running the test.

@pokoli regarding the test fail, see how to allow sudo usage on travis: https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments

@tomviner thanks for your feedback!

Ok, so everything is good now, the build is failing because the litmus test suite is not passing.
I thank that the litmus test suite must be fixed before merging this PR.

The third test seems to fail because litmus is not configured for SSL support:

begin................. FAIL (No SSL support, reconfigure using --with-ssl)

@mar10 thanks for the input. Travis is green now, let met know if you want me to rebase (and squash) this PR before merging.

I rebased all the commits into a single one.

Great!


ideas, improving the resource selection process by calculating relevance scores

Problem: The wizard returns too many resources.
Current behaviour (should be)
Answers: label_A label_B label_C
In the database:
Resource1: {label_A, label_B} {relatesto: N/A}
Resource2:(label_B} {relatesto: Resource3}
Resource3:(lables:N/A)
Resource4:{relatesto:Resource3}
All four resources will be returned because R1,R2 has matching labels, and R3, R4 links to R2. though R4 might not be related.
One possible solution is to calculate a relevance score = matched labels + related resource.
For example, a resource can only be selected if it has more than one piece of evidence (>=2 matching labels, or one matching label + 1 relationshipInfo, 2 relationship info)
Also, there should be a cap on how many levels of relationships. For example R4 is not selected because it doesn’t have a direct relationship with R2

Currently we only return label matched resources. We will include first degree relationships in next. We have to come up with a scoring criteria + cut off mark or exact inclusion rules ( can start with >=2 matching labels, or one matching label + 1 relationshipInfo, 2 relationship info)

is after #21


In geolocation event handler view bounds are calculated incorectly

In Map._handleGeolocationResponse value of Coordinates.accuracy is interpreted as diameter of "confidence circle", but it should be radius.
Error is at line https://github.com/Leaflet/Leaflet/blob/master/src/map/Map.js#L659:
bounds = latlng.toBounds(pos.coords.accuracy),
LatLng.toBounds according to manual:

Returns a new LatLngBounds object in which each boundary is sizeInMeters/2 meters apart from the LatLng.

But after reading the definition of Coordinates.accuracy  from MDN https://developer.mozilla.org/en-US/docs/Web/API/Coordinates/accuracy

The Coordinates.accuracy read-only property is a strictly positive double representing the accuracy, with a 95% confidence level, of the Coordinates.latitude and Coordinates.longitude properties expressed in meters.

and accuracy term in wikipedia https://en.wikipedia.org/wiki/Accuracy_and_precision I'm sure Coordinates.accuracy should be the radius of "confidence circle"
I attached demo illustrating wrong behavior of Map._handleGeolocationResponse:
https://jsfiddle.net/4zjLzqv1/
Here blue circle radius equals Coordinates.accuracy and red circle radius equals Coordinates.accuracy / 2.
Blue circle is larger then view bounds and can be seen only when zoomed out one step.
Conclusion:
Line https://github.com/Leaflet/Leaflet/blob/master/src/map/Map.js#L659 should be
bounds = latlng.toBounds(pos.coords.accuracy * 2),
Error was introduced in first commit of geolocation support:
https://github.com/Leaflet/Leaflet/blame/e87e010e7ddb4acec5088362a43f5e9227e0a9eb/src/map/ext/Map.Geolocation.js#L63

Sounds like an easy fix. Care to send a pull request?

+1

#6140

Fixed by #6140


Correct path in gcc build scripts

This corresponds to https://github.com/redox-os/gcc/pull/4.
The Arch build seems to work. I haven't tested Debian.

Thanks!


Releasenotes logic fails if a release note is deleted in a PR (likely a revert)

Bug Description
The release notes tests fails to find the realeasenote which is deleted in a PR to check it's schema and then the test fails.
Does it make sense to ignore file deletions in the release notes directory?
Version
main branch

Additional Information
ex:  gh pr view https://github.com/istio/istio/pull/38826 --json files lists all file changes including deletions. The logic iterates over the file list for files in the releasenotes directory checking their schema. In the case that a file is deleted, the schema check returns a failure.
We could check that a file exists before calling the schema validator (or ignore the exit code for the file not existing being returned).

Fixed by https://github.com/istio/tools/pull/1981 and https://github.com/istio/test-infra/pull/4038

Fixed by previously noted PRs.


[Getting Started] Update outputs to match OpenCilk/tutorial updates

Addresses #172.
This PR updates the Getting Started page (specifically the example program outputs) to match the updates proposed in https://github.com/OpenCilk/tutorial/pull/1.

@behoppe The OpenCilk/tutorial#1 PR just got merged.  When you get a chance, could you please review the Getting Started page changes in this PR and merge it if things look good?

@ailiop it looks good. I do see that there are some dummy links (which were formerly dead links) that never got connected to the proper Cilkscale/Cilksan pages. I will make a quick change on that separately from this PR.


Split RS232 and ESP code

I have a server that is running right next to the inverter, it would be really nice to be able to connect the serial port directly to it using something like https://gitlab.com/Teuniz/RS-232.
Splitting the code into separate classes would definitely help to implement that, among other advantages.

Thanks for suggestion.
I wanted to avoid coupling any other external device (orangepi, raspberrypi).
The inverter is quite noisy in RF spectrum and may cause these devices to work less stable.
Especially with the common ground.
I guess we have a lot of other options to communicate over modbus from linux machine.

Thank you for the fast reply.
My idea was to put at least one filtering capacitor between inverter and computer, but the devices cannot be fully decoupled. An ESP8266 can be sacrificed in case something goes wrong as it's very cheap, a high-end server on the other hand...
I think I'll design a PCB on EasyEDA.

I completed both schematic and PCB, here's a preview of the latter:

Pictures

Components

 Name
  Part
  LCSC part

 C1, C2
  GRM21BR61E226ME44L
  C86816

 C3, C4
  GRM21BR60J476ME15L
  C77072

 C5
  GRM155R71H332KA01D
  C85963

 C6, C7, C8, C9
  GRM155R71C104KA88D
  C71629

 ESP32
  ESP32-C3-WROOM-02U-N4
  C2926676

 ESP32_BOOT
  TSG002A05018A
  C2888616

 ESP32_UART
  PZ254V-11-04P
  C492403

 L1, L2
  DFE252012F-1R0M=P2
  C435392

 PSU
  TPS62180YZFT
  C73980

 R1, R3
  CRCW0402470KFKED
  C482181

 R2
  0402WGF1503TCE
  C25755

 RS232
  R-RJ45R08P-A009
  C2902700

 RS232_UART
  MAX3232IPWR
  C113205

The power supply is definitely overkill for our needs, but more stuff can be connected to the board by simply soldering wires to it.
I will make the order on JLCPCB, test the hardware and then publish the resources under an open-source license.

The PCB(s) have arrived!

Pictures

Alright, the hardware is working as it should! It took me a while to test as I had to fix a few things. I will publish schematics and PCB soon.

The inverter is quite noisy in RF spectrum and may cause these devices to work less stable.
Especially with the common ground.

You were absolutely right: when powered by the RS232 port, simply connecting the ground from the ESP32's UART header to a CH340 interface causes the computer's USB port to reset continuously... any ideas on how to fix that?


[SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

What changes were proposed in this pull request?
Do not cast NaN to an Integer, Long, Short or Byte. This is because casting NaN to those types results in a 0 which erroneously replaces 0s while only NaNs should be replaced.
Why are the changes needed?
This Scala code snippet:
import scala.math;

println(Double.NaN.toLong)

returns 0 which is problematic as if you run the following Spark code, 0s get replaced as well:
>>> df = spark.createDataFrame([(1.0, 0), (0.0, 3), (float('nan'), 0)], ("index", "value"))
>>> df.show()
+-----+-----+
|index|value|
+-----+-----+
|  1.0|    0|
|  0.0|    3|
|  NaN|    0|
+-----+-----+
>>> df.replace(float('nan'), 2).show()
+-----+-----+
|index|value|
+-----+-----+
|  1.0|    2|
|  0.0|    3|
|  2.0|    2|
+-----+-----+

Does this PR introduce any user-facing change?
Yes, after the PR, running the same above code snippet returns the correct expected results:
>>> df = spark.createDataFrame([(1.0, 0), (0.0, 3), (float('nan'), 0)], ("index", "value"))
>>> df.show()
+-----+-----+
|index|value|
+-----+-----+
|  1.0|    0|
|  0.0|    3|
|  NaN|    0|
+-----+-----+

>>> df.replace(float('nan'), 2).show()
+-----+-----+
|index|value|
+-----+-----+
|  1.0|    0|
|  0.0|    3|
|  2.0|    0|
+-----+-----+

How was this patch tested?

Added unit tests to verify replacing NaN only affects columns of type Float and Double

Can one of the admins verify this patch?

@cloud-fan can you take a look?

ok to test

Can one of the admins verify this patch?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19616/
Test PASSed.

ok to test

Test build #114808 has started for PR 26749 at commit f23d113.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19632/
Test PASSed.

Test build #114808 has finished for PR 26749 at commit f23d113.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114808/
Test PASSed.

thanks, merging to 2.4!


Blind 75 and array problem

You need to do only one problem for a day. Kindly follow this on upcoming days

i have done only one problem in the blind 75 the balance are being updated on the general learning in arrays


Update !#/bin/bash to !#/bin/sh startup-order.md

Proposed changes
Changed !#/bin/bash to !#/bin/sh because the script above was throwing standard_init_linux.go:178: exec user process caused "no such file or directory".  Maybe I was doing something incorrectly, but switching to sh allowed it to run.

You can do some troubleshooting on this by running the postgres image interactively:
$ docker run --rm -it postgres sh

The --rm switch says to remove the container when it exits. The -it switches run the container interactively and attached to your terminal. The sh is what to run inside the container, instead of the default endpoint which would be the database.
You're dropped into the container at a root prompt. Then you can run some commands:
# which sh
/bin/sh

# which bash
/bin/bash

# ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Nov  8  2014 /bin/sh -> dash

# ls -ld /bin/bash
-rwxr-xr-x 1 root root 1029624 Nov  5 21:22 /bin/bash

You can stop and remove the container by just typing exit (because of the --rm switch).
So, in this case, sh is actually a symbolic link to dash, which is a lightweight shell that doesn't have all the features of Bash. However, Bash does exist and is where it is supposed to be.
You might want to verify that your postgres image is up to date and try again. I don't like to change these docs if Bash really is there. Can you double-check by running the  commands above and let us know?

Ah - ok - that makes sense. I was running the script as an ENTRYPOINT to my node app running the node:7.7.2-alpine image.
# ls -l /bin/sh
lrwxrwxrwx    1 root     root            12 Mar  3 11:20 /bin/sh -> /bin/busybox
# ls -ld /bin/bash
ls: /bin/bash: No such file or directory

bash doesn't exist on Busy Box at all - which does explain the error I was seeing. The above troubleshooting, however, is super useful, and I've learned something today, so all good.
I ended by changing to node:7.7.2-slim where bash is preinstalled, and I get the results you have above.
# ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Nov  8  2014 /bin/sh -> dash

# ls -ld /bin/bash
-rwxr-xr-x 1 root root 1029624 Nov  5 21:22 /bin/bash

I don't want to change documentation if not required - but it might be good to note somewhere that the alpine version won't have bash installed, unless that is just something I should have know already and was completely naive here.
Thank you so much for the really helpful response.  I will go ahead and close this, and let you all reopen if warranted.

So, I think it is general knowledge among people who use Alpine that Alpine doesn't have bash by default. The shell for Alpine is ash. I'm not sure that the Docker docs are the right place to talk about Alpine details, though. I'm sorry this tripped you up.


Fix font paths in app

Acceptance Criteria:

Museo 500
Museo 900

The font IS here: legal-checkup/packages/client/public/fonts/
Except, we think that the URL that is being used in the the index file in the style folder needs to be updated (here: legal-checkup/packages/client/src/styles/index.js). It looks wrong?
The following needs to happen:

It needs to reference the path in the public folder
It only needs the /fonts/part added

Found the free font at https://github.com/cssrocks/fonts/tree/master/Museo Sans Cyrillic


java.util.ConcurrentModificationException from the DbWriter

debezium-embedded_1  |<PHONE_NUMBER>-10-19 19:24:03.281 [pool-1-thread-2] ERROR com.altinity.clickhouse.sink.connector.db.DbWriter  - ******* ERROR inserting Batch *****************
debezium-embedded_1  | java.util.ConcurrentModificationException
debezium-embedded_1  | 	at java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
debezium-embedded_1  | 	at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
debezium-embedded_1  | 	at com.altinity.clickhouse.sink.connector.db.DbWriter.addToPreparedStatementBatch(DbWriter.java:451)
debezium-embedded_1  | 	at com.altinity.clickhouse.sink.connector.executor.ClickHouseBatchRunnable.flushRecordsToClickHouse(ClickHouseBatchRunnable.java:198)
debezium-embedded_1  | 	at com.altinity.clickhouse.sink.connector.executor.ClickHouseBatchRunnable.processRecordsByTopic(ClickHouseBatchRunnable.java:169)
debezium-embedded_1  | 	at com.altinity.clickhouse.sink.connector.executor.ClickHouseBatchRunnable.run(ClickHouseBatchRunnable.java:101)
debezium-embedded_1  | 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
debezium-embedded_1  | 	at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
debezium-embedded_1  | 	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
debezium-embedded_1  | 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
debezium-embedded_1  | 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
debezium-embedded_1  | 	at java.base/java.lang.Thread.run(Thread.java:829)

affects 2023-10-17 release

Hello.
I'm having the same problem. Have you had any feedback?

Hello @aadant.
I,m with same problems in my infrastructure.  You have any news?

@subkanthi should release a stable release that fixes this issue. Do you know if there is a recent build that fixes the issue ?

@jramorim13 , we are working on an improved build process, we will have a new release in a couple of days.

Fixed in latest release, ConcurrentLinkedQueue poll is used instead of iterating through elements.


Simple guide on how to verify Airnode addresses

Context
Jiri has requested a short guide on how a dAPP owner can verify the addresss of an API provider's Airnode.
Suggested Changes
A new guide
Additional Information
For these API providers:

Coinpaprika: https://coinpaprika.com/
dxfeed: https://dxfeed.com/
Finage: https://finage.co.uk/
Finnhub: https://finnhub.io/
Kaiko: https://www.kaiko.com/
NewChangeFX: https://www.newchangefx.com/
Nodary: https://nodary.io/docs/data-feeds/
TraderMade: https://tradermade.com/
twelvedata: https://twelvedata.com/

An example link"
https://www.digitalocean.com/community/tools/dns?domain=dxfeed.com#TXT-Records
There is issue in that the provider's used ChainAPI and as such there txt record will use the following:
dxfeed.com | 86400 | chainapi-verification-keys=[0x11030d4f8eB06F958E763C6f8b165D7CDd98DB6C]

So advise the reader to look for chainapi-verification-keys= in the provider's txt records.
Note from Jiri:
Hi Warren, I talked with Burak about this and he said, that it's not really correct, but with ChainAPI winding down, we should not really ask them to do any changes. So he suggested we just explain in the docs, that the user should search for: chainapi-verification-keys in order to find the airnode address.

Waiting on Jiri to verify an issue with Kaiko's DNS TXT record. It does not seem to exist.

Jiri has contacted Kaiko and they are getting the txt record added.

Seems like this is done, if so we can close this

My guess is that this was left open because kaiko didn't have a txt record present. I just checked and that's still the case.

Pretty sure the txt record is all set.

I don't see it here whereas it is for others, e.g. nodary, here.

nodary.io
300
chainapi-verification-keys=[0xc52EeA00154B4fF1EbbF8Ba39FDe37F1AC3B9Fd4] Show less...

@wkande please reread all of the comments

Wellit was there when Jiri and I dod this. Now I need to track it down again.

Moved her so I will fix this.
https://www.digitalocean.com/community/tools/dns?domain=kaiko.io#TXT-Records


Can PrimeVue 4.0 be integrated with the vitesse project as an example?

I think this can help everyone understand how to integrate primavue with unocss and vite ssg.
Now unocss and vite ssg are very popular, and I think we need an example like this.
I once tried to do this, but I failed.
I hope the development team can create an example like this.
thanks!

sorry this issue move to https://github.com/primefaces/primevue-examples/issues/10


[SUPPORT]Will it be supported that incremental queries and point in time queries through hive connector and prestoDB ?

Can anyone  tell me that
ncremental queries and point in time queries through hive connector and prestoDB will be possible in version hud-0.13.1?
Thanks

Not yet. We're working on some APIs to improve our integration with query engines - https://github.com/apache/hudi/pull/7080. This is expected to come out in Hudi 1.0 (late summer / early fall). Along with it, incremental and point in time queries will be supported with Hudi connector in PrestoDB.

Thanks for your kindness to tell me that which makes me determined to use hudi other than iceberg.

@forest455 Feel free to close this ticket if you don't need any other support on this.

@forest455 Closing out this ticket. Please reopen in case of any concerns.


vanilla mods?

can vanilla mods be loaded? if not, is there a database somewhere where I can find eagler mods?(specifically the manhunt compass)
If this is the wrong spot to put this, let me know so I can take it down and move It to the correct location.

EaglerForge's API is completely different than Forge's. Mods need to be made from scratch.

Ill look into the manhunt compass


[benchmarks] IntelliJ Warning on T for Array.ofDim

Seems that the type could not be implicitly inferred. for ofDim so this has been added explicitly. Seems to only happen on IntelliJ and not cause issues on SBT via terminal. Possibly this is coming from Scala 3 migration.

Yes very likely that this is coming from the Scala 3 migration, or rather Intellij's nonperfect support for it. It definitely helps (and doesn't harm) to merge this.
Just to double check: for me (with intellij 2023.1.3 and scala plugin version 2023.1.565) it does derive the type correctly to Array[Int], however it complains about a missing TypeTag - is that the same for you?

@mpollmeier My Scala plugin is 2023.1.19 from what I see but I have the exact same phenomena as you've shown above

Yes the IntellIj support has been bad for Scala 3 imo

even if there's no difference for this specific issue, it's worth changing to the nightly plugin builds IMO...


There is no Create button

The docs say "click Create to create the project.", but there is no Create button -- the screenshot reads Next. Please update these docs to reflect current software.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 660b0f7c-9941-2db3-63bf-fc8a97765b1e
Version Independent ID: 5aa1e6f6-534a-05b9-c44a-1f62b24c201a
Content: Hello, Android: Quickstart - Xamarin
Content Source: docs/android/get-started/hello-android/hello-android-quickstart.md
Product: xamarin
Technology: xamarin-android
GitHub Login: @davidortinau
Microsoft Alias: daortin

Thanks for submitting an issue and we apologize for the delayed response. The requested updates haven't been made since the creation of the issue, and the timeline for resolution may vary based on resourcing, so the issue is being moved to an internal repo to better track it.


Release artifacts for release 1.2.11

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/hold


0.20

Please, publish a new release 0.20 (or higher). Don't forget to update us here regularly (at least once a week), as explained in this article.

@yegor256 I set the milestone to 1.0 since there is nothing set yet

@yegor256 Closing..


fix checkstyle check FAILED #670

Fixes ISSUE#670.
Motivation
Update spotbug-gradle-plugin version to 5.0.3 and fix checkstytle check fail.
Modifications
Update spotbug-gradle-plugin version to 5.0.3.
Reformate  java code.
Documentation
No

close for many commits bug.


Lung Nodule detection (Inference)

I have followed the instructions to do the inference but I have three questions:
1- The output I got having three main things:

the ground truth coordinates
label
image name
I’m wondering why the label is always zero? but some images have two zeros and some have more? can you please elaborate more on this part?

2- The inference is working only on the raw data (The unprocessed images), while when I infer the model on the resampled data it is not working!?
3- The inference uses the ground truth and calculates the label score, what if I want to do the inference on a different dataset that has no ground truth?
I want to see the performance of the model on another dataset.

I have followed the instructions to do the inference but I have three questions: 1- The output I got having three main things:

the ground truth coordinates
label
image name
I’m wondering why the label is always zero? but some images have two zeros and some have more? can you please elaborate more on this part?

2- The inference is working only on the raw data (The unprocessed images), while when I infer the model on the resampled data it is not working!?
3- The inference uses the ground truth and calculates the label score, what if I want to do the inference on a different dataset that has no ground truth? I want to see the performance of the model on another dataset.

Thank you for reaching out.

The label is always zero because 0 represents lung nodule. This is the only foreground class. The coordinates you got is not ground truth. Instead it is the predicted coordinates of nodules. When there are more than one 0, it means it predicts more than one nodules.

Please refer to explanation on inference setting. If you find issue on resampled data, it is very likely that you need to change this setting to false. If it still does not work, then consider add "affine_lps_to_ras": true in "_target_": "LoadImaged".

The inference did not use the ground truth. If you look at the "preprocessing" in the config file, you can see only "image" is used. Simply delete the box and label in the data list json, and it will produce the result

Thank you for your fast response
1- clear.
2- Yes I did the same preprocessing in 3.1 and the inference didn't work, I also check "affine_lps_to_ras": true and make sure it is true, I also added this line "affine_lps_to_ras": true in "target": "LoadImaged" and still the the inference is not working :/ !
The error message: RuntimeError: Could not create IO object for reading file /data/<IP_ADDRESS>.4.1.145<IP_ADDRESS>.6279.6001.281489753704424911132261151767.mhd
3- Where are you referring exactly when you said “preprocessing in the config file” ?
Config directory has only five files which are:

evaluate.json
inference.json
metadata.json
train.json
logging.conf

I did as you said I deleted the box and label in the data list json in (annotation folder) since the data is being read from that folder, and I modified the name of the image to the new image I want to read, but it didn’t work because as I mentioned it is structured to read the ground truth. This is the error message I got:
ValueError: Data list validation not specified in "/annotation/dataset_fold0 copy.json"
Can you please guide me how to to do the inference without ground truth?
Sorry for being annoying, but I really interested to see MONAI results in another dataset :)

Thank you for your fast response
1- clear.
2- Yes I did the same preprocessing in 3.1 and the inference didn't work, I also check "affine_lps_to_ras": true and make sure it is true, I also added this line "affine_lps_to_ras": true in "target": "LoadImaged" and still the the inference is not working :/ ! The error message: RuntimeError: Could not create IO object for reading file /data/<IP_ADDRESS>.4.1.145<IP_ADDRESS>.6279.6001.281489753704424911132261151767.mhd
3- Where are you referring exactly when you said “preprocessing in the config file” ? Config directory has only five files which are:

evaluate.json
inference.json
metadata.json
train.json
logging.conf

I did as you said I deleted the box and label in the data list json in (annotation folder) since the data is being read from that folder, and I modified the name of the image to the new image I want to read, but it didn’t work because as I mentioned it is structured to read the ground truth. This is the error message I got: ValueError: Data list validation not specified in "/annotation/dataset_fold0 copy.json"
Can you please guide me how to to do the inference without ground truth? Sorry for being annoying, but I really interested to see MONAI results in another dataset :)

No worries, I'm happy to get feedback and answer the questions.

From the error message, I can see the image is very likely to be the raw image, not the resampled image...Because the resampled image should be nifti. I updated the josn files in https://github.com/Can-Zhao/model-zoo/tree/detection/models/lung_nodule_ct_detection/configs Could you try inference.json for resampled nifti images or inference_raw.json on original images?

In inference.json, the very first transform of "preprocessing" is "DeleteItemsd", which deletes "box" and "label". If you already delete them in the json file, then maybe remove this "DeleteItemsd" transform.

Thank you! Please feel free to ask more questions

2- The images are resamples, but I explicitly convert them from nifti to mhd after doing the resampling because your code is only reading mhd format. did you test the inference ?
3- I added the name of the new data and I have the same issue.
ValueError: Data list validation not specified in "/annotation/dataset_fold0.json".
Also, I noticed in the inference.json line 8 ("output_dir") it should put only the inference output in "eval" directory, but what is actually happening is, the code expected that the json annotations files are located in "eval directory". So, I needed to add a copy of the annotations files in eval directory to be able to run the code


Timer function

@bsoyka What do you think about this? Unfortunately I don't see a huge reason why we'd need it anymore...

@bsoyka What do you think about this? Unfortunately I don't see a huge reason why we'd need it anymore...

Yeah, I guess I agree with you. Closing this PR and its issue.


Updated failed node status in slack notification

Reports node failures in slack channel

Please have a look @chaitanyaenr

Can one of the admins verify this patch?


video input from sjCam in IP Adress format

what is command to takevideo input from sjcam mounted on my drone to run siamMask teracking

you can find examples of how to use THOR in the benchmarks (vot.py, otb.py) or in webcam_demo.py.


[BUG]: Unable to configure new agent

What happened?
All my existing agents (around 18) stopped working and I am not able to configure new agent too as it fails to connect to server and this happens specifically when I have a proxy defined. When I check the network flow, nothing reaching our proxy server and seems failing even before request is sent
Attached log below
Versions
Azure DevOps version 3.218.0 latest one
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Windows 10
Version controll system
No response
Relevant log output
[2023-04-20 13:31:14Z ERR  LocationServer] System.Net.Http.HttpRequestException: An error occurred while sending the request.
 ---> System.IO.IOException: Unable to write data to the transport connection: An existing connection was forcibly closed by the remote host..
 ---> System.Net.Sockets.SocketException (10054): An existing connection was forcibly closed by the remote host.
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.CreateException(SocketError error, Boolean forAsyncThrow)
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.SendAsyncForNetworkStream(Socket socket, CancellationToken cancellationToken)
   at System.Net.Sockets.Socket.SendAsyncForNetworkStream(ReadOnlyMemory`1 buffer, SocketFlags socketFlags, CancellationToken cancellationToken)
   at System.Net.Sockets.NetworkStream.WriteAsync(ReadOnlyMemory`1 buffer, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnection.WriteToStreamAsync(ReadOnlyMemory`1 source, Boolean async)
   at System.Net.Http.HttpConnection.FlushAsync(Boolean async)
   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.AuthenticationHelper.SendWithNtAuthAsync(HttpRequestMessage request, Uri authUri, Boolean async, ICredentials credentials, Boolean isProxyAuth, HttpConnection connection, HttpConnectionPool connectionPool, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining)
   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
   at System.Threading.Tasks.Task`1.TrySetResult(TResult result)
   at System.Net.Http.HttpConnectionPool.GetHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining)
   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetExistingTaskResult(Task`1 task, TResult result)
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecuteFromThreadPool(Thread threadPoolThread)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
   at System.Threading.Thread.StartCallback()
--- End of stack trace from previous location ---

   --- End of inner exception stack trace ---
   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at Microsoft.VisualStudio.Services.Common.VssHttpRetryMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync(HttpRequestMessage message, HttpCompletionOption completionOption, Object userState, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync[T](HttpRequestMessage message, Object userState, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.Location.Client.LocationHttpClient.GetConnectionDataAsync(ConnectOptions connectOptions, Int64 lastChangeId, CancellationToken cancellationToken, Object userState)
   at Microsoft.VisualStudio.Services.WebApi.Location.VssServerDataProvider.GetConnectionDataAsync(ConnectOptions connectOptions, Int32 lastChangeId, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.Location.VssServerDataProvider.ConnectAsync(ConnectOptions connectOptions, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.Agent.LocationServer.ConnectAsync(VssConnection jobConnection) in D:\a\1\s\src\Microsoft.VisualStudio.Services.Agent\LocationServer.cs:line 36
[2023-04-20 13:31:14Z INFO CommandSettings] Flag 'unattended': 'False'
[2023-04-20 13:31:14Z ERR  Terminal] WRITE ERROR (exception):
[2023-04-20 13:31:14Z ERR  Terminal] System.Net.Http.HttpRequestException: An error occurred while sending the request.
 ---> System.IO.IOException: Unable to write data to the transport connection: An existing connection was forcibly closed by the remote host..
 ---> System.Net.Sockets.SocketException (10054): An existing connection was forcibly closed by the remote host.
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.CreateException(SocketError error, Boolean forAsyncThrow)
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.SendAsyncForNetworkStream(Socket socket, CancellationToken cancellationToken)
   at System.Net.Sockets.Socket.SendAsyncForNetworkStream(ReadOnlyMemory`1 buffer, SocketFlags socketFlags, CancellationToken cancellationToken)
   at System.Net.Sockets.NetworkStream.WriteAsync(ReadOnlyMemory`1 buffer, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnection.WriteToStreamAsync(ReadOnlyMemory`1 source, Boolean async)
   at System.Net.Http.HttpConnection.FlushAsync(Boolean async)
   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.AuthenticationHelper.SendWithNtAuthAsync(HttpRequestMessage request, Uri authUri, Boolean async, ICredentials credentials, Boolean isProxyAuth, HttpConnection connection, HttpConnectionPool connectionPool, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining)
   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
   at System.Threading.Tasks.Task`1.TrySetResult(TResult result)
   at System.Net.Http.HttpConnectionPool.GetHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining)
   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetExistingTaskResult(Task`1 task, TResult result)
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecuteFromThreadPool(Thread threadPoolThread)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
   at System.Threading.Thread.StartCallback()
--- End of stack trace from previous location ---

   --- End of inner exception stack trace ---
   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at Microsoft.VisualStudio.Services.Common.VssHttpRetryMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync(HttpRequestMessage message, HttpCompletionOption completionOption, Object userState, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync[T](HttpRequestMessage message, Object userState, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.Location.Client.LocationHttpClient.GetConnectionDataAsync(ConnectOptions connectOptions, Int64 lastChangeId, CancellationToken cancellationToken, Object userState)
   at Microsoft.VisualStudio.Services.WebApi.Location.VssServerDataProvider.GetConnectionDataAsync(ConnectOptions connectOptions, Int32 lastChangeId, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.Location.VssServerDataProvider.ConnectAsync(ConnectOptions connectOptions, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.Agent.LocationServer.ConnectAsync(VssConnection jobConnection) in D:\a\1\s\src\Microsoft.VisualStudio.Services.Agent\LocationServer.cs:line 36
   at Microsoft.VisualStudio.Services.Agent.Util.ServerUtil.GetConnectionData(String serverUrl, VssCredentials credentials, ILocationServer locationServer) in D:\a\1\s\src\Microsoft.VisualStudio.Services.Agent\Util\ServerUtil.cs:line 94
   at Microsoft.VisualStudio.Services.Agent.Util.ServerUtil.DetermineDeploymentType(String serverUrl, VssCredentials credentials, ILocationServer locationServer) in D:\a\1\s\src\Microsoft.VisualStudio.Services.Agent\Util\ServerUtil.cs:line 85
   at Microsoft.VisualStudio.Services.Agent.Listener.Configuration.ConfigurationManager.checkIsHostedServer(IConfigurationProvider agentProvider, AgentSettings agentSettings, ICredentialProvider credProvider) in D:\a\1\s\src\Agent.Listener\Configuration\ConfigurationManager.cs:line 826
   at Microsoft.VisualStudio.Services.Agent.Listener.Configuration.ConfigurationManager.ConfigureAsync(CommandSettings command) in D:\a\1\s\src\Agent.Listener\Configuration\ConfigurationManager.cs:line 157
[2023-04-20 13:31:14Z ERR  Terminal] WRITE ERROR: Failed to connect.  Try again or ctrl-c to quit
[2023-04-20 13:31:14Z INFO CommandSettings] Arg 'url': ''
[2023-04-20 13:31:14Z INFO CommandSettings] Flag 'unattended': 'False'
[2023-04-20 13:31:14Z INFO PromptManager] ReadValue
[2023-04-20 13:31:14Z INFO Terminal] WRITE: Enter server URL >
[2023-04-20 13:31:14Z INFO Terminal] READ LINE

Hi @chilakamarthi thanks for reporting! We are working on more prioritized issues at the moment but will get back to this one soon.


gtk-primary-selection: support multiple devices

When a client was creating multiple data devices for the same seat, we were
only creating one resource. This is a protocol error.
Instead, create one offer per data device.
This commit also makes offers inert when their source is destroyed.
Fixes part of https://github.com/swaywm/wlroots/issues/1041
Supersedes https://github.com/swaywm/wlroots/pull/1113

I gave the patch in the PR a shot with firefox 65 (hg master) and sway (master). It doesn't crash anymore when I'm selecting text in the address bar.

After applying the patch, the ipc_channel_posix.cc errors seen in #3170 and other issues no longer occur when running firefox.
[Child 20714, Chrome_ChildThread] WARNING: pipe error (40): Connection reset by peer: file /var/cache/pkg/firefox-wayland/src/mozilla-unified/ipc/chromium/src/chrome/common/ipc_channel_posix.cc, line 363


fix(roxvet): fix needlessformat analyzer

Description
After introducing an interface that's exposed from the logging package, the needlessformat analyzer didn't work correctly anymore since it expected a pointer expression of the form (*Logger), but instead we have an expression of Logger.
The PR fixes the analyzer and all occurrences that have been flagged by it after its fixed to pass CI.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed

see CI passing.

Current dependencies on/for this PR:

master

PR #7462   👈

This comment was auto-generated by Graphite.


Remove handle() method from controllers

The previous routing strategy relied on verb routing inside the controllers; it is no longer needed but the parent controller class implemented the handle() method as an abstract so it always had to be declared.  The requirement to have it required is gone and the existing handle methods are also removed

:+1:


Deep match is not working

I'm trying to make deepMatch work but I always get false positives.
I saw this https://github.com/microsoftly/BotTester/blob/master/test/BotTester.spec.ts#L185
If I change the user id in the test it always works. Not sure what is the problem. Have tried using chai-subset and I'm getting the same issue. Any ideas @microsoftly ?

That's interesting. I'll look into it. I found it a bit hard initially to find something that could do the deep matching well.
What may be a better solution is to break down IMessage into each component (text, address, type, etc .... ) then check against each of those and throw an error when one of them doesn't match (if defined in the expectation). That would definitely give better error reporting too instead of a giant blob of red

Yep, breaking the IMessage probably would be better but I think the deep match should be fine for the moment. The problem as I mentioned is that is not working correctly :(. Let me know if you find anything please!

@bilby91 fixed #16

Awesome!
When you have a moment can you check on #15 ?
Thanks
Martín Fernández
On Tue, Sep 05, 2017 at 9:18 PM Matthew Schwartz
<
mailto:Matthew Schwartz<EMAIL_ADDRESS>
wrote:

a, pre, code, a:link, body { word-wrap: break-word !important; }
https://github.com/bilby91
fixed
https://github.com/microsoftly/BotTester/pull/16
—
You are receiving this because you were mentioned.
Reply to this email directly,
https://github.com/microsoftly/BotTester/issues/14#issuecomment-327338462
, or
https://github.com/notifications/unsubscribe-auth/ACGV91TyRZrawsb0Qbp1vkGd66teUn_Qks5sfeTagaJpZM4PMNXw
.


soc: xtensa: esp32s2/s3: remove HEAP_MEM_POOL_ADD_SIZE_SOC

There is no need for this config here and it is wrongfully messing with total system heap calculation.

No objections, but out of curiosity why did these files originally contain a modification to the default HEAP_MEM_POOL_SIZE? (which was changed to ADD_SIZE_SOC when that feature was added)

I guess it should not have that originally. Also, only ESP32-S2 and ESP32-S3 had this change. Other SoCs do not.