Always fallback to DefaultFrom in Enlight_Components_Mail

1. Why is this change necessary?
If you send some mail with Enlight_Components_Mail, for example when changing the order state and sending out an update to your customer and you don't provide an sender, setting the From header to an empty string won't set the fallback default mail address.
2. What does this change do, exactly?
If the sender email address provided to $mail->setFrom() is an empty string fall back to $address = null to allow Zend_Mail to use setFromToDefaultFrom().
3. Describe each step to reproduce the issue or behaviour.

Go to an order
Change order state to cancelled
Send state change mail to customer
Customer gets mail but without a sender as it is an empty string (AFAIK there is no input for sender mail)
Now use this PR and go to step 1 and retry. Now shop's default mail address will be used.

4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello @pascalheidman-bedarf,
I wasn't able to reproduce this error on any system. I changed the state of an order to cancelled and sent the email, and there was always a sender.

Hey @pascalheidman-bedarf,
you're still on it?

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://developers.shopware.com/contributing/contribution-guideline/.

@shopwareBot while this was a case that problem happened to us this should be fixed anyway... Will take a look at it soon anyway


HUDI-110 Spark Datasource Auto Partition Extractor

What is the purpose of the pull request
JIRA: https://issues.apache.org/jira/browse/HUDI-110
Add an example to support the Spark auto partition extractor to improve read performance.
With the existing way how we query the ReadOptimized table through Spark, we can take advantage of https://spark.apache.org/docs/latest/sql-data-sources-parquet.html#partition-discovery directly. This feature only support folder structure like /partitionKey=partitionValue and partitionValue could be String or Int
This feature only applies to the Spark internally supported file format. If we use a custom relation, we will need a custom partition parser to extract partition from the path. This was handled by DataSource internally.
We need to add this example to the doc as well.
Brief change log

Add test to demo Spark Partition Discovery.

Verify this pull request
This change added tests and can be verified as follows:

Added unit test testSparkAutoPartition

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #1643 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1643      +/-   ##
============================================
- Coverage     16.71%   16.59%   -0.12%
- Complexity      795      799       +4
============================================
  Files           340      344       +4
  Lines         15030    15172     +142
  Branches       1499     1512      +13
============================================
+ Hits           2512     2518       +6
- Misses        12188    12322     +134
- Partials        330      332       +2

Impacted Files
Coverage Δ
Complexity Δ

...in/scala/org/apache/hudi/AvroConversionUtils.scala
45.45% <0.00%> (-4.55%)
0.00% <0.00%> (ø%)

...c/main/java/org/apache/hudi/index/HoodieIndex.java
36.84% <0.00%> (-4.34%)
3.00% <0.00%> (ø%)

...ain/java/org/apache/hudi/avro/HoodieAvroUtils.java
50.00% <0.00%> (-3.97%)
22.00% <0.00%> (ø%)

...java/org/apache/hudi/config/HoodieIndexConfig.java
38.46% <0.00%> (-1.23%)
3.00% <0.00%> (ø%)

...java/org/apache/hudi/client/HoodieWriteClient.java
20.37% <0.00%> (-1.12%)
12.00% <0.00%> (ø%)

...java/org/apache/hudi/config/HoodieWriteConfig.java
42.25% <0.00%> (-1.04%)
48.00% <0.00%> (+1.00%)
:arrow_down:

...n/scala/org/apache/hudi/AvroConversionHelper.scala
7.42% <0.00%> (-0.37%)
0.00% <0.00%> (ø%)

...org/apache/hudi/client/utils/SparkConfigUtils.java
7.69% <0.00%> (-0.31%)
2.00% <0.00%> (ø%)

...java/org/apache/hudi/common/util/ParquetUtils.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

.../apache/hudi/common/util/ObjectSizeCalculator.java
77.61% <0.00%> (ø)
25.00% <0.00%> (ø%)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a0080...ce6005c. Read the comment docs.

IIRC we already support generating partition path in the /partitionKey=partitionValue folder strucutre.. Not sure what this PR is adding

@vinothchandar Yes this feature was already supported. Maybe I misunderstand this ticket https://issues.apache.org/jira/browse/HUDI-110. Need @bvaradar 's input here.
I will add the partition discovery example to the doc. I remember someone asked questions related to this topic before.

@garyli1019 : There are 2 parts to it : The ticket was originally created to track making hive-style partitioning scheme as default in Hudi.  Spark supports this same style.  Given the adoption, changing the default partition style has implication on backwards compatibility and needs to have a discussion.
The other part is about how to make use of partition configuration spark captures in partitionBy(..) and use it directly configure KeyGenerator. Let me know if this makes sense.
SlashEncodedDayPartitionValueExtractor is the default being used. This is not a common format outside Uber.
Also, Spark DataSource provides partitionedBy clauses which has not been integrated for Hudi Data Source.  We need to investigate how we can leverage partitionBy clause for partitioning.

Thanks @bvaradar , so this is more on the writer side. I will take a closer look.


Swap task classes over to annotations

For streaming support, move the params of @caikit.task into annotations on the class def, like:
@caikit.task()
class TokenClassification:
  unary_params: {"text": str}
  streaming_params: {"tokens": Iterable[str]}
  unary_output_type: TokenClassifications
  streaming_output_type: Iterable[TokenClassification]

This will allow a much more readable implementation as we add these extra params for streaming, and it will remove some awkwardness where parameters to task() are closure'd around the class to be injected into it.
We'll need to add similar validation checks that we do on streaming outputs to the new streaming inputs.
Would be super great to allow backwards-compatibility if that's remotely feasible

JK we're doing something different - staying in the task decorator params to minimize change footprint
@caikit.task(unary_parameters={"text": str},
                      streaming_parameters={"tokens": Iterable[str]},
                      unary_output_type=TokenClassifications,
                      streaming_output_type=Iterable[TokenClassification]
)
class TokenClassification:
    pass


how run on live from a Realsense camera?

I have a realsense camera, but I cannot find how run it on live slam, only I can find ros bag based .launch files.
Other question is can Kimera use Imu data from a Pix 4 or t265 and the stereo from d435? what name should have the IMU msg and what kind of coordinate system (quaternions or other)
thanks

Yes, you can run Kimera on live slam! Below is a picture of it performing live SLAM on the infrared stereo + IMU of a d435i.
For now, you need a system like the D435i that provides synchronized stereo images and imu data. You can specify what topics you are publishing the data on in the launch file, and camera calibration parameters in the VIO params folder. We'll release a launch file and calibration files at some point in the near future. In the meantime, feel free to consult this doc for how to do it yourself!

Working parameters and launch file have not yet been merged into master, but are available in these pull requests:
Kimera-VIO
Kimera-VIO-ROS
You can check them out with:
cd /PATH/TO/Kimera-VIO
git checkout feature/centralized_params_with_realsense
cd /PATH/TO/Kimera-VIO-ROS
git checkout feature/realsense_metric_reconstruction_demo

This guide has tips for setting up the RealSense drivers/firmware/etc as well as the command line commands to get the RealSense running with the given launch files.

You can pair the stereo images from the d435i with IMU data from another device if you can get the device clocks synchronized. That said, the d435i has a pretty good on board accelerometer and gyroscope-- I would recommend using those.
All messages sent/accepted over ROS are in ROS standard formats. For the IMU data, it follows this format.

You can pair the stereo images from the d435i with IMU data from another device if you can get the device clocks synchronized. That said, the d435i has a pretty good on board accelerometer and gyroscope-- I would recommend using those.
All messages sent/accepted over ROS are in ROS standard formats. For the IMU data, it follows this format.

Hi,
Have you managed to perform a stable localization/odometry with only the d435i?
I'm running the Kimera-VIO-ROS here with my D435i and I'm getting large localization errors
(Running with the kimera_vio_ros_realsense_IR.launch)

You can pair the stereo images from the d435i with IMU data from another device if you can get the device clocks synchronized. That said, the d435i has a pretty good on board accelerometer and gyroscope-- I would recommend using those.
All messages sent/accepted over ROS are in ROS standard formats. For the IMU data, it follows this format.

Have you managed to perform stable localization with only the d435i and the Kimera-VIO?

Yep! I got it to do stable localization with kimera_vio_ros_realsense_IR.launch. If you are experiencing unstable localization, it could be a problem with
a) your device
b) your device driver
c) your Kimera parameters
d) Kimera itself
Given that I've gotten it working (resolving some device issues along the way) I suspect it's b) or c).
Can you run Kimera on this sample rosbag collected from my D435i?
https://drive.google.com/open?id=1ipuwygPzKnTu7I5df97dcVih_1oxqpmq
This will allow us to narrow down the possible sources of failure

Also, what is your environment like? The current set of parameters is tuned for indoor environments-- close range, fairly feature dense. They may need additional tuning if you are operating outside.


fix: :ambulance: Solve the issue for token limit quota exceeded

Description
This pull request resolves the DynamoDB rate limit error without throttling on the table. The issue was identified as a throttling problem in the retry module, particularly affecting scenarios with a high number of concurrent Go routines using the same client instance.
Root Cause
The error was triggered by the limited token bucket size shared among multiple Go routines, leading to the exhaustion of tokens during retry attempts.
Solution
The solution involves making the token bucket size configurable. By adjusting the number of tokens when constructing the configuration, we can prevent the depletion of tokens across concurrent Go routines. In this case, the token rate limit has been set to 1,000,000 to accommodate the high concurrency.
cfg, err := config.LoadDefaultConfig(ctx, config.WithRetryer(func() aws.Retryer {
    return retry.NewStandard(func(so *retry.StandardOptions) {
        so.RateLimiter = ratelimit.NewTokenRateLimit(1000000)
    })
})

This problem is specific to use cases. This library does not have to cater for that. It provides an option to pass a function for setting AWS config with the concept of Middlewares for mutating aws config.
Even better, extend the NewClient func to take list of option functions like WithRetry WithRateLimit WithRegion etc.
Cannot make this a default configuration. The consumer could pass this as a middleware. See ClientOptions

@thusharprakash
Here is what you could do while we streamline the provision of middlewares, options, and provide some functions to construct a default set of middlewares like https://github.com/go-chi/chi/tree/master/middleware
const AWS_TOKEN_RATE_LIMIT = 1000000

func RateLimitMiddleware(conf *aws.Config) {
	conf.Retryer = func() aws.Retryer {
		return retry.NewStandard(func(so *retry.StandardOptions) {
			so.RateLimiter = ratelimit.NewTokenRateLimit(AWS_TOKEN_RATE_LIMIT)
		})
	}
}

	dynago.NewClient(context.TODO(), dynago.ClientOptions{
		TableName:   "other-options-ignored",
		Middlewares: []func(*aws.Config){RateLimitMiddleware},
	})

Let me know if this doesn't work.


Unable to execute JS call: __fbBatchedBridge is undefined

run the rnws bundle to generate the main.jsbundle file and
uncomment the line
  jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
in the AppDelegate.m file.
After all, run the app in my iphone through Xcode, it get the error:

Unable to execute JS call: __fbBatchedBridge is undefined

Did I miss something?

Make sure main.jsbundle is in fact bundled with your app. When using the React Native packager, react-native-xcode.sh takes care of that. When using rnws, it depends on your setup. A common solution is to simply add main.jsbundle to the XCode tree.

Closing this issue for now since it's not really related to rnws. Please reopen with more details if you can confirm it's a rnws issue.


Propagate tracestate header in the OpenTelemetry tracer

Commit Message: Propagate tracestate header in the OpenTelemetry tracer
Additional Description: OTLP Spans include the tracestate from the tracestate header. We can propagate that information from the headers to the Span. For an initial cut, we can just store whatever incoming tracestate header is in the span. In the future, it may make sense to add more handling to update the tracestate, but I don't believe we currently do any tracestate updates in Envoy.
Risk Level: Low
Testing: Basic tests
Part of #9958

/assign-from @envoyproxy/first-pass-reviewers

This ready to merge @htuch @AlexanderEllis ?


Migrate this repository to github.com/metanorma

The repository github.com/metanorma has been set up to host all Metanorma related work. This is one such piece of work. While the migration will be slow (there is a lot to do, and a lot of interdependencies), we need to schedule migration for all related repositories.
Migration to Metanorma:

Repost the repository to http://github.com/metanorma/X

This should be as simple as changing the following field in .git/config: [remote "origin"]   url = https://github.com/riboseinc/metanorma-iso.git. Refer https://help.github.com/en/articles/transferring-a-repository

If this is a Ruby gem, change the address of the repository in the *.gemspec
Delete all files but the Readme in the riboseinc repository
Replace the Readme in the riboseinc repository with the message "Repository migrated to http://github.com/metanorma/X
Update the links to the repository in any documentation you maintain
Link the README in the new location to updated links for appveyor, CodeClimate, travis, etc. New links to travis should be to travis-ci.com, not travis-ci.org.
Notify @opoudjis and @strogonoff when you have migrated the repository. They will then update the links to the repository in any documentation they maintain.

@strogonoff this is for you. Can you accept the org invitation for the assignment? Thanks!

There is probably very little for you to do now: just ensure that links point to http://github.com/metanorma instead of http://github.com/riboseinc (I already have started doing so in my edits, and will keep doing so.)


kimberliteBidAdapter: video support docs update

🏷 Type of documentation

[ ] new bid adapter
[x] update bid adapter
[x] new feature
[ ] text edit only (wording, typos)
[ ] bugfix (code examples)
[ ] new examples

📋 Checklist

[x] Related pull requests in prebid.js or server are linked https://github.com/prebid/Prebid.js/pull/11981
[ ] For new adapters check submitting your adapter docs

Hi there! Is it possible to merge PR or any issues with that? Is it required for changes to be appeared in new version?


Jobs launched with run_namespaced_job fails in case of evictions

Expectation / Proposal
When a pod is evicted from a job launched with run_namespaced_job, the whole flow fails due to this runtime error even if the new pod created by Kubernetes after the eviction completes. This is due to this query getting all pods tied to the controller UUID.
I think wait_for_completion should ignore evicted pods in this loop.
Traceback / Example
Encountered exception during execution:
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/prefect/engine.py", line 1925, in orchestrate_task_run
    result = await call.aresult()
  File "/usr/local/lib/python3.9/site-packages/prefect/_internal/concurrency/calls.py", line 293, in aresult
    return await asyncio.wrap_future(self.future)
  File "/usr/local/lib/python3.9/site-packages/prefect/_internal/concurrency/calls.py", line 355, in _run_async
    result = await coro
  File "/usr/local/lib/python3.9/site-packages/prefect_kubernetes/jobs.py", line 449, in wait_for_completion
    raise RuntimeError(
RuntimeError: Job '***' failed, check the Kubernetes pod logs for more information.
wait_for_completion-0
prefect.task_runs

Finished in state Failed("Task run encountered an exception RuntimeError: Job '***' failed, check the Kubernetes pod logs for more information.")
wait_for_completion-0
prefect.task_runs

Encountered exception during execution:
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/prefect/engine.py", line 844, in orchestrate_flow_run
    result = await flow_call.aresult()
  File "/usr/local/lib/python3.9/site-packages/prefect/_internal/concurrency/calls.py", line 293, in aresult
    return await asyncio.wrap_future(self.future)
  File "/usr/local/lib/python3.9/site-packages/prefect/_internal/concurrency/calls.py", line 355, in _run_async
    result = await coro
  File "/usr/local/lib/python3.9/site-packages/prefect_kubernetes/flows.py", line 41, in run_namespaced_job
    await task(kubernetes_job_run.wait_for_completion.aio)(kubernetes_job_run)
  File "/usr/local/lib/python3.9/site-packages/prefect/_internal/concurrency/api.py", line 182, in wait_for_call_in_loop_thread
    return call.result()
  File "/usr/local/lib/python3.9/site-packages/prefect/_internal/concurrency/calls.py", line 284, in result
    return self.future.result(timeout=timeout)
  File "/usr/local/lib/python3.9/site-packages/prefect/_internal/concurrency/calls.py", line 168, in result
    return self.__get_result()
  File "/usr/local/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.9/site-packages/prefect/_internal/concurrency/calls.py", line 355, in _run_async
    result = await coro
  File "/usr/local/lib/python3.9/site-packages/prefect/engine.py", line 1420, in get_task_call_return_value
    return await future._result()
  File "/usr/local/lib/python3.9/site-packages/prefect/futures.py", line 237, in _result
    return await final_state.result(raise_on_failure=raise_on_failure, fetch=True)
  File "/usr/local/lib/python3.9/site-packages/prefect/states.py", line 91, in _get_state_result
    raise await get_state_exception(state)
  File "/usr/local/lib/python3.9/site-packages/prefect/engine.py", line 1925, in orchestrate_task_run
    result = await call.aresult()
  File "/usr/local/lib/python3.9/site-packages/prefect/_internal/concurrency/calls.py", line 293, in aresult
    return await asyncio.wrap_future(self.future)
  File "/usr/local/lib/python3.9/site-packages/prefect/_internal/concurrency/calls.py", line 355, in _run_async
    result = await coro
  File "/usr/local/lib/python3.9/site-packages/prefect_kubernetes/jobs.py", line 449, in wait_for_completion
    raise RuntimeError(
RuntimeError: Job '***' failed, check the Kubernetes pod logs for more information.
prefect.flow_runs

Finished in state Failed("Flow run encountered an exception. RuntimeError: Job '***' failed, check the Kubernetes pod logs for more information.")

[X] I would like to help contribute a pull request to resolve this!

Thanks for the issues @NicholasFiorentini - would love a contribution on this. Tag me if you put one up and I'll review!

@WillRaphaelson, here is my fix: https://github.com/PrefectHQ/prefect-kubernetes/pull/119. Thanks 🙏


Feature discussion: Provide current search context to matcher

Hi Luke,
we recently tried to migrate homegrown code for our component container to your tool - thank you for providing it!
The only issue we're encountering so far is the fact that we need the context from where the match is encountered, because this "plugin" serves as another container for a new private classpath context. From here the plugin may lookup local content.
Currently this is not possible as we do not have the context in the match processor.
Do you think this might be a useful extension that could make it to the public API?
Greetings, Michael

Hi Michael, sounds useful, but what do you mean by "context"?
On Dec 20, 2015 11:51 PM, "Michael"<EMAIL_ADDRESS>wrote:

Hi Luke,
we recently tried to migrate homegrown code for our component container to
your tool - thank you for providing it!
The only issue we're encountering so far is the fact that we need the
context from where the match is encountered, because this "plugin" serves
as another container for a new private classpath context From here the
plugin may lookup local content
Currently this is not possible as we do not have the context in the match
processor
Do you think this might be a useful extension that could make it to the
public API?
Greetings, Michael
—
Reply to this email directly or view it on GitHub
https://github.com/lukehutch/fast-classpath-scanner/issues/33.

Hi Luke,
sorry for being so vague (i'm well known for describing any software artifact with "context", "handler" and "wrapper" :-)).
We load plugins via classloader organized in directories
root1
  + plugins
  |   + <context1>
  |   |   + PLUGIN-INF
  |   |   |  + plugin.xml
  |   |   + <plugin local data>
  |   + <context2>
  |   |   + PLUGIN-INF
  |   |   |  + plugin.xml
  |   |   + <plugin local data>
root2
  + plugins
  |   + <context3>
  |   |   + PLUGIN-INF
  |   |   |  + plugin.xml
  |   |   + <plugin local data>

If i have a matcher to find me any "/plugins/*/plugin.xml" i am getting the relative path within a jar file or classes/ directory, not the root itself. So i can not setup a local classloader for the plugin.
Thanks for reading and merry xmas...
Michael

Ah, I see what you need. Funnily enough, the API used to give you the absolute path, not the relative path, and I figured nobody would need the absolute path, since the whole point of the classpath is to abstract away the absolute location of resources, so I removed it! However, I just added two new MatchProcessor types that provide you with the File object representing either the root of the classpath entry (if the classes are stored in the file hierarchy), or the zipfile (if the classes are stored in a jar/zip). This should do what you need. Please test, and re-open if it doesn't work for you, or if you need some other functionality. (I'll push a release out in half an hour or so once I make an unrelated change.) Merry Christmas!

Released in 1.9.13.

Works as expected. Great - that's "responsive design", many thanks.
Design question: Wouldn't this have been a good candidate for a default method on the old interface?

Thanks for testing!
Probably that would work, yes, but I'm holding off on adding any more Java 8 features for now, since there is at least one user that needs this to work on JRE 1.7. (The only Java 8 feature I'm using right now is the FunctionalInterface annotation, which can be safely ignored by JRE 1.7 if you build using JDK 1.8 in Java 7 compatibility mode.)


GitHub merge queue is generally available

Description of the new feature / enhancement
General availability of GitHub’s merge queue means good-bye to traffic jams on your team’s busiest branches. No more rushing to merge your pull requests before someone else merges theirs 🥵. Turn on GitHub’s merge queue today and accelerate your merge velocity 🚀.
Any team that is part of a managed organization with public repositories and GitHub Enterprise Cloud users will be able to enable this feature on their respective repository and start streamlining their team’s pull requests immediately. If this describes you, then let the commit parties commence 🎉.
Scenario when this would be used?
Merge queue is designed for high-performance teams where multiple users regularly commit to a single branch. Prior to merge queue, engineers would need to attempt to merge directly onto an already busy branch—potentially running into code conflicts, and then spiraling into a cycle of rework.
Supporting information
https://github.blog/2023-07-12-github-merge-queue-is-generally-available/

@snickler @jaimecbernardo @davidegiacometti @stefansjfw what's your experience and opinion?

Haven't used merge queue yet.
Wondering if is worth to use considering the volume of PR of this repo.

I agree. It could be worth checking out, especially if we want to make sure certain things get merged in order 🤔

Jeremy Sinclair

From: Davide Giacometti @.>
Sent: Tuesday, August 22, 2023 9:51:01 AM
To: microsoft/PowerToys @.>
Cc: Jeremy Sinclair @.>; Mention @.>
Subject: Re: [microsoft/PowerToys] GitHub merge queue is generally available (Issue #27465)
Haven't used merge queue yet.
Wondering if is worth to use considering the volume of PR of this repo.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerToys/issues/27465#issuecomment-1688229570, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6URJJQCIPXIHDMBY7Q5R3XWS2MLANCNFSM6AAAAAA2L5UAPE.
You are receiving this because you were mentioned.Message ID: @.***>

Opinion: I'd try it out. Might be beneficial
Experience: Haven't tried it
:)

Anybody want to try? @crutkas ?

Thanks for opening this PR! I'm thinking it makes more sense to get it in only after #28722 and #29023 get in.
I'd like to avoid conflicts on those. WDYT?

https://github.com/microsoft/PowerToys/pull/29114#pullrequestreview-1667195750

@crutkas the recent prs about updating dependencies seems like a great case to test this.  What do you think? What would keep us?


Error running the sample WeatherTwentyOne project

Hello everyone,
sorry about my question, but I got many issues when I tried to run the WeatherTwentyOne project, I missed something for sure... can help? I would like to run for now using Android Platform. Maybe I am confuse, and I should run dotnet commands to update  something, not sure...
Severity	Code	Description	Project	File	Line	Suppression State
Error	NETSDK1045	The current .NET SDK does not support targeting .NET 6.0.  Either target .NET 5.0 or lower, or use a version of the .NET SDK that supports .NET 6.0.	WeatherTwentyOne.WinUI	C:\Program Files\dotnet\sdk\5.0.400\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets	141
Severity	Code	Description	Project	File	Line	Suppression State
Error	NETSDK1139	The target platform identifier android was not recognized.	WeatherTwentyOne	C:\Program Files\dotnet\sdk\5.0.400\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets	109
See the image:

Use VS 2022 Preview. Yours look like VS 2019


Adding Sliding Window Technique

Adding new cpp file with illustration of Sliding Window Technique.
and improving the readme file with proper explanation.

@rajprem4214, be more specific. Which folder do you plan to add in?
Sliding window technique is best explained taking an example problem, So, explain properly how you are going to implement it.


Fixed Contact-Us Page Test

I broke the test on /contact-us/ when I changed all our arrow links in #793. I also spaced out that line and one other in the file to fix two eslint warnings.
Testing

run protractor test/browser_tests/conf.js

Preview

Review

@anselmbradford
@jimmynotjim
@sebworks

:+1: LGME


Search does not work after return to search results from a selcted title

The search functionality no longer works after selecting a title and returning to the search results via the browsers back button.
Repro:

search for a title
select any title
use browser back button
subsequent searches are no longer executed/ran and results do not update

Experienced on Safari 17.3 (196<IP_ADDRESS>.8) and Firefox 121.0.1 (64-bit)

Thx! Taking a look


Unknown error, or, how do I debug failed runs?

Unfortunately I don't have very much information to offer on this issue. I've tried to gather everything of value that I could think of, and I'll be more than happy to try and dig up more specifics if you can tell me how to provide them.
I have a geojson file that's ~14gb in size.
It's a set of high-detail features covering a US state.
The data was originally 10s of shapefiles. I've processed them using other software in to the single geojson file. I also stripped out all the unwanted attributes at the same time, leaving just the two that I'm interested in. (Gotta try to keep the data minimal!)
I've then tried to process them using tippecanoe in Docker, as I'm running on a Windows machine.
The docker container OS is: Ubuntu 16.04.5 LTS
Here's the command line I'm using to execute tippecanoe: docker run -it --rm -v ${pwd}:/data tippecanoe:latest tippecanoe -f -o /data/Risk.mbtiles -zg --extend-zooms-if-still-dropping --drop-smallest-as-needed /data/Risk.geojson 1>stdout.txt 2>stderr.txt
stderr.txt ends up with nothing in it.
stdout.txt does have some output in it, but nothing of apparent use:

For layer 0, using name "Risk"
Read 0.00 million features
Read 0.01 million features
Read 0.02 million features
Read 0.03 million features
Read 0.04 million features
Read 0.05 million features
Read 0.06 million features

I've had a look around the excellent documentation on the tippecanoe github home page (it's helped me a lot as I've been working with this tech for the last few weeks, thank you!) but I've not been able to find much about getting "enhanced logging", or any other debug information which would help me track down the problem.

The debugging information ought to be in the log of the standard error. In ordinary use I don't think there will be anything on the standard output.
If you are finding the progress messages to be too noisy, you can use --no-progress-indicator to log only errors and warnings, not progress messages.
Maybe you are running out of disk space before anything interesting happens, and it is losing your error log as well as the actual intended output because there is no room to store either of them?

Please reopen if there are further questions.

Thank you for your reply, it gave me some things to think about, and made me realize I'm probably not capturing standard error correctly.
I'm currently working through that but it revolves around the environment I'm using, and isn't really anything to do with tippecanoe specifically.
If I get to the point where I do have tippecanoe specific questions then I'll reopen as you suggest.
Sorry for taking so long to reply. As so often happens, other things took me away temporarily from this work, but I still could have and should have responded sooner.


Developer file preview shows html code, overriding an html previewer that actually renders the html

Microsoft PowerToys version
0.57.0
Running as admin

[ ] Yes

Area(s) with issue?
Developer file preview
Steps to reproduce

Enable this setting: File Explorer add-ons>Preview Pane> Enable developer files preview.
Preview an html file in Explorer - it shows html code, i.e. it does render the content.  This is probably not what most people want.
Preview a markdown file in Explorer - it is rendered.  Why the inconsistency?
Disable the setting and html files are rendered in the preview pane.  If there's actually a reason for the PowerToys previewer to show the code instead of rendering the html, perhaps an option to disable the PowerToys preview for specific file types such as html.  Or follow the suggestion from a few years ago to provide buttons to toggle between previewing as code or rendered.

✔ Expected Behavior
Rendered html in the preview pane.
❌ Actual Behavior
html displayed as code in the preview pane.
Other Software
No response

The HTML previewer that renders the HTML may be Microsoft Edge or other browsers, we do currently preview code only.
cc: @Aaron-Junker Is it possible to add an extension exclude list to the Monaco preview so the user can use the existing preview handler?

The HTML previewer that renders the HTML may be Microsoft Edge or other browsers, we do currently preview code only.
cc: @Aaron-Junker Is it possible to add an extension exclude list to the Monaco preview so the user can use the existing preview handler?

Well it's surely not impossible. But how exactly should this work? When developer previes is set on it automatically overwrites the other preview handlers (I may be wrong). This would only work for built in previewers.

When it's enabled, we write the preference in CURRENT_USER. default previewers usually are set up in LOCAL_MACHINE. So if we remove form CURRENT_USER, the PC would still default to LOCAL_MACHINE.

A separate checkbox for 'enable HTML previewer' may be enough, if cluttering the interface with a handler mapping manager is undesirable.
That said, with all the work you are doing on preview handlers, an extension-to-handler GUI might well be useful as its own PowerToy -- especially if could be used to set HKCU and HKLM (subject to admin).


[Feature] Option to fetch history rows with undefined keys

I don't see an efficient way to get a history object for a number of runs where the desired keys might not be available in some of the runs.
One option is to fetch all keys and filter locally, which is especially impractical for media types which I don't need in many situations. An alternative approach requires an accurate knowledge of run/key mapping and building from smaller queries. Unfortunately, I have not found an easy way to get this kind of information through the API.
I would like to have an option to fetch a filtered view (through history and scan_history) without discarding rows with missing values. Or at least an option to ignore_keys so that at least some of the columns can be excluded before being sent.

@karolpiczak you're right, currently we only return rows with all instead of any of the keys present. Thank you for suggesting this improvement. We're not going to address this soon, but we'll keep in our backlog.

Hi, is there any update on this? I am unable to retrieve my rows because they have at least one missing column each.


Create CODE_OF_CONDUCT.md

Pull Request Test Coverage Report for Build 14

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.431%

Totals

Change from base Build 12:
0.0%

Covered Lines:
384

Relevant Lines:
411

💛  - Coveralls


[internal] refactor and minor improviment

Component
[x] PowerShell module
[] VSCode extension
[] Other
Description of the issue
minor issues and refactor needed:

hide unused cmdlets: Get-AzUpgradeCmdletSpec, Get-AzUpgradeAliasSpec to private
refine parameters of existing cmdlets (need to discuss)
refactor Disable/Enable AzUpgradeDataCollection

Describe how to reproduce the issue
Be as precise as possible about the reprduction steps
Environment
Describe the environment on which this issue is happening
Error output
Share the error log
Additional context
Add any other context or screenshots about the issue here.

hide unused cmdlets: Get-AzUpgradeCmdletSpec, Get-AzUpgradeAliasSpec to private
-> this would be breaking change. we need to check the usage.


Create a nix flake for reproducible development and build environments

This PR adds a nix flake definition, which provides as output a devshell, i.e. a development environment containing all necessary tools and libraries to work with bridle.
This (optionally) removes the dependency on any distribution packages installed via apt (or equivalent) apart from Nix itself, and removes the need for pip and virtualenv entirely.
To evaluate the flake, install Nix (the package manager), e.g. by apt install nix. Then either add experimental-features = nix-command flakes to ~/.config/nix/nix.conf, or add --experimental-features 'nix-command flakes' to any nix command.
After that, simply navigate to the bridle directory, and run nix develop to enter the devshell environment.
As a proof-of-concept, the PR also includes a subflake nix-workspace, which provides a fully fetched and initialized west workspace. This can be used to define derivations that include west commands, as demonstrated by the bridle-doc package also provided by the main flake. This makes it possible to generate the full documentation set by running nix build .#bridle-doc, also without installing any further dependencies or creating a local workspace.
This subflake is auto-generated via a python script, also currently located in nix-workspace. This script parses the project's west manifest and generates corresponding flake inputs, which can then be locked. Re-generating the subflake is only needed after manifest changes, otherwise upstream changes will be brought in via nix flake update as normal.
Note that the setup still suffers from an issue with subflakes, which requires building the required outputs from the subflake at least once to create a reference in the local nix store, before the main flake can reference it. In this case this means running nix build nix-workspace#workspace.

I've reworked this a bit, hopefully making it simpler to use and to understand.
All python dependencies are now collected in nix/python-dependencies.nix. Since a handful of packages in there aren't in nixpkgs, I've added basic derivations for them, also all found under nix/. These then get appended to the upstream package set so no additional special treatment is necessary.
I've also used the get-flake flake to make importing the workspace subflake much easier (no more explicitly building the package before using it!).
Both nix/python-dependencies.nix and nix/workspace/flake.nix can be re-generated by running west nix-update, which will also update the workspace subflake inputs, to make sure nix and west see the same upstream revisions. By running this after west update, the two should stay in sync.
Finally I've added a section to the documentation on how to start using the flake, although without going into detail on the underlying principles of nix and flakes (that is better explained elsewere, anyway).

In light of west2nix now being available, which in combination with pyproject2nix solves all these problems much more elegantly, I have reworked the flake to use those instead.
This has made things much simpler, since python dependencies are resolved directly from the requirements.txt, and the workspace can simply be locked into a west2nix.toml file with a single command, with no additional code generation.
I've also moved the additionally packaged python dependencies into an external repository, so updating them won't require action in this one.


Please enter valid Api Key. when trying to change to new wakatime key

The key is copied directly from wakatime and put into excel without any proxies... Still I get the error Please enter valid Api Key.

I had the same issue, in another thread it was stated that the issue was to use the "waka_" in the beginning. So you should delete it when adding the api key

Same here, even if I remove the waka_ prefix. I tested with:

2.1.1
2.1.0
2.0.0

Windows 11 x64
Excel 2016

Removing waka_ prefix is not working because you first paste into input box which removes last 5 characters.
You should only copy non waka_ part and past it. It will work.


LSP: Auto import

The VSCode extension doesn't seem to suggest auto-imports at the moment. I rely on them heavily, and would love to see support for them.

And possibility to configure it, for example:
import like this:
import { prop } from 'lib'

or like this:
{ prop } from 'lib'

and if it type only:
type { SomeType } from 'lib'

import type { SomeType } from 'lib'

import { type SomeType } from 'lib'

{ type SomeType } from 'lib'

Another vote for this from me . It seems that VSCode can spot a civet file but, ctrl + spaceing it doesn't add the import declaration at the top. When manually writing it there's a 'cannot find module' error annotation.


Update: OpenWhisperSystems.Signal version 5.43.0 [FP-D]

Result: Installation Successful

Manifest
Add/Remove Programs

Name
Signal
Signal 5.43.0

Version
5.43.0
5.43.0

Publisher
Signal Messenger, LLC
Signal Messenger, LLC

ProductCode

7d96caee-06e6-597c-9f2f-c7bb2e0948b4

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 1571

@wingetbot run


fix(compiler-core): should only skip v-is on , don't inc…

…lude :is
fix #1018

I don't think this is the correct fix - see 7d0ab339


Voice dictation shortcut

Type: Bug
Thanks for adding dictation! Features like this are great for users with limited mobility (or those looking for a performance boost)
Ask: can you update the shortcut so it is consistent with W/X/P?
In those apps it is Alt+`
A great accessibility experience includes having consistency across workflows. Thanks for investing in features like these
VS Code version: Code 1.87.0 (019f4d1419fbc8219a181fab7892ebccf7ee29a2, 2024-02-27T23:41:44.469Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 9 5900X 12-Core Processor             (24 x 3700)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.92GB (15.85GB free)

Process Argv
--crash-reporter-id 14dd867b-75ec-4cb0-9d8b-b25e728286ca

Screen Reader
no

VM
0%

Extensions (20)

Extension
Author (truncated)
Version

vscode-markdownlint
Dav
0.54.0

docs-article-templates
doc
1.0.3

docs-authoring-pack
doc
1.0.1

docs-build
doc
0.4.2

docs-markdown
doc
1.0.3

docs-preview
doc
1.0.3

docs-yaml
doc
1.0.1

kusto
don
0.4.4

vsc-material-theme
Equ
34.3.1

vsc-material-theme-icons
equ
3.5.0

prettier-vscode
esb
10.1.0

copilot
Git
1.171.0

copilot-chat
Git
0.13.0

Learn-Training-AI-Assistant
Lea
1.0.35

vscode-dotnet-runtime
ms-
2.0.2

vscode-edge-devtools
ms-
2.1.5

debugpy
ms-
2024.2.0

python
ms-
2024.2.1

vscode-yaml
red
1.14.0

kuskus-kusto-syntax-highlighting
ros
1.2.1

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:30899288
vscaat:30438848
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
accentitlementst:30887150
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfcontrol:30973184
d34g3935:30971562
edj9j583:30969295
a89i1917:30973842
bg6jg535:30958357
ccp2r6:30958158
dsvsc020:30973508

@bpasero , what do you think of this?
When I reassigned the keybinding to be `alt+``, it did not work with this log:
 Ignoring single modifier alt due to it being pressed together with other keys.

Yes that makes good sense to me, I was not aware of a standard keyboard shortcut.
@ulugbekna could you possibly assist @meganrogge with the keybinding trouble? Thanks1

Correct. This is about the dictate command and not the copilot chat one. ctrl+alt+v
From: Benjamin Pasero @.>
Sent: Monday, March 4, 2024 3:22 PM
To: microsoft/vscode @.>
Cc: Mention @.***>
Subject: Re: [microsoft/vscode] Voice dictation shortcut (Issue #206800)
Yes that makes good sense to me, I was not aware of a standard keyboard shortcut.
@ulugbeknahttps://github.com/ulugbekna could you possibly assist @meganroggehttps://github.com/meganrogge with the keybinding trouble? Thanks!
@BeReasonablehttps://github.com/BeReasonable to clarify, you are talking about the feature to dictate into the text editor, but not dictate into Copilot chat? We currently have 2 different keybindings for each (Ctrl+Alt+V for dictate and Ctrl+I to chat).

Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/206800#issuecomment-1977386128 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3OLHNY74YTHFJZLLLXU7LYWTJWZBFKMF2HI4TJMJ2XIZLTS2BKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZTCNRYGEZTGNRUURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SNJXHAYDINZRGIZ2I3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGYYDGMRSGEZTCMBVURXGC3LFVFUGC427NRQWEZLMVRZXKYTKMVRXIX3UPFYGLLCJONZXKZKDN5WW2ZLOOSTHI33QNFRXHFMCUR2HS4DFVJZGK4DPONUXI33SPGSXMYLMOVS2QNBRHA4DCOJQGCBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIYTMNZQGEYTQNZQQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJTGE3DQMJTGM3DJAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTKNZYGA2DOMJSGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGYYDGMRSGEZTCMBVU52HE2LHM5SXFJTVOBSGC5DF.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@meganrogge

When I reassigned the keybinding to be alt+`, it did not work with this log:

Could you show all logs produced by keyboard troubleshooting when you press alt+` ?
Could you also press alt+ at https://w3c.github.io/uievents/tools/key-event-viewer.html and show the output? I wonder if alt+ is a system shortcut that's not captured by OS and not passed to apps

2024-03-07 09:41:39.342 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-03-07 09:41:39.343 [info] [KeybindingService]: | Resolving alt+[Backquote]
2024-03-07 09:41:39.344 [info] [KeybindingService]: \ From 1 keybinding entries, matched workbench.action.editorDictation.start, when: hasSpeechProvider && !editorDictation.inProgress && !editorReadonly, source: user.
2024-03-07 09:41:39.352 [info] [KeybindingService]: + Storing single modifier for possible chord alt.
2024-03-07 09:41:39.352 [info] [KeybindingService]: + Clearing single modifier due to other key up.
2024-03-07 09:41:43.636 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-03-07 09:41:43.636 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-03-07 09:41:43.637 [info] [KeybindingService]: / Received  keydown event - modifiers: [meta], code: MetaLeft, keyCode: 91, key: Meta
2024-03-07 09:41:43.637 [info] [KeybindingService]: | Converted keydown event - modifiers: [meta], code: MetaLeft, keyCode: 57 ('Meta')

It doesn't end up working and the ` is sent to the editor.
https://github.com/microsoft/vscode/assets/29464607/ad62ff01-4c24-4c49-a13f-57385d9d0a38

Neither shortcut works. Ctrl-Alt-V doesn't trigger dictation. Neither does Alt-` when I remap it
From: Benjamin Pasero @.>
Sent: Monday, May 13, 2024 10:05 AM
To: microsoft/vscode @.>
Cc: Mention @.>; Author @.>; Comment @.***>
Subject: Re: [microsoft/vscode] Voice dictation shortcut (Issue #206800)
@BeReasonablehttps://github.com/BeReasonable are you able to assign the desired keybinding when you go to your keybinding settings or does it not work at all?

Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/206800#issuecomment-2107665442 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3OLHM74DHTPGSB7FAXEN3ZCDB7RBFKMF2HI4TJMJ2XIZLTS2BKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZTCNRYGEZTGNRUURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SNJXHAYDINZRGIZ2I3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGYYDGMRSGEZTCMBVURXGC3LFVFUGC427NRQWEZLMVRZXKYTKMVRXIX3UPFYGLLCJONZXKZKDN5WW2ZLOOSTHI33QNFRXHFMCUR2HS4DFVJZGK4DPONUXI33SPGSXMYLMOVS2QNBRHA4DCOJQGCBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIYTMNZQGEYTQNZQQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJTGE3DQMJTGM3DJAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTKNZYGA2DOMJSGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGYYDGMRSGEZTCMBVU52HE2LHM5SXFJTDOJSWC5DF.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@BeReasonable you need to install https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-speech

Nice!
I've installed the extension, and Alt-` does work when I override the setting in vscode.
From: Benjamin Pasero @.>
Sent: Monday, May 13, 2024 10:40 AM
To: microsoft/vscode @.>
Cc: Mention @.>; Author @.>; Comment @.***>
Subject: Re: [microsoft/vscode] Voice dictation shortcut (Issue #206800)
@BeReasonablehttps://github.com/BeReasonable you need to install https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-speech

Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/206800#issuecomment-2107799495 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3OLHPA5ES6DI53X7JCWZ3ZCDGFRBFKMF2HI4TJMJ2XIZLTS2BKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZTCNRYGEZTGNRUURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SNJXHAYDINZRGIZ2I3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGYYDGMRSGEZTCMBVURXGC3LFVFUGC427NRQWEZLMVRZXKYTKMVRXIX3UPFYGLLCJONZXKZKDN5WW2ZLOOSTHI33QNFRXHFMCUR2HS4DFVJZGK4DPONUXI33SPGSXMYLMOVS2QNBRHA4DCOJQGCBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIYTMNZQGEYTQNZQQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJTGE3DQMJTGM3DJAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTKNZYGA2DOMJSGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGYYDGMRSGEZTCMBVU52HE2LHM5SXFJTDOJSWC5DF.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@BeReasonable when you type that into the keybindings editor, how does it appear, literally as Alt+` ?

I am not on a US keyboard, so thats why I wonder.

Yes
From: Benjamin Pasero @.>
Sent: Monday, May 13, 2024 11:10 AM
To: microsoft/vscode @.>
Cc: Mention @.>; Author @.>; Comment @.***>
Subject: Re: [microsoft/vscode] Voice dictation shortcut (Issue #206800)
@BeReasonablehttps://github.com/BeReasonable when you type that into the keybindings editor, how does it appear, literally as Alt+` ?
image.png (view on web)https://github.com/microsoft/vscode/assets/900690/03555da0-9a96-4b7f-aa08-935aa4efe34f
I am not on a US keyboard, so thats why I wonder.

Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/206800#issuecomment-2107926423 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3OLHJLECQQVPN5QRZETB3ZCDJTHBFKMF2HI4TJMJ2XIZLTS2BKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZTCNRYGEZTGNRUURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SNJXHAYDINZRGIZ2I3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGYYDGMRSGEZTCMBVURXGC3LFVFUGC427NRQWEZLMVRZXKYTKMVRXIX3UPFYGLLCJONZXKZKDN5WW2ZLOOSTHI33QNFRXHFMCUR2HS4DFVJZGK4DPONUXI33SPGSXMYLMOVS2QNBRHA4DCOJQGCBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIYTMNZQGEYTQNZQQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJTGE3DQMJTGM3DJAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTKNZYGA2DOMJSGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGYYDGMRSGEZTCMBVU52HE2LHM5SXFJTDOJSWC5DF.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@BeReasonable can you clarify where the keybinding is documented for Windows? I only found https://support.microsoft.com/en-us/windows/use-voice-typing-to-talk-instead-of-type-on-your-pc-fec94565-c4bd-329d-e59a-af033fa5689f#WindowsVersion=Windows_11 which talks about another keybinding?

The Home ribbon in W/X/P/Outlook
[A screenshot of a computer  Description automatically generated]
From: Benjamin Pasero @.>
Sent: Monday, May 13, 2024 11:28 AM
To: microsoft/vscode @.>
Cc: Mention @.>; Author @.>; Comment @.***>
Subject: Re: [microsoft/vscode] Voice dictation shortcut (Issue #206800)
@BeReasonablehttps://github.com/BeReasonable can you clarify where the keybinding is documented for Windows? I only found https://support.microsoft.com/en-us/windows/use-voice-typing-to-talk-instead-of-type-on-your-pc-fec94565-c4bd-329d-e59a-af033fa5689f#WindowsVersion=Windows_11 which talks about another keybinding?

Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/206800#issuecomment-2107998731 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3OLHPEWIH7ITZZSOE4VFLZCDLWTBFKMF2HI4TJMJ2XIZLTS2BKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZTCNRYGEZTGNRUURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SNJXHAYDINZRGIZ2I3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGYYDGMRSGEZTCMBVURXGC3LFVFUGC427NRQWEZLMVRZXKYTKMVRXIX3UPFYGLLCJONZXKZKDN5WW2ZLOOSTHI33QNFRXHFMCUR2HS4DFVJZGK4DPONUXI33SPGSXMYLMOVS2QNBRHA4DCOJQGCBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIYTMNZQGEYTQNZQQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJTGE3DQMJTGM3DJAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTKNZYGA2DOMJSGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGYYDGMRSGEZTCMBVU52HE2LHM5SXFJTDOJSWC5DF.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Possible edge-case bug while deserializing

Hello,
I don't know if this library is maintained or receives updates, but I think we just encountered a serialization bug using this code:
String dec1 = "[{\"f\":\"crb:language\",\"v\":\"Englids\",\"b\":\"-\"}]";
String enc1 = LZSEncoding.compressToEncodedURIComponent(dec1);
String dec2 = LZSEncoding.decompressFromEncodedURIComponent(enc1);

The final decompressFromEncodedURIComponent() call ends with an String index out of range: 66 exception.
Note that we deliberatly used the word "Englids" instead of "English" (it crashes too) to investigate/demonstrate/debug.
Any help resolving this?
all the best,
b.

I'll look into this now. This library, surprisingly, hasn't needed much attention lately, even with me using some variants on its code in more places. The original algorithm was by one person, and I based my code off someone else's port of that to Java, so there's several places there could be some mistake porting. Most likely, it's my mistake, and I hope that it is because I don't think I ever really understood how the algorithm works deep inside.

Watch out: dollar sign isn't a valid URI character by rfc3986, I think...
See https://datatracker.ietf.org/doc/html/rfc3986#section-2.3

The dollar sign is defined as a sub-delimiter, though I can't seem to figure out what "sub-delimiter" means in the first RFC... The only point of the trailing dollar signs is to use as padding, like what base64 I believe is supposed to use for its padding. The padding doesn't have any semantics associated with it other than empty space. Based on the original library, their tests actually check reading a String padded with dollar signs: https://github.com/pieroxy/lz-string/blob/master/src/encodedURIComponent/tests/encodedURIComponent.test.ts#L27
If I can figure out a way to skip padding entirely, I'll do that. For now, I think padding is required to support.

Ah, I was unaware the original Pieroxy lib also pads using $, which is a bit... exotic.
I've implemented an experimental version of your base64 encoding using your LZByteEncoding class in the TransmissionDemo. The dependency on libgdx can simply be removed by using a standard ByteArrayOutputStream (replace .add() by .write() and shrink() by toByteArray()). This generates a byte stream which can be base64url encoded using eg. java.util.Base64.
It seems to work very well until now, maybe a thought?

I think I stayed away from java.util.Base64 because for a while it wasn't implemented on all platforms I want to support. Mainly, iOS via RoboVM is a nice target in theory, but doesn't support any APIs added in Java 8 or newer (it does support Java 8's language-level features). I'm pretty sure Base64 was added in 8 or newer... And yes, it isn't much fun to be stuck on Java 7 APIs. One of my projects was started under the assumption that Java 8 APIs were coming soon to RoboVM, letting me use those APIs everywhere... And I started that project in 2020... Still waiting. Though I did figure out ways to avoid the APIs and still use default methods and lambdas.
I think LZByteEncoding does comparable work to the UTF16, Base64, or URI Encoding schemes, it just outputs a whole 8-bits as a byte instead of just 6 bits for Base64 or URI Encoding that get sent to a lookup table. Running java.util.Base64 on that seems like doing the work twice, just maybe faster for the second phase if the JVM is optimized for it.
I do use that byte-based compression in some other places; it would be interesting if Emscripten or something similar could be used with heavier-duty, more modern compression like LZ4 or ZStd to get them to work on the web. As long as the wrappers matched up between the JS that GWT calls and the Java used elsewhere, it could be pretty convenient even if the generated JS was large.

Aha, yes, I think java.util.Base64 was added quite recently. You're right that running the byte buffer through a Base64 decoder/encoder is doing the work twice, it was a quick fix because the lz-string base64url encoding/decoding is super arbitrary. lz-string.js even uses '+' in URL-safe mode, which introduces a lot of problems because they are decoded to a space (+/ should just be replaced with -_ as described by https://developer.mozilla.org/en-US/docs/Glossary/Base64).

"Should" just be replaced depends entirely on what's encoding and decoding. Base64...

typically refers to the version of Base64 outlined in RFC 4648, section 4, which uses the following alphabet to represent the radix-64 digits, alongside = as a padding character:

ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/

And that ends with + and /, which are what the Base64 mode here uses. The issue is with the URI Safe encoding, which is definitely arbitrary and I'm open to using an existing standard here instead of whatever it is lz-string is using. I'm also open to allowing users to provide their own 65-char Strings to match whatever they need.


Update to ng-lodash 0.4

Version 0.4 of ng-lodash is available:
https://github.com/rockabox/ng-lodash/releases

Fixed in version v1.0.3
https://github.com/puzzle/ng-user-auth/releases/tag/v1.0.3


Remove UUID dependency in favour of own key generation system

Hey @jeremybarbet, did some tweaking to generate our own solution to this.
Really happy if you'd rather go with UUID route.
But in summary, this:

keeps track of used keys,
retries if it hits a duplicate (up to 5 times, but thats such an edge case as it's so random it should be fine, just wanted to stop an endless loop of retries)
removes used keys on unmount

And doesn't have any external dependencies.
Should fix #10 too
Let me know your thoughts or if my code could be better :-)
Thanks bossman

Could you rebase against master? your changes already merged are also here.

I think I've rebased correctly! Please have a look :-)
Next task is to work on utils/key gen :)

@jeremybarbet I've created external hook: hooks/useGeneratedKey.ts
The array of used keys doesn't need to be a ref because it's not stored within a React component that re-renders (just stored at the top of the hook file).
Testing seems to show all working!
Attached is screenshot of it adding keys. It removes them successfully too.
No clashes yet (you can see how random the keys are!)
Let me know your thoughts :-)

@jeremybarbet I've refactored as you've requested 👍
Only thing to note is there's no benefit to using Refs for the lets inside generate key, as they are all block-level scoped to the generateKey function and just used to generate the key temporarily. Is that ok?
Would love to know your thoughts on if my first dip into typescript went well!!

I have only a few comments on the code style. Sorry I'm super picky on the coding guideline 🤓

No worries! Just committed all your suggestions, take a look and make sure youre happy :-)

Looks good now, I will release a new version and you can test it out! Thanks for your contribution!

Hi @jeremybarbet - this seems to work great in all use cases I have in my app upon updating to 1.0.7 and removing the dep on the polyfill. I'm looking at that fresh issue  (#12) but not sure what the scenario is. Great work @harveyappleton @jeremybarbet ! Thank you


[SPARK-6087][CORE] Provide actionable exception if Kryo buffer is not large enough

A simple try-catch wrapping KryoException to be more informative.

Can one of the admins verify this patch?

ok to test

LGTM.

Test build #28388 has started for   PR 4947 at commit 48ab7f9.

This patch merges cleanly.

Test build #28388 has finished for   PR 4947 at commit 48ab7f9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28388/
Test PASSed.

Test build #28397 has started for   PR 4947 at commit 0f7a947.

This patch merges cleanly.

LGTM. I'll wait a bit longer for more comments.

Test build #28397 has finished for   PR 4947 at commit 0f7a947.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class BinaryClassificationMetrics(JavaModelWrapper):

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28397/
Test PASSed.

Is this not needed or serializeStream as well?

@sryza KryoSerializer.maxBufferSize is used only in KryoSerializer.newKryoOutput, which, in turn, is used only in KryoSerializerInstance. KryoSerializationStream uses output passed in arguments, so spark.kryoserializer.buffer.max.mb doesn't affect it. Same applies to JavaIterableWrapperSerializer.

Yes, that looks correct. In the other cases, we aren't writing to an internal buffer, not one that is controlled by this buffer size setting.


Implementation of base64 mime code

This API could be usefull to implement digital signature applications. In this API after 76 encoded characteres an CRLF code is added.

Hi, thanks a lot for this. Do you have a pointer to the spec for this? I can't find a useful spec.

Without a spec this will slip to 1.3

Looks like RFC 2045 defines the table.

Isn't this now superseded by @ASzc 's work on ceylon.buffer?

Can one of the admins verify this patch? (see README)

Yes, it is. Also, as far as I can see the only difference here from regular base64 is some extra following characters (the table appears to be the same at least), which I don't think justifies another base64 variant in ceylon.buffer.base. It's easy enough to add/strip those around the library.

Ok, I'll close this then. If someone disagrees let them speak up.
But thanks to @charlessea for the original implementation in any case!


(READ THIS ONE FIRST!) Feature/merge argocd branch

This is a catch-all commit representing the merged changes between the "master" and the "feature/argocd" branches. I.e., I have provided you with several PRs today, split out into individual features where we have added/changed functionality. In addition, we merged in the addition features you had in "master", since we are interesting in using them (for example the "external-secrets"). This however means that the git commit history has become somewhat entangled and would make sensible PRs quite difficult. As a result, all of these PRs have bee  constructed manually.
This final catch-all PR represents the results of the merge between the "master" and the "feature/argocd" branches that still remain after the other PRs have been merged in.
I realise that this may cause some additional merge conflicts along the way, but this would be isolated to differences between "master" and "feature/argocd" and should be easy enough to clear up.
Thanks very much for a very cool repository. We have plenty of additional ideas and would love to continue contributing!

Take its as-is, in finally, we add some stabilize patch. In connection with the relocation of modules to separate repositories, these changes will be checked again and transferred to the corresponding repositories


Example for processing preupload

Would it be possible to provide an example of how to modify the file pre-upload in the upstream?
IE. Generate a resized image before uploading.
or could this API also be used for uploading a file stored from the .tmp directory?

+1

+1

I tried to use gm to resize the image before uploading to s3, but due to limited knowledge of streams, I had no luck so far. An example of the preprocessing will be very helpful!

The way I do it now is use skipper-disk, resize the image locally and upload that one. That's a very bad way to do it though

The short answer is, there's no way to do this with the S3 adapter as-is.
To do it, need to add some code to the receiver that accepts a Transform stream as an option, pipes __newFile through the transformer, and then sends the transformed stream to S3 instead of __newFile.
Of course, a better solution would be to tackle this at the Skipper level, by allowing you to pass in an array of Transform streams that should operate on any files before they hit the receivers at all.  If anyone's up for it, this would be a great addition to the project.


Add a go-to-production document

Signed-off-by: Andy Doan<EMAIL_ADDRESS>

@mike-scott @ricardosalveti - I think there's more we can/should add here. I'm posting it in hopes we can collect more information and get this complete enough for now.

Docs for ff90ab5f419f97e64be3b6b94772f51ed354062d are browesable at: https://ci.foundries.io/projects/fio-docs/builds/844/docs/artifacts/html/index.html

@rsalveti @mike-scott - this thing is starting to bit rot. we may want to sit down next week and discuss

@dagriego @doanac @mike-scott let's use the eng chat meeting to discuss this one, and see what else we might want to add here.

@doanac Checking in on the status of this document, should this be revived?


Special characters can break infoset

If you try to save a special character (know about vertical tab but surely this is not the only one) to an infoset-backed but also record-stored content part then you can cause a YSOD only fixable by editing the DB. Such a character can mess up the infoset's XML, resulting in the below exception being thrown.
2017-02-07 04:33:07,785 [15] Orchard.ContentManagement.DefaultContentManager - (null) - ArgumentException thrown from IContentHandler by Orchard.ContentManagement.FieldStorage.InfosetStorage.InfosetHandler [(null)]
System.ArgumentException: '', hexadecimal value 0x0B, is an invalid character.
   at System.Xml.XmlEncodedRawTextWriter.InvalidXmlChar(Int32 ch, Char* pDst, Boolean entitize)
   at System.Xml.XmlEncodedRawTextWriter.WriteAttributeTextBlock(Char* pSrc, Char* pSrcEnd)
   at System.Xml.XmlEncodedRawTextWriter.WriteString(String text)
   at System.Xml.XmlWellFormedWriter.WriteString(String text)
   at System.Xml.Linq.ElementWriter.WriteStartElement(XElement e)
   at System.Xml.Linq.ElementWriter.WriteElement(XElement e)
   at System.Xml.Linq.XElement.WriteTo(XmlWriter writer)
   at System.Xml.Linq.XNode.GetXmlString(SaveOptions o)
   at Orchard.ContentManagement.FieldStorage.InfosetStorage.Infoset.get_Data()
   at Orchard.ContentManagement.FieldStorage.InfosetStorage.InfosetHandler.Creating(CreateContentContext context)
   at Orchard.ContentManagement.DefaultContentManager.<>c__DisplayClass41_0.<Create>b__0(IContentHandler handler)
   at Orchard.InvokeExtensions.Invoke[TEvents](IEnumerable`1 events, Action`1 dispatch, ILogger logger)

The offending character will be saved to the record's field but it won't succeed getting into the infoset, thus this write operation will be retried forever, without success. I guess that if there's no record then just saving the item would fail.
We should probably do some encoding in InfosetHelper.Store()? Note that I experienced this with TitlePart, so maybe it's only affecting infoset values if they're stored in an attribute like in this case.

The solution might be to sanitize all input in forms with regards to control characters (i.e. character code is less than 32), although some might be actually valid to store in the DB.

I doubt that an XmlDocument would not encode these chars automatically. Can you repro it from a console app?

Let's look at the XML specification and XDocument documentation to see what chars are not allowed.
Repro:
            XDocument doc = new XDocument();
            doc.Add(new XElement("foo", @"bar" + Char.ConvertFromUtf32(20) + /*Char.ConvertFromUtf32(0x0b) +*/ "bar"));
            Console.WriteLine(doc.ToString());

https://www.w3.org/TR/xml/#NT-Char states the allowed chars, to summarize, any char less than 0x20 is forbidden with the exception of 0x9, 0xA, and 0xD.
This SO answer explains how to read any document with invalid chars: http://stackoverflow.com/a/18020992/142772
Not sure if the same exists on serialization, or we'll need to sanitize once the infoset is read.

Have also experienced this though i forget what the character was!

Or read the content using:
XDocument xDocument = null;
XmlReaderSettings xmlReaderSettings = new XmlReaderSettings { CheckCharacters = false };
using (XmlReader xmlReader = XmlReader.Create(filename, xmlReaderSettings))
{
    xmlReader.MoveToContent();
    xDocument = XDocument.Load(xmlReader);
}

I've pushed a failing test into this branch: https://github.com/Lombiq/Orchard/commits/issue/ORCH-208 (see InfosetFieldStorageProviderTests.ForbiddenXmlCharactersDontBreakInfoset). However, on the fix I'd need some advises.
The issue is that you can save such invalid characters into an XElement and you can read it out if you read the attribute or the node's value directly but you'll see this exception if you do a ToString(). This is somewhat inconsistent IMO and there is no way to tell ToString() to ignore such errors.
I've thought about the following fixes:

Go through XmlReader as Sebastien suggested above, but that sounds a bit heavy for me (we don't use XmlReader here otherwise, so we'd introduce it just for this).
Custom XElement.ToString() implementation: we can write some tree-walking code to build the XML string by accessing the elements' and attributes' values, which, since this works, wouldn't fail.
Using XmlConvert.EncodeName() when saving values and XmlConvert.DecodeName() when reading them. This would work I think perfectly but might break already saved values in existing installations if they look like encoded XML characters.
Custom escaping logic: we could minimize the possibility of breaking existing data if we just escape the 29 control characters causing issues (escaping "\0" e.g. is simply "\0").

What do you think? None of these seem too appealing to me...

Also, there's more than one place where the Infoset XML is directly written, so whatever we do should affect all of these:

InfosetHelper
InfosetPart
InfosetStorageProvider

The approach we'll take as discussed during the meeting: Throw an exception when saving offending characters that'll explain which character is invalid and tell you not to use it. It also seems that the current behavior is a bug in XDocument since it either should encode the characters, or throw an exception as soon as you try to save it.


Duplicate entries for spliceu index

I'm not sure if I should be asking this here or on the alevin fry repo or here but anyway: I'm building a spliceu index and then using it for aligning a SPLiT-seq single nuclei (mouse) dataset. I'm trying to understand how duplicate entries from the GTF are handled. Naturally enough, for all single exon genes the unspliced pre-mRNA and the (presumably single) transcript are "duplicates", and these are deduped from spliceu.fa if I use the --dedup-seqs option to pyroe. However, they are not removed from e.g. spliceu_t2g.tsv or the resulting quantification after running quant, e.g. the duplicates are in the dumped equivalence classes (what I actually want to use) as well as quants_mat_cols.txt. This seems odd to me: wouldn't you want to avoid having duplicated features to align to and quantify (since they are indistinguishable anyway)?
Happy 4th :)

Hi @davidaknowles,
Thanks for reporting this.  I think it's fine to report it here, though with our movement from pyroe to roers, we'll want to make sure that we include any changes there as well (cc @DongzeHE).
I agree that it seems somewhat inconsistent to remove the sequence from the generated fasta but to leave the labels in the spliceu_t2g.tsv (which therefore propagate to the quants_mat_cols.txt file).  I guess there is a legitimate question of how one should handle a cases such as this.  I see 2 options that would be "consistent":

Remove all but one of the sequence identical targets, but then generate another file that provides the mapping from representative to discarded sequence-identical target.  This is essentially what salmon does with the file duplicate_clusters.tsv.  The benefit of this approach is that the fasta and t2g file are entirely consistent, but at the same time the relevant information is recorded if the user wants to use it downstream.  With some extra cycles, we could even develop a function that considers this mapping when loading the matrix into R/Python and "re-populates" the identical targets ... though how to do that and what the policy should be is still a bit of an open question.
Remove all but one of the identical sequence targets, remove the corresponding entry from the t2g file, and don't produce any extra information recording the duplication status.  This keeps things as simple as possible, but certainly loses some information.

There may be other possibilities as well, so I'm happy to hear if you have any thoughts on this.  Also, I hope you had a great 4th :).
Best,
Rob

Hi @davidaknowles ,
Thanks for bringing this up. I think this is really a question because in pyroe, we do deduplicate identical sequences, but when doing it, we sort the transcript names that share the same sequence and take the first one as the representative name. This behavior may sometimes prefer to keep unspliced transcript names. For example, when sorting ENST an ENSG, ENSG will always win. In your case, I would suggest you run pyroe without the dedup-seq flag and filter the sequences by yourself because, currently, pyroe does not ensure that the spliced transcripts are always kept rather than the unspliced transcripts. This will be easy to do, you can slightly modify the function we defined here, and you replace the logic in line 91-93 with any logic you want to use.
@rob-p We might want to rewrite the dedup_seq function because if we have a single-exon transcript, we might want to keep both sequences so that reads map to this transcript will also map to its unspliced counterpart so that they can be classified as the ambiguous state, what do you think?
Best,
Dongze

Thanks both. For the specific case of single exon genes, I think these should be deduped: there is no distinction between spliced and unspliced (since the mature RNA = pre-mRNA!) so there is no real ambiguity. Then it's just a matter of semantics whether you label with the gene or transcript name (the only tricky part is what label you give in _3col.tsv).
For deduping other sequences would it be problematic at all to label these with the concatenation of the sequence names? That would avoid creating an additional file.
And just so I understand: index building and alignment will only look at the fasta (but not t2g.tsv), but quant will look at t2g.tsv (or t2g_col.tsv)?

Thanks, this all sounds reasonable. For now I'm going to take duplicate_entries.tsv and use it to remove entries from t2g.tsv etc before quantification. I'm primarily interested in looking at alternative splicing variation so the single exon genes are only of interest to me as places that multimapping reads could get (partially) assigned to.

Hmm so with my deduped t2g.tsv I'm getting an error when I go to run alevin-fry quant:
2023-07-06 17:50:54 INFO quantifying from uncompressed, collated RAD file File { fd: 4, path: "/gpfs/commons/groups/knowles_lab/data/parse/original_SPLITseq_GSE110823/salmon_spliceu/out_permit_knee/map.collated.rad", read: true, write: false }
2023-07-06 17:50:55 INFO paired : false, ref_count : 116,918, num_chunks : 192,395
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `96955`,
 right: `116918`: The tg-map must contain a gene mapping for all transcripts in the header', src/utils.rs:234:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I think the rad file knows there should be more entries in t2g.tsv: maybe I need to rerun collate?

Hi @davidaknowles,
So the constraint here is that all of the transcripts that appear in the header of the RAD file should have some mapping to a gene in the t2g map.  You can see what targets are listed in the RAD file using the view sub-command.  That is the minimal set of targets that must appear in the t2g file.
If you want to share the RAD file, your t2g mapping, and your duplicate_entries file, @DongzeHE and I are happy to take a look.
Best,
Rob

Is there a way to have view show me only the targets and not the alignments?

Hi @davidaknowles,
Were you ever able to resolve this? Should I close the issue, or is there something lingering that @DongzeHE and I should look into?
Thanks!
Rob

Fine to close it for now.


SubsetProblem: add constructor without size limits

Add a constructor to the SubsetProblem class without size limits that calls
this(obj, data, 0, data.getIDs().size());

Update affected examples (subset selection without size limits).


[USERSNAP] I dont understand why a Drep can have active status with 0 voting power, or when they dont have a name attached to their position (ex.:  data missing, or formatted incorrectly), or why 2 different Dreps can have the same name (ex.:  HD5000). ...

Taken at: https://gov.tools/drep_directory
Fields:

Add a comment: I dont understand why a Drep can have active status with 0 voting power, or when they dont have a name attached to their position (ex.:  data missing, or formatted incorrectly), or why 2 different Dreps can have the same name (ex.:  HD5000).
Some sort of clarity or a fix of what seems to be real problems would be good.
thank you

Browser: Chrome 131 (Android 10)
Screen size: 412x892
Open #169 in Usersnap
Powered by Usersnap.

The first question
(I don't understand why a Drep can have active status with 0 voting power, or when they dont have a name attached to their position (ex.: data missing, or formatted incorrectly)
This behaviour is inherent in the way that DReps are defined. The only thing that's written to the chain is:

the DRep ID
the hash of the metadata
the URL of the metadata

Hence, there is no check on the name of the DRep, nor their balance.
I agree it's a confusing situation, but it would take some re-engineering of the Node to fix this.

Closing as we cannot fix this easily, or at all without re-writing the foundational CIP, and serious re-engineering of the Node itself.


For PowerToys Run: Suggests also results in other languages installed on the computer

Description of the new feature / enhancement
For bilingual users, sometimes the keyboard is set to the wrong language but you only realize it halfway into writing your query.
Suggesting results in other languages (according to the keyboard layout) can save a lot of time and frustration.
Like Google does:

Scenario when this would be used?
Typing a query while the keyboard is not set to the intended language.
Supporting information
No response

https://github.com/microsoft/PowerToys/issues/30278

/dup https://github.com/microsoft/PowerToys/issues/30278


New parking scheme tags end up with fixme output

As an experiment I added the new parking scheme tags to way<PHONE_NUMBER> to see what would happen when the tag updater code came across them. I left the old scheme tags in place as well. The result is invalid output from the updater.
I would have expected the old scheme tags to be flagged with transformation information provided. That did indeed occur. However I would also have expected new scheme tags to be ignored because they are already present and valid. What instead happened was that the new scheme tags were parsed and highlighted with fixme messages and the instruction was to fix them manually.
New scheme tags when present should either be completely ignored or highlighted as being compatible with the new scheme.

New scheme tags when present should either be completely ignored or highlighted as being compatible with the new scheme.

Sounds reasonable; will have a look in the weeks to come.

I improved this in https://github.com/osmberlin/osm-tag-updater/commit/bb5e5164a5a1819ea208c91c8b7d8b606802334b

When new+old schema is mixed, the new is ignored + notice
When input has both the old and the new schema…

the app will only transpose the old schema
there is a notice about the new schema being present
but no auto-merge of new and old

@davidpnewton @SupaplexOSM please have a look and report back if there are other / new issues. Thanks!


ExpansionTileController is unusable if the ExpansionTile changes

Steps to reproduce
My use case is that I have a list of expansion tiles, initially collapsed. When the user types in a search box, the list should be filtered by the search query, and any remaining expansion tiles should expand. This is for UX, as there are too many total children to show all of them before the user starts searching.
My approach was to maintain a list of ExpansionTileControllers and call .expand() on the ones that match the search. But since the ones that don't fit the search are hidden, they are disposed, and they dissociate their state from the controllers. Which means if an expansion tile wasn't searched for before, it will dispose itself, and now the controller will throw errors if I try to use it in future searches.
I pasted a reproducible example in the dropdowns below. I'm not sure but I believe https://github.com/flutter/flutter/issues/138153 or https://github.com/flutter/flutter/issues/138916 will fix this.
Expected results
I would like the controllers to collapse or expand the expansion tiles they are currently attached to when I call them, despite having passed the controller to a different expansion tile previously.
Actual results
If the ExpansionTile has previously been removed from the page, trying to expand or collapse it with the controller results in the following error:
'package:flutter/src/material/expansion_tile.dart': Failed assertion: line 77 pos 12: '_state != null': is not true.

This is an assertion in debug mode, but the code uses ! in release mode:
https://github.com/flutter/flutter/blob/978657becd854b0b5ced80d372bdfc9b82da19b0/packages/flutter/lib/src/material/expansion_tile.dart#L76-L81
Code sample
Code sample
import "package:flutter/material.dart";

void main() => runApp(MaterialApp(home: SearchPage()));

class SearchPage extends StatefulWidget {
  @override
  SearchState createState() => SearchState();
}

class SearchState extends State<SearchPage> {
  static const ids = [
    "hello", "world", "example", "stuff", "etc",
  ];

  final controllers = {
    for (final id in ids)
      id: ExpansionTileController(),
  };

  Iterable<String> filtered = ids;

  void search(String query) {
    setState(() => filtered = ids.where((id) => query.isEmpty || id.contains(query)));
    for (final id in filtered) {
      // Error: 'package:flutter/src/material/expansion_tile.dart':
      // Failed assertion: line 77 pos 12: '_state != null': is not true.
      controllers[id]?.expand();
    }
  }

  @override
  Widget build(BuildContext context) => ListView(
    children: [
      TextField(
        onChanged: search,
      ),
      for (final id in filtered)
        ExpansionTile(
          key: ValueKey(id),
          title: Text(id),
          controller: controllers[id],
          children: [
            for (final other in ids) Text(other),
          ],
        ),
    ],
  );
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs

════════ Exception caught by widgets ═══════════════════════════════════════════
The following assertion was thrown while calling onChanged:
'package:flutter/src/material/expansion_tile.dart': Failed assertion: line 77 pos 12: '_state != null': is not true.

When the exception was thrown, this was the stack:
#2      ExpansionTileController.expand (package:flutter/src/material/expansion_tile.dart:77:12)
expansion_tile.dart:77
#3      SearchState.search (package:trinket/src/widgets/tasks/sidebar.dart:112:24)
sidebar.dart:112
#4      EditableTextState._formatAndSetValue (package:flutter/src/widgets/editable_text.dart:4186:27)
editable_text.dart:4186
#5      EditableTextState.userUpdateTextEditingValue (package:flutter/src/widgets/editable_text.dart:4550:5)
editable_text.dart:4550
#6      EditableTextState._replaceText (package:flutter/src/widgets/editable_text.dart:4934:5)
editable_text.dart:4934
#7      CallbackAction.invoke (package:flutter/src/widgets/actions.dart:597:39)
actions.dart:597
#8      Action._invoke (package:flutter/src/widgets/actions.dart:338:17)
actions.dart:338
#9      ActionDispatcher.invokeAction (package:flutter/src/widgets/actions.dart:641:19)
actions.dart:641
#10     Actions.invoke.<anonymous closure> (package:flutter/src/widgets/actions.dart:966:48)
actions.dart:966
#11     Actions._visitActionsAncestors (package:flutter/src/widgets/actions.dart:748:18)
actions.dart:748
#12     Actions.invoke (package:flutter/src/widgets/actions.dart:960:30)
actions.dart:960
#13     _DeleteTextAction.invoke (package:flutter/src/widgets/editable_text.dart:5820:20)
editable_text.dart:5820
#14     _OverridableContextAction.invokeDefaultAction (package:flutter/src/widgets/actions.dart:1806:28)
actions.dart:1806
#15     _OverridableActionMixin.invoke (package:flutter/src/widgets/actions.dart:1671:9)
actions.dart:1671
#16     Action._invoke (package:flutter/src/widgets/actions.dart:336:19)
actions.dart:336
#17     ActionDispatcher.invokeActionIfEnabled (package:flutter/src/widgets/actions.dart:666:28)
actions.dart:666
#18     ShortcutManager.handleKeypress (package:flutter/src/widgets/shortcuts.dart:907:83)
shortcuts.dart:907
#19     _ShortcutsState._handleOnKeyEvent (package:flutter/src/widgets/shortcuts.dart:1098:20)
shortcuts.dart:1098
#20     _HighlightModeManager.handleKeyMessage (package:flutter/src/widgets/focus_manager.dart:2073:39)
focus_manager.dart:2073
#21     KeyEventManager._dispatchKeyMessage (package:flutter/src/services/hardware_keyboard.dart:1100:34)
hardware_keyboard.dart:1100
#22     KeyEventManager.handleRawKeyMessage (package:flutter/src/services/hardware_keyboard.dart:1172:17)
hardware_keyboard.dart:1172
#23     BasicMessageChannel.setMessageHandler.<anonymous closure> (package:flutter/src/services/platform_channel.dart:235:49)
platform_channel.dart:235
#24     _DefaultBinaryMessenger.setMessageHandler.<anonymous closure> (package:flutter/src/services/binding.dart:581:35)
binding.dart:581
#25     _invoke2 (dart:ui/hooks.dart:344:13)
hooks.dart:344
#26     _ChannelCallbackRecord.invoke (dart:ui/channel_buffers.dart:45:5)
channel_buffers.dart:45
#27     _Channel.push (dart:ui/channel_buffers.dart:135:31)
channel_buffers.dart:135
#28     ChannelBuffers.push (dart:ui/channel_buffers.dart:343:17)
channel_buffers.dart:343
#29     PlatformDispatcher._dispatchPlatformMessage (dart:ui/platform_dispatcher.dart:750:22)
platform_dispatcher.dart:750
#30     _dispatchPlatformMessage (dart:ui/hooks.dart:257:31)
hooks.dart:257
(elided 2 frames from class _AssertionError)
════════════════════════════════════════════════════════════════════════════════

Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [Version 10.0.22631.3880], locale en-US)
    • Flutter version 3.22.2 on channel stable at C:\Users\KDAB\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (6 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at C:\Users\KDAB\AppData\Local\Android\sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: C:\Program Files\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.10.3)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.10.35013.160
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2024.1)
    • Android Studio at C:\Program Files\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105)

[√] VS Code (version 1.91.1)
    • VS Code at C:\Users\KDAB\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.92.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22631.3880]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 126.0.6478.128
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 126.0.2592.102

[√] Network resources
    • All expected network resources are available.

• No issues found!

My workaround is to leverage ExpansionTileController.of to get the current controller correctly. I use maintainState: true so the children elements are forced to be drawn even when hidden (which probably incurs a performance penalty since Offstage is no longer being used), then used a Builder to get that expansion tile's controller and open or close it based on the query. Here's that code:
        children: [
          for (final child in children)
            if (child.isWhatIwant) Builder(
              builder: (context) {
                // We want the default state to be closed, unless this element was searched for
                // Note that keeping the controller in the view model does not work as the controllers
                // are automatically disposed when scrolled out of view and are unusable after that.
                if (model.filter.isNotEmpty) Timer.run(ExpansionTileController.of(context).expand);
                if (model.filter.isEmpty) Timer.run(ExpansionTileController.of(context).collapse);
                return Padding(...),

Reproducible using the sample provided above.
Steps to reproduce

Run the code sample.
Type some text in the textfield to filter out some of the tiles
Clear the textfield

complete sample
import "package:flutter/material.dart";

void main() => runApp(MaterialApp(home: SearchPage()));

class SearchPage extends StatefulWidget {
  @override
  SearchState createState() => SearchState();
}

class SearchState extends State<SearchPage> {
  static const ids = [
    "hello", "world", "example", "stuff", "etc",
  ];

  final controllers = {
    for (final id in ids)
      id: ExpansionTileController(),
  };

  Iterable<String> filtered = ids;

  void search(String query) {
    setState(() => filtered = ids.where((id) => query.isEmpty || id.contains(query)));
    for (final id in filtered) {
      // Error: 'package:flutter/src/material/expansion_tile.dart':
      // Failed assertion: line 77 pos 12: '_state != null': is not true.
      controllers[id]?.expand();
    }
  }

  @override
  Widget build(BuildContext context) => Scaffold(
    body: ListView(
      children: [
        TextField(
          onChanged: search,
        ),
        for (final id in filtered)
          ExpansionTile(
            key: ValueKey(id),
            title: Text(id),
            controller: controllers[id],
            children: [
              for (final other in ids) Text(other),
            ],
          ),
      ],
    ),
  );
}

flutter doctor -v
[!] Flutter (Channel stable, 3.22.3, on macOS 14.4.1 23E224 darwin-arm64, locale en-GB)
    • Flutter version 3.22.3 on channel stable at /Users/nexus/dev/sdks/flutter
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter. Consider adding /Users/nexus/dev/sdks/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter. Consider adding /Users/nexus/dev/sdks/flutter/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b0850beeb2 (2 days ago), 2024-07-16 21:43:41 -0700
    • Engine revision 235db911ba
    • Dart version 3.4.4
    • DevTools version 2.34.3

[✓] Flutter (Channel master, 3.24.0-1.0.pre.197, on macOS 14.4.1 23E224 darwin-arm64, locale en-GB)
    • Flutter version 3.24.0-1.0.pre.197 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0bac2be379 (6 hours ago), 2024-07-19 00:15:26 -0400
    • Engine revision ea1e53a4e8
    • Dart version 3.6.0 (build 3.6.0-55.0.dev)
    • DevTools version 2.37.1
```
</details>

I believe https://github.com/flutter/flutter/issues/138153 or https://github.com/flutter/flutter/issues/138916 will fix this.

I believe you are correct! I am going to close this issue then since it is covered there. This will be linked to those issues now for future reference. Thanks!

Just as a note, those issues aren't reporting bugs, but possible enhancements. The PR in #138153 has possible issues and #138916 can be worked around by re-using the controller. The latter is closer to this but this issue is an actual error, so I clarified that in my comment in #138916


⚠ GLDDNS Server (ns2.glddns.com) has degraded performance

In d101a0f, GLDDNS Server (ns2.glddns.com) (ns2.glddns.com) experienced degraded performance:

HTTP code: 200
Response time: 674 ms

Resolved: GLDDNS Server (ns2.glddns.com) performance has improved in 9711015 after 6 minutes.


Mat/Pat - Extended Leave Warning

add warning if taking extended allowance wihtout the full extended leave

duplicate


Error cfr-9 while creating a new server

Beat Saber version 1,16,4
Beat Together version: PC v1.1.3
Error cfr-9 while creating a new server, but I see server status is ONLINE.
How can I solve it?
Tried some steps from this topic https://steamcommunity.com/app/620980/discussions/2/4420805388059415190/ but it doesn't work for me

Same issue here, thank you for the plugin btw!

@Oikio @HugWolf
Beat Together PC v1.1.3 is only compatible with BS v1.16.2 as stated in the features, Beat together has not been updated yet to support BS v1.16.4
Hopefully we will hear something soon.

Thank you for the response, clear now.

The plugin hasn't bee updated.
Join our discord server for future updates: https://discord.com/invite/gezGrFG4tz


Option so Changing Worlds Doesn't TP Them Back to Spawn

Hey,
I don't like how when my players teleport to different worlds, they are always teleported back to spawn, if there a way I am able to make it so they are able to automatically spawn back to their last location?
Thanks
Techno

I have to laugh at seeing this.  It is the exact same request I made 5 years ago and just read my request before looking at current issues. I don't know if they plan on changing their verdict but at the time they had no intentions of it (drawing line at storing player data).  Personally would still love the option in-part because the additional add-on I was using hasn't been updated since 2013 (maybe there is another replacement).

Mulitverse inventories have a last location feature. https://github.com/Multiverse/Multiverse-Core/wiki/Shares-List-(Inventories)#optional-shares---must-be-enabled-via-mvinv-toggle-sharename-or-they-have-no-effect


Horizontal scrollbar on changelog page on mobile

You can scroll sideways on that page and it looks bad:

The cause is these long links:

This CSS seems to fix it:
a.external {overflow-wrap: anywhere;}

https://docs.readthedocs.io/en/stable/guides/adding-custom-css.html

Fixed. https://datasette.readthedocs.io/en/latest/changelog.html


No "forwarded from" info in export from channel

Hi.
Any plans for this feature?
Regards

Thanks for pointing this out. Will look into this when I get a chance.