feat: reupload pinned content periodically

Closes #309
So that the content is available for other nodes on the network. It can be done using the /stewardship endpoint, by using the hashes from the list of pinned nodes.
There could be a new environment variable (REUPLOAD_PERIOD) which would define the time when the reupload would happen.

I am sorry, but we might have some misunderstanding on how this feature should be implemented, which we have to fix up first before continuing to sort out details.
Reuploading pin content is not related to stamp management. Actually, they are very separate and are important to keep distinct, because for re-uploading data, you need to have a valid postage stamp, so then it is up to the user to choose from our 3 ways how the gateway-proxy should manage its postage stamps. If you have another postage-stamp "mode" for reuploading then the user does not have a way how to configure the postage stamp acquisition works.
So this should be a completely separate feature that is split from any StampsManager. Maybe it would make sense to create something like DataManager which would function similarly to StampsManager style. It would have its own interval loop where the reupload would happen and the interval would be enabled only if the gateway-proxy has enabled the reuploading feature.
@agazso can you please verify if my understanding is correct?

Yes, I can second what @AuHau is saying. This feature is about managing the data and not about managing the postage stamps.

I am sorry, but we might have some misunderstanding on how this feature should be implemented, which we have to fix up first before continuing to sort out details.
Reuploading pin content is not related to stamp management. Actually, they are very separate and are important to keep distinct, because for re-uploading data, you need to have a valid postage stamp, so then it is up to the user to choose from our 3 ways how the gateway-proxy should manage its postage stamps. If you have another postage-stamp "mode" for reuploading then the user does not have a way how to configure the postage stamp acquisition works.
So this should be a completely separate feature that is split from any StampsManager. Maybe it would make sense to create something like DataManager which would function similarly to StampsManager style. It would have its own interval loop where the reupload would happen and the interval would be enabled only if the gateway-proxy has enabled the reuploading feature.
@agazso can you please verify if my understanding is correct?


feat: use types and improve code quality

There's no reason to use classes as DTOs unless you're using them to serialize data, so I switched to type and casting.
Also, use console.error where appropriate.

Thank you for PR. I am new to javascript/typescript in general and I see you changed quotes to double quotes - could you recommend conventional eslint settings/config? Everything else in PR is great.

I usually use double quotes, and that's powered by prettier. There's a lot of configuration that can go into lint rules and the likes so I won't make decisions on your behalf, but it would be a great thing for someone else to PR.
Most of the other changes are just default prettier settings I have enabled in VSC. I'd stick with those TBH.


design the data store

How to store so that it is easy to calculate stats as the data gets bigger. Not big data scale of course but in hundreds.

similar to #24, closing this


size of output

so when i do model(images) the number of channels for the output is equal to 2 when the input channel number is equal to 1 any idea why / how i can compute loss between the two? so if i do outputs.size() I get (1, 2, 128, 128) when my input was (1, 1, 128, 128). Is it correct? If so, how do I compute the DiceLoss between them?

i figure i have to just take one of the channels and compare? but how?

this is the solution i came up with let me know if it's wrong:

output = output[0][0]
image = torch.reshape(image, shape=(1, 64, 64, 64))
image = torch.reshape(image, shape=(1, 1, 64, 64, 64))

output is the (1, 2, 128, 128, 128) image and the final output is (1, 1, 128, 128, 128).

Hi Palash,
The Dice Loss is computed between labels. Your output dim 1 is 2 since you have one mask for the background and one for the foreground (i.e. they are inverses of each other: bg = 1 - fg). I suggest either of following 2 ways:
Calculate dice loss over all class-labels:
You would need to calculate the inverse of your foreground true label (i.e 1-true_mask) to get a background label mask. And then concatenated these 2 matrices along the axis=1 to get matrix of shape (1, 2, 128, 128).
Calculate dice loss only over foreground
Just take the foreground part from the model prediction : output[ 0, 0, : , : , : ] and compute dice loss between this and your label.
Cheers,
Ishaan

Oops, I meant output[0, 1, : , : , :] to get the foreground prediction.


feat: Added a function for finding the least common multiple

Description of Change
I have added a function that outputs the least common multiple of two numbers.

Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] Sort by alphabetical order
[x] I acknowledge that all my contributions will be made under the project's license.

Notes: Function to find the least common multiple of two numbers.

I have taken onboard all the comments and tried to fix the issues, please take a look now.

@tjgurwara99 have a look at #807 files are very well documented  in this PR, please do the documentaion in similar manner.
Thanks! for your contribution

@tjgurwara99 This is the autogenerated documentation for this file -> link. Note:

the correct tag is param and not params. hence, all the parameter tags got ignored
no \brief tag in the beginning of the file did not create any summary in the list of files page
Thought the points would help you going forward and this was another point I realized should keep an eye while reviewing 😄

@tjgurwara99 This is the autogenerated documentation for this file -> link. Note:

the correct tag is param and not params. hence, all the parameter tags got ignored
no \brief tag in the beginning of the file did not create any summary in the list of files page
Thought the points would help you going forward and this was another point I realized should keep an eye while reviewing 😄

@kvedala Could you show me the config file (cmake or Doxyfile) you use for Doxygen, I want to try and add that to other projects but don't seem to be able to do it.

@tjgurwara99 This is the autogenerated documentation for this file -> link. Note:

the correct tag is param and not params. hence, all the parameter tags got ignored
no \brief tag in the beginning of the file did not create any summary in the list of files page
Thought the points would help you going forward and this was another point I realized should keep an eye while reviewing 😄

@kvedala Could you show me the config file (cmake or Doxyfile) you use for Doxygen, I want to try and add that to other projects but don't seem to be able to do it.

In my setup, the doxygen gets configured by cmake itself. -> right here


Make handlers async

IContentHandler and IContentPartHandler should have async methods.

YES!

async methods have been added to IContentHandler and IContentPartHandler


tado° API credentials

Hi,
I just got an email from Tado that they are changing their API.
Here is the email

Stefan Gaß (tado° Help Center)
30 jun. 13:56 CEST
Hello,
we have noticed that you are using tado° API. Even though it is not officially supported by us yet, we wanted to inform you about some upcoming breaking changes.
As you might already know, our APIs are authenticated by OAuth 2. We have recently migrated our own apps to new client credentials which uses client secret and we plan to discontinue the old credentials during next week.
Please make sure you migrate your API usages to this client credentials:
Client ID: public-api-preview
Client Secret: 4HJGRffVR8xb3XdEUQpjgZ1VplJi6Xgw
Also feel free to share these credentials with other developers. That way we will be able to easily distinguish our own apps from third party developers and make sure that the official public API will suit your needs.
Best regards,
Michal
Head of Server Development

Does this affect the Home-Assistant implementation?
Cheers,
Ruben
Edit: Style changes

Thanks for letting us know. This is an issue that should be filed upstream at https://github.com/wmalgadey/PyTado


LNK1104 error in setup.py

I tried to install dlib for python using 'py.exe setup.py install' command in windows.
It runs well for a while and at some point it finishes with LNK1104 error.
'LINK : fatal error LNK1104 : cannot open file 'python35.lib' [~~~/dlib/tools/python/build/dlib_.vcproj]

http://dlib.net/faq.html#Whywon'tthePythonbindingscompilework


Rspec Test case Application job controller

As a developer, I want to create concise RSpec test cases for the Application Job controller to ensure the core functionalities are robustly tested. The tests will cover scenarios such as job creation, updating job details, displaying job information, and deleting jobs. Additionally, the test suite will include valid and invalid input cases, edge scenarios, and effective error handling strategies.


CodePipelineReadOnlyPolicy is requiring a pipeline name

Description:
Unable to use the CodePipelineReadOnlyPolicy policy template since it requires a single pipeline name via the parameter PipelineName and the schema for parameters doesn't allow *
Steps to reproduce the issue:

Create a template with:

  - CodePipelineReadOnlyPolicy:
       PipelineName: '*'

Observed result:

Invalid Serverless Application Specification document. Number of errors found: 1. Errors: Resource with id [PipelineDashboardEventHandler] is invalid. 'CodePipelineReadOnlyPolicy' policy template contains unsupported value for a parameter 'PipelineName'.

Expected result:
Should work

'*' is definitely a valid value and is allowed. I think this might be something to do with YAML formatting.
Can you convert your YAML to JSON (you can do it online here https://www.json2yaml.com/), and post the relevant JSON sections? We want to ensure it looks like {"CodePipelineReadOnlyPolicy": {"PipelineName": "*"}}

@sanathkr thanks for the quick response.  I converted to JSON and still get the same error.  Complete template is available below:
{
  "AWSTemplateFormatVersion": "2010-09-09",
  "Transform": "AWS::Serverless-2016-10-31",
  "Description": "Create pipeline-dashboard application.",
  "Resources": {
    "PipelineDashboardEventHandler": {
      "Type": "AWS::Serverless::Function",
      "Properties": {
        "Description": "Create CloudWatch metrics from CodePipeline events",
        "Handler": "index.handlePipelineEvent",
        "Runtime": "nodejs6.10",
        "CodeUri": "s3://pipeline-dashboard-us-east-1/bc131ad7fd38fd97ecd0387124bb2bda",
        "Events": {
          "PipelineEventRule": {
            "Type": "CloudWatchEvent",
            "Properties": {
              "Pattern": {
                "source": [
                  "aws.codepipeline"
                ],
                "detail-type": [
                  "CodePipeline Pipeline Execution State Change",
                  "CodePipeline Stage Execution State Change",
                  "CodePipeline Action Execution State Change"
                ]
              }
            }
          }
        },
        "Policies": [
          {
            "CloudWatchPutMetricPolicy": {
            }
          },
          {
            "CodePipelineReadOnlyPolicy": {
              "PipelineName": "*"
            }
          }
        ]
      }
    },
    "PipelineDashboardGenerator": {
      "Type": "AWS::Serverless::Function",
      "Properties": {
        "Description": "Build CloudWatch dashboard from CloudWatch metrics",
        "Handler": "index.generateDashboard",
        "Runtime": "nodejs6.10",
        "CodeUri": "s3://pipeline-dashboard-us-east-1/bc131ad7fd38fd97ecd0387124bb2bda",
        "Timeout": 60,
        "Events": {
          "DashboardEventRule": {
            "Type": "Schedule",
            "Properties": {
              "Schedule": "cron(*/5 * * * ? *)"
            }
          }
        },
        "Policies": [
          {
            "CloudWatchDashboardPolicy": {
            }
          }
        ]
      }
    }
  }
}

@cplee Where are you running the template at? I was able to take the template you provided and deploy to us-west-2.

@jfuss I'm trying to register the template as a new version in Serverless Application Registry in us-east-1

@cplee This makes sense now! Serverless Application Repository does not allow you to provide a value of * for the resource name (in your case, it is the name of CodePipeline resource).
This might sound a bit counter-intuitive, but it is done to make apps more secure. As a publisher, the best practice is to parameterize the resource name using Template Parameters, and let the consumer decide the pipeline to give access to, at the time of deployment. Consumers could even choose a value of *.
Parameters:
  PipelineNameParam:
     Type: String

Resources:
   ...
        CodePipelineReadOnlyPolicy: !Ref PipelineNameParam

This way, your app is generic when you publish, and consumers can give access to necessary resources when deploying. This is just similar to how you would write a software library with generic interfaces that consumers will customize for their needs.
Does this make sense?

@sanathkr thanks, that makes perfect sense.  For now, i'll add the parameter.  However, I'd argue that the SAM policy templates are very inconsistent in that many do default to * for the Resource (examples below).  I propose creating some naming standard for the policy templates that also implies scoping of the resources to one vs all.  For example, EC2DescribePolicy vs EC2DescribeAllPolicy.

EC2DescribePolicy
CloudFormationDescribeStacksPolicy
AWSSecretsManagerRotationPolicy

Good catch. We use * for Resources in the policy template definition like EC2DescribePolicy because the underlying API like DescribeRegions does not support resource level scoping. So if we set any value for the resource other than "*", the API would fail.
This might be worth adding to a documentation section on how Policy Templates are created and how they work, which is lacking today.
Would you be interested in writing a para or two based on your knowledge and send a pull request? I will be happy to contribute to your Pull Request. We can work together to create a good documentation on how Policy Templates work.

Here's a page on Policy Templates from the AWS SAM Docs: https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-policy-templates.html


⚠ Fox Sports has degraded performance

In 7d5810f, Fox Sports (https://foxsports.com) experienced degraded performance:

HTTP code: 200
Response time: 4828 ms

Resolved: Fox Sports performance has improved in c3a43c1.


Added Tests to Verify MT-SRE Can Connect To Prometheus , Alert Manager Using OpenShift Port-Forwarding

Continuation of older PR which got closed due to some problems while squashing commits and rebasing PR Link

Jenkins Link: https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods-ci-pr-test/818/
Result: Passed

Jenkins link: https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods-ci-pr-test/833/


feat: add scaled text input

What changed? Why?

Notes to reviewers
How has it been tested?

closing in favor of increasing the padding between the value and select and keeping the current scroll behavior, cc: @mindapivessa


Add insertion sort in cpp

Please assign this issue to me...

can I also work on this issue..?

Please review my pull request...

https://github.com/randomfeelings/dsa_resources/pull/25
please merge


The player stops displaying the video after a period of time and displays the advertisement only

Describe the bug
After about a few hours, the player stops showing videos and only displays ads. I'm not a programmer but I followed the youtube instructions to turn on fluid player in blogger but the player always works on the first day and then stops showing videos
Please help me find a solution as soon as possible. I have tried v3, v2, 3.0.0 and the problem has not changed

Hello @saifassizoz, what do you mean by a few hours? Is the player open playing a long video? Do you see any errors in your developer tools console?

Hello @saifassizoz, what do you mean by a few hours? Is the player open playing a long video? Do you see any errors in your developer tools console?

My friend, I'm just trying to play my videos from google drive and add vast ads from adsterra, but the player stops playing the video after one day or less, does fluidplayer play the video only once? Isn't it supposed to work permanently?
I am not a programmer, but I own a website to display videos, and I used the doodstream platform, but I am not comfortable with it
I just want to use vast ads on my site, and I resorted to using google drive to upload videos and fluid player to run them and take advantage of the ads feature
The problem that I am posing is that I try the video after setting up the player, and I find that it works, but the visitors on my site complain that the videos do not work, so I return to verify that to find that the video player displays the advertisement only and then stops
Do you have advice for me?

You can make sure that your video works using it without Fluid Player, using a tag like this one without Fluid Player.
<video width="320" height="240" controls>
  <source src="movie.mp4" type="video/mp4">
  <source src="movie.ogg" type="video/ogg">
Your browser does not support the video tag.
</video>

Hosting videos is outside of the domain of Fluid Player, so this is something that we can't help with. I believe the best action is looking for a CDN that can give you confidence that your video will be delivered to your visitors. Your current choice of hosting can be limiting the delivery of your content due to high bandwidth usage or some other policy.

Dihantar daripada telefon saya-------- Mesej asal --------Daripada: Leroy Medeiros @.>Tarikh: Isn, 21 Nov 2022, 8:11 PTGKepada: fluid-player/fluid-player @.>Sk: Subscribed @.***>Tajuk: Re: [fluid-player/fluid-player] The player stops displaying the video after a period of time and displays the advertisement only (Issue #696)
You can make sure that your video works using it without Fluid Player, using a tag like this one without Fluid Player.

Your browser does not support the video tag.

Hosting videos is outside of the domain of Fluid Player, so this is something that we can't help with. I believe the best action is looking for a CDN that can give you confidence that your video will be delivered to your visitors. Your current choice of hosting can be limiting the delivery of your content due to high bandwidth usage or some other policy.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

@saifassizoz Personally I don't know any specific platforms, this will depend on your use case, costs, performance, etc... Closing the ticket since it's not related with FP.


Does neovim have a default indent guide?

I don't know exactly what caused my problem, but I ask it here because I think it's somehow related to this plugin. The reason that I think so is that this is the only plugin that I installed for indent guides.
basically, I can't remove indent guides in neovim. even after I removed this plugin from the init.vim file and the vim-plug plugins directory I still see indent lines in the neovim.
As I said, I installed it using vim-plug and I'm using neovim 0.5.
The interesting part is that, even after I removed all of my configs, I still have the indent lines:

does neovim have a default indent guide?
this is my current init.vim file: https://github.com/ahhshm/dotfiles/blob/main/.config/nvim/init.vim

I tried :IndentBlanklineRefresh and it doesn't give me an error. so it's installed while it's neither in my init.vim nor vim-plug's plugins directory.
I ran :set runtimepath and I found that neovim somehow loads this plugin from packer! before vim-plug, I have a configuration that used packer as plugins manager. but I switched back to vimscript and vim-plug. I thought because I had no Lua file, packer plugins also don't load. I only have init.vim and coc-settings.json in nvim configuration directory.
so I removed the packer directory in ~/.local/nvim/site/pack and now indent guides are disappeared.
thanks for the help. i close this issue.


Added logger implementation based on logback + slf4j.

Implemented VerdictDBLogger wrapper class + added a simple unit test.
It implements slf4j's Logger interface so we can use it just like before.
Any suggestion to improve its behavior is welcomed.
I guess we can configure our logger to print log into rolling files as well as on console later.

Codecov Report

Merging #174 into master will decrease coverage by 0.93%.
The diff coverage is 15.7%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   71.29%   70.35%   -0.94%
==========================================
  Files         136      136
  Lines        7494     7614     +120
  Branches     1203     1203
==========================================
+ Hits         5343     5357      +14
- Misses       1805     1913     +108
+ Partials      346      344       -2

Impacted Files
Coverage Δ

...in/java/org/verdictdb/commons/VerdictDBLogger.java
15.7% <15.7%> (+15.7%)
:arrow_up:

.../core/scrambling/FastConvergeScramblingMethod.java
90.16% <0%> (-1.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d69da...1e0b944. Read the comment docs.


Add API to get the current TagContext or Span without loading the implementation

Currently there are two ways to get the current TagContext or Span, but neither one supports the case where another application or library needs to get the current value during program initialization:

Tagger.getCurrentTagContext() or Tracer.getCurrentSpan(): These methods are part of the core API.  However, they require the global Tagger or Tracer to be loaded, which could cause an error in initialization order if the method is called during initialization.  See the discussion about this problem at https://github.com/census-instrumentation/opencensus-java/pull/1371#discussion_r211441000.

ContextUtils.TAG_CONTEXT_KEY.get() or ContextUtils.CONTEXT_SPAN_KEY.get(): These fields avoid the initialization order issue, but they are in "unsafe" packages because they rely on details of the gRPC context.  Code outside of the repository should avoid using them.

opencensus-api could provide two additional methods that don't expose details of the gRPC context and don't force the implementation to be loaded.  Here is an example for TagContext:
public static TagContext getCurrentTagContext() {
  return io.opencensus.tags.unsafe.ContextUtils.TAG_CONTEXT_KEY.get();
}

The documentation could still encourage use of the Tagger and Tracer methods in code that doesn't run during initialization.

you can use directly the unsafe API in this case instead of adding new public methods.

In this case where an initialization ordering is a problem please use the unsafe package.

We talked offline, and I'm reopening this issue because the proposed API handles the initialization ordering issue without exposing as much detail about the inplementation of the opencensus-java contexts.  However, it should still be harder to find than Tagger.getCurrentTagContext()/Tracer.getCurrentSpan(), which should be used in most cases.
The reason that I opened this issue is that opencensus-contrib-log-correlation-stackdriver accesses the current span context, and it needs to handle logging that could happen early in initialization.  It currently accesses ContextUtils.CONTEXT_SPAN_KEY directly: https://github.com/census-instrumentation/opencensus-java/blob/7a565481d75d1ecf45cb84651e277cc57ba54a47/contrib/log_correlation/stackdriver/src/main/java/io/opencensus/contrib/logcorrelation/stackdriver/OpenCensusTraceLoggingEnhancer.java#L101  It would be better if it could use an API with more encapsulation, especially if it were to be moved to a separate project.


Fixed typo and addressed a few comments

Fixed a typo in the word "registry."
Added an FAQ about whether updates require user intervention.
Changed the requirements to reference the support OS page instead of listing them out here.

@kaarins Hi Kaarin, changes look correct. Could you please take a look and merge? Thanks!


Fix #152 Helm chart does not support Istio port naming

Fixes #152
Motivation
Change port naming to abide by Istio protocol rules
Modifications
Changed port names

pulsar -> tcp-pulsar
pulsarssl --> tls-pulsarssl etc

Verifying this change

[ ] Make sure that the change passes the CI checks.

FYI closing this in favor of another PR  #162


i18n support

React-timeago already supports i18n with the formatter prop.
The formatter is a function that takes a few arguments and renders anything. Using a library to do this unnecessarily bloats up the package and hurts the common case.


Transfer to organization

Currently I am not actively maintaining it, while @ragi256 is very actively maintaining it.
I think I'm going to transfer it to organization, because it's difficult to maintain in a personal repository because of its limited permissions.
@ragi256 What do you think?

Thanks for the suggestion, hogelog.
I also skipped maintenance for a long time due to business schedule reasons. During that time, many gems needed to be updated, and I had a hard time restarting the development this time.
I would be grateful if it could be organized and made easier for other developers to join.
It would be good if you could nominate members based on their current merge rights.

I transfered this repo to https://github.com/teamdmemo/dmemo and sent invitations.
I sent an owner invitation to @ragi256 and member invitatations to the rest.


The [Bug Report] cannot dynamically change the el-col span property, which dynamically changes the width of the el-col

Element UI version
1.3.7
OS/Browsers version
Windows 7
Vue version
2.2.1
Reproduction Link
https://jsfiddle.net/ct6jp8gk/
Steps to reproduce
直接点击jsfiddle运行出现的开关，el-col　没有任何变化。
What is Expected?
el-col span宽度变为 12。
What is actually happening?
el-col span宽度保持不变。

[Vue warn]: Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders. Instead, use a data or computed property based on the prop's value. Prop being mutated: "span"

The error pretty much explains why it doesn't work. You should not mutate an inner prop directly. Correct usage: https://jsfiddle.net/ct6jp8gk/1/ . For more information: https://vuejs.org/v2/guide/components.html#One-Way-Data-Flow


chrome: make ONN async

makes the negotiationneeded fired from addTrack async
@henbos can you take a look? Not sure what a good test is...

Merging, test failures are unrelated.


tweak: don't send mumble:SetVoiceData to all clients if mode

mode/voice proximity doesn't need to be synced to all players, it causes a lot of event spam at high player counts.

+1 this tweak has resolved our sync thread and network thread overload at high player counts


API and data structure refactor

remove parameter 'signature' from wasm_runtime_lookup_function
move common data members c_api_func_imports and cur_exec_env from WASMModuleInstanceExtraCommon to WASMModuleInstance
In WASMModuleInstance enlarge reserved[3] to reserved[5] in case add more data member in the future

Hi, @yamt, I did some further refactoring according to the first bulletin mentioned in this issue https://github.com/bytecodealliance/wasm-micro-runtime/issues/2530. Could you please take a look at this PR at your convenience? By the way, I tested the performance on the 32-bit platform after refactoring. On benchmarks, including CoreMark, Dhrystone, and JetStream, there was basically no performance impact for JetStream, and the performance was roughly down by 1% for CoreMark and 2% for Dhrystone. I think generally speaking, we don't have to worry about the performance impact on the 32-bit platform

@yamt, I merged this PR (and also PR #3209) since we are to implement the memory64 feature and hope to refactor the related APIs and data structures before that, and also to make the related update for wamr-rust-sdk, Python language binding and Go language binding. @TianlongLiang have done a lot of test on the two PRs and also the code has been carefully reviewed. Please   let us know if there are issues found. Many thanks.

this patch looks reasonable at a glance. but i have no time to make careful review this month.
please go ahead w/o waiting for me.
i guess ideally we can stop aot relying on known sizeof(WASMModuleInstance) so that all these
"extra" stuff can be merged into the "base" structure. how do you think?

Yes, it may be another way that AOT doesn't rely on sizeof(WASMModuleInstance), for example, wamrc puts the field offsets of WASMModuleInstance inside the AOT file and lets aot code read these fields according to the offsets. The issue is that it impacts the performance since an extra load instruction is added when accessing these fields, my preference is that performance is more important and we can reserve some spaces in WASMModuleInstance for future use, in fact there is a field uint32 reserved[5] in it, and we just found that field used_to_be_wasi_ctx is unused and can be merged to the reserved filed, so now the reserved space is 28 bytes: uint32 reserved[7]. Normally it should be enough, do you think we should enlarge it?
BTW, we found the global shared memory lock issue you mentioned in #3209, and plan to add a field in WASMMemoryInstance, korp_mutex *memory_lock. Is it good to you?


Issue #4274: Let lowercase_constants directive to be configurable.

Fix #4274
This issue is to have the lowercase_constants directive configurable. (Issue #3026)
The configurable option would let you choose in between 'upper' or 'lower' case syntax.
Here's an example on how it would be:
lowercase_constants:
   syntax: upper

or
lowercase_constants:
   syntax: lower

The default would be lower to be backward compatible.
Why this request ?
CMS's like Drupal 8 are using uppercase constants (TRUE, FALSE, NULL) and I would like to have a proper tool that follows the Drupal 8 "standard" in our custom code at European Commission.
The PHP version you are using ($ php -v):
=> PHP 7.2.14
PHP CS Fixer version you are using ($ php-cs-fixer -V):
=> PHP CS Fixer 2.14.1-DEV Sunrise by Fabien Potencier and Dariusz Ruminski
The command you use to run PHP CS Fixer:
=> Via grumphp
The configuration file you are using, if any:
        array_syntax:
            syntax: short
        blank_line_after_opening_tag: true
        blank_line_before_statement:
            statements:
                - break
                - continue
                - declare
                - return
                - throw
                - try
        include: true
        # Drupalism:
        class_attributes_separation: false
        declare_equal_normalize:
            space: single
        declare_strict_types: true
        is_null: true
        lowercase_static_reference: true
        # Drupalism: lowercase_constants (unable to configure it in php-cs-fixer. Provide a patch?)
        native_function_invocation: false
        # Drupalism:
        no_blank_lines_after_class_opening: false
        no_closing_tag: true
        no_extra_blank_lines:
            tokens:
                - extra
                # Drupalism: - curly_brace_block
                - parenthesis_brace_block
                - square_brace_block
                - return
                - throw
                - use
                - use_trait
        no_trailing_whitespace_in_comment: true
        no_unneeded_final_method: true
        single_blank_line_at_eof: true
        single_line_after_imports: true
        strict_comparison: true
        strict_param: true
        trailing_comma_in_multiline_array: true
        yoda_style:
            equal: false
            identical: false
            less_and_greater: false
            always_move_variable: false

If applicable, please provide minimum samples of PHP code (as plain text, not screenshots):

before running PHP CS Fixer (no changes):

if ($var === null) {
  // Do something
}

with unexpected changes applied when running PHP CS Fixer:

if ($var === null) {
  // Do something
}

with the changes you expected instead:

if ($var === NULL) {
  // Do something
}

Hi and thanks for opening this PR.
Before I review the PR in detail, I'm wondering. The suggestion to uppercase the keywords is not in line with PSR2 , however this is part of the Drupal standard? Do you know why Drupal prefers this style or if this is legacy they might want to move away from?

Hello,
No I don't know why using uppercase for keywords was chosen in Drupal.
I'm pretty sure that it won't change in Drupal 7 and 9 and I don't know either if they are going to move away from it in Drupal 9.
However, I really wish they do.
That said, having this configurable in PHP-CS-Fixer shouldn't be a bad thing, I think.

I'm +1 as this is a standard of a bigger community (Drupal) even if against PSR, however I know of and respect the opinions of people who feel different about this change.

Final nitpicking remark from me: I find "syntax" a strange choice for configuration option, "case" or "casing" would be more clear and intuitive.

Ok guys, I will fix this, it will be ready for tomorrow.

(maybe case would be best, as we already used that as config option else where, but casing we did not)

@dmvdbrugge @SpacePossum Ready for review again.

please regenerate the readme with php php-cs-fixer readme > README.rst :)

All good @SpacePossum

@keradus @dmvdbrugge @SpacePossum Any of you guys to do a new review ?

Thank you @drupol.

THANKS !!!


Enlarge Images

There are enlarge buttons when cursors hover over images in Logseq; however, no enlarge button is given when using images with this kanban plugin. The only way to enlarge the image is by going into the data. Can we somehow enlarge images with this plugin? Thank you.

Hi, I am actually not hooking onto the way Logseq renders images, and am just rendering the image in HTML.
Hence, will require some time to make it like such. Will be happy to keep this FR up, in case anyone wants to do a PR.

Closed as stale.


Error accessing media when checkout files

Hi there,
I use LFS 0.5.1 with Github Enterprise, when checkout binaries, always get the error Error accessing media ..., and here is the details about the error log:
git-lfs smudge jvms/SunOS/sunjre160_07-solaris64.bin
LocalWorkingDir=/test/official_build/3rdParty_UNIX
LocalGitDir=/test/official_build/3rdParty_UNIX/.git
LocalMediaDir=/test/official_build/3rdParty_UNIX/.git/lfs/objects
TempDir=/test/official_build/3rdParty_UNIX/.git/lfs/tmp
GIT_DIR=.git
GIT_PREFIX=

Error accessing media: jvms/SunOS/sunjre160_07-solaris64.bin (e337bf5319cb28171ad7d02addf10a12dd2bb98795948262662eb3a988a429de)

Error downloading /test/official_build/3rdParty_UNIX/.git/lfs/objects/e3/37/e337bf5319cb28171ad7d02addf10a12dd2bb98795948262662eb3a988a429de.
Server error: http://<github_enterprise_url>/Analytics/3rdParty_UNIX.git/info/lfs/objects/e337bf5319cb28171ad7d02addf10a12dd2bb98795948262662eb3a988a429de from HTTP 502
Request:Content-Length=54835
Request:Etag="5538b9e2-d633"
Endpoint=http://<github_enterprise_url>/Analytics/3rdParty_UNIX.git/info/lfs
URL=GET http:/<github_enterprise_url>/Analytics/3rdParty_UNIX.git/info/lfs/objects/e337bf5319cb28171ad7d02addf10a12dd2bb98795948262662eb3a988a429de
Request:Content-Type=text/html
Request:Server=GitHub.com
Request:Date=Wed, 08 Jul 2015 09:35:53 GMT
Response:User-Agent=git-lfs/0.5.1 (GitHub; linux amd64; git 2.2.2; go 1.3)
Response:Authorization=--
Response:Accept=application/vnd.git-lfs+json; charset-utf-8
Status=502 Bad Gateway
goroutine 16 [running]:
github.com/github/git-lfs/lfs.Stack(0x0, 0x0, 0x0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/errors.go:85 +0x89
github.com/github/git-lfs/lfs.Errorf(0x2b95185001b0, 0xc208001560, 0x79c160, 0x0, 0x0, 0x0, 0x0, 0xb3)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/errors.go:29 +0x62
github.com/github/git-lfs/lfs.Error(0x2b95185001b0, 0xc208001560, 0x2b95186a5538)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/errors.go:17 +0x52
github.com/github/git-lfs/lfs.defaultError(0xc20802e630, 0x71fbe0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/client.go:363 +0x151
github.com/github/git-lfs/lfs.handleResponse(0xc20802e630, 0x0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/client.go:325 +0x102
github.com/github/git-lfs/lfs.doHttpRequest(0xc208028dd0, 0xc20800f9b0, 0x1, 0x2)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/client.go:246 +0x215
github.com/github/git-lfs/lfs.doApiRequestWithRedirects(0xc208028dd0, 0xc20800f9b0, 0x2b95186a57e8, 0x0, 0x4, 0x0, 0x0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/client.go:261 +0x44
github.com/github/git-lfs/lfs.doApiRequest(0xc208028dd0, 0xc20800f9b0, 0xc20804a33a, 0x40, 0xc208028dd0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/client.go:296 +0x8e
github.com/github/git-lfs/lfs.Download(0xc20804a33a, 0x40, 0x0, 0x0, 0x2b95186a5978, 0x2)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/client.go:110 +0xca
github.com/github/git-lfs/lfs.downloadFile(0x2b9518504318, 0xc208036008, 0xc208034080, 0x7fff41e0c8f5, 0x25, 0xc20804a300, 0x7a, 0x0, 0x0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/pointer_smudge.go:45 +0x1e8
github.com/github/git-lfs/lfs.PointerSmudge(0x2b9518504318, 0xc208036008, 0xc208034080, 0x7fff41e0c8f5, 0x25, 0x0, 0x0, 0x0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/pointer_smudge.go:31 +0x300
github.com/github/git-lfs/lfs.(*Pointer).Smudge(0xc208034080, 0x2b9518504318, 0xc208036008, 0x7fff41e0c8f5, 0x25, 0x0, 0x0, 0x0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/lfs/pointer.go:44 +0x73
github.com/github/git-lfs/commands.smudgeCommand(0x98d180, 0xc208000f10, 0x1, 0x1)
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/commands/command_smudge.go:59 +0x819
github.com/spf13/cobra.(*Command).execute(0x98d180, 0xc208000f00, 0x1, 0x1, 0x0, 0x0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/spf13/cobra/command.go:355 +0x17c
github.com/spf13/cobra.(*Command).findAndExecute(0x98d780, 0xc20800e010, 0x2, 0x2, 0x0, 0x0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/spf13/cobra/command.go:334 +0xd3
github.com/spf13/cobra.(*Command).Execute(0x98d780, 0x0, 0x0)
        /Users/rick/github/git-lfs/.vendor/src/github.com/spf13/cobra/command.go:408 +0x7b0
github.com/github/git-lfs/commands.Run()
        /Users/rick/github/git-lfs/.vendor/src/github.com/github/git-lfs/commands/commands.go:80 +0x2a
main.main()
        /Users/rick/github/git-lfs/cmd/git-lfs/git-lfs.go:8 +0x1a

The repository uses LFS to manage many huge binaries, but always failed to checkout some binaries.
Any help would be greatly appreciated. Thanks!

The current workaround is:
$ rm <the_missing_binary>
$ git checkout <the_missing_binary>

Which will trigger the smudge filter and force LFS to download the binary again. Then the binary will be successfully downloaded, replace the placeholder in work space.
But since this repository is used by all engineers in our company, manually fix the missing binaries after
each clone would not be acceptable.

If you're using Git LFS v0.5.2, you can also use git lfs fetch to do that.
We're working on improvements to the checkout process. Better error handling is definitely part of that. Thanks for the report!

Hi,
This issue is still unresolved. Just posting so others can see this. When googling for the error message, only one link was found. :laughing:
git checkout feature/some-branch
Downloading test/fixtures/images/image_1.jpg (149.29 KB)
Error downloading object: test/fixtures/images/image_1.jpg
OS version  = 3.19.0-49-generic #55~14.04.1-Ubuntu x86_64 x86_64 x86_64 GNU/Linux
Git version = 2.7.1
git-lfs version = 1.1.1

@emiilsd: Can I get some more info? That's a pretty generic error message that could mean many things. Try running with GIT_TRACE=1.

Well, I did a fresh install so can't check anything
.
Ok, so the first thing - I followed the installation steps and tried installing git-lfs with bash script. After that I ran sudo apt-get update && sudo apt-get install git-lfs and I get error message E: Unable to locate package git-lfs.
So I installed `git-lfs

Installed git-lfs through tar.gz. Went to my project, tried
$ rm <the_missing_binary>
$ git checkout <the_missing_binary>

and received this error:
Downloading image.jpg (149.29 KB)
Error downloading object: image.jpg (76d83cea369c4160ce08f96d916e3af316920e9fd39dd7ef2478cb88131093ce)

Errors logged to /home/<user>/<project>/.git/lfs/objects/logs/20160211T100624.481431389.log
Use `git lfs logs last` to view the log.
error: external filter git-lfs smudge %f failed 2
error: external filter git-lfs smudge %f failed
fatal: image.jpg: smudge filter lfs failed

Log file:
git-lfs/1.1.1 (GitHub; linux amd64; go 1.5.3; git 7de0397)
git version 2.7.1

$ git-lfs smudge image.jpg
Error downloading object: image.jpg (76d83cea369c4160ce08f96d916e3af316920e9fd39dd7ef2478cb88131093ce)

exit status 1
goroutine 1 [running]:
github.com/github/git-lfs/lfs.Stack(0x0, 0x0, 0x0)
/Users/rick/go/src/github.com/github/git-lfs/lfs/errors.go:557 +0x80
 github.com/github/git-lfs/commands.logPanicToWriter(0x7f395d0c71e8, 0xc820030178, 0x7f395d0c7bc0, 0xc820011f60)
/Users/rick/go/src/github.com/github/git-lfs/commands/commands.go:184 +0xf7f
 github.com/github/git-lfs/commands.logPanic(0x7f395d0c7bc0, 0xc820011f60, 0x0, 0x0)
/Users/rick/go/src/github.com/github/git-lfs/commands/commands.go:148 +0x421
 github.com/github/git-lfs/commands.handlePanic(0x7f395d0c7bc0, 0xc820011f60, 0x0, 0x0)
/Users/rick/go/src/github.com/github/git-lfs/commands/commands.go:123 +0x4e
 github.com/github/git-lfs/commands.LoggedError(0x7f395d0c7bc0, 0xc820011f60, 0x96a3a0, 0x21, 0xc820127c98, 0x2, 0x2)
/Users/rick/go/src/github.com/github/git-lfs/commands/commands.go:73 +0x82
 github.com/github/git-lfs/commands.smudgeCommand(0xb5cfa0, 0xc820011c30, 0x1, 0x1)
/Users/rick/go/src/github.com/github/git-lfs/commands/command_smudge.go:77 +0xd89
 github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra.(*Command).execute(0xb5cfa0, 0xc820011b80, 0x1, 0x1, 0x0, 0x0)
/Users/rick/go/src/github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra/command.go:477 +0x403
  github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra.(*Command).Execute(0xb5dfe0, 0x0, 0x0)
/Users/rick/go/src/github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra/command.go:551 +0x46a
  github.com/github/git-lfs/commands.Run()
/Users/rick/go/src/github.com/github/git-lfs/commands/commands.go:88 +0x23
 main.main()
/Users/rick/go/src/github.com/github/git-lfs/git-lfs.go:34 +0x12e

 ENV:
 LocalWorkingDir=/home/<user>/<project>
 LocalGitDir=/home/<user>/<project>/.git
 LocalGitStorageDir=/home/<user>/<project>/.git
 LocalMediaDir=/home/<user>/<project>/.git/lfs/objects
 TempDir=/home/<user>/<project>/.git/lfs/tmp
 ConcurrentTransfers=3
 BatchTransfer=true
 GIT_DIR=.git
 GIT_PREFIX=

OK, so we got it working!
First of all, we're using GitLab and Let's Encrypt CA. Maybe something there is the problem.
Here are the config that worked for me that wasn't set up automatically for me but was for a colleague:
lfs.batch=true
lfs.url=https://git.<domain>.<tld>/<group_name>/<project_name>.git/info/lfs/objects/batch
lfs.url=https://git.<domain>.<tld>/<group_name>/<project_name>.git/info/lfs
lfs.https://git.<domain>.<tld>/<group_name>/<project_name>.git/info/lfs/objects/batch.access=basic

We think that first and second config line isn't needed but we aren't sure.

To summarize, this works with self-hosted GitLab with Let's Encrypt (?):
git config lfs.batch true
git config lfs.url https://git.domain.tld/group-name/project-name.git/info/lfs

This may help someone although this seems to be different issue than original one.


Implement confirmation for Clear and Delete commands

Implemented confirmation requirements for:

Clear command
Delete command

Syntax as of now: type 'yes' (case insensitive) and press Enter to confirm, any other input will abort the command.
Credits to @Silvernitro for the help 😋
Resolves #93

Codecov Report

Merging #94 into master will decrease coverage by 1.29%.
The diff coverage is 20.68%.

@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
- Coverage     73.30%   72.01%   -1.30%
- Complexity      429      433       +4
============================================
  Files            75       76       +1
  Lines          1270     1297      +27
  Branches        130      135       +5
============================================
+ Hits            931      934       +3
- Misses          275      294      +19
- Partials         64       69       +5

Impacted Files
Coverage Δ
Complexity Δ

...ava/seedu/address/logic/commands/ClearCommand.java
80.00% <0.00%> (-20.00%)
2.00 <0.00> (ø)

.../java/seedu/address/logic/commands/YesCommand.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...java/seedu/address/logic/parser/GradPadParser.java
89.47% <0.00%> (-10.53%)
13.00 <0.00> (ø)

...rc/main/java/seedu/address/logic/LogicManager.java
38.09% <5.00%> (-30.09%)
5.00 <0.00> (+1.00)
:arrow_down:

...ain/java/seedu/address/logic/commands/Command.java
100.00% <100.00%> (ø)
2.00 <1.00> (+1.00)

...va/seedu/address/logic/commands/DeleteCommand.java
100.00% <100.00%> (ø)
9.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5108dc3...5530cb5. Read the comment docs.


Remove installer dep from apis/

In a prior change (#2460 / c7581516) we tried using a UserTag type imported from openshift/installer, creating a dependency on same for downstream consumers of our apis/ package. This is causing problems downstream with the checksum database, so for the sake of unblocking those downstreams for now, we're pulling that out and copy/pasting the type definition instead (like we have always done in the past with types of this ilk).
We hope to reinstate the dependency in the future, as it would improve the maintainability of hive.
OCPBUGS-42448

/assign @jstuever
/cc @patrickdillon

/override "Red Hat Konflux / hive-mce-27-on-pull-request" "Red Hat Konflux / hive-operator-enterprise-contract / hive"


Add code for generating random rotating discs of bodies

Generalize approach from issue #18 to be able to generate rotating discs of bodies with no central body (or with one).

Use this capability to create rotating star cluster scenarios with and without central black holes. Create new SimSpace using parsecs and years. Use some random varied star sizes. Make these mini-galaxies with proper rotation.
Create a method in NumericTypesTests.sln to calculate forces and velocities for a rotating cluster with no massive central body. Start with 100 stars in an shared circular orbit and calculate what equivalent central mass would give the same acceleration. Next, look at the forces on a star from 100 stars in an orbit of half the radius of the star in question.


feat: add models and module for ecommerce

At the moment, the API client offers models and a client module for most modules and features, but it does not yet include functionality for the e-commerce endpoints and models.

[ ] Models

[ ] Add Product model
[ ] Add ProductSKU model
[ ] Add Order model
[ ] Add OrderAmount model
[ ] Add OrderAddress model
[ ] Add OrderCustomerInfo model
[ ] Add OrderDownloadedFile model
[ ] Add OrderItemImage model
[ ] Add OrderPurchasedItem model
[ ] Add OrderExtra model
[ ] Add OrderTotals model
[ ] Add StripeDetails model
[ ] Add StripeCard model
[ ] Add InventoryItem model
[ ] Add EcommerceSettings model

[ ] Module

[ ] List Products & SKUs (GET)
[ ] Create Product & SKU (POST)
[ ] Get Product and SKUs (GET)
[ ] Update Product (PATCH)
[ ] Create SKU (POST)
[ ] Update SKU (PATCH)
[ ] List Orders (GET)
[ ] Get Order (GET)
[ ] Update Order (PATCH)
[ ] Fulfill Order (POST)
[ ] Unfulfill Order (POST)
[ ] Refund Order (POST)
[ ] List Inventory (GET)
[ ] Update Item Inventory (PATCH)
[ ] Get Ecommerce settings (GET)

Webflow API documentation: https://developers.webflow.com/reference
Models documentation: https://developers.webflow.com/docs/models

This is being worked on in PR #12.

Hey folks! If you're looking to contribute for Hacktoberfest, this issue would be a great place to start!
Feel free to submit pull requests for parts of this issue, or even this entire issue if you have the time!
To help you get started, a WIP PR has already been created here: https://github.com/koalatiapp/webflow-api-client/pull/12
You can take a look at this PR as well as the existing codebase for the other Webflow endpoints/modules to have an idea of how to get started.
You may also ask questions in here and I will do my best to answer as fast as possible :)


FeatureRequest : there needs to be a way to add "feature-gates" to kubelet as like in Kind.

using Kind, we can add a featuregate like this:
kind: Cluster
apiVersion: kind.sigs.k8s.io/v1alpha3
kubeadmConfigPatches:
- |
  apiVersion: kubeadm.k8s.io/v1beta2
  kind: ClusterConfiguration
  metadata:
    name: config
  apiServer:
    extraArgs:
      "feature-gates": "EphemeralContainers=true"

Requesting for a similar feature

Well found out it can be added to /var/snap/microk8s/current/args/


Changes to Ansible role dataset_loader to add ATS 9 support

This PR includes several modifications to the main.yml file for the Ansible dataset_loader role. Work was undertaken to add ATS 9 support to the dataset_loader role to allow a version of ATS 9 to be utilized in a lab/testing environment. Previously, ATS 7 and 8 only were supported by the dataset_loader role. ATS 9 specific parameters were added where necessary to replace deprecated ATS 7/8 parameters. Other parameters in main.yml that caused spurious log messages in ATS 9 were moved to sections for ATS 7 and 8 in the file.

Which Traffic Control components are affected by this PR?

Automation - Ansible Roles - dataset_loader

What is the best way to verify this PR?

Determine version of ATS 9 to use in lab environment
Utilizing Ansible playbooks, build ATC lab environment
On lab caches, confirm ATS 9 is installed, running with no errors
On lab caches, confirm common and ATS 9-specific parameters are set in appropriate configuration files

PR submission checklist

[x] This PR has tests
[x] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@jhg03a , responded to all comments and made appropriate changes where necessary. Please review and provide anything additional you find.


Aggregate query on nested struct

Very cool project.  I'm just spinning up on bolthold and I'm trying to figure out if this query is possible, or if I need to restructure my data.
I'm attempting to get a count of grouped Sentiment and I've tried bunch of things to no avail.  I think I'm trying to figure out if this is possible.  Frankly, I'm just spinning up on bolthold, so concede I'm likely not doing it right.
	type SentimentResult struct {
		File           string `json:"File"`
		Line           int    `json:"Line"`
		Sentiment      string `json:"Sentiment"`
		SentimentScore struct {
			Mixed    float64 `json:"Mixed"`
			Negative float64 `json:"Negative"`
			Neutral  float64 `json:"Neutral"`
			Positive float64 `json:"Positive"`
		} `json:"SentimentScore"`
	}

	type ProjectSentimentResult struct {
		ID              uint64 `boltholdKey:"ID"`
		ProjectId       string
		QuestionId      string
		JobId           string
		SentimentResult SentimentResult
	}

I've tried
grp, err := store.FindAggregate(ProjectSentimentResult{}, bolthold.Where("JobId").Eq("ad1be007-91fa-41a5-5f48-b5720a107717"), "SentimentResult.Sentiment")

However that doesn't appear to work, because it complains about not knowing what SentimentResult.Sentiment is.
The field SentimentResult.Sentiment does not exist in the type *main.ProjectSentimentResult"}
I can do an .Eq() assertion for the Sentiment value, but that would mean I would need to do N queries for the different values in Sentiment.
I thought about using a Find() query first with a matchfunc and subaggregate, but that will not return the counts as the resultant is stored in passed in result slice if I understand correctly.
Thanks in advance for any help!  I really appreciate it.

Grouping currently doesn't support nested fields like queries do, otherwise this would work.
I'll mark this issue as an enhancement and add it when I get a chance.
Thanks for reporting this.

This is fixed in master.
Thanks,


[bug] cannot update HTTP port

Changing the value of Insecure HTTP Server Port seems to actually change the HTTPS port

Note I've kept the HTTPS port default, but modified HTTP to 27125, while the dev console shows HTTP still at 27123 and HTTPS at 27125. Changing the Secure HTTPS Server Port value also modifies the actual HTTPS port.

macOS 12.2.1

Obsidian v0.13.33

Put up a PR to fix the issue


AmericanExpress CVC is 4 digits number, not 3 digit

Isn't it a duplicate of https://github.com/jessepollak/card/issues/95 ?

Closing as a duplicate.


Bug: Week mode displays wrong month

In this photo selected date is December 1st 2017, but when the month view is transitioned into week view in the  FSCalendarScope example, the label displays "November 2017". This should instead display "December 2017". Also for this reason perhaps, there are no placeholders in the week view...
If you fix this bug please let me know a link to the commits you made so I can directly change it in the code as well. Thanks.

same problem，hope someone can give some idea

same problem here. At the moment we're in August, the week view as I have it shows up to the 30th of August, and yet the month says September already!

Same problem here

I solved it by changing minimum date to earlier date that agrees with your calendar first week day .

具体解决方法是什么，有Demo吗？

Any solution for this bug


Client unique-ness

The client should have its own unique token.
Maybe whenever the user first uses the app, we ask for a name and generate an ID and create a token out of it.
The client then saves that token & the server will work out who that token points to and sign them in
not sure, some shit like that tho

Done, added sessions that are validated on a per-request basis


[Tips] Right now Fail is not switch to Result scene, use this

In beatoraja.py
change
bms.player.beatoraja.result.MusicResult$IRSendStatus
to
bms.player.beatoraja.PlayDataAccessor writeScoreDara

maybe there's better option idk

Thank you I'll look into this in the upcoming days. This looks definitely more reliable than looking for the IR call, and will enable compatibility with setups that do not use IR at all.


skip swift extension if driver isn't 'postmark'

If the mail driver isn't set to 'postmark', don't register the Postmark transport for Swift.
Motivation and context
First of all this skips a bit of unnecessary code, but it also enables a developer to use this package in combination with other mail drivers in different environments.
For example, when combined with the 'themsaid/laravel-mail-preview' package, the artisan package:discover command would fail with a Class swift.transport does not exist error.

Hey @julesjanssen, love the idea and appreciate the PR, only problem is that the tests are failing. All of them say "InvalidArgumentException: Driver [postmark] not supported.". Once we get that and the other comment addressed it looks good to me.

1st: making the driver check a strict equality check is not a problem of course.
2nd: sorry about those failing tests, I hadn't really looked in to it yet. The update in 3c54d3b751747c0710be3e0771a825ed5d2c80d0 should fix that.


"Izvoare", "Liliac", "Țuțcanii din Deal" and "Țuțcanii din Vale" are listed in the drop-down menu

Description:
"Izvoare", "Liliac", "Țuțcanii din Deal" and "Țuțcanii din Vale" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Izvoare" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Izvoare, NEAMȚ (Bahna)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Liliac" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Liliac, NEAMȚ (Bahna)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Țuțcanii din Deal" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Țuțcanii din Deal, NEAMȚ (Bahna)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Țuțcanii din Vale" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Țuțcanii din Vale, NEAMȚ (Bahna)".


Initial schema definitions

Initial README detailing tables described in the TIDES pre-publication report.

TRB staff asked that we included acknowledgement and disclaimer language explaining the distinction between the TCRP research and the TIDES project.  (The current text here makes too concrete a link between the two.)  I have requested language from TRB and will recommend a revision to this document once I receive that.

[ ]  if a primary key is a single field, should that field be marked with the "unique" constraint? Clear but possibly redundant.
[ ]  put primary key fields first and in order listed in primaryKey key?
[ ]  no guarantee that parsers understand 25+ hour clocks (e.g., 25:08:01) as commonly used in transit to indicate operations part of the prior service day (Friday) but extending into the next calendar date (early Saturday morning). So time fields should probably all be one of "timestamp", "string" (GTFS style, "25:04:10") or "integer" (seconds since midnight of service date, e.g., 86644). I prefer integer.
[ ]  integer enums are not self-documenting, use string enums instead at the cost of larger file sizes. Data readers will probably implement more efficiently, e.g., R frictionless package reads string fields as factors (enums) when constraint is "enum".
[ ]  add "NA" to missingValues key for all tables, it's the default value used in the default R CSV writer
[ ]  use boolean type instead of imitating GTFS's lack of boolean type (integer enum [0, 1])

@botanize a lot of your questions stem from concepts from the prepublication report (describing 0/1 booleans as enums, time vs. timestamps, etc.). I share the suggestions you made, but I have a couple of outstanding points of clarification:

By changing the enum fields to be self-documenting, would it make sense to remove the documented acceptable values from the respective description fields, or should we keep the resulting duplicated references for acceptable values?

I had a similar concern with the ambiguity of timestamps. In the report they are not described as datetime and I think changing it to that would address the point you raised. I’m wondering if you’d rather we:

a. Convert all timestamps/“time” attributes to datetime and remove respective date attributes from impacted schemas

b. Use integer (as preferred) for timestamps we expect to have 25+ hour representations and datetime for the others. The question about the duplicative nature of a corresponding date attribute would remain relevant in those cases.

More thoughts on datetime/time and service date. We have some systems (AFC I think) that don't have a concept of service day and just record a datetime, others that have a service date and time (>24 hour format), or service date and datetime. I see two options:

Using service date + integer time is probably the most flexible and consistent. Systems that use datetime with or without service date can be easily converted to date + integer time, systems that use service date + time would be directly supported.
Service date could be optional, and timestamp would represent the calendar time (standard 24 hour clock). Systems that have a concept of service date could provide that, while converting service_date + integer time to calendar time for the timestamp field.

I think we also need to clarify that date means the service date, which may or may not be the same as the calendar date. This allows a trip that spans midnight to be one trip, when aggregated to daily metrics (total boardings, run-time).

I'm going to create an issue for date/time representation in the spec. It's clear that the TCRP report is under-defined, and I'm not sure we can or should make those decisions right now. Let's invite the larger community to engage on this one.

By changing the enum fields to be self-documenting, would it make sense to remove the documented acceptable values from the respective description fields, or should we keep the resulting duplicated references for acceptable values?
Yes.
I had a similar concern with the ambiguity of timestamps. In the report they are not described as datetime and I think changing it to that would address the point you raised. I’m wondering if you’d rather we:
a. Convert all timestamps/“time” attributes to datetime and remove respective date attributes from impacted schemas
b. Use integer (as preferred) for timestamps we expect to have 25+ hour representations and datetime for the others. The question about the duplicative nature of a corresponding date attribute would remain relevant in those cases.
Let's resolve issue #31 at a later date with more stakeholder engagement.


dispatcher: split into multiple interfaces to improve functional scoping

Commit Message: dispatcher: split into multiple interfaces to improve functional scoping
Additional Description: The Envoy event dispatcher is a bit of a multi-tool, and often only a small portion of its interface is used in a given context. Envoy Mobile has various cases where it needs to wrap or extend pieces of the Event::Dispatcher, but it's difficult to simply wrap it in its entirety given the amount of functionality it has. Having it implement more narrowly scoped interfaces makes it easier to do this.
This can also simplify mocking and testing dispatcher functionality in different contexts and could eventually support more compartmentalized implementation as well.
Risk Level: Moderate
Testing: Local & CI

Note this is straight refactor; it only moves the function declarations between interfaces, all of which the Dispatcher still implements. I did a search for the previous DispatcherBase and didn't find any usage.

/retest

@antoniovicente did you have additional feedback here?
@goaway do you mind merging main?

/retest

Thanks @antoniovicente!

/retest


'prisma migrate dev' using url instead of shadowDatabaseUrl

Bug description
When running prisma migrate dev it uses url as opposed to shadowDatabaseUrl.
ubuntu@dev-environment:~/gitrepos/yyy$ npx prisma migrate dev --name init
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db": MySQL database "yyy" at "xxxx:3306"

Error: P1010: User `xxx` was denied access on the database `mysql`

How to reproduce

Set the shadowDatabaseUrl variable in the schema.prisma file to a different database than what's defined in the url variable
Run npx prisma migrate dev
The above error will be seen with the database defined in the url variable, indicating that its not using the one defined by the shadowDatabaseUrl

Expected behavior
No response
Prisma information
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider          = "mysql"
  url               = env("DATABASE_URL")
  shadowDatabaseUrl = env("SHADOW_DATABASE_URL")
}

Environment & setup

OS: Linux
Database: MariaDB
Node.js version: v20.5.1

Prisma Version
prisma                  : 5.1.1
@prisma/client          : 5.1.1
Current platform        : debian-openssl-3.0.x
Query Engine (Node-API) : libquery-engine 6a3747c37ff169c90047725a05a6ef02e32ac97e (at<EMAIL_ADDRESS>Schema Engine           : schema-engine-cli 6a3747c37ff169c90047725a05a6ef02e32ac97e (at<EMAIL_ADDRESS>Schema Wasm             : @prisma/prisma-schema-wasm 5.1.1-1.6a3747c37ff169c90047725a05a6ef02e32ac97e
Default Engines Hash    : 6a3747c37ff169c90047725a05a6ef02e32ac97e
Studio                  : 0.492.0

The shadowDatabaseUrl is only used for shadow database functionality. You are still trying to create a migration for your actual database defined in url, so it has to talk to your normal database. And if that does not work, then it can not proceed and get to the actual step where it would try to talk to the shadow database.
Do you agree that there is no problem then and this issue can be closed?

The shadowDatabaseUrl is only used for shadow database functionality. You are still trying to create a migration for your actual database defined in url, so it has to talk to your normal database. And if that does not work, then it can not proceed and get to the actual step where it would try to talk to the shadow database.
Do you agree that there is no problem then and this issue can be closed?

The documentation (and what I gathered from the linked ticket) seems to imply that if I didn't want to give *.* permissions to my database user that I would instead use the shadow database url definition.
https://www.prisma.io/docs/concepts/components/prisma-migrate/shadow-database#shadow-database-user-permissions
So if that's not the case then how would I get around not giving those permissions to my database user? I only want them to act on the database defined in the databaseUrl. So only grant all those permissions on that single database.

You give the needed shadow database permissions to the user you use in shadowDatabaseUrl, and you use limited permissions for your normal database connection string in url. This way migrate dev can do shadow database things with that connection string, and normal "let me figure out what the state of the database is" with the normal connection string and potentially run the migrations later.
Note: url and shadowDatabaseUrl should point to different databases. Usually Prisma just creates a temporary shadow database with the url credentials, but if you don't want to allow that, you have to give Prisma an already existing database to work with.

Right. They do point to different databases, and the grants for my user look like the below
| GRANT ALL PRIVILEGES ON `database`.* TO `dev`@`%`                                                         |
| GRANT ALL PRIVILEGES ON `database_dev`.* TO `dev`@`%`                                                     |
+----------------------------------------------------------------------------------------------------------------+

Where database is the one used by databaseUrl and database_dev is used by the shadow.
The problem is that prisma migrate dev still seems to require that I setup *.* permissions which I don't want to do.

Do you get the same error when running npx prisma db pull with your main database credentials?

Actually, we looked into the code a bit: mysql as database name is only used when the defined database name (form the connection string) does not exist, and Prisma needs to actually create the database first. In MySQL you have to connect to a database, and mysql as a system database usually exists.
Is it possible that yyy (from your output) does not actually exist yet?
Does the problem go away if you create that database manually first? Then Prisma should not try to connect to mysql at all.

Ya that's the thing. Both of those databases already exist and my user has those above permissions on them. I am using mariadb if that matters.

It shouldn't.
Can you recount how you created and configured that user? I guess that is what we would need to have to reproduce the problem you describe.

create user 'dev' identified by 'password'
grant all privileges on database.* to 'dev'@'%';
grant all privileges on database_dev.* to 'dev'@'%';

This is what I did in AWS to create the user and grant permissions on the pre-made databases. I am also connecting via an ssl certificate if that's relevant.

Thank you, with that someone should be able to reproduce your setup (2 databases database and database_dev, one for url and other for shadowDatabaseUrl) on our side and see if they get the same error you are getting.


Touch screen is not supported

Touch screen is not supported. When I try to use Brackets on my Thinkpad Yoga with touch screen, I can't use my fingers to collapse/expand folders in the folders tree. Instead, the virtual keyboard shows up whenever I try to use touch screen.

@amamf This is a duplicate of https://github.com/adobe/brackets/issues/10630


Support TCP server first protocol in echo

This is to help us add tests in the future (will send after this is merged or in parallel).
This adds a mode for echo to be server first. This impacts the server (send magic string on connect) and the client (wait for magic string before sending the request)
Manually tests:

Mismatch of server-first on client and server fails
Mismatch of magic string fails
In mesh, request is instant for declared protocol
In mesh, request is 5s for non-declared protocol

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
76d5cc08ba361c45fb707f66385d2452d53a582c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
76d5cc08ba361c45fb707f66385d2452d53a582c
link
/test release-notes_istio

integ-security-k8s-tests_istio
76d5cc08ba361c45fb707f66385d2452d53a582c
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Router Locals Mapping

It would be nice if the Router allowed callback functions or route mapping for server variables. Sometimes, I want different locals to be rendered for every route. Mapping a route to a locals object would be efficient.
new Router(app, {
  '': { x: 'home' },
  'user': (req, res) => { { x: req.params.username } },
})

Dynamic locals can be functions while static locals can simply be plain objects.

This will take some time. Route mapping is quite complicated but doable.


Funding Identifiers are not returned from EarthChem

Description of the bug
Create a new EarthChem record with the properties filled out for funder -> identifiers -> (Scheme, Scheme URI, Identifier, Url).  The EarthChem record is created but when it is retrieved, identifiers is None.  The json-schema validation fails and an error results.
Steps to reproduce the bug:

Fill out a new EarthChem record, including funder identifiers
Save and observe an error

Expected behavior
There should be no error when submitting an earthchem record with funder identifiers.
Additional information
(https://github.com/earthchem/ecl-spec/blob/main/schemas/ECL-JSON-v2.0.0.json#L702-L736)

This appears to have been fixed.


Cannot setState within the beforeChange and afterChange callbacks without also reloading ALL the slide components.

It seems impossible to change the slider’s currentSlide state within the beforeChange and afterChange callbacks without also reloading ALL the slide components. This is causing unacceptable presentation issues as GatsbyImages disappear and reappear on every slide action.
I have tried using both functional components and classes, changing ref, context and useState, and no matter how I manage state, every-time the state is changed within the callbacks, even when using a setTimeout, all the slides are reloaded.
Here is a minimal reproducible example, if you view the console as the slide runs, you should see what I mean,
https://codesandbox.io/s/beforechange-afterchange-react-slick-forked-lhgyxj?file=/src/components/slickCarousel.js
Other closed issues reference the SlickGoTo example, but this example is very basic and does not use components as slides. For my use case I am trying to trigger code within the slide component when the slide becomes active.
I haven’t been able to get the [wrapping component workaround] (https://github.com/akiran/react-slick/issues/576#issuecomment-266243192) to work for me yet. Any tips appreciated. Thanks.

SlickGoTo should work for this usecase.
You can try it out and let us know if you run into any problems


How to simulate the digital .spice with xschem?

Paste the .spice content in the spice_syum_def param:


UX: Cloneable traits [age crate]

For ergonomics it would nice to be able to clone the Identity and Recipient traits, had a few usecases where it becomes unwieldy without it.
Probably the easiest way to implement this is with https://github.com/dtolnay/dyn-clone,
There is also a convenience macro wrapper for that crate here: https://github.com/kardeiz/objekt-clonable, which ends up with minimal extra code and just adding supertraits, such as:
#[clonable]
pub trait Recipient: Clone {
 ...
}

Would also have to derive clone on some internal structs that use it too, Stanza, Header, BaseDecryptor, etc.
Could whip up a draft PR if this is something you be interested in. Thanks.

I'm not sure I want to require that Identity and Recipient are cloneable. That might be reasonable for some (or even most) Recipient implementations, but Identity implementations are much more likely to not be suitable for cloning (e.g. if they wrap a connection to an HSM or KMS; the latter could also be the case for Recipient).
What specific use cases did you encounter that were unwieldy without a Clone bound?

After #523, it will no longer be necessary to clone Recipient impls in order to use them across multiple files (aligning the API with how Identity was used for decryption).


Create room generator

There has to be a room generator so admin users can easily generate rooms.

Done in #63


Correctly update Assignee and current iteration

There's one bug fix and one feature in this PR.
First, the Patch document isn't formatted correctly when un-assigning a Quest issue. The patch document needs to use the "Remove" operation.
Second, update the iteration on the following events:

Adding a new Quest item. If it is assigned, put it in the current iteration.
When a linked issue is opened / closed, put the associated quest item in the current iteration.

That code uses new query that retrieves all the current iterations when the app starts.

I just finished testing this locally.
Let's not merge this until Monday. If merged, the new code will run over the weekend.


Version 3.1.0 available

According to source page https://www.thepay.cz/ke-stazeni/ is latest available version of library 3.1.0.
Could you please update the package.

Thank you, updated


kube-aws: use rkt for decrypt-tls-assets

fixes #545
My investigation has found (at least on my reproductions) that kubelet.service failing for dependency reasons is caused by decrypt-tls-assets.service explicitly listing docker a dependency and failing for that reason.
I took this opportunity to switch us over to rkt for decrypting the TLS assets as well.
\cc @aaronlevy @robszumski @pbx0 @cgag

\m/ lgtm besides addressing robs comment

I see the confusion between dependencies and ordering dependencies pop up a lot in discussion of systemd units here. @pbx0 @robszumski I highly recommend reading this section on Before/After of the systemd docs carefully. The crux is:

Note that this setting is independent of and orthogonal to the requirement dependencies as configured by Requires=.

Understood, SGTM

We have a successful e2e run on this PR, so I'm going to merge it and fix #670


Incorrect Credentials?

I'm putting in the credentials, but it keeps coming up as Incorrect credentials passed.

If you're editing the config file with notepad, it breaks the file.  Each section needs to be on their own line too.  Also remember to save the file.

I'm using Notepad++.

Finally, I got it. Sorry for wasting your time.


Calling only addSchemaMetadata function causes Web GUI to indefinitely "load"

In v0.5.0, adding only the schema metadata by calling addSchemaMetadata function defined in SchemaRegistryClient.java causes the Web GUI to get indefinitely stuck in the loading screen after refreshing.

Closed due to inactivity.


Files App doesn't remember last session (opened folders) as default explorer

Description
The Files App doesn't remember its last session of opened folders with the option turned on+As a Default Explorer app.
There are two main different ways of opening the app, one is as shortcut/lnk and the other is by using it as the default file explorer (As its an experimental option, its an expected behavior but it might help to have this noted when the option receive updates)
Steps To Reproduce

In the Files App > Experimental turn On "Set Files as the Default File Explorer";
Close the app (maybe to save the configs?) and open it with either the default explorer key Win+E or with a created shortcut;
Open multiple folder tabs, only one more is enough;
Close the app and re open it with with the default explorer key Win+E;
Check the last session not opening back.

Expected behavior
Opening Files App should start the last session of opened folders as normal in any startup method.
Files Version
<IP_ADDRESS>
Windows Version
Windows 10 Pro 20H2 19042.1466
Relevant Assets/Logs

#7272


efficient parsing of big files

as part of a project I'm developing, I needed to be able to efficiently parse big EDF files lying on remote network/cloud storage, without the need to read all the file.
I quickly implemented a new method to get only a selection of records. No significant changes have been made to original code, apart some minor added feature. New method is tested alongside old ones, with some added testing conditions as well.

Looks good, thank you for the contribution. I merged your pull request with the master branch.


Improve OAuth documentation on backend to backend OAuth

The draft documentation can be viewed here: https://github.com/UnionInternationalCheminsdeFer/OSDM/blob/491-improve-oauth-documentation-on-backend-to-backend-oauth/spec/authentication.md

Note that the draft has been merged into the main documentation branch, hence it can be viewed at https://osdm.io/spec/authentication/

Job done, thank you Josef!


Add Support for specifying git branch and tag in devfile

What type of PR is this?
/kind feature
What does does this PR do / why we need it:
Updates go-git library
Users can specify git branch and git tag using checkoutFrom in devfile, This PR implements the same
starterProjects:
  - name: odo
    git:
      remotes:
        origin: https://github.com/openshift/odo
      checkoutFrom:
        revision: v2.0.0
        remote: origin

Which issue(s) this PR fixes:
Fixes #4257
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[ ] Documentation

[x] I have read the test guidelines

How to test changes / Special notes to the reviewer:
Specify revision as shown above in devfile, revision could be a tag or branch. odo should download the starter project from specified branch/tag

Need to write tests

/retest
Does not seemed to be linked error with the PR.
 When linking devfile component with Operator backed service
  /go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:360
    should successfully connect and disconnect a component with an existing service [It]
    /go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:410
    No future change is possible.  Bailing out early after 300.515s.

    Running odo with args [odo push]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
    /go/src/github.com/openshift/odo/tests/helper/helper_run.go:34
------------------------------

Does not seemed to be linked error with the PR.
 When linking devfile component with Operator backed service
  /go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:360
    should successfully connect and disconnect a component with an existing service [It]
    /go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:410
    No future change is possible.  Bailing out early after 300.515s.

    Running odo with args [odo push]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
    /go/src/github.com/openshift/odo/tests/helper/helper_run.go:34
------------------------------

The reason for failure shows before the summary of failure. Here are the relevant logs:
 [odo] I1201 07:54:17.997656   69701 deployments.go:139] Waiting for deployment "xpcvfl" rollout to finish: 0 of 1 updated replicas are available...
[odo] I1201 07:54:17.997662   69701 deployments.go:146] Waiting for deployment spec update to be observed...
[odo]  ✗  Waiting for component to start [5m]
[odo]  ✗  Failed to start component with name xpcvfl. Error: Failed to create the component: error while waiting for deployment rollout: timeout while waiting for xpcvfl deployment roll out
Deleting project: khbtduaeqe
Running odo with args [odo project delete khbtduaeqe -f]
[odo] I1201 07:59:17.399962   69728 util.go:736] HTTPGetRequest: https://raw.githubusercontent.com/openshift/odo/master/build/VERSION
[odo] I1201 07:59:17.400252   69728 util.go:757] Response will be cached in /tmp/odohttpcache for 1h0m0s
[odo] I1201 07:59:17.592408   69728 util.go:770] Cached response used.
[odo]  ⚠  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project may still exist on a different node.
[odo] I1201 07:59:17.684440   69728 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
[odo]  ✓  Deleted project : khbtduaeqe
Setting current dir to: /go/src/github.com/openshift/odo/tests/integration/operatorhub
Deleting dir: /tmp/689072515
------------------------------
• Failure [368.286 seconds]
odo service command tests for OperatorHub
/go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:17
  When linking devfile component with Operator backed service
  /go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:360
    should successfully connect and disconnect a component with an existing service [It]
[Fail] odo service command tests for OperatorHub When linking devfile component with Operator backed service [It] should successfully connect and disconnect a component with an existing service
/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34
Ran 15 of 15 Specs in 823.713 seconds
FAIL! -- 14 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestOperatorhub (823.72s)
FAIL

We're hitting #3256 like in many other recent CI failures. :cry:

/retest
level=error
level=error msg="Error: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached."
level=error msg="\tstatus code: 400, request id: a8befd5a-4663-4987-864f-1f2b4d67c19c"
level=error
level=error msg="  on ../tmp/openshift-install-225736861/vpc/vpc.tf line 6, in resource \"aws_vpc\" \"new_vpc\":"
level=error msg="   6: resource \"aws_vpc\" \"new_vpc\" {"
level=error
level=error
level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply Terraform: failed to complete the change"
2020/12/02 07:31:55 Failed to upload $KUBECONFIG: timed out waiting for the condition: stat /tmp/secret/kubeconfig: no such file or directory
error: failed to execute wrapped command: exit status 1

Need to write tests

Is this ready for review?

Need to write tests

Is this ready for review?

yes

@adisky: The following tests failed, say /retest to rerun all failed tests:
Test name 	Commit 	Details 	Rerun command
ci/prow/v4.5-integration-e2e 	85c504b link /test v4.5-integration-e2e
Full PR test history. Your PR dashboard.

/override ci/prow/v4.5-integration-e2e

@adisky I'm trying to check out the functionality and am facing a few issues. Maybe I'll ask a few embarrassing questions. First, I forked https://github.com/odo-devfiles/nodejs-ex repo and created a separate branch with minor changes. Here it is: https://github.com/dharmit/nodejs-ex/commit/5d68d95ce14da8e5ded8ec3e972936654c5f3f0b.
Next, I built odo binary using your PR (well, obviously!)
Steps followed after that:
$ git clone repo
$ cd repo

$ odo create nodejs node

# next I modified the devfile and did `odo push`

On the URL, I see the message Hello from Node.js Starter Application! instead of the change I made. Here's the devfile:

 devfile
commands:
- exec:
    commandLine: npm install
    component: runtime
    group:
      isDefault: true
      kind: build
    workingDir: /project
  id: install
- exec:
    commandLine: npm start
    component: runtime
    group:
      isDefault: true
      kind: run
    workingDir: /project
  id: run
- exec:
    commandLine: npm run debug
    component: runtime
    group:
      isDefault: true
      kind: debug
    workingDir: /project
  id: debug
- exec:
    commandLine: npm test
    component: runtime
    group:
      isDefault: true
      kind: test
    workingDir: /project
  id: test
components:
- container:
    endpoints:
    - name: http-3000
      targetPort: 3000
    - exposure: public
      name: node-3000
      path: /
      protocol: http
      targetPort: 3000
    image: registry.access.redhat.com/ubi8/nodejs-12:1-45
    memoryLimit: 1024Mi
    mountSources: true
    sourceMapping: /project
  name: runtime
metadata:
  name: nodejs
  version: 1.0.0
schemaVersion: 2.0.0
starterProjects:
- git:
    checkoutFrom:
      remote: origin
      revision: my-branch
    remotes:
      origin: https://github.com/dharmit/nodejs-ex.git
  name: nodejs-starter

What am I doing wrong?

devfile
What am I doing wrong?

This works when you download starter project with odo odo create nodejs --starter, you are cloning the project by yourself


Dialogs: improve API

You makes it really simple to open simple dialogs. I suggest a few additions:

You have created a service with alert/prompt/confirm methods. If I need to open custom-component dialog I would need to inject MdDialog service to open it. So it often ends up with injecting two similar services. It would be great to have simple open method from MdDialog in TdDialogService to avoid double injection.

Add simple alternatives to alert/prompt/confirm that way:
prompt(string): Observable<string>;
It would allow even simpler way to use dialogs!

PS: I can make a PR for this if you like the ideas!

I agree, it would be simple to create wrapper methods to the MdDialog methods inside TdDialogService so we dont have to inject both. e.g. tdDialogService.open(CustomDialog)

Added point no 1 and will be available for 0.10.


chore: upgrade charts

updated chart jx3/jx-charter from 0.0.3 to 0.0.13

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign hferentschik
You can assign the PR to them by writing /assign @hferentschik in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm-kapp
f06907858488505f1ec9d351b841ff69d0b735f5
link
/test gsm-kapp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm-kapp
f06907858488505f1ec9d351b841ff69d0b735f5
link
/test gsm-kapp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest


Add back penguin sklearn to pre-commit checks

Related to #61

Oh that's funny, yapf caused lint errors. https://github.com/tensorflow/tfx-addons/pull/62/files#diff-64892c783cb937313fc35f3e3c429f867f78aad2e70afde0a88390bd3d4a1822R192

Yeah, I can fix those and merge :P will do tomorrow though

@TheMichaelHu Can you review and merge if possible?

Looks like I don't have permission to merge this PR for you.


etcd doesn't bind --listen-peer-urls for outbound peer traffic

Similar to a previous issue (Feature Request: Ability to pick source IP address), we would like the ability to specify the source address of the peer traffic.
In our environment each node has multiple IP addresses, including a specific IP for etcd. While inbound traffic is handled correctly by etcd, outbound peer traffic is handled by binding any available address, resulting in identity issues, i.e. with client certificates.
While this could be handled by using other tools to NAT the outbound traffic of etcd, we consider this to be unexpected behaviour. Additionally, as the outbound ports are dynamic, NATing this traffic is very difficult to do at a granular level to ensure that only etcd traffic can use it's assigned IP.
etcd Version:
3.3.2
Expected:
When --listen-peer-urls is set, etcd will bind the given IP address for outbound traffic to peers.
Actual:
etcd binds any available address for outbound traffic to peers.
Steps to reproduce:

Configure etcd with --listen-peer-urls set on a node that has multiple outbound IP addresses.
Join the etcd instance to a cluster.
Observe source address (i.e. via tcpdump)

Proposed solutions:

Attempt to bind the address from listen-peer-urls, fall back to any available address if bindable
Add a configuration flag for the outbound address to bind

Just as a note, we are happy to invest effort into adding this if it will be upstreamed

@chaosaffe I'm not sure I follow what you believe is wrong with selecting source ports from the ephemeral port range and what problems this has caused with client certificates. Could you explain the motivation in more detail?

@jpbetz the issue isn't the source port range, rather the source IP.
We have multiple IP's assigned per node, and while an etcd instance will only listen on the listen-peer-urls IP, the etcd instance will connect to peers using any IP available on the node.
As the source IP is not deterministic, we must add any potential node IP to the peer certificate SAN as we cannot deterministically assign which IP an etcd instance will use to contact it's peers.
Example:
Node Addresses:

<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
etcd-1 started with --listen-peer-urls="https://<IP_ADDRESS>:2380"

Current Result:
peer -> etcd-1 will use a destination IP of <IP_ADDRESS>
etcd-1 -> peer will use a source IP of <IP_ADDRESS>, <IP_ADDRESS> or <IP_ADDRESS>, non-deterministically
Expected Result:
peer -> etcd-1 will use a destination IP of <IP_ADDRESS>
etcd-1 -> peer will use a source IP of <IP_ADDRESS>

@chaosaffe What do your network segments look like, and what are the subnet masks for each of those addresses? As I understand it, you're trying to ensure that etcd will use the listen-peer-url address as the source for the peer connections? That should happen automatically assuming that the <IP_ADDRESS> is on a smaller subnet (/24 for example) than <IP_ADDRESS>, and that all peers are on the same <IP_ADDRESS> subnet and network segment.
If instead all of the addresses you listed have a /8 subnet mask (<IP_ADDRESS>), then yes, any of those addresses will be equally likely to be chosen as a source address.

@joelegasse our subnets are the following:

interface
etcd-1 Node
etcd-2 Node
etcd-3 Node

lo
<IP_ADDRESS>/32
<IP_ADDRESS>/32
<IP_ADDRESS>/32

eth0
<IP_ADDRESS>/30
<IP_ADDRESS>/30
<IP_ADDRESS>/30

eth1
<IP_ADDRESS>/30
<IP_ADDRESS>/30
<IP_ADDRESS>/30

Peers do not share a subnet. We have a 3 layer CLOS topology. Peers do not share a network segment, they are on separate ToR's.

Putting all etcd instances into the same subnet (<IP_ADDRESS>/28) resolved the issue, but I can't find any documentation on this. Can we hold the issue open until we can make a docs PR please?

@chaosaffe Another option would be to adjust the routing table on each of the nodes to select the desired source IP at the OS/kernel level.
I don't really consider this to be an etcd issue. You would see this same behavior out of a lot of systems, since most don't specify a source IP as the OS generally handles the network configuration of a host. I don't think the etcd documentation is the correct place to include instructions about source address selection.

Fair enough. Thank you for your help!


Update Size Limit to 4096

For better compatibility with WebPush, see #26 for more info.
This can be merged anytime on or after May 28 if there are no unresolved objections by then. Please discuss this on #26, not here.

We may update SERV_1.0.1 to SERV_1.1.0 atm

I think this can be merged now

I think this can be merged now

@p1gp1g


fix: Component Governance alert for nconf

Fixes #4188
Description
Branch main has 2 code governance alerts with high severity or above:

minimist 1.2.5 severity: critical
nconf 0.11.2 severity: high

This fixes nconf. minimist requires a new release of orchestrator-core. It could be released as version 4.14.4.
Specific Changes
Bump nconf to 0.11.4.
Update dependency @microsoft/orchestrator-core to latest: 4.14.3.
Drop an irrelevant package-lock.json file.
Update yarn.lock to match changes.
Add Component Detection to streaming E2E tests.

Closing because checks failed.


Allow tooling API tests to fail before emitting BUILD FAILED

In some cases, for example when using the tooling API with an invalid JVM, an exception is thrown and BUILD FAILED is not printed. In these cases, do not require the specific build output and accept that an exception being thrown is enough evidence to verify that the build has indeed failed.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gadlel help

@bot-gradle help

Currently, the following commands are supported:
@bot-gradle test <BuildTrigger1> <BuildTrigger2> ... <BuildTriggerN> [without PTS]
Add without PTS to run the build with full test coverage.

A trigger is a special build for this PR on TeamCity, common triggers are:

SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/PullRequestFeedback/ReadyForNightly/ReadyForRelease
Shortcuts: SC/CA/QFL/QF/PRF/RFN/RFR
Specific builds:

BD: BuildDistributions/BuildDocs so that you can preview the generated docs/distribution.
PT: PerformanceTest, all performance tests for Ready For Nightly stage.
APT: AllPerformanceTest, all performance tests, including slow performance tests.
AST: AllSmokeTestsPullRequestFeedback
AFT: AllFunctionalTestsPullRequestFeedback
ASB: AllSpecificBuildsPullRequestFeedback
ACC: AllConfigCacheTestsPullRequestFeedback
ACT: AllCrossVersionTestsReadyForNightly
AFTN: AllFunctionalTestsReadyForNightly
ACTR: AllCrossVersionTestsReadyForRelease
AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle squash

Squash the current pull request into a single commit. The squash message will come from the pull request body, with:

All Signed-off-by: lines kept.
All authors being Co-Authored-By:

@bot-gradle merge

Enqueue this PR into GitHub merge queue for merging.

GitHub will create a merge commit from your PR branch HEAD and the target branch
A GitHub Merge Queue Check Pass build will be triggered on the merge commit
When the build passes, the target branch will be fast-forwarded to this merge commit (i.e. merge the PR)

@bot-gradle squash and merge

Squash the current pull request into a single commit as described in squash command above,
then enqueue this PR into GitHub merge queue as described in merge command above.

@bot-gradle cherrypick to <branch>

Cherrypicks the current PR to another branch.
A new PR will be created and a build will triggered automatically if there is no conflict.

@bot-gradle cancel

cancel a running build in GitHub merge queue and remove the PR from the queue

@bot-gradle clean

clear the conversation history

@bot-gradle help

display this message

To run a command, simply submit a comment.  For detailed instructions see here.

@bot-gradle test ACTR QF

I've triggered the following builds for you. Click here to see all build failures.

AllCrossVersionTestsReadyForRelease build
QuickFeedback build

@bot-gradle test ACTR QF

I've triggered the following builds for you. Click here to see all build failures.

AllCrossVersionTestsReadyForRelease build
QuickFeedback build

@bot-gradle test ACTR

I've triggered the following builds for you. Click here to see all build failures.

AllCrossVersionTestsReadyForRelease build

The merge queue build has failed. Click here to see all failures.