ubsan: jerryscript/jerry-core/ecma/base/ecma-helpers-conversion.c:702:5: runtime error: shift exponent 64 is too large for 64-bit type 'long unsigned int'

JerryScript revision

ccc1525
Build platform

Ubuntu 20.04.1 LTS (Linux 5.4.0-74-generic x86_64)
Build steps

readonly FLAGS=(
  "-g -O1 -fsanitize=address,undefined -fno-sanitize-recover=undefined,address"
)
cmake -D CMAKE_C_FLAGS="${FLAG}" -D CMAKE_BUILD_TYPE=Debug -D CMAKE_INSTALL_PREFIX:PATH="${INSTALL_DIR}" "${SRC_FOLDER}"
make
make install

Test case

o2 = 13.37;

Output

jerryscript/jerry-core/ecma/base/ecma-helpers-conversion.c:702:5: runtime error: shift exponent 64 is too large for 64-bit type 'long unsigned int'

Expected behavior

According to C99 standard (6.5.7/3):

The integer promotions are performed on each of the operands. The type of the result is
that of the promoted left operand. If the value of the right operand is negative or is
greater than or equal to the width of the promoted left operand, the behavior is undefined.

It seems that #4294 also mentioned this undefined behavior (UB#11)


No cursor hover on navbar menu icon

When the navbar menu is in the collapsed mode (hamburger menu icon appears), your cursor should change to a pointer when hovering over the menu button to show that it's a button. Should be a quick fix, can you do this @zNon18 ?

Fixed it! Thank you for pointing that out.
https://www.loom.com/share/0f9077fbbfbe4245a0556f039aa696d6

Sweet. For practice, close this issue!


Content Suggestion: Pocket Bitcoin

Link to Content: pocketbitcoin.com
Briefly Describe Content:
Pocket exchanges your bank payments automatically into bitcoin. The bitcoin are then sent directly into your own Bitcoin wallet. You can also set up a recurring payment to automate your buys (DCA). Pocket also helps people getting started on their Bitcoin journey by guiding them through the process of buying and storing their bitcoin. Pocket provides different hardware storage options.
Suggested Section: Get Bitcoin
Description: Buy; Location: EU; Auto DCA: Yes

Added
Thanks


Warning for creates when the resource already exists

Generated based on discussion in issue #3574.
Creates in Azure and the CLI are (or at least should be!) idempotent, so running the same create command twice with the same parameters should result in success.
The suggestion raised by @alexeyshishkin01 would be to issue a warning so the user knows that an existing resource is being overwritten by this create command. We do this already in certain instances where it can be done "for free", but in the general case, for top-level resources, it would likely require us to make an additional REST call in order to decide whether to issue the warning or not.
Pros and cons.  Thoughts?

We have discussed this within the team and decided not to implement this. For top-level resources this would necessitate an extra API call to check for existence, which is a pattern we actively discourage.


Renames user1 import to userv1

This has been applied to master too but as part of patch which didn't make it to this branch

Wrong branch!


Lazy plugin loading

For heavy plugins like tpope/vim-rails it would be lovely to have a lazy option like plug. Any interest in this feature? Thanks!

No, it's unlikely I'll add this, I'm sorry.
It's worth noting that vim-plug's own lazy loading does very little. In particular, vim-rails defines most of it's logic in the autoload directory (in a single file… but whatever), so it shouldn't increase start-up time much.
 You can use that with an autocommand if you want. Unfortunately, neovim doesn't have a way to define autocommands in Lua (see neovim/neovim#12378).

Alternative solution: Declare vim-rails as an optional plugin, and define an autocommand for it
paq {'tpope/vim-rails', opt=true}
vim.cmd [[autocmd Filetype ruby packadd! vim-rails]]

Makes sense, and thanks for the pointers! :pray:


Fixes TEM Segmentation issue

This quick PR aims to fix segmentation issue for TEM dataset.
Fixes #230

Coverage remained the same at 82.738% when pulling 62ce186cffa6ab9e04e7ef2212f9ef856be22420 on dev_issue230 into 785012eb16ab7d8d9c3a2526dc0edf82d35f8ba4 on master.

@Stoyan-I-A can you please test this PR and confirm it fixes your issue? there is no code for me to review (only binaries)

I just tested it on the image shown in #230. It works.

@vs74 even though this branch resolves @Stoyan-I-A's issue, as Julien said the only changes done were in the model files, so would you mind briefly explaining what you did to resolve this issue here to clarify it for us now and in the future?

The TEM model was trained on commits prior to commit 2c45120. In commit 2c45120 I introduced better visualisation support for tensor board wherein I implemented scope variables and names. The TEM used in ADS was outdated so I had to retrain the model and  fix these model files.


LiveEvaluateFunctionView

A simple widget to test local tasks with electron

To be clear, this refers to calling Task-type functions that are defined by a Python back-end, right? Not allowing evaluation of arbitrary functions sent in from the UI?

To be clear, this refers to calling Task-type functions that are defined by a Python back-end, right? Not allowing evaluation of arbitrary functions sent in from the UI?

Correct. And this one is just for development/testing. Minimal example.


doc: Add pino and lightstep middlewares to list of middlewares

Add graphql-pino-middleware, graphql-lightstep-middleware to list of middlewares

Could you add a semantic release compliant commit? I can merge afterwards.


New version: Microsoft.WindowsAppRuntime.1.6 version 1.6.3

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Program Files\WindowsApps\Microsoft.WindowsAppRuntime.1.6_6000.318.2304.0_x64__8wekyb3d8bbwe\DeploymentAgent.exe returned exit code: -2147024736
Executable C:\Program Files\WindowsApps\Microsoft.WindowsAppRuntime.1.6_6000.318.2304.0_x64__8wekyb3d8bbwe\RestartAgent.exe returned exit code: -1073740791
Executable C:\Program Files\WindowsApps\Microsoft.WindowsAppRuntime.1.6_6000.318.2304.0_x86__8wekyb3d8bbwe\DeploymentAgent.exe returned exit code: -2147024736
Executable C:\Program Files\WindowsApps\Microsoft.WindowsAppRuntime.1.6_6000.318.2304.0_x86__8wekyb3d8bbwe\RestartAgent.exe returned exit code: -1073740791

Automated error analysis suggests -1073740791 may mean Stack overflow / exhaustion.
(Automated response - build 897.)


What MMU would you recommend with this?

I have been playing around with this on my ICE40 using this chinese 8M Quad-SPI PSRAM and it works great.
I was thinking of building some kind of kernel that utilizes real processes and was wondering what kind of small/simple MMU would you recommend.  I still have 30% of the chip available but wanted to be stingy.  I was thinking of a simple 74LS612 type MMU controller with masks for KERNEL/USER space.  The idea of putting in a full TLB with caching seems a bit much for trying to keep it simple.
I was wondering on your thoughts on this.  Is it practical to make a simple MMU just for size, or is it better to just cut in the normal one from the RISCV isa?

I wouldn't recommend any MMU for PicoRV32. It's a tiny embedded core aimed at applications that traditionally have no need for MMUs.


[awake] disable temporarily

Description of the new feature / enhancement
In addition to the existing "Keep awake temporarily", I would love seeing a "Disable awake temporarily" with the same options (30 minutes, 1 hour, 2 hours).
Scenario when this would be used?
Somebody is working from home (WFH) and has awake enabled. When their break starts, they disable awake so their IM (Slack, etc) status automatically switches to inactive/away. Since it is just temporarily, you can't forget to enable it again and you are automatically returning after 30 minutes and all your remote colleagues are aware of it too.
It adds some more plausibility to WFH, if you are constantly online and never AFK it will eventually raise some suspicion.
Alternatively, it would be awesome too, if you could set awake schedules.
Supporting information
No response

Thank you for the feedback, @grandeljay. Tagging this as wont-fix mainly because this seems counter to what Awake is - it doesn't track or change app status (Slack/Zoom/Teams/Skype/etc.) and its default state is to keep the OS settings for power management as-is, so the solution here is to disable Awake when you're taking a break and then re-enable it whenever you re-start work.


Change subscriptions table and the way of storing it

https://github.com/trustwallet/blockatlas/issues/1065

I don't fully understand the things behind it, but I approve.
Diff codecov 0% : if measurement is real, doesn't look good.


Some shortcuts override AZERTY special characters inserting

GitLens Version: 5.7.1
VSCode Version: Version 1.18.0-insider (1.18.0-insider) aaec2980609a4bbe44d0cfe2d3f78c85cba1be83
OS Version: macOS High Sierra 10.13 (17A405)

Steps to Reproduce:

Have an AZERTY keyboard
Type \ (⌥⇧:)
see that the commit search shows up instead of a backslash

{
  "command": "gitlens.showCommitSearch",
  "key": "shift+alt+[Period]",
  "when": "gitlens:enabled"
}

This happens because alt and alt-shift on Mac in AZERTY are used to enter special characters (for example \,ß that could be used in code)

I manually disabled those, but could be nice to avoid this issue alltogether

Duplicate of https://github.com/eamodio/vscode-gitlens/issues/104. Please join the conversation there -- https://github.com/eamodio/vscode-gitlens/issues/104#issuecomment-335574528

Thanks, didn't find that issue when searching


frdm_k64f: tests/subsys/storage/flash_map/storage.flash_map.mpu fails

Describe the bug
The tests/subsys/storage/flash_map/storage.flash_map.mpu failed.
Assertion failed at ./tests/subsys/storage/flash_map/src/main.c:242: flash_map_test_flash_area_erase_and_flatten: (erased is false)
Erase failed at index 1
Tue, 11 Jun 2024 09:52:40 GMT INFO    - frdm_k64f    tests/subsys/storage/flash_map/storage.flash_map.mpu  FAILED Failed (device: xxx, 10.815s)

To Reproduce
scripts/twister -W -p frdm_k64f --device-testing -T tests/subsys/storage/flash_map -v

The following issues were found (showing the top 10 items):
Tue, 11 Jun 2024 09:53:10 GMT INFO    - 1) tests/subsys/storage/flash_map/storage.flash_map.mpu on frdm_k64f failed (Failed)
Tue, 11 Jun 2024 09:53:10 GMT INFO    -
Tue, 11 Jun 2024 09:53:10 GMT INFO    - To rerun the tests, call twister using the following commandline:
Tue, 11 Jun 2024 09:53:10 GMT INFO    - west twister -p <PLATFORM> -s <TEST ID>, for example:
Tue, 11 Jun 2024 09:53:10 GMT INFO    -
Tue, 11 Jun 2024 09:53:10 GMT INFO    - west twister -p frdm_k64f -s tests/subsys/storage/flash_map/storage.flash_map.mpu
Tue, 11 Jun 2024 09:53:10 GMT INFO    - or with west:
Tue, 11 Jun 2024 09:53:10 GMT INFO    - west build -p -b frdm_k64f tests/subsys/storage/flash_map -T storage.flash_map.mpu

Logs and console output
INFO    - frdm_k64f    tests/subsys/storage/flash_map/storage.flash_map.mpu  FAILED Failed (device: xxx, 10.815s)
INFO    - ./twister-out/frdm_k64f/tests/subsys/storage/flash_map/storage.flash_map.mpu/handler.log
ERROR   - ***** delaying boot 500ms (per build configuration) *****
*** Booting Zephyr OS build v3.6.0-5742-g2efc447c1b41 (delayed boot 500ms) ***
Running TESTSUITE flash_map
===================================================================
START - test_fixed_partition_node_macros
PASS - test_fixed_partition_node_macros in 0.001 seconds
===================================================================
START - test_flash_area_check_int_sha256
PASS - test_flash_area_check_int_sha256 in 0.159 seconds
===================================================================
START - test_flash_area_disabled_device
PASS - test_flash_area_disabled_device in 0.001 seconds
===================================================================
START - test_flash_area_erase_and_flatten
Assertion failed at ./tests/subsys/storage/flash_map/src/main.c:242: flash_map_test_flash_area_erase_and_flatten: (erased is false)
Erase failed at index 1
FAIL - test_flash_area_erase_and_flatten in 4.744 seconds
===================================================================
START - test_flash_area_erased_val
PASS - test_flash_area_erased_val in 0.001 seconds
===================================================================
START - test_flash_area_get_sectors
PASS - test_flash_area_get_sectors in 0.904 seconds
===================================================================
TESTSUITE flash_map failed.
------ TESTSUITE SUMMARY START ------
SUITE FAIL -  83.33% [flash_map]: pass = 5, fail = 1, skip = 0, total = 6 duration = 5.810 seconds
- PASS - [flash_map.test_fixed_partition_node_macros] duration = 0.001 seconds
- PASS - [flash_map.test_flash_area_check_int_sha256] duration = 0.159 seconds
- PASS - [flash_map.test_flash_area_disabled_device] duration = 0.001 seconds
- FAIL - [flash_map.test_flash_area_erase_and_flatten] duration = 4.744 seconds
- PASS - [flash_map.test_flash_area_erased_val] duration = 0.001 seconds
- PASS - [flash_map.test_flash_area_get_sectors] duration = 0.904 seconds
------ TESTSUITE SUMMARY END ------
===================================================================
RunID: bf5ab1639defa729ed7ac2c5f1bffb02
PROJECT EXECUTION FAILED

Environment:
OS: Linux
Zephyr version: v3.6.0-5742-g2efc447c1b41
Zephyr SDK version: 0.16.5-1

@dleach02 seems to be my fault, taking over.

The same issue occurred at nrf52840dk/nrf52840 and nrf52dk/nrf52832 (version v3.6.0-5452-gec9f71e23794).
===================================================================
START - test_flash_area_erase_and_flatten
Assertion failed at ../../../../../../../zephyr/tests/subsys/storage/flash_map/src/main.c:242: flash_map_test_flash_area_erase_and_flatten: (erased is false)
Erase failed at index 1
FAIL - test_flash_area_erase_and_flatten in 4.289 seconds
===================================================================


chore: password sanitization

Description

Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

[ ] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR requires documentation updates?
[ ] I've updated documentation as required by this PR.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have tested it for all user roles.
[ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ash-exp @gireesh-devtron This PR is wrongly labelled as chore, it should be labelled fix and the relevant issue should be attached before closing.


pull request for e2e test at 11/11/2016 18:45:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[fix] typo in seq exec

This PR fixed a typo reported by ToB's code review in week 3

it is circuit change. (vk change).  So i will merge it into develop soon, so we can test & release early.

close accoriding to #1332


[d3d11] NieR Replicant ver.1.22474487139... prerendered media fails to play video

When attempting to play a prerendered "movie" file, the screen turns black, no video is played (however audio plays fine) and DXVK logs an error.
The files utilize a proprietary format, but when its 24-byte header is removed we get an ASF container.
$ ffprobe MOVIE_ATRACT_GESTALT.asf
[snip.]
Input #0, asf, from 'MOVIE_ATRACT_GESTALT.asf':
  Metadata:
    major_brand     : mp42
    minor_version   : 0
    compatible_brands: mp42mp41
    encoder         : Lavf58.20.100
  Duration: 00:03:07.09, start: 0.000000, bitrate: 25345 kb/s
    Stream #0:0(eng): Video: wmv2 (WMV2 / 0x32564D57), yuv420p, 1920x1080, 25000 kb/s, 30 fps, 30 tbr, 1k tbn, 1k tbc
    Stream #0:1(eng): Audio: wmav2 (a[1][0][0] / 0x0161), 48000 Hz, 2 channels, fltp, 128 kb/s

The issue can be reliably reproduced by waiting at the "press any button" screen for about 30 seconds, at which point the game will attempt to play (one of?) its trailer(s) (data/movie/MOVIE_ATRACT_{REPLICANT,GESTALT}.arc). According to https://github.com/ValveSoftware/Proton/issues/4777#issuecomment-828716546, this is also an issue when using DXVK on Windows. It's a major progression roadblock as a prerendered cutscene plays at the midpoint of the game.
After a quick search, I was able to find issue https://github.com/doitsujin/dxvk/issues/1676, which seems to be related (in that this is also caused by missing YUV support in the d3d11 implementation).
Software information
Game: NieR Replicant ver.1.22474487139...
Settings do not affect the ability to reproduce this issue.
System information

GPU: Radeon RX 580 8GB
Driver: amdgpu (kernel 5.11.6), RADV, mesa 20.3.4
Wine version: 6.7-GE-1 with a couple patches described in https://github.com/ValveSoftware/Proton/issues/4777#issuecomment-829523695
DXVK version: 1.8.1

Apitrace file(s)
Unfortunately, the game doesn't run under wined3d and I do not have a Windows setup to run apitrace on, not one that has a real GPU attached at least.
Log files

d3d9.log: not applicable
d3d11.log: https://gist.github.com/aurieh/95d00c05d880853c804d14cef5ccac84
dxgi.log: https://gist.github.com/aurieh/fb6b2caad9c85987ac7abd1ed321adbf

Looks like the game requires NV12 support. That's a huge issue since DXVK does not support multiplanar formats at all, and adding it now is going to be extremely hard. It also doesn't help that there is hardly any documentation on how to actually use that format in D3D11 (especially on how uploads and image copies work etc).
Is there a Proton build with the required patches available to test this with? Regular Proton obviously just crashes.
Note that Windows has a different problem since Microsoft's mfplat implementation requires support for D3D11 Video APIs. We cannot support those.

Looks like the game requires NV12 support. That's a huge issue since DXVK does not support multiplanar formats at all, and adding it now is going to be extremely hard. It also doesn't help that there is hardly any documentation on how to actually use that format in D3D11 (especially on how uploads and image copies work etc).
Is there a Proton build with the required patches available to test this with? Regular Proton obviously just crashes.
Note that Windows has a different problem since Microsoft's mfplat implementation requires support for D3D11 Video APIs. We cannot support those.

Check out the build this guy made https://github.com/ValveSoftware/Proton/issues/4777#issuecomment-829859050
He made a proton build with a patch reversed which does not crash NieR while the prerendered cutscenes are playing.

Starting to make some real progress; the videos play on Windows (although it should also work with a Proton build that has the required mfplat patches; even when using NV12 images). I'll push a branch tomorrow or so, but there's still a lot of work (and research) to be done.

Fixed in current master.

Hello, dear @doitsujin and users.
I still have a problem described here regardless of Wine or Proton build/version I use.
My game always crashes after loading screen when finish Act I cutscene should appear. Same problem on "Press any button" title screen.
I tried to use latest versions of Wine and Proton by GloriousEggroll and Tk-Glitch, run game via Lutris and Steam, install to Wine prefix "vcrun2019" and "mf" via Winetricks, add MS Media Foundation libraries via "mf-install" script by z0z0z, but nothing of it helped. And, of course, I am using latest DXVK built-in in Lutris or Proton.
Interesting thing is that when Special K and GShade are disabled game just immediately closes, but when they are enabled video plays just with sound but without any picture (black screen), Special K gives some critical error and nothing happens when cutscene ends (well, sound of cutscene ends, since I see nothing else), it just remaining in black screen stage forever until I stop game manually.
It would be perfect if someone can help me a little and tell me which exactly additional software should be installed in Wine prefix to make video playback in NieR Replicant work. I tried to figure it out myself by searching NieR's ID in "protonfixes" but suddenly my knowledge is still insufficiently for understanding it.
What else I need except "vcrun2019" or "mf" and where I can get it? Thank you for any answers and possible help in advance! :-)

Still works here with an old Proton-GE build (6.10-GE-1 to be precise), but yeah, otherwise it's complaining about a gstreamer plugin missing.


Dark mode theme not applied to select menus

Describe the Bug
All select menus are displayed with a bright background, even though dark mode is enabled.
Steps to Reproduce the Problem

Make sure dark mode is selected.
Go to any page that makes use of select menus.

Expected Result
Select menus should have the correct theme applied.
Actual Result
Select menus are displayed with the wrong background color.
Text is unreadable.

PermaplanT version
current master
Operating System
Linux FREIMWOERK 6.5.0-14-generic #14~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Mon Nov 20 18:15:30 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Browser
Version 120.0.6099.199 (Offizieller Build) snap (64-Bit)
Versions of other relevant software/extensions
No response
Additional info/logs
No response

Thank you for reporting this problem! I can reproduce. This is a regression, on www.permaplant.net this problem does not exist.

@Bushuo is this issue and maybe also #1166 caused by the Tailwind CSS update?


The site icons on the rectangular tabs are shifted to the right.

Describe the bug
The site icons on the rectangular tabs are shifted to the right.
To Reproduce
Steps to reproduce the behavior:

Change the shape of the tabs to rectangular (--rectangular-switch tabs).
Open several tabs with sites.

Expected behavior
Site icons and their names on rectangular tabs should be slightly shifted to the left, closer to the left edge of the tab.
Screenshots

Desktop (please complete the following information):

OS: Windows 8.1 x64.
x64.

Additional context
In my opinion, the distance from the left edge of the rectangular tab to the site icon is too large, and it can be slightly reduced. In addition, the distance from the right edge of the rectangular tab to the close tab button is also too large, and it can also be slightly reduced.

The metrics are indeed based on the other, narrower tab styles. I can definitely adjust them to take better advantage of the extra space.


Feature Request: Ability to post chat channels into Discord

In SCUM we have several chat channels (Global, Team, Lokal & Admin), how about parsing the chat log and output these messages in a discord channel, optionally one discord channel per chat?

lImplemented with Version 1.0.11


TZ add to location pages

Pretty simple submission: I want to allow for addition of timezone info when creating a new Location Page. Defaults to ETC/UTC (Reykjavik I believe uses this one). Allows a user to see open/close status in real time, not based on the browser's localtime.

Hi @Amondale - I'm afraid this PR isn't usable, as the intended changes are mixed in with various unintended ones (for example, you've deleted the Github workflows, and committed your copy of the sqlite database). Please could you retry?


hostname.properties file ignored and overwritten with IP

Hello,
I don't know why but my machine registered on the ArcGIS server is registered with its IP rather than FQDN
https://FQDN:6443/arcgis/admin/machines/<IP_ADDRESS>
And when I try to upload SSL Certificate using "SslCertifcates" property, I received the following error:
"Not able to find machine in site with either hostname $MachineName or fully qualified domain name $FQDN"
Any idea, why was the machine registered with its IP rather than hostname ?
Thanks !

You will find below more details from the VERBOSE log.
But what I find interesting in this log is the following line:
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Using File System Based Storage for the config store
I wonder if the file mentionned is the one located in "framework/etc/" named hostname.properties.
Because this file looks like the following:
#Hostname properties set by AgsStartup plugin.
#Fri Mar 08 13:38:22 CET 2019
hostname=<IP_ADDRESS>
defaultDirectoriesRoot=D:\arcgisserver
So it does have the hostname IP in addition to the wrong defaultDirectoriesRoot path as mentionned by @shailesh91 in https://github.com/Esri/arcgis-powershell-dsc/issues/55
ArcGISConfigure--Verbose.txt
[HOSTNAME]: LCM:  [ Start  Resource ]  [[ArcGIS_WindowsService]ArcGIS_for_Server_Service]
[HOSTNAME]: LCM:  [ Start  Test     ]  [[ArcGIS_WindowsService]ArcGIS_for_Server_Service]
[HOSTNAME]: LCM:  [ End    Test     ]  [[ArcGIS_WindowsService]ArcGIS_for_Server_Service]  in 0.2600 seconds.
[HOSTNAME]: LCM:  [ Start  Set      ]  [[ArcGIS_WindowsService]ArcGIS_for_Server_Service]
[HOSTNAME]:                            [[ArcGIS_WindowsService]ArcGIS_for_Server_Service] [WARNING] Stopping Server :- Cannot validate argument on parameter 'Message'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again.
[HOSTNAME]: LCM:  [ End    Set      ]  [[ArcGIS_WindowsService]ArcGIS_for_Server_Service]  in 1.5930 seconds.
[HOSTNAME]: LCM:  [ End    Resource ]  [[ArcGIS_WindowsService]ArcGIS_for_Server_Service]
[HOSTNAME]: LCM:  [ Start  Resource ]  [[ArcGIS_Service_Account]Server_RunAs_Account]
[HOSTNAME]: LCM:  [ Start  Test     ]  [[ArcGIS_Service_Account]Server_RunAs_Account]
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] RunAsAccount Username:- DOMAIN\username
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Install Dir for ArcGIS Server is C:\Program Files\Arcgis\Server
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Testing Permission for User DOMAIN\username on Directory C:\Program Files\Arcgis\Server
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Permissions are not set for C:\Program Files\Arcgis\Server
[HOSTNAME]: LCM:  [ End    Test     ]  [[ArcGIS_Service_Account]Server_RunAs_Account]  in 0.2200 seconds.
[HOSTNAME]: LCM:  [ Start  Set      ]  [[ArcGIS_Service_Account]Server_RunAs_Account]
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] RunAsAccount Username:- DOMAIN\username
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Install Dir for ArcGIS Server is C:\Program Files\Arcgis\Server
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Testing Permission for User DOMAIN\username on Directory C:\Program Files\Arcgis\Server
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Providing RunAs Account 'DOMAIN\username' has the required permissions to C:\Program Files\Arcgis\Server
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] icacls.exe C:\Program Files\Arcgis\Server /grant DOMAIN\username:(OI)(CI)F
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Restarting Service ArcGIS Server
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Stopping the service
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Stopped the service
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Starting the service
[HOSTNAME]:                            [[ArcGIS_Service_Account]Server_RunAs_Account] Restarted Service ArcGIS Server
[HOSTNAME]: LCM:  [ End    Set      ]  [[ArcGIS_Service_Account]Server_RunAs_Account]  in 21.6220 seconds.
[HOSTNAME]: LCM:  [ End    Resource ]  [[ArcGIS_Service_Account]Server_RunAs_Account]
[HOSTNAME]: LCM:  [ Start  Resource ]  [[ArcGIS_Server]ServerHOSTNAME]
[HOSTNAME]: LCM:  [ Start  Test     ]  [[ArcGIS_Server]ServerHOSTNAME]
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Fully Qualified Domain Name :- FQDN
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Checking for site on 'http://FQDN:6080'
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Unable to detect if Site Exists. Was NOT able to retrieve token for PSA
[HOSTNAME]: LCM:  [ End    Test     ]  [[ArcGIS_Server]ServerHOSTNAME]  in 66.9770 seconds.
[HOSTNAME]: LCM:  [ Start  Set      ]  [[ArcGIS_Server]ServerHOSTNAME]
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Site Administrator UserName:- siteadmin
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Fully Qualified Domain Name :- FQDN
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Waiting for Server 'http://FQDN:6080/arcgis/admin' to initialize
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Configured Host Name  is not equal to FQDN. Setting it
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Version of ArcGIS Server is 10.6.9270
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Version of ArcGIS Server does not require removal of EC2 Listener from NodeAgent xml file
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Restarting Service ArcGIS Server
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Stopping the service
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Stopped the service
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Starting the service
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Restarted Service ArcGIS Server
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Waiting for Server 'http://FQDN:6080/arcgis/admin' to initialize
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Checking for site on 'http://FQDN:6080'
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Creating Site
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Using File System Based Storage for the config store
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Waiting for Server 'http://FQDN:6080/arcgis/admin' to initialize
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] POST http://FQDN:6080/arcgis/admin/createNewSite with -1-byte payload
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] received 20-byte response of content type application/json;charset=UTF-8
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Response from CreateSite:-
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Created Site
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Waiting for Server 'http://FQDN:6080/arcgis/admin' to initialize
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Get Single Cluster Mode Setting
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] POST http://FQDN:6080/arcgis/admin/system/deployment/ with 77-byte payload
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] received 26-byte response of content type application/json;charset=UTF-8
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] {"singleClusterMode":true}
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Current Single Cluster Mode @{singleClusterMode=True}
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Waiting for Server 'http://FQDN:6080/arcgis/admin' to initialize
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Ensuring Log Level WARNING
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] POST http://FQDN:6080/arcgis/admin/logs/settings with 77-byte payload
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] received 280-byte response of content type application/json;charset=UTF-8
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Response from Create Site:- @{settings=}
[HOSTNAME]:                            [[ArcGIS_Server]ServerHOSTNAME] Current Log Level:- WARNING
[HOSTNAME]: LCM:  [ End    Set      ]  [[ArcGIS_Server]ServerHOSTNAME]  in 167.2660 seconds.
[HOSTNAME]: LCM:  [ End    Resource ]  [[ArcGIS_Server]ServerHOSTNAME]

As a workaround, for now, @Biboba you might want to clear that file (framework/etc/hostname.properties.)  out. And try rerunning the Configure-ArcGIS command.
PS. These are the default values that are already present in amazon ami that Esri provides that you are encountering.

@shailesh91 Thanks for the reply. Will try that.
Any thought about that one:
[HOSTNAME]: [[ArcGIS_WindowsService]ArcGIS_for_Server_Service] [WARNING] Stopping Server :- Cannot validate argument on parameter 'Message'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again.
Thanks

@Biboba I am cannot repro this issue on my environment. Will need more info to repro this.

@shailesh91
Deleting the file "hostname.properties" and rerunning Configure-ArcGIS does not work. It get stuck for ever at testing "ArcGIS_Server".
Indeed, after restarting the ArcGIS Server, I cannot connect to it myself.
Having a look at the ArcGIS Server log:
Failed to update the data store with updated list of server machines. {0} Server machine 'https://FQDN:2443/arcgis/datastoreadmin/updateServerMachines' returned an error. 'Invalid Token.'
ArcGIS Server has detected that the server machine name '<IP_ADDRESS>' has been changed to 'FQDN'. ArcGIS Server will be updated automatically to use the new host name. If you have enabled SSL and your certificate was using the previous machine name, you must generate a new SSL certificate and configure your ArcGIS Server site to use it. If you had configured the ArcGIS Web Adaptor to use your previous machine name, you will need to reconfigure it with a new URL that uses the updated machine name.
I tried several times and it is systematic. In fact the issue is more general and problematic and the SSL certificate was only a consequence. Do you have any workaround ? Do you know with hostname.properties is set to the IP instead of the hostname ?
Thanks for your help

@Biboba
Perhaps the instance has more than one Network Interface Controller card (NIC) or DNS record. This could be why Portal/Server/DS is binding to the IP instead of FQDN.
The hostname.properties file may need to be modified to point to the FQDN for Portal/Server/DS respectively:
AGS
Portal
DS

Hello @cameronkroeker,
Thanks for your reply.
I don't think that there is more that one NIC:
netsh interface show interface
returns only one interface for Ethernet.
I tried a deployment of ArcGIS Enterprise on a single host and I don't have this problem with Portal for ArcGIS or with the datastore. The machine name is configured to FQDN for them.
Also, the script is already setting the hostname property to FQDN in "Set-ConfiguredHostName":
https://github.com/Esri/arcgis-powershell-dsc/blob/11e0364c92e3cfdb31270d415accabef4a71ce74/Modules/ArcGIS/DSCResources/ArcGIS_Server/ArcGIS_Server.psm1#L153-L160
But then after restarting the ArcGIS Server service, the file is overwritten to its IP...
Finally, when I install and configure manually the ArcGIS server on this machine, I don't have this problem. After running the setup, the file "hostname.properties" does not exist and after initializing the site with HTML interface, the ArcGIS Site machine is properly configured with its FQDN.
If I restart it, "hostname.properties" is not created and arcgis server machine is still set to FQDN.
Do you have any idea ? I am under the impression (not tested yet), that if I remove the "Set-ConfiguredHostName" from the configuration, I would not face this issue.
Thanks for your help !

So I confirm that if I comment out the following section:
https://github.com/Esri/arcgis-powershell-dsc/blob/11e0364c92e3cfdb31270d415accabef4a71ce74/Modules/ArcGIS/DSCResources/ArcGIS_Server/ArcGIS_Server.psm1#L156-L159
Everything works as expected and the ArcGIS Server is properly configured with FQDN and does not switch to IP when restarted. Basically "hostname.properties" is never created.
It is funny because both Portal for ArcGIS and dataStore have a similar file ("hostname.properties" for Portal for ArcGIS and "hostidentifier.properties" for dataStore) created by DSC and they are not changed to IP adress when restarting the services. It is only with the ArcGIS Server that this phenoma occurs systematically.
I precise that at the moment it is an ArcGIS Enterprise deployment on one machine.
Any idea why does this issue occur ?
Thanks

To put it in a nutshell, I believe the question is why is the hostname.properties file overwritten by the "AgsStartup plugin" of the ArcGIS Server ?

This is an EC2Observer node agent plugin that tries to account for hostname changes in AWS EC2.
This may be what is happening here.

Thanks for the reply @nshampur.
FYI, my VM is hosted in Openstack and I don't know if it can help but in the log of ArcGIS Configure there is:
"Version of ArcGIS Server does not require removal of EC2 Listener from NodeAgent xml file"

@cameronkroeker, do you think a bug for the ArcGIS Server product should be opened ? It looks to me more about the ArcGIS Server than arcgis-powershell-dc ?
Thanks

Hello @Biboba,
I recommend opening an Esri Technical Support case, so that they can help investigate the issue further.
Thanks,
Cameron

Hello @cameronkroeker,
I finally had some time to come back to this issue and try to reproduce it without using 'arcgis-powershell-dsc' library.
So let say my machine name is "foo" and have the alias "bar": it has thus several DNS entries.
After manually installing ArcGIS Server 10.7.1, I create the hostname.properties file and add the following entry:
hostname=bar.company.com

I restart the ArcGIS Server service and then the hostname.properties file has been overwritten by ArcGIS Server and looks like this:
#Hostname properties set by AgsStartup plugin.
#Wed Aug 21 11:07:22 CEST 2019
hostname=<IP_ADDRESS>

Just to let you know that I just opened a ticket with the support and I will let you know the outcome.
Thanks

what does a DNS lookup for bar.company.com  look like
using nslookup
or PowerShell's Resolve-DnsName

nslookup bar.company.com

Server:  ip-dns-2.ipv6.company.com
Address:  1001:1358:101:1100::5

Name:    foo.company.com
Address:  <IP_ADDRESS>
Aliases:  bar.company.com

But FYI, if I remove the alias "bar" and just create a hostname.properties with the following entry:
hostname=foo.company.com
the file is overwritten anyway:
#Hostname properties set by AgsStartup plugin.
#Thu Aug 22 10:21:12 CEST 2019
hostname=<IP_ADDRESS>

DNS lookup returns the following in this case:
nslookup bar.company.com
Server:  ip-dns-2.ipv6.company.com
Address:  1001:1358:101:1100::5

Name:    foo.company.com
Address:  <IP_ADDRESS>

Support made me remove NodeAgentExt.xml file and now it does work properly:
the file is not overwritten.
"Since Openstack is operating as a private cloud, we assume the plugin is treating the machine as it would an EC2 instance in AWS".

FYI, a bug has been logged regarding this issue:
BUG-000124901 - "When deploying ArcGIS Enterprise to a Private Cloud, the AgsStartupPlugin treats the VM as an EC2 instance"
I am closing this issue as it is not related to arcgis-powershell-dsc.
Thanks for your help

@cameronkroeker I'm hitting similar issue related to IP address being used instead of FQDN on generic EC2 Windows 2016 box with 10.6.1. Is there any flags or configuration to get around this?  I plan to test the work around the commenter mentioned with commenting out code, but was hoping for a cleaner approach if one exists.

@cameronkroeker I'm hitting similar issue related to IP address being used instead of FQDN on generic EC2 Windows 2016 box with 10.6.1. Is there any flags or configuration to get around this? I plan to test the work around the commenter mentioned with commenting out code, but was hoping for a cleaner approach if one exists.

@mkarikari if this is an Esri/ArcGIS AMI then perhaps try removing the arcgis_cloud_platform environment variable.

Actually this isnt a ESRI ami, its an instance based on regular windows '16 image

Actually this isnt a ESRI ami, its an instance based on regular windows '16 image

Thanks for confirming @mkarikari. The only workaround I am aware of is to comment out the AgsStartupPlugin from the NodeAgentExt.xml file.

Thanks @cameronkroeker, where is the nodeagentext.xml file located at?

Thanks @cameronkroeker, where is the nodeagentext.xml file located at?

@mkarikari
By default its in C:\Program Files\ArcGIS\Server\framework\etc

@cameronkroeker
Ah I see. Based on that though, changing that file only make since to change if run in Install or InstallLicense mode then. If you run InstallLicenseConfigure, updating wouldn't scale when deploying to multiple systems since setting up the site is part of the process. I will move forward with just commenting out that code section within the .ps1 file like Biboba originally mentioned

@mkarikari,
FYI, do not forget to comment out the same part in ArcGIS_ServerUpgrade DSC resource otherwise the restore of webgisdr will fail !
cf. https://community.esri.com/t5/high-availability-and-disaster-recovery-questions/arcgis-enterprise-11-0-webgisdr-restore-fails/m-p/1204062#M562


people can impersonate others using the chat relay system

horrible
pls

it was mcd confirmed

Spooky ghosts in Ca$h

2spooky


bazel dependency diamond problem and bind

I came across this problem with zlib, but there's no good reason why it wouldn't also be a problem with gRPC's other bazel dependencies.
As discussed here, bazel's native.bind function can be a real pain and is officially not recommended, yet gRPC's grpc_deps function uses it extensively.
Case in point: my bazel repository has both first-party rules and multiple third-party repositories that all depend on zlib. If they're not all pointing at the same zlib, that's a recipe for awful ODR errors. So, I declare my own zlib dependency in the @net_zlib_zlib external repository (a common choice of name). When I import protobuf and grpc repositories, I can use repo_mapping to point their choice of @zlib to my choice of @net_zlib_zlib:
http_archive(
    name = "com_google_protobuf",
    repo_mapping = {"@zlib": "@net_zlib_zlib"},
    ...
)

http_archive(
    name = "com_github_grpc_grpc",
    repo_mapping = {"@zlib": "@net_zlib_zlib"},
    ...
)

so far so good.
However, when I then call grpc_deps in my WORKSPACE file, that causes my WORKSPACE file to call native.bind a bunch of times (:disappointed:), including https://github.com/grpc/grpc/blob/v1.22.0/bazel/grpc_deps.bzl#L34
native.bind(
    name = "madler_zlib",
    actual = "@zlib//:zlib",
)

which doesn't work. @zlib doesn't exist and repo_mapping can't fix it because this function is called from my WORKSPACE file.
My current workaround hack involves preceding the call to grpc_deps with
bind(
    name = "zlib",
    actual = "@net_zlib_zlib//:zlib",
)

and following it with
bind(
    name = "madler_zlib",
    actual = "@net_zlib_zlib//:zlib",
)

two uses of bind which I don't want in my codebase but allow me to trick gRPC into doing the right thing and solving my ODR problems.
I don't see why you can't just avoid using native.bind at all. Protobuf doesn't, it just depends on @zlib//:zlib directly (allowing repo_mapping to remap this nicely).
What version of gRPC and what language are you using?
1.22.0, C++
What operating system (Linux, Windows,...) and version?
Ubuntu 18.04

CC @gnossen

Is there any planned fix to this?

I believe the main limitation here was the range of bazel versions that gRPC supports. We supported 3.x until recently, so a handful of bazel features, including repo_mapping, were not available to us. We now only support bazel 4.x and above (see https://github.com/grpc/grpc/blob/master/doc/bazel_support.md), so this might be feasible.
Reassigning to @veblush

Hmm I wasn't able of this bind issue and it's interesting to know that using bind is discouraged. I think removing bind is a good improvement project but we need to change gRPC build system not to rely on bind heavily. This was because of two reasons; i) to deal with different dependencies in Google3 (but this could be addressed by dependency translation during the import process) and ii) to fix the project generation issue which doesn't allow @ character in the dependency  list. (which might be able to be fixed easily)
Note that we don't have plan to work on this for now so I'm going to add this label for "help needed"

bind is not only deprecated but also unsupported in bzlmod. Would be great if we could get rid of them.

One could build on top of the downstream bzlmod patch: https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/grpc/1.48.1.bcr.1/patches/adopt_bzlmod.patch

I gave it a shot at #35272.

I've ran into similar issue - where grpc (v1.54.3) would pull it's own madle_zlib as @zlib, and I had bazel_dep(name = "zlib", version = "1.3") - tried multiple things (realizing bind does not work, and coming here), and found using repo_mapping to solve it for me:
    maybe(
        http_archive,
        name = "com_github_grpc_grpc",
        sha256 = "17e4e1b100657b88027721220cbfb694d86c4b807e9257eaf2fb2d273b41b1b1",
        strip_prefix = "grpc-1.54.3",
        urls = [
            "https://github.com/grpc/grpc/archive/v1.54.3.tar.gz",
        ],
        repo_mapping = {
            "@zlib": <EMAIL_ADDRESS>        }
    )


Chrome makes two requests for each image

I'm not sure how to duplicate this. When I viewed the lazy load examples in Chrome, everything was working correctly. When I viewed the examples on the lazy load documentation site, everything worked correctly.
But for some reason, in my particular environment, Chrome was making two requests for each image lazy loaded. I am using Zurb Foundation as a base for my toolkit, and I wanted to add the lazy load plugin to our assets. In my demonstration page, I consistently duplicated this problem even though I followed the most basic example correctly.
Looking through the code, I finally changed this block
$("<img />")
    .bind("load", function() {
        var original = $self.data(settings.data_attribute);
        $self.hide();
        if ($self.is("img")) {
            $self.attr("src", original);
        } else {
            $self.css("background-image", "url('" + original + "')");
        }
        $self[settings.effect](settings.effect_speed);

        self.loaded = true;

        /* Remove image from array so it is not looped next time. */
        var temp = $.grep(elements, function(element) {
            return !element.loaded;
        });
        elements = $(temp);

        if (settings.load) {
            var elements_left = elements.length;
            settings.load.call(self, elements_left, settings);
        }
    })
    .attr("src", $self.data(settings.data_attribute));

to this
$("<img />")
    .bind("load", function() {
        var original = $self.data(settings.data_attribute);
        $self.hide();
        if ($self.is("img")) {
            $self.attr("src", original);
        } else {
            $self.css("background-image", "url('" + original + "')");
        }
        $self[settings.effect](settings.effect_speed);

        self.loaded = true;

        /* Remove image from array so it is not looped next time. */
        var temp = $.grep(elements, function(element) {
            return !element.loaded;
        });
        elements = $(temp);

        if (settings.load) {
            var elements_left = elements.length;
            settings.load.call(self, elements_left, settings);
        }
    }).load();

It seemed like calling the load() function after it was bound was a better solution than modifying the src attribute a second time. Load() already does that and it keeps track of which images are already loaded.
Everything seems to work the same, but I wanted to mention my issue here to make sure I'm not just missing something. Thanks.

I have exactly the same thing using chrome Version 51.0.2704.63 (64-bit). It says it makes one request in the Network tab but I actually get two requests with slightly different headers.


HTML

#HTML
##USER STORY
As a boot camp student,
I want prework notes to be structured on a webpage,
so that I can easily find and read information.
##ACCPETANCE CRITERIA
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

HTML has been added to criteria


Python function signture does not work!

I really liked kickstart and I am trying to migrate from LazyVim but things did not work 100% for Python Auto completion.
I simply enabled the pyright language server as follow
pyright ={}

Python auto-completion worked just fine except for function signatures. No information about arguments. The same nvim on the same machine (Debian 12) with LazyVim, function signatures and arguments details worked as expected. I wonder if I am missing something here.
Regards,

Hi, LazyVim uses noice.nvim to trigger signature help automatically, I believe. Kickstart does not use it. You can either add the plugin or add a keymap to trigger it.

Thank you @nhld
Anyone knows how to trigger it? If I were to install noice.nvim, I might as well stay with LazyVim. Without function signature, a code completion feature is 50% ready
Thanks!

Add this keymap:
vim.keymap.set('i', '<C-k>', vim.lsp.buf.signature_help, { buffer = event.buf, desc = 'Signature Documentation' })

This is where you should put it:
   vim.api.nvim_create_autocmd('LspAttach', {
        group = vim.api.nvim_create_augroup('kickstart-lsp-attach', { clear = true }),
        callback = function(event)

          vim.keymap.set('i', '<C-k>', vim.lsp.buf.signature_help, { buffer = event.buf, desc = 'Signature Documentation' })

          -- NOTE: Remember that lua is a real programming language, and as such it is possible
          -- to define small helper and utility functions so you don't have to repeat yourself
          -- many times.
          --
          -- In this case, we create a function that lets us more easily define mappings specific
          -- for LSP related items. It sets the mode, buffer and description for us each time.

          local map = function(keys, func, desc)
            vim.keymap.set('n', keys, func, { buffer = event.buf, desc = 'LSP: ' .. desc })
          end

<C-k> will show the signature doc in insert mode.

Thank you so much @nhld It worked but apparently to keep it floating while typing the arguments takes some work especially when highlighting the active argument only


No available courses on find courses

Description
OSPR-2285
This PR show the message No available courses on the Find courses section when there are no available courses.

Reviewers

[ ] Code review: @saeedbashir
[ ] Code review: @salman2013

cc @marcotuts @nedbat

Thanks for the pull request, @jagonzalr! I've created OSPR-2285 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
If you like, you can add yourself to the AUTHORS      file for this repo, though that isn't required.     Please see the CONTRIBUTING     file for more information.

(BTW, there's no need to ping me directly on these pull requests :)  )

@edx/ios-devs please take a look.

Hi! One thing to flag here is that we should emulate our empty pattern from when courses are empty or when there are no videos in a course if possible for this empty view.

@marcotuts I updated the PR to follow the empty pattern. You can see the updated image on the description.

@jagonzalr BTW, no need to ping me on pull requests :)  I'll see them!

Thanks for the update!
Moving into our next scheduled sprint for review.

@jagonzalr Can you share a sandbox link where I can test these changes?

@saeedbashir what is your email address. I can invite you to Testflight

for testflight it's<EMAIL_ADDRESS>

@saeedbashir you should have access now


UPDATE(BMP-508): updated custom-plugin-lib to version 2.0.1

Updated custom-plugin-lib dependency to 2.0.1.
Checklist
BMP-508

[ ] tests are included
[ ] the documentation is updated or integrated accordingly with your changes
[ ] the changelog has been updated accordingly with your changes
[X] you are not committing extraneous files or sensible data
[X] added the link to the Jira task
[X] commit message and branch name conventions

Already updated by dependabot in #52


[ios]fix maxlength issues

Brief Description of the PR
maxlength=5, but set the default value to 12 lengths. Before the 5th character, pasting 10 characters directly will result in
As a result, the length of leftLength=17 is larger than the position of the cursor and larger than maxleng, and the extra characters need to be filtered.
Checklist

Demo:
Documentation:

逻辑上看OK的，麻烦修改下注释，CI会有中文卡口

逻辑上看OK的，麻烦修改下注释，CI会有中文卡口

已修改


More information on the not supported scenarios for the connector

As it is currently stated under Known Issues:
"The "Workday to Azure AD" connector is not currently supported on Azure AD tenants where AAD Connect is enabled."
I would like to know more about this behavior, its roots and waht workarounds can we use for our customers. I am currently working with a customer that intends on making use of AADP SaaS integration for Workday, and we may require to set this up for them.
Anything helps. Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 799c371a-a17e-08aa-ef56-86eef2395f7e
Version Independent ID: 1339cc93-712c-3a32-8321-dfd016a50ed4
Content: Tutorial: Configure Workday for automatic user provisioning with Azure Active Directory
Content Source: articles/active-directory/saas-apps/workday-inbound-tutorial.md
Service: active-directory
GitHub Login: @cmmdesai
Microsoft Alias: chmutali

@ermacia91 Thanks for your feedback! We will investigate and update soon on it.

@ermacia91 have assigned the issue to the content author to investigate and update as appropriate.

@ermacia91 Thank you for your feedback. Here is a quick explanation of why "Workday to Azure AD" connector is not supported with AADConnect. When Azure AD is used in hybrid mode (where it contains a mix of cloud + on-premises users), it's very important to have a clear definition of "source of authority". Typically hybrid scenarios require deployment of AAD Connect. When AADConnect is deployed, on-premises AD is the source of authority. Introducing the Workday to Azure AD connector into the mix can lead to a situation where Workday attribute values could potentially overwrite the values set by AAD Connect. Hence use of "Workday to Azure AD" connector is not supported when AAD Connect is enabled. In such situations, we recommend using "Workday to AD" connector for getting users into on-premises AD and then syncing them into Azure AD using AAD Connect.

Your explanation is very clear. I didn't expect it to be so simple to understand. Now that I think of it on a SOA context, it makes a lot of sense. Awesome!
Do you think this can be added to the current content in the article, for future reference for other customers?

Thank you for the feedback. I'll update the document with this information. #please-close.


Improvements to e2e matmul tests

Test f16 on CPU, not just on GPU.
Test bf16
Test many SIMD variants that we now have dedicated ukernel code paths for. These code paths were so far tested only in isolated unit tests, not in integration.
Rationalize/reorganize the collection of e2e matmul tests:

Drop no longer relevant cases.
Rename: mmt4d -> dt (for data-tiling), direct -> nondt, etc.  The nondt tests explicitly disable data-tiling, so they will continue testing that through the merging of #15215.
Group by target backend.

whaaaa... ok, let's roll that back.

Root cause: https://github.com/openxla/iree/issues/15258


DropDown does not dismiss when clicked outside

I noticed a problem in iOS 14. Does not work dismissing DropDown when pressed outside. When setting dropDown.dismissMode = .onTap, the dismissableView is displayed correctly, but does not respond to clicks.
On iOS <= 13.5 everything works as expected. How can this problem be corrected?

I noticed that dismissableViewTapped is triggered only when clicking on the tableViewContainer but when clicking on the dismissableView, nothing happens. In iOS 13.5, the opposite is true!

After updating iOS to 14.1 this problem disappeared!


feat(ApolloQueryObservable): expose it in the index module

@Urigo forgot about that :cry: but it is not urgent and we can wait to release it


directory name guide/english/linux/create-file-with-sepcific-size

replaced with guide/english/linux/create-file-with-specific-size

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thanks for the PR @jpatidar8740, but this has been fixed with a previous merge. We welcome future PR's from you. Thanks and happy coding!


Publish ASP.NET Core 5.0 APIs

In addition to the ASP.NET Core APIs, the cross-cutting Microsoft.Extensions.* APIs should be published.

This was completed the day of the GA product release.


Open editor doesn't work

https://github.com/user-attachments/assets/d0ad2fa1-faec-41be-85b8-ad68b6b23614

@bjsi -Kindly look into this . Along with this please fix the bug of half pdf being shown as seen in the attached recoding.

The half pdf is sort of highlighted here: https://github.com/bjsi/incremental-everything/issues/64


Define strategy of versioning

How to automatically update version?
How to bump major/minor etc.
One option is using the tag

I have a set of Gradle tasks: prepareRelease[Major|Minor|Patch]. They increment the appropriate part of the version stored in a Kotlin file in buildSrc. They also need to set lower parts of version to 0.
Increment minor from 0.1.2 goes to 0.2.0 for example.
To perform a release, I then have a Gradle task which uses the version in that file to create a Git tag. CI has a workflow that is triggered by Git tag and does a release to Google Play internal channel.
The release workflow uses Gradle tasks inside the project to do each part, so that if I really needed to (issues with CI) I would do all the release locally (provided I put the secrets where they needed to be).
My release workflow also does other things that are needed such as creating Jira release, adding that to all the tickets contained in the release, marking it as released, then posting all the Jira task names and IDs as release notes message to a Slack channel.
I found it very interesting putting it all together! Will happily show you what I have sometime, if you are interested.

Yes I'm definitely interested! Thanks a lot for the notes :)
I tried to think about the requirements I have:

Complete release to Google Play and all other things like Jira should happen by executing single task - publishRelease
It should be executable both from local environment and CI, also needs to be able to trigger manually on CI
It should be clear in git which version a commit points to.
Possibly 100% of all logic in Gradle
The only manual action should be promoting to Beta and staged rollout. - These could be automated as well.
As trivial strategy as possible.

One thing related to 3. is if the CI needs to modify anything in VCS or not? Because I was thinking about variants on how to avoid this.
The thing is where this version number should be - one options is the version number in file as you mention, other one we used in the past is having the latest git tag as this reference and push the next tag based on this. We can discuss that as well :)

Will try this with GitHub actions :)

This is exactly what I do right now for GetBusy.
On Thu, 18 Mar 2021 at 22:56, Josef Raska @.***> wrote:

[image: Automatic release]
https://user-images.githubusercontent.com/6277721/111708033-66939100-8845-11eb-8643-439ff47d05ba.png
Will try this with GitHub actions :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jraska/github-client/issues/236#issuecomment-802366339,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACWLLEYKU5SINEMLTQPFNHTTEKAI3ANCNFSM4NA7BDHQ
.

@lordcodes do you use Milestones or can't we somehow provide backward reference into each PR to release directly? The Milestone feels like a patch of this not being possible :)

We use Jira so all done on there for now.
On Thu, 18 Mar 2021 at 23:15, Josef Raska @.***> wrote:

@lordcodes https://github.com/lordcodes do you use Milestones or can't
we somehow provide backward reference into each PR to release directly? The
Milestone feels like a patch of this not being possible :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jraska/github-client/issues/236#issuecomment-802375787,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACWLLE3BOFDACP6GTGGHFOLTEKCPTANCNFSM4NA7BDHQ
.

Ah ok :) thanks

Resolved by #445
Example release: https://github.com/jraska/github-client/releases/tag/0.24.0

Version is bumped for following release: example automatic commit: https://github.com/jraska/github-client/commit/88c0d9a7240be6dab8646d14a9ffa13682e07ae6


Github Workflow doesn't work as expected.

Describe the bug
Publish test result in p/r trigger crashes
To Reproduce
Create a p/r, watch the test result publisher not work.
Tests work as expected, and resultfile is found.
Expected behavior
The tests should pass so we can merge stuff.

You could try to add continue-on-error to the publishh step in the workflow in your branch. This should allow the jobs to complete even if it fails to publish the result.
    - name: Publish test results
      uses: EnricoMi/publish-unit-test-result-action/composite@v1
      continue-on-error: true
      with:
        files: testResults.xml


Interoperability with servo URL?

When writing a library that needs to abstract over URLs I've ran into the problem that the Rust ecosystem has two incompatible URL types: http::Uri and url::Url.
Unfortunately the API choices both crates have made make them incompatible:

Url has .as_str(), because it stores the full URL as a string and uses integer offsets to mark start/end of scheme, authority, etc.

Uri exposes Scheme, Authority and PathAndQuery as separate objects, which don't have a lifetime attached.

To be honest, Servo's implementation seems better to me. It simply stores the entire URL with just one heap allocation, instead of up to three. It can use 32-bit offsets instead of usize length + vtable + atomicptr for each part (Bytes). And it's very convenient to have as_str().
I think Uri could switch to that design if it added lifetimes on Scheme<'_>/Authority<'_>/PathAndQuery<'_>, so these could work similarly to Cow<'static, str> and either own their string or borrow from their parent Uri's single allocation.
With a bit of unsafety, I think this might even be done without breaking API changes by hiding the lifetime. Since Uri exposes only shared/immutable references to these objects, they won't outlive their owning Uri anyway.
Once Uri has .as_str(), Servo's URL could switch to being just a wrapper around the Uri, with Deref and From operations for Uri at zero cost, nicely unifying the types.
What do you think?

Servo's implementation seems better to me. It simply stores the entire URL with just one heap allocation, instead of up to three.

The difference in implementation was carefully chosen. The reason http::Uri has 3 different pieces is because in HTTP2, it comes in 3 separate headers (:scheme, :authority, and :path), which means that in order to create a single contiguous string, we'd need to allocate a new String and copy (and :authority and especially :path can be quite long).
As for the HTTP1 case, where it is received in a single contiguous block, the usage of Bytes internally means it doesn't actually need to make 3 different allocations, but instead is just 3 ref-counted slices to the same buffer.


SNS message parsing broken

The Message parsing relies on the parameter SigningCertURL: https://github.com/aws/aws-sdk-net/blob/e538f4d492fdd2980d2b907aa7b870e8d333d4a6/sdk/src/Services/SimpleNotificationService/Custom/Util/Message.cs#L73
However, actual SNS messages provide it as SigningCertUrl (notice the casing difference).
This makes the instantiation always fail with legitimate messages, and since ParseMessage is the only public way to set these fields the current implementation is practically unusable.
We fixed it by making our own copy of this file and  replacing the JSON parsing with Newtonsoft.Json:
        public static Message ParseMessage(string messageText)
        {
            var message = new Message();

            var settings = new JsonSerializerSettings { DateParseHandling = DateParseHandling.None };
            JObject json = (JObject)JsonConvert.DeserializeObject(messageText, settings);

            Func<string, string> extractField = ((fieldName) =>
                {
                    var val = json.GetValue(fieldName, StringComparison.OrdinalIgnoreCase)?.Value<string>();
                    if (string.IsNullOrEmpty(val)) {
                        return null;
                    }
                    return val;
                });

I would make a PR, but I assume there is a reason why these libs aren't using Newtonsoft.Json (more common in the community) in the first place?

@klaytaybai What discrepancies are you talking about specifically? AFAIK LAambda/SNS is a pretty standard pattern to use in chains and pipelines.
If there is anything blocking this, I would suggest deprecating or even  removing the class altogether as a broken implementation can be worse than none at all.

This blog post about invoking Lambda functions with SNS subscriptions indicates that the format it uses is "SigningCertUrl".  Everywhere else that I am aware of uses the standard "SigningCertURL."  If you have a different use case where you are seeing this difference, that would be important to know.
I'd like to add a disclaimer: My claim about likely not being able to change the Lambda subscriptions is mostly my opinion based on similar conversations I have heard.  I don't have much say in the decision regarding deprecations like that.  Also, the context I was using was a change in the service, not in the SDK.  That was a poor judgement on my part to not clearly define the context of my thoughts there.
I'll label this as a bug in the SDK because we are not accounting for both spellings.  We should be able to patch it up pretty easily.  Thanks for bringing it to our attention.

If you have a different use case where you are seeing this difference, that would be important to know.

I have a Lambda that uses SNS messages as a trigger. Messages I was receiving on SNS uses SigningCertUrl. Even if SDKs are inconsistent, I argue that an AWS SDK should be able to handle messages originating from the AWS API - if documentation and implementation have incongruities I'd argue for supporting both versions. What is the use case to have a function for parsing SNS messages if it can't parse messages originating from SNS?

There is a discrepancy between what SNS sends back to clients and what it sends to Lambda function:
https://docs.aws.amazon.com/sns/latest/dg/json-formats.html#http-notification-json
https://docs.aws.amazon.com/lambda/latest/dg/eventsources.html#eventsources-sns
Are you by any chance using our Lambda libraries or rolling your own unarmshalling logic?


Renaming Suggestion of Method Names to Make Them More Descriptive

Renaming Suggestion of Method Names to Make Them More Descriptive

Description
We have developed a tool (NameSpotter) for identifying non-descriptive method names, and using this tool we find a non-descriptive method name in your repository:
/* Non-descriptive Method Name in modality-ecommerce/modality-ecommerce-frontoffice-activities-payment/src/main/java/one/modality/ecommerce/frontoffice/activities/payment/PaymentActivity.java */

private static String digits(String s, int n, boolean right) {
        s = "" + s;
        while (s.length() < n)
            s = right ? s + '0' : '0' + s;
        return s.substring(s.length() - n);
    }

We considered "digits" as non-descriptive because it is too generic and lacks a verb indicating the action of this method. We proposed renaming the method name to "formatDigits". Consequently, when we look at this method name, we will be informed that it is a method written for formating the digits of numbers.
Do you agree with the judgment?

If not, could you please leave your valuable opinion?

If you do agree, the relevant modification has been submitted as a PR, and thanks for your precious time to consider it.

Spam


Would you like to check one more lockfree mpmc queue?

The  https://github.com/erez-strauss/lockfree_mpmc_queue/  is fast atomic lockfree mpmc queue.
The diff file:
add_es_lockfree_mpmc_queue_20191123.diff.zip
Please let me know if you would like to have it included in the benchmarks.

Thanks for your interest.
The other queues are in the benchmark because they are well known queues I would like to compare the performance of my queues against.
I am not interested in benchmarking any available queue on GitHub, I am sorry.

what about queues in the folly lib? It's been the most efficient one iirc.

what about queues in the folly lib?

Submit a pull request, I will have a look.

It's been the most efficient one iirc.

I would like to see that benchmark.


Bug | Broken Links in Documentacion

What?
Found some Broken Links (error 404) for the Binbash Leverage Reference Documentation.
Where?
URL: https://leverage.binbash.com.ar/first-steps/introduction/
The following links were broken:

BROKEN: link https://leverage.binbash.com.ar/first-steps/how-it-works/

URL: https://leverage.binbash.com.ar/first-steps/aws-account-setup/
The following links were broken:

BROKEN: link https://leverage.binbash.com.ar/first-steps/user-guide/organization/organization-init#user-guide

URL: https://leverage.binbash.com.ar/first-steps/leverage-project-setup/
The following links were broken:

BROKEN: link https://leverage.binbash.com.ar/first-steps/user-guide/base-workflow/leverage-cli/reference/project#init

BROKEN: link https://leverage.binbash.com.ar/first-steps/user-guide/base-workflow/leverage-cli/reference/credentials#create

BROKEN: link https://leverage.binbash.com.ar/first-steps/user-guide/base-workflow/leverage-cli/reference/project#create

URL: https://leverage.binbash.com.ar/first-steps/management-account/
The following links were broken:

BROKEN: link https://leverage.binbash.com.ar/first-steps/user-guide/base-workflow/leverage-cli/reference/terraform#init

BROKEN: link https://leverage.binbash.com.ar/first-steps/user-guide/base-workflow/leverage-cli/reference/terraform#apply

BROKEN: link https://leverage.binbash.com.ar/first-steps/user-guide/identities/gpg/

BROKEN: link https://leverage.binbash.com.ar/first-steps/user-guide/base-workflow/leverage-cli/reference/terraform#import

BROKEN: link https://leverage.binbash.com.ar/first-steps/user-guide/base-workflow/leverage-cli/reference/credentials#update

URL: https://leverage.binbash.com.ar/first-steps/post-deployment/
The following links were broken:

BROKEN: link https://leverage.binbash.com.ar/first-steps/first-steps/management-account/#identities-layer

BROKEN: link https://leverage.binbash.com.ar/first-steps/first-steps/security-and-shared-accounts/#identities-layer

BROKEN: link https://leverage.binbash.com.ar/first-steps/user-guide/identities/gpg#how-to-manage-your-gpg-keys

Proposed Solution
Its seems like the links related with the user-guide section don’t wok correctly.
I think the problem cloud be in the "href",  it's points to a nonexistent path:

Now:

Should be:

Line 2157 of le-ref-architecture-doc/first-steps/management-account/index.html

@Rodriguez-Matias Thanks for reporting this issue, it has a very clear and complete explanation. So as discussed we'll work together on order to solve it 🚀
CC: @binbashar/leverage-ref-architecture-aws-admin @binbashar/leverage-ref-architecture-aws-dev

@Rodriguez-Matias thanks for your contribution here, as we've seen after sync with master branch and re-deploying everything works fine.
CC: @binbashar/leverage-ref-architecture-aws-admin @binbashar/leverage-ref-architecture-aws-dev


Initialize only I2C stack

Is there any easy way to initialize just I2C bus, not SPI/GPIO/etc? I have some custom code with bit banging over SPI, and it goes down to the conflict because of the resource usage.

A few questions to clarify:

Do you mean https://periph.io/x/periph/host/sysfs specifically?
What platform, a Raspberry Pi running Raspbian or something else?

In this case, is there any reason why you can't use raspi-config to disable SPI?

What do you mean exactly by "resource usage"?
Do you need to use the exact same SPI pins or any pin would do?
driverSPI.Init() specifically doesn't open the SPI devices, so I'm surprised there would be any interference there.

@maruel I just rebooted the PI and now everything works fine, I assume that there was something in the way. Closing this as not an issue.


chore(Cargo): update rust dependencies

[ ] Amended the changelog in release.nix (see release.nix for instructions)

CI failure formatting, goes into other PR.


Latest Release requires future 2sxc?

2sxc v14.08 is current, but

this is a bit unsexy, sorry.
Temporarily please scroll down on the app-catalog - further down you can see previous releases.
14.09 should come out in a few days.


Requesting reopening of Issue #28625

Microsoft PowerToys version
0.74.1
Installation method
GitHub, PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
It was my fault for not responding in a timely manner, but I did now respond and I'm hoping to reopen it.
✔ Expected Behavior
It was my fault for not responding in a timely manner, but I did now respond and I'm hoping to reopen it.
❌ Actual Behavior
It was my fault for not responding in a timely manner, but I did now respond and I'm hoping to reopen it.
Other Software
No response

Reopened. Thank you


Calling elevator.stop() triggers many incorrect "passing_floor" events

Using the following code:
{
    init: function(elevators, floors) {
        var elevator = elevators[0];
        elevator.goToFloor(2);
        elevator.on("passing_floor", function(floorNum, direction) {
            console.log("Passing floor "+floorNum);
            elevator.stop();
        });
    },
    update: function(dt, elevators, floors) {}
}

You would expect to see only Passing floor 1 printed, and then nothing else.
The actual result is sometimes it prints:
Passing floor 1
Passing floor 2
Passing floor 1

And sometimes even:
Passing floor 1
Passing floor 2
Passing floor 1
Passing floor 2
Passing floor 1

You can try this in challenge 1

Nice find, pretty serious bug. Will take a look.

It's kind of sporadic, but I managed to make a test that consistently fails.
https://github.com/magwo/elevatorsaga/blob/floorpassing/test/tests.js#L302
It seems that if you overshoot some certain "magic" amount or something, the bug manifests.
The code that generates the passing_floor events is not very clean. I'd like to make it more simple and obviously correct.
The reason it is complicated, I think, is because sometimes elevators overshoot slightly when stopping at a floor, causing it to pass the floor and then go back down. This is a tiny amount and that should not trigger the passing_floor event again, which complicates the code.

Might have to completely rewrite the code that generates these events.

Now rewritten and kind of fixed. You can still sometimes get multiple events for the same floor when stopping very close to the floor, due to slightly bouncy control system. But all the events should be expected and arguably correct.

I'm still seeing this behavior and it does not seem correct. When the elevator is moving from floor 2 to floor 0, on the first "passing_floor" (1) event I direct it to goToFloor(1). This results in 9 new "passing_floor" (0) events.
Floor 1 has not yet been passed, and floor 0 is not being passed (it is scheduled to be visited after the visit to floor 1).

You are correct. Will investigate.

Code to reproduce:
{
    init: function(elevators, floors) {
        var elevator = elevators[0]; // Let's use the first elevator

        // Whenever the elevator is idle (has no more queued destinations) ...
        elevator.on("idle", function() {
            // let's go to all the floors (or did we forget one?)
            elevator.goToFloor(2);
            elevator.goToFloor(0);
        });

        elevator.on("passing_floor", function(floorNum, direction) {
            console.log("passing floor", floorNum, direction);

            if(floorNum === 1 && direction === "down") {
                elevator.stop();
                elevator.goToFloor(1);
            }
        });
    },
        update: function(dt, elevators, floors) {
            // We normally don't need to do anything here
        }
}


Step 3 RLHF PPO Training Action Mask Does not Make Sense

Hi,
I believe there is a bug in implenting PPO trainer in step3_rlhf_training.
The current code implements the action_mask by a right shifting. But I believe the left shifting is correct, because we do not use the last token (rather than the first token) for calculating the loss.

The original implementation (refer to https://github.com/microsoft/DeepSpeedExamples/blob/master/applications/DeepSpeed-Chat/training/step3_rlhf_finetuning/ppo_trainer.py#L183):
action_mask = attention_mask[:, 1:]

I believe the correct implementation is:
action_mask = attention_mask[:, :-1]

Best regards,
Ziniu

I misunderstand the code and finally find that there is no bug.
Specifically, the next token prediction framework implies that when we decides the action mask, we need a right shifting. That is the reason why action_mask = attention_mask[:, 1:] is reasonable.


[Feature Request] Create new folder from Query context-menu

Is your feature request related to a problem? Please describe.
When creating a new folder, I find it rather disturbing to find it created at the top of the list. When you have plenty of queries, you have to drag&drop it down until the place you want it to be. And most of the times, I have to do this when wanting to sort my queries into... subfolders.
Describe the solution you'd like
What would be great is to be able to a create a new folder from the context-menu of a Query, like "Move to a new folder", and the folder would be created right at the same place as the query was before.
Describe alternatives you've considered
An alternative would be to create the folder (via the menu or the Shift+Ctrl+N combination) right before or after the current Query, that would avoid having to drag&drog the new folder right from the top.

Hi @mxmlnglt thanks for reporting this, and sorry for not getting back to you sooner!
We have since changed a bit the way folders and requests work, so now you should be able to create a new folder inside another one:

And you should also be able to run the Create Folder keyboard shortcut (Shift+Cmd+N or Shift+Ctrl+N) when you have a request selected, and it will create a folder on that level.
Feel free to report any other issues you come across!


Interpolate the data within max and min dates of the whole series

Right now I interpolate the data for plotting and skill using a 30 points limit to avoid huge extrapolations.  That is fine for most SECOORA applications due to the high resolution of the data and most of the models.
To make this more generic we can find a max and min valid dates for all the series (excluding low temporal resolution models) and interpolate only within that range.

On second thought.  Excluding the low resolution is not OK.  I'd rather have a useless comparison, but show that the models exists, than omitting these models. They are very few and only global HYCOM comes to mind.


Unable to download Arousal Based Breast Adjuster SE <IP_ADDRESS>z

What happened?
[FATAL] (Wabbajack.Installer.StandardInstaller) Unable to download Arousal Based Breast Adjuster SE <IP_ADDRESS>z (ManualDownloader+State|https://www.loverslab.com/files/file/6671-arousal-based-breast-adjuster-for-se-abba/)
This got updated yesterday and the old file does exist in the form of the legacy download, but it doesn't get accepted by wabbajack. Figured it'd be worth reporting. I've tried redownloading the legacy version, unpacking it, repacking it into a .7z, and changing the name, but that doesn't seem to work. Not familiar with the internal machinations of Wabbajack so I can't take my troubleshooting much further.
Modlist version
1.2.1

there is a temporary link here https://github.com/zhongjiedong/Tsukiro/blob/main/Arousal Based Breast Adjuster SE <IP_ADDRESS>z


Reviewer 2 - Installation instructions - Unable to install dependency

openOmics version: 0.8.4
Python version: 3.9
Operating System: Mac OS X

Description
Running pip install requirements.txt initially received error.
Perhaps an external dependency on this can be specified (required by llvmlite)? The assumption is that the end-user has a working python installation and relevant compilers etc. installed, though this doesn't seem to be specified anywhere?
What I Did
Installing collected packages: MarkupSafe, Werkzeug, numpy, Jinja2, itsdangerous, zope.interface, zope.event, urllib3, threadpoolctl, scipy, retrying, PyYAML, pytz, python-dateutil, pyparsing, ptyprocess, llvmlite, joblib, idna, heapdict, greenlet, Flask, chardet, certifi, brotli, zict, typing-extensions, tornado, toolz, tblib, soupsieve, sortedcontainers, scikit-learn, requests, psutil, plotly, pillow, pexpect, patsy, pandas, packaging, numba, msgpack, locket, gevent, future, flask-compress, decorator, dask, dash-table, dash-renderer, dash-html-components, dash-core-components, colorlog, cloudpickle, xmltodict, xlsxwriter, xlrd, wrapt, wget, suds-jurko, statsmodels, requests-cache, pynndescent, pyerfa, pydot, partd, networkx, lxml, kiwisolver, grequests, fsspec, easydev, docopt, distributed, dash, cython, cycler, cachetools, bokeh, beautifulsoup4, appdirs, validators, umap-learn, typing, sqlalchemy, scikit-allel, rarfile, obonet, matplotlib, large-image, h5py, gunicorn, gtfparse, goatools, filetype, dash-daq, dash-bootstrap-components, bioservices, biopython, astropy, openomics
    Running setup.py install for retrying ... done
    Running setup.py install for llvmlite ... error
    ERROR: Command errored out with exit status 1:
     command: /Users/stephenmoss/.pyenv/versions/3.9.0/bin/python3.9 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/setup.py'"'"'; __file__='"'"'/private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-record-rgduko9u/install-record.txt --single-version-externally-managed --compile --install-headers /Users/stephenmoss/.pyenv/versions/3.9.0/include/python3.9/llvmlite
         cwd: /private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/
    Complete output (29 lines):
    running install
    running build
    got version from file /private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/llvmlite/_version.py {'version': '0.34.0', 'full': 'c5889c9e98c6b19d5d85ebdd982d64a03931f8e2'}
    running build_ext
    /Users/stephenmoss/.pyenv/versions/3.9.0/bin/python3.9 /private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/ffi/build.py
    LLVM version... Traceback (most recent call last):
      File "/private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/ffi/build.py", line 105, in main_posix
        out = subprocess.check_output([llvm_config, '--version'])
      File "/Users/stephenmoss/.pyenv/versions/3.9.0/lib/python3.9/subprocess.py", line 420, in check_output
        return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
      File "/Users/stephenmoss/.pyenv/versions/3.9.0/lib/python3.9/subprocess.py", line 501, in run
        with Popen(*popenargs, **kwargs) as process:
      File "/Users/stephenmoss/.pyenv/versions/3.9.0/lib/python3.9/subprocess.py", line 947, in __init__
        self._execute_child(args, executable, preexec_fn, close_fds,
      File "/Users/stephenmoss/.pyenv/versions/3.9.0/lib/python3.9/subprocess.py", line 1819, in _execute_child
        raise child_exception_type(errno_num, err_msg, err_filename)
    FileNotFoundError: [Errno 2] No such file or directory: 'llvm-config'

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/ffi/build.py", line 191, in <module>
        main()
      File "/private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/ffi/build.py", line 185, in main
        main_posix('osx', '.dylib')
      File "/private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/ffi/build.py", line 107, in main_posix
        raise RuntimeError("%s failed executing, please point LLVM_CONFIG "
    RuntimeError: llvm-config failed executing, please point LLVM_CONFIG to the path for llvm-config
    error: command '/Users/stephenmoss/.pyenv/versions/3.9.0/bin/python3.9' failed with exit code 1
    ----------------------------------------
ERROR: Command errored out with exit status 1: /Users/stephenmoss/.pyenv/versions/3.9.0/bin/python3.9 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/setup.py'"'"'; __file__='"'"'/private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-install-sm6pl876/llvmlite_0bff606e31a6496399a22ccfcec04d59/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/var/folders/bf/cl_g6mhx7zd9_1mhhvppbzdh0000gn/T/pip-record-rgduko9u/install-record.txt --single-version-externally-managed --compile --install-headers /Users/stephenmoss/.pyenv/versions/3.9.0/include/python3.9/llvmlite Check the logs for full command output.

I needed to run the following to fix the issue:
brew install llvm@9
LLVM_CONFIG=/usr/local/opt/llvm@9/bin/llvm-config pip install openomics
I tried with brew install llvm (version 11.0.1 and it failed with RuntimeError: Building llvmlite requires LLVM 10.0.x or 9.0.x, got '11.0.1'. Be sure to set LLVM_CONFIG to the right executable path.

Issue has been resolved under Mac OS + Python 3.9 and Python 3.8 when running pip install openomics.

All works fine for me now 👍


Gravatar

Many 'clean-up' and 'mistake' commits
No description so I have no clue whatsoever what is this PR purpose, scope, risks, etc.
Like another PR there are changes to indentation, and package.json is again mangled with different versions/packages that I can't understand what's changed there.

@rhutchison I appreciate the will to contribute but let's make the PRs more clean and tidy.


fix: remove entity overlay when switching extraction

Fixes: ADO#2264
Why was the entity overlay added?
We used to allow users to freely select text. This was a established behavior they would expect from other program like notepad or Word and some time ago this overlay was put in and diverged from that behavior. Likely to protect against some error but what was it? In other words, previously there was no concept or requirement to UNselect something, the new selection would over write the old one. Now the users have to click again.
There is also duplicated state in the extractor editor and the custom entity node. From my testing it was because the node is not re-rendered and needs this, but it's going against standard react patterns of lifting state to parents, This is example of thing that would be better to capture comments.

:tada: This PR is included in version 0.389.4 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


wind direction not customizable

If your language doesn't have the same convention that NESW are the directions, you need to change the script itself, which risks getting overwritten in a package update.
If line 240 where you set the wind directions is put into the .ansiweatherrc and pulled from there, it would be customizable as well.
Same goes for the replacement of the word 'forecast'.

That makes sense, thanks for your suggestion.
Since version 1.08, you can also set "forecast_text" in .ansiweatherrc.


TouchableNativeFeedback not working on android

Having trouble using TouchableNativeFeedback on android devices. Even when just running react-native init, and adding only a TouchableNativeFeedback, I get the following error: "Trying to add unkown view tag: 13..."
Minimal project where this error occurs: https://github.com/Pungsnigel/react-native-broken-example
I'm running react-native 0.14.2, and using a OnePlus One with Android 5.1.1

I guess you need to wrap your Text component in a View.

@satya164 Can't believe it was that simple... Working now, thanks a bunch!


Use a config schema instead of configDefaults.

Kills a Deprecation Cop warning.
configDefaults has been deprecated since v0.133.0:
https://github.com/atom/atom/commit/f57dbfd9f531c847f8e1ce34beab2b526f71
554c

Fixes #252 and #257.

Thanks!


[feature request] Add comment "This file was generated by"

Hi,
because I usually commit the classes your plugin generate, to be sure that no one build war with something accidentally changed, I would like to have an option that add at the top of the class a comment like JAXB:
//
// This file was generated by the JavaTM Architecture for XML Binding(JAXB) Reference Implementation, vJAXB 2.1.3 in JDK 1.6
// See http://java.sun.com/xml/jaxb
// Any modifications to this file will be lost upon recompilation of the source schema.
// Generated on: 2013.07.03 at 12:09:05 PM CEST
//
Thanks

I think you could do this using http://code.mycila.com/license-maven-plugin/

I mean, in the classes your Maven's plugin generate, it will be nice to add that comment, so people that open the source code of one of these classes can immediately understand that the source code is generated automatically.
Thanks

I've found in the past that people don't like this kind of addition in their source code, in particular when they have an existing project and this kind of change appears. I don't want to have to make a configuration option just for this, so I'm going to leave this out for now. Thanks for the suggestion though, I might revisit this at some point in the future.


fix: Correcting broken and incorrect links

Not having this reviewed as it's just minor link fixes (nothing that requires review).


[BUG] SKGLView doesn't repaint if it's in a TabBar

Description
SKGLView doesn't repaint if it's in a TabBar.
Code
AppShell.xaml - puts the MainPage with the MySKGLView in a tab bar.  When the tabs switch, the MySKGLView doesn't redraw
    <TabBar x:Name="SKGLViewTabs">
        <Tab Title="Tab1">
            <ShellContent
                Title="Home"
                ContentTemplate="{DataTemplate local:MainPage}"
                Route="MainPage" />
        </Tab>
        <Tab Title="Tab2">
        ...
        </Tab>
    </TabBar>

MainPage.xaml - contains the MySKGLView
<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             xmlns:local="clr-namespace:TestTabsMauiApp2"
             x:Class="TestTabsMauiApp2.MainPage">

    <ScrollView>
        <VerticalStackLayout
            Spacing="25"
            Padding="30,0"
            VerticalOptions="Center">

            <local:MySKGLView
                x:Name="MySKGLView1"
                SemanticProperties.Description="MySKGLView"
                HeightRequest="200"
                HorizontalOptions="Center"
            />
...

MySKGLView.cs - this draws a gradient filled rectangle usually
public class MySKGLView : SKGLView
{
    protected override void OnPaintSurface(SKPaintGLSurfaceEventArgs e)
    {
        base.OnPaintSurface(e);
        SKCanvas canvas = e.Surface.Canvas;
        canvas.Clear();
        SKRectI rect = new SKRectI(0, 0, (int)CanvasSize.Width, (int)CanvasSize.Height);

        // Create linear gradient from upper-left to lower-right
        using SKPaint paint = new SKPaint();
        paint.Shader = SKShader.CreateLinearGradient(
                            new SKPoint(rect.Left, rect.Top),
                            new SKPoint(rect.Right, rect.Bottom),
                            new SKColor[] { SKColors.Red, SKColors.Blue },
                            new float[] { 0, 1 },
                            SKShaderTileMode.Repeat);

        // Draw the gradient on the rectangle
        canvas.DrawRect(rect, paint);
    }
}

Expected Behavior

Click Tab1, the SKGLView draws
Click Tab2, the second tab draws
Click back to Tab1, the SKGLView is blank.  It should redraw [BUG]

Basic Information

Version with issue:  SkiaSharp.Views.Maui.Controls.Compatibility 2.88.3
Last known good version:  No previous version tested
IDE:  Microsoft Visual Studio Community 2022 (64-bit) Version 17.6.5
Platform Target Frameworks:

Android: Android SDK Platform 33, Android 12.0 - S

Target Devices:

Android Emulator 32.1.14
Google Pixel 5 - API 31

Screenshots
Reproduction Link
TestTabsMauiApp2.zip

Ooops!  I didn't realize this is for the mono SkiaSharp implementation, not Microsoft.  I was kind of surprised to find MS on github.  I'll close this bug and look for the MS repo.

Fixed by hack: toggle IsVisible in container's OnAppearing

I was kind of surprised to find MS on github.

GitHub is owned by Microsoft! 😆

I can reproduce this issue with .NET 8 (MAUI 8.0.61 and SkiaSharp 2.88.8). Unfortunately it also affects Mapsui.

Fixed by hack: toggle IsVisible in container's OnAppearing

Gladly I can also confirm this workaround :)

This is happen to me also and not even in a TabBar. We just have content page as usual. And this is only happen on Android. And thank you @noelbk for the workaround. It works for now :D

Even though there is a workaround, it would be much appreciated to have an official fix for this issue. This hack is not a sustainable solution and having a proper fix would ensure better reliability. Moreover, this issue might be a symptom of something even more severe, so addressing it promptly would be beneficial.
@mattleibow What do you think?

This issue happens when a new rendering thread is created for an SKGLView which already has had its layout (size/position) set.
The cause lies in SkiaSharp.Views.Android.GLTextureView.OnAttachToWindow() creating a new GLThread when the Tab with the SKGLView comes on the screen for a second time, without telling the thread what the size of the View is.
This makes the GLThread assume the View has a width and height of 0, causing nothing to be rendered.
And since the View has already been created and had its size/position set by the previous time the Tab came into view, GLTextureView.OnSurfaceTextureSizeChanged() (which currently is responsible for setting the width/height in the GLThread) is never called.
That's also exactly why toggling the IsVisible property off and on works! It will call GLTextureView.OnLayoutChange() with the correct width and height, enabling the GLThread to receive the actual width and height of the View.
The solution should be simple, which is to pass the View's width and height to the GLThread when it gets constructed, instead of assuming a size of (0, 0).

Nice analysis! :+1:


Add necessary import statements to README file

Your module works as expected, but I needed to import the module. I added this to the readme files.

Thank you for adding the missing part :smiley:


sidewalk=separate unsupported

Ways that have a sidewalk=separate tag lead to a conversion error.
Conversion Error: unsupported: 'sidewalk=separate' - osm2lanes/src/transform/tags_to_lanes/modes/foot_shoulder.rs:213:32

Good point. Like sidewalk=no, no sidewalk lanes should be generated for the way. osm2streets et al. should use sidewalk=separate to associate the nearby highway=footway or add a generic sidewalk as needed.
Maybe osm2lanes should gain an understanding of "parallel"/"adjacent" ways. Not to detect them, but to work with a list of them, the whole corridor, once they have been identified.