Is there any way to generate equivalent charges for resonance hybrids like carboxylate?

Hi all, thank you for making this package available!
I tested this out on some molecules and found that, for what we might think of as equivalent atoms, partial charges are different.
Example (see charges on oxygens):
from rdkit import Chem; from espaloma_charge import charge
from rdkit.Chem.Draw import IPythonConsole, rdMolDraw2D
import numpy as np
from IPython.display import SVG

m = Chem.MolFromSmiles('OC(c1ccccc1)=O')
ch = charge(m, total_charge=-1)

for i in range(m.GetNumAtoms()):
   m.GetAtomWithIdx(i).SetProp("atomNote",str(np.around(ch[i],3)))

d2d = rdMolDraw2D.MolDraw2DSVG(350,300)
d2d.DrawMolecule(m)
d2d.FinishDrawing()
SVG(d2d.GetDrawingText())

This may be expected: Section 8.5 of the manuscript says Ensuring full chemical equivalence is nontrivial:

the non-uniqueness of formal charge assignment (obvious in molecules such as guanidinium, where resonance forms locate the formal charge on different atoms) does not guarantee the assigned parameters will respect chemical equivalence (a form of invariance)

I see why it's hard - SMILES requires a kekule form rather than a resonance form. But is it possible to get around this? One might simply average the carboxylate charges, for instance, but I wonder if there's a more principled way?
Thanks
Lewis

@ljmartin: Thanks for raising this issue!
EspalomaCharge should only be using atom features that are invariant for resonance forms, so it should handle the carboxylic acid case here and assign equivalent charges for the oxygens.
What I suspect is happening here is that we never anticipated EspalomaCharge receiving molecules with implicit hydrogens, and the molecule create with
m = Chem.MolFromSmiles('OC(c1ccccc1)=O')

and pass in to
ch = charge(m, total_charge=-1)

is missing key hydrogens needed to actually produce useful charges.
Could you try this again by (1) specifying the carboxylate SMILES, and (2) telling RDKit to explicitly protonate the molecule before you pass it to charge()? You should not need to specify the total_charge.
@yuanqing-wang : It looks like we have two dangerous issues here we should address:

We need to check to make sure the molecules we are charging have all hydrogens explicitly represented, and raise an Exception if not
We should consider eliminating total_charge since the explicit hydrogen form of the molecule from RDKit should already provide all relevant information about the net charge. Allowing someone to specify a non-matching total charge will just cause bad charges to be produced.

Thanks for trying this!
OK, now this is puzzling for two reasons:

I don't understand why the oxygens would be featurized in different ways and receive different charges---they should be the same with the features we're putting in
I don't understand why the charge sum is not correct

@yuanqing-wang : Can you investigate?

Hi @ljmartin! It seems that, when Chem.AddHs, RDKit would by default add all hydrogens to COO-, making it a COOH. I'm thinking about what's the best way to circumvent this.

Thanks @yuanqing-wang - as far as I can tell, though, hydrogens are not added to the carboxylate. The picture above was created after adding hydrogens. One can verify that hydrogens aren't added to the carboxylate by saving a PDB structure and visualizing, or just counting up the atoms:
m = Chem.MolFromSmiles('[O-]C(c1ccccc1)=O')
m = Chem.AddHs(m)
print(m.GetNumAtoms())

output: 14. That's 9 heavy atoms (7 carbons, 2 oxygens) and 5 hydrogens (around the benzene ring).
RDKit version is 2022.09.4

Sorry that was my mistake.
It seems that there was a keyword mismatch in the deployment code. I'm drafting a fix here: https://github.com/choderalab/espaloma_charge/pull/17
I'll test and pull in a minute.

@jchodera @ljmartin it also seems that atom.GetTotalValence() for the oxygen atoms would show 2 and 1, respectively. Maybe we should get rid of this in the input feature as well.

@yuanqing-wang : Yes, we need to replace that with atom.GetDegree().

thanks for looking into this, @yuanqing-wang
@jchodera - could I trouble you to point me to the code in espaloma or espaloma_charge that handles resonance forms? It's something I've been looking to do, too.

@ljmartin : There is no special code in espaloma_charge or espaloma to handle resonance forms. In espaloma_charge (and in future updates of espaloma) our plan is to only use atom (and possibly bond) features that are invariant with resonance forms, but as noted above, we accidentally used atom.GetValence() (which is not resonance form invariant) instead of atom.GetDegree(). We'll fix that in a retraining and update in the next few days.
For more sophisticated approaches to handling resonance---such as averaging over localized resonance forms (including of biopolymers), you might check out the https://github.com/openforcefield/openff-nagl package, which has a much more sophisticated way to tackle this.

Amazing, thanks @jchodera.
Looks like this is wrapped up, so I'll close it.


sbt  ~run error (windows 8.1)

name@PC-NAME:[~/projects/pl-scala]:
$ sbt  ~run
[info] Loading project definition from C:\Users\name\projects\pl-scala\project
[info] Set current project to pl-scala (in build file:/C:/Users/name/projects/pl-scala/)
[error] Expected key
[error] Expected '*'
[error] C:/Program Files (x86)/Git
[error]   ^

Please follow What to report and list out all environment that could be contributing to this behavior:

how your sbt was installed
what version of sbt
list of your global settings and plugins
your build

Scala version 2.11.5 (Java HotSpot(TM) 64-Bit Server VM, Java 1.7.0_7
sbt.version=0.13.5

video -> http://a.pomf.se/aycalg.mp4

Thanks for the video.
So ~run works from Activator shell, but
$ sbt ~run

doesn't work on what seems to be Cygwin running with Bash.
Could it be tilde expansion? On my Mac and zsh I get
$ sbt ~compile
zsh: no such user or named directory: compile

but
$ sbt "~compile"

seems to work. Could you try with double quotes?

nice!
@eed3si9n thanks!! :+1:


Ashes of Singulary crashes

Ashes of Singularity crashes on the latest master build. Have tested with 1.0.3 and it runs perfectly. I'm using 430.14 so not sure if it's from a missing Vulkan extension or not.
Software information
Ashes of singularity, more or less max settings @ DX11 @ 4K resolution.
System information

System specs: https://pastebin.com/raw/BKL47L1T
Driver: 430.19
Wine version: 4.2-4 proton
DXVK version: master
steam-507490.log

Can you bisect this to figure out which commit it is that breaks the game?

Can you bisect this to figure out which commit it is that breaks the game?

It's going to be a recent commit because it ran fine on master 3-5 days ago. I'll look into how to bisect and let you know what commit it is.

See https://git-scm.com/docs/git-bisect on how to do it.

@doitsujin
I just installed random commits until I found the problem. Not sure if that's what you needed, but here you go:
32e1afc7a104b837b3440a58b4a49640c401e511 - compiles, game works
e5fa55cbb5fac2761b1e85e5d8008bf49ecea4c4 - compiles, game crashes

Interesting; this is the second time that someone reports this commit as broken. May I ask which compiler you are building DXVK with, and whether you're using a winelib build or mingw build?

I'm using this ebuild - https://raw.githubusercontent.com/pchome/dxvk-gentoo-overlay/master/app-emulation/dxvk/dxvk-9999.ebuild
Meson is at 0.49.2, GCC is 9.1.0.

@tsalwierz I have a similar problem with a similar ebuild and the same bisected patch (e5fa55c).
But when I build with the package-release.sh script, instead of the ebuild, I've no problem at all.
Can you try to build with the package-release.sh script and see if it's OK?

Looks like the ebuild you're using is producing winelib builds. Seems the issue is localized to that.

Forced -Dunity=on comes in mind.

@pchome
I have an extra copy if you want the game.

@tsalwierz
Thanks, but RTS (it's RTS ?) is not my thing. I don't going to use it other than for testing.
Could you check if this bug caused by unity build?
This build type greatly reduces DXVK compilation time, and I using this by default despite all earlier detected problems. So, maybe it worth to disable unity, and force -O2 for safety.

@pchome
That's a negative, forcing -Dunity=on -O2 after the flag parameters did nothing.

https://github.com/pchome/dxvk-gentoo-overlay/commit/382d1e09dc4cd2cfc2ce4f8f33ae73168e0888f0
Ebulds w/ unity set to off and forced -O2 (also there is experimental openvr USE flag, set if you have VR, not planned but ...).

Otherwise I can only blame -fvisibility=hidden flag.

@pchome
Attached.
stuff.txt

That's really strange. If you use standard meson release build -- it should differ to your flags only for -march=native -pipe -fomit-frame-pointer (AFAIK meson release uses -O3 flag only).
@edmondo
I suppose we still talking about winelib build for package-release.sh.
@tsalwierz
So the ebuild, other than appending your flags to default flags from cross-file, should do the same things as package-release.sh.
Let's continue investigations yesterday, I have no ideas for now.

@pchome yes, I only use winelib. I built it with:
./package-release.sh master /home/edmondo/tmp/dxvk --winelib
I had the issue with ELEX, freezing on the main menu. Problem is, I cannot reproduce anymore the issue with the ebuild. So my information is sadly not very reliable.

Just to confirm e1610f8 did fix the problem @doitsujin


Some features are running on unrelated pages

Clear the cache
Reload this issue
Run this in the extension’s console: chrome.storage.local.get(console.log)
Notice the workflows, list-prs-for-file, and tag-ahead-by cache items, neither of which appears on an issue

Example URL
This issue
Browser(s) used
Safari

I do see workflows in Firefox, but not the others.

I think the others don't appear on the issue page, but on the PR page. Closing for now. If you see unusual entries on other pages feel free to reopen


Add exit built-in command

Call app.quit() in a built-in command. This resolves the first half of #158.
"exit" does not show up in autocomplete, even though "clear" does. Should it be added to providers/Executable.ts or is there a better place?

Thank you @shockone, getInstance() changed to instance.
In order to re-render ApplicationComponent when the terminals change, I modified Application to emit events when it changes (similar to Terminal) and subscribed ApplicationComponent to these. This is in https://github.com/bmats/black-screen/tree/exit-command-app-emitter. Is this approach OK, or is there a better solution?

@bmats, I'm sorry it took me so long. Could you please update it, because it's conflicts now?

No problem, @shockone. I fixed the conflicts.

Thank you, @bmats.


This line isn't useful.

There shouldn't be any reason to do this.
This might cause a minor perf regression until we fix https://github.com/flutter/flutter/issues/3488.

@abarth

never mind. this breaks all the tests. i'll do this as part of my big test framework refactor.


Why the order of the tuple is changed in CustomOperator?

Repro Steps
type SimpleSequenceBuilder() =
  member __.For(source, body) =
    seq { for v in source do yield! body v }
  member __.Yield(()) = Seq.empty
  member __.Yield(item) = seq { yield item }
  [<CustomOperation("apply",  AllowIntoPattern=true)>]
  member __.Apply(source, case) = seq { yield! source; yield case }
  [<CustomOperation("print")>]
  member __.Print(source: _ seq, [<ProjectionParameter>]f: _ -> unit) =
    printfn "%A" source
    Seq.iter f source

let myseq = SimpleSequenceBuilder()

myseq {
  apply (1, 2, 5) into (b, c, a)
  print (printfn "%d %d %d" b a c)
}

Expected
seq [(2, 1, 5)]
2 1 5

Actual
seq [(2, 1, 5)]
1 5 2

Translation
probably
myseq.Print(
  mseq.For(
    myseq.Apply(
      myseq.Yield(()),
      (1, 2, 5)
    ),
    fun (b, c, a) ->
      myseq.Yield((c, b, a)) // Why not (b, c, a)?
  ),
  fun (c, b, a) ->
    printfn "%d %d %d" b a c
)

Version
F# 3.0 (FSharp.Core, <IP_ADDRESS>), .NET Framework 4.5

This is by design. If you emit a final "select"-like construct, the results will be to yield the active variable space.

I understand. Thank you for letting me know.


Take config's OS, Dist, OS X image name, known Env var values into cache slug computation

This PR addresses the issue with cache name collisions by taking into account extra pieces of information known at the build script compilation time.
Related issues:
https://github.com/travis-ci/travis-ci/issues/4393
https://github.com/travis-ci/travis-ci/issues/3023

Currently, this PR does not take secure env vars into consideration. As we are just taking the SHA256 digest, I think it is acceptable to take secure env vars into computation. (There is no way to recover secure env vars from the SHA256 digest.)

Actually, I think it is best to not include secure environment variables, since we do not use salt for the digest.

Or add salt on the app side.

Examples=:
https://staging.travis-ci.org/BanzaiMan/travis_staging_test/jobs/492870#L161-L163

The salt can be defined user or repo level in the database. Either as a new field (preferred) or reusing an existing secret (less preferred).

Maybe we should take the osx_image value into account. This is a bit more granular information than OS X release (sw_vers -productVersion), but it is better than corrupt caches.

We should also consider not printing the hash at all.

Would it be possible to include an extra user-defined salt value as well, so that individual builds may set themselves apart from others in the matrix?
We're currently working around this with a hack: https://github.com/bitcoin/bitcoin/blob/master/.travis.yml#L38
It would be great to use instead, something like:
    - cache_salt: arm
      env: HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf" DEP_OPTS="NO_QT=1" CHECK_DOC=1 GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
    - cache_salt: win32
...

Ok, I clicked too fast, assuming this only applied to vars set outside of the .yml. Obviously that's not the case, and this work addresses our use-case exactly. Thanks!

There are some cases where user-defined variables contain pre-defined vars from the builder. For example: https://travis-ci.org/bitcoin/bitcoin/jobs/125738866#L161
Would the values of vars like TRAVIS_BUILD_ID/TRAVIS_COMMIT/etc. be expanded before being used to calculate the slug? If so, I imagine there are many that would cause new cache id's for each build.

@theuni Thanks for taking time to look at this PR. I really appreciate the interest in this feature.
This PR considers only the environment variables defined in .travis.yml because only these are known at the build script compile time. This characterostoc is important because in order to fetch and store caches securely, URLs have to be signed; and the signing must happen at the script's compile time. (See the description of this PR.)
Some environment variables are evaluated and assigned only at the run time. Some can be reasoned beforehand (e.g., TRAVIS_BUILD_ID) but are probably not fit to be a part of the key for the cache (because the hash thus computed will never match again for future builds). We simply need to stay away from them. Users may assign others (e.g., in a script), but there is no way for travis-build to know them.
I also thought about some mechanism for the user to influence the cache name (e.g., with cache_salt as proposed in a previous comment here) with a key in .travis.yml. I like the idea, but I think the cost is rather high (in terms of cognition, and in terms of implementation). To achieve the same effect, however, one can simply set an extra environment variable that does nothing but signifies the name of the cache (e.g., CACHE_NAME=arm).

My inclinations:

Leave secure environments out of the mix
Omit a few characters in the digest name in the logs

@BanzaiMan Agree on leaving out secure vars.
As a suggestion though, it would be helpful to see (maybe behind a debug var?) which env vars have been considered for the slug, without their values.

@theuni Do you want that information always printed? Sees a bit noisy. And adding a key to .travis.yml seems kludgy.

@BanzaiMan No, only for troubleshooting the non-obvious cases.
It would be helpful in this case to see what's happening with BAR, as I'm not sure if empty is the same as nonexistent.
Not the end of the world if printing it is a hassle though, It would only take a few quick experiments to figure out what's happening.

The very presence of such a variable should affect the cache name. BAR= and  (absence of BAR) are different.

This has been deployed to production. I will observe how it behaves for the next several hours, after which, if it's behaving well, I will merge this code and redeploy.


Change icon to button

In button component README, changed "icon" to "button"

Looks like duplicate of #35

Fixed in https://github.com/material-components/material-components-web-components/pull/35


Add search component

We should keep the focus state the same colour (3px yellow box-shadow) on the error state so users can follow it down the page as they tab.   Only change the input border and outline from black to red.

 Search component


support ES6

Would be great to support full ES6 feature.
I'm using facebook fork of esprima. This fork has an Experimental support for ES6/Harmony (module, class, destructuring, ...). Don't know if it's enough.

Why don't just use the upstream Esprima 2.x? It gets enough support for ES6 features.

Because I want to support facebook jsx format (https://facebook.github.io/jsx/).

This worked for my needs: https://github.com/brandonbloom/i18n-extract/commit/2d9871790def99b607b8e02965ea585d70bc813b

This worked for my needs: brandonbloom@2d98717

Interesting, I'm gonna add an unit test with ES6 format. Will try to use babel-core.

Fixed with @6b01835740cb0523d03ce9d011a3e07b03d2938f.


allow IOBuf::append_user_data_with_meta to specify the lkey of rdma memory region

What problem does this PR solve?
Issue Number: 1995
Problem Summary: When using IOBuf::append_user_data, if the application specify a buffer with an offset over the base address registered with rdma::RegisterMemoryForRdma, brpc reports a failure for invalid memory region.
What is changed and the side effects?
Changed: Add a new function named append_user_data_with_meta in IOBuf. Allow application specifying the lkey as meta to explicitly inform brpc. This removes the necessity to lookup the lkey for the IOBuf Block in rpc processing.
Side effects:

Performance effects(性能影响):

Breaking backward compatibility(向后兼容性): To store the meta/lkey in IOBuf Block, the portal_next field is reused when flags is non-0. It is acceptable because portal_next is only used for tls cache of IOBuf, which does not work for user defined Blocks.

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

append_user_data_with_meta not found in files changed

LGTM

@wwbmmm is this PR qualified to be merged? It seems that the Travis often fails due to some irrelevant reason.

Has resolved conflict. Any plan to merge?


feat(blot): Add divider module to toolbar

PR
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our Commit Message Guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #158
What is the new behavior?
支持插入分割线

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Summary by CodeRabbit

New Features

Added a visual divider to the toolbar for improved formatting options.
Introduced localization support for the divider in English and Chinese.
Implemented a new divider icon for the editor.
Enabled the insertion of dividers within the editor using the toolbar.
Enhanced tooltip options in the toolbar to include the divider.

Bug Fixes

Ensured proper initialization of tooltip options in the toolbar.

@jany55555 有几个优化点可以考虑下：

点击分隔线，出现选中效果，此时可以 Delete 删除分隔线、Ctrl+C 复制分隔线、Ctrl+X 剪切分隔线
分隔线左右两边要能使用光标，点击分隔线右边缘，光标出现在分隔线右边，此时输入内容，内容会插入下一行；左边光标同理
在两行文本中间插入分隔线，目前是会多一个换行，可以优化下只插入分隔线、不插入换行


Add other variant into ResponseType

Shouldn't we add an Other(i32) variant into the ResponseType enum? Docs says that gtk response types are below 0 but that users can provide custom ones. Shouldn't it be wrapped as well?

Yes

Don't we already have #[doc(hidden)]__Unknown(i32), ?

If it need be in doc, IMHO better don't copy ResponseType
but change gir to allow enable docs for it or, better, change it name.

Yes, the Unknown here should be just made public... and maybe renamed into Other and we might want to add a check that the value given does not overlap with any of the others.

Not sure how to do check normally,
maybe just add fn normalize(self)->ResponseType{ from_glib(self.to_glib()) } is enough?

We could just implement TryFrom and do the check at this point? Not really sure how we could enforce the check before even creating the variant...

TryFrom is not stable yet. But yes, you'd need some kind of function.
Maybe just add a ResponseType::other(type_: i32) function that panics on invalid inputs?

I meant case when one user create ReponseType::Other(-4) instead ResponseType::DeleteEvent and use it.
It not problem in C part but if other user get this value in rust (not from C) and attempt to match can gone wrong.

Adding constructor other can solve problem, if Unknown not made public

That would work but I find it a bit counter-intuitive... But if no better solution, that would do it.

We still need to make the other, unknown variant "public" (not hidden) though, otherwise users can't easily match on their custom response types.

Then how we can solve problem https://github.com/gtk-rs/gtk/issues/725#issuecomment-428837751 ?

Then how we can solve problem #725 (comment) ?

Add a panic in to_glib() for an invalid value for "other" responses and document this

Or only allow u16 for "other" types :)

Last idea maybe good, but need full copy generated code to manual.

Then how we can solve problem #725 (comment) ?
Add a panic in to_glib() for an invalid value for "other" responses and document this

But then it'd panic and I'm not a big fan of this... And if we allow only u16 types, it means you won't be able to instantiate a "known" kind from i32 directly.

I'm having in mind cases where a defined ResponseType isn't available on all platforms but maybe I'm being too careful here...

The people can still use the hidden __Unknown variant as a workaround


Regex concept

Summary
Create the Regular Expressions concept.
Create the "Regular Chatbot" exercise.
Closes #122
Checklist

[x] If docs where changed, run ./bin/configlet generate to ensure all documents are properly generated.
[x] CI is green

The main question: does the concept and exercise satisfy the design goals?

The main question: does the concept and exercise satisfy the design goals?

I believe it does!


Add function row_blobs: stmt -> row

A new function (+ glue code) is added:
val row_blobs: stmt -> row

which lets you avoid going through Data to implement the same callback API as exec when using prepare (going through Data is can be inconvenient due to Sqlite's dynamic typing).

Thanks for the contribution!  I have improved some minor things and made a release.

Thank you!


Question - How to get errorcodes from dependent rules

Good night @JeremySkinner, it's nice to talk to you again.
I have a problem with the following code:
InlineValidator<Transaction> InlineValidatorTransaction = new InlineValidator<Transaction>();

InlineValidatorTransaction.RuleFor(t => t)
			  .Must(CanUpdateAccountBalance).WithErrorCode("ERR_CANNOT_UPDATE_ACCOUNT_BALANCE")
			  .DependentRules(() =>
			  {
				  InlineValidatorTransaction.RuleFor(t => t.Account)
							.NotNull().WithErrorCode("ERR_ACCOUNT_IS_NULL");

				  InlineValidatorTransaction.When(t => t.Account != null, () =>
				  {
					  InlineValidatorTransaction.RuleFor(t => t.Account.Id)
								.Cascade(CascadeMode.StopOnFirstFailure)
								.NotEmpty().WithErrorCode("ERR_ACCOUNT_ID_IS_EMPTY")
								.Must(IsAccountValid).WithErrorCode("ERR_ACCOUNT_ID_IS_INVALID");
				  });

				  InlineValidatorTransaction.RuleFor(t => t.Value)
							.GreaterThan(0m).WithErrorCode("ERR_VALUE_MUST_BE_GREATER_THAN_ZERO");
			  });

In this case, how do I get the error codes in the rules inside the dependent rules action block? The only error that I can see after the validation is done is ERR_CANNOT_UPDATE_ACCOUNT_BALANCE.
Or maybe there's another way to chain the error codes here?
Thanks and regards!
@rmszc81

All the error codes will be in the ValidationResult after you execute the validator. They're associated wiht the property that caused the rule to fail in the Failures collection.

Yes I understand but, in this piece of code, this does not happen.

I understand that in this case, my rules were not well defined here (sorry by long time for post an answer by the way).
In the other hand, I changed my rules to the following:
InlineValidatorTransaction
	.RuleFor(t => t.Account)
	.Cascade(CascadeMode.StopOnFirstFailure)
	.NotNull().WithErrorCode("ERR_ACCOUNT_IS_NULL")
	.DependentRules(() =>
	{
		InlineValidatorTransaction.RuleFor(t => t.Account.Id)
			.Cascade(CascadeMode.StopOnFirstFailure)
	 		.NotEmpty().WithErrorCode("ERR_ACCOUNT_ID_IS_EMPTY")
	 		.Must(IsAccountValid).WithErrorCode("ERR_ACCOUNT_ID_IS_INVALID");
			InlineValidatorTransaction.RuleFor(t => t.Value)
	 		.GreaterThan(0m).WithErrorCode("ERR_VALUE_MUST_BE_GREATER_THAN_ZERO");
	})
	.DependentRules(() =>
	{
		InlineValidatorTransaction.RuleFor(t => t)
			.Must(CanUpdateAccountBalance).WithErrorCode("ERR_CANNOT_UPDATE_ACCOUNT_BALANCE");
	});

In this case, the 2nd DependentRules are being executed anyway, even if the first Dependent Rules fail. How can I achieve this please?

In this case, the 2nd DependentRules are being executed anyway, even if the first Dependent Rules fail.

That's correct. Because the second dependent rules call is defined at the same level as the first. So the second dependent rules call is dependent on the root rule passing, just like the first one is. You'd need to nest them to achieve what you want.

Closing due to no further activity. Please re-open if you're still having problems.


adapt connection e2e params test to use gov v1 message

Part of https://github.com/cosmos/ibc-go/issues/2010
Pre-requisite:

[ ] #3650

Adjust TestMaxExpectedTimePerBlockParam to use gov v1 message when the version of the chain supports it (keep using legacy params for versions that don't support gov v1).
Alternatively we could also not test legacy params anymore and test only with gov v1. Open to the opinion of others.

Done in #3650


After applying loadBalancerIP option in values.yaml it goes in pending state.

If we create ambassador svc without applying loadBalancerIP it works fine.

Sorry my bad. I was creating the static ip in different region.


question: liburing access patterns

I am looking for  a best-practice to "interrupt" the io_uring_enter call from a different thread. I am using eventfd which works ok. it seems that IORING_OP_NOP could work as well if submit path was thread-safe but it seems not. Is it non-thread safe in kernel as well? Can you think of anything  better than eventfd for waking up io_uring_enter from a different thread? btw, I am getting a hard time to understand why IORING_REGISTER_EVENTFD exists. Does it help me it if I manage my I/O loop fully via io_uring (without epoll_wait)?
io_uring_peek_batch_cqe returns count pointers to entries in ring->cq.cqes array. The entries are 16 bytes, pointers are 8. Why not just copy the entries by value? Why do we need this additional level of indirection? That would allow a user to advance completion queue by count right after io_uring_peek_batch_cqe returns and before it processes cqe callbacks potentially freeing up the space in CQ for kernel  in parallel to user code processing the callbacks.

eventfd should work fine, another option is to use timeouts
you must process cqes before advancing the cq ring, or you could risk have new events come in an overwrite the ones you haven't processed yet. if you copy, then you need an extra copy (both in terms of storage and memory copy overhead). you could roll that on your side if you wanted to, though.

To expand on #1, the kernel side is fully thread side, the liburing side is not in terms of the struct io_uring cq and sq side management.

Thanks! My suggestion regarding (2) was to simplify the interface since the extra copy is only 8 bytes per entry and it seems negligible. Anyway, that's what I did https://github.com/romange/gaia/blob/IoUring/util/uring/proactor.cc#L55

@axboe, @romange 's suggestion regarding copying 16 byte CQEs instead of copying 8 byte pointers would also mean that io_uring_cqe_seen() is no longer needed, making the liburing interface simpler and safer. It might even be faster... if you could copy a batch of CQEs, you would also gain the performance upside of amortizing the atomic head update across the batch.
For a batch of 256 CQEs, or a 4096 page, it comes down to a copy of 2048 additional bytes with a single io_uring_smp_store_release() vs 2048 less bytes copied with 256 calls to io_uring_smp_store_release().
I don't know which is worse.

I've got some pretty beefy test hardware, so I'd definitely be able to test this if someone hacks it up.
On difference in cost, depends a lot on the arch. On x86, the load acquire and store release are not expensive.

Well, you're right, but I don't like io_uring_peek_batch_cqe() at all.
CQEs are already laying mostly contiguously in memory with an exception
of wraping around. You may iterating over them directly (see
io_uring_for_each_cqe()) or do maximum 2 memcpy()s to copy them
to a local array of CQEs.
p.s. io_uring_for_each_cqe() does unnecessary load_acquire()s, but
that's doing nothing for x86 and you may easily optimise it.

I perform the copy to local array and then call io_uring_cq_advance before running the completion callbacks. The motivation is that I want to remove pending CQEs as quickly as possible to allow kernel to continue processing I/O events  while my server code does its own thing.
inline unsigned CQReadyCount(const io_uring& ring) {
  return io_uring_smp_load_acquire(ring.cq.ktail) - *ring.cq.khead;
}

unsigned IoRingPeek(const io_uring& ring, io_uring_cqe* cqes, unsigned count) {
  unsigned ready = CQReadyCount(ring);
  if (!ready)
    return 0;

  count = count > ready ? ready : count;
  unsigned head = *ring.cq.khead;
  unsigned mask = *ring.cq.kring_mask;
  unsigned last = head + count;
  for (int i = 0; head != last; head++, i++) {
    cqes[i] = ring.cq.cqes[head & mask];
  }
  return count;
}

IMHO, this one should be in liburing.
And that may be faster with memcpy().
unsigned head, mask, last;
...
count = min(ready, count);
last = min(head + count, (head + mask) & mask);
memcpy(local_cqes, &ring.cq.cqes[head & mask], last - head);

Or this one
offset = head & mask;
cq_size = mask + 1;
count = min(ready, count, cq_size - offset);
memcpy(local_cqes, &ring.cq.cqes[head & mask], count);

yes, it's faster and more concise.
as you said, it might need 2 memcpy's in case of wrapping.

Right, that one should work if callers do retries for non-zero return.
You're probably already have a loop around, am I wrong?

Yes, I have a loop around :+1:  Good point.


new version of zmq 0.9

Signed-off-by: Axel Nennker<EMAIL_ADDRESS>zmq 0.9 will get changes that are not part of the 0.8 branch that are useful/needed for cross-compiling libindy. This PR bumps the version to the new 0.9 zmq.

The cause for the poisoning seems to be a pool timeout.
'IndyError { error_code: PoolLedgerTimeout, message: "Error: Pool timeout\n  Caused by: Consensus is impossible\n"'
This might be due to a wrong server key or something that was changed in this PR.
I assume @mikelodder7 will see the cause immediately when he is back on Monday.

The PR looks good as it just upgrades the ZMQ version. Can you point me to the pool timeout error you are seeing?

It does a little bit more than upgrade the version. The API changed.
https://github.com/hyperledger/indy-sdk/pull/1792/files#diff-a7fc12abaf1ee9daab630fc4bbd3faf6R346
Maybe I adapted the calls incorrectly, there was something regarding z85encoding we chatted about already.
The timeout is visible here: https://build.sovrin.org/blue/organizations/jenkins/indy-sdk%2Findy-sdk-ci/detail/PR-1792/3/pipeline
---- high_cases::cred_def_cache::indy_get_cred_def_cache_works stdout ----

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: IndyError { error_code: PoolLedgerTimeout, message: "Error: Pool timeout\n  Caused by: Consensus is impossible\n", indy_backtrace: Some("stack backtrace:
0: failure::backtrace::internal::InternalBacktrace::new::hafe4f3b6de23059d (0x7fd17ab2c932)\n             at /home/indy/.cargo/registry/src/github.com-1ecc6299db9ec823/failure-0.1.5/src/backtrace/internal.rs:44
1: failure::backtrace::Backtrace::new::h99e416b70139309e (0x7fd17ab2c66d)\n             at /home/indy/.cargo/registry/src/github.com-1ecc6299db9ec823/failure-0.1.5/src/backtrace/mod.rs:111
2: failure::context::Context<D>::new::h3dd3c69c63ffa494 (0x7fd17a7beec1)\n             at /home/indy/.cargo/registry/src/github.com-1ecc6299db9ec823/failure-0.1.5/src/context.rs:84
3: indy::errors::IndyError::from_msg::he7a01937adb021ad (0x7fd17a16fced)\n             at src/errors/mod.rs:153
4: indy::errors::err_msg::ha257b38939746bd6 (0x7fd17a17035d)\n             at src/errors/mod.rs:1765: indy::services::pool::request_handler::RequestSM<T>::handle_event::h63fb19b42535a0df (0x7fd179d4d9f4)\n             at src/services/pool/request_handler.rs:364
6: <indy::services::pool::request_handler::RequestHandlerImpl<T> as indy::services::pool::request_handler::RequestHandler<T>>::process_event::{{closure}}::hab53773ac4e46f1c (0x7fd179d5842d)\n             at src/services/pool/request_handler.rs:622
7: core::option::Option<T>::map::h8e11bd3fb7b3981b (0x7fd179b20dcf)\n             at /rustc/a53f9df32fbb0b5f4382caaad8f1a46f36ea887c/src/libcore/option.rs:416
 8: <indy::services::pool::request_handler::RequestHandlerImpl<T> as indy::services::pool::request_handler::RequestHandler<T>>::process_event::h28fac4cb6cebdb0a (0x7fd179d57ec9)\n             at src/services/pool/request_handler.rs:622
9: indy::services::pool::pool::PoolSM<T,R>::handle_event::h7a7d9526b494d8f2 (0x7fd17a197831)\n             at src/services/pool/pool.rs:418
10: indy::services::pool::pool::PoolThread<S,R>::_loop::{{closure}}::hb7030ac703f5e14a (0x7fd17a19b8be)\n             at src/services/pool/pool.rs:553
11: core::option::Option<T>::map::h83294b96dc461cf1 (0x7fd179b1e8a6)\n             at /rustc/a53f9df32fbb0b5f4382caaad8f1a46f36ea887c/src/libcore/option.rs:416
12: indy::services::pool::pool::PoolThread<S,R>::_loop::h0f33ec02ed512347 (0x7fd17a19b69b)\n             at src/services/pool/pool.rs:553
13: indy::services::pool::pool::PoolThread<S,R>::work::hc62463fb7db19b6e (0x7fd17a19b31c)\n             at src/services/pool/pool.rs:541
14: indy::services::pool::pool::Pool<S,R>::work::{{closure}}::hdc37d4c38b7f2708 (0x7fd17a19aebc)\n             at src/services/pool/pool.rs:506
...

@AxelNennker I've tried to run this PR on my machine locally and can reproduce the problem + have some thoughts to discuss with team. Most probably we will be able to schedule appropriate ticket in our next sprint


Unit tests

Logic can probably be stolen from https://github.com/Esri/angular-esri-map/blob/583808bf9b692298a4df464a5a5dff7a9f82200e/test/unit/core/esriLoader.spec.js
What lib to use?

resolved in #19


Allow SSH agent key management

Today when deploying with --multi-node the user is forced to provide a path to the SSH key for remote accessing the node. We should allow that field to be empty so the SSH agent can try to figure out the key to access the node by itself. This seems to be supported by k0sctl:
- role: worker
   ssh:
   address: <IP_ADDRESS>
   user: crdant

We could add an option to the SSH key selection that reads: (leave blank to use SSH agent). Upon selecting this HelmVM will remove the key path section from the configuration.

Moved to Shortcut.


Unable to make iOS build on MacOS

Build/Submit details page URL
No response
Summary
For the last couple of weeks, I have been facing an issue with EAS builds, whenever I try to make a new iOS build it first gives me a message to upgrade the EAS-CLI package even though I already have the latest one installed, and when it tries to register the bundle identifier it gives a weird error.
I have tried with multiple bundle identifiers, and the error remains the same.
Managed or bare?
Managed
Environment
ibrahimarif@Ibrahims-MacBook-Pro ESL-Wombat % sudo npx expo-env-info
expo-env-info 1.2.0 environment info:
System:
OS: macOS 14.4.1
Shell: 3.2.57 - /bin/sh
Binaries:
Node: 20.11.1 - /usr/local/bin/node
Yarn: 1.22.17 - /usr/local/bin/yarn
npm: 10.2.4 - /usr/local/bin/npm
SDKs:
iOS SDK:
Platforms: DriverKit 23.4, iOS 17.4, macOS 14.4, tvOS 17.4, visionOS 1.1, watchOS 10.4
IDEs:
Android Studio: 2021.1 AI-211.7628.21.2111.8193401
Xcode: 15.3/15E204a - /usr/bin/xcodebuild
npmPackages:
expo: ~51.0.4 => 51.0.4
react: 18.2.0 => 18.2.0
react-native: 0.74.1 => 0.74.1
npmGlobalPackages:
eas-cli: 9.0.3
Expo Workflow: managed

ibrahimarif@Ibrahims-MacBook-Pro ESL-Wombat % sudo npx expo-doctor
✔ Check Expo config for common issues
✔ Check package.json for common issues
✔ Check native tooling versions
✔ Check dependencies for packages that should not be installed directly
✔ Check for common project setup issues
✔ Check for issues with metro config
✔ Check npm/ yarn versions
✔ Check Expo config (app.json/ app.config.js) schema
✔ Check that native modules do not use incompatible support packages
✔ Check for legacy global CLI installed locally
✔ Check that packages match versions required by installed Expo SDK
✔ Check that native modules use compatible support package versions for installed Expo SDK
Didn't find any issues with the project!
Error output
**✖ Failed to register bundle identifier XXX
Received an internal server error from Apple's App Store Connect / Developer Portal servers, please try again later
This request can not be processed right now - Service not available because of maintenance activities, please try again after some time.
    Error: build command failed.is**

Reproducible demo or steps to reproduce from a blank project
this happens when I try to make a new build for a new Expo project on SDK 50 or 51.
the command I'm using is: eas build -p ios -- profile production
And if I use the same command on a Windows laptop with the same project it works fine.

what is the output of the eas --version command on your machine?

Hello @Ibrahim-Arif,
Is this problem solved?

Hello @Ibrahim-Arif, Is this problem solved?

Yes, it turned out I had 2 versions of EAS installed on my Mac, one was latest and second was very old version in the global packages folder, so i uninstalled the old version and now using the latest version which works well.

Yes, like me , i used where eas , and i found 3 install from same package,I removed it, and then install it again, and it works now.
Thank you


chore: move to 0.8.41-SNAPSHOT

Review and merge this PR to move the release branch to the next micro SNAPSHOT.
Afterward, delete the branch that this PR is based on.
(Typically a button appears on this page once the PR is merged.)

Not creating a release branch this time.


Call hierarchy duplicate entries

testing #85924

VSCode Version: 1.41.0-insider (9785578)
OS Version: macOS Mojave

Steps to Reproduce:

https://github.com/jrieken/demo-callhierarchy
open sample/test.abc
show or peek call hierarchy

Not sure if this is from the extension or what but definitely unexpected.

Does this issue occur when all extensions are disabled?: Yes/No

I'd say that's my dummy extension... I will take a look but you can double check with the other (better) sample that we have

Yes its fine in the other extension. Fine to close unless there's something odd there.

yeah - closing. I already invested too much in my abc-lang


Simple lint edits commits for dcegm.py

it still gets
dcegm.py:155:25: E712 comparison to False should be 'if cond is False:' or 'if not cond:' dcegm.py:161:26: E712 comparison to False should be 'if cond is False:' or 'if not cond:' dcegm.py:175:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

I think we'd better leave this for @pkofod's judgment tomorrow.  Thanks!

I'm going to go ahead and merge it.  I'll flag it so we can follow up and fix the last E712 errors once we hear back from Patrick.

OK, sounds good.

Thanks! Wrt the other things, I'd have to check first that it works with numpy arrays.


v0.8.5_27: No small pop up screen is displayed on full screen (Safari 8)

SEVERITY: Major
MODULE: Mountain Chart
Platform:  MAC / Safari 8.1
RELEASE: v0.8.5
STEPS TO REPRODUCE:

Navigate URL: http://static.gapminderdev.org/vizabi/release/v0.8.4/preview/Mountainchart.html
Mountain chart page will be loaded
Click “Full” button under RESPONSIVENESS
Now click “X and Y” or “Color”
Note that  no small pop up screen is displayed by clicking the options

ACTUAL RESULTS:
No small pop up screen is displayed by clicking the options full screen view
EXPECTED RESULTS:
Small pop up screen should be displayed by clicking options available on the chart
SCREENSHOT:

Retest Result: Fail
Testing Environment: http://static.gapminderdev.org/vizabi/develop/preview/bubblechart.html

https://github.com/Gapminder/vizabi/pull/873

Retest Result: Pass
Platform:  MAC / Safari 9.0.1
Testing Environment: http://static.gapminderdev.org/vizabi/develop/preview/mountainchart.html

Retest Result: Fail
Platform:  MAC / Safari 9.0.1
Testing Environment:
1) http://static.gapminderdev.org/vizabi/develop/preview/mountainchart.html
2) http://static.gapminderdev.org/vizabi/release/v0.8.8/preview/bubblechart.html

It works for me if I refresh the page after clicking Fullscreen

https://github.com/Gapminder/vizabi/pull/970

Thought it was fixed, but it didn't actually.


Fix unit tests when run on MS-Windows

See https://issues.jboss.org/browse/UF-463

@bbrodt thanks for your changes. Two minor comments.
Also, you have to rebase your PR and more important do a sanity check with linux + workbench in order to make sure that doesn't break on *nix environments.
@manstis could you please also take a look on this?
Thanks.

Any news on this one? I would be great to have a green build also on Windows.

@ederign any news on this?

I can't merge this mess - too much water under the bridge. I'm closing this PR and creating a new one.


Error thrown in juiceContent() is not an instance of Error

... but a plain string, in my case simply for example 8: ")" not found.
I expect it to be an instance of error with all it's features like stack etc.

@binarykitchen I'm not sure where this error is coming from, it might just be bubbling up from a dependency. If you can post a sample that can reproduce the error, it could potentially be patched in juice or in the relevant dependency.

i cannot remember, this ticket is almost one year old ...


Enable data download should be turned off by default

After uploading a new layer, "Enable data download" is toggled on. Administrators should be forced to deliberately turn that on to explicitly indicate that they want data downloadable.

this can now be controlled on a project-level setting


Customised

You should probably close this pull request. You're trying to put your own personal information into the publicly shared template.
You also should add .idea to your .gitignore!

@anipmehta dude seriously. Close this.

Sorry @jimcullenaus. Didn't knew I was pushing to a pull request


Git submodules for smart home schemas

If there's another repository to get the schemas, import through a submodule. If there is not another repo, ignore this.

This was addressed in pr #29


Fix map Volen channels.

Turn off sandbox mode when playing in camping.

Why close?

this issue was already fixed, I am unable to go onto your device and remove the map file however so volen still has infinite resources
to fix this, locate the map file in your storage and delete it

I try.
сб, 7 мая 2022 г. в 15:35, Sh1penfire @.***>:

this issue was already fixed, I am unable to go onto your device and
remove the map file however so volen still has infinite resources
to fix this, locate the map file in your storage and delete it
—
Reply to this email directly, view it on GitHub
https://github.com/Sh1penfire/Endless-Rusting/issues/7#issuecomment-1120202346,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARS346OCC5TNPJVTYY36RBLVIZPPZANCNFSM5VKC6Z6A
.
You are receiving this because you authored the thread.Message ID:
@.***>

This version just for 126.2 or can use for 135?
сб, 7 мая 2022 г. в 16:21, 1 3 @.***>:

I try.
сб, 7 мая 2022 г. в 15:35, Sh1penfire @.***>:

this issue was already fixed, I am unable to go onto your device and
remove the map file however so volen still has infinite resources
to fix this, locate the map file in your storage and delete it
—
Reply to this email directly, view it on GitHub
https://github.com/Sh1penfire/Endless-Rusting/issues/7#issuecomment-1120202346,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARS346OCC5TNPJVTYY36RBLVIZPPZANCNFSM5VKC6Z6A
.
You are receiving this because you authored the thread.Message ID:
@.***>

In map folder - not have Volen channel.
[image: image.png]
сб, 7 мая 2022 г. в 15:35, Sh1penfire @.***>:

this issue was already fixed, I am unable to go onto your device and
remove the map file however so volen still has infinite resources
to fix this, locate the map file in your storage and delete it
—
Reply to this email directly, view it on GitHub
https://github.com/Sh1penfire/Endless-Rusting/issues/7#issuecomment-1120202346,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARS346OCC5TNPJVTYY36RBLVIZPPZANCNFSM5VKC6Z6A
.
You are receiving this because you authored the thread.Message ID:
@.***>


fork scheduled workfows

each fork of prima runs scheduled workflows on its own, thats unnecessary and may slow users own workflows
this is a known issue
https://github.com/orgs/community/discussions/16109
the solution would be adding a condition for each job:
if: github.repository == 'libprima/prima'

Hi @jschueller ,
I agree that it is an issue. It would be desirable if there was a systematic way to specify the repo where a workflow should run. However, doing it on the job level seems not ideal.
The solution I suggest for the moment is to disable the workflow manually.
Also, I would like to remark that all workflows with a cron schedule are disabled by default on forks.

sorry, but that's not what I experienced on my fork: scheduled workflows ran there too  slowing down my own jobs from my other repos

sorry, but that's not what I experienced on my fork: scheduled workflows ran there too slowing down my own jobs from my other repos

There is probably a bug on the GitHub side. I also experienced that some scheduled workflows are enabled unintendedly, but I cannot reproduce the problem. If you can, you may report to GitHub.
For the moment, the solution is to disable the workflows manually.
Thank you.

the issue has been reported:
https://github.com/orgs/community/discussions/16109
the solution is to explicitely disable it via a job condition:
https://github.com/libprima/prima/pull/94

I guess it was reported befor GitHub implements "disable scheduled workflows on forks by default".
The (new) problem is, the implementation seems not always work.
Thanks.

seems its disabled now on new forks

Great. Thanks.
I still observe from time to time that they are enabled on some forks. But I have not recognized the pattern yet. So do not be surprised if they come back ...


[Breaking Change]s cross-version reports missing paths that were moved to another file

The Breaking Changes (cross-version) check in PR 24249 is flagging many "RemovedPath" issues for paths that were moved to a different file.
The PR moves a number of paths from the MachineLearningServices.json file to workspaceRP.json file. The readme.md was updated to add the new workspaceRP.json file to the new tag. But the PR check flags them as missing.
Take the first two issues:
- RemovedPath '/providers/Microsoft.MachineLearningServices/operations'
- RemovedPath '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}'

Both paths are present in workspaceRP.json.

Per chat with Mike, this might be hard to fix, because we would have to scan way more files.

This likely related to:

https://github.com/Azure/azure-sdk-tools/issues/7904
https://github.com/Azure/azure-sdk-tools/issues/7786


Screenshot shows old content

The screenshot below the "Retrieve Teams data from the audit log" shows an old version of the admin center I think this could confuse people looking for how to find things.

Dokumentdetails
⚠ Bearbeiten Sie diesen Abschnitt nicht. Er ist für die Verknüpfung von docs.microsoft.com zum GitHub-Artikel erforderlich.

ID: 37e51e97-ff97-c5eb-6517-21ce9a563ca4
Version Independent ID: d3dc21b2-d90a-fbe7-8473-fff0b55feafb
Content: Suchen nach Überwachungsprotokoll für Ereignisse in Microsoft Teams
Content Source: Teams/audit-log-events.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@svenseidenberg Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Solving and updating issue #2630 with PR #2746

@svenseidenberg Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Reviewer GitHub handles render on top of re-request review buttons

Hate to be that guy with a long name, but I see this with the pending indicator still.

Filed https://github.com/microsoft/vscode-pull-request-github/issues/4672 for that. Marking verified for this specific issue


Fix macOS deprecated API

Bug/issue #, if applicable:
Summary
Fix deprecated FileHandle.readDataToEndOfFile, Process.launch and Process.launchPath API on macOS since they can be removed at a future release.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Ran the ./bin/test script and it succeeded

Thanks for opening this @Kyle-Ye. Since the blocking PR has been merged, can you please rebase, and I'll kick off CI again here? Also, I filed https://bugs.swift.org/browse/SR-15428 to track the issue you're resolving

Thanks for opening this @Kyle-Ye. Since the blocking PR has been merged, can you please rebase, and I'll kick off CI again here? Also, I filed bugs.swift.org/browse/SR-15428 to track the issue you're resolving

Done with rebase. Could you help me run test on this again? Thanks

@swift-ci please test

Thanks @Kyle-Ye! I will merge this


Bug in version 1.39: vscode reports "no debug adapter found" when click "start without debugging"

VSCode Version: Latest
OS Version: win10

Steps to Reproduce:

Create a python file

print("hello")

Click "Start without debugging".

Then vscode reports "no debug adapter found"

Does this issue occur when all extensions are disabled?: Yes/No
No
This is the log:
[2019-10-11 20:21:21.113] [renderer1] [error] no debug adapter found: Error: no debug adapter found
    at t.RawDebugSession.handleErrorResponse (file:///C:/Users/zjli1/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2751:326)
    at Promise.then.e (file:///C:/Users/zjli1/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2750:738)
    at process._tickCallback (internal/process/next_tick.js:68:7)

I have downgrade vscode to 1.38, and the error disappears.

Please file this against the python extension https://github.com/microsoft/vscode-python

@isidorn  Thanks for your response.

After downgrade vscode to 1.38, the error has gone.
The output panel of the python extension has no error information.
the log I posted above has not mentioned python extension

So I think the issue is more likely related to the vscode itself.

@isidorn Why did you close this issue? VSCode 1.39 broke a lot of 3rd party debug extension. We have the same problem with PlatformIO IDE Debugger. I tried to resolve this issue and don't have idea what VSCode wants from me.
notificationsAlerts.ts:38 Error: no debug adapter found
    at t.RawDebugSession.handleErrorResponse (rawDebugSession.ts:693)
    at Promise.then.e (rawDebugSession.ts:665)

Everything works great with VSCode <1.39

You are correct, this is an issue on the vscode side. And I can not repro with Node, but only with Python.
Problem being the start without debugging usually finishes fast and the debug adapter goes down before we can send the configurationDone request. When we try to send the configuratinoDone request the adapter is already down thus the error message.
Since this is only an error shown, and the start without debugging still works this is not a candidate, and we will ship the fix only to the insiders, not to the recovery release. The stable release will have the fix in one month.
Please use vscode insiders if you would like us to catch breakaeges like this earlier. Thanks
fyi @DonJayamanne

@isidorn thanks for the fast fix!

Please use vscode insiders if you would like us to catch breakaeges like this earlier.

Yes, I know :( This is the 3rd time when something is broken with a new release. We need to add some reminders to test our base functionality with each new release.

@isidorn Thanks for the fix!!!

no error reported when using "start without debugging" for a Python program.


undefined method `key?' for nil:NilClass

Cookbook version
2.1.0
Chef-client version
Chef: 12.16.42
Platform Details
Windows 2012 R2
Scenario:
Trying to run cookbook 'ms_dotnet35'.  Was replicated with other cookbooks as well.
Steps to Reproduce:
install cookbook ms_dotnet35.
run chef-client -z -o 'ms_dotnet35::default'
Expected Result:
Executes cookbook ms_dotnet35 installing .net 3.5
Actual Result:
Error (see below).
This was reproduced with other cookbooks that use windows cookbook as well.  By rolling back to 2.0.2 the issue goes away.
================================================================================
Error executing action `install` on resource 'windows_feature[NetFx3]'
================================================================================

NoMethodError
-------------
undefined method `key?' for nil:NilClass

Resource Declaration:
---------------------
# In c:/windows/temp/Bisque/SqlServer/MssqlserverDefault/chefcache/cache/cookbooks/ms_dotnet35/recipes/default.rb

 23:     windows_feature 'NetFx3' do
 24:       action :install
 25:       all true
 26:       not_if { ::File.exist?('C:/Windows/Microsoft.NET/Framework/v3.5') }
 27:     end
 28:   else

Compiled Resource:
------------------
# Declared in c:/windows/temp/Bisque/SqlServer/MssqlserverDefault/chefcache/cache/cookbooks/ms_dotnet35/recipes/default.rb:23:in `from_file'

windows_feature("NetFx3") do
  provider LWRP provider windows_feature_dism from cookbook windows
  action [:install]
  retries 0
  retry_delay 2
  default_guard_interpreter :default
  declared_type :windows_feature
  cookbook_name "ms_dotnet35"
  recipe_name "default"
  all true
  feature_name "NetFx3"
  not_if { #code block }
end

Platform:
---------
i386-mingw32

We're seeing this in the acceptance tests for chef-client in the 'top-cookbooks' test as well.

The windows default recipe is required with the dism changes that went in. Our tests missed this since they include that default recipe. I'm going to change things so the default recipe isn't necessary for the plugin to work.

This should be fixed in #411

This is fixed in the 2.1.1 release. Thanks for the report. The tests have been updated so we'll catch this in the future.

@tas50 I'm using the 2.1.1 release and I'm still getting this.

@nozpheratu can you share the stacktrace?

@btm Sure. I'm using dism.
windows_feature "Remote-Desktop-Services" do
  action :install
  not_if {reboot_pending?}
end

-----> Starting Kitchen (v1.14.0)
-----> Converging <default-mwrock-Windows2016>...
       Preparing files for transfer
       Preparing dna.json
       Resolving cookbook dependencies with Berkshelf 5.2.0...
       Removing non-cookbook files before transfer
       Preparing validation.pem
       Preparing client.rb
-----> Chef Omnibus installation detected (12.5.1)
       Transferring files to <default-mwrock-Windows2016>
       Starting Chef Client, version 12.5.1
       resolving cookbooks for run list: ["remote-vrt::default"]
       Synchronizing Cookbooks:
         - remote-vrt (0.1.0)
         - windows (2.1.1)
         - powershell (5.1.0)
         - ohai (4.2.2)
         - ms_dotnet (3.1.0)
         - chef_handler (2.0.0)
         - compat_resource (12.16.2)
       Compiling Cookbooks...
       Converging 3 resources
       Recipe: remote-vrt::default
         * user[guest2] action create (up to date)
         * group[Remote Desktop Users] action modify (up to date)
         * windows_feature[Remote-Desktop-Services] action install
           * ohai_plugin[dism_features] action create[2016-11-29T22:37:31+00:00] WARN: The Ohai plugin_path does not include C:\Users\vagrant\AppData\Local\Temp\kitchen/ohai/plugins. Ohai will reload on each chef-client run in order to add this directory to the path unless you modify your client.rb configuration to add this directory to plugin_path. See 'Ohai Settings' at https://docs.chef.io/config_rb_client.html
       [2016-11-29T22:37:31+00:00] WARN: Adding C:\Users\vagrant\AppData\Local\Temp\kitchen/ohai/plugins to the Ohai plugin path for this chef-client run only

             * directory[C:\Users\vagrant\AppData\Local\Temp\kitchen/ohai/plugins] action create (skipped due to not_if)
             * cookbook_file[C:\Users\vagrant\AppData\Local\Temp\kitchen/ohai/plugins/dism_features.rb] action create (up to date)
             * ohai[dism_features] action reload
        - re-run ohai and merge results into node attributes

           ================================================================================
           Error executing action `install` on resource 'windows_feature[Remote-Desktop-Services]'
           ================================================================================

           NoMethodError
           -------------
           undefined method `key?' for nil:NilClass

           Resource Declaration:
           ---------------------
           # In C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/cookbooks/remote-vrt/recipes/default.rb

            23: windows_feature "Remote-Desktop-Services" do
            24:   action :install
            25:   not_if {reboot_pending?}
            26: end
            27: # reboot "reboot" do

           Compiled Resource:
           ------------------
           # Declared in C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/cookbooks/remote-vrt/recipes/default.rb:23:in `from_file'

           windows_feature("Remote-Desktop-Services") do
             provider LWRP provider windows_feature_dism from cookbook windows
             action [:install]
             retries 0
             retry_delay 2
             default_guard_interpreter :default
             declared_type :windows_feature
             cookbook_name "remote-vrt"
             recipe_name "default"
             feature_name "Remote-Desktop-Services"
             not_if { #code block }
           end

       Running handlers:
       [2016-11-29T22:37:39+00:00] ERROR: Running exception handlers
       Running handlers complete
       [2016-11-29T22:37:39+00:00] ERROR: Exception handlers complete
       Chef Client failed. 2 resources updated in 31 seconds
       [2016-11-29T22:37:39+00:00] FATAL: Stacktrace dumped to C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/chef-stacktrace.out
       [2016-11-29T22:37:39+00:00] FATAL: NoMethodError: windows_feature[Remote-Desktop-Services] (remote-vrt::default line 23) had an error: NoMethodError: undefined method `key?' for nil:NilClass
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: 1 actions failed.
>>>>>>     Converge failed on instance <default-mwrock-Windows2016>.  Please see .kitchen/logs/default-mwrock-Windows2016.log for more details
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration

Not sure if this is related, but I can see that the "Remote-Desktop-Services" feature shows up as "Disabled" when I run the dism cmd executable. Would that have anything to do with it?

Was it pulled yet?  I could not find evidence that it was pulled yet, but
I'm not sure
On Nov 29, 2016 5:32 PM, "Bryan McLellan"<EMAIL_ADDRESS>wrote:

@nozpheratu https://github.com/nozpheratu can you share the stacktrace?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chef-cookbooks/windows/issues/409#issuecomment-263721879,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACtJ7jUuJB8J7Wd48lFyEHCF1LcuFwZYks5rDKgJgaJpZM4K6F0l
.

@hounddog22030 Seems to be, but doesn't seem to fix the issue.

must be coming from either https://github.com/chef-cookbooks/windows/blob/d144f3ecfc8c33473aacf6ec57fa7ac92cc3126c/providers/feature_dism.rb#L65 or https://github.com/chef-cookbooks/windows/blob/d144f3ecfc8c33473aacf6ec57fa7ac92cc3126c/providers/feature_dism.rb#L56.
Seems like the ohai plugin must not be setting the dism_features

Here's my .kitchen.yml if it helps to reproduce the bug:
---
driver:
  name: vagrant
  require_chef_omnibus: 12.5.1

provisioner:
  name: chef_zero

platforms:
  - name: mwrock/Windows2016
    transport:
      name: winrm
      max_threads: 1
    driver_config:
      network:
      - ["forwarded_port", {guest: 3389, host: 9833}]

suites:
  - name: default
    run_list:
      - recipe[remote-vrt::default]
    attributes:
      windows:
        feature_provider: 'dism'

The Chef recipe is simply:
# install RDS
windows_feature "Remote-Desktop-Services" do
  action :install
  not_if {reboot_pending?}
end

@nozpheratu this is caused by running with chef v12.5.1. You will have better luck running with an updated chef client or pinning to a v1 windows cookbook version.


Implementation of Webvision

Hi,
Sorry, I haven't found the implementation for Webvision. I don't know if I missed something.
Best.

I have uploaded the code. You can run it now.


container can't fully access internal site

I have created a new hyper-v vm using Ubuntu 18.04. I've installed docker, and pulled the images for selenoid/selenoid-ui,ggr and created a docker-compose file. We currently have an internal firewall, so I installed the certificate onto the ubuntu vm. When I open Firefox inside of Ubuntu, I can access all of our internal websites. However, when I execute a test through selenoid/ggr, it can access some of the sites but I get the following error on chrome when it tries to navigate to one of our other internal sites: internaldomainx.com's server IP address could not be found.
err_name_not_resolved
Try:

Checking the connection
Checking the proxy, firewall, and DNS configuration.

Even though I can access all of our internal sites from the Ubuntu vm, I tried adding the DNS servers to the docker-compose file but still it breaks.
please advise

You have to configure docker daemon and pass to it dns list via --dns
option or daemon.json, please refer to docker docs:
https://docs.docker.com/engine/reference/commandline/dockerd/
2018-06-06 20:45 GMT+03:00 ed84<EMAIL_ADDRESS>
I have created a new hyper-v vm using Ubuntu 18.04. I've installed docker,
and pulled the images for selenoid/selenoid-ui,ggr and created a
docker-compose file. We currently have an internal firewall, so I installed
the certificate onto the ubuntu vm. When I open Firefox inside of Ubuntu, I
can access all of our internal websites. However, when I execute a test
through selenoid/ggr, it can access some of the sites but I get the
following error on chrome when it tries to navigate to one of our other
internal sites: internaldomainx.com's server IP address could not be
found.
Try:

Checking the connection
Checking the proxy, firewall, and DNS configuration.

Even though I can access all of our internal sites from the Ubuntu vm, I
tried adding the DNS servers to the docker-compose file but still it breaks.
please advise
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aerokube/selenoid/issues/462, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWNbX7TKiRbG3XNAZJMOrWHVwi_dN7-ks5t6BUqgaJpZM4UdFX6
.

thank you sir!

@ed84 Were you able to resolve this issue ? I know its been long time but I am facing the same issue.
Could you guide me as well. Thanks


fix: fix a few typos and formatting errors

Looks great overall. After all conversations are resolved, this should be merged asap.

@Esinko this could probably be merged?

Yup


1 fix, couple additions

fix bug in str implementation
make Properties a collections.abc.MutableMapping instance
implement python setup.py test
use pytest as test runner/framework
implement save method

This looks great. I'll merge it soon.

Your author and committer have a mismatch in name and email, could you let me know which one it is you want to use?

Please use the author (ie the account I'm using to make this comment)
thanks!

Rebased, fixed and landed. I also added my usual pattern for tests and setup.
If you have more PRs coming, let me know, otherwise I'll probably do a 1.0 release.


release 27.09.2022 v2

:tada: This PR is included in version 1.0.30 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


15 remove unregistered users based on moderation list

Uses a designated moderation list to remove registered users from the feed. Periodically syncs the list  in an async task when running the primary indexer.

I've been running this locally without issue but I would like to add some unit tests before merging into the Jetstream branch.


Trace Instrumentation Library

This is the first iteration of the trace instrumentation library.  It will allow automatic tracing of requests based on a QPS sample rate and also allow forced tracing when the proper headers are set.  This only provides information about the incoming request and does not provide additional trace information about specific method execution unless specifically requested.
I am working on the unit tests for this but will wait to send them until this PR is closer to being checked in.
One part of this I am not entirely happy with and would appreciate feedback on is the RateLimiter class. I'm worried it may cause performance issues.  A less accurate RateLimiter that does not need to lock may be a better choice.

(I'll wait until you've responded to Mike's comments before continuing with my review.)

Thanks for the feedback Mike. PTAL

Thanks, PTAL

@jskeet Friendly ping

Will look in the morning. Wasn't sure you and Mike had finished.

As for tests I have most of everything tested.  Once this is merged I will send a PR for them
https://github.com/iantalarico/google-cloud-dotnet/tree/trace-unit-tests/apis/Google.Devtools.AspNet/Google.Devtools.AspNet.Tests/CloudTrace


Created dashboard mockup

Incorporated necessary features for dashboard such as:

Lessons
Quizzes
Profile
Streak Tracker
Point System
Badges

May need to play around with the colour scheme when implementing the front-end later

Hey Mithun I think you accidentally added assignees instead of reviewers


2D Example

Create a 2D example with all the structure that is in the 3D example including:
-> Personal inventory
-> Loot inventory
-> Pick up items
-> Drop items

[ ] The example must reuse the items from the FPS example, but recreating the database and putting in place of dropped_item and hand_item 2d scenes that represent the item in the 2D dimension.

[ ] Must create a player with interactions with 2D versions to open loots and pick up items
(Maybe because of proximity)

[ ] Add example in 2D folder in the project demo

Notes:

It should reuse the entire FPS UI, with no need to change scenes or codes.

Use some top-down example, reference some godot demo project.
https://github.com/godotengine/godot-demo-projects/tree/master/2d

plz assign me to this issue , i want to contribute to this issue . i am a completely newbie plz guide me for what i have to do.

Perfect, I assign you this task, it's good if you are a beginner, so it can be clear which points the inventory system is not intuitive for new users.


Internationalisation - french translation

Changes proposed in this pull request:

translate-ui.csv french language added
help-tags.csv partial  french language added

@Stephen-Gates @mattRedBox

Thanks @4estone still investigating getting this into scope.

Hi eveybody, I'm back on this project after some time spent on other things.
Coul'd you help me to understand / solve conflict on pull request?

It seems @MattRedBox has left the project. Perhaps @cofiem or @hoylen may be able to help. I haven't worked on this for 3+ years.


Docmanifest

Hey @shonin
I converted your README into new documentation, added some documentation on contributing to your current README.MD and added some reference tags.

@ChristopherLandaverde this is brilliant. thank you so much for doing this. I'm going to do some organizational changes in a separate PR. This is exactly the help I needed.

👍


this should fix issue with early deletion of mosek Task objects

Changes should resolve issues in #500 and #497 . I have tested with mosek 8 and 9, with both nosetests and running cvxpy/examples/tsp_mip.py.

Coverage decreased (-2.8%) to 80.358% when pulling a05c5a4cddfb0eeb04ebddafdb92e00ec8cdebb2 on rileyjmurray:master into edc371b9dc395c699fe7b0c3760dfd43ea9331a7 on cvxgrp:master.

Hi Riley, what is the current plan for this PR? It's not the end of the world if we need to put out a simple patch to fix the Mosek issue and deal with other challenges later.

I'm working on it today. Goal is to get automated pypi deployment to work (but to do this only when the version number updates).

Should be ready to merge. As long as appropriate environment variables are set in the Travis CI website, a single commit that bumps version should result in automatic deployment to anaconda and pypi (for mac and linux).

Awesome!


C99/C++98 standard compliance

Currently, there are no barriers in place for using compiler extensions. This makes it difficult to know when code is inherently unportable. Allowing compiler extensions hurts reproducibility across toolchains.
From previous discussions these appear to be our target standards:

C99
C++98 (C++11 is unsupported in IAR)

Here is a quick checklist of what is needed to bring mbed up to compliance:

strict c99/c++98 flags in gcc
strict c99/c++98 flags in armc5
strict c99/c++98 flags in iar
compile in gcc
compile in armc5
compile in iar
warning free in gcc
warning free in armc5
warning free in iar

Previous issue: ARMmbed/mbed-os#241

Sorry for the redundant issues, I got confused by github site problems.
https://github.com/mbedmicro/mbed/issues/2152


[BUG] Multiple notes outline doesn't follow light / dark mode

When I switch between light and dark mode, Multiple Notes Outline stays in the previous mode until I close and reopen the pane.

Multiple Notes Outline version: 0.1.4
Obsidian: 1.4.13
Theme: Prism

Thank you for using the plugin 😄
It is a specification at this time that the folder background color does not immediately change when switching between light and dark modes. Sorry about that.
However, it should be fixed by redrawing the view by clicking the leftmost icon in MNO view (update view), without restarting the MNO view. Does this not work?
Either way, I will look into a way to instantly reflect the light/dark mode.

Either way, I will look into a way to instantly reflect the light/dark mode.

Sorry to bother you, but it would be great if this got some attention, because as is, I close the Multiple notes outline sidebar every time I switch between light and dark mode. Especially going from light to dark mode, then Multiple notes outline is the only thing left that disturbs my vision. Otherwise, I would keep it open all the time.

Sorry for your inconvenience. I will try to improve it.
But again, I think clicking the reload button will fix the colors, but does not work well?
In your screenshot, it is an icon like 🔃 on the bottom left of the MNO view.
Not a real time change, but easier than closing and reopening the view.

Sorry for your inconvenience. I will try to improve it. But again, I think clicking the reload button will fix the colors, but does not work well? In your screenshot, it is an icon like 🔃 on the bottom left of the MNO view. Not a real time change, but easier than closing and reopening the view.

Hey, no worries, and I'm sorry, I actually forgot about the refresh button—that makes a lot more manageable! However, it still is a bit jarring going to dark mode with the white file list at first. But don't lose any sleep over it, it will manage with the refresh button for now.

In v0.2.0, MNO views should immediately reflect light/dark mode change.
I would appreciate it if you could let us know if there are any problems.

I would appreciate it if you could let us know if there are any problems.

No, this is working great for me now. Thanks a lot, I really appreciate it!


Setup issue

Hi there,
I tried to install your repo but I'm running into some issues.
I clone the repo and follow all the guidance for non docker installation.
I'm on Mac
when I run make setup during the setup process  I run into this issue:
WARNING in starspace_intent_classifier [/Users/atodorov/Desktop/Work/ai-chatbot-framework/app/nlu/classifiers/starspace_intent_classifier.py:587]:
Failed to load nlu model. Maybe path /Users/atodorov/Desktop/Work/ai-chatbot-framework/model_files doesn't exist
Traceback (most recent call last):
File "manage.py", line 3, in
from app import app

Dear Admin, Even im facing the same issue during setup process, im using Ubuntu 18.0+ and python 3.6. please help me

@vinodalladi
i'm facing the same issue, could you please help me out.
Thanks in advance.

i have the same problem


OSC Plugins page does not automatically refresh when a plugin is added or deleted

Description
OSC Plugins page does not automatically refresh when a plugin is added or deleted. User needs to hit 'refresh' sometimes twice, or go to a different page and then come back to the plugins page to see the plugin added or deleted.
Expected Behavior
The plugins page should be automatically refreshed.
Actual Behavior
Need to hit 'refresh' sometimes twice, or go to a different page and then come back to the plugins page to see the plugin added or deleted.
Steps to Reproduce
Testing OSC Centos - 2.6-4192
Delete Manager Plugins (NMS, SMC, ISM) and/or SDN Controller Plugins  (NSC or NSX). Upload them again using the corresponding Manager or SDN Controller Plugins.
The OSC UI Plugins page does not automatically refresh.
The message for a successful plugin being uploaded is received but I have to try couple of times to refresh the page.
NOTE - The attached screen shot will display the NSC SDN Controller plugin. However this is applicable for all plugins and for add and delete actions.

Experience the above issue with OSC Build - 1.0.0-SNAPSHOT (Build:41-gfd9b086, 2017-08-04T21:07:35Z) as well.
A related issue is that when I delete the ISM plugin, I get an INSTALL_WAIT State and the plugin is not deleted.
Keep hitting refresh, nothing happens.
But if you go to any other page and then come back to plugins page, the plugin is deleted.
Screenshot and logs attached.
Additional Information
DE3110 in Rally
Environment

OSC Version/Build: 2.6-4192, 1.0.0-SNAPSHOT (Build:41-gfd9b086, 2017-08-04T21:07:35Z)
Cloud Provider Info:
Plugin Info:
Other:

Status

[ ] Reproduced
[ ] In Progress
[ ] Validated     =>    Verified in Version/Build:

ISM-shows-install-wait-on-delete.txt

workaround is to refresh the page or move to a different page and get back to it.


Array index bug in revoke function of GroupAdmin

Description:
In GroupAdmin.sol, when owner revokes oldAdmins from the admins array，each address in oldAdmins is compared with address in admins. While in the for loop in line 35, the index of admins array, uint j is not updated because of the typo ++i, and it should be ++j.
    function revoke(address[] oldAdmins) public onlyOwner{
        for(uint i = 0; i < oldAdmins.length; i++){
            for (uint j = 0; j < admins.length; ++i) { // typo here!
                if (admins[j] == oldAdmins[i]) {
                    admins[j] = admins[admins.length - 1];
                    admins.length--;
                    emit AdminRevoked(oldAdmins[i]);
                    break;
                }
            }
        }
}

Impact:
This bug will make the call of revoke fail and some oldAdmins won't be revoked.
Without ++j, j will always be zero. if oldAdmins[0] != admins[0] , the for loop in line 35 won't break, thus variable i will eventually execeed the length of oldAdmins,  cause array out-of-bound and finally revert the evm state.
revoke function was added since commit 8e94db42
Fix:
for (uint j = 0; j < admins.length; ++j)

Also another tip: Instead of i & j, write better names like oldAdmIdx and newAdmIdx. Much harder to confuse old/new compared to i/j.


Remove vc-js library

Resolves:
https://github.com/docknetwork/sdk/issues/180
https://github.com/docknetwork/sdk/issues/194
Side effects of this PR: I added linting for tests and ran fix on them, they arent required to pass for CI but i think we should keep them cleaned too

I have opened this issue https://github.com/docknetwork/sdk/issues/196 to address incorrect de-referencing of properties, itll require a bit of logic reworking and maybe some test/example adjustment so will address in future PR


refactor tag-format constants to a separate package

Issue #, if available: https://github.com/aws-controllers-k8s/community/issues/1261
Description of changes:

Using tag-format constants inside pkg/config/config.go rather than hardcoded strings
Move the tag format definition into a separate package to avoid cyclic import between pkg/config & pkg/runtime

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Fix/error message when fail registration

@NicholasAzar @stevehu Hi, this PR is related to the error message when consul registration. I just let the server down by throwing an exception when consul registration fails so there would be no matter whether multiple ports are listening (what Frank reported). Look forward to your review! Thanks
The RFC related to this:
https://github.com/networknt/light-rfcs/blob/Fix/error-message-when-registration-failure/light-4j/0009-Fix-error-message-when-fails-to-register-in-consul.md

@jiachen1120 right now when the server can't bind to the configured port it won't exit

@jiachen1120 if consul is unavailable when the server is starting up, the server still starts up fine and binds to the port, however the following is continually output to the logs:
HOST IP null
12:06:57.409 [main] com.cibc.apif-hello-1   ERROR c.n.consul.client.ConsulClientImpl registerService - Exception:
java.net.ConnectException: Connection refused
	at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
	at org.xnio.nio.WorkerThread$ConnectHandle.handleReady(WorkerThread.java:321)
	at org.xnio.nio.WorkerThread.run(WorkerThread.java:561)
Http port disabled.
Https Server started on ip:<IP_ADDRESS> Port:8443
12:06:59.069 [pool-3-thread-1]    ERROR c.n.consul.client.ConsulClientImpl checkPass - CheckPass request exception
java.net.ConnectException: Connection refused
	at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
	at org.xnio.nio.WorkerThread$ConnectHandle.handleReady(WorkerThread.java:321)
	at org.xnio.nio.WorkerThread.run(WorkerThread.java:561)
12:07:19.078 [pool-3-thread-2]    ERROR c.n.consul.client.ConsulClientImpl checkPass - CheckPass request exception
java.net.ConnectException: Connection refused
	at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
	at org.xnio.nio.WorkerThread$ConnectHandle.handleReady(WorkerThread.java:321)
	at org.xnio.nio.WorkerThread.run(WorkerThread.java:561)
12:07:39.078 [pool-3-thread-3]    ERROR c.n.consul.client.ConsulClientImpl checkPass - CheckPass request exception
java.net.ConnectException: Connection refused
	at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
	at org.xnio.nio.WorkerThread$ConnectHandle.handleReady(WorkerThread.java:321)
	at org.xnio.nio.WorkerThread.run(WorkerThread.java:561)
Disconnected from the target VM, address: '<IP_ADDRESS>:57933', transport: 'socket'

Also, the RFC linked in the original comment in this pr is 404ing

Hey, the previous RFC has already been merged to
https://github.com/networknt/light-rfcs/blob/master/light-4j/0009-Fix-error-message-when-fails-to-register-in-consul.md

Make a fix that reserve the previous behavior. When binding is failed, don't throw RuntimeException to stop the server but simply log one line message without the stack trace to indicate the binding to the port is failed, try the next port. Then return false to indicate that binding is failed so that the next port will be tried. In the second try/catch block for the consul registration, a RuntimeException is thrown and the server will be stopped.
        } catch (Exception e) {
            System.out.println("Failed to bind to port " + port + ". Trying " + ++port);
            if (logger.isInfoEnabled())
                logger.info("Failed to bind to port " + port + ". Trying " + ++port);
            return false;
        }


Juliabox session timestamps running ~1 min fast

I just noticed that on starting a new session on juliabox.org, under 'Profile and session info', the timestamps seem to be a minute faster than the actual time. See 'Session initialized at:'
Small issue, but I thought it could cause some problems?

Those are based on server time, and it can possibly be different from your local machine time. I believe we do run NTP. And the time remaining display always displays it floored to the previous minute.
That shouldn't affect anything though.

Given I've observed my local machine time to be a lot more accurate to NIST time, I thought it was just worth noting. Perhaps NTP isn't working? But I agree that it's a very low risk issue, just thought I'd point it out if it's an easy fix.
Happy to close this if it's not worth the effort.

Thanks for catching this! It turns out that we are not running ntpd.
Fixed image will roll out with the next update.

heh! No worries.


SET SCHEMA docs

Fixes #8147.

This change is

@solongordon Assigning to you for triage, as I believe Rohan and Richard were the ones who worked on this.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3ac6c464639073830887da4532205db2e8a68fb8/
Edited pages:

v20.2/alter-sequence.md
v20.2/alter-table.md
v20.2/alter-view.md
v20.2/create-schema.md
v20.2/set-schema.md
v20.2/sql-statements.md


TLSv1.3 related changes to man pages

Add or update the documentation of the different man pages in relation to TLSv1.3 behaviour.

Checklist

[x] documentation is added or updated

@FdaSilvaYY thanks! fixed

@kaduk wrote:

I'm basically picking nits

no problem, it's almost necessary for documentation :)
all should be fixed now

I am in good situation ;-)
Since all commits are related to TLSv1.3 doc updating, I squashed all commits into one: 322755c - with the title 'TLSv1.3 related changes to man pages'...
@tomato42 thanks for the contribution!


Visibility- Map Point Tool vs Observer Map Point Tool for RLOS vs LLOS

The tooltip over the map point tools in linear line of sight are called observer map point tool and target map point tool respectively, whereas in the radial line of sight tab the observer map point tool is simply called the map point tool.
Expected Behavior
tooltip naming convention for both of these should be the same, preferably change the name of the radial line of sight tool to Observer Map Point Tool.

@nfeuerstein @Dbarnes1 Changed the tooltip for RLOS map point tool from Map Point Tool to Observer Map Point Tool. Pull request https://github.com/Esri/visibility-addin-dotnet/pull/106

@pHill5136 thank you!

@Dbarnes1 can we close this issue?

@topowright I just merged #106 so i'll verify in the next build

verified, closing


Installation issue conda error

Dear authors,
I am facing issue while attempting to install bcbio v129 on a HPC cluster with Linux RED HAT OS.
I have conda installed but I removed conda from my path to avoid conflict with bcbio installation.
How can I fix this issue?
Thank you in advance for your attention,
Kind regards,
Hanae
Here are the logs I get:
TypeError('not all arguments converted during string formatting')
TypeError('not all arguments converted during string formatting')
TypeError('not all arguments converted during string formatting')
TypeError('not all arguments converted during string formatting')
TypeError('not all arguments converted during string formatting')
Traceback (most recent call last):
File "bcbio_nextgen_install.py", line 304, in
main(parser.parse_args(), sys.argv[1:])
File "bcbio_nextgen_install.py", line 46, in main
anaconda = install_mamba(anaconda, args)
File "bcbio_nextgen_install.py", line 95, in install_mamba
subprocess.check_call([anaconda["conda"], "install", "--yes", conda_bin])
File "/usr/lib64/python3.6/subprocess.py", line 311, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/path-to-my-folder/apps/bcbio/v129/anaconda/bin/conda', 'install', '--yes', 'conda']' returned non-zero exit status 1.

Hi @hanaecarrie !
It looks like your installation is not isolated - it uses system python (you can see /usr/lib64/python3.6) which should be something like /path/apps/bcbio/v129/anaconda/bin/python).
The solution might be to add /path-to-my-folder/apps/bcbio/v129/anaconda/bin/ to your PATH to have it before your system python.
S.


Create and test querying the director for available namespaces

This is a followup from issue #81 and it's last line, which wasn't included in the unit test created for that issue:
Query the director for an object within the new origin's namespace. Ensure the response includes the newly registered origin.

Follow up on this issue and some breakdown of the tasks required:

Add a new function to return a list of origins the director contains
Use the newly created function to make a new test

Closed with #185 merged.


New instance when dropping a folder onto lite

as stated here:
https://github.com/rxi/lite/commit/7517d0ef552c89cc24e0589a8df8eb9648217e24#commitcomment-39879404
Gif showing the issue here:

Found the culprit:
https://github.com/tDwtp/lite/blob/1db1f0bcebd54878a0415deda91c92b6e03acbd3/data/core/init.lua#L345
(basically this was intentional?)
I am going to check on how to reload the RootView, so you don't to open a new instance.

As you pointed out this is intentional behaviour, it may be something which is tweaked in the future (for example: automatically closing the current instance if there are no documents open)

I am going to check on how to reload the RootView, so you don't to open a new instance.

Assuming you meant the TreeView (the RootView is the layout system). The TreeView is based around the "project directory". As a rule lite can have one project directory set, which is set at start up and cannot be changed without restarting lite. All parts of lite (including plugins) are allowed to assume this is the case -- changing the project directory once lite has initialised isn't something that will be supported.

I noticed I can't just change the TreeView without causing issues, so I wanted to reload the UI without reloading everything. good to know it won't work...


Investigate how to speed up end-to-end -tests in Github Actions

Priority 1 is to get end-to-end tests working, but when we have time, some optimizations could be done later. Ideas I have investigated:

Split up building services and databases to different jobs. Then cache stuff for next job
Run cypress in parallel, each job restoring services and databases from cache

Problems:

Problem here is that dockers build-push-action can only cache stuff with buildable dockerfiles. This isn't problem for services, but databases need to be handled differently. One possible solution would be to precreate images for anon databases and push the to some private registry. This could be for example in registry.toska.cs.helsinki.fi
docker has only experimental support for caching images built with docker-compose build
parallel running for cypress in support only by accounts that have cypress dashboard enabled

We're now running things in parallel with basic jobs. Action files are now quite verbose, but this works


Adds RSS/Atom blog Feed

Summary
Fixes #2277
Generates both rss and atom in the step in the convert step
Test plan
running yarn start

Current coverage is 89.23% (diff: 100%)

Merging #2378 into master will not change coverage

@@             master      #2378   diff @@
==========================================
  Files            39         39
  Lines          1486       1486
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1326       1326
  Misses          160        160
  Partials          0          0

Powered by Codecov. Last update 2a378d8...fc745ae


TTLCache - similar, but different?

Hey, I recall using TTLCache from cachetools before to achieve similar outcomes. I assume the functional difference is that TTLCache timer is per-item, whilst expiring cache timer is per-function?

Yes, I believe that's correct 😇


Open the alternate file in a new tab

Hi, is it possible to open the alternate file in a new tab instead of the same buffer?

Not right now, but it is really trivial to extend the plugin to support this case, customization should be implemented for this line in the plugin:
https://github.com/ton/vim-alternate/blob/57a6d2797b3bec39f5c075104082b0c0835535ed/plugin/alternate.vim#L48
When I have some time I might implement this functionality, otherwise I'm happy to accept any pull requests.

This has been implemented in master, use g:AlternateCommand to configure which Vim command is used to open an alternate file. For example, to open an alternate file in a separate tab, set this to tabnew.


tf.random.uniform array minval/maxval with dtype=tf.int*

Hi,
The current implementation of tf.random.uniform allows for non-scalar minval and maxval if dtype=tf.float32 (or tf.float64).  However, this is not the case for dtype=tf.int32 (or tf.int64).
e.g.
tf.random.uniform(shape=(), minval=[0, 0], maxval=[10, 10], dtype=tf.int32)
ValueError: minval must be a scalar; got a tensor of shape [2] ....

generates a ValueError whereas
tf.random.uniform(shape=(), minval=[0., 0.], maxval=[10., 10.], dtype=tf.float32)
tf.Tensor([5.918947 5.918947], shape=(2,), dtype=float32)

works as expected.
The documentation doesn't indicate that the integer version of tf.random.uniform has this restriction.  Is it expected behaviour, and if so what is the workaround?
Thanks,
Chris

TF version 2.3.0-dev20200521 (tf-nightly)
Python 3.7.6 (Anaconda 3)

@chrism0dwk The ValueError should be the correct behavior, as shape=() expect minval and maxval to be a scalar.
The behavior of the float32 type is actually incorrect, and should have thrown out the same error as well. The issue is being fixed in #34363 #38585

Ah, I see.  Thanks.  From the doc of minval and maxval, "for integer types, broadcasting is not supported, so it needs to be a scalar".  I guess this means that minval and maxval are therefore intended to be scalars at least for Uniform integers.


ImportError: cannot import name 'concat' from 'lightgbm.compat'

Version 3.3 on Mac
ImportError: cannot import name 'concat' from 'lightgbm.compat'
Please help!

Thanks for using LightGBM.
We need more information to help you. Please provide the following which were asked for in the issue template:

a minimal, reproducible example demonstrating how you are using LightGBM
the version of Python you are using
the version of LightGBM you are using (is 3.3... 3.3.0? 3.3.3?)
the exact commands you used to install lightgbm

And we will try to help.

Thanks for using LightGBM.
We need more information to help you. Please provide the following which were asked for in the issue template:

a minimal, reproducible example demonstrating how you are using LightGBM
the version of Python you are using
the version of LightGBM you are using (is 3.3... 3.3.0? 3.3.3?)
the exact commands you used to install lightgbm

And we will try to help.

I'm using version 3.3.0 because there was an error when I tried to install the latest version. It was installed through the PyCharm package manager.
Python version 3.10 on Mac OS 10.14.6
I'm new to python so I'm not sure if I'll be able to post a reproducible example. I can post screen shots if thats helpful.
Thanks!

Please don't post screenshots of code or logs here. Text is strongly preferred, so that others facing the same issue can find this discussion from search engines.
If you are unable or unwilling to provide a minimal, reproducible example then please at least share the code you are running, removing any details (e.g. commented-out code, extra lines after the one producing the error) unrelated to the error you're facing.

I'm trying to run a program called YASA that requires Lightgbm

That is not enough information for us to help you. If you cannot share the code you're running or some other similar code that results in this error, then you're asking for us to randomly guess.
I have one more guess, but otherwise we're going to close this is you can't provide more information.
Is your code in a file called lightgbm.py, or do you have a file called lightgbm.py in the same directory? That can cause something like import lightgbm to match that script instead of this library. Renaming the script would resolve the error if that's the situation.


fix: properly close context on worker script timeouts and crashes.

I noticed that PHP timeouts will fully stop the script's execution and not just continue to the next iteration in worker mode.
This PR fixes this issue in part by making sure the context gets closed if a worker request is still pending and the PHP script returned a non-zero status code.
To reproduce, just set max_execution_time = 2 in the php.ini and execute a worker script with sleep(3);. Ideally, timeouts would not stop the script execution (if that's even possible).

Hmmm... I think there must be an issue somewhere. In frankenphp.c it should set the timeout to 0.

It gets unset while waiting, but reset during request execution

The issue is, if it times out during execution, it will exit from the whole script, not just the current frankenphp_handle_request() execution.

This was intended. I'm not sure that it's the best behavior, but it looked more secure to me, especially because workers are restarted anyway.

@withinboredom on timeout it will not behave the same as on exit. On timeout it will stop the whole script and execution is continued after php_execute_script. This PR makes sure that the pending worker request gets properly closed before the worker restarts (so fc.done gets called and the client receives a response).
I'm not sure if the behavior was always this way, but it behaves this way on the newest PHP 8.3 version.

Ok I think I get it. This looks like a good fix. WDYT @withinboredom ?

Thank!!