DisabledByDefault Descrepancy

All through this article, there are comments around the DisabledByDefault setting which says to set to 1 to disable the protocol by default, yet the screenshots show it set to 0 but the description immediate preceding these pictures say "The following example shows TLS xxx disabled in the registry".
e.g. "To disable TLS 1.0 by default, create a DisabledByDefault entry and change the DWORD value to 1. If an SSPI app explicitly requests to use TLS 1.0, it may be negotiated.  The following example shows TLS 1.0 disabled in the registry" - but then it shows it set to 0!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd180142-4c19-8abc-ecce-e4c7e5ac8951
Version Independent ID: fc5bba87-afad-1729-8f7e-333c73188b73
Content: Transport Layer Security (TLS) registry settings
Content Source: WindowsServerDocs/security/tls/tls-registry-settings.md
Product: windows-server
Technology: security
GitHub Login: @Justinha
Microsoft Alias: justinha

OK. There are 2 options to choose from here (both involving that you make a Pull Request to change the incorrect information):

Create your own image (or edit the current image) and upload the new one to your own PR branch.
Start editing the text in the document, create a PR from that, where you suggest the image description to something like this:
"The following example shows you where to disable TLS 1.0 in the registry."

Feel free to inform us when you have started working on your Pull Request and ask for help whenever you need to add information in the PR.

You are misreading the text and image content. The image shows the setting as "Disabled" because Enabled = 0 in the image.
This is NOT the same as Disabled By Default.

#please-close

By the way, when I said "You are misreading the text and image content.", I meant to say that you are jumping to conclusions. It is necessary to read the statements separately and with individual meanings.

Wow you sure have a blunt way of letting me know what you mean!
Ok I wouldn’t say “jumping to conclusions” but more like you have worded it right before showing a picture that has it set the opposite way!
I do see what you mean now though, but because perhaps the statements about DisabledByDefault shouldn’t be right before the screenshots then, and instead should be after?
I am having a similar discussion with a SCOM Management Pack author (see below) who thinks your page is saying to set DisabledByDefault to 0 to disable it and has written his monitors to expect it to be 0 to be considered Healthy, therefore his monitors generate alerts when set to 1 as he thinks 0 is DisabledByDefault.
https://monitoringguys.com/2020/07/13/tls-compliance-monitoring/
Sent from my iPhone
On 8/11/2020, at 8:40 AM, Trond B. Krokli<EMAIL_ADDRESS>wrote:

By the way, when I said "You are misreading the text and image content.", I meant to say that you are jumping to conclusions. It is necessary to read the statements separately and with individual meanings.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/windowsserverdocs/issues/4926#issuecomment-723486055, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AROBNZ7EGLPSVZRDYA6FLR3SOWPBLANCNFSM4SW5JOLA.

To add to this, why has each picture got the red box around both settings when making that statement - this is where the confusion got me too?!
The DisabledByDefault setting shouldn’t be included in the red box when set to 0, following the example statements around this is the protocol showing as disabled. This is very misleading (yes the protocol is disabled but not by default too) and is no doubt why they wrote their monitors to look for that combination as the best practice.
Kevin Holman’s SCOM TLS script sets DisabledByDefault to 1 as best practice, and the Monitoring Guys have it as 0, as they too misinterpreted your site.
Sent from my iPhone
On 8/11/2020, at 9:44 AM, Steve Cahill<EMAIL_ADDRESS>wrote:
 Wow you sure have a blunt way of letting me know what you mean!
Ok I wouldn’t say “jumping to conclusions” but more like you have worded it right before showing a picture that has it set the opposite way!
I do see what you mean now though, but because perhaps the statements about DisabledByDefault shouldn’t be right before the screenshots then, and instead should be after?
I am having a similar discussion with a SCOM Management Pack author (see below) who thinks your page is saying to set DisabledByDefault to 0 to disable it and has written his monitors to expect it to be 0 to be considered Healthy, therefore his monitors generate alerts when set to 1 as he thinks 0 is DisabledByDefault.
https://monitoringguys.com/2020/07/13/tls-compliance-monitoring/
Sent from my iPhone
On 8/11/2020, at 8:40 AM, Trond B. Krokli<EMAIL_ADDRESS>wrote:

By the way, when I said "You are misreading the text and image content.", I meant to say that you are jumping to conclusions. It is necessary to read the statements separately and with individual meanings.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/windowsserverdocs/issues/4926#issuecomment-723486055, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AROBNZ7EGLPSVZRDYA6FLR3SOWPBLANCNFSM4SW5JOLA.

Sorry for appearing to be blunt, I did not intend to make that impression.
I was tired and wanted to complete my task of sorting out which tickets were related to the DTLS 1.1 / DTLS 1.2 image issue, for which I made a PR to resolve the fact that DTLS 1.1 is not an existing protocol.
Anyway, maybe you are correct, but would you be able to suggest a better way to clear up that confusion, so we can work on some material to add in a new PR to clean up the mess you are seing?

No problem, I guess I just want to understand if the article needs updating to better explain the end goal of disabling each protocol by default and in general.  In my opinion to reduce confusion, each protocol explanation should be similar to this (or show a screenshot for each setting right after it is explained on what it should be set to for it to be disabled).
I also wasn’t 100% sure if it needs the statement updated when you have it set as per my screenshot that it will be denied even when an SSPI app explicitly requests to use TLS 1.1 IF Enabled = 0 and DisabledByDefault = 1 – is that the case?  I have highlighted my text around that too…
….
To disable TLS 1.1 for client or server, change the DWORD value to 0. If an SSPI app requests to use TLS 1.1, it will be denied.
To disable TLS 1.1 by default, create a DisabledByDefault entry and change the DWORD value to 1. If an SSPI app explicitly requests to use TLS 1.1, it may be negotiated (unless Enabled = 0 and DisabledByDefault = 1, then it will be denied).
The following example shows TLS 1.1 disabled (Enabled = 0) and TLS 1.1 by default being disabled also (DisabledByDefault = 1) in the registry:
<EMAIL_ADDRESS>From: Trond B. Krokli<EMAIL_ADDRESS>Sent: Sunday, 8 November 2020 10:18 a.m.
To: MicrosoftDocs/windowsserverdocs<EMAIL_ADDRESS>Cc: Steve Cahill<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/windowsserverdocs] DisabledByDefault Descrepancy (#4926)
Sorry for appearing to be blunt, I did not intend to make that impression.
I was tired and wanted to complete my task of sorting out which tickets were related to the DTLS 1.1 / DTLS 1.2 image issue, for which I made a PR to resolve the fact that DTLS 1.1 is not an existing protocol.
Anyway, maybe you are correct, but would you be able to suggest a better way to clear up that confusion, so we can work on some material to add in a new PR to clean up the mess you are seing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/windowsserverdocs/issues/4926#issuecomment-723496529, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AROBNZ4CZIMYCPDBMFQZBGTSOW2QFANCNFSM4SW5JOLA.

Just to quote someone more knowledgeable than me in this topic, here is an explanation from https://github.com/MicrosoftDocs/windowsserverdocs/pull/4988#issuecomment-723637268:

By the way, I have answered a handful of tickets where other users have claimed that the images do not show the correct state of the services being disabled, because they (in my opinion) claim that the Registry key DisabledByDefault should have the value 1 instead of 0, whereas I find that the images seem to be correct by showing the key Enabled = 0. Do you have any views on that detail?

Well, this is a standard case where Microsoft makes things difficult with double negation and further complicates it with dual flags overriding each other. So let's break it down.

DisabledByDefault and Enabled control different things, but we can think of DisabledByDefault as a subset of Enabled=1 setting.
When Enabled flag is set to 0, the respective protocol version is disabled and cannot be negotiated no matter what the value of DisabledByDefault flag is. In this cases the value of DisabledByDefault is essentially ignored.
If Enabled=1 AND DisabledByDefault=1 the respective protocol is not advertised, but it can still be explicitly requested through SSPI.
If Enabled=1 AND DisabledByDefault=0 the respective protocol is available and advertised.
In short, DisabledByDefault flag is somewhat useless and confusing because no matter what the value is here, it does not really disable the protocol.

So, back to your question, while the clean settings for a completely disabled protocol are:

DisabledByDefault=1 (Disabled by Default)
Enabled=0 (Disabled)

in reality, the following combination also completely disables the protocol:

DisabledByDefault=0 (Enabled by Default)
Enabled=0 (Disabled)

Thanks for the information – the fact that multiple people are querying this and that some are taking DisabledByDefault=0 as gospel over DisabledByDefault=1 highlights my confusion also.
But yes, I do understand it now in that DisabledByDefault is a subset of Enabled, so if Enabled=0 then it doesn’t really matter what DisabledByDefault is set to…but as mentioned by your guru, DisabledByDefault=1 is the “clean” way of setting it.
I have let the SCOM Management Pack company know this too, as currently when his monitor sees DisabledByDefault=1, it fires SCOM alerts to say this is not set as best practice when disabling these protocol, and his monitor expects this to be 0.
https://monitoringguys.com/2020/07/13/tls-compliance-monitoring/#comment-102
Thanks again
From: Trond B. Krokli<EMAIL_ADDRESS>Sent: Monday, 9 November 2020 1:37 p.m.
To: MicrosoftDocs/windowsserverdocs<EMAIL_ADDRESS>Cc: Steve Cahill<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/windowsserverdocs] DisabledByDefault Descrepancy (#4926)
Just to quote someone more knowledgeable than me in this topic, here is an explanation from #4988 (comment)https://github.com/MicrosoftDocs/windowsserverdocs/pull/4988#issuecomment-723637268:
By the way, I have answered a handful of tickets where other users have claimed that the images do not show the correct state of the services being disabled, because they (in my opinion) claim that the Registry key DisabledByDefault should have the value 1 instead of 0, whereas I find that the images seem to be correct by showing the key Enabled = 0. Do you have any views on that detail?
Well, this is a standard case where Microsoft makes things difficult with double negation and further complicates it with dual flags overriding each other. So let's break it down.

DisabledByDefault and Enabled control different things, but we can think of DisabledByDefault as a subset of Enabled=1 setting.
When Enabled flag is set to 0, the respective protocol version is disabled and cannot be negotiated no matter what the value of DisabledByDefault flag is. In this cases the value of DisabledByDefault is essentially ignored.
If Enabled=1 AND DisabledByDefault=1 the respective protocol is not advertised, but it can still be explicitly requested through SSPI.
If Enabled=1 AND DisabledByDefault=0 the respective protocol is available and advertised.
In short, DisabledByDefault flag is somewhat useless and confusing because no matter what the value is here, it does not really disable the protocol.

So, back to your question, while the clean settings for a completely disabled protocol are:

DisabledByDefault=1 (Disabled by Default)
Enabled=0 (Disabled)

in reality, the following combination also completely disables the protocol:

DisabledByDefault=0 (Enabled by Default)
Enabled=0 (Disabled)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/windowsserverdocs/issues/4926#issuecomment-723693197, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AROBNZ465D355ODWJT4CI7LSO42UDANCNFSM4SW5JOLA.

Very well, good follow-up and feedback. Would you also like to offer some form of document improvement to reduce the confusion, based on the available information?

I would say the document could be improved by reiterating what @ixtlanianhttps://github.com/ixtlanian wrote on https://github.com/MicrosoftDocs/windowsserverdocs/pull/4988#issuecomment-723637268 - to cleanly disable the protocol by setting it as not available and not advertised (by default) then to set Enabled to 0 and DisabledByDefault to 1.
He has summed up what needs to be highlighted – also with his comments around thinking of DisabledByDefault as a subset of Enabled, and that when Enabled is set to 0 this essentially ignores the value of DisabledByDefault.
From: Trond B. Krokli<EMAIL_ADDRESS>Sent: Monday, 9 November 2020 5:43 p.m.
To: MicrosoftDocs/windowsserverdocs<EMAIL_ADDRESS>Cc: Steve Cahill<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/windowsserverdocs] DisabledByDefault Descrepancy (#4926)
Very well, good follow-up and feedback. Would you also like to offer some form of document improvement to reduce the confusion, based on the available information?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/windowsserverdocs/issues/4926#issuecomment-723750067, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AROBNZ3ISJUDAX3WZXORKGTSO5XNTANCNFSM4SW5JOLA.

Good call. I will do my best to find a way to place it within the existing document, but it might take a week for me to finish it (got more than enough to do at work. I am also going to ask for this ticket to be reopened, just to make it easier for myself to follow up on this ticket.
Feel free to add anything that might be helpful regarding the placement and so on.

#please-reopen

#please-open

Hi there - this doesn't appear to have been reopened yet as per the comments made 28 days ago?

I tried both here and somewhere else with no success, so I don't know if the scripted bots are able to reopen tickets at all or if they have got any respond codes to do so.

OK thanks - so how can we progress with you being able to update the documentation?

Sorry, I have had some rough times lately. I misjudged how sleepy the medicine I take makes me. Would it be OK if we continue this discussion in my PR #4988 ?

Ah sorry to hear that. No problem using that one, thanks


Fix Issue 13663 - Comparison of Tuples with floating point fields

Thanks to Simen Kjaeraas for pointing out this solution.

Two of the tests in buildkite produce this error:
std/typecons.d(814,32): Error: template instance
isFloatingPoint!"key" does not match template declaration
isFloatingPoint(T)
It's clear, that this comes from the tuple having named elements. But it seems like I need a more thorough understanding of how Tuple works for getting this right.

I switched to math:isNaN, because now we know, that we compare floats.
And: It feels a little bit strange to me, that the two functions differ only by a "const"...

I just noticed, that the docs of opCmp where wrong too and obviously did not account for NaNs. I fixed that too.

Next try.


[$1000] Web - The error doesn't clear immediately after reloading the contact method verify page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to setting > profile > contact method
Click on add contact method
Add a new contact method
Click on this contact method to verify
Enter a random magic code to make the error appears
Reload the page and notice the error

Expected Result:
The error should clear immediately after reloading the page
Actual Result:
The error doesn't clear immediately
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.47-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screencast from 28-07-2023 18_05_23.webm
https://github.com/Expensify/App/assets/93399543/b422eafd-cb89-48a6-93ba-7d0c3ed4fa3f
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690542294914639
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0140f90e5805b83227
Upwork Job ID:<PHONE_NUMBER>572416000
Last Price Increase: 2023-07-28

Proposal
Please re-state the problem that we are trying to solve in this issue.
The error doesn't clear immediately after reloading the contact method verify page.
What is the root cause of that problem?
The error message is stored in loginList onyx data.
But when reloading the contact method verify page, these data does not clear.
Therefore the error is still shown.
What changes do you think we should make in order to solve the problem?
We should clear loginList onyx data in componentDidUpdate in ContactMethodDetailsPage.
What alternative solutions did you explore? (Optional)
None.

Confirmed error on staging

Thanks for the proposal @StevenKKC.  I get that the proposal works, and the RCA is also correct. But I am going to have to confirm if we're okay to clear these messages.
🎀 👀 🎀 C+ reviewed.

Hello, everyone!
I am the professional web/mobile app developer who have full experience 8 years.
How can I join this project dev team?
Regards.
Janitha!

 Can you confirm the expected behavior?

@johnmlee101 can you confirm expected behavior here?

Let's only clear the validate code field @mananjadhav, I feel like thats safer than clearing all fields.

@mananjadhav since we've confirmed, are we hiring @StevenKKC for this one?

@mananjadhav Any thoughts on these proposals? It's been a few weeks since we've moved the needle here.

thanks for the bump @garrettmknight. I had reviewed this earlier so it was off my radar. Checking through the last messages I am in a bit of a tight spot. Most proposals mention the correct RCA and similar solutions.
But based on the confirmation I am going to choose @WikusKriek's proposal here, because it has the most recent updated proposal with the correct behavior. (considering useEffect).
I understand that earlier when the issue was, it would've been a class component, but considering we had enough time to revise the proposals, I am going to still select the one which considers the function component.
cc - @johnmlee101 .

I still feel we should be doing this in BaseValidateCodeForm, unless it causes any regression.

@WikusKriek I would strongly advise against creating the PRs for the issues that aren't officially assigned to you. Please wait for the GH issue to be assigned to you to work on the PR. Thanks for the patience.

Thanks for understanding. @johnmlee101 Quick bump.

This was deployed on production 2 days, but the title wasn't updated.

Oops, yep, let me process now.

Summary of payments for this issue:

#urgency bonus? Yes
Reporter: @dukenv0307 - $250 paid via Upwork
Contirbutor: @WikusKriek - $1500 paid via Upwork
Contributor+: @mananjadhav - $1500

Upwork job: https://www.upwork.com/jobs/~0129c8265c6b7e57ae

$1,500 payment approved via NewDot based on BZ summary.

@JmillsExpensify @garrettmknight We're good to close this one?

@mananjadhav can you complete the checklist?

I can't attribute this to a specific offending PR. We are not clearing the code is something that we have had since BaseValidationCodeForm component was created. It's a base component, where we've fixed the change.  Hence I don't think we would have the issue again. This is the reason, I don't think we need a regression test for this one.

Thanks, we can close now.


Bump buildpack-packager init bindata in CI please

When I install this repo, the buildpack-packager init scaffold generator is creating an install_go.sh that installs go1.10; not go1.12, which is in the latest scaffold script.
I think the bindata.go + cfbindata.go files are no being recreated when scaffold files are changed. Could this be done in CI please? Or would you just like scaffold PRs to also bump the bindata files?
https://github.com/cloudfoundry/libbuildpack/tree/master/packager - bindata.go is 6 mths old, cfbindata.go is over a year old.
Update: I see in readme that it discusses scaffold updates in PRs, but perhaps since multiple open PRs currently all modify scaffold it isn't possible for PRs to include bindata generated?

We aren't going to spend the time to have this automatically updated in CI as we are moving away from this tooling in the medium-term. I've gone ahead and manually bumped the version of Go in the scaffold to 1.13.5 which should be the latest version as of this comment. Thanks!


3 minor mistakes

“crop the center image to make it rectangular” makes no sense.
unecessary rgb->bgr conversion
use "mx.model.FeedForward()" rather than "mx.model.FeedForward.create()"

Thanks for your contribution! Please rebase your commit then we will merge it.
https://mxnet.readthedocs.org/en/latest/contribute.html#how-to-combine-multiple-commits-into-one


Expect renameCollection tests failures

Description
Add helper for SQLite tests.
Readiness checklist

[x] I added/updated unit tests.
[x] I added/updated integration/compatibility tests.
[x] I added/updated comments and checked rendering.
[x] I made spot refactorings.
[ ] I updated user documentation.
[x] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

Uh, sorry, I should not push broken commit right before the takeoff :D


auto-completion is duplicated

Good time of the day, every time I write the code, the autocompletion shows me everything 2 pieces at a time, I'm setting up my Neodim for the first time and I think it's my fault and not the plugin, could you help me with the correct setup?
https://gitflic.ru/project/dartmitai/neovim

do I need to remove this from the configuration?
-- LSP   use {     'neovim/nvim-lspconfig',     config = function()       require'lspconfig'.dartls.setup{}   end }


Fix several compiler warnings

Thanks, however I'd prefer not to remove the unwrap(). They are real errors that could happen and that should be handled instead of being ignored.

You mean instead of unwrap we should match the result right?

Just leave the warning for now. The error should be propagated.

I just updated this PR.
I also tried running clippy on this crate, and ran into a compiler bug.


Add TLS and basic auth

Many exporters use the Prometheus exporter-toolkit/web package to implement TLS and basic auth.
The only issue is that this library assumes you're using go-kit for logging. I could convert the existing logging to go-kit if that's acceptable.

Sounds reasonable.


Pull data from pangeo (https://catalog.pangeo.io/browse/master/ocean/altimetry/) - S3A, S3B, J3

Access denied if not registered to a project that pays for each download.
Downloading L2 S3A product from coda.eumetsat.int instead.

@panmits86 has downloaded X-Track (L3) of TP/J1/J2/J3 for the region of interest from 1993 to July 2020.


FailureListFormatter: use exception message as reason, not spec name

For me, this improves the value of the 3rd field ("reason") when working with the Quickfix list in Vim.
Additionally, rspec --help specifies this behavior:
    -f, --format FORMATTER             Choose a formatter.
                                         [p]rogress (default - dots)
                                         [d]ocumentation (group and example names)
                                         [h]tml
                                         [j]son
                                         [f]ailures ("file:line:reason", suitable for editors integration)

Please rebase this off our default branch, which is main.

Please rebase this off our default branch, which is main.

@JonRowe I've rebased off main (sorry, I forked ages ago).
@smortex I've improved the locations. It'll find the first relevant location in the exception's backtrace, if set, defaulting back to the example location.

@JonRowe I've rebased off main (sorry, I forked ages ago).
@smortex I've improved the locations. It'll find the first relevant location in the exception's backtrace, if set, defaulting back to the example location.

Something went wrong with rebasing... I'm gonna reopen this in a new PR.

Something went wrong with rebasing... I'm gonna reopen this in a new PR.


Add Demo08  upgraded to ASP.Net Core V3.0 P5

closed with git flow feature finish WGH-AddDemo08UpgradedToASPNetCoreV3.0P5-#25, merged into develop branch


Remove !subscribe and references.

Closes #99
Removes the !subscribe  command any references to it, since we have a new way of doing roles. Should be ready to reveiew and push, grep seems to be returning no more results for !subscribe, or subscribe.

I'm assuming we want to keep the MovedCommandError just incase we need it later. It was only referenced in _cog.py before I removed the command here.


ninjas need a timegate

Description
Earlier today on Mander, there was a ninja that didnt know how to USE HIS JETPACK OR SEE HIS OBJECTIVES.
This is an issue, so there should be a timegate. Maybe antagonist related? "6 hours of antagonist needed" or something
Additional context
Round 54193 on mander.

i agree, but maints say "there is no reason to gate fun"

I suspect #27425 is related. If you don't know how to see objectives, you typically won't try to be an antag.

yesn't

I suspect #27425 is related. If you don't know how to see objectives, you typically won't try to be an antag.

Considering the Ninja is a ghost role, they could have very well opted into it without knowing what it was supposed to be. You would think the description would tell you otherwise though.

yesn't

I suspect #27425 is related. If you don't know how to see objectives, you typically won't try to be an antag.

Considering the Ninja is a ghost role, they could have very well opted into it without knowing what it was supposed to be. You would think the description would tell you otherwise though.

I think we should reimplement the raffling in a Goon/TG style instead of how it is now, though I cant think of a short term fix other than just giving it a time requirement (unfun)


VPC cleanup: use DestinationIpv6CidrBlock when available

Fix exception botocore.exceptions.ClientError: An error occurred (MissingParameter) when calling the DeleteRoute operation: The request must contain exactly one of: destinationCidrBlock, destinationIpv6CidrBlock, destinationPrefixListId
Related ticket : https://progress.opensuse.org/issues/154456
NOTE : this PR contains 3 commits (commits 1 and 2 was added to fix failing CI) :
1.)  upgrade selenium to fix pytest.PytestUnraisableExceptionWarning
2.) Switch to pip azure-cli install because azure-cli rpm not support python3.11
3.)  VPC cleanup: use DestinationIpv6CidrBlock when available

Maybe at least mention that Azure issue you're dealing with here as well.

PR description updated please check if it is ok now


install failed

i cannot install the extension in vscode.

@JayaHuang please try manually download the extension and install it. It should be something related with VS Code market place or your own environment.

@JayaHuang please try manually download the extension and install it. It should be something related with VS Code market place or your own environment.

thanks for reply.
it shows this info when i manually install the extension.

The information is very clear, you need to update your VS Code to the latest.


Add mount options for smb.

Can you give some more details about why these mount options would be required (just in here, not necessarily in that documentation)? I may be missing some context here.

I'm closing PRs which have conflicts or are failing builds and are older than 6 months old, to tidy up the Drupal VM PR queue; please create a new PR against the latest master branch if you feel this is still an important fix or feature for Drupal VM. Thank you!


How to create uuid4 file names for images uploaded with Django-CKEeditor?

I tried generating uuid4 file names for images uploaded with CKEditor.
It gives me the following error:
Internal Server Error: /ckeditor/upload/ module_path, class_name = dotted_path.rsplit('.', 1) AttributeError: 'function' object has no attribute 'rsplit' [06/Jul/2017 14:48:20] "POST /ckeditor/upload/?CKEditor=id_description&CKEditorFuncNum=1&langCode=en HTTP/1.1" 500 97818
What I tried:
utils.py
import uuid
import os.path

def generate_uuid4_filename(filename):
    """
    Generates a uuid4 (random) filename, keeping file extension

    :param filename: Filename passed in. In the general case, this will
                     be provided by django-ckeditor's uploader.
    :return: Randomized filename in urn format.
    :rtype: str
    """
    discard, ext = os.path.splitext(filename)
    basename = uuid.uuid4().urn
    return ''.join(basename, ext)

settings.py
# Somewhere at the top
from .utils import generate_uuid4_filename

# Near the rest of the CKEditor variables
CKEDITOR_FILENAME_GENERATOR = generate_uuid4_filename

What causes this problem?
I followed the instructions from StackOverflow. Feel free to answer this in SO:
https://stackoverflow.com/questions/44948917/how-to-create-uuid4-file-names-for-images-uploaded-with-django-ckeeditor

I followed the instructions from Stack Overflow: https://stackoverflow.com/questions/44948917/how-to-create-uuid4-file-names-for-images-uploaded-with-django-ckeeditor

You got a wrong method，you shoud do like this !
utils.py
import os.path
import uuid
def generate_uuid4_filename(filename):
    discard, ext = os.path.splitext(filename)
    basename = uuid.uuid4()
    return u'{0}{1}'.format(basename, ext)

settings.py
CKEDITOR_FILENAME_GENERATOR = 'ckeditor_uploader.utils.generate_uuid4_filename'

ckeditor_uploader  is yours code path
BY： 独自等待博客 https://www.waitalone.cn/

@hack2012 This gives me:
ImportError: Module "ckeditor_uploader.utils" does not define a "generate_uuid4_filename" attribute/class

@hack2012 Apparently
CKEDITOR_FILENAME_GENERATOR = 'appname.utils.generate_uuid4_filename'

yes....  notice this @

ckeditor_uploader is yours code path means your appname

INSTALLED_APPS = [
    'ckeditor',
    'ckeditor_uploader',
]

That may be a good addition to the docs. I'd certainly appreciate a pull request to that effect.


Data Extractor for Mailchimp

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1537
Originally created by @dmor on 2020-01-07 22:45:30

Came up in a customer call today that they'd like to be able to pull in their data from Mailchimp.
Mailchimp is an email sending service, and would have interesting information to dashboard, like:

growth of subscribers over time
change in open rate over time
change in clickthrough rate over time

It would also be interesting to understand the relationship between email sending and other activities, such as:

% of emails that generated a login
% of emails that generated a signup
% of emails that generated a new sale

There is an existing Singer tap for Mailchimp https://github.com/singer-io/tap-mailchimp

View 2 previous comments from the original issue on GitLab


Fixed documentation example of usage phpunit

Code block was loosed because no empty line after .. code-block:: php

What about fixing it on site?
http://docs.phinx.org/en/latest/commands.html#using-phinx-with-phpunit

The documentation will soon be moved to another URL and updated there.


Condition time issue

This will not work as time spans multiple days
	<condition time_start="4:00am" time_end="3:59pm">

Good morning.

	</condition>
	<condition time_start="4:00pm" time_end="3:59am">

Good evening

	</condition>

Fixed commit 009941ef51f7d744f77d02a8c5a58b1eb97763e


See https://github.com/apache/trafficcontrol/pull/2305/files
No tests, just removing a proxy, existing route has been manually tested.
No docs, no interface change.
No changelog, no interface change.

[x] This PR fixes #REPLACE_ME OR is not related to any Issue

Which Traffic Control components are affected by this PR?

Traffic Ops

What is the best way to verify this PR?
Request cdns/health route, verify matches Perl, and has x-server-name Golang header.
If this is a bug fix, what versions of Traffic Control are affected?
Not a bug fix.
The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4930/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4931/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4932/


Adds QOI support to Peek

Summary of the Pull Request
Adds QOI image files support to Peek!
Light theme

Dark theme

PR Checklist

[X] Closes: #29918
[X] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[X] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments
A couple of notes on this PR:

I moved the QoiImage and Gcode* classes from PreviewHandlerCommon to FilePreviewCommon, and by doing that, I had to enable <UseWindowsForms>, <AllowUnsafeBlocks> and <Nullable> on the project.
As I enabled nullable types on the step above, I fixed all the nullable issues on FilePreviewCommon
FilePreviewCommon has been added as a project dependency to:

GcodePreviewHandler
GcodeThumbnailProvider
QoiPreviewHandler
QoiThumbnailProvider

IFileSystemItemExtensions.GetQoiSize is just going directly to the bytes where we expect the "width" and "height" of a QOI image to be. I did not add a file header validation, but that should be rather trivial to do as it is already implemented in QoiImage.
BitmapHelper.GetBitmapFromHBitmapAsync has been refactored so that I could extract the code that converts a System.Drawing.Bitmap to a Microsoft.Xaml...BitmapSource <- you might want to take a good look at this one to make sure all is ok!

I understand that Peek can now show Preview Pane Handlers directly, but considering #26726, I think it best to prepare to a situation where PT stops supporting the Preview Pane Handlers completely

Validation Steps Performed
Manual validation with the test images pack in https://qoiformat.org/

@pedrolamas
Isn't it ready? Then we can remove the review label. Thought it was ready.

@htcfreek from my part, this PR is ready to go!

Thanks for opening the PR, @pedrolamas .
At this moment, we're thinking of reviewing the contribution for 0.77 only. Sorry for the delay. 😄

No problem, thanks for letting me know, @jaimecbernardo
I will try and keep the branch in sync with main branch to make sure it does not have conflicts.

/azp run

I've merged latest main in and added QOI to the notice section about Peek as well. Running a Dart CI test to check if it still builds OK for release.

When the preview pane is on a qoi file, you can't delete that file.

Thanks @jaimecbernardo, I have a feeling this is due to the fact I changed the BinaryReader in QoiReader to leave the stream open (in theory that makes sense to me as I would expect the stream to be closed upstream, but maybe that is not the case?)

@jaimecbernardo I have now fixed the problem by adding a using to the file stream
https://github.com/microsoft/PowerToys/pull/29919/files#diff-1d420d0e6cfb94016296228da268defbf9677c8414f378b21b45abb19ce22779R66
For the record, my thinking here is that if the Image.FromStream method leaves the stream open, I think it is reasonable to expect the same behavior from QoiImage.FromStream, hence why I changed the BinaryReader to leave it open.
Disposing the FileStream in this case solves the problem very nicely, and I would argue that it is reasonable that (where appropriate) the same change should be made on ALL other preview handlers, what do you think?

Solves it for me. Not sure 🤔 . The other previewers don't seem to be suffering from the same issue.


fix: add pre-steps before publishing to github npm registry

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #255 (4d45657) into main (2974dfe) will increase coverage by 8.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   83.33%   92.26%   +8.93%
==========================================
  Files           2        1       -1
  Lines         126      349     +223
  Branches       31       43      +12
==========================================
+ Hits          105      322     +217
- Misses         21       27       +6

Impacted Files
Coverage Δ

src/index.ts
92.26% <100.00%> (+10.26%)
:arrow_up:

example/src/main.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da5878...4d45657. Read the comment docs.


Local Assembly Implementation for a Transport Equation

Hello,
I have a question about implementing a sweep based solver for an advection equation that uses an upwind discretization with DG. My problem is similar to example 9, with the exception that my problem is steady state. I have modified this example to meet the needs of my problem and the solver produces the correct answer.
My problem is that I am now trying to convert this solver into one which does not form the global linear system and, instead, solves the same problem in an element by element manner following an appropriate reordering of the mesh elements. My formulation requires the following bilinear and linear forms:

-(I, Omega_d . grad v), where I is the trial variable, v is the test variable, and Omega_d is the vector coefficient that defines the wind direction. My implementation uses ConservativeConvectionIntegrator(Omega_d, 1.0) for this term.
On interior/exterior faces I have the bilinear form < (Omega_d.n) {{I}},[[v]] > + 0.5 < |Omega_d.n| [[I]],[[v]] >, where I is (again) the trial variable, Omega_d is the ordinate vector, and v the test variable. This requires two instances of DGTraceIntegrator(Omega_d, 1.0, 0.5) when the full system is assembled, but I have implemented a custom method for this (described later).
(Q, v) where Q is the known source function and v is the test variable. This is implemented using DomainLFIntegrator(Q).
No inflow condition is used here, so it is not essential for this problem. The source term is non-zero, so this is fine.

For the element by element implementation, I created instances of the same integrators mentioned above, with the exception of the face terms. As I move through the elements (in the order specified by the wind direction) my code basically calls the assembly functions of the different bilinear and linear forms and adds them to the corresponding matrix or vector for the element. I'm confident that the problem is not in the evaluation of the volume integrals (items 1 and 3). The likely culprit is the assembly of the face terms.
The approach I'm using for the evaluation of the face terms is somewhat similar to the code used in MFEM's DGTraceIntegrator except that I don't have the jump condition anymore (since the solve is done with one element at a time). On the faces of the mesh element being solved,  I use GetFaceElementTransformations with the edge/face id to get the transformation object and the elements that share this face. From this, I compute the normal vector and then I handle the upwinding of the flux myself. I've checked the orientation of the normal vectors on Cartesian meshes and it seems that the upwind procedure is correct, so I'm fairly confident that this is not an issue either.
One problem I've noticed is in the loop over the quadrature points on the faces because it appears to be using the wrong quadrature points on the edge/face. For example, on an edge of a 2-D Cartesian mesh, with a sixth order quadrature rule, when I print the physical integration point being used, I get this:
Physical ip on this element =  [0.00000000e+000 2.32139155e-316], Physical ip on this element =  [0.00000000e+000 2.33850489e-310], Physical ip on this element =  [0.00000000e+000 2.33852371e-310], Physical ip on this element =  [0.00000000e+000 2.33852371e-310], Physical ip on this element =  [ 0.00000000e+00 -2.90966899e-92], Physical ip on this element =  [0.00000000e+000 2.33852371e-310], Physical ip on this element =  [0.00000000e+000 2.33852371e-310]
My code, like MFEM's DGTraceIntegrator, does the calculation on the reference element. I'm only computing the physical points for inspection. So the points are the same (to machine precision) and I can't figure out why and this is causing problems with the calculations that follow. As you would expect, the error gets worse as you increase the order of the basis in the finite element space.
One of my earlier problems (since this is a 2-D test case) is that I was not aware that I needed to specify the differences between edges and faces, since I thought MFEM handled this for me automatically. Could this issue be related? Any advice/clarification you could provide on the matter would be greatly appreciated. Thank you in advance!

Hi @i3s93, why does the ip physical position always come out as (0,0)? Can you show the loop that prints this?

@vladotomov, Here is the relevant section of the code that you requested. I should've mentioned in my original post that I'm using the Python wrapper, but I don't think this is a Python issue. Perhaps I'm missing something with one of the data structures.
# Calculate the order of the integration rule (again following MFEM)
if FTr.Elem2No >= 0:
        order = (min(FTr.Elem1.OrderW(), FTr.Elem2.OrderW()) + 2*max(el1.GetOrder(), el2.GetOrder()))
else:
        order = FTr.Elem1.OrderW() + 2*el1.GetOrder()

if el1.Space() == mfem.FunctionSpace().Pk:
        order += 1

# Get the integration rule on the reference domain of a certain order
ir = mfem.IntRules.Get(FTr.GetGeometryType(), order)

for p in range(ir.GetNPoints()):

        # Extract the integration point and set the location in the transformation object
        ip = ir.IntPoint(p)
        FTr.SetAllIntPoints(ip)

        physical_ip = mfem.Vector(2)
        FTr.GetElement1Transformation().Transform(ip, physical_ip)
        print("Physical ip on this element = ", physical_ip.GetDataArray())

        # Evaluate the coefficient at the integration point
        # This doesn't really have any effect since these are constants
        Omega.Eval(ordinate_vec, FTr, ip)

        # Compute the normal vector on the face at this integration point
        # The normal points from element FTr.Elem1No into FTr.Elem2No
         mfem.CalcOrtho(FTr.Jacobian(), nor)

First, thank you for your suggestion -- I greatly appreciate the help. I have tried your modification and I'm seeing similar behavior.
In case you'd like to try reproducing the issue, I'm testing on a 2-D Cartesian mesh with a single quadrilateral element obtained with mesh = mfem.Mesh(1,1, "QUADRILATERAL"). Then I loop over the faces of the mesh and call FTr = mesh.GetFaceElementTransformations(face_id). This object gets passed to a method that performs the loop in my earlier comment. In my case, the value of order used in the line ir = mfem.IntRules.Get(FTr.GetGeometryType(), order) happens to be 5.  False
Element IDs that share this face: (0, -1)
order = 5
p = 0
Reference weight on this element =  0.2777777777777778
Physical weight on this element =  0.2777777777777778
Reference ip on this element =  0.11270166537925831 , 2.328768201843e-310
Physical ip on this element =  [2.3287682e-310 9.7768714e-317]
p = 1
Reference weight on this element =  0.4444444444444444
Physical weight on this element =  0.4444444444444444
Reference ip on this element =  0.5 , 2.3287864511193e-310
Physical ip on this element =  [2.32876820e-310 1.23227403e-316]
p = 2
Reference weight on this element =  0.2777777777777778
Physical weight on this element =  0.2777777777777778
Reference ip on this element =  0.8872983346207417 , 2.3287864511509e-310
Physical ip on this element =  [2.3287682e-310 1.6816777e-316]

Working on face 1
Is this face an interior face? False
Element IDs that share this face: (0, -1)
order = 5
p = 0
Reference weight on this element =  0.2777777777777778
Physical weight on this element =  0.2777777777777778
Reference ip on this element =  0.11270166537925831 , 2.328768201843e-310
Physical ip on this element =  [0. 1.]
p = 1
Reference weight on this element =  0.4444444444444444
Physical weight on this element =  0.4444444444444444
Reference ip on this element =  0.5 , 2.3287864511193e-310
Physical ip on this element =  [2.32876820e-310 1.12310765e-316]
p = 2
Reference weight on this element =  0.2777777777777778
Physical weight on this element =  0.2777777777777778
Reference ip on this element =  0.8872983346207417 , 2.3287864511509e-310
Physical ip on this element =  [2.3287682e-310 2.3287682e-310]

Working on face 2
Is this face an interior face? False
Element IDs that share this face: (0, -1)
order = 5
p = 0
Reference weight on this element =  0.2777777777777778
Physical weight on this element =  0.2777777777777778
Reference ip on this element =  0.11270166537925831 , 2.328768201843e-310
Physical ip on this element =  [0. 1.]
p = 1
Reference weight on this element =  0.4444444444444444
Physical weight on this element =  0.4444444444444444
Reference ip on this element =  0.5 , 2.3287864511193e-310
Physical ip on this element =  [2.32876820e-310 1.64564966e-316]
p = 2
Reference weight on this element =  0.2777777777777778
Physical weight on this element =  0.2777777777777778
Reference ip on this element =  0.8872983346207417 , 2.3287864511509e-310
Physical ip on this element =  [2.3287682e-310 1.6852326e-316]

Working on face 3
Is this face an interior face? False
Element IDs that share this face: (0, -1)
order = 5
p = 0
Reference weight on this element =  0.2777777777777778
Physical weight on this element =  0.2777777777777778
Reference ip on this element =  0.11270166537925831 , 2.328768201843e-310
Physical ip on this element =  [0. 1.]
p = 1
Reference weight on this element =  0.4444444444444444
Physical weight on this element =  0.4444444444444444
Reference ip on this element =  0.5 , 2.3287864511193e-310
Physical ip on this element =  [2.3287682e-310 6.8610620e-317]
p = 2
Reference weight on this element =  0.2777777777777778
Physical weight on this element =  0.2777777777777778
Reference ip on this element =  0.8872983346207417 , 2.3287864511509e-310
Physical ip on this element =  [2.32876820e-310 1.12310765e-316]

What's also weird to me is that to this point, my code is nearly identical to DGTraceIntegrator. The only exception to this is that the Assemble() method from the Bilinear form class iterates over faces (in any order) and would get FTr either from GetInteriorFaceTransformations(face_id) or something like GetBdrFaceTransformations(Bdr_elem_id), both of which call GetFaceElementTransformations in some form or another.

I have resolved this issue with the quadrature points on the face. I'm closing this issue, but will reopen if I have other questions.


add arbitrary args to put_object method, specifically for SSE support.

In order to add SSE support (yes for the encrypted files), we need put_object to either accept a growing list of args or just **kwargs.


max link idle reach, close the underlying net.Conn 怎么解决

time="07/03 11:01:10" level=warning msg="link is stopped already" from=link id=0
time="07/03 11:01:19" level=warning msg="ping failed" error=timeout from=link id=0 idle=1m2.000863288s
time="07/03 11:01:19" level=error msg="max link idle reach, close the underlying net.Conn" from=link id=0 idle=1m2.000863288s
panic: close of nil channel
goroutine 49 [running]:
github.com/ooclab/otunnel/vendor/github.com/ooclab/es/link.(*Link).Stop(0xc42022e0a0, 0xc42016aea8, 0x1)
/Users/gwind/go/src/github.com/ooclab/otunnel/vendor/github.com/ooclab/es/link/link.go:181 +0xd7
github.com/ooclab/otunnel/vendor/github.com/ooclab/es/link.(*Link).keepalive(0xc42022e0a0, 0x2, 0xc42017c000)
/Users/gwind/go/src/github.com/ooclab/otunnel/vendor/github.com/ooclab/es/link/link.go:244 +0x6c5
github.com/ooclab/otunnel/vendor/github.com/ooclab/es/link.newLink.func1(0xc42022e0a0)
/Users/gwind/go/src/github.com/ooclab/otunnel/vendor/github.com/ooclab/es/link/link.go:125 +0x32
created by github.com/ooclab/otunnel/vendor/github.com/ooclab/es/link.newLink
/Users/gwind/go/src/github.com/ooclab/otunnel/vendor/github.com/ooclab/es/link/link.go:124 +0x6a1
nohup: ignoring input

It is a known issues, would be fixed when I have time 😢


Show “super” ingredients in sidebar

The lists of spirits, liqueurs, etc are growing long. It may make sense to group each category together, something like:
Spirits
- 27 Gin
- - 4 London dry gin
- - 3 Old tom gin
- 19 Rum
- - 11 White rum
- - 4 Dark rum
- - 2 Gold rum
- - 1 Demerara rum
- - 1 Overproof white rum

I think yes and it might be a double-win - this could give us a way to replace Pedantic because it'd do basically the same thing!
The only gotcha is stuff like Triple sec where (afaict) grand marnier is a triple sec close alternative, but not a kind of triple sec. But that would be a totally acceptable loss if ^ this change makes things both simpler and more organized.


Bugfix

Changelog for PR #56
Changes.
12ad2e8: Bringen the composer/lock into the repo.
f6912f5: Fixed dir basepath -> /scripts/0-agency.txt.php.
23275fd: Fixed config. -> /scripts/4-feed_info.txt.php.
Note(s):
[10/9/2015 - 00:15H]: I will make a commit for StyleCI fixing.
[10/9/2015 - 00:17H]: I will ping any core member when i'm done. -> Still working on this one.

Yeah, I would make a new one with relative path fix + composer.lock added


fix: remove vulnerable dev dependencies

Remove grunt-cucumberjs as a dependency.
Move from qunitjs to qunit (same framework new name)
Not sure - it looked to me like grunt-cucumberjs is not used.
qunitjs is now published as qunit. The dependency would be updated to the next working version, not the latest. Is qunit actually used in the code? Was is probably replaced by karma-qunit?

Seems like grunt-cucumberjs is still used - however there is no update available for the vulnerability.


update What's Included Section in the Releases page

This PR updates - What's Included in the AWS Distro for OpenTelemetry Collector - section in the Releases documentation with AWS OTel Collector components in upcoming release.
Issue # 163

Merged upstream.


ValueError: Invalid file descriptor: -1

This error does not appear to prevent normal operation of the miner, but has been happening more and more frequently:
Traceback (most recent call last):
  File "/home/ec2-user/venv/lib64/python3.8/site-packages/skepticoin-0.1.15.dev38+gf75d821-py3.8.egg/skepticoin/networking/peer.py", line 848, in handle_remote_peer_selector_event
    remote_peer.handle_receive_data(recv_data)
  File "/home/ec2-user/venv/lib64/python3.8/site-packages/skepticoin-0.1.15.dev38+gf75d821-py3.8.egg/skepticoin/networking/peer.py", line 514, in handle_receive_data
    self.receiver.receive(data)
  File "/home/ec2-user/venv/lib64/python3.8/site-packages/skepticoin-0.1.15.dev38+gf75d821-py3.8.egg/skepticoin/networking/peer.py", line 363, in receive
    self.receive(b"")  # recurse to repeat (multiple messages could be received in a single socket read)
  File "/home/ec2-user/venv/lib64/python3.8/site-packages/skepticoin-0.1.15.dev38+gf75d821-py3.8.egg/skepticoin/networking/peer.py", line 358, in receive
    self.handle_message_data(self.buffer[:self.len])
  File "/home/ec2-user/venv/lib64/python3.8/site-packages/skepticoin-0.1.15.dev38+gf75d821-py3.8.egg/skepticoin/networking/peer.py", line 369, in handle_message_data
    self.peer.handle_message_received(header, message)
  File "/home/ec2-user/venv/lib64/python3.8/site-packages/skepticoin-0.1.15.dev38+gf75d821-py3.8.egg/skepticoin/networking/peer.py", line 495, in handle_message_received
    return self.handle_get_peers_message_received(header, message)
  File "/home/ec2-user/venv/lib64/python3.8/site-packages/skepticoin-0.1.15.dev38+gf75d821-py3.8.egg/skepticoin/networking/peer.py", line 739, in handle_get_peers_message_received
    self.send_message(PeersMessage(peers), prev_header=header)
  File "/home/ec2-user/venv/lib64/python3.8/site-packages/skepticoin-0.1.15.dev38+gf75d821-py3.8.egg/skepticoin/networking/peer.py", line 459, in send_message
    self.check_message_backlog()
  File "/home/ec2-user/venv/lib64/python3.8/site-packages/skepticoin-0.1.15.dev38+gf75d821-py3.8.egg/skepticoin/networking/peer.py", line 464, in check_message_backlog
    self.start_sending()
  File "/home/ec2-user/venv/lib64/python3.8/site-packages/skepticoin-0.1.15.dev38+gf75d821-py3.8.egg/skepticoin/networking/peer.py", line 467, in start_sending
    self.local_peer.selector.modify(self.sock, selectors.EVENT_READ | selectors.EVENT_WRITE, data=self)
  File "/usr/lib64/python3.8/selectors.py", line 377, in modify
    key = self._fd_to_key[self._fileobj_lookup(fileobj)]
  File "/usr/lib64/python3.8/selectors.py", line 225, in _fileobj_lookup
    return _fileobj_to_fd(fileobj)
  File "/usr/lib64/python3.8/selectors.py", line 42, in _fileobj_to_fd
    raise ValueError("Invalid file descriptor: {}".format(fd))

"Good" to hear that this is on master, I thought this was a bug introduced by my own changes.
I'll do some bisecting and find out what change caused this.

This is on the cloud-mining branch, which includes your fix to #42 that I merged in.

I have not seen this error in a long time. It was probably resolved by some combination of the fixes to #36, #45, and #71.

LOL as soon as I posted the above comment, I saw the error when using --log-to-stdout:
2021-06-13 11:43:52,596       <IP_ADDRESS> Disconnecting remote peer Invalid file descriptor: -1

@sashimi-houdini what is the purpose of a peer connecting to itself?

I don't see how a peer connecting to itself makes any sense. Does preventing connecting to <IP_ADDRESS> fix this issue?


Ability to disable certain features

Ability to disable certain features
I want to be able disable clipboard manager. And also disable certain search result types like google maps search. And also hide certain apps from search

PRs are welcome

You can now disable the clipboard manager and scratch-pad shortcuts from the settings.


tabindex doesn't work

Hello
I use tabindex, but doesn't work for my  eg =)
Can you fix it ? please

Do you want to use tabindex on wysibb toolbar buttons?

no, for my  "Post"


Improvements to upper and lower of enclosure STL files

Added tab to upper and part to lower to keep board pushed against upper

@motorina0 Updated HWW STL files for 3D printing


Added code entitlement status.

Unable to expand on negative tests, as I don't have the necessary Twitch scenario to test this IRL to see what the possible returns are.
Access is controlled via an app access token on the calling service. The client ID associated with the app access token must be approved by Twitch as part of a contracted arrangement.
@nicklaw5 let me know how you want to handle the additional test cases.
Docs: https://dev.twitch.tv/docs/api/reference#get-code-status

Pull Request Test Coverage Report for Build 388086240

8 of 10 (80.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 90.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

entitlement_codes.go
8
10
80.0%

Totals

Change from base Build 387945074:
0.3%

Covered Lines:
639

Relevant Lines:
710

💛  - Coveralls

That's all from me in the next 24 hours. I hope to knock out some more endpoints soon, but haven't started on others yet.


Any chance of enabling this CB to work with kafka?

Hi @joldham1023
This cookbook is agnostic about Winlogbeat outputs. Just as an example, you could configure Kafka output like that:
node.default['winlogbeat']['override_config'] = {
  'winlogbeat' => {
    'registry_file' => "#{ENV['ProgramData']}\\Winlogbeat\\.winlogbeat.yml",
    'event_logs' => [
      { 'name' => 'System' },
    ],
  },
  'output' => {
    'kafka' => {
      'enabled' => true,
      'hosts' => ["kafka1:9092", "kafka2:9092", "kafka3:9092"],

      'topic' => '%{[type]}',
    },
  },
}

Docs for Winlogbeat 5.6


Can't install for Laravel 5.5

Installation fails for L 5.5
Could be a problem with the illuminate/queue version.
This is the error message from composer:
vladski/laravel-sms-clicksend v1.0.1 requires illuminate/queue 5.1.|5.2.|5.3.|5.4. -> satisfiable by illuminate/queue[v5.1.1, v5.1.13, v5.1.16, v5.1.2, v5.1.20, v5.1.22, v5.1.25, v5.1.28, v5.1.30, v5.1.31, v5.1.41, v5.1.6, v5.1.8, v5.2.0, v5.2.19, v5.2.21, v5.2.24, v5.2.25, v5.2.26, v5.2.27, v5.2.28, v5.2.31, v5.2.32, v5.2.37, v5.2.43, v5.2.45, v5.2.6, v5.2.7, v5.3.0, v5.3.16, v5.3.23, v5.3.4, v5.4.0, v5.4.13, v5.4.17, v5.4.19, v5.4.27, v5.4.36, v5.4.9].

I try to install it to laravel 7.20 , It also fails
Problem 1
- Installation request for vladski/laravel-sms-clicksend ^1.0 -> satisfiable by vladski/laravel-sms-clicksend[v1.0.1].
- Conclusion: remove laravel/framework v7.20.0
- Conclusion: don't install laravel/framework v7.20.0
- vladski/laravel-sms-clicksend v1.0.1 requires illuminate/notifications 5.1.|5.2.|5.3.|5.4. -> satisfiable by illuminate/notifications[5.3.x-dev, 5.4.x-dev, v5.3.0, v5.3.16, v5.3.23, v5.3.4, v5.4.0, v5.4.13, v5.4.17, v5.4.19, v5.4.27, v5.4.36, v5.4.9].
- don't install illuminate/notifications 5.3.x-dev|don't install laravel/framework v7.20.0


Add a WeldBundle to Dropwizard

This feature makes it easy to get started with CDI using the Weld implementation.

Coverage increased (+0.03%) to 84.552% when pulling 8233c8f2c9168b2114f51f00e7e27487c7cb77e0 on jelmerterwal:cdi_weld into 223be464b1e58ac8e85137c71bbb541bed760403 on dropwizard:master.

@jelmerterwal Thanks for your contribution!
We try to keep the core Dropwizard project as small and lean as possible, so please create a separate project for your Weld bundle and add it to the Dropwizard Modules Directory via https://github.com/dropwizard/modules.dropwizard.io/pulls

@jelmerterwal As a side note, it would be great if you could integrate Weld with the HK2 injector used by Jersey, e. g. via https://jersey.java.net/documentation/latest/cdi.support.html#cdi.support.weld.se

Coverage increased (+0.03%) to 84.552% when pulling a665a1ce25978bb5652bd40ae94e2348fc099648 on jelmerterwal:cdi_weld into 223be464b1e58ac8e85137c71bbb541bed760403 on dropwizard:master.

@joschi Just thought this might be something a lot of people might need. However, I do understand your point.
I believe that is exactly the approach taken :)


[IMPROVEMENT] Edit Profile > Keyboard should hide when user taps outside the input field

Environment:
Rocket Chat App version 2.4.0 Build 2027
Device (or simulator) you're running with: Samsung S8 version 8.0.0
Pre-Condition:
User is logged in.
Steps:

Tap the hamburger menu icon on the upper left corner of the page
On the menus Tap Profile
Tap on any of the input fields (name, username, email or avatar url)
Verify keyboard should appear
Tap outside the input field or tap the hamburger menu then select Settings or Chats

Expected Result
Keyboard should hide
Actual Result
Keyboard stays open
Please see attached video
https://www.dropbox.com/s/5uopkjo1hgk587o/20180711_150113.mp4?dl=0

We don't plan to touch this at this point, but PRs are welcome. 👍


Please pre-compile aws-amplify-react/dist/API/GraphQL/Connect.js

When building app with this dependency with create-react-app it throws error:
Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

 	./node_modules/aws-amplify-react/dist/API/GraphQL/Connect.js:65

Read more here: http://bit.ly/2tRViJ9

Please pre-compile aws-amplify-react/dist/API/GraphQL/Connect.js
see http://bit.ly/2tRViJ9

Hello! Thanks for plugging the issue - I was using withAuthenticator() on a Gatsby starter site and was getting that error. Now I'm getting a "No userPool" error when I try to log in. I've associated my Gatsby project with a new AWS Mobile Hub backend, but still getting the same error when I try to sign up. It is most definitely associated with a Cognito user pool. Thoughts?

Hi<EMAIL_ADDRESS>fixed that problem.
The issue you mention with No userPool it happen to me.
Please check if exists node_modules/aws-amplify-react/node_modules/aws-amplify
If that happen I fixed by installing aws-amplify with the same version that is required for aws-amplify-react. And then install aws-amplify-react that should remove the folder I mentioned before.

Hi @elorzafe, thanks for the tip! I tried upgrading to the latest aws-amplify (0.3.0) and aws-amplify-react (0.1.41) and made sure neither module was installed in node_modules, but to no avail. Maybe I'm doing something wrong?
To recreate this:

gatsby new test
cd test
[Create new Mobile Hub project, note the id number, and add a Cognito user pool]
awsmobile init
npm i --save aws-amplify-react

Edit the src/pages/page-2.js to add:
import {withAuthenticator} from 'aws-amplify-react';
Change last line to be:
export default withAuthenticator(SecondPage);

gatsby develop

Then navigate to the second page in the web browser, try to create a new user. I get a "No userPool" error. I can confirm withAuthenticator is working perfectly with a CRA app.
Thoughts?
Thank you!

Where did you initialize this?
import Amplify from 'aws-amplify';
import awsmobile from './aws-exports';
Amplify.configure(awsmobile);

I usually do this in the entry point of my app

:-)


Provide a way to override API status

There might be valid reasons to use implementation (rather than api) even in case a class is present in a signature of a public method.
The method could be visible-for-test only or internal or something like that.

This seems like an edge case and I would rank it low in priority.

I'm going to close this as duplicate and add your comment to https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/issues/69


feat: add support for glob targets

This PR does not build yet; there is more work to call  globsToFilePaths in appropriate locations. Additionally the libTargets and binTargets need review / adjustment. I'm not sure how to work this into functions like buildModuleOleanAndCTargetsWithDepTargets yet.

Just the glob code is fine, I can handle the build part. However, as you did make some edits there, here are some notes:

The term ' targets' are used for things that are, in fact, targets (i..e, of type Target or ActiveTarget).  So libTargets should really just be called modules (or libModules).
The binRoot should remain as is. For binaries, the entry point is main which can only be located in one file (the root) so the normal strategy of recursively imports of the root is an ideal strategy there,

Also, why not just use Lean.modToFilePath with an empty extension for modToDir?

(1) because it would make more sense for modToFilePath to use modToDir instead of the other way around (it is the go function in that definition), and (2) p.withExtension "" is not actually equal to p. It handles the file path like a file, not a directory, and so it mangles directories with dots: "foo.bar".withExtension "" = "foo".

I fixed things along the lines of your suggestions; you should have the ability to push more to this branch if you want to do the build part.

One more note: the Package field should just be named to libModules (they are not specific to the static lib build -- they are also used to build the .olean files).

@digama0 okay, sounds good! Thanks for the code!

What is the intended use case of this PR?

and so it mangles directories with dots

Uh, surely we have other issues if someone wants to use a path like that in a Lean package? Even if the import is appropriately escaped, modToFilePath will misbehave.

@Kha It seems to work just fine:
#eval Lean.modToFilePath "" `Foo.«Bar.Baz».Quux "lean"
-- FilePath.mk "/Foo/Bar.Baz/Quux.lean"

What is the intended use case of this PR?

The main purpose is to allow libraries that don't have a single root file that imports everything, and instead allow a library to specify multiple files to build, or everything in a given folder (or multiple folders). In particular, I want to use this for mathlib4 so that we don't have to hack this in an external makefile in CI - we want every lean file in the src folder to be built, even if it is not imported by any files.

It probably won't surprise you to hear that I specifically designed the system to work like this (after Rust's module system), just as I'm not surprised this doesn't match mathlib's expectations. I'd still like to understand your viewpoint better. Do you want no Mathlib.lean, Mathlib/Data.lean etc. files at all, or do you want them to import only specific submodules? And why?

It probably won't surprise you to hear that I specifically designed the system to work like this (after Rust's module system), just as I'm not surprised this doesn't match mathlib's expectations.

Yes, I know that this is how leanpkg works, and I would like lake to be more flexible to alternative approaches. There is some discussion leading up to this PR at https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/.5BRFC.5D.20name.2Fversion.20package.20fields/near/254451319, continuing into the discussion of how it is done in python.

I'd still like to understand your viewpoint better. Do you want no Mathlib.lean, Mathlib/Data.lean etc. files at all, or do you want them to import only specific submodules? And why?

I want the library author to decide whether Mathlib.lean exists, and if it does, it does not necessarily need to import everything in the package. This is basically the library author deciding what import Mathlib will do in a downstream library, and authors should have the freedom to make this not an exhaustive import, even if it often is. Similarly for Mathlib/Data.lean and other submodules - they exist if the library author wants to support users writing import Mathlib.Data, and they might not import everything under them.
I bring up import tactic as a specific example of this in mathlib: it imports most of the tactics in the directory, but not some oddball tactics that are very long to compile, discouraged, or for testing only.

authors should have the freedom to make this not an exhaustive import

In theory, this could also be achieved by a new kind of import that merely marks the mentioned module as part of the package without making the current module depend on it. It would be somewhat like a pub mod without a pub use in Rust, though the mix of modules and namespaces in Lean complicates comparisons.
You might ask what the point of that would be compared to the alternative implemented in this PR: it preserves the property of expressing clear intent to include a file in a package. I consider filesystem directories a bad source of truth because of stray untracked files from switching branches, temp files created by the editor etc. pp.  Basically, while a build system naturally needs to access folder entries, I believe it should never need to scan through them. But I also understand that one's clear intent might be another's unnecessary boilerplate.

Note that this PR still currently won't all one to include everything in the source directory (would still need to specific each of the top level files). To do so would require a Glob.all.

You should be able to use Glob.subdirs Name.anonymous to include everything under the source directory.

@Kha For me the primary reason to have direct support in the build tool for directory traversal is because if lake doesn't support it, we're just going to have a makefile that wraps lake and does it anyway. This already exists in mathlib CI, because orphaned lean files is a thing that happens and when reviewing PRs this is an error that we want to be notified about. I really want to get away from scripting on top of lake, so I want to make sure that lake at least supports the present concerns for lean 4 compilation in existing projects.

@digama0 globs are now fully supported!

@digama0

You should be able to use Glob.subdirs Name.anonymous to include everything under the source directory (but it would make sense to make Glob.all a definition for that).

Just noticed this. Sadly, this is difficult, The glob needs to provide to pieces of information: which files to load and which modules correspond to those files. A Glob.all what have the former, but not the later. The later is necessary so the build system can determine what modules are considered local. However, for mathlib, I would imagine only having to specify only the top-level modules/directories is still a major improvement?

Just noticed this. Sadly, this is difficult, The glob needs to provide to pieces of information: which files to load and which modules correspond to those files (and the later part currently needs to be pure). This corresponds to Glob.pushModules and Glob.matches, respectively, in the current code. A Glob.all would provide the former, but not the later. The later is necessary so the build system can determine what modules are considered local.

As I mentioned in Zulip, I would like to eliminate the reliance on the "module roots" view of things. One way to determine whether a module is local (not pure, though) is to check whether the corresponding file exists in the source directory at the expected location. This can be made into a pure lookup by precomputing all accessible lean files via directory traversal, or it can be cached so that you don't have to hit the disk too much.

@digama0 and as I mentioned on Zulip, I very much wish to keep the 'module roots' view of things as the default and preferred way of doing things. I am will to support alternative approaches (as is feasible), but such changes should not inhibited / interfere with the module root approach.

While your solution is a reasonable one, and  thus something I will keep in mind. It is not currently easy to do. There is no way to pre-compute this information and pass it to the target (or determine it at the time of import) in the current build system structure. However, if, in the future, such a thing becomes more straightforward, I will reconsider adding such a feature.

Also, it is important to note that one of the plan features of Lake is cloud builds, where we may be downloading compiled artifacts for modules for package purely from the information contained in package.lean without cloning the package's source. In which case, it would not even be possible to derive whether a module is part of a package from its source tree. That is, a dependent package should be able to figure out what modules are owned by tis dependency without downloading the source of the package.

Another option, that might meet both our requirements: A package can declare what modules it contains, using a list of globs like currently, but this list can potentially overlap with dependent packages, and the later package always "wins" when there is a conflict. For example, let's say that the std package claims Std.*, and more_std depends on std and claims Std.FancyMap.*, then Std.FancyMap.* is in more_std and everything else in Std.* is in std. So for mathlib, that would mean declaring all the top level directories, plus any data.* namespaces that are claimed by lean core.

@digama0 that's what currently happens?


Cursor Issue Fixed for Publisher Scope

Related issue : https://github.com/wso2/product-apim/issues/12808

Same issue is fixed in a different way using https://github.com/wso2/apim-apps/pull/341 and merged. Because of that, this PR is closed.


Cannot post cyrillic symbols with OkHttp.

I'm trying to post cyrillic login and password with OkHttp:
RequestBody formBody = new FormEncodingBuilder()
    .add("login", user)
    .add("pass", password)
    .build();

Request request = new Request.Builder()
    .addHeader("User-Agent", USER_AGENT)
    .addHeader("Connection", "keep-alive")
    .url(URL)
    .post(formBody)
    .build();

OkHttpClient client = new OkHttpClient();
Response response = client.newCall(request).execute();
if (!response.isSuccessful()) throw new IOException("Unexpected code " + response);
String responseBody = response.body().string();

With latin symbols it works just fine.

Could you provide a test case with the expected behavior? FormEncodingBuilderTest should get you started.

I've tried to post some data on a website. I cannot give you exact example.
I've managed to solve the issue with such code:
.addEncoded("login", URLEncoder.encode(user, "CP1251"))
.addEncoded("pass", URLEncoder.encode(password, "CP1251"))

As far as I understood, I should have encode my encoding and then use existing method addEncoded.

Cool. By the way, you should try to convince the webservice that expects CP1251 to upgrade their systems to also support UTF-8.


split out specs to unit and integration

just some re-org

LGTM

@talevy Could you enable redis on travis and run the integration test there?

@ph, the integration test is running on travis?

@talevy Nothing is blocking travis to run the integration test, you just need to make sure the travis yml file install or active redis and define a new test script.

@ph from my understanding, I have enabled integration testing on travis

@talevy My bad I haven't read it carefully enough.


Fully mimic the signature of django.core.mail.send_mail

The current signature of email_extras.utils.send_mail:
def send_mail(subject, body_text, addr_from, addr_to, fail_silently=False,
              attachments=None, body_html=None, connection=None, headers=None):

is supposed to mimic the signature of django.core.mail.send_mail:
def send_mail(subject, message, from_email, recipient_list,
              fail_silently=False, auth_user=None, auth_password=None,
              connection=None, html_message=None):

but it doesn't quite manage it.
This ensures that our send_mail function completely mimics Django's send_mail function.
Changes:

The body_html option should be renamed to html_message, but to ensure backwards compatibility I kept them both and made sure users only specified one of them, and threw a warning if body_html was used.
The addr_to argument was renamed to recipient_list. This is more of a cosmetic change than anything else, but it should reduce the cognitive burden for anybody comparing the source code for each function.
Used Python's dict() constructor and Django's values_list() to create the dictionary of (address, use_asc) pairs without explicit loops (read: more Pythonic).
The auth_user and auth_password options were added, and used if the connection option was None. This is exactly how Django's send_mail function uses them.
Updated send_mail_template to use the new argument/option names.

Is this backward compatible? Can you keep lines under 80 chars?
Thanks for your help.

It should be completely backwards compatible, but it does throw up a warning if the body_html option is specified instead of the html_message option.
The previous function didn't accept an html_message option - it called that option body_html. So it's impossible that current users are specifying both. Because of that, it errors out if users try to pass in both body_html and html_message. That means it's backwards compatible, but the function now refuses to guess in the face of ambiguity.
And yes I can reformat it to < 80 chars. One sec.

Makes sense, thanks a lot!

I fixed the line length to be < 80 chars. This is now ready to merge.

Thanks again


Proposal: Improved QR scanning - Scanning of inverted QR

It seems like scanning of inverted QR (white QR on darker background) is not supported in the current version.
It is a very desirable feature in order to be able to scan steel plates created on the SeedHammer machine.
Example (that scans on the SeedHammer controller):

Implemented in 5d99eee8. Sparrow will now invert the cropped frame (area within the dotted line box) and scan for inverted QRs. The output descriptor above scans correctly.

Thank you!


Open Safari links in githawk

Hi,
Is there a chance, if I open a github link in safari, that it automatically opens it in githawk? Like youtube, Instagram and other apps are doing?

Hi @misanthrophy,
What I believe you're referring to there is a technology called Universal Linking where Apple will open a native app (if installed) for certain compatible URLs.
Unfortunately this requires a file to be uploaded to the website itself in order to redirect users to the native app. As we don't own or have any association with GitHub we are unable to do this.
There have been some attempts in the past to do something a bit different - for example using an action extension demonstrated here.
We do however have support for Opener which lets you easily open a URL in a variety of apps.
Another possible solution would be to introduce our own redirect URL. For instance if I shared a URL https://githawk.com/Owner/Repo/issues/1 then this could redirect users to the app, if installed, or redirect to github.com if not installed.
This would only work for these URLs though, benefitting from everyone using them which would likely mean an inconsistent experience not ideal.

As @Sherlouk mentioned, this is unfortunately not possible...


[FEATURE]: Add Container Storage Modules to the Rancher (RKE) marketplace

Describe the solution you'd like
Users on Rancher (RKE) environments should be able to deploy Container Storage Modules (DRIVERS ONLY for now) via Rancher Market Place.
Additional context
CSM HELM Charts will be available in the Rancher Market Place
CSM will be installed through the HELM Charts from Rancher Market Place

Broken charts are fixed in rancher charts


Can i backup the entries from Preset Text node?

Hi, is there a way to i backup the entries from the Preset Text node? They have to be stored somewhere, right? ^^

If you press F12 to open the browser console, then type localStorage["pysssss.PresetText.Presets"]

If you press F12 to open the browser console, then type localStorage["pysssss.PresetText.Presets"]

I think he would like a text file that can be backup.
Such as a PresetText.txt in a folder (eg. comfyui/wildcards/PresetText.txt).


⚠ Bofrost.com has degraded performance

In 1f6a8e7, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 671 ms

Resolved: Bofrost.com performance has improved in 8fb3d93 after 9 minutes.


Improve InvalidTransaction::AncientBirthBlock doc comment

The AncientBirthBlock transaction validity error is a bit nuanced and the current doc comment relies on a rather cyclical explanation.
I think giving the reader starting points for clarifying what constitutes a birth block and what makes one ancient is a cheap way to improve the debugging experience for transaction creators. I attempt to do that in this PR while keeping it concise.
I based these off of the docs here and the logic here
cc @dvdplm, @joepetrowski

bot merge


sql agent service not started

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 652c3fee-c6a9-f163-a281-6e2ae73da6f5
Version Independent ID: 8b88a92e-0d8d-d2b2-2a37-e96565a71045
Content: Quickstart: Deploy a SQL Server container cluster on Azure - SQL Server
Content Source: docs/linux/quickstart-sql-server-containers-azure.md
Service: sql
Sub-service: linux
GitHub Login: @rwestMSFT
Microsoft Alias: randolphwest

@cletocs Please provide more information about the issue you're experiencing, and what steps you took so we can recreate it.

@cletocs As we have not heard from you, I am closing this issue. If you decide to provide some information, please do so in the comments below.


Merge branch 'develop' into master

:tada: This PR is included in version 0.3.20 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Light Level Sky

I've searched existing issues and couldn't find a duplicate.

[X] I confirm this is not a duplicate.

Operating System
Linux manjaro
Server Software Version/Commit
the online server
What happened?
The Light Level of the sky is zero
To Reproduce
Press F3: Client Light: ? (0, ?)
? is variable
Expected behavior
Light Level shouldn't be zero

Currently light is not calculated, We use static values


Add .xlsm as known file type

Add .xlsm (Microsoft Excel macro-enabled spreadsheet) to the type lookup. XLSM files are supported by Power BI but until now they could not be uploaded, refer to issue #349.
Fixes #349.
Changes proposed in this pull request:

Adds a single line to Get-ItemType.ps1 for the .xlsm file type
Minor reformat of layout (spacing) for neatness

How to test this code:

Create an .xlsm file in Excel, save it as C:\Temp\Just_a_test.xlsm
Upload the file using Write-RsRestCatalogItem -ReportPortalURI $youruri -Path 'C:\Temp\Just_a_test.xlsm' -RsFolder $DestFolder
(Previously this would fail with an error message - (400) Bad Request. After this change to Get-ItemType.ps1 it seems to run without any issues.
)

Has been tested on (remove any that don't apply):

Powershell 5.1
Windows Server 2016

@microsoft-github-policy-service agree

So, how many weeks does it usually take to approve a single-line change to the code?


Update service-admin-premium-multi-geo.md

Add an item that remain in the tenant home region.
The new playground saved state is a feature that we are releasing soon that will allow users to continue their progress in the developer-sandbox from where they left off.

@liavZayde : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Andy Grove

安迪·葛洛夫 安迪·葛洛夫 [An1 di2 · Ge2 luo4 fu1] /Andy Grove (1936-2016), Hungarian-American businessman, engineer, and CEO of Intel Corporation/
Only noticed now, when I searched middle dot · (Chinese convention for indicating full names that are not Chinese) in CedPane, there are no full names in CedPane, so I think this will do:
葛洛夫 葛洛夫 [Ge2 luo4 fu1] /Grove/
Reference: https://blog.csdn.net/Byeweiyang/article/details/125841972#:~:text=安迪·葛洛夫

Thanks.  Confirmed 葛洛夫 is used for several different people called Grove (and Groff) so will add a generic entry.  Correct I'm not using entries with mid-dot (most software won't scan across mid-dot anyway, and not every Chinese page uses mid-dot as it should, plus you catch a lot more people if you enter the given names and the surnames separately....)


phantoms cannot be dismissed / this feedback style too obtrusive

I tried this on a python project that has a lot of pycodestyle errors (indentation mostly). While perhaps I should do something about those in the first place, this makes it pretty hard to work with (and pretty hard to do something about the errors 😉) :

Sublime's standard build result phantoms can be dismissed, and then cycled through with next_result and prev_result.
Showing unrequested feedback using phantoms is really obtrusive. All code has to shift to make place for the phantoms, which makes for a really bumpy ride if there is more than one phantom. Pretty much unusable.

I would suggest using linter-style (squiggly underline and/or gutter icons) feedback during editing, and then display the phantoms using a command. Perhaps the current behaviour should be optional, but it's easy enough to add a trigger for a "show phantoms" command. I definitely don't think it should be the default behaviour.

It should be configurable in the settings: https://github.com/tomv564/LSP/blob/master/LSP.sublime-settings#L43

I feel your pain with the default linters from python-language-server, there is an outstanding issue to make them configurable here: https://github.com/palantir/python-language-server/issues/57.
That linter does already try to read any configuration / comments in code to ignore certain rules.
As for LSP itself:
As @rwols pointed out, adding show_diagnostics_phantoms: false to your LSP package settings should result the linter-style feedback being shown all the time.
Dismissing the phantoms is tricky to implement as the diagnostics they are based on will be recreated every time you edit the document.
The linter-style feedback may not be visible unless you have SublimeLinter installed, I will create an issue to find a good scope to use that works with many color schemes.

I feel your pain with the default linters from python-language-server

Well, it's just an example where there is more than one error. Silencing the linter is not the solution, because the linter is not the problem, the UX of diagnostics_phantoms is just not very good.

adding show_diagnostics_phantoms: false to your LSP package settings should result the linter-style feedback being shown all the time

Wouldn't that make them never show at all?

Dismissing the phantoms is tricky to implement as the diagnostics they are based on will be recreated every time you edit the document.

You're describing the problem here: diagnostics are run all the time and that will make phantoms appear and disappear all the time.
What I'm saying is, you shouldn't use phantoms this way, not because of this particular linter, but because they're super disruptive and they get in the way of editing code. If I wanted an annoying tool that gets in the way I'd be using an IDE 😉
Phantoms are super useful when dealing with build errors, because they stay visible while editing and you can go through them one by one. However, the phantoms here disappear as soon as you start editing.
I don't think a setting to switch them off is going to solve anything, the approach to UX needs to change completely. You already have the same info in a popup on hover, which is excellent. You can have a marker in the gutter to tell you something is wrong in a line. I understand Sublime doesn't let you do the squiggly underline via a nice api, but you could do worse than lean on SublimeLinter here. It's an excellent package that solves the unobtrusive feedback issue completely. And then, when I tell LSP to "show me everything that's wrong with this file", that's a good moment to show the phantoms. Have the phantoms stick around while I'm editing, and let me dismiss them when I'm done with them.
Perhaps I'm so used to working with SublimeLinter and the built-in build system that I expect it to work that way. But this package takes over much of what those features already offer, so why shouldn't it mirror those features? They've been polished for years and mostly get it right. LSP should at least be just as focussed on supporting your workflow instead of interrupting it.

Agree 100% that SublimeLinter gets it right, and I think LSP covers the gutter + squiggly marks functionality? I see squiggly lines and gutter marks in your GIF, and this is also what LSP produces in this screenshot:

And then, when I tell LSP to "show me everything that's wrong with this file", that's a good moment to show the phantoms. Have the phantoms stick around while I'm editing, and let me dismiss them when I'm done with them.

That does sound like a nice workflow when working with a build system. I have to think about how this fits with an always-updating language service. You don't want the phantoms to update while you're in "fixing mode", so how do you want to be notified of new errors you are creating?

I see squiggly lines and gutter marks in your GIF, and this is also what LSP produces in this screenshot:

I wasn't sure if that was because of SublimeLinter running in the background, but if LSP already provides this that's excellent.

You don't want the phantoms to update while you're in "fixing mode",

You're probably right about that...

so how do you want to be notified of new errors you are creating?

Isn't that what the squigglies are for? That's what the linter does: squigglies update live and if your caret is in a problematic region the message is show in the statusbar. I expect LSP might be able to get more detailed messages and auto-fix actions, so would want to be able to open a popup (as in your screenshot) to deal with the error at my caret.
Perhaps "fixing mode" could be a mode you enter explicitly, and a slightly different behaviour that gives more visibility to the errors could work here while it doesn't during normal editing. Exiting "fixing mode" could be as simple as dismissing the phantoms.
Phantoms that change position are super annoying and you definitely don't want to remove and restore them "on change". Ideally, but I'm not sure that's even possible, you'd want to just remove the error that has just been solved.
The language service isn't fully continuous right? If I'm right it waits for a certain action (or perhaps a timeout) before updating the diagnostics. Now it removes all phantoms as soon as you start editing, and when you're done they return. So while you're editing you lose the visual info of exactly what you're fixing, and possibly the next problem you might want to go to and fix. It would be nice if it removes the phantom for problem A as soon as I fixed that one, while keeping the phantom for problem B visible at all times so I can go there and continue working through the errors. Now this might be stretching what the phantoms system was designed for, I'm just thinking aloud about what the interaction could be here.

How about the following:

A "Create Phantoms" command that creates phantoms from a diagnostics snapshot
We restore the close button on the phantoms so you can dismiss them individually.
A "Dismiss Phantoms" command that gets rid of all of them.

The current behaviour could then be made configurable with:
"create_diagnostics_phantoms_on_save": true
"dismiss_diagnostics_phantoms_on_dirty": true
And in your case you'd probably want both of those set to false.
I think this a good attempt to deliver the best of both worlds. I hope for a little more feedback from you and other users before starting on this feature.
In the meantime, there are configuration options for pycodestyle in this issue: https://github.com/palantir/python-language-server/issues/93
If you're determined to short all those lines, then the Format Document command might be worth a try.

A "Create Phantoms" command that creates phantoms from a diagnostics snapshot

👍

We restore the close button on the phantoms so you can dismiss them individually.

I'm not even sure the api allows that, I think you have to dismiss (and then recreate) them all. But I haven't dived too deeply into what you can do here.
Another thought: after creating the phantoms, update/reload them on save events until they're dismissed. I'm not sure how jumpy that would be, but it's a way to be more interactive/live than traditional build output.

I hope for a little more feedback from you and other users before starting on this feature.

Right now disabling the phantoms doesn't remove anything too valuable, so that's good enough option for me. Perhaps that's also telling (why is the feature) even there?), but it might also be just my opinion.
I've never been a heavy user of LSP-like features, mostly because most implementations in editors are annoying and get in the way of writing code, and IDE's are seemingly all about getting in the way. I think LSP is super promising, so I'll definitely share opinions and ideas.

If you're determined to short all those lines, then the Format Document command might be worth a try.

Yeah, this particular file isn't something I maintain, but a good test case. It has a flake8 config, pycodestyle takes a similar config file and that also solves it. Realistically, if there is real time linting and perhaps format on save, you don't have to solve too many errors at once unless you're introducing the tests/linter to an existing project.

Phantoms have been disabled by default by #37, a new issue was created to explore suggestions in this issue.


Types with CudaArray elements cannot be saved to JLD because of pointer exception

I'd like to fix this so people can save and load machine learning models that use CudaArray's without having to explicitly copy everything to cpu.  Is the right way to overwrite serialize - deserialize?  Or is it to introduce a new cpu array type that CudaArrays know to convert themselves to and from during load/save?  Or is there some other way?

See https://github.com/JuliaLang/JLD.jl/blob/master/doc/jld.md#custom-serialization

Thanks Tim, the following three lines solved the problem:
    type _CudaArraySave; a::Array; end
    JLD.writeas(c::CudaArray) = _CudaArraySave(to_host(c))
    JLD.readas(d::_CudaArraySave) = CudaArray(d.a)

Do you want to put this in CUDArt?  I was going to submit a pull request but I couldn't be sure if you wanted JLD to be a requirement for CUDArt.  In either case, this issue can be closed.

If you can come up with a solution that exploits Requires.jl, do you think that would be better?


SealedJob image update

I am deploying a SealedJob using Keda. It is working fine. But I don't know how to update the image which is running in the jobs.
I am using Keda 2.7.1.
My SealedJob object has rolloutStrategy: gradual, but to update the image I am currently removing the entire object by kubectl delete and redeploying it.
If anyone knows the any better command, please help.

@JorTurFer
Hi, so the way we can update the image of a deployment using the kubectl set image command, that same way I wanted to update the ScaledJob image.
And by using rolloutStrategy: gradual, I wanted to use the image for the next triggered jobs.

oh, did you mean a single kubectl command for setting that parameter instead of applying the whole manifest?

@JorTurFer
Yes, just to update the image.

My SealedJob object has rolloutStrategy: gradual, but to update the image I am currently removing the entire object by kubectl delete and redeploying it.

You could just redeploy it doing again kubectl apply -f MANIFEST.YAML

@JorTurFer
Yes, just to update the image.

You could use kubectl patch to modify the images

@JorTurFer
Can you give me any command?

kubectl patch

With this command
kubectl patch ScaledJob eod-heurestics-job  -n ml-iot-camera --patch 'spec:\n jobTargetRef:\n  template:\n   spec:\n    containers:\n     - name: eod-heurestics-job\n       image: <container>'

I am facing this error
error: unable to parse "spec:\\n jobTargetRef:\\n  template:\\n   spec:\\n    containers:\\n     - name: eod-heurestics-job\\n       image: <container>": yaml: mapping values are not allowed in this context

I have tried this and works:
kubectl patch ScaledJob test --type='merge' --patch '{"spec": { "jobTargetRef": { "template": { "spec": { "containers": [{ "image": "nginx", "name": "test" } ] }}}}}'
probably you have any typo in your command
In any case, I suggest reapplying the manifest, using kubectl apply -f manifest.yaml you can modify the manifest and reapply it with the same command, if you have conflicts I guess that it's because you use kubectl create instead of kubectl apply, I mean, you can use kubectl apply always, even the resource is not created yet, it's idempotent


Update tag.cson

Was an issue flagged by deprecation cop.

Thanks @smlombardi
This has been fixed with the latest release with a couple more other changes to make the package 1.0 API compatible.
Please update tag to 0.3.0.


help idk how to add my mouse

idek what mouse am i using i know its from bloody and i dont know how to add it help

closing this one. @smooua please file a new issue once you can provide sufficient information that others can act on.