G7

Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
[ ] There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

3199 of 4543 (70.42%)  changed or added relevant lines in 51 files are covered.
60 unchanged lines in 15 files lost coverage.
Overall coverage increased (+9.6%) to 58.829%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

routing/router.go
6
7
85.71%

channeldb/graph_cache.go
41
43
95.35%

discovery/chan_series.go
18
20
90.0%

htlcswitch/link.go
11
13
84.62%

htlcswitch/switch.go
8
10
80.0%

netann/chan_status_manager.go
7
9
77.78%

peer/brontide.go
29
31
93.55%

discovery/message_store.go
9
12
75.0%

graph/validation_barrier.go
33
36
91.67%

lnrpc/devrpc/dev_server.go
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

discovery/syncer.go
1
86.18%

routing/localchans/manager.go
1
59.4%

discovery/chan_series.go
1
80.73%

peer/brontide.go
2
77.8%

lnrpc/routerrpc/router_backend.go
2
65.87%

rpcserver.go
2
70.9%

discovery/sync_manager.go
3
91.79%

funding/manager.go
4
73.89%

discovery/gossiper.go
4
76.54%

channeldb/channel.go
4
77.38%

Totals

Change from base Build<PHONE_NUMBER>3:
9.6%

Covered Lines:
132362

Relevant Lines:
224996

💛  - Coveralls


ImportError for from astropy.utils.data._open_shelve

I'm getting this error with astropy 3.0.dev20203 and astroplan d5045d3bfbead5e0da9aca43475be3d32b78d5e3
Can someone reproduce the issue?
Is it possible to avoid the import of "private" things from Astropy like _open_shelve: this is relying on internals and is error-prone, no?
In [1]: from astroplan import FixedTarget
f---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-ff17affa8f6e> in <module>()
----> 1 from astroplan import FixedTarget

~/code/astroplan/astroplan/__init__.py in <module>()
     21 # For egg_info test builds to pass, put package imports here.
     22 if not _ASTROPY_SETUP_:
---> 23     from .utils import *
     24     from .observer import *
     25     from .target import *

~/code/astroplan/astroplan/utils.py in <module>()
     12 from astropy.time import Time
     13 import astropy.units as u
---> 14 from astropy.utils.data import (_get_download_cache_locs, CacheMissingWarning,
     15                                 _open_shelve)
     16 from astropy.coordinates import EarthLocation

ImportError: cannot import name '_open_shelve'

If it's not trivial to fix it might be worth an issue on astropy. Even if it's an internal function if it's used (often) in downstream packages it might be a good idea to deprecate it instead of removing it outright.

Well, if this is really needed and Astropy core wants to expose that functionality, they should expose it as a public, documented function. Or if it's not really needed astroplan and other potential callers should be adapted. Probably @bmorris3 or @eteq will know or have an opinion on this?

In astropy it was a workaround for some regression of shelve for python <3.4, so I would be inclined not to put it back, given that it wasn't a public function in the first place.
Based on a quick github search, it seems that it's only astroquery and astroplan that still use it, other results were mostly astropy forks etc.
Note that astroquery already has a local workaround.


Refactor get block item status

Purpose
Refactor getBlockItemStatus to utilise new BlockTransactionEvent class instead of TransactionStatus and TransactionSummary as these cannot capture everything returned by the GRPCv2 API.
Changes
Refactored getBlockItemStatus. Added BlockItemStatus and BlockItemSummaryInBlock.
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

Included in https://github.com/Concordium/concordium-java-sdk/pull/253


[c++] Pre-neatens before making unit-test helpers for variant-indexed dataframes

Issue and/or context: This is a line-count-reducing under-diff following on #2919 for issue #2407 / [sc-51048].
The intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Just some prep for my next step to unit-test #2916 and #2917, namely, we need libtiledbsoma-level support for variant-indexed dataframes (those whose dim is something other than a single int64).
Notes for Reviewer:
#2785 is unreviewable as-is: besides being a WIP, it's an all-in-one experimental area. Smaller PRs such as this one are being offered for manageable review.

Thanks @nguyenv !


[UX - Responsiveness] Learn - text alignment not consistent

Current Behaviour

Link to website: https://play.meshery.io/
The paragraph text under "The Cloud Native Playground" is center aligned
However the text under "Sign-up to receive a user account..." is left aligned, additionally, the subheading under "Frequently Asked Questions" is also left aligned.

Screenshots

Suggested Behaviour

To maintain design consistency text should have the same format i.e either left aligned or center aligned.

Screenshots

Environment:

Host OS: Mobile responsiveness
Browser:

Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

📚 See contributing instructions.
🎨 Wireframes and designs for Layer5 site in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack.

Join the Layer5 Community by submitting your community member form.

Can I work on this issue?
@sandramsc

hi @sandramsc I would like to work on this issue , so could you please assign it to me.

Thanks @Mohith234
I have linked my PR, let me know if it needs any changes

Created a new PR to include latest changes from play/master.

Hey @sandramsc , Is this issue open I would love to work on this

Hi @sandramsc, I would like to work on this. Thank you

@ayusudi I have assigned this to you.

Hi @sandramsc , it's already done. Thank you


hello

Checklist

[ ] I'm reporting a broken site support issue
[ ] I've verified that I'm running youtube-dl version 2021.04.26
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

Last login: Fri May  7 12:01:22 on ttys000
ipad-laurence:~ renaudk$ youtube-dl --verbose https://sexu.com/20101464/
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://sexu.com/20101464/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.04.26
[debug] Python version 2.7.16 (CPython) - Darwin-18.7.0-x86_64-i386-64bit
[debug] exe versions: avconv 11.4, avprobe 11.4
[debug] Proxy map: {}
[Sexu] 20101464: Downloading webpage
ERROR: Unable to extract jwvideo; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 806, in wrapper
return func(self, *args, kwargs)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 827, in __extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 534, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/sexu.py", line 27, in _real_extract
self._search_regex(r'.setup(\s({.+?})\s);', webpage, 'jwvideo'),
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 1012, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract jwvideo; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Description

Hello
i am using this app to dwonload porn. many sites dont work because of something which i don't understand.
i encounter the problem on youtube sometimes with you video uplaods.
just so you knox.
have a nice day

and no it's not used on an ipad. but on mac so 10.14.


[CUDA] Use > 200GB memory to compile ResNet50 and BertLarge models

In benchmark_large.yml we found that IREE took lots of memory (>200GB, couldn't finish the compilations) to compile ResNet50 and BertLarge models with large batch sizes and caused OOM in build stage. Those models were able to be compiled before.
To Reproduce
Download models:
# ResNet50 batch size 2048
wget https://storage.googleapis.com/iree-model-artifacts/jax/jax_models_0.4.13_1688607404/RESNET50_FP32_JAX_3X224X224XF32_BATCH2048/stablehlo.mlirbc -O model_RESNET50_FP32_JAX_3X224X224XF32_BATCH2048.mlirbc

# BertLarge batch size 1280
wget https://storage.googleapis.com/iree-model-artifacts/jax/jax_models_0.4.13_1688607404/BERT_LARGE_FP32_JAX_384XI32_BATCH1280/stablehlo.mlirbc -O model_BERT_LARGE_JAX_384XI32_BATCH1280.mlirbc

Compile:
# ResNet50 batch size 2048
iree-compile model_RESNET50_FP32_JAX_3X224X224XF32_BATCH2048.mlirbc -o resnet50.vmfb --iree-hal-target-backends=cuda --iree-input-type=stablehlo --iree-hal-cuda-llvm-target-arch=sm_80

# BertLarge batch size 1280
iree-compile model_BERT_LARGE_JAX_384XI32_BATCH1280.mlirbc -o bert_large.vmfb --iree-hal-target-backends=cuda --iree-input-type=stablehlo --iree-hal-cuda-llvm-target-arch=sm_80

I am working my way through updating the models. ResNet50 batch 2048 passes compilation but fails at runtime with:
work/runtime/src/iree/base/allocator.c:110: RESOURCE_EXHAUSTED; system allocator failed the request;
reading file '.../module.vmfb'; loading bytecode module at '.../module.vmfb'

To reproduce:
wget https://storage.googleapis.com/iree-model-artifacts/jax/jax_models_0.4.14_1691969180/RESNET50_FP32_JAX_3X224X224XF32_BATCH2048/stablehlo.mlirbc -O model_RESNET50_FP32_JAX_3X224X224XF32_BATCH2048.mlirbc

iree-compile model_RESNET50_FP32_JAX_3X224X224XF32_BATCH2048.mlirbc -o resnet50.vmfb --iree-hal-target-backends=cuda --iree-input-type=stablehlo --iree-hal-cuda-llvm-target-arch=sm_80

iree-benchmark-module resnet50.vmfb --function=main --input=2048x3x224x224xf32=0 --device_allocator=caching --device=cuda://0 --print_statistics=true --benchmark_repetitions=10

BertLarge batch size 512 is also OOM'ing at compile time. Link to mlir:
https://storage.googleapis.com/iree-model-artifacts/jax/jax_models_0.4.14_1691969180/BERT_LARGE_FP32_JAX_384XI32_BATCH512/stablehlo.mlirbc

PyTorch BertLarge batch size 512 and above is also OOM'ing at compile time. Link to mlir:
https://storage.googleapis.com/iree-model-artifacts/pytorch/pt_models_20230813.929_1692010793/BERT_LARGE_FP32_PT_384XI32_BATCH512/linalg.mlirbc

these should be pretty straightforward to triage - do iree-compile --compile-to=executable-sources, then xargs each source with iree-compile --compile-mode=hal-executable and see which ones OOM
that something compiling 1 KB of source can OOM is ... sad x_x

It OOMs even when I run iree-compile --compile-to=executable-sources. Here's the command I used iree-compile /tmp/stablehlo.mlirbc --compile-to=executable-sources --iree-hal-target-backends=cuda --iree-input-type=stablehlo --iree-hal-cuda-llvm-target-arch=sm_80

that implies it may have nothing to do with codegen - have you tried anything but CUDA?

Ohh getting the same error on llvmcpu:
iree-compile --iree-hal-target-backends=llvm-cpu --iree-input-type=stablehlo --iree-llvmcpu-target-triple=x86_64-unknown-linux-gnu /tmp/stablehlo.mlirbc -o /tmp/module.vmfb
Killed

well, that changes things :) this likely has nothing to do with CUDA and may be something happening much earlier - possibly some constant folding? I'm guessing there's an infinite loop happening or something in some pass - a print-ir-before-all dumped to a file will let us see where it hangs (or a debugger)

Here's what's dumped when I add --print-before-all to iree-compile: https://gist.github.com/mariecwhite/a2e46e570e0568eb00bf1870d9cdb5b5

oof, that looks unrelated but something in the LLVM IR we're generating that's bad, what happens with CUDA?

CUDA shows the same error: https://gist.github.com/mariecwhite/f330f40517768fc8d662457c28359f51

@mariecwhite @benvanik Anyone actively working on this one? Flagged as P0.

This is as far as I can take it unless someone has more instructions on how to debug.

Is this still an issue? When I tried to reproduce the OOM, unfortunately, it seems that the stored models are no longer compatible with the current version of StableHLO:
iree-compile --iree-hal-target-backends=llvm-cpu --iree-input-type=stablehlo --iree-llvmcpu-target-triple=x86_64-unknown-linux-gnu stablehlo.mlirbc -o /tmp/module.vmfb
/tmp/jax_models_0.4.14_1691969180/BERT_LARGE_FP32_JAX_384XI32_BATCH512/stablehlo.mlir:413:12: error: 'stablehlo.slice' op attribute 'start_indices' failed to satisfy constraint: i64 dense array attribute
/tmp/jax_models_0.4.14_1691969180/BERT_LARGE_FP32_JAX_384XI32_BATCH512/stablehlo.mlir:413:12: note: see current operation: %410 = "stablehlo.slice"(%409) {limit_indices = dense<[1, 512, 384]> : tensor<3xi64>, start_indices = dense<0> : tensor<3xi64>, strides = dense<1> : tensor<3xi64>} : (tensor<2x512x384xf32>) -> tensor<1x512x384xf32>
/tmp/jax_models_0.4.14_1691969180/BERT_LARGE_FP32_JAX_384XI32_BATCH512/stablehlo.mlir:413:12: note: in bytecode version 6 produced by: MLIR18.0.0git

and
iree-compile --iree-hal-target-backends=llvm-cpu --iree-input-type=stablehlo --iree-llvmcpu-target-triple=x86_64-unknown-linux-gnu linalg.mlirbc -o /tmp/bertlarge.vmfb
linalg.mlirbc:0:0: error: attempting to parse a byte at the end of the bytecode
linalg.mlirbc:0:0: note: in bytecode version 6 produced by: MLIR18.0.0git

I'll regenerate the MLIR

@cc10512 do you mind trying with https://storage.googleapis.com/iree-model-artifacts/jax/jax_models_0.4.23_1705868085/BERT_LARGE_FP32_JAX_384XI32_BATCH512/stablehlo.mlirbc?


Not coming popup of account kit

I followed all steps mentioned. But popup not coming of account kit.

Check console and share error appearing there.


Fix title of User Manual page

Asciidoc uses the first line of a doc as the title, so you can't put
comments before the heading.

I had an old copy of the Manual page open and I noticed that the "User Manual" heading (and page title) had disappeared in the live version:

With this change (and how it was a few days ago):

Thanks!
bors r+

changelog fix (first contribution) fix manual page title


Concourse installation using Bosh CLI fails with error

I'm trying to install concourse lite using bosh cli on Cent OS VM by following the steps in link https://concourse.ci/concourse-lite.html
I'm getting below error during install process. I'm unable to figure out why the error is occurring and what does it mean. Please do help me out here.
bosh -e bosh-1 create-env manifests/concourse-lite.yml --state tmp/state.json
Deployment manifest: '/opt/Sumanth/ConcourseTutorials/manifests/concourse-lite.yml'
Deployment state: 'tmp/state.json'
Started validating
Downloading release 'concourse'... Skipped [Found in local cache] (00:00:00)
Validating release 'concourse'... Finished (00:00:04)
Downloading release 'garden-runc'... Skipped [Found in local cache] (00:00:00)
Validating release 'garden-runc'... Finished (00:00:01)
Downloading release 'postgres'... Skipped [Found in local cache] (00:00:00)
Validating release 'postgres'... Finished (00:00:02)
Downloading release 'bosh-virtualbox-cpi'... Skipped [Found in local cache] (00:00:00)
Validating release 'bosh-virtualbox-cpi'... Finished (00:00:03)
Validating cpi release... Finished (00:00:00)
Validating deployment manifest... Finished (00:00:00)
Downloading stemcell... Skipped [Found in local cache] (00:00:00)
Validating stemcell... Finished (00:00:04)
Finished validating (00:00:16)
Started installing CPI
Compiling package 'golang-1.8-linux/c97f9a00c26b34a3f59ca15b0f5a079d7f7e27c334cc8100248143c5dc0d4c0a'... Finished (00:00:25)
Compiling package 'golang-1.8-darwin/ee2bb46a25872469cd8fe0f4b0804bab5c39cc5512bbcc4335c8691a038d3e73'... Finished (00:00:25)
Compiling package 'virtualbox_cpi/cb3116b9b6c2111a873bb4ea14a1f3544ccdd2af'... Finished (00:00:23)
Installing packages... Finished (00:00:08)
Rendering job templates... Finished (00:00:00)
Installing job 'virtualbox_cpi'... Finished (00:00:00)
Finished installing CPI (00:01:23)
Starting registry... Finished (00:00:00)
Uploading stemcell 'bosh-vsphere-esxi-ubuntu-trusty-go_agent/3468.11'... Failed (00:02:09)
Stopping registry... Finished (00:00:00)
Cleaning up rendered CPI jobs... Finished (00:00:00)
creating stemcell (bosh-vsphere-esxi-ubuntu-trusty-go_agent 3468.11):
**CPI 'create_stemcell' method responded with error: CmdError{"type":"Bosh::Clouds::CloudError","message":"Importing stemcell from '/root/.bosh/installations/a511484e-14b6-4491-4c9a-37beea0d3422/tmp/stemcell-manager063439831/image': Retried '2' times: Retried '30' times: Starting command 'VBoxManage import /root/.bosh_virtualbox_cpi/stemcells/sc-2dde56da-373c-464d-6fd2-19946a20bf08/image.ovf': exec: "VBoxManage": executable file not found in $PATH","ok_to_retry":false}
Exit code 1**
Post unsuccessful installation, i found that the directory "/root/.bosh/installations/a511484e-14b6-4491-4c9a-37beea0d3422/tmp" is empty and so, the stemcell "/root/.bosh/installations/a511484e-14b6-4491-4c9a-37beea0d3422/tmp/stemcell-manager063439831/image" doesn't exists at all.

I'm facing this issue consistently even after deleting and creating bosh director. I'm using VMWare VSphere as cloud provider. I'm unable to install concourse using bosh because of same error again and again. Not sure how to proceed.
creating stemcell (bosh-vsphere-esxi-ubuntu-trusty-go_agent 3468.11):
CPI 'create_stemcell' method responded with error: CmdError{"type":"Bosh::Clouds::CloudError","message":"Importing stemcell from '/root/.bosh/installations/c2f8b12d-eb0d-47ca-70d5-e14574078adb/tmp/stemcell-manager418778541/image': Retried '2' times: Retried '30' times: Starting command 'VBoxManage import /root/.bosh_virtualbox_cpi/stemcells/sc-ef712e2b-5040-471b-4d59-0885427b1311/image.ovf': exec: "VBoxManage": executable file not found in $PATH","ok_to_retry":false}
Exit code 1

for the lite version, the cpi should be vboxManage, basically, you are trying to build the cluster on VBOX MANAGER. you should use vbox as cpi, here is an example https://github.com/concourse/concourse-deployment/tree/master/cluster/cloud_configs

As mentioned, it looks like your manifests/concourse-lite.yml wants to deploy to a local VirtualBox environment which you do not appear to have installed. I'd recommend taking a look at the official concourse/concourse-deployment repository for more details and the manifests they maintain.

Yes, i don't have local virtual box environment. Thank you for clarification.


Confirm test exists before running it

I think I understand the point of this change, but doesn't it cover up the real issue? In my opinion if a job doesn't exist either it should be created or the code shouldn't be trying to run it. Maybe I'm missing something from the larger picture?

Yeah you can take the view that we need to create the jobs, think the biggest issue is there are quite a few java 11 tests missing. So until those are created (or this pull request goes in) they will block 11 nightlys


How to set the output sampleRate

The SFBAudioPlayer output sampleRate is lower than the file sampleRate, how to set?

This is not an issue with SFBAudioEngine. Feel free to post general items in Discussions.


Manually call a .respond listener

I'm wondering if there's a best practice way of manually calling a .respond listener. In some instances, it would be great if I could manually call one and let params go through as default (eg, msg.match[1] for example will match nothing and fallback to default).
Normally, the action performed by the listener being called would be abstracted out but I'm just curious if anyone else has gone this way.
For example
module.exports = (robot) ->
  robot.respond /hello!/i, (msg) ->
      msg.send "Hello to you too, sir!"
      # Something here to call the below listener and have Hubot also wish the user a great day

  robot.respond /have a great day/i, (msg) ->
      msg.send "I wish upon you a fantastic day, as well!"

As soon as #803 merges, I've got a commit queued up to add robot.listenerById which will retrieve a specific listener based on its ID (a new metadata field introduced in #803). You would then be able to execute the listener directly using the private API call.
In a unit test scenario:
  describe 'listener "get-room-oncall"', ->
    it 'should match "who is oncall?"', (testDone) ->
      listener = @robot.listenerById 'get-room-oncall'

      # Stub out the real work; just testing the match
      listener.callback = sinon.stub() # private API

      testMessage = new TextMessage @user, "TestHubot: who is oncall?"

      listener.call testMessage, (result) -> # private API
        expect(result).to.be.ok
        testDone()

The relevant bit of script would be:
module.exports = (robot) ->
  robot.respond /who is oncall?/, id: 'get-room-oncall', (response) ->
    # it does stuff

i'm interested in being able to do this too, it seems kind of odd that I can't arbitrarily send a message back to hubot and chain event togethers.

@radius314 What exactly are you trying to accomplish? While I hope to enable listener retrieval soon, I envision manual invocation as an edge case (call is a private API). Most reuse of logic should be done with functions, external modules, and events.

Opened #1031 to add robot.listenerById. When that merges, I'll close this.

Hi all!  This type of functionality is really important when it comes down to re-using behind the scenes 3rd party script packs.  For example if I'm building a script pack for my specific business context it would be great if I could just execute one or more commands exposed by another library (e.g. google maps scripts, etc) explicitly by using their text patterns.
This way developers can really work on the semantic layer of thing without having to worry about internal listener IDs and other low-level stuff.  @michaelansel solution is clean but cannot work with existing libraries if no IDs have been specified for each listener.
For example if my listener hears for:
get service x location
and I'm using hubot_maps as a dependency, my service would return the location details in the controller and if I wanted to enrich the message with geo info I'd just have an extra step calling
hubot map me 'query'
passing the coordinates, get its response and return the enriched message.
Command composition is definitely a great way of leveraging re-usability.


[Task]: Fix the alignment issues in datasource form components

SubTasks

Base64 string input component has min-width and hence couldn't be aligned similarly to an input widget.
File picker widget has padding internally that makes it difficult to align.
File picker component opens a modal that has CTA to browse file and once upload is successful the modal needs to be closed. We want to remove this modal.

we think there may be some cascading issues, and these small changes could break alignment elsewhere. It could also lead to test failures, hence keeping the ballpark as M

Hii @rohan-arthur @rishabhrathod01 , I am debugging the sub tasks ,could like to work on this ticket.


F3.2.1 The service shall place the user in a first come first serve queue upon requesting a match.

Done in https://github.com/CS3219-AY2425S1/cs3219-ay2425s1-project-g50/pull/165


Node Details (Stats) page [JIRA: RIAK-1733]

Feature request: Implement a Node Details (Stats) page, linked off of the Cluster Management page or the Cluster Snapshot page.
This would display as much detailed information about a particular node as we have available inside Riak (exposed via HTTP Status api and ‘riak-admin status’).
Preferential treatment (in terms of the UI) should be given to these stats: http://docs.basho.com/riak/latest/cookbooks/Statistics-and-Monitoring/#Riak-Metrics-To-Graph

Separate by tabs or sections – FSM Times, Memory and CPU, Search stats (via riak_search_stat:get_stats()), Versions, etc
Bonus feature – display tooltip/hover type explanations for what each stat means (pulled from the docs).

Comment for Jira.


Update list_lambdas.py

Descriptions with commas where not handled correctly. Add quotes to fix this and moved column to last position.

Thanks @MarkVeldt !

No problem 😊


On win32, find executables using this method when getting Nil

Given that at the moment that which('explorer') and which('iexplore') are returning Nil. Let us try to add a fallback to use this method on win32 platforms:
HMODULE hModule = GetModuleHandleW(NULL);
WCHAR path[MAX_PATH];
GetModuleFileNameW(hModule, path, MAX_PATH);

MSDN references:

GetModuleHandleW(Kernel32.dll)

GetModuleFileNameW(Kernel32.dll)

Nearly there...
https://github.com/azawawi/perl6-file-which/blob/master/examples/02-win32-native.pl6

Fixed in https://github.com/azawawi/perl6-file-which/commit/d5cc4f64f644a4cbff497759fcacae13b5752f18


Tests/272 unicode fix

Updating PyPI tests to support python2.7.2 as per bugfix noted by @coleb in https://github.com/Binstar/binstar/pull/143
cc: @malev @srossross

@malev, can you take a quick look? test this in 2.7 & 3.4?

@malev, I think this is refactored a bit more elegantly now.


Feedback on deploy status

Sorry if there is obvious documentation that I'm missing on this, but I can't seem to get hubot to print out the message indicated in the docs, even when a deployment is successful (and I can see the successful deployment status in the github api):

I've also scanned the code and I don't see where this part is implemented. Am I missing something?

You need a heaven install or something that sends deployment status notifications to your chat server. Slack told me they'd do it a while back and never did.

@atmos ah so there is no direct hubot functionality to wait for deployment status updates, the goal is to have something else send a notification to chat?
I might try to whip up a PR to have hubot poll for updates to the deployment status, or maybe register for webhooks if GH supports deploy-related notifs.

We could probably do it w/ organization webhooks pretty easily.

I think I already have the hubot http adapter running due to slack integration. I think that might be the easiest and possibly best way to do all of this.

@atmos so basically that flow is:

hubot registers for webhooks on all deployments on a repo
hubot creates a deployment on github
something else (heaven, herokubeta service) deploys somewhere
thing from step 3 updates github deployment with the status (e.g. "success")
github sends a webhook to hubot
hubot reports "success" in chat

seems reasonable! now I just have to figure out how to get HerokuBeta to deploy to multiple apps for staging/prod..

Check out the docs, https://github.com/atmos/hubot-deploy/blob/master/docs/config-file.md

@atmos yea I saw that hubot-deploy supports multiple environments but it seems like HerokuBeta always deploys to the preconfigured heroku application name? (sorry if I'm missing something)

Huh, looks like you're right. I've been using it with heaven for multi-environment support. We should adapt that heroku beta to behave like the aws-codedeploy one. It supports arbitrary envs instead of weird environment name interpolation.

@atmos i'd be happy to make the change to github-services, but there probably isn't an easy way for me to test it, right?

Today is my last day as a GitHub employee but I use it a bunch so I'll send them a PR next week.

Hey are you still using this? I added some stuff this week that does all of this.

cool! @atmos we're not using it but i might look into switching to it again :)


dtw values comparison with tslearn

Hi! Comparing the values of DTW (with euclidean distance) from traj-dist and tslearn library, weren't the values supposed to be the same?
Thanks in advance.

I'm also getting completely different numbers. The values from tdist are about 10 times bigger than the values from tslearn.metrics.dtw!
However, using soft-dtw with gamma=0 (which is exactly dtw) from https://github.com/mblondel/soft-dtw, I'm getting the same values as in tslearn.metrics.dtw.


Remove pointless comment about prepare-yum-repositories

The script is actually copied and used only on RHEL 7.

[test]

Thanks for the PR. Actually we have Dockerfile.rhel9 files https://github.com/sclorg/s2i-base-container/blob/master/core/Dockerfile.rhel9#L31. Please remove this change as well.

Removed. Please merge it before we add RHEL 10 :smile:

[test]


Requirements Milestone 2 part a

Comment any questions about each req here that you may have asked that need an answer or questions that you asked but found the answer to.

For each req a list of questions that

That need an answer
That you have asked, and the answer you have found

A graph or table of dependencies

How will we test the requirements

Implications of the requirement for implementation

Of course this can all be read in the document provided by Oldham.

Does the command line interface need to be a standalone window that opens then launched? I can write a class for this. Or maybe @askewseth can work on that?

How do we determine line number? Do we include the beginning (header)? Do
we include blank lines?  Do we index by page number or only by raw line
number, ex) page 57 line 30 vs line 3,692
Do we need to deal with things like hyphenated words? ex) self-worth =?
self worth
I'm assuming that we need to ignore cases, but it was never explicitly
mentioned so just in case.
What makes something a common word?  Are we supposed to make a list of
common words such as articles and filter those out or are we supposed to
allow the user to define words they don't care about?
On Tue, Feb 2, 2016 at 1:42 PM, Cory Sabol<EMAIL_ADDRESS>wrote:

Does the command line interface need to be a standalone window that opens
then launched? I can write a class for this. Or maybe @askewseth
https://github.com/askewseth can work on that?
—
Reply to this email directly or view it on GitHub
https://github.com/sible777/Concordanator/issues/1#issuecomment-178750830
.

Yeah I can work on the CLI if y'all want me to.  But if I'm not mistaken the CLI is really just a wrapper for all of the other classes, just making them callable from the command line, and if that's the case then I wouldn't really be able to accomplish much on it until I had the rest of the program to call.

@askewseth Those are some really great questions! I would assume that we can simply let user search for a hyphenated word and only return that exact string. We can use regex to math a little better, but that's a bit of a hassle.
As for the cli, yeah I think that's just a wrapper. Once we have the shell up and such then you can just include the empty classes you would depend on for full functionality.
You can break it down into features and work on the ones that can stand by themselves. Like parsing the command line args into tokens and such.

Closing issue


Ci/linter improvements

Continue the work on linters initiated by @faddat: https://github.com/okp4/okp4d/pull/175 & https://github.com/okp4/okp4d/pull/174. Thank you by the way! 🙏

Enforce gofumpt code formatting by adding the linter to the Lint workflow.
Add a target to the makefile to format go source code using gofmpt
Improve documentation (a bit)

@amimart i've added a target to the makefile to format the go source files using gofmpt. It's not essential (especially if the developers wire correctly their IDE) but it completes the supported features, as a general principle.

@amimart i've added a target to the makefile to format the go source files using gofmpt. It's not essential (especially if the developers wire correctly their IDE) but it completes the supported features, as a general principle.

Nice thanks!

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add post-install messages for distributions

For instance, we could suggest to install ketal using kubectl krew install get-all (recommended by the author).

that should be definitely done, for example, vagrant also needs at least bsdtar and virtualbox for working, and plugins cannot be built locally. this could be shown in a postmsg information


AngularJs, not Antular

While indeed the component is for AngularJS, and both the description of the repo and the documentation readme clearly state it, we wouldn't like to change the repo name at this time: developers know that Angular can refer to different technologies, i.e. AngularJS or Angular 2-.... (And finally, we think that the title of the readme page should better refer the repo name itself.)


TypeError/AttributeError somehow related to enums

Description
Exception in thread Thread-8 (_worker_thread):
Traceback (most recent call last):
  File "threading.py", line 1016, in _bootstrap_inner
  File "threading.py", line 953, in run
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\scheduler.py", line 60, in _worker_thread
    self._complete_a_job(block=True)
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\scheduler.py", line 89, in _complete_a_job
    job.execute()
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\scheduler.py", line 30, in execute
    self.ret_value = self.function(*self.args, **self.kwargs)
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\client.py", line 325, in get_state
    state = State.parse(
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\data\state.py", line 351, in parse
    state.enums = {
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\data\state.py", line 351, in <dictcomp>
    state.enums = {
TypeError: unhashable type: 'list'

And a short while later:
Exception in thread Thread-6 (_worker_thread):
Traceback (most recent call last):
  File "threading.py", line 1016, in _bootstrap_inner
  File "threading.py", line 953, in run
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\scheduler.py", line 60, in _worker_thread
    self._complete_a_job(block=True)
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\scheduler.py", line 89, in _complete_a_job
    job.execute()
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\scheduler.py", line 30, in execute
    self.ret_value = self.function(*self.args, **self.kwargs)
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\api\controller.py", line 32, in _init_check
    return f(self, *args, **kwargs)
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\api\controller.py", line 703, in push_artifact
    was_set = set_artifact_func(state, artifact, set_last_change=set_last_change, **kwargs)
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\data\state.py", line 48, in dirtycheck
    r = f(self, *args, **kwargs)
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\data\state.py", line 118, in _update_last_change
    self.last_push_artifact = artifact_loc
AttributeError: 'dict' object has no attribute 'last_push_artifact'

Steps to reproduce the bug
I'm not actually sure what triggered this. 🤔 Something related to enums, one would assume.
Environment
Binary Ninja 3.5.4314-dev Personal (6506ee0e)
BinSync 3.10.14
Additional context
(I don't think this BinSync version has the fix in #298 yet?)

Shortly after this, I started also seeing:
WARNING | 2023-06-03 21:25:46,806 | binsync.api.controller | There were no states remote or local.

And it seems like syncing stopped working.

Uh oh. I now get this whenever I try to connect to the repo:
Exception in thread Thread-8 (_worker_thread):
Traceback (most recent call last):
  File "threading.py", line 1016, in _bootstrap_inner
  File "threading.py", line 953, in run
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\scheduler.py", line 60, in _worker_thread
    self._complete_a_job(block=True)
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\scheduler.py", line 89, in _complete_a_job
    job.execute()
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\scheduler.py", line 30, in execute
    self.ret_value = self.function(*self.args, **self.kwargs)
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\core\client.py", line 325, in get_state
    state = State.parse(
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\data\state.py", line 351, in parse
    state.enums = {
  File "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages\binsync\data\state.py", line 351, in <dictcomp>
    state.enums = {
TypeError: unhashable type: 'list'

I have a sneaking suspicion that what happened here is that I deleted a type used by another type and BinSync somehow got into a bad state. 🤔

@alexrp any chance you can post or direct me to your current .bsproj? I want to see what the enums.toml looks like.

@alexrp any chance this is the repo and this is the commit which triggered the bad bad?
https://github.com/alexrp/tera-eu-387486-binsync/commit/f64563b37c3802aa4f3a972b9af0a3c76aa2c1ca
Looks like somehow an Enum name became a list and not a string.

any chance this is the repo and this is the commit which triggered the bad bad?

Yep, you got it.


Assorted Modules

Migrate the following modules to Swift 3:

Common Types
Colors
Sounds
Timeout
Version
Geometry
Rx

Rx update is up here: https://github.com/IntrepidPursuits/swift-wisdom/pull/57

No warnings or test for Geometry

No warnings and passings tests for Version

No warnings or tests for Common Types

No warnings or tests for Timeout

No warnings for Colors, tests will pass when range function in String+NSRange.swift is fixed

No warnings or tests for sounds


Regular? ToC behavior of including first line only

I use metadata in the heading sometimes, which gets included into the ToC.
Presently, the only metadata being filtered is "id:: ".
But I believe that only including the first line is the best way to solve this, since it's standard behviour in most markdown editors I've used to only grab that first line when generating the ToC. For further reference, even Logseq doesn't style consecutive lines with the same font-size when using the heading syntax.
I hope it makes sense :)
Thank you for the plugin!

On second thought, the code may need to be smarter if someone adds metadata on the first line instead.
It should grab the first line that has the heading "#..." syntax, not simply the first line.
Tomorrow night I'll fix it if you think it's a reasonable change to your code.

A solution:

A setting:

Something like "hide number of items in answer"... I dunno, naming is tricky ^^

The code:

It would check the recursive call to getClozedContentHTML and if level == 0 wrap the entire partent <UL/> in a cloze deletion, while ommiting doing that for each item, of course.

I'm not a coder, and I have exams coming up so right now I can't go through the docs and see how to implement the setting thing. I did code this into a clone of your repo and installed from there, and it does what I want.
Thank you again!


Upgrade to Hypergrid 2.1.8

This branch competes with the jpmorganchase:hypergrid-2.1.6 branch (which can be deleted).

@nmichaud I'd like to go over the setPSP method with you to better understand it purpose. Can any of this be moved to the data model?


Update Reason
We'd like to update the existing BomAsSpecified to add more usability / value to the model. As for now, the model is attached as a submodel to a digital twin without any reference point to the parts that are mentioned in the BOM.
In order to change that, we would like to add the property "childCatenaXId" in order to reference to other Parts (e.g. PartAsSpecified).
By doing so, the Item Relationship Service can be integrated and use the parent-child relationship to depict a complete vehicle BOM.
MS1 Criteria

[ ] The model that should be updated exists
[ ] The referenced use case exists
[ ] The potential updates are discussed with all stakeholders
[ ] The potential update will be either

[ ] backward compatible or
[ ] a (chain of) migration strategy(-ies) from all non-deprecated previous versions to the new model will be developed

Modeling_Team


Memory Ram Issue

I wonder if everyone else has the same problem. Environments like cheetah run or walker need way more RAM than other environments like the ball in the cup. Perhaps three times more ram consumption.

I wonder if everyone else has the same problem. Environments like cheetah run or walker need way more RAM than other environments like the ball in the cup. Perhaps three times more ram consumption.

Hi!
did you solve the problem? i'm getting the same problem...


Exception Type: UnicodeDecodeError

Hello,
I had the UnicodeDecodeError exception as shown below. It occur when trying to download a video (i.e her....progressive=True).first().download('./Files'))

PS: some videos are downloaded without problem, but most videos trigger the exception above.

Hello,
I had the UnicodeDecodeError exception as shown below. It occur when trying to download a video (i.e her....progressive=True).first().download('./Files'))

PS: some videos are downloaded without problem, but most videos trigger the exception above.

Hello,
I had this problem too.for resolve:
try:
yt.download()
except UnicodeDecodeError:
filename = yt.title.encode('ascii', 'ignore').decode('ascii')
yt.download(filename=filename)

Hello,
I had the UnicodeDecodeError exception as shown below. It occur when trying to download a video (i.e her....progressive=True).first().download('./Files'))

PS: some videos are downloaded without problem, but most videos trigger the exception above.

Hello,
I had this problem too.for resolve:
try:
yt.download()
except UnicodeDecodeError:
filename = yt.title.encode('ascii', 'ignore').decode('ascii')
yt.download(filename=filename)

Thank you so much aminhyper.


[20.09] Network manager crash in i3gaps

Describe the bug
Duplicate of  #99197, but on the i3gaps fork of the i3 WM.
Any tray app ( Network Manager applet in particular) crashes after an in-place restart of i3 or e.g. after resume from suspend.
To Reproduce
Steps to reproduce the behavior:
1.
programs.nm-applet.enable = true
services.xserver.windowManager.i3.enable = true;
services.xserver.windowManager.i3.package = pkgs.i3-gaps

Log in to the session and restart i3 in place.

Expected behavior
Tray applications persist after restart.
Metadata

system: "x86_64-linux"
host os: Linux 5.4.86, NixOS, 20.09.2497.4a75ca4a4e7 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.9
channels(root): "nixos-20.09.2497.4a75ca4a4e7"
channels(lukaszm): "home-manager-20.09"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
@fmthoma
# a list of nixos modules affected by the problem
module: i3-gaps

Probably the same fix from i3 can be applied here, backport this commit to 20.09: https://github.com/NixOS/nixpkgs/commit/9190daba45c50e7c704aedcfb7438ef4938c0343#diff-7cb3a901a6ef0400193cdd9612a05b4fde580d93eeec2a1d2817b29596e7389d
The issue seems to be version 4.18.2, 4.18.3 should be fine.

Probably the same fix from i3 can be applied here, backport this commit to 20.09: https://github.com/NixOS/nixpkgs/commit/9190daba45c50e7c704aedcfb7438ef4938c0343#diff-7cb3a901a6ef0400193cdd9612a05b4fde580d93eeec2a1d2817b29596e7389d
The issue seems to be version 4.18.2, 4.18.3 should be fine.

Opened a PR: https://github.com/NixOS/nixpkgs/pull/108871

Opened a PR: https://github.com/NixOS/nixpkgs/pull/108871

Should be fixed by #108871. Please test and re-open if the issue persists. You can check status.nixos.org to see when the nixos-20.09 channel advances. You can also rebuild your system from a local nixpkgs checkout if you do not want to wait for the channel.

Should be fixed by #108871. Please test and re-open if the issue persists. You can check status.nixos.org to see when the nixos-20.09 channel advances. You can also rebuild your system from a local nixpkgs checkout if you do not want to wait for the channel.


Moving extensions directly to HttpResponseMessage class

Hello, thanks a lot for the useful library provided.
Doesn't it make sense to provide extension methods like ReadAndDeserializeFromJsonAsync() directly to HttpResponseMessage class? Usage could be simplified to smth like:
using (var response = await httpClient.SendAsync(request))
{
    Person person = await response.DeserializeAsStreamAsync<Person>();
}

That's a good idea :)  Would add them though, not replace the existing methods.  Would you be willing to provide a PR?  If not I'll just assign myself, no problem either.

Sure, will provide PR soon.

@KevinDockx, provided PR. Please, take a look. #10

Thank you - will be part of the next release :)


Fix Romanian leu symbol

According to Wikipedia please use sign: L; https://en.wikipedia.org/wiki/Romanian_leu

@bengourley Any chance you can take a look?

@krzychukula I've found confusing information, some sites say the symbol is lei, while others say it's L. The ISO 4217 standard doesn't specify it unfortunately.
Can you please look for an official source that would clearly state which symbol should be used?
I lean towards approving your change, as L seems to be more common, but additional information / opinions would be useful.

Some sources I checked:

https://currencyname.com/romania/
https://en.wikipedia.org/wiki/Romanian_leu
https://www.xe.com/currency/ron-romanian-leu/
https://www.investopedia.com/terms/forex/r/ron-romanian-new-leu.asp
https://transferwise.com/gb/currency-converter/currencies/ron-romanian-leu
https://www1.oanda.com/currency/iso-currency-codes/RON
https://eurochange.es/en/exchange-rates/romanian-leu

@krzychukula I've found confusing information, some sites say the symbol is lei, while others say it's L. The ISO 4217 standard doesn't specify it unfortunately.
Can you please look for an official source that would clearly state which symbol should be used?
I lean towards approving your change, as L seems to be more common, but additional information / opinions would be useful.

Some sources I checked:

https://currencyname.com/romania/
https://en.wikipedia.org/wiki/Romanian_leu
https://www.xe.com/currency/ron-romanian-leu/
https://www.investopedia.com/terms/forex/r/ron-romanian-new-leu.asp
https://transferwise.com/gb/currency-converter/currencies/ron-romanian-leu
https://www1.oanda.com/currency/iso-currency-codes/RON
https://eurochange.es/en/exchange-rates/romanian-leu

I’m far from the expert, but it’s a result of the feedback we got. I have no idea how context-specific it is, but for what it’s worth, we’ve set up a local override for it.
It also means that if you want to take some time to gather more feedback, then it’s entirely fair to do so :)

I’m far from the expert, but it’s a result of the feedback we got. I have no idea how context-specific it is, but for what it’s worth, we’ve set up a local override for it.
It also means that if you want to take some time to gather more feedback, then it’s entirely fair to do so :)

@krzychukula @namenyi depends on what you use case is. I can definitely say no-one practically uses L.
Before the revaluation of cutting the 0's in 2005 (see here) everyone was using ROL and lei.
After the revaluation people started using RON everywhere to make the distinction (as both old and new prices were shown to get people accustomed). Basically you have old price: 10.000 leu or 10.000 ROL / new price 1 RON.
It kind of stuck as a symbol as well. So if in Hungary you have HUF => Ft., in Poland you have PLN => zł, in Romania you basically have RON => RON. Sometimes, but rarely they still use leu.
And it is always written after the sum, separated by a space, such as 100 RON or 100 leu.
Again this is not official (I do not know of any official sources), but how people practically use it.

@krzychukula @namenyi depends on what you use case is. I can definitely say no-one practically uses L.
Before the revaluation of cutting the 0's in 2005 (see here) everyone was using ROL and lei.
After the revaluation people started using RON everywhere to make the distinction (as both old and new prices were shown to get people accustomed). Basically you have old price: 10.000 leu or 10.000 ROL / new price 1 RON.
It kind of stuck as a symbol as well. So if in Hungary you have HUF => Ft., in Poland you have PLN => zł, in Romania you basically have RON => RON. Sometimes, but rarely they still use leu.
And it is always written after the sum, separated by a space, such as 100 RON or 100 leu.
Again this is not official (I do not know of any official sources), but how people practically use it.

@ilpet thanks for the insights! Really useful.
I've just asked another friend who is from Romania, and he said he'd make it Lei, but lei and RON are also widely used and okay.
He also checked some Romanian invoices he got recently, and they wrote Lei and lei on them.

My conclusion is that we should NOT merge this PR and NOT change it to L.
We could change it either to RON or Lei, probably they would be better options, BUT imho it's not worth the breaking change.
I would only make such a change if the current version were clearly wrong, which is not the case here.
@krzychukula I'm closing this PR for now.

@ilpet thanks for the insights! Really useful.
I've just asked another friend who is from Romania, and he said he'd make it Lei, but lei and RON are also widely used and okay.
He also checked some Romanian invoices he got recently, and they wrote Lei and lei on them.

My conclusion is that we should NOT merge this PR and NOT change it to L.
We could change it either to RON or Lei, probably they would be better options, BUT imho it's not worth the breaking change.
I would only make such a change if the current version were clearly wrong, which is not the case here.
@krzychukula I'm closing this PR for now.


Typo fix in Argo Workflow warning

Closes: RHOAIENG-9505
Description
Fixes small type error of a missing space in the Argo workflow warning
How Has This Been Tested?
Tested using the Cypress file argoAlert.cy.ts
Test Impact
No new tests added
Screenshots
Before:

After:

Request review criteria:

Self checklist (all need to be checked):

[ ] The developer has manually tested the changes and verified that the changes work
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/lgtm
/approve


Add fieldalignment tool and check

Tracking issue: https://github.com/open-telemetry/opentelemetry-log-collection/issues/98

I don't have a strong opinion on this. We can either take small steps or go for ./... in this PR.
If this gets a 🟢 light then I can make the required changes proposed by fieldalignment -fix ./... and add those in this PR.

Thanks @pmalek-sumo. I'll merge this, and we can enhance from here.


AppPackageInfo add packageName property

@jeffid this has been added as of the latest release, v3.0.0:
https://pub.dev/packages/flutter_app_info/versions/3.0.0


Mouse events been delay due to NSTimer

Hi, the statement as follow make mouse events delay,and raise a bad UE.
NSTimer.scheduledTimerWithTimeInterval(2, target: self, selector: #selector(updateRateData), userInfo: nil, repeats: true)

it's in your AppDelegate.swift file, line 36.

Fixed now, thank u.


Underscores

This PR is to standardize the naming format across all entries in the ontology. It adds underscores to all node names (both leaf nodes and higher level category nodes). Examples are unchanged. Please let me know if that works for other teams.

@dianakolusheva: I am generally Ok with this change. Is this needed for Indra?

@MihaiSurdeanu I believe there's no specific requirement for this in INDRA at this point. We found that some entries have underscores while others have spaces in current version ("food_security" vs "crop season"). @bgyori and I discussed this with @BeckySharp in recent email (should be on darpa-wm mailing list) and agreed it would be good to standardize the entries.

Ok with me then!
@bnmin: does this change impact BBN in any negative way?

If an underscore is a requirement, it should (eventually) be added to the unit tests.

Sounds good to me. It should be just some minor changes on our side. @MihaiSurdeanu
Thanks! @dianakolusheva

I did check for spaces in the node or branch names and found none.  If it turns out to be a hard requirement, I can submit the code.


ui bug: datatable alignment seems off by one initially

Why are you still seeing the old data table? This is outdated.

it's a screencap from the video of the SparkR presentation a couple of weeks ago so it has the old table.
i think the bug is in the current code too though.
seem pretty minor though, does not appear to grow with the columns.

this off by one issue looks like only when a user is zoomed in, going to close as a non issue.


Failed to load UTXOs

Apparently, the check_utox method is not working properly in Spectrum, resulting in such errors:

This results in not being able to view the Transactions tab or the Addresses tab.

First thing is to get a stacktrace by replacing:
try:
...
except Exception as e:
raise SpecterError(e)
with
...
except Exception as e:
    logger.exception(e)
   raise SpecterErrot(e)

This is not a good pattern. Ideally, one should never catch Exception. Ideally, one would remove that try/except block entirely. We can in the meantime, remove these patterns entirely in page-serving controllers but not yet in API/JSON serving controllers as the error-message is not yet guaranteed to bubble up properly.

Most propably fixed with #2026


Creating your app...panic: interface conversion: interface {} is nil, not []interface {}

Describe the bug
Creating your app...panic: interface conversion: interface {} is nil, not []interface {}
nhost init --remote exit with this error while trying to init a remote project
To Reproduce
I simply run nhost init --remote
Expected behavior
App is locally initialized
Screenshots

Desktop (please complete the following information):

OS: macOs Monterey 12.3 - MacbookPro M1 2020

Additional context
Add any other context about the problem here.

Same bug as https://github.com/nhost/cli/issues/274

Should be fixed in the latest v0.9.1, please upgrade


FD2 underperforms w/ multiple kernel binaries

FD2 doesn't pack kernel binaries.
Plan is for FD2.2 to use a ring buffer, w/ a the ring buffer the binaries can be packed in DRAM and written w/ one linear write
However, w/ multiple kernel groups, we'd still pay the dram latency for each kernel group which will dominate for typical kernel sizes.
To address both now and post ring buffer, we could:

Create a packed read command which would read from multiple dram locations
Either modify the existing packed write command to handle larger amounts of data (currently limited to 1 page per write) or create a packed_write_large command for larger transfers
Today, do a packed read followed by a packed_write for all binaries.  Post ring buffer, we could pack the binaries for a kernel group in dram and then for single kernel groups do a read and linear write while multiple kernel groups would do a packed read and packed write (w/ fewer total transfers)

note that adding "force_inline" to a few prefetcher routines nets ~5% w/ 5 binaries.

Done, perf gains of >5x


change my url

https://github.com/ERLtechtvm/RobotControl.git this is my changed url  can you please check

https://github.com/ERLtechtvm/RobotControl.git this is my changed url can you please check @ArduinoBot


[1.9.4] Powered spawner ignores redstone triggers

Issue Description:
Putting a pressure plate/lever/redstone torch next to a powered spawner(didn't test with other machines) set to "Activate with signal" is ignored and machine does not turn on.
What happens:
http://imgur.com/a/C5DjV

Affected Versions (Do not use "latest"):

EnderIO: EnderIO-1.9.4-<IP_ADDRESS>_alpha
EnderCore: EnderCore-1.9.4-<IP_ADDRESS>-alpha
Minecraft: 1.9.4
Forge: forge-1.9.4-<IP_ADDRESS>9

Cause is that for some reason we need a strong redstone signal. Something wasn't ported right. Known issue, just hasn't been looked at.

will be fixed in next build


Can you add suport for lpsolve

lp_solve is a Mixed Integer Linear Programming (MILP) solver that we use extensively in our environment
thanks.
rich

We can’t reopen this issue until a PR is opened, unfortunately, consider making a pull request!


Update README docs

I reverted the unrelated changes, only kept the opts addition to drive.update method


TypeError: Cannot read property 'stats' of undefined in caniuse

I was getting this error because react-boilerplate gave me an older version of caniuse-db.
Had to yarn remove xxx on react-toolbox-themr, and css-loader, then do a yarn install.
Check you have version 1.0.3000063x or later of caniuse-db in your yarn.lock file.
If not, remove packages, or reinstall everything.
The issue is that there are some older versions of caniuse-db that technically meet the dependency needs of these projects, but are missing some attribute fields.  More info here:
https://github.com/MoOx/postcss-cssnext/pull/359

I did 'npm remove caniuse-db' then 'npm install caniuse-db'  ,
after that 'yarn run toolbox' worked


[type: refactor]refactor logging plugin code

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #3709 (49a52bc) into master (ec17f7e) will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3709      +/-   ##
============================================
+ Coverage     63.42%   63.58%   +0.16%
- Complexity     5947     5979      +32
============================================
  Files           897      897
  Lines         24681    24681
  Branches       2249     2249
============================================
+ Hits          15653    15694      +41
+ Misses         7607     7570      -37
+ Partials       1421     1417       -4

Impacted Files
Coverage Δ

...n/aliyun/sls/client/AliyunSlsLogCollectClient.java
65.55% <ø> (ø)

...sls/handler/LoggingAliYunSlsPluginDataHandler.java
81.81% <ø> (ø)

...u/plugin/logging/common/AbstractLoggingPlugin.java
0.00% <ø> (ø)

...in/logging/kafka/client/KafkaLogCollectClient.java
34.61% <ø> (ø)

...in/logging/kafka/config/KafkaLogCollectConfig.java
96.00% <ø> (ø)

...g/kafka/handler/LoggingKafkaPluginDataHandler.java
72.00% <ø> (ø)

...apache/shenyu/admin/model/vo/PermissionMenuVO.java
49.65% <0.00%> (+0.68%)
:arrow_up:

...org/apache/shenyu/admin/model/dto/ResourceDTO.java
83.49% <0.00%> (+0.97%)
:arrow_up:

...a/org/apache/shenyu/admin/model/vo/ResourceVO.java
53.84% <0.00%> (+1.09%)
:arrow_up:

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb33ffd...49a52bc. Read the comment docs.


Actionsheet overlay click event in Android ?

when user click actionsheet overlay, modal closing in android but what is this modal closing event ? i need to know if user click overlay.

upp

@bahadircivelek you can write your code inside the second parameter of ActionSheet.show()  which is the function called when you choose an option.
ActionSheet.show({
   ...
},(buttonIndex) =>{ //code here }
);

Overlay and backbutton click not trigger this callback event i crated pull request for it..

Merged the Pull request #1242 and released.


Improve body measurement field

Modify the class so that it accepts 'double' input
Add lower and upper bound for measurements
Fix inconsistent measurement prefix in UG
Correct wrong format for edit & edittask command in UG

Codecov Report

Merging #223 (3b62084) into master (b1295db) will decrease coverage by 0.21%.
The diff coverage is 34.61%.

@@             Coverage Diff              @@
##             master     #223      +/-   ##
============================================
- Coverage     58.94%   58.73%   -0.22%
- Complexity      679      681       +2
============================================
  Files           134      134
  Lines          2609     2634      +25
  Branches        300      304       +4
============================================
+ Hits           1538     1547       +9
- Misses          981      993      +12
- Partials         90       94       +4

Impacted Files
Coverage Δ

...in/java/seedu/address/logic/parser/ParserUtil.java
84.21% <0.00%> (-3.71%)
:arrow_down:

.../java/seedu/address/storage/JsonAdaptedPerson.java
97.05% <0.00%> (-2.95%)
:arrow_down:

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...n/java/seedu/address/model/person/Measurement.java
75.00% <47.36%> (-21.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1295db...3b62084. Read the comment docs.


undici fix

Description
Similar to this PR: https://github.com/webnative-examples/ditto-companion/commit/5d3d99309939af297a54886b29ee5f3130fa2a0e

Thanks! 🙏


[WIP] sbt 1.0.3

bumps dependency versions and fixes incompatablities in order to be used with SBT 1.0.3
tested locally with sbt publishLocal
TODO - update README

Hey Chris! Do you think https://github.com/localytics/sbt-dynamodb/issues/40 may be related?

This might be on the way since this is a WIP, but we'll want to be sure to update the README to indicate which version to use for sbt 0.13.X and which to use for sbt 1.0.X.


Small display bug "Plans"

Community Task Bar shows not actual percentage

@drjakob, as I said in Slack, I would appreciate feedback on ongoing features that have not been merged in the PR itself because while working on something it is not finished and there is typically lots of feedback. The issue list is nice to keep as clean as possible.
I need more information since it does show the actual percentage when I've tested it. What I have done is test on Firefox and Chrome, the two browsers we support. There is an animation that has a 1 second delay and then animates the width to the percentage of the contributors the organization has used of its business plans total allocated plans. So for this instance, when the plan is Editorial basic, it has used 60% of its allocated contributor seats. That is what the contributors' status bar show for me on Firefox and Chrome. See screenshot. Please give instructions for reproducing the bug; otherwise, it's difficult to know if it is reproducible and if so what is causing it.


Syntax for quote escaping can fail

A single backslash is interpreted by the syntax as an escape sequence when just doesn't make that distinction.

Possible solutions:

Stop calling out escape sequences entirely, since they don't actually mean anything to just
Continue to mark backslash escape sequences, but exclude quotation marks from the list of escapable characters

Ah, I hadn't noticed the difference between the two string types. As explained in the manual:

Double-quoted strings support escape sequences
Single-quoted strings do not recognize escape sequences

So '\' will always be valid, and '\'' will evaluate to "\'" but "\"" will evaluate to just a single double quote.


feat(OuterSubscriber): notifyNext passes innersubscriber when next emits

notifyNext() passes inner subscriber as same as notifyError(), notifyComplete() does, supports subscription management

closes #1250
Ran some perf against after applying changes, couldn't see noticeable differences.

before

------------------------------------------------------------------------------------------
            buffer - immediate |   33,135 (±5.19%) |   94,162 (±6.56%) |  2.84x |   184.2%
     combinelatest - immediate |   11,154 (±3.08%) |  118,908 (±3.02%) | 10.66x |   966.0%
                 combinelatest |    8,443 (±3.54%) |   81,640 (±3.08%) |  9.67x |   867.0%
          debounce - immediate |    5,874 (±8.76%) |   23,409 (±5.11%) |  3.98x |   298.5%
          mergemap - immediate |    2,450 (±2.71%) |   23,331 (±2.82%) |  9.52x |   852.4%
                      mergemap |      606 (±2.93%) |    4,912 (±3.66%) |  8.11x |   711.2%
         skipuntil - immediate |   22,688 (±2.62%) |  101,935 (±5.70%) |  4.49x |   349.3%
            switch - immediate |    2,920 (±2.64%) |   26,361 (±3.44%) |  9.03x |   802.9%
                        switch |    5,317 (±3.48%) |   25,154 (±3.42%) |  4.73x |   373.1%
         takeuntil - immediate |    3,689 (±2.56%) |  106,054 (±5.00%) |  4.48x |   347.7%
               zip - immediate |    2,554 (±3.67%) |   71,988 (±2.33%) |  5.73x |   473.4%
               zip - immediate |    5,742 (±3.35%) |   68,654 (±2.19%) | 11.96x | 1,095.6%

after
------------------------------------------------------------------------------------------
            buffer - immediate |   32,050 (±6.50%) |   97,139 (±6.60%) |  3.03x |   203.1%
     combinelatest - immediate |  11,156 (±11.48%) |  121,978 (±2.40%) | 10.93x |   993.3%
                 combinelatest |    9,201 (±2.95%) |   82,289 (±2.97%) |  8.94x |   794.3%
          debounce - immediate |    5,706 (±7.35%) |   27,265 (±3.34%) |  4.78x |   377.9%
          mergemap - immediate |    2,661 (±2.95%) |   24,345 (±3.02%) |  9.15x |   815.0%
                      mergemap |      668 (±3.00%) |    5,073 (±2.77%) |  7.60x |   659.6%
         skipuntil - immediate |   21,837 (±2.87%) |  101,634 (±6.39%) |  4.65x |   365.4%
            switch - immediate |    2,837 (±2.65%) |   27,601 (±3.18%) |  9.73x |   872.9%
                        switch |    6,096 (±2.82%) |   25,593 (±3.19%) |  4.20x |   319.8%
         takeuntil - immediate |   23,559 (±2.51%) |  105,616 (±5.15%) |  4.48x |   348.3%
               zip - immediate |   12,793 (±3.45%) |   70,808 (±2.84%) |  5.54x |   453.5%
               zip - immediate |    6,021 (±3.10%) |   68,313 (±2.38%) | 11.35x | 1,034.6%

LGTM.

Merged with 1df8928, thanks for reviewing @blesh  :)


docker-compose is using old keycloak-version

A deprecated keycloak image is used in the docker compose. For security reasons, this should be updated. See also: https://quay.io/repository/keycloak/keycloak?tag=latest&tab=tags

Can you provider a PR of course ;-)

Sorry, I'm product owner and not a developer. I'm very familiar with jira and confluence. I only use Github to report bugs or feature requests.
When I get the chance, I'll take a look at creating PR or have our developers show me how to do it.

Well it might be time topick up some skills then... in the mean time I have fixed this.


Change wic image rootfs size by ROOTFS_EXTRA variable

Purpose of pull request
For building wic image, add --size option to change rootfs size. When user sets rootfs extra space size by ROOTFS_EXTRA variable in conf/local.conf,  the --size option use user given size to create rootfs. If ROOTFS_EXTRA is not set, this mean --size 0. When 0 is passed to size option, it uses default size to enough size to install rootfs plus some space.
The ROOTFS_EXTRA variable is able to change rootfs size for qemu image so that this variable can change qemu image and wic image size.
The ROOTFS_EXTRA use Mega bytes as unit so adding 2 Giga bytes extra space  is following setting.
ROOTFS_EXTRA = "2048"

Test result
ROOTFS_EXTRA is not set
-rw-r--r-- 1 build build 912M Nov 16 00:24 tmp/deploy/images/generic-x86-64/emlinux-image-base-emlinux-bookworm-generic-x86-64.wic
-rw-r--r-- 1 build build 324M Nov 16 00:20 tmp/deploy/images/qemu-amd64/emlinux-image-base-emlinux-bookworm-qemu-amd64.ext4
-rw-r--r-- 1 build build 482M Nov 16 00:34 tmp/deploy/images/raspberrypi3bplus-64/emlinux-image-base-emlinux-bookworm-raspberrypi3bplus-64.wic
-rw-r--r-- 1 build build 484M Nov 16 01:39 emlinux-image-base-emlinux-bookworm-raspberrypi4b-64.wic

ROOTFS_EXTRA = "2048"
-rw-r--r-- 1 build build 2.7G Nov 16 00:43 tmp/deploy/images/generic-x86-64/emlinux-image-base-emlinux-bookworm-generic-x86-64.wic
-rw-r--r-- 1 build build 2.3G Nov 16 00:40 tmp/deploy/images/qemu-amd64/emlinux-image-base-emlinux-bookworm-qemu-amd64.ext4
-rw-r--r-- 1 build build 2.7G Nov 16 00:49 tmp/deploy/images/raspberrypi3bplus-64/emlinux-image-base-emlinux-bookworm-raspberrypi3bplus-64.wic
-rw-r--r-- 1 build build 2.7G Nov 16 01:31 emlinux-image-base-emlinux-bookworm-raspberrypi4b-64.wic

Thanks!


Compilation fails with ALSA disabled

Specifically, linking fails with:
[100%] Linking CXX executable polybar
CMakeFiles/polybar.dir/modules/alsa.cpp.o: In function `polybar::v3_1_0_45_gb37e4a0_git::modules::alsa_module::teardown()':
/home/jon/dev/others/polybar/src/modules/alsa.cpp:92: undefined reference to `snd_config_update_free_global'
CMakeFiles/polybar.dir/modules/alsa.cpp.o: In function `alsa_module':
/home/jon/dev/others/polybar/src/modules/alsa.cpp:50: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::mixer(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:53: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::mixer(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:56: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::mixer(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:59: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::control::control(int)'
CMakeFiles/polybar.dir/modules/alsa.cpp.o: In function `polybar::v3_1_0_45_gb37e4a0_git::modules::alsa_module::has_event()':
/home/jon/dev/others/polybar/src/modules/alsa.cpp:98: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::wait(int)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:101: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::wait(int)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:104: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::wait(int)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:107: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::control::wait(int)'
CMakeFiles/polybar.dir/modules/alsa.cpp.o: In function `polybar::v3_1_0_45_gb37e4a0_git::modules::alsa_module::update()':
/home/jon/dev/others/polybar/src/modules/alsa.cpp:120: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::process_events()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:123: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::process_events()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:126: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::process_events()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:129: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::control::process_events()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:139: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_normalized_volume()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:140: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_volume()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:141: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::is_muted()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:148: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::control::test_device_plugged()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:150: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_normalized_volume()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:151: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_volume()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:152: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::is_muted()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:160: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_normalized_volume()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:161: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_volume()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:162: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::is_muted()'
CMakeFiles/polybar.dir/modules/alsa.cpp.o: In function `polybar::v3_1_0_45_gb37e4a0_git::modules::alsa_module::input(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&)':
/home/jon/dev/others/polybar/src/modules/alsa.cpp:233: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_name[abi:cxx11]()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:235: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_name[abi:cxx11]()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:235: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_sound_card[abi:cxx11]()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:234: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::mixer(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:237: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_name[abi:cxx11]()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:239: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_name[abi:cxx11]()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:239: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_sound_card[abi:cxx11]()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:238: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::mixer(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:241: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_name[abi:cxx11]()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:243: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_name[abi:cxx11]()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:243: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_sound_card[abi:cxx11]()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:242: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::mixer(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:248: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::is_muted()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:248: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::set_mute(bool)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:252: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_normalized_volume()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:252: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::set_normalized_volume(float)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:253: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_volume()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:253: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::set_volume(float)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:257: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_normalized_volume()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:257: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::set_normalized_volume(float)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:258: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::get_volume()'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:258: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::set_volume(float)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:265: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::wait(int)'
/home/jon/dev/others/polybar/src/modules/alsa.cpp:266: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::process_events()'
CMakeFiles/polybar.dir/modules/alsa.cpp.o: In function `polybar::v3_1_0_45_gb37e4a0_git::modules::alsa_module::teardown()':
/home/jon/dev/others/polybar/src/modules/alsa.cpp:92: undefined reference to `snd_config_update_free_global'
CMakeFiles/polybar.dir/modules/alsa.cpp.o: In function `__shared_count<polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer *>':
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:588: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::~mixer()'
CMakeFiles/polybar.dir/modules/alsa.cpp.o: In function `std::_Sp_counted_ptr<polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer*, (__gnu_cxx::_Lock_policy)2>::_M_dispose()':
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:376: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::mixer::~mixer()'
CMakeFiles/polybar.dir/modules/alsa.cpp.o: In function `__shared_count<polybar::v3_1_0_45_gb37e4a0_git::alsa::control *>':
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:588: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::control::~control()'
CMakeFiles/polybar.dir/modules/alsa.cpp.o: In function `std::_Sp_counted_ptr<polybar::v3_1_0_45_gb37e4a0_git::alsa::control*, (__gnu_cxx::_Lock_policy)2>::_M_dispose()':
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:376: undefined reference to `polybar::v3_1_0_45_gb37e4a0_git::alsa::control::~control()'
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/CMakeFiles/polybar.dir/build.make:1950: bin/polybar] Error 1
make[1]: *** [CMakeFiles/Makefile2:512: bin/CMakeFiles/polybar.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
** Failed to build project

Build log:

** Fetching submodules
** Using compiler: clang++/clang
** Executing cmake command
-- The C compiler identification is Clang 5.0.1
-- The CXX compiler identification is Clang 5.0.1
-- Check for working C compiler: /usr/bin/clang
-- Check for working C compiler: /usr/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++
-- Check for working CXX compiler: /usr/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- No build type specified; using RelWithDebInfo
-- Using supported compiler Clang-5.0.1
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Checking for module 'cairo-fc'
--   Found cairo-fc, version 1.15.10
-- Checking for module 'libcurl'
--   Found libcurl, version 7.58.0
-- Found Libiw: /usr/lib/libiw.so
-- Checking for module 'libpulse'
--   Found libpulse, version 11.1
-- Checking for module 'xcb-xkb'
--   Found xcb-xkb, version 1.12
-- Checking for module 'xcb-randr'
--   Found xcb-randr, version 1.12
-- Checking for module 'xcb-randr>=1.12'
--   Found xcb-randr, version 1.12
-- Checking for module 'xcb-xrm'
--   Found xcb-xrm, version 1.2
-- Checking for module 'xcb-cursor'
--   Found xcb-cursor, version 0.1.3
--  Build:
--    Type: RelWithDebInfo
--    CC: /usr/bin/clang  -O2 -g -DNDEBUG
--    CXX: /usr/bin/clang++  -Wall -Wextra -Werror -O2 -pedantic -pedantic-errors -Wno-error=parentheses-equality -O2 -g -DNDEBUG
--    LD: /usr/bin/ld
--  Targets:
-- [X]   polybar-msg
-- [ ]   testsuite
--  Module support:
-- [ ]   alsa
-- [X]   curl
-- [ ]   i3
-- [ ]   mpd
-- [X]   network
-- [X]   pulseaudio
--  X extensions:
-- [X]   xcb-randr
-- [X]   xcb-randr (monitor support)
-- [ ]   xcb-render
-- [ ]   xcb-damage
-- [ ]   xcb-sync
-- [ ]   xcb-composite
-- [X]   xcb-xkb
-- [X]   xcb-xrm
-- [X]   xcb-cursor
-- Font not found: fixed:pixelsize=10
-- Font not found: unifont:fontformat=truetype
-- Font not found: siji:pixelsize=10
-- Checking for module 'xcb-proto'
--   Found xcb-proto, version 1.12
-- Found PythonInterp: /usr/bin/python2.7 (found suitable version "2.7.14", minimum required is "2.7")
-- XCB[XCB]: Found component XCB
-- Found XCB_XCB: /usr/lib/libxcb.so
-- XCB[ICCCM]: Found component ICCCM
-- Found XCB_ICCCM: /usr/lib/libxcb-icccm.so
-- XCB[EWMH]: Found component EWMH
-- Found XCB_EWMH: /usr/lib/libxcb-ewmh.so
-- XCB[UTIL]: Found component UTIL
-- Found XCB_UTIL: /usr/lib/libxcb-util.so
-- XCB[IMAGE]: Found component IMAGE
-- Found XCB_IMAGE: /usr/lib/libxcb-image.so
-- Found XCB: /usr/lib/libxcb.so;/usr/lib/libxcb-icccm.so;/usr/lib/libxcb-ewmh.so;/usr/lib/libxcb-util.so;/usr/lib/libxcb-image.so
-- Searching for xcbgen with python2
-- Searching for xcbgen with python2.7
-- Searching for xcbgen with python3
-- Found xcbgen in /usr/lib/python3.6/site-packages
-- XCB[RANDR]: Found component RANDR
-- Found XCB_RANDR: /usr/lib/libxcb-randr.so
-- Found XCB: /usr/lib/libxcb.so;/usr/lib/libxcb-icccm.so;/usr/lib/libxcb-ewmh.so;/usr/lib/libxcb-util.so;/usr/lib/libxcb-image.so;/usr/lib/libxcb-randr.so
-- XCB[XKB]: Found component XKB
-- Found XCB_XKB: /usr/lib/libxcb-xkb.so
-- Found XCB: /usr/lib/libxcb.so;/usr/lib/libxcb-icccm.so;/usr/lib/libxcb-ewmh.so;/usr/lib/libxcb-util.so;/usr/lib/libxcb-image.so;/usr/lib/libxcb-randr.so;/usr/lib/libxcb-xkb.so
-- xpp: including xcb proto randr.xml
-- xpp: including xcb proto xkb.xml
-- xpp: including xcb proto xproto.xml
-- Configuring done
-- Generating done
-- Build files have been written to: /home/jon/dev/others/polybar/build
** Building project
Scanning dependencies of target xpp
[  1%] Linking CXX static library libxpp.a
[  4%] Built target xpp
Scanning dependencies of target polybar-msg
[  6%] Building CXX object bin/CMakeFiles/polybar-msg.dir/ipc.cpp.o
[  7%] Building CXX object bin/CMakeFiles/polybar-msg.dir/utils/env.cpp.o
[  8%] Building CXX object bin/CMakeFiles/polybar-msg.dir/utils/file.cpp.o
[  9%] Building CXX object bin/CMakeFiles/polybar-msg.dir/utils/string.cpp.o
[ 10%] Linking CXX executable polybar-msg
[ 10%] Built target polybar-msg
Scanning dependencies of target polybar
[ 12%] Building CXX object bin/CMakeFiles/polybar.dir/adapters/net.cpp.o
[ 13%] Building CXX object bin/CMakeFiles/polybar.dir/adapters/pulseaudio.cpp.o
[ 14%] Building CXX object bin/CMakeFiles/polybar.dir/cairo/utils.cpp.o
[ 15%] Building CXX object bin/CMakeFiles/polybar.dir/components/bar.cpp.o
[ 17%] Building CXX object bin/CMakeFiles/polybar.dir/components/builder.cpp.o
[ 18%] Building CXX object bin/CMakeFiles/polybar.dir/components/command_line.cpp.o
[ 19%] Building CXX object bin/CMakeFiles/polybar.dir/components/config.cpp.o
[ 20%] Building CXX object bin/CMakeFiles/polybar.dir/components/controller.cpp.o
[ 21%] Building CXX object bin/CMakeFiles/polybar.dir/components/ipc.cpp.o
[ 23%] Building CXX object bin/CMakeFiles/polybar.dir/components/logger.cpp.o
[ 24%] Building CXX object bin/CMakeFiles/polybar.dir/components/parser.cpp.o
[ 25%] Building CXX object bin/CMakeFiles/polybar.dir/components/renderer.cpp.o
[ 26%] Building CXX object bin/CMakeFiles/polybar.dir/components/screen.cpp.o
[ 28%] Building CXX object bin/CMakeFiles/polybar.dir/components/taskqueue.cpp.o
[ 29%] Building CXX object bin/CMakeFiles/polybar.dir/drawtypes/animation.cpp.o
[ 30%] Building CXX object bin/CMakeFiles/polybar.dir/drawtypes/iconset.cpp.o
[ 31%] Building CXX object bin/CMakeFiles/polybar.dir/drawtypes/label.cpp.o
[ 32%] Building CXX object bin/CMakeFiles/polybar.dir/drawtypes/progressbar.cpp.o
[ 34%] Building CXX object bin/CMakeFiles/polybar.dir/drawtypes/ramp.cpp.o
[ 35%] Building CXX object bin/CMakeFiles/polybar.dir/events/signal_emitter.cpp.o
[ 36%] Building CXX object bin/CMakeFiles/polybar.dir/events/signal_receiver.cpp.o
[ 37%] Building CXX object bin/CMakeFiles/polybar.dir/main.cpp.o
[ 39%] Building CXX object bin/CMakeFiles/polybar.dir/modules/alsa.cpp.o
[ 40%] Building CXX object bin/CMakeFiles/polybar.dir/modules/backlight.cpp.o
[ 41%] Building CXX object bin/CMakeFiles/polybar.dir/modules/battery.cpp.o
[ 42%] Building CXX object bin/CMakeFiles/polybar.dir/modules/bspwm.cpp.o
[ 43%] Building CXX object bin/CMakeFiles/polybar.dir/modules/counter.cpp.o
[ 45%] Building CXX object bin/CMakeFiles/polybar.dir/modules/cpu.cpp.o
[ 46%] Building CXX object bin/CMakeFiles/polybar.dir/modules/date.cpp.o
[ 47%] Building CXX object bin/CMakeFiles/polybar.dir/modules/fs.cpp.o
[ 48%] Building CXX object bin/CMakeFiles/polybar.dir/modules/github.cpp.o
[ 50%] Building CXX object bin/CMakeFiles/polybar.dir/modules/ipc.cpp.o
[ 51%] Building CXX object bin/CMakeFiles/polybar.dir/modules/memory.cpp.o
[ 52%] Building CXX object bin/CMakeFiles/polybar.dir/modules/menu.cpp.o
[ 53%] Building CXX object bin/CMakeFiles/polybar.dir/modules/meta/base.cpp.o
[ 54%] Building CXX object bin/CMakeFiles/polybar.dir/modules/network.cpp.o
[ 56%] Building CXX object bin/CMakeFiles/polybar.dir/modules/pulseaudio.cpp.o
[ 57%] Building CXX object bin/CMakeFiles/polybar.dir/modules/script.cpp.o
[ 58%] Building CXX object bin/CMakeFiles/polybar.dir/modules/systray.cpp.o
[ 59%] Building CXX object bin/CMakeFiles/polybar.dir/modules/temperature.cpp.o
[ 60%] Building CXX object bin/CMakeFiles/polybar.dir/modules/text.cpp.o
[ 62%] Building CXX object bin/CMakeFiles/polybar.dir/modules/xbacklight.cpp.o
[ 63%] Building CXX object bin/CMakeFiles/polybar.dir/modules/xkeyboard.cpp.o
[ 64%] Building CXX object bin/CMakeFiles/polybar.dir/modules/xwindow.cpp.o
[ 65%] Building CXX object bin/CMakeFiles/polybar.dir/modules/xworkspaces.cpp.o
[ 67%] Building CXX object bin/CMakeFiles/polybar.dir/utils/bspwm.cpp.o
[ 68%] Building CXX object bin/CMakeFiles/polybar.dir/utils/command.cpp.o
[ 69%] Building CXX object bin/CMakeFiles/polybar.dir/utils/concurrency.cpp.o
[ 70%] Building CXX object bin/CMakeFiles/polybar.dir/utils/env.cpp.o
[ 71%] Building CXX object bin/CMakeFiles/polybar.dir/utils/factory.cpp.o
[ 73%] Building CXX object bin/CMakeFiles/polybar.dir/utils/file.cpp.o
[ 74%] Building CXX object bin/CMakeFiles/polybar.dir/utils/http.cpp.o
[ 75%] Building CXX object bin/CMakeFiles/polybar.dir/utils/inotify.cpp.o
[ 76%] Building CXX object bin/CMakeFiles/polybar.dir/utils/io.cpp.o
[ 78%] Building CXX object bin/CMakeFiles/polybar.dir/utils/process.cpp.o
[ 79%] Building CXX object bin/CMakeFiles/polybar.dir/utils/socket.cpp.o
[ 80%] Building CXX object bin/CMakeFiles/polybar.dir/utils/string.cpp.o
[ 81%] Building CXX object bin/CMakeFiles/polybar.dir/utils/throttle.cpp.o
[ 82%] Building CXX object bin/CMakeFiles/polybar.dir/x11/atoms.cpp.o
[ 84%] Building CXX object bin/CMakeFiles/polybar.dir/x11/connection.cpp.o
[ 85%] Building CXX object bin/CMakeFiles/polybar.dir/x11/cursor.cpp.o
[ 86%] Building CXX object bin/CMakeFiles/polybar.dir/x11/ewmh.cpp.o
[ 87%] Building CXX object bin/CMakeFiles/polybar.dir/x11/extensions/randr.cpp.o
[ 89%] Building CXX object bin/CMakeFiles/polybar.dir/x11/extensions/xkb.cpp.o
[ 90%] Building CXX object bin/CMakeFiles/polybar.dir/x11/icccm.cpp.o
[ 91%] Building CXX object bin/CMakeFiles/polybar.dir/x11/registry.cpp.o
[ 92%] Building CXX object bin/CMakeFiles/polybar.dir/x11/tray_client.cpp.o
[ 93%] Building CXX object bin/CMakeFiles/polybar.dir/x11/tray_manager.cpp.o
[ 95%] Building CXX object bin/CMakeFiles/polybar.dir/x11/window.cpp.o
[ 96%] Building CXX object bin/CMakeFiles/polybar.dir/x11/winspec.cpp.o
[ 97%] Building CXX object bin/CMakeFiles/polybar.dir/x11/xembed.cpp.o
[ 98%] Building CXX object bin/CMakeFiles/polybar.dir/x11/xresources.cpp.o
[100%] Linking CXX executable polybar

This was just fixed a few minutes before you posted this. Please pull the latest commit.


Autoscaling does not scale cluster to min capacity on creation

Description
When creating a cluster with autoscaling enabled, cluster is not automatically scaled to autoscaling_min_capacity value and remains stuck with directly created instances.

[✅] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: 9.0.0

Terraform version:
1.7.2

Provider version(s):
5.35.0

Reproduction Code [Required]
module "aurora" {
  source  = "terraform-aws-modules/rds-aurora/aws"
  version = "9.0.0"

  name  = "test-aurora"

  engine         = "aurora-mysql"
  engine_version = "5.7.mysql_aurora.2.11.4"
  instance_class = "db.t3.medium"

  port    = 3306
  vpc_id  = module.vpc.vpc_id
  subnets = module.vpc-subnets.subnet_ids

  master_username                     = "admin"
  manage_master_user_password         = true
  iam_database_authentication_enabled = true

  instances                = { primary = {} }
  autoscaling_enabled      = true
  autoscaling_min_capacity = 2
  autoscaling_max_capacity = 3

  allow_major_version_upgrade = true
  apply_immediately           = true
  copy_tags_to_snapshot       = true
  skip_final_snapshot         = true
}

Steps to reproduce the behavior:
terraform apply
Expected behavior
Reader nodes are scaled to the minimum capacity when cluster becomes available.
Actual behavior
Cluster will be created with only one instance. Autoscaling configuration will not add any reader nodes.
Additional context
If you set autoscaling_enabled to false and create aws_appautoscaling_target and aws_appautoscaling_policy outside the module with depends_on set to whole module reader nodes are created as expected.

We have encountered the same issue recently, and found that the auto scaling policy is created, but seems to be inactive. By modifying the autoscaling policy, simply editing and saving, the auto scaler kicks in and creates the desired minimum instances.

this appears to be related to an upstream issue https://github.com/hashicorp/terraform-provider-aws/issues/31329

Issue still persists in newer module versions


nixos/amazon-image: Enable Amazon SSM Agent by default

Description of changes
Enable the Amazon SSM Agent on our EC2 images, just like the Amazon-provided AMIs.
See: https://docs.aws.amazon.com/systems-manager/latest/userguide/ami-preinstalled-agent.html
Things done
I built an amazonImage using this branch, imported it into EC2 (aws ec2 import-snapshot then aws ec2 register-image), launched it, and tested that it started an agent. I then gave the instance an IAM role including the AmazonSSMManagedInstanceCore AWS-managed policy and tested how well it interfaced with the Systems Manager service:

It appears in Systems Manager > Fleet Manager in the AWS console.
I was also able to use Systems Manager to run an AWS-RunShellScript command document on my test instance. (Many other AWS-provided command documents will fail because they expect a more conventional filesystem layout, but that's not a problem with the agent. This also affects some Fleet Manager and inventory features.)
I was able to connect to the instance via Session Manager, though it dumped me into a /bin/sh shell. Running /usr/bin/env bash by hand gave my a normal bash shell with a PATH that matched the running NixOS system.

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[X] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Ping @arianvp , who seems to be taking point on NixOS AMI stuff these days. (If I'm wrong, I'm sorry.)