Add name field to sound devices

What this PR does / why we need it:
Adds a mandatory field name to  sound type devices. This PR complements https://github.com/kubevirt/kubevirt/pull/6650
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6828
Special notes for your reviewer:
Functional and Unit tests updated too.
Release note:

NONE

/retest

/lgtm
/approve
/hold
@xpivarc in case you want to have another look. feel free to unhold.

/lgtm /approve
/hold
@xpivarc in case you want to have another look. feel free to unhold.

Looks good to me.
/hold cancel

/retest

/retest
dial tcp <IP_ADDRESS>:443: i/o timeout

Seems like tests are slightly more flaky lately again. Will check tomorrow what's going on.


How does one delete a design from the Menu.Storage Area?

Currently you cannot. But you will be able to from the next release.

@laefsky you can find more information on this here: https://dataplatform.cloud.ibm.com/docs/content/analyze-data/ml-canvas-nnd-intro.html


Reset Azure tests.

Restored the original Azure tests under gems/pending, adding new cassettes.

@Fryguy please review.

Is this a full revert of the other commit, or a partial revert?  If it's a full revert, can you use git revert instead since it gives a standard commit message and makes tracking easier.  If it's a partial revert can you at least reference which commit and PR were reverted in the commit message?

@Fryguy It's a partial revert of:
https://github.com/ManageIQ/manageiq/pull/8564

Setting darga/yes, since the original PR has been ported to darga.


Currently available courses page should group providers by region

Context
As the list of providers and courses on Apply grows we need to make the list of available providers and courses easier to navigate. It makes sense to group the providers into regions.
Changes proposed in this pull request

[x] Group courses by provider region and change views to present an accordian per region under region headings.
[x] Feature flag
[x] New system spec
[x] Refactor to components?

Guidance to review

Does the grouping logic make sense? I've moved the sorting into the DB and but the grouping happens in Ruby code still.
I think we will run into issues with performance in the longer-term with this design (and the previous one) as more providers become available on Apply. Not sure what we can do to mitigate that without changing the design to present a subset of the results or load subsets on demand. Any thoughts on this welcome.

In mine tests I found the performance to be OK with 1000 and 5000 courses. Both page loads took about a second and it didn't degrade significantly with increased numbers of courses. So I think this is OK for now - we are probably going to have to address usability before performance.

Link to Trello card
https://trello.com/c/luWz8uHE/975-dev-currently-available-providers-page-grouped-by-region
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

In mine tests I found the performance to be OK with 1000 and 5000 courses. Both page loads took about a second and it didn't degrade significantly with increased numbers of courses. So I think this is OK for now - we are probably going to have to address usability before performance.

💯 to you for testing!


Synth ignores devel/qt5-core in FreeBSD 13.0

Synth is now ignoring devel/qt5-core following a recent change in that port. The port now tests for the existence of /etc/rc.d/os-release which does not exist in Synth's chroot. For FreeBSD versions prior to 13.0, a runtime dependency (sysutils/etc_os-release) is added. For FreeBSD 13.0, that dependency cannot be installed since it's supposed to be in base. The result is that the port is ignored by Synth.
Edit: I've opened an issue in FreeBSD's bugzilla as well.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255354

The issue as been dealt in the port by modifying its logic. However I'm leaving this issue open and let the author of Synth decide whether to include /etc/rc.d/os-release in Synth's chroot when it exists in base.

I'm going to close this without doing anything, but if this issue returns (needing support for os-release) I'm happy to revisit.


Make possible to override Html5Metadata values (Solves #60)

Solves #60

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @stonko1994. Thanks for your comments. I updated the target branch and added Changelog entry. Tell me if you have any additional comments.

Closing this to create a new one from the current version.


Can't get cookie in App loading request

I can see the cookie in App loading request, but I can't get it by calling getAll() or get(name). I only can get different cookie after I add it by calling set(name, value) in my code.

Hi @Limin-Sun
Do you have an example or a step-by-step process to replicate your issue?
Thank you

Just used some code like your example - src/client.js and src/components/App.js as our app is way much complicated and uses reduxForm:
// src/index.js
import React from 'react';
import ReactDOM from 'react-dom';
import injectTapEventPlugin from 'react-tap-event-plugin';
import { Provider } from 'react-redux';
import { compose, createStore, applyMiddleware } from 'redux';
import { persistStore, autoRehydrate } from 'redux-persist';
import thunk from 'redux-thunk';
import createLogger from 'redux-logger';
import { AppContainer } from 'react-hot-loader';
import { CookiesProvider } from 'react-cookie';
import reducers from './reducers';
import App, { middleware } from './router';
import '../styles/index.scss';
import '../styles/animation.scss';
const logger = createLogger();
injectTapEventPlugin();
const store = compose( window.devToolsExtension ? window.devToolsExtension() : f => f,
process.env.NODE_ENV === 'production'
? applyMiddleware(middleware, thunk)
: applyMiddleware(middleware, thunk, logger) , autoRehydrate()
)(createStore)(reducers);
persistStore(store);
const rootElement = document.getElementById('root');
ReactDOM.render(

,
rootElement
);
// src/container/.../index.js
import React, { Component } from 'react';
import { instanceOf } from 'prop-types';
import { withCookies, Cookies } from 'react-cookie';
import { Field, reduxForm, stopAsyncValidation, change } from 'redux-form';
class App extends Component {
static propTypes = {
cookies: instanceOf(Cookies).isRequired
};
componentWillMount() {
this.props.initializeState();
const { cookies } = this.props;

//cookies.set('MYSAPSSO2', 'myCookieValue',{ path: '/' });
//cookies.remove('MYSAPSSO2')
console.log("cookies : ", cookies.getAll() );

console.log("cookies.get('MYSAPSSO2') : ", cookies.get('MYSAPSSO2') );

}
.....
}
......
export default reduxForm({
validate,
form: FORM_NAME,
destroyOnUnmount: false
})(
connect(null, mapDispatchToProps)(withCookies(App))
);

ReactDOM.render(

,
rootElement
);

Just used some code like your example - src/client.js and
src/components/App.js as our app is way much complicated and uses reduxForm:
// src/index.js
import React from 'react';
import ReactDOM from 'react-dom';
import injectTapEventPlugin from 'react-tap-event-plugin';
import { Provider } from 'react-redux';
import { compose, createStore, applyMiddleware } from 'redux';
import { persistStore, autoRehydrate } from 'redux-persist';
import thunk from 'redux-thunk';
import createLogger from 'redux-logger';
import { AppContainer } from 'react-hot-loader';
import { CookiesProvider } from 'react-cookie';
import reducers from './reducers';
import App, { middleware } from './router';
import '../styles/index.scss';
import '../styles/animation.scss';
const logger = createLogger();
injectTapEventPlugin();
const store = compose( window.devToolsExtension ?
window.devToolsExtension() : f => f,
process.env.NODE_ENV === 'production'
? applyMiddleware(middleware, thunk)
: applyMiddleware(middleware, thunk, logger) , autoRehydrate()
)(createStore)(reducers);
persistStore(store);
const rootElement = document.getElementById('root');
ReactDOM.render(

,
rootElement
);
// src/container/.../index.js
import React, { Component } from 'react';
import { instanceOf } from 'prop-types';
import { withCookies, Cookies } from 'react-cookie';
import { Field, reduxForm, stopAsyncValidation, change } from 'redux-form';
class App extends Component {
static propTypes = {
cookies: instanceOf(Cookies).isRequired
};
componentWillMount() {
this.props.initializeState();
const { cookies } = this.props;

//cookies.set('MYSAPSSO2', 'myCookieValue',{ path: '/' });
//cookies.remove('MYSAPSSO2')
console.log("cookies : ", cookies.getAll() );

console.log("cookies.get('MYSAPSSO2') : ", cookies.get('MYSAPSSO2') );

}
.....
}
......
export default reduxForm({
validate,
form: FORM_NAME,
destroyOnUnmount: false
})(
connect(null, mapDispatchToProps)(withCookies(App))
);
Thanks
*Limin Maxim Sun *B.Sc.Eng.
E-Commerce Solutions | Digital & Development
Programmer Analyst
Phone<PHONE_NUMBER>  |  Mobile<PHONE_NUMBER>
atb.com http://www.atb.com/
[image: ATB_Logo_EmailSignature_v3.png]
On Mon, Aug 28, 2017 at 7:54 PM, Benoit Tremblay<EMAIL_ADDRESS>wrote:

Hi @Limin-Sun https://github.com/limin-sun
Do you have an example or a step-by-step process to replicate your issue?
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/reactivestack/cookies/issues/99#issuecomment-325531524,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ad9ZbJq2xERdYeLk-L_ig4Fg76pUq_5Qks5sc29LgaJpZM4PEw6N
.

If you have received this email in error, please let me know by return email so I can make sure it doesn't happen again. Because emails can contain confidential and privileged material, I'd ask for your help by deleting it and any attachments. Thanks!
We like to keep people up to date with information about new products and services at ATB or changes that could affect you. You can check out more about ATB and CASL at http://www.atb.com/important-information/privacy-security/Pages/ATB-and-CASL.aspx
If you would like to unsubscribe from our updates, please use this URL - http://www.atb.com/important-information/privacy-security/Pages/unsubscribe.aspx

Are you using this with server-rendering? If so, you need to pass the cookie header to the CookiesProvider. There is an example in the readme.

We are using more like your example code src/components/App.js and
src/client.js
*Limin Maxim Sun *B.Sc.Eng.
E-Commerce Solutions | Digital & Development
Programmer Analyst
Phone<PHONE_NUMBER>  |  Mobile<PHONE_NUMBER>
atb.com http://www.atb.com/
[image: ATB_Logo_EmailSignature_v3.png]
On Sun, Sep 3, 2017 at 12:53 PM, Benoit Tremblay<EMAIL_ADDRESS>wrote:

Are you using this with server-rendering? If so, you need to pass the
cookie header to the CookiesProvider. There is an example in the readme.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/reactivestack/cookies/issues/99#issuecomment-326823904,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ad9ZbI-LQAQpg9QrG4P6FJrX4XX2NzZEks5sevWLgaJpZM4PEw6N
.

If you have received this email in error, please let me know by return email so I can make sure it doesn't happen again. Because emails can contain confidential and privileged material, I'd ask for your help by deleting it and any attachments. Thanks!
We like to keep people up to date with information about new products and services at ATB or changes that could affect you. You can check out more about ATB and CASL at http://www.atb.com/important-information/privacy-security/Pages/ATB-and-CASL.aspx
If you would like to unsubscribe from our updates, please use this URL - http://www.atb.com/important-information/privacy-security/Pages/unsubscribe.aspx

@Limin-Sun What version of react-cookie are you using?


cmd/cgo: "function symbol table not sorted by program counter" crash when using multiple shared libraries linked with -buildmode=c-archive

What version of Go are you using (go version)?

$ go version
go version devel +04f1b65cc6 Wed Mar 13 15:11:37 2019 +0000 linux/amd64

I also tried to run this on the Go 1.12 release, and the same crash happens there.
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/u/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/u/goget:/home/u/Desktop/go"
GOPROXY=""
GORACE=""
GOROOT="/home/u/go1.13"
GOTMPDIR=""
GOTOOLDIR="/home/u/go1.13/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build238606776=/tmp/go-build -gno-record-gcc-switches"

What did you do?

For a minimal reproducible example code see: https://github.com/mewspring/go-cgo-issue
$ git clone https://github.com/mewspring/go-cgo-issue
$ cd go-cgo-issue/foo
$ make -B
$ ./foo
...
fatal error: cgo callback before cgo call

In essence, I have a minimal C program that invokes multiple shared libraries, each one written in C and linked with Go code using -buildmode=c-archive.
The program works great when invoking Go code from C this way when using one library. However, when you invoke Go functions from more than one library, the program crashes with the following error message.
u@x1 ~/D/f/foo> ./foo
function symbol table not sorted by program counter: 0xf7ef1f00 _cgo_topofstack > 0xf7dcbf20 runtime.goexit
    0xf7d80780 __x86.get_pc_thunk.ax
    0xf7d80790 __x86.get_pc_thunk.cx
..
    0xf7d8c840 runtime.evacuate_fast32
    0xf7d8cc30 runtime.mapassign_faststr
a1
       args: ./foo
b1
c1
fatal error: cgo callback before cgo call

Note: if we simply uncomment one line (https://github.com/mewspring/go-cgo-issue/blob/d03e251e54cc0a6821bee5fb15c52d69e90c08d7/c/c.c#L12), the invocation of the Go function FooBar in the c.so library, then the program works as expected.
What did you expect to see?
No crash. In particular, I expected to see the output:
a1
       args: ./foo
b1
c1
       foobar: ./foo

And a status code of 0.
What did you see instead?
The crash "fatal error: cgo callback before cgo call" crash.

Is there any further information I could provide to help investigate the cause of this issue? Also, is this a previously known issue or limitation of Cgo interaction with Go?
The scenario is as follows.
We have a C program foo and three shared libraries written in C, a.so, b.so and c.so.

The first C library (a.so) links against a go-a.a archive produced with -buildmode=c-archive. The go-a.a archive contains one exported Go function that is invoked from C.
The second C library (b.so) links against a go-b.a archive produced with -buildmode=c-archive. The go-b.a archive contains no exported Go functions.
The third C library (c.so) links against a go-c.a archive produced with -buildmode=c-archive. The go-c.a archive contains one exported Go function that is invoked from C.

Given this setup, the resulting binary foo crashes with fatal error: cgo callback before cgo call.
If we change the scenario to not invoke any Go function in go-c.a, then we can successfully run the foo program, without experiencing any crashes.
So, from what I can tell, it seems that only one shared library may have Cgo code in it (produced with -buildmode=c-archive)? It this a correct understanding of the issue and is it a known limitation?
Cheers,
Robin

A quick update. @acln0 helped me do some initial trouble shooting. We've now reproduced this issue on two machines (and on both 32-bit and 64-bit builds).

We could further conclude that the issue is with the function symbol table not sorted by program counter error (and not the cgo callback before cgo call error).
   As you've discovered.  The essential problem is that there has to be only one Go runtime, but you have multiple runtimes.  When using -buildmode=c-archive there's no way to isolate the different runtimes.  I don't see any simple way to make this work.

The essential problem is that there has to be only one Go runtime, but you have multiple runtimes. When using -buildmode=c-archive there's no way to isolate the different runtimes. I don't see any simple way to make this work.

Hi @ianlancetaylor. Thanks for the input. One question, when we generate multiple shared libraries using -buildmode=c-shared, does each one contain the Go runtime? If so, how do shared libraries created with -buildmode=c-archive differ from those produced with -buildmode=c-shared?
I would assume there are cinit functions run in c-shared that are not run in c-archive. If so, are there any theoretical restrictions that make it impossible to implement support for the same initialization in shared libraries produced with c-archived as those produced with c-shared?
If there is a design document, or specific parts of the runtime source code I could attend to to gain further insight into this, I'd be very curious to learn more.
Kindly,
Robin

The -buildmode=c-shared libraries differ in that they are built with -Bsymbolic which forces all their local references to be local.  The effect is that we have multiple Go runtimes, but they don't refer to each other so there is no confusion.
I guess you could do the same with your shared libraries, if your C code doesn't mind being linked with -Bsymbolic.
There is a design doc but I'm not sure it helps with this level of detail: https://golang.org/s/execmodes.

Thank you so much @ianlancetaylor! Your insight is invaluable.
Indeed, adding -Wl,-Bsymbolic to the build of each shared library that included Go code in c-archive form resolved the issue.
Thanks once more :)
Cheerful regards,
Robin


chore(commit message): use commitplease to validate commit messages

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Outsource commit message validation, automate installing as git commit-msg hook.
What is the current behavior? (You can also link to an open issue here)
There is a validate-commit-msg.js that can be called manually or linked as a git hook via init-repo.sh.
What is the new behavior (if this is a feature change)?
A dependency on commitplease, an external npm module, to do the commit message style checks.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Other information:
Pros of using:

No need to manually run validate-commit-msg.js or init-repo.sh
Automatically installs with npm install and runs with git commit
When the commit message is not valid, provides a specific reason why

How to try out:
git checkout commitplease
mv .git/hooks/commit-msg .git/hooks/commit-msg.old
npm install

Now try to commit some changes with valid/invalid commit messages.
How to go back:
git checkout master
mv .git/hooks/commit-msg.old .git/hooks/commit-msg

Disclaimer: I am contributing to commitplease as part of the Google Summer of Code project for students.

I am not sure we want to impose this to all contributors. We do support commitizen to help people format their messages, but failing when the are not following the conventions is a bit harsh I think.

I haven't yet looked at commitizen, but in regards to, "but failing when the are not following the conventions is a bit harsh I think.", that's a fair concern. I originally developed this module for jQuery Foundation projects, where its been in use for more than 2 years (different validation rules, otherwise same approach). As far as I know, it has been working pretty well. Since the tool provides immediate feedback, its easy to try again and fix the issue (unlike a CI feedback loop, where there's often several minutes between making a change and getting feedback).
You could give it a try. If there are issues, we can help improve the feedback. As kind of a last resort, you could set nohook: false, to prevent automatically installing the hook. Then you'd have to install the hook manually (or put that back into init-repo.sh). Would still be an improvement of the current custom script, since that same approach can be used in other repos.

Starting scope with the dollar-sign "$", as recommended by the question text, creates empty scope.
Could not find an obvious way to create lists in the commit message (i.e. insert a line break). Both Ctrl+Enter and Shift+Enter skip to the next question like Enter. Maybe there is another shorcut?

Actually I like the look of this. We can starts lines with WIP for knocking up non-normalised commits. It even handles revert commits.
Let's install it and try it for a bit. If it is not working or too annoying then we can always remove it again.
@all3fox is there a clean "uninstall" of this module?

@petebacondarwin, glad to here that! Here is a clean uninstall procedure:

remove the git hook rm .git/hooks/commit-msg
uninstall the module npm uninstall commitplease
cleanup package.json (changes visible here)

If you find any bugs/annoyances, do not hesitate to report them here or in this issue!
As a side note, here are ways to do dirty commits:

WIP, wip or Wip at the start of commit message
fixup! or squash! at the start of the message. These are part of git automatic squashing
git commit --no-verify which skips the git hook and allows to commit with any non-empty message

Is it not possible to have a postuninstall hook in the commitplease module that removes the hook?

I tried this out and it doesn't work with GUIs like SmartGit - primarily because, I believe, that the GUI doesn't know what version of node is needed and where to find that node.

@petebacondarwin about the automatic git hook uninstall:
There used to be a problem with commitplease 2.5.0 and there still is a problem with npm 3.x
We have solved the problem with commitplease 2.6.0 yesterday and now it works with npm 2.x. This PR got updated, the hook will be automatically uninstalled.
Unfortunately, the problem remains with npm 3.x. In fact, it looks like an npm problem: order of script execution and no script execution at all. So, with npm 3.x it is "better" to remove the hook manually for now.
I have also tried the postinstall hook instead of the uninstall hook, as you suggested. For me both these hooks do not get triggered with npm 3.x
I will take a look at SmartGit now.

As for SmartGit, it worked for me just fine (no extra actions, just make sure commitplease is installed):

Here's an altenative PR that adds a manual check to the Travis CI_CHECKS job: https://github.com/angular/angular.js/pull/16097
the git hook is turned off.
This will provide feedback to contributors without getting in the way of doing some dirty commits. I trust committers who push directly to the repo to use correct commit messages ;) Most changes go through PRs anyway.


don't load all local message metadata into memory during synchronize (don't merge yet!)

Issue #2061 rightly remarked that we load all local message metadata from a folder into RAM during MessagingController.synchronizeMailbox`. This is hugely wasteful, since metadata loading is not exactly lightweight (we parse mime headers in there!), and we hardly use this data in the method other than for its uid and comparing whether our date is newer than the remote.
This PR changes the logic to use Map<Uid, Date> instead of a full List<? extends Message>, loading the messages only as required for destroyMessage later on.
HOWEVER
Looking at LocalMessage.populateFromGetMessageCursor, the two dates are loaded as this.setInternalSentDate(new Date(cursor.getLong(2))); and this.setInternalDate(new Date(cursor.getLong(11)));, which looks mighty suspicious to me. These values are never null since they come from a constructor. If the row is null, cursor.getLong returns 0L, which is 1970. This screws up the logic in olderThan, which compares to the sent date if it is non-null, otherwise the internal date if it is non-null, yet neither of these can be non-null.
It also seems we put as sent date (the non-internal one!) System.currentTimeMillis as a default value, if there is no sent date, plus we also accept bogus ones like future dates?
There is really a lot here that doesn't seem right :\

You can probably get rid of the overhead of creating Date objects by simply using long for the timestamp.
And it looks like this could be further optimized by only getting a list of message UIDs to find out which messages have been deleted from the server and can be destroyed locally. And then have a second step to remove the messages that are now outside the sync window. The effective date calculation can probably even be done by a database query.

Right, that's a very small optimization by comparison though, and I didn't want to change too much around considering the unsolved problems mentioned above. What do we do about these?

I believe we have logic in place that avoids writing null values into the date columns. So the bug when loading messages shouldn't affect the sync logic. But please feel free to change the loading code to properly handle null date values.
The proper fix is to rewrite the whole sync code (and make it protocol-dependent while we're at it). But let's save that for another day.

I would have thought that the date column is supposed to be null iff there is no Date header, and was actually surprised to find it isn't. We currently use the date column for sorting so changing that isn't super simple.
So what is our actual concept for sorting messages?

I guess it makes sense to use the date column for sorting and it never being null but containing our best guess for the message date. Most of the time we don't care about the actual Date header.
We do care when displaying the full message. But then we also load the full header, so we can extract it from there.
I'm thinking: put the "effective date" into the date column, remove getSentDate() and getInternalDate() from message, add getEffectiveDate() to LocalMessage. Use the effective date for the message list, display the Date header in the message view (maybe along with the effective date when they differ).
While we're at it, we probably want to limit the effective date to the current time when fetching messages. That way messages with dates in the future don't stay at the top.

This is more or less in line with what I thought. Already halfway there :)

Isn’t sorting by “Received” the default? I hate it when new messages pop anywhere but at the top (often the case with moderated ML for instance), and I also indeed hate it when messages from the future stays at the top (less common to me though).

I think that should do it. Gonna test again tomorrow when I'm not as tired.

The internal date will be null for non-IMAP remote messages. This will lead to a crash when saving those messages in the database.
Let's fix the performance issue in this pull request and leave the date stuff for another one.

So like this? This uses the date column now, which is effectively what Message.olderThan did before


Upgrade to Laravel 7.x

Hi there,
May I ask when you're planning to upgrade to Laravel 7? I see there will be some errors because of some missing Symfony components (e.g. Symfony\Component\HttpFoundation\File\MimeType\ExtensionGuesser)

Found a quickfix for my project (fetching attachments from a mail in a mailbox)
in file src/IMAP/Attachment.php replace line 298:
return ExtensionGuesser::getInstance()->guess($this->getMimeType());
by
return MimeTypes::getDefault()->getExtensions($this->getMimeType())[0] ?? null;
with the correct uses ofcourse

Just ran into this problem too, schmeits his fix works but editing vendor files is not really a way to go on production environments.

Same issue,
Error
Class 'Symfony\Component\HttpFoundation\File\MimeType\ExtensionGuesser' not found..
Trying fixing from vendor for now, thanks @schmeits

Same issue, however since we are using laravel 7, I opted to just replace my extension code with Str::afterLast($attachment->getName(), ".")

Thanks for your suggestions. I've added a fix to support all laravel versions including 7.x.
Best regards,


Cleanup error stack

For a cleaner error stack we could use clean-stack which removes the nodejs specific parts in the stack.

We'd probably keep them but record them as in_app false.

This is a nice idea too. :-)

@LewisJEllis – I don't think we can easily use these libraries, because they wipe the value entirely. We'd like to keep the value, but mark it as being in_app=false, so that we can separate application/library frames in the Sentry UI.
So, that probably means borrowing some of these regexes + tests. The stack-utils library probably has the most readable version of these.

@benvinegar I'm inclined to just depend on stack-utils here; they export that linked nodeInternals function, and the rest of the library is small. If node updates and that pile of regex needs to change, we'll only have to worry about updating our dep instead of keeping code in sync. But, I can also see the argument for just plucking that list out and maintaining it ourselves to avoid the dependency; lmk what you think.

@MaxBittker and I investigated this and were unable to make a failing test. line.isNative() seems to already return true for node standard library modules. Added passing test case and a couple comments in #271; closing this. Reopen if we find a failing test case or example of a sentry event with node core library frames marked as being in app.

@floriangosse do you remember what nodejs frames you saw in the stack?

No sry, I don't remember.
I think I thought about it more as an enhancement for a cleaner error stack.

well, we should be displaying the stack with these frames correctly collapsed in the UI now, so please share if you find anything that looks incorrect 👍


[Feature] Add Ascend NPU accelerator support

What does this PR do?
Since npu already supports Transformer/Accelerate and Peft out of the box, this would be a good addition to run TRL out of the box on npu.
cc @younesbelkada and @lvwerra

@younesbelkada @lvwerra I tried using dpo.py to do a sanity check on ascend npu, here is the training log: https://gist.github.com/statelesshz/4437ccec89c8f0d9df11444e8ca578cd

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada Thanks for your reminder. CI is green:)


Some deprecated features in HA 2024.1

Начиная с версии HA 2024.1 в логе появились следующие предупреждения:
DEVICE_CLASS_VOLTAGE was used from yandex_smart_home, this is a deprecated constant which will be removed in HA Core 2025.1. Use SensorDeviceClass.VOLTAGE instead
ELECTRIC_CURRENT_MILLIAMPERE was used from yandex_smart_home, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfElectricCurrent.MILLIAMPERE instead
ENERGY_WATT_HOUR was used from yandex_smart_home, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfEnergy.WATT_HOUR instead
TEMP_CELSIUS was used from yandex_smart_home, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.CELSIUS instead
VOLUME_LITERS was used from yandex_smart_home, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfVolume.LITERS instead
HVAC_MODE_OFF was used from yandex_smart_home, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead

Обновите компонент до версии 0.6.8
https://github.com/dext0r/yandex_smart_home/releases/tag/v0.6.8


Can't use in UE5.2 or UE5.3

Is has a plan to update the Maya LiveLink to support unreal engine 5.2 or 5.3 ?

Maya people are so slow updating their software to the latest UE5 version, i expect it will take them months to do so, and here im talking about 5.2. for 5.3 forget about it for now, its just a preview not full release therefor they will not even think of updating Maya live link for 5.3 for now, you can always reach out to them in their website


oopsy: add support for tracking overwritten party damage CDs

Shows a ⚠ warning when a party damage cooldown (e.g., Chain Stratagem, Battle Litany, etc.) is overwritten.  Also adds some missing BLU mitigation overwrite warnings.

I sorta assumed oopsy was already doing this, but you know what they say about assumptions... 🙃

I think there were plans for it to at some point but it was super spammy in alliance raids? I can't remember exactly, it's been so long.


⚠ Bofrost.com has degraded performance

In 9c9a641, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 823 ms

Resolved: Bofrost.com performance has improved in afdb201 after 7 minutes.


Custom Viz Plugin throwing error after executing yo @superset-ui/superset

A clear and concise description of what the bug is.
Trying to create a custom Viz Plugin, followed the steps mentioned in this link.
https://superset.apache.org/docs/contributing/creating-viz-plugins/
When executing the script yo @superset-ui/superset , it throws error saying Error @superset-ui/superset.Cannot find module './utils.js'
How to reproduce the bug

npm i -g yo
cd superset-frontend/packages/generator-superset
npm i
npm link
mkdir /tmp/superset-plugin-chart-hello-world
cd /tmp/superset-plugin-chart-hello-world
yo @superset-ui/superset

Expected results
Expected a prompt to input package name and description
Actual results
macbookpro@MACBOOKs-MacBook-Pro superset-plugin-chart-hello-world % yo @superset-ui/superset
Error @superset-ui/superset

Cannot find module './utils.js'
Require stack:
- /Users/macbookpro/Documents/blinklink/superset/superset/superset-frontend/node_modules/node-fetch/node_modules/whatwg-url/lib/URL.js
- /Users/macbookpro/Documents/blinklink/superset/superset/superset-frontend/node_modules/node-fetch/node_modules/whatwg-url/lib/public-api.js
- /Users/macbookpro/Documents/blinklink/superset/superset/superset-frontend/node_modules/node-fetch/lib/index.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /Users/macbookpro/Documents/blinklink/superset/superset/superset-frontend/node_modules/github-username/index.js
- /Users/macbookpro/Documents/blinklink/superset/superset/superset-frontend/node_modules/yeoman-generator/lib/actions/user.js
- /Users/macbookpro/Documents/blinklink/superset/superset/superset-frontend/node_modules/yeoman-generator/lib/index.js
- /Users/macbookpro/Documents/blinklink/superset/superset/superset-frontend/packages/generator-superset/generators/app/index.js

Screenshots

Environment
(please complete the following information):

node.js version: v16.20.2
any feature flags active:

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

Change to<EMAIL_ADDRESS>

Closing the issue assuming the upgrade fixed the issue. Please reopen if that's not the case.


Fixes array parsing

Fix for #51

hi thanks for submitting this PR, sorry it has taken awhile to get back to you. I will be sure to review it this week.

Please take look at the second PR as well

hey. Still waiting for review. We understand that you are busy but I think this stops the progress of this repo.

LGTM but it could possibly be breaking change so we might want to record this in the README or somewhere visible.

I am not sure if this is a breaking change.


Device selection addon, support for controls, refactoring + reorganization

📦 Published PR as canary version: 0.2.9-canary.16.271.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>

:shipit:

:rocket: PR was released in v0.2.9 :rocket:


RuneLite HD

Could we please get RuneLite to support HD.
RuneHD had it and I think it would help grow the userbase of the client even more.
*Cant find a suggestion area so if someone could move this to correct area.
Thanks.

https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features


make:event and event:generate command overwrite existing event file

As title said. artisan make:event command overwrite existing file. So event:generate command also.
In event documents say "untouched" it. so it is incorrect now.
I think document is correct, the commands behaver incorrectly.

Aha. EventGeneraterCommand extends GeneratorCommand. GeneratorCommand check if a target file already exist.
While EventGeneratorCommand just extends Command. Maybe Taylor intended to extend GeneratorCommand, but seems to forget it.  :)

Oh something I missed. Once close this.

OK, now I understood whole.
Situation:

Execute 'php artisan make:event TestEvent', then this command generated 'App\Events\TestEvent' class.
Modified 'App\Events\TestEvent' class.
Execute again 'php artisan make:event TestEvent' command. So 'App\Events\TestEvent' class was overwrote by newly generated stub class.

Came from:
Illuminate\Foundation\Console\EventMakeCommand class is the generator command class. This class extends Illuminate\Console\GeneratorCommand that correctly checked class existence based on  namespace in alreadyExists method.
However EventMakeCommand overwrote alreadyExists to check without class namespace.
In result, make:event Artisan cli became destructive.
I just commented out alreadyExists method in EventMakeCommand, then it work properly.

https://github.com/laravel/framework/commit/4c331c9fd98be29c77b3397bac1abc36211d1af8
Maybe on this commit, no needed changes on EventMakeCommand.
This commit seems to try to resolve same issue, but generated now one... needed well tests...

So, what's the actual issue then?

try

Execute 'php artisan make:event TestEvent', then this command generated 'App\Events\TestEvent' class.
Modified 'App\Events\TestEvent' class.
Execute again 'php artisan make:event TestEvent' command. So 'App\Events\TestEvent' class was overwrote by newly generated stub class.

As mentioned, this command overwrite existing class file.  Other generate commands never. Only when full namespaced class name specified, file checking work correctly.
php artisan make:event TestEvent  <= this will overwrite existing app/Events/TestEvent.php file.
php artisan make:event 'App\Events\TestEvent' <= This display error message as "file existed".

I can't replicate that behaviour. Are you sure you named the file correctly? The class name MUST match the file name.

Of cause muched, whole namespace + class name is muched file structure, because the command generated.
And again, I just have installed fresh 5.1LTS, and still overwrote existing file as I mentioned.
If you read the Illuminate\Foundation\Console\EventMakeCommand, you may understand I'm right. The source code showed behaviour I reported.

Please re open. Another problem is there.
When you will make View event file when app\Events\View.php file dose not exist. You may type :
$ php artisan make:event View

This command return 'Event already exists!' everytime!! (Of course also when the file is not there)
Because 'View' is registered as facade alias on the top of name space. Other facades' name will make same situation.
Do you think this behaver is correct???


Clojure autotranslate  maps

[{:A 1, :B 2} {:A 3, :B 4} {:A 5, :B 6}]
almost auto translates correctly, - it results in a table of the right dimensions, but there are no values in the cells...
Thanks!

thank you, will get back to you about this.

As additional data point,
['(1 2) '(3 4) '(5 6)]
works as expected.

hi sorry i won't have time to look at this for a while, we are focused on the core architecture right now.

Totally appreciate that you are focused on core architecture.  This is a bit of a show stopper for me, though. I have a presentation on applying Beaker to the computational biology domain next Monday.  Everything works as expected, except for the output of maps, which is pretty fundamental to Clojure.  I can't imagine this is a particular complicated problem.  Can you maybe give me a clue as to where I should be looking?  I'll see if I can't figure it out.

As a further data point,
[{"A" 1, "B" 2} {"A" 3, "B" 4} {"A" 5, "B" 6}]
works as expected.
So I think it's probably something to do with how you interpret keywords...
"A" works, :A does not.

Finally, this appears to be a functional work-around (if entirely kludgey)
(clojure.set/rename [{:A 1, :B 2} {:A 3, :B 4} {:A 5, :B 6}] {:A "A", :B "B"})


Generate Asp.net core initial migration for exisitng DB which was used by Asp.net MVC app

I have a existing Asp.net MVC application. In-order to convert it to a Asp.net Core application, how do I generate DB migration. What I need is upgrade ASP.NET identity tables to ASP.NET Core identity.
EDIT: 2.9K PV

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db6772c4-1017-5e86-8045-8849b5dd1ad7
Version Independent ID: bcb8d6b2-f38a-ac10-d3f2-69d4223bfd72
Content: Migrate Authentication and Identity to ASP.NET Core
Content Source: aspnetcore/migration/identity.md
Service: asp.net-core
GitHub Login: @ardalis
Microsoft Alias: riande

Hi @scottaddie, My current application is having Microsoft.AspNet.Identity (Asp.net MVC). I want to use that DB with Microsoft.AspNetCore.Identity.

@sampathdr Thank you for the clarification.
@blowdart Do you have any resources for migrating Identity tables from ASP.NET 4.x to ASP.NET Core? This detail appears to be missing from our migration guide.

Nope, not a thing. @HaoK ?

@ajcvickers are there any general EF 6 -> EF Core migration docs that we can link to here?  I don't think we need anything special for the identity migration

@HaoK  Since some properties are different in Microsoft.AspNet.Identity (EF6) and Microsoft.AspNetCore.Identity (EF Core) we cannot directly apply<PHONE_NUMBER>0000_CreateIdentitySchema migration on top of current DB. So I think we may need to create a migration manually. Is there any better way to handle this?

Ping. I am also looking for guidance on how to do this. I have several ASP.NET Identity (EF6) databases that I'd like to migrate since we are moving everything to ASP.NET Core.

@jessebarocio  I was able to migrate existing DBs using the following steps.

Create a new ASP.net Core project and modify it's ModelSnapshot to match with EF6. After that, you can generate a script for the chnages of EF6 to EF Core.
Write a script to update the AspNetUsers table. In ASP.net core identity when authenticating it is used NormalizedEmail, NormalizedUserName columns. So we need to update those two columns using our existing data.

+1 for official guidance on migrating the db as well.

@sampathdr Any chance you can share the modified ModelSnapshot?

@nguyenquyhy  Yes, I can share ModelSnapshot and generated scripts with you. I will send an email to your email.

I have an existing Asp.net MVC application with EF6 and an IdentityDbContext. ( Microsoft.AspNet.Identity.EntityFramework.IdentityDbContext )
Is there any way I can use the same database from a .core project that is using EF core.
It seems like there is a lack of compatibility that will force me either remain on the full framework or convert all projects (no budget for this) that use the identity db at the same time.

@sampathdr I'm in the exact same situation. Would you be willing to share your ModelSnapshot and scripts with me as well?

+1 @sampathdr
Maybe add as a comment to this thread?

+1 @sampathdr
Can you add those scripts here as comment? Thanks

Migration.zip
These are the migration scripts I generated. Feel free to modify them accrding to your requirement.

I was able to update the schema, however I still had to migrate existing users to use the new password hasher algorithm. The easier (probably safer) option is to ask all users to reset their passwords.
If you don't want to ask users for resetting their passwords, but want to gradually update password hashes to the new algorithm as they authenticate, I posted what I did in this Stack Overflow question.

@AlissonRS Hello, Alisson!
When I've been converted one of the projects to use Identity 3 instead of 2nd version, I've done some research about passwords hashes difference and operations compatibility.
I found that implementations of UserManager methods (that are related to the passwords verification) in Identity 3 are able to determine if hashes has been generated by old Identity 2. This is done via so called format marker anaslysis-- the first byte of password's hash. And based on this verification can use either old hashing strategy or new one, no rehashing required.
The same thing is described in docs of CompatibilityMode option of hasher.
So if it's not too late and if prior to Identity 3 you've used default hashing strategy, then I'd suggest you to consider try these compatibility features instead of writing them by hand and force users to reset passwords. It worked well in project which I've converted to use new Identity.
Hope that this is helpful.

Hi @CallStackRunner
Thanks for your reply. I'm aware of this feature, in fact I tried it, but I think it only works when migrating between .Net Core projects, I tried using this with users created in MVC 5 project and it didn't work.
My guess is that this only works for users created using the Microsoft.AspNetCore.Identity package, which was not the case for my MVC 5 project.
I appreciate your reply.

@AlissonRS That's strange. "MVC5 --> Core" conversion was my case (Identity conversion is only a part of it) and users has been created using old packages of Identity.
Well, hopefully this might be helpful for anyone else who will face this task :)

@CallStackRunner I'll give another try just in case, maybe I did something wrong. I'll post the outcome here.

@CallStackRunner when I use CompatibilityMode without overriding the PasswordHasher, the login works for existing users, but the hashes are not updated to newest version.  I'd like hashes to be rehashed to latest algorithm version.

@AlissonRS I don't think that default behavior is to update hash, so it's expected that they aren't updated.
In my case I didn't tried rehashing at all, backward compatibility was enough for my requirements.
According to this article, the supposed way to do this is exactly to implement custom PasswordHasher and return PasswordVerificationResult.SuccessRehashNeeded when necessary.
So if you need to rehash passwords then you're on the right way :)

@Rick-Anderson Is there something specific you want me to address here?

@HaoK asked

@ajcvickers are there any general EF 6 -> EF Core migration docs that we can link to here? I don't think we need anything special for the identity migration

If not, I'll close this issue.

@Rick-Anderson We currently have this: https://docs.microsoft.com/en-us/ef/efcore-and-ef6/porting/index
Plus an issue to make it better: https://github.com/aspnet/EntityFramework.Docs/issues/1180
So closing here.


where is example folder?

https://github.com/AdelRedaa97/react-native-select-dropdown/tree/master/examples


devfile variables inside kubernetes component are not replaced

Devfile variables inside  kubernetes component files referenced by uri should work the same way as they do when inline is used
#devfile.yaml

commands:
  - exec:
      commandLine: npm install
      component: runtime
      group:
        isDefault: true
        kind: build
      workingDir: $PROJECT_SOURCE
    id: install
  - exec:
      commandLine: npm start
      component: runtime
      group:
        isDefault: true
        kind: run
      workingDir: $PROJECT_SOURCE
    id: run
  - id: build-image
    apply:
      component: prod-image
  - id: deployk8s
    apply:
      component: outerloop-deploy
  - id: deploy
    composite:
      commands:
        - build-image
        - deployk8s
      group:
        kind: deploy
        isDefault: true
components:
  - container:
      endpoints:
        - name: http-3000
          targetPort: 3000
      image: registry.access.redhat.com/ubi8/nodejs-14:latest
      memoryLimit: 1024Mi
      mountSources: true
    name: runtime
  - name: prod-image
    image:
      imageName: "{{CONTAINER_IMAGE}}"
      dockerfile:
        uri: ./Dockerfile
        buildContext: ${PROJECT_SOURCE}
  - name: outerloop-deploy
    kubernetes:
      uri: kubernetes/deployment.yaml

variables:
  CONTAINER_IMAGE: quay.io/tkral/test:latest
metadata:
  language: javascript
  name: nodejs-nodejs-kkty
  projectType: nodejs
schemaVersion: 2.2.0
starterProjects:
  - git:
      remotes:
        origin: https://github.com/odo-devfiles/nodejs-ex.git
    name: nodejs-starter

# kubernetes/deployment.yaml

kind: Deployment
apiVersion: apps/v1
metadata:
  name: mynode
spec:
  replicas: 1
  selector:
    matchLabels:
      app: node-app
  template:
    metadata:
      labels:
        app: node-app
    spec:
      containers:
        - name: main
          image: "{{CONTAINER_IMAGE}}"
          resources: {}

odo deploy

$ k get deployment mynode -o yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "1"
  creationTimestamp: "2021-11-23T08:58:43Z"
  generation: 1
  labels:
    app.kubernetes.io/managed-by: odo
  name: mynode
  namespace: test
  resourceVersion: "31444"
  uid: 98f8a389-0a3d-4abf-b9f1-c691ad7c4cf0
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app: node-app
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: node-app
    spec:
      containers:
      - image: '{{ CONTAINER_IMAGE }}'
        imagePullPolicy: IfNotPresent
        name: main
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 30
status:
  conditions:
  - lastTransitionTime: "2021-11-23T08:58:43Z"
    lastUpdateTime: "2021-11-23T08:58:43Z"
    message: Deployment does not have minimum availability.
    reason: MinimumReplicasUnavailable
    status: "False"
    type: Available
  - lastTransitionTime: "2021-11-23T09:08:44Z"
    lastUpdateTime: "2021-11-23T09:08:44Z"
    message: ReplicaSet "mynode-5db6864ffd" has timed out progressing.
    reason: ProgressDeadlineExceeded
    status: "False"
    type: Progressing
  observedGeneration: 1
  replicas: 1
  unavailableReplicas: 1
  updatedReplicas: 1

/kind bug
/priority high

Duplicate of #5451 (fixed by #5711).
#6041 would allow to simplify the code in odo, now that substitution is done in the Devfile library itself.
/triage duplicate
/close


T225211: Modify OresProcessor to conform to new revision/score schema

Tests are failing!

@Pchelolo is there a way we can trigger this code in dev to test it with the new schema? In mediawiki-vagrant perhaps?

No. It's downloads the schema from girhub :)

Coverage increased (+0.2%) to 88.454% when pulling 9072107eb272432612751f30bab9dcfbad2b7c7a on clarakosi:revision_score into dfe2ef771b98ec783e281027dde7d06ec1e2871a on wikimedia:master.

The tests are passing for Node 10 but failing for Node 6 because Node 6 doesn't support async/await as shown here. I guess we could drop support for Node 6 or go back and change the functions to use promises or even use Babel.

Seems good, let's see what Travis say


Add cockatrice

Add snapshot of current cockatrice master.

We have problem on branch, so Travis can't build. Have you built it locally (chroot build ofc)?

@jagajaga yes, I did:
sweater@brainstorm ~/nix
λ export NIX_PATH="nixpkgs=$NIXPKGS:$NIXPKGS"
sweater@brainstorm ~/nix
λ nix-shell $NIXPKGS --option build-use-chroot true --option use-binary-caches false --pure -p cockatrice
[nix-shell:~/nix]$ cockatrice
14933 cards in 175 sets loaded
loadCardDatabase(): Status =  0
main(): starting main program
main(): SoundEngine constructor finished
main(): MainWindow constructor finished
main(): ui.show() finished
Attempting auto-connect...
Cannot open file ':/resources/countries/uk.svg', because: Unknown error

![http://i.imgur.com/nk1CKs6.png](Everything works).
Everything works. I will change qt4; rename the derivation; then alter the history of my branch.
Hopefully, in this PR it will get reflected w/o closing it and re-opening.

Actually, if anyone cares about this package (I just made it to be able to install cockatrice from official repo tbh), a good idea would be to make three distinct (?) packages —

servatrice (that will sate cmake flags to "don't build client, build server");
cockatrice (that will build client and oracle);
cockatriceFull (ditto)

Updates?

Updates?

Updates?

Closing as it's probably not going to be pushed further. Feel free to re-open this PR or submit a new one that is rebased on master.

I know the author and I know that he will make an update someday... :crying_cat_face:

Maybe he can make a new pull-request if that happens ? I don't say that this is bad work but it might be best to keep open PR just active work to limit the number of open-ones.


Improve code-internal terminology

on #554, @aarppe posted

Primarily notes on code-internal terminology, probably best dealt separately later, plus a suggestion on how to deal with reduplication (RdplW+ and RdplS+) and initial change (IC+).
BTW, we'll have the same issue with prenouns (PN/...+), not yet in the FST, but in the CW dictionary.

Another example: EnglishKeyword has a lemma attribute, when really it can be any wordform. It even says so here:
https://github.com/UAlbertaALTLab/cree-intelligent-dictionary/blob/master/CreeDictionary/API/models.py#L355-L359

Another example: EnglishKeyword has a lemma attribute, when really it can be any wordform. It even says so here:
https://github.com/UAlbertaALTLab/cree-intelligent-dictionary/blob/master/CreeDictionary/API/models.py#L355-L359


[WIP] String datatype will be no dictionary column  by default

table creation
String datatype will be no dictionary column  by default.
Property dictionary_exclude will be deprecated

2 remove HIGH_CARDINALITY_IDENTIFY_ENABLE
3.remove columngroup testcase

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/348/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2934/

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/354/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2941/

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/355/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2942/

fixed all comments

LGTM


chore(packages): license-reporter and fixed version of express

Connects to https://github.com/bucharest-gold/entente/issues/186

Coverage remained the same at 92.308% when pulling 27c9ef34d7c21837d59a0d16f1fa1977396ebc1d on helio-frota:pr into e6ce68f4d2f442b82b94d3056616f4ad40d8026d on bucharest-gold:master.

Coverage remained the same at 92.308% when pulling 27c9ef34d7c21837d59a0d16f1fa1977396ebc1d on helio-frota:pr into e6ce68f4d2f442b82b94d3056616f4ad40d8026d on bucharest-gold:master.


Installation guide for Windows

Make a setup script at root of project for windows
Add section in the docs/docs/get-started/setting-up-la-vague.md for installation with windows

作者您好，现在windows的安装指南是否编写好了？

Hello,
No, this still needs to be done. We are looking for a contributor to help us with this :)


Add hook for autoformat of terraform code snippets embedded in the docs

There is a utility called terrafmt that can be used to check and fix the formating of Terraform snippets embedded into usage sections in README.
How could pre-commit-terraform help solve your problem?
It would be great to have native support as a pre-commit hook.

@MaxymVlasov @antonbabenko: Can I pick the terrafmt hook? I have tried it in my system. Looks like, terrafmt does not extract terraform files and does not do inline code formatting from the README.md file if, we start the Three backquotes after 4 spaces in the README.md file. It only works, if we start the Three backquotes at column 0.
Ex:

Works:

terrafmt blocks README.md

####### B1 @ #587
resource "aws_lambda_function" "pass" {
  function_name = "test-env"
  role          = ""
  runtime       = "python3.8"

  environment {
    variables = {
      AWS_DEFAULT_REGION = "us-west-2"
    }
  }
}

Does not work

terrafmt blocks README.md

The README.md in the repository has all the inline code starting at 4 spaces. For ex: Hooks usage notes and examples , apart from checkov, all other sections defines the inline code starting at 4 spaces.

Sounds like this is the problem in terrafmt because markdown format allows having an offset.


clear document needed

hi,
please create a simple document for implemented.

What?

hi dexter. i try to implement a very simple project in nuxt3 and use your repo for sitemap.
i added below lines in my nuxt.config.ts:
import dynamicRoutes from './helpers/dynamicRoutes'
...
sitemap: {
    hostname: 'https://example.com',
    path: 'sitemap.xml',
    cacheTime: 1,
    routes: dynamicRoutes,
    defaults: {
      changefreq: 'daily',
      priority: 1,
      lastmod: new Date().toISOString(),
    },
  },

create a folder "helper" and add a file "dynamicRoutes.ts" in it with below lines:
 export default async () => {
  return await $fetch('/api/sitemap_routes', {
    method: 'POST',
    headers: {
      'Content-Type': 'application/json',
    },
  })
}

finally create folder "api" and a file in it "sitemap_routes.ts" with below lines:
import { IncomingMessage, ServerResponse } from 'http'
/**
 * We are using Storyblok as our CMS,
 * in order to have all news and testimonials pages in our sitemap
 * we need to fetch some from Storyblok
 */
export default async (req: IncomingMessage, res: ServerResponse) => {
  if (req.method !== 'POST') {
    res.statusCode = 405
    res.end()
    return
  }
  const config = useRuntimeConfig()
  console.log('[vue-sitemap] generate dynamic routes')

  const fetchRoutes = async (slug) => {
    const routes = []
    const pageInfo = []
    return routes
  }

  return[]
}

but still i get [Vue Router warn]: No match found for location with path "/sitemap.xml"
what is my wrong?

@oripka  Thanks, added.


Allow undo/redo persistence between Brackets sessions - #10222 -

Topic: Issue #10222 - "Easy to hit Reload by accident, losing Undo history for files that don't have unsaved changes"
About: This patch uses localStorage to preserve the CodeMirror history between sessions, and until file is renamed or deleted within Brackets. It was created in response to @peterflynn's second part of one of his replies, as stated:

If you do reload Brackets, or quit & relaunch, etc., it would be cool if the Undo history were preserved -- or a more coarse-grained 'local history' at least. Local history is on the backlog already. I'm not aware of any editor that preserves the full Undo history (not even Sublime, which preserves unsaved changes but not Undo/Redo history), so I'm guessing we're unlikely to invest in a feature like that.

Happy to help out with this awesome tool--thanks again for it. If there are any suggestions or needed changes, please let me know, and I'll get right to them.

As a PS, if it would be preferred, I can quickly change this feature to also delete localStorage for the file being handled on each save. Doing so would ensure only each documents unsaved changes are preserved in localStorage instead. As of now, this will preserve the entire undo/redo history between saves, as already stated.

@nyteksf Awesome!

Any feedback or problems with this, please let me know. That aside, maybe this could be two prefs? Like, as in, "persist undo/redo history for files not yet saved", and another, "persist undo/redo history between sessions"? I only ask as I can imagine people wanting either option at different times.

@nethip, whoops! I missed your comment until now somehow. Thank you, by the way! That aside, I'll get right on adapting this PR to persist all unsaved changes instead.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_e2244bd8-81fe-46ed-b194-2a2f1496bef4/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_e2244bd8-81fe-46ed-b194-2a2f1496bef4.git

Docs Build status updates of commit 2bae334:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Failed to create new Angular 6 project - macOS (High Sierra)

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Area
- [x] devkit
- [x] schematics

Versions
node : v8.11.3
npm : 6.1.0
Angular CLI : 6.0.8
OS : macOS (High Sierra)
Repro steps
ng new testappp
The log given by the failure
$ ng new testappp
CREATE testappp/README.md (1025 bytes)
CREATE testappp/angular.json (3566 bytes)
CREATE testappp/package.json (1312 bytes)
CREATE testappp/tsconfig.json (384 bytes)
CREATE testappp/tslint.json (2805 bytes)
CREATE testappp/.editorconfig (245 bytes)
CREATE testappp/.gitignore (503 bytes)
CREATE testappp/src/environments/environment.prod.ts (51 bytes)
CREATE testappp/src/environments/environment.ts (631 bytes)
CREATE testappp/src/favicon.ico (5430 bytes)
CREATE testappp/src/index.html (295 bytes)
CREATE testappp/src/main.ts (370 bytes)
CREATE testappp/src/polyfills.ts (3194 bytes)
CREATE testappp/src/test.ts (642 bytes)
CREATE testappp/src/assets/.gitkeep (0 bytes)
CREATE testappp/src/styles.css (80 bytes)
CREATE testappp/src/browserslist (375 bytes)
CREATE testappp/src/karma.conf.js (964 bytes)
CREATE testappp/src/tsconfig.app.json (194 bytes)
CREATE testappp/src/tsconfig.spec.json (282 bytes)
CREATE testappp/src/tslint.json (314 bytes)
CREATE testappp/src/app/app.module.ts (314 bytes)
CREATE testappp/src/app/app.component.css (0 bytes)
CREATE testappp/src/app/app.component.html (1141 bytes)
CREATE testappp/src/app/app.component.spec.ts (991 bytes)
CREATE testappp/src/app/app.component.ts (207 bytes)
CREATE testappp/e2e/protractor.conf.js (752 bytes)
CREATE testappp/e2e/src/app.e2e-spec.ts (304 bytes)
CREATE testappp/e2e/src/app.po.ts (208 bytes)
CREATE testappp/e2e/tsconfig.e2e.json (213 bytes)
npm WARN deprecated<EMAIL_ADDRESS>1.2.0 should have been a major version bump
npm ERR! Unexpected end of JSON input while parsing near '...mpiler-cli","version"'
npm ERR!      /Users/dream/.npm/_logs/2018-06-23T19_05_28_356Z-debug.log
Package install failed, see above.
Desired functionality
Failed to create a new angular 6 project.
Mention any other details that might be useful

Were you connected to the internet while creating the new app?

Were you connected to the internet while creating the new app?

Yes, I was connected to internet while creating the new app.
Before app creation, I have successfully installed the cli (npm install -g @angular/cli).

what if you don't use yarn?

installed Node.js v10.5.0 and npm v6.1.0 (https://nodejs.org/en/)
npm install -g @angular/cli
sudo npm install -g yarn
ng new testappp (It still failed like before but i open the directory and installed the packages through yarn as bellow commands)
cd testappp
yarn install
ng serve --open

It worked.
@elonaire : Thanks for suggesting yarn.

a similar looking error happened on my machine, which I have opened as another issue. it seems like the culprit may have to do with deprecated istanbul? that's where mine fails too

Duplicate of #11498

yarn is not a requirement. NPM 6.x is not yet stable and there were a few regressions in NPM itself. Nothing we can do, unfortunately. Try reverting to NPM 5 or use the latest NPM 6 (but there might be other issues).


Difference between quality and density?

Is an image's quality not comprised of its pixel density and resolution?
What's the actual utility of the quality option?

Is an image's quality not comprised of its pixel density and resolution?
What's the actual utility of the quality option?

Quality is inversely related to compression afaik. From https://en.wikipedia.org/wiki/JPEG:

The degree of compression can be adjusted, allowing a selectable tradeoff between storage size and image quality.

Also see https://github.com/ImageMagick/ImageMagick/blob/a7e810e41cfc29c9c8e6eabb43ea0c52e26d0664/coders/png.c#L10699-L10736 for some notes on png compression.


Fix appending body of an existing draft release

Don't just return the release without doing anything else, this
prevented "append_body" from having any effect when updating an existing
draft release.
The real change here is continuing executing the release function even if an existing draft release is found, the rest is just due to changing existingRelease to be a Release object (which seems more logical anyhow).

Sorry, I somehow hadn't noticed an already existing #245 doing the same thing.


chore: refactored docker images replication module

Issue #, if available:
Description of changes:

fixed the deletion workflow and provided an input to remove the hardcoded idf as project name
refactored the shell script to check the repo first, check the image if exists and push images only if needed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: fbc0c42245c76658aae1beb71fc033903408560c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: a2cc0fc77d05de2f13213c73fce9159f20432ea5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: 403c037f028b8130c848ab52a3da288e9e0475a4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Looks good, are we now defferring to CONTIRBUTING, LICENSE etc at the root of repo?
And looks like there's some static checks to fix

Fixed the static checks. Also, from my knowledge, we always the license, contributing.md at the root of the repo. right? I've checked the IDF modules and thats what i observed. Do you have any suggestion?


Crash on Android 4.1.2 and 4.4

Hello,
I have a this probleme only when I am testing my app on android 4.1.2
It works fine on Lolipop and above.
I saw the same issue mentioned by @abbasalim but I don't really understand what he did to fix it.
solved by replace  extends Application   with extends MultiDexApplication
Originally posted by @abbasalim in https://github.com/Ereza/CustomActivityOnCrash/issues/70#issuecomment-590052105

Tested also on android 4.4, but this time I get a different error
java.lang.RuntimeException: Unable to get provider cat.ereza.customactivityoncrash.provider.CaocInitProvider: java.lang.ClassNotFoundException: Didn't find class "cat.ereza.customactivityoncrash.provider.CaocInitProvider" on path: DexPathList[[zip file "/data/app/dz.app.myapps-2.apk"],nativeLibraryDirectories=[/data/app-lib/dz.app.myapp-2, /vendor/lib, /system/lib]]


Writability checks

health_check is super-awesome, but (as far as I could tell) it does not check that databases (postgres and redis, in my case) are writable, which is generally important.  I used custom tests for this, but it seems logical to add checks for writability to health_check, either as part of the normal database and redis checks, or as additional checks that can be run.
(If it does actually test this already, then it would be helpful to make that explicit in the README.)

I don't check that the databases are writeable as opposed to contactable because I haven't seen or heard that failure happening in practise. All the ones I have seen are caught by the connection and version read check.  Have you ever seen it happen in practise?
If you are happy to share the custom test, I would be happy to add to the wiki for others to benefit from.
Otherwise if you can point to some failure scenarios that result in the database being readable but not writeable I will consider adding it to health_check.

I have closed this because I had not heard back to the request for further info, and I have never experienced this failure scenario myself.


Missing nest-asyncio requirement

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
missing: https://github.com/jupyter/notebook/blob/aee45355b568650cf650f4e2d3d551570655f844/setup.py#L125, and so allows nest-asyncio<1.5 to be installed
Installed packages
notebook==6.4.12
nest-asyncio<1.5

Environment info
any

Note this dependencies was introduced in 6.4.10: https://github.com/jupyter/notebook/commit/751c7eb0cc7d252e5ee3a378056c6eee107445a1

I wonder why pip check failed here. Maybe something else is installing that in the environment.


[BUG] interruption with scroll timeline

Describe the bug
Using ScrollTimeline for animations within the sheet got broken between 1.2.6 and 1.2.7. The animated elements seem to think that the scrollable element is at the end of the scroll area when the sheet is initialized. I was using 1.2.6 and recently upgraded to 1.2.8 and saw this problem, then downgraded to 1.2.7 and still saw the problem. In my example I'm using the scroll timeline to indicate the "active" tab as the user swipes left/right. However the sheet is initialized with the tab on the right i.e. end of the scroll area with the active color instead of the one on the left.
To Reproduce
I created a sample reproduction of my cordova app, you can view the code here and test it in this build
Expected behavior
The "comment" tab should be highlighted with the black background and white text when the sheet is opened.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: Tecno Android phone and Samsung Galaxy Ultra Note 20
OS: Android 8.1 - Android 12
Browser Chrome Webview
Version 97

Additional context
Add any other context about the problem here.

Hello @CodeWithOz
Thank you for issue. I reviewed your code and here some conclusions:
When you initialize ScrollTimeline with new ScrollTimeline(...), your DOM isn't visible on viewport and active tab is not correctly calculated. You must initialize ScrollTimeline composed and ready DOM.
Simple solution is to present pane first, and using async/await function to be sure that pane presented. And after this ScrollTimeline can be initialized without issues.
function initPane(...) {
  requestAnimationFrame(async() => { // Here async
    ...
    if (shouldPresent) {
      await myPane.present({ animate: true }); // Here you await for presentation
    }

    // And after presentation you could initialize ScrollTimeline and other ScrollTimeline works
   const scrollSnapContainer = document.querySelector(`.content`);
   const sectionScrollTimeline = new ScrollTimeline({
     scrollSource: scrollSnapContainer,
     orientation: 'inline',
     fill: 'both',
   });
   ...
  });
}

@roman-rr thanks for that, it worked. :+1: :tada:


fix(plugin-space): Set an index when a Space or SpaceObject is created

This PR aims to resolve issues observed when DnD rearrange fails due to indexes not being set.
This applies only to new objects, however, and does not solve for existing objects which are missing indexes, the solution for which remains an outstanding question.

🤖 Generated by Copilot at e44fafe
Summary
🚀🗂🎨

Improved space plugin UI with index-based sorting and ordering. Used external libraries to handle index logic and object updates. Modified SpacePlugin.tsx and added dependencies.

To sort and order spaces and objects
The space plugin some new code injects
It uses indices
And echo-schema
To generate and subscribe to the effects

Walkthrough

Import and use getIndexBelow function to generate next index for space or object (link, link, link)
Import and use EchoObject, subscribe, and TypedObject types to handle echo objects in spaces (link, link)
Import and use getAppStateIndex function to get index of space from app state (link, link)
Add and use hasIndex, echoObjectCompare, getNextSpaceIndex, and getNextSpaceObjectIndex functions to sort and index spaces and objects (link, link, link)

Merged on accident, reverting.


2nd Level Contact tracing : Yellow warning code -  Zweite Grades Kontaktnachverfolgung :Gelbe Code

Feature description
Contacts of the users who receive a red warning code should be directly informed with a yellow warning code straightaway instead of waiting for the test results of red code users.
Problem and motivation
On an average it takes 6 days of infection to show symptoms, and a few additional days to wait for the symptoms to develop, book the test, get tested and get the report. So on average 10 days from the start of infection till a confirmed positive report.
RKI assumes the generation time of 4 days, that is average time between start of infection till the transmission of the disease to other people. This means that on 10th day of infection of Patient zero, direct contact might be on his 6th day of infection and the he has already infected some of his contacts in last 2 days(day 4th and 5th)
The real advantage of informing the potentially infected people is when they are informed before their infectious phase. Let's say in the first 2-3 days of their infection.
If the 2nd level contact person is informed with a different warning code (Let's say yellow) on the same day when the direct contact received a red code warning, it will be his/her 2nd day of infection and maybe just before the start of his infectious phase.
Erklärung auf Deutsch
Explanation in English for a similar indian App : Aarogya Setu
Explanation in English on Twitter thread reader app .
Is this something you're interested in working on
I can't  directly work on the SW code but I can help if more clarifications are needed on the functionality

Closely related to #24

I agree that the time to information ( let's call it TTI)need converge to zero. I suggest to make this a goal of the App. Along with your suggest, I want to suggest to have a report of yellow , when someone gets PCR tested or has a positive rapid test, since this gap also adds two to three days.

I agree that the time to information ( let's call it TTI)need converge to zero. I suggest to make this a goal of the App. Along with your suggest, I want to suggest to have a report of yellow , when someone gets PCR tested or has a positive rapid test, since this gap also adds two to three days.

@DanAmt
Notifying positive rapid tests is already announced as a new feature of the CWA for second half of april.
Notifying contacts before receiving a test result is not a good idea. In this case you may warn and scare people even if a test result is later negative. Additionally this won't help because delays may occur also before having the PCR test, e.g. not getting an appointment for a test in time or not having a test on first symptoms, etc.
I highly recomment to implement the feature of notifying only on a positive test (PCR or rapid test): the primariy contact with a red notification and all contacts on >= second level with a yellow/orange notification.
(see #24 and #403 where the feature is discussed in more details)

Hello @Vineet-Bhola ,
Thank you for your contribution. The request you make is very similar to the topics discussed in https://github.com/corona-warn-app/cwa-wishlist/issues/24 . I suggest you follow the discussion there and mirror your comment to the thread as some of the points you raised have already been mentioned there.
I will close your issue as a duplicate of https://github.com/corona-warn-app/cwa-wishlist/issues/24 in order to keep the discussion in one central place.
Regards,
CH

Corona-Warn-App Open Source Team


minor english changes

Pull Request Test Coverage Report for Build 533

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.63%

Totals

Change from base Build 531:
0.0%

Covered Lines:
2032

Relevant Lines:
2373

💛  - Coveralls


PictureRecorder Image Rendering Does Not Render on Chrome when Web App is Built and Deployed on Raspberry Pi aarch64

Steps to Reproduce
Build and run below main.dart code on Raspberry Pi 4 (Issue only occurs when app is built and run on Raspberry Pi - prob any aarch64 would suffice to reproduce?).

On Raspberry Pi 4 build app using:

flutter channel stable
flutter upgrade
flutter config --enable-web
flutter build web --web-renderer canvaskit --release

Serve up build/web on a web server (e.g. a simple arm64v8 python http server).
Visit 'http://{server-ip}:{server-port}/' on a Firefox web browser and you should see a composite render of two images from Tile_set.png and a green circle.
Visit 'http://{server-ip}:{server-port}/' on a Chrome web browser and you will only see a green circle. Tile_set.png images are not rendered.

Expected results:
Visit 'http://{server-ip}:{server-port}/' on any web browser and you should see a composite render of two images from Tile_set.png and a green circle.
Actual results:
When you visit 'http://{server-ip}:{server-port}/' on a Firefox web browser you see a composite render of the two images from Tile_set.png and a green circle as expected.
When you visit 'http://{server-ip}:{server-port}/' on a Chrome web browser you only see a green circle.
Notes:
In my setup the built webapp is actually run in a k8s pod in a k8s cluster running on the Raspberry Pi(s) using Docker image: arm64v8/python:3.8.5-alpine.
If the app is run on my dev desktop (x86_64 architecture) then the images composite renders as expected in the same two Firefox and Chrome web browsers so I believe the issue is specific to when the .js is built by Flutter on aarch64 maybe?
main.dart:
import 'dart:async';
import 'dart:typed_data';
import 'dart:ui' as ui;
import 'package:flutter/material.dart';
import 'package:url_strategy/url_strategy.dart';
import 'package:http/http.dart' as http;

void main() async {
  await runZonedGuarded(() async {
    WidgetsFlutterBinding.ensureInitialized();
    setPathUrlStrategy();
    runApp(const MainApp());
  }, (Object error, StackTrace stack) {
    print('error:$error stack:$stack');
  });
}

class MainApp extends StatelessWidget {
  const MainApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      color: Color(0xFF000000), home: TestWidget(),
    );
  }
}

class TestWidget extends StatefulWidget {
  const TestWidget({super.key});

  @override
  State<TestWidget> createState() => _TestWidgetState();
}

class _TestWidgetState extends State<TestWidget> {
  ui.Image? _image;

  @override
  void initState() {
    super.initState();
    _getImage();
  }

  @override
  Widget build(BuildContext context) {
    return _image != null
        ? CustomPaint(
      painter: TestPainter(_image!), size: const Size(60.0,60.0),
      child: SizedBox(//color: Colors.white,
          width: _image!.width.toDouble(),
          height: _image!.height.toDouble()),
    )
        : Container(width: 50, height: 50, color: Colors.red);
  }

  _getImage() async {

    http.Response response = await http.get(
      Uri.parse('https://upload.wikimedia.org/wikipedia/commons/7/77/Tile_set.png'),
    );
    Uint8List bytes = response.bodyBytes;
    ui.Image image = await decodeImageFromList(bytes);

    ui.PictureRecorder recorder = ui.PictureRecorder();
    Canvas canvas = Canvas(recorder);
    final Paint spritePaint = Paint()..color = Colors.green;

    var src0 = const Rect.fromLTWH(0, 16, 16, 16);
    var dst0 = const Rect.fromLTWH(0, 0, 16, 16);
    var src1 = const Rect.fromLTWH(0, 32, 16, 16);
    var dst1 = const Rect.fromLTWH(0, 16, 16, 16);
    canvas.drawImageRect(image, src0, dst0, spritePaint);
    canvas.drawImageRect(image, src1, dst1, spritePaint);
    ui.Picture picture = recorder.endRecording();
    _image = await picture.toImage(32, 32);

    print('_getImage() _image:$_image');
    setState(() {});
  }
}

class TestPainter extends CustomPainter {
  final ui.Image image;

  TestPainter(this.image);

  @override
  void paint(Canvas canvas, Size size) {
    final Paint spritePaint = Paint()..color = Colors.green;
    canvas.drawImage(image, Offset.zero, spritePaint);
    canvas.drawCircle(const Offset(30, 30), 10, spritePaint);
  }

  @override
  bool shouldRepaint(CustomPainter oldDelegate) {
    return true;
  }
}

# flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.3.8, on Ubuntu 20.04.5 LTS 5.4.0-1073-raspi, locale C.UTF-8)
[✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Linux toolchain - develop for Linux desktop
[!] Flutter IDE Support (No supported IDEs installed)
[✓] Connected device (1 available)
[✓] HTTP Host Availability

Firefox Render:
Chrome Render:

I think the issue I am seeing is similar to #103803?
I have now done a build and deploy on the Raspberry Pi device using flutter master (Channel master, 3.6.0-1.0.pre.37, on Ubuntu 20.04.5 LTS 5.4.0-1073-raspi, locale C.UTF-8) based on comments there and can confirm that with Flutter 3.6.x version the PictureRecorder Image renders as expected in both Firefox and Chrome.
So will carry on doing builds on the Raspberry Pis with channel master until the fix becomes available in stable.

@ponderMuse Thanks for verifying and confirming that it works on latest master. Based on above comment and per triage policy, I am going ahead and closing this as fixed. You may keep an eye on stable release notes to check if it contains the fix.


 Well, at least we removed 40 lines.
The reason we need kwargs there is that otherwise you can't upgrade the workers independently of the server.
Would be good to factor out a proper API at some point. But I don't think RemoteSchedulerResponder was the right approach.

Coverage decreased (-0.09%) to 76.33% when pulling 347306a98cbccc54b078e8acea7eba07c675664e on erikbern/rpc-cleanup into b44ffafdee77186f7aa870205fbb6a245e87ecfb on master.

Coverage increased (+0.21%) to 76.64% when pulling 347306a98cbccc54b078e8acea7eba07c675664e on erikbern/rpc-cleanup into b44ffafdee77186f7aa870205fbb6a245e87ecfb on master.

Coverage increased (+0.07%) to 76.64% when pulling ace47a3bf1a70104db8336dac57a4250d3bfaf4d on erikbern/rpc-cleanup into ff87a03096373081dec91cd99506666e6e966f34 on master.

LGTM


core.remote_sudo prompts for a password when run

Even when a password is provided as a parameter, the core.remote_sudo action hangs after prompting the user for a password. The expected behavior would be the action being executed without prompting the user for a password.

I've reproduced this locally, and working to resolve it.

From my digging into the code it would appear the handling of sudo isn't very robust.
Stated in more detail we execute the command prepending sudo -E -- bash -c to it (https://github.com/StackStorm/st2/blob/master/st2common/st2common/models/system/paramiko_command_action.py#L46) but don't have any mechanism to catch if a password prompt is initiated. It would appear we assume the sudoer will have unprompted access to run commands.
The trail I followed is listed below:
Runner gets command to run
Command object created
Begin command execution
Generate command
Execute parallel ssh method with command
Send _run_command method and options to _execute_in_pool
Spawn instance of execute_method
Execute command
I haven't found any logic to determine if password prompt is given for sudo, and if it is to put in the password. Perhaps this is by design and the st2 user is expected to provide a system user with no-password access to sudo.

@bigmstone @cbrenton correct, per documentation (and installation script) user needs to set up paswordless sudo for stanley user.
As far as "robustness" goes, I agree - we should make the code more robust and user-friendly. Previously, with the fabric runner we caught "sudo requires password" scenario and throw a more user-friendly exception which said Paswordless sudo needs to be set up for that user.
Right now I don't know exactly what happens, but I would imagine action times out while waiting on prompt...

Having said that, we could perhaps introduce support for sudo with password by adding a new "sudo_password" or similar parameter and updating the local and remote runner (or at least the remote one).
Docs for default installation would still require paswordless setup for user stanley though.

I can't easily conceive of a way to gracefully catch this that doesn't run the risk of blindly typing the user's password into the shell.

@cbrenton I've captured this as a feature request now. Will put it on the docket to add mechanism to handle both prompted and unprompted sudo.

Here is an example of how fabric handles sudo password (it also supports interactive mode and prompt which we don't need to support) - https://github.com/fabric/fabric/blob/master/fabric/io.py#L170
So yeah, not totally straight forward to implement in our remote runner... So something we probably don't have time to do right now, but user contributions are of course welcome :)


Create new entry creates same item multiple times.

Hi there,
I tried to allow users to add new entries via create_field='nachname'.
However, each new entry ends up as many times in the database, as there are chars in the string.
i.e. if I enter "Maxmueller" in the field and click on "create "Maxmueller"", I end up with 10x a "Maxmueller" object in the database. Else the thing is just working fine. Any ideas?
url(r'^person-autocomplete/$', PersonAutocomplete.as_view(create_field='nachname'), name='person-autocomplete'),
Thanks!

Hi !
I couldn't reproduce your issue. I tried creating a new choice in the test project but then i only see it once
Could you perhaps fork this repo and add an app that allows to reproduce this in the test_project ?
Thanks !

@teconomix , any luck figuring this out? The same thing is happening to me, but it's always 4 (regardless of how long the create string is)

I'm having the same problem - I'm getting four duplicates the same as @rdolen. I'm running 3.2.1

Unless someone makes it to reproduce the issue in the test project, all we can do is wait until someone proposes a patch.

I'm having the same issue, though I'm consistently getting 2 duplicates

Please people, try to provide some useful information.

Alright, so I think I solved this in my case - silly mistake for me. I am using DAL on two dynamic formsets in the page and had included the JS files for both of the formsets. Once I removed the includes for the second formset everything worked well.
Anyway, as best I can tell this was the cause of the additional object creation.
Don't want to add to the thread without more info, but figured this might provide a clue for someone else stumbling across this message.

The problem is that include more that one time the file "select2.js" and by each time that the file is included the event "select2:selecting" is binded, this ocurs for example if you have 2 or more times the {{ form.media }} instruction...

Thanks for the heads up, what happens if you merge your media objects from your different form objects in your view before rendering ?

First of all thank you @Wealthymaury.
In my case, i was using crispy forms and i also had {{ form.media }} on the page i removed the variable {{ form.media }} it worked good so @Wealthymaury  is right. This occurs if you have multiple select2.js in your page.

Hi, does anyone here know hot to, while allowing creation of new items, hide the "Create ..." option in certain cases e.h. if an object with the exact same name already exists (which is what I'm trying to do).


Recently pushed commit is not reflected in the latest automated build

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
dptgqyo1az3e7
Region
ap-southeast-1
Amplify Console feature
Not applicable
Describe the bug
I made some visible changes to our project and pushed it into our bitbucket repo's main branch.
The AWS Amplify Console triggers a new build but the cloned repo is not the latest one.
Expected behavior
The latest pushed commit should be reflected in the latest build.
Reproduction steps

git add .
git commit -m "commit message"
git push

Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - npm ci
    build:
      commands:
        - npm run build:$AWS_BRANCH
  artifacts:
    baseDirectory: out
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*
  customHeaders:
     - pattern: '**/*.json'
       headers:
        - key: 'Cache-Control'
          value: 'public,max-age=31536000,immutable'
     - pattern: '**/*.js'
       headers:
        - key: 'Cache-Control'
          value: 'public,max-age=31536000,immutable'
     - pattern: '**/*.css'
       headers:
        - key: 'Cache-Control'
          value: 'public,max-age=31536000,immutable'
     - pattern: '**/*.gif'
       headers:
        - key: 'Cache-Control'
          value: 'public,max-age=31536000,immutable'
     - pattern: '**/*.ico'
       headers:
        - key: 'Cache-Control'
          value: 'public,max-age=31536000,immutable'
     - pattern: '**/*.jpg'
       headers:
        - key: 'Cache-Control'
          value: 'public,max-age=31536000,immutable'
     - pattern: '**/*.png'
       headers:
        - key: 'Cache-Control'
          value: 'public,max-age=31536000,immutable'
     - pattern: '**/*.svg'
       headers:
        - key: 'Cache-Control'
          value: 'public,max-age=31536000,immutable'
     - pattern: '**/*.mp4'
       headers:
        - key: 'Cache-Control'
          value: 'public,max-age=31536000,immutable'
     - pattern: '**/*.webm'
       headers:
        - key: 'Cache-Control'
          value: 'public,max-age=31536000,immutable'
     - pattern: '**/*'
       headers:
        - key: 'Strict-Transport-Security'
          value: 'max-age=31536000; includeSubDomains'
        - key: 'X-Frame-Options'
          value: 'SAMEORIGIN'
        - key: 'X-XSS-Protection'
          value: '1; mode=block'
        - key: 'X-Content-Type-Options'
          value: 'nosniff'

Additional information
Connecting a new branch that came from the main branch build is also outdated.
I suspect that the automated build keeps cloning a specific commit from the past.

This issue might be the cause of the applied fix for issue #1825 #1824.
We're using Next.js SSG.

@jericopulvera sorry you are facing this issue. It looks like you ran a build during a period where we had an issue with SSG detection. I have manually reset your status to SSG, so your issue should be resolved. Please feel free to re-open if you continue to face this issue.

@jericopulvera sorry you are facing this issue. It looks like you ran a build during a period where we had an issue with SSG detection. I have manually reset your status to SSG, so your issue should be resolved. Please feel free to re-open if you continue to face this issue.

Latest build still does not reflect the latest commit.

I created a new hidden page and I see that it is generated on the build phase but it's still not appearing in the connected domain.
Could this be a caching issue on your side?

@Athena96 I cannot re-open the issue.

@Athena96 I am experienceing the same issue, and was previously experiencing the issues cited in #1824. I was able to yesterday, but the latest commit was not reflected, and upon pushing a new commit today, the build failed at :
2021-05-18T15:58:13.052Z [INFO]: Export successful. Files written to /codebuild/output/src253453846/src/tuned-next/out 2021-05-18T15:58:13.058Z [INFO]: Done in 94.97s. 2021-05-18T15:58:13.062Z [INFO]: Starting SSR Build... 2021-05-18T16:01:04.085Z [INFO]: Error Terminating logging...

@ssousa33 can you share your appId, thanks

@Athena96 I was able to create a new amplify app with Next.js - SSR detected as the framework and I got no issues so far. The old app has Web as the detected framework.
I'm currently using the old app to redirect my main domain to the www subdomain in the new app.
I hope that the issue with the old app "dptgqyo1az3e7" gets fixed.
Hope this info helps you.

@ssousa33 can you share your appId, thanks

@Athena96 - app id is d1monpkxtxrpp5

@Athena96 - I'm having the same error for two Amplify apps (staging and production). One has the framework as blank while the other has SSR. They should both be SSG.

I'm also experiencing the same build issue with no error
appid: dvz5hlwhv3cxu
region: ap-southeast-2
2021-05-21T07:27:37.529Z [INFO]: Starting SSR Build...
2021-05-21T07:29:25.492Z [INFO]: Error

@leighkendell I'm seeing this build error
ModuleNotFoundError: Module not found: Error: Can't resolve 'mongodb' in '/codebuild/output/src069219851/src/livestock-pricing-fe/node_modules/typeorm/platform'

@leighkendell I'm seeing this build error
ModuleNotFoundError: Module not found: Error: Can't resolve 'mongodb' in '/codebuild/output/src069219851/src/livestock-pricing-fe/node_modules/typeorm/platform'

Weird... That looks to be a peer dependency as I am not using typeorm  or mongodb explicitly. I don't have this issue building in other environments like bitbucket pipelines and vercel. Is it possible to have these errors actually exposed to the amplify console? Otherwise I'll be troubleshooting this blind 😬

@Athena96 I was able to create a new amplify app with Next.js - SSR detected as the framework and I got no issues so far. The old app has Web as the detected framework.
I'm currently using the old app to redirect my main domain to the www subdomain in the new app.
I hope that the issue with the old app "dptgqyo1az3e7" gets fixed.
Hope this info helps you.

@Athena96
We ran into this issue again in the new amplify app (d15izgm8c268bd) instance we've created.
I can see in the amplify build log that the new page is generated but it's not reflected on the site.
The old app (dptgqyo1az3e7) also still has this issue.

This might be related to #604

closing this issue, feel free to re-open if you continue to face it. thanks!

I'm running into the same issue. My app id is d2ohstmzpe02tu


Send correct NuGet status codes

fixes #20644

https://docs.gitea.io/en-us/packages/generic/
Maybe for generics too?


Use Keda v2.10.0

Description
Changes proposed in this pull request:

upgrade keda version
rename keda-operator to keda-manager (since keda has renamed its workloads )
...

Related issue(s)
#130

/test all


proxy: rip out io_uring code

with the event handler rewrite the IO thread scales much better (up to 8-12 worker threads), leaving the io_uring code in the dust.
realistically io_uring won't be able to beat the event code if you're using kernels older than 6.2, which is brand new. Instead of carrying all this code around and having people randomly try it to get more performance, I want to rip it out of the way and add it back in later when it makes sense.
I am using mcshredder as a platform to learn and keep up to date with io_uring, and will port over its usage pattern when it's time.

Yes I've left a few support bits in, which is fine since I do intend on adding it back later.  Hopefully by the time it gets added back I can use a single alarm timespec and event callback structure, so I don't have to ifdef half the damn codebase.