Update README.md

Summary of the Pull Request
References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
PR Checklist

[ ] Closes #xxx
[ ] Tests added/passed
[ ] Documentation updated

If checked, please file a pull request on our docs repo and link it here: #xxx

[ ] Schema updated (if necessary)

no comment at this time


Port Gamepad

Summary
What is the feature all about? Is it a game, a utility, an enhancement, or something else?
Gamepad mode from 2023, now in IDF 5.0
Technical Spec
How will this be implemented?
What peripherals will be used, and how?
Digital touch buttons should be removed, and replaced with a virtual analog stick mapped to the new touchpad. 2024 hardware will be needed for this.
UI
What are the display screens & menus (if applicable)?
What user inputs are there for each screen?
Same UI as last year, but with changes for aforementioned touchpad redesign. We can also add a deadzone setting if we find it natural to return the finger on the touchpad to a "home" position in the center, rather than lifting the finger.
Mockups
Paste any mockups of screens or anything else here.
Sample analog stick visualization with deadzone:

How to Test
How can we verify the feature is working?
Test on a Switch and a PC

The bulk of the mode is currently ported, except for aforementioned UI/control changes and the gamepad support in the tinyusb component.
No compiling or testing has been done, since the tinyusb changes are required.

If you want to make the UI look more Metroid-Primey, and less gamecube controllery, that'd be cool too. Maybe some color swaps, maybe some HUD decor?

Currently blocked by missing driver support. Looking for helper(s) experienced with modifying components.
Will pick up UI and touchpad changes once driver compiles.

Driver support isn't missing, but I agree that it isn't working as expected. When loading demo mode, my Swadge does enumerate as a USB Gamepad, but it isn't sending button presses as expected. When I ported everything, I used TUD_HID_REPORT_DESC_GAMEPAD, but it looks like that was replaced in our source by TUD_HID_REPORT_DESC_GAMEPAD_SWADGE. I suspect something about that is screwy. Paging @cnlohr

Docu: https://docs.espressif.com/projects/esp-idf/en/v5.1/esp32s2/api-reference/peripherals/usb_device.html
Example: https://github.com/espressif/esp-idf/tree/v5.1/examples/peripherals/usb/device/tusb_hid

@Brycey92 in the meantime you can try checking out 2bf02263f92fe2401efbe2f98b22edb7c51a8df0, the rev before advanced USB changes, and see if Demo mode's USB works for you there.

I ran a fullclean, make, and idf.py build flash on https://github.com/AEFeinstein/Swadge-IDF-5.0/commit/2bf02263f92fe2401efbe2f98b22edb7c51a8df0 and the hardware becomes unresponsive when powered on. No LEDs light up, the TFT remains off, and the Swadge cannot be rebooted into the bootloader.
A forced programming mode boot with the D-pad UP held allows reflashing to known working firmware from main branch, though repeating steps to clean and build the suggested commit result in the same issues.

dang. Lets go further back, does it work in 30823ed? If so, this may be a job for git bisect

Also, fwiw, this was originally developed on a squarewavebird

This now compiles, connects to PC, and reports buttons, thanks to @AEFeinstein.
We now have to

update its UI for the new touchpad (@Brycey92)
add Nintendo Switch compat (@JVeg199X, @cnlohr)
add settings to change touchpad reporting style btwn 4/8/4+ctr/8+ctr/analog/etc (@dylwhich? @cnlohr? @JVeg199X? me? one of us should claim this if we have time.)

@Brycey92 motion support and PC/Switch compat are in main, so I think this is all in your court for UI and maybe some config if you want.


failure to install tulind and talib - any advise appreciated

this is what i get when i try to install the talib and tulind indicators on linux. any info or advise would be greatly appreciated. many thanks
...............................................................................................................................
make: Entering directory '/home/GLIgroup/gekko/node_modules/talib/build'
CXX(target) Release/obj.target/talib/src/talib.o
make: g++: Command not found
make: *** [talib.target.mk:103: Release/obj.target/talib/src/talib.o] Error 127
make: Leaving directory '/home/GLIgroup/gekko/node_modules/talib/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:198:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
gyp ERR! System Linux 5.1.6-200.fc29.x86_64
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build"
gyp ERR! cwd /home/GLIgroup/gekko/node_modules/talib
gyp ERR! node -v v10.16.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node ./src/lib/build.js && node-gyp configure && node-gyp build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!


feat(directive): introduce attr translate-sanitize-strategy

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[x] Make sure you are making a pull request against the canary branch (left side). Also you should start your branch off our canary.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.

Description
I found sanitizeStrategy argument in determineTranslation function which was never used. I've added new translate-sanitize-strategy attribute which uses this forgotten argument.

@Anber Great contribution, thank you very much

Picked as 4a2c3ab & 41c7e1f
Thank you again!


support for set/array/vector/matrix proposal

Hi, sometimes it is useful to operate not only on numbers, but on sets of numbers: vectors, matrices, ordered and unordered sets.
We can define operations for vectors as so:
[1, 2, 3, 4] * 7 = [7, 14, 21, 28]
[2, 4, 8] / 2 = [1, 2, 4]
[5, 8, 11] + 4 = [9, 12, 15]
[10, 7, 4] - 4 = [6, 3, 0]
for f(x) where x is number:
f([a1, a2, ..., an]) = [f(a1), f(a2), ..., f(an)]
and also some aggregate functions would be extremely useful e.g.
a = [1/2, 1/4, 1/8]
sum(a) = 7/8
avg, product, variance, min, max e.t.c.
[a1, a2, ..., an] * [b1, b2, ..., bn] = [a1 * b1, a2 * b2, ..., an * bn]
and more vector/matrix specific functions such as vector product...
what do you think of it?

I agree, this would be very useful. I should be able to implement this when I have time.

Maybe I should take a look on kalker's codebase and try to help with some stuff.
Is it complicated?

That would be cool. Basic vector support should be fairly simple, although the KalkNum struct probably needs some better way to deal with values of different types, so some architectural changes may be ideal, although probably not required initially to make this work. The implementation would involve:

Updating the lexer to support square brackets
Adding a vector type to the ast
Making the parser support vector expressions... in `parse_primary
Adding support for the vector types in the interpreter
Adding support for storing vectors in KalkNum (in the future KalkNum needs to be updated to support values of different types better, but initially it would probably work to deal with it the same way booleans are dealt with)

I'm trying to decide how to deal with the different kinds of multiplication operations with vectors. The Wolfram language seems to do the following:

* for element-wise multiplication, eg. [1, 2, 3] * [1, 2, 3] = [1, 4, 9]
. for dot product
× for cross product

The problem with this in kalker is that * and × are the same operator. *is automatically turned into × in the web version. I guess it would then be confusing if it did something else, as people could assume it would do the cross product instead. I feel like the "default" shouldn't be cross product though... Maybe it would be possible to replace * with a dot symbol instead of a cross when it's between two vectors, but that would require semantic information.

I have now implemented basic support for vectors/matrices.
Vectors are defined like (1, 2, 3) or [1, 2, 3]. You can do addition, subtraction, division, multiplication and power with another vector or a single number. The dot product is calculated for multiplication. I also added an average function that takes a vector: average([1, 2, 3]) or average(1, 2, 3), and modified min and max to take vectors. If a function is not made to handle vectors, the it applies the function on all the items like suggested in the issue. Vectors are primarily indexed like this: v⟦n⟧ which is equivalent of v[[n]], but can also be indexed by a lowered number v₁ which is equivalent of v_1.
Matrices are defined only with square brackets. New rows are defined either after a new line or a semicolon. Most operations are also possible here, but with some limitations to power operations. If a function is not made to handle matrices, the it applies the function on all the items. Matrices are indexed like this: m⟦a, b⟧.
Now it would be good to have some way of dynamically creating vectors. Maybe something like list comprehension in Python.


XIONE-936 : Port TextToSpeech plug-in onto Realtek platform

Reason for change : Modified TextToSpeech code to add Realtek pipeline

Cherry-Pick from 2101_sprint
Test Procedure : Build & verify voice guidance
Risks : Medium

(cherry picked from commit 7c230a5b884fe2f469409043a0df0a0e7ea29b28)
Signed-off-by: Sunil S<EMAIL_ADDRESS>Signed-off-by: Mark Yang<EMAIL_ADDRESS>

Jenkins build verified done:
[https://gerrit.teamccp.com/#/c/482984/]
https://jenkins.ccp.xcal.tv/jenkins/job/Gerrit-Trigger-Custom-Verification-SingleReview-Pipeline/42522/
Primary builds completed:
https://rdkportal.ccp.xcal.tv/builds/job/PACEXID-Yocto-Build/228677 - default - SUCCESS - GRT size: 70.37 MB, CI size: 83.72 MB, difference:N/A, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/CISCOG8-Yocto-Build/172559 - default - SUCCESS - GRT size: 94.60 MB, CI size: 94.50 MB, difference:100.84 KB, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/SKY-LLAMA-PANEL-Yocto-Build/22959 - default - SUCCESS
https://rdkportal.ccp.xcal.tv/builds/job/ARRISXG1V4-Yocto-Build/188483 - default - SUCCESS - GRT size: 101.26 MB, CI size: 109.89 MB, difference:N/A, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/HISENSE-A6GP-Yocto-Build/14751 - default - SUCCESS
https://rdkportal.ccp.xcal.tv/builds/job/TCHXi6-Yocto-Build/127311 - default - SUCCESS - GRT size: 95.08 MB, CI size: 95.07 MB, difference:12.02 KB, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/ARRISXG1V1-Yocto-Build/228094 - default - SUCCESS - GRT size: 86.16 MB, CI size: 102.22 MB, difference:N/A, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/CXD01ANI-Yocto-Build/211146 - default - SUCCESS - GRT size: 74.38 MB, CI size: 74.38 MB, difference:1 Byte, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/PACEXG2V2-Yocto-Build/231022 - default - SUCCESS - GRT size: 80.01 MB, CI size: 99.64 MB, difference:N/A, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/ARRISXI6-Yocto-Build/191512 - default - SUCCESS - GRT size: 93.17 MB, CI size: 103.18 MB, difference:N/A, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/PACEXI3V2-Yocto-Build/258429 - default - SUCCESS - GRT size: 70.23 MB, CI size: 89.80 MB, difference:N/A, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/PACEXI5-Yocto-Build/231445 - default - SUCCESS - GRT size: 78.24 MB, CI size: 93.50 MB, difference:N/A, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/ARRISXG1V3-Yocto-Build/219434 - default - SUCCESS - GRT size: 89.36 MB, CI size: 104.45 MB, difference:N/A, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/PACEXG1V3-Yocto-Build/279964 - default - SUCCESS - GRT size: 83.21 MB, CI size: 103.96 MB, difference:N/A, oversized: false
https://rdkportal.ccp.xcal.tv/builds/job/PLATCO-CAD11-Yocto-Build/19368 - default - SUCCESS

Closing this outdated PR. Please submit this to the latest sprint branch if needed.


Version string '5.0.0-beta.4' in info.plist is causing TestFlight upload failure

ℹ Please fill out this template when filing an issue.
All lines beginning with an ℹ symbol instruct you with what info we expect. You can delete those lines once you've filled in the info.
Per our *CONTRIBUTING guidelines, we use GitHub for
bugs and feature requests, not general support. Other issues should be opened on Stack Overflow with the tag alamofire.
Please remove this line and everything above it before submitting.

[x] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
TestFlight upload of my app which imports Alamofire via carthage
github "Alamofire/Alamofire" "5.0.0-beta.4"
What did you expect to happen?
Upload success and app show up on TestFlight as a new version.
What happened instead?
Got error
[11:33:55]: [iTMSTransporter] [2019-04-11 11:33:54 PDT] <main> ERROR: ERROR ITMS-90060: "This bundle is invalid. The value for key CFBundleShortVersionString '5.0.0-beta.4' in the Info.plist file must be a period-separated list of at most three non-negative integers. Please find more information about CFBundleShortVersionString at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring"
Alamofire Environment
Alamofire version: 5.0.0-beta.4
Xcode version: 10.0
Swift version: 5.0
Platform(s) running Alamofire:
macOS version running Xcode: 10.14.4
Demo Project
ℹ Please link to or upload a project we can download that reproduces the issue.

The problematic value is picked up from [here] https://github.com/Alamofire/Alamofire/blob/e9c742d8791aa3c028c65abdf9966a0cb4bf3e26/Source/Info.plist#L18
TestFlight upload was working fine for release named 5.0.0.beta.1

#2799 should resolve this issue. I'm going to close this issue out for now. Please direct all further comments to #2799.


Add more info to announced components in Discovery Server

This is a feature request for the Discovery Server.
See https://github.com/TheThingsIndustries/console/issues/381
It would be nice if we can add extra information to an announcement. We should add:

an Emoji or IconURL field
an Operator field, with information about the operator (name, homepage, ...)

Also contact uri (maybe link-like, so mailto: or https://)

Moving this to v3. We'll have to come up with a different mechanism, considering that there likely won't be a discovery server in v3...


fix: remove lodash

it's too easy to avoid using lodash to justify having it as a dependency IMO.
The only real point of isFunction is to use it as a predicate like arr.filter(isFunction).
It's trivial:
function isFunction(value) {
  return typeof value === 'function'
}

isString accepts primitive strings and also instances of the String class, but I don't know
anyone who's in favor of using the String class for anything.
function isString(value) {
  const type = typeof value
  return type === 'string' || (type === 'object' && value != null && !Array.isArray(value) && getTag(value) == '[object String]')
}

We were using isInteger to validate the level passed to one method, but that would fail to catch log levels that are out
of range, so I replaced it with a strict check that the value is one of the valid log levels.

Merged with a81558e946679d048f05807e52621b6a948fc407


Support flash messages

Flash messages are a common way to display success or error notifications to users in server-side rendered applications.
Dream already has a middleware to support sessions, which Flash messages are a specialization of, so it would be great to have a middleware and a set of API to support flash messages.
Additionnally, helpers to add flash messages in Eml templates would be really useful. For reference, here's Phoenix documentation on this: https://hexdocs.pm/phoenix/controllers.html#flash-messages. The templates look like this:

<%= get_flash(@conn, :info) %>

<%= get_flash(@conn, :error) %>

Definitely yes! I skipped this for now because I wasn't ready to design good flash helpers myself. Any good precedents very welcome.

Another precedent that might be of interest is Django's messages framework. Below is my quick summary of that page.
Messages have three main parts: The body of the message, which is a string, the level (debug, info, success, warning or error), and one or more string-valued tags. The level is always provided as one of the tags, and custom levels are possible. Messages can be stored in different ways (in the database or with cookies, for example).
 There are also convenience functions for creating messages at a particular level (e.g. messages.info(request, "hello")). There is functionality for disabling messages below a certain level (for example, if you don't want debug messages while running in production). The fail_silently option on add_message decides what to do if the messages framework is entirely disabled.
By default all of the flash messages get cleared when a response is processed (so they only show up once) but the framework allows app developers to mark a message so that it won't be cleared.
I'm interested in helping with this issue, if I can. That could mean continuing to research other precedents or putting together a prototype PR for discussion.

Thanks @jsthomas, that saved a lot of research time for me! I would welcome a prototype PR.

@jsthomas The example now has a writeup, is in the playground, and I finished up the docs for the feature.
Thanks again for actually implementing it in #62!

Awesome! This comment in the example is helpful, I learned something new here:

The total size of all flash messages attached to a request has a soft limit of about 3072 bytes. This is because cookies are generally limited to 4096 bytes, and Dream ends up encrypting flash messages and encoding them in base64, which blows up their original size by 4/3.


Please help Conda package tensorflow for OSX

(I get that this is a weird thing to put in an issue)
Right now it's hard for the Anaconda people to make conda packages of Tensorflow for OSX because of gcc-versus-clang issues:
https://github.com/ContinuumIO/anaconda-issues/issues/11697
This is impacting downstream packages that want to use tensorflow, as we can't specify conda environments that come with tensorflow included; installing it with pip afterwards severely limits our ability to sanely package it.
If you can spare the time to work this out with them, a lot of us who maintain downstream packages would really appreciate it.

Probably the necessary information needed here is how to build the correct Bazel compiler toolchain. You can have a look at https://github.com/conda-forge/tensorflow-feedstock/blob/40db5f43756877bea9e0dd2685cd5683b6527904/recipe/gen-bazel-toolchain.sh#L1 how we did this for conda-forge.

@pgunn,
TensorFlow provided pip package is recommended, But, You can use a community-supported Anaconda package. To install, read the Anaconda TensorFlow guide. Thank you!

It looks like there are conda-forge provided tensorflow packages now, so there's no need to keep this ticket open.
(I suggest a change in perspective to stop considering the pip package the recommended install route - a lot of the scientific community and several other communities use conda as their sole tool to manage their python environments and using pip for one package is a non-starter, but that's neither here nor there)


SIM bug fix when open CONFIG_SIM_WALLTIME_SIGNAL

Summary
sim/oneshot: don't need sleep_until when open CONFIG_SIM_WALLTIME_SIGNAL
sim/mem: don't let siwtch out when operated the host mem
Impact
sim when open CONFIG_SIM_WALLTIME_SIGNAL
Testing
VELA

@GUIDINGLI
During testing https://github.com/apache/nuttx/pull/8489, I noticed that the sim:smp consumes much CPU time.
Finally, I confirmed that this PR is the root cause of the high CPU load.


sensu-go: init at 5.9.0

Motivation for this change
New package.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build sensu-go-agent sensu-go-backend sensu-go-cli

Thanks @thefloweringash!


feature: Unified API

:loudspeaker: Type of change

[ ] Bugfix
[X] New feature
[ ] Enhancement
[ ] Refactoring

:scroll: Description
feature: Unified API
:bulb: Motivation and Context
SDK follows the Sentry convention for SDKs
https://develop.sentry.dev/sdk/unified-api/
:green_heart: How did you test it?
running samples and unit/integration tests
:pencil: Checklist

[X] I reviewed submitted code
[X] I added tests to verify changes
[X] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

Make sure not to squash this PR 👍

a few TODOs:
https://github.com/getsentry/sentry-dart/projects/1#card-48213380
https://github.com/getsentry/sentry-dart/projects/1#card-47082476
https://github.com/getsentry/sentry-dart/projects/1#card-47082234

Draft of the docs https://github.com/getsentry/sentry-docs/pull/2599


Possible enhancement: Allow setting request priorities

I've been using Volley with an OkHttp stack for a while now, but I've been wanting to switch to a pure OkHttp stack for a while now(streaming response bodies, interceptors, multipart requests, ease of integration are a few of the reasons).
One of the reasons I have held of on this change is because Volley has one feature that OkHttp doesn't have yet: support for prioritizing requests. Would such a feature be acceptable as a Pull Request if I implement it?

This is a tricky feature to do generally. Is policy fixed or pluggable? Does the default policy starve low priority requests? When is priority enforced? Do we short circuit low priority calls that would benefit from the cache? Is the priority shared with the HTTP/2 server?
I'm reluctant to solve this partially, and solving it generally is a lot of work. I'd prefer to punt on this for now.

AH, got it. I didn't think of that.
Anyway, this is something I need and I feel it would be a good addition to
the library. I'll draft up a set of reqs for the feature(considering
whatever you've mentioned) and update this issue. If you're okay with them,
I can implement this and submit a PR whenever it's ready.
On Thu, Feb 5, 2015 at 2:31 AM, Jesse Wilson<EMAIL_ADDRESS>wrote:

This is a tricky feature to do generally. Is policy fixed or pluggable?
Does the default policy starve low priority requests? When is priority
enforced? Do we short circuit low priority calls that would benefit from
the cache? Is the priority shared with the HTTP/2 server?
I'm reluctant to solve this partially, and solving it generally is a lot
of work. I'd prefer to punt on this for now.
—
Reply to this email directly or view it on GitHub
https://github.com/square/okhttp/issues/1361#issuecomment-72937939.

--
Vinay S Shenoy
Android App Developer at Flipkart.com
+91-9538122356 |<EMAIL_ADDRESS>LinkedIn : http://in.linkedin.com/in/vinaysshenoy

Cool. I think we'll probably hold on priorities until we also make the backend async for HTTP/2. When things are async we suddenly get better control over which order tasks are completed.

@swankjesse Is there a timeline for when the backend will be async?

No timeline.

@swankjesse is this feature implemented

Not implemented.

I don't quite understand the worries cited above.  Couldn't the priority simply be forwarded to the HTTP/2 server and be interpreted by the server?
How the server interprets priorities is given by the HTTP/2 spec (they can be ignored), and whether requests are starved etc. is out of scope for the library.
The tcp socket buffer size is the only thing the client needs to have control of.

OkHttp has a queue of pending requests not yet transmitted to the server. A good priority mechanism should probably influence the queue.

For our use case, we only wanted new requests to be prioritized over old requests, specifically with regard to the ready deque (last in, first out). The easiest way to accomplish that was to change the add call in the Dispatcher to a push (specifically this line).
This seems to be a more sensible default for many applications, if a real prioritization feature isn't on the roadmap for the foreseeable future.

Duplicate of https://github.com/square/okhttp/issues/1361

Duplicate of https://github.com/square/okhttp/issues/404


Comparison lists city names twice (for indicators with only one timepoint)

When comparing cities/districts on an indicator that only has one timepoint, the Atlas shows a column graph. It lists the name of each city/district twice -- once below the x-axis of the graph, and once in a 'legend' above the graph.
I suggest keeping only one of those lists, and I prefer to keep the labels on the x-axis and get rid of the legend.
Of course, we definitely need to keep the legend for line graphs (indicators with multiple timepoints)!

Would you mind giving an example? In my case I can only see the labels on the top

It only appears when you maximize the comparison


Update related record version edge-oai-pmh

Purpose
Describe the purpose of the pull request.
Approach
How does this change fulfill the purpose?
TODOS and Open Questions

[ ] Use GitHub checklists. When solved, check the box and explain the answer.

Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.


AMDGPU-PRO OpenCL support

projects using pytorch are usually nvidia only because who cares about other gpu's. Who cares about open standards.
pytorch is mostly to blame here, pytorch devs don't know opencl is exist and they don't see a future for it (that's obviously a wrong statement and downvoted to oblivion on the issue page)

See the arguements about opencl support for pytorch:
https://github.com/pytorch/pytorch/issues/488
https://github.com/pytorch/pytorch/issues/30029


TensorFlow 1.0.0 alpha binaries require SSE4.1

The TensorFlow 1.0.0 alpha binaries require SSE4.1, which was not necessary to run the binaries of earlier versions (e.g. 0.12.1). SSE4.1 is only supported by a few AMD architectures. In particular, it is not supported by the  "Barcelona" and the "Bobcat" architecture. They support SSE4a, which is not supported by Intel processors.
Therefore, running the 1.0.0 binaries on our workstations with "AMD Opteron(tm) Processor 6174" fails with the following error:
The TensorFlow library was compiled to use SSE4.1 instructions, but these aren't available on your machine.
Is it possible to make the official TensorFlow 1.0.0 binaries not dependent on vendor specific SSE4.1 instructions? I am aware that these AMD processors are not the newest ones and that it's possible to compile TensorFlow without the SSE4.1 requirement (at least, I assume so), but I wanted to raise this issue to see if you think it might be possible to make the official 1.0.0 binaries work without SSE4.1. Alternatively, would you consider offering alternative binaries without SSE4.1 similar to how you offer different binaries for different python versions?

I'm also having trouble finding the correct compiler flags to enable SSE4.1, SSE4.2 and AVX instructions. If anyone has insights, I'd really appreciate it.
Building on a Retina MBP with 2.6 GHz Intel Core i7 on Mac OS X El Capitan 10.11.6
from commit https://github.com/tensorflow/tensorflow/commit/d4b5c606fc9fbd1a20b5b113b4bc831f31d889a3 with this custom build rule:
cc_binary(
    name = "libtensorflow_all.so",
    linkshared = 1,
    deps = [
    	"//tensorflow/c:c_api",
        "//tensorflow/cc:cc_ops",
        "//tensorflow/core:framework_internal",
        "//tensorflow/core:tensorflow",
    ],
)

Based on this StackOverflow thread, I tried:
bazel build -c opt --copt=-mavx --copt=-mavx2 --copt=-mfma --copt=-mfpmath=both --copt=-msse4.2 tensorflow:libtensorflow_all.so

which threw the compiler error:
ERROR: /private/var/tmp/_bazel_pjh/932673a2a7490816ef213d3cdb401ef6/external/gif_archive/BUILD:8:1: C++ compilation of rule '@gif_archive//:gif' failed: cc_wrapper.sh failed: error executing command external/local_config_cc/cc_wrapper.sh -U_FORTIFY_SOURCE '-D_FORTIFY_SOURCE=1' -fstack-protector -Wall -Wthread-safety -Wself-assign -fcolor-diagnostics -fno-omit-frame-pointer -g0 -O2 -DNDEBUG ... (remaining 33 argument(s) skipped): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1.
error: unknown FP unit 'both'

I was able to compile with:
bazel build -c opt --copt=-mavx --copt=-mavx2 --copt=-mfma --copt=-msse4.2 tensorflow:libtensorflow_all.so

but the resulting .so immediately crashed at runtime.
I recompiled with the basic:
bazel build tensorflow:libtensorflow_all.so

but at runtime, I get the following warnings:
W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.

Thanks!

Having the TensorBoard binary require SSE4.1 sounds problematic. Could you take a look @zffchen78?

Is this issue receiving any love? I'd like to run tensorflow on a machine that doesn't have that instruction set.
At the very least, could someone tell me what's the most recent commit I could use that doesn't have this issue?

Thank you for your patience @abejfehr. I've sent a friendly ping to a couple Googlers via email. Expect an update very soon.

@gunan, did you already fix the build scripts/Jenkins setup to explicitly set the optimization flags? We should remove 4.1.

Well, with our latest change, (--config=opt) the binaries we build for distribution should now be without sse 4.1.
Could you try downloading and installing nightly binaries?

OK, with 1.0rc0, now the binaries should not need sse 4.1
Please let me know if you run into any issues.
I will close this issue now as our latest binaries are more compatible.

@gunan
I have similar issue issues issue. My cpu does not support avx2 and it will cause core dumped each time when import tensorflow. Is there any option to compile without this optimization?

@Noahsark yes, 1.0rc0 should not have SSE 4.1

@Noahsark It also does not have avx2.
It is back to the original compilation options.

Thanks a lot!

@gunan @yaroslavvb
I do switch to 1.0rc0 with the default compile option, but the problem still exists.
Here is the output when I try to import it.

import tensorflow
I tensorflow/stream_executor/dso_loader.cc:125] successfully opened CUDA library libcublas.so.8.0 locally
I tensorflow/stream_executor/dso_loader.cc:125] successfully opened CUDA library libcudnn.so.5 locally
I tensorflow/stream_executor/dso_loader.cc:125] successfully opened CUDA library libcufft.so.8.0 locally
I tensorflow/stream_executor/dso_loader.cc:125] successfully opened CUDA library libcuda.so.1 locally
I tensorflow/stream_executor/dso_loader.cc:125] successfully opened CUDA library libcurand.so.8.0 locally
F tensorflow/core/platform/cpu_feature_guard.cc:35] The TensorFlow library was compiled to use AVX2 instructions, but these aren't available on your machine.
Aborted (core dumped)

Any ideas ?
Thank you so much.

@Noahsark can you give a link to the binary that you've used?
(unless your built it yourself, which would be a different issue)

@yaroslavvb
Yes, I build it from source. Any way to get avoid this?

This is surprising -- you are compiling (by default) with
-march=native. This means that unless you compile on a computer other than
the one you run on, it should not use optimizations your machine doesn't
understand. Did you set the optimization flags? Which hash are you building
from?

Bad news, 1.0.0rc1 and the nightlies again require SSE4.1. @gunan Can you please reopen the issue.

I just verified that somehow we have some sse 4.1 instructions in the disassembled code.
But we are not sure how it crept back in.
Will do some debugging in our build scripts.

Found the problem. It was bad, because when you are building from sources on any machine it was enforcing -msse4.1. I am hoping to get fixed binaries everywhere by tomorrow.

Tested it with 1.0.0rc2. Looks good :-) Thanks a lot!

Glad to hear this is resolved.
Thank you for your patience.


Breachable wall missing

On the Bartlett Uni map there should be a breachable wall on the second floor between Upper Library (eastern wall) and Vista Hallway (western wall)

Yeah ooops, there are at least a couple on that wall eh? I will update this soon.


Bind ddev-router to IPv6 addresses

The Problem/Issue/Bug:
How this PR Solves The Problem:
Manual Testing Instructions:
Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

Will stop here because WSL2 does not support IPv6 without a special kernel :(


Surface API errors on the client more prominently

r? @cjavilla-stripe
cc? @mikito-stripe
This change updates the UI to surface any errors returned from fetch calls both in the console and in the UI. It displays the error in a black banner pinned to the top of the screen (screenshot below).
This also updates the Go implementation to abide by the API the client expects, which specifies an error property on the response JSON that contains the corresponding error message.

Thanks @andybons-stripe any chance you could write a test for this so we can ensure consistency across languages?
https://github.com/stripe-samples/checkout-single-subscription/blob/master/spec/server_spec.rb

Will do!

To catch this particular condition (a bad secret key), each example would have to be altered so that it reads the secret key when handling the request instead of once at startup time. Is that something we‘d like to do?


How to avoid default export to be separately listed from namespace?

Pretty much all of my files have a single default export of a class.
Therefor I pretty much not need / want the extra "namespace"
It causes a lot of double naming when searching:

And it creates a lot of empty namespace index files:

At first there was a lot of mentions of 'default', which wasn't ideal, so I now I'm using typedoc-plugin-rename-defaults .. which made things more clear, but now there is the double names.
My question is: Is there any way to remove the namespace so that there is just one "entry" per file for the default exported class?

I'm trying to figure out how you're generating the documentation of this library itself. Because besides the default exports, your code setup is very similar, and the end result of the typedoc API is what I'm trying to achieve. examples folder however points to outdated comments, and in the source code I don't see any references to what is internal vs external for example. Can you point me to where I can find the typedoc configuration in this repository that generates the typedoc API documentation itself?

Ok, to answer my own question. It seems removing default exports and changing everything to normal exports gives me the desired result in the output, and removes the namespaces. It will be quite a rewrite, but I'm open to this being the better solution.
If you're reading this @Gerrit0 I was your mention somewhere that you fullheartedly support moving away from default exports.
For future readers coming here with similar issues, can you offer any thoughts why you think that's a good idea in general?

If you google for "why not use default exports" you are going to find some ideas why it is better not to use them. 😉

There's a couple things here:

Entry point vs namespace vs file based documentation
Default vs named exports

The first is more important. TypeDoc before version 0.20 contained two modes, file and modules. file mode was originally intended for legacy JS projects which lived in the global scope while modules mode was intended for projects that used namespaces. 1 Recently built TypeScript projects tend to use ES modules, which either of these modes could kind of support, but neither did well. The modules mode evolved slightly over time to better support ES modules, but never did a really good job of it.
TypeDoc 0.20's goal was to fix this by adding first class support for projects using ES modules. This resulted in switching to what I like to call "entry point" based documentation.2 In entry point based documentation, the documentation tool creates documentation for your entry point(s), using the names that consumers of your package will import.
Practically, this means that most TypeDoc user's config should contain a single file as the entry point. TypeDoc's documentation is generated with typedoc src/index.ts. 3 This is a change from pre-0.20 config files which would have to specify every file that TypeDoc should consider for documentation.4
Default exports really only become a problem for documentation when you have multiple entry point, since then you'll end up with a bunch of modules that have exports with the same name. Assuming you have a top level entry point that exports your default exports under the canonical name, and use that to generate documentation, TypeDoc won't care if you used default or named exports.
Outside of documentation, I still don't like default exports. I mostly agree with Basarat's reasons, with the addition that the meaning of a default export is different depending on your compiler settings, the compiler settings of whoever is importing your code, and what module type they are running Node with... writing a post about this has been on my list for a while.
Footnotes:
1 It was called modules because that's what TypeScript before 1.5 called them, and most of TypeDoc was written then, though that's slowly changing...
2 During development, I was calling this "library mode", but I think "entry point" is a better name since it makes it obvious what the documentation tool is meant to do.
3 Plus some other options that aren't relevant here. The config file used is here, which is used by the GitHub action here
4 I tried to communicate this in the 0.20 release notes... but I still get enough questions about it that I must not have done a very good job, or some people just don't read release notes.

For your specific issue, and for users who are generating documentation for an application rather than a library, you might want to use typedoc-plugin-merge-modules, which will get rid of modules if you have a ton of entry points.


ASDK-2769 - fixing the constants colliding with the SDK

Coverage remained the same at 54.89% when pulling 276e129aedc32d5f0d1c6bb1ed2dffd0b4c859b5 on sdk_collision_fix into ca9276d8fc388219a72cb6b3b57b1c7691ea20c0 on development.

Coverage increased (+0.08%) to 54.94% when pulling 24b9c32bfc38880c03daf8007195473481c3476a on sdk_collision_fix into 70d14bb995ee46dcd5aef80ec0cdb643f3622a22 on development.


GDScript Search Help empty after creating an Object Script

Godot version
4.0 Alpha 9
System information
Windows 11, Vulkan, Nvidia GTX 1050 Ti, 512.15
Issue description
GDScript Documentation goes missing when a new script is created inheriting from Object (or other non-node classes)
Steps to reproduce
Open Scripting Tab
Open Search Help -> List Visible
Create New Script Inheriting from Object (or other non-node classes)
Open Search Help -> List Empty
Minimal reproduction project
MRP is impossible to create as reloading the project fixes it.

Can you reproduce this on 3.4.4?

No, albeit There seems to be an empty doc created in 3.4.4 as a result

Can someone verify this is still an issue on latest master or 4.0.3? I think it has been fixed

Was updating my above PR and was at that point "relying" on this to not make some improvements 😆, but fortunately I verified it still wasn't possible just to make sure I wasn't missing something and presto!


React JS npm start giving port busy ,but it is free

My react app when I run 'npm start' gives port busy. Even if a change the port same problem occurs. There's no problem in code as when I created new react app , encountered the same problem. Sudo lsof -i:port gives no process running and other apps(other than react) is also running perfectly.
sudo nano /etc/hosts/ content is also okay. <IP_ADDRESS> localhost
Environment-
node-12.18.0
{
  "name": "app1",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@testing-library/jest-dom": "^4.2.4",
    "@testing-library/react": "^9.3.2",
    "@testing-library/user-event": "^7.1.2",
    "react": "^16.13.1",
    "react-dom": "^16.13.1",
    "react-scripts": "3.4.1"
  },
  "scripts": {
    "start": " react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  }
}

Have you tried going to localhost:3000 to see if anything is there? Maybe a computer restart?

Have you tried going to localhost:3000 to see if anything is there? Maybe a computer restart?

Yes,I tried .There is nothing on running on that port.Also tried with changing the port, but didn't work.


Dev vscode extension

Introducing a basic VSCode extension locally that can be used to perform validations - there are still a number of issues to run through post this being merged.

[ ] Dependency issues are stopping from it being packaged/published.
[ ] GitHub action workflow to check that we're not breaking anything with any merges.
[ ] Add back in the visualization workflow to the plugin.

Sorry for the sea of WIP commits, trying to figure out how to get this GH action to work. Really not comfortable merging it without it.

Will aim to pick this back up now that the major CLI issues are resolved.

Closing this - as it needs re-done and revisited now that we're on npm workspaces.


ListView: add to the schema

Add ListView as a widget in Ensemble schema here with its properties -
https://github.com/EnsembleUI/ensemble/blob/main/assets/schema/ensemble_schema.json

@Moeez1999 please don't forget this one. Feature is not complete unless it is available to be used in schema.

done


Strange HoloMaps Axis behavior

holoviews version 1.10.5
%%opts Curve {+framewise +axiswise}
def mk_data(n):
    return pd.DataFrame( dict(x = [k for k in range(n)], y1 = [0.1*n*k for k in range(n)], y2 = [0.5*n*k for k in range(n)]  )).reset_index()

some_data = { str(i) : mk_data(k) for i,k in enumerate([18, 13, 16, 18, 19, 18, 19, 18, 18, 95]) }

def plot(i):
    h=\
    hv.Overlay([hv.Curve( some_data[i], 'index', hv.Dimension(v,label='y'), label=v) for v in some_data[i].filter(like='y').columns ]).options(width=720)
    return h.options(legend_position='left')

hv.HoloMap({ i : plot(i) for i in some_data.keys()})

Problem: Select plot 9, followed by plot 8:
the x axis range is not reset?!
Wishlist: an easy way to stop the axes from changing location as tick labels change lengths (e.g., the transition from 0 to 1)

Same issue as https://github.com/ioam/holoviews/issues/2753 I believe. This is a tricky issue that arose from the way we handle bokeh update messages. We might need to add some code to ensure that for non-dynamic plots all the data is embedded for each frame.

Appears to be fixed.


Reduce the number of dependencies

For example lz4 and bincode could be removed. Maybe even more ...

#39 and #40 remove the lz4_flex and bincode dependencies from the h3ron crate.


[FEAT]: ChromaDB Support

What would you like to see?
The current version of Chroma introduced some breaking changes and rules that make the current support of AnythingLLM for ChromaDB incompatible, we should revamp this connector to work with the latest version of Chroma

Seems to be attempting to retrive from chromadb just fine.. except it isn't creating new collections or storing properly (ValueError: Collection luminav2 does not exist.)
(luminav2) is the workspace name and the above ValueError is from chromadb output when ALLM tries to engage.

Requires support for collection name pre-flight check:
https://github.com/Mintplex-Labs/anything-llm/issues/1481


{AKS} fix: update logic to sanitize cluster name for DC* objects

Related command

az aks update -n kaveeshcli22 -g kaveeshcli --enable-azuremonitormetrics --enable-windows-recording-rules
az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azuremonitormetrics --enable-windows-recording-rules --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"
Description

The DC* objects can only container alphanumeric characters and '-' so updating the code to reflect it.
Testing Guide

This is a bug fix and can be tested by onboarding to the azure monitor for metrics addon using the above mentioned commands.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

AKS

DC* objects

Could you explain the meaning of DC* objects in the PR title? This description is easily confusing


error with getCurves

Hi,
I'm using your package with NextJS. when I run it I get the following error:
Unhandled Runtime Error
TypeError: getCurves is not a function
```
and the error handler point to `const verifyAppleToken = require("verify-apple-id-token").default;`

Hey @farrokh
thanks for the issue.
NextJS is frontend framework right? This library should be used on Node.js server - it is backend side library which takes apple token from frontend login process and verifies it against apple servers, if you look here: https://developer.apple.com/documentation/sign_in_with_apple/sign_in_with_apple_rest_api/verifying_a_user. It is prepared for the API server and Apple ID server side, not the App side. So please make sure, you use it on the server, not on the frontend.
Because when I quickly googled the getCurves function, it's available in Node.js and that is maybe the problem because Node.js features are not available on frontend. But I am not sure where the getCurves comes from at the moment.
If you use the lib on the backend / server side, could you please share the whole stack trace and include the exact "minimal working example" for your issue? :pray:

Duplicate of

Hey @farrokh
thanks for the issue.
NextJS is frontend framework right? This library should be used on Node.js server - it is backend side library which takes apple token from frontend login process and verifies it against apple servers, if you look here: https://developer.apple.com/documentation/sign_in_with_apple/sign_in_with_apple_rest_api/verifying_a_user. It is prepared for the API server and Apple ID server side, not the App side. So please make sure, you use it on the server, not on the frontend.
Because when I quickly googled the getCurves function, it's available in Node.js and that is maybe the problem because Node.js features are not available on frontend. But I am not sure where the getCurves comes from at the moment.
If you use the lib on the backend / server side, could you please share the whole stack trace and include the exact "minimal working example" for your issue? 🙏

Hey,
Yes I figured it out last night! I moved the code to API side and works fine now. Thanks again for your time.

Thanks for the response! Perfect, hope it is now all good! Let me know when there are some problems! :slightly_smiling_face:


mixin breakage in 1.20.1 forge v1.3.0

Re did my issue due to a malware bot
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Callback method fixBowUseBug(Lnet/minecraft/world/InteractionHand;)Lnet/minecraft/world/InteractionHand; in mob-ai-tweaks.mixins.json:RangedBowAttackGoalMixin from mod mob_ai_tweaks failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap mob-ai-tweaks-refmap.json

what do you use to show mixin errors on forge?  Scanned 1 target(s). Using refmap mob-ai-tweaks-refmap.json
23:23:23.420
game
at MC-BOOTSTRAP/org.spongepowered.mixin/org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
23:23:23.420
game
at MC-BOOTSTRAP/org.spongepowered.mixin/org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1384)
23:23:23.420
game
at MC-BOOTSTRAP/org.spongepowered.mixin/org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1062)
23:23:23.420
game
at MC-BOOTSTRAP/org.spongepowered.mixin/org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:402)
23:23:23.420
game
at MC-BOOTSTRAP/org.spongepowered.mixin/org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327)
23:23:23.420
game
at MC-BOOTSTRAP/org.spongepowered.mixin/org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
23:23:23.420
game
at MC-BOOTSTRAP/org.spongepowered.mixin/org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
23:23:23.420
game
at MC-BOOTSTRAP/org.spongepowered.mixin/org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
23:23:23.420
game
... 23 more```

https://gist.github.com/Mysticpasta1/6e9a9f35588c048f87bb224695101f62

here is the full error


Question: Why do modules have "module" appended to their name?

This seems a bit redundant to me. Just wondering if there is a specific reason it displays like this.

Just a naming convention, and to identify them as modules. It's not strictly necessary.


Update typography.md

fontsource-roboto has been deprecated
Package relocated. Please install and migrate to @fontsource/roboto

[x] I have followed (at least) the PR section of the contributing guide.

Already fixed: https://next.material-ui.com/components/typography/


Run bandit check for python/triton/runtime

Prerequisite for https://github.com/intel/intel-xpu-backend-for-triton/issues/2844

See also https://bandit.readthedocs.io/en/latest/plugins/b101_assert_used.html:

Consider raising a semantically meaningful error or AssertionError instead.

Closing it since https://github.com/intel/intel-xpu-backend-for-triton/issues/2844#issuecomment-2504735597


Having an issue understanding how to utilize the 'quoted-printable' decoding

Does anyone have any examples they could point me to (above and beyond the code)? I'm doing the following (for reference):
mailbox = '/var/mail/ubuntu'
mail = Mail.read(mailbox)
puts mail.body.decoded
(simple, right?) :)
Ultimately I want to have a clean message body that I can start extracting IPs, domains, and URLs from...but i need to get past this hurdle first.

Could you give an example of what the body you are getting looks like?  It's unclear to me if you're asking how to use the gem to read emails from the mailbox or what you mean by "clean message body".  Thanks

Use mail.decoded (not mail.body.decoded) to get the message body.


[Drawer] Fix behavior on RTL layouts

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

As reported in #5603, If you set isRtl: true, Drawer component swipe to open and close does not work as expected. In fact, a sidebar that located on the right of the screen opens by swiping from the left while it should get opened by swiping from the right. Also, an open drawer can get closed by swiping to the left, while it should get closed by swiping to the right.
This pull request applies some minor changes to detect isRtl and change swipe behavior based on that.
Please let me know if any changes required.

@alireza-ahmadi Thanks


EnvironmentPlugin handling of null/undefined for default values is inconsistent with docs

Bug report

What is the current behavior?
Using a null default value does not cause builds to fail if that environment variable is not defined.
new webpack.EnvironmentPlugin({
  ENV_TYPE: null
})

If the current behavior is a bug, please provide the steps to reproduce.
https://webpack.js.org/plugins/environment-plugin/

What is the expected behavior?
In the documentation for EnvironmentPlugin, it says this:

To specify an unset default value, use null instead of undefined.

If an environment variable is not found during bundling and no default value was provided, webpack will throw an error instead of a warning.

I infer that this means that using this will fail if no environment variables are provided:
new webpack.EnvironmentPlugin({
  ENV_TYPE: null
})

Whereas this will not:
new webpack.EnvironmentPlugin({
  ENV_TYPE: undefined
})

I expect this is an error in the documentation, or the wording is unclear.

Other relevant information:
webpack version:
Node.js version:
Operating System:
Additional tools:

I believe the document is right although I'm not the one wrote it.
If you have a rule without specifying an environment variable:
new webpack.EnvironmentPlugin(['ENV_TYPE'])

Then process.env.ENV_TYPE would be undefined, which is same to:
new webpack.EnvironmentPlugin({
  ENV_TYPE: undefined
})

In both cases, webpack will throw an error.
Hence the documentation recommends to use null to initialize ithe value if you don't care about the value of your variable at the beginning. Actually, anything other than undefined is ok here, e.g., ''.
Maybe we can change it to something like:

Do not  use undefined for the default value, otherwise webpack would throw an error.

Ok I see your point.
I think the main part that was unclear to me was this sentence as it's ambiguous whether "an unset default value" means "a default value will not be set" vs "the default value shall be the unset value (ie undefined)":

To specify an unset default value, use null instead of undefined.

The behaviour is actually the latter interpretation.

Maybe we can change it to something like:

Do not use undefined for the default value, otherwise webpack would throw an error.

I'm not sure the docs should instruct people not to use it.
In my application I need to use both to support both optional and non-optional environment variables:
new EnvironmentPlugin({
  APP_NAME: undefined,
  API_ROOT: null,
});

APP_NAME needs to be an error as it has not meaningful default value, but the application provides its own default if API_ROOT is not defined, so I don't want to treat that as an error.
What about something like this?

Note that null and undefined values behave differently. Use undefined for required environment variables, or null if they are optional.

@jdmnd Make sense. Would you love to file a pull request for it? Otherwise I can help.


[BUG] Bloxstrap updates when launching from website

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

What problem did you encounter?
I have auto-update off
Sorry for few details

Like, it's updating to the latest version when you have auto-update off?

Yes. When launching from the website, it launches bloxstrap.exe which auto updates even if I have it off.

Upload your configuration: https://github.com/pizzaboxer/bloxstrap/wiki/Uploading-your-Bloxstrap-configuration

I don't need this anymore.


The world model is damaged after exporting to onnx

with fp16 and version 17.
After exporting the model, attempting to use onnx infering resulted in an error.
onnxruntime.capi.onnxruntime_pybind11_state.Fail: [ONNXRuntimeError] : 1 : FAIL : Load model from RWKV_32_4096_16_17_seq.onnx failed:Type Error: Type parameter (T) of Optype (Mul) bound to different types (tensor(float) and tensor(float16) in node ().
There seems to be a defect in fp16 quantification. Please fix it as soon as possible. Thank you

Onnx conversion development is now moved to https://github.com/daquexian/faster-rwkv. You can contact that author.


fix: fixing boxes wip

Refactoring boxes.
This PR does the following:

Fixes the frontend side of boxes, which was broken and not tested in CI (only jest tests were tested in CI).
Fixes the README which was quite outdated
It also refactors the boxes to be little bit easier to work with.

This is prob not the last contribution to boxes. We will probably:

Add a frontend test to run on CI so we can catch when the frontend breaks too.
Remove A LOT of frontend code which was nice but not really necessary for a minimal, barebones boilerplate, such as form validation and other features.

Summary

Move artifacts and tests outside of the src folder.
Makes the README much more straightforward. Less.
Makes package.json scripts follow a pattern where dev will run webpack in dev mode (with hot reload, etc), build runs webpack in prod, and serve serves it.
For some reason, there were two scripts setting up the PXE. Unified them in one and provided a helper class instead.

Closes AztecProtocol/dev-rel#134

Benchmark results
Metrics with a significant change:

note_trial_decrypting_time_in_ms (8): 24.8 (-77%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit ea840857 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,412
179,524
716,068

l1_rollup_calldata_gas
221,560
866,968
3,448,360

l1_rollup_execution_gas
313,979
984,640
3,667,949

l2_block_processing_time_in_ms
1,408 (-14%)
5,566 (+5%)
21,052

note_successful_decrypting_time_in_ms
312 (+5%)
930 (+8%)
3,526 (+11%)

note_trial_decrypting_time_in_ms
:warning: 24.8 (-77%)
53.7 (-43%)
152 (+5%)

l2_block_building_time_in_ms
16,191 (+1%)
63,874
256,719

l2_block_rollup_simulation_time_in_ms
11,773
46,464
187,232

l2_block_public_tx_process_time_in_ms
4,380 (+1%)
17,324 (+1%)
69,193

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,921 (-1%)
30,713

note_history_successful_decrypting_time_in_ms
2,198 (+11%)
4,188 (+9%)

note_history_trial_decrypting_time_in_ms
209 (+38%)
166 (-63%)

node_database_size_in_bytes
3,515,092
3,559,500

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
213
44,681
25,561

private-kernel-ordering
166 (+1%)
43,753
14,809

base-rollup
1,194
128,338
881

root-rollup
79.0
4,088
677

private-kernel-inner
292
71,208
25,561

public-kernel-private-input
206
31,863
25,561

public-kernel-non-first-iteration
203
31,905
25,561

merge-rollup
7.65
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,455
32,219

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
375
1,087

Metric
1 public data writes

tx_sequencer_processing_time_ms
536

closes AztecProtocol/dev-rel#146

gonna stack this up to close AztecProtocol/dev-rel#147 too

Closing as github refuses to acknowledge there's no diff with master except on boxes. Will open a new PR


Remove cookies from all domains

HI! It would be usefull to add method that removes cookies from all domains and not just current as Selenium's .deleteAllCookies() do.

Well, how to do that?

Here's an example in python, but same idea in java:
wd = self.webdriver
cookies = wd.get_cookies()
    for cookie in cookies:
       if cookie["domain"] == [domains i've worked]:
              wd.delete_cookie(cookie["name"])

Saw this text in Selenide sources: If browser window was already opened before, it will be reused. Does this mean that once opened current browser session will be reused for every @Test in my class?

Sorry, I thought Selenide was reopening browser every new test but it was not. Resolved my issue by adding this code to test class:
@AfterClass
    public static void endSession() {
        closeWebDriver();
    }

So, can we close the issue?

Closing the issue


Parse addStoryType string value to boolean

YAML booleans are actually strings when retrieving them with core.getInput(), so they need to get parsed to a boolean value.
I've applied a fix for the addStoryType input. It defaults to true.

Hey @kuritz. Just saw that a new version of this repo was released and that it causes conflicts on all my PRs. Could you please let me know if you're interested in merging these, so I know if I should fix the conflicts or not.

Hey @dnsv, sorry for that. The preference would be to open an issue first to discuss the change you want to make and then open PRs. We should add a contributing guide detailing that, so our fault for it being ambiguous.
I think this one is straightforward and we can get it merged ASAP. Thanks for proposing this. Can you update the tests to use string values as well in accordance with this discrepancy you pointed out?
I'll take a look at the other ones now.

@kuritz Thanks. I've resolved the conflicts and added a test. Existing tests don't need to get updated as they bypass the parsing by focusing directly on getTitle() and not run().

Existing tests don't need to get updated as they bypass the parsing by focusing directly on getTitle() and not run().
Oh, I see. Thanks for pointing that out, i didn't not notice that!


Updated Gradle to 4.0.1

This looks good.
I would use the full version of gradle instead but that's just me because I do a lot of gradle build development and I like having the docs downloaded too.
Example:
https://github.com/wpilibsuite/allwpilib/blob/master/build.gradle#L67-L70

There's a major build system update that will be PR'ed soon, so this is OBE.

"OBE"?

Obsoleted By Events.


tt_lib.tensor.rmsnorm with no beta and gamma provided breaks with low PCC for BFLOAT8_B input and gets stuck [Wormhole]

Describe the bug
tt_lib.tensor.rmsnorm operation in case without beta and gamma tensor provided fails in all combinations of test cases involving BFLOAT8_B type input tensor on Wormhole with low PCC errors. Also, it was noticed that it gets stuck either for larger input dimensions or after low PCC failure, so the next test after the failing one will never be executed. The problem was first noticed in sweep tests, and then reproduced within unit test.
To Reproduce
Steps to reproduce the behavior:

Checkout branch main
Run unit test test_rmsnorm_noweights.py  using this command:
pytest tests/tt_eager/python_api_testing/non_working_unit_tests/wormhole/test_rmsnorm_noweights.py

Expected behavior
There are four test cases presented in the unit test tests/tt_eager/python_api_testing/non_working_unit_tests/wormhole/test_rmsnorm_noweights.py and the first one is expected to fail. After that, the execution gets stuck.

The first test case is breaking with error like this:
Max ATOL Delta: 1.2105675798371893e+20, Max RTOL Delta: inf, PCC: 0.8654571727427982, PCC check failed

Getting Additional info for the operation under test and its behavior
To get additional information and results for different combinations of input shapes, types, layouts and memory configs for which this operation was tested you can also run locally sweeps for tt_lib.tensor.rmsnorm and check the results. To do this you should:

Follow the Getting Started page to setup the repo, environment variables and python-env
Activate source build/python_env/bin/activate
Run sweeps by using python tests/tt_eager/python_api_testing/sweep_tests/run_pytorch_test.py -i tests/tt_eager/python_api_testing/sweep_tests/test_configs/ci_sweep_tests/broken_wormholel/pytorch_rmsnorm_noweights_test.yaml -o ./result-sweeps
After the run is completed all test sweeps results should be available inside specified output directory (in this case ./result-sweeps). There you will find rmsnorm_noweights_sweep.csv which holds all executed sweeps, among which you can also find the ones that failed and were recreated by the unit test, which you can get by searching unique data_seed field.

Unfortunately, it still gets stuck and exhibits low PCC for the same test case

I see this test pass on main. Are you rebased on main after 51b163010a98d3d610b90950bb57e23005f75574?

I rebased and confirm that it is now working. Issue can be closed.


Fix failing strict wildcard pushdown tests

A change that went in a while ago has made changes to the wildcard query functionality. It now functions as it had historically. This PR updates the testing logic to make sure the wildcard tests account for these differences.

See also https://github.com/elastic/elasticsearch/pull/71751


x/tools/internal/lsp: frequent "expected full AST […], returned trimmed" failures in builders

I've been looking through flakes on the build dashboard, and noticed a pattern in the x/tools/internal/lsp tests. They seem to fail frequently with error messages of the form expected full AST for file:///tmp/workdir/tmp/[…].go, returned trimmed.
Examples:
https://build.golang.org/log/035d6f57a677b538aa7bcbab8e4d959d225896b3
https://build.golang.org/log/bd47b4f273b8fba6536cbb47257a2340c0575bad
https://build.golang.org/log/035d6f57a677b538aa7bcbab8e4d959d225896b3
https://build.golang.org/log/2d45e4b10c7e990d922b9606b99db59c4d10635c
https://build.golang.org/log/008b9f9c6839ab16253155c23b5f22f5df9a2222
CC @stamblerre @ianthehat

It's not clear to me whether this one is related or not: a no AST for rather than expected full AST.
https://build.golang.org/log/13d5da81654a025a3bf86d38b616d7936a0788f2

There are some race conditions in gopls but we are working on a significant rewrite, so hopefully those flakes will go away once those are in.

This issue is fairly old and we have resolved the races between full/trimmed ASTs, so I think this can be closed now.


Code is Crashing on version 2.3.1

Hi William,
Hope you are doing well!
We tried to use the 2.3.1 version of terraform and now it is crashing. Please find the error below. Kindly advise
Stack trace from the terraform-provider-zpa_v2.3.1 plugin:
panic: interface conversion: error is *errors.errorString, not *zpa.ErrorResponse
goroutine 54 [running]:
github.com/zscaler/terraform-provider-zpa/zpa.resourceAppConnectorGroupRead(0xc000290480, {0xb6b5e0?, 0xc000406b60})
github.com/zscaler/terraform-provider-zpa/zpa/resource_zpa_app_connector_group.go:167 +0x589
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xdce5d8?, {0xdce5d8?, 0xc00028e8d0?}, 0xd?, {0xb6b5e0?, 0xc000406b60?})
github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/schema/resource.go:712 +0x178
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).RefreshWithoutUpgrade(0xc00021c700, {0xdce5d8, 0xc00028e8d0}, 0xc000404dd0, {0xb6b5e0, 0xc000406b60})
github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/schema/resource.go:1015 +0x585
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadResource(0xc0002098d8, {0xdce5d8?, 0xc00028e7b0?}, 0xc000211680)
github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/schema/grpc_provider.go:613 +0x497
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadResource(0xc00026cfa0, {0xdce5d8?, 0xc00028e1e0?}, 0xc0002005a0)
github.com/hashicorp/terraform-plugin-go@v0.14.0/tfprotov5/tf5server/server.go:748 +0x49e
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadResource_Handler({0xc6dcc0?, 0xc00026cfa0}, {0xdce5d8, 0xc00028e1e0}, 0xc0002348c0, 0x0)
github.com/hashicorp/terraform-plugin-go@v0.14.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:349 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0xc00036a000, {0xdd1048, 0xc00040d1e0}, 0xc00024b200, 0xc000391a40, 0x126d4b0, 0x0)
google.golang.org/grpc@v1.48.0/server.go:1295 +0xb0b
google.golang.org/grpc.(*Server).handleStream(0xc00036a000, {0xdd1048, 0xc00040d1e0}, 0xc00024b200, 0x0)
google.golang.org/grpc@v1.48.0/server.go:1636 +0xa1b
google.golang.org/grpc.(*Server).serveStreams.func1.2()
google.golang.org/grpc@v1.48.0/server.go:932 +0x98
created by google.golang.org/grpc.(*Server).serveStreams.func1
google.golang.org/grpc@v1.48.0/server.go:930 +0x28a
Error: The terraform-provider-zpa_v2.3.1 plugin crashed!
This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.
====================================================
Error: Request cancelled
with zpa_segment_group.file_share_seg_grp
on segment_group.tf line 107, in resource "zpa_segment_group" "file_share_seg_grp":
resource "zpa_segment_group" "file_share_seg_grp" {
The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
======================================================
Thank you.

Hi @Mayur-Movaliya  Thanks for reaching out. Would you mind adding the following log traces, run Terraform again, and post on Gist the log output? Also, can you clarify which resource exactly you're trying to create?
Running tests on my end and assuming you're creating an app connector group, the resource was successfully created without any problems.
export TF_LOG="TRACE"
export TF_LOG_PATH="terraform.log"

Thanks for your quick response William. I am trying to create a segment group and it is failing.

I need to see your configuration and potentially the trace logs. Testing the resource in my environment it is working as expected.

Hi William,
A big Thank you for fixing the code now it works on V2.3.2.  Also the Access Policy Rule order works as expected.


Adobe Extract overrides important AltGr shortcuts on international keyboards

On QWERTY keyboards we use:
Alt Gr + + to write ]
But when I've Adobe Extract opened it is used to zoom the PSD and the symbol is not inserted.

@redmunds hello,
please whai is the code to handle Alt Gr ?
i tried in keymap.json
{
"documentation": "https://github.com/adobe/brackets/wiki/User-Key-Bindings",
"overrides": {
"AltGr-P": "xxxxx.shortcuts"
}
}
but brackets say the shortcut is not good
i do not find anything about it on https://github.com/adobe/brackets/wiki/User-Key-Bindings
thanks

@yoyoy You can simply write "Ctrl-Alt-P" rather than "AltGr-P".

Same problem on Windows and Brackets 1.2 on an AZERTY keyboard.
If I want to do this } I have to do AltGr + +, and when Extract if open, it zooms.

Fixed buying a MacBook with american keyboard layout :D
I'm still sure there must be some easier fix...

I have filed this internally for Extract. I may not get fixed in this release but hopefully the next one

Hi! The problem seems to be still there: on an PC AZERTY keyboard.
If I want to do this  }, I have to do AltGr + =,  and when Extract if open, it zooms.

Deprecated feature See details . Closing.


Update RubyMine.app zap list without no_dots method

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

Did RubyMine change their app data paths?

Yes. You can look PyCharm.app, IntelliJ IDEA.app or WebStorm.app, they are all without no_dots method


Explore how to improve support for filing performance issues

Is there more data that could be collected?
Ability to start/stop data collection while repro'ing problem
Embed parts of performance wiki

Closing as out-of-scope


Release initial version - 0.1

Remember to add instructions to README

PC 0.1.0 is now available on repo1 https://repo1.maven.org/maven2/io/confluent/parallelconsumer/parallel-consumer-core/0.1.0/


image: Support writing still images to stdout

Signed-off-by: David Plowman<EMAIL_ADDRESS>

@naushir Fixes https://github.com/raspberrypi/libcamera-apps/issues/139
(I notice the imx477 run-test seems to have got stuck... not clear to me why, I don't think it can be down to this change. Anyway, no urgency, let's deal with it next week!)


add hacking with yearn guide

closes #195
also formats the sidebar config file into a more readable form (every line is a file now)

link linter says that a link is broken but it isn't .-.


Support for embed="false" audio on HTML5 needs to be restored

Nevermind, this appears to work properly, I took the "PlayingSound" sample, and edited the <assets /> tag to include embed="false"
As expected, this caused it to fail on HTML5, with a message that "stars.ogg" is only available asynchronously on HTML5.
I then tried the following modified class:
package;

import motion.easing.Quad;
import motion.Actuate;
import openfl.display.Sprite;
import openfl.events.Event;
import openfl.events.MouseEvent;
import openfl.media.Sound;
import openfl.media.SoundChannel;
import openfl.media.SoundTransform;
import openfl.Assets;

class Main extends Sprite {

	private var background:Sprite;
	private var channel:SoundChannel;
	private var playing:Bool;
	private var position:Float;
	private var sound:Sound;

	public function new () {

		super ();

		Actuate.defaultEase = Quad.easeOut;

		background = new Sprite ();
		background.alpha = 0.1;
		background.buttonMode = true;
		background.addEventListener (MouseEvent.MOUSE_DOWN, this_onMouseDown);
		addChild (background);

		Assets.loadSound ("assets/stars.ogg").onComplete (function (sound) {

			this.sound = sound;

			//#if flash
			//sound = Assets.getSound ("assets/stars.mp3");
			//#else
			//sound = Assets.getSound ("assets/stars.ogg");
			//#end

			position = 0;

			resize ();
			stage.addEventListener (Event.RESIZE, stage_onResize);

			play ();

		});

	}

	private function pause (fadeOut:Float = 1.2):Void {

		if (playing) {

			playing = false;

			Actuate.transform (channel, fadeOut).sound (0, 0).onComplete (stop);
			Actuate.tween (background, fadeOut, { alpha: 0.1 });

		}

	}

	private function play (fadeIn:Float = 3):Void {

		stop ();

		playing = true;

		if (fadeIn <= 0) {

			channel = sound.play (position);

		} else {

			channel = sound.play (position, 0, new SoundTransform (0, 0));
			Actuate.transform (channel, fadeIn).sound (1, 0);

		}

		channel.addEventListener (Event.SOUND_COMPLETE, channel_onSoundComplete);
		Actuate.tween (background, fadeIn, { alpha: 1 });

	}

	private function resize ():Void {

		background.graphics.clear ();
		background.graphics.beginFill (0x24afc4);
		background.graphics.drawRect (0, 0, stage.stageWidth, stage.stageHeight);

	}

	private function stop ():Void {

		playing = false;

		Actuate.stop (channel);

		if (channel != null) {

			position = channel.position;
			channel.removeEventListener (Event.SOUND_COMPLETE, channel_onSoundComplete);
			channel.stop ();
			channel = null;

		}

	}

	// Event Handlers

	private function channel_onSoundComplete (event:Event):Void {

		pause ();
		position = 0;

	}

	private function stage_onResize (event:Event):Void {

		resize ();

	}

	private function this_onMouseDown (event:MouseEvent):Void {

		if (!playing) {

			play ();

		} else {

			pause ();

		}

	}

}

This is working properly, so issue closed :wink:


python3Packages.python-izone: 1.1.6 -> 1.1.8

Motivation for this change
Update to latest upstream release 1.1.8
Change log:

https://github.com/Swamp-Ig/pizone/releases/tag/v1.1.8
https://github.com/Swamp-Ig/pizone/releases/tag/v1.1.7

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build home-assistant


Problem with a command

Hello Thomas,
When I want to run this command  "sudo dpkg --install pico2wave.deb", I get an ERROR like this:
dpkg: error processing archive pico2wave.deb (--install):
cannot access archive: No such file or directory
Errors were encountered while processing:
pico2wave.deb
Maybe you have a solution for me...
nice regards from Austria
Markus

cannot access archive: No such file or directory

You don't have that file (pico2wave.deb).


[panopto] Extract subtitles for videos without m3u8 subs

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[X] At least skimmed through contributing guidelines including yt-dlp coding conventions
[X] Searched the bugtracker for similar pull requests
[X] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[X] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[X] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Panopto provides captions in json via an endpoint.
Note the duration of the subtitle is not always available, so I use the next captions start time as the end in that case.

Tests I've added current do not entirely pass. We need to add functionality to InfoExtractor._merge_subtitles to support merging subtitles that have data instead of url.

needs https://github.com/yt-dlp/yt-dlp/pull/3044


Use wait_until_ready over on_ready

Why wait_until_ready over on_ready
Hey there! I noticed you had the on_ready() listener implemented. Doing anything on_ready() is generally not good practice, as stated here on the discord.py documentation page for on_ready(). Instead, I've implemented wait_until_ready(), which is better practice, and will prevent issues like random disconnects or the event firing multiple times from happening.

Thanks for the PR :).


[DON'T MERGE] Disable GC on scheduler at benchmark start

Based on, https://github.com/dask/distributed/issues/4987, ran SF1k w/ GC disabled on the scheduler process, and observed total benchmark runtime improvement of about 5s. This was consistent across many runs.
Results from larger scale tests are pending.

Well the other interesting thing from that thread was pinning the Scheduler to a single CPU. Admittedly that's probably a little hacky (ok for the exploration Gabe is doing). If that is important longer term, we can investigate other ways to set that.

@jakirkham worth noting that I only did that so the measured CPU times (particularly idle time) were easier to understand on a multi-core machine. The disabling-GC performance boost seemed the same without it. I suppose it could make a difference with memory access performance if the kernel is moving the process around between physical cores, but I don't think we're at the point of worrying about that yet.


Automatic X.509 certificate issuance and publication using Federation API

According to @fmarino-ipzs 's perspective, the most smart proposal appears to be the following below:
During the entity registration (onboarding procedure) we issue one X.509 certificate for all the Federation Entity Keys, providing therefore one or more JWK including the x5c parameter valued with the X.509 Certificates in Base64(DER) format.
The application specific jwks, included in each application specific metadata, would be self-issued by leafs using the private cryptographic key of one of the Federation Entity Keys with x5c.
This approach makes every leaf as an X.509 certificate issuer about itself.
Below an X.509 Certificate Chain example:

Trust Anchor/CA X.509 Self issued Certificate (iss: ta, sub: ta),
X.509 Certificate issued by TA/CA about an Intermediate (if any) (iss: ta, sub: immediate descendant)
X.509 Certificate issued by the immediate superior entity above about the Leaf (iss: immediate superior, sub: immediate descendant)
X.509 Certificate issued by the Leaf about the one of the metadata jwk under its control (iss: itself, sub: itself)

This approaches enables:

freedom in each participant in issuing all about themselves according to the verifiable evidences provided with the trust chain about themselves
opportunity to RP instances (ISO 18013-5 verifiers apps belonging an RP domain)
scalability, every participants using the chain provided wit hthe federation entity keys, are enabled in issuing whatever certificates they needs

This would require every participants issuing X.509 certificates about itself, to provide X.509 certificates revocations (CRL) and any other certificate transparency endpoints.

Am I correct to assume that this is an attempt to get around the requirements in the implementing acts enforcing entities to be represented by a certificate?
I don't think this will do it, as each issuer must be a trustworthy CA.
My thinking along these lines is that we would setup one CA that issues certificates to all entities that needs a certificate according to the regulation. This will only require one certificate in the trusted list (The one CA:s certificate).
I think this will satisfy the requirements and allows participants to choose what trust infrastructure they want to use.
But I may have completely missed the reason for this proposal. But making every entity a CA seems like a lot of overhead.

Am I correct to assume that this is an attempt to get around the requirements in the implementing acts enforcing entities to be represented by a certificate?

this is the solution allowing an automatic issuance of X.509 certificates, required for legacy applications, using the trust established using federation.

I don't think this will do it, as each issuer must be a trustworthy CA.

using the proposed solution each federation entity is free to issue a signed statement, therefore an X.509 certificate, about itself because this is verifiable using a trust chain about it. This is the same approach we use for the Entity Configurations.

My thinking along these lines is that we would setup one CA that issues certificates to all entities that needs a certificate according to the regulation. This will only require one certificate in the trusted list (The one CA:s certificate).

this doesn't scale, it is problematic thinking about a PKI without intermediaries. For this level of awareness I might leave to your the floor as the author of RFC5280

But I may have completely missed the reason for this proposal. But making every entity a CA seems like a lot of overhead.

the reasons are:

enabling x.509 certificates for legacy applications that require it
enabling automatic and self-issued certificate issuance using a verifiable mechanism
enabling a total scalability using the delegation pattern without loose of responsability or security

Thank you.
I still struggle to understand the use-case. I feel that I got invited in the middle of a conversation where I don't understand the problem at hand.
My understanding of the current situation is that we all want to use OpenID federation. When you use that, no certificates are needed. The trust in each entity certificate is provided by signed Entity Statements.
I'm not fully sure what you mean by "Legacy applications here". In the context of wallets I'm not sure what that is.
But if I would interpret that as an application that is not using OpenID federation, and expects a certificate to represent an entity that they can validate using Trusted List instead, then my thinking applies.
An application that is not using OpenID federation will have a hard time validating chains according to your proposal, and it creates a huge number of entities that have to be acting as a CA.
This makes me believe that your use-case is something else. If you elaborate, then perhaps I can provide more relevant thoughts.


feat: create InputDatePicker component

Checklist before requesting a review

[x] Working on iOS
[x] Working on Android
[x] Integration tests added
[x] Visual regressions screenshots are up to date
[ ] Design validated

Thanks @kimak ! Sorry for my late reply on this.
Reviewed! Both iOS and Android are working well. 😊✨

Can we please update the blue colors on both iOS and Android to match our Bluko brand color?
Bluko-500: #2D50E6

Just so I better understand... Are we using a "library" for this? Will this mean we can stay aligned with the native behavior if the native picker on iOS/Android changes?

Thanks @kimak ! Sorry for my late reply on this. Reviewed! Both iOS and Android are working well. 😊✨

Can we please update the blue colors on both iOS and Android to match our Bluko brand color?
Bluko-500: #2D50E6

I updated it for iOS here: https://github.com/GetLuko/streamline/pull/85#discussion_r1228115074
On Android, I'm limited with expo the solution we use here for the sandbox
https://expo.canny.io/feature-requests/p/customize-android-apptheme
But it will be good once integrated with the final app:

Just so I better understand... Are we using a "library" for this? Will this mean we can stay aligned with the native behavior if the native picker on iOS/Android changes?

Yes, it's a react-native library https://github.com/react-native-datetimepicker/datetimepicker using Native implementation.
It will be retro compatible with new OS versions. With that being said, sometime we still need update the lib to be up to date with the latest OS (last time was iOS 14 for example).

Thanks for the clarity! Sounds good. 👍


Resurface CassandraTask error messages in the Failed condition

What is missing?
When a CassandraTask fails, we don't have any information in the CassandraTask status to make it easier to understand the core issue. This then requires to go through the cass-operator logs in search of the error message.
We'd need to update the Failed condition Message field with the error.
Why is this needed?
This would make investigation a lot easier without requiring to go through logs.

That information should be there, if there is a message to be set.
https://github.com/k8ssandra/cass-operator/blob/master/internal/controllers/control/cassandratask_controller.go#L375

I'm seeing cases where the task fails with an NPE reported in the cass-operator logs but no message in the Failed condition.
Let's investigate a bit more, I'll come up with a way to reproduce this.

Here's a sample status from a failed CassandraTask:
status:
  completionTime: '2024-01-23T07:59:44Z'
  conditions:
    - lastTransitionTime: '2024-01-23T07:59:44Z'
      message: ''
      reason: Running
      status: 'False'
      type: Running
    - lastTransitionTime: '2024-01-23T07:59:44Z'
      message: ''
      reason: Complete
      status: 'True'
      type: Complete
    - lastTransitionTime: '2024-01-23T07:59:44Z'
      message: ''
      reason: Failed
      status: 'True'
      type: Failed
  failed: 1
  startTime: '2024-01-23T07:59:43Z'
``

And here's the error in the cass-operator logs:

2024-01-23T09:32:42.286Z	ERROR	Job failed to successfully complete the task	... {"error": "task failed: java.lang.IllegalArgumentException: Keyspace ALL does not exist"}
github.com/k8ssandra/cass-operator/internal/controllers/control.(*CassandraTaskReconciler).reconcileEveryPodTask
/workspace/internal/controllers/control/cassandratask_controller.go:660
github.com/k8ssandra/cass-operator/internal/controllers/control.(*CassandraTaskReconciler).Reconcile
/workspace/internal/controllers/control/cassandratask_controller.go:339
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:122
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:323
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:274
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:235

Only way to return a message in this case is to stop the task execution also when a non-retry event happens. What happens here is that we might get that error on the first pod, but currently we then move on to the next pod to try the same task again - so writing that error message from the first pod didn't make sense.


Production server is not using custom 500 error pages

For example:
https://cantusdatabase.org/source/620437/chants/?folio=104

I believe that the changes that were made in #1530 should be applied to the cantusdb.conf file on the production server instead of cantusdb.conf.development.

We should also probably have the cantusdb.conf file stored on the DDMAL wiki resources page.

Nvm, they're on the ansible github page.


Optimize .idea/icon.png, add sandbox/.idea/* to gitignore

I've optimized the logo via https://tinypng.com/ and added sandbox/.idea/* to gitignore

think you need to commit with sign-off


Unref cache from RangeManager at finalization

Required (only!) to prevent pebble crashing the program when it finalizes due to a cache
having a positive reference count.
Why go further into the finalization hole?  There is no real choice.  An alternative would
be to add a Close() method to RangeManager, then add such a method everywhere that holds
a RangeManager, all the way up the stack.
Fixes #1349: with this patched in, go test -v --count 1 github.com/treeverse/lakefs/api/... passes (without --race...).

Codecov Report

Merging #1352 (4d234ac) into master (5da68d0) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   46.87%   46.57%   -0.31%
==========================================
  Files         201      201
  Lines       15700    15881     +181
==========================================
+ Hits         7360     7397      +37
- Misses       7366     7505     +139
- Partials      974      979       +5

Impacted Files
Coverage Δ

graveler/sstable/range_manager.go
31.34% <0.00%> (-0.97%)
:arrow_down:

catalog/mvcc/cataloger_create_repository.go
59.25% <0.00%> (-3.71%)
:arrow_down:

api/api_controller.go
38.01% <0.00%> (-2.04%)
:arrow_down:

catalog/mvcc/cataloger.go
68.34% <0.00%> (-2.03%)
:arrow_down:

api/client.go
2.95% <0.00%> (-0.23%)
:arrow_down:

graveler/graveler.go
35.55% <0.00%> (-0.08%)
:arrow_down:

auth/setup.go
0.00% <0.00%> (ø)

pyramid/tier_fs.go
58.77% <0.00%> (+1.75%)
:arrow_up:

catalog/rocks/entry_catalog.go
16.73% <0.00%> (+1.77%)
:arrow_up:

catalog/rocks/cataloger.go
26.35% <0.00%> (+2.81%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da68d0...4d234ac. Read the comment docs.

Codecov Report

Merging #1352 (4d234ac) into master (5da68d0) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   46.87%   46.57%   -0.31%
==========================================
  Files         201      201
  Lines       15700    15881     +181
==========================================
+ Hits         7360     7397      +37
- Misses       7366     7505     +139
- Partials      974      979       +5

Impacted Files
Coverage Δ

graveler/sstable/range_manager.go
31.34% <0.00%> (-0.97%)
:arrow_down:

catalog/mvcc/cataloger_create_repository.go
59.25% <0.00%> (-3.71%)
:arrow_down:

api/api_controller.go
38.01% <0.00%> (-2.04%)
:arrow_down:

catalog/mvcc/cataloger.go
68.34% <0.00%> (-2.03%)
:arrow_down:

api/client.go
2.95% <0.00%> (-0.23%)
:arrow_down:

graveler/graveler.go
35.55% <0.00%> (-0.08%)
:arrow_down:

auth/setup.go
0.00% <0.00%> (ø)

pyramid/tier_fs.go
58.77% <0.00%> (+1.75%)
:arrow_up:

catalog/rocks/entry_catalog.go
16.73% <0.00%> (+1.77%)
:arrow_up:

catalog/rocks/cataloger.go
26.35% <0.00%> (+2.81%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da68d0...4d234ac. Read the comment docs.

It's my bad - we've experienced it before. When we discussed that in the previous PR I didn't find evidence in Pebble's code to the panic scenario and assumed it was fixed in the current version - sorry.

I did brush it off as a bug.  What I should have said is "this is a bug in the pebble SSTable implementation when used outside of CockroachDB".

Small suggestion (probably not fixable in this PR): Move cache init up and propagate it all the way down, then you can defer the Unref and avoid finalizers..

This is the "destructors" solution, only we make it the caller's responsibility.  To make this work you would need to construct the pebble Cache very high up and not Ref the cache inside the RangeManager.  But there are already currently 4 calls to create this manager, would need to push each one up.  Now e.g. NewEntryCatalog is called from 3 places, 2 commands (which can deref immediately) and the other in NewCataloger.  Now it seems we're good, because NewCataloger is going away.  Unfortunately we shall still need to BuildCataloger, even if not in a factory... and there are 10 calls to that.  So explicit destruction would have to happen in 14 places, all of them far away from RangeManager construction.  This is hard and nonscalable.
Destructors rule.

It's my bad - we've experienced it before. When we discussed that in the previous PR I didn't find evidence in Pebble's code to the panic scenario and assumed it was fixed in the current version - sorry.

I did brush it off as a bug.  What I should have said is "this is a bug in the pebble SSTable implementation when used outside of CockroachDB".

Small suggestion (probably not fixable in this PR): Move cache init up and propagate it all the way down, then you can defer the Unref and avoid finalizers..

This is the "destructors" solution, only we make it the caller's responsibility.  To make this work you would need to construct the pebble Cache very high up and not Ref the cache inside the RangeManager.  But there are already currently 4 calls to create this manager, would need to push each one up.  Now e.g. NewEntryCatalog is called from 3 places, 2 commands (which can deref immediately) and the other in NewCataloger.  Now it seems we're good, because NewCataloger is going away.  Unfortunately we shall still need to BuildCataloger, even if not in a factory... and there are 10 calls to that.  So explicit destruction would have to happen in 14 places, all of them far away from RangeManager construction.  This is hard and nonscalable.
Destructors rule.

Thanks!
@ozkatz I'm pulling so you can rebase onto master and see that it helps.  I do want your review, so please do review and I shall reply and change after-the-fact in a separate PR.

Thanks!
@ozkatz I'm pulling so you can rebase onto master and see that it helps.  I do want your review, so please do review and I shall reply and change after-the-fact in a separate PR.

Thanks @arielshaqed! It indeed solves my issue (rebased mvcc removal on master).

Thanks @arielshaqed! It indeed solves my issue (rebased mvcc removal on master).


ci: remove review_secrets job

:tada: This PR is included in version 4.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: