Change in Dockerfile

Inside Container mesher was not able to find mesher.yaml. ( https://github.com/go-mesh/mesher/issues/24 )

Pull Request Test Coverage Report for Build 75

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 38.545%

Files with Coverage Reduction
New Missed Lines
%

adminapi/router.go
3
25.93%

protocol/dubbo/dubbo/respond.go
3
37.74%

Totals

Change from base Build 71:
-0.02%

Covered Lines:
927

Relevant Lines:
2405

💛  - Coveralls


rspec-puppet needs means to exclude fixtures path from coverage report

As a developer, when I look at a coverage report I want to see metrics for the system under test, and should be able to conveniently configure a Rakefile task to exclude the fixtures/ path from the coverage metrics.

Looking for clarification: is the Rakefile setup excluding fixtures in https://github.com/rodjek/rspec-puppet/blob/master/lib/rspec-puppet/setup.rb#L146 not enough?

DavidS: that is correct.  I am using that logic, but to no avail.
Rakefile currently looks like this:
require 'rake'
require 'rspec/core/rake_task'
require 'puppet-lint'
require 'puppet-lint/tasks/puppet-lint'
require 'puppet-syntax/tasks/puppet-syntax'

exclude_paths = [
  "fixtures/etc/puppet/modules/apt/manifests/conf.pp",
  "/Users/escoh/sandbox/my_project/fixtures/etc/puppet/modules/**/*",
  "fixtures/etc/puppet/modules/**/*",
  "fixtures/**/*",
  "vendor/**/*",
  "spec/**/*",
  "pkg/**/*",
  "spec/fixtures/modules/**/*",
]

PuppetSyntax.exclude_paths = exclude_paths

desc "Run all RSpec code examples"
RSpec::Core::RakeTask.new(:rspec) do |t|
  t.rspec_opts = File.read("spec/spec.opts").chomp || ""
end

SPEC_SUITES = (Dir.entries('spec') - ['.', '..','fixtures']).select {|e| File.directory? "spec/#{e}" }
namespace :coverage do
  task :coverage do
    spec_file = 'spec/classes/coverage_spec.rb'
    fh = File.open( spec_file, 'w' )
    fh.write('at_exit { RSpec::Puppet::Coverage.report! }')
    SPEC_SUITES.each do |suite|
      desc "Run #{suite} RSpec code examples"
      RSpec::Core::RakeTask.new(suite) do |t|
        t.pattern = "spec/#{suite}/**/*_spec.rb"
        # t.rspec_opts = '--exclude "spec,fixtures/*"'
        # t.rcov_opts =  %q[--exclude "spec,fixtures/*"]
        t.rspec_opts = File.read("spec/spec.opts").chomp || ""
      end
    end
    # fh.truncate( 0 )
    fh.close
    task :default => :coverage
  end
end

namespace :rspec do
  SPEC_SUITES.each do |suite|
    desc "Run #{suite} RSpec code examples"
    RSpec::Core::RakeTask.new(suite) do |t|
      t.pattern = "spec/#{suite}/**/*_spec.rb"
      t.exclude_pattern = "**/coverage_spec.rb"
      t.rspec_opts = File.read("spec/spec.opts").chomp || ""
    end
  end
end
task :default => :rspec

namespace :lint do
  PuppetLint.configuration.ignore_paths = exclude_paths
  PuppetLint.configuration.send('disable_80chars')
  # PuppetLint.configuration.send('disable_autoloader_layout')
  begin
    if Gem::Specification::find_by_name('puppet-lint')
      require 'puppet-lint/tasks/puppet-lint'
      task :default => [:lint]
    end
  rescue Gem::LoadError
  end
end

Any progress on this? @hesco: did you find a workaround? Kind of invalidates coverage altogether.


Removal or migration of page into existing configure-server-endpoints.md

The majority of the info on this page is a repetition of the information on the page configure-server-endpoints.md (titled "Onboard Windows servers to the Microsoft Defender for Endpoint service").
It seems it would be better to migrate the little content that's unique on this page, into the above mentioned, to simplify the content.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4166ff18-3b2f-8df5-1c9a-5746add8180b
Version Independent ID: 4166ff18-3b2f-8df5-1c9a-5746add8180b
Content: Defender for Endpoint onboarding Windows Server
Content Source: microsoft-365/security/defender-endpoint/onboard-windows-server.md
Service: microsoft-365-security
Sub-service: mde
GitHub Login: @siosulli
Microsoft Alias: siosulli

Hi @baardhermansen and @yogkumgit
As there is a plan to refresh the onboarding content in the near future this is really helpful information.
I will make sure this included as part of the documentation refresh.
Thanks,
Sinead

@siosulli Thank you very much for sharing this information. @baardhermansen Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


feat: now only allowing parent methods to be used in desc

:tada: This PR is included in version 1.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Graph Runtime] Add get_output_name

We have a use case where we would like to ship the pre winograd transform weights (for the sake of smaller model size) and then run them through the pregraph to get the transformed weights at runtime. The get_output_name function is needed to allow us to execute the extracted pregraph at runtime. The client code looks like this:
// load pregraph_module
// load run_module

// set input for pregraph_module

// run pregraph
pregraph_module_->run();

// set weights for run module
for (int i = 0; i < static_cast<int>(pregraph_module_->get_num_outputs()); i++) {
  run_module_->set_input(
      pregraph_module_->get_output_name(i), pregraph_module_->get_output(i));
}

// set input for the run module

// run graph
run_module_->run();

@tqchen, @siju-samuel, @ajtulloch, please review

I'd note this is similar to existing work in neo-ai/tvm, specifically e.g. https://github.com/neo-ai/tvm/commit/9fb28a6c246352faf9e1cc8138c8a5fd1987a51a (cc @zhiics, @yidawang).

@ajtulloch Thanks for reference. Yeah, I was also trying to differentiate the input and weight nodes during the runtime. To be honest, it might be a little hacky there.

@zziics, our intent here is not to differentiate input and weight nodes. It's more about enabling shipping pre transformed weights to minimize model size.

#2770 to support metadata information in graph json.

close by #2770


Generic Thermostat

Home Assistant release (hass --version):
Fresh hass.io - 0.57.1
Pi 3
Python release (python3 --version):
Fresh hass.io
Component/platform:
Generic Thermostat with latest parameters
Description of problem:
Changing the temperature in the thermostat panel will not send and update data to system/frontend.
Worked fine with 0.56
Expected:
Taget temerature to change.
Problem-relevant configuration.yaml entries and steps to reproduce:

Probably related:
https://github.com/home-assistant/home-assistant/issues/10361

Same problem with EQ3 Bluetooth Smart Thermostats (v 57.1)
Marek

Fixed by https://github.com/home-assistant/home-assistant-polymer/pull/570.
Released in 0.57.2.


Thank you

Thank you for making this. Other examples were old, out of date, or just plain didn't work. This solved a problem I've been experiencing for over a week with building for production. Appreciate this a ton!

I need to still comb through the dependencies again and do another round of updates, but nothing is severe.


Fix #2023

table.FeatureVariations.FeatureVariationRecord might not exist in some cases.

fixed on master, thanks


Removed enabling of EVSE on startup

Describe your changes
Removed automatic enabling of evse on startup.
This change is required because otherwise a previously communicated Inoperative state could be overriden. The charger is enabled by default, so there is no reason the call enable on startup.
Issue ticket number and link
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[x] I read the contribution documentation and made sure that my changes meet its requirements

We need to check if it confuses the API module as it may get stuck in state::unknown for example

We need to check if it confuses the API module as it may get stuck in state::unknown for example

Instead of removing the line we could publish either
signal_simple_event(types::evse_manager::SessionEventEnum::Enabled);
or
signal_simple_event(types::evse_manager::SessionEventEnum::Disabled);
depending on the state. OCPP / OCPP201 have already called call_enable or call_disable based on the persisted state.

That would be cleaner as some modules may require an initial sync of state

That would be cleaner as some modules may require an initial sync of state

Added it, ready for review


support relative XARGO_RUST_SRC

We need to canonicalize the path because we change working directory before using it.

bors r+

Network failure.
bors retry


getvalueforname() fails for some names if claims do not exist

Below error occurs when calling getvalueforname() for certain names that do not have any claims (but not all names). For example, getvalueforname("test") will return an empty dictionary but getvalueforname("testx") will return below exception.
Is most likely related to https://github.com/lbryio/lbryum-server/pull/8
File "/home/meepo/Documents/lbry/lbryum/gui/qt/console.py", line 245, in keyPressEvent
self.runCommand()
File "/home/meepo/Documents/lbry/lbryum/gui/qt/console.py", line 215, in runCommand
result = eval(command, self.namespace, self.namespace)
File "", line 1, in
File "/home/meepo/Documents/lbry/lbryum/gui/qt/main_window.py", line 1807, in
return lambda *args: apply( f, (method, args, self.password_dialog ))
File "/home/meepo/Documents/lbry/lbryum/lib/commands.py", line 94, in _run
result = f(*args)
File "/home/meepo/Documents/lbry/lbryum/lib/commands.py", line 73, in func_wrapper
return func(*args, **kwargs)
File "/home/meepo/Documents/lbry/lbryum/lib/commands.py", line 704, in getvalueforname
response = self.network.synchronous_get(('blockchain.claimtrie.getvalue', [name, blockhash]))
File "/home/meepo/Documents/lbry/lbryum/lib/network.py", line 827, in synchronous_get
raise BaseException(r.get('error'))
BaseException: list index out of range

Closing, as this was due to the lbryum-server not being updated with the latest patches


Pointer/Touch events not working

I'm trying to do a simple touch / click at first, but it seems that the events are not fired. I also tried on mobile, and sometimes it fired an alert for the onDown function, but not always.
this._kontra.card = kontra.sprite({
	x: 0,
	y: 0,
	image: KontraSprites.card,
	width: this.width,
	height: this.height,
	onDown: function() {
		console.log("down");
	},
	onUp: function() {
		console.log("up");
	},
	onOver: function() {
		console.log("over");
	}
});

kontra.pointer.track(this._kontra.card);

And I have a really simple gameLoop:
kontra._loop = kontra.gameLoop({
	update: function() {
		sprite.update();
		for(var i in KontraPOOL){
			KontraPOOL[i].update();
		}
	},
	render: function() {
		sprite.render();
		for(var i in KontraPOOL){
			KontraPOOL[i].render();
		}
	}
});

kontra._loop.start();

Any ideas why the events for the pointer won't fire? Am i missing something?
Thanks

Ah right. I almost forgot I had a bug I needed to fix in the pointer code. I forgot to account for canvas offset and scale.
I wrote the fix in my js13k game but need to transfer it over. Thanks for the reminder.

Hmm, yeah that makes sense :) I didn't even realize that i was on a scaled canvas until you said it.

I forked the repo and added your fix for scaling and offset, but after that i found out that i wasn't waiting for the images to load, and when i created the sprites, they had 0 width and height, the image was showing correctly, but when checking for input it couldn't create a bounding box.
Now i'm waiting for the images to load, and after that i create the sprites and everything is working correctly.

Awesome, glad it's working.


Help me! The type or namespace name 'Platform' does not exist in the namespace 'Microsoft.Maui.Graphics'

The type or namespace name 'Platform' does not exist in the namespace 'Microsoft.Maui.Graphics'
pls i cannot find Platform Class when build MAUI windows app
code :
public void Draw(ICanvas canvas, RectF dirtyRect)
{
// Drawing code goes here
    IImage image;
    Assembly assembly = GetType().GetTypeInfo().Assembly;
    using (Stream stream = assembly.GetManifestResourceStream("MemeCreator.Resources.Images.dotnet_bot.svg"))
    {
        image = PlatformImage.FromStream(stream); // error here

    }

    if (image != null)
    {
        IImage newImage = image.Resize(100, 60, ResizeMode.Stretch, true);
        canvas.DrawImage(newImage, 10, 10, newImage.Width, newImage.Height);
    }
}

@leNam199320xx See
https://github.com/dotnet/Microsoft.Maui.Graphics/blob/26443e13721a8983ea8ad2cf0c663192b05b6a2c/src/Microsoft.Maui.Graphics/PlatformImage.cs#L1-L15

Platform is Android version. I reported the issue with the documentation like 2 months ago but last 6 months all updates on MAUI Graphics have been just package version updates.


Fix broken links to values.yaml in README.md

Description
Fix some URLs in the documentation.
I agree with "Commits are signed per the DCO using --signoff"
Issues Resolved
Some links to values.yaml was broken.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hi @gdm can you also confirm in the description that you are agreeing with     Commits are signed per the DCO using --signoff
Thanks.

You also need to use -s to sign your commit to pass DCO checks. Thanks.

You also need to use -s to sign your commit to pass DCO checks. Thanks.

Thanks for reviewing, I'll make another PR with '-s' option.

You also need to use -s to sign your commit to pass DCO checks. Thanks.

Thanks for reviewing, I'll make another PR with '-s' option.

 Looks like not all your commits are signed

Sorry, I've created another PR https://github.com/opensearch-project/helm-charts/pull/139  hope its better now.


Better error handling for references in add_basis

Codecov Report

Merging #149 (d0ed6c0) into master (498f022) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@bennybp tests green, ready to merge


The non-build jobs belong in the short queue

Sigh, django-rq-scheduler is not honoring this though.

Is this something we want on MetaShare and/or project-template as well?

We definitely need short-running maintenance jobs to be in a different queue from long-running builds, whether that's done like this (which relies on the fact that all of MetaDeploy's repeatable jobs are in that category) or by fixing django-rq-scheduler to actually honor the queue named on the RepeatableJob model.


Better than getting an error


rewrite annotate_bed.sh

When annotating bed it would be better to have a check that no regions of the bed file are missed (i.e don't have 100% intersect with exons_nirvana => missed from output), probably easier to rewrite in python and use to pybedtools package to still do the intersecting.
Also make the minimum intersect an optional input.

retrieving transcript file for analysis with ensembl: https://www.biostars.org/p/93011/
generates bed file with: chr, start, end, gene symbol, tx, exon number, strand

also need to handle mismatches in chr prefixes in all input files (mosdepth coverage bed, input bed, exons/tx file etc.), strip them all would be best


Fix typo in get_lookup

Trivial, but it breaks a compatible lookup.

Wow, how didn't we notice this ;) thanks!


render: add rbac rules for proxy/logs from apiserver

This fixes (together with the correct empty kubelet CA in the apiserver config) the use of kubectl logs.

/lgtm


[3.x] Determining +json or +xml in abstract handler

Why are +json and +xml content types converted to known content types in AbstractHandler.php?
The problem is that this does not follow JSON:API Specifications which require application/vnd.api+json content type.
Is there specific reason for that conversion?

This is only used by the error handling. It's to ensure that Slim sends back JSON when the client's Accept header indicates that it's expecting JSON.

On 3 Nov 2018, at 19:20, Filip Š<EMAIL_ADDRESS>wrote:
Why are +json and +xml content types converted to known content types in AbstractHandler.php?
The problem is that this does not follow JSON:API Specifications which require application/vnd.api+json content type.
Is there specific reason for that conversion?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

What can I do if I want that unhanded errors will be send using application/vnd.api+json content type?
I don't want that all responses are JSON because I also want to support other formats. So I want to send same content type as request, but format depending on type.

Replace the Error Handler with your own one.

On 4 Nov 2018, at 03:47, Filip Š<EMAIL_ADDRESS>wrote:
What can I do if I want that unhanded errors will be send using application/vnd.api+json content type?
I don't want that all responses are JSON because I also want to support other formats. So I want to send same content type as request, but format depending on type.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Ok. Thank you.


Make CI even better round 2

[ ] Are the integration tests being run in parallel?
[ ] Can we express things like lint fmt and test as build-time tasks rather than things that run within a docker container?
[ ] Crypto in the release build seems way faster than debug, can we use this at test time? Can we measure the difference?

Android runs 4 compilations of core in serial, perhaps we could use something like this to do this in parallel.

It may block the build directory though

Server, CLI, and Linux need to have double dummy rs'
Android does not need to do any rust stuff
All the integration tests need to depend on server and core being built
All the integration test clients should use core as a starting point for their docker image
Lint, Test, and other operations that aren't integration tests should be dockerfile build time command


Scroll issue

Hi,
First of all, great project. I was searching a good way to document my project, I was trying Flatdoc and others alternatives but none like this one, so professional an complete form my requirements. Keep the good work. :+1:
I am seeing a problem with scroll. There are two frames to me, the left frame where is all the tree documentation structure and the right frame where there is the content. If I scroll first the left frame, then I scroll the right frame, the left frame automatically scroll up to the top.
So If my documentation is long and maybe I am at the final is a little not useful scrolling down the left panel every time you scroll the right panel.
I am using Firefox 29.0.1 and not tested on other browsers.
Regards

Closing because we'll soon be moving away from Tocify in v2, so this won't be a problem!


Crash while loading world

When I start Terraria-Clone and I click on "Load World" the program crashes and it gives me this error:
Exception in thread "LWJGL Application" java.lang.ArrayIndexOutOfBoundsException: 11
at com.jmr.terraria.game.io.WorldIO.loadChunk(WorldIO.java:165)
at com.jmr.terraria.game.io.WorldIO.loadWorld(WorldIO.java:68)
at com.jmr.terraria.game.world.World.(World.java:57)
at com.jmr.terraria.game.views.screen.GameScreen.(GameScreen.java:24)
at com.jmr.terraria.game.views.screen.MainScreen.update(MainScreen.java:35)
at com.jmr.terraria.PhysicsGame.render(PhysicsGame.java:118)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:207)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:114)
I'm not sure if loading worlds is already supported. So sorry if it isn't.

The world IO is implemented, but I have not ran into this error. In the save file, the blocks are saved by their ID and then retrieved by it. The way that I have it is that the ID is expected to match the index in the array that the block type is saved. The reason that this crashes is because the last statement is not true, the ID's don't match the index where the block type is kept. I have changed the code to find the block type by their ID rather than the index in the array. Pull down the newest code to receive this update. Thank you for submitting the error!


Change name of main branch

@aloctavodia and @yilinxia I'd like to change the main branch name to main. If there are no objections, then I'll make the change.

Thank you Andy for the suggestion! I dont mind at all :)

Good idea!

@aloctavodia you will need to change the current default branch to the newly created main branch. You can do so by following step 4 and 5 on this site
https://stevenmortimer.com/5-steps-to-change-github-default-branch-from-master-to-main/
I would do it, but I don't have those privileges. Thanks for the change.

github has a rename branch feature, I can use that too if you don't mind

sure, I didn't realize it had that feature. That's super

Done, now I see this message:

with commands:
git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

I assume you will see the same message but posting anyway just in case.

Awesome, thanks again everyone.
Closing the issue, but it will still be around if anyone needs to reference it.


Data corruption upon packet loss recovery

@jlaine  I have been looking again at the failure seen in the interop runner -- logs here. These failure seems to happen regularly during the "cross traffic" tests between aiortc client and picoquic server.
The downloaded file differs from the reference file. I compared the two files, and I find the following:

The two files have the same length, but the contents differ after offset 19238721
After that point, all the bytes in the downloaded file appear different from the reference file
The data at offset 19238721 was transmitted in packet number 13821, which was correctly received at T=19817.26
However, the packet 13820 before that was lost.
The content of 13820 was re-transmitted later, split in two packets
Packet 13860, received at T=19855.18 contains 1397 bytes of data from offset= 19237315
Packet 13861, received at T= 19856.3 contains 9 bytes of data from offset=19238712

It appears that something got wrong on the client after receiving these corrected bytes, leading to receiving a corrupted file.
Maybe you want to fix that...

Hi @huitema, I'm progressively trying to get back afloat on my various opensource projects, so sorry for not answering sooner.
Thanks for taking the time to dive into the problem, this definitely sounds like something that needs fixing.
The lgos have unfortunately expired meanwhile, I'll try looking for similar errors in more recent logs.

@huitema to the best of my knowledge this is now fixed


List clients with their capabilities and support level

according to kubernetes client guidelines we need to host a page listing clients, including their stability and capability level from the above lists.

The client is listed here: https://github.com/kubernetes-client/community/blob/master/clients.md


[iOS] Test Implementation of grab orders

Make sure the implementation of grab orders is working and fix the possibles issues.

This is blocked because TIKI Receipt Capacitor is not building due to an error in TIKI SDK Capacitor (see. https://github.com/tiki/tiki-sdk-capacitor/issues/68.

#199 duplicate


Current restivus build causes crash on "Restivus.configure"

Looks like this line causes meteor to crash when calling Restivus.configure() and config.apiPath isn't defined.
Can be fixed by adding existence checks :
  if config.apiPath?[0] is '/'
    config.apiPath = config.apiPath.slice 1
  if config.apiPath?[-1] isnt '/'
    config.apiPath = config.apiPath + '/'

Good catch! Sorry about that. Your suggestion would fix the error, but the intended behavior is that the default apiPath ('api/') be used in that case. To fix that, I needed to copy all the properties from config to this.config (for some crazy reason I was doing that immediately after trying to normalize the base api path instead of before, where it belonged), and then use this.config.apiPath instead of config.apiPath during the normalization. Again, sorry if that caused you any headache. I'll have the fix pushed and published very soon. I'll let you know once it's all set.

Sweet, thanks!
btw, Great work on Restivus, just what I needed.

Just published v0.5.4 with the fix. You should be able to grab it with > meteor update restivus. Thanks again for reporting it! And thanks for the compliment! It makes me warm and fuzzy inside that Restivus has been helpful to you. This is my first project that anyone besides myself has actually used, so this is all very awesome for me.


Linter Toggle fails to remove bubble gutter on left

When first opening a file from the tree view, the linter is invoked (say, rubocop on a foo.rb file) and a gutter is added to the left hand side of the content window. If you then use linter toggle to try to dismiss it, the panel is hidden but the gutter with the line 'bubbles' remains. You can toggle linter on and then off again and the gutter will get removed, it just never works the first time, in my experience.

I am unable to repro this on the latest version of linter and Atom
Can you please provide some way to repro this?

Mac OS X 10.10.5, Atom 1.1.10, Linter 1.10.0, Linter-RuboCop 0.4.4, Ruby 2.1.4, Rucocop 0.34.2  (parser/ruby21, 2.1.7-compliant syntax)
Steps:
Close all open files
Open a Ruby file
Toggle Linter
Gutter Remains < BUG
Toggle Linter
Toggle Linter
Gutter Removed < Expected Behavior

I was able to repro this and have fixed in the UI improvements branch

😎


Support golangci-lint to improve code quality

The golangci-lint is the great Go linter. We should:

Use golangci-lint and add the unified .golangci.yml file to make consistent behavior in CI and local testing;
Add the lint target in Makefile;
Use the same .golangci.yml in CI;

Is this to solve the workflow problem and what verification needs to be added?

@sjcsjc123 Glad to see your interest! I have modified the issue description and hope it can help your understanding. Adding the .golang.ci.yml is the very important thing in Go ecosystem.

i can try this

@sjcsjc123 Are you still working on that? Sorry for missing the message, and I already created the related PR about the issue. If you are interested, you can review the PR.

No problem! I only added some content to the Makefile, which is not important.


Require async functions to be called with the await keyword

Hi, I'm not sure what I'm looking for is even possible.
I often find myself in this situation :
async function foo() {
	// does some stuff
}

async function bar() {
	foo()
}

I have created an async function foo and I'm calling it some place else but I forgot the await keyword in front 😱 My code becomes very unpredictable and the issues I face don't help me in any way to identify where is the missing await.
After some time scanning my code, I finally find the culprit, and correct it:
async function foo() {
	// does some stuff
}

async function bar() {
-	foo()
+   await foo()
}

To be clear, this rule is different from require-await : the following code is not marked as invalid by the require-await rule :
async function foo() {}

async function bar() {
	await foo()
	foo()
}

Is it even possible for eslint to identify async function calls that are not awaited ?

@aymericbouzy   wrong project. you might wanna look here: https://github.com/eslint/eslint . babel-eslint is the underlaying "engine" (parser) of eslint.
that being said, I don't think it is possible for a variety of reasons. your "awaited" function could be an async function, or just a Promise returning function. In any case, it might be just passing through to the next function, without the Promise resolution, or you wanna assign it to a variable, and pass it elsewhere. there's no way to know what you are planning to do with the Promise.
you might wanna check out: flow types. if you'd use that, flow could tell whazz up:
async function test(): Promise<number> {
  return 1;
}

(async () => {
  const a: number = test();
})()

const a: number = test();
                       ^ Cannot assign `test()` to `a` because `Promise` [1] is incompatible with number [2].
References:
1: async function test(): Promise<number> {
                          ^ [1]
6:   const a: number = test();
              ^ [2]

but that might be beyond your needs. just something to keep in mind.

Thanks for the detailed answer! In fact I've just found this being discussed in eslint here : https://github.com/eslint/eslint/issues/9787 sorry ...
Using flow will not help me if I'm not assigning the result to any variable, though ... But it will help me most of the time.
I agree javascript allows to do all sorts of things with promises, and you've given quite a few of them. But if I want to restrict myself to (almost) always awaiting promises (except when the value is immediately returned, or passed to Promise.all / Promise.race), it could be a nice rule to have, if only it could be implemented, and you've confirmed my thinking that it couldn't be done.


Make metrics collection configurable via table properties

This PR introduces MetricsConfig that allows us to control metrics collection and resolves #173.
Currently, this logic is integrated only into the Parquet write path.

@rdblue @vgankidi this what I had before we merged PR #254. It would be great to get preliminary feedback and align on whether truncation should be part of MetricsSpec or not.

@aokolnychyi, this looks great! I think we need to merge it with the changes from #254, but this is an awesome start!

@rdblue this one is ready for another review round.

@aokolnychyi, just a couple minor comments and this is ready to go. It also needs a rebase. Thanks!

Merged. Thanks for fixing this, @aokolnychyi!


Unity Versions

What version of Unity should we stick to?

:thinking: :thought_balloon: :question:


Document how to send log search data to splunk

@kimahoff - Could you merge this extra documentation & publish to docs.pivotal.io/logsearch for us please.
Its relevant to the existing v1.0.0 tile.
Thanks!

@mrdavidlaing @kimahoff Currently looking at this. Will build locally first to make sure everything looks good.

@ljarzynski Thanks!
FWIW; I think the screenshot images might be a bit big.

@MasslessParticle Ok, thanks. I can resize them.


Sync display in top left can't be seen (its to dark)

Current Behavior
Sync display status in top left can't be seen (its to dark)

Expected Behavior
it should be a lighter gray or white or some other color that is more readable.
Steps to Reproduce
No response
Version
0.1.0 Beta
What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?
Ubuntu 22.04, windows 10 chrome.
Anything else?
No response

Fixed by #141


Getting items description

How can I get an item’s HTML description?
It’s a live listing and I have its id.

This repository is deprecated, read the Readme and look to the examples of the new one


Delay Unit Test to give time to the component to setState and render

Current behavior
Code coverage shows that the state is being correctly updated (async) but the snapshot and the wrapper.state() call have the default values.
Expected behavior
The snapshot shows the correct layout and updated state.
Your environment
API

[X ] shallow

Version

library
version

Enzyme
3.2.0

React
16.0.0

Adapter

[X ] enzyme-adapter-react-16  (1.1.1)

Currently, I am setting the state in an async call. Basically, I check the network info and based on that, I update the state. The code coverage shows that the setState internally is being called and I can confirm that with some logging.
I saw that if you call the setState async you need to call wrapper.update or wrapper.instance().forceUpdate. None of those worked for me.
The only way the snapshot shows the correct layout, is if I call wrapper.setState manually, which is not the purpose of my tests.
After some logging, I realized that the setState internally is actually executing AFTER my Jest tests (based on the logs) so I wanted to know if there is a way to delay the jest unit test for some ms in order to test the fully rendered shallow component.
I tried this, but it seems to not be working:
jest.useFakeTimers()
        //wrapper.setState({basicLogin: true, isLoading: false});
        setTimeout(()=>{
            const spy = jest.spyOn(wrapper.instance(), "_toggle");
            expect(wrapper).toMatchSnapshot();
        }, 500);
        jest.runAllTimers();

No matter what I do, the state is always the default one at this stage.
Any input, appreciated. Thanks

How is this your bad?
With your solution, there is no guarantee that:

your test won't break in a future update of React
your test won't break with different combinations of micro/macro tasks.

@anilanar My bad because I didnt know you cuold do async in enzyme at that time.
The right way to do this right now it is to actually inject a promise as a dependency and return the test when that promise returns so that will execute in order.
I didnt have that knowledge when I wrote this

@sfratini Could you please write an example of what you say here:

The right way to do this right now it is to actually inject a promise as a dependency and return the test when that promise returns so that will execute in order.

@sfratini Could you please write an example of what you say here:

The right way to do this right now it is to actually inject a promise as a dependency and return the test when that promise returns so that will execute in order.

Yeah, I didnt explained myself very well. This is an example, for a code that needs to wait for a promise to resolve:

it("should return the image source of the icon", () => {
    expect.assertions(3);
    return icons.getSource("Entypo", "home").then(source => {
        expect(source).toBeDefined();
        expect(source).toHaveProperty("scale");
        expect(source).toHaveProperty("uri");
    });
});

Or you can create a promise and pass it to the component which is the way I usually prefer to test components, just passing the dependency:
    it("should catch a network info error", () => {
        const wrapper = shallow(<LoginComponent/>);
        let promise = Promise.reject(new Error("networkInfo"));
        NetInfo.getConnectionInfo = jest.fn(() => promise);
        return promise.catch(err => {
            expect(err.message).toContain("networkInfo")
        });
    })

Bottom line, you return a promise, and calculate the assertions after the promise is resolved, which guarantees the code executed.


change xvcvuxwdp and xvcvuxwsp

change xvcvuxwdp and xvcvuxwsp

vsx/convert instruction refactor is complete, four instructions failed the test in the round_to_int_xx2_xo.isa file.

vsx/convert remove annotations and useless codes


Revert excluded UTs due to https://github.com/oap-project/gluten/pull/4211

Backend
CH (ClickHouse)
Bug description
By https://github.com/oap-project/gluten/pull/4211 we excldue 4 tests:
    .exclude("except all")
    .exclude("exceptAll - nullability")
    .exclude("intersectAll")
    .exclude("intersectAll - nullability")

Or, especially, failed at the following check.
    // check null equality
    checkAnswer(
      nullInts.exceptAll(nullInts.filter("0 = 1")),
      nullInts)
    checkAnswer(
      nullInts.exceptAll(nullInts),
      Nil)

Those failed UTs are caused by https://github.com/ClickHouse/ClickHouse/pull/57872, it looks like a bug
Spark version
None
Spark configurations
No response
System information
No response
Relevant logs
see logs at here
[2023-12-28T03:22:27.382Z]   !== Correct Answer - 4 ==   == Gluten Answer - 4 ==
[2023-12-28T03:22:27.382Z]    struct<a:int>              struct<a:int>
[2023-12-28T03:22:27.382Z]    [1]                        [1]
[2023-12-28T03:22:27.382Z]    [2]                        [2]
[2023-12-28T03:22:27.382Z]    [3]                        [3]
[2023-12-28T03:22:27.382Z]   ![null]                     [3] (GlutenSQLTestsTrait.scala:141)
[2023-12-28T03:22:27.644Z] - exceptAll - nullability *** FAILED ***

失败的ut "except all",  可通过mvn test复现，但无法在thriftserver中复现。
CREATE TABLE nullInts (
  a INT
);

INSERT INTO nullInts (a)
VALUES
  (1),
  (2),
  (3),
  (NULL);

select * from nullInts
EXCEPT ALL
select * from nullInts where 0 = 1


Error when trying to open file with hdfs://ip:port/path

If I want to open a file with a path like hdfs://<IP_ADDRESS>:8020/tmp/test.txt i get an error.
The libhdfs3 seems to prolong the pathname to user/username/hdfs:://<IP_ADDRESS>:8020/tmp/test.txt which I guess it shouldn't do.
Full Error Message:
2015-06-18 00:43:00.575636, p39304, th140444680022112, ERROR Handle Exception: RpcHelper.h: 94: HdfsIOException: Unexpected exception: when unwrap the rpc remote exception "org.apache.hadoop.fs.InvalidPathException", Invalid path name /user/cloudera/hdfs:/<IP_ADDRESS>:8020/tmp/testfile00.txt
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFileInt(FSNamesystem.java:2470)
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFile(FSNamesystem.java:2431)
at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.create(NameNodeRpcServer.java:552)
at org.apache.hadoop.hdfs.server.namenode.AuthorizationProviderProxyClientProtocol.create(AuthorizationProviderProxyClientProtocol.java:108)
at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.create(ClientNamenodeProtocolServerSideTranslatorPB.java:388)
at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:587)
at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1026)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2013)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2009)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:415)
at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1642)
at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2007)
in /home/dm/libhdfs3-apache-rpc-9/src/server/NamenodeImpl.cpp: 111
@	Unknown
@	Hdfs::Internal::UnWrapper<Hdfs::HdfsIOException, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing>::unwrap(char const*, int)
@	Hdfs::Internal::UnWrapper<Hdfs::UnresolvedLinkException, Hdfs::HdfsIOException, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing>::unwrap(char const*, int)
@	Hdfs::Internal::UnWrapper<Hdfs::ParentNotDirectoryException, Hdfs::UnresolvedLinkException, Hdfs::HdfsIOException, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing>::unwrap(char const*, int)
@	Hdfs::Internal::UnWrapper<Hdfs::NSQuotaExceededException, Hdfs::ParentNotDirectoryException, Hdfs::UnresolvedLinkException, Hdfs::HdfsIOException, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing>::unwrap(char const*, int)
@	Hdfs::Internal::UnWrapper<Hdfs::FileNotFoundException, Hdfs::NSQuotaExceededException, Hdfs::ParentNotDirectoryException, Hdfs::UnresolvedLinkException, Hdfs::HdfsIOException, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing>::unwrap(char const*, int)
@	Hdfs::Internal::UnWrapper<Hdfs::FileAlreadyExistsException, Hdfs::FileNotFoundException, Hdfs::NSQuotaExceededException, Hdfs::ParentNotDirectoryException, Hdfs::UnresolvedLinkException, Hdfs::HdfsIOException, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing>::unwrap(char const*, int)
@	Hdfs::Internal::UnWrapper<Hdfs::DSQuotaExceededException, Hdfs::FileAlreadyExistsException, Hdfs::FileNotFoundException, Hdfs::NSQuotaExceededException, Hdfs::ParentNotDirectoryException, Hdfs::UnresolvedLinkException, Hdfs::HdfsIOException, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing>::unwrap(char const*, int)
@	Hdfs::Internal::UnWrapper<Hdfs::AlreadyBeingCreatedException, Hdfs::DSQuotaExceededException, Hdfs::FileAlreadyExistsException, Hdfs::FileNotFoundException, Hdfs::NSQuotaExceededException, Hdfs::ParentNotDirectoryException, Hdfs::UnresolvedLinkException, Hdfs::HdfsIOException, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing, Hdfs::Internal::Nothing>::unwrap(char const*, int)
@	Hdfs::Internal::NamenodeImpl::create(std::string const&, Hdfs::Permission const&, std::string const&, int, bool, short, long)
@	Hdfs::Internal::NamenodeProxy::create(std::string const&, Hdfs::Permission const&, std::string const&, int, bool, short, long)
@	Hdfs::Internal::FileSystemImpl::create(std::string const&, Hdfs::Permission const&, int, bool, short, long)
@	Hdfs::Internal::OutputStreamImpl::openInternal(std::shared_ptrHdfs::Internal::FileSystemInter, char const*, int, Hdfs::Permission const&, bool, int, long)
@	Hdfs::Internal::OutputStreamImpl::open(std::shared_ptrHdfs::Internal::FileSystemInter, char const*, int, Hdfs::Permission const&, bool, int, long)
@	Hdfs::OutputStream::open(Hdfs::FileSystem&, char const*, int, Hdfs::Permission, bool, int, long)
@	hdfsOpenFile
@	main
@	Unknown
@	Unknown
I searched for this behaviour and found something on snakebyte about it:
For operations: mv, test and tail - single_arg is used to carry hdfs
path, and there's no extra dirs for this operations thus CL parsing
method skipped single_args - in this commit make sure single_arg is
always included for this operations.
(Link: https://github.com/spotify/snakebite/issues/148)
Greetings Faladu

Hi Faladu
To open a file, the "path" pass to hdfsOpenFile() cannot be a URL, it should be a path (absolute path such as "/path/to/a/file" or a relative path such as "a/relative/path").

Hm any reason why it differs there from the normal libhdfs?
It is strange that the normal libhdfs provides the URLs as path / filename when you use hdfsListDirectory and also accepts them as name for the hdfsopen but the libhdfs3 which uses the same headerfile doesn't.
Any reason why the implementation differs at that point?

Hi Faladu
Good question.
We try to keep the same behaviors with libhdfs, but please consider this case.
User first create a filesystem and connect to cluster "hdfs://clusterA:9000" and then try to open a file on another cluster "hdfs://clusterB:9000/path/to/file", what will happen?
hdfsFS FS = hdfsConnect("clusterA", 9000);
hdfsFile file = hdfsOpenFile(FS, "hdfs://clusterB:9000/path/to/file", ...);  // what will happen?
Since FS is connected to clusterA but the "path" point to clusterB, this does not make sense. That is why we do not want to keep cluster info in "path", it will duplicate cluster info and make confusion.
It is true that we can improve libhdfs3's implementation to support pass a URI in hdfsOpenFile() and check if the cluster in URI is the same with the file system object passed by the user. Report error if they are not the same. You can consider it as an unimplemented feature and patch is welcomed.

Apologies for the very delayed response. The development team managing this codebase is also responsible for Apache HAWQ (incubating) and trying to get the first release out the door. As a result, this repo has been unintentionally neglected and recently turned read-only.
This code was birthed from HAWQ and will be merged back into into that project (now that it is open source as well); mailing lists, pull requests, issues and releases related to libhdfs3 will be there. The plan is to provide tarball releases of this code separate from the larger HAWQ project until it can be relocated into a dedicated repo again (down the road) - see HAWQ-1059.
Again, thank you for the contribution and patience while we sort out these logistics.
@faladu if this issue/feature is still useful, please respond.


3d cuts don't open back upon changing user settings

Changing user settings reload the windows, 3d cuts should open again if they were open before the change

Fixed here 0f5bf15


Peer-Code-Review-2022-03-01

Positive points 👍

The HTML structure is sound and very semantic 👍
HTML structure easy to read 👍
CSS styling is nicely structured 🤓
Smart positioning with Javascript in the DOM 🧐
Smart, making sure to wait for the loading of the DOM in order to select DOM elements.

Take into consideration 🖋

Maybe you could change the .display-none class selector to '.hide' or '.hidden' to keep the DRY (do not repeat yourself) code principle in practice.
const ListOfMenus should be lower camelcased. --> listOfMenus (convention)
Observation: Instead of using element.style = 'xxx:xxx;yyy:yyy' try looking at element.style.cssText = 'xxx:xxx;yyy:yyy'.
Maybe could refactor or try to make the same result with less code. 🙂

@hsztan 🧑🦱 @Juanse7793 Introducing the recommended changes.

Change display-non to hide 😵💫
Modify  the way to style elements of DOM within JS. here ✔
Refactor JS and use dynamic content loade for the recent work section: here ✔

Thank you guys for the perfect review. Can't wait to work with you again 👍 😄


[broker]Tidy up update subscribeRateLimiter

Motivation
Tidy up code to update subscribe rate-limiter
Modifications
Use updateSubscribeRateLimiter to update subscribe rate-limiter
Verifying this change

[x] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: ( no)
Anything that affects deployment: (no )

Documentation

[x] no-need-doc
(Please explain why)

LGTM

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@lhotari PTAL

@lhotari @codelipenghui PTAL

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

I find there is a race condition about subscribeRateLimiter. So I will close there PR and think a better solution. Thanks for all. @HQebupt @Jason918 @lhotari @codelipenghui


Implement tcollect functionality.

If we add this, it should probably also work for non-generators (e.g. even simple unit-ranges).

Thanks @RomeoV!


[Feature] Add users on MacOS Platform

I'm submitting a

[ ] bug fix
[X] feature
[ ] documentation addition

What is the current behaviour?
Adding users is not implemented on MacOS
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
What is the expected behavior?
Ability to add users to a MacOS system using comtrya
What is the motivation / use case for changing the behavior?
Feature parody with FreeBSD and Linux
Please tell us about your environment:
Version (comtrya --version): 0.8.3
Operating system: MacOS 13.1

Codecov Report
Base: 46.27% // Head: 45.48% // Decreases project coverage by -0.78% :warning:

Coverage data is based on head (f3b4287) compared to base (db12cde).
Patch coverage: 1.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   46.27%   45.48%   -0.79%
==========================================
  Files          79       81       +2
  Lines        2766     2836      +70
==========================================
+ Hits         1280     1290      +10
- Misses       1486     1546      +60

Impacted Files
Coverage Δ

app/src/commands/apply.rs
0.00% <0.00%> (ø)

app/src/commands/contexts.rs
0.00% <0.00%> (ø)

app/src/commands/version.rs
0.00% <0.00%> (ø)

app/src/main.rs
0.00% <0.00%> (ø)

lib/src/actions/user/providers/macos.rs
0.00% <0.00%> (ø)

lib/src/actions/user/providers/mod.rs
25.00% <0.00%> (-3.58%)
:arrow_down:

lib/src/manifests/load.rs
0.00% <0.00%> (ø)

lib/src/contexts/mod.rs
73.75% <50.00%> (ø)

lib/src/atoms/file/copy.rs
80.35% <100.00%> (+17.85%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Random Beacon v2 sortition pool locking

Depends on: #2671
Depends on: https://github.com/keep-network/sortition-pools/pull/132
The sortition pool should be locked upon group creation start and unlocked either during result approval or DKG timeout.

Ready for review. Keeping it draft until #2671 lands on main.

Is there a possibility we can make this PR not depending on #2671? The change looks pretty straightforward while the one from #2671 will require more work and I think there is no point in blocking this one. The merge shouldn't be that problematic I think.

Is there a possibility we can make this PR not depending on #2671? The change looks pretty straightforward while the one from #2671 will require more work and I think there is no point in blocking this one. The merge shouldn't be that problematic I think.

#2671 introduce real SP in relay tests so it was easier to stack this PR on top than implementing tests using the stub and then change to real pool.

@pdyraga Ready for another shot.

@pdyraga Everything addressed.


TFT Price pallet avg price calculation should be reviewed

currently, the avg price is stored every 10 blocks, meaning every minute. the avg is calculated based on all the values in the list / the length of the list. If this runs for months/years, the list will be very huge and avg calculation will be very costly and inneficient.
I propose we make the price history map a ringbuffer of maximum 1440 elements (1 day of data). And calculate avg on this daily history.

Pff, I don't get the storing of the price every block, every 10 blocks seems sufficient.

We store the price every block for a use case where the latest price needs to be fetched.

Calculating a normal average over all historic points also does not make sense, 1440 for the average over the last day is a better indication of the price.

This is what I am suggestion right?


[BUG] Stream client Feed#followers returning HTTParty object not array

I am having this weird issue I can only reproduce on an app deployed with Heroku.
I am calling the Stream::Feed#followers and Stream::Feed#following methods, but they return an HTTParty object instead of an array as it does on my local machine.
E.g.:
irb(main):002:0> STREAM_CLIENT.feed("user", "139052").following
=> #<HTTParty::Response:0x7f05820da1b8 parsed_response={"duration"=>"12ms", "results"=>[]}, @response=#<Net::HTTPOK 200 OK readbody=true>, @headers={"allow"=>["GET, POST, HEAD, OPTIONS"], "cache-control"=>["max-age=0"], "content-type"=>["application/json"], "date"=>["Fri, 15 Jan 2016 00:08:51 GMT"], "server"=>["nginx/1.4.6 (Ubuntu)"], "vary"=>["Accept"], "content-length"=>["35"], "connection"=>["Close"]}>

Any ideas of what can be going wrong?

That is indeed weird. Especially since there is no difference between the Heroku and regular deployment.

@tschellenbach I've just created a vanilla Rails 4.2.5 project, added the Stream dependencies, pushed the app to Heroku and I am getting the same results. Strangely this now also happens on the Rails console for me.
Steps to reproduce:

Create a new Rails project
Add stream-ruby dependency to Gemfile and run bundle install
Test in rails c

2.2.2 :002 > client.feed("user", "4").followers
 => #<HTTParty::Response:0x7fd26a6de108 parsed_response={"duration"=>"35ms", "results"=>[{"created_at"=>"2016-01-15T21:31:46.754Z", "feed_id"=>"flat:158485", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:31:46.754Z"}, {"created_at"=>"2016-01-15T21:31:39.674Z", "feed_id"=>"flat:158069", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:31:39.674Z"}, {"created_at"=>"2016-01-15T21:31:35.436Z", "feed_id"=>"flat:157815", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:31:35.436Z"}, {"created_at"=>"2016-01-15T21:31:30.990Z", "feed_id"=>"flat:157556", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:31:30.990Z"}, {"created_at"=>"2016-01-15T21:31:30.018Z", "feed_id"=>"flat:157506", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:31:30.018Z"}, {"created_at"=>"2016-01-15T21:31:16.508Z", "feed_id"=>"flat:156791", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:31:16.508Z"}, {"created_at"=>"2016-01-15T21:31:02.990Z", "feed_id"=>"flat:155996", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:31:02.990Z"}, {"created_at"=>"2016-01-15T21:30:53.923Z", "feed_id"=>"flat:155537", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:53.923Z"}, {"created_at"=>"2016-01-15T21:30:52.796Z", "feed_id"=>"flat:155481", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:52.796Z"}, {"created_at"=>"2016-01-15T21:30:45.002Z", "feed_id"=>"flat:154978", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:45.002Z"}, {"created_at"=>"2016-01-15T21:30:41.975Z", "feed_id"=>"flat:154856", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:41.975Z"}, {"created_at"=>"2016-01-15T21:30:40.854Z", "feed_id"=>"flat:154807", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:40.854Z"}, {"created_at"=>"2016-01-15T21:30:34.550Z", "feed_id"=>"flat:154445", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:34.550Z"}, {"created_at"=>"2016-01-15T21:30:31.042Z", "feed_id"=>"flat:154234", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:31.041Z"}, {"created_at"=>"2016-01-15T21:30:19.893Z", "feed_id"=>"flat:153709", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:19.893Z"}, {"created_at"=>"2016-01-15T21:30:15.747Z", "feed_id"=>"flat:153479", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:15.747Z"}, {"created_at"=>"2016-01-15T21:30:13.708Z", "feed_id"=>"flat:153373", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:13.708Z"}, {"created_at"=>"2016-01-15T21:30:08.854Z", "feed_id"=>"flat:153131", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:08.854Z"}, {"created_at"=>"2016-01-15T21:30:06.941Z", "feed_id"=>"flat:153023", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:06.941Z"}, {"created_at"=>"2016-01-15T21:30:06.097Z", "feed_id"=>"flat:152949", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:06.097Z"}, {"created_at"=>"2016-01-15T21:30:05.108Z", "feed_id"=>"flat:152877", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:05.108Z"}, {"created_at"=>"2016-01-15T21:30:04.467Z", "feed_id"=>"flat:152822", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:30:04.467Z"}, {"created_at"=>"2016-01-15T21:29:48.366Z", "feed_id"=>"flat:152207", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:29:48.366Z"}, {"created_at"=>"2016-01-15T21:29:48.356Z", "feed_id"=>"flat:152196", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:29:48.356Z"}, {"created_at"=>"2016-01-15T21:29:40.554Z", "feed_id"=>"flat:151743", "target_id"=>"user:4", "updated_at"=>"2016-01-15T21:29:40.554Z"}]}, @response=#<Net::HTTPOK 200 OK readbody=true>, @headers={"allow"=>["GET, HEAD, OPTIONS"], "cache-control"=>["max-age=0"], "content-type"=>["application/json"], "date"=>["Mon, 18 Jan 2016 20:41:23 GMT"], "server"=>["nginx/1.4.6 (Ubuntu)"], "vary"=>["Accept"], "content-length"=>["3408"], "connection"=>["Close"]}>

Hi Kenny,
The author of the ruby integration (@tbarbugli) is coming back to work next week.
Best,
Thierry

This may not be a bug. I've been using pry which alters the console output. I hope @tbarbugli can just confirm the described behavior is no bug when he comes back before I close the issue.

@tbarbugli @tschellenbach this is not a bug... sorry about the confusion. Closing this one


Create document-query-command-supported

Based on https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported and testing at CBT

@dandv Travis JSON validation check is failing here too; you need to add https://github.com/Fyrd/caniuse/blob/ca56a2a7cc20ecdfb6a53fe377224e4a75f264ae/sample-data.json#L223

Thanks!


UnicodeDecodeError installing via pip-3.2

So here's a weird one. I have a Docker container based on debian:stable where I install python3 and python3-pip, and when trying to install requests from a requirements.txt file I get the following:
Downloading/unpacking requests (from -r /tmp/requirements/xxx.txt (line 2))
  Running setup.py egg_info for package requests

Exception:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/pip/basecommand.py", line 104, in main
    status = self.run(options, args)
  File "/usr/lib/python3/dist-packages/pip/commands/install.py", line 245, in run
    requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
  File "/usr/lib/python3/dist-packages/pip/req.py", line 1014, in prepare_files
    req_to_install.assert_source_matches_version()
  File "/usr/lib/python3/dist-packages/pip/req.py", line 359, in assert_source_matches_version
    version = self.installed_version
  File "/usr/lib/python3/dist-packages/pip/req.py", line 351, in installed_version
    return self.pkg_info()['version']
  File "/usr/lib/python3/dist-packages/pip/req.py", line 318, in pkg_info
    data = self.egg_info_data('PKG-INFO')
  File "/usr/lib/python3/dist-packages/pip/req.py", line 261, in egg_info_data
    data = fp.read()
  File "/usr/lib/python3.2/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 8161: ordinal not in range(128)

However, when I run pip-3.2 install requests directly, it works fine.
I honestly have no idea where even to start on debugging this.

This is a duplicate of an old error that was fixed. Can you confirm that the version of requests is pinned to something in the 2.x line but is not 2.5.1?

#2196 is the already fixed issue for reference.

I've tried it with no version pinned, pinned to 2.5.1, and pinned to 2.5.0.
The thing that I don't understand is why it only fails when installing from a requirements.txt file.


transition group no css effects

Im trying to implement the <transition-group> based on this demo https://vue-draggable-next.vercel.app/#/transition but no css effects. Did i miss something? Im using Nuxt 3 and here is my sample code

                Order
                Status Name
                Status Group

                <VueDraggableNext v-model="lists">
                    <transition-group>

                            {{ list.id}}
                            {{ list.name }}

                    </transition-group>
                </VueDraggableNext>

and this is my lists.
const lists = ref([
    {
          id: 1,
         name: 'John Doe'
    },
   {
        id: 2,
       name: 'Peter Doe'
   }
])

@noprobz09 checkout the example here https://github.com/anish2690/vue-draggable-next/blob/master/demo/components/transition-group.vue


CommaFeed can't load items from https://www.ilrisparmiotradito.it/rss.xml

Steps to reproduce:

in CommaFeed add feed https://www.ilrisparmiotradito.it/rss.xml
the analysis step is ok, but in the end no item is loaded.
Thank you

Looks like the feed has been fixed, I'm gonna close this issue 👍


The connection to the server localhost:8080 was refused!

Hello,
I have a strange bug.
Everything is working fine with vagrant up.
But after some days running some containers, i have the following message when i tried any command involving kubectl

core@master ~ $ kubectl get nodes
The connection to the server localhost:8080 was refused - did you specify the right host or port?

I've tried to vagrant halt/up but i've an unexpected timeout exception on the up phase.
Could someone explain me what's going on and how to resolve it aside from completly destroy and create VM ?
Thanks

You have changed your ~/.kube/config and it's no longer pointing to the cluster created using this repo. If you fix that file, it will work again. There's no need for vagrant halt/up - IIRC that's not even supported.

I didn't change anything in this directory.
Could you send me a sample config ?

Well, something did because localhost:8080 is not what's being defined here.


Android: Unhandled exception in callback for onConnectionStateChange

Android only:
OS version: 7 (Nougat); API Level 24
SDK: API 26,
minimum API level 16
BLEDevice.zip
callstack.txt
Hi Allan, hope you are well.
I have observed this exception in my debug output (full stacktrace attached):
java.lang.NullPointerException: Attempt to invoke virtual method 'void android.bluetooth.BluetoothGattCallback.onConnectionStateChange(android.bluetooth.BluetoothGatt, int, int)' on a null object reference
The error is observed very specifically only when re-acquiring characteristics and subscribing to them after a reconnection. I have attached a simple test class which presents this error. In my case, this error occurs when calling Device.Connect(line 140) after the reconnection - the first time everything is 100%. I have set up the test unit to disconnected and then reconnect and resubscribe after 3 notifications have been received.
Cheers
Marius

I have not observed the condition in my tests and the test case is a too specific for me to do anything with.
Please make sure to use the template in the future because the OS where this problem was observed would be very helpful in determining what may be going on

Apologies, I have updated my original post with the information.
I will see if I get it on lower versions as well, but I am pretty sure it is exhibiting it as well since our app was displaying the same symptoms on an API level 19 device as well, which is why I created the test code
Will update post with this confirmation asap.

Hi Allan,
I can report that on API 19 device (Samsung SM-J100H), I get the same error:

10-02 21:37:31.991 W/BluetoothGatt(21261): Unhandled exception in callback
10-02 21:37:31.991 W/BluetoothGatt(21261): java.lang.NullPointerException
10-02 21:37:31.991 W/BluetoothGatt(21261): 	at android.bluetooth.BluetoothGatt$1.onClientConnectionState(BluetoothGatt.java:172)
10-02 21:37:31.991 W/BluetoothGatt(21261): 	at android.bluetooth.IBluetoothGattCallback$Stub.onTransact(IBluetoothGattCallback.java:71)
10-02 21:37:31.991 W/BluetoothGatt(21261): 	at android.os.Binder.execTransact(Binder.java:404)
10-02 21:37:31.991 W/BluetoothGatt(21261): 	at dalvik.system.NativeStart.run(Native Method)
10-02 21:37:31.991 D/BluetoothGatt(21261): onClientConnectionState() - status=0 clientIf=8 device=98:7B:F3:76:81:18

I have done some digging and encounter the following threads as well as a google issue
    public class GattContext
       .
       .
        public void Close()
        {
            this.gatt?.Disconnect();
            this.gatt?.Close(); > this seems to be the issue
            this.gatt = null;
        }

as per one of the suggestions, I added a delay before calling gatt?.Close() - this did not fix the issue. When I comment out this line, I no longer get the exceptions, but rest of the callbacks does not work.
from the Google issue:
DESCRIPTION
When using BLE and from an Android app is first disconnecting and then closing a BluetoothGatt instance a NullPointerException can happen in BluetoothGatt.java.
It seems like the issue is that the mCallback is set to null before removing/unregistering the callback. This means that the GattService still thinks the callback is available when calling e.g. onConnectionStateChange which uses the mCallback instance.

Thanks for looking into this.  It is going to take some time to figure out a proper fix for this.

I am currently trying to update Visual Studio/Xamarin/Android SDK to use Android 8.0 (API 26) to see if this might potentially alleviate this issue...

It won't change a thing.  As an FYI, I've started work on a new implementation of the connection logic.

Can you please give the latest dev branch a try to see if you are still having the issue?

Hi Allan,
I am afraid the error persists in the dev branch as per below:

[0:] Hooking for write response - 0000ffe1-0000-1000-8000-00805f9b34fb
[0:] Incoming Characteristic Write Event - 0000ffe1-0000-1000-8000-00805f9b34fb
10-16 19:35:06.847 D/BluetoothGatt(15544): cancelOpen() - device: 98:7B:F3:76:7E:CF
[0:] Hooking for write response - 0000ffe1-0000-1000-8000-00805f9b34fb
10-16 19:35:06.874 D/BluetoothGatt(15544): close()
10-16 19:35:06.875 D/BluetoothGatt(15544): unregisterApp() - mClientIf=7
10-16 19:35:06.896 D/BluetoothGatt(15544): onClientConnectionState() - status=0 clientIf=7 device=98:7B:F3:76:7E:CF
10-16 19:35:06.901 W/BluetoothGatt(15544): Unhandled exception in callback
10-16 19:35:06.901 W/BluetoothGatt(15544): java.lang.NullPointerException: Attempt to invoke virtual method 'void android.bluetooth.BluetoothGattCallback.onConnectionStateChange(android.bluetooth.BluetoothGatt, int, int)' on a null object reference
10-16 19:35:06.901 W/BluetoothGatt(15544): 	at android.bluetooth.BluetoothGatt$1.onClientConnectionState(BluetoothGatt.java:227)
10-16 19:35:06.901 W/BluetoothGatt(15544): 	at android.bluetooth.IBluetoothGattCallback$Stub.onTransact(IBluetoothGattCallback.java:70)
10-16 19:35:06.901 W/BluetoothGatt(15544): 	at android.os.Binder.execTransact(Binder.java:573)

However, the sequence and timing are slightly different. This time I get it immediately when I CancelConnection(); previously it seemed to have been on Connect()
I have attached the same point of failure on dev and master
master.log
dev.log

This should be fixed as of beta2.  Please note, with your original code, you aren't trapping any errors.  It is expected that Connect & any read/write operations can error.  Connect on droid is actually more likely to bubble out an error if necessary with this release.

Evaluating now, will let you know....

So far it looks good. The re-connection is a bit lethargic, but it seems to be stable.  I have specifically implemented error trapping in my test project for any operation, and so far have not observed any.
I have observed that when I manually disconnect and then try to reconnect, as opposed to out of range or radio switched off/on, that sometimes it does not reconnect. I am still doing more testing and will let you know what I find

Hi Allan,
So I have found the following: initially on first connect all is well.

(a) I connect, (b) obtain a characteristic, (c) write values to it and (d) subscribe to notifications.
I disconnect (in any way: CancellConnection, out of range, Bluetooth off)
Initiate reconnection. It initiates the normal sequence as in (1).
(a) and (b)  is successful
(c) is partially successful. It actually writes the values (BLEDevice:148) to the characteristic, but none of the Actions is triggered in the observable (onNext, onError, onCompleted). I know the value was written successfully because our device disconnects if it does not receive the passcode in:149, and none of the functions in the firmware is enabled.

below is an extract from the code
taskWrite = characteristic.Write(new byte[] { 0xAA, 0x27, 0xEB, 0x55 })
	.Subscribe(
	auth =>
	{
		System.Diagnostics.Debug.Write("Authorized");

		SetNotify(characteristic);
	},

	error =>
	{
		System.Diagnostics.Debug.Write($"error: {error.Message}");
	},
	() =>
	{
		System.Diagnostics.Debug.Write("completed: characteristic.Write");
	});

I have attached sample test code and output
debug-output.txt
BLEDevice.zip

Thanks @mariusbloemhof - your testing has been of amazing help.  Definitely the best I've experienced as an OSS maintainer.
As for your issue, I'm glad the main connection issue appears to be solved.  I haven't seen the write get locked before.  That is a new one, but I have a reliable & fast way to test it now.
From looking at your code, there isn't anything that jumps out as an issue especially since you're trapping the errors.  I'll see what I can find.

It's a pleasure - working in the industry I know what massive pain it is when you get an issue that is reported as "I get an error". Even fellow developers, rarely give enough information to track down the actual problem, when it is not really that hard when you get relevant info.
Plus you are doing me a massive favor, and your component is the best and most usable and stable I have found for Xamarin cross-platform, so I can only help you to help us :)

Can I contact outside of this forum if you don't mind? I have a simple, BLE related question I want to ask you, and I am sure you have loads of expertise around this

does your problems occur on all devices?
(or maybe mostly on Samsung S8? (as i am))

I get this on a Samsung SM-J100H (Android 4.4 - API 19) as well. I have not tested another manufacturer other than Samsung. I will need to get my hands on more phones.
The original phone was an S8 though yes

@mariusbloemhof you can contact me on the xamarin slack (xamarinchat.slack.com - username aritchie)

master now contains a new connection mechanism ported from rxandroidble project that is supposed to take of all these junk implementations on other phones.
I haven't had any luck reproducing the write locking you're experiencing.  Could you try modifying the new test projects to see if you experience the issue there?

Hi Allan, so far all looks good on master. I modified your test project to include my authentication, and it worked, even on reconnection events. I then transferred some of the code over to my test project and managed to get it working, Once I have it 100% working I will post the differences and let you know. I will then also transfer the changes to your main app and report back
Cheers!

We are facing an issue described by @mariusbloemhof in https://github.com/aritchie/bluetoothle/issues/72#issuecomment-340532461.
Are there any estimations when it's possible to try a fixed version from NuGet (maybe preview)?

@mariusbloemhof you likely only need to run with the unit tests as they will draw out the worst of the problem.
@SeeD-Seifer it breaks my mojo when people ask for estimates on OSS.  If you could run master and report back feedback, that would be helpful.  The more positive feedback I can get, the better chance of a release.

@aritchie sure thing! Just prefer to ask if it makes sense to wait another night in case preview release is planned anyway :)
Will try during the week and let you know if master fixes the issue for us.

@aritchie
I have extensively tested using the latest code. I tried to modify the unit tests, but my custom device makes it slightly more tricky, and eventually I end up with my test code:) (see my test class)
I keep on encountering this error (see screenshot)
System.Threading.SemaphoreFullException: Adding the specified count to the semaphore would cause it to exceed its maximum count.
I have attached the full output, callstack and the test class that I use to test. My testing sequence is much the same before:

(a) I connect, (b) obtain a characteristic, (c) write values to it and (d) subscribe to notifications.
I disconnect (in any way: CancellConnection, out of range, Bluetooth off)
Initiate reconnection. It initiates the normal sequence as in (1).
(a) (b) and (c) is successful
(d) seems to be successful but the error is raised, even though the RegisterAndNotify seems to be successful, it then fails on what seems to be the write with the attached error.

I have noticed that you seem to use a lot of task/await, whereas I specifically use the observables.
debug.zip

The exception is easy to fix.  I can't delay the writes on my test device so I'm not seeing the gap between passing the gate and still cancelling the task.
My use of async is just to cause a sequential flow in droid.  The whole android bluetooth stack requires a serial/sequential pattern for ALL actions coming in/out thus the need for locks.  The library is taking a protocol that should be asynchronous, dealing with it serial, while exposing it as asynchronous.  It's complicated.
Once again, your testing helps a ton... thanks.  Patch should be incoming in a few hours.

Hi Allan, I am encountering a write lock after the initial write to the characteristic. I can

obtain characteristics,
write values to it successfully
control in (2) return, but any action after this write, locks execution.

No error is raised. It is the same test unit as before
output.txt

I can confirm the issues reported above with unstable behavior of writes (and sometimes reads) with the latest commit, and when I roll back the commit I am back at the problem with the race condition on the semaphore. I temporarily solved this by simply trapping exceptions around the semaphore release in DeviceContext.cs and this solves this problem while also retaining the reads and writes. But with that fix I have observed that it seems possible for multiple characteristics accesses against different BLE device instances to "interfere" with each other: They run at the same time (seemingly) and neither of them completes. I imagine that is related to the semaphore gate.

Guys - Android requires things to be done in sequence/serial format.  The library is attempting to solve that for you and failing.  This also helps produce the GATT 133 issue that you likely have experienced.  I believe the key issue with this topic has been solved.  The read/write locks will be removed in the next version as fixing the overall issue is difficult.  This means your code will need to be responsible making sure things fire and complete in a serial fashion.
@goiditdev please contribute fixes instead of just talking about what you think the issue is.  It isn't helpful simply adding confirmation.

@aritchie My apologies. I didn't commit anything because my code change isn't a fix. It just moved the problem somewhere else.


Program will not turn in

Every time I go to calculate the grade or turn in the assignment, I get stuck with the loading wheel. I have attempted this several times over the course of the last 40 or so minutes.
Version: 1.85.2
Commit: 8b3775030ed1a69b13e4f4c628c612102e30a681
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces

/causedByExtension

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


Stop creating PRs from the UI?

We see quite a few PRs every week created by accident, e.g. https://github.com/openwebdocs/mdn-bcd-results/pull/878
Should we remove this feature?
What's the use case?

Before the Selenium script was introduced, this function used to be the only way to get the results from multiple browsers into GitHub, since I would have to manually run every browser version on BrowserStack, one by one.  However, since the Selenium script does most of the work for us, this is only important for a few browsers (Safari and mobile browsers) that we can't automatically test with using Selenium.
However, we do unfortunately get a lot of PRs opened from random users clicking on the GitHub export, and it would be great to limit who is allowed to export to GitHub.  I was thinking of ensuring that it can only be category-level or higher.  Maybe some private passkey that must be entered, so only we can generate these PRs?

The original motivation for this was to make it very easy to collect results even from browsers and devices where we can't save files or otherwise get data out of the browser, like old mobile browsers running through an emulator. I think keeping that capability is useful.
Changing the name of the button would be a good start I think. Originally I think this was the only way to export results, even before there was a way to download, so that explains the generic wording.
Are PRs against mdn-bcd-results used at all in the current day-to-day work? If not, automatically closing any PR might be an option. A maintainer could reopen and merge anything that was intentional.

I've sent https://github.com/openwebdocs/mdn-bcd-collector/pull/902


Fixing typo in comment blocks of createError() and enhanceError()

Nothing more than a couple of typos in the comment blocks of 2 functions. I'm only fixing this because they were being picked up by the code linter in my pre-commit hook in my webpack-built Laravel 5 project.

Coverage increased (+1.5%) to 93.719% when pulling 30c5a3b0bb47acb79b6c727c9eea3eb501389429 on martinjoiner:master into f31317aeca8f7fa385d6aee94ef6ec8ac9d7c072 on mzabriskie:master.

Thanks for the fixes!


Search query must query also the upn as mail could be null

PeopleSearch service should also find people by userPrincipalName when group transitive membership check is used. If the user does not have an email or the email is different from userPrincipalName currently it is not returned.

Q
A

Bug fix?
[ X ]

New feature?
[ ]

New sample?
[ ]

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
This PR adds the userPrincipalName filter to the query.

@eduardpaul , Thank you for the improvement .


Missing var in slider.js

Hi everyone, I'm using gulp-include to include all js plugins in order
My code editor shows me errror in:
foundation.slider.js
// Line: 331:
offsetPct = percent(barXY, barDim);
After changing  to:
var offsetPct = percent(barXY, barDim);
Error dissapear, even without fixing, my js compilation works fine
Nothing to worry, just a cosmetic change...

Interesting..

Seems to be already addressed in #9006.


Manual Overrides - TCP

I am wondering if fabio will terminate existing TCP connections (as configured with proto=tcp) if a manual override deletes the route?
For example, I have a redis server hosted by ElastiCache and exposed through fabio using a route override since fabio does not process "external" services registered to consul.
So I have the manual route:
route add redis :6379 tcp://something.use1.cache.amazonaws.com:6379 opts "proto=tcp"
My application connects through that just fine, but what if I want to change the route to another ElastiCache instance?
Currently, if I remove/delete the route or change it in the overrides fabio doesn't drop the existing connection.
Is this intended? If so, would it be possible to configure fabio to drop the  up/downstream connection and force the client that's connected to it to reconnect and get the new route?
Thanks

The current behavior is for fabio not to interrupt existing connections. This stems from the fact that fabio started as an HTTP proxy which is presumed to have short living connections. That was already broken when supporting web sockets but TCP proxying makes this more visible since master/cluster failovers require an active component in the stream which terminates the connection.
This requires keeping track of certain types of connections which need to be disconnected when the routing table changes. Right now, the proxy code is wholly unaware of changes in the routing table and therefore cannot take action. Since this would interrupt existing connections anyway I'd suggest to restart fabio to kill the other connections until I have a better solution. Not sure whether this is an option for you.

I have an idea of a work around until you're able to solve it.
Thanks for the quick response


I sent Trx currency from Trust wallet to Telegram dollar currency wallet and nothing arrived. What should I do?

Description

Name:

HD Derivation Scheme:

Symbol:

Documentation:

Reason:
Checklist
Finish check list here.

Hello @hany21
This issue has been preview on the Pull Requests. To resolve, Visit the official live support page to initiate a chat with an agent using the chat button via support

Hi @hany21, this issue is not related to the wallet core repository, please create a ticket here to get help: https://support.trustwallet.com/en/support/tickets/new

Hello @hany21  A support ticket has been opened for you. Kindly Talk to Support on the Live support page so that your issue can be looked into. CLICK HERE


Group ID can not be found in download.

tgcloud -m download -n x -u -123456789 -p "/Users/me/Desktop/" -c "test"
When I use this command with a groupID I get a error message.
Uploading with the same groupID works and uploading and downloading to me works as well. Am I doing anything wrong?
Thank you for the help!
Awesome tool!
Additional Info:

groupID is replaced
OS = macOS

The error message:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.7/bin/tgcloud", line 10, in <module>
    sys.exit(cli())
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/telegramcloud/__main__.py", line 71, in cli
    client.loop.run_until_complete(main())
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 579, in run_until_complete
    return future.result()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/telegramcloud/__main__.py", line 45, in main
    async for message in client.iter_messages(entity=username, search=args.caption):
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/telethon/requestiter.py", line 58, in __anext__
    if await self._init(**self.kwargs):
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/telethon/client/messages.py", line 26, in _init
    self.entity = await self.client.get_input_entity(entity)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/telethon/client/users.py", line 432, in get_input_entity
    await self._get_entity_from_string(peer))
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/telethon/client/users.py", line 570, in _get_entity_from_string
    'Cannot find any entity corresponding to "{}"'.format(string)
ValueError: Cannot find any entity corresponding to "-123456789"

Hello
Thank you for reporting this problem.
It's my bad!
Now it's working fine, test it again and make sure you are on version 1.4.4, not older versions.

Works now! Thank you for the quick fix!


Convert Featurecollection to SpatialRDD

Could someone sketch a way on how to convert an org.geojson.FeatureCollection (list of geojson features) to a SpatialRDD.
I found a way that works with a workaround by feeding derived GeojsonFeatureStrings to the SpatialRDD, but I bet there must be a more efficient method.
Would be very gratefull if someone could help here.
Thanks.
Br conect.

@conect
Test data:
{ "type": "FeatureCollection",
    "features": [
      { "type": "Feature",
        "geometry": {"type": "Point", "coordinates": [102.0, 0.5]},
        "properties": {"prop0": "value0"}
        },
      { "type": "Feature",
        "geometry": {
          "type": "LineString",
          "coordinates": [
            [102.0, 0.0], [103.0, 1.0], [104.0, 0.0], [105.0, 1.0]
            ]
          },
        "properties": {
          "prop0": "value1",
          "prop1": 0.0
          }
        },
      { "type": "Feature",
         "geometry": {
           "type": "Polygon",
           "coordinates": [
             [ [100.0, 0.0], [101.0, 0.0], [101.0, 1.0],
               [100.0, 1.0], [100.0, 0.0] ]
             ]
         },
         "properties": {
           "prop0": "value2",
           "prop1": {"this": "that"}
           }
         }
       ]
     }

Code:
      val schema = "type string, features array<struct<type string, geometry string, properties map<string, string>>>"
      val df = sparkSession.read.schema(schema).option("multiLine", "true").json(geojsonFeatureCollection)
      val parsedDf = df.selectExpr("explode(features) as features").select("features.*")
        .withColumn("geometry", expr("ST_GeomFromGeoJSON(geometry)"))
        .withColumn("prop0", expr("properties['prop0']")).drop("properties").drop("type")
      parsedDf.show()
      parsedDf.printSchema()

Output
+--------------------+------+
|            geometry| prop0|
+--------------------+------+
|     POINT (102 0.5)|value0|
|LINESTRING (102 0...|value1|
|POLYGON ((100 0, ...|value2|
+--------------------+------+

root
 |-- geometry: geometry (nullable = false)
 |-- prop0: string (nullable = true)

To SpatialRDD and saveAsGeoJSON again
      var spatialRDD = Adapter.toSpatialRdd(parsedDf, "geometry")
      spatialRDD.saveAsGeoJSON("testOutput.json")

testOutput.json content
{"type":"Feature","geometry":{"type":"Point","coordinates":[102.0,0.5]},"properties":{"prop0":"value0"}}
{"type":"Feature","geometry":{"type":"LineString","coordinates":[[102.0,0.0],[103.0,1.0],[104.0,0.0],[105.0,1.0]]},"properties":{"prop0":"value1"}}
{"type":"Feature","geometry":{"type":"Polygon","coordinates":[[[100.0,0.0],[101.0,0.0],[101.0,1.0],[100.0,1.0],[100.0,0.0]]]},"properties":{"prop0":"value2"}}

This works for Scala, Java, Python, R. The detailed explanation can be found here: https://sedona.apache.org/1.4.0/tutorial/sql/#load-geojson-using-spark-json-data-source

@conect This is in fact not possible. JSON in general is a very bad format for big data. Parsing a large json dataset is known to be very slow due to (1) json string parsing is slow anyway (2) multi-line json cannot be chopped to multiple partitions and read in parallel. The reader has to figure out a way to honor the json that crosses multiple partitions.

@conect My suggestion is, in your original dataset (1) do not use feature collection (2) do not use multi-line geojson
Use something like this, each geojson object takes 1 single line
{"type":"Feature","geometry":{"type":"Point","coordinates":[102.0,0.5]},"properties":{"prop0":"value0"}}
{"type":"Feature","geometry":{"type":"LineString","coordinates":[[102.0,0.0],[103.0,1.0],[104.0,0.0],[105.0,1.0]]},"properties":{"prop0":"value1"}}
{"type":"Feature","geometry":{"type":"Polygon","coordinates":[[[100.0,0.0],[101.0,0.0],[101.0,1.0],[100.0,1.0],[100.0,0.0]]]},"properties":{"prop0":"value2"}}


[suggestion] use icons for fileformat

Instead of the boring unix, dos and mac for fileformat, one may use devicons (since they are also used for file types). More precisely, from https://www.nerdfonts.com/cheat-sheet, check out nf-dev-linux, nf-dev-windows and nf-dev-apple. Just eye-candy, but, hey, why not? (I do not think both icon and text should be provided. Icons if the possibility is there, text for fallback.)

Seems like a nice idea

Seems like a nice idea

I think it will make it look prettier, and also will relieve some space. I am debating on whether nf-pl-current_line and nf-ple-current_column would be good to use in location. They do look good, but maybe they will add up on space...

I think it will make it look prettier, and also will relieve some space. I am debating on whether nf-pl-current_line and nf-ple-current_column would be good to use in location. They do look good, but maybe they will add up on space...

This is related to #16 and #45. Hopefully in the near future you will be able to set
lualine.icons = true
lualine.powerline_fonts = true
lualine.sections.lualie_a = { 'filetype' icons false } -- something along those lines

This is related to #16 and #45. Hopefully in the near future you will be able to set
lualine.icons = true
lualine.powerline_fonts = true
lualine.sections.lualie_a = { 'filetype' icons false } -- something along those lines

resolved with #45


ChangeMasterCredentials: fixed when server is not a replica

Fixes https://github.com/github/orchestrator/issues/788
This fixes the ChangeMasterCredentials() behavior on masters. Behavior was broken by https://github.com/github/orchestrator/pull/767
cc @pasha167

@shlomi-noach, thank you for quick response.
I tested that and it did not solve the issue. Could you please double check?
Thanks.

whoops. committed an unrelated change.

@pasha167 please test again now

Yes, that works 👍. Thanks.

This PR also introduces a concurrency cap on the number of replicas operated on relocate-replicas. There will only be 5 replicas moved at a time.


Resolve FQDNs to IP addresses via A record lookup

This completes the full service lookup by adding the missing A record lookup step:

Look up the SRV records for a given service
Look up the A records for each FQDN returned by the previous SRV query
Add the IP:port pairs to the list of discovered nodes

Previously, when that step was skipped, the FQDN (not the IP address) was being passed to new DiscoveryNode, which would cause an UnresolvedAddressException.
Here's what the process looks like if you were to do it manually on the command line:
$ dig @localhost -p 8600 elasticsearch-transport.service.consul SRV
;; ANSWER SECTION:
elasticsearch-transport.service.consul. 0 IN SRV 1 1 9301 machine.node.dc1.consul.
elasticsearch-transport.service.consul. 0 IN SRV 1 1 9300 machine.node.dc1.consul.

$ dig @localhost -p 8600 machine.node.dc1.consul. A
machine.node.dc1.consul. 0   IN      A       <IP_ADDRESS>

Now the IP:port pairs can be constructed: <IP_ADDRESS>:9301 <IP_ADDRESS>:9300
I tested this on my own machine with 2 ES processes on different ports by setting discovery.zen.ping.multicast.enabled: false and discovery.zen.minimum_master_nodes: 2, and watching the output of  curl -s localhost:9200/_cat/nodes?h=ip,port,v,m switch from {"error":"MasterNotDiscoveredException[waited for [30s]]","status":503} to <IP_ADDRESS> 9300 1.7.2 *\n<IP_ADDRESS> 9301 1.7.2 m after starting the second ES process.
Also, this should support multiple A records per FQDN. Although I don't know if it works, the cloud-aws plugin already does this.
Closes #4.
/cc @grantr

@grantr: Do you think we can merge this in and make a release?

@chrismwendt Sure. I haven't tested it, but if you're confident we can merge.


PR for #205

This is inactive, so I'm going to close for now, but feel free to discuss if needed.

 You should sign our Contributor License Agreement in order to get your pull request merged.

Let's take another look at this PR after the discussion in #606.
I find it frustrating that backends are poorly designed such that this is required, but if we want adoption I guess we need to be compatible.
Let's go ahead and keep the name "proxy_redirect" to be consistent with "proxy_header".
This PR is going to conflict with #601. Also, we'll need a test case to verify the behavior.

@mholt said:
This PR is going to conflict with #601.

If my PR get approved, I can make the adjustments needed to make them compatible.

@novaeye Will you able to add a test case for this PR? If so, I'll leave this open, otherwise, we'll have to wait for somebody else to pick up where you left off. It's a good start.

@novaeye I'm going to close this due to inactivity. :( But if you (or anyone!) could add a test case to this we'd like to look at merging it in.

Is this working or is it under construction?

@Stonedestroyer Seems like this change was abandoned over a year ago.


Avg Entry Price

Implement the average entry price from the subgraph entity
Description

Change the title on the position card
Retrieve the average entry price from the subgraph for FuturesPositionsTable

Related issue
Closes #534
Screenshots (if appropriate):

Situation: I have an open position on ETH. From dashboard, I visit LINK-PERP. In the Futures Positions overview at the bottom, the Avg Entry price is loaded with a dash and only shows up after about a minute of delay.

@platschi It's expected that the data will arrive separate from other table data, but the delay is too long. I added a dependency that looks like it fixed this locally.


Roll Flutter Engine from 7572fe5b9226 to c7894a662ae1 (8 revisions)

https://github.com/flutter/engine/compare/7572fe5b9226...c7894a662ae1
2023-03-11<EMAIL_ADDRESS>Make the context current before accessing GL in MakeSkiaGpuImage (flutter/engine#40208)
2023-03-10<EMAIL_ADDRESS>Revert "Make FlutterTest the default test font (#40188)" (flutter/engine#40237)
2023-03-10<EMAIL_ADDRESS>Revert "[web] Access engine version to get correct gstatic URL (#40194)" (flutter/engine#40235)
2023-03-10<EMAIL_ADDRESS>Manual roll Dart SDK from 7240b35cc401 to c766fffb626e (9 revisions) (flutter/engine#40233)
2023-03-10<EMAIL_ADDRESS>Roll buildroot to 287917d342224d34d6fbdf863aee8417a5f2e8b8 (flutter/engine#40232)
2023-03-10<EMAIL_ADDRESS>Roll Fuchsia Linux SDK to 12.20230309.0.1 (flutter/engine#40231)
2023-03-10<EMAIL_ADDRESS>[Impeller] remove unused shader, format malioc diff (flutter/engine#40230)
2023-03-10<EMAIL_ADDRESS>Make FlutterTest the default test font (flutter/engine#40188)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 2R3ybztMdyKj to VFZ_BtgLOf7F
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

AutoRoller is stopped; closing the active roll.


Update disable-user-signup.md

Checklist
I have:

[x] run the content through Grammarly
[ ] linked to sample apps when relevant
[ ] added the meta description for each page in the PR
[x] minimized the callouts and added only when necessary
[ ] added the queryString parameter to the Tabs (if used)
[ ] masked PII in images. For example, login credentials, account details, and more
[ ] added images only when necessary
[ ] deleted the images that are no longer used for the updated pages in the PR
[ ] followed the image file naming convention while renaming or adding new images. (Use lowercase letters, dashes between words, and be as descriptive as possible)
[ ] used the <figure/> tag instead of a markdown representation for images
[ ] added the <figcaption/> tag to add a caption to the image
[ ] added the alt attribute in the <img/> tag
[ ] verified and updated the cross-references or created redirect rules for the changed or removed content
[x] reviewed and applied the style changes for UI formatting. For example, Bold the UI elements(Buttons on screen) used in the doc.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix: footer of pomodoro page

Closes: #1199 #1201 #1205

@akshitagupta15june done.

Sign Up For Our Newsletter: is not visible in footer? @Viveksati5143

<img width="960" alt="image" sr@akshitagupta15june ="https://github.com/akshitagupta15june/Moksh/assets/100852245/4ca6b22a-66f5-4c09-b0d2-3856a1650d3d">
done @akshitagupta15june

cool! Thanks


Meilisearch is no more able to return split words

In the previous version of Meilisearch, camelCasing wasn't supported and therefore words like DeLonghi were not split. In this new v1.2 version we introduced the support of camelCase. Unfortunately, we also consider that concatenating two query words is considered one typo.
To Reproduce

Start Meilisearch v.1.2.0
Send the document [{ "id": 0, "title": "DeLonghi" }]
Search for dellonghi

Expected behavior
Meilisearch should be able to find this one document without issue.

Feedback from the user here: https://github.com/meilisearch/meilisearch/discussions/3831

Hello everyone 👋
We have released the first RC (release candidate) of Meilisearch containing this change!
You can test it by using

the release assets
the Meilisearch Docker image

docker run -it --rm -p 7700:7700 -v $(pwd)/meili_data:/meili_data getmeili/meilisearch:v1.3.0-rc.2

If you encounter any bugs, please report them here.
Thanks in advance for your help and your involvement in Meilisearch ❤
🎉 The official and stable release containing this change will be available on July 31st, 2023
⚠ RC (release candidates) are not recommended for production