[Issue #472] Move results from RegexMatcher to its own attribute

This PR adds a new property spanListName to regex matcher and regex source. This option lets users to specify the name of the column where the spanList results will be put into. If the spanListName is not specified or empty, then the name will be specified by system.

LGTM. It will be good add a comment to the codebase to explain the logic.


sucle:start crashes on Windows 10 64-bit

I installed sucle per the instructions on my Windows 10 x64 box, and everything works up until (sucle:start), when I get this message:
* (ql:quickload :sucle)
To load "sucle":
  Load 1 ASDF system:
    sucle
; Loading "sucle"
.............
(:SUCLE)
* (sucle:start)
#<SB-THREAD:THREAD "Anonymous thread" RUNNING {1006207803}>
*
debugger invoked on a SIMPLE-ERROR in thread
#<THREAD "Anonymous thread" RUNNING {1006207803}>:
  An exception occurred in context #.(SB-SYS:INT-SAP #X03C0D0F0): #.(SB-SYS:INT-SAP #X03C0DD50). (Exception code:<PHONE_NUMBER>)`

Hello rpherman! Thank you for taking the time to be a part of the sucle development effort!
The exception code<PHONE_NUMBER> seems to be related to the loading of foreign libraries, and glfw3 is the only foreign library which is used. What IDE are you using?  I'll try to copy your setup to see what is going wrong.

Giorgio,
I'd love to be a part of this, if I can get it working, and I am competent
enough to help.
I followed the installation instructions on the repository.
I simply did a fresh install of Roswell, with the default SBCL install, and
the subsequent install of sucle per the installation instructions.
This happens at the Windows Command Prompt with the SBCL REPL running after
issuing the 'ros run' command.
I can use any IDE, but I did install Lem via Roswell, but when I execute
Lem it says it is incompatible with the 64 bit Windows 10 I am running.
I do have a Linux box at home, so I will try that when I get back home in a
few days. Windows is my daily driver and work computer.
Thanks!
Rob
On Thu, 25 Jul 2019 at 11:52, Giorgio Masching III<EMAIL_ADDRESS>wrote:

Hello rpherman! Thank you for taking the time to be a part of the sucle
development effort!
The exception code<PHONE_NUMBER> seems to be related to the loading of
foreign libraries, and glfw3 is the only foreign library which is used.
What IDE are you using? I'll try to copy your setup to see what is going
wrong.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gmasching/sucle/issues/19?email_source=notifications&email_token=AAVRDNPOURAG4K23DELNMA3QBEPQDA5CNFSM4IGV2V2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2YIKTY#issuecomment-514884943,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVRDNNSKEZULY74FBK3IVDQBEPQDANCNFSM4IGV2V2A
.

I need to use it on Windows, so I will reinstall. What IDE do you recommend, and when to install it in the process? If I have Emacs and Slime, is that all the IDE I need, or are you looking for an OpenGL context IDE? Thanks!

I still get the same error from my original post. Any ideas on Windows and sucle?

I also have issues with sucle on Windows 10. It doesn't crash but only produces a black unresponsive window. I am starting sucle from portacle, and do not get any errors. Output below:
CL-USER> (ql:quickload :sucle)
; Fetching #<URL "http://beta.quicklisp.org/dist/quicklisp/2019-10-08/releases.txt">
; 436.17KB
==================================================
446,638 bytes in 0.05 seconds (7930.36KB/sec)
To load "sucle":
  Load 1 ASDF system:
    sucle
; Loading "sucle"

(:SUCLE)
CL-USER> (sucle:start)
#<SB-THREAD:THREAD "Anonymous thread" RUNNING {10036AEE03}>
CL-USER>

@maacl
Sorry for the delayed response.
I really need to add a help menu/ splash screen/tutorial. Right now I'm working on documenting everything and writing test cases on how to use it.
If you click/focus on the window and press "E" a blue screen should appear with a white dot at the center. this is the sky and the crosshair.
Then if you run:
(dotimes (x 100)
   (flet ((foo () (- (random 20) 10)))
        (world::plain-setblock (foo) (foo) (foo)  2)))

You'll see some grass blocks appear.
Sorry this is so convoluted, I'm working on documenting and explaining everything.
see: https://github.com/gmasching/sucle/issues/20 for more details

Thanks. Whene I press "E" I get a landscape etc. but I get undefined function, when trying to call world::plain-setblock.


Not working on random url input

Hi there, I was wondering if I am doing it wrong? It seems to accept anything random that at least has a . in it:
Example
2.3.0 :067 > PublicSuffix.valid?("asdg.324.asad324")
=> true

Another example:
2.3.0 :071 > PublicSuffix.valid?("12gdf3.1234578")
=> true

You need to override the default * (wildcard) rule:
irb(main):005:0> PublicSuffix.valid?("asdg.324.asad324", default_rule: nil)
=> false

See https://github.com/weppos/publicsuffix-ruby/blob/f6132e1cb96080f60a0b4b1628408dc8de51e8d2/2.0-Upgrade.md#upgrade for more info about that

Ah great thanks! so if I use the default_rule : nil ...I will be able to stop people inputting urls that are not known to the list? Which should cover pretty much everything?

From https://publicsuffix.org/list/

If no rules match, the prevailing rule is "*".

Therefore, if you enter a random string with a dot in it, the last part is considered the suffix regardless whether the suffix is in the list or not. This is by design.
This library is not designed for URL validation.

Appreciate the clarification, thanks!


Use a new dataset in style transfer

Hi!
Recently, I am trying to use a new dataset of motion in style transfer. But I face some problems about the preprocess of the dataset.

Does the new dataset skeleton have to have the same T-pose as the original skeleton?

Can you tell me some information about the skeleton_MCU.yml file? I just know that it seems to preserve the static information of the skeleton. How can I create a new .yml for the new dataset?

Looking forward to your kind reply. Thanks!

I have the same question about the creation of skeleton_CMU.yml, Did you replace the dataset successfully, if you succeed, can you tell me how to generate the yml file of a new dataset?
Looking forward to your reply, thank you so much!

I have the same problem. Have you solved it?


Debugger friendly context

An attempt to fix #1950 .
To prevent some kind of performance problem I'm limiting the  enumeration of DynamicDictionary to five items since this seems sensible. I tried to follow the guidelines at http://blogs.msdn.com/b/jaredpar/archive/2011/03/18/debuggerdisplay-attribute-best-practices.aspx
Right now it outputs is like:

TODO

[x] Response
[x] NegotiationContext
[x] DefaultRequestTrace

@felipeleusin This is actually looking more useful than I initially thought :)

So, I'm not sure about the NegotiationContext and DefaultRequestTrace. I'm just going to keep them as is. Also I have no idea why the TravisCI build failed, can you guys help me with it? It seems something wrong with mono.
And one last thing, I couldn't find a way to get the ProtocolVersion on the Response object.

Hi

Leave NegotiationContext and DefaultRequestTrace
TravisCI seems happy now
Why would you get the protocol version from the response?

@khellang Ironically you should know that it's not on the Response object because you were the one that added it to Nancy in the first place :yum:

So, ignoring protocol-version on the Response, is this feature complete?

Yeah. I think so.

@TheCodeJunkie Yeah that was more of a questioning statement than an actual question. It seemed like you thought it had a protocol version and that it was used in the display property :smile:

@khellang the way it came across to me was that you were surprised that there wasn't a protocol-version property on the response :P

Bam! Welcome to the Nancy contributors club :heart:

:+1: :clap:
Bravo! I'm sorry I didn't have the chance to contribute, but this is looking awesome! Well done!

Thanks! It's been lot of fun, if you guys have any issues that need help let me know. Been using Nancy for a few years and would love to help more.


Windows Defender Detected Release Zips as Trojan:Win32/CryptInject!ml

Been using this since the initial launch of the tweaks. Thanks for all of the hard work; however, today after I ran the latest Windows Defender security definition updates it detected each of the Release zips in particular for this repo as containing Trojan:Win32/CryptInject!ml.
https://www.microsoft.com/en-us/wdsi/threats/malware-encyclopedia-description?Name=Trojan:Win32/CryptInject!ml
More than likely a false positive, but I removed them immediately.

same here, got alert from windows defender

If you got it from the releases page here, it is a false positive. If you got it anywhere else, you might have a problem.
https://www.virustotal.com/gui/file/d9aa90b200c633c330db1bad03098afaf202b128e502d2fa770e486423a03edb/detection

I would recommend not using Windows Defending seeing as it can have many false positives.

Defender has a relatively low false positive rate, especially if you keep it properly updated. In this case, the latest version of defender does not trigger this FP (as seen in the VT link I posted, and from my own testing.)

Can confirm that Windows Defender security intelligence version 1.329.1017.0 (current as of 25-12-2020T0410Z) gets a hit for the above referenced trojan from the zip I downloaded on 19-12-2020T0012Z but not any binaries later than that on my machine. It appears that the next version I downloaded was significantly smaller due to major code changes. Looks like a false positive but I have no idea what heuristic it's getting caught on. Manually scanning folder containing about a dozen releases does not hit any of the others for me.

My friend sends me videos in zip files all the time and Windows Defender also randomly picks them up as "Trojan:Win32/CryptInject!ml"
Windows Defender has just been extra sensitive to false positives recently for me.

Windows defender thinks Cyberpunk2077.exe is a malware when zipped.


Add a Gitter chat badge to README.md

chinchang/hint.css now has a Chat Room on Gitter
@chinchang has just created a chat room. You can visit it here: https://gitter.im/chinchang/hint.css.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

added manually.


Plugin doesn't work on React vite template?

import { registerSW } from 'virtual:pwa-register'

registerSW({
  onOfflineReady() {
    // show a ready to work offline to user
  },
})

Upon build
$ tsc && vite build
node_modules/vite-plugin-pwa/client.d.ts:12:28 - error TS2307: Cannot find module 'vue' or its corresponding type declarations.

import type { Ref } from 'vue'

Do I have to install vue for this plugin to work?
EDIT:
I had to include node_modules/vite-plugin-pwa/client.d.ts in tsconfig.json for VScode to even pick up that such a module exists.

@krypticallusion can you provide a minimal repro so we can test? thanks

@krypticallusion,  can you can try to add the entry on the tsconfig.json file (if you have exclude node_modules maybe will not work)?

@krypticallusion can you add types with this?:
"types": [
   "vite-plugin-pwa/client"
]

https://github.com/krypticallusion/test. This is a fine test repo?
I've tried your above suggestions but they seem to be in vain.
Thanks!

@krypticallusion add include instead types (similar to exclude in previous picture):
"include": ["vite-plugin-pwa/client"]

I'll try with you repro...

0.6.5 seems to resolve the issue. Thanks!


Improve instruction to build ssimulacra2

I don't have the technology literacy to understand the instruction and what I need to do. The instruction provided was not sufficient for me and I don't wish for anyone to go through the pain.
I managed to compile and run it after many trial runs. If anyone want to check out how I did this, here's the step. It's mostly for Windows, sorry for anyone who's looking to do this in Linux, I failed to do it on Ubuntu

Enter this link http://www.vapoursynth.com/doc/installation.html#linux-installation,
Follow the prerequisites to download the required python
Enter the VapourSynth installer link and download the .exe file
Then download the latest release-x86_64-cachedir-cwd.zip from https://github.com/AkarinVS/L-SMASH-Works/releases/tag/vA.3j
Run the exe file, don't modify or change any setting if you are not familar with it
After Vapoursynth is installed, find the path, typically C:\Users<username>\AppData\Local\Programs\VapourSynth\sdk\lib64 (REPLACE THE  WITH YOUR!!)
decompress the .zip folder, and copy and paste the libvslsmashsource.dll to C:\Users<username>\AppData\Local\Programs\VapourSynth\plugins
(I only attempted this on Powershell), There are different command shell to use. Use the command below according to what shell you're using. DON'T FORGET TO REPLACE USERNAME OR PATH FROM STEP 6.

Powershell: $env:LIB="C:\Users<username>\vapoursynth-portable\sdk\lib64;$env:LIB"
CMD: set LIB=C:\Users<username>\vapoursynth-portable\sdk\lib64;%LIB%
Bash: export LIB="C:/Users//vapoursynth-portable/sdk/lib64:$LIB"

If you have rust installed, attempt "cargo install ssimulacra2_rs" on your cli.
If it fail because it require Visual Studio or Visual studio tool, download them. I downloaded Visual
10_1. You can download on https://visualstudio.microsoft.com/downloads/ Find the "Tools for Visual Studio" bar and download the "Remote Tools for Visual Studio 2022". Run it
10_2. Make sure Desktop Development with C++ is checked, leave the optional check installation alone and download it.
10_3. Retry step 8 again after you reboot your PC.
Run ssimulacra2_rs -h to check if it's running.
You're done!

I'll put this on my todo list for when I have a bit more time. I can't help with documentation for Windows, so contributions would be appreciated.


Ram annotation of (x, y) are not aligned

Hi,
I've tried using the provided AtariARIWrapper to get the 'labels' for MsPacmanNoFrameskip-v4.
However, when I draw the locations of player, enemy_sue, enemy_inky..., using ('player_x', 'player_y'), ('enemy_sue_x', 'enemy_sue_y'), there seems to be always certain offsets to the real location.

How can get the aligned locations?
Thanks

Hi,
So the wrapper provides just the raw RAM values. The source code of the game then uses those values to render the sprites. Unfortunately, I don't know assembly code well enough to interpret this rendering process. See issue 47 for a longer answer on this topic. One thing you could do is find (by trial and error) what the offset is and then just add this offset to your code that draws the circles.
Hope this helps!

@happywu We also found the mapping from RAM values to screen positions to be inconsistent across games, and also across different variables within each game. If you want to do this only for a particular game, you can try to deconstruct the encoding for that game using the disassemblies: http://www.bjars.com/disassemblies.html

Thanks, I think manual hack the offsets for certain game would work.


Results Refresh Issue For Query With Many Result Sets

Version 0.30.6
Commit df7e3ec7d52a82febee5b597a1019cabf021b883
Date 2018-06-19T21:45:43.589Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
Steps to Reproduce:

Have Utility Script, either full script or stored procedure which returns multiple result sets (tested with one stored procedure returning 18 result sets).
Run this stored procedure.
When finished scroll down in results window.

Expected Result:
All result set data displays as you scroll.
Actual Result:
First couple result sets show, but as you scroll down, the results are not shown making it seem like there are no results but there are, appearing to be a refresh issue.

Duplicate... sorry.


Fail to extract terms from IAO and ENVO

I'm using the ontology-starter-kit
owltools version https://github.com/owlcollab/owltools/commit/f90176d5849278d8fc01e839e444408c8e9445be)
I'm trying to import the terms:
http://purl.obolibrary.org/obo/IAO_0000312 ## publication about an investigation
or
http://purl.obolibrary.org/obo/ENVO_01000254 ## environmental system
http://purl.obolibrary.org/obo/ENVO_01000309 ## cold environment
I added the ontologies in the Makefile, they are downloaded properly, and I got terms extracted properly from chebi and bfo (so it seems to work ok for some ontologies).
Is there a way to avoid the following errors?
Error for IAO
(the owl file can be found here:  http://bjonnh.net/share/iao_import.owl)
$ owltools --use-catalog imports/iao_import.owl -o -f obo imports/iao_import.obo
Exception in thread "main" org.semanticweb.owlapi.model.OWLOntologyStorageException: org.obolibrary.oboformat.model.FrameStructureException: multiple def tags not allowed. in frame:Frame(BFO:0000031 id( BFO:0000031)is_a( BFO:0000002)def( b is a generically dependent continuant = Def. b is a continuant that g-depends_on one or more other entities. (axiom label in BFO2 Reference: [074-001]){{http://purl.obolibrary.org/obo/IAO_0010000=http://purl.obolibrary.org/obo/bfo/axiom/074-001} })name( generically dependent continuant)def( A continuant that is dependent on one or other independent continuant bearers. For every instance of A requires some instance of (an independent continuant type) B but which instance of B serves can change from time to time.))
at org.semanticweb.owlapi.oboformat.OBOFormatRenderer.render(OBOFormatRenderer.java:90)
at org.semanticweb.owlapi.oboformat.OBOFormatStorer.storeOntology(OBOFormatStorer.java:42)
at org.semanticweb.owlapi.util.AbstractOWLStorer.storeOntology(AbstractOWLStorer.java:155)
at org.semanticweb.owlapi.util.AbstractOWLStorer.storeOntology(AbstractOWLStorer.java:119)
at uk.ac.manchester.cs.owl.owlapi.OWLOntologyManagerImpl.saveOntology(OWLOntologyManagerImpl.java:1521)
at uk.ac.manchester.cs.owl.owlapi.OWLOntologyManagerImpl.saveOntology(OWLOntologyManagerImpl.java:1498)
at owltools.io.ParserWrapper.saveOWL(ParserWrapper.java:289)
at owltools.io.ParserWrapper.saveOWL(ParserWrapper.java:209)
at owltools.cli.CommandRunner.runSingleIteration(CommandRunner.java:3549)
at owltools.cli.CommandRunnerBase.run(CommandRunnerBase.java:76)
at owltools.cli.CommandRunnerBase.run(CommandRunnerBase.java:68)
at owltools.cli.CommandLineInterface.main(CommandLineInterface.java:12)
Caused by: org.obolibrary.oboformat.model.FrameStructureException: multiple def tags not allowed. in frame:Frame(BFO:0000031 id( BFO:0000031)is_a( BFO:0000002)def( b is a generically dependent continuant = Def. b is a continuant that g-depends_on one or more other entities. (axiom label in BFO2 Reference: [074-001]){{http://purl.obolibrary.org/obo/IAO_0010000=http://purl.obolibrary.org/obo/bfo/axiom/074-001} })name( generically dependent continuant)def( A continuant that is dependent on one or other independent continuant bearers. For every instance of A requires some instance of (an independent continuant type) B but which instance of B serves can change from time to time.))
at org.obolibrary.oboformat.model.Frame.checkMaxOneCardinality(Frame.java:424)
at org.obolibrary.oboformat.model.Frame.check(Frame.java:405)
at org.obolibrary.oboformat.model.OBODoc.check(OBODoc.java:390)
at org.obolibrary.oboformat.writer.OBOFormatWriter.write(OBOFormatWriter.java:189)
at org.semanticweb.owlapi.oboformat.OBOFormatRenderer.render(OBOFormatRenderer.java:88)
... 11 more
make: *** [Makefile:61: imports/iao_import.obo] Error 1
Error  for ENVO
(the owl file can be found here:  http://bjonnh.net/share/envo_import.owl)
$ owltools --use-catalog imports/envo_import.owl -o -f obo imports/envo_import.obo
Exception in thread "main" org.semanticweb.owlapi.model.OWLOntologyStorageException: org.obolibrary.oboformat.model.FrameStructureException: multiple def tags not allowed. in frame:Frame(BFO:0000020 id( BFO:0000020)def( b is a specifically dependent continuant = Def. b is a continuant & there is some independent continuant c which is not a spatial region and which is such that b s-depends_on c at every time t during the course of b’s existence. (axiom label in BFO2 Reference: [050-003]){{http://purl.obolibrary.org/obo/IAO_0010000=http://purl.obolibrary.org/obo/bfo/axiom/050-003} })def( b is a relational specifically dependent continuant = Def. b is a specifically dependent continuant and there are n > 1 independent continuants c1, … cn which are not spatial regions are such that for all 1  i < j  n, ci  and cj share no common parts, are such that for each 1  i  n, b s-depends_on ci at every time t during the course of b’s existence (axiom label in BFO2 Reference: [131-004]))def( A continuant that inheres in or is borne by other entities. Every instance of A requires some specific instance of B which must always be the same.)name( specifically dependent continuant)is_a( BFO:0000002))
at org.semanticweb.owlapi.oboformat.OBOFormatRenderer.render(OBOFormatRenderer.java:90)
at org.semanticweb.owlapi.oboformat.OBOFormatStorer.storeOntology(OBOFormatStorer.java:42)
at org.semanticweb.owlapi.util.AbstractOWLStorer.storeOntology(AbstractOWLStorer.java:155)
at org.semanticweb.owlapi.util.AbstractOWLStorer.storeOntology(AbstractOWLStorer.java:119)
at uk.ac.manchester.cs.owl.owlapi.OWLOntologyManagerImpl.saveOntology(OWLOntologyManagerImpl.java:1521)
at uk.ac.manchester.cs.owl.owlapi.OWLOntologyManagerImpl.saveOntology(OWLOntologyManagerImpl.java:1498)
at owltools.io.ParserWrapper.saveOWL(ParserWrapper.java:289)
at owltools.io.ParserWrapper.saveOWL(ParserWrapper.java:209)
at owltools.cli.CommandRunner.runSingleIteration(CommandRunner.java:3549)
at owltools.cli.CommandRunnerBase.run(CommandRunnerBase.java:76)
at owltools.cli.CommandRunnerBase.run(CommandRunnerBase.java:68)
at owltools.cli.CommandLineInterface.main(CommandLineInterface.java:12)
Caused by: org.obolibrary.oboformat.model.FrameStructureException: multiple def tags not allowed. in frame:Frame(BFO:0000020 id( BFO:0000020)def( b is a specifically dependent continuant = Def. b is a continuant & there is some independent continuant c which is not a spatial region and which is such that b s-depends_on c at every time t during the course of b’s existence. (axiom label in BFO2 Reference: [050-003]){{http://purl.obolibrary.org/obo/IAO_0010000=http://purl.obolibrary.org/obo/bfo/axiom/050-003} })def( b is a relational specifically dependent continuant = Def. b is a specifically dependent continuant and there are n > 1 independent continuants c1, … cn which are not spatial regions are such that for all 1  i < j  n, ci  and cj share no common parts, are such that for each 1  i  n, b s-depends_on ci at every time t during the course of b’s existence (axiom label in BFO2 Reference: [131-004]))def( A continuant that inheres in or is borne by other entities. Every instance of A requires some specific instance of B which must always be the same.)name( specifically dependent continuant)is_a( BFO:0000002))
at org.obolibrary.oboformat.model.Frame.checkMaxOneCardinality(Frame.java:424)
at org.obolibrary.oboformat.model.Frame.check(Frame.java:405)
at org.obolibrary.oboformat.model.OBODoc.check(OBODoc.java:390)
at org.obolibrary.oboformat.writer.OBOFormatWriter.write(OBOFormatWriter.java:189)
at org.semanticweb.owlapi.oboformat.OBOFormatRenderer.render(OBOFormatRenderer.java:88)
... 11 more
make: *** [Makefile:61: imports/envo_import.obo] Error 1

Turns out the issue is not related to owltools, but to the ontology-starter-kit that was injecting BFO everywhire (because of the catalog file). Closing the issue.

Looks like the issue is related to terms having multiple definitions in ENVO and IAO (they seem to have cut the definition of the original BFO in two)… Is that a bug in those ontologies or is OWLAPI too strict here?


sciRNAseq and seqFISH documentation errata

Feedback
Help Desk Issue Tracker URL: https://on.spiceworks.com/tickets/open/614/activity
Message:
Is the donor, sample, and assay-specific documentation complete and correct?  Do your assay experts approve for public release?

Amir and Daniel (sample “Creators) need to be capitalized on Samples page
On datasets page, HBM686.ZPMW.826 and HBM286.BGXG.335 are blank for datatypes
The assay-specific documentation needs some typo corrections for location of examples.

Spicework Issue 614-HuBMAP_Alpha_release_Issues.docx
These are the issue in Spiceworks issue 614. I don't see the typos (item 3 above) mentioned.


Fixing The Issue of Message Visibility

Title and Issue number
Title : Messages Are Visible to All Rooms
Issue No. : #28
Close #28
Video/Screenshots (mandatory)
https://github.com/sd012gfhkhhvh/Slate.AI/assets/112365664/544f6d1a-0133-4520-a3ac-4664e8ecdbd4
Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
In This PR Now We Are Explicitly Sending Room Id From ChatBox Component to the Server Which Solves The issue.
Are you contributing under any Open-source programme?
I am Contributing Under JWOC 2024

issue #28 has been resolved and pr #30 has been merged into dev


Unset timestamp to fix cart error

1. Why is this change necessary?
Currently it is possible to buy a product, even if inactive, when it was in the cart beforehand. The validation is faulty due to an always set DataTimestamp
2. What does this change do, exactly?
It adds an unset -> set to null in case the lineItem is not in the productGateway anymore (therefor inactive or deleted)
3. Describe each step to reproduce the issue or behaviour.

Add a product to the cart
Set it inactive or delete it
Continue your shopping process and buy the product
Success

The cart should be validated accordingly and remove the lineItem from it. This is due to
$lineItem->setDataTimestamp(new \DateTimeImmutable());
Being set when the item is initially being added, but never changed afterwards. The check
// product data was never detected and the product is not inside the data collection
        if ($product !== null || $item->getDataTimestamp() !== null) {
            return;
        }

will always lead to a return
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/NEXT-17002
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

@shyim I added 2 tests - one for the delete case and one for the inactive case.

Hey @Isengo1989, It seems that booth of your tests are failing against the current trunk. Could you please have a look at that?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Isengo1989:x: SwissCommerceYou have signed the CLA already but the status is still pending? Let us recheck it.

@J-Rahe as far as I see the test testProductFeaturesContainCorrectInformation is responsible for the failure:
removing the test leads to passing. Mine -> testInactiveProductCartRemoval and testDeletedProductCartRemoval do pass it.
PHPUnit 9.5.21 #StandWithUkraine

Random Seed:<PHONE_NUMBER>

Testing Shopware\Core\Content\Test\Product\Cart\ProductCartProcessorTest
........................E.....S....                               35 / 35 (100%)

Time: 00:04.692, Memory: 118.50 MB

There was 1 error:

1) Shopware\Core\Content\Test\Product\Cart\ProductCartProcessorTest::testProductFeaturesContainCorrectInformation with data set #3 (array('customField', null, 'lorem_ipsum', 3), array(array(array('Default', array('Default')), array(array('Dolor sit amet.')))), array('lorem_ipsum', array('24c8b3e8cacc4bf2a743b8c5a7522a33', 'text', 'Dolor sit amet.'), 'customField'))
Doctrine\DBAL\Exception\InvalidFieldNameException: An exception occurred while executing 'SELECT `custom_field`.`id` as `custom_field.id`, `custom_field`.`name` as `custom_field.name`, `custom_field`.`type` as `custom_field.type`, `custom_field`.`config` as `custom_field.config`, `custom_field`.`active` as `custom_field.active`, `custom_field`.`set_id` as `custom_field.customFieldSetId`, `custom_field`.`allow_customer_write` as `custom_field.allowCustomerWrite`, `custom_field`.`created_at` as `custom_field.createdAt`, `custom_field`.`updated_at` as `custom_field.updatedAt` FROM `custom_field` WHERE (`custom_field`.`name` IN (?))' with params ["lorem_ipsum"]:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'custom_field.allow_customer_write' in 'field list'

/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:79
/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:182
/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:159
/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:2226
/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1313
/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:212
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:299
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:134
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:86
/home/micha/platform_fork/src/Core/Content/Test/Category/Service/CountingEntityReader.php:35
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/EntityRepository.php:225
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/EntityRepository.php:254
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/EntityRepository.php:103
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductFeatureBuilder.php:141
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductFeatureBuilder.php:37
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductCartProcessor.php:125
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductCartProcessor.php:126
/home/micha/platform_fork/src/Core/Checkout/Cart/Processor.php:101
/home/micha/platform_fork/src/Core/Checkout/Cart/Processor.php:65
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Checkout/Cart/Processor.php:84
/home/micha/platform_fork/src/Core/Checkout/Cart/CartRuleLoader.php:127
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Checkout/Cart/CartRuleLoader.php:177
/home/micha/platform_fork/src/Core/Checkout/Cart/CartRuleLoader.php:89
/home/micha/platform_fork/src/Core/Checkout/Cart/CartCalculator.php:30
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Checkout/Cart/CartCalculator.php:39
/home/micha/platform_fork/src/Core/Checkout/Cart/SalesChannel/CartItemAddRoute.php:107
/home/micha/platform_fork/src/Core/Checkout/Cart/SalesChannel/CartService.php:122
/home/micha/platform_fork/src/Core/Content/Test/Product/Cart/ProductCartProcessorTest.php:767
/home/micha/platform_fork/src/Core/Content/Test/Product/Cart/ProductCartProcessorTest.php:322

Caused by
Doctrine\DBAL\Driver\PDO\Exception: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'custom_field.allow_customer_write' in 'field list'

/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDO/Exception.php:18
/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:119
/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1304
/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:212
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:299
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:134
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:86
/home/micha/platform_fork/src/Core/Content/Test/Category/Service/CountingEntityReader.php:35
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/EntityRepository.php:225
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/EntityRepository.php:254
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/EntityRepository.php:103
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductFeatureBuilder.php:141
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductFeatureBuilder.php:37
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductCartProcessor.php:125
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductCartProcessor.php:126
/home/micha/platform_fork/src/Core/Checkout/Cart/Processor.php:101
/home/micha/platform_fork/src/Core/Checkout/Cart/Processor.php:65
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Checkout/Cart/Processor.php:84
/home/micha/platform_fork/src/Core/Checkout/Cart/CartRuleLoader.php:127
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Checkout/Cart/CartRuleLoader.php:177
/home/micha/platform_fork/src/Core/Checkout/Cart/CartRuleLoader.php:89
/home/micha/platform_fork/src/Core/Checkout/Cart/CartCalculator.php:30
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Checkout/Cart/CartCalculator.php:39
/home/micha/platform_fork/src/Core/Checkout/Cart/SalesChannel/CartItemAddRoute.php:107
/home/micha/platform_fork/src/Core/Checkout/Cart/SalesChannel/CartService.php:122
/home/micha/platform_fork/src/Core/Content/Test/Product/Cart/ProductCartProcessorTest.php:767
/home/micha/platform_fork/src/Core/Content/Test/Product/Cart/ProductCartProcessorTest.php:322

Caused by
PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'custom_field.allow_customer_write' in 'field list'

/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:117
/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1304
/home/micha/platform_fork/vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:212
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:299
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:134
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:86
/home/micha/platform_fork/src/Core/Content/Test/Category/Service/CountingEntityReader.php:35
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/EntityRepository.php:225
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/EntityRepository.php:254
/home/micha/platform_fork/src/Core/Framework/DataAbstractionLayer/EntityRepository.php:103
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductFeatureBuilder.php:141
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductFeatureBuilder.php:37
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductCartProcessor.php:125
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Content/Product/Cart/ProductCartProcessor.php:126
/home/micha/platform_fork/src/Core/Checkout/Cart/Processor.php:101
/home/micha/platform_fork/src/Core/Checkout/Cart/Processor.php:65
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Checkout/Cart/Processor.php:84
/home/micha/platform_fork/src/Core/Checkout/Cart/CartRuleLoader.php:127
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Checkout/Cart/CartRuleLoader.php:177
/home/micha/platform_fork/src/Core/Checkout/Cart/CartRuleLoader.php:89
/home/micha/platform_fork/src/Core/Checkout/Cart/CartCalculator.php:30
/home/micha/platform_fork/src/Core/Profiling/Profiler.php:57
/home/micha/platform_fork/src/Core/Checkout/Cart/CartCalculator.php:39
/home/micha/platform_fork/src/Core/Checkout/Cart/SalesChannel/CartItemAddRoute.php:107
/home/micha/platform_fork/src/Core/Checkout/Cart/SalesChannel/CartService.php:122
/home/micha/platform_fork/src/Core/Content/Test/Product/Cart/ProductCartProcessorTest.php:767
/home/micha/platform_fork/src/Core/Content/Test/Product/Cart/ProductCartProcessorTest.php:322

ERRORS!
Tests: 35, Assertions: 173, Errors: 1, Skipped: 1.

run the unit tests again but with FORCE_INSTALL=1 prepanded in the CLI

@J-Rahe @shyim can you please link the error occuring. I just merged the trunk, dropped the DB & TEST_DB + added the FORCE_INSTALL, but still no error:

There were 2 failures:
1) Shopware\Core\Content\Test\Product\Cart\ProductCartProcessorTest::testInactiveProductCartRemoval
Failed asserting that Shopware\Core\Checkout\Cart\LineItem\LineItem Object &000000007f3a49b70000000061abaa6f (
    'payload' => Array &0 (
        'isCloseout' => false
        'customFields' => Array &1 ()
        'createdAt' => '2022-06-30 08:56:08.847'
        'releaseDate' => null
        'isNew' => false
        'markAsTopseller' => null
        'purchasePrices' => '{"currencyId":"b7d2554b0ce847cd82f3ac9bd1c0dfca","net":5,"gross":7.5,"linked":false,"listPrice":null,"percentage":null,"regulationPrice":null,"extensions":[]}'
        'productNumber' => 'cf748fda4bea4475b39e4689c0357670'
        'manufacturerId' => null
        'taxId' => 'c8b6fc8ee4af45d0ab934843d329ce6c'
        'tagIds' => null
        'categoryIds' => null
        'propertyIds' => null
        'optionIds' => null
        'options' => Array &2 ()
        'streamIds' => null
        'parentId' => null
        'stock' => 10
        'features' => Array &3 ()
    )
    'id' => 'e1f5603f943e457f88266596f5a7ca5e'
    'referencedId' => 'e1f5603f943e457f88266596f5a7ca5e'
    'label' => 'test'
    'quantity' => 1
    'type' => 'product'
    'priceDefinition' => Shopware\Core\Checkout\Cart\Price\Struct\QuantityPriceDefinition Object &000000007f3dd3100000000061abaa6f (
        'price' => 15.0
        'taxRules' => Shopware\Core\Checkout\Cart\Tax\Struct\TaxRuleCollection Object &000000007f3d77440000000061abaa6f (
            'elements' => Array &4 (
                15 => Shopware\Core\Checkout\Cart\Tax\Struct\TaxRule Object &000000007f3a02910000000061abaa6f (
                    'taxRate' => 15.0
                    'percentage' => 100.0
                    'extensions' => Array &5 ()
                )
            )
            'extensions' => Array &6 ()
        )
        'quantity' => 1
        'isCalculated' => true
        'referencePriceDefinition' => null
        'listPrice' => null
        'regulationPrice' => null
        'extensions' => Array &7 ()
    )
    'price' => Shopware\Core\Checkout\Cart\Price\Struct\CalculatedPrice Object &000000007f3cbb030000000061abaa6f (
        'unitPrice' => 15.0
        'quantity' => 1
        'totalPrice' => 15.0
        'calculatedTaxes' => Shopware\Core\Checkout\Cart\Tax\Struct\CalculatedTaxCollection Object &000000007f3cbb060000000061abaa6f (
            'elements' => Array &8 (
                15 => Shopware\Core\Checkout\Cart\Tax\Struct\CalculatedTax Object &000000007f3ac17e0000000061abaa6f (
                    'tax' => 1.96
                    'taxRate' => 15.0
                    'price' => 15.0
                    'extensions' => Array &9 ()
                )
            )
            'extensions' => Array &10 ()
        )
        'taxRules' => Shopware\Core\Checkout\Cart\Tax\Struct\TaxRuleCollection Object &000000007f3d77440000000061abaa6f
        'referencePrice' => null
        'listPrice' => null
        'regulationPrice' => null
        'extensions' => Array &11 ()
    )
    'good' => true
    'description' => null
    'cover' => null
    'deliveryInformation' => Shopware\Core\Checkout\Cart\Delivery\Struct\DeliveryInformation Object &000000007f3a3b9d0000000061abaa6f (
        'stock' => 10
        'weight' => 100.0
        'freeDelivery' => false
        'restockTime' => null
        'deliveryTime' => null
        'height' => 101.0
        'width' => 102.0
        'length' => 103.0
        'extensions' => Array &12 ()
    )
    'children' => Shopware\Core\Checkout\Cart\LineItem\LineItemCollection Object &000000007f3d282f0000000061abaa6f (
        'elements' => Array &13 ()
        'extensions' => Array &14 ()
    )
    'requirement' => null
    'removable' => true
    'stackable' => true
    'quantityInformation' => Shopware\Core\Checkout\Cart\LineItem\QuantityInformation Object &000000007f3d7bae0000000061abaa6f (
        'minPurchase' => 1
        'maxPurchase' => 100
        'purchaseSteps' => 1
        'extensions' => Array &15 ()
    )
    'modified' => false
    'dataTimestamp' => DateTimeImmutable Object &000000007f3d77ad0000000061abaa6f (
        'date' => '2022-06-30 08:56:09.025988'
        'timezone_type' => 3
        'timezone' => 'UTC'
    )
    'dataContextHash' => 'bf9d265b33d183a6f75f93c4b04349a6'
    'extensions' => Array &16 ()
) is null.
/builds/shopware/6/product/platform/src/Core/Content/Test/Product/Cart/ProductCartProcessorTest.php:712
phpvfscomposer:///builds/shopware/6/product/platform/vendor/phpunit/phpunit/phpunit:97
2) Shopware\Core\Content\Test\Product\Cart\ProductCartProcessorTest::testDeletedProductCartRemoval
Failed asserting that Shopware\Core\Checkout\Cart\LineItem\LineItem Object &000000007f3aa6ce0000000061abaa6f (
    'payload' => Array &0 (
        'isCloseout' => false
        'customFields' => Array &1 ()
        'createdAt' => '2022-06-30 08:56:09.246'
        'releaseDate' => null
        'isNew' => false
        'markAsTopseller' => null
        'purchasePrices' => '{"currencyId":"b7d2554b0ce847cd82f3ac9bd1c0dfca","net":5,"gross":7.5,"linked":false,"listPrice":null,"percentage":null,"regulationPrice":null,"extensions":[]}'
        'productNumber' => '8d88f9cc9b5842b6be750f9a04e2d2a8'
        'manufacturerId' => null
        'taxId' => '8f9893d953384007bf37b37121607139'
        'tagIds' => null
        'categoryIds' => null
        'propertyIds' => null
        'optionIds' => null
        'options' => Array &2 ()
        'streamIds' => null
        'parentId' => null
        'stock' => 10
        'features' => Array &3 ()
    )
    'id' => '6a526f075314413eaff4d5f2701fecfe'
    'referencedId' => '6a526f075314413eaff4d5f2701fecfe'
    'label' => 'test'
    'quantity' => 1
    'type' => 'product'
    'priceDefinition' => Shopware\Core\Checkout\Cart\Price\Struct\QuantityPriceDefinition Object &000000007f3dac740000000061abaa6f (
        'price' => 15.0
        'taxRules' => Shopware\Core\Checkout\Cart\Tax\Struct\TaxRuleCollection Object &000000007f3a00560000000061abaa6f (
            'elements' => Array &4 (
                15 => Shopware\Core\Checkout\Cart\Tax\Struct\TaxRule Object &000000007f3cd4d70000000061abaa6f (
                    'taxRate' => 15.0
                    'percentage' => 100.0
                    'extensions' => Array &5 ()
                )
            )
            'extensions' => Array &6 ()
        )
        'quantity' => 1
        'isCalculated' => true
        'referencePriceDefinition' => null
        'listPrice' => null
        'regulationPrice' => null
        'extensions' => Array &7 ()
    )
    'price' => Shopware\Core\Checkout\Cart\Price\Struct\CalculatedPrice Object &000000007f3ae1730000000061abaa6f (
        'unitPrice' => 15.0
        'quantity' => 1
        'totalPrice' => 15.0
        'calculatedTaxes' => Shopware\Core\Checkout\Cart\Tax\Struct\CalculatedTaxCollection Object &000000007f3a93590000000061abaa6f (
            'elements' => Array &8 (
                15 => Shopware\Core\Checkout\Cart\Tax\Struct\CalculatedTax Object &000000007f3d7bac0000000061abaa6f (
                    'tax' => 1.96
                    'taxRate' => 15.0
                    'price' => 15.0
                    'extensions' => Array &9 ()
                )
            )
            'extensions' => Array &10 ()
        )
        'taxRules' => Shopware\Core\Checkout\Cart\Tax\Struct\TaxRuleCollection Object &000000007f3a00560000000061abaa6f
        'referencePrice' => null
        'listPrice' => null
        'regulationPrice' => null
        'extensions' => Array &11 ()
    )
    'good' => true
    'description' => null
    'cover' => null
    'deliveryInformation' => Shopware\Core\Checkout\Cart\Delivery\Struct\DeliveryInformation Object &000000007f3af4590000000061abaa6f (
        'stock' => 10
        'weight' => 100.0
        'freeDelivery' => false
        'restockTime' => null
        'deliveryTime' => null
        'height' => 101.0
        'width' => 102.0
        'length' => 103.0
        'extensions' => Array &12 ()
    )
    'children' => Shopware\Core\Checkout\Cart\LineItem\LineItemCollection Object &000000007f3aa1fc0000000061abaa6f (
        'elements' => Array &13 ()
        'extensions' => Array &14 ()
    )
    'requirement' => null
    'removable' => true
    'stackable' => true
    'quantityInformation' => Shopware\Core\Checkout\Cart\LineItem\QuantityInformation Object &000000007f3a86460000000061abaa6f (
        'minPurchase' => 1
        'maxPurchase' => 100
        'purchaseSteps' => 1
        'extensions' => Array &15 ()
    )
    'modified' => false
    'dataTimestamp' => DateTimeImmutable Object &000000007f3a90eb0000000061abaa6f (
        'date' => '2022-06-30 08:56:09.426624'
        'timezone_type' => 3
        'timezone' => 'UTC'
    )
    'dataContextHash' => 'bf9d265b33d183a6f75f93c4b04349a6'
    'extensions' => Array &16 ()
) is null.

@J-Rahe were as in "past" ? I can not reproduce this error, can you please help me out here, we do have hundreds of those broken orders.

Thx @Isengo1989 your changes were merged! :blue_heart:


ip classification: <IP_ADDRESS> is not recognized as expected

Actual: unrecognized
Expected: Crawler

Ha. Only test was wrong. No bug here


Testsuite fixes

In Chrome 17.x two tests fail due to mixed precision when compairing numerical values.

@marcjansen you're the kind, I'll take a look.

see also #161 and #162

As of  67ea250 there are still 6 tests failing in Firefox 10.0.1 on Linux:

Layer/GeoRSS.html: fail 3 ok 8 (detailed: fail 1 ok 23)

test_Layer_GeoRSS_AtomParsing planned 6 assertions but got 3; fail 1 ok 2
test_Layer_GeoRSS_popups planned 4 assertions but got 0; fail 0 ok 0
test_Layer_GeoRSS_resizedPopups planned 4 assertions but got 0; fail 0 ok 0

Layer/Text.html: fail 2 ok 6 (detailed: fail 0 ok 31)

test_Layer_Text_overflow planned 4 assertions but got 0; fail 0 ok 0
test_Layer_Text_events_nopopups planned 4 assertions but got 0; fail 0 ok 0

Map.html: fail 1 ok 55 (detailed: fail 1 ok 313)

test_panTo fail 1 ok 5

Tween.html: fail 1 ok 2 (detailed: fail 3 ok 7)

test_Tween_start fail 3 ok 2

deprecated/Layer/MapServer.html: fail 1 ok 0 (detailed: fail 2 ok 3)

test_Layer_MapServer_Reproject fail 2 ok 3

deprecated/Layer/WMS.html: fail 1 ok 0 (detailed: fail 2 ok 3)

test_Layer_WMS_Reproject fail 2 ok 3

I can confirm that the Control.OverwiewMap, Format.WKT and Strategy.BBOX tests now pass in FF 10, Chrome, and IE 8. Thanks a lot for fixing that @marcjansen. Please merge.
FYI, we have more failing tests, see #249. I'd happily use some help to make all tests pass again.


Adds the improved Russian translation to article

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@egarnaga Excellent! Could you correct the translation in the text of the tests? Thanks for your help!

This PR was closed and then re-opened in an attempt to clear a specific Travis build failure.

LGTM 👍 :dart:
Thank you for the PR ✨ 🎉
We're happy to accept these changes and look forward to your future contributions :clap:
Happy coding! :octocat:


The documentation feels incomplete

This library could use some more documentation to make it more clear on how to use stores to retrieve data from objects.

Hi @Mys7erio,
Was there something specific you running into.
I tried to balance keeping docs short, so people don't have to read a lot.
Maybe the repo should have example code? Would that be helpful?

Yes, more code showing how to retrieve data would be a nice addition to the documentation.  If added, it would help people who were in the same situation as me.
I was trying to access the attribute of an object but I wasn't able to. It took me some time but I eventually figured out how to do it.

I feel the Readme is already showing how to read from stores. Since the API is identical to all Svelte stores, I hesitate to make people read docs when nothing's different.
I'm going to close the issue for now, but if I hear more requests about docs, I'll definitely revisit this decision.


Switch View looks cut on my android(4.4.2).

Dive into the component's index.js in node_modules and change the padding set in the constructor:
this.padding = 6 // was originally 2

Did the trick for me, although I've only checked the results on one Android device and with my own custom switch:
<Switch
    buttonRadius={10}
    switchHeight={12}
    switchWidth={32}
   ...
  />

Yes, padding increase works only for this or similar setup.
For permanent fix (or I hope it is, tested on various dimensions), in node_modules.intex.js change:
parent View that starts on line 201, in his style add:
            marginTop: this.props.buttonRadius/2,
            marginLeft: this.props.buttonRadius/2,

modify TouchableHighlight's width like so:
           width: this.props.switchWidth+doublePadding+this.props.buttonRadius,(add '+this.props.buttonRadius' to it)
and modify Animated.View's top and lett absolute values like so:
              top: halfPadding + this.props.switchHeight/2 - this.props.buttonRadius/2,
              left: this.props.switchHeight/2 > this.props.buttonRadius ? halfPadding : halfPadding + this.props.switchHeight/2 - this.props.buttonRadius/2,

(basically just add '/2' to the end.
this makes the switch travel area and the button circle centered instead of starting in the top left corner and should solve this issue. Since I'm new to the github mechanics of forking and pull requests and mostly lazy (:D), could someone who is working actively on this project test it out and introduce the changes? cheers


Make ReconstructionProperties into a Flag enum to support same reconstructor providing many properties

A first start at addressing the need in #2291 of a reconstructor indicating it reconstructs many properties.
I changed  ReconstructionProperties into a enum of Flag type, meaning a reconstructor can say it provides both geometry and particle type by setting
self.property = ReconstructionProperty.ENERGY | ReconstructionProperty.PARTICLE_TYPE
It is also possible to pick out a list of properties a reconstructor supports given a flag combination in self.property using this (slightly unreadable) list comprehension
        properties = [
            self.property & itm
            for itm in self.supported
            if self.property & itm in ReconstructionProperty
        ]

Do we really want a FlagEnum that is using binary operations to store the values instead of just a tuple of the enum like we e.g. do for DataLevel?
What is the advantage of using FlagEnum?

I didn't think of using a tuple of enums, compared with that case I'm not sure there is any benefit. I can change it.

@maxnoe You can't properly do it with an tuple, because the StereoCombiner takes the properties via traitlets and traitlets only support type checking fixed length tuples. But traitlets can typecheck variable size sets, so I used that instead.
However, I realised that the assumption that a reconstructor only does one thing seems to be pretty deeply encoded in the predict_table functions via assumptions about the prefix used to name columns, and I don't have a good idea for how to resolve that.


.repeat double posting, and ending up unable to be disabled.

On our server, I was setting a notification to be played in our general chat every 2.5 hours, containing a link to a Google Fomrs poll we were taking responses to over the week. I messed something up in the posting message, and resubmitted the command. Lo and behold, Nadeko was now posting the repeated message twice, with the difference in time equal to the amount of time it took for me to repost the edited message.
Not quite sure how it happened, as we were unable to replicate the circumstances, but I'll outline the gist of what happened before the issue.

The repeat command that posted first was accidentally posted in another channel, while a repeat was running in our general chat. Nadeko logged that the message would be posted to the general chat, despite being in a different room.
A .repeat was issued in that self-same room to cancel what we thought was a simple mistake fix.
The repeat command, with a message beginning with an @here, was issued in our general chat to begin the loop.
Upon realizing that @here mentions fail to work in repeat messages, (It is unsure whether we issued a stop .repeat command or not) a .repeat command with the @here removed was issued, again, for 150 minutes.

Once we noticed the issue, .repeat commands were issued naked in every channel to try to resolve the issue, but a .repeatinvoke returns with the claim that there are no repeats programmed to occur. Since we're using a clone from https://www.carbonitex.net/Discord/bots , we don't have access to .unstuck, and .restart doesn't terminate .repeat messages.
I'm currently in the painstaking process of setting up a personal clone for the server that we'll instate once the poll closes (since really, it isn't an issue until we don't want the repeats there), and since there's no option to set command/module permissions for a range of roles, I'll have to enter another 170-some-odd commands. I love the bot, and appreciate the help that you might be able to give that will save me the process.

I fixed the issue by deleting and remaking the channel, but it'd be nice to figure out why it happens so it can be fixed/so we don't accidentally do it again.

I think this is fixed in one of the recent commits by dragon (a guy who's helping). Global Nadeko is not on that release yet.


Speakers

i can take this up

i want to take this up!

i want to take this up

i want this

i can take this up

I want to try this out

I would like to take this up

I will work on it

I will work on it

I would like to take this issue

I can work on this

I want to take this issue

I can work on this

I want to work on this.

I would like to take this up!!

I want to take this issue

i want to work

i would like to take up this issue

i want to take it

I would like to take this issue


split some long lines in many

Yeah, you are right, I have corrected the lines commented!

Great, thanks a lot!

Hello @AlessandroMinoccheri, i create a fork of this repo and release this changes into the new version(6.4.0).
Namespace compatibility is 100%, and you can use my changes

replace "guzzlehttp/guzzle": "^6.3" to "someblackmagic/guzzle": "^6.4"
add "guzzlehttp/guzzle": "6.3.*" into replace block in your composer.json

Fork link: https://github.com/SomeBlackMagic/guzzle/


feat: move from a toml hugo config to a yaml one

Moving to YAML config for Hugo instead of TOML as Docsy itself has moved. This PR will also be a blocker for #531 as this change will be removed from that PR and rebased.
Reference comment by @sftim

I would make the move to YAML be its own separate PR.

Wow, thanks!
Netlify preview looks good, what could this break that wouldn't be immediately obvious, if anything?

I don't think anything would break as I have converted the TOML to YAML verbatim including the comments.

/approve
/lgtm


scikit-image release breaks qtt

Scikit-image 0.17 was released with some non-backwards compatible changes to peak_local_max (https://github.com/scikit-image/scikit-image/pull/4501). The qtt tests are broken, and probably the functionality as well.
@QFer @sldesnoo-Delft

The unit tests that used peak_local_max result didn't take into account that the order of peak_local_max is not defined. The same peaks were found but were returned in a different order in the new version.


Process Selected Rows not working with Apex 21.1

Browser: Chrome, Edge, Firefox
Plugin version: 20.2.0
Apex version: 21.1.0
Action Process Selected Rows is not working with this APEX version
Action Process Filtered Rows is working properly

As a temporary workaround please edit the plugin and add a COMMIT statement after line 332 in the plugin PLSQL i.e. after "apex_exec.close(l_context);"
This will be included in the FOS 21.1 release which will be released soon.

Fixed in just published v21.1.0

Looks like this is broken again in 22.2. PL/SQL Code is called for each row not only the selected rows.


seeing jobs in pods section

Describe the bug
I am seeing jobs in pods section is this expected. correct me if I am wrong
please find the screenshot

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Lens Version:3.4.0
OS:ubuntu 20.04
Installation method (e.g. snap or AppImage in Linux):

Logs:
When you run the application executable from command line you will see some logging output. Please paste them here:
Your logs go here...

Kubeconfig:
Quite often the problems are caused by malformed kubeconfig which the application tries to load. Please share your kubeconfig, remember to remove any secret and sensitive information.
your kubeconfig here

Additional context
Add any other context about the problem here.

May be this is the reason.
$ kubectl get pods -n istio-system
NAME                                      READY   STATUS      RESTARTS   AGE
grafana-6bb6bcf99f-4hjkc                  1/1     Running     0          52m
istio-citadel-688696f77f-fj628            1/1     Running     0          52m
istio-egressgateway-747bd76fdf-rt64b      1/1     Running     0          52m
istio-galley-78d7c776f6-nb2c8             1/1     Running     0          52m
istio-grafana-post-install-1.5.1-k8jfx    0/1     Completed   0          52m
istio-ingressgateway-76b4c5c8cd-lc8tw     1/1     Running     0          52m
istio-pilot-57b569c8fd-sq86x              2/2     Running     3          52m
istio-policy-67597856b-rm2fs              2/2     Running     4          52m
istio-security-post-install-1.5.1-tkpzc   0/1     Completed   0          52m
istio-sidecar-injector-7c84db86f4-87hfz   1/1     Running     0          52m
istio-telemetry-6c8c5b7fbc-rx7k6          2/2     Running     4          52m
istio-tracing-7bdc6f8867-hbbcs            1/1     Running     0          52m
kiali-7b5c8f79d8-q7ltv                    1/1     Running     0          52m
prometheus-74d8b55f54-t6x5m               1/1     Running     0          52m

Don't see the actual issue here. Based on screenshot and kubectl output everything seem to be correct. Those pods are created by Job and should be visible on pods list. Please reopen and elaborate if there's a real issue.


[dv/rstmgr] Address TODO about lint configuration

Partially adresses #17915

This was part of https://github.com/lowRISC/opentitan/pull/18259, moved here to increase granularity.


Some of the download links return a 404 not found.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ddbbbdfb-c916-be79-2a91-5576d58a30e1
Version Independent ID: 793f2f73-6fbc-04e5-fa8a-54908d74d860
Content: Microsoft 365 productivity illustrations
Content Source: microsoft-365/solutions/productivity-illustrations.md
Product: microsoft-365-enterprise
GitHub Login: @samanro
Microsoft Alias: samanro

@shung818 Thank you for your feedback. I was able to download PDF from all the downloadable links in the document. Could you please check and provide the link that is returning a 404 error?
Thanks
Sri

Hello Sri,
I had just checked today and they all are valid with no errors.
Thanks for checking in, I can relay this to my customer who had brought up the issue.
From: Sriraman M S @.>
Sent: Tuesday, May 25, 2021 7:44 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Sharilyn Ung @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Some of the download links return a 404 not found. (#5038)
@shung818https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshung818&data=04|01|Sharilyn.Ung%40microsoft.com|494a3132b61c4f449b0108d91f7267d7|72f988bf86f141af91ab2d7cd011db47|1|0|637575398511775659|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=61Bc36WDTR26WAaphiRIgd8gLTDDgepnx%2FbgecpD9oM%3D&reserved=0 Thank you for your feedback. I was able to download PDF from all the downloadable links in the document. Could you please check and provide the link that is returning a 404 error?
Thanks
Sri

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F5038%23issuecomment-847798936&data=04|01|Sharilyn.Ung%40microsoft.com|494a3132b61c4f449b0108d91f7267d7|72f988bf86f141af91ab2d7cd011db47|1|0|637575398511785655|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=x%2FGjwmRDWWkIUupR9xGiO7KKXgTGdWrMT2wanx0KoLY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUEAN5OZUHN3WPCHUSAAU5TTPOEQPANCNFSM45DFMZRA&data=04|01|Sharilyn.Ung%40microsoft.com|494a3132b61c4f449b0108d91f7267d7|72f988bf86f141af91ab2d7cd011db47|1|0|637575398511795647|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=khwZOqkbMdi%2BiNy9uYUKMEZzzaJxh4fOxO3doqWugh8%3D&reserved=0.

@shung818  Thank you for the update.
@yogkumgit  There are no changes required in the document.
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @shung818 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Ansible prepare step of imported plan does not work

When you use import plan feature [1] and the imported plan has one of prepare steps implemented via Ansible, the execution fails, because it can not find the playbook. E.g.:
ERROR! the playbook: /var/ARTIFACTS/git-masternbv9uido/ansible/setup_to_run_leapp.yml could not be found
[1] https://tmt.readthedocs.io/en/stable/spec/plans.html#import-plans

I found out, that commenting out  _ansible_playbook_path at https://github.com/teemtee/tmt/blob/main/tmt/steps/provision/init.py#L1474 fix this issue and does not break use case when the imported plan is run directly.


Helper functions

functions to add together/merge columns across offences by the month/for the year/total, but still separated by borough.

I think the addition of MultiIndex solves this - it makes these kinds of operations fairly trivial with pandas

Yes...


MD format not completely rendering

Describe the Bug
A MD page created with code from the following example: https://raw.githubusercontent.com/fullpipe/markdown-test-page/master/test-page.md does not render all elements correctly.
Steps to Reproduce

Get raw code from https://raw.githubusercontent.com/fullpipe/markdown-test-page/master/test-page.md
Create a new page with md editor
Save and view page

Expected Behaviour
It should render the md file as shown at https://gist.github.com/rt2zz/e0a1d6ab2682d2c47746950b84c0b6ee
Screenshots or Additional Context
No response
Browser Details
Firefox 119.0.1
Exact BookStack Version
v23.10.2

Hi @Stump8743,
I'm not quite sure what's rendering incorrectly.
That input content and example render link are two quite different documents.
Either way, in BookStack we support commonmark plus a few extensions including tables and tasklists.
Outside of that, there may be indeed differences in supported syntax and behaviour.

Since there's been no further follow-up to the above I'll go ahead and close this off.


New version: Alibaba.aDrive version 6.3.2

Created by 🥟 Dumplings in workflow run #7857.

Log
Updated: 6.2.0 → 6.3.2
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Action bar randomly deletes your actions and will "reorganize" your inventory as a result

Unable to properly reproduce as this seems to happen without warning/indication and about 1-3 times a round. Cannot find what triggers it. If this happens to me again I will attempt to capture a recording of it

Play game as normal
If an action is custom(such as storage implant and helmet toggle), might notice that its gone. Only the defaults such as scream, combat mode toggle, etc remain.
This also results in your inventory being reorganized. For example, my belt in one round had all its items shuffled. It is only when I put one of my tools back in the belt that everything moved back to their original places.

I have a feeling this might be related to the "random death" bug, but it's just a guess.
Using command "resetallents" fixed it, similar to fixing the death bug.
Edited for further clarity.

#20483 ??

I can verify that inventory strangeness is itself an issue, and I believe it didn't happen alongside actions being removed. It's probably the same root cause overall though, especially if resetallents can fix the bugged inventory.

The inventory getting bugged out issue has been happening to me, quite annoying. To a lesser extend the actions being removed bug likewise. both issues tend to happen after I have had been playing for a while.

As far as we understand at Corvax, this is partly due to the sound system. If there are too many sources, then things in the inventory, walls, and the action panel begin to disappear. I was also almost shot by sec because I was not visible to them and seemed to appear out of thin air.

recently im getting openal errors saying out of memory and slowly all the sounds stop playing (swap was being ravaged at the time but it still shouldnt say out of memory or the whole thing would crash probably)

As far as we understand at Corvax, this is partly due to the sound system. If there are too many sources, then things in the inventory, walls, and the action panel begin to disappear. I was also almost shot by sec because I was not visible to them and seemed to appear out of thin air.

Does anyone have any logs that it's state handling failing elsewhere or is this spitballing.

Also this is the same bug yeah.


Add support for collector to be able to run on nodes with taints

Can support be added so that the collector can run even on nodes with taints set.
This would be useful because I have a workload that runs on a node-pool that has taints on it, but I want to be able to collect metrics from the pods running on it.
Let me know if there is something that I am missing that would currently allow this.

Hello,
This should be possible already with the current tolerations to the collector daemonset. Is this not working for you?


Lf drug issue665

This PR addresses points in issue opentargets/platform#665 about known drugs charts:

set container overflow to visible to show otherwise truncated labels
set piecharts segments stroke to white (so segments appear separated by space)
set piecharts segments to have different colours (shades of blue, starting from current light blue)

Applied style to cancer biomarkers charts as well for consistency


Epic: Timeline Performance

Epic tracking work to improve timeline rendering performance. Goal is to make the the Clipper TT-6 plan usable.
### Tasks
- [ ] https://github.com/NASA-AMMOS/aerie-ui/pull/1009
- [ ] https://github.com/NASA-AMMOS/aerie-ui/pull/1017
- [ ] https://github.com/NASA-AMMOS/aerie-ui/pull/1016
- [ ] https://github.com/NASA-AMMOS/aerie-ui/pull/1049
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/959
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/1023
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/1051
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/294
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/613
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/1069

I created another mega ticket thats related to performance but more focused on usability: https://github.com/NASA-AMMOS/aerie-ui/issues/1167


Migration Log

This is an auto-generated issue. The migration log is in the following comment(s).

Log Chunk 1
[2024-05-20T07:19:27Z] INFO -- Migration started by shubhajyoti-bagchi-groww from https://github.com/GrowwOld/google-signin to Groww-OSS/google-signin
[2024-05-20T07:19:27Z] INFO -- Migration ID: f902a3a9-bfa3-4864-a16b-5aa260467efa
[2024-05-20T07:19:27Z] INFO -- -----------------------------
[2024-05-20T07:19:27Z] INFO -- Git source migration started
[2024-05-20T07:23:38Z] INFO -- Git source migration completed
[2024-05-20T07:23:38Z] INFO -- -----------------------------
[2024-05-20T07:23:38Z] INFO -- Extraction started
[2024-05-20T07:23:43Z] INFO -- Extraction complete
[2024-05-20T07:23:43Z] INFO -- -----------------------------
[2024-05-20T07:23:43Z] INFO -- Transformation started
[2024-05-20T07:23:52Z] INFO -- Transformation complete
[2024-05-20T07:23:52Z] INFO -- -----------------------------
[2024-05-20T07:23:52Z] INFO -- Import started
[2024-05-20T07:23:53Z] WARN -- 'Allow Forking' setting could not be enabled for the repository because it is not enabled at the organization level.
[2024-05-20T07:24:05Z] INFO -- Import complete
[2024-05-20T07:24:05Z] INFO -- -----------------------------
[2024-05-20T07:24:05Z] INFO -- Migration complete
[2024-05-20T07:24:05Z] INFO -- -----------------------------


Add contents in footer

Add information or links in the footer, after BCAP Smile.

A ‘© 2021 Barry Cap’ can now be added in the footer, since the website is under the MIT license.

Done!


Use std::optional instead of raw pointer to optionally store raft handle

This problem would have been introduced if we merged #63 as part of 21.06, but since we've deferred to 21.07, let's just fix it in the PR. I'll close this for now, and we can re-open if we decide that that's really not viable.


radio-group component has error in form，when I use ngModel instead of FormControl

Version
1.1.1
Environment
OS:Windows 10    Browser:Chrome
Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-setup-fjfmmp
Steps to reproduce
Using ngModel instead of FormControl in form
What is expected?
I want to use the ngModel to bind the value of the radio-group, but I don't want to use FormControl
What is actually happening?
The Angular has ran an error
Other?

I'm sorry,I misunderstood the nzName attribute,thanks very much


Expose Block#getItem to allow plugins to get the proper ItemStack for a location

Block#getItem is used by the pick block mechanic, in order to preserve the damage value and NBT, as necessary, for the block being picked. We should expose this through a Property of some sort, to allow plugins to properly reconstruct an ItemStack from a block.
Note that the underlying method requires a World, BlockPos, and an IBlockState. We'll probably want to expose this through BlockSnapshot in some way, since it contains the required data to call the method.

BlockSnapshot actually may not have the data...Location is Optional in it.
Also:
https://github.com/SpongePowered/SpongeAPI/blob/bleeding/src/main/java/org/spongepowered/api/block/BlockType.java#L71

@Zidane: That method is different - it just uses the default itemstack, and can't take into account damage or NBT. I suppose we could provide an overload that takes in a Location and a BlockState, but that doesn't really seem to fit with our property/data system for getting block information.

Could the method just return Optional<ItemStack> since Location is also an Optional in BlockSnapshot?


Range field imported incorrectly for studies with no OR or Beta

This bug concerns associations imported into the curation interface from deposition.
For associations with no effect size (i.e. no Odds ratio or Beta), the Range column should be empty. In Chibnik LB 28322283, it is incorrectly being filled with “[0.0-null]”.

Tested in snoopy:9680 - this is now fixed.


simplify example

coverage: 98.768% (-1.2%) from 100.0% when pulling ad72fff125dde59f359731f722a1e12943141814 on target-param into 8bbaaab5be7e51a66ed149b52640451a888c107b on main.


Automerge dependabot PRs

Codecov Report

Merging #69 (4c29ff0) into master (fae40ed) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   87.33%   87.33%
=======================================
  Files          11       11
  Lines         892      892
=======================================
  Hits          779      779
  Misses         74       74
  Partials       39       39


Dedicated class for container addresses

Fixing issue #360

This is ready to merge when green.

Fixing #149

Will get this into master now, even though the image deletion is broken now. We can fix that in another PR.


Change User-Agent from faraday's default one to Weneedfeed

To resolve https://github.com/r7kamura/weneedfeed/issues/44.

@captn3m0 Would this work for your situation?
This Pull Request would change the User-Agent like this:
# Before
User-Agent: Faraday v1.10.0

# After
User-Agent: Weneedfeed

Validated, this works nicely.

Released v0.20.0 💎 ✨

https://rubygems.org/gems/weneedfeed/versions/0.20.0
https://github.com/r7kamura/weneedfeed/releases/tag/v0.20.0


Init virtio-mmio devices with custom register + irqnum

Init virtio-mmio devices from a list of 'slots' - pairs of address and irq number which we'll get from dtb
(This doesn't work yet, hence draft)
In add_virtio_mmio_devices, the mmio memory is reserved with the system allocator using allocate_platform_mmio_addresses() - because CLH normally allocates virtio devices in the 'platform device' area, above regular ram.
But, the virtio addresses we need to use, from the ARE device tree, are not in that area - they're below the ram, so the allocate fails.
So we need to get around this somehow, and it's not as simple as nudging the hardcoded layout around like before; we want to allocate the virtio devices in a completely different area than originally intended by CLH...
Simplest solution might be to change the add_virtio_mmio_code to try and allocate in platform device region, and if that fails, try mmio hole region (below ram), which would then succeed. I might try that and see if I run into anything else...

FAOD I will wait for your ping to have a closer look.


Cannot change MH_SMTP_BIND_ADDR

Hello,
I've set up a MailHog container using docker compose using the following configuration:
version: "3.8"
services:
  mailhog:
    image: mailhog/mailhog:latest
    container_name: MailHog
    environment:
      - TZ='America/Chicago
    ports:
      - 1025:1025/tcp
      - 8025:8025/tcp
    volumes:
      - type: bind
        source: /data/mailhog
        target: /data/mailhog
    restart: unless-stopped

I noticed when running docker-compose up, it states that the SMTP address is bound to address <IP_ADDRESS>:1025. I need to bind it to the hostname of the VM that MailHog is running on so that I can connect to it from apps running on separate VMs. However, whenever I set the MH_SMTP_BIND_ADDR environment variable, per https://github.com/mailhog/MailHog/blob/master/docs/CONFIG.md, and run docker-compose up, the container fails stating port 1025/tcp is an unknown port. Any idea why this is?

By using
environment:
  - MH_SMTP_BIND_ADDR=<IP_ADDRESS>:25

I could set the bind-addr in my docker-compose file.
In your example, I can't see how you are trying to set the MH_SMTP_BIND_ADDR environment variable, so not sure what is wrong

By using
environment:
  - MH_SMTP_BIND_ADDR=<IP_ADDRESS>:25

I could set the bind-addr in my docker-compose file.
In your example, I can't see how you are trying to set the MH_SMTP_BIND_ADDR environment variable, so not sure what is wrong

Turns out the actual problem I'm having is unrelated to what I had mentioned. So, the reason I was getting the error above is because I had single quotes wrapped around the <IP_ADDRESS>:1025 in the docker-compose file. However, the actual problem I'm having - that I thought I could fix by setting MH_SMTP_BIND_ADDR manually - is when setting up a Nodemailer transport on a separate VM that's not running MailHog, the only way I can send an email successfully is when I use the IP address of the host running MailHog. However, rather than using the actual IP address, I'd like to be able to use the domain name that I have configured in my DHCP server. For example, I'm trying to connect to production1.localhost.com:1025 rather than <IP_ADDRESS>:1025, for example. I figured if I could change MH_SMTP_BIND_ADDR to production1.localhost.com:1025, it would route correctly, however, that does not appear to be the case.


Redundant Openflow messages are sent when syncing an updated group to OVS

Describe the bug
For example, when syncing an ClusterIP Service whose Endpoints has been changed,
Function in the following is called in pkg/agent/openflow/client.go, we can see that variable group is returned by serviceEndpointGroup , then call the method Add() to sync the group to OVS.
func (c *client) InstallServiceGroup(groupID binding.GroupIDType, withSessionAffinity bool, endpoints []proxy.Endpoint) error {
	c.replayMutex.RLock()
	defer c.replayMutex.RUnlock()

	group := c.featureService.serviceEndpointGroup(groupID, withSessionAffinity, endpoints...)
	if err := group.Add(); err != nil {
		return fmt.Errorf("error when installing Service Endpoints Group: %w", err)
	}
	c.featureService.groupCache.Store(groupID, group)
	return nil
}

We can see the code of method Add() in pkg/ovs/openflow/ofctrl_group.go:
func (g *ofGroup) Add() error {
	return g.ofctrl.Install()
}

We can see the the method Install() of g.ofctrl in lib ofnet https://github.com/antrea-io/ofnet/blob/716e8ccd4ba3713d3b38ff2f808e698749d9de79/ofctrl/fgraphGroup.go#L76
func (self *Group) Install() error {
	command := openflow15.OFPGC_ADD
	if self.isInstalled {
		command = openflow15.OFPGC_MODIFY
	}
	groupMod := self.getGroupModMessage(command)

	if err := self.Switch.Send(groupMod); err != nil {
		return err
	}

	// Mark it as installed
	self.isInstalled = true

	return nil
}

However, in serviceEndpointGroup which is used to generate group in /pkg/agent/openflow/pipeline.go, we can see that when adding a new bucket, then Done() is called.
func (f *featureService) serviceEndpointGroup(groupID binding.GroupIDType, withSessionAffinity bool, endpoints ...proxy.Endpoint) binding.Group {
	group := f.bridge.CreateGroup(groupID).ResetBuckets()
	var resubmitTableID uint8
	if withSessionAffinity {
		resubmitTableID = ServiceLBTable.GetID()
	} else {
		resubmitTableID = EndpointDNATTable.GetID()
	}
	for _, endpoint := range endpoints {
		endpointPort, _ := endpoint.Port()
		endpointIP := net.ParseIP(endpoint.IP())
		portVal := util.PortToUint16(endpointPort)
		ipProtocol := getIPProtocol(endpointIP)

		if ipProtocol == binding.ProtocolIP {
			ipVal := binary.BigEndian.Uint32(endpointIP.To4())
			group = group.Bucket().Weight(100).
				LoadToRegField(EndpointIPField, ipVal).
				LoadToRegField(EndpointPortField, uint32(portVal)).
				ResubmitToTable(resubmitTableID).
				Done()
		} else if ipProtocol == binding.ProtocolIPv6 {
			ipVal := []byte(endpointIP)
			group = group.Bucket().Weight(100).
				LoadXXReg(EndpointIP6Field.GetRegID(), ipVal).
				LoadToRegField(EndpointPortField, uint32(portVal)).
				ResubmitToTable(resubmitTableID).
				Done()
		}
	}
	return group
}

We can see the code in Done() in /pkg/ovs/openflow/ofctrl_group.go, AddBuckets is called.
func (b *bucketBuilder) Done() Group {
	b.group.ofctrl.AddBuckets(b.bucket)
	return b.group
}

AddBuckets is defined in lib ofnet https://github.com/antrea-io/ofnet/blob/716e8ccd4ba3713d3b38ff2f808e698749d9de79/ofctrl/fgraphGroup.go#L58:
func (self *Group) AddBuckets(buckets ...*openflow15.Bucket) {
	if self.Buckets == nil {
		self.Buckets = make([]*openflow15.Bucket, 0)
	}
	self.Buckets = append(self.Buckets, buckets...)
	if self.isInstalled {
		self.Install()
	}
}

We can see that if self.isInstalled is true (this means that when updating the group), Install() is called.
Take a simple example, when syncing a updated Service which has 3 Endpoints,  there are

Message to install the corresponding group which has bucket 0 (triggered by Done() to generate bucket 0)
Message to install the corresponding group which has bucket 0, 1 (triggered by Done() to generate bucket 1)
Message to install the corresponding group which has bucket 0, 1, 2 (triggered by Done() to generate bucket 2)
Message to install the corresponding group which has bucket 0, 1, 2 (triggered by Add() to install the group)

Only the last Openflow is needed when syncing an updated group to OVS.  To fix the issue, the code in Done() could be:
func (b *bucketBuilder) Done() Group {
	b.group.ofctrl.Buckets = append(b.group.ofctrl.Buckets, b.bucket)
	return b.group
}

@hongliangl nice catch!


Repeat steps and meaningless steps in this doc

This article has repeat part. Th purpose to upload Service Provider metadata file is to get the reply URL but to get Service Provider metadata file,we have to input reply URL first. So it's meaningless to upload Service Provider metadata file to AAD. It makes our end user very confused.
Please update is ASAP, thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c206e955-bb5b-0707-5cf5-7b29cdf0ff6e
Version Independent ID: f00eff35-9f21-ea45-45a6-eba4be4fda04
Content: Tutorial: Azure Active Directory integration with Salesforce Sandbox
Content Source: articles/active-directory/saas-apps/salesforce-sandbox-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@JenifferKiki Thanks for the feedback. We will engage the content development team for further investigation, they will verify and perform necessary changes in the document as needed.

Resolving the issue.
#please-close


Empty strings in CSV files aren't being interpreted as null when using a Dictionary(_, Utf8)

Describe the bug
Related to #7797
Empty strings in CSV files aren't being interpreted as null when using a Dictionary(_, Utf8)
To Reproduce
Create a simple input.csv file like this:
id,name
1,
2,bob

Run the following code:
#[tokio::main]
async fn main() -> Result<(), DataFusionError> {
    let ctx = SessionContext::new();

    let format = CsvFormat::default();
    let listing_options = ListingOptions::new(Arc::new(format));
    ctx.register_listing_table(
        "input",
        "input.csv",
        listing_options.clone(),
        Some(Arc::new(Schema::new(vec![
            Field::new("id", DataType::Utf8, false),
            Field::new(
                "name",
                DataType::Dictionary(Box::new(DataType::UInt8), Box::new(DataType::Utf8)),
                true,
            ),
        ]))),
        None,
    )
    .await?;

    let results = ctx
        .table("input")
        .await?
        .filter(col("name").is_not_null())?
        .collect()
        .await?;

    let pretty_results = arrow::util::pretty::pretty_format_batches(&results)?.to_string();

    println!("{}", pretty_results);

    Ok(())
}

Expected behavior
I was expecting the output to look like this:
+----+------+
| id | name |
+----+------+
| 2  | bob  |
+----+------+

But the full dataset is returned instead:
+----+------+
| id | name |
+----+------+
| 1  |      |
| 2  | bob  |
+----+------+

Additional context
Tested on v41.0.0
Replace DataType::Dictionary(Box::new(DataType::UInt8), Box::new(DataType::Utf8)) with DataType::Utf8 and it works.

take

@alamb shouldn't the csv reader also throw an error because "bob" is not a valid dictionary?

I agree the discrepancy between UTf8 and Dictionary looks like a bug

@alamb shouldn't the csv reader also throw an error because "bob" is not a valid dictionary?

I think "bob" is a valid value for a DictionaryArray (whose values are Strings)

@alamb before I file an issue to arrow-csv, why is "bob" a valid value for DictionaryArray? don't you need a key and a value for a dictionary?

@alamb before I file an issue to arrow-csv, why is "bob" a valid value for DictionaryArray? don't you need a key and a value for a dictionary?

I think a more precise version of this would be "bob" is a valid value for DictionaryArray(Int32, Utf8) -- that is if the dictionary's value type is strings (Utf8) then the dictionary should be able to hold string values

@alamb I have a reproducer on Arrow CSV, see this https://github.com/apache/arrow-rs/compare/main...edmondop:arrow-rs:datafusion-12041?expand=1
However, I don't know if we should change the behavior of the Arrow CSV reader to return null for empty nullable dictionaries, I filed https://github.com/apache/arrow-rs/issues/6821 to track the discussion

Pending https://github.com/apache/arrow-rs/pull/6830 merge and release in upstream arrow-rs dependency


CARDS-2199: As a clinician, I can see on the DATA-PRO clinician dashboard whether surveys have been emailed to a patient prior to their appointment

[x] CARDS-2227: PROMs-specific Survey events questionnaire
[x] CARDS-2201: Augment the Visit information json with the timestamps when notification emails were sent from Survey events
[x] CARDS-2202: Update the Appointments dashboard widget to display whether survey links had been sent to the patient
[x] CARDS-2200: Enable the Survey Tracker in proms

To test proms:

on branch CARDS-2200-test build with mvn clean install -Pdocker
in compose-cluster/mssql run python3 generate_test_proms_sql.py --time_spread_minutes 4320 -n 30 proms_sample.sql, check that there are events for tomorrow and 3 days from now, and if not, rerun the script
in compose-cluster run python3 generate_compose_yaml.py --mssql --cards_project cards4proms --oak_filesystem --dev_docker_image --smtps --smtps_test_container --smtps_test_mail_path ~/cardsmail --composum --adminer --clarity
edit docker-compose.yml and add NIGHTLY_NOTIFICATIONS_SCHEDULE=0 * * * * ? * to the cardsinitial environment to have emails sent every minute
in compose-cluster start cards with docker-compose up
at http://localhost:1435/?mssql=mssql&username=sa&db=master&ns=path&import= import the generated proms_sample.sql file
open http://localhost:8080/Subjects.importClarity
check that the patients have been imported correctly
check that Survey Events have been created
wait for one minute, check that patients with a visit 3 days from today have their Initial Notification question answered, patients with a visit tomorrow have their Reminder Notification question answered
log in, fill in and submit one of the visits, make sure that the Survey Events has an answer for the Responses Received question
go to the clinic dashboard, make sure that the upcoming visits shows the correct email type and date for the patients that were supposed to receive emails

To test regressions in prems:

on branch CARDS-2199 build with mvn clean install -Pdocker
in compose-cluster/mssql run python3 ./generat1e_test_YE_sql.py -n 100 --basedate 2023-05-03 prems_sample.sql (use 6 days ago as the date)
in compose-cluster run python3 generate_compose_yaml.py --mssql --cards_project cards4prems --oak_filesystem --dev_docker_image --smtps --smtps_test_container --smtps_test_mail_path ~/cardsmail --composum --adminer --clarity
edit docker-compose.yml and add NIGHTLY_NOTIFICATIONS_SCHEDULE=0 * * * * ? * to the cardsinitial environment to have emails sent every minute
in compose-cluster start cards with docker-compose up
at http://localhost:1435/?mssql=mssql&username=sa&db=master&ns=path&import= import the generated prems_sample.sql file
open http://localhost:8080/Subjects.importClarity
check that the patients have been imported correctly
check that Survey Events have been created
wait for one minute, check that patients with a visit 7 days ago have their Initial Notification question answered, patients with a visit 9 days ago have their Reminder1 Notification question answered, and 11 days ago Reminder 2 Notification
generate a token, log in, fill in and submit one of the visits, make sure that the Survey Events has an answer for the Responses Received question

PROMS - ALL GOOD!
I'm having problems when testing regressions in prems:
There is no generate_test_YE_sql.py, I only see generate_test_sql.py.
Also there is a typo in ( proms instead of prems) :
python3 generate_compose_yaml.py --mssql --cards_project cards4proms --oak_filesystem --dev_docker_image --smtps --smtps_test_container --smtps_test_mail_path ~/cardsmail --composum --adminer --clarity
by using generate_test_sql.py and with the corrected typo, I am not getting anything imported in prems

Indeed, I'll update the instructions, they're still modeled on the 1886 branch.

Small bug: in prems the second reminder isn't shown on the dashboard

Small bug: in prems the second reminder isn't shown on the dashboard

Fixed in e36f6de


Add support for new 'ext' noalerts label.

https://issues.redhat.com/browse/OSD-4059
A future phase will remove the old label.  Tracked as a task in the above story.

Going to wait for https://github.com/openshift/deadmanssnitch-operator/pull/65
/hold

PR is obsolete, changes are done in other PR's.