UnitTestRootDirectory setting in PythonSettings.json is ignored

This issue has been moved from a ticket on Developer Community.

Clone https://github.com/microsoft/DeepSpeed.git
Open it as Local Folder in Visual Studio 2022 with Python workload installed
Toggle hidden file display, and open PythonSettings.json from Local settings
Use the following settings:

{
  "TestFramework": "pytest",
  "UnitTestRootDirectory": "tests\\unit",
  "UnitTestPattern": "test_*.py"
}

Open Test Explorer and check Output window (show output from: Tests)

Expected: pytest command line should restrict looking for tests to tests\unit subfolder
Actual: it seems to be using the root folder of the repository ignoring UnitTestRootDirectory setting:
python.exe -m pytest --collect-only --cache-clear '--rootdir=C:\Users\USERNAME\Projects\DeepSpeed'

Original Comments
Feedback Bot on 12/16/2021, 07:21 PM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Original Solutions
(no solutions)

This should work according to https://devblogs.microsoft.com/python/whats-new-for-python-in-visual-studio-16-3-preview-2/. Need to investigate, could be a regression.

For our project, this completely prevents the tests from working because it ends up scanning so many files that it times out before it can find the tests.

Hi, the UnitTestRootDirectory only specifies test directory for unittest. You will need to specify a .ini file to config pytest. Please see this link.

Please reopen the ticket if it still does not resolve your issue. Thank you!

This is exactly the issue, if the pytest.ini file is not in the root of the project (in my case a C++ library with bindings for Python and Java that has the tests for each language in separate subdirectories) it takes more than 30 seconds to scan for the Python tests and the Test Explorer always times out. We finally worked around the issue by moving pytest.ini to the root directory of the project, but there should be some way to tell the test discovery process where to find pytest.ini — I thought that was the purpose of the UnitTestRootDirectory setting, but apparently I was wrong.


changes some character for easy view and a line

Which category is this pull request?

[ ] A new feature/enhancement.
[ ] Fix an issue/feature-request.
[ ] An improvement to existing modules.
[ ] Other (Please mention below).

Where has this been tested?

Python Version

[ ] v3.x
[ ] v2.x

Operating System:

[ ] Linux (Please specify distro)
[ ] Windows
[ ] MacOS

Does this close any currently open issues?
[Mention any issue which this PR closes]
Does this add any new dependency?
[Mention if this PR includes any new library]
Does this add any new command line switch/argument?
[Mention if the changes add any new arguments like --arg]
Any other comments you would like to make?
[Anything more you'd want the reviewer to know]

What kind of PR is this?


Support submit reply.

It would be nice if munin can allow user to post reply, to support this, munin needs to parse bbcode(which is the reply format on bangumi) into a AST.
Currently there is no bbcode parser in dart, hence we need to write one.
This task can be broken in following parts.

Write a parser to parser bbcode into ast.(when user wants to edit a post, bbcode is returned)

Parser user post into bbcode.(when user wants to submit a reply, we need to transpile it into bbcode)

2.5 Choose a rich text editor in flutter.

Actual implementation.

regarding 2.5. I checked zefyr, the only seem-to-be-mature rich text editor on Flutter, unfortunately I don't think it's ready for munin in production.

Very difficult to select text, plus, 3D touch doesn't work
Cannot custmize toolbar https://github.com/memspace/zefyr/issues/23  :( deal breaker, showing some widgets on toolbar that never works is even worse than doesn't use a rich text editor, plus, I want to add some new tools.

Implemented a simple reply editor for now.


[helm] Fix typos and sync values-mini with values

Motivation
Fix typos and sync values-mini with values
Modifications
Comments only.
Verifying this change

[ ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): no
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable
If a feature is not applicable for documentation, explain why? trivial
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

retest this please

run integration tests

run integration tests


Up test coverage

Cover inline query answer
Up cover

Codecov Report

Merging #513 (fb54f91) into master (e6f9dce) will increase coverage by 1.62%.
The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   91.78%   93.40%   +1.62%
==========================================
  Files         152      152
  Lines        3651     3672      +21
==========================================
+ Hits         3351     3430      +79
+ Misses        300      242      -58

Files
Coverage Δ

src/handlers/prayer_reaction_change_answer.py
100.00% <ø> (+24.56%)
:arrow_up:

src/integrations/tg/coordinates.py
100.00% <100.00%> (ø)

src/settings/os_or_file_settings.py
100.00% <100.00%> (+26.66%)
:arrow_up:

src/settings/settings.py
100.00% <100.00%> (ø)

src/srv/prayers/inline_query_answer.py
100.00% <100.00%> (+26.92%)
:arrow_up:

... and 7 files with indirect coverage changes


ASYNC101: check for non-http blocking calls

Itching in my fingers to restructure the code and take stuff from flake8-trio, but not worth it while the plugin is this small. Opted to create a new error code, though I bunched them up in the same parametrize in test_flake8_async.
handles time.sleep, open, and subprocess.[run, Popen, call, check_call, check_output, getoutput, getstatusoutput].
The subprocess calls could be modified not to warn if timeout=0, and could do the same with time.sleep(0) - I don't know if those are acceptable or not.
fixes #4
@Zac-HD

Howdy - Happy for any and all love here. Would you like ownership / access to this project on GitHub and pypi? I'm short of time at the moment.

I'm already on both, and now also watching the repo if you want to step back Cooper!  Release automation makes it easy 🙂

Howdy - Happy for any and all love here. Would you like ownership / access to this project on GitHub and pypi? I'm short of time at the moment.

I'm only really contributing to this on the request of Zac, and use neither plugin myself atm. But I got plenty time and FOSS contributions look good on the resume so I'm happy to give some love :heart:


Transparent Background

I'm struggling to get the search bar by itself without any background. Is there any way to get the SearchView with an App Bar with a transparent background?
I've attached below what I was able to get to work.

Hi,
there is very a simple solution, do not use app:behavior and use transparent background for your appbar class.

Or...write and extend your own CoordinatorLayot.Behavior class or AppBar.Behavior class.

Was able to get it to work, thanks!


[Bug] Error while converting multimodal Phi 3 Vision model to TRT-LLM checkpoints

System Info

n1-standard-16 from GCP with 4x NVIDIA T4s
nvidia-smi: NVIDIA-SMI 550.54.15, Driver Version: 550.54.15, CUDA Version: 12.4
Using a NVIDIA GPU Optimized base image

Who can help?
No response
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
When trying to convert microsoft/Phi-3-vision-128k-instruct to a TRT-LLM checkpoint with the instructions found in examples/multimodal, I run into an undefined symbol error, that I believe is the result of some mismatched version somewhere down along the chain of dependencies.
Below is the set of steps I followed to get to this point:
# Install buildx since the GCP provisioned machines don't have it by default
sudo apt-get install -y docker-buildx-plugin

# Steps from https://github.com/NVIDIA/TensorRT-LLM/blob/release/0.5.0/docs/source/installation.md
# TensorRT-LLM uses git-lfs, which needs to be installed in advance.
apt-get update && apt-get -y install git git-lfs

git clone https://github.com/NVIDIA/TensorRT-LLM.git
cd TensorRT-LLM
git checkout rel # Use a stable version to avoid errors, 0.11.0 at the time of writing
git submodule update --init --recursive
git lfs install
git lfs pull

# Build TensorRT-LLM
make -C docker build

# Run TensorRT-LLM
make -C docker run

# At this point we're inside the container

# Go to the multimodal vision example
cd examples/multimodal

# Download the model
export MODEL_NAME="Phi-3-vision-128k-instruct"
git clone https://huggingface.co/microsoft/${MODEL_NAME} tmp/hf_models/${MODEL_NAME}

sudo apt-get install -y git-lfs
(cd tmp/hf_models/${MODEL_NAME} && git lfs fetch)

# Install dependencies
pip install -r ../gpt/requirements.txt

export MODEL_NAME="Phi-3-vision-128k-instruct"
python ../gpt/convert_checkpoint.py \
    --model_dir tmp/hf_models/${MODEL_NAME} \
    --output_dir tmp/trt_models/${MODEL_NAME}/fp16/1-gpu \
    --dtype float16

Expected behavior
I expect to convert the Phi 3 vision model to a TRT-LLM checkpoint.
actual behavior
Upon attempting to convert the model to a TRT-LLM checkpoint, I get the following error:
$ python ../gpt/convert_checkpoint.py \
    --model_dir tmp/hf_models/${MODEL_NAME} \
    --output_dir tmp/trt_models/${MODEL_NAME}/fp16/1-gpu \
    --dtype float16
Traceback (most recent call last):
  File "/code/tensorrt_llm/examples/multimodal/../gpt/convert_checkpoint.py", line 26, in <module>
    import tensorrt_llm
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/__init__.py", line 32, in <module>
    import tensorrt_llm.functional as functional
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/functional.py", line 28, in <module>
    from . import graph_rewriting as gw
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/graph_rewriting.py", line 12, in <module>
    from .network import Network
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/network.py", line 27, in <module>
    from tensorrt_llm.module import Module
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/module.py", line 17, in <module>
    from ._common import default_net
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/_common.py", line 31, in <module>
    from ._utils import str_dtype_to_trt
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/_utils.py", line 30, in <module>
    from tensorrt_llm.bindings.BuildInfo import ENABLE_MULTI_DEVICE
ImportError: /usr/local/lib/python3.10/dist-packages/tensorrt_llm/bindings.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN3c106detail14torchCheckFailEPKcS2_jRKSs

additional notes
I also tried installing the requirements found in examples/phi/requirements.txt to no avail. Attached to this issue is the output of pip freeze and apt installed --list:
pip_freeze.txt
apt_list.txt

Hi @monoclex , I think you should try python ../phi/convert_checkpoint.py

@QiJune I forgot to have mentioned it, but I believe I tried that as well similarly to no avail. If it works for you, let me know how!

@byshiue Can you confirm if this is a bug? Are there any ideas to get around this in the meantime?


PEP8 cleanup, Travis-CI addition

Fixed most PEP8 violations, except for alignment of = on constants and broad exceptions
Make message header management hidden as these are not meant to be used outside of the class
Added Travis-CI integration for build verification (needs to be enabled on main branch though)

Any more comments on this PR?

Any more changes needed on this PR?

This pr has been open for some time. While there are no conflicts, I'm going to close this and redo it since this was a messy branch.


Bugfix PR: Fixing localization issues

Pull Request (PR) description
This PR fixes several localization issues that were discovered when using non-English versions of Windows and/or SharePoint
This Pull Request (PR) fixes the following issues

Fixes #920
Fixes #955

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md in the resource folder.
[x] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #993 into dev will decrease coverage by <1%.
The diff coverage is 83%.

@@          Coverage Diff           @@
##             dev    #993    +/-   ##
======================================
- Coverage     92%     92%    -1%
======================================
  Files        116     116
  Lines      11871   11984   +113
  Branches       1       1
======================================
+ Hits       11030   11122    +92
- Misses       840     861    +21
  Partials       1       1

@NikCharlebois Can you please review?


Add submit_command_extra and cancel_command_extra to HTCondor

Primarily for HTCondor it might be important to pass extra parameters, such as schedd.
As for specifying the schedd, I think @lesteve's suggestion of submit_command_extra and cancel_command_extra is a good way of solving this problem; that way we don't have to argue over which arguments are "important".
Originally posted by @matyasselmeci in https://github.com/dask/dask-jobqueue/pull/319#issuecomment-541160495
This probably should be added across all schedulers: see also #202

What stops me from doing this is actually a meaningful test case.  In this case it would be enough to see if the command/cancel command is correctly assembled, right?
Actually I noted another thing, I want to put up for discussion:
wouldn't it make sense to actually pass actual the cancel and submit commands in the constructor (with a default!)  as a format string with named parameters ( sth. like "condor_submit {submit_command_extra} {submit_file}".format(**{**kw_args,**computed_args} )
The background is that some schedulers might expose a SGE interface for compatibility reasons: e.g. htcondor_qsub that could be easily used. Also it is sometime easy to extend things using simple wrapper scripts. Also this might help if for some reasons the commands are not in the path.
For the named parameter formatting: The problem comes with akward positional parameters see #319 or rather #351.

I recommend against looking too closely at htcondor_qsub -- it hasn't been widely advertised, and doesn't get maintained much either.
If you wanted to test more than just whether {submit_command_extra} got properly interpolated, put something like my.testattribute="foo" into the submit_command_extra; this will add an extra attribute named testattribute with the value foo into the job which you can test for with something like condor_q {job_id} -af testattribute.

I think this is mostly closed. One should maybe add more tests (but this is sth that always can be done), but I think this does not justify keeping the issue open.


polling for packages and deployments

Updating to satisfy task.
We want to allow a user to decide whether or not to wait for a workflow's associated packages, deployments, and releases to be completed. To do this, we can poll the API for information about the statuses

https://github.com/chassyflow/platform/actions/runs/10622490507/job/29449987509
Successfully dogfooding

I've verified that when sync is disabled, it doesn't bother checking for the success of the workflow.

Does the action with sync = true wait for all packages and deployments to have status success or error before finishing?


Half a variadic tuple rest sandwich matching algorithm missing

Half a variadic tuple rest sandwich missing
Bug Report
🔎 Search Terms
variadic tuple assignment matching algorithm
Background
When a non-generic variadic tuple of arbitrary depth is declared,
it is transformed into one of two possible final flat canonical forms,
as described by this comment
// We have optional, rest, or variadic elements that may need normalizing. Normalization ensures that all variadic
// elements are generic and that the tuple type has one of the following layouts, disregarding variadic elements:
// (1) Zero or more required elements, followed by zero or more optional elements, followed by zero or one rest element.
// (2) Zero or more required elements, followed by a rest element, followed by zero or more required elements.
// In either layout, zero or more generic variadic elements may be present at any location.

found in checker.ts, function createNormalizedTupleType.
Bug
However, the current unidirectional matching algorithm in checkArrayLiteral does not work correctly with the output from
createNormalizedTupleType.  It incorrectly gives errors.  (Incorrect meaning, it returns errors for lhs values that could pass if a full combinatorial search were used.
That's because checkArrayLiteral performs a unidirection (left to right) search only, whereas the output from createNormalizedTupleType requires a bidirectional search.
One solution would be be to change the output of createNormalizedTupleType so that it all elements to the right off the first rest element were rolled into a single rest.  Then the unidirectional search could be used with returning false errors.
However, a bidirectional search takes the same O(1) time as the unidirectional search, yet
yet produces fewer false postives (false passes) than the unidirectional search.  Therefore the bidirectional search is prefereable.
The bidirectional matching algorithm intended by the output of createNormalizedTupleType is

match values from the front until the rest element is reached,
match values from the back until the rest element is reached,
match the remaining values to the rest element.

🕗 Version & Regression Information
The example wrong assignment results for variadic tuples are stable in version range 4.2.3 ~ 4.8 dev.
⏯ Playground Link
playground
💻 Code
// @strict: true
// @exactOptionalPropertyTypes: false

/**
 * The before: (OK/Error) X (expected/unexpected) notations on the rhs
 * of the assignments are valid for versions 4.2.3 ~ 4.8 dev.
 */

{
    // Type T2 IS NOT a rest sandwich format - always no change in result between before and after
    type T1 = [x:number,y?:boolean];
    type T2 = [...T1, "$"];  // GUI shows type T2 = [number, boolean | undefined, "$"] canonical type 1 format (no rest)

    const t2a:T2 = [1, "$"]; // { before: Error (expected), after: Error (expected) }
    const t2b:T2 = [1, true, "$"]; // { before: OK (expected), after: OK (expected) }
}

{
    // Type T12 IS a rest sandwich format - this example shows results that improvably differ between before and after.
    type Last = "$";
    type T11 = [x:"^",...y:boolean[]];
    type T11m = [z?:string];
    type T12 = [...T11, ...T11m,"$"]; // type T12 = ["^", ...(string | boolean | undefined)[], "$"] canonical type 2 format (rest sandwich)

    /**
    * In the next two assignment examples:
    *   before: the glutinous rest element `T12[1]` greedily eats the rhs `$`, preventing `T12[2]` from correctly matching rhs `$`.
    *   after: first `T12[0]` matches rhs "^", rest element `T12[1]` matching is deffered, `T12[2]`matches the last "$",
    *     and finally matches the rest element `T12[1]`.
    */
    const t12a:T12 = ["^", "$"]; // { before: Error (unexpected), after: OK (expected) }         // BUG
    const t12b:T12 = ["^", true, "$"]; // { before :Error (unexpected), after: OK (expected) } // BUG

    // In the next two assignment examples, the before unexpected errors are prevented by explicity casting rhs "$" to the literal type it really is meant to be,
    // which is not compatible with the rest element `T12[1]`.  This is just to illustrate how the unidirecitonal L to R matching is working
    // and can sometimes get the right answer.
    const t12c:T12 = ["^", "$" as Last]; // { before: OK (expected), after: OK (expected) }
    const t12d:T12 = ["^", true, "$" as Last]; // { before: OK (expected), after: OK (expected) }
}

🙁 Actual behavior
Matching from left to right (Alg1).
Invalid results found.
🙂 Expected behavior
Using the bidirectional, rest-centered search described above no invalid results would be found.
Deep analysis
In order to properly analyze the the specs, I felt I had to write an implementation of the bidirectional search
and run it on the baseline tests.  That's work is in the "pull draft" #49106.
Of course I assume this "pull draft" will not be used, but the analysis result are still valid, and potentially useful.
To summarize the analysis, the way the code is currently written (4.7) there is assumption that array context types
don't necessarily need to expose a length for use in matching.  However that won't necessarily work when
trying to match with a bidirectional search. Might be able to get away with negative indices
(distance from the end) and still avoid length.  But stretching a rest element to infinite length won't work when a bidirectional search is required.

half a variadic tuple rest sandwich

Doesn’t sound very tasty.  Who ate the other half?

@fatcerberus - "There's nobody here but us mice!"

I'm going to report a simpler version of the bug

Reopening after the topic arose again.

See the newer version #49138.


WaitFor module unusually long promise resolve time

When coding with Roblox's own API, and using instance:WaitForChild(childName), you get a warning after 7 seconds that tells you that the yield is unusually long.
With the WaitFor module, that isn't a feature but instead, the default timeout is 60 seconds, and the timeout forces the promise's "yield" to reject and error.
This behavior is fine, and I am making the assumption that 60 seconds force timeout time was set with slow runtimes running WaitFor code in mind, however, as I was testing earlier today some code for my game that uses WaitFor, I realized that the WaitFor wasn't resolving in an expected time frame and I stopped the test almost immediately after and started to print debug the code.
This is not very ideal as it takes more time than it has to take, and if I were to wait 60 seconds at least before closing my game, I would have figured out the exact problem!
With Roblox's own API in mind, I think introducing an "unusual length warning" would do well for the WaitFor module, and being able to set this value somehow (not required but would be nice) would also be good. I think that 7 seconds unusual yielding time would work perfectly, as it has for Roblox throughout all these years.
I do not want to create a PR alongside this since WaitFor uses promise functionality which I have no experience in using, so instead I am making this issue with a code snippet of how unusual yield time warnings could be introduced.
I am hoping that someone can create a PR, or that Sleitnick can just update the module himself if he thinks this functionality can be introduced.
Here's the code snippet of how you can implement the functionality described above when creating a Promise.
local unusualYieldWarn = task.delay(7, function()
  warn("Unusual yielding time for Promise, etc")
end)

local promise = Promise.new(function(resolve)
  -- Do whatever you want in your promise here
  if promiseResolvedSomehow then
    task.cancel(unusualYieldWarn)
    resolve()
  end
end)

Below is an example of the warning that Roblox outputs after 7 seconds of yielding using a :WaitForChild()


Target AppLocalFromInstalled: 'pwsh.exe' is not recognized as an internal or external command, operable program or batch file.

Describe the bug
After installing vcpkg, new diagnostic output appeared while building existing projects
Environment

OS: Windows 11
Compiler: Visual Studio 2022/MSBuild

To Reproduce
Steps to reproduce the behavior:

Install vcpkg
Build existing static library C++ project in Visual Studio 2022
Check build output window

Expected behavior
No errors logged
Failure logs
Target AppLocalFromInstalled: 'pwsh.exe' is not recognized as an internal or external command, operable program or batch file.

On my Windows 11, PowerShell shortcut points to:
%SystemRoot%\system32\WindowsPowerShell\v1.0\powershell.exe
and is included in
Path=..;C:\Windows\System32\WindowsPowerShell\v1.0;...

vcpkg uses powershell-core pwsh.exe not windows powershell powershell.exe.
That said, vcpkg should have downloaded and installed the version of powershell core it requires - you can download/install powershell-core from here. Just be sure to select Add to Path for All Users when installing.
The version of powershell core used by vcpkg can be found here, looks like the x86 version of 7.2.11.
I personally have powershell-core 7.4 x64 with its path added and vcpkg finds it just fine.

Thank you for prompt response.
Maybe powershell-core should be listed as a prerequisite here: https://github.com/microsoft/vcpkg#quick-start-windows?

vcpkg should download/install the tools needed by the ports/features selected while being transparent to the user.
Listing the dozens of supporting tools vcpkg uses as prerequisite would be formidable, long and overwhelming, especially for new users to install, not to mention most would not be needed.
In this case vcpkg failed to download/install powershell-core and I am unsure what information/logs would be required to duplicate the issue and then remedy. The maintainers or this area of vcpkg may be reaching out to you for more information.

OK, thanks a lot!

@oleg-boulanov  Can you provide your simple reproduction project?

@Adela0814 sorry, I can't.
StarGate-One already identified the issue - pwsh not installed during vcpkg installation:
git clone https://github.com/microsoft/vcpkg.git
cd vcpkg && bootstrap-vcpkg.bat
I had to install it manually to fix the issue.

Same. Manually installing fixed the issue.

The other possibly bigger problem is that this doesn't fail the build. Is this target necessary?


Spell check of tutorials

Apply spell check to tutorials

Hi! I'm new at this but I hope I can do this one. Is there a special/dedicated way to do this (scared by the Epic tag!)?

Thank you. But, this is just an epic to manage a group of issues. They are almost done already. How about some issues with documentation tag?

Got it,  will check those out.


Allow for flattening of generic parameters

Goal
Generic parameters currently can't be flattened:
#[derive(TS)]
#[ts(export)]
struct Item<D> {
    id: String,
    #[ts(flatten)]
    inner: D,
}

Serde happily accepts this, and we should too.
The three test cases work, and they are compatible with what serde does with them. There may be edge-cases I currently can't think of, though.
However, this change definitely wont break any existing code.
Changes
Tiny change: we just implement fn inline_flattened() for the dummy generic types we generate, instead of throwing an error.
Checklist

[x] I have followed the steps listed in the Contributing guide.
[x] If necessary, I have added documentation related to the changes made.
[x] I have added or updated the tests related to the changes made.

damn, that was fast! :D

damn, that was fast! :D

I literally logged into GitHub as the PR was being created lmao

I think this is what @murl-digital wanted in #335, though it might be unrelated if I misunderstood.

I think this is what @murl-digital wanted in #335, though it might be unrelated if I misunderstood.

Looking thorugh the issue, I think this is what they need as well

I think this is what @murl-digital wanted in #335, though it might be unrelated if I misunderstood.

i clarified what i wanted in the issue just in case, but i think this would fit my usecase (i'll have to check, though)
one potential issue is handling trait bounds, but i think i can just use a concrete type or something.

one potential issue is handling trait bounds, but i think i can just use a concrete type or something.

Since your definition of struct Item doesn't make use of the fact that D: Document, I'd consider if you can just remove that bound. Normally, you only need such a bound on a struct definition if you're using an associated type on Document.
Even std::hashmap::HashMap<K, V> doesn't constrain K or V, but only the impl<K: Hash> HashMap { ... } block does.

Hm, maybe this should be a patch release instead..

Hm, maybe this should be a patch release instead..

This would fit very well in a 9.1.0, maybe we could even squeeze #316 in with it

Hey @NyxCode, since this was release on crates.io, I'll make a corresponding GitHub release


Workflow autostart issues

Summary
We have a workflow with start_step "new" assigned, force_autostart true, we have no transition named start, we have another transition which has is_start true, but when we persist and flush this entity that has this specific workflow, workflow manager throws error "Step "new" of workflow "custom_flow" doesn't have allowed transition "start".
Steps to reproduce
Create any workflow that should autostart automatically and has no start transaction.
Actual Result
Fatal error and workflow not started.
Expected Result
Workflow should be started with step "new"
Details about your environment

OroPlatform version: had 3.1.15 and updated to 3.1.19 (seems like previous version was OK, but cannot be sure 100%)
PHP version: 7.2
Database: MySQL 5.7
Additional information

We tried to configure start transaction, even tried to remove start_step, but then nothing happens. If you leave start_step and have start transaction as is_start true, then same error occurs. I always try make PR, but workflow seems so broken in so many places, for example Listener which registers which workflow to autostart, does not register anything if you have no start_step assigned, but in the docs start_step is mentioned as an optional if you have no start transition assigned. start is used everywhere as start transition even if you have no such transition in your workflow. Ill try to make PR, but i need better understanding of how everything should be. For now adding start to allowed transition for our start step solved an issue, but I think workflow is still broken or documented poorly.

Hi @vytsci,
you can configure the basic workflow prototype from UI and dump it to the code with below command:
php bin/console oro:debug:workflow:definitions <workflow-name>

This can help you to find the initial issue in the configuration.

Ok we solved one issue, as database got somehow corrupted and our new entities dragged old workflow items from the table. But issues still persists where force_autostart does not work if start_step is not present. And start transition should be documented inside docs.

I dunno this issue is partially true now. Because autostart still not works as expected, but Ive solved fatal errors and it was on our side.


fix ToolExitException when user enter exit/quit

Fixed below exceptions
$ pyocd cmd
Connected to MIMXRT1062xxxxA [Running]:<PHONE_NUMBER>97e4ca00000000000000000000000097969905
pyocd> q
Error:
Traceback (most recent call last):
  File "c:\mycode\pyocd\pyocd\commands\repl.py", line 88, in run_one_command
    self.context.process_command_line(line)
  File "c:\mycode\pyocd\pyocd\commands\execution_context.py", line 272, in process_command_line
    self.process_command(cmd.strip())
  File "c:\mycode\pyocd\pyocd\commands\execution_context.py", line 316, in process_command
    cmd_object.execute()
  File "c:\mycode\pyocd\pyocd\commands\commands.py", line 91, in execute
    raise ToolExitException()
ToolExitException
pyocd> quit
Error:
Traceback (most recent call last):
  File "c:\mycode\pyocd\pyocd\commands\repl.py", line 88, in run_one_command
    self.context.process_command_line(line)
  File "c:\mycode\pyocd\pyocd\commands\execution_context.py", line 272, in process_command_line
    self.process_command(cmd.strip())
  File "c:\mycode\pyocd\pyocd\commands\execution_context.py", line 316, in process_command
    cmd_object.execute()
  File "c:\mycode\pyocd\pyocd\commands\commands.py", line 91, in execute
    raise ToolExitException()
ToolExitException

Thanks for catching this!

@Hoohaha Fyi, I incorporated this fix into #978.

Thanks @flit


Xwayland tooltips appear in the right place on the wrong output

If you move an xwayland window to an output other than the first and hover over something with a tooltip, the tooltip appears on the first output.

Ditto for context menus

This is working correctly, presumably after #297


Improve OIDC sample app to demonstrate backchannel logout

Improve one of the OIDC sample apps to demonstrate OIDC backchannel logout capability.

@janakamarasena AFAIR, the playground application is capable of doing this.
@piraveena @ashendes Please correct me if im wrong.
Thanks,

Yes, the Playground application has the backchannel logout functionality.

This is implemented for pickup dispatch and manager as well. https://github.com/wso2/samples-is/pull/267.

Hence closing this issue.

@piraveena we have to do a refresh to the browser for the logout to be reflected right?


[GlobalVarAccess] Report 795 Adjust Cost - Item Entries, OnBeforePreReport; add variables: ItemNoFilter, ItemCategoryFilter, PostToGL

since https://github.com/microsoft/AL/issues/3285 GlobalVarAccess was Yes
Now is not possible for 15.x
I need such variables: ItemNoFilter, ItemCategoryFilter, PostToGL
Please adopt:
AdjustCostItemEntries.Report.al
    trigger OnPreReport()
    var
        ItemLedgEntry: Record "Item Ledger Entry";
        ValueEntry: Record "Value Entry";
        ItemApplnEntry: Record "Item Application Entry";
        AvgCostAdjmtEntryPoint: Record "Avg. Cost Adjmt. Entry Point";
        Item: Record Item;
        UpdateItemAnalysisView: Codeunit "Update Item Analysis View";
    begin
        // mofify, alexef
        OnBeforePreReport(ItemNoFilter, ItemCategoryFilter, PostToGL);
...
    [IntegrationEvent(TRUE, false)]
    local procedure OnAfterPreReport()
    begin
    end;
    // modify, alexef
    [IntegrationEvent(TRUE, false)]
    local procedure OnBeforePreReport(ItemNoFilter: Text[250]; ItemCategoryFilter: Text[250]; PostToGL: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Should we have shell scripts called zopen-xxx that can be run directly?

Right now, we have:
bin
  +- lib

as our structure, with zopen in bin and the zopen-xxx shell scripts (that presumably aren't meant to be called directly) in bin/lib.
Is there any reason to restrict the underlying scripts to not be run directly?
There are two reasons this would seem nice:

it makes it clearer for the invoker how options and such are processed and you don't end up with the slightly clunky zopen <verb> <options> <parameters>
it would give us a direct mapping from 'man' pages and docs to the actual scripts

@IgorTodorovskiIBM @DevonianTeuchter @HarithaIBM and anyone else... arrows expected...

I believe git allows the dash form scripts to be run explicitly as well, so I'm ok with this.
I initially decided to separate the scripts into option commands because I wanted the user's entry point to be zopen. When the user types zopen, they get the help which describes what the meaning of each command is. I think this is common convention is cli tools these days, including git, brew, etc. One negative is the lack of auto-complete, but new shells like zsh overcome this:
$ git <tab>
add       -- add file contents to the index
bisect    -- find by binary search the change that introduced a bug
branch    -- list, create, or delete branches
checkout  -- checkout a branch or paths to the working tree
clone     -- clone a repository into a new directory
commit    -- record changes to the repository
diff      -- show changes between commits, commit and working tree,
fetch     -- download objects and refs from another repository
grep      -- print lines matching a pattern
init      -- create an empty Git repository or reinitialize an exis
log       -- show commit logs
merge     -- join two or more development histories together
mv        -- move or rename a file, a directory, or a symlink
pull      -- fetch from and merge with another repository or a loca
push      -- update remote refs along with associated objects
rebase    -- forward-port local commits to the updated upstream hea
reset     -- reset current HEAD to the specified state
restore   -- restore working tree files
rm        -- remove files from the working tree and from the index
show      -- show various types of objects
status    -- show the working tree status
switch    -- switch branches
tag       -- create, list, delete or verify a tag object signed wit

The alternative for bash is https://github.com/scop/bash-completion

Actually, I thought that too but git does not let you run the commands directly (and least not on Mac or z/OS when I tried, e.g. git add works but git-add does not.

running /usr/libexec/git-core/git-fetch does work on fedora; git-fetch is a symlink back to git itself so it must check how it was instantiated.
I like @IgorTodorovskiIBM 's approach in that zopen --help  lists all the available commands/verbs and an explanation for each - while a zopen <verb> --help would list the specific help for that verb - very similar to docker/podman's approach.

Some tools make it more fun by doing it like git help push.

done


training with less classes

hello!
If I want to train this model with less classes just like two or three class of object
but when i change the classes in pascal_voc.py some error is happened
so what should I do to change the amount of classes?
thank you!

check out this issue, https://github.com/rbgirshick/py-faster-rcnn/issues/243

Place the class names in https://github.com/jwyang/faster-rcnn.pytorch/blob/358cecacf876717ff13988dc6396de10e265279c/lib/datasets/pascal_voc.py#L48-L53
and the code will take care of updating the architecture.
That is the pascal_voc dataset .py file. If you have your one dataset, copy it and adapt it to your needs.


Write errors to provenance information from pop-out error window

Current Behaviour
When I press the write errors to provenance information from pop-out error window the errors are not written to the provenance information
Expected Behaviour
errors are written to provenance information
Steps to Reproduce

Open Data Curator using the icon
Enter invalid data
Validate
Pop-out errors window
Press write errors to provenance information button
nothing happens

Data Curator version: 0.13.0
Operating System and version: macOS High Sierra 10.13.3

Fixed in 0.18.0


Support big- and little-endian lane order with bitcast

Add a MemFlags operand to the bitcast instruction, where only the big and little flags are accepted.  These define the lane order to be used when casting between types of different lane counts.
Update all users to pass an appropriate MemFlags argument.
Implement lane swaps where necessary in the s390x back-end.
This is the final part necessary to fix
https://github.com/bytecodealliance/wasmtime/issues/4566.
CC @cfallin
This is still a RFC because of the following questions:

Should we enforce that a byte order flag must be explicitly specified if the types differ in lane count?  (This would be easily doable in the verifier.)
There was some discussion in the issue whether or not the MemFlags API is the right choice.  It seems that way to me, since it makes the semantics easy to specific, and is simple to implement based on the already existing MemFlags infrastructure.  If you prefer some other implementation, please let me know - I'd be happy to change this.

I do think we should require one of big or little when lane-count differs, as you suggest; otherwise this is a new way that endian-specific behavior is visible in CLIF, which I'd prefer to avoid. Happy to r+ once that is added!

Ok, implemented.  There were four filetests where the error triggered, which I fixed by adding a byte order specifier.  Thanks!


Add PreparedRequest pickling tests

Trying to address #1558 by first creating a failing test, but I'm not sure when PreparedRequests fail to be pickleable. Pulling early to see if anyone has suggestions on how to re-create the issue, also maybe these tests are useful on their own as well.

Thanks @keyan! From the issue:

On a prepared request, the only thing I think can hurt us is the case when the body attribute is a file object. Is there a specific hook that we're concerned about not being pickleable?

So the concerns seem to be body file objects and hooks.

@keyan do you have intentions to update this with the tests we were looking to add?

Hey @sigmavirus24, I could use some advice on how to add a file object in the test environment. I just added a commit with a failing test containing a hook. Not sure how to address the actual issue though.

@keyan It is often easiest to just create a file handle to the file under test: open(__file__).

Closing due to inactivity, (now) merge conflict, and failing tests. These look very much needed though, so please open another PR when ready to proceed!


Logs are added to UI at certain intervals

A lot of logs could freeze the UI. Hopefully, now that logs are only added every second, this will prevent freezing.

I think maybe we should introduce a quiet mode where we suppress all logs, @emm1R how complicated would that be ?

You mean that the user cannot see the logs at all? In UI and CLI?

You mean that the user cannot see the logs at all? In UI and CLI?

yes, in both. Just asking how complicated it would be.

You mean that the user cannot see the logs at all? In UI and CLI?

yes, in both. Just asking how complicated it would be.

Not complicated

maybe we can do that as part of another PR, but not a high priority


Update aws sdk

This is prep work for using kinesumer which uses the latest aws sdk. This should also take care of the ThrottlingExceptions and automatically retry (introduced in sdk 0.6.8, we were using v0.6.1).

Nice. :+1:


Sync with openAI when editing assistant

Description

User Impact

Now the sync will happen automatically without having to press the sync button
Demo

coming soon
Docs

to be updated

Codecov Report
Attention: Patch coverage is 9.09091% with 30 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

apps/assistants/sync.py
8.69%
21 Missing :warning:

apps/assistants/views.py
10.00%
9 Missing :warning:

Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!

@coderabbitai please review

@snopoke I would like your input on whether are_files_in_sync_with_openai properly checks the file status becuase this is what I'm unsure about

going back though the logic of are_files_in_sync_with_openai I realize that it wasn't quite checking what I wanted in terms of the case if a tool is being used in OpenAI but not found in OCS. I revised the logic to cover these cases:

1
A tool is enabled in OpenAI but not locally
False

2
A tool is locally configured but not enabled in OpenAI
True (allowed)

3
Files associated with a tool type differ between OCS and OpenAI
False

4
All tools and files are synchronized between OCS and OpenAI
False

@coderabbitai please review again specifically the logic of are_files_in_sync_with_openai


Including metal-rs on cargo.toml results in a compile error due to cocoa

I've created a brand new Rust project, and added metal-rs = "0.10.6" to its cargo.toml. Attempting to build it results in the following error:
   Compiling cocoa v0.15.0
error: could not compile `cocoa` due to 5 previous errors
error[E0282]: type annotations needed
    --> /Users/v/.cargo/registry/src/github.com-1ecc6299db9ec823/cocoa-0.15.0/src/appkit.rs:3457:9
     |
3457 |         msg_send![self, setStringValue:label];
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: this error originates in the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider giving `result` an explicit type
    -->  |/Users/v/.cargo/registry/src/github.com-1ecc6299db9ec823/objc-0.2.7/src/macros.rs:141:19
     |
141  |         let result: _;
     |                   +++

error[E0282]: type annotations needed
    --> /Users/v/.cargo/registry/src/github.com-1ecc6299db9ec823/cocoa-0.15.0/src/appkit.rs:3454:9
     |
3454 |         msg_send![self, setEditable:editable];
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: this error originates in the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider giving `result` an explicit type
    -->  |/Users/v/.cargo/registry/src/github.com-1ecc6299db9ec823/objc-0.2.7/src/macros.rs:141:19
     |
141  |         let result: _;
     |                   +++

error[E0282]: type annotations needed
    --> /Users/v/.cargo/registry/src/github.com-1ecc6299db9ec823/cocoa-0.15.0/src/appkit.rs:2849:9
     |
2849 |         msg_send![self, setBezelStyle:style];
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: this error originates in the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider giving `result` an explicit type
    -->  |/Users/v/.cargo/registry/src/github.com-1ecc6299db9ec823/objc-0.2.7/src/macros.rs:141:19
     |
141  |         let result: _;
     |                   +++

error[E0282]: type annotations needed
   --> /Users/v/.cargo/registry/src/github.com-1ecc6299db9ec823/cocoa-0.15.0/src/appkit.rs:526:9
    |
526 |         msg_send![self, releaseGlobally];
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider giving `result` an explicit type
   --> |/Users/v/.cargo/registry/src/github.com-1ecc6299db9ec823/objc-0.2.7/src/macros.rs:132:19
    |
132 |         let result: _;
    |                   +++

I'm using 1.66.0-nightly (f5193a9fc 2022-09-25). I'm on macOS Monterey Version 12.5.1. What is the cause of this error?

Oh, seems like package is published as metal. The metal-rs one seems to be an old version that isn't published anymore. Just adding metal = 0.24.0 on cargo.toml works fine.


Threads options for face_detector and test_simple_object_detector

Is it possible to run face_detector and test_simple_object_detector using multiple threads. I know there is an example to train with multiple threads. This will really help to make the code faster

No

any idea how to improve the performanc?

If there was an option to improve performance it would be on by default :)

many thanks.


[8.x] Adds Pipable trait

This PR adds the "Pipable" trait, which allows decorating methods calls at the "call site", allowing to refactor christmas tree code into a method chain.

This is a simplified version of the laravel-middlewarize package.
Support for static method can also be added as the package has if this was accepted.

Example usages:
$obj->pipe('retry:3')->fetchData();

$response = $this->pipe('throttler:3')->login();

Before:
$ttl = \DateInterval::createFromDateString('6 seconds');

return Cache::remember("user_$id", $ttl, function () use ($id) {
    $repo = new UserRepo();

    return $repo->find($id);
});

After:
$repo = new UserRepo();   // The UserRepo uses Pipable trait.

$user = $repo->pipe("cacher:user_$id,6 seconds")->find(1);

In this example, the point is that the Cacher pipe class does not know anything about the UserRepo or what is being cached. So it can be defined once (in a package or somewhere else) and be used everywhere. So nice pipes can be shared as laravel packages.
class Cacher
{
    public function handle($data, $next, $key, $ttl)
    {
        $ttl = \DateInterval::createFromDateString($ttl);

        return Cache::remember($key, $ttl, function () use ($next, $data) {
            return $next($data);
        });
    }
}

We also bind:
app()->singleton(Cacher::class, 'cacher');

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


[build-script] Add a presets for building/testing the stdlib standalo…

…ne against a swift.org toolchain
This hopefully provides an example for other people on how to do this sort of
thing.
The presets are called "stdlib_RDA,standalone{,[,]notest}". It requires one parameter:
toolchain_path which should be the bin directory of your toolchain. Example:
build-script --preset=stdlib_RDA,standalone toolchain_path=$MY_TOOLCHAIN/usr/bin
build-script --preset=stdlib_RDA,standalone,notest toolchain_path=$MY_TOOLCHAIN/usr/bin

@swift-ci smoke test and merge


DataverseHandoff

Note: If dv_installation is an FK to RegisteredDataverse, it should allowed to be blank/None

In the handoff params, the siteUrl is there and used to attempt to link to a RegisteredDataverse
Also see (1)(b) in #150.

resolved in handoff endpoint/logic


Roll Engine from 6f4143e80069 to 0e4777407091 (5 revisions)

https://github.com/flutter/engine/compare/6f4143e80069...0e4777407091
2021-10-02<EMAIL_ADDRESS>Roll Wuffs to 600cd96cf47788ee3a74b40a6028b035c9fd6a61 (flutter/engine#28917)
2021-10-02<EMAIL_ADDRESS>Roll Skia from 906e9eb53841 to ce22e059ffeb (1 revision) (flutter/engine#28996)
2021-10-02<EMAIL_ADDRESS>Roll Dart SDK from 8c385be2c663 to f440a20ff15f (2 revisions) (flutter/engine#28995)
2021-10-02<EMAIL_ADDRESS>Roll Dart SDK from d50eacfa4fcd to 8c385be2c663 (2 revisions) (flutter/engine#28994)
2021-10-01<EMAIL_ADDRESS>Roll Skia from 8e29caf4c130 to 906e9eb53841 (6 revisions) (flutter/engine#28989)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Background Image of Vertex

Hello everyone!
I am trying to set an image as background of a vertex, but I don't find how to do it.
It is possible to do this? If it is possible, how could I do it?
Thanks!

Hi, you should change the VertexControl template in XAML.
This is the default template:
    <Style TargetType="{x:Type graphx:VertexControl}">
        <Setter Property="Background" Value="#FFE3E3E3"/>
        <Setter Property="BorderThickness" Value="5,3,5,3"/>
        <Setter Property="Padding" Value="10,5,10,5"/>
        <Setter Property="BorderBrush" Value="#FF393939"/>

        <Setter Property="Template">
            <Setter.Value>
                <ControlTemplate TargetType="{x:Type graphx:VertexControl}">
                    <Border Background="{TemplateBinding Background}"
                            BorderBrush="{TemplateBinding BorderBrush}"
                            CornerRadius="10,10,10,10"
                        Padding="{TemplateBinding Padding}">
                        <Grid>
                            <ContentPresenter Content="{TemplateBinding Vertex}" />
                            <graphx:VertexLabelControl x:Name="PART_vertexLabel" Content="{Binding Vertex, RelativeSource={RelativeSource TemplatedParent}}" />
                        </Grid>
                    </Border>
                </ControlTemplate>
            </Setter.Value>
        </Setter>
        <Style.Triggers>
            <Trigger Property="graphxRoot:GraphAreaBase.PositioningComplete" Value="False">
                <Setter Property="Visibility" Value="Hidden"/>
            </Trigger>
        </Style.Triggers>
    </Style>

Thank you for the reply!
Thanks to you response, I started thinking that VertexControl is like a container, and then, I find out easy to add whatever you want!
Thank you for your hard work!
(Sorry for the late response BTW :( )

np, have fun!


Removed x bit from 203 files

See the title, removed the x bit since it's not needed.
I'm too dumb to be able to count correctly, it's 203

corporate has asked us to identify the difference between these files
GitHub Files Changed tab: they are both empty

What is the purpose of this?

What is the purpose of this?
since they aren't meant to be executed, they shouldn't be executable. It's preferable to give only necessary permissions...


Test-specific helpers in storage-plus

mod.rs in storage-plus/src/indexes contains what appears to be test helpers:
pub fn index_string(data: &str) -> Vec<u8> {
    data.as_bytes().to_vec()
}

pub fn index_tuple(name: &str, age: u32) -> (Vec<u8>, u32) {
    (index_string(name), age)
}

pub fn index_triple(name: &str, age: u32, pk: Vec<u8>) -> (Vec<u8>, u32, Vec<u8>) {
    (index_string(name), age, pk)
}

pub fn index_string_tuple(data1: &str, data2: &str) -> (Vec<u8>, Vec<u8>) {
    (index_string(data1), index_string(data2))
}

Maybe the test-specific parameters like age could use better names? Or maybe this code doesn't belong here?

Yes, these must be defined in the test section.

@maurolacy Something like https://github.com/CosmWasm/cw-plus/pull/709?


Incompatibility of "gentrans.py" Scripts and Current lit_gpt Library

Hi,
very interested in your work.
However, It seems that there is a problem with "gentrans.py" scripts not being compatible with the provided lit_gpt library.
(e.g. "lit_gpt/gentrans.py" is calling the "RoPECache" class from "lit_gpt/model.py," which doesn't seem to exist.)
I suspect that "gentrans.py" might be intended to work with an older version of lit_gpt, but the version provided here appears to have been updated.
Could you please fix this issue or let me know which version of lit_gpt you used?
Apologies if I missed anything.

Thank you for the reply.
The "gentrans.py" scripts seem to be compatible with the lit_gpt library now.
However, a new issue has arisen:
When using "infer.sh" to load your checkpoints,
there is an error indicating a large number of missing keys in the state_dict.
Could you please have another check?
Thanks a lot ^^

Hi, sorry for inconvenience. pls try again it should work now

Thank you very much 🙏


Adding MixedLoadTest to otherLoadTest as part of Load_Level_4 playlist

I've added a new test called MixedLoadTest to otherLoadTest as part of Load_Level_4 playlist which is a mix of workloads.

Successful test run
https://hyc-runtimes-team-svt-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/268/console

@Mesbah-Alam
I've made above changes. Thank you.


Clarify summary_crc should be 0 if there are no summary records

Add clarifying wording to the spec to indicate that summary_crc should be 0 if there are no records in the summary section (the alternative would be that the summary_crc would just be the crc of the first 1+8+8+8 bytes of the footer, which in this case would necessarily be 02<PHONE_NUMBER>000000<PHONE_NUMBER>000000<PHONE_NUMBER>000000).

I'm not sure I like this idea -

If we ever expand the footer record to contain additional fields, the logic does not gracefully migrate
Readers who are validating this CRC will have no trouble accepting a CRC of an empty footer. Also if that CRC fails to validate, it still carries some information.
It costs basically nothing to compute, for writers who are already computing CRC.

Is it really necessary to make a special case in the spec? What's the benefit?

Changed to indicate the range begins at the start of the footer. So the two valid values for this field are 0 and<PHONE_NUMBER>.


Start

Description
Start Pages
Screenshot

Service Manual
https://www.gov.uk/service-manual/design/start-pages

closing this as it's a duplicate of #21


SAMJ model installation fails on Apple Silicone Macs: Micromamba unable to install mkl

Trying to install SAMJ-IJ plugin on an M2 Apple MacBook Pro running macOS Sonoma 14.4.1:

First installed and updated Fiji (ImageJ2 Version 2.14.0/1.54i) and restarted
Then installed SAMJ plugin via Manage Update Sites ... and restarted
Fiji:Plugins > SAMJ > SAMJ Annotator started up
Installation of model EfficientViTSAM-xl1 fails (red message "This model is not installed yet." reappears) with this Console message:

java.lang.RuntimeException: Error executing the following command: [/Applications/Fiji.app/appose_x86_64/bin/micromamba, create, -p, /Applications/Fiji.app/appose_x86_64/envs/efficientvit_sam_env, -c, conda-forge, python=3.11, -c, pytorch, libpng, libjpeg-turbo, scikit-image, pytorch=2.0.1, torchvision=0.15.2, cpuonly, mkl=2024.0.0, cmake, onnx, onnxruntime, timm=0.6.13, --yes]
22:43:05 -- STARTING INSTALLATION
22:43:24 -- TERMINATED PROCESS
670a93a8-bea6-45fb-8cfc-6b34fbbcbc30error    libmamba Could not solve for environment specs
670a93a8-bea6-45fb-8cfc-6b34fbbcbc30The following package could not be installed
670a93a8-bea6-45fb-8cfc-6b34fbbcbc30└─ mkl 2024.0.0**  does not exist (perhaps a typo or a missing channel).
670a93a8-bea6-45fb-8cfc-6b34fbbcbc30critical libmamba Could not solve for environment specs
at io.bioimage.modelrunner.apposed.appose.Mamba.runMamba(Mamba.java:1177)
at io.bioimage.modelrunner.apposed.appose.Mamba.runMamba(Mamba.java:1199)
at io.bioimage.modelrunner.apposed.appose.Mamba.create(Mamba.java:655)
at ai.nets.samj.SamEnvManager.installEfficientViTSAMPython(SamEnvManager.java:639)
at ai.nets.samj.SamEnvManager.installEfficientViTSAMPython(SamEnvManager.java:613)
at ai.nets.samj.SamEnvManager.installEfficientViTSAM(SamEnvManager.java:1045)
at ai.nets.samj.gui.SAMModelPanel.lambda$createInstallationThread$7(SAMModelPanel.java:321)
at java.lang.Thread.run(Thread.java:750)

Same problem with model EfficientViTSAM-I0
Same problem on coworkers silicone MacBook running macOS Ventura
No problem whatsoever installing and running SAMJ on Intel MacBook Pro running macOS Monterey (12.7.2) -- works great!

Looks like the problem lies with micromamba being unable to install mkl, the Intel® oneAPI Math Kernel Library.
I am not a Java, Python, or Mamba expert, so I am stumped what to try to resolve the issue and would be grateful for any suggestions.
Thanks,
microscope

hello @microscope , first of all thank you for trying to use SAMJ and thank you for the debug effort that you made.
Yesss, I will release today or tomorrow a version that does not use mkl for apple silicon!
I will let you know once is out.
Also what do you mean by a repository for developers?
Regards,
carlos

Hello @microscope
First of all sorry for the delay, but now you should be able to use SAMJ in your Apple Silicon laptop.
The repo that contains the backend of the plugin is here:
https://github.com/segment-anything-models-java/SAMJ
Sorry there is still not much documentation. We call it developers repo because there is the code used for the backend of SAMJ. SAMJ consists on a Java-python backend that runs SAM and functionalities based on SAM (SAM segmentation coming soon!) and this repo is the IJ/Fiji specific repository that acts as the front end.
The idea is that every Java based software could use the same SAMJ backend.
Thanks a lot for your interest.
If the plugin works let me know and I will close this issue.
Regards,
Carlos

Forgot to tell that you need to update the plugin in the update site

Awesome!! I am happy to hear that it works!
Thanks a lot for hte help. I am closing this issue, but please do not hesitate to open other issues if you want to ask something or report any other problem.
Carlos


Fix focus state management on dropdown + modal

Perkins CENG_2486, CENG_2491
These are similar and probably related issues between the dropdown and modal components.
Dropdown
When making a selection from the dropdown (or pressing the Escape key to close it), focus returns to the dropdown button but there is not a visible focus.
Modal
When closing the modal visible focus is not evident on the button that triggers the modal.

The Issue is Fixed.
RM Link : https://next--upbeat-sinoussi-f675aa.netlify.app/api/dropdown/
See Screen-cast : http://somup.com/c3iFfDuYYB
Thanks!


Add Purple Theme

This PR contains:
A New Template - Purple
I created a new resume template to display the list items and/or job description options (mentioned in this PR). This template is based off of my own resume, which has gotten me a job 1 or more times in the past 3 years. (amazing! Obviously it works great!)
Notes:

There's CSS for an image but it is commented out in favor of extending the contact info bar & icons across the header.
An about me section can be added in the footer if person.about is set to a paragraph.
Users can add experience.description to add a paragraph to their job description, and/or experience.list to list bullet points about the job. I didn't add these as defaults to person.js because I didn't want to step on any toes if it's not a welcome change.
I think the clickable links are covered by the chrome shadow fixer but i'm not sure how to fix that.
Honestly this is not my proudest work but I just wanted to contribute to making a resume a little more helpful with bullet points etc. If you want to implement across the board, all templates would have to be changed individually.

Purple Theme preview:

Since this PR https://github.com/salomonelli/best-resume-ever/pull/42/files the twmplate vue part is shorter. Would be great if you modify this.

@salomonelli should an "about me" heading be added in the languages?
@mattcheah please use the language support as far as possible. To display the headings uppercase you could use css: text-transform: uppercase;

This looks great. @mbndr I think we need an "about me" in the translations.


Error: __on_close_callback() takes from 1 to 2 positional arguments but 4 were give

Getting below issue very frequently after some time of running program.
ERROR:websocket:error from callback <bound method AlphaTrade.__on_close_callback of <alphatrade.alphatrade.AlphaTrade object at
0x0000025FC445FF70>>: __on_close_callback() takes from 1 to 2 positional arguments but 4 were given
Generally happens on calling following function:
sas.subscribe(optionType, LiveFeedType.COMPACT)
Trace logs are as follows:
ERROR:websocket:error from callback <bound method AlphaTrade.__on_close_callback of <alphatrade.alphatrade.AlphaTrade object at
0x0000025FC445FF70>>: __on_close_callback() takes from 1 to 2 positional arguments but 4 were given
Traceback (most recent call last):
File "d:\alokguptaxggn\python_sandbox\python_stories\python_stories\01-Development\algoTrade\63AlgoTrade-MIS-4-RSI-56.py", line 238, in
putBuyPrice = getOptionPrice(sas, NIFTY_PUT)
File "d:\alokguptaxggn\python_sandbox\python_stories\python_stories\01-Development\algoTrade\63AlgoTrade-MIS-4-RSI-56.py", line 20, in getOptionPrice
sas.subscribe(optionType, LiveFeedType.COMPACT)
File "C:\Users\alokg\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\alphatrade\alphatrade.py", line 857, in subscribe
return self.__ws_send(data)
File "C:\Users\alokg\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\alphatrade\alphatrade.py", line 460, in __ws_send
self.__websocket.send(*args, **kwargs)
ocal\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Pythonpy", line 203, in send
if not self.sock or self.sock.send(data, opcode) == 0:
File "C:\Users\alokg\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\websocket_core.py", line 283, in send
return self.send_frame(frame  File "C:\Users\alokg\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\websocket_core.py", line 311, in send_frame
l = self._send(data)
File "C:\Users\alokg\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\websocket_core.py", line 525, in _send
return send(self.sock, data)  File "C:\Users\alokg\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\websocket_socket.py", line 146, in send
raise WebSocketConnectionClosedException("socket is already closed.")
websocket._exceptions.WebSocketConnectionClosedException: socket is already closed.

Is it possible for your to share the code? using code formatting. I will check it out

I am also receiving this error quite often. It happens sporadically.
2022-08-23 10:52:01,310 - ERROR - nifty_straddle_new.py:292 - Error in subscribing to main instrument : EOF occurred in violation of protocol (_ssl.c:2384)
This happens when I try to subscribe to Nifty feed. Probably it could be for any instrument and not just for Nifty.
try:
      x = sas.get_instrument_by_symbol('NSE', 'Nifty 50')
      sas.subscribe(x, LiveFeedType.COMPACT)
      subscribed = len(sas._AlphaTrade__subscribers)
      sleep(1)
except Exception as e:
      logging.error('Error in subscribing to main instrument : ' + str(e))

Does it has something to do with insufficient memory (RAM)? or anything else? Kindly help.

Is it possible for your to share the code? using code formatting. I will check it out

I am also receiving this error quite often. It happens sporadically.
2022-08-23 12:52:01,310 - ERROR - algo_test.py:292 - Error in subscribing to main instrument : EOF occurred in violation of protocol (_ssl.c:2384)
This happens when I try to subscribe to Nifty feed. Probably it could be for any instrument and not just for Nifty.
try:
      x = sas.get_instrument_by_symbol('NSE', 'Nifty 50')
      sas.subscribe(x, LiveFeedType.COMPACT)
      subscribed = len(sas._AlphaTrade__subscribers)
      sleep(1)
except Exception as e:
      logging.error('Error in subscribing to main instrument : ' + str(e))

Does it has something to do with insufficient memory (RAM)? or anything else? Kindly help.


chore(main): release 2.1.6

:robot: I have created a release beep boop
2.1.6 (2024-11-30)
Dependencies

update dependencies (#53) (b6d3d2f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/aimeerivers/watchthis-home-service/releases/tag/v2.1.6 :sunflower:


Indicate listener ip

Changes Title (replace this with a logical title for your changes)
Description
The documentation for the Dimension Data Cloud REST API v2.2-20160222 states that a load balancer can be statically assigned a listener IP on creation. This change fixes the dimension data driver to conform to the docs.
Status

done, ready for review

Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[x] Documentation
[x] Tests
[ ] ICLA (required for bigger changes)

Please note that the first commit (sha ca10bbd) is part of PR #814

Waiting on resolution of #814


[Feature] R client for Sacred

Does Sacred already support tracking experiments using the R language?

Unfortunately not (directly) as it is fully written in Python. There is a bridge between Python and R (https://rpy2.github.io/) that could possibly be used for this.


Logo proposal for BookShelf

Hi, my name is Zuur W. I'm a graphic designer and I'd like to collaborate on your open source project and propose free logo/icon design for your project. If it's something you're interested in, please, let me know!
Best Regards
Zuur

Hi Zuur!
I would definitely be interested. Thank you!

Hi @Nevenall, do you have any request or any idea from what you want? Can you give me something to get inspired?
Best Regards!

Yes, I definitely have some thoughts.
This is the existing logo I did from http://game-icons.net/
BookShelf is intended to be used for multiple books, each with its own custom style, so some indicator of multiplicity would be cool. As would a logo friendly to having it's color changed to match a particular book's theme. Or match a book's theme in some other way. :)
Ideally, I'd like something that looks identifiable and nice at smaller sizes like 32x32px.
Hope that helps!

Hi @Nevenall, here is my design for BookShelf, I create something simple and easy to remember and I think it works good on smaller sizes.
First I create the logo just for one color, but I add also a two color logo.
Send me your feedback.
Best Regards!

Cool! I like that!

Hi @Nevenall, Im happy that you like it.
What color do you want for the logo? after you decide I will create a pull request with the files.
Best Regards!

Hi @Nevenall can I make the pull request?
Best Regards!

Hi @Nevenall, I create the PR with logo design files and I put also the logo on the README and It looks really good.
Best Regards!

Hi @Nevenall, here is the link https://github.com/zuurw/Graphic-Design-
Do you have other projects to work, that need a logo?
Best Regards!

In the near future I am going to be working on an app for a friend to track student achievements. I'll ping you when I get started.
Thanks again!


Pursue players and dont get food/people in viruses

Title says it all.
You should pursue players and not treat them like food.
You should NOT collect food or people in the viruses

Oh, that's a good way to see it.

#323

@Drflash55 Can you confirm this ?

@ErmiyaEskandary I don't think it would make a difference if I tried out previous versions, as Agar.io itself has been updated quite a lot lately.
Pretty sure that if the newer version is bugging out, trying to go back to a legacy version won't fix the issue, as the bot needs to be updated to remove the bug in the first place.

I was talking about if the bot pursued player in an older version where the bot was playable. At the moment, the phantom bug is being worked on. ;)


✨[feature Request]: Fixing Navbar size and responsiveness

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description

I want to fix the Navbar UI
Use Case
Enhancement in UI
Benefits
Enhancement in UI
Add ScreenShots
No response
Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

Please assign this to me

@Pheonixrog go ahead


Building Android-go in Android Open Source Project (AOSP)

How can we build android-go in Android Open Source Project (AOSP) for android marshmallow 6.0. Can you please help me with the steps for it. And after building Android-Go, will it generate JAR file so that other application can use this?

Hi! This project isn't about JARs and other Java applications, you should check out https://github.com/golang/mobile instead.

How can we build android-go in Android Open Source Project (AOSP) for android marshmallow 6.0.

I had no problems building and running apps for any Android versions between 4.4.3 and 7.0 using this package. You should adjust the scripts to use proper Android NDK paths and versions:
about paths
https://github.com/xlab/android-go/tree/master/example#prerequisites
about SDK versions
https://github.com/xlab/android-go/blob/master/example/Makefile#L2
https://github.com/xlab/android-go/blob/master/example/android/Makefile#L11-L13

Hi, Thank you for quick reply. I will go through the links.

Hi Maxim, I am getting the below error while compiling android-go,I am following as mentioned in the above links. Could you please help me with this.Sorry if it is a silly question, I am new to this.
processing android.yml ⠼[ERR] /home/user/spade_sorcecode/HDU_MARSHMALLOW/android-ndk-r14/platforms/android-23/arch-arm/usr/include/android/asset_manager.h:89:43: unexpected identifier size_t, expected parameter declaration or one of [..., _Bool, _Complex, _Noreturn, auto, char, const, double, enum, extern, float, inline, int, long, register, restrict, short, signed, static, struct, typedef, typedefname, typeof, union, unsigned, void, volatile]
make: *** [gen-android] Error 1

Hi Maxim, I am getting the below error while compiling android-go,

You don't have to run generation of bindings, if you really don't want to do that.
The makefile you're invoking is for project maintainers https://github.com/xlab/android-go/blob/master/Makefile

android-go package is go get-able.

Is it though? I am just trying this out, but I get the following:
$ echo $GOPATH
/home/pao
$ pwd
/home/pao/src/github.com/xlab
pao@janus:~/src/github.com/xlab$ ls
closer
$ cd
$ go get github.com/xlab/android-go
package github.com/xlab/android-go: no buildable Go source files in /home/pao/src/github.com/xlab/android-go
$ go version
go version go1.6.2 linux/amd64
$ cd ~/src/github.com/xlab/android-go
$ ls
android      app  egl.yml  example-egl  gles2      gles3   gles31.yml  gles.yml     Makefile
android.yml  egl  example  gles         gles2.yml  gles31  gles3.yml   LICENSE.txt  README.md
What is wrong?

Sorry, I meant packages in this project.

github.com/xlab/android-go/android — the bindings to Android NDK and helpers
github.com/xlab/android-go/app — the app framework (the minimal glue)

you can check all packages available in this project at
https://github.com/xlab/android-go#project-structure

Thanks a lot. I am able to build and install.

Thanks a lot. I am able to build and install.

Hey Brother , I am also a bigginer in this field and really want to build a custome rom based on android go edition i need your help in this . will you please guild me to build this rom .
My android is having Marshmallow(6.0) os with 1gb ram and 8 gb internal storage.Arm 64

@Utkarsh104 any android can run go binaries, you can follow the tutorials like this:
https://github.com/golang/go/wiki/Mobile
After you build the first Android app that writes something to console, you can use this package to have better flexibility. That means it's harder to use, but more possibilities, such as custom 3D drawing surfaces.

@Utkarsh104 any android can run go binaries, you can follow the tutorials like this:
https://github.com/golang/go/wiki/Mobile
After you build the first Android app that writes something to console, you can use this package to have better flexibility. That means it's harder to use, but more possibilities, such as custom 3D drawing surfaces.

If you don't mind can i get your personal email address so i can directly contact you instead of replaying in comment section. I have some question in my mind and i want to share it with you .


Refactor all the things

The important part of this huge (sorry!) refactoring is base.ts.
This changes Transpiler.visit to dispatch to a sequence of transpiler steps that each implement one aspect of transpilation, by calling visitNode on the step. If a TranspilerStep's visitNode method returns true, the node is considered to be handled, otherwise further steps can handle it. The TranspilerStep base class (in base.ts) provides basic support methods (visitEach, emit etc) and dispatches back through to Transpiler.visit.
Transpiler itself retains functionality for handling transpilation in general, source maps, files, errors, and output. It might make sense to pull it apart further. For now, this cleans up our "giant file syndrome".

Note that the ugly shim methods in base.ts dispatching back to transpiler go away in a later commit, those are only temporary.

great!

Pushed as 836ac94.

All comments applied, except for the closing quote to fix the highlighter.


Feature request: Add a way to directly perform a Raycast from a Camera

Godot version: 3.0.5 +
https://godot.readthedocs.io/en/latest/classes/class_camera.html
The Camera node has some methods for assisting with projecting rays, but none of these methods actually perform full Raycasts. I think it would be useful to have a method which returns a RayCast object containing a RayCast from the mouse position on the screen into the world. That way, I could, for example, simply run get_collision_point() on that returned RayCast object to figure out the 3D point on a CollisionShape in the world that the camera is pointing at.

Why not just:

Putting a RayCast node as child of the camera pointing forwards?
Or doing the raycast via code using -transform.basis.z?

https://godotengine.org/qa/1996/ray-casting-from-the-camera-in-3d
also input_ray_pickable may also help if you're trying to pick objects from your camera and mouse.
https://godotengine.org/qa/1996/ray-casting-from-the-camera-in-3d


Be clear that Node 18+ is required

Explicitly declare in README that Node 18+ is required.
Add a .nvmrc.
Add an engines field to the package.json.

Fixes #6236
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

LGTM. Nice one!

Could we also add this to .nvmrc to avoid to have to edit it locally?
registry=https://registry.npmjs.org/
Also, we should do the same for ./examples I think.

@mvaligursky That goes in .npmrc, not .nvmrc.

I used to build the engine on my old Ubuntu VM/server and it doesn't support node v18:
https://github.com/rollup/rollup/issues/5497
There are hundreds of other people with the same issue: https://stackoverflow.com/questions/72921215/getting-glibc-2-28-not-found
The "solution" is "install v16"... software disintegrates quicker than you can fix it these days :disappointed:


fix: notfound in wrong place #342

Description
path was wrong for the not-found file

Related Issue
closes #342

Motivation and Context

fix the issue in #342
How Has This Been Tested?
ran it locally

Screenshots (if appropriate):

fyi @Savinvadim1312


🚀 Release  1.4.0

:robot: I have created a release beep boop
1.4.0 (2022-10-24)
✨ Features

generate coverage badges and clean commit comments (#22) (3b0173c)

👷 Maintenance

add badges to README.md (1e948f5)
get branch that triggered workflow from context (c90ef4a)
log context (fb32012)
remove branchName from readme (e38dcf0)

🚨 Bug Fixes

branch name (209e73b)
fix percentage sign on badges (694268f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/carlosdevpereira/test-publish-to-cloudflare/releases/tag/v1.4.0 :sunflower:


Upgraded golang.org/x/net

Signed-off-by: Andy Tinkham<EMAIL_ADDRESS>Desired Outcome
Upgrade module to latest version
Implemented Changes
Upgraded golang.org/x/net to v0.0.0-20211209124913-491a49abca63
Changelog

[X] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a
CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code
changes, or
[X] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: insert issue ID
[X] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[X] No behavior was changed with this PR

Security

[X] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[ ] There are no security aspects to these changes

Going to fix a different way


[Feature] Engine API: Merge requests into a single list

Component
rpc
Describe the feature you would like
Currently we have one list per request type in the engine API execution payloads, but for devnet 4 these will be merged into one list: https://github.com/ethereum/execution-apis/pull/577
Additional context
No response

Closed in #1383


Delete ProjectN specific parts of TypeManagerHandle

cmdLine:/__w/1/s/tests_downloaded/CoreCLR/JIT/opt/virtualstubdispatch/bigvtbl/bigvtbl_cs_ro/bigvtbl_cs_ro.sh Timed Out


Update github-mobile.md

Why:
Removing<EMAIL_ADDRESS>from the doc since it's no longer a vector to collect feedback for mobile. See more details here - https://github.com/github/zendesk/issues/2410#issue-1235450041

What's being changed (if available, include any code snippets, screenshots, or gifs):

Removed If you find a bug in {% data variables.product.prodname_mobile %}, you can email us at <a href="mailto:mobilefeedback<EMAIL_ADDRESS>from the file.
Check off the following:

[ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@candyho Thanks so much for opening a PR! I'll get this triaged for review :zap:


Angular Support

This isn't an issue but rather a request or discussion. Will you consider adding api methods to support angular and typescript compilation to laravel mix? we already have react() method, it only makes sense to add support to the other big player.
I've made a simple repository that allows using Laravel with Angular 4. it works with webpack.mix.js or just a webpack.config.js file
https://github.com/vinceg/laravel-angular
It won't be hard to add support for typescript and angular compilation.
Thank You.

Yes, I'm more than happy to add mix.angular() to the main API. Just submit a PR and we'll merge it.
Let me know if you have any questions. You can review the mix.react() implementation for ideas.
https://github.com/JeffreyWay/laravel-mix/blob/master/src/Api.js#L29

Hey...can i run this proyect laravel-angular with php artisan serve?


Be able to rollback upgrades

(Backup package.json to package.json.bak before --force upgrade)
or
git reset, rimraf node_modules and re-run npm install

A better strategy might be to remember the git commit hash before starting the upgrade and rollback using git commands. This is partially implemented in #34, but not the interesting part of remembering the git commit hash to rollback to.


Not able to login to "Default" Site name

Hi Team,
I have simple code to show a list of Projects from a Site.
import tableauserverclient as TSC
server = TSC.Server("https://tableauserver.com/")
tableau_auth = TSC.TableauAuth('user name', 'password','Default')
with server.auth.sign_in(tableau_auth):
all_projects, pagination_items = server.projects.get()
projects = [projects.name for projects in all_projects]
print(projects)
From the above code, Default is a Default site, I am not able to log in using the Default site.
We have multiple sites, so if I give any other site name, it is working.
If I leave it as a blank, I see a list of Projects from all sites as we have multiple sites.
I have a requirement where I need to show a list of Projects from the Default site.
This is the error i see.

Thanks
Pavan Kumar

Leaving it blank is the way to say you want the default site. I'm not sure how you could end up showing projects from all sites, the API call needs a specific site to look for. Are you sure that's what's happening, and it's not just that the default site contains projects that look like other sites?

My bad, i was looking in a different way. Thanks for the responce


hire dates not autofilled when editing a hire

also not autofilled when the form submission is rejected because of a (separate) error

Identified as an issue with IE11, not present on Chrome/FF

I think I originally discovered it on Safari for Mac. FF and Chrome
automatically refill forms for you - I would argue that the burden should
be on the server to do this as it has rejected the form!
On Fri, 23 Feb 2018 at 10:24, Jon Salmon<EMAIL_ADDRESS>wrote:

Identified as an issue with IE11, not present on Chrome/FF
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Jon-Salmon/Durham-Hires/issues/12#issuecomment-367970177,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMgNloC3t2-IcIowPEX4MT2hAY_dOFCRks5tXpHZgaJpZM4QsJW8
.

--
Sent from my iPhone

It's some issue with vue and the vuedatepicker used, basically the server's correctly returning the date into the vue data structure, just that then isn't updating initially. Oddly, it can set the date just fine after page has loaded as after setting a start date, the end date field is auto filled which should be using the same mechanism!

Just tried editing a hire but can't as the date fields are disabled but the dates aren't auto-filled!
If it's not something we can easily fix completely due to a bug in vue/vuedatepicker, can we change the server-side logic to treat a null/missing date field as unchanged? That would at least let me confirm a hire!

Probably a good idea, it's something browser specific as it does work on firefox and chrome, but doesn't on IE and Safari (I think)


getLastExecutionResult has no param bulidID

I want to get all testcase execution under a bulid，but I don't find a function

Please, see comment for issue #80


Default to not run init scripts after first run

I take the concept init scripts as being scripts that are run only when something needs to be setup. I've noticed that your script automatically wants to run any init script by default every time. Is there a way to make init scripts not default to be run after the first run? Example: I run dotfiles for the first time and all the init scripts default to run but then every subsequent run afterwards defaults to not run since everything doesn't need to be run every time. Thanks.

I found out this can be achieved by removing the menu selects code in initialization as shown by this commit.


fix:temporarily debugging an error

Install the beta version with
npm install @probot/adapter-aws-lambda-serverless@beta

deploy to lambda, try again, share what the logs say


Make jellyfish wasm compatibility

This issue aims to achieve wasm compatibility:

[ ] finish #111
[x] document slowdown (if any) and limitations in the wasm version.
[x] add wasm compilation check in CI
[ ] pay extra attention to entropy sampling (as /dev/random is no longer available, the usage of PRNG, seed length etc has to be more conservative chosen)

While doing #318, on my local M1,
native benchmark:
$ cargo flamegraph --root --bench=plonk-benches --features test-srs

proving time for Bls12_381, PlonkType::TurboPlonk: 52120 ns/gate
proving time for Bls12_377, PlonkType::TurboPlonk: 53111 ns/gate
proving time for Bn254, PlonkType::TurboPlonk: 44123 ns/gate
proving time for BW6_761, PlonkType::TurboPlonk: 215765 ns/gate
proving time for Bls12_381, PlonkType::UltraPlonk: 79688 ns/gate
proving time for Bls12_377, PlonkType::UltraPlonk: 78137 ns/gate
proving time for Bn254, PlonkType::UltraPlonk: 69546 ns/gate
proving time for BW6_761, PlonkType::UltraPlonk: 341935 ns/gate
verifying time for Bls12_381, PlonkType::TurboPlonk: 2504441 ns
verifying time for Bls12_377, PlonkType::TurboPlonk: 2597979 ns
verifying time for Bn254, PlonkType::TurboPlonk: 3948429 ns
verifying time for BW6_761, PlonkType::TurboPlonk: 8686679 ns
verifying time for Bls12_381, PlonkType::UltraPlonk: 2658983 ns
verifying time for Bls12_377, PlonkType::UltraPlonk: 2570262 ns
verifying time for Bn254, PlonkType::UltraPlonk: 1644525 ns
verifying time for BW6_761, PlonkType::UltraPlonk: 9560779 ns
batch verifying time for Bls12_381, PlonkType::TurboPlonk, 1000 proofs: 15505 ns/proof
batch verifying time for Bls12_377, PlonkType::TurboPlonk, 1000 proofs: 16257 ns/proof
batch verifying time for Bn254, PlonkType::TurboPlonk, 1000 proofs: 16841 ns/proof
batch verifying time for BW6_761, PlonkType::TurboPlonk, 1000 proofs: 31831 ns/proof
batch verifying time for Bls12_381, PlonkType::UltraPlonk, 1000 proofs: 17502 ns/proof
batch verifying time for Bls12_377, PlonkType::UltraPlonk, 1000 proofs: 18538 ns/proof
batch verifying time for Bn254, PlonkType::UltraPlonk, 1000 proofs: 16461 ns/proof
batch verifying time for BW6_761, PlonkType::UltraPlonk, 1000 proofs: 37605 ns/proof

targeting wasm:
$ cargo flamegraph --root -o wasm-flamegraph.svg --bench=plonk-benches --no-default-features --features test-srs -- --target=wasm32-unknown-unknown

proving time for Bls12_381, PlonkType::TurboPlonk: 228241 ns/gate
proving time for Bls12_377, PlonkType::TurboPlonk: 226454 ns/gate
proving time for Bn254, PlonkType::TurboPlonk: 173796 ns/gate
proving time for BW6_761, PlonkType::TurboPlonk: 925769 ns/gate
proving time for Bls12_381, PlonkType::UltraPlonk: 349392 ns/gate
proving time for Bls12_377, PlonkType::UltraPlonk: 338768 ns/gate
proving time for Bn254, PlonkType::UltraPlonk: 275681 ns/gate
proving time for BW6_761, PlonkType::UltraPlonk: 1245619 ns/gate
verifying time for Bls12_381, PlonkType::TurboPlonk: 2516504 ns
verifying time for Bls12_377, PlonkType::TurboPlonk: 2743795 ns
verifying time for Bn254, PlonkType::TurboPlonk: 1684900 ns
verifying time for BW6_761, PlonkType::TurboPlonk: 11598887 ns
verifying time for Bls12_381, PlonkType::UltraPlonk: 2768262 ns
verifying time for Bls12_377, PlonkType::UltraPlonk: 3081320 ns
verifying time for Bn254, PlonkType::UltraPlonk: 1837012 ns
verifying time for BW6_761, PlonkType::UltraPlonk: 12966108 ns
batch verifying time for Bls12_381, PlonkType::TurboPlonk, 1000 proofs: 52437 ns/proof
batch verifying time for Bls12_377, PlonkType::TurboPlonk, 1000 proofs: 52356 ns/proof
batch verifying time for Bn254, PlonkType::TurboPlonk, 1000 proofs: 47650 ns/proof
batch verifying time for BW6_761, PlonkType::TurboPlonk, 1000 proofs: 91287 ns/proof
batch verifying time for Bls12_381, PlonkType::UltraPlonk, 1000 proofs: 61210 ns/proof
batch verifying time for Bls12_377, PlonkType::UltraPlonk, 1000 proofs: 60756 ns/proof
batch verifying time for Bn254, PlonkType::UltraPlonk, 1000 proofs: 55146 ns/proof
batch verifying time for BW6_761, PlonkType::UltraPlonk, 1000 proofs: 106205 ns/proof

The caveats is that I'm not using any wasm runtime like wasmtime, so I'm not sure how accurate is the wasm target binary benchmark, will investigate more later.
But on the surface, it seems that inside wasm is 2~2.5x slower.

 If you don't provide any runtime how the wasm code is executed? My guess is that by specifying --no-default-features you disabled parallel feature and this is the cause of worse performance. From my experiments, it seems that wasm performance is ~10x worse comparing to native without rayon.

I believe so. What I did to get perf data that you can then feed to flamegraph was:

cargo build --release --target wasm32-unknown-unknow
perf record -k mono wasmtime --profile=jitdump prover.wasm
perf inject --jit --input perf.data --output perf.jit.data

Then you can either inspect perf.jit.data with perf perf report --input perf.jit.data or use some frontend


Setting Input Decorators fails in production build, but not in development build

There seems to be some sort of configuration bug as I set the input like this
    @Input() set defaultColor(colorName: string) {
        this._defaultColor = colorName || this._defaultColor;
    }

It works perfectly fine when I do a development build. However when I build it in production mode, no errors are thrown during compiling. However, when I load it in the browser, browser.js throws an Uncaught TypeError... when I look at the trace it shows
function decorate(decorators, target, targetKey, targetDescriptor) {
        if (!is_undefined_1.isUndefined(targetDescriptor)) {
            if (!is_array_1.isArray(decorators)) {
                throw new TypeError();
            }
            else if (!is_object_1.isObject(target)) {
                throw new TypeError();
            }
            else if (is_undefined_1.isUndefined(targetKey)) {
                throw new TypeError();
            }
            else if (!is_object_1.isObject(targetDescriptor)) {
                throw new TypeError(); // <---------- This where where the error is thrown from the browser.js file webpack creates
            }

        }

The same bug occurs on every other directive that has a input setter as well. What could be the issue?

can use use @Input('defaultColor') and see if you have the same error?

Same as #190

@gdi2290 It still gives the error (only in production, not dev).
@manavsehgal when I comment out CommonsChunkPlugin for common, it just moves up to vendor to being the file that calls the same error. If I comment out the plugin for vendor it just moves up to main.
It works without a problem in plunker, but not in production build: https://plnkr.co/edit/XBqIYu4aHyNi7TJtc5wH?p=preview
Every directive I have with an input setter breaks in production build.

oh yeah there was a problem with CommonsChunkPlugin for common that needs to be removed

Do I need to install a new version of that plugin or redownload this repo? This is the part I commented out on production config, let me know if I'm commenting out the wrong areas.
plugins: [
    //new CommonsChunkPlugin({
    //  name: 'vendor',
    //  filename: 'vendor.[hash].bundle.js',
    //  minChunks: Infinity
    //}),
    //new CommonsChunkPlugin({
    //  name: 'common',
    //  filename: 'common.[hash].bundle.js',
    //  minChunks: 2,
    //  chunks: [
    //    'main', // keep sync with entry
    //    'vendor'  // keep sync with entry
    //  ]
    //}),
    // static assets

Still not working after commenting out either of the two or both of the above.

leave the vendor CommonChunk

you also want to move DedupePlugin  and OccurenceOrderPlugin to be first
https://github.com/AngularClass/angular2-webpack-starter/blob/master/webpack.prod.config.js#L106

@gdi2290 The issue persists. I just did a clean install of the latest repo and the error is still there. There is still something wrong with the current build.
To reproduce error, all you have to do is...

Have latest repo installed.
Copy the template from app.ts into project app: https://plnkr.co/edit/XBqIYu4aHyNi7TJtc5wH?p=preview
Copy the attributeSample.ts from above plunker and copy and import it into app.
Do a production and it will compile successfully, but soon as you open up browser you will see the error

browser.js:130 Uncaught TypeError

r	@	browser.js:130
(anonymous function)	@	attributeSample.ts:12
webpackJsonp.499	@	main.7e53375de59da6dff570.bundle.js:79
e	@	bootstrap 97a8b9bfeb46a22d04b6:50
webpackJsonp.498	@	app.ts:9
e	@	bootstrap 97a8b9bfeb46a22d04b6:50
webpackJsonp.0	@	main.ts:13
e	@	bootstrap 97a8b9bfeb46a22d04b6:50
window.webpackJsonp	@	bootstrap 97a8b9bfeb46a22d04b6:21
(anonymous function)	@	main.7e53375de59da6dff570.bundle.js:1

can you update the prod config. see https://github.com/AngularClass/angular2-webpack-starter/issues/203

@gdi2290 thanks, it works great now :+1:

Thanks for opening an issue. If you have any more questions or problems feel free to open another one