[Feature] : Implement Dark/Light Toggle Theme to the Website.

Description :
Add a toggle switch to allow users to switch between dark and light themes across the website. The toggle should be easily accessible and instantly apply the selected theme across all pages, providing a consistent experience. The theme selection should also be remembered between sessions, ensuring the user's preference is retained.
Requirements :

Toggle button for dark/light mode should be present in the navigation bar or a prominent, user-friendly location.
On toggle, all elements (text, background, buttons, etc.) should seamlessly transition between light and dark themes.
Implement smooth transitions between themes for better user experience.
Ensure compatibility with all website components (e.g., Navbar, Footer, etc.).

not needed , the site color right now is good to not require any inversion


ABI should be stored in the account cache

If I made the ABI serializable, I could store it directly in the account (or even I could store the whole list of ABI needed for the from accounts as well). The ABI for a contract is immutable. It would increase the size on disc, but I wouldn't have to rely on it being in the folder.

Moved to https://github.com/Great-Hill-Corporation/quickBlocks/issues/63


Incorrect quick link is getting highlighted when particular section is loaded using deep linked url

As seen in screenshot below, incorrect link is getting highlighted.

When quick link is clicked, url in address bar is not modified.

@yugandhar02  that is not happening in the original website as well ?

@vivesing  do we support this ?

As seen in screenshot below, incorrect link is getting highlighted.

Thanks @yugandhar02 for finding this, I can relook into this

When quick link is clicked, url in address bar is not modified.

This beahviour has been added intentionally to match the original page


[Practice Website], FreeCodeCamp etc

Category Name
Practice Website
Subcategory Name
Freecodecamp
Additional Context
There are lots of useful websites that let you code with in-browser IDEs such as FreecodeCamp and many more!! which can help beginners with industrial practices.
And can you suggest any good category name for this?
Thank You
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I have checked that this category does not exist
[X] I have checked that this subcategory does not exist
[X] I am willing to work on this issue (optional)
[X] I am participating in Hacktoberfest 2023

It's already there.

Do you want to add a new resource here.
I may be getting the wrong idea, so do correct me.

Ohh! What I meant is that FreeCodeCamp has project-based learning, and Codedamn, Exercism is also similar to it.

@Amanmawar17
As you can see these already exists for various subcategories.

What do you suggest, making a new subcategory?
It might be a good idea, let me know the subcategory name and which type of platforms will be there.

Can I add a certification sub-category as project-based learning in resources, and I also saw that certification in placement prep is empty.
We can also moves online code editor from frontend to resources.

@rupali-codes @CBID2
What do you think? I'm kinda confused. But the options like codecademy, exercism, freecodecamp can be in 1 category due to learning by solving step wise questions from instructions.

@rupali-codes @CBID2
What do you think? I'm kinda confused. But the options like codecademy, exercism, freecodecamp can be in 1 category due to learning by solving step wise questions from instructions.

Self-paced courses maybe @Anmol-Baranwal?

So, should I add self-paced courses as a sub-category in resources?

Self-paced courses maybe @Anmol-Baranwal?

Yeah, great suggestion.

So, should I add self-paced courses as a sub-category in resources?

@Amanmawar17
I have assigned you the issue. Please proceed with it, and don't hesitate to tag me @Anmol-Baranwal or @CBID2 if you require any assistance.

@Amanmawar17
Please update the description of this issue to reflect what you need to add. It will be in resources as you suggested.

Is it look good? @Anmol-Baranwal

Is it look good? @Anmol-Baranwal

Looks great. Please raise a PR 😄


Add support for interactively checking out a branch

This is a follow-up from the discussion here. It updates the git co command to check if the selected commit is associated with a single branch, and checks that out if so.

Thanks for looking into this! Can we try instead implementing this logic in core::check_out::check_out_commit? That way, we can benefit from this behavior in other places too.

My Rust is gross (lots of copying/mut) and any pointers are greatly

Generally, rather than write
let mut foo = 1;
if cond {
    foo = 2;
}

you would write
let foo = 1;
let foo = if cond { 2 } else { foo };

Similarly, to return multiple values from a conditional statement, you can return a tuple (or even a struct if it gets to be particularly complicated):
let (foo, bar) = if cond {
    (true, "hello")
} else {
    (false, "world")
}

instead of checking out , it checks out refs/heads/.

I think check_out_commit has a fix for this anyways (where it calls remove_prefix).
You may need to update tests for this change. If necessary, to review snapshot tests interactively, you can install cargo-insta and run cargo insta review.

Also, I added a refactoring for the checkout target in https://github.com/arxanas/git-branchless/pull/514 which might help, so you may want to rebase your work on top of that.

Thanks! Pulled in your changes, and moved the code into core check_out. Made some of the code less gross, but I'm sure there's plenty of room for improvement.
Currently, I'm just looking for all local branches then checking for an oid match, which may be expensive for large repos. If there's an cheaper way to say "give me all the branches with this oid", we should probably do that.
Looks like the tests are passing, but it seemed like lots of tests required updates. Some of them made sense, we're no longer checking out a detached commit, so the hash is replaced with the branch name, but others were more puzzling (e.g. why does test_reword need to change?)

Not sure why the tests are failing, they work fine locally and produce no diffs in need of review. Given the failing output, looks like the feature might be broken in CI, I'll take a look at this later today

My bet is that you just need to apply this patch:
diff --git a/git-branchless/tests/command/test_navigation.rs b/git-branchless/tests/command/test_navigation.rs
index 3aa0d90..5eb0153 100644
--- a/git-branchless/tests/command/test_navigation.rs
+++ b/git-branchless/tests/command/test_navigation.rs
@@ -859,6 +859,7 @@ fn test_checkout_auto_switch_interactive() -> eyre::Result<()> {
             PtyAction::WaitUntilContains("> "),
             PtyAction::Write("test1"),
             PtyAction::WaitUntilContains("> test1"),
+            PtyAction::WaitUntilContains("> 62fc20d"),
             PtyAction::Write(CARRIAGE_RETURN),
         ],
     )?;
@@ -902,6 +903,7 @@ fn test_checkout_auto_switch_interactive_disabled() -> eyre::Result<()> {
             PtyAction::WaitUntilContains("> "),
             PtyAction::Write("test1"),
             PtyAction::WaitUntilContains("> test1"),
+            PtyAction::WaitUntilContains("> 62fc20d"),
             PtyAction::Write(CARRIAGE_RETURN),
         ],
     )?;

The failure case on CI (or a slow machine in general) is that the process can exit before the UI has a chance to select the given item, which means that nothing will happen when you exit the process because you haven't selected a switch target. It's not clear at all from just the test case, but there are two carets of interest in the UI. Example screenshot:

One of them is the prompt where you're typing, and the other is the actual selection. You need to wait for the actual selection to complete before exiting. (I guess it would be possible to not have the wait for > test1 at all; I don't remember if there's a reason that the other test cases have that.)

Other than the failing tests, everything looks good to me. When you're done, please squash and force-push your changes and I'll merge this PR. Thanks for working on this!

We have some failing Nix tests already for PTY-related stuff, so I just added the new failing tests introduced in this PR to the list of skipped tests. @bcspragu thanks for your contribution!


Parsing not exactly like in GitHub

In GitHub - [ ] without space in the end is not a task list item, here it is. The rule should check if there is a space after the [ ].

Nice find, I'll definitely have to fix this. Thanks!

Fixed in 1.4.1. Thanks again @astoilkov! ✨


Setting namespace for  "Given Kubernetes pod {name} is running" and "Given Camel-K integration {name} is running"

Hi!
I want to check if  a camel-k integration is running on the cluster before send a request to it. Due to some restrictions the yaks test is not running in the same namespace as the integration.
I tried out the kubernetes and camel-k steps.
Here are the things I tried:
Given Kubernetes namespace name-of-integration-namespace
Given Kubernetes pod name-pod-integration is running
Given Kubernetes name-of-integration-namespace
Given Kubernetes pod labeled with camel.apache.org/integration=integration-name is running --> only one replica
Given Kubernetes namespace name-of-integration-namespace
Given Camel-K integration integration-name is running
Unfortunately none of things are tried are working. The first two tries should be working after reading the documentation. The last example should not work, because the steps are from different packages

There is an issue with Given Kubernetes namespace ... as it does not fully control the namespace for inspecting Kubernetes resources.
Kubernetes and Camel-K namespace settings are separate, so we also miss a step Given Camel-K namespace ... respectively.
Fortunately as a workaround you can set the namespace via env variables in yaks-config.yaml configuration. Something like this:
config:
  runtime:
    env:
      - name: YAKS_KUBERNETES_NAMESPACE
        value: <name-of-integration-namespace>
      - name: YAKS_CAMELK_NAMESPACE
        value: <name-of-integration-namespace>

Now your test should look for the right namespace when doing a Given Camel-K integration ... is running.
Of course you need to make sure that the service account yaks-viewer in the yaks test namespace is granted to list resources in the integration namespace.
Please let me know if this works for you

Fixed


⚠ ClamAV has degraded performance

In 8269fdc, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in b609227.


Implement buffer functionality

Configurable buffer to avoid Gateway Stream overload.
It depends on having a GW deployed that can receive a bundle of messages as an Array of objects instead of a single element.

commit 5d376c4 closes #7


Fix: members can now view agreements that have not launched yet

:tada: This PR is included in version 1.28.0-dev.16 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.28.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use individual project symlinks for current

This allows having one package updated and restarted without disrupting
other packages while in an upgrade. NOT INTENDED FOR MIXED VERSIONS
OUTSIDE OF UPGRADES!
Also attempts to migrate an existing current symlink into the individual
symlinks based on the current target.

This does not touch upgrade.yml as I have another PR for that for the 1.2.x to 2.x upgrade path, where much of it will change.

This is looking really good (and really cool)! I'm going to try running it this weekend. I'll let you know how it goes.

LGTM but needs a rebase


Pass payload to keyfinder

I have an app that I would like to authenticate to using tokens signed with HMAC (created by the app) or ECDSA (created by other companies), depending on the value of the issuer (iss) claim.  I'm using the keyfinder block to implement that logic, but it needs to have the payload passed to it in order to find the appropriate public key for the issuer.  To that end, I made a small change to pass both the header and payload to keyfinder, if it has arity of 2.  Now my calling code looks like:
payload = JWT.decode(token, nil, true) do |header, payload|
  alg = header['alg']
  if alg.starts_with?('HS')
    # HMAC token
    Rails.application.secrets[:secret_key_base]

  elsif alg.starts_with?('ES') && (pub_key = Company.where(id: payload['iss']).pluck(:public_key).first)
    # ECDSA token
    OpenSSL::PKey::EC.new(pub_key)

  else
    nil
  end
end.first

Added check that keyfinder returns a key.

Made style changes.

Thanks. :)


Fixed-text English i18n

PR for adding fixed-text English strings to the web app, as part of #406.
This is currently a WIP.
Just sharing my progress to confirm I'm not doing anything egregious.
Some sample screenshots of what's been done:

@sruenwg
I apologize, but there seems to be a conflict in the getStaticProps processing. I would appreciate it if you could fix it. 🙇

@sruenwg
Thank you very much for proceeding so quickly 🙇
I will handle the translation for contents 1 to 3 on my end!  (The original Japanese content is outdated, so I will revise and translate it simultaneously...)
Therefore, the scope of this PR should mainly focus on handling the dynamic content (livestream, clip, event...) pages!! (They are probably almost complete?)


Bug when clean edittext

I like to click the "x" for cleaning all edit content when I input wrong data,but it will disappear in sample:

Search something and go into ResultActivity
delete all edit content
input some new characters

the "x" will never appear only if you return to last Activity

Thank you for your update,bug has disappear

Thank you for your update,bug has disappeared


Update module go.mozilla.org/sops/v3 to v3.8.0

This PR contains the following updates:

Package
Type
Update
Change

go.mozilla.org/sops/v3
require
minor
v3.7.3 -> v3.8.0

Release Notes

mozilla/sops (go.mozilla.org/sops/v3)
v3.8.0
Compare Source
Note from the Maintainers
We are extremely happy to introduce this new minor release of SOPS, now a CNCF Sandbox project under the stewardship of a new group of maintainers.
This release involved significant effort in rewriting and enhancing key source implementations, and includes a number of bug fixes which people had been patiently waiting on for a long period of time. In addition, the release process has been built up from scratch, and now now provides enhanced assurance by publishing SBOMs (Software Bill of Materials), SLSA3 provenance attestations and a Cosign signed checksums file as release artifacts.
For a comprehensive list of changes, please refer to CHANGELOG.rst.
Important Information for SOPS SDK Users
With the project transitioning from the Mozilla Foundation to the CNCF, the Go module path has been updated to reflect this change in ownership. If you use go.mozilla.org/sops/v3 as a library, going forward, import the Go Module using github.com/getsops/sops/v3. Apart from this small adjustment, the SDK's API remains fully backward compatible.
For a one-liner to quickly implement this change throughout your codebase, please refer to: https://github.com/getsops/sops/issues/1246#issuecomment-1625526429
Installation
To install sops, download one of the pre-built binaries provided for your platform from the artifacts attached to this release.
For instance, if you are using Linux on an AMD64 architecture:

### Download the binary
curl -LO https://github.com/getsops/sops/releases/download/v3.8.0/sops-v3.8.0.linux.amd64

### Move the binary in to your PATH
mv sops-v3.8.0.linux.amd64 /usr/local/bin/sops

### Make the binary executable
chmod +x /usr/local/bin/sops

Verify checksums file signature
The checksums file provided within the artifacts attached to this release is signed using Cosign with GitHub OIDC. To validate the signature of this file, run the following commands:

### Download the checksums file, certificate and signature
curl -LO https://github.com/getsops/sops/releases/download/v3.8.0/sops-v3.8.0.checksums.txt
curl -LO https://github.com/getsops/sops/releases/download/v3.8.0/sops-v3.8.0.checksums.pem
curl -LO https://github.com/getsops/sops/releases/download/v3.8.0/sops-v3.8.0.checksums.sig

### Verify the checksums file
cosign verify-blob sops-v3.8.0.checksums.txt \
  --certificate sops-v3.8.0.checksums.pem \
  --signature sops-v3.8.0.checksums.sig \
  --certificate-identity-regexp=https://github.com/getsops \
  --certificate-oidc-issuer=https://token.actions.githubusercontent.com

Verify binary integrity
To verify the integrity of the downloaded binary, you can utilize the checksums file after having validated its signature:

### Verify the binary using the checksums file
sha256sum -c sops-v3.8.0.checksums.txt --ignore-missing

Verify artifact provenance
The SLSA provenance of the binaries, packages, and SBOMs can be found within the artifacts associated with this release. It is presented through an in-toto link metadata file named sops-v3.8.0.intoto.jsonl. To verify the provenance of an artifact, you can utilize the slsa-verifier tool:

### Download the metadata file
curl -LO  https://github.com/getsops/sops/releases/download/v3.8.0/sops-v3.8.0.intoto.jsonl

### Verify the provenance of the artifact
slsa-verifier verify-artifact <artifact> \
  --provenance-path sops-v3.8.0.intoto.jsonl \
  --source-uri github.com/getsops/sops \
  --source-tag v3.8.0

Container Images
The sops binaries are also available as container images, based on Debian (slim) and Alpine Linux. The Debian-based container images include any dependencies which may be required to make use of certain key services, such as GnuPG, AWS KMS, Azure Key Vault, and Google Cloud KMS. The Alpine-based container images are smaller in size, but do not include these dependencies.
These container images are available for the following architectures: linux/amd64 and linux/arm64.
GitHub Container Registry

ghcr.io/getsops/sops:v3.8.0
ghcr.io/getsops/sops:v3.8.0-alpine

Quay.io

quay.io/getsops/sops:v3.8.0
quay.io/getsops/sops:v3.8.0-alpine

Verify container image signature
The container images are signed using Cosign with GitHub OIDC. To validate the signature of an image, run the following command:
cosign verify ghcr.io/getsops/sops:v3.8.0 \
  --certificate-identity-regexp=https://github.com/getsops \
  --certificate-oidc-issuer=https://token.actions.githubusercontent.com \
  -o text

Verify container image provenance
The container images include SLSA provenance attestations. For more information around the verification of this, please refer to the slsa-verifier documentation.
Software Bill of Materials
The Software Bill of Materials (SBOM) for each binary is accessible within the artifacts enclosed with this release. It is presented as an SPDX JSON file, formatted as <binary>.spdx.sbom.json.
What's Changed

chore: update dependencies by @hiddeco in https://github.com/getsops/sops/pull/1275
build: pin actions to full length commit SHA and add CodeQL by @hiddeco in https://github.com/getsops/sops/pull/1276
Enable Dependabot for Docker, GitHub Actions and Go Mod by @hiddeco in https://github.com/getsops/sops/pull/1277
build(deps): Bump the go group with 2 updates by @dependabot in https://github.com/getsops/sops/pull/1280
build(deps): Bump the ci group with 6 updates by @dependabot in https://github.com/getsops/sops/pull/1279
release: generate versioned .intoto.jsonl by @hiddeco in https://github.com/getsops/sops/pull/1278
pgp: remove DisableAgent option by @hiddeco in https://github.com/getsops/sops/pull/1282
keyservices: address logging regression by @hiddeco in https://github.com/getsops/sops/pull/1281
chore: update dependencies by @hiddeco in https://github.com/getsops/sops/pull/1283
Prepare v3.8.0 by @hiddeco in https://github.com/getsops/sops/pull/1284

Full Changelog: https://github.com/getsops/sops/compare/v3.8.0-rc.1...v3.8.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: go.sum
Command failed: go get -d -t ./...
go<EMAIL_ADDRESS>parsing go.mod:
	module declares its path as: github.com/getsops/sops/v3
	        but was required as: go.mozilla.org/sops/v3

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Option optimization and benchmarks

The style after optimization is significantly worse and much more imperative but it is a good tradeoff for the performance gain.
This is a low hanging fruit and there is nothing special or surprising except for difference between static constructor and static initializers and meaning of related beforefieldinit flag.
Option<T> doesn't inherits from Coproduct2<A, Unit> which may be seen as a controversial, since it is not possible to cast IOption<T> to Coproduct2<A, Unit> anymore. But such a cast is inherently unsafe anyway.
There are several other opportunities for basic optimizations, and I would be glad to continue with them if this PR is accepted.
You can run the same benchmarks on original code from this branch: https://github.com/JakubLinhart/FuncSharp/tree/optimization/option-benchmarks.
|                                Method |        Mean |     Error |     StdDev |      Median | Allocated |
|-------------------------------------- |------------:|----------:|-----------:|------------:|----------:|
|     MapNonEmptyToConstant  (original) | 161.0728 ns | 3.7304 ns | 10.5825 ns | 157.9324 ns |     208 B |
|     MapNonEmptyToConstant (optimized) |  13.1610 ns | 0.3396 ns |  0.6210 ns |  13.0880 ns |      32 B |
|        MapEmptyToConstant  (original) |  53.2459 ns | 1.9239 ns |  5.6424 ns |  51.0935 ns |     176 B |
|        MapEmptyToConstant (optimized) |  11.4110 ns | 0.3033 ns |  0.5698 ns |  11.2720 ns |         - |
|               GetNonEmpty  (original) |  47.8753 ns | 1.0937 ns |  3.1556 ns |  47.3610 ns |     176 B |
|               GetNonEmpty (optimized) |   1.0600 ns | 0.0848 ns |  0.1321 ns |   1.0100 ns |         - |
|    FlatMapNonEmptyToEmpty  (original) |  37.8561 ns | 1.1711 ns |  3.3788 ns |  37.1899 ns |     152 B |
|    FlatMapNonEmptyToEmpty (optimized) |  12.4850 ns | 0.3163 ns |  0.5941 ns |  12.4510 ns |      64 B |
| FlatMapNonEmptyToNonEmpty  (original) |  37.7490 ns | 1.2127 ns |  3.4006 ns |  36.8450 ns |     120 B |
| FlatMapNonEmptyToNonEmpty (optimized) |  13.0810 ns | 0.3331 ns |  0.5186 ns |  12.9590 ns |      32 B |
|  ToEnumerableFromNonEmpty  (original) |  24.1255 ns | 0.5112 ns |  1.3378 ns |  24.0597 ns |      32 B |
|  ToEnumerableFromNonEmpty (optimized) |   8.2040 ns | 0.2032 ns |  0.5862 ns |   8.0600 ns |      32 B |
|     ToEnumerableFromEmpty  (original) |  21.0854 ns | 0.4555 ns |  1.2545 ns |  20.6403 ns |         - |
|     ToEnumerableFromEmpty (optimized) |   6.2440 ns | 0.1518 ns |  0.2536 ns |   6.1680 ns |         - |
|             MatchNonEmpty  (original) |  16.4216 ns | 0.3556 ns |  0.8656 ns |  16.1683 ns |         - |
|             MatchNonEmpty (optimized) |   9.4850 ns | 0.2151 ns |  0.2561 ns |   9.5140 ns |         - |
|                MatchEmpty  (original) |  15.4158 ns | 0.3159 ns |  0.7001 ns |  15.2005 ns |         - |
|                MatchEmpty (optimized) |   9.7570 ns | 0.2241 ns |  0.4423 ns |   9.6680 ns |         - |
|                     Empty  (original) |   0.0211 ns | 0.0350 ns |  0.0603 ns |   0.0000 ns |         - |
|                     Empty (optimized) |   0.0275 ns | 0.0158 ns |  0.0140 ns |   0.0000 ns |         - |
|                    Valued  (original) |   4.7309 ns | 0.0952 ns |  0.0844 ns |   4.6959 ns |      32 B |
|                    Valued (optimized) |   3.5690 ns | 0.1444 ns |  0.2373 ns |   3.6130 ns |      32 B |
|         GetOrElseNonEmpty  (original) |  40.9788 ns | 0.8710 ns |  1.3560 ns |  40.7190 ns |     176 B |
|         GetOrElseNonEmpty (optimized) |  18.4250 ns | 0.4959 ns |  1.4229 ns |  18.1580 ns |      88 B |
|            GetOrElseEmpty  (original) |  38.8970 ns | 0.8338 ns |  1.1131 ns |  38.3283 ns |     176 B |
|            GetOrElseEmpty (optimized) |  14.4790 ns | 0.3531 ns |  0.8988 ns |  14.1870 ns |      88 B |
|            OrElseNonEmpty  (original) |  36.1304 ns | 0.7892 ns |  1.6647 ns |  35.6104 ns |     160 B |
|            OrElseNonEmpty (optimized) |   8.2320 ns | 0.3229 ns |  0.9316 ns |   7.9120 ns |         - |
|               OrElseEmpty  (original) |  38.6853 ns | 0.8389 ns |  1.8764 ns |  38.8559 ns |     192 B |
|               OrElseEmpty (optimized) |   6.5380 ns | 0.2032 ns |  0.2979 ns |   6.5390 ns |      32 B |

@JakubLinhart thanks for this 👏 👏 👏 I'm definitely all for optimizations like this, I was pretty sure this will sooner or later happen, the whole FuncSharp was written mainly with readability in mind, not performance, but it makes sense and I'm happy to change this going forward. As a first thing, I cherrypicked the benchmarks to simplify this PR: https://github.com/siroky/FuncSharp/commit/383f9768797629170c346c9016d83e585cc71540

BTW I did some followup polishing (do not mind the comments in benchmarks, I reverted them later): https://github.com/siroky/FuncSharp/commit/64292d14ba242774b6f6bbf9d0b016a896ee4934 It improves the benchmarks to measure only the operation itself and nothing else on a few places. Plus fixes implementation of Second on the option.


Portfolio: finish mobile version PR

I have choosed template No. 3 of Figma and added Works & About section in my this pull request.

All suggested changes are made. Please let me if still anything is missing.

PR title changed and margin acrroding to Figma Template giving Mobile Vesrion insepect dimension to (497x749) as suggested by first reviewer.

alright, do submit again the next reviewer will consider and approve it


chore: remove devcontainer

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1476
#1504
#1503  👈 (View in Graphite)
#1501
#1500
#1495
#1494
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Missing assemblies on NSwag.MSBuild

Error:

The command "NSwag.MSBuild.9.2.0\build\NSwag.exe  webapi2swagger /assembly:$(OutDir)/Category.dll /output:swagger.json" exited with code -532462766

Output:

System.IO.FileNotFoundException: Could not load file or assembly "NSwag.CodeGeneration.CSharp, Version=9.2.6249.28921, Culture=neutral, PublicKeyToken=c2d88086e098d109" or one of its dependencies. The system cannot find the file specified.
1>     в NSwag.Commands.NSwagCommandProcessor.Process(String[] args)
1>     в NSwag.Program.Main(String[] args)
1>  NSwag command line tool for .NET 4.6+,

Workaround:
Add assemblies to NSwag.MSbuild Folder:

NSwag.CodeGeneration.CSharp.dll
NSwag.SwaggerGeneration.dll
NSwag.SwaggerGeneration.WebApi.dll

Possible solution:
Add to .nuspec file direct link to these assemblies

I totally missed that... will fix that ASAP

https://github.com/NSwag/NSwag/commit/07ec2ae4482e2bae7cfe91d1d5ce23f46627a1e5

Try NSwag.MSBuild 9.2.1 on NuGet

Everything is OK! Thanks!


Proxied plain http requests for injection hosts are not being redirected to local server

core/pull-requests/828


Error establishing a database connection

I got all the way through deployment and hit:
Error establishing a database connection
when I tried to load the site. I'd guess a password issue, though it looks OK in wp-config.php.
I don't see anything in the cloud console logs to help. Is there some extra step to allow the app engine standard app to connect to Cloud SQL? On https://cloud.google.com/appengine/docs/standard/php/cloud-sql/ I see
Add the Cloud SQL instance connection name, database, user, and password to the
 nvironment variables in app.yaml.
appengine/standard/cloudsql/app.yaml VIEW ON GITHUB
env_variables:
  # Replace project, instance, database, user and password with the values obtained
  # when configuring your Cloud SQL instance.
  MYSQL_DSN: mysql:unix_socket=/cloudsql/INSTANCE_CONNECTION_NAME;dbname=DATABASE
  MYSQL_USER: root
  MYSQL_PASSWORD: ''

and the generated app.yaml doesn't seem to have that section.
Nope, adding that doesn't seem to have fixed it. :-(

@elharo What version of PHP are you using?
What version of Wordpress are you using?

Have you granted access to App Engine?
Is Composerinstalled?

I eventually resolved this. I think the problem was I was using the root password for the db instead of the wp user password. The scripts could perhaps be clearer on this point. They ask you for, I think, the "database password", not the "password for the wp user"

@jgacuca567 hi again! I am having a similar issue to @elharo and I think one of your suggested solutions might help, but I'm not sure how to implement them. Instead of a database issue, I'm getting the error in the attached screenshot. I tried adding google_app_engine.disable_readonly_filesystem = 1 to the php.ini file but that did not work. I see some suggestions on Stack Overflow about running chown in the Google Cloud SSH but I'm not sure that will work. How can I get around this error so I can update plugins, install plugins, update Wordpress, etc. right from the WordPress Dashboard? Thank you!

@bld2104 are you running standard or flexible?
Try running chown see if its going to work.

@jgacuca567 flexible. What would the exact chown command be? I found several and I can't tell which one is correct. Some use "apache" and some use "http". For example: https://wordpress.stackexchange.com/questions/228591/to-perform-the-requested-action-wordpress-needs-to-access-your-web-server-pleas vs https://www.digitalocean.com/community/questions/why-i-can-t-install-a-new-plugin-on-my-wordpress

@bld2104 Try the one for digital ocean.
chown -Rf www-data.www-data /var/www/html/
Test and see if it works, If it doesn't post error from Command Line.

@jgacuca567 okay before I post it, I just want to check:

this won't mess up my website right? Like there's no chance the website will go down from this, I'm just changing permission on a folder righT?
I am posting this in the terminal from Google Console right? Like I click this SSH button and do it there?

App Engine Standard does not provide a read-write file system: https://cloud.google.com/appengine/docs/standard/php/googlestorage/
I'm not sure about flex, but it wouldn't surprise me if it's the same.  There is no way on standard you can "update plugins, install plugins, update Wordpress, etc. right from the WordPress Dashboard." You have to use the wordpress cli and gcloud app deploy.

@bld2104 1. No Guarantee just make sure before you do that the database is backed up.

Yes or you can use the Google Cloud Shell as well.


Bugfix/home page fix1

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: subodhde sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Cached responses in "wrong" directory

Describe the bug
Cached files are stored in the generic folder ~/.cache/net.
Expected behavior
I think it would be better if cached files were stored under a spot directory. e.g. ~/.cache/spot/net. As if someone is looking at their cached files they can better identify where they are from.
General information:

Distribution: N/A
Installation method [e. g. built from source, installed from Flathub...]: source
Version [e.g. 0.1.0]: master
Device used [e. g. desktop, phone...]: desktop

Right I noticed this a little while ago, I've been reluctant to fix it, this is embarassing :sweat_smile: it's not much of an issue for flatpak users, but for others...
I'll look into it; I'd like to automatically remove files stored at this current location, which is wrong, but we need to be really careful to only remove our files since other things could be writing here possibly :/


If file is empty, parse and compile status should be 'default' ...

... so that in the status panel they just show as the dark blue background

Absorbed into #422


Updated patches with previsouly missing Signed-off-by line

for patch_9pfs_vsock-transport.patch and patch_lower-the-minimum-PMEM-size.patch

@soccerGB,
Thanks for your contribution.  To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
The agreement will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


__builtin_riscv_pause not listed in document

I notice that __builtin_riscv_pause has been supported on GCC for a while but not listed in risc-c-api-doc.
Is it an official api and just not yet updated to the document?

The name __builtin_riscv_pause does not conform with the naming convention of RISC-V intrinsics (which need a prefix __riscv_).
In other words, there is no defined interoperable intrinsic function to emit a PAUSE instruction.
To introduce one, the following steps could be taken:

make a proposal for the intrinsic in a PR for this repo
create and publish patches for GCC and LLVM (if necessary) that reference the PR


Nice message for no-flea cheapest price

Previously, cheapest price column would show an inaccurate tip for users who don't have the flea:

This shows a more accurate message:

Also uses cheapest price for price per slot calculations.

.deploy

.deploy


X11 drag and drop sometimes drops "through" overlapping windows

Given something like T[slack* discord], and initiating a drag in Slack:

the drag image does not respond to movement, and is frozen a couple of pixels from where it started
releasing the drag causes Discord to receive it, making it request urgent status

Video example:
https://user-images.githubusercontent.com/1403503/112929915-6027d380-90e7-11eb-8c68-3b66dc76ea31.mp4
The logs around this time look like:
14:50:42.736 [DEBUG] [wlr] [types/seat/wlr_seat_pointer.c:384] button_count=1 grab_serial=66649 serial=66651
14:50:42.737 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 401 (_NET_WM_USER_TIME) for window 20971527
14:50:42.968 [DEBUG] [sway/desktop/xwayland.c:761] New xwayland unmanaged surface
14:50:42.968 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 360 (CHROMIUM_TIMESTAMP) for window 20971528
14:50:42.968 [DEBUG] [wlr] [xwayland/selection/incoming.c:487] XCB_XFIXES_SELECTION_NOTIFY (selection=299, owner=20971621)
14:50:42.968 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 380 (XdndActionList) for window 20971527
14:50:42.968 [DEBUG] [sway/desktop/xwayland.c:761] New xwayland unmanaged surface
14:50:42.968 [DEBUG] [wlr] [xwayland/selection/incoming.c:453] XCB_SELECTION_NOTIFY (selection=299, property=282, target=283)
14:50:42.970 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 385 (_CHROMIUM_DRAG_RECEIVER) for window 6291468
14:50:42.970 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 385 (_CHROMIUM_DRAG_RECEIVER) for window 6291468
14:50:42.970 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 385 (_CHROMIUM_DRAG_RECEIVER) for window 6291468
14:50:42.970 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 385 (_CHROMIUM_DRAG_RECEIVER) for window 6291468
14:50:47.954 [DEBUG] [wlr] [types/seat/wlr_seat_pointer.c:384] button_count=0 grab_serial=66651 serial=66652
14:50:47.955 [DEBUG] [wlr] [xwayland/selection/incoming.c:487] XCB_XFIXES_SELECTION_NOTIFY (selection=299, owner=0)
14:50:47.955 [ERROR] [wlr] [xwayland/xwm.c:1386] xcb error: op 18:0, code 3, sequence 18214, value 20971622
14:50:48.804 [DEBUG] [sway/input/cursor.c:893] denying request to set cursor from unfocused client
14:50:49.025 [DEBUG] [sway/input/cursor.c:893] denying request to set cursor from unfocused client
14:50:49.026 [DEBUG] [sway/input/cursor.c:893] denying request to set cursor from unfocused client

--- releasing the drag here ---

14:50:51.119 [DEBUG] [sway/tree/arrange.c:264] Usable area for ws: 1440x2530@0,30
14:50:51.119 [DEBUG] [sway/tree/arrange.c:294] Arranging workspace '2' at 0.000000, 30.000000
14:50:51.119 [DEBUG] [sway/tree/arrange.c:77] Arranging 0x7fffb6e5b2b0 horizontally
14:50:51.119 [DEBUG] [sway/tree/arrange.c:156] Arranging 0x7fffb6e5b240 vertically
14:50:51.119 [DEBUG] [sway/tree/arrange.c:156] Arranging 0x7fffb6e5b160 vertically
14:50:51.119 [DEBUG] [sway/desktop/transaction.c:399] Transaction 0x559e6c8fb040 committing with 10 instructions
14:50:51.119 [DEBUG] [sway/desktop/transaction.c:294] Applying transaction 0x559e6c8fb040
14:50:51.119 [DEBUG] [wlr] [types/seat/wlr_seat_pointer.c:384] button_count=1 grab_serial=66651 serial=66662

In a floating layout like the below, with Chromium partially obscured by Slack and dragging from Slack:

...the drag image position updates with mouse movement until it overlaps with the Chromium window underneath, at which point it freezes.
At the time of intersection, the
14:55:23.241 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 385 (_CHROMIUM_DRAG_RECEIVER) for window 35651585
14:55:23.242 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 385 (_CHROMIUM_DRAG_RECEIVER) for window 35651585
14:55:23.242 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 385 (_CHROMIUM_DRAG_RECEIVER) for window 35651585
14:55:23.242 [DEBUG] [wlr] [xwayland/xwm.c:759] unhandled X11 property 385 (_CHROMIUM_DRAG_RECEIVER) for window 35651585

lines get printed, but nothing else appears in the log.

This was originally rbegin and rend when introduced 12 years ago in chromium/chromium@da11eed. But this regressed 10 years ago in chromium/chromium@3c64537

Sounds like a very important code path that everyone runs all the time. 10 years. That's only, like yesterday!
(Feel free to mark this comment as off-topic, because it is, but) does anyone know why _NET_CLIENT_LIST_STACKING exists? XQueryTree provides the same information, but perhaps in a less-easy-to-consume form (and a lot harder to watch for changes).

Chromium patch is up: https://chromium-review.googlesource.com/c/chromium/src/+/2844104
Thanks @psychon for your help in figuring this out :)

does anyone know why _NET_CLIENT_LIST_STACKING exists?

I tried tracking it down when you first mentioned it, but I couldn't find anything. Ergonomics and performance are likely reasons; at the very least Chrome has extra logic to avoid a call to XQueryTree and a comment saying that it's "expensive".


Enable es5: initial draft

change main entry to ./index.js
add logic to dynamically export the appropriate lib version and polyfill
'Promise' if necessary
add prepublish script
add node-version and promise-polyfill dependencies
add necessary babel dev dependencies
remove engine declaration in package.json
add babel configuration

I do want your opinion on whether testing the es5 version is necessary.  I tested back to node 0.10 and it worked.  There are a couple issues with automating a test script (as far as I can tell anyway)

We have to assume the developer has nvm
It would be easier to export ChildProcessPromise on the root export so test.js doesn't hardcode the lib directory

If you're fine with me assuming nvm and exporting ChildProcessPromise on the root export, then I'll add an script to test the es5 output.

Reviewing PR now.

I do want your input on how to test the es5 output.

We can enable Travis CI since it allows you to run tests against multiple Node.js versions by specifying the versions in a .travis.yml file. For example: marko/.travis.yml

I made various fixes on top of your changes and enabled Travis CI. Everything appears to be working in all Node.js versions. New version published<EMAIL_ADDRESS>Please let me know if you see any issues. Thanks for your help on this!

Sounds great - haven't worked with Travis CI  before so that will be good for me to learn.  I'll take a look tonight and delete my branch assuming all's well.

Aye - my bad about depending on babel instead of babel-cli
Also I appreciate your comment Don't use the native Promise in Node.js <4 since it doesn't support subclassing - never knew that
Thanks so much for implementing this in a short time.

You're welcome and thank you.

Also I appreciate your comment "Don't use the native Promise in Node.js <4 since it doesn't support subclassing" - never knew that

I learned this during the implementation. I don't remember the exact error, but things blew up when trying to use the native Promise implementation provided with Node.js v0.12. Using the polyfill is okay because the Promise spec makes it clear that different Promise implementations should play nice together.


Add beginning of java8 module

Right now this only includes instances for LocalDateTime:
scala> import io.circe._, io.circe.java8._, java.time.LocalDateTime
import io.circe._
import io.circe.java8._
import java.time.LocalDateTime

scala> val json = Encoder[LocalDateTime].apply(LocalDateTime.now)
json: io.circe.Json = "2016-01-15T13:27:46.64"

scala> Decoder[LocalDateTime].apply(json.hcursor)
res0: io.circe.Decoder.Result[java.time.LocalDateTime] = Right(2016-01-15T13:27:46.640)

Note that this module won't work on Java 7 or earlier, and isn't available for Scala.js.
I'd also like to add some other things like helpers for creating encoder and decoder instances from Java with lambda expressions, but I'm happy to merge this as is for now.
I'm not 100% sure the Travis CI config will work correctly (I hate Bash), and it's taking jobs forever to get started today, so I may be force pushing fixes to this branch until I get it working.

Current coverage is 77.43%

Merging #168 into master will decrease coverage by -0.07% as of 41cbaf2

Powered by Codecov. Updated on successful CI builds.


Site auth

get rid of sitesAdmin and sitesOwner usage from user token
retrieve and user sitesAdmin and sites Owner from db
add unit tests

Pleas check if permissions & checks are correct for siteAdmin and siteOwner scenarios!!!

I added a bit of new logic & I am not sure if it is correct.
From my point of view, a basic user which is site owner/site admin should not be able to remove himself from the site. Is that correct?

I added a bit of new logic & I am not sure if it is correct.
From my point of view, a basic user which is site owner/site admin should not be able to remove himself from the site. Is that correct?

He can but he will not have access to it anymore :-)
Then he should request an Admin to put him back.


DPL-796 Bioscan - Make key columns mandatory for sample manifest

User story
As the SSRs we would like the key columns in the Bioscan sample manifest to be made mandatory, so they must be filled in.
Who are the primary contacts for this story
Liz H
Alice L
Scott T
Emma B
Who is the nominated tester for UAT
Alice L
Acceptance criteria
To be considered successful the solution must allow:

[ ] agree a list of columns to include in the Bioscan sample manifest and which ones should be mandatory
[ ] sample manifest columns in downloaded template file from Sequencescape reflect the agreed list
[ ] sample manifest enforces agreed mandatory column requirements

Dependencies
This story is blocked by the following dependencies:
None
References
This story has a non-blocking relationship with:
None
Additional context
During UAT we made a mistake and didn't fill in the sample description or sample type columns. Sample description is supposed to hold the specimen plate barcode and is used in the mBrave file.

Waiting on decisions from:
SSRs about which columns are needed
R&D from faculty about whether experiment group (cohort) should be mandatory


Credstash as secret management solution

What is the context of this PR?
WIP example of how credstash (https://github.com/fugue/credstash) could be used as a secret management solution
How to review
With EQ_DEV_KEYS set to False the application should reach out to DynamoDB and AWS KMS for its secrets

Nice, what needs to be setup in AWS to enable this to work?

@collisdigital a KMS alias and a DynamoDB table

@collisdigital was also talking to @ajmaddaford (MadDog) and this could also be used for rolling our encryption keys as they secrets can have versions and are immutable

👌 ; would be good to compare with Vault; but looks promising.

@collisdigital the issue i can see with Vault is that we would need to deploy our own instances with cluster and autoscaling.
Which is an option, but also its a single point of failure.


Shouldn't Citation info also include all member's name?

I have created a project under a team that had members added to it, and also shared the project with some users.
Shall we not include their name in the citation info tab?
Right now we are just including the name of people added as authors.

Closed in favor of https://github.com/NFDI4Chem/nmrxiv/issues/949


[FEATURE] Add direction arrow as point style in line chart and have user supply direction/angle/rotation in data series

Use case: I want to display the wind speed as a line chart (existing feature), and use the points as indicators for the wind direction.  (new)
A point/arrow pointing down indicates Northern wind, etc. There are probably other use cases, like charting the speed and direction of a plane. For an example, see jsfiddle.
For this we need two things:

Add a point type "arrow", and/or other form/type that can indicate a direction. Currently we don't have a point which can indicate a direction; they are all too symmetric.

Obviously we must be able to specify the direction of each point, e.g. as an angle or direction. Since the wind direction actually is a second data series, it would be good to be able to specify it as such. So the data series should look like this
[ {t: , y: , a: <angle/direction>}
This would then be very similar to the second data series r of the bubble chart.

Add a point type "arrow"...

I agree with your idea of the custom point draw method.
In the mean time, your suggestion for the datalabels plugin works great! Thanks for the fiddles.

... be able to specify the direction for each point...

I still see the direction/rotation as a second data series, but I stop discussing that now.
As an inbetween solution, I do specify the second data range in the data as a:
[ {x: 1, y: 2, a: 360} ],
and use the datalabel plugin to pick it up in the rotation:
rotation: function(ctx) {    return ctx.dataset.data[ctx.dataIndex].a; },
Thanks for your quick and elaborate replies!

I'm going to close this for now since the datalabels plugin seems to be working for you

This post helped me som if the way. But I can't figure out how to access the wind direction data in my exempel (from row 200 and down)
I tried
data: [{s: this.windspeeds, a: this.winddeg}]
and
ctx.dataset.data[ctx.dataIndex].a
In the JSFiddle examples simonbrunel used the same data in the graph and in the labels. But how can I get the wind direction from my openweather API?
This seems promising but I cant access the data
pointRotation: function(ctx) {
    // compute angle based on whatever is your use case:
    // return ctx.dataset.data[ctx.dataIndex].a; // or .angle, or .rotation, or ...
    // return ctx.dataset.data[ctx.dataIndex].x > 42 ? 90 : -90;
    // return ctx.dataIndex % 4 ? 45 : 0;
}

JSFiddle

You missed the last sentence of Simon's suggestion. In Chart.js 2.7.3, scriptable options are only available for bubble charts. We should implement them for all charts. In Chart.js 2.8.0 we will support scriptable options for many more chart options: https://github.com/chartjs/Chart.js/tree/master/samples/scriptable

@benmccann i tried using datalabels plugin but that doesn't have the capability to add arrows on labels outside of doughnut chart. Please correct me if am wrong ? and would like to get a suggestion if thats not possible with data labels what should i try

I know that the datalabels plugin supports line charts, but am not too familiar with it beyond that. Perhaps @sfrauenfelder can share since it sounds like his issue was solved

I would like to help, but I don't understand what you mean with "add arrows on labels outside of doughnut chart". Do you mean in the legend, or in other chart types, or something else? I am using the datalabels plugin, and the legend DOES NOT show the point type. Which I understand, because a datalabel is not a point type...

Hello @sfrauenfelder @benmccann
I am trying to achieve this in the below image , point type on legend/label.

Below is what i have working till now, missing point type on legend,

I have never used doughnut charts, so I can't help.
Furthermore, do I understand correctly that with "point type" you refer to the line between each text like "Paid Amount: 1500" and its segment?
Where I wrote "point type", I should have written "point style", or pointStyle, which determines what the point look like in a line chart, i.e. its shape, e.g.
pointStyle: 'rect'
or
pointStyle: 'circle'
I have no clue whether pointStyle has anything to do with the lines in a doughnut chart.

Hello @sfrauenfelder @benmccann,
Is there any known way to achieve what @supreet8789 has mencioned. I mean, those arrows/lines that connect datalabels with doughtnut segments ..? Perhaps with some plugin ..? or Is that still pending to develop ..?


Strings have to be enclosed in double quotes

Need to think about how we represent strings in the generated grammar. At present, by default, all strings must be enclosed in double quotes, which is confusing for lawyers.
E.g. "Party A" will be deemed to in the template<EMAIL_ADDRESS>The Nearley grammar that is generated based on this template:
https://github.com/accordproject/cicero/blob/master/packages/cicero-core/lib/template.ne#L75

This issue is discussed in more details in #305


Overriding formats, export_formats, import_formats not documented.

I wanted to restrict valid formats differently for different models.
By examining the code I discovered that I could set formats, export_formats, or import_formats as attrs on the admin to control the allowed formats.
This is not documented.
I am not sure if this was an intended feature, but it is useful enough that I recommend it be promoted to such, and documented.

Thanks for raising this.  There is some documentation on this here but it looks like we missed documentation for setting values directly on the admin.  I'll get that added in.


AttributeError occurred when resuming the upload of a fusion dataset

AttributeError occurred when resuming the upload of fusion dataset nuScenes, which is loaded by the nuScenes dataloader.
gas.upload_dataset(dataset, jobs=8, draft_number=1, skip_uploaded_files=True)
Environment:

tensorbay 1.4.0
Ubuntu 20.04
python 3.8.5

Error message:
Traceback (most recent call last):
  File "upload_nuScenes.py", line 22, in <module>
    gas.upload_dataset(dataset, jobs=8, draft_number=1, skip_uploaded_files=True)
  File "/home/newbie/.local/lib/python3.8/site-packages/tensorbay/client/gas.py", line 411, in upload_dataset
    dataset_client._upload_segment(  # pylint: disable=protected-access
  File "/home/newbie/.local/lib/python3.8/site-packages/tensorbay/client/dataset.py", line 860, in _upload_segment
    multithread_upload(
  File "/home/newbie/.local/lib/python3.8/site-packages/tensorbay/client/requests.py", line 334, in multithread_upload
    futures = [executor.submit(function, argument) for argument in arguments]
  File "/home/newbie/.local/lib/python3.8/site-packages/tensorbay/client/requests.py", line 334, in <listcomp>
    futures = [executor.submit(function, argument) for argument in arguments]
  File "/home/newbie/.local/lib/python3.8/site-packages/tensorbay/client/dataset.py", line 799, in _skip_upload_frame
    remote_frame.frame_id = frame.frame_id
AttributeError: 'Frame' object has no attribute 'frame_id'

Now it 's fixed.
v1.4.1 is released:
https://pypi.org/project/tensorbay/1.4.1/
Use pip3 install -U tensorbay to get the latest tensorbay package


Can't dynamically enable/disable input devices anymore

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit v0.37.1  ().
Date: 2024-03-16
Tag:

flags: (if any)

System Information:
System name: Linux
Node name: nixOS
Release: 6.1.85
Version: #1-NixOS SMP PREEMPT_DYNAMIC Wed Apr 10 14:28:36 UTC 2024

GPU information:
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GA107M [GeForce RTX 3050 Mobile] [10de:25a2] (rev a1) (prog-if 00 [VGA controller])
05:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Rembrandt [Radeon 680M] [1002:1681] (rev c8) (prog-if 00 [VGA controller])

os-release: BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="23.11.6272.51651a540816"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 23.11 (Tapir)"
SUPPORT_END="2024-06-30"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="23.11 (Tapir)"
VERSION_CODENAME=tapir
VERSION_ID="23.11"

plugins:

Bug or Regression?
Regression
Description
Here's a Reddit thread with the exact same issue I'm having.
Hyprctl can't set the enabled state of a specific device. This is really annoying. Ideally there'd be a dispatcher that can toggle a device. That'd also remove the need for a external scrip.
The workaround mentioned in the script is hacky and I'd rather not rely on completely undefined behaviour of Hyprland updating the variable.
Also I didn't read the commit but the changes definitely don't seem justified. There's not really a reason to change the config like that. At least not for users. + These breaking changes should probably be in the release notes

'device[name]:prop' 'value'

For anyone stumbling upon this issue you actually have to use the []
like this
hyprctl keyword "device[asue120a:00-04f3:319b-touchpad]:enabled" true

I'm mentioning this because the Hyprland wiki often uses [] as a placeholder.
Here's an example:

Thanks! 🛞


Status of the project

Hi @axelaris,
i just wanted to ask whether there are any plans on continuing this release?
What i expect as an answer is a "no", when i look at the last changes made to the repo.
Is something out there in the open source community that could be used as a replacement.
Maybe you could point me to something, as we are struggling with switching to something else from this release in our systems.
Kind regards and thanks in advance
Julian Weber

Hi Julian.
This project was supported by the company where I worked before. Unfortunately, it was suffered because of Covid, and now does not have resources to support open source projects :-(
Sorry to say that, but currently this project can be treated as orphaned. If anyone want to continue develop it - I would say thanks and give necessary permissions.

Hi @axelaris,
thanks for the fast feedback.
This is what we expected.
I wish you fun and good luck with your new projects.
Thanks for maintaining this project in the past.
Kind regards,
Julian

@bengerman13, is taking over this repo something that your organization would be able to take on?  I've been eyeing your fork at https://github.com/cloud-gov/logsearch-boshrelease/ for some time trying to decide if we need to switch over to it for our deployments, but I'm not sure if that is intended for general use or if it's been customized for your use case.  Given your current pending pull request as well it seems like you're the best candidate to keep this project current.
I've got very limited development resources but I would be happy to offer testing resources to make sure your new pull request doesn't cause any issues for a generic deployment.

@amhuber I'll discuss it with our team. Currently, most of our efforts are based on security and compliance findings, rather than on features/improvements. I don't believe we have any super-specific modifications - the only thing I believe we've done other than version bumps is permissions fixes as ES and Kibana change APIs.
(Aside: if you want to follow our fork for the time being, know that we currently track .final_builds and releases directories outside of git, but you'd probably have to do the same since our blobstore is private)

TBH that's really all we need (security fixes vs. new features).  The existing release desperately needs your pull request to get the latest JDK and ELK security fixes.

We're still looking into this, but right now our main concern is about licensing. Because of the changes in Elastic's licensing strategy, we think we need to either:

move to an option with more permissive licensing (e.g. opensearch)
build elasticsearch components from source, and change the license to SSPL wherever we do so

I think moving to to a different backend (such as opensearch) is a major breaking change, and the migration would be nontrivial for most or all users, so I'm somewhat inclined to do that in a new repo, probably a hard fork of our current logsearch-boshrelease.

Yeah, I've been wondering when (not if) the licensing change was going to become a problem.  Thanks in advance for considering this, and I suspect many in the CF community would be grateful (and hopefully contribute to) a fork based on OpenSearch with the same functionality.

We're getting closer to owning a logging stack on our end. We've sketched out a plan here and welcome input from the community.
Because we're being driven by compliance and security considerations, we'll be running this in our github org and with internal governance at least for the time being, but our code is all licensed CC0, so it's readily forkable if anyone needs something we can't incorporate/accommodate.
With this breadcrumb dropped, we're going to try to keep any conversation about our projects on our own repos to keep potential confusion and unwanted noise down.

Awesome!  I'm sure we're not the only ones in the community who will benefit greatly from that.


Handle embeddings from Azure OpenAI

There seems to be an issue using embeddings provided as part of the Azure OpenAi platform
I can access them using python
client = AzureOpenAI(
    api_key="[API_KEY]",
    azure_endpoint=my_endpoint,
    api_version="2023-12-01-preview"
)

response = client.embeddings.create(input=[text], model="text-embedding-ada-002-2")

But when I try to add it to my config.yaml file:
  - type: azure-openai
    name: azure_ai
    api_base: [URL]
    api_key: [API_KEY]
    models:
      - name: gpt-4o-e # 128k
        max_input_tokens: 128000
        max_output_tokens: 4096
        supports_function_calling: true
        supports_vision: true
[...]
      - name: text-embedding-3-large
        mode: embedding
      - name: text-embedding-3-small
        mode: embedding
      - name: text-embedding-ada-002-2
        mode: embedding

and then
thomas@L15-77:$ aichat --rag myrag
? Select embedding model:
> openai:text-embedding-3-large (dimension:3072; max-tokens:8191; price:0.13; batch:100)
  openai:text-embedding-3-small (dimension:1536; max-tokens:8191; price:0.02; batch:100)
[↑↓ to move, enter to select, type to filter]

(I only see openai embeddings, not azure ones)
Expected behavior
The azure_openai embedding models should appear.
Configuration
model                   azure_ai:gpt-4o-e
max_output_tokens       -
temperature             -
top_p                   -
dry_run                 false
save                    true
keybindings             emacs
wrap                    no
wrap_code               false
save_session            -
compress_threshold      50000
function_calling        true
rag_reranker_model      -
rag_top_k               4
highlight               true
light_theme             false
config_file             /home/thomas/.config/aichat/config.yaml
roles_file              /home/thomas/.config/aichat/roles.yaml
functions_dir           /home/thomas/.config/aichat/functions
agents_functions_dir    /home/thomas/.config/aichat/functions/agents
agents_config_dir       /home/thomas/.config/aichat/agents
rags_dir                /home/thomas/.config/aichat/rags
sessions_dir            /home/thomas/.config/aichat/sessions
messages_file           /home/thomas/.config/aichat/messages.md

Environment (please complete the following information):

os version: WSL 2 Ubuntu
aichat version: 0.19.0 rc2
terminal version: Windows Terminal

Note that ollama embeddings from a remote location don't seem to be handled either, although I managed to make them work locally on a different computer.

miss type: embedding
https://github.com/sigoden/aichat/blob/8b8f8b37c35479f747a70a65f069c0d8d4b01dcf/config.example.yaml#L98-L102

Thanks a lot for the quick response! I don't know where this "mode" keyword came from, maybe a previous version ? In any case that solved both problems, for Azure and Ollama


Port Forwarding Incorrect Port Breaks Tunneling

Type: Bug
Tunneling server is running on an up to date Raspberry Pi V4 4gb ram. (Running Raspian)
Tunneling server will not respond after trying to add a port forward that does not exist. (E.g. trying to forward port 2000 when nothing is running on port 2000)
Steps to Reproduce

Start vscode tunnel in systemctl service. (code tunnel)
Connect to the tunnel and try to portforward a port that is not in use

The logs will show an error along the lines of "Error connecting forwarding to <IP_ADDRESS>:, Connection refused (os error 111)"
It will not connect until the service is restarted.
VS Code version: Code 1.74.2 (e8a3071ea4344d9d48ef8a4df2c097372b0c5161, 2022-12-20T10:29:14.590Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz (6 x 2808)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
11.82GB (2.80GB free)

Process Argv

Screen Reader
no

VM
0%

Seems similar to #170042

This is an old duplicate, fixed a while ago


Installation from Maven dependency hangs

I'm trying to include BotKit in a Maven project but when I run mvn install or verify, it appears to hang while downloading
It appears I was just being impatient. I'll note that the download took 17:51 for me on a 20Mb/s wireless connection. Not sure why it took so long.

Hi,
Maybe you have a lot of transitive dependency in your pom.xml file. Can you post the out of this command mvn dependency:tree here?


Saved Keypairs UI Tests

Preview is available here:http://laboratory-pr1181.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-pr1181.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-pr1181.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-pr1181.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-pr1181.previews.kube001.services.stellar-ops.com/


React view vs reducer dilema

I'm sorry to opening a new issue but I was afraid this type of  question would get closed as opinionated on SO.
I'm using React with Redux in my app and I know reducer should be pure functions.
there is an authentication system in my app.
The only question I have is that where should take the responsibility of saving tokens.
Should they be saved in reducer or should the action dispatch another action which would save the token or would it be saved in the view?

Since this is a usage question, this should be asked on SO, not in an issue tracker.  You may also want to read through the Redux FAQ for some ideas: http://redux.js.org/docs/FAQ.html .


Enhance function of .gitleaksignore

Is your feature request related to a problem? Please describe.
We are encountering the challenge that we are using gitleaks in a CI/CD context and manage our ruleset .gitleaks.toml in a SSOT. Yet this comes with the challenge on different repos there might be different allowlists. The way this is managed at the moment is by placing a .gitleaks.toml in the repo that contains only the allowlist. In our integration when we check for secrets we take our ruleset and merge its allowlist with the repo-specific allowlist. Yet the problem here is that if externals clone our repo and run gitleaks on it without any agruments, the standard ruleset won't be applied, due to the presence of the .gitleaks.toml and even worse since this file doesn't contain any rules there can never be a detection.
Describe the solution you'd like
Taking the above setting into account we would like to use the .gitleaksignore similar to the an allowlist. The way it currently works is nice, yet it doesn't scale really well, since commit IDs are different for different repos and if one would talk about an organization having thousands of repos going through every repo manually and checking fingerprint is almost infeasible. Therefore, it would be easy to add what should be allowed (e.g. emails from the organization, public keys of the organization) to the .gitleaksignore file similar to how ignore files or folders with a .gitignore file.
Note: This approach is different from what is described in #1195 where whole files/directories are ignored. I totally agree on the comment of @rmgz
If there is a way on how that is already possible and I simply didn't see it, please let me know.
Describe alternatives you've considered
As an alternative we use the approach described in the beginning. Yet this raises the problem described.
cc @zricethezav

Hi team,
this would be a great feature! Does anyone know if it has been taken into account?

Hi @ zricethezav this would be a great feature!


Remove SZ_ENTITY_INCLUDE_FEATURE_ELEMENTS

See https://github.com/senzing-garage/garage-roadmap/issues/26

Pull requests:

https://github.com/senzing-garage/sz-sdk-go/pull/184


Is it worth creating a CONTRIBUTING.md

I noticed there are no contributing instructions.
Would it be worth adding some basics (installation/building/linting expectations, etc)?

Yes, we should have a contrib file. If no one else adds it, I will add it once I have some time.
Thanks for pointing it out @krassowski! I did not realize we didn't have it.


[containerapp] az containerapp up: support create or update containerapp on connected env

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

az containerapp up --custom-location --connected-cluster-id

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

containerapp

Hi @Juliehzl @LaylaLiu-gmail
Could you help to review this PR when you have chance? Thanks!

Hi @Juliehzl
Got tests rerun pass with newest code, could you help to approve this PR? Thanks.

Hi @zhoxing-ms
Can you help to review and merge this PR? Thanks!


ENH: Add TempPath type, subclasses pathlib.Path

Looks good, merging so we can move forward, thanks @thermokarst!


Added GATT and ATT PDU Unit Tests

Issue
Fixes #27.
What does this PR Do?
Added unit tests for GATT and ATT PDUs.
Where should the reviewer start?
GATTTests.swift
Sweet giphy showing how you feel about this PR

Result of Integration 1
Duration: 2 minutes and 26 seconds
Result: All 53 tests passed, but please fix 1 warning.
Test Coverage: 69%

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 3
Duration: 5 minutes and 10 seconds
Result: Perfect build! All 53 tests passed. :+1:
Test Coverage: 69%

Result of Integration 3
Duration: 5 minutes and 10 seconds
Result: Perfect build! All 53 tests passed. :+1:
Test Coverage: 69%

Result of Integration 3
Duration: 5 minutes and 10 seconds
Result: Perfect build! All 53 tests passed. :+1:
Test Coverage: 69%

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 4
Duration: 2 minutes and 10 seconds
Result: Perfect build! All 54 tests passed. :+1:
Test Coverage: 71%

Result of Integration 4
Duration: 2 minutes and 10 seconds
Result: Perfect build! All 54 tests passed. :+1:
Test Coverage: 71%

Result of Integration 4
Duration: 2 minutes and 10 seconds
Result: Perfect build! All 54 tests passed. :+1:
Test Coverage: 71%

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 5
Duration: 1 minute and 54 seconds
Result: Perfect build! All 57 tests passed. :+1:
Test Coverage: 72%

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error

Result of Integration 2
Duration: 6 minutes and 32 seconds
Result: -1 error, failing state: checkout-error


Merge pull request #1 from knightliao/master

pull from knightliao/disconf

pull from knightliao/disconf

Coverage remained the same at 42.498% when pulling f467c77c6b099155329013c64bba0543071b70e2 on jarvett:master into 651e2e4c4ca24c24ffbc4dab13bf60be31554775 on knightliao:master.

Coverage remained the same at 42.498% when pulling f467c77c6b099155329013c64bba0543071b70e2 on jarvett:master into 651e2e4c4ca24c24ffbc4dab13bf60be31554775 on knightliao:master.


wizard-build-profile checkbox onChange is not firing

As per the issue no. #36, I am also not getting any response on checkbox onChange. I tried adding onChange and as following:
$('#dental_type_id_1').change(function () {
    alert($this.value);
 });

$('input[type=checkbox]').change(function () {
    alert('changed');
});

nothing work. Please need help.

Hi, @shariful2011! Thank you for using our products and sorry for the late response. Please see this link https://stackoverflow.com/questions/13418963/jquery-onchange-function-not-triggering-for-dynamically-created-inputs.
Regards,
Dragos

Thanks, I did it on click event.


License？

I like the simple structure!
I would like to use it too, but I can't find a license.
I'm a beginner and would like to add some features.
It would be nice to have a license so I can use it with peace of mind.
Can you add it?

Thanks for the comment, I just added the license.

Thank you!
I'm very happy.


Release Version 0.30.0

Description
This version includes a flip fest functionality for scaffolding apps: flow app create <name>. It gives you options to choose from different templates and generates the folder structure for you. It also includes some housekeeping like dependency updates, fixes some documentation issues with the flip fest ticket and adds missing flags. CI actions were fixed with snyk causing problems.

For contributor use:

[x] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

Codecov Report

Merging #418 (4caed26) into master (cec2ed3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   55.50%   55.50%
=======================================
  Files          36       36
  Lines        1906     1906
=======================================
  Hits         1058     1058
  Misses        711      711
  Partials      137      137

Flag
Coverage Δ

unittests
55.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad7390...4caed26. Read the comment docs.


[WIP] support npm3

Files changed: 7,615
O.O

its because we bundle all the dependencies. So when someone installs nmo they have everything. Don't need to fetch anything and we shouldn't have any dependency version issues.

It's all nice from technical side, but from legal one are all the deps compatible with Apache v2 license and doesn't including them all violates any ASF rule? I'm in doubts.

Yes. Thats why its [WIP] we have to decide how to manage this. Any suggestions would be great.

After discussion with @janl and @kxepal we don't need this anymore. I'm closing.


Update Docs: Widgets “image”

Automatically generated by Netlify CMS
Related to https://github.com/netlify/netlify-cms/issues/3671

@erezrokah hi, I didn't read the edits you had made properly but the absolute paths don't work if the media folder path starts with a single '/', it needs to be two slashes ie '//', this was not a typo in my original post.
The reasoning for this comes from the file at /packages/netlify-cms-lib-util/src/path.ts which defines an isAbsolutePath function using regex which matches for any strings starting with "//" (I was unsure if this was meant to be an escaped slash ie "/"however "//" is valid in some cases so I assumed it was intentional)

The isAbsolutePath function is used in the file at /packages/netlify-cms-core/src/reducers/entries.ts  in the selectMediaFilePath function, see below. As you can see, if the input media path is an "absolute" path then this function does nothing and just returns the path, otherwise, it processes the path as normal where the path would be made relative to a media folder.

The selectMediaFilePath is then used in the file at packages/netlify-cms-core/src/actions/media.ts to get generate a "resolvedPath" which is then used for finding assets.

From following this chain, my understanding was that prefixing the path with a double slash '//' allowed the CMS to look at absolute locations for assets, so as it stands the suggestion in the documentation of using a single slash '/' won't work, unless if the regex in the isAbsolutePath function is actually meant to be '/' instead of '//'.
So either the documentation or the code needs to change in order to align, from my understanding.
Apologies if I have misunderstood something.

The reasoning for this comes from the file at /packages/netlify-cms-lib-util/src/path.ts which defines an isAbsolutePath function using regex which matches for any strings starting with "//" (I was unsure if this was meant to be an escaped slash ie "/"however "//" is valid in some cases so I assumed it was intentional)

Hi @eliasm307, thank you for following up on this.
That function is actually testing absolute URLs (e.g. https://) and not paths - we should probably rename it.
The test for paths starting with / is done here:
https://github.com/netlify/netlify-cms/blob/e0db5ea19a1a9b82b194c7e23b38a1f9cc1bbe20/packages/netlify-cms-core/src/reducers/entries.ts#L741

Hi @erezrokah thanks for your reply. I'll have a look again however previously when I had tried to use a single '/' for the media folder path the result was that images were saved relative to the collection folder. I'll see if I was doing something wrong

Hi @erezrokah thanks for your reply. I'll have a look again however previously when I had tried to use a single '/' for the media folder path the result was that images were saved relative to the collection folder. I'll see if I was doing something wrong

Thanks, please open a bug if it reproduces.


Maintain portrait in app clip

Why
Make sure the app clip can't rotate to horizontal mode. Using the same values here as our app.

ty. not going to merge yet, since will delay OTA for a bit


Proposal: option to disable implicit boolean cast in conditions

I came across a very silly bug in my code which the Typescript compiler did not catch. Consider the following snippet of code:
class MyClass {
    public /*get*/ flag(): boolean {
        return false;
    }

    public doStuff() {
        if(this.flag) {
            alert('hello');
        }
    }
}

The alert will always be executed, because the property has been mis-declared as a method. Instead of invoking the getter and checking its return value, we instead evaluate the body as truthy.
While this behaviour is expected in many cases, it would be nice to have a compilation flag to enable additional checks, for example - noImplicitBool. It would require expressions in classic control structures (if, while, for) to be explicitly of the boolean type.
The flag should not affect the behaviour of the || operator, which is often used for coalescing values of arbitrary types.

See #7746

TSLint has a rule strict-boolean-expressions that does exactly what you want: https://palantir.github.io/tslint/rules/strict-boolean-expressions/

See #9041

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


[1.12.2] Bug - Player sounds don't play when not in a "cave"

DynamicSurroundings-1.12.2-<IP_ADDRESS>
Forge <IP_ADDRESS>05
Unless I need to delete the config or any other file from previous versions, no player sounds play unless the player is underneath blocks or what is considered a cave. Examples are walking on blocks, crafting items, switching items, and etc.

Ancient, but did you get this to work with the update?

Closing due to inactivity - as if I have any moral ground here. :)  If you are still having issues feel free to reopen.


Can't access repository from Azure Pipeline

It only shows my repositories, and won't let me select yours, neither when I try and configure the Pipelines App nor when using access all repositories.

Can you clone my repo and use the clone?


Remove vestigal python install code from CMake build system

In the current build system, a correct python installation requires using setup.py, either through pip install or python setup.py install.
there was code that was always attempting to install python headers, even in C++ only builds
...and python building was on by default, even though it was incorrect when only building through cmake.

Codecov Report

Merging #1113 (3f7c583) into master (0cc00ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1113   +/-   ##
=======================================
  Coverage   86.20%   86.20%
=======================================
  Files         191      191
  Lines       19028    19028
  Branches     2105     2105
=======================================
  Hits        16404    16404
  Misses       2078     2078
  Partials      546      546

Flag
Coverage Δ

unittests
86.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc00ce...3f7c583. Read the comment docs.


Allow underscore characters in sample names

It would be great to allow underscores in sample names. Currently in the vignette_config.yaml we have:
fq_files: # fastq files to be processed
  WTnone: SRR1042855_s1mi.fastq.gz # do not use "_" in dataset name
  WT3AT: SRR1042864_s1mi.fastq.gz

We could not have '_' in sample names because characters after the '_' were dropped by the string processing in prepRiboviz.sh. This might not be a problem in prepRiboviz.py?
I would like to be able to use, for example:
fq_files: # fastq files to be processed
  WT_none: SRR1042855_s1mi.fastq.gz
  WT_3AT: SRR1042864_s1mi.fastq.gz

The use-case is where the underscore separates distinct and useful parts of information aobut the sample:
fq_files: # fastq files to be processed
  WT_rep1: SRR1042855_s1mi.fastq.gz
  WT_rep2: SRR1042864_s1mi.fastq.gz
  Mutant_rep1: SRRxxxxx.fastq.gz
  Mutant_rep2: SRRxxxx.fastq.gz

In the long run we would like to have a more sample-sheet based approach to metadata, but it would still be nice if the sample ids/names could include underscores.

Setting vignette_config.yml:
fq_files: # fastq files to be processed
  WT_none: SRR1042855_s1mi.fastq.gz
  WT_3AT: SRR1042864_s1mi.fastq.gz

and running:
python scripts/prepRiboviz.py scripts/ vignette/vignette_config.yaml

gives: vignette/tmp:
WT_3AT_nonrRNA.fq
WT_3AT_orf_map_clean.sam
WT_3AT_orf_map.sam
WT_3AT_rRNA_map.sam
WT_3AT_trim.fq
WT_3AT_unaligned.sam
WT_none_nonrRNA.fq
WT_none_orf_map_clean.sam
WT_none_orf_map.sam
WT_none_rRNA_map.sam
WT_none_trim.fq
WT_none_unaligned.sam

and vignette/output:
TPMs_collated.tsv
WT_3AT_3nt_periodicity.pdf
WT_3AT_3nt_periodicity.tsv
WT_3AT.bam
WT_3AT.bam.bai
WT_3AT_codon_ribodens.pdf
WT_3AT_codon_ribodens.tsv
WT_3AT_features.pdf
WT_3AT.h5
WT_3AT_minus.bedgraph
WT_3AT_plus.bedgraph
WT_3AT_pos_sp_nt_freq.tsv
WT_3AT_pos_sp_rpf_norm_reads.pdf
WT_3AT_pos_sp_rpf_norm_reads.tsv
WT_3AT_read_lengths.pdf
WT_3AT_read_lengths.tsv
WT_3AT_tpms.tsv
WT_none_3nt_periodicity.pdf
WT_none_3nt_periodicity.tsv
WT_none.bam
WT_none.bam.bai
WT_none_codon_ribodens.pdf
WT_none_codon_ribodens.tsv
WT_none_features.pdf
WT_none.h5
WT_none_minus.bedgraph
WT_none_plus.bedgraph
WT_none_pos_sp_nt_freq.tsv
WT_none_pos_sp_rpf_norm_reads.pdf
WT_none_pos_sp_rpf_norm_reads.tsv
WT_none_read_lengths.pdf
WT_none_read_lengths.tsv
WT_none_tpms.tsv

Compare collated file with results before introduction of _:
diff vignette/output/TPMs_collated.tsv ~/RiboViz-Outputs/Ubuntu18/vignette-bash/output/TPMs_collated.tsv

1c1
< ORF	WT_none	WT_3AT
---
> ORF	WTnone	WT3AT

In prepRiboviz.sh, in each iteration of the loop:
for fq in ${fqfs}

fq to has values fq_files_NotHere, fq_files_WT_3AT, fq_files_WTnone. This is then parsed to get fn_stem:
eval fn_stem=${fq##*_}

This is where problems arise if there are multiple underscores:
fq=fq_files_WTnone; eval fn_stem=${fq##*_}; echo $fn_stem

WTnone

fq=fq_files_WT_none; eval fn_stem=${fq##*_}; echo $fn_stem

none

This is bash substring removal of form PARAMETER##PATTERN(see example). ## means 'take the longest matching string possible', so it removes the longest *_ string i.e. fq_files_WT_. To fix this, one can explicitly specify the prefix to be removed i.e. fq_files_:
fq=fq_files_WTnone; eval fn_stem=${fq##fq_files_}; echo $fn_stem

WTnone

fq=fq_files_WT_none; eval fn_stem=${fq##fq_files_}; echo $fn_stem

WT_none


Connection Timed Out

How do i handle if the connection was timed out?

Always provide error/exception, stack trace, and maybe some code to help recreate the issue.

its not an error
am saying how do i handle connection timeout like maybe something is wrong with the api

One it does not load completely and when it loads completely the modal closes on its own, without any error message
How can you help me to resolve it

Create a try catch block around your code
try {
  ...
} SocketException (e) {
  ...
}

One it does not load completely and when it loads completely the modal closes on its own, without any error message
How can you help me to resolve it

are you using the callback or webhook ensure its the callback


NGINX reverse proxy question

Hi, I am trying to reverse proxy netbird to a local installation, but always run into "Bad Gateway". The setup is as follows:
Firewall: Ports 443 and 80 (TCP/UDP) forwarded to a VM (<IP_ADDRESS>) that runs Nginx (not Nginx proxy manager). Several other services are working through the proxy. The config for Netbird listens to nb.mydomain.com
Netbird is installed installed with authentik (auth.mydomain.com). I verified that this is working in general by temporary hosting netbird on a VPS at my hoster and created another application and provider in Authentik that points to nb.mydomain.com. The netbird VM has <IP_ADDRESS>
nginx-site.conf.txt
docker.compose.yml.txt
setup2.env.txt
I am sure I am missing something, but what?
EDIT: I have changed the ports in the nginx config as follows:
upstream dashboard {
    server <IP_ADDRESS>:80;
    keepalive 10;
}

upstream signal {
    server <IP_ADDRESS>:10000;
}

upstream management {
    server <IP_ADDRESS>:33073;
}

Now I get this:

Thank you in advance!

Have you taken a look at this section https://docs.netbird.io/selfhosted/selfhosted-guide#configuration-for-your-reverse-proxy in the self-hosted guide?

Yes, followed it to the letter but that didn't help.
The auth issue is solved, in fact that was mixed up with my first test of Netbird on a hosted VPS. I have re-taken the authentik steps and this seems to work now. I am getting to load the dashboard and log in sucessful, see teh download instructions. but cannot connect to the vpn.
There are some questions the documentaiton doesn't answer:

which hostname do I enter in setup.env? nb.mydomain.com does not resolve to the netbird VM but to the gateway. I did edit /etc/hosts on the netbird vm so that nb.mydomain.com points to localhost in case it is needed.
what to fill in for NETBIRD_MGMT_API_ENDPOINT in setup.env?

I also had issues with using NGINX as my reverse proxy. Got it working with below configuration:
server {
	listen 443 ssl http2;
	listen [::]:443 ssl http2;
	server_name netbird.mydomain.com;

    #Use letsencrypt.org to get a free and trusted ssl certificate
    ssl_certificate /etc/letsencrypt/live/mydomain.com/fullchain.pem; # managed by Certbot
    ssl_certificate_key /etc/letsencrypt/live/mydomain.com/privkey.pem; # managed by Certbot

    error_log /var/log/nginx/netbird.error.log error;
    access_log /var/log/nginx/netbird.access.log;

    # This is necessary so that grpc connections do not get closed early
    # see https://stackoverflow.com/a/67805465
    client_header_timeout 1d;
    client_body_timeout 1d;

    proxy_set_header        X-Real-IP $remote_addr;
    proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header        X-Scheme $scheme;
    proxy_set_header        X-Forwarded-Proto https;
    proxy_set_header        X-Forwarded-Host $host;

    # Proxy dashboard
    location / {
        proxy_pass http://dashboard-upstream;
    }
    # Proxy Signal
    location /signalexchange.SignalExchange/ {
        grpc_pass grpc://signal-upstream;
        # Can't remember why I turned this off, but it works fine without it
        #grpc_ssl_verify off;
        grpc_read_timeout 1d;
        grpc_send_timeout 1d;
        grpc_socket_keepalive on;
    }

    # Proxy Management http endpoint
    location /api {
        proxy_pass http://management-upstream;
    }

    # Proxy Management grpc endpoint
    location /management.ManagementService/ {
        grpc_pass grpc://management-upstream;
        #grpc_ssl_verify off;
        grpc_read_timeout 1d;
        grpc_send_timeout 1d;
        grpc_socket_keepalive on;
    }
}

Thank you @sgtaziz !
Are you running netbird on the same machine as nginx? I don't see the definitions for the location endpoints. Also, did you in the setup.env set these?
#NETBIRD_MGMT_API_PORT="444"
NETBIRD_MGMT_API_ENDPOINT="nb.mydomain.com"
NETBIRD_SIGNAL_PORT="81"

Yes, I'm running it on the same machine. The endpoints are configured at the top of my nginx site file as such:
upstream dashboard {
    server <IP_ADDRESS>:8086;
    keepalive 10;
}
upstream signal {
    server <IP_ADDRESS>:8087;
}
upstream management {
    server <IP_ADDRESS>:6443;
}

And the related setup.env:
NETBIRD_MGMT_API_PORT=6443
NETBIRD_SIGNAL_PORT=8087

Also, I did modify the docker-compose.yml manually, since there is no env variable to change the dashboard port:
services:
  dashboard:
    image: netbirdio/dashboard:latest
    restart: unless-stopped
    ports:
      - 8086:80 # 8086 since 80 is already used by nginx
      #- 443:443
    environment:
  ....

Nginx ports open are only 80/tcp and 443/tcp. I do have the COTURN related ports open, but that's not through NGINX, just opened it from the docker container and my firewall.
Feel free to change the ports in setup.env and the dashboard port in docker-compose.yml file to whatever you need, just make sure its reflected in the nginx upstream configuration.

Hi @sgtaziz, I'm running the same setup as you i believe. NGINX (as reverse proxy) and Netbird on the same machine.
However, I can't get this to work as I'm stuck on an infinite loading screen on https://netbird.mydomain.com/peers, after logging in via authentik. My nginx_netbird.conf ist the same as yours and I've set up the same ports in my setup.env. Firewall / NAT definitley isn't the issue here.
Would you mind sharing your docker-compose.yml please, so i can make sure I'm all good there?

Hi @Xentec0. It might not be an issue any more but I was banging my head against this issue for a day or so. I noticed today that the configure script is appending the value of NETBIRD_MGMT_API_PORT to NETBIRD_MGMT_API_ENDPOINT and NETBIRD_MGMT_GRPC_API_ENDPOINT in the generated docker-compose file.
So if you use the settings from @sgtaziz above then NETBIRD_MGMT_API_PORT is set to https://:6443 which results in a timeout as the JS client can't communicate with this directly.
However, since we are proxying that connection via nginx if you set NETBIRD_MGMT_API_PORT=443 then it's handled by nginx and works for me. Check the network tab in the chrome/firefox debugging tools and if you are seeing that the client can't contact the management server then this may also be your problem.
Worked for me at least . I do wish there was an alternative deployment option to docker though, it's a pretty opaque process.

I also had issues with using NGINX as my reverse proxy. Got it working with below configuration:
server {
    listen 443 ssl http2;
    listen [::]:443 ssl http2;
    server_name netbird.mydomain.com;

    #Use letsencrypt.org to get a free and trusted ssl certificate
    ssl_certificate /etc/letsencrypt/live/mydomain.com/fullchain.pem; # managed by Certbot
    ssl_certificate_key /etc/letsencrypt/live/mydomain.com/privkey.pem; # managed by Certbot

    error_log /var/log/nginx/netbird.error.log error;
    access_log /var/log/nginx/netbird.access.log;

    # This is necessary so that grpc connections do not get closed early
    # see https://stackoverflow.com/a/67805465
    client_header_timeout 1d;
    client_body_timeout 1d;

    proxy_set_header        X-Real-IP $remote_addr;
    proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header        X-Scheme $scheme;
    proxy_set_header        X-Forwarded-Proto https;
    proxy_set_header        X-Forwarded-Host $host;

    # Proxy dashboard
    location / {
        proxy_pass http://dashboard-upstream;
    }
    # Proxy Signal
    location /signalexchange.SignalExchange/ {
        grpc_pass grpc://signal-upstream;
        # Can't remember why I turned this off, but it works fine without it
        #grpc_ssl_verify off;
        grpc_read_timeout 1d;
        grpc_send_timeout 1d;
        grpc_socket_keepalive on;
    }

    # Proxy Management http endpoint
    location /api {
        proxy_pass http://management-upstream;
    }

    # Proxy Management grpc endpoint
    location /management.ManagementService/ {
        grpc_pass grpc://management-upstream;
        #grpc_ssl_verify off;
        grpc_read_timeout 1d;
        grpc_send_timeout 1d;
        grpc_socket_keepalive on;
    }
}

can you please share two docker compose files of netbird and nginx proxy manager and also there env sample file

I also had issues with using NGINX as my reverse proxy. Got it working with below configuration:
server {
    listen 443 ssl http2;
    listen [::]:443 ssl http2;
    server_name netbird.mydomain.com;

    #Use letsencrypt.org to get a free and trusted ssl certificate
    ssl_certificate /etc/letsencrypt/live/mydomain.com/fullchain.pem; # managed by Certbot
    ssl_certificate_key /etc/letsencrypt/live/mydomain.com/privkey.pem; # managed by Certbot

    error_log /var/log/nginx/netbird.error.log error;
    access_log /var/log/nginx/netbird.access.log;

    # This is necessary so that grpc connections do not get closed early
    # see https://stackoverflow.com/a/67805465
    client_header_timeout 1d;
    client_body_timeout 1d;

    proxy_set_header        X-Real-IP $remote_addr;
    proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header        X-Scheme $scheme;
    proxy_set_header        X-Forwarded-Proto https;
    proxy_set_header        X-Forwarded-Host $host;

    # Proxy dashboard
    location / {
        proxy_pass http://dashboard-upstream;
    }
    # Proxy Signal
    location /signalexchange.SignalExchange/ {
        grpc_pass grpc://signal-upstream;
        # Can't remember why I turned this off, but it works fine without it
        #grpc_ssl_verify off;
        grpc_read_timeout 1d;
        grpc_send_timeout 1d;
        grpc_socket_keepalive on;
    }

    # Proxy Management http endpoint
    location /api {
        proxy_pass http://management-upstream;
    }

    # Proxy Management grpc endpoint
    location /management.ManagementService/ {
        grpc_pass grpc://management-upstream;
        #grpc_ssl_verify off;
        grpc_read_timeout 1d;
        grpc_send_timeout 1d;
        grpc_socket_keepalive on;
    }
}

@sgtaziz can you please share two docker compose files of netbird and nginx proxy manager and also there env sample file


How do I migrate data structures ?

I LOVE THIS DATABASE!
If I have an existing database and change the structure how do I migrate the existing data in the file or is it done automagically ?
Is there a file viewer available ?
(If I want to copy a data file off an iOS or Android device and view the contents)
Thanks for this awesome project !!!!!

Hi @stephenhauck, thanks for your comment. :)
About upgrade your datastructre, it´s depend what you change. If you only add new field, no problems. If you remove a field, all data will keep this field, but when read/write this extra field will be removed.
The major problem is if you what change datatype in an existing data. In this case, you must "update" your collection to this. You can use UserVersion to control your datafile version schema. Also, you can use BsonDocument to access your old data and update. Some like this:
using(var db = new LiteDatabase("..."))
{
    if(db.Engine.UserVersion == 0)
    {
        foreach(var doc in db.Engine.Find("MyCol"))
        {
            doc["NewCol"] = Convert.ToInt32(doc["OldCol"].AsString);
            db.Engine.Update("MyCol", doc);
        }
        db.Engine.UserVersion = 1;
    }
    ....
}

You can use LiteDB Viewer: https://github.com/falahati/LiteDBViewer

Awesome, THANKS for the quick response...hopefully this will help others :)