igc-reader branch for reading IGC files [WIP]

@Turbo87: i have made a sketch of the igc reader class. Would be great if you could have a look on the structure to make sure that it fits nicely in your library.

It took a while, but i have continued working on this branch. I restructured significantly, implementing your suggestion of a LowLevelReader class. A records and H records are now implemented and i will continue adding the rest. Please let me know when you have suggestions for improvement

@Turbo87 : i have very little experience with continuous integration and cannot get the testing to pass. could you help out? tried to alter tox.ini but that didn't help. it gives a deprecation warning on python 2.6. i don't know whether you have to / want to drop support for python 2.6?

I don't have much time right now to look at it in detail, but I'm fine with dropping Python 2.6 support in general.

no real hurries here. still have to add tests and polish the code a bit.
It seems that it 2.6 is not the main problem: similar error on 2.7.
dropping 2.6 does seem like a good option. maybe moving python 3 to 3.5 and 3.6 while we're at it?
for future reference: should maybe revert my change in the .ini file to get it working.

Tried the current implementation with a set of 1200 flights from Soaring Spot:

1119 flights without errors
68 flights gave F record errors ValueError('F record formatting is incorrect') from uneven string length
6 flights were found, with 'CAMN CAI Conversion' (e.g. this one). they have extra header items and weird formatting
5 flights were found with an unexpected gps_receiver H-record. The record (e.g. in this flight) looks like the following: HFGPS:LXNAV V7,693. Normally there are manufacturer, model, channels, max_alt. It is unclear what the number 693 depicts here
1 flight was found with an unexpected gps_receiver H-record: HFGPS:,3492
1 flight was found with an impossible latitude in the task definition: 9026865N

@GliderGeek thanks a lot for working on this! please let me know when you would like me to merge this.

there are a few things i still want to do

implement error handling. (e.g.: should the file be completely unreadable when there is 1 faulty F-record? i dont think this should be the case)
maximal line length from spec

Good point about rebase, will do that

i am struggling a bit with the structure to implement correct error handling in the HighLevelReader.
a sketch of the current structure, using F records as example:
def read():
    satellite_records = []
    for record_type, line, error in self.reader:
        if error:
            raise InvalidIGCFileError

        if record_type == 'F':
            satellite_records.append(line)

    return dict(satellite_records=satellite_records)

sometimes these F records are faulty, causing a InvalidIGCFileError, while the B-records are fine.
the user might not be interested in the F-records or might not care that a few are faulty and left out.
One possible implementation might be:
def read():
    satellite_records = [None, []]  # first entry is error, second entry is value
    for record_type, line, error in self.reader:

        if record_type == 'F':
            if error:
                satellite_records[0] = error
            else:
                satellite_records[1].append(line)

    return dict(satellite_records=satellite_records)

unfortunately this implementation only stores the last error. furthermore it does not feel like a very nice data structure.
if the user want to read in a file and get the sattelite_records, the following syntax is used:
result = Reader(fp).read()
sat_recs_status, sat_recs = result['satellite_records']

@Turbo87: what are your thoughts on this?

@GliderGeek I think we need to distinguish between errors that are recoverable (which pretty much all of them should be in an IGC file) and error where the parser gets into a state where it can't recover. For those errors that are not recoverable we should just throw an exception, for the recoverable errors we could collect those errors somewhere and offer them in addition to the final parser result at the end?

i don't really follow what you mean. could you make it more explicit with the example of the F-records?
a frequently occuring error in the F-records is an odd number of digits, while a satellite is identified with two digits. Inside def decode_F_record() in the LowLevelReader class:
# each satellite ID should have two digits
if (len(line.strip()) - 7) % 2 != 0:
    raise ValueError('F record formatting is incorrect')

I guess it would be good if the errors that we throw in the low level parser had some information available that indicated which type of record they were trying to parse.
For example there is that I record (if I remember correctly) which changes how the following B records are parsed. If parsing an I record fails it is hard to recover from that since we don't know how to parse the extension data of the following B records. If however a B records can't be parsed we can just skip it and continue with the next one.
Was that description better to understand?

yes, this is much clearer, and in line with what i thought of myself :)
last commit enables a distinction between record types. so it is known on which type the exception is thrown.
now it is a matter of determining which record-type parser error breaks the HighLevelReader and which enables it to continue.
will implement a suggestion in a next commit

btw technically we could also recover from broken I records, by resetting the extension info for the following B records and just not parsing that part of the line. in those cases we should still add a warning to the result thought to make it clear to the library user that something here might have failed.

@Turbo87: last commit contains a suggestion for the error handling.
it should never fail on an igc file as some user might want to retrieve the task (not interested on the fixes) , while other are not interested in the task.
each entry in the results dict contains of two item. the first being a list with errors. this enables the following syntax:
with open('file.igc','r') as f:
    result = Reader().read(f)
    fix_records_errors, fix_records = result['fix_records']
    if not fix_records_errors:
        # use fix_records

@Turbo87: can you take a look at the proposed error handling?

@GliderGeek yes, I'll put it on my todo list

I looked at the code for a bit and I'm wondering if it would be better to have a single errors property instead of an array for every property 🤔

what would this single array store? something like this:
errors = [MissingBRecordsError, InvalidTaskError]

what is the benefit of this?
it seems to me that this has the disadvantage of the user needing to know what the correct name of the error is

@Turbo87: can you let me know whether my current error handling is sufficient? Would really like to finish this implementation.

can you let me know whether my current error handling is sufficient? Would really like to finish this implementation.

yes, feel free to merge as you please. I'm not doing much Python anymore these days so maintenance here is a bit hard for me. Sorry about that...!

i have merged the branch and fixed broken tests (will test more thoroughly  before merge next time 🙈 )

no problem, nice work! 🎉


Static Tree functionality

Is it possible to disable the ability to edit (remove, rename, move, create) node elements?  A flag for disabling editing (either globally, and/or at a node level) would be useful.

@sjdemoor Agree!

I need this too!

+1!

👍  Thanks for turning this so quickly!


react-content-query-webpart Upgrading to latest drop v1.20

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
Category

[ ] Enhancement

Hi Simon-Pierre,
The react-content-query-webpart sample that you've provided is a fantastic resource, showcasing a lot of really helpful custom property pane controls and techniques e.g. searching for sites/webs, selecting resulting lists, filtering on fields, ordering and selecting fields.
I've had a go at upgrading my local instance to the latest drop 1.2 which uses office-ui-fabric-react v4.32.0.   I found a couple things during this process so figured I'd share them, and what I did to get them working again.

The PropertyPaneAsyncDropdown wasn't reflecting the item that was selected from the dropdown list.  If you switched pages within the property pane, and then went back, it would show the correctly selected item.   To fix this I added a call to this.context.propertyPane.refresh(); in the onCustomPropertyPaneChange of the ContentQueryWebPart.ts.

The IPersonaProps interface no longer has a value property.  This causes an error for the CamlQueryHelper.ts and the ContentQueryService.ts.  I've changed this to instead use the primaryText property (not quite sure if this is correct or not, still testing).  So, in CamlQueryHelper.ts, line 163, I've changed it from x.value to x.primaryText.   In the ContentQueryService.ts file I've change line 580 to: let isDuplicate = currentUsers.filter((u) => { return u.primaryText === user.primaryText; }).length > 0;

Office Fabric v4.32.0 now renders the checkbox using a button, where previously it was using an input element.  The button doesn't support the 'data' attribute, so I've had to change the AsyncChecklist.tsx so that it returns the Checkbox using the 'value' inputProp rather than the 'data' inputProp.   I've also had to remove the 'data' property on it.

office-ui-fabric-react Checkbox HTML previously

office-ui-fabric-react Checkbox HTML v4.32.0

Resulting checkbox code to return:
<Checkbox id={ item.id }                           label={ item.label }                           defaultChecked={ this.isCheckboxChecked(item.id) }                           disabled={ this.props.disable }                           onChange={ this.onCheckboxChange.bind(this) }                           inputProps={ { value: item.id } }                           className={ styles.checklistItem }                           key={ index } />
I've then also had to update line 43 in AsyncChecklist.tsx, so that it get's the 'value' rather than the 'data' attribute:
Previously:
let checkboxKey = ev.currentTarget.attributes.getNamedItem('data').value;
Now:
let checkboxKey = ev.currentTarget.attributes.getNamedItem('value').value;
Thanks again for providing this sample, it's been a great help.  Hopefully the above helps.
Regards
Pete

Hi @petecuttriss,
Thanks a lot for detailing the different steps you went through, I will surely use this in my next update. Just so you know, I recently fixed the Web Url by adding a Site Url parameter and changing the way it uses the search by using recursive calls in order to avoid being limited to 500 webs/sites. If you do not already have this version I would suggest you to take a look at it :)
My next update will be to pre-select the current site/web on which the user added the webpart, it will be a good opportunity to update to the latest drop, I will contact you here if ever I have questions :)
Thanks again!

Hi @spplante,
My pleasure.  Glad I could help.
I did some further digging into the issue with the PropertyPaneAsyncDropdown not reflecting the selected item.   I ended up changing the code in the AsyncDropdown.tsx component.  The main change was altering the 'onChanged' binding.  I've bound it to a local method which in turn calls the prop.onChanged method.  It's now working happily.   I've attached the code.
AsyncDropdown.tsx.txt
I'll grab your latest drop and take a look.
Thanks
Pete

Wonderful.
Based on when you took your version on here, you might not have the possibility to add external javascript files and custom handlebars block helpers, you can find how the feature works by looking at the new section all the way down in the documentation.

Hi @petecuttriss ,
I did upgrade the solution to 1.2.0 tonight, and I had the exact same issues as you. Here is what I figured:

I had the same problem with the PropertyPaneAsyncDropdown not showing the correct selected value. I did investiguate on this, and the issue #2719 has already been raised on the office-ui-fabric repository. The issue was introduced in the 4.32.0 version, they did fix the issue already but the SharePoint packages are still pointing to the 4.32.0 version, hence why it is not fixed in SPFX yet.

While your solution for this might be a good temporary fix, I feel like it's kind of an "hack", so I preferred raising the issue #311 to ask Microsoft to upgrade to a newer office-ui-fabric version.

I also had the IPersona error with the .value being removed, however the solution is slightly different than replacing it with PrimaryText. The PrimaryText property is filled with the actual display name of the user and i used to display purpose only. On the other hand, the .value property was used to store the ID of the current user within the site collection. While using the display name for querying content might work, using the ID is critical in order to avoid conflicts and users with the same display name. So the line you were missing is line 375 in the ContentQueryService.ts, which I changed for this :

                let userSuggestions:IPersonaProps[] = users.map((user) => { return {
                    primaryText: user.DisplayText,
                    optionalText: user.EntityData.SPUserID || user.EntityData.SPGroupID
                }; });

So instead of storing the user ID in the value property, I stored it in the optionalText property for later use. I changed the other two occurences of .value as well.

I also had the problem and your solution was correct.

That's pretty much it, for now I will leave this "on hold" until the issue I raised is fixed, then as soon it's fixed I will publish this officially :)
Thanks again!

Great work Simon-Pierre @spplante !  Thanks Pete.

Hi @petecuttriss,
I changed my mind and decided to go forward with a temporary solution that would fix the dropdown issue introduced in<EMAIL_ADDRESS>I figured waiting on SPFX to update the package might take too long, so I went ahead and used most of your solution, except instead of storing the selectedKey in a private variable, I used the state in order be more faithfull to the react model and to fix some issues that I had when resetting the dropdown values later on...I also fixed some scss on the custom filter controls like the people picker and taxonomy picker.
I also took the occasion to add a small functionality that now automatically pre-select the current site url and web url on which the user adds the WebPart for the first time. This can be useful/quicker for 80% of the times where the user simply wants to query content on the current site.
I just submitted everything in the pull request #313, meanwhile if you want to start using it without waiting for the pull request to be merged, you can go get a version directly on the dev branch of my fork.
@VesaJuvonen, this enhancement can be closed 👍
Thanks!

We closed this issue as it had not activity within last 180 days. This is a generic process we have decided to perform for issues, which have not been explicitly marked still to be "work in progress" based on tags. We are performing this cleaning to make sure that old issues that have already been solved (but not closed) or are no longer relevant are cleaned out and make the issues more manageable. If this issue still valid, we would ask you to open a new issue and follow the guidance in the issue template related on the recommended location. We do apologize any inconveniences this might cause. Please do remember that issues in the issue lists are also messages for others in the community, so you can also check if you can assist on any of them. “Sharing is caring!”


Implemented SA1027 unit tests + code fix

Fixes #235
Fixed #243

:bulb: Add a test for a block of text inside #if false (it should be ignored).

Added the #if false test case.

The code fix provider will now always add the amount of spaces required to keep the formatting the same.


kn: Add support for experimental writer api

I think you must give this a look as I think this is not the best practice, if you have any idea about modeling this, please tell me:
https://github.com/zxing-cpp/zxing-cpp/pull/764/files#diff-522c2c5ffea68705c4dd11a7c6100002687b8fb541c5bc1e84b1da025c6a1932R16-R53
https://github.com/zxing-cpp/zxing-cpp/pull/764/commits/5f1be8fcf44a959338d203a35a7c38c2c90ad082#diff-522c2c5ffea68705c4dd11a7c6100002687b8fb541c5bc1e84b1da025c6a1932R73-R89

I think you must give this a look as I think this is not the best practice, if you have any idea about modeling this, please tell me:

I don't like that either. While Image is derived from ImageView in c++, this is not the case (or intransparent) in the C-API. While it would make sense to model it like that in k/n as well to support passing the result of a barcode creation directly back to the reader, this is not really useful in non-testing use cases, so not a priority in my eyes. What I definitively not want to merge is a rename of the public facing ImageView type to ImageViewImplNoCopy. If we deem this subclassing worthwhile then we need to introduce something like ImageViewBase or IImageView and then have Image and ImageView implement that.
I did not have much time to really go through the PR in detail, though.

I think the current version makes more sens.

I've checked all the comments and pushed related changes.
Sorry for late responding...

Thanks for your continued dedication to maintain your contributed code base. Much appreciated.


Music bot

Add music bot feature.

Why not just get spotify?

much discussion about this in chat

too hard to moderate
just get spotify
legal issues


--fail-on-error overlaps with --fail

When I built --fail in #102 I missed that shot-scraper multi already has a similar option, --fail-on-error.
That option turns out to not do much though:
https://github.com/simonw/shot-scraper/blob/378a27cefc45390537c93f73d5415f3e819f2b29/shot_scraper/cli.py#L352-L357
https://github.com/simonw/shot-scraper/blob/378a27cefc45390537c93f73d5415f3e819f2b29/shot_scraper/cli.py#L439-L444
That's the only place it actually has an impact: if a page times out and --fail-on-error is set then you get an error, otherwise it gets skipped.

That option was added in: https://github.com/simonw/shot-scraper/commit/68fe39024bd6febe2cb8bbc2f7de7a4f5a432301

https://github.com/simonw/shot-scraper/pull/51

Potential solutions:

Leave it alone.
Deprecate --fail-on-error - use hidden=True to hide it from --help - but have --fail also handle that timeout case

Demo:
% echo '- url: https://datasette.io/' | shot-scraper multi - --timeout 1 --fail
Error: Timeout 1ms exceeded.
=========================== logs ===========================
navigating to "https://datasette.io/", waiting until "load"
============================================================
% echo $?
1
% echo '- url: https://datasette.io/' | shot-scraper multi - --timeout 1
Timeout 1ms exceeded.
=========================== logs ===========================
navigating to "https://datasette.io/", waiting until "load"
============================================================
% echo $?
0


Can't use with onewire due to InputPin + OutputPin requirement

When trying to use nrf-hal-common with OneWire (https://crates.io/crates/onewire), InputPin needs to be implemented for OutputPin.
I tried to implement this myself, but I seem to be a bit out of my depth :(
Example code is:
let peripherals = Peripherals::take().unwrap();

let pin1 = nrf52840_hal::gpio::p1::Parts::new(peripherals.P1);
let mut temp_pin = pin1.p1_08.degrade().into_open_drain_output(
    OpenDrainConfig::Disconnect0HighDrive1, Level::High
);
let mut wire = OneWire::new(&mut temp_pin, false);

This results in the error:
error[E0271]: type mismatch resolving `<nrf52840_hal::gpio::Pin<nrf52840_hal::gpio::Output<OpenDrain>> as nrf52840_hal::prelude::OutputPin>::Error == ()`
  --> src/main.rs:30:29
   |
30 | let mut wire = OneWire::new(&mut temp_pin, false);
   |                             ^^^^^^^^^^^^^ expected `()`, found enum `void::Void`
   |
   = note: required for the cast to the object type `dyn OpenDrainOutput<(), Error = (), Error = ()>`

error[E0277]: the trait bound `nrf52840_hal::gpio::Pin<nrf52840_hal::gpio::Output<OpenDrain>>: _embedded_hal_digital_InputPin` is not satisfied
  --> src/main.rs:30:29
   |
30 | let mut wire = OneWire::new(&mut temp_pin, false);
   |                             ^^^^^^^^^^^^^ the trait `_embedded_hal_digital_InputPin` is not implemented for `nrf52840_hal::gpio::Pin<nrf52840_hal::gpio::Output<OpenDrain>>`
   |
   = note: required because of the requirements on the impl of `nrf52840_hal::prelude::InputPin` for `nrf52840_hal::gpio::Pin<nrf52840_hal::gpio::Output<OpenDrain>>`

I've opened https://github.com/nrf-rs/nrf-hal/pull/340 which should resolve this

Previously: https://github.com/nrf-rs/nrf51-hal/pull/25

I've opened #401 which should finally resolve this.


Charts Update Is Delayed

Discussed in https://github.com/orgs/locustio/discussions/2769

Originally posted by r01k June 24, 2024
On Locust 2.29.0 (Python 3.12.4) the charts update with an increasing lag behind the user activity. After about 20 minutes in the test the charts have already fallen behind by about 10 minutes. Is anyone else seeing this?

@andrewbaldwin44 Can you have a look - perhaps this is a windows-specific thing?
@r01k can you add some details, maybe your locustfile? And command line.

Can confirm reproducibility on both Windows 10 22H2 machines tested, with a clean venv where only Locust has been installed. Didn't test on Linux. The graphing delay becomes apparent in a couple of minutes.
>locust -V
locust 2.29.1 from E:\Downloads\venv\Lib\site-packages\locust (Python 3.12.4, OpenSSL 3.0.13)

>pip freeze
blinker==1.8.2
Brotli==1.1.0
certifi==2024.6.2
cffi==1.16.0
charset-normalizer==3.3.2
click==8.1.7
colorama==0.4.6
ConfigArgParse==1.7
Flask==3.0.3
Flask-Cors==4.0.1
Flask-Login==0.6.3
gevent==24.2.1
geventhttpclient==2.3.1
greenlet==3.0.3
idna==3.7
itsdangerous==2.2.0
Jinja2==3.1.4
locust==2.29.1
MarkupSafe==2.1.5
msgpack==1.0.8
psutil==6.0.0
pycparser==2.22
pywin32==306
pyzmq==26.0.3
requests==2.32.3
setuptools==70.1.1
urllib3==2.2.2
Werkzeug==3.0.3
zope.event==5.0
zope.interface==6.4.post2

>locust -f test.py

from locust import HttpUser, task

class TestUser(HttpUser):
    host = 'localhost'
    @task
    def ping(self):
        self.client.get("http://localhost:8000/ping")

@cyberw Is it possible that the charts have been scaled? 2.29 charts can be scaled, I had this problem before and found out that the latest version of echats can be scaled.

@cyberw, apparently the charts are upscaled by default. Just looked and that was my case too. Scaling them back to 1 with the scroll wheel in fact allowed the current live stats to be shown.

@andrewbaldwin44 , maybe there is some way to show the user that they have scaled the graph?

Thanks for reporting this issue @r01k, good catch @GeraldWhitehead! I will check this out and have it so the chart shows the live test by defaut. Then I will see if there is also a way to show if the chart is scaled or not :+1:


About faiss

Hi, I am quite interest on faiss, a large-scale similarity search framework. However, I am not familier with C/C++. I want to know whether faiss can be packaged into Java interface for being utilized in Java application.
look forward to you reply.
Best regards.

Yes, it could be via a JNI (Java Native Interface) layer, but this is something that should be discussed on the main repository.  This is a wrapper for openFrameworks, which is C++. http://github.com/facebookresearch/faiss/


engine: Add titan customized statistics

What have you changed?
Add Titan customized statistics exported by https://github.com/tikv/titan/pull/129
What is the type of the changes?

Engineering (engineering change which doesn't change any feature or fix any issue)

How is the PR tested?
No code
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Release note

Add more Titan statistics

tests can be passed when https://github.com/tikv/rust-rocksdb/pull/488 is merged

LGTM. wait for merging with https://github.com/tikv/rust-rocksdb/pull/488

@brson I remove the engine/rocks/util/engine_metrics.rs in favor of engine_rocks/src/rocksdb_metirics.rs, PTAL


How to combine continuous BLE scan and the IotWebConf lib?

I have set up NimBLE to act as a client up against a density meter from Anton Paar.
The BLE part works great but the continuous  BLE scan is giving me some headache.
I want to use the IotWebConf lib to configure wifi and mqtt server parameters etc.
The problem is that this lib requires a loop to be functioning and that do not pair up well with the scan.
The ESP32 connects to the Wifi but I am not able to access the internal webserver in IotWebConf while the scan is running. If I turn on the density meter and the BLE client connect (scan is stopped) I can access the webserver.
But as soon as the scan start again (I turn of the density meter) the webserver stops responding.
Everything else with the BLE client works as it should - just not scan part.
Is there a way to make keep the continuous scan and still be able to access the webserver ?
I "delay" the BLE part that should have been in setup() by not running it until the Wifi is connected.
I use a executeonce inside loop() for this.

void loop() {
iotWebConf.doLoop();
if ((executeonce == false) && (WiFi.status() == WL_CONNECTED)) {
executeonce = true;
setClock();  // set the clock using NTP
startBLE();  // starts the BLE part that should have been in setup()
}
if(millis() - last_time > 1000) {
///// The rest of the BLE client code goes here and this part works well
last_time = millis();
}
}

void startBLE()
{
Serial.println("Starting Arduino BLE Client application...");
BLEDevice::init("");
BLEScan* pBLEScan = BLEDevice::getScan();
pBLEScan->setAdvertisedDeviceCallbacks(new MyAdvertisedDeviceCallbacks());
pBLEScan->setInterval(1349);
pBLEScan->setWindow(449);
pBLEScan->setActiveScan(true);
pBLEScan->start(0, false);
}`

Hi @thomassandberg, what I have done before to make this work is put the iotwebconf.loop in a separate task with a delay.
void webConfTask(void *params){
  uint32_t notifiedValue;
    for(;;){
      xTaskNotifyWait(0x00,ULONG_MAX,&notifiedValue, (1 / portTICK_PERIOD_MS));
      iotWebConf.doLoop();
    }
}

Created in setup like this xTaskCreatePinnedToCore(webConfTask, "webConfTask", 4500, NULL, 1, &hWebConfTask, 1);

Dude! That worked like a charm! Thank you very much :)

Great, probably not the most applicable code for your use but I'm glad it works.
xTaskNotifyWait(0x00,ULONG_MAX,&notifiedValue, (1 / portTICK_PERIOD_MS));
could simply be replaced with delay(1); for you usage unless you need to send task notifications to it later.

Closing as resolved.


Refactor Wigner function into module

Context:
Calculation of the Wigner function is already included in Mr Mustard but hidden in the graphics module
Description of the Change:
This PR moves the Wigner function calculation to its own module and numbifies it.
Benefits:
Now you can calculate the Wigner function using
from mrmustard.utils.wigner import wigner_discretized

wigner_discretized(dm, q, p) # dm is a density matrix

It should be faster as well because it uses numba jit.
Possible Drawbacks:
None

Nice! We can easily write the P and Q as well right?

Correct! Though I think all this functions will have a better place to be in soon with the representations. Right now it feels a bit missplaced.


docs(v2): clarify theme-original and theme-init

Motivation
https://github.com/facebook/docusaurus/issues/3043
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Change to api-pages.md Page Require Paths
Related PRs
As explained by https://github.com/facebook/docusaurus/pull/2464#issuecomment-603802459

Hi and thanks.
Unfortunately, after reading that doc I'm still not 100% convinced to understand those aliases and why they are useful in practice 🤪
Will need to understand first, and see how we could improve the doc later

Let's merge this for now, but keep the issue open, because I still feel the doc can be clearer

Oh, that's unfortunate but this has been contributed to v1 docs while it's a v2 feature :( will fix that soon


Latest version of Werkzeug does not support Flask 2.0.2

Adding Werkzeug==2.2.2 to requirements.txt fixes the issue

I set it to Werkzeug>=2.3.8,<3.0.0

Can confirm that the fix recommended by @ljarman84 works. Opened a pull-request: https://github.com/PaloAltoNetworks/cdl-decompress-proxy-sentinel-ingest/pull/9

Hi, had this same issue and managed to resolve with updating requirements.txt to
requests==2.27.1
Flask==2.0.2
Werkzeug>=2.3.8,<3.0.0
gunicorn[gevent]
gevent

We had the same issue and updated our requirements.txt file to the following and it started building the app correctly:
requests==2.27.1 Flask==2.2.2 Werkzeug==2.2.2 gunicorn[gevent] gevent
I should also point out that the WORKSPACE__ID and SHARED_KEY (called out on other issues/PRs) need to be present in your environmental variables or it still wont work.  These are the Workspace ID and Secret for your Log Analytics workspace.  Palo Alto could do with reviewing some of the recommendations/bugs here.


Support for shallow clone

Would be useful in some cases to have shallow clone with the same feature that implementes "git clone --depth".

Sounds like maybe you're looking for https://github.com/gogits/git ?  go-github is focused pretty squarely on implementing the GitHub API, not git itself.

Sorry, I opened the issue on the wrong project 👎

gogits/git author said,

it is out of maintenance, recommend https://github.com/src-d/go-git for now.

https://github.com/gogits/git/issues/17


Bug report: add field in table

I use SQL Server 2016.
When I use DBEver' GUI to add Field to table, I input field name in text field box，click "ok" button,
but in field list ,new fieldname is "column1", lost my input data.

The same issue with other Generic-based drivers.
Thanks for bug report.


Add v0.11.16

Need to double check that this will build since they are using SHA512 now.

Back to SHA1 again, I guess.

Thanks, sorry it's taken me so long to get to this


[SPARK-39877][PYTHON][FOLLOW-UP] Add DataFrame unpivot to PySpark docs

What changes were proposed in this pull request?
Adds the new DataFrame.unpivot method to PySpark docs.
Why are the changes needed?
https://github.com/apache/spark/pull/37304#discussion_r934080682
Does this PR introduce any user-facing change?
Only documentation.
How was this patch tested?
No

Merged to master.


[msal-react] AADSTS7000218: The request body must contain the following parameter: 'client_assertion' or 'client_secret'

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.15.0
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.0.1
Description
When using the msal-react library as defined, I get the title error upon logging in
AADSTS7000218: The request body must contain the following parameter: 'client_assertion' or 'client_secret'

Error Message
AADSTS7000218: The request body must contain the following parameter: 'client_assertion' or 'client_secret'.
Msal Logs
No response
MSAL Configuration
{
    auth: {
        clientId: "<client id>",
        authority: "https://login.microsoftonline.com/<tenant id>",
        redirectUri: "http://localhost:3000/",
        navigateToLoginRequestUrl: false
    },
    cache: {
        cacheLocation: "sessionStorage", // This configures where your cache will be stored
        storeAuthStateInCookie: false, // Set this to "true" if you are having issues on IE11 or Edge
    },
    system: {
        loggerOptions: {
            loggerCallback: (level, message, containsPii) => {
                if (containsPii) {
                    return;
                }
                switch (level) {
                    case LogLevel.Error:
                        console.error(message);
                        return;
                    case LogLevel.Info:
                        console.info(message);
                        return;
                    case LogLevel.Verbose:
                        console.debug(message);
                        return;
                    case LogLevel.Warning:
                        console.warn(message);
                        return;
                }
            }
        }
    }
}

Relevant Code Snippets
I'm just running the example: https://github.com/Azure-Samples/ms-identity-javascript-react-spa

Reproduction Steps
Follow the steps in the example repo: https://github.com/Azure-Samples/ms-identity-javascript-react-spa
Expected Behavior
I'd expect it to successfully login.
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Firefox
Regression
No response
Source
External (Customer)

.. Forgot to mention in the above that I saw this issue https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/3792 and attempted the fix from there, but that did not fix my issue.

Did you register an App on Azure AD?

Yeah it's set up on AAD, I have a redirect URL for SPA set up as http://localhost:3000

@cccs-cat001 Do you happen to have other localhost reply urls registered or is that your only one?

Yeah I have other localhost ones registered, but not for SPA. I'm in the process of creating a replica app registration which will only have the one reply url to see if that fixes anything

Hi @cccs-cat001, feel free to let us know if it fixes the problem.

@cccs-cat001 Thanks for confirming. localhost is a special case in which the server treats localhost urls the same if the only difference is the port. (e.g. localhost:3000 is the same as localhost:4000) When you have multiple localhost urls registered under different app types the server will choose one at random to use which can result in the error you are experiencing if it didn't happen to choose the one registered as type SPA.

Sorry issue still isn't resolved, our cloud team is just taking a while to approve the app registration I'm trying to create

Looks like it works fine with just the one localhost redirect :)


feat Port/data.list.big operators.lemmas

Should work after #1380 is merged.

@semorrison why the label blocked-by-other-PR is removed?


Created krishnamurthy_number.py hacktoberfest

This is a Python 3 program to check if a number is Krishnamurthy number.
A number is a Krishnamurthy number if the sum of the factorials of the digits of the number is equal to the number itself.
For example, 1, 2 and 145 are Krishnamurthy numbers.

I have added your PR but make sure you fix it by making a folder of your GitHub username and then upload it


Configurable process list

Description
At the moment the PyWPS application is created using the wsgi.create_app function, which imports the list of PyWPS.Process instances defined in processes/__init__.py. I think it would be useful to have a way to configure active processes, for example using a yml config file, which could list the process identifiers to deploy within the Service.
Now to map the identifiers to the process classes, we could

inspect objects inside the processes/ directory, find Process subclasses and extract their identifier
modify PyWPS to register Process subclasses
create a register_process decorator in the cookie-cutter

@tlvu As discussed.


Fix developer warnings

Notes for Reviewers
This PR fixes #10002
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit b7506a50a5a0db64e78e02b50a21dcca8cd90d86 at: https://65ab787ec319e862e0ad6669--meshery-docs-preview.netlify.app

@meshery/maintainers @meshery/meshery-ui-maintainers do we want all console.logs removed?

that commit is for another PR in next issue, I have created new branch. but the commit is being added to this pull request

https://github.com/meshery/meshery/pull/10027
this was the pr for that issue.

@meshery/maintainers @meshery/meshery-ui-maintainers do we want all console.logs removed?

removing does not do any harm i guess and we are exposing many unnecessary info to users and will just create noise in logs


[Bug]: Gatsby Functions is skipped even if they exists

Summary
I have a vanilla install of Gatsby + one Gatsby function. I installed to support Gatsby on Netlify.
Before upgrading to the newest version of gatsby-plugin-netlify it would detect functions as expected.
After upgrading, it skips building Gatsby functions.
Steps to reproduce

Pull down reproduction repro-gatsby-netlify-functions-plugin
Deploy to Netlify
See message Skipping Gatsby Functions and SSR/DSG support because gatsby-plugin-netlify reported that this site does not use them.

Plugin version
5.0.0

Closing as dup of https://github.com/netlify/netlify-plugin-gatsby/issues/385


Is this urfave or codegangsta

I think this was a typo, could you update it whenever you are making a docs update? ty

Hah, that was my typo, thank you @Firescar96


Add WASTED by Juice WRLD

Song Name
WASTED
Artist Name
Juice WRLD
Source
Youtube
Youtube Link
b7MumMyhCBk
Direct File Link
No response
Song ID
1
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 64097173

reject


NoMethodError at /subscriptions/new undefined method `router_name' for nil:NilClass

After creating a plan, when you click on it, I get an error on the subscriptions/new?plan=2 view. Screenshot below.
Looks like there may be an issue with the app trying to redirect to login possibly?

It looks like this issue happens when a user tries to add a new plan, but doesn't have one on file. On the demo site, it redirects to the card page and references the user. It's almost as if the user can't be found, so there an issue with devise/app. Any suggestions?

I updated the link to: http://localhost:3000/koudoku/organizations/1/subscriptions/new?plan=2
Replacing users/:id with organizations/:id and i got the route to redirect to unuauthorized. Looks like this is the crux of the issue.


Was something missed in this project early on?


⚠ Bofrost.at has degraded performance

In b4f2c5b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1618 ms

Resolved: Bofrost.at performance has improved in 1fc6a41.


Sorting with include

How can I use orderBy for include in a request.  So that I can sort the nested response.  For example, api/clients?include=users&orderby={"id":"asc"} only sorts clients records, but not nested users records.  How can I additionally sort users?

Hello @AntonAndreevichMoroz, the lib currently doesnt support nested orders, but I'd be glad to accept a PR that fixes this :)


docs: update readme

Update for currency

remove deprecated block explorers
add context to map of zones entry
remove validator list, we have so many now and we want more
other minor updates because @toschdev encouraged us all to make this resource more awesome

thank you @barriebyron great work!!!


server busy

i got server busy on terminal.

Which type of authentication do you use, PTC or Google?

google

I was experienced the same problem when trying to use Google account to sign in. Do you use two-factor authentication in your Google account?

nope.

I've just checked, in my case disabling the two-factor authentication helps. Did you try to use PTC to sign in?

setup app password to bypass two-factor authentication

@hklcf maybe we need to add correct error messages when using Google account?

yeah. its blocked by authentication

@screamolic solution

https://support.google.com/accounts/answer/185833?hl=en

@hklcf link error. and i cant find the aapps on my list.

Tutorial on how to fix this issue here: https://github.com/PokemonGoF/PokemonGo-Bot#google-login-issues-login-error-server-busy
Closing this for now.
/closed


Wrap table cells for a better responsive table experience + fix print

Fixes

#117
https://github.com/rtfd/readthedocs.org/issues/2161

Adds:

Wrapping for s on desktop sizes
Visible overflow and wrapping on printed media

Does not wrap  on purpose, this leaves a bit of control for people who wanna force the width of certain columns.
Please observe the great amount of projects working around the issue with related commits, issues and PRs.
Quotes:
@kmike

Why not have relevant CSS fixed by default? Are there cases when it is desirable to truncate the information in table, be it a tablet screen or a computer screen? On tablets existing tables are even worse because horizontal scroll of individual elements is hard on touch interfaces. On macs there is no indication that table can be horizontally scrolled because scrollbars are hidden by default; they don't appear even on hover, you need to actually start scrolling to see the scrollbars.

@agjohnson

This was a design decision for the theme around table wrapping, though I agree that the experience around wide tables on large displays is generally poor.

Before
I agree that this may look nicer, but that's only because the example table doesn't have a lot of text in its s!

After

Printing
There's now a higher probability that tables will print:

FAQ
Q: Why no overflow: visible on desktop tables?
A: Because horizontal scrolling is completely off in the theme, so the table would be cropped like this :/

I'm also convinced that for readability, now that wrapping is introduced, we need vertical-align: top for  which has to go through a separate rule.
Displays like this:

Hi,
I probably have a corner case with this issue: in my docs, there's a table in which the first column always has preformatted text which is pretty long and overlaps with the next table cell.
See here at page 12 and forward.
Would this corner-case be fixed by this PR?

@dpdani No, the CSS that changes print media is about printing HTML through a browser, your report is generated with a different ruleset for Latex. I'm not sure why, but if you read up on how Latex works and about how in penalises and optimizes its layout to have as little penalty as possible, you'll get the idea why this can happen.

@benjaoming Ok thank you.

FYI, this is a sensitive change, so the review might take a while as we test.

@Blendify sounds good! Thanks for taking time to test it!

@ericholscher @agjohnson questions or concerns here that I can respond to?

+1 for this change. I was wondering why one of the tables looks so weird, and found that white-space: nowrap rule. Changing it to normal makes it look much better.
Before:

After:

Hi RTD team,
What are the prospects to have this PR merged?
This bug is really annoying.
Here is my story:

First I was avoiding tables that have long sentences.
Then I switched to using Definition Lists. This is acceptable as an alternative for two column tables, but does not work if you have three or more columns with text that should be wrapped.
Finally, being confronted with multiple column tables with a lot of text that is hard to read because of this issue, I have no choice but to patch this nice theme. I found a patch by  Rackspace Documentation Guides that eventually brought me to this PR ready and waiting, vintage 2017 :wine_glass:

Looking forward to see this PR merged.
Documentation by RTD will be better without crappy tables like below you have to scroll left and right to be able to read it:

We will have a look as soon as the next release is out.

We will have a look as soon as the next release is out.

@agjohnson

agjohnson removed the PR: ready for review label 14 days ago

What does that mean?
PR is rebased to latest master.

@agjohnson

agjohnson removed the PR: ready for review label 14 days ago

What does that mean?
PR is rebased to latest master.

This can be ignored, it was automated. All the labels for rtfd were synced so some were removed.

@benjaoming we don't use that label anymore on rtd, now we use work in progress (not ready for review) or 'not label' (ready for review if ci pass) flow

Okay, it's ready for review... and has been since June 2017 :smile:

What are the chances of getting this reviewed/merged in the foreseeable future?

Adding this for additional reference to the extensive workarounds for this issue: https://github.com/OpenShot/openshot-qt/pull/1272

Fixed a bit of SASS syntax and merged latest master in.
Understanding that this PR will change how existing tables are displayed by default. One hack will still exist to keep very wide columns because nowrap is maintained on  (I would actually want to remove that if no one objects)

What do other themes do?
Short answer: They wrap text in table cells.
As there aren't any specific worries associated with the change and I see other themes with text wrap in table cells, I think this would still be the way forward.
Examples of other themes with wrapping:

Alabaster: https://sphinx-themes.org/sample-sites/default-alabaster/kitchen-sink/tables/
Furo: https://sphinx-themes.org/sample-sites/furo/kitchen-sink/tables/
PyData: https://sphinx-themes.org/sample-sites/pydata-sphinx-theme/kitchen-sink/tables/
Material: https://sphinx-themes.org/sample-sites/sphinx-material/kitchen-sink/tables/
Karma: https://sphinx-themes.org/sample-sites/karma-sphinx-theme/kitchen-sink/tables/

(I didn't find an example of the opposite)

Bumping the release on this, 1.1 is a bug fix release.


Fix hidden category/channel bug

Hi!
I saw #368 and decided to take a bit of a closer look at it. I set up a server like this, which I think emulates the situation described in the issue close enough:

private-category (visible to admin only)

role1 (visible to role1 only)
admin (admin only)

public-category (visible to all)

role1 (visible to role1 only)
admin (admin only)

empty-public-category (visible to all)

(no channels added here)

Previously, this resulted in the following GuildTree:

public-category

role1

With this fix, the GuildTree looks like this for the role1 member:

private-category

role1

public-category

role1

This matches how the web client displays them, too.
The issue was that categories were not being drawn if the user did not have view channel permissions for them. However, a category can be hidden and still have user-visible channels, which should be drawn in the guild tree.
With this fix, the createChannelNodes() function now has three steps as follows:

Draw all top-level, non-category channels
Draw categories that have at least one visible channel (regardless of the categories' own visibility)
Draw channels inside (visible) categories if they are visible to the user

Cheers!

Fix definitely works, thanks so much!


added coin change and mst problem in greedy folder

Pull Request for PyVerse 💡
Requesting to submit a pull request to the PyVerse repository.

Issue Title
Please enter the title of the issue related to your pull request.
added coin change and minimum spanning tree problems to the greedy folder.

[x] I have provided the issue title.

Info about the Related Issue
What's the goal of the project?
To contribute algorithms related to the greedy approach by adding the coin change and minimum spanning tree (MST) problems.

[x] I have described the aim of the project.

Name
Please mention your name.
Riya Rane

[x] I have provided my name.

GitHub ID
Please mention your GitHub ID.
riyarane46

[x] I have provided my GitHub ID.

Email ID
Please mention your email ID for further communication.
<EMAIL_ADDRESS>
[x] I have provided my email ID.

Identify Yourself
Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, SWOC).
GSSOC , HACTOBERFEST

[x] I have mentioned my participant role.

Closes
Enter the issue number that will be closed through this PR.
*Closes: #314 *

[x] I have provided the issue number.

Describe the Add-ons or Changes You've Made
Give a clear description of what you have added or modified.
Added two problems, the coin change problem and the minimum spanning tree (MST) problem, in the greedy folder..

[x] I have described my changes.

Type of Change
Select the type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Describe how your changes have been tested.
The problems were tested with multiple input sets to ensure accuracy and efficiency of the solutions.

[x] I have described my testing process.

Checklist
Please confirm the following:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

@UTSAVS26 @TheChaoticor ???


Lot of syntax issues inside codebase.

Inside Adyen.js, there are large number of syntax errors in the stable version released. Please have a look and release the cartridge after removing syntax errors.
There is possibility of syntax errors inside other files as well.
Common syntax errors:
Extra commas at large number of places due to which functionality is breaking, like Adyen callback.

Ok @maassenbas , will give a try. Thanks for reply.


The more buttons on the home page are disappointing

The front page shows 6 apps in each category. Clicking the more button for each one shows the following number of apps:

Popular: 50
New and updated: 10
Editors choice: 10
Editors choice: 10

So in most cases, someone only sees 4 more apps when they click more. This is disappointing and not a great experience.
The obvious fix here would be to show more apps. Since each row contains 7 apps, picking a multiple of 7 would ensure a better page layout. 35 might be a good number (ie. 5 rows).

I agree the editor's choice are very disappointing. On #69 we discussed fixing the list but I haven't find the time. Could you help me on this?
News and updated show apps that where added or updated in the last 7 days. The only way to make it bigger is making the period longer (15 days?) or telling developers to publish/update more :-)
The most popular display resolutions according to Google Analytics are 1920x1080 (34% users) (7 tiles per row) and 1366x768 (26% users) (5 tiles per row). I think 35 apps per list is a good number


Spans aren't being marked as errors in Cloud Trace

Hi,
I'm instrumenting a gRPC server with OpenTelemetry and Google Cloud Trace. I can see spans in my Trace dashboard but they aren't being coloured red if an rpc returns an internal error. I'm using the otelgrpc.UnaryServerInterceptor() (code here) which calls span.SetStatus with the otel error code and the grpc message if any of these statuses are returned

grpc_codes.Unknown
grpc_codes.DeadlineExceeded
grpc_codes.Unimplemented
grpc_codes.Internal
grpc_codes.Unavailable
grpc_codes.DataLoss

I've also tried calling span.SetStatus outside the interceptors and Cloud Trace doesn't colour them red either so I don't think the problem is with the interceptor code.
I've created a simple demo app to reproduce this using the example grpc-go Greeter service with the addition of tracing using otel and  cloudtrace.
When forcing a request to fail this is what I see in cloud trace

The interceptor has added the attribute rpc.grpc.status_code: 13 but the span status isn't showing up.
Ideally this would produce a red dot in the trace graph and the span would be coloured red.
Many thanks,
Andy

This seems suspicious... https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/6b51e22bb5a89706db8e631469b1a491a0a693c3/exporter/trace/trace_proto.go#L162-L163

Seems potentially related to https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/issues/143

@aabmass do you remember why we set codes.Error to codepb.Code_UNKNOWN?

Unknown represents an unknown error, along the lines of HTTP 500 status code. Since OTel only has two possible statuses (OK and ERROR), gRPCs UNKNOWN (error) seems reasonable.
Do you know what status codes actually show red in Cloud Trace?

It does seem like we are doing the right thing based on https://pkg.go.dev/google.golang.org/genproto/googleapis/rpc/code#Code

// Unknown error.  For example, this error may be returned when
// a Status value received from another address space belongs to
// an error space that is not known in this address space.  Also
// errors raised by APIs that do not return enough error information
// may be converted to this error.
//
// HTTP Mapping: 500 Internal Server Error
Code_UNKNOWN Code = 2

Do you know what status codes actually show red in Cloud Trace?

I'll see if I can find the answer to that question.

I tested all status codes, and none appear to make the span look like an error

I'll reach out to the trace UI team.

For further context, the way we're getting around this currently is by setting /http/status_code to 500 regardless of whether the context is for a HTTP server or not.
It seems to be the only way to make the trace UI render it as an error.

Hi @dashpole, is there any update on this?

+1. We are facing this problem as well. Thanks for pointing to the workaround!

Lowering to p3 since the workaround is sufficient

workaround is odd. adding http status code to code just so Google Trace can recognise, is not good. for example, if there is custom span (e.g. span_kind worker or consumer in open telemetry lingo) then Google Trace is not helpful. At least being able to configure what user threats as error would help. For example, in Grafana this is possible.
I spent some time to find where the error happen buy looking at the span attributes and finding grpc status 7. no colors at all, all blue. very hard to read. Google Trace needs to improve.


Find all possible paths between two vertices on a graph

Is there a way to determine all possible paths between two vertices?

Unfortunately, there is currently no out of box solution for this in the library. Feel free to make a contribution in the case you need to implement it ;)
However, i might add that depending on the size and connectivity of the graph, it can become quite slow every quickly. In deed, to know all the paths between two vertices, we need to check and compute every simple paths (no cycle) between them. There can be 2^(n-1) of them in the worst case (ie in a fully connected undirected graph of n vertices) and even more (typically O(n!) I think) if the order of the visited vertices matters (ex: the path cost would be different in a directed graph).
Food for thought :
http://stackoverflow.com/questions/9535819/find-all-paths-between-two-graph-nodes
http://stackoverflow.com/questions/713508/find-the-paths-between-two-given-nodes
http://mathematica.stackexchange.com/questions/25779/finding-all-simple-paths-between-two-vertices-in-a-graph
http://cs.stackexchange.com/questions/423/how-hard-is-counting-the-number-of-simple-paths-between-two-nodes-in-a-directed
Will let the issue open ;)

@letournel  thanks for your reply, in the end, I followed this tutorial and implemented using a recursive sql query, something that i wasn't even aware it was possible.


Optimize MNT6 pairing (2-NAF Miller loop)

#305
MNT6

For CI / Test (nightly) failing, see #303

Hey @yelhousni, thanks for the PR!
We're transitioning the code in this repo over to https://github.com/arkworks-rs/algebra/; could you make the PR there instead?

Hi @yelhousni do you mind re-opening this PR against arkworks-rs/algebra? Sorry for the inconvenience!


Switching shards will summoned prevents return

ppr will just say the player is offline, if he switched to another shard

Fixed https://github.com/Civcraft/PrisonPearl/pull/174


Emit change event on uploadFile calls

In puppeteer 1.20.0, the following code emitted an alert:
const puppeteer = require('puppeteer');

(async () => {
	const browser = await puppeteer.launch({args: ['--no-sandbox'], headless: false});
	const page = (await browser.pages())[0];

	await page.setContent(`
		<input type=file>
		<script>
		document.querySelector('input').addEventListener('change', () => {
			alert('Uploaded a file');
		});
		</script>
		`);
	const input = await page.waitForSelector('input[type="file"]');
	await input.uploadFile(__filename);
})();

This is broken in puppeteer 2.0.0 and 2.1.0.
A bisection yielded 6091a34a360b0b8aec4d67f6190f131d7e8e3300 as the commit that broke this.
Emitting the change event as well seems to fix the problem.

Thanks for the patch! Could you add a test for this as well please?

This PR (and bug) is related to the same file upload changeset: https://github.com/puppeteer/puppeteer/pull/5358 (and should be merged at the same time with this PR I think)

Updated to include tests for the input and change events.

Test failures seem unrelated to code changes.


Document jax config to disable remat HLO pass

A recent PR added a jax config option to disable the remat HLO pass. This PR adds some documentation about that config option.

@hawkinsp Any idea who can review this PR?


Content Library

I would love to see a library that brings all the content from events together
Ideally with the option to either upload or just link content (on github, personal blogs, wherever).
When google searching for presentations, there is a lot of clutter - this could be highly focussed.
Thoughts?

Awesome suggestion - How do we enable this

Invite speakers to link content on the event page via PR
Do magic to collate all these links onto datasaturday.com/library
....


Use a different polkit policy name for each Atom channel on Linux

Refs: https://github.com/atom/atom/issues/17884#issuecomment-503992230
Using the same name would generate an exception when trying to install more than one version of Atom at the same time.

I've tested the latest nightly on my Ubuntu VM and this fixes the problem. After installing atom-beta and atom-nightly we have this polkit policies:
$ ls /usr/share/polkit-1/actions/atom*
  /usr/share/polkit-1/actions/atom-nightly.policy
  /usr/share/polkit-1/actions/atom.policy

I've also verified that the polkit integration works correctly when having the two policies.
@as-cii should we cherry-pick this change on the 1.39-releases branch to be sure that users that have the beta installed don't experience this problem when the polkit changes go to stable?


Uncaught TypeError: reactComponent.getName is not a function (React 16)

Hello, I have been experiencing an error when using react-a11y with React 16.
It seems the issue is: reactComponent.getName() in lib/index.js on line 137 is undefined in React 16.
Below is a concept that may help resolve the issue.
  // Validate component name against React Version
  // Version <= 15 use reactComponent.getName()
  // Version >= 16 use reactComponent.type.name
  var reactComponentName = Boolean(reactComponent.type)
    ? reactComponent.type.name
    : reactComponent.getName();

  // If a Component instance, use the component's name,
  // if a ReactElement instance, use the tag name + id (e.g. div#foo)
  var name = reactComponent && reactComponentName || type + '#' + props.id;

Also running into this which makes react-a11y unusable with React 16, unfortunately. I have to disable it until this is fixed.

Looks like it would be fixed by https://github.com/reactjs/react-a11y/pull/139; anything we can do to support this fix getting merged? :)

Please try updating to v1.0.0 as this issue should now be fixed.  Let me know if not and I'll reopen this.


Fix few things and python3 compatibility

Hi,
I found some issues, Please feel free to comment.
Best regards
B

I have a branch and the internal repository too which I verified with Python 3.6 and tests, though limited are passing.  I'll take a closer look though to see if you caught anything else.  Thanks!


Work Package wp-ij.csv

Results of Phase 1:
wp-ij-results.csv

wp-ij-results.csv

Results of Phase 2
wp-ij-results.csv

Results of Phase 2
wp-ij-results.csv


Putting an empty file will return an error

When trying to put an empty file, content here will be null and will fail with Cannot read property 'destroy' of null
Current s3 behaviour is to handle the empty file correctly

I'm not able to reproduce making object.content null when putting an empty file. Within S3rver I'm seeing an empty stream, and when retrieving the object via the Node.js aws-sdk it correctly gives an empty Buffer. The following test I attempted works just fine:
  it("should store an empty object in a bucket", async function() {
    await s3Client
      .putObject({
        Bucket: buckets[0].name,
        Key: "somekey",
        Body: fs.createReadStream('./empty')
      })
      .promise();
    const object = await s3Client
      .getObject({ Bucket: buckets[0].name, Key: "somekey" })
      .promise();
    expect(object.ETag).to.match(/"[a-fA-F0-9]{32}"/);
  });

where "empty" is a zero-byte file.

Thanks for having a look 👍
I think it's getting triggered only by the HEAD method after the object has been PUT
If you need more context let me know

I was able reproduce this by modifying that test to use HEAD instead, so thanks for the suggestion. It was a subtle bug but fortunately had a simple fix. I think I should finally have some time to put together a release tonight, thanks for your patience.


Update Security Report with 0 findings

When a report with 0 findings is generated, the vulnerability summary table still shows and an additional page is also created.  This may be confusing for the reader.
A 0 finding report should replace the vulnerability summary table with a clear an concise message such as "No vulnerabilities were found during this assessment."

This ticket will also handle if any of the following do not exist:

Executive Summary
Problem Locations
Resources
Screenshots


missmatch with naming on pods from nested tasks in DAGs in the UI (fail to retrieve live logs)

Pre-requisites

[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
hi, from v3.4.3, the field POD_NAME in the UI is not correlated with the pod created in k8s in some cases.
As an example:

workflow_name: foo-lg77s
task of dag name: foo-lg77s.bar
task of subdag of task on dag: foo-lg77s.bar.my-stage
concrete retry pod name (because last task has retries): foo-lg77s.bar.my-stage(0)

In this example:

reported POD_NAME in Argo UI (and the one logs are tried to be get): foo-lg77s-3278223386 .
REAL POD_NAME created in K8S: foo-lg77s-my-stage-3278223386

Somewhere over there a mismatch between names of created pod names in task of tasks of DAGs is rising so the UI will not show the logs.
Not happening with <v3.4.3 (if i remember well)
Version
v3.4.3
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
no wf

specifically, the NAMEon the UI is kargentina-1-279wc.s2t-core-lower.wait-main-get-logs(0), the POD NAME in the UI is kargentina-1-279wc-931539070
but the pod name inside k8s is kargentina-1-279wc-wait-main-get-logs-931539070, so argo workflow controller is disconnected from what is happening in K8S

@JPZ13 Can you look at this issue?

@isubasinghe @rohankmr414 Can I get one of you two to look into this? I'll be available to review it Wednesday or Friday if y'all can get a fix out before then


Bypass Authenticator App not Displayed

The screenshots in steps 1-12 show the option at the bottom of menu "I want to set up a different method"; this is not shown in our current testing.  We have some users that do not want to install the Microsoft Authenticator application and, not allowing them to skip this step to use the phone/text only options will make adoption difficult.  Will this option return and/or is it something that could be added?  The "old" method is simple enough but, so far, we greatly prefer the guided registration process. Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f713c469-83c5-e98b-a18b-2eff0df2a992
Version Independent ID: 549c8059-4404-13db-5259-08395afe3ea8
Content: Set up security info (preview) from your sign-in prompt - Azure Active Directory
Content Source: articles/active-directory/user-help/security-info-setup-signin.md
Service: active-directory
Sub-service: user-help
GitHub Login: @eross-msft
Microsoft Alias: lizross

@joeywalla Thanks for your feedback! We will investigate and update as appropriate.

@joeywalla  Thank you for taking the time to write. I spoke with the product group about this and it turns out that the bypass link only appears when you're using the app code option. If you're using notifications, you can only register the Microsoft Authenticator app. Please let me know if this fixes your problem.

@joeywalla  Please feel free to add a comment or open a new issue, but I'm going to close this one for now.
#please-close

Thank you @eross-msft!  In order to use the app code option, would I have to disable the push notification option?
Thank you again!

@joeywalla. Unfortunately you would have to turn off notifications, you can only use one of the options at a time.

Thank you @eross-msft for your reply.  Do you have a recommended approach or, set up, to enroll users who will not want to install any applications (MSFT Authenticator or otherwise) but instead, will only want to verify using the phone call or, text option?  Is this possible when using the new "mysignins.microsoft.com" portal or, will we have to revert to using the original registration method/portal?  So far, I would greatly prefer to use the guided method of registration as, it appears to be much more intuitive for our users.
Thank you again for your help!


🐛 [BUG] - FormControl.Validation ignores id attribute, blocking aria-describedby linkage

Describe the bug
Hey folks,
We’re working with Primer Brand form components and think we’ve found an accessibility issue with the FormControl.Validation component. We’re trying to connect the TextInput with the corresponding FormControl.Validation component using aria-describedby and id attributes on both components. The issue is that FormControl.Validation seems to ignore the id attribute we pass as a prop, so we’re unable to link the two components together (even though the documentation states it’s a valid prop for this component).
<FormControl fullWidth required>
  <FormControl.Label>Your email</FormControl.Label>

  <TextInput aria-describedby="email-validation-msg" type="email" />

  <FormControl.Validation id="email-validation-msg"> {/* <- this id gets ignored */}
    {error}
  </FormControl.Validation>
</FormControl>

Additionally, I wonder if this is something FormControl could handle by default, so we wouldn’t need to manually connect both components, and Primer Brand could provide an accessible experience out of the box 🤔
Please forgive me if there are other ways to achieve this same accessibility that I’m not aware of but are already supported in Primer Brand!
Reproduction steps
https://codepen.io/sergioalvz/pen/poMarxY
Expected behavior
The FormControl.Validation component does forward the id prop to the actual DOM element.
Screenshots
No response
Browsers
No response
OS
No response

Thanks for this @sergioalvz, great spot!
I think this is related to https://github.com/github/primer/issues/3780, which I'm hoping to get to this week, so hopefully this will be a quick resolution for you 🙂
Ideally, this will be taken care of automatically by the FormControl, but you probably should be able to override the id if you really want to.

@sergioalvz This should be resolved by https://github.com/primer/brand/pull/818
If you include a FormControl.Validation alongside your input inside a FormControl then the aria-describedby will be handled automatically.
This will go out in the next Primer Brand release, let me know if you have any issues or questions 🙂

Thanks, @joshfarrant! That's exciting :-) Do you know when we can expect the next release to happen? 👀


Upgrade Jetty to version 11.0.18

Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

/component-test camel-atmosphere-websocket camel-cometd camel-jetty-common camel-jetty camel-salesforce camel-thymeleaf camel-undertow

/component-test camel-atmosphere-websocket camel-cometd camel-jetty-common camel-jetty camel-thymeleaf camel-undertow

/component-test camel-atmosphere-websocket camel-cometd camel-jetty-common camel-jetty camel-thymeleaf camel-undertow


Tutorials

Added DML tutorial
Removed imports from root init.py

This much of a description of the paper is okay right ?

Don't know why Travis shows issues with black formatting. I've done it locally.

It is failing for another pr as well something is wrong with black.

This much of a description of the paper is okay right ? Then I'll do the rest this way as well

Maybe add the schematic of the algorithm from the paper?

The algo snippet for DML is not complete on its own. It refers to equations from earlier in the paper. What should be done ?
I think this will be the case for other papers as well. Should we avoid putting the schematics in the tutorials ?

The algo snippet for DML is not complete on its own. It refers to equations from earlier in the paper. What should be done ?
I think this will be the case for other papers as well. Should we avoid putting the schematics in the tutorials ?

yea true. Can you a diagrammatic snippet from the paper?

This one in particular?

Hmm, yes, I'll add this one and similar for other algos

Merging


feat: withdraw from v0 to v1

kicker pr

https://github.com/RetricSu/godwoken-kicker/pull/237

Is relevant godwoken/godwoken-scripts changes limited to v0?
If so, maybe it make more sense to test on godwoken v0 push/pr instead of v1?

Is relevant godwoken/godwoken-scripts changes limited to v0?
If so, maybe it make more sense to test on godwoken v0 push/pr instead of v1?

The purpose of this test is to make sure that every v1 changes don't break withdraw from v0 to v1.


Partial loading of .env file on production server

I know this library isn't meant to be used in production, however I've stumbled upon an error that I find very strange and I would like to understand what's going on.
On a production server, when dotenv load method was called many times per second, "sometimes" not all varibles listed in the .env file were loaded. I would get this issue around 1 time out of 1k-10k requests, I didn't measure exactly, but its a relatively small percentage of all requests. Out of ~20 defined vars, I would sometimes get 0 loaded, sometimes half of them, sometimes just one var missing, etc. Like setting environment vars would be at race conditions with the rest of the script.
On a development machine which doesn't have traffic I was unable to reproduce this issue.
Moving environment setup to apache virtual host config fixed the problem immediately.
The server is apache 2.4 with php 7 using mod_php.
I tried Symfony dotenv component and it had the same problem.
Since both symfony and phpdotenv have the same problem, I am guessing this is probably a bug in apache/php.
Is this a known issue?
Is it safe to use this library for CLI / cron scripts in production?

Looks like a duplicate of #248.

Yes, opcache is on in both production and development.
I've read the other issue, but it is still unclear what exactly causes this behavior?

Disabling opcache did not solve the problem.
I also noticed that values returned from getenv() call and $_ENV global can be different. Sometimes getenv() returns false and $_ENV has a proper value, sometimes they are both unset.

My code relies on getenv() everywhere. Here is how I know they are not loaded or partially loaded.
.env:
APP_ENV="prod"
... other vars

script code:
if ( ! getenv('APP_ENV')) {
	$dotenv = new \Symfony\Component\Dotenv\Dotenv();
	$dotenv->load(__DIR__ . '/../../.env');
}

and later:
if (getenv('SOME_VAR_DEFINED_IN_DOTENV') === false) {
     // log return values of getenv() and $_ENV
     // the contents of getenv() and $_ENV vary randomly here
}

I have modified Loader.php as suggested and still get the error.
Also got one interesting scenario:
Script code:
if (!getenv('DATA_DIR')) { // <--- Condition evaluated to true here (DATA_DIR must have been empty)
  $g = print_r(getenv(), true); // <--- DATA_DIR is already defined at this point
  $e = print_r($_ENV, true);
  throw new Exception('Undefined data dir: ' . $g . $e);
}

Dumped exception data:
2018-04-21 20:55:10 [ERROR] Exception: Undefined data dir: Array
(
    [TERM] => xterm
    [SYSTEMCTL_SKIP_REDIRECT] =>
    [LD_LIBRARY_PATH] => /usr/local/apache2/lib
    [PATH] => /sbin:/usr/sbin:/bin:/usr/bin
    [PWD] => /
    [SHLVL] => 1
    [SYSTEMCTL_IGNORE_DEPENDENCIES] =>
    [_] => /usr/local/sbin/httpd
    [APP_ENV] => prod
    [AMAZON_SES_USERNAME] => ***
    [AMAZON_SES_PASSWORD] => ***
    [AMAZON_SES_HOSTNAME] => ***
    [DKIM_SELECTOR] => 20170916
    [SENTRY_DSN] => ***
    [LOCAL_JQUERY] => 0
    [DATA_DIR] => /webdata/
)
Array
(
    [TERM] => xterm
    [SYSTEMCTL_SKIP_REDIRECT] =>
    [LD_LIBRARY_PATH] => /usr/local/apache2/lib
    [PATH] => /sbin:/usr/sbin:/bin:/usr/bin
    [PWD] => /
    [SHLVL] => 1
    [SYSTEMCTL_IGNORE_DEPENDENCIES] =>
    [_] => /usr/local/sbin/httpd
    [APP_ENV] => prod
    [AMAZON_SES_USERNAME] => ***
    [AMAZON_SES_PASSWORD] => ***
    [AMAZON_SES_HOSTNAME] => ***
    [DKIM_SELECTOR] => 20170916
    [SENTRY_DSN] => ***
    [LOCAL_JQUERY] => 0
    [DATA_DIR] => /webdata/
)

Notice how the script checks for existance of DATA_DIR variable. At the moment of check, DATA_DIR is undefined, while in the exception dump (generated next line) it is already defined.

Can you specify which exact version of PHP you are using?

See https://github.com/vlucas/phpdotenv/issues/219 for why this is happening.


Condense tests with pytest parametrize

There's some duplication between tests added in the fix-regrid-cube-name branch. In this PR, I've used pytest parametrize to provide variations of names across test cases, which avoids the duplicated code.
This is a PR-to-PR for metoppv/improver#1761.
Testing:

[x] Ran tests and they passed OK
[x] Added new tests for the new feature(s)

Thanks @tjtg.


[PE-D][Tester A] The title of the application when launching GUI should be the name of the application

Currently the name of the application at the top left corner of the GUI states Address App, which is the same as the original AB3. This can be changed to Supply Central so it's less confusing for the user.

Labels: severity.VeryLow type.FunctionalityBug
original: awdse22/ped#1

Can be fixed

Duplicate of #192

Resolved.


Stop allocating so much

Prototyping period is done. Current API somewhat stable. This is still not high-pri (need to get a few other things in, including tests), but time to stop allocating like crazy in core. If we have to we'll turn the codebase inside out to squeeze out that last drop of frame.

I have a few optimizations locally, especially when endValue returns an array. I'm waiting for #57 to get merged though because I don't want to him to commit suicide after rebasing/merging so many times.

Closing because too general. Will open specific issues if needed.


Deprecate org.gradle.cache.cleanup property

Now that we have this configurable via dsl, we want to remove the magic system property.

Is there a way to deprecate properties? We were the ones that originally added that property, and we're fine with it being removed from newer versions, as long as it doesn't error out if that property exists on newer versions. We need to be able to support both newer and older versions of Gradle on the same system, and since that property only works if its globally set, newer versions of gradle can't error if its found.

#23854

@big-guy That is a problem. Its a global flag, and our builds need to support a mix on both Gradle 7 and Gradle 8. That PR will mean that gradle 8 will always print out a deprecation warning no matter what, with no way to solve it.

I think you might have misunderstood the instructions that PR adds to the upgrade guide.  You can continue to have the property in gradle.properties as long as you also set it via the DSL (either to disable it or to some other value).  This allows you to use the property for older versions of Gradle, but avoid the deprecation warning in Gradle 8.1+.  Does that make sense?
Does that resolve your problem, or am I misunderstanding?

If you have the dsl property, it won't print the deprecation warning even if the property still exists? If thats the case thats good, its just not clear from the PR how that happens.


[minor] add contracts

https://github.com/edenlabllc/ehealth.api/issues/2212

Coverage decreased (-0.4%) to 91.099% when pulling 2fa9ca88cbbdcdddfaddef3d06835fea0131af1c on contract_request_msp_sign#2212 into d6c949a24299eb4c6eaa054c83d1667213ce7f27 on master.


Deprecated the is_training argument in vgg.py.

This fixes #4887.

Can one of the admins verify this patch?

Hi, @jart May you help to review this, thank you in advance.

Actually I think it is actually better to let the is_training argument as part of the network, see
https://github.com/tensorflow/models/tree/master/slim/nets which have unified API and would be merge soon into tf.contrib

Thanks @sguada and @jart I think we should discard this, right?


dotfiles picks the ubuntu init script on SUSE

It shouldn't be picking ubuntu on a SUSE machine; that should only be chosen on ubuntu.
Either the logic to deselect it is flawed, or the logic to detect ubuntu gets a false positive when on SUSE (tumbleweed)

[mjl@hoppy:~]
[16:45]$ is_ubuntu
[mjl@hoppy:~]
[16:45] 1 $

okay, so it's not is_ubuntu's fault.

It correctly picks a suse file (made by touching):
Run the following init scripts?
 ✖  10_osx_xcode.sh
 ✖  20_osx_homebrew.sh
 ✔  20_ubuntu_apt.sh
 ✖  30_osx_homebrew_casks.sh
 ✖  30_osx_homebrew_recipes.sh
 ✔  50_fonts.sh
 ✖  50_node.bug
 ✔  50_python.sh
 ✔  50_vagrant.sh
To edit this list, press any key within 8 seconds.


Statistical Functions(StdevP, StdevPT, VarP, VarPT) implementation.

Implemented some statistical functions in the interpreter and included tests.
Edit: Used Welford's algorithm to implement VarianceAggreator. Is that okay or is there any other specific alg/implementation that is generally used for variance : https://en.wikipedia.org/wiki/Algorithms_for_calculating_variance#Welford's_online_algorithm.
Seems to avoid numerical issues and avoids doing two passes through the data to find the mean of the set first.

StdevP(1,2,3)

fwiw - I double checked that all these new tests do pass on the JS implementation.

Refers to: src/tests/Microsoft.PowerFx.Core.Tests/ExpressionTestCases/StdevP.txt:1 in f194fff. [](commit_id = f194fffcfde8f2b1ca3648a60c2766849da8b781, deletion_comment = False)


fix: remove WorkflowSpec VolumeClaimTemplates patch key

Fixes #11344
Motivation

In the workflow_type.go file, the VolumeClaimTemplates within the WorkflowSpec type was defined as follows:
VolumeClaimTemplates []apiv1.PersistentVolumeClaim `json:"volumeClaimTemplates,omitempty" patchStrategy:"merge" patchMergeKey:"name" protobuf:"bytes,6,opt,name=volumeClaimTemplates"`

However, upon checking the PersistentVolumeClaim type, the type defined under "name" doesn't exist; instead, "name" exists within the "metadata" section.
type PersistentVolumeClaim struct {
	metav1.TypeMeta `json:",inline"`
	// Standard object's metadata.
	// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
	// +optional
	metav1.ObjectMeta `json:"metadata,omitempty" protobuf:"bytes,1,opt,name=metadata"`

	// spec defines the desired characteristics of a volume requested by a pod author.
	// More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#persistentvolumeclaims
	// +optional
	Spec PersistentVolumeClaimSpec `json:"spec,omitempty" protobuf:"bytes,2,opt,name=spec"`

	// status represents the current information/status of a persistent volume claim.
	// Read-only.
	// More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#persistentvolumeclaims
	// +optional
	Status PersistentVolumeClaimStatus `json:"status,omitempty" protobuf:"bytes,3,opt,name=status"`
}

Because of this, when defining VolumeClaimTemplates in the controller config map (workflowDefaults), a continuous does not contain declared merge key: name occurs.
Is there a reason for defining patchStrategy and patchMergeKey in VolumeClaimTemplates?
In my opinion, there's no need to define patchStrategy and patchMergeKey in VolumeClaimTemplates, so I removed that content.
If there's a reason behind it, please provide feedback, and I'll be grateful to make changes using an alternative approach.
Modifications

I removed patchStrategy and patchMergeKey from VolumeClaimTemplates in WorkflowSpec, as shown in the below image.

Verification

stale bot, please wait a moment

Any news here? Expect this from me.

Could you add some tests?

Okay, I'll make it as fast I can.

By the way, before having this feature I my temporary solution is below.
Put a workflow into a ConfigMap. Then create a cronJob which mount a that ConfigMap. Using kubectl apply -f xxx.yaml to create the workflow.

I'm sorry I've been so busy these days that I've been late in writing the test code.
I plan to finish it by at least next week, so please wait a little :)

I add some test code that applied volumeClaimTemplate to workflowDefaults.


Incorrect substitution, hence types, sometimes

We get an error while goal chomping, which comes from incorrect substitution and hence incorrect types. However things work correctly if a similar situation is created from scractch.
The wrong behaviour is as follows.
@ pd.variable
res73: Term = @b

@ pd.value
res74: Typ[Term] = (∏(@b : 𝒰 ){ (Unit → @b) } → @b)

@ pd.value.replace(pd.variable, Unit)
res75: Typ[Term] with Subs[Typ[Term]] = (∏(Unit : 𝒰 ){ (Unit → Unit) } → Unit)

@ pprint.log(pd.value)
cmd76.sc:1 pd.value: FuncTyp(
  dom = PiDefn(
    variable = SymbTyp(name = `@b, level = 0),
    value = FuncTyp(dom = Unit, codom = SymbTyp(name = `@b, level = 0))
  ),
  codom = SymbTyp(name = `@b, level = 0)
)
res76: Typ[Term] = (∏(@b : 𝒰 ){ (Unit → @b) } → @b)

@ pprint.log(pd.variable)
cmd77.sc:1 pd.variable: SymbTyp(name = `@b, level = 0)
res77: Term = @b

In contrast, we have the following correct behaviour.
@ pd.value
res14: Typ[Term] = (∏(B : 𝒰 ){ (Unit → B) } → B)

@ pd.variable
res15: Term = B

@ pd.value.replace(pd.variable, Unit)
res16: Typ[Term] with Subs[Typ[Term]] = (∏(B : 𝒰 ){ (Unit → B) } → Unit)

@ pprint.log(pd.value)
cmd17.sc:1 pd.value: FuncTyp(
  dom = PiDefn(
    variable = SymbTyp(name = `B, level = 0),
    value = FuncTyp(dom = Unit, codom = SymbTyp(name = `B, level = 0))
  ),
  codom = SymbTyp(name = `B, level = 0)
)
res17: Typ[Term] = (∏(B : 𝒰 ){ (Unit → B) } → B)

@ pprint.log(pd.variable)
cmd18.sc:1 pd.variable: SymbTyp(name = `B, level = 0)
res18: Term = B

@ pd.value.dependsOn(pd.variable)
res19: Boolean = true

Leaving aside the mystery of why the cases are different, clearly we must avoid variables in Pi-definitions just as we do in lambda-definitions. Not doing so is giving the error.

The above avoiding var did not fix the bug.

Bug persists (in a slightly different form) but can be replicated locally using the following.
import provingground._ , learning._, interface._, translation._, HoTT._
val A = Type.sym
val B = Type.sym
val f = "f" :: (A ~>: (B ~>: (A ->: B)))
repl.pprinter.bind(translation.FansiShow.fansiPrint)
val fArg = toTyp(f(Unit)(Type)(Star))
val func = f(fArg)(Type)
val arg = "x" :: fArg
import scala.util.Try
val attempt = Try(func(arg))
val fail = attempt.failed.get.asInstanceOf[ApplnFailException]


DEC-685: Showcase order default

ShowcaseQuery will now add a default value for order that is based on the existing showcase orders when calling the build method. This should effectively append any new showcases to the end of the exhibit's list of showcases. Since it's done in the build method, the user has the ability to change it before saving the new showcase.

:+1:

:+1:


feat: respect x-github-token

fixes #98

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

v1.4.0
GitHub release

Your semantic-release bot :package::rocket:


adding template descriptions

Adding template descriptions that can be surfaced in the UX.

:shipit:

@davidebbo: Addressed comments. Can you merge this in? @alrod is waiting on this change.


fixed single quotation marks

Single quotation marks are error in gulpfile.babel.js

Hi,I signed it!

I signed it!

On Nov 5, 2015, at 7:45 PM, googlebot<EMAIL_ADDRESS>wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the company's name.
—
Reply to this email directly or view it on GitHub https://github.com/google/material-design-lite/pull/1846#issuecomment-154038675.

Hey @sxqwaade, thanks for the PR.
However, you are actually making the code not work (did you test it?). There are two kinds of backticks being used here:

The backticks in comments are derived from backticks in markdown to denote a code fragment or file name. Everything that you would expect to be printed like this.
The backticks for strings are actually ES2015 template strings and require the backtick.

Therefore, I’m closing this.


How to use MockTextTerminal

Hi.
Can you please provide some documentation or guidance on how to use the MockTextTerminal?
I would like to unit-test my business logic and the example in the repository with the Robot is not really adequate for unit tests (given the definition of unit test).
Kind regards and thanks in advance.

I put up an example project that shows how to use the MockTextTerminal with JUnit 5.

Hi.
I'm using JUnit 5, but even JUnit 4 is fine if for you is better (I can convert the code accordingly).

Did you see the example project I put up yesterday?

Sorry, I read just the comment about the test framework and I missed the next one ;)
I'll have a look at it.
Thank you.

Hi.
I can confirm the example works, but how to test prompt properties? For example, that a proper color is set?

Hi.
I've just realized I cannot really assert what properties have been set when using executeWithPropertiesConfigurator.
Do you have any way to test this?


install libwx widgets dependencies for observer app

the most popular GUI app based on wx ? and the only one?
for #28; image size increased ~65MB, is it worth it?
REPOSITORY    TAG                   IMAGE ID      CREATED             SIZE
otp           20.0-rc0-cd48b81-wx   f8b3e0fc15dd  49 seconds ago      814.9 MB
otp           20.0-rc0-cd48b81      dbff7d029fed  About an hour ago   749.9 MB

comments are welcome /cc @sdwolf from c0b/docker-elixir#19 @AugustoPedraza

this is a run of observer on a docker container on remote host and X protocol over SSH

I would not worry to much about that extra 65MB since that is the unpacked virtual size. I think people care more about the size of the archive docker pull downloads, which would be less than that and they could use the slim version if they do not want the extra functionality. Also it's normal for it to look like that over X11 forwarding. You have my :+1:.

as technical preview in branch 20 here for discussion some days and then we can merge into 19; generally speaking a service oriented docker image doesn't X applications, and because of distributed Erlang, you may run observer at localhost and connect Erlang on the remote host, but to be developer friendly, this image can also run on docker engine at localhost, and be used at the major observer to connect others in remote


Question - Is there any queueing mechanism to MQTT output interface

Is there any mechanism that prevents the data loss of telemetry that was read from OPC-UA servers when MQTT broker that is set for telemetry to be published to is not available? If there is can you point to the place where I can configure Queue size?
Thank you

Right now the network sink class tries to send a message for "forever".  The queue size for all messages queued for sending can be configured using --om. It already has a pretty large default of 4000 (legacy), which might not be reasonable for constraint setups.  Queue eviction is LIFO.


[UI] Accessibility enhancement of Sidebar Toggle

Current Behavior
The sidebar collapse toggler, as it is right now, proves somewhat inaccessible when the sidebar is open due to it's transparency, making it difficult to distinguish it from the surrounding content.
This can lead to confusion and decreased usability, especially for users with visual impairments or in low-light conditions.

Desired Behavior
The component should have a distinct background color that contrasts with the surrounding content, ensuring it is clearly visible to all users.
Implementation
Setting a more distinguishable background color (probably the bg color of the sidebar?)
Normal state

Hover/Focus state

Acceptance Tests

Mockups

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

This is a valid issue. The proposed solution isn't acceptable, however. @Rexford74, help?

The transparency works well when the tab is flipped on top of the Meshery menu, but you're right, @dragon-slayer875, not when the tab is on top of the rest of the page content.

I agree @leecalcote. That is why I made sure to target code that is active when the sidebar is open.
As soon as Rex provides his suggestions, we can implement them immediately.


Added LetterAnimation

Description
An interactive letter animation layout using HTML, CSS & JS.
Fixes:  #648

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[ x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK
https://tanya-chan.github.io/letter-animation/

@TANYA-CHAN i understand but try to make text in center in small screen and it should not be cut

@arpit456jain please review this PR and merge it.

@arpit456jain Thank you so much, and yes I will keep contributing to this repo :)


Support multiple indexes and binary embeddings

Introduce support for https://github.com/piercefreeman/vectordb-orm/issues/3 and https://github.com/piercefreeman/vectordb-orm/issues/4

Stochastic failing test for binary similar recall, tracking here: https://github.com/milvus-io/pymilvus/issues/1379


e2e: Drop utils NewRandomFedoraVMIWithBlacklistGuestAgent

What this PR does
Get rid of utils NewRandomFedoraVMIWithBlacklistGuestAgent
Use libvmi directly instead.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

None

/sig code-quality

Thanks
Addressed comments (removed the 2nd commit per one of the discussions)


Lazy loading of plugins

I hope that this questions was not asked before. I have a basic use case to lazy load a plugin inside a web client.
The basic loading of plugins works fine:
import MarkdownIt from "markdown-it";
import MarkdownItImageFigures from "markdown-it-image-figures";
var md = new MarkdownIt();
md.use(MarkdownItImageFigures, {
  lazy: true,
  async: true,
  figcaption: "title",
});

However, I want to lazy load a huge footprint plugin like follows, which does not work.
let lazy = async () => {
  let mdHighlightjs = await import("markdown-it-highlightjs");
  md.use(mdHighlightjs());
};
lazy();

I also tried the following:
let lazy = async () => {
  await import("markdown-it-highlightjs").then(plugin) {
    md.use(plugin);
  }
};
lazy();

I hope you have a clear suggestion for me.

Okay, I got it!
await import("markdown-it-highlightjs").then((plugin) => {
  md.use(plugin?.default);
});


Default events since to current time

Closes #13753

makes sense

Not really sure why this test is failing.
Manual testing has this working.

@cpuguy83 Maybe races between times? I have alternative solution, but I like this.

Yeah, probably with until being set from the CLI and since being set to a time after until since it is set on the daemon.
Could instead do a special case for when since == -1.

@cpuguy83 Yeah, maybe just
if since == -1 {
    current = nil
}

Updated with special case for -1

LGTM

LGTM

:+1:  Thanks for this!

Code LGTM.

Pushing to docs-review to clarify @duglin last questions.

LGTM

ping @thaJeztah @moxiegirl so i can cherry-pick ;)

This is fixing a regression in behavior from 1.6, and we were good with the way this was documented in 1.6, so I don't see the docs a "blocking issue" for this to be merged.
However, I agree with @duglin https://github.com/docker/docker/pull/13754#discussion_r31928353 that the current documentation is incomplete and doesn't clearly explain the behavior.
In short, @cpuguy83 if you want to add @duglin's suggestion to the CLI docs and man page, that'd be great, but if this is blocking the release, I'm fine with merging as-is and a follow-up PR to improve the docs.
LGTM, with the notes above

ping @moxiegirl if you agree with https://github.com/docker/docker/pull/13754#issuecomment-110656485

Added minor doc changes.

Thanks @cpuguy83! Ping @thaJeztah @moxiegirl for review.

Thanks @cpuguy83, minor correction, apart from that LGTM

Updated docs.

LGTM, thanks!

LGTM !

cherry-picked

Wow, thanks for the fast turn around time on this guys.  Awesome to see you all cranking through this. :)

Quick question: When are changes that are merged into master built onto https://master.dockerproject.org/?  It looks like it hasn't been updated since the 8th.  Thanks!

they are updated now, cache issue sorry
On Wed, Jun 10, 2015 at 1:17 PM, Michael Barrett<EMAIL_ADDRESS>wrote:

Quick question: When are changes that are merged into master built onto
https://master.dockerproject.org/? It looks like it hasn't been updated
since the 8th. Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/13754#issuecomment-110898291.