Issue: Deployment does not have minimum availability.

I'm trying the sample and create a RedisStreamSource, but I get an error of MinimumReplicasUnavailable . What does it mean? I'm using IKS 1.16.
$ k get redisstreamsource mystream
NAME       SINK                                               AGE       READY     REASON
mystream   http://async-consumer.default.svc.cluster.local/   8m53s     False     MinimumReplicasUnavailable

$ k describe redisstreamsource mystream
Name:         mystream
Namespace:    default
Labels:       <none>
Annotations:  kubectl.kubernetes.io/last-applied-configuration={"apiVersion":"sources.knative.dev/v1alpha1","kind":"RedisStreamSource","metadata":{"annotations":{},"name":"mystream","namespace":"default"},"spec":{"...
API Version:  sources.knative.dev/v1alpha1
Kind:         RedisStreamSource
Metadata:
  Creation Timestamp:  2020-09-02T06:59:38Z
  Generation:          1
  Resource Version:    1839020
  Self Link:           /apis/sources.knative.dev/v1alpha1/namespaces/default/redisstreamsources/mystream
  UID:                 8331b02c-5ccc-44d4-abbe-2b1832b9452e
Spec:
  Address:  redis.redis.svc.cluster.local:6379
  Sink:
    Ref:
      API Version:  v1
      Kind:         Service
      Name:         async-consumer
  Stream:           mystream
Status:
  Group:
  Conditions:
    Last Transition Time:  2020-09-02T06:59:38Z
    Message:               Deployment does not have minimum availability.
    Reason:                MinimumReplicasUnavailable
    Status:                False
    Type:                  Deployed
    Last Transition Time:  2020-09-02T06:59:38Z
    Message:               Deployment does not have minimum availability.
    Reason:                MinimumReplicasUnavailable
    Status:                False
    Type:                  Ready
    Last Transition Time:  2020-09-02T06:59:38Z
    Status:                True
    Type:                  SinkProvided
  Observed Generation:     1
  Sink Uri:                http://async-consumer.default.svc.cluster.local/
Events:                    <none>

$ k get deployment
NAME                                                             READY     UP-TO-DATE   AVAILABLE   AGE
redistreamsource-mystream-8331b02c-5ccc-44d4-abbe-2b1832b9452e   0/1       1            0           2m21s

$ k get deployment redistreamsource-mystream-8331b02c-5ccc-44d4-abbe-2b1832b9452e -o yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "1"
  creationTimestamp: 2020-09-02T06:59:38Z
  generation: 1
  labels:
    eventing.knative.dev/source: redisstream-source-controller
    eventing.knative.dev/sourceName: mystream
  name: redistreamsource-mystream-8331b02c-5ccc-44d4-abbe-2b1832b9452e
  namespace: default
  ownerReferences:
  - apiVersion: sources.knative.dev/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: RedisStreamSource
    name: mystream
    uid: 8331b02c-5ccc-44d4-abbe-2b1832b9452e
  resourceVersion: "1839018"
  selfLink: /apis/apps/v1/namespaces/default/deployments/redistreamsource-mystream-8331b02c-5ccc-44d4-abbe-2b1832b9452e
  uid: b2fda252-2a0e-4af8-82bb-c4a70cc2e0b1
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      eventing.knative.dev/source: redisstream-source-controller
      eventing.knative.dev/sourceName: mystream
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        eventing.knative.dev/source: redisstream-source-controller
        eventing.knative.dev/sourceName: mystream
    spec:
      containers:
      - env:
        - name: STREAM
          value: mystream
        - name: ADDRESS
          value: redis.redis.svc.cluster.local:6379
        - name: K_SINK
          value: http://async-consumer.default.svc.cluster.local/
        - name: NAMESPACE
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.namespace
        - name: NAME
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.name
        - name: METRICS_DOMAIN
          value: knative.dev/eventing
        image: docker.io/daisyycguo/receive_adapter-58ffdc23e8aa937490f9d72cf3d0a33d@sha256:e5a8a1588073c2f7ed989d99595d4b0110b4a5e3448afd2572067a5633746273
        imagePullPolicy: IfNotPresent
        name: receive-adapter
        ports:
        - containerPort: 9090
          name: metrics
          protocol: TCP
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      serviceAccount: redistreamsource-mystream-8331b02c-5ccc-44d4-abbe-2b1832b9452e
      serviceAccountName: redistreamsource-mystream-8331b02c-5ccc-44d4-abbe-2b1832b9452e
      terminationGracePeriodSeconds: 30
status:
  conditions:
  - lastTransitionTime: 2020-09-02T06:59:38Z
    lastUpdateTime: 2020-09-02T06:59:38Z
    message: Deployment does not have minimum availability.
    reason: MinimumReplicasUnavailable
    status: "False"
    type: Available
  - lastTransitionTime: 2020-09-02T06:59:38Z
    lastUpdateTime: 2020-09-02T06:59:38Z
    message: ReplicaSet "redistreamsource-mystream-8331b02c-5ccc-44d4-abbe-2b1832b9452e-75d98cfc7d"
      is progressing.
    reason: ReplicaSetUpdated
    status: "True"
    type: Progressing
  observedGeneration: 1
  replicas: 1
  unavailableReplicas: 1
  updatedReplicas: 1

Hi @daisy-ycguo, most likely the pod crashes, possibly due to mystream not been created in Redis. Can you check the logs? If that's the case, create mystream before creating the source.

Hi @lionelvillard
I think the reason is that redis.redis.svc.cluster.local:6379 doesn't work in my IKS cluster. After I change it to
spec:
  address: "redis.redis.mycluster-dff43bc.sjc03.containers.appdomain.cloud:6379"
  stream: mystream
  sink:
    ref:
      apiVersion: v1
      kind: Service
      name: write-to-db

it works.
$ kubectl get redisstreamsources.sources.knative.dev mystream
NAME       SINK                                            AGE       READY     REASON
mystream   http://write-to-db.default.svc.cluster.local/   70s       True

do you have the Istio cluster-local gateway configured in your cluster?
kubectl get -n istio-system deployments.apps cluster-local-gateway
NAME                    READY   UP-TO-DATE   AVAILABLE   AGE
cluster-local-gateway   1/1     1            1           9d

Yes, I did.
$ kubectl get -n istio-system deployments.apps cluster-local-gateway
NAME                    READY     UP-TO-DATE   AVAILABLE   AGE
cluster-local-gateway   2/2       2            2           23h

I have a redis server in my cluster.
$ k get svc -n redis
NAME      TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)    AGE
redis     ClusterIP   <IP_ADDRESS>   <none>        6379/TCP   18h

I tried to create below RedisStreamResource. It reported "MinimumReplicasUnavailable" error when I called kubectl get redisstreamsources.sources.knative.dev mystream
apiVersion: sources.knative.dev/v1alpha1
kind: RedisStreamSource
metadata:
  name: mystream
spec:
  address: "redis.redis.svc.cluster.local:6379"
  stream: mystream
  sink:
    ref:
      apiVersion: v1
      kind: Service
      name: write-to-db

I tried to create below RedisStreamResource. It reported "MinimumReplicasUnavailable" error when I called kubectl get redisstreamsources.sources.knative.dev mystream
apiVersion: sources.knative.dev/v1alpha1
kind: RedisStreamSource
metadata:
  name: mystream
spec:
  address: "<IP_ADDRESS>:6379"
  stream: mystream
  sink:
    ref:
      apiVersion: v1
      kind: Service
      name: write-to-db

I tried to create below RedisStreamResource. It reported “Ready” when I called kubectl get redisstreamsources.sources.knative.dev mystream. But, the adapter will report "panic: dial tcp <IP_ADDRESS>:6379: connect: connection timed out". I think it is because "redis.redis.mycluster-guoyc-dff43bc8701fcd5837d6de963718ad39-0000.sjc03.containers.appdomain.cloud" is an external domain name but 6379 is a container port.
apiVersion: sources.knative.dev/v1alpha1
kind: RedisStreamSource
metadata:
  name: mystream
spec:
  address: "redis.redis.mycluster-guoyc-dff43bc8701fcd5837d6de963718ad39-0000.sjc03.containers.appdomain.cloud:6379"
  stream: mystream
  sink:
    ref:
      apiVersion: v1
      kind: Service
      name: write-to-db

What shall I do then ?

OK. I think the root cause is that mystream is not created. After I exec kubectl exec -n redis svc/redis redis-cli xadd mystream '*' fruit banana color yellow, it works fine till now.
So it's better to exec a command to create a stream mystream before creating the RedisStreamSource.


debugging widget series errors flutter

while debugging any error occurs, I've to restart, it should be option to execute all f5 actions to skip all those errors at once.

Please file this against the Flutter extension.


Updated docstring links

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
This Pull Request will Fix issue #504 and also I replace all the links in Codebase.
If anything needs to be correct, Let me Know!
Did you have fun?
Yeah, I had fun finding the links in the docstrings and placing them in links.rst.

@XFarooqi pls don't open any more PRs on the same topic

@XFarooqi pls don't open any more PRs on the same topic

I am sorry, I have removed previous ones.


YARN-11547. [Federation] Router Supports Remove individual application records from FederationStateStore.

Description of PR
JIRA: YARN-11547. [Federation] Router Supports Remove individual application records from FederationStateStore.
How was this patch tested?
Add Junit Test.
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 22s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 14s

trunk passed

+1 :green_heart:
compile
1m 40s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 32s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 50s

trunk passed

+1 :green_heart:
mvnsite
1m  0s

trunk passed

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 39s

trunk passed

+1 :green_heart:
shadedclient
20m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 42s

the patch passed

+1 :green_heart:
compile
1m 32s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
1m 32s

the patch passed

+1 :green_heart:
compile
1m 25s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 42s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 4 new + 3 unchanged - 0 fixed = 7 total (was 3)

+1 :green_heart:
mvnsite
0m 47s

the patch passed

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 41s

the patch passed

+1 :green_heart:
shadedclient
21m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 36s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 24s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

101m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6055

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e6244e66c03d 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d2b232f91fe58a9ac1ae7620ad3adc4f4012863a

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/1/testReport/

Max. process+thread count
555 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 38s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m 34s

trunk passed

+1 :green_heart:
compile
2m 38s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
2m 23s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 24s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 28s

trunk passed

+1 :green_heart:
shadedclient
33m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
2m 24s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
2m 24s

the patch passed

+1 :green_heart:
compile
2m 17s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
2m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 11s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 4 new + 3 unchanged - 0 fixed = 7 total (was 3)

+1 :green_heart:
mvnsite
1m  7s

the patch passed

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 31s

the patch passed

+1 :green_heart:
shadedclient
33m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 32s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 32s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

153m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6055

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a365f2609785 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d2b232f91fe58a9ac1ae7620ad3adc4f4012863a

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/2/testReport/

Max. process+thread count
557 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 26s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 27s

trunk passed

+1 :green_heart:
compile
2m 35s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
2m 21s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 24s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 29s

trunk passed

+1 :green_heart:
shadedclient
33m 27s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
33m 51s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 58s

the patch passed

+1 :green_heart:
compile
2m 22s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
2m 22s

the patch passed

+1 :green_heart:
compile
2m 15s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
2m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 13s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 6 new + 3 unchanged - 0 fixed = 9 total (was 3)

+1 :green_heart:
mvnsite
1m  6s

the patch passed

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 29s

the patch passed

+1 :green_heart:
shadedclient
33m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 27s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 32s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

149m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6055

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 270e16f707ac 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 339aa7c85f692336cc7e51051e6070a470106a59

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/3/testReport/

Max. process+thread count
633 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 18s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 18s

trunk passed

+1 :green_heart:
compile
1m 41s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 32s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 50s

trunk passed

+1 :green_heart:
mvnsite
1m  0s

trunk passed

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 41s

trunk passed

+1 :green_heart:
shadedclient
20m 58s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 16s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 42s

the patch passed

+1 :green_heart:
compile
1m 31s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
1m 31s

the patch passed

+1 :green_heart:
compile
1m 25s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m 25s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 42s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 6 new + 3 unchanged - 0 fixed = 9 total (was 3)

+1 :green_heart:
mvnsite
0m 46s

the patch passed

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 40s

the patch passed

+1 :green_heart:
shadedclient
21m  8s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 36s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 23s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

101m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6055

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fc2f0fd8842b 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 010ca8009cc8e29891451ad8b60fb4af8ce3319c

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/5/testReport/

Max. process+thread count
698 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 25s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 17s

trunk passed

+1 :green_heart:
compile
1m 50s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 51s

trunk passed

+1 :green_heart:
mvnsite
1m  0s

trunk passed

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 42s

trunk passed

+1 :green_heart:
shadedclient
20m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 18s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

-1 :x:
compile
1m 34s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
hadoop-yarn-server in the patch failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

-1 :x:
javac
1m 34s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
hadoop-yarn-server in the patch failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

-1 :x:
compile
1m 23s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
javac
1m 23s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 42s

the patch passed

-1 :x:
mvnsite
0m 20s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
spotbugs
0m 19s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

+1 :green_heart:
shadedclient
21m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 38s

hadoop-yarn-server-common in the patch passed.

-1 :x:
unit
0m 22s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

101m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6055

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 233ce95565e8 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b92d9c2cd2c274d7f2c0f6a939bad92fc0b64d17

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/6/testReport/

Max. process+thread count
554 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 50s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m  2s

trunk passed

+1 :green_heart:
compile
1m 39s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 33s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 51s

trunk passed

+1 :green_heart:
mvnsite
1m  0s

trunk passed

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 41s

trunk passed

+1 :green_heart:
shadedclient
22m 21s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
22m 38s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 19s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch failed.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
hadoop-yarn-server in the patch failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
hadoop-yarn-server in the patch failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

-1 :x:
compile
0m 22s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
javac
0m 22s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 44s

the patch passed

-1 :x:
mvnsite
0m 20s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch failed.

-1 :x:
javadoc
0m 19s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
hadoop-yarn-server-common in the patch failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

-1 :x:
javadoc
0m 23s
/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05 with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1 :x:
spotbugs
0m 21s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch failed.

-1 :x:
shadedclient
5m 15s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 21s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch failed.

+1 :green_heart:
unit
0m 17s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 24s

The patch does not generate ASF License warnings.

81m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6055

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8ad04d8398fa 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9c266672b82ee2987e7f176d4f91b63824f96e1b

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/8/testReport/

Max. process+thread count
554 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 18s

trunk passed

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 28s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 27s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 54s

trunk passed

-1 :x:
shadedclient
31m 31s

branch has errors when building and testing our client artifacts.

-0 :warning:
patch
31m 53s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 21s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

-1 :x:
compile
0m 24s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
hadoop-yarn-server-router in the patch failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

-1 :x:
javac
0m 24s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
hadoop-yarn-server-router in the patch failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

-1 :x:
compile
0m 24s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-yarn-server-router in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
javac
0m 24s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-yarn-server-router in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 22s
/buildtool-patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
The patch fails to run checkstyle in hadoop-yarn-server-router

-1 :x:
mvnsite
0m 25s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

-1 :x:
javadoc
0m 24s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-yarn-server-router in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
spotbugs
0m 26s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch failed.

-1 :x:
shadedclient
9m  2s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 24s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

87m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6055

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5d15cb50483c 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 310085b3f42b5bbab11b3405e716d66d1f6fdaea

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/9/testReport/

Max. process+thread count
494 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 34s

trunk passed

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 37s

trunk passed

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  2s

trunk passed

+1 :green_heart:
shadedclient
33m 49s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
34m 12s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 56s

the patch passed

+1 :green_heart:
shadedclient
33m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 32s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

126m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6055

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 3cd0ffff372b 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6e49e6ad1c644c86ad68c0f5f1f53ebbe213e927

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/10/testReport/

Max. process+thread count
674 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  8s

trunk passed

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 28s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 46s

trunk passed

+1 :green_heart:
shadedclient
21m  8s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 25s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 13s

the patch passed

+1 :green_heart:
mvnsite
0m 19s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 40s

the patch passed

+1 :green_heart:
shadedclient
20m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 23s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

84m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6055

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 386309c0bf8f 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ee8af8cc3f28b1553a89e41f7ba6051c289e7440

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/11/testReport/

Max. process+thread count
559 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 11s

trunk passed

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 27s

trunk passed

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 46s

trunk passed

+1 :green_heart:
shadedclient
20m 53s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 11s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 13s

the patch passed

+1 :green_heart:
mvnsite
0m 18s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 40s

the patch passed

+1 :green_heart:
shadedclient
20m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 23s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

84m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6055

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2b3fcb3dd830 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 14675c309afb1cd79a16c0e260237cdd0bce0c6a

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/12/testReport/

Max. process+thread count
676 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6055/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Thank you very much for your help in reviewing the code!


error

Hi,
I am sure that the cuda path is added to bashrc. If i want to check "nvcc --version", it can show me the correct information: Cuda compilation tools, release 8.0, V8.0.61. I am so confused by that and want to know how to solve it.
Thanks,
Peter
python setup.py build_ext --inplace
running build_ext
skipping 'utils/bbox.c' Cython extension (up-to-date)
skipping 'utils/nms.c' Cython extension (up-to-date)
skipping 'nms/cpu_nms.c' Cython extension (up-to-date)
skipping 'nms/gpu_nms.cpp' Cython extension (up-to-date)
rm -rf build
bash make.sh
make.sh: line 13: nvcc: command not found
g++: error: roi_pooling_op.cu.o: No such file or directory

same question, any help?

i have the same question...,anyone help?

python setup.py build_ext --inplace
running build_ext
skipping 'utils/bbox.c' Cython extension (up-to-date)
skipping 'utils/nms.c' Cython extension (up-to-date)
skipping 'nms/cpu_nms.c' Cython extension (up-to-date)
rm -rf build
bash make.sh
@gbc8181  @yangzhibo0212
import tensorflow aas tf
tf.test.is_gpu_available()
test is not successful?


Request is not retried on timeout using requestTimeout and retries

Environment details

OS: alpine linux 3.14
PHP version: 8.1
Package name and version: google/cloud-pubsub v1.35

Overview
Requests are not retried if the requestTimeout is reached. I checked the source code and found inside the RetryDeciderTrait.php only these http codes are retried:
private $httpRetryCodes = [
    500,
    502,
    503
];

There seems to be no way to override this, I also need to retry when the timeout is reached.
Steps to reproduce
Run below snipped with a slow internet connection, request times out after 1 second and is not retried.
Code example
return new PubSubClient([
    'retries' => 3,
    'requestTimeout' => 1
]);

Hi @dwsupplee
Thanks for investigating this issue. Is there some workaround for this currently? Thanks

You can set which http status codes to retry by calling setHttpRetryCodes.
https://github.com/googleapis/google-cloud-php/blob/3095675fc315bc75ba1daf7b1dc805c233fb083a/Core/src/RetryDeciderTrait.php#L101
If PubSubClient works anything like Google Cloud Storage's StorageClient class, you would need to use your own class that uses this trait, set your desired http codes and call and pass the trait's getRetryFunction() return value into your PubSubClient's constructor config array under the key "restRetryFunction"
Related to retrying, what I'm curious about though is how to retry curl errors, because I've been seeing a lot of curl 18 errors when reading files from Google Cloud Storage.

Hi @bernardwiesner
Thanks for filling the issue.
Apologies for the delay in response.
One way to think about could be to take control of how you want to retry instead of just overriding the error codes.
In this case, you could use the configuration option restRetryFunction that decides whether an operation should be retried or not.
So, something like this could be customised as per your need:
$client = new PubSubClient([
    'retries' => 3,
    'requestTimeout' => 1,
    'restRetryFunction' => function ($ex, $attempt) {
        // $ex is the exception object
        // $attempt is the retry attempt
        $statusCode = $ex->getCode();

        $httpRetryCodes = []; // your list of retry codes

        if (in_array($statusCode, $httpRetryCodes)) {
            return true;
        }

        return false;
    }
]);

You could even check for the type of exception etc.
Hope this helps your use case.


Nil hourly cost immunity

One small question and then :+1:

What is more are you able to squash these 6 commits into one?


data link for MEM vignette

Hi @zkamvar!
I think I updated correctly. I modified the link ("new hyperlink - download data") so that right clicking downloads the csv file (the first change was not correct).
Thanks for your help! 😃

Looks good to me! Now we need approval from one more maintainer. @smanel, @hlapp?
Sent from my iPhone

On Oct 21, 2017, at 11:22, Brenna Forester<EMAIL_ADDRESS>wrote:
Hi @zkamvar!
I think I updated correctly. I modified the link ("new hyperlink - download data") so that right clicking downloads the csv file (the first change was not correct).
Thanks for your help! 😃
You can view, comment on, or merge this pull request online at:
https://github.com/NESCent/popgenInfo/pull/202
Commit Summary
add hyperlink to data file
new hyperlink - download data
File Changes
M use/2016-12-13_MEM_outlier.Rmd (2)
Patch Links:
https://github.com/NESCent/popgenInfo/pull/202.patch
https://github.com/NESCent/popgenInfo/pull/202.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Looks good to me too. Squash and merge, I assume? Or keep each commit?

I vote for squash
Sent from my iPhone

On Oct 21, 2017, at 16:26, Hilmar Lapp<EMAIL_ADDRESS>wrote:
Looks good to me too. Squash and merge, I assume? Or keep each commit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks @zkamvar and @hlapp !


Add support for react context element types, fixes #1509

There are some outstanding support concerns here with shallow rendered per https://github.com/facebook/react/issues/12152 but i wasn't attempting to fix those here. This just adds support for traversal over said elements. I was not sure how to structure the peer deps in a way that would exercise this test as well...
cc @aweary

This might be better as a new adapter like ReactSixteenThreeAdapter, since it's a new API and 16.2 and earlier don't have it. It will possibly depend on how context is supported in the new shallow renderer as well.

my thought was that it'd reduce some churn for folks since it's not a breaking change but that might go out the window for handling context only using hte new API. In which case it may be easier to make a new one...Idk

Yeah, I think reducing churn is good concern. There is precedence for creating a new adapter for a minor release (ReactFifteenFourAdapter), but to be fair that split was around before we required people to explicitly configure an adapter. I just think if we're going to traversing the new context elements, we should also support actually using the new context API, so it might be best to hold off until we figure out what that'll look like.

we should also support actually using the new context API, so it might be best to hold off until we figure out what that'll look like.

definately agree on supporting hte new context, but most of that change is gonna be internal ReactWrapper stuff. It'd be nice to at least not have tests break for folks who start using the context api in their own code. I mean if we can do it at the same time great, but i'm not confident in my ability to tackle it so idk

I guess my concern is that if context doesn't actually work at all, maybe it should break? I don't want anyone to assume because it renders the providers/consumers without failing that that means the adapter supports them. I also think it should fail if you try to use it with React <=16.2, which is why I'm leaning towards a separate adapter. We didn't do that with fragments though AFAIK, so maybe it's not a big deal.
I haven't been paying a lot of attention to what's been happening with Enzyme, @ljharb can you chime in here?

I think there are two concerns here. The first, being enzyme should work in react trees that use createContext, and the second is that internally Enzyme mount() and shallow should handle their context options with the new APi since it'll break when the old on is removed.

I guess my concern is that if context doesn't actually work at all

So this isn't the case, if a user renders a Provider/Consumer it'll work, and internally if passed context it'll also work but use the old api.
Ultimately tho I think Enzyme even needs a context option (depending on shallow renderer) since its straightforward to do in a test manually now, e.g. <Provider><Root></Provider> that and there is probably no way to make the enzyme api work without a breaking change since you can't arbitrarily pass context anymore, you must have the paired Consumer to access it.

I think there are two concerns here. The first, being enzyme should work in react trees that use createContext, and the second is that internally Enzyme mount() and shallow should handle their context options with the new API since it'll break when the old on is removed.

Right, I'm suggesting that if one works the other should probably work as well. Mostly because people will probably be rendering a lot of consumers without providers.

So this isn't the case, if a user renders a Provider/Consumer it'll work, and internally if passed context it'll also work but use the old api.

So my worry is related to the second concern you mentioned, specifically users thinking that Enzyme's API for providing context to a tree will work rendering standalone consumers. I'm assuming this would not work:
const Button = ({ label }) => (
  <ThemeConsumer>
    {theme => <button style={theme.button}>{label}</button>}
  </ThemeConsumer>
)

and they try to pass it context via mount's option like:
const theme = {
  button: { fontSize: 15 }
}
const root = mount(<Button label="foo">, { context:  { theme }  })

Ultimately tho I think Enzyme even needs a context option (depending on shallow renderer) since its straightforward to do in a test manually now, e.g.  that and there is probably no way to make the enzyme api work without a breaking change since you can't arbitrarily pass context anymore, you must have the paired Consumer to access it.

The one thing that sucks about requiring that consumers always exist inside a provider is that with shallow you'll always have to use dive to get to the actual rendered component(s). It's the same problem we have now with shallow rendering trees with react-redux providers and other similar APIs, but at least with the existing context API you can side-step the issue and pass the store or whatever into the context option.

The one thing that sucks about requiring that consumers always exist inside a provider

is this the case? That will break so much of my context code...

is this the case? That will break so much of my context code...

Not in the general case. It will just use the default value provided to createContext. I mean in the context (no pun intended 😄) of testing components in isolation; you'll probably want to test that Button with something other than the default value in some cases, and requiring a Provider to do that might not be the best solution.
That's why mount and shallow have the context option, so you don't have to wrap your components in actual context providers.

Phew! :P

That's why mount and shallow have the context option, so you don't have to wrap your components in actual context providers.

definitely, I was thinking though that the new API can't work like this, the user will at the least have to provide Enzyme with the provider since it can't take a plain object and send to the correct consumers. AT the very least the API will change to passing a Provider to context: in which case i might be simpler to just have the user use the provider.

Hi there! Any news on that?

I updated, let me know if there is anything i can do here :) I'd love to see this a release, we're already playing with react 16.3.0 and the context api and it's killing our tests :P

oops sorry shallow tests are wrong, one sec

Hey, guys. Is there any reason to not merge this?

Nope

Thanks y'all

Any news on when this will get released?

When I run the test suite I'm seeing a warning:
Warning: Failed prop type: Invalid prop `Component` supplied to `WrapperComponent`.
    in WrapperComponent
        ✓ should find elements through Context elements

If I copy the test into my environment I'm actually seeing an exception thrown. Is this an issue to be addressed separately? Can I prevent it from failing in my environment?
    Expected the function not to throw an error.
    Instead, it threw:
      Failed prop type: Invalid prop `Component` supplied to `WrapperComponent`.
        in WrapperComponent

Thanks!

@ljharb any update on when a release for this will happen? we've migrated our codebase to the new Context API in React 16.3 and this bug is causing our tests to fail so just waiting on a release. Thanks 😄

@baldwmic to overcome this, we are using a simplified version of jamiebuilds/create-react-context polyfill. Copy this file into your project and and a reference to it in package.json under jest.setupFiles. Note that you'll need to provide a 3rd argument to all calls to createContext. If you're using flow, you'll also have to modify the type signature of createContext, type definitions are included in the gist.

@Dremora thanks so much for the tip! My team doesn't want to change our configuration and dependencies for a short amount of time only to change it back once the official release occurs, but it's definitely nice to know a workaround exists.

@ljharb do you have any update on a release cut? Another poor soul is struggling hard to work around 😢

@ljharb

There’s a few more issues i want to iron out before cutting a release; hopefully

Why can't you just release current master (or merge this onto previous release if master contains bugs)?

Same here, we had to disable tests for parts of the code that uses new Context API :(

Guys, release this pls

😢 😿 😭

Any update on when this is gonna be released?

While you are waiting for the release you can install the enzyme-adapter-react-16 package that we forked here.
We tried to install enzyme directly from github but it didn't work, so we just took the react 16 adapter package with @jquense changes, made a couple of small changes (babel was out of date and not able to build). Further there was an issue importing a function from enzyme-adapter-utlisso we just add that directly into the adapter code.
The build is available on github as well, so you can just clone it from our repo.

Do I have to beg?  I'm not above begging.  PLEASE release this soon.  We have a whole suite of tests that we have disabled now because of this issue.

This is truly incredible. The single most important tool for testing React, does not keep up to date with the latest React version - for a matter of months not days.

Well... Since no one cares i've ended up publishing latest code changes for myself. I'll use my own packages until official release. I've also made them public in case anyone else wants to use.
Install
npm i @pisano/enzyme @pisano/enzyme-adapter-react-16

Use
import Enzyme, { shallow, mount } from '@pisano/enzyme';

import React16Adapter from '@pisano/enzyme-adapter-react-16';

Enzyme.configure({
  adapter: new React16Adapter()
});

Note: I didnt change any code. Only pulled and published master. The repo is here.

@ramesaliyev see above, @KrustyC already did

@davidfloegel yeah i saw that but i dont like using git repos as npm modules, maybe this is okay today but in the past it causes trouble because of the npm bugs.

@ljharb @aweary @jquense can you please release a new version of Enzyme with this fix? It's becoming difficult for many users of enzyme (as you can see above) to upgrade to the new version of React since we are waiting on this fix for our tests to pass.
Or at the very least, it would be nice to know a timeline on when a new release can be expected. Of course, thank you for all your work giving to the open source community 😄

i cannot release anything i'm not a maintainer

I also don't have publish rights on npm. Someone from Airbnb will need to publish a release.

This is blocking Formik from going to 16.3. Would love to see a release tomorrow.

This was taking a long time to land, so for the meantime I've published a package which patches enzyme in the postinstall hook, using the patch from @lucasconstantino above.
Repo: https://github.com/KevinGrandon/enzyme-react-16-context-patch
NPM package: https://www.npmjs.com/package/enzyme-context-patch
We wanted a small temporary and encapsulated package that we could install, simply uninstall once this code lands. Hopefully it won't take too much longer 😅

Any news guys?

Last publish 5 months ago, would love to see this fix released

Thank you @lucasconstantino and @KevinGrandon for sharing the alternative approach of patching the fix. I am having success with this approach and it means we don't have to switch to a fork! 😄
Unfortunately, I couldn't use your package @KevinGrandon because we use yarn workspaces, and the postinstall script doesn't run for us, but I've figured out how to do it. Thanks for sharing.

Do we have to wait for the next release until all issues related React v16 have been resolved?

https://gitter.im/airbnb/enzyme?at=5aec95d540f24c4304524d83
https://github.com/airbnb/enzyme/issues/1553

Whats the policy on releasing updates to enzyme?
It seems strange that master is so widely out of date with what is published on npm.

@ljharb Thank you so much for taking the time to explain! 😄
Strategically, that makes sense a lot of sense why you have delayed in publishing. It's too bad others can't take some of the work of enzyme off your plate to allow progress to continue for the benefit of the community. I am sure there's a lot of context I'm missing, since I don't work at Airbnb so don't worry about my pondering...
I want to be clear that I am extremely grateful for the work you do. I think being an open source maintainer is an often thankless job, and I hope I didn't contribute in some way to your personal stress. If anything, the number of comments requesting a release on this pull request show how impactful Enzyme has been on the React testing community! Great work and thanks again! ❤

Cool, thanks for the update, @ljharb ! ❤

@ljharb when you get this release in can you also add support for React.forwardRef ? I used the patch described above but still have the issue referenced here https://github.com/airbnb/enzyme/issues/1604

Any chance for a pre-release? I think the expectation there is that pre-releases are unstable and folks should be willing to see bugs. Hopefully that should address the concern of new bug reports? Could even update the bug report template to reflect this as well, hopefully resulting in less noise.

I'd happily try out an alpha pre-release with the React 16.3 handling implemented so far. Like the Babel 7 beta.
I really think it would be a good idea to officially release what has been done so far as an alpha because unlike other packages, the monorepo pattern used in enzyme means that it's not possible to use a git+ dependency to get the latest in-development version.

now seems the same problem with the React-16.4

@baldwmic you said:

Unfortunately, I couldn't use your package KevinGrandon because we use yarn workspaces, and the postinstall script doesn't run for us, but I've figured out how to do it. Thanks for sharing.

Would you be kind enough to explain how you got things working with yarn workspaces?

@jcready I tried looking into why post install script wasn't working, but it was becoming a time sink
Instead, since my team used a Makefile, I just wrote a command to patch the file from KevinGrandon's repo. So I didn't really solve it, but got around it.
You might be able to get around it by writing your own npm script to patch the file if you don't use Make. Maybe do your own postinstall.
I don't have access to the private repo anymore but hope that helps!

There is an issue with current implementation of the context in enzyme
  console.error node_modules/fbjs/lib/warning.js:33
    Warning: Detected multiple renderers concurrently rendering the same context provider. This is currently unsupported.

https://github.com/stereobooster/react-context-issue
and
https://github.com/stereobooster/react-context-issue/tree/enzyme-react-adapter-future

@stereobooster would you mind filing a new issue about that?

@KevinGrandon Thanks for building that package. Could you confirm if your package actually should support the new context features or if it just allows components using it to be mounted? (It definitely lets my components mount where they wouldn't before, but context doesn't seem to be passed 😕 )

@KevinGrandon Thanks for building that package. Could you confirm if your package actually should support the new context features or if it just allows components using it to be mounted? (It definitely lets my components mount where they wouldn't before, but context doesn't seem to be passed 😕 )

Weird, I would think that it should work, but I didn't do the initial implementation. If you have a PR/patch I'm happy to try to include it in the package fork. Unfortunately not much time to investigate this further at the moment.

@ljharb The test case I can be found in this test for a project I've been working on: https://github.com/draperd/react-forms-processor/blob/master/packages/core/src/renderer.test.js#L61 (the commented line should pass but is failing with undefined rather than an empty object which should be provided from the context)
I'm not entirely sure how I'd create a PR for a test without pulling in my entire library?

@draperd thanks - the hope would be that you could construct a minimal test case that doesn't require your whole library :-) https://github.com/draperd/react-forms-processor/blob/master/packages/core/src/components/Button.js is relatively small, so perhaps you could condense that along with a test into a single post? If you don't have time, or aren't willing, to make a PR, then filing a new issue with that minimal test case would also be super helpful <3

The following packages are now released:

enzyme v3.4.0
enzyme-adapter-react-16 v1.2.0
enzyme-adapter-react-16.3 v1.0.0
enzyme-adapter-react-16.2 v1.0.0
enzyme-adapter-react-16.1 v1.0.0
enzyme-adapter-react-15 v1.0.6
enzyme-adapter-react-15.4 v1.0.6
enzyme-adapter-react-14 v1.0.6
enzyme-adapter-react-13 v1.0.4
enzyme-adapter-utils v1.5.0

Thank you so much! Could you add this to the changelog? I couldn't found this issue. Thanks

Ah, I see. Thank you!

https://github.com/airbnb/enzyme/issues/1647 is still broken it seems.

@MartinDawson yes, that's why it's still open.

How am I supposed to use this? I upgraded both enzyme and enzyme-adapter-react-16 to latest versions, I try to shallow with context in the options and it still doesn't work for me. Couldn't find any instructions either.

@belfz  this change adds support for rendering trees with the new Context elements, it doesn't change the API for setting context on mount, that is still old style contex. If you want to mount a component with some context, render it with the ContextProvider and a value. That said the new Context is not supported for shallow rendering, the React team has not decided to support that use case, it will work for mount tho

enzyme, however, will support that use case - it just doesn’t yet.

Thank you!

@jquense - Enzyme's old style context isn't working for me with React 16's new Context... This is the code I have...
package.json
    "react": "^16.5.0",
    "enzyme": "^3.6.0",
    "enzyme-adapter-react-16": "^1.5.0",

Error.js
export default class Error extends Component {
  render() {
    return (
      <AppConsumer>
        {context => {
          return (

Error

{context.error}

          );
        }}
      </AppConsumer>
    );
  }
}

Error.test.js
const mountComponent = () => {
  const context = { error: 'foo' };
  element = mount(<Error />, { context });
  console.log(element.html());
  console.log(element.text());
};

describe('<Error />', () => {
  describe("AppContext's Error is displayed", () => {
    it('Given Error component is rendered', () => {
      mountComponent();
      element.setContext({ error: 'bar' });
      console.log(element.html());
      console.log(element.text());
    });
    it('Expect error display to be error passed in from context', () => {
      expect(element.text()).to.contain('bar');
    });
  });
});

The context never gets set for me. Is the above correct?
@belfz - did the old style context work for you?

@James-Ga11agher that won't work you can use old style context with new context. they aren't compatible apis.

@jquense - sorry, not following, "you can use old style context with new context. they aren't compatible apis."
Does Enzyme support React 16's new Context? Is there an example of this? On my search for this, this was the most promising posting.

The Enzyme API's for setting context are only for old style context, they don't work for the new context api. if you want to set context for a tree using the new context API, render the Provider as part of the test. e.g.
mount(<AppProvider><Error/></AppProvider>)

Ah I get you now, thank you so much 👍 Really appreciate the help 👍  In case anyone else has the same issue as me, working code below
const mountComponent = errorMessage => {
  element = mount(
    <AppProvider value={{ error: errorMessage }}>
      <Error />
    </AppProvider>,
  );
};

describe('<Error />', () => {
  it('renders without crashing', () => {
    mountComponent();
  });

  describe("AppContext's Error is displayed", () => {
    it('Given Error component is rendered', () => {
      mountComponent(errorMessage);
    });
    it('Expect error display to be error passed in from context', () => {
      expect(element.html()).toContain(errorMessage);
    });
  });
});

@James-Ga11agher no, enzyme does not yet support new-style context, see #1553. This PR is only one piece of it.

Following up on the above comments about the existing context option in mount() and shallow(), I'm wondering if it will ever be possible to achieve a similar result using the new context API. I am currently in the process of setting up a theme for the styled-components in the app I'm working on. This is requiring updates to almost every test case that uses mount(), because either the component directly uses styled-components that need theme properties, or it uses the theme indirectly via a separate npm package with our shared UI components (also styled-components). So for every test where we could previously do something like this:
const component = mount(<CreatorSummary creator={mockCreator} />)
...
expect(component.state().open).toBe(true)

We would now have to do this:
const component = mount(<ThemeProvider theme={theme}><CreatorSummary creator={mockCreator} /></ThemeProvider>)
...
expect(component.find(CreatorSummary).instance().state.open).toBe(true)

...and this is just the tip of the iceburg -- the tests are already written so there is a lot of such code that would need to be updated.
With the current API, I was able to set up helper functions, e.g. mountWithTheme(), that use enzyme's context and childContextTypes options, as explained [here])(https://github.com/styled-components/jest-styled-components/issues/61#issuecomment-421043968) - which is obviously a much more convenient solution, and IMO a more elegant one too.
But soon we will be upgrading to styled-components 4 (currently in beta), which uses the new context API. So far the best solution I've been able to come up with for the new version is this hack that overrides one of styled-component's internal methods, which obviously isn't ideal:
...
import * as theme from './theme'

function setupMockTheme() {
    const result = enzyme.mount(React.createElement(styled.div``))
    const BaseStyledComponent = result.childAt(0).type()

    BaseStyledComponent.prototype.renderOuter = function renderOuter(styleSheet) {
        this.styleSheet = styleSheet
        return this.renderInner(theme)
    }
}

Would it somehow be possible to add an option to enzyme so context properties could still be passed as an option to mount() and shallow() in a way that would work with the new context API? I realize the new context API works quite differently...any thoughts or suggestions are welcome. As an alternative, it might be helpful if it were possible to call methods like state() on non-root nodes (so tests wrapped with Provider components could still be written in a similar way), but that seems to be an inherent and deliberate limitation of enzyme...

See #1802, for setting state.
It may indeed be possible; i can’t know until i build support for new context.
My advice would be not to update to something that used new context until you’re able to test it properly :-)

@ljharb Oh, I thought the new context support was mostly done already (I was looking at #1553, where only the issue about dive() not working is still open). Good to know there will be more robust support for it in the future.
Regarding state() and setState() and #1802, this is great. Are there any plans to allow other methods like props(), prop(), and setProps() to work on child nodes as well?

props and prop should already work on anything; setProps is a bit different since the child's parent controls what props it gets - i'm not sure it makes sense to allow that. Either way, let's discuss this in a new issue, since it's all off topic for this PR.


Script to build phar library

For releases, probably we need to do also something like:
https://github.com/composer/composer/blob/master/.travis.yml#L64-L72
and would be nice to have also check in travis for if build is correct:
https://github.com/squizlabs/PHP_CodeSniffer/blob/master/.travis.yml#L44-L45

This is an awesome idea, but to make usage of a PHAR secure, we need to sign it and distribute a signature as well... which is non-trivial (I know, as I've done it in the past, and setting up the toolchain is ridiculous (see my writeup), even without doing rollback and self-update automation.
We can discuss after the initial release; usage of composer is easier initially and reasonably secure as developers can compare the installed sources with the github repo.

This repository has been closed and moved to mezzio/mezzio-migration; a new issue has been opened at https://github.com/mezzio/mezzio-migration/issues/4.

This repository has been moved to mezzio/mezzio-migration. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

Squash all commits in your branch (git rebase -i origin/{branch})
Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
Run the laminas/laminas-migration tool on the code.
Clone mezzio/mezzio-migration to another directory.
Copy the files from the second bullet point to the clone of mezzio/mezzio-migration.
In your clone of mezzio/mezzio-migration, commit the files, push to your fork, and open the new PR.
We will be providing tooling via laminas/laminas-migration soon to help  automate the process.


docs: fix vstest markdown headings

Github doesn't render # headings that touch the text anymore. There was also a jump from H1 to H3

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@nschonni, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

take or close


fix: 修复参数化数据驱动 初始化参数时自定义插件函数无效的问题

修复使用参数化驱动时自定义插件的函数未初始化的问题；issue链接为： #1467

Codecov Report
Patch coverage: 100.00% and project coverage change: -9.43 :warning:

Comparison is base (6600473) 49.69% compared to head (b2f0b6e) 40.26%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
- Coverage   49.69%   40.26%   -9.43%
==========================================
  Files          92       59      -33
  Lines       13232     9807    -3425
==========================================
- Hits         6575     3949    -2626
+ Misses       6323     5524     -799
  Partials      334      334

Flag
Coverage Δ

unittests
40.26% <100.00%> (-9.43%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

hrp/parameters.go
86.20% <100.00%> (+0.18%)
:arrow_up:

hrp/runner.go
58.22% <100.00%> (ø)

... and 34 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@sweetWang1 我优化了下实现，减少了 parser 参数传递。
https://github.com/httprunner/httprunner/commit/6ca9c5236be9f352b7c5373a319400946ac3b661


feat: add nimbus-eth1

This feature still does not work:
  nimbus_eth1: cat /data/nimbus_eth1/keystore/nodekey

Lets merge this pr once https://github.com/status-im/nimbus-eth1/issues/2767 is resolved.


Improve path query: autodetect only if the target exists

Detect path parts of a query with PathQuery.is_path_query() which tests for os.sep presence AND query part existence.
Also fix a bug where "my_path/" would not get detected: colon absence would make search for os.sep only happen in "my_path".
Fix #1385.

Looks ideal! I'll merge this now.

One small casualty of this change: you can no longer use beet rm /path/to/file.mp3 to remove dangling database entries. Probably not a big deal, but the standard advice should now be to use an explicit path: query for that.


Add host port for Visualization and documentation

Add a host port so that you do not have to overwrite the Synthea-based
display to get the FHIR data.
Update the documentation to provide the latest link.

Hi @shabiel,
The docker image was not updated. It has no so please try it again.
On 10/30/2019 2:42 PM, Sam Habiel wrote:

@shabiel requested changes on this pull request.
Synthea Visualizer does not show the boxes for URL/port.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OSEHRA/synthea-compose/pull/2?email_source=notifications&email_token=AAEELGRS2OJ6F3XWPL6MDYDQRHISVA5CNFSM4JGORPLKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJY2VZA#pullrequestreview-309439204,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEELGWJJQ2DSP5XQI3XQWLQRHISVANCNFSM4JGORPLA.

--
Joseph Snyder
Senior R&D Engineer
Kitware, Inc.
1712 Route 9, Suite 300
Clifton Park, NY 12065
(518) 881-4409

It works!


Add more info about hactoberfest in readme.md

Add more info about hactoberfest in the readme.md
fix other details and make it look more eye appealing

hey @rhvsingh please assign this task to me

hey @rhvsingh please assign this task to me

Yeah sure @yogesh-9999

@yogesh-9999 Nice work


Cannot delete spatial coverage from a resource when it is a box coverage

Once a spatial coverage for a resource is set to a box, it cannot be deleted. This is problematic as the spatial coverage gets automatically set when some types of aggregations are added to a resource, but the user may intentionally NOT want to have a spatial or temporal coverage. I tried going into edit mode and just deleting the box/point coordinates, but HydroShare throws an error when I click the "save" button indicating that the metadata element cannot be updated.
Oddly, when I change the box coverage to a point coverage and refresh the page, a garbage can icon appears that allows me to delete the spatial coverage.  The same garbage can icon needs to be added to enable deleting spatial coverage when it is a box coverage.

Related to https://github.com/hydroshare/hydroshare/issues/4009

Related to https://github.com/hydroshare/hydroshare/issues/4009

@horsburgh
Hi, I am trying to fix this issue. Can you point to a resource that I can use to reproduce the issue?
Thanks!

Hi @soumyapurohit - here's some steps to reproduce this. You can just create a new resource that will show this:

Create a new resource
Set the spatial coverage by clicking on the box icon at the top of the google map and drawing a box coverage.
Click the "Save Changes" button to apply the spatial coverage
Exit edit view by clicking the view resource button at the top of the page (left pointing arrow button)
Click on the edit resource button (the pencil)
Delete the latitude and longitude values from the text boxes
Click the "Save Changes" button
HydroShare throws an error that says "Error! Metadata failed to update.

I see that @cuahsimarko just mentioned this in #4009