Amplify push shows "Error updating cloudformation stack" without specifying the error

Describe the bug
I have a stack on Amplify CLI and recently after updating to 4.38.X & 4.39.0, when I'm pushing directly or building it through Amplify Console, it shows these lines:
Updating resources in the cloud. This may take a few minutes...Error updating cloudformation stack
✔ All resources are updated in the cloud

Although it says that the build was successful, there are some errors and the backend environment doesn't get updated and since there's no error message, I have a really hard time finding the problem.
I even tried --verbose but no luck, so I have to read through my whole backend-config and cloudformations and kind of guess my error.
Amplify CLI Version
4.38.X to 4.39.0
To Reproduce
I'm not sure if it's happening to anyone else or not, but if your stack has some errors, it won't get updated since 4.38.X version, but you see the successful message. So you should check the last update date on Amplify Console Backend environment, if you're using it to make sure that your backend environment is really up to date.
Expected behavior
It must shows errors like it used to!
Screenshots

Desktop (please complete the following information):

OS: Mac
Node Version: v14.15.0

Additional context
I have already attached an screenshot of Amplify Console, the same thing happens when I push locally except the log is not disfigured like the picture.

@BardiaN Can you try looking at where it failing in the cloudformation console?

I have the same issue, and there is no error in the Cloud Formation console. I just have the amplify root stack with no nested stack created at all.

Don't know if this will help at all but I got same error and discovered if I run amplify build function before push my cloud formation error went away

Having the same issue after updating to 4.39.0 Nothing showing up on Cloudformation to help debug what the problem is, no new events are being recorded by the console, so I guess Amplify is not reaching it when I push.

Same issue here

I resolved this by using the default/suggested function name instead of the custom name I'd supplied which contained a hyphen.

@davegravy I confirm I have some custom cloud formation templates which I renamed to mycategory-cloudformation-template.json. So it may be the cause as well for me

Pretty sure this is an AmplifyCLI issue. Even though the CLI standard output was silent on the issue, I found the following in amplify/logs/:
2020-12-13T17:38:32.414Z|error : amplify-provider-awscloudformation.push-resources.updateCloudFormationNestedStack(["/home/davidg/xxxxxxxxxx/amplify/b$ValidationError: Template format error: Resource name function xxxxxxxxxx-xxx-xxxxxxxx is non alphanumeric.

Pretty sure this is an AmplifyCLI issue. Even though the CLI standard output was silent on the issue, I found the following in amplify/logs/:

2020-12-13T17:38:32.414Z|error : amplify-provider-awscloudformation.push-resources.updateCloudFormationNestedStack(["/home/davidg/xxxxxxxxxx/amplify/b$ValidationError: Template format error: Resource name function xxxxxxxxxx-xxx-xxxxxxxx is non alphanumeric.

Where did you find that directory with logs?

The same problem with creating policy.

Pretty sure this is an AmplifyCLI issue. Even though the CLI standard output was silent on the issue, I found the following in amplify/logs/:

2020-12-13T17:38:32.414Z|error : amplify-provider-awscloudformation.push-resources.updateCloudFormationNestedStack(["/home/davidg/xxxxxxxxxx/amplify/b$ValidationError: Template format error: Resource name function xxxxxxxxxx-xxx-xxxxxxxx is non alphanumeric.

Where did you find that directory with logs?

my-project-root/amplify/logs
FYI I'm on v4.39.0

Pretty sure this is an AmplifyCLI issue. Even though the CLI standard output was silent on the issue, I found the following in amplify/logs/:

2020-12-13T17:38:32.414Z|error : amplify-provider-awscloudformation.push-resources.updateCloudFormationNestedStack(["/home/davidg/xxxxxxxxxx/amplify/b$ValidationError: Template format error: Resource name function xxxxxxxxxx-xxx-xxxxxxxx is non alphanumeric.

Where did you find that directory with logs?

my-project-root/amplify/logs
FYI I'm on v4.39.0

It saved the log first time I ran it with --verbose but after that, the same thing happened with another resource and no log this time.

Interesting. I have never run with verbose. That said there is definitely not a log entry for every amplify push I've done. Unclear what is the logic used to write logs.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Bardia Navvabian<EMAIL_ADDRESS>Sent: Tuesday, December 15, 2020 8:50:39 AM
To: aws-amplify/amplify-cli<EMAIL_ADDRESS>Cc: David Grant<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [aws-amplify/amplify-cli] Amplify push shows "Error updating cloudformation stack" without specifying the error (#6155)
Pretty sure this is an AmplifyCLI issue. Even though the CLI standard output was silent on the issue, I found the following in amplify/logs/:
2020-12-13T17:38:32.414Z|error : amplify-provider-awscloudformation.push-resources.updateCloudFormationNestedStack(["/home/davidg/xxxxxxxxxx/amplify/b$ValidationError: Template format error: Resource name function xxxxxxxxxx-xxx-xxxxxxxx is non alphanumeric.
Where did you find that directory with logs?
my-project-root/amplify/logs
FYI I'm on v4.39.0
It saved the log first time I ran it with --verbose but after that, the same thing happened with another resource and no log this time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/aws-amplify/amplify-cli/issues/6155#issuecomment-745298117, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AETG67NI4QB7T55WALZJSQLSU5SS7ANCNFSM4UXADQ2Q.

Pretty sure this is an AmplifyCLI issue. Even though the CLI standard output was silent on the issue, I found the following in amplify/logs/:

2020-12-13T17:38:32.414Z|error : amplify-provider-awscloudformation.push-resources.updateCloudFormationNestedStack(["/home/davidg/xxxxxxxxxx/amplify/b$ValidationError: Template format error: Resource name function xxxxxxxxxx-xxx-xxxxxxxx is non alphanumeric.

Where did you find that directory with logs?

I have not got this directory too


Allow setting conditional classes via setters

Describe the bug
Avalonia has Classes.accent="{Binding IsSpecial}" markup.
https://docs.avaloniaui.net/docs/next/basics/user-interface/styling/style-classes#conditional-classes
But when i try to use it inside of setter if doesn't work and throws compilation error.
<Setter Property="Classes.withClipping" Value="True" />

Error AVLN:0004 Avalonia: Unable to find withClippingProperty field on type Avalonia.Controls.Classes,Avalonia.Base Line 591, position 15.

To Reproduce
Steps to reproduce the behavior:

Create a style
Add setter<Setter Property="Classes.withClipping" Value="True" />

See error

Expected behavior
Classes can be set via style/ControlTheme setters.
Desktop (please complete the following information):

Version: 11.0.4, but i suppose any

It's not a bug, but not a supported feature. Initially, it wasn't implemented due to the possibility of a circled loop of classes. I.e. class that disables itself in the style. Problem, that possibly can be ignored, but still would be pretty hard to diagnose.

It's not a bug, but not a supported feature. Initially, it wasn't implemented due to the possibility of a circled loop of classes. I.e. class that disables itself in the style. Problem, that possibly can be ignored, but still would be pretty hard to diagnose.

Sounds like if we get a circled loop of classes we also get StackOverflowException, isn't it?

Second the request, this would allow avoiding code duplication and reusing Style classes to define styling for child elements.
See #13906 for details.


Remove tiktok iframe

Optionally replace it with links to our social medias:

Facebook,
Instagram,
Tiktok,
(Ticketmaster?)++

NOTE:
We have to follow the guidelines for usage and editing of companies logos. E.g. Facebook logo: https://about.meta.com/brand/resources/facebook/logo/, which means they should NOT be recoloured to yellow.


Merge issues

After merging a commit, I can only access that commit's code and the ".md" files in the repository. If I revert, I can read and edit the files again.
Details

#4
#5
#6

Things work fine again. Smh...


Styleguide: Forms: Layout

Document Form Layout used within the app in a styleguide section
This includes:

Header ( If present )
Header Title
Form Group
Form Group Title
Label Alignment
Buttons ( Inline forms vs. modal forms )
Button alignment cancel vs submit

Refactor/cleaup form layouts where necessary.
Add:

define a FormLayout.scss
define a FormLayout.js in /styleguide/components/sections

Styleguide Index: #884
reference #877

Layout added to index in #970, first form update in #980.
Additional issues for other form updates have been created:
https://github.com/linode/manager/issues/986
https://github.com/linode/manager/issues/985
https://github.com/linode/manager/issues/984
https://github.com/linode/manager/issues/982
https://github.com/linode/manager/issues/981
If I missed a form, please create an issue


Handle unknown fields part of a oneof

Companion CL https://dart-review.googlesource.com/c/sdk/+/125345 has tests.

I have also improved the _clearField methods handling of oneofs. It was doing the work twice, and only for known fields @szakarias Could you look over that?

@sigurdm it seems like the changes to _FieldSet._hasField are separate from the issues with oneof and can be merged separately, with the test you added. Should we do that?


AndroidX.JetBrains.Annotations – Package namespace conflict when binding native kotlin libraries

When including the Kotlin standard library (jdk 7 version <IP_ADDRESS>) I have a namespace conflict with JetBrains.Annotations which we leverage heavily.
For the time being I've worked around it with a target but would it be possible to remove this dependency?

Thanks for the feedback.
So, let me see if I understand this correctly.
This is kotlin stdlib pom.xml
https://repo1.maven.org/maven2/org/jetbrains/kotlin/kotlin-stdlib/1.5.0/kotlin-stdlib-1.5.0.pom
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib</artifactId>
<version>1.5.0</version>
<name>Kotlin Stdlib</name>
<description>Kotlin Standard Library for JVM</description>
<url>https://kotlinlang.org/</url>
<licenses>
<license>
<name>The Apache License, Version 2.0</name>
<url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
</license>
</licenses>
<developers>
<developer>
<name>Kotlin Team</name>
<organization>JetBrains</organization>
<organizationUrl>https://www.jetbrains.com</organizationUrl>
</developer>
</developers>
<scm>
<connection>scm:git:https://github.com/JetBrains/kotlin.git</connection>
<developerConnection>scm:git:https://github.com/JetBrains/kotlin.git</developerConnection>
<url>https://github.com/JetBrains/kotlin</url>
</scm>
<dependencies>
<dependency>
<groupId>org.jetbrains</groupId>
<artifactId>annotations</artifactId>
<version>13.0</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib-common</artifactId>
<version>1.5.0</version>
<scope>compile</scope>
</dependency>
</dependencies>
</project>

Removing nuget dependency Xamarin.Jetbrains.Annotations from Xamarin.Kotlin.StdLib would break Xamarin.Kotlin.StdLib and other libraries and users.
There are 2 workaround that could work:

using fully qualified names in problematic files
using aliases (using JetBrainsAnnotations=Jetbrains.Something; and using XamarinAnnotations=Xamarin.Something;)

closing this one.

Sorry, missed the earlier message, Fully qualified namespaces don't work because the Xamarin.Jetbrains.Annotations package is in the JetBrains.Annotations namespace, thus you get a conflict no matter what you try aside from creating an alias at the assembly import level.
The 'fix' would be to use the Jetbrains.Annotations package instead of the Xamarin.Jetbrains.Annotations one, which only seems to exist for the sake of the kotlin stdlib packages.

That is to say, change the import here: https://github.com/xamarin/XamarinComponents/blob/589b5fb2befe500e1497e106e66a555fbf0eaf3a/Android/Kotlin/source/Xamarin.Jetbrains.Annotations/Transforms/Metadata.xml
From:
<attr<EMAIL_ADDRESS>name="managedName">JetBrains.Annotations<attr/>

To:
<attr<EMAIL_ADDRESS>name="managedName">Xamarin.JetBrains.Annotations<attr/>

Unfortunately, changing the namespace will break every application and NuGet package that currently uses these annotations, as .NET does not have a way to type forward to a different namespace.
If we just use the JetBrains version of JetBrains.Annotations, it will not contain the metadata needed to tie it back to the bound Java version (ie: the [Register] attributes):
namespace JetBrains.Annotations
{
    [Register("org/jetbrains/annotations/Contract", "", "JetBrains.Annotations.IContractInvoker")]
    public interface IContract : IAnnotation, IJavaObject, IDisposable, IJavaPeerable
    {
        [Register("pure", "()Z", "GetPureHandler:JetBrains.Annotations.IContractInvoker, Xamarin.Jetbrains.Annotations")]
        bool Pure();

        [Register("value", "()Ljava/lang/String;", "GetValueHandler:JetBrains.Annotations.IContractInvoker, Xamarin.Jetbrains.Annotations")]
        string Value();
    }
}

The only "safe" way to "rename" the namespace I can think of would be to create a second Xamarin.Jetbrains.Annotations2 package and have future versions of Kotlin stdlib depend on that.

You've probably considered this, but there is the possibility of dropping the dependency entirely, and including the jetbrains annotations jar as a reference jar which will avoid the binding of the library entirely so there'll be no possibility of conflicts.

If it was simply an issue of a compile time error then it wouldn't be too big of an issue.
The bigger issues is already compiled libraries.  That is, any already published NuGet referencing the existing library types would contain type references to ex: JetBrains.Annotations.IContract.  If a user updates to the new Annotations package and there isn't a corresponding update to the other Nuget, their app will crash at runtime with something like Type JetBrains.Annotations.IContract could not be found.  (Since the type would now be Xamarin.JetBrains.Annotations.IContract.

@joshuangfraedom wrote:

Fully qualified namespaces don't work because the Xamarin.Jetbrains.Annotations package is in the JetBrains.Annotations namespace, thus you get a conflict no matter what you try aside from creating an alias at the assembly import level.

This is what the C# namespace alias qualifier is for.  You can use global::JetBrains.Annotations.Type1 to explicitly use Typ1 from the the JetBrains.Annotations namespace, even if your current namespace is nested within Xamarin.JetBrains.Annotations:
namespace JetBrains.Annotations {
    class AnotherExample {}
}

namespace Xamarin.JetBrains.Annotations {
    class Example {}

    class App {
        public static void Main ()
        {
            // CS0234 if `global::` isn't present on following line
            global::JetBrains.Annotations.AnotherExample e = null;
        }
    }
}

@joshuangfraedom wrote

For clarity, the problem is that both packages expose the same namespace, so you can't qualify it that way as for example the type is JetBrains.Annotations.NotNull in both assemblies.

That is what the C# namespace alias qualifier alongside extern aliases is for.
In your C# source code, you could do:
// At global scope
extern alias JetBrains;

Within your .csproj, add %(Aliases) metadata which uses the same value, e.g.
<ItemGroup>
  <PackageReference Include="JetBrains.Annotations" Version="…" Aliases="JetBrains" />
</ItemGroup>

%(Aliases) is a comma-separated or semicolon-separated list of values; one of the values should match an extern alias declaration.  When these match, you can then use the C# namespace alias qualifier to reference types within the specified assembly:
extern alias JetBrains;

partial class Example {
    JetBrains::JetBrains.Annotations.NotNull notNull = null;
}

Note that when using %(Aliases), all types from the "aliased" assembly are not visible unless explicitly qualified.  global::JetBrains.Anotations.NotNull will not resolve to JetBrains.Anotations.NotNull, JetBrains.Annotations; it will instead resolve to JetBrains.Anotations.NotNull, Xamarin.JetBrains.Annotations.  (You can of course "reverse" this and make the Xamarin assembly use %(Aliases), in which case the JetBrains assembly could use global::.)

I ran into this problem when I upgraded Xamarin.AndroidX.AppCompat to 1.5.x because it now references Xamarin.Kotlin.StdLib.  This workaround seems to work without having to specify a PackageReference for Xamarin.Jetbrains.Annotations:
<Target Name="HideXamarinJetBrains" BeforeTargets="FindReferenceAssembliesForReferences;ResolveReferences">
  <ItemGroup>
    <ReferencePath Condition="'%(FileName)' == 'Xamarin.Jetbrains.Annotations'">
      <Aliases>DoNotUse</Aliases>
    </ReferencePath>
  </ItemGroup>
</Target>

@gtbuchanan Thanks! This solved the issue for me (using Xamarin Forms) whilst building the Android project.

In our specific use case, the namespace/type conflict was causing downstream issues. So the fix was to add PrivateAssets="all" to the offending PackageReference.
This won't fix the issue in the base project, but any project that references it will be unaffected.
   <ItemGroup>
-    <PackageReference Include="Xamarin.AndroidX.Window" Version="<IP_ADDRESS>" />
+    <PackageReference Include="Xamarin.AndroidX.Window" Version="<IP_ADDRESS>" PrivateAssets="all" />
   </ItemGroup>


Use custom hx- attributes for Blazor specific features instead of using hx-headers

Covered by https://github.com/egil/Htmxor/issues/30


Updated sfplan crds for mismatched schema's property

Updated the sfplan crd to avoid mismatching during schema validation from broker at the time of service instance creation/updation and the service binding creation.
https://jtrack.wdf.sap.corp/browse/HCPCFS-2878

Pull Request Test Coverage Report for Build 4967

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.167%

Totals

Change from base Build 4957:
0.0%

Covered Lines:
9411

Relevant Lines:
10185

💛  - Coveralls

Pull Request Test Coverage Report for Build 4967

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.167%

Totals

Change from base Build 4957:
0.0%

Covered Lines:
9411

Relevant Lines:
10185

💛  - Coveralls


Validating multidimensional arrays

I have two fields, named title[1] and title[2].

Indexes are used to mention the language id.

$this->form_validation->set_rules("title[]", "Menu title", "required");

Only validates the first index but not second or others using CodeIgniter 2.2.1. I want to know is there any fix so CI its self check for all the indexes and apply the same rule. Just like set_value["title[]"] reloads the value for each field automatically.

Please ask your questions on the forums instead, we only accept bug reports here.

Dear @nerfbg
Is this not a bug that title[] indexes are not validating just like set_value["title[]"] reloads all the value automatically without mentioning indexes?

Even if it is a bug, there are a few problems with you opening this issue here ...

Before reporting any bug, you must make sure that it hasn't already been fixed and step 1 is updating to the latest version. CI 2.2.1 is very old.
CI2 is in security maintenance mode and we no longer accept bug reports for it.
You didn't present it as a bug report; you just asked how to fix it for yourself.


show filename instead of game name

is there a way to show the complete filenames?
I have a few version like Euro, JAP, USA but in Emulationstation it only shows the game name not the filename. Which is confusing to me because then i wont know which version I am picking.
Example
#Filename
Street Fighter II (Europe).zip
Street Fighter II (Japan).zip
Street Fighter II (USA).zip
#Emulationstation game names:
Street Fighter II
Street Fighter II
Street Fighter II

I need it too. Currently there are no settings for this.
You can make a dirty hack: in the file es-app/src/FileData.cpp replace line 69
return removeParenthesis(stem);

with
return stem;

I would also like to see this as a feature. it would be great if this was a toggle in the ui options.

Pythoning the gamelist.xml just doesn't work... much much needed feature!
please apply it as soon as possible!!! Many Thanks!!!!

@btimofeev - I'm using retropie rpi image, do you know maybe how can i add this change and recompile with keeping anything else in tact ? thanks in Advance,

@Gyges-of-lydia - I also need it for retropie, but I never build apps for it.

+1 for this feature-request (show/sort by filename)


Unique Identifier (% identifier) does not work with an instantiated node

Godot version
Godot 4.1.3 stable
System information
Windows 10
Issue description
The Unique Identifier doesn't work in ready() when used in an instantiated node,
Instead of returning the node to search for, it returns null.
This behavior only occurs when the node containing the code making the request with the unique ID is instantiated by code.
The searched node can still be found using the classic godot path in the instantiated node
Steps to reproduce

Create a scene with a node looking for a node with a unique id
Instantiate the node
Instead of finding the node with the unique ID, we get a null

Example with a scene instantiated by the editor, then by code :
I tried to get unique and got: Unique:<Node2D#27111982233>
Instanciating get_unique
I tried to get unique and got : <Object#null>

Minimal reproduction project
TestUID.zip

The node you're instantiating through code is not a part of the scene (its owner is not set to the scene's root node) containing that node accessible with unique name, and hence it's expected that from such instantiated node get_node("%Unique") returns null.
Probably it could be clarified further in the docs.
Meaning if you'd e.g. change the GetUnique.gd in the MRP to:
extends Node2D

func _ready():
	if owner == null:
		owner = get_parent().owner
	var unique = get_node("%Unique")
	print("I tried to get unique and got : ",unique)

Then you'd get an output like:
I tried to get unique and got : Unique:<Node2D#24192746644>
Instanciating get_unique
I tried to get unique and got : Unique:<Node2D#24192746644>

Note there also this related issue: #66536.
Meaning if get_unique.tscn would itself contain at least 1 unique node, e.g.:

then even with the above changed GetUnique.gd you'd get output:
I tried to get unique and got : <Object#null>
Instanciating get_unique
I tried to get unique and got : <Object#null>


Stylelint error (Jekyll template)

I'm getting this error when editing my styles in atom:
Unable to parse stylelint configuration
Could not find "stylelint-order". Do you need a `configBasedir`?

Same here with Hugo and VS Code.

It looks that yarn add stylelint-order solve the problem...
Maybe it should be in static-scripts dependencies?
Thanks


[default-type] heading styles for longform markdown areas

Trello: https://trello.com/c/fzqceTXs/126-i-want-sensible-default-styles-for-markdown-coming-from-the-back-end

To test you will want to paste some markup in the markdown class containers, like the description area on the plan detail page. Here's a snippet if you want to use:

Header Level 1

Pellentesque haien ullamcorper pharetra. Donec non enim in turpis pulvinar facilisis. Ut felis.

Header Level 2

Pellenorbi tristique senectus et netus et malesuada fames ac turpis egestas. Vestibulum tortor quam, feuenean ultricies mi vitae est. Mauris placerat eleifend leo.

Header Level 3

Pestibulum tortor quam, feuan ultricies mi vitae est. Mauris placerat eleifend leo.

Header Level 4

Pellentesque habitant moenean ultricies mi vitae est. Mauris placerat eleifend leo.

Header Level 5

Pellentesque habitant moenean ultricies mi vitae est. Mauris placerat eleifend leo.

Header Level 6

Pellentesque habitant moenean ultricies mi vitae est. Mauris placerat eleifend leo.

There aren't any headers above it really so I'm not sure the size of the current markdown h1 size is a problem? The page header is bold so even if it is smaller (which I didn't check to see exactly what size it is) will still stand out even if it is a tiny bit smaller.
I can change it, but then there won't be any distinction between h3-h6.

There aren't any headers above it really so I'm not sure the size of the current markdown h1 size is a problem? The page header is bold so even if it is smaller (which I didn't check to see exactly what size it is) will still stand out even if it is a tiny bit smaller.
I can change it, but then there won't be any distinction between h3-h6.

Well there are currently headers above it on product-detail descriptions... but ideally I guess we want to intelligently remove those. I'm 👍  on this for now.


Reading timestamp "Cannot convert String to Long"

When writing into influxDB, I provided a long as Timestamp
Point.measurement(/**/).time(observation.getTimestamp(), TimeUnit.MILLISECONDS).(/**/)
However, when I read the Point back I find a formatted String
2015-07-03T09:34:25.714Z
and not the long as I would expect.
(Of course I get a Cast exception when trying to initialize my Pojo)
Is this wanted?

Also, milliseconds are not padded
2015-07-03T09:34:27.799Z
2015-07-03T09:34:27.79Z
2015-07-03T09:34:27.8Z
hence even parsing the String against the format  yyyy-MM-dd'T'HH:mm:ssz with SimpleDateFormat isn't a viable solution.

Hi @andremann
according to: https://influxdb.com/docs/v0.9/guides/querying_data.html
Timestamp format defaults to the format you see. It can be otoh configured with the epoch="s,ms,m,h," argument for the query. This is not yet implemented.
This can for example be implemented in a second api signature query(String query, TimeUnit unit)
Greetings
Stefan

I'm also waiting for this feature as the only acceptable choice for me is timestamp long

I implemented a new method query(String query, Timeunit unit) which acts as described above. This is only compile tested, so please test if this is what solves your problem.
Greetings
Stefan

Worked for me,  thanks


Use latest csi-lvm-controller (v0.2.2)

Use latest csi-lvm-controller (v0.2.2) to support shoots (and shooted seeds) with only one disk
See also: https://github.com/metal-pod/csi-lvm/commit/d2dbea8463e881fbf1e2caffc4652356413e2f1f

Sorry, I didn't see that early enough and already committed the same thing on oot-clouster-provider.


ciao-deploy: Keep going if any unjoin step fails

If any step during a "ciao-deploy unjoin" fails print an error and keep
going.
Fixes: #1488
Signed-off-by: Rob Bradford<EMAIL_ADDRESS>

Coverage decreased (-0.01%) to 65.995% when pulling fd3fe33b422162d27b8d799979cd9f05c1429b9b on rbradford:ciao-deploy-unjoin-keep-going into 6ab9a45a56d00edd5f9a4976996156335da6ecbd on ciao-project:master.

Coverage decreased (-0.004%) to 66.004% when pulling 19f008da6a7f63ee474e62e679f86629fba972f7 on rbradford:ciao-deploy-unjoin-keep-going into 6200ad7d773112057e5974a54ad402bba9204386 on ciao-project:master.


Session api

This time for real!
But again: any thoughts? I am not sure about the cookie handling in the session callback!? Is this ok, the way it is implemented?
Best
Daniel

Strange. Why are there the other commits?

I am terribly sorry for this spam! My repo was kind of dirty! Will create another, final (really)! promised! pull request for this!


Include topic information with Kafka metrics

Currently, Kafka metrics are emitted with partition information, but no information about which topic that partition belongs to. This patch includes the topic information in the Storm metrics emitted by the Kafka spout so that multiple input topics may be tracked from a single topology.

@chawco patch looks good to me but can you open a apache jira for it. Thanks.

Sure thing, I've filed STORM-713  for this issue.

You should update the commit message so it begins with JIRA number. +1.

I've amended the offending commit. Thanks!

+1


More Details of Tasks

Make subtasks clickable to open a window or something with some room to display more details about a task

I would suggest a copy button for error (makes your life easier when sharing @NeoPlays)?

haha yes like the idea of a copy button 🙌🏼

I would suggest a copy button for errors (or copy by click). Makes your life easier when sharing @NeoPlays)?
I liked your idea: "making the subtasks clickable which then opens a window with some details"
Will suggest some paths what this could look like
haha yes like the idea of a copy button 🙌🏼

Talked with @maxbehzadi82

[ ] Add Tooltip to display more information
[ ] Add Copy Button for Errors

implementation from backend needed


Concurrent state sampler

Provide concurrent state sampler to users via the new create_concurrent_vector_state_sampler function. The created function takes a list of (state, shots) tuples, state_shots_tuples, as input parameters and samples each state with the corresponding number of shots.
Example code:
state_vector_concurrent_sampler = create_concurrent_vector_state_sampler()

state_shots_tuple = [(state_1, n_shots_1), (state_2, n_shots_2), (state_3, n_shots_3)]

# concurrent sampler
state_vector_concurrent_sampler(state_shots_tuples)

I have read the CLA Document and I hereby sign the CLA


Chinese Digital Calipers 150mm mounting documentation error

The current instructions are
Designed for 150mm and 300mm calipers of the sort you'll find from various Chinese vendors. Combine with 2x2 L brackets and a 2x2 spacer.

Should the spacer be 2x3?
Should the bracket be 2x1?

Also both the tool holder and the bracket have a slot, how will the tool holder snap in the bracket?

Good catch and thanks for bringing it to my attention! I've updated the documentation on that part to better reflect reality 😃
One primary goal with my designs is to provide models that can be loaded directly into your slicer and print in the provided orientation without supports.  This can sometimes be challenging due to the geometry required by some models, and the calipers happen to be one of them.
Instead of printing the tabs on that model, as you've noted you'll find a slot.  What you'll need to do is to print 4x of the 4x10x8mm Pin models and press them into the slots to complete the assembled unit.

Good catch and thanks for bringing it to my attention! I've updated the documentation on that part to better reflect reality 😃
One primary goal with my designs is to provide models that can be loaded directly into your slicer and print in the provided orientation without supports.  This can sometimes be challenging due to the geometry required by some models, and the calipers happen to be one of them.
Instead of printing the tabs on that model, as you've noted you'll find a slot.  What you'll need to do is to print 4x of the 4x10x8mm Pin models and press them into the slots to complete the assembled unit.


Append new content to files

It should be possible to append content to existing files (and not overwrite them)
@JozefDropco Was your feature pull request released with the 0.9.1 release or is it still pending?

Hi, it was included in 0.9.0 version but that version had an issue with
ClassCastException. 0.9.1 works
Dňa št 20. 12. 2018, 22:24 Simon Wächter<EMAIL_ADDRESS>napísal(a):

It should be possible to append content to existing files (and not
overwrite them)
@JozefDropco https://github.com/JozefDropco Was your feature pull
request released with the 0.9.1 release or still pending?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/swaechter/smbjwrapper/issues/14, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAsg2gZ8EKdMdsqPzX579bvaBhLAUh6Zks5u7AAegaJpZM4Zc718
.

Just implemented the feature. The flag for getOutputStream(boolean) alone doesn't work - the CreateDisposition has to be adjusted accordingly. See: https://msdn.microsoft.com/en-us/library/cc246502.aspx
Feel free to report any issues. I hope to implement the rename/session delay feature soon & make a proper 0.0.9 release


dependency update

Thanks for putting the template together. I did some work to get to the latest version of many of the dependencies.

Hi @abersnaze. Sorry I missed this back in Nov 18. I've performed a lot of update work, but would you like to have a look over it, and if there's anything else you suggest, just update the PR and I'll go over it. Many thanks, Ben

Thanks for updating the project.


Add column for amount of comments per review.

Hey!
I really like the stats job and I recently started using it.
What I found missing was the stats about number of comments per pull request. When trying to achieve quality in the software, it is often more important how many comments are left per PR than just number of comments per all PRs
I am by no way a JS developer, so I am sure there would be a need to improve this further.. But I already use this branch myself in my integrations and I like the results

Hi @NaceHudobivnik
Thanks for your help! I also think is an important metric, just I'd like to make it optional to avoid results having a lot of stats / columns.
Please give 1 week or so, to find the time and work on this change.

Hello @NaceHudobivnik @badenh @rowi1de @gokulk16
Thanks for your patience. Now this stat is available in v3.0.0. Just send commentsPerReview in the new option stats along with the other stats you need to be printed.


Wrong size of the Signature Request and send pop-up window.

On  macOS using Chorme Version 108.0.5359.94 (Official Build) (x86_64):
The pop up window to unlock the sign actions opens undersized compared to the content which is seeing clipped away. See attached screenshot:

fixed in new versions


Running this script only got message created by function usageErr

Dear authors:
Greeting. Sorry to ask question in this way. My name is Benny Lin, and I am now translating this book (Cybersecurity Ops with bash), hence I am verifying all sample codes & add comments when I thought it's necessary.
For example 10-3, I copied codes from GitHub then paste to my Git bash environment to test it. What I found is, no matter I provided starting directory or not (with option -d, such as ./baseline.sh -d / before.txt), the result is always error messages from function usageErr.
I tried to add a line below, right before shift command:
echo "Check all options inside parseArgs before shifted: $OPTARG, $OPTIND"

But when I ran './baseline.sh -d / before.txt' again, the output became:
Check all options inside parseArgs before shifted: ,1

It seems that $OPTARG wan empty, and $OPTIND was 1. I wonder: aren't $OPTARG and $OPTIND global variables?  Shouldn't they be valid while inside a function being called?
So I  added another line before calling parseArgs function:
echo "Before parseArgs runs: $#,$0,$1,$2,$3"

Then I ran './baseline.sh -d / before.txt' again, I could see output like this:
Before parseArgs runs: 3,./baseline.sh,-d,/,before.txt,,1

So before parseArgs was called by script, the script itself did recognize my 3 options (-d, /, and before.txt).
Then I suddenly realized, regarding $# inside a function, does it represent function's number of options? Or it actually represents script's number of options? Because if it IS function's number of options, then it would always be '0', so parseArgs would always call usageErr, so I always got the error message.
Please provide your comments. I really love to discuss with authors while I translated.

Thank you for pointing this out.  The code file has been corrected.


[bug 1590541][bug 1202653] Docker image fixes and product-details update

Change mysql client to default-mysql-client for docker
Switch from MySQL-python to mysqlclient library
Update django-mozilla-product-details package
Set download directory for product_details
Update product details

I did some tests locally and didn't notice anything off. The test_view_edit_current_voting test failure is acknowledged as that one failed at https://travis-ci.org/mozilla/remo/jobs/599546390. Can you have a look at the other 3 test failures? Other than that r+ with the minor comment from me.
(obviously I can't say if these changes will have an impact on production though)

@MichaelKohler Other issues are related to email. Outbox is empty after the event comment. Do you know where it is trying to send an email for comments? I tried to find the signal, checked EventComment model and form, and couldn't find the email part.

Issue was that some users (recipients) passed to send_remo_mail function were in integer type instead of long, and the task was only accepting email string and long pk. Adding a check for integer with or solved email issues.

@akatsoulas yes, it also was my concern. While fixing the docker issue the product details started crashing, so I updated the package and that update also solved second bug. I can split it into 2 PRs if necessery. As for 2 whitespace commits, I missed the commented line and after Michael pointed it out, that line also changed with the update of travis's env file. At the end, I will squash all of them into 1 commit

Closing this PR because the site will be decommissioned soon. Thank you for the time spent on this.


Introduce hoogle support

/cc @jystic

Amazing :100:

Tests would be good :smiling_imp:

Looks good :100:

Added a sanity test. Let me know if anyone has problems using this.


Mantaray removed entry still persists

⚠ Support requests in an issue-format will be closed immediately. For support, go to Swarm's Discord.
Context
Bee Version: current master
System information: Mac M1
Summary
Adding and Persisting Nodes: Multiple nodes are added in the manifest, then saved.
Node Removal: Getting the saved node's reference from the previous step, a new manifest is loaded. Then one of the nodes is removed.
Persistence After Removal: The manifest is saved again after removing the node and reloaded to ensure the removed node does not reappear.
I have added a test that confirms that the removed node, img/2.png, cannot be found, verifying the removal operation. The expectation is for the system to return a mantaray.ErrNotFound error when trying to look up the removed node.
Expected behavior
This persistence should be rectified in the code logic or the test setup.
Actual behavior
Despite removing img/2.png, the removed node still persists at the end.

Steps to reproduce

the problem involves mantaray package I think
I have added a test in the mantaray_test package -> persist_test.go file.

Please see the test : https://github.com/asabya/bee/blob/4a8c3c5d994a9d91e69e7680237274667efb0ebf/pkg/manifest/mantaray/persist_test.go#L66
Possible solution

@ldeffenb Not sure what you mean actually. I have not personally used mantaray-js ever. I stumbled upon this issue while doing some experiment on bzz collection, trying to remove file/node from a manifest root node.

There is no way that I know (knew) of to remove an individual manifest node using just the bee node APIs.   From the description of what you did, I assumed (with all of the negative connotations of that word) that you were doing this external to the node with type/javascript using the mantaray-js package.
Having looked at your test, it appears that you are using the bee node package for the manifest and coding your program in golang?   I haven't heard of anyone trying to do this before, and therefore I'm not certain that direct accessing the packages that make up the bee node is supported.   But I'm willing to be proved worng (sic)!
https://github.com/ethersphere/bee/tree/master/pkg/manifest/mantaray
But do be aware that any data that is uploaded to the swarm cannot be directly deleted.  So even if you manage to remove the manifest node (and thereby get a new root manifest reference), the original data will still be accessible on the swarm via the original references, both of the data itself and/or the old root manifest reference and suitable path.

I assumed (with all of the negative connotations of that word) that you were doing this external to the node with type/javascript using the mantaray-js package.

Yes, I am doing this external to the node. But with golang, using the packages from bee itself.

I haven't heard of anyone trying to do this before, and therefore I'm not certain that directly accessing the packages that make up the bee node is supported. But I'm willing to be proved worng (sic)!

As the packages can be imported and have the interfaces to be implemented, I can assure you it is possible. Not sure if it's officially supported, but on most of the few cases that i tried it worked. Like, adding file entries into an existing manifest, adding custom metadata to entries etc.

But do be aware that any data that is uploaded to the swarm cannot be directly deleted. So even if you manage to remove the manifest node (and thereby get a new root manifest reference), the original data will still be accessible on the swarm via the original references, both of the data itself and/or the old root manifest reference and suitable path.

Yes I am aware of the fact that anything on swarm cannot be directly deleted and content will be accessible from both references. My idea is to update the manifest and access it from a feed.

I was going through the mantaray-js repo. Saw this issue https://github.com/ethersphere/mantaray-js/issues/40. I think it has the same issue as mine.


add installation instructions to readme

Closes #3

Once this merges in, we should republish to NPM with a patch bump so the README will show on the NPM page.

Thank you. @benbrown can you bump the version?


PHPStan process exited with error in WSL 2

Hello,
when trying to run this extension inside a WSL container it gives me this error:
[check:24] Spawning PHPStan with the following configuration:  {"binCmd":"\\\\wsl.localhost\\WorkArch\\home\\zhifan\\Documents\\Projects\\magento\\hrm-training-commerce\\vendor\\bin\\phpstan","args":["analyse","-c","\\\\wsl.localhost\\WorkArch\\home\\zhifan\\Documents\\Projects\\magento\\hrm-training-commerce\\phpstan.neon","--error-format=raw","--no-interaction","--memory-limit=1G","--no-progress","\\\\wsl.localhost\\WorkArch\\home\\zhifan\\Documents\\Projects\\magento\\hrm-training-commerce\\app\\code\\HRM\\Rma\\Test\\Unit\\Observer\\RequestUpdateObserverTest.php","-a","C:\\Users\\ZHIFAN~1\\AppData\\Local\\Temp\\tmp-79096-enUzrrgevQAT\\autoload.php","-c","C:\\Users\\ZHIFAN~1\\AppData\\Local\\Temp\\tmp-79096-enUzrrgevQAT\\config.neon"]}

[check:24] PHPStan process exited with error  err= '\\wsl.localhost\WorkArch\home\zhifan\Documents\Projects\magento\hrm-training-commerce'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported.  Defaulting to Windows directory.
'\\wsl.localhost\WorkArch\home\zhifan\Documents\Projects\magento\hrm-training-commerce\vendor\bin\phpstan' is not recognized as an internal or external command,
operable program or batch file.
  data=

Settings are the default ones.
Any tips to make this work inside WSL?

Hmm are you using the WSL extension in VSCode or are you using another way of opening the WSL folder? As far as I know, when using WSL in VSCode the file paths are all relative to the WSL root and don't use windows-style paths (such as \\wsl.localhost\WorkArch). When you open a terminal in your repo and run pwd what do you get?

It should work if you get rid of that error. I'm pretty sure it's caused by XDebug starting when it shouldn't (more info about how to fix it here). To debug it you can just try running PHPStan outside of the extension and you should run into the same error (the error isn't related to the PHPStan VSCode extension).
After this it should no longer exit with an error and exit successfully and the errors diagnosed should be integrated into VSCode's diagnostics.

I don't know why it throws that error but I managed to work it around.
For PHP development I'm using DDEV which is basically a wrapper around docker-compose that helps you manage PHP environments and has its own way to run xdebug.
What I had to do was to attach to the webserver container inside

VSCode and now it works like a charm.
By the way, since this doesn't seem a fatal error, could you provide a way to ignore this error in the extensions' settings?

Great to hear that it's working!
It's surprisingly hard to ignore PHPStan errors. Since you can't rely on the exit code to find out whether it exited with an error, you have to look at whether stderr was set. I could then filter out any error that contains this xdebug string but I'm sure that won't work on systems with different languages or different xdebug settings (for example in this case it's using "Step Debug", another config might not). I'll definitely keep this in mind though, and if it happens more often I'll consider adding such a feature. For now I'll hold off on adding it.
(I'll close the issue since I think your problem has been resolved)

FYI I've implemented something close to what you suggested in the latest release. Instead of ignoring xdebug stuff, there's a new setting (phpstan.ignoreErrors) where you can put to-be-ignored errors.


Update to Rust version 1.81.0

This PR kind of is an optional add-on to #5012.

Once #5012 is merged and this PR is rebased, this should be good to go if @laurmaedje is ok with bumping the Rust version (note that this PR bumps the CI versions, not only the flake).

I'm ok with that

#5012 is merged.

Thanks!


Commerce API breaks on deserializing BOM character in RateCard response?

Package Name:
@azure/arm-commerce

Package Version:
2.1.1

Operating system:
macOS Mojave 10.14.6

[x] nodejs

version: v10.16.3

[ ] browser

name/version: N/A

[x] typescript

version: 3.4.1

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
When trying to download the rate card data via the commerce package, an error occurs. This has always worked but since december 20th a JSON deserialization exception occurs.
Error: Error SyntaxError: Unexpected token  in JSON at position 0 occurred in deserializing the responseBody - {"OfferTerms":[{"Credit":150.0,"EffectiveDate":"2013-12-23T00:0<<full json payload removed>>

Here in the Issue it's not showing but there is a 'weird' character at the start of the response:

I think it's a BOM (Byte order mark) that causes the deserialization to fail?
To Reproduce
Steps to reproduce the behavior:

Create a small app:

import * as msRestAzureNode from "@azure/ms-rest-nodeauth" // "2.0.4"
import * as commerce from "@azure/arm-commerce"; // "2.1.1"
import * as fs from "fs";

const subscriptionId = "*******-3703-4687-9d4e-826010b85e24";
var tenantId = "*******-384b-4d25-aaba-4e6c8b0762d5";
var offerId = "MS-AZR-0063P"
var currency = 'USD'
var locale = 'en-US'
var regionInfo = 'US'

msRestAzureNode.interactiveLogin({ domain: tenantId }, (err, creds) => {
    this.usageManagementClient = new commerce.UsageManagementClient(creds, subscriptionId);
    this.usageManagementClient.rateCard.get(`OfferDurableId eq '${offerId}' and Currency eq '${currency}' and Locale eq '${locale}' and RegionInfo eq '${regionInfo}'`).then((rates) => {
        console.info(`Done: ${rates}`)
    }).catch((e) => {
        console.log("Error, see log.txt")
        fs.writeFileSync("log.txt", JSON.stringify(e));
    });
});

Expected behavior
Work with the price card data
Additional context
I'm using this package/api to power the Azure Cost Insights DevOps Extension. Therefor, my users run this every day as part of a scheduled nightly Azure Pipeline. First failures started ±19-20 december. Did they change the API's, or...?
Also reproduced on Windows 10 with Node 12.9.1 and TS 3.7.4.

Thanks for reporting @keesschollaart81
@qiaozha Can you take a look if this is an sdk issue or a service side issue?

I think it's a service side issue. the original responseBody has already contained the BOM.

I think it's fixed. @keesschollaart81  please check and verify.

That is correct, this now works in all my test cases/customers. Would you mind to share what the root cause was?

@qiaozha, There was no changes done to the packages, so my guess is that something was fixed in the service side?

@qiaozha, There was no changes done to the packages, so my guess is that something was fixed in the service side?

Yes. we haven't done anything in the package side.

Hi, since the issue was resolved and there hasn't been any activity on this issue for a while, I'll close it. Thanks!

Hi, since the issue was resolved and there hasn't been any activity on this issue for a while, I'll close it. Thanks!


[BUG] If a node attribute value contains an apostrophe, nx_translator().to_cypher_queries(G) breaks because the string values are contained in a single quote instead of double.

Memgraph version Which version did you use?
1.6.0
Environment Some information about the environment you are using Memgraph
on: operating system, how do you connect, with or without docker, which driver
etc.
Operating System: Darwin
OS Version: Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000
OS Release: 23.6.0
OS Architecture: arm64
Full Platform Info: macOS-14.6.1-arm64-arm-64bit
Connecting with docker. Not sure about which driver
Describe the bug A clear and concise description of what the bug is.
When a string attribute value on a node contains an apostrophe, the nx_translator().to_cypher_queries(G) will break. It seems to be because string values are enclosed by a single quote instead of double quotes.
To Reproduce Steps to reproduce the behavior:

Run the following python code

import networkx as nx
from gqlalchemy import Memgraph
from gqlalchemy.transformations.translators.nx_translator import NxTranslator

from warnings import filterwarnings

filterwarnings("ignore")

memgraph = Memgraph("<IP_ADDRESS>", 7687)
memgraph.drop_database()
graph = nx.Graph()
graph.add_nodes_from([(1, {"labels": "First", "name": "Josh's Laptop"}), 2, 3])
graph.add_edges_from([(1, 2, {"type": "EDGE_TYPE"}), (1, 3)])

nx_translator = NxTranslator()
for query in nx_translator.to_cypher_queries(graph):
    memgraph.execute(query)

Expected behavior A clear and concise description of what you expected to
happen.
I would expect that the queries should be seemlessly created and executed.

Hi @joshtracy3 thank you for reporting this. It can definitely be handled better internally, but I tried running this and it worked:
graph.add_nodes_from([(1, {"labels": "First", "name": "Josh\\'s Laptop"}), 2, 3])
Let me know if it works for you. Btw. what are you working on?

@katarinasupe yes this works if you escape the apostrophe's. There also seems to be an issue if the name contains a backslash. I just updated the functions to_cypher_labels and to_cypher_values in nx_translator to double quotes. Seems to work alright. I'm working on an entity linkage problem.

Feel free to open a PR @joshtracy3 😄 Thank you for letting me know what works. I hope Memgraph is performing well for your use case.
If you still haven't, join our Discord server or schedule an office hours call for more questions.


Use checked_sub to fix panic on window resize.

bug link: https://github.com/iced-rs/iced/issues/1773

It seems there is no way to fix the cargo-deny failure currently? Ouroboros just depends on syn 1.0 ...

Rebased on #119 to fix build


ncks "append mode" is broken

The code to retrieve the version of NCO is currently broken:
  File "/home/kwilcox/miniconda3-py36/envs/packrat35/lib/python3.5/site-packages/nco/nco.py", line 224, in get
    nco_version = self.version()
  File "/home/kwilcox/miniconda3-py36/envs/packrat35/lib/python3.5/site-packages/nco/nco.py", line 364, in version
    ncra_help)
  File "/home/kwilcox/miniconda3-py36/envs/packrat35/lib/python3.5/re.py", line 173, in search
    return _compile(pattern, flags).search(string)
TypeError: cannot use a string pattern on a bytes-like object

When specifying the append flag (-A) in ncks, the version() function is called resulting in errors. We need some test coverage for the append ncks functionality!
$ python
Python 3.5.3 | packaged by conda-forge | (default, Feb  9 2017, 14:37:12)
[GCC 4.8.2 20140120 (Red Hat 4.8.2-15)] on linux

Working on a PR...


Sourcemaps is not referencing the correct paths

Hi,
I've recently added gulp-js-import to my application in order to import js files in my main script.js file.
I put sourcemaps.init() before, like for any other js compile task, but every error that occurs in my browser is referenced as being part of script.js.
An example:
script.js
@import 'test.js';
test.js
alert(bar);
My browser's console:
Uncaught ReferenceError: bar is not defined at script.js:1
I've sent an issue report for gulp-js-import, as it could be related to this plugin, but as I don't know how sourcemaps work when used in a gulp pipeline I prefer to report here as well.
Do you have an idea of how to make it work?
A clue on what to add or change in the gulp-js-import plugin?
Thanks

There's no sourcemap support in the module you linked.  Also, that plugin doesn't follow gulp plugin guidelines so you should not use it.


Workspace Trust should auto accept empty workspace folders

I created a new directory and opened VS Code on it. I got a prompt asking if I trust the files :-)

Closing this as duplicate of #128457.


[feat] add check for Weaviate version at instantiation

Addresses #287 (partly - client-side version check not implemented) by checking the current Weaviate instance version against a (hard-coded) minimum threshold.
*Note: Initially it was set up to grab the latest version from GitHub and compare against a threshold difference (e.g. 3 minor versions). But this causes issues with GH rate limits during tests (every instance is a GH API request).

Codecov Report
Patch coverage: 97.12% and project coverage change: -0.16 :warning:

Comparison is base (8f7e154) 96.14% compared to head (6d3aa1b) 95.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   96.14%   95.99%   -0.16%
==========================================
  Files          61       64       +3
  Lines        7295     7461     +166
==========================================
+ Hits         7014     7162     +148
- Misses        281      299      +18

Flag
Coverage Δ

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

integration/test_timeout.py
100.00% <ø> (ø)

weaviate/backup/backup.py
100.00% <ø> (ø)

weaviate/schema/crud_schema.py
79.01% <ø> (ø)

weaviate/gql/multi_get.py
86.36% <86.36%> (ø)

integration/test_authentication.py
89.34% <92.85%> (+0.25%)
:arrow_up:

weaviate/connect/connection.py
90.61% <93.33%> (+0.55%)
:arrow_up:

weaviate/util.py
95.69% <94.11%> (-0.16%)
:arrow_down:

test/test_embedded.py
97.56% <97.56%> (ø)

weaviate/embedded.py
97.76% <97.76%> (ø)

integration/test_graphql.py
90.58% <100.00%> (+2.01%)
:arrow_up:

... and 11 more

... and 8 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Sadly a few things in the client ahve changed and yuo need to either rebase or merge current main into your branch


[Splash Screen] Gif support

Extension name
Splash Screen
Feature Description
Gif support when launching games in Playnite. As of right now, only still images are supported.
Screenshots
No response

Videos are also supported, which are a much better way to display animations. I'm not sure about gif support, it's a very outdated format, specially for this use case and there must be ways to convert your gif to a video.


[X11] Prevent IME activation from entering infinite loop.

Fixes https://github.com/godotengine/godot/issues/72012

Thanks!


Negative term in mkTuple

Using dfconf2nix as found in https://gvolpe.com/blog/gnome3-on-nixos/ (excellent guide thank you), it gave a .nix file which contains a syntax error in mkTuple.
If either of the two numbers is negative, it is an "unexpected '-'" to the syntax checker of Nix. This came up in the "org/gnome/settings-daemon/plugins/color/night-light-last-coordinates" section of the dconf.settings.
I made it a string ("-71.xxxx" instead of -71.xxxx) and there is no longer a syntax error but I don't know if it is still performing correctly.
Have you seen this before?
Thank you

This appears to only be an issue with the version from nix-env. I added it as a system package and it is no longer occurring. Thank you for this program.

I'm still seeing this in version 0.0.7

Nevermind, I was running an old version, sorry!

This is still present in v0.0.8. The following input:
[org/gnome/settings-daemon/plugins/color]
night-light-last-coordinates=(43.684199280057591, -79.347200000000001)

Produces
# Generated via dconf2nix: https://github.com/gvolpe/dconf2nix
{ lib, ... }:

let
  mkTuple = lib.hm.gvariant.mkTuple;
in
{
  dconf.settings = {
    "org/gnome/settings-daemon/plugins/color" = {
      night-light-last-coordinates = mkTuple [ 43.68419928005759 -79.3472 ];
    };
}


Writing GCCPCA CA Pool Config Fails with Error 500

Running Vault 1.9.2, with the 1.1.0 release of this plugin.
I've installed using the prebuilt binary following the direction provided in the README.  Received Success registering and then enabling the plugin.
I am then attempting to run the following write to the configuration with of course my details filling in below.
vault write gcppca/config
pool="my-pool"
location="us-central1"
project="your-project-id"
During the run of this command I receive the following error:
Error writing data to gcppca/config: Error making API request.
URL: PUT https://vault-address:port/v1/gcppca/config
Code: 500. Errors:

1 error occurred:
* internal error

Any assistnace on this would be much appreciated, thanks!

if your'e running vault production locally, you shold see the log out put to stdout.  (i'd recommend testing with the vault dev server just to verify and test).
anyway, when you use vaultproduction,  you need to register the plugin and specify a ca-cert if you're using a custom CA for TLS as described in the repo.  eg
 -args="-ca-cert=$VAULT_CACERT"

as in
vault plugin register \
    -sha256="${SHASUM}" \
    -command="vault-plugin-secrets-gcppca" \
    -args="-ca-cert=$VAULT_CACERT" secret vault-plugin-secrets-gcppca

The install of the plugin has the arg poining to the CA Cert.
Checking journalctl to get the output I got this:
plugin tls init @module: secrets.vault-plugin-secrets-gcppca.vault-plugin-secrets-gcppca_#####.vault-plugin-secrets-gcppca.vault-plugin-secrets-gcppca error during token unwrap request Error making API request. Client sent an HTTP request to an HTTPS server
error rolling back @module rollback Unrecognized remote plugin message:  This usually means that the plugin is either invalid or simply needs to be recompiled to support the latest protocol path gcppca
So build from source then instead of the pre-compiled version?

Recompiling isn't necessary...i'm not sure what would cause that error (i did just verify its working end-to-end with this config):
$ vault --version
Vault v1.9.3 (7dbdd57243a0d8d9d9e07cd01eb657369f8e1b8a)

$ sha256sum /apps/vault/plugins/vault-plugin-secrets-gcppca
9a5fa7af21615b919394f537c7e08ac20a1a2c6cd650815f6dd9f2e1554c0949  /apps/vault/plugins/vault-plugin-secrets-gcppca

$ more /apps/vault/server.conf
backend "file" {
  path = "/apps/vault/filebackend"
}

ui = true

listener "tcp" {
  address = "vault.domain.com:8200"
  tls_cert_file = "/apps/vault/crt_vault.pem"
  tls_key_file = "/apps/vault/key_vault.pem"
}

api_addr = "https://vault.domain.com:8200"

plugin_directory = "/apps/vault/plugins"

Alright I'll play around some more there and see what's going on.  The only thing that I could think of is something is wrong with the CA cert, since perms and everything else looks good.


Add rspec and create first test

Will need a bundle install, but then running spec will run the first (of hopefully many) test


memory leak after couple of multiple image selection and removing

Hi
i strictly test the app for different use cases that app users can do
i added all the images and removed couple of times about 5-10 ten times .
after that memory usage incrementally reached out  to 1.3gb .
also recognized that app doesn't release memory even though i switch to different app pages.
i am testing with simulator iphone 8 plus .
i know that it is not easy to  find out this kind of problem , i hope we can find some solution.
Thanks for help

setting  the variable referring    the my own  controller as a weak decreased   the memory usage    until 200mb-300mb , now it is fixed here  , when i go to main menu , memory usage is getting down to 60mb.
200mb-300mb is normal ? there is something to improve ?

In example project, there is not leak memory. ( 1 leak 48byte )
I don't know why it happen. can you show me your referring controller?
- instrument
iPhone X peak memory : 100MB
normal  : 80mb

Hi,
I think that's not related to the library but to the manner of how you exploit images retrieved from the library. From my point of view, images can have a huge size, depending on the quality. So, if you have an array of images with big sizes, you can have obviously a memory leak. Mostly if you store these images in an array.
Ali.


[CI] Run ArmSME tests under emulator as part of build_test_all_arm64

This adds a step to the existing build_test_all_arm64 job, which uses a small Python script to find the ArmSME tests and run them under QEMU.
This currently just runs the two matmuls defined in tests/e2e/matmul/BUILD.bazel, which is enough for a smoke test.

This script is a simple way to run the tests using a standard AArch64 build. The script is required as ctest (as far as I could find) does not allow simply injecting a prefix to the test commands without doing a full cross-compile (via CROSSCOMPILING_EMULATOR), which is overkill for just running a couple of SME tests.
Also, for this to work the gcr.io/iree-oss/base-arm64 docker image needs rebuilding with the Dockerfile from this patch (which includes QEMU). I don't think that's something I can do, so I'll need help there :)

cc @banach-space, @c-rhodes

Looks like all worked: https://github.com/openxla/iree/actions/runs/8018957309/job/21905918125
The two ArmSME e2e matmul tests ran under QEMU and passed.

Could someone land this for me? I don't have write access :)


Bugfix: Allow args to be a subclass of Hash

Mutant prefers 'instance_of?' to 'is_a?', if the tests pass with
either. But, the BaseCheck test for arguments was sending a Hash,
when in normal use, it's a Hashie::Mash. So, although the tests
were passing, the code was wrong.
This commit fixes that bug.

Minor niggle: this PR's commit title isn't in the imperative (because of the Bugfix). All our commit titles and PR titles should complete the sentence "If applied, this will…"

Fair point. I'll make sure that all future commit titles comply. Should we add a Danger rule that blocks commit titles that being with a single word followed by a colon?

Much as I'd like to, I think we'd be best leaving that for the moment and trying to socialise Danger use first, then adding things like that.


KEP-4292: Remove custom profiling env var as it is GA now

This PR remove environment variable KUBECTL_DEBUG_CUSTOM_PROFILE from the docs for https://github.com/kubernetes/enhancements/issues/4292 as it is promoted to stable now.

/hold

/cc @soltysh
Should we keep this flag in documentation as well until 1.34 or can it be removed?. WDYT?

I think, we should remove this feature gate from docs also in 1.34. So I'm closing this;
/close

Should we keep this flag in documentation as well until 1.34 or can it be removed?. WDYT?

@ardaguclu actually, the feature gate is locked to true, so it's safe to drop it from docs.

/reopen

/hold cancel
/sig cli

/approve


Move the old-android implementation of getifaddrs from Envoy Mobile to Envoy code

Move the old-android implementation of getifaddrs from Envoy Mobile to Envoy code.
This reverts commit dd0585e3d88a63b0fad3c519c3031dd5ee4124a8. The original version of this PR broken clang-tidy and coverage because this code was in third_party directory which was excluded from these checks. This PR moves them from mobile/third_party/ to third_party/ to match the move of the implementation from //mobile/ to //.
Signed-off-by: Ryan Hamilton<EMAIL_ADDRESS>Risk Level: Low
Testing: Mobile tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/assign @mattklein123


Bom Diggy by Zack Knight unsupported.

Check if issue with swaglyrics or whether song lyrics unavailable on Genius.

stripper -> Zack-Knight-Bom-Diggy

added to db


Add ARM_USE_OIDC auth type

https://nedinthecloud.com/2022/06/08/using-oidc-authentication-with-the-azurerm-backend/
https://colinsalmcorner.com/using-oidc-with-terraform-in-github-actions/

Hi @tanmay-db
I'm not sure to understand if it's possible to authentify the databricks terraform provider using oidc like we do with terraform azurerm provider ?
I read the links you mentionned (and issue) but it's not clear for me. I'm using Terraform Cloud to deploy my resources on Azure.
provider "azurerm" {
  features {}

  tenant_id       = var.tenant_id
  subscription_id = var.subscription_id
}

provider "azuread" {
  tenant_id     = var.tenant_id
}

provider "databricks" {
  host                        = azurerm_databricks_workspace.databricks.workspace_url
  azure_workspace_resource_id = azurerm_databricks_workspace.databricks.id
}

I would expect the databricks provider to connect to databricks using the same OIDC worflow than azurerm but it's not happening.
To enable azurerm OIDC auth workflow I just had to create federated credentials to trust Terraform Cloud in Azure for the service principal and then add the following env variables to Terraform Cloud workspace:
TFC_AZURE_PROVIDER_AUTH=true
TFC_AZURE_RUN_CLIENT_ID=<CLIENT_ID>
What should I do to enable OIDC for Databricks provider ?
Thank you very much

@loureirodnl  I dont use terraform cloud, but it is possible for regular TF for sure, it is difficult to get it to work with current options. Essentially this issue is here to get this working more slimply like in the AzureRM provider with the env var ARM_USE_OIDC: true
In my github actions I essentially run this:
jobs:
  x:
   (..)
   steps:
    - name: FetchBearerToken
      shell: bash
      id: bearer
      run: |
        DATABRICKS_AAD_TOKEN=`az account get-access-token --resource 2ff814a6-3304-4ab8-85cb-cd0e6f879c1d | jq -r '.accessToken'`

        echo "[DEFAULT]
        host = ${{ inputs.workspace }}
        token = $DATABRICKS_AAD_TOKEN
        jobs-api-version = 2.1" > ~/.databrickscfg

        cat ~/.databrickscfg

     - name: terraform plan (...)

To make things more difficult, the env vars ARM_CLIENT_ID or ARM_TENANT_ID cannot be set, or OIDC will not be used regardless with the current provider version.

any news on this?

This becomes more important nog that federated credentials are GA and soon to be the default setup method in Azure DevOps

any news on this?

Ever since terraform-provider-databricks version 1.50.0 which updated the SDK version to 0.44 and included this change: https://github.com/databricks/databricks-sdk-go/pull/910
I am struggling to make my workaround work described in https://github.com/databricks/terraform-provider-databricks/issues/2234 work anymore..


consolidate results for multi-ID query nodes

This ticket is a refinement of the results-building behavior defined in https://github.com/biothings/BioThings_Explorer_TRAPI/issues/164. Previously we did not address the case where the TRAPI specifies multiple allowed IDs for a single node.  For example, consider this query (also pasted as the Example query below), that asks BTE to explain the relationship between 6 different-but-related drugs in n00 to 3 different-but-related diseases in n02.  In the BTE results rendered in ARAX (see BTE screenshot), there are three different results that differ only by the three diseases in n02. In this case, the desired behavior would be to combine those three entries into a single result object.  Further down below in the results list, there are also other result objects that correspond to the different drugs in the query -- those also should be consolidated into a single result object.
The rationale for this change is that the "result" that the user likely cares about is the gene in n01, and the user will likely want to see all the supporting evidence for that gene.  So, a gene that is connected to multiple drugs in n00 and multiple disease in n02 would be viewed very differently than a gene connected to only one drug/disease.
Example query:
{
  "message": {
    "query_graph": {
      "edges": {
        "e00": {
          "subject": "n00",
          "object": "n01"
        },
        "e01": {
          "subject": "n01",
          "object": "n02"
        }
      },
      "nodes": {
        "n00": {
          "ids": [
            "DRUGBANK:DB00215",
            "DRUGBANK:DB01175",
            "DRUGBANK:DB00472",
            "DRUGBANK:DB00176",
            "DRUGBANK:DB00715",
            "DRUGBANK:DB01104"
          ],
          "categories": ["biolink:SmallMolecule"]
        },
        "n01": {
          "categories": ["biolink:Gene"]
        },
        "n02": {
          "ids": ["DOID:5844", "DOID:1936", "DOID:3393"],
          "categories": ["biolink:Disease"]
        }
      }
    }
  }
}

BTE screenshot

I wanted to verify -- we could have ids lists for different nodes, and those nodes could be of the same type. So if we had two disease nodes, they could each have ids lists, and those lists could be identical, partially intersecting or non-intersecting, right?

yes, I think that's right.  But in practice, those lists will be non-intersecting 99% of the time.  So if throwing an error where multiple nodes of the same type have any overlapping IDs significantly simplifies the implementation, I think that's totally fine...

Closing this ticket as a special case of #341.  If the intent is to consolidate results when multiple IDs are specified, then the query should explicitly state that using the is_set parameter.  So the behavior described above should be performed if and only if the query looks like this:
{
  "message": {
    "query_graph": {
      "edges": {
        "e00": {
          "subject": "n00",
          "object": "n01"
        },
        "e01": {
          "subject": "n01",
          "object": "n02"
        }
      },
      "nodes": {
        "n00": {
          "ids": [
            "DRUGBANK:DB00215",
            "DRUGBANK:DB01175",
            "DRUGBANK:DB00472",
            "DRUGBANK:DB00176",
            "DRUGBANK:DB00715",
            "DRUGBANK:DB01104"
          ],
          "categories": ["biolink:SmallMolecule"],
          "is_set": true
        },
        "n01": {
          "categories": ["biolink:Gene"],
          "is_set": false
        },
        "n02": {
          "ids": ["DOID:5844", "DOID:1936", "DOID:3393"],
          "categories": ["biolink:Disease"],
          "is_set": true
        }
      }
    }
  }
}


eslint doesn't seem to work

Describe the bug
After adding prettier/eslint in https://github.com/OWASP/Nest/pull/97 the former once works whereas eslint seems doing nothing.
To Reproduce
I tested for unused variables/imports and a lot of undefined imports in tests hasn't been caught.
Expected behavior
Eslint has to warn/error about this type of things.

/assign

Hi there,
this one is pretty critical for enforcing the new frontend code quality. If you don't have it ready yet I could take care of it due to higher priority of the issue.

@arkid15r
I have tried multiple solutions and approaches throughout the day to resolve this issue. However, I consistently encounter the following errors during debugging:
File ignored because of a matching ignore pattern.
Warning: File ignored because no matching configuration was supplied.
I am unsure what I might be missing  .

/unassign


rename archived to sleeping

That is not what the API is returning though, is it? @notrab

@athoscouto yeah the API returns sleeping:
{
    "database": {
        "Name": "myrootschema",
        "DbId": "b8e89975-d722-11ee-a86f-f2e159adf5c7",
        "Hostname": "myrootschema-notrab.turso.io",
        "is_schema": false,
        "schema": "",
        "block_reads": false,
        "block_writes": false,
        "allow_attach": false,
        "type": "logical",
        "hostname": "myrootschema-notrab.turso.io",
        "version": "0.22.22",
        "sleeping": false
    }
}

@notrab but does the group model also have a sleeping field?
We may be talking about different endpoints, but the ones that return a group that I see come with the archived field.

@athoscouto ah, yes. Good catch!
@gris do we want to update the API to return sleeping there also?

@notrab let me get that fixed 🤓

I'll close this for now, but we can revisit once we unify the API responses elsewhere.


HttpClient has many TIME_WAIT or CLOSE_WAIT connections

I use AddHttpClient() dependency injection to add a client to a service. At times, when I execute netstat -a on the server, I see many connections open with TIME_WAIT or CLOSE_WAIT status. I believe that these connections take up so much resource that, other TCP connections are unable to operate. Is this possible? Is there a way to stop these, and is it safe?

Sounds like an HttpClient issue. Do you mind moving this bug over to https://github.com/dotnet/corefx?

Done. Thank you


Cannot Log-In

When attempting to log in using a valid API key, the process encounters an issue that results in the error message "error: missing required argument 'API Key'." This error indicates that, despite providing what appears to be a correct and valid API key, the system is not recognizing it as such.

Hey, could you specify how to reproduce the issue? Are you providing the api key through config or an CLI parameter?

Hey, could you specify how to reproduce the issue? Are you providing the api key through config or an CLI parameter?

I use the command "tolgee login ". I use the actual api key.

And if you specify the api key as a parameter --api-key does it work then?

So if I follow correctly you do:
tolgee login <api-key>

and then:
tolgee push

and it gives you "error: missing required argument 'API Key'."
This can happen when the api key is associated with different project than is specified in tolgeerc file, because then it's not used for push command. Could you check if the API key is associated with correct project. And also what error does it give you when you skip the login and provide the API key directly (tolgee push --api-key=<...>)?

You can also use --verbose parameter, that should also print error stack.

I don't use Tolgee CLI now.


Added Russian translation

Ou, I didn't know that I can't delete before accept :)

Ou, I didn't know that I can't delete before accept :)


More information on advanced query support for b2c

@rohsh354 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@rohsh354 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@rohsh354 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

I approve, @FaithOmbongi to check the rest.

@rohsh354 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

Hi @kengaderdus, please go ahead and sign off on this one. Thanks!

@kengaderdus, you can only sign off in the main PR conversation, not in review comments.

#sign-off


Put All Strings In strings.xml

Move all strings into the strings.xml so that they can be translated

Done in release v1.1.


Add llama_cpp_commit to Vulkan build and remove double params

This PR adds the missing llama_cpp_commit param to the Vulkan build workflow, and cleans up some double params that were already present in COMMON_DEFINE.
Build action completed succesfully on my fork and binaries were tested locally (including running the unit tests) without issues:
https://github.com/m0nsky/LLamaSharp/actions/runs/9598690516
This fix is required before the upcoming binary update. After the next binary update, we can merge Vulkan support (#797) and the new CUDA12 paths (#800).

Thanks again!


[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?
[ ] Have you successfully run brew man locally and committed any changes?

test labeling. Label was applied prior to PR creation via the GUI.

Review period will end on 2020-12-18 at 04:05:40 UTC.

Review period ended.

Review period ended.


jdk updated to jdk-8u121-linux-x64

Probably should also make the jdk dir in the image version independent:
common/provision/default/image-config.sh:jdk_install_dir=/mnt/jdk-7u80

jdk7 is recommended for these wso2servers.

As far as I know, wso2 should work just fine with jdk8.


unit fix

Fix for https://github.com/Yelp/dockersh/issues/24
added unit folder with content from another project
updated Dockerfile to copy unit folder

Build is still broken, I think we will still be at the mercy of the "cover" package because it still depends on code.google.com, right?

(but also can you pull/rebase on master?)

build is still broken because it cant find libcontainer/namespaces ... still trying to figure out how to fix that one

see https://github.com/Yelp/dockersh/pull/26


Missed Attributes...

Are the missed aspects irrelevant?  or should those be reviewed..
Privkey found vs Privkey missed ...

I have found that if you remove the comment in the PrivKey missed, usually the output is a wrong key ( key to an non existent   address.

yeah its just junk ..
On Fri, Dec 27, 2024 at 1:34 PM Mahuro @.***> wrote:

I have found that if you remove the comment in the PrivKey missed, usually
the output is a wrong key ( key to an non existent address.
—
Reply to this email directly, view it on GitHub
https://github.com/iceland2k14/rsz/issues/43#issuecomment-2564046135,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJLDXRYS7XWR4AODKHPCLW32HXBXJAVCNFSM6AAAAABUC35YE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUGA2DMMJTGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Don't Break preset-wind built-in theme utils with preset-rem-to-px

Clear and concise description of the problem
I believe there are still some ppl prefer using px rather than rem, so they will use the preset-rem-to-px preset to achieve this.
This works all good with those spacing rules such as m-1 will be 1px instead of 0.25rem.
However, for those built-in utils in theme, such as text-* / rounded-*, etc., they will break, and it's a bit inconvenient since most likely for users use preset-rem-to-px they would still likely want to use those utils without any changes.
This could be a bit tricky since preset-rem-to-px simply converts all rem unit to px regardless the source, wondering if there could be any better solution than re-defining those utils in px in the config file's custom theme again?
Or would it be possible to maybe provide an option to not convert rem unit from theme?
Suggested solution
See above
Alternative
N/A
Additional context
N/A
Validations

[X] Read the Contributing Guidelines.
[X] Read the README.md of using the package.
[X] Already used the Interactive Docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Playground
Basically, there's nothing wrong with preset-rem-to-px itself, but since generally for users using this preset, they want m-1 to be margin: 1px; instead of margin: 4px; (with baseFontSize of 16), so they would set the baseFontSize to 4 to achieve that.
But this will break those built-in theme's size, e.g. maybe they still want to be able to use font sizes such as text-sm. As you can see in the playground, unless I re-define it using px or rem with 4 as baseFontSize, it's not going to work since built-in theme uses 16 as base font size.
But that's less ideal, since I'll need to define every single value I used in preset-uno's theme.
Wondering if there could be more we can do rather than redefining everything. Like I said, this is definitely not a bug, but just less ideal.

Yeah, it's the same as what I'm thinking. Seems it has to be rewritten. Cheers.


refactor

chore: refactor code
fix: missing check on lower boundary for Int64
fix: underflow with min int64 with floats

Coverage shows me there is something strange


Support for Origin v1.5.0

Now that Openshift Origin v1.5.0 has been released, I plan to work on adding support for the new version in the coming weeks.
Checklist (to be completed):

[x] Centos Package (see https://github.com/openshift/origin/issues/13887)
[x] Read release notes for the new version
[ ] Update this cookbook's LWRP and recipes

Alright :-) Sounds like a plan

Let's see if we can introduce an upgrade Adhoc recipe

@IshentRas I have submitted a draft PR for this feature. Looking forward to testing the adhoc upgrade recipe.

@jperville Ok next step is metrics/logging + new customisation items we shall offer to end user.

I am using 1.5 on my learning environment.
Could you please share which futures are not safe to use ( as i understand metrics/logging are those ) ?

Hello @ebenezar-mccoy , I have an 1.5.x cluster in production. As you said, the instructions for logging and metrics do not work anymore (because the official documentation says "use ansible playbook"). I'd like to see those ported to this cookbook one day, but you can still try to use the v1.4.1 images on top of openshift 1.5.x cluster, it should work (see https://docs.openshift.com/container-platform/3.4/install_config/aggregate_logging.html for documentation).
Also, beware of using prebuilt docker images from docker versions >= 1.10, the internal manifest format has changed, making impossible to reference the layers by sha256sum (that's not a problem with this cookbook but a gotcha that should be known by every openshift user).

Is the last item still to-do?

Can close, v1.5 is working in production for me.

@jperville, i'm a bit confused,
logging and metrics are still on todo list for 1.5 ? and we are safe to use images from 1.5 ?

Hello @ebenezar-mccoy ; the logging addon has never been supported by this cookbook (have a look at https://github.com/IshentRas/cookbook-openshift3/tree/master/resources ), and the metrics addon is supported if you supply all the parameters, so this cookbook is working as well with openshift v1.5.1 as it did work with openshift v1.4.x.
I was just reporting my experience with my own LWRP to deploy the logging component and I said that the instructions for v1.5.x are no longer available on the official documentation, they just say "use ansible", which means that if we were to support deploying the logging component using this cookbook (which is not possible today) we would have to backport the logic from the ansible cookbook instead of applying the documented steps, which used to work until v1.4.x included.

Sorry @jperville @ebenezar-mccoy for the delay replying to your post. Currently working on it. Should be with us shortly :+1:

@jperville the metrics is ready :+1:
Will send a PR shortly

@IshentRas, i'm watching changes in openshift_hosted_metrics branch.
Can i ask for something like
['openshift_hosted_metrics_selector'] = 'region=infra'
i think it currently depends on openshift_common_default_nodeSelector parameter.

@ebenezar-mccoy https://github.com/IshentRas/cookbook-openshift3/blob/openshift_hosted_metrics/attributes/metrics.rb#L36

@jperville @ianmiell Will need to refactor the tests for metrics as the way of deploying has changed

I am trying to test those changes to launch metrics in my test environment:
when pod hawkular metrics trying to start it's getting following error:
Events:
Error syncing pod, skipping: failed to "StartContainer" for "hawkular-metrics" with CrashLoopBackOff: "Back-off 20s restarting failed container=hawkular-metrics pod=hawkular-metrics-rk07n_openshift-infra(418770f1-615c-11e7-b5a5-005056b79c1f)"
Logs:
2017-07-05 08:34:07 Starting Hawkular Metrics
Error: the service account for Hawkular Metrics does not have permission to view resources in this namespace. View permissions are required for Hawkular Metrics to function properly.
Usually this can be resolved by running: oc adm policy add-role-to-user view system:serviceaccount:openshift-infra:hawkular -n openshift-infra

my configuration:
"openshift_hosted_cluster_metrics": true,
"openshift_metrics_image_version": "v1.5.1",
"openshift_common_default_nodeSelector": "region=infra"

I am unable to reproduce what you can see... Can you share the output of the following commands, please?

oc get clusterrolebinding hawkular-view
oc get clusterrolebinding  | grep /view

William

Output from my test:
[root@srv-101 ~]# oc logs -f hawkular-metrics-hpqf4
2017-07-06 17:04:05 Starting Hawkular Metrics
The service account has read permissions for its project. Proceeding
/opt/hawkular/auth /opt/jboss
Certificate was added to keystore
[Storing hawkular-metrics.truststore]
/opt/jboss
JBoss Bootstrap Environment
.....

$ oc get clusterrolebinding hawkular-view
NAME            ROLE      USERS     GROUPS    SERVICE ACCOUNTS           SUBJECTS
hawkular-view   /view                         openshift-infra/hawkular

$ oc get clusterrolebinding | grep /view
hawkular-view                                   /view                                                                                openshift-infra/hawkular

@ebenezar-mccoy Ok I have found a few bugs, I am about to fix. Will keep you posted as soon as I push a new version. (Likely to be today in a bit)

#142

@ebenezar-mccoy Can you test again against latest code please 1.10.57

Hi @IshentRas it's  still not working for me on 1.10.58, a different output from commands:
[root@oc01 ~]# oc logs -f hawkular-metrics-mv0xt
2017-07-14 07:36:22 Starting Hawkular Metrics
Error: the service account for Hawkular Metrics does not have permission to view resources in this namespace. View permissions are required for Hawkular Metrics to function properly.
Usually this can be resolved by running: oc adm policy add-role-to-user view system:serviceaccount:openshift-infra:hawkular -n openshift-infra
[root@oc01 ~]# oc get clusterrolebinding hawkular-view
Error from server (NotFound): clusterrolebinding "hawkular-view" not found
[root@oc01 ~]# oc get clusterrolebinding | grep /view
[root@oc01 ~]#

We have fixed the code to deploy the rolebinding locally instead of cluster wide.
Therefore you should get the following (Within the openshift-infra):
[root@srv-101 ~]# oc get rolebinding -n openshift-infra                                                                                NAME                   ROLE                    USERS     GROUPS                                   SERVICE ACCOUNTS   SUBJECTS
hawkular-view          /view                                                                      hawkular
system:deployer        /system:deployer                                                           deployer
system:image-builder   /system:image-builder                                                      builder
system:image-puller    /system:image-puller              system:serviceaccounts:openshift-infra
I have redeployed everything (Crash and burn)
And all look fine for me... I am a bit lost on how it is not working for you...
[root@srv-101 ~]# oc get pod
NAME                         READY     STATUS    RESTARTS   AGE
hawkular-cassandra-1-zgb1q   1/1       Running   0          5m
hawkular-metrics-6n418       0/1       Running   0          5m
heapster-xqf6x               0/1       Running   0          5m
[root@srv-101 ~]# oc logs hawkular-metrics-6n41 | head -n 5
Error from server (NotFound): pods "hawkular-metrics-6n41" not found
[root@srv-101 ~]# oc get pod
NAME                         READY     STATUS    RESTARTS   AGE
hawkular-cassandra-1-zgb1q   1/1       Running   0          5m
hawkular-metrics-6n418       1/1       Running   0          5m
heapster-xqf6x               1/1       Running   0          5m
[root@srv-101 ~]# oc logs hawkular-metrics-6n418 | head -n5
2017-07-14 10:05:26 Starting Hawkular Metrics
The service account has read permissions for its project. Proceeding
/opt/hawkular/auth /opt/jboss
Certificate was added to keystore
[Storing hawkular-metrics.truststore]

[root@oc01 ~]# oc get rolebinding -n openshift-infra
NAME                   ROLE                    USERS     GROUPS                                   SERVICE ACCOUNTS     SUBJECTS
admin                  /admin                  admin
hawkular-view          /view                                                                      hawkular
system:deployer        /system:deployer                                                           deployer, deployer
system:image-builder   /system:image-builder                                                      builder, builder
system:image-puller    /system:image-puller              system:serviceaccounts:openshift-infra

[root@oc01 ~]#  oc get pod
NAME                         READY     STATUS             RESTARTS   AGE
hawkular-cassandra-1-bjjlq   1/1       Running            0          3h
hawkular-metrics-mv0xt       0/1       CrashLoopBackOff   41         3h
heapster-hjbsl               0/1       Running            20         3h

heapster is wating for metrics
[root@oc01 ~]# oc logs hawkular-metrics-mv0xt
2017-07-14 10:40:57 Starting Hawkular Metrics
Error: the service account for Hawkular Metrics does not have permission to view resources in this namespace. View permissions are required for Hawkular Metrics to function properly.
Usually this can be resolved by running: oc adm policy add-role-to-user view system:serviceaccount:openshift-infra:hawkular -n openshift-infra

Redeploying this enviroment from scratch is in my routine.

@IshentRas,  do you have an idea how to solve this problem?

@ebenezar-mccoy Contact me on<EMAIL_ADDRESS>

@ebenezar-mccoy Sorry for such a delay. I'd like to thank you for your patience.
So your issue is down to a misused of one of the variable :+1:
So you use "openshift_metrics_master_url": "metrics.domain.local" and it is wrong as it is to overwrite the URL of the kubernetes listener or masters URL.
I believe that what you are trying to achieve is:
"openshift_metrics_hawkular_hostname": "metrics.domain.local" which set the FQDN to use with the Hawkular-metrics.
I can confirm that switching the options does solve your error.
Can you please check :-)

I assume we can close this now?


Clarification needed

Hi, great project! I'm curious why you not recommend it for production?

It is not recommended in production because it much less powerful as vue-loader + webpack.
However, if it fits your requirements, it is ok, but I really encourage people to use vue-loader + webpack.

Thanks for the answer. In my case integrating webpack node and all of their dependencies into project deployment will bring a great overhed to the project maintenance cost just because of literally two-three simple vue widgets which share subcomponents with each other. Thats why i searched a solution to that problem and found this project.
Btw personally i think that your project shouldn't be labeled as "testing-only" if it's stable and maintained but just not so feature reach as webpack with its loaders. :) Someone could probably not recommend a cat utility for production because of MS Office existance :))) Anyway, thank you for this great work, it's awesome.

thanks :)