Add a load_all() method

Is your feature request related to a problem? Please describe.
Sometimes I want the data of a given object and all its fields, recursively.  For example, sending the data off-server.  At the moment, AFAIK, in order to do this I need to manually load each (foreign) field of each class.
Describe the solution you'd like
I'd like a method, e.g. load_all(), which recursively calls load() and all() as needed on fields, and THEIR fields, and so forth, such that all of the data is present if I were to call e.g. json().  (The solution need not actually call load() and all(), so long as the result is equivalent.)
There may be difficulties regarding circular references.  What I'd normally expect is for repeat references to be set to the same object instance previously loaded.  If that is currently infeasible - say, if the __str__() method and others would infinite loop, and it's a widespread, difficult problem - then I think it would be acceptable to use an object with only the primary key(s) loaded, when encountering a previously-loaded object.
Describe alternatives you've considered
I've considered explicitly, manually loading the fields of an object tree in relevant places.
I've also considered writing a function to try to do it for me.
The former seems like a lot of work, and brittle to boot.  The latter might work - it'd be a little tricky, though, and I'm told that there might be a more efficient way than how I'd be liable to implement it myself.  (My own implementation would consist primarily of repeated calls to load() and all().)
Additional context
Add any other context or screenshots about the feature request here.

Added in 0.9.6 - please update and check

I did encounter one bug - when I upgraded, and used .load_all(follow=True) on my unmodified model, I got an error ormar.exceptions.ModelError: Unknown field '[name of one of my fields]' for model Link, where Link is presumably that dynamic linking class I made:
def link(tblname: str):
    class Link(ormar.Model):
        class Meta(BaseMeta):
            tablename = tblname
    return Link

I think maybe through doesn't respect related_name, because when I removed the related_name for the field to which the name given in the error most likely was intended to refer (i.e., when I removed the custom name that seemed to be broken), and updated the rest of my code accordingly, .load_all(follow=True) appeared to work fine.  So, that's good news, anyway, it seems to work aside from the related_name thing.  (Though I should probably do more than one single test, I suppose.)
Also - perhaps load_all could be present on QuerysetProxy, so we don't need to loop through the elements thereof and call .load_all(follow=True) on each?  Or, is there a recommended way of doing it I'm not familiar with?

You cannot set name of through field with related_name, if you refer to Link model in your example the trough name of the field will be link, if you mean related_name during creation of ManyToMany field it refers to name of the field that will be created on related model (the one passed as to parameter, reversed side).
If you want to change the name of through field you need to simple change the name of Through class as the name is the Through class name lowercase. In your factory function you can do it by dynamically creating classes with given name.
When you load_all without excluding anything out it should include also the models to which queryset proxy refers. It won't load the same relation twice if you have loops in nested relations but apart from that it should go as deep as lack of circular references allows.
Or you mean you would like to load_all() only the relation with nested models without reloading the main model?

TL;DR - re: related_name etc., I changed my link code to make the names of the generated classes different from each other, and the problem went away.  Something still feels fishy, because that's not how I solved it in my real code, and I haven't observed any problems with name collisions before the update - but the link change seems to fix it, so I'm not inclined to spend more time on the issue.
Original post, long version, probably unnecessary:
Yeah, I meant related_name of ManyToMany, sorry.  Keep in mind my code works, until I call load_all - or, at least, it used to work.  After more testing, I'm less sure of the conditions under which it now works.  So like:
def link(tblname: str):
    class Link(ormar.Model):
        class Meta(BaseMeta):
            tablename = tblname
    return Link

class CC(ormar.Model):
    class Meta(BaseMeta):
        tablename = "ccs"
    id: UUID = ormar.UUID(primary_key=True, default=uuid4)
    name: str = ormar.Text(default="")
    contents: str = ormar.Text(default="")

class CB(ormar.Model):
    class Meta(BaseMeta):
        tablename = "cbs"
    id: UUID = ormar.UUID(primary_key=True, default=uuid4)
    name: str = ormar.Text(default="")
    cCs: List[CC] = ormar.ManyToMany(CC, through=link("link_bc"), related_name="cBs")

class CA(ormar.Model):
    class Meta(BaseMeta):
        tablename = "cas"
    id: UUID = ormar.UUID(primary_key=True, default=uuid4)
    name: str = ormar.Text(default="")
    cBs: List[CB] = ormar.ManyToMany(CB, through=link("link_ab"), related_name="cAs")

In [2]: ca = await CA().save()

In [3]: cb = await CB().save()

In [4]: cc = await CC().save()

In [5]: await ca.cBs.add(cb)

In [6]: await cb.cCs.add(cc)

In [7]: await ca2.load_all(follow=True)
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\models\newbasemodel.py in __init__(self, *args, **kwargs)
    142         try:
--> 143             new_kwargs: Dict[str, Any] = {
    144                 k: self._convert_json(

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\models\newbasemodel.py in <dictcomp>(.0)
    145                     k,
--> 146                     self.Meta.model_fields[k].expand_relationship(
    147                         v, self, to_register=False,

KeyError: 'ca'

During handling of the above exception, another exception occurred:

ModelError                                Traceback (most recent call last)
<ipython-input-12-fe88e42d38c1> in <module>
----> 1 await ca2.load_all(follow=True)

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\models\model.py in load_all(self, follow, exclude, order_by)
    319         instance = await queryset.select_related(relations).get(pk=self.pk)
    320         self._orm.clear()
--> 321         self.update_from_dict(instance.dict())
    322         return self

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\models\newbasemodel.py in update_from_dict(self, value_dict)
    661         """
    662         for key, value in value_dict.items():
--> 663             setattr(self, key, value)
    664         return self
    665

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\models\newbasemodel.py in __setattr__(self, name, value)
    211         elif name in object.__getattribute__(self, "_orm"):
    212             model = (
--> 213                 object.__getattribute__(self, "Meta")
    214                 .model_fields[name]
    215                 .expand_relationship(value=value, child=self)

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in expand_relationship(cls, value, child, to_register)
    491         }
    492
--> 493         model = constructors.get(  # type: ignore
    494             value.__class__.__name__, cls._construct_model_from_pk
    495         )(value, child, to_register)

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in _extract_model_from_sequence(cls, value, child, to_register)
    341         :rtype: List["Model"]
    342         """
--> 343         return [
    344             cls.expand_relationship(  # type: ignore
    345                 value=val, child=child, to_register=to_register,

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in <listcomp>(.0)
    342         """
    343         return [
--> 344             cls.expand_relationship(  # type: ignore
    345                 value=val, child=child, to_register=to_register,
    346             )

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in expand_relationship(cls, value, child, to_register)
    491         }
    492
--> 493         model = constructors.get(  # type: ignore
    494             value.__class__.__name__, cls._construct_model_from_pk
    495         )(value, child, to_register)

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in _construct_model_from_dict(cls, value, child, to_register)
    393         if len(value.keys()) == 1 and list(value.keys())[0] == cls.to.Meta.pkname:
    394             value["__pk_only__"] = True
--> 395         model = cls.to(**value)
    396         if to_register:
    397             cls.register_relation(model=model, child=child)

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\models\newbasemodel.py in __init__(self, *args, **kwargs)
    141         # also remove property fields values from validation
    142         try:
--> 143             new_kwargs: Dict[str, Any] = {
    144                 k: self._convert_json(
    145                     k,

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\models\newbasemodel.py in <dictcomp>(.0)
    144                 k: self._convert_json(
    145                     k,
--> 146                     self.Meta.model_fields[k].expand_relationship(
    147                         v, self, to_register=False,
    148                     ),

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in expand_relationship(cls, value, child, to_register)
    491         }
    492
--> 493         model = constructors.get(  # type: ignore
    494             value.__class__.__name__, cls._construct_model_from_pk
    495         )(value, child, to_register)

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in _extract_model_from_sequence(cls, value, child, to_register)
    341         :rtype: List["Model"]
    342         """
--> 343         return [
    344             cls.expand_relationship(  # type: ignore
    345                 value=val, child=child, to_register=to_register,

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in <listcomp>(.0)
    342         """
    343         return [
--> 344             cls.expand_relationship(  # type: ignore
    345                 value=val, child=child, to_register=to_register,
    346             )

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in expand_relationship(cls, value, child, to_register)
    491         }
    492
--> 493         model = constructors.get(  # type: ignore
    494             value.__class__.__name__, cls._construct_model_from_pk
    495         )(value, child, to_register)

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in _construct_model_from_dict(cls, value, child, to_register)
    393         if len(value.keys()) == 1 and list(value.keys())[0] == cls.to.Meta.pkname:
    394             value["__pk_only__"] = True
--> 395         model = cls.to(**value)
    396         if to_register:
    397             cls.register_relation(model=model, child=child)

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\models\newbasemodel.py in __init__(self, *args, **kwargs)
    141         # also remove property fields values from validation
    142         try:
--> 143             new_kwargs: Dict[str, Any] = {
    144                 k: self._convert_json(
    145                     k,

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\models\newbasemodel.py in <dictcomp>(.0)
    144                 k: self._convert_json(
    145                     k,
--> 146                     self.Meta.model_fields[k].expand_relationship(
    147                         v, self, to_register=False,
    148                     ),

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in expand_relationship(cls, value, child, to_register)
    491         }
    492
--> 493         model = constructors.get(  # type: ignore
    494             value.__class__.__name__, cls._construct_model_from_pk
    495         )(value, child, to_register)

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\fields\foreign_key.py in _construct_model_from_dict(cls, value, child, to_register)
    393         if len(value.keys()) == 1 and list(value.keys())[0] == cls.to.Meta.pkname:
    394             value["__pk_only__"] = True
--> 395         model = cls.to(**value)
    396         if to_register:
    397             cls.register_relation(model=model, child=child)

c:\users\USER\appdata\local\programs\python\python38\lib\site-packages\ormar\models\newbasemodel.py in __init__(self, *args, **kwargs)
    153             }
    154         except KeyError as e:
--> 155             raise ModelError(
    156                 f"Unknown field '{e.args[0]}' for model {self.get_name(lower=False)}"
    157             )

ModelError: Unknown field 'ca' for model Link

Now, I WAS going to say "If I remove the related_name fields, everything works", because I think I did that with my real code and I remember it working.  However, I did that with the test code, and it did NOT work; the same error remained.  If I instead remove my through parameter, THEN things work.  Is it related to your comment "Note also that i.e. fastapi don't work properly with multiple classes with same name from same file."?  I don't think I've had problems with the dynamic linking class, before, though....  Still, after some testing, the problem goes away if I update my link code to distinguish the class names:
def link(tblname: str):
    class Link(ormar.Model):
        class Meta(BaseMeta):
            tablename = tblname
    Link.__name__ += tblname
    Link.__qualname__ += tblname
    Link.Meta.__qualname__ = Link.__qualname__ + ".Meta"
    return Link

At this point I went back up and wrote the TL;DR.

As for link tables this is related with filed registration - Through field is also registered on both sides -> and since your CB model has links to both CA and CC the link field is overwritten (same name for links CA-CB and CB-CC) hence the error. That should be an exception with ModelDefinitionError -> will add this, thanks for catching that! :)
Note also that after update Through model is optional (if you don't have any additional fields there) so you can skip the generation and ormar does it for you, default names of the fields are both classes names lowercase (so in your example link fields would be cacb and cbcc respectively (and table names would be cas_cbs and cbs_ccs, classes names CACB and CBCC, default names are in docs)).
Ahh, now I get this -> you don't want to reload given instance but load all relations during query, yeah it should be easy to implement since I implemented load_all() in a very similar way (it uses the QuerySet under the hood), can you please open enhancement issue for load_all from QuerySet?

Oh, ok; good to know.  Hopefully that accounts for the behavior I was seeing earlier; at this point I can't tell anymore, haha.
And good to know; default through models seem convenient, thanks.
Yeah, I'll open the enhancement; thanks.


[Bug] Disposing the Editor does not dispose the global key event listener

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[X] Not reproducible in the monaco editor playground

Monaco Editor Playground Link
No response
Monaco Editor Playground Code
No response
Reproduction Steps

Open an editor
Open the Suggestions (Ctrl + Space)
Dispose of the editor

Result: The 'keydown' eventlistener in dom.ts still triggers every input in my web application and even fires exceptions on chrome auto fill events.
Actual (Problematic) Behavior
The eventlisterner, although written as a disposable, is not correctly disposed of on disposing the complete editor.
Stacktrace of the exception after filling an input with chrome autocomplete (omitted Angular junk):
TypeError: e.getModifierState is not a function
at new StandardKeyboardEvent (keyboardEvent.ts:111:24)
at dom.ts:1165:18
Expected Behavior

The eventlistener should stop listening to events after the editor is disposed.
Also the constructor of StandardKeyboardEvent should not throw exceptions on auto fill events.

Additional Context
We embedded monaco in an angular app, handling multiple instances in a [stepper]https://material.angular.io/components/stepper/overview). Some of the steps contain simple input elements which cause the issues.

After entering content in the Monaco editor, clicking on another input box triggers an error in the console
Uncaught TypeError: e.getModifierState is not a function  at new StandardKeyboardEvent (keyboardEvent.js:66:30)  this.altGraphKey = e.getModifierState('AltGraph');

Seeing the same issue. Upgraded to the latest version and it still occurs. Any updates?
Uncaught TypeError: e.getModifierState is not a function  at new StandardKeyboardEvent (keyboardEvent.js:66:30)  this.altGraphKey = e.getModifierState('AltGraph');

I'm battling the same error
Unhandled Runtime Error
TypeError: e.getModifierState is not a function

Call Stack

new StandardKeyboardEvent
node_modules/monaco-editor/esm/vs/base/browser/keyboardEvent.js (66:0)

HTMLBodyElement.eval
node_modules/monaco-editor/esm/vs/base/browser/dom.js (118:0)

Anybody have a workaround for this?

Please provide a monaco editor playground example so that we can reproduce this issue.

As i wrote before: The error is NOT reproducable in the playground - as there is no real way to dispose the editor. Also the error triggers explicitly on Auto-Fill Events (which the editor should ignore) as those miss some of the properties of a Keyboard Event.

FWIW, I have also encountered this issue.

In which version is this problem solved？

I dont think it was. The issue was just closed. :(


TIP: :: as bind if you use babel

Instaed of using the [context, apply]...args you can use
yield call(::this.myFunction, arg1, arg2, arg3)
I find this to be a much simpler syntax and it works great.

Does the :: operator return the same reference on multiple invocations?
::obj.func === ::obj.func

Otherwise w'd have some issue when testing sagas

I advise you not to rely on experimental feature proposals anywhere except personal projects. Certainly not in the documentation or the source, as it confuses users who are not familiar with those proposals, or worse, leads them to believe those are safe to use when in reality they may well be withdrawn later.

@gaearon Agree.
@bradennapier  It seems ::obj.func is just a syntactic sugar for obj.func.bind(obj) (from babel REPL). So it can't be tested by simple equality. You can't simply test you Saga using
function *mySaga() {
  yield call(::obj.func)
}

const gen = mySaga()

// this will fail, because ::obj.func will return a different `func` object from the
// one produced inside the Saga
assert.deepEqual(gen.next().value, call(::obj.func))

Yep, just noticed that after some initial confusion!

Oops just removed the label you had added.  Can close this.


Log Process Metrics Similar to Graphite Carbon

The Carbon daemon records a bunch of useful metrics using itself, we should do something similar. Metrics:

CPU usage
Memory usage
Number of unique metrics
Number of total metrics
Number of datapoints per key
Packets received

This may require creating a channel from the backend to the frontend to allow it to send stats back to be stored.

Going to split this into two parts: Collecting the metrics and then emitting them along with all other metrics emitted to the backend. This issue will just be for collecting them internall.


Set default volume-plugin-dir to r/w path

ci check this

on coreos it will still fail with kubeadm i suppose: https://github.com/kubernetes/kubeadm/issues/476

This won't fix coreos. Let's close this PR until we can do something here to fix kubeadm.


issue with using both i386 and x64 versions on Windows

Another manifestation of this issue on Mac is re-compilation by compileNimble of CppCode files that are already compiled into libnimble.a.

Duncan responded:
Yes, that code for building libnimble at run-time, not installation time, is still in the code
but it should not be used on Windows.  How is it getting triggered ?  Is testBUGSmodel() calling
compileNimble() ?  testBUGSmodel("pump") is my go to simple test.
Or is it that you compiled without --merge-multiarch and then used  R -arch 32  ?

We can disable the code to build libnimble at run-time so it doesn't get run.
Alternatively, we can remove it,  OR I canmake it fully functional if we want it around.

This has been fixed on installation-issues branch by changing logic of what files get compiled in cppProjectClass::compileFile.


Adding optional address reference to ERC20Transfer.

Description
Adding optional address reference to ERC20Transfer.

@paulo-bc I did a decode using this website
https://flightwallet.github.io/decode-eth-tx/
of your test fixture and found that the function signature is not correct. Some more digging I found that this library actually computes the EVM function signature on the fly based on the arguments that you pass in
https://github.com/oliveratkinson-bc/wallet-core/pull/2/files#diff-ee5abff8d6706ab34d606ef7cfd4679e6da47d2bbb909fd9bf607981c6ed365aR95
This call here effectively takes the function name and the input argument types, hashes them, and takes the first 4 bytes to be the function signature, i.e.
https://piyopiyo.medium.com/how-to-get-ethereum-encoded-function-signatures-1449e171c840
By passing a third argument to the function here
https://github.com/oliveratkinson-bc/wallet-core/pull/2/files#diff-ee5abff8d6706ab34d606ef7cfd4679e6da47d2bbb909fd9bf607981c6ed365aR91
it results in a different hash (dbba0f01 instead of a9059cbb). I believe most smart-contract implementations would just completely ignore this transaction.
It seems like this function here takes the arguments and parses them into a function signature
https://github.com/oliveratkinson-bc/wallet-core/blob/30bcd54d7f3bdd9d074beef4bd0a31d00c6254e1/src/Ethereum/ABI/Function.cpp#L16
https://github.com/oliveratkinson-bc/wallet-core/blob/30bcd54d7f3bdd9d074beef4bd0a31d00c6254e1/src/Ethereum/ABI/Function.h#L57
https://github.com/oliveratkinson-bc/wallet-core/blob/30bcd54d7f3bdd9d074beef4bd0a31d00c6254e1/src/Ethereum/ABI/Parameters.cpp#L57
In particular, this is exactly what we want to avoid. We make use of the fact that the EVM ignores extra data beyond what is specified in the function signature. We need to find a way to make this library accept extra parameters without encoding them. For example we can probably add a boolean here
https://github.com/oliveratkinson-bc/wallet-core/blob/30bcd54d7f3bdd9d074beef4bd0a31d00c6254e1/src/Ethereum/ABI/Parameters.h#L38
Of the form shouldEncodeInFunctionSignature() or similar, that is checked here
https://github.com/oliveratkinson-bc/wallet-core/blob/30bcd54d7f3bdd9d074beef4bd0a31d00c6254e1/src/Ethereum/ABI/Parameters.cpp#L62

@paulo-bc I did a decode using this website
https://flightwallet.github.io/decode-eth-tx/
of your test fixture and found that the function signature is not correct. Some more digging I found that this library actually computes the EVM function signature on the fly based on the arguments that you pass in
https://github.com/oliveratkinson-bc/wallet-core/pull/2/files#diff-ee5abff8d6706ab34d606ef7cfd4679e6da47d2bbb909fd9bf607981c6ed365aR95
This call here effectively takes the function name and the input argument types, hashes them, and takes the first 4 bytes to be the function signature, i.e.
https://piyopiyo.medium.com/how-to-get-ethereum-encoded-function-signatures-1449e171c840
By passing a third argument to the function here https://github.com/oliveratkinson-bc/wallet-core/pull/2/files#diff-ee5abff8d6706ab34d606ef7cfd4679e6da47d2bbb909fd9bf607981c6ed365aR91 it results in a different hash (dbba0f01 instead of a9059cbb). I believe most smart-contract implementations would just completely ignore this transaction.
It seems like this function here takes the arguments and parses them into a function signature
https://github.com/oliveratkinson-bc/wallet-core/blob/30bcd54d7f3bdd9d074beef4bd0a31d00c6254e1/src/Ethereum/ABI/Function.cpp#L16
https://github.com/oliveratkinson-bc/wallet-core/blob/30bcd54d7f3bdd9d074beef4bd0a31d00c6254e1/src/Ethereum/ABI/Function.h#L57
https://github.com/oliveratkinson-bc/wallet-core/blob/30bcd54d7f3bdd9d074beef4bd0a31d00c6254e1/src/Ethereum/ABI/Parameters.cpp#L57
In particular, this is exactly what we want to avoid. We make use of the fact that the EVM ignores extra data beyond what is specified in the function signature. We need to find a way to make this library accept extra parameters without encoding them. For example we can probably add a boolean here
https://github.com/oliveratkinson-bc/wallet-core/blob/30bcd54d7f3bdd9d074beef4bd0a31d00c6254e1/src/Ethereum/ABI/Parameters.h#L38
Of the form shouldEncodeInFunctionSignature() or similar, that is checked here
https://github.com/oliveratkinson-bc/wallet-core/blob/30bcd54d7f3bdd9d074beef4bd0a31d00c6254e1/src/Ethereum/ABI/Parameters.cpp#L62

@matsjj thank you for the in depth review, I am getting back to this today and will get this all done 🙇

@matsjj Hey Mats, PR ready for review again.
I added a shouldSkipEncodeInFunctionSignature parameter to ParamBase (default false), added test covering that getType() behaves correctly with this change, and fixed the test you referenced that now has the fn hash a9059cbb.


multipart/formdata format POST support

Hi,
I've added support for multipart/formdata POST and also fix a bug for the request option unsigned_parameters

Hi,
I have recently come onboard to help maintain oauth-xx.
Thank you so much for your contribution, really, big or small, help is always welcome.
But this is a very old pull request and therefore I have to assume this problem has probably already been solved by somebody else and this PR was forgotten in time.
It would be very good if you could rebase or re-patch this so we can all merge this.
If you do believe there is any chance this issue has not been fixed, please click on re-open and I will come help you with it.
Best,
James Pinto.


adding executeAPI

Issues Resolved
Closes #164
Check List

[x] New functionality includes testing.

[ ] All tests pass

[x] New functionality has been documented.
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The tests will fail until PR #159 gets merged.

@dhrubo-os Can you send the criteria for validating the json?

import json

def is_json(myjson):
  try:
    json.loads(myjson)
  except ValueError as e:
    return False
  return True

I'm talking about something simple like this.

And for the simple calculator what I was instructing to use is here:
POST _plugins/_ml/_execute/local_sample_calculator
{
    "operation": "max",
    "input_data": [1.0, 2.0, 3.0]
}

# Output
{
    "sample_result": 3.0
}

ref: https://github.com/opensearch-project/ml-commons/blob/main/docs/how-to-add-new-function.md#step-6-run-and-test-1

Can we please check why the integration test is failing here?
                 try:
>                   self.fp = io.open(file, filemode)
E                   FileNotFoundError: [Errno 2] No such file or directory: '/code/opensearch-py-ml/tests/ml_commons/../../../../../synthetic_queries.zip'

Also can you please check why the integration test is failing here?

I'll prioritize this commit. Let's close out this commit asap if possible. Thanks

The problem is with the TESTDATA_SYNTHETIC_QUERY_ZIP constant path string.
TESTDATA_SYNTHETIC_QUERY_ZIP = os.path.join(     PROJECT_DIR, "../../../../..", "synthetic_queries.zip" )
I don't know why it started failing all of a sudden. Can you explain why there is a "../../../../.." argument here?

FileNotFoundError: [Errno 2] No such file or directory: '/code/opensearch-py-ml/tests/ml_commons/../../../../../synthetic_queries.zip'
It just concatenates the double dots as the other 2 arguments.


export_keeping_net_name_reverting

reverting default value to 20

@svandenb-dev @Samuelopez-ansys Is it normal of this PR got merged with 0 changes ? oO


Fix appveyor builds

Thanks for submitting a PR!
Please make sure to check for the following items:

[ ] Add unit tests and integration tests where applicable.
If you've added an error code or changed an error code behavior,
you should probably add or change a test case file under tests/test_cases/ and add
it to the list under tests/test_definitions.py.
If you've added or changed a command line option,
you should probably add or change a test in tests/test_integration.py.
[ ] Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

See discussion on https://github.com/tox-dev/tox/issues/791
Basically tox is using a really old version of pip which doesn't support some newer features required by our deps.

@Nurdok all the appveyor builds are failing. Please merge this so the other PRs pass.

Thanks!


Can't upload file with SpatieMediaLibraryFileUpload through the relation manager

Package
filament/filament
Package Version
v3.2.124
Laravel Version
10.48.24
Livewire Version
No response
PHP Version
PHP 8.2.25
Problem description
I have CustomerResource to handle Customer CRUD. I want to implement that File upload capability for the customers.I have installed Spatie Media Library plugin then created a relation manager. My purpose is to upload file with relation manager. I have set the resource form. It is listed as expected but, when I upload file and it throws SQL error:

Expected behavior
I was expecting to see upload file the local and insert data to table
Steps to reproduce
<?php

namespace App\Filament\Resources\CustomerResource\RelationManagers;

use App\Models\Customer;
use App\Models\Media;
use Filament\Forms;
use Filament\Forms\Components\SpatieMediaLibraryFileUpload;
use Filament\Forms\Form;
use Filament\Resources\RelationManagers\RelationManager;
use Filament\Tables;
use Filament\Tables\Table;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletingScope;

class MediaRelationManager extends RelationManager
{
    protected static string $relationship = 'media';
    protected static ?string $title = 'Dosyalar';
    protected static ?string $modelLabel = 'Dosya';
    protected static ?string $pluralModelLabel = 'Dosyalar';

    public function isReadOnly(): bool
    {
        return false;
    }
    public function form(Form $form): Form
    {
        return $form
            ->schema([
                SpatieMediaLibraryFileUpload::make('attachment')->collection('test')->multiple(),
            ])
            ->model($this->getOwnerRecord())
        ;
    }

    public function table(Table $table): Table
    {
        return $table
            ->recordTitleAttribute('name')
            ->columns([
                Tables\Columns\TextColumn::make('name'),
            ])
            ->filters([
                //
            ])
            ->headerActions([
                Tables\Actions\CreateAction::make(),
            ])
            ->actions([
                Tables\Actions\EditAction::make(),
                Tables\Actions\DeleteAction::make(),
            ])
            ->bulkActions([
                Tables\Actions\BulkActionGroup::make([
                    Tables\Actions\DeleteBulkAction::make(),
                ]),
            ]);
    }
}

I went to customer view page and try to upload file
Reproduction repository (issue will be closed if this is not valid)
https://github.com/firatdgn/filament-issue
Relevant log output
No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

I have successfully implemented a working RelationManager without using the ->model($this->getOwnerRecord()) method in the form, and it saves data perfectly. If it is still not working for you, you can try the following configuration for your file upload field:
SpatieMediaLibraryFileUpload::make('upload_quote')
    ->label(__('inba::labels.upload_quote'))
    ->collection('upload_quote')
    ->acceptedFileTypes(['application/pdf', 'image/jpeg', 'image/png', 'image/webp'])
    ->helperText('.pdf, .jpg, .jpeg, .png, .webp')
    ->statePath('data'); // Map the state to the 'data' attribute

Thank you I will try that and let you know the results 🙏

I have successfully implemented a working RelationManager without using the ->model($this->getOwnerRecord()) method in the form, and it saves data perfectly. If it is still not working for you, you can try the following configuration for your file upload field:

SpatieMediaLibraryFileUpload::make('upload_quote')

    ->label(__('inba::labels.upload_quote'))

    ->collection('upload_quote')

    ->acceptedFileTypes(['application/pdf', 'image/jpeg', 'image/png', 'image/webp'])

    ->helperText('.pdf, .jpg, .jpeg, .png, .webp')

    ->statePath('data'); // Map the state to the 'data' attribute

@firatdgn

Thank you I will try that and let you know the results 🙏

I have successfully implemented a working RelationManager without using the ->model($this->getOwnerRecord()) method in the form, and it saves data perfectly. If it is still not working for you, you can try the following configuration for your file upload field:
SpatieMediaLibraryFileUpload::make('upload_quote')
    ->label(__('inba::labels.upload_quote'))
    ->collection('upload_quote')
    ->acceptedFileTypes(['application/pdf', 'image/jpeg', 'image/png', 'image/webp'])
    ->helperText('.pdf, .jpg, .jpeg, .png, .webp')
    ->statePath('data'); // Map the state to the 'data' attribute

@firatdgn

Still same
  public function form(Form $form): Form
    {
        return $form
            ->schema([
                SpatieMediaLibraryFileUpload::make('attachment')->collection('test')->multiple(),
            ])
            ->statePath('data')
        ;
    }

The modal has the interface and the trait. Do I need to do additionally?
use Spatie\MediaLibrary\HasMedia;
use Spatie\MediaLibrary\InteractsWithMedia;

class Customer extends Model implements HasMedia
{
    use HasFactory, SoftDeletes, InteractsWithMedia;
}

same here


Update Dockerfile

@sakomws you’ll need to follow these steps to sign-off on your commits - https://github.com/layer5io/meshery/pull/291/checks?check_run_id=232341332

@sakows, like Lee has suggested, please fix the DCO issues and we can merge this PR.


Fix Check bucket size before find tablet.

Proposed changes
Issue Number: close #20175
Add some guard code in BE to avoid something similar happens.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


feat(mappers): Added support for glob patterns in source stream names

:books: Documentation preview :books:: https://meltano-sdk--1888.org.readthedocs.build/en/1888/

Related to https://github.com/meltano/sdk/issues/699 and https://github.com/meltano/sdk/issues/1350 and https://github.com/meltano/sdk/issues/1883.

Tested this with meltano-map-transform and it looks great :)
https://github.com/MeltanoLabs/meltano-map-transform/actions/runs/8650142183/job/23717977927?pr=241


"CApp has encountered deployment issues. Please refer to the output for error logs" ERROR in wso2 micro integrator with visual studio

Description
Hi Team,
I am following the WSO2 Quick start guide to work with MI integration (Helloworld service).
after designing the project, click ctrl + shift + p to add the MI Server in visual studio. Click on "Build and Run" button.
after build success, getting pop up like "CApp has encountered deployment issues. Please refer to the output for error logs."

Logs from MicroIntegrator Server - Output console :
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.857 s
[INFO] Finished at: 2024-12-06T22:33:48+05:30
[INFO] ------------------------------------------------------------------------
Stopping the Micro Integrator Server
SUCCESS: The process with PID 5132 has been terminated.

Logs from Micro Integrator - Output console:
[12/6/2024, 10:33:48 PM] [MI Debug] [INFO] Build and copy tasks executed successfully
[12/6/2024, 10:34:04 PM] [MI Debug] [ERROR] Error while checking for Server readiness: connect ECONNREFUSED <IP_ADDRESS>:9201

Steps to Reproduce

Install WSO2 MI and Visual studio by follows WSO2 official site https://mi.docs.wso2.com/en/latest/install-and-setup/install/installing-mi/

Design "Helloworld" service as instructed in WSO2 Quick reference https://mi.docs.wso2.com/en/latest/get-started/quick-start-guide/

After designing the project, Click on  "Build and Run" to deploy the created service to the WSO2 MI Server.Hello world

Version
WSO2 MI 4.3.0
Environment Details (with versions)

OS: Windows 11

WSO2 MI 4.3.0

Visual Studio Code: 1.95.3

Hi @JustinRaj-S,
Do you see any server starting logs after the build is success and before it gets terminated? Also please confirm that you are pointing to the server location and not its bin folder.

Hi @ChinthakaJ98
I have selected only the wso2-mi product, not bin directly while adding MI Server.

Below is the server log after build success:
`[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for com.microintegrator.projects:HelloWorld:pom:1.0.0
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 96, column 19
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO]
[INFO] --------------< com.microintegrator.projects:HelloWorld >---------------
[INFO] Building HelloWorld 1.0.0
[INFO]   from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
Downloading from wso2-nexus: https://maven.wso2.org/nexus/content/groups/wso2-public/org/apache/maven/plugins/maven-compiler-plugin/maven-metadata.xml
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/maven-metadata.xml
Downloading from wso2.snapshots: https://maven.wso2.org/nexus/content/repositories/snapshots/org/apache/maven/plugins/maven-compiler-plugin/maven-metadata.xml
Progress (1): 1.3 kB
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/maven-metadata.xml (1.3 kB at 1.6 kB/s)
Progress (1): 1.6 kB
Downloaded from wso2-nexus: https://maven.wso2.org/nexus/content/groups/wso2-public/org/apache/maven/plugins/maven-compiler-plugin/maven-metadata.xml (1.6 kB at 981 B/s)
[WARNING] Ignoring incompatible plugin version 4.0.0-beta-1: The plugin org.apache.maven.plugins:maven-compiler-plugin:4.0.0-beta-1 requires Maven version 4.0.0-beta-3
[INFO] Latest version of plugin org.apache.maven.plugins:maven-compiler-plugin failed compatibility check
[INFO] Looking for compatible RELEASE version of plugin org.apache.maven.plugins:maven-compiler-plugin
[INFO] Selected plugin org.apache.maven.plugins:maven-compiler-plugin:3.13.0
[INFO]
[INFO] --- clean:3.2.0:clean (default-clean) @ HelloWorld ---
[INFO] Deleting f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\HelloWorld\target
[INFO]
[INFO] --- dependency:3.5.0:copy-dependencies (default) @ HelloWorld ---
[INFO]
[INFO] --- vscode-car:5.2.75:car (default) @ HelloWorld ---
[INFO] datamapper directory not found
[INFO] ------------------------------------------------------------------------
[INFO] Building Composite Project
[INFO] ------------------------------------------------------------------------
[INFO] Processing artifacts in f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\HelloWorld\src\main\wso2mi\artifacts
[INFO] Processing API definitions in f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\HelloWorld\src\main\wso2mi\resources
[INFO] Processing connectors in f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\HelloWorld\src\main\wso2mi\resources
[INFO] Processing registry resources in f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\HelloWorld\src\main\wso2mi\resources
[INFO] Processing metadata in f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\HelloWorld\src\main\wso2mi\resources
[INFO] datamapper directory not found
[INFO]
[INFO] --- install:2.5.2:install-file (install-car) @ HelloWorld ---
[INFO] pom.xml not found in HelloWorld_1.0.0.car
[INFO] Installing f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\HelloWorld\target\HelloWorld_1.0.0.car to C:\Users\Amirtha.m2\repository\com\microintegrator\projects\HelloWorld\1.0.0\HelloWorld-1.0.0.car
[INFO]
[INFO] --- synapse-unit-test:5.2.75:synapse-unit-test (synapse-unit-test) @ HelloWorld ---
[INFO]
[INFO] --- install:2.5.2:install (default-install) @ HelloWorld ---
[INFO] Installing f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\HelloWorld\pom.xml to C:\Users\Amirtha.m2\repository\com\microintegrator\projects\HelloWorld\1.0.0\HelloWorld-1.0.0.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  6.837 s
[INFO] Finished at: 2024-12-09T12:16:28+05:30
[INFO] ------------------------------------------------------------------------
[2024-12-09 12:16:33,062]  INFO {org.wso2.config.mapper.ConfigParser} - Overriding files in configuration directory f:\WSO2_Learning\wso2_product\wso2mi-4.3.0\bin..
[2024-12-09 12:16:33,517]  INFO {org.wso2.config.mapper.ConfigParser} - Applying configurations with deployment configurations
Stopping the Micro Integrator Server
SUCCESS: The process with PID 23136 has been terminated.`
As soon as build success, getting that pop up

Hi @ChinthakaJ98
I  have shortened the directory path of the MI Server in Windows OS.
Before:F:\WSO2_Learning\wso2_product\wso2mi-4.3.0\wso2mi-4.3.0 (Failed)
Now: F:\WSO2_Learning\wso2_product\wso2mi-4.3.0 (Success)
After shortening Path, it is working as expected, and tested API via Runtime services

Hi @ChinthakaJ98
I think issue persists for some other project. I am trying  this tutorialhttps://mi.docs.wso2.com/en/latest/learn/integration-tutorials/sending-a-simple-message-to-a-service/
As soon as build was successful, getting pop up like "CApp has encountered deployment issues. Please refer to the output for error logs."
ERROR Logs:
[INFO] Scanning for projects... [WARNING]  [WARNING] Some problems were encountered while building the effective model for com.microintegrator.projects:MessageSample:pom:1.0.0 [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 96, column 19 [WARNING]  [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING]  [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING]  [INFO]  [INFO] -------------< com.microintegrator.projects:MessageSample >------------- [INFO] Building MessageSample 1.0.0 [INFO]   from pom.xml [INFO] --------------------------------[ pom ]--------------------------------- [WARNING] Ignoring incompatible plugin version 4.0.0-beta-1: The plugin org.apache.maven.plugins:maven-compiler-plugin:4.0.0-beta-1 requires Maven version 4.0.0-beta-3 [INFO] Latest version of plugin org.apache.maven.plugins:maven-compiler-plugin failed compatibility check [INFO] Looking for compatible RELEASE version of plugin org.apache.maven.plugins:maven-compiler-plugin [INFO] Selected plugin org.apache.maven.plugins:maven-compiler-plugin:3.13.0 [INFO]  [INFO] --- clean:3.2.0:clean (default-clean) @ MessageSample --- [INFO]  [INFO] --- dependency:3.5.0:copy-dependencies (default) @ MessageSample --- [INFO]  [INFO] --- vscode-car:5.2.75:car (default) @ MessageSample --- [INFO] datamapper directory not found [INFO] ------------------------------------------------------------------------ [INFO] Building Composite Project [INFO] ------------------------------------------------------------------------ [INFO] Processing artifacts in f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\MessageSample\src\main\wso2mi\artifacts [INFO] Processing API definitions in f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\MessageSample\src\main\wso2mi\resources [INFO] Processing connectors in f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\MessageSample\src\main\wso2mi\resources [INFO] Processing registry resources in f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\MessageSample\src\main\wso2mi\resources [INFO] Processing metadata in f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\MessageSample\src\main\wso2mi\resources [INFO] datamapper directory not found [INFO]  [INFO] --- install:2.5.2:install-file (install-car) @ MessageSample --- [INFO] pom.xml not found in MessageSample_1.0.0.car [INFO] Installing f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\MessageSample\target\MessageSample_1.0.0.car to C:\Users\justin\.m2\repository\com\microintegrator\projects\MessageSample\1.0.0\MessageSample-1.0.0.car [INFO] Installing C:\Users\justin\AppData\Local\Temp\mvninstall286000344121606296.pom to C:\Users\justin\.m2\repository\com\microintegrator\projects\MessageSample\1.0.0\MessageSample-1.0.0.pom [INFO]  [INFO] --- synapse-unit-test:5.2.75:synapse-unit-test (synapse-unit-test) @ MessageSample --- [INFO]  [INFO] --- install:2.5.2:install (default-install) @ MessageSample --- [INFO] Installing f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\MessageSample\pom.xml to C:\Users\justin\.m2\repository\com\microintegrator\projects\MessageSample\1.0.0\MessageSample-1.0.0.pom [INFO] ------------------------------------------------------------------------ **[INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time:  2.748 s [INFO] Finished at: 2024-12-09T13:07:09+05:30 [INFO] ------------------------------------------------------------------------ Stopping the Micro Integrator Server SUCCESS: The process with PID 8488 has been terminated.**
Kindly check on this

Hi @ChinthakaJ98  if you don't mind, could you able to check on this further once you are free?

Hi @JustinRaj-S,
We tried to reproduce this issue in a Windows OS but we were unable to reproduce it. May I know whether you are facing this issue intermittently or whether it happens continuously on specific projects?

Hi @ChinthakaJ98 , @JustinRaj-S
I have the same issue.
From my experience, it works again, when I delete

wso2carbon.pid
tmlog0.log
tmlog.lck
xxx.xxx.xxx.xxx.tm0.epoch

and restart VSCode.
It seems to me that the cleanup does not happen correctly when stopping the server from VSCode. I already ruled out file permissions and UAC - the issue remains regardless if I have %mi_home% in my user folder or in the programs folder.

Hi @QuantumSupraLogic
I also deleted the files mentioned above(wso2carbon.pid, tmlog0.log, tmlog.lck and xxx.xxx.xxx.xxx.tm0.epoch) and restarted VSCode , However issue remains same for me

Hi @ChinthakaJ98
For every project I'm creating, facing the same issue. FYI, I tried another tutorial https://mi.docs.wso2.com/en/latest/learn/integration-tutorials/using-scheduled-tasks/ , this also leads to a similar issue, after build success, getting same pop-up "CApp has encountered deployment issues. Please refer to the output for error logs."
Screenshot:

Hi @JustinRaj-S
can you try to close VSCode (all instances) and all Java-processes, then delete the aforementioned files and start VSCode again.

Hi @QuantumSupraLogic
I tried closing visual studio by Ctrl + Shift + W   --> Visual studio closed
and java process by taskkill /f /im java.exe -->  The process "java.exe" not found.
Deleted all aforementioned files under WSO2 MI 4.3.0 distribution.
Re-Opened visual studio code again. Build and Run done in visual studio. as soon as build was successful, getting below ERROR
Micro Integrator Server:
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.046 s
[INFO] Finished at: 2024-12-27T21:26:50+05:30
[INFO] ------------------------------------------------------------------------
[2024-12-27 21:26:55,359]  INFO {org.wso2.config.mapper.ConfigParser} - Overriding files in configuration directory f:\WSO2_Learning\wso2_product\wso2mi-4.3.0\bin\..
[2024-12-27 21:26:55,712]  INFO {org.wso2.config.mapper.ConfigParser} - Applying configurations with deployment configurations
Stopping the Micro Integrator Server
SUCCESS: The process with PID 3168 has been terminated.

Micro integrator:
detecting project 9:25:35 PM
MI project detected
Current workspace path: f:\WSO2_Learning\wso2_product\wso2_workspace\learn_mi\ScheduleTaskTutorial
Project detection completed 9:25:36 PM
Waiting for LS to be ready 9:25:36 PM
LS is ready 9:25:38 PM
[12/27/2024, 9:26:51 PM] [MI Debug] [INFO] Build and copy tasks executed successfully
[12/27/2024, 9:27:07 PM] [MI Debug] [ERROR] Error while checking for Server readiness: connect ECONNREFUSED <IP_ADDRESS>:9201

Still same behaviour unfortunately.


nixos/systemtap: fix and test

Description of changes

stap can run with a --sysroot flag, which allows it to find paths like /boot or /lib/modules within a directory. This allows us to pass a custom sysroot directory, tailored for what systemtap looks for.
Things done

use --sysroot instead of -r
add vm tests

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3163

going ahead and merging this, since stap is broken right now, so no risk of breaking it further


ExcelOpenXmlReader: numbers stored as text

Hi,
I come to a issue that when using the ExcelOpenXmlReader, the numbers formated as text in Excel are always converted to double, ex: the number 0006181(text) is converted to 6181.0(double).
In line 279 there is a verification to see if the format is text:
else if (xf.NumFmtId == 49)
  o = o.ToString();

but the convertion is from the object already converted to double!
Sugestion:
else if (xf.NumFmtId == 49)
   o = _xmlReader.Value;

this will preserve numbers as text, as long as they are formated as text in Excel.

Fixed


TADAbigdataRet chunking by site

Chunks by site list generated by readWQPsummary, rather than sites within each FIPS code.
changed statecode default to "null" to match other inputs
specified startDate and endDate if not populated in inputs (this is required if using readWQPdata()).
Made readWQPsummary a flexible query in case site type or statecode are not included...saves if statements
State code can be an input but not default.
removed objects not needed in future computation (df_summary, sites; save space)
removed temp RDS file creation/reading within package.
added testthat back in that compares TADAdataRetrieval with TADABigdataRetrieval...does not depend upon statecode

Example in documentation does not work (characteristic is required - can we update the error message?):
tada3 <- TADABigdataRetrieval(statecode = "CT")
Error in STUSAB %in% statecode : object 'STUSAB' not found
Called from: STUSAB %in% statecode

Instead of requiring characteristicname , can we make it more flexible, so that statecode, sitetype, or characteristicname (at least 1) could be provided?

@cristinamullin This function is ready for your review and testing. Appears robust on my machine but I am certain fresh eyes will identify weaknesses. Thank you!

It's a great question. I wonder what data submitters see in WQX when they upload a project ID. As a data user, I see the column names in the returned data profiles and it makes sense to me to have the function input match the column name on which I want to query. For example, I would be much more likely to know what a "ProjectIdentifier" input is, rather than "project". Similarly with "ActivityMediaName" rather than "sampleMedia". However, it is interesting that even the WQP browser interface is different. Continuing with these two examples, those fields are termed "Project ID" and "Sample Media" on the page itself. I think whichever we pick, adding documentation of field synonyms across querying platforms will make functions relatively simple to use (e.g. "project input is synonymous with the ProjectIdentifier column returned from the WQP and Project ID field on the web interface").

@ehinman I have another question related to this thread. Do you think it would make sense for TADAdataRetreival and TADABigdataRetrieval to be a single function? Where the chunking is only activated if needed, that is, if the summary service returns over X unique MonitoringLocationIdentifier's?

Interesting idea, and certainly can be done. The only downside I see is that running the summary will slow down the function, especially since we do not have the ability to specify the date range of interest in the summary service. Someone could specify they want one month of data for one characteristic name in one state and it'll pull data for that characteristic name and state over the entire time data are available. It's not likely to take too long, but it will add some time. Another consideration is the prevalence of sites with little to no data, such that they add to the site n count but may not require chunking to successfully return data. What do you think? Would you like me to try this? It would be so nice if there was a webservice that reported the size of a request so one (or a function!) could make a decision on which process to use.


Redirect from App to Homepage when no tree data.

App component breaks if we try to render it before having any tree data. So if user goes directly to App route, kaboom. This avoids that by redirecting to Homepage when user has no tree data yet.

@vincent-czi -- lmk if you need any support before merging this one :)


Are Point3D and Image 0 indexed?

This is not an issue and only a question. I see that the id's for most classes are initialized with a big number. Is this because it is possible to have the id be 0? I am asking this because in the current project I am working on there is no id=0 on any of the classes and was wondering if the id will never be 0 or am I just lucky?

IDs are not indices, they are not ordered and are not guaranteed to be continuous. I think that image and point IDs usually start at 1 but most parts of COLMAP won't complain if they are given a value 0.

For me it works well if you count image and camera from 0, e.g.,:
fidx=0
camera = pycolmap.Camera(model="SIMPLE_PINHOLE", width=image_size[0], height=image_size[1], params=pycolmap_intri_pinhole, camera_id=fidx, )
image = pycolmap.Image(id=fidx, name=f"image_{fidx}", camera_id=camera.camera_id, cam_from_world=cam_from_world)

reconstruction.add_camera(camera)
reconstruction.add_image(image)

However, if you want to add 3D points manually, they start from 1.
for vidx in valid_idx:
    reconstruction.add_point3D(points3d[vidx], pycolmap.Track(), np.zeros(3))

(Pdb) reconstruction.points3D[0]
*** KeyError: ''
(Pdb) reconstruction.points3D[1]
Point3D(xyz=[-2.73191, 8.97091, 32.4668], color=[0, 0, 0], error=-1, track=Track(length=2))


Aggregate functions are not supported in Kundera

I'm using cassandra 3.11.0 and it looks that aggregate functions are not supported.
A simple query like:
SELECT MAX(field) FROM Table t WHERE id = :value
is translated to CQL by kundera as
SELECT * FROM "Table" WHERE "id" = value
and getSingleResult() returns an Entity object instead of a field.
Are there any plans to add support for standard aggregate functions?

Reference - https://github.com/Impetus/Kundera/pull/983


Switch clipboard crate to copypasta

Currently the imgui-example code uses the clipboard crate, which works fine, but hasn't been touched in about 3 years currently and lacks support for Wayland
There is a fork actively developed for by the alacritty project which is more or less a straight switch out
https://github.com/alacritty/copypasta
Only slight ~issue is the Wayland integration requires access to the window object (e.g &glutin::window::Window) so it ties the integration code to a specific, whereas X11 is more lax so doesn't require this

There is also an issue and a MR which fixes many security issues that is not getting merged due to the crate being abandoned.

It would indeed be good to replace the example, because I assume (I did at least) use it as a starting point.
I'll submit a MR asap.

Thanks for the info.
I checked and x11-clipboard can't be totally unmaintained, they merged a PR yesterday. I give it to you though, it was the first since July 2022.
Anyway, it could make sense to replace it by arboard. One thing were to be careful is to disable the default features as it pulls in even more crates to support images.

You are right, x11-clipboard is not totally unmaintained. It is noted in the provided links that it is primarily in maintenance mode and depends on xcb with known unsoundness.

The more I dig in, the crazier it gets! As of copypasta 0.8.2, all of the mentioned issues with x11-clipboard have been fixed. It no longer depends on the unsound xcb crate.
I suspect using copypasta is the right thing to do until winit adds clipboard support itself.

Now merged - info above is interesting, thanks, wasn't aware of arboard nor the plans to integrate clipboard handling directly into winit :partying_face:


adding in all of the RDS engine and EBS volume types

Coverage increased (+0.4%) to 51.047% when pulling afe7cd1f6384741c7b051c86e769504063e4fa81 on db_and_volume_types into 8dec1240e42aa4c6c68d892b2d4e8a355aba650e on master.

Where'd io2 come from?  http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html links to http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateVolume.html for the list of types.  I don't see io2 listed.

Honestly I have no idea. My guess is it was a random typo back in the day that is long overdue to fix.

Oh, duh.  That's why you're removing it.  I wasn't even paying attention to the colors, was thinking it was being added as a new thing.  Mind's still on vacation a bit, I guess.  This one LGTM.


keepa.com - broken on Big Sur with AdGuard nightly

@adguard-bot commented on Fri Oct 30 2020
Issue URL (Incorrect Blocking)
https://keepa.com
Comment

The website works fine when AdGuard is turned off globally, but disabling AdGuard in the browser for this specific website (adding to user filter) does not work.
Website also works fine in Chrome when AdGuard is enabled globally.

Screenshots

Screenshot 1

Screenshot 2

System configuration

Information
value

AdGuard product:
AdGuard for Mac v<IP_ADDRESS>1 nightly (CL-1.7.134)

Browser:
Safari

Stealth mode options:
Hide your search queries, Send Do-Not-Track header, Strip URLs from tracking parameters, Self-destructing first-party cookies (), Block WebRTC, Block Java

Filters:
Ad Blocking: AdGuard Base, AdGuard Mobile Ads, EasyList, Peter Lowe's BlocklistPrivacy: AdGuard Tracking ProtectionSocial Widgets: AdGuard Social MediaAnnoyances: AdGuard Annoyances, Adblock Warning Removal List, I don't care about cookiesSecurity: Online Malicious URL Blocklist, Spam404, NoCoin Filter ListOther: AdGuard DNSLanguage-specific: AdGuard Russian, AdGuard German, AdGuard Japanese, AdGuard Spanish/Portuguese, AdGuard French, EasyList China, EasyList Czech and Slovak, EasyList Italy, Official Polish filters for AdBlock, uBlock Origin & AdGuard

@Alex-302 commented on Tue Nov 03 2020
Cannot reproduce on macbook with the latest AdGuard.
Which macos version?

@dalDevelo commented on Tue Nov 03 2020
macOS 11.0.1 Beta (20B5012d)

@Alex-302 commented on Tue Nov 03 2020
Big Sur has a lot of problems.
Please check the latest AdGuard nightly
http://agrd.io/mac_nightly

@dalDevelo commented on Wed Nov 04 2020
I believe I am already on the latest night build: AdGuard for Mac v<IP_ADDRESS>3 nightly. The ticket was opened whilst on the previous version, however, the issue remains in the latest version.

@Alex-302 commented on Wed Nov 04 2020
Ok, please check with disabled filters, but enabled protection.

@dalDevelo commented on Wed Nov 04 2020
Thanks for reopening the issue @Alex-302
Turning off all the filters does not resolve the issue. I've gone through all the tabs in settings and I have found the culprit. Unchecking 'Automatically Filter Applications' under the network tab fixes the issue. re-enabling causes the issue to reoccur.
I also turned off all the (main) setting in the other tabs, such as stealth mode etc, but they didn't resolve the issue.

Let's try addressing it asap, the release is close

Can't reproduce, macOS 11.0.1 Beta (20B5012d), Safari 14.0.1 (166<IP_ADDRESS>.4), AG <IP_ADDRESS>7 nightly.
@dalDevelo, if you're still encountering this problem, we'll need debug logs to troubleshoot it: please enable debug logging (Advanced -> Logging Level), reproduce the issue, then export (Advanced -> Export Logs...) the logs. Send the file to<EMAIL_ADDRESS>Mention the Github issue number and the exact time when the issue was reproduced.
Btw, unchecking 'Automatically Filter Applications' practically means disabling AdGuard, so that is not a solution :)

@ngorskikh Yes I still have the issue in the latest nightly build <IP_ADDRESS>7. I've just sent the requested logs over.

@dalDevelo can you also please tell if it works in browsers other than Safari, and have you tried emptying the caches (Safari -> Preferences -> Advanced -> Show develop menu, then Develop -> Empty caches)?

@ngorskikh I have tried emptying the caches, issue remains. Yes, this works in Chrome (latest version) with AdGuard enabled, I mentioned this in the comment section of the original report.

Not sure if this is any use, but this is the console error message I get when trying to access Keepa.com with AdGuard enabled

Just tried again on the latest macOS beta release candidate 2 11.0.1 (20B28) and the issue remains.

Hello there @dalDevelo!
Unfortunately, we cannot solve your issue without cert.db.
Could you send it to us?
You can find it here:
~/Library/Group/Containers/TC3Q7MAJXF.com.adguard.mac/Library/Caches/com.adguard.mac.adguard/CertCache/SSL/cert.db
We are waiting for a mail from you on<EMAIL_ADDRESS>:)

@dalDevelo it looks like a Safari or NetworkFramework + NetworkExtension bug, the only problem is we can't reproduce it on our end :( Can you see if WebSocket in Safari with AdGuard works on other sites, for example: https://www.websocket.org/echo.html ?

@ngorskikh I am also unable to get web socket to connect on https://www.websocket.org/echo.html in Safari with AdGuard enabled. Notably, even if I turn off the AdGuard extension in the Safari settings, it still doesn't work, I need to turn off AdGuard from the main switch in the AdGuard app, or by turning off 'automatically filter applications' in the AG network preferences.
There is nothing out of the ordinary with my network settings. IPv6 is enabled and set to automatic config.
I will send the console log over via email, let me know if you need this in a different format.

Probably no surprise here, but issue remains on the release (non-beta) version of macOS 11.0.1 (20B29)

@ngorskikh any ideas?

Just to follow up on this, I think this may be an interoperability issue with AdGuard / Little Snitch. I have tried troubleshooting this further and if I disable LS from the macOS network panel via the 'make service inactive' option, the Keepa.com website also loads in this situation (even with AG enabled). However, the issue is not resolved if I disable the LS network filter via the LS settings. Either AG or LS need to be disables at the global / OS level for Keepa.com to work.
For info, I am not blocking any connections with Little Snitch, even when it is enabled, it is just used to capture and monitor outgoing network traffic from my machine.

Oh, so you're using Little Snitch. This is important indeed, thank you!

Reported incompatibility with LittleSwitch to Apple:
FB8918126
https://developer.apple.com/forums/thread/667962

I’m having this issue with Keepa’s Chrome Extension on Amazon. AdGuard version <IP_ADDRESS>3 nightly (CL-1.8.138, DNS-1.6.14). I’m on nightly for M1 support. Turning off AdGuard fixes Keepa.

(Fixed this for now by adding keepa.com to the whitelist.)

Highly likely fixed by core/pull-requests/2477

Turns out excluding keepa.com doesn’t actually fix it. At least, these rules don’t help:
@@||keepa.com^$important,document
@@||dyn.keepa.com^$important,document

@jace Try adding an HTTPS exclusion instead, until the fix is released.

@ngorskikh Looks like that worked.


How can I use with tsx|jsx ?

On production build, when i use with tsx is not build class on tsx.

Please provide a reproduction link and reopen the issue :)


README.md updates

Updated section Which Manipulation is required for which test
Checklist
The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

Adherence to coding conventions

[x] Pull Request Assignee
[ ] Reviewer

Adherence to javadoc conventions

[x] Pull Request Assignee
[ ] Reviewer

Changelog update (necessity checked and entry added or not added respectively)

[x] Pull Request Assignee
[ ] Reviewer

README update (necessity checked and entry added or not added respectively)

[x] Pull Request Assignee
[ ] Reviewer

config update (necessity checked and entry added or not added respectively)

[x] Pull Request Assignee
[ ] Reviewer

SDCcc executable ran against a test device (if necessary)

[x] Pull Request Assignee
[ ] Reviewer

The GetRemovableDescriptors manipulation was renamed to GetRemovableDescriptorsOfClass.
When updating the table, we should change that as well.

The GetRemovableDescriptors manipulation was renamed to GetRemovableDescriptorsOfClass. When updating the table, we should change that as well.

done


Timeline docs link to review.docs.microsoft.com page

The link shown in the section about the timeline which reads "To learn more, see Enable rich-text editor for notes in timeline." contains a link to the review.docs.microsoft.com page, which normal readers don't have access to.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c057977-38e8-660d-87b7-44e141d6f368
Version Independent ID: 0e4045ed-5c1b-9e59-9045-0f70141a7230
Content: Learn the basics of the Customer Service Hub app
Content Source: ce/customer-service/customer-service-hub-user-guide-basics.md
Service: dynamics-365-customerservice
GitHub Login: @lalexms
Microsoft Alias: laalexan

Thank you for helping identify the inaccuracy, @AndrewBibby. The Learn the basics of the Customer Service Hub app topic has been updated with the correct link.
Please let know if you have any questions.
Best regards,
Neeraja

Closing this GitHub issue as the content has been corrected, @AndrewBibby .
Thank you.
Neeraja


Finalised token implementation for the login

@jtarchie
@vito
@chendrix
Please review & merge.
This is linked to https://github.com/concourse/fly/pull/185 and needs to be merged first.
This PR enables the ATC to return the following structure on api/v1/teams/:team_name/auth/methods:
{
        "auth_url": "http://<IP_ADDRESS>:8080/auth/github?team_name=openCloak",
        "display_name": "GitHub",
        "token_url": "http://<IP_ADDRESS>:8080/auth/github/token?team_name=openCloak",
        "type": "oauth"
}

Note the added token_url

Can I help you somehow with the review of this PR?

@Chumper Merged! Thanks for the PR!


Translate README to zh-CN (China)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Kucashu sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


onNotification method get called in background but notification not coming in notification list

Hi team,
In my case notification is coming from connectycube and even my onNotificaiton method get fire when the app is in background but notification didn't popup and not coming in notification list.
This is what i am getting in onNotification:
{
data:
badge: "1"
dialog_id: "60574552ca8bf468829098f5"
message: "You have 4 new messages"
user_id: "3791768"
proto: Object
finish: ƒ finish()
foreground: false
id: "-414371205"
userInteraction: false
}
I am think the notification data is wrong and due to which notification not get popup, because when i am using this api "https://fcm.googleapis.com/fcm/send" notification get popup in my application .

Please, find solution in this issue
https://github.com/ConnectyCube/connectycube-reactnative-samples/issues/206


Creating a UI in the 3d viewer for writing and changing the data in the schema

Would be great to add an option for the 3dViewer for editing the data in the schema so in such way the viewer could be used for managing information.
In this example: https://3dviewer.net/#model=https://raw.githubusercontent.com/IliyaMuzychuk/Dotbim/main/studios.bim I modeled a few of artists' studios for my friend as an idea to manage it online through dotbim. If we could add or edit the information of each mesh in the viewer, it can turn into a powerful tool for studio management (And perhaps and other asset management) that doesn't require expensive proprietary software and is accessible by everyone and anywhere.  Conceptually it can bring the digital twin world to many other markets and be much more user friendly than BIM360 and similar products.
Would love to contribute, just I don't have the best skillsets for UI, but in any other way.
Thanks, and excited to see dotbim! I really think it could turn into amazing project with much more use cases than just the AEC!

@kovacsv

Adding editing features to Online 3D Viewer is a topic that comes up more and more often. Mostly the requests are about modifying materials, but modifying data makes a lot of sense, too (and probably it's even easier to implement). I didn't have the capacity so far to step on this road, but maybe one time in the future. 🙂

Data editing can convert this viewer into a strong tool and open many use cases, even outside of AEC imo. Would it be possible to access the viewer js code to see the complexity of creating a UI feature for it? I won't mind managing it and getting someone to assist in it. Just not a front-end savvy guy :(

It's open source. 🙂
https://github.com/kovacsv/Online3DViewer

Thanks! Embarrassed to be a noob here on github but will get with my guy on it and see what we can do :)

Ya a workaround with excel is doable and might fit the purposes I have for now. Thanks.
But would be cool to do it through a viewer, I mocked up a quick figma for it here: https://www.figma.com/file/dMXD0vmnwDCheZBPXIx0pr/Viewer-addition?node-id=0%3A1&t=DYDrayVoSV8Qtt6Y-1


addon vela-workflow upgrade error：exists but not managed by any application now

Describe the bug

addon vela-workflow upgrade error：exists but not managed by any application now
0.3 to 0.4.0
~ % vela addon status vela-workflow
vela-workflow: enabling
==> Installed Clusters
[local]
==> Registry Name
KubeVela
diagnose addon info from application addon-vela-workflowAbout:
Name:      	addon-vela-workflow
Namespace: 	vela-system
Created at:	2022-11-07 17:28:26 +0800 CST
Status:    	workflowFailed
Workflow:
mode: DAG-DAG
finished: true
Suspend: false
Terminated: true
Steps

id: jl8z2wr3j3
name: workflowrun-crd
type: apply-component
phase: failed
message: run step(provider=oam,do=component-apply): Dispatch: pre-dispatch dryrun failed: Found 1 errors. [(cannot apply ApplyOption: CustomResourceDefinition /workflowruns.core.oam.dev exists but not managed by any application now)]
id: 3h292hpyc2
name: vela-workflow
type: apply-component
phase: failed
message: run step(provider=oam,do=component-apply): Dispatch: pre-dispatch dryrun failed: Found 1 errors. [(cannot apply ApplyOption: Deployment vela-system/vela-workflow exists but not managed by any application now)]
id: 95s9lqlzfx
name: vela-workflow-additional-privileges
type: apply-component
phase: failed
message: run step(provider=oam,do=component-apply): Dispatch: pre-dispatch dryrun failed: Found 4 errors. [(cannot apply ApplyOption: ServiceAccount vela-system/vela-workflow exists but not managed by any application now), (cannot apply ApplyOption: ClusterRoleBinding /vela-workflow:manager-rolebinding exists but not managed by any application now), (cannot apply ApplyOption: Role vela-system/vela-workflow:leader-election-role exists but not managed by any application now), (cannot apply ApplyOption: RoleBinding vela-system/vela-workflow:leader-election-rolebinding exists but not managed by any application now)]

Services:

Name: workflow-helm
Cluster: local  Namespace: vela-system
Type: webservice
Healthy Fetch repository successfully, Create helm release successfully
No trait applied

KubeVela Version

CLI Version: v1.7.0
Core Version: 1.7.0
GitRevision: git-8ef2513
GolangVersion: go1.19.4

@nicoloxu There is CRD in the cluster. Do you install the workflow CRD in another way?

@wangyikewxgm Should we add some policy for the vela-workflow addon same as the fluxCD?

@nicoloxu There is CRD in the cluster. Do you install the workflow CRD in another way?

I only follow the document。use vela cli：vela install -v 1.7.0


Not able to indent systemverilog files properly

Steps to reproduce

Open a system verilog file with .sv extension
Select all, ggVG
Indent all with, =

The indentation gets messed up. Whereas emacs perfectly indents the same code.
file_indented_by_vim.sv.txt
Expected behaviour
This is the correct indentation, based on emacs.
file_indented_by_emacs.txt
Version of Vim
8.2
Environment
OS: Ubuntu 20.04 [WSL]
Terminal: Windows Terminal
$TERM: xterm-256color
$SHELL: /bin/bash
BASH: 5.0.17
Logs and stack traces
No response

Same issue exists in neovim.

please try to contact the maintainer of this file: https://github.com/vim/vim/blob/master/runtime/indent/verilog.vim

@chrisbra Are you sure that indent script is the issue? Because, there is also systemverilog.vim that is the syntax and filetype I using.
Also verilog and systemverilog both have similar syntax. I tried setting the syntax and filetype to verilog. The issue still remains. I think both indent files have this issue.
Should I contact the systemverilog.vim maintainer or verilog.vim?

ah, I don't know verilog and systemverilog at all. I just assumed that would be the correct one. In that case, try to contact the maintainer of the systemverilog indent script.

@raveensrk Thank you for contacting us. I have checked and corrected the problem.

indent/systemverilog.vim

Could you please try it once.
If there seems to be no problem, I will issue a PR.

@Kocha Thank you for the fix. All the issues I faced were solved. You can proceed with the PR.
Not sure if i did the check properly. This is what i did,

Replaced the /usr/local/share/vim/vim82/indent/systemverilog.vim in the $VIMRUNTINE path with your indent file.

Opened the

and Indented with ggVG=

I did not check with my actual code base. I will check this indent fix there and get back to you.
The only difference between emacs and vim this the \ifndefindendation. Vim indents everything after`ifndef` where emacs doesnot. I do not know which is the right way to indent this. So I will let you decide.
Left is vim with the new indent file and the right is emacs.

There is some misalignment going on in multiline comments. I will get back with example code tomorrow.

@Kocha There is some junk commented code in my code base with a mix of multiline and single line comments which is causing some problems. Can you take a look at this as well? Thanks.
Left is Vim and Right is Emacs

I have attached the files below.
fix_systemverilog.vim.zip

@raveensrk Could you please try this?

indent/systemverilog.vim

Regarding the ifndef indentation, I have added an option.
Once this is set, there will be no indentation.

b:systemverilog_indent_ifdef_off

Hi @Kocha, I tried the above fix and some above-mentioned problems went away. I also tried the b:systemverilog_indent_ifdef_off option. That also worked fine.
In systemverilog file buffer, To set the ifdef indent off,
let b:systemverilog_indent_ifdef_off = 1
To revert this change, I used,
unlet b:systemverilog_indent_ifdef_off
Both worked file. Let me know if this is the correct way to test this. Could this option be inverted instead? Let the indent option be off by default and let the user decide to switch it on. I am suggesting this based on Emacs implementation taken as reference.
I also tested this on my codebase, and it looks like there are few more issues when single line comments are used after the multiline comments. For example,

(Same as before, left is vim with the new indent file and right is Emacs.)
I have attached the files below.
fix_systemverilog.vim.3.tar.gz

Hi @raveensrk
I think I'll go default ifdef indent on.
Because that is what the example code in the IEEE1800 22.6.

Hi @raveensrk,  Sorry to keep you waiting.
Next... Could you please try this?

indent/systemverilog.vim

Hi @Kocha, I checked the fix, and it worked. There are a few other places where the indentation is off again.

fix_systemverilog.vim.4.tar.gz

@Kocha Sorry for the delay. I had to test this out a bit. The previous reported issue fixed. But there are a few more issues that I discovered.

fix_systemverilog.vim.5.tar.gz

Hi @raveensrk Thank you for response.

top.sv : let b:systemverilog_indent_modules=1 option.
env.sv

Not support uvm macro indent.
Bugfix a few. -> indent/systemverilog.vim
But, task close parenthesis is a little difficult, please give me some time.

HI @raveensrk
I tried to solve task close parenthesis , but I am not sure if this is the right way to do it.
Could you please try this?

indent/systemverilog.vim

Hi @Kocha, checked the fix, it works fine. Could I request one more update to the indentation? The ability to break argument into multiple lines for print statements would be a nice addition. I will let you decide.

fix_systemverilog.vim.6.tar.gz
I think after this update, we can close this issue and do a pull request. Meanwhile, I will be using this indentation file, if I see more issues I will reopen this issue and post the issues. I think most bugs I faced were fixed. Thanks for the help.

@raveensrk Sorry for the wait.
Updated the indent/systemverilog.vim file.

indent/systemverilog.vim

If there seems to be no problem, I will issue a PR.

Thanks, the update looks good to me. Issue a pr @Kocha lets merge it.

Hi, @raveensrk I sent to PR and closed.
If all is well, please close the Issue.
Best regards.

Thanks @Kocha. Closing this issue.


Adding packet limit to merged pcap

Limit the Number of packets in the final merged pcap
Overview:
This PR resolves an issue where the user can limit the number of packets in the final merged pcap without any other command-line utility
Changes Made:

Added a new flag -c which takes a positive integer as an argument
based on this flag we limit the number of packets that are being written in the final merged pcap

Testing:

Unit tests covering new functionality.

I updated the review, let me know if it looks good

Thanks!


Output formats for pip-audit

Apart from supporting a standard SBOM format (#3), pip-audit should have at least two output formats for the MVP:

A human-readable format for display on a terminal or logs
A JSON format for interpretation by other programs

I imagine that this is going to look like:
class VulnerabilityFormat(ABC):
  def format(self, Dict[Dependency, List[Vulnerability]]) -> str:
    ...

And we can toggle via the CLI options similar to how we control vulnerability services.


Option to set root folder? [request]

It looks like the main bookmark root folder from which the popup "Use existing folder" list is taken is from Firefox's default Bookmarks Toolbar. Perhaps have an option to change this?

@spiralsam That's correct: we code currently looks at the default Bookmarks Toolbar, for simplicity. What would you like the user be able to select instead?

It would be great to be able to set the root folder as Bookmarks Menu instead of Bookmarks Toolbar since the Menu is where I store the majority of my bookmarks and I only use the Toolbar for very frequently accessed bookmarks.

Thanks for the additional vote on this. I'll look into this.

I would love to see this as well!

Thanks for the additional vote. I admit not having as much time as I used to, but I'll do my best.

I guess most people would select the 'Bookmarks Menu' as base folder ... I currently use the recently introduced 'Other Bookmarks' folder (browser.toolbars.bookmarks.showOtherBookmarks) ... but maybe it is best to let the user select an arbitrary folder :wink:


Sharepoint migration tool error showing "failed to submit the job to server" while migrating the data from file server

i was migrating the Data from the file server and getting error that failed to submit the job to server.
Data size only 12.08 GB with 4335 files
please help on this

@Amitosh89 - it is great we have the product team providing info too. This is an issue list for documentation and it is totally fine to open any issue here but I don't want your issue to go stale in this documentation issue list.
If you haven't already got this resolved, the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP.
Based on outcome let me know if it is something that can be called out in the docs.
Here is a quick video on opening a ticket: https://www.youtube.com/watch?v=puuOy0sEg1Y
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.


Fixed sample synchronization

I was debugging why the samples 01, 02, and 03 where hanging on either close or resize when the cpu tick-rate was too high on moltenVK. Basically the 'Context.Device.WaitIdle();' would seemingly never return. After digging it seemed that the gpu was capping at 60hz (present mode FiFo) but the cpu loop would run at 1000+hz, and would keep queuing up commands in the graphicsQueue. Issue is also discussed here: https://github.com/KhronosGroup/MoltenVK/issues/95. To fix this i've added syncing using fences according to a SaschaWillems sample (https://github.com/SaschaWillems/Vulkan/blob/master/examples/triangle/triangle.cpp)

Yeah very interesting, on my windows desktop it was actually blocking on the 'PresentKhr' so there was no problem but on mac with mvk it was not blocking on that. According to that issue-thread on the mvk repo its not defined by the standard if it should block or not.

Thanks for the info. Good to know about the standard.


[JS] Others : Data Types in JavaScript

Description 📜
I've updated the already made README file for JavaScript Data Types with some additional contents.
Fixes #73

Type of change 📝

[ ] Audio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[x] Documentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev (Flutter, Java, Kotlin)
[ ] Backend Dev (Java, .NET, Python)
[ ] C/CPP
[ ] Competitive Programming
[ ] Cyber Security
[ ] DSA
[ ] Database
[ ] Datascience with Python
[ ] Datascience with R
[ ] Frontend Dev HTML/CSS/JS
[ ] Frontend Dev React/Angular/Vue
[ ] Golang
[ ] Interview Prep
[ ] Java_Domain
[x] JavaScript
[ ] MERN
[ ] Machine Learning
[ ] Open Source
[ ] Python_Domain
[ ] Rust
[ ] Statistics
[ ] UI/UX

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@paramsiddharth  Sir, as told by you I've updated the already merged PR by Aniket with some additional contents, Please review this. And please remove the other domain labels i don't know how it got added.

@paramsiddharth Sir, as told by you I've updated the already merged PR by Aniket with some additional contents, Please review this. And please remove the other domain labels i don't know how it got added.

@dakshsethi @Creatoon @s4-2 Mentors! Please review this.

@paramsiddharth Sir, now review

@paramsiddharth @Creatoon  Sir, made the changes now review it.

LGTM


chore(deps): update terraform terraform-ibm-modules/observability-agents/ibm to v2

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/observability-agents/ibm (source)
module
major
1.30.2 -> 2.0.0

Release Notes

terraform-ibm-modules/terraform-ibm-observability-agents (terraform-ibm-modules/observability-agents/ibm)
v2.0.0
Compare Source
Features

fully remove support for Log Analysis agent. Log Analysis is a deprecated service and has been replaced by IBM Cloud Logs (#411) (adf3256)

BREAKING CHANGES

No longer possible to provision the Log Analysis agent

v1.30.3
Compare Source
Bug Fixes

deps: update default logs agent version to 1.3.1 (#410) (4c4bb23)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 3.34.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Implemented the cancellation of discovery request

Description
Implemented the changes to cancel a discovery request through the design mode client

@cltshivash : Would be great to have this in whenever you think its ready.

@singhsarab , @cltshivash : Wondering if we could update the test platform insertion on the VS side to include this change.

Addresses issue #149


Retrieval error

bookcut, version 1.3.3
Error when retrieving a book. Copy of entire activity.
di@MacPro downloads % bookcut search -t "Theory and Practice of Contrast: Integrating Science, Art and Philosophy"

| __ )  ___   ___ | | / |   | |
|  _ \ / _ \ / _ | |/ / |  | | | | __|
| |) | () | () |   <| || || | |
|/ _/ _/||_\_,|_|

Welcome to BookCut! I'm here to
help you to read your favourite books!

Searching for: Theory and practice of contrast: integrating science, art and philosophy
Connected to: http://libgen.li/
Author(s)  ... Extension
1  Mariusz Stanowski  ...       pdf
[1 rows x 8 columns]
Please enter a number from 1 to 1 to download a book or press "C" to abort search: 1
Connected to: http://libgen.li/
First Link: http://libgen.li//ads.php?md5=a62d7fc594b25398b9ebad673a40ae5c
Traceback (most recent call last):
File "/usr/local/bin/bookcut", line 8, in
sys.exit(entry())
File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1137, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1062, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1668, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.9/site-packages/click/core.py", line 763, in invoke
return __callback(*args, **kwargs)
File "/usr/local/lib/python3.9/site-packages/bookcut/bookcut.py", line 130, in searching
details = link_finder(link, mirror_used)
File "/usr/local/lib/python3.9/site-packages/bookcut/search.py", line 40, in link_finder
filename = soup.find('input')['value']
TypeError: 'NoneType' object is not subscriptable

Thanks!

Issue Resolved.
Please update to BookCut 1.3.6


Consider an AzureAD middleware? (Multi tenant)

From @mbeckenbach on November 22, 2014 19:44
An azure ad middleware (that supports also multi tenant or mixed mode with local users) should be as important as the facebook login.
.Net is still mostly used in enterprise. Enterprises need something made for enterprises. not facebook.
Please extend your development, documentation and support for your own authorization technologies.
On MyGet there are already vnext packages for google, facebook and co. but nothing for windows auth or azure ad. Even on "vLast" azure ad via oauth / open id is not really good documented or implemented until today.
Copied from original issue: aspnet/Identity#267

What is the status on being able to treat Azure AD like any other OAuth provider as @Tratcher demonstrates above?
It seems odd to me that Azure AD provides OAuth endpoints but I can't seem to get the middleware to work with it.

@jaredcnance Any reason you can't use the OpenIdConnect middleware?


Update Dependencies

I've updated dependencies to remove as many deprecated packages as possible. There's still 2 outstanding deprecated packages from a dependency of a dependency:
npm WARN deprecated<EMAIL_ADDRESS>This is probably built in to whatever tool you're using. If you still need it... idk
npm WARN deprecated<EMAIL_ADDRESS>Please use @jridgewell/sourcemap-codec instead
acorn-dynamic-import is required by @rollup/plugin-buble (buble):
+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| | +--<EMAIL_ADDRESS>deduped
| | +--<EMAIL_ADDRESS>deduped
| | +--<EMAIL_ADDRESS>| | `--<EMAIL_ADDRESS>deduped
| +--<EMAIL_ADDRESS>| | `--<EMAIL_ADDRESS>| |   `--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| | +--<EMAIL_ADDRESS>| | | `--<EMAIL_ADDRESS>deduped
| | +--<EMAIL_ADDRESS>| | | `--<EMAIL_ADDRESS>deduped
| | +--<EMAIL_ADDRESS>| | +--<EMAIL_ADDRESS>| | | +--<EMAIL_ADDRESS>| | | | `--<EMAIL_ADDRESS>| | | |   `--<EMAIL_ADDRESS>| | | +--<EMAIL_ADDRESS>| | | `--<EMAIL_ADDRESS>| | |   `--<EMAIL_ADDRESS>| | +--<EMAIL_ADDRESS>| | | `--<EMAIL_ADDRESS>deduped
| | +--<EMAIL_ADDRESS>| | `--<EMAIL_ADDRESS>| |   +--<EMAIL_ADDRESS>| |   | `--<EMAIL_ADDRESS>deduped
| |   +--<EMAIL_ADDRESS>| |   +--<EMAIL_ADDRESS>| |   +--<EMAIL_ADDRESS>| |   | `--<EMAIL_ADDRESS>| |   +--<EMAIL_ADDRESS>| |   | +--<EMAIL_ADDRESS>| |   | `--<EMAIL_ADDRESS>| |   `--<EMAIL_ADDRESS>| `--<EMAIL_ADDRESS>deduped

And sourcemap-codec is required by @babel/core, @rollup/plugin-buble, and @rollup/plugin-commonjs dependencies of a dependency.

Thank you, @jammerxd.
However, after reviewing, I noticed that Webpack stopped working.
I had to switch to node@18 due to the following error:
error<EMAIL_ADDRESS>The engine 'node' is incompatible with this module. Expected version '>=18.0.0'. Got '16.20.2'

I've refactored this module to use the latest libraries, so you can now use v2.0.0 to avoid those issues.

Yes that's right, it does require a node upgrade to use.


🐛 Broken useImportType fix when "quickfix.biome": "explicit" is enabled

VS Code version
1.87.2
Extension version
2,2,2
Biome version
1.6.3
Operating system

[X] Windows
[ ] macOS
[ ] Linux

Description
When there are many type imports, autofix on save in vscode can be buggy
Steps to reproduce
When useImportType rule is enabled, and vscode extension is configured with "quickfix.biome": "explicit", try to edit following code:
import fs, { BigIntOptions, ReadStream, lchownSync } from "fs";
import { Blob, File, Buffer} from "buffer"

const a: fs;
const b: BigIntOptions;
const c: lchownSync;
const d: Blob;
const e: File;

The result will be
import type fs from "fs";
import { type type BtIntOptions, ReadStream, type lchownSync } from "fs"
import { Blob, File, Buffer} from "buffer"

const a: fs;
const b: BigIntOptions;
const c: lchownSync;
const d: Blob;
const e: File;

You can continue pressing ctrl+s, and the code will become more and more broken. The issue seems to be exacerbated the more you mix imports that are supposed to be types and are not supposed to be them.
Expected behavior
Cli seems to be applying type to imports correctly. Vscode extension should behave like cli
Does this issue occur when using the CLI directly?
No
Logs
No response

Duplicate of #1550. I just tested your code and this will be fixed in #2237.

@Sec-ant , was it supposed to be fixed in 1.6.4? While it's certainly better now, the code above is still broken after format
import type fs from "fs";
import { type BigIntOptions, lchownSync }type  from "fs";
import { type Blob, type File, } from "buffer"

const a: fs;
const b: BigIntOptions;
const c: lchownSync;
const d: Blob;
const e: File;

@Sec-ant , was it supposed to be fixed in 1.6.4? While it's certainly better now, the code above is still broken after format
import type fs from "fs";
import { type BigIntOptions, lchownSync }type  from "fs";
import { type Blob, type File, } from "buffer"

const a: fs;
const b: BigIntOptions;
const c: lchownSync;
const d: Blob;
const e: File;

I added a demo to show this is fixed in https://github.com/biomejs/biome/pull/2237. I don't see any issues when quickfix.biome is enabled, do you have other settings (maybe formatting) involved?

Wait, I can reproduce the issue... I don't know why it works well on that PR branch... please give me some time to debug. 😢

Thank you!


Np 47131 prevent persistence of invalid role names

We had a case where "old" role has still been attached to user in NVA. It caused that user had access rights we did not know about, cause role and all belongings access rights have not been removed/ updated when we updated user roles via api.
To fix this case and all future cases we decided to make RoleName to enum, so all unknown values will fail on serialization.

Since roleName has been string before, had to update a lot of tests.
RoleName is still stored as String in database and all enum values have the same role names as before.

From now we will end up with:
java.lang.IllegalArgumentException:
Unable to convert string value 'Curator' to enum type 'class no.unit.nva.useraccessservice.model.RoleName'
And return internal server error via api.
Before:
Not longer "existent" role has been served via api and user got granted access rights to given role:
{
    "rolename" : "Curator",
    "accessRights" : [ "MANAGE_PUBLISHING_REQUESTS", "MANAGE_OWN_AFFILIATION", "MANAGE_DOI", "MANAGE_RESOURCES_ALL", "MANAGE_RESOURCES_STANDARD" ],
    "type" : "Role"
  }

Too long, didn't read. (I am sure it just a lot of refactor from a string to enum so its fine).
Quick question what will happen to a user that has one of the legacy userRoles when they log in now? Do we need to wash our databases before we roll this to prod?

All "old" roles will be removed from users.


Upgraded to work in Ghost 1.8.5

Fixed issues when importing the theme in latest version of Ghost (1.8.5).
Unlike the other 4 similar pull requests, this one only changes files in the src folder. I have tested running a Grunt build and then using the generated files from build and that works fine too.

Closed in favor of #187