stage1: remove --pid-file patch from systemd-nspawn

Instead of asking systemd-nspawn to write its "pid" file, rkt can write
the parent pid "ppid". Then, update getPID() to get the pid file from
/proc/$ppid/task/$ppid/children. In this way, we don't need to patch
systemd-nspawn.
getPID() is able to read both the "pid" file and the "ppid" file, so the
command "rkt status" or "rkt enter" will work when attempted against a
pod started with an older version of stage1.
See also #885.

It doesn't work for me.
It seems /proc/$pid/task/$pid/children needs CONFIG_CHECKPOINT_RESTORE enabled in the kernel. Unfortunately it's disabled in my distro (Arch) because it depends on CONFIG_EXPERT :disappointed:
I commented on the (relevant archlinux bug)[https://bugs.archlinux.org/task/43088#comment135546] to try to get it enabled.

Is it acceptable to break support for kernels that don't have CONFIG_CHECKPOINT_RESTORE? It is enabled in Debian, Fedora, Ubuntu, CoreOS, etc. but not Arch.
As Iago said, this option is strongly recommended for running systemd and rkt definitely needs some kernel options (see #918) but I am not sure what to do for Arch users...

I rebased this branch after #919 got merged. I should still address the issues mentioned above (support for Arch? ABI?)

My inclination is that it might make sense to block this on being in Arch (as a somewhat arbitrary benchmark for its ubiquity). Is it worth pinging kernel to see if it's still strictly necessary to gate this behind CONFIG_CHECKPOINT_RESTORE ?

Is it worth pinging kernel to see if it's still strictly necessary to gate this behind CONFIG_CHECKPOINT_RESTORE ?

I asked them:
http://permalink.gmane.org/gmane.linux.kernel.api/11370

@vcaputo @yifan-gu : I rebased this branch and added a new commit which changes the logic you implemented in #826 (race on pod.getPID). I am trying to move the pid file code back into stage1 so that it would be an implementation detail of stage1 and it would not need to be described in the Stage1 ACI implementor's guide. Other stage1 such as ones based on KVM might not have a process leader for the container.
There are a couple of TODO in my commit that I have not yet addressed, but I think the idea is here.
Did you have any scenario to trigger the bug addressed by #826? I described 3 scenarios in the commit log (https://github.com/endocode/rkt/commit/a39337b41302ef279feeef1932f348311bb8980a) but I don't know if they are related to the one you had.

@iaguis wrote a kernel patch to introduce CONFIG_PROC_CHILDREN which enables /proc/pid/task/tid/children, so CONFIG_EXPERT and CONFIG_CHECKPOINT_RESTORE will not be necessary. The patch has been added to the -mm tree and will go to linux-next.

@alban Sorry, missed the PR for several days. The original scenario is that when rkt enter report no pid file when it enters soon after rkt run. I think this is covered by your Test1.

@alban I couldn't (and can't) imagine any stage1 implementation which will not have a unix process to which we can attach the container's lock fd to.  It really seems to belong in stage0 IMHO, even kvm instances will have a user process.

@yifan-gu: the new tests added in #972 and #973 should cover it now.
@vcaputo: ok, I changed it back and updated the documentation. PTAL.
@iaguis: I rebased and updated the branch after your review.

LGTM.
I tested it both on a kernel with and without support for /proc/<pid>/tasks/<tid>/children and it worked.
I would like another review before merging it though.

small things, otherwise lgtm

Thanks for the review.
I added a fixup commit, for easier review. If it's fine, I will squash that fixup commit before merging.

Semaphore is green and the tests also pass on my laptop.
@iaguis reviewed it out of band.


N+1 Query in /feed/new

Sentry Issue: BACKEND-MS

Offending Spans
db - SELECT apps.type AS apps_type

FROM apps

...

https://github.com/flathub-infra/website/commit/21d58b1f1c622d4006f417393c2aab5c37b7c1f4 should help with this


Bug: Todos not persisting in mongo DB

git clone
npm install
npm run dev

<EMAIL_ADDRESS>dev /Users/**/reactGo
cross-env NODE_ENV=development nodemon

[nodemon] 1.11.0
[nodemon] to restart at any time, enter rs
[nodemon] watching: /Users//reactGo/app/utils//* app/server.jsx app/routes.jsx /Users//reactGo/server//* webpack/webpack.config.dev-client.js webpack/webpack.config.dev-server.js .stylelintrc
[nodemon] starting npm run build:dev && node compiled/server.dev.js

<EMAIL_ADDRESS>build:dev /Users/**/reactGo
cross-env NODE_ENV=development webpack ---debug --colors --display-error-details --config ./webpack/webpack.config.dev-server.js

Hash: 401b2505459a9dbe1331
Version: webpack 1.14.0
Time: 11492ms
Asset     Size  Chunks             Chunk Names
server.dev.js   876 kB       0  [emitted]  server
server.dev.js.map  1.01 MB       0  [emitted]  server
+ 309 hidden modules
===> 😊  Starting Server . . .
===>  Environment: development
===>  Listening on port: 3000
===>  Using DB TYPE: MONGO
===>  Succeeded in connecting to mongodb://localhost/ReactWebpackNode
webpack building...
webpack built 32af108534092747fe2b in 9423ms
Problem is mongo has todos still its not showing todo's, on first render as well as via routing. Nothing comes in state as well.

@gauravarora91 Thanks for reporting. I can confirm that this is happening to me as well.

Documenting our discussion here https://github.com/reactGo/reactGo/pull/780/files#r94002355

Thanks!


Deprecate reading all formulae through commands

We added the --all flag for various commands (now renamed to --eval-all) for this behaviour so let's start deprecating this.
Also, introduce a HOMEBREW_EVAL_ALL environment variable to use the existing, less secure, behaviour by default and avoid passing --eval-all everywhere.

Review period skipped due to critical label.

@Bo98 @Rylan12 Have updated this to:

Use --exec-all and HOMEBREW_EXEC_ALL (but could be convinced to use --eval-all and HOMEBREW_EVAL_ALL)
Remove the brew bump-formula-pr Formula.all code
Adjust descriptions to better explain what's going on
Audited existing usage of --all and renamed them too

Resolved all issues and renamed to --eval-all. Thanks for all the comments, folks!

This is now unfortunately causing errors in CI, e.g. https://github.com/Homebrew/homebrew-core/runs/8190505169?check_suite_focus=true

@max-ae Have opened a PR: https://github.com/Homebrew/homebrew-test-bot/pull/830


[markdown] underscores in URLs produce italicizing

http://goo.com/_foo bar baz [foo](bar)
gets rendered with the _ starting an italicized section, whereas it should just be part of the URL, as rendered below:
http://goo.com/_foo bar baz foo

The markdown mode doesn't highlight URLs, so I guess you're using the GFM mode. That is currently implemented as an overlay over the Markdown mode, which means it can't influence the tokenizing the Markdown mode produces. This is the cause of a bunch of problems, but it's not something that can be addressed without rewriting the whole GFM mode. Since this is contributed code, I don't really have any plans to do so myself on the short term.

I wasn't talking about any special highlighting of the URL.
We are currently using this config for markdown mode:
  {
    name: 'markdown',
    underscoresBreakWords: false,
    fencedCodeBlocks: true,
    strikethrough: true
  },

The problem, as described above, is that when you paste my example into https://codemirror.net/mode/markdown/ the _ starts an italicized section, which here is undesirable. The desired fix would be some adjustment of the tokenization etc. in the markdown mode so that underscores in contexts like this (e.g. preceded by / and maybe other characters) don't trigger the start of italicizing.

I see. But then is there any reason to expect this underscore not to start an emphasis span? The CommonMark spec suggests treating punctuation (/ in this case) the same as whitespace.

I think autolinks would be the right thing to use here, and inside these _ shouldn't start an italic span.


Page Translation using reach and GSAP?

Starting with Page transition example using Reach-Router and React-Transition-Group/CSSTransition
https://reach.tech/router/example/animation
But, what if I want to animate with it GSAP? GSAP uses pure JavaScript not CSS. So  TransitionGroup and  CSSTransition wouldn't be necessary right?  I found another example on GSAP that use React-Router
https://stackblitz.com/edit/gsap-react-route-animation
I am trying to utilize to get it work with Reach-Router, since they both router are almost close resemblance with each other.  So far, I made a progress but unfortunately, animation didn't work! Visit codesandbox and see what I have so far.
https://codesandbox.io/s/dreamy-diffie-h5rny?fontsize=14
I not understanding here. Did I missing something? Please need help?

Hi @aprather51 👋🏽
Looking at your sandbox example, I see that it's working with reach router as you mentioned.  Outside of that however, I would recommend posting on a discussion forum like stackOverflow or the spectrum chat group.  Doing so helps keep the issues for feature requests/bugs and would likely get your issue resolved a bit faster than here.
Thanks for using reach router!


fix: add spacing to 'added in' texts

Description

Add spacing to <Since /> elements

Before
After

Wouldn't it make more sense to add padding to the <Since /> component instead of wrapping all of them in a `?

Wouldn't it make more sense to add padding to the <Since /> component instead of wrapping all of them in a <p />?

It would but there are some instances of Since that are inlined 😅

Thanks, Kevin! I updated Astro Docs Docs to show this usage of the component in a standalone line!


chore(tier4_perception_launch): fix typo

Description
fix typo of tier4_perception_launch

Tests performed

spell check
Effects on system behavior

Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

https://github.com/autowarefoundation/autoware.universe/pull/4429
It overlaps with this one.

@takayuki5168
Sorry, did not see this PR
:bow:

@knzo25 Sorry about that. Then I will merge mine.


Regarding preparation of shape file and its extraction in GEE. I am using jupyter notebook.

geemap version:
Python version:
Operating System:

Description
Describe what you were trying to get done.
Tell us what happened, what went wrong, and what you expected to happen.
What I Did
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

I am not sure what your issue is. If you are trying to use shapefile with GEE or download GEE datasets as shapefiles, check out this notebook example.


Update logback-classic, logback-core to 1.4.5

Updates

ch.qos.logback:logback-classic
ch.qos.logback:logback-core

from 1.4.4 to 1.4.5.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "ch.qos.logback" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #2299 (08f37e2) into main (0795560) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2299      +/-   ##
==========================================
- Coverage   78.61%   78.61%   -0.01%
==========================================
  Files         435      435
  Lines       14844    14844
  Branches     2060     2080      +20
==========================================
- Hits        11670    11669       -1
- Misses       3174     3175       +1

Impacted Files
Coverage Δ

...he/io/annotations/parser/CommentPreprocessor.scala
96.70% <0.00%> (-1.10%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Remove Inspector from the docs

We pulled the Xamarin Inspector from the install for new users maybe
1.5-2 years ago. It's still technically included in the install for existing
users that already have it installed and do updtates. That, I think,
we'll remove for Dev17. But Inspector essentially is a removed,
unsupported, feature now and has been for some time. So removing
from the docs seems like the right thing & Maddy agreed.

@BretJohnson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Closing this PR as it's on the wrong repo.
It's replaced by this PR on the private repo, which Dave Britch can approve: https://github.com/MicrosoftDocs/xamarin-docs-pr/pull/2298


NIFI-10506 Move Repository Encryption to Admin Guide

Summary
NIFI-10506 Moves the Repository Encryption configuration section from the User Guide to the Administrator's Guide and adds a new section named Configuration Change Considerations. The new section highlights the fact that disabling repository encryption requires removing the contents of existing repositories.
The Repository Encryption configuration details are administration concerns, as opposed to user concerns, so this move aligns with the Repository Encryption properties already present in the Administrator's Guide.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

+1 will merge

Will take a look.

Sorry, was late to the game, but LGTM.  Nice decision to move this content to the Admin Guide.


Not production ready

I think using the django provide server should be avoided and Django insists on not using it (https://docs.djangoproject.com/en/2.0/ref/django-admin/#runserver). Maybe adding a uwsgi to this template would be useful.

This is bad sample.
IMHO Better sample ... https://github.com/Azure-App-Service/python
https://github.com/robpco/docker-nginx-uwsgi-flask-mssql


Feature Request: .card-img-left / .card-img-right

Currently you can have a card with an image on top or bottom, but not to the left (as is typical).
Requesting that card-img-left and card-img-right be added, getting your very typical box with some text and an image to the left or right on desktops and as a top-cap on mobile.
Example Desired Behaviour:
-----------------------------
| img  |  Title                     |
| img  |  Text text text text |
| img  |  Button                 |
-----------------------------

Example Code Using Columns instead of cards of what I want to do:

Title

Copy

								Contact Us

Possible solutions in BS4 solutions explored
Media Left
This looks great at full width, however as the viewport shrinks, the image stays the same size and the text stays on the right shifting further right.  If done in a card, this would stack when the width gets too small.

Title

Copy

      Contact Us

Float Left
Doesn't seem to work for this image

@gijsbotje that's cool, I'll review it

Duplicate of #20794.

thank you


.Date is empty on index.html

If I insert {{ dateFormat "2006-01-02" .Date }} into the "layouts/index.html" file, the rendered result is "0001-01-01". It works in other templates.
Other variables of "node" types like .URL or .Title are working as expected.

Thanks for this report.

I tried something similar, not sure if it's another issue. I render dates in sitemap.xml and for the layouts/index.html it uses 0001-01-01
<lastmod>0001-01-01</lastmod>


added phone i booking 2

added phone number to challenges.html and index.html,  only HTML, no CSS! the CSS did not load so id do not know how it looks with it.

Did you type
"npm run dev" in the terminal and then followed the localhost-link?
How do you mean CSS did not load? Have you pulled all the changes to your local repo?


Unexpectable action when first clicking on the slider

I have a multislider:

When I  first time click on slider the right thumb is immediately moves to the left

After you set the minValue and maxValue of the multi slider, you have to set the value of the thumb1.
The code is following
multislider.getThumb(1).setValue(maxValue)


Debug vite projects in Chrome63 development environment

Describe the bug
node 16.16.0
vite 4.1.0
vue 3.2.45
typescript 4.9.3
npm run dev   After running the project, Chrome version 63 opens with a blank page and an error:

The purpose is to debug the vite project in Chrome63 development environment, not production environment.
Reproduction
https://github.com/LLLuojp/test_project
Steps to reproduce
No response
System Info
Uncaught SyntaxError: Unexpected token .

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is by design, support for legacy browsers is a build-only feature. During dev mode, Vite doesn't transpile files.


Adding field level resolvers with GRPC and Apollo Federation

Hi Team,
I have a GRPC backed service which needs to be served through an Apollo federation gateway.
I have created a sample repo here - https://github.com/rsugirtharaj/graphql-mesh-example
The current query I am using is
{
  getProduct(productId:1234) {
    productId
    productName
    reviews {
      rating
      userName
    }
  }
}

This is working fine with no issues, but what I want to do is
{
  getProduct(productId:1234) {
    productId
    productName
    reviews (limit: 10) {
      rating
      userName
    }
  }
}

Notice the limit param passed to the reviews field. Please let me know if this is possible and how to implement this.
Thanks.

Hi Team, Can anyone help with this?

You can use additionalTypeDefs and additionalResolvers to extend the schema.


className as list

https://github.com/gravity-ui/navigation/blob/main/src/components/CompositeBar/Item/Item.tsx#L164
after build
gn-composite-bar-item gn-composite-bar-item_type_regular g n - f o o t e r - i t e m

Which version of @bem-react/classname do you use?
If bug really exists we need to fix all places not only CompositeBarItem


SystemClockRate calculation factor typo correction

Description:
As reported in issue ticket #5504 (Typo), the calculation factor should be 10,000 instead of 10,0000 (decimal system 3 digit grouping) and be consistent with the already present calculation formula information just before and after.
Thanks to @elljay23 for reporting this typo.
Proposed change:

Remove the extraneous zero in "10,0000" in the calculation example.

Codestyle & whitespace changes:

Remove redundant MarkDown indent markers where unneeded.
Align MarkDown table metadata row length with the column headers (1 table)
Remove any redundant end-of-line (EOL) blanks.
Remove redundant leading whitespace (blank) (1 occurrence).
Add missing NewLine at end-of-file (EOF).

Additional note:

The document article date has been updated, from 04/28/2021 to 05/20/2021, although the date should probably be set more accurately at merging time.

Ticket closure or reference:
Closes #5504

@illfated : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@illfated: I'm sorry - only the author of this article, @Teresa-Motiv, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Yes, I know. My sign-off comment is based on a previous agreement with the team.

#sign-off


[forwardport]Remove "istio-virtual-service-ui" feature flag

https://github.com/rancher/rancher/issues/23582

Available in latest2.

rancher/rancher:master-head 781cd0f
UI: latest-2

istio-virtual-service-ui feature flag is enabled by default and UI features are shown
When flag is set to false the UI features are hidden


how get contact profile picture

Does anyone have tips?

so after hours, I found the slotion!
self.activeWs.send(messageTag+',["query", "ProfilePicThumb", "xxxxxxxxxx@c.us"]');
cheers :D

so after hours, I found the slotion!
self.activeWs.send(messageTag+',["query", "ProfilePicThumb", "xxxxxxxxxx@c.us"]');
cheers :D

Eu preciso fo


SRVKP-4361: enable results-from sidecar-logs for pipelines

This PR is related to
Story https://issues.redhat.com/browse/SRVKP-4361
before this we tried to enable the feature, but it was failing on stage because of missing rbac.
This PR :

enable the feature results-from sidecar-logs
increases the limit for the result size to 12288 (originally 4096)
adds the rbac to pipeline controller sa to allow access to pods logs anywhere

it has been tested on dev using

https://github.com/jkhelil/pipeline-service/commit/5df1afddcbdaf3de0561ef20541150580d2b8fb2
https://github.com/tektoncd/pipeline/blob/main/examples/v1/pipelineruns/alpha/pipelinerun-large-results.yaml

@lcarva PTAL

/retest

/retest

you need to do the development overlay as well @jkhelil ... that is what the e2e's will work off of.

Aha! This is why e2e didn't catch errors last time.

you need to do the development overlay as well @jkhelil ... that is what the e2e's will work off of.

Aha! This is why e2e didn't catch errors last time.

OMG ... yeah just revisited the original PR and yep it did not bump the dev overlay.  Yikes miss for me.  Should have seen that before.

/retest

/retest

Tests are failing, Ci is still failing to provision clusters

/retest

/retest

/hold
/retest
@lcarva will you still do the sanity check on stage-m01 or stage-rh01?  If so, then feel free to release the hold when you are ready, assuming we have green e2e's
if all good, we'll bump p01 i.e. bifrost cluster and then put this in the queue for prod

will you still do the sanity check on stage-m01 or stage-rh01? If so, then feel free to release the hold when you are ready, assuming we have green e2e's

I should be able to test on stage-m01. I don't think I have access to create application on stage-rh01. If someone triggers the Pipeline that Yash has I can review the results.

will you still do the sanity check on stage-m01 or stage-rh01? If so, then feel free to release the hold when you are ready, assuming we have green e2e's

I should be able to test on stage-m01. I don't think I have access to create application on stage-rh01. If someone triggers the Pipeline that Yash has I can review the results.

I would think m01 is sufficient .... sorry I have no idea how to trigger the pipeline Yash has

closing in favor of https://github.com/redhat-appstudio/infra-deployments/pull/3699 with @jkhelil out on PTO and being able to update p01 now