Dragging any Resource not recognized by the editor over the viewport crashes Godot

Tested versions
v4.3.dev4.official [df78c0636]
System information
Godot v4.3.dev4 - macOS 14.2.1 - Vulkan (Forward+) - integrated Apple M1 Pro - Apple M1 Pro (10 Threads)
Issue description
When dragging a theme over the viewport, the editor crashes.
https://github.com/godotengine/godot/assets/2206700/80922fcd-fd60-4706-b4b0-8b0a917360ba
I get this from the crash dialog, not sure if it helps:
-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               Godot [94104]
Path:                  /Applications/Godot.app/Contents/MacOS/Godot
Identifier:            org.godotengine.godot
Version:               4.3 (4.3)
Code Type:             ARM-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2024-03-02 18:35:36.4833 +0100
OS Version:            macOS 14.2.1 (23C71)
Report Version:        12
Anonymous UUID:        33ED798A-8EC3-E728-0035-E4E197B21DF8

Sleep/Wake UUID:       14A2FDC0-AF33-4169-BAFF-3E500503288E

Time Awake Since Boot: 540000 seconds
Time Since Wake:       12305 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGABRT)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000188
Exception Codes:       0x0000000000000001, 0x0000000000000188

Termination Reason:    Namespace SIGNAL, Code 6 Abort trap: 6
Terminating Process:   Godot [94104]

VM Region Info: 0x188 is not in any region.  Bytes before following region:<PHONE_NUMBER>78840
      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      UNUSED SPACE AT START
--->
      MALLOC_NANO<PHONE_NUMBER>00-600080000000 [512.0M] rw-/rwx SM=PRV

Application Specific Information:
abort() called

If I don't hover with the dragged resource over the viewport and play a game of moving only around the editor, it doesn't crashes. So I assume that there is something going wrong when trying to make a preview of the resource in the viewport? or something like that 🤷♂
https://github.com/godotengine/godot/assets/2206700/16cd683f-e037-4907-9006-bd232820b74b
Steps to reproduce
Download the project, drag the res://UI/MainTheme.tres into the viewport.
Minimal reproduction project (MRP)
This is the current project I'm using on the videos. It is not a super minimal version of it, but it is small enough.
MRP.zip

CrashHandlerException: Program crashed
Engine version: Godot Engine v4.3.dev.custom_build (9fc1d6eb3634007f4103cafbdfd5f2ab58753bfb)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[0] CowData<char32_t>::_ref (C:\godot_source\core\templates\cowdata.h:459)
[1] String::String (C:\godot_source\core\string\ustring.h:458)
[2] Node::get_scene_file_path (C:\godot_source\scene\main\node.cpp:2414)
[3] CanvasItemEditorViewport::can_drop_data (C:\godot_source\editor\plugins\canvas_item_editor_plugin.cpp:5942)
[4] Viewport::_gui_drop (C:\godot_source\scene\main\viewport.cpp:1748)
[5] Viewport::_gui_input_event (C:\godot_source\scene\main\viewport.cpp:2109)
[6] Viewport::push_input (C:\godot_source\scene\main\viewport.cpp:3375)
[7] Window::_window_input (C:\godot_source\scene\main\window.cpp:1611)
[8] call_with_variant_args_helper<Window,Ref<InputEvent> const &,0> (C:\godot_source\core\variant\binder_common.h:304)
[9] call_with_variant_args<Window,Ref<InputEvent> const &> (C:\godot_source\core\variant\binder_common.h:419)
[10] CallableCustomMethodPointer<Window,Ref<InputEvent> const &>::call (C:\godot_source\core\object\callable_method_pointer.h:99)
[11] Callable::callp (C:\godot_source\core\variant\callable.cpp:58)
[12] Callable::call<Ref<InputEvent> > (C:\godot_source\core\variant\variant.h:864)
[13] DisplayServerWindows::_dispatch_input_event (C:\godot_source\platform\windows\display_server_windows.cpp:3155)
[14] DisplayServerWindows::_dispatch_input_events (C:\godot_source\platform\windows\display_server_windows.cpp:3125)
[15] Input::_parse_input_event_impl (C:\godot_source\core\input\input.cpp:773)
[16] Input::flush_buffered_events (C:\godot_source\core\input\input.cpp:1044)
[17] DisplayServerWindows::process_events (C:\godot_source\platform\windows\display_server_windows.cpp:2674)
[18] OS_Windows::run (C:\godot_source\platform\windows\os_windows.cpp:1476)
[19] widechar_main (C:\godot_source\platform\windows\godot_windows.cpp:182)
[20] _main (C:\godot_source\platform\windows\godot_windows.cpp:204)
[21] main (C:\godot_source\platform\windows\godot_windows.cpp:218)
[22] WinMain (C:\godot_source\platform\windows\godot_windows.cpp:232)
[23] __scrt_common_main_seh (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[24] <couldn't map PC to fn name>
-- END OF BACKTRACE --

Happens with any Resource not recognized by the editor.

I think it is actually related to #88829?
[3] CanvasItemEditorViewport::can_drop_data (C:\godot_source\editor\plugins\canvas_item_editor_plugin.cpp:5942) this section of the code points to a commit related to that PR, may I attempt a fix for this?

I have a fix ready but I'm not sure if I'm capturing all scenarios; @KoBeWi what other Resources did you test with?
How did you get that log? by using target=template_debug?

You can get a log by crashing in a build with debug symbols (e.g. dev_build=yes in scons). This bug happens for any resource that isn't Texture2D or PackedScene.


Roll engine 58eff77ef2f8..75da3d42d56a (2 commits)

https://github.com/flutter/engine/compare/58eff77ef2f8...75da3d42d56a
git log 58eff77ef2f808306f0f8d4e46d910b6210bae46..75da3d42d56aaad46a1ea2e57c954a6ec95b9baa --no-merges --oneline
75da3d42d Roll src/third_party/dart fee615c5a5..39ec9fc4f3 (46 commits)
49b6de8c5 Dynamically add certain iOS AppDelegate methods. (flutter/engine#8843)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6099735765581824

Commit queue failed; closing this roll.


error

Traceback (most recent call last):
File "preprocess", line 23, in
module = importlib.import_module(MODULE.format(dataset))
File "/opt/conda/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 941, in _find_and_load_unlocked
File "", line 219, in _call_with_frames_removed
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 941, in _find_and_load_unlocked
File "", line 219, in _call_with_frames_removed
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 953, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'core'

It might be that you didn't add edGNN in your PYTHONPATH. Try adding it by doing:
export PYTHONPATH="YOUR-PATH/edGNN" or directly adding it to your bashrc.

Thanks！！！


Update event methods documentation

I think an API of usage is updated and needs to update documentation too.
There are events which needs to update in documentation:
addUserLoaded instead of userLoaded
addUserUnloaded instead of userUnloaded
addAccessTokenExpiring instead of accessTokenExpiring
addAccessTokenExpired instead of accessTokenExpired
addSilentRenewError instead of silentRenewError
addUserSignedOut instead of userSignedOut
Please consider that I've tested only above events and I'm not sure it's enough, maybe there are other things where we need to update

Those are all the events. You use add and remove to register and uregister.


Models with InputLayer are not serialized to HDF5 correctly

Opening new issue due to #10417 being closed without fix. Below is a demonstration of the issue and a hack to fix existing saved models.
docker run -it tensorflow/tensorflow:1.11.0-py3 /bin/bash
apt-get update
apt-get install python3-venv git hdf5-tools
python3 -m venv env
source env/bin/activate
pip install keras tensorflow
pip install git+git://github.com/keras-team/keras.git --upgrade --no-deps
python test.py

import keras
from keras.models import Sequential, load_model
from keras.layers import Dense, Input, InputLayer

print('keras.__version__=', keras.__version__)

fname1 = 'test1.h5'
model1 = Sequential()
model1.add(Dense(1, input_shape=(64, 64), name='dense'))
model1.compile(loss='mse', optimizer='adam')
model1.save(fname1)
model1 = load_model(fname1)

fname2 = 'test2.h5'
model2 = Sequential()
model2.add(InputLayer((64,64), name='input'))
model2.add(Dense(1, name='dense'))
model2.compile(loss='mse', optimizer='adam')
model2.save(fname2)
# ValueError: You are trying to load a weight file containing 1 layers into a model with 0 layers
model2 = load_model(fname2)

keras.__version__= 2.2.4
$ h5dump -A test1.h5 > test1.structure
$ h5dump -A test2.h5 > test2.structure
$ diff test1.structure test2.structure
...
<       (0): "{"class_name": "Sequential", "config": {"name": "sequential_1", "layers": [{"class_name": "Dense", "config": {"units": 1, "kernel_constraint": null, "bias_initializer": {"class_name": "Zeros", "config": {}}, "kernel_regularizer": null, "use_bias": true, "dtype": "float32", "activation": "linear", "kernel_initializer": {"class_name": "VarianceScaling", "config": {"seed": null, "distribution": "uniform", "mode": "fan_avg", "scale": 1.0}}, "batch_input_shape": [null, 64, 64], "bias_constraint": null, "activity_regularizer": null, "name": "dense", "bias_regularizer": null, "trainable": true}}]}}"
---
>       (0): "{"class_name": "Sequential", "config": {"name": "sequential_2", "layers": [{"class_name": "Dense", "config": {"units": 1, "kernel_constraint": null, "bias_initializer": {"class_name": "Zeros", "config": {}}, "kernel_regularizer": null, "use_bias": true, "trainable": true, "activation": "linear", "kernel_initializer": {"class_name": "VarianceScaling", "config": {"seed": null, "distribution": "uniform", "mode": "fan_avg", "scale": 1.0}}, "bias_constraint": null, "activity_regularizer": null, "name": "dense", "bias_regularizer": null}}]}}"
...

The test1 has the additional structure: "batch_input_shape": [null, 64, 64], "dtype": "float32",
You can fix this using:
import json
import h5py

def fix_layer0(filename, batch_input_shape, dtype):
    with h5py.File(filename, 'r+') as f:
        model_config = json.loads(f.attrs['model_config'].decode('utf-8'))
        layer0 = model_config['config'][0]['config']
        layer0['batch_input_shape'] = batch_input_shape
        layer0['dtype'] = dtype
        f.attrs['model_config'] = json.dumps(model_config).encode('utf-8')

# Example
fix_layer0('test2.h5', [None, 64, 64], 'float32')

@cyounkins Thanks for posting the workaround. Would you like to keep this issue open?

@ymodak yes absolutely. It is a bug to not be able to deserialize previously serialized networks.

@cyounkins -- Thanks, for pushing this issue.  I have been struggling with this for too long.  I simply rolled back to keras 2.1.6, but would much prefer a fix...and that means fix it, not close it because one of our smarter contributors found and posted a way around it.

@gabrieldemarmiesse Can you please take a look? Thanks!

What is the workaround if my model is saved as separate .json with architecture and .hdf5 with weights?

My own workaround is to build the model directly, rather than using Sequential().

@hosford42 Thanks, I can construct the model in code, but the problem seems to be with loading the weight file into it...
ValueError: You are trying to load a weight file containing 1 layers into a model with 28 layers.

Yes, that issue went away when I stopped using Sequential to construct the
code, and created the Input directly instead.
On Fri, Dec 21, 2018, 11:49 AM mikephn<EMAIL_ADDRESS>wrote:

@hosford42 https://github.com/hosford42 Thanks, I can construct the
model in code, but the problem seems to be with loading the weight file
into it...
ValueError: You are trying to load a weight file containing 1 layers into
a model with 28 layers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keras-team/keras/issues/11683#issuecomment-449454037,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEWlsxjVr9IACng1kpcS07Z02j4guuJoks5u7R82gaJpZM4Yp6NZ
.

I’m using the functional API, creating the layers and calling Model(input, output) at the end.

On 21 Dec 2018, at 21:57, Aaron Hosford<EMAIL_ADDRESS>wrote:
Yes, that issue went away when I stopped using Sequential to construct the
code, and created the Input directly instead.
On Fri, Dec 21, 2018, 11:49 AM mikephn<EMAIL_ADDRESS>wrote:

@hosford42 https://github.com/hosford42 Thanks, I can construct the
model in code, but the problem seems to be with loading the weight file
into it...
ValueError: You are trying to load a weight file containing 1 layers into
a model with 28 layers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keras-team/keras/issues/11683#issuecomment-449454037,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEWlsxjVr9IACng1kpcS07Z02j4guuJoks5u7R82gaJpZM4Yp6NZ
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/keras-team/keras/issues/11683#issuecomment-449496441, or mute the thread https://github.com/notifications/unsubscribe-auth/AEh_HGpVtj2a-JLW91AB9fdc9NElsRy5ks5u7Us-gaJpZM4Yp6NZ.

I am seeing this with class API for models saved within the same session (not cross version). Is it possible this is related?

Has anyone tried the fix (not a workaround) I proposed in #10417 ?  It works for me and I haven't noticed any side effects.

Another workaround is to replace:
InputLayer((64,64))

with this instead:
Lambda(tf.identity, input_shape=(64,64))

@fchollet Was there a fix for this or is it being closed like #10417 without resolution? As I said above, it's clearly a bug to not be able to deserialize something keras serialized.


Conflicting file path assertions in delegate() and add_paths()

Description of issue or feature request:
Related to #957
The Targets.delegate()method fails if one of the file paths or patterns passed via the paths argument is absolute, i.e. starts with a directory separator.  At the same time it warns if it the path does not have self._targets_directory as prefix, which very well may be an absolute path.
https://github.com/theupdateframework/tuf/blob/409eef1a4872a88b610e81b375f36b07a8e0f996/tuf/repository_tool.py#L2286-L2294
The Targets.add_paths() methods emits a similar message (with debug level). Note that the method does not check whether the passed paths have a leading directory separator, although it should, in order to be consistent with above function.
https://github.com/theupdateframework/tuf/blob/409eef1a4872a88b610e81b375f36b07a8e0f996/tuf/repository_tool.py#L1868-L1872
Current behavior:

Targets.delegate() and Targets.add_paths() emit warning/debug message if a passed path or path pattern is not prefixed with the targets directory base path, i.e. self._targets_directory.
Targets.add_paths does not check if the passed paths are indeed relative.

Expected behavior:
Either,

Targets.delegate() and Targets.add_paths() should not care about the prefix of the passed paths or path patterns.
Targets.add_paths should probably assert that the passed paths are relative, to be consistent with the sibling the corresponding functionality of delegate().

When fixing this issue, don't forget to remove the comment in a tutorial code snippet that asks the reader to ignore a misleading warning about the location of a delegation path pattern (see 41d7bbde5dbeabb938b1cb90f4c7bc20bfdee725 of #775).

The specification states:

A TARGETPATH is a path to a file that is relative to a mirror's base URL of targets. To avoid surprising behavior when resolving paths, it is RECOMMENDED that a TARGETPATH uses the forward slash (/) as directory separator and does not start with a directory separator. The recommendation for TARGETPATH aligns with the "path-relative-URL string" definition in the WHATWG URL specification.

Therefore I think the latter expected behaviour is most consistent with the spec, i.e. we should change such that:

Targets.add_paths should probably assert that the passed paths are relative, to be consistent with the sibling the corresponding functionality of delegate().

To make sure we are on the same page, we are not talking about TARGETPATH but PATHPATTERN here. But the specification states something similar:

To avoid surprising behavior when matching targets with PATHPATTERN, it is
RECOMMENDED that PATHPATTERN uses the forward slash (/) as directory
separator and does not start with a directory separator, akin to
TARGETSPATH.

Also, just to double check, do others think raising an exception is reasonable? The spec only recommends relative paths, but IIRC we agreed (#63, 67) that an implementation can be more assertive than the spec in this regard. So I think leaving the strict behavior in delegate and adding it to add_paths is indeed reasonable.

I also just saw that I didn't suggest an expected behavior for the other issue, i.e. the warning/debug messages on not path.startswith(targets_directory).
I strongly suggest to remove them, because if a PATHPATTERN does indeed start with a targets directory, I think, it won't even match TARGETPATHs, as they explicitly leftstrip the targets directory, see e.g. add_target:
https://github.com/theupdateframework/tuf/blob/409eef1a4872a88b610e81b375f36b07a8e0f996/tuf/repository_tool.py#L1962

Fixed in #1008


change methods module to method.lib

Named methods will be imported from mrsimulator.method.lib

Add a statement in the changelog for the module remaining.

Update changelog file.


feat: add keywords

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area videos

What this PR does / why we need it:
Adds keywords to some pages. Update parsing keywords logic, so phrases consisting of 2 words don't get joined into one.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bullet03
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bullet03
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS
layouts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bullet03, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [Issif]
layouts/OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash:<PHONE_NUMBER>da3838a2f1ac3bb9816475ce2f086f


Improve stream functionality and handling of links in streams

See https://github.com/product-os/autumndb/pull/1462
Change-type: minor
Signed-off-by: Lucian Buzzo<EMAIL_ADDRESS>

@balena-ci I self-certify!


Fix some typos in the issue templates

Pull Request Checklist
You can go to dendron pull requests to see full details for items in this checklist.
General
Quality Assurance

[ ] add a test for the new feature
[ ] make sure all the existing tests pass
[ ] do a spot check by running your feature with our test workspace
[ ] after you submit your pull request, check the output of our integration test and make sure all tests pass

NOTE: if you running mac/linux, check the windows output and vice versa if you are developing on windows

Special Cases

[ ] if your tests changes an existing snaphot, make sure that snapshots are updated
[ ] if you are adding a new language feature (graphically visible in vscode/preview/publishing), make sure that it is included in test-workspace. We use this to manually inspect new changes and for auto regression testiing

Docs

[x] Make sure that the PR title follows our commit style
[x] Please summarize the feature or impact in 1-2 lines in the PR description
[ ] If your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Example PR Description
# feat: capitalize all foos

This changes capitalizes all occurences of `foo` to `Foo`

Docs PR: <URL_TO_DOCS_PR>

Special Cases
First Time PR

[x] sign the CLA which will be prompted by our github bot after you submit the PR
[x] add your discord alias in the review so that we can give you the horticulturalist badge in our community: lnicola#6853

Analytics

[ ] if you are adding analytics related changes, make sure the Telemetry docs are updated

thanks for the corrections!


Azure Open AI returns unexpected results.

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ x] feature request
- [ x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior

OS and Version?

macOS ( Sierra)

azd version?
azd version 1.9.3
Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Hi,
I just wonder if this sample works with Azure Open AI, too? When I ask a simple question, like "Where is Poland", the answer is "I'm sorry, but I don't have any information about the location of Poland based on the provided sources."
However, it works well with the provided sources. Is there a way to hide developer settings and citations from users?

That sounds like a good answer, given that this a RAG app designed to answer based on sources.
Is your goal to have it also answer questions that aren't from the sources?


About training details

I noticed in the previous issue that it will reach convergence after about 150,000 iters. Does this refer to the training results when the batchsize is 5?
I checked the training code and the number of iterations here is independent of the number of GPUs, right?

Based on other people's replications, the performance of the number of iterations is related to the number of GPUs used. More details can be found in this issue.

But in theory, one GPU' train_step will be counted as one iteration. I guess the number of GPUs affects the batch of gradient backpropagation in DDP strategy.


Crash in h2

Was testing something else with h2load, and randomly got this, h2load command is /h2load --warm-up-time=10 -D 20 -c 4 -t 4 -m 4 https://<IP_ADDRESS>:9090/0, running latest master branch:
(gdb) bt
#0  MIMEField::name_get (this=this@entry=0x0) at ../../../proxy/hdrs/MIME.cc:1756
#1  0x00005575cea64f68 in MIMEField::name_get (length=<synthetic pointer>, this=0x0) at /home/duke/Git/duke-ats/_build/../proxy/hdrs/MIME.h:812
#2  HpackIndexingTable::get_header_field (field=..., index=<optimized out>, this=<optimized out>) at ../../../proxy/http2/HPACK.cc:309
#3  HpackIndexingTable::get_header_field (this=<optimized out>, index=<optimized out>, field=...) at ../../../proxy/http2/HPACK.cc:293
#4  0x00005575cea65d6b in decode_indexed_header_field (header=..., buf_start=<optimized out>, buf_end=<optimized out>, indexing_table=...)
    at ../../../proxy/http2/HPACK.cc:705
#5  0x00005575cea67167 in hpack_decode_header_block (indexing_table=..., hdr=hdr@entry=0x7f68857c7d90, in_buf=0x7f688579b020 "\004\002/0\207\277\202\276",
    in_buf_len=<optimized out>, max_header_size=131072, maximum_table_size=maximum_table_size@entry=4096) at ../../../proxy/http2/HPACK.cc:868
#6  0x00005575cea42dff in http2_decode_header_blocks (hdr=hdr@entry=0x7f68857c7d90, buf_start=<optimized out>, buf_len=<optimized out>, len_read=len_read@entry=0x0,
    handle=..., trailing_header=@0x7f68857c87b0: false, maximum_table_size=4096) at ../../../proxy/http2/HTTP2.cc:688
#7  0x00005575cea5a345 in Http2Stream::decode_header_blocks (this=this@entry=0x7f68857c7c00, hpack_handle=..., maximum_table_size=<optimized out>)
    at ../../../proxy/http2/Http2Stream.cc:151
#8  0x00005575cea56a88 in rcv_headers_frame (cstate=..., frame=...) at ../../../proxy/http2/Http2ConnectionState.h:106
#9  0x00005575cea54ac6 in Http2ConnectionState::main_event_handler (this=0x7f68857c6308, event=<optimized out>, edata=0x7f689c00fe20)
    at ../../../proxy/http2/Http2ConnectionState.cc:1064
#10 0x00005575cea4902f in Continuation::handleEvent (data=0x7f689c00fe20, event=2253, this=0x7f68857c6308)
    at /home/duke/Git/duke-ats/_build/../iocore/eventsystem/I_Continuation.h:219
#11 Continuation::handleEvent (data=0x7f689c00fe20, event=2253, this=0x7f68857c6308) at /home/duke/Git/duke-ats/_build/../iocore/eventsystem/I_Continuation.h:215
#12 send_connection_event (cont=0x7f68857c6308, event=2253, edata=0x7f689c00fe20) at ../../../proxy/http2/Http2ClientSession.cc:65
#13 0x00005575cea49ae1 in Http2ClientSession::do_complete_frame_read (this=this@entry=0x7f68857c6000) at ../../../proxy/http2/Http2ClientSession.cc:529
#14 0x00005575cea4a55b in Http2ClientSession::state_process_frame_read (this=0x7f68857c6000, event=<optimized out>, vio=0x7f68859d6ae0, inside_frame=<optimized out>)
    at ../../../proxy/http2/Http2ClientSession.cc:587
#15 0x00005575cea4a79d in Http2ClientSession::state_start_frame_read (this=0x7f68857c6000, event=100, edata=0x7f68859d6ae0)
    at ../../../proxy/http2/Http2ClientSession.cc:443
#16 0x00005575cea492ec in Http2ClientSession::main_event_handler (this=0x7f68857c6000, event=100, edata=0x7f68859d6ae0)
    at ../../../proxy/http2/Http2ClientSession.cc:313
#17 0x00005575cea4571e in Continuation::handleEvent (data=0x7f68859d6ae0, event=100, this=0x7f68857c6000)
    at /home/duke/Git/duke-ats/_build/../iocore/eventsystem/I_Continuation.h:219
#18 Continuation::handleEvent (data=0x7f68859d6ae0, event=100, this=0x7f68857c6000) at /home/duke/Git/duke-ats/_build/../iocore/eventsystem/I_Continuation.h:215
#19 Http2ClientSession::state_read_connection_preface (this=0x7f68857c6000, event=<optimized out>, edata=0x7f68859d6ae0)
    at ../../../proxy/http2/Http2ClientSession.cc:423
#20 0x00005575cea492ec in Http2ClientSession::main_event_handler (this=0x7f68857c6000, event=100, edata=0x7f68859d6ae0)
    at ../../../proxy/http2/Http2ClientSession.cc:313
#21 0x00005575cebecead in Continuation::handleEvent (data=0x7f68859d6ae0, event=100, this=0x7f68857c6000)
    at /home/duke/Git/duke-ats/_build/../iocore/eventsystem/I_Continuation.h:219
#22 Continuation::handleEvent (data=0x7f68859d6ae0, event=100, this=0x7f68857c6000) at /home/duke/Git/duke-ats/_build/../iocore/eventsystem/I_Continuation.h:215
#23 read_signal_and_update (vc=0x7f68859d6900, event=100) at ../../../iocore/net/UnixNetVConnection.cc:83
#24 UnixNetVConnection::readSignalAndUpdate (this=this@entry=0x7f68859d6900, event=event@entry=100) at ../../../iocore/net/UnixNetVConnection.cc:1030
#25 0x00005575cebbacb2 in SSLNetVConnection::net_read_io (this=<optimized out>, nh=0x7f68a4f85b40, lthread=0x7f68a4f81ac0)
    at ../../../iocore/net/SSLNetVConnection.cc:671
#26 0x00005575cebdd5b6 in NetHandler::process_ready_list (this=this@entry=0x7f68a4f85b40) at ../../../iocore/net/UnixNet.cc:415
#27 0x00005575cebdda73 in NetHandler::waitForActivity (this=0x7f68a4f85b40, timeout=<optimized out>) at ../../../iocore/net/UnixNet.cc:549
#28 0x00005575cec3a3a2 in EThread::execute_regular (this=0x7f68a4f81ac0) at /home/duke/Git/duke-ats/_build/../include/tscore/ink_atomic.h:76
#29 0x00005575cec3ab2e in EThread::execute (this=0x7f68a4f81ac0) at ../../../iocore/eventsystem/UnixEThread.cc:364
#30 EThread::execute (this=0x7f68a4f81ac0) at ../../../iocore/eventsystem/UnixEThread.cc:342
#31 0x00005575cec383ca in spawn_thread_internal (a=0x7f68a9901ac0) at ../../../iocore/eventsystem/Thread.cc:92
#32 0x00007f68aa2db609 in start_thread (arg=<optimized out>) at pthread_create.c:477
#33 0x00007f68a9eaf293 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Tried a few different configurations, can't recreate this crash anymore. Closing the issue for now, will reinvestigate if it pops up again.


Use full path as repository_id

I have a repos structure like
/repositories
 - /owner
    - /repo

Sometimes repo names can be the same. In such case on gitbase start I see in logs:
time="2019-01-23T12:04:32Z" level=debug msg="repository added" path=/mnt/repositories/SignalR/SignalR
time="2019-01-23T12:04:32Z" level=error msg="repository could not be added" error="the repository is already registered: /mnt/repositories/SignalR/SignalR" id=SignalR path=/mnt/repositories/aspnet/SignalR
time="2019-01-23T12:04:32Z" level=debug msg="repository added" path=/mnt/repositories/aspnet/SignalR

Repos https://github.com/aspnet/SignalR and https://github.com/SignalR/SignalR are actually different but only one gets registered and available to query.

I need it !

The ID should be relative to the  --directories= paths, but ever from the root otherwise the ids are going to be deployment dependent

As we discussed recently, we need this sooner than later. While we can sometimes workaround with remotes, it's not that convenient for our work on PoCs. So if there is enough bandwidth, I think we should fix this even before go-borges integration.


Still working on this?

Are you still experimenting here? We have libp2p pubsub talking to js pretty well now after getting a few bug fixes merged.

I am not still working on this, it was just a proof of concept. I am glad to hear libp2p pubsub is working better in JS.

@tobowers I'm interested to understand how to use libp2p as signaling server.
Do you have any concrete examples at hand?

@tobowers I'm interested to understand how to use libp2p as signaling server.
Do you have any concrete examples at hand?

@marcoippolito I don't sorry - I'm still interested in it though :). There are a few links around about getting rid of the star servers and using pubsub as signaling... but I haven't actively experimented at this point.  My comment above is about libp2p pubsub which wasn't working go-to-js before.


Create blog posts about some projects in the incubator program

[ ] scicookie
[ ] makim
[ ] sugar
[ ] envers
[ ] ArtBox
[ ] ArxLang/ASTx

PS: Using Jupyter Lab
ref: https://github.com/OpenScienceLabs/opensciencelabs.github.io/tree/main/pages/blog/unlocking-the-power-of-multiple-dispatch-in-python-with-plum-dispatch

Hey Ivan, I have to do the blogs with Jupyter like the ref
Is it right?

Yes please.
When you run locally makin pages.preview or makim pages.build it creates automatically the md file

Ok, thanks so much
The issue #92 also using Jupyter?

Nope, that one should be pure markdown.
Jupyter should be used just when there are any codes or commands to be executed.

although we don't have all the blog posts initially proposed, but it is enough for now.
envers and astx need a bit more work in order to have a blog post.


Tunable d3 forceLayout

Elevator Pitch
Force layout diagrams will be more flexible by exposing some of the underlying forceLayout simulation parameters. Specifically the d3Forces link, charge and center can enable tuning of the layout based on communities in the graph.
Motivation
This will let users tune their simulation engine to generate more nuanced layouts.

Different link strengths based on edge weight.
Grouping clusters of nodes based on similarity

Design Ideas
Examples

Multi-Foci Force Layout
Clustered force layout

Is d3.ForceBundle a force simulation or separate edge routing given a particular node layout?

re: forceBundle: no idea. however we expose this, it should be composable with e.g. https://vasturiano.github.io/3d-force-graph/example/tree/
this might be something separate from behaviors, e.g. Layout, .layouts or something


Automatically set executable permissions on commands

Avoid having to have do:"chmod a=rx *" on every as:command entry.
Signed-off-by: Daniel Bayley<EMAIL_ADDRESS>

Is there a particular reason why you changed the file permission from 0644 to 0755 or was it just by mistake?

@NigoroJr I'm not sure how/why that happened… I certainly didn't do it manually. I think it might have been an Atom package that sets permissions.

Okay thanks, just wanted to make sure :smiley: I know Emacs looks at the shebang and does that too.

Oh, I didn't notice this was for v1. @danielbayley Could you make the same change for v2? The master branch is going to be replaced with v2 soon.

@danielbayley Any update on this? I can make the same changes for v2 instead if you'd prefer that way.

@NigoroJr See #133


Revisit "Detail Icon"-Styling and adapt if necessary (OldTitle: Check Form Features Icons)

It'd be great to check form features icons and see if they're suitable or not. To check if they may give a wrong idea. For example, in this case:

At first sight one user thought this feature was related to settings or support.

Maybe we need to find and add an open-source icon library instead, we are currently limited by having to create every individual icon ourselves, and thus resorting in alot of todos and duplicate icons

There is, e.g. the Feather Icon Library.
Also, I've recently heard that a big company was creating a CC0 icon library, I think it was blender. I couldn't find anything just now, but I'll update this if I remember where that was.


bump versions & fix CRDs

bump versions & fix CRDs

Codecov Report

Merging #834 (4de00e3) into master (750afd3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
- Coverage   80.81%   80.78%   -0.03%
==========================================
  Files         133      133
  Lines        4633     4633
  Branches       97      102       +5
==========================================
- Hits         3744     3743       -1
- Misses        889      890       +1

Impacted Files
Coverage Δ

...ain/scala/com/ing/baker/runtime/PollingAware.scala
100.00% <ø> (ø)

...la/com/ing/bakery/baker/InteractionDiscovery.scala
85.10% <0.00%> (-2.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 750afd3...4de00e3. Read the comment docs.


[Bug] Spleeter Separate on custom trained model tries to download another model

Description
I have trained a custom model and the separate function does not work as intended as it tries to download the model from a nonexisting url.
Step to reproduce

Created custom model training data / specs annotated in the custom_model_config.json
Trained model (succesfully, apparently) using !spleeter train -p "custom_model_config.json" -d "PathToCustomDataset". I check that the trained model folder is created.
When trying to separate a file using !spleeter separate -o sep_out -p "custom_model_config.json" "test.mp3"

The function tries to download the model from a url which obviously does not exists. Why is this happening?
Output
tcmalloc: large alloc<PHONE_NUMBER> bytes == 0x556df36f0000 @  0x7f9e527bf1e7 0x7f9e4ef5f631 0x7f9e4efc3cc8 0x7f9e4efc3de3 0x7f9e4f061ed8 0x7f9e4f062734 0x7f9e4f062882 0x556d45843f68 0x7f9e4efaf53d 0x556d45841c47 0x556d45841a50 0x556d458b5453 0x556d458b04ae 0x556d458433ea 0x556d458b232a 0x556d458b04ae 0x556d458433ea 0x556d458b160e 0x556d4584330a 0x556d458b160e 0x556d458b04ae 0x556d458433ea 0x556d458b160e 0x556d458b04ae 0x556d458433ea 0x556d458b232a 0x556d458b04ae 0x556d45782e2c 0x556d458b2bb5 0x556d458b07ad 0x556d45782e2c
INFO:spleeter:Downloading model archive https://github.com/deezer/spleeter/releases/download/v1.4.0/bach10_model_2.tar.gz
Traceback (most recent call last):
  File "/usr/local/bin/spleeter", line 8, in <module>
    sys.exit(entrypoint())
  File "/usr/local/lib/python3.7/dist-packages/spleeter/__main__.py", line 256, in entrypoint
    spleeter()
  File "/usr/local/lib/python3.7/dist-packages/typer/main.py", line 214, in _call_
    return get_command(self)(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 829, in _call_
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/typer/main.py", line 497, in wrapper
    return callback(**use_params)  # type: ignore
  File "/usr/local/lib/python3.7/dist-packages/spleeter/__main__.py", line 137, in separate
    synchronous=False,
  File "/usr/local/lib/python3.7/dist-packages/spleeter/separator.py", line 382, in separate_to_file
    sources = self.separate(waveform, audio_descriptor)
  File "/usr/local/lib/python3.7/dist-packages/spleeter/separator.py", line 325, in separate
    return self._separate_librosa(waveform, audio_descriptor)
  File "/usr/local/lib/python3.7/dist-packages/spleeter/separator.py", line 269, in _separate_librosa
    sess = self._get_session()
  File "/usr/local/lib/python3.7/dist-packages/spleeter/separator.py", line 241, in _get_session
    model_directory: str = provider.get(self._params["model_dir"])
  File "/usr/local/lib/python3.7/dist-packages/spleeter/model/provider/__init__.py", line 80, in get
    self.download(model_directory.split(sep)[-1], model_directory)
  File "/usr/local/lib/python3.7/dist-packages/spleeter/model/provider/github.py", line 141, in download
    response.raise_for_status()
  File "/usr/local/lib/python3.7/dist-packages/httpx/_models.py", line 1103, in raise_for_status
    raise HTTPStatusError(message, request=request, response=self)
httpx.HTTPStatusError: 404 Client Error: Not Found for url: https://github.com/deezer/spleeter/releases/download/v1.4.0/bach10_model_2.tar.gz
For more information check: https://httpstatuses.com/404

Environment

OS
Linux (Colab environment)

Installation type
pip

RAM available
16GB

It appears that you need to move your model to the pretrained_models folder after you've trained it in order for the separate command to be able to find it.

Where should be that pretrained_models folder? I cannot find it

It appears that you need to move your model to the pretrained_models folder after you've trained it in order for the separate command to be able to find it.

Where should be that pretrained_models folder? I cannot find it

I think it's created automatically when you run separate without specifying a custom model, and it downloads the default 2stems. You should be able to just create it manually in the same folder as your config.json file.

@GelflingHand perfect! I have been able to load a custom pretrained model from such folder, and now this issue is solved. Thanks!


[stable/drone] Add services permission to pipeline role

What this PR does / why we need it:

Bump drone version to RC7 release
Add services to the pipeline service account role in role-pipeline.yaml

If the pipeline Service Account does not have services permission, Drone pipelines that require services will fail with an error similar to:
default: services is forbidden: User "system:serviceaccount:default:[release-name]-drone-pipeline" cannot create services in the namespace “ixjox3za1ed8vi8wspzgj"

This can be reproduced by running the current chart with any pipeline that uses services (e.g. drone-demo-elasticsearch).
Adding services to the pipeline Service Account role fixes the issue.
Checklist

[x] DCO signed
[x] Chart Version bumped

/assign @christian-roggia

Once #11054 is merged you can bump the version and I will merge this PR. Thank you!

/lgtm cancel

/lgtm


state.cleanup.delay.ms default is 600,000 ms (10 minutes).

If I'm counting my zeros correctly, I believe the default cleanup delay is 600_000ms, not 6_000_000 as written in the docs.
Default value here: https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java#L681
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

\cc @ableegoldman @vvcephei for review

Merged to trunk and cherry-picked to 2.2, 2.1, 2.0, 1.1, and 1.0.
Thanks for the fix @cwildman!


Back-end with runtime part

There are a lot of new stuff, so if you don't understand something i will try to explain why i did in that way and what i wanted to do.
Stefano

I have to set some code standards, otherwise this project would be complete anarchy.
First add your eclipse settings and other config files to .gitignore. That shouldn't be in the code repo.
Second the 3 million lines added is way way too much. I have tried to limit the XML file length to keep the project manageable. Please remove all but 1 of those BPMN challenge files as they really arent that needed for development. If you do need them just put them in some other folder outside this repo.
Third, are the Redis files like supervisord.conf.save really needed?

I know there is too much code, infact is not finished yet. At the beggining I was insicure on what to do so I added code instead of changing yours. The aim of this pull request is to have the same fix to issues. At the moment for me is important to have something that works and move on to the front-end. When I will have a working UI I will clear the code to let it be manageable. And i completed forgot about the .gitignore, sorry. For the third one the answer is no.

By the way the 3 millions line are there because i saved all the models and the BPI logs also

.travis.yml is actually important. Automated tests cant run without it. Add it back and fix the errors.

I put it back but I don't understand why yesterday everything worked fine and now not

Seems to be  ImportError: cannot import name 'imap'

I can't really merge without this build being fixed. Automated tests are what keep this project working.

I know, but I can't understand why it worked yesterday, and not today. I didn't change anyhting, I only deleted models and logs from folders

Ok, imap problem is solved, now i have to change all the tests to let them work with my code

I recommend that you do further development in branches on this repository because the automated testing is already set up. When you need to present it then you can fork it under your own name.

There is one last test that doesn't work, I'm trying to fix it

There is one test where It compare results of next_Activity that sometimes works and sometimes not, so I think it's a problem of the model he creates with scikit_learn functions, can I comment the line where results are compared?

If the tests results are inconsistent then try to match at least part of the results. If even that is unreliable then match that there is something in the result. The aim of the calculation tests is to make sure everything works end-to-end.

In my opinion the problem is that with a training set with 4 entry the program can't create a precise model, so sometimes it will creates the right model that give that resultset, and othertimes create a slightly different model that is not correct for the results you want

Are the binary files all needed?

Which binary files? I think the only thing i can remove is the folder src/
All the rest is needed. Now i'm going to remove that folder

Can't the files in model_cache be generated automatically? If so can it be .gitignored? I'd rather not have them in the repo. But if they really are needed then that is the final thing.

They are needed for the travis testing, because when it does the training part it doesn't phisically create models, but when it has to load them he can't reach the path, so I was thinking we can leave there only the few models needed for the testing but anyways starting to ignore that folder

Well remove what you can to keep it minimal. If you can't then I'll merge the PR.

I think i can't remove more than this


Feature/tb user batch import

这个 PR 实现什么功能/修复什么问题:

yunionapi新增批量导入用户接口

是否需要 backport 到之前的 release 分支:

release/2.13

/area apigateway
/cc @swordqiu @yousong

/hold

/hold cancel

Codecov Report

Merging #4083 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4083      +/-   ##
=========================================
- Coverage    6.85%   6.84%   -0.02%
=========================================
  Files         519     519
  Lines       87905   87905
=========================================
- Hits         6023    6014       -9
- Misses      81383   81394      +11
+ Partials      499     497       -2

Flag
Coverage Δ

#aFlag
6.84% <ø> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/cloudcommon/cronman/cronman.go
49.51% <0%> (-5.34%)
:arrow_down:

pkg/appsrv/response.go
69.23% <0%> (+3.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3693d87...256b629. Read the comment docs.

/lgtm

/lgtm

/approve


Possible bug in 0.20 release for Google Maps provider

Is this a bug report?
Yes :
After upgrading to 0.20 iOS map is displayed instead of Google Map, i rolled back to the 0.19 release and it's working fine.
Environment
react-native: 0.53.0
react: 16.2.0
11.2 Simulator/iPhone 6 Plus
bug?: react-native-maps: 0.20
working: react-native-maps: 0.19
Steps to Reproduce
upgrade to 0.20 release

@loic-lopez can you give more details, is anything special you did or just simply updating the module?

@rborn
I did :
npm-check-updates -u npm install cd ios/ pod update react-native run-ios

I'm getting the same issue. iOS is using MapKit instead of Google Maps, even though Google Maps is specified as our preferred provider and was functioning properly in 0.19.0.
<MapView ref={ref => {this.map = ref;}}
    provider={PROVIDER_GOOGLE}
    zoomEnabled={true}
    showsUserLocation={false}
    onPress={Keyboard.dismiss}
    style={styles.container}
    region={this.state.region}
    onRegionChangeComplete={this.onRegionChangeComplete}
    loadingEnabled={false}
    pitchEnabled={false}
    showsCompass={false}
    showsScale={false}
    showsIndoors={false}
    showsIndoorLevelPicker={false}
    customMapStyle={config.map.style}>

    ...

</MapView>

"react": "^16.2.0",
"react-native": "^0.53.0",
"react-native-maps": "^0.20.0"

@rborn any ideas? This seems like a pretty big issue. I'm surprised it didn't get caught in testing before being released.

@alvelig I meant no disrespect. I understand this is a community effort. That being said, I think it would make more sense to mark brand new untested/lightly-tested versions as release candidate pre-releases. Myself and others would be happy to help test and diagnose issues. The only reason I hadn't done so for this one is because I had no way of knowing if @rborn or another Collaborator was already investigating. If there is a Slack, Discord, etc... that already exists or could be set up to communicate, it could go a long way. Just food for thought.
As for this issue, I have started to pinpoint the problematic commit. So far I have determined that it is somewhere in between 0d540b9b7d3fc2c97262b4a9655ad97202a3992d and f553317fcaa2e3a4889f38c4bb2e215693f3f20c. I should be able to report the exact commit shortly.

@christopherdro do you mind creating a react-native-maps slack and sharing invite link in #1807

@alvelig I found the culprit.
Commit 9f3c5f6e8be3f95335de20fda073d3edceb2c850 is where this issue started.

@wbattel4607 THX!!! Try latest master, it contains hotfix.
https://github.com/react-community/react-native-maps/commit/cd868ea7b33a04c8bdd5e909cf134a133b2cb316

@alvelig just tried with cd868ea7b33a04c8bdd5e909cf134a133b2cb316 and I'm happy to report that it works!

That was the border case.
If you did MapView.PROVIDER_GOOGLE or 'google' it would have worked 🙄

@christopherdro can we make a push to npm for this hotfix? 🤗

Fixed in 0.20.1


How to run google Drive in Ubuntu Devices

Could you please provide more information.

Closing, please reopen with more detail.


Remove aliases.

These were used for transitional purposes and are no longer needed.
CC @UniqMartin

:+1:


Allow Opensearch as backend instead of Elasticsearch

Verify future versions of Opensearch as this is becoming a very viable option as an Elastic replacement and it is fully open source as opposite from Elastic that has started to limit the usage. Right now version 7 and Opensearch 1.x are quite compatible but who knows if things will diverge in the future.
We have several Opensearch clusters available to use for indexing but installing and maintaining Elasticsearch and purchase licenses just for Arkime usage might not be a viable option, and I think others might have the same issue. Especially if you require things like AD logins and such.

Opensearch is already supported, are you having an issue?

Version 1.xx is since it is Elastic v7 compatible I am assuming, but reading the manual I see no direct mention of Opensearch and since Opensearch is forked from Elasticsearch 7.10 I fear that the two might diverge along the line. Or is it simply because you haven't just written it into the manual yet?
I am simply concerned going forward with installation and then not be able to upgrade further down the line so to say.

Ok, but the title of the issue is "Allow Opensearch as backend instead of Elasticsearch", which we already do.
Yes they will diverge someday. We hope to continue to support both. Just like we hope to never require any pay Elasticsearch features.
If you really just want to see the text for Elasticsearch updated in the docs we would gladly accept pull requests. Although I'm not sure how to phrase "Elasticsearch/Opensearch/Opendistro compatible ..." which is one reason for now we've just left it.
Closing this issue for now, feel free to add a comment if I'm missing something or even better come on over to slack and discuss.

hey @awick, is the list of Elastic APIs used by Arkime documented somewhere? I was thinking maybe someone could come up with a shim to plug other DBs to it just by simulating ES APIs


Ability to retrieve name of invoked hostcall in call hook

Feature
I'd like a way to retrieve the name of the invoked hostcall in a call hook. Ideally getting the arguments and return values would also be useful.
Benefit
Adding this feature would allow me to log the name of the invoked hostcall. We have third party developers writing wasm modules running on something we've built around wasmtime and we'd like to offer a trace feature so those developers can see what hostcalls are being invoked and roughly when they are invoked relative to other parts of their modules. Including arguments and return values could also be useful in that context.
Implementation
I do not have an implementation plan at this time.
Alternatives
I'd be open to using a different API than the call hook one if it allows me to do something similar where a callback is invoked with sufficient context available to determine the hostcall name. Alternatively, if there were a way to define a decorator around the WASI hostcalls, that could also work, since I could just instrument other hostcalls.

One idea I had for this is some sort of injection wrapper in Linker where you could have something like Linker::pre_hook or similar. A small caveat is that you'd have to define said pre_hook before calling any other Linker function to define an item, but that's not necessarily the end of the world.
Another idea is a specific hook on WasiCtxt itself, although that would probably want integration with wiggle to generate calls to such a hook rather than us having to manually do it.
In both of these schemes though you wouldn't have access to parameters or return values. That's actually pretty difficult to do I think in the sense that having a uniform representation for arguments and returns can generally be quite inefficient.
If all you need is logging though wasi-common should already have logs for arguments in/out of hostcalls, so if the end goal is just a few prints that may suffice as well?

If all you need is logging though wasi-common should already have logs for arguments in/out of hostcalls, so if the end goal is just a few prints that may suffice as well?

I confirmed that it does and this seems to work for our purposes for the time being. Thank you! That being said, having this be part of an API instead of an implementation detail would help us avoid relying on the these log calls being present as part of how we provide hostcall tracing. But what's currently there is good enough for now.


PoC Bucketed rate limit

A query needs to be passed with the following header:
Solr-Request-Type: QUERY
As per below configuration, a query should be passed with a query parameter ?q-bucket=test-bucket
Example clusterprops.json:

    {
      "rate-limiters": {
        "readBuckets": [
        {
        "name": "test-bucket",
        "conditions": [{
          "queryParamPattern": {
            "q-bucket": "test-bucket"
          }
        }],
        "allowedRequests": 2,
        "slotAcquisitionTimeoutInMS": 1000
      }

        ]
      }
    }

@noblepaul The tryWaitAverage is always 0, there's a possible bug.

Couple of questions

is ?q-bucket=test-bucket is enough. it's not clear to me the need of request header
probably we can define two buckets foreground and background ?
when we can have multiple conditions ?
also "slotBorrowingEnabled":true feature is there? this seems interesting

is ?q-bucket=test-bucket is enough. it's not clear to me the need of request header
actually both are required.

The request header requirement is something we may be able to get rid of. the only reason it is there is because the current design requires that

probably we can define two buckets foreground and background ?

can you please elaborate?

when we can have multiple conditions ?
you could add multiple conditions . it's not very useful but , it's just there for completeness

also "slotBorrowingEnabled":true feature is there? this seems interesting

this is not done. let me explore that

The request header requirement is something we may be able to get rid of. the only reason it is there is because the current design requires that

if it not require then just remove it.

probably we can define two buckets foreground and background ?
can you please elaborate?

We have two types of requests, one from customers and other is background job.  Thus wondering we can create two buckets for this, where customer request will get more preference but background job should not execute query requests more than n.

when we can have multiple conditions ?
you could add multiple conditions . it's not very useful but , it's just there for completeness

Same as above if not require just remove it. I think one param is more than enough?

also "slotBorrowingEnabled":true feature is there? this seems interesting
this is not done. let me explore that

that maybe helpful in two bucket scenario

@hiteshk25

The request header requirement is something we may be able to get rid of. the only reason it is there is because the current design requires that
if it not require then just remove it.

According to the current design, the feature kicks in only if the header is present. if we remove it, it may not be backward compatible

We have two types of requests, one from customers and other is background job. Thus wondering we can create two buckets for this, where customer request will get more preference but background job should not execute query requests more than n.

There is already an implicit bucket which has an unlimited no:of threads. Only explicit bucket is just throttled. So, we should create a just a bucket for background tasks and limit the no:of operations and leave the rest as is

@noblepaul

According to the current design, the feature kicks in only if the header is present. if we remove it, it may not be backward compatible

Nice, then can we just accommodate header only?

According to the current design, the feature kicks in only if the header is present. if we remove it, it may not be backward compatible
looks like it not documented if the header is present? Or I can't find it

Nice, then can we just accommodate header only?

You mean, do not support parameters ?

I want to understand current behavior(limitation, etc)- how this get triggered(http header?)
based on above http header will work to point the new bucket?


Adds basic infrastructure for RPC request sampling

This adds an abstraction layer for RPC, based on non-deprecated code in
brave-instrumentation-http. It will be a work in progress until at least
Dubbo and gRPC are integrated (ideally also Armeria even though in
another repo.
This is limited to sampling logic to make it easy to integrate and also
as that's the more in-demand functionality. Most notably, we only need
two properties: RPC service and method, to satisfy the first use cases
of RPC sampling.
Ex. Here's a sampler that traces 100 "GetUserToken" requests per second. This
doesn't start new traces for requests to the health check service. Other
requests will use a global rate provided by the tracing component.
import static brave.rpc.RpcRequestMatchers.*;

rpcTracing = rpcTracingBuilder.serverSampler(RpcRuleSampler.newBuilder()
  .putRule(serviceEquals("grpc.health.v1.Health"), Sampler.NEVER_SAMPLE)
  .putRule(methodEquals("GetUserToken"), RateLimitingSampler.create(100))
  .build()).build();

grpcTracing = GrpcTracing.create(rpcTracing);

Thanks @trustin for helping me think through namings and such

added gRPC impl

@anuraaga PTAL again at grpc as I'm switching to dubbo meanwhile. thanks for the review!

@anuraaga yeah the idea is to do parsing and agreed it is more straightforward in google grpc which hides the transport. Due to issues like you mentioned, I wanted to keep the simple part (sampling) separate.. this keeps the latter change concentrated on these bits (including if http request should have a nullable getter for rpcRequest or not)

suprisingly I didn't mention this earlier, but #999 will be rebased over this, and has scope for parsing etc.

so one thing I will clear up in the text is that the method name is not required to be different than the java method. There are java based RPC, of course, like Dubbo. It is just preferred to use IDL when something is backed by IDL. We cannot enforce that there is always going to be IDL in other words.

I added apache dubbo. Last thing is to convert that code to alibaba dubbo

Thanks for the help!


Update popover menu check to use isEmpty

cc @parasharrajat
Details
This PR fixes an issue where an empty string value used in a conditional render results in a mobile crash. The explanation of why this happens and why this is my recommended fix can be found in https://github.com/Expensify/App/issues/6198#issuecomment-960345451.
Fixed Issues
$ https://github.com/Expensify/App/issues/6198
Tests/QA

Launch the app and login with expensifail account
Click the FAB button and select Send money
Enter an amount and tap Next button
Select an attendee from the list
Tap the payment selection button.
Confirm options show up

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

iOS
Web

Adding CP staging label to fix deploy blocker

Thanks, Jack, I missed that. Looks like that component was not following guidelines :smile:  .

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.13-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@roryabraham As long as page is not freezing and user is redirected to Onfido flow its a pass right? We do not see the "Pay with expensify" option in some cases.
https://user-images.githubusercontent.com/43995119/140415585-5dbe369b-e0aa-4077-91ae-55981a831669.mp4

@mvtglobally That looks like a pass to me 👍

🚀 Deployed to production by @yuwenmemon in version: 1.1.13-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by @roryabraham in version: 1.1.13-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Jag96 in version: 1.1.14-4 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Adding a logo

We can add a logo to the website. I have experience with designing. Please design it to me under Gssoc.

@samridhi171 Have you any design

please assign me this issue...

@samridhi171 Have you any design
I can make a few and send them to you! I can try something pixelated. like the theme of the game.


time: adjust time zone offset if desired location differs mere seconds when parsing string

This PR aims to fix an issue where a time.Time object was seconds off after having been converted into a string using Format with RFC3339 and back using ParseInLocation.
For illustration, a copy of the test that was added to this PR.
https://go.dev/play/p/5t8wa3b_ahv
Fixes #53919

I reviewed all files!


Lose focus when close the terminal

I was trying to see some doc on my browser and continue to write some code on Atom.
When I change back to Atom and close the terminal, it can't focus on the text field I was writing before. Instead, it focused on the little toolbar on the bottom of Atom.
Then I manually open and close the terminal with the button on that toolbar, it happened again in the same way.
I wonder if there are some ways to focus on text field that I'm using using keyboard only instead of mouse?

Please retest again with platformio-atom-ide-terminal 2.9.0 is using node-pty-prebuilt instead unmaintained and outdated pty.js
if issues persist open a new ticket with required information.
I cannot reproduce issue in 2.9.0.
Thx =)


Scikit learn

Build is working (alongside the correct Python path with the change in Travis). 6 new models are implemented, but their traits still need correct defining.

Great. I have added some tests, which fail when we replace your Xr and yr with real data (the Boston dataset). Can you have a look please?
Otherwise, looking good. Still to do:

add trait functions
wrap in a SVM submodule (the load_paths are then,
"MLJModels.ScikitLearn_.SVM.SVMClassifier" and so forth
add minimal doc string (can just link to the sklearn documentation

I'll have a closer look at this tomorrow so I can see the types of each task to see it's dispatched correct. Just a quick question, we seem to be mixing the Iris and Boston dataset? maybe this is introducing the error?

Yiannis,
I've added more rigorous testing (tests on artificial linear data) and resolved your bugs. The main issues were:

failure to test regression fit methods on tabular data (you were testing on matrix data)
confusion about what the regressor/classifier distinction means

For the second, here is a quote from the guide:
The form of the target data y passed to fit depends on the kind of
supervised model. For "regressors", y is a vector, for "classifiers"
it must be a categorical vector. More precisely, the form is
determined by value returned by the trait output_kind that each model
type should define (see below):

output_kind return value
type of y

:continuous
Vector{<:AbstractFloat}

:binary
CategoricalVector

:multiclass
CategoricalVector

:ordered_factor_finite
CategoricalVector

:ordered_factor_infinite
Vector{<:Integer}

So y for a regressor is a Vector{<:AbstractFloat} (and there is none of that decoding jazz), while for a classifier y is a CategoricalVector and we need to worry about preservation of levels as described later in the guide.
Small note: there is no need to annotate the types of X, y and Xnew in your methods.  And there is no point writing methods to deal with alternative form of data because they will be invisible to the higher level API.
You probably want to go over the changes I have made to src/ScikitLearn.jl.
See earlier comments for what is still left for you to do.
Thanks

I'm sorry, but I am rethinking the "wrap in submodule" plan.  If need be, we might need to rename the src file ScikitLearnSVM.jl but leave it for now, thanks.

That's fine about the module. I'll fix the other things and add the DT in due course. I'll also go over the XGBoost code and make similar changes, so classifiers work on Categorical data and regressors on plain vectors their also.

Okay. I'm ready to pull as soon as the doctoring and clean! methods are done.

Please separate move the additions to DecisionTree.jl to a separate PR - they have nothing to do with the current Scikitlearn PR.

Thanks.


[FLINK-15138][e2e][python] Add PyFlink e2e tests.

What is the purpose of the change
This pull request adds the PyFlink e2e tests, which includes 1 python job, 4 python udf sql job and 1 python udf sql-client job.
Brief change log

Add a new project flink-python-test in the flink-end-to-end-tests.
Add a new script test_pyflink.sh in the flink-end-to-end-tests/test-scripts folder.
Add the python e2e test call to the `flink-end-to-end-tests/run-nightly-tests.sh script.

Verifying this change
This change is already covered by existing tests, such as flink-end-to-end-tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@dianfu Thanks for your review! I have addressed your comments.

https://dev.azure.com/weizhong0618/Flink/_build/results?buildId=97&view=logs&j=1f3ed471-1849-5d3c-a34c-19792af4ad16&t=2f5b54d0-1d28-5b01-d344-aa50ffe0cdf8

@dianfu It seems the e2e test has passed in my Azure build.


Build a plugin system for the web

Use web components as a plug n play

Plugin listing and loading UI done with #31


Fix some of the TODO items in the project under openfoodfacts.github.scrachx.openfood

Summary:
There are almost 17 items listed as TODO in the project. Which can be completed. I'll take these tasks one by one and send PRs here
Steps

Go to TODO section in your project
Check openfoodfacts.github.scrachx.openfood module

Some of the TODOs to work upon are

[ ] AdditiveNameTest.java : update empty constructor to set isWikiDataIdPresent to false
[ ] AdditivesWrapperTest.java : fix so that this test passes. Currently gives a null pointer. (Well for me I didn't see any null pointer exception. Can the mentors please verify this)
[ ] CategoryNameTest.java : update empty constructor to set isWikiDataIdPresent to false if possible
[ ] NutrimentsTest.java :  in Nutriments, make the key endings public Strings, or at least turn them into variables
[ ] SendProductTest.java : add PowerMock to test compress()
[ ] ToUploadProductTest : should make product field strings public static fields in ToUploadProduct or use toString from
[ ] UnitUtils.java : what about % DV and IU

@teolemon @deniger @huzaifaiftikhar for the To-Do item:
UnitUtils.java : what about % DV and IU

This is the conversion system that is followed, could you please help me where can I info of the Vitamin present or if not, then what can be done with this?


python311Packages.aiomisc: 17.3.25 -> 17.3.41

Changelog: https://github.com/aiokitchen/aiomisc/blob/master/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 269051 run on x86_64-linux 1

24 packages built:

python310Packages.aio-pika
python310Packages.aio-pika.dist
python310Packages.aiofile
python310Packages.aiofile.dist
python310Packages.aiomisc
python310Packages.aiomisc-pytest
python310Packages.aiomisc-pytest.dist
python310Packages.aiomisc.dist
python310Packages.aiormq
python310Packages.aiormq.dist
python310Packages.caio
python310Packages.caio.dist
python311Packages.aio-pika
python311Packages.aio-pika.dist
python311Packages.aiofile
python311Packages.aiofile.dist
python311Packages.aiomisc
python311Packages.aiomisc-pytest
python311Packages.aiomisc-pytest.dist
python311Packages.aiomisc.dist
python311Packages.aiormq
python311Packages.aiormq.dist
python311Packages.caio
python311Packages.caio.dist


I have 3 problem when i upgrade

Package
filament/forms
Package Version
v2.7.1
Laravel Version
v8.77
Livewire Version
No response
PHP Version
PHP 8.1
Bug description

public static function form(Form $form): Form

Forms\Components\HasManyRepeater::make('categories')
                    ->schema([
                            Forms\Components\TextInput::make('title')
                    ]),

or
Forms\Components\Repeater::make('categories')
                    ->schema([
                            Forms\Components\TextInput::make('title')
                    ]),

Default render one, but shouldn't none of them be rendered by default? One should be added only by clicking the Add button.

FileUpload upload image work fine, sometimes the image is not displayed but can be submitted normally
App\Forms\Components\SomeForm has a fileupload filed, but upload field is array, I have to expand the array manually , It was normal before

Forms\Components\FileUpload::make('image')->image()

/////////////////

    public function saveRelationships(): void
    {
        $state = $this->getState();
        $model = $this->getModel();
        $relationship = $model->{$this->getRelationship()}();
        $state['image'] = is_array($state['image']) ? Arr::first($state['image']) : $state['image']; // there

        if ($setting = $relationship->first()) {
            $setting->update($state);
        } else {
            $relationship->updateOrCreate($state);
        }

        $model->touch();
    }

submit like this
['image' => ['uuid-uuid-uuid-uuid' => 'xxxxxxxx.png']]

but i need
['image' =>  'xxxxxxxx.png']

Steps to reproduce
No response
Relevant log output
No response

Hey, can you make sure that your assets are also on the latest version (run Laravel Mix to compile them & php artisan view:clear)?

I deleted the project and re-downloaded it from git and it still does it

Addressing your other points:
We've made it default behaviour to have 1 item filled by default on the repeater. It's not great UX to have to click a button to add one manually each time. To disable this, you can pass defaultItems(0) to the repeater. Obviously, the default item is not created when you have existing data, only when you $form->fill().
With regards to the file upload change - we recently added better support for multi-uploads, and this was one of the changes we made to ensure that the code was clean. Instead of having to check if the upload is multiple every time & changing the state from array to string, we always have the state as an array and then dehydrate it as a string if there is only 1 file uploaded. We don't guarantee that there won't be breaking changes when you override parts of our internal form components, so just be careful in the future to check the changelog of the project before upgrading to make sure you're not overriding anything important.

@danharrin but set defaultItems(0) have two items?

@danharrin but set defaultItems(0) have two items?

Oh haha, I didn't know that was a bug. I fixed it in #1025.

Should be working now on the latest release?

Should be working now on the latest release?

It's working

@danharrin
With regard to file upload, when the title field is not empty, the picture will not be displayed. When the title field is empty, the picture will be displayed normally
https://user-images.githubusercontent.com/52574911/147521856-17d6510c-3b36-4c6c-a336-bf6c5d282779.mp4

Can I have some code to replicate that problem please?

Forms\Components\Group::make()->schema([
                Forms\Components\Card::make()->schema([
                    Forms\Components\TextInput::make('title')
                        ->required()
                    Forms\Components\DateTimePicker::make('start_at')
                        ->displayFormat('Y-m-d H:i:s')
                        ->default(now())
                        ->required(),
                    Forms\Components\DateTimePicker::make('end_at')
                        ->displayFormat('Y-m-d H:i:s')
                        ->default(now()->addDays(2))
                        ->required(),
                    Forms\Components\FileUpload::make('cover')
                        ->required()
                        ->image(),

This should be fixed in the latest version - let me know if not.

This should be fixed in the latest version - let me know if not.

it's working


App version

Related Issues

Closes #176
Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[ ] I read and followed contribution rules

@ymaheshwari1 Please review the PR.

Closing as the component in dxp has been updated and thus this issue will be handled differently.


Merge dev model into master

Created by: JimnyCricket
Merge the dev branch into the master branch when satisfied with the performance of the new layers.

Created by: brollb
I think this has been done. Before I did some recent updates to the CNN seed, the only differences with CNN-dev was the Pooling layer being named MaxPooling


continuous swipe update

Hey! I've needed to get continuous swipe events, i.e. events while the user is swiping, to move elements along as the user is moving their finger over the screen. I think, this is not possible with svelte-gestures if I'm not mistaken. A friend and I have ported the react-swipable library to svelte (https://github.com/react2svelte/swipeable) to do this (If you'd like to link to it, I'd be very happy :) )
I'm making this ticket to let you guys know that this functionality is quite useful and and implementation exists, I think maybe it would be nice to also merge it in here. If I find some time I might look into it, but if someone else is keen, feel free to take it! I think it would be great to have one place for anything swipe-releated, but the libraries should work fine next to each other as well!

There is the PAN action for this


Markdown to HTML for blog page.

I get the editor has a preview feature but what I'm after is if it offers a function to just output the markdown to HTML.Much like editing a blog post saving the markdown to the database then rendering the markdown as HTML on the client.
The function is like marked.js do ,I find it is hard to render same html page like that easyMDE render preview when try to include marked.js ,the differrence is feature code and poetry.Furthermore  Blockquotes of easyMDE don't have solid border-left like simplemde markdown editor.
My Demo
<!DOCTYPE html>

    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Example / Preview</title>
    <link rel="stylesheet" href="https://unpkg.com/easymde/dist/easymde.min.css">

Demo

        <button onclick="myFunction()">Click me</button>
        <textarea id="demo1" style="display: none;"># Hello world</textarea>

Seems like something that should be included...
Reply appreciated.

You can probable force the editor into preview mode using the EasyMDE.togglePreview(editor); method and remove the toolbar.
Removing the word counters is also possible.

You can probable force the editor into preview mode using the EasyMDE.togglePreview(editor); method and remove the toolbar.
Removing the word counters is also possible.

Give me a big inspiration,Thank you.

What we use was very simple:
const easyMDE = new EasyMde( ... );
easyMDE.markdown(easyMDE.value());

this returned the html code from markdown

What we use was very simple:
const easyMDE = new EasyMde( ... );
easyMDE.markdown(easyMDE.value());

this returned the html code from markdown

The returned html code has no css class style like easyMDE‘s preview mode which include blockquote and code.

Still no solution? .markdown method returns ... whereas converting to HTML should just return
...
.

When you want to render the content without using the editor you can use the official https://marked.js.org/ which EasyMDe uses internally doing this for example you will get the desired result

document.getElementById('content').innerHTML = marked.parse('# Marked in browser\n\nRendered by **marked**.');
....
document.getElementById('content').innerHTML = marked.parse(easyMDE.value());

One issue that I have is that if my user submits
*{
background-color: red;
}
my whole sites becomes red, they can sort of "exploit" and make "ugly" content and affect other divs.
Ideally inline is cool for them to create stylized content, but if they can change the behavior outside the "sandbox" it is quite bad.
I switch from SimpleMDE do EasyMDE because for SimpleMDE I had to write a custom solution to avoid XSS.
Now I am afraid I might need to ditch and filter all html and don't let my users use it all.

Make sure to read https://github.com/markedjs/marked#usage. EasyMDE does not sanitize the markdown by default.
Options like DOMPurify can be used with the renderingConfig.sanitizerFunction option. Look here for an example.

Make sure to read https://github.com/markedjs/marked#usage. EasyMDE does not sanitize the markdown by default.
Options like DOMPurify can be used with the renderingConfig.sanitizerFunction option. Look here for an example.

Yes, I've filtered what users can or can't do on the backend, but it seems that it is safe against most XSS attacks right?
I was talking HTML/CSS, since I am actually very permissive and let my users customize their profiles with custom HTML, right now it looks kinda safe.
I tried all the XSS exploits I know and EasyMDE was able to avoid them out of the box, which is amazing.


Several minor fixes in gradle scripts

I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

Rebased, merged.
@shuraa thanks for the contributions! Looking forward to more.
Please limit commit headlines to 50 chars - see the contribution guidelines.
Thanks again!

@garyrussell, got it.


What is the best way to wait for a custom event?

My solution would be to inject js code inside the page to hook an handler executed on a custom event and then make the browser wait until the handler is executed.
In other words:
browser.executeScript('window.on('customEvent', function(){
  window.hasBeenTriggered=true;
})
)')
browser.driver.wait(function(){
  return browser.executeScript('return window.hasBeenTriggered;' )===true;
});

Is there a better way to do it?

Please read the contributing guidelines; these types of questions are ill-suited for GitHub. Thanks!


Non reactive simple example

Using the code bellow, connecting to localhost:9000 with my web browser shows no progress. When I kill the server process, the client receives am ERR_CONNECTION_REFUSED.
Using the log in verbose mode, there appear to be two issues. The first is that suave attempted to return an BAD_REQUEST code, which I think indicates something went wrong in websharper.suave, but I don't know what. The second problem is that this BAD_REQUEST code never makes it to the client, due to a socket error, possibly a suave issue.
open Suave.Web
open WebSharper.Suave
open Suave.Types
open System.Net
open System
open Suave.Logging
open WebSharper
open WebSharper.Sitelets

let MySite =
    Application.SinglePage(fun ctx -> Content.Text("Hello world"))

[<EntryPoint>]
let main argv =
    let config =
        { defaultConfig with
            bindings = [ { scheme = Protocol.HTTP ; socketBinding = { ip = IPAddress.Loopback ; port = 9000us } } ]
            logger = Loggers.saneDefaultsFor LogLevel.Verbose
        }
    startWebServer config (WebSharperAdapter.ToWebPart MySite)
    0

The log contained these lines:
[V] 2015-10-19T16:34:38.4130658Z: initialising BufferManager with 827392 bytes [Suave.Socket.BufferManager]
[I] 2015-10-19T16:34:38.4310882Z: listener started in 15.019 ms with binding <IP_ADDRESS>:9000 [Suave.Tcp.tcpIpServer]
[V] 2015-10-19T16:34:43.1699710Z: <IP_ADDRESS> connected, total: 2 clients [Suave.Tcp.tcpIpServer.job]
[V] 2015-10-19T16:34:43.1699710Z: <IP_ADDRESS> connected, total: 2 clients [Suave.Tcp.tcpIpServer.job]
[V] 2015-10-19T16:34:43.1729605Z: reserving buffer: 811008, free count: 99 [Suave.Tcp.tcpIpServer.job] [Suave.Socket.BufferManager]
[V] 2015-10-19T16:34:43.1729605Z: reserving buffer: 802816, free count: 98 [Suave.Tcp.tcpIpServer.job] [Suave.Socket.BufferManager]
[V] 2015-10-19T16:34:43.1779760Z: -> processor [Suave.Web.httpLoop.loop]
[V] 2015-10-19T16:34:43.1779760Z: -> processor [Suave.Web.httpLoop.loop]
[V] 2015-10-19T16:34:43.1789681Z: reading first line of request [Suave.Web.processRequest]
[V] 2015-10-19T16:34:43.1789681Z: reading first line of request [Suave.Web.processRequest]
[V] 2015-10-19T16:34:43.1899963Z: reserving buffer: 794624, free count: 97 [Suave.Web.readMoreData] [Suave.Socket.BufferManager]
[V] 2015-10-19T16:34:43.1899963Z: reserving buffer: 786432, free count: 96 [Suave.Web.readMoreData] [Suave.Socket.BufferManager]
[V] 2015-10-19T16:34:43.2009955Z: reading headers [Suave.Web.processRequest]
[V] 2015-10-19T16:34:43.2050005Z: freeing buffer: 794624, free count: 97 [Suave.Web.split] [Suave.Socket.BufferManager]
[V] 2015-10-19T16:34:43.2120152Z: parsing post data [Suave.Web.processRequest]
[V] 2015-10-19T16:34:43.2150129Z: <- processor [Suave.Web.httpLoop.loop]
[V] 2015-10-19T16:34:43.2971250Z: yielding to OWIN middleware [Suave.Owin]
[V] 2015-10-19T16:34:53.1631597Z: freeing buffer: 786432, free count: 98 [Suave.Web.readMoreData] [Suave.Socket.BufferManager]
[V] 2015-10-19T16:34:53.1641609Z: <- processor [Suave.Web.httpLoop.loop]
[V] 2015-10-19T16:34:53.1661635Z: Socket error while sending BAD_REQUEST, exiting: SocketError Shutdown [Suave.Web.httpLoop.loop]
[V] 2015-10-19T16:34:53.1661635Z: freeing buffer: 811008, free count: 99 [Suave.Tcp.tcpIpServer.job] [Suave.Socket.BufferManager]
[V] 2015-10-19T16:34:53.1671647Z: <IP_ADDRESS> disconnected, total: 1 clients [Suave.Tcp.tcpIpServer.job]

I forgot to mention the version of websharper.suave: <IP_ADDRESS> (retrieved with nuget).

Does it work with Suave 0.32.0-owin2?

I don't know, I can't compile it. Not sure how the build system works. I checked out suave 0.32.0-owin2, built it, dropped the assembly in websharper.suave/packages/Suave.../lib, ran build.cmd and got a compilation error
WebSharper.Suave\Main.fs(43,16): error FS0001: Type mismatch. Expecting a
    MidFunc -> WebPart
but given a
    WebPart
The type 'MidFunc' does not match the type 'HttpContext'

The same problem appears when trying to get to the "/about" page using the client/server suave VS template. (Suave.0.32.1) The the browser keeps waiting and the verbose log shows the "Socket error while sending BAD_REQUEST". I also get the "ERR_CONNECTION_REFUSED" when server is killed.
I was trying to see how the suave request routing and websharper request routing "play together". Unfortunately it doesn't work
[V] 2015-10-20T13:39:59.4693180Z: initialising BufferManager with 827392 bytes [
Suave.Socket.BufferManager]
[I] 2015-10-20T13:39:59.7384970Z: listener started in 294.200 ms with binding 12
<IP_ADDRESS>:9000 [Suave.Tcp.tcpIpServer]
[V] 2015-10-20T13:40:15.4191650Z: <IP_ADDRESS> connected, total: 3 clients [Suave.T
cp.tcpIpServer.job]
[V] 2015-10-20T13:40:15.4191650Z: <IP_ADDRESS> connected, total: 3 clients [Suave.T
cp.tcpIpServer.job]
[V] 2015-10-20T13:40:15.4201601Z: <IP_ADDRESS> connected, total: 3 clients [Suave.T
cp.tcpIpServer.job]
[V] 2015-10-20T13:40:15.4391783Z: reserving buffer: 802816, free count: 98 [Suav
e.Tcp.tcpIpServer.job] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:15.4401760Z: reserving buffer: 811008, free count: 99 [Suav
e.Tcp.tcpIpServer.job] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:15.4411784Z: reserving buffer: 794624, free count: 97 [Suav
e.Tcp.tcpIpServer.job] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:15.4601919Z: -> processor [Suave.Web.httpLoop.loop]
[V] 2015-10-20T13:40:15.4601919Z: -> processor [Suave.Web.httpLoop.loop]
[V] 2015-10-20T13:40:15.4611900Z: -> processor [Suave.Web.httpLoop.loop]
[V] 2015-10-20T13:40:15.4641924Z: reading first line of request [Suave.Web.proce
ssRequest]
[V] 2015-10-20T13:40:15.4651931Z: reading first line of request [Suave.Web.proce
ssRequest]
[V] 2015-10-20T13:40:15.4641924Z: reading first line of request [Suave.Web.proce
ssRequest]
[V] 2015-10-20T13:40:15.5232342Z: reserving buffer: 786432, free count: 96 [Suav
e.Web.readMoreData] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:15.5242298Z: reserving buffer: 778240, free count: 95 [Suav
e.Web.readMoreData] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:15.5242298Z: reserving buffer: 770048, free count: 94 [Suav
e.Web.readMoreData] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:15.5962777Z: reading headers [Suave.Web.processRequest]
[V] 2015-10-20T13:40:15.6131145Z: freeing buffer: 770048, free count: 95 [Suave.
Web.split] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:15.6601453Z: parsing post data [Suave.Web.processRequest]
[V] 2015-10-20T13:40:15.6741547Z: <- processor [Suave.Web.httpLoop.loop]
[V] 2015-10-20T13:40:16.0584072Z: yielding to OWIN middleware [Suave.Owin]
[V] 2015-10-20T13:40:25.3847490Z: freeing buffer: 786432, free count: 96 [Suave.
Web.readMoreData] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:25.3857509Z: freeing buffer: 778240, free count: 97 [Suave.
Web.readMoreData] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:25.3907589Z: <- processor [Suave.Web.httpLoop.loop]
[V] 2015-10-20T13:40:25.3887525Z: <- processor [Suave.Web.httpLoop.loop]
[V] 2015-10-20T13:40:25.5828867Z: Socket error while sending BAD_REQUEST, exitin
g: SocketError Shutdown [Suave.Web.httpLoop.loop]
[V] 2015-10-20T13:40:25.5828867Z: Socket error while sending BAD_REQUEST, exitin
g: SocketError Shutdown [Suave.Web.httpLoop.loop]
[V] 2015-10-20T13:40:25.5868889Z: freeing buffer: 802816, free count: 98 [Suave.
Tcp.tcpIpServer.job] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:25.5878853Z: freeing buffer: 794624, free count: 99 [Suave.
Tcp.tcpIpServer.job] [Suave.Socket.BufferManager]
[V] 2015-10-20T13:40:25.5938936Z: <IP_ADDRESS> disconnected, total: 1 clients [Suav
e.Tcp.tcpIpServer.job]
[V] 2015-10-20T13:40:25.5918987Z: <IP_ADDRESS> disconnected, total: 2 clients [Suav
e.Tcp.tcpIpServer.job]

The issue is caused by the fact that Application.SinglePage doesn't ignore final slashes in URLs, and the URL received from Suave is "http://localhost:9000//" (note the double slash). I am fixing this in WebSharper itself.
@kevinmoesker however I can't seem to reproduce your version of the issue. Are you using the template code "as is"? If not, can you post here your code?

What I do to reproduce the issue:

create a new project using the ""UI.Next Client-Server Application with Suave" template "as is",
start it (debug mode) and try to get the /about page
my issue: the about page does not show and i see the browser waiting

How I reproduce the "Socket error while sending BAD_REQUEST" in the suave log

modify the "Main.fs" code a little bit to start suave in verbose log mode like @deneuxj
start the project and again try to get the /about page from a browser
close the browser window.

The Socket error while sending BAD_REQUEST message will not show before you close the browser window.
So @Tarmil for you the "/about" page is working? Websharper multipage routing combines well with suave? Do you have any suggestions on what I could try, or what info would help you, to make this work?

Okay, I can now actually reproduce too. It is also a double slash issue, I am looking into it. It might be a problem with how we handle owin.RequestPathBase.


[network] tests openssl/gnutls backend for curl

What does this PR do?
Adding more https tests by testing openssl/gnutls against curl and wget
Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

Let's add something so that curl is only downloaded and built once in local dev environments. Maybe check the packages curl has been built with before attempting.


"Too many requests" for all users on forgotPassword even with no prior attempts

Hello,
I get a "Too many requests" for all users on forgotPassword even with no prior attempts. The user_resets table is empty.
Another unexpected behaviour is when I don't set an email address variable it returns "Invalid email address" whereas I would expect this to be an exception. Below is my test code:
`	//Database connection
include_once('../####/######.php');
require '../vendor/autoload.php';
$auth = new \Delight\Auth\Auth($login);
$_POST['email'] =<EMAIL_ADDRESS>try {
$auth->forgotPassword($_POST['email'], function ($selector, $token) {
echo 'Send ' . $selector . ' and ' . $token . ' to the user (e.g. via email)';
});
echo 'Request has been generated';

}
catch (\Delight\Auth\InvalidEmailException $e) {
die('Invalid email address');
}
catch (\Delight\Auth\EmailNotVerifiedException $e) {
die('Email not verified');
}
catch (\Delight\Auth\ResetDisabledException $e) {
die('Password reset is disabled');
}
catch (\Delight\Auth\TooManyRequestsException $e) {
die('Too many requests');
}`
Any help is much appreciated.

Thanks a lot, @eypsilon!


add supported fork info to evm tools help

What was wrong?
The forks supported by the current evm tools was not documented in the description (-h command)
How was it fixed?
Add the supported forks to help
Cute Animal Picture

Codecov Report
Patch and project coverage have no change.

Comparison is base (2da1ad3) 74.06% compared to head (eb7c698) 74.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   74.06%   74.06%
=======================================
  Files         571      571
  Lines       31726    31726
=======================================
  Hits        23498    23498
  Misses       8228     8228

Flag
Coverage Δ

unittests
74.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Feature Request] Convert proxy server to TypeScript

Description
Use TypeScript for the proxy server code.
Related Issues
Originally in issue #303.
Tasks

[ ] Convert server to TypeScript
[ ] Add script to watch and reload server when changes are made in dev

[!IMPORTANT]
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

[!TIP]
Please use a 👍 reaction to provide a +1/vote.
This helps the community and maintainers prioritize this request.

Could impact issue #132

This article would be a great source of inspiration for when this is tackled.
https://www.totaltypescript.com/typescript-and-node


samples function has different declaration in Poisson with respect to Likelihood class

The samples function which is called several times, especially when plotting, true predictive values with the option "m.plot_mean(...,plot_raw=False)" , there is an ugly error because of difference between the declarations of samples function in Likelihood class and corresponding child classes.

quick fix would be to add the argument:samples=1 in the declaration.