Can't get it to work on Ubuntu 14.4

It installs fine and all paths are set, but it just doesn't do anything.
tengen@ubuntu:~$ m
tengen@ubuntu:~$ m 2.6.6
tengen@ubuntu:~$
tengen@ubuntu:~$ m --help
tengen@ubuntu:~$ m use 2.6.6
tengen@ubuntu:~$

Try turning on debugging:
DEBUG=* m 2.6.6

@rueckstiess bump.  Any luck reproducing this with DEBUG on?

chatted offline.  new related fixes coming.  if we can get more diagnostic, let's reopen


GeoJsonMapLayer crashed during simple_geojson.py

$ python simple_geojson.py
....
Traceback (most recent call last):
File "simple_geojson.py", line 51, in
runTouchApp(view)
File "/usr/lib/python2.7/dist-packages/kivy/base.py", line 487, in runTouchApp
EventLoop.window.mainloop()
File "/usr/lib/python2.7/dist-packages/kivy/core/window/window_sdl2.py", line 525, in mainloop
self._mainloop()
File "/usr/lib/python2.7/dist-packages/kivy/core/window/window_sdl2.py", line 290, in _mainloop
EventLoop.idle()
File "/usr/lib/python2.7/dist-packages/kivy/base.py", line 327, in idle
Clock.tick()
File "/usr/lib/python2.7/dist-packages/kivy/clock.py", line 483, in tick
self._process_events()
File "/usr/lib/python2.7/dist-packages/kivy/clock.py", line 615, in _process_events
event.tick(self._last_tick, remove)
File "/usr/lib/python2.7/dist-packages/kivy/clock.py", line 374, in tick
ret = callback(self._dt)
File "/data/home/user/.kivy/garden/garden.mapview/mapview/downloader.py", line 102, in _check_executor
callback(*args)
File "/data/home/user/.kivy/garden/garden.mapview/mapview/geojson.py", line 304, in _load_geojson_url
self.geojson = r.json()
File "kivy/properties.pyx", line 397, in kivy.properties.Property.set (kivy/properties.c:4818)
File "kivy/properties.pyx", line 429, in kivy.properties.Property.set (kivy/properties.c:5389)
File "kivy/properties.pyx", line 484, in kivy.properties.Property.dispatch (kivy/properties.c:6070)
File "kivy/_event.pyx", line 1168, in kivy._event.EventObservers.dispatch (kivy/_event.c:12854)
File "kivy/_event.pyx", line 1074, in kivy._event.EventObservers._dispatch (kivy/_event.c:12051)
File "/data/home/user/.kivy/garden/garden.mapview/mapview/geojson.py", line 290, in on_geojson
self.canvas_line.clear()
AttributeError: 'GeoJsonMapLayer' object has no attribute 'canvas_line'

THis was fixed recently in d62fd928b3c84f5c916279bef14e07151da5e8c2


Chess: Move E7 to E5

Please do not change the title. Just click "Submit new issue". You don't need to do anything else :D

@BenMcBride done! Successfully played move e7e5 for current game.
Thanks for playing!


Dragging a GridItem is not working when distributeEvenly prop is set

Expected Behavior
Same as when the prop is not set.
Current Behavior
When this prop is set, the entire layout is being destroyed.

Tnxs to UTing119


internal/scaffold/helm: added role rule for creating events

Description of the change:
This PR adds a new role rule during project scaffolding that allows the operator to create events.
Motivation for the change:
This is a follow-up fix for #2325, which is required for the operator to be able to create events on CRs when override values are in use.

@theishshah This is a follow-up fix for #2325 which just merged last Friday, so no need for a separate changelog entry since this issue wasn't in the most recent release.


Add [Lenstik]

Name: Lenstik
Description: Lenstik is a revolutionary decentralized short video application that empowers users to create, upload, and share short videos while leveraging blockchain technology.
Thumbnail URL: https://drive.google.com/file/d/1_58DOCLxZqtpyokv7852Yr94oRr3goqu/view?usp=sharing
Category: Social Media
Project URL: https://www.lenstik.xyz/

Hello, how long do we have to wait to be listed on Lens Garden or is it currently under review


pull request for e2e test at 12/26/2016 12:15:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[macOS] Default OpenSSL will be switched to 1.1.1 and OpenSSL 1.0.2 will be removed on December, 14

Breaking changes
We will switch default OpenSSL to 1.1.1 and will remove OpenSSL 1.0.2 from all macOS images.
Target date
Image deployment will start on December, 14 and will take 2-3 days.
The motivation for the changes
All versions under 1.1.1 have reached EOL and now out of support and should not be used.
Possible impact
If your library/project is not compatible with OpenSSL 1.1.1 and you build them based on default OpenSSL version - your workflow will be broken.
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[x] macOS 10.13
[x] macOS 10.14
[x] macOS 10.15
[x] macOS 11.0
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Mitigation ways
The following code will install and set OpenSSL 1.0.2 as a default one in runtime:
brew tap-new --no-git local/openssl
FORMULA_PATH=$(brew extract openssl local/openssl | grep "Homebrew/Library/Taps")
brew install $FORMULA_PATH

# Set OpenSSL 1.0.2t as default
ln -sf<EMAIL_ADDRESS>/usr/local/Cellar/openssl
ln -sf /usr/local/Cellar/openssl/1.0.2t/bin/openssl /usr/local/bin/openssl
rm /usr/local/opt/openssl
ln -sf ../Cellar/openssl/1.0.2t /usr/local/opt/openssl

Ideally this would be the suggested mitigation:
brew tap-new --no-git local/openssl
FORMULA_PATH=$(brew extract openssl local/openssl | grep "Homebrew/Library/Taps")
brew install $FORMULA_PATH

Otherwise, anything trying to build against OpenSSL 1.1 using Homebrew's locations will silently build against OpenSSL 1.0.2 instead and:

All older versions (including 1.1.0, 1.0.2, 1.0.0 and 0.9.8) are now out of support and should not be used.

https://www.openssl.org/source/
With the above mitigation this can still be done manually by referencing e.g<EMAIL_ADDRESS>instead of /usr/local/opt/openssl/bin
Thanks (from the Homebrew project leader and GitHub employee)!

My phone hijacked overhere

Breaking changes
We will switch default OpenSSL to 1.1.1 and will remove OpenSSL 1.0.2 from all macOS images.
Target date
Image deployment will start on December, 14 and will take 2-3 days.
The motivation for the changes
All versions under 1.1.1 have reached EOL and now out of support and should not be used.
Possible impact
If your library/project is not compatible with OpenSSL 1.1.1 and you build them based on default OpenSSL version - your workflow will be broken.
Virtual environments affected

[ ]  Ubuntu 16.04
[ ]  Ubuntu 18.04
[ ]  Ubuntu 20.04
[x]  macOS 10.13
[x]  macOS 10.14
[x]  macOS 10.15
[x]  macOS 11.0
[ ]  Windows Server 2016 R2
[ ]  Windows Server 2019

Mitigation ways
The following code will install and set OpenSSL 1.0.2 as a default one in runtime:
brew tap-new --no-git local/openssl
FORMULA_PATH=$(brew extract openssl local/openssl | grep "Homebrew/Library/Taps")
brew install $FORMULA_PATH

# Set OpenSSL 1.0.2t as default
ln -sf<EMAIL_ADDRESS>/usr/local/Cellar/openssl
ln -sf /usr/local/Cellar/openssl/1.0.2t/bin/openssl /usr/local/bin/openssl
rm /usr/local/opt/openssl
ln -sf ../Cellar/openssl/1.0.2t /usr/local/opt/openssl

The new set of images has been deployed!

I have an issue since the 14th December on my dotnet unit test workflow running on MacOS  :
 The active test run was aborted. Reason: Test host process crashed : No usable version of libssl was found
This occurs on netcoreapp3.1 with SDK 3.1.404.
Current runner version: '2.275.1'
Operating System
  Mac OS X
  10.15.7
  19H15
Virtual Environment
  Environment: macos-10.15
  Version: 20201212.1

Is it related to this issue ? I assume dotnet is using OpenSsl 1.1.1.
@AlenaSviridenko ?

Hi @ycrumeyrolle,
this seems to be the issue with netcore, please, create issue in corresponding repository https://github.com/dotnet/core/issues and team will investigate it.
Meanwhile, could you please try the mitigation way provided in the comment above https://github.com/actions/virtual-environments/issues/2089#issuecomment-729756890 and see if it helps?


Include ps command

kata-runtime should have an implementation similar to runc to list the processes inside the containers.

ps command should be included in all the images generated by osbuilder
document why ps command is needed

or presumably we could parse /proc ?

@grahamwhaley no we can't, user can specify ps options using docker top, if we read /proc then we have to support ALL ps options
$ docker top --help
Usage:	docker top CONTAINER [ps OPTIONS]

[ps OPTIONS]
$ docker top --help
Usage:	docker top CONTAINER [ps OPTIONS]

Agreed. Thanks for explaining - I'd forgotten the user can supply options through docker top.


🐛 Bug Report: Premium Support is Shown When No Org. Exists

👟 Reproduction steps
Assuming there's a plain Cloud account with no organizations created.

See -

Support Modal
Support Wizard

Note: For obvious reasons, the form submission fails. However its important to simply not show the contact form directly.
👍 Expected behavior
Don't show the Premium Support option.
👎 Actual Behavior
Premium Support option is shown.
🎲 Appwrite version
Appwrite Cloud
💻 Operating system
Linux
🧱 Your Environment
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Update: This also happens if you navigate to a wrong project or organization manually by typing in the URL like - https://cloud.appwrite.io/console/organization-xyz or https://cloud.appwrite.io/console/project-xyz.


Add icon description to InlineNotification icon

On this line:
https://github.com/carbon-design-system/carbon-components-svelte/blob/ae3445158315f7f834ae7f4be75bfd79aea5a299/src/Notification/InlineNotification.svelte#L85
Depending on the value of kind, I would like to provide this icon a default description per kind, rather than the default "Closes notification" since it isn't interactive. For example:

kind === error, icon description "no-entry icon"
kind === warning-alt, icon description "warning triangle"

Related: #672

Released in v0.71.0


Setup deployment to Github Package Registry for nupkg artifact examples

Refs strongbox/strongbox#1927
Deploys nupkg artifacts generated by nuget-chocolatey and nuget-mono examples. I got it to work using the actions/setup-dotnet@v1.
Sample artifacts:

nuget-chocolatey nupkg artifact
nuget-mono nupkg artifact

I also tried using the strongboxci docker images for both but ran into issues:

nuget-chocolatey using Docker image
nuget-chocolatey logs
nuget-mono using Docker image
nuget-mono logs

@carlspring Request review

I think we need to update something in the scripts in order to fix this:

Any idea what we're missing?

Any idea what we're missing?

The description tag for the .nuspec file in the hello-chocolatey example had placeholder values, along with some other metadata. I've updated them and added a link to the .nuspec File Reference docs

Also, any idea why the asset for both is called package.nupkg?

Hmm not sure if this a nuget or GitHub Package Registry thing. From what I can see in the logs, nuget doesn't seem to be renaming the artifact:
Pushing hello-chocolatey.1.0.0.nupkg to 'https://nuget.pkg.github.com/strongbox'...
PUT https://nuget.pkg.github.com/strongbox/

Thanks for fixing the placeholders! :)
This looks good to me now.

Could you please rebase this, so we can merge it? Thanks! ;)

@carlspring Merge conflicts resolved


FMSynth example crashes Chrome

The FMSynth demo  (https://tonejs.github.io/examples/#fmSynth) crashes my chrome tab (Version 66.0.3359.181 (Official Build) (64-bit)). This occurs when pressing down my mouse and moving it quickly up and down on the diplayed keyboard.

These are the errors I get when enabling the debug logging flag in chrome:
[20183:161863:0521/152342.002693:WARNING:audio_sync_reader.cc(193)] AudioSyncReader::Read timed out, audio glitch count=10
[20183:161863:0521/152342.060817:WARNING:audio_sync_reader.cc(193)] AudioSyncReader::Read timed out, audio glitch count=20
[20183:161863:0521/152342.064765:WARNING:audio_sync_reader.cc(175)] ASR: No room in socket buffer.: Broken pipe (32)

I haven't been able to find out what causes this failure. There are some old issues which seam related: (https://github.com/Tonejs/Tone.js/issues/40, https://github.com/Tonejs/Tone.js/issues/332) but they are all closed and should be fixed by now.

ouch! that's a hard crash.
it is probably the same bug as #332, but since the examples are using the current master build (tone@r12) the fix for it is only in the latest dev build (tone@^13), they'll still have the crashing issue. i suggest using the latest dev build if you can to avoid this issue.
i'll try to file a bug with chrome

Thanks, didn't look properly if the current version included that commit


Optimize Universal cable rendering or disable it by default in config.

Issue description:
In a nice empty world it's not difficult to get 300-400FPS... Until you place down and power 8 stacks of Universal cables... Suddenly 30fps! It is not uncommon to have long running power cables all over your (sky)base. Other power carrying cables don't seem to suffer this issue (for example 8 stacks of EnderIO conduits still manage 300FPS).
There is an issue on GitHub from 2013 about this, and it has spawned a config option to change. This config option is still available in the current versions, albeit a bit oddly named (OpaqueTransmitterRender).
Either optimize the Universal cables to not completely destroy FPS when a few of them are placed, or have their fancy rendering disabled by default.
Steps to reproduce:

Load empty world
Place an 8x8x8 cube of Universal cables
Power them
Feel the FPS destruction.

Version (make sure you are on the latest version before reporting):
Forge: <IP_ADDRESS>05
Mekanism: 1.12.2-<IP_ADDRESS>9

albeit a bit oddly named (OpaqueTransmitterRender)

how is that odd? it describes exactly what it does
If your setup can handle it with that option turned on, the problem is probably with your rig.

Feel the FPS destruction.

That's also not a repro step.

OpaqueRender is clear, but transmitter doesn't scream "universal cable" or "logistical transporter" to me.
My rig is a bit old, I won't deny that. But you'd think that a pc that can easily play GTAV for example should be able to render 8 stacks of connected cables in minecraft.
Feeling FPS destruction is indeed not a step to reproduce the issue, but pressing F3 and looking at the little counter to see a drop in FPS might be.
Admittedly, I have this issue in a large mod pack, I will try to reproduce it with just Mekanism, and on a different computer.

Alright, I installed a fresh instance of Minecraft, added Mekanism 1.12.2-<IP_ADDRESS>9 and Better Builder's Wands 1.12-<IP_ADDRESS>+69d0d70 on a different, newer system... The results:

I don't make any clams as to how optimised it is (I didn't write it), but what exactly do you expect for 512 TESRs?

I expect my performance to not be tanking to 35-40FPS. Some FPS drop is fine, and should be expected, but 35-40FPS has a very clear and direct negative impact on my experience.
When I subject other mods to this same "torture" test, FPS isn't impacted nearly as much.

Perhaps migrating the TESRs to forge's FastTESRs might yield performance improvements?
The forge documentation says that FastTESRs should be used whenever possible.
https://mcforge.readthedocs.io/en/latest/tileentities/tesr/#fasttesr

Makes sense, as the glowing thing needs two render-calls, one with lighting disabled... Simple enough to make them not glowing though (still changing color, just not always-bright)

Closing this as I have optimized the rendering code some in 1.15, as well as, FastTESRs no longer exist, due to all TERs being "fast"

Opening this again, mainly to just throw it in the fixed in dev and 9.9.18 milestone as I did some more profiling and further improved this (8x8x8 of universal cables):


How to set an id for "mat-option"?

Question
I want to set the id of "mat-option" tags so that they are fixed for testing purposes.
right now "mat-option" gets random numbers in different environments with different builds. Ex:
"mat-option-677", "mat-option-201" and so on.
please note that it is not always "mat-option-0", "mat-option-1" and ....
The "id" given will be used only for "mat-select" as shown in the image below, but is there a way to assign an "id" also for "mat-option"?

https://stackblitz.com/edit/ngx-formly-ui-material-ka5p7a?file=src/app/app.component.ts

Duplicate of #3484.
Not supported yet, you'll need to override the select type instead, also PR welcomed!

Could you please provide an example or point me in the right direction on how to override the select type?

https://formly.dev/docs/guide/custom-formly-field
https://github.com/ngx-formly/ngx-formly/tree/main/src/ui/material/select/src


Plot all the significant GOterms from custom association file

I have a custom annotation from a non model organism and want to plot the graph of the significant GOterms found.
The idea is to be able to plot the graph similar to the one shown in the this notebook: https://github.com/tanghaibao/goatools/blob/master/notebooks/goea_nbt3102.ipynb
But im not sure how to load my custom association file to create the GOEA object.
Also, couldnt find the example files to run the notebook, to replicate it and try to match those files from my data.
Could you please help me explaining me how to do that, or where to find the example files?
Thanks,

Hi there @rafarios50 ,
You need to import and use the IdToGosReader method to read an annotation file from a custom database of a non-model organism.
Basically you need to make sure that your association file is in the same shape and format as the example provided here.
Then, in step "2b. Load Associations" of the notebook  you mentioned you create the objanno object using IdToGosReader function. You have to specify two parameters for that function: the path to your annotations file and the GODag that was previously downloaded in that notebook.
Here is how the code looks like
from __future__ import print_function
from goatools.anno.idtogos_reader import IdToGosReader
objanno=IdToGosReader("association.txt",godag=obodag)
Good luck and I hope this is still useful almost three years later :D


Problems populating the bucket dropdown in the Lambda deploy wizard

A Lambda deploy wizard problem was reported:

I changed some code and tried to deploy again using the serverless.template publishing mechanism. Even though it saved my stack and bucket name in its config file, it wouldn't load those into the dropdown fields. In fact, I couldn't even type my bucket name into the bucket field - it was just blank with no items in the dropdown, and wouldn't allow keyboard input. After restarting VS, this worked.

This appears to occur if the role's token expires between opening of the publish to aws screen. We use a script to renew our tokens into the local aws creds file on our machine. Even if this external script has been run and the token is valid, the VS plugin won't see that new token and instead blanks out the dropdowns:

These two dropdowns are not editable - can't type inside.
The only workaround is to restart visual studio. Then it gets the latest token and works.

Thank you for the additional context @mtttcgcg , this helps to dig in to this a little further.
Out of curiosity, how frequently is your token renewal occurring?
As a possible workaround, have you considered setting up a credential_process style of credential?

Our tokens expire after 1 hour. We use https://github.com/Nike-Inc/gimme-aws-creds to get the token and save it to the %HOME%.aws\credentials file. I guess it would be pretty easy to convert that output to the JSON that credential_process looks for. Let me investigate that, thanks!

I would be interested in hearing if you have success with that. Also, we have a feature request for SSO/SAML (#98). If that would help you, please take a moment to add a reaction to the issue's initial post, as that helps us measure interest in requested features.

Hi @mtttcgcg , version <IP_ADDRESS> of the toolkit is now available. It has support for AWS SSO based credentials, which you may be interested in trying out.
Additionally, when the modal publish dialogs come up, the Toolkit now makes an attempt to validate the credentials. This would help in the case where the credentials have expired before the dialog tries to load resources when it is initially displayed. I'd be interested in hearing if this helps you out.

I'm going to close this issue since it hasn't received any updates in a while, and the Toolkit has gained additional credentials support since this issue was filed. If the problem persists, please re-open the issue or file a new one, and share details about the behavior you are seeing.


Add additional claims on successful login with Google authentication

I use the following code to sign in users using Google authentication.
services.AddDataProtection()
    .PersistKeysToFileSystem(new System.IO.DirectoryInfo("/Users/marcus/Temp/App/KeyStorage"))
    .SetApplicationName("SharedCookieApp");

services
    .AddAuthentication(options =>
    {
        options.DefaultScheme = IdentityConstants.ApplicationScheme;
        options.DefaultSignInScheme = IdentityConstants.ExternalScheme;
    })
    .AddGoogle(options =>
    {
        options.ClientId = "xxx.apps.googleusercontent.com";
        options.ClientSecret = "xxx";
        options.Scope.Add("https://www.googleapis.com/auth/userinfo.profile");
    })
    .AddIdentityCookies(options =>
    {
        options.ApplicationCookie.Configure(a => a.Cookie.Name = ".AspNet.SharedCookie");
    });

How can I add additional claims when a user is successfully logged in? I tried using the event OnTicketCreating but the new claim is not added to to the cookie so it can be read using the following code.
@foreach (var claim in User.Claims)
{
<EMAIL_ADDRESS><EMAIL_ADDRESS>}

This is how I use the OnTicketCreating event.
options.Events.OnCreatingTicket = ctx =>
{
    var identity = (ClaimsIdentity)ctx.Principal.Identity;
    identity.AddClaim(new Claim("FullName", ctx.Principal.FindFirst(ClaimTypes.Name).Value));
    return Task.CompletedTask;
};

So is it possible to add additional claims to the authentication cookie using this or any other approach?

It's a two stage process:

persist the claims from Google into the temp External cookie.
Transfer the claims to the long term Identity cookie.
https://docs.microsoft.com/en-us/aspnet/core/security/authentication/social/additional-claims?view=aspnetcore-2.2

I don't really understand what you mean by temp external cookie and long term cookie. The docs suggest using ClaimActionCollectionMapExtensions
? Are there any real example in the docs or can you provide me with one?
https://docs.microsoft.com/en-us/aspnet/core/security/authentication/social/additional-claims?view=aspnetcore-3.0#creating-and-adding-claims

https://docs.microsoft.com/en-us/aspnet/core/security/authentication/social/additional-claims?view=aspnetcore-2.2#map-user-data-keys-and-create-claims gives examples for setting up which external fields you want to save as claims (MapJsonKey).  These are stored in a temporary cookie usually named IdentityConstants.ExternalScheme.
The second example in that section covers OnPostConfirmationAsync and shows how to persist those extra claims long term via _userManager.AddClaimAsync.

Ok, I see. So the claim must be stored in the storage provider I use by adding it with _userManager.AddClaimAsync? I thought it was possible to only send a custom claim without saving it to the database but if I understand correctly that is not possible?

@HaoK ?

We added a new method SignInManager.SignInWithClaimsAsync in 3.0 for this:
https://github.com/aspnet/AspNetCore/blob/master/src/Identity/Core/src/SignInManager.cs#L231

Ok, cool! I use the preview bits so I'll give it a try. Thanks!


KA Gradescope link

Summary

Removed fake names from Speedgrader page and replaced usages of fake names with the Gradescope student ID.

Also removed the getStyles function because it was based on the name and did not appear to impact anything.

Added in ID maps for Fall 2023/Spring 2024 Gradescope courses and Project 2 assignments.
Implemented a "Gradescope Submission" button that appears once a Gradescope student ID is selected and links to the student's submission using a new browser tab.

Google Chrome-specific issue where error page is reached but reloading page allows you to see submission. Error page does take quite a few seconds to reach and slows down workflow a lot, so would recommend any other browser is used for experiment unless Gradescope fixes this before.

Speedgrader page buttons/tabs that require a Gradescope student ID to be selected to be useful are now hidden until an ID is selected.

Feature Video
https://github.com/The-DSA-Duckies/aegon/assets/64329665/a3184475-9c2c-4592-9796-bae76ab96213
Next Steps

We'll have to replace the sample IDs with the actual subset of IDs from Spring 2024 for grading. We'll also have to replace the "Fa23" key usage with the "Sp24" key.
I also am going to contact Gradescope via<EMAIL_ADDRESS>to let them know of the Google Chrome specific problem with having to reload the page to see the student submission.
We will want to make it not as hard-coded for Project 2, but that will happen when the entire Speedgrader page is updated to handle different assignments.

Just added video to original PR comment. Will test out different button placements and share with group for feedback!


Add protocol field to app service spec

The protocol field allows users to specify whether they're serving HTTP or HTTP2.

Converting to a draft until this is ready to be reviewed and merged.


Analyze prebuilts for ASPNET Extensions

The following prebuilts are added by the ASPNET Extensions repo:
These look like they could be reference-only packages.  Listed in the table below are the versions of the packages that are already being generated as reference-only.  Is4.6.0-preview7.19352.8 the required version for each of these packages?

PackageName
PackageVersion
Ref-Pkg Versions
Category

System.ComponentModel.Annotations
4.6.0-preview7.19352.8

System.Diagnostics.DiagnosticSource
4.6.0-preview7.19352.8
4.0.0, 4.3.0, 4.4.0

System.Diagnostics.EventLog
4.6.0-preview7.19352.8

System.Runtime.CompilerServices.Unsafe
4.6.0-preview7.19352.8

System.Security.Cryptography.Xml
4.6.0-preview7.19352.8

System.Text.Encodings.Web
4.6.0-preview7.19352.8

System.Text.Json
4.6.0-preview7.19352.8

TL;DR, we need System.Diagnostics.EventLog and System.Security.Cryptography.Xml from CoreFX, we can stop building System.Diagnostics.DiagnosticSource. The rest of the Extensions packages need to compile for netstandard2.1 and remove dependencies.
I've looked into these dependencies and here's my recommendations:

PackageName
PackageVersion
Ref-Pkg Versions
Category
Referenced By
Recommendation

System.ComponentModel.Annotations
4.6.0-preview6.19303.8

Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Options
Extension packages are included in shared framework, as is the CoreFX package. Cross compile for netstandard2.1 and remove dependency https://github.com/aspnet/Extensions/issues/2056

System.Diagnostics.DiagnosticSource
4.6.0-preview6.19303.8
4.0.0, 4.3.0, 4.4.0

Microsoft.Extensions.DiagnosticAdapter
Extension package is not included in the shared framework. Skip building it in source build

System.Diagnostics.EventLog
4.6.0-preview6.19303.8

Microsoft.Extensions.Logging.EventLog
Extensions package is included in shared framework but CoreFx package is not. CoreFx needs to build this package.

System.Memory
4.5.2
4.5.2
Ref-Only
Microsoft.Extensions.Primitives
Extension package is included in shared framework, as is the CoreFX package. Cross compile for netstandard2.1 and remove dependency https://github.com/aspnet/Extensions/issues/2056

System.Runtime.CompilerServices.Unsafe
4.6.0-preview6.19303.8

Microsoft.Extensions.Primitives
Extension package is included in shared framework, as is the CoreFX package. Cross compile for netstandard2.1 and remove dependency https://github.com/aspnet/Extensions/issues/2056

System.Security.Cryptography.Xml
4.6.0-preview6.19303.8

Microsoft.Extensions.Configuration.Xml
Extensions package is included in shared framework but CoreFx package is not. CoreFx needs to build this package.

System.Text.Encodings.Web
4.6.0-preview6.19303.8

Microsoft.Extensions.WebEncoders
Extension package is included in shared framework, as is the CoreFX package. Cross compile for netstandard2.1 and remove dependency https://github.com/aspnet/Extensions/issues/2056

System.Text.Json
4.6.0-preview6.19303.8

Microsoft.Extensions.Configuration.Json, Microsoft.JSInterop, Microsoft.Extensions.Logging.EventSource
Extension packages are included in shared framework, as is the CoreFX package. Cross compile for netstandard2.1 and remove dependency https://github.com/aspnet/Extensions/issues/2056

System.Threading.Tasks.Extensions
4.5.2
4.0.0, 4.3.0, 4.5.1

Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Logging.EventSource
Extension packages are included in shared framework, as is the CoreFX package. Cross compile for netstandard2.1 and remove dependency https://github.com/aspnet/Extensions/issues/2056

Is there another list for AspNetCore-Tooling?

FYI, the recommendation has been updated to cross compile for netcoreapp3.0 instead of netstandard2.1

@dseefeld Can this issue be closed now? We have addressed the underlying issues already. Or is this being kept open to track when the fixes make their way to source build?

We usually keep them open until our prebuilt report shows no outstanding prebuilts.

I think this is completed @dseefeld ?

Yes.  All prebuilts have been removed.


Don't be specific about VS Code

This can be used for either VS or VS Code, we shouldn't be specific here. I'd guess there are other locations as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c53405a4-8bde-8e99-db91-75f4b76ab6eb
Version Independent ID: acba9d21-cfb1-29da-bcce-58155f707396
Content: #region - C# Reference
Content Source: docs/csharp/language-reference/preprocessor-directives/preprocessor-region.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

I believe the article is actually talking about the Code Editor of Visual Studio, notice that the "outlining" link goes to VS-specific documentation. Though it's definitely confusing as it is now and should be rewritten.

Good points.
I suggest replacing "Visual Studio Code Editor" with "code editor".
I've added the up for grabs and good first issue label to this issue.


Comment out JS line results in removal of first character.

Just here to report.

Feel free to close if dupe, didn't have time to write a full report at the moment, but wanted to show it.
Using Javascript

Does this happen in safe mode (atom --safe)?

@drj-io can you re-try with atom --safe?

Haven't seen the issue since in save mode or otherwise.


atom-ternjs disables atom api code completion

When atom-ternjs is enabled it disables atom API autocomplete (writing packages).
https://github.com/atom/autocomplete-atom-api

the package excludes all lower priority providers.
good point! in the next release i will provide an option to disable this behaviour so you can manually disable it.

Great to hear.

I suspect this is why https://atom.io/packages/autocomplete-paths does not work with atom-ternjs enabled. Can anybody confirm that?


Bugs and crashes on moving windows between workspaces with different layouts.

Description
I have two workspaces with different layouts:
№ 1 - with dwindle layout (assigned)
№ 2 - with master layout (default)
Hypland version: 0.34.0.r61.754eaf5b-1
Moving windows between those workspaces leads to following bugs:
Phantom window after moving to a different layout workspace
Steps to reproduce

Create windows on workspace 1
Move a window to workspace 2
Return focus to workspace 1

Result: There is a blank space where the window previously was. Tiling works as there is a phantom window.
Crash on return to workspace after closing moved window
Steps to reproduce

Create windows on workspace 1
Move a window to workspace 2
Close the window
Return to workspace 1

Result: Hyprland crashes.

Can reproduce. Happens when using keyboard binds to move the windows, not with mouse binds.
I may have a look at it on Wednesday, if I have time.

Oh hmm, this is annoying.
https://github.com/hyprwm/Hyprland/blob/91e8c428431deac1e5eb8e537f002ab960777174/src/Compositor.cpp#L2695
here hyprland calls onWindowRemovedTiling, then sets the workspace id etc. Then calls onWindowCreatedTiling
The problem is this line: https://github.com/hyprwm/Hyprland/blob/91e8c428431deac1e5eb8e537f002ab960777174/src/Compositor.cpp#L2689
that function sets the workspace id of the window too. So when onWindowRemovedTiling is called, the workspaceID is already set to the new workspace. So the plugin uses the 'new' workspace for the proxied remove call.
I think I'm just going to have to keep a global state of all window->workspaceid mappings in the plugin and use that to lookup the layout for each operation.

Try this commit, please

I did some further testing and it seems to work fine now when switching between ordinary workspaces with different layouts. However, it doesn't seem to work correctly with special workspaces yet. When moving a window to a special one, it doesn't tile and stays the same size.
It's quite easy to reproduce:
I have master as a default layout and set the layout of a special workspace to dwindle.

Create at least 2 windows on a normal master workspace.
Move a window to your the special workspace with a keybind -> the window won't tile.
Move a couple of more windows to the special workspace -> they'll start to overlap etc.

When opening a new window on the special workspace all windows are tiled correctly again.
I also noticed that opening a special workspace on another monitor does also not show the window (probably because they are not retiled) until I open a new one.

special workspaces are weird in hyprland.... please try latest commit

This fixes all the issues I've had with the special workspaces, thanks!
However, I've found another one. It took me a lot of time to find how to reproduce the issue but this should work:
I have two monitors with differing layouts. I've added some numbers for clarity:

Open two windows on one monitor (1).
Move one of them to the other monitor (2) via keybind.
Move it back with the mouse (to 1).
Move it again to the the other monitor (2) via keybind. -> The monitor (1) does not retile.
Focus the first monitor (1) with the mouse. -> The window disappears from the other monitor (2).
Focus the other monitor (2) with the mouse. -> The window appears again. etc.

Sometimes the compositor also crashes when closing the windows after reproducing it, but I couldn't reproduce that reliably. I could also reproduce it with your latest commits (from ~1-2 hours ago).

Just tested last version. I see no problem. Thanks!

Just tested latest version. I see no problem. Thanks!


<EMAIL_ADDRESS>

<EMAIL_ADDRESS>
Update imports thereof for compatibility.

CI is passing: https://app.circleci.com/pipelines/github/MetaMask/inpage-provider?branch=json-rpc-engine%406.1.0


python unexpectedly aliases to 2.6.9

Reports of python pointing to 2.6.9 instead of 2.7.x.  There is apparently an alias of python2 => 2.7.x.

Evidence: https://travis-ci.org/meatballhat/cloaked-octo-tyrion/builds/85534778

Lookie there, all of the pythons! https://travis-ci.org/meatballhat/cloaked-octo-tyrion/builds/85535522#L137-L144
$ echo $PATH | tr ":" "\n"
/usr/local/rvm/gems/ruby-2.2.3/bin
/usr/local/rvm/gems/ruby-2.2.3@global/bin
/usr/local/rvm/rubies/ruby-2.2.3/bin
/usr/local/rvm/bin
/home/travis/bin
/home/travis/.local/bin
/home/travis/.gimme/versions/go1.5.1.linux.amd64/bin
/home/travis/.local/bin
/opt/python/2.6.9/bin
/opt/python/2.7.10/bin
/opt/python/3.2.6/bin
/opt/python/3.3.6/bin
/opt/python/3.4.3/bin
/opt/python/3.5.0/bin
/opt/python/pypy-2.6.1/bin
/opt/python/pypy3-2.4.0/bin
/home/travis/.phpenv/shims
/usr/local/phantomjs/bin
/usr/local/phantomjs
/home/travis/perl5/perlbrew/bin
/home/travis/.nvm/versions/node/v4.1.2/bin
./node_modules/.bin
/usr/local/maven-3.1.1/bin
/usr/local/gradle/bin
/usr/local/clang-3.5.0/bin
/usr/local/sbin
/usr/local/bin
/usr/sbin
/usr/bin
/sbin
/bin
/home/travis/.phpenv/bin

Not sure if related but it looks pyenv is not available on non-python images?
$ pyenv versions
/home/travis/build.sh: line 41: pyenv: command not found
The command "pyenv versions" failed and exited with 127 during .

.travis.yml file: https://github.com/cotsog/travis_ci_prod_trusty/blob/df06a07a3ad8c9ebf204df0ed9e5f39af997d110/.travis.yml
Build log: https://travis-ci.org/cotsog/travis_ci_prod_trusty/builds/85542611


Add configs for building a bundle with Konflux

Add a script that Konflux will update with the latest references to the operands. This script is also used during the build for producing the variables that will be used when generating the manifests from templates.

Add a Containerfile for building the bundle.

Once we will get this PR merged we will update https://github.com/kubev2v/forklift/pull/1076 with the correct path to the Containerfile.


delete xml emission files if creating csv versions of them

Pull request information

Status: ready to merge
Kind of changes: cleaning
Related PR or issue: None

Description
This feature removes redundancies in stored data, which can be very annoying when trying to generate hundreds of emission csv files for examples.

@Yasharzf can you review this? it's pretty straightforward.

Pull Request Test Coverage Report for Build 4103

2 of 3 (66.67%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 91.902%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flow/visualize/visualizer_rllib.py
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

flow/visualize/visualizer_rllib.py
1
75.62%

Totals

Change from base Build 4101:
-0.01%

Covered Lines:
8773

Relevant Lines:
9546

💛  - Coveralls


Updated azure core dependency to the new 1.11.3 version

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[ ] C++ Guidelines
[ ] Doxygen docs
[ ] Unit tests
[ ] No unwanted commits/changes
[ ] Descriptive title/description

[ ] PR is single purpose
[ ] Related issue listed

[ ] Comments in source
[ ] No typos
[ ] Update changelog
[ ] Not work-in-progress
[ ] External references or docs updated
[ ] Self review of PR done
[ ] Any breaking changes?

/check-enforcer help

/check-enforcer override


Failed test, Cannot read property 'length' of null when spacing encountered in solution

Challenge http://www.freecodecamp.com/challenges/waypoint-override-all-other-styles-by-using-important has an issue.
If there is a space between "!important" and ";" test will return:
Cannot read property 'length' of null

Having a space between last character and ";" on other lines do not provide a failed test case.

Hello World!

Issue appears to be with test assertion regex under https://github.com/FreeCodeCamp/FreeCodeCamp/blob/staging/seed/challenges/html5-and-css.json
Original:
"assert(editor.match(/pink.*\\!important/gi) && editor.match(/pink.*\\!important;/gi).length > 0, 'Your pink-text class should have the !important keyword to override all other declarations.')",

Proposed change:
"assert(editor.match(/pink.*\\!important/gi) && editor.match(/pink.*\\!important/gi).length > 0, 'Your pink-text class should have the !important keyword to override all other declarations.')",

Hey thanks for posting and doing some of that legwork @karn09!
It looks like someone beat you to it though, this is a duplicate of #2099.  I'll close this but follow the updates there.

Thanks for the note! Did not notice the duplicate.


clang segmentation fault when testing without OSS-Fuzz integration

Hi,
I tried to test without OSS-Fuzz integration and built simple-example-1 in fuzz-introspector/tests/simple-example-1/work using FuzzIntrospector after building the custom clang:
FUZZ_INTROSPECTOR=1 ../../../build/llvm-build/bin/clang -fsanitize=fuzzer -flto -g ../fuzzer.c -o fuzzer

But clang get error and here is the detailed output:
$ FUZZ_INTROSPECTOR=1 ../../../build/llvm-build/bin/clang -fsanitize=fuzzer -flto -g ../fuzzer.c -o fuzzer -v
clang version 15.0.0 (https://github.com/llvm/llvm-project/ a5258e5b2728e6337462247ba11dcf7af051ae9b)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /root/fuzz-introspector/tests/simple-example-1/work/../../../build/llvm-build/bin
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/8
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9
Selected GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Candidate multilib: x32;@mx32
Selected multilib: .;@m64
 "/root/fuzz-introspector/build/llvm-build/bin/clang-15" -cc1 -triple x86_64-unknown-linux-gnu -emit-llvm-bc -flto=full -flto-unit -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name fuzzer.c -mrelocation-model pic -pic-level 2 -pic-is-pie -mframe-pointer=all -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -mllvm -treat-scalable-fixed-error-as-warning -debug-info-kind=constructor -dwarf-version=5 -debugger-tuning=gdb -v -fcoverage-compilation-dir=/root/fuzz-introspector/tests/simple-example-1/work -resource-dir /root/fuzz-introspector/build/llvm-build/lib/clang/15.0.0 -internal-isystem /root/fuzz-introspector/build/llvm-build/lib/clang/15.0.0/include -internal-isystem /usr/local/include -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/9/../../../../x86_64-linux-gnu/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -fdebug-compilation-dir=/root/fuzz-introspector/tests/simple-example-1/work -ferror-limit 19 -fsanitize-coverage-type=1 -fsanitize-coverage-type=3 -fsanitize-coverage-indirect-calls -fsanitize-coverage-trace-cmp -fsanitize-coverage-inline-8bit-counters -fsanitize-coverage-pc-table -fsanitize-coverage-stack-depth -fsanitize=fuzzer,fuzzer-no-link -fno-builtin-bcmp -fno-builtin-memcmp -fno-builtin-strncmp -fno-builtin-strcmp -fno-builtin-strncasecmp -fno-builtin-strcasecmp -fno-builtin-strstr -fno-builtin-strcasestr -fno-builtin-memmem -fgnuc-version=4.2.1 -fcolor-diagnostics -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /tmp/fuzzer-890de1.o -x c ../fuzzer.c
clang -cc1 version 15.0.0 based upon LLVM 15.0.0git default target x86_64-unknown-linux-gnu
ignoring nonexistent directory "/usr/lib/gcc/x86_64-linux-gnu/9/../../../../x86_64-linux-gnu/include"
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
 /root/fuzz-introspector/build/llvm-build/lib/clang/15.0.0/include
 /usr/local/include
 /usr/include/x86_64-linux-gnu
 /usr/include
End of search list.
 "/usr/bin/ld" -pie -z relro --hash-style=gnu --eh-frame-hdr -m elf_x86_64 -dynamic-linker /lib64/ld-linux-x86-64.so.2 -o fuzzer /lib/x86_64-linux-gnu/Scrt1.o /lib/x86_64-linux-gnu/crti.o /usr/lib/gcc/x86_64-linux-gnu/9/crtbeginS.o -L/usr/lib/gcc/x86_64-linux-gnu/9 -L/usr/lib/gcc/x86_64-linux-gnu/9/../../../../lib64 -L/lib/x86_64-linux-gnu -L/lib/../lib64 -L/usr/lib/x86_64-linux-gnu -L/usr/lib/../lib64 -L/lib -L/usr/lib -plugin /root/fuzz-introspector/build/llvm-build/bin/../lib/LLVMgold.so -plugin-opt=mcpu=x86-64 --whole-archive /root/fuzz-introspector/build/llvm-build/lib/clang/15.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.fuzzer.a --no-whole-archive --whole-archive /root/fuzz-introspector/build/llvm-build/lib/clang/15.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.fuzzer_interceptors.a --no-whole-archive -lstdc++ --whole-archive /root/fuzz-introspector/build/llvm-build/lib/clang/15.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_standalone.a --no-whole-archive --dynamic-list=/root/fuzz-introspector/build/llvm-build/lib/clang/15.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_standalone.a.syms /tmp/fuzzer-890de1.o --no-as-needed -lpthread -lrt -lm -ldl -lresolv -lgcc --as-needed -lgcc_s --no-as-needed -lc -lgcc --as-needed -lgcc_s --no-as-needed /usr/lib/gcc/x86_64-linux-gnu/9/crtendS.o /lib/x86_64-linux-gnu/crtn.o
We are now in the FuzzIntrospector module pass
[Log level 1] : 17:49:53 : Fuzz introspector is running
[Log level 1] : 17:49:53 : Running introspector on ld-temp.o
[Log level 1] : 17:49:53 : This is a fuzzer, performing analysis
[Log level 2] : 17:49:53 : Using default configuration
[Log level 1] : 17:49:53 : Logging next yaml tile to fuzzerLogFile-0-9naMqPai1E.data.yaml
[Log level 1] : 17:49:53 : Wrapping all functions
clang-15: error: unable to execute command: Segmentation fault (core dumped)
clang-15: error: linker command failed due to signal (use -v to see invocation)

Is this error caused by the custom compilation of clang?
Thanks!

this shouldn't be because of the custom clang -- will take a look at this today after rebuilding my local set up

@DavidKorczynski Thank you!

Am having troubles reproducing this. For your LLVM compilation, did you clone from the latest LLVM?

Yeah, I cloned the latest LLVM as recommended as follows but failed.
https://github.com/ossf/fuzz-introspector/blob/22822c81cf2cfb0f6bd12e06ac8c14266a333ba4/README.md?plain=1#L136-L153
I ran build_all.sh again and succeed. Thanks!

Btw, the output HTML report gives the detailed information about each fuzzer. How can I get the coverage diff of each pair of fuzzers? For example, which code lines can be only triggered by one of these two fuzzers?

How can I get the coverage diff of each pair of fuzzers? For example, which code lines can be only triggered by one of these two fuzzers?

You can't at this moment in time. You can only see what code is statically reachable by a given set of fuzzers (using the All Functions Table at the top of the report). However, this is a neat feature that fits well with this issue:https://github.com/ossf/fuzz-introspector/issues/209 and should be fairly straightforward to implement -- I will see if I can get this done in the near future, unless it's something you'd like to implement?


Enable Language Server Test Cases

Purpose

Enable language server test cases

Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

:exclamation: No coverage uploaded for pull request base (jballerina@7cb25a5). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             jballerina   #15910   +/-   ##
=============================================
  Coverage              ?   15.46%
  Complexity            ?     4875
=============================================
  Files                 ?     1972
  Lines                 ?    91471
  Branches              ?    12743
=============================================
  Hits                  ?    14142
  Misses                ?    74988
  Partials              ?     2341

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb25a5...d2ceb42. Read the comment docs.


New version: Surfshark.Surfshark version <IP_ADDRESS>9

Pull request has been created with komac v2.6.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Hi, I have test install with local manifest before submit PR
 C:\Users\Felix>winget install --manifest E:\github\winget-pkgs\manifests\s\Surfshark\Surfshark\<IP_ADDRESS>9 Found Surfshark [Surfshark.Surfshark] Version <IP_ADDRESS>9 This application is licensed to you by its owner. Microsoft is not responsible for, nor does it grant any licenses to, third-party packages. Downloading https://downloads.surfshark.com/windows/latest/SurfsharkSetup.exe   ██████████████████████████████  84.3 MB / 84.3 MB Successfully verified installer hash Starting package install... Successfully installed

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-10-16 01:57:12.729 [CLI ] ShellExecute installer failed: 1603
LookupUserGroupFromRid() FAILED
LookupAccountSidW() FAILED
LookupUserGroupFromRidSDDL() FAILED
LookupAliasFromRid() FAILED
[SC] OpenService FAILED 1060:
ERROR: The process "Surfshark.AntivirusService.exe" not found.
CustomAction StopAndRemoveAVService returned actual error code 1603 but will be translated to success due to continue marking
MSI (s) (34:E0) [01:57:11:133]: Product: Surfshark -- Error 1606. Could not access network location Surfshark.
Error 1606. Could not access network location Surfshark.
Property(S): ErrorDialog = ErrorDlg
Write-Output "ERROR: $($_.Exception.Message)"
Exit 0x23E #ERROR_UNHANDLED_EXCEPTION
Property(S): POWERSHELL_EXECUTION_LOG = [SC] OpenService FAILED 1060:
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0

Automated error analysis suggests -1978335226 may mean Running ShellExecute failed
Automated error analysis suggests 1603 may mean Previous MSI installer is missing (Or it might mean Install successful but system restart may be required.) Should this be add as an InstallerSuccessCode or similar?
Automated error analysis suggests 1606 may mean ERROR_UNKNOWN_FEATURE - Feature ID not registered.
(Automated response - build 897.)

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-10-16 01:57:12.729 [CLI ] ShellExecute installer failed: 1603
LookupUserGroupFromRid() FAILED
LookupAccountSidW() FAILED
LookupUserGroupFromRidSDDL() FAILED
LookupAliasFromRid() FAILED
[SC] OpenService FAILED 1060:
ERROR: The process "Surfshark.AntivirusService.exe" not found.
CustomAction StopAndRemoveAVService returned actual error code 1603 but will be translated to success due to continue marking
MSI (s) (34:E0) [01:57:11:133]: Product: Surfshark -- Error 1606. Could not access network location Surfshark.
Error 1606. Could not access network location Surfshark.
Property(S): ErrorDialog = ErrorDlg
Write-Output "ERROR: $($_.Exception.Message)"
Exit 0x23E #ERROR_UNHANDLED_EXCEPTION
Property(S): POWERSHELL_EXECUTION_LOG = [SC] OpenService FAILED 1060:
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0

Automated error analysis suggests -1978335226 may mean Running ShellExecute failed
Automated error analysis suggests 1603 may mean Previous MSI installer is missing (Or it might mean Install successful but system restart may be required.) Should this be add as an InstallerSuccessCode or similar?
Automated error analysis suggests 1606 may mean ERROR_UNKNOWN_FEATURE - Feature ID not registered.
(Automated response - build 897.)

I have compared with the old manifest version <IP_ADDRESS>9 I think is not much different with this commit

Close with reason: Duplicate of #183766;


Fix for broken filter page

Coverage remained the same at 19.345% when pulling 8ad8480ee289ab1bb5479517550d1489b0fea877 on fix-filter-page into 0ad55a1406ed2838b452864bd212d975203bb9cd on master.


MovieExists

@maketochen commented on Thu Apr 02 2020
Where does MovieExists declare it

文档详细信息
⚠ 请勿编辑此部分。 docs.microsoft.com ➟ GitHub 问题链接必须具有此部分。

ID: 582aeaf8-770f-6861-ab47-bb6a4f2206e4
Version Independent ID: 51894773-82dc-3c71-f675-8af42cfa925f
Content: ASP.NET Core 中的控制器方法和视图
Content Source: aspnetcore/tutorials/first-mvc-app/controller-methods-views.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@srvbpigh commented on Thu Apr 02 2020
Hello, @maketochen
Thank you for your feedback.
We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

It's all in the tutorial.


Bookmarks to keep track of observations

Proposed by Jim Johnson:
"A few times I have thought that it would be nice to have some mechanism for “bookmarking” particular submissions in iNaturalist that I want to come back to later, and these bookmarked submissions would be listed somewhere, such as my profile section, so I can see what I wanted to get back to. I can, of course, copy the URL to that submission and make a note of it somewhere, but it would be a nice feature to be able to bookmark it within the site. Just a thought…"

With faves https://github.com/inaturalist/inaturalist/issues/575 and mark ase reviewed https://github.com/inaturalist/inaturalist/issues/611 we've got 2 new ways to sort of bookmark things. Lets close this for now and give folks a chance to see if those features are sufficient for this usecase


Parallel installer on Windows GVim does not show progress

Could be this because of this issue? https://github.com/junegunn/vim-plug/issues/4
I mean, it works perfectly, but I don't have any feedback about the progress except for many consoles being opened, I supposed that each one represents a git process cloning the corresponding plugin.
If that is the case, have you tried any solution? Or something that's blocking the implementation?

@junegunn I ran into this too, annoyingly. I reported it to the vim_dev list (1) because the problem seems to lie directly with GVim rather than something in this plugins code. Seems that with the Windows version, when you are inside an embedded language you can't call redraw. Ever. I suspect the main UI loop may be blocked waiting for command to finish?
Due to this, I'm not certain what I'm going to do for Windows. Debating whether to just leave it disabled like ruby since its so poor to see GVim freeze until command unblocks.

https://groups.google.com/forum/#!topic/vim_dev/Pmisv__GAFo

@starcraftman Yeah, I've been considering disabling parallel installer on Windows altogehter because the experience is really horrible and unstable. It's perfectly fine for me if you decide to give up supporting Windows on your python implementation.


App is crashing on calling const result = await PhotoEditor.open(Options);

App is crashing on calling const result = await PhotoEditor.open(Options);  But  no errors are showing.

Add the highlighted code "AndroidManifest.xml". You can find this file under @baronha/react-native-photo-editor/android/src/main

Thank you so much @isubhann, the issue was instantly fixed for me, can you please tell me how did you know this was going to fix this issue? I wanted to understand the root cause of this.


feat: adding Target and Analytics with WebSDK

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--icicidirect--aemsites.hlx.live/research/equity
After: https://target-alloy-1--icicidirect--aemsites.hlx.live/research/equity

The current implementation

Make whole body hidden
Fetch Target Offers/ Proposition
Identify Section applicable for Target Offers/Proposition and Make them Hidden
Make Body Visible
Apply All Offers/Proposition as when Sections are loaded and comes into view port.

Current Limitation -
Propositions are applied to all whenever a new section comes into view port. So All proposition are applied again and again. There is no adverse effect is observed as of now because of this.
If we see any adverse effect because of this in future then for improvements.
Scope of Improvement when the needs arise

when Identifying the applicable sections , create a map of section and their associated Proposition/Offer
When a section comes into view port , apply Proposition/ Offers applicable to that section only.

Thanks,

FF doesn't load the page for me.

FF doesn't load the page for me.

@JiangLong2019

Thats Strange seems to be working. Lets take this offline discussion

proposition are applied again and again.

On small solution could be to apply a CSS class once the proposition has been applied. And then when applying propositions, check for the absence of this class.

Looks good to me! Just hard to judge the performance impact precisely since there is a lot of variance from the martech in the PSI report

Thanks @ramboz  we did some improvement, there was 2 request to backend which were taking time and hence could not got the quite time needed for TBT. Since both of the request were not needed for above the fold we moved it to observe and we are seeing the better numbers in general now.

@anagarwa A few more suggestions looking at the current state:

I'd only load social-utils.js if you actually do have socialShareAnchors on the page… even would try to defer this to lazy
Since blocks-utils.js is always loaded, move it up in the head.html so it's downloaded in parallel with the aem.js and scripts.js
Since alloy.js is loaded on every page load, you could do the same, or at least have a <link rel="preload" as="script" crossorigin="anonymous" href="/scripts/alloy.min.js"/> so the browser starts downloading it earlier. Same for the websdkconfig.js file
Do you need the LD schemas at the top of the eager phase and blocking? You might be able to defer to the top of the lazy phase, or just not await them so you can let the eager phase run while they load
Could you instrument the breadcrumbs in the lazy phase after the main LCP content? Just reserve the space via CSS to avoid CLS, but let it render afterwards

You should be able to win 2~3 more LHS points that way.


More font assets

Pull Request
🤨 Rationale
When working on the new nimble-dialog styling, I realized that our "light" fonts did not render correctly. There was no difference between specifying a font-weight of 300 (light) and a font-weight of 400 (normal). To fix the issue, I'm pulling in the light version of Source Sans Pro and the semi-bold version of Source Sans Pro. The light version allows us to have the correct fonts for subtitles, and the semi-bold version addresses some rendering inconsistencies we've seen between browsers for bold text.
👩💻 Implementation

Pulled in SourceSansPro-Light.woff2 and SourceSansPro-SemiBold.woff2
Updated fonts.css to point to the new fonts based on font-weight

🧪 Testing

Verified my pending dialog changes look correct
Looked at Chromatic diffs. There are quite a few, but they are all minor font changes. This affects a large number of our components because our component labels are semi-bold.

✅ Checklist

[x] I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite, you mentioned updating the readme to capture which fonts were included, but since each has to be included separately, I didn't see a value in also adding the information to the readme. Let me know if you disagree and think I should update some docs.

Might be anecdotal but the label fonts seem easier to read / sharper with this change (in addition to better consistency across Chrome and Firefox). Nice win!


freediag: init at unstable-2019-02-18

Motivation for this change
unstable-2019-02-18 since @fenugrec had not released since some years and later the better!
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Yeah yeah, I have a release "soon"... seriously just need to test it on my test ECUs before I package the release P)
Last changes probably shouldn't affect your packaging though.


Performance and size differences - possible regression in 1.2.2

I have observed since upgrading from 1.1.3 an exponential increase in pickling time (~ 1sec vs 1.5 minutes) of a map [String -> case class(simple strings and ints)] with around 350K members using the defaults for pickling/unpickling.
Also the size of the pickle roughly doubled.
Thank you for the pointers on the gitter channel.
Cheers!
Russ

Yes, this was indeed an omission in the algorithm design, as it did not consider such high volumes of objects :)
This will be fixed in 1.2.3

Fixed in release 1.2.3


update a few lingering uses of [Bb]luemix

Codecov Report

Merging #4794 into master will decrease coverage by 6.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4794      +/-   ##
==========================================
- Coverage   85.11%   78.53%   -6.59%
==========================================
  Files         197      197
  Lines        8843     8843
  Branches      610      610
==========================================
- Hits         7527     6945     -582
- Misses       1316     1898     +582

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...enwhisk/connector/kafka/KamonMetricsReporter.scala
0% <0%> (-100%)
:arrow_down:

...e/database/cosmosdb/cache/ChangeFeedConsumer.scala
0% <0%> (-100%)
:arrow_down:

...ore/database/cosmosdb/cache/CacheInvalidator.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-96.23%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-93.85%)
:arrow_down:

...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala
0% <0%> (-92.31%)
:arrow_down:

...e/database/cosmosdb/cache/KafkaEventProducer.scala
0% <0%> (-77.78%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-74.08%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
7.69% <0%> (-50%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f418c25...6294de8. Read the comment docs.


version 2.6.3 isn't on maven central

I'm unable to download version 2.6.3 and according to Sonatype, the latest version is 2.6.2 from August 29th.
publish-to-maven-central #22 seems to have completed successfully, so did something else happen to it?

Yeah, that’s weird. I thought I pushed those out to central. I’ll take a look.

I just re-ran the publish job and releaced all the artifacts. I’ll check back in an hour and see if they’re on central.

It looks like I forgot to hit release last time. 2.6.3 is on central now. Sorry for any inconvenience.

Thanks for looking into it and the quick fix! 👏


Fix WP media domains

This PR fixes a problem with the domain-name-switcher we apply to Wordpress media links. The current implementation sometimes modifies and breaks links to external sites (that share the same URL path structure as our own Wordpress media).

Still checking to see if I've covered every case.


CarPlay causes panic.

Apple CarPlay causes a panic on Beta 4, iPhone 13 Pro Max, iOS 15.4.

yes. me too. 15.4 iPhone 12

Same here iOS 15.3 iPhone 12

update to beta 7, fixed it for me
export repos and tweak list!!! you will have to reinstall env due to switching to sileo stable

remove snowboard

Same on iPhone 12 Pro Max on iOS 15.4.1

Also have the problem. Removed Snowboard but problem still persists.

Also have the problem. Removed Snowboard but problem still persists.
Public Beta 1. iPhone 13 Pro Max 15.3

Why are you using Public Beta 1? Thats probably why.

with beta 8 and snowboard icon pack disabled it works perfectly. so I create a shortcut automations where I disable the theme when Carplay is connected and viceversa with ssh script using "snowboardutil" command.
like this:

snowboardutil -u /theme/path/     DISABLE THEME
snowboardutil -t /theme/path/     ENABLE THEME

this should already be fixed in upstream, if this still happens in the final release when that's out, open another issue


Introduced start_allocated function + minor improvements

It works with my workloads on WSC and Lassen. I would be happy to do more testing if you have something at hand to try.

It works with my workloads on WSC and Lassen. I would be happy to do more testing if you have something at hand to try.

Ok, if you've run it then the daemon=yes problem must have been fixed. In the bash script that I originally wrote, I needed daemon=no. I just carried that over to the python script so maybe it was fixed so daemon=yes works now.

Great, thanks!


fix: use saucelabs latest

This uses the Saucelabs latest feature.

Hmm, lots of "Cannot start latest..."

yes, because I didn't specify the platform :-/ I hoped SL would figure out a platform automatically.

Opened a ticket with SL support.

(thumbsup) Thanks for looking into this!

Sauce issue thread
skatejs wrote:
I was trying to use: http://sauceio.com/index.php/2016/03/new-browser-version-shortcuts/
I noticed that when using a definition with “latest-n” and not specifying a platform, Saucelabs doesn’t figure out a valid one by itself, the build just doesn’t start.
E.g.
ERROR [launcher.sauce]: Can not start safari latest-1
[init({“version”:”latest-1″,”platform”:”ANY”,”tags”:[],”name”:”Skate unit tests (master)”,”tunnel-identifier”:”karma1458098888″,”record-video”:false,”record-screenshots”:false,”device-orientation”:null,”disable-popup-handler”:true,”build”:”2520″,”public”:null,”customData”:{},”browserName”:”safari”,”base”:”SauceLabs”})] The environment you requested was unavailable.
Unsupported OS/browser/version/device combo: OS: ‘unspecified’, Browser: ‘safari’, Version: ‘8.0.’, Device: ‘unspecified’
Would be good if that can be added, otherwise the definition needs to be changed with every major release that shifts the platform.
The definition is here: https://github.com/skatejs/build/commit/8646983a1b7417531cafd81e1b22adeb7cc9041a
Matt Dunn replied:
Hi,
The intention behind the latest-n browser version capability is really for browsers where we support multiple versions of a browser per OS. That’s Chrome and Firefox really and yes, you still have to specify an OS. For Safari, we support one version of Safari per OS X version.
That said, it would be a good idea to be able to just specify a browser with “latest” and have Sauce Labs work out the correct OS to run on rather than have to specify this yourself. I’m going to speak to the Product Manager who’s responsible for this area and see whether that’s on the roadmap.
I’ll let you know what I find out.
Matt

still 9 failures on Safari 7.0.6 - Saucelabs seems to only return 7.0.6 now

I disabled Safari 7 for now and opened a ticket with SL - seems as if even when specifying 7.17 explicitly, you still get a 7.0.6.

I disabled the sauce image in the readme as it was severely broken. Might be good to uncomment that.

lgtm if tests pass


Some values need to be divided by 10

The temperature in integration shows 190 degrees, meanwile on the DConnect site is 19.0
Total Energy and Partial Energy in integration need to be divided by 10 too
CPU load is always 100-99% do not found the real value on the site, may be jus a dummy.
v2023.12.2

@Djavdeteg
Can easily fix the Total and Partial energy.
Needed a bit of thinking on how to solve the temperature though.
In your Esybox.mini data it comes back as "TE_HeatsinkTemperatureC": "208", with a meaning of 20.8 C
In my own Esybox data it comes back as "TE_HeatsinkTemperatureC": "22", with a meaning of 22 C
So sometimes need to divide by 10, sometimes not. I've now coded that to depend on the device distro string contains the substring 'mini'. I may need to alter that condition when I get feedback from people with pumps other than ESybox and Esybox.mini
There is a new version v2023.12.3 available for download, please let me know if that resolves the issues with these properties.

Thank you for your work again!
The Total Energy, Partial Energy and Heatsink temperature are working now.
There are some other values would be nice to fix:
Memory free 82,644 MB need to be 82,644 B
Ram used 296 192 kB and Ram used max 303 776 kB need to be in Bytes too, I suppose
Last period energy counter  (integration) 59 w/o units, Previous month energy consumption (site) 5.9 kWh
Last period flow counter (integration) 10112 w/o units, Previous month water consumption (site) 10.112 mc
Anti lock (AE), Anti cycling (AY) and Anti Freeze (AF) in integration and online is working conversely. If Enabled online it shows the Disabled status and vice versa.
Anti Freeze (AF) is showing just numbers  1 or 0  instead of Disabled/Enabled
Anti cycling (AY) has the third state "Smart", integration shows the number 2 instead of string

Processed all your comments; a new v2023.12.4 is published.
Strange how the units of some values differ per pump type. For instance, MemFree is in bytes for Esybox.mini, but in kB for Esybox.
The RamUsed and RamUsedMax are even more different. In kB for the Esybox.mini, but % for the Esybox.
I now also spotted that the installations.json returned by DConnect actually contains information about units, weight and names of enumeration values. For instance:

v2023.12.4 is OK
The last value I didnt notice earlier is "Actual period energy counter" it is 50 kWh now instead of 5.0 kWh.
Merry Xmas
D.

Resolved the "Actual period energy counter" with a factor 10.
Also adapted "Actual period flow counter" which was in liters while the installations.json indicates to use m3 with a factor of 0.001. That now makes it consistent with the "Last period flow counter"
Will both be in the next version v2023.12.5 (some days after Xmas)


FF: Support Audit Log Types for Feature Flags

Is your feature request related to a problem? Please describe.
Currently, we don't have specific audit log types (enum) for feature flags, so we need to support them to enable proper filtering.
Describe the solution you'd like
The list of audit log types for feature flags:

Feature Flag Created
Feature Flag Updated (below lists belong to this type and are only included in the log message)

Feature Flag Include List Created
Feature Flag Include List Updated
Feature Flag Include List Deleted
Feature Flag Include List State Changed (enabled/disabled a specific include list or the "Include All" slide toggle)
Feature Flag Exclude List Created
Feature Flag Exclude List Updated
Feature Flag Exclude List Deleted

Feature Flag Deleted
Feature Flag State Changed (enabled/disabled)
Feature Flag Design Exported

Some examples ('My Feature Flag' links to the details page like how experiment logs work):

"Successfully created 'My Feature Flag'."
"Successfully updated 'My Feature Flag' - The include list 'My Schools' has been added."
"Successfully updated 'My Feature Flag' - The include list 'My Schools' has been updated."
"Successfully updated 'My Feature Flag' - The include list 'My Schools' has been enabled."
"Successfully updated 'My Feature Flag' - The include list 'My Schools' has been deleted."
"Successfully enabled 'My Feature Flag'."
"Successfully deleted 'My Feature Flag'."

Additional context
I tried to make the log types consistent with the existing ones for experiments:

For your reference, the log messages can be more concise if we implement the local logging in the future:

Related issue: https://github.com/CarnegieLearningWeb/UpGrade/issues/1844

@amurphy-cl @danoswaltCL @bcb37 @VivekFitkariwala @ppratikcr7 @Yagnik56 Please let me know what you think about the Audit Log Types I listed above.

@Yagnik56 will create a new issue and PR for front end work

I am doing QA for this isssue


Improve username behavior

Fixes #<1>

It's a good idea to open an issue first for discussion.

[ all] Tests pass
[@spamcat4brian ] Appropriate changes to README are included in PR

completed

completed


No position encoder in your huggingface sd15 model weights

Someone asked me to support your work in AUTOMATIC1111 SD WebUI, and I have some questions.
There is no position encoder found in https://huggingface.co/wangfuyun/AnimateLCM/resolve/main/AnimateLCM_sd15_t2v.ckpt?download=true
However, in your diffusers weights https://huggingface.co/wangfuyun/AnimateLCM/resolve/main/diffusion_pytorch_model.fp16.safetensors?download=true, I do find position encoder, but it's incomplete. Typically in mid_blocks there are 2 position encoders, but in your diffusers model, there is only one.
It seems to me that you did require position encoding in your model because I saw https://github.com/G-U-N/AnimateLCM/blob/master/animatelcm_sd15/configs/inference-t2v.yaml#L23
I would appreciate if anyone can explain to me the difference between your model and the original AnimateDiff model architecture, or anyone can fix this issue by updating your weights on huggingface.

I did try different archs but the released version is generally identical to animatediff.
For you question, the position embedding are just some fixed hyper-parameters instead of trained weight and therefore I delete it in my code base and my weights. You won't get error if use my code.
The diffusers weight are converted by diffusers team. I am not exactly sure about the correctness.
You may also refer to https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved, which supports the loading of AnimateLCM related weights.


chore: use mpl smart contracts packages

Summary
All smart contract specific code was moved into
metaplex-foundation/metaplex-program-library
and will be maintained in there.
Additionally modules that are core to all those contracts were moved there as well.
The exposed packages were added as dependencies in this repo and all code updated to reference
those packages, including tests.
Verification
I ran the following successfully from the project root:
yarn tsc -b tsconfig.build.json
yarn build
yarn test

Next Steps
Working across Repos
At this point I did not add any scripts that aid in cross-repo development, i.e. if you need to
make a change to a smart contract in conjunction with changes in this higher level SDK repo.
I wanted to let contributors decide which tools they wanted to leverage to provide local links
while working on those changes.
In my case I did use simple ln -s by doing something similar to the following in order to
link the @metaplex-foundation/mpl-metadata package:
cd node_modules/\@metaplex-foundation/
rm -rf mpl-metaplex/
ln -s ~/dev/metaplex-foundation/mpl/metaplex/js/ mpl-metaplex/

Once that link is set up just rebuilding in the mpl repo after updates makes them usable in
this SDK repo.
Testing
I'm currently working on a POC showing how the smart contracts can be integration tests
(running the actual rust contracts in a local validator).
I will provide the minimum to show passing/failing (skipped) tests and will include simple
test-utils to make setting them up easier.
In case of interest you can review the current state of that
task
I'm then delegating fixing/adding more tests inside the mpl repo to the SDK contributors.
Going Forward
Please provide PRs to smart contract changes in the mpl repo including tests that demonstrate that
they work properly.
Higher level SDK changes should be added + tested in this SDK repo as was done previously.

Good job 👍
I think we need to move the new dependencies to peerDependencies section since users won't be able to use Metaplex account classes in their apps without installing the low-level API.
Probably it makes sense to consider moving other solana dependencies to peerDependencies.

@kurpav please open an issue WRT to items we need to address.
Let's discuss the dependency issue there as well. I'm not sure what you mean as dependencies that are not optional and need to be exact should be a dependency, not a peer dependency.
The contracts are underpinning parts of the SDK essentially.
But as I said let's not discuss here, but in a separate issue.

:tada: This PR is included in version 4.10.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update Kotlin to 1.9.24 + Anvil to 2.5.0-beta11

Task/Issue URL: https://app.asana.com/0/488551667048375/1207912454820662/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#4819  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joshliebe and the rest of your teammates on  Graphite


[PIL-1147] added scalafix & applied reported fixes

Added:

latest scalafix plugin added to plugins.sbt
scalafix plugin added to build.sbt
.scalafix.config file added
various fixes and improvements reported by scalafix plugin made to files

I'm not sure this was on the jira but we're currently using this ruleset on the other repos, probably worth using the same here: .scalafix.conf
rules = [ExplicitResultTypes, OrganizeImports, RemoveUnused,DisableSyntax]

OrganizeImports {
  groupedImports = Keep
  coalesceToWildcardImportThreshold = 3
}

DisableSyntax {
  noVars = true
  noNulls = true
  noReturns = true
}

Thanks, needed to force the push since it's an ignore rule in .gitignore


Design Middleware implementation

as this is Rx powered, middleware will take a different form than Redux would.
side effects vs no side effects
sync vs async.
etc

needs design

There's middleware and there's async... in redux, you use middleware - mainly - to get async working, you can use this or that, but the question is, do you even need the ability to write middlewares ... or you just need to support async out of the box.. it's the latter for me, at least for now.

Almost all cases can be covered via spawn or wrap Like a Observable, Promise, thunk, scalar value, complicated Observable etc. https://github.com/Reactive-Extensions/RxJS/pull/855 I made this method a very powerful. Also will be interesting Rx.Observable.when which is an implementation of Join Pattern @fxck @robwormald

Would not redux-saga's be a good fit for async behaviors? Would redux-saga notice that it isn't working with a redux store? Would we be confined to the disassociated runSaga approach?

See https://gist.github.com/tomkis1/8b3573ca9483d60c8b34 for a few ideas on an Rx version of Saga. I much prefer this style...

this is initially implemented in 1.3.2 :+1:

To follow up, can I return promises or observables in my meta reducers - I want to be able to save the state with using promises.


update extension ids

Pull requests into cqm-parsers require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[ ] This pull request describes why these changes were made.
[ ] Internal ticket for this PR:
[ ] Internal ticket links to this PR
[ ] Code diff has been done and been reviewed
[ ] Tests are included and test edge cases
[ ] Tests have been run locally and pass

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Codecov Report

Merging #77 into cqm_reports_2_x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           cqm_reports_2_x      #77   +/-   ##
================================================
  Coverage            89.14%   89.14%
================================================
  Files                   66       66
  Lines                 1751     1751
================================================
  Hits                  1561     1561
  Misses                 190      190

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e6ccd5...87d2b82. Read the comment docs.


Intellisense does not detect new packages

It may take ~5-10 seconds to rebuild index

Also #4030, may be the same issue


fix for Discussion #4333 (PR as req by Pascal Berger)

minor typo fix

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.DickBaker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@DickBaker thank you for fixing this!
Are you in a position to sign the CLA?

Nils, Hi
Think I did that already (as otherwise CLA wouldn’t have accepted as below).

Regards,
Dick
From: Nils Andresen @.>
Sent: 29 September 2024 20:10
To: cake-contrib/CakeContrib.Guidelines @.>
Cc: Dick Baker @.>; Mention @.>
Subject: Re: [cake-contrib/CakeContrib.Guidelines] fix for Discussion #4333 (PR as req by Pascal Berger) (PR #352)
@DickBaker https://github.com/DickBaker  thank you for fixing this!
Are you in a position to sign the CLA?
—
Reply to this email directly, view it on GitHub https://github.com/cake-contrib/CakeContrib.Guidelines/pull/352#issuecomment-2381538737 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVFJLG4OEKHHCZPPZL6WZLZZBGCHAVCNFSM6AAAAABO5EYH6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGUZTQNZTG4 .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/AAVFJLHE7V4O32WYIW7W4VTZZBGCHA5CNFSM6AAAAABO5EYH6WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUN6NS3C.gif Message ID: @.*** @.***> >
From: CLAassistant @.*** @.>
Sent: 26 September 2024 15:27
To: cake-contrib/CakeContrib.Guidelines @. @.>
Cc: Dick Baker @. @.> ; Author @. @.***>
Subject: Re: [cake-contrib/CakeContrib.Guidelines] fix for Discussion #4333 (PR as req by Pascal Berger) (PR #352)
https://cla-assistant.io/cake-contrib/CakeContrib.Guidelines?pullRequest=352
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement https://cla-assistant.io/cake-contrib/CakeContrib.Guidelines?pullRequest=352  before we can accept your contribution.

DickBaker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user .
You have signed the CLA already but the status is still pending? Let us recheck https://cla-assistant.io/check/cake-contrib/CakeContrib.Guidelines?pullRequest=352  it.
—
Reply to this email directly, view it on GitHub https://github.com/cake-contrib/CakeContrib.Guidelines/pull/352#issuecomment-2377132793 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVFJLBKMB7XYLEJRJWEEW3ZYQKRZAVCNFSM6AAAAABO5EYH6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGEZTENZZGM .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/AAVFJLHWCXB2Z55LVFUYXW3ZYQKRZA5CNFSM6AAAAABO5EYH6WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUNWAVPS.gif Message ID: @.*** @.***>

@DickBaker your changes have been merged, thanks for your contribution :+1:


feat: Enable creation of DBs with old address format.

This change enables the creation of DBs with the old address format, by passing an additional option to the accessController.
The main reason for this change is that in 3Box we are not saving the addresses of the users DBs. Rather, we generate the addresses by opening the DB with it's name and the writing key. Without this change we can only open a new db where the users data won't be available.
This PR depends on https://github.com/orbitdb/orbit-db-io/pull/2 and https://github.com/orbitdb/orbit-db-access-controllers/pull/29

Thanks @oed! This is superseded by #625


New version: BAT v0.5.0

Registering package: BAT
Repository: https://github.com/bat/BAT.jl
Created by: @oschulz
Version: v0.5.0
Commit: 89ba18baa8e72e908da9f6f8e805d473b837b406
Reviewed by: @oschulz
Reference: https://github.com/bat/BAT.jl/commit/89ba18baa8e72e908da9f6f8e805d473b837b406#commitcomment-35678987

Your new version pull request does not meet all of the guidelines for automatic merging.
Specifically, your pull request does not meet the following guidelines:

The following dependencies do not have a compat entry that has an upper bound: Measurements

If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]

Your new version pull request met all of the guidelines for automatic merging.
I will automatically merge this pull request during the next cron job.
If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]


Invalid compose .yml (clickhouse)

In case of clickhouse params missing form ".env" environment file

I just pulled the latest changes and am now getting the same error. Previously I was working with commit 2f575017e440a336e4a02d346d86ed6d16898ee0 without issue.

I just pulled the latest changes and am now getting the same error. Previously I was working with commit 2f575017e440a336e4a02d346d86ed6d16898ee0 without issue.

Solved. The env-example was updated with the appropriate CLICKHOUSE variables however I did not copy them to my .env file.

Solved. The env-example was updated with the appropriate CLICKHOUSE variables however I did not copy them to my .env file.

The problem with all these updates is when they add ports. I have a spot at the bottom of my .env file that I add the port variable and just set it to 0. When it's blank, it breaks.

The problem with all these updates is when they add ports. I have a spot at the bottom of my .env file that I add the port variable and just set it to 0. When it's blank, it breaks.


joal won't launch on my computer

I have the Last MacBook Air M3 on Sonoma

read my answer in #109 :)


[FEATURE] Add an API to return validation parameters

Is your feature request related to a problem?
Users do not have an easy way to validate workflow steps, particularly in understanding what parameters are part of the output (e.g., model_id) and which inputs are required vs. optional (other than by laboriously visiting original API docs).  We should allow users to easily identify these requirements via API.
In addition, the planned front-end will need access to this same information in order to enable real-time validation in the drag-and-drop interface.
What solution would you like?
Create a new REST API to return content equivalent to the workflow-steps.json file.
Allow an optional parameter for the workflow step type which returns only the content of that portion of the file.
What alternatives have you considered?

Force users to navigate documentation.
Point users to the JSON file on GitHub.
Document every single step on opensearch.org.

Do you have any additional context?
We already parse the contents of this file into a WorkflowValidator class, which internally contains a Map<String, WorkflowStepValidator>.

The API can simply return the contents of these objects, which simply requires toXContent() methods.
We could also avoid the potential issues with parsing this file (e.g., users experiencing runtime validation checks rather than compile time checks) by simply hardcoding the WorkflowStepValidator map.  We can then remove the parse methods and all the complexity with exceptions that they bring.

Request: GET /_plugins/_flow_framework/workflow/_step
Response:
{
  "undeploy_model": {
    "inputs": [
      "model_id"
    ],
    "outputs": [
      "success"
    ],
    "required_plugins": [
      "opensearch-ml"
    ]
  },
  "register_model_group": {
    "inputs": [
      "name"
    ],
    "outputs": [
      "model_group_id",
      "model_group_status"
    ],
    "required_plugins": [
      "opensearch-ml"
    ]
  },
  "register_remote_model": {
    "inputs": [
      "name",
      "connector_id"
    ],
    "outputs": [
      "model_id",
      "register_model_status"
    ],
    "required_plugins": [
      "opensearch-ml"
    ]
  },
  "register_local_sparse_encoding_model": {
    "inputs": [
      "name",
      "version",
      "model_format",
      "function_name",
      "model_content_hash_value",
      "url"
    ],
    "outputs": [
      "model_id",
      "register_model_status"
    ],
    "required_plugins": [
      "opensearch-ml"
    ],
    "timeout": "1m"
  },
  "create_index": {
    "inputs": [
      "index_name",
      "default_mapping_option"
    ],
    "outputs": [
      "index_name"
    ],
    "required_plugins": []
  },
  "delete_agent": {
    "inputs": [
      "agent_id"
    ],
    "outputs": [
      "agent_id"
    ],
    "required_plugins": [
      "opensearch-ml"
    ]
  },
  "create_ingest_pipeline": {
    "inputs": [
      "id",
      "description",
      "type",
      "model_id",
      "input_field_name",
      "output_field_name"
    ],
    "outputs": [
      "pipeline_id"
    ],
    "required_plugins": []
  },
  "register_local_pretrained_model": {
    "inputs": [
      "name",
      "version",
      "model_format"
    ],
    "outputs": [
      "model_id",
      "register_model_status"
    ],
    "required_plugins": [
      "opensearch-ml"
    ],
    "timeout": "1m"
  },
  "create_tool": {
    "inputs": [
      "type"
    ],
    "outputs": [
      "tools"
    ],
    "required_plugins": [
      "opensearch-ml"
    ]
  },
  "noop": {
    "inputs": [],
    "outputs": [],
    "required_plugins": []
  },
  "create_connector": {
    "inputs": [
      "name",
      "description",
      "version",
      "protocol",
      "parameters",
      "credential",
      "actions"
    ],
    "outputs": [
      "connector_id"
    ],
    "required_plugins": [
      "opensearch-ml"
    ]
  },
  "delete_model_group": {
    "inputs": [],
    "outputs": [],
    "required_plugins": []
  },
  "register_agent": {
    "inputs": [
      "name",
      "type"
    ],
    "outputs": [
      "agent_id"
    ],
    "required_plugins": [
      "opensearch-ml"
    ]
  },
  "deploy_model": {
    "inputs": [
      "model_id"
    ],
    "outputs": [
      "deploy_model_status"
    ],
    "required_plugins": [
      "opensearch-ml"
    ],
    "timeout": "15s"
  },
  "delete_connector": {
    "inputs": [
      "connector_id"
    ],
    "outputs": [
      "connector_id"
    ],
    "required_plugins": [
      "opensearch-ml"
    ]
  },
  "register_local_custom_model": {
    "inputs": [
      "name",
      "version",
      "model_format",
      "function_name",
      "model_content_hash_value",
      "url",
      "model_type",
      "embedding_dimension",
      "framework_type"
    ],
    "outputs": [
      "model_id",
      "register_model_status"
    ],
    "required_plugins": [
      "opensearch-ml"
    ],
    "timeout": "1m"
  },
  "delete_model": {
    "inputs": [
      "model_id"
    ],
    "outputs": [
      "model_id"
    ],
    "required_plugins": [
      "opensearch-ml"
    ]
  }
}

Should we remove the create index and create ingest pipeline from the JSON?

Should we remove the create index and create ingest pipeline from the JSON?

We should. Let me push the change.


[BUG] itemized deduction ceiling switch not correctly processed by taxbrain

I noticed that setting the switches in Deductions subject to the cap on itemized deduction benefits to false did not actually cause the parameter, _ID_BenefitCap_Switch, that was passed to taxcalc to be false.  I ran this reform on a local instance of taxbrain and the value of _ID_BenefitCap_Switch was passed to taxcalc as
 {... u'_ID_BenefitCap_Switch': [[True, True, False, True, 1.0, 1.0, 1.0]], ...}
But when I upload the reform as a file, ID_BenefitCap_Switch is passed back as:
{...u'_ID_BenefitCap_Switch': [[1.0, 1.0, 0.0, 1.0, 0.0, 1.0, 1.0]], ...}
Here is a link to the test app run of the reform file: http://ospc-taxes7.herokuapp.com/taxbrain/1389/
And here are the contents of the reform file:
{
    "policy": {
        "_ID_BenefitCap_Switch":
            {"2017": [[1.0, 1.0, 0.0, 1.0, 0.0, 1.0, 1.0]]},
        "_ID_c":
            {"2017": [[20000, 40000, 20000, 20000, 99e9]]}
    }
}

@brittainhard @PeterDSteinberg

@hdoupe,  Thanks for the bug report in issue #598.
Let me be sure I understand your findings.
Are you saying that when you use the regular GUI interface to TaxBrain, the reform passed to taxcalc is correct, but when you use the file-upload interface to TaxBrain, the reform passed to TaxBrain is incorrect?  Is this right?  Or am I confused?
@brittainhard @PeterDSteinberg

@martinholmer Yes, it appears that there is an issue with the GUI interface to Taxbrain, but the file upload functionality appears to work correctly.

@hdoupe said:

it appears that there is an issue with the GUI interface to Taxbrain, but the file upload functionality appears to work correctly.

So, I had it reversed.  You're finding that the GUI interface to TaxBrain has the reform wrong while the file-upload interface to TaxBrain has it right.  Is that correct?

@martinholmer said

So, I had it reversed. You're finding that the GUI interface to TaxBrain has the reform wrong while the file-upload interface to TaxBrain has it right. Is that correct?

Yes, that is correct.  My apologies for the confusion.  I edited my initial comment in an effort to clear this up.

Closed via #641


[WIP] Add Support for joins

This is still WIP. Wandered down some wrong paths, but I think it is the right general approach.
There is currently some issue with right joins, but other wise this is ready for a look.

Well, this diff fixes the the errant test, but.... ugh. I don't have complete confidence in the rationale for the changes, also its just a mess
diff --git a/modules/cudf/src/data_frame.ts b/modules/cudf/src/data_frame.ts
index e0e66c4..1d016ed 100644
--- a/modules/cudf/src/data_frame.ts
+++ b/modules/cudf/src/data_frame.ts
@@ -308,7 +308,11 @@ export class DataFrame<T extends TypeMap = any> {
       }
     }

-    right_result = right_result.drop(on) as any;
+    if (how == 'right' && on.length > 1) {
+      left_result = left_result.drop(on as any) as any;
+    } else {
+      right_result = right_result.drop(on) as any;
+    }

     // if there are no suffices provided, and there are column conflicts, then we
     // want to drop columns on the right results (so, assign over from left result)
@@ -318,15 +322,29 @@ export class DataFrame<T extends TypeMap = any> {
     const rnames = right_result.names;

     // otherwise for any column name conflicts, apply the suffix before combining
-    for (const name of lnames) {
-      if (rnames.includes(name as any)) {
-        const rcol   = right_result.get(name as any);
-        right_result = right_result.drop([name as any]) as any;
-        right_result = right_result.assign({[name + rsuffix]: rcol});
-
-        const lcol  = left_result.get(name as any);
-        left_result = left_result.drop([name] as any) as any;
-        left_result = left_result.assign({[name + lsuffix]: lcol});
+    if (how == 'right') {
+      for (const name of rnames) {
+        if (lnames.includes(name as any)) {
+          const rcol   = right_result.get(name as any);
+          right_result = right_result.drop([name as any]) as any;
+          right_result = right_result.assign({[name + rsuffix]: rcol});
+
+          const lcol  = left_result.get(name as any);
+          left_result = left_result.drop([name] as any) as any;
+          left_result = left_result.assign({[name + lsuffix]: lcol});
+        }
+      }
+    } else {
+      for (const name of lnames) {
+        if (rnames.includes(name as any)) {
+          const rcol   = right_result.get(name as any);
+          right_result = right_result.drop([name as any]) as any;
+          right_result = right_result.assign({[name + rsuffix]: rcol});
+
+          const lcol  = left_result.get(name as any);
+          left_result = left_result.drop([name] as any) as any;
+          left_result = left_result.assign({[name + lsuffix]: lcol});
+        }
       }
     }

OK I've pushed some changes to get right-joins working but it still seems pretty ugly to me so I will keep looking a bit for improvements

Also went ahead and added left semi- and anti-joins since there was not alot more to do to include them

Here's an example of one way to do the join generic type signature in the TS playground:

Pushed commits with the generic signatures that include lsuffix and rsuffix :tada: