Default error boundary loses message of exception thrown during client-side routing

What version of Remix are you using?
1.19.3
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce

Create a trivial page like

export default function SimulatedRenderingErrorPage() {
  throw new Error('This is a simulated React error.');
}

Link to that page from another page

<Link to="/errors/react">Client-Rendered React Error</Link>

Run your app
Click the link you just created.
Observe that you see "Application Error" and a stack trace, but you don't see "This is a simulated React error."
Reload the page
Observe that you see "Application Error" and a stack trace, and now "This is a simulated React error." is also present

Expected Behavior

Actual Behavior

I don't think this is a bug but just a slight difference in behavior across JS runtimes.
Remix includes a root default error boundary that renders the stack in dev mode.  It looks like for errors in Node/Chrome/Edge, the stack includes the message by default (this is why you always get it on the hard reload, since the error comes from a render in Node, but on the client side transition it's rendering in the browser):

But errors in Firefox/Safari do not:

We keep the default error boundary UI to a minimum by design to avoid leaking any information to the end-user (and we genericize message and strip stack traces in production).
Apps should not be relying on the root default error boundary past any initial development and should instead be adding Error Boundaries to take control over the UI.
If you want the error.message to appear in all cases, you can add an ErrorBoundary to the root route:
export function ErrorBoundary() {
  let error = useRouteError();
  let heading: string;
  let meta: string | undefined;

  if (isRouteErrorResponse(error)) {
    heading = error.status + " " + error.statusText;
    meta = error.data;
  } else if (error instanceof Error) {
    console.error(error);
    heading = error.message;
    meta = error.stack;
  } else {
    heading = "Unknown Error";
  }

  return (

        <meta charSet="utf-8" />
        <meta name="viewport" content="width=device-width,initial-scale=1" />
        <Meta />
        <Links />

{heading}

        {meta ?
{meta}
 : null}
        <Outlet />
        <ScrollRestoration />


CharacterBody2D template uses move_toward incorrectly

Godot version
4.0 stable
System information
win 11
Issue description
If you select the CharacterBody2D template, you get this line:
		velocity.x = move_toward(velocity.x, 0, SPEED)
However, the docs say that the third parameter is delta. This means that velocity.x is set to 0 immediately since it can't be any greater than SPEED. The line could be replaced by velocity.x = 0.
I think the line should be replaced by velocity.x = move_toward(velocity.x, 0, SPEED * delta), right?
Also, someone on Discord confused the delta of the move_toward function with the _physics_process delta. Perhaps the docs should clarify that they're not the same and that delta just means change?
Steps to reproduce
Make a CharacterBody2D with the default template for it.
Minimal reproduction project
N/A

Should be fixed by #73873.


Roll Flutter Engine from ade610ec88b5 to 6a92731d2edc (1 revision)

https://github.com/flutter/engine/compare/ade610ec88b5...6a92731d2edc
2023-01-27<EMAIL_ADDRESS>[Impeller] ensure 1x1 has mipcount of 1 (flutter/engine#39182)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


feat: Add rudimentary MIPS support

In particular, this adds support for reading the CPU type and fixes some issues related to big-endian, such as UTF16 parsing, and DebugId parsing.
The Module DebugId parsing is now done at parsing-time because it needs to be endian aware.
For sentry folks, this fixes:

Unknown minidump arch 1: https://sentry.my.sentry.io/organizations/sentry/issues/297362
Garbage module names for example: https://sentry.my.sentry.io/organizations/sentry/issues/297548/events/99e6508a508744dd8aa19a06c57e5d23/

I’m a bit unsure how to write a unit-test for all this with reasonable effort 🤷🏻♂

The second commit makes the Cpu enum non_exhaustive. I wasn’t aware before, so this makes the PR technically a breaking change.

Yeah that's ok, it fits with #297


Fix validation for edit repo authorization

Changed the validation checking in able_to_edit_repo? in user model.

Fix for #347

Seems good, thanks


Remove 'failproof'

Description
Fixes GitHub PR status not showing whether tests fail or not, which allow failing tests to pass PR checks
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[x] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?
GitHub actions summaries
Checklist

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts
[x] I have checked that no one else is on staging and deployed this feature branch

Now to have on record that this change worked:


Bump CI build to go 1.23

What changed?

Bumped Go version used for CI + proto builds to 1.23

Why?

Our automated merge builds began failing

How did you test it?

Pending

Potential risks

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Support more parameters for variable commands

Support more parameters for the following commands:

Get-Variable
Set-Variable
New-Variable
Remove-Variable
Clear-Variable

Extra parameters supported:

Force
Scope
Visibility
Include
Exclude
Option

Improved error reporting for the variable commands.
Fixed a problem in PSObject being unable to assign a string to an enum property on an object.
Added some tests for ErrorRecord.
Support $host variable.
There are still some problems with the commands around local and global scope where even though local scope is specified in the command the global scope variables are affected. These tests have been marked as explicit for now.

Wow.


REJECT_MALFORMED cmd when trying to sync wallet

Hi all,
I've been getting strange error message when trying to sync my zap desktop wallet.
Attached is my lnd.log, it looks like peer <IP_ADDRESS> is sending a header which exceeds the max header length.
Anyone knows what could be wrong here?
lnd.log

The issue here seems to be that the zap wallet currently uses <IP_ADDRESS> as the backend btc node for the neutrino light-client, and this node appears to be having some issues. @JimmyMow can you check your bitcoin node please?

@mrfelton the BTCD node hosted at <IP_ADDRESS> is fine
@evertvr what version of Zap are you running?

Version 0.1.0
-------- Original Message --------
On May 28, 2018, 16:59, JimmyMow wrote:

@mrfelton the BTCD node hosted at <IP_ADDRESS> is fine
@evertvr what version of Zap are you running?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Lastest code in master @JimmyMow
I have also tried adding faucet.lightning.community:18333 as an additional neutrino node and it's unable to sync from that one too.
I'm using the latest lnd v0.4.1-beta release.
You can test by wiping out your LND data dir snd try setting up a new wallet from scratch

same problem, is it solved?

Same problem. Stuck at 75% on 0.1.1 beta for Windows 10 and Linux versions.

@fiddybux I would suggest that you try using the latest code from the master branch, along with the most recent build of lnd.

Hi,
I am currently stuck at 0% can anyone help? here is the log https://pastebin.com/m8F3ZJWz
Thanks:

I plonked the latest lnd into /opt/zap et al, and it seems to be syncing
properly now. Up to 35% of gradual increase rather than stuck at 0% or
instantly up to 75%. I'm getting Java errors on executing zap-desktop, but
it doesn't seem to be hindering the sync progress.
On Sat, 16 Jun 2018, 00:18 Tom Kirkpatrick<EMAIL_ADDRESS>wrote:

@fiddybux https://github.com/fiddybux I would suggest that you try
using the latest code from the master branch, along with the most recent
build of lnd.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/LN-Zap/zap-desktop/issues/391#issuecomment-397765028,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX8Vkey9ri29jkdLc_EU4p6qPkNOeft6ks5t9EC8gaJpZM4T7SA9
.

I'm closing this issue as it relates to an older version of Zap. The sync process has had an overhaul in v0.2.0.


⚠ Secret Website 3 has degraded performance

In f635c86, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2109 ms

Resolved: Secret Website 3 performance has improved in 727b95f.


Step 6: Creating My About Me

Step 6: Creating My About Me
In this step I:

Added aboutme.html file
Added aboutme.css file
Updated readme.md

Hello!
I made the requested changes and brought everything to my index.txt file.
Kindly have a look. Thank you. :smiley:


API Conciseness

The current API is somewhat verbose. I am unsure whether this is a natural attribute of a retained-mode API or if it is an artifact of the design of iui. More consideration is required and suggestions are welcome.

After looking at some other APIs (GTK+, QT, and WinForms), I don't think there's a way to avoid this.


Update some defines for F769I, if they are truly required?!

On my todo list was to remove this file all together.
Only a couple are used in tje f750dk port.
Do the ones commented out affect the f750 build?

In this build, none are commented out... just changed for the target at hand... and even that currently builds and (seems to) run ok.
Since this, Easiest check would be first to integrate https://github.com/Ryzee119/usb64/pull/50 then add the target to the CI. This can then (at very least) check it is able to build, before checking regressions in a PR...

Ive removed this file all together. I barely used anything from it, and just another file to lose track of
Superseded by fbb62394ee0a287f87fce7ade6ea3dedee145540

Since this, Easiest check would be first to integrate #50 then add the target to the CI. This can then (at very least) check it is able to build, before checking regressions in a PR...

The current CI should build all PlatformIO environments already


Issue #2: Between conditions don't bonk on nil

If the attribute isn't present, return false (instead of raising an error)

I think is preferable to raise an error, instead of silently evaluating the condition as falsey. Friendly errors and perhaps some way to mark attributes as optional could be the way to go.


New UI Homepage

Fixes #
Describe the changes you have made in this pr -In this PR i have redesigned the Homepage according to new design and have made it responsive.

Screenshots of the changes (If any) -

Coverage decreased (-0.9%) to 83.374% when pulling 3bc60f1a9420b0bbd30eead7ba1b06c764382152 on harshgujrati:homepage into a1e98b9acdc82878088e809c97a50551dd1cd22b on CircuitVerse:master.

I guess your have merged the code for Examples page in this pr

Okay @aayush-05 i will make the recquired correction.

Remove unrelated commits from the PR

Dropping a new pr for Homepage, this one is too hard to review and manage.

@tachyons Please close this.


How can i send data with pages

Im use this side menu but when i come back root view , its empty . i could not send data.

hi halily,
There a lots of tutorials online, and stackoverflow covers this totally.  Some googling should turn up lots of tips. Youtube is a great resource for sure.
http://jamesleist.com/ios-swift-passing-data-between-viewcontrollers/
We probably need a bit more info on what your UX is doing. Are you selecting a value from the list and want to preserve it? NSUserDefaults.standardUserDefaults() comes in super handy, maybe not always the purist way, but always works great when you need to access values that may be clicks away from where the data originated.
Singletons are probably good for this too, but I'm stuck with NSUserDefaults.standardUserDefaults() for now.
More data is needed I think to look at your issue.


Checklist Plugin Doesn't Recognize CHX Files

The checklist plugins do not recognize chx files unless they are fully properly formed XML files.  This is because the mime type is registering incorrectly because the  declaration is missing from the file.

A fix within Databrowse would either require a significant performance hit or require a "hack" to get the handler_support module to get namespace information from files with specific extensions, regardless of mimetype.  The latter is doable and relatively simple; however, it's not a good fix for the issue.  Instead, checklists should have XML declarations on the first line of the file.

XML specifies that the <?xml ... at the top of the file is optional. So
we really shouldn't be demanding it.
Not sure the best approach. Ideally, incremental parsing up through the
opening of the first element, then identify the tag name and namespace.
But I'm not sure there are any off the shelf parsers that work quite
this way.
Steve

On Wed, 2016-11-16 at 01:40 -0800, Tyler Lesthaeghe wrote:

A fix within Databrowse would either require a significant
performance hit or require a "hack" to get the handler_support module
to get namespace information from files with specific extensions,
regardless of mimetype. The latter is doable and relatively simple;
however, it's not a good fix for the issue. Instead, checklists
should have XML declarations on the first line of the file.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

That is true of XML 1.0; though, it is required in XML 1.1.
This problem results because the code that was added to identify the namespace of an XML file only runs if the file is recognized as application/xml by libmagic to avoid unnecessarily parsing the file.  Perhaps this is really a bug in libmagic and should be corrected there.
One possibility: using a local copy of the magic database that plugins can include content into that might correct these issues.  This might require some modifications to libmagic.  That would be much more efficient than using a bunch of random Python hacks.


Blocking feature stopped working

Hi!
Looks like there is an issue with the blocking feature in 0.3.4 and above.
...
   Compiling yahoo_finance_api v0.3.4
error[E0599]: no method named `compat` found for enum `std::result::Result<reqwest::blocking::response::Response, reqwest::error::Error>` in the current scope
   --> /Users/cm/.cargo/registry/src/github.com-1ecc6299db9ec823/yahoo_finance_api-0.3.4/src/lib.rs:460:44
    |
460 |     let resp = reqwest::blocking::get(url).compat();
    |                                            ^^^^^^ method not found in `std::result::Result<reqwest::blocking::response::Response, reqwest::error::Error>`
    |
   ::: /Users/cm/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/src/libcore/result.rs:247:1
    |
247 | pub enum Result<T, E> {
    | ---------------------
    | |
    | doesn't satisfy `_: std::future::Future`
    | doesn't satisfy `_: tokio_compat_02::FutureExt`
    |
    = note: the method `compat` exists but the following trait bounds were not satisfied:
            `std::result::Result<reqwest::blocking::response::Response, reqwest::error::Error>: std::future::Future`
            which is required by `std::result::Result<reqwest::blocking::response::Response, reqwest::error::Error>: tokio_compat_02::FutureExt`
            `&std::result::Result<reqwest::blocking::response::Response, reqwest::error::Error>: std::future::Future`
            which is required by `&std::result::Result<reqwest::blocking::response::Response, reqwest::error::Error>: tokio_compat_02::FutureExt`
            `&mut std::result::Result<reqwest::blocking::response::Response, reqwest::error::Error>: std::future::Future`
            which is required by `&mut std::result::Result<reqwest::blocking::response::Response, reqwest::error::Error>: tokio_compat_02::FutureExt`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.
error: could not compile `yahoo_finance_api`.

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

cargo.toml:
...
yahoo_finance_api = {version = "0.3.4", features = ["blocking"]}

Haven't observed that error yet, I will have a look at it.

Okay, I fixed it already. The call to compat() was just superfluous at this location and has been removed.
Version 1.0.1 should not have this bug.


Name cubed not available on pypi

@yuvipanda pointed out that the name "cubed" is almost impossible to Google - there are so many other projects called cubed. (In our field "cubed" would also likely get confused with "datacube".)
In fact, "cubed" is not available on pypi (I used this package to check quickly).
Would you consider renaming the package to something more distinctive? The best time to do it would be before you have many users...  :sweat_smile:
If you want ideas then you could perhaps get inspiration from the key feature of bounding the memory usage - e.g. a word that expresses boundedness, limits, predictability, or a concept from the memory-safety  world.

In fact, "cubed" is not available on pypi (I used this package to check quickly).

cubed on PyPi is this project! 😄
Naming is hard! Finding a name that is Google-able generally means coming up with a unique made-up word. In the absence of that, people tend to Google for projects using modifiers, such as "cubed array python".
Having said that, I'm not averse to renaming it, but all the names I came up with were too general (like cubed), not on PyPi, or were just pretty awful (judged by my family).


ARM32 compile problem..

I want to use google-cloud-cpp library on ARM32.
So, I try to compile source on ARM32(ubuntu 20.04).
(And When I try it on ARM64(ubuntu20.04), it compiles successfully. But some library which I used doesn't support ARM64, so I have to use ARM32)
It returns 2 errors. But I don't know how to fix it.
Please give me information to resolve it.
Here are the error log.
/root/google-cloud-cpp/google/cloud/storage/parallel_upload.cc:409:30: error: conversion from 'long long int' to 'std::streamsize' {aka 'int'} may change value [-Werror=conversion]
409 |     istream.read(buf.data(), to_copy);
|                              ^~~~~~~
/root/google-cloud-cpp/google/cloud/storage/parallel_upload.cc:413:32: error: conversion from 'long long int' to 'std::streamsize' {aka 'int'} may change value [-Werror=conversion]
413 |     ostream_.write(buf.data(), to_copy);
|                                ^~~~~~~

I think the problem is the code assuming that std::streamsize and std::streamoff are the same types, which evidently is not the case on ARM32 for Ubuntu.  I will send a PR to fix this (and maybe cleanup other problems), but unfortunately we do not have ARM32 machines we can use to test this.  Would you be willing to test the changes?  Or report if they do not work?

Sure. I can test it. Once  fixing finished, Please let me know. And then I will report the result.

I think the problem is the code assuming that std::streamsize and std::streamoff are the same types, which evidently is not the case on ARM32 for Ubuntu. I will send a PR to fix this (and maybe cleanup other problems), but unfortunately we do not have ARM32 machines we can use to test this. Would you be willing to test the changes? Or report if they do not work?

How do I download changed source code?

I think the problem is the code assuming that std::streamsize and std::streamoff are the same types, which evidently is not the case on ARM32 for Ubuntu. I will send a PR to fix this (and maybe cleanup other problems), but unfortunately we do not have ARM32 machines we can use to test this. Would you be willing to test the changes? Or report if they do not work?

How do I download changed source code? I am not familiar with

I think the problem is the code assuming that std::streamsize and std::streamoff are the same types, which evidently is not the case on ARM32 for Ubuntu. I will send a PR to fix this (and maybe cleanup other problems), but unfortunately we do not have ARM32 machines we can use to test this. Would you be willing to test the changes? Or report if they do not work?

It works!! Thanks.

Thanks for testing.  The bug is not fixed until we merge those changes though.

Thanks for the bug report and confirming the fix worked for you.  The PR is merged (as you probably noticed).  It will be in the next release, due early in 2022-04.

Thanks for the bug report and confirming the fix worked for you. The PR is merged (as you probably noticed). It will be in the next release, due early in 2022-04.

Thank for fixing issue. :-)


Question: how to process a .wav or .mp3 directly?

Hey @xlab,
I was wondering whether that was possible to process a .wav or .mp3 directly using ProcessRaw ?
I'm not really an expert in that field and I do have an audio file ready to be processed but ProcessRaw requires a []int16  and I do not know how to convert accordingly.
Cheers
Quentin

Hi, it's better to start with a bit of theory there https://en.wikipedia.org/wiki/Audio_bit_depth
So []int16 is actually an array of 16-bit signed samples, 1 channel mono. You can parse header and read samples directly under some circumstances, see packages like https://github.com/cryptix/wav and https://github.com/verdverm/go-wav
Working with MP3 is a bit harder, it's a container, you'll need a frame parser for it https://github.com/tcolgate/mp3
Anyways, these are common problems and they have many solutions. Just keep in mind that ProcessRaw accepts 16-bit signed samples and you'll need set fullUtterance=true


Release Proposal v0.12.0

Blow isa proposal for release notes:
LocalStorage

#1033 (@SSmallMonster )
#1041 (@buffalo1024  )
#1047  (@Vacant2333 )
#1062  (@sun7927 )

LocalDiskManager

#1032  (@AmazingPangWei )
#1039 (@SSmallMonster  )
#1053  (@SSmallMonster )
#1057  (@SSmallMonster )
#1058  (@SSmallMonster )
*#1071  (@buffalo1024 )

Failover

#1008 (@sun7927 )
#1018  (@sun7927 )
#1023 (@sun7927 )
#1026 (@sun7927 )
#1060  (@sun7927 )

Auditor

#1056  (@sun7927 )

Other

Add more e2e tests  ( #1009 #1022 #1025 #1029 #1030 #1034 #1037 #1043 #1046 #1050@FloatXD )
Add more unit tests  ( #1010 @Vacant2333 )
Update Docs  (#1011 #1021 #1036 #1048 #1055@windsonsea  ）

Admission,Scheduler,Evictor,Exporter
N/A

LGTM

inprogress PR:

https://github.com/hwameistor/hwameistor/pull/981


Move popochiu settings to Project Settings

This MR moves settings currently defined in popochiu_settings.tres to the Popochiu tree under Godot's Project Settings.
Note that this is a draft, and should not be merged yet. This is my first contribution to the project, so wanted to open this early to get feedback as I go.
Closes https://github.com/mapedorr/popochiu/issues/26.

Hi @drbloop. First of all thanks for this PR and for contributing.
Can you please rename this PR following the title format: refs #<ISSUE-ID>: <description>? This makes it easier to navigate and less error-prone.
Thanks a lot! :)

This is ready for a first round of review.

@drbloop so far it looks good to me. Great work.
Please, convert this PR to draft until it is finished, or we may end up merging it by mistake.
Thanks

Before merging the PR we have to remove the Settings button in the footer of the Popochiu panel, or see if there is a way to use this button to open Popochiu' Settings section in the Project Settings.

Hi @drbloop ! Sorry for leaving this unattended for so long.
Are you still interested in continuing with the implementation of the change? If so, it might be better to move the changes to a new branch branching off develop (I can help you with that if you want). If you are no longer interested, would it be okay for me to take what you did as a starting point? My idea is to include this change in beta 3.

@mapedorr I guess you finished this task into another PR, right?
If so I think we can close this.


Run npm pkg fix on everything

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.49%. Comparing base (f26b5d6) to head (02c73a8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   98.49%   98.49%
=======================================
  Files           6        6
  Lines        1332     1332
=======================================
  Hits         1312     1312
  Misses         20       20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


migrating to Node 20

looks like a dup of https://github.com/projectatomic/ai-studio/issues/416 (or the opposite but https://github.com/projectatomic/ai-studio/issues/416 has content)

looks like a dup of #416 (or the opposite but #416 has content)

Weird there has been two issue opened, closing this one


Test pull request

Testing the pull request for various UIs.

This looks great!

Review status: 0 of 27 files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Review status: 0 of 27 files reviewed at latest revision, 2 unresolved discussions.

tensorflow/cc/BUILD, line 5 [r8] (raw file):
Added some comments!!!!!

tensorflow/tensorboard/.gitignore, line 18 [r8] (raw file):
Added some comments !!!!!!!!!!!!!!!!!

Comments from the review on Reviewable.io

Reviewed 5 of 6 files at r1, 6 of 6 files at r2, 2 of 3 files at r3, 2 of 2 files at r4, 9 of 10 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, 1 of 1 files at r8.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Added other some comments  !!


Issue with -v flag in running a container

Hi. I'm trying to do the following with Docker Quickstart terminal..  I get this error even though the path specified with -v flag is an unix path.
$ winpty docker run -it -v /data --name mycontainer busybox
invalid value "C:\\Program Files\\Git\\data" for flag -v: \Program Files\Git\data is not an absolute path See 'docker run --help'.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

@SurabhiBorgikar this is a duplicate of https://github.com/docker/docker/issues/12751 and https://github.com/docker/docker/issues/12590, and is caused by msys automatically converting paths to "windows" paths.
You can prevent this from happening by using a double slash at the start of the path, i.e. //data. see this comment; https://github.com/docker/docker/issues/12751#issuecomment-96288101
I'm ging to close this issue, but feel free to comment here after I've closed

Hi. Yes I've already seen those posts before posting mine. Even using double slash did not work for me. May be I should try using something else instead of Docker quickstart terminal for Volumes. Thanks!

@SurabhiBorgikar oh, that's unfortunate; I think I've seen using quotes ' worked in other cases.

This hack seems to work like a charm if you have downgraded to 1.9 from the AUFS issues in 1.9.1
docker create -v //c/Users/myuser:/myuser --name data hello-world
winpty docker run -it --rm --volumes-from data ubuntu


Various changes to StateChanges

Removes the redundant SetInputTexture StateChange, renames the SetInputTextureFromFBO to SetInputTexture, adds a new SetRenderBufferMask StateChange and fixes the remaining resizing problems.

This was supposed to be based on an earlier branch (Resizing Issues PR), and so only the last commit actually belongs to this Branch. Please ignore the other commits for now.
@Cervator This should fix every last one of the problems (as far as I know). Go ahead, and try to break it!
@emanuele3d Tagging for review!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Even in this new set of commits, only the 7cfe6fc commit is relevant, the other two are from a different branch. I'll squash all commits into one once the other PR gets merged.

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Uh oh, something went wrong with the build. Need to check on that

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

This PR has been broken down into smaller PRs, and so I'm closing this one.

Hooray Jenkins reported success with all tests good!

Closed, in favour of making 2 new PRs (and because of some rebasing issues).

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!


Well-founded recursion: Lean could guess the lexicographic order

This definition
def test : ∀ i j : Nat, Nat
  | 0, _ => 1
  | _, 0 => 1
  | i + 1, j + 1 => test i (j + 1) + test (i + 1) j

needs
termination_by _ i j => (i, j)

or
termination_by _ i j => i + j

to go through. It didn’t need that in Lean3 (and our friendly competitors don't need that annotation either, I believe).
It would be nice if Lean4 would be up to that.
Previous discussion:

https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Regression.20in.20equation.20compiler/near/400582161 by Bhavik Mehta

The original version in the Zulip thread showed up in porting the Exponential Ramsey project, in which I hit this when trying to define the Ramsey numbers! It also appears twice in mathlib, in Data/Nat/Choose/Basic: the definition of multichoose and the theorem multichoose_eq both gained a termination_by fix which weren't needed in Lean 3.

We could look into implementing what Isabelle did here: https://www21.in.tum.de/~krauss/papers/lexicographic-orders.pdf

That would be nice, but a simpler approach might just be to restore the old behaviour: build a PSigma of the arguments in the order they're given, and do lex on that.

Probably doing one and later the other is best.


Aeon Labs Garage Door Controller Gen5

I´m running Zwave2mqtt in a docker container, The latest working version for my barrier operator is container with zwavejs2mqtt 6.8.0 and Z-wave JS 9.0.6. All later versions do not have a working barrier operator for the Aeon Labs Garage Door Controller Gen5. Unfortunately I do not know if it´s the zwavejs2mqtt or Z-wave JS  that has the problem.
Kind regards
Z

Tried reinterview but it goes on forever. Goes fast with old version.
[Node 010] Error during node interview: subsystemType is not a SubsystemType (
ZW0322)
zwavejs_2022-11-24.log

cc @AlCalzone

Hy, I have also a problem with the module, the interview don't finish.
Thanks for your help

This should be fixed by https://github.com/zwave-js/node-zwave-js/pull/5465

Yes this works now. Many thanks!


Create Consumer Information Endpoint

User story

As a frontend-dev
I need an endpoint
So that I can retrieve all relevant information about a single consumer

Acceptance criteria
Endpoint provides all information listed below:

address: Address of this consumer
availablePermits: Number of available message permits for the consumer
getBytesOutCounter: Total bytes delivered to consumer (bytes)
getClientVersion: Client library version
getConnectedSince: Timestamp of connection
getConsumerName: Name of the consumer
getLastAckedTimestamp: Timestamp of the last acknowledged message
getLastConsumedTimestamp: Timestamp of last consumed message
getMessageOutConter: Total messages delivered to consumer (msg)
getUnackedMessages: Number of unacknowledged messages for the consumer, where an unacknowledged message is one that has been sent to the consumer but not yet acknowledged
isBlockedConsumerOnUnackedMsgs: Flag to verify if consumer is blocked due to reaching threshold of unacked messages

Here is a short documentation about all consumer information.
Definition of done (DoD)

Feature is done when the acceptance criteria are fullfiled
Feature is done when there are test where it is necessary and they pass
Feature is done when the linter passes
Feature is done when it is merged onto our main branch (after the code has been reviewed by at least one other person)
Feature is done when the code has been documentend or commented properly

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

Expert was not at the meeting, we will send a mail to him and then i will give you more detail about it. For now just start with those information. Adjusting the filtering process with some exrta attributes shouldnt be a big issue anyways.

Expert says, information is good for now. please do it like this!


[Bug]: Network module reporting wrong data

Checklist

[X] I have read the appropriate section in the contributing guidelines
[X] I believe this issue is a problem with polybar itself and not a misconfiguration on my part
[X] I have searched for other open and closed issues that may have already reported this problem
[X] I have checked the known issues page for this problem.
[X] I have followed the debugging guide to narrow down the problem to a minimal config.

Steps to reproduce
Run polybar the usual way with the network module enabled.
Minimal config
[module/network]
type = internal/network
interface = wlp4s0

interval = 1.0

format-connected = <label-connected>
format-connected-prefix = "󰤨 "
format-connected-prefix-foreground = ${colors.grey}

format-disconnected = <label-disconnected>
format-disconnected-prefix = "󰤭 "
format-disconnected-prefix-foreground = ${colors.red}

label-connected = %signal%%  %{F#808080}󰘡 %{F#EAEADD}%downspeed:8:10% %{F#808080}󰘣 %{F#EAEADD}%upspeed:8:10%%{F-}
label-disconnected = "disconnected"

Polybar log
No response
Expected behavior
The network module is not reporting the correct signal strewth of my WiFi connection.
Actual behavior
Here's a video showing a comparison between the output of Polybar's network module and i3status-rust: https://streamable.com/0iubor. i3status-rust is reporting the correct data that corresponds to the output of nmcli device wifi.
Window Manager and Version
i3 version 4.20.1
Linux Distribution
Manjaro <IP_ADDRESS>
Polybar version
polybar 3.6.2-34-g4961a7dc

Additional Context / Screenshots
No response

I don't think polybar reports wrong info. The signal percentage is calculated from the signal strength in (dBm). Different tools use different formulas to derive a percentage from the dBm value and thus may produce different percentage values.
See here for more info.
I'll mark this as a duplicate of #2179.


Charging Profiles: Daily planning shows always 24h in the chart + Cannot change the start date

Date can be changed now


Higher contrast for favicon

On Chrome the favicon lacks a bit of contrast to my taste. Maybe the black version would fit better here?

I would be fine to have either the white or black background.  @4mber can you take care of this and shoot me a PR with this issue tagged?  I can deploy on Monday should if you remind me.

Will do!

Deployed.


Change Collector module to Push data to TimeSeries DB like influx

Hi All,
My requirements are to push data into influx db rather than Hbase. Kindly let me know the best place to start with.
I would like to know few things in this regard
a) Does the Pinpoint license allows me to modify the Collector module ?
b) if there is a technical documentation on Collector module then please specify, as i have failed to find one.
suggestions/feedback are welcome :)

I perfer only push metrics data to influxdb . After all , influxdb can use grafana to display data chart.

thanks emeroad for responding back.. :)


Giving attribution for authors of PowerToys

As PowerToys helps bundle up a bunch of tools together, it is important that the creators don't get lost. Acknowledging people is important and the hard work they do.
As part of #569, i feel we should tweak the settings and add in attribution their setting page.

I think this could be an attribution section on Github versus in application.  Easier to update.  The app itself could have maybe at the bottom a link to this attribution page

with the new settings format, this should be added in as well.
-Authors

Author
URL

should this wait until we do the migration for the new UX for settings?  I think so.

This will be hardcoded, this is in progress


Cannot compile on 1.0.0-beta-.4

Hey.
I was trying to use your library and got a really nasty set of compile errors. For reference I'm running 1.0.0-beta-.4.
   Compiling aster v0.2.2
   Compiling quasi v0.2.0
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/quasi-0.2.0/src/lib.rs:99:58: 99:75 error: unresolved name `token::NtImplItem`
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/quasi-0.2.0/src/lib.rs:99         vec![ast::TtToken(self.span, token::Interpolated(token::NtImplItem(self.clone())))]
                                                                                ^~~~~~~~~~~~~~~~~
<std macros>:1:1: 4:58 note: in expansion of vec!
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/quasi-0.2.0/src/lib.rs:99:9: 99:92 note: expansion site
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/quasi-0.2.0/src/lib.rs:105:58: 105:76 error: unresolved name `token::NtTraitItem`
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/quasi-0.2.0/src/lib.rs:105         vec![ast::TtToken(self.span, token::Interpolated(token::NtTraitItem(self.clone())))]
                                                                                ^~~~~~~~~~~~~~~~~~
<std macros>:1:1: 4:58 note: in expansion of vec!
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/quasi-0.2.0/src/lib.rs:105:9: 105:93 note: expansion site
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/quasi-0.2.0/src/lib.rs:162:57: 162:69 error: unresolved name `token::NtArm`
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/quasi-0.2.0/src/lib.rs:162         vec![ast::TtToken(DUMMY_SP, token::Interpolated(token::NtArm(self.clone())))]
                                                                                ^~~~~~~~~~~~
<std macros>:1:1: 4:58 note: in expansion of vec!
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/quasi-0.2.0/src/lib.rs:162:9: 162:86 note: expansion site
error: aborting due to 3 previous errors
Build failed, waiting for other jobs to finish...
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/aster-0.2.2/src/lib.rs:1:1: 1:27 error: unstable feature
/home/test/.cargo/registry/src/github.com-1ecc6299db9ec823/aster-0.2.2/src/lib.rs:1 #![feature(rustc_private)]
                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~
note: this feature may not be used in the beta release channel
error: aborting due to previous error
Could not compile `quasi`.

To learn more, run the command again with --verbose.

I'm still pretty new to Rust, and im not exactly sure how to fix this in the interim. Can you help? Thanks!

I also found this error while trying to use serde/serde_macros for json serialization. Does it only support nightly build?

@piaoger Thanks for the pointer, I'll rustup the latest nightly. Is running off the latest nightly more common than the stable beta?

Yes quasi is nightly only but I'm hoping to get it beta compatible this week :)

@angrygoats: I would recommend first trying the beta channel before reaching for the nightlies, but for the short term quasi (and serde_macros) are still tied to some nightly libraries.

Quasi should now be usable with stable if you use syntex! Check out how quasi-tests is setup in order to make a crate that's compatible with both quasi_macros (for plugins on nightly rust) and quasi_codegen (for stable rust). I'm going to close this ticket now, so if you run into problems please open a new ticket.


Can't Open Colorbox From Within a bxSlider Slide

I have a slide within a bxSlider, that should trigger the opening of a colorbox slideshow. It opens a colorbox, but never loads the slideshow. here is call to the colorbox() within the bxSlider:
$('.isSlideshow').colorbox({rel:'slideGroup'});
Where the class "isSlideshow" is on the link within the bxSlider slide and of course the rel:'slideGroup' is on the unordered list containing the slides with the rel of slideGroup. Never loads the slides.

Wow, so easy! I just had to attach an event handler to the slide in the bxslider and using the on() method call .colorbox in a function like this:
$('.slide').on('click','a.isSlideshow', function() {
$('a.slideGroup').colorbox({rel:'slideGroup1', open:true});
});

👍

Jack,
Quick question regarding my use of the event handler. The way I called colorbox works great, but if I try to add an additional hyperlink in the caption for the slide in the same way, it creates a duplicate colorbox group and then the total number of slides in the colorbox is doubled. What is the proper way to make a second call to the same slideGroup? Thanks for any suggestions Jack.


Undelete records

What would be the proper way to handle a undelete request? Would it be a PATCH request that unsets the deleted_at timestamp?
This would be for models with soft deletes.

Hi! I think this is totally down to your application's logic - unsetting the deleted at timestamp via a patch request would definitely be one way of doing it.
I haven't implemented any generic way of doing this because it is very application-specific. For example, we have a production application where models are soft-deleted, but the client never knows this - i.e. when the client deletes a resource, the model is soft-deleted and never returned to the client again. The logic here would differ from an application where a client is allowed to both soft-delete and remove resources.
If there is a demand for a feature that supports handling soft-deleted models, I'd be open to adding it in. Generally my approach would be for a soft-delete to be done via the PATCH method (i.e. setting/unsetting the deleted timestamps via a PATCH request would toggle a resource's soft-deleted status, or using a pseudo property such as "archived") and then a DELETE request would hard delete a resource. To me this is the most semantic way to do it, because DELETE means DELETE - the resource should not exist (from the client's perspective) if the client has asked for it to be deleted. However my only concern with adding something in is this is certainly straying into application-specific logic.

In EloquentController::destroy(), we call $model->delete().
This can trigger either a soft or hard delete.  In both cases, we return 204.
If it was a soft delete, should we return 202 instead?
https://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.7

A successful response SHOULD be 200 (OK) if the response includes an entity describing the status, 202 (Accepted) if the action has not yet been enacted, or 204 (No Content) if the action has been enacted but the response does not include an entity.

After all, a soft delete means that we've accepted the deletion request, but it is not yet (completely) enacted?

Hey there.. quite an old issue, but i will provide some thoughts on this one..
From my perspective, you should always use DELETE /posts/1 in order to delete a model - it does not matter (from the client perspective) if this model is really deleted or just soft-deleted. Actually, it is best, if the client does not know. However, PATCHing the resource in order to "delete" it, feels kind of weird from a RESTful perspective.. At least that is my opinion...
Restoring a model, however, is tricky with just the regular HTTP verbs (GET / POST / PUT / PATCH / DELETE). In this case, i would argue for a PATCH request - but that is just my personal opinion..
In another application we added a DELETE /posts/1?force=true query param in order to apply a forced delete (i.e., no soft-delete). However, this query param is removed via a middleware from "normal" (non-admin) users..
Regarding the 202 / 204 discussion:
I would always argue, that a DELETE should return 204 (no content) - becaues it actually does not return a content - and the action has been executed. 202 (accepted) should be used for "long-running actions", e.g., preparing a web-service call to a 3rd-party service or complex calculations. In this case you may provide a location header to the client where you can add a custom URI.. This URI, in turn, may provide information regarding the progress of the execution or provide actual data (once the calculation is finished).
Hope this helps ;)

Yeah, great input.

From my perspective, you should always use DELETE /posts/1 in order to delete a model - it does not matter (from the client perspective) if this model is really deleted or just soft-deleted.

This is the key problem from my perspective. For me the thing that makes most sense is that if you do DELETE /posts/1 then subsequent calls to either GET /posts/1 or PATCH /posts/1 should return a 404. I.e. the resource from the client's perspective is deleted, even if that's actually soft-deleted in the database.
So if you are using soft-delete to allow a client to archive/restore resources, then DELETE should mean hard-delete and the soft deletion (archive/restore) should probably happen through the PATCH.
But if you you are using soft-delete to remove the resource from your API, the client cannot restore it, and it will never appear in the API again (e.g. in a relationship), then DELETE should do a soft-delete not a hard-delete.
This is what I mean by it depends on your application logic. In theory if we could find a neat way of doing it, then it would be good for the package to provide both approaches. The main thing to work out is how we would do allowing the client to do an archive/restore kind of operation.
Maybe the place to start is see if there's any APIs out there that do offer an archive/restore type function and see how they've implemented it from the client's perspective?

Yeah, that sounds similar to how I've split a production application into two APIs - one for general users, and one for admins.
The problem with all of this is it's not really for this package to provide that solution as it's so tied to the logic of a specific application.
I'll keep thinking about this but at most I think this package needs to provide options or guidance on different options, rather than a default solution.

what do you mean exactly with "guidance on different options"? Are we talking about the different "API Realms"?
How did you manage to solve this issue? Did you develop 2 separate APIs (applications) that are hosted on 2 different domains (or folders within the same domain)? Or was it one "large" application that had different route-groups?
All the best

Sorry, I mean guidance on different options for handling soft-delete.
In our solution we have one API at /data/users/* and one at /data/admins/*. That's one of the main reasons this package supports having multiple APIs. We built it as two separate APIs because it wasn't just the logic of access rights and what a client could do that was different between the two, but also schema for the resources in each API varied. I.e. the resources served in the admin API had more attributes and relationships in them exposing the secret information.
So effectively if their was a resource called posts a public version of it was accessible at /data/users/posts/1 whereas a secret version of it was accessible at /data/admins/posts/1.
It's not the only way of architecting a solution but that worked best for our use case.

Dear @lindyhopchris ,
yeah, that was my initial idea, that i may provide different API configurations, depending on the realm. So i may have one json-api-user and a json-api-manager and a json-api-admin configuration file each with different endpoints, right?!
All the best

This is potentially becoming an issue that I'm going to get a lot more questions about, so need to implement something for 1.0.
Basically we need:

Something on an adapter to make soft-deleted records appear in the API.
Something on the relationship objects to make soft-deleted records appear in that relationship.
Some docs explaining that whether or not you include soft-deleted records in your API what you need to consider and how to make soft-deleted records appear in your API if needed.

Optionally we could provide something on the adapter to restore a resource in a PATCH request.

Fyi I've put how we're planning to implement this in #250


add token ERC20 Address to AssetAmount

Description
Please explain the changes this PR addresses here.
Checklist

[ ] If this requires a documentation change, I have created a PR in moonbeam-docs repository.
[ ] If this requires it, I have updated the Readme
[ ] If necessary, I have updated the examples
[ ] I have verified if I need to create/update unit tests
[ ] I have verified if I need to create/update acceptance tests
[ ] If necessary, I have run acceptance tests on this branch in CI

@Rihyx I think we can close this. It's done in v3.


Rethink NotImplemented in ordered comparisons

Should return NotImplemented or raise TypeError?
See sec 2.6 and 4.11 of Python Distilled

done


Adding new document about how to migrate Osclass to docker infrastruc…

…ture with Docker Compose.

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "dry-run-test" git@github.com:XaviOutside/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

Thanks Gordon,
I’m already updated.
Best,
Xavi.

On May 21, 2015, at 11:44 PM, Gordon<EMAIL_ADDRESS>wrote:
Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "dry-run-test" git@github.com:XaviOutside/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f
This will update the existing PR, so DO NOT open a new one.
—
Reply to this email directly or view it on GitHub https://github.com/docker/docker/pull/13394#issuecomment-104429665.

mmm, i suspect this should go into the http://github.com/docker/compose repository documentation.
@bfirsh ?

ping @moxiegirl

@XaviOutside HI Xavier --- I see you made your contribution! Very cool, thanks for doing this. Hopefully you are enjoying Spain as it is warmer than San Francisco.  Maybe we will see you at the Docker Party next year in Spain?

I think this should go in https://github.com/docker/compose, as @SvenDowideit mentions.

@moxiegirl
Hi moxiegirl!
Sorry for the delay but I have moved to Berlin (June) and I have started a new job in a small startup. I have been disconnected of the world because I haven’t had enough time and a good internet connection too. Now, I’m in my new apartment with DSL, I will be able to review the different things that you have send to me.
I have seen that the next Dockercon is in Barcelona! Good news, I don’t know if I will be able to go but anyway, I’m very happy that Docker comes to BCN.
I’m working as a devops and I’m working with docker mainly. We are using dockerhub in order to store the images and I have more ideas to contribute.
Regards,
Xavier.

On Jun 13, 2015, at 3:32 PM, moxiegirl<EMAIL_ADDRESS>wrote:
@XaviOutside https://github.com/XaviOutside HI Xavier --- I see you made your contribution! Very cool, thanks for doing this. Hopefully you are enjoying Spain as it is warmer than San Francisco. Maybe we will see you at the Docker Party next year in Spain?
—
Reply to this email directly or view it on GitHub https://github.com/docker/docker/pull/13394#issuecomment-111710144.

Ok, I'm going to move this doc to https://github.com/docker/compose.

Thanks @XaviOutside! I see you created https://github.com/docker/compose/pull/1627 so I'll close this PR
(I hope you enjoy Berlin by the way, I love that city!)


Address any[] and never[] arrays in StrictNullChecksManipulator and NoImplicitAnyManipulator

In our implementation of StrictNullChecksManipulator, we fixed empty arrays (never[] type arrays) by giving them the type any[]. However, overall this was just a temporary fix, and we don't actually ever want to assign an any type. Because of this, look into different ways of avoiding this issue. Is there a way to infer the type of an array, similar to how we infer the types of scalars right now?

After looking into this issue, we've deemed that it's nearly impossible to determine the type of an array without hardcoding for specific cases, such as specific array methods (push) and countless other cases. Missing any case would be extremely dangerous, and as such we have decided not to pursue this.
Instead of adding the type any[], both StrictNullChecksManipulator and NoImplicitAnyManipulator now ignore empty arrays and outputs a message telling users that it is not able to infer the types of arrays. This fix was implemented in #38


How do parse all *.svg files in a directory recursively?

If I have the following structure:
/path/to/svg/
├── foo
│   ├── far
│   │   └── away.svg
│   ├── bar.svg
│   └── cafe.svg
└── car.svg

svgo -f /path/to/svg/ fixes only the car.svg
svgo -f /path/to/svg/* fixes all the files in foo directory but not car.svg and not the far folder

So the question is.. what's the best way to scan all the *.svg recursively in a folder?

In the spirit of Unix philosophy, I'd be inclined to propose using find for locating the files, and svgo for processing them. Something like find /path/to/svg/ -name *.svg -exec svgo {} \;.
That said, given that the -foption already exists, it could be argued that it makes sense to extend it to process folders recursively.

Yes that will work only in Unix systems..and if I want to use it inside the package.json as a script it won't fly on every platform.. the -f should be fixes to support all.
Or maybe even something like that

svgo /path/to/svg/**/*.svg would parse all the files recursively inside that match the *.svg extension.
svgo /path/to/svg/*.svg only in the root of that folder without going deeper and only the *.svg files.

No clue how the possibilities are with installed git-bash in windows, there are some linux-commands like grep and find available too. Should be possible to combine that but add another dependency ...
I know this is probably not the way to go but just thought about it.

We all know the workarounds guys... let's just fix it! The question was mostly on how to do it without workarounds and if not possible.. it's a feature request.

how is this related to svgo?

It is realted to svgo because svgo supports -f

so if you're motivated, extend this https://github.com/svg/svgo/blob/master/lib/svgo/coa.js#L49 with a -rf option (r for recursive) and paste the code above to get all .svg's

Thanks a lot @caub for the advice man.. I didn't know that I was aloud to make my own PRs..

you're very aloud to

Thanks again man..! I'll keep that in mind..

I would like to see this built-in to SVGO too, but in the mean-time, here's a workaround that runs SVGO in parallel:
find resources/icons -type f -name '*.svg' -print0 | xargs -0 -n 1 -P 6 $(NM)/svgo

Thanks for adding this feature. Could you tag this release please? @justrhysism

Actually the output is a little weird. It says

No SVG files have been found.

...even though it did find all my icons. I guess it didn't find any in the root dir.
node_modules/.bin/svgo -r resources/icons
Processing directory 'resources/icons':

Processing directory '/mnt/c/Users/Mark/PhpstormProjects/myproject/resources/icons/fa':

Processing directory '/mnt/c/Users/Mark/PhpstormProjects/myproject/resources/icons/ion':

Processing directory '/mnt/c/Users/Mark/PhpstormProjects/myproject/resources/icons/misc':

No SVG files have been found.
asterisk.svg:
Done in 14 ms!
0.497 KiB - 0% = 0.497 KiB

android-calendar.svg:
Done in 6 ms!
0.316 KiB - 0% = 0.316 KiB

account.svg:
Done in 9 ms!
0.948 KiB - 0% = 0.948 KiB

...

When will this be released?

Agree. This would be a much appreciated feature. 🙂

Is this dead? Will this ever be released?

I did not find it written elsewhere, but today it is simple, also on windows
svgo -o /PATH/TO/OUTPUT/DIR/ -f /PATH/TO/INTPUT/DIR/ -i *.svg
will also create the output if it did not exits.

This is now part of the "with files" documentation in the https://github.com/svg/svgo#usage section.

-f and -r both still don't work with paths like packages/**/static/next/icons
Possible workaround: svgo $(echo packages/**/static/next/icons) -r

Those aren't paths, those are globs - many tools don't support globs.


Update musializer.c : Add newline at end of errors

The lack of newline sometime messes up the prompt, and also it looks better.

@AmalIrfan thanks!


[Code app]: Parent folder is not expanded when add new nested folder

EPAM AI DIAL chat version
0.20.0
How to reproduce
Steps:

open Add Code app form
select any folder as source
add new folder in code editor
hover over new folder and click on context menu option "Add new folder"

Actual result
Arrow for expand added to the parent folder -> ok
Folder is not expanded and nested folder is not visible -> bug
https://github.com/user-attachments/assets/bddba78c-2b18-4745-bbf1-1e6ef75ceefb
Expected result
Parent folder should be expanded to show added nested folder
Confidential information

[X] I confirm that do not share any confidential information

issue is reproducible if add more that one folder to parent folder:

create parent folder
add sub-folder 1 -> parent folder is expanded -> ok
add sub-folder 2 to the same parent -> parent folder is collapse, sub-folder 2 is not visible -> bug
https://github.com/user-attachments/assets/61c6fc84-a2d5-443b-99e4-6df335577e8b

verified on staging successfully


Error: unable to build authorizer for Resource Manager API: could not configure AzureCli Authorizer

Hi,
I don't know If this is really a bug or a misconfiguration right now.
Terragrunt version
terragrunt version v0.43.2
Explanation

I have the following monorepo architecture for my Azure modules, here an Azure Data Factory and an Azure Resource Group.

├── az_adf
│   ├── main.tf
│   ├── outputs.tf
│   ├── README.md
│   ├── variables.tf
│   └── version.tf
├── az_rg
│   ├── main.tf
│   ├── outputs.tf
│   ├── README.md
│   ├── variables.tf
│   └── version.tf
├── pipeline.yaml
└── README.md

and I'm using the module az_rg to create the resource group in my az_adf
data "azurerm_client_config" "current" {}

data "azurerm_subscription" "primary" {}

locals {
  common_tags = {
    owner           = "daa team"
    managed_by      = "Terraform"
    resource        = "adf"
    location        = var.location
    user_or_project = var.user_or_project
    environment     = var.environment
  }
}

module "az_rg" {
  source = "../az_rg"

  user_or_project = var.user_or_project
  environment     = var.environment
}

resource "azurerm_data_factory" "current" {
  name                = "adf-${var.user_or_project}-${var.location}-${var.environment}"
  location            = module.az_rg.location
  resource_group_name = module.az_rg.rg_name

  tags = local.common_tags
}

The version.tf files are the same in both directories.
terraform {
  required_version = ">=1.4.6"

  required_providers {
    azurerm = {
      source  = "hashicorp/azurerm"
      version = "~>3.59.0"
    }
  }
}

provider "azurerm" {
  features {}
}

My live infrastructure is located in another repository and managed by Terragrunt like this.

.
├── deployment-pipeline
├── dev
│   ├── adf_mkl
│   │   └── terragrunt.hcl
│   └── terragrunt.hcl
├── mgmt
├── README.md
└── staging

with dev/terragrunt.hcl looking likt that
locals {
  # Parse the file path we're in to read the env name: e.g., env
  # will be "dev" in the dev folder, "staging" in the staging folder,
  # etc.
  parsed       = regex(".*/s/(?P<env>.*?)/.*", "${get_terragrunt_dir()}/")
  env          = local.parsed.env
  secrets_vars = yamldecode(sops_decrypt_file("${get_terragrunt_dir()}/../secrets.dev.yaml"))
}

# Configure azure as a backend
remote_state {
  backend = "azurerm"
  config = {
    resource_group_name  = "RG-EU-NONPROD-TF-STATE"
    storage_account_name = "statfstatetestp50"
    container_name       = "${local.env}"
    key                  = "${path_relative_to_include()}/terraform.tfstate"

    client_id       = local.secrets_vars.ARM_CLIENT_ID
    client_secret   = local.secrets_vars.ARM_CLIENT_SECRET
    subscription_id = local.secrets_vars.ARM_SUBSCRIPTION_ID
    tenant_id       = local.secrets_vars.ARM_TENANT_ID
  }
  generate = {
    path      = "backend.tf"
    if_exists = "overwrite_terragrunt"
  }
}

generate "version" {
  path      = "versions_override.tf"
  if_exists = "overwrite_terragrunt"
  contents  = <<EOF
        terraform {
        required_version = ">=1.4.6"

        required_providers {
            azurerm = {
            source  = "hashicorp/azurerm"
            version = "~>3.59.0"
                }
              }
            }

        provider "azurerm" {
            features {}

            client_id       = "${local.secrets_vars.ARM_CLIENT_ID}"
            client_secret   = "${local.secrets_vars.ARM_CLIENT_SECRET}"
            subscription_id = "${local.secrets_vars.ARM_SUBSCRIPTION_ID}"
            tenant_id       = "${local.secrets_vars.ARM_TENANT_ID}"
        }
  EOF
}

and dev/adf_mkl/terragrunt.hcl looking like that.
include "root" {
  path = find_in_parent_folders()
}

locals {
  devops_pat = get_env("TF_VAR_PAT")
}

terraform {
  source = "git::https://${local.devops_pat}@dev.azure.com/MYORG/PROJECT/_git/infrastructure-modules//az_adf?ref=main"
}

inputs = {
  user_or_project = "adf"
  environment     = "dev"
}

What happened ?
When I tried to launch a terragrunt plan in dev/adf_mkl I have the following error in my pipeline.
data.azurerm_subscription.primary: Read complete after 0s [id=/subscriptions/7b34aa28-b315-41c8-9a1f-3ce5d17df71d]
╷
│ Error: unable to build authorizer for Resource Manager API: could not configure AzureCli Authorizer: could not parse Azure CLI version: launching Azure CLI: exec: "az": executable file not found in $PATH
│
│   with module.az_rg.provider["registry.terraform.io/hashicorp/azurerm"],
│   on ../az_rg/version.tf line 12, in provider "azurerm":
│   12: provider "azurerm" {
│
╵

I thought every submodule called would inherit from the versions_override.tf generated by terragrunt, but it doesn't seem to be the case. Is there a way to generate versions_override.tf in every submodules ? Or am I missing something ?

Hi,
looking to error message launching Azure CLI: exec: "az": executable file not found in $PATH , looks like the az binary is in in $PATH


Animations are not exported by GLTF2Export

Feature request

Link to forum discussion about the feature:
https://forum.babylonjs.com/t/animations-lost-when-exported-with-gltf2export-glbasync/4460
Feature description:

I get models from BJS github, or oher model archive
then import into this PG and exported it with the code. (Then put it into a public github repository to import below again)
Then imported to another PG, or an app with BJS scene which is on my localhost, but animations are gone, no Animation Groups section in Scene Explorer or visible animation.
Also when I download and import the original github models to my BSJ scene they also work.
Something happens when I run export methods.

Acording to recent conversation in forum in above link exporting skins is not implemented yet.

Additional links that could help implementing the feature:

thanks a lot for this request. @Drigax will look at it (but not now as he already has a lot to deal with exporters :))
Feel free to help if you want

thanks. I would love to. What kind of task is at hand? Can I getr some leads while I go into codebase to look around?

This is the right place

any news?

Unfortunately not any so far. Only if I had the time these recently. :|

I started by creating this test harness so I can quickly evaluate glTF sample models:
https://playground.babylonjs.com/#T087A8#1
Testing this asset import->export->import round trip with AnimatedCube, I can see that our node animation export works fine. That's somewhat of a relief, as I'm not too worried about glTF animation accessor and sampler being properly setup.
Looking back at the forum post, I can see that we're testing against alien from our meshes library, which also includes Morph target and skeletal animation. I'll update my PG to use this asset instead, as its pretty comprehensive as far as export capabilities go.

Alien test bench has been completed. Going to close this issue to roll into #5100


[HOLD for payment 2023-10-27] [$250] Migrate index.js to function component

Class Component Migration
Filenames

[ ] src/components/EmojiPicker/EmojiPickerMenu/index.js

type: React.Component
has state values: true
has refs: true
has context: false
lifecycle methods: componentDidMount,componentWillUnmount

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01eb40815378adee79
Upwork Job ID:<PHONE_NUMBER>262638592
Last Price Increase: 2023-10-06

I'd like to work on this issue

I'd love to work on this.

I'd like to work on this issue

I will refactor this component like following:

Determine which logics can be separated out of EmojiPickerMenu component into separate components
Determine which logics could be refactored out of EmojiPickerMenu into separate customs hooks. (This is done only to separate logics which are very closely related into that separate custom hook.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0130db910fd00b9f05

How do I know the issue is still open?

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link<EMAIL_ADDRESS>

Proposal
Please re-state the problem that we are trying to solve in this issue.
this component  is class based
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
we should migrate to functional components.
What alternative solutions did you explore? (Optional)

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01ca3117d2b055a0eb

Proposal
Please re-state the problem that we are trying to solve in this issue
Migrate index.js to function component
What is the root cause of that problem?
index.js is a class component extends React.Component
What changes do you think we should make in order to solve the problem?

Replace state with useState hook
Replace componentDidMount, componentDidUpdate & componentWillUnmount with useEffect hook
Replace refs with useRef
Remove this keyword from file.

What alternative solutions did you explore? (Optional)
Update .js to .tsx

@ashuvssut I like your proposal, but it's doing too much.
❌  Refactoring into separate components
No need to do this. We are just focused on the conversion to a function component
❌ Refactoring into Custom Hooks
Sounds like a premature optimization.
❌  Use TypeScript for props types and function parameter type(Also this renames file extension:-*.js into *.tsx)
We have a separate migration happening related to TS so this is more than we are asking for. Do not do it.
The rest sounds ok!

@Santhosh-Sellavel Please request via NewDot manual requests for the Reviewer role ($250)

I ended up reviewing this one. But could use your help on the PR Review.

The PR is ready

Hi @Santhosh-Sellavel
I havent received my payment for this contribution. Who should I reach out to?
Also, I saw in upwork that I haven't been hired yet for the job

Hi @Santhosh-Sellavel @marcaaron
I havent received my payment for this contribution. Who should I reach out to?
Also, I saw in upwork that I haven't been hired yet for the job
I have a fully verified upwork account

@marcaaron please assign a BZ here, thanks!

@johncschuster @marcaaron any update on the payment issue?

@johncschuster seems like the Job has expired

@johncschuster Bump for the above, also please leave a payment summary message!

Thanks for the bump on the expired job! I'll get a manual one spun up.

@ashuvssut can you please comment on the issue above so I can assign it to you? That should create the Upwork job.

Payment Summary:
@ashuvssut requires payment (will be paid via Upwork here) - $250
@Santhosh-Sellavel does not require payment (Eligible for Manual Requests) - $250


Branch 193119953

Manually resolved
tensorflow/contrib/data/python/kernel_tests/sequence_dataset_op_test.py
tensorflow/contrib/data/python/ops/batching.py
tensorflow/contrib/metrics/python/ops/metric_ops.py
tensorflow/contrib/tensorrt/convert/convert_nodes.cc
tensorflow/core/common_runtime/process_util.cc
tensorflow/core/kernels/cwise_op_clip.cc
tensorflow/core/kernels/cwise_op_clip.h
tensorflow/core/kernels/cwise_op_clip_gpu.cu.cc
tensorflow/core/kernels/maxpooling_op.cc
tensorflow/python/framework/dtypes.py
tensorflow/python/framework/tensor_shape_test.py
tensorflow/python/kernel_tests/clip_ops_test.py
tensorflow/python/ops/clip_ops.py
tensorflow/python/util/tf_inspect.py
tensorflow/tools/api/generator/create_python_api.py
tensorflow/tools/docs/parser.py
tensorflow/tools/docs/parser_test.py

cc: @jsimsa

We decided against it because it's hard to make a reversible
transformation, and they are not harmful either. In a perfect world,
everybody would make a GitHub issue to link, but it's pretty far down the
list of important things to do.

Seems that both py presubmit failed on same test case, need some check and probably rollback.

Internal continuous builds were all green, and so are github builds. I wonder if I mess something up during merge.

 Maybe one of the underlying ops it use is causing issues? Any suggestion?

Turns out to be issue with merge indeed! The change in dtypes.py from https://github.com/tensorflow/tensorflow/pull/18481/files got override. Will fix.

Nice debugging!


Refactor Baseline documents to be within ScubaGear module

💡 Summary
ScubaGear is currently deployed as a zipped package with manual instructions on installation and usage. To migrate to delivery/deployment via a package repository all baseline documents should be included in publishing.
Motivation and context
This would be useful because it supports publishing ScubaGear to a public repository #645
Implementation notes
Reference #94, #645, #677 for context and additional information
-ScubaGear functinality has access to packaged baseline documents (e.g., Import-SecureBaseline)
-Allow users to export any secure baseline
Acceptance criteria
How do we know when this work is done?

[ ] ScubaGear executes properly when installed from a package repository
[ ]  ScubaGear executes properly when imported directly from source code baseline
[ ] User can export any/all baseline documents from ScubaGear when installed froma repository

Only concern with this is discoverability. Having the baselines folder be in the root directory makes it easier for new viewers to find our baseline documents.
My hope is that the PowerShell equivalent of a package_data field lets us grab folder and files outside of the ScubaGear.psd1 manifest directory. Which would make this issue an easy fix.

I share the concern.  This is partially why I added a requirement to be able to export the baseline documents from the installed module.  We can also talk about a "build" of the module instead of restructuring the project heirarchy.  My iniital thought is the closer it is to actual publishing structure the better - but, we should look at all options.


Bug: Region and Start URL not read from sso-session configuration

After an update to version 0.20.0 the following AWS Profile file leads to an error, when using assume command:
[sso-session sso]
sso_start_url=https://myapp.awsapps.com/start
sso_region=eu-central-1
sso_registration_scopes=sso:account:access

[default]
sso_session=sso

[profile superaccount]
sso_session=sso
sso_account_id=00101010101001
sso_role_name=MyRole
region=eu-central-1
output=json
cli_pager=cat

This is the error:
~ assume superaccount
[✘] operation error SSO OIDC: RegisterClient, failed to resolve service endpoint, an AWS region is required, but was not found

If I add sso_start_url and sso_region to the profile superaccount, then the I get no error.
Assumption:
sso_start_url and sso_region are not read from sso-session configuration.

@kirnberger1980 Thank you for reporting this issue! v0.20.1 includes https://github.com/common-fate/granted/pull/544 which should resolve this issue. Please let me know if it works for you after you do an update.

@shwethaumashanker , thanks for the quick reply. We updated to 0.20.2. The update fixed the issue. Thanks a lot.
Kind regards,
Marcell


[dattri.metrics] Add brittleness test

Description
1. Motivation and Context
This PR is to add brittleness test in metrics. Reference paper. This version does not use interpolate.
2. Summary of the change

Add brittleness.py under metrics. (After review, we may make it wrapped as a function in metric.py.
Add mnist_lr_brittleness.py in experiment folder to show how to use this metric to evaluate Influence Function.

3. What tests have been added/updated for the change?
N/A:

And you may add brittleness here: https://github.com/TRAIS-Lab/dattri?tab=readme-ov-file#metrics-supported

And you may add brittleness here: https://github.com/TRAIS-Lab/dattri?tab=readme-ov-file#metrics-supported

Made the PR in https://github.com/TRAIS-Lab/dattri/pull/121

And you may add brittleness here: https://github.com/TRAIS-Lab/dattri?tab=readme-ov-file#metrics-supported

Done in this PR


Link to discord in the website

Depends on #7

Discord didn't end up getting enough interest from users so for now we won't do this.


Plugin 'Poetry' (version '1.1.5-212') is not compatible with the current version of the IDE, because it requires build 212.* or older but the current build is IU-213.5744.223

Plugin 'Poetry' (version '1.1.5-212') is not compatible with the current version of the IDE, because it requires build 212.* or older but the current build is IU-213.5744.223

Poetry is now part of pycharm thanks to @koxudaxi.
See: https://youtrack.jetbrains.com/issue/PY-30702#focus=Comments-27-5313948.0-0

@sleshJdev
Yes, This plugin has been merged into Pycharm source code 😄
Python plugin supports poetry integration natively.
We don't need this plugin on 2021.3 or later Jetbrains IDEs.

Thanks, good news!


Jordan/1869 network page

Closes #1869
Description:

implemented PageNetwork

❤ Thank you!

[x] Added entries in CHANGELOG.md with issue # and GitHub username
[x] Reviewed Files changed in the github PR explorer

A screenshot of the page would have been nice.


Meetup: what would a sample test look like?

Here is a sample entry in the canonical data for the meetup problem.
{
  "uuid": "b08a051a-2c80-445b-9b0e-524171a166d1",
  "description": "when third Wednesday is some day in the middle of the third week",
  "property": "meetup",
  "input": {
    "year": 2013,
    "month": 7,
    "week": "third",
    "dayofweek": "Wednesday"
  },
  "expected": "2013-07-17"
}

The corresponding test for this data in Ruby is:
  def test_when_third_wednesday_is_some_day_in_the_middle_of_the_third_week
    meetup = Meetup.new(7, 2013).day(:wednesday, :third)
    assert_equal Date.parse("2013-07-17"), meetup
  end

In C# it's like this:
    public void Third_wednesday_of_july_2013()
    {
        var sut = new Meetup(7, 2013);
        var expected = new DateTime(2013, 7, 17);
        Assert.Equal(expected, sut.Day(DayOfWeek.Wednesday, Schedule.Third));
    }

The exercise doesn't mandate any particular implementation.
What would the test look like in Chapel if the solution is idiomatic?
If I have an idea what it needs to look like I can generate the exercise stub.

o-ho, sorry I thought I had replied this. After having looked at the exercise description and JSON data, I think there are two approaches for this exercise

meetup returns an object of time date. In this case the test could be something like

test.assertEqual(meetup(2013, 8, "teenth", "Monday"), new date(2013, 8, 19));

have meetup return a string. In which case the test would be

test.assertEqual(meetup(2013, 8, "teenth", "Monday"), "2013-8-19");

I don't have an opinion on which one is better. The first case is more explicit and automatically guides the student to use the Time module, which has useful out-of-the-box functionalities to solve the problem.
The second method is less explicit. using Time is probably still the best idea, but in principle the student is free to implement everything themselves.  The extra step date -> string is fairly trivial so it does not increase complexity itself.
Since this is a medium/hard exercise, how would you feel about going with option two? We can have as hint to check out the Time module. Once we have concepts we could link both this and ´gigasecondto thedatetime` concept and  have gigasecond as prerequisite.

I think I would prefer to use the Time option, in the sense that reaching for a time object when dealing with datetimes is what I feel like people should do, and so the obfuscation (if one can say that) of comparing against a string seems like it's not helping use the language in an idiomatic way, if that makes sense.
I need to double-check the bit about prerequisites. I think only concept exercises are meant to be prerequisites for practice exercises (but could be wrong; we've changed how all the pieces fit together over the years).

sorry I forgot to answer (again). I think it makes sense, let's go with the explicit Time module. Do you have all pieces to generate the stub?

I think only concept exercises are meant to be prerequisites for practice exercises

This is also my understanding, but I don't think we need to worry about this, we can add in instructions.append.md a note as did in the other exercises

Do you have all pieces to generate the stub?

I think I have what I need. I'll generate it, and if something looks off, holler and I can tweak and regenerate.


Update framebuffer on draw

The shapes example crashed for me on start, because of indexing outside the framebuffer. This fixes it.

Thanks!


Support M1 machines

Any timeline for this? I'm a nix and emacs newbie, but maybe I can help either way

I don't own an M1 machine yet, I'm afraid. I believe GitHub aren't providing hosts for Apple silicon just yet, which I would have to rely on without owning one (not going to try even going near cross compilation for this 😅).
So, until I own an M1 machine, I likely won't be adding support for it.
In theory, it should be fairly trivial to add - I just don't want to blindly add what I think should work without being able to build and test :)

When I still had my M1 machine (had to exchange it for an intel for work), I was using this repo's overlay in my nix-darwin aarch64-darwin configuration (following the instructions in https://github.com/LnL7/nix-darwin/issues/334). I didn't realize that this might not be supposed to work, but I suspect it ... just did?

@antifuchs If it worked without any changes from the flake, your probably built and ran an x86_64 binary on your M1 via rosetta. It's pretty impressive to me how transparent that emulation can be.
Anyways, I opened up a pull request #5 to allow native builds for M1. The resulting binary works on my new Macbook Pro 2021, but other tests would be appreciated. Maybe @choco wants to help?

Hey guys, since GitHub doesn't provide arm64 macOS build machines right now I'm just using my own overlay (on top of emacs-overlay) which looks like this:
emacs = (prev.emacsGit.override { withXwidgets = true; nativeComp = true; }).overrideAttrs (old: {
  buildInputs = old.buildInputs ++ [ prev.darwin.apple_sdk.frameworks.WebKit ];
  patches = old.patches ++ [
    ../patches/emacs-no-titlebar.patch
    ../patches/emacs-fix-window-role.patch
    ../patches/emacs-fix-thin-smoothing.patch
    ../patches/emacs-no-frame-refocus.patch
    ../patches/emacs-system-appearance.patch
  ];
  postInstall = old.postInstall + ''
   cp ${../patches/emacs-rounded-square-icon.icns} $out/Applications/Emacs.app/Contents/Resources/Emacs.icns
  '';
});

It's basically latest emacs git version with xwidgets and gcc native compilation, plus a bunch of patches (mostly from the https://github.com/d12frosted/homebrew-emacs-plus repo) plus a fix for the font smoothing setting that is broken since macOS big sur. I also change the icon to another that I like better.
For the vterm module you can then wrap the above in (emacsPackagesFor emacs) or let emacs just install it themselves (both worked for me)

Considering this fixed for now with @phaer's contributions in #5 🙇


Fixed issue where text is truncated when client height equals max height

Fixes #46

@qsjchen I'll review this tomorrow. THANKS!

@qsjchen https://github.com/dollarshaveclub/shave/pull/34 Note the hanging chad

What you mentioned there seems like a separate issue that will be there regardless if you merge it in or not though. Why not fix this issue first?

I agree with @qsjchen, the comments in #34 don't seem entirely relevant to what this PR is trying to address. That "hanging chad" is there regardless, but even so the ellipses is still within the element's defined width. Its not like its bleeding out the edge of the element. That would be a bigger issue.

@qsjchen @ibarsi thanks for your comments.
Your points have been read.
https://github.com/dollarshaveclub/shave/issues/46
^ Your issues will be addressed here.


Add blog review guideline to Reviewing PRs page

This PR amends the Reviewing PRs page with a blog section under the Reviewing checklist header
This PR replaces PR  48180
Credit to @chris-short for commits in the original PR 48180 that are not reflected in this PR

/area contributor-comms

To keep the commit history tidy:
/retitle Add blog review guideline to Reviewing PRs page

The build did work, (i had to trigger it manually after it timed out on the first build after @dipesh-rawat's edit).
Deploy preview

I pushed a squashed version of this with just 1 commit.

Hold on, I already approved this.
/lgtm cancel

Someone else can LGTM it though.

Also signposting to https://github.com/kubernetes/website/pull/48585#issuecomment-2452662060


make clear in readme if the the tool can work on Windows

I don't have a Windows machine at hand, could you try to npm install wikibase-cli@latest and tell me how it goes?

I've just been trying to install this on Windows but I've ran into similar issues as those reported in #72
Install with npm seemed to go smoothly - as far as I can tell, I'm not an expert - but running the "wd summary Q5" command from my command line returns an error - "Sh is not a recognizable command...", which seems to be similar to what others have reported.

@VojtechDostal do you get the same error with wb summary Q5 --instance https://www.wikidata.org?

@VojtechDostal do you get the same error with wb summary Q5 --instance https://www.wikidata.org?

That does work! What have  missed or forgotten to configure? :)

wd is just a convenience executable that calls wb, but in its current implementation, it explicitly requires to do that in a sh environment. Maybe removing that first line would let the choice of the shell type to the executing context: could you try to remove that line in your local installation and see if wd summary Q5 works?

After removing the 1st line from "wd" file, I restarted the command line window and tried "wd summary Q5" again but the problem remains the same

I rewrote wd as a node script in 2a4eaa0, published in v15.16.1: can you upgrade and retry wd summary Q5?

I rewrote wd as a node script in 2a4eaa0, published in v15.16.1: can you upgrade and retry wd summary Q5?

I upgraded and tried again, attaching results:

So there seems to be a different error this time.

new attempt :D 38a9ea8 published in v15.16.3

Sorry for taking a bit longer :)
This seemed to have worked. After update, I tried the following command:
wd update-claim Q4466817$72dfdfa0-4c71-7806-6d8c-dc7b316148a6 "Thuja occidentalis ʽSmaragd’"
--> https://www.wikidata.org/w/index.php?title=Q4466817&diff=prev&oldid=1573856361
Thanks! 👍

Regarding the original issue, I added a mention that Windows should be part of the supported system: a1b780a


bootstrap

Bug report

What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?

Other relevant information:
webpack version:
Node.js version:
Operating System:
Additional tools:

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.
Please help us help you by recreating the issue using one of our templates.


Priority<PHONE_NUMBER>

On Android, I can't directly see the cpu set(255) and thread priority information(120).

No idea what this issue means. Can you please provide some more information on what you're trying to do and what's not working?

perfetto

old chrome://tracing/

Priority
2147483647
prio:<PHONE_NUMBER>12,
It looks different. The data(255 112) we need cannot be directly displayed in perfetto.

Naively, that looks like a bug in chrome://tracing.
Priority information in Perfetto and chrome://tracing both come from the sched_switch event.
The ftrace format file for sched_switch is given by https://cs.android.com/android/platform/superproject/main/+/main:external/perfetto/src/traced/probes/ftrace/test/data/synthetic/events/sched/sched_switch/format;l=1?q=sched_switch f:Perfetto f:format&sq=
255300087112 is much much bigger than the max value which can be held inside an int<PHONE_NUMBER>).

Another potential option is that there is some other ftrace event which is feeding priority information to chrome://tracing but is an event we don't take advantage of. This will need some investigation on your side to see if this is the case.

binder:5315_6-23932   (   5315) [000] ...1.  1474.636987: binder_set_priority: proc=5315 thread=23932 old=112 => new=120 desired=120
NTQM0_14567_pre-14567   (  14159) [000] d..2.  1468.681445: sched_waking: comm=Detect_15664 pid=15664 prio=120 target_cpu=001
NTQM0_14567_pre-14567   (  14159) [000] d..2.  1468.681504: sched_switch: prev_comm=NTQM0_14567_pre prev_pid=14567 prev_prio=000255001047110 prev_state=S ==> next_comm=Detect_15664 next_pid=15664 next_prio=000255301047120
I think it's the sched_switch that's at work.

This information is very important, I have to switch from perfetto to trace to check the cpu and priority.

I think it's the sched_switch that's at work.

That's only possible if you have a custom sched_switch event in your kernel. The upstream kernel only has an int field for priority not a long
Note that Perfetto reads the binary ftrace format not the textual format so if you are hacking something in the kernel to tweak the priority in the text output Perfetto does not see that
This is not a solvable problem from our side alone: the reading of the binary pipe is fundamental to how ftrace works and we don't receive the data from the kernel to get the full priority.


FileBasedSource: throw IOException instead of Exception where possible

Replace "throws Exception" with "throws IOException" from APIs
that already only throw IOException. Only private or final methods,
so that we don't affect overriding classes.
Refactor one function to catch, handle, and rethrow
(Interrupted|Execution)Exception.

This makes it easier to write a new FileBasedSource, because the
FilebasedReader functions are only registered to throw IOException.

R: @jkff @tgroh
Rebased to fix merge conflicts. Note that you may want to review the individual commits: the entire diff will show both the functional change and cleanups. I tried to separate any cleanup (log messages, preconditions) into separate patches.

LGTM


PVS6 System - no total solar across panels value

I'm trying to use HA's energy panel and using this integration (installed yesterday) I don't see a total solar production value which I believe I'm supposed to use:

Is this a bug - or be design? I'm going to take a look at making a custom sensor to sum all these sensor.lifetiem_power_x of my panels up perhaps -> or I can look into a PR if this is something to be added...

I think I have an idea where this might be coming from - some of the older examples online have type E panels and I think I have G Panels which have potentially different fields....

So my installation doesn't have the field: p_mpptsum_kw available anywhere ... so I'll either have to sum them up manually or come up with some other option...
For context my stuff looks like:
{
                  "ISDETAIL": true,
                  "SERIAL":   "E00122116029005",
                  "TYPE":     "SOLARBRIDGE",
                  "STATE":    "working",
                  "STATEDESCR":     "Working",
                  "MODEL":    "AC_Module_Type_G",
                  "DESCR":    "Inverter E00122116029005",
                  "DEVICE_TYPE":    "Inverter",
                  "hw_version":     "4400",
                  "interface":      "mime",
                  "module_serial":  "",
                  "PANEL":    "SPR-A415-G-AC",
                  "slave":    0,
                  "SWVER":    "4.21.3",
                  "PORT":     "",
                  "MOD_SN":   "",
                  "NMPLT_SKU":      "",
                  "DATATIME": "2022,01,24,21,35,51",
                  "ltea_3phsum_kwh":      "96.1859",
                  "p_3phsum_kw":    "0.2097",
                  "vln_3phavg_v":   "247.73",
                  "i_3phsum_a":     "0.84",
                  "p_mppt1_kw":     "0.2133",
                  "v_mppt1_v":      "40.42",
                  "i_mppt1_a":      "5.27",
                  "t_htsnk_degc":   "21",
                  "freq_hz":  "60.01",
                  "stat_ind": "0",
                  "origin":   "data_logger",
                  "OPERATION":      "noop",
                  "CURTIME":  "2022,01,24,21,38,17"
            }

The value of
net_ltea_3phsum_kwh on the production sensor is the correct value which was:
sensor.lifetime_power -> a very bad name to figure out :)


fix phoneNumber key name for opt_in_phone_number request

Mistakenly had up-cased key name for the request, should be lowercase per the docs.
http://docs.aws.amazon.com/sns/latest/api/API_OptInPhoneNumber.html

Thanks!


votca_compare: move to python3

Part of https://github.com/votca/csg/issues/341

We should remove the "import print from future" stuff to


Gin improvements + zerolog

Split gorillaz and httpz into separate middleware.
Improvements to Gin middleware:

Add Check implementation for authorizing using policy-rebac.
Add support for reading identities from gin.Context values instead of the context.Context of the underlying http.Request.

Add logging in all middleware (using zerolog.Ctx logger)

We should update makefile lint to something like:
go work edit -json | jq -r '.Use[].DiskPath'  | xargs -I{} .ext/bin/golangci-lint run {}/... -c .golangci.yaml


docs: fix readme word error

What type of PR is this?
docs:
What this PR does / why we need it (en: English/zh: Chinese):
en:  Fix word errors in zh README
zh:  修复 中文版 README 中的单词错误

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

How to solve the run failed check. I can't find any button to rerun @zhquzzuli

How to solve the run failed check. I can't find any button to rerun @zhquzzuli

We will fix the CI issue in annother PR. It's OK for your PR.


SAK-40810 - Rubrics doesn't start due to Spring dependencies upgrade

@bgarciaentornos can you try in your dev environment too?

It's working for me, let's merge this soon!

It's working for me, let's merge this soon!

It's working for me, let's merge this soon!


Migrate to new configuration asciidoc macro and build plugin 5.4.5

closes #174

It failed because of the rate limit. I restarted the job.
Still, I'm uncertain whether it's worth to target a branch with Micronaut 3.x. Why not targeting master? /cc @sdelamo

It failed because of the rate limit. I restarted the job.
Still, I'm uncertain whether it's worth to target a branch with Micronaut 3.x. Why not targeting master? /cc @sdelamo

We are updating the docs in every MN 3.x branches and then merging up. We should not abandon MN 3.x branches.


[CALCITE-5156] Support implicit type cast for IN Sub-query

2811

 Quality gate: Passed
 Everything looks good
Details


Timing of games is correct?

It says that 5k games with average of 32 seconds, so around ~5k*32/(60^2) = 44hrs total computation right?
But it was run with 120+ machines concurrently, so more or less 44 / 120 = 0.36hrs in total?
But it took 4+ hours!
Is there anything wrong here?

See #66 related


disable maintenance threads on Coordinators

Scope & Purpose
Turn off maintenance threads on coordinators, as they are not needed there.
Additionally, mark all maintenance config options as DB-Server-only.
This also disables all maintenace-related metrics on coordinator, so they will not be exported by /_admin/metrics anymore.

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This change is already covered by existing tests, such as all cluster DDL tests.
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11137/

Tests blue


Calculate unique reference to labels without hash

Hi, I've been using this module in combination with my own prometheus-log-client module, to produce a metrics endpoint for an application from its existing logs.
We hit a problem during our load tests where our metric exporter was using a huge amount of CPU. I traced the slowdown back to this module, and specifically to the sha1 hash of the labels that is done every time a metric is updated. I tried changing it to use md5 method available on object-hash, but it didn't offer any improvement.
This pull request removes the object-hash dependency and uses simple string concatenation to work out a unique reference for the labels. We have seen a significant performance increase using this approach. I don't believe there is any necessity of having such a strong hash function, as all we really care about here is uniqueness.
Under heavy load our application can produce (per instance) in the region of 3-4k metric updates over a 10 second period. We are running these on AWS m2.large instances. Before the change we saw CPU around 50%, and eventual death of the process as it ran out of memory. With this patch, we see CPU hovering around 1% and no trouble keeping up.
Just to be clear, it's only the first use of sha1 that causes the slowdown. The keys method done later isn't a problem due to the caching. But I thought I might as well get rid of the dependency.
Cheers.

Looks like the tests pass and at a glace doesn't look like anything will break, I want to do a few more tests before I merge just to be certain. I'll try and do that tonight.

Closing because I've implemented this in version 4.0.0 that is now available at the @next tag. It needs testing.
I'm pushing the code up here shortly with an updated readme.