Enable extra kernel options to support Istio dns proxy feature

Is your feature request related to a problem? Please describe.
Istio DNS proxy fails with the current kernel build, Linux/x86 <IP_ADDRESS>. There's a discussion on this issue.
Describe the solution you'd like
Enable these two kernel option:

CONFIG_NF_CONNTRACK_ZONES=y
CONFIG_NETFILTER_XT_TARGET_CT=y

Describe alternatives you've considered
Use native Linux
Additional context
Istio version: 1.12.0

@kelsey-steele I see that you were the last person to update the config-wsl kernel build options in the WSL repo. I would greatly appreciate you taking a look at this.
How do you feel about enabling CONFIG_NF_CONNTRACK_ZONES and CONFIG_NETFILTER_XT_TARGET_CT, as doing so will unblock running Kubernetes clusters (with service meshes like Istio) on WSL2.
(Read more about the Istio issue here: https://github.com/istio/istio/issues/37885)

PS: I tried to raise a PR, but the microsoft/WSL2-Linux-Kernel repo is limited to collaborators only.

@thesuperzapper  hello o/
Happy to check into this. Give me time to do a little research and testing, then I'll come back here with an update. I'll do my best to provide an update here before I update the kernel next (~end of month).
I appreciate you taking the time on the PR and sorry the WSL2 repo isn't open to taking that at this time.

Quick swing by to note this isn't forgotten. I have these configs added to a kernel in testing now. I should have a proper update here next week.

@thesuperzapper sorry on such a delay for this task! This config change is part of a larger WSL update where WSL will support loadable modules. This will be the config changes in the upcoming kernel:
NF_CONNTRACK_ZONES=y
NETFILTER_XT_TARGET_CT=m
The next kernel release with the updated config file con be found in the WSL2-Linux-Kernel repo: https://github.com/microsoft/WSL2-Linux-Kernel/releases/tag/linux-msft-wsl-<IP_ADDRESS>
The loadable modules rely on a WSL update that is coming soon; this will first be seen as a pre-release. I'm keeping an eye out for that pre-release and plan to come back and update here when that happens. :)
Thank you for the patience!

@thesuperzapper this update can be found in the latest WSL pre-release: https://github.com/microsoft/WSL/releases/tag/2.1.1
I'm going to close this issue now, though please report and ping me if any problems are found. Thank you! :)


fix(multiple): update to angular v13.0.1 to emit proper partial compilation output

Updates to Angular v13.0.1 which fixes the partial compilation output
for forwardRef usages in queries. The fixed partial compilation output
will ensure that Angular CDK/Material works with JIT linking at runtime,
as done in e.g. Jest.
Fix upstream in framework: https://github.com/angular/angular/pull/44113.
We will add some testing for the JIT linker to the angular/components
repository with: https://github.com/angular/components/pull/23882. That should help ensuring JIT linking does
not regress.
Fixes #23907.

 Most likely in the future we should have another scope like package-output or something around that. Some build changes are actually relevant for consumers of the library.

so is this released or not ? We are still seing this error in 13.0.2 for our own components.

We stopped having issues with this release and the compiler 13.0.1 release.  Did you also update your @angular/compiler dependency and rebuild your library?


Ctrl+Drag to rotate collides with Ctrl+Click to add point in Path2D

Ctrl+Drag to rotate node,
Ctrl+Click to add point in Path2D.
They collide with each other, so when you want to rotate path2d node you add a new point instead, which is quite annoying.

Is this still valid in the current master branch?

It looks like it was fixed.

Great, thanks!


Difficulties building

I tried 2 different ways to build, and both failed. What am I doing wrong?
On Ubuntu 20.04, x86_64.
Try 1
$ cargo build
...
error[E0713]: borrow may still be in use when destructor runs
--> /home/plafer/.cargo/registry/src/github.com-1ecc6299db9ec823/url-1.7.0/src/form_urlencoded.rs:261:40
|
259 | impl<'a> Target for ::UrlQuery<'a> {
    |      -- lifetime `'a` defined here
260 |     fn as_mut_string(&mut self) -> &mut String { &mut self.url.serialization }
261 |     fn finish(self) -> &'a mut ::Url { self.url }
      |                                        ^^^^^^^^ - here, drop of `self` needs exclusive access to `*self.url`, because the type `UrlQuery<'_>` implements the `Drop` trait
  |                                        |
  |                                        returning this value requires that `*self.url` is borrowed for `'a`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0713`.
error: could not compile `url`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

Try 2
$ ./scripts/local-build.sh x86_64-unknown-linux-gnu amd64
...
error: failed to parse lock file at: /work/Cargo.lock

Caused by:
invalid serialized PackageId for key `package.dependencies`

Running cargo update updated the culprit: url from 1.7.0 to 1.7.2.

@plafer I had the same issue on Alpine. Installing dbus helped me.
I found this Issue https://github.com/greshake/i3status-rust/issues/194 so maybe that helps you.

All of the previous solutions looked relevant at different points. Conclusion: must run cargo update before building and also have a recent version of cargo in the system that is running the build. I had 1.74 on my machine but scripts/local-build.sh runs an old Docker image with cargo 0.24. There is no release of the image in the last 6 years but it was possible to enter the image and (since regular rustup update did not affect the cargo version there) reinstall Rust.
docker run -it -v $PWD:/work majorz/rust-amd64:rust-1.24.1 bash
rustup self uninstall
curl https://sh.rustup.rs/ -sSf | sh
cargo --version # cargo 1.74.1 (ecb9851af 2023-10-18).
rustup target add x86_64-unknown-linux-gnu
cargo build --release --target=/x86_64-unknown-linux-gnu

local-build.sh does not seem worth much as-is. For anyone seeing this, I recommend sticking to basic cargo build and trying the last two lines on your host to build the desired target.

I have made myself this build script for cross building for arm64 on Debian Bullseye. It doesn't use docker. Perhaps it is of use to someone.
https://github.com/hupster/wifi-connect-build


Translate migrations page

Source: https://github.com/laravel/docs/blob/5.2/migrations.md

working on this.

Added via b2264f6ca4252fa4538727a6975698c3b64d7f95


Facebook login fails with  KeyError: 'access_token'

This is the stack trace:
Internal Server Error: /complete/facebook/
Traceback (most recent call last):
  File "/home/ec2-user/project/venv/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/ec2-user/project/venv/local/lib/python2.7/site-packages/django/views/decorators/csrf.py", line 57, in wrapped_view
    return view_func(*args, **kwargs)
  File "/home/ec2-user/project/venv/local/lib/python2.7/site-packages/social/apps/django_app/utils.py", line 52, in wrapper
    return func(request, backend, *args, **kwargs)
  File "/home/ec2-user/project/venv/local/lib/python2.7/site-packages/social/apps/django_app/views.py", line 20, in complete
    redirect_name=REDIRECT_FIELD_NAME, *args, **kwargs)
  File "/home/ec2-user/project/venv/local/lib/python2.7/site-packages/social/actions.py", line 43, in do_complete
    user = backend.complete(user=user, *args, **kwargs)
  File "/home/ec2-user/project/venv/local/lib/python2.7/site-packages/social/backends/base.py", line 40, in complete
    return self.auth_complete(*args, **kwargs)
  File "/home/ec2-user/project/venv/local/lib/python2.7/site-packages/social/backends/facebook.py", line 71, in auth_complete
    access_token = response['access_token']
KeyError: 'access_token'

Python social auth: 0.2.1

Facebook app: v2.2

Since: March 28, 2017 (as v2.2 was deprecated on March 27). Updated the Facebook App to latest, but the error persists.

+1

+1

Does the latest python-social-auth work? (0.3.6)

Try python-social-auth==0.2.21

I was unable to upgrade to latest. However, upgrading to 0.2.19 worked and also solved this issue.


FirebaseUser#getToken method is deprecated

Method getToken(boolean) is deprecated (link). Please add FirebaseUser#getIdToken method.

Added in <IP_ADDRESS> release.


[3.x] Possible regression in update/refresh event handlers

References

https://github.com/awcodes/filament-tiptap-editor/pull/129
https://github.com/awcodes/filament-tiptap-editor/pull/135

Demo
https://github.com/awcodes/filament-tiptap-editor/assets/7805679/98ef6f95-759c-4f55-9367-5edf5b540ce6

what does your $dispatch() look like in you're x-on:click

@awcodes The method is triggered from the Livewire component with $this->dispatch('refresh-tiptap-editors'). I think the issue comes from Livewire 3 request batching. The event seems to be called before @entangle has a chance to run.


external assets can now be updated from zipped updates. #36

getPathToLocalUpdateFile now sets the path of the localUpdate file to the parent of the target directory, if the update is a zip file.
applyUpdate in applyUpdate.go now applies zipped updates by renaming the old folder to {folderName}.old and extracting into {folderName]
added a sample for zipped updates

Codecov Report

Merging #51 (704e8ce) into main (3ef7eea) will increase coverage by 0.52%.
The diff coverage is 26.31%.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   28.00%   28.52%   +0.52%
==========================================
  Files           6        6
  Lines         300      319      +19
==========================================
+ Hits           84       91       +7
- Misses        211      223      +12
  Partials        5        5

Impacted Files
Coverage Δ

updater/applyUpdate.go
0.00% <0.00%> (ø)

updater/checkForUpdates.go
32.94% <0.00%> (ø)

updater/update.go
0.00% <0.00%> (ø)

updater/fileHandling.go
71.42% <62.50%> (+10.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef7eea...704e8ce. Read the comment docs.


[Identity] Fix browser bundling for Azure Developer CLI credential

Packages impacted by this PR
@azure/identity
Issues associated with this PR
N/A
Describe the problem that is addressed by this PR
The browser bundle includes NodeJS's child_process which is incorrect.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A
Are there test cases added in this PR? (If not, why?)
N/A
Provide a list of related PRs (if any)
N/A
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.

Closing in favor of https://github.com/Azure/azure-sdk-for-js/pull/27097

Hi, I am currently running into this issue. When will this patch go out?


Visual Studio's destribution doesn't update

I am using a vcpkg distribution from Visual Studio (the Microsoft.VisualStudio.Component.Vcpkg component), however, I noticed that it didn't update since the last release (as at the end of December), while I am opening this issue two weeks later from the moment when it was actually released. This caused that some ports don't work properly.
Could you please clarify me how does Visual Studio updates their vcpkg redist?
Note: I know that it usually downloads the registry from GIt, but I am asking about the vcpkg executable itself and the scripts included.

This may be helpful to you https://devblogs.microsoft.com/cppblog/vcpkg-is-now-included-with-visual-studio/#using-the-visual-studio-copy-of-vcpkg.


The Maven settings file scripts should allow more configuration

The following values may need to be configured:

Release site profile name
Development site profile name

Move them to variables with default values, allowing them to be overriden.

Also, allow disabling these profiles, to use a more manual deployment approach.


Add line context option to audit --display-results

This will make it so that we could more easily add e.g. --line-excludes, to improve accuracy.

We did this in https://github.com/Yelp/detect-secrets/commit/139c64ab0edffebfaadb421aa2fbf5ec42d80615


Question about the term "hibernating" on the loading screen after clicking Hibernate

On a Windows computer, if you click Hibernate from the power option menu, the system goes into a loading screen showing "Hibernating". I doubt if this is correct:

because when you see the loading screen, the computer has not yet entered hibernation. When I see "Hibernating", I would consider this computer is already hibernating right now, which is not true.
In addition, if the process is described as "Hibernating", and how you describe the status when the computer is actually hibernating with one word? Please kindly answer my question. Thank you in advance!

See the picture here:
https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcSFCYWp3LJrLGXOj5M-4F2cQRLzLax_gNKUojjQQleV_zO1lNvTk7Fn3fCUlXABosaxCIg&usqp=CAU

Hi @wayneko , this sounds like a question for the product team. I would recommend reaching out to the Windows team to see if they have more detailed information about this process (or if their terminologist does). Thanks!


fix: Fixed build issues

I was trying to run the monaco example. I ran into a couple of issues. This PR addresses them. Have also attached screenshots of error that I had enocuntered.

@acao Please take a look when you find some time. Thanks :)

@anoopmd thanks for addressing this!
i wonder if this could be solved by adding the webpack monaco middleware package to the example devDependencies
i think this happened when i removed examples from the workspace
are you running yarn inside the example first before running yarn start?

@anoopmd I resolved this with #1696, thanks for the heads up!


Revert electron-updater to 6.3.0 (Linux AppImage updater fix)

Pins the electron-updater version to 6.3.0, reverting #4093.
This fixes the electron-updater issue that showed up in 0.24.3. But the root cause is still TBD. A new follow up ticket to #4474 will be created to address and get back to latest.

I wouldnt mind keeping this pinned until post v1. That's some pretty time burning stuff here.

Agreed. Will close #4474 and we can figure out the priority of #4505 separately. Thank you!


feature flag doc for pluralization needs to be updated

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
No response
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
7.6.25
What operating system are you using?
Windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
no
Amplify Categories
api
Amplify Commands
init
Describe the bug
Currently, the Amplify feature flag doc provides the improvepluralization with a camel case improvePluralization. needs to be updated with the correct syntax.
https://docs.amplify.aws/cli/reference/feature-flags/#improvePluralization

reference: #10009

Expected behavior
set improvePluralization to improvepluralization
Reproduction steps
none
GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

@ykethan the flags are converted to lowercase when the file is loaded, so this isn't a documentation issue.

Notes for docs update: should we perhaps list feature flags by name and show the value we'll see in cli.json as it appears?

Improve Pluralization improvepluralization

NOTE: add callout to docs that feature flags are case-insensitive https://docs.amplify.aws/cli/reference/feature-flags/#feature-flags

Closing as PR has been merged.


chore: add new reviewer to codeowners (8294)

Hey, I just made a Pull Request!
This is a very late follow up to issue #8294 which requested reviewers on certain plugins. Also added an entry for cost-insights-* since there is now a cost-insights-common package.  @jhaals asked me back in Dec about this, and I'm just getting around to it now :(
Signed-off-by: Andrew Thauer<EMAIL_ADDRESS>:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Thank you for contributing during Hacktoberfest 🍂! You can claim the Backstage Hacktoberfest Holopin at https://bck.st/hacktoberfest-holopin 🙌🏻


State Retry-After headers will be added by default for rate-limit and quota policies

Currently the document mentions that user can specify retry-after-header-name for rate-limit policies.
The attribute is optional, therefore making it sound like if not specified there will be no information in the response indicating how many seconds left before client retry is allowed.
Instead, the current behavior is Retry-After header is added by default, and the header name is replaced with the specified one if exists.
For quota policies, there is no such attribute option. However these policies also return Retry-After header with seconds left.
[REQUEST]

Modify the document to clearly state Retry-After header is added by default when rate-limit/quota policies are used.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 248a0753-0fa7-1cc0-d13a-d378ab182e95
Version Independent ID: 7efa247a-7184-6e7f-c1f5-3ff2531df357
Content: Azure API Management access restriction policies
Content Source: articles/api-management/api-management-access-restriction-policies.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

@taiyokato - Thanks for contacting us. This is a helpful observation and I agree it's worth documenting. I'll add it in the near future. cc/ @VitaliyKurokhtin


Remove dask-kubernetes config

@TomAugspurger , I believe we can now fully remove dask-kubernetes config from the images since this config is now taken care of in the dask-gateway helm chart, correct?
https://github.com/pangeo-data/pangeo-docker-images/blob/e3fd4ae4a797a78072b403815791b0dda5318066/base-image/dask_config.yml#L27-L51

The question here is where images in this repo should be solely intended to run on Pangeo JupyterHubs or also potentially used in other settings (xref https://github.com/pangeo-data/pangeo-docker-images/issues/112)
For example, you might want to run one of these docker images locally without dask as described in the readme:
Or you might want to run a single-user deployment of the dask helm chart (https://github.com/dask/helm-chart), in which case maybe it's helpful to keep  this config file in but remove the jupyterhub environment variables {JUPYTERHUB_USER}? Thoughts @TomAugspurger ?

I'm not sure what's best here. I've always found including the Dask configs
here a bit strange, since

They can be difficult to debug (what values they're setting, where
they're coming from)
They feel like they're making application-specific choices (number of
threads per worker) in a base image

So perhaps I'm arguing for removing them and documenting how they should be
used at the application level? I'm not really sure.
On Fri, Aug 28, 2020 at 5:59 PM Scott Henderson<EMAIL_ADDRESS>wrote:

The question here is where images in this repo should be solely intended
to run on Pangeo JupyterHubs or also potentially used in other settings
(xref #112
https://github.com/pangeo-data/pangeo-docker-images/issues/112)
For example, you might want to run one of these docker images locally
without dask as described in the readme:
Or you might want to run a single-user deployment of the dask helm chart (
https://github.com/dask/helm-chart), in which case maybe it's helpful to
keep this config file in but remove the jupyterhub environment variables
{JUPYTERHUB_USER}? Thoughts @TomAugspurger
https://github.com/TomAugspurger ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pangeo-data/pangeo-docker-images/issues/94#issuecomment-683181152,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKAOITVM2WVYXKAWSUWN33SDAZFFANCNFSM4OU4RWLQ
.


compressing checks into commands

@kcwinner - Removing the concept of a check in the exec2 connector and just adding flags on the commands to run as checks. Also pushing the interval down to the individual command.

Looks good to me. I like that you changed some variable names!


[Feature Request] Integrate AutoGate Function

Add AutoGate Function in this mod.

This might already fixed by https://www.nexusmods.com/stardewvalley/mods/3109
No need to add in this mod.


fix(versions): update Activiti/activiti-cloud-example-chart versions into master

UpdateBot pushed helm dependency: application to: 0.0.193

UpdateBot commands:
updatebot push-version --kind helm application 0.0.193


visual_tracking benchmark: fix URI of camera/display images

Fix the image URI sent to the robot window: in python 3 base64.b64encode creates a  bytes literal object that converted to string has the format b'<value>'.
The additional b and quotes was making the URI invalid.

:+1:


Support ESM-style "imports" field aliases in package.json

Clear and concise description of the problem
As of v14, Node.js now supports defining aliases for ESM imports in the packages.json through the "imports" field. Vite supports rollup-style aliases.
It would be nice if Vite was capable out of the box of reading the "imports" field and translating it correctly to rollup aliases.
Suggested solution
As a proof of concept, I have implemented a version that uses rollup's customResolver feature and works as long as no conditional imports are used. It turned out to be surprisingly simple:
import path from 'path'
import fs from 'fs'
import { defineConfig } from 'vite'
import { findUpSync } from 'find-up'

const pkg = findUpSync('package.json', { cwd: process.cwd() })
const { imports = {} } = JSON.parse(fs.readFileSync(pkg, 'utf8'))

export default defineConfig({
  // ...
  resolve: {
    alias: [
      {
        // Use a custom rollup resolver to emulate ESM-style imports
        // mappings in vite, as read from `package.json` above:
        find: /^#/,
        replacement: '#',
        customResolver(id) {
          for (const [find, replacement] of Object.entries(imports)) {
            const { match, capture } = matchIdentifier(id, find)
            if (match) {
              const replacementPath = path.resolve(replacement)
              id = capture
                ? replacementPath.replace('*', capture)
                : replacementPath
            }
          }
          return id
        }
      }
    ]
  }
})

function matchIdentifier(id, pattern) {
  const regexp = new RegExp(`^${pattern.replace('*', '(.*)')}$`)
  const match = id.match(regexp)
  return {
    match: !!match,
    capture: match?.[1]
  }
}

This works for my code-base with the following imports map:
  "imports": {
    "#config": "./src/config/index.js",
    "#app": "./src/server/app.js",
    "#models": "./src/server/models/index.js",
    "#models/*": "./src/server/models/*.js",
    "#controllers": "./src/server/controllers/index.js",
    "#controllers/*": "./src/server/controllers/*.js",
    "#services": "./src/server/services/index.js",
    "#services/*": "./src/server/services/*.js",
    "#errors": "./src/server/errors/index.js",
    "#utils": "./src/server/utils/index.js",
    "#utils/*": "./src/server/utils/*.js",
    "#features/*": "./src/server/features/*.js",
    "#admin/schema": "./src/admin/schema/index.js",
    "#admin/*": "./src/admin/*.js",
    "#test/*": "./test/*.js"
  }

It shouldn't be too hard to expand this to also support conditional imports.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Subpath imports are supported by Webpack and esbuild. I think it should also be supported by Vite. I'm gonna woking on this.

Has it been resolved?
When building a project which contains<EMAIL_ADDRESS>it throws an error:
[vite]: Rollup failed to resolve import "#ansi-styles" from "node_modules/chalk/source/index.js".
This is most likely unintended because it can break your application at runtime.
...

package.json in<EMAIL_ADDRESS>{
	"name": "chalk",
	"version": "5.0.0",
	"description": "Terminal string styling done right",
	"license": "MIT",
	"repository": "chalk/chalk",
	"funding": "https://github.com/chalk/chalk?sponsor=1",
	"type": "module",
	"exports": "./source/index.js",
	"imports": {
		"#ansi-styles": "./source/vendor/ansi-styles/index.js",
		"#supports-color": {
			"node": "./source/vendor/supports-color/index.js",
			"default": "./source/vendor/supports-color/browser.js"
		}
	},
	"types": "./source/index.d.ts",
	"engines": {
		"node": "^12.17.0 || ^14.13 || >=16.0.0"
	},
	"scripts": {
		"test": "xo && c8 ava && tsd",
		"bench": "matcha benchmark.js"
	},
	"files": [
		"source",
		"!source/index.test-d.ts"
	],
	"keywords": [
		"color",
		"colour",
		"colors",
		"terminal",
		"console",
		"cli",
		"string",
		"ansi",
		"style",
		"styles",
		"tty",
		"formatting",
		"rgb",
		"256",
		"shell",
		"xterm",
		"log",
		"logging",
		"command-line",
		"text"
	],
	"devDependencies": {
		"@types/node": "^16.11.10",
		"ava": "^3.15.0",
		"c8": "^7.10.0",
		"color-convert": "^2.0.1",
		"execa": "^6.0.0",
		"log-update": "^5.0.0",
		"matcha": "^0.7.0",
		"tsd": "^0.19.0",
		"xo": "^0.47.0",
		"yoctodelay": "^2.0.0"
	},
	"xo": {
		"rules": {
			"unicorn/prefer-string-slice": "off"
		}
	},
	"c8": {
		"reporter": [
			"text",
			"lcov"
		],
		"exclude": [
			"source/vendor"
		]
	}
}

Can we get an update on this? I was surprised to find out that vite was the only one of the main bundlers that didn't support this feature when making our reference toolkit. There is a PR that has gone with no reviews for about 6 months now.
https://github.com/vitejs/vite/pull/7770

[vite]: Rollup failed to resolve import "#ansi-styles" from "node_modules/chalk/source/index.js".
This is most likely unintended because it can break your application at runtime.
...

If the error is only from rollup (while building), for now you can use @rollup/plugin-node-resolve which supports conditional exports / imports. Here's @alienzhou's repo forked to show that working:
https://stackblitz.com/edit/vitejs-vite-k1bhgi?file=vite.config.ts&terminal=dev. Since it might break other things you might want to narrow down which modules are included

At least for building with rollup this seems to be fixed on their side and supported. When running vitest however - which seems to use whatever vite is using during its own runtime https://github.com/vitest-dev/vitest/issues/1365 - it's still throwing an error.


vpl-gpu-rt: Set platforms to x86_64-linux only

The upstream README notes:

Operating System:

Linux x86-64 fully supported
Linux x86 only build

But the SSE4 optimizations in the ipp library depend on x86_64 specific assembly.
Any platform except for x86_64 seems to be broken here.
Closes #359086
@evanrichter do you agree here?
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

I can't wait for mergebot to be fully operational 😭


BUG: LDAP Auth fails  to AD --v0.29.3

Argument 1 passed to BookStack\Auth\Access\LdapService::validateUserCredentials() must implement interface Illuminate\Contracts\Auth\Authenticatable, null given, called in
bookstack\app\Auth\Access\Guards\LdapSessionGuard.php on line 78

Hi @mikebohlen,
Do you still get this issue? When exactly does this issue occur? And detail on how to replicate would be much appreciated.

Anytime anyone tries to sign on.  I have tried this with AD and a *STD x.500 LDAP both secured\unsecured  same issue, just fyi, I adjusted the search strings etc to match the LDAP server I was trying to auth. to, same issue each time with same error.

Hi @mikebohlen I'll try to handle LDAP queries for a bit here. Can you send some logs from your LDAP server, or share your .env LDAP configuration (sanitized?)

Since the last comment on this issue is relatively old I'm going to close this. If the issue remains and is something you still require to be fixed please open a new issue, referencing this one.


Git Remote URL Unclear

The section 'Push to Azure' from Git refers to the "the URL of the Git remote that you saved from Create a web app (section).". However, the 'Create a web app section' says nothing about saving the URL of a Git remote. It is therefore totally unclear to me what value should be used to replace the placeholder text in the Git command to create a remote.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1588bff1-8730-051c-bef6-219c40b25fc4
Version Independent ID: d95c8cb0-f3fa-c861-1962-09c5b029b554
Content: Create a PHP web app in Azure
Content Source: articles/app-service/app-service-web-get-started-php.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin;cfowler

@bogan Thank you for pointing this out. We have gone ahead and added clarity to the doc. This should be viewable within 24 hours.
In the meantime, when you run the below cmdlet, the output should have the Git Remote URL in the first 10 lines of the output.
az webapp create --resource-group myResourceGroup --plan myAppServicePlan --name <app_name> --runtime "PHP|7.0" --deployment-local-git
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


flake8-isort

Add flake8-isort as part of CI for import grouping / sorting validation

LGTM
We'll want to test this config against a few projects and see how far off it is.


removed condition to check for subcommand being undefined in case of …

…workspace run

Sweet. Same as the other. LGTM, lets merge next week.


Repo rename error

Describe the bug
Failed to validate before saving repo name. If user didn't enter new name then blank space is saved as a new name.
To Reproduce
Steps to reproduce the behavior:

Go to 'Settings -> Saved repos'
Click on 'Edit button'
Save without entering new name.
See error (blank space in repo name column)

Expected behavior
Validate whether the name is provided or not
Screenshots

Desktop (please complete the following information):

OS : Windows
Browser : Chrome
Version : v2.0.1

Issue Type

mark with [x] to select the check box

[X] UI Issue
[ ] Performance Issue
[ ] Feature Breaking Issue
[ ] Security Issue

Severity

mark with [x] to select the check box

[ ] Critical (The application crashes / breaks completely)
[ ] High (Blocks you from performing a critical operation)
[X] Moderate (Bearable or Manageable issue)
[ ] Low (Something is not right, but the impact is minimal)

@Nageswari-droid bug fix has been delivered. Re-test and close the issue

@Nageswari-droid bug fix has been delivered. Re-test and close the issue


Hubot behind a proxy v.2

Hi i have a problem, yesterday i was trying to deploy hubot with HipChat adapter, on centos server with proxy :(.
I know this problem was few times in Issues but none of the solutions didn't work for me.
I cant ever deploy it, when i trying i have this statements:
<EMAIL_ADDRESS>HUBOT_HIPCHAT_PASSWORD="password" HUBOT_HIPCHAT_XMPP_DOMAIN="chat.hipchat.com" HUBOT_LOG_LEVEL="debug" bin/hubot -a hipchat > /tmp/log.txt

[hubot@sql2 AI]$ cat /tmp/log.txt
<EMAIL_ADDRESS>/opt/AI
+¦¦<EMAIL_ADDRESS>extraneous
L¦¦<EMAIL_ADDRESS>extraneous

[Thu Jan 07 2016 17:04:11 GMT+0100 (CET)] DEBUG Loading adapter hipchat
[Thu Jan 07 2016 17:04:11 GMT+0100 (CET)] DEBUG HipChat adapter options: {"jid":"1234321@chat.hipchat.com","password":"password","token":null,"rooms":"All","rooms_blacklist":"","rooms_join_public":true,"host":null,"bosh":{"url":null},"autojoin":true,"xmppDomain":"chat.hipchat.com","reconnect":true}
[Thu Jan 07 2016 17:04:11 GMT+0100 (CET)] INFO Connecting HipChat adapter...

I dont know docker very well, maybe this could solved my problem?
Please help

Check out https://github.com/github/hubot/pull/1092/files for some updated documentation. It's possible that it's going to be specific ot the hipchat adapter though.

Hey @CezaryRynkowski, I'm having the same problem... like exactly. I'm deploying to an OpenStack node with CentOS, using Terraform and Chef, behind a proxy.... and it's kicking my butt.
Did pickles link help? Were you able to solve your issue?

I think the problem here is that you are trying to connect prior to script loading (the documentation only addresses HTTP connections after scripts have loaded and only those using robot.http). Without programmatic launching or hand-modifying robot.coffee/the hipchat adapter, there isn't an easy way to do this in code. I'm not sure, but there might be a way to do this at the OS level (proxychains comes to mind).

That's exactly the issue @michaelansel

This solved my problem

@CezaryRynkowski How did that solve your problem?  I followed the example here:
https://github.com/github/hubot/pull/1092/files
but the xmpp adapter doesn't seem to be using the proxy.


Pull Token request

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Please read the SPL-token README, and ensure your SPL-token info uses the correct Uniswap format.

Please read the SPL-token README, and ensure your SPL-token info uses the correct Uniswap format.


Restrict modification of fields that should not be modifiable with API

Is your feature request related to a problem? Please describe.
If we create a model with ARC's UserModifiableEntitiy or BaseEntity. I am able to update fields/columns which should not be updated from API.
Example: createdOn, createdBy, modifiedOn, modifiedBy, deletedOn, deletedBy
Right now, there's no safe guard for modification, if I make an API call with the above fields in request body, then those are getting updated in DB. So, any authenticated user can write any data on above fields like different user ids in createdBy, modifiedBy, deletedBy or different time(even past date/time) in createdOn, modifiedOn and deletedOn
Describe the solution you'd like
Fields like createdOn, createdBy, modifiedOn, modifiedBy, deletedOn, deletedBy should be calculated on backend and it's value should not be taken from API's request body.
Additional context
Sandbox Repo: https://github.com/AryanshSourcefuse/sandbox-sourceloop
Here I created just a todo service and a todo model, then I called the POST /todos API to create a todo with some random data
// Request body, notice dates are in past and in place of userIds I have added Random User
{
  "deleted": true,
  "deletedOn": "2022-05-12T16:35:01.141Z",
  "deletedBy": "Random User",
  "createdOn": "2022-05-12T16:35:01.141Z",
  "modifiedOn": "2022-05-12T16:35:01.141Z",
  "createdBy": "Random User",
  "modifiedBy": "Random User",
  "title": "Hi"
}

Once I made the API request, entry was made in the database(Refer below Screenshot)

@AryanshSourcefuse are you using UserModifiableRepository as base class for your repository ? If not, then you need to do that. I can see in your sandbox example, that you have not used the repo I mentioned. You need to use that for restrictions. Its mentioned in readme as well. Its similar to how softdelete works. Please fix the repository base class and then check.

Sorry, I was not able to find that in docs.


Expose Uniques helper functions and DestroyWitness fields

We@Basilisk are planning to use our custom pallet-nft which is basically wrapped pallet-uniques with some customizations and extended permission functionality.
In order to use pallet-uniques' helper methods do_method we need to make them pub. Also need to make DestroyWitness fields pub to use them - e.g. need to prevent destroying classes which contain instances.

@shawntabrizi hi, opening PR as discussed, can you please have a look?


Allow multiple triggers for a job

Currently I can specify only one trigger for a job:
- job: copr_build
  trigger: commit
  metadata:
    branch: build-branch

To avoid duplicate code in the packit config - specifying two jobs for basically the same - allow specifying multiple triggers. E.g.
- job: copr_build
  triggers:
    - commit
    - pull_request
  metadata:
    branch: build-branch

Michal, thank you for taking time opening this.
I'm going to be as transparent as possible.
There are multiple reasons why I think we cannot accept this:

We are stomped with requests in the past months and are unable to resolve them in a timely manner (as you already know).
Even though this sounds like a simple request (and easy to be implemented), I can tell ya up front that a PR to resolve this would touch a ton of code and would probably be a diff of 1000 lines.
I understand the benefit of this request: smaller, concise config. On the other hand, I feel like the engineering work spent on this is bigger than the benefit: configs are meant for services to use and humans to write - does 10 extra, dupe lines make such a big impact?

Therefore in order to prevent this request rotting in the queue, I'm closing it right away.
We appreciate feedback like this very much: that's what powering the team - the fact that people use packit and care about the project. Please keep them coming - it's just that not every suggestion gets accepted or implemented. I know that you understand what it takes to maintain a project. Thank you, big love :heart:

Thanks for your time to write such an elaborate comment. I totally understand.


I would like to have access to some ressource

Title
Easily accessible seed to voxel correlation and machine learning program in Python with high performance computer (HPC) and Docker.
Is this a new project?
yes
People involved
Claudéric DeRoy (Github user : neurok8050)
Project Description

What are you doing, for whom, and why?
I want to do the exercise from the HPC module. I also want to use the resource for my project.

Link to project repository/sources
https://github.com/brainhack-school2022/deroy_project
What resources do you require?
HPC
Anything else?
No response

Dear @neurok8050 - we need an email address to create the account. Can you send this to the team on https://mattermost.brainhack.org/brainhack/channels/brainhack_cloud ?

Dear @neurok8050
the project is created under "seed_voxel_correlation". You have an email with the login details.
Kind regards
Steffen

Dear @neurok8050,
I send you an email a few days ago to ask about your 3 HPC clusters you are running in your account and the underutilization of the cloud resources. Can you please respond to my email to let me know what is happening in your account - otherwise I have to shutdown the unused resources on the 5th of September.
Thank you
Steffen

This project is now closed and all resources on the Oracle Cloud will be deleted within the next few days.


feat: add support for TS in templates

Description
As in title: Add support for TS in templates:

use @babel/preset-typescript for transpiling TS to JS

Related issue(s)
Resolve https://github.com/asyncapi/generator-react-sdk/issues/3

@magicmatatjahu any progress here? What is missing? 🤔

@jonaslagoni I didn't notice it until now, sorry! The problem is described here. https://github.com/asyncapi/generator-react-sdk/issues/3#issuecomment-828299626

Still valid. See #3 (comment)

@magicmatatjahu @jonaslagoni I would be really useful to have typescript support in template files (tsx) too. Is this still an issue, because there exists a Text component. It is also possible to use this workaround if needed.
import React, { ReactElement } from 'react'

function Component() {
   return ("foobar" as unknown) as ReactElement
}

function App() {
  return (
    <Component /> // no error
  );
```


Is it updated with ^2.0.0-rc.5?

I'm submitting a ...
[ ] feature request

Is it updated with ^2.0.0-rc.5?

Hey @jadav1982, please check out this issue https://github.com/akveo/ng2-admin/issues/171


API Pages AfterInsert Logic in Triggers OnQueryClosePage/OnClosePage

Hi,
I need to add some AfterInsert functionality to a Custom API Page where the record of the API is already inserted.
To be more specific, if a Customer is inserted via this API Page a new Contact Business Relation shall be created if a linked Contact has been found.
After some testing I have discoverd that the OnQueryClosePage/OnClosePage is run when the Customer is already inserted and that this newly created Customer can be Validated into the "No." field of the Contact Business Relation.
My question is: Is the OnCloseQueryPage Trigger on API Pages intended to behave like that and can be used to handle e.g. AfterInsert logic?
Kind Regards

@nikolakukrika - can you help?

Hi, OnQueryClosePage and OnClosePage triggers are not intended to handle web service clients. They are designed to be invoked only when page is hosted in a modal popup window (MPO), therefore a UI client.
Instead you can use the OnInsertRecord trigger and insert the record yourself, that way you'd be sure that the record is inserted and have your additional logic afterwards.
Another option could be to subscribe to OnAfterInsertRecord event on the source table, and check the client type.
[EventSubscriber(ObjectType::Table, Database::Customer, 'OnAfterInsertEvent', '', false, false)]
local procedure HandleOnAfterCustomerInsert(var Rec: Record Customer)
var
        ClientTypeManagement: Codeunit "Client Type Management";
begin
        if ClientTypeManagement.GetCurrentClientType() = ClientType::ODataV4 then
                    //do stuff
end;

Thank you @onbuyuka, issue can be closed


1.11 optifine - resources aren't loaded and crashes in dev environment

Apparently it's not optifine issue, so reporting it here.
https://github.com/sp614x/optifine/issues/766#issuecomment-315117105

Yep, it's not. My bad.
Something must have changed after 1.10.2 (dunno what yet), and the generated jars for 1.11.2 and 1.12 are not viable. 1.12 looks the same (magenta-black test texture everywhere), except it doesn't crash. Lots of FileNotFoundExceptions in the log, and if I throw in other deobfed mods as well (tested with Forestry and TechReborn) it crashes during startup. Something to do with missing and/or invalid resources again.
I never noticed the bug because of how I develop BetterFoliage: I usually work on the 1.10.2 branch, and merge my changes downstream. Since there weren't any OptiFine-related breakages in 1.11.2 and 1.12, I never even made dev versions for those (I've just noticed this now).
I'll have some time to tinker tomorrow, but if it's not something easy to fix, it'll be weeks until I can devote time to the issue. If you have a 1.10.2 version of your mod, I recommend you fix the OptiFine-related stuff there, it'll probably be fine for later versions too.
To answer your question on the other thread: yes, simpledeobf is still maintained - technically. In practice, since it did all it had to do (I use it regularly), and there was nothing to add, there were no commits for a long time.
Until now :)

I already did what I needed to do with this barely-functional version of optifine in dev environment. Since it normally wouldn't even get into main menu, getting it far enough to show a missing block ingame was enough to get it working.

I figured out a workaround for now: additionally delete all net/minecraft/client/renderer/block/model/ModelBakery*.class files from the deobfed jar, so the originals will be used.
The problem lies with the modified model bakery adding models/ to the start of model resource locations, so it tries to load them from DOMAIN:models/models/WHATEVER which will obviously fail. I didn't figure out why it happens in the dev environment and works fine in production, but if you're not debugging any extensions OptiFine adds to model loading, this will get you going.

Further testing with the fix you outlined showed that there are also lighting-related issues in dev environment (might be with just my mod, but it doesn't occur outside of dev environment). While I do have functional optifine outside of dev environment, debugging any further issues with it isn't going to be possible. And as I don't have a real 1.10 version of my mod now, without a fix it will be impossible to debug any other optifine issues.

I think I found the cause of this issue. I still have the strange issue with light spreading just plain not working, together with a lot of other strange issues but the model loading issue is gone after my fix.
I have no idea what causes this, and debugging doesn't give me much insight into the issue:
https://i.imgur.com/VFq2a5V.png
The models issue seems to be with making everything public. You probably did it to workaround IllegalAccessError crashes that you would normally get. They are caused by forge AT not being applied, and it can easily be added by adding forge_at into Optifine's jar META-INF and adding the appropriate FMLAT entry in MANIFEST.MF. Doing that and creating dev jar ithout making everything public makes the models issue go away.
I'm still investigating the issue with lighting and block updates.

I figured out the issue, and this is DEFINITELY optifine bug:
[12:21:03] [main/WARN] [Config/]: [OptiFine] (Reflector) More than one method found: net.minecraft.block.Block.getLightOpacity
[12:21:03] [main/WARN] [Config/]: [OptiFine] (Reflector)  - public int net.minecraft.block.Block.getLightOpacity(net.minecraft.block.state.IBlockState,net.minecraft.world.IBlockAccess,net.minecraft.util.math.BlockPos)
[12:21:03] [main/WARN] [Config/]: [OptiFine] (Reflector)  - public int net.minecraft.block.Block.getLightOpacity(net.minecraft.block.state.IBlockState)
[12:21:03] [main/WARN] [Config/]: [OptiFine] (Reflector) More than one method found: net.minecraft.block.Block.getLightValue
[12:21:03] [main/WARN] [Config/]: [OptiFine] (Reflector)  - public int net.minecraft.block.Block.getLightValue(net.minecraft.block.state.IBlockState)
[12:21:03] [main/WARN] [Config/]: [OptiFine] (Reflector)  - public int net.minecraft.block.Block.getLightValue(net.minecraft.block.state.IBlockState,net.minecraft.world.IBlockAccess,net.minecraft.util.math.BlockPos)

Yes, you're 100% right about the AT stuff. That's why I did it, and using the transformer makes for a much better dev jar overall. I didn't think of that - just went for the easy way out right away.
Seeing the logs you posted, I had a snap theory about the lighting, but I see you've already confirmed my suspicions over in the Optifine repo. I hope this is the last hurdle, and when sp614x makes the necessary adjustments, you'll have a fully functional jar so you can keep working.
Thanks for all the work you put into this!


Test: Increase logs for Kube-dns issues

Added kubedns logs in reportFailed.
Added a new fallback option in WaitForKubeDNSEntry to know in case
of fail if the issue is that the DNS entry does not exits, or cannot
connect to kube-dns service.
Use service IP instead of the kube-dns pod IP.

Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

test-me-please

test-me-please

test-me-please

Marking this as a backport candidate since this will provide useful logs for triaging CI failures which can potentially affect 1.0 CI.

backport in https://github.com/cilium/cilium/pull/3771


Monaco windows don't resize when resizing the browser window

Collapsing and reopening the window seems to fix the problem but we should force the resizing somehow.

I am closing because, this should be fixed now. Feel free to re-open if needed


Invalid component type

I am trying to create entity with position component with this code
const auto player2 = registry.create(); registry.emplace<position>(player2, 10, 5);
with the position as
struct position {     float x;     float y; };
which genrate the following eror
 error: static assertion failed: Invalid component type              static_assert(std::is_same_v<Comp..., Component>, "Invalid component type");                            ^~~

As it stands, there are not enough information to help.
Can you provide at least the version of EnTT in use and the line/file where the assert is triggered?
Thanks.

I used EnTT v3.7.1 and even tried the latest master brench
edit: something awkward happened after I retried with same code now it worked
sorry for inconvenience
if you don't mind me I have a couple function
1- how can I attach some function to component so when iterate on the component I can just call it's function
2-how can I get a pointer to a component and not copy so I don't waste memory
I tried this
auto pos = registry.get<position>(player2); but it generate a copy of that component
note : I tried reading the docs

@hero2002

Components are class types. They can have member functions. Isn't it enough to attach a function to a component? Otherwise you can use a function pointer or the like. This doesn't really depend on/matter to EnTT.

get returns a reference. Try auto & instead of auto.


Extension methods crashed when called on a dynamic object

Happens on MacOSX / Linux and reproducible in DartPad.
Dart version: Based on Flutter 1.23.0-18.1.pre Dart SDK 2.10.4
Consider the following code:
class MyClass {
  void foo() => print('foo');
}

extension Bar on MyClass {
  void bar() => print('bar');
}

void main() {
  dynamic val = MyClass();
  val.foo();
  val.bar(); // crashes
}

This compiles fine, but crashes at runtime because the extension method bar() cannot be found. The compiler should either fail with an error, or better still valid code should be generated that invokes the method at runtime.

This is by design: https://dart.dev/guides/language/extension-methods#static-types-and-dynamic
I have no idea if or how this could be turned into a runtime error - someone from the language team could better answer that.

It could probably at least be a lint.

@leafpetersen would know the langauge question, @pq the lint

For better or worse the contract with dynamic is that the compiler just believes that you know what you're doing.  I think this would be a fine candidate for an opt in lint though.

Yeah.  This seems to fit in a general category of advice that recommends avoiding dynamic almost altogether.
@chickenblood: can you provide some context?  Why would you type val dynamic in practice?

I try to avoid dynamic altogether. In this case I was consuming a Flutter API that returns a dynamic type.
https://api.flutter.dev/flutter/widgets/DragTargetMove.html
I did not realize this since most of the callbacks for this class are typed
I plan to file a bug on that API. However, I would still hope that the linter could help us in cases like this. It is often not apparent that an implicit conversion is taking place.

There are a couple lints around implicit dynamics.  I'm not sure they capture this case.  @chickenblood - do you have an example of where the dynamic call is coming from?  The dynamic here is the type parameter, so not obvious.

Sure. I provided a callback for DragTarget.onMove and in there called details.data.doThing() (doThing() being the extension method). Because details.data is dynamic, the failure occurs.
DragTarget.onAccept and DragTarget onAcceptWithDetails do not have this problem because the argument is typed.
The lint sounds like a very good idea here (as well as fixing the DragTarget API).

@franklinyow - it sounds like the resolution for this issue is for a lint request? If that's the case, I'd update the title to reflect that, and move the issue to the dart-lang/linter repo.

Issue moved to dart-lang/linter #2379 via ZenHub


[GHSA-3xq5-wjfh-ppjc] Luxon Inefficient Regular Expression Complexity vulnerability

Updates

Affected products

Comments
Version 1.38.1 does not exist.

Hi there @icambron! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

See https://github.com/github/advisory-database/pull/1586

dup of #1586. Thanks for pointing it out @icambron


Remove faulty characters from filename

Fixes #614

@Brutus5000 made a PR for java-api, but there will still be maps that have an incorrect syntax what do you wann do with them??

Looks like we need a script on the server to rename the file and update the sql table entry.

At least we need to do something as map vault crashes on illegal characters !

So what is the outcome of all of this?

May general feedback is still the same. Validate the filename consistently over maps and mods.

So I close this?


[BUG] Rancher spammed with logs when a k3s cluster is deleted and it is stuck in Removing state

Rancher Server Setup

Rancher version: 2.8-head- commit id: 331d18b docker install

Information about the Cluster

Kubernetes version: 1.26, any - doesn't matter

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) Admin

Describe the bug
[BUG] Rancher spammed with logs when a cluster is deleted and it is stuck in Removing state
To Reproduce

Deploy 2.8-head rancher
Deploy a k3s cluster downstream
In the local cluster, edit config of workload - capi-controller-manager and change its image to an invalid one. (Wanted to test a failure usecase)
Now edit the k3s cluster and save changes made.
Cluster will be stuck in updating state.
Delete this cluster

Result
Rancher logs spammed with error
2023/09/28 21:24:54 [ERROR] error syncing 'fleet-default/sowmya2': handler provisioning-cluster-remove: Internal error occurred: failed calling webhook "validation.cluster.cluster.x-k8s.io": failed to call webhook: Post "https://capi-webhook-service.cattle-provisioning-capi-system.svc:443/validate-cluster-x-k8s-io-v1beta1-cluster?timeout=10s": no endpoints available for service "capi-webhook-service", requeuing
2023/09/28 21:24:54 [ERROR] error syncing 'fleet-default/sowmya2': handler provisioning-cluster-remove: Internal error occurred: failed calling webhook "validation.cluster.cluster.x-k8s.io": failed to call webhook: Post "https://capi-webhook-service.cattle-provisioning-capi-system.svc:443/validate-cluster-x-k8s-io-v1beta1-cluster?timeout=10s": no endpoints available for service "capi-webhook-service", requeuing
2023/09/28 21:24:54 [ERROR] error syncing 'fleet-default/sowmya2': handler provisioning-cluster-remove: Internal error occurred: failed calling webhook "validation.cluster.cluster.x-k8s.io": failed to call webhook: Post "https://capi-webhook-service.cattle-provisioning-capi-system.svc:443/validate-cluster-x-k8s-io-v1beta1-cluster?timeout=10s": no endpoints available for service "capi-webhook-service", requeuing
2023/09/28 21:24:54 [ERROR] error syncing 'fleet-default/sowmya2': handler provisioning-cluster-remove: Internal error occurred: failed calling webhook "validation.cluster.cluster.x-k8s.io": failed to call webhook: Post "https://capi-webhook-service.cattle-provisioning-capi-system.svc:443/validate-cluster-x-k8s-io-v1beta1-cluster?timeout=10s": no endpoints available for service "capi-webhook-service", requeuing
2023/09/28 21:24:54 [ERROR] error syncing 'fleet-default/sowmya2': handler provisioning-cluster-remove: Internal error occurred: failed calling webhook "validation.cluster.cluster.x-k8s.io": failed to call webhook: Post "https://capi-webhook-service.cattle-provisioning-capi-system.svc:443/validate-cluster-x-k8s-io-v1beta1-cluster?timeout=10s": no endpoints available for service "capi-webhook-service", requeuing
2023/09/28 21:24:54 [ERROR] error syncing 'fleet-default/sowmya2': handler provisioning-cluster-remove: Internal error occurred: failed calling webhook "validation.cluster.cluster.x-k8s.io": failed to call webhook: Post "https://capi-webhook-service.cattle-provisioning-capi-system.svc:443/validate-cluster-x-k8s-io-v1beta1-cluster?timeout=10s": no endpoints available for service "capi-webhook-service", requeuing
2023/09/28 21:24:55 [ERROR] error syncing 'fleet-default/sowmya2': handler provisioning-cluster-remove: Internal error occurred: failed calling webhook "validation.cluster.cluster.x-k8s.io": failed to call webhook: Post "https://capi-webhook-service.cattle-provisioning-capi-system.svc:443/validate-cluster-x-k8s-io-v1beta1-cluster?timeout=10s": no endpoints available for service "capi-webhook-service", requeuing
2023/09/28 21:24:55 [ERROR] error syncing 'fleet-default/sowmya2': handler provisioning-cluster-remove: Internal error occurred: failed calling webhook "validation.cluster.cluster.x-k8s.io": failed to call webhook: Post "https://capi-webhook-service.cattle-provisioning-capi-system.svc:443/validate-cluster-x-k8s-io-v1beta1-cluster?timeout=10s": no endpoints available for service "capi-webhook-service", requeuing
^C

Expected Result
Rancher should not be spammed with these messages every second

@sowmyav27 For step 3 when you change the image to an invalid one, are you also deleting the existing pods manually with kubectl delete pods capi-controller-manager-<pod-ID> -n cattle-provisioning-capi-system? Otherwise, this step would likely have no real effect as the new pods would fail to start and the new pods would keep running.

Talked offline with @bfbachmann , and the details have been updated in the original issue's description


Make OPS Emissions a directory like AMIP/AMIP.20C?

This is a question for @amdasilva just from my own thoughts.
Currently in, say, CA2G we have:
CA2G_GridComp/
├── AMIP
│   ├── CA2G_GridComp_ExtData.rc
│   ├── CA2G_instance_CA.bc.rc -> ../CA2G_instance_CA.bc.rc
│   ├── CA2G_instance_CA.br.rc -> ../CA2G_instance_CA.br.rc
│   └── CA2G_instance_CA.oc.rc -> ../CA2G_instance_CA.oc.rc
├── AMIP.20C
│   ├── CA2G_GridComp_ExtData.rc
│   ├── CA2G_instance_CA.bc.rc -> ../CA2G_instance_CA.bc.rc
│   ├── CA2G_instance_CA.br.rc -> ../CA2G_instance_CA.br.rc
│   └── CA2G_instance_CA.oc.rc -> ../CA2G_instance_CA.oc.rc
├── CA2G_GridCompMod.F90
├── CA2G_GridComp_ExtData.rc
├── CA2G_StateSpecs.rc
├── CA2G_instance_CA.bc.rc
├── CA2G_instance_CA.br.rc
├── CA2G_instance_CA.oc.rc
└── CMakeLists.txt

where the OPS emissions files are the ones in the main directory. What I'm wondering is might there be a benefit to having instead:
CA2G_GridComp
├── AMIP
│   ├── CA2G_GridComp_ExtData.rc
│   ├── CA2G_instance_CA.bc.rc -> ../OPS/CA2G_instance_CA.bc.rc
│   ├── CA2G_instance_CA.br.rc -> ../OPS/CA2G_instance_CA.br.rc
│   └── CA2G_instance_CA.oc.rc -> ../OPS/CA2G_instance_CA.oc.rc
├── AMIP.20C
│   ├── CA2G_GridComp_ExtData.rc
│   ├── CA2G_instance_CA.bc.rc -> ../OPS/CA2G_instance_CA.bc.rc
│   ├── CA2G_instance_CA.br.rc -> ../OPS/CA2G_instance_CA.br.rc
│   └── CA2G_instance_CA.oc.rc -> ../OPS/CA2G_instance_CA.oc.rc
├── CA2G_GridCompMod.F90
├── CA2G_StateSpecs.rc
├── CMakeLists.txt
└── OPS
    ├── CA2G_GridComp_ExtData.rc
    ├── CA2G_instance_CA.bc.rc
    ├── CA2G_instance_CA.br.rc
    └── CA2G_instance_CA.oc.rc

We still use symlinks to prevent code duplication, but now it's a bit more obvious that some files belong to the OPS emissions without knowledge that the "main directory" ones are those.
I only say this because then in the $EXPDIR/RC directory, a user would have an OPS, AMIP, and AMIP.20C directory where you'd know if you want to affect an OPS emissions run, you change the files in OPS. At the moment, you have to know that $EXPDIR/RC/CA2G_GridComp_ExtData.rc is the one for OPS and $EXPDIR/RC/AMIP/CA2G_GridComp_ExtData.rc is the one for AMIP.
Obviously, we'd need to make scripting changes, etc (as well as concurrent changes in Chem), but it might make things a bit clearer?
Not sure. Thought I'd ask.

@mathomp4 This is an attractive solution to the current asymmetry;  it would more clearly delineate the set of files specifically designated for OPS runs, and if a user wanted to update a particular resource file, they would not make the mistake of editing (for example) the version of the file in RC/  when they really meant to change the version under RC/AMIP.


Alignment of "Time Interval" dropdown ;Addition of 'back' button and colour contrast of instrument screen

The drop-down in the time interval in "Generate Config File" is not properly aligned initially.
The dropdown containing sec, min, hr and day is not properly aligned.

There is no back button anywhere on the 'sensors' screen. When we open the Sensors in
the instrument(home screen), there is no option to go back to the main menu on the UI.

The color contrast of the home screen is not decent. The colors are too bright and it pains in
eyes.

To Reproduce the first bug;

Go to the "Generate Config File" section in the navigation bar.
See error -->The dropdown corresponding to the "Time Interval". You will be able to see the dropdown not properly aligned

To Reproduce the second Bug;

Go to the "Sensors" in the instruments section.
See error-->There is no back button anywhere in that section to return back to the home screen.

Screenshots

Smartphone Info:
|Device          |[Redmi Note-5 Pro]|
|Android Version|[Android 10]|
Additional context
Please choose a decent color contrast for the home screen.
Would you like to work on the issue?
-[No]

This issue is for the PSLab Android App, open it in that app's repo.


Manually include the CentralPackageVersion files

To workaround https://github.com/Azure/azure-sdk-for-net/issues/7490
we are going to simply extract and include the props and targets
file from the package directly into our repo.
This should eliminate the issue in #7490 and if the nuget team ever fixes the resolve issue we can consider switching back to using an SDK reference instead.
cc @chidozieononiwu @pakrym

/azp run net - core


Restore cargo fmt behavior in workspaces

Previously, cargo fmt  invoked without parameters would
only format the crate in the current directory, even if
the crate was part of a workspace. This patch restores
that behavior.

Thanks! Could you rebase please?

Done!

Thank you!


Fixes docker image to align with 1.9

Fixes the outdated run invocation for self-managed configuration mode, and also aligns the config file type with the source.

This PR results/does not result in breaking changes to upstream dependencies.

Checklist

[x] This PR contains all the work required to resolve the linked issue.

[x] The work contained has sufficient documentation to describe what it does and how to do it.

[ ] The work has sufficient tests and/or testing.

[x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

[x] I have added the appropriate labels to this PR.

bors r+


hardware.video.hidpi.enable = true breaks nixos-rebuild

Describe the bug
When adding
hardware.video.hidpi.enable = true;

To my NixOS configuration I get when launching sudo nixos-rebuild switch --upgrade --show-trace:
# many lines ending with:
/nix/store/ba4p71msbb4bvcjc8isxn9w7d5m21qpb-extra-utils/bin/fsck.btrfs' -> 'btrfsck'
'/nix/store/rj6a0zv814zsknnx9ankrqhbzgfh27i3-cryptsetup-2.3.3/bin/cryptsetup' -> '/nix/store/ba4p71msbb4bvcjc8isxn9w7d5m21qpb-extra-utils/bin/cryptsetup'
'/nix/store/mqimkd6mgx78ng3cpwzqpqi2kic0jf7m-cryptsetup-askpass/bin/cryptsetup-askpass' -> '/nix/store/ba4p71msbb4bvcjc8isxn9w7d5m21qpb-extra-utils/bin/cryptsetup-askpass'
cp: missing destination file operand after '/nix/store/ba4p71msbb4bvcjc8isxn9w7d5m21qpb-extra-utils/share/consolefonts/font.psf'
Try 'cp --help' for more information.
builder for '/nix/store/sri3bv1h184z0pqww63vranlbzq67p7j-extra-utils.drv' failed with exit code 1
cannot build derivation '/nix/store/wvj2qfimsdsn94ricbca8nhlgskp359a-stage-1-init.sh.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0s224kkm1f3kgzc9gvc3l3l4is5b0b2c-initrd-linux-5.4.73.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/y5y2mwl4zzqzw3xv64z99ccyym02synp-nixos-system-thinkpad-x1e-20.09.1599.d105075a1fd.drv': 1 dependencies couldn't be built
error: build of '/nix/store/y5y2mwl4zzqzw3xv64z99ccyym02synp-nixos-system-thinkpad-x1e-20.09.1599.d105075a1fd.drv' failed

Expected behavior
I expect the console font to become bigger and readable, on boot up and before I need to enter my Disk-Encryption password.
I have a high resolution and with my eyes it is very difficult to read the console font.
Metadata
#> nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.72, NixOS, 20.09.1599.d105075a1fd (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.7`
 - channels(root): `"nixos-20.09.1599.d105075a1fd, nixos-hardware"`
 - channels(reirob): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

you could try adding
boot.kernelParams = [ "nomodeset" ];

new nvidia gpu's don't seem to play well right now without that param

Reproduced on latest stable and latest unstable.

Reproduced on latest stable and latest unstable.

which console font are you setting?

@Artturin Lat2-Terminus16

i cannot repro, could you send your config?

Cannot reproduce either.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.2.3-xanmod1, NixOS, 23.05 (Stoat), 23.05.20230316.194c2aa`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


feat: add base helm chart

I've moved everything to this new repository and I've added on top :

https://github.com/Stirling-Tools/Stirling-PDF/pull/2178
https://github.com/Stirling-Tools/Stirling-PDF/pull/2174

As before we have to setup gh-pages branch as described here : https://github.com/Stirling-Tools/Stirling-PDF/pull/2113
Regression : The sync script can't be moved for now as it reads the gradle file.
Do you want to setup a DNS entry for the github  page ? otherwise it would be https://stirling-tools.github.io/Stirling-PDF-chart
@Frooodle

https://stirling-tools.github.io/Stirling-PDF-chart
Should be fine, its what most would expect I guess
and thanks again for this, awesome work

gh-pages pushed

ahh seems its pushed to
http://docs.stirlingpdf.com/Stirling-PDF-chart/

Ah yes I think it's because the name is on the organization ? which one would you want to keep ?

Can you also pin the github pages address in the About ?


Buffer pooling alert post request body buffer

Added buffer pooling for post handler in alert.
I tried to add benchmark for this, by using httptest.NewServer and got: accept: too many open files, I tried to increase the maximum file descriptors to 4096 and didn't helped.

@yosiat Looks good thanks.

@nathanielc can you think of a way we can benchmark the post handler of alert?

Using httptest.NewServer should work, accept: too many open files should only occur if the requests were being made massively parallel or they were not being closed after use. Could you share the code you wrote initially?
Also I merged because it was a simple enough change that I didn't think it merited its own benchmark (it does have a test). But if you want to add the benchmark I am happy to help.

@nathanielc The code created httptest.NewServer and doing nothing in the handler function, and I passed the url of the httptest to the post handler, nothing special here.
I think I got the error (might be because of #572) or because we have 1000 tasks, which means 1000 requests..

@yosiat  I think you are right. Worth trying again once its merged.


NuGet Support & Build System

The NuGet package you have published is ages old, kindly update the package. VS2019 suggested using "Nancy" package when using container and other classes in code. I have to use it as of now, please update your package. Maybe use some automated build system for pushing stuff to NuGet automatically.

We'd be willing to accept GitHub actions support as a PR. I'll see what we can do to update this package.

We'd be willing to accept GitHub actions support as a PR. I'll see what we can do to update this package.

I can give you access to the package in nuget if I haven't already.

Can you please add me to nuget: niemyjski

I just did a bunch of work to get it working on Mac and GitHub actions (clone and run) as well as the new project system. Still more todo.


Update sustainability-design-methodology.md

The section for calculating SCI is quite difficult to understand, so I have linked to 2 Microsoft examples
Before selecting the "Create pull request" button:

Enter a meaningful title above^, using a prefix if necessary and keywords "New" or "Update" indicating the nature of changes.

Describe the summary, scope, and intent of this PR:
[REPLACE-THIS-TEXT]

Insert links(s) to any related work item(s) or supporting detail:
[DELETE-OR-REPLACE-THIS-TEXT]

AFTER YOUR PR HAS BEEN CREATED, expand this section for tips and additional instructions.
These are common guidelines for contributions across the repos managed by the Cloud Architecture Content Team (CACT). Some repositories may have additional specific requirements that are not listed here.
Guidance for all contributors

Topic
Guidance

Draft PR
If your PR will be a work-in-progress for more than a day or two, select the Convert to draft link in the upper right of the page (under Reviewers) to change it to a draft. For future reference, you can also do this using the Create pull request button drop-down during PR creation.

ms.date metadata
Don't update an article's "ms.date" metadata property unless you've done a full freshness review of the content. A full freshness review includes changes required to correct or improve the full technical accuracy of the article.Don't update "ms.date" if you're doing targeted changes to improve non-technical aspects of the article, such as editorial quality, art improvements, article template alignment, etc.If you've changed any "ms.date" properties for work that wasn't part of full review for freshness, please reset them to their previous value.

Placement and linking
If you're creating a new article or articles, include updates to the related TOC.yml file to propose where the article(s) should be placed. Also consider other places within the document set where it would be beneficial to cross-reference and link to your new article(s).

PR build
After you open your PR, and for each successive commit that you push to your branch, the publishing platform will run validation on the files in your pull request. A summary of the build results for each file will be inserted inline into your pull request, which includes any build suggestions/warnings/errors. PRs cannot be merged until all build errors and most warnings are resolved.

Publishing
Following a successful merge, most repos publish to the live site at least once per (business) day, usually around 10am Pacific.

Additional resources
Learn.Microsoft.Com contributor guide

Additional guidance for private repos and internal contributors

Topic
Guidance

PR size
If your PR is more than ~5 lines of changes, or you'd like for the changes to go through editorial or larger review, open a contribution request at https://aka.ms/Contribution and include a link to the PR in response #8. Once it's processed, you'll be notified of the next steps.

PR title prefix
Select the Edit button to the right of the PR title if you need to revise it. The following prefixes are reserved for specific contribution types:[Quality Check] - maintenance work related to content quality (edit passes, art improvements, template alignment)[LinkFix] - recurring/adhoc PRs to correct link URLs[Pipeline] - new/updated contributor success pipeline content[WIP] - a work-in-progress draft requiring several days/weeks

PR preview
Following successful build of your PR, publishable files will also include Preview URL links to staged previews of your new/updated articles. Be sure to review these for verification of your intended contributions, or to send to other internal contributors for review.

PR sign-off (public repo)
If an article you own is updated in a public repo PR, you are responsible for sign-off. You will be automatically notified via email. The PR will not be merged until you've had a chance to review and sign-off.

PR sign-off (private repo)
After you've completed your proposed changes, addressed build warnings, and completed all review work, you can begin the sign-off process for review and merge:If your PR is in draft mode, remove "[WIP]" from the title and select Ready for review button at the bottom of the PR.Enter "#sign-off" in a new comment. This comment indicates that you're confident the work meets or exceeds Microsoft's standards for publication, and will trigger the review process.Your PR may be selected for initial review by the CACT. Following CACT review, you may receive questions or requests for additional changes. You should have initial feedback from CACT review within a few business days. If you have an urgent request or need to contact the team, please mention @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers in your PR and someone will get back to you. After CACT review is complete, a CACT #sign-off will be added.Final review/merge is done by the PR review team. The PR team may also respond with feedback, categorized as "Blocking" (requires action from you), or "Non-blocking" (to be addressed in a future PR).

Additional resources
Learn.Microsoft.Com internal contributor guideAuthoring templates: architecture-center-pr, well-architected-prTo contact the CACT use e-mail, or @mention our GitHub team in your PR comments using: @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers

@Zimmergren
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @thommck - I've marked this PR a draft to prevent accidental merging. Is there an ADO item associated with this work? If not, could you please fill out a contribution request form here: https://aka.ms/contributions?
Additionally, all proposed changes should be made in the private repository: https://github.com/MicrosoftDocs/well-architected-pr. Please close this PR and open a new one in the private repo with the proposed changes.

@Zimmergren - Priyanka asked that you take a look at these sustainability updates to see if you think they should be accepted.

Closing and re-opening to trigger a new build; the review link wasn't available.

#sign-off

#sign-off


Write description about VideoPlayerHelper

Please add description in this page.
https://github.com/styly-dev/STYLY-Spatial-Layer-Plugin/wiki/Content-samples#play-online-video

For this description, I created a full documentation on the file and what it does, but I don't think that the wiki is where that description should be added.
Do you mean a small description of what it does and not a full on documentation?
As I already made it, is there somewhere I can put it for future implementations?


Test account logic in mina_base package.

Explain your changes:

Add unit test for account logic

Explain how you tested your changes:

Run in CI.

Checklist:

[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] All tests pass (CI will check this if you didn't)
[x] Does this close issues? List them

Closes #12803

Opened against wrong branch. Closing.


Cancel request only works for get, not post?

#### Summary
Using the cancel example from the readme, anytime I create post requests, cancel never cancels them.  However, when I swap post with get, the previous request cancels as expected.
 var CancelToken = axios.CancelToken;
 var source = CancelToken.source();

 axios.post('/api/search', {
     query: query,
     cancelToken: source.token
 }).then((response)=>{
     this.users = response.data;
     this.isLoading = false
 }).catch((error)=>{
     if (! axios.isCancel(error)) {
          this.isLoading = false
     }
 });

 source.cancel();

#### Context

axios version: v0.16.2
Environment: node v8.4.0, chrome 60.0.3112.101, osx 10.11.6

@jaketoolson It should work for POST requests as well.
I think you may want to set isLoading to false regardless of whether the request has failed or been canceled.
Can you please try something like this?
.catch((error) => {
  this.isLoading = false;
  if (axios.isCancel(error)) {
    console.log('Request canceled');
  }
});

Closing due to inactivity

Updated
POST worked demo
In post method, cancelToken should not be a param, but be a config.Then it works.
axios.post('http://zhaoke.proxy.beeceptor.com/api/login',{
  // params
}, {
     cancelToken: source.token
 }).then((response)=>{

 }).catch((error) => {
  if (axios.isCancel(error)) {
    console.log('post Request canceled');
  }
});


Calculated TableView columns widths are sometimes inaccurate due to state setTableWidth

🐛 Bug Report
We've seen a case where an initially hidden column renders with a width of 0 instead of its provided minWidth. It seems to due to setTableWith here becoming stale, which causes column widths to be calculated against an outdated columns prop.
🤔 Expected Behavior
Newly added column is rendered with the proper width
😯 Current Behavior
Newly added column is rendered with 0px width
💁 Possible Solution
Add setTableWidth to dep array here
🔦 Context

💻 Code Sample
Sandbox example: https://codesandbox.io/s/brave-pare-ntibeu?file=/src/App.js. This example doesn't actually exhibit the broken behavior but models the setup the user was seeing.
🌍 Your Environment

Software
Version(s)

react-spectrum
3.21.2

Browser

Operating System

🧢 Your Company/Team

Rough code flow:

setTableWidth is computed every render. It makes use of columns obtained from state(i.e. state.collection from useTableState) which isn't a problem so long as you use the updated setTableWidth when calling it from other hooks/code. (Side note: probably should make this a useCallback)
TableView uses setTableWidth in https://github.com/adobe/react-spectrum/blob/e514827f49696a9c20fb819bd9610651f7017039/packages/%40react-spectrum/table/src/TableView.tsx#L400-L411. Since this makes use of useCallback, it doesn't recompute onVisibleRectChange when setTableWidth changes, meaning we may not be computing with the latest columns received via props

setTableWidth is a new function every render, it should probably be memo'd as well, or onVisibleRectChange will also update every render.

this should be fixed now by https://github.com/adobe/react-spectrum/pull/3672, @LFDanLu do you have a test case you could check against it?

Nah, didn't have a reproduction of the above error but I'll ping the team that did to try it out

Closing, inactivity and should be fixed


Fix: Regression - Big number pad button size is not justified on small screens

Details

Big number pad button size is not justified on small screens. We previously check for small screens based on the dynamic windowHeight which changes when soft keyboard opens. This PR uses screenHeight instead.
Fixed Issues

$ https://github.com/Expensify/App/issues/24603
$ https://expensify.slack.com/archives/C049HHMV9SM/p1693367178391569
Tests

=== On small height devices (iPhone SE - Safari)

Login with any account
Press FAB >> Request money
Verify that the amount input is fully visible
Verify that number and next button height is medium
=== On larger height devices (iPhone 14 - Safari)
Press the currency symbol
Verify soft keyboard appears
Press back
Verify that the amount input is fully visible
Verify that number and next button height is normal without any flickering

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

=== On small height devices (iPhone SE - Safari)

Login with any account
Press FAB >> Request money
Verify that the amount input is fully visible
Verify that number and next button height is medium
=== On larger height devices (iPhone 14 - Safari)
Press the currency symbol
Verify soft keyboard appears
Press back
Verify that the amount input is fully visible
Verify that number and next button height is normal without any flickering

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/113963320/b675446b-561a-4040-9ff4-4e8b643b0ffc

Mobile Web - Chrome

https://github.com/Expensify/App/assets/113963320/da22b540-2edb-4edf-b008-83ac9e599402

Mobile Web - Safari

https://github.com/Expensify/App/assets/113963320/bcb7f07d-c582-49f1-9a81-d041bd5dba52

Desktop

https://github.com/Expensify/App/assets/113963320/340a7d1f-9b01-424d-bd00-349dd10e194b

iOS

https://github.com/Expensify/App/assets/113963320/ef4712c9-de56-456e-b4e3-b8cd048e18e0

Android

https://github.com/Expensify/App/assets/113963320/3b7f8cba-e1ba-40c1-abfc-af85f352ecfa

Looking!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.71-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


lib.fileset: Lazier path existence check

Description of changes
Allows things like difference ./. ./a even if ./a doesn't exist.
Another case that's now doable is intersection ./a (union ./a ./b) even if ./b doesn't exist.
This is an alternative to https://github.com/NixOS/nixpkgs/pull/265964 that doesn't require a new function and is more transparent to the user.
It's not perfect however, because difference ./. (difference ./a ./a/b)
doesn't give an error anymore if ./a/b doesn't exist. We can maybe consider this an edge case. This could be fixed in the future, but would need a non-trivial change to the internal representation.
More problematic however is that you aren't protected against typos in the negative argument anymore: If you want to remove ./secret, but you write difference ./. ./sercet instead, it would just fail silently and import the path into the store! This is making me think that we maybe shouldn't do this.
This work is sponsored by Antithesis :sparkles:
Things done

[x] Extended tests
[x] Updated documentation
[x] Clean and commented code

it would just fail silently and import the path into the store! This is making me think that we maybe shouldn't do this.

Yes, this in particular.

Looks like we need a sercet breaker.

There were some minor changes here useful on their own, created a separate PR for those: https://github.com/NixOS/nixpkgs/pull/268520


Connection Test feature does not display error modal when test fails

The Connection Test feature does not display an error message, popup, etc. if the test fails. Opening the DevTools console, I can see JavaScript errors occurred.
(Reported to me, directly, via Sitecore Slack - user wished to remain anonymous)

I was able to reproduce this issue.
Issue has been marked verified and will be fixed in the next release.

Issue fixed. You should now see a modal with help information when a connection test fails. I also logged more detailed information about the failed request in a JS object that I printed to the DevTools console as an error.


Use zoned UTC when comparing search doc and edition publication dates.

Description
Fixes an assertion in tests/core/models/test_work.py::TestWork::test_to_search_document, so that both sides of the comparison are based on UTC-zoned datetimes.
Motivation and Context
Test was failing depending on the timezone and time configured for the test environment.
How Has This Been Tested?

Manually ran tests with different time zones configured in the test environment.

TZ = UTC: Test always passed -- both before and after the change.
EST: Before the fix, test always failed.
EST: After the fix, test always passed.

CI tests.

Checklist

[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.

This looks good. I'm curious why assert_time_match apparently isn't vulnerable to this problem.
I might move these time/date comparisons into a module as part of the test suite refactoring, as there are a lot of comparisons all over the test suite and it'd be good to only have this kind of code once.

assert_time_match is using a tz-aware, UTC datetime provided by our own from_timestamp helper method, so won't have the same problem.

@RishiDiwanTT Requesting your review to make sure that I'm not breaking/failing to test any assumptions from this test's origin PR (#453).