CoreCLR Access Violation

Windows service application is unstable after upgrade to netcoreapp2.2 from net472.
Can provide a minidump created by DebugDiag tool
Event Log record:
Log Name:      Application
Source:        .NET Runtime
Date:          3/21/2019 3:40:06 PM
Event ID:      1023
Task Category: None
Level:         Error
Keywords:      Classic
User:          N/A
Computer:      API1
Description:
Application: apppp.exe
CoreCLR Version: 4.6.27110.4
Description: The process was terminated due to an internal error in the .NET Runtime at IP 00007FF842E8D149 (00007FF842CD0000) with exit code c0000005.

DebugDiag report:
Entry point   coreclr!Thread::intermediateThreadProc
Create time   3/21/2019 4:28:56 PM
Time spent in user mode   0 Days 0:0:0.0
Time spent in kernel mode   0 Days 0:0:0.0

**Full Call Stack**

Function     Arg 1     Arg 2     Arg 3     Arg 4   Source
KERNELBASE!RaiseException+68     00000000`00000001     0000000a`ec2ff108     000001a3`dc122818     00000000`00000004
coreclr!RaiseTheExceptionInternalOnly+2fc     00000000`00004000     000001a3`f59e6980     000001a3`dc4c91b8     000001a3`f59e6980   e:\a\_work\287\s\src\vm\excep.cpp @ 2996 + 11
coreclr!UnwindAndContinueRethrowHelperAfterCatch+71     00000000`00784086     000001a3`f59e6980     00000000`0c784000     00000000`00000101   e:\a\_work\287\s\src\vm\excep.cpp @ 8458 + d
coreclr!JIT_RngChkFail+6c     000001a3`e31ba7f8     00007ff8`2ca23d48     80000000`00000000     00007ff8`2ce99f29   e:\a\_work\287\s\src\vm\jithelpers.cpp @ 4912 + a
System_Private_CoreLib+934331     000001a3`dc3dc070     00007ff8`2ced6030     0000000a`ec2ff560     00000000`00000000
System_Private_CoreLib+933ac1     000001a3`dc4c90f0     00000000`08000000     000001a3`dc3dc070     000001a3`de44beb0
System_Private_CoreLib+849457     000001a3`dd9960c8     00000000`00000003     00007ff8`2cb5a9c0     00000000`00000000
coreclr!FastCallFinalizeWorker+6     00000000`08000000     000001a3`dd9960c8     00009d66`624d560e     00007ff8`2ce4e421   E:\A\_work\287\s\src\vm\amd64\CallDescrWorkerAMD64.asm @ 27
coreclr!MethodTable::CallFinalizer+af     000001a3`dd9960c8     000001a3`dbabf8b0     00007ff8`2cb5a9c0     000001a3`dd9960c8   e:\a\_work\287\s\src\vm\methodtable.cpp @ 3991
coreclr!CallFinalizer+3f     00000000`00000409     0000000a`ec2ff689     000001a3`dbabf8b0     00007ff8`2ce4a6c9   e:\a\_work\287\s\src\vm\finalizerthread.cpp @ 108
coreclr!FinalizerThread::DoOneFinalization+9b     000001a3`dd9960c8     00000000`00000409     00000000`00000001     00007ff8`2ce4b64f   e:\a\_work\287\s\src\vm\finalizerthread.cpp @ 180 + 8
coreclr!FinalizerThread::FinalizeAllObjects+c2     000001a3`dba85490     000001a3`dba85490     000001a3`dba85490     000001a3`dbaad740   e:\a\_work\287\s\src\vm\finalizerthread.cpp @ 277
coreclr!FinalizerThread::FinalizerThreadWorker+bf     0000000a`ec2ff8b0     000001a3`dbab9820     0000000a`ec2ffb00     000001a3`dba85490   e:\a\_work\287\s\src\vm\finalizerthread.cpp @ 635
coreclr!ManagedThreadBase_DispatchMiddle+192     00000000`00000000     00007ff8`2ce545b9     00000000`001fa590     00007ff8`2cdbc3b4   e:\a\_work\287\s\src\vm\threads.cpp @ 8901 + 3b
coreclr!ManagedThreadBase_DispatchOuter+af     000003f4`00000001     80000000`00000000     000001a3`dba85490     0000000a`ec2ffb00   e:\a\_work\287\s\src\vm\threads.cpp @ 9140
coreclr!FinalizerThread::FinalizerThreadStart+d0     00000000`00000000     00000000`00000000     00000000`00000000     00000000`00000000   e:\a\_work\287\s\src\vm\finalizerthread.cpp @ 769
coreclr!Thread::intermediateThreadProc+8a     00000000`00000000     00000000`00000000     00000000`00000000     00000000`00000000   e:\a\_work\287\s\src\vm\threads.cpp @ 2255
kernel32!BaseThreadInitThunk+14     00000000`00000000     00000000`00000000     00000000`00000000     00000000`00000000
ntdll!RtlUserThreadStart+21     00000000`00000000     00000000`00000000     00000000`00000000     00000000`00000000

**Exception Information**
In apppp__PID__2960__Date__03_21_2019__Time_04_29_09PM__323__First chance exception 0XE0434352.dmp the assembly instruction at KERNELBASE!RaiseException+68 in C:\Windows\System32\KERNELBASE.dll from Microsoft Corporation has caused a CLR Exception on thread 5

**Module Information**
Image Name: C:\Windows\System32\KERNELBASE.dll   Symbol Type:  PDB
Base address: 0x00000003`00905a4d   Time Stamp:  Wed Mar 06 07:02:22 2019
Checksum: 0x00000000`00000000   Comments:
COM DLL: False   Company Name:  Microsoft Corporation
ISAPIExtension: False   File Description:  Windows NT BASE API Client DLL
ISAPIFilter: False   File Version:  10.0.14393.2848 (rs1_release.190305-1856)
Managed DLL: False   Internal Name:  Kernelbase.dll
VB DLL: False   Legal Copyright:  © Microsoft Corporation. All rights reserved.
Loaded Image Name:  KERNELBASE.dll   Legal Trademarks:
Mapped Image Name:  c:\symcache\KERNELBASE.dll\5C7F626E21d000\KERNELBASE.dll   Original filename:  Kernelbase.dll
Module name:  KERNELBASE   Private Build:
Single Threaded:  False   Product Name:  Microsoft® Windows® Operating System
Module Size:  2.11 MBytes   Product Version:  10.0.14393.2848
Symbol File Name:  c:\symcache\kernelbase.pdb\E26F9607943644BB8CDE6C806006A3F01\kernelbase.pdb   Special Build:  &

Additional context
dotnet --info:
Host (useful for support):
  Version: 2.2.3
  Commit:  6b8ad509b6

.NET Core SDKs installed:
  No SDKs were found.

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

Packages used:
    <PackageReference Include="Microsoft.AspNetCore" Version="2.2.0" />
    <PackageReference Include="Microsoft.AspNetCore.Hosting" Version="2.2.0" />
    <PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.2.0" />
    <PackageReference Include="Microsoft.AspNetCore.Hosting.WindowsServices" Version="2.2.0" />
    <PackageReference Include="Microsoft.AspNetCore.ResponseCompression" Version="2.2.0" />
    <PackageReference Include="Microsoft.AspNetCore.Routing" Version="2.2.2" />
    <PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.2.0" />
    <PackageReference Include="Microsoft.AspNetCore.Server.Kestrel.Https" Version="2.2.0" />
    <PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="2.2.0" />
    <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.2.0" />
    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="2.2.0" />
    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.2.0" />
    <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="2.2.0" />
    <PackageReference Include="Microsoft.Extensions.Logging.EventLog" Version="2.2.0" />
    <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="2.2.0" />
    <PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="1.2.2" />
    <PackageReference Include="Microsoft.Windows.Compatibility" Version="2.0.1" />
    <PackageReference Include="System.IO.Compression" Version="4.3.0" />
    <PackageReference Include="System.Net.Http" Version="4.3.4" />

If you have a minidump please pop it on OneDrive / Google Drive / etc. and email a link to levib at microsoft dot com. (Don't post it here.) We'll take a look. Thanks!

Done. Thank you

@intelli9 Do you have any custom classes in your project that have finalizers? In particular, it looks like the finalizer thread is crashing due to an index out of bounds exception when trying to read from an int[]. I'm looking through some finalizable types that ship with the framework but I don't yet see anything that matches the codegen pattern included in the dump you provided.

Was able to load full dump in Visual Studio to access a context.
It seems exception is related to TLS implementation:
KERNELBASE.dll!00007fff1dcb4078()
[Managed to Native Transition]
System.Private.CoreLib.dll!System.Buffers.TlsOverPerCoreLockedStacksArrayPool<byte>.PerCoreLockedStacks.Trim(uint tickCount, int id, System.Buffers.TlsOverPerCoreLockedStacksArrayPool<byte>.MemoryPressure pressure, int[] bucketSizes) Line 380
	at E:\A\_work\287\s\src\mscorlib\shared\System\Buffers\TlsOverPerCoreLockedStacksArrayPool.cs(380)
System.Private.CoreLib.dll!System.Buffers.TlsOverPerCoreLockedStacksArrayPool<byte>.Trim() Line 235
	at E:\A\_work\287\s\src\mscorlib\shared\System\Buffers\TlsOverPerCoreLockedStacksArrayPool.cs(235)
System.Private.CoreLib.dll!System.Gen2GcCallback.~Gen2GcCallback() Line 58
	at E:\A\_work\287\s\src\mscorlib\shared\System\Gen2GcCallback.cs(58)
[Native to Managed Transition]
kernel32.dll!00007fff204e84d4()
ntdll.dll!00007fff20a7e851()

And int[] bucketSizes array with no checks in TlsOverPerCoreLockedStacksArrayPool:
            public bool Trim(uint tickCount, int id, MemoryPressure pressure, int[] bucketSizes)
            {
                LockedStack[] stacks = _perCoreStacks;
                for (int i = 0; i < stacks.Length; i++)
                {
                    stacks[i].Trim(tickCount, id, pressure, bucketSizes[i]);
                }
                return true;
            }

Sent you more details along with a latest dump.

Found something.
Look here:
    public TlsOverPerCoreLockedStacksArrayPool()
    {
      int[] numArray = new int[17]; // 17? What does it mean?
      for (int binIndex = 0; binIndex < numArray.Length; ++binIndex)
        numArray[binIndex] = Utilities.GetMaxSizeForBucket(binIndex);
      this._bucketArraySizes = numArray;
    }

And here:
      public PerCoreLockedStacks()
      {
        TlsOverPerCoreLockedStacksArrayPool<T>.LockedStack[] lockedStackArray = new TlsOverPerCoreLockedStacksArrayPool<T>.LockedStack[Math.Min(Environment.ProcessorCount, 64)]; // I have 32 cores
        for (int index = 0; index < lockedStackArray.Length; ++index)
          lockedStackArray[index] = new TlsOverPerCoreLockedStacksArrayPool<T>.LockedStack();
        this._perCoreStacks = lockedStackArray;
      }

Ta-da:
      public bool Trim(
        uint tickCount,
        int id,
        TlsOverPerCoreLockedStacksArrayPool<T>.MemoryPressure pressure,
        int[] bucketSizes)
      {
        TlsOverPerCoreLockedStacksArrayPool<T>.LockedStack[] perCoreStacks = this._perCoreStacks; // array of 32
        for (int index = 0; index < perCoreStacks.Length; ++index)
          perCoreStacks[index].Trim(tickCount, id, pressure, bucketSizes[index]); //--- While bucketSizes is still int[17]
        return true;
      }

Reduced CPU cores to 16. Looks like it works now.
Can't find that code in CoreCLR repository. It seems it has been fixed. Otherwise the issue should be moved/recreated there.

/cc @stephentoub

Is this different from the issue fixed in https://github.com/dotnet/coreclr/pull/20932?

@stephentoub Don't know how I missed it but now I see it's fixed. Both arrays are of 17 now.
Just one difference to what discussed in original issue: in my case the bug was causing an app crash :(

in my case the bug was causing an app crash

That's very strange.  The exception would be coming from L58 here:
https://github.com/dotnet/coreclr/blob/f82c75d8cd0072156c8c6372915f2c4a34a8d237/src/mscorlib/shared/System/Gen2GcCallback.cs#L56-L67
which is confirmed by your call stack above, and that's within a catch block that eats all exceptions.

@stephentoub you may look a second issue then. Exception is like handled there too.
Or I'm just completely wrong and dumps I made all point to wrong places

Exception is like handled there too.

Sorry, I'm not following; that's not coming from the same place and wouldn't be surrounded by the same catch block.  Can you clarify?

Sure not. I meant thrown exception is also catched higher by stack there.

I meant thrown exception is also catched higher by stack there.

Where in the stack do you believe there's a catch that eats the exception?

Sorry I believe I saw it when walking over stack.
Now I tracked it down by referencesource site and stopped here without any signs of handling:
https://referencesource.microsoft.com/#system/net/System/Net/SecureProtocols/SslStream.cs,296
        public virtual Task AuthenticateAsServerAsync(X509Certificate serverCertificate, bool clientCertificateRequired, SslProtocols enabledSslProtocols, bool checkCertificateRevocation)
        {
            return Task.Factory.FromAsync((callback, state) => BeginAuthenticateAsServer(serverCertificate, clientCertificateRequired, enabledSslProtocols, checkCertificateRevocation, callback, state), EndAuthenticateAsServer, null);
        }

Anyway its a subject of this issue: https://github.com/aspnet/AspNetCore/issues/8740


Remove duplicate tests in CI.

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

With this latest modification, it will work correctly by eliminating double flows for pull requests. Additionally, it runs the flows in the fork, and only pushes to the master branch.
This should cut the number of workers and test time in half.

@terabytesoftw can we merge it or does it require more work?

@terabytesoftw can we merge it or does it require more work?

Let's wait better, try it some more.

@terabytesoftw enough time passed?

After reviewing well, it is not necessary, all the PR in Yii2 come from a fork, so it is not a problem.

I'm wandering, can we only execute ci-node on js changed
a job intermittently failed<PHONE_NUMBER>7 while I'm not changing js #20007


Sennet 47 - Create pyunit tests for search adaptor

Run the tests with the command pytest ./test --es_url <AWS_ES_DEV_URL>

We're going to move the testing into the Search API.


[Enhancement] Improve regexp replace use hyperscan for constant pattern

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Problem Summary(Required) ：

Because switching between greedy and non-greedy semantics is a no-op in Hyperscan, so we must test every match for pattern with wildcard, that maybe causing performance degradation.
This improve performance for regexp_replace with pattern without wildcard through hyperscan.
Checklist:
The count of test_all_type_select0_regexp is 4000000, and there are 2000000 lines for id_varchar = 'foaaoxyaabarbaaa'/'foaaoxyaabarbaaaaaaaaaaaa'.


Styles issues since Polymer 1.7

Hi,
Since Polymer 1.7, some of the styles defined in nvd3-shared-styles do
not apply anymore.
To reproduce, run bower update in the nvd3-elements repo,
then polyserve and go to
http://localhost:8080/components/nvd3-elements/demo/nvd3-line.html
The rule that do not apply and that makes the demo look weird is :
Line 289
      :root svg.nvd3-svg {
        ...
        width: 100%;
        height: 100%;
      }

I think this rule do not apply because nvd3-shared-styles is used in a
document level custom-style in nvd3-behavior.html :
<style is="custom-style" include="nvd3-shared-styles"></style>

From the doc https://www.polymer-project.org/1.0/docs/devguide/styling#custom-style :

Document styles defined in a custom-style are shimmed to ensure
they do not leak into local DOM when running on browsers without
native Shadow DOM.

The svg element is in the local DOM, so it seems normal that the rule
does not apply (even though it was working before 1.7).
Other css rules seem to work, because they apply on elements added
to the DOM by nvd3, so not under the control of Polymer shady DOM polyfill
(none of these elements have the style-scope class), but this is not something
we should rely on.
Also, using document level styles rules is probably the cause of issue #11,
because styles really do not leak into the local DOM from above under shadow DOM.
I think using scoped styles is the path to solve this issue.
I wrote a PR to achieve this and everything seems to work with shady
and shadow DOM. Basically, I've included nvd3-shared-styles in every element
local DOM style, and rewritten the CSS rules to target the local DOM.
One problem though is the styling of the tooltip.
nvd3 adds the tooltip div at the end of the body, so it still need document
level styling.
I've tried to make clear my findings, but I'm still confused with
all these DOM (shadow/shady/local/light) things. So don't hesitate to correct me
if I wrote something wrong.

I've tested the PR. It works fine. Thanks for the effort.

It also fixed #11.


Use latest azure-pipelines-tasks-webdeployment-common version for pipeline tasks

Task name: AzurePipelineTasks
Description: Use latest azure-pipelines-tasks-webdeployment-common for pipeline tasks
**Documentation changes required:**N
Added unit tests: N
Attached related issue: https://github.com/microsoft/azure-pipelines-tasks/issues/20168
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

Tasks for sprint 243 have already been released: https://github.com/microsoft/azure-pipelines-tasks/releases/tag/v243, I think we should bump the versions to 244

@aleksandrlevochkin tried to bump the version to 244, but after doing build tasks were automatically bumping to 243 and latest patch version.

@nagarajku As a workaround you can manually set the 244 version in the _generated/{Task_Name}.versionmap.txt file and then run the build command

@nagarajku As a workaround you can manually set the 244 version in the _generated/{Task_Name}.versionmap.txt file and then run the build command

@aleksandrlevochkin made the changes and did a commit

Please, bump the task version in task/task.loc files for AzureFunctionAppV2

I have bumped the version in the recent commits

/azp run


Worker kill on style recompile

Process Process-1:
Traceback (most recent call last):
  File "/usr/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/usr/lib/python3.8/multiprocessing/process.py", line 108, in run
   self._target(*self._args, **self._kwargs)
 File "/home/monika/metaworkspace/env/lib/python3.8/site-packages/metaworkspace/runtime/processing/runners.py", line 23, in JobWorker
    job = load_job(job_dir)
  File "/home/monika/metaworkspace/env/lib/python3.8/site-packages/metaworkspace/runtime/processing/loader.py", line 35, in load_job
    with open(jobfile, 'r') as job_file:
FileNotFoundError: [Errno 2] No such file or directory: '/home/monika/metaworkspace/workspace/jobs/55067c4f-195d-4b23-bea4-9d726780f86e/job.json'

Probably race condition between file writes/reads

Workspace issue, not related to this repo, closing.


Version for datastore 1.1.0

DataStore 1.1.0 contains breaking changes:

Exposed PreferencesSerializer, previously it was internal
Library is multiplatform now, so it may require changes on my side

Any plans on updating this for 1.1.0?

Yes, I plan to finish this before datastore goes into beta

datastore:1.1.0-beta01 is out

Ouch. datastore 1.1.0 is already here.

Version 1.1.1-beta01 is out. With datastore 1.1.1 as a dependency.


Add full support for ec2::Subnet

As far as I see at the moment subnet information is loaded only from referring objects, the full subnet information is not available in the database, which means that vpcid, cidrblock and other interesting parameters are missing.
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_Subnet.html
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html?highlight=describe_subnets#EC2.Client.describe_subnets
I might give a try implementing it, but would be so nice not to deep dive from scratch, maybe it is alredy in the queue somewhere.

Thanks for making note of this. If you want to work on this we can help, say hi in Slack :-).

Hi, a raised a few topics on Slack the core of the new functionality is there on my dev instance.

Fixed with https://github.com/lyft/cartography/pull/401


On mobile, filter popup is hidden under controls

Reported by @RalfStrandell
Make difficult to set source, for instance.

I think we are fine with this. now,


Support timezone configuration

Thanks for making this extension 🙌
I have a feature request. Our dashboards are in UTC timezone, but I believe this extension converts millisecond epoch to local timezone. It would be great if we can add a config option to set global (for all apps) or app-specific timezone so the UI will show time in a configured timezone

@jumbosushi  Thanks for the good suggestion!
It certainly seems useful if we work based on a different timezone than local timezone. I will include such a feature in the next update :+1:

The feature for this issue is implemented at #2 and released at v1.1.0. (also available in Chrome Web Store)
Feel free to let me know if you have any additional requests!


Allow setting custom data on autotracked pageviews via data attribute on script element

This would allow setting custom data, like Plausible allows with what they call "Custom Properties".
This is very useful to track how much people are on e.g. a version, how much people use the dark theme, how much pageviews are from logged-in users, etc.
An example of what it looks like in the dashboard:

I added a way to show those custom fields on a website's dashboard. I also excluded pageview custom data from the custom data tab, since it doesn't make much sense and would pollute that tab with lots of events.
For now you can add these custom data tables on the dashboard via the URL: ?fields=comma,separated,field,of,event-keys
I'll add a selector in the UI but it requires much more changes

very cool feature, will this be merged soon?

@timomayer if you want to use it right away, I've been using my fork in production for a few weeks now with no issues.
The annoying thing is that there's nothing in the UI yet to actually choose what custom properties to show, you have to pass them via the query parameter.
And also there are some places where you would expect custom properties to show up (e.g. on reports, etc.) but they only appear on the dashboard for now, and you also can't filter by a custom property's value. It's rudimentary but this is still better than Plausible, that outright denies access to this feature on self-hosted instances.

PRs are usually made against the dev branch. You are doing it against the master branch directly, if I am not mistaken, despite it being the default branch you should change your PR against dev.

Any update?


templateResult does not create needed [aria-selected] attributes (4.0)

When I use a custom templateResult function I get lists containing elements like:

Without the custom templateResult function I get lists like this:

Much of the actual functionality seems to require a selection of [aria-selected] to differentiate between the options and other placeholder  elements, so unfortunately the custom formatter does not seem to work.
Any suggestions on workarounds?

I can't reproduce this, we're going to need a jsbin/jsfiddle that reproduces the issue.
The templating example (along with the AJAX one) doesn't have this issue: https://select2.github.io/examples.html#templating
It also doesn't make sense considering the aria-selected attributes are applied at a different time than the templating methods.

Can you expand upon the issue you are facing by adding a few more pieces of information to your bug report?

What steps can be used to reproduce the issue?
What is the bug and what is the expected outcome?
What browser(s) and Operating System have you tested with?
Does the bug happen consistently across all tested browsers?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

The contributing guide contains a useful section with a few questions which can help us track down the bug and speed up the process of finding a fix for it.  The creation of an isolated test case would also be useful.

Hi Kevin, thanks for getting back so soon. I'll work on a JSFiddle. I was able to get around the issue by moving back to the 'id' and 'text' attributes as opposed to trying to roll with something else, I assume this is somehow involved.

Not using the id attribute would cause the aria-selected attribute to not be set.
https://select2.github.io/announcements-4.0.html#changed-id

Makes sense. Exactly what I ended up doing. Thanks for following up

Patrick


Upgrade Workbench for GCW to 2023.09.1

Closes #670

I tested all session types and running apps and found no show-stoppers. This change looked good to me.


Peek error: error: Module not found .../public/main.bundle.js

Describe the bug
I have followed the instructions provided in the repository to install the plugin.

Installed deno binary from the website first
Installed the plugin using lazy.nvim package manager
The build part of the command deno task --quiet build:fast fails with an error:

error: Node specifiers have not yet been implemented for this subcommand (https://github.com/denoland/deno/issues/15960). Found: node:punycode

Steps To Reproduce

Open NeoVim instance and a markdown file
Execute :lua require('peek').open() command, which throws an error:

Peek error: error: Module not found "file:///home/kenja/.local/share/nvim/lazy/peek.nvim/public/main.bundle.js".

Expected behavior
A markdown preview should open when :lua require('peek').open() is executed
Desktop (please complete the following information):

OS: Ubuntu
nvim --version:

NVIM v0.10.0-dev
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

deno --version:

deno 1.34.2 (release, x86_64-unknown-linux-gnu)
v8 <IP_ADDRESS>
typescript 5.0.4

plugin setup:

require('peek').setup()

Additional context
Similar issues were noted in #11, #28 and #46
Workarounds (manual installation) provided in these issues failed with the same error above error: Node specifiers ...

Exactly the same environment and same problem. Did the same workarounds and got the same errors

I have the exact same issue, but I installed it using Packer.
After playing around with different deno versions, I got a better error message (with deno v1.25.0):
error: Remote modules are not allowed to import local modules. Consider using a dynamic import instead.
  Importing: node:punycode
    at https://esm.sh/v125/markdown-it@13.0.1/denonext/markdown-it.mjs:2:328

Only main.ts doesn't compile, the other targets are fine.
This is my first time working with deno so I don't really know how to fix this.
Maybe the installer script should use a different command to bundle src/main.ts since deno bundle is deprecated?
I tried building main.ts with esbuild app/src/main.ts --bundle --outdir=public, which then produces public/main.js.
So you have to also change the run command in deno.json.
This script then had a problem requiring some package dynamically.
Maybe this will help someone figure out a solution.

I replaced the bundling process with deno_emit. This works nice.
I will replace all other bundlings with this also and open a PR. In the meantime you can try my version here: https://github.com/cloudsftp/peek.nvim/tree/bundle

I am trying to use your version, @cloudsftp ,  I still get the same error. Am I doing something wrong?

@fengzhiken Unfortunately, my version only works with older versions of deno. Refer to the pull request, I linked.

same problem, env as follow
[dogqizi@MacDog lua (lazyvim ✗)]❱❱❱ nvim --version
NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3

     系统 vimrc 文件: "$VIM/sysinit.vim"
         $VIM 预设值: "/opt/homebrew/Cellar/neovim/0.9.1/share/nvim"

Run :checkhealth for more info
[dogqizi@MacDog lua (lazyvim ✗)]❱❱❱ deno --version
deno 1.34.3 (release, aarch64-apple-darwin)
v8 <IP_ADDRESS>
typescript 5.0.4

facing the same problem when I'm trying out this tool, in the meantime, I think u guys can try this markdown preview tool

facing the same problem when I'm trying out this tool, in the meantime, I think u guys can try this markdown preview tool

This plugin is laggin with puml. Periodically raise strange exceptions when code is ok

Same problem in NixOS.

Can confirm the tweaks at #50 fix the issue :+1:

I had the same problem and implemented the four lines from the PR @pabloqpacin recommended. Ran a fresh deno task --quiet build and peek is now working as expected.

Can also confirm that @pabloqpacin fix works ! Used @john-kenealy's comment above 👍

I had this issue as well, but using @saimo PR and then fresh deno build solve the issue.

@toppair Could you please check the mentioned PR and merge it? There have been multiple confirmations already about the PR fixing this issue.


consider non-default base domains

Handle installations where base domain is custom
Checklist

[ ] Update changelog in CHANGELOG.md.

Changelog is missing btw.

Changelog is missing btw.

it's just a fix on a feature that is already mentioned in the changelog


-Tag won't seem to allow zooming in Modal Dialogs

So I have run into a very strange problem. While having set everything to have it scrollable, as well as only using percentage-values, my modal dialog won't allow me to zoom in with a finger pinch.
I also took a look at the meta tags in my index.html and they seem to be fine, and my CSS is not of fault either, I think.
I will link to my code in case someone could take a look at it -> http://cloud.novalos.net/index.php/s/vo8A7YtNMz5kHVn
The file causing that problem is "displayDetailImage.html" in the templates-folder, and I do assume that this might be a bug in Ionic using modal template views?

@Z3roCoder hi, did you find anything to make zooming work in a modal window ? I ran into the same issue and absolutely need to be able to pinch to zoom on that modal.

This issue was moved to driftyco/ionic-v1#189


fix: use Hashicorp random provider in ~> 3.4 version

Description
In examples and modules there were changes in version of random provider. On M1 based machines there was an error, if provider in version lower than 3.1.0 was used, because there is no such release for darwin/arm64.
Motivation and Context
PR resolves issue #157.
How Has This Been Tested?
Changes were tested on local machine by deploying examples/vmseries.
Screenshots (if appropriate)
While using older version of random provider on M1 based machine, there was an error:
│ Error: Failed to query available provider packages
│
│ Could not retrieve the list of available versions for provider hashicorp/random: no available releases match the given constraints < 3.0.0, ~> 3.1

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[x] All new and existing tests passed.

Overall good work! Check this PR #182 we relax a bit minor version there and we get rid of version in examples.

thank you . It that case I'm only upgrading version of random provider to ~> 3.4.
Thanks for informing about #182 and removed versions from examples.


Update BDC deployment min azdata version

Pull Request Test Coverage Report for Build 322725945

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.739%

Totals

Change from base Build 322680538:
0.0%

Covered Lines:
20533

Relevant Lines:
47406

💛  - Coveralls


Implement np.shape for nestedarray

Feature request
numba currently (0.54.1) doesn't implement np.shape for nestedarrays from numpy record types. Support for this would simplify some generic code a little bit.
import numba
import numpy as np

dtype = np.dtype([
    ("a", np.float64, (10,))
])

data = np.zeros((), dtype=dtype)[()]

@numba.njit
def foo(data):
    #return data.a.shape  # this works
    return np.shape(data.a)

foo(data)  # Throws a TypeError

TypingError: Failed in nopython mode pipeline (step: nopython frontend)
No implementation of function Function(<function shape at 0x7fb0b028e430>) found for signature:

 >>> shape(nestedarray(float64, (10,)))

There are 2 candidate implementations:
  - Of which 2 did not match due to:
  Overload in function 'np_shape': File: numba/np/arrayobj.py: Line 1981.
    With argument(s): '(nestedarray(float64, (10,)))':
   Rejected as the implementation raised a specific error:
     TypingError: Failed in nopython mode pipeline (step: nopython frontend)
   No implementation of function Function(<function asarray at 0x7fb0b026a040>) found for signature:

    >>> asarray(nestedarray(float64, (10,)))

   There are 2 candidate implementations:
         - Of which 2 did not match due to:
         Overload in function 'np_asarray': File: numba/np/arraymath.py: Line 4196.
           With argument(s): '(nestedarray(float64, (10,)))':
          Rejected as the implementation raised a specific error:
            LoweringError: Failed in nopython mode pipeline (step: native lowering)
          Can only insert double at [0] in [10 x double]: got i8*

          File "../../../miniconda3/envs/aesara-numba/lib/python3.9/site-packages/numba/np/arraymath.py", line 4208:
                      def impl(a, dtype=None):
                          return a
                          ^

          During: lowering "return $4return_value.1" at /home/anna/miniconda3/envs/aesara-numba/lib/python3.9/site-packages/numba/np/arraymath.py (4208)
     raised from /home/anna/miniconda3/envs/aesara-numba/lib/python3.9/site-packages/numba/core/errors.py:786

   During: resolving callee type: Function(<function asarray at 0x7fb0b026a040>)
   During: typing of call at /home/anna/miniconda3/envs/aesara-numba/lib/python3.9/site-packages/numba/np/arrayobj.py (1987)

   File "../../../miniconda3/envs/aesara-numba/lib/python3.9/site-packages/numba/np/arrayobj.py", line 1987:
       def impl(a):
           return np.asarray(a).shape
           ^

  raised from /home/anna/miniconda3/envs/aesara-numba/lib/python3.9/site-packages/numba/core/typeinfer.py:1074

During: resolving callee type: Function(<function shape at 0x7fb0b028e430>)
During: typing of call at /tmp/ipykernel_17638/1962980170.py (14)

File "../../../../../tmp/ipykernel_17638/1962980170.py", line 14:
<source missing, REPL/exec in use?>

Alsp, Numba should also not have triggered the error from:
  File "/root/miniconda3/envs/numba_dev/lib/python3.9/site-packages/llvmlite/ir/builder.py", line 980, in insert_value
    instr = instructions.InsertValue(self.block, agg, value, idx, name=name)
  File "/root/miniconda3/envs/numba_dev/lib/python3.9/site-packages/llvmlite/ir/instructions.py", line 660, in __init__
    raise TypeError("Can only insert %s at %r in %s: got %s"
TypeError: Can only insert double at [0] in [10 x double]: got i8*

I wonder if https://github.com/numba/numba/pull/7359 fixes this

With #7359, the following:
import numba
import numpy as np

dtype = np.dtype([
    ("a", np.float64, (10,))
])

data = np.zeros((), dtype=dtype)[()]

@numba.njit
def foo(data):
    return np.shape(data.a)

print(foo(data))

prints
(10,)

So I think this will be resolved by #7359.

@astoeriko Are there any similar use cases that ought to be checked? Can you try with #7359 and check if it works for all your intended use cases?

So I think this will be resolved by #7359.

That sounds great, thanks for testing! I wanted to test it for a while but did not actually get around to do so.

Are there any similar use cases that ought to be checked? Can you try with #7359 and check if it works for all your intended use cases?

I will try with my use cases and get back to you.


Transient error in 'mri_deface' results in full crashout

This might have been resolved with the move from bidsconvert.sh to full python, but a transient error in mri_deface appears to result in the workflow ending prematurely on v0.0.2.

Can we edit run so that it prints out the actual error message?


Triplicate Functionality on screen

I am seeing triple versions of many things on the screen

The Fitness Trend droplist (note two are version 6.0.0 and one is 5.13.0)
The Show Extended Stats
Remote Views, Relive and Weather

I am using Chrome Version 63.0.3239.132
https://www.strava.com/athletes/190502

You probably tested v6.0.0 along side 5.13.0. Like written in install guide i provided to you https://github.com/thomaschampagne/stravistix/wiki/How-to-install-stravistix-build-archive

Disable the official StravistiX for Strava extension (if you use it in your chrome) to avoid any conflicts with the version you are installing now.


Add example usage of deploying the cloud-controller-manager on GCE

When this PR is merged https://github.com/kubernetes/kubernetes/pull/44258
cc @wlan0

@luxas what about other clouds? Or is the scope of this project restricted to GCE?

No restrictions here, all clouds welcome :)
However, at the moment I have only set up my env for testing this on GCE. If you could test on AWS, it would be awesome!


[Bug] Checkbox border color is not correct

🕵 Is there an existing issue for this?

[X] I have searched the existing issues

What version of spark are you using?
1.0.0
🐛 What happened?
The color of the checkbox is not correct.
### Expected
✅ It should be grey as in web: https://sparkui.vercel.app/?path=/docs/components-checkbox--docs#usage

Problem
🚨 But it's black
https://github.com/adevinta/spark-android/assets/23620759/7f3ee7fd-814b-4536-9363-085eeb1ed994
Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

After reviewing it with @turolopezsanabria We'll stay with the current version where the enabled unchecked checkbox is black as changing it to outline breaks state hierarchy


[bug] Ingesting SBOMs results in license error

Describe the bug
When ingesting some SBOMs we sometimes encounter the error:
{"level":"error","ts":1726087820.935968,"caller":"collector/collector.go:108","msg":"emit error: unable to ingest document: error assembling graphs for \"file:///cdx_guac.json\" : ingestLicenses failed with error: IngestLicenses failed with error: input: ingestLicenses LicenseRef name provided without inline.\n","guac-version":"v0.0.1-custom","documentHash":"sha256_37a12cc083d82a18fe3d342cb2f0121279c7c94e55860225d694caf8c5c4c85d","stacktrace":"github.com/guacsec/guac/pkg/handler/collector.Collect\n\t/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/handler/collector/collector.go:108\ngithub.com/guacsec/guac/cmd/guacone/cmd.init.func7\n\t/Users/nathannaveen/go/src/github.com/nathannaveen/guac/cmd/guacone/cmd/files.go:151\ngithub.com/spf13/cobra.(*Command).execute\n\t/Users/nathannaveen/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:989\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/Users/nathannaveen/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1117\ngithub.com/spf13/cobra.(*Command).Execute\n\t/Users/nathannaveen/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1041\ngithub.com/guacsec/guac/cmd/guacone/cmd.Execute\n\t/Users/nathannaveen/go/src/github.com/nathannaveen/guac/cmd/guacone/cmd/root.go:57\nmain.main\n\t/Users/nathannaveen/go/src/github.com/nathannaveen/guac/cmd/guacone/main.go:23\nruntime.main\n\t/Users/nathannaveen/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.6.darwin-arm64/src/runtime/proc.go:271"}

This happens with these two SBOMs:
cdx_guac.json
cdx_vuln.json
To Reproduce
Steps to reproduce the behavior:

Start up the GraphQL: go run ./cmd/guacgql --gql-debug
Then run the ingestion command go run ./cmd/guacone collect files cdx_guac.json

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

GUAC version
GUAC version: v0.8.2

@jeffmendoza and I were discussing this and have come to realize the issue. When ingesting an SPDX SBOM the licenses can be either defined via an id or a name. If the name is provided, the inline will have to be attached. But, in CycloneDX docs, when the name is provided, the inline is optional https://cyclonedx.org/docs/1.6/json/#services_items_licenses_oneOf_i0_items_license_name.
If the inline isn't provided, then we can't actually know if it is a valid license. So, we should probably not add a license node if the license is defined via a name and the inline isn't provided.

Hey @nathannaveen
I ran into the same issue and dived deeper after checking your comment. It seems for licenses that don't have neither the text field (this is what I assume "inline" means), nor the bom-ref field, the CycloneDX parser just returns hash of the license name without adding any corresponding inline entry for it in the parser.
Would it make sense to remove the else block to fall back to the license ID for these cases?

If the inline isn't provided, then we can't actually know if it is a valid license. So, we should probably not add a license node if the license is defined via a name and the inline isn't provided.

@jeffmendoza  Based on the discussion, we do not add a license node but do we still keep them part of the license expression strings?

Based on maintainer call:
If the inline isn't provided, then we can't actually know if it is a valid license. So, we should NOT add a license node if the license is defined via a name and the inline isn't provided but but we DO still keep them part of the license expression

I retract my earlier comment after discussion in today's Maintainer Meeting. I misunderstood the shape of the problem, but I'm going to leave the comment there for posterity because there are some points worth preserving. My main concern with ignoring it is if there are several packages that use "Ben's Cool License", people won't be able to search for it. But that's going to be ambiguous and edge-case-y enough to not try to solve right now.

Have you considered using https://scancode-licensedb.aboutcode.org/ as reference dataset? This is the largest such db this side of the galactic quadrant. (And unfortunately dumbed down in ClearlyDefined scan merges when reported by ScanCode there)

@pombredanne ah very interesting! This would be great to integrate into GUAC as another data point for licenses

@funnelfiasco  re:

There's also the question of "what is a valid license?" If I released some software under the Permissive 3000 license that I wrote (translated?), it's not in SPDX nor is it OSI-approved, but it's certainly a valid license in the sense that it does what licenses are supposed to do.

If this exists and is used, this is a valid license alright in my book. OSI and SPDX have nothing to do with the existence of a license, they are rather helping clarify and catrgorize these licenses.
As far the Permissive 3000 license, this is a fine license but it sees little actual usage, so we track it only as the text of a generic, permissive license in ScanCode at https://github.com/aboutcode-org/scancode-toolkit/blame/9a340fc36b971bcc04fdf255ee73bf88ce39635a/src/licensedcode/data/rules/other-permissive_210.RULE#L12  ... most occurrences in the wild are found in ScanCode forks https://github.com/search?q="list+of+conditions+and+the+following+refusal+of+responsibility."&type=code ;)
In the guac context, you should IMHO always track whatever is the asserted license you receive as-is. And if you are lucky, this is correct. It is going to be inaccurate and creative in some (or many) cases as many (or most) SBOM tools do something between a poor and a bad job to report licensing.
I'd suggest that you can enrich this after the fact with correct data from a ScanCode scans (either directly, recommended) or retrieved from PurlDB or raw from ClearlyDefined.

And as for gettings things from ClearlyDefined, I'd focus on the raw "harvest" as we do here https://github.com/aboutcode-org/purldb/blob/main/clearcode/

Fixed by https://github.com/guacsec/guac/pull/2164


Switch to embedded-hal version 1.0

Embedded-hal has hit a RC and is looking for final feedback. It may be worth starting to port the EspressIf crates to help locate any flaws before the final release happens.
See https://github.com/rust-embedded/embedded-hal/issues/177#issuecomment-1805300873

this crate already supports e-hal 1.0 rc 1 as well as e-hal 0.2

Oh, I never noticed the feature. Thanks


Pedestrian detector

i have trained a pedestrian detector with INRIA dataset can be found at https://github.com/sturkmen72/dlib_pedestrian_detection
i will share some more information about how to train it soon on the github repo.
many thanks for @davisking for the great library.

Sweet :)   Feel free to add this to the dlib users wiki.

Hi there, thanks for this. Very new to dlib. Right now, I am using the face detect data library as such:
dlib::shape_predictor sp;
dlib::deserialize( "./shape_predictor_68_face_landmarks.dat" ) >> sp;

How does one go about using your contribution for pedestrian detection?

I've been trying to train a pedestrian detector using INRIA dataset as well. The training procedure seems to go fine. But I'm not able to detect anything even on the trained data. Does annotation have to do anything with it? Also how does merging the pictures help?

can i see your training.xml

https://github.com/tej06/dlib-pedestrian-detection/blob/master/training.xml

using INRIA's annotation information to create such training.xml is possible.
how much time did you spend to do it?

I wrote a python snippet to extract the information from the INRIA's annotation information. It took me somewhere around 15 to 20 mins. That had an issue where some annotations were not fine. So i annotated them again using imglab. My problem is that after training my percentage of detection is 0.

i found the code i used before to generate annotation file and generated four files. you can find them at https://github.com/sturkmen72/dlib_pedestrian_detection/tree/master/INRIA
i was planning to try creating a detector but did not find some free time yet

Thanks a lot:) I'll train the detector with this.
How does overlapping annotations affect the training procedure?

as i said i did not try yet. i am not too experienced in this field.

what is your purpose to train a pedestrian detector?

It's a part of a project I'm working on.

did you try OpenCV's HOGDecsriptor ?

Yes I did. It works well. But it's a bit fickle. Even with NMS it behaves erratically for video streams. I'm trying to achieve a better detection using DLib. If this doesn't work out I'll resort to OpenCV's HOGDescriptor.

As I recall, INRIA doesn't label all the people in each image.  That's why it's not working.  There is also an issue of excessively tight cropping which is far from ideal.  You want to train on images that look like the real testing images, not ones that are cropped in some obviously target biased way. But most importantly, the dlib training algorithm uses all non-labeled parts of the image as negatives, so if there are any people in the background it's not going to work very well and will likely learn that the lowest error behavior is to never detect anything.  This feature is why you don't need to deal with hard negative mining.  It does that for you, but it's obviously going to do something bad if the background is full of unlabeled people.

Also, this is such a common question that I just added a new FAQ for it: http://dlib.net/faq.html#WhydoesnttheobjectdetectorItrainedwork :)

Thanks a lot @davisking This sure did help a lot:)

No problem.  I should have written this FAQ answer a long time ago :/

Hi @davisking ,
I've found this closed issue and I want to share the work I've done so far with some dataset publicly available on internet: to train the pedestrian classifier, I'm usingthis one which contains some scenarios with partial occluded elements as well.
All the data from USC is shipped with ground truth data, which makes it easier to be used with dlib, therefore I've written a parser for those XML data and converted in the format supported by dlib (the same used for face_detection). If anyone is still interested, you can find the parser (written with Python 3) here: Conversion of Ground Truth data for the USC dataset.
By the way, thank you for all the efforts you put in this work!


How to multiple instance viewmodel for same compose fun

I have a list of items and a detail screen. Detail Screen is a compose function that takes a (post) parameter that I pass as an argument to the ViewModel.
       val viewModel = getStateViewModel<PostDetailViewModel>(parameters = { parametersOf(args) })
The problem is that it looks like the viewModel is cached, and all the time it opens the first post (argument) that was followed.
In jetpack navigation works correctly.
https://user-images.githubusercontent.com/27068529/129693071-ade8b0bc-1c0e-4bc0-a367-cceac22c4e53.mp4

I've just encountered exactly the same issue. Maybe it's a problem with Koin?

Are you guys using SavedStateHandle in the ViewModel? If not, it works with by viewModel()?

Nope, this is my code that is called from the Content function of my Screen
@Composable
fun SessionDetailScreen(
    archiveItem: UiArchiveItem,
    subsessionItem: UiSubSession?,
    vm: SessionDetailViewModel = getViewModel(parameters = {
        parametersOf(archiveItem, subsessionItem)
    })
) {
...

and I am using Koin for retrieving VM https://insert-koin.io/docs/reference/koin-android/compose/#viewmodel-for-composable

Since we are in the same activity the ViewModelStoreOwner is the same between screens (https://github.com/InsertKoinIO/koin/issues/1142). Internally it uses a Map<String, ViewModel>  and Koin uses the qualifier as the key. Because of that we get the same ViewModel even if the params are different.
The solution for that is to implement ViewModelStoreOwner in our screens:
class DetailsScreen(
    val id: Int
) : Screen, ViewModelStoreOwner {

    private val viewModelStore = ViewModelStore()

    override fun getViewModelStore() = viewModelStore

    @Composable
    override fun Content() {
        CompositionLocalProvider(
            LocalViewModelStoreOwner provides this
        ) {
            val viewModel = getViewModel<DetailsViewModel> { parametersOf(id) }

        }
    }
}

I'm looking for a way to integrate that on Voyager, in the meamtime you can use the above snippet as workaround.

But when I used navigation-compose from Jetpack this problem was not there. I've refactored my app to Voyager because of arguments passing and then it started. Koin should have this solved IMO, it wouldn't make sense if there would be such limitation

It works on navigation-compose because NavBackStackEntry implements ViewModelStoreOwner, so I have to do the same.
Working on that, shouldn't take long.

Just released 1.0.0-beta06 with a new module: voyager-androidx. Just replace Screen with AndroidScreen  and ViewModels should now work as expected (docs).
Closing the issue, but feel free to re-open if needed.

Works like a charm! Thanks :)

@adrielcafe Thanks for your quick help! It worked for me only without SavedStateHandle, is there a way to use it with SavedStateHandle?

@zakrodionov the ViewModel still is the same when you use the SavedStateHandle, or the SavedStateHandle content is not being saved? Can you provide a code snippet please?

@adrielcafe If I use getViewModel everything is ok. But with getStateViewModel an in-memory reference to the same viewModel. It looks like the problem is in the SavedStateRegistryOwner.

@adrielcafe Yes, it works. Thank you so much!

I am experiencing the same problem on multiplatform, but there is no AndroidScreen available, even when including cafe.adriel.voyager:voyager-androidx. Is there another way to push the same Screen twice and if so, with changed parameters as well?


Hide the BufferedSender Constructor

Hide the BufferedSender Constructor

@sarangan12 Can you add some details to the issue description here? Something around why we are doing this, is this over a preview or change over a GA package etc

Code complete with this PR: https://github.com/Azure/azure-sdk-for-js/pull/11785


[BUG] [V.11.315] the tab does not appear on Tidy sheet

Hello,
as per the title, the tab on the tidy cards does not appear while the basic D&D tab does.
Maybe it no longer works on V11 but on V12 it does? (I'm waiting at least another month before migrating).
Thanks for any solutions.

I'm on v12 but give this a try;
Go into the sheet tab selection settings here by clicking the 3 dots next to the character level:

See if Downtime appears in the available tabs section, if it does, put it on the selected tabs section.

Thanks so much, I hadn't noticed, it actually works :)


Use Lister to reduce the number of calls to api server

The related issue: https://github.com/open-cluster-management/backlog/issues/8687
Signed-off-by: Yang Le<EMAIL_ADDRESS>

/assign @qiujian16

/assign @qiujian16


Making Array and Hash coerce handle spaces better, adding Symbol

Sorry for the delay, can you add one or two tests?

I think I've got bitten by that issue?
We pass in our spec the following:
req[:orders_attributes][0][:email] =<EMAIL_ADDRESS><EMAIL_ADDRESS>
And in our controller we validate this param with a:
   order.param! :email, String

With rails_param (0.11.2) and rails 6 the coercion happens. With  rails_param (~> 1.3.0) it doesn't
Extract from pry session while running the spec:
RAILS 6

[3] pry(#<Api::ImportController>)> order.params["email"]
=><EMAIL_ADDRESS><EMAIL_ADDRESS>[4] pry(#<Api::ImportController>)>

[3] pry(#<Api::ImportController>)> order.param! :email, String
RailsParam::Param::InvalidParameterError<EMAIL_ADDRESS><EMAIL_ADDRESS>is not a valid String
from /home/foo/.bundle/ruby/3.1.0/gems/rails_param-0.11.2/lib/rails_param/param.rb:134:in `rescue in coerce'
Caused by ArgumentError: ArgumentError
from /home/foo/.bundle/ruby/3.1.0/gems/rails_param-0.11.2/lib/rails_param/param.rb:106:in `coerce'

RAILS 7 and the gem 1.3.0, the exception doesn't get raised
[1] pry(#<Api::ImportController>)> order.params["email"]
=><EMAIL_ADDRESS><EMAIL_ADDRESS>[2] pry(#<Api::ImportController>)> order.param! :email, String
=><EMAIL_ADDRESS><EMAIL_ADDRESS>[3] pry(#<Api::Las::Scc::ImportController>)>

For sure in that case I could simply validate by format, but I have more than 30 unique fails, since this is validated in many different parameters.

@vpereira this PR is completely outdated now, so I'll be closing it.
Would you mind opening a new issue instead with the same details 🙏 ?


feat: auto generate pr template eau

Description

Feature: auto-generate this template with hidden comment lines to guide developers on filling out a thoughtful description when someone opens new PRs
The motivation of writing thoughtful PR descriptions is to improve the efficiency of the review process. The idea is that the descriptions should scale accordingly to the size of PRs. This is a proposed template with some suggested pre-submission checklist that will essentially auto-generate when someone opens a new PR.
It would be great to get everyone's thoughts on this template:
Relevant Links

Markdown Basic Syntax
Create PR templates
Template Examples

Checklist before requesting a review

[x] I performed a self-review of my code
[ ] If it this a core feature, I have added thorough tests
[x] The command go fmt was used on all files
[ ] Send PR link to the #computation slack channel

Testing

Preview:
# Description
<!-- Please add a summary for this PR. Summary should scale w/ PR size!  -->

## Relevant Links
<!-- Please add any relevant links or resources, ideally links to related PRs, technical concepts or literature! -->
- [Display Text](https://www.vertgenlab.org/)

### Checklist before requesting a review

- [ ] I performed a self-review of my code
- [ ] If it this a core feature, I have added thorough tests
- [ ] The command `go fmt` was used on all files
- [ ] Send PR link to the #computation slack channel

### Testing
<!-- if relevant, document how you tested this code, and how someone else might also test it -->
None

### Screenshots & Media
<!-- if relevant, add an screenshots, images or recordings -->
None

### Edge cases / Breaking Changes / Known Issues
<!-- if relevant, document any edge cases, known issues, etc -->
None

Screenshots & Media

Here I've attached a video where I open a new PR in the web browser and the template is auto generated prior to the PR submission:
https://user-images.githubusercontent.com/11465271/228706582-d08b494c-c711-4ce7-8712-1453c9aaa792.mov
Edge cases / Breaking Changes / Known Issues

If someone is trying to merge a one-liner, then the template may not apply, so feel free to delete everything and include a short sentence
Headers/Titles (i.e. Description, Links, Testing, Edge Cases, ...etc.) can be agreed upon and/or reordered

Should we remove "Send PR link to the #computation slack channel" since not everyone will have access?

Makes sense I'll remove that one. I dont have anything against that

Approving and merging because a template is good for thoroughness and consistency as gonomics is expanding. Also, there's the option to delete everything in the template and create custom PR if needed, so it seems like there's nothing to lose


vuex initialization inside of a module does not provide this.app context

What problem does this feature solve?
Developing a module currently does not work as expected if users would require the initialization of Vuex:
export default (ctx) => {
  const {app, store} = ctx
  const storeOptions = {
    state: Object.assign(general.state, apollo.state, content.state),
    getters: Object.assign(general.getters, apollo.getters, content.getters),
    mutations: Object.assign(general.mutations, apollo.mutations, content.mutations),
    actions: Object.assign(general.actions, apollo.actions, content.actions)
  }
 store.registerModule('lc', Object.assign({}, storeOptions))
}

getters:{
  test(state){
    console.log(this.app) //=> this.app is 'undefined'.
  }
}

What does the proposed changes look like?
It would be great if Vuex inside of a module would automatically receive the this.app context. Also all through a module/plugin injected context variables would be great to be available

This feature request is available on Nuxt.js community (#c6835)

I think by design the this context is only available inside of actions. Will close this for now because I found another way to do this.


Allow dashboard plugins to advertise what type of objects they support

As a user, I want plugins to be able to advertise what objects they support opening so that the UI can be smart about display those object types. Should be able to include a friendly name of the object and icon as well (for descriptions).
Currently, if there's an unknown object type exported (such as PartitionedTable), it appears as a button like other objects but just doesn't do anything: https://github.com/deephaven/web-client-ui/issues/1143

We could also do some sort of ObjectPlugin that just maps a panel to an object, instead of making a whole DashboardPlugin.

As we get into programmatic layouts, the plugins we build here should be compatible. To that end, I'm thinking there should actually just be a WidgetPlugin that can advertise it's type, and instead of rendering a whole panel, it just renders the component itself. Panels can then be created/managed programmatically.


added the ignore rule for thread safety

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

A request for Sonatype Lift was to remove the THREAD_SAFETY_VIOLATION violation appearing in PRs. This PR adds a configuration setting to stop the comments appearing in future PR's.
An example on demand run without the setting showing the THREAD_SAFETY_VIOLATION https://lift.sonatype.com/results/github.com/apache/skywalking/01FYY2QG9P3AC8AYBFANRH7ZZ7?t=Infer|THREAD_SAFETY_VIOLATION
An example on demand run using this setting https://lift.sonatype.com/results/github.com/doddi/skywalking/01FYY8BBCACQ1W0HNQ9HWDBNWS (running from this branch)

.muse is added in https://github.com/apache/skywalking/blob/master/.licenserc.yaml to ignore license header check.
If .lift's files can't have headers(from tech perspective) too, please update .licenserc.yaml  file accordingly.

Hi, another thing I noticed is this https://lift.sonatype.com/results/github.com/doddi/skywalking/01FYY8BBCACQ1W0HNQ9HWDBNWS?t=ErrorProne|MissingSummary
MissingSummary covers the generated codes, which are not controlled by us, they are from protoc tool. Is there any way to exclude those too?

https://lift.sonatype.com/results/github.com/doddi/skywalking/01FYY8BBCACQ1W0HNQ9HWDBNWS?t=ErrorProne|SameNameButDifferent
Another question is, this is a common use of @Slf4j, why is this showing up?
https://github.com/doddi/skywalking/blob/2a1e480d18605d89b62e12e1a020241133ad5dfa/apm-webapp/src/main/java/org/apache/skywalking/oap/server/webapp/GlobalErrorWebExceptionHandler.java#L34

@doddi can you also check this and other comments in the same PR, I don't think those SameNameButDifferents are positive

https://lift.sonatype.com/results/github.com/doddi/skywalking/01FYY8BBCACQ1W0HNQ9HWDBNWS?t=ErrorProne|SameNameButDifferent
Another question is, this is a common use of @Slf4j, why is this showing up?
https://github.com/doddi/skywalking/blob/2a1e480d18605d89b62e12e1a020241133ad5dfa/apm-webapp/src/main/java/org/apache/skywalking/oap/server/webapp/GlobalErrorWebExceptionHandler.java#L34

@wu-sheng @kezhenxu94 Looks like there might be an issue with Lombok and ErrorProne for this particular finding (details). For now I think we should disable this finding as it's more of a suggestion than a true issue. I'm testing the config change out on another branch and then will merge into this one if it works correctly.

This PR seems from @doddi 's personal for repo, are you able to change there?

This PR seems from @doddi 's personal for repo, are you able to change there?

Yep he granted me permissions before going on vacation

Added the rule for SameNameButDifferent: https://github.com/apache/skywalking/pull/8736/commits/8835cdfc3a0149b9f0aab050854e7a64086f794d
Test here shows that finding removed: https://lift.sonatype.com/results/github.com/doddi/skywalking/01FZ0G8NAZ7J3WPN59JXRZQ0HK

@jlstephens89 Yes, that is gone.
And I found subprocess_without_shell_equals_true, 76 hits and assert_used(200+ hits) are just reviewing codes from submodule(UI) part, which should not be reported in this repo. And the error is from skywalking-ui/node_modules/, which are the dependencies, not the codes written by SkyWalking UI side. Could you set rules to skip /skywalking-ui folder?

The NonAtomicVolatileUpdate is false warning, I think. We have added @SuppressWarnings("NonAtomicVolatileUpdate") to the field.

JSC_PARSE_ERROR is reporting errors of 3rd party license files. I think we either should skip files not .java or expected source files, or at least exclude /dist-material/release-docs

EqualsGetClass has listed some warnings according to the book <Effective Java 3rd Edition §10> or other practice you preferred.
But, personally, I don't feel this is an issue, and also, this code style is from IntelliJ's code generator.
Is there a way we don't have to add @SuppressWarnings("EqualsGetClass")? Because it seems pointless, this should be a very developer's personal style. Sub-instance should or should not be treated as equal, is debatable.


[Autocomplete] Add possibilty to set the require attribut of the input

Summary 💡
Add a possibility to set the require attribute of the input element of the autocomplete
Examples 🌈
<Autocomplete
  id="combo-box-demo"
  require={true}
  options={top100Films}
  getOptionLabel={(option: FilmOptionType) => option.title}
  style={{ width: 300 }}
  renderInput={params => (
    <TextField {...params} label="Combo box" variant="outlined" fullWidth />
  )}
/>

<input aria-invalid="false" require=true autocomplete="off" type="text" class="MuiInputBase-input MuiInput-input MuiAutocomplete-input MuiAutocomplete-inputFocused MuiInputBase-inputAdornedEnd" aria-autocomplete="list" autocapitalize="none" spellcheck="false" value="" id="mui-autocomplete-48773">

Motivation 🔦
This would be very nice to use autocomplete in a form.

You can use the inputProps prop on the TextField for that.

Works. Thank you very much!

Using required on the text field does not work, because the text field does not recognize if an option has been selected.

@reginaochotzki See #21663 for multiple support of the required field.

@reginaochotzki See #21663 for multiple support of the required field.

I did, but it does not work. I am using the latest version of mui lab 4.0.0-alpha56


Implement "Copy All Codes" Feature for Color Palette in share window UI

The existing "Copy Code" option in the share functionality does not currently display the codes of the active color palette. We need to implement a feature that ensures the current palette codes are visible before users attempt to copy them.
Requirements:

Display Active Palette Codes: Ensure that the codes for the current color palette are clearly displayed in the UI.
Smooth Functionality: Guarantee that the "Copy Codes" option works flawlessly, allowing users to copy the displayed codes easily.

hey! @TheOpenInnovator can you assign me this issue under hacktoberfest?

That's great @HarshitaJaiswal5 for creating a valuable issue. You can start working on it.


Get method should not have content

GET https?://gitlab.url/api/v3/ call should not send Content-Lenght, thus body needs to be empty. Some webservers (lighttpd in my case) return 400 on GET with Content-length set.
Ngnix does not check this when proxy to gitlab backend, it just bypass.
http://tools.ietf.org/html/rfc2616#section-5.1

make sense. Could you rebase from master?

Gitlab CI has been merged with Gitlab CE. Closing this PR.


awsume: init at 4.5.3

Description of changes

https://awsu.me/
Closes #200632
Note to the reviewer:  as per the documentation, the main executable awsume is not meant to be executed directly but aliased to be sourced from the shell, i.e:
$ alias awsume="source $(which awsume)"

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 229944 run on x86_64-linux 1

2 packages built:

awsume
awsume.dist


Allow to model passive pass-thru-modules (for example on blade centers)

Issue type
[X] Feature request
[ ] Bug report
[ ] Documentation
Environment

Python version: 2.7.13
NetBox version: 2.3.3

Description
When trying to model HPE Bladecenters/enclosures (C7000) with netbox, we currently have to decide if we want the pysical cabling to be accurate or the logical network connection. The blade centers are equipped with pass-thru-modules, which simply extend each network port of the servers directly to a physical network port on back of the bladecenter. As in, blade server 1 has it's first nic mapped to the first port of the first pass-thru-module and so on for all 16 blades in the blade enclosure. The blade center and blade servers are modeled with a parent-child relation. Now, depending on how you look at it, the connection of this ports to the switch ends either on the blade chassis (if you look at the physical cabling) or on the server nic inside the blade server (if you look at layer 2/lldp/show neighbor/ethtool). Now the datacenter guys insist on modeling the physical cabeling between the blade center and the switch, in order to for example create proper cable labeling from the netbox data. The server guys on the other hand really want the logical connection modeled as for them the nic is conncected to the switch and they want to build upon the connection data for proper interface labeling, verifying vlan configurations and so on.
So in order to fix this we had the idea of a new interface type that 'borrows' the interface from another device, like 'this interface on this device is in fact that interface on that device', kind of an alias or symlink. This would allow both parties to accurately describe their setups.
I'm aware this would be a larger change, so I wonder if there is demand for this kind of mapping.

Since the module is just pass-through, I would model the connections in NetBox as connecting to the servers themselves. This seems reasonable since the position of the cable is deterministic as you say (slot 1 = interface 1, etc.). Attempting to model the pass-through module would require an entire new level of abstraction and yield very little real value.

I'm not objecting that this ticket is closed, I just wan to add one use case we identified in the meantime that speaks against mapping the ports directly to the servers: When relocating blade servers in a blade center, the patching would follow the server location, where in "reality" the patching would still be on the same port, only that port now being connected to another server. But I can understand that this level of realism could be more distracting than helpful.


Xiaomi Aqara Cube not working with ZHA component

Home Assistant release with the issue:
0.80.3
Last working Home Assistant release (if known):
n/a
Operating environment (Hass.io/Docker/Windows/etc.):
Docker
Component/platform:
zha
Description of problem:
I can add the cube to the zha network, but it don't create any sensor for it.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
zha:
usb_path: /dev/ttyS0
database_path: zigbee.db

Traceback (if applicable):

Additional information:

This is the bug/issue tracker for Home Assistant. Please use the forum for questions about installation, setup and configuration.


launch cellxgene with password

Hi
Is there a simple way to launch cellxgene instance with a password so only users with a password can access it?

Hi Fadhl,
Are you familiar with Apache reverse proxy module? You can use Apache to
set up a public website first, and then reverse proxy to the real
Cellxgene instant. In Apache, you can set up basic http authentication
(i.e., .htaccess, .htpasswd).
--Derrick

From: Fadhl @.>
Reply-To: interactivereport/cellxgene_VIP
@.
@.***>>
Date: Sunday, May 1, 2022 at 12:41 AM
To: interactivereport/cellxgene_VIP @.>
Cc: Subscribed @.>
*Subject: *[EXTERNAL] [interactivereport/cellxgene_VIP] launch
cellxgene with password (Issue #74)
Hi Is there a simple way to launch cellxgene instance with a password
so only users with a password can access it? — Reply to this email
directly, view it on GitHub [github.com http://github.com], or
unsubscribe [github.com http://github.com]. You are receiving this
because
ZjQcmQRYFpfptBannerStart
*This Message Is From an External Sender *

*EXTERNAL EMAIL: *Use caution before replying, clicking links, and
opening attachments.
ZjQcmQRYFpfptBannerEnd
Hi
Is there a simple way to launch cellxgene instance with a password so
only users with a password can access it?
—
Reply to this email directly, view it on GitHub [github.com]
https://urldefense.com/v3/__https:/github.com/interactivereport/cellxgene_VIP/issues/74__;!!LqrO4s96!l-1sdH2QkGA7OxO6yGcJUn7nICPjH--6_zYUtCZZqdx5nBp4NRKjhpTRpGagFQoYwPo0Zt12DD71499t2k7pKN_Ufj7f$,
or unsubscribe [github.com]
https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AHBU2TDN73IFJJN7ZHN76QLVHYDNXANCNFSM5UZJSQBQ__;!!LqrO4s96!l-1sdH2QkGA7OxO6yGcJUn7nICPjH--6_zYUtCZZqdx5nBp4NRKjhpTRpGagFQoYwPo0Zt12DD71499t2k7pKCJFpZLr$.
You are receiving this because you are subscribed to this thread.Image
removed by sender.Message ID:
@.***>

Hi Fadhl, Are you familiar with Apache reverse proxy module? You can use Apache to set up a public website first, and then reverse proxy to the real Cellxgene instant. In Apache, you can set up basic http authentication (i.e., .htaccess, .htpasswd).
…
--Derrick
From: Fadhl @.> Reply-To: interactivereport/cellxgene_VIP @. @.***>> Date: Sunday, May 1, 2022 at 12:41 AM To: interactivereport/cellxgene_VIP @.> Cc: Subscribed @.> *Subject: *[EXTERNAL] [interactivereport/cellxgene_VIP] launch cellxgene with password (Issue #74) Hi Is there a simple way to launch cellxgene instance with a password so only users with a password can access it? — Reply to this email directly, view it on GitHub [github.com http://github.com], or unsubscribe [github.com http://github.com]. You are receiving this because ZjQcmQRYFpfptBannerStart This Message Is From an External Sender * ------------------------------------------------------------------------ EXTERNAL EMAIL: Use caution before replying, clicking links, and opening attachments. ZjQcmQRYFpfptBannerEnd Hi Is there a simple way to launch cellxgene instance with a password so only users with a password can access it? — Reply to this email directly, view it on GitHub [github.com] <https://urldefense.com/v3/https:/github.com/interactivereport/cellxgene_VIP/issues/74;!!LqrO4s96!l-1sdH2QkGA7OxO6yGcJUn7nICPjH--6_zYUtCZZqdx5nBp4NRKjhpTRpGagFQoYwPo0Zt12DD71499t2k7pKN_Ufj7f$>, or unsubscribe [github.com] <https://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AHBU2TDN73IFJJN7ZHN76QLVHYDNXANCNFSM5UZJSQBQ;!!LqrO4s96!l-1sdH2QkGA7OxO6yGcJUn7nICPjH--6_zYUtCZZqdx5nBp4NRKjhpTRpGagFQoYwPo0Zt12DD71499t2k7pKCJFpZLr$>. You are receiving this because you are subscribed to this thread.Image removed by sender.Message ID: @.>

How would you go about deploying the public website first to something like Heroku?

@FADHLyemen Other than adding Apache server, another way would probably be to modify the cellxgene server/app/app.py and add HTTPBasicAuth to get a simple password protection.
You might want to have a look of this link, https://flask-httpauth.readthedocs.io/en/latest/.
I put an example to this filebin. You might want to have a look and see if that helps :)
The file will work with their latest commit that added support with cellxgene 1.1.1. Once you finished all the VIP setup, you just need to replace the file with the one inside the filebin. The path will be around /opt/conda/lib/python3.8/site-packages/server/app/app.py, depending on the Python version you are using.


Add filter to UserProfileListView

requires #1037 for checks to complete
closes #1027

[ ] tests

coverage: 88.888% (-0.06%) from 88.95% when pulling 4e15ba57fc5cedcf010b629cf9d8c1a3a8cbe783 on better-user-group-lists into 2f4ed4b8e07fb3984ede9f2c7c6fb9a8aa4b7422 on main.


feat: add flutter support

Description
Add a short description of:

what changes you made,
why you made them, and
any other context that you think might be helpful for someone to better understand what is contained in this pull request.

This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.

But Mitosis doesn't have any support for flutter...?

maybe this means we should add it or maybe he is working on it

Hey folks, sorry! the idea was to open in my fork sdhuadhuasuh my bad I'm working on it!

This project was something like what you are doing here: https://github.com/skynexui/components
I was creating a compatibility layer between Flutter and React.

Would love flutter support at the moment I'm using the React Native target and using this tool to convert it - https://github.com/GeekyAnts/react-native-to-flutter


UI issues

[ ] Home page is kind of pointless ATM. I'd suggest using this page to display all added components from styleguide. I'm also not sure about having separate pages for each component. I think it would make more sense for styleguide consumers to be able to scroll through the style guide without clicking. In this case, the navigation could act as a TOC with an affix (http://getbootstrap.com/javascript/#affix).
[ ] "Filter" field doesn't look like an input and more like a heading
[ ] Typing something into filter input and pressing ESC is broken (https://github.com/pure-ui/styleguide/issues/195)
[ ] Component instance controls () appearing with a big delay. It feels weird.
[ ] Component instance controls doesn't have title attributes
[ ] Pressing on the "+" displays input. It is not focused by default, so you can't start typing without focusing it with the mouse firstly... (see next one for even better fix)
[ ] IMO pressing on the "+" should just add a component without asking for a title
[ ] Inconsistent location of controls
[ ] "Edit metadata" isn't clear enough
[ ] "Edit metadata" button should be disabled for components where it is empty
[ ] Consider dropping the modal in favor of a sidebar with a direct manipulation. Something like "Sketch"?

@okonet this would get us to crazy file renaming issues and we might do it sometime in the future:  IMO pressing on the "+" should just add a component without asking for a title


No module named 'sphinx.quickstart'

It seems sphinx.quickstart does not exists in Sphinx 2 and has been renamed sphinx.cmd.quickstart.
$ hieroglyph-quickstart
Traceback (most recent call last):
  File "/usr/local/bin/hieroglyph-quickstart", line 7, in <module>
    from hieroglyph.quickstart import quickstart
  File "/usr/local/lib/python3.6/dist-packages/hieroglyph/quickstart.py", line 1
0, in <module>
    import sphinx.quickstart
ModuleNotFoundError: No module named 'sphinx.quickstart'

But even renaming sphinx.quickstart with sphinx.cmd.quickstart I still get an error:
$ hieroglyph-quickstart
Traceback (most recent call last):
  File "/usr/local/bin/hieroglyph-quickstart", line 11, in <module>
    sys.exit(quickstart())
  File "/usr/local/lib/python3.6/dist-packages/hieroglyph/quickstart.py", line 87, in quickstart
    d = sphinx.cmd.quickstart.DEFAULT_VALUE.copy()
AttributeError: module 'sphinx.cmd.quickstart' has no attribute 'DEFAULT_VALUE'

I do have this version of sphinx:
$ sphinx-quickstart --version
sphinx-quickstart 2.1.2

Well it seems it works with the current branch: pip install git+https://github.com/nyergler/hieroglyph#egg=hieroglyph


Frontend-Backend Connection: Overview page of digital identities

User story

As a {HR-employee}
I want / need {all existing DIs to be displayed in the overview page of DIdentity frontend}
So that {I can review them (and later edit them)}

Acceptance criteria

existing DIs are displayed on overview page
columns:

ID
Name
Surname
Email
open credentials --> integer
open Proofs --> integer
Connection status

Definition of done (DoD)

Added only after week 5
The same for all features
Here goes the project specific part

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

Backend is done. See #70 for the commits/the PR.

Finished in sprint 5: 8b9cdf974b0592bb76a4d87a3d35fe9834c38272


Conversion to enum seems to fail after each redeploy + JITer warmup

Hello, I'm using custom converters to map from a string value in the config to an enum.  For the most part, everything has been working great, but I noticed via logs that every once in a while, I'd get an InvalidCastException.  This is in a *.ashx web handler acting as a web service (old code base), so I'd hit it once, it'd throw the exception, I'd hit it again right away without changes, and it'd work perfectly.
  If I immediately send another request via Postman, it works perfectly and immediately.  I've hammered the webservice and the only time it fails is the first time after a deploy.
Is there some kind of timeout used by the library or you can you think of any reasons / fixes for this behavior?  In case it's relevant, code snippets follow.  Thank you.
    public enum OurPlatforms
    {
        Dev,
        Production
    }

    public class OurPlatformEnumConverter : IConvertType
    {
        public object Convert(string configurationValue)
        {
            if (configurationValue == OurPlatforms.Dev.ToString())
            {
                return OurPlatforms.Dev;
            }
            else if (configurationValue == OurPlatforms.Production.ToString())
            {
                return OurPlatforms.Production;
            }
        }
        public Type TargetType => typeof(OurPlatforms);

I'm using them in a config factory, which gets wired up like this in the factory constructor:
        public ProcessorConfigFactory()
        {
            var ourPlatformEnumConverter = new OurPlatformEnumConverter();
            ConfigurationManager.RegisterTypeConverters(ourPlatformEnumConverter);
        }

and then it reads out the config value that should map out to an enum when a Get method is called:
        private OurPlatforms GetOurPlatform(IConfigurationManager manager)
        {
            return manager.AppSettings.AppSettingConvert<OurPlatforms>("SomeNamespace.OurPlatform");
        }

Update: it works just fine in a webform, as expected, so I'm wondering if there's something to do with the lifecycle of an http handler.

I pasted ALL my code into said webform, and I'm experiencing the same behavior of throwing the exception after a deploy but being fine after that.  I wonder if it's because of how I'm registering the converters in the constructor of the class that's trying to use them.
Is there a recommended way to call ConfigurationManager.RegisterTypeConverters(converter); such that it's picked up by all instances of the Configuration Manager?  I'll experiment with this.  I was trying to avoid having a separate "setup" step in each spot that CM will be used, as there isn't a convenient place to wire this up in a webforms project...

This is super interesting - I'll take a look at this in the next day or two.

I was just coming back to make another comment.  I think it has to do with static versus instance stuff.  I've reproduced a minimally working example to highlight the issue.  I could very well be doing something silly in the way I'm using things.
https://dl.dropboxusercontent.com/u/34032461/MinimalWorkingExampleConfigAbstraction.zip
If you run the attached solution by loading up default.aspx, it'll automatically break on return manager.AppSettings.AppSettingConvert<Platforms>("SomeNamespace.Platform");
If you look at the following in the debugger:

manager => static members => TypeConverters
manager.AppSettings => non-public members => _typeConverters

you'll see that on the first run, TypeConverters holds the custom one, and _typeConverters has the default URI converter.  You'll get a "InvalidCast" exception because CM defaults to the PrimitiveConverter due to not finding a match.
If you click "continue" (in VS), let it show you the exception page, and immediately reload default.aspx, it'll break again, and you'll notice that TypeConverters now has 2x of PlatformConverter and _typeConverters has 1x PlatformConverter and 1x UriConverter.  If you click continue, everything works as expected.
If you immediately reload the page again, TypeConverters now has 3x PlatformConverter and _typeConverters has 1x UriConverter and 2x PlatformConverter.  On each load, it'll add another PlatformConverter.
As I said, I could be doing something inadvisable, but I'm using this in an old legacy webforms app and AFAIK I don't have a convenient place to wire this up "once and only once" like in a startup.cs.  And I'm trying to avoid having to have a separate call to wire up the converters before using it in each of the various places.

Theories: because the call to ConfigurationManager.RegisterTypeConverters() (via RegisterConverter() in the "factory" class) happens inside a class library, the JITer / whatever doesn't "see" it at first and only loads it when it runs/loads the class library code.
Then there's some static/instance stuff going on such that the first custom converter doesn't get registered the first time around.
(Separate issue is it continuing to stack another one each time, but that's likely related to the static nature.)
I'm pretty sure that other areas where I'm using this don't have an issue the first time around because "factory" class stuff gets called into right in the code-behind of a webform, so it gets picked up and pre-warmed.
I started playing around with adding an instance version of RegisterTypeConverters to see if that would help, but it's too late in the day so I'll pick it up again tomorrow.

It looks like throwing the custom converter registration stuff into the global.asax file may be the way I need to go on this.

Thank you for taking the time to investigate and patch in a fix for this.
I originally was doing the registration in startup events only, but then I ran into the problem in #13 and so started registering it per-request.  I'll take another look and see if I can get it to work only in the startup.

A few idle thoughts - the correct pattern of usage here is that this stuff should all be configured on application startup in a global.asmx which deals with the static configuration of the library - then each subsequent instance of the configuration manager that is constructed it copies a snapshot of the currently configured Converters into the private _typeConverters list for use with that instance of the ConfigurationManager.
The only way I can see the thing you're demo-ing up there happening is if the ConfigurationManager instance is created before those static registrations happen.

While kind of tangential - I think I'm just going to bake Enum conversion into the library - it's two lines of code and makes this whole thing go away :)

Version <IP_ADDRESS>.42 adds Enum support by default, which should stop you needing to worry about any of this :)

Sorry I dropped off and was unavailable the rest of the weekend.  I appreciate you adding enum support and will try it out this week. Thank you!


Benchmark

Hello
How did you calculate the mAP  in the Benchmark table?
code please
Thank's

I didn't calculate the mAP. That's not so easily done.
Instead I copied the figures from the corresponding academic papers.


non-latin chars

Coverage remained the same at 83.65% when pulling 7e5664812c3be2aebbfd14ad2c0910b21d32ba72 on 1d10t:patch-1 into fa4f5653161231bb9bf666aa5fcbbe1ed81edd9a on nixsolutions:master.


neovim: set meta.mainProgram

Motivation for this change
Neovim's main executable is nvim. When running commands such as nix run nixpkgs#neovim users receive and error like:
$ nix run nixpkgs#neovim
error: unable to execute '/nix/store/j03scl0i8da1f2rlfaqdcpz8awzh0agk-neovim-0.4.4/bin/neovim': No such file or directory

After this patch, users experience nvim launching:
$ nix run .#neovim
# nim opens!

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Looks like a great idea. This will need a minor change to our meta validation code:
https://github.com/NixOS/nixpkgs/blob/ddea0864b61fb817c6c562a4133547ac9413068b/pkgs/stdenv/generic/check-meta.nix#L205
adding a new field of the type str.

@grahamc Thanks for this advice! I introduced a PR doing that in #120692.
As you noted, this PR requires it.


Containernized ASP.NET Core apps not working when using Kubernetes Orchestrator

I followed the steps on the link below:
https://docs.microsoft.com/en-gb/visualstudio/containers/tutorial-multicontainer?view=vs-2019
Instead of using Docker Compose, Kubertnes is selected for Container Orchestrator Support for each project.

However, the project, WebFrontEnd, runs forever (the VS build progress bar is half way) and web app endpoint is not working when it is in debug mode with Azure Dev Spaces.
Update
I tried switching to Docker mode when debugging, and switching back to Azure Dev Spaces mode, WebFrontEnd launchs at the url below.
http://localhost:51927/
Should the url not contain "localhost"?
However, the text below is not displayed, which means there is an issue with communication between two containers.

"Hello from webfrontend and webapi (with value 1)."

I am looking for an example that shows how to create projects for Kubernetes Orchestration and deploy to AKS. I searched through all docs from MS, but I cannot find one.

For deployment during the dev life cycle, Azure Dev Spaces provides the CLI command 'azds up' which can be invoked from Visual Studio during a build when the Azure Dev Space is selected as the debug target.  The work here is to add more information to this topic.  For now, docs on this are provided at https://docs.microsoft.com/en-us/azure/dev-spaces/get-started-netcore-visualstudio

Closing this as per previous comment - the article refers to the Docker Compose steps and for the Kubernetes scenario, refer to the Azure Dev Spaces docs.


Feature/frontend wfs analysis

This PR contains all commits from backend analysis PR https://github.com/WFP-VAM/prism-frontend/pull/186 and a additional commit which includes the frontend changes https://github.com/WFP-VAM/prism-frontend/commit/a15d10cd8b66e9fde30f75c3fe8462e11e534ad4
Features:

React renders an exposure analysis button within the legend of a layer that has the type exposure included. This type is a string which references a geotiff layer.
On a button click, an analysis is executed by making a request to the API specifying the geotiff raster and the wfs parameters for the vector polygon layer.
When the response returns the required parameters, the analyser checks if there is a geometry field specified within the ** mergeFeaturesByProperty** function. This geometry corresponds to the polygon intersection between the wfs polygon layer and the admin boundary.

How to test:

Switch to branch

git fetch origin && git checkout feature/frontend-wfs-analysis

Start local api service.
Modify ANALYSIS_API_URL to point to your local server https://github.com/WFP-VAM/prism-frontend/blob/master/src/context/analysisResultStateSlice.ts#L30
Modify ADMIN_BOUNDARIES_URL to point to myanmar example: https://github.com/WFP-VAM/prism-frontend/blob/master/src/context/analysisResultStateSlice.ts#L31
Run local frontend server.

@JorgeMartinezG I changed the base to make it easier to review

@Ry-DS Applied feedback

@ericboucher  Added 2.0.0 version within commit 911c2cf2dd32089113030e0dff97ca87684a98b2


[RFC FS-1028] - Implement Async.StartImmediateAsTask

Feature implemented.

@OnurGumus,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@OnurGumus, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

The code looks ok though the tests indicate some failures?

Yes kinda weird. The test failing is
Conformance\InferenceProcedures\TypeInference (E_OnOverloadIDAttr01.fs) -- failed
I have no clue why. Not related to my work. I only ran the test named "test" locally and that passed. Could this be already broken even before my commit?

@OnurGumus I'll close and reopen to re-run tests.  But I think more tests must be failing - usually each of part1, part2 and part3 indicate different failures
For example I expect you will need to update the API surface area tests?

@OnurGumus,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

I will check it again, but that's gonna be on the weekend again:)

@dotnet-bot test this please

@dotnet-bot test this please

Sorry for not dealing with this yet. I forgot to update surface area tests. I will check it asap.

ping

I just want to highlight a potential problem that also exists for Async.StartImmediate. For example:

[<EntryPoint>]
    let main argv =
        async {
            printfn "1- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Async.Sleep 1000
            printfn "2- %A" (Thread.CurrentThread.ManagedThreadId)
            do!  Async.Sleep 1000
            printfn "3- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Task.Delay(1000) |> Async.AwaitTask
            printfn "4- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Async.Sleep 1000
            printfn "5- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Task.Delay(1000) |> Async.AwaitTask
            printfn "6- %A" (Thread.CurrentThread.ManagedThreadId)

            return ()
        }
        |> Async.StartImmediate  |> ignore
        System.Console.ReadLine()
        0

If we use async everywhere then everything works perfectly. That is no thread switch occurs. However if start to use System.Threading.Tasks.Task in between as in above example, then a thread switch occurs. The async module is a little bit complicated for me with a lot of "trambolines" involved.

If we use async everywhere then ...no thread switch occurs.

@OnurGumus I think it's just luck or which thread pool thread gets chosen.  When i tried it I got
1- 1
2- 4
3- 4
4- 5
5- 4
6- 4

@dsyme Which example have you tried? If you have used above example of course a thread switch occurs because tasks are involved. But the key is if you try below:
[<EntryPoint>]
    let main argv =
        async {
            printfn "1- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Async.Sleep 1000
            printfn "2- %A" (Thread.CurrentThread.ManagedThreadId)
            do!  Async.Sleep 1000
            printfn "3- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Async.Sleep(1000)
            printfn "4- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Async.Sleep 1000
            printfn "5- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Async.Sleep1000)
            printfn "6- %A" (Thread.CurrentThread.ManagedThreadId)

            return 1
        }
        |> Async.StartImmediateAsTask  |> ignore  // or Async.StartImmediate with return ()
        System.Console.ReadLine()
        0

Then no thread switch occurs as there are no tasks involved. Hence we achieve our goal.
To clarify the confusion, my pull request introduces a brother method to StartImmediate that has the same characteristics. That is StartImmediate must return unit where as StartImmediateAsTask can return something.

Then no thread switch occurs as there are no tasks involved.

Thread switches occur in your sample - the Async.Sleep calls are ultimately implemented via by a timer callback which may get scheduled on a different thread (unless the originating code was a thread with a non-null SynchronizationContext, e.g. a UI thread).
When I compile this code
open System.Threading

open System.Threading.Tasks

[<EntryPoint>]
let main argv =
        async {
            printfn "1- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Async.Sleep 1000
            printfn "2- %A" (Thread.CurrentThread.ManagedThreadId)
            do!  Async.Sleep 1000
            printfn "3- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Async.Sleep 1000
            printfn "4- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Async.Sleep 1000
            printfn "5- %A" (Thread.CurrentThread.ManagedThreadId)
            do! Async.Sleep  1000
            printfn "6- %A" (Thread.CurrentThread.ManagedThreadId)

            return ()
        }
        |> Async.StartImmediate |> ignore  // or Async.StartImmediate with return ()
        System.Console.ReadLine()
        0

I get
C:\GitHub\dsyme\visualfsharp>a
1- 1
2- 4
3- 4
4- 5
5- 4
6- 5

@dsyme : Are you sure? Because that's weird. I am getting
1- 1
2- 4
3- 4
4- 4
5- 4
6- 4

repeatedly every time. As a proof see below gif file:

I am using .NET 4.7 with F# 4.1 Release build 64 bit (though other configurations also yield the same result).

@OnurGumus That's just luck with regard to the thread pool threads (e.g. thread 4) used for the timer callbacks.

@dsyme , I see. Then my preliminary assumption was incorrect. Nevertheless, as I stated, this function is still valuable and complementary to StartImmediate, as it ensures, it starts a task immediately and when done, it returns the task itself.  Though not sure what I should do to complete this pull request.

@OnurGumus The PR is ready - you don't have to do anything more.  It's just a question of when we're willing to rev FSharp.Core (and if we rev the version number etc.)


Improved fetch and data preparation for charts

Removed a bunch of unnecessary code, now it is cleaner and easier to understand
Updated fetch function: now it collects the data depending on the number of days requested and sets it into state
Added functions to combine data, dedupe it and prepare it to be consumed by chart

/lgtm

/ok-to-test


FireFox bug with fixed container sizes

Works for images in portrait orientation
Demo: https://codesandbox.io/s/3r3mozxp5q
OS: macOS 10.14.1 (18B75)
FireFox: 63.0.3

@Grimfrid
I was able to work around this issue for the time being by passing a custom class to the crop tool which explicitly sets the maxHeight in pixels to be the same as the parent container for the background  element. I believe you can also set this value in JS by passing in the style prop. I chose to use a custom class since I am adjusting the max-height at several breakpoints.
LESS:
.your-custom-crop-tool-class {
    max-height: 600px;

    img {
        max-height: 600px;
    }
}

JS
<ReactCrop
    src = {src}
    crop = {crop}
    className = "your-custom-crop-tool-class"
    onChange = {(c) => this.onCrop(c)}
    onComplete = {(c, p) => this.onCropComplete(p)} />


Reset password button

i gonna be direct in the question.
there is a option to enable the reset password if anyone don't know the last password ?

Bearing in mind the security issues associated with being able to reset anyone's password, how would you see this working from a user's perspective?

See #20

Sorry, but we are not including that feature.