Fix saved filename in ModelCheckpoint if it already exists [wip]

What does this PR do?

Fixes the saved filename if it's already present. It will override the file if it's already going to be deleted. Previously if save_top_k=1 and filename is static for eg: some_file, it will create a file with the version for eg: filename=some_file-v2.ckpt if max_epoch > 1 but it should be some_file.ckpt only.
The test fails on master.
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?
Make sure you had fun coding 🙃

Hello @rohitgr7! Thanks for opening this PR.

In the file pytorch_lightning/callbacks/model_checkpoint.py:

Line 526:121: E501 line too long (130 > 120 characters)

Do see the Hitchhiker's guide to code style

Thanks @carmocca for the review :)

Unrelated to the PR but, is there a reason for version starting at 0?
file.ckpt  # I find this confusing, kind of implies this is -v-1
file-v0.ckpt
file-v1.ckpt
...

instead of:
file.ckpt
file-v1.ckpt
file-v2.ckpt
...

Unrelated to the PR but, is there a reason for version starting at 0?

there is no special reason :]
cc: @PyTorchLightning/core-contributors

file.ckpt  # I find this confusing, kind of implies this is -v-1
file-v0.ckpt
file-v1.ckpt
...

no strong opinion here. To me, it looks like file.ckpt the filename user requested, and file-v0.ckpt, ... files created with duplicate names starting with 0 version index.

Imagine you know nothing about Lightning and you are given a copy of these checkpoints so you can run a model on some data. Would it be clear which is the first checkpoint?

Would it be clear which is the first checkpoint?

monitor values = [10, 20, 15, 5], mode='min'
file.ckpt might not always be the first checkpoint.

let's do https://github.com/PyTorchLightning/pytorch-lightning/pull/4861#discussion_r531787757 in another PR, since we need to make sure to update the states in ModelCheckpoint when we rename the file. Reverting the changes.

@carmocca wanna give this a shot? https://github.com/PyTorchLightning/pytorch-lightning/pull/4861#discussion_r531787757

@carmocca wanna give this a shot? #4861 (comment)

Sure, I will. Most likely this weekend


Added TGF_PATH environment variable

I don't understand this error, can anyone maybe explain ?
verifying<EMAIL_ADDRESS>checksum mismatch
When are checksums generated ?

I merged the master into your branch. It is always preferable to do it before submitting a pull request.


Releases 0.3.0

It includes breaking features, given that from now on, the @rpc annotation requires the type of serialization (either Protobuf or Avro).

Codecov Report

Merging #82 into master will increase coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   89.34%   90.16%   +0.81%
==========================================
  Files          12       12
  Lines         122      122
==========================================
+ Hits          109      110       +1
+ Misses         13       12       -1

Impacted Files
Coverage Δ

rpc/src/main/scala/internal/service/calls.scala
85.71% <0%> (+3.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4367723...59e2f93. Read the comment docs.


Camera updates

The camera needs to:

be able to transition between ortho and perspective smoothly
be positioned so that it's looking at a certain block rather than at a world position, as the main viewport should be orthographic

Or 2 should be: A certain position in block space (Float, Int, Float)


make-rpm.mk: simplify PKGNAME definition

The first lines in make-rpm.mk contain this PKGNAME variable definition:
ifndef PKGNAME
    PKGNAME:=$(shell test -f *.spec && basename *.spec .spec)
endif

This could probably be simplified to:
PKGNAME ?= $(shell test -f *.spec && basename *.spec .spec)

(Needs to be verified before implementing.)

Makes sense :)


Travis setup for test automation

how is this PR different from the one I just merged?
Please do a re-basing of your fork (now and before any PR), I'm assuming that I've already merged most of this.

Yeah almost some except for small change in .yml file which is not needed
now , As u said there is need to virtual env.
On 10 Oct 2018 09:48, "Dan Petre"<EMAIL_ADDRESS>wrote:

how is this PR different from the one I just merged?
Please do a re-basing of your fork (now and before any PR), I'm assuming
that I've already merged most of this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/takanokage/blocksWorld/pull/4#issuecomment-428646557,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ao6dC__N-r0O5FMtqrYKfev689_ZrqTFks5ujiTQgaJpZM4XVxl5
.

well, please go ahead and rebase and let's see what's left after. ;)

oh, after the rebase you'll notice a few changes in the code, particularly I've added docstrings to methods and modules. your immediate task after this PR is to do the same for the unit tests - will help me and others to understand what you're doing.

Did you  find any useful  changes for my new PR ?
On 10 Oct 2018 09:59, "Dan Petre"<EMAIL_ADDRESS>wrote:

oh, after the rebase you'll notice a few changes in the code, particularly
I've added docstrings to methods and modules. your immediate task after
this PR is to do the same for the unit tests - will help me and others to
understand what you're doing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/takanokage/blocksWorld/pull/4#issuecomment-428650550,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ao6dC5aoZueDXwM0c5FinsRUYZjL_tS5ks5ujieBgaJpZM4XVxl5
.

Yep, thanks!
No worries, I picked up everything you did and I'm preparing more for you to do.

Thanks. I am adding docstrings to unitests now . I will create a new PR in
10 to 15 mins .
On 10 Oct 2018 10:18, "Dan Petre"<EMAIL_ADDRESS>wrote:
Yep, thanks!
No worries, I picked up everything you did and I'm preparing more for you
to do.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/takanokage/blocksWorld/pull/4#issuecomment-428656555,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ao6dCwCD9coAwmh3CDOsIyH01U0iD1qNks5ujivVgaJpZM4XVxl5
.

oh, if you mean the previous PR.
On this one more than anything I really want you to learn how to rebase you fork. The idea is that while you are working the main repo can accept changes from other people too. It's best practice for you to get the latest changes from the main repo and handle any differences before submitting a PR.

Oh gosh!!!! Unfortunately , I thought rebase is something to fork again. I
have deleted my repo and forked ur repo .
On 10 Oct 2018 10:22, "Dan Petre"<EMAIL_ADDRESS>wrote:

First things first: let's address this PR. Later you can look at
docstrings.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/takanokage/blocksWorld/pull/4#issuecomment-428657743,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ao6dC9WyQdop8m0ZP3K4bL611PtHlyRpks5ujizPgaJpZM4XVxl5
.

Anyways, I made a PR for changes in .yml file before deleting my repo.

that's always good experience. no worries, I'm sure there's either a way to recover your previous stuff or simply rewrite it.

Anyway, I could save your stuff from the current PR but I won't. We don't need the xml file for the CI and we don't need venv. I'm going to handle the Travis CI integration.

I will create a branch now and then compare by pushing the contents from my system (older repo). Does it works ?

Go ahead with the docstrings.
Also, I just built the pip package and tried to run the tests and couldn't run them. One of the issues is that I can't pip install unittest. Secondly I'm not sure we really need this external package: please make a case for why we need it. ;) Thanks!

To answer your question: yes, that works. That's pretty much a rebase only done in a very convoluted way :). I'm not going to integrate this PR though, I don't want the extra xml and venv.


Strange Javascript error when using PhantomJS driver

I'm seeing some Javascript errors that only happen in PhantomJS and trying to puzzle out why that might be. Here is the error message:
SyntaxError: Unexpected token ','
           at http://localhost:8080/assets/App.js:5296 in eval
           at http://localhost:8080/assets/App.js:5296
           at http://localhost:8080/assets/common.js:51 in __webpack_require__

This comes from a file loaded from a different port. The test runner is on port 9876, and the files are loaded from 8080. Could that be the reason? I can't figure out why it works on Chrome and only fails in PhantomJS. Does anyone know?

Most likely you're using new syntax (ES6?) thats not supported by PhantomJS.  Whats at that line of App.js?  Note also that requests to a different server can't be tracked by Capybara which is okay as long as they're just for assets but will can create all sorts of issues if those requests interact with the database.

That's strange. I do use ES6, but Babel compiles it to ES5. Here is the line in question:
https://gist.githubusercontent.com/volkanunsal/d1cadef212d88d87c6e29518047eebba/raw/95d75b5780221eeb8d4feb8a557b071af2b0917e/gistfile1.js
I can't find anything wrong with it, but maybe you can pick out a problem there.
I also tried gzipping the file for production and compressing it –– just to see if that might iron out the issue –– but I got a different error this time. It now complains about not finding a variable, which is actually defined in one of the JS files –– and I never get this error in Chrome.
ReferenceError: Can't find variable: bv_form
       ReferenceError: Can't find variable: bv_form
           at http://<IP_ADDRESS>:9887/users/sign_in:13
           at http://<IP_ADDRESS>:9887/assets/common-3c4910e796947932c803.js:5 in c
           at http://<IP_ADDRESS>:9887/assets/common-3c4910e796947932c803.js:5 in fireWith
           at http://<IP_ADDRESS>:9887/assets/common-3c4910e796947932c803.js:5 in ready
           at http://<IP_ADDRESS>:9887/assets/common-3c4910e796947932c803.js:4 in d

Here is a schema of my page layout just to show you how strange this is:
!!!
%html
  %head
    =javascript_include_tag 'common'
    = javascript_include_tag 'App'
    = javascript_include_tag 'Map'
  %body{class: page_class}
      ...
      :javascript
          bv_form('form')

Btw, I'm using PhantomJS 2.0. Should I try upgrading to 2.1?

@volkanunsal Definitely upgrade to 2.1.1

@twalpole Just tried it in 2.1.1. Still getting the same error. :(

@volkanunsal It appears the error is being generated because you have a hash with two identical keys being declared -   around  style: _styles.rowStyle,\n          align: 'center',\n          style: { borderBottom: 'solid 1px #999' }   -- note how 'style' is repeated -- why phantomjs throws an error there I'm not sure  but I think that is it.

@twalpole Yes, that was definitely the issue.

@twalpole I wonder if there is a way to get a backtrace from PhantomJS in the event of a crash? I'm now getting a DeadClient error and want to file a bug report, but all I can see is the backtrace from Capybara...

@volkanunsal Turning on debug mode in poltergeist and phantomjs (phantomjs_options  --debug=true)  should give some more info.   Closing this issue since it's not a poltergeist issue.


Support for docker swarm

Would like to deploy the workbench in a swarm which means we need to persist the data. Any recommendation on how we do it give we have a persistent storage available across all the host in the swarm

Hi  sabareeshkkanan,
Look please https://hub.docker.com/r/jboss/jbpm-workbench-showcase/ under point: "Persistent configuration"
Michael

The persistent configuration is only for git ? I would like the persistent configuration for drools workbench itself

Hi  sabareeshkkanan ,
All processes, projects, forms and dataobjects are stored in .git.
What exactly do you want to store related to workbench itself? The language?
If this is the case you can do this with the URL like: http://localhost://kie-wb.jsp?locale=


Improve link anchor wrapping

When URLs are wrapped in anchor tags, we reparent the text nodes from the DOM to the new anchor node in order to prevent CodeMirror from getting confused and hiding the cursor when it's inside the URL. Additionally, we apply the cm-string class to the anchor tag to keep the style the same. We also only apply the cm-string-link class to the surrounding span tag when links are not wrapped in anchor tags in order to avoid triggering the custom link behavior by accident. Finally, we put an event listener on the anchor tags that prevents the contextmenu event from bubbling to CodeMirror's handler in order to restore the expected behavior of context menus for links.

Awesome!


Can't connect to exp://

I've been fiddling with this problem since the release of CRNA, already tried setting my REACT_NATIVE_HOST_NAME environment variable to my actual IP address and also giving priority to my Wifi connection

Hi! Sorry to hear that you're having problems. Make sure that environment variable you're setting is REACT_NATIVE_PACKAGER_HOSTNAME.
Also, in the future please make sure to use the issue template, it is much more difficult to help you with this without the information that's requested there.


Given an m x n matrix, return all elements of the matrix in spiral order

Given an m x n matrix, return all elements of the matrix in spiral order.

Congratulations for your Open source contribution. Don't forget to add a star on this repo.. Happy hacking


[HCA] Prepare demo of HCA Catalog

Need
To demo the flexibility of the framework to HCA stakeholders and get folks thinking about a more integrated experience between the data browser and the wider community.
Approach
Look at this catalog here:
https://www.ebi.ac.uk/humancellatlas/project-catalogue/

download the projects file https://api.ingest.archive.data.humancellatlas.org/projects/search/catalogue?page=0&size=1000
Use this to generate a TSV in the "files" section to power the site.
Extract off interesting attributes for the columns and detail pages to the tsv.
Configure a project entity and project detail page.
Create mappers etc to map from the tsv data structure to the fields needed to display.
Iterate till we have an interesting browser.

Would be great to get the institution, laboratory and contributors in there once we have some basics.
Entities
Make a single entity "Project".
Select some columns

project name
assay
species

Select some filters

same as columns

Configure them.
Project Detail Page
Make project detail pages using the title, description and right channel key value pairs of assay, species.

Done


Fix incorrect instruction in DEVELOPMENT.md

In DEVELOPMENT.md the command to deploy knative/build is wrong.
kubectl deploy should be kubectl apply.

/lgtm


Unable to login to Deis Controller v1.6.0

AWS EC2
I have deleted the cloudformation template and rebuilt the entire cluster twice
A nslookup on deis.clusterb.private resolves to my ELB
*.clusterb.private is a CNAME to my ELB

deis register http://deis.clusterb.private

http://deis.clusterb.private does not appear to be a valid Deis controller.
Make sure that the Controller URI is correct and the server is running.

These are the logs from the controller after I restarted it
May 13 12:32:06 ip-10-0-10-41.ec2.internal systemd[1]: Stopping deis-controller...
May 13 12:32:07 ip-10-0-10-41.ec2.internal systemd[1]: Stopped deis-controller.
May 13 12:32:07 ip-10-0-10-41.ec2.internal sh[12298]: time="2015-05-13T12:32:07Z" level="fatal" msg="Error response from daemon: No such container: c23fbf25ab17475a5cf9929909b2c815f76ab2a0bfd054ec45fc99f255925661"
May 13 12:32:07 ip-10-0-10-41.ec2.internal docker[20062]: deis-controller
May 13 12:32:11 ip-10-0-10-41.ec2.internal systemd[1]: Starting deis-controller...
May 13 12:32:12 ip-10-0-10-41.ec2.internal systemd[1]: Started deis-controller.
May 13 12:32:37 ip-10-0-10-41.ec2.internal sh[20158]: controller: running etcd data migrations...
May 13 12:32:37 ip-10-0-10-41.ec2.internal sh[20158]: controller: done running etcd data migrations.
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Syncing...
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Creating tables ...
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Installing custom SQL ...
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Installing indexes ...
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Installed 0 object(s) from 0 fixture(s)
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Migrating...
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Running migrations for authtoken:
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: - Nothing to migrate.
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: - Loading initial data for authtoken.
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Installed 0 object(s) from 0 fixture(s)
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Running migrations for api:
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: - Nothing to migrate.
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: - Loading initial data for api.
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Installed 0 object(s) from 0 fixture(s)
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Running migrations for guardian:
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: - Nothing to migrate.
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: - Loading initial data for guardian.
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Installed 0 object(s) from 0 fixture(s)
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Synced:
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > django.contrib.admin
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > django.contrib.auth
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > django.contrib.contenttypes
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > django.contrib.humanize
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > django.contrib.messages
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > django.contrib.sessions
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > django.contrib.sites
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > django.contrib.staticfiles
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > django_auth_ldap
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > json_field
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > rest_framework
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > south
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > corsheaders
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: > web
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: Migrated:
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: - rest_framework.authtoken
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: - api
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: - guardian
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: deis-controller running...
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: [2015-05-13 12:32:40 +0000] [126] [INFO] Starting gunicorn 19.3.0
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: [2015-05-13 12:32:40 +0000] [126] [INFO] Listening at: http://<IP_ADDRESS>:8000 (126)
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: [2015-05-13 12:32:40 +0000] [126] [INFO] Using worker: sync
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: [2015-05-13 12:32:40 +0000] [131] [INFO] Booting worker with pid: 131
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: [2015-05-13 12:32:40 +0000] [132] [INFO] Booting worker with pid: 132
May 13 12:32:40 ip-10-0-10-41.ec2.internal sh[20158]: [2015-05-13 12:32:40 +0000] [133] [INFO] Booting worker with pid: 133

I believe my issue is I did not notice an error that requested I set proxyProtocol=1
deisctl config router set proxyProtocol=1
I rebuilt the cluster and ran the proxyProtocol and it is allowing me to connect now.


Contribution to the Wiki section

Hello!!
I want to contribute an article to your wiki section, if its counted.
If yes, I want to contribute towards Linear Search.
Kindly assign this to me.
I am GSSoC'21 participant.
Regards,
Sarthak Delori

/assign


feat: introduced a new MultiEntityPicker field

Hey, I just made a Pull Request!
As discussed in #16334 this PR adds a new MultiEntityPicker scaffolder field.

It's essentially a clone of the EntityPicker with the required modifications to support multiple entities.
Tests are still lacking, I'd prefer to align first on the approach before adding these.
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[X] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[X] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Would it be possible to support showing the title of the entity chosen?
(I am not a maintainer)

definitely not stale. I'd love feedback from @rugvip or @camilaibs to get it moving.
@alper98 that should be doable. I'm not sure why the regular EntityPicker does not support this but I don't mind adding it behind a flag

Not stale at all. Still waiting for feedback

@Rugvip definitely, I added them in the latest commit
@alper98 The title is not an attribute set on all entities. For my use case, picking multiple users, an option to display the title instead wouldn't help much. I was thinking that maybe it would make more sense to optionally specify a path that would be used for the label. For example, metadata.title would allow you to display the title. What do you think?

@Rugvip definitely, I added them in the latest commit
@alper98 The title is not an attribute set on all entities. For my use case, picking multiple users, an option to display the title instead wouldn't help much. I was thinking that maybe it would make more sense to optionally specify a path that would be used for the label. For example, metadata.title would allow you to display the title. What do you think?

sounds good to me :) However, might be worth including the maintainers in all this. Perhaps this https://github.com/backstage/backstage/pull/17474 would be relevant to consider?

@Rugvip definitely, I added them in the latest commit
@alper98 The title is not an attribute set on all entities. For my use case, picking multiple users, an option to display the title instead wouldn't help much. I was thinking that maybe it would make more sense to optionally specify a path that would be used for the label. For example, metadata.title would allow you to display the title. What do you think?

Sounds goood

not stale

Hi @Rugvip, all commits are now signed.

Not stale

@Rugvip is there anything left that I can do? Any chance to get this into 1.20? 🙏

Hi @benjdlambert
I've added the export and updated the api report.

Hey @benjdlambert sorry I missed your reply. I just pushed the change. Could you please re-open the PR? 🙏

@mrooding I don't think I can open the PR again, could you create a new PR? It's all greyed out for me :(


[docs] Update notification link for release 3.0.0

Notification version and id are correct but release tag version in the notification link is incorrect.

😊

@lumatijev Thanks!


Making the entire repository menu driven

Description
Started the code for making the entire repository menu driven
Fixes #831
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@devRawnie Now the action is working properly and we can work on your issue. I would like you to pull the latest changes in your local system and then report what challenges you are facing. If you want, you can create separate issue other than the master issue (#831) for better clarity

Ok I am on it. Will revert back shortly

Kindly refer to #1071 issue for problems related to the menu driven script.


fix workshop date

Website: fix date for NDC London

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add store non canonical blob sidecars option

PR Description
Add --data-storage-non-canonical-blob-sidecars-enabled option
Fixed Issue(s)

#7229
Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

PS: I set the option to true in the database migrator

Doc change PR: https://github.com/ConsenSys/doc.teku/pull/459

We can't imply this by the fact non-canonical-blocks-enabled=true?

We can't imply this by the fact non-canonical-blocks-enabled=true?

We thought it would be better to separate them. Users might only need one or the other depending on their needs.

When will we ever not use 'non-canonical-block' storage but set this enabled?
Are we doing this to follow the non canonical storage model?
Are we keeping non-canonical blobs forever like we keep non canonical blocks?
If there's a way in which it differs from non canonical block storage, then I kind of get it, but if its storing non canonical blobs forever like we store non canonical blocks, then I'm struggling to see the use-case

I thought separating them because blocks and blobs have actually very different use cases (at least in theory).
You might be an L2 operator that is interested in non canonical blobs in particular and you may not be interested in non canonical blocks. On the other hand, a service could be interested in tracking orphaned blocks, without being interested in having the corresponding blobs (they are just meaningless data for them).
I don't have a super-strong opinion if there is real need of separating the options.
About forever storing, I think both non canonical blocks and blobs should respect the storage mode in place.
In particular:

For blocks, we are currently missing pruning of non canonical when the MINIMAL is enabled. I think we should fix this.

For blobs, we should prune non canonical respecting the same data availability window applicable for canonical blobs.
in addition, as per https://github.com/ConsenSys/teku/issues/6395 if someone wants to run an altruistic node serving more blobs (wider DA window), the modified pruning window should effects the non canonical blobs too.

As long as we're pretty sure people actually want to store sidecars and not non canonical blocks specifically... I would be happy to make them just store both initially...
I just don't want to end up in a position where because someone has used this flag and not that flag that they've got useless data they cant access anyway, or we have to do weird lookups because the block isn't present... it'll just be a big time sink for little value and no current call to do this permutation.

Can we make sure we don't follow the non canonical block storage style? I don't want another special table that has to be completely separately handled unless we really have to do that...

As long as we're pretty sure people actually want to store sidecars and not non canonical blocks specifically... I would be happy to make them just store both initially...
I just don't want to end up in a position where because someone has used this flag and not that flag that they've got useless data they cant access anyway, or we have to do weird lookups because the block isn't present... it'll just be a big time sink for little value and no current call to do this permutation.

I will keep the option as it is and update the description and the doc then

Can we make sure we don't follow the non canonical block storage style? I don't want another special table that has to be completely separately handled unless we really have to do that...

I'm implementing it the same way as non canonical blocks actually: A separate column where I move blob sidecars from the blob sidecars table to the non canonical blob sidecars one. I understand this might imply heavy db operations (I batched them: 500 blocks at a time -> Max 500 * 6 blobs) but I thought this would keep things simple and separate. In this case, there will be no impact when the feature is off. The current non canonical blocks storage is not ideal because we never delete them but that could be fixed and avoided right from the start with non canonical blob sidecars (if that's what's bothering you).
Otherwise we were thinking of other approaches but none of them is really convincing:

We could add a flag in the column key (SlotAndBlockRootAndBlobIndex -> SlotAndBlockRootAndBlobIndexCanonical) but this would mean adding complexity and possibly impacting performance even if the feature is not active.
Another idea @tbenr came with: extend the DB schema and implement some kind of a flag entry which could live next to each entry (after each blob sidecar entry we could have have an entry which could flag it as non conical) but that requires implementing a new level of abstraction and seeing how it goes. Not sure if this use case is worth the effort.

Do you think it's worth implementing one of these? Or do we keep it the same way (separate table) and make sure we do the required cleanups?

I agree that this is more a PO question. We are doing this not for debug purpose, it is for aligning the non-canonical feature with new deneb blobs. I assume there are real use-cases, even if not very popular. But if we are unsure, let's park it for now.
Thinking about the need of having a separate column for non-canonical: it is for easely accessing canonical without the need of getting canonical blocks first to filter non canonical blobs out.
This mainly impacts the getBlobsByRange RPC. If canonical and non canonical where stored in the same table we have to filter them out, even for very old finalized blobs, which requires extra DB access. And this have to be done even if the non-canonical flag is currently off (you could have enabled it for a while and still have non-canonical data in DB). So there will be a constant impact for all users just for supporting a very niche use case.
With a separate column, there will be no impact for normal users (no filtering needed) the new column will be forever empty. For the ones who want to enable the non-canonical feature, they'll probably accept to pay the DB overhead price.
From API perspective, now there is teku specific getAllBlocks which takes in consideration the non canonical. I see there will be the corresponding getAllBlobs.

I removed the non canonical blob sidecars storage option (I use the existing one related to the non canonical blocks) and added the persistence logic.
I will park this PR for now until we reach consensus on how we could implement this if we need this this feature at all.

I also suspect that we will need nonCanonicalBlobsidecarsAtSlotfor the api. We may end up not using the current method

I also suspect that we will need nonCanonicalBlobsidecarsAtSlotfor the api. ~We may end up not using the current method.~ No we will actually use it in the standard get BlobSidecars when when blockId is a block root (when we lookup non canonical knowing the block root)

I think it will be better to update/add the APIs in a separate PR once this one is merged


Increase miner reward - smallest unit is atto-Aeternity-token

For now go with 10^-18, will be easy to adjust if we decide on something different.

Updated the timeout + added release notes and DB-path bump.


change client version files extensions

Description
change client version files extensions from .py to .txt
Related Issue

These files were used as plaintext and not as python script, so python extension is misleading
It provoked a bug in the API generation

Type of change
The types of changes must be deduced from the labels of the related issues. Please consider providing these further details.

[x] This change requires a documentation update
[x] This change affects the client

How Has This Been Tested?
tested by the github actions

I misunderstood it a bit, I'll fix it tomorrow

By renaming version.py to version.txt, you broke the wheel generation part.

The version.py is called as a module inside the SDK, renaming it to txt might break everything as this file is imported.

Irrelevant at the moment, closing this PR


Added documentation for reconstruct historical states service

Pull request checklist
Use the following template to make sure your PR fits the Teku documentation standard.
Before creating the PR
Make sure that:

[ ] You've read the contribution guidelines.
[ ] You've previewed your changes locally.

Describe the change
Added documentation for reconstruct historical states service
Issue fixed
N/A
Add "fixes #{your issue number}" to close the issue automatically when the PR is merged.
If your PR doesn't completely fix the issue, add "see #{your issue number}" to link to the issue
without automatically closing it. -->
Impacted parts

For content changes:

[X] Documentation content
[ ] Documentation page organization

For tool changes:

[ ] CircleCI workflow
[ ] Build and QA tools (for example lint or vale)
[ ] MkDocs templates
[ ] MkDocs configuration
[ ] Python dependencies
[ ] Node dependencies and JavaScript
[ ] Read the Docs configuration
[ ] GitHub integration

After creating your PR and tests have finished
Make sure that:

[ ] You've fixed any issues raised by the tests.
[ ] You've previewed your changes on Read the Docs
and added a preview link.

Preview

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


tests: arch: arm: move test arm_hardfault_validation to new ztest API

Migrate the testsuite tests/arch/arm/arm_hardfault_validation to the new ztest API.
Signed-off-by: Shaoan Li<EMAIL_ADDRESS>

Please fix the following failures:
57baab5d7a114ad31ffeb7372e66ace7ec3b806e: author email (shaoanxli<EMAIL_ADDRESS>needs to match one of the signed-off-by entries.
57baab5d7a114ad31ffeb7372e66ace7ec3b806e: author email (shaoanxli<EMAIL_ADDRESS>does not follow the syntax: First Last <email>.

3: UC4 Line exceeds max length (83>75): "Migrate the testsuite tests/arch/arm/arm_hardfault_validation to the new ztest API."

Have fixed. Thanks.


ffmpeg command line only

I mostly don't use topaz shell, but run a preconfigured command line with topaz ffmpeg.exe.
Can your utility be extended to pause and resume ffmpeg?

Sorry, there's no plan to support this yet, the tool works by detecting ffmpeg.exe processes spawned by topaz, other programs rely on ffmpeg will be affected if we remove the constraint and pause any ffmpeg.exe processes. It's possible to make it optional and not on by default, but requires more work, so this feature may not be availiable in the near future.
Thanks for your feedback!


Fix civil mod config

I don't think you intended to create this pull request. Confirm?

Correct. My apologies.

@jjafuller Out of curiosity, any particular reason you are forking it?

@jjafuller Out of curiosity, any particular reason you are forking it?

That is a good question. I think at the time it was forked this module depended on cloud.google.com/go/civil which doesn't work in aws? I'll follow up with our maintainer to see if we actually still need a fork of this.


Issue with k8s.io/docs/admin/kube-apiserver/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
The reference layout for options renders poorly, requiring sideways scrolling within the code sample box.
Proposed Solution:
Clean up the Markdown for friendlier display.
Page to Update:
https://kubernetes.io/docs/admin/kube-apiserver/

@ahmetb :wave: Do you have any guidance what's setting the spf13/cobra autogeneration format?

Nope I haven't looked at that before. I assumed those are checked in to kubernetes/kubernetes repository. Somewhere in there, there should be a hack/* script doing that.

@pwittrock :wave: Heya; any advice here about how to adjust the format of outgenerated output?

/remove-lifecycle stale
/lifecycle frozen
/assign

/closed

/close


JavaScript Syntax Highlighter Broke

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.59.1
OS Version: Windows_NT x64 10.0.19043

Steps to Reproduce:

Make a JavaScript File
type in: for (const req of /require *\\( *["'\](.+?)["'`] *\)/.exec(fileCode).slice(1)) {}`
some things in the brakets will be highlighted incorrectly

This is actually a syntax highlighting issue:
// Works
const r = /te'st/.exec('test');

// Broken
for (const req of /te'st/.exec('test')) {
}

On Mon, Aug 23, 2021 at 4:45 AM Henning Dieterichs @.***>
wrote:

This is actually a syntax highlighting issue:
// Worksconst r = /te'st/.exec('test');
// Brokenfor (const req of /te'st/.exec('test')) {}
[image: image]
https://user-images.githubusercontent.com/2931520/130417963-e89caff5-9c91-4777-a85d-70dc62502cc2.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/131333#issuecomment-903565787,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASKLV2RKCDKVUR5EW2ZN4BDT6IDCHANCNFSM5CSGVWRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Well yeah, I said that it was a Syntax Highlighter Issue.


Add ERC: ERC20 Payment reference extension

You'll need to fix all the errors generated by the linter: https://github.com/ethereum/ERCs/actions/runs/8858664958/job/24327583845

@SamWilsn Thx for letting me know. I will fix those. Would you be so kind and help initiate the discussion on related ethereum magicians among wallets (mainly Metamask, Rabby) and explorers (Etherscan, Blockscout)?

@radeksvarz we'd be happy to have you on the next AllWalletDevs call! You can find the details and discord server here: https://allwallet.dev/

I added the section ## Privacy Considerations (reflecting the Web3Privacy Now initiative). Is that a problem?

I added the section ## Privacy Considerations (reflecting the Web3Privacy Now initiative). Is that a problem?

@SamWilsn I fixed the license, can you please react on the section issue?

@abcoathup , @fhar28 pls help
I added the section ## Privacy Considerations (reflecting the Web3Privacy Now initiative). Is that a problem?


[ip6] allow hoplimit 0

HopLimit 0 is required for TC defined in Thread 1.2 Test Plan. And also as pointed out by @bukepo in #3089, 0 is a valid value.

From section IPV6_UNICAST_HOPS and IPV6_MULTICAST_HOPS of http://man7.org/linux/man-pages/man7/ipv6.7.html, 0 is a valid value, and -1 means using the default value

Here were some relative PRs and discussions regarding hop limit 0 (#3077, #3089, #3092).
The first commit in PR introduces one flag to indicate whether to apply hop limit 0 to meet the hoplimit 0 requirement, as well as keep previous usage as is.
The second commit extends existing ping command to allow hoplimit configuration.

Refined this PR according to current discussions/comments.
Please have another review. @LuDuda @abtink @jwhui Thanks.

Thank you @librasungirl for that!


UserAccountDetal component is returning IPFS link

If a user has an avatar on their ENS, we show the URL in the disconnect popover instead of using it as the src for an image element

PR linked https://github.com/airswap/airswap-voter-rewards/pull/118

FYI you can use closes #118 in the PR body and it'll auto-close the issue when they're merged.


OrderDetailID set to 0 instead of null for non-article items in order_details

1. Why is this change necessary?
For non-articles, the orderDetaildID column of order items (s_order_details) is to set to 0 instead of null. It is not a correct behavior as surcharges or discount have no article details and therefore should contain a null value. The issue comes from string conversion in a sprintf that cast a null value into a 0.
2. What does this change do, exactly?
This changes will properly make the articleDetailID being null when necessary. Thought it's important to notice that there is not migration involved for existing order_details and I am not sure it's even wished to do that.
3. Describe each step to reproduce the issue or behaviour.
Create an order that includes a discount (or a surcharge) and go through the entire checkout
Without the current PR:

in s_order_details, for the discount item, the column articleDetailID contains 0
With the current PR:
in s_order_details, for the discount item, the column articleDetailID contains null :+1:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Extension contributed commands (non-codicons) in custom trees are misaligned

Originally reported in https://github.com/microsoft/vscode/issues/116168

Seems to be caused by the fix for #114798 in dcda88e5a69a52b3a9e141af73b68caae08cb2bf
/cc @jrieken


[FZ Editor] No way to create a custom grid layout

Summary of the new feature/enhancement
There's no way to create a grid layout in the Custom tab. Editing the "Create new custom" opens the "custom layout" creator and I didn't find a way to open the "custom table layout" creator except for editing a template.

As I understand correctly: you want to adjust the default gird layout in the editor, not start from scratch?

I actually want to start from scratch, so I'd have one big layout that I'd split manually. There are some pre-defined ones in the Template tab, I just thought it would be reasonable to have a way to create grid layouts from the Custom tab (not by editing a template).

@Defman21
when you edit a predefined template, it will generate a new custom layout, so the predefined template will remain unchanged and available as a template.

Yeah I understand that, it's just strange to have "create custom layout" in the Custom tab, but not "create custom grid layout".

If we put "Create custom grid layout" in the Custom tab, what would you expect the UI to be?
When "Create custom grid layout" is chosen, we would have to show the list of predefined templates that we currently show in the Template tab, right? So it would require two more steps compared to the current UI.
If you have a better UI in mind, let us know, suggestions to improve the user experience are always welcomed!

2 things that I would like to see:

Show a tip that editing a template would actually create a custom grid template.
Choosing "create custom grid layout" would create a basic area/rectangle/layout (gray area, I don't know the proper name of it) without splitters and you can then split it how you want. Not sure about how to deal with the initial splitter orientation (horizontal or vertical), but I have 2 suggestions there:
a. Pick vertical orientation by default and change it near the left/right of the area
b. Let the user rotate the splitter by holding Shift/Alt/Ctrl (again, it should be vertical by default imo)

Show a tip that editing a template would actually create a custom grid template.

Will do it. Thanks for the suggestion.
For number 2, that would require a considerable amount of work (not just for the coding but for the testing as well). Let's keep this issue open and see if it's something more people ask for it.

PR https://github.com/microsoft/PowerToys/pull/8148 tweaks this and lets you

Fixed by https://github.com/microsoft/PowerToys/pull/9325

Fixed by https://github.com/microsoft/PowerToys/pull/9325

Fixed in 0.31.1


[Snyk] Upgrade next-auth from 4.24.3 to 4.24.4

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade next-auth from 4.24.3 to 4.24.4.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2023-10-27.

Release notes

Package name: next-auth

4.24.4 - 2023-10-27

4.24.3 - 2023-10-18

    from next-auth GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Closing in place of https://github.com/DTS-STN/secure-client-hub/pull/453


unexpected error error_class=Aws::Errors::NoSuchProfileError

(check apply)

[x] read the contribution guideline
[ ] (optional) already reported 3rd party upstream repository or mailing list if you use k8s addon or helm charts.

Steps to replicate
Create a fluentd docker with the following config:
<match **>
    @type opensearch
    logstash_format true
    include_tag_key true
    tag_key "@log_name"
    <endpoint>
        url https://MY_AWS_ENDPOINT
        region MY_AWS_REGION
    </endpoint>
</match>

Its dockerfile contains (fluentd:1.14-1):
sudo gem install fluent-plugin-opensearch

During startup of the container inside AWS Beanstalk, we see this error over and over:
logger_1   | 2022-03-15 13:30:20 +0000 [error]: #0 unexpected error error_class=Aws::Errors::NoSuchProfileError error="Profile `default' not found in /root/.aws/credentials or /root/.aws/config"
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/aws-sdk-core-3.130.0/lib/aws-sdk-core/shared_config.rb:367:in `validate_profile_exists'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/aws-sdk-core-3.130.0/lib/aws-sdk-core/shared_config.rb:103:in `credentials'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/aws-sdk-core-3.130.0/lib/aws-sdk-core/shared_credentials.rb:42:in `initialize'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluent-plugin-opensearch-1.0.2/lib/fluent/plugin/out_opensearch.rb:222:in `new'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluent-plugin-opensearch-1.0.2/lib/fluent/plugin/out_opensearch.rb:222:in `aws_credentials'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluent-plugin-opensearch-1.0.2/lib/fluent/plugin/out_opensearch.rb:601:in `block in client'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/faraday-1.10.0/lib/faraday/connection.rb:91:in `initialize'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/faraday-1.10.0/lib/faraday.rb:120:in `new'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/faraday-1.10.0/lib/faraday.rb:120:in `new'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/opensearch-transport-1.0.0/lib/opensearch/transport/transport/http/faraday.rb:72:in `__build_connection'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/opensearch-transport-1.0.0/lib/opensearch/transport/transport/base.rb:166:in `block in __build_connections'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/opensearch-transport-1.0.0/lib/opensearch/transport/transport/base.rb:158:in `map'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/opensearch-transport-1.0.0/lib/opensearch/transport/transport/base.rb:158:in `__build_connections'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/opensearch-transport-1.0.0/lib/opensearch/transport/transport/base.rb:69:in `initialize'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluent-plugin-opensearch-1.0.2/lib/fluent/plugin/out_opensearch.rb:624:in `new'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluent-plugin-opensearch-1.0.2/lib/fluent/plugin/out_opensearch.rb:624:in `client'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluent-plugin-opensearch-1.0.2/lib/fluent/plugin/opensearch_index_template.rb:62:in `host_unreachable_exceptions'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluent-plugin-opensearch-1.0.2/lib/fluent/plugin/opensearch_index_template.rb:71:in `rescue in retry_operate'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluent-plugin-opensearch-1.0.2/lib/fluent/plugin/opensearch_index_template.rb:69:in `retry_operate'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluent-plugin-opensearch-1.0.2/lib/fluent/plugin/out_opensearch.rb:497:in `handle_last_seen_os_major_version'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluent-plugin-opensearch-1.0.2/lib/fluent/plugin/out_opensearch.rb:380:in `configure'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/plugin.rb:187:in `configure'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/agent.rb:132:in `add_match'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/agent.rb:74:in `block in configure'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/agent.rb:64:in `each'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/agent.rb:64:in `configure'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/root_agent.rb:149:in `configure'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/engine.rb:105:in `configure'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/engine.rb:80:in `run_configure'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/supervisor.rb:716:in `block in run_worker'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/supervisor.rb:968:in `main_process'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/supervisor.rb:708:in `run_worker'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/lib/fluent/command/fluentd.rb:372:in `<top (required)>'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/lib/ruby/gems/2.7.0/gems/fluentd-1.14.5/bin/fluentd:15:in `<top (required)>'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/bin/fluentd:23:in `load'
logger_1   |   2022-03-15 13:30:20 +0000 [error]: #0 /usr/bin/fluentd:23:in `<main>'
logger_1   | 2022-03-15 13:30:20 +0000 [error]: Worker 0 finished unexpectedly with status 1

Expected Behavior or What you need to ask
fluentd should not fail. Instead, it should use IAM credentials automatically, since no key and secret were specified in the config file
...
Using Fluentd and OpenSearch plugin versions
fluentd 1.14.5
fluent-plugin-opensearch 1.0.2

OS version: whatever the fluentd docker 1.14-1 uses (some Alpine)
Bare Metal or within Docker or Kubernetes or others? Docker
Fluentd v1.0 or later: 1.14.5

paste result of fluentd --version or td-agent --version

OpenSearch plugin version: 1.0.2

paste boot log of fluentd or td-agent
paste result of fluent-gem list, td-agent-gem list or your Gemfile.lock

OpenSearch version (optional): 6.x
OpenSearch template(s) (optional)

I found a workaround for now. Seems like (based on the stack trace) the plugin doesn't expect AWS sdk to throw an exception when trying to lookup credentials on disk. So I ended up adding this to my docker (note the exact spacing and lack of secret entry, otherwise it doesn't work)
RUN f=/root/.aws/credentials &&\
    mkdir -p `dirname $f` &&\
    echo "[default]" > $f &&\
    echo "aws_access_key_id = " >> $f

This seems to cause the code to NOT throw and continue to the next line, where it picks up the credentials from the instance profile successfully. AFAIK, it's not expected behavior...

Ah, I got it. rescue nil tail clause should be needed to catch such exceptions.


EAS does not create a push key in apple developer

Build/Submit details page URL
No response
Summary
When initializing a managed expo project, and publishing it with eas build, when you create a push key, this wil generate, but not show up within the keys of apple developer account.
Managed or bare?
Managed
Environment
expo-env-info 1.0.5 environment info:
System:
OS: Windows 10 10.0.22000
Binaries:
Node: 16.13.2 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
npm: 8.1.2 - C:\Program Files\nodejs\npm.CMD
SDKs:
Android SDK:
API Levels: 28, 29, 30, 31, 32
Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.2, 30.0.3, 31.0.0, 32.0.0, 32.1.0, 33.0.0
System Images: android-28 | Google APIs Intel x86 Atom_64, android-Tiramisu | Google APIs Intel x86 Atom_64
IDEs:
Android Studio: Version     2<IP_ADDRESS> AI-211.7628.21.2111.8139111
npmPackages:
expo: ~46.0.9 => 46.0.10
react: 18.0.0 => 18.0.0
react-native: 0.69.5 => 0.69.5
Expo Workflow: managed
Error output
No response
Reproducible demo or steps to reproduce from a blank project

Create a sample project.
Configure apple dev login within EAS.
run EAS build --platform ios
Select generate key

Where on the apple developer portal are you checking that? If you are part of multiple teams, make sure you are checking on the correct one.


Build on Linux - Ubuntu 20.10 with gcc/g++ 10

CMAKE_CXX_FLAGS need -Wno-deprecated-declarations
Build Docs HowTo Build on Linux - Ubuntu 20.10 with gcc/g++ 10

Adding  Building on raspberrypi 5.10 with gcc/g++ 8 no UI in how_to_build

Excellent work by @pcbreflux brings us a how-to-build for Ubuntu 20.10 and Raspberry Pi.


refactor: [FileLocator] reorder search() params

Description
Since the $ext parameter is already ensured and optional, it would be better to place it in last order. This allows us to access the $prioritizeApp parameter more easily without needing to define the $ext parameter first.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

This is a breaking change. Changing the parameters order will break anyone's code previously using the old ordering.
If you want, you can use named arguments instead, like $locator->search(__DIR__, ext: 'phpt');

@paulbalandan Yes, that's right, using named parameters is a bit of a hassle.

We never accept interface changes to develop branch.

@kenjis what do you think if this breaking change is pushed to the 4.6 branch?

This is not a bug fix, and I don't see much benefit.
I don't see any real use case for prioritizeApp: false.
I would not probably approve this even if it is sent to 4.6 branch.


feat(*)!: Adds wasm-pkg-pusher to repository

This PR adds a common pushing library to wasm-pkg-tools and also adds push functionality into wkg. This involved refactoring out common OCI code into the common crate

Heads up that I created this as the eventual PR, but I have not yet added pushing (I'll do that in a commit tomorrow). Mostly I created this as a heads up for @lann since I am building on top of his new common crate. I personally think there is enough of the common stuff in there that we could just merge #25 as is and then this PR before continuing on with the refactor.
Also, note that this is based on top of #28 as well so you can pretty much skip all of those commits to see what I am doing. This was rebased so that the order is
#25 -> #28 -> this PR

Ok I'll try to get #25 merged today or tomorrow

Going to close this in favor of a new PR I am opening soon


Could you please provide a version support MacOS platform ?

There is only a windows 64 version available. Could you support other platforms? All the godot suitable platforms are essential, for me, the MacOS platform is more important though.
Thanks.

Hi, I don't have a MAC at the moment, and I can't compile the version related to MacOS for the time being, but I will upload the Android version first.

我有 如何编译 mmkv 我没太搞明白。


Enhancement: Enable Forking, Editing, Regenerating, and Read-Aloud for Messages in Assistants Chat

What features would you like to see added?
Currently, in the Assistants Chat feature, users are unable to fork, edit, regenerate, or read aloud messages. These options are available in the regular chat but not supported in the Assistants Chat.
More details
Please add support for the following functionalities within Assistants Chat:

Fork Message: Allow users to fork a message and create a new conversation branch.
Edit Message: Enable users to modify a message post-sending.
Regenerate Message: Allow users to regenerate responses from assistants.
Read Aloud: Implement the read-aloud feature for messages within Assistants Chat.

Which components are impacted by your request?
UI
Pictures
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

When using Assistants API, the thread history is managed by OpenAI. It is possible to manipulate it but rather convoluted to achieve the same functionality as the other endpoints for forking, editing, regenerating.
The upside, is that I'm making my own "assistants api" alternative which will allow for all of this, nearing completion: https://github.com/danny-avila/LibreChat/issues/3607


How can I use tf.assign under mirroredstrategy

When I used tf.assign under MirroredStrategy, I got valueError(you must specify an aggregation method to update a mirroredVariavle in towercontexy)
How can I fix it?

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.


.exec() within forloop can't work

i have a model something like this:
\**
* user.petIds = ["1","2","3","4"];
*\
getPets: function(users){
    var response = [];
    for(var i=0;i<users.length;i++){
      Pet.find(users[i].petIds).exec(function(err, pets){
        if(err) return null;
        console.log("index: "+i);
        response.push({ name: users[i].name, pets: pets});
      });
    }
    return response;
  }

I want to get every pets from an array of pet ids for an array of users. However, an exec only executes after a callback which in this case causes console.log("index: "+i); to print 2, which throws an undefined error for users[i].name.
Is there anything in Sails which solve this problem? Otherwise it's impossible to use a for loop to query.

I have tried to use a forEach instead:
getPets: function(users){
    var response = [];
    users.forEach(function(user){
      Pet.find(users[i].petIds).exec(function(err, pets){
        if(err) return null;
        console.log("index: "+i);
        response.push({ name: users[i].name, pets: pets});
      });
    });
    return response;
  }

but this is still asynchronous. response is returned before the queries are completed.

Hi @holyxiaoxin and thanks for using Sails.  This forum is for posting about bugs in the Sails core; for support please try StackOverflow (looks like you already posted there) or our Google Group, Gitter chat or IRC channel at irc.freenode.org/sailsjs.  I'll close this now and answer on SO.


Services, Load Balancing, and Networking

Hey @NjDoe-hash,
What is the exact issue you are facing with Services, Load Balancing, and Networking. or do you have any suggestions to propose on these concepts? please update description with details. Also it is good if you can update title with more meaningful.
/triage needs-information

/close not-planned
No information provided.
You are welcome to provide details and reopen the issue @NjDoe-hash


Sometimes I don't need Menu.

Can I have it banned in some views? I just need to go back.

There are couple of ways of doing this.
The easiest way is to pass true to disableGestures to disable swipe.


fit: BoxFit.cover : gets applied to FadeInImage's placeholder

when i use fit: BoxFit.cover in FadeInImage.assetNetwork the BoxFit.cover gets applied to the image and the placeholder is that an Intended behaviour? Is it possible to apply it only to the image and not to the placeholder?
Flutter (Channel beta, v0.5.1, on Mac OS X 10.13.6 17G65, locale en-US)

Hello,
It would be great if we could have a different fit property for each of the image and the placeholder

The issue still persists Flutter 1.12.13+hotfix.9.
Are there any good alternatives except writing my own plugin?

With me is only working on the asset image. I have this code:
Container(
height: 300,
child: FadeInImage(
fit: BoxFit.cover,
placeholder: AssetImage("images/hivan_no_image.png"),
image: NetworkImage(imageUrl)),
),

With me is only working on the asset image. I have this code: Container( height: 300, child: FadeInImage( fit: BoxFit.cover, placeholder: AssetImage("images/hivan_no_image.png"), image: NetworkImage(imageUrl)), ),

the same thing happens to me


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Merged as trivial.


Migrate support to mysql

the sql script don't work with mysql

Yes, both the migrate and backup/restore commands at present call psql, rather than being database agnostic. I need to consider which user to call commands with as well, as for initial bootstrap we can't rely on the config db user as there is none.


MINOR fixes on the admin

FIXED bug on vertical site name on sitetree

Hey Francisco, thanks for that! You seem to be changing more than just the vertical site name here, what are the style changes on optionset for? Can you provide before/after screenshots for both cases? Have you tested in all supported browsers? IE7/8/9, FF, Chrome.


Linking issue

Hi,
I've experienced a linking issue on Ubuntu 22.04 when I install the onnxruntime libs (same as used in cmake: "onnxruntime-linux-x64-static_lib-1.17.1-glibc2_17.zip") upfront into /usr/local.
Steps to reproduce:
# install onnxruntime libs
mkdir -p /tmp/onnx && cd /tmp/onnx && wget https://github.com/csukuangfj/onnxruntime-libs/releases/download/v1.17.1/onnxruntime-linux-x64-static_lib-1.17.1-glibc2_17.zip  &&  unzip onnxruntime-linux-x64-static_lib-1.17.1-glibc2_17.zip &&  mv onnxruntime-linux-x64-static_lib-1.17.1-glibc2_17 onnxruntime && cp -a onnxruntime/* /usr/local/ && cd /tmp && rm -fr onnx*

cmake -DCMAKE_BUILD_TYPE=Release
make -j

It is detected during configuration:
-- location_onnxruntime_header_dir: /usr/local/include
-- location_onnxruntime_lib: /usr/local/lib/libonnxruntime.a

This results in this errors during linking:
/usr/bin/ld: ../../lib/libsherpa-onnx-core.a(offline-punctuation-impl.cc.o): in function `_GLOBAL__sub_I_offline_punctuation_impl.cc':
offline-punctuation-impl.cc:(.text.startup+0x17): undefined reference to `OrtGetApiBase'
/usr/bin/ld: ../../lib/libsherpa-onnx-core.a(offline-ct-transformer-model.cc.o): in function `_GLOBAL__sub_I_offline_ct_transformer_model.cc':
offline-ct-transformer-model.cc:(.text.startup+0x17): undefined reference to `OrtGetApiBase'
/usr/bin/ld: ../../lib/libsherpa-onnx-core.a(onnx-utils.cc.o): in function `_GLOBAL__sub_I_onnx_utils.cc':
onnx-utils.cc:(.text.startup+0x17): undefined reference to `OrtGetApiBase'
/usr/bin/ld: ../../lib/libsherpa-onnx-core.a(session.cc.o): in function `_GLOBAL__sub_I_session.cc':
session.cc:(.text.startup+0x17): undefined reference to `OrtGetApiBase'
/usr/bin/ld: ../../lib/libsherpa-onnx-core.a(provider.cc.o): in function `_GLOBAL__sub_I_provider.cc':
provider.cc:(.text.startup+0x17): undefined reference to `OrtGetApiBase'

When I do not install the onnxruntime libs by myself and let cmake do the onnxruntime libs installation the compilation&linking works - which is strange as it downloads the same onnxruntime-linux-x64-static_lib package...
Do you know why linking behaves different?
Thanks

please show the output of
make VERBOSE=1

Could you tell us which commit you are using?
Are you using the latest master? If not, have you tried the latest master?

Yes, I am using latest commit from master branch. It looks like the issue was introduced with older commit:
commit 9ab89c33bccbe0378f7969316e50232668846416
Date:   Fri Nov 1 11:16:28 2024 +0800

With commit:
commit a3c89aa0d8470d8eab30d7781b3dd7b9ed448046
Date:   Thu Oct 31 17:54:16 2024 +0800

the linking issue wasn't there.

I'm using latest commit from master and observed this linking issues.
During my own investigations I found the problematic commit and the last working version for me - that were the two commits I've posted.

Ah, I see. Thanks for reporting!
Will try to reproduce it locally.


Update FINOS badge on README.MD to INCUBATING

This pull request communicates the repo status as INCUBATING in accordance with project materials recorded and tracked at FINOS.

PR no longer relevant.


readme: Update build badges

This commit updates the build badges for Ubuntu 16.04 and 17.04
jenkins jobs since their names changed.
It also adds the build badge related to Fedora 26.
Fixes #116

This one can be force merged since it needs https://github.com/clearcontainers/agent/pull/119 to get fedora CI passing.

Or we can just do it in the 'right order', wait for #119 to land (soon), and then follow it up with this one...

@amshinde @iphutch can you take a look and merge please ?


"Piping streams" demo: should the ReadableStream remove data?

I think it would be better from an encapsulation perspective if the ReadableStream removed the characters. from the left-hand side. Then the writable stream would only have to add them into the div on the right-hand side.
This would mean that the WritableStream was reusable with other sources of data.

Thanks! Definitely agree. Adjusting now.


PHP 5.6 support, FIX broken build

See issue https://github.com/Azure/msphpsql/issues/45

@Jan-E - Thanks for calling attention to the compilation issue you experienced with the latest PHP RC and the extension.  We will review your pull request when we release an update to the extension, at which time we will ensure it compiles correctly with the then latest shipping PHP 5.5/5.6 versions.

@SumoLion See the discussion I had with Anatol, a colleague of yours at Microsoft:
https://github.com/php/php-src/commit/9bf95d82911dc7028c624494e9ac914f615f66ed#commitcomment-10136379


overlap assembly and coverage trimming to create VariantSequence candidates

The primary change in this branch is that I added a variant_cdna_sequence_assembly option to the call chain which determines the cDNA sequence from reads (and a corresponding --variant-sequence-assembly option to the CLI). I also added coverage statistics and trimming by coverage to VariantSequence.
Less important changes:

Reorganized ReferenceContext by moving the namedtuples from which it inherits fields into separate modules and renaming them to ReferenceSequenceKey and ReferenceCodingSequenceKey.
Turned simple functions for constructing objects (e.g. allele read from locus read) into class methods.
Caching PyEnsembl on Travis

TODO for a future branch:

If we can't establish a ReferenceContext for a variant sequence with only 1 reading supporting the very beginning of its sequence, try trimming to the next highest coverage level(s) until a reference context can be established. (https://github.com/hammerlab/isovar/issues/58)

merge overlapping paired reads into single LocusRead objects (extends the length of sequences we can construct). (https://github.com/hammerlab/isovar/issues/59)

This change is

Coverage decreased (-0.5%) to 86.411% when pulling dcfd2ed6a0d21209b125851d5e68b03cad972e18 on use-assembly-and-trimming into f60e65458272406cc97dd8b1f15277bee3b5dbf9 on master.


Added both graphs to layout

Added the anatomy and taxa graph to visualization skeleton. Made styling more readable.

I assume this was opened by accident.


Connect-ServiceFabricCluster fails when server certificate is not specified

Service Fabric Runtime Version:
7.2.432.9590
Environment:
Azure
Description:
Connect-ServiceFabricCluster without specifying the server certificate fails with
Connect-ServiceFabricCluster : FABRIC_E_SERVER_AUTHENTICATION_FAILED: 0x800b0109 or
Connect-ServiceFabricCluster : FABRIC_E_SERVER_AUTHENTICATION_FAILED: CertificateNotMatched
Observed behavior:
Service Fabric picks the wrong server certificate.
Expected Behavior:
I expect Service Fabric to use the active server certificate and nothing else. This usually works.
Workaround:
The only workaround I found is to add the parameters -ServerCommonName and -ServerCertThumbprint to specify the server certificate. Also making sure that it is the server certificate with the latest expiration date that is used.

Can you expand on this comment? "I expect Service Fabric to use the active server certificate and nothing else. This usually works".  The parameters you call out are expected to make sure you are selecting the right cert.

Can you expand on this comment? "I expect Service Fabric to use the active server certificate and nothing else. This usually works".  The parameters you call out are expected to make sure you are selecting the right cert.

The parameters you call out are expected to make sure you are selecting the right cert.

The server parameters are a list of expected values making sure you connect to the correct cluster. I don't believe that it should affect which certificate that is selected.
The cluster is configured to use specific certificates and then there are conventions for which one that is selected. The problem here seems to be that the server validates against some other certificate than the server certificate or skips some validation when the server parameters are added.
I have several clusters with various client certificates and usually you can connect without specifying the expected server certificate.

The parameters you call out are expected to make sure you are selecting the right cert.

The server parameters are a list of expected values making sure you connect to the correct cluster. I don't believe that it should affect which certificate that is selected.
The cluster is configured to use specific certificates and then there are conventions for which one that is selected. The problem here seems to be that the server validates against some other certificate than the server certificate or skips some validation when the server parameters are added.
I have several clusters with various client certificates and usually you can connect without specifying the expected server certificate.


Error with react-addons-pure-render-mixin

Description
Upgrading a project from 2.1.2 to 2.4.2 and something is going wrong with import PureRenderMixin from 'react-addons-pure-render-mixin';
The error I'm getting is:
Uncaught Error: Cannot find module "react/lib/ReactComponentWithPureRenderMixin" from "react-addons-pure-render-mixin"
This was working in 2.1.2. I've created a minimal repo from the with-react template that shows the problem here:
https://github.com/chrismcg/brunch_react_bug
Environment

Brunch: 2.4.2
Node: 5.7.0
NPM: 3.6.0
Operating system: OSX 10.9.5

package.json contents
{
  "name": "your-app",
  "description": "Description",
  "author": "Your Name",
  "version": "0.0.1",
  "repository": {
    "type": "git",
    "url": ""
  },
  "scripts": {
    "start": "brunch watch --server",
    "prod": "brunch build --production"
  },
  "dependencies": {
    "react": "~0.14.7",
    "react-dom": "~0.14.7",
    "react-addons-pure-render-mixin": "~0.14.7"
  },
  "devDependencies": {
    "auto-reload-brunch": "^2.0.0",
    "babel-brunch": "~6.0.0",
    "babel-preset-es2015": "~6.3.13",
    "babel-preset-react": "~6.3.13",
    "brunch": "^2.4.0",
    "clean-css-brunch": "^2.0.0",
    "css-brunch": "^2.0.0",
    "javascript-brunch": "^2.0.0",
    "uglify-js-brunch": "^2.0.0"
  }
}

brunch config contents
module.exports = {
  files: {
    javascripts: {
      joinTo: {
        'vendor.js': /^(?!app)/,
        'app.js': /^app/
      }
    },
    stylesheets: {joinTo: 'app.css'}
  },

  plugins: {
    babel: {presets: ['es2015', 'react']}
  }
};

May be related to https://github.com/brunch/brunch/issues/1186

Replace brunch version with brunch/brunch & npm install and tell us if that does the trick.

No joy I'm afraid, same problem in the test app linked in the issue.

Apparently, this is another regression related to #1184, which purpose was to not raise errors when optional dependencies could not be found. At first, it only used package.json's dependencies and was later extended to also work properly with shims and package.json's browser feel. However, it looks like it still lacks the peerDependencies check here, so I'm going to add it

@chrismcg https://github.com/brunch/brunch/pull/1210 should fix it
One other issue with the app you submitted is export const App = ... exports {App}, not not makes it the default.

I can confirm #1210 fixes it, made the same change locally (and fixed the App.jsx) and everything worked. Also checked my real application and that fixes it there too. Thanks!


[Bug]The "Total record count" and "Page size" should only be visible when the server side pagination is enabled. Also add a tooltip/Helper function for the same.

Description
[What happened]The "Total record count" and "Page size" should only be visible when the server side pagination is enabled. They should also have helpers to convey the functionality to the user.
Steps to reproduce the behaviour:

Drag and drop the tablet widget on the canvas
when the server side pagination toggle is disabled
check if the "Total record count" and "Page size" input boxes are displayed

expected result : The "Total record count" and "Page size" input boxes should not be displayed when the server side pagination is disabled. Also add a tooltip/Helper function to the "Total record count" and "Page size".
Important Details

Version: Cloud
OS: Windows
Browser Chrome
Environment Release

check discussion in #2230

The total record count will be displayed when server-side pagination is enabled and the page size is removed as per the new changes so now it is working as per the requirments