elfshaker gc

[x] snapshot deduplication
[x] object graph tracing
[x] fs-based lock
[x] performance improvements (compute_snapshot_checksums is around 96% CPU time)
[x] API design
[x] Documentation

Closes #17

Nice!
Maybe you saw it, github recently wrote an article about git's GC. https://github.blog/2022-09-13-scaling-gits-garbage-collection/ Worth a read in case it inspires anything in you.
I'd appreciate a brief high level description (perhaps a source code comment?) of what GC aims to do and how it is achieved it (and if there are any gotchas, or things you do to avoid gotchas). I guess the main thing in my mind is to cope with the case where you potentially have multiple elfshaker processes sharing the elfshaker_data directory, for which I guess "fs-based lock" on your checklist will be the most straightforward answer.
For the performance issue of detecting identical snapshots, I'd like to see us add a field which indicates the snapshot hash to the index.

Maybe you saw it, github recently wrote an article about git's GC.

I had not seen this, thanks.

I'd appreciate a brief high level description

Sure, it's still WIP. I've not identified any gotchas, but our case is simpler than git.

I'd like to see us add a field which indicates the snapshot hash to the index.

I think that's a very good idea. We already had a few other changes to consider for 1.0 (file permissions and UTF-8/cross-platform file paths). There are however ways to speed up compute_snapshot_checksums

Ping for code review.

I'd appreciate a brief high level description (perhaps a source code comment?)

I've just added some more detailed descriptions of how GC is implemented in gc.rs, doc comments and commit message.

and if there are any gotchas, or things you do to avoid gotchas

None that I can think of. But then again maybe you will find some holes in the approach/implementation :)

I guess the main thing in my mind is to cope with the case where you potentially have multiple elfshaker processes

I think I've managed to handle that nicely -- Repository::open takes a shared file-based lock on the directory, and that gets upgraded to an exclusive lock when we need to delete stuff (so no elfshaker store/pack could be in progress while we're doing this).

Hi, question about the default behavior. so if I just do elfshaker gc does it actually do anything? or must I always specify an action -s , -o etc? I can't seem to make out from the docs or help.

@Mistuke
elfshaker gc without options should output
[ERROR (main) 1.092µs]: Specify what to GC (--loose-snapshots, --loose-objects). Nothing to do!
[ERROR (main) 33.774µs]: *FATAL*: Invalid options!

@veselink1 thanks for this! gc is working great :)

Thanks for your patience, and thanks for testing @Mistuke!


Any plan for 1.19.2?

1.19.2 as a major release for 1.19.x, hopefully there are plans for 1.19.2,thanks!

No, unfortunately I will not be supporting 1.19.2. I am only supporting the latest minor version for every major version with the exception of the latest major version where I will support all minor versions until the next major version releases.
The plan is to support 1.17.1, 1.18.2, 1.19.4, 1.20.1, 1.20.2, 1.20.4, 1.20.5 until 1.21 comes out where I will likely stop supporting 1.20.1, 1.20.2, and 1.20.4.
Just out of curiosity, is there any specific reason you do not want to update to 1.19.4?

Eumm,just many mods update 1.19.2 and skip other versions of 1.19.x


Fixes #193 Removed moment construction, fixed data pattern for OpenMR…

The New Patient registration issue is solved.
Next pair programming session we need to include tests @Guimino


Avoid calling next() in Express middleware

Fixes #557.
Fixes #752.
Changes proposed in this pull request:

Avoid calling next() in express middleware after res.end(). This causes other middleware to be called afterward, and since this is a rendering middleware, it will throw

[ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your PR! It will be in the next release 🚀


When user doesn't have account yet, buy button shouldn't say same thing as buy button they eventually get to actually use

For first time users, it makes it confusing that after they get through the account prep flow they have to click Buy in exactly the same way they already did a few screens ago.

We're already checking if account is defined on this screen, so we can use that same boolean to conditionally change the text of the button too

Maybe a bit of text above the button with the button saying "set up account":
Want to buy this land?
SET UP ACCOUNT


Why not having both community and news redirect to the same page with different anchor ?

I think these 2 pages should be merged one, communities being at the top, and news just below.
It would make sense from a user point of view.
We could still keep 2 links to that page on the top header, each one pointing to a different anchor, though.

I don't think this makes sense now that I've vastly expanded "Communities" in #83


CI: Fix nightly lint error & fix rust nightly version

Fixes nightly lint error
Follow the discussion from @portersrc , I fix the version of rust nightly compiler in GHA to avoid unexpected CI errors everytime new rust nightly version is released.

there is a case for testing against nightly: you will pick up changes early that will propagate to stable in later releases, like the last nightly breakage that we've seen.

I made a few comments in https://github.com/confidential-containers/confidential-containers/issues/193
I would just drop nightly @mkulke. rust-nightly doesn't necessarily hit stable (if I understand correctly), and even rust-beta is overhead we don't need until we're ready to bump to a stable version.
But FWIW, I'd say @Xynnn007's pinned nightly is better than nightly, b/c of the reasons he stated. Arbitrary date is fine.

I made a few comments in confidential-containers/confidential-containers#193
I would just drop nightly @mkulke. rust-nightly doesn't necessarily hit stable (if I understand correctly), and even rust-beta is overhead we don't need until we're ready to bump to a stable version.
But FWIW, I'd say @Xynnn007's pinned nightly is better than nightly, b/c of the reasons he stated. Arbitrary date is fine.

no, not everything that hits nightly will end up in stable, but more specifically: if something doesn't compile in nightly today it's likely that eventually it will also break in stable, because the original behaviour was based on a bug. not sure if this is a hard rule, but that has been my experience. So in this respect nightly can be a good indicator of upcoming changes that need be dealt with.
that said, I wouldn't mind dropping beta and nightly (I don't see the point in testing against some revision of nightly, but I might be missing something) from the matrix. I don't think the project is affected too much by those changes.

@mkulke Right. Nightly test will tell us the potential error asap. however, there might be cases where indirect dependency breaks, which will block the daily development. At the same time, if we update nightly version periodically, we also might need to handle a bunch of errors one time.
This is a every-day-a-little vs a-batch-one-time problem. I am okay with both tbh temporarily as they both has pros and cons. If finally it is decided not to fix nightly version, I will drop the commit in this PR.

yeah, this is mostly bikeshedding, so I while I have opinions, it probably does not matter 😅  but I'm intellectually curious: what good would pinning a nightly version does vs just dropping nightly from the matrix?
would there be a checkbox item on the release list that says "bump the nightly version and fix all potential errors?"

Personally I think I lean more towards dropping nightly. We don't make any claims about supporting it. I don't see much benefit in testing with it.

good. So it seem clear that we do not need to check against nightly and beta anymore. Let me just delete them in this PR : )

Thanks @Xynnn007 for fielding this. Maybe catch kbs-e2e and kbs-docker-e2e in this PR, as well.


Semantics for contract inheritance

Currently, contract inheritance semantics is undefined. Decorators inside a class which does not have contract decorator do not get processed.
We should clarify how contract inheritance should work, or prevent inheritance entirely in favor of composition.

Working on https://github.com/tradatech/sunseed repo.


fix: curl import ui fixes wrt to design system

Description
Changed the CURL Import page design with respect to design system.
Fixes #11647
Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Comparing with the designs.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/curl-ui

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
55.8 (-0.02)
37.17 (0)
35.14 (-0.06)
56.14 (-0.01)

:red_circle:
app/client/src/pages/Editor/APIEditor/CurlImportForm.tsx
48.15 (-26.14)
87.5 (-1.39)
4.35 (-20.65)
49.02 (-29.11)

:green_circle:
app/client/src/utils/WorkerUtil.ts
89.76 (0.78)
72.55 (1.96)
100 (0)
93.33 (0.95)

/ok-to-test sha=3fc7937


feat: add old crc migration and fix openapi schema

closes #28
closes #25

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 36 (41.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 86.907%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

components/renku_data_services/crc_migrations/versions/0044b54a89b9_migrate_old_crc_tables.py
15
36
41.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.6%

Covered Lines:
2217

Relevant Lines:
2551

💛  - Coveralls


Add more quotes

What does this PR accomplish?

Adds more Ron Swanson quotes

Notes/Questions

I have tried to check for duplicates but if I added some by mistake, please let me know and I'll fix it
One quote contains a swear word so I SFW'd it like you did with the rest of them
The last quote "Please and thank you" is so legendary that I thought it deserves to also live on its own. I am aware that you've used it at the end of two previous quotes. If you don't agree with this, I will remove it.
I've also found some sources that list the exact season and the episode in which the quote originally appeared. If you'd like to expand the API with the additional info, please let me know and I'll gladly help.

Thank you for putting together this list. It made my day while reminding me of some unforgetable funny moments 😊

Hey @nemanjaglumac,
Thanks so much for the PR; there's no such thing as too many Ron Swanson quotes! 😁 I've just merged this and will deploy it shortly.
Great idea regarding the season and episode metadata. With this in mind, perhaps we could introduce v3/quotes/:count endpoint that returns said metadata if available, or rather the quotes array will be updated to the new format and the legacy endpoints can be updated to adhere to the existing string[] format. The new format could be:
[
  {
    "text": "I would prefer she ask for my permission so I could say no. I like to say no; it lowers their enthusiasm",
    "season": 2,
    "episode": 6
  }
]

Going further, new endpoints could be exposed to return all the quotes for a given season and/or episode.
Thanks for the idea! 😁

@nemanjaglumac Happy to say that your changes have now been deployed! 😊
http://ron-swanson-quotes.herokuapp.com/v2/quotes/search/1978

@jamesseanwright woohooo. Let them grow :)
Btw, if you need some help with the new version, just let me know. I'd be happy to contribute.
I have some WIP "Ron Swanson Quote Generator" (still private repo) written in ClojureScript. I'll let you know when I add some cosmetic touches to it.


How to add F4 paper size?

I tried to add custom F4 size inside paper.css then it messed-up.
Please help. How to add it correctly?

did your problem solved?

still not yet

are you using jQuery ?

nope, I just modified A4 to F4 size


Few icons don't render.

Discord, Twitter and few other icons don't render properly for me.
How it looks on my website.

Code snippet from the Elements:

Hi @dnikoloski,
That's simply not possible. All SVG icons are rendered.
Could you give further explanation on how did you setup the theme or/and your browser (if it is hardened, has some blockers enabled etc.) If possible could you please test with Vanilla Chromiun or Firefox browsers?

Hi @1bl4z3r, thanks for reply.
You are totally right, It was my bad, I forgot to check out layouts directory, that had a few custom icons in it and overwrote the theme's ones.
Solved now.

That's the LMAO moment, if I have ever seen one.
Glad it got resolved.


PHP typing greater-than sign

After typing greater-than sign in PHP file, intellisense suggestion list pops up automatically, and so, when press 'Enter' key, the first suggested PHP global variable in the list is typed. Is there any configuration options to set the suggestion list manually using the keyboard shortcut? ex: "Ctrl + ."   . Otherwise, to press "Esc" key each time after greater-than sign is very inconvenient.

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:32:36.023Z)
OS Version: Windows_NT x64 10.0.10586
Extensions:

Extension
Author (truncated)
Version

vscode-eslint
dba
1.4.3

php-debug
fel
1.12.1

phpcs
ika
0.7.0

sublime-keybindings
ms-
3.0.3

team
ms-
1.122.0

Steps to Reproduce:

Reproduces without extensions: Yes/No

/duplicate of https://github.com/Microsoft/vscode/issues/37919


MullvadVPN.MullvadVPN.beta version 2024.5-beta1

Moves beta releases into their own identifier so it doesn't propose a beta version by default (#137814) but folks who want them (like me) can still install them through WinGet.
Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Verify:

Hi @mahtaran,
Since the application displays 2024.5-beta1, but writes 2024.5.0-beta1 to the Registry (adding a .0 in the middle), this manifest should probably have a DisplayVersion. What do you think?

Good eye @stephengillie, did not think to check for that. I'm not too familiar with how to add such a field to the manifest, but I've made an attempt, please do check if this is the correct way to do so.


Update version: HarshKhandeparkar.RainbowBoard version 0.8.1

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/114957&drop=dogfoodAlpha

Manifest Error: Duplicate installer entry found.

Manifest Error: Duplicate installer entry found.


Quote/Brace matching breaks in Windows 10

Last 15 Keys:
p r o m p t - f o Tab Spacebar - Tab Spacebar "
Exception:
System.Management.Automation.RuntimeException: Unable to find type [PSConsoleUtilities.PSConsoleReadLine].
at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
at System.Management.Automation.Interpreter.ActionCallInstruction2.Run(InterpretedFrame frame)    at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)    at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)    at System.Management.Automation.Interpreter.Interpreter.Run(InterpretedFrame frame)    at System.Management.Automation.Interpreter.LightLambda.RunVoid1[T0](T0 arg0)    at System.Management.Automation.ScriptBlock.InvokeWithPipeImpl(ScriptBlockClauseToInvoke clauseToInvoke, Boolean createLocalScope, Dictionary2 functionsToDefine, List1 variablesToDefine, Err orHandlingBehavior errorHandlingBehavior, Object dollarUnder, Object input, Object scriptThis, Pipe outputPipe, InvocationInfo invocationInfo, Object[] args)    at System.Management.Automation.ScriptBlock.<>c__DisplayClassa.<InvokeWithPipe>b__8()    at System.Management.Automation.Runspaces.RunspaceBase.RunActionIfNoRunningPipelinesWithThreadCheck(Action action)    at System.Management.Automation.ScriptBlock.InvokeWithPipe(Boolean useLocalScope, ErrorHandlingBehavior errorHandlingBehavior, Object dollarUnder, Object input, Object scriptThis, Pipe outputP ipe, InvocationInfo invocationInfo, Boolean propagateAllExceptionsToTop, List1 variablesToDefine, Dictionary2 functionsToDefine, Object[] args)    at System.Management.Automation.ScriptBlock.DoInvoke(Object dollarUnder, Object input, Object[] args)    at Microsoft.PowerShell.PSConsoleReadLine.<>c__DisplayClass67.<ProcessOneKey>b__65()    at Microsoft.PowerShell.PSConsoleReadLine.<>c__DisplayClass63.<CalloutUsingDefaultConsoleMode>b__62()    at Microsoft.PowerShell.PSConsoleReadLine.CalloutUsingDefaultConsoleMode[T](Func1 func)
at Microsoft.PowerShell.PSConsoleReadLine.ProcessOneKey(ConsoleKeyInfo key, Dictionary`2 dispatchTable, Boolean ignoreIfNoAction, Object arg)
at Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics)
HAL9000@ P:>

If you have a custom key handler for PSReadLine defined in your profile and you are on PowerShell 5.0 you need to make sure any references to [PSConsoleUtilities.xxx] have been replaced with [Microsoft.PowerShell.xxx].

@rkeithhill Thank you for the useful info. I am not yet affected but this issue but I will be eventually. Your suggestion is clear. The problem is that on some machines I will use the old PSReadLine and on others the new with the same portable profile. Can you recommend the way how to distinguish new and old PSReadLine in the PowerShell profile and use a proper class? Is it the version of Windows or PSReadLine or something else? I cannot experiment now because I do not have Windows 10 yet but I would like to be prepared beforehand. Perhaps I am not alone with such a scenario.

I would use a variable for the namespace and then set that conditionally based on this:
(Get-Command Get-PSReadlineKeyHandler).ImplementingType.FullName -match 'Microsoft.PowerShell'

If that is true set $psrl = [Microsoft.PowerShell.PSConsoleReadLine] else $psrl = [PSConsoleUtilities.PSConsoleReadLine].

@rkeithhill Thank you. If I were the author I would mention this or similar trick somewhere in the manual.

Closing, see also #266.
I like the suggestion from @rkeithhill, but I should just publish a new release so the namespaces match.


nucleoATAC Invalid Region error

Hello, I'm getting the following error when running nucleoATAC on sorted BAM files and the output of MACS2 as inputs. I'm using python 2.7, numpy 1.9.3, scipy 0.16.0, cython 0.23.3, pysam 0.8.3.
Any help would be appreciated.
-R
===============
Relevant error text:
(ATACseq)[bainerr@rescomp5008 ATACpilot]$ nucleoatac run --bed /gne/home/bainerr/Workspace/ATACseq/Jackson/ATACpilot/macs2_results/filtered.lungline_10_peaks.broadPeak --bam /gne/home/bainerr/Workspace/ATACseq/Jackson/ATACpilot/filtered.lungline_10.bam --fasta /gne/research/apps/ngs_pipeline/3.14.2/x86_64-linux-2.6-sles11/genome_files/GATK/NCBIM37.fa --out lungline_nATAC_10
Command run:  /gne/home/bainerr/bin/nucleoatac run --bed /gne/home/bainerr/Workspace/ATACseq/Jackson/ATACpilot/macs2_results/filtered.lungline_10_peaks.broadPeak --bam /gne/home/bainerr/Workspace/ATACseq/Jackson/ATACpilot/filtered.lungline_10.bam --fasta /gne/research/apps/ngs_pipeline/3.14.2/x86_64-linux-2.6-sles11/genome_files/GATK/NCBIM37.fa --out lungline_nATAC_10
nucleoatac version 0.2.1
start run at: 2015-10-09 13:53
---------Step1: Computing Occupancy and Nucleosomal Insert Distribution---------
Caught exception when processing:
10      129994094       129994223       None    None    +
Traceback (most recent call last):
File "/gne/home/bainerr/.local/lib/python2.7/site-packages/NucleoATAC-0.2.1-py2.7.egg/nucleoatac/run_occ.py", line 30, in _occHelper
occ.process(params)
File "/gne/home/bainerr/.local/lib/python2.7/site-packages/NucleoATAC-0.2.1-py2.7.egg/nucleoatac/Occupancy.py", line 226, in process
self.makeBiasMat()
File "/gne/home/bainerr/.local/lib/python2.7/site-packages/NucleoATAC-0.2.1-py2.7.egg/nucleoatac/Occupancy.py", line 195, in makeBiasMat
bias_track.computeBias(self.params.fasta, self.params.chrs, self.params.pwm)
File "/gne/home/bainerr/.local/lib/python2.7/site-packages/NucleoATAC-0.2.1-py2.7.egg/pyatac/bias.py", line 88, in computeBias
sequence = seq.get_sequence(self, fasta)
File "/gne/home/bainerr/.local/lib/python2.7/site-packages/NucleoATAC-0.2.1-py2.7.egg/pyatac/seq.py", line 18, in get_sequence
sequence = handle.fetch(chunk.chrom, chunk.start, chunk.end)
File "pysam/cfaidx.pyx", line 182, in pysam.cfaidx.FastaFile.fetch (pysam/cfaidx.c:3370)
ValueError: invalid region: start (129993838) > end (129993255)
()
Traceback (most recent call last):
File "/gne/home/bainerr/bin/nucleoatac", line 291, in
main()
File "/gne/home/bainerr/bin/nucleoatac", line 75, in main
run_occ(occ_args)
File "/gne/home/bainerr/.local/lib/python2.7/site-packages/NucleoATAC-0.2.1-py2.7.egg/nucleoatac/run_occ.py", line 116, in run_occ
tmp = pool1.map(_occHelper, zip(j,itertools.repeat(params)))
File "/gne/home/bainerr/miniconda3/envs/ATACseq/lib/python2.7/multiprocessing/pool.py", line 251, in map
return self.map_async(func, iterable, chunksize).get()
File "/gne/home/bainerr/miniconda3/envs/ATACseq/lib/python2.7/multiprocessing/pool.py", line 567, in get
raise self._value
ValueError: invalid region: start (129993838) > end (129993255)

I suspect given the coordinates that something strange is happening with that peak because it is at the end of the chromosome; I think such peaks ought to be handled correctly (I have done some tests to see that both peaks at very beginning and end are handled correctly) but that they might not be if the chromosome length information differs between the fasta and the bam file.  Can you confirm that the fasta file provided matches exactly the genome file used for alignment? i.e. if you do  in python interpreter:
from pyatac.utils read_chrom_sizes_from_bam, read_chrom_sizes_from_fasta
read_chrom_sizes_from_fasta('name_of_fasta_file')['10']
read_chrom_sizes_from_bam('name_of_bam_file')['10']

are the results the same?

Hi Alicia,
Thanks for your prompt attention. I'm pretty sure that the bams were
aligned using the correct assembly, but I'm afraid that I don't program in
python and need a bit more direction. I am currently getting a syntax error
when run that code within the interpreter (within the environment that I
use to run nucleoATAC):

from pyatac.utils read_chrom_sizes_from_bam, read_chrom_sizes_from_fasta
File "", line 1
from pyatac.utils read_chrom_sizes_from_bam,
read_chrom_sizes_from_fasta
^
SyntaxError: invalid syntax

I'm sure it's something obvious?
-R
On Thu, Oct 15, 2015 at 7:16 PM, Alicia Schep<EMAIL_ADDRESS>wrote:

I suspect given the coordinates that something strange is happening with
that peak because it is at the end of the chromosome; I think such peaks
ought to be handled correctly (I have done some tests to see that both
peaks at very beginning and end are handled correctly) but that they might
not be if the chromosome length information differs between the fasta and
the bam file. Can you confirm that the fasta file provided matches exactly
the genome file used for alignment? i.e. if you do in python interpreter:
from pyatac.utils read_chrom_sizes_from_bam, read_chrom_sizes_from_fasta
read_chrom_sizes_from_fasta('name_of_fasta_file')['10']
read_chrom_sizes_from_bam('name_of_bam_file')['10']
are the results the same?
—
Reply to this email directly or view it on GitHub
https://github.com/GreenleafLab/NucleoATAC/issues/20#issuecomment-148577202
.

Sorry about that, I left out a crucial word-- should be:
from pyatac.utils import read_chrom_sizes_from_bam, read_chrom_sizes_from_fasta

Ha! You were right- they apparently updated the default genome assembly
here a couple of days ago. Everything seems to be running here now, I'll
start another thread if I run into additional problems.
Thanks for your help with this.
On Fri, Oct 16, 2015 at 9:34 AM, Alicia Schep<EMAIL_ADDRESS>wrote:

Sorry about that, I left out a crucial word-- should be:
from pyatac.utils import read_chrom_sizes_from_bam, read_chrom_sizes_from_fasta
—
Reply to this email directly or view it on GitHub
https://github.com/GreenleafLab/NucleoATAC/issues/20#issuecomment-148762963
.

Hi Alicia,
I'm afraid that I am running into a similar issue, this time during the nfr calling step. I'm sure that my alignment and fasta match now, and notably the code appears to progress despite throwing the errors. I thought I'd pass them along to see if you have any insight about what could be going on.
============
---------Step5: Calling NFR positions-------------------------------------------
Traceback (most recent call last):
File "/gne/home/bainerr/miniconda3/envs/ATACseq/lib/python2.7/site-packages/nucleoatac/run_nfr.py", line 26, in _nfrHelper
nfr.process(params)
File "/gne/home/bainerr/miniconda3/envs/ATACseq/lib/python2.7/site-packages/nucleoatac/NFRCalling.py", line 105, in process
self.getBias()
File "/gne/home/bainerr/miniconda3/envs/ATACseq/lib/python2.7/site-packages/nucleoatac/NFRCalling.py", line 83, in getBias
self.bias.computeBias(self.params.fasta, self.params.chrs, self.params.pwm)
File "/gne/home/bainerr/miniconda3/envs/ATACseq/lib/python2.7/site-packages/pyatac/bias.py", line 88, in computeBias
sequence = seq.get_sequence(self, fasta)
File "/gne/home/bainerr/miniconda3/envs/ATACseq/lib/python2.7/site-packages/pyatac/seq.py", line 18, in get_sequence
sequence = handle.fetch(chunk.chrom, chunk.start, chunk.end)
File "pysam/cfaidx.pyx", line 182, in pysam.cfaidx.FastaFile.fetch (pysam/cfaidx.c:3370)
ValueError: invalid region: start (195585088) > end (195471971)
Traceback (most recent call last):
File "/gne/home/bainerr/miniconda3/envs/ATACseq/bin/nucleoatac", line 291, in
main()
File "/gne/home/bainerr/miniconda3/envs/ATACseq/bin/nucleoatac", line 83, in main
run_nfr(nfr_args)
File "/gne/home/bainerr/miniconda3/envs/ATACseq/lib/python2.7/site-packages/nucleoatac/run_nfr.py", line 104, in run_nfr
tmp = pool1.map(_nfrHelper, zip(j,itertools.repeat(params)))
File "/gne/home/bainerr/miniconda3/envs/ATACseq/lib/python2.7/multiprocessing/pool.py", line 251, in map
return self.map_async(func, iterable, chunksize).get()
File "/gne/home/bainerr/miniconda3/envs/ATACseq/lib/python2.7/multiprocessing/pool.py", line 567, in get
raise self._value
ValueError: invalid region: start (195585088) > end (195471971)


authenticatedRoute: beforeModel hooks called on parent routes before authentication is checked

When using authenticatedRoute on a hierarchy of routes I am finding that the beforeModel hook is called on all the parent routes before the authentication is checked. I see this behaviour:

The beforeModel hooks on the parent routes are called
The users authenticated state is checked (the user is redirected if they are not authenticated)
The beforeModel hook on the current route is called

I would have expected the default behaviour to be that authentication was checked before any model hooks were fired? I am using the beforeModel hook in my parent route to validate the users token has additional claims beyond their basic authentication status.
I've worked around it by simply checking their authentication status in the beforeModel hook, but I was a bit surprised to find this behavior.
I've had a dig around in authenticated-route-mixin.js but my ember route skills are not sufficient for me to fix it!

Closing this, the project that was using Torii no longer does so, so I'm not sure if it's still an issue.


updated to three.js r151

Lots of rendering improvements this time, most notably that multiple UV channels and texture transforms are fully and properly supported now, which is a huge win especially for models using a tiled texture swatch as well as a non-tiled AO map, e.g. Sheen Chair:

Further proof:

Also significant improvement of back-side reflections of transmissive materials:

I need to dig a little deeper into what's changed with punctual lights:

And also with the Glam sofa:

@mrdoob This is looking great overall! I can't quite figure out why the last two renders changed. Not saying it's a regression, but I'd like to understand for sake of glTF compliance and other renderers. Any thoughts?

Yeah, @mrdoob there's definitely something going in here; these used to look a lot more similar: https://modelviewer.dev/fidelity/#khronos-LightsPunctualLamp
This one's also looking not great - it was too dark before, and now it's much too light: https://modelviewer.dev/fidelity/#khronos-GlamVelvetSofa

@mrdoob Okay, my best guess is whatever is causing that change to the LightsPunctualLamp also blew out our default lighting, so that's become a blocker.

Okay, nevermind, I realized I just got hit by https://github.com/mrdoob/three.js/pull/25479. The one-liner fixed it and it only took an hour to figure it out, so not bad overall. And apparently GlamVelvetSofa has a punctual light (!?!).

Hi, this works great on model viewer and android, but when autogenerated usdz file is opened on Iphone second UV map doesn't work. Is there some naming rule for UV maps, or it just isnt supported for USDZ autogeneration?

The current state of USDZ is a bit of a mess:
https://twitter.com/mrdoob/status/1654494500230778887

In theory this should work but I don't think it does.
https://github.com/mrdoob/three.js/pull/25996

The current state of USDZ is a bit of a mess:
https://twitter.com/mrdoob/status/1654494500230778887

In gerneral autogeneration works perfectly except for models with animations and multiple uv maps

@elalish do you maybe have some info about multiple UV sets and USDZ autogeneration. Does this work or still isnt supported? I have tried with only AO on the second set and I cant make it work… thanks!

I'm guessing you're looking for this, which we can pull down at the end of the month when it's released.

These two PRs implemented multiple uv sets:

https://github.com/mrdoob/three.js/pull/25996
https://github.com/mrdoob/three.js/pull/26009

@elalish @mrdoob thank you for help, I'm not a developer, so maybe I don't understand everything the best...
But I have made some tests..
I have created a very simple scene wher AO is baked on second UV map

It works correct in model viewer but after autogeneration second uv-map is not displayed correctly

But when I convert glb file using this online convertor (https://arize.io/tools/usdz-converter/) to usdz
On Iphone it works correctly! It also works right on https://www.usdz-viewer.net/

Here are the files:
cube.zip
So somehow this online converter is converting in the right way comparing to autogeneration.
So if I understand correctly, this will be fixed by the end of the month as elalish wrote (https://github.com/mrdoob/three.js/pull/26023)?
or i got it wrong? :)
Thanks!

Great!! off course I will test in detail when it will be released


series file type checking

Overview
This implements doing type checking per series. This PR introduces the tsdb.SeriesID and tsdb.SeriesIDTyped values that abstract the internal representation of a series id. This allowed the compiler to track down all of the places that needed to be modified, flagging the spots that needed consideration. The ID field is unfortunately exported on the types due to an issue with some reflect like tests (the diffing business). If this is considered to be too overbearing of a change, I wouldn't mind changing back to either typed uint64s or naked uint64s now that the hard work is done.
The next large portion of the PR is to have the code use a new abstraction: the tsdb.SeriesCollection. This type exists so that we can avoid passing around 4 parallel slices both in and out of many methods. It also helps with the logic of invalidating bad points, keeping track of partial write errors, and shuffling around the slices cheaply.
The portion of the complexity in the collection comes from how the series file handles doing lookups/writes of new series in parallel across its partitions. Since that's also the spot where we know what type the series id is supposed to be, invalidating the series at that moment becomes challenging. Using the fact that most writes won't have a problem, we make it cheap and allocation free in the case that there are no conflicts.
Lastly, one change I would like to draw attention to is in tsi1. When creating series in tsi1, it would first split the work into 8 subsets and pass those to its partitions. Then, each tsi1 partition would individually pass their subset of the data to the series file. Then, the series file would split that work against its 8 partitions, causing a total of 64 splits, and much ado. Instead, tsi1 now passes the entire collection to the series file before splitting the work for its individual partitions. Not only do I think this is better, it makes the job of the series file efficiently dropping incorrectly typed series easier since it can operate on all of the data at once, and no merging of the individual pieces is required.
Benchmarks
Some benchmark results for inmem[1], names elided for space:
old time/op    new time/op    delta
  2.70ms ± 1%    2.64ms ± 1%  -2.31%          (p=0.000 n=8+7)
   314µs ± 2%     315µs ± 1%    ~             (p=0.442 n=8+8)
   314µs ± 4%     315µs ± 1%    ~             (p=0.536 n=8+7)
  2.02ms ± 1%    2.00ms ± 1%  -0.88%          (p=0.001 n=8+7)

old alloc/op   new alloc/op   delta
   477kB ± 0%     477kB ± 0%  -0.04%          (p=0.000 n=8+8)
   15.0B ± 0%     15.0B ± 0%    ~     (all samples are equal)
   15.0B ± 0%     15.0B ± 0%    ~     (all samples are equal)
   501kB ± 0%     501kB ± 0%  -0.04%          (p=0.000 n=8+8)

old allocs/op  new allocs/op  delta
    37.0 ± 0%      38.0 ± 0%  +2.70%          (p=0.000 n=8+8)
   0.00 ±NaN%     0.00 ±NaN%    ~     (all samples are equal)
   0.00 ±NaN%     0.00 ±NaN%    ~     (all samples are equal)
    23.0 ± 0%      23.0 ± 0%    ~     (all samples are equal)

tsi1 has a more comprehensive benchmark suite, but I had trouble running it, so I used inch to create 30 million series by running inch -b 10000 -c 20 -t 10,10,100000,3 -m 1 -p 1 -v:

strategy
vals/sec
seconds
ratio

no checking
80829.1 val/sec.
371.2 seconds
1x

checking
81896.5 val/sec.
366.3 seconds
0.98x

which I believe can be attributed to noise.

[1] The inmem benchmarks were also benchmarking the initial add in some situations, causing the allocation amounts to vary based on how many times it ran, since only the first time allocated. The above benchmarks include backported changes to fix this.

During a run of megacheck the following issues were discovered:
/tmp/265371993/src/github.com/influxdata/influxdb/tsdb/series_file.go:471:6: type uint64Slice is unused (U1000)
/tmp/265371993/src/github.com/influxdata/influxdb/tsdb/series_id.go:68:2: const seriesIDStructSize is unused (U1000)
/tmp/265371993/src/github.com/influxdata/influxdb/tsdb/series_id.go:69:2: const seriesIDTypedStructSize is unused (U1000)

Circle CI seems to be exposing this failure:
panic: interface conversion: tsm1.Value is tsm1.IntegerValue, not tsm1.FloatValue

goroutine 42196 [running]:
github.com/influxdata/influxdb/tsdb/engine/tsm1.(*floatAscendingCursor).peekCache(0x1b0bae70, 0x1, 0x2, 0x2, 0x24)
	/root/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/iterator.gen.go:410 +0xb1
github.com/influxdata/influxdb/tsdb/engine/tsm1.(*floatAscendingCursor).nextFloat(0x1b0bae70, 0x8d0c93c, 0x0, 0x1, 0x80556d8)
	/root/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/iterator.gen.go:441 +0x25
github.com/influxdata/influxdb/tsdb/engine/tsm1.(*floatIterator).Next(0x1acd4240, 0x87de2e0, 0x1, 0xf54b62b8)
	/root/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/iterator.gen.go:236 +0x556
github.com/influxdata/influxdb/tsdb_test.TestShard_WritePoints_FieldConflictConcurrentQuery.func2(0x1acb4140, 0x1ad64e40)
	/root/go/src/github.com/influxdata/influxdb/tsdb/shard_test.go:627 +0xa95
created by github.com/influxdata/influxdb/tsdb_test.TestShard_WritePoints_FieldConflictConcurrentQuery
	/root/go/src/github.com/influxdata/influxdb/tsdb/shard_test.go:580 +0x3d2
FAIL	github.com/influxdata/influxdb/tsdb	8.708s

I have a feeling this change is causing it. Tickling it out with cpulimit.

Alright, I cannot for the life of me get this to fail locally, so I'm going to start the arduous process of pushing commits with a bunch of temporary logging to extract more information out of CircleCI.

The issue discovered here by CircleCI is now #10169.


Use live and template secrets so git won't complain

As I have seen this in other projects I recommend this be done here as well.
So what I recommend is that the secrets folder has two subfolders called live/ and template/. The template folder should have all the secrets in it that are required by docker-compose and should be left untouched. Then there should be a make command used to generate secrets inside the live folder (with or without password and certificate generation). The live folder should be excluded with .gitignore. This is quite practical for not commiting local changes to the secrets and no complains from git when pulling new changes when deploying.
I need some feedback if this feature is practical so I can then make it.

I like this approach. The only flaw I see is that for some secrets you may want to set a value and have it stick, e.g. https://github.com/Islandora-Devops/isle-dc/blob/development/secrets/DRUPAL_DEFAULT_CONFIGDIR . How would that be accomplished in this structure?
CC @g7morris who I know is also interested in this topic.

The generator would generate from existing template files and would just
treat some files as exceptions and act accordingly. Nice that you pointed
that out.
On Wed, 30 Jun 2021, 19:21 Noah W. Smith, @.***> wrote:

I like this approach. The only flaw I see is that for some secrets you may
want to set a value and have it stick, e.g.
https://github.com/Islandora-Devops/isle-dc/blob/development/secrets/DRUPAL_DEFAULT_CONFIGDIR
. How would that be accomplished in this structure?
CC @g7morris https://github.com/g7morris who I know is also interested
in this topic.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Islandora-Devops/isle-dc/issues/165#issuecomment-871590120,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEPGMCAUQZY7OGP3VKYSBLTVNHA7ANCNFSM47R62XXQ
.

Ok- sounds like an excellent approach. I'd say go for it!
Other interested parties may be @dannylamb and @nigelgbanks

I have no issues with that approach @Tristaan . Sounds better than live editing secrets.


Update mockService.ts

这里有个bug，类名错误。会导致mock接口本地运行无法保存
IPublicEnumTransformStage->IPublicEnumIPublicEnumTransformStage

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

CLA麻烦签署下


Depend on rack < 2 to restore Ruby 2.1 compat

Rack 2.0.1 was just released and it requires Ruby 2.2+
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

@chef/client-core can I get some 👍 s on this?

🚢 :it:

👍


Which SDK and Documentation

You have three SDKs and the documentation is a blend of all of them. I have no idea which to use, and what documentation to follow. Please advise.

https://github.com/Judopay/JudoKit-iOS (this is the most recently updated on GitHub and the one the documentation says to use - but the API is totally different from the docs)

https://github.com/Judopay/JudoKitObjC (this was also updated this year, and seems to reflect the documentation's API)

https://github.com/Judopay/JudoKit (this one is in Swift but we wont get it through Apple because it uses UIWebView)

@adamwaite I was using JudoKit, updated to JudoKitObjC due to the UIWebView issue, and it looks like I now need to switch to JudoKit-iOS for which there doesn't seem to be any documentation.
Did you manage to resolve this issue yourself?

Yeah resolved it by switching to Checkout.com


fix the memory leaks

On line no. 74 of 'test_P_DNS.cc' there is a memory leak and on line no. 72 of 'test_P_Net.cc' there is memory leak -- both memory leaks are errors.
Found by https://github.com/bryongloden/cppcheck

[approve ci]

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/421/ for details.

Needs to run "make clang-format". :)

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/524/ for details.

Also would have a Jira # in the subject line please.

Greetings @zwoop 😬
Sorry, what is a JIRA number? I've never heard this before. And I know how to change the commit message; is this the same as the subject line? If so, what should I update it to say? 👍

Ah, so you have to create a Jira ticket (for now at least) in conjunction with the Github PR. Go to https://issues.apache.org/jira/browse/TS/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel  and create an account (unless you already did), create a new Issue for the Traffic Server project, and it will give you a TS- number. That's the Jira issue number, and you should refer to it in all commits etc. for this particular issue.

Thank you @zwoop 👍
REF: https://issues.apache.org/jira/browse/TS-4794

@bryongloden please address James' concern, and we can land this (after we run it on the CI again).


Issue with kubernetes pods [ feature request - maximum number of pod allocation in a master node]

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
How many pods can be run in kubernetes master nodes in HA Cluster
For example there is 10 node cluster ( 3 master + 7 worker nodes are available)
Can you please tell us the maximum number of pods can assign it to each master nodes
Proposed Solution:
Page to Update:
https://kubernetes.io/...

kubernetes version 1.10 and above

/triage support

/close


⚠ Cioos National CKAN has degraded performance

In 4c32359, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 13353 ms

Resolved: Cioos National CKAN performance has improved in d476277 after 25 minutes.


Document all the now package.json config options

Currently I can't find the various now package.json config options documented anywhere. The only way I discovered that now.alias existed was by accidently seeing it while browsing the source code trying to fix an unrelated bug.
Also the --config option isn't documented anywhere, I'm guessing it can contain the same options as the ones in the package.json?

On it! Launching very soon.

Was this done, and if so where?

https://zeit.co/docs/features/configuration#files


[Tests-Only] Bump core commit to include 37917

This will include in the test code:
https://github.com/owncloud/core/pull/37917 [Tests-Only] Do not overwrite user information when testing duplicate user creation

Let's see what happens to CI.

@micbar I made this PR to demonstrate that the test code is working with the ocis currently in master.
I am not sure if you want this merged. Or just let the mono branch come with this core test commit id.

mono branch has been merged and includes this.


segmentation fault with hybridScaffold.pl

Hi Andy,
This is not a runBNG issue but a hybridScaffold.pl issue, just wondering if you've experienced it before:
I get "Segmentation fault" whenever I run "runBNG hybrid", and the cause is hybridScaffold.pl, with perl 5.10.0, 5.14.4 and 5.16.0.
It seems to be related to the PerlIO::Util module (and more?)
Let me know if you have suggestions, I am going to post in the bionano forum too.
Cheers,
Jenny

Hi Jenny,
I saw this kind of error before and I think it is related to the Perl version you used. Which Perl version did you use? I tested with v5.10.0 and v5.14.4 and all worked for me.
Cheers,
Andy

Thanks Andy,
I got it working,
So previously I tried 5.10.0, 5.14.4 and 5.16.0, all with my own installations. The error is very likely due to conflict between perl modules, as HybridScaffold also uses it's own lib folder. It is possible that I've missed out including or excluding some lib paths.
I reinstalled perl using perlbrew and got it working with v5.14.4. Just in case someone has the same problem:
perlbrew --notest install --thread perl-5.14.4
perlbrew switch perl-5.14.4
perl  hybridScaffold.pl

Cheers,
Jenny

Hi Andy,
I have met the same problem with hybridScaffold.pl. I have tested it with perl 5.10.1, 5.14.4 and 5.16.0. The problem still remains. It really struggles me a lot. I hope you can give me some suggestions~
When I use perl-5.10.1 to run hybridScaffold.pl, the errors is: Type of arg 1 to keys must be hash (not hash element) at scripts_v5134/HybridScaffold/hybridScaffold.pl line 1477, near "})	"
For perl-5.14.4, the error is: Segmentation fault (core dumped)
For perl-5.16.0, the error is:
Can't load '/public/home/lijing/software/bionano/scripts_v5134/HybridScaffold/scripts/perl5/5.16.3/x86_64-linux-thread-multi/auto/PerlIO/Util/Util.so' for module PerlIO::Util: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /public/home/lijing/software/bionano/scripts_v5134/HybridScaffold/scripts/perl5/5.16.3/x86_64-linux-thread-multi/auto/PerlIO/Util/Util.so) at /public/home/lijing/perl5/perlbrew/perls/perl-5.16.0/lib/5.16.0/XSLoader.pm line 68.
 at /public/home/lijing/software/bionano/scripts_v5134/HybridScaffold/scripts/perl5/5.16.3/x86_64-linux-thread-multi/PerlIO/Util.pm line 10.

Hi @Mr-Inamn,
I think the Perl settings (mainly libs) or versions in your ENV are in conflict. Not sure how did you set them. Have you tried the solution from @JennyHTLee above?
Cheers,
Andy

Hi Andy,
Yes, I have tried Jenny's solution, but the Segmentation fault still exists.

Hi Andy,
Yes, I have tried Jenny's solution, but the Segmentation fault still exists.

Hi Andy,
Finally I got it done. The solution is to change the line 1477 as follows with perl-5.10.1. But I have to mention that the Segmentation fault still exists with perl-5.14.4 and perl-5.16.0. The @INC in my file is in the last. You can have a look and check whether the priority is correct.
1477c1477
<         #foreach my $flagIncludeKey (keys $configRef->{$theStage})	{
---
>         foreach my $flagIncludeKey (keys %{$configRef->{$theStage}}) {

@INC
/public/home/lijing/software/bionano/scripts/HybridScaffold/scripts/perl5/5.14.4/x86_64-linux-thread-multi
/public/home/lijing/software/bionano/scripts/HybridScaffold/scripts/perl5/5.14.4
/public/home/lijing/software/bionano/scripts/HybridScaffold/scripts/perl5
/usr/lib/perl5/site_perl
/public/home/lijing/perl5/perlbrew/perls/perl-5.14.4/lib/site_perl/5.14.4/x86_64-linux
/public/home/lijing/perl5/perlbrew/perls/perl-5.14.4/lib/site_perl/5.14.4
/public/home/lijing/perl5/perlbrew/perls/perl-5.14.4/lib/5.14.4/x86_64-linux
/public/home/lijing/perl5/perlbrew/perls/perl-5.14.4/lib/5.14.4


Figure out what to do with current core RFCs

There are several open RFCs assigned to core at https://github.com/rust-lang/rfcs/pulls?q=is%3Aopen+is%3Apr+label%3AT-core. We should decide if we want to take ownership of them, or close them.

No council members indicated an objection to this process. Since RFC 3392 defines the Council as the successor to Core, I think it is a reasonable interpretation that the Council takes on whatever ownership and responsibilities the Core team had. The RFCs have been reassigned, and I'm going to work with the authors to see if the RFCs can be moved along.


Runtime problems when including multiple versions of ndk-glue

Having multiple versions of ndk-glue in the dependency tree leads to crashes because of uninitialized NATIVE_ACTIVITY.
Example: Including ndk-glue 0.5. When entering main(), NATIVE_ACTIVITY 0.5 gets initialized. Including Oboe crate that uses ndk-glue 0.4.0. When enumerating audio devices, i get:
thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', /Users/ric/.cargo/registry/src/github.com-1ecc6299db9ec823/ndk-glue-0.4.0/src/lib.rs:59:39

I tried using [patch.crates-io] but that does not seem to work.
This bug might be related to using resolver = "2" as required by wgpu.

That's not really a bug, Just How Things Work™.
That said, winit added a match table to prevent this (and we should have a comment or issue around here documenting the exact same problem), so this is a very real problem.
[patch.crates-io] only works when the versions are the same, allowing you to make small local modifications. It's impossible to use this to patch ndk-glue 0.4.0 with ndk-glue 0.5.0.
What we can however do is the semver trick: we release one final patch-release of ndk-glue 0.4.x, reexporting the functions from ndk-glue 0.5.x (and removing the statics): that causes duplication on the crate graph but makes sure that - assuming everyone sets the minimum patch version correctly in their toml or lock file - both are interoperable.

I thought of another hack: make NATIVE_ACTIVITY public (or create a unsafe setter).

I was thinking about something like this:
Cargo.toml:
ndk-glue = "0.5"
ndk-glue-4 = { package = "ndk-glue", version = "0.4" } # Workaround for CPAL and Oboe
ndk-glue-3 = { package = "ndk-glue", version = "0.3" }

main:
let native_activity = ndk_glue::native_activity();
unsafe { ndk_glue_4::set_native_activity(native_activity) };
unsafe { ndk_glue_3::set_native_activity(native_activity) };

We can add a patch release for v0.3, v0.4 and v0.5 with this new method, I think it's cleaner. I can make a PR if you want.

I don't really like that approach as it's quite unsafe (ie. allows users to break things at will), requires careful consideration by the caller on what ndk-glue version the static is initialized versus what version(s) use it, and will also need to be updated.
While NATIVE_ACTIVITY itself won't change during the runtime of the program (except that we should drop it at the end, see #160), there are (at the time of writing) four more statics that need all of the above including updates during the runtime of the program while Android fires callbacks.
As such I don't think the manual approach scales.
Re-exporting pub accessor functions is tricky too, as we'd need to perform those pointer casts to wrapper-structs from different ndk versions while still holding on to the same lock guard. Since the layout between all the versions is the same we could transmute the lock guards to make them hold a different ndk version's newtype/wrapper struct.
In the end it's probably best to just update oboe to a newer ndk-glue?

In the end it's probably best to just update oboe to a newer ndk-glue?

I already sent a PR for ndk-glue some days ago, but your last release made it already deprecated. This is not sustainable. If we con't introduce cross-version initialization functions we should at least make so ndk-glue does not need to be updated so often. The ndk crate dependency should be removed from ndk-glue, and maybe move some functionality inside the ndk crate.

In the end it's probably best to just update oboe to a newer ndk-glue?

@MarijnS95 In the end, is the best approach is to set ndk = "*" and ndk-glue = "*" in libraries that use android-ndk? It's such a pain to bump every library to use the newest version of ndk-glue.

In the end, is the best approach is to set ndk = "" and ndk-glue = "" in libraries that use android-ndk? It's such a pain to bump every library to use the newest version of ndk-glue.

Don't think you can publish a crate with wildcard version? Believe it only works for local crates

but your last release made it already deprecated. openxrs also breaks if I update ndk-glue to 0.6 in my project. This is not sustainable.

Indeed, and increased use of ndk-glue lately shows.

The ndk crate dependency should be removed from ndk-glue

Not easily possible since ndk-glue has to know of and call/use some of the functions/types from the ndk. We have better solutions.

and maybe move some functionality inside the ndk crate.

Nah, I think the ndk crate should purely hold the (safe) abstractions to the NDK. ndk-glue is "just" a helper (like Android's "official" glue layer) that users can leverage to simplify their Android setup. Either way it'll suffer from breaking changes to the ndk there too... Pick your poison.

Maybe we need a ndk-ptrs crate for storing the static pointers. The crate should have no dependencies (apart for lazy_static), and the pointers can be untyped (c_void).

I've been thinking about the exact same, we can even apply this retroactively to previous crate-releases as an additional patch. It'll just need a dependency on one of the crates that provides a Mutex/RWLock with a mapable inner value on the *LockGuard. That way we can convert from the pointer to the typed handle, and give the user what they asked for while held inside the *LockGuard.
@msiglreith @francesca64 @dvc94ch What are your thoughts on this? I/we can start working on a little proof of concept for this, having to make sure that we don't need to release any breaking changes to it for a good long while.
Alternatively we could do away with statics entirely and work with a heap allocation to which a pointer is stored in ANativeActivity::instance. Users would then have to pass this object around to get access to the NativeActivity and NativeWindow, and code would simply not compile if differing versions of ndk/ndk-glue are combined. Safer and more predictable, but the same dependency management hell for all the library crates involved.

@MarijnS95 In the end, is the best approach is to set ndk = "*" and ndk-glue = "*" in libraries that use android-ndk? It's such a pain to bump every library to use the newest version of ndk-glue.

@enfipy As @repi mentioned such crates cannot be published... But it should be possible to publish them with a range of compatible crate revisions. Perhaps ndk-glue could set something (imaginary, I didn't compatibility-test this) like ndk = ">= 0.3, <= 0.6". Then we only need to bump these (usually only the upper bound) in a patch release.
(We can probably do this regardless of introducing an ndk-ptrs/statics crate mentioned above?)
Note that an upper bound is mandatory in my eyes to prevent a situation like https://github.com/gwihlidal/vk-mem-rs/issues/54. It's much safer for us to validate a setup and push a patch release enlarging the available range of versions than to retroactively publish a new patch release with the upper bound fixed to the last working/compatible version, and yanking everything without that upper bound from crates.io.
The only thing I am not sure about is crate selection. I assume, but have not tested this, that if a crate were to select ndk = "0.5" any crate with ndk-glue with the imaginary ndk = ">= 0.3, <= 0.6" dependency from above would get just ndk 0.5.0? Though perhaps if cargo were to try and select the highest or the lowest (-Zminimal-versions) you could end up with duplicates on different versions after all. Then only Embark's cargo-deny could save you (or the aforementioned suggestion to remove statics from the crate altogether).

I'm currently leaning towards the separate ptr crate approach as it seems to minimize the risk of breaking changes compared to just using a version range for ndk.
Regarding the ANativeActivity::instance I'm not totally sure if I understand it in detail. In particular who is owning the memory storing the pointers? The ANativeActivity::instance is then only for internal usage?

why do you have two versions in your dependency tree? ndk-glue only needs to be a dependency of the windowing crate you use (either winit, or your own), and you can reexport anything you need from the windowing crate. not sure why you have it more than once in your dependency graph.

Here is a list of dependencies that we use that today all depend on ndk-glue for their Android version and as such run into this problem:

app_dirs2
cpal
oboe
webbrowser
winit

those libraries should probably expose an init function that takes a jnienv. although I can see that this is annoying yes.

so how about a crate that looks like this:
pub struct AndroidContext {
    jni_env: std::ffi::c_void,
   context: std::ffi::c_void,
}
pub fn android_context() -> AndroidContext;

#[doc(hidden)]
pub unsafe intialize_android_context(ctx: AndroidContext);

ndk-glue can initialize it and all library crates can get the stuff they need from the ndk-context crate? If you spawn a new thread you can use the get_java_vm method and then attach to the new thread. this would mean that downstream crates don't depend on ndk-glue (which they shouldn't).

Ups, I guess the approach was already mentioned, not very good at reading long threads. I claimed that crates shouldn't depend on ndk-glue without mentioning why. Risking pointing out the obvious, if you want to embed your library in a kotlin app that doesn't use native activity, the kotlin app will invoke initialize_android_context, so we should make it extern "C"

@msiglreith

I'm currently leaning towards the separate ptr crate approach as it seems to minimize the risk of breaking changes compared to just using a version range for ndk.

We can do both, the dependency range should result in less minor (breaking) updates for at least ndk-glue because we're not forcing the update of another breaking-change crate dependency anymore. But then again we'd have to validate how cargo selects the dependency and also make sure at least min and max versions are tested in the CI? If we do this for multiple crates possible combinations may explode exponentially though.

Regarding the ANativeActivity::instance I'm not totally sure if I understand it in detail. In particular who is owning the memory storing the pointers? The ANativeActivity::instance is then only for internal usage?

It seems to be the typical userdata pointer that is untouched by the NDK, you're free to assign any data you want but of course have to drop it when the ANativeActivity is cleaned up, presumably in onDestroy.

@dvc94ch Thanks for those insights! It indeed seems that many crates are erroneously using ndk-glue to get hold of the ANativeActivity for JNI purposes (or in one of my test-crates: the internal_data_path()).
Hence going back to my comment and your suggestion, also taking Kotlin into account: those crates should consume the necessary objects through an init function or constructor. We could pass it the needed JNI or NDK types, and get rid of static state and public getters altogether.
On the ndk-glue side we will then pass an ANativeActivity into fn main() from fn init(), and internally hold a pointer to our own state in instance so that there's no static globals anymore. We'll still have to wrap things in locks to be able to access them concurrently from ANativeActivityCallbacks.
If there's an NDK version mismatch things will simply refuse to compile (instead of the hard-to-debug failures we're observing right now), and we can use the existing ptr/unsafe from_ptr helpers to turn one into the other (leveraging the more stable ndk-sys crate types, and if all else a raw pointer can easily be cast too).

Between @MarijnS95 and @dvc94ch ideas I prefer the latter. While @MarijnS95 idea is cleaner, @dvc94ch idea is the more practical IMO. Just one nit, I think "ndk-context" is clearer than "ndk-ctx".
The ndk-context pointers can be RwLock<Option<NonNull<c_void>>>, and the ndk crate can use some constructors like from_context() that return RwLock. But the raw pointers could also also be used unsafely directly from ndk-context (this would be the case for openxrs).
Do you need me to make a PR?

It turns out that splitting off ndk-context from ndk-glue in not clean at all. ndk-context gets contaminated for example with the Rect and Event structs. I think we should introduce a NdkApp, whose public API lives inside the ndk crate, but its logic can still live inside ndk-glue. Please give some feedback

It turns out that splitting off ndk-context from ndk-glue in not clean at all. ndk-context gets contaminated for example with the Rect and Event structs. I think we should introduce a NdkApp, whose public API lives inside the ndk crate, but its logic can still live inside ndk-glue. ndk-context will contain only a static instance to this object (as a pointer). NdkApp could be initialized by crates with the ndk-context pointer + ndk crate; ndk-glue will do the same internally. Please give some feedback.

so the idea behind the ndk-context is that it only provides stuff required for interacting with android.jar. that's essentially these vm and activity pointers. this should be sufficient to access any java apis. this means that some things you can access directly from the ndk when you have an ANativeActivity will need to be accessed using the jni. The advantage is that the code should work even if it's not called from a NativeActivity. The reason why I haven't PR'ed this yet is because it's a bit of work to test all the cases (test that it works in a multi threaded context, works from kotlin, etc).

FYI: the vm and activity pointers should be valid after main is called from ndk-glue so there is no need for a RwLock.

@dvc94ch ok, maybe it's better for you to push this forward. But where should the poll_events() live? should it be moved inside winit?

I don't think ndk-glue needs to be changed at all except initializing ndk-context.

anyway, don't think I'll have time to look into this before next week

Opened a PR #223

I think we should close this issue as soon as most popular crates migrated to ndk-context:
https://crates.io/crates/ndk-glue/reverse_dependencies

https://github.com/app-dirs-rs/app_dirs2/pull/19
https://github.com/Ralith/openxrs/pull/108
cpal
oboe
webbrowser
winit (needs more than just the VM/Context, https://github.com/MarijnS95/android-ndk-rs/compare/anativeactivity-instance?)

@zarik5 When making these PRs at least link back to the original issue and PR :)

think we can close now


Older hardware sees a black screen for a scene if I am using Perfect Vision

Check the console for error messages (F12 / cmd+option+I -> Console tab). And if you see yellow warning messages with the word WEBGL in it, let me see those as well.

And Perfect Vision requires WebGL 2. Is there an error notification on the screen that mentions this?

There certainly is an error for WebGL 2.  I believe the hardware is unable to support it.

It is required. Foundry itself does technically require webgl 2 as well (lights are not rendered entirely correctly with webgl 1). What hardware do you have? In case it's an iPad or iPhone:

Does Foundry Work on the iPad or iPhone?
Foundry does not explicitly support Safari on the iPad or iPhone but if your OS is on 14.5 or later you may be able to access Foundry after enabling an experimental Safari feature. Navigate to Settings > Safari > Advanced > Experimental Features and enable the WebGL 2.0 setting. Modules such as Touch VTT and Mobile Improvements can make interacting with Foundry via touch much smoother.

Check the console for error messages (F12 / cmd+option+I -> Console tab). And if you see yellow warning messages with the word WEBGL in it, let me see those as well.

Presuming that's on the players pc with the older hardware, let me coordinate that and find out.

Here we go - I also have error messages on the vtt screen itself as well as F12 console output:


Says to ban people you dont like, and censorship going on in your own project.

Q: WTF, the discussion was locked, and/or I can't reply!?
Once again, we are not going to tolerate our community being overridden by the mob. If this starts to happen, we will nuke, delete, lock, close, ban, and do whatever we have to do to put the fire out. These discussions drag on and on and on, and they don't make communities better.
so here your saying we should "ban" so called "mobsters"
what defines a "mobster" exactly?
also here https://github.com/domgetter/NCoC/issues/11 you changed the "fucked" to "*****" a very classic example of censorship right there.

You're free to fork the project and/or make whatever code of conduct you like.


GA release notes

Docs Build status updates of commit cbb954d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 96783d2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 5cc7eba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0698392:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 4441ba6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 8ed9dc1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 89ed6fe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 8e76756:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 8b3a7be:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 6e45544:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

#sign-off and merged.


Raspotify not visible

Raspotify disappeared from all my devices, without any cromprehensible reason. I removed it completely and reinstalled it which fixed the problem for a short while. Now I can't see it anymore. All other devices are visible.

i have the same problem. just since 2 days. i cant find a solution either

This actually happened to me as well exactly two days ago. I wonder if Spotify changed anything of its APIs during that time.

I did a clean new install of buster and now it works again.


fetchers: git: Use ssh in batch mode

If $git_url uses ssh protocol and is not in .ssh/known_hosts,
the ssh client starts to iterate with a user.
But this interaction is not visible and looks
just like the ninja hung on some operation.
So we have to use ssh in BatchMode to throw
an error instead of asking invisible questions.

With proposed PR ninja does not hang but prints an error message:
$ ninja fetch-domd
[5/6] git clone
FAILED: yocto/proprietary
GIT_SSH_COMMAND='ssh -o BatchMode=yes' git clone -q<EMAIL_ADDRESS>yocto/proprietary && touch yocto/proprietary
Host key verification failed.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
ninja: build stopped: subcommand failed.

Please fix typo in the commit message: "starts to iterate with a user" s\iterate\interact
and add my R-b tag:
Reviewed-by: Volodymyr Babchuk<EMAIL_ADDRESS>

Typo is fixed.
Reviewer is added.
PR is ready to be merged.


navigateTo' was called on null

i change my code from demo;
i get the error like this: "flutter: The method 'navigateTo' was called on null."

Have you changed the route while the app is running? If yes then you need to hot refresh it afaik

Are you setting Application.router to anything?

i don't not why~~~
this is my project address: https://github.com/hanxu317317/flutter-test
`
can someone run it and click the index

then u will get the error like this

i fixed the problem , but i didn't learn why
i createState by first ~ it's right but second it will go wrong.
first:
  _DemoState createState() => new _DemoState();

second:
State<StatefulWidget> createState() => new _DemoState();

class _DemoState  extends State<Demo> {
...
 new RaisedButton(
                child: new Text('index'),
                onPressed: () {
                  Application.router.navigateTo(context, "/index");
                },
              ),
...

in https://github.com/hanxu317317/flutter-test/blob/master/lib/view/demo/index.dart line 33.


Fixed #27386 -- Wrapped readonly callable fields in  rather than .

https://code.djangoproject.com/ticket/27386

Release notes:
Fields marked as readonly are wrapped inside a
...
 instead of a
...
 in order to allow any kind of HTML as the field's content.

buildbot, add to whitelist.

Could you add the release notes?
diff --git a/docs/releases/1.11.txt b/docs/releases/1.11.txt
index 55fe3be..6b32621 100644
--- a/docs/releases/1.11.txt
+++ b/docs/releases/1.11.txt
@@ -492,6 +492,15 @@ This works similar to ``settings.TIME_ZONE = None`` except that it also sets
 if there's a use case where you find you can't adapt your code to set a
 ``TIME_ZONE``.

+HTML changes in admin templates
+-------------------------------
+
+``
`` is replaced with a ``
`` tag to allow including lists
+inside help text.
+
+Readonly fields are wrapped in ``
...
`` instead of
+``
...
`` in order to allow any kind of HTML as the field's content.
+
 Miscellaneous
 -------------

@@ -576,9 +585,6 @@ Miscellaneous
   :func:`~django.utils.cache.add_never_cache_headers` call
   ``patch_response_headers()`` and therefore are also affected by this change.

-* In the admin templates, ``
`` is replaced with a ``
`` tag
-  to allow including lists inside help text.
-
 * ``ConditionalGetMiddleware`` no longer sets the ``Date`` header as Web
   servers set that header.

merged in b3162cab94ca2988c99afe01887a4b61d6a35c1a, thanks!


Fix menu on no-js base_nonresponsive/base_update pages

When Javascript is turned off on pages that use the base_nonresponsive.html template (like find-a-housing-counselor) or base_update.html  template (like askcfpb), the menu loads open and won't close
Additions

Add no-js class to <html> in base_nonresponsive.html template
Add no-js class to <html> in base_update.html template
Override hover state background color for menu links in legacy styles.less

Testing

Check out branch
Turn off js in browser
Navigate to http://localhost:8000/find-a-housing-counselor and http://localhost:8000/askcfpb and verify that:

menu is not open on load & behaves as expected
menu links don't have background color on hover

Review

@cfpb/cfgov-frontends

Screenshots
Before:

After:
On load:

On hover:

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

so menu will work when js is turned off, and remove menu link hover
state background color on nonresponsive pages.

👍

👍


show 'get contacts' button on Invite screen

Description
Displays a 'Get Contacts' button on the invite screen if the user has not previously give the app permissions to access the contacts on the device.
Tested
Freshly install the app, go through the setup process, do NOT allow access to the contacts. Then go to Account > Invite screen. No contacts should be displayed, and a 'get my contacts' button should be shown. Clicking on that button should display the system pop up asking if the app can access the contacts. If the User allows it, the button will disappear, and the contacts should be displayed.
Searching for a user that does not exist (e.g. search for a random string) will display the "no results" label, and the button should also not be displayed.
Related issues

Fixes #4051

@flashman1234 Looks like you've got some lint check issues.
You can run yarn lint-checks locally to diagnose. Recommend doing this before pushing PR updates :)

@jmrossy I added the same functionality to the send screen. The button isn't currently shown as is part of the empty view, and the send screen always has the Celo Default Recipient. I'm not sure if that is just for testing?
Linting has been also been fixed, so if the last changes to send.tsx are ok, I will merge.


fix: apply (existing) Notification sorting capabilities to the Notifi…

…cationRestV2Controller; squash a bug (resulting in NPE) in SortStrategy.DUE_DATE
Resolves #255
This PR is a reboot of #256 .
This change brings sorting features to the Notification Web Components by applying the existing capabilities to NotificationRestV2Controller.
It also fixes an NPE in SortStrategy.DUE_DATE

Thanks @drewwills - this is a cleaner approach.

@mairi @hsun1


Implement SystemcoreClock

Hi.
We implemented SystemcoreClock which is defined in CMSIS.
Regards;
Yamanaka

Does this mean that clock is fixed and can't be changed?
A user case:
extern uint32_t SystemCoreClock;

printf("Old core clock: %u \n", SystemCoreClock);
user_change_clocks();
SystemCoreClockUpdate();
printf("New core clock: %u \n", SystemCoreClock);

Hi
As shown below, other companies also implement by the same method.
Do you have any problems?

\hal\targets\cmsis\TARGET_ARM_SSG\TARGET_IOTSS_BEID\system_CMSDK_BEID.c
\hal\targets\cmsis\TARGET_Atmel\TARGET_SAM_CortexM0P\utils\cmsis\TARGET_SAMD21
source\system_samd21.c

and more...
We think that SystemCoreClock is to store the CPU Clock.

Good point, they make it wrong ! That does not update the core clock variable. The docs defines it clearly: https://www.keil.com/pack/doc/CMSIS/Core/html/group__system__init__gr.html#gae0c36a9591fe6e9c45ecb21a794f0f0f
we should review those CoreClockUpdate functions for targets, identify those that don't do it properly.

I created an issue for the rest of the targets, can you please update the Update function to read the value from registers?

We will consider about the implement method of Update function.

Hi.
We implemented SystemCoreClockUpdate function.
In SystemCoreClockUpdate function, we changed to calculare the CPU Clock by the division ratio setting of from FRQCR register.
Regards;
Yamanaka

Thank you for the update


{Freeway-Bug}[Adaptive Cards- Home- Flight Itinerary]: Talkback focus move to hidden element and announce it as "departs from" using swipe right gesture.

Target Platforms
Android
SDK Version
2<IP_ADDRESS>
Application Name
Adaptive Cards
Problem Description
Test Environment
Device: S21+ 5G
Screen Reader: Talkback
AdaptiveCard Android App version: 2<IP_ADDRESS>
Repro Steps:

Turn on Talkback.
Open Adaptive Cards Visualizer Application.
Home Page will opened.
Now Navigate to 'Sample card' button and select it.
Now navigate to "choose sample" expands/collapse control and select "Flight Itinerary" list item.
Now Navigate to Visual tab and select it.
Now navigate to Flight Itinerary card using swipe gesture and observe the issue.

Actual Result:
Talkback focus move to hidden element using swipe right gesture. talkback focus move to hidden element after "Tue, May 20, 2017 12:25PM" text and announce it like "departs from"
Expected Result:
Talkback focus shouldn't move to hidden element using swipe right gesture. Talkback focus shouldn't move to hidden element after "Tue, May 20, 2017 12:25PM" text or Visually text should be appears on the card.
User Experience:
When focus order does not follow the visible reading order, the experience can create a different interaction pattern, and/or unintended content relationships for assistive technology users. On rare occasions, there is a logical reason the focus order is different from the reading order, but the meaning of the content and interactions must remain the same.
WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/meaningful-sequence
"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com) “
Screenshots
https://user-images.githubusercontent.com/89897257/230121731-f06e5031-a35e-400b-ad63-d9c4a70904b1.mp4
Card JSON
NA

Sample Code Language
No response
Sample Code
No response

need to make the filler view not to participate in talkback.


SQL CONCAT statement fails if it includes a " "

If a space is added using CONCAT between two fields, it causes a query to fail. ie:
SELECT p.ID, f.Name, p.Subname, CONCAT(f.Code, " ", p.SubCode) FROM p LEFT JOIN f ON f.ID = p.F_ID
Where as this works (without the " ")
SELECT p.ID, f.Name, p.Subname, CONCAT(f.Code, p.SubCode) FROM p LEFT JOIN f ON f.ID = p.F_ID
Information

Version of Medoo: 1.6.1
Type of Database: MySQL
System (Liunx\Windows\Mac): Mac

Expected output
I would expect the query to return two fields joined, with a space between in a single column, ie:
(1, "B C"),
(2, "D E"),
(3, "F G"),
(4, "H I"),

You may use raw object to this case. https://medoo.in/api/raw

Brilliant thanks. Just realised the query is a prepared statement. (Which I should have known.


[QRF-176] Lena theme cookie notice button 'disappears' on hover

Hey @fgyimah! I'm adding @alpower to review this as well because I feel like the color contrast between the background and text is not good on hover.
This is what it looks like now:

I guess changing the button text color to white on hover can solve the issue.

Hey @fgyimah! I'm adding @alpower to review this as well because I feel like the color contrast between the background and text is not good on hover. This is what it looks like now:
I guess changing the button text color to white on hover can solve the issue.

@MohammadxAli good catch, will update to use white text on hover


Multiple IMUs

Is it possible to use 2 or more IMUs at the same time?
Ideally I want to run two MPU-9150 boards (0x68 & 0x69) in case 1 fails.

Take a look at this post:
https://richardstechnotes.wordpress.com/2014/12/16/using-multiple-imus-with-rtimulib/
It's written for the Linux version but it should be easy to change for the Arduino version. You would need to be sure there's enough RAM (depending on what board you are using).

Thanks for the response I will have a look into this and share my results if I have any success.


Access databases from host when running multiple projects

I have multiple projects set up with traefik running standalone. I can't figure out how to get sequel pro to connect to one of the mariadb containers. Do I need further traefik config?

By default, MariaDB doesn't expose any public ports and available only inside of containers virtual network, you can just expose unique public port per project. AFAIK, traefik supports only http and https at the moment.

If I expose a unique port per project, how do I access that mariadb machine from the host?

The same way as always – localhost:[PORT]


Prepare for the rhel-coreos image

machine-os-content may be replaced with rhel-coreos in the future release.

The rhel-coreos-8 ostree native container image replaces the machine-os-content image starting in OCP 4.12. In OCP 4.13, the image is rhel-coreos. I believe the plan is for future builds to stop producing machine-os-content images, but I'm not sure exactly when that will happen (or if it's happening already).


system requirements on the home page

Hi ^^
i just installed Legacy Update on a windows 2000 VM and while the website say in the banner it work with 2000, the system requirements under the "Install Legacy Update" does not and i was confuse if it will work or not 😅
i did downloaded it and it did work but will it be possible to add Windows 2000 on that system requirement list then ?
Also the top bar say it work up to vista/server 2008, what about doing another banner ? (don't think adding the other supported OS'es will be feasable/look nice xD)
have a great day all and thanks for that amazing work 💜

I wonder how I missed 2000 there 🤦♀ Thanks, fixed.
I do need to redo the site banner, it’s already a bit too long as-is!


YoloAI Bot

YoloAI is an Object Detection artificial intelligence.
This could be used in Osu! itself.. But what I herd from a different user who made it - it took them about 6months to make it work and press z x keys.

This could apply in your private program if you accept this to be implemented in your code.
Plus it takes alot of time and patiance. Could be used in doing real High PP plays if so.

The problem is that it will never perform as human as a code that is set in stone with my own preferred humanization methods i think.
Also this is not the goal of my journey here. I dont wanna code on an ai or something but rather my first cheat features. Im just not interested in ai.

Alright


Documentation: add 'upgrade to v3.1'

Current coverage is 63.86% (diff: 100%)

No coverage report found for master at 017ea3d.

Powered by Codecov. Last update 017ea3d...f49e16b

@xiang90 PTAL.

LGTM. defer to @heyitsanthony

@heyitsanthony All fixed. PTAL. Thanks.

lgtm after fixing the the the


“xvnc” is always set as the default in the Login-Screen, although “xorg” was selected previously

Hello Team,
We are using RHEL 6 and RHEL 7 machine with XRDP.
[root@XXX ~]$ cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.4 (Maipo)
[root@XXX ~]$ rpm -qa | grep xrdp
xrdp-devel-0.9.5-1.el7.x86_64
xorgxrdp-0.2.5-3.el7.x86_64
xrdp-0.9.5-1.el7.x86_64
xrdp-selinux-0.9.5-1.el7.x86_64
xrdp-debuginfo-0.9.5-1.el7.x86_64
As per discussion with our user the problem is, while using XRDP "xvnc" is always set as default in the Login-screen of XRDP, although if we selected "Xorg" previously which can lead to unintentionally using the wrong session.
Can anyone help and let me know how to fix this.

edit xrdp.ini as you like.

Please find below /etc/xrdp.ini file:
[Globals]
; xrdp.ini file version number
ini_version=1

; fork a new process for each incoming connection
fork=true
; tcp port to listen
port=3389
; 'port' above should be connected to with vsock instead of tcp
use_vsock=false
; regulate if the listening socket use socket option tcp_nodelay
; no buffering will be performed in the TCP stack
tcp_nodelay=true
; regulate if the listening socket use socket option keepalive
; if the network connection disappear without close messages the connection will be closed
tcp_keepalive=true
#tcp_send_buffer_bytes=32768
#tcp_recv_buffer_bytes=32768

; security layer can be 'tls', 'rdp' or 'negotiate'
; for client compatible layer
security_layer=negotiate
; minimum security level allowed for client
; can be 'none', 'low', 'medium', 'high', 'fips'
crypt_level=high
; X.509 certificate and private key
; openssl req -x509 -newkey rsa:2048 -nodes -keyout key.pem -out cert.pem -days 365
certificate=
key_file=
; set SSL protocols
; can be comma separated list of 'SSLv3', 'TLSv1', 'TLSv1.1', 'TLSv1.2'
ssl_protocols=TLSv1, TLSv1.1, TLSv1.2
; set TLS cipher suites
#tls_ciphers=HIGH

; Section name to use for automatic login if the client sends username
; and password. If empty, the domain name sent by the client is used.
; If empty and no domain name is given, the first suitable section in
; this file will be used.
autorun=

allow_channels=true
allow_multimon=true
bitmap_cache=true
bitmap_compression=true
bulk_compression=true
#hidelogwindow=true
max_bpp=32
new_cursors=true
; fastpath - can be 'input', 'output', 'both', 'none'
use_fastpath=both
; when true, userid/password *must* be passed on cmd line
#require_credentials=true
; You can set the PAM error text in a gateway setup (MAX 256 chars)
#pamerrortxt=change your password according to policy at http://url

;
; colors used by windows in RGB format
;
blue=009cb5
grey=dedede
#black=000000
#dark_grey=808080
#blue=08246b
#dark_blue=08246b
#white=ffffff
#red=ff0000
#green=00ff00
#background=626c72

;
; configure login screen
;

; Login Screen Window Title
#ls_title=My Login Title

; top level window background color in RGB format
ls_top_window_bg_color=009cb5

; width and height of login screen
ls_width=350
ls_height=430

; login screen background color in RGB format
ls_bg_color=dedede

; optional background image filename (bmp format).
#ls_background_image=

; logo
; full path to bmp-file or file in shared folder
ls_logo_filename=
ls_logo_x_pos=55
ls_logo_y_pos=50

; for positioning labels such as username, password etc
ls_label_x_pos=30
ls_label_width=60

; for positioning text and combo boxes next to above labels
ls_input_x_pos=110
ls_input_width=210

; y pos for first label and combo box
ls_input_y_pos=220

; OK button
ls_btn_ok_x_pos=142
ls_btn_ok_y_pos=370
ls_btn_ok_width=85
ls_btn_ok_height=30

; Cancel button
ls_btn_cancel_x_pos=237
ls_btn_cancel_y_pos=370
ls_btn_cancel_width=85
ls_btn_cancel_height=30

[Logging]
LogFile=xrdp/xrdp.log
LogLevel=DEBUG
EnableSyslog=true
SyslogLevel=DEBUG
; LogLevel and SysLogLevel could by any of: core, error, warning, info or debug

[Channels]
; Channel names not listed here will be blocked by XRDP.
; You can block any channel by setting its value to false.
; IMPORTANT! All channels are not supported in all use
; cases even if you set all values to true.
; You can override these settings on each session type
; These settings are only used if allow_channels=true
rdpdr=true
rdpsnd=true
drdynvc=true
cliprdr=true
rail=true
xrdpvr=true
tcutils=true

; for debugging xrdp, in section xrdp1, change port=-1 to this:
#port=/tmp/.xrdp/xrdp_display_10

; for debugging xrdp, add following line to section xrdp1
#chansrvport=/tmp/.xrdp/xrdp_chansrv_socket_7210

;
; Session types
;

; Some session types such as Xorg, X11rdp and Xvnc start a display server.
; Startup command-line parameters for the display server are configured
; in sesman.ini. See and configure also sesman.ini.
[Xvnc]
name=Xvnc
lib=libvnc.so
username=ask
password=ask
ip=<IP_ADDRESS>
port=-1
#xserverbpp=24
#delay_ms=2000

[Xorg]
name=Xorg
lib=libxup.so
username=ask
password=ask
ip=<IP_ADDRESS>
port=-1
code=20

#[X11rdp]
#name=X11rdp
#lib=libxup.so
#username=ask
#password=ask
#ip=<IP_ADDRESS>
#port=-1
#xserverbpp=24
#code=10

#[console]
#name=console
#lib=libvnc.so
#ip=<IP_ADDRESS>
#port=5900
#username=na
#password=ask
#delay_ms=2000

#[vnc-any]
#name=vnc-any
#lib=libvnc.so
#ip=ask
#port=ask5900
#username=na
#password=ask
#pamusername=asksame
#pampassword=asksame
#pamsessionmng=<IP_ADDRESS>
#delay_ms=2000

#[sesman-any]
#name=sesman-any
#lib=libvnc.so
#ip=ask
#port=-1
#username=ask
#password=ask
#delay_ms=2000

#[neutrinordp-any]
#name=neutrinordp-any
#lib=libxrdpneutrinordp.so
#ip=ask
#port=ask3389
#username=ask
#password=ask

; You can override the common channel settings for each session type
#channel.rdpdr=true
#channel.rdpsnd=true
#channel.drdynvc=true
#channel.cliprdr=true
#channel.rail=true
#channel.xrdpvr=true

Please let me know which line i have to change in this file to get previous selected session ("Xvnc/Xorg").

change the order of Xorg and Xvnc. you should more try & error.

Ok , We will check and let you know. Thanks

We have changed the order of /etc/xrdp.ini file.
Now we could see the default session as "Xorg"

Although  "Xvnc" was selected previously but still Xorg only display as default.
The session option should be the session which we selected previously.

Do you really need both Xvnc and Xorg (xorgxrdp)? In most cases, use only Xorg. It will be enough.
If you really need both, you can specify session type in domain. Your clientside username can include the session type. "Xvnc\username" will use Xvnc, "Xorg\username" will use Xorg.
The selection cannot be saved server side. Save it at the client side.

The selection cannot be saved server side. Save it at the client side.
Put the session type before the username and separate with backslash when you input the user name in your client. If you give  "Xvnc" before the username, Xvnc will be used. "Xorg", Xorg will be used.

Ahhhh what's your client?

We tried to connect the linux machine from windows using Remote Desktop connection.

Session type can be given as a part of credentials. Put the session type in the "User name:" field like, "Xvnc\username" or "Xorg\username".  The client can save user credentials. Saving credentials is saving session type. "Xvnc\username" will use Xvnc, "Xorg\username" will use Xorg.

Anyway, I'd say session type selection cannot be saved server side.

See also man xrdp.ini.

I tried as per your suggestion.
I have mention the session with username like below:

But once i enter password facing login failed issue.

Actually my requirement is on the session option we have to see the previous session which we used.
Every time its changed automatically as default session, so unintentionally we are using wrong session sometime.

Can we get any idea to overcome this issue.

No, not there. I said CLIENT. Put "Xvnc\username" into the CLIENT SIDE username field.

Please see my screen  shot once I enter the Xvnc/username in client side like below:

getting below screen

I also said:

The client can save user credentials. Saving credentials is saving session type.

Turn on "Allow me to save credentials" and input user password client side.

Yes Got it. :) Thank you

Thanks for all your support case can be closed.

👍

Hi Metalefty,
Greetings:)
We are facing Copy/Paste issue from windows to XRDP.
Can you please help me on below issue also:
https://github.com/neutrinolabs/xrdp/issues/1188


fix: Restore instructions for required dependencies

Fixes #233

:tada: This PR is included in version 13.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


JBPM-5233: Data source management

- Adds the required module for letting the dashbuilder use the data sources defined in the WB

Hello @dgutierr would you mind review this PR?
It basically adds the already merged dashbuilder integration component into the kie modules.
Thanks!

+1


BI Template not aligned with April Project Blog referenced PBIT file

Not sure if this is a feature or a bug. We are using Accelerator in production....and when we saw the April Project blog post about an updated PBIT file with direct links to tasks, we installed it. (ref: https://techcommunity.microsoft.com/t5/project-blog/april-project-update-blog/ba-p/2319011)
However, that PBIT file does not have any of the Accelerator entities such as Status, Risk, Issue, Program, etc.
It looks like we have to revert to the PBIT referenced in the Accelerator documentation. Will the Project team continue to maintain that PBIT file separate from this one? Can you merge your efforts? My preference would be for you to update the Accelerator PBIT with the direct-to-task link for Task Status as they did in the Project PBIT file....and of course keep all of the Accelerator entities in tact. Thanks.

I used the original PBIT to create my report that I treat as my master report for my projects, programs, etc.  As I see new PBIT files I will open them to see what new report pages might be available.  I will then copy any new pages into my file.  You might have to manually create the supporting tables first before copying the report page.
For example I saw this blog post for a Resource Allocation report https://techcommunity.microsoft.com/t5/project-blog/monitor-resource-allocation-with-project-power-bi-template/ba-p/2492453 and followed these steps to add to my report.
It might be nice is the report efforts were coordinated but it isn't to hard to incorporate changes into your existing PBIX file.

The new PBIT has been updated to work with the Accelerator and is available here.


Cordova 5.0

Missing changes

Why is this not being merged? Is the original plugin already compatible with Cordova 5.0?


⚠ Bofrost.at has degraded performance

In 78cd452, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1432 ms

Resolved: Bofrost.at performance has improved in 579a38b after 13 minutes.


OCPBUGS-32760: Request serving scheduler: omit deleting nodes

What this PR does / why we need it:
Avoid taking deleting nodes into consideration when making scheduling decisions.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-32760
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.

/lgtm

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

/retest

/unhold
/test e2e-aws

/test e2e-aws

/retest-required

/retest

/test e2e-aws

/retest
For konflux

/retest-required