[GHSA-4487-x383-qpph] Possible privilege escalation in org.springframework:spring-core

Updates

References
Source code location

Comments
Add some patch links and source code location related to CVE-2018-1272.

Hey @sunSUNQ, I'm not sure I see how these commits are related. Would you mind elaborating?

Interesting. I wonder why they think these commits are related. I don't see how a change in a random number generator would be related.
https://spring.io/security/cve-2018-1272

Spring Framework versions 5.0 to 5.0.4, 4.3 to 4.3.14, and older unsupported versions provide client-side support for multipart requests. When Spring MVC or Spring WebFlux server application (server A) receives input from a remote client, and then uses that input to make a multipart request to another server (server B), it can be exposed to an attack, where an extra multipart is inserted in the content of the request from server A, causing server B to use the wrong value for a part it expects. This could to lead privilege escalation, for example, if the part content represents a username or user roles.

In order for the attacker to succeed, they would have to be able to guess the multipart boundary value chosen by server A for the multipart request to server B, which requires the attacker to also have control of the server or the ability to see the HTTP log of server A through a separate attack vector.

I also did not find this association. The data I collected was from last year, and now, due to the unavailability of Jira's issue link at https://spring.io/blog/2019/01/15/spring-framework-s-migration-from-jira-to-github-issues, there is a lack of associated information that could be further explored.

I see. So, if there's no clear association why make the PR to add these commits to the advisory?


[MERGE AFTER ELECTION] After election updates

This PR

Removes the dilution logic from the proposal section of governance.
Fetches the current spartan council from the new Election Module contract

The snapshot is now reading from the new election contract. This means that current spartan concil cant vote untill the election closes in a few hours. I also means that we can merge this one.


Review the readme

Include on top of the SciSharp header a few lines about what is the objective of this fork, and some instructions on how to compile.

Closing this as this repo is going to be archived in favous of the MachineLearning_Toolkit


fix: Adjusting the width of dropdown

This will make it so the width of the dropdown will adjust to the longest variable name
Closes #18021
Describe your proposed changes here.
Ive done a simple math problem that determines the longest length in the values and makes that the width px

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[ ] Well-formatted commit messages
[ ] Rebased/mergeable
[ ] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[ ] Documentation updated or issue created (provide link to issue/pr)
[ ] Signed CLA (if not already signed)

@alexpaxton do you have any fancy tricks for measuring text up your sleeve? i have a fear that we're tightly coupling a font choice to system behavior here

If we style the dropdown items to be in the monospace font then all characters will be the same width, and more predictable


add verilog

Please help if you are free
https://github.com/zenizeni0918/AttractingContributors-color

Thank you!


Feature/vision demo

Rviz config for vision demo. Includes raw camera image & lilypond visualization of detected notes.

Please have a look at the merge conflict


do.sh: Use docker-ce when available.

This enables users to use docker on platforms where docker is not
officially supported, e.g., RHEL8.
Also, remove dependency on docker-distribution. Instead just start a
container that runs the registry on the tester node.
Signed-off-by: Dumitru Ceara<EMAIL_ADDRESS>

LGTM.


EntityDescription does not render on first click.

v1.13.1 has been released. Please try it and reopen this issue if the issue persists.

Originally posted by @rot1024 in https://github.com/reearth/resium/issues/436#issuecomment-701140692
Looks like this is still an issue (regressed?).
I've just come across this issue in "resium": "1.14.2". The first EntityDescription object I click on, does not show the description.
Then second Entity I click on shows the EntityDescription. I click back on the first Entity, and now it show the EntityDescription.
This is a fresh ReactJS project - happy to share source (if required).
package.json
"dependencies": {
    "@craco/craco": "6.3.0",
    "@hot-loader/react-dom": "17.0.1",
    "@testing-library/jest-dom": "5.14.1",
    "@testing-library/react": "12.1.0",
    "@testing-library/user-event": "13.2.1",
    "@types/jest": "27.0.1",
    "@types/node": "16.9.1",
    "@types/react": "17.0.20",
    "@types/react-dom": "17.0.9",
    "@types/react-router-dom": "5.1.8",
    "cesium": "1.85.0",
    "craco-cesium": "1.2.0",
    "craco-plugin-react-hot-reload": "0.1.0",
    "react": "17.0.2",
    "react-dom": "17.0.2",
    "react-hot-loader": "4.13.0",
    "react-router-dom": "5.3.0",
    "react-scripts": "4.0.3",
    "resium": "1.14.2",
    "typescript": "4.4.3",
    "web-vitals": "2.1.0"
  }

Reproduced and find the same issue.
After digging a little bit I find the reason for this issue but haven't found a perfect solution yet
The reason

The reason is that the EntityDescription component did not handle the removal of  cssium-infoBox-bodyless class correctly. and together with the height of the iframe as indicated in the pic below.

Current Solution
To solve this issue. you can try to correct these two things.
potential source of the issue
In resium/src/EntityDescription/EntityDescription.ts  The snippet below was actually trying to handle this but not sure why it's not working right now for the first click.

Pls check if possible
Ash

Thank you.
It would be great if someone creates a pull request!

v1.14.3 released!


std::evm lib, port send_value to fe

Depends on #628
What was wrong?
How was it fixed?
To-Do

[ ] OPTIONAL: Update Spec if applicable

[ ] Add entry to the release notes (may forgo for trivial changes)

[ ] Clean up commit history

Codecov Report

Merging #629 (d001358) into master (897f159) will decrease coverage by 0.20%.
The diff coverage is 85.81%.

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   85.81%   85.61%   -0.21%
==========================================
  Files          97       99       +2
  Lines        9075     9010      -65
==========================================
- Hits         7788     7714      -74
- Misses       1287     1296       +9

Impacted Files
Coverage Δ

crates/analyzer/src/errors.rs
79.59% <0.00%> (-13.27%)
:arrow_down:

crates/common/src/span.rs
76.47% <ø> (ø)

crates/lowering/src/mappers/module.rs
83.13% <ø> (ø)

crates/parser/src/parser.rs
74.29% <ø> (-2.41%)
:arrow_down:

crates/test-files/src/lib.rs
52.94% <ø> (-31.68%)
:arrow_down:

crates/test-utils/src/lib.rs
88.78% <ø> (+0.10%)
:arrow_up:

crates/yulc/src/lib.rs
88.46% <ø> (ø)

crates/yulgen/src/db.rs
50.00% <ø> (+16.66%)
:arrow_up:

crates/yulgen/src/db/queries/functions.rs
97.70% <ø> (ø)

crates/yulgen/src/mappers/expressions.rs
90.07% <ø> (-0.08%)
:arrow_down:

... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897f159...d001358. Read the comment docs.


star icons on categories need to have images

Unsure of what this ticket is referring too... could I get some clarification?

See Screenshot - service sub-category (UNHCR category) - Food Assistance in this example.

Right but what do you mean, should the icons be changed to images?

See current app - http://data.unhcr.org/jordan/services-advisor/
Each service type has a dedicated icon

Got this working for English, have to do it for arabic by translating the category back to the original english

The current arabic site doesn't have this: http://data.unhcr.org/jordan/services-advisor/index_AR.html#map-filters doesn't have this

But now we do!


Performance optimizations

Hello !
During the past week i tried to improve your code
I made some commits,
It s not much but it s honest work and I hope it helps UNION>
Br,
Tudor.

this touches many unrelated areas of the repo, some of which are in active development (and thus are changing very often or are still actively being designed). please open issues for changes that you think would be worthwhile and we can discuss there. thank you!


Update ItemSource during runtime and refresh control

I have a carousel control feeding from an item source using Binding, but when I update the item source, and I know it's been updated during debugging,  the layout is not refreshed. It still shows using the previous ItemSource,  was wondering if it's not possible or am I doing something wrong?

Thats implemented in latest release.

Oh cool, let me check it out. Can you give give a brief snippet or example just in case??

It's simple. If you use a binding or simply assign the ItemsSource property, the carousel will refresh. Also, ItemTemplate can be changed and UI will refresh.

Hello, I still faced the same error,do I need to raise property change in the model of the observable collection which is the carousel Itemsource? ? If you could give an example it would wild be nice

Of course you need to raise property changed. How the the control will now? Only add/remove from the observable collection will raise automatically but to change the whole itemssource the property in the VM needs to implement PropertyChanged. I use Fody for that myself.

If my work is helping you, please help me back: https://xamarinhq.wufoo.com/forms/nominate-a-xamarin-mvp/
This is what i have done that is community visible:

Alex has been pretty active sharing his knowledge and answering questions in StackOverflow, GitHub and Xamarin Forums.
Alex has been open sourcing Xamarin components and plugin with the community, with more of 10 repositories being maintained on GitHub.
One of Alex's Xamarin.Forms plugin, the CarouselView, is currently being pulled into the Xamarin.Forms core (https://github.com/xamarin/Xamarin.Forms/pull/853). As an stable widget, this control has become the standard for Xamarin.Forms carousel screens with more that 16K downloads in NuGet and more than 100 solved and not open issues.
Another Alex's plugin, the SegmentedControl (https://github.com/alexrainman/SegmentedControl), is a big candidate to be also pulled into Xamarin.Forms core.
Plus Xamarin.Forms UI related plugins, Alex shares plugins to set app icon Badge, Google Analytics and KeyChain access.
Alex shares his knowledge about cutting edge technologies like Couchbase NoSQL and MobileIron integration with Xamarin Apps.


[Question] Unable to connect to MySQL DB from remote machine:mysql.connector.errors.DatabaseError: 1130 (HY000): Host 'machine.xxx.xxx.com' is not allowed to connect to this MySQL server

I am new to this world so I do anything wrong please guide me.
I am using MySQL DB server 8.0 and trying to connect from a remote machine using below Python code:
import mysql.connector mydb = mysql.connector.connect(host='10.xx.xxx.xx', user='dummyuser', passwd='dummypwd') myCursor = mydb.cursor() myCursor.execute("show databases") for i in myCursor:     print(i)
I get below error:
mysql.connector.errors.DatabaseError: 1130 (HY000): Host 'xxxxxx-xxx-xxx.xxx.xxx.com' is not allowed to connect to this MySQL server
I checked on the net but nothing seems to work for me can you please guide how can I get this resolved.

收到邮件！

Issue is Solved hence Closing it.
The Host name was replaced by %.%.%.%

收到邮件！


Allow checks config to fail independently of logs config

What does this PR do?
Allows the logs config to be sent if the checks config parsing failed in AD.
I refactor the extractTemplatesFromMap function to return an array of errors. I add the info whether checks or/and logs parsing failed.
I still handle the errors in the providers to give context on the errors (did it happen in a pod / docker container / ecs ?)
Motivation
In Autodiscovery, when the parsing of checks config fails, the logs configs is not parsed and fails. We want to be able to send logs even if the checks config is broken
Additional Notes
Ideally we would display something in the agent status (or agent configcheck?) when we fail to parse a config. I'm not sure there is a simple way of doing this for the logs.

I removed the noreno tag as this is a user-facing change from 6.5. It requires a fixes item


Brainstorming the topic of the group project

Possible data sources:
past DSCI 100 projects (note: if you reuse part or all of a past DSCI 100 project, you will be required to provide documentation of written permission of all past teammates from that project)
UCI Machine Learning Repository: Data Sets
fivethirtyeight R package (if you use this, see the note below!)
Government of Canada open data
GitHub repo of awesome public datasets
tidytuesday data set
Google Data set search engine

We chose one of the past DSCI 100 projects of @Rz02. We will need to get written permission from the past teammates. Will open up a separate ticket for that.


iOS13 – Cannot disable camera button

In iOS13 Beta 5, the property "usedCameraButton" seems to have no effect anymore?
Also if we allow it, after taking photo using the camera cell the photos cells do not get updated.

Actually, i am not update to my iPhone iOS13 yet. 😢

I am facing same issue in iOS 12. Did you guys find any fix for it.

@nvish-sanjeevthapar
It's working normally on the samples.
Can you show me the setup configuration code? ( TLPhotosPickerConfigure )

Below is my configuration setup, not sure if anything else will affect it but I have set usedCameraButton to false already - works on iOS 12 though.
var configure = TLPhotosPickerConfigure()
configure.numberOfColumn = 4
configure.autoPlay = false
configure.usedPrefetch = true
configure.usedCameraButton = false
configure.allowedVideo = false
configure.allowedVideoRecording = false
configure.maxSelectedAssets = 10
configure.cancelTitle = "Cancel"
configure.doneTitle = "Done"


Fix dragonfly

Compiles ponyc on DragonFlyBSD. Test suite runs except one test case.

@mneumann thanks for this!

@mneumann hopefully we will eventually have CI for BSD, at the moment, that isnt possible as we are relying on free services. Eventually, I hope we can get enough monetary support from the community to run our own BSD CI.

@sylvanc i feel like this raises the question of, could we do a better job of handling platforms supported rather than a "here's another value to add to if statements" approach we currently have.

@SeanTAllen - I think it's a good point to discuss
@mneumann - pardon my ignorance, but what are the practical differences for our purposes between freebsd and dragonfly?  For the purposes of ifdefs in Pony, would it make sense to make dragonfly and freebsd synonymous, perhaps under the name bsd?

When adding support for Dragonfly, I think we should also be updating the README install instructions to include Dragonfly in some fashion. Perhaps changing "FreeBSD" to "FreeBSD and DragonflyBSD".
Additionally, we would need to find any documentation on support platforms in this repo and update (as part of this PR) and also in any other repos.

Additionally, when we squash and merge this, I'd want to change from "Fix Dragonfly" to "Add support for DragonflyBSD"
Given that Dragonfly is currently unsupported, we should be clear that we are adding support for it and we should, as a team, recognize what that means in terms of commitment on our part for providing support, releases, etc.

@mneumann I'm not comfortable merging with a failing test case without knowing more details. Which test fails? What's the error?

This needs a CHANGELOG.md entry

The test is SugarTest.IfDefPosix that's failing. That should be an easy fix.

It looks like we could detect DragonFly in the Makefile and define PLATFORM_IS_FREEBSD internally. That would mean Platform.freebsd() would return true for DragonFly.
Is that an acceptable consequence for lowering the maintenance burden?

@SeanTAllen  @sylvanc : Yes the failing test is SugarTest.IfDefPosix is as far as I understand somewhat related to how the macro expansion of the ifdefs work. I don't exactly understand how they work.
It think there would be all sorts of problems to declare DragonFly as FreeBSD. Also this would not help the other BSDs. Instead we should group common BSD-behaviour as such. For example with a PLATFORM_IS_BSD, which covers 90% of all BSDs.

@mneumann I think you are right about PLATFORM_IS_BSD being the way to go. I think we should go with that, and add Platform.bsd() as well. That will make future OpenBSD, NetBSD, etc ports easier to do.
Would you be up for refactoring this PR to do that? Someone can help you with the failing test case :) It's a bit tricky in there.

@mneumann i can work on finding someone who can help with the test failure if you take on the refactoring of the PR.

Marking this as discuss at sync as there has been no movement on this for a while.
We need to decide at sync if we want to take on support for DragonFly BSD as a "probably works" platform? And if we decide to, who will take over this PR and bring it home and exactly what "bring it home" means.

I'm closing this as I've opened https://github.com/ponylang/ponyc/pull/2183


tree-wide: autorename gnome packages to use dashes

Motivation for this change
Closes: https://github.com/NixOS/nixpkgs/issues/32804
The only rebuild should be plasma-nm, where patch has been modified.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval

I checked it once again and did not found any issues except for missing gnome-2 aliases, which I have now added.

Great stuff! May I suggest to squash the last fixup commit, as to not break git bisect?

@bjornfor I would leave it for just before the merge. It is useful if I need to re-generate it.


Use of path.py slows down startup time of scripts.

I would like to start by saying I genuinely love path.py and will continue using it no matter the outcome of filing this issue.  This is going to be yet another "pkg_resources is slow" issue... sorry.  Rather than provide new evidence to this, I will simply refer to pypa/setuptools#510 and the links/discussions therein.
Why do I think this is a big enough problem to file an issue? path.py is the type of module that could potentially be used in every script or command-line tool (since interacting with the filesystem is almost always unavoidable), so if a user/organization decides to use it as their primary filesystem abstraction then all of their scripts incur a startup penalty. This penalty is non-trivial - importing path.py makes command-line tool startup go from imperceptible to very noticeable where I work (we have many packages installed in site-packages). To solve this, I either have to

Create a local fork of path.py that removes the call to pkg_resources that my organization can use (instead of the version on PyPI). Not desirable, since they will become quickly out-of-sync.
Copy the path.py source file into the source code for the command-line tool and manually remove the call to pkg_resources (undesirable for all the reasons above).
Use the following hack when importing path.py

import sys
sys.modules['pkg_resources'] = None
import path
del sys.modules['pkg_resources']

None of these are desirable.
I fully understand why path.py is using setuptools_scm (and thus pkg_resources) - there should only be one source of "truth" for the version, and the VCS version is an excellent way to define truth.
But perhaps there is another way?

There is a tool bumpversion that can be used to control the version of a package, and it can be used to also create the tags in your VCS. This could be used as the source for version "truth", and can remove the reliance on setuptools_scm.
There may be ways to make __version__ a module property so that pkg_resources need only be imported if __version__ is explicitly requested. This seems rather hacky, though.

My purpose in posting this is not to complain, but hopefully to start a constructive discussion that will result in path.py imports being as fast as something like six. No matter how this is resolved, I think it would be a big win for path.py if import time is reduced.

Another possible solution - wait for importlib_metadata to land and we can use that instead.

Haha, so looks like you have already been working on this problem!!  This looks like the "correct" solution.  Do you know when importlib_metadata will be released?  Will it wait for Python 3.8, or will it show up on PyPI sooner?

Well, now I'm embarrassed... it is on PyPI already (I was in transit when I made the above post).
So far, I believe that path.py has tried to avoid any third-party dependencies (well, except setuptools_scm and pkg_resources).  Is there any hesitation on depending on this module?

will it show up on PyPI sooner?

Yes. I'm hoping to make the 0.1 release prior to the PyPA summit at the end of October (and maybe sooner).

Is there any hesitation on depending on this module?

Good point. Yes, the dependency will be optional, the same way pkg_resources is currently optional.


2 water ridge on moons catalogue

 are both different or the same ?

 are both different or the same ?

Wth ?
Logs please

um how to post logs ?

am i just gonna copy and paste the entire logs here ?

I written a guide on the mod page for logs

LogOutput.log

Thanks
I'll look at it in one or two hours I'm busy rn

ok

@DigitalIver
[Error  :LethalExpansion] The given key 'Battery' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'CannedFood' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Matchbox' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Pills' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Tape' was not present in the dictionary.
[Info   :LethalExpansion] Wateridge Moon added.
[Error  :LethalExpansion] The given key 'Battery' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'CannedFood' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Matchbox' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Pills' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Tape' was not present in the dictionary.
[Info   :LethalExpansion] Orion Moon added.
[Error  :LethalExpansion] The given key 'Battery' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'CannedFood' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Matchbox' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Pills' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Tape' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Blahaj' was not present in the dictionary.
[Error  :LethalExpansion] The given key 'Marmor' was not present in the dictionary.
[Info   :LethalExpansion] Wateridge Moon added.
one of your modules is adding another copy of Wateridge
try to disable them one by one till find which one is duplicating it

hmm i check

i try to avoid this anomaly to happen again for next update

ah i fix it just doing a reinstall and it work


LiveShare Co-Debugging

When enabling the Allow Guest Debug control, Liveshare collaborators are unable to actually do it.
Is there another setting we are missing.
Lasted VSCode and LiveShare.
Thanks!
LiveShareExport.zip

Apologies for the delay here. We’ve made improvements in this area since this issue was filed. As is, this issue doesn’t have enough information to be reproduced. Please reopen if the issue persists with any additional details. Thank you.


objstore: Download and Upload block files in parallel

Hi...
We were doing some tests on the thanos compactor on cortex and we noticed that for very big tenants the compactor was mostly waiting the blocks to be downloaded but at the same time it was not using all the network or disk available capacity.
Looking at the thanos code we noticed that the blocks and chunks are being downloaded one by one so we decided to test 2 changes (Download chunks in parallel and Download blocks in parallel) that seems to have improved a lot the compaction time.
On or test case we were compacting 6 blocks ~ 200GB each as as we can see below we were taking ~45 minutes to download each block at ~80 MiB/s (almost 7 hours to download all the blocks)

Download chunks in parallel

This change already improved the download time quite a bit from 45min per block to ~10 min per block at ~ 580 MiB/s.

We can still see the 10 min gaps between blocks where thanos is reading the index (GatherIndexHealthStats).

Download blocks in parallel

This change tries to take advantage of the time thanos is reading the index to continue to download blocks.

With both change the time required to download and read the index of all blocks decreased from almost 7 hours to ~1 hour.
PS: We may wanna limit the download concurrency.
Changes

Download chunks in parallel

Download blocks in parallel

Verification
draft

I have a previous PR for this https://github.com/thanos-io/thanos/pull/4435/files and I did some tests on this. If there are multiple blocks to compact it is easy to occupy all the disk spaces and bandwidth.
What about supporting a number of concurrency workers to download/verify the block?

Yeah... I think we can limit the concurrency.
Also doing just the first change (download chunks in parallel) already improves a lot this case and it may be safer (as at this stage we are just piping the bytes from the remote storage to the disk)

@bwplotka any thoughts about this?

@alanprot Docs failling is not related to this pr. But it would be good if you can try to rebase on main and try again.
Btw please sign off your commits.

Yeah... I think we can limit the concurrency.
Also doing just the first change (download chunks in parallel) already improves a lot this case and it may be safer (as at this stage we are just piping the bytes from the remote storage to the disk)

Let's do this in this pr. For most users, no concurrency (worker = 1) is good enough. Making this configurable is better for them to choose.

Thanks for the feedback @yeya24 I will try to do this today

@yeya24 You think i should create an "DownloadOptions" like that IterOption that already exists?

HI @yeya24
I changed the PR to just download chunks in parallel and also have a configuration (default 1) to control the concurrency.
Thanks

https://github.com/thanos-io/thanos/issues/5414 is also related so we might need to cover upload part, too (maybe someone else can do it in another pr)

#5414 is also related so we might need to cover upload part, too (maybe someone else can do it in another pr)

Oh.. I can definitely do the upload part as well.. if we think make sense.

Yes, that would be great. Maybe we can use the same flag for both download and upload concurrency then we might need to rename it somehow as it is called 'fetch-concurrency' only.
WDYT?

The compact configuration is already block-fetch-concurrency but i think in this case we may wanna change to something like block-objstore-concurrency?
The would keep the DownloadDirOption as it and create a new one for upload (UploadDirOption) as those calls can have different options in the future (even now it already have as UploadDir does not have ignoredPaths), make sense?

The compact configuration is already block-fetch-concurrency but i think in this case we may wanna change to something like block-objstore-concurrency?

Yeah, we need to change the flag name to cover upload, too. I think it is better to make it more specific. block-xxx-concurrency is a little bit ambiguous, what about block-files-objstore-concurrency or simply objstore-files-concurrency?
Naming is so hard 😄

Ok @yeya24  :D
I added the Upload Concurrency  as well..
Feel free to ask to change the parameter name! hahha =p

Rebased! :D

Hi @yeya24 @kakkoyun ...
I think i made all the changes requested :D

@alanprot So I guess we will have a follow-up pr to parallelize downloading blocks during compaction? That was the change you made at the original commit

Should we also close https://github.com/thanos-io/thanos/issues/5414?


Sort the candidates in entity linker.

The order of candidates returned from the UMLS candidate generator could be different between retries, so that when different candidates have the same scores, entity linker could return different results for each retry because of the max_entities_per_mention limit.
This PR is to sort the candidates from the candidate generator, so that the entity linker returns consistent results between retries.

@danielkingai2 Hey Daniel. I'd appreciate it if you could quickly have a look at this PR.

@danielkingai2 Hey Daniel. I'd appreciate it if you could quickly have a look at this PR.

@wlwg Could you share an example that produces different results on retries? I am not able to reproduce this locally, and tie-breaking in sorting is deterministic in python, so it would produce different results if nmslib is returning results in a different order each time (which it might be, but I'm not aware of this)

@wlwg Could you share an example that produces different results on retries? I am not able to reproduce this locally, and tie-breaking in sorting is deterministic in python, so it would produce different results if nmslib is returning results in a different order each time (which it might be, but I'm not aware of this)

@danielkingai2 This is my code example. Run it multiple times can produce results with different order.
from scispacy.candidate_generation import CandidateGenerator

candidate_generator = CandidateGenerator(name='umls')
candidates = candidate_generator(['Benlysta'], 30)[0]
print(','.join([c.concept_id for c in candidates]))

@danielkingai2 This is my code example. Run it multiple times can produce results with different order.
from scispacy.candidate_generation import CandidateGenerator

candidate_generator = CandidateGenerator(name='umls')
candidates = candidate_generator(['Benlysta'], 30)[0]
print(','.join([c.concept_id for c in candidates]))

@wlwg I still can't reproduce this, I ran
In [17]: candidates = candidate_generator(['Benlysta'], 30)[0]
    ...: for i in range(1000):
    ...:     candidates_loop = candidate_generator(['Benlysta'], 30)[0]
    ...:     assert candidates_loop == candidates

without hitting the assert. Is it possible you are changing something else between runs? What version of scispacy and nmslib do you have?

@wlwg I still can't reproduce this, I ran
In [17]: candidates = candidate_generator(['Benlysta'], 30)[0]
    ...: for i in range(1000):
    ...:     candidates_loop = candidate_generator(['Benlysta'], 30)[0]
    ...:     assert candidates_loop == candidates

without hitting the assert. Is it possible you are changing something else between runs? What version of scispacy and nmslib do you have?

@danielkingai2 You can't reproduce it by having a loop like that. (I assume it's because some kind of random seed is fixed during the whole program). You need to put it into a python script and run it multiple times in command line. You'll be able to see different results.

@danielkingai2 You can't reproduce it by having a loop like that. (I assume it's because some kind of random seed is fixed during the whole program). You need to put it into a python script and run it multiple times in command line. You'll be able to see different results.

Ok, I was able to reproduce it, thanks. I believe it is caused by this iteration over a defaultdict. I think the candidate generator is the proper place to fix, rather than the linker. Would you be up for changing that loop to iterate in a deterministic order (probably just sort the dictionary keys), and verifying that fixes the issue? Thanks!

Ok, I was able to reproduce it, thanks. I believe it is caused by this iteration over a defaultdict. I think the candidate generator is the proper place to fix, rather than the linker. Would you be up for changing that loop to iterate in a deterministic order (probably just sort the dictionary keys), and verifying that fixes the issue? Thanks!

@danielkingai2 Thanks for confirming. I also agree that the change is better to be in candidate generator. I've made the changes and fixed a related unit test. Would appreciate it if you could review it.

@danielkingai2 Thanks for confirming. I also agree that the change is better to be in candidate generator. I've made the changes and fixed a related unit test. Would appreciate it if you could review it.


Migrate test deployment to wrangler2

We currently use wrangler 1.19 and miniflare 2.5.1 for setting up the test deployment. Since wrangler2, it's now possible to run miniflare directly. The task for this issue is to re-generate the test deployment in align closer with more modern Workers deployments.

While at it, consider migrating to WASI! https://blog.cloudflare.com/announcing-wasi-on-workers/


LLMRails

LLMRails Integration
This PR provides integration with LLMRails. Implemented here are:
langchain/vectorstore/llm_rails.py
tests/integration_tests/vectorstores/test_llm_rails.py
docs/extras/integrations/vectorstores/llm-rails.ipynb

Fixed linting error


Curses doesn't work on Windows

Curses doesn't work on Windows, so for now, Windows users need to use CygWin.
I'll try to use something called UniCurses for cross-platform support.

Yay, finally. I got Unicurses up and running with the game.


Replace python -m bio2zarr vcf2zarr with python -m bio2zarr.vcf2zarr?

I.e., make each command a subpackage, and give those subpackages an __main__ definition. This seems like a more rational approach to organising things, but it does mean that encapsulating all the CLI functionality in the cli.py module as we do now  (which has a lot of advantages) may not be possible.

Note: if we do, get rid of the note on installation.md linking to this issue.

I feel like the space is more natural than the . but it's not a strongly held opinion. Nice to have all the cli in one file too.


Fix ID validation

Before, the ID was restricted to follow a UUID format while the S2 spec is less restrictive (strings composed by alphanumeric, dashes, underscores and semicolons with a range between 2 and 64).

Before, the ID was restricted to follow a UUID format while the S2 spec is less restrictive (strings composed by alphanumeric, dashes, underscores and semicolons with a range between 2 and 64).

@Flix6x  While you are absolutely right that the JSON schema and Asyncapi specify a range between 2-64, it might be good we check this with the maintainers of s2-ws-json first if it isn't a bug. The description of the specifications state that a UUID is expected: https://github.com/flexiblepower/s2-ws-json/blob/main/s2-json-schema/schemas/ID.schema.json#L7C5-L7C55  Perhaps they meant 'UUID-like' but it might be good to clarify. Asked the question: https://github.com/flexiblepower/s2-ws-json/issues/20


Add new default rules to app

@paloeka Is there a link you could add here to the latest App default rules?

What do you mean?
Do you mean this spreadsheet: https://docs.google.com/spreadsheets/d/1SAHeILvDPOj5nvshqrDyRkuQe_yL9My5TXp_Rv7LBDI/edit?gid=0#gid=0

spreadsheet might be to old


Update Interactable property code to utilize shader int keys instead of strings

Overview
InteractableTheme classes are able to update shader properties such as color or glow, etc in response to scene interactions such as focus or click. These theme handler classes updates shaders in Unity via string properties. Whenever a property is updated via a string key such as GetFloat(), Unity will automatically call Shader.PropertyToId() to get it's int key and then perform the get or the set.
This change caches the integer property keys for all property strings in a given theme class so as to help with performance when calling the get/set functions at runtime
Changes

Fixes: #4228
Optimize Shader property and Material access on Interactable*Theme class

Verification
Confirmed HandInteraction scene worked with Interactable classes on changes such as focus or clicks, etc.

/azp run mrtk_pr

/azp run mrtk_docs

Overall lgtm, just a few minor q's

@Cameron-Micka , @wiwei , @killerantz , thanks!
I did run the HandInteraction examples scene and validated all interactables changed properties as expected both in editor & on device, particularly the piano keys were easy to validate. I haven't found the InteractionProperties used anywhere else except Interactable (both runtime & inspectors). I know it is a breaking change but as already stated, minor and unlikely someone will be using it directly as well as it is an easy thing to fix if indeed the case.
I will definitely be sure to updated documentation

@troy

@Cameron-Micka , @wiwei , @killerantz , thanks!
I did run the HandInteraction examples scene and validated all interactables changed properties as expected both in editor & on device, particularly the piano keys were easy to validate. I haven't found the InteractionProperties used anywhere else except Interactable (both runtime & inspectors). I know it is a breaking change but as already stated, minor and unlikely someone will be using it directly as well as it is an easy thing to fix if indeed the case.
I will definitely be sure to updated documentation

@Cameron-Micka , @wiwei , @killerantz , thanks!
I did run the HandInteraction examples scene and validated all interactables changed properties as expected both in editor & on device, particularly the piano keys were easy to validate. I haven't found the InteractionProperties used anywhere else except Interactable (both runtime & inspectors). I know it is a breaking change but as already stated, minor and unlikely someone will be using it directly as well as it is an easy thing to fix if indeed the case.
I will definitely be sure to updated documentation

That sounds great! If you are looking to test more, @killerantz has a scene called "InteractablesExamples"

Hey @Troy-Ferrell , any update on this? Anything I can do to help?

Hey @Troy-Ferrell , any update on this? Anything I can do to help?

Sorry for the delay. I got caught up in work and travel recently.

Fixed space in for loop
Tested "InteractablesExamples" scene and objects update correctly on focus, etc
Added documentation to code explaining preferrence of integer key over string key
Updating this page to reflect this point as well:
https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/README_Interactable.html

@Troy-Ferrell , thanks for the push. Ping @wiwei if/when this is ready for check in.

@wiwei can you merge this in? Thanks!

Yes, sorry for the delay!

/azp run mrtk_pr

/azp run mrtk_docs

Merging with two approvals and successful builds.


teardown not called on dynamically-added components

Description:
I'm dynamically loading in ractive components with webpack's import(...) and then using Ractive.attachChild(lazyLoadedComponentInstance, 'anchor-name'). But the dynamically-attached child component doesn't seem to get torn down.
The parent component that owns the anchor <# anchor-name> tears down when it's hidden, but the dynamically attached child doesn't (example code below).
Docs for attachChild indicate that the parent will manage the attached child's render/unrender cycle. Does that cycle include teardown?
Versions affected:
1.3.6
Reproduction:
This code demonstrates how dynamically-attached child components don't teardown, but non-dynamically-attached children do teardown.
<!DOCTYPE html>

    <title>Ractive Dynamic Components</title>

Sorry, I thought I responded to this right after you posted it, but it looks like something happened that ate my response.
In short, no, teardown is not part of the render cycle for manually managed components. With anchor points, you're responsible for creating and destroying components in addition to handing them to a parent to have a place to live in the template (attachChild).
An {{#await}} block or simply gating the component behind an {{#if condition}} that isn't true until the component is fully loaded would be the best alternatives if you don't want to manually manage the full lifecycle outside of render. Another alternative would be to add a detached listener in the page components that call this.teardown().

No worries, thanks for the response.
For the suggestion to use {{#if, I think I'm already doing that with this:
{{#if active === 'page1'}}<# page1 msg="yay" />{{/if}}
{{#if active === 'page2'}}<# page2 something="yep" />{{/if}}

i.e., when active switches from page1 to page2, I'd want page1 to teardown. But it doesn't call teardown. Or am I misunderstanding where the {{#if needs to be?

I think I got it to work by handling calling teardown in each page component's onunrender handler like:
I had originally simply called teardown on the previous page component, but that complained about calling it on an unrendered component.
You can close this if this is all expected behavior. Thanks for your tips!

Since components are looked up lazily, gating the component behind {{#if active === 'page1'}}<page1 msg="yay" />{{elseif active === 'page2'}}<page2 something="yep" />{{else}}loading...{{/if}} you could avoid the anchors altogether. Whatever handles your routes would need to check to see if the target component is already loaded and if it is, just swap out the active value on the parent instance. If it's not, start loading the component and set the active value when it's done, optionally setting active to something like false to show the loading branch in the interim.

ooooooh, I see! It works. I lazy load the component and then set it on the parent's this.components. Thanks!


Help with posting to a mission queue

Hi,
I am trying to post a move command to the mission queue using the rest api.
What’s I’m trying to do is to try to send the robot to a location p3(guid: mirconst-guid-0000-0001-positions010) and
"mission_id": "abe05a24-3183-11eb-b645-000c29a5725a",
The created mission is labelled m1 and position P3. The guids for both mission and position is right.
{
"mission_id": "abe05a24-3183-11eb-b645-000c29a5725a",
"parameters": [
{
"input_name": "p3",
"value": "mirconst-guid-0000-0001-positions010"
}
]
}

But i get this 500 internal server error.  Do you know what i may be doing wrong?

Thanks for your help,
Michael

The REST API is not supported by this project yet. I haven't used it yet, so I'm afraid I can't help you.


Add JS only api to support non-sass environments.

The strategy here would be to separate out the color picking logic into a separate modules so they could be used in non sass environments (postcss, css in js, etc...).
Then the sass portion could act as a go between between the base logic and the sass environment, while environments that don't use sass would just use the base apis.
This would be somewhat difficult because currently the base logic depends on several sass APIs and data types.

SASS is dead, JS

The strategy here would be to separate out the color picking logic into a separate modules so they could be used in non sass environments (postcss, css in js, etc...).

This module is just a wrapper around chroma-js, to make its functions available from sass.
So if you're looking for chromatic functions in Javascript (i.e. outside of sass environments), see:
https://www.npmjs.com/package/chroma-js


Refactoring oauth integration to make openid easier

Provided a google openid integration example
OAUTH_USERNAME_INFO_KEY to define which field (usually email) to use for username. Allow nested field ( Pinterest return nested userinfo map )
provide OAUTH_EXTRACT_USERNAME_FROM_EMAIL to allow extract username from email

@lilida @sjoshi6 @haom-pinterest @yongwen

r+ with a few small comments

If only this was created/merged before we made our own patches on Teletraan to support Google Auth, it would have saved us a ton of time...
I know a lot of people will appreciate having this merged, thank you for putting it together! Super excited to have official support for non-pinadmin auth!


Refactor Payment entry forms

Notion Link:
https://www.notion.so/Refactor-Components-dc63e7c61b9e47aa9b909f0b17166d69
What

Added Formik to Payment entry form
Removed state variables used for Form

Also, the heading title of the modal is incorrect for mobile screens. @JijoBose

@apoorv1316 I've fixed the mobile view issue
https://github.com/saeloun/miru-web/assets/13100108/57034bfa-2166-4742-8119-7ab6cdd68e6e


[SUPPORT] Hudi not working with Spark 3.0.0

Describe the problem you faced
Trying to run hudi with spark 3.0.0, and getting an error
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Environment Description

Hudi version :

0.5.3

Spark version :

3.0.0

Hive version :

2.3.7

Hadoop version :

3.2.0

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) :

yes
Additional context
Add any other context about the problem here.
Stacktrace
Caused by: java.lang.NoSuchMethodError: 'java.lang.Object org.apache.spark.sql.catalyst.encoders.ExpressionEncoder.fromRow(org.apache.spark.sql.catalyst.InternalRow)'
at org.apache.hudi.AvroConversionUtils$.$anonfun$createRdd$1(AvroConversionUtils.scala:42)
at scala.collection.Iterator$$anon$10.next(Iterator.scala:459)
at scala.collection.Iterator$$anon$10.next(Iterator.scala:459)
at scala.collection.Iterator$$anon$10.next(Iterator.scala:459)
at scala.collection.Iterator$SliceIterator.next(Iterator.scala:271)
at scala.collection.Iterator.foreach(Iterator.scala:941)
at scala.collection.Iterator.foreach$(Iterator.scala:941)
at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
at scala.collection.generic.Growable.$plus$plus$eq(Growable.scala:62)
at scala.collection.generic.Growable.$plus$plus$eq$(Growable.scala:53)
at scala.collection.mutable.ArrayBuffer.$plus$plus$eq(ArrayBuffer.scala:105)
at scala.collection.mutable.ArrayBuffer.$plus$plus$eq(ArrayBuffer.scala:49)
at scala.collection.TraversableOnce.to(TraversableOnce.scala:315)
at scala.collection.TraversableOnce.to$(TraversableOnce.scala:313)
at scala.collection.AbstractIterator.to(Iterator.scala:1429)
at scala.collection.TraversableOnce.toBuffer(TraversableOnce.scala:307)
at scala.collection.TraversableOnce.toBuffer$(TraversableOnce.scala:307)
at scala.collection.AbstractIterator.toBuffer(Iterator.scala:1429)
at scala.collection.TraversableOnce.toArray(TraversableOnce.scala:294)
at scala.collection.TraversableOnce.toArray$(TraversableOnce.scala:288)
at scala.collection.AbstractIterator.toArray(Iterator.scala:1429)
at org.apache.spark.rdd.RDD.$anonfun$take$2(RDD.scala:1423)
at org.apache.spark.SparkContext.$anonfun$runJob$5(SparkContext.scala:2133)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
at org.apache.spark.scheduler.Task.run(Task.scala:127)
at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:444)
at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1377)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:447)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)```

@lyogev  can you please paste the spark shell or spark submit command you used  that would reproduce this ?

Spark 3.0 is a new version (just release in 6.18...). It is quite different from 2.0. It is not surprising that there are some conflicts.
At present, it is not recommended to use hudi by spark 3.0

lets wait for @lyogev to chime in.. I think @n3nash did explicitly test Spark 3 and confirmed it working as of 0.5.1/0.5.2

Sorry for not responding sooner.
I am working on this PR: https://github.com/YotpoLtd/metorikku/pull/335 which is right now failing in CI.
This PR in spark (merged for version 3.0.0): https://github.com/apache/spark/pull/28223
moved fromRow from ExpressionEncoder into another class.
And it is used in hudi in https://github.com/apache/hudi/blob/89e37d5273ea1c6bf2fe3a8f7053e7a3cc44011d/hudi-spark/src/main/scala/org/apache/hudi/AvroConversionUtils.scala#L42

Does #1760  help? If you could try that out & report back.. it'd be awesome..

Looks like it is! now I'm stuck at hive sync:
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/calcite/rel/type/RelDataTypeSystem
	at org.apache.hadoop.hive.ql.parse.SemanticAnalyzerFactory.get(SemanticAnalyzerFactory.java:318)
	at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:484)
	at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317)
	at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457)
	at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1237)
	at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1227)
	at org.apache.hudi.hive.HoodieHiveClient.updateHiveSQLs(HoodieHiveClient.java:401)
	at org.apache.hudi.hive.HoodieHiveClient.updateHiveSQLUsingHiveDriver(HoodieHiveClient.java:384)
	at org.apache.hudi.hive.HoodieHiveClient.updateHiveSQL(HoodieHiveClient.java:374)
	at org.apache.hudi.hive.HoodieHiveClient.createTable(HoodieHiveClient.java:266)
	at org.apache.hudi.hive.HiveSyncTool.syncSchema(HiveSyncTool.java:152)
	at org.apache.hudi.hive.HiveSyncTool.syncHoodieTable(HiveSyncTool.java:120)
	at org.apache.hudi.hive.HiveSyncTool.syncHoodieTable(HiveSyncTool.java:93)
	at org.apache.hudi.HoodieSparkSqlWriter$.syncHive(HoodieSparkSqlWriter.scala:235)
	at org.apache.hudi.HoodieSparkSqlWriter$.checkWriteStatus(HoodieSparkSqlWriter.scala:286)
	at org.apache.hudi.HoodieSparkSqlWriter$.write(HoodieSparkSqlWriter.scala:189)
	at org.apache.hudi.DefaultSource.createRelation(DefaultSource.scala:108)
	at org.apache.spark.sql.execution.datasources.SaveIntoDataSourceCommand.run(SaveIntoDataSourceCommand.scala:46)
	at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:70)
	at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:68)
	at org.apache.spark.sql.execution.command.ExecutedCommandExec.doExecute(commands.scala:90)
	at org.apache.spark.sql.execution.SparkPlan.$anonfun$execute$1(SparkPlan.scala:175)
	at org.apache.spark.sql.execution.SparkPlan.$anonfun$executeQuery$1(SparkPlan.scala:213)
	at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
	at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:210)
	at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:171)
	at org.apache.spark.sql.execution.QueryExecution.toRdd$lzycompute(QueryExecution.scala:122)
	at org.apache.spark.sql.execution.QueryExecution.toRdd(QueryExecution.scala:121)
	at org.apache.spark.sql.DataFrameWriter.$anonfun$runCommand$1(DataFrameWriter.scala:944)
	at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$5(SQLExecution.scala:100)
	at org.apache.spark.sql.execution.SQLExecution$.withSQLConfPropagated(SQLExecution.scala:160)
	at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$1(SQLExecution.scala:87)
	at org.apache.spark.sql.SparkSession.withActive(SparkSession.scala:763)
	at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:64)
	at org.apache.spark.sql.DataFrameWriter.runCommand(DataFrameWriter.scala:944)
	at org.apache.spark.sql.DataFrameWriter.saveToV1Source(DataFrameWriter.scala:396)
	at org.apache.spark.sql.DataFrameWriter.save(DataFrameWriter.scala:380)

I think calcite was removed from spark as a dependency

@lyogev could you try including it explcitly in hudi-spark-bundle pom under packaging and give it a shot? (if not, i will make sometime to try this later tonight or tomorrow morning and push a PR)

I did not run into this when testing #1760 myself, I think it might be because we have internal changes for hive3.
I just checked and it looks like we have calcite added and shaded in hudi-hive-bundle

org.apache.calcite
calcite-core
1.16.0

I think you might also need to add and shade libfb303 for hive-sync

org.apache.thrift
libfb303
0.9.3

We had these dependency changes for hive3 compatibility, however, didn't realize this was needed for spark3 also. I will try to update #1760 with what is needed.

Thanks @bschell ..

Was wondering if there is an update here! Running a PoC and would love to use Hudi + Spark 3 if possible.
Thanks!

@nsivabalan : Can you reply when you get a chance ?
Thanks,
Balaji.V

@bschell is driving this. Ref PR: https://github.com/apache/hudi/pull/1760. @bschell : any rough timelines ?

spark 3 support is available in latest release. Closing this for now. Let us know/reopen if you have any more ask.

spark 3 support is available in latest release. Closing this for now. Let us know/reopen if you have any more ask.

I am getting the same java.lang.NoClassDefFoundError: org/apache/calcite/rel/type/RelDataTypeSystem when trying to use Hive sync. It looks like Spark 3 is using a custom class loading mechanism for loading Hive:
.https://github.com/apache/spark/blob/ab93729987084ec55f762639a7e7f7cb8dd275e1/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala#L170
I think this might cause some classes to be loaded only if they are coming from one of the exec jars, which I assume are the jars shipped with Spark.

I resolved the issue by deleting these two exclusions from Spark: https://github.com/apache/spark/blob/v3.0.1/pom.xml#L1692-L1699

@dszakallas got the same behavoir on spark 3.0.2 / hudi 0.8 (RelDataTypeSystem, then HoodieParquetInputFormat)
fixed it by turning  .option("hoodie.datasource.hive_sync.use_jdbc", "true")
there is then no need for calcite jars or anything

I'm still hitting this with Spark 3.1.1 and hudi-spark-bundle_2.12-0.8.0.jar

@dude0001
.option("hoodie.datasource.hive_sync.use_jdbc", "false")
.option("hoodie.datasource.hive_sync.mode": "hms"),

did the trick for me

For someone who gets here due to the issue with AWS Glue 3.0 + Hudi Connector.
"""# 2021-11-13 status"""
AWS Glue 3.0 fails to load Image from ECR for Hudi Connector dependencies.
If you don't need Hudi Schema Evolution, then go with AWS Glue 2.0.
If you need Hudi Schema Evolution, then you have to use AWS Glue 3.0 otherwise you will see the issue related to Glue Catalog caused by out-dated EMRFS.
You can still use AWS Glue 3.0 + Hudi by adding Hudi JARs dependencies by yourself instead Glue Connector does it for you.
you need four dependencies.

https://mvnrepository.com/artifact/org.apache.spark/spark-avro_2.12/3.1.1
https://mvnrepository.com/artifact/org.apache.hudi/hudi-spark3-bundle_2.12/0.9.0
https://mvnrepository.com/artifact/org.apache.calcite/calcite-core/1.16.0
https://repo1.maven.org/maven2/org/apache/thrift/libfb303/0.9.3/

I hope this can help someone. I was stuck in this for a day.

LOL.
I've never thought that I would get a help from my own comment that I left here.

OMG.
I am here again.
I am building ETL in AWS EMR on EKS + Hudi.

emr-6.7
hudi 0.10.1

Error I have
Caused by: java.lang.ClassNotFoundException: org.apache.calcite.rel.type.RelDataTypeSystemShow context

I looked at logs in Spark Driver.
And, I noticed that Hudi is connecting to Hive. hmm.
Anyone knows how to force Hudi to use AWS Glue Data Catalog?
HoodieSparkSqlWriter$: Syncing to Hive Metastore (URL: jdbc:hive2://localhost:10000)

I am tagging related github issue ( AWS limited )

https://github.com/apache/hudi/issues/5389

I see little difference in these two different combination.

AWS Glue + AWS Glue Catalog + Hudi 0.10.1
AWS EMR on EKS + AWS Glue Catalog + Hudi 0.10.1

When using AWS Glue, it is enough to set "Use Glue data catalog as the Hive metastore".
However, when using AWS EMR on EKS, it requires some setting.

"spark.hadoop.hive.metastore.client.factory.class": "com.amazonaws.glue.catalog.metastore.AWSGlueDataCatalogHiveClientFactory"
"hoodie.datasource.hive_sync.mode": "hms"

You can find more details here
https://aws.github.io/aws-emr-containers-best-practices/metastore-integrations/docs/aws-glue/#sync-hudi-table-with-aws-glue-catalog


update letkf answers due to ADT UFO fix

Description
The ADT observation operator was wrong when using halo distribution (see https://github.com/JCSDA-internal/ufo/issues/2692), UFO PR will fix that
ADT was not being tested with LETKF / halo distribution, so ADT obs were added to the LETKF ctests and answers updated. See UFO PR for additional proof that it works.
Dependencies
Merge after:

https://github.com/JCSDA-internal/ufo/pull/2695

This looks fine. Here is a plot of difference between SST analysis after 1 cycle with split solver vs halo. Don't know what the large(ish) difference at the southern borders are.

the kd tree used can be a bit random sometimes. Also, if the halo is set smaller than the largest localization radius, it might remove observations that would otherwise be included in the non-halo distribution, but those obs are far enough away that they don't really matter


Keep track of reparented element paths

Problems
Duplicating elements that are in the root of a conditional branch is broken in two ways:

The shortcuts don't select the duplicated element(s)
Alt + drag doesn't work at all

The root cause of these problems is the same: if an element is inserted into a conditional branch next to its root element, the elements are wrapped in a fragment, which results in a different element path compared to what was calculated in the calling code, before the actual duplication was run.
Fix
To avoid having to duplicate the logic that finds out the new element path, reparentedToPaths this PR converts reparentedToPaths into a lookup, which maps the "naively" calculated path of an element (which consists of the target parent path with the duplicated element's UID appended, not taking into account the fragment wrapping) to its actual new element path. When duplicating the element, the inserted element's new path can be looked up based on the naive path.
TODO

[ ] Better name for reparentedToPaths
[ ] Move reparentedToPaths out from under EditorStateCanvas.controls
[x] Reset reparentedToPaths after running the duplicate shortcut
[x] test for the bugs fixed

a more comprehensive solution is needed


bug: scroll on touch screen devices does not work

Describe the bug
On mobile, its not possible to scroll when you try to scroll in a carousel element
To Reproduce
Go to a any mobile phone
Scroll vertically on a carousel element
Expected behavior
The scroll should be possible
Smartphone (please complete the following information):

Device: Samsung Galaxy S23
OS: Android 14
Browser Chrome
Version Latest

Additional context
Maybe you would want to listen to this event
https://developer.mozilla.org/en-US/docs/Web/API/Element/pointercancel_event
if (e.type === 'pointercancel') return;

@tnfAngel
Hi, thank you for using this open-source package and for not giving up on it despite encountering issues. Your dedication has contributed to its improvement. The problem you mentioned indeed exists. Currently.
I've replaced mousestart, mousemove, mouseup | touchstart, touchmove, touchup with pointerstart, pointermouse, pointerup, pointercancel along with touch-action: pan-y.
It may not be elegant when sliding at an angle
Feel free to test this version and see if it meets expectations.
"bear-react-carousel": "4.0.27-alpha.0"

@tnfAngel
Hi, thank you for using this open-source package and for not giving up on it despite encountering issues. Your dedication has contributed to its improvement. The problem you mentioned indeed exists. Currently.
I've replaced mousestart, mousemove, mouseup | touchstart, touchmove, touchup with pointerstart, pointermouse, pointerup, pointercancel along with touch-action: pan-y.
It may not be elegant when sliding at an angle
Feel free to test this version and see if it meets expectations.
"bear-react-carousel": "4.0.27-alpha.0"

Currently https://bear-react-carousel.pages.dev/ has switched to this version.

That's really awesome! Now it works excellent, thank you! ❤

@tnfAngel Hi, I fixed the problem of sliding and scrolling at the same time when touching the mobile phone at an angle.
There is also an error in the judgment of window.resize when body scroll is triggered, so that it will not jitter when sliding (between slideToVirtualIndex and move)
in addition
Because in mobile pointermove, the body scroll will trigger pointercancel, causing pointermove to be interrupted. The limit is only open to touch-action: pan-y, which will trigger cancel when sliding at an angle, but if touch-action: none, it will not be possible to scroll down.
So I changed back to touchmove in mobile
"bear-react-carousel": "4.0.27-alpha.3"


Debug print freezes execution if there is no UART receiver

Flow control stops the UART from sending while it waits for the receiver's buffer to clear. This makes it so in the BattOr's init freezes when in debug printing mode.

Fixed this issue by removing all debug prints.


Avoid race condition in election test

Avoid race condition in election test
The change to go.mod are a side effect of #1457 and #1456

I recommend adding a go mod tidy test to Travis to stop your go.mod/go.sum lagging behind changes (see Trillian's Travis config for an example).

I've removed the mod file changes to clean up the PR.


feat: automatic batching

Description of change

feat: evaluate multiple sequences in parallel with automatic batching
feat: improve automatic chat wrapper resolution
feat: smart context shifting
feat: improve TS types
refactor: improve API
build: support beta releases
build: improve dev configurations

BREAKING CHANGE: completely new API (docs will be updated before a stable version is released)
Closes #85
Fixes #102
Fixes #94
Fixes #93
Fixes #76
Things left to do (in other PRs)

Update documentation
Use the smart context shifting support in LlamaChatSession
Add contexts manager to automatically create more contexts as needed
Improve grammar support
Try to disable llama.cpp logs by default
Add migration guide from v2 to v3
Add more tests

Pull-Request Checklist

[x] Code is up-to-date with the master branch
[x] npm run format to apply eslint formatting
[x] npm run test passes with this change
[x] This pull request links relevant issues as Fixes #0000
[ ] There are new or updated unit tests validating the change
[ ] Documentation has been updated to reflect this change
[x] The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

is there a code snippet that shows how to correctly use batching?
I'm doing repetitive things in a loop and wondering how I might take advantage of this?

@Madd0g There will be a better example in the documentation when version 3 leaves the beta status soon, but for now, here's a simple example:
import {fileURLToPath} from "url";
import path from "path";
import {getLlama, LlamaChatSession} from "node-llama-cpp";

const __dirname = path.dirname(fileURLToPath(import.meta.url));

const llama = await getLlama();
const model = await llama.loadModel({
    modelPath: path.join(__dirname, "models", "dolphin-2.1-mistral-7b.Q4_K_M.gguf")
});
const context = await model.createContext({
    sequences: 2
});

const sequence1 = context.getSequence();
const sequence2 = context.getSequence();

const session1 = new LlamaChatSession({
    contextSequence: sequence1
});
const session2 = new LlamaChatSession({
    contextSequence: sequence2
});

const q1 = "Hi there, how are you?";
const q2 = "How much is 6+6?";

const [
    a1,
    a2
] = await Promise.all([
    session1.prompt(q1),
    session2.prompt(q2)
]);

console.log("User: " + q1);
console.log("AI: " + a1);

console.log("User: " + q2);
console.log("AI: " + a2);

The batching is done automatically across sequences of the same content


Verbosity flags for optimisation and compilation now used

Ready to be merged.

Hmm, coverage fails because the print statements don't get tested. We could change the coveragerc to ignore all print statements? Writings tests for print statements seems overkill.

woah, that's a bug in gpmc.py
 L = tf.cholesky(K) + eye(tf.shape(self.X)[0])*settings.numerics.jitter_level

should be
 L = tf.cholesky(K + eye(tf.shape(self.X)[0])*settings.numerics.jitter_level)

Current coverage is 98.93% (diff: 76.92%)

Merging #202 into master will decrease coverage by 0.18%

@@             master       #202   diff @@
==========================================
  Files            22         22
  Lines          1596       1601     +5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1582       1584     +2
- Misses           14         17     +3
  Partials          0          0

Powered by Codecov. Last update 9fbdec8...7c9df40

jitter also gets used in sgpr.py, conditionals.py, svgp.py

Should tests also depend on the jitter level?

I thinks tests should pass with the gpflowrc that we provide.
If users want to go off-piste and change the settings, that's fine, but running the tests for every permutation of gpflowrc is not feasible.


TSC Infrastructure Meeting Minutes 27 April 2021

SAFR Production Binary Deliverable to GIT

license.md file has been created for this particular deliverable
readme.md has been updated to hold the deployment instructions for this Repo
currently on Hold waiting for an examination of candidate PDS's and contents of those PDS's
Kip asked about RM issues in this license.md  Bobmcc to chase up

MR91 Binary Deliverable

approval received to include SAX XML Parser modules from XML Toolkit team in China
deployment into z/OS from Git are understood
as source for this deliverable will not reside in GIT only a binary file, we need to perform a special build on KANPLEX to ensure correct version release number
bobmcc advised a bespoke build for this with a specific VRM needed

Performance Engine sans CPP code Build

we have a deployment plan for this Repo
after GIT cloning to USS, we run a shell script to create and populate the source PDS's on z/OS
then a supplied batch job (in SAMP) uses a supplied REXX pgm (in SAMP) to create 3 build jobs
BUILD1 to assemble all parts listed in INVM
BUILD2 to preprocess and assemble all DB2 assemble files in INVM
BUILD3 to bind all modules as listed in INVM
VICOM have the latest Toolkit structured macros
Kip asked that POLYCEPHALY be looked as well for builds

Move Performance Engine to IBM Internal GITHUB

currently waiting on a INVM examination for open source shipment

Installation Verification

Plan here is to deploy the testsuite
on USS on Kanplex we performed a GIT clone of the Test Framework repo
we deployed GRADLE software onto USS
Using GRADLE we ran the Test Framework as a pure java application to perform all the tests
Took under 10 minutes
Issue does exist where the ouput HTML is sent/stored

Java Source Scans

some training exist to show SAFR staff to use SONAR QUbe
We use the community edition of SONAR QUBE

Move WorkBench to external Git

waiting on IBM development staff for final tweaks

Move Test FrameWork to external Git

waiting on development tweaks for this repo

Kanban

update GD 24 with results of testing Test Framework from USS
update GD 18 with data about deploying PE

Meeting complete


Update to work with Ubuntu 20.04 and ROS2 Foxy.

Hi @tdenewiler
Thank you for your PR about Foxy and Gazebo 11. At first glance, your changes to use Gazebo 11 match what I had noted before. I need some time to review it more deeply.

@tdenewiler I could review your PR and I approve your changes.
However, some features are missing to finalize a migration to Foxy.

[ ]  node-name in the XML launch files and node_name in the python ones are deprecated and should be renamed to name

[ ]  node_executable in the python launch files is deprecated and should be renamed to executable

[ ]  node_namespace in the python launch files is deprecated and should be renamed to namespace

[ ]  CMake macro ament_export_interfaces is deprecated and should be renamed to ament_export_targets

[ ] Xacro now benefits from a better support and allows a direct parsing of xacro files to a given parameter instead of writing the resulting file in the disk. Implied changes:

uuv_descriptions, uuv_thruster_manager/tests, uuv_gazebo_ros_plugins python launch files where the generation of the parsed file is replaced by a string parameter robot_description passed to the node constructor. The string could be obtained either by a launch.substitions.Command call or a xacro.process() call.

thruster_manager.py could read a robot_description parameter instead of loading the file to get information from the urdf description. Parameters are no longer global as they were in ROS 1, so a new way to do it has yet to be choosen (read the parameter stored in which node ?).

Pending:

[ ] Force system gazebo plugin should be loaded by default when launching Gazebo server (see here). However, installing Gazebo ros pkgs from sudo apt install ros-foxy-gazebo-ros-pkgs is not sync with the foxy branch of their repository and force system is still not loaded by default. So, I'm just writing it for information.

I have two questions:
Have you checked the checkbox allowing maintainers to push to your pull request ? If not, would you mind allowing us to push ?
Let me know if you are willing to to do some tasks (xacro part is clearly the most time consuming). Otherwise, I can do it myself, there are no problems.

@jpliquid, in my view of the PR I can see the box checked next to Allow edits by maintainers. You should be good to go there.
I am happy to work on some of the items in your list, which is a nice list by the way. Was that list posted somewhere before now? Do you have a recommended way of testing, and what you look for while doing it? I was using Github Actions and running the launch files from your Test the package section. The launch files would get hung up on spawning a new vehicle.
Another question I have is whether you intend to continue supporting ROS2 Eloquent? There are some changes to CMakeLists.txt that are recommended when moving to Foxy, but I didn't want to include those if you are still trying to support older versions of ROS2. Your list seems to include things that might break Eloquent support.
I don't have a lot of free time this week, but I think most of the desired changes in your list are straightforward. Whether I could finish it this week partly depends on how much backwards compatibility you want to keep :)

@tdenewiler, My list was not posted anywhere, I've just summarized and collected what I know is needed for the migration these last few days.
I don't really have a recommended way to test and I find that testing the whole package can be really time consuming. As you said, a nice start is the test example in the readme and the unit tests (with colcon test --packages-up-to plankton, which is also equivalent to our Github Action).
In general, I try to test each package independently for each file. I have also tested other vehicles like eca_a9. There are many example files in uuv_gazebo and uuv_tutorials, but I haven't migrated them yet.
In my opinion, a not-so-bad and quick way to globally proceed is to compare the behaviour of the simulation in Plankton with UUV Simulator, either visually or using for example tools like rqt_gui to check that the connections of topics and nodes are the same.
The plan is indeed to move to Foxy and drop Eloquent support, except maybe for critical patches. Actually, I have already created a new branch eloquent and your pull request will be merged to the master branch, which will reflect Foxy. So, you are very welcome to share what could be the changes related to CMakelist.txt :)
Next step will be to update the installation instructions in the readme / changelog / version / Github actions.
If you are happy to work on some items in my list, I appreciate your help! I could do the xacro related part and leave you the rest of the tasks for example if it suits you. They are straightforward as you noticed, but implies many many files to change (almost all the launch files, some CMake)

The launch files would get hung up on spawning a new vehicle.

What do you mean ? Is it an issue when spawning a second vehicle ?

@jpliquid, here is what I mean by the launch files get hung up. This could be related to the xacro issues you are already aware of.
In Terminal 1 I run the following, and see Gazebo start up. It looks the same as UUV Simulator.
ros2 launch uuv_gazebo_worlds ocean_waves.launch

In Terminal 2 I run
ros2 launch uuv_descriptions upload_rexrov.launch mode:=default x:=0 y:=0 z:=-20 namespace:=rexrov

The last of Terminal 2 output is
[spawn_entity.py-1] [INFO] [1607013819.435319489] - rexrov.urdf_spawner:/opt/ros/foxy/lib/gazebo_ros/spawn_entity.py:_spawn_entity:282: Spawn status: SpawnEntity: Successfully spawned entity [rexrov]

But an issue occurs in Terminal 1 after I run the launch command in Terminal 2. I get the following error message, and no vehicle shows up in Gazebo.
[gzserver-2] Error [parser_urdf.cc:3193] Unable to call parseURDF on robot model
[gzserver-2] Error [parser.cc:488] parse as old deprecated model file failed.

FYI, I used find . -name \*.launch | xargs grep node-name to find all instances that needed to be changed in the launch files (and similar commands for the other strings to change).

Ok, I see. I have the same message and the error comes from the parser here. But that's weird that no vehicle shows up. In my case, the error seems transparent and I see the vehicle (Eloquent & Foxy) in Gazebo and rviz. I need to take some time to investigate anyway.
Thanks for the first updates by the way.

@jpliquid, here is what I mean by the launch files get hung up. This could be related to the xacro issues you are already aware of.
In Terminal 1 I run the following, and see Gazebo start up. It looks the same as UUV Simulator.
ros2 launch uuv_gazebo_worlds ocean_waves.launch

In Terminal 2 I run
ros2 launch uuv_descriptions upload_rexrov.launch mode:=default x:=0 y:=0 z:=-20 namespace:=rexrov

The last of Terminal 2 output is
[spawn_entity.py-1] [INFO] [1607013819.435319489] - rexrov.urdf_spawner:/opt/ros/foxy/lib/gazebo_ros/spawn_entity.py:_spawn_entity:282: Spawn status: SpawnEntity: Successfully spawned entity [rexrov]

But an issue occurs in Terminal 1 after I run the launch command in Terminal 2. I get the following error message, and no vehicle shows up in Gazebo.
[gzserver-2] Error [parser_urdf.cc:3193] Unable to call parseURDF on robot model
[gzserver-2] Error [parser.cc:488] parse as old deprecated model file failed.

Hi, I got this question too, I don't know how it happened, have you solved it?


Add tiling endpoints

Blocked by #36
Will not work correctly in development environment without #34
Closes #5
This PR adds two new endpoints:

dataset/{pk}/tiles/metadata: metadata related to the tiles of the Dataset
datasets/{pk}/tiles/{z}/{x}/{y}.png: the specified tile of the Dataset

This uses just the system libraries necessary to build GeoDjango. Tiles are generated in a "streaming" fashion. The image is read remotely from the object store.
This was tested against the target Vandy image. I'm not sure how to include such a test or include seed data for such a large blob.

This PR is considered to be in its final state, but will be listed only as draft PR until #36 is merged in.

Tests are failing due to tox configuration issues fixed in #35, namely https://github.com/atlascope/atlascope/pull/35/commits/e85a28b8ee97fac8edccb42d3d63e9c1f608fef9.


Support JsonSerializable and XmlSerializable in RestProxy

Description
Adds support for JsonSerializable and XmlSerializable in RestProxy when azure-json or azure-xml can be found on the classpath and the request body type or response body type is an implementation of one of the interfaces.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-core


angular not defined.

production.min.js?r=0.10.2:1 Uncaught ReferenceError: angular is not defined
at production.min.js?r=0.10.2:1
at production.min.js?r=0.10.2:1
(anonymous) @ production.min.js?r=0.10.2:1
(anonymous) @ production.min.js?r=0.10.2:1
(index):128 Uncaught ReferenceError: angular is not defined
at (index):128
(anonymous) @ (index):128
sails.io.js:438
running the latest release in docker throws and error that angular is not defined.  (0.10.2)
The page is showing complete blank
angular is showing in the bower_components folder and there are no errors during npm install
running node 8.9.4

https://github.com/pantsel/konga#faq

npm run bower-deps
i added this after npm install in the docker build and tried running it by connecting to the running container and I am still getting the error

This error is pretty standard.
Do you have the assets/bower_components folder in your project?
If not, the bower dependencies are not installed.
Try a simple bower install and see what happens.
Are you are trying to build a docker image from source?

building from the release because kong is on the same image so it has access to the admin api without exposing

I have a /app bower_components folder but not an assets/bower_components

do you have a .bowercc file? What are its contents?

there is no .bowercc file

Then your source code is not complete. Cross check it with Kongas source code from the repo

testing now.   I was missing the . files

@slimm609 ,
any news?

still running into an issue but comparing to make sure that all the code is there.

Its resolved.   Thanks for your help!

i have assets/bower_components folder in your project but i still get errors in above image.

Hi friends!
My problem was solved using: bower install --allow-root
For installing as root


Allow the URL of the Core Text font to be fetched.

This allows FreeType to load Core Text fonts, which is necessary for
WebRender (unless we want a Quartz backend for WebRender).
r? @glennw

@bors-servo r+

:pushpin: Commit 8380931 has been approved by glennw

:hourglass: Testing commit 8380931 with merge 7140635...

:sunny: Test successful - travis


Creates sdk-testing and adds ActorClientStub class.

Description
Creates a new project: sdk-testing.
Adds ActorClientStub class for easy mocking of ActorClient class.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #543
Created new project (sdk-testing) to be used in #541
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[X] Code compiles correctly
[X] Created/updated tests
[ ] Extended the documentation

@mthmulders  @TomCools It would be great to have your feedback on this PR.

@mthmulders @TomCools It would be great to have your feedback on this PR.

I will go through it next week.

@mthmulders @TomCools It would be great to have your feedback on this PR.

I will go through it next week.

Idem Ditto 😄... weekend first!

I think we more clearly need to define what kinds of features we would want in an "sdk-testing" module. Adding stubs like the one that was added now doesn't add much on top of Mockito. If we want to support other testing libraries... that's something else, but i'd argue that Mockito is pretty standard.
I do however see a lot of value in the following kind of test-utilities that might be placed in this module.

A Testing sidecar, and a way to spin up other "components + sidecar".

These other components could be custom wrapper this module provides in the form of

For HTTP: "Sidecar + WireMock"
For Pubsub: "Sidecar + ?"

@mthmulders you have any more ideas on this?

We have an issue to create this "testing SDK" project: https://github.com/dapr/java-sdk/issues/541
yes, the idea is that it can help apps to write integration tests with actual Dapr sidecar running. We have that code already in our internal testing package (sdk-tests), so the idea is to create an user friendly API.

A second line of thought on this: I typically try to avoid mocking "things I don't own". If I were building applications with Dapr, that would mean I would avoid mocking Dapr internals. I'd rather not have my test depend on the internals of an SDK I use.
I'd prefer a test that proofs the behaviour of my production code over a test that proofs I invoke the right methods of a third-party class. The latter may change as that SDK evolves. The former should hardly ever change.
By providing convenient mocks of our own internals, I feel we're encouraging consumers to do the former.

I like the idea of this as well, but it'd be good to see it in action. We have the actor example in the Java SDK already. Do you think we could see how this would add a unit test/integration test to that as an example? I think that would help show what value this adds, or, show us that we're OK with just Mockito for now.

The unit test in this code shows that.

A second line of thought on this: I typically try to avoid mocking "things I don't own". If I were building applications with Dapr, that would mean I would avoid mocking Dapr internals. I'd rather not have my test depend on the internals of an SDK I use.
I'd prefer a test that proofs the behaviour of my production code over a test that proofs I invoke the right methods of a third-party class. The latter may change as that SDK evolves. The former should hardly ever change.
By providing convenient mocks of our own internals, I feel we're encouraging consumers to do the former.

I've seen this approach before and it probably means creating Facade interfaces to abstract 3rd party interfaces. This is not  necessarily a universal practice. We already encourage mocking of Dapr client by providing it as an interface. If a developer wants to avoid that, he then should come up with his/her own interfaces to avoid exposing any direct interaction with Dapr.
To a greater extend, Dapr is that abstraction already - avoids applications to implement against specific interfaces of their cloud components by providing a common interface.

/ping @halspang @TomCools @mthmulders
Code freeze is today, so I assume we will not include this in this release unless we get some consensus on this. As a maintainer, I seek consensus as much as possible - so will give everyone some time to agree on a path forward here.

I talked to @rynowak about this. I will try a solution where the user provides a mock implementation of their actor interface and we offer an ActorClient implementation that calls into the in-memory implementation. So users just mock their actor interface and not the method from ActorClient. I will try that in the next release, since code freeze is today. Thanks for playing.


fix: check err on request_stream

Motivation
request_stream dont return an Err in case of Http Error
Solution
Re-use the same method as request_text, with a little refactoring

(don't know why it was closed)


Make the repo public

Is there anything we need to do before making the repo public?

[x] Click the button.


iCubGenova11: add mc and ft ros2 nws

This PR adds the xml files for running the ft and mc ros2 nws.
It has been tested on the robot.

Probably more check/fixes are needed on the urdf in order to visualize the data correctly on rviz, meanwhile here is an example of visualization of data on rqt:

cc @maggia80 @pattacini @randaz81 @elandini84 @xEnVrE

regarding iCubGenova11/icub_all_ros2.xml I recommend using the syntax shown in https://github.com/robotology/robots-configuration/blob/master/R1SN003/CER.xml, so you can use a single main xml file.

Yes I think we can takle that upgrade with the new sintax later on probably it needs also intensive testing

I added the issue here: https://github.com/robotology/robots-configuration/issues/417


Too small NoTrafficTimeout should refuse creation/modification of user in webadmin

Thinking about it more... fixing defaults (#1418) should be enough.


Log: update severity level where appropriate

Hi!
Continuation of https://github.com/opnsense/core/pull/5497
log_msg() sets LOG_WARNING by default as discussed at https://github.com/opnsense/core/commit/279de63e63129e0b6c94fcbf4b944674bc22a38d#comments
change severity level where appropriate
Thanks!

Please let’s avoid the larger change before 1 months prior to 22.7. What we can do now is transform syslog() calls to log_msg() without those in config.inc

@kulikov-a draft is fine, thanks for your patience

@kulikov-a if you can give this another try, see 931a851e09f 8b078c0ffd a7fd4381a2ee

Too much movement, I think we better close this.

@fichtner Sure, I'll try to find some time )


--version cmd-line option

This can be a helpful quick-n-easy way to find out which cpplint is being used. (vs. Google one)

I suggest using the PyPI version number for --version and putting a sentence in --help about how this is an advanced fork of the official Google cpplint.


Remove ockam node purge command

ockam node purge and ockam node delete --all have very similar behavior.
We want to keep ockam node delete --all

https://github.com/build-trust/ockam/blob/develop/implementations/rust/ockam/ockam_command/src/node/delete.rs
https://github.com/build-trust/ockam/blob/develop/implementations/rust/ockam/ockam_command/src/node/purge.rs

I like to work on this. Should I remove the purge.rs file?

@PrajwalBorkar 👋 That's great. Thank you.

Should I remove the purge.rs file?

Yes and the locations where its referenced https://github.com/build-trust/ockam/blob/develop/implementations/rust/ockam/ockam_command/src/node/mod.rs

fixed in https://github.com/build-trust/ockam/pull/3030


For Static and Dynamic buffers, send @max_items with subscriptions.

Currently, I'm relying on slang code and data-maxChildren so the javascript on the browser has a way of knowing how long a list should be.  Since that data's known on the server, and since the entire point of this framework is to seamlessly send data to the client, this is a no-brainer.
After WebObject#subscribe subscribes the user, send a update_attribute message to that dom id with a value of "data-maxChildre=#{@max_items}"

Impemented with cleaner_dom branch, to be merged shortly.


Update cryptic clue message to include bringing a sled

fixes #10287

I listed cryptic clues that could benefit from an item recommendation in https://github.com/runelite/runelite/pull/9628#issuecomment-520750625 but there's not a significant amount of them, even fewer which actually require a specific item to be able to be completed. So imo just a note in the description like this seems fine.


Fix a couple typos

Signed-off-by: Carlos Eduardo Arango Gutierrez<EMAIL_ADDRESS>
What type of PR is this?
/kind cleanup
/kind documentation

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes nothing
Special notes for your reviewer:
Spring cleaning

/lgtm
/approve

/check-cla

/check-cla

/check-cla

/check-cla

/check-cla

you might want to create a new PR

you might want to create a new PR

#102 is on the same situation, going to focus on others things and circle back to this PR's later today

Last try
/check-cla


How to run code in Backend to build and destroy widget in Flutter app

I wanna build an android app that I can control in Backend, such as I can run the code on the server, and rebuild the widgets in the flutter app while running on android.
I am a new programmer, and right not I don't have much understanding, So please anyone can tell me how I could achieve this.

The Github issue tracker is for bugs and features requests for the Flutter SDK. Help and support questions like these are better suited for Q&A sites like StackOverflow or on one of the flutter community sites at https://flutter.dev/community .


missing dist directory after npm install

🐛 Bug description
After installing this package with npm, the node_modules/serverless-localhost/ directory contains just package.json, README.md, LICENSE, and CHANGELOG.md.  The dist directory is missing.
Consequently running serverless localhost fails with

Serverless plugin "serverless-localhost" not found. Make sure it's installed and listed in the "plugins" section of your serverless config file.

I think you need to commit the dist directory to the repository per https://stackoverflow.com/questions/46619788/npm-install-from-a-git-repo-leaves-a-pretty-blank-package
🤔 Expected Behavior
The dist directory should be present after installing.
👟 Steps to reproduce
$ npm install softprops/serverless-localhost
$ ls node_modules/serverless-localhost/
CHANGELOG.md  LICENSE       README.md     node_modules/ package.json
$ serverless localhost

  Serverless Error ---------------------------------------

  Serverless plugin "serverless-localhost" not found. Make sure it's installed and listed in the "plugins" section of your serverless config file.

🌍 Your environment
$ npm --version
6.5.0
$ node --version
v11.6.0
$ uname -a
Darwin localhost 18.7.0 Darwin Kernel Version 18.7.0: Sun Dec  1 18:59:03 PST 2019; root:xnu-4903.278.19~1/RELEASE_X86_64 x86_64

serverless version: 1.60.4 (standalone)
serverless-localhost version: latest master, 0.1.0

thanks for this, maybe you should submit a PR?

@y2kappa good point -- submitted https://github.com/softprops/serverless-localhost/pull/15


Issue/4667 fix e2e

Description

Short description here *

closes #4667
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Code is clear and sufficiently documented
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Processing this pull request

Merged into branches iso5 in 106e0521a417efdf6c21dde45cdb72a6c32eafa9


Variable interpolation into shell commands is unsafe

I see code like this:
subprocess.call(
    'cd "%s" && %s %s%s "%s"' % (
        gcov_root, args.gcov, args.gcov_options, local_gcov_options, path),
    shell=True)

You should wrap these in strings in calls to pipes.quote (Python 2.7) or shlex.quote (Python 3.3).
It would probably be OK to not execute this in a shell, by the way, and just set the cwd argument. No quoting necessary.
Also the check_call method will raise an exception if the subcommand failed, which might be useful to know.

Patches of course welcome.
cpp-coveralls currently targets pypy, 2.7, 3.4, and 3.5 [1]
Is there a quoting option that supports both python2 and python3 ?
[1] https://github.com/eddyxu/cpp-coveralls/blob/master/.travis.yml#L3


server doesn't respond to terminate signal in container

refactor Dockerfile and entrypoint so node is PID=1

Fixed in 2.8.4


UnicodeEncodeError: 'latin-1' codec can't encode character '\u2026' in position 57: ordinal not in range(256)

Getting a cryptic exception when running the following snippet:
from googleapiclient.discovery import build
from google.oauth2 import credentials

access_token = "<access token from a JS auth response>"
creds = credentials.Credentials(access_token)
drive = build('drive', 'v3', credentials=creds)
files = drive.files().list().execute()

---------------------------------------------------------------------------
UnicodeEncodeError                        Traceback (most recent call last)
<ipython-input-6-76b44e24404f> in <module>
----> 1 files = drive.files().list().execute()

/usr/local/lib/python3.7/site-packages/googleapiclient/_helpers.py in positional_wrapper(*args, **kwargs)
    132                 elif positional_parameters_enforcement == POSITIONAL_WARNING:
    133                     logger.warning(message)
--> 134             return wrapped(*args, **kwargs)
    135
    136         return positional_wrapper

/usr/local/lib/python3.7/site-packages/googleapiclient/http.py in execute(self, http, num_retries)
    927             method=str(self.method),
    928             body=self.body,
--> 929             headers=self.headers,
    930         )
    931

/usr/local/lib/python3.7/site-packages/googleapiclient/http.py in _retry_request(http, num_retries, req_type, sleep, rand, uri, method, *args, **kwargs)
    189         try:
    190             exception = None
--> 191             resp, content = http.request(uri, method, *args, **kwargs)
    192         # Retry on SSL errors and socket timeout errors.
    193         except _ssl_SSLError as ssl_error:

/usr/local/lib/python3.7/site-packages/google_auth_httplib2.py in request(self, uri, method, body, headers, redirections, connection_type, **kwargs)
    223             redirections=redirections,
    224             connection_type=connection_type,
--> 225             **kwargs
    226         )
    227

/usr/local/lib/python3.7/site-packages/httplib2/__init__.py in request(self, uri, method, body, headers, redirections, connection_type)
   1707                 else:
   1708                     (response, content) = self._request(
-> 1709                         conn, authority, uri, request_uri, method, body, headers, redirections, cachekey,
   1710                     )
   1711         except Exception as e:

/usr/local/lib/python3.7/site-packages/httplib2/__init__.py in _request(self, conn, host, absolute_uri, request_uri, method, body, headers, redirections, cachekey)
   1422             auth.request(method, request_uri, headers, body)
   1423
-> 1424         (response, content) = self._conn_request(conn, request_uri, method, body, headers)
   1425
   1426         if auth:

/usr/local/lib/python3.7/site-packages/httplib2/__init__.py in _conn_request(self, conn, request_uri, method, body, headers)
   1345                 if conn.sock is None:
   1346                     conn.connect()
-> 1347                 conn.request(method, request_uri, body, headers)
   1348             except socket.timeout:
   1349                 conn.close()

/usr/local/lib/python3.7/http/client.py in request(self, method, url, body, headers, encode_chunked)
   1275                 encode_chunked=False):
   1276         """Send a complete request to the server."""
-> 1277         self._send_request(method, url, body, headers, encode_chunked)
   1278
   1279     def _send_request(self, method, url, body, headers, encode_chunked):

/usr/local/lib/python3.7/http/client.py in _send_request(self, method, url, body, headers, encode_chunked)
   1316
   1317         for hdr, value in headers.items():
-> 1318             self.putheader(hdr, value)
   1319         if isinstance(body, str):
   1320             # RFC 2616 Section 3.7.1 says that text default has a

/usr/local/lib/python3.7/http/client.py in putheader(self, header, *values)
   1248         for i, one_value in enumerate(values):
   1249             if hasattr(one_value, 'encode'):
-> 1250                 values[i] = one_value.encode('latin-1')
   1251             elif isinstance(one_value, int):
   1252                 values[i] = str(one_value).encode('ascii')

UnicodeEncodeError: 'latin-1' codec can't encode character '\u2026' in position 57: ordinal not in range(256)

Packages:
google-api-python-client==2.10.0
google-auth==1.32.0
google-auth-oauthlib==0.4.4
google-auth-httplib2==0.1.0

Hi @steverecio,
Could you try the request through the Try this API UI on the right hand side of this page? That will help narrow down the source of the issue.
Could you also share what version of httplib2 is installed?

@busunkim96
In [2]: import httplib2

In [3]: httplib2.__version__
Out[3]: '0.19.1'

It looks like the error is happening when the request is being sent. Could you enable httplib2 debugging and check the list of headers that are being sent? (Particularly authorization: Bearer ... since my best guess is that the token somehow ends up with an invalid character.)
import httplib2

httplib2.debuglevel = 4

Could you also try fetching a auth token through google-auth-oauthlib? (see this quickstart for reference). If that works, I think the most likely cause is the token.

I'm going to close this issue due to inactivity but please feel free to re-open it with more information.