test framework: echo builder returns filterable Instances

Spun out of https://github.com/istio/istio/pull/24549
Build/BuildOrFail returns a result Instances that can be used to get services by name/cluster. Useful in MC testing.
Changes under tests/integration/multicluster/ have solid usage examples.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

lint_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

lint_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test lint_istio

gencheck_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

lint_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test lint_istio

gencheck_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test gencheck_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

lint_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test lint_istio

gencheck_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test gencheck_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

lint_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test lint_istio

gencheck_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test gencheck_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

lint_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test lint_istio

gencheck_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test gencheck_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

lint_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test lint_istio

gencheck_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test gencheck_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

lint_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test lint_istio

gencheck_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test gencheck_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

lint_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test lint_istio

gencheck_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test gencheck_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test gencheck_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-multicluster-k8s-tests_istio

lint_istio
2222069475f1faa116500d35736777fc75574345
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-multicluster-k8s-tests_istio

lint_istio
2222069475f1faa116500d35736777fc75574345
link
/test lint_istio

gencheck_istio
2222069475f1faa116500d35736777fc75574345
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-multicluster-k8s-tests_istio

lint_istio
2222069475f1faa116500d35736777fc75574345
link
/test lint_istio

gencheck_istio
2222069475f1faa116500d35736777fc75574345
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

integ-operator-controller-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-multicluster-k8s-tests_istio

lint_istio
2222069475f1faa116500d35736777fc75574345
link
/test lint_istio

gencheck_istio
2222069475f1faa116500d35736777fc75574345
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-multicluster-k8s-tests_istio

lint_istio
2222069475f1faa116500d35736777fc75574345
link
/test lint_istio

gencheck_istio
2222069475f1faa116500d35736777fc75574345
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-multicluster-k8s-tests_istio

lint_istio
2222069475f1faa116500d35736777fc75574345
link
/test lint_istio

gencheck_istio
2222069475f1faa116500d35736777fc75574345
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25af284f6a7e94ae56d1d47b67d4dcbc1177c9a9
link
/test integ-multicluster-k8s-tests_istio

lint_istio
2222069475f1faa116500d35736777fc75574345
link
/test lint_istio

gencheck_istio
2222069475f1faa116500d35736777fc75574345
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2222069475f1faa116500d35736777fc75574345
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
07441bac16dae9aa9fb23454ebf3ee7fbe874dd8
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
07441bac16dae9aa9fb23454ebf3ee7fbe874dd8
link
/test lint_istio

gencheck_istio
07441bac16dae9aa9fb23454ebf3ee7fbe874dd8
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
07441bac16dae9aa9fb23454ebf3ee7fbe874dd8
link
/test gencheck_istio

lint_istio
7ff6dfff5b921b17e3db58c5896b0c5cfb3a6e7e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
7ff6dfff5b921b17e3db58c5896b0c5cfb3a6e7e
link
/test lint_istio

gencheck_istio
7ff6dfff5b921b17e3db58c5896b0c5cfb3a6e7e
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
7ff6dfff5b921b17e3db58c5896b0c5cfb3a6e7e
link
/test lint_istio

gencheck_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test gencheck_istio

lint_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test gencheck_istio

lint_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test lint_istio

integ-multicluster-k8s-tests_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test integ-multicluster-k8s-tests_istio

lint_istio
8028599f796bf55d55b606d4349570d6e0608c12
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test integ-multicluster-k8s-tests_istio

lint_istio
bd94af66f48b8dcd005c7e82d1da3ad4d9eeabdb
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test integ-multicluster-k8s-tests_istio

lint_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test integ-multicluster-k8s-tests_istio

lint_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test lint_istio

integ-distroless-k8s-tests_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test integ-multicluster-k8s-tests_istio

lint_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test lint_istio

integ-distroless-k8s-tests_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test integ-multicluster-k8s-tests_istio

lint_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test lint_istio

integ-distroless-k8s-tests_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
4b482540c9259f5cbefcc824157bd8ca73bbbbbd
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
64755fa3e0f251aa3cd506f255ea642e57e49f8b
link
/test integ-security-k8s-tests_istio

lint_istio
42a9f7c4982fe7e77481bdfc81b00d4c7e436d2b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b003b96a0f94878c4df077999bdeeeb999df361b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
0114c9e663fcb7797a2c6d43c96f61221012b014
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
4348fd1b09f26b20603f975370c8c9ad4223b1ba
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
4348fd1b09f26b20603f975370c8c9ad4223b1ba
link
/test lint_istio

integ-telemetry-k8s-tests_istio
4348fd1b09f26b20603f975370c8c9ad4223b1ba
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
8841f13e676ce809b03d0263ef4ce33f8fbbd814
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
8841f13e676ce809b03d0263ef4ce33f8fbbd814
link
/test lint_istio

gencheck_istio
8841f13e676ce809b03d0263ef4ce33f8fbbd814
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bump for @istio/wg-security-maintainers and @istio/wg-policies-and-telemetry-maintainers approval

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4050378554c21ab176f3147ef10dd2796b60f26b
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4050378554c21ab176f3147ef10dd2796b60f26b
link
/test release-notes_istio

lint_istio
4050378554c21ab176f3147ef10dd2796b60f26b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
a85f76ba00a1bd111339eca58d1635a370eb81f1
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
a85f76ba00a1bd111339eca58d1635a370eb81f1
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio


Regression: Empty boolean attributes are broken in<EMAIL_ADDRESS>(and up)

Describe the bug
After updating Clarity from 5.5.1 to 5.6.2 empty boolean attributes are evaluated as falsy. This was once already fixed for 5.2.1 in #5932.
<cds-tag readonly>readonly tag</cds-tag>

How to reproduce
Steps to reproduce the behavior:

Go to https://stackblitz.com/edit/clarity-dark-theme-v5-ljlano?file=package.json
Click on "Readonly Tag" an see interaction behaviour like "Clickable Tag", which shouldn't be there.
Downgrade @cds/angular to 5.6.0
Click on "Readonly Tag". There is no interaction behaviour.

Expected behavior
Empty boolean attributes are interpreted as truthy/present like in version 5.6.0.
Versions
Clarity project:

[x] Clarity Core
[ ] Clarity Angular/UI

Clarity version:

[ ] v3.x
[ ] v4.x
[x] v5.x

Framework:

[x] Angular
[ ] React
[ ] Vue
[ ] Other:

Framework version:
Angular 11 and 12
Additional notes
A workaround is to use property binding syntax:
<cds-tag [readonly]="true">readonly tag</cds-tag>

Thank you for the reproduction! We should be able to get a fix out for our next release.


resolved the api-version warning when used in papermc server, and fix a mvn package phase warning

ignore the MacOS .DS_Store file from the SVC
resolve the warning when used as a papermc plugin: Legacy plugin LoginSecurity v3.1.1 does not specify an api-version.
resolve a mvn package waring

https://github.com/lenis0012/LoginSecurity-2/issues/289

this breaks compatability with MC 1.13-1.18.x

this breaks compatability with MC 1.13-1.18.x

Ok, I get it. Thx

@wangzhizhou as a workaround I think I could set api-version 1.13.
That should work on 1.8 - 1.19.4 and at least not show the "legacy" warning

@wangzhizhou as a workaround I think I could set api-version 1.13. That should work on 1.8 - 1.19.4 and at least not show the "legacy" warning

May I have a try on my fork of your repo，It should be ok

Any updates on this warning issue?

@BRGustavoRibeiro should be fixed in version 3.2.0


Installation fails at "make" step

I am trying to build PANENE to use it within progressive-umap. I was able to follow the build instructions up until the step were we run make to build PANENE. This step fails with the following error message (from 57% into the process):
[...]
g++ -pthread -shared -B /[...]/miniconda3/compiler_compat -L/[...]/miniconda3/lib -Wl,-rpath=/[...]/miniconda3/lib -Wl,--no-as-needed -Wl,--sysroot=/ build/temp.linux-x86_64-3.7/[...]/Development/PANENE/python/pynene.o -o build/lib.linux-x86_64-3.7/pynene.cpython-37m-x86_64-linux-gnu.so -lpanene -std=c++11 -fopenmp

/[...]/miniconda3/compiler_compat/ld: cannot find -lpanene
collect2: error: ld returned 1 exit status
error: command 'g++' failed with exit status 1
python/CMakeFiles/target.dir/build.make:60: recipe for target 'python/build/timestamp' failed
make[2]: *** [python/build/timestamp] Error 1
CMakeFiles/Makefile2:367: recipe for target 'python/CMakeFiles/target.dir/all' failed
make[1]: *** [python/CMakeFiles/target.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

I am running  Python 3.6.5 and 3.8.5, g++ 7.5.0, make 4.1 and cmake 3.10.2 and have run into this error on the following platforms:

Ubuntu 16.04.7 on Linux 4.15.0-122-generic
Ubuntu 18.04.4 LTS on Linux 4.15.0-122-generic
Linux subsystem for Windows with Ubuntu 18.04.5 LTS on Linux 4.4.0-18362.

Any ideas on how to fix this?

As far as I remember, this is not related to the system/library version.
You can refer to this.
Hope it helps.

As far as I remember, this is not related to the system/library version.
You can refer to this.
Hope it helps.

Thank you for that link, it did the trick for me. To make g++ aware of -lpanene, I changed line 6 in python/setup.py.in to this (basically including a link to the libs in the build directory):
extra_link_args = ["-lpanene", "-L${CMAKE_CURRENT_SOURCE_DIR}/build/"]

Thank you for that link, it did the trick for me. To make g++ aware of -lpanene, I changed line 6 in python/setup.py.in to this (basically including a link to the libs in the build directory):
extra_link_args = ["-lpanene", "-L${CMAKE_CURRENT_SOURCE_DIR}/build/"]

I don't know how "portable" this solution is (given the comment that is already in that file). Let me know if you are interested in a PR for this.

I don't know how "portable" this solution is (given the comment that is already in that file). Let me know if you are interested in a PR for this.


Put forward AV._request() & ajax() to request.js .

[Current coverage][cc-pull] is 62.80%

Merging [#283][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.74%

2 files (not in diff) in dist/node were modified. more

Misses -11
Hits -58

File dist/node/ajax.js (not in diff) was deleted. more

@@             master       #283   diff @@
==========================================
  Files            27         26     -1
  Lines          2848       2758    -90
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1810       1732    -78
+ Misses         1038       1026    -12
  Partials          0          0

Powered by Codecov. Last updated by [abc2b11...2e812a3][cc-compare]
[cc-base-branch]: https://codecov.io/gh/leancloud/javascript-sdk/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/leancloud/javascript-sdk/compare/abc2b11740b358b9c73abff74caa6c95a75d2160...2e812a39a83aed666c4b92fe98020351dd3a51f6
[cc-pull]: https://codecov.io/gh/leancloud/javascript-sdk/pull/283?src=pr


[Bug]: Unable to exclude CSS files from LightningCssMinimizerRspackPlugin or to silence warnings

System Info
System:
OS: Windows 11 10.0.22631
CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
Memory: 21.27 GB / 31.70 GB
Binaries:
Node: 20.11.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.22 - C:\Program Files\nodejs\yarn.CMD
npm: 10.8.2 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: Chromium (127.0.2651.74)
Internet Explorer: 11.0.22621.3527
Details
I have external CSS files in my application which come from other bundles and I don't want LightningCssMinimizerRspackPlugin to minimize them or to show warnings about them but I am unable to exclude them no matter what I try.
Reproduce link
https://github.com/alex-vukov/rspack-css-issue
Reproduce Steps

Checkout the repo from the link.
Run npm install.
Run npm build and see this warning in the console: warn    Compile Warning:  ⚠ Invalid token in pseudo element: Dimension { has_sign: false, value: 2.0, int_value: Some(2), unit: "px" } at static\external-css\test.css:0:3274

The warning should not be there because the static\external-css folder is not included in the LightningCssMinimizerRspackPlugin's options in rsbuild.config.mjs. I tried to exclude the folder explixcitly and it still doesn't work and I see the same warning.

Rspack uses LightningCssMinimizerRspackPlugin as the default minimizer. When you use '...', it effectively registers LightningCssMinimizerRspackPlugin twice.

Then how can I pass any options to it? If I don't use '...' my Javascript doesn't get minified

I see you're using rsbuild. You might want to try this configuration, as it can override existing plugin configurations.
https://rsbuild.dev/config/output/minify#css-minify-options

I am using rsbuild for the reproduction repo but the real issue is in production code and there I use pure rspack. Can it be done in rspack in a similar way?

You can do it this way:
optimization: {
  minimizer: [
    new rspack.SwcJsMinimizerRspackPlugin(),
    new rspack.LightningCssMinimizerRspackPlugin({/* your config */})
  ]
}

Indeed, it does seem a bit cumbersome. Unlike webpack, rspack has two default minimizers. In such a scenario, what would be a better solution?
@chenjiahan cc

In my opinion the correct solution would be to make it work the same way it does in Webpack. '...' will add the default plugins but if you add a plugin after it which already exists the default instance of the same plugin should be replaced by the new plugin instance instead of having two instances.

This behavior is consistent with webpack, but webpack does not include a CSS minimizer by default. This is one of the reasons why Rsbuild was created, as it reduces the learning curve for configuring Rspack.

if you add a plugin after it which already exists the default instance of the same plugin should be replaced by the new plugin

When you add a new minimizer, Rspack does not know whether it is used to minify JS, CSS, or other assets, nor does it know which modules the newly added minimizer matches. Therefore, Rspack cannot accurately replace the built-in plugins automatically.

Indeed, it does seem a bit cumbersome. Unlike webpack, rspack has two default minimizers. In such a scenario, what would be a better solution?

I recommend keeping the current behavior, as changing the behavior here will introduce breaking changes and we haven't found a better solution yet.


espup silently discards errors when /bin/bash is not available

Bug description
Rust default installer https://github.com/esp-rs/rust/blob/4ca000ac85a4f486ed080c281c86ea2287592027/src/tools/rust-installer/install-template.sh#L1 uses #!/bin/bash shebang which is not available on some systems, but espup discards the script's output here https://github.com/esp-rs/espup/blob/d4870a5ad50d56a6d06695c6c64bdb0ce8e0eba6/src/toolchain/rust.rs#L238-L241 and here https://github.com/esp-rs/espup/blob/d4870a5ad50d56a6d06695c6c64bdb0ce8e0eba6/src/toolchain/rust.rs#L266-L269
so the installation reports itself as successful, but the actual rust toolchain won't be installed. In other words, there's no ~/.rustup/toolchains/esp/bin folder.
Trying to use such incomplete installation leads to issues like https://github.com/esp-rs/rust-build/wiki/Build-failures#linux-x86_64.

Would you like to work on a fix? idk

To Reproduce
Steps to reproduce the behavior:

Use system without /bin/bash or remove it
run espup install
the script will try to install rust compiler while silently discarding the error

Expected behavior
The rust compiler installer script works in environments without /bin/bash.
Screenshots
Environment

OS: NixOS 23.05
espup version: 0.4.1

Additional context

The shebang can probably be ignored by removing -c argument. Haven't tested yet.
+ .args(["bash"].chain(arguments))
- .args(["bash", "-c", &arguments])

Hi! Thanks for reporting and checking the fix! Would you like to open a PR with the fixing patch? If not, I am happy to open it

Would you like to open a PR with the fixing patch?

Hi. I'll be unavailable for some time today. Feel free to create PR.

Just created #312, could you verify that the PR works for you?
cargo uninstall espup
cargo install espup --git https://github.com/SergioGasquez/espup --branch fix/shebang
espup install

It does not work. I added a comment to your PR.

It does not work. I added a comment to your PR.

Thanks for your feedback, just addressed your comment and also added checking the result of the command, if it fails it will return the error! Do you mind trying it?

It works! Thanks.


chore: updated otel dependencies

Coverage remained the same at 96.97% when pulling c1eea1dc2d755d7b30c5fef8e6e6638466c9532b on pnaik1:update into bc399f0ee94abfed10bb69b3c70a5e9c3daaf4de on nodeshift-starters:main.


Ruby gems Backup and VSCode

Just opening up this issue as feature request for backing up Ruby Gems and VSCode settings and extensions.
I'll post the relevant directories after I figured them out.

Closed issues because Ruby Gems are already being backuped and there's already an Issue for VSCode.

Ruby Gems are already being backuped

Not correctly, though. #38 is open, and isn't something I'll end up fixing because I don't use Ruby too much, so if you want to work out the issue and open a PR, that'd be great.

VSCode

#45 is open already for this, and it should just be a change in the default config file in config.py. PR would also be appreciated here.


Improve sessions tool filtering

Is your feature request related to a problem? Please describe.
Currently the sessions tool uses a very custom table with limited options
Describe the solution you'd like
If the sessions tool used the standard table editor, we would get nice features, like per-column filtering, grouping panel, etc...
Describe alternatives you've considered
Just allowing per-column filters instead of a single filter applied to all columns would be a good improvement, a new FR can be opened for the rest of the features.
Additional context
I'm particularly interested about the Oracle version of this, don't know for other databases. Since for Oracle sessions are basically the result of a single query, presenting them with the default resultset viewer should be feasible.

We will implement it, but most likely only at the end of the spring. Upcoming releases are overloaded.

fair enough! keep with the good work!

I dunno, I wouldn't use that feature.
The query itself contains too much columns. Also, clicking on a row in the session manager shows details like execution plan, long ops, etc that wouldn't be available with your solution.
I'm mostly interested in a filter acting on each column separately instead of globally.

@serge-rider basically yes, per column filter is what I'm missing!

I think we should add per-column filters for all object lists (e.g. metadata editor).

So, in conclusion.
When working with the session manager, you have some additional options.

You can disable (hide) any columns in the "Configure Columns" dialog.

You can open data from the session manager in the SQL Editor as a table with the help of the "SQL" button.

And our new feature - the ability to use column grouping. It will be available in the 21.3.2 DBeaver version.

I think that at this moment the ticket can be considered as solved. If you have new ideas, feel free to open a new ticket.


[SONARMSBRU-177] Fixed error in log message (missing parameter)

Added extra logging statements

Should this ship in version 1.1 @duncanpMS ?

@dbolkensteyn it would be useful but not essential. Very few if any users will hit the error condition (I had to manually edit some of the generated files to provoke the error), and the badly-formatted message doesn't cause an exception, it's just less useful. The additional logging for valid/invalid files might be useful when answering support questions.

SonarQube analysis reported 6 issues:

 6 major

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 The 'this' parameter (or 'Me' in Visual Basic) of 'RoslynV1SarifFixer.IsValidJson(string)' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate.
 The 'this' parameter (or 'Me' in Visual Basic) of 'RoslynV1SarifFixer.IsSarifFromRoslynV1(string)' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate.
 Make "IsSarifFromRoslynV1" a "static" method.
 The 'this' parameter (or 'Me' in Visual Basic) of 'RoslynV1SarifFixer.ApplyFixToSarif(string)' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate.
 Make "ApplyFixToSarif" a "static" method.

LGTM

@tvsonar - I wonder if this bug could have been caught by static analysis ? - the number of different placeholders in the format string (i.e. {0} {1} {0} {2}) needs to match the number of string arguments. However in this case we don't call Console.Log directly but via wrappers...

@bgavrilMS We have a rule (S2275) to check for string format arguments. It doesn't handle all cases, but I think does a decent job. You can check out the recognized and non recognized examples here.
For this particular case,

the string is in a resource file, so it's not handled at all,
recognizing cases when there are less placeholders in the string then arguments is not recognized.

Maybe we should/could improve the current behavior, but that requires parsing the format string. I've created https://github.com/SonarSource/sonarlint-vs/issues/713.


SVG image is blurred when some sections have opacity<>1

Description
We want to render SVG files. Some of those SVGs contain sections where the css property opacity is set to a value that is not 1 (e.g. 0.xx). Those sections do not get drawn as expected (see the below images for expected and actual outcomes).
If you change all opacities in the below SVG to 1, everything gets rendered correctly.
 I work with @alonafe and we are patiently waiting for the release :)


How can I configure dat to use PostgreSQL as the backend

I've added "leveldown": "sqldown", to my dat.json and installed sqldown, pg and pg-query-stream
using npm install --save pg pg-query-stream sqldown
How can I configure sqldown to use a postgres connection. Right now when I run dat serve it tries to connect to a sqlite3 database that obviously does not exists.

Hey, sorry for the late reply. This month has been a bit busy getting the beta ready.
This feature is still experimental but we have a working version that deploys to heroku. You can see here where in the dat.json file, there is a place to put your DATABASE_URL connection string:
{
  "leveldown": {
    "path": {
      "env": "DATABASE_URL"
    },
    "module": "sqldown"
  }
}

I'll go ahead and document this


Efficient and less lossy powering for Gates

What should we add?
By default, powering a Gate returns a UnitaryGate. This is inefficient because it numerically calculates the matrix exponential, and it discards information about the gate that could be used for efficient compilation. This can be addressed by overriding the power method for certain gates, including:

[ ] ZGate -> PhaseGate
[ ] iSwapGate -> XXPlusYYGate

We could also add XGate.power(0.5) --> SXGate and -0.5 to SXdg.

It's worth considering whether we can add some additional structure to the gates. For example,

Make ZGate inherit from PhaseGate
Make iSwapGate inherit from XXPlusYYGate

Such changes would reduce code duplication and simplify identification of gates for efficient compilation.

As discussed in the meeting, these inheritance structures could lead to issues if the parameters of the child are not the same of the parent. Assume that ZGate inherited from PhaseGate, something like
class ZGate(PhaseGate):
    def __init__(self, ...):
        super().__init__(params=[np.pi], ...)

then in the code I could do
z = ZGate()
z.params = [0]

and suddenly my "Z" gate is the identity! 😄

Could you give some concrete examples from existing Terra code about how OOP inheritance would reduce code duplication and improve compilation efficiency?
Terra already has a mechanism for describing these relations: entries in the relevant EquivalenceLibrary (we use the name field as the key, which also lets us safely {,de}serialise custom user gate objects without needing to run arbitrary code).  This strictly more powerful, because it can relate one gate to several different compositions, each of any number of other gates.  It better represents the fact that these gates don't have a unique hierarchy - as a slightly reductive example, the I gate is a special case of any of U, P, RX, etc, but that set doesn't have a total subtype ordering under any useful definition.
I'm also concerned that while the mathematical Z gate is a special case of the mathematical P gate, that doesn't necessarily make it a valid subtype in the OOP sense.  For example, the number of parameters required to specify the operation, which is a class invariant, is not the same between the two objects.  As a concrete example of how introducing hierarchy between Z and P wouldn't necessarily help here without even more data changes: in order for the proposed custom PhaseGate.power to be automatically inheritable by ZGate, the latter would have to have its "phase parameter" accessible somewhere on the gate, defined by the parent.  This can't actually be params (because that implies mutability, which can't be inherited here), so it would have to be a separate field.  Since PhaseGate would still need its params field to be mutable, its params getter and setter would now have intercept all modifications (either to the entire params or to its __setitem__) to also mutate the other value.  We've had no end of problems with CUGate because it tries (poorly) to do exactly that.
In general, we don't use class hierarchies to specify the type of a gate, we use the gate name.  In my (admittedly relatively shallow) experience in building type-system descriptions within parsers, I've so far found that I've often started off trying to categorise things like you have done here, but it's always fallen apart for me as I've got deeper into it, mainly because these type-like objects are almost always only partially hierarchical.

fwiw: I totally support various gates gaining more accurate power methods, as mentioned in the actual head of the issue.

Thanks all, I agree with your assessment. The inheritance was not a very well thought-out proposal. I think that the structure I speak of will only be achievable once we support singleton Gates. Then, ZGate can just be an instance of PhaseGate with the angle equal to pi. This would reduce duplication because the ZGate class could be deleted. As for simplifying compilation, I'm talking about places in the code that check for special cases of gates and do something based on that. I think the equivalence library for standard gates is a good example: https://github.com/Qiskit/qiskit-terra/blob/b45afea03662bf4a2905251e26cbc008bdb3c0e1/qiskit/circuit/library/standard_gates/equivalence_library.py. Also, lines such as these which list different kinds of Z Gates: https://github.com/Qiskit/qiskit-terra/blob/19fdd32affd37afb58774f40bcf509b16480fe63/qiskit/transpiler/passes/optimization/commutative_cancellation.py#L57

That's fine, it's good to discuss!  Let's revisit the issue more when we've made some progress on getting the state out of Gate.
For your example: I'm not sure OOP hierarchy can represent this, entirely.  For example, both rz and p are in that list as being "rz-like", which in this case is only equivalence up-to-phase, rather than exact equality.  That might be ok in this case, but it causes differences if the gate becomes controlled, say, so other places that handle them might prefer subclassing to mean "child is a special case of parent".  If we try to resolve all the possible ways into one unique hierarchy using a lot of levels of abstraction, I suspect (without proof) that we'll end up with highly highly abstract intermediary levels that don't fully do their job anyway; you still end up with the "$I$ problem" I had above, where it's a special case of many different incompatible gates.

I think it makes sense to add a global_phase parameter to most or all gates. In that way rz and p can be unified.

https://github.com/Qiskit/qiskit-terra/pull/9318 overrides power for many common gates. It doesn't address XGate and YGate because there aren't analogous powered gates (for ZGate there is PhaseGate). I think we should add those gates.


upstream.get_peers() Incorrect peers when declared upstreams with same prefixes

1.3.1 Fixed

One upstream is the prefix of other.


Unable to sync previous matches

Version: v0.2.0
I'm having trouble trying to sync my previous matches, all the .json files are there but when I sync, nothing happens. All the previous games are displayed in the program and any new game I have is syncing just fine. The log looks like this: https://pastebin.com/k87fsSL9
I also tried v0.1.0, and when I sync, I get this: https://pastebin.com/mNELtgSM , all the .json files are removed after the sync is complete but I still have only 3 files synced (which I believe is from my three games I played with 0.2.0)

Based on your logs, it looks like v0.2.0 was working correctly... if you click Sync and nothing happens, that just means that the files on your computer and the files in the server are the same- otherwise, it'll either upload files the server doesn't have, or download files your machine doesn't have.  As long as the logger is running, it'll be uploading files to the server automatically, so there's no need to manually sync.
If it helps, on my end it looks like you currently have 12 games logged, so that's how many you should be seeing on your end.
Also, if you have the logger running but you're currently not logged in, it won't upload the files after you click sync.....I plan on fixing this, but for now, one workaround would be to find the folder in the directory 'hsl_files/json/hunterX' and move it into the other folder under hsl_files/json with the really long name.  make sure the directory structure stays the same though ( like 2022/08/05/attributes..... or whatever )

The problem is that I have 88 games recorded on my computer but none of them were syncing, only the games recorded with 0.2.0 are synced. I moved the .json files into hsl_files/json/LONG-ID/2022/08/06/...... and that seems to upload them, it says that I have 107 files synced. I downloaded the program again fresh to see if the files are actually synced and it says that the files are there (all 107) but only two of them gets downloaded, I think it has something to to with the error ( LOG ) , it seems to get stuck in that "refreshing token" loop forever and none of the details are updated

okay, I think I see what's been happening....I had made some changes in how the json data gets formatted, so it's only the files created with an earlier version which are failing.  So all the files are there, they're just not getting read properly.  Should be a pretty easy fix.
Thanks!!

I've pushed some changes and updated the release, so hopefully it'll be able to sync properly now.
Thanks for your feedback!

I can confirm that it works, I took 0.2.1 fresh and it synced all the files, all my games shows up in the program. Thanks for the fix.


Updated footer position at mobile view.

Fixes #290
I am attaching screenshots of website in mobile view before and after this PR.
Before

After

@Jassi10000 Sir, i request you to review my work and merge my PR in this project.


Allow for local fs config to turn packages off and on

I have a few projects that use JSHint and others that use ESLint. I'd very much like a config in the root folder that package-switch evaluates when atom is opened.
project 1
{
  "disabled": ["eslint"]
}

project 2
{
  "disabled": ["jshint"]
}

Interesting idea. It's on my list.

ty
On Tue, Sep 1, 2015 at 12:09 PM, Fabian Stiewitz<EMAIL_ADDRESS>wrote:

Interesting idea. It's on my list.
—
Reply to this email directly or view it on GitHub
https://github.com/deprint/package-switch/issues/2#issuecomment-136815017
.

Added in v0.4.0.
Create a file called .package-switch.cson in the project's root folder and set whatever linter you use to disabled.
Only limitation is that it only auto-executes the file config if there is only one active project, so multi-project work environments are not supported.

You rock Fabian. Thanks so much.
On Sep 4, 2015 8:07 AM, "Fabian Stiewitz"<EMAIL_ADDRESS>wrote:

Closed #2 https://github.com/deprint/package-switch/issues/2.
—
Reply to this email directly or view it on GitHub
https://github.com/deprint/package-switch/issues/2#event-401172267.


Bifacial_radiance

Hello, I installed everything for tool bifacial_radiance. I opened the Anaconda and the spyder but I can't find the file bifacial_radiance.py in the foder. I don't have the same files the video explained. Can you help me?. https://www.youtube.com/watch?v=4A9GocfHKyM&feature=youtu.be. Thank you

Hola Pablo,
Sorry, I left the github project unattended for a couple months  , I apologize. Thank you for finding out this detail --- the main functions got renamed to be main.py. Our training video that follows up (https://www.youtube.com/watch?v=1X9L-R-RVGA) has that updated if I recall correctly, but I'll make a note in the installation video.
Thank you,
Silvana

Hi Silvana,
Thank you very much!!!
Take care!
Pablo
Le lun. 10 août 2020 à 19:28, Silvana Ayala<EMAIL_ADDRESS>a
écrit :

Hola Pablo,
Sorry, I left the github project unattended for a couple months , I
apologize. Thank you for finding out this detail --- the main functions got
renamed to be main.py. Our training video that follows up (
https://www.youtube.com/watch?v=1X9L-R-RVGA) has that updated if I recall
correctly, but I'll make a note in the installation video.
Thank you,
Silvana
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NREL/bifacial_radiance/issues/266#issuecomment-671621273,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP54NCGLD73QAUVUDPGJUOLSABYATANCNFSM4N4JOXXQ
.


[FEATURE] create utils to create git-like text-diff for markdown Fields

Is your feature request related to a problem? Please describe.
N.A.
Describe the solution you'd like
from argilla.feedback.util import text_dif

before = "my name is"
after = "y name is"
html_str = text_dif(before, after)

Describe alternatives you've considered
N.A.
Additional context
N.A.

this compares the suggestion for corrected_text with the first response to that question
import diff_match_patch as dmp_module
from IPython.core.display import display, HTML

def extract_text_from_object(obj):
    """Extract the 'value' text from the object."""
    return obj[0]['value']

# Initialize the diff_match_patch object
dmp = dmp_module.diff_match_patch()

# Extract the 'value' text from the validated object
incorrect_df.loc[:, 'text_from_response'] = incorrect_df['corrected-text'].apply(extract_text_from_object)

def visual_diff(s1, s2):
    """Get a visual representation of the differences between two strings."""
    diff = dmp.diff_main(s1, s2)
    dmp.diff_cleanupSemantic(diff)
    return dmp.diff_prettyHtml(diff)

# Let's apply this function to the DataFrame
incorrect_df['visual_diff_html'] = incorrect_df.apply(lambda row: visual_diff(row['new-text'], row['text_from_response']), axis=1)

# Print the visual diffs in Colab
for index, row in incorrect_df.iterrows():
    print(f"Row {row.metadata_article_name}:")
    display(HTML(row['visual_diff_html']))

@dvsrepo, do you still feel this should be added to the utils

@sdiazlor might not be relevant


Add "Copy link to topic" to three-dot topic menu

It is possible to get a link to a topic by right-clicking the topic name and selecting "Copy link". However, this is unintuitive and difficult to discover.
We should add a "Copy link to topic" option to the three-dot topic menu in the left sidebar. It should appear just above the dividing line in the menu, or as the last option for someone who does not have permissions to rename topics:

We should use the same chain-link icon that we use for "Copy link to message" in the three-dot message menu.

@zulipbot claim


canvas.getDataUrl() is not a function. So can't extract base64 encoded string.

Tested on v3.0.0-rc.3 with latest jquery.
Let's say I want to get the base64 encoded version of the cropped image. I need to use this method rather than the canvas.toBlob() approach, due to lack of IE9 compatibility for toBlob().
I first do the following:
var canvas = $("#cropper-image").cropper("getCroppedCanvas");
console.log(canvas);

Which produces (as expected):
<canvas width="319" height="319">

Now I attempt to convert to base64 using the following:
var data =  canvas.toDataUrl("image/jpeg");
console.log(data);

An error is thrown:
(index):60 Uncaught TypeError: canvas.toDataUrl is not a function
    at HTMLAnchorElement.<anonymous> ((index):60)
    at HTMLAnchorElement.dispatch (jquery-3.2.1.min.js:3)
    at HTMLAnchorElement.q.handle (jquery-3.2.1.min.js:3)

Is this a library bug, or am I doing something wrong?
 Should have called getDataURL(), not getDataUrl(). Doh!


feat: changed GitHub runner to dedicate agent

Description
Changed Pull Request Action to use dedicated host to alleviate capacity issues.
Context

Type of changes

[ ] Refactoring (non-breaking change)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I am familiar with the contributing guidelines
[x] I have followed the code style of the project
[ ] I have added tests to cover my changes
[ ] I have updated the documentation accordingly
[ ] This PR is a result of pair or mob programming

Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

[x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

I've cancelled these workflows as the dedicated runner is failing to start the job - we will need to revisit the configuration before running this branch again.

Different approach taken in the end.


Remove ComponentsError

Objective
ComponentsError is unused and should be removed.
Fixes #3707
Solution
Remove ComponentsError.

bors r+


InstanceOfPatternMatch removes try-with-resource variable

Given the code
   if (object instanceof JarArtifact) {
      try (JarArtifact a = (JarArtifact) object) {

a rewrite using InstanceOfPatternMatch results in
    if (object instanceof JarArtifact a) {
      try () {

A fix could be to simply remove the parenthesis
    if (object instanceof JarArtifact a) {
      try {

but that may leave the object unclosed, so it should probably be left alone.

Thanks for the report! That would be a bug indeed; we should not make that change when the assignment is in a try-with-resources-try-block. Is this something you'd want to help fix? Even a draft PR with just a unit test added would already help.

I forget in which Java version this was, but possibly 9, the syntax allows for an expression in try-with-resources and doesn't mandate declaring a new variable. So with an appropriate language version we can leverage that.

Yes 9 https://bugs.openjdk.org/browse/JDK-7196163

@timtebeek I'll have a go at it. How to detect Java source version?

Awesome, thanks for the offer to help! We determine the Java version when we parse the project, and store that in a marker called JavaVersion. A common pattern is to define a Precondition through UsesJavaVersion, to limit when a recipe should apply.
https://github.com/openrewrite/rewrite/blob/03c458404073082275a752063887c188d213afbe/rewrite-java/src/main/java/org/openrewrite/java/search/UsesJavaVersion.java#L30
In rare cases we one can also read the marker directly, but use that only when preconditions aren't an option.

In this particular case we probably don't need anything in addition, as instanceof pattern variables were added in Java 11. So that precondition is already a given.


Config map/Secret passing null instead of All for sourcekey in wrkld

Rancher versions: 2.0 master 4/17
Steps to Reproduce:

Create a config map
Create a workload and add config map
For Key, leave as All
Launch

Results:  Posting null instead of all.

hi @tfiduccia , it will use all keys if UI passes null for sourceKey field to backend.

Version - v2.0.0-beta4-rc4
This is still not fixed

Version - 2.0 master 4/26
Verified fixed


feat: add smoke testing

Add a terraform script and an example js function.
The function is pushed to aws with the following layers:

apm js agent
locally built lambda extension

Log level and aws region can be configured using variables.
Closes https://github.com/elastic/apm-aws-lambda/issues/217

First iteration, ready for review, any feedback and tip on how to integrate this in CI is really welcomed

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-08-29T21:03:46.687+0000

Duration: 7 min 47 sec

Steps errors
Expand to view the steps failures

make build

Took 0 min 5 sec . View more details here
Description: make build

make build

Took 0 min 2 sec . View more details here
Description: make build

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

In standup I mentioned that I think we should use an ephemeral deployment for this. Perhaps for that we can reuse some of the Terraform modules defined in the apm-server repo, like this:
module "ec_deployment" {
source = "github.com/elastic/apm-server//testing/infra/terraform/modules/ec_deployment?depth=1"
deployment_name_prefix = "apm-aws-lambda"
integrations_server = true
apm_server_expvar = false
apm_server_pprof = false
}
We could then compose that and the module you have defined to orchestrate the creation of the ESS deployment and Lambda. After provisioning we would run a script that sends requests to the Lambda URL, and then poll Elasticsearch for results.

Could you clarify this ? Looking at the module in the apm-server repository I don't think we will end up using much of the available inputs. Is there a specific feature we're planning to use ?

Could you clarify this ? Looking at the module in the apm-server repository I don't think we will end up using much of the available inputs. Is there a specific feature we're planning to use ?

My initial thought was also to use the ec provider directly, which I assume is what you're thinking here. The main thing we would get from using ec_deployment from the apm-server repo is extraction of the generated secret token from the APM integration policy.

I've been intending to propose that we take this approach for the agents too, and stop using apm-integration-testing. CC @felixbarny @cachedout

This topic has come up a few times lately.
@axw How would you like to proceed in terms of making a decision on a path forward?

@cachedout I've just created a proposal (in a private repo for reasons, but the gist is the same as what I've described above), I'll ping you on it.

Ok, I added the script to verify the traces are in Elasticsearch, I think this is ready for another review


About build my own dataset

✅ Code of conduct checklist

[X] 🌱 I am using the latest version of the code.
[X] 📙 I thoroughly went through the README, but could not find the feature I need there.
[X] 📘 I thoroughly went through the tutorial slides, notebook, and video, but could not find the feature I need there.
[X] 📗 I thoroughly went through the documentation, but could not find the feature I need there.
[X] 📜 I went through the docstrings and comments in the source code parts relevant to my problem, but could not find the feature I need there.
[X] 👩🔧 I searched for similar issues, but could not find the feature I need there.
[X] ⭐ Since I am showing interest in the project, I took the time to give the repo a ⭐ to show support. Please do, it means a lot to us !

🚀 The feature, motivation and pitch
I have some point cloud data obtained by drones through images and 3D reconstruction (not collected by LiDAR), with a format of xyzrgb. I would like to train this data to segment buildings, vegetation, roads, etc. The scene is similar to the DALES dataset, but the data format is more similar to S3DIS. I plan to refer to S3DIS to build my own dataset. Do I need to modify some hyperparameters? I hope you can give me some suggestions. Thank you.
🔀 Alternatives
I tried eclair-dataset, However, there are still some issues to be addressed.
📚 Additional context
No response

The scene is similar to the DALES dataset, but the data format is more similar to S3DIS. I plan to refer to S3DIS to build my own dataset.

See the datasets docs and the docstring of BaseDataset for how to create your own dataset class. Note that S3DIS has a very special raw file structure and, at preprocessing time, we aggregate all the S3DIS rooms into a single big cloud for each building area. DALES, on the other hand, has a more straightforward raw file structure, but its raw clouds are too large to be processed at once on, so we tile them at preprocessing time. These mechanisms may or may not be what you need, but be aware of them.

Do I need to modify some hyperparameters? I hope you can give me some suggestions.

Unless you have the same classes, same sensor, and same resolution at one of our already-existing datasets, you will likely need to adjust some of the preprocessing parameters to suit your need. I have already provided many resources to help users do so on their own data. Please see the README, docs, notebooks, and the video tutorial I gave.
Due to the large number of requests I receive, I unfortunately do not have the bandwidth to provide free, individual support for implementing and parameterizing customized user datasets. I did strive, however, to provide very detailed notebooks, demo tutorial, and documented code to do so.


Drastically reduce the amount of re-renders while using Inequality

State was being set even though no actual change was present. Odd that React wouldn't detect that, but hey.

I think React does shallow equivalence checking, and so a new object won't match even though it's equal in value. I thought LGTM might object to the direct state access, but it didn't, so I merged it!


[BUG] - can not move the robot

Description
I imported the urdf file of kr60 from another repositoryI. And I set the rsi as tutorial in the wiki.
Then, I executed the following commands to connect:
ros2 launch kuka_kss_rsi_driver startup_with_rviz.launch.py client_ip:=<IP_ADDRESS>
ros2 lifecycle set robot_manager configure
ros2 lifecycle set robot_manager activate
After that, I can successfully see the real-time status of the robot in rviz, and I can see the joint position by ros2 topic echo /joint_states in real time.
However, when i want to move the robot by ros2 launch iiqka_moveit_example launch_trajectory_publisher.launch, the robot doesn't move.
The question is as the wiki say, "On successful activation the brakes of the robot will be released and external control is started.", but i can't see anything to know about whether i have activate successfully include the brake and external control.
But i can get the status on ROS.
KUKA robot OS
KSS
KUKA robot OS version
KSS8.6
KUKA external interface version
RSI4.0
Affected robot model(s)
KR60
Version or commit hash of the driver
No response
Setup
I didn't modify any file, except the robot descriptions for kr60

Reproduction steps
1.install by https://github.com/kroshu/kuka_drivers#installation
2.copy mesh file from https://github.com/simonschmeisser/kuka_experimental/tree/hydro-devel/kuka_kr60_support/meshes/kr60ha
3.copy kr6_r700_sixx.urdf.xacro as a template for kr60, and modify the parameters according to https://github.com/simonschmeisser/kuka_experimental/tree/hydro-devel/kuka_kr60_support/urdf
4.run:
ros2 launch kuka_kss_rsi_driver startup_with_rviz.launch.py client_ip:=<IP_ADDRESS>
ros2 lifecycle set robot_manager configure
ros2 lifecycle set robot_manager activate
5.run ros_rsi.src on the teach pad
6.run "ros2 launch iiqka_moveit_example launch_trajectory_publisher.launch"

Logs
The log after run "ros2 launch kuka_kss_rsi_driver startup_with_rviz.launch.py client_ip:=<IP_ADDRESS>":
[INFO] [launch]: All log files can be found below /home/liu/.ros/log/2024-12-06-16-01-05-327109-liu-virtual-machine-112454
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [control_node-1]: process started with pid [112467]
[INFO] [robot_manager_node-2]: process started with pid [112469]
[INFO] [robot_state_publisher-3]: process started with pid [112471]
[INFO] [spawner-4]: process started with pid [112473]
[INFO] [spawner-5]: process started with pid [112475]
[INFO] [rviz2-6]: process started with pid [112477]
[robot_state_publisher-3] [INFO] [1733472065.802799466] [robot_state_publisher]: got segment base
[robot_state_publisher-3] [INFO] [1733472065.803017627] [robot_state_publisher]: got segment base_link
[robot_state_publisher-3] [INFO] [1733472065.803027125] [robot_state_publisher]: got segment flange
[robot_state_publisher-3] [INFO] [1733472065.803031954] [robot_state_publisher]: got segment link_1
[robot_state_publisher-3] [INFO] [1733472065.803036352] [robot_state_publisher]: got segment link_2
[robot_state_publisher-3] [INFO] [1733472065.803040901] [robot_state_publisher]: got segment link_3
[robot_state_publisher-3] [INFO] [1733472065.803045329] [robot_state_publisher]: got segment link_4
[robot_state_publisher-3] [INFO] [1733472065.803049767] [robot_state_publisher]: got segment link_5
[robot_state_publisher-3] [INFO] [1733472065.803054336] [robot_state_publisher]: got segment link_6
[robot_state_publisher-3] [INFO] [1733472065.803058694] [robot_state_publisher]: got segment tool0
[robot_state_publisher-3] [INFO] [1733472065.803063093] [robot_state_publisher]: got segment world
[rviz2-6] Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
[control_node-1] [WARN] [1733472065.829108329] [controller_manager]: [Deprecated] Passing the robot description parameter directly to the control_manager node is deprecated. Use '~/robot_description' topic from 'robot_state_publisher' instead.
[control_node-1] [INFO] [1733472065.829595967] [resource_manager]: Loading hardware 'kr60'
[control_node-1] [INFO] [1733472065.830651836] [resource_manager]: Initialize hardware 'kr60'
[control_node-1] [INFO] [1733472065.830898310] [KukaRSIHardwareInterface]: IP of client machine: <IP_ADDRESS>:59152
[control_node-1] [INFO] [1733472065.830912456] [resource_manager]: Successful initialization of hardware 'kr60'
[control_node-1] [INFO] [1733472065.831029647] [controller_manager]: Setting component 'kr60' to 'unconfigured' state.
[control_node-1] [ERROR] [1733472065.837852346] [controller_manager]: setscheduler error
[control_node-1] [ERROR] [1733472065.838401200] [controller_manager]: Inappropriate ioctl for device
[control_node-1] [WARN] [1733472065.838416759] [controller_manager]: You can use the driver but scheduler priority was not set
[control_node-1] [INFO] [1733472066.173008403] [controller_manager]: Loading controller 'joint_trajectory_controller'
[control_node-1] [WARN] [1733472066.197555693] [joint_trajectory_controller]: [Deprecated]: "allow_nonzero_velocity_at_trajectory_end" is set to true. The default behavior will change to false.
[control_node-1] [INFO] [1733472066.204516312] [controller_manager]: Loading controller 'joint_state_broadcaster'
[spawner-5] [INFO] [1733472066.232042788] [spawner_joint_trajectory_controller]: Loaded joint_trajectory_controller
[spawner-4] [INFO] [1733472066.250684401] [spawner_joint_state_broadcaster]: Loaded joint_state_broadcaster
[control_node-1] [INFO] [1733472066.253716987] [controller_manager]: Configuring controller 'joint_state_broadcaster'
[control_node-1] [INFO] [1733472066.253857682] [joint_state_broadcaster]: 'joints' or 'interfaces' parameter is empty. All available state interfaces will be published
[control_node-1] [INFO] [1733472066.318889782] [controller_manager]: Configuring controller 'joint_trajectory_controller'
[control_node-1] [INFO] [1733472066.319119785] [joint_trajectory_controller]: No specific joint names are used for command interfaces. Using 'joints' parameter.
[control_node-1] [INFO] [1733472066.319139813] [joint_trajectory_controller]: Command interfaces are [position] and state interfaces are [position].
[control_node-1] [INFO] [1733472066.319157296] [joint_trajectory_controller]: Using 'splines' interpolation method.
[control_node-1] [INFO] [1733472066.320942077] [joint_trajectory_controller]: Controller state will be published at 50.00 Hz.
[control_node-1] [INFO] [1733472066.324113099] [joint_trajectory_controller]: Action status changes will be monitored at 20.00 Hz.
[INFO] [spawner-4]: process has finished cleanly [pid 112473]
[INFO] [spawner-5]: process has finished cleanly [pid 112475]
[control_node-1] [INFO] [1733472075.906756278] [resource_manager]: 'configure' hardware 'kr60'
[control_node-1] [INFO] [1733472075.906792245] [resource_manager]: Successful 'configure' of hardware 'kr60'
[control_node-1] [INFO] [1733472078.891386886] [resource_manager]: 'activate' hardware 'kr60'
[control_node-1] [INFO] [1733472078.891452199] [UDPServer]: <IP_ADDRESS>: 59152
[control_node-1] [INFO] [1733472078.891524646] [KukaRSIHardwareInterface]: Connecting to robot . . .
[control_node-1] [INFO] [1733472082.145605808] [KukaRSIHardwareInterface]: Got data from robot
[control_node-1] [INFO] [1733472082.146177986] [KukaRSIHardwareInterface]: System Successfully started!
[control_node-1] [INFO] [1733472082.146204035] [resource_manager]: Successful 'activate' of hardware 'kr60'
[control_node-1] [INFO] [1733472082.147018644] [controller_manager]: Switch controller timeout is set to 0, using default 1s!
[robot_manager_node-2] [INFO] [1733472082.150326699] [robot_manager]: Successfully activated controllers

If activation of the hardware is successful, controlling the robot should be possible.
You can try the following to verify where the issue lies:

ros2 run rqt_joint_trajectory_controller rqt_joint_trajectory_controller, set the velocity rate to low and try to move a joint -> motion can be quite jerky
try the same setup with use_fake_hardware:= true for the launch file

If robot moves in the first case, something is misconfigured for the launch_trajectory file, if it moves in the mock setup, than the issue might be with the hardware setup

Thank you for your reply. Unfortunately, ros2 run rqt_joint_trajectory_controller rqt_joint_trajectory_controller still cannot control the robot to move, but use_fake_hardware:= true can.
Can you tell me some key settings about kuka robot? I want to confirm where the problem with my hardware settings is.
Below are the details of my robot network configuration. Can you help me check it?

and ros_rsi.src. Are the four states above correct? "S", "I", "R", "T1"?

the IP configuration seems valid for me and it seems you continually get packages from the robot controller, otherwise the client would raise a timeout.
Looking at the smartHMI I can see 2 things:

robot interpreter is red, in this case the robot cannot move. Are you continually pressing the enabling switch? (In T1 that is necessary, but you can also try it out in AUT)
there are 4 status messages, can you check whether they can be connected to the issue?

Thank you for your reply. I have found the problem. There is nothing wrong with my settings and program. The problem is that when executing ros_rsi.src in the teach pad, the play button should be held down always at the ros_movecorr() function. But I didn't do that.

yes, I forgot that, play button is also necessary in T1, but not in AUT :)


[BUG] - Bottom of Modal gets cut off on IOS Safari if the tabbar is not already showing

NextUI Version
v2.1.0
Describe the bug
If you open a modal in safari on ios and the tabbar is not showing the modal will be cut off slightly at the bottom.
Your Example Website or App
https://nextui.org/docs/components/modal
Steps to Reproduce the Bug or Issue

go to https://nextui.org/docs/components/modal on ios safari
scroll down so tabbar dissapears
click 'open modal'
bottom of modal is cut off

Expected behavior
Bottom of modal to not be cut off. For the modal to rise up to account for the tabbar
Screenshots or Videos
No response
Operating System Version
ios
Browser
Safari

Hi, @indie-ridge-dev!
What's your iPhone device and iOS version?
I've recorded the video and everything looks fine.
https://github.com/nextui-org/nextui/assets/19293733/1018428b-1aa7-42f1-be0e-f898010833a3
device name: iPhone12
iOS version: 16.6.1

Hey, it's an iPhone 11 Pro Max running iOS 16.1.1
Here's what I'm seeing
https://github.com/nextui-org/nextui/assets/80777374/5251812c-1b18-49e1-bf3d-046616fcd3cc

This image I took of the actual screen shows the issue


Improve index

Just checking I understand: the idea is to store None as 0 and Some(n) as !n assuming n is not usize::MAX ?

Yes, I guess I'll add a comment.

But storing None as 0 is don by the rust compiler itself.


Add in memory cache to SWS

Is your feature request related to a problem? Please describe.
SWS does not have in memory caching for static assets.
Describe the solution you'd like
On first request files will be taken from disk and cached for a given period in memory, all other subsequent will get files  from memory cache.
This can be especially effective for scenarios where one have remote volumes bindings, like CSI
I think this feature shall be enabled with help of Environment variable, which will specify Time to live in seconds like IN_MEMORY_CACHE_TTL=3600
A possible solution could be to implement in memory caching with help of freqfs?

FYI there is already PoC in progress on https://github.com/static-web-server/static-web-server/pull/328 using the SIEVE eviction algorithm.

This is done by https://github.com/static-web-server/static-web-server/pull/328 and It will be released on the next v2.33.0.
Note that this is an still experimental feature as we would like to get user feedback, so your help here is appreciated.
For the feature details, please check the PR description.


Use accurate token counts

The total token count is now based upon an identical format conversation sent to the LLM during response generation.
This results in counts that should be accurate, and prevent token limit errors entirely.
Closes BLO-1724

it is much closer now, but I still see some weird discrepancy


⚠ Processors has degraded performance

In 3199e51, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 52 ms

Resolved: Processors performance has improved in 71b5a00.


Visible error for multifactor options with local auth

Description of the problem including expected versus actual behavior:
When local auth is disabled if you go to the security tab in account settings there will be a 404 page under the multifactor heading. I'm assuming this is because the routes aren't added since the auth method is disabled. It's probably fine for multifactor to be tied directly to local auth and let other providers worry about how they'll do additional factors but it probably shouldn't error out.
Steps to reproduce:
Please include a minimal but complete recreation of the problem,
including (e.g.) index creation, mappings, settings, query etc.  The easier
you make for us to reproduce it, the more likely that somebody will take the
time to look at it.

Disable local authentication (and use just Okta)
Start server
Go to security tab in account settings (http://localhost:8080/account/security)

I can't reproduce this as indicated. If the server only has okta, then no local auth components will render.
I can get a similar error by including both ashirt and okta as valid authentication schemes, and then having a user with only okta auth, plus some additional steps below. We can probably just capture these errors and render a not available message.
steps to generate an error here:

login with a user that has local auth (alternate: link a local auth with an okta-only user)
go to account settings/authentication methods
unlink local auth
go to the account settings/security page

A refresh "fixes" this -- as noted above, only the components for the current set of auth schemes load. This only changes on refresh, so components will be out of sync until the user hits the refresh page button.

On the backend, there's not a lot we can do without leaking user details. On the frontend, I will be putting up a PR that adds a friendlier error message in situations where the frontend thinks it should advertise multifactor auth, but for whatever reason, it cannot. In these cases, this error message will be displayed:
Multifactor Authentication is not available for this account. Please ensure you have linked ASHIRT local authentication. (given that this is only a local auth feature this should be a pretty safe message)

The reason that it renders is that the user has a local auth scheme that was setup before the switch to only okta. If you add a local auth scheme in then change the auth schemes to only allow okta, the local auth scheme will still exist in the database and the backend will still return it when the /user endpoint is requested so it chooses to render that component.

There are 2 PRs that address this issue.
PR #149 filters users that have auth scheme linked that are no longer supported. This should prevent the above situation from happening in those situatiions.
PR #148 provides a front end solution. Rather than displaying an error icon and vague error message, we instead display a simple message on error that indicates (As noted in a previous comment) that the feature is simply not available for the user.


Bound checking errors in small features

These tests fail due to discrepancies wrt. bound checking:
language/generic/generic_function_type_argument_test
co19/Language/Generics/Superbounded_types/typedef3_A01_t06/01
co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02
co19/Language/Generics/typedef_A06_t04
co19/Language/Generics/typedef_A06_t12
co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t03
co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t04
co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l4_t01
co19/LanguageFeatures/regression/34560_t02

Sorry, @stefantsov I'm not sure I totally parsed which of your examples were problems with tests and which were CFE issues.

@leafpetersen I think all four are issues with tests, and in the first one in the list a compile-time error is expected in the test, but I believe that it's not an error. Sorry for not being clear.

cc @eernstg

Also, I think the test co19/Language/Generics/typedef_A06_t04 should be corrected too. The right-hand side of the typedef there is a regular-bounded type (it's not even an application of a generic type to type arguments), and all parts of it are well-bounded.

Taking a look, I can't verify two of the issues, but I agree on the remaining two:

Agree: co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02 is not a compile-time error, B<A<A<A<B<A<dynamic>>>>>> is super-bounded.
Can't verify the problem with co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t03, it has no failures according to https://dart-ci.firebaseapp.com/current_results/#/filter=co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t03&showAll
Agree: co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l4_t01 does look like it's just the location associated with the error message that differs for the CFE.
Can't verify the problem with co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l4_t01.

So maybe the 2nd and 4th issue have been fixed in a roll already?

I filed a co19 issue for the three tests that we agree should be updated: https://github.com/dart-lang/co19/issues/1029.

Some of the remaining test failures are being worked on here: https://dart-review.googlesource.com/c/sdk/+/192146.

About co19/Language/Generics/typedef_A06_t04: The front end does not report the error about the raw bound, but this is covered by https://github.com/dart-lang/sdk/issues/42435.

I have a status update for the remaining tests that are currently failing if run locally at the HEAD fo Dart SDK:

co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02 — still marked as compile-time error, but shouldn't be; the test should be updated;
co19/Language/Generics/typedef_A06_t04 — the fix is in work at https://dart-review.googlesource.com/c/sdk/+/193662;
co19/Language/Generics/typedef_A06_t12 — the fix is in work at https://dart-review.googlesource.com/c/sdk/+/193662;
co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t04 — still a failure because of the error locations; the locations should be updated in the test.

So, after https://dart-review.googlesource.com/c/sdk/+/193662 lands, the issue for the CFE may be closed.

https://dart-review.googlesource.com/c/sdk/+/193662 landed. I'm closing the issue. Please reopen if needed.


Enhancement/csv import cylinder

added function to create cylinders using geometry data from the csv file.

Maybe the method create_geometry_from_csv can be moved to Modeler3D since it can be used by all the 3D Modeler tools

I agree.


Generate docs automatically for the python modules

Lets add some docs systems such as read the docs to generate docs automatically for the python modules.

Do you want to upload the document from a local or add the URL to the online site?

Successfully implemented automated doc generation for the Python modules with Read the Docs. Documentation is now live and will update with repo changes.


Remove usage of deprecated startActivityForResult

Need to find out what the new method is, and replace the deprecated calls.

Details on the new methods:
https://developer.android.com/training/basics/intents/result


Malcat capa integration detects capabilities missed by standalone capa

Description
I recently analyzed some Cobalt Strike shellcode (VT Link)
in Malcat, and its capa integration correctly identified several capabilities. However, running the standalone capa.exe with the same shellcode sample did not detect any capabilities.
Steps to Reproduce

I loaded the shellcode into Malcat (I understand you may not have access to this product).
I ran Malcat's capa integration to analyze the shellcode. This produced the following output:

I ran the standalone capa.exe command: capa.exe -r C:\Tools\capa-rules -f sc64 scwow.bin
**Note: ** I used capa.exe version 7.40 and the latest rules from GitHub.

Expected behavior:
The standalone capa.exe should identify the same capabilities as Malcat’s capa integration.
Actual behavior:
The standalone capa.exe returned no capabilities found.
Versions
Malcat: Appears to use capa 4.0.1.
Standalone capa.exe: Version 7.40. I also downloaded and tested capa.exe version 4.0.1 to see if the issue was specific to newer versions, but it also identified no capabilities.
Capa Rules: Cross-checked rules like reference-http-user-agent-string.yml and resolve-function-by-parsing-pe-exports.yml between Malcat and the up-to-date versions on GitHub, with no identified significant differences.
All of this testing was done on a Windows 10 Enterprise VM.
If any additional screenshots or details are needed, please let me know. Thank you!

thanks for the detailed report @as0ni!
this sort of issue is usually due to malcat recovering more code than our built in framework can. especially with shellcode, where calls are often indirect, vivisect often has trouble finding all the functions. then capa isn't able to find the capabilities you see.
i can take a look at the sample you provided and confirm this behavior. there might be some things we can do to more aggressively recover code.

Thanks for the quick feedback, @williballenthin! That makes a lot of sense. I’ve observed similar behavior in Ghidra; initially, capa finds no capabilities in this shellcode. However, once I manually define a function, capa identifies access PEB ldr_data. It still doesn’t pick up the additional two rules that Malcat does, but as you mentioned, this likely stems from differences in how each framework recovers code. Appreciate you looking into this!

Please reopen if you still have questions or think we need to track further improvements.