Support external dependencies (experimental PEP 725 support?)

First off thanks to everyone working on fromager. I'm happy to provide a PR but wanted to file an issue for discussion first.
It would be helpful for my use case, and I hope for others,  if there was a standard mechanism in fromager for external dependencies. Currently fromager offers a hooks mechanism for customization
Problem
As per the example for pydantic-core many fromager failures result from missing external dependencies. Bootstrapping fromager with fromager for example the dependency tree needs rust, libffi-dev in the build environment
PEP-725 currently proposes a standard to use [external] metadata for Python build and runtime dependencies on non-python packages (eg libffi-dev) using PURL (package urls).
Examples of external metadata can be found in https://github.com/rgommers/external-deps-build, eg for cryptography
[external]
build-requires = [
  "virtual:compiler/c",
  "virtual:compiler/rust",
  "pkg:generic/pkg-config",
]
host-requires = [
  "pkg:generic/openssl",
  "pkg:generic/libffi",
]

Proposal

Add hooks for  get_external_build_dependencies and get_external_host_dependencies  (and handle optional-dependencies) with no-op defaults (given PEP 725 is just proposed). This would allow fromager users and distros to add a hook to install dependencies using the system package manager when running fromager in a container
Add support to configure write PEP 725 [external] table via the project_override  in packagesettings.py which already modify the pyproject.toml.  This could also be done via a new config hook slot that can customize project override if you don't wish for fromager to be PEP 725 aware at this time.

Hi, @pnasrat, thanks for starting this discussion!

Proposal

Add hooks for  get_external_build_dependencies and get_external_host_dependencies  (and handle optional-dependencies) with no-op defaults (given PEP 725 is just proposed). This would allow fromager users and distros to add a hook to install dependencies using the system package manager when running fromager in a container

When PEP-725 is approved, it definitely makes sense to support it in fromager.
Today we use pyproject_hooks for probing most of the dependencies, so I think we'd want to see support added there, too, rather than building our own version of that for this new type of dependency. Unless maybe there's no need because we could just read them from the pyproject.toml, like we do for the build backend?
And then, yes, overrides in fromager would make sense for projects where the standard hooks don't work and someone providing build overrides could add their own customizations.

Add support to configure write PEP 725 [external] table via the project_override  in packagesettings.py which already modify the pyproject.toml.  This could also be done via a new config hook slot that can customize project override if you don't wish for fromager to be PEP 725 aware at this time.

This part is a little less clear. I can see the utility of having the external dependency list, but I would expect that to mostly be done in the original source package build instructions, even if aspects of the build change the values that need to appear there. Maybe I'm missing something, though. Why does fromager need to update that list (or provide a hook for a build plugin to)?

That makes sense, I'll keep an eye on the progress of the PEP, initially suggesting the hooks was to allow for me to try to get builds working with pulling in external deps in the interim. I'll take a closer look at pyproject_hooks also (it's been a while since I've worked deeply in python packaging)
The second part is more as I assume it will take some time for upstreams to add their external deps, where as a package/distribution already has that info (or as from the external deps research metadata) .
I also see it useful for cases for from source builds where eg cmake might be being removed from the standard requires to prefer an external (distro/os) installed cmake (that could be installed in the build env).
For now I can handle the external dependencies outside of fromager for building from source using fromager  as they aren't in any upstream projects currently.

I have created elfdeps and integrated it into Fromager. The tool extracts shared library dependencies from ELF files and emits RPM-compatible requirements and provides. The output can be used on Fedora/CentOS/RHEL-based systems, because RPM build system injects metadata into the RPM packages. I don't know if Alpine, Debian, Gentoo, and other distros have the same metadata in their packages.
The same approach could be used for macOS DWARF and Windows PE files. Contributions welcome! :)
I have a PoC container based on CentOS 9 Stream that contains Fromager, build tools, and dependencies for most Python packages. I'll push the container next week.

What are the security implications of having fromager have permission to install build requirements during the build process?


HTML Comments are not hidden

Checking https://staging.waku.org/
HTML Comments <!-- --> are not hidden (they usually are when content is generated from MarkDown).

related https://gist.github.com/jonikarppinen/47dc8c1d7ab7e911f4c9


programmatically create grid of WpfPlot controls #4

Guys, not sure how to contact you to say thanks, so "thanks !". Can you advise on a good book or resource for WPF programming covering "code behind" and binding and so on?

response in #311


Limit the listed dependencies to those that are actually reachable

The data source underlying rust-license-tool lists all entries in the dependency tree, even if they can't be reached under any actual combination of top-level feature flags. While we can't reasonably expand every possible combination of the top-level feature flags (Vector has 228 which leads to about 10^440 unique combinations), we should be able to reduce that dependency tree by producing sets of possible feature flags for each crate and thereby eliminate sub-dependencies that can't be turned on. This would reduce the size of the generated licenses file, producing a more accurate reflection of what components are actually used.

Is https://github.com/rust-lang/cargo/issues/10801 related to this?

Yes, that's the one. I was looking for that link when I wrote the above but couldn't find it. There may be opportunities for us to solve this without support from that issue, however.


Dependence on xcontour package

I'm opening a new issue here to continue the discussion on the issue of the xcontour dependence that we started here.

The dependence of xcontour is a bit complicated. It is another package I've written here. So the example of reference state, which is newly added, depends on xcontour to prepare the forcing (actually preparing the forcing data is not the core part of xinvert). This is not necessary for other examples. So far, I don't have any plan to get xcontour released as a conda package, so it is not possible to add this to conda dependency. Do you have any suggestion? I really like this example to remain in the problem list.

Is there a way to precompute M(Q) and C(Q) with xcontour and in the https://xinvert.readthedocs.io/en/latest/notebooks/05_reference_SWM.html example, and just load these states from netcdf if xcontour is not available? You could  then adapt the notebook as follows:
try:
    import xcontour
    # do xcontour computation in this notebook, as you do now
except ImportError:
    ds = xr.open_dataset(your_precomputed_dataset)

This is part of the review process at https://github.com/openjournals/joss-reviews/issues/5510.

Oh yes, that's a nice workaround.  I should do this follow your suggestion.

It is fixed now at here

Great! I'm closing this issue.


_ can only match a value of type any

Refer https://groups.google.com/d/msg/ballerina-dev/_f--VkihvsY/OlOQbTzvBwAJ for more details.

Fixed in #14543


vscode error: Could not register service workers

Getting the below error while trying to view the extensions. Screenshot also has been attached.
Error loading webview: Error: Could not register service workers: InvalidStateError: Failed to register a ServiceWorker: The document is in an invalid state..

Issue solved. Thank you...

I'm getting the same error. Can you comment on what the solution was?


[Deepseek] --yes | Ask for creation of new file

Issue
I really enjoy Aider AI. Thank you very much!
I'm using DeepSeek with the --yes option. The model tried to ask for the file (which doesn't exist), but after that, the conversation stopped. I'm not sure whether the bug is in the --yes option or if the model doesn't make a good request.

Version and model info
Aider v0.55.0
Model: deepseek/deepseek-coder with diff edit format, prompt cache, infinite output
Git repo: .git with 46 files
Repo-map: using 1024 tokens, auto refresh

See this tip for creating new files -> https://aider.chat/docs/usage/tips.html#creating-new-files

Thanks for trying aider and filing this issue.
Unfortunately Deepseek isn't always smart enough to try and create a new file.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open. Or feel free to file a new issue any time.

@paul-gauthier I checked but is there any option to disable crawling suggestion ? I'm using --yes

Thank you very for your support !

No, if you've used --yes that will answer yes to everything.


mysql-client APT package installation  attempt causes Docker Compose Build to Fail

When running "docker-compose build" command, it fails when attempting to install mysql-client because the APT package manager does not recognize "mysql-client" as an actual package name.
To fix this, I had to go into the Dockerfile and change "mysql-client" to "default-mysql-client". From there I was able to successfully build the Docker image.
Would recommend changing this in the Docker files.

@theappsecguy This has now been fixed on both the master and dev branches. Thank you for the concern.


Behavior issues when decoupleChildFromParent is true

There are two big issues when I choose to enable the decoupleChildFromParent option:

When choosing a parent, the output eventemitter selectedChange invoked with an empty parameter.
After choosing the checkbox of the parent, the "options selected" menu doesn't update.

Please fix it.


[Wave Collect] [Ideal Nav] Refactor goBack to simplify the navigation logic

Issue
The logic and responsibility of the goBack function grew too much over time.
Solution
Split the goBack function into different functions to ensure it is easy to use and debug in the future
Background
Several regressions occurred from the Ideal Navigation PR, particularly concerning the back navigation behavior. The complexity of the goBack function may be responsible for some of these regressions. @adamgrzybowski has suggested a refactor of this function to prevent similar issues in the future.

@adamgrzybowski please comment on this issue so that I can assign you to it. 🙇

👋

this is a refactoring issue that is complicated. Adam is going to work on it when they have time.

This should minimally be weekly priority though, right?

there is a new project dashboard?

Yep, #wave-collect is where the party is at!

@adamgrzybowski how is this one looking? What are the next steps?

@mountiny I need to fix tests for this PR. After that I can focus on the goBack if this is the most urgent thing.
It would be great to have @WojtekBoman around for some brainstorming though. The go back is used in a lot of places and we don't want to miss any use cases. He will be back on Monday (18.03)
I was asked to help with this issue https://github.com/Expensify/App/issues/36476 so maybe I could work on it in the meantime.

Moving back to Weekly, how are we going with this one?

@adamgrzybowski, let me know your availability and when you're planning to work on this refactor. Depending on when you're planning to work on this, we can adjust the priority back to weekly 😄

@hayata-suenaga I think we will take care of that after preparing section for the search tab in the design docs

Melvin -> @hayata-suenaga I think we will take care of that after preparing section for the search tab in the design docs

Hi! I just got back from vacation, so I'll take a look around and let you know.

welcome back! 😄

Hi @adamgrzybowski is this one going to be worked on by any chance? Juat wondering what the priority is. Thanks!

Got it, thanks! @trjExpensify - going off Adam's comment above: did you want to keep this one open, or can I close this issue?

The problem in the OP seems suitably vague, and we've fixed the bugs that came up during the rollout, so I'm good with closing this until we get a more concrete problem for refactoring goBack.


NAS-130812 / 25.04 / Fix core.get_jobs output

time 0:05

Time tracking failed: can't get issue ID from title 'Fix core.get_jobs output'

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130812

time 0:05


Update Marvel Heroic Roleplaying translation.json

Changes / Comments
Corrected some terminology, added translations for new dropdowns/selects, corrected a mislabeled key
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[x] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

As I mentioned in your additional pull request, it would be ok to include the changes for the translation.json, .css, and .html files within the same pull request as long as they pertain to the same character sheet. Thank you for what you do!


Plugin marks incorrect text as Spring EL

Describe the bug
This plugin marks text as a Spring EL in incorrect places.
To Reproduce
Steps to reproduce the behavior:

Open the attached project
Go to DemoApplicationTests
See the inspection error on line 14

Expected behavior
There is no inspection error. The plugin should not mark text in Java as Spring EL.
Screenshots

IntelliJ version (please complete the following information):
IntelliJ IDEA 2020.2 EAP (Ultimate Edition)
Build #IU-202.4357.23, built on May 27, 2020
IntelliJ IDEA EAP User
Expiration date: June 26, 2020
Runtime version: 11.0.7+10-b912.1 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 10.15.5
GC: G1 Young Generation, G1 Old Generation
Memory: 3072M
Cores: 8
Registry: debugger.click.disable.breakpoints=true, analyze.exceptions.on.the.fly=true, ide.browser.jcef.enabled=true, compiler.automake.allow.when.app.running=true
Non-Bundled Plugins: com.intellij.ideolog, CheckStyle-IDEA, com.chainstaysoftware.assertions2assertj, org.mapstruct.intellij, com.jetbrains.colorful.toolwindow.icons, io.protostuff.protostuff-jetbrains-plugin, org.nik.presentation-assistant, MavenRunHelper, intellij.prettierJS, flowable-bpmn-visualizer

Thanks for the quick fix


added  Java code for cocktail sort

Have you read the Contributing Guidelines on Pull Requests?
yes
Description
added  Java code for cocktail sort
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#378

@siddharth25pandey please see this


Add environment parsing support for enums.

Adds support for environment parsing of enum field names to values.

Thanks @kschwab for the new feature implementation.
I left some suggestion

please update


Added Cards/cards-5

author : Yuvraj Dagur
GitHub : https://github.com/thatfreakcoder

Thank you for your contribution 😃 . Keep contributing and leave a star if your like this repo
Happy hacking 😁


Revive special message comment

Special message is no longer invoked on special day, so this hopefully will remedy the situation.

Codecov Report

Merging #67 into master will decrease coverage by 0.11%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   82.22%   82.11%   -0.12%
==========================================
  Files          16       16
  Lines         799      805       +6
==========================================
+ Hits          657      661       +4
- Misses        142      144       +2

Impacted Files
Coverage Δ

baldrick/utils.py
94.28% <66.66%> (-2.69%)
:arrow_down:

baldrick/plugins/github_pull_requests.py
79.03% <75%> (-0.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216b47e...91d5893. Read the comment docs.

Codecov says you need tests :stuck_out_tongue:
Also, I wont merge it because I assume @astrofrog will need to redeploy astropy bot anyway.

Testing an Easter Egg defeats the purpose of Easter Egg? Also I should have really just committed directly to master but I am a nice person. 😉

a PR is safe here as only the 4 of us watching this repo, but I agree, surprises should not be added in PRs but directly :)
(also this reminds me that we are really close to special day, 😱 )

Special merge!


UITableViewCell incorrect position when scroll table embeded in a container view

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Description
When I roll the page the tableviewcell is over the view in blue. I set the SlackTextViewController in the ContainerView
Reproducible in:

[x] This is reproducible in the sample project.
SlackTextViewController version: 1.9.6
iOS version(s): 11.3
Device(s): iPhone SE Simulator

Steps to reproduce:

Set your SlackTextViewController inside of containerView
Set your main view with another color to can see tableviewcell over the main view

Expected result:
Cell scrolling inside containerview
Attachments:

e.g. Logs, screenshots, screencast, sample project, funny gif, etc.

Does the keyboard work inside the container view? Are you using an embed segue?


gx lint

It would be really nice to have a gx lint command. But i'm torn on whether it should just lint the dependency structure, or also run subtools code linters. Either way, its something i want

Had the same idea the other day :):)
gxvet tool

missing gx.dvcsimport
unused deps
imports without deps declared
deps in the tree with differing versions
deps with incorrect version in package.json
deps with 0.0.0 version
local gx and gx-go update check

unused deps

bump
https://github.com/ipfs/go-ipfs/issues/4937


feat: Option to pass kubeVersion to helm template

To be able to use helmfile template to render helm charts for cluster with other than the default Kubernetes version in helm you might need to add the --kube-version flag to helm. This adds that functionality.

Hi,
I found Datadog Chart use .Capabilities.KubeVersion.GitVersion.
https://github.com/DataDog/helm-charts/blob/de93d7c45467c2bf65a34afec0729f13341aed4f/charts/datadog/templates/_helpers.tpl#L521-L526
{{- define "enable-service-internal-traffic-policy" -}}
{{- if or (semverCompare "^1.22-0" .Capabilities.KubeVersion.GitVersion) .Values.agents.localService.forceLocalServiceEnabled -}}
true
{{- else -}}
false
{{- end -}}
{{- end -}}

If enable-service-internal-traffic-policy is true, the kind: Service resource manifest which contains internalTrafficPolicy will be generated.
internalTrafficPolicy feature can be used only on Kubernetes 1.22+.
The clusters we have are v1.19 and v1.21, so we're a little troubled.
This pull request may resolve our problem.
I would like to know the status of this.

The reason I need this feature myself is that I need to set pathType in the ingresses for prometheus. But the prometheus chart only allows setting the pathType in Kubernetes 1.19+
https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus/templates/_helpers.tpl#L200

What can I do to get this pull request merged?

@msvticket @44smkn Hey! I recently learned that --kube-version is only present in helm2's helm template. So if your chart is relying solely on Capabilities.KubeVersion to detect the correct API version for a resource, this doesn't help.
So if you're using Helm 3, you'd just list API versions available to helm template by specifying apiVersions in your helmfile.yaml.

Updated README to note the above info https://github.com/roboll/helmfile/commit/91aa0acddbacaa8c8295b9dfa95f045a39d0609b

$ helm template --help | grep kube-version
--kube-version string          Kubernetes version used for Capabilities.KubeVersion
$ helm version
version.BuildInfo{Version:"v3.6.3", GitCommit:"d506314abfb5d21419df8c7e7e68012379db2354", GitTreeState:"dirty", GoVersion:"go1.16.5"}
--kube-version was added again with helm/helm#9040

When I ran helmfile template using helm v3.7.2 and helmfile v0.143.0, I got the expected results.
I think the feature proposed in this PR is useful in helm3 as well.

@msvticket @44smkn Good to know! Thank you so much for sharing ☺


Standalone server block not parsable

server {
    # My comment here
    server_name domain.name;
    listen 443;

    location /api0 {
        proxy_set_header Host $http_host;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Scheme $scheme;
        proxy_set_header X-Forwarded-Proto $scheme;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_pass http://<IP_ADDRESS>:5000/awesome;
        proxy_redirect off;
    }
}

With your basic crossplane.Parse example in your README, this errors:
{
  "status": "failed",
  "errors": [
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 1,
      "error": "\"server\" directive is not allowed here in /tmp/configs/merged_roots.conf:1"
    },
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 3,
      "error": "\"server_name\" directive is not allowed here in /tmp/configs/merged_roots.conf:3"
    },
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 4,
      "error": "\"listen\" directive is not allowed here in /tmp/configs/merged_roots.conf:4"
    },
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 6,
      "error": "\"location\" directive is not allowed here in /tmp/configs/merged_roots.conf:6"
    },
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 7,
      "error": "\"proxy_set_header\" directive is not allowed here in /tmp/configs/merged_roots.conf:7"
    },
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 8,
      "error": "\"proxy_set_header\" directive is not allowed here in /tmp/configs/merged_roots.conf:8"
    },
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 9,
      "error": "\"proxy_set_header\" directive is not allowed here in /tmp/configs/merged_roots.conf:9"
    },
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 10,
      "error": "\"proxy_set_header\" directive is not allowed here in /tmp/configs/merged_roots.conf:10"
    },
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 11,
      "error": "\"proxy_set_header\" directive is not allowed here in /tmp/configs/merged_roots.conf:11"
    },
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 12,
      "error": "\"proxy_pass\" directive is not allowed here in /tmp/configs/merged_roots.conf:12"
    },
    {
      "file": "/tmp/configs/merged_roots.conf",
      "line": 13,
      "error": "\"proxy_redirect\" directive is not allowed here in /tmp/configs/merged_roots.conf:13"
    }
  ],
  "config": [
    {
      "file": "/tmp/configs/merged_roots.conf",
      "status": "failed",
      "errors": [
        {
          "line": 1,
          "error": "\"server\" directive is not allowed here in /tmp/configs/merged_roots.conf:1"
        },
        {
          "line": 3,
          "error": "\"server_name\" directive is not allowed here in /tmp/configs/merged_roots.conf:3"
        },
        {
          "line": 4,
          "error": "\"listen\" directive is not allowed here in /tmp/configs/merged_roots.conf:4"
        },
        {
          "line": 6,
          "error": "\"location\" directive is not allowed here in /tmp/configs/merged_roots.conf:6"
        },
        {
          "line": 7,
          "error": "\"proxy_set_header\" directive is not allowed here in /tmp/configs/merged_roots.conf:7"
        },
        {
          "line": 8,
          "error": "\"proxy_set_header\" directive is not allowed here in /tmp/configs/merged_roots.conf:8"
        },
        {
          "line": 9,
          "error": "\"proxy_set_header\" directive is not allowed here in /tmp/configs/merged_roots.conf:9"
        },
        {
          "line": 10,
          "error": "\"proxy_set_header\" directive is not allowed here in /tmp/configs/merged_roots.conf:10"
        },
        {
          "line": 11,
          "error": "\"proxy_set_header\" directive is not allowed here in /tmp/configs/merged_roots.conf:11"
        },
        {
          "line": 12,
          "error": "\"proxy_pass\" directive is not allowed here in /tmp/configs/merged_roots.conf:12"
        },
        {
          "line": 13,
          "error": "\"proxy_redirect\" directive is not allowed here in /tmp/configs/merged_roots.conf:13"
        }
      ],
      "parsed": []
    }
  ]
}

In the meantime I'll just:
crossplane.ParseOptions{SkipDirectiveContextCheck: true, SkipDirectiveArgsCheck: true}

you should make it surrounded by http{} block

@mingmingshiliyu Yes but these are included; so should not be surrounded so.

I use your case like nginx.conf
http{
    server {
        # My comment here
        server_name domain.name;
        listen 443;

        location /api0 {
            proxy_set_header Host $http_host;
            proxy_set_header X-Real-IP $remote_addr;
            proxy_set_header X-Scheme $scheme;
            proxy_set_header X-Forwarded-Proto $scheme;
            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
            proxy_pass http://<IP_ADDRESS>:5000/awesome;
            proxy_redirect off;
        }
    }
}

and parse it into json style ,it`s obviously workable.

And I`m doubt about using gonginx or go-crossplane to parse configuration,maybe not only nginx.conf in the future,Do you have any advices?

@mingmingshiliyu Sure but include is very useful, and in a dynamic environment I might want to reload nginx and include/exclude different server blocks. Being able to convert to JSON, modify the JSON, then emit the new server block is required functionality for my use-case.
And my use-case seems pretty common.

@mingmingshiliyu Sure but include is very useful, and in a dynamic environment I might want to reload nginx and include/exclude different server blocks. Being able to convert to JSON, modify the JSON, then emit the new server block is required functionality for my use-case.
And my use-case seems pretty common.

oh, it happened! agree with you

@aluttik Bump


Replace react-script with vite

Vite was chosen because of https://github.com/opencast/opencast-editor/pull/1265

Vite was chosen because:
Straightforward migration
Relatively similar set of opinions as CRA
Optimized for single page applications like ours
Popular

I didn't reimplement the dev mode with the mocks.

Was the code necessary to deploy it like that?

As the test deployments are only static files, removing the proxy should not cause any trouble.

Since #470 got merged, can you update the test comment:
https://github.com/opencast/opencast-admin-interface/blob/ddfd555a61efcbb11f0376b07724975327657446/.github/workflows/deploy-container-image.yaml#L53-L61
This should now probably be something like:
 Run test server using develop.opencast.org as backend:
 ```
 podman run --rm -it -p <IP_ADDRESS>:3000:3000 ${{ steps.meta.outputs.tags }}
 ```

 Specify a different backend like stable.opencast.org:
 ```
 podman run --rm -it -p <IP_ADDRESS>:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ${{ steps.meta.outputs.tags }}
 ```

Sorry for finding another issue :see_no_evil:
This causes the container to fail since they do not contain a browser:
❯ podman run --rm -it -p <IP_ADDRESS>:3000:3000 opencast-admin-interface:6dfe2dc

><EMAIL_ADDRESS>start
> vite

The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

  VITE v5.2.11  ready in 207 ms

  ➜  Local:   http://localhost:3000/
  ➜  Network: use --host to expose
node:events:497
      throw er; // Unhandled 'error' event
      ^

Error: spawn xdg-open ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:292:12)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn xdg-open',
  path: 'xdg-open',
  spawnargs: [ 'http://localhost:3000/' ]
}

Node.js v20.13.1

The vite server also listens to localhost only which does not work with the containers.
There may be a better way, but this will fix the issues:
diff --git a/Dockerfile b/Dockerfile
index 2782425b1f..1890183c3c 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -7,4 +7,5 @@ WORKDIR /admin-interface
 RUN npm ci

 ENV CI true
+ENV BROWSER none
 CMD [ "npm", "start" ]
diff --git a/package.json b/package.json
index 4a14ced112..c0bd48faa9 100644
--- a/package.json
+++ b/package.json
@@ -45,7 +45,7 @@
     "yup": "^1.4.0"
   },
   "scripts": {
-    "start": "vite",
+    "start": "vite --host <IP_ADDRESS>",
     "build": "tsc && vite build",
     "serve": "vite preview",
     "test": "vitest"

I did not alter the package.json because I would not expect vite to listen on all addresses in a dev environment. Instead, I added the host option to the CMD instruction.

Great. Tried that but without the --. Didn't know that I need to separate that. Thanks. Merging…


Fix Broken PMD Analysis

This command is a temporary fix to the recent changes introduced by sfpowerkit.
While I tried to address this in the last release, that made the command useless due to the following

Fix Issue with working directory
sfpowerkit by default always breaks, so need to bypass it
do a double pass, as an internal file used to be generated by sfpowerkit no longer is available

Codecov Report

Merging #644 (ba09cde) into develop (0f00c00) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head ba09cde differs from pull request most recent head 19aa88b. Consider uploading reports for the commit 19aa88b to get more accurate results

@@           Coverage Diff            @@
##           develop     #644   +/-   ##
========================================
  Coverage    64.58%   64.58%
========================================
  Files           43       43
  Lines         1423     1423
  Branches       240      240
========================================
  Hits           919      919
  Misses         504      504

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df0bcba...19aa88b. Read the comment docs.


Add ParameterizedTypeReference to ModifyRequestBodyGatewayFilterFactory

Hi!
I've had a go at fixing gh-2635. I'm not 100% convinced that my approach is the best way as I am concerned that my changes may break some of the public API (if ModifyRequestBodyGatewayFilterFactory.Config is considered part of that API) as I have changed the types which are returned from the getInClass and getOutClass methods.
If this is considered breaking, I can do some additional work to avoid causing such breaks, particularly if you're able to provide some advice on an acceptable way forward with it.
If I'm going completely down the wrong path here, please do let me know. Hope this helps and I'm open to making any changes as required.
Fixes gh-2635

@jrhenderson1988 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@jrhenderson1988 Thank you for signing the Contributor License Agreement!

I'd call the Config class public since that is how users interact, but you've kept the original methods, so it's backwards compatible.


NoSuchMethodError message for constructor argument mismatch is misleading

Given the following, I hope we can all agree that there is a constructor 'A' declared in class 'A':
class A	{
  A();
}

However this code:
void main() {
  new A(0);
}

...results in the following message:
Unhandled exception:
NoSuchMethodError: No constructor 'A' declared in class 'A'.
Receiver: A
Tried calling: new A(0)
#0      NoSuchMethodError._throwNew (dart:core-patch/dart:core/errors_patch.dart:192)
#1      main (test.dart:6:8)

I would prefer a message such as "Invalid arguments passed to constructor 'A' declared in class 'A'" or some such.

(putting in area-front-end since that will producing these sorts of error messages imminently)

We produce a different error message:
32493.dart:6:8: Error: Too many positional arguments: 0 allowed, but 1 found.
Try removing the extra positional arguments.
  new A(0);
       ^
32493.dart:2:3: Context: Found this candidate, but the arguments don't match.
  A();
  ^


Issue when trying to open a DICOM file.

I am facing an issue when trying to open a DICOM file. Interestingly, the code works for all DICOM files except one. I suspect there might be a problem when attempting to load pixel data, as using .read_until(tags::PIXEL_DATA) seems to work fine.
Err: ReadToken { source: ReadValue { len: 268374015, tag: Tag(0x0FFF, 0x0FFF), source: ReadValueData { position: 4033230, source: Error { kind: UnexpectedEof, message: "failed to fill whole buffer" }, backtrace: Backtrace(()) } } }

It appears that the Pixel Data element length (4030980 bytes) does not align with the real size of the pixel data encoded in the file (4031972 bytes). There are more pixel data values than the ones expected by its length, making the file non-compliant. The resulting errors are merely the consequence of the parser trying to read these trailing pixel data values as more data elements.
Could you look into whichever device or software that produced that file? It clearly did not encode the data element correctly.

Closing as an isolated incident from external devices for which the project should not adapt to for now. If the problem can be more substantiated in the future, please file a new issue.


feature request: skip empty translations

Hi!
Another request :)
It would be great if empty strings can be skipped when pulled (with e.g. a --skip-empty argument). For me, these are "untranslated", but because they are pulled as an empty string my app thinks its translated and displays that empty string.
Not sure if the underlying API package permits that.

Hi
I'm not sure if this is something I want to add as this is kind of a hack. Personally, I would use Loco tags or flags to denote untranslated assets. We can then maybe filter on tags when pulling.

I agree, filtering on tags / flags would be more beneficial.


[custom endpoint] Add support for getting auth token from command line

At our company we have an OpenAI API compatible model router deployed which can only be accessed via short lived tokens.
This means we can't put a long-lived API key in the configuration since long-lived tokens cannot be generated.
We would be able to use this if we provide a custom bash command to get an auth token like get-auth-token --name vs-code-ai

It's able to use environment variable when adding a model to "My Model" list.
E.g., for Open AI models,

Create environment variable OPENAI_API_KEY on your machine

(Close and reopen VSCode instances to ensure the env var works in VSC)

When adding Open AI model, you'll see an option "Use $OPENAI_API_KEY"

After adding model like this, AI Toolkit will call the model by referencing the value from your env var.

BTW, Antropic model uses ANTHROPIC_API_KEY, Google model uses GEMINI_API_KEY
(Let me also add these steps to the doc)

That's good to know! Although it doesn't quite solve the issue as we would have to quit and reopen VS code every few hours from the command line like
OPENAI_API_KEY=$(get-auth-token) code
It's just inconvenient enough that people would be discouraged from using this

We too have moved to oauth only for aoai access, specifically Az cli Entra ID. It would be nice if that were supported.
Thanks.

Thanks all for the detailed scenarios. Added to our backlog.
FYI @sffamily

@sa- Your use case is a valid scenario that we've added to our feature backlog and will investigate and plan it for our next release.


How to apply multimodal feature for multimodal classification?

Hi everyone,
First of all, thank you so much for this great package.
I would be so grateful if you could kindly provide me with an example code of how the multimodal feature can be used for multimodal classification, as you mentioned here.
Best,

Hi, thanks for your interest.
You can take multimodal embedding to send them to a classifier, which can be as simple as an MLP.
This can be useful when you want to classify captioned images. One example is the visual entailment (VE) task, which is a three-way classification. You may want to take a look at the ALBEF VE model for reference.
Thanks.


OSError: [WinError 121] The semaphore timeout period has expired

Problem Description
mitmdump throws this exception on the console
Traceback (most recent call last):

  File "C:\bin\Python-3.10.4\lib\asyncio\proactor_events.py", line 771, in _loop_self_reading
    f.result()  # may raise

  File "C:\bin\Python-3.10.4\lib\asyncio\windows_events.py", line 817, in _poll
    value = callback(transferred, key, ov)

  File "C:\bin\Python-3.10.4\lib\asyncio\windows_events.py", line 462, in finish_recv
    return ov.getresult()

OSError: [WinError 121] The semaphore timeout period has expired

Please lodge a bug report at:
        https://github.com/mitmproxy/mitmproxy/issues

Steps to reproduce the behavior:
mitmdump -s recordTraffic.py
System Information
Paste the output of "mitmproxy --version" here.
Mitmproxy: 8.0.0
Python:    3.10.4
OpenSSL:   OpenSSL 1.1.1n  15 Mar 2022
Platform:  Windows-10-10.0.19043-SP0

I can't reproduce this on Windows, we need more context. FWIW I suspect that this may be a bug in Python itself, but if we can reproduce it reliably I'd be happy to trace it down and get it fixed there.


Bump Dependencies #3584467987

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/3584467987

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


fix broken links in website

This PR fixes the broken links in website after upgrading docusaurus & typedoc as discussed here: https://github.com/hatemhosny/racing-bars/pull/164
The new version of typedoc generates a different file structure than the one previously used which caused links to break.

Thank you 😄


Edited Raft tutorial

Edited Raft tutorial

Instructions work well. 👍
Step 4 could perhaps be more explicit that the output of bootnode --nodekey=nodekey --writeaddress needs to be inserted at the <EnodeID> placeholder. Step 9 is similar.

Step 4 could perhaps be more explicit that the output of bootnode --nodekey=nodekey --writeaddress needs to be inserted at the <EnodeID> placeholder. Step 9 is similar.

Replace by something like that?

Copy the following (replace the <EnodeID> placeholder with the enode ID returned by the previous command)  to a file called static-nodes.json in the Node-1/data directory:


Bug when using configMap with ephemeral agents

Bug description 🐞
Hi !
Following the PR I implemented, it appears that the configMap is not mounted on the job when it's running. I've set the TERRAKUBE_ENABLE_EPHEMERAL_EXECUTOR, EPHEMERAL_CONFIG_MAP_NAME, EPHEMERAL_CONFIG_SERVICE_ACCOUNT and the EPHEMERAL_CONFIG_MAP_MOUNT_PATH but no volumes are mounted. I tripled check the new code I added but it seem correct to me and I'm having hard time to trouble shot where it comes from.
I'm still trying to figure out what is happening, if you have any ideas I'd be happy to hear !
thanks !
Steps to reproduce
Try to run an EPHEMERAL_JOB with the parameter above, no volume are mounted on the ephemeral job's container.
Expected behavior
No response
Example repository
No response
Anything else?
No response

Hello @alfespa17 !
Do I have good understanding of these values by setting workspace environment variables like ?  Or we do need to use them differently ? From what i can see in the kubectl describe job-<job_id>
Containers:
  job-376:
    Environment:
      EphemeralFlagBatch:           true
      EphemeralJobData:   data
      AWS_STS_REGIONAL_ENDPOINTS:   regional
      AWS_DEFAULT_REGION:          my-region
      AWS_REGION:                   my-region
      AWS_ROLE_ARN:                 my-role
      AWS_WEB_IDENTITY_TOKEN_FILE:  /var/run/secrets/eks.amazonaws.com/serviceaccount/token

Volumes:
  aws-iam-token:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  86400
  kube-api-access-46wdc:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true

No environment variables like EPHEMERAL_CONFIG_MAP_NAME are set so maybe I misunderstood something ?
Regards!

Did you update the value in ExecutorEphemeralImage???

From you logic here, I think it should work
https://github.com/AzBuilder/terrakube/blob/3114c2bf9fd768120216cf4aa5f5aaccb227e599/api/src/main/java/org/terrakube/api/plugin/scheduler/job/tcl/executor/ephemeral/EphemeralExecutorService.java#L88
You only need to add the environment values EPHEMERAL_CONFIG_MAP_NAME and EPHEMERAL_CONFIG_MAP_MOUNT_PATH

Hello @alfespa17 !
Do I have good understanding of these values by setting workspace environment variables like ?  Or we do need to use them differently ? From what i can see in the kubectl describe job-<job_id>
Containers:
  job-376:
    Environment:
      EphemeralFlagBatch:           true
      EphemeralJobData:   data
      AWS_STS_REGIONAL_ENDPOINTS:   regional
      AWS_DEFAULT_REGION:          my-region
      AWS_REGION:                   my-region
      AWS_ROLE_ARN:                 my-role
      AWS_WEB_IDENTITY_TOKEN_FILE:  /var/run/secrets/eks.amazonaws.com/serviceaccount/token

Volumes:
  aws-iam-token:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  86400
  kube-api-access-46wdc:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true

No environment variables like EPHEMERAL_CONFIG_MAP_NAME are set so maybe I misunderstood something ?
Regards!

Did you update the value in ExecutorEphemeralImage???

Yep ! I'm using this config for the API
api:
  defaultDatabase: false
  loadSampleData: false
  serviceAccountName: ${svc_name}
  env:
  - name: SERVICE_BINDING_ROOT
    value: /mnt/platform/bindings
  - name: JAVA_OPTS
    value: "-Xmx512m -XX:MaxMetaspaceSize=1024m"
  - name: ExecutorEphemeralNamespace
    value: terrakube
  - name: ExecutorEphemeralImage
    value: azbuilder/executor:2.24.0-beta.5
  - name: ExecutorEphemeralSecret
    value: terrakube-executor-secrets

Workspace environment variables

Did you try killing the API pod?

I didn't fix it :/

I didn't fix it :/

Try checking the Kubernetes job specification using kubectl maybe you can find what is missing there

Figured it out ! Actually need to set the API to the same image as the executor ! thanks !


Pull request for Issue #55 (controller for open data sets)

Resolves #55
Added a controller for data sets on the Edmonton Open Data Portal.
This controller returns data on all the data sets in the Open Data Portal catalogue (data set name and its columns). The data is loaded from the Redis cache when the controller endpoint is hit by the IFTTT applet. An example of the format of the returned data can be seen here under the "Animals" example or below.
Controller endpoint: <host>/ifttt/v1/triggers/open_data/fields/dataset/options
Data format:
data: [
  {
    "label": <dataset_label>,
    "values": [
      { "label": <column_name>, "value": <column_id> },
      ...
    ]
  },
  ...
]

The data needs to be pre-loaded into the Redis cache before the API endpoint is hit. New data can be received by sending a POST request to <host>/ifttt/v1/open_data/datasets/store, which executes an async function to store data set data into the Redis cache. There is a 15 minute timeout between each call.
Note: The separate drop-down lists for dynamic filtering of the trigger field was enabled by contacting the IFTTT Platform support team

I'll take a look at this on Monday.
*From: *Henry<EMAIL_ADDRESS>*Date: *Fri, Apr 5, 2019, 4:37 PM
*To: *CityofEdmonton/IFTTT-Edmonton
*Cc: *Jared Rewerts, Review requested
@WJXHenry https://github.com/WJXHenry requested your review on: #83

https://github.com/CityofEdmonton/IFTTT-Edmonton/pull/83 Pull request
for Issue #55 https://github.com/CityofEdmonton/IFTTT-Edmonton/issues/55
(controller for open data sets).
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/CityofEdmonton/IFTTT-Edmonton/pull/83#event-2257081010,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH6SqJgLY5nzNP2nAXHyjz3mPLVyVDw5ks5vd9AagaJpZM4cf1bj
.

--
The contents of this message and any attachment(s) are confidential,
proprietary to the City of Edmonton, and are intended only for the
addressed recipient. If you have received this in error, please disregard
the contents, inform the sender of the misdirection, and remove it from
your system. The copying, dissemination, or distribution of this message,
if misdirected, is strictly prohibited.

I think we'll have to try a different approach for initializing Redis. Typically, the way it is used is as a cache, where if the key you're looking for doesn't exist in Redis, you fetch it the long way and store it. Then, set a timeout using EXPIRE.

I think the problem with fetching keys on the spot is that we need all the data to be sent over in a single call. I don't think you can dynamically populate the drop-down field based on the data set selected - you pretty much need all the available data sets and their columns already loaded in. I was thinking of using Redis as more of a persistent storage (which I guess defeats the purpose of Redis)

Hey @j-rewerts, I made some of the changes that you requested, but I'd like to meet with you to discuss the other changes and how to go about solving them

I've added 1 more change request that should be simple. Then lets have a quick meeting.

@WJXHenry I'm going to get you to whittle this PR down a bit.
PR: The Open Data trigger fields, submitted to this branch. This will resolve #55.
After this, I'll get you to make a branch on your fork based on the open-data branch. Add your generic open data triggering work to that branch. I'll build off of that branch.

LGTM.


Error seting up provider - Home Assistant Mediaplayers

What version of Music Assistant has the issue?
2.0.2
What version of the Home Assistant Integration have you got installed?
2024.5.1
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
Pressing Save to add the HA Media Player provider I get the following error
players has unexpected type: <class 'NoneType'>

How to reproduce

Go to Settings
Select Add Player Provider
Select Home Assistant Mediaplayers
Select Save

Music Providers
N/A
Player Providers
HA Mediaplayers doesnt work
Sonos, Airplay and Chromecast work
Full log output
2024-05-12 09:53:03.492 INFO (MainThread) [music_assistant] Starting Music Assistant Server (ebc4420adf744b8daab35b1e57daf191) version 2.0.2 - HA add-on: True - Safe mode: False
2024-05-12 09:53:03.496 INFO (MainThread) [music_assistant.cache] Initializing cache controller...
2024-05-12 09:53:03.538 INFO (MainThread) [music_assistant.music] Using a sync interval of 180 minutes.
2024-05-12 09:53:03.631 INFO (MainThread) [music_assistant.streams] Detected ffmpeg version 6.0.1 with libsoxr support
2024-05-12 09:53:03.631 INFO (MainThread) [music_assistant.streams] Starting server on  <IP_ADDRESS>:8097 - base url: http://<IP_ADDRESS>:8097
2024-05-12 09:53:03.636 INFO (MainThread) [music_assistant.webserver] Starting server on  <IP_ADDRESS>:8095 - base url: http://<IP_ADDRESS>:8095
2024-05-12 09:53:03.787 INFO (MainThread) [music_assistant] Loaded music provider Music Assistant
2024-05-12 09:53:03.787 INFO (MainThread) [music_assistant] Loaded metadata provider TheAudioDB Metadata provider
2024-05-12 09:53:03.787 INFO (MainThread) [music_assistant] Loaded metadata provider MusicBrainz Metadata provider
2024-05-12 09:53:03.787 INFO (MainThread) [music_assistant] Loaded metadata provider fanart.tv Metadata provider
2024-05-12 09:53:03.787 INFO (MainThread) [music_assistant] Loaded music provider Tune-In Radio
2024-05-12 09:53:03.813 INFO (MainThread) [music_assistant] Loaded player provider SONOS
2024-05-12 09:53:03.819 INFO (MainThread) [music_assistant] Loaded plugin provider Home Assistant
2024-05-12 09:53:03.909 INFO (MainThread) [music_assistant.music] Sync task for Music Assistant completed
2024-05-12 09:53:04.168 INFO (MainThread) [music_assistant] Loaded player provider Airplay
2024-05-12 09:53:04.171 INFO (MainThread) [music_assistant.players] Player registered: ap48a6b88863cc/office
2024-05-12 09:53:04.173 INFO (MainThread) [music_assistant.players] Player registered: ap38420b9123c8/bedroom
2024-05-12 09:53:04.174 INFO (MainThread) [music_assistant.players] Player registered: ap0499b99e2b2d/bedroom (2)
2024-05-12 09:53:04.474 INFO (MainThread) [music_assistant.players] Player registered: RINCON_48A6B88863CC01400/Office
2024-05-12 09:53:04.476 WARNING (MainThread) [soco.events_asyncio] Could not bind to <IP_ADDRESS>:1400: [Errno 98] Address already in use
2024-05-12 09:53:04.580 INFO (MainThread) [music_assistant.players] Player registered: RINCON_38420B9123C801400/Bedroom
2024-05-12 09:53:05.001 INFO (MainThread) [music_assistant] Loaded music provider RadioBrowser
2024-05-12 09:53:05.088 INFO (MainThread) [music_assistant.players] Player registered: ap58d34916a4d3/Bedroom
2024-05-12 09:53:05.162 INFO (MainThread) [music_assistant.players] Player registered: apa4cf99c7a8cb/Office HomePod
2024-05-12 09:53:06.091 INFO (MainThread) [music_assistant.providers.spotify] Successfully logged in to Spotify as<PHONE_NUMBER>
2024-05-12 09:53:06.092 INFO (MainThread) [music_assistant] Loaded music provider Spotify
2024-05-12 09:53:09.384 WARNING (MainThread) [music_assistant.providers.tunein] Unable to retrieve info for http://media.on.net/radio/playlist.m3u: Connection timed out
2024-05-12 09:53:09.402 INFO (MainThread) [music_assistant.music] Sync task for Tune-In Radio completed
2024-05-12 09:53:09.402 INFO (MainThread) [music_assistant.music] Sync task for RadioBrowser completed
2024-05-12 09:53:18.481 INFO (MainThread) [music_assistant.music] Sync task for Spotify completed
2024-05-12 10:18:46.838 INFO (MainThread) [music_assistant.players] Player registered: ap9c760e31ae47/tbMacStudio
2024-05-12 10:23:14.158 INFO (MainThread) [music_assistant] Loaded player provider Chromecast
2024-05-12 10:23:14.829 INFO (MainThread) [music_assistant.players] Player registered: 683ce7c5-f8e2-5096-ec60-af7dce786292/tbPixelTablet
2024-05-12 10:23:15.261 INFO (MainThread) [music_assistant.players] Player registered: 5dec7c03-ac6c-e9a2-4387-6eb2aee2bdfc/SHIELD
2024-05-12 10:23:22.196 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/hass_client/client.py", line 318, in _process_messages
raise ConnectionFailed
hass_client.exceptions.ConnectionFailed: Connection failed.
2024-05-12 10:23:23.626 ERROR (MainThread) [music_assistant.webserver] Error handling message: config/providers/save: players has unexpected type: <class 'NoneType'>
2024-05-12 10:23:31.990 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/hass_client/client.py", line 318, in _process_messages
raise ConnectionFailed
hass_client.exceptions.ConnectionFailed: Connection failed.
2024-05-12 10:24:19.748 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/hass_client/client.py", line 318, in _process_messages
raise ConnectionFailed
hass_client.exceptions.ConnectionFailed: Connection failed.
2024-05-12 10:26:27.394 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/hass_client/client.py", line 318, in _process_messages
raise ConnectionFailed
hass_client.exceptions.ConnectionFailed: Connection failed.
2024-05-12 10:27:40.465 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/hass_client/client.py", line 318, in _process_messages
raise ConnectionFailed
hass_client.exceptions.ConnectionFailed: Connection failed.
2024-05-12 10:27:41.575 ERROR (MainThread) [music_assistant.webserver] Error handling message: config/providers/save: players has unexpected type: <class 'NoneType'>
Additional information
No response
What version of Home Assistant Core are your running
2024.5.3
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

Are you saying you can't add ANY HA media player? If not then list which players work and which don't

No players at all.

It looks like MA has discovered some other players. Do they work ok?
Is the plugin provider installed ok?

Cast players are working, and it did install the provider.

Are you saying you can't add ANY HA media player? If not then list which players work and which don't

I did under Player Providers - Sonos, Chromecast and Airplay all work
Home Assistant plugin provider is also installed

I'm also getting hass_client.exceptions.ConnectionFailed: Connection failed. and have not been able to populate the media player list using the Home Assistant media players provider. On 2.0.0 and 2.0.2.

Make sure to enable the web server in Settings->Core->Web Server (frontend and api)

You do not need to enable that port. It is disabled by default for security reasons

Didn't seem to matter if it's enabled for me or not, even trying to sync after it being enabled. I've disabled the port for the time being.

Yeah that setting has nothing to do with this report. So confirm you can see the list of HA players that are available to select but when you select one you get that error?

I don't see a list of HA players

For reference this is what you should see. Maybe you don’t have any suitable HA players?

Also you have listed the wrong integration version in your report. Look in HACS and report the version you are running. It should be 2024.5.0

Also you have listed the wrong integration version in your report

Well that's what is getting reported in integration setup

For reference this is what you should see

I only see this, pressing save is what generates the error in my original report

@bacco007 clear your browser cache. If that doesn’t work clear the MA cache (MA SETTINGS>> CORE>> CACHE CONTROLLER)

@cmsimike you have a different issue. Please open your own report

clear your browser cache. If that doesn’t work clear the MA cache

Done - still get same error

Have you restarted MA? Try a full host reboot?

Done both (separately), no change either time

Ok will have to wait for Marcel as I don’t know why that page isn’t rendering properly.

I've got the exact same issue where no media players are rendered.
This is most certainly related to

2024-05-13 22:31:00.016 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/hass_client/client.py", line 318, in _process_messages
raise ConnectionFailed
hass_client.exceptions.ConnectionFailed: Connection failed.

As this happens right before the nonexistent player list shows.
I'm guessing it's incorrect connection details to the supervisor api

2024-05-13 22:31:00.016 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/hass_client/client.py", line 318, in _process_messages
raise ConnectionFailed
hass_client.exceptions.ConnectionFailed: Connection failed.

I dont have the issue, that i cant see window, but i have this in my logs (ConnectionFailed) and cant setup any HA-mediaplayer. I can select it, but it does not appear in my playerlist.
I have server version [2.1.0 BETA 1] and integration version [2024.5.1].

@collateral87 if you don’t have the same issue as this then raise a new one.

@collateral87 if you don’t have the same issue as this then raise a new one.

Ok, i thinked this is the right place, because the error message is exactly the same as the autor has.

But this whole discussion is about how the OP doesn’t see anything in the media player list which you say you can see?

If you are running the beta please try with the latest version of the server as well as use the current beta of the integration 2024.7.1b0

Please try with beta 14 and try clearing the cache MA SETTINGS>>CORE>>CACHE CONTROLLER>>CONFIGURE>>CLEAR CACHE

We will close this soon due to no follow up. (rc2 is the latest to try)


HCAP-732 | seeding participants and sites

This is a general QoL improvement for testing as well as on-boarding new developers to the project. By seeding the database with sites and participants when the initial migrations are run, we can run tests on an environment more similar to the production deployment (instead of empty tables everywhere).
Addresses the following ticket:
https://freshworks.atlassian.net/browse/HCAP-732?atlOrigin=eyJpIjoiN2ViMDhmNjc0YjE0NGU2ODhmZmU3ZDNhMWU0NWJhMjgiLCJwIjoiaiJ9

@Zenen-freshworks Can you check why test is failing?

restarting to avoid seeding via migration.


CSV asset reader sample fails

The csv asset file reader fails
In this case the asset management notebooks have also been run, however the sample fails with:
jonesn:egeria/ (issue3254b) $ java -jar ./open-metadata-resources/open-metadata-samples//access-services-samples/asset-management-samples/asset-reader-csv-sample/target/asset-reader-csv-sample-2.0-jar-with-dependencies.jar
===============================
CSV File Reader Sample
===============================
Running against server: cocoMDS4 at https://localhost:9444
Using userId: erinoverview
Reading file: open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv

The open metadata repositories have returned 1 asset definitions for the requested file name open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv
===============================
Accessing file: open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv
Exception BASIC-FILE-CONNECTOR-404-001 The file named file://secured/research/clinical-trials/drop-foot/Patients.csv in the Connection object file://secured/research/clinical-trials/drop-foot/Patients.csv CSV File Store Connection does not exist

Only one asset is found, which is correct (ContactList.csv). It is unclear why the exception is reporting Patients.csv
It's also worth noting that although the ContactList.csv file exists, it probably should be moved into this sample. and also may be dependent on the current working directory when run

After cleaning the repos and only configuring, starting, and then running the create CSV sample, we still get:
jonesn:egeria/ (issue3254b) $ java -jar ./open-metadata-resources/open-metadata-samples//access-services-samples/asset-management-samples/asset-reader-csv-sample/target/asset-reader-csv-sample-2.0-jar-with-dependencies.jar
===============================
CSV File Reader Sample
===============================
Running against server: cocoMDS4 at https://localhost:9444
Using userId: erinoverview
Reading file: open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv

The open metadata repositories do not have an asset definition for the requested file name open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv
===============================
Accessing file: open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv
Number of records: 26
First 10 records ...

A search with TEX shows that the asset exists:
Entity: open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv [added in gen 1]
GUID : f9f7ccea-bee9-4431-ad1f-567857191540

Type: CSVFile

Version : 3

Status : ACTIVE

Properties:

delimiterCharacter : ,
description : This is a new file asset created by the CreateCSVFileAssetSample.
fileType : csv
latestChange : Asset created
name : open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv
qualifiedName : open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv
quoteCharacter : "
Classifications:

AssetOwnership
AssetZoneMembership
Home Repository:

metadataCollectionName : cocoMDS1
metadataCollectionId :
fa91620f-7f34-4455-8596-45657eb22348
OMRS Control Properties:

createdBy : peterprofile
createTime : 2020-06-25T15:36:49.122+00:00
updatedBy : peterprofile
updateTime : 2020-06-25T15:36:49.153+00:00
maintainedBy :
list is empty
instanceURL : undefined
instanceLicense : undefined
instanceProvenanceType : LOCAL_COHORT
replicatedBy : undefined

Note the qualified name looks correct -- though the query is being done against cocoMDS4 for TEX, using the enterprise connector
Switching the reader sample back to cocoMDS1 does then retrieve the asset metadata -- though not the file.
I don't see this as an inhibitor for the 2.0 release, but we do need to ensure the right servers are being used, that we add more test to the readme for the sample, and correct the use of enterprise connector if needed, plus ensure the sample file exists/in right place -- as this sample is a useful stepping stone for understanding asset management in egeria.

We get a similar issue with the avro file reader sample.
In this case I took the sample 'weather.avro' from the avro project, and was able to add this to egeria's metadata repo.
However the reader fails against cocoMDS4 (as currently coded), whilst it works against cocoMDS1

This is probably because the supported zones are different on each repository so it is expected that different assets are visible through different repositories.   However I will check that this is the case.

The file itself does need to be in the correct location to allow the connector to read it.  Without knowing details of where it was run from I can not comment on whether it is a problem or incorrect environment.  Basically the filename (including path) has to be correct in the call to create the asset.
I am assuming TEX should be REX.  Either one accesses the metadata repository using the repository services.  These services do not support the filtering of assets using the governance zones.  Governance zones are supported by the OMAS.
The samples do not set up zones on the assets.  This means the servers use the value from "defaultZones" to set the zone value when the asset is created.   When the file is read, the value from the 'supportedZones' is used.  These values are configured on each access service within the server.    Each of the metadata servers in the coco hands on labs is set up with different defaultZones and supportedZones.
For example:

cocoMDS4 does not support any access services permitting assets to be created.  However it does have asset-consumer which is set up with SupportedZones="data-lake".
When assets are created in cocoMDS1, the zone is set to "quarantine-zone".  This asset is invisible to users of cocoMDS4.  It should be possible to see them from cocoMDS2 because it has supportedZones="" which means all.
I thinkk it is working as is should

Thanks. I'll assign it to myself to retest/check docs next time I run

I went to run this directly from the 'distribution' and whilst the create appears to work (no error is reported) it's not clear it's finding the file.
When run from the top level of egeria not the distribution, but calling the uber jar in the distribution it also appears to work, and files look ok, but file is not found. This may indeed be due to reading from cocoMDS2
I think for the sample we need

A description of the scenario in the source tree
information on how to run in the source tree
supporting docs (or a link) in the published distribution
Explanation of the expected config for the code to run (or request the coco is setup)
ensuring the default servers/URL work with that config
error checking if asset cannot be created (if it doesn't exist?)

So that anyone can come along and understand the sample and try it out - then incrementally explore more
(this probably applies to other samples)
Rather than a bug this is more a reflection of some work to improve usability of the samples

My run (for example)
jonesn:egeria/ (issue3441) $ java -jar ./open-metadata-distribution/open-metadata-assemblies/target/egeria-2.2-SNAPSHOT-distribution/egeria-omag-2.2-SNAPSHOT/samples/asset-create-csv-sample-2.2-SNAPSHOT-jar-with-dependencies.jar
===============================
CSV File Asset Creation
===============================
Running against server: cocoMDS1 at https://localhost:9444
Using userId: peterprofile
Creating file: open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv

jonesn:egeria/ (issue3441) $ java -jar ./open-metadata-distribution/open-metadata-assemblies/target/egeria-2.2-SNAPSHOT-distribution/egeria-omag-2.2-SNAPSHOT/samples/asset-reader-csv-sample-2.2-SNAPSHOT-jar-with-dependencies.jar
===============================
CSV File Reader Sample
===============================
Running against server: cocoMDS4 at https://localhost:9444
Using userId: erinoverview
Reading file: open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv

The open metadata repositories do not have an asset definition for the requested file name open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv
===============================
Accessing file: open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv
Number of records: 26
First 10 records ...


Fix test failure when cuDNN is unavailable

Fixes error introduced in #2234.

Jenkins, test this please.

Sorry, I missed that during the review. Thanks for the fix.

Jenkins CI test (for commit f494e5627e48ed4f186cbfca2d97a7cc6618cea3, target branch master) succeeded!

LGTM!


3D Modeling - Radio + MP3

3D model radio and mp3 for development

[ ] Design
[ ] Modeling
[ ] QA

Mp3
Front

Right

Left

back

top

bottom

I cannot found a way to create an animation that can change materials color in 3ds max, so I made the animations inside the unity.
The animation just changes the color of the buttons from black to blue to make that seem user press the button.

Radio
Front

Back

Top

Bottom

I added an animation to play the radio with an animator controller. So remember to add a component if you use the animation


Add support for markers in the paper programs and the design board

We've been adding support for using "markers", which are circles that are a bit bigger than the one used to identify the paper programs. I don't see an issue for this and have a commit to make, so I'm adding this.  @jessegreenberg - Let me know if there is one already and I just missed it.

Thanks, this is great. Here is the branch issue: https://github.com/phetsims/paper-land/issues/83. We also had #67, but this can be a continuation.

I merged the changes into master and tested them out for a bit. Everything is working great @jbphet, nicely done on this!
I made a couple of programs that exercise the new emitters. I think the next step is to discuss the examples and API with the team to confirm that what we are hoping for is covered. But otherwise I think this is done.

This is indeed done and proven to work very well for virtual and real papers. Noting that there is a set factor for a dot to be considered a marker. This is set at calibration when the average dot size is determined.


Getting cppsim to compile from sources alongside the MindQuantum sources

In principle, cppsim source is now integrated into MQ, and compiles together with it. There are several items to be addressed yet:

The cmake and cmake/commands modules folder should not be reached with ../../.., this is ugly. But I was not able to find an example of a better way to do it in other subfolders.

include("${CMAKE_CURRENT_SOURCE_DIR}/../../../cmake/compiler_has_std_filesystem.cmake")

Accessing ../../include/cppsim include directory is also ugly, maybe there is a good environment variable to use instead?

CppSim still deals with dlfcn-win32 by itself, while all other dependencies are brought in globally, by MQ. I guess we should move this dependency out on MQ likewise, but before that maybe it's better to use cross-platform dynalo instead?

There is an issue with std::allocator, compiler complains about max_size(). Even though throw() version is not deprecated, it fails either way. Maybe we disable exceptions?

    // class std::allocator<std::complex<double> >’ has no member named ‘max_size’; did you mean ‘_M_max_size’?
    size_type max_size() const noexcept
    {
        std::allocator<T> a;
        return a.max_size();
    }

1. The `cmake` and `cmake/commands` modules folder should not be reached with `../../..`, this is ugly. But I was not able to find an example of a better way to do it in other subfolders.

This is easily fixed. As long as the corresponding folders are inside the CMAKE_MODULE_PATH you can include them without using a path:
include(compiler_has_std_filesystem)

2. CppSim still deals with `dlfcn-win32` by itself, while all other dependencies are brought in globally, by MQ. I guess we should move this dependency out on MQ likewise, but before that maybe it's better to use cross-platform dynalo instead?

Sure we could do that. Otherwise, we can just add dlfcn-win32 to the list of third parties in MindQuantum and only load it when necessary.

3. There is an issue with std::allocator, compiler complains about max_size(). Even though throw() version is not deprecated, it fails either way. Maybe we disable exceptions?

As discussed yesterday, look at the version included in HiQ-ProjectQ.

Also ensure that the versions of the third-party specified in the third_party folders are the same you are specifying (e.g. for ResEmbed)


Expose label selection parameters

These parameters have helped reduce computational complexity in our previous implementations. Exposing them allows us to play with the values!

LGTM. Any anecdata based recommendations?

Currently figuring out that now (we had 6 before, verifying it works with this decoder)


Create and review compliance diagram for guardrails with cloud environments

Guardrails with and without security and privacy
Definition of Done
Current compliance( privacy and security) of different cloud providers, eg. Google, AWS

first draft completed on 26th


added contributing.md file

Made the contributing file and made the required changes

Please make it more elaborate and interactive like this

Please make it more elaborate and interactive like this

@Sloth-Panda you are in SWOC only or DWOC as well?

@Sloth-Panda you are in SWOC only or DWOC as well?

Sir, I am in both actually

Sir, I am in both actually


support configure nydusd mirror health checking

The failure_limit indicates the failed time at which the mirror is set to unavailable, and the health_check_interval indicates the time interval to recover the unavailable mirror.
This PR is related to https://github.com/dragonflyoss/image-service/pull/800
Signed-off-by: Bin Tang<EMAIL_ADDRESS>

We still have to discuss with the community if these parameters and proper. So let's wait for a period 🤗


OOD PR Merge pull request #639 from OSC/grafana-cluster

Create documentation for https://github.com/OSC/ondemand/commit/f20a190cc04ecf1885fb09c20d511ac8ab30f71d

This was completed in the PR linked in this ticket.


MINOR: Bump Netty to 4.1.115.Final

This release includes a fix for a low rated CVE (CVE-2024-47535) on Windows.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mimaison Can you change also the LICENSE-binary file?

Still making this mistake after all these years is embarrassing :see_no_evil:
Thank you!

We should automate this, definitely!

Backported to 3.8 (just in case): f3222da

Cherry-picked to 3.7 branch, for 3.7.2 release.


Use Context#deleteFile for local/private storage

mASAPP Report is reporting the following error:
Category: Code Quality
CVSS: 4.7
Description: The use of the method "java.io/File/delete" deletes the file or directory denoted by
its abstract pathname. If this pathname denotes a directory, then the directory must be empty
in order to be deleted.
Impact: This may lead to information disclosure if the deleted file was stored in an external SD
card. The original file could be recovered by a third-party in an undesired manner.
Recommendations: Please make sure not to use file.delete to delete essential files. Use
Context.deleteFile for private files instead.

This is a small change that will make this report pass

It's failing on Firebase test @josealfonsomora
Can you check on it? Otherwise, I'll see what I can do on this weekend

From the error message Service account is required to authorize gcloud to access the Cloud Platform. I think there is a configuration problem
I will take a look at the google action to see if I can find something

        uses<EMAIL_ADDRESS>        with:
          arg-spec: 'firebasetest.yml:android-pixel-4'
        env:
          SERVICE_ACCOUNT: ${{ secrets.SERVICE_ACCOUNT }}```

I saw how firebase test is being run and I think there is nothing I can do to help. Service account has to be checked

Hi @josealfonsomora after looking again at the source code, I don't think I want to use Context#deleteFile for this case for the reasons:

I still don't know the behavior difference between File.delete and Context.deleteFile apart from what you tell on the PR
The file that being deleted in that method is an empty file (this handle edge cases where empty image exist)
I don't consider Image as a private file, if it is, the image save path is configurable and I plan to make CameraModule configurable too

Thanks anyway!


use weak for supperior handling

Throws the error as soon as it's clear that it won't be handled in any way \o/

It seems like Travis is failing because of an too old compiler :(

@sindresorhus What do you think? :smile:

The tests now only runs in io.js 1.4.1 and above since that was the version that introduced unhandledRejection.

Really cool idea, but I don't want to introduce a native dependency. Native dependencies in Node are horrible and prone to break in so many ways and never works on Windows. Seeing how I'm planning to use this in most of my modules, I really don't want a native dependency in there.

I encourage you to make it into an alternative module for those willing to have a native dependency, though.

Sounds like a good plan, I'll try and finish up the other pull request then :)

:+1:


Update Readme with better install instructions

It should say
"git clone https://github.com/Roibal/Cryptocurrency-Trading-Bots-Python-Beginner-Advance.git"
then "pip install xxx"
then "python Bot"
It should be as simple as being able to just copy and paste everything you tell it to then it works....

@Roibal I can work on an easiest way to install & run your experiments.

@kiikoh thank you for the suggestion. I have updated the installation instructions to include your description (plus a couple additions), please tell me if anything needs to be added. @santteegt please let me know if you would like to add additional info.

I have edited the installation instructions, included (and modified) your instructions, and I will continue to modify the readme as project grows. If anyone has any future mods to readme, fork the repo and them submit your changes under a pull request and I will include. Thank you to everyone for helping to make this code better and better.


it seems BasePlugin#sourceForNode() trims first character of AttrNodes

it seems BasePlugin#sourceForNode() trims first character of AttrNodes.
from log i made:
----
{ type: 'AttrNode',
  name: 'src',
  value: { type: 'TextNode', chars: 'tomster.png', loc: null },
  loc:
   { source: null,
     start: { line: 1, column: 20 },
     end: { line: 1, column: 36 } } }
===
rc='tomster.png'
===

in other case it seems it shift the character in offset of 1
<img alt=tomster>

Result:
lt=tomster>

My guess is that both are the same, but I'd need to dig in a bit more.


Fix push container - 125

[Auto generated]
Number: [#125]

github-webhook-server: Closing issue for PR: Fix push container.
PR was closed.


Add support for RP2350 (Pico 2)

Also update OTP matrix for macOS to include OTP27
Also fix build test matrix to also install elixir & rebar3 in all cases.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

True.
Raspberry Pi had a rp2_common directory before the pico 2.
https://github.com/raspberrypi/pico-sdk/tree/master/src
Micropython calls the port rp2
https://github.com/micropython/micropython/tree/master/ports
I never was a fan of the pico brand name for this platform as pico refers to the board and not the soc and there are a lot of cheap boards using the same soc that we support here.

True.
Raspberry Pi had a rp2_common directory before the pico 2.
https://github.com/raspberrypi/pico-sdk/tree/master/src
Micropython calls the port rp2
https://github.com/micropython/micropython/tree/master/ports
I never was a fan of the pico brand name for this platform as pico refers to the board and not the soc and there are a lot of cheap boards using the same soc that we support here.

I understand your point, still I'm not yet sure if we are using Raspberry Pi Pico vs 2040 names in a consistent name.


Error in ios

When i call to Speak in iOS throw:
Foundation.MonoTouchException: Objective-C exception thrown.  Name: com.apple.coreaudio.avfaudio Reason: required condition is false: IsFormatSampleRateAndChannelCountValid(format)

What version of the plugin are you using?


Head problem

Sorry, 'im new here....
Well, i want a take a picture when my V's is.... with a joytoy... and his head is disappered.... i moved the camera after i opened the photo mode. :\

Yeah sorry that's not gonna work. The game doesn't render a head in those scenes, with or without photomode... there's no way to force the game to render the head at the moment...

Yeah sorry that's not gonna work. The game doesn't render a head in those scenes, with or without photomode... there's no way to force the game to render the head at the moment...


Gnome Sort

Is your feature request related to a problem? Please describe.
Gnome Sort is a sorting algorithm that arranges all the elements in their correct positions by means of a series of swaps in a single loop.
Do you want to work on it
I will write the code in C++

@plazzy99 @rudrakshi99 @nakul-19 @raksha009 @rish-singhal @Rohan27s @yasharth291 please assign this issue to me

@plazzy99 @rudrakshi99 @nakul-19 @raksha009 @rish-singhal @Rohan27s @yasharth291 please assign this issue to me in python

Please assign this to  me in Java

Please assign this to me in C++.I am a GSSOC'21 participant


Blank stars for the question categories that do not have ratings are styled not correctly

On the article page, the blank stars for the question categories without ratings are not styled correctly.


fedimint: 0.3.2-rc.0 -> 0.3.2

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

please mark broken on x86_64-darwin

For some reasons rocksdb sometimes has compilation/linking issues on MacOS when newer clangs are being used. In our own flake-based setup, we use clang 11 or 12 on Darwin. Would that be an OK thing to do in here?

it seems we still keep 12 around, but if you're able try out and use a newer one then it would be much appreceated

@pbsds I don't currently have a good way to try it on Darwin, but I verified that Linux version builds with overriden stdenv just fine, so that's promissing. Hopefully the way I implemented it is OK.

The CI eval fails because clang12Stdenv is an alias of llvmPackages_12.stdenv. Aliases are disabled in CI


[ISSUE #5437] Add log info for push consumer when execute hook failed

closes https://github.com/apache/rocketmq/issues/5437

Codecov Report

Merging #5468 (74af205) into develop (dd95a5b) will increase coverage by 0.00%.
The diff coverage is 31.01%.

@@             Coverage Diff             @@
##             develop    #5468    +/-   ##
===========================================
  Coverage      43.17%   43.17%
- Complexity      8050     8061    +11
===========================================
  Files           1021     1025     +4
  Lines          71999    72196   +197
  Branches        9537     9560    +23
===========================================
+ Hits           31082    31171    +89
- Misses         36985    37077    +92
- Partials        3932     3948    +16

Impacted Files
Coverage Δ

...a/org/apache/rocketmq/broker/BrokerController.java
46.44% <0.00%> (+2.67%)
:arrow_up:

...rocketmq/broker/metrics/BrokerMetricsConstant.java
0.00% <ø> (ø)

.../rocketmq/broker/metrics/NopLongUpDownCounter.java
0.00% <0.00%> (ø)

...ocketmq/broker/processor/PeekMessageProcessor.java
3.40% <0.00%> (-0.20%)
:arrow_down:

...he/rocketmq/broker/processor/PopReviveService.java
40.56% <0.00%> (-0.92%)
:arrow_down:

.../transaction/queue/TransactionalMessageBridge.java
69.51% <0.00%> (-2.71%)
:arrow_down:

...lient/impl/consumer/DefaultMQPushConsumerImpl.java
32.12% <0.00%> (-0.09%)
:arrow_down:

...he/rocketmq/common/attribute/TopicMessageType.java
91.66% <0.00%> (-8.34%)
:arrow_down:

.../apache/rocketmq/common/utils/ServiceProvider.java
0.00% <0.00%> (ø)

...org/apache/rocketmq/store/DefaultMessageStore.java
53.62% <0.00%> (+0.04%)
:arrow_up:

... and 31 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Rebase to make all CI pipelines pass


Latency performance test

What is speed parameter? Can you please make this test more actual.

Also you should change this test to generate some files (with modified perf_compare) which can be compared with previous ones.

Current test is in my branch https://github.com/intel-go/nff-go/tree/mbulatova/latency
Added scope according to perf.json (perf_main, perf_light, perf_seq)
Takes 34m to complete

After #353 is implemented, writing to files will not be necessary


⚠ Samsung has degraded performance

In fa5f16e, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1903 ms

Resolved: Samsung performance has improved in 7491a8a.


(7zip*) migrated from ferventcoder

Package source: https://github.com/ferventcoder/chocolatey-packages/pull/223
3 open issues

@majkinetor Will you change this also to an embedded package? Based on the license I think this should be possible.

Will you change this also to an embedded package?

Yes, this should be embedded. You, rather then me, should do it, since you are migrating it now.  Its easier then creating online installer and people should get used to it. See vlc as an example or any other that uses it.
In short:

you can use Get-RemoteFiles in this repository (still unpublished) but this repo uses NEXT version.
you will need to create embedded intaller which differes from online one (no checksums, urls etc.). I created Get-RemoteFiles in such way that changes to chocolateyInstall are trivial (in general case only silentArgs should be filled in and removed arch's that aren't used).

Ah, sorry, I thought I was writting on Git.
Yes, I will embedd this one.

@majkinetor chocolatey user has been added to each of these packages on chocolatey.org.

This ready?

@ferventcoder doesn't look like it, looks like it's currently just the same code as in your repo

Right on.

I believe this is done now, could someone please review it?
All issues at @ferventcoder is fixed except for https://github.com/ferventcoder/chocolatey-packages/issues/82 which I couldn't reproduce, making me think it have been fixed upstream

@pascalberger
I believe I've added/responded to the feedback you provided.
With the exception of moving to 7zip.portable, will do that to but not yet.

I believe the 7zip packages is now finally done.
/cc @pascalberger @ferventcoder

Thanks, LGTM

I'm just looking for a 👍 from @ferventcoder before this can be merged.

I noticed the following packages need to be unrejected.
7zip v16.04
7zip.install v16.04
Not sure about 7zip.commandline v16.04 needs to unrejected though, as we're deprecating it.
/cc @chocolatey/community-moderators

@AdmiringWorm I have unrejected the first two packages.  For the last one, I would be tempted to push out a package fix notation version, that way it is clear that it isn't an "official" release.

Looks great. Just a few minor issues...

@ferventcoder I've made the requested changes, if there isn't anything else I believe this can now be merged.

LGTM

👍
The build is running to update the 7zip packages now, when it's done and the 7zip.portable package is approved I can push out the deprecated 7zip.commandline package


Apache Phoenix - Existing Schema

What version of Flyway are you using?
4.2.0
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command Line
What database are you using (type & version)?
HBASE 1.1.2 with Phoenix 4.10
What operating system are you using?
Ubuntu 14.04
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
➜  flyway-4.2.0  ./flyway migrate -url="jdbc:phoenix:<IP_ADDRESS>:2181"  -jarDirs=../apache-phoenix-4.10.0-HBase-1.1-bin -locations=filesystem:/home/barrett/Git/rm-metrics-ingestion/src/main/resources/migrations
Flyway 4.2.0 by Boxfuse

Database user:
Database password:
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/barrett/Tools/flyway-4.2.0/../apache-phoenix-4.10.0-HBase-1.1-bin/phoenix-4.10.0-HBase-1.1-hive.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/barrett/Tools/flyway-4.2.0/../apache-phoenix-4.10.0-HBase-1.1-bin/phoenix-4.10.0-HBase-1.1-client.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/barrett/Tools/flyway-4.2.0/../apache-phoenix-4.10.0-HBase-1.1-bin/phoenix-4.10.0-HBase-1.1-thin-client.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/barrett/Tools/flyway-4.2.0/../apache-phoenix-4.10.0-HBase-1.1-bin/phoenix-4.10.0-HBase-1.1-pig.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
Database: jdbc:phoenix:<IP_ADDRESS>:2181 (Phoenix 4.10)
Phoenix does not support setting the schema. Default schema NOT changed to
Phoenix does not support setting the schema. Default schema NOT changed to
Successfully validated 2 migrations (execution time 00:00.019s)
Phoenix does not support setting the schema. Default schema NOT changed to
Phoenix does not support setting the schema. Default schema NOT changed to null
ERROR: Found non-empty schema(s)  without metadata table! Use baseline() or set baselineOnMigrate to true to initialize the metadata table.

HBASE Tables
hbase(main):013:0> list
TABLE
SYSTEM.CATALOG
SYSTEM.FUNCTION
SYSTEM.MUTEX
SYSTEM.SEQUENCE
SYSTEM.STATS
5 row(s) in 0.0100 seconds

=> ["SYSTEM.CATALOG", "SYSTEM.FUNCTION", "SYSTEM.MUTEX", "SYSTEM.SEQUENCE", "SYSTEM.STATS"]

What did you expect to see?
Migrations to be applied
What did you see instead?
Error concerning existing table
I am familiar with the meaning of the error when applied to RDBMS, but I'm not sure the meaning with Phoenix.

@jmahonin What do you think?

I'll note, that in production I will be limited to running Phoenix 4.7.0, so I'm unable to use any of the schema features that were introduced in 4.8.0

The initial flyway implementation was made for Phoenix 4.4. As a total guess, I suspect something's changed with the expected behaviour in this method since then:
https://github.com/flyway/flyway/blob/master/flyway-core/src/main/java/org/flywaydb/core/internal/dbsupport/phoenix/PhoenixSchema.java#L51-L68
@bearrito Do you see the same issue regardless of the migrations applied? i.e., For reproducibility, does this issue occur on a trivial migration?

Yes, I looked a bit at that method. Would it make sense to filter out tables prefixed with System. ? My guess is the length of the table list is greater than zero  because of the inclusion of System tables.
I will try what you suggest, with a trivial migration.
I will also add that I was able to work around this by baseline prior to migrate

This now seems further broken. I'm unable to run any migrations
➜  flyway-4.2.0 ./flyway migrate -url="jdbc:phoenix:<IP_ADDRESS>:2181"  -jarDirs=../apache-phoenix-4.10.0-HBase-1.1-bin -locations=/home/barrett/Git/rm-metrics-ingestion/src/main/resources/migrations
Flyway 4.2.0 by Boxfuse

Database user:
Database password:
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/barrett/Tools/flyway-4.2.0/../apache-phoenix-4.10.0-HBase-1.1-bin/phoenix-4.10.0-HBase-1.1-hive.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/barrett/Tools/flyway-4.2.0/../apache-phoenix-4.10.0-HBase-1.1-bin/phoenix-4.10.0-HBase-1.1-client.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/barrett/Tools/flyway-4.2.0/../apache-phoenix-4.10.0-HBase-1.1-bin/phoenix-4.10.0-HBase-1.1-thin-client.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/barrett/Tools/flyway-4.2.0/../apache-phoenix-4.10.0-HBase-1.1-bin/phoenix-4.10.0-HBase-1.1-pig.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
Database: jdbc:phoenix:<IP_ADDRESS>:2181 (Phoenix 4.10)
WARNING: Unable to resolve location classpath:home/barrett/Git/rm-metrics-ingestion/src/main/resources/migrations
WARNING: Unable to resolve location classpath:home/barrett/Git/rm-metrics-ingestion/src/main/resources/migrations
WARNING: Unable to resolve location classpath:home/barrett/Git/rm-metrics-ingestion/src/main/resources/migrations
WARNING: Unable to resolve location classpath:home/barrett/Git/rm-metrics-ingestion/src/main/resources/migrations
Creating schema  ...
Phoenix does not support creating schemas. Schema not created: null
Creating Metadata table: "schema_version"
Phoenix does not support setting the schema. Default schema NOT changed to
Phoenix does not support setting the schema. Default schema NOT changed to
Current version of schema : null
Schema  is up to date. No migration necessary.
Phoenix does not support setting the schema. Default schema NOT changed to
Phoenix does not support setting the schema. Default schema NOT changed to null
➜  flyway-4.2.0

Apache Phoenix support is dropped https://github.com/flyway/flyway/issues/2112, so this issue is irrelevant. We can check if it's still relevant if we re-introduce support.


Add missing attributes to AndroidManifest annotations

Can one of the admins verify this patch?

@AppInventorWorkerBee ok to test


No module sdx.common

I got errors on make build and fixed them with these changes:
diff.txt

@tundish assuming this is no longer a problem, can we close it?

Appears to be working now


Parser: prevent to finish a macro body when {% if/for/begin %} is nested

Fixed #4769
This introduced control_nest counter variable to keep macro control (if/for/begin) nesting information. When the parser finds end inside macro body, it checks control_nest and finishes a macro body if and only if control_nest is 0 (and nest which is usual block nesting
information is 0 also).

You're awesome! Thanks =)
The original code of #4772 with end formats and compiles with this fix.
However the workaround using {{ "end".id }} still produces an error in the formatter (but compiles fine).

Sorry, I forget to fix the formatter.

Done fixing the formatter.

Confirmed, now it works as expected. Thanks again!

Can we get this approved?

I think I'd prefer a parse_macro_control_body method, instead of repeating incr, parse_body, decr.
What is nest for? Any nested macro content?

nest is for counting if, while and other Crystal (not macro) control block nesting to detect macro block's end. But it behaves like stack against macro control internally, in other codes:
macro foo
  # `nest == 0`
  {% if true %}
    # `nest == 0` also necause `{% if true %}` is not counted by `nest`
    if true
      # `nest == 1` because `if true` is counted
  {% end %}

  # Now, `nest == 0`. oops! after {% if true %}, `nest` is reset before it.

  {% if true %}
    # `nest == 0` and the parser found `end`, so the parser mistakes it as macro body `end`, and then #4769 bug is caused.
    end
  {% end %}
end

Macro body parsing is very very and very complex task (hmm, @asterite?), so unfortunately we cannot count macro/usual control block nesting in simple way. You should read source codes of the parser.
Of course, to correct this behavior is the right way to fix #4768, but I think this PR way is also right and this is simpler than that. The most preferable way is to apply both, but I think this makes it hard to review.

Yes, this is a fix for incorrect behaviour and does not add much complexity. It makes sense to merge this as a bugfix for now and address refactoring in a different PR.

Thanks the detailed explanation @MakeNowJust. That makes sense.


Casing broken since the recent dashing changes

This is how OpenRailwayMap looks with the original rendering code:

This is how it looks now:

The casing is now either always on or always off as it looks to me. The change is the new dashing code from @braandl.

Hm, I use the new code in my Application, and I can not find any of that behavior so far. When does this happen?

It's this code.

Hm, when I define casing and dashing in the same selector, it works as intended, i think?
Maybe you should define the dashes in "way|z9-[railway=razed].tracks", too?
I am not sure what the correct behavour is...

Your case looks correct.

Which version of Leaflet do you use? Which Browser?

Leaflet 0.7.7 and I did test it with Google Chrome, Firefox on Windows, Ubuntu , Opera on Windows and Mobile and Safari MacOsX 10.11 aswell as on iPhones with iOS 9.3 and on an iPad Air having no issues that I am aware of.

All the Browsers were always updated to the latest stable version.

We were still using Leaflet 0.6.2 back then, but meanwhile I upgraded. I'll test again.

South of the bridge this is just one way, which in the middle stops showing any casing. I changed the base color to green just to make sure there are no other styles interfere with that.
Have you tried your code when the line crosses tile borders?

Yes, it works on my Installation that provides tiles for entire regions as gjson