KeyError: "EncoderDecoder: 'PlainMamba is not in the models registry'"

Hi, thank you for sharing your work.
I’m trying to perform semantic segmentation using PlainMamba, but I encountered errors when running commands like tools/get_flops.py and tools/dist_test.sh.
Could someone please assist me with this? I would greatly appreciate your guidance.
cd PlainMamba/downstream/mmsegmentation && python tools/get_flops.py plain_mamba_seg_configs/l1_upernet.py

/usr/local/lib/python3.10/site-packages/mmcv/__init__.py:20: UserWarning: On January 1, 2023, MMCV will release v2.0.0, in which it will remove components related to the training process and add a data transformation module. In addition, it will rename the package names mmcv to mmcv-lite and mmcv-full to mmcv. See https://github.com/open-mmlab/mmcv/blob/master/docs/en/compatibility.md for more details.
  warnings.warn(
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/mmcv/utils/registry.py", line 69, in build_from_cfg
    return obj_cls(**args)
  File "/root/PlainMamba/downstream/mmsegmentation/mmseg/models/segmentors/encoder_decoder.py", line 36, in __init__
    self.backbone = builder.build_backbone(backbone)
  File "/root/PlainMamba/downstream/mmsegmentation/mmseg/models/builder.py", line 20, in build_backbone
    return BACKBONES.build(cfg)
  File "/usr/local/lib/python3.10/site-packages/mmcv/utils/registry.py", line 237, in build
    return self.build_func(*args, **kwargs, registry=self)
  File "/usr/local/lib/python3.10/site-packages/mmcv/cnn/builder.py", line 27, in build_model_from_cfg
    return build_from_cfg(cfg, registry, default_args)
  File "/usr/local/lib/python3.10/site-packages/mmcv/utils/registry.py", line 61, in build_from_cfg
    raise KeyError(
KeyError: 'PlainMamba is not in the models registry'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/PlainMamba/downstream/mmsegmentation/tools/get_flops.py", line 159, in <module>
    main()
  File "/root/PlainMamba/downstream/mmsegmentation/tools/get_flops.py", line 124, in main
    model = build_segmentor(
  File "/root/PlainMamba/downstream/mmsegmentation/mmseg/models/builder.py", line 48, in build_segmentor
    return SEGMENTORS.build(
  File "/usr/local/lib/python3.10/site-packages/mmcv/utils/registry.py", line 237, in build
    return self.build_func(*args, **kwargs, registry=self)
  File "/usr/local/lib/python3.10/site-packages/mmcv/cnn/builder.py", line 27, in build_model_from_cfg
    return build_from_cfg(cfg, registry, default_args)
  File "/usr/local/lib/python3.10/site-packages/mmcv/utils/registry.py", line 72, in build_from_cfg
    raise type(e)(f'{obj_cls.__name__}: {e}')
KeyError: "EncoderDecoder: 'PlainMamba is not in the models registry'"

Hi, you may need to run "pip install -e ."

Thank you very much for your quick reply.
I successfully ran pip install -e . on ./PlainMamba, ./PlainMamba/downstream/mmdetection, and ./PlainMamba/downstream/mmsegmentation. I was able to perform object detection in ./PlainMamba/downstream/mmdetection, but I encountered the above error when trying to perform segmentation in ./PlainMamba/downstream/mmsegmentation.
This might not be related, but it appears that PlainMamba has not been registered in the mmseg/models/backbones/init.py file.


Document Java version should be exact 1.8

https://github.com/apache/incubator-iceberg/blob/720b240a3e6a32b6f01173ebcc448c2c6e32e13a/build.gradle#L43-L44
https://github.com/apache/incubator-iceberg/blob/720b240a3e6a32b6f01173ebcc448c2c6e32e13a/build.gradle#L82-L83
When I build with Java 13 environment it fails. We should document it at least in README.md.

Sounds good. Could you open a PR?

@rdblue Yep. I will open a PR a bit later.

Hi @rdblue I've created a PR. Could you have a look?


Bugs with input

There are multiple bugs when using input on mobile: I tested with (safari)

When clicking on input, the keyboard comes out as it focuses the input, however the input stays behind the keyboard until I start typing.
After inputting something and clicking done on the keyboard, the position of the drawer doesnt return to the bottom and hangs.

https://github.com/emilkowalski/vaul/assets/101852870/6bed9a64-9f93-4113-8453-36074b8199c3

Are you using the latest version? If so, can you provide a codesandbox with reproduction? Also, which phone and browser are you using?

I changed the styling abit and it works fine now. previously the header was sticky, I remove it and add also changed the padding bottom to another layout component, sorry for bothering! I will raise another issue if it still occurs! Thanks so much for making this btw!🙏

@khairulhaaziq This is fixed in #56, I'll release a new version soon!

Thanks! Hugely grateful for your work!


Updated invalid reset password error message

Description

Updated error message shown when reset link fails in updating the password.

Fixes # (issue)

Fixes issue #781

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update

How Has This Been Tested?

Changed the token in reset password link so it fails.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@akshay11298 Thanks for making the required changes. I don't know why Github is showing me 161 files changed (even though you only changed 2 files). I'm assuming you pulled the latest release code into your own branch right?
To ensure correctness, would it be OK to close this PR and for you to open another one from a fresh branch? I'm a little concerned in merging 161 changed files.

@mohanarpit yes, I pulled the latest release and merged. Sure I will create a new branch and PR


remove ceph resorces forcefully when client is deleted

Epic: https://issues.redhat.com/browse/RHSTOR-5698

In the case of HCP, a cluster can be deleted on the fly, and PVs can remain on the provider's side, so we need to remove them forcefully.
What API do internally

This API takes the name of the storage consumer as input, adds an annotation to the storage consumer resource, and deletes the storage consumer.
Storage Consumer is responsible for reconciling based on the added annotation and it then adds annotation back to the storage request.
Storage Request is responsible for reconciling based on the added annotation and adding an annotation to Ceph resources. That forcefully cleans the resources.

I had a couple of questions:

If we are adding an annotation will it trigger a reconcile for the storageClassRequest and remove the annotation from the storageClassRequest controller?
If we are adding an annotation to the ceph CRs will it also delete the ceph CR or just the underlying resources in ceph?

Adding annotation won't trigger deletion of storage class request. Once the annotation is added  then I am calling delete on the storage consumer. Storage consumer is the owner of storageclassrequest it will take care of deleting that.
Good question I am not sure on what all resources it will delete let me check with Santosh Pillai and get back to you

/hold Keeping on hold because I have not tested this change.

@rchikatw Thinking about this endpoint again. Why do we need it in the first place? Why can't the UI call delete on the storageconsumer resource?

@rchikatw Thinking about this endpoint again. Why do we need it in the first place? Why can't the UI call delete on the storageconsumer resource? The current implementation is basically just a proxy to k8s delete anyways.

so is the earlier rotate-keys endpoint, Bipul also raised the same concern, the only reason that we are still going w/ these endpoints is to support API calls from other operators (aka HCI) which may not use UI.

superseded by #2563

superseded by #2563


Negative answers in subtraction always result to '-1'

Describe the bug
Any subtraction operation that results to a negative number always show -1 as the answer.
To Reproduce
Steps to reproduce the behavior:

Subtract two numbers. The first one should be smaller than the other (0 - 9 = -1)

Expected behavior
0 - 9 = -9

Resolve with the new push


Table Based Transition

It will be useful to have a table based transition. For example, see: https://github.com/OSEHRA/Synthetic-Patient-Data-Project
This project is attempting to create transition probabilities based on patient race, gender, and age. This creates many many states and a confusing graph. It would be simpler to create a single state with a table based transition.
 So, in the example above, a white male aged 13 with the other attribute values would have a probability of 0.8 (or 80% chance) to transition to state1.

:+1: , especially if it can reduce to the equivalent of a switch/case statement

Alternative implementation proposal: add lookup tables with the ability to set one or more attributes based on that lookup table, and then use the existing "named transition" concept for transitions. There are a lot of places that lookup tables could be useful beyond just transitions (notably some of the areas we currently have hardcoded in the java code instead of in gmf modules -- vital sign ranges, calculations like the framingham points system, etc) and this would be a good opportunity to add something that could be useful there.
After thinking about this occasionally over the past 3 months, I'd actually prefer not to add a separate new table transition type, even though I do think there is benefit in terms of simplifying certain areas. A few reasons:

It adds no new power or capability compared to the current complex transition.
It would require a lot of UI work when we don't have a lot of UI developer time available
Not all logic types map cleanly to this concept -- how would the "And", "Or", "At Least", etc condition types work? So it would need some concept of including/excluding logic types, possibly both in the UI and engine
It splits the logic into 2 places -- the "type" sits at the header of the table but different fields but there's an implicit or explicit "operator" and "comparison value" in the rows. It doesn't align super well with the current implementation of logical conditions. We'd have to either rewrite how logic works or duplicate or wrap every condition type just for this one transition.

I think adding lookup tables can cover everything you want to do with the table transition, plus adds additional capability that we could use elsewhere, so I'd push strongly to make lookup tables happen instead. It would still require UI work, but I suspect it would be simpler because the lookup table could just be a "dumb" plaintext-only grid.

It isn't about adding, it is about simplifying.
We're going to have this problem with every GMF change moving forward.
It isn't meant to.
True, it uses implicit operators. If a value is given, then equality. If a range is given, then within the range. It doesn't need to align with logical conditions.

Remember, this is about lowering the bar for those with a background in public health, epidemiology, and health research -- where many data sets and published results are reported in tables.
I'd argue this is a similar change to the one we made with Diagnostic Reports.
It isn't about adding power or making the most elegant software design, it is about catering to our target user groups.

@jeffeastman Do you see this approach being extensible beyond just Gender, Age, and Race? Those 3 probably do cover the majority of use cases, but being able to plug in additional risk factors like smoking status could be useful in certain cases.

I've implemented these tables with 3 classes: AgeLikelihoodRow, AgeLikelihoodTable & GenderAgeLikelihoodTable (GALT). You can see from the above that the gender table uses two age tables to achieve a third dimension of specification. I can imagine adding another class, maybe AttributeGenderAgeLikelihoodTable to allow a fourth dimension, but I've found that Conditional and Complex transitions using attributes are clearer. An example: in my Diabetes modules I use separate GALTs for each BMI range and use ConditionalTransitions to sample based upon the patient's BMI vital.
I've requested permission to release these classes and expect approval from MiHIN. Once this occurs I'll create a branch and make the other Synthea changes to integrate them into Logic.

This issue has been addressed with #528 -- thank you @RobertScalfani


streamalert - logs - vpc flow - flowlogstatus update

to: @ryandeivert
Details: http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/flow-logs.html:

3 possible values of OK, NODATA or SKIPDATA for flowlogstatus
For the latter 2, the schema accounts for '-' vs. integers

This updates all 3 schemas to use log_patterns
Testing
python manage.py lambda test --processor all
...
python manage.py validate-schemas

Coverage remained the same at 95.295% when pulling 3be55551e523b0b8c24664d806884509761d2553 on mimeframe-streamalert-logs-vpc-fix into 81044e1f9d2f91eb756f693278c4f71ad0db37ec on master.


Multi-ControlNet Speed Improvements

Implements Accelerate vectorized routines in ControlNet.swift, increasing execution times by 5.6x when using multiple ControlNets, as suggested by @atiorh in #212.
Before:
4.75 seconds / step
After:
0.84 seconds / step
Tested using Stable Diffusion 1.5 with lllyasviel/control_v11p_sd15_shuffle and lllyasviel/control_v11p_sd15_canny
M1 Max MacBook Pro 16
Thank you for your interest in contributing to Core ML Stable Diffusion! Please review CONTRIBUTING.md first. If you would like to proceed with making a pull request, please indicate your agreement to the terms outlined in CONTRIBUTING.md by checking the box below. If not, please go ahead and fork this repo and make your updates.
We appreciate your interest in the project!
Do not erase the below when submitting your pull request:
#########

[x] I agree to the terms outlined in CONTRIBUTING.md

I’m also working on a separate PR to add ControlNet strength weighting, which I’ve found to be very useful when working with more than one ControlNet model. Will try to have it up in next day or so.


Upgrade Node & NPM dependencies, fix NPM audit vulnerabilities

Closes #98
Changes

Upgraded to<EMAIL_ADDRESS>Pin engines to Node >=14 <17, NPM >=6 <7
Pin Volta to Node 16/NPM 6
Set up matrix testing for Travis CI to use NPM 14 and 16
Upgraded [sub-]dependencies for all outstanding security vulnerabilities
npm update for dependencies with semver-compatible upgrades
Upgraded other outdated dependencies:

eslint-plugin-jsdoc
mocha
xmldom

Upgraded Travis CI Ubuntu version to Xenial

Validation steps taken

npm clean-install
npm install with previous node_modules in place
npm audit shows 0 vulnerabilities
npm outdated shows 0 packages outdated (well, it shows a false positive for<EMAIL_ADDRESS>npm run test passes (this also includes npm run eslint-check)
npm run develop + manually check a transformation loads
temporarily npm install grunt; npx grunt-cli transforms before/after, with the same logic used in enketo-core to transform all the test fixtures, to verify they don't produce a diff
npm run build-docs before/after doesn't produce a diff (because my half awake brain read "jsdoc" in eslint-plugin-jsdoc and instinctively thought jsdoc, but perhaps useful as a sanity check)

It seems dangerous to have production dependencies like express and request auto update. Seems like these should be pinned?

They are pinned (everything is), in package-lock.json, which is automatically collapsed in GitHub PRs because it's expected to be machine generated. (This is of course a risk if it's updated by untrusted contributors.) Also, in both cases those dependencies should be using semver, and the ^ prefix means any updates we do make e.g. via npm update will be major-version compatible and should be expected not to have breaking changes.

Is there a good reason we support Node 14 and 16? Why not stick with 16?

In general the Node community tends to support current LTS releases where possible. I think that's a good policy unless there's a particular reason not to. Node 14 is expected to be Maintenance LTS until 2023-04-30.

xenial has passed the end of standard support from Ubuntu. Why not bionic or focal?

Good catch! I think this was a holdover from one of my zillion git stashes where I'd looked into getting a newer version of Chrome (in core/express), and xenial achieved that. I hadn't looked into what versions were actually available at the time. I did choose focal when I got around to opening enketo/enketo-express#298. I should update this, and enketo/enketo-core#798, to match.

I also see that npm audit shows new vulnerabilities since this PR was opened, so I'll address those where I can (and any in the core/express projects as well) while I'm revisiting this branch.

Okay! CI is now using focal, the new vulnerabilities have been addressed:

Manually updated pinned subdependency tar to latest semver-compatible version
Switched from xmldom 0.6.x to @xmldom/xmldom 0.7.x, see xmldom/xmldom#271

Awesome! The XMLdom change suggests that things should be validated again. Can you confirm npm run test|develop|build-docs does what you expect?

Awesome! The XMLdom change suggests that things should be validated again. Can you confirm npm run test|develop|build-docs does what you expect?

Validated these, as well as again validating there are no changes in the transforms. This is sort of a time consuming process, I think we may want to:

Add the transforms process to the project
Share test form fixtures between transformer and core (because core has some that transformer doesn't), or add core as a dev dependency to access both
Snapshot test transforms of all fixtures

That'll help us detect unexpected breaking changes much more rapidly. I'm not sure there's much benefit in applying the same to build-docs, those are likely to change quite frequently because significant portions are generated from JSDoc in source code.

@eyelidlessness Let's get this merged. Good ideas on the validations. Can you please file an issue so we don't forget. Doesn't feel like a priority at the moment, but it's your call on when that work gets done.

looks good!


Update browserify to 14.1.0 to support async / await

As per substack/node-browserify#1667 acorn is updated in the latest version of browserify so that async/await (now in Chrome AND node) is supported.

Yes please! It's blocking our workflow.

Thanks for the PR, and sorry for taking so long to merge.


RuntimeError: Sizes of tensors must match except in dimension 0. Got 0 and 300 (The offending index is 0)

When I was training my own data set with DN-DETR, I encountered the following problems,
how do I solve them?
Who can tell me, please?
@HaoZhang534 @SangbumChoi @FengLi-ust @LYMDLUT
Traceback (most recent call last):
File "D:\JetBrains\Pycharm_Project\Learn_Deep_Learning\DN-DETR\main.py", line 443, in
main(args)
File "D:\JetBrains\Pycharm_Project\Learn_Deep_Learning\DN-DETR\main.py", line 369, in main
train_stats = train_one_epoch(
File "D:\JetBrains\Pycharm_Project\Learn_Deep_Learning\DN-DETR\engine.py", line 53, in train_one_epoch
outputs, mask_dict = model(samples, dn_args=dn_args)
File "D:\Anaconda3\envs\DN_DETR\lib\site-packages\torch\nn\modules\module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "D:\JetBrains\Pycharm_Project\Learn_Deep_Learning\DN-DETR\models\dn_dab_deformable_detr\dab_deformable_detr.py", line 206, in forward
prepare_for_dn(dn_args, tgt_all_embed, refanchor, src.size(0), self.training, self.num_queries, self.num_classes,
File "D:\JetBrains\Pycharm_Project\Learn_Deep_Learning\DN-DETR\models\dn_dab_deformable_detr\dn_components.py", line 70, in prepare_for_dn
tgt = torch.cat([tgt_weight, indicator0], dim=1) + label_enc.weight[0][0]*torch.tensor(0).cuda()
RuntimeError: Sizes of tensors must match except in dimension 0. Got 0 and 300 (The offending index is 0)

I think it is the problem either your dataset wasn't load properly or lack of defining num_classes.

I think it is the problem either your dataset wasn't load properly or lack of defining num_classes.

I've already set num_classes.
There are some errors in torch.cat. How can I fix the code to solve the problem.

try to print the individual shape of each variable and debug it. Like i just said it seems to appear that tgt_weight is abnormal shape which is related to dataset preparation.
Or did you modified self.two_stage and self.use_dab constraint?

I didn't modified  self.two_stage and self.use_dab.
I'm thinking how can I modify and add a few lines of code to solve the problem


Fix release scripts

Update release scripts to account for the fact that:

calico/node doesn't use build.sh anymore
projectcalico/calico was renamed to projectcalico/felix

As discussed, I'm going to take over this PR


scene.pickPosition returns incorrect position

Reported on the forum: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/0E-aKBTLESk
The user created this sandcastle example to demonstrate the problem: http://hosting.virtualcitysystems.de/demos/temp/pickProblem/Apps/Sandcastle/?src=3D Tiles.html&label=undefined
The demo is using the latest 3d-tiles branch
pickPosition works fine if you run the example inside sandcastle, but if you click 'Open in New Window' sometimes the returned position sits in front of the building you clicked instead of where the click intersects with it.  Maybe it's related to the canvas ratio?  See the forum post for more details.
I couldn't reproduce this with any of our sample models, but I asked the user if he could share a tile for us to test with.

Here is the tileset which is used in the sandcastle demo: http://hosting.virtualcitysystems.de/demos/temp/b3dm
Here is a video which shows the behavior:  https://youtu.be/9twwwMHbjKU
And here is another that shows that it has something to do with the size of the screen: https://youtu.be/IbDNwqKVOik
And zooming : https://youtu.be/nJpHGOdTssY

3D tileset zipped: http://hosting.virtualcitysystems.de/demos/temp/b3dm/3dTiles.zip

Thanks @lucasvw!

I'll take a look at this soon.

Just to update this issue, it looks like this is related to inconsistencies with depth picking with multifrustum rendering, so it's a bug in the core engine. I still need to investigate more.

Is this going to be part of the bug-bash next week? +1 for yes ;)

@lucasvw  I marked us to at least look at it as part of the bash, but depending on how involved the fix is, I can't promise it will be resolved.  We'll try our best!

@mramato @lilleyse do you perhaps have an idea when you will be able to fix this ?

Sorry about the delay, I will spend some more time looking into this.

That would be great! Thanks a lot @lilleyse

@lilleyse I barely dare to ask... but eh.. any updates on this ?
;)

Sorry but not yet. I did find a slight bug with the calculated pick position (https://github.com/AnalyticalGraphicsInc/cesium/pull/4615) but it didn't solve the problem unfortunately.
If I remember correctly the core issue here is that Cesium uses multi-frustum rendering and when the pick position is calculated it looks to see if a depth exists starting from the first frustum. The problem is that each frustum may have a different depth at that pixel and it doesn't know which frustum to use. That's just a theory though, but it could be tough to solve. I promise I'll get to this eventually.

Thanks for the update and the explanation!

In looking at this while debugging #4855, I saw a case where I had only a single frustum, and yet the position returned by pickPosition was wildly wrong.  For example, values in pickGlobe in ScreenSpaceCameraController.js:

So I don't think it's necessarily multi-frustum related.

Our "pick position" Sandcastle demo limits your picking to just a 3D model of the milk truck.  Check out what happens if you open it up to allow picking the entire globe.  It works at close range to the truck, but the more you zoom out, the worse it gets.

var viewer = new Cesium.Viewer('cesiumContainer', {
    selectionIndicator : false,
    infoBox : false
});

var scene = viewer.scene;
var handler;

var modelEntity = viewer.entities.add({
    name : 'milktruck',
    position : Cesium.Cartesian3.fromDegrees(-123.0744619, 44.0503706),
    model : {
        uri : '../../SampleData/models/CesiumMilkTruck/CesiumMilkTruck-kmc.gltf'
    }
});
viewer.zoomTo(modelEntity);

var labelEntity = viewer.entities.add({
    label : {
        show : false,
        showBackground : true,
        font : '14px monospace',
        horizontalOrigin : Cesium.HorizontalOrigin.LEFT,
        verticalOrigin : Cesium.VerticalOrigin.TOP,
        pixelOffset : new Cesium.Cartesian2(15, 0)
    }
});

var sceneModeWarningPosted = false;

// Mouse over the globe to see the cartographic position
handler = new Cesium.ScreenSpaceEventHandler(scene.canvas);
handler.setInputAction(function(movement) {
    var foundPosition = false;

    var scene = viewer.scene;
    var pickedObject = scene.pick(movement.endPosition);
    if (scene.pickPositionSupported) {
        if (scene.mode === Cesium.SceneMode.SCENE3D) {
            var cartesian = viewer.scene.pickPosition(movement.endPosition);

            if (Cesium.defined(cartesian)) {
                var cartographic = Cesium.Cartographic.fromCartesian(cartesian);
                var longitudeString = Cesium.Math.toDegrees(cartographic.longitude).toFixed(2);
                var latitudeString = Cesium.Math.toDegrees(cartographic.latitude).toFixed(2);
                var heightString = cartographic.height.toFixed(2);

                labelEntity.position = cartesian;
                labelEntity.label.show = true;
                labelEntity.label.text =
                    'Lon: ' + ('   ' + longitudeString).slice(-7) + '\u00B0' +
                    '\nLat: ' + ('   ' + latitudeString).slice(-7) + '\u00B0' +
                    '\nAlt: ' + ('   ' + heightString).slice(-7) + 'm';

                var camera = scene.camera;
                labelEntity.label.eyeOffset = new Cesium.Cartesian3(0.0, 0.0, camera.frustum.near * 1.5 - Cesium.Cartesian3.distance(cartesian, camera.position));

                foundPosition = true;
            }
        } else if (!sceneModeWarningPosted) {
            sceneModeWarningPosted = true;
            console.log("pickPosition is currently only supported in 3D mode.");
        }
    }

    if (!foundPosition) {
        labelEntity.label.show = false;
    }
}, Cesium.ScreenSpaceEventType.MOUSE_MOVE);

@emackey

I think it worth to add scene.globe.depthTestAgainstTerrain = true; to your sandcastle code, because this is not the default.
pickPosition returns different values on terrain if depthTestAgainstTerrain = false (maybe the DepthPlane?, I didn't get into this).

the height string in your example code is truncated so it shows wrong height.
for example: -143976.41485355987 becomes 3976.41.

I'm not sure that the 'jittering' in your animation is due to the pickPosition results. On my machine, If I set eyeOffset.z to a fixed number I can't reproduce this.

If you debug this compared to Globe.pick remember that it has its own issues (#3423).

What GPUs/Browsers does everyone run into this on? I get this pretty consistently on a discrete AMD GPU, which makes me think that @kring idea (caught up with the zoom issues which were exacerbated by this issue) that it's depth buffer related with AMD cards may have something to do with it.

@lilleyse
After some hours of debugging i found a possible solution for this.
The problem is that scene.pickPosition sometimes returns a negative height value if used in combination with scene.pick.
I noticed that the number of frustums in the pickPosition rendering pass differs from the number of frustums in the normal rendering update, when pickPosition delivers a corrupt result.
After some digging I figured that the scene.pick function changes the framestate cullingVolume which is then also used from the pickPosition function.
So when I use the pickPosition function without calling any scene.pick() in the same frame, pickPosition will use the cullingVolume from the last rendering pass and delivers the correct position result.
var viewer = new Cesium.CesiumWidget('cesiumContainer', {
        scene3DOnly : true,
        shadows : true
    });

    //var viewer = cesium.getViewer();

    var scene = viewer.scene;

    viewer.camera.up = new Cesium.Cartesian3(0.602242291265668, 0.47745810596428245, 0.6397952638618689);
    viewer.camera.direction = new Cesium.Cartesian3(-0.09199309329813982, 0.8376012488044867, -0.5384806577646075);
    viewer.camera.position = new Cesium.Cartesian3(3785056.8752774675,<PHONE_NUMBER>953185, 5037174.477028298);

    var tileset = scene.primitives.add(new Cesium.Cesium3DTileset({
        url : 'https://d35ei6ur3bjvr1.cloudfront.net/berlin/3c2a32d3-633c-462d-b79c-7215dcfbc44f',
    }));

    var dataSourceCollection = new Cesium.DataSourceCollection();
    var dataSourceDisplay = new Cesium.DataSourceDisplay({
          scene : scene,
          dataSourceCollection : dataSourceCollection
        });

        var clock = viewer.clock;

        var eventHelper = new Cesium.EventHelper();
        clock.onTick.addEventListener(function(clock){
          var time = clock.currentTime;
          dataSourceDisplay.update(time);
        }.bind(this));

    // Mouse over the globe to see the cartographic position
    var handler = new Cesium.ScreenSpaceEventHandler(viewer.scene.canvas);
    handler.setInputAction(function(click) {
        var foundPosition = false;

        var scene = viewer.scene;
        var pickedOject = scene.pick(click.position);
        if (true) {
            var position = viewer.scene.pickPosition(click.position);
            var carto = Cesium.Cartographic.fromCartesian(position);
            console.log('pos' + carto);

            if (Cesium.defined(position)) {
                dataSourceDisplay.defaultDataSource.entities.add({
                    position : position,
                    point : {
                        pixelSize : 10,
                        color : Cesium.Color.YELLOW
                    }
                });
            }
        }
    }, Cesium.ScreenSpaceEventType.LEFT_CLICK);

With this Sandcastle code i could reproduce the corrupt height value if i click on the building in the center of the screen. If you just remove the line var pickedOject = scene.pick(click.position);  pickPosition works correct.

This helps a lot @jbo023.
So why does it matter that the pick pass renders lesser frustums if it is still writing out depth correctly? Is the pick depth-copy broken? Just questions I'm thinking about right now...

Hey all, it's been a year and I'm pretty sure that (at least the way I'm using it?) scene.pickPosition is still giving me hilariously-wrong results.  I'm passing the endPosition from a MoveEvent and getting back a point that, when converted to Cartographic, has a height in the negative millions.  Is there another way I'm supposed to get lat / lon point under the cursor on the rendered globe along with a relatively accurate height-above-ellipsoid?  Nothing is working...

@thw0rted this is for using pickPosition to pick the globe?  I would recommend using either scene.camera.pickEllipsoid if you don't have terrain or scene.globe.pick if you do have terrain.  pickPosition works great for getting the position on a 3D tileset or a glTF model, but we haven't had a chance to fix the globe picking issue.

I don't think I'm getting sane altitudes from any method.  For comparison, I made a quick SandCastle testbed.  Zoom pretty far out (at least so you can see the whole globe) then just kind of noodle around -- when I have North America in the center of the globe, I can mouse over the Amazon, near the edge of the visible globe, and get altitude values like -18000 m (!) for Globe.pick.  Most values are negative and the magnitude of the value tends to increase the further your view is zoomed out -- once you zoom in far enough, you start to see some positive values show up even outside of major mountain ranges.
The interesting bit is that Globe.pick gives massive negative altitudes even when the Ellipsoid terrain provider is used.  In theory, the values for Globe.pick and Camera.pickEllipsoid should line up every time, right?  I mean, if the globe is using the ellipsoid to model the mesh, and Globe.pick is based on a mesh/pick-ray intersection.  I guess what we're seeing is some "fudge factor" where the actual mesh is contained by the ellipsoid but doesn't actually reach it, since zooming in reduces this discrepancy and eventually removes it -- zoom in to maybe a state or city-sized region and the Globe.pick altitude shows up as (negative) 0m.  Using the Ion terrain provider changes the numbers somewhat, but the trend (more negative when zoomed out further) remains.
All that to say: am I making a mistake somewhere, or is it just not possible to get a realistic terrain-height-under-cursor right now?

@thw0rted that is expected behavior.  Globe.pick is retrieving the height of whatever terrain LOD is currently visible on the globe.  When you're zoomed out far, the terrain tiles are very low resolution, hence the negative altitude values.
TerriaJS (a library that uses both Cesium and leaflet) has a mouse over coordinate tool that does a fast approximation of height using globe.pickTriangle, then gets the actual terrain height using sampleTerrainMostDetailed.  It displays the approximate height until the result from sampleTerrainMostDetailed is returned.  I would recommend doing something similar.  See https://github.com/TerriaJS/terriajs/blob/master/lib/ReactViewModels/MouseCoords.js

I was looking at something similar on my own, actually, but it turns out the provider I'm using at the moment (an older in-house Google Earth server) doesn't support availability and that's required for sampleTerrainMostDetailed.  I could use sampleTerrain but I didn't know a good way to guesstimate the appropriate level to pass, so I put it on the back burner.  I just want to know how tall stuff is :-/

See https://github.com/AnalyticalGraphicsInc/cesium/issues/6990 for a great code example.  pickPosition works decently well on the ellipsoid when globe.depthTestAgainstTerrain = true but doesn't work at all otherwise.

For others who find this bug because pickPosition is wildly inaccurate and seems to change based on the camera position, on my system (Linux / Firefox / nvidia) the entire problem turned out to be CanvasBlocker intentionally tampering with the WebGL APIs that Cesium uses to query the depth buffer to prevent that from being used for fingerprinting.

@jbo023 Thanks for that analysis. It has been a couple years since your post, but I ran into something similar with Cesium 1.58, calling drillPick and then pickPosition right after with incorrect results.  Luckily I was able to just swap the order of operations to work around it.

I faced the same issue. Tried to use globe.depthTestAgainstTerrain = true but all entities that were on the surface dive into it now. The only solution that I can see at this moment is add height: 10 to all the surface entities to make them lying higher on the surface.

I faced the same issue. Tried to use globe.depthTestAgainstTerrain = true but all entities that were on the surface dive into it now. The only solution that I can see at this moment is add height: 10 to all the surface entities to make them lying higher on the surface.

@ggetz Hi, i am the guy from #11043
Video: https://twitter.com/peace_engine/status/1615317374009511937
You wrote "The workaround for your case would be to use either scene.camera.pickEllipsoid if you don't have terrain or scene.globe.pick if you do have terrain."
I understand the solution. Thanks a lot.
But don't understand how my actual code picks like 10 times the right position and than randomly 1 wrong position, then again like 10 times alright.
How is that possible? Shouldn't it return all positions right, or all wrong, but not both?

Hi @worldpeaceenginelabs, I think we're still trying to pin down the exact cause, however there are several possible contributing factors, such as the multiple render passes performed for rendering and picking, multiple frustums, and asynchronous terrain tile loading.

@ggetz hmm, thats bad. This bug and the "touchscreen two finger pinch flip" bug are there for years now.

Does the Cesium staff not work on this repositories? Is it completly community dependant?
Is the Cesium company still successful or on a way down? (asking to estimate the actual motivation behind CesiumJS)

Could i donate money to someone for making this two bugs a high priority?

Is the solution you gave me mature enough that i can go into production?
I am a bit afraid of these unsolved bugs coming up while in production... (they are the only ones i found while testing, and they really su##...) 😅

@worldpeaceenginelabs I understand the frustration with these long-running bugs. I'm assuming you're also referring to https://github.com/CesiumGS/cesium/issues/4363?

Does the Cesium staff not work on this repositories? Is it completely community dependent?
Is the Cesium company still successful or on a way down?

Cesium as a company has been growing, though we've been a bit of a victim of our own success with the amount of inbound and opportunity. As such, we've needed to prioritize accordingly. CesiumJS is still very much a cornerstone of Cesium, and where most of our growth and revenue comes from. We invested more resources in CesiumJS this past year in 2022. Though many of the recent improvements have been focused on modernizing the codebase rather than bug fixes, we're trying to tackle more user-facing improvements and bug fixes in the near future.

Could i donate money to someone for making this two bugs a high priority?

I'm checking if its policy to take donations. In the meantime, I noticed this rear its head in https://github.com/CesiumGS/cesium/pull/11033 which may end up affecting priority as well.

Is the solution you gave me mature enough that i can go into production?

IMO yes. pickPosition and globe.pick/camera.pickEllipsoid work through different mechanisms.

Possible fixes discussed in https://github.com/CesiumGS/cesium/issues/8179.

Thank you @worldpeaceenginelabs for the kind offer, but we cannot accept donations. We happily accept contributions from the community, including fixes and test cases. Additionally, we do consider service engagements that benefit the community as a whole. If that sounds applicable to your case, please fill out our contact form with any details and someone can follow up with you: https://cesium.com/contact/.

@ggetz Thanks a lot for this easy solution. And thanks for clarifying your motivation.
My last offtopic comment, since i got you here 😈 (Cesium staff member):
Really no offense, but i had always the impression of Cesium priotizing ION over "how to run your own map-tile server"(the answers to this topic on the cesium community page are very sparse), which is a legit business model. 😁
But i have the impression of a chicken / egg situation:

Cesium is the only cool open-source solution out there, but not mainstream yet. (Unreal and Unity for Cesium are big steps into that direction)

If Cesium would have two well presented video tutorials, one "how to start and configure the globe in js" (kinda like this well commented Cesium globe with basic functions), and second "how to run your own map-tile server" (kinda like this), there would be a strong increase of devs (to use cesium is actually easy as soon as you know how to fetch coordinates and render on them)

Which in turn increases the chance of one or multiple devs developing killer apps based on Cesium, which would make Cesium become mainstream.

 This is your new customers.
But now in the number of a mainstream open-source library for world class digital globes 😜

Related issue: https://github.com/CesiumGS/cesium/issues/11031

https://github.com/CesiumGS/cesium/issues/11031 is likely caused by this issue directly, but only arose after the Model refactor changed how point clouds were handled.
There are some good debugging notes from @UniquePanda in that issue.

您的邮件我已收到，会尽快回复。亲

Also reported in https://github.com/CesiumGS/cesium/issues/11313.

您的邮件我已收到，会尽快回复。亲


fix: Parse allowed metadata values correctly

This allows the user to set @expires and @collections in the metadata.

Pull Request Test Coverage Report for Build 59f533fa75ec747254d485f0aadcf72922acf759-PR-7

8 of 11 (72.73%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.07%) to 67.181%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ravix_ecto/parsers/query_parser.ex
6
7
85.71%

lib/ravix_ecto/raven_executor.ex
2
4
50.0%

Files with Coverage Reduction
New Missed Lines
%

lib/ravix_ecto/raven_executor.ex
1
94.74%

Totals

Change from base Build 2b3478a2e542603641fcf5b33235f2ea1dd8fe91:
-0.07%

Covered Lines:
348

Relevant Lines:
518

💛  - Coveralls


featurens: Ensure RHEL is correctly identified

When trying to identify various RedHat releases, RHEL was not being
picked up as a centos release because the Oracle Linux regex was too
permissive: it would match any release name with ' Linux
Server release' in the name. By being more restrictive with the Oracle
regex, RHEL is now properly identified.
I don't know why the Oracle regex used such a permissive matcher for the
name but it still passes all the tests by replacing it with the word
'Oracle'.
Fixes #436

Is there anything stopping this from being merged? Would you prefer to look at the /etc/os-release file?


ActionsModule

Added Actions module with two simple actions: SwitchAction and ButtonAction.
User can add these actions for any custom debug options. Action contains name and callback. SwitchAction saves its value to SharedPreferences.
This module was useful for me in my own project so I decided to share it. It might be useful for some cases.

Great! Looks like really useful module. Thanks for contributing!


521 bmi computation

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #521
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Release | Other)
Checklist

[x] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[x] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[x] I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

I'm working on the code in this PR, will refactor bmi category and change abbreviations to camelcase (with no all uppercase) then push by my eod...


Add option to disable OptionButton menu item shortcuts

Fixes https://github.com/godotengine/godot/issues/80201

maybe adding a new menu menu item and assigning it's shortcut or creating a new shortcut menu item will not work by default if i removed this line and will require to set shortcuts enabled with an extra line of code , should i really remove it ?

Added a more descriptive title to the PR, would be good to have the commit message have an equally descriptive one, remember that it's better to describe what is done rather than what problem is fixed

this is the main reason why i have added this fix

void OptionButton::shortcut_input(const Ref<InputEvent> &p_event) {
	ERR_FAIL_COND(p_event.is_null());

	if (disable_shortcuts) {
		return;
	}

	if (p_event->is_pressed() && !p_event->is_echo() && !is_disabled() && is_visible_in_tree() && popup->activate_item_by_event(p_event, false)) {
		accept_event();
		return;
	}

	Button::shortcut_input(p_event);
}

Then I'd suggest:
Add shortcut handling to `OptionButton`

Also adds option to disable shortcuts

As the commit message

@AThousandShips choose whatever you like, just describe it to be addressed correctly in the list of fixes in godot 4.2

No, but I don't think the current message is very helpful, as it doesn't specify what has been fixed, i.e. that no handling exists period

ok i will change it and remove the extra line that enables the enabled variable again, we also may need too change it later in MenuButton too, just remember to mention it when someone changes their files in a pull request

You can wait until CI has finished to reduce time in next run, as it caches some of the results

On the surface it looks correct as it mimics similar logic from MenuButton. Still, could you provide a test project that you've used to validate the change?

i have noticed the issue while working on Editor in c++, for example CanvasItemEditor is using MenuButtons with shortcuts for snapping options, but when you try to use the OptionButton with shortcuts it doesn't work because it was missing shortcut handeling function.
this single line will work fine with MenuButton's PopupMenu while it won't work with OptionButton's PopupMenu

select_popup->set_item_shortcut(TOOL_SELECT, ED_SHORTCUT("canvas_item_editor/select_mode", TTR("Select Mode"), Key::Q));

This is how i tested it, which will be hard to be provided as test project at the moment since it's for godot-2d repo

also ignore that the shortcuts offset in tooltip are drawn with wrong offset, this is an editor theme issue and will try to fix it too.

have found this which may be helpful for testing, just create an option button and add this script to it then press Q and it will change the item

extends OptionButton

func _ready():
	add_item("test")
	add_item("test with shortcut")
	var sc := Shortcut.new()
	var ev := InputEventKey.new()
	ev.keycode = KEY_Q
	sc.events.append(ev)
	get_popup().set_item_shortcut(1, sc, true)

Thanks!


add in CONTRIBUTING.md and LICENSE.md files to learn new templates?

for the learn new templates, can we add in CONTRIBUTING.md and LICENSE.md files to each template?

oh wow, this has been done for a while. closing.


STM32: Add support for STM32L5 series and nucleo_l552ze_q board

This work add support for first STM32 Cortex-M33 based Series.
Support for board nucleo_l552_q is also added with minimum peripheral support for now.

@ioannisg , @MaureenHelm, thanks for the reviews and guidance. I've updated the changes.

@ioannisg Following discussion held above, (https://github.com/zephyrproject-rtos/zephyr/pull/23551#discussion_r406051580),I removed TRUSTED_EXECUTION_NONSECURE setting.

commit msg
Add support for stm32l5 socs on stm32 external interrupts driver

@FRASTM Fixed, txs

could have a line in the file header too (MP1 seems not here though)
STM32F0/STM32L0/STM32L4/STM32L5/STM32G0/STM32G4: Lines 0 to 15. Lines > 15 are not mapped on an IRQ

Done

@erwango I had a look, and removed my -1 on this, to make it go in for v2.3, but, I am confused regarding the objectives here: I see a single board target, now (a single defconfig). This target does not enable any of TRUSTED_EXECUTION_SECURE or _NONSECURE, so when building Zephyr , is this desirable?
I was more thinking you would like to have 2 board targets, here, one "default" to be used for zephyr test suites, and one strictly "non-secure", to build Zephyr as a Non-Secure RTOS (i assumed the latter would need TRUSTED_EXECUTION_NONSECURE=y, but if you managed to set the whole thing up without this need, then I 've got no objections. BTW, the "double board target" is used, no for nRF, Musca, and MPS2 platforms, see respective board definitions ).


index.6c2583f….js:17308 Warning: NaN is an invalid value for the left css style property. Check the render method of Image.

component:
<Image
         src={menu.photos.web}
          color={placeholderColor}
           loadingSize={30}
           alt={menu.name}
           style={{ minHeight: '143px', height: '100%' }
/>

I don't use a left css value. The progress spinner does.
left={style && style.width ? (style.width / 2) - (loadingSize) : styles.root.width / 2 - (loadingSize / 2)}
Try to fiddle aroudn with your style prop. 100% seems to provide null I guess
Otherwise this comp needs an update to the latest mui code.
ProgressSpinner has changed a lot.
I'll update it asap, let you know and we see if this fixes your issue.

I can't reproduce your error. Please try version 1.4.0 and post more informatino about your parent div. Seems to be an inheritance issue.


request.body is no longer nullish for body-less requests made from load's fetch during SSR

Describe the bug
As of version 1.0.0-next.151, request.body in the handle hook was nullish when the request had no body and was sent via load's fetch during SSR from some page.
As of version 1.0.0-next.152 (https://github.com/sveltejs/kit/pull/2215), it is now Uint8Array(0) [].
This is inconvenient when you want your handle hook to call fetch to proxy some requests, as you can no longer pass the request object as the second argument to fetch.
Reproduction
Starting from the sample app, update the handle hook as so:
export const handle = async ({ request, resolve }) => {
  console.log(request.body);
  // ...
};

Navigate to the /todos page (which makes API calls), and hit refresh to get a server-rendered page.
Logs
(in the above repro)
Uint8Array(0) []

(in my app)
Request with GET/HEAD method cannot have body
 TypeError: Request with GET/HEAD method cannot have body
     at new Request (file:///foo/node_modules/@sveltejs/kit/dist/install-fetch.js:1254:10)

System Info
System:
    OS: Linux 5.10 Debian GNU/Linux 10 (buster) 10 (buster)
    CPU: (8) x64 Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
    Memory: 5.92 GB / 12.32 GB
    Container: Yes
    Shell: 5.0.3 - /bin/bash
  Binaries:
    Node: 14.17.5 - /usr/local/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 6.14.14 - /usr/local/bin/npm
  npmPackages:
    @sveltejs/adapter-node: next => 1.0.0-next.43
    @sveltejs/kit: 1.0.0-next.152 => 1.0.0-next.152
    svelte: 3.42.3 => 3.42.3

Severity
serious, but I can work around it
Additional Information
We've previously blessed calling fetch in handle as a way to deal with API calls in SSR where the app server and the API server live in different places, but are both behind the same reverse proxy when seen from a browser.

I'm currently hitting this after implementing a proxy route for our graphql api, or at least using
"@sveltejs/adapter-node": "^1.0.0-next.45",
"@sveltejs/kit": "^1.0.0-next.164",

Proxy route.
/** @type {import('@sveltejs/kit').RequestHandler} */

import { Environment } from '$lib/config/app-config'

export async function post(request) {
	const res = await fetch(Environment.apiURL, {
		method: 'POST',
		headers: request.headers,
		credentials: 'include',
		body: request.rawBody
	})
	const data = await res.json()

	return {
		body: { data: data.data }
	}
}


[SPARK-8670][SQL] Nested columns can't be referenced in pyspark

This bug is caused by a wrong column-exist-check in __getitem__ of pyspark dataframe. DataFrame.apply accepts not only top level column names, but also nested column name like a.b, so we should remove that check from __getitem__.

cc @marmbrus @davies

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

retest this please.

Merged build triggered.

Merged build started.

Test build #40879 has started for   PR 8202 at commit 8988661.

Test build #40879 has finished for   PR 8202 at commit 8988661.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #40887 has started for   PR 8202 at commit e61dd96.

Test build #40887 has finished for   PR 8202 at commit e61dd96.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Thanks!  Merging to master and 1.5


Add July newsletter

Change-type: minor
Signed-off-by: Lizzie Epton<EMAIL_ADDRESS>

@balena-ci I self-certify!


Error: System error: exec: "bash": executable file not found in $PATH

I found that harlequin and leap release of the docker image is severely broken and failed to run any command like bash, pwd.
Only tumbleweed release is working.
Console output below
hyz@Aspire:~$ docker run -i opensuse:leap bash
exec: "bash": executable file not found in $PATH
Error response from daemon: Cannot start container 91fccbf852b4884e4e5aeb38c577d16fb968eaf070c6fd2a33f9a1541b941e7f: [8] System error: exec: "bash": executable file not found in $PATH

hyz@Aspire:~$ docker run -i opensuse:leap pwd
exec: "pwd": executable file not found in $PATH
Error response from daemon: Cannot start container a254f472e2cb7836b1ca6969d6f9a12ad548e497d033a409af1224791f0a388c: [8] System error: exec: "pwd": executable file not found in $PATH

This has been caused by a bug on the build system of the Docker Hub (see this issue).
We reported the issue to upstream, in the meantime we will push the images to the opensuse/ namespace on the Docker Hub

As @flavio said, the build system for the official images on the Docker Hub appears to be having some problems. We've pushed the images to the opensuse/ namespace with the form opensuse/amd64:<version>. Sorry for the inconvenience.
If you have any images that are derived on library/opensuse (FROM opensuse:<tag>) then you can fix those as well by creating those tags like so:
% docker tag opensuse/amd64:leap opensuse:leap

We've also re-pushed the older tags to opensuse: while we investigate what we can do to fix this. :cry:

# docker run -ti opensuse:leap bash
Unable to find image 'opensuse:leap' locally
leap: Pulling from library/opensuse
Digest: sha256:8c49cb12499ba72f02791d6db3519a196aa3d9e8f485d3307c275eff9603c8ab
Status: Downloaded newer image for opensuse:leap
bash-4.3#

Seems to be fixed, closing.


Integrated terminal's error on command "bundle exec jekyll serve" (doesn't occur and works as expected in external terminal)

VSCode Version: 1.22.2
OS Version: Arch Linux | Kernel: x86_64 Linux 4.16.13-1-ARCH

Steps to Reproduce:

Run bundle exec jekyll serve (as normal user).

I'm filing the bug report because the error doesn't happen in gnome-terminal or xterm but only in the VSCode's integrated terminal. Plus, when the terminal is closed with ctrl+d this appears: The terminal process terminated with exit code: 14.
Does this issue occur when all extensions are disabled?: Yes

This is probably related to environment variables, can you try adding this setting?
"terminal.integrated.setLocaleVariables": true

Yeah, it was a Locale issue. A reboot later gnome-terminal too stopped working but setting up the locale and regenerating it brought both one's back.
What does "terminal.integrated.setLocaleVariables": true actually do?

@akshaykhobragade glad it's fixed! setLocaleVariables tries to set a good $LANG environment variable value based on the app locale:
https://github.com/Microsoft/vscode/blob/ab21dfa0a9c56e05f3f4f380f16d4b1b673961a2/src/vs/workbench/parts/terminal/node/terminalEnvironment.ts#L91-L122


Added support for Endeavour OS as arch

Submit Checklist (REMOVE THIS SECTION BEFORE SUBMITTING)

[x] I have selected the next branch as the destination for my PR, not main.
[x] I have listed all changes in the Changes section.
[] I have filled out the Issues section with the issue/discussion link(s) (if applicable).
[x] I have tested my changes.
[x] I have considered backwards compatibility.
[x] I have removed this checklist and any unused sections.

Changes
Added the Endeavour OS as a Arch type so that install does not just "fail" when running it

Thank you for the PR 💜.


Duplicate Install Command Entry in Table.

The last table on the page has an install command entry twice in the same table.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ffd521ea-089c-001c-ad4f-e1bfc6f94285
Version Independent ID: e3d308c4-f527-a202-55ea-249d9ede8e99
Content: Install the Remote Desktop client for Windows on a per-user basis with Intune or Configuration Manager - Azure
Content Source: articles/virtual-desktop/install-windows-client-per-user.md
Service: virtual-desktop
GitHub Login: @dknappettmsft
Microsoft Alias: daknappe

@FrankFromHR
Thanks for your feedback! We will investigate and update as appropriate.

@FrankFromHR
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Helm upgrade process

Hey, first of all - amazing work. I definitely plan on becoming a contributor (sidenote: I would love to see a list of issues that would suggest what I could start contributing to).
I just used the nx plugin to scaffold the code for the input and button to get a feel for the library, and immediately I started  wondering how I should use/extend the button for example.
Let's assume I want to add a [loading] input to all my buttons. If I add it directly to the generated helm button, I assume I will run into problems in future versions if I rerun the generator?
Or will there be nx migration scripts?
Or in other words, can you elaborate how the upgrade process will look like?

I played around with it a bit and also read up on shadcn and figured it out. It seems the idea behind shadcn (and therefore behind spartan) is to have full control over your component library, meaning you own your code, but that also comes with the downside of having to manually change it whenever updates to shadcn/spartan appear.
I'll get to coding then :) let me know if there's anything I can contribute and maybe also where to find a list of tasks.


Develop a plan for a more all-inclusive NodeJS client

Right now, @aspnet/signalr is usable in NodeJS, but it requires numerous global polyfills. We should come up with a plan for a more "all-inclusive" Node JS client. This may just be logic/behavior in the existing client, or we could build a new @aspnet/signalr-node package that bundles @aspnet/signalr with additional polyfills (and pre-configures them).
Things to figure out:

[ ] What polyfills should we use?
[ ] How should @aspnet/signalr allow injecting polyfills. I'd like to avoid depending upon globals, so should IHubConnectionOptions have a webSocketConstructor parameter, etc.?
[ ] How should we package the client?

What polyfills should we use?

We shouldn't polyfill anything. Or rather, lets not call it that. We abstract things a bit more and have node implementations and browser implementations.

How should @aspnet/signalr allow injecting polyfills. I'd like to avoid depending upon globals, so should IHubConnectionOptions have a webSocketConstructor parameter, etc.?

You mean IHttpConnectionOptions right? I think it's fine to hang the factories off there

How should we package the client?

I think a separate package.

We should ensure that the WebSocket and EventSource abstractions we use take the accessToken value. NodeJS-based implementations would be able to actually encode this in a header, which would be more desirable.

This is also effectively a pre-req for https://github.com/aspnet/SignalR/issues/2048 since the tests run in Node

So socket.io just directly depends upon the ws WebSocket polyfill library: https://github.com/socketio/engine.io-client/blob/1cfae04a13ad43c9644231698f51f101ab1d19c7/package.json#L35

I did some research and thinking on ways to handle this. I listed a few approaches below. I think we should just go head-first into this and do the 4th approach before (one library that works in node and browser). It's a little more work for us, and it does mean that extra packages are downloaded on install, but I think the clean experience is worth it.
Approach 1: Global Polyfills
We do nothing. We already have HttpClient to abstract XMLHttpRequest, and Node users can install polyfills into the global WebSocket/EventSource
Pros:

No work for us to do!

Getting WebSockets to work in Node requires installing a global which is Bad
Unit Testing is hard because we have to install globals, which risks cross-contamination

Approach 2: Manual, non-global polyfills
We add options to IHttpConnectionOptions to provide a WebSocket constructor function and an EventSource constructor function. Users can pass a Polyfill in to that and we'll use it instead of the global. We can provide HubConnectionBuilder methods to configure them
Pros:

Users can install polyfills without polluting global scope
Our unit tests don't have to pollute global scope

Cons:

Users still have to find and configure polyfills

Approach 3: @aspnet/signalr-node library
This is based on Approach #2. We add the options to IHttpConnectionOptions as TypeScript @internal fields, which means they don't show up in the docs. We build a '@aspnet/signalr-node' library that depends directly on @aspnet/signalr, as well as WebSocket and EventSource polyfills and stitches it all together.
Pros:

Users don't have to find an configure polyfills

Cons:

Separate library, which is confusing and seems unnecessary in JavaScript
Users can't easily swap out Polyfills, but since we still have the undocumented options on IHttpConnectionOptions, they could swap them out in theory.
Properly stitching it together is actually not trivial since we need to "override" logic in HubConnectionBuilder. It's doable, but a little funky and might involve exporting a different HubConnectionBuilder out of @aspnet/signalr-node that wraps the one in @aspnet/signalr.

Approach 4: One band, one sounds, one library
We just have the one library. The library takes a direct dependency on the polyfills we want to use. However, we still "detect" the browser and use the browser-native versions if they are present and we only require the polyfill if we aren't on a browser. Also, this is what socket.io does in their engine.io-client package (engine.io is their lower-level transport abstraction, like our Http.Connections)
Pros:

Everything just works in the single library.
The world becomes a better place, one bit at a time.
Dogs and cats live together in harmony.

Cons:

Again, users can't easily swap out the polyfills, but we could make them configurable, and even document it.
More complex logic for us, but honestly, it's not much more than Approach #3
New third-party dependencies, but we wouldn't need to bundle them for the browser version since they aren't needed there. Would need to see how WebPack and friends are affected, but I think this pattern isn't uncommon.
Users have to download the WebSocket and EventSource polyfills when npm installing, even if they don't plan to use them.

I was leaning towards 3 but then I saw this https://www.npmjs.com/package/socket.io-client, now I think 4.

We're going with Approach 4. Closing this out and creating specific issues for the work


adds support for query parameters

Summary

This PR adds support for the new SQL parser that is able to interpret placeholders (?) and replace them with query parameters that come from the request. You can now perform the following queries:

GET /query?statement="select * from my_table where id = ?"&params=1
POST --json '{"statement": "SELECT * FROM my_table WHERE counter = ?", "params" : [1], "unwrap": true, "extract": true}'  /query

If you want to provide multiple params values, you just repeat the params with new values. For example &params=1&params=2&params=3. And if you want to provide a string, you gotta enclose it &params="3".

This PR depends on tablelandnetwork/go-sqlparser#388 and tablelandnetwork/docs#198

Context
The context for this PR can be found at ENG-852.
Make sure you understand tablelandnetwork/go-sqlparser#388 and tablelandnetwork/docs#198 before reviewing this one.
Implementation overview
This PR changes a lot of files, but most of the changes are just a side effect of the main changes. Here's an overview on the most important changes:
Controller
The controller needed to be changed to capture the params query parameter. Both GET /query and POST /query were changed. The params is captured as a slice of string ([]string). In the case of the POST, since we have an []interface{} after the JSON is decoded into memory, we try to convert it to []string.
Resolver is now passed to the GatewayService
I made a change to make the resolver a dependency of the GatewayService. See the implication of this change here, here and here. The reason for that is that it makes more sense for the GatewayService to attach the parameters values to the resolver, than the storage layer. The storage layer is just responsible for executing the query.
The resolver is not a dependency of GatewayStore and is now passed in the Read method
We already mentioned how the resolver is passed to a GatewayService instead of GatewayStore. In order to build the final statement, we need to pass the resolver to the Read method. See it here:
The resolver implementation needs to implement GetBindValues() []sqlparser.Expr
We must implement the new method of our resolver (remember this? ). For that, we make use of PrepareParams that converts []string that comes from the controller to []sqlparser.Expr and store those values inside the struct. Here's how PrepareParams is used.
Review orientation

Start at internal/router/controllers/controller.go and understand the change made in the controller
Go to cmd/api/main.go and see how the resolver is now passed to the gateway and not to the storage layer then check the changes at internal/gateway/gateway.go
Check the internal/gateway/impl/gateway_store.go file
Check the pkg/parsing/readstatementresolver.go file
Check the changes made in the Go client (pkg/client/v1/readquery.go)
The changes in the other files are just to adjust to the changes explained above

@avichalp would you mind approving this again? i've updated with the correct parser version


Feature #302 - Display conclusion of issue to admins before users

[ ] Fix silly bug shown in screenshot

Regular admin page

Admin page when issue voting state is VOTING_FINISHED, but before issue is ended. (plz disregard vote status counter, is a silly bug)

This change requires some future work, but it can be merged now with no problems other than nuisances for the admins.
Merging these changes will introduce the following ~bugs~ features for admins only:

Admins will not be able to view their own votes if they reload the page while an issue is in VOTING_FINISHED state. Read 782a1a0 for more information.
The vote status will show <number of alternatives> / <number of qualified voters> when the issue is in  VOTING_FINISHED state. (A quick fix is to hide the vote status component while the issue is in this state, but this moves the whole interface around which is very weird behaviour)

IT WORKS


CALL LIST: Be able to append calls to the call list (JS)

When a user clicks the 'add to call list' button, append them to the Your Call List section below (without reloading).

Working on this tonight


reference line with today date

Hello
Can you please show us how to add a reference line (vertical line for today date)
Thanks

It isn't possible. See here for the reason: https://github.com/SimoneSilini/Reboot-Timeline/issues/5#issuecomment-528782068

ok bro what about extrat this with pdf ? is this possible ?
Thanks

This is not possible - This graph is based on the Google timeline chart, so the functions are limited to that library.


Fix the load script to reinstall polaris when needed

It was looking for setup.py but this has been replaced by pyproject.toml in the root of the repo.

Checklist

[ ] Testing comment in the PR documents testing used to verify the changes

Testing
I ran ./configure_polaris_envs.py and then sourced the load script.  As expected, I got:
$ source load_polaris_test2_chrysalis_intel_openmpi.sh
Loading conda environment
Done.

Reinstalling polaris package in edit mode...
Done.

Loading Spack environment...
Done.

Without this fix, we were not seeing Reinstalling polaris package in edit mode....


DropdownButton does not fill Gesture detector

https://b.corp.google.com/issues/151599231.
This is the minimum code to reproduce it
GestureDetector(
  behavior: HitTestBehavior.translucent,
  onTap: () {
    // Do some logging.
    print('tapped');
  },
  child: DropdownButtonFormField(
    items: [
      DropdownMenuItem(
        value: 'value 1',
        child: Text('option 1'),
      ),
    ],
    onChanged: (newValue) => print('newValue: $newValue')
  ),
),

Expected behaviour:
When the dropdown button is tapped, 'tapped' should be logged and the dropdown items are displayed.
The event should be combined, no exclusive of each other.
On a side note:
what we're trying to achieve is do logging when the dropdown button is tapped.
This is actually an alternative method of doing it. The preferable way is for DropdownButton(and DropdownButtonFormField) to have onTap callback. I am not sure what's the opinion on having such callback.

I think what's needed here is a "me too" onTap callback like https://api.flutter.dev/flutter/material/TextField/onTap.html

I'm the person who reported the bug.
If you guys don't mind, I can take a stab on this to accelerate the process.
Is it okay for me to say that adding onTap callback to DropdownButton and DropdownButtonFormField is the way to go?

If onTap is indeed the path that we're pursuing, can I extend this issue into also adding onTap to DropdownMenuItem?
We also need to do logging when user taps onto the item, and currently since there are already InkWell integrated, it would be cleaner to do so instead of wrapping DropdownMenuItem with GestureHandler(which also doesn't quite work as expected).

This is marked as a P1 in the upstream database, so I'm tagging it with the severe: customer critical label. @tjonganthony and @HansMuller if I'm wrong, please remove it. Thanks!

Yes, if possible we would like to get this sorted as soon as possible as it is considered as launch blocking when we are not able to do logging for event.
However, I can try pushing back a bit if you guys have different priority at the moment.

@tjonganthony Would you need this logging to be done on a tap down (pointer down), or on a tap (pointer down, followed by pointer up)?
The only worry I have is that users might get confused between using the onChanged and onTap callbacks since they sort of overlap in functionality, but we can always add an assert that if one is defined, the other shouldn't be and explain the use-case for each callback.

It should be "on a tap", as we only want to log a valid tap.
I think the confusion between onChanged and onTap would not be too hard as onChanged will have newValue as a parameter, while onTap should not have any parameter.  Correct me if I'm wrong, but I think both DropdownButton and DropdownButtonFormField can have both onTap and onChanged callback.
Maybe something that might be concerning is the order in which the callback is defined. My 2 cents is it should be this sequential order

DropdownButton.onTap or DropdownButtonFormField.onTap
DropdownMenuItem.onTap
DropdownButton.onChanged or DropdownButtonFormField.onChanged

Yeah that makes sense! Actually thinking about it now, having both defined should be okay, as long as we're very clear with what each callback actually does and when it's called.

One thing that would work for DropdownButton for now is using a Listener instead of a GestureDetector, since it does not participate in the gesture arena and gesture disambiguation:
      Listener(
        onPointerUp: (_) {
          // Do some logging.
          print('Log on pointer up');
        },
        child: DropdownButtonFormField(items: [
          DropdownMenuItem(
            value: 'value 1',
            child: Text('option 1'),
          ),
        ], onChanged: (newValue) => print('newValue: $newValue')),
      );

However, this wouldn't work on DropdownMenuItem since DropdownButton takes a DropdownMenuItem widget so there's no easy way to wrap them with a Listener.


Write additional information on 3.1, 3.x and master branches and how to do bugfixes

Use the wiki to include information on the current push process

Where do you plan to write this? a Contributing file? the wiki? or maybe the website when avalaible

When opening a pull request plus wiki


Issue with accessing ".sent" file in the code

Hey there, sorry to bother you. I am interested in your work. Now, I have obtained the original CoNLL09 data files, but when I run the script 'conll09_to_sent.py', I receive an error message "No module named 'conll_format_utils'". I searched through the code and README file but did not find any information about 'conll_format_utils'. I tried to install this module using the pip command, but this failed. I also tried to skip this step, but the ".tsv" files also need ".sent" files to produce. Could you please provide me with a link to download the 'conll_format_utils' module? Thank you for your help.

@yahui19960717
Thanks for letting us know.
The required file is now uploaded https://github.com/System-T/LabelAwareSRL/blob/main/conll_format_utils.py.
Please pull the latest commit.


Word-level timestamps are off after hotwords is setted

Hi, after the I set the hotwords for the model, word-level timestamps are off as follows:

How can I switch on word-level timestamps like this? I need the timestamps as precise as possible

Also, after I setted the hotwords, hallucination comes up. So is there any possible way to get rid of this hallucination?


Substate Multisig pallet and its MVP fontend

Project Abstract

This project implements a minimum viable functioning multisig product on a Substrate. The goal of this project is to eventually launch a multisig product that is integrated with Dora Factory's testnets and parachain.

dora-factory-multisig.md
For which grant level are you applying?

[ ] Level 1:  Up to $10,000, 2 approvals
[x] Level 2:  Up to $50,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for > $100k Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied, renamed ( dora-factory-multisig.md) and updated.
[x] A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
[x] I have read and acknowledged the terms and conditions.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[ ] The grant will only be announced once the first milestone has been accepted.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the application, @tinydjp. We will look into it as soon as possible. In the meantime: do you have any designs or wireframes for the UI you could add to the doc?

Hi, @semuelle we plan to work on the pallet implementation first, the design is still on the way, once we finalize, I'll let you know.

Thanks for the application!
I am trying to understand how much will your pallet differ from the current FRAME multisig module?
For example, how would Create wallet by organization work - i.e. what is it exactly that is not possible (or difficult) to do via the existing pallet, and how will you make it possible/easier?
It would be great if you could expand on these points for all your listed deliverables.

Hi @mmagician sorry for the late response, The reasons why build a new pallet are below

Multisig pallet only provides 3 methods, which can not meet requirements application-level and DAO use cases
The multisig pallet has not been updated for a while, we’ll implement more new features to help community to build a multisig pallet faster
The latest polkadot{.js} has removed feautres to support multisig, which makes this pallet hard to debug/demonstrate
As Dora Factory is working on DAO infrastructures, most of our users are organization users, we are creating a multisig for organization users (e.g. a DAO can deposit and manage funding using the pallet and get access to a broader range of applications from Dora Factory). In this way this pallet can integrate with other Dora Factory pallets seamlessly.

Hi @Noc2 , maybe our description mislead you guys, actually, our pallet will derive from the parity multisig pallet. Those functions are designed in the view of product. To be honest, current multisig pallet can fulfill our requirements in some way of other. We just want to make that pallet more user friendly so that developers know which methods to call at a glance. More precisely, our pallet development is to refactor the pallet, not to create a brand new one.  I think we can follow @semuelle 's suggestion, focus on the frontend first. As of the pallet, do you think is it necessary for us to do the refactor?

Hi @Noc2 , we just updated the application form, the requested fund also decreased due to the removal of pallet implementation. Would you mind reviewing again, thanks!

I’m closing the application for now due to inactivity. Let me know if I should reopen it.

Hi @Noc2 , hope it's not too late, we've just finished the MVP design, would you please help review again, thanks! The design link https://www.figma.com/file/NBavL709zClLkDMAqP1maR/Substrate-Multisig-Frontend-MVP?node-id=225%3A1575

@tinydjp Thanks for sharing the MVP design. It looks nice. I’m going to reopen the application. Could you please update it?

Hi @Noc2 I've just updated our doc. As for milestone 1, it's more meant to be our workload for the design. I'm not sure whether we should remove it and just provide you the final requested amount.

Thanks for you advice, we've decided to remain only 1 milestone, please help review our latest document.

Hi @alxs and @Noc2 , thanks for your review, we're ok with price. I've just updated the doc and request.


Patch for critical Openssl vulnerability

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
A critical vulnerability is incoming for OpenSSL 3.0.0 - 3.0.6
https://xeiaso.net/blog/openssl-3.x-secvuln-incoming
https://mta.openssl.org/pipermail/openssl-announce/2022-October/000238.html
Traefik should be prepared to scan containers for OpenSSL 3.0.0 - 3.0.6 and upgrade them to 3.0.7 as it becomes available
What did you see instead?
Insecure TLS lol
What version of Traefik are you using?
any version with openssl 3.0.0 - 3.0.6
What is your environment & configuration?
# (paste your configuration here)

Add more configuration information here.
If applicable, please paste the log output in DEBUG level
No response

As I understand it, updating to openssl-3.0.7 will be an absolute sprint to apply once it is disclosed Tuesday. Please be ready traefik team to update containers ASAP once the fix is dropped.

Hello,
we don't use OpenSSL, so we are not affected.

Ok... y'all missed the hint.
https://groups.google.com/g/golang-announce/c/dRtDK7WS78g
Go statically links openssl into it's standard libraries.  Resulting go binaries are statically linked as well.  You have a libsso.a in your traefik binaries.
"We plan to issue Go 1.19.3 and Go 1.18.8 on Tuesday, November 1."
tldr; any traffic compiled with go 1.19.x and 1.18.x are subject to this vulnerability.

Go statically links openssl into it's standard libraries. Resulting go binaries are statically linked as well. You have a libssl.a in your traefik binaries.

I'm not sure about that because Go implemented its own TLS library and doesn't rely on OpenSSL.
But it's possible that Go and OpenSSL have the same bug.

If that's the case, then yeah Traefik would be safe (as long as it isn't some overall design flaw). The fact that golang is updating for a private vulnerability could indicate a protocol design vulnerability though.
As for container packages, I confirmed libssl in the latest traefik container is:

libssl1.1-1.1.1q-r0 x86_64 {openssl} (OpenSSL) [installed]
That's too old to be in scope per what is known so far.

Anyway, as long as y'all are aware of its looming potential i'm happy.   If it's a server-side vulnerability, Traefik would be a prime target since it terminates SSL connections for a lot of infrastructure on the internet.

For the record, the Go security fixes being released tomorrow
are unrelated to the OpenSSL CRITICAL security patch release
that is by an unlucky coincidence also happening tomorrow.

https://groups.google.com/g/golang-announce/c/dRtDK7WS78g/m/T5pVQ7PoAQAJ


Where are the constant definitions that specify NET20, NET35, NET40, etc.?

Normally, one would define a VS constant on the Build page of a project, for example: NET40:

This constant is then saved into the .csproj file, and looks something like this:

These constants are used in code:

But I cannot find the constant definitions for NET20, NET35, NET40, etc.
Perhaps I'm missing something?

With the new SDK style project, and when multi-targeted, the Roslyn builder automatically creates those. See https://docs.microsoft.com/en-us/dotnet/standard/frameworks.


Comparison with CNN fixations

@marcotcr what do you think of https://ieeexplore.ieee.org/document/8537979

I have not read it. Also, this does not seem like an issue with lime's open source package : )


fix(travis): Move to new champagne cluster

Current coverage is 56.88% (diff: 100%)

Merging #87 into master will not change coverage

@@             master        #87   diff @@
==========================================
  Files            21         21
  Lines           508        508
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            289        289
  Misses          180        180
  Partials         39         39

Powered by Codecov. Last update 8669f8a...61c0864


Signup flow enhancements

This PR fixes minor issues in the signup flow.

Use the promise chain inside payment-info/route.js to update a progress bar after each promise resolves
Add more interesting plan information to payment method form
Refactor UI of credit card form
Add user navigation header to top of signup so a user can log out
Add current step indicator
Remove current plan dropdown and instead use a small toggle at the bottom.  The idea here is that the user should have already decided on a plan.

Also fixes #148

I'll look at this after our sync

Awesome.


Provide proper license details (copyright holder)

I know now, after reading your NuGet page, GitHub page and website, that this code is licensed under the terms of the MIT license.
But that linked text isn't a proper license, it's just a template. The license would need to contain a copyright holder. I'm about to use this library in a client's project which requires me to provide a proper license attribution. If you'd like me to call you "<COPYRIGHT HOLDER>", please confirm, because that looks like a strange name for a developer. But I'm happy to note that name in my license documentation if that's the case.

Looks like license.txt/copyright.txt never made it into this repository (AvalonEdit was originally part of the SharpDevelop repository).
The license text is also at the beginning of each source file.

@dgrunwald is avalonedit not MIT licenced?

The license is MIT.

I have added the LICENSE file explicitly with commit https://github.com/icsharpcode/AvalonEdit/commit/bc6ff4cd601a466acc2200e4ebb979c1b958a867.


Periodically refresh voters list

This will refresh the voters list every 30 seconds to keep it up to date. In addition, I started using /voters.json again until we can figure out what's wrong with the /voters page.
(revote of #510)

Needs another meritocracy approval @PlasmaPower @md678685

The meritocracy mention system is working, so that isn't necessary anymore.

Should "neutral" comment reviews override an approval? Currently they do.

Probably not.


[feature] cluster healthcheck

Is your feature request related to a problem? Please describe.
There is a long-standing problem. The EndpointWriter will restart/retrying to connect a unreachable member forever.
About the unreachable member, there are two cases.
case 1:  The member will be reachable later after network recover to normal or process restarted.
case 2:  The member is permanently leave after the cluster scaling down.
The retrying forever is works fine for case 1, but not suitable forcase 2. Some PRs  #369 #458 will fix case 2, but breaking case 1. So we need a feature to cover both of the two cases.
Describe the solution you'd like
healthcheck
Additional context
Maybe there should be an actor named /member in a cluster node. It can do something like healthcheck or heatbeat on behalf of member-self.

healthcheck

How to define healthy? 2 times heartbeats ok?
How to define unhealthy?  3 times heartbeats missing?

heartbeat :

What frequency is it sent to a healthy member?
What frequency is it sent to a unhealthy member?

Any suggests?

gossip contains this.


Bug with selecting the domain to which a policy applies

I have a tenant with several domains. Their names are like this - domain.com, another.domain.com, yetanother.domain.com, etc. If in the policy I put "domain.com" it applies to all other domains in the tenant as well. As if the filter is "recipientAddress -like 'domain.com'" instead of "recipientAddress -like<EMAIL_ADDRESS>
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

 That behavior could be by design. Your best bet is to open a support case to see what they say.

@badsector-82, I presume your talking about the Allowed Domains list or the Blocked Domains list? That behavior could be by design. Your best bet is to open a support case to see what they say.

No, I'm not talking about Allowed Domains list, or the Blocked Domains list. I'm talking about the list of domains, that the policy should be applied to. That's the first thing after the name, you have to choose when creating a new policy. Here's a screenshot to be more clear - https://i.imgur.com/vV4DdWB.png

@badsector-82, OK. That "Applies to" logic for domains should be the same for any/all types of policies.
If it's only working the way you describe for anti-spam policies, or it works the same for all types of policies, but you don't think it should work that way, then your best course of action is to open a support case.

@badsector-82 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Any idea how can we avoid this?
[ReuseBitmapDrawableCache] Cache hit
[ReuseBitmapDrawableCache] Cache hit
[ReuseBitmapDrawableCache] Cache hit from reuse pool
[ReuseBitmapDrawableCache] Cache hit from reuse pool
[SelfDisposingBitmapDrawable] OnFreeResources
[ReuseBitmapDrawableCache] Cache hit from reuse pool
[SelfDisposingBitmapDrawable] OnFreeResources
[ReuseBitmapDrawableCache] Cache hit from reuse pool
[SelfDisposingBitmapDrawable] OnFreeResources
[libc] heap corruption detected by dlmalloc_real
[libc] Fatal signal 6 (SIGABRT), code -6 in tid 19541
I/DEBUG   (  122): signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
I/DEBUG   (  122): Abort message: 'heap corruption detected by dlmalloc_real'
I/DEBUG   (  122):     r0 00000000  r1 00004c55  r2 00000006  r3 00000000
I/DEBUG   (  122):     r4 40090e38  r5 00000006  r6 0000000b  r7 0000010c
I/DEBUG   (  122):     r8 00000000  r9 41dcf600  sl 00000006  fp 00000006
I/DEBUG   (  122):     ip 00004c55  sp be9d5798  lr 401a4c81  pc 401cac04  cpsr 600f0010
I/DEBUG   (  122):
I/DEBUG   (  122): backtrace:
I/DEBUG   (  122):     #00 pc 0003cc04  /system/lib/libc.so (tgkill+12)
I/DEBUG   (  122):     #01 pc 00016c7d  /system/lib/libc.so (pthread_kill+52)
I/DEBUG   (  122):     #02 pc 0001789b  /system/lib/libc.so (raise+10)
I/DEBUG   (  122):     #03 pc 00014029  /system/lib/libc.so
I/DEBUG   (  122):     #04 pc 000124f0  /system/lib/libc.so (abort+4)
I/DEBUG   (  122):     #05 pc 00015367  /system/lib/libc.so
I/DEBUG   (  122):     #06 pc 00029ab1  /system/lib/libc.so
I/DEBUG   (  122):     #07 pc 0002b2c9  /system/lib/libc.so
I/DEBUG   (  122):     #08 pc 00012287  /system/lib/libc.so (malloc+10)
I/DEBUG   (  122):     #09 pc 00000c41  /system/lib/libstdc++.so (operator new(unsigned int)+4)
I/DEBUG   (  122):     #10 pc 00035421  /system/lib/libhwui.so (android::uirenderer::RenderProperties::updateMatrix()+24)
I/DEBUG   (  122):     #11 pc 0007f0cb  /system/lib/libandroid_runtime.so
I/DEBUG   (  122):     #12 pc 000b3ac3  /data/dalvik-cache/arm/system<EMAIL_ADDRESS>

We solved the issue by uncommenting the OnDetachedFromWindow method from ManagedImageView, because it looks the only place where NoLongerDisplayed event could be raised.

We need to fix that. I'll reopen the issue.

@SemyonL Could you test this https://github.com/molinch/FFImageLoading/commit/b23dad1ab790536365788826d78cd55a67f32a44?

@SemyonL That fix is included in 2.0.7-rc1 released, it would be really nice if you could give some feedback about the issue.

@daniel-luberda Just tested the latest source and no luck, still getting heap corruption. Dispose doesn't seem to work properly.

@SemyonL does it happen on a particular Android version or any?

@molinch It easily reproduced on nexus 7 with 5.1. However, on another 4.3 device after 5 minutes it doesn't crash.

Thanks I'll try with 5.1

So I tried on a simulated Nexus 4 and couldn't reproduce it.
I guess I will need a real device.
If you manage to run against git sources I'm pretty sure you will get valuable info.

@SemyonL Do you reproduce this issue in simulators as well?

@SemyonL if we don't get more feedback we cannot solve this. Could you help us?

@SemyonL I'll close this one. If you'll have any more details about it, feel fry to reopen it. I cannot reproduce it. Thanks.

Well, it happens here, too. Details? Use a lot of images in your app and your app will likely crash after some usage.

@bspinner  I have some image heavy apps and can't reproduce it. I'll need some help with it.

It would be awesome to have a sample that fails. Could you deliver one?

Well, problem went away after not setting MaxCacheSize. Maybe it should be renamed to MaxMemoryCacheSize... ... ...

@bspinner You are right, this name makes more sense. Changed https://github.com/luberda-molinet/FFImageLoading/commit/4beb8cf251140a038269325f08e22ac69b846d3a

When I use LoadingPlaceholder, application crashes with fatal signal 6
Without LoadingPlaceholder it works fine
Here is an example: http://www.filedropper.com/testffimageloading

Hi @molinch.
ImageService.Instance.LoadUrl(url, TimeSpan.FromDays(1000))

//.ErrorPlaceholder(placeHolder, ImageSource.CompiledResource)
//.LoadingPlaceholder(placeHolder, ImageSource.CompiledResource)

.DownSample(UIUtils.DpToPx(context, 42))
.Transform(new CircleTransformation())
.Into(imageView);

When I commented ErrorPlaceholder and LoadingPlaceholder methods, application works fine. Instead app crashes during fast scrolling in recycler view.

@djanri Well, that might be the reason our app is crashing, too.. :+1:


[Feature] Support Fault Tolerance in RayDP

Raydp should be able to recover/re-calculate data lost in ray as Spark does.

Initial support has done.


Added button styles for the date shortcuts

Added a few shortcuts to the of the timeline years. Added button styles to the shortcuts.

Please check the merge conflict

I got it figured out. Thanks for the collaboration!


Dependencies - Version Update

Bumps org.apache.struts:struts2-core from 2.3.1 to 2.3.37.

Commits

See full diff in compare view

Bumps com.fasterxml.jackson.core:jackson-databind from 2.9.8 to <IP_ADDRESS>.

Commits

See full diff in compare view

Bumps org.springframework:spring-core from 4.3.14.RELEASE to 4.3.30.RELEASE.

Commits

8e0d8f9 Release version 4.3.30.RELEASE
0b076b2 Remove duplicate "property" in PropertyCacheKey.toString()
0abb17a Polishing (aligned with 5.1.x)
d5a80d2 Polishing (aligned with 5.2.x)
07455c8 ContentCachingResponseWrapper skips contentLength for chunked responses
c45c672 Add Maven Central repository (aligned with 5.1.x)
aeb83fe Remove misleading default note on ISO.DATE_TIME
0bf002d Fix 401 errors from artifactory
4ff521d UrlPathHelper.removeJsessionid correctly appends remainder
9107aed Refined SqlParameterSource batchUpdate tests (plus related polishing)
Additional commits viewable in compare view


Replace np.matrix with np.ndarray (fixes #46)

numpy has deprecated the np.matrix class.
The most significant advantage of np.matrix is easy access to matrix multiplication.
As of py3.5, the matmul infix operator (@) has been available to do this with np.ndarrays.
We are getting DeprecationWarnings bubbling up from np.matrix.
This is because we do rotations a lot (and so matrix-multiply by rotation matrices), and because we use matrix operations in the 5D Jacobian calculations.
This PR will eliminate sources of the deprecated np.matrix type in qfit, using the
It also chases down all locations where matmul was 'implied' through one of the objects being a np.matrix type, and makes this matmul operation explicit.

Closes #46

@blake-riley OSX builds still fail. Just making sure it's OK to close this PR?

I'd say good to merge.
The reason for fail on py3.6, macos-latest with cplex-mkl is still
ImportError: dlopen(/Users/runner/runners/2.169.1/work/qfit-3.0/qfit-3.0/.tox/cplex-mkl/lib/python3.6/lib-dynload/_ctypes.cpython-36m-darwin.so, 2): Library not loaded: @rpath/libffi.6.dylib

The lack of libffi seems something in the GitHub runner?
I'm confident it still works because the cplex-openblas tests pass on all machines (including windows).


[0.66] Shadow inconsistency fix with updated test

Cherry pick of https://github.com/microsoft/react-native-macos/commit/19a62d9f57a6fae7a046741e19978a801f69abee

/azp run


[pipeline] refactor pipeline

infer pipeline schedule parameters, such as tensor_shape or scatter_gather_tensors, from user config file

Is this a good practice? In this way, users rely on config file more heavier, which is diffenret from Pytorch's pattern.

Is this a good practice? In this way, users rely on config file heavier, which is diffenret from Pytorch's pattern.

Actually, this PR do not add any addtitional requirement to the config file except set NUM_MICRO_BATCHES in pipeline parallel mode. We could infer those argument for schedule before, but we don't. This PR just fill it.

I think a good way to define tensor shape for pipeline is to set static batch size, seq length and hidden size for the model. The schedule reads the sizes from the model. If they are None, we transfer the shape in the first step.

I think a good way to define tensor shape for pipeline is to set static batch size, seq length and hidden size for the model. The schedule reads the sizes from the model. If they are None, we transfer the shape in the first step.

I agree with you, but I don't find a standard to define the config file, so the rule in this PR is induced from the examples config. If they are None, we will get the shape in the warmup stage.

@FrankLeeeee In what case we need to transfer multiple tensors across the pipeline?

@FrankLeeeee In what case we need to transfer multiple tensors across the pipeline?

In cases such as dual path network, one example is SlowFast, one of the most popular video networks.

@YuliangLiu0306 scatter_gather_tensors is only used for 1D parallelism. We suggest to enable it when 1D is used. So, how about hide this option from users?

@YuliangLiu0306 scatter_gather_tensors is only used for 1D parallelism. We suggest to enable it when 1D is used. So, how about hide this option from users?

Yes. As we put schedule into engine, not only that option, the whole initialization process of schedule has been hidden. From users' view, they don't have to care about how to initialize schedule.


Trained Models

Could you please share the trained models? I was trying to train them on my own system but it keeps crashing cause it fills up the RAM quickly. I greatly appreciate it.

Could you please share the trained models? I was trying to train them on my own system but it keeps crashing cause it fills up the RAM quickly. I greatly appreciate it.

Unfortunately, the model is very heavy and need a high capacity RAM.
In the original paper, they mentioned that the learning parameters for model with 10 BRMs is less that 10 million, however my implement by TensorFlow shows that only 3 BRMs produces more than 80 million parameters. I sent them an email to ask about this big difference with what they reported, but long pause no response.
With 3 BRMs the training result is not good and not same as what they reported.

That's unfortunate.
Do you have any estimates of the required resources for training an exact replica of the model in the paper? I might be able to get a session on AWS or sth. Also, the notebook you've prepared, is the configuration different from the paper? Or do I have to just load it on the server and let it run?

I used a Quadro RTX8000 that equipped with 48GB of dedicated RAM.
I tried to implement all settings, parameters and initialization as reported in the original paper.

Alright, thanks! I'll see what I can do and if I manage to train it, I'll send it to you so you can share it along with the code.