Custom sequence markup in ordered list

From https://github.com/metanorma/bipm-si-brochure/issues/24
The custom sequence in ordered lists based on manually numbering the list items is not working in Metanorma (and apparently, in AsciiDoc neither).
...

1. the base units, the supplementary units and the derived units of the Système International d'Unités, which form a coherent set, are denoted by the name "SI units"; footnote:[The CIPM approved in 2001 a proposal of the CCU to clarify the definition of "SI units" and "units of the SI", see <<cipm-si-units>>.]

2. the prefixes adopted by the CGPM for the formation of decimal multiples and submultiples of SI units are called "SI prefixes";

and *recommends*

3. the use of SI units and of their decimal multiples and submultiples whose names are formed by means of SI prefixes.

Output:

@Intelligent2013 I will also need to decide whether the sequence choice on lists is something we should implement independently, or something I should pass on to you as attributes on each
. My inclination is still that we should implement it independently.

@opoudjis sorry for my misunderstanding, what does mean 'independently'? If xml will contain initial value, then I can set it for PDF out, if not, then each list will start with '1' always (where can I get the information then?).
Notes for xml format:

attribute can be set only for lists which have non '1' first value.
attribute can be set for each li instead of parent ol.
for aphabetical numbering, it would be better if the start value will be set as 3, not c.

Sorry, @Intelligent2013, this is not about the start value (which I am refusing to implement for now, because it will involve major refactoring for Word); it is about the style,
 v s
. Right now there is a metanorma default: the levels go a, 1, i, A, I. In BIPM ordered lists will presumably start with 1 at the first level, but I will need to look through the documents to confirm.
The question for you is: should I give you
 populated for all ol in the documents of BIPM? Or should we both implement a different sequence of levels in the rendering code independently?

The question for you is: should I give you  populated for all ol in the documents of BIPM? Or should we both implement a different sequence of levels in the rendering code independently?

I can implement in xslt any rules for types of ol depends on the nested level and position in hierarchy. So don't need to populate type attribute.

The default list style is arabic; but the festival of historical folly that is Annex 1 includes:
1st CGPM: A. then 1.
CIPM 2002: a) as two levels nested down from unordered list
24th CGPM: (i) as three levels down from unordered list, but not rendered as indented list at all
This means that we do in fact need to permit arbitrary list types.
Now it turns out that we do insert the ol/@type into the XML; we've just been ignoring them in rendering, because that's been Metanorma policy. @Intelligent2013, you and I will both need to not ignore  ol/@type for BIPM.

Note: there is grotesque and execrable incoherence in BIPM publications on formatting of list numbers: 1., a), (1).
Metanorma is not in the business of perpetuating formatting incoherence. We will be rendering list numbers only one way.


[BUG] zvm upgrade crashed

Describe the bug
run zvm upgrade crashed
To Reproduce
Steps to reproduce the behavior:

Run zvm  upgrade
See error below:

xiaods@ZBBB2006M-0032 ~/code/build-nfs-ganesha $ zvm version
zvm v0.6.7 linux/amd64
xiaods@ZBBB2006M-0032 ~/code/build-nfs-ganesha $ zvm upgrade
You are on ZVM v0.6.7... upgrading to (v0.7.1)panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x78f575]

goroutine 1 [running]:
github.com/tristanisham/zvm/cli.(*ZVM).Upgrade(0xc000030740)
        github.com/tristanisham/zvm/cli/upgrade.go:74 +0x495
main.main()
        github.com/tristanisham/zvm/main.go:175 +0x756

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Ubuntu wsl on win10
Architecture  x86_64
Version v0.6.7

Configuration:
Additional context

Huh, that's so weird. Might have already fixed in the latest release. I'd suggest reinstalling ZVM with the install script. Unless you've customized the install location or any of the default environment variables, you should just be able to delete ~/.zvm and rerun the one liner to upgrade to the new version.

Huh, that's so weird. Might have already fixed in the latest release. I'd suggest reinstalling ZVM with the install script. Unless you've customized the install location or any of the default environment variables, you should just be able to delete ~/.zvm and rerun the one liner to upgrade to the new version.

Yes, I have reinstalled the ZVM and manually replaced it.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_04lm07do5b/clone/recipe/meta.yaml:15: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_04lm07do5b/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_04lm07do5b/clone/recipe/meta.yaml:40: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_04lm07do5b/clone/recipe/meta.yaml:40: missing_description: The recipe is missing a description
ERROR: /tmp/abs_04lm07do5b/clone/recipe/meta.yaml:40: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_04lm07do5b/clone/recipe/meta.yaml:40: missing_license_family: The recipe is missing the about/license_family key.
Errors were found


Still losing files in Brackets' default directory when upgrading Brackets

Software should never destroy information without much effort from users ("rm -f" and sinister dialog boxes), and allow mistakes to be undone (Undo, Trash Bin, Recycle Bin.)
This is the same issue as "Lost all saved files when updating from 1.7 to 1.8 #12912", which was 3 versions and a year ago. Brackets is still designed to hurt new users.
I am a new Mac user.  "TextEdit" is a primitive word processor, not a text editor.  Others confirmed MacOS does not include a graphical text editor, and recommended Atom and other downloadable applications.  A Web search for "Mac text editor" found several lists topped by Brackets.
So last week, I installed and started using Brackets. I did not notice new files saved to the Getting Started directory buried in the Brackets application directory tree, a very bad choice for default directory.  Brackets should not allow (or at least menacingly warn) when attempting to write to any directory inside the Brackets application directory tree.  The default directory should be Documents, until changed by user.
Today, opening Brackets suggested upgrading to version 1.11.  Clicked yes, and replace existing app.
The upgrade deleted my files.  The upgrade did not overwrite the previous version, allowing extra files to be preserved. The upgrade did not check if the Getting Started directory contained files not provided by Brackets.  The upgrade did not move user-created files to a safe place.  The upgrade did not warn that Bracket likes to save files to a directory that would soon be deleted.
Trash Bin does not contain the deleted application, or any of its files.  My files seem unrecoverable.
Expected behavior:
New users expect their files to be saved to Documents.
New users do not expect their files to be deleted when upgrading an application.
Actual behavior:
Brackets deliberately upsets users, deleting files, and destroying productivity.
Versions
Release 1.11 build 1.11.0-17524 (release 86b5e2d4e)
build timestamp: Wed Sep 20 2017 03:34:28 GMT-0700
macOS Sierra Version 10.12.6 (16G29)

Hi @solprovider,
my 2 💵's is that the issue is not destroying work in the Getting Started project exactly, but actually two things consisting of:

Being able to save in the Getting Started directory in the first place
New users having a hard time grasping the concept of Projects in Brackets every now and then.

What we should do is:

Prevent saving into Getting Started
Prompt to change the project when trying to save a file in Getting Started, with a simple explanation on how Brackets operates.

/cc @adobe/brackets-committers

@petetnt Point noted 💯
IMO, we could use 2 solutions together.

Prevent save in Brackets installation directory.
Create the default project in app support directory.

This happened to me and although it was heartbreaking, the one saving grace of being an OSX user is Time Machine - I was able to recover from a backup most of what was lost. Hopefully you took a recent backup!


Non-sorted data assertion in ordered queue

When I finish a trajectory and start a new one I could have:
F0625 10:08:27.729404 30040 ordered_multi_queue.cc:112] Check failed: last_dispatched_time_ <= next_data->GetTime()
In my case this is due to the following scenario:

start of cartographer with a trajectory
imu data at 1millisecond
odometry data at 1millisecond (common start time in ordered_multi_queue is then 1 millisecond)
odometry data at 3 milliseconds
finish trajectory
new trajectory
imu data a 2 milliseconds

This can be reproduced by the following code:
TEST(OrderedMultiQueueTestOther, MarkQueueAsFinishedMultiple) {
  std::vector<std::unique_ptr<Data>> values;
  OrderedMultiQueue queue;

  const int trajectory1 = 1;
  const QueueKey imuTrajectory1{trajectory1, "imu"};
  const QueueKey odometryTrajectory1{trajectory1, "odometry"};

  const int trajectory2 = 2;
  const QueueKey imuTrajectory2{trajectory2, "imu"};

  const auto AddQueues = [&queue,&values](std::initializer_list<QueueKey> queueKeys) {
    for (const QueueKey& queueKey : queueKeys) {
      queue.AddQueue(queueKey, [&values](std::unique_ptr<Data> data) {
        if (!values.empty()) {
          EXPECT_GE(data->GetTime(), values.back()->GetTime());
        }
        values.push_back(std::move(data));
      });
    }
  };

  AddQueues({imuTrajectory1, odometryTrajectory1});

  queue.Add(imuTrajectory1, MakeImu(1));
  EXPECT_TRUE(values.empty());
  queue.Add(odometryTrajectory1, MakeOdometry(1));
  EXPECT_EQ(1, values.size());
  queue.MarkQueueAsFinished(imuTrajectory1);
  EXPECT_EQ(2, values.size());
  queue.Add(odometryTrajectory1, MakeOdometry(3));
  EXPECT_EQ(3, values.size());
  queue.MarkQueueAsFinished(odometryTrajectory1);
  EXPECT_EQ(3, values.size());

  AddQueues({imuTrajectory2});
  queue.Add(imuTrajectory2, MakeImu(2)); // Check failed: last_dispatched_time_ <= next_data->GetTime() (3 vs. 2) Non-sorted data added to queue: '(2, imu)'
}

I want to know if you consider it as a bug as if I do not finished the trajectory there is no assertion or if I should modify my code to handle this case.

I'm not entirely sure.
I think you are only supposed to call MarkQueueAsFinished for all sensors of a trajectory after all sensors have finished.
Does it still fail when you move the MarkQueueAsFinished to the end of the block where you "finish trajectory1"?

If you mean:
// same code as before

queue.Add(imuTrajectory1, MakeImu(1));
EXPECT_TRUE(values.empty());
queue.Add(odometryTrajectory1, MakeOdometry(1));
EXPECT_EQ(1, values.size());
queue.Add(odometryTrajectory1, MakeOdometry(3));
EXPECT_EQ(1, values.size());
queue.MarkQueueAsFinished(imuTrajectory1);
queue.MarkQueueAsFinished(odometryTrajectory1);
EXPECT_EQ(3, values.size());

// same code as before

then I got the same error.

I think the minimal case will be like this:

Create trajectory 1
Send data with timestamp 100 to trajectory 1
Create trajectory 2
Send data with timestamp 50 to trajectory 2

OrderedMultiQueue or Collator or CollatedTrajectoryBuilder really cannot handle this kind of case.
They guarantee to forward data strictly time-sequential, but at step (2.) they didn't know and could not wait for trajectory 2.
What do you think the expected behavior should be?
Have you seen this issue in the wild?
TrajectoryCollator won't have this issue, so it could be a work around to enable it, but it won't sort across trajectories.

I think the minimal case will be like this:
Create trajectory 1
Send data with timestamp 100 to trajectory 1
Create trajectory 2
Send data with timestamp 50 to trajectory 2

In this case you will got a failure when you insert data with timestamp 50 in case data of trajectory 1 was dispatched. In my case it is:

create trajectory 1
send imu data with timestamp 100 to trajectory 1
send odometry data with timestamp 100 to trajectory 1
send odometry data with timestamp 200 to trajectory 1
finish trajectory 1
create trajectory 2
send imu data with timestamp 199 to trajectory 2 (due to a message received a bit later)

If I create trajectory 2 before  finishing trajectory 1, it does not fail as OrderedMultiQueue::Dispatch() will call OrderedMultiQueue::CannotMakeProgres().
Just note that in my case I have:

imu data at: 100 and 199
odometry data at: 100 and 200
So imu dates have dates which always increase, same for odometry.

OrderedMultiQueue or Collator or CollatedTrajectoryBuilder really cannot handle this kind of case.
They guarantee to forward data strictly time-sequential, but at step (2.) they didn't know and could not wait for trajectory 2.

Yes but you could discard data for e.g.

What do you think the expected behavior should be?

It depends on OrderedMultiQueue semantics. If you think that this it is the expected behaviour maybe just add documentation about this case.

If I create trajectory 2 before finishing trajectory 1, it does not fail as OrderedMultiQueue::Dispatch() will call OrderedMultiQueue::CannotMakeProgres().

Are you saying

create trajectory 1
send imu data with timestamp 100 to trajectory 1
send odometry data with timestamp 100 to trajectory 1
send odometry data with timestamp 200 to trajectory 1
create trajectory 2
finish trajectory 1
send imu data with timestamp 199 to trajectory 2 (due to a message received a bit later)

does not fail or

create trajectory 1
send imu data with timestamp 100 to trajectory 1
send odometry data with timestamp 100 to trajectory 1
send odometry data with timestamp 200 to trajectory 1
create trajectory 2
send imu data with timestamp 199 to trajectory 2 (due to a message received a bit later)
finish trajectory 1

does not fail?

I meant the first case but both do not fail as trajectory2 is created before finishing trajectory 1.

Well the creation of trajectory 2 before trajectory 1 does not work as it breaks invariant at a higher level:
TEST_F(MapBuilderTest, FinishTrajectoryWithOtherTrajectory) {
  const auto addFakeRangeTo = [this](int trajectory_id, double elapsed_time) {
    TrajectoryBuilderInterface* trajectory_builder =
        map_builder_->GetTrajectoryBuilder(trajectory_id);
    cartographer::sensor::TimedPointCloudData data{
        cartographer::common::FromUniversal(123) +
            cartographer::common::FromSeconds(elapsed_time),
        Eigen::Vector3f::Zero(),
        {Eigen::Vector4f::Zero()}};
    trajectory_builder->AddSensorData(kRangeSensorId.id, data);
  };

  const auto addFakeImuTo = [this](int trajectory_id, double elapsed_time) {
    TrajectoryBuilderInterface* trajectory_builder =
        map_builder_->GetTrajectoryBuilder(trajectory_id);
    trajectory_builder->AddSensorData(
        kIMUSensorId.id,
        sensor::ImuData{cartographer::common::FromUniversal(123) +
                            cartographer::common::FromSeconds(elapsed_time),
                        Eigen::Vector3d(0., 0., 9.8), Eigen::Vector3d::Zero()});
  };

  trajectory_builder_options_.mutable_trajectory_builder_2d_options()
    ->set_use_imu_data(true);
  BuildMapBuilder();

  int trajectory_id_1 = map_builder_->AddTrajectoryBuilder(
      {kRangeSensorId, kIMUSensorId}, trajectory_builder_options_,
      nullptr /* GetLocalSlamResultCallbackForSubscriptions */);
  addFakeRangeTo(trajectory_id_1, 0.); // data not dispatched as there is no imu

  int trajectory_id_2 = map_builder_->AddTrajectoryBuilder(
      {kRangeSensorId}, trajectory_builder_options_,
      nullptr /* GetLocalSlamResultCallbackForSubscriptions */);

  // data not dispatched by internal queue as there is no data for 2nd trajectory
  addFakeImuTo(trajectory_id_1, 0.);

  // mark internal queue as finished
  map_builder_->FinishTrajectory(trajectory_id_1);

  // dispatch of imu (as imu key is sorted before range)
  // which triggers the following check:
  // F0706 17:05:18.893314  24578 pose_graph_2d.cc:720] trajectory_id 0 has finished but modification is requested, skipping
  addFakeRangeTo(trajectory_id_2, 1.);
  map_builder_->FinishTrajectory(trajectory_id_2);
}

Is it possible to change fatal error to warning as there is: // TODO(gaschler): Replace all FATAL to WARNING after some testing.?

After replacing LOG(FATAL) by LOG(WARNING) I sometimes got assertions:

F0725 08:39:37.499804  5049 pose_graph_2d.cc:318] Check failed: data_.submap_data.at(submap_id).state == SubmapState::kActive
F0725 10:39:42.344398 18830 pose_graph_2d.cc:185] Check failed: data_.trajectories_state.at(trajectory_id).state != TrajectoryState::DELETED

Unfortunately, I am not able to reproduce it in a test case for now but the problem is due to the fact that
PoseGraph2D::AddNode() does not check if we can add a work item that modify the trajectory. A possible fix could be:
NodeId PoseGraph2D::AddNode(
    std::shared_ptr<const TrajectoryNode::Data> constant_data,
    const int trajectory_id,
    const std::vector<std::shared_ptr<const Submap2D>>& insertion_submaps) {
  // [...] skipped for simplification
  AddWorkItem([=]() EXCLUDES(mutex_) {
    if (!CanAddWorkItemModifying(trajectory_id)) { // <--- check added here
      return WorkItem::Result::kDoNotRunOptimization;
    }
    return ComputeConstraintsForNode(node_id, insertion_submaps,
                                     newly_finished_submap);
  });
  return node_id;
}

If you agree with the fix I could send PR.

Well the fix is not complete as I now got:
*** Check failure stack trace: ***
    @     0x7fb65afaf0cd  google::LogMessage::Fail()
    @     0x7fb65afb0f33  google::LogMessage::SendToLog()
    @     0x7fb65afaec28  google::LogMessage::Flush()
    @     0x7fb65afb1999  google::LogMessageFatal::~LogMessageFatal()
    @     0x7fb65c3b8d3c  cartographer::mapping::PoseGraph2D::AddTrajectoryIfNeeded()
    @     0x7fb65c3c0cf9  cartographer::mapping::PoseGraph2D::AppendNode()
    @     0x7fb65c3c154f  cartographer::mapping::PoseGraph2D::AddNode()
    @     0x7fb65c40b3fa  cartographer::mapping::(anonymous namespace)::GlobalTrajectoryBuilder<>::AddSensorData()
    @     0x7fb65c34549d  cartographer::sensor::Dispatchable<>::AddToTrajectoryBuilder()
    @     0x7fb65c3f5ee4  cartographer::mapping::CollatedTrajectoryBuilder::HandleCollatedSensorData()
    [...] removed for simplicity

Could you explain the rational behind the following code to help me trying to fix this issue:
AddTrajectoryIfNeeded(submap_id.trajectory_id);
if (!CanAddWorkItemModifying(submap_id.trajectory_id)) return;

Especially why the 2 call are not inverted?

In my eyes, AddNode should always execute, and we should not do this fix without fully understanding the issue. There is a risk that the fix only covers the real issue.
Can you please explain again in which case the failed check is triggered?
Perhaps we can understand this corner case first and then write a test that reproduces it reliably?

AddTrajectoryIfNeeded(submap_id.trajectory_id);
if (!CanAddWorkItemModifying(submap_id.trajectory_id)) return;
Especially why the 2 call are not inverted?

Reading these lines again, I think if (!CanAddWorkItemModifying(submap_id.trajectory_id)) return; can even be omitted because AddTrajectoryIfNeeded has already passed all the checks.
But it does not hurt.
I think it is rather unrelated to your issue, and is just the point when the checks fail.
(Just a reminder, callers may never add sensor data to a trajectory after finishing it.)

Inverting the 2 calls also mean modifying CanAddWorkItemModifying or creating another function to return true when there is no trajectory.

Can you please explain again in which case the failed check is triggered?

In my initial report I was doing:
  load_map()
  current_trajectory_id = create_trajectory()
  while (true)
    add_data(current_trajectory_id, imu, odo, lidar)
    finish_trajectory_id(current_trajectory_id)
    current_trajectory_id = create_trajectory()

Since https://github.com/googlecartographer/cartographer/issues/1212#issuecomment-403065078 I have replaced FATAL by WARNING and I do:
  load_map()
  current_trajectory_id = create_trajectory()
  while (true)
    add_data(current_trajectory_id, imu, odo, lidar)
    old_trajectory_id = current_trajectory_id
    current_trajectory_id = create_trajectory()
    finish_trajectory(old_trajectory_id)

This to test that finishing/creating a trajectory is fully supported by cartographer.

Note that as data dispatching is delayed by OrderedMultiQueue, even though the user call FinishTrajectory after adding all data, internally FinishTrajectory can be called before data processing is finished, like in the following case:
// ...
int trajectory_id_1 =  map_builder.AddTrajectoryBuilder();
auto trajectory_builder_1 = map_builder.GetTrajectoryBuilder(trajectory_id_1);
trajectory_builder_1.AddSensorData(lidar_data);
trajectory_builder_1.AddSensorData(imu_data);
trajectory_builder_1.AddSensorData(odo_data);
// ...
int trajectory_id_2 =  map_builder.AddTrajectoryBuilder();
auto trajectory_builder_2 = map_builder.GetTrajectoryBuilder(trajectory_id_2);

// void MapBuilder::FinishTrajectory(const int trajectory_id) {
//  sensor_collator_->FinishTrajectory(trajectory_id);
//  pose_graph_->FinishTrajectory(trajectory_id);
// }
// map_builder.FinishTrajectory() calls queue_.MarkQueueAsFinished() which
// calls Dispatch() to consume remaining data. But as we have another trajectory
// Dispatch() return without processing remaining data as we do not have data
// for trajectory 2.
// map_builder.FinishTrajectory() calls pose_graph_->FinishTrajectory()
// but all data from trajectory 1 was not dispatched.
map_builder.FinishTrajectory(trajectory_id_1);

// may call Dispatch() and then data of trajectory 1 is dispatched
trajectory_builder_2.AddSensorData(lidar_data);
trajectory_builder_2.AddSensorData(imu_data);
trajectory_builder_2.AddSensorData(odo_data);
// ...

So we are back to a previous question do you want to support this case in OrderedMultiQueue?
If not you should mention that Collator should not be used with multiple trajectories on the same robot.

So we are back to a previous question do you want to support this case in OrderedMultiQueue?

What is the expected behavior? Drop remaining items of a finishing trajectory that are waiting for newer timestamps of newly added sensors?
Without a clear expected behavior this issue is not actionable.

If not you should mention that Collator should not be used with multiple trajectories on the same robot.

The use case that I heard of is finishing a trajectory to "pause SLAM" and adding a new one later, often with the initial pose set to the last known pose. This is supported.
If you don't need strong determinism, TrajectoryCollator should work in this case.

What is the expected behavior? Drop remaining items of a finishing trajectory that are waiting for newer timestamps of newly added sensors?

Yes, you could drop remaining items instead of dispatching them.

Without a clear expected behavior this issue is not actionable.

I understand, I was not probably clear enough. My point is just that I was surprised by the fact that I got an assert when:

I sent sensor data chronologically ordered for each sensor
I finished and started a new trajectory with sensor data also chronologically ordered for each
sensor (like in the cases discussed)

I wanted to know if you consider it a bug or not. Depending on your answer I would have fixing it or
fixing my code.

If you don't need strong determinism, TrajectoryCollator should work in this case.

Yes, I now use it.

Close as OrderedMultiQueue will not be changed to drop remaining items.


Crash when loading big image with progressive decoding enabled

Issue Description
On some devices (I reproduced on iPhone 7) when loading big image (in my case its' size is aboun 11Mb) with progressive decoding enabled I get the app crashed
Reproduce
Unfortunately can't add the file I use to reproduce the problem because it's 11 Mb in size but only less then 10Mb is allowed. And the URL I use is private. But the code to reproduce the problem is here:
let source = ImageResource(downloadURL: url!)
self.task = self.imageView.kf.setImage(with: source,
                                       placeholder: nil,
                                       options: [.forceRefresh, .progressiveJPEG(.default), .transition(.fade(0.1))],
                                       completionHandler: nil)

run it with URL to big image (11,1Mb in my case) on iPhone 7 (and probably older devices) and you'll get crash in SessionDataTask.swift on line 119: mutableData.append(data). At the same time another thread is stopped in ImageFormat.swift on line 120: for (index, item) in buffer.enumerated() {
the info from console:
malloc: can't allocate region
:*** mach_vm_map(size=12697600, flags: 100) failed (error code=3)
 malloc: *** set a breakpoint in malloc_error_break to debug

If I remove  .progressiveJPEG(.default) from options, everything works well

From the error, it is the memory issue. The system forbids an allocation of more memory. Loading a 11MB image itself is not a trivial behavior, it consumes lots of memory, especially when loading progressively (which actually load the same image for multiple times). Loading big picture like that requires some trick.
Maybe you can try to use the DownsamplingImageProcessor to make your image smaller before actually decoding it, which may solve your loading issue (normal such a huge image is not necessary for your UI, so pick a good smaller size):
imageView.kf.setImage(with: url, options: [
                        .forceRefresh,
                        .progressiveJPEG(.default),
                        .processor(DownsamplingImageProcessor(size: .init(width: 800, height: 600)))
])

(And not sure why you need .forceRefresh, but I personally suggest not use it until you have a special reason. Leave Kingfisher to decide reusing a cached image would be also helpful for memory usage.)


Feature-Request for nextButton and prevButton

See this fiddle https://jsfiddle.net/ee32t6q4/
Request is for setting "slidesPerView: auto"
Click on nextButton or prevButton its swipe a single element. I wish that it scroll to the first not complete visible Slide. Means: When I see "Slide 1" "Slide 2" "Slide 3" and not or only partly "Slide 4" than "Slide 4" should be the first Slide. Has anyone understood my request or is this already possible?

There is slidesPerGroup parameter to control such behavior

Thanks, but how I use this in a responsive design with diffrent count of slides in a view? I like to slide all visible slides, what depends on devicescreen size.


Formatters: HTML

What feature or new tool do you think should be added to DevToys?
It would be great to have under "Formatters" the "HTML" item, to reformat (as for XML) what pasted in
Why do you think this is needed?
Very useful
Solution/Idea
Reformatting like https://webformatter.com/html can be the best
Comments
In case, thank you :)

Duplicate with #176


Home list of tweets unordered in loklak

The list of home tweets is usually ordered according to last tweets on top. The list on loklak is unordered.

The sorting function was implemented here which was removed because it kept resulting into a timeout, this needs to be put in correctly so that we avoid the delays.
https://github.com/loklak/loklak_webclient/commit/26ef0f69fa91acd1e2f879fc678e4e27f8290bff#diff-4c242643d0a18b0152c046e9ed637055L46

@sudheesh001 If you take out basic functionality, please create an issue and assign to the responsible. We cannot just get rid of features that are implemented once. Thanks for solving the issue, but it is not completely solved until the functionality is there. Hence: Create an Issue in future!

I'll solve this today.

@sudheesh001, why is it resulting in a timeout?
I just looked back and the sort function is accurate and place at the right place to not interrupt anything.
Sorting ~ 30 statuses is very fast - 0.064s - You can't notice that.
Please compare the live version on PR #260 and http://test.loklak.net/

It is working now. Thank you!


Update sql-data-warehouse-develop-ctas.md

correct typo
their -> there

Hi @ahkim, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@barbkess


Docs: New setfit tutorial

Looking good!

@davidberenstein1957 could you review and finalize this PR with the addition to the proper sections in the docs, file naming, etc.
After that, we can merge it


Augment the concept of a payment schedule to include those elements needed for ILDR reporting

Currently we are missing several required terms, including but not limited to:
Payment amount
Last payment date
Next due date
Number of payments in contract
There are other concepts needed to cover the ILDR reporting requirements, but these are the ones specific to payment schedules.  See the attached mapping from FIBO to the ILDR reporting requirements, which defines these properties.  They are relevant to many debt instruments so should likely be added in FBC to the Debt ontology or possibly be related to Debt instruments.
Note that we should review the concepts in the parametric schedules ontology in SEC and consider whether they should be merged into financial dates for use in payment and other schedules more generally.  Parametric Schedules is a small ontology but important, and some of the concepts defined in that ontology apply more broadly to debt instruments and loans.  Others may be specific to debt instruments such as bonds, and could be retained in their original location.
FIBO-ILDR Mapping.xlsx

I'm not so keen on "last payment" and "next payment" which are relative to current date - which you'd also need to record. If we have a schedule with dates, and actual payments with dates, then it is easy to calculate last and next from any given current date.


feat(build): use release version in bump-job

What this PR changes/adds
This PR modifies the bump-version action and takes the release version (base version) from an action input and only falls back to the gradle.properties if that input was null.
Why it does that
when releasing e.g. 0.2.0, the next snapshot is supposed to be 0.2.1-SNAPSHOT.
Further notes

I also improved the snapshot patch version increment, so that when releasing versions with metadata, e.g. 0.3.6-rc2, the next snapshot version will still be 0.3.6-SNAPSHOT.
once this PR is approved, i'll do the same thing in all other repos as well.

Linked Issue(s)
Closes #3198
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Codecov Report
Patch and project coverage have no change.

Comparison is base (176aedd) 65.64% compared to head (78f86e1) 65.64%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3207   +/-   ##
=======================================
  Coverage   65.64%   65.64%
=======================================
  Files         841      841
  Lines       16872    16872
  Branches      928      928
=======================================
  Hits        11075    11075
  Misses       5428     5428
  Partials      369      369

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix code formatting for Embedded Framework @ README

Looks like this was taken care of by #2031. Thanks anyway! Cheers! 🍻


connectedComponentsWithStats produces a segfault in the latest release (<IP_ADDRESS>)

The following minimal example finishes with exit code 139 (interrupted by signal 11: SIGSEGV):
import cv2
import numpy as np

img = np.zeros((240, 320, 1), np.uint8)

cv2.connectedComponentsWithStats(img, connectivity=4)
cv2.connectedComponentsWithStats(img, connectivity=4)

With the previous release of opencv-python (<IP_ADDRESS>) this worked fine.
Here is a Dockerfile to reproduce the crash:
FROM python:3.9.9

RUN apt-get update && apt-get install -y \
  libglib2.0-0 \
  libgl1-mesa-glx \
  build-essential \
  && rm -rf /var/lib/apt/lists/*

# With the old opencv-python==<IP_ADDRESS> things are fine.
RUN pip install --no-cache-dir numpy==1.22.0 opencv-python==<IP_ADDRESS>

RUN echo "import cv2" > main.py
RUN echo "import numpy as np" >> main.py
RUN echo "img = np.zeros((240, 320, 1), np.uint8)" >> main.py
RUN echo "cv2.connectedComponentsWithStats(img, connectivity=4)" >> main.py
RUN echo "cv2.connectedComponentsWithStats(img, connectivity=4)" >> main.py

RUN python main.py

Result:
Segmentation fault (core dumped)

I don't know if relevant, but when installing <IP_ADDRESS>, pip prints:
Collecting opencv-python==<IP_ADDRESS>
  Downloading opencv_python-<IP_ADDRESS>-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (60.3 MB)

While when installing <IP_ADDRESS>, it prints:
Collecting opencv-python==<IP_ADDRESS>
  Downloading opencv_python-<IP_ADDRESS>-cp36-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (60.4 MB)

(cp36-abi3 instead of cp39-cp39)
Maybe this is related to the problem?

Duplicate of https://github.com/opencv/opencv-python/issues/602 and https://github.com/opencv/opencv/issues/21366.
Cannot be fixed here, the issue is in C++ code.

(cp36-abi3 instead of cp39-cp39)

That is expected due to recent changes. See https://www.python.org/dev/peps/pep-0384/ for more info.

Ah, ok, thanks. :+1:

it works
opencv-python <IP_ADDRESS>
thanks


Update gokrb5 to v8

Thanks for the contribution. Can you please run make fmt to fix formatting?

Thanks for the contribution. Can you please run make fmt to fix formatting?

I got no changes when I did (and nothing's jumping out at me as wrong when looking at it)


[BUG] when you select clickable and events: click you cant click  element inside, without closing tooltip

Describe the bug
A clear and concise description of what the bug is.
Version of Package
vX.X.X
To Reproduce
Steps to reproduce the behavior
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information if possible or delete this section):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]
Frameworks [e.g. React 18, Next.js 13]

Smartphone (please complete the following information if possible or delete this section):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]
Frameworks [e.g. React 18, Next.js 13]

Additional context
Add any other context about the problem here.

As you can see on the example in the docs page, it should work fine. Can you provide a sample project showing the problem?

Yes, when you open when hover, you can click great, the problem is when you set the events={[click]} and prop clickable, when you click a button the popover close.

            try this up.

               `◕‿‿◕
		<Tooltip events={['click']} anchorSelect="#not-clickable">
			<button>You cant click me :(</button>
		</Tooltip>
		◕‿‿◕
		<Tooltip
			events={['click']}
			anchorSelect="#clickable"
			clickable
		>
			<button>You can click me!</button>
		</Tooltip>`

You're right, I misread your description. Try out the beta release for #979 with the version<EMAIL_ADDRESS>and let us know if it works as expected.
By the way, this PR also deprecates events and introduces a new prop openOnClick, which I recommend you use instead.

Yeah!! it's working! with this PR<EMAIL_ADDRESS>

Good to know. The issue will be closed when the PR gets merged. Thanks for reporting.


[Question & Bug?]: Culling Doesn't Really Cull???

So technically, when i turn around from particles they cull right, and gives me FPS, but even if i turn around it doesn't give too many FPS.
But if i disable all the particles in the config, now it gets me up to 500 FPS which is what it should be giving when they also culled isn't it?
I don't know much about culling so just curious.

With culling, the particles still exist abd all have to be checked for position versus the players view and passed over if they aren't in view (and rendered if they are).
The disable particles setting prevents any particles from spawning at all, so not only is there no rendering time, but no particles to tick, check for collisions, etc.

With culling, the particles still exist abd all have to be checked for position versus the players view and passed over if they aren't in view (and rendered if they are).
The disable particles setting prevents any particles from spawning at all, so not only is there no rendering time, but no particles to tick, check for collisions, etc.

Ah gotcha, thank you ❤
Also is there any known incompatibility with optimization mods such as:
Sodium
Lithium
FerriteCore
Entity Culling
Indium
ImmediatelyFast
SodiumExtra
Reesee's Sodium Options
ModernFix
More Culling
Krypton
Ennhanced Block Entities
Debugify
C2ME
Noisium
Memory Leak Fix

There are no known issues with any of those mods

There are no known issues with any of those mods

Lovely! Am i allowed to have this mod for my modpack called Elysium Days with giving credits on the modpack page?

yes, that would be ok

yes, that would be ok

Thanks! ❤


chore: fix comments

Description
fix some function names

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use
unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

Thanks


Missing dependencies

Hello there,
First, thank you for your building such a useful module.
Here is my problem. When I try to run decompress it is asking for 'is-absolute' module. Is that normal?

Probably some nested dependency that didn't get installed. Try installing this again and have another go.

Yep, don't know why I had to clean the node_modules folder. Then, it worked. Sorry for that issue and thank you for your help.


no Python in 5.0.0 release

We need to fix the script too.

I think we don't want to change the script until we have a stand-alone python release?


[setup] Incomplete instructions - github plugin and login needed

Description
Currently at step 4 in the instructions, "Open Visual Studio Code, navigate to the File Explorer and clone this repository with the following repository name CurtinIDS/CIDS_Carpentries_Python into your preferred folder destination"
VS-Code on linux will query for the GitHub plugin, and upon installing it, it will query for a login. The directory does not seem to be able to be cloned without logging in via the plugin using just CurtinIDS/CIDS_Carpentries_Python
Fix
There are two options I see to fix this:

Tell the user to insert the full html https://github.com/CurtinIDS/CIDS_Carpentries_Python.git or https://github.com/CurtinIDS/CIDS_Carpentries_Python
Tell the user to install the GitHub plugin and create a github account before cloning

Option 1. seems the best to me

Updated README.md.
See 1bd96c2.


add remove method

Codecov Report

Merging #4 into master will decrease coverage by 1.11%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage     100%   98.88%   -1.12%
==========================================
  Files           1        1
  Lines          85       90       +5
==========================================
+ Hits           85       89       +4
- Misses          0        1       +1

Impacted Files
Coverage Δ

include/easy_iterator.h
98.88% <80%> (-1.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72ef4f...e661b8f. Read the comment docs.


Revert "Revert "[BACKLOG-18195] decouples abort job.""

Reverts pentaho/pentaho-kettle#5155
adding missing downstream
https://github.com/pentaho/pdi-sdk-plugins/pull/69

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'ui,engine,plugins/core/impl,plugins/core/ui' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui,engine,plugins/core/impl,plugins/core/ui' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/resources/kettle-job-entries.xml
  engine/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_en_US.properties
  engine/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_fr_FR.properties
  engine/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_ja_JP.properties
  engine/src/main/resources/org/pentaho/di/job/entry/messages/messages_en_US.properties
  engine/src/main/resources/org/pentaho/di/job/entry/messages/messages_es_AR.properties
  engine/src/main/resources/org/pentaho/di/job/entry/messages/messages_fr_FR.properties
  engine/src/main/resources/org/pentaho/di/job/entry/messages/messages_it_IT.properties
  engine/src/main/resources/org/pentaho/di/job/entry/messages/messages_ja_JP.properties
  engine/src/main/resources/org/pentaho/di/job/entry/messages/messages_ko_KR.properties
  engine/src/main/resources/org/pentaho/di/job/entry/messages/messages_zh_CN.properties
  plugins/core/impl/src/main/java/org/pentaho/di/job/entries/abort/JobEntryAbort.java
  plugins/core/impl/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_de_DE.properties
  plugins/core/impl/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_en_US.properties
  plugins/core/impl/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_es_AR.properties
  plugins/core/impl/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_fr_FR.properties
  plugins/core/impl/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_it_IT.properties
  plugins/core/impl/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_ja_JP.properties
  plugins/core/impl/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_ko_KR.properties
  plugins/core/impl/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_nl_NL.properties
  plugins/core/impl/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_pt_BR.properties
  plugins/core/impl/src/main/resources/org/pentaho/di/job/entries/abort/messages/messages_zh_CN.properties
  plugins/core/impl/src/test/java/org/pentaho/di/job/entries/abort/JobEntryAbortLoadSaveTest.java
  plugins/core/ui/src/main/java/org/pentaho/di/ui/job/entries/abort/JobEntryAbortDialog.java
  plugins/core/ui/src/main/resources/org/pentaho/di/ui/job/entries/abort/messages/messages_de_DE.properties
  plugins/core/ui/src/main/resources/org/pentaho/di/ui/job/entries/abort/messages/messages_en_US.properties
  plugins/core/ui/src/main/resources/org/pentaho/di/ui/job/entries/abort/messages/messages_es_AR.properties
  plugins/core/ui/src/main/resources/org/pentaho/di/ui/job/entries/abort/messages/messages_fr_FR.properties
  plugins/core/ui/src/main/resources/org/pentaho/di/ui/job/entries/abort/messages/messages_it_IT.properties
  plugins/core/ui/src/main/resources/org/pentaho/di/ui/job/entries/abort/messages/messages_ja_JP.properties
  plugins/core/ui/src/main/resources/org/pentaho/di/ui/job/entries/abort/messages/messages_ko_KR.properties
  plugins/core/ui/src/main/resources/org/pentaho/di/ui/job/entries/abort/messages/messages_nl_NL.properties
  plugins/core/ui/src/main/resources/org/pentaho/di/ui/job/entries/abort/messages/messages_pt_BR.properties
  plugins/core/ui/src/main/resources/org/pentaho/di/ui/job/entries/abort/messages/messages_zh_CN.properties
  ui/src/main/java/org/pentaho/di/ui/spoon/job/JobGraph.java
  ui/src/main/resources/ui/images/ABR.png
  ui/src/main/resources/ui/images/ABR.svg

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
:new: org.pentaho.di.job.entries.abort.JobEntryAbort

Branch Coverage: 0% :exclamation:
Complexity Coverage: 58.8% :exclamation:
Instruction Coverage: 41.9% :exclamation:
Line Coverage: 47.2% :exclamation:
Method Coverage: 62.5% :exclamation:

org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.pgbulkloader.PGBulkLoaderMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

Yes, sorry about your impediment.
We are currently on a effort to decouple any plugin that lives inside the engine, and make it available as a plugin.  However the pdi-sdk-plugins are yet to comply with the recent move.
What you need to do, for the GeneratingJobs to see the Abort job, is to add in the project root, a plugins folder containing the pdi-core-plugins-impl.jar file.
Hope this information helps you.  I'll try to add this information in the sdk README too.


local development with 'oc cluster up'

new scripts to set up a local OpenShift cluster with CentOS container images for zabbix and host monitoring

[test] again please!

@joelddiaz the test failure appears to be legitimate, let me know if this is incorrect:
YAML validation failed on docker/local_development/zabbix_monitoring_cent7_local_dev.yaml: while scanning a simple key
  in "docker/local_development/zabbix_monitoring_cent7_local_dev.yaml", line 258, column 1
could not found expected ':'
  in "docker/local_development/zabbix_monitoring_cent7_local_dev.yaml", line 259, column 18

For some reason the build output was not included in the jenkins output, I'll have to look into that.

[test]

@twiest changes/feedback incorporated/addressed


search box doesn't work in some cases

The search box of the registry does not bring results for partial matches or eth address.
e.g. given the user Leo Fer profile
https://app.proofofhumanity.id/profile/0xb30851b276e19fbbcbf3d82825a8cab68823ddfa?network=mainnet
when I type in the search box the word "le" it doesn't bring any result. On the other hand, if I type Leo, which is an exact word contained in the profile name, it does bring the profile included in the results, together with other users which have the exact word Leo in the profile name.
Full name " Leonardo Ferlini" is not matched at all in the search, not even typing the exact full name.
Search by ethereum address also doesn't bring any results.
It  should bring results for partial matches or for any text contained in the profile
Windows 10, chrome Version 89.0.4389.82 (Official Build) (64-bit)

Hi, I see an improvement has been pushed for partial matches but search is still case sensitive and is still not returning results for the remaining information of the profile. e.g. last name

Please follow https://github.com/Proof-Of-Humanity/proof-of-humanity-web/issues/192


Ignore click events when zooming or panning is active.

All's in the title.
Also kindly asking whether a release is planned any time soon.  Thanks!

Thanks especially for this one! I'd been looking for a robust and simple way to do that and somehow overlooked the widgetlock.
I've been behind on maintaining mpldatacursor lately.  That should change in the very near future.
Enough enhancements have accumulated to justify a 0.7 release.  I think I'll try to get a few more bugfixes in this weekend and release either this weekend or next.
Also, thanks for all of your contributions lately.  I've been late in responding, but I do greatly appreciate them!

Actually, I just realized that sometimes, allowing click events even when zooming or panning is active can be useful (use case: I'm using mpldatacursor for interactive data selection, so I want to zoom, click on a point, pan somewhere else, click on another point, and retrieve the data from datacursor.annotations).
I guess one can add an argument to the constructor, "exclusive=True", which switches this behavior.  Thoughts?  Thoughts on the name of the argument?

That's the typical use case, in my experience.  However, even with that in mind, disabling the datacursor during zooming is the right thing to do.  (It's actually how it worked in the past when it was based on a connection to the pick event.)
By default, pressing the zoom/pan/whatever button again after zooming/etc will re-enable the normal pick mode where mpldatacursor works.  I should probably put a note about that in the readme, as it used to be a relatively frequently asked question, and not obvious unless you're quite familiar with matplotlib.
It is possible (albeit it a bit hackish) to have mpldatacursor make the zoom/pan/etc buttons only work once.  E.g. "zoom" mode zooms once, then goes back to normal pick mode without having to press the zoom button again.  I'd prefer not to go that route, as it changes how the matplotlib toolbar works.


GOPATH / GOROOT

Thank for you great tool!
I've built tile38 the last time in 2021 without any problems. Now make is leading to GOROOT / GOPATH complaints like in https://github.com/tidwall/tile38/issues/6 :
cmd/tile38-luamemtest/main.go:14:2: cannot find package "github.com/tidwall/resp" in any of:
	/usr/lib/go/src/github.com/tidwall/resp (from $GOROOT)
	./go/src/github.com/tidwall/resp (from $GOPATH)
cmd/tile38-luamemtest/main.go:15:2: cannot find package "github.com/yuin/gopher-lua" in any of:
	/usr/lib/go/src/github.com/yuin/gopher-lua (from $GOROOT)
	./go/src/github.com/yuin/gopher-lua (from $GOPATH)
[..]

My env: ArchLinux, go 1.22.2

That's really strange.
Maybe try go clean' and make clean`?

I've added a go clean in front of make, which didn't change my error. I've just created the srcdir, it is a new and empty folder.
There ArchLinux PKGBUILD may read, but not write outside their context.
No access to any GOROOT / GOPATH folders is intentional, it is necessary to set them up ad hoc.


[WIP] Actually actionable batch rules to write, 2022 Edition

For each of the items here, we should make sure all compositions (vmap, vmap x vjp) have a batching rule. All of these items should be actionable (in that it is possible to write a batching rule and we are not blocked on functionalization, which is coming soon).
Note: you may need to write an OpInfo for the operator if it doesn't exist already or wait for one to be added. A lot of folks are adding OpInfos right now, so if the OpInfo doesn't exist please ask first to see if someone is working on it.
Note: if any of the operations decompose into in-place operations, then we need functionalization to handle them. I think I've already filtered out all of those, but please check me on that.
Parcel 1: misc torch.nn.functional

torch.nn.functional.max_pool1d
torch.nn.functional.max_pool3d
torch.nn.functional.prelu
torch.nn.functional.instance_norm (#391)
torch.nn.functional.group_norm (May require writing an OpInfo) (#387)

Parcel 2: misc torch

torch.repeat_interleave
torch.combinations (I'm not sure if this is actually possible)
torch.cartesian_prod (I'm not sure if this is actually possible)

Parcel 3: If you're looking to write some OpInfos. NB: Please check if someone already has a PR open for the OpInfo

nn.functional.l1_loss
nn.functional.smooth_l1_loss
nn.functional.conv3d
nn.functional.fold
nn.functional.soft_margin_loss
unbind

Deprecated; goto https://github.com/pytorch/functorch/issues/614


Additional workloads: cyclictest, oslat and testpmd add

Description
Three more workloads added:

oslat
cyclictest
testpmd

Fixes
n/a
This PR depends on the work @jdowni000 has done for the baremetal clusters #248

@mohit-sheth @sjug @rsevilla87 Can we get another set or two of eyes on this one please?


Update AviationWeather.php

Added the ability to fetch latest TAF report of given icao from ADDS/NOAA
(to be used for Weather widget or any other process)

I've updated this PR to update the Metar base class and renamed the implementation methods to get_metar and get_taf. This is so they can be cached and are wrapped in that. Thanks for the update!

Please have a look at this too @nabeelio , i tried to figure out the cause of the error but found nothing.

Please have a look at this too @nabeelio , i tried to figure out the cause of the error but found nothing.

Why'd you close this? I haven't gotten to it yet

Why'd you close this? I haven't gotten to it yet

I did not closed it intentionally ... Was deleting old branches in my fork , this was deleted too by mistake , restoring it back

I did not closed it intentionally ... Was deleting old branches in my fork , this was deleted too by mistake , restoring it back

Thanks. Can you resolve the weather blade conflict? Then I can pull this down and test it out this weekend.

Thanks. Can you resolve the weather blade conflict? Then I can pull this down and test it out this weekend.

Was it causing the error i mentioned at contracts.metar.php ? I was looking through the code but never looked to the widgets.weather.blade

Was it causing the error i mentioned at contracts.metar.php ? I was looking through the code but never looked to the widgets.weather.blade

I don't know but it says above there's a conflict in that file

I don't know but it says above there's a conflict in that file

Strange though, what i see is an error on Metar.php / line 44 ... Will look into the weahter.blade for any conflicts

Strange though, what i see is an error on Metar.php / line 44 ... Will look into the weahter.blade for any conflicts

Just pulled all down, used them on my test server and looks like we have the tafs too

Just pulled all down, used them on my test server and looks like we have the tafs too

I had to remove the taf part from the blade to resolve the conflict, we need to add it later i think.

I had to remove the taf part from the blade to resolve the conflict, we need to add it later i think.

Looks like the TAF translation is missing (says common.taf) - also, have you tested with something where the TAF is missing? I can add some tests in later, actually.

Looks like the TAF translation is missing (says common.taf) - also, have you tested with something where the TAF is missing? I can add some tests in later, actually.

Well , i need to find an airport without a taf first ... Give me some time.

Well , i need to find an airport without a taf first ... Give me some time.

Just checked two airports ;

HAAB / Addis Ababa ( Ethiopia ) they never publish metar or taf publicly (you can get via phone or via handling agent) , widget reported "METAR/TAF data could not be retrieved".

KFOK / Francis S. Gabreski Airport ( United States / Near NY ) on the other hand, does only publish metars and but no tafs, this airport broke the code and I get the error "Trying to access array offset on value of type null" while rendering weather.blade

So, we can avoid this in the Weather Widget controller or in the blade, rest of the code is ok I think.
Btw, I am just using raw taf. Should I test decoding it like the metar ?

Just checked two airports ;

HAAB / Addis Ababa ( Ethiopia ) they never publish metar or taf publicly (you can get via phone or via handling agent) , widget reported "METAR/TAF data could not be retrieved".

KFOK / Francis S. Gabreski Airport ( United States / Near NY ) on the other hand, does only publish metars and but no tafs, this airport broke the code and I get the error "Trying to access array offset on value of type null" while rendering weather.blade

So, we can avoid this in the Weather Widget controller or in the blade, rest of the code is ok I think.
Btw, I am just using raw taf. Should I test decoding it like the metar ?

Can you attach the XML files here I can add them as tests

Can you attach the XML files here I can add them as tests

Ok , seems like HAAB starting sending TAF to ADDS but still no metar ... Here are your files ;
HAAB : No Metar - Has Taf
HSFS : No Metar - No Taf
KFOK : Has Metar - No Taf
xml_pack.zip

Ok , seems like HAAB starting sending TAF to ADDS but still no metar ... Here are your files ;
HAAB : No Metar - Has Taf
HSFS : No Metar - No Taf
KFOK : Has Metar - No Taf
xml_pack.zip

Did some changes in my weather.blade as below ;
`
METAR
@if($metar) {{ $metar['raw'] }} @else No METAR Reports @endif

TAF
@if($taf) {{ $taf['raw'] }} @else No TAF Reports @endif
`
Got this results, which is more than enough for me

Did some changes in my weather.blade as below ;
`
METAR
@if($metar) {{ $metar['raw'] }} @else No METAR Reports @endif

TAF
@if($taf) {{ $taf['raw'] }} @else No TAF Reports @endif
`
Got this results, which is more than enough for me


Remove createCell parameter from inline docs

The parameter was removed from the method signatures, but not form their documentation.

Thanks @kaishin !


Cancel drag drop

Hi every one,
Please ask how to cancel action dragging.
I try press 'ESC' but not

thanks !

Ctrl or Cmd z.


new APIs request: getCurrentPullRequestInfo and openDiff

I would like to propose two new api calls so that other VS Code extensions can interact with this extension.
They would look something like this:
getCurrentPullRequestInfo(uri: string)
Given the URI of a file or diff view, return the PR number and repository that corresponds to that URI (or null if the URI isn’t for a file or diff).
openDiff(filePath: string, pr: number, repoRootUri: Uri)
Open the diff view of a desired file based on its path, the PR number, and the repository. This would function the same as clicking on that fileChangeNode in the pull requests TreeView.
Question: is the repository rootUri the right way to refer to a repo in this extension?
The reasoning behind these two calls:
We are currently developing an extension that allows users to explore the pull request in a diagram. We want to:

Allow a user, while doing a code review using the github pr extension, to view the associated diagram. For this, we need to know what the “active” pull request is that’s being reviewed, and we’re thinking the best way to do that is based on the URI of the active editor. Very open to other ideas, though!
Allow a user to click in our diagram to open the diff view of any file in the pull request. For this, we need a way to open the correct diff view for each file, just as it would be opened by the github pr extension.

We see two scenarios for how a user might interact with our extension and the github pr extension

Checking out a review branch

User checks out the branch they want to review
User opens our Review Map diagram

We look at the local branch information and determine the PR we are on and all the information we need to display the diagram

User double clicks on a file in the diagram to open the diff for that file

We get the file path they clicked on and call the proposed openDiff() api with the filepath, pr number, and repo rootUri

The user is now in github pr extension land and can review the file like normal

User is exploring remote pull requests and opening the diffs from the github pr extension

User opens up the github PR extensions's pull requests TreeView, expands the PR they want to review, and clicks on a fileChangeNode to open a file diff view
while viewing that file, they want to view it in our diagram

user does a cmd shift P and choses to open our diagram
we call the proposed getCurrentPullRequestInfo() api to get the repository and PR number
we use this information to display our diagram

User clicks in our diagram to open a different file's diff

We grab the filepath of what they clicked on, combine it with the repository/pr that we have from the last step and call openDiff()

Thank you for considering our proposal!

@LizardEatsFlies and I have made some progress on our extension.
We figured out how to glean some pull request information by accessing editor.document.uri.scheme. If that scheme is "pr", we can parse a lot of context information:
const editor = vscode.window.activeTextEditor;
const {
  headCommit,
  baseCommit,
  prNumber,
  remoteName
} = JSON.parse(editor.document.uri.query);

This allowed us to make progress without the getCurrentPullRequestInfo() method we proposed.
To get around the lack of openDiff() method, we constructed some URIs manually and called the vscode.diff command:
const schemeParams = {
  headCommit,
  baseCommit,
  prNumber,
  remoteName,
  fileName,
  isBase: true,
  status: 3,
};

const baseURI = vscode.Uri.file(absoluteFilePath).with({
  scheme: "pr",
  path: absoluteFilePath,
  query: JSON.stringify(schemeParams),
});

schemeParams.isBase = false;
const headURI = vscode.Uri.file(absoluteFilePath).with({
  scheme: "pr",
  path: absoluteFilePath,
  query: JSON.stringify(schemeParams),
});

const shortFileName = path.basename(relativeFilePath);

// Open a diff view based on a PR selected in the GitHub extension panel
vscode.commands.executeCommand(
  "vscode.diff",
  baseURI,
  headURI,
  `${shortFileName} (Pull Request)`
);

getCurrentPullRequestInfo(uri: string)
I'm definitely amenable to this API, but I don't have time to work on it at the moment. This should probably return the following:

{
prNumber: number,
owner: string, // for this repo that would be "microsoft"
repository: string // for this repo that would be vscode-pull-request-github
{

openDiff(filePath: string, pr: number, repoRootUri: Uri)
I'm less sure of this API. What if the pr isn't a currently open pr?

We don't plan to add this in the near future, so closing as out of scope!


Use full known command validation for pilight send

Description:
We already know the datatypes for certain pilight command data fields.
As it is not always possible for the user, to choose the correct
datatype for a piece of data (see bug #5042), which causes an unhelpful
error message from the pilight daemon, we can use this schema to "fix"
the users command data.
To prevent duplicate definition of the command data, this puts the data
into the pilight hub component and males the rf schema extending it.
this is also consistent as the command schema validates what the send
service of the hub gets as valid data.
Related issue (if applicable): fixes #5043
Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

I cannot reproduce the unittest errors in 3.4. @pvizeli can this be an artifact of the async logging effort?

The unit test failures are yours:
16-12-23 02:47:50 ERROR (Thread-726) [tests.components.test_pilight] PilightDaemonSim callback: <function setup.<locals>.handle_received_code at 0x7ffa7a752620>
16-12-23 02:47:50 ERROR (LoopThread) [homeassistant.core] Invalid service data for pilight.send: required key not provided @ data['protocol']. Got None

The problem is, That I cannot reproduce any of this failures. Neither with the python version on my system, nor in a container build with the provided dockerfile.

Do you maybe have some custom components with the same name?

No, I've exactly the same code that's in the PR. I tried a clean checkout and rebuild the container from the given dockerfile. No error. It seems like the log messages are somewhat out of order. There is no possible way how the
16-12-23 02:47:50 ERROR (LoopThread) [homeassistant.core] Invalid service data for pilight.send: required key not provided @ data['protocol']. Got None

can come from this unittest, becase the protocol is give in the test data.

Both your test classes do not shut down the hass instance. There is no tear down method.

Thank you @balloob , this seems to fix the problem. I made it an extra PR #5195 to not intermix it with this change. As soon as it's merged I'll rebase this PR on it.

As long as there is no API provided by the pilight c-library we have to put protocol configuration validation on hold. The arising issues (e.g. #5119 #4853) outweigh the benefit of better error messages when the protocol is wrong. A clear no merge from me.

@DavidLP, then please provide another method to use templated service data with the component and provide consistency between the switch data and the service call

then please provide another method to use templated service data with the component: I cannot. I do not use templating, but I guess being able to parse an expression to a certain data type is very valid feature request.
provide consistency between the switch data and the service call: What is inconsistent here? Switch data is being used in the service call.

https://github.com/home-assistant/home-assistant.github.io/pull/1750

You could always write a custom component that parse data to the right format and passes it on to the pilight component

Hi @janLo,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Are there any updates on this?

The issue that caused this PR still exist. The PR is not merged. So the situation is still the same.

@baloob could you either close the PR or say it is mergeble  so @janLo could finish it?

This PR would implement a regression for issue https://github.com/home-assistant/home-assistant/issues/5119.

The changes from #5119 have to be ported to this (a simple copy/paste) before, yes.

I don't want to make a decision. I'll let @DavidLP decide.

I close it now. It need to be a rebase, and look like david have decide.


Front End - Contact Us component.

Create a component that contains either a google maps api or just screenshot of the location, or even just the picture of the storefront. Include contact information.
Nice to have, have a contact form that saves the contact input into a separate database. Think it should only have a simple get all query and no mutations for now.

Content added. Awaiting styling.
Either need to figure out how to add the google api to it or just leave the image as is.