bug(mat-icon): Inline mat-icon inherits line-height incorrectly resulting in clipping

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
13
Description
Any line-height set on a parent of an inline mat-icon with a larger font size results in clipping. As an example, let's add mat-typography on body which sets the font of the element it is placed on to body-1. This includes setting line-height to 20px. .mat-icon-inline sets line-height to inherit. This results in the line height being set to 20px and any font size larger than 20px causing clipping.
This problem was hidden by the fact that in earlier versions, the mat-icon overflowed so no clipped occurred. However, since #12429, overflow is set to hidden and clipping occurs.
A fix
The fix I found is removing line-height: inherit which allows .material-icons's line-height: 1 to apply. I can make a PR to make this change.
Reproduction
Steps to reproduce:

Set line height on body
Add an inline mat-icon with font-size larger than the line height set previously

See https://stackblitz.com/edit/components-issue-vwhnst?file=src/app/example-component.html
Before v14 (overflowing mat-icon)
This mat-icon has 38.4 margin top and bottom and a font-size of 76.8px.

Since v14

Expected Behavior
The icon should scale with font-size without clipping.
In this screenshot, the line-height is set to 1, the margin is correctly applied, and no clipping occurs.

Actual Behavior
The icon is clipped due to the line-height not being 1. This is caused by line-height: inherit.
Environment
Angular CLI: 14.1.3
Node: 16.18.1
Package Manager: npm 8.19.2
OS: linux x64
Angular: 14.1.3
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, language-service, material, material-moment-adapter
... platform-browser, platform-browser-dynamic, router
Package                         Version
@angular-devkit/architect       0.1401.3
@angular-devkit/build-angular   14.1.3
@angular-devkit/core            14.1.3
@angular-devkit/schematics      14.1.3
@schematics/angular             14.1.3
rxjs                            6.6.7
typescript                      4.7.4

I have exactly the same issue. Bug since 2022 what happens?


Restore 'query' event to its original form (no native sql string)

Fixes #2549

Closing, GitHub won't update with new commit for some reason.


FEATURE REQUEST: dumpInInterval() convenience method

would be really cool to be able to do this:
wtfnode.dumpInInterval(90000)

which would be the same as doing
const handler = setInterval(() => {
  wtfnode.dump()
}, 90000)

handler.unref()

Hi there. I'm a bit disinclined to do this, mainly because the point of the tool is to identify dangling handles preventing node from exiting. You only exit once, so I'm not sure what purpose this would serve? That and, as you've shown, it can be accomplished with a one-liner. Can you say more about what purpose or benefit it would provide to users?

why to include it?
Yes it's 4 liner, but a lot of developers don't know about unref() so a lot of people won't even think of using it this way.
my usecase is running this in jest/vitest or any other test runner and detecting culprit when the runner is not exiting

A timer doesn't really address your use case well - what you probably want is an "afterEach" with a debounce or something (to avoid spam).
That said, wtfnode doesn't operate properly if it's not loaded absolutely first; it won't be able to mutate the globals that it wraps to identify callers. So for use with Jest, you'd probably be best off using the cli invocation (to ensure it loads first) to load wtfnode and then launch jest directly and then manually hit ctrl+c as usual when the tests have reported completion. It's not possible of course to know when a program has intended to exit automagically, and certainly waiting for a period of time is not a very convenient way to substitute for that.
I agree that unref may be relatively unknown, but I don't agree that it's a particular problem - it will be pretty obvious that "the timer that ran wtfnode" is in the list to a user who is unaware of things. In other words, it doesn't really hurt anything if the timer shows up in the list.
I'm hesitant to commit to an additional API here and I don't honestly see enough value to justify the addition.


have the tcomp root context configurable

Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
tcomp root context is /
What is the new behavior?
tcomp root context is /tcomp and is configurable via command line
Does this PR introduce a breaking change?

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
…s file

Pull request test result: failure :x:

Pull request test result: failure :x:


empty line after vim in ssh channel

the terminal on the right is mac terminal.

open a ssh channel
use vim to open a text file
exit for many times

Different behaviors show.
No empty line like this:

Too many empty line like this:

A bug of CentOS or ssh? I don't think so. I also test for many times on my mac terminal, only one behavior.

Are you using WSL SSH or Windows SSH?

Yes, I use Windows SSH (built in PowerShell)

This might be an issue for their repository. I see this on conhost itself without Windows Terminal on occasion.


Segment not showing

hello,
when we set array count more than 1 of segment then it showing perfect but when array count 1 then segment not shown..can you please help how to solve this..
i am attaching screenshot with two array count and 1 array count you can see there is not shown segment in 1 array count
 <-- you can see there is no segment.

Hello Any Solution for this ? @Akash-nara did you fixed this issue ?


bc assessment report

Hi Jessica, can you please update the terra form env variable below.
REACT_APP_POWER_BI_REPORT_ID_INTERNAL=22baabf7-3310-4cf2-9756-e0d67f992367
Thanks,

I have updated the variable in the test web configuration in azure :)

I have updated the variable in the test web configuration in azure :)

thanks Jessica


Implement same features in Java/Android app

Hello Jishi,
Thanks for such a nice and perfectly working api in node js for SONOS devices.
I want to achieve same kind of functionality in android application.My query is,
1)How can i acheive this in Android app.
2) Is it possible to implement same functionality in android?
3) Have you implemented for android?
4) If I have to start then from where I can start it?
Please help me out over above queries.
Thanks,
Chetan

Hi. I can't help you with the Android stuff, but I can tell you that it is possible.
For some guidance for Android, look at the Andronos source (a now deprecated controller, but I think it would still work) https://gitorious.org/andronos/andronos.git/ is a readonly copy of it.

I am trying to run API in debug mode but it's not working. I am using Visual studio code for development.
Please guide how can I run in debug mode.

I'm sorry, I can assist you with specific problems that doesn't relate to this code base at all. You will have to find help by other means, stackoverflow or similar.

Thanks for the quick reply. :)


Use voluptuous for Fritzbox Callmonitor

Description:
Migration of the configuration check to voluptuous.
Related issue (if applicable): fixes 127528299
Example entry for configuration.yaml (if applicable):
sensor:
  platform: fritzbox_callmonitor

@DavidMStraub, would be nice if you could take a look at the changes and run a quick test. Thanks.

Hi, the changes look fine to me, I can't test it until tomorrow though as I am reinstalling my development system.

🐬

(Tested, works.)

@DavidMStraub thanks!


Contact us page – wireframe

Create wireframe for contact page.
The page should include simple contact form (to report an issue or to ask a question).
The form will include at least those fields:

Name of the user
Text field where a user can leave a message
Contacts of the user
Button Send

Before the form, there should be a header.

I changed variant a bit. In Figma.


added config file SITL iris with gazebo

Gains are not yet tuned, we first need to focus on getting things right on the simulator, otherwise we will try to compensate those things by adjusting gains on the firmware side which doesn't make sense.
Anyway, this config loads the correct mixer, sets the correct board rotation, ...


Failure to fetch bibliographic reference CC/R 1102:2013

Error when using it in Metanorma-CC:
[bibliography]
== Bibliography

* [[[cc_glossary,CC/R 1102:2013]]], CalConnect. _Calendaring and Scheduling Glossary of Terms V2.2_. 2013.

Error:
[relaton-cc] INFO: Downloaded index from `https://raw.githubusercontent.com/relaton/relaton-data-calconnect/main/index-v1.zip`
[relaton-calconnect] INFO: (CC/R 1102:2013) No found.

But it works in Relaton:
With year:
$ bundle exec relaton fetch 'CC/R 1102:2013'
<bibdata type="standard" schema-version="v1.2.9">
  <fetched>2024-11-09</fetched>
  <title type="title-main" format="text/plain" language="en" script="Latn">Calendaring and Scheduling Glossary of Terms V2.2 (CD 1102)</title>
  <title type="main" format="text/plain" language="en" script="Latn">Calendaring and Scheduling Glossary of Terms V2.2 (CD 1102)</title>
  <docidentifier type="CC" primary="true">CC/R 1102:2013</docidentifier>
  <version>
    <revision-date>2013-05-02</revision-date>
  </version>
  <abstract format="text/plain">A Glossary of Calendaring and Scheduling Terms.</abstract>
  <ext schema-version="v1.0.0">
    <doctype>report</doctype>
    <editorialgroup>
      <committee>CALCONNECT</committee>
    </editorialgroup>
  </ext>
</bibdata>

Without year:
$ bundle exec relaton fetch 'CC/R 1102'
<bibdata type="standard" schema-version="v1.2.9">
  <fetched>2024-11-09</fetched>
  <title type="title-main" format="text/plain" language="en" script="Latn">Calendaring and Scheduling Glossary of Terms V2.2 (CD 1102)</title>
  <title type="main" format="text/plain" language="en" script="Latn">Calendaring and Scheduling Glossary of Terms V2.2 (CD 1102)</title>
  <docidentifier type="CC" primary="true">CC/R 1102:2013</docidentifier>
  <version>
    <revision-date>2013-05-02</revision-date>
  </version>
  <abstract format="text/plain">A Glossary of Calendaring and Scheduling Terms.</abstract>
  <ext schema-version="v1.0.0">
    <doctype>report</doctype>
    <editorialgroup>
      <committee>CALCONNECT</committee>
    </editorialgroup>
  </ext>
</bibdata>

FYI @andrew2net

@andrew2net The query Relaton.fetch_async is making is:
@bibdb.fetch_async("CC/R 1102:2013", "2013",
  {:code=>"CC/R 1102:2013", :analyse_code=>{:id=>"CC/R 1102:2013"}, :year=>"2013", :title=>"CalConnect. Calendaring and Scheduling Glossary of Terms V2.2. 2013.", :match=>#<MatchData "<ref id=\"cc_glossary\">[CC/R 1102:2013]</ref>, CalConnect. Calendaring and Scheduling Glossary of Terms V2.2. 2013." anchor:"cc_glossary" usrlbl:nil code:"CC/R 1102:2013" text:"CalConnect. Calendaring and Scheduling Glossary of Terms V2.2. 2013.">, :lang=>"en", :process=>0, :ord=>0})

Fetching either @bibdb.fetch_async("CC/R 1102:2013", "2013",  ....) or @bibdb.fetch_async("CC/R 1102", "2013",  ....) is resulting in a Not Found error.
@andrew2net I think this is still a Relaton issue, even if relaton fetch does not replicate it.

@ronaldtse @opoudjis in the source dataset the document doesn't have published date. It has only revdate:
...
  - id: CC/R1102-2013
    title:
    - type: title-main
      content: Calendaring and Scheduling Glossary of Terms V2.2 (CD 1102)
      language: en
      script: Latn
      format: text/plain
    - type: main
      content: Calendaring and Scheduling Glossary of Terms V2.2 (CD 1102)
      language: en
      script: Latn
      format: text/plain
    type: standard
    docid:
      id: CC/R 1102:2013
      type: CC
    version:
      revision_date: '2013-05-02'
    revdate: '2013-05-02'                   # <=REVDATE!!
    abstract:
      content: A Glossary of Calendaring and Scheduling Terms.
      format: text/plain
    fetched: '2020-06-23'
    editorialgroup:
      technical_committee:
        name: CALCONNECT
    doctype: report
    uri:
    xml:
    pdf:
    doc:
    html:
    rxl:
    txt:
...

Can we use the revdate as a published date?

This is bad practice, the source data should have a published date. But yes, if you know for a fact that the document is published and not draft, but you do not have a published date or updated date, then you must use revdate; all published documents need a publication date for referencing.

We do not enforce a published-date for all documents, because published-date means the document was published and not draft. If the document is published, then perhaps we should enforce a published-date (@opoudjis )
If the document is not published, we need to show the draft date, which is revdate. (@andrew2net )

Fixed in relaton-calconnect v1.19.1 @ronaldtse @opoudjis plese check

We do not enforce a published-date for all documents, because published-date means the document was published and not draft. If the document is published, then perhaps we should enforce a published-date (@opoudjis )

@ronaldtse Did you want that as a warning or an abort in Metanorma?


fix normalization order in find_missing_characters()

To account for composite characters, I changed find_missing_characters() to normalize the training example before using it to calculate the set of all characters in the training data, rather than normalizing the set of characters.
In addition to the change, I modified one of the test cases for updating the tokenizer to include a check for handling a composite character.

This change is

Codecov Report
Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.34%. Comparing base (bda3b54) to head (38cdb25).

Files
Patch %
Lines

...tion/huggingface/hugging_face_nmt_model_trainer.py
85.71%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   88.33%   88.34%
=======================================
  Files         234      234
  Lines       13816    13820    +4
=======================================
+ Hits        12205    12209    +4
  Misses       1611     1611

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update contribution guidelines

Request a white image for the dashboard screen
Request edge case specs and provide explanation for how to run specs
Include explanations of how images will be used

:ship:

still :ship:


Entire mini.nvim, vim-fugitive and fzf-lua support

Question or Suggestion
Can support for entire mini.nvim suite and fzf-lua be added. Currently this theme doesn't support mini.statusline, mini.indentscope afaik.

Hi @231tr0n!
Thanks for raising the issue. I'll be adding support for fzf-lua very soon :)

Hello @echasnovski!
Hope I'm not being too cheeky asking this of you, but I can see you've made contributions to several other colorschemes just in the last day. I thought I'd jump on the opportunity to see if you'd be interested in adding Offical Mini Support™ to cyberdream.nvim as well. Would love input from the original author!

@231tr0n I've added a borderless theme for fzf-lua that looks like this:

This mimics the default telescope theme quite closely. For it to look correct, you need to set fzf_colors to true in your fzf config. E.g.
return {
    "ibhagwan/fzf-lua",
    dependencies = { "nvim-tree/nvim-web-devicons" },
    config = function()
        require("fzf-lua").setup({
            fzf_colors = true,
        })
    end,
}

@scottmckendry, Is support for vim-fugitive possible. I did not want to create a new defect. So I modified the existing one.

Hello @echasnovski!
Hope I'm not being too cheeky asking this of you, but I can see you've made contributions to several other colorschemes just in the last day. I thought I'd jump on the opportunity to see if you'd be interested in adding Offical Mini Support™ to cyberdream.nvim as well. Would love input from the original author!

Hi @scottmckendry!
Since you are the first one to ask this (and nicely so), here you go. I'd like to explicitly stress though, that this is not an Offical Mini Support™, but my attempt to make 'mini.nvim' experience more pleasant for users. I'd much rather enjoy seeing that color scheme authors or their users add this kind of support on their own (it is explicitly stated as a welcome way to contribute to 'mini.nvim' with an explicit list of highlight groups needed for full support).

I would also like to give some feedback for issues that were apparent when adding 'mini.nvim' support:

The Visual highlight group defines both foreground and background. This is generally ok (although I prefer background only), but the result has way too low contrast ratio (1.71, to be exact). To the point that text is barely readable.
Having Diff* highlight only through foreground is rarely a good choice for usability. Mostly because they are used to highlight already highlighted text. Using background highlighting is usually a better choice. I'd prefer something like what is used for MiniDiffOverXxx highlight groups in PR.
The CursorLine and CursorColumn highlight groups define lines used to quickly locate cursor on screen. As cursor can be used in floating windows, it is reasonable to have those two groups be such that they are visible both in normal and floating windows. Hence I am not really sure what the purpose of custom MiniFilesCursorLine is.
I'd personally create all shades with appropriate names beforehand instead of using util.blend() in the highlight group definitions. This allows for a more coherent future definitions in plugin extensions.

Hope this helps.

 Thanks for the excellent feedback. Especially around useability and contrast. I want the colorscheme to be as friendly as possible for users and contributors alike.
Appreciate all your hard work on neovim and mini! It's people like you that make the neovim community such a pleasure to be a part of 💚

@231tr0n I've fixed the highlights for vim-fugitive's :Git diff command in the latest commit. As far as I can tell, everything else looks pretty good out of the box. If you spot anything else, let me know 🙂

@scottmckendry The mini.statusline and MiniHiPatterns dont look properly with the latest changes.
MiniHipatternsNote
MiniHipatternsTodo
MiniHipatternsHack
MiniHipatternsHack
MiniStatuslineModeReplace
MiniStatuslineModeCommand
MiniStatuslineModeInsert
MiniStatuslineModeVisual
MiniStatuslineModeNormal
MiniStatuslineModeOther
are the related highlight groups afaik.

Should be resolved now. Pretty sure this would only be an issue when transparency is enabled - due to the bg color being set to "NONE". Let me know if the most recent change fixes it 👍🏻

Should be resolved now. Pretty sure this would only be an issue when transparency is enabled - due to the bg color being set to "NONE". Let me know if the most recent change fixes it 👍🏻

@scottmckendry yup it fixes it. One last addon, currently if we open buffers horizontally using :split command, there is visually no seperator spearating the two buffers horizontally. Vertically there is a line but my doubt was can something be done about this horizontally.

Oh, that's an easy one! Just set hide_fillchars to false (or remove the option entirely since this is the default) in your config and the separators will reappear 🙂

Oh, that's an easy one! Just set hide_fillchars to false (or remove the option entirely since this is the default) in your config and the separators will reappear 🙂

It is false in my case but still i dont see any separators horizontally.

Hmmm... I'm not 100% sure what that could be then. Could you try defining the fillchar manually in your config?
This line here, update it to vim.o.fillchars = [[eob: ,fold: ,foldopen:,foldsep: ,foldclose:,horiz:─]] to see if there's any change.
If not, it might be getting overridden somewhere else.

Hmmm... I'm not 100% sure what that could be then. Could you try defining the fillchar manually in your config? This line here, update it to vim.o.fillchars = [[eob: ,fold: ,foldopen:,foldsep: ,foldclose:,horiz:─]] to see if there's any change.
If not, it might be getting overridden somewhere else.

It is still the same even after the change you suggested.The thing is vertical line is coming, only horizontal is the issue.

Looks like it might be a global statusline thing. If you run :set laststatus=3 does that fix it?

Looks like it might be a global statusline thing. If you run :set laststatus=3 does that fix it?

Yup this fixes it. Thank you soo much @scottmckendry.

CLosing this issue.

 Thanks for the excellent feedback. Especially around useability and contrast. I want the colorscheme to be as friendly as possible for users and contributors alike.
Appreciate all your hard work on neovim and mini!  Best of luck keeping up with the not-always-easy burden of maintaining a color scheme.

Having Diff* highlight only through foreground is rarely a good choice for usability. Mostly because they are used to highlight already highlighted text. Using background highlighting is usually a better choice. I'd prefer something like what is used for MiniDiffOverXxx highlight groups in PR.

I've remembered the other (probably more prominent) reason why Diff* highlight groups usually have distinctive background. DiffAdd, DiffChange, and DiffDelete are used to highlight whole lines, meaning the part after end of line is also highlighted. If there is no background attribute in those highlight groups, this is not visible. And there is also an issue of highlighting whitespace with these groups.

I've just added a fix for this in the latest commit. Gave it a spin with diffview.nvim and it looks SOO much better! Thank you again 🙂


Free container lock during mount setup on container start

Setting up the container mounts could potentially take a good amount of
time.  This is due to the fact that volume drivers are invoked and are
free to do quite a bit.  This change releases the container during the
setup of the mounts.
This helps https://github.com/docker/docker/issues/19328 but does not 100% fix it.  There is another section in container start that deals with networking that I'm guessing will also slow down quite a bit.  I haven't investigated that one yet.
Signed-off-by: Darren Shepherd<EMAIL_ADDRESS>

This seems mostly ok, but we probably need to set a state like Starting or something that we can check while locked so we don't race with 2 calls to start.

@cpuguy83 That's a good point but I was assuming that that locking or control was done at a higher level.  The code today releases the lock for waitForStart and this change just increases the window in which it is unlocked.  I mostly assumed that the container lock was just to protected the mutable data structure for consistent reads, but not for actually blocking two starts from happening at the same time.

@WeiZhang555 I notice you did the change to break up the container.Lock into smaller critical sections.  Does this change make sense too you? (oh yeah, and thanks for that change, I currently see a good deal of issues around docker ps hanging and this container.Lock() wrapping waitForStart seems to be the root cause)
I am now quite confused about the locking behavior.  In 1.9 the entire container start was locked, now in 1.10 it is broken into smaller sections but it does seem like two container starts will have a problem.  I would propose maybe adding a specific startLock that is just used to synchronize start.  Right now the biggest problem I have is that container.Lock() is called from docker ps.  So adding the second lock may be better.

@ibuildthecloud I've started the investigation of the race problem of two calls of start, currently I'm leaning to adding a new state of starting and prefer NOT to add a new start lock, because in my point of view mix use of two locks (start lock and container lock) will bring more chance of dead lock but won't bring too much benefit.
As a opposite, using a state machine to manage container's life cycle can give us better performance, because you know when the state isn't what you want, the function can choose to exit immediately or wait and there's no need to hang for getting the lock.
I'll take a further look tomorrow morning about this PR, and also do more work on double start problem :)

And this change looks good to me, seems no obvious bad influence :+1:

This is closed since it's no longer relevant after reverting the lock break-up PR.
The discussion on the overall fix for improving concurrency/container locking is still very much desirable.
Let's continue on #19328


Question - how to build falcon with cython using pipenv

This is a cross post from stack overflow - https://stackoverflow.com/questions/48805350/how-to-build-falcon-with-cython-using-pipenv
In the  falcon docs it is mentioned that in order to build falcon with cython the following commands need to be issued:

$ pip install cython

$ pip install --no-binary :all: falcon

The question is how to do this with pipenv.
First of all i want to say Pipfile that i have build dependency cython.
I want also to pass the parameters --no-binary :all: falcon to pip.
How can i accomplish this with pipenv?

I actually had to do this for psycopg2 the other day; use this as a guide: https://github.com/pypa/pipenv/issues/1430

Hi @dfee,
I just want to be sure that we accomplish the goals for which we decided to uses pipenv.
When installing an environment from scratch just from Pipfile and Pipfile.lock will the module installed again with cython without setting the PIP_NO_BINARY environment variable?
If not, then i will have to set it up manually every time i install an environment, furthermore this flag would then be globally for all dependencies and not just for falcon.
Thanks

Hey @david-gang - that is a valid question, one I don’t have the answer to.

$ pipenv --three
$ pipenv run pip install Cython
$ pipenv install

I don't think it works for me:
First i run:

pipenv run pip install Cython
Collecting Cython
Downloading Cython-0.27.3-cp36-cp36m-manylinux1_x86_64.whl (3.1MB)
100% |████████████████████████████████| 3.1MB 340kB/s
Installing collected packages: Cython
Successfully installed Cython-0.27.3

Then i try to install falcon with cython:

export PIP_NO_BINARY=ALL && pipenv install falcon
Installing falcon…
Collecting falcon
Using cached falcon-1.4.1-py2.py3-none-any.whl
Requirement already satisfied: six>=1.4.0 in /home/david/.local/share/virtualenvs/planner->FTV5fq3F/lib/python3.6/site-packages (from falcon)
Collecting python-mimeparse>=1.5.2 (from falcon)
Using cached python_mimeparse-1.6.0-py2.py3-none-any.whl
Installing collected packages: python-mimeparse, falcon
Successfully installed falcon-1.4.1 python-mimeparse-1.6.0

Adding falcon to Pipfile's [packages]…
Pipfile.lock (712601) out of date, updating to (b17002)…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…

Look he just took the wheel

Found out you can specify build-system requirements which will install cython and make it available for "normal" modules.
[build-system]
requires = ["cython"]


Deprecation of Repo.insert/2, update, delete in favor of Exception throwing versions

Shouldn't those methods exist in parallel to each other?
Quote from http://elixir-lang.org/getting-started/try-catch-and-rescue.html

In practice, however, Elixir developers rarely use the try/rescue construct. For example, many languages would force you to rescue an error when a file cannot be opened successfully. Elixir instead provides a File.read/1 function which returns a tuple containing informations about whether the file was successfully opened:

In my particular case: I would like to use the optimistic lock on a model and in case of an unsuccessful update due to a version conflict, I would like to get the record from the database again, apply the changes and try to update again.
With only an error throwing method however, I would need to use try/rescue as a flow control mechanism as I do not want to crash my process because of the Ecto.StaleModelError.

We have added the insert/delete/update back. It is very unlikely though that they will handle StaleModelError as such errors can be raised in other situations besides the lock ones (like ID being removed). So you will need to use the try/catch until we come up with a better solution (if there is any).

Ah, yes! Sorry didn't see that one.
https://github.com/elixir-lang/ecto/commit/96a50fb1e6c08154cc4c3ba1f43fcb7731bc78f7


Close then disconnect.

Firstly, thanks for this it is a great addition to my home automation.
I am having a few issues though.
Disconnects. Which I've been following the other issue thread and following the advice.
My issue though is, if the blind is left in the fully open position. It will eventually close on its own and then disconnect, taking some time to become available again.
I am unsure on how to supply logs etc as I'm not too advanced in Arduino, all my devices are either ESPHome or Tasmota.
Is there anything I needed to do in the setup that I may have missed? One thing I noticed is that my open/closed positions reported are the opposite to your readme. I have tried swapping them but it just reports open when closed and it still closes itself after a random amount of time with nothing I can see triggering it. For eg. for me 0 is closed, 100 is open. I guess I put the pulley in the guide wheel in the opposite way to yourself.
I do have another ESP module running a BLE client in ESP Home in the same room, it's used for Xiaomi plant and climate sensors.
I have also set the MAC of the blind in the config file.
I have also tried a second board. same problem.
Apologies if this is the wrong way/format to respond but it seems the only way to reach out to you.
The last issue, which doesn't really bother me is the light sensor always reports  50. I've now just removed the solar sell as I have it hard wired anyway.
Thanks again

My issue though is, if the blind is left in the fully open position. It will eventually close on its own and then disconnect, taking some time to become available again.

I can't imagine anything closing it in the code. Only two things come to mind:

You have something sending a close command on the MQTT topic.
You have the timers set and enabled in the Blind Engine app.

I am unsure on how to supply logs etc as I'm not too advanced in Arduino, all my devices are either ESPHome or Tasmota.

Can you open the serial monitor in arduino and report what you see there?

One thing I noticed is that my open/closed positions reported are the opposite to your readme.

Perhaps HA does not behave well when the positions are inverted from the code? I'll be uploading a few changes shortly, it will have settings to invert the position numbers.

I've played a bit with the positions here, the only thing that would give the swapped open/closed positions is if you have the motor direction set wrong. Open the Blinds Engine app and try changing the 'blind direction setting'.

Thanks for your reply.
I decided to reset everything and start again.

Swap the motor around, and set the direction in the app to match the inverted numbers.
Connected and it seemed well it, then slightly opened the blinds, to which I found this via serial...

MQTT [am43/02:ba:58:19:2c:d3/set_position]2: 98
Addr: 02:ba:58:19:2c:d3 Cmd: set_position
[ 02:ba:58:19:2c:d3] AM43 Send: 00FF00009A0D0162F4
[02:ba:58:19:2c:d3] Got position: 99
BLE scan complete.

I found a command in Node-Red matching it, so maybe I made a mistake in there and it was sending a command as you suggested. So I removed it.

I then looked at this github and noticed you'd made some changes, so I decided to update everything, I also noticed this recommended change, so I amended the file (was it there before?)...

m_scan_params.scan_duplicate     = BLE_SCAN_DUPLICATE_DISABLE;

I then removed the manual entity and sensors and I'm now testing but maybe Node-Red and an error from myself was the issue.

I will report back after I've tested for a while.
Thanks again

I think this issue can be closed, it seems a rogue Node-Red command was my issue coupled with the way it was set up.
The system is now constantly disconnecting, so I will comment on the other thread


App-wide - Give better "object created" notices

Currently the flash just says "Successfully created location" (or other object), but i'm encountering cases where that could be ambiguous. This PR changes the flash to print the object's text_name also, if it exists. Otherwise it defaults to the general message.

coverage: 93.457% (-0.003%) from 93.46%
when pulling 52e5aa7023773c9ce7491191e961d68597c7320f on better-created-flash
into b9575acc9eed14df8bb3ebe477695d2f2771c933 on main.


when will you release the code ?

Dear sir, thanks for the research, but some part in the paper is not clear without code, like the computation of uncertainty  and assesing of uncertainty quality .
And I have serveral other questions,

In fig 1, how do you make the plot ? i think it should be bars (x confidence in a bin and y precision in a bin), and how do you define underconfident/overconfident/well-calibrated ?
In the paper "From our experiments we can conclude that methods that aggregate voxel-wise uncertainty to provide subject-level estimations are not reliable enough to be used as a mechanism to detect failed segmentations." I did not see why
"Furthermore, we observed that when using current uncertainty methods for correcting segmentations, a maximum benefit can be attained when preferring a combination of low precision segmentation models and uncertainty-based false positive removal" I also cannot find any provals from the paper ?

Dear argman,
Thank you for your interest.
The code is finally online. Below the answers to your questions:

We calculate the bins with the function sklearn.claibration.calibration_curve. To determine if a case is over-/underconfident or well-calibrated we calculate the average calibration error and threshold it according to statistics (90th percentile, see miscalibration_percentage).
The sentence is a bit misleading but basically it means that we should pay attention when using the voxel-wise uncertainties at the subject level, e.g. when assessing the result for one individual patient.
This is because the correction only removes false positives. But you are right we did not back this up in the paper (due to the page limit of 8 pages).

I hope, I could answer your questions.


[Desktop] Allow commands to extend native menus

Conceptually:
functions:
  myCommand:
    path: file.ts:myCommand
    command:
      name: “My Command”
      menu: “My Menu > My Command”
      key: “Ctrl-Shift-c”

This would create a “My Menu” top level menu, with a “My Command” menu item triggering myCommand on click (but the keyboard shortcut would also work).

Desktop is now legacy, closing


Incompatibility between the new SSH cipher policies in FCOS 33 and golang.org/x/crypto/ssh

It looks like the id_rsa file is not getting created in the .crc/machine directory.
General information

OS: Any
Hypervisor: KVM / Hyper-V / hyperkit
Did you run crc setup before starting it Yes
Running CRC on: Laptop  & Bare Metal

CRC version
CodeReady Containers version: 1.19.0-OKD+8d69386
OpenShift version: 4.6.0-0.okd-2020-11-27-200126 (embedded in executable)

Steps to reproduce

The bundle was built with:
OKD_VERSION=4.6.0-0.okd-2020-11-27-200126
OPENSHIFT_PULL_SECRET_PATH=/tmp/pull_secret.json

The SNC revision is from my fork: https://github.com/cgruver/snc
The revision is: 4.1.14-157-g291ef43
The single node cluster built successfully, and was usable.
The bundle built successfully.

CRC was built with:
OKD_BUILD=true
BUNDLE_VERSION=4.6.0-0.okd-2020-11-27-200126
BUNDLE_DIR=/crc-build/snc
make embed_bundle

The CRC build completed successfully.

The setup completes with no errors:  Tested on MacOS 11 and CentOS 8
crc setup

It unpacks the bundle and prepares the environment.

The cluster start fails with ssh errors:

INFO Starting CodeReady Containers VM for OpenShift 4.6.0-0.okd-2020-11-27-200126...
DEBU Updating CRC VM configuration
(crc) Calling .GetConfigRaw
(crc) Calling .Start
(crc) DBG | Starting VM crc
(crc) DBG | Validating network
(crc) DBG | Validating storage pool
(crc) DBG | GetIP called for crc
(crc) DBG | Getting current state...
(crc) DBG | IP address: <IP_ADDRESS>
(crc) Found IP for machine: <IP_ADDRESS>
(crc) Calling .GetState
(crc) DBG | Getting current state...
(crc) Calling .GetIP
(crc) DBG | GetIP called for crc
(crc) DBG | Getting current state...
(crc) DBG | IP address: <IP_ADDRESS>
DEBU Waiting until ssh is available
DEBU retry loop: attempt 0
DEBU About to run SSH command:
exit 0
Cannot read private ssh key /home/crc-user/.crc/machines/crc/id_rsa
DEBU SSH command results: err: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain, output:
DEBU error: Temporary error: ssh command error:
command : exit 0
err     : ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
output  :  - sleeping 1s
DEBU retry loop: attempt 1
DEBU About to run SSH command:
exit 0
Cannot read private ssh key /home/crc-user/.crc/machines/crc/id_rsa
DEBU SSH command results: err: ssh: handshake failed: ssh: unable to...
etc...  Until it times out.

Starting CodeReady Containers VM for OpenShift 4.6.0-0.okd-2020-11-27-200126

Hmmmm... this is not the correct issue tracker for OKD-related issues ;-)

It looks like the id_rsa file is not getting created in the .crc/machine directory.

Did you perform a crc delete -f beforehand? The key should be dropped in the ~/.crc/machines/crc folder, but perhaps it is confused by an existing (partial) VM?

Yeah, this was a completely clean build.  The ~/.crc/machines/crc/id_rsa file is not getting created, but I don't see any errors that indicate why...
I ran crc setup and crc start with debug log level to look for clues.

If this is the first run, the error is "normal" as we are using 2 possible keys to connect. The other one is in the extracted bundle.
If this is a second run, it was aborted before or during the new key generation I suppose.

This issue turns out to be an incompatibility between the new SSH cipher policies in FCOS 33 and golang.org/x/crypto/ssh
Reverting the policies in FCOS 33 to support RSA-SHA1 fixes the issue.
cat > /etc/ssh/sshd_config.d/10-fcos-insecure-rsa-key.conf <<EOF
> # For now allow RSA-SHA1 keys.
> # https://github.com/coreos/coreos-assembler/issues/1772
> PubkeyAcceptedKeyTypes=+ssh-rsa
> EOF

wow! nice catch.

Keeping this open, we'll need to fix this somehow.

@cfergeau does this change also going to work with RHCOS ?

This will need to be tested, but I expect RHEL8 to support ecdsa and ed25519 keys in addition to rsa keys.
man ssh-keygen on a rhel 8.3 system has ssh-keygen [-q] [-b bits] [-t dsa | ecdsa | ed25519 | rsa], openssh RHEL builds from 2013/2014 have mentions of ecdsa/ed25519, so I'm quite confident it will be all fine.

I fixed it!!!
I switched snc and crc to use ecdsa keys, and it appears to work.
I'll submit a PR in the morning so you guys can vet it out.

Fixed by: https://github.com/code-ready/snc/pull/289, https://github.com/code-ready/crc/pull/1757


fixes MD5 generation for certain messages

MD5 was calculated wrong when one of the types in the message was substring of an other type
e.g. message moveit_msgs/RobotState.msg:
sensor_msgs/JointState joint_state
sensor_msgs/MultiDOFJointState multi_dof_joint_state
AttachedCollisionObject[]` attached_collision_objects
bool is_diff

resulted in this being hashed:
3066dcd76a6cfaef579bd0f34173e9fd joint_state
MultiDOF3066dcd76a6cfaef579bd0f34173e9fd multi_dof_joint_state
3ceac60b21e85bbd6c5b0ab9d476b752 attached_collision_objects
bool is_diff

Good catch. If I find time today, I'll add those messages to common_msgs and add their names+md5s to the md5 sum test

Great! Before you add those messages, you might want to look into my branch fix-messages-with-fieldname-object as e.g. moveit_msgs/AttachedCollisionObject.msg has a fieldname called 'object':
string link_name
CollisionObject object
string[] touch_links
trajectory_msgs/JointTrajectory detach_posture
float64 weight

As I'm not really sure what all that code in GenerationGuts.cs is doing I'm not very comfortable with my changes...

Yeah... that code's a stale hot mess, most of it naively composed circa-fuerte or spit+duct tape on top of that original design. //TODO


Issue with links to already translated documents

This is a Bug Report

Problem:
The following documents contain the document links which are already translated into Korean:

[x] docs/concepts/configuration/configmap.md
[x] docs/concepts/configuration/overview.md
[x] docs/concepts/extend-kubernetes/api-extension/apiserver-aggregation.md
[x] docs/concepts/extend-kubernetes/api-extension/custom-resources.md
[x] docs/concepts/overview/kubernetes-api.md
[x] docs/concepts/security/overview.md
[x] docs/concepts/services-networking/connect-applications-service.md
[x] docs/concepts/services-networking/dual-stack.md
[x] docs/concepts/storage/volumes.md
[x] docs/concepts/workloads/controllers/job.md
[x] docs/concepts/workloads/pods/_index.md
[x] docs/concepts/workloads/pods/pod-lifecycle.md
[x] docs/contribute/participate/pr-wranglers.md
[x] docs/contribute/participate/roles-and-responsibilities.md
[x] docs/reference/_index.md
[x] docs/reference/command-line-tools-reference/feature-gates.md
[x] docs/setup/best-practices/certificates.md
[x] docs/setup/production-environment/windows/user-guide-windows-containers.md
[x] docs/tasks/access-application-cluster/web-ui-dashboard.md
[x] docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md
[x] docs/tasks/configure-pod-container/pull-image-private-registry.md
[x] docs/tasks/inject-data-application/define-command-argument-container.md
[x] docs/tasks/run-application/run-single-instance-stateful-application.md
[x] docs/tasks/tools/_index.md
[x] docs/tasks/tools/install-kubectl.md
[x] docs/tutorials/stateful-application/mysql-wordpress-persistent-volume.md

Proposed Solution:
Update the document links to the Korean translated documents.
Page to Update:
https://kubernetes.io/...

/language ko
/assign


Update bench_example version in integration test

Fixes #309

Integration test now passes. CABLE tasks and comparison tasks are successful.


0 health glitch

0 health bug
I'm simply putting this here as just something to look into.
-What exactly causes this bug?
anything that does 200 or more damage (important to note that the purple shotgun in 12.61 does EXACTLY 200 damage and to my knowledge, doesn't cause this bug)
and sometimes if you take over 100 fall damage
-Are there ways of fixing it?
temporary fixes include: awarding siphon, slurp juice, standing in slurp

does that happen every time when you take 200 or more damage

sorry for not seeing this until now. Yes, just about every time. I should mention though that this happens on a chapter 2 build. (C2S2).
It's just about every time AFTER the initial first respawn. (Doesn't do it if respawning is off)


ACDC dataset

Hi Could you please make the ACDC dataset available for using your repository.  It will be very useful for students to just run it in the already working format.

thanks for your interest, i have updated the link to allow you download.


AssertionError: Wrong line separators

Android Studio, 2022.1.1 Patch 1
Plugin not working with erros like:
Got unexpected exception during formatting KtFile: PresetRepositoryImpl.kt

java.util.concurrent.ExecutionException: java.lang.AssertionError: Wrong line separators: '...repository\r\n\r\nimport...' at offset 76

java.lang.AssertionError: Wrong line separators: '...repository\r\n\r\nimport...' at offset

Issue closed lacked to due of response and no reproducer.


Improvements for workQueueManager - wmagent version

1.1.14_wmagent version of
#8748 : (only first commit) improve the performance of dbs file insert
#8755 : Make WorkQueueManagerWMBSFileFeeder slightly more verbose
I'm pushing it to vocms0254 only, because it has an urgent pilot request to acquire and it's acquiring some bad ACDC workflows.

Merging this, if you need to apply other agents, we will do that.


Seeding: Getting Deterministic Results

Hi!
I have had the chance to study your work, and I’ve decided on MARLlib as our MARL framework of choice. Thanks for sharing your fantastic hard work!
While testing MARLlib, I couldn’t help but notice that the results that come out of .fit() are not deterministic. That is, even if the seed: 321 is specified in the the ray.yaml config file, multiple runs of the same algorithm on the same environment will generate slightly differing results.
Being able to reliably obtain a deterministic result would allow any MARLlib user to better test, debug, replicate and confirm their implementations.
From what I could dig around I deduced that there are 2 main parts that need seeding: The environment and the model.
Seeding the Environment.
From the tests I conducted, which were all based on the Cooperative MPE environments, I was able to figure out that while your custom RLlibMPE environment class does not have a way to set the seed, all the libraries below it do. Therefore, by simply calling
env = marl.make_env(
    environment_name='mpe',
    map_name='simple_speaker_listener',
    force_coop=True
)

env[0].env.seed(seed=42)

I was able to test that any subsequent observations and rewards were the same across multiple executions. However, I am not sure this applies across all workers that might not execute this seed setting code. I am not sure how to ensure all workers seed their environments.
To make the API a little more friendly, I was wondering:
Why not also include a seeding method in RLlibMPE, or a way to specify the seed directly via for example: marl.make_env(seed=...)? Perhaps consider adding a seed: ... field in the environment .yaml config file as well?
Seeding the model.
When it comes to the model side of things, I was not able to figure out how to ‘manually’ seed the model initialisation. I was able to determine that the seed argument both via the API (ie .fit(..., seed=xxx)) and via the ray.yaml config file is passed to tune.run(), and then it calls update_global_seed_if_necessary() to set all the seeds. I’ve checked that this function is being called, and it is, but it doesn’t seem to be making a difference. I wonder if this has to do with the multiple workers not executing this code as well.
I was wondering if there are plans on your end to address this seeding issue. I'm sure it would be greatly appreciated by the whole community. Thank you!
Cheers!

Thank you for your attention on our work and all the information.
To ensure deterministic results in MARLlib, you can add the line self.env.seed(321) at this location(works for other environments as well). This will fix the seed for the inner environment.
However, it's important to note that if you have different worker numbers set in two experiments, even with the same seed, the reported results in the tabular format can still differ. This discrepancy could potentially be an issue with Ray/RLlib, and it may require further investigation to determine the cause.
As for the model side, when you set seed 321 to ray.tune, all the algorithms side should be deterministic.
Theo

Hello!
Great news: I was not able to re-create the issues I was having! 😅
Seeding seems to work as intended after appending self.env.seed(...) on line 116 at: https://github.com/Replicable-MARL/MARLlib/blob/0ac275e6132e653f826b107e79963a1485bcd425/marllib/envs/base_env/mpe.py#L95-L116
If I could make a small suggestion - why not pass the seed from the ray.yaml file to the above directly? That way the Ray seed will be all you need to set!
This can be done simply by adding a 'seed' argument to the RLlibMPE.__init__(..., seed=321), and then initialising the env using ENV_REGISTRY[env_config["env"]](env_config["env_args"], seed=env_config["seed"]) in marllib.__init__(), since the ray.yaml config is already merged with the env_configs.
Of course, don't forget to do the same for the COOP_ENV_REGISTRY envs too (and possibly all other envs? 😄)


Tutorial wording fix

Overview

What is it?

[ ] Feature / enhancement
[ ] Bug
[ X] Docs / tests / types / typos

Description
Fixes to the tutorial of:

English grammar and wording
Code examples.

Fixes to English Wording
The fixes to the English are minor -- mainly the insertion of articles ('a', 'the') into the wording.  They improve the legibility and credibility of the tutorial for native English speakers.
Fixes to Code Examples
The fixes to code examples are:

fixes to constant name casing
correct use of TypeScript
English grammar in strings.

Use cases and why
The fixes are to the documentation and code examples only.
Checklist:

[X ] My code follows the developer guidelines of this project
[X ] I have performed a self-review of my own code
[ X] I have made corresponding changes to the documentation
[ N] Added new tests to cover the fix / functionality

(No tests are required as the only changes are to documentation.)

great job @iancharlesdouglas ! thanks! 🙏


Reset vm state

Is there a way to reset a runtime state in order to reuse the same vm instance?
Say one want to manage a fixed pool of runtimes by avoiding to allocate a new instance each time.

Thank you


Fix for NRE when running PowerTools. Thanks for the fix ByteBuilder.

Resolves #15
@lajones

Hi @smitpatel, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Checked into master with commit 9d7ef534.


Support ignore label in softmax_cross_entropy

I want to ignore parts of labels in softmax_cross_entropy, for example output labels of RNNs.

I implemented NN for multitask learning, where intermediate layers are shared among tasks and output layer is separated. This feature can be helpful.


Announcement Page

Describe the bug
inspect shows error.
To Reproduce
Steps to reproduce the behavior:

Go to Announcement
Right Click and click inspect
See error

Expected behavior
The error should be removed
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@smaranjitghose Can I work on this ?


feat: external function modules

Support the ability to mark a module as external when bundling a handler.

How does it look like to use


execute command in callbackquery command

Required Information

Operating system:
PHP version: 7.0
PHP Telegram Bot version: 0.44.1
Using MySQL database: yes
MySQL version: 5
Update Method: Webhook
Self-signed certificate: no
RAW update (if available):

how can I execute a command in  callbackquerycommand
for example, I would like when pres a inlinekeyboard  . execute /start
I used
   $this->getTelegram()->executeCommand('exec');
but this is  not working

I thinks it's useful: # 485

@mohsenshahab Did you check the issue linked by @NabiKAZ?
Namely, this comment should work for you: https://github.com/php-telegram-bot/core/issues/485#issuecomment-298847941

is these codes work for you? i can not call a command with inline keyboard!

@sadeghesfahani Did you get it to work?
If still not, what error(s) do you get?

i get bellow error:
PHP Fatal error:  Call to a member function isPrivateChat() on null in /vendor/longman/telegram-bot/src/Commands/Command.php on line 376
i used bellow code in CallbackqueryCommand.php  execute() method
   $update = json_decode($this->update->toJson(), true);     $update['message']['text'] = '/start';     return (new StartCommand($this->telegram, new Update($update)))->preExecute();

Right, you need to adjust your StartCommand to get the correct message object, or you'll need to add some extra tweak to the code you're using now.
Try using this to get the Message object:
$message = $this->getMessage() ?: $this->getCallbackQuery()->getMessage();

Does that fix it?

i changed StartCommand::execute() in StartCommand.php
$message = $this->getMessage() ? $this->getMessage() : $this->getCallbackQuery()->getMessage();         $chat_id = $message->getChat()->getId();
but still same error

Can you share your StartCommand.php and CallbackqueryCommand.php?
Alternatively, you can also get in touch with me via Telegram directly if you prefer not to share your code publicly: @noplanman

Is this still actual?

This has to do with the fact that the raw_data isn't being set for result objects.
So when trying to get the JSON of the Update object, null is returned, as there is no raw_data property in the Update object. This then causes a problem when using that returned value (which is now null) to instantiate a new Update object, which fails because an array is expected and null is passed.
Example where it fails (in CallbackqueryCommand.php::execute()):
$update = json_decode($this->update->toJson(), true);
return (new MyCommand($this->telegram, new Update($update)))->preExecute();

In these simple cases, the Update object can just be passed directly:
return (new MyCommand($this->telegram, $this->update))->preExecute();

The whole raw data passing is a bit messy and could do with clearing up :confused:


Added "UTF-8 only" comments to three decoders.

Added comments to LineBasedFrameDecoder, JsonObjectDecoder and XmlFrameDecoder that they are only compatible with UTF-8 encoded streams.
No code changes, therefore no tests.

@netty-bot test this please

@alex-vas can please fix the check style errors:
07:00:33 [INFO] Starting audit...
07:00:33 /code/codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java:34: trailing whitespace
07:00:33 /code/codec/src/main/java/io/netty/handler/codec/LineBasedFrameDecoder.java:29: trailing whitespace
07:00:33 /code/codec/src/main/java/io/netty/handler/codec/xml/XmlFrameDecoder.java:63: trailing whitespace
07:00:33 Audit done.

@netty-bot test this please

@alex-vas can you squash and update the commit message to match our template please:
https://netty.io/wiki/writing-a-commit-message.html

Not sure I understand the "squash", but I have updated the last comment.

@alex-vas looks good! can you just also sign our ICLA: https://netty.io/s/icla ?

@alex-vas looks good! can you just also sign our ICLA: https://netty.io/s/icla ?

Done.

@alex-vas thanks a lot... merged.


Use context manager for connections transactions

Eloquent should support context managers for transactions.
with db.transaction() as transaction:
    transaction.table('users').insert({'name': 'foo', 'email'<EMAIL_ADDRESS>

The syntax should actually be:
with db.transaction():
    db.table('users').insert({'name': 'foo', 'email'<EMAIL_ADDRESS>


Clickable and resizable images

Markwon

Clicks can be consumed with ImageClickResolver

Markwon image loader

Image resizes can be maded with addition in end of link this part: /width$height (in dp)

if width/height == 0 image will use self density and non null side

Other

bump buildTools, targetSdk, supportVersion, dagger and okhttp to max actual version
variables names are modified to better match the google codestyle

I didn't find anything about standard of adding to the URL (width$height) in path. Is it your invention? There is markdown section about images sizes, maybe using it would be a better option.

Yes, it's my invention, because md haven't any options for resizing images:

Markdown has no syntax for specifying the dimensions of an image; if this is important to you, you can simply use regular HTML  tags. (source)

Ok, I understand everything you said above and I'll propose the changes later. It remains only to decide how to resize the pictures. Are you sure that my option is not suitable?

@zTrap I have created an issue: #8 . If you want to participate, please do


Global variables

Allow global variables to be stored in localStorage which can be used in request parameters.

Will be available in 0.6


[Storage] [DataMovement] Added Download File Share Tests and Minor Fixes

Added Download Test Base for DataMovement Single Download Transfers
Added Share Files implementation Download tests (of the implementation above) and recordings
Minor fix: Options bag in ShareFileStorageResource initializes options bag, which no longer requires default check when using options bag to make the API option bag requests.

API change check
API changes are not detected in this pull request.


Want to add Rock Paper Scissor game (Python Project)

Please assign it to me under hacktoberfest2022 tag

@anomekumar08

Create a quality issue and work on some good project.


Hi! Have you guys try out batch size larger than 1?I want to know how to implement it?

When I try batch_size = 2
I encountered the following problem

So I checked the Dimension and the problem appears in mask_batch on line of code
rois_label, stu_feature, mask_batch = fasterRCNN(im_data, im_info, gt_boxes, num_boxes)
I don't know how to modify the code because it needs to involve some complicated changes.

Do you have implement it now? @moFang222

@moFang222 @chenaifang Hi thanks for being interested in our research, we have not tried larger than one batch for faster r-cnn, but it is simple, you can implement it yourself.


Adjust to membrane_core v0.12

Related PR in membrane_core: https://github.com/membraneframework/membrane_core/pull/542
Related PR in membrane_rtc_engine: https://github.com/jellyfish-dev/membrane_rtc_engine/pull/262

Changes from this PR will be merged in https://github.com/jellyfish-dev/membrane_webrtc_plugin/pull/116


2 miscellaneous C99 conformance fixes.

i think these were rejected on the mailing list as "gcc and clang don't care, so not a problem".


contribution guidelines for adding multi-file modules/libraries?

It looks to me like spork currently contains only single-file modules. However, some modules that may be a good fit for inclusion into spork may contain multiple files, their own tests, docs, etc. It is not clear how one would create a PR for inclusion of modules/libraries of this type. Would it make sense for there to be a contributions doc for this repository, specifically including guidelines for how to weave in these kinds of "larger" libraries?

One that came to mind is tomlin.

One that came to mind is tomlin.

Or is spork better kept simple and for single-file modules?

Or is spork better kept simple and for single-file modules?

Currently, I think spork is best served by smaller, janet only modules. One reason for this is adding C modules means it may be harder to install in some platforms, but I'm not making a hard line here.

Currently, I think spork is best served by smaller, janet only modules. One reason for this is adding C modules means it may be harder to install in some platforms, but I'm not making a hard line here.

Thank you very much for the answer. I will link the answer to the spork discussion.

Thank you very much for the answer. I will link the answer to the spork discussion.

I guess we can close this, @uvtc.

I guess we can close this, @uvtc.

Yup. Thanks.

Yup. Thanks.


Find-Module -AllVersions returns no results when run against internal/private repositories

In version 1.1.7 of PowerShellGet, running "find-module <module_name> -AllVersions" returns no results when run against private /internal repositories. It does return all versions when run against the powershell gallery.
Version <IP_ADDRESS> of PowerShellGet that ships with Powershell 5.1 doesn't have this problem. It returns all versions of a module regardless of which repository it is run against.
Expected Behavior
Running find-module <module_name> -AllVersions should return all non-prerelease versions of a module from a repository
Current Behavior
find-module <module_name> -AllVersions returns nothing, not even the current version. However, runing find-module <module_name> without the "-AllVersions" does return the current version, regardless of the type of repository.
Possible Solution

Steps to Reproduce (for bugs)

Create a file share on local or remote computer.
Register the repository
Create a module and publish it to the repository.
Increment build number an publish to the repository
Run find-module -Repository <my_repository> will show the current version
Run find-module -Repository <my_repository> -AllVersions returns no results.

Context
We rely on being able to find and install previous versions of modules on occasion if we need to test a previous version of code. With this bug, people who have the latest build of PowerShellGet can't use some of our source code tools.
Your Environment

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.16299.98
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.16299.98
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

> Get-Module
ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Binary     <IP_ADDRESS>    CimCmdlets                          {Export-BinaryMiLog, Get-CimAssociatedInstance, Get-CimClass, Get-CimInstance...}
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Host           {Start-Transcript, Stop-Transcript}
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Management     {Add-Computer, Add-Content, Checkpoint-Computer, Clear-Content...}
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Utility        {Add-Member, Add-Type, Clear-Variable, Compare-Object...}
Script     <IP_ADDRESS>    PackageManagement                   {Find-Package, Find-PackageProvider, Get-Package, Get-PackageProvider...}
Script     1.6.0      PowerShellGet                       {Find-Command, Find-DscResource, Find-Module, Find-RoleCapability...}
Script     1.2        PSReadline                          {Get-PSReadlineKeyHandler, Get-PSReadlineOption, Remove-PSReadlineKeyHandler, Set-PSReadlineKe...

> Get-Module -ListAvailable PowerShellGet,PackageManagement
ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     <IP_ADDRESS>    PackageManagement                   {Find-Package, Get-Package, Get-PackageProvider, Get-PackageSo
Binary     <IP_ADDRESS>    PackageManagement                   {Find-Package, Get-Package, Get-PackageProvider, Get-PackageSo
Script     1.6.0      PowerShellGet                       {Install-Module, Find-Module, Save-Module, Update-Module...}
Script     <IP_ADDRESS>    PowerShellGet                       {Install-Module, Find-Module, Save-Module, Update-Module...}

> Get-PackageProvider
Name                     Version          DynamicOptions
----                     -------          --------------
Chocolatey               <IP_ADDRESS>        SkipDependencies, ContinueOnFailure, ExcludeVersion, ForceX86, PackageSaveMode, FilterOnTag, Contains, AllowPr...
msi                      <IP_ADDRESS>          AdditionalArguments
msu                      <IP_ADDRESS>
NuGet                    <IP_ADDRESS>        Destination, ExcludeVersion, Scope, SkipDependencies, Headers, FilterOnTag, Contains, AllowPrereleaseVersions,...
PowerShellGet            <IP_ADDRESS>          PackageManagementProvider, Type, Scope, AllowClobber, SkipPublisherCheck, InstallUpdate, NoPathUpdate, AllowPr...
Programs                 <IP_ADDRESS>          IncludeWindowsInstaller, IncludeSystemComponent

> Get-PackageProvider -ListAvailable
Name                     Version          DynamicOptions
----                     -------          --------------
Chocolatey               <IP_ADDRESS>        SkipDependencies, ContinueOnFailure, ExcludeVersion, ForceX86, PackageSaveMode, FilterOnTag, Contains, AllowPr...
msi                      <IP_ADDRESS>          AdditionalArguments
msu                      <IP_ADDRESS>
nuget                    <IP_ADDRESS>
NuGet                    <IP_ADDRESS>        Destination, ExcludeVersion, Scope, SkipDependencies, Headers, FilterOnTag, Contains, AllowPrereleaseVersions,...
PowerShellGet            <IP_ADDRESS>          PackageManagementProvider, Type, Scope, AllowClobber, SkipPublisherCheck, InstallUpdate, NoPathUpdate, AllowPr...
PowerShellGet            <IP_ADDRESS>
Programs                 <IP_ADDRESS>          IncludeWindowsInstaller, IncludeSystemComponent

After investigation, I found that this is a regression in <IP_ADDRESS> version of PackageManagement. PowerShellGet provider returns the results but PackageManagement core in <IP_ADDRESS> version doesn't return these results.

This issue was moved to OneGet/oneget#343


some bug in dataloader about the self.types ?

hello,i meet some problem when i frist time run the code.
error:
   different_c_index   = np.random.choice(range(0, self.types - 1), 1)
  File "mtrand.pyx", line 915, in numpy.random.mtrand.RandomState.choice
ValueError: 'a' cannot be empty unless no samples are taken

i think the self.types may be the size of labels,so i change the code and work for me like this,
class SiameseDataset(Dataset):
    def __init__(self, input_shape, lines, labels, random, autoaugment_flag=True):
        self.input_shape    = input_shape
        self.train_lines    = lines
        self.train_labels   = labels
        self.types          = labels.size    #  max(labels)

maybe is difficult version env make this problem?

Your dataset format is wrong. There is a train_own_datasets parameter in train.py needs to be set.

fine,i set train_own_datasets = True,which dataset format wrong?
i used DDP in 8*3090 but i think it slow about dataloader,would you like to add cache image function in training like yolov5?

Can you start training now? I set two data formats, corresponding to different data sets. The original data format corresponds to the omniglot dataset.
I don't set cache, but I think you can improve num_ works.

yeah, i can train now and finish the cache function,thanks for your reply

3q


Any suggestions on modifying this?

Nevermind, I got it.


Email - The email preview of the attached long image is of low quality / resolution

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4550900&group_by=cases:section_id&group_id=292107&group_order=asc
Issue reported by: Applause - Internal Team
Action Performed:

Log in with a Gmail account
Open a chat with a Gmail account where you have access to it's email
Upload the attached long image
Check the Gmail client of the recipient

Expected Result:
The preview should be of higher quality
Actual Result:
The email preview of the attached long image is of low quality / resolution. Other types of images aren't affected
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/5ec31aa5-af2d-4933-be14-23788a684d07

View all open jobs on GitHub

@puneetlath  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp

I think this probably isn't worth our time to try and figure out right now. Going to close, but feel free to comment or reopen if you disagree.


clkdiv: added clkdiv

This change allows arbitrary divider values to be used for the 6MHz FTDI
SPI/JTAG clock.
I find that, on the Lattice NX Evaluation Board, the FTDI clock divider
needs to be set to a value of 3 or higher in order to program the flash
rom. This may be because the board uses an ES (Early Silicon/Engineering
Sample) CrossLink/NX-40. I see similar behavior with the Radiant
programmer where a divisor of 2 or higher is needed.
With a slower clock divider, ecpprog is also able to verify programmed
flash rom content.

This addresses some problems noted in issue #3

Looks good! Thanks! :D


Discuss testing framework and propose formats

The purpose of this issue is to agree upon a test description formats and testing architecture.
It is not primary about a CI although it can and should become part of it
Layered approach,

lowest layer is to send and receive json formated messages, compare with requested values and output statistics. (Implemented currently by scripts/evaluate_tests.py)
second layer is to generate json messages from human readable simpe csv/xlsx format

Challenges

use a similar format as intent definition - to simplify evaluation of the training sets
make sure it  can deal with variable outputs (bot answers alternative outputs for a given input sequence)
interoperability with other testing frameworks (e.g. declarative format rather then language specific code sequence)
ability to propagate back from lower level the location of  error definition (line number?)
permit automatic  generate of test variants e.g.  based on word reordering, tables of synonyms, adding politness e.g. Could you please..., testing of authoring style recommendations e.g. functioning help at any point.

CC: @marek-danel @Tereza-Pytelova

Proposal for format
//# Test name
variant of input I1       variant of output  o1
variant of input I2      variant of output  o2
variant of input I3
Test sequences will be delimited by //# Test name

Postponing this to the next sprint.

Postponing this to the next sprint.

@tomasmacek this could take place in Sprint 24.

@tomasmacek we should try it in the Sprint 25.

We should also agree on json format for workspace tests, simmilar as for functions tests, e.g.
[
  {
    "name": "options dialog",
    "dialog_data": [
      {
        "name": "options turn 1",
        "type": "EXACT_MATCH",
        "input_message": {
          "input": {
            "text": "tell me what are the possibilities"
          }
        },
        "output_expected": {
          "intents": [
            {
              "intent": "OPTIONS"
            }
          ]
        }
      },
      {
        "name": "options turn 2",
        "type": "EXACT_MATCH",
        "input_message": {
          "input": {
            "text": "thanks"
          }
        },
        "output_expected": {
          "output": {
            "text": [
              "You are welcome"
            ]
          }
        }
      }
    ]
  },
  {
    "name": "greeting dialog",
    "dialog_data": [
      {
        "name": "greeting turn 1",
        "type": "EXACT_MATCH",
        "input_message": {
          "input": {
            "text": "Hello"
          }
        },
        "output_expected": {
          "intents": [
            {
              "intent": "GREETING"
            }
          ]
        }
      }
    ]
  },
  {
    "name": "time dialog",
    "dialog_data": [
      {
        "name": "time turn 1",
        "type": "EXACT_MATCH",
        "input": "@pathToFile",
        "output_expected": {
          "intents": [
            {
              "intent": "GREETING"
            }
          ]
        }
      }
    ]
  }
]

FYI @ondrejtomas @tomasmacek


Add files via upload

PR Description 📜
This adds a CODE OF CONDUCT page in the project.
Fixes #2910

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have specified the respective issue number for which I have requested the new game.

Thank you @abhisar-yadav ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit PLEASE REVIEW MY PR

Thank you  @abhisar-yadav , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Problems with catch up

There seems to be some problems with catching up a peer that is behind. As I described on IRC:

The leader decrements the next_index, and then tries to catch up the follower, which responds that it's still inconsistent, so the leader looks at next_index again (and because of the catch up it's the same again) and decrements it.

(More investigation and notes incoming later)
Related: #55

If desired, the protocol can be optimized to reduce the number of rejected AppendEntries RPCs. For example, when rejecting an AppendEntries request, the follower can include the term of the conflicting entry and the first index it stores for that term. With this information, the leader can decrement nextIndex to bypass all of the conflicting entries in that term; one AppendEntries RPC will be required for each term with conflicting entries, rather than one RPC per entry. In practice, we doubt this optimization is necessary, since failures happen infrequently and it is unlikely that there will be many inconsistent entries.

A common and simple thing is for the follower to reply with the length of its log and to cap nextIndex accordingly (there's no use for next index to be more than 1 past the end of the follower's log). Works well for new members and members that are far behind. Doesn't help if there are a bunch of extraneous entries in some log, but I haven't heard of that scenario being a problem in practice.

@ongardie Hm, an interesting idea!

The following diff seems to solve issues with the log index looping. It's now possible (and stable) to end followers and restart them safely. There seems to be an issue if you end the leader and restart them though still.
How LogCabin Does it:

stepDown()
if (response.term() > currentTerm)

diff --git a/src/consensus.rs b/src/consensus.rs
index 225add2..c440a8f 100644
--- a/src/consensus.rs
+++ b/src/consensus.rs
@@ -302,7 +302,8 @@ impl <L, M> Consensus<L, M> where L: Log, M: StateMachine {
                     if latest_log_index < leader_prev_log_index {
                         scoped_debug!("AppendEntriesRequest: inconsistent previous log index: leader: {}, local: {}",
                                       leader_prev_log_index, latest_log_index);
-                        messages::append_entries_response_inconsistent_prev_entry(self.current_term())
+                        messages::append_entries_response_inconsistent_prev_entry(self.current_term(),
+                            leader_prev_log_index)
                     } else {
                         let existing_term = if leader_prev_log_index == LogIndex::from(0) {
                             Term::from(0)
@@ -313,7 +314,8 @@ impl <L, M> Consensus<L, M> where L: Log, M: StateMachine {
                         if existing_term != leader_prev_log_term {
                             scoped_debug!("AppendEntriesRequest: inconsistent previous log term: leader: {}, local: {}",
                                           leader_prev_log_term, existing_term);
-                            messages::append_entries_response_inconsistent_prev_entry(self.current_term())
+                            messages::append_entries_response_inconsistent_prev_entry(self.current_term(),
+                                leader_prev_log_index)
                         } else {
                             let entries = request.get_entries().unwrap();
                             let num_entries = entries.len();
@@ -400,12 +402,12 @@ impl <L, M> Consensus<L, M> where L: Log, M: StateMachine {
                 self.leader_state.set_match_index(from, follower_latest_log_index);
                 self.advance_commit_index(actions);
             }
-            Ok(append_entries_response::Which::InconsistentPrevEntry(..)) => {
+            Ok(append_entries_response::Which::InconsistentPrevEntry(index)) => {
                 scoped_assert!(self.is_leader());
-                let next_index = self.leader_state.next_index(&from) - 1;
+                let next_index = index;
                 scoped_debug!("responder had inconsistent previous entry, rolling it back to {}",
                     next_index);
-                self.leader_state.set_next_index(from, next_index);
+                self.leader_state.set_next_index(from, next_index.into());
             }
             Ok(append_entries_response::Which::StaleTerm(..)) => {
                 // The peer is reporting a stale term, but the term number matches the local term.
diff --git a/src/messages.capnp b/src/messages.capnp
index 6c45a51..a521dd4 100644
--- a/src/messages.capnp
+++ b/src/messages.capnp
@@ -72,9 +72,10 @@ struct AppendEntriesResponse {
     # The `AppendEntries` request failed because the follower has a greater term
     # than the leader.

-    inconsistentPrevEntry @3 :Void;
+    inconsistentPrevEntry @3 :UInt64;
     # The `AppendEntries` request failed because the follower failed the
-    # previous entry term and index checks.
+    # previous entry term and index checks. Includes the index of the
+    # inconsistent entry.

     internalError @4 :Text;
     # an internal error occured; a description is included.
diff --git a/src/messages.rs b/src/messages.rs
index 49ae6f7..481bb66 100644
--- a/src/messages.rs
+++ b/src/messages.rs
@@ -88,13 +88,13 @@ pub fn append_entries_response_stale_term(term: Term) -> Rc<MallocMessageBuilder
     Rc::new(message)
 }

-pub fn append_entries_response_inconsistent_prev_entry(term: Term) -> Rc<MallocMessageBuilder> {
+pub fn append_entries_response_inconsistent_prev_entry(term: Term, index: LogIndex) -> Rc<MallocMessageBuilder> {
     let mut message = MallocMessageBuilder::new_default();
     {
         let mut response = message.init_root::<message::Builder>()
                                   .init_append_entries_response();
         response.set_term(term.into());
-        response.set_inconsistent_prev_entry(());
+        response.set_inconsistent_prev_entry(index.into());
     }
     Rc::new(message)
 }

what's the issue when restarting the leader? Also, why not open a PR with the diff? Also, we should open an issue about testing. There's barely anything there as far as I can tell.

@tschottdorf See #12!

Digging some more I think we might have the implementation of inconsistent_log_term incorrect.

If an existing entry conflicts with a new one (same index but different terms), delete the existing entry and all that follow it (§5.3)

However we currently don't do this:
if existing_term != leader_prev_log_term {
    scoped_debug!("AppendEntriesRequest: inconsistent previous log term: leader: {}, local: {}", leader_prev_log_term, existing_term);
    messages::append_entries_response_inconsistent_prev_entry(self.current_term(), leader_prev_log_index)
} else {


Add Toastify Notification on Submit Button Click.

Feature Request
I suggest adding a Toastify Notification when the Submit Button is clicked. This notification can be used to provide feedback to the user, such as confirming that the query has been submitted or that the query has been copied.

#Additional Information:

If there are specific elements or sections that need improvement, mention them by making new issues.
Consider attaching images to illustrate your suggestions.

Please leave a comment on this, then I'll try to assign the task accordingly.
If your contribution is well-received, I encourage you to submit a Pull Request with the changes.
Feel free to ask questions or seek clarification on any aspect of the improvements.
#Good Luck! ✌

I want to contribute and implement the Toastify notification feature. Kindly assign it to me under SWOC'24.

Hello @Anubhab-03,
Thanks for your interest in this issue.⭐
Here's my concern,

As per the SWOC rules, we (Project Admins) can assign the tasks to the Contributors from 1st of Jan.
But you can work on this now and keep me update your output through images/videos in the comment section.
And one more thing, don't make any PR now, you can do it when the program begins (On 1st Jan).

So don't worry, I'll assign this task to you with the tag on 1st of Jan.
Hope you got my points!
Thanks For Understanding! ✌

Feel free to ask any questions for further clarification.
#Good Luck!✌

Got it @PranabKumarSahoo

Join Discord Channel for discussion/doubts/questions. ✌

I would like to work on this issue under SWOC 2024.

Hello @ayann07,
Thanks for your interest in contributing!

The Toastify Notification feature task has already been assigned to @Anubhab-03 on a FCFS(first-come, first-served) basis under SWOC.
But you can also work on this. So make your changes and keep me update your progress through images/videos in the comment section.

I'll choose the best! 😉
For real-time communication and any immediate queries, you can join the Discord Server.

Feel free to ask any questions for further clarification.
#Good Luck!✌

Hello @ayann07,
I wanted to inform you that the Toastify Notification feature task has been successfully implemented by @Anubhab-03, and the pull request has been submitted. Great job, @Anubhab-03!
Given that the task has been completed, I am closing this issue now. Thank you for your interest in contributing!
Your participation is highly valued, and I look forward to your continued contributions.

If you have any questions, need clarification, or would like to work on another task, feel free to let me know.
#Good luck! ✌


Add org page

Co-authored-by: rrchai<EMAIL_ADDRESS>Co-authored-by: vpchung<EMAIL_ADDRESS>Fixes #100

Preview
Component org-profile-header


If the playback thread experiences an audio API error, it never comes back

This requires a complete restart of the application in order to get playback working again. That's... less than ideal, especially given how easy it is to select a broken / unusable audio device on Linux.

Resolved by 97a23e0 and 6e89089.


Inputs should be set to use Lato typeface for user input

Inputs should be set to use Lato typeface for user input
Originally posted by @bameyrick in https://github.com/ONSdigital/pattern-library-v2/issues/163#issuecomment-465541240

 Issue #205: Inputs should be set to use Lato typeface for user input


rescript-vscode non working after a fresh install

New to rescript, i've done all steps specified in the getting started page and furthermore installed the visual studio code plugin but as I try to edit neither completion nor error highlighting works.
I've tried all steps on the plugin gif but if i can populate the first line for the rest nothing is working the same.
I don't know which file to pass you for exploring the configuration but it's exactly the same as in the getting started template repo.
I've asked the question on stackoverflow but can't get an answer they're so I'm putting it here as well.

Hi. What OS? And did you start a bsb build?


Stripe Issue : const stripe = require("stripe") "Error,  Cannot call this expression. The type 'typeof import("stripe")' has no call signature."

Hello, I tried to make an ecommerce site using stripe but I'm stuck... I've followed the documentation, watched videos but I can't use it... I don't understand what's wrong with my statement can someone help me please?

Hi there,
This is the repo for Stripe Apps, not all of Stripe. We recommend you to join our Developer discord where our team can help you: https://stripe.com/go/developer-chat


🐛 Bug Report: Disable DynamicPluginsTable thirdClickSort due to bad user experience

📜 Description
Material UI by default has an odd behavior for sorting tables.
On the third click on column sort, the sorting is cleared and it looks like a bug (as our QE observed)
It's possible to disable it, but the backstage table doesn't by default and so the RHDH catalog has this behavior.
WDYT about disabling this feature?
You can see the behavior by clicking three times on sort on of the columns in the catalog table
👍 Expected behavior
The table should always present the data in a user friendly format.
👎 Actual Behavior with Screenshots

👟 Reproduction steps

Trigger some workflows
go to workflows run table
Click sort by started 3 times (until arrow is grey)
Observe data in table, it isn't presented in a user friendly format.

📃 Provide the context for the Bug.
It is just an eye sore, table data should always be easy for the user to read and understand
🖥 Your Environment
rhdh deployed on OCP with Orchestrator and Notifications plugins installed
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

Just wanted to add on some details. Backstage actually uses @material-table/core for it's tables and not the ones in Material-UI. I learned about that when working on a recent update to the Catalog Index customization docs here: https://backstage.io/docs/features/software-catalog/catalog-customization#table-options
You can see an working demo of this issue here: https://demo.backstage.io/catalog?filters[kind]=component&filters[user]=all. Just click on one of the column headers three times. I do find to really notice this you need to cycle through it a few times, the arrow really helps make it more obvious IMO.
@condawrangler, I don't know what "rhdh" is can you share more details? I'm also not familiar with the "Orchestrator" plugin, can you share a link, please? I'm assuming this is what is shown in your screen shot?

The 'third option sort' is indeed useful in certain cases. However, plugin authors have the option to disable this feature if they prefer. I recommend opening an issue at https://github.com/janus-idp/backstage-plugins, as the plugin you're referring to is managed there.

Closing this in favour of the "Table improvemnts RFC": https://github.com/backstage/backstage/issues/22735. I also want to mention that the problem you are running into is related to a specific implementation of Backstage (RHDH) so you might want to reach out to that team instead of raising the issue here.

Hi @tudi2d, you can actually see this on the demo site
Catalog: https://demo.backstage.io/catalog?filters[kind]=component&filters[user]=all
GitHub Actions: https://demo.backstage.io/catalog/default/component/backstage-demo/ci-cd
Docs list: https://demo.backstage.io/docs?filters[user]=all
This does seem to be an Backstage "issue". I don't know the solution but I'll be honest it's confused me often, I've just lived with it.

Hi @tudi2d, you can actually see this on the demo site
Catalog: https://demo.backstage.io/catalog?filters[kind]=component&filters[user]=all GitHub Actions: https://demo.backstage.io/catalog/default/component/backstage-demo/ci-cd Docs list: https://demo.backstage.io/docs?filters[user]=all
This does seem to be a Backstage "issue". I don't know the solution but I'll be honest it's confused me often, I've just lived with it.

so what you are seeing is the "default material ui behaviour", which is inherited by all the tables.
However, plugin authors can customize this behaviour by passing custom props to the Table component. This is the reason why we believe this isn't a bug affecting Backstage. The behaviour might sound confusing but it actually makes sense if you think about data sorted server side according to some criteria. You can decide to sort the data asc or desc on a column or you can reset to the default sorting.


newrelic-infra-operator not deploying nri-kube-events integration on Fargate

Description
There seems to be a bug in the operator where we are accidentally using the same name for the volumes of what we inject and nri-kube-events.
Steps to Reproduce
Deploy latest version of newrelic-infra-operator on Fargate cluster. Events integration does not deploy successfully.
Expected Behavior
Events integration deploys successfully.

Hello!
Can you share the yaml of the nri-kube-events with the injected sidecar? with version of the newrelic-infra-operator are you running?
The release v0.4.0 was fixing that issue https://github.com/newrelic/newrelic-infra-operator/releases/tag/v0.4.0 are you running an updated version of the operator? If so can you share the yaml of the operator and the content of the config map mounted?

This issue was closed because it has been inactive for a long time despite it can be reopened at any point if you think it still relevant.
Thank you for your contribution!


Renamed the export function to have Async postfix

for clarity. If agreed, I’d add this to the coding guidelines we have too.

I have to admit, I don't recall seeing APIs call out in the function name that a function is async. So personally, I would avoid this.

Sounds good, closing.