Can't make it work on Docker Desktop K8s (Mac)

Hi
In order to make the deployment work on K8s by Docker Desktop (Mac) I had to modify the deployment manifest:
  volumes:
      - name: tf-serving-volume
        hostPath:
          #path: /var/tmp/saved_model_half_plus_two_cpu
          path: /tmp/saved_model_half_plus_two_cpu
          #type: Directory

Then verified the deployment was up and running:
kubectl get pods
NAME                                     READY   STATUS    RESTARTS   AGE
tf-serving-deployment-6c4f4dc9d6-nbhq8   1/1     Running   0          53m

Then I forwarded the pod port:
kubectl port-forward tf-serving-deployment-6c4f4dc9d6-nbhq8 8501:8501
Forwarding from <IP_ADDRESS>:8501 -> 8501
Forwarding from [::1]:8501 -> 8501

And when trying to run a POST command to get a prediction, the pod refuses the connection request:
curl -d '{"instances": [1.0, 2.0, 5.0]}' -X POST http://localhost:8501/v1/models/half_plus_two:predict
curl: (52) Empty reply from server

E0225 10:46:00.303384   62138 portforward.go:400] an error occurred forwarding 8501 -> 8501: error forwarding port 8501 to pod aaecd472db77fbd0d7684f213bf653f70f4fdede346e05d5c2b255d3b495fed4, uid : exit status 1: 2022/02/25 16:46:00 socat[36952] E connect(16, AF=2 <IP_ADDRESS>:8501, 16): Connection refused
This is unusual to me as K8s from Docker Desktop normally behave like a regular K8s deployment. I'd appreciate some guidance as I think that it'd be good to understand how TF serving works in a real K8s cluster and not only on Minikube/VirtualBox.
thanks

Hi! Sorry for the late reply. Next time, you can post or search for similar topics in our community. There might be mentors/learners there who have the same setup and can help you. If you haven't joined yet, you can find instructions in Week 1 of your classroom. Thank you!


Move Request types to dependencies & fix functionConf type

@types/request needs to be a dependency instead of devDependency. If we build a library with node-vault as dependency, @types/request are missing
It also fixes functionConf type

@kr1sp1n This fixes the issue introduced in https://github.com/kr1sp1n/node-vault/pull/142

@kr1sp1n Could you please take a look on this one? It fixes 2 bugs with types introduced lately.

@Kamahl19 do you mind removing the package.json change?


[WIP] Improved Utilities

Includes UI improvements and additions:
Improvements:

[x] Results filepath is conserved across utils
[x] Selected layer is retained when possible
[x] Utils output creates a layer and updates it instead of making new layers
[ ] Bring above change to CRF

Additions:

[x]  Util to crop larger volumes into smaller cubes for training
[ ] Tests + coverage

Codecov Report

:exclamation: No coverage uploaded for pull request base (cy/training@1971d8d). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             cy/training      #44   +/-   ##
==============================================
  Coverage               ?   80.94%
==============================================
  Files                  ?       45
  Lines                  ?     4923
  Branches               ?        0
==============================================
  Hits                   ?     3985
  Misses                 ?      938
  Partials               ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Ability to check c7n-org version

Nice to have an ability to verify the installed version of c7n-org

nvm, this can be verified by running pip show c7n-org


Fix spinner / progress bar when saving

Screenshot:

Note: this does not change any existing loading indicator. There was no working loading indicator before.
Fixes #856
Fixes #790

FWIW, actual page size will be much smaller because the wordpress/components script won't be loaded.


When tap on the last line, the cursor immediately jumps back to the first line

When using the iOS 16, after entering several empty lines in the editor, then moving the cursor to the second line and clicking on the last line, the cursor will immediately jump to the first line.

Thanks for reporting this issue. It's fixed in #218.


[WIP] Cassandra Support

Unfortunately this runs into a problem described here: http://stackoverflow.com/questions/36877897/detected-guava-issue-1635-which-indicates-that-a-version-of-guava-less-than-16
java.lang.ExceptionInInitializerError
	at geotrellis.spark.io.cassandra.CassandraInstance$class.getCluster(CassandraInstance.scala:21)
	at geotrellis.spark.io.cassandra.BaseCassandraInstance.getCluster(CassandraInstance.scala:60)
	at geotrellis.spark.io.cassandra.CassandraInstance$class.getSession(CassandraInstance.scala:22)
	at geotrellis.spark.io.cassandra.BaseCassandraInstance.getSession(CassandraInstance.scala:60)
	at geotrellis.spark.io.cassandra.CassandraInstance$class.withSessionDo(CassandraInstance.scala:38)
	at geotrellis.spark.io.cassandra.BaseCassandraInstance.withSessionDo(CassandraInstance.scala:60)
	at geotrellis.spark.io.cassandra.CassandraAttributeStore.<init>(CassandraAttributeStore.scala:28)
	at geotrellis.spark.io.cassandra.CassandraAttributeStore$.apply(CassandraAttributeStore.scala:19)
	at geotrellis.spark.io.cassandra.CassandraAttributeStore$.apply(CassandraAttributeStore.scala:22)
	at geotrellis.spark.io.cassandra.CassandraLayerWriter$.apply(CassandraLayerWriter.scala:56)
	at demo.Config.writer(Config.scala:63)
	at demo.LandsatIngestMain$.main(LandsatIngest.scala:168)
	at demo.LandsatIngestMain.main(LandsatIngest.scala)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.apache.spark.deploy.yarn.ApplicationMaster$$anon$2.run(ApplicationMaster.scala:542)
Caused by: java.lang.IllegalStateException: Detected Guava issue #1635 which indicates that a version of Guava less than 16.01 is in use.  This introduces codec resolution issues and potentially other incompatibility issues in the driver.

To repeat ingest error just run: make upload-code && make create-cluster && make ingest

we can close that pr, due to #5


Merge alert to case

This PR adds an API function to merge an alert into an existing case.
NB! Adding empty JSON payload, since the backend API wants a POST request, but does not have any parameters defined as payload data.

Thanks @haam3r for the PR, I'll rename the method to merge_alert_into_case instead of merge_alert_to_case to be compliant with the UI.


Provide a way to selectively execute tests

What are you trying to achieve?
Selectively run a subset of tests without "skip"ing all the rest
What do you get instead?
At the moment, I have a mechanism in a hook to skip a test if it matches a set of criteria, one of which being a relevant tag being present in a list.
example: https://github.com/codeceptjs/CodeceptJS/issues/661

Provide console output if related. Use --verbose mode for more details.
n/a

Provide test source code if related
n/a - this is extremely broadly applicable to any and all tests, it's only specific to the use of @tag notations in test scenario strings.

But a basic example:
const { I } = inject();
Feature("Some Feature");

Scenario("A scenario description @tag1 @skip @tag2", async () => {
  console.log("Execute some code here");
});

@skip @otherTags
Scenario: Some scenario
  Given I do something first
  When I do another thing
  Then I see a result

Details

CodeceptJS version: 3.3.6
NodeJS Version: 14.19.2
Operating System: Ubuntu 20.04
puppeteer || webdriverio || testcafe version (if related): possibly related: playwright
Configuration file: n/a

Hack Implementation
I'm not really sure how to do all the things necessary to offer a PR on this project.  I'm also not sure if this project is appropriate, or if it's more appropriate to offer a solution to the Allure project (https://github.com/allure-framework/allure-js) or the Mocha project (https://github.com/mochajs/mocha) given the motivation and maybe draft? solution(s) for mocha and/or CodeceptJS as referenced https://docs.qameta.io/allure-testops/integrations/test-frameworks/.
So, I've built what will roughly do what I need in my own codebase, though I'll need to patch it after every update.
A test scenario, (bdd or plain-code, doesn't matter)
@tag1
Scenario: Some scenario
  Given I do something first
  When I do another thing
  Then I see a result

In codecept.conf.js (where the property value is an array, but could also be a function result after importing and transforming an external file content).
module.exports = {
  ...
  selective: ["tag1", "tag2"],
  ...
}

In lib/container.js, add the if (config.selective) block
...
class Container {
  ...
  static create(config, opts) {
    const mochaConfig = config.mocha || {};
    if (config.grep && !opts.grep) {
      mochaConfig.grep = config.grep;
    }
    if (config.selective) {
      mochaConfig.selective = config.selective;
    }
    this.createMocha = () => {
      container.mocha = MochaFactory.create(mochaConfig, opts || {});
    };
    ...
  }
 ...
}
...

In lib/mochaFactory::create(), added a new prototype definition on the Mocha object and then call the function; on or about line 44/45 in CodeceptJS v3.3.6
        Mocha.prototype.selective = function(selective) {
          if (!selective) {
            return this;
          }
          if (!Array.isArray(selective)) {
            throw new Error("Must provide an array.");
          }
          const re = selective.join("|");
          const regex = new RegExp(re);
          this.grep(regex);

          return this;
        };

        mocha.selective(config.selective);

Weakness/Uknowns

I don't know whether this is the "right" place or even the correct way of adding this code, but it's the most concise I've found that seems to at least work with the codeceptjs run command and both BDD and plain-code tests.
I'd love to be able to use a command line parameter like --selective, maybe even with a file path, but I couldn't figure how to modify the command prompt for codecept and have it follow through into mocha.
This leverages regex/grep which mocha seems to really advise against; preferring instead that developers utilize the .only() methodology.  However, I couldn't figure out how to call the .only() method or any related functionality via a programatic before.test or before.suite event; like I was able to programmatically skip() as described in issue 661.
This is important because programmatically skipping 450 out of 500 tests when I only want to execute a specific list of 50 makes the reporting a huge mess.  Plus, I couldn't find this capability so as to be able to fully implement Allure / Allure TestOps.

Summary
Hopefully someone with greater experience in CodeceptJS and/or Mocha can see this and maybe this will provide some inspiration for a quick(er) patch.  If not, then anyone else coming along might be able to use this to patch their own installation.

On second (or third) examination, this can be done via bootstrap in the codecept.conf.js:

const { container } = require("codeceptjs");

exports.config = {
  ...
  bootstrap: async function () {
    const mocha = container.mocha();
    mocha.selective = function(selective) {
      if (!selective) {
        return false;
      }
      if (!Array.isArray(selective)) {
        throw new Error("Must provide an array.");
      }
      const re = selective.join("|");
      const regex = new RegExp(re);
      mocha.grep(regex);

    };

    mocha.selective(["tag1", "tag2"]);

    return null;
  },
  ...
}

Where the array in `selective()` could be provided programmatically with or without an environment variable

Looks like a good approach and nice example of using bootstrap!
Thank you!


Javascript Transformations: UI support

Feature description
It should be possible to create a JS transformation through the UI.

@neovintage this feels work keeping around. Definitely a gap in UI capabilities.

UI will be deprecated soon.


Is there a way to disable a collector from the config file?

I can just remove the collector ofcourse, but I wonder if there is a way to let's say, specify enabled = 1 in the config. I can build it in otherwise...

You can use this patch for now:
https://github.com/kormoc/Diamond/commit/665841def787b45fc78e890ffe4b05fd57e28e74
It will be in the main repo in a few days


countvectorizer returns incorrect dimensions

count_vec = CountVectorizer() final_tr=train.map_partitions(count_vec.fit_transform).compute() final_te=test.map_partitions(count_vec.transform).compute()
when i m trying to print shape
it s getting
(46, 1)
i am passing around
846065 data points
train and test are dask dataframes

Closing due to lack of response.


Positioning the map

I conduct a search for nodes.
Got the coordinates of the node
How to position the map so that the node is in the center of the screen

I'd think that what you did at #7 is the right way.

not positioned on the node

Could you explain your problem in more detail please?
It looks the same problem as #7 to me.


Firestone Spell

Hello wowsim team!
I noticed that Firestone, and any level of the spell created item for warlocks, isnt in the DPS or Tank sim for them. Though it is more relevant for the Tank sim due to melee weaving.
Could you please add the class created item! Ill provide the link down below.
Additional context
I have an idea I would love to sim for melee weaving caster dps, and I would like to test if the Firestone is better than Shadow oil or Lesser Wizard oil. They take the same slot and Ive wanted to test out Firestone melee weaving since phase 2 but it was never supported and lesser wizard oil seems to be better for meta warlocks, or simply using Shadow Oil.
here is the link to the Spell information on Firestone (Greater) the one that is currently avialable at level 50:
Spell: https://www.wowhead.com/classic/spell=17952/create-firestone-greater
Item: https://www.wowhead.com/classic/item=13700/greater-firestone
I hope this email found you well!
Kindest Regards,
-Vossiel

Hey @Vancopland 👋 The ability to select Firestone/Spellstone is only available when you unequip your off-hand. When you do, you'll see an extra input in the Setting Tab's Player inputs and you'll be able to select one of the stones there.


Column spacing on withdrawals list is too wide

Description
On the withdrawals tab the columns should be [auto] sized to show more data - the first screenshot is how the table opens on my machine and the second is more like how it ought to look.
Acceptance Criteria

[ ] Check on default column spacing on a 13in screen

Superseded by assets rework


Support for Phi-3-mini-128k-instruct

Phi-3-mini-128k-instruct has the same number of parameters and same architecture as Phi-3-mini-4k-instruct, unless I am mistaken. Would it be possible for unsloth to support inference for this model as well? Thank you.

The issue is RoPE scaling is different for Phi-3  4K and 128K - they use some weird dynamic RoPE scaling which I haven't yet looked into


Chapter grid component

Fixes #169
Adding the chapter grid component

Codecov Report

Merging #204 (1bc4266) into master (c447a54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   41.27%   41.27%
=======================================
  Files          99       99
  Lines        1267     1267
  Branches      231      231
=======================================
  Hits          523      523
  Misses        712      712
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c447a54...1bc4266. Read the comment docs.

Codecov Report

Merging #204 (80c29cf) into master (c447a54) will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   41.27%   41.67%   +0.39%
==========================================
  Files          99       99
  Lines        1267     1267
  Branches      231      231
==========================================
+ Hits          523      528       +5
+ Misses        712      706       -6
- Partials       32       33       +1

Impacted Files
Coverage Δ

src/app/shared/auth/auth.service.ts
30.30% <0.00%> (+7.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c447a54...80c29cf. Read the comment docs.


beer-song: Rewrite tests and add working stub solution.

Add HINTS.md explaining that the exercise is about refactoring.
Use lyrics from x-common/exercises/beer-song/description.md.
Tests all lines, one by one, and then the entire song.
Remove old tests checking verses.
Add stub solution passing the tests.
Patch example solution to work with the new tests.

Related to #301.

Seems good!


New login issue

One of my account is having problem logging in. It returns this error message: You are using an older version of Snapchat. Please update to the latest version to log in :)
Other accounts are fine. I think the reason is I logged in from the latest official snapchat app using that account. Then all of sudden I can't log in with that account using the script anymore. Always give me that error.
Logged in from the official snapchat app with another account, and that account starts to get the same error. Is snapchat coming up with some new trick?

Logged in from the official snapchat app with another account, and that account starts to get the same error. Is snapchat coming up with some new trick?

On one account I also got a warning + one with 3rd party warning. On my android vm there was a new update of the snapchat app, so maybe the update is still rolling out.

I tried to update the user-agent to <IP_ADDRESS> which is the latest version, then I get "login temparily failed" error.

Try sending a request thru a middleman proxy and analyzing exactly what
user agent it uses now.
On Tue, Apr 28, 2015 at 09:09 rpw98<EMAIL_ADDRESS>wrote:

I tried to update the user-agent to <IP_ADDRESS> which is the latest version,
then I get "login temparily failed" error.
—
Reply to this email directly or view it on GitHub
https://github.com/mgp25/Snap-API/issues/93#issuecomment-97054684.

@ferdau This time is a little different I think. Before I was able to log in from official snapchat app and this  script before. But now once I logged in from the official app, I can't log in with script anymore. :-(

Til we update the new login mechanish.
Regards

How often does Snapchat change their login API? Seems like they do it pretty much every update.....

Yes, mostly because of us

yep, we're the main reason they do it

We must continue to fight the oppression! Resist the Snapchat foes!

lol yea they keep trying but I have yet to see anything that's stopped us for any period of time (that is, soley using the API) besides the latest attestation check. even that doesn't really count because the attestation is Google's code, not Snapchat's.

and it will be broken by me and @mgp25 within a week or 2 if things go as planned

@MasterEjay @rpw98 I actually fixed this today :)


changing the includes function to contains

Per a conversation I had with @robes, I changed the .includes(...) function to .contains(...). Here is the noteworthy information.
"Logician George Boolos strongly urged that "contains" be used for membership only and "includes" for the subset relation only."

Assigning to @robes for review and merge.

Interesting subtlety here! I didn't know about "contains" vs "includes".


Crash on testing requirements

there is a bug in the latest version when requirements are tested. in bwx-game.py, when you try and go into the elevator, which requires the pebble and the key, there is a crash:

        --=( You are in the Intersection )=--

A boring intersection. There is a passageway to the
north that leads to the shop. To the east is the elevator
landing, to the west is the guest lounge, and to the
south is the reception desk. There is nothing to do here.

> go east
Traceback (most recent call last):
  File "bwx-game.py", line 310, in <module>
    my_game.run(update)
  File "/home/ubuntu/workspace/advent.py", line 417, in run
    if f( actor, noun, words ):
  File "/home/ubuntu/workspace/advent.py", line 658, in act_go1
    if loc == None:
  File "/home/ubuntu/workspace/advent.py", line 511, in go
    if set(c.point_b.requirements).issubset(set(self.hero.inventory)):
AttributeError: 'Location' object has no attribute 'hero'

it seems with the refactoring, we lost a reference to hero in location. should Location have a reference to the Game object? then it would be able to find hero through self.game. hero, or is there a better way to get the hero from the Location instance?

oops, spoke too soon. we do have a reference to game in Location, just had to tweak the code. nevermind, fixed :)


[App Service] Fix #22722: az webapp config ssl import fixes to support new GraphAPI for SP queries

Fixes #22722
Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

App Service

@zhoxing-ms / @wangzelin007 can we merge this change?

@jiasli Please help review the Graph related changes


pkg/k8s: allow from both namespace and pod selector in KNP

Signed-off-by: André Martins<EMAIL_ADDRESS>Fixes: https://github.com/cilium/cilium/issues/3767

This change is

test-me-please

@aanm Does this include any functional change or only added tests?

@aanm Does this include any functional change or only added tests?

@tgraf did you miss pkg/k8s/network_policy.go?

Out of curiosity, why can't both of these be set? is it because the namespace selector is purely a namespace == foo thing? If I wanted a cross-namespace rule I would include the namespace tag in the podselector? If so, couldn't I also select the whole namespace with a namespace = wildcard thing?

Both can be set https://github.com/cilium/cilium/pull/4354/files#diff-92803b90ff4e68fc0c9b00607fa4bc1bR1484

Looks good. It will be helpful in the future to separate real changes and cosmetic code moves/cleanups.

@tgraf they look like they are cosmetic code moves but they are not, the fact the namespaceSelector takes precedence over the podSelector is a real change in this case.

test-missed-k8s

test-missed-k8s

@aanm Any reason not to merge this into 1.1. It is a bugfix.

@tgraf this is a feature that is going to be introduced in k8s 1.11, which is not released yet.
We can either wait for k8s 1.11 is released and then backported to 1.0 or backport it now. I'm fine either case

this is a feature that is going to be introduced in k8s 1.11, which is not released yet.
We can either wait for k8s 1.11 is released and then backported to 1.0 or backport it now. I'm fine either case

OK. I don't see a problem enabling this now and prepare 1.1 for k8s 1.11 already. I think we should merge it into 1.1. I don't see a difference in merging now or backporting it later to 1.1.


[CI] Job to update REST and GraphQL docs #7956

Notes for Reviewers
This PR fixes #7956
Signed commits

[ ] Yes, I signed my commits.

@suhail34 this is very nice to see.

@suhail34 this is very nice to see.

Thanks @leecalcote for appreciating

@suhail34 thanks for this. To the extent that these steps are not reusing Meshery's existing make targets, we're going to run into discrepancies between the manual builds and the automated builds. Can you have this workflow reuse the make targets, perhaps?

@suhail34  Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

Gents, shall we close out this PR or would you like to address this feedback within this PR? https://github.com/meshery/meshery/pull/8076#pullrequestreview-1522854402

Gents, shall we close out this PR or would you like to address this feedback within this PR? #8076 (review)

@Lee @suhail34 has updated to use make commands https://github.com/meshery/meshery/pull/8076/commits/61055d4daaec583913a693f23b1d5bb75fd7ba72

Oh, super. Great job, guys. @suhail34, you've been doing some good work. Hit me up in Slack and let's chat about how we might support you in being even more impactful.

We don't this job now?

Gents, shall we close out this PR or would you like to address this feedback within this PR? #8076 (review)

@leecalcote update to use make commands has been made. This PR can be closed.

@leecalcote By closed, I meant merged 😅 . This PR looks good.

If we don't remove docs from paths-ignore I think it will not be able to track the changes in docs directory so there will be no commits made
https://github.com/meshery/meshery/blob/7dfa087289e4cbc8444a879d4a9837ce8514ea2b/.github/workflows/build-and-release-edge.yml#L7-L8


TypeError: getattr(): attribute name must be string from "null_text_w_ptp.ipynb" file

I am trying to run the jupyter file and third block give me the following error.
scheduler = DDIMScheduler(beta_start=0.00085, beta_end=0.012, beta_schedule="scaled_linear", clip_sample=False, set_alpha_to_one=False)
MY_TOKEN = ''
LOW_RESOURCE = False
NUM_DDIM_STEPS = 50
GUIDANCE_SCALE = 7.5
MAX_NUM_WORDS = 77
device = torch.device('cuda:0') if torch.cuda.is_available() else torch.device('cpu')
ldm_stable = StableDiffusionPipeline.from_pretrained("CompVis/stable-diffusion-v1-4", use_auth_token=MY_TOKEN, scheduler=scheduler).to(device)
try:
ldm_stable.disable_xformers_memory_efficient_attention()
except AttributeError:
print("Attribute disable_xformers_memory_efficient_attention() is missing")
tokenizer = ldm_stable.tokenizer

TypeError                                 Traceback (most recent call last)
Cell In[3], line 8
6 MAX_NUM_WORDS = 77
7 device = torch.device('cuda:0') if torch.cuda.is_available() else torch.device('cpu')
----> 8 ldm_stable = StableDiffusionPipeline.from_pretrained("CompVis/stable-diffusion-v1-4", use_auth_token=MY_TOKEN, scheduler=scheduler).to(device)
9 try:
10     ldm_stable.disable_xformers_memory_efficient_attention()
File ~/anaconda3/envs/p2p/lib/python3.8/site-packages/diffusers/pipeline_utils.py:373, in DiffusionPipeline.from_pretrained(cls, pretrained_model_name_or_path, **kwargs)
370     if issubclass(class_obj, class_candidate):
371         load_method_name = importable_classes[class_name][1]
--> 373 load_method = getattr(class_obj, load_method_name)
375 loading_kwargs = {}
376 if issubclass(class_obj, torch.nn.Module):
TypeError: getattr(): attribute name must be string
any comments?
All the other jupyter file works well.

I also tried to bring Stable-diffusion v-2.1, and it also didn't work :(

You can try pip install diffusers==0.10.0 rather than 0.3.0

It was working fine with diffusers==0.3.0 uptil recently
It's not working now, any potential fix?

the problem is solved but it raise a new one
TypeError: PNDMScheduler.set_timesteps() got an unexpected keyword argument 'offset'
how should i fix it

Yes i got the same issue. neither diffusers 0.3.0 or 0.10.0 could work

the problem is solved but it raise a new one
TypeError: PNDMScheduler.set_timesteps() got an unexpected keyword argument 'offset'
how should i fix it

Just omit line 163 and revise model.scheduler.set_timesteps in ptp_utils.py
    # set timesteps
    # extra_set_kwargs = {"offset": 1}
    # model.scheduler.set_timesteps(num_inference_steps, **extra_set_kwargs)
    model.scheduler.set_timesteps(num_inference_steps)

just try this https://github.com/google/prompt-to-prompt/issues/29#issuecomment-1398825757


Respect PGP body hashes signed into sigchain

cc @maxtaco @oconnor663

Fixes #6

Other than all my comment requests above, this looks good to me. @maxtaco do you care to take a look, or should we just :shipit:?

I'm good if you're good!

@oconnor663 I made most of these changes but I'm still unclear on one of your questions.

@oconnor663 I think I'm going to merge this, since it's just a comment change. Let's chat once you're back online.


load_model fails with "TypeError: arg 5 (closure) must be tuple" for models with Lambda layer

When loading a model with a Lambda layer, Keras throws the error TypeError: arg 5 (closure) must be tuple. But after implementing the changes outlined in https://github.com/explosion/spaCy/issues/767#issuecomment-278651113, load_model() works as expected.
The issue is with https://github.com/fchollet/keras/commit/edae1785327dd7a418ac06c2fe85a8c1f6ea05b7#diff-56dc3cc42e1732fdb3a3c2c3c8efa32a. This commit removes func_reconstruct_closure(), but when I added that back in and called it in func_load(), it works.
Is there a fix planned for this?

[x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[x] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[ ] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[ ] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

I am having a similar issue and tried to revert my pip installation back to 2.0.0, which still didn't make it  work..

You'll have to manually make the code changes detailed above. Seems like @fchollet removed that section of the code because there weren't any unit tests. I might have some time in the future to familiarise myself with that section of the codebase and submit a PR, but that may be a while. In the meantime, the workaround I've found is to use load_weights() instead of load_model()

@nigeljyng thanks for the work on this~
Hm, so to be clear the current state is that we can't load_model() for models with Lambda layers in keras 2.0.6?
To be clear, the changes you're suggesting are to bring back func_reconstruct_closure() and rename it to func_load(), correct?

@adalca No, I'm suggesting to bring back func_reconstruct_closure() and call it from func_load(). I don't think I'll have time to look into this so hopefully someone else can contribute?

@nigeljyng thanks for the quick clarification.
That makes a lot more sense! has misread your original comment. Thank you.

This is still an issue in 2.0.8.
Is my understanding that all that needs to happen is to add unit tests to this PR?
How many do we need and exactly what do they need to cover?  Would a model consisting only of a simple lambda layer saved, then loaded suffice?

This indeed still appears to be an issue. Is someone working on this? @gw0 ?

@hgaiser Unfortunately, no. At the moment I am doing some embedded programming for IoT.
I also understand it, that only unit tests for verifying that func_reconstruct_closure() works correctly. This means a few different examples that cover all possible situations of functions.

To add to this, it's not just re-adding the code that's necessary, as my network is failing in dropout reconstruction.
~/keras/keras/layers/recurrent.py in _generate_dropout_mask(self, inputs, training)
   1588             import code; code.interact(local=dict(globals(), **locals()))
   1589
-> 1590             ones = K.ones_like(K.squeeze(inputs[:, 0:1, :], axis=1))
   1591
   1592             def dropped_inputs():

TypeError: list indices must be integers, not tuple

The inputs causing the problem:
Python 3.4.3 (default, Nov 17 2016, 01:08:31)
[GCC 4.8.4] on linux
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
In : inputs
Out[2]:
[<tf.Tensor 'lambda_2/strided_slice:0' shape=(32, 1, 100) dtype=float32>,
 <tf.Tensor 'encoder_0/while/Exit_2:0' shape=(32, 150) dtype=float32>,
 <tf.Tensor 'encoder_0/while/Exit_3:0' shape=(32, 150) dtype=float32>]

Seeing this on 2.0.8 is there a workaround?

@dvaldivia This PR should provide working model loads with Lambda layers.

@soaxelbrooke the change did work for me

Got the same error...


0.10.4: shpinx fails

Looks like lates sphinx fails on generate documentation
+ /usr/bin/python3 setup.py build_sphinx -b man --build-dir build/sphinx
running build_sphinx
Running Sphinx v4.5.0

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/sphinx/config.py", line 332, in eval_config_file
    exec(code, namespace)
  File "/home/tkloczko/rpmbuild/BUILD/beartype-0.10.4/doc/source/conf.py", line 45, in <module>
    from beartype.roar import BeartypeDependencyOptionalMissingWarning
ImportError: cannot import name 'BeartypeDependencyOptionalMissingWarning' from 'beartype.roar' (/home/tkloczko/rpmbuild/BUILD/beartype-0.10.4/beartype/roar/__init__.py)

Hah! The joke's on you, @kloczek! We don't even have Sphinx documentation. It can't be broken if it doesn't exist. Checkmate. :chess_pawn:
In all seriousness, Sphinx is a unique Hell we're currently working on fixing. Sphinx-based documentation is in-process and well-known to be broken. Yes, this is shameful. Yes, this reflects poorly on @beartype. That's why issue #8 is our highest priority. For the moment, please pretend that we have no doc/ directory. I can only insert mournful emoji here. :disappointed: :sob:
Oh – and thanks for letting us know, nonetheless. If we thought we actually had working documentation, I'd be ruthlessly hell-bent on fixing this! Since you're awesome, @kloczek, just let us know if anything else looks brokey.

Just testes 0.11.0 and documentation builds with small parch
--- a/doc/source/conf.py
+++ b/doc/source/conf.py
@@ -41,8 +41,9 @@
 # See also:
 # * https://samnicholls.net/2016/06/15/how-to-sphinx-readthedocs
 #   The "Make autodoc actually work" is the canonical writeup on this kludge.
-# import os, sys
-# # sys.path.insert(0, os.path.abspath('../../'))
+import os
+import sys
+sys.path.insert(0, os.path.abspath("../../"))
 # print(f'sys.path (from "doc/source/conf.py"): {sys.path}')

 # ....................{ IMPORTS                           }....................

With that
+ /usr/bin/sphinx-build -n -T -b man doc/source build/sphinx/man
Running Sphinx v5.1.1
WARNING: Optional Sphinx extension "sphinx_rtd_theme" not found; falling back to default Sphinx HTML theme.
making output directory... done
WARNING: html_static_path entry '_static' does not exist
[autosummary] generating autosummary for: changes.rst, index.rst, reference.rst, tutorial.rst
building [mo]: targets for 0 po files that are out of date
building [man]: all manpages
updating environment: [new config] 4 added, 0 changed, 0 removed
reading sources... [100%] tutorial
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... beartype.1 { changes reference tutorial } /home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/__init__.py:docstring of beartype:3: WARNING: py:mod reference target not found: beartype.meta
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:class reference target not found: beartype._data.datatyping.BeartypeableT
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:class reference target not found: beartype._data.datatyping.BeartypeableT
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:class reference target not found: beartype._data.datatyping.BeartypeableT
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:class reference target not found: BeartypeableT
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:class reference target not found: BeartypeConf
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:class reference target not found: optional
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:class reference target not found: BeartypeReturn
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:exc reference target not found: BeartypeConfException
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:67: WARNING: py:class reference target not found: BeartypeConf
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:exc reference target not found: BeartypeDecorHintException
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:68: WARNING: py:mod reference target not found: typing
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:exc reference target not found: BeartypePep563Exception
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:exc reference target not found: BeartypeDecorParamNameException
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:exc reference target not found: BeartypeDecorWrappeeException
/home/tkloczko/rpmbuild/BUILD/beartype-0.11.0/beartype/_decor/_cache/cachedecor.py:docstring of beartype._decor._cache.cachedecor.beartype:1: WARNING: py:exc reference target not found: BeartypeDecorWrapperException
done
build succeeded, 17 warnings.

You can peak on fixes that kind of issues in other projects
https://github.com/latchset/jwcrypto/pull/289
https://github.com/click-contrib/sphinx-click/commit/abc31069
https://github.com/latchset/jwcrypto/pull/289
https://github.com/RDFLib/rdflib-sqlalchemy/issues/95
https://github.com/sissaschool/elementpath/commit/bf869d9e
https://github.com/jaraco/cssutils/issues/21
https://github.com/pywbem/pywbem/pull/2895
https://github.com/sissaschool/xmlschema/commit/42ea98f2
https://github.com/RDFLib/rdflib/pull/2036
https://github.com/frostming/unearth/issues/14
https://github.com/pypa/distlib/commit/98b9b89f

Oh, nice! Thanks a fistful of fallen Autumn leaves for both that fast patch and the generous helping of links from fellow Sphinx victims survivors. I must confess I haven't touched Sphinx with a ten-foot septic pole after becoming irrationally upset and pounding angrily on my keyboard five months ago.
What I'm trying to say is... re-resolved by commit 5598744. :hot_face:

[mode=bowing]
Thank you 👍 😄
[/mode]


greenbone sync problem

Please help me with greenbone-scapdata-sync and greenbone-certdata-sync i have reponse: Network is unreachable (101) and connection timed out (101) every time im trying to do that.
Im trying to do that because i have an error when trying to launch openvas on browser (SCAP and/or CERT database missing on OMP server).
only command greenbone-nvt-sync worked but with --curl --verbose (nothing more cant work).
Help pls

Have you checked your firewall?

I have no firewall and i tried using internet from my cellphone hotspot and normal wifi or cable.
Errors:
root@kali:~# greenbone-scapdata-sync
rsync: failed to connect to feed.openvas.org (<IP_ADDRESS>): Connection timed out (110)
rsync: failed to connect to feed.openvas.org (2a01:130:2000:127::d1): Network is unreachable (101)
rsync error: error in socket IO (code 10) at clientserver.c(125) [Receiver=3.1.2]
root@kali:~# greenbone-nvt-sync
rsync: failed to connect to feed.openvas.org (<IP_ADDRESS>): Connection timed out (110)
rsync: failed to connect to feed.openvas.org (2a01:130:2000:127::d1): Network is unreachable (101)
rsync error: error in socket IO (code 10) at clientserver.c(125) [Receiver=3.1.2]
root@kali:~# openvas-feed-update
[>] Updating OpenVAS feeds
[] [1/3] Updating: NVT
rsync: failed to connect to feed.openvas.org (<IP_ADDRESS>): Connection timed out (110)
rsync: failed to connect to feed.openvas.org (2a01:130:2000:127::d1): Network is unreachable (101)
rsync error: error in socket IO (code 10) at clientserver.c(125) [Receiver=3.1.2]
[] [2/3] Updating: Scap Data
rsync: failed to connect to feed.openvas.org (<IP_ADDRESS>): Connection timed out (110)
rsync: failed to connect to feed.openvas.org (2a01:130:2000:127::d1): Network is unreachable (101)
rsync error: error in socket IO (code 10) at clientserver.c(125) [Receiver=3.1.2]
[*] [3/3] Updating: Cert Data
rsync: failed to connect to feed.openvas.org (<IP_ADDRESS>): Connection timed out (110)
rsync: failed to connect to feed.openvas.org (2a01:130:2000:127::d1): Network is unreachable (101)
rsync error: error in socket IO (code 10) at clientserver.c(125) [Receiver=3.1.2]
root@kali:~# greenbone-
greenbone-certdata-sync  greenbone-nvt-sync       greenbone-scapdata-sync
root@kali:~# greenbone-certdata-sync
rsync: failed to connect to feed.openvas.org (<IP_ADDRESS>): Connection timed out (110)
rsync: failed to connect to feed.openvas.org (2a01:130:2000:127::d1): Network is unreachable (101)
rsync error: error in socket IO (code 10) at clientserver.c(125) [Receiver=3.1.2]
also check setup show me that info:
root@kali:~# openvas-check-setup
openvas-check-setup 2.3.7
Test completeness and readiness of OpenVAS-9
Please report us any non-detected problems and
help us to improve this check routine:
http://lists.wald.intevation.org/mailman/listinfo/openvas-discuss
Send us the log-file (/tmp/openvas-check-setup.log) to help analyze the problem.
Use the parameter --server to skip checks for client tools
like GSD and OpenVAS-CLI.
Step 1: Checking OpenVAS Scanner ...
OK: OpenVAS Scanner is present in version 5.1.1.
OK: redis-server is present in version v=4.0.10.
OK: scanner (kb_location setting) is configured properly using the redis-server socket: /var/run/redis-openvas/redis-server.sock
OK: redis-server is running and listening on socket: /var/run/redis-openvas/redis-server.sock.
OK: redis-server configuration is OK and redis-server is running.
OK: NVT collection in /var/lib/openvas/plugins contains 46013 NVTs.
WARNING: Signature checking of NVTs is not enabled in OpenVAS Scanner.
SUGGEST: Enable signature checking (see http://www.openvas.org/trusted-nvts.html).
OK: The NVT cache in /var/cache/openvas contains 46013 files for 46013 NVTs.
Step 2: Checking OpenVAS Manager ...
OK: OpenVAS Manager is present in version 7.0.2.
OK: OpenVAS Manager database found in /var/lib/openvas/mgr/tasks.db.
OK: Access rights for the OpenVAS Manager database are correct.
OK: sqlite3 found, extended checks of the OpenVAS Manager installation enabled.
OK: OpenVAS Manager database is at revision 184.
OK: OpenVAS Manager expects database at revision 184.
OK: Database schema is up to date.
OK: OpenVAS Manager database contains information about 46009 NVTs.
OK: At least one user exists.
ERROR: No OpenVAS SCAP database found. (Tried: /var/lib/openvas/scap-data/scap.db)
FIX: Run a SCAP synchronization script like greenbone-scapdata-sync.
ERROR: Your OpenVAS-9 installation is not yet complete!
Please follow the instructions marked with FIX above and run this
script again.
If you think this result is wrong, please report your observation
and help us to improve this check routine:
http://lists.wald.intevation.org/mailman/listinfo/openvas-discuss
Please attach the log-file (/tmp/openvas-check-setup.log) to help us analyze the problem.
Ofcourse thats dont work as you can see above

I just tested and connectivity is working fine. This generally happens when there's an issue like a firewall (as @fabionitto mentioned above). I don't think this is our docker container's issue at the moment :(

Tu ani you for answers. I will try what i can do nad i will lat you know what happens ;)

Currently receiving the following, and have been since last evening:
[root@scanner:~# greenbone-certdata-sync
rsync: failed to connect to feed.openvas.org (<IP_ADDRESS>): Connection refused (111)
rsync: failed to connect to feed.openvas.org (2a01:130:2000:127::d1): Network is unreachable (101)

Hello,
I've a new installation on debian, syncing certdata and scapdata give me these errors:
rsync: failed to connect to feed.openvas.org (<IP_ADDRESS>): Connection timed out (110)s:
rsync: failed to connect to feed.openvas.org (2a01:130:2000:127::d1): Network is unreachable (101)
rsync error: error in socket IO (code 10) at clientserver.c(125) [Receiver=3.1.2]

fwiw you can run both those scripts with --refresh arguments to avoid modifying it by hand

What port is needed to be open for the rsync? 873?

您好，
我在debian上进行了新安装，同步certdata和scapdata给我这些错误：
rsync：无法连接到feed.openvas.org（<IP_ADDRESS>）：连接超时（110）s：
rsync：连接失败to feed.openvas.org（2a01：130：2000：127 :: d1）：网络无法访问（101）
rsync错误：clientserver.c上的套接字IO（代码10）中的错误（125）[Receiver = 3.1.2]

$cat /usr/bin/openvas-feed-update
#!/bin/bash
echo "Updating OpenVas Feeds"
greenbone-nvt-sync
greenbone-scapdata-sync
greenbone-certdata-sync --wget
it work

greenbone-scapdata-sync --wget worked for me FWIW after getting the rsync connection refused error

I'm having the same problem, it seems to work after I run the command a number of times, I've checked my firewall and IIDS and neither of those are interfering. Any ideas?


Bump API version to v1beta1 [Tracking Issue]

Describe the solution you'd like

Bump API version to v1beta1 to match Cluster API Core

Anything else you would like to add:
xref: v1alpha4 -> v1beta1 changes for providers CAPI documentation
Rough task list:

[x] https://github.com/metal3-io/cluster-api-provider-metal3/issues/314
[x] https://github.com/metal3-io/cluster-api-provider-metal3/issues/315
[x] https://github.com/metal3-io/cluster-api-provider-metal3/issues/316
[x] https://github.com/metal3-io/cluster-api-provider-metal3/issues/317
[x] https://github.com/metal3-io/cluster-api-provider-metal3/issues/318
[ ] https://github.com/metal3-io/cluster-api-provider-metal3/issues/319
[x] https://github.com/metal3-io/cluster-api-provider-metal3/issues/320
[x] https://github.com/metal3-io/cluster-api-provider-metal3/issues/321

Related issues upstream:

https://github.com/kubernetes-sigs/cluster-api/issues/5260
https://github.com/kubernetes-sigs/cluster-api/issues/5262
https://github.com/kubernetes-sigs/cluster-api/issues/5269
https://github.com/kubernetes-sigs/cluster-api/issues/5277
https://github.com/kubernetes-sigs/cluster-api/issues/5281

/kind feature

This is a tracking issue and should be closed automatically once child issue https://github.com/metal3-io/cluster-api-provider-metal3/issues/319 is closed.

/triage accepted
/kind design
/kind feature

This was a tracking issue and all the issues inside are closed now, so closing this one as well.
/close


support eks access entry

Description
All our new clusters use the new EKS access entry auth method instead of the old (and cumbersome)  aws-auth configmap stuff.  However it seems Karpenter doesnt support access entry yet, or atleast i cant find any documentation for it.

This looks like a duplicate of https://github.com/aws/karpenter-provider-aws/issues/5369


missing dependency on python-setuptools

Upon installation on a clean system, first run outputs:
> azurectl
Traceback (most recent call last):
  File "/usr/bin/azurectl", line 5, in <module>
    from pkg_resources import load_entry_point
ImportError: No module named pkg_resources

pkg_resources is provided by python-setuptools.

I am not fond of having setuptools as a runtime dependency. Makes me wonder if we should not change our approach and instead of letting setuptools  do the generation that triggers this dependency write the main entry point such that setuptools is not needed at runtime?

@rjschwei , @schaefi : now we have two different solutions, both with and without setuptools. Comments, please?

as said in the pull request, I'd like to see us using python-setuptools

Fixed


Datepicker clears all other input values

Hi, thank you for sharing this wonderful library with us.
When using tag in a form with other input tags,
my Datepicker clear button clears all other input values as well.
Could you check if there is any problem with my code or setting?
<template>

    <form>
      <input
        id="postcode"
        class="postcode"
        type="text"
        maxlength="8"
        placeholder="000-0000"
        :value="postcode"
        autocomplete="off"
      />
      <Datepicker
        uid="birthday"
        name="birthday"
        v-model="birthday"
        :enable-time-picker="false"
        locale="ja"
        :format="format"
        :year-range="[1960, 2010]"
        :start-date="new Date(2000, 9)"
        no-today
        :auto-position="false"
      ></Datepicker>
    </form>

</template>

To Reproduce
Steps to reproduce the behavior:

Create a form with datepicker tag and other input tags
input any values to other input tags
Click clear of datepicker, or select any date on datepicker
all other values gone

Expected behavior
just a value of datepicker is updated/cleared.

I couldn't reproduce with this simple code, so it might be the other part of my codes which causes this problem.
I will retest my code and report if any problems.

@yurijosha Based on the provided example, your value is empty, when you update it, the value is not set anywhere, then when the v-model is updated, that value is re-rendered and that is why it is reset.
For example, you can set another input below your input but add a v-model on it:
<template>

    <form>
      <input
        id="postcode"
        class="postcode"
        type="text"
        maxlength="8"
        placeholder="000-0000"
        :value="postcode"
        autocomplete="off"
      />

     <input type="text" v-model="test" />
    </form>

</template>

Thank you.
This was just my lack of understanding of vue.


fix: wrong description

:tada: This PR is included in version 0.0.2 :tada:
The release is available on:

GitHub release
v0.0.2

Your semantic-release bot :package::rocket:


How to create a collective for projects not using github?

At the Osmocom project (https://osmocom.org/) we have a strong belief in self-hosting our own infrastructure, including e-mail, lists, gerrit, gitolite, cgit, etc.
We do have literally more than a hundred git repositories (see https://git.osmocom.org), but we don't host them on github.  Hence we don't have (nor want) "a github repository with 100 stars", as indicated on https://opencollective.com/opensource/apply
In all of the matierials I've read about opencollective before, there was no mention of github being a requirement to use opencollective.  The "Terms" only refer to an optional connection to github.

To be more precise: The "Terms" don't contain any mention of github.  It's only the privacy policy, which mentions github "We will share your name and avatar with Github if you participate in a collective that is also working on a software project through Github." - but that cannot be used to construe some kind of requirement for it.

Hi @laf0rge thank you for this reminder, that we should add an alternative pathway for OSS that don't host in github on that link.
Please go ahead and create your collective here opencollective.com/apply (choose something other than open source, we'll edit the settings manually on our end)

closing since it answers the issue question, re-open or create another one if there are pending issues.


Catching the original OpenAI error

Hello,
I am using ConversationChain with ChatOpenAI (gpt-4), ChatPromptTemplate & BufferMemory.
I would like to implement error handling mechanism in order to show a meaningful error messages for my users.
However, when the chain encounters an error, it appears to throw an error related to the implementation of openai._generate in the langchain -js library. This issue occurs because the code doesn't catch OpenAI server errors and attempts to parse the response data regardless. Consequently, I'm running into the following error:
TypeError: data.choices is not iterable

Same goes for OpenAI llm (with gpt-3.5-turbo) where openai-chat.js  running into error:
TypeError: Cannot read properties of undefined (reading '0')

Is this an implementation bug, or is there something missing in my configurations?
I've tried using the handleLLMError callback, but it doesn't seem to make a difference since the thrown error is a mismatch either way.
Any guidance or suggestions would be greatly appreciated.

Can anyone assist?
I cannot get meaningful errors neither can monitor OpenAI request failures

Hey, the issue indeed seem to be solved now. Thank you.
In addition - regarding using it on TypeScript, how can the returned error be parsed (as what type) in order to see internal error message?


One graphical issue and suggestion

Created a drow mage and MonsterBlocks seems to have issues with having both Innate spells and regular spells at the same time when rendering:

Also, it would be very helpful if the spell slots reflected how many were left rather than max.
Thank you for this mod!

The display issue should be fixed in v2.x.
The other thing is a side effect of the sheet being a read-only reference: Only max slots matter if it's just static info like a book.
However, 2.x changes all that. The beta is already available if you want to check it out, this and many more things have changed to make the sheet fully-featured.


test travis ci

Codecov Report

Merging #22 (a246c7b) into master (dacaaac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   98.45%   98.45%
=======================================
  Files          38       38
  Lines        1942     1942
=======================================
  Hits         1912     1912
  Misses         17       17
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dacaaac...a246c7b. Read the comment docs.

Codecov Report

Merging #22 (a246c7b) into master (dacaaac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   98.45%   98.45%
=======================================
  Files          38       38
  Lines        1942     1942
=======================================
  Hits         1912     1912
  Misses         17       17
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dacaaac...a246c7b. Read the comment docs.


Mono: dependency classes aren't added to solution automatically

When you create a base class in a file, and create a deriving class in another file and attach it to a node, the build will fail, complaining that the base class isn't a part of the build.

Autoload singleton also doesn't added automatically while regenerating the solution after deleting whole project solution..

@tagcup What is the build error exactly?

The type or namespace name `BaseClass' could not be found. Are you missing an assembly reference?

Attached an example project demonstrating the issue
monodependency.zip

There was a mistake in the example you uploaded. Line 4 of Player.cs should be public class Player : PlayerBase not public class PlayerBase : Player. After changing that, it gives the error you were talking about, because the file which declares PlayerBase is not part of the project.
Can you describe how did you create the file for the base class?

Yeah, probably sent the wrong file, anyway, that's what I mean.

Can you describe how did you create the file for the base class?

emacs Player.cs. Why should it matter?

BTW, assuming that globals need to be implemented using a singleton class in a separate file, I also bumped into the issue @khairul169 mentioned too, originally

Ah maybe you mean that's the kind of thing that would be added along with support for external editors / IDEs?

The reason is you didn't create the file from Godot or an IDE, which would have added it manually.
Right now, there is no way for CSharpScript to know its base CSharpScript, only the base MonoClass, so it can't check that file as well to add it to the project. This will be possible soon though.

Also need to check AutoLoads as mentioned above.

The reason is you didn't create the file from Godot or an IDE, which would have added it manually.

This will be possible soon though.

Yeah, that was kind of the point that I'm trying to make.

Also need to check AutoLoads as mentioned above.

Well, yes, I do reproduce the same problem?

This seems to have been fixed a long time ago, the project in https://github.com/godotengine/godot/issues/11930#issuecomment-335045262 with the fix in https://github.com/godotengine/godot/issues/11930#issuecomment-335046555 works fine in 3.5 beta 1, and likely in earlier releases too.


Use docusaurus code block tabs for npm & yarn commands

https://docusaurus.io/docs/markdown-features/code-blocks#multi-language-support-code-blocks
Just because it'd look tidy.
Possibly one for the backlog for @AztecProtocol/devrel
Edit: I just noticed @catmcgee is missing from this github group :)

im doing this rn, can you add me & assign pls

I don't think I have permission to add you to that group. Might need to be Charlie.


create dynamic highlighter to mark a star

find a way to mark a star in a distinguishable manner

created a rotator transition to show the star


Approximate equality for SecondQuantizedOps

What is the expected enhancement?
Comparing two SecondQuantizedOps for approximate equality is useful for testing. As far as I can tell there is no simple way to do this yet.

I suggest that this could be implemented via __eq__ and equiv (as seen in Terra e.g.) methods on the new classes proposed in #665 and #669


BibTeX citation uses improper date format

Description
The BibTeX citation tool for articles currently produces dates with too much precision for what BibTeX expects. This would (likely) error out a user's LaTeX build if they dumped the generated citation into the .bib files.
The date should still be ISO 8601, but only be YYYY-MM-DD.
Tasks

[x] Correct the date format used in the BibTeX citation tool

Closed by 28d3d24.


Update README.md

Hello @cbarberis ,
do you want to merge this in? Otherwise I'll close the PR. :)
Cheers,
spek


 tags with identical href and inner text are now rendered using angular bracket syntax

Fixed #31
All feedback is welcome. Thanks.

Overall this looks great!  If you wouldn't mind making that one minor change I'll get this merged ASAP :)
Thanks!

Would you mind changing this to use $href instead of $text? I know it's an extremely minor nit-pick, but we are outputting a link after all, so using $href would make that super obvious.

No problem. I like your point.
Done.

Awesome, thanks for the contribution! :smiley:


libraries-bom 10.0

@stephaniewang526

[ERROR] COMPILATION ERROR :
[ERROR] javac: invalid target release: 11
Usage: javac
use --help for a list of possible options
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project automl-google-cloud-samples: Compilation failure
[ERROR] javac: invalid target release: 11
[ERROR] Usage: javac
[ERROR] use --help for a list of possible options
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

@elharo Good to mention which test - we are so used to seeing Static analysis fail that we didn't notice it - I'll look at it later today.


Livewire support

Just an idea. I noticed that I cant use livewire in any of the module.

Never mind it works.


[TC-I-1.1]-AttributeList Value Mismatch

Summary:
Executed TC-I-1.1 Testscript as per latest testplan but getting Attribute List value mismatch error
Note:
Expected value is [0,1] but instead of that got [0,1,65528,65529,65531,65533] value response
Testplan Screenshot:

Error screenshot:

I-1-1-Attributelist-missing-issue.zip

this is not an issue ,global attribute value supposed to be there in Attributelist ,hence closing this issue


Missing libraries in packages.json file

It could be a side effect of my upgrade from 1.0, but in order to get foundation-apps build to work for me, I had to overwrite my packages.json file with the one in the repo (nothing big there). After doing this and hitting a couple of errors, I had to add the following dependencies to my packages.json file for the gulp process to fully run:
"front-router": "~1.0.0"
"yargs":  "~3.13.0"
Again, this could be a remnant of my upgrade process, but I wanted to mention it just in case.

Ah yeah, the 1.0.2 upgrade guide was written before we introduced those two libraries to the template.
Also, since you've upgraded, you can remove front-matter and through2 from your dependencies. Those are wrapped up in the front-router package.

Oooh, good to know. I'll update that now.
Since I have you here, I'm seeing this error now when I try foundationapps-build

[09:37:02] 'uglify:foundation' errored after 1.1 ms
[09:37:02] TypeError: Object # has no method 'if'
at Gulp.gulp.task.gulp.src.pipe.$.webserver.port (C:\Users\Sean\Projects\prayerjournal\prayerjournal\gulpfile.js:152
:19)
at module.exports (C:\Users\Sean\Projects\prayerjournal\prayerjournal\node_modules\gulp\node_modules\orchestrator\li
b\runTask.js:34:7)
at Gulp.Orchestrator._runTask (C:\Users\Sean\Projects\prayerjournal\prayerjournal\node_modules\gulp\node_modules\orc
hestrator\index.js:273:3)
at Gulp.Orchestrator._runStep (C:\Users\Sean\Projects\prayerjournal\prayerjournal\node_modules\gulp\node_modules\orc
hestrator\index.js:214:10)
at C:\Users\Sean\Projects\prayerjournal\prayerjournal\node_modules\gulp\node_modules\orchestrator\index.js:279:18
at finish (C:\Users\Sean\Projects\prayerjournal\prayerjournal\node_modules\gulp\node_modules\orchestrator\lib\runTas
k.js:21:8)
at cb (C:\Users\Sean\Projects\prayerjournal\prayerjournal\node_modules\gulp\node_modules\orchestrator\lib\runTask.js
:29:3)
at Gulp.gulp.task.gulp.src.pipe.$.sass.includePaths (C:\Users\Sean\Projects\prayerjournal\prayerjournal\gulpfile.js:
130:2)
at module.exports (C:\Users\Sean\Projects\prayerjournal\prayerjournal\node_modules\gulp\node_modules\orchestrator\li
b\runTask.js:34:7)
at Gulp.Orchestrator._runTask (C:\Users\Sean\Projects\prayerjournal\prayerjournal\node_modules\gulp\node_modules\orc
hestrator\index.js:273:3)

Am I missing a library for that? I saw a gulp-if library out there, but the syntax seems different.

It is gulp-if, see if that's missing.

Good to know about removing those libraries. I did so and added gulp-if
It appears that through2 might still be needed even though front-router is in place? Here's my npm install warning:

npm WARN unmet dependency C:\Users\Sean\Projects\prayerjournal\prayerjournal\node_modules\gulp-ruby-sass\node_modules\vi
nyl-fs\node_modules\glob-stream requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency undefined,
npm WARN unmet dependency which is version undefined

and my foundation-apps build has this error now
npm WARN unmet dependency C:\Users\Sean\Projects\prayerjournal\prayerjournal\node_modules\gulp-ruby-sass\node_modules\vi
nyl-fs\node_modules\glob-stream requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency undefined,
npm WARN unmet dependency which is version undefined
Maybe I need to npm uninstall to flush everything and do a fresh npm install? Previously I did npm uninstall front-matter and npm uninstall through2 to remove those libraries.
I greatly appreciate your time!

Yeah, maybe try cleaning out your folder and starting again. The error here is related to through2 being used by vinyl-fs, which is being used by gulp. Dependencies get complicated. But it doesn't appear to be related to the instance of through2 that was being used at the top level.
To start over, try:
rm -rf node_modules
npm cache clean
npm install

Also, when you run npm uninstall, you need to add --save or --save-dev to make the change stick in your package.json file.

Hazzah! That seemed to do the trick! I have a successful build and all.
I have some custom front-matter issues now to resolve, but that's on me to fix 8^D
Thanks again!

Nice! If you have any suggestions for Front Router, let us know.


Removes merge conflicts for branch dev-1.15

This PR aims to update dev-1.15 with content from master branch while resolving all merging conflicts.

cc @jimangel

Let's kick this in and iterate.
/lgtm
/approve

/lgtm
/approve

@makoscafee Let's solve the conflict and try again? :)

@makoscafee Let's solve the conflict and try again? :)

Sure let me work on resolving these conflicts

/hold
I think this might be done wrong, since it's pulling in 605 commits (and multiple languages). Comparing to our 1.14 (dev-1.14) release, there was only 50 commits: https://github.com/kubernetes/website/pull/13174/commits
/cc @kubernetes/sig-docs-maintainers thoughts?

It might be good to directly merge from master (which consists bug fixes) into dev-1.15 (which consists of the feature work) before doing the final release.

Ok Let me close this and try creating to see how it turns out..


Unable to deploy the protocol - Cannot find '../typechain-types' issue

Hi ! I dev on windows, I already had issues with the Quick Setup guide when configuring the docker container.
I choosed not to use it and I got other issues for deploying the protocol in a local blockchain.
Here is what I got in the first terminal:

(This is in french but means SKIP_LOAD is not recognized as an internal or external control.)

I fixed that with "npm ci" in the first terminal and I got:

So I guess this is working fine and I just have to keep this window open and dev in another terminal.
I have the exact same issues in the second shell but couldn't fix it:

This "Cannot find module '../typechain-types'" issue is the same than previously. I try this:

And now I got issues with Hardhat (not recognized as internal or external control)..
I tried to set SKIP_LOAD value, to update full-deploy.ts file but nothing is working...
Thank you for your help, and tell me if you have further questions !

I had the same issue, but then was able to generate the typechain-types by running npm run compile

Yes, compiling should do the trick. However, now we switched to foundry and we have foundry scripts. I will close this issue, sorry for the delay.


[Monitor][Query] Update CHANGELOG for release

API change check
API changes are not detected in this pull request.


[ollama kernel] Add command to install kernelspec

Something like:
ollama-kernel --install

Probably ok to rely on clap for it now.

Once we've got this in, it's time for a README and some sample notebooks.


More explicit error when sudo requires password for actions

(virtualenv)~/stanley git:linux_pack_improvements ❯❯❯ st2 run linux.lsof_pids hosts=localhost pids=20430 username=stanley                                                                                ✭ ✱ ◼
.
+-----------------+--------------------------------------------------------------+
| Property        | Value                                                        |
+-----------------+--------------------------------------------------------------+
| id              | 54f0fcd10640fd02810515cc                                     |
| action.ref      | linux.lsof_pids                                              |
| context.user    | lakshmi                                                      |
| parameters      | {                                                            |
|                 |     "username": "stanley",                                   |
|                 |     "pids": "20430",                                         |
|                 |     "hosts": "localhost"                                     |
|                 | }                                                            |
| status          | failed                                                       |
| start_timestamp | Fri, 27 Feb 2015 23:25:05 UTC                                |
| end_timestamp   | Fri, 27 Feb 2015 23:25:06 UTC                                |
| result          | {                                                            |
|                 |     "localhost": {                                           |
|                 |         "failed": true,                                      |
|                 |         "traceback": "  File "/home/lakshmi/stanley/st2commo |
|                 | n/st2common/models/system/action.py", line 376, in _sudo     |
|                 |     output = sudo(self.command, combine_stderr=False,        |
|                 | pty=True, quiet=True)                                        |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/network.py", line 639, in              |
|                 | host_prompting_wrapper                                       |
|                 |     return func(*args, **kwargs)                             |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/operations.py", line 1095, in sudo     |
|                 |     stderr=stderr, timeout=timeout,                          |
|                 | shell_escape=shell_escape,                                   |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/operations.py", line 909, in           |
|                 | _run_command                                                 |
|                 |     channel=default_channel(), command=wrapped_command,      |
|                 | pty=pty,                                                     |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/state.py", line 390, in                |
|                 | default_channel                                              |
|                 |     chan = _open_session()                                   |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/state.py", line 382, in _open_session  |
|                 |     return                                                   |
|                 | connections[env.host_string].get_transport().open_session()  |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/network.py", line 151, in __getitem__  |
|                 |     self.connect(key)                                        |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/network.py", line 143, in connect      |
|                 |     self[key] = connect(user, host, port, cache=self)        |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/network.py", line 523, in connect      |
|                 |     password = prompt_for_password(text)                     |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/network.py", line 596, in              |
|                 | prompt_for_password                                          |
|                 |     handle_prompt_abort("a connection or sudo password")     |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/utils.py", line 154, in                |
|                 | handle_prompt_abort                                          |
|                 |     abort(reason % "input would be ambiguous in parallel     |
|                 | mode")                                                       |
|                 |   File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7 |
|                 | /site-packages/fabric/utils.py", line 32, in abort           |
|                 |     raise env.abort_exception(msg)                           |
|                 | ",                                                           |
|                 |         "succeeded": false,                                  |
|                 |         "error": "Passwordless sudo needs to be setup for    |
|                 | user: stanley"                                               |
|                 |     }                                                        |
|                 | }                                                            |
+-----------------+--------------------------------------------------------------+
(virtualenv)~/stanley git:linux_pack_improvements ❯❯❯

@lakshmi-kannan Can you paste the result of
st2 execution get 54f0fcd10640fd02810515cc

(virtualenv)~/stanley git:passwordless_sudo_warning ❯❯❯ st2 execution get 54f0fcd10640fd02810515cc                                                                                ✭ ◼
status: failed
result:
{
    "localhost": {
        "failed": true,
        "traceback": "  File "/home/lakshmi/stanley/st2common/st2common/models/system/action.py", line 376, in _sudo
    output = sudo(self.command, combine_stderr=False, pty=True, quiet=True)
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/network.py", line 639, in host_prompting_wrapper
    return func(*args, **kwargs)
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/operations.py", line 1095, in sudo
    stderr=stderr, timeout=timeout, shell_escape=shell_escape,
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/operations.py", line 909, in _run_command
    channel=default_channel(), command=wrapped_command, pty=pty,
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/state.py", line 390, in default_channel
    chan = _open_session()
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/state.py", line 382, in _open_session
    return connections[env.host_string].get_transport().open_session()
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/network.py", line 151, in __getitem__
    self.connect(key)
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/network.py", line 143, in connect
    self[key] = connect(user, host, port, cache=self)
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/network.py", line 523, in connect
    password = prompt_for_password(text)
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/network.py", line 596, in prompt_for_password
    handle_prompt_abort("a connection or sudo password")
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/utils.py", line 154, in handle_prompt_abort
    abort(reason % "input would be ambiguous in parallel mode")
  File "/home/lakshmi/stanley/virtualenv/local/lib/python2.7/site-packages/fabric/utils.py", line 32, in abort
    raise env.abort_exception(msg)
",
        "succeeded": false,
        "error": "Passwordless sudo needs to be setup for user: stanley"
    }
}
(virtualenv)~/stanley git:passwordless_sudo_warning ❯❯❯                                                                                ✭ ◼
	st2client/st2client/commands/outpu

stupid traceback takes away from the message. Its just noise in most cases especially if there is a useful message.
Any thats a separate problem.

oh well ...if this is the only way.
+1

I couldn't think of a way that works across distros. I'll merge it for now. If we have a better solution, we can fix later.

Yeah, I was thinking if we can maybe catch a more specific fabric error message, but this should work as well.

Actually, to make false positives less likely, might be better to look for a connection or sudo password, right?

Actually, to make false positives less likely, might be better to look for a connection or sudo password, right?

I think the current version is fine.

Btw, what's the type(exc) here? Just slightly worried about false positives.

It's a FabricExecutionException. I checked that.

Ah, ok, to be on the safe side we should check for that type and the text :)

Ah, ok, to be on the safe side we should check for that type and the text :)

Fair enough. Let me do that.

@Kami Am I good to go?

+1

It turns out fabric returns the same error message (Needed to prompt for a connection or sudo password (host: x4, but input would be ambiguous in parallel mode) if it can't authenticate to the server (e.g. invalid username / password / key) which results in some confusing false positives.
I'm looking into it and trying to figure out if we can differentiate between those errors. If we can't we should probably revert this change since it makes it confusing - in case of an authentication failure, this has nothing to do with a passwordless sudo, it just makes it very confusing for the end user and harder to debug.


Add # as default comment for conf files

Currently, nerdcommenter defaults to /**/ for unknown filetypes.  I would suggest switching the default to #..., or at least for conf files, where this syntax seems much more common imo.

The default already is to use # delimiters for conf files. The problem you are likely hitting is that no file type is being set by vim. Next time try :set ft=conf. That should load a generic conf file syntax and NERDCommenter will do the right thing. The problem here is vim's file type detection, not this plugin. Given that C-style comments are by far the most common across unknown file types it seems reasonable to keep that as the default. Perhaps you can force vim to set that file type for all *.conf extensions rather than relying on its file type detection mechanism which catches conf files of known programs, but not necessarily all of them.


Make Trailing Slash Redirects Configurable

Hi,
I don't want requests to /user to do a 301 Redirect to /user/. I consider those to mean different things, i.e., PUT /user replaces a resource named "user", while PUT /user/ would replace all resources under "user".
This happens even if I have only defined $app->put('/user') without the trailing slash, which leads the 301 to ultimately resolve to a 404.
I realize the 301 behavior is useful in other approaches to API design so I would like to be able to flip a switch in the config to turn this behavior off. It was very confusing to me why this was happening as I had not set up anything but the bare minimum RewriteRules in .htaccess.

Which version of Slim are you using ?

It might be Apache DirectorySlash setting doing the redirect. Try setting it off.
DirectorySlash Off

@akrabat Slim 2.6.2. On Windows 7 x64 under XAMPP if that helps.
@tuupola I did not know about that directive, thanks.  Here are the results of some tests I ran:

$app->get('/users/me') + GET /users/me = 200 OK, text/html, blank page
$app->get('/users/me') + GET /users/me/ = 404 Not Found, text/html, Slim Error Page
$app->get('/users/me/') + GET /users/me = 200 OK, text/html, blank page
$app->get('/users/me/') + GET /users/me/ = 200 OK, application/json, JSON results as intended

The second and last results are the only ones that make sense.
It also seems that turning DirectorySlash on or off has no effect.

We are not intending to change Slim2's behaviour at this point.

Why not? Shouldn't developers be able to design their APIs the way they want to? A configuration setting  to turn redirects on or off that defaults to the existing behavior wouldn't break any existing uses, but it WOULD give people a choice to honor REST principles if they are so inclined.

@hguiney is this behaviour still the same in Slim 3? If yes send a PR to that please, we are only currently taking security fixes for Slim 2.

Here is original discussion concerning the current behaviour.
https://github.com/slimphp/Slim/issues/31


Firefox Tabbing

The problem
When using the keyboard, tabulator doesn't work as expected when using the columns menu or the note reactions menu.
Browser
Firefox
Steps to reproduce the behavior
Open the columns menu or note reactions menu using tabulator. Both menus cannot be accessed properly, unlike Chrome, for example.
Screenshots
No response
Additional context
No response

Hello,
#4562


Automate/export project owners email list

We keep using this list without it being automated. As well as just being a pain to manually keep the list up to date, it's impossible for anyone to unsubscribe from the list.

This needs to be kept open, because legally we have to give people a way to unsubscribe from this list.

Keeping open.


Enable noUncheckedIndexedAccess for FF repo

Minimum file changes needed to enable noUncheckedIndexedAccess for FF repo
AB#8109

Most of our jest tests are configured to run against the .ts code rather than be built by tsc first. There are compile errors in three packages:

example:


Make 'make test' print debug info when failing

Description
Make 'make test' print debug info when failing
This change makes development faster (don't need to run the specific
test with a -v option uppon failure) and makes CI output much more
helpful too.

Status
READY
Requires Backporting
NO
Migrations
NO
Outline the steps to test or reproduce the PR here.

retest

The -v option generates a much longer output and running it with -v only when there is an error was just a naive attempt from my side to reduce memory usage on the CI.
But you are right, the first run failing doesn't mean that the second will fail too and it is probably better to do it in a single run.

Shall we instead make the CI default to verbose output?

@Patater Currently run-tests-suites.pl doesn't have the kind of verbose mode that we want (-v just prints stats, what we want is to know what test(s) failed in a suite and how).

Superseded by #2061


Update watchdog image to multi-arch 0.13.4

Signed-off-by: Richard Gee<EMAIL_ADDRESS>Description
Updates the templates that were previous moved to the hardware architecture specific Watchdog images so that they all use the multi-arch equivalent.
Motivation and Context
Reduced maintenance. More generic pattern.

[ ] I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #
How Has This Been Tested?
Local builds
Deployed
Invoked
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Maintenance

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Thank you!


Inconsistency of typedef:parameter with lambdas

array.forEach(element => {}) does not complain
array.forEach((element) => {}) complains expected to have a typedef.
array.sort((a,b) => {}) complains expected to have a typedef.

hi guys, is it possible to look into it again?
I would like to enforce typedef for lambdas...
.filter((e: Error): boolean => this.belongsToChannel(e))
there is no way to enforce : boolean in this example ... or is there such a rule?

☠ TSLint's time has come! ☠
TSLint is no longer accepting most feature requests per #4534. See typescript-eslint.io for the new, shiny way to lint your TypeScript code with ESLint. ✨
It was a pleasure open sourcing with you all!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


My account is marked as a donation wallet. I did not authorize this action . What is the remedy ?

Scammers kyber if it was legit would let everyone keep there money.

Suspect it's not the correct AlphaWallet. Ensure you install AlphaWallet here:
https://play.google.com/store/apps/details/AlphaWallet_Ethereum_Wallet?id=io.stormbird.wallet


vcpkg not copying DLLs to target directory

We're using vcpkg for installing all of our dependencies. Yet, when we compile it, it shows that most of the DLLs are missing from the final executable.
Here's the output from wine:
002a:err:module:import_dll Library SDL2_image.dll (which is needed by L"C:\\Program Files\\SuperTux\\bin\\supertux2.exe") not found
002a:err:module:import_dll Library libpng16.dll (which is needed by L"C:\\Program Files\\SuperTux\\bin\\supertux2.exe") not found
002a:err:module:import_dll Library vorbisfile.dll (which is needed by L"C:\\Program Files\\SuperTux\\bin\\supertux2.exe") not found
002a:err:module:import_dll Library boost_filesystem-vc140-mt-x32-1_68.dll (which is needed by L"C:\\Program Files\\SuperTux\\bin\\supertux2.exe") not found
002a:err:module:import_dll Library boost_date_time-vc140-mt-x32-1_68.dll (which is needed by L"C:\\Program Files\\SuperTux\\bin\\supertux2.exe") not found
002a:err:module:import_dll Library boost_locale-vc140-mt-x32-1_68.dll (which is needed by L"C:\\Program Files\\SuperTux\\bin\\supertux2.exe") not found
002a:err:module:import_dll Library glew32.dll (which is needed by L"C:\\Program Files\\SuperTux\\bin\\supertux2.exe") not found
002a:err:module:import_dll Library libcurl-d.dll (which is needed by L"C:\\Program Files\\SuperTux\\bin\\supertux2.exe") not found
002a:err:module:attach_dlls Importing dlls for L"C:\\Program Files\\SuperTux\\bin\\supertux2.exe" failed, status c0000135

Here's the code:
https://github.com/SuperTux/supertux/compare/appveyor-vcpkg
If you have any ideas, please let me know.

Thanks for letting us know!
I suspect the issue is that we don't currently add your dependencies to the make install target; however, we should be copying them to the executable output folder. If you were to try to run the executable from the output folder instead of after the make install, I believe it should work (though I understand that you want make install to work as well :)).
First, the obvious suggestion: have you considered static linking? All you need to do is modify the C:\tools\vcpkg\triplets\x64-windows.cmake file to have set(VCPKG_LIBRARY_LINKAGE static) and clear your appveyor cache. When you build the libraries again, they will be built statically. I'd recommend something like [1]:
cache:
  - C:\tools\vcpkg\installed -> .appveyor.yml

If you'd like to use DLLs instead, you'll need to add installation steps for the DLLs manually. This will look probably look something like
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/SDL2_image.dll ... DESTINATION bin)

However you may experience issues with make not knowing how to build the dlls. In that case, you'll need to create a fake custom command[2] that depends on your main build and claims to produce the DLLs (though they'll truly be created by a POST_BUILD action on your main add_executable() call).
I'd strongly recommend first trying the static build route :).
[1] https://www.appveyor.com/docs/build-cache/#cleaning-up-cache
[2] https://cmake.org/cmake/help/latest/command/add_custom_command.html

Thanks for the pointers so far, I made the necessary changes so that it copies custom triplet files to the necessary directories. However, upon linking, I now get this error:
LINK : fatal error LNK1149: output filename matches input filename 'C:\projects\supertux-9ml4d\Release\supertux2.lib' [C:\projects\supertux-9ml4d\supertux2.vcxproj]

as can be found here: https://ci.appveyor.com/project/supertux/supertux-9ml4d/build/2607

I'm almost certain that the issue is caused by setting the outputs of your executable and library to be the same[1]. However, assuming this worked before, this is most likely due to a bug in one of the vcpkg-built libraries that has declared something as dllexport while being built statically.
This can be immediately worked around by just commenting out those two lines, I believe. Assuming that fixes things, and assuming we do indeed have a bug, there will be a supertux2.lib AND supertux2_lib.lib created. In this case, if you can run dumpbin /exports supertux2.lib it will tell us exactly which dependency is misbehaving so we can fix it upstream here in vcpkg.
[1] https://github.com/SuperTux/supertux/blob/4013f7ff548f95cc22adc88288ea46303dee2788/CMakeLists.txt#L635-L636

When I do that, I keep getting linter errors en masse: https://pastebin.com/GYY6e2rd

This issue hasn’t been updated in a year; if it is still an issue, please reopen this issue.

This is still a problem for me.
Making it static by modifying 'x64-windows.cmake' to set(VCPKG_LIBRARY_LINKAGE static) did "solve" it, but I don't really consider having to modify my vcpkg submodule a proper solution (multiple devs working on the project all have to manually do the same modification, or we can fork vcpkg and use a branch in our fork, or continue to manually copy the dlls when building on windows.... I'm not a fan of any option).
I did attempt
include(vcpkg/scripts/buildsystems/vcpkg.cmake)
set(VCPKG_LIBRARY_LINKAGE static)

in my toplevel CMakeLists.txt, but that didn't work :(
Note: I seem to recall that there's a way to specify a triplet. That doesn't work in my case because my project is multiplatform. (I spent a lot of time attempting to make Windows static while still being able to build on Linux when I first started using vcpkg. It is nice to finally have an alright way to do that)

@Triasmus You are not facing the same problem. Open a new issue with a proper description please.

Oh sorry, the first response described my problem

I suspect the issue is that we don't currently add your dependencies to the make install target; however, we should be copying them to the executable output folder. If you were to try to run the executable from the output folder instead of after the make install, I believe it should work (though I understand that you want make install to work as well :)).

so I figured that's what this issue is about.

... where "currently" was in 2018, and #26397 is for correctly using CMake's BundleUtilities.
There are other ways to go wrong (e.g. plugins). That's why I wrote: Open a new issue with a proper description please.


Use "latest" version specifier (when applicable) in Sauce tests

Refs http://sauceio.com/index.php/2016/03/new-browser-version-shortcuts/

Doesn't work for OS X Safari, for unknown reasons.


As a developer, I need to implement testing framework to make it easy writing and testing various scenarios

Goals:

In tests, we need to have complete control over all the inputs of the state machine, so things like time, content and order of the events. This is made easy thanks to our architecture. Even if some/all services aren't mocked, we still must maintain control over it.
We need to be able to run not just one, but multiple nodes, even if we take perspective of only one node in the tests.
We should be able to only mock some/none of the services but for some/all use actual services. That way we can test services as well. In some cases though, it might be too expensive (E.g ledger service using too much RAM), so if we want to run many nodes, we'll have to customize service to reuse some data or mock it all together.
Scenarios instead of being part of the code, should be written as serialized files. That way we won't have to recompile tests, which might get very slow with many tests. Instead those files can be modified on the fly, significantly reducing the feedback loop and time it takes to write a scenario.
We should be able to build scenarios on top of one another. For example we might have a scenario which simply connects two nodes together. We should be able to refer to that scenario as a starting point and build new one from there.
By using actual p2p service, we should be able to test Ocaml node as well, by simulating scenario in Rust node and making Ocaml node observe that scenario. Our ability to test Ocaml node will be limited, since we lack enough control and data from the node, but we will be able to do as much as physically possible from outside.
We might try to use Ocaml node to test Rust node as well, but non-determinism in Ocaml node will degrade accuracy and quality of tests.

While executing defined scenarios, all safety and liveness conditions will be executed indiscriminately. If in the future it gets too slow or to expensive, we might consider disabling some for some scenarios.
Way those conditions are written needs to enable us to reuse them for the replayer, so that we can make assertions on the node that we are running also.
Safety Condition
Assertions on each action based on the global state, state of the services and a current action.
For example once action is dispatched that syncing snarked ledger is done, we need to assert correctness of the merkle tree in the state of the ledger service that we just synced.
Liveness Condition
Assertions on each action based on the global state, state of the services, state of the liveness condition and current action.
Each liveness condition will accumulate individual state based on the dispatched actions or state changes.
For example, in liveness condition's state, we could accumulate which parts of ledger we have already downloaded and if we have downloaded them all, then we need to assert that synchronization is done in state machine.

Implemented core parts. Now working on adding http rpcs in order to be able to manage/execute scenarios.
Rpcs for managing scenarios is implemented, now I need to implement code for triggering and executing those scenarios.

Implemented Cluster logic.
A Cluster is what is responsible for running a scenario and setting up env for nodes defined in that scenario.
Also added rpcs to create/manage clusters and run them.

[ ] For the first scenario, I'm thinking about testing syncing merkle tree logic.

Safety conditions

At any given moment in time, in the syncing state, we have only requested parts of the same height in the merkle tree. So if we have requests for one part on height 5 and one for height 6, that's an invalid state.
At the end, when syncing merkle tree is finished, we must have all hashes and all accounts synced in the ledger and hashes must be correct.
We need to test that given condition holds, because if it doesn't, then we might not have parent hash in current ledger mask so we might not be able to verify it when we get the response.

Scenario

Node will connect to 2 peers (replayers).
At some chosen height, node will receive all hashes before receiving the first one.
At next height, node will receive all hashes before receiving the last hash on that height.
At next height we will do same above 2 steps, except those first and last hash requests will timeout instead of being received at the end.
Continue till we are done syncing.

Implemented WIP version of above: https://github.com/openmina/openmina/blob/2d70ebd01c13bcf2f91e4e808b86a8ad8cea0d75/node/testing/src/scenarios/solo_node/sync_root_snarked_ledger.rs#L35
Missing 4th and 5th steps.

It's still WIP but it will evolve as we work more on tests. Closing this issue as the main goal of this task was achieved.


Show version number rather than commit in sysinfo service

Sometimes the version number shown in the sysinfo service used by ScienceMesh is a commit ID rather than the tagged version.
The build info is taken from the build tags:
https://github.com/cs3org/reva/blob/a8c61401b662d8e09175416c0556da8ef3ba8ed6/cmd/revad/main.go#L56
so I think we just need to make sure that the packaged reva version in the ArtifactHub is the one with a tag.

@dagl can you please take this one?


Maximize window in new windows workspace like MacOS

Hope to add a new feature that when maximizing a window,  it moves to a new windows workspace and hide the taskbar automatically like MacOS.
Moreover, users can config the setting to choose the behavior they want.

Good idea, I can try to see if it can be achieved~

Difficult to implement.


Include a local version of SCons

See #12835.
This adds the "local" version of SCons to the repository, allowing for Godot to build even if SCons is not installed system-wide. (Particularly helpful for Windows users where SCons can be a bit of a pain to set up, but not without merit on other platforms also.)
The documentation on building should be updated to reflect that this is now possible.
The 'new' syntax (assuming the user is in the root of the repo directory) is:
$ python scons/scons.py [arguments] (or equivalent)
Barring that, building should work the exact same as it does already.
SCons 3.0.0 explicitly requires Python >=2.4 to be installed on the system (but most people have Python 2.7 and/or 3.5/6 so this shouldn't be an issue to anybody).

Sorry but I don't want this.
Windows users have to install Python anyway, so they can install SCons too. It's not that hard.
For other platforms, it makes no sense to bundle SCons when it's trivial to install from distro repositories on Linux or homebrew on macOS.
Including thirdparty code in our repo means that we need to maintain it by updating it regularly, ensure that we patch security vulnerabilities if any are found (maybe not so relevant for SCons, but still), and make sure that we don't let contributors modify this thirdparty code as it makes it harder to sync with upstream and could introduce weird bugs. We do vendor the libraries that we need for Godot itself, but I haven't ever seen a project vendor their buildsystem tool. We provide code, users have to install the tools themselves (OS, compiler, buildsystem).