Error 1003 when adding L530 bulb

Version of the integration

v3.1.4 (v3.1.2 noted on the integration page) <- not sure if this is another issue where it's not stating the version number downloaded?
Configuration

Tapo L530 Series
Hardware: 1.0
Firmware: 1.3.1 Build 20240630 Rel. 64117

Describe the bug
Since updating my bulb (Bedroom Light), it will no longer connect to my home assistant.
I've had this bulb for around 6-8 months with no issue.
I've updated my home assistant (core etc) just to be safe, but no luck, it is still not working.
It seems to be throwing a 1003 error.
I've removed the bulb from HASS and tried adding it, but get the same error.
I've removed the bulb from HASS and Tapo, reconnected the bulb to both, but I still get the error.
The bulb still works fine via the Tapo app.
I've tried accessing the bulb via my browser (<IP_ADDRESS>:80) and it gives me the following JSON response:
{
    "error_code": 1003
}

When doing the same to other bulbs, I get a 200 OK response (blank screen).
Edit: I've check all my bulbs and this is the only bulb I have that is hardware version 1.0 on latest firmware. My other bulb on HW 1.0 is firmware 1.3.0 so I'll not update as of yet.
My other bulbs are on HW 2.0 and latest firmware (1.1.1 240623) and still work fine.
Debug log

Logger: custom_components.tapo.config_flow
Source: custom_components/tapo/config_flow.py:231
integration: TP-Link Tapo ([documentation](https://github.com/petretiandrea/home-assistant-tapo-p100), [issues](https://github.com/petretiandrea/home-assistant-tapo-p100/issues))
First occurred: 00:14:57 (3 occurrences)
Last logged: 10:28:29

Failed to setup cannot connect
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 71, in send_request
    if response := await self._send_request(request, retry):
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 84, in _send_request
    self._klap_session = await self.perform_handshake()
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 122, in perform_handshake
    if seeds := await self.perform_handshake1():
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 207, in perform_handshake1
    raise Exception(
Exception: Server response doesn't match our challenge on url http://<IP_ADDRESS>:80/app

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 71, in send_request
    if response := await self._send_request(request, retry):
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 84, in _send_request
    self._klap_session = await self.perform_handshake()
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 122, in perform_handshake
    if seeds := await self.perform_handshake1():
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 207, in perform_handshake1
    raise Exception(
Exception: Server response doesn't match our challenge on url http://<IP_ADDRESS>:80/app

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 71, in send_request
    if response := await self._send_request(request, retry):
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 84, in _send_request
    self._klap_session = await self.perform_handshake()
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 122, in perform_handshake
    if seeds := await self.perform_handshake1():
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 207, in perform_handshake1
    raise Exception(
Exception: Server response doesn't match our challenge on url http://<IP_ADDRESS>:80/app

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/config/custom_components/tapo/config_flow.py", line 317, in _async_get_device
    await device.update()
  File "/usr/local/lib/python3.12/site-packages/plugp100/new/tapodevice.py", line 60, in update
    components = await self._negotiate_components()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/new/tapodevice.py", line 183, in _negotiate_components
    return (await self.client.get_component_negotiation()).get_or_raise()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/common/functional/tri.py", line 159, in get_or_raise
    raise self.value
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 71, in send_request
    if response := await self._send_request(request, retry):
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 84, in _send_request
    self._klap_session = await self.perform_handshake()
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 122, in perform_handshake
    if seeds := await self.perform_handshake1():
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/protocol/klap/klap_protocol.py", line 207, in perform_handshake1
    raise Exception(
Exception: Server response doesn't match our challenge on url http://<IP_ADDRESS>:80/app

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/config/custom_components/tapo/config_flow.py", line 231, in async_step_discovery_auth_confirm
    device = await self._async_get_device_from_discovered(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/tapo/config_flow.py", line 295, in _async_get_device_from_discovered
    return await self._async_get_device(config | {CONF_HOST: discovered.ip}, discovered)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/tapo/config_flow.py", line 322, in _async_get_device
    raise CannotConnect from error
custom_components.tapo.errors.CannotConnect

I have same issue with existing L530 - this is error in integration.

I eventually got my bulb added but it was using another integration.
I'm not trying to push people that way, but hopefully it will suffice until a fix is put in place on this repo
https://www.home-assistant.io/integrations/tplink


play/pause button on headphones work erratically

Start soundcleod & play some music
Hit play/pause on headphones :+1: works as expected
Pause & wait a bit (maybe going to sleep affects this? I'll try to see)
Press play/pause on headphones

Expected
Soundcleod starts playing
Actual
iTunes starts playing
After that, a second click sometimes causes soundcleod to start playing again :question: :question:
What can I do to collect more debug info? I'm on yosimite.

No idea why this is happening, definitely looks like a bug in SoundCleod. Will try to figure out..

This is actually less of a bug with soundcleod and more of a known frustration with OS X. There are  couple workarounds, hopefully this saves some digging on your end @salomvary.
ControllerMate with iTunes Patch  (see here for extra details)
Alternatively, check out MMFix or this similar issue with Hermes.
🎵👂😇

@sammarcus thanks for the pre-investigation, will look into this

@salomvary if you come up with a canonical/official workaround please let me know.


AuthorizationPolicyBuilder.RequireUserName requires Name - not UserName in Google authentication type

https://github.com/aspnet/Security/blob/beaa2b443d46ef8adaf5c2a89eb475e1893037c2/src/Microsoft.AspNetCore.Authorization/AuthorizationPolicyBuilder.cs#L192
See that we require on the user name, but a NameAutorizationRequired requirement is added.
NameAutorizationRequired checks Identity.Name
When using tokens from Google, the name is the real name (e.g. "Eva T"), and not the user name - and real names can have duplicates.
(Debug info for claims returned from Google below)
Name Value Type
Identities Count = 1 System.Collections.Generic.IEnumerable<System.Security.Claims.ClaimsIdentity> {System.Collections.Generic.List<System.Security.Claims.ClaimsIdentity>}
[0] {System.Security.Claims.ClaimsIdentity} System.Security.Claims.ClaimsIdentity
Actor null System.Security.Claims.ClaimsIdentity
AuthenticationType "Google" string
Claims Count = 6 System.Collections.Generic.IEnumerable<System.Security.Claims.Claim> {System.Collections.Generic.List<System.Security.Claims.Claim>}
[0] {http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier: 1234567} System.Security.Claims.Claim
[1] {http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name: Eva T} System.Security.Claims.Claim   [2] {http://schemas.xmlsoap.org/ws/2005/05/identity/claims/givenname: Eva} System.Security.Claims.Claim
[3] {http://schemas.xmlsoap.org/ws/2005/05/identity/claims/surname: T} System.Security.Claims.Claim   [4] {urn:google:profile: https://profiles.google.com/123456} System.Security.Claims.Claim
[5] {http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress<EMAIL_ADDRESS>System.Security.Claims.Claim
CustomSerializationData null byte[]
IsAuthenticated true bool
Label null string
Name "Eva T" string
NameClaimType "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name" string
RoleClaimType "http://schemas.microsoft.com/ws/2008/06/identity/claims/role"

FYI: here is the current claim map for google:
https://github.com/aspnet/Security/blob/32177cad1eb1eb6be8ad89a7dba1a1637c0d0786/src/Microsoft.AspNetCore.Authentication.Google/GoogleOptions.cs#L29-L30
You can remove/clear this and remap as you see fit.

Thank you for the workaround. In this area I think the defaults should be correct, though.
The NameAutorizationRequirement uses Name:
https://github.com/aspnet/Security/blob/beaa2b443d46ef8adaf5c2a89eb475e1893037c2/src/Microsoft.AspNetCore.Authorization/Infrastructure/NameAuthorizationRequirement.cs#L44
For me it looks like GoogleOptions are doing the reasonable thing (display name to name, id to name identifier). Twitter seems to do the same (but documentation for ClaimType is the same for both ClaimType.Name and ClaimType - maybe they should map to GivenName instead e.g.):
new Claim(ClaimTypes.NameIdentifier, accessToken.UserId, ClaimValueTypes.String, ClaimsIssuer),
new Claim(ClaimTypes.Name, accessToken.ScreenName, ClaimValueTypes.String, ClaimsIssuer),
The problem, off course, is that if anybody uses<EMAIL_ADDRESS>and supports several auth providers, you could in Twitter or Google change your screen/display name to that and fake their way into the system.
So all the different providers and the checks has to be consistent about what they put into their different claims.

So history time, require user name was there to support migration from older systems like webforms, where the auth was against an AD/domain where the check was against a SID.
In all honesty it's there for back compat, no-one should be hardcoding usernames into their code any more, and certainly not against social providers where multiple providers where an account name or other identifier may not be unique between providers.
Don't use the back compat switch and instead use a full blown policy and check claims and their providers.


RESTCONF path format issue

According to RESTCONF Protocol draft-ietf-netconf-restconf-18, RESTCONF path should include module-name. But there isn't module-name within the current TAPI swagger API.
draft-ietf-netconf-restconf-18 reference section was copyed here:
<IP_ADDRESS>. ABNF For Data Resource Identifiers
The "api-path" Augmented Backus-Naur Form (ABNF) syntax is used to
construct RESTCONF path identifiers. Note that this syntax is used
for all resources, and the API path starts with the RESTCONF root
resource. Data resources are required to be identified under the
subtree "+{restconf}/data".
An identifier is not allowed to start with the case-insensitive
string "XML", according to YANG identifier rules. The syntax for
"api-identifier" and "key-value" MUST conform to the JSON identifier
encoding rules in Section 4 of [RFC7951]: The RESTCONF root resource
path is required. Additional sub-resource identifiers are optional.
The characters in a key value string are constrained, and some
characters need to be percent-encoded, as described in Section 3.5.3.
api-path = root *("/" (api-identifier / list-instance))
root = string ;; replacement string for {+restconf}
api-identifier = [module-name ":"] identifier
module-name = identifier
list-instance = api-identifier "=" key-value *("," key-value)
key-value = string ;; constrained chars are percent-encoded
string =
identifier = (ALPHA / "")
*(ALPHA / DIGIT / "" / "-" / ".")

This has been fixed with the newer versions of Eagle Uml2Yang tooling (in the baseline since Mar 2017 timeframe)


48- Data card

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #21
Test URLs:

Before: https://main--world-bank--aemsites.hlx.live/
After: https://80-data-cards-styling--world-bank--aemsites.hlx.live/en/drafts/samriddhi/data-card

@Samriddhi-1998  as discussed, this PR is no more valid. I am closing this PR


Payload frame with neither NEXT nor COMPLETE should be rejected

The spec currently doesn't mention the behavior if you send a Payload which doesn't set COMPLETE nor NEXT meaning it will effectively be ignored. While this isn't a problem for implementors it might make it harder to talk to a an implementation that doesn't implement the NEXT bit as Payloads will effectively be blackholed.

Also we could tighten up the rules around a next=false, complete=true. Which can't carry metadata etc.
But I think the immediate answer is to ignore anything that doesn't make sense.

Trying to clarify here: https://github.com/ReactiveSocket/reactivesocket/pull/227

I've been thinking if we even need the C flag. Streams could be completed by just not having neither F or N flag.
The rationale to me is this (and sorry if this is a n00b assumption):
REQUEST_RESPONSE: Since 1 response frame is allowed, despite fragmentation, the frame does not need the C flag.
STREAM and CHANNEL: The C flag is redundant here, because frames either have the F or N flag, which are mutually exclusive already. No flag could indicate the completion of the stream.

The protocol already handles the first case
"If a PAYLOAD for a REQUEST_RESPONSE is received that does not have a COMPLETE flag set, the implementation MUST assume it is set and act accordingly."

@fiorix If you take N not set as meaning COMPLETE there is no way to do deliver a Payload and also signify the stream is also COMPLETE.

Mmmm, maybe I'm missing something but my understanding is that on a stream you'd set N to indicate there's more frames coming. Not having N could signify the stream is complete. No?

N does not mean more frames are coming. A stream can't know that. It means the current frame has data to emit, even if length=0. The PR adds explanation of this. We used to only have C by an edge case exists of an empty payload.

I see, thanks for clarifying.

Closing this now as #227 was merged.


Climbjump has a 1.44 speed boost in EveryJumpIsUltra variant

As described in title, EveryJumpIsUltra variant hooks Player.Jump(..) and Player.ClimbJump(), adds a 1.2 speed boost to the end of these functions
however, ClimbJump() calls Jump(..) internally, so a ClimbJump will actually give a 1.44 speed boost, instead of 1.2
not sure whether this should be patched or not

Yeahhh I'm not sure of the impact fixing this would have on existing maps
😅 (I think there are maps that force ultras?)
Le mar. 19 sept. 2023, 10:39, LozenChen @.***> a écrit :

As described in title, EveryJumpIsUltra variant hooks Player.Jump(..) and
Player.ClimbJump(), adds a 1.2 speed boost to the end of these functions
however, ClimbJump() calls Jump(..) internally, so a ClimbJump will
actually give a 1.44 speed boost, instead of 1.2
not sure whether this should be patched or not
—
Reply to this email directly, view it on GitHub
https://github.com/maddie480/ExtendedVariantMode/issues/25, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMNQTC6QSIB3UR334E4THRLX3FK5RANCNFSM6AAAAAA455XZZE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Someone pointed out that it was fixed in the past, but reverted as it broke a number of maps and TASes. So this bug is here to stay, I guess 😅

0.25.8: "Climb jumps don't trigger double ultras anymore when using the Every Jump is an Ultra variant"
0.26.9: "Reverted a fix on Every Jump is an Ultra introduced in 0.25.8, as it broke a few maps and TASes"


Page#videos method, Video class

Coverage decreased (-2.4%) to 97.632% when pulling 34c99e7121158a624c5cd8eddb112b57c2d532c0 on videos-video into 77fb9ea07a851273663c1bba16f938ac9e5f6594 on master.

I think the page used for testing has no videos. We should add more videos to that page or use different page. Can we merge this commit first, and change it later?


Adjusted the gain compensation to not lose gain due to applied pan stages

This fixes the issue (https://github.com/sfztools/sfizz/issues/1086) that the output level of a sample played through sfizz is ~3dB lower compared to playing the sample directly.

Thanks for the MR!


Turning off the Habitat and venting it should also dump any remaining WasteAtmosphere

It would make sense if venting a habitat would dump WasteAtmosphere when it dumps the Atmosphere.

I agree.

Implemented here.


Logs page does not render markdown, but ticker does.

Expected Behavior

Logs page can render markdown in the same way the ticker does.

Actual Behavior

Logs page does not render markdown

Steps to Reproduce

Create a markdown log.
Open the log on the logs page.

This bug was reported by @connorRigby

This is the intended behavior. The log ticker renders markdown and HTML, while the logs page provides a way to view the raw log messages. This is especially important for FarmBot OS error logs, which may include special characters that don't display correctly with markdown enabled.


bug: Ion-Range issue after update to carbon 4.6.0

Bug Report
Ionic version:
[x] 4.6.0
Current behavior:
Please note: This might be a very edge use case. I understand if this issue is closed.
I have a component that has a dynamic ion-range. This component is nested in a another component that is a google map control. It holds a lot of things, basically its the menu for the page
this.map.controls[ControlPosition.TOP_LEFT].push(document.getElementById('map-menu'));

Everything else that the menu does is working, its just the ion-range. To be more specific it is just the ion-range when the user drops into street view, the ion-range is not draggable anymore. The values are in the correct positions. So if i change the range value to 2 then when in street view the range value is 2 but it doesn't work, i cant change the value.
Expected behavior:
The ion-range should work as expected when the menu component is pushed onto the map when then user enters street view
Related code:
<ion-item *ngFor="let range of rangeDetails.items;let idx = index; let lst = last"
    [lines]="lst ? 'none' : 'full'">
    <ion-range #rangeSlider snaps="true" pin="true" min="0" color="primary" [max]="rangeDetails.maxValue"
      (ionChange)="rangeChanged(rangeSlider.value,idx)">
      <ion-label slot="start">
        <h4>
          <ion-text color="primary"> {{rangeSlider.value}} </ion-text>
        </h4>
      </ion-label>
      <ion-label slot="end">
        <p> {{rangeDetails.maxValue}} </p>
      </ion-label>
    </ion-range>
  </ion-item>

Other information:
Everything was working fine until the update to  "@ionic/angular": "^4.6.0",. I wasn't  going to post this issue, because it seems like a very specific edge case, but when i was looking at the commits for 4.6.0 in the file core/src/components/range/range.tsx there is an import for the letter h
, h } from '@stencil/core';

Im not sure if that is an actual thing that is used in stencil/core, it does seem a little odd though.
I dont know if that is the cause of the issue ( probably not .. i dont know ), i just trying to narrow down what could be causing it to break like it is.  I have tried updating to the most recent versions, that being 4.6.1 and 4.6.2 but it is still not working.
Unfortunately i dont have a demo to show - So yeah i understand if this issue is unresolved and closed.
Ionic info:

Ionic CLI : 5.1.1
Ionic Framework: @ionic/angular 4.6.0
@angular-devkit/build-angular: 0.13.9
@angular/cli: 7.3.9
@ionic/angular-toolkit: 1.5.1

NodeJs: v10.12.0
npm: 6.5.0
OS: Windows 10

Thanks for the issue! The h being added was added to every component as part of the update to Stencil One. Unfortunately, if we can't reproduce this, it's hard to fix it. If there's any way you can create a new starter app and just add the page with the map + range it would be helpful, or if you can try and reproduce it in Codepen without Angular at all: https://codepen.io/pen?template=aXENNW


CMake: Enable finding the Swift -target flag in more cases

When the detected SDK for CMAKE_OSX_SYSROOT and friends has the same
version as your current macOS system version, CMake helpfully doesn't
set CMAKE_OSX_DEPLOYMENT_TARGET. Unfortunately, in this case, swiftc
will default to macOS 10.4, which is absolutely ancient. Grab the target
triple from the -print-target-info JSON when CMAKE_OSX_DEPLOYMENT_TARGET
is not provided at configure time.
Also pull swift-testing from the Swift toolchain on macOS.

ah, my favorite. works on my machine but not in CI.


python311Packages.approvaltests: add mock

Description of changes
Fix build (https://hydra.nixos.org/build/246541866)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 281359 run on x86_64-linux 1

6 packages marked as broken and skipped:

python312Packages.approvaltests
python312Packages.approvaltests.dist
python312Packages.robotframework-selenium2library
python312Packages.robotframework-selenium2library.dist
python312Packages.robotframework-seleniumlibrary
python312Packages.robotframework-seleniumlibrary.dist

4 packages failed to build:

python311Packages.robotframework-selenium2library
python311Packages.robotframework-selenium2library.dist
python311Packages.robotframework-seleniumlibrary
python311Packages.robotframework-seleniumlibrary.dist

2 packages built:

python311Packages.approvaltests
python311Packages.approvaltests.dist


URL open redirect leads to phishing attacks

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I'm convinced that mine is new.
Describe the bug
Redirect URL in login page was not filtered and can redirect user to any website.
Attackers can send a URL like https://<FIREWALL_IP>/?url=http://phishing-site.com/ to firewall user. If user enter the credential and login, he will be redirected to malicious page
To Reproduce
Steps to reproduce the behavior:

Access https://<FIREWALL_IP>/?url=http://example.com
Enter the credential.
User was redirected to http://example.com

Environment
OPNsense 20.1-amd64
FreeBSD 11.2-RELEASE-p16-HBSD
OpenSSL 1.1.1d 10 Sep 2019

https://github.com/opnsense/core/blob/2a216f91c79a469138e5d302b5eb03b3c3743d13/src/etc/inc/authgui.inc#L117

Can you explain how that differs from clicking the malicious URL itself? Auth step or not, what is the severity assessment?

On 24. Apr 2020, at 19:41, naivekun<EMAIL_ADDRESS>wrote:

https://github.com/opnsense/core/blob/2a216f91c79a469138e5d302b5eb03b3c3743d13/src/etc/inc/authgui.inc#L117
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Malicious URL itself does not starts with "http://<REAL_IP_ADDRESS>". I'll give you an example.
If someone send you a link like "http://<IP_ADDRESS>/?url=http://bit.ly/xxxxx", "<IP_ADDRESS>" makes user feel safe instead of "http://bit.ly/xxxxx" and users are more likely to click a URL contains a trusted domain or IP address.
referrer: https://cwe.mitre.org/data/definitions/601.html

Another reasonable payload is like http://<IP_ADDRESS>/?url=http://csrf_token_XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX.hacker.com which is more easily to obfuscate user. csrf_token_XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX is a fake subdomain of hacker.com.

https://github.com/opnsense/core/commit/0d07fae36a6bf45be91da03e7fc33188c897bd5a should prevent off site redirects.


Go indexer: Add support for variable and constant definitions. [phab:D1226]

Created by fromberger at 2017-01-06 07:02:22:

Add writeBinding method to handle creating a binding definition and adds
child edges where appropriate.

Add unit test for variable definitions.

Add constant and interface schema node labels; sort the names.

zarko accepted this revision at 2017-01-06 17:41:09


Is it possible to create a Sable Diffusion plugin in the form of a1111?

I believe this is an exceptional project due to its ability to leverage SD's models while addressing the issue of inconsistent image generation in Stable Diffusion. Integrating it into a1111's Stable Diffusion would be a groundbreaking achievement and leave many people in awe.If a plugin for video generation is not feasible, could a plugin be developed for manga generation instead?

This isn't the A1111 repository. Please keep the GUI cancer limited to the GUI repos.

@tsjslgy Thank you for your interest. We are willing to do so, but I lack experience in web UI development, which may take some time. At the same time, third-party implementations are highly welcomed.


init / destroy methods

Great piece of work!
I was wondering how to init / destroy carousel on specific breakpoints as there are no such methods in the documentation. Would appreciate help.
Thanks!

Thank you!
Can you tell me more about your use case?
If you check out the first example on https://vue-ssr-carousel.netlify.app/misc, it disables the carousel-ness when there aren't enough slides for the slides-per-page of your current breakpoint.  I'm wondering, in particular, if that feature will fit your needs or not.

I would need exactly opposite behavior (disabled on mobile, active on desktop). But this is not the point. The point is to be able to programmatically init/destroy carousel. For example like this:
https://flickity.metafizzy.co/api.html#destroy (manually)
or
https://splidejs.com/guides/options/#destroy (with breakpoints)

I still don't understand why you would need to init or destroy manually.
Also, such an API doesn't feel very Vue-y to me. Like if you don't want to use vue-ssr-carousel at some breakpoint, I think you would just wrap it in a v-if that is bound to some variable you update based on the window width.

True, but with v-if you would loose the markup.
Manually destroy for a scenario when you do not want a carousel but a set of static element.


Learning WA

Is your feature request related to a problem? Please describe.
What's the problem? For example, "I'm always frustrated when..."
Describe the solution you'd like
What would you like to have connect-go do? How should we solve the problem?
Describe alternatives you've considered
If you've proposed a solution, are there any alternatives? Why are they worse
than your preferred approach?
Additional context
Add any other context or screenshots about the feature request here.

Nicely done


Adding support for saveUnknown being an array

This is a PR to add support for saving and retrieving items on a per attribute bases for saveUnknown option.
Close #275

Coverage decreased (-0.1%) to 82.382% when pulling 4eeeb7e67357112b226374a39a6e6b5fc20ab412 on fishcharlie:saveunknownperattr into 388662cdfeb128d8469f19dd04b4f653a16fd4d7 on automategreen:master.


Update Twitter logo to X

Issue #154 📐

I Hanzalah Waheed have worked for #154

Guidelines 🔐
I accept the fact that I have followed the guidelines and have not copied the codes from around the internet

[x] Contribution Guidelines
[x] Code of Conduct

Issue to be closed 🛅

My pull request closes #154

Screenshots 📷
Here are the pictures of changes that I have made 🔽

Update pr title
Fix your name in the PR template
See closed PRs for reference

Update pr title
Fix your name in the PR template
See closed PRs for reference

Update pr title Fix your name in the PR template See closed PRs for reference

Made the changes. Hope all is good now!

Fix PR title


feat: propagate external modules to swc Bundler

Towards #51
Collects Source::External module objects from the ModuleGraph and propagrates them as external modules to the swc bundler. Previously, a graph with external modules would throw a runtime exception.
This shouldn't introduce any changes in behavior to the TypeScript API, since the loader since the JsLoader from createCache doesn't expose a way to mark external dependencies.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


GRPC protocol

Many changes were merged in the proto repo, and already updated in gateway-rs and router.
The tests that passed here do not contain those changes.
Because the changes to proto touch so many things, I'd like to get this merged and address those fixes in a separate PR.


[Debugging Experience -- TRITON_INTERPRET] Multiplying float with uint fails

When using the interpreter, multiplying a float with a uint8 fails. Without the interpreter, this works. (Example taken from https://github.com/cuda-mode/lectures/blob/main/lecture 14/A_Practitioners_Guide_to_Triton.ipynb)
import os
os.environ['TRITON_INTERPRET'] = '1'

import triton
import triton.language as tl
import torch

x = torch.ones(4, dtype=torch.uint8, device='cuda')

@triton.jit
def test_k(x_ptr, bs: tl.constexpr):
    offs = tl.arange(0,bs)
    r = tl.load(x_ptr + offs)
    0.2989*r  # this fails when  TRITON_INTERPRET = 1, but runs otherwise

test_k[(2,)](x, bs=2)

Should be resolved with triton/main?

@Jokeren can confirm it's resolved with triton/main - thanks


Rails5 Update

Removed the alias_method_chains since that is being deprecated.  Also forced a version of Rake to allow all tests to pass

@jlsookiki This is my personal fork of the main repository https://github.com/jashmenn/activeuuid, so you'd better open your PR on the original one.
Also I think these fixes are covered in my PR https://github.com/jashmenn/activeuuid/pull/85. But if there are anything I've missed out, would you start discussions on that thread instead? Thanks.

@inbeom I can make a PR to the actual repo that's fine.  I only made this into yours since I forked it off yours.  This just does a slight refactor or yours to remove some final deprecations

@jlsookiki I read https://github.com/jashmenn/activeuuid/pull/86 so now I see that. I am really sorry I missed to notice the base branch of this PR is not master.
Can we continue our discussion after I merge #1? I think we can maintain activeuuid before @jashmenn decides working on it again.

@jlsookiki I've done some housekeeping works on this fork so we can start our discussion from now on. Can you open your PR against master branch? Thanks a lot!

@inbeom sounds good. I'll open it up in a bit


Deprecate AdSupport?

Shall we deprecate the AdSupport project in react-native?
Its not including a Andriod version to get Identifier for Advertising.
I've created a package to enable this on https://github.com/ptomasroos/react-native-idfa

cc @lacker

@mkonicek is the deprecationmaster so let's ask him.

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.


BUG: Report.save() does not use current working directory (as advertised)

As seen below, the current working directory is $HOME/Desktop/report-tmp and report.save() with no arguments saves to $MNE_PYTHON_PACKAGE_ROOT/report.html
In [1]: import os
In [2]: os.getcwd()
Out[2]: '/home/drmccloy/Desktop/report-tmp'
In [3]: from mne.report import Report
In [4]: from mne.datasets import sample
In [5]: path = sample.data_path()
In [6]: report = Report(verbose=True)
Embedding : jquery.js
Embedding : jquery-ui.min.js
Embedding : bootstrap.min.js
Embedding : jquery-ui.min.css
Embedding : bootstrap.min.css
In [7]: report.save()
<ipython-input-7-27511b8eb600>:1: RuntimeWarning: `data_path` not provided. Using /opt/mne/python/mne instead
  report.save()
Report already exists at location /opt/mne/python/mne/report.html. Overwrite it (y/[n])? n
Out[7]: '/opt/mne/python/mne/report.html'

Also the RuntimeWarning is confusing (to a first-time Report user like me) because data_path is not one of the parameters of Report or Report.save()

That's here:
https://github.com/mne-tools/mne-python/blob/master/mne/report.py#L1558
And it's not what we say it will do (which is os.getcwd()). This is a bug, feel free to fix separately or as part of your PR.


Fix bug with integer-typed Gelu

Certain lines in gelu()  currently round down constants if called with integer types (sqrt_2_over_pi = np.sqrt(2 / np.pi).astype(x.dtype))
Cast the input array to the nearest float-like type to avoid this, as done for trigonometic functions.

Mind adding a test also? https://github.com/google/jax/blob/main/tests/nn_test.py is the right place.

Done!


Adding tests for new_comment

This PR adds tests for the new_comment function, which is responsible for handling comments added to existing PRs.

Thanks!


Add Aunik Ahmed to Contributors list

Hi  @aunik22, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Hi @Roshanjossey , I felt delighted as I was able to learn how to contribute to open source projects. When you merged my pull request, it felt as if I had actually contributed to something and that was exciting. Thank you for this awesome tutorial.

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


[Question] Installation using Python on Windows

Checklist

[X] I'm asking a question
[X] I've looked through the README and FAQ for similar questions
[X] I've searched the bugtracker for similar questions including closed ones

Question

Could you please improve the readme's instructions for Python on Windows?
The mentioned command needs to be run "as an Administrator".

Which command?

python3 -m pip install --upgrade yt-dlp
for me I had to run (as Admin):
python3 -m pip install --upgrade yt-dlp

I don't think you need to run in Admin to install yt-dlp via pip. I tried running it in terminal (which is not privilged), but it doesn't complain about permission.
How did you install Python?


Add table on row clicked and double clicked callbacks.

Proposal to add two new API functions to set a callback for when a user clicks and double clicks a table row.
void uiTableOnRowClicked(uiTable *t, void (*f)(uiTable *t, int row, void *data), void *data);
void uiTableOnRowDoubleClicked(uiTable *t, void (*f)(uiTable *t, int row, void *data), void *data);

Implementations provided for darwin, unix, and windows. A small sample usage is provided on page16.
Two platform inconsistencies I found while testing:

Unix will send two uiTableOnRowClicked events when double clicking before the uiTableOnRowDoubleClicked event. Windows and Mac will only send one.
Mac will not select a row when ticking a checkbox, hence no uiTableOnRowClicked is sent. Unix and Windows select the row (first), send a uiTableOnRowClicked event and then send a uiTableValueChanged event.

My suggestions:

Can be ignored for now, as this will be automatically fixed once we switch to GtkGesture based events Gtk >= 3.14 or at the latest Gtk4. A working fix that requires Gtk >= 3.14 can be found here.
Not sure what to do about the differing behavior for mac in general, this should possibly be raised as an issue on its own? Comments welcome.

This would supersede #44, adding a differentiation between single and double click and fixing all problems related to keyboard events on the unix side as well (by not implicitly adding any handlers).
Supersedes old PR libui#516

My suggestions:

Can be ignored for now, as this will be automatically fixed once we switch to GtkGesture based events Gtk >= 3.14 or at the latest Gtk4. A working fix that requires Gtk >= 3.14 can be found here.

Our current Gtk dependency of 3.10 was released 2013, and Gtk 3.14 was released 2014..
I'm fine with bumping our minimum Gtk version as part of this PR. Your GtkGesture based fix looks correct to me.
diff --git a/unix/meson.build b/unix/meson.build
index f8004fbd..b1abd92a 100644
--- a/unix/meson.build
+++ b/unix/meson.build
@@ -49,7 +49,7 @@ libui_sources += [

 libui_deps += [
        dependency('gtk+-3.0',
-               version: '>=3.10.0',
+               version: '>=3.14.0',
                method: 'pkg-config',
                required: true),

Not sure what to do about the differing behavior for mac in general, this should possibly be raised as an issue on its own? Comments welcome.

I think uiprivOnCheckboxAction on Darwin could be modified to emulate the Unix and Windows behavior?
Probably out of scope for this PR though yeah.

My suggestions:

Can be ignored for now, as this will be automatically fixed once we switch to GtkGesture based events Gtk >= 3.14 or at the latest Gtk4. A working fix that requires Gtk >= 3.14 can be found here.

Our current Gtk dependency of 3.10 was released 2013, and Gtk 3.14 was released 2014.. I'm fine with bumping our minimum Gtk version as part of this PR. Your GtkGesture based fix looks correct to me.
diff --git a/unix/meson.build b/unix/meson.build
index f8004fbd..b1abd92a 100644
--- a/unix/meson.build
+++ b/unix/meson.build
@@ -49,7 +49,7 @@ libui_sources += [

 libui_deps += [
        dependency('gtk+-3.0',
-               version: '>=3.10.0',
+               version: '>=3.14.0',
                method: 'pkg-config',
                required: true),

The other option would be to guard the fixed code in a #if GTK_CHECK_VERSION(3, 14, 0) and add a @warning in the API docs that two uiTableOnRowClicked events will be sent on unix, unless you manually want to bump the version number? (Haven't tested this yet). That way we would not need to bump the version number for the entire project. Apparently Unity would break and first supported Ubuntu would be from 2015: 15.04.
Eventually we will want to bump this anyways, as a way of moving towards Gtk4. Question essentially is, do we want to put this on hold for the merge of API breaking old PRs or not.

Not sure what to do about the differing behavior for mac in general, this should possibly be raised as an issue on its own? Comments welcome.

I think uiprivOnCheckboxAction on Darwin could be modified to emulate the Unix and Windows behavior? Probably out of scope for this PR though yeah.

Yes, this will get especially tricky in conjunction with the multi select PR. I have not tested this yet, but something to look into is: how do systems modify an existing selection when ticking a checkbox with various keys held.

The other option would be to guard the fixed code in a #if GTK_CHECK_VERSION(3, 14, 0)
Eventually we will want to bump this anyways, as a way of moving towards Gtk4. Question essentially is, do we want to put this on hold for the merge of API breaking old PRs or not.

Yeah that's a better option: delay the version bump a bit longer, if its not too much effort.

Just added a fix that automatically gets applied when linking against GTK >= 3.14. All older unix systems still get the double trigger bug, which is documented as such in the API doc.
This sadly does introduce a new warning on newer systems, but should compile on older systems by using the #else branch (which is the important part). I believe the warning to be acceptable until we bump the version number.
../unix/table.c: In function ‘uiNewTable’:
../unix/table.c:666:9: warning: ‘gtk_gesture_multi_press_new’ is deprecated: Not available before 3.14 [-Wdeprecated-declarations]
  666 |         gesture = gtk_gesture_multi_press_new(GTK_WIDGET(t->tv));
      |         ^~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:117,
                 from ../unix/uipriv_unix.h:6,
                 from ../unix/table.c:2:
/usr/include/gtk-3.0/gtk/gtkgesturemultipress.h:45:14: note: declared here
   45 | GtkGesture * gtk_gesture_multi_press_new      (GtkWidget            *widget);

Thanks for the nits, fixed :)


Update platform.sh CLI version to the latest available version

Platform.sh updated their CLI again.

See MR #179


Retrying setup: API token request returned with status code 401

Describe the bug
Seams the legacy API is no longer handled correct
Latest working release
Current
Debug logs
2022-03-09 13:30:32 DEBUG (MainThread) [skodaconnect.connection] Get authorization page: "https://identity.vwgroup.io/oidc/v1/authorize" 2022-03-09 13:30:32 DEBUG (MainThread) [skodaconnect.connection] Got authorization endpoint: "https://identity.vwgroup.io/signin-service/v1/signin/f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com?relayState=22c4463fea047d890e1c4abaf120c4af17fa0d3d" 2022-03-09 13:30:32 DEBUG (MainThread) [skodaconnect.connection] Got redirect to signin-service 2022-03-09 13:30:32 DEBUG (MainThread) [skodaconnect.connection] Extracted form attribute: ('_csrf', 'c4aa16a4-85c6-45f3-8890-d203cc1868f3') 2022-03-09 13:30:32 DEBUG (MainThread) [skodaconnect.connection] Extracted form attribute: ('relayState', '22c4463fea047d890e1c4abaf120c4af17fa0d3d') 2022-03-09 13:30:32 DEBUG (MainThread) [skodaconnect.connection] Extracted form attribute: ('hmac', '5dea80011d1512b9b134065f07815cb174480a018baee5c93257653ba1fdc8f1') 2022-03-09 13:30:32 DEBUG (MainThread) [skodaconnect.connection] Start authorization for user<EMAIL_ADDRESS>2022-03-09 13:30:33 DEBUG (MainThread) [skodaconnect.connection] Found dynamic credentials form, extracting attributes 2022-03-09 13:30:33 DEBUG (MainThread) [skodaconnect.connection] JSON: {'clientLegalEntityModel': {'clientId': 'f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com', 'clientAppName': 'ŠKODA App & Portal', 'clientAppDisplayName': 'ŠKODA App & Portal', 'legalEntityInfo': {'name': 'ŠKODA', 'shortName': 'SKODA', 'productName': 'ŠKODA ID', 'theme': 'skoda', 'defaultLanguage': 'cs', 'termAndConditionsType': 'DEFAULT', 'legalProperties': {'revokeDataContact'<EMAIL_ADDRESS>'imprintText': 'IMPRINT', 'countryOfJurisdiction': 'CZ'}}, 'imprintTextKey': 'imprint.link.text'}, 'template': 'loginAuthenticate', 'hmac': '4cc7c4e338c4a83bd669b45547528a6b95ff960867e6a5caa5d54f1285bde085', 'useClientRendering': True, 'emailPasswordForm': {'email'<EMAIL_ADDRESS>'password': None}, 'error': None, 'relayState': '22c4463fea047d890e1c4abaf120c4af17fa0d3d', 'nextButtonDisabled': False, 'enableNextButtonAfterSeconds': 0, 'postAction': 'login/authenticate', 'identifierUrl': 'login/identifier'} 2022-03-09 13:30:33 DEBUG (MainThread) [skodaconnect.connection] Finalizing login 2022-03-09 13:30:33 DEBUG (MainThread) [skodaconnect.connection] Using login action url: "https://identity.vwgroup.io/signin-service/v1/f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com/login/authenticate" 2022-03-09 13:30:33 DEBUG (MainThread) [skodaconnect.connection] Following redirect to "https://identity.vwgroup.io/oidc/v1/oauth/sso?clientId=f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com&relayState=22c4463fea047d890e1c4abaf120c4af17fa0d3d&userId=8c9a2806-bc44-4575-93e8-b552d4b26829&HMAC=b0a3d71c7d4ff578dc227db67e5a7300e55891656a0cfe6201acf9c4f30bd418" 2022-03-09 13:30:33 DEBUG (MainThread) [skodaconnect.connection] Following redirect to "https://identity.vwgroup.io/signin-service/v1/consent/users/8c9a2806-bc44-4575-93e8-b552d4b26829/f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com?scopes=openid%20mbb%20profile&relayState=22c4463fea047d890e1c4abaf120c4af17fa0d3d&callback=https://identity.vwgroup.io/oidc/v1/oauth/client/callback&hmac=09397ca690d32ad197173f6084530e20b2716241c4780d2559defd7ae26ca64d" 2022-03-09 13:30:33 DEBUG (MainThread) [skodaconnect.connection] Following redirect to "https://identity.vwgroup.io/oidc/v1/oauth/client/callback/success?user_id=8c9a2806-bc44-4575-93e8-b552d4b26829&client_id=f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com&scopes=openid%20mbb%20profile&consentedScopes=openid%20mbb%20profile&relayState=22c4463fea047d890e1c4abaf120c4af17fa0d3d&hmac=6cae527634c7c8c8c0278a1f57cd749f2f23ab6e4522cf3be339914fdba4a90c" 2022-03-09 13:30:33 DEBUG (MainThread) [skodaconnect.connection] Received authorization code, exchange for tokens. 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Got access_token for client f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com, token: "ACCESS_TOKEN" 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Got refresh_token for client f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com, token: "REFRESH_TOKEN" 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Got id_token for client f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com, token: "ID_TOKEN" 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Verifying token for f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Matching f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com against 7f045eee-7003-4379-9968-9355ed2adb06@apps_vw-dilab_com 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Matching f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com against f9a2359a-b776-46d9-bd0c-db1904343117@apps_vw-dilab_com 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Token for skoda verified OK. 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Client "connect" token is missing, call to authorize the client. 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Starting authorization process for client connect 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Get authorization page: "https://identity.vwgroup.io/oidc/v1/authorize" 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Got authorization endpoint: "https://identity.vwgroup.io/oidc/v1/oauth/sso?clientId=7f045eee-7003-4379-9968-9355ed2adb06@apps_vw-dilab_com&userId=8c9a2806-bc44-4575-93e8-b552d4b26829&relayState=e0a8b687a5908b7777c00edd48af57f27dab1b65&HMAC=41f78fe2734c44f3953f95b535a644150638ca8d6ce385b6437acafd69ece5fa" 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Following redirect to "https://identity.vwgroup.io/signin-service/v1/consent/users/8c9a2806-bc44-4575-93e8-b552d4b26829/7f045eee-7003-4379-9968-9355ed2adb06@apps_vw-dilab_com?scopes=openid%20profile%20address%20cars%20email%20birthdate%20badge%20mbb%20phone%20driversLicense%20dealers%20profession%20vin&relayState=e0a8b687a5908b7777c00edd48af57f27dab1b65&callback=https://identity.vwgroup.io/oidc/v1/oauth/client/callback&hmac=97cbbd821c008fac10cb1aebce10f5667ef9dc2c8b29a46d09e50d4ab78693c8" 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Following redirect to "https://identity.vwgroup.io/oidc/v1/oauth/client/callback/success?user_id=8c9a2806-bc44-4575-93e8-b552d4b26829&client_id=7f045eee-7003-4379-9968-9355ed2adb06@apps_vw-dilab_com&scopes=openid%20profile%20address%20cars%20email%20birthdate%20badge%20mbb%20phone%20driversLicense%20dealers%20profession%20vin&consentedScopes=openid%20profile%20address%20cars%20email%20birthdate%20badge%20mbb%20phone%20driversLicense%20dealers%20profession%20vin&relayState=e0a8b687a5908b7777c00edd48af57f27dab1b65&hmac=50c31240d9cfad864fcb37488795670a142b5ffa7ccc281fbaade5a1a5fff08d" 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Received authorization code, exchange for tokens. 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Got access_token for client 7f045eee-7003-4379-9968-9355ed2adb06@apps_vw-dilab_com, token: "ACCESS_TOKEN" 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Got refresh_token for client 7f045eee-7003-4379-9968-9355ed2adb06@apps_vw-dilab_com, token: "REFRESH_TOKKEN" 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Got id_token for client 7f045eee-7003-4379-9968-9355ed2adb06@apps_vw-dilab_com, token: "ID_TOKEN" 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Verifying token for 7f045eee-7003-4379-9968-9355ed2adb06@apps_vw-dilab_com 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Matching 7f045eee-7003-4379-9968-9355ed2adb06@apps_vw-dilab_com against 7f045eee-7003-4379-9968-9355ed2adb06@apps_vw-dilab_com 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] Token for connect verified OK. 2022-03-09 13:30:34 DEBUG (MainThread) [skodaconnect.connection] HTTP POST "https://profileintegrityservice.apps.emea.vwapps.io/iaa/pic/v1/users/8c9a2806-bc44-4575-93e8-b552d4b26829/check-profile" 2022-03-09 13:30:35 DEBUG (MainThread) [skodaconnect.connection] Request for "https://profileintegrityservice.apps.emea.vwapps.io/iaa/pic/v1/users/user/check-profile" returned with status code [200], response: {'scopeId': 'commonMandatoryFields', 'ssoId': 'SSOID', 'missingMandatoryFields': [], 'mbbUserId': 'UserID', 'mbbIdStatus': True, 'mandatoryFieldsStatus': True, 'spinStatus': True, 'mandatoryConsentInfo': [{'id': 'termsOfUse', 'status': 'VALID'}]} 2022-03-09 13:30:35 DEBUG (MainThread) [skodaconnect.connection] Consent returned {'consentInfo': {'scopeId': 'commonMandatoryFields', 'ssoId': '8c9a2806-bc44-4575-93e8-b552d4b26829', 'missingMandatoryFields': [], 'mbbUserId': 'UserID', 'mbbIdStatus': True, 'mandatoryFieldsStatus': True, 'spinStatus': True, 'mandatoryConsentInfo': [{'id': 'termsOfUse', 'status': 'VALID'}]}} 2022-03-09 13:30:35 DEBUG (MainThread) [skodaconnect.connection] User consent is valid, no missing information for profile 2022-03-09 13:30:35 DEBUG (MainThread) [skodaconnect.connection] HTTP GET "https://api.connect.skoda-auto.cz/api/v2/garage/vehicles" 2022-03-09 13:30:36 DEBUG (MainThread) [skodaconnect.connection] Request for "https://api.connect.skoda-auto.cz/api/v2/garage/vehicles" returned with status code [200], response: [] 2022-03-09 13:30:36 DEBUG (MainThread) [skodaconnect.connection] Skoda native API returned no vehicles. Using fallback VW-Group API. 2022-03-09 13:30:36 DEBUG (MainThread) [skodaconnect.connection] Client "vwg" token is missing, call to authorize the client. 2022-03-09 13:30:36 DEBUG (MainThread) [skodaconnect.connection] Trying to fetch api tokens. 2022-03-09 13:30:37 DEBUG (MainThread) [skodaconnect.connection] API token request failed. 2022-03-09 13:30:37 WARNING (MainThread) [homeassistant.config_entries] Config entry 'VIN' for skodaconnect integration not ready yet: API token request returned with status code 401; Retrying in background
Installation:

Home Assistant variant: Supervised
Python version 3.8

Additional context
Add any other context about the problem here.

There has been outages this past week. Is the issue still there?
If that's the case, can you verify that skoda-connect.com shows your vehicle and that the MySkoda app also works after logout/login?

Still the same, app and website are OK.

There is some information in the LOG Client "vwg" token is missing, call to authorize the client.
This is might the reason for not working

There is some information in the LOG Client "vwg" token is missing, call to authorize the client. This is might the reason for not working

Yes it fails to fetch the token required to access the API for "legacy" cars. Not sure why since it's working fine here. Might be an issue with the scope requested for the client but either way I cannot reproduce.
You can try the example python code from the library and see if that gets you any further.

I'll try

Could resolve the issue by recreating the account


Generated by :no_entry_sign: Danger


Header modification policy strips port number from string

This policy allows for the new or additional Header value to be defined as a string or liquid value.
For example: Host: api.com:80 would be added to the policy config with Host & api.com:80 as two separate values in the same policy configuration.
Version

Image: registry.access.redhat.com/3scale-amp23/apicast-gateway:1.11-1

Running on Docker with following version:

Client:
Version:         1.13.1
API version:     1.26
Package version: docker-1.13.1-61.git9cb56fd.fc28.x86_64
Go version:      go1.10.3
Git commit:      1556cce-unsupported
Built:           Wed Aug  1 17:21:17 2018
OS/Arch:         linux/amd64

Server:
Version:         1.13.1
API version:     1.26 (minimum version 1.12)
Package version: docker-1.13.1-61.git9cb56fd.fc28.x86_64
Go version:      go1.10.3
Git commit:      1556cce-unsupported
Built:           Wed Aug  1 17:21:17 2018
OS/Arch:         linux/amd64
Experimental:    false

image timestamp: 2018-09-25T20:54:25.389199Z

Steps To Reproduce

Configure Header modification policy with op: Create the header when not set, replace the value when set. header: Host value: <my-api.com>:<port>
docker run using the latest configuration for the service with above policy config.

Current Result
Host header is sent to the upstream as Host: <my-api.com>
Expected Result
Host header is sent to the upstream as Host: <my-api.com>:<port>
Additional Information
The expected format is compliant with the RFC and is an accepted format.
Log entry in error logs
Example apicast config.json

@kevprice83 do I understand this correctly, that when you set header Host to example.com:8080 it is sent upstream as example.com?

@mikz correct, this might be considered an enhancement rather than a bug of course. The RFC states the port is accepted although in my experience it's not that common.

oh  I see why it might not have been clear now, the markdown is not rendering the port correctly in my original description

@kevprice83 you can just configure host header in the UI and there it works just fine.

@mikz that's interesting because on the previous version I can modify the Host header.
Image: registry.access.redhat.com/3scale-amp22/apicast-gateway:1.8-12
Timestamp: 2018-08-17T08:52:30.421763Z
With this image the Host header is modified using the same policy config.

@mikz it's not possible to add the port in the host header rewrite field until THREESCALE-1408 is fixed. Otherwise yeah that was my first solution.

@mikz so what will the decision be here? To fix the hostname rewrite field and keep the current behaviour? Just wondering if the change in behaviour on APIcast between versions is unexpected?

@mikz what will be the decision here then? To fix the hostname rewrite field and use that or change the current behaviour in APIcast? Wondering if the change in behaviour between versions is unexpected or not?

@mikz what will be the decision here then? To fix the hostname rewrite field and use that or change the current behaviour in APIcast? Wondering if the change in behaviour between versions is unexpected or not?

@kevprice83 3scale/porta is open source, so fixing THREESCALE-1408 should be a trivial task.
However, that would solve only the main endpoint of the configuration, not servers set by the upstream policy.
The change of behaviour is on hand unexpected (because we did not know about it), but also expected, because we rewrote the whole upstream subsystem to be more consistent.
If we aim to fix it in APIcast, then this would require several changes:

ability to turn off / configure hostname rewrite in the APIcast policy and
ability to turn off setting host header in the APIcast policy or
changes required to make Headers policy to override Host header set by APIcast


Is software v9 not supported?

I'm trying out this code on an ESP32 with a JK-BD6A17S8P
Only a few of the parameters are coming through with the rest either showing non-sensical values or non-printing characters.
Details from the App over Bluetooth:
Hardware Ver: 9.X
Software Ver: 9.01G
Example conversation from ESPHome log:
[I][jk_bms:061]: Status frame received
[D][sensor:125]: 'jk-bms min cell voltage': Sending state 100.00000 V with 3 decimals of accuracy
[D][sensor:125]: 'jk-bms max cell voltage': Sending state -100.00000 V with 3 decimals of accuracy
[D][sensor:125]: 'jk-bms delta cell voltage': Sending state -200.00000 V with 3 decimals of accuracy
[D][text_sensor:067]: 'jk-bms errors': Sending state ''
[D][text_sensor:067]: 'jk-bms operation mode': Sending state 'Discharging enabled;Balancer enabled;Battery dropped'
[D][text_sensor:067]: 'jk-bms operation mode': Sending state 'Discharging enabled;Balancer enabled;Battery dropped'
[D][text_sensor:067]: 'jk-bms battery type': Sending state 'Unknown'
[D][text_sensor:067]: 'jk-bms password': Sending state ''
[D][text_sensor:067]: 'jk-bms device type': Sending state ''
[D][text_sensor:067]: 'jk-bms software version': Sending state '�?xV���S�?'
[D][sensor:125]: 'jk-bms actual battery capacity': Sending state 744619328.00000 Ah with 0 decimals of accuracy
[D][text_sensor:067]: 'jk-bms manufacturer': Sending state ''
[D][text_sensor:067]: 'jk-bms manufacturer': Sending state ''

It looks like the response payload has changed. Does the BMS return this garbage periodically depending on the update/request interval?

Actually I just moved the pins on the ESP from 14 & 4 to
  tx_pin: GPIO16
  rx_pin: GPIO17

as it is my understanding that that makes use of the hardware UART: https://esphome.io/components/logger.html#hardware-uarts
and after that change I'm in good shape.
Perhaps I just had a loose wire and it was just the re-connection that solved it, or perhaps there's something to that hardware UART business.  In any case thanks for putting together this awesome project.


Created a simple way of using the FishyUnityTransport Relay capabilities

First, thank you for maintaining a FishNet plugin to support Unity Relay's feature !
I added a FishyUnityTransportRelayManager component with these features :

A simple way to start an allocation as Host using relay and getting a JoinCode with a StartHostWithRelay() method.
A simple way to join a relay server as a client with a StartClientWithRelay(string joinCode) method

There is also a StartServerWithRelay() method that you can use.
I modified the Assembly Definition to add Unity.Services.Relay. (this might be an issue if people wants to use the Unity Transport with FishNet without wanting to use Relay)
Everything's asynchronous for the relay creation and joining.
I also added a Tutorial to the README, on how to set it up, especially the Authentication part that will not work without it.

Hi, thanks for your interest in transport. I have taken a close look at your PR and unfortunately cannot accept it. This is not the direction in which I would like to see FishyUnityTransport go. I am in the process of developing other assets for these needs and hope to be able to present them in the near future.

I may possibly re-create the PR on my end with this as a reference. Please understand.


Support for QCELLS cloud (analog to solax-cloud)

Many QCELLS products are rebranded solax products, and so QCELLS cloud API is most probably to be used the same way as the solax cloud, but with a different uri.
Uri format in solax template is:
uri: https://www.solaxcloud.com/proxyApp/proxy/api/getRealtimeInfo.do?tokenId={{.tokenid}}&sn={{.serial}}
Uri format for QCELLS should be:
uri: https://www.portal-q-cells.us/proxyApp/proxy/api/getRealtimeInfo.do?tokenId={{.tokenid}}&sn={{.serial}}
So either the hostname for the solax can be provided by a template parameter in order to support both QCELLS and solax with the same template, or a clone of the solax template with a different hardcoded uri can be provided.

Actually I did, but I put the wrong value in for serial number.
Not the serial of the inverter (Inverter SN) is to be used, but the ID of the LAN dongle, named "Registration No." in QCELLS web interface.

So thx for the information on the dns target, now I can continue testing.


Publisher stops respecting reconnect period after initial successful connection

Describe the bug
If OPC Publisher 2.9.4 cannot connect to a certain endpoint, it will try again every second to reconnect. reconnectperiod is set to 1000 ms, so this makes sense. I upped it to 10 seconds using --reconnectperiod=10000, and that works the first time, but after it the server comes online and later on disappears again, the publisher gets stuck in errors occurring publish requests, and it keeps printing that every second rather than every 10 seconds - it doesn't seem to notice the connection as fully 'dropped' somehow and never goes back to retrying every 10 seconds, not even after 15 minutes or more of these errors.
To Reproduce
Steps to reproduce the behavior:

Pass --reconnectperiod=10000.
Configure an OPC UA server that isn't available.
Notice connections being attempted every 10 seconds as expected.
Bring the server online on the specified address.
Wait for the publisher to connect properly.
Bring the server offline or make it unreachable.
Notice errors being printed every second about not being able to publish.

Expected behavior
The publisher disconnects properly, possibly after a grace period.
Additional context
The error being spammed every second after this happens is the following:
[24-02-12 14:00:48.4247] fail: Azure.IIoT.OpcUa.Publisher.Stack.Services.OpcUaStack[0]
      Unexpected error sending publish request.
      Opc.Ua.ServiceResultException: BadConnectionClosed
         at Opc.Ua.Bindings.UaSCUaBinaryClientChannel.BeginSendRequest(IServiceRequest request, Int32 timeout, AsyncCallback callback, Object state)
         at Opc.Ua.Client.Session.BeginPublish(Int32 timeout)
[24-02-12 14:00:48.9734] info: Azure.IIoT.OpcUa.Publisher.Stack.Services.OpcUaSubscription[0]
      Subscription <<UnknownDataSet>>_($e1822db470e60d090affd0956d743cb0e7cdf113):439048616 STOPPED!

@mregen

We are looking at streamlining the opc ua stack errors so that they do not look like exceptions, the issue is benign. Otherwise, the reconnect timing should work now, I tested this using the docker-compose deployment with MQTT and there is now also a log message that shows the timer that tracks the reconnect delays.  The numbers are in millisecond and contain a jitter component.


Generate .lib files

I have succesfuly built the OpenBLAS with cygwin (make TARGET=PRESCOTT), but it didn't generate any .lib files, just libopenblas.dll and libopenblas_prescottp-r0.1alpha2.4.dll. How can I get those?

Hi,
I think you should run "lib /machine:X64 /def:libgoto2.def" in
OpenBLAS/exports folder. The lib program is a tool in Visual Studio. You
could download the free Visual Studio Express from the Microsoft website.
I am on a business tripe. Because I didn't install visual studio on my
box, I have not tested this method. When I am back the office, I will
try this method.
Thanks
Xianyi
gbnk write:Sent: 2011/10/11 7:15

I have succesfuly built the OpenBLAS with cygwin (make TARGET=PRESCOTT), but it didn't generate any .lib files, just libopenblas.dll and libopenblas_prescottp-r0.1alpha2.4.dll. How can I get those?

Hi,
Your method worked just fine. Thanks!


Bump version, compatible with MikroORM V6

Current version is already compatible.

Not exactly
Peer dependency error
https://github.com/mikro-orm/nestjs/blob/master/package.json#L43

I dont see any peer dependency error (https://github.com/mikro-orm/nestjs-realworld-example-app), ^6.0.0-dev already supports any 6.0 stable version.

Maybe this calculator don't work perfectly, I have error during npm install
Anyway I create PR https://github.com/mikro-orm/nestjs/pull/156

as i said, i dont see any errors, tried with npm and yarn in the realworld example app, no issues there
anyway, i will ship v6 of this package too later this week (maybe even today). if you see issues with peer deps, you can always just use --force to get around them.

you can always just use --force to get around them

Already

Is there a way to pre build a cache when dynamically creating a config using the forrootasync function?


Remove old arrow versions

Closes #29 by updating the arrow dependency and raising the build number.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Creating a Table from a Typescript interface

Hello y'all! Such a great library, it's already saving me so much headache and I can see it only getting better.
I have a naive question which I couldn't find an answer to in previous issues but forgive me if this is possible or if it has been asked and answered already but:
If we're able (and one of the first best features of Kysely is) to define a database schema using Typescript interfaces, why isn't there a way to create the tables with that schema from the Typescript interfaces that have been given?
In other words:
interface Table {
    id: GeneratedAlways<number>

    created_at: ColumnType<Date, string | undefined, never>
    metadata: JSONColumnType<any>

   ...etc etc
}

interface Database {
  table: Table
}

const db = new Kysely<Database>()

why must we then do something like
db.schema.createTable('table')
  .addColumn('id', 'number', (cb) => cb.primaryKey())
  ...etc etc
  .execute()

rather than
db.createTable('table') // it is already known to the schema so it's definition is already understood
  .execute()

I feel this would reduce duplication and increase understandability of code, two architecture choices that seem core to kysely. I could even imagine it really simplifying migrations if it were possible!
Thanks so much for your time!

Hey 👋

If we're able (and one of the first best features of Kysely is) to define a database schema using Typescript interfaces, why isn't there a way to create the tables with that schema from the Typescript interfaces that have been given?

TypeScript types are not expressive enough to translate to production-grade schemas. It would require building an annotation/branded type system just to express the various numeric and string data types. Lots of complexity for little to no gain.
It'd require a CLI - not gonna happen as part of core.

I feel this would reduce duplication and increase understandability of code

This actually reduces the understandability of code. There's implicit stuff going on under the hood. You lose control over what SQL is being run. Kysely is a query builder, not an ORM. The main design principle is What You See Is What You Get.
Migrations should be dead simple, explicit, and should be frozen in time.
You're not forced to use Kysely's schema module. You can use Prisma/Atlas/Drizzle for migrations if you want to.

Ahh right Kysely is a query builder, not an ORM, I'm sure you get this all the time, I apologize! The place that I figure got turned on to Kysely even has it ambiguously labeled under ORMs alongside Prisma and others 🤣😅

Yeah, ORM became "a library that talks to my SQL database" and everyone's confused now.


Don't use coroutines in util.sortedpairs

util.sortedpairs is used in luarocks loader since @6dc745a.
Openresty does not like coroutines being used from inside require,
resulting in "attempt to yield across C-call boundary" error.
New version of util.sortedpairs uses a prepared array of ordered keys
instead of coroutines.
Also added some tests for it.

Thank you! (And thanks for adding tests!! :D )


Escape attribute and packed using asciidoc inline passthrough

Unlike Markdown `` in Asciidoc simply applies monospace formatting
rather than literal text. This means __attribute__ and __packed__
were being formatted incorrectly. This patch uses the inline passthrough
syntax https://docs.asciidoctor.org/asciidoc/latest/pass/pass-macro/
to avoid this.

Thanks! Seem like C++ confused the Asciidoc parsing, let me handled that in another PR.

https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/316 fix the pdf formatting issue, got following pdf render result if no #316.


[WFCORE-497] Do cross-model validation in a separate step

While at it I made a couple minor changes to how data is obtained during validation.

Linux Build 1036 is now running using a merge of e12f45788efc0ab987826630e8b77915cff5be75

Windows Build 744 is now running using a merge of e12f45788efc0ab987826630e8b77915cff5be75

Core - Full Integration Build 319 is now running using a merge of e12f45788efc0ab987826630e8b77915cff5be75

Just thinking out loud, couldn't we do validation like this also in ValidateModelStepHandler? which is already ran as separate step.

Windows Build 744 outcome was SUCCESS using a merge of e12f45788efc0ab987826630e8b77915cff5be75
Summary: Tests passed: 2932, ignored: 95 Build time: 0:15:50

Linux Build 1036 outcome was SUCCESS using a merge of e12f45788efc0ab987826630e8b77915cff5be75
Summary: Tests passed: 2932, ignored: 95 Build time: 0:19:55

Core - Full Integration Build 319 outcome was FAILURE using a merge of e12f45788efc0ab987826630e8b77915cff5be75
Summary: Tests failed: 1 (1 new), passed: 2839, ignored: 430 Build time: 0:42:19
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ws.wsse.signencrypt.EJBSignEncryptMultipleClientsTestCase.encryptedAndSignedRequestFromAlice: javax.xml.ws.WebServiceException: Could not send Message.
	at java.net.SocketInputStream.socketRead0(Native Method)
	at java.net.SocketInputStream.read(SocketInputStream.java:152)

The concern here seems to be very different wrt to the ValidateModelStepHandler question.

@ctomc Eventually much of this stuff should be done in something like ValidateModelStepHandler, or perhaps internally in the OC the way that capabilities and requirements are resolved. I'm talking here about the "validating model ref" part. These particular OSHs also do some pretty-custom validation that I don't envision us handling centrally -- the HandlerUtil.checkNoOtherHandlerWithTheSameName bit.
I did this as a one-off because it is blocking Alexey's work.

makes sense, tnx @bstansberry


CIfar100_Codes

Hi,
Could you also share the codes on how you split cifar 100 and stl-10 dataset?
Many thanks,
Jeff

Hi,
Previously, I personally replied to your e-mails related to this issue.
Now, I update those parts in this repository (dataset/remix_cifar100.py, dataset/remix_stl.py)
Thanks,
Jaehyung


Doesn't interact correctly with typing.overload.

If you provide a @typing.overload for a function, the output is not correct. As far as I can tell, this problem is not fixable without changes to autodoc.
The is that in the presence of a typing.overload, autodoc will never emit an 'autodoc-process-signature' event. You can see the logic here in FunctionDocumenter.format_signature:
https://github.com/sphinx-doc/sphinx/blob/master/sphinx/ext/autodoc/__init__.py?plain=1#L2193
If self.analyzer.overloads has overloads for this function, it uses overloaded signatures, otherwise it calls super().format_signature. In this case super().format_signature is Documenter.format_signature which actually emits the `'autodoc-process-signature' event:
https://github.com/sphinx-doc/sphinx/blob/master/sphinx/ext/autodoc/__init__.py?plain=1#L513\
So when overloads exist, we fail to override default behavior. An easy fix for this is:
from sphinx.ext.autodoc import FunctionDocumenter
del FunctionDocumenter.format_signature

Example module
from typing import overload

@overload
def f(a : int, b : int) -> None:
    ...

@overload
def f(a : str, b : str) -> None:
    ...

def f(a : int | str, b : int | str) -> None:
    """
    f does the thing. The arguments can either be ints or strings but they must
    both have the same type.

    Parameters
    ----------
    a:
        The first thing
    b:
        The second thing
    """

Actual output

Actual output

Desired output
achieved with del FunctionDocumenter.format_signature

Desired output

I guess you also have to del MethodDocumenter.format_signature.

PR trying to address this is welcome 🤗

Are you okay with adding:
from sphinx.ext.autodoc import FunctionDocumenter, MethodDocumenter

del FunctionDocumenter.format_signature
del MethodDocumenter.format_signature

to setup?

I'm willing to try.

Okay, PR incoming.

Closed by #297.


txt file handling added to dropzone

Uploading local file to GCS and reading via GcsFileLoader with loader function as PyMuPdfLoader or UnstructuredFileLoader respectively


Update MSSQL versions in CI workflow.

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

👍


BUG: linalg: test_decomp_update fail

win10 x64 python3.6.0a0 amd64
numpy master:9cd868a00cc488478ac4f07ee0b5452a38cb3cc0
scipy  master:89066e8b5eea5ce638b95cd6a94013102495e39a
mkl 2015

FAIL: test_decomp_update.TestQRdelete_D.test_delete_last_p_col
Traceback (most recent call last):
File "E:\pyjq\cpython\lib\site-packages\nose\case.py", line 198, in runTest
self.test(*self.arg)
File "E:\pyjq\cpython\lib\site-packages\scipy\linalg\tests\test_decomp_update.py", line 328, in test_delete_last_p_col
assert_unitary(q1)
File "E:\pyjq\cpython\lib\site-packages\scipy\linalg\tests\test_decomp_update.py", line 21, in assert_unitary
assert_allclose(aTa, np.eye(a.shape[1]), rtol=rtol, atol=atol)
File "E:\pyjq\cpython\lib\site-packages\numpy\testing\utils.py", line 1347, in assert_allclose
verbose=verbose, header=header)
File "E:\pyjq\cpython\lib\site-packages\numpy\testing\utils.py", line 708, in assert_array_compare
raise AssertionError(msg)
AssertionError:
Not equal to tolerance rtol=1e-13, atol=4.44089e-16
(mismatch 1.3888888888888857%)
x: array([[  1.000000e+00 +0.000000e+00j,   3.816392e-17 +5.898060e-17j,
4.163336e-17 +2.775558e-17j,   1.387779e-17 +2.775558e-17j,
6.938894e-17 -6.245005e-17j,   3.469447e-17 -2.341877e-17j,...
y: array([[ 1.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.],
[ 0.,  1.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.],
[ 0.,  0.,  1.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.],...

This looks like it is probably okay, but the test tolerance is too tight.  @yajiedesign, could you rerun the tests after changing line 328 of scipy/linalg/tests/test_decomp_update.py  to be
assert_unitary(q1, rtol=1e-13, atol=1e-14)

If that doesn't fix things, could you please try changing the atol value too see what tolerance it would take to pass?

when i change 328 to assert_unitary(q1,1e-5,1e-6) ,it not fail

Hmm, not sure what to do with this one. Going from 2 * eps to 1e-5 doesn't sound like a simple case of test tolerance a bit too tight. The mismatch of 1.38% means that exactly 2 values (it's an array of shape (12,12)) are way off.

MKL 2015 probably hasn't been exercised a lot yet (and neither has Python 3.6.0a0, but that's probably less relevant).

Removing the 0.16.1 milestone; this is not a must-have.

Both this and gh-10550 seem to have a slight tolerance issue.
https://github.com/scipy/scipy/blob/main/scipy/linalg/tests/test_decomp_update.py#L14 sets
    if atol is None:
        atol = 10*np.finfo(a.dtype).eps

which is too tight, at least on a MacOS with some linalg backends.

we do not see it in our regular CI, incl MacOS
the last time it was seen was in 2019 (gh-10550)
the tolerance violations look minor both here and in gh-10550 (over there with float32/complex64 arrays: 3.6e-7 vs atol=2.4e-7; in here "mismatch 1.3888888888888857%", so the bump in https://github.com/scipy/scipy/issues/5117#issuecomment-128703596 is likely an overshot)

I suggest we close both this and gh-10550, possibly bumping the atol to 20 eps or some such. Thoughts?
cc @tylerjereddy who participated in the linked issue, @ilayn as the linalg regular

@ev-br I agree. I wrote up a detailed history of this issue in gh-21432, which would bump the tolerance as you suggest, but I suspect we can just close it and this issue. (I closed the other duplcates tonight.)
Before closing this one, I'd just like to confirm that @andyfaff is no longer able to reproduce the failure (he filed gh-10716), and I'd like to see if @h-vetinari can provide more information about it (reported in gh-19210).

I'd like to see if @h-vetinari can provide more information about it (reported in gh-19210).

I'm unsure if this is related. The failures in #19210 are catastrophically wrong, not a simple tolerance violation. To my understanding they also only happen in emulation, not on native hardware (which makes it likely that the bug is in the emulation layer itself). However, I have no native hardware to test (and neither does conda-forge), so I've been taking that item on good faith.

OK, I'll go ahead and close this. If the problems are related, then we'll conisder gh-19210 to supersede this issue; if they aren't, I agree with https://github.com/scipy/scipy/issues/5117#issuecomment-1987202802 that this doesn't appear to be a problem anymore.


create a function to change job status to in progress (status = 1)

This is a simple function that just takes the 'status' field on a job at sets it to 1. Some quick notes:

Job status is set to 0 by default
A status of 0 means "Open"
A status of 1 means "In Progress"
A status of 2 means "Completed"

The status field is intended to help the frontend differentiate between the jobs, and, for example, avoid displaying jobs that are already in progress or completed to users looking for open jobs.

Great! Thank you, Logan!


Make official ChakraCore Linux binaries that work on all currently maintained versions of Linux

This is is a follow on from https://github.com/Microsoft/ChakraCore/issues/2278 . The currently available Linux ChakraCore binaries only work on some Linux distros. Ideally they would work on all (currently maintained) Linux distros.
I've put together a rough build system that is capable of generating such binaries (https://github.com/cosinusoidally/ChakraCore-experiments/tree/master/build-chakracore). It does this by generating a CentOS 6 based root filesystem, and building a copy of CMake 3.5.2 and Clang 3.8. It then uses CMake and Clang to build ChakraCore. Unfortunately there are still one or two manual steps since ChakraCore's CMakeFiles do not instruct the compiler to link to librt. I'm sure that would be easy to patch, but my knowledge of CMake is quite limited. My current work around is to manually invoke the compiler with "-lrt" appended to the command line (only 3 or 4 build steps error out, so this isn't too tedious to do).
I also noticed that the binary I built would crash on my Core 2 Duo based system. I was running a simple "Hello World" JavaScript script. The same binary did not crash on a Haswell based system. Any idea why that would be? I am guessing that you may be using SSE 4 instructions? If so, is it possible to build ChakraCore to target only SSE 2?

@cosinusoidally cool! cc @obastemur since he's our xplat build expert
@cosinusoidally do you have a stack trace for your crash?

I understand making ChakraCore binaries available to older distros could be beneficial to some.
Reminder; ChakraCore can be build from source code on older distros. (AFAIK)
Concerns;

Are we going to support those distros? That comes with CI changes. Otherwise it will be hard.
Are we going to provide bug / security fixes ?
That means we will target / embed some older versions of dependencies. We have to update our license / binary release docs and internally start process for these?
This is an open source project. If there are parties interested, patches welcome and I'm ready to put my personal time into helping to those patches etc. (as long as they do not break the current targets). Do we have to make this official ? (read the list above again)
We have some other targets (x86, arm64 etc.) with IMHO bigger priorities.

@digitalinfinity stack trace for official Linux x86_64 binary from here: https://github.com/Microsoft/ChakraCore/releases/tag/v1.7.0
This is running on a T5300 Core 2 Duo, see below flags from /proc/cpuinfo:
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx lm constant_tsc arch_perfmon pebs bts rep_good nopl aperfmperf pni dtes64 monitor ds_cpl est tm2 ssse3 cx16 xtpr pdcm

gdb session:
ljw@ubuntu:~/Desktop$ ./ch
Illegal instruction
ljw@ubuntu:~/Desktop$ gdb ./ch
GNU gdb (Ubuntu 7.7.1-0ubuntu5~14.04.3) 7.7.1
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ./ch...(no debugging symbols found)...done.
(gdb) run
Starting program: /home/ljw/Desktop/ch
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7ffff70d2700 (LWP 1201)]

Program received signal SIGILL, Illegal instruction.
0x000055555568aae3 in _GLOBAL__sub_I_RecyclerHeuristic.cpp ()
(gdb) bt
#0  0x000055555568aae3 in _GLOBAL__sub_I_RecyclerHeuristic.cpp ()
#1  0x0000555555f5aa9d in __libc_csu_init ()
#2  0x00007ffff70f4ed5 in __libc_start_main (main=0x5555556abda0 <main>, argc=1, argv=0x7fffffffe238,
    init=0x555555f5aa50 <__libc_csu_init>, fini=<optimised out>, rtld_fini=<optimised out>, stack_end=0x7fffffffe228)
    at libc-start.c:246
#3  0x00005555556a7b29 in _start ()
(gdb) disassemble
Dump of assembler code for function _GLOBAL__sub_I_RecyclerHeuristic.cpp:
   0x000055555568aa90 <+0>:     push   %rbp
   0x000055555568aa91 <+1>:     mov    %rsp,%rbp
   0x000055555568aa94 <+4>:     push   %rbx
   0x000055555568aa95 <+5>:     sub    $0x18,%rsp
   0x000055555568aa99 <+9>:     mov    $0x55,%edi
   0x000055555568aa9e <+14>:    callq  0x5555556893d0 <sysconf@plt>
   0x000055555568aaa3 <+19>:    mov    %rax,%rbx
   0x000055555568aaa6 <+22>:    mov    $0x1e,%edi
   0x000055555568aaab <+27>:    callq  0x5555556893d0 <sysconf@plt>
   0x000055555568aab0 <+32>:    imul   %rbx,%rax
   0x000055555568aab4 <+36>:    movq   %rax,%xmm0
   0x000055555568aab9 <+41>:    test   %rax,%rax
   0x000055555568aabc <+44>:    je     0x55555568aaea <_GLOBAL__sub_I_RecyclerHeuristic.cpp+90>
   0x000055555568aabe <+46>:    mov    $0x56,%edi
   0x000055555568aac3 <+51>:    movdqa %xmm0,-0x20(%rbp)
   0x000055555568aac8 <+56>:    callq  0x5555556893d0 <sysconf@plt>
   0x000055555568aacd <+61>:    mov    %rax,%rbx
   0x000055555568aad0 <+64>:    mov    $0x1e,%edi
   0x000055555568aad5 <+69>:    callq  0x5555556893d0 <sysconf@plt>
   0x000055555568aada <+74>:    movdqa -0x20(%rbp),%xmm0
   0x000055555568aadf <+79>:    imul   %rbx,%rax
=> 0x000055555568aae3 <+83>:    pinsrq $0x1,%rax,%xmm0
   0x000055555568aaea <+90>:    movq   %xmm0,%rax
   0x000055555568aaef <+95>:    cmp    $0x20000000,%rax
   0x000055555568aaf5 <+101>:   ja     0x55555568ab12 <_GLOBAL__sub_I_RecyclerHeuristic.cpp+130>
   0x000055555568aaf7 <+103>:   mov    0x25eb97d(%rip),%cl        # 0x555557c7647a <_ZN14AutoSystemInfo4DataE+634>
   0x000055555568aafd <+109>:   test   %cl,%cl
   0x000055555568aaff <+111>:   je     0x55555568ab12 <_GLOBAL__sub_I_RecyclerHeuristic.cpp+130>
   0x000055555568ab01 <+113>:   mov    $0x20,%edx
   0x000055555568ab06 <+118>:   mov    $0x1000,%ecx
   0x000055555568ab0b <+123>:   mov    $0x10,%eax
   0x000055555568ab10 <+128>:   jmp    0x55555568ab3a <_GLOBAL__sub_I_RecyclerHeuristic.cpp+170>
   0x000055555568ab12 <+130>:   cmp    $0x40000001,%rax
   0x000055555568ab18 <+136>:   mov    $0x40,%esi
   0x000055555568ab1d <+141>:   mov    $0xc0,%eax
   0x000055555568ab22 <+146>:   cmovb  %esi,%eax
   0x000055555568ab25 <+149>:   mov    $0x4000,%edx
   0x000055555568ab2a <+154>:   mov    $0x20000,%ecx
   0x000055555568ab2f <+159>:   cmovb  %edx,%ecx
   0x000055555568ab32 <+162>:   mov    $0x100,%edx
   0x000055555568ab37 <+167>:   cmovb  %esi,%edx
   0x000055555568ab3a <+170>:   mov    %ecx,0x25f4f60(%rip)        # 0x555557c7faa0 <_ZN6Memory17RecyclerHeuristic8InstanceE.7>
   0x000055555568ab40 <+176>:   mov    %edx,0x25f4f52(%rip)        # 0x555557c7fa98 <_ZN6Memory17RecyclerHeuristic8InstanceE.6>
   0x000055555568ab46 <+182>:   mov    %eax,%ecx
   0x000055555568ab48 <+184>:   shl    $0x14,%ecx
   0x000055555568ab4b <+187>:   mov    %ecx,0x25f4f1f(%rip)        # 0x555557c7fa70 <_ZN6Memory17RecyclerHeuristic8InstanceE.0>
---Type <return> to continue, or q <return> to quit---q
Quit

The crash above is on the pinsrq instruction, which is a SSE 4.1 instruction according to https://en.wikipedia.org/wiki/SSE4
Similarly my binary also crashes, but with my binary you actually need to run some js code first (I think it is because the version of ch I have built will dlopen libChakraCore.so, and so will not crash until after it has opened libChakraCore.so ):
ljw@ubuntu:~/src/build-ch-artif/centos6-root/root/release$ ls
a.js  ch  libChakraCore.so
ljw@ubuntu:~/src/build-ch-artif/centos6-root/root/release$ ./ch

Usage: ch [-v|-version] [-h|-help|-?] <source file>
Note: [flaglist] is not supported in Release builds; try a Debug or Test build to enable these flags.
        -v|-version             Displays version info
        -h|-help|-?             Displays this help message
ljw@ubuntu:~/src/build-ch-artif/centos6-root/root/release$ ./ch a.js
hello world
Illegal instruction
ljw@ubuntu:~/src/build-ch-artif/centos6-root/root/release$ gdb ./ch
GNU gdb (Ubuntu 7.7.1-0ubuntu5~14.04.3) 7.7.1
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ./ch...(no debugging symbols found)...done.
(gdb) run a.js
Starting program: /home/ljw/src/build-ch-artif/centos6-root/root/release/ch a.js
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7ffff6bc6700 (LWP 1296)]
[New Thread 0x7ffff55f2700 (LWP 1297)]
[New Thread 0x7ff7effff700 (LWP 1298)]
[New Thread 0x7ff7ef7fe700 (LWP 1299)]
hello world

Program received signal SIGILL, Illegal instruction.
0x00007ffff59a7904 in Memory::Recycler::AbortConcurrent(bool) ()
   from /home/ljw/src/build-ch-artif/centos6-root/root/release/libChakraCore.so
(gdb) bt
#0  0x00007ffff59a7904 in Memory::Recycler::AbortConcurrent(bool) ()
   from /home/ljw/src/build-ch-artif/centos6-root/root/release/libChakraCore.so
#1  0x00007ffff59a7a6a in Memory::Recycler::FinalizeConcurrent(bool) ()
   from /home/ljw/src/build-ch-artif/centos6-root/root/release/libChakraCore.so
#2  0x00007ffff5798371 in JsDisposeRuntime () from /home/ljw/src/build-ch-artif/centos6-root/root/release/libChakraCore.so
#3  0x000055555555c216 in ExecuteTest(char const*) ()
#4  0x000055555555c835 in main ()
(gdb) disassemble
Dump of assembler code for function _ZN6Memory8Recycler15AbortConcurrentEb:
   0x00007ffff59a78e0 <+0>:     push   %rbp
   0x00007ffff59a78e1 <+1>:     mov    %rsp,%rbp
   0x00007ffff59a78e4 <+4>:     push   %r15
   0x00007ffff59a78e6 <+6>:     push   %r14
   0x00007ffff59a78e8 <+8>:     push   %r12
   0x00007ffff59a78ea <+10>:    push   %rbx
   0x00007ffff59a78eb <+11>:    sub    $0x10,%rsp
   0x00007ffff59a78ef <+15>:    mov    %esi,%r15d
   0x00007ffff59a78f2 <+18>:    mov    %rdi,%r12
   0x00007ffff59a78f5 <+21>:    movdqu 0xb40(%r12),%xmm0
   0x00007ffff59a78ff <+31>:    movdqa %xmm0,-0x30(%rbp)
=> 0x00007ffff59a7904 <+36>:    pextrq $0x1,%xmm0,%rdi
   0x00007ffff59a790b <+43>:    cmp    $0x1,%rdi
   0x00007ffff59a790f <+47>:    mov    $0x1,%ebx
   0x00007ffff59a7914 <+52>:    sbb    $0xffffffff,%ebx
   0x00007ffff59a7917 <+55>:    mov    $0x1,%r14b
   0x00007ffff59a791a <+58>:    testb  $0x20,0x3e9(%r12)
   0x00007ffff59a7923 <+67>:    je     0x7ffff59a7a38 <_ZN6Memory8Recycler15AbortConcurrentEb+344>
   0x00007ffff59a7929 <+73>:    movb   $0x1,0xbc4(%r12)
   0x00007ffff59a7932 <+82>:    test   %rdi,%rdi
   0x00007ffff59a7935 <+85>:    je     0x7ffff59a793e <_ZN6Memory8Recycler15AbortConcurrentEb+94>
   0x00007ffff59a7937 <+87>:    xor    %esi,%esi
   0x00007ffff59a7939 <+89>:    callq  0x7ffff578f170 <SetThreadPriority>
   0x00007ffff59a793e <+94>:    lea    -0x30(%rbp),%rsi
   0x00007ffff59a7942 <+98>:    xor    %edx,%edx
   0x00007ffff59a7944 <+100>:   mov    $0xffffffff,%ecx
   0x00007ffff59a7949 <+105>:   xor    %r8d,%r8d
   0x00007ffff59a794c <+108>:   mov    %ebx,%edi
   0x00007ffff59a794e <+110>:   callq  0x7ffff5789ac0 <WaitForMultipleObjectsEx>
   0x00007ffff59a7953 <+115>:   mov    %eax,%ebx
   0x00007ffff59a7955 <+117>:   movb   $0x0,0xbc4(%r12)
   0x00007ffff59a795e <+126>:   test   %ebx,%ebx
   0x00007ffff59a7960 <+128>:   jne    0x7ffff59a798f <_ZN6Memory8Recycler15AbortConcurrentEb+175>
   0x00007ffff59a7962 <+130>:   xor    $0x1,%r15b
   0x00007ffff59a7966 <+134>:   jne    0x7ffff59a798f <_ZN6Memory8Recycler15AbortConcurrentEb+175>
   0x00007ffff59a7968 <+136>:   mov    0x3e8(%r12),%eax
   0x00007ffff59a7970 <+144>:   cmp    $0xa002,%eax
   0x00007ffff59a7975 <+149>:   je     0x7ffff59a79b1 <_ZN6Memory8Recycler15AbortConcurrentEb+209>
   0x00007ffff59a7977 <+151>:   cmp    $0xa001,%eax
   0x00007ffff59a797c <+156>:   jne    0x7ffff59a7a38 <_ZN6Memory8Recycler15AbortConcurrentEb+344>
   0x00007ffff59a7982 <+162>:   mov    %r12,%rdi
   0x00007ffff59a7985 <+165>:   callq  0x7ffff59a40e0 <_ZN6Memory8Recycler24ResetMarkCollectionStateEv>
   0x00007ffff59a798a <+170>:   jmpq   0x7ffff59a7a38 <_ZN6Memory8Recycler15AbortConcurrentEb+344>
   0x00007ffff59a798f <+175>:   mov    %r12,%rdi
   0x00007ffff59a7992 <+178>:   callq  0x7ffff59a3eb0 <_ZN6Memory8Recycler20CleanupPendingUnrootEv>
   0x00007ffff59a7997 <+183>:   add    $0x480,%r12
---Type <return> to continue, or q <return> to quit---q

The a.js sample program just runs print("Hello world"); . Again this is crashing on a SSE 4.1 instruction (pextrq in this case). I assume the cuprit is this: https://github.com/Microsoft/ChakraCore/blob/v1.7.0/CMakeLists.txt#L156

Were you creating this binary on Core 2 Duo system ?

I assume the cuprit is this: https://github.com/Microsoft/ChakraCore/blob/v1.7.0/CMakeLists.txt#L156

We could add a feature detection for given instruction yet if you were compiling on another machine with support to SSE 4.1, the result wouldn't be different. Optionally, we may add a build time argument for target arch compatibility level.
i.e --custom-cpu-argument:<argument(s) here> to build.sh. Would you like to send a PR?

Were you creating this binary on Core 2 Duo system ?

Yep, though the resultant binary works fine on machines with SSE 4.1 and 4.2 support, it will not work on the Core 2 Duo machine. This makes sense as it appears that the CMakeLists.txt is instructing clang to generate SSE 4.2 code.

i.e --custom-cpu-argument:<argument(s) here> to build.sh. Would you like to send a PR?

I'll try and build a SSE2 copy of ChakraCore next week and let you know how I get on. If possible I will try and create a PR.

@cosinusoidally any update on this?

@obastemur proof of concept for the 1.7.x series is here https://github.com/cosinusoidally/ChakraCore-experiments/tree/master/build-chakracore . In that version I disable the -msse4.2 flag and remove any SSE > 2 intrinsics, I think the general solution is to remove the -msse4.2 flag and then write inline assembler versions of any required intrinsics. I've got a couple of spare hours today so I'll give that a go on master.

@obastemur See commit https://github.com/cosinusoidally/ChakraCore/commit/055784bf31b4be441170c9921a87d6bb99c88457 .  I think the inline assembler will need some review by someone more knowledgeable than me. It seems to work and passes the test suite on a SSE4.2 based system and my old SSE2 only based system (but I am not 100% confident that my asm constraints are correct). I created inline assembly versions of all the required intrinsics (called simd_*). The reason to use inline asm rather than __attribute__ target is that only the inline assembler versions of the functions will get inlined (__attribute__ target versions of the functions are also included, but commented out).
There is also the question as to where the implemented intrisics should go. In my patch I simply put them in the files where they are required. In theory they should be inline functions insider a header somewhere. I'm not sure where the best place would be.


testdata: sandbox ns options should be under security_context

And not directly under linux.
Fixes #243
Signed-off-by: Samuel Ortiz<EMAIL_ADDRESS>

lgtm waiting tests to merge