Change repo name?

Should we change the name of the repo to align with the primary resource names (gateway-apis?)

Could we not pluralize it though? When it's plural everybody tends to call it something different (service api vs service apis). It would be a bit more concrete if it was just gateway-api.

Could we not pluralize it though? When it's plural everybody tends to call it something different (service api vs service apis). It would be a bit more concrete if it was just gateway-api.

I am so much in favour of gateway-api then :)

I am so much in favour of gateway-api then :)

@bowei Before we get into renaming, I think we should understand why the current name was chosen in the first place. What was the motivation and goal then?

@bowei Before we get into renaming, I think we should understand why the current name was chosen in the first place. What was the motivation and goal then?

I chose the name because it has to do with an API that was an iteration on Kubernetes services.
At that point in time, we didn't really have any of the resource names, so I didn't really want to make up a name.

I chose the name because it has to do with an API that was an iteration on Kubernetes services.
At that point in time, we didn't really have any of the resource names, so I didn't really want to make up a name.

Although the plural APIs name feels more accurate, I think the singular Gateway API name would likely be easier to work with. Name changes are always painful, but I think the transition from Service to Gateway probably makes sense here. Certainly will be easier to change the project name now than at any point in the future. With that said I'm sure it will be a non-trivial amount of work.

Although the plural APIs name feels more accurate, I think the singular Gateway API name would likely be easier to work with. Name changes are always painful, but I think the transition from Service to Gateway probably makes sense here. Certainly will be easier to change the project name now than at any point in the future. With that said I'm sure it will be a non-trivial amount of work.

/cc @danehans @jpeach

/cc @danehans @jpeach

Of course this would be a terrible change if we weren't 100% sold on the Gateway name. I think our votes on resource naming in the fall were pretty conclusive though.

Of course this would be a terrible change if we weren't 100% sold on the Gateway name. I think our votes on resource naming in the fall were pretty conclusive though.

@bowei what is the impetus for the name change? Renaming to Gateway API implies a single API. I'm in favor of keeping the name unless the current name does not follow a standardized k8s repo naming schema.

@bowei what is the impetus for the name change? Renaming to Gateway API implies a single API. I'm in favor of keeping the name unless the current name does not follow a standardized k8s repo naming schema.

@bowei will send an email to the sig-network mailer to obtain feedback on the rename. This issue will be readdressed during the 2/3 service apis community meeting.

@bowei will send an email to the sig-network mailer to obtain feedback on the rename. This issue will be readdressed during the 2/3 service apis community meeting.

Thread in sig-network mailing list: https://groups.google.com/g/kubernetes-sig-network/c/5Rkg_juNDGc. Also added to agenda for sig-network meeting on Feb 4.

Thread in sig-network mailing list: https://groups.google.com/g/kubernetes-sig-network/c/5Rkg_juNDGc. Also added to agenda for sig-network meeting on Feb 4.

/assign @robscott


Make sure all EN-Erros link to the FAQ page correctly

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is not already reported in another issue

Technical details

Device name: -
iOS Version: 14.4
App Version: 1.12.1

Describe the bug
I have some indication that ENError-Pop ups do not correctly link to the General_moreInfo_URL defined in https://github.com/corona-warn-app/cwa-app-ios/blob/11e3e101ba3e52f3ad8321ce5d3ded642960f4ca/src/xcode/ENA/ENA/Resources/Localization/en.lproj/Localizable.links.strings#L13
Instead, if the user clicks "Mehr Erfahren", nothing happens but the pop-up closes. I can't confirm this myself, since it is not easy to reproduce such errors.
I think that this does not affect, the separately defined, ENErrors 5, 11 and 13.
Steps to reproduce the issue

Get a ENError (but 5, 11 and 13)
Click on "Mehr Erfahren"
Pop-Up closes
Nothing happens

Expected behaviour
The FAQ website should be opened.

Related Issue

#1353

Internal Tracking ID: EXPOSUREAPP-5223

@Ein-Tim did you actually see this popup? If yes: do you know if the corresponding risk check was triggered from background or foreground?

@ndegendogo
I don't experience this issue, I just talked with somebody on Twitter who encountered ENError 14.
But I also noticed
back in #1353 that I think that it is (still) not working.

Thanks @Ein-Tim.
I cannot promise for sure, but if I find time I am going to play with this scenario in my simulator ...

@ndegendogo @Ein-Tim
Do you have any idea how to trigger one of the ENErrors?

@dsarkar ENError 14 is triggered if a MDM is preventing CWA to use the ENF/the ENF is deactivated by a MDM.
But it's all a bit tricky because some ENErorrs are also hidden from the user, others aren't but the most common (13, 11 and 5) seem to work correctly (but not sure about that).

@Ein-Tim  Ok. ENError13 ( API was called too often ), I think one could trigger it: At the end of the day, after 4-6 checks, reset app several times (or re-install). So we could check at least that one.

@dsarkar Yes, I triggered this yesterday and it seemed to work. It's only about the Erros which don't have a own FAQ entry. This should best be tried out by the devs.

@Ein-Tim ok

@dsarkar I plan to use the simulator / community build, then cherry-pick my recent PR for #1918, and do a local modification so that the mock returns error 14
😎😎

I can reproduce it with 1.12.1.
ENError 13 forwards to the FAQ, ENError 14 shows no action on "more info".
Root cause is here. Three specific error codes are extended with an URL to the FAQ, but the default gets no URL.
I guess it should use one of the other URLs here, else the list of URLs to be extended.
@dsarkar

@ndegendogo @Ein-Tim Thanks for reporting and analyzing!
Internal Tracking ID: EXPOSUREAPP-5223

@dsarkar please ask the devs what is the fastest way to get this fix in.
If they have time to work on it I guess this would be fastest.
Else I could volunteer for a PR; but of course I don't want to spend duplicate effort.

@ndegendogo  They are working already on it as far as I can see in the ticket. However, I will forward your generous offer and suggest the developer contacting you here on this issue if this is applicable and/or practical for the devs.

@ndegendogo @Ein-Tim FYI PR https://github.com/corona-warn-app/cwa-app-ios/pull/2024/files

@dsarkar Thanks!
@ndegendogo I will leave this issue open until Version 1.13 is released, maybe you would like to test this via the emulator again then? Thank you so much for you help here! 👍

Wow - this is fast 🚀 amazing 😀
@dsarkar Please tell the devs!
But then ... I have another question - not sure if I should open a new ticket or can just append here?
Actually, in the same file there is another, very similar extension ExposureSubmissionError and I am wondering if that should be also extended with a default URL.
However, so far I have not analysed its usage (from the name it could be related to submission of DEK keys)
@dsarkar could you please give the developers the hint to double-check that?
(sorry - I should have mentioned it in the first place ... but it was already a bit late yesterday ...)

@ndegendogo
From the perspective of the FAQ it's not necessary to make an FAQ entry for every error type. In general, these errors should be caught and handled internally (e.g. try again in case of submission). Most of them are not meant to be shown to the user. And if they are, the app should show it's own user-friendly error message.
If the error is still shown to a lot of users, we will make an FAQ entry of course. However, chances are we are mirroring the Apple FAQ's if we do this preemptively for every error.

Corona-Warn-App Open Source Team

@heinezen no problem. I have meanwhile analysed the source myself, and as far as I see all is fine.
ExposureSubmissionCoordinator.showErrorAlert adds the 'More Info' button only if the error has an URL, so the user gets the popup with just one button in the 'default' case, which is fine.
This is different with AppDelegate.makeAlertController, which always adds a second button.
(And a button which promises 'More info' but does not fulfill this promise is at least surprising.)

@ndegendogo regarding your comment https://github.com/corona-warn-app/cwa-app-ios/issues/1998#issuecomment-781633712, I forwarded both, your question and your amazement to the developer.

@heinezen no problem. I have meanwhile analysed the source myself, and as far as I see all is fine.
ExposureSubmissionCoordinator.showErrorAlert adds the 'More Info' button only if the error has an URL, so the user gets the popup with just one button in the 'default' case, which is fine.
This is different with AppDelegate.makeAlertController, which always adds a second button.
(And a button which promises 'More info' but does not fulfill this promise is at least surprising.)

@ndegendogo This is the correct answer to your question about the ExposureSubmissionError.

Version 1.13 which fixed this has been released to GitHub and will be available to all users in the next 48h.
See blog post:
DE: https://www.coronawarn.app/de/blog/2021-03-04-corona-warn-app-version-1-13/
EN: https://www.coronawarn.app/en/blog/2021-03-04-corona-warn-app-version-1-13/
See GitHub release:
iOS: https://github.com/corona-warn-app/cwa-app-ios/releases/tag/v1.13.0
Android: https://github.com/corona-warn-app/cwa-app-android/releases/tag/v1.13.2
This issue will now be closed.

@Ein-Tim  Thanks!


ci: run one test at a time

Until the driver test runner safely supports concurrent specs, we should run one spec at a time.

Superseded by https://github.com/PlaceOS/driver/pull/108


Fix Introspect Call

This PR updates the introspect call to use a POST request instead of GET

Coverage remained the same at 100.0% when pulling b0d282a855717f78b052e728b009348d18891be2 on fix/introspect into 89c5297af5373eebf3b9b161c6eb175295f16000 on master.


VisualStudio CloudFormation template editor shows key is invalid for this object

Description
Visual Studio v<IP_ADDRESS> for Cloudformation is throwing 'xxx key is invalid for this object" for "HttpParameters" and "QueryStringParameters" when trying to create EventBridge/Event Rules resource. Here's a screenshot:

Reproduction Steps
These are valid properties according to documentation for EventBridge/Event Rules (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/AWS_Events.html). Similar issues for other scenarios:

https://github.com/aws/aws-sdk-net/issues/663
https://github.com/aws/aws-sdk-net/issues/133

Visual Studio Version: 2017/2019
AWS Toolkit for Visual Studio Version: v<IP_ADDRESS>

Hi @etoh91,
Good afternoon.
Could you please attach the complete template to this ticket? Looking at high level, it appears to be issue.
Thanks,
Ashish

This is just for this resource that's part of a bigger template. Thanks.
eventbridge.json.zip

Hi @etoh91,
Good afternoon.
Could you please attach the complete template to this ticket? Looking at high level, it appears to be issue.
Thanks,
Ashish

This is just for this resource that's part of a bigger template. Thanks.
eventbridge.json.zip

@ashishdhingra checking on update. Thanks!

@ashishdhingra checking on update. Thanks!

Hi @etoh91,
Good morning.
I will discuss with the developer and get this prioritized.
Thanks,
Ashish

Assigned to @normj.

A new version of the CloudFormation schema has been released which fixes this issue. You should automatically see the change after restarting Visual Studio.


Tessera "storeraw" endpoint is not available --> can't perform private transactions

Hi guys,
I'm using QuorumMaker to run a Quorum network with two nodes and Tessera. The command i used: "./setup.sh dev --tessera --project  --nodecount 2"
Also, i'm using web3j's contract wrappers to perform a very simple private transaction, but it keeps failing with a "404 not found" response whenever QuorumTransactionManager attempts calling Tessera's "storeraw" endpoint.
However, when i use a different approach: "Quorum.ethSendTransaction( privateTransaction)" it does work. But this approach is very verbose and requires nonce management.
I think the second approach works because it doesn't go through Tessera's "storeraw" endpoint.
Somehow QuorumMaker runs Tessera with "storeraw" endpoint disabled, in comparison, Quorum's 7nodes example does have this endpoint available in Tessera, thus private transactions are available through TransactionManager.
How can i make QuorumMaker run Tessera with above endpoint enabled?

Can you please try setting up a development network using the following command
./setup.sh dev --project Test --nodecount 2 --tessera
and then try performing private transactions by deploying private contract of quorum's 7 node example. Don't forget to replace the public key in privateFor field in private-contract.js file using your public key before deploying it.

The issue seems to be caused by the a wrong generation of "tessera-config.json" which leads to some Tessera APIs being disabled. I replaced "tessera-config.json" by the following and it worked:
{
"type" : "config",
"useWhiteList" : false,
"disablePeerDiscovery" : false,
"jdbc" : {
"url" : "jdbc:h2:file:/node1/node/qdata/node1;AUTO_SERVER=TRUE",
"autoCreateTables" : true
},
"serverConfigs" : [ {
"app" : "P2P",
"enabled" : true,
"communicationType" : "REST",
"sslConfig" : {
"tls" : "OFF",
"generateKeyStoreIfNotExisted" : false,
"serverTrustCertificates" : [ ],
"serverTrustMode" : "TOFU",
"clientTrustCertificates" : [ ],
"clientTrustMode" : "TOFU"
},
"serverSocket" : {
"type" : "INET",
"port" : 22002,
"hostName" : "http://<IP_ADDRESS>"
}
}, {
"app" : "Q2T",
"enabled" : true,
"communicationType" : "UNIX_SOCKET",
"serverSocket" : {
"type" : "UNIX",
"path" : "/node1/node/qdata/node1.ipc"
}
}, {
"app" : "ThirdParty",
"enabled" : true,
"communicationType" : "REST",
"sslConfig" : {
"tls" : "OFF",
"generateKeyStoreIfNotExisted" : false,
"serverTrustCertificates" : [ ],
"serverTrustMode" : "TOFU",
"clientTrustCertificates" : [ ],
"clientTrustMode" : "TOFU"
},
"serverSocket" : {
"type" : "INET",
"port" : 22007,
"hostName" : "http://<IP_ADDRESS>"
}
} ],
"peer" : [ {
"url" : "http://<IP_ADDRESS>:22002/"
} ],
"keys" : {
"keyData" : [ {
"privateKeyPath" : "/node1/node/keys/node1.key",
"publicKeyPath" : "/node1/node/keys/node1.pub"
} ]
},
"alwaysSendTo" : [ ]
}

hi，masarwib， i use your method ,it doesn't work. wether something left?


add rick and morty example

this is a very similar example to the star wars app, since the star wars api
is going to be deprecated and is currently down swapi, my proposal is to use
this rick and morty example to replace the star wars example that is not
working right now.

Awesome! Can you update the Readme with a link to it too?

sure! I'm on it


Unable to switch from JS to TS in ionic 2

I changed the file extensions of my app files including app/app.js
Error: Cannot find module 'app/app.js' from 'app_folder'
It doesn't tell me which file I should be looking at to fix the error.
I tried looking with git grep and read a bit about Angular2's entry points to find out where it is loaded, but no luck yet.

Hello! Thanks for opening an issue with us. Since this is more of a question and not really an issue with the framework i am going to point you towards our forums (https://forum.ionicframework.com/) they will be able to help you over there. Thanks again!

@epetre If it's a new app, I would recommend you to start it over with the --ts flag.
In case that you want to convert an existing app from JS to TS, then you should also make some updates to the project and the build process. I will recommend you to create a new TypeScript project and perform merge of the relevant files between the two projects. You can do this by executing:
ionic start BlankTS blank --v2 --ts --skip-npm

As a minimum you'll have to replace ionic-gulp-browserify-es2015 with ionic-gulp-browserify-typescript in both package.json and gulpfile.js and create tsconfig.json and typings.json files using the ones from the following repository as a reference.

ok, thank you I managed to find what I was looking for by digging in the code and doing some tiral and error.
Here is how to do it in case Im not alone :)
http://stackoverflow.com/questions/36847051/unable-to-switch-from-js-to-ts-in-ionic-2/36851567#36851567


Add a link to the RidGraph tool

The RidGraph tool generates visualizable .NET runtime identifier graphs in SVG

Hi @0xced
I like this change. I am waiting to approve and merge it because the RidTool doesn't have a license.md in the repo. Once that's added, it enables any reader to know if they can use the tool in accordance with the license.
Thanks.

The license (MIT) has been added. Thanks for your interest in this pull request. 😃

closing and reopening for a fresh CI build.

trying to close and reopen one more time.


Add unit test for skipping(Handle file skipping internally #143)

#143

@AndrewSouthpaw PR this test?🧐
#143 has been already accepted.

Oops thanks, missed this 😅

Next time, I think it'd be better to roll them into the same PR.

Next time, I think it'd be better to roll them into the same PR.

That would great.

Oh! Sorry I didn't notice you weren't the same person. My bad!
Seems like it's all squared away now.

nm🤪


Create a Nextflow module for Nucmer

Description of feature

[ ] Install module from nf-core
[ ] Test module

Imported from nf-core and tested locally

Reopening this, as we want to output the alignment in SAM format to produce standardized outputs from each variant caller. Nucmer can produce SAM outputs by supplying the --sam-long flag
For more details see here


distutils bdist_wininst command has been removed in Python 3.10

Commit: https://github.com/python/cpython/commit/0e2a0f72cc9af0899eacb5604e44a563c0b06110
Discussion: https://discuss.python.org/t/remove-bdist-wininst-command/6434

I ran the setuptools test suite on a Python without bdist_wininst. I had to remove setuptools/command/bdist_wininst.py file to be able to run tests. Result: 1 failed, 665 passed, 17 skipped, 5 xfailed, 1 xpassed, 3 errors.
Errors and warnings:

test_distutils_stdlib
test_distutils_local_with_setuptools
test_distutils_local
test_bdist_wininst_warning

I understand that almost everything works in setuptools, unless a few specific tests which expect bdist_wininst command to exist. It sounds doable to fix 4 tests.
I'm the author of the commit which removed the command.

Thanks Victor. I'll experiment. Thanks for the report.

Thanks Victor. I'll experiment. Thanks for the report.

No activity since 2021, I close the issue.

Sorry to have left this lingering. If it's still of interest, we can re-open.


Constant problems with the mod

2023-08-29-2.log.gz
(i had to upload the zip because the log was too heavy it seems)
some times when opening the game it says it cant find the config file or something (i lost that log im sorry, but happened a couple times) then every time with this mod installed it spams in the logs "Your identifier minimalist_questapi is incorrect or you have no screen registered"
this mod also causes massive lag in my game for some reason, im no programer so ill leave this here so you can check it, sorry for the trouble
(its the lastest version of the mod in the lastest forge 1.20.1)

Hello Aabaddon! This bug is a known bug, but fixed in latest version, so I would need more information about this.
Also want to know how this lag is being caused.
To a proper conversation, I recommend you to join QuestAPI's discord so I can ask you for more files 😊

sure thing, thanks dude!


Create binaries for OSX

If somebody could create binaries for OSX, that would be much appreciated. Let me know in this issue or via email<EMAIL_ADDRESS>where I can download the binaries from, and I will put them where others can easily find them, e.g., here:
https://github.com/LambdaHack/LambdaHack/releases
https://github.com/AllureOfTheStars/Allure/releases
For some time now one can create OSX binaries via travis, but I can't test them to determine, e.g., how many libraries to include with the binary vs what the OSX user should install on his own, so that doesn't solve the issue.
Edited: removed mentions of GTK, etc.

Here is a hint how to do that remotely on travis: https://github.com/haskell/ThreadScope/blob/master/.travis.yml
Still, access to a OSX machine, for debugging, would probably make it much less painful.

See https://github.com/AllureOfTheStars/Allure/issues/79

Would a simple cabal install suffice for this?

Just noticed there is build-binary-common on the makefile, should I use that?

Actually, if there is a common package format or installer for OS X, then the make build-binary you mention may come useful. Here is how I use it to create a Windows binary archive (and also an installer, later on):
https://github.com/LambdaHack/LambdaHack/blob/master/appveyor.yml#L17
I copy by hand the SDL2 and other needed libraries. If there is a tool for OS X that automatically copies the needed libraries, that would be even better.

@PabloReszczynski: Both LambdaHack and Allure releases v<IP_ADDRESS> are now ready. Could we try to create OS X packages (or archives) before the release is published, in case we need to tweak anything in the repo (or in case we can add some script to Makefile to automate the task)?

@PabloReszczynski: Well done with the binary archives! Please, try renaming the binaries to Allure_<IP_ADDRESS>_darwin-10.12.6-amd64.tar.gz, etc., or whatever exactly your OS/arch identification is, and uploading them, for now, to
https://github.com/AllureOfTheStars/Allure/releases/tag/v<IP_ADDRESS>
and, respectively,
https://github.com/LambdaHack/LambdaHack/releases/tag/v<IP_ADDRESS>
because the <IP_ADDRESS> version is well advertised, but it lacks OS X binaries (and there are almost no user-visible changes in v<IP_ADDRESS>). If you can't upload, let me know and I will try to fix the github setup.
Could you also unpack your archives, enter their directories and try running
./Allure --dbgMsgSer --logPriority 4 --newGame 3 --noAnim --maxFps 100000 --benchmark --stopAfterFrames 2000 --automateAll --keepAutomated --gameMode battle --setDungeonRng 7 --setMainRng 7

and similarly for Lambdaahck? What are your outputs for each archive? That's a quick test that also lets us compare if it works the same on all architectures, if the optimization level is right, etc.
If it's not too much to ask, could you then issue pull requests for the Makefile on both repos that adds a target build-darwin-binary (and renames build-binary to build-ubuntu-binary)? Just copy-paste with the required changes. Remember about tabs instead of spaces, because Makefile is fussy about it. Let me know if I can assist you.
When it's all shaken up, I will skip v<IP_ADDRESS> and release v<IP_ADDRESS> to Hackage to mark the breakthrough (and I would include a couple of extra tweaks) and upload our new binaries to some other sites and then advertise it. I wonder if there are some special pages where game-starved OS X people come to download free games? We could upload it there as well. Or is it all iTunes these days?

Or perhaps make it Allure_<IP_ADDRESS>_osx-10.12.6-amd64.tar.gz? I have no idea if ordinary players are aware that they own a Darwin. Or OSX? Or MacOsX? What is most understandable?

Test output for Allure:
./Allure --dbgMsgSer --logPriority 4 --newGame 3 --noAnim --maxFps 100000 --benchmark --stopAfterFrames 2000 --automateAll --keepAutomated --gameMode battle --setDungeonRng 7 --setMainRng 7
  1.     82 Spacefarers perished on level 5, killed 41, lost 4,
            difficulty 3, after 335 turns on 2018-06-23 17:46:25.
Game time: 5.358882s; frames: 1223. Average clips per second:<PHONE_NUMBER>425982. Average FPS:<PHONE_NUMBER>3788394.
Session time: 8.592441s; frames: 2001. Average clips per second:<PHONE_NUMBER>807431. Average FPS:<PHONE_NUMBER>094445.

Test output for LambdaHack
./LambdaHack --dbgMsgSer --logPriority 4 --newGame 3 --noAnim --maxFps 100000 --benchmark --stopAfterFrames 2000 --automateAll --keepAutomated --gameMode battle --setDungeonRng 7 --setMainRng 7
  1.   1315 Explorers slew all opposition, killed 69, lost 2,
            difficulty 3, after 428 turns on 2018-06-23 17:49:07.
Game time: 5.011076s; frames: 1558. Average clips per second:<PHONE_NUMBER>279272. Average FPS:<PHONE_NUMBER>561223.
Session time: 6.243039s; frames: 2002. Average clips per second:<PHONE_NUMBER>688191. Average FPS:<PHONE_NUMBER>9081564.

As for most understandable name I think macosx is best.
And about where do we get our games, normally I use Homebrew, so making it available there would be a plus.

Our numbers match, so the OS doesn't affect, e.g., randomness, and threads are handled in a deterministic enough fashion that differences in scheduling don't manifest. Perfect. That also means debugging, given a game seed is possible across OSes. Also, your machine has a nice single core performance. :) I'm fine with you uploading these binaries to the v<IP_ADDRESS> release. Let me know if it fails.
Ubuntu output for Allure
dist/build/Allure/Allure --dbgMsgSer --logPriority 4 --newGame 3 --noAnim --maxFps 100000 --benchmark --stopAfterFrames 2000 --automateAll --keepAutomated --gameMode battle --setDungeonRng 7 --setMainRng 7
  1.     82 Spacefarers perished on level 5, killed 41, lost 4,
            difficulty 3, after 335 turns on 2018-06-24 00:06:18.
Game time: 9.876390476s; frames: 1223. Average clips per second:<PHONE_NUMBER>827131. Average FPS:<PHONE_NUMBER>5517123.
Session time: 17.340515039s; frames: 2001. Average clips per second:<PHONE_NUMBER>336543. Average FPS:<PHONE_NUMBER>8604243.

Ubuntu output for LambdaHack
dist/build/LambdaHack/LambdaHack --dbgMsgSer --logPriority 4 --newGame 3 --noAnim --maxFps 100000 --benchmark --stopAfterFrames 2000 --automateAll --keepAutomated --gameMode battle --setDungeonRng 7 --setMainRng 7
  1.   1315 Explorers slew all opposition, killed 69, lost 2,
            difficulty 3, after 428 turns on 2018-06-23 23:58:33.
Game time: 8.953732856s; frames: 1558. Average clips per second:<PHONE_NUMBER>7354733. Average FPS:<PHONE_NUMBER>1333648.
Session time: 11.402314499s; frames: 2002. Average clips per second:<PHONE_NUMBER>5532947. Average FPS:<PHONE_NUMBER>6985885.

@PabloReszczynski: I've commented directly on your PR. Looks good, thank you.
Re Homebrew, sounds reasonable. Would you create an issue about making the package/formula/whatever? On LambdaHack or on Allure issue tracker, whichever is handy for you. And if you'd like, at any point, to tackle it, you have my utmost trust. :)

I succumbed to "just one more commit", so <IP_ADDRESS> is cut right now. Let me tag it to prevent further drift.

I succumbed one last time and did the shameful thing and moved the tag. Won't happen again (probably).

MacOS output for Allure <IP_ADDRESS>
./Allure --dbgMsgSer --logPriority 4 --newGame 3 --noAnim --maxFps 100000 --benchmark --stopAfterFrames 2000 --automateAll --keepAutomated --gameMode battle --setDungeonRng 7 --setMainRng 7
  1.   1302 Spacefarers slew all opposition, killed 83, lost 3,
            difficulty 3, after 823 turns on 2018-06-29 08:58:27.
Game time: 8.493132s; frames: 1891. Average clips per second:<PHONE_NUMBER>053318. Average FPS:<PHONE_NUMBER>3107764.
Session time: 9.31504s; frames: 2000. Average clips per second:<PHONE_NUMBER>102905. Average FPS:<PHONE_NUMBER>023549.

MacOS output for LambdaHack
./LambdaHack --dbgMsgSer --logPriority 4 --newGame 3 --noAnim --maxFps 100000 --benchmark --stopAfterFrames 2000 --automateAll --keepAutomated --gameMode battle --setDungeonRng 7 --setMainRng 7
  1.   1325 Explorers slew all opposition, killed 65, lost 0,
            difficulty 3, after 393 turns on 2018-06-29 09:00:37.
Game time: 3.565023s; frames: 799. Average clips per second: 1100.133154821161. Average FPS:<PHONE_NUMBER>1165416.
  1.   1330 Explorers slew all opposition, killed 67, lost 0,
            difficulty 3, after 166 turns on 2018-06-29 09:00:39.
Game time: 1.629762s; frames: 921. Average clips per second: 1018.5536293029289. Average FPS:<PHONE_NUMBER>060226.
Session time: 5.7648s; frames: 2002. Average clips per second: 1039.9320011101859. Average FPS:<PHONE_NUMBER>0743825.

Thank you very much. Well done. We have the same outputs. I moved the tag for the last time and now it matches your binaries and I will cut mine from the same tag (which is very fortunate, I wanted these last moment changes in and now they are in).

v<IP_ADDRESS> is released! With Mac OS X binaries! Score!

@PabloReszczynski: release v0.9 is imminent. Would you like to create OSX binaries using the current state of master branch of LambdaHack and of Allure? GHC 8.6.4 would be best and the invocation is the on you prepaired, namely 'make build-binary-macosx`. Cheers!

I'm now offloading creating the OSX binaries to Homebrew. Get them via brew install allureofthestars.
@PabloReszczynski: thank you for your help and for initiating the homebrew effort.
Closing.


SDT Frontend Implementation

Image is borderless on one of the sides, we could adjust it

@Apurv428 Can you provide some precise instructions on how reviewers can test this change, including the dependencies? This will later be worked into the documentation.

To test the PR, please run the following commands:

git clone https://github.com/Apurv428/software-discovery-tool.git
cd software-discovery-tool
git checkout sdt-frontend
npm i --force
npm start

Note: You need node installed.
Alternatively, you can directly go to this link to view the current implementation: Link

Image is borderless on one of the sides, we could adjust it

I'll make the necessary changes. Thanks for pointing it out.

Hey @Apurv428, still getting errors on setting this up.

Please share the error.

@Apurv428  This is the one.
Commands I ran:
git clone https://github.com/Apurv428/software-discovery-tool.git
cd software-discovery-tool
git checkout sdt-frontend
npm i
npm start

@Apurv428 This is the one. Commands I ran: git clone https://github.com/Apurv428/software-discovery-tool.git cd software-discovery-tool git checkout sdt-frontend npm i npm start

error?

@Apurv428 This is the one. Commands I ran: git clone https://github.com/Apurv428/software-discovery-tool.git cd software-discovery-tool git checkout sdt-frontend npm i npm start

can you share the error?

Yes @Apurv428
 npm start

><EMAIL_ADDRESS>start
> honkit serve

(node:18188) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Live reload server started on port: 35729
Press CTRL+C to quit ...

Starting server ...
info: parsing multilingual book, with 6 languages
warn: no summary file in this book
info: 19 plugins are installed
info: 19 explicitly listed
info: plugin "hints" is loaded
info: plugin "sidebar-ad" is loaded
info: plugin "intopic-toc" is loaded
info: plugin "sharing" is loaded
info: plugin "exercises" is loaded
info: plugin "@honkit/honkit-plugin-ga" is loaded
info: plugin "sitemap" is loaded
info: plugin "i18nsettings" is loaded
info: plugin "favicon-custom" is loaded
info: plugin "chapter-fold" is loaded
info: plugin "hide-published-with" is loaded
info: plugin "edit-link" is loaded
info: plugin "livereload" is loaded
info: plugin "highlight" is loaded
info: plugin "search" is loaded
info: plugin "lunr" is loaded
info: plugin "fontsettings" is loaded
info: plugin "theme-creative" is loaded
info: plugin "theme-default" is loaded
Error: EPERM: operation not permitted, lstat 'C:\Users\Win\AppData\Local\ElevatedDiagnostics'
    at Object.lstatSync [as statSync] (node:fs:1634:25)
    at C:\Users\Win\node_modules\honkit\lib\fs\node.js:17:39
    at C:\Users\Win\node_modules\immutable\dist\immutable.js:3016:46
    at List.__iterate (C:\Users\Win\node_modules\immutable\dist\immutable.js:2206:13)
    at mappedSequence.__iterateUncached (C:\Users\Win\node_modules\immutable\dist\immutable.js:3015:23)
    at seqIterate (C:\Users\Win\node_modules\immutable\dist\immutable.js:604:16)
    at IndexedSeq.__iterate (C:\Users\Win\node_modules\immutable\dist\immutable.js:320:14)
    at IndexedIterable.forEach (C:\Users\Win\node_modules\immutable\dist\immutable.js:4381:19)
    at C:\Users\Win\node_modules\immutable\dist\immutable.js:2069:14
    at Map.withMutations (C:\Users\Win\node_modules\immutable\dist\immutable.js:1353:7) {
  errno: -4048,
  code: 'EPERM',
  syscall: 'lstat',
  path: 'C:\\Users\\Win\\AppData\\Local\\ElevatedDiagnostics'
}

Yes @Apurv428
 npm start

><EMAIL_ADDRESS>start
> honkit serve

(node:18188) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Live reload server started on port: 35729
Press CTRL+C to quit ...

Starting server ...
info: parsing multilingual book, with 6 languages
warn: no summary file in this book
info: 19 plugins are installed
info: 19 explicitly listed
info: plugin "hints" is loaded
info: plugin "sidebar-ad" is loaded
info: plugin "intopic-toc" is loaded
info: plugin "sharing" is loaded
info: plugin "exercises" is loaded
info: plugin "@honkit/honkit-plugin-ga" is loaded
info: plugin "sitemap" is loaded
info: plugin "i18nsettings" is loaded
info: plugin "favicon-custom" is loaded
info: plugin "chapter-fold" is loaded
info: plugin "hide-published-with" is loaded
info: plugin "edit-link" is loaded
info: plugin "livereload" is loaded
info: plugin "highlight" is loaded
info: plugin "search" is loaded
info: plugin "lunr" is loaded
info: plugin "fontsettings" is loaded
info: plugin "theme-creative" is loaded
info: plugin "theme-default" is loaded
Error: EPERM: operation not permitted, lstat 'C:\Users\Win\AppData\Local\ElevatedDiagnostics'
    at Object.lstatSync [as statSync] (node:fs:1634:25)
    at C:\Users\Win\node_modules\honkit\lib\fs\node.js:17:39
    at C:\Users\Win\node_modules\immutable\dist\immutable.js:3016:46
    at List.__iterate (C:\Users\Win\node_modules\immutable\dist\immutable.js:2206:13)
    at mappedSequence.__iterateUncached (C:\Users\Win\node_modules\immutable\dist\immutable.js:3015:23)
    at seqIterate (C:\Users\Win\node_modules\immutable\dist\immutable.js:604:16)
    at IndexedSeq.__iterate (C:\Users\Win\node_modules\immutable\dist\immutable.js:320:14)
    at IndexedIterable.forEach (C:\Users\Win\node_modules\immutable\dist\immutable.js:4381:19)
    at C:\Users\Win\node_modules\immutable\dist\immutable.js:2069:14
    at Map.withMutations (C:\Users\Win\node_modules\immutable\dist\immutable.js:1353:7) {
  errno: -4048,
  code: 'EPERM',
  syscall: 'lstat',
  path: 'C:\\Users\\Win\\AppData\\Local\\ElevatedDiagnostics'
}

are you sure you are running in the right folder?
because it should come as<EMAIL_ADDRESS>start

are you sure you are running in the right folder? because it should come as<EMAIL_ADDRESS>start

Oh right. It should be in the react-frontend folder. I can see the draft up now.
Could you please update the instructions to cd react-frontend after git checkout sdt-frontend?


Implement Composer V2 Support

Updates GitHub Actions to run using Composer v1 and v2
PHPUnit XML file migration to new format
Fixes for various typos (particularly in namespaces that was causing some issues with Composer generating the autoloader).

Before merging, we need to update the required statuses on the main branch.
After merging, we can schedule some time to upgrade composer on prod, safe in the knowledge that v1 will work fine in the interim.

:tada: This PR is included in version 6.11.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Is it possible to show contextMenu in Mac only on right-clicked to Tray Icon

I read that there is/was a problem on tray right-clicked event. It is/was triggering clicked as well. I'm not sure it's fixed or not.
I'm trying to show the contextMenu only on right-clicked to tray icon in Mac.
I tried to preventDefault from click and right-clicked events, no luck. If there is a contextMenu on a tray, It anyway shows the context menu and doesn't run the code i have in the clicked event (I'm showing/hiding the window by single click)
I'm looking a way/workaround to show the contextMenu when only right clicked.
Tev.

It seems that we don't have a solution for this, we can probably add a menu parameter for Tray.popUpContextMenu.

I'm having this exact issue right now. Hopefully someone can figure out a fix.

I'm having the same problem now.

I just realized this is a duplicate of #2830.


fix the URL for Balanced js

Regression introduced in f526d9613354abc77044d5fdac8c2beceb7dc887 (#3467).

Ping @rohitpaulk @techtonik @kaguillera et al.

Blocking:
https://gratipay.freshdesk.com/helpdesk/tickets/2187


Adds cifmw-adoption-standalone-base for rhel 9.2 OSP17/CDN job

Adds cifmw-adoption-standalone-base for rhel 9.2 OSP17/CDN job

This adds cifmw-adoption-standalone-base which is essentially the same
as cifmw-adoption-base but with the addition of the standalone node
and ci-framework required networking config. Using this new parent
will let us minimize disruption while adding the new job.

Needed by https://review.rdoproject.org/r/c/rdo-jobs/+/50590/

https://issues.redhat.com/browse/OSP-29746

As a pull request owner and reviewers, I checked that:

[X] no need for actual checkbox

/approve
makes sense for a smooth migration.

/lgtm


alamin

https://github.com/microsoft/vscode/blob/main/.vscode%2Fcglicenses.schema.json

@salauddinmahmud could you please provide some additional information about what exactly your issue is. In its current form the issue is not actionable.


1.66.0 - Storage & CPU information no longer present

Just upgraded from 1.59 to 1.66 using the helm chart. I'm using an external prometheus and previously have had no problems. I'm running on AWS EKS.
I've now noticed that the only costs being synced seem to be 'Memory' however, causing a large underestimate of the cluster cost! Could anyone point to to how to get Storage & Compute costs back?

HI @robertgates55, thanks for this report.
Regarding the missing Compute graph:
Looks like the kubernetes_node label may be missing from your node-exporter metrics. We should still be collecting costs, just not displaying it correctly on that page. We have a staging build with a fix to display the total cost even when these breakdowns don't exist. Instructions on getting that build are available here: https://github.com/kubecost/docs/blob/master/staging.md
However, you also want to be picking up these metrics to make sure you have the breakdown displayed. Can you also run "node_cpu_seconds_total" and send us a few rows of the results so we can see if this is the cause? If it is, you'll want to add our rules to relabel here:
https://github.com/kubecost/cost-analyzer-helm-chart/blob/develop/cost-analyzer/charts/prometheus/values.yaml#L1257
Regarding the missing Storage graph:
Can you run
sum_over_time(sum(container_fs_usage_bytes{device!="tmpfs", id="/"}) by (instance, cluster_id)[24h:1m]) / 1024 / 1024 / 1024
avg_over_time(sum(container_fs_limit_bytes{device!="tmpfs", id="/"}) by (instance, cluster_id)[24h:1m])

and see if this is working for you?

node_cpu_seconds_total:
Element | Value
node_cpu_seconds_total{cpu="0",endpoint="metrics",instance="<IP_ADDRESS>:9100",job="node-exporter",mode="idle",namespace="monitoring",pod="prometheus-operator-prometheus-node-exporter-p926c",service="prometheus-operator-prometheus-node-exporter"} | 365414.98

sum_over_time(sum(container_fs_usage_bytes{device!="tmpfs", id="/"}) by (instance, cluster_id)[24h:1m]) / 1024 / 1024 / 1024:
Element | Value
{instance="<IP_ADDRESS>:10250"} | 27483.565273284912

As the complexity of the relabellings etc looks to be increasing (I can imagine maintaining backwards compatibility is a continual battle) I was looking at letting kubecost deploy it's own prometheus.
However, I already have a prometheus-operator install in each of our clusters, and would like to reuse the node-exporter and kube-state-metrics deployments if possible, as per the docs:
"For the best experience, we generally recommend teams use the bundled prometheus-server & grafana but reuse their existing kube-state-metrics and node-exporter deployments if they already exist. This setup allows for the easiest installation process, easiest on-going maintenance, minimal duplication of metrics, and more flexible metric retention."
Could you advise what additional configuration is required to achieve this? I presume prometheus.kubeStateMetrics.enabled: false and prometheus.nodeExporter.enabled: false, but how do I then make the kubecost prometheus scrape the necessary from the existing deployments?

Right. I've moved to using a kubecost prometheus instead, as it feels like aligning everything will be too tricky to maintain. Also found the docs section on using my own nodeExp/stateMetrics.
All good now - thanks!
"Using an existing node exporter
You can use an existing node exporter DaemonSet by setting the prometheus.nodeExporter.enabled and prometheus.serviceAccounts.nodeExporter.create Kubecost helm chart config options to false. More configs options shown here. Note: this requires your existing node exporter to be configured to export metrics on the default port."


Create a deployment of the alertmanager to notify for submit errors

Post results in a telegram chat using the  https://github.com/metalmatze/alertmanager-bot/

closed in https://github.com/tellor-io/telliot/pull/434


Use existing assignment if available

previously if probabilities feature was disabled, it would not use the existing assignment
use case:
if you are doing an experiment and you want to grandfather old users by using ab_add_participant
description of problem:
as of right now ab_add_participant won't do anything because when it hits AbTest#alternative_for, it just skips down to Digest::MD5.hexdigest("#{name}/#{identity}").to_i(17) % @alternatives.size and overwrites the alternative.
anyone willing to help me out with the failing test?

@jmondo thanks for the PR! We'll probably have to add an additional test to handle the new if/else case.

@jmondo thanks again for the PR. It looks like this was solved for unequal probabilities, but at the wrong level, in alternative_for instead of higher up in choose. I've fixed this and added a test case covering this behavior in  c33998b.

awesome! thanks so much :)


Youtube

Where is the upload to YouTube function?

Currently the project as a whole is a work in progress, and youtube uploading isn't implemented as I don't have a way to authorize uploading without a window manager (I'd like the whole program to function from the terminal and files).


Call forward_sequence with second template argument for real forwarding

Currently we almost universally call xtl::forward_sequence with only one template argument.
For real forwarding we need to call it with a second template argument.

This has been fixed in 0.19.0


ERROR in static/js/commons.js from UglifyJs

What did I do?
./psh.phar administration:build
What did I want to achieve?
Rebuilding all js files for the administration, to see any changes (like the color for menu items).
What did I expect?
An error-free experience.
What happened?
Some weird UglifyJs error pops up, regardless of me extending anything. Unexpected token: punc ())
The files have not changed; the color of the menu item stayed the same.
Full error log
(2/3) Starting
> npm run --prefix vendor/shopware/platform/src/Administration/Resources/administration/ build -- http://localhost:8000

        ><EMAIL_ADDRESS>build /app/vendor/shopware/platform/src/Administration/Resources/administration
        > node build/build.js "http://localhost:8000"

        # Loading Shopware administration plugin definitions
        Trying to load plugin definitions from "/app/var/config_administration_plugins.json"
        Found 1 plugin definition(s): WebcuMarketplaceConnector

        # Adding Shopware administration plugins to Webpack
        Plugin "WebcuMarketplaceConnector" was injected into the Webpack config

        Hash: 6ca2890ae4755bc0695f
        Version: webpack 3.10.0
        Time: 18422ms
                                             Asset     Size  Chunks                    Chunk Names
                           static/js/vendor.js.map   3.8 MB       0  [emitted]         vendor
                static/img/sw-login-background.png   513 kB          [emitted]  [big]
                                  static/js/app.js   459 kB       1  [emitted]  [big]  app
                              static/js/commons.js  79.3 kB       2  [emitted]         commons
            static/js/WebcuMarketplaceConnector.js  2.17 kB       3  [emitted]         WebcuMarketplaceConnector
                             static/js/manifest.js  1.45 kB       4  [emitted]         manifest
                                static/css/app.css   295 kB       1  [emitted]  [big]  app
                               static/js/vendor.js   533 kB       0  [emitted]  [big]  vendor
                              static/js/app.js.map  1.76 MB       1  [emitted]         app
                          static/js/commons.js.map   113 kB       2  [emitted]         commons
        static/js/WebcuMarketplaceConnector.js.map  8.83 kB       3  [emitted]         WebcuMarketplaceConnector
                         static/js/manifest.js.map  14.1 kB       4  [emitted]         manifest
                 static/css/prism-github-theme.css  2.23 kB          [emitted]
                  static/css/storybook-preview.css  1.05 kB          [emitted]
                           static/img/sw-icons.svg   356 kB          [emitted]  [big]

        ERROR in static/js/commons.js from UglifyJs
        Unexpected token: punc ()) [./node_modules/eslint-loader?{}!./node_modules/eslint-loader??ref--0!./src/core/common.js:28,0][static/js/commons.js:372,30]

          Build complete.

          Tip: built files are meant to be served over an HTTP server.
          Opening index.html over file:// won't work.

Version Info
Using the shopware/platform commit https://github.com/shopware/platform/commit/051852af023bc9f2a632f6abf8c3a4ffecf1b1d7 as of Monday 30.07.2018 around 12.00.

No such issue arises for administration:watch, probably because uglify isn't used.

Hey @EtienneBruines,
thx for the info, I created a ticket for that. We will give a short answer when we fixed this.
Greetings,
Phil

Hey @EtienneBruines,
we updated all dependencies, so the issue should no longer appear. Could you check this, if it's fixed for you?


fix(dependencies): 💫 update packages

Description
Update dependencies.
Type of change

[X] Dependency update

How Has This Been Tested?

[X] cargo test run with all tests passing

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

Current dependencies on/for this PR:

main

PR #68   👈

This comment was auto-generated by Graphite.


Launching of Botframework composer throws error with pop up -> "Something went wrong"

Launching the botframework composer throws error with popup title "Something went wrong" and the content says to report an issue in Github
After it loads & in the workflow after selecting "Send Response" activity & trying to click "Show Code". It once again throws the same error "Something went wrong"
Version
Version:  2.1.0
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
OS
Edition	Windows 10 Enterprise
Version	21H1
Installed on	1/29/2021
OS build	19043.1110
Experience	Windows Feature Experience Pack 120.2212.3530.0
To Reproduce
Refer to the above issue description
Expected behavior
The Botframework composer shouldn't throw any error
Screenshots

Hi @SundaresanSivakumar
Do you see any error listed in the Problems section at the bottom of Composer?

Hi @dmvtech ,
I didn't notice anything. However I uninstalled the bot framework composer 2.1.0 last week and installed the 2.0.0 version as we had product release close by. I will try installing the latest version tomorrow and let you know.
Thanks

I installed the 2.1.0 version . The screenshot that I had shared while creating this issue pops up. However i don't see any error listed in the problem section.

Thank you @SundaresanSivakumar
Can you try the following?:

Go to Composer's install location (mine is at C:\Users{username}\AppData\Local\Programs\Bot Framework Composer)
Open a terminal here
run set DEBUG=composer*
run the executable from the terminal Ex. "Bot Framework Composer.exe"

Then run the same steps to reproduce the issue. Then share the output from the terminal.

Hi @SundaresanSivakumar Any luck with the above steps?

Here is the terminal o/p Dana
2021-08-25T04:59:29.619Z composer:publisher-controller Setting up runtime
log server
GET /api/publish/runtimeLogUrl/90574.58464532069 304 32.908 ms - -
2021-08-25T04:59:29.752Z composer:bot-project Schemas directory found.
GET /api/publish/90574.58464532069/status/default 404 158.125 ms - 66
GET /conversations/ws/port 200 39.554 ms - 39
GET /conversations/ws/port 200 0.516 ms - 40
2021-08-25T04:59:30.162Z composer:bot-project Schemas directory found.
2021-08-25T04:59:30.185Z composer Update file check.botproj {
"$schema": "
https://raw.githubusercontent.com/microsoft/BotFramework-Composer/main/Composer/packages/server/schemas/botproject.schema
",
"name": "check",
"skills": {}
}
PUT /api/projects/90574.58464532069/files/check.botproj 200 116.151 ms - 74
2021-08-25T04:59:30.243Z composer:bot-project Schemas directory found.

GET /api/projects/90574.58464532069/variables 304 61.324 ms - -
2021-08-25T04:59:52.271Z composer:bot-project Schemas directory found.
GET /api/projects/90574.58464532069/variables 304 60.625 ms - -
2021-08-25T05:00:56.127Z composer:bot-project Schemas directory found.
GET /api/projects/90574.58464532069/variables 304 64.117 ms - -
2021-08-25T05:00:57.915Z composer:bot-project Schemas directory found.
GET /api/projects/90574.58464532069/variables 304 60.442 ms - -
On Wed, Aug 25, 2021 at 4:58 AM Dana V @.***> wrote:

Hi @SundaresanSivakumar https://github.com/SundaresanSivakumar Any luck
with the above steps?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/BotFramework-Composer/issues/8531#issuecomment-905042155,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2WX4T2CDDGOW4VR42ROD3T6QTKTANCNFSM5BVH3K5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@SundaresanSivakumar You should have 2 schema files as well. I have attached them. Can you extract them from the zip and add them to the schemas folder and see if that resolves the issue?
schemas.zip

@SundaresanSivakumar Any luck?

Closing due to lack of response. Please comment if you are still having this issue.

Sorry @dmvtech , couldn't get back to you early. However i tried to copy the schema file but still the issue remains

@SundaresanSivakumar

If you expand the Details section, what does it show? (Any error different than the above console trace?)
Are you able to share your bot with me? Either in a zip or in a (private) repository?

Hi @SundaresanSivakumar Just checking in. Can you comment on the questions above?

Closing due to lack of reply. If you are still need assistance, please comment with the information asked above and anything else that may help troubleshoot and we will reopen.


add plugin for review

LGTM - one open comment about renaming cp, but this looks like it's doing the right thing.

/lgtm


error: failed to get bitcode from object file for LTO

Hello. I use cargo xbuild to build my OS. Recently build failed with the following error message.
error: failed to get bitcode from object file for LTO (Bitcode section not found in object file)

My repository is this and cargo_settings.json is specified as the target. You can reproduce this by running make on the master branch. I also tried with phil-opp's .json file, but build failed. The only thing which made it possible to build is to disable lto ( lto = false in Cargo.toml) . cargo clean && cargo xbuild did not solve the problem.
This is my CI history. You can see that the same commit succeeds and fails to build.

I never seen this error before, but it sounds more like a rust/cargo problem. Have you tried updating your nightly?

If it still occurs on the current nightly, it might be worth opening an issue in the https://github.com/rust-lang/rust repository.

I'm currently investigating: this looks to be the culprit https://github.com/rust-lang/cargo/pull/8192.
Compiling with rlib enabled in Cargo.toml works, produces the following rustc flags:
-Cembed-bitcode=no
With rlib removed we get:
 -C lto
Manually running rustc with  -C lto replaced with -C linker-plugin-lto seems to work okay.
I'll look a bit further but that is what I've figured out so far.

@ascjones Thanks for investigating! I think you're right that this pull request caused it. We should definitely open a cargo issue with an example that reproduces this eror.
It seems like the rusty-hermit project has the same issue: https://github.com/hermitcore/rusty-hermit/issues/15, so it might make sense to cc the project developers in the issue.

I created a minimal example to reproduce: https://github.com/toku-sa-n/cargo_bug
cargo xbuild should cause the error.

Thanks for the example @toku-sa-n. By bisecting rustc I found out that this error is caused by https://github.com/rust-lang/rust/pull/71528, which in combination with https://github.com/rust-lang/cargo/pull/8066 results in a more aggressive removal/ of bitcode for crates that have lto disabled. Since we compile the sysroot as a separate crate, this means that it gets compiled without bitcode because we don't have lto enabled for it.
I think the most simple fix is to always enable lto for sysroot builds. I will create a PR in a moment.

I created a fix at https://github.com/rust-osdev/cargo-xbuild/pull/70.

Still failing with cargo-xbuild 0.5.30 and rustc 1.45.0-nightly (9912925c2 2020-05-10). I tried cargo clean && cargo xbuild on my minimum example, but build failed with the same error. Is it better to send a issue on cargo project?

Can confirm I also get the same error with the new version 0.5.30

Seems like I messed something up… I can also still reproduce the error. I'll take a look at it again right now.

Still investigating, but it seems like version 0.5.30 only fixed the breakage between nightlies 2020-04-30 and 2020-05-01. There seems to be another breakage between 2020-05-01 and current nightlies. Starting a new bisecting run.

Regression is in https://github.com/rust-lang/rust/pull/71925, so it is likely https://github.com/rust-lang/cargo/pull/8192, as @ascjones suspected. I'm still not sure what the best fix is.
I think I will report this to the xargo project too since it also seems to affect them. Maybe they have an idea how to fix this.

I opened a xargo issue at https://github.com/japaric/xargo/issues/292.
I also found one possible fix: Set -Clinker-plugin-lto for the sysroot build via RUSTFLAGS. I will create a PR in a moment. Maybe you can help test it then?

@ascjones @toku-sa-n I created a new PR at #71. Maybe you could try whether it fixes the issue. You can install the new version through:
cargo install cargo-xbuild --git https://github.com/rust-osdev/cargo-xbuild.git --branch embed-bitcode  --debug --force

Thank you. Builds of both the minimum example and my OS succeed.

Great to hear that!

Fixed version released as v0.5.31.

Works! Much appreciated :)

Sorry, very sorry, but the problem seems not to be solved. Actually cargo xbuild succeeded, but the output binary seems to have a defect.
Building my OS did not succeed completely, with ld error:
ld: build/libramen_os.a: error adding symbols: file format not recognized

See CI log

@toku-sa-n It seems like this issue is not related to cargo-xbuild. It also occurs when using cargo's -Z build-std flag instead of cargo-xbuild. Try the following diff:

Click to show the diff
diff --git a/Cargo.toml b/Cargo.toml
index 26cf1bb..d9f1861 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -24,6 +24,7 @@ crate-type = ["staticlib"]

 [dependencies]
 spin = "0.5.2"
+rlibc = "1.0.0"

 [dependencies.lazy_static]
 version = "1.4.0"
diff --git a/Makefile b/Makefile
index 478ffa6..dd58448 100644
--- a/Makefile
+++ b/Makefile
@@ -45,7 +45,7 @@ endif

 release:$(KERNEL_FILE) $(HEAD_FILE) $(LD_SRC)|$(BUILD_DIR)
        make clean
-       $(RUSTCC) xbuild --target-dir $(BUILD_DIR) --release
+       $(RUSTCC) build -Zbuild-std=core,alloc --target-dir $(BUILD_DIR) --release
        cp $(BUILD_DIR)/$(CARGO_JSON)/$@/$(shell basename $(LIB_FILE))  $(LIB_FILE)
        make

@@ -53,7 +53,7 @@ $(KERNEL_FILE):$(LIB_FILE) $(LD_SRC)|$(BUILD_DIR)
        $(LD) $(LDFLAGS) -o $@ $<

 $(LIB_FILE): $(addprefix $(RUST_SRC_DIR)/, $(RUST_SRC))|$(BUILD_DIR)
-       $(RUSTCC) xbuild --target-dir $(BUILD_DIR)
+       $(RUSTCC) build -Zbuild-std=core,alloc --target-dir $(BUILD_DIR)
        cp $(BUILD_DIR)/$(CARGO_JSON)/debug/$(shell basename $(LIB_FILE)) $@

 $(HEAD_FILE):$(HEAD_DEPENDS)
diff --git a/src/lib.rs b/src/lib.rs
index c67ceee..f817450 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -3,6 +3,8 @@
 #![feature(start)]
 #![feature(naked_functions)]

+extern crate rlibc;
+
 mod asm;
 mod descriptor_table;
 mod interrupt;

So this isn't something that we can fix in the cargo-xbuild tool. I recommend creating a minimal example that uses -Z build-std instead of cargo-xbuild and then report it in the rust-lang/rust or rust-lang/cargo repository directly.

I see. Anyway, thank you for telling me.

I ran a bisect for your project with the above diff applied and the "file format not recognized" also appears with https://github.com/rust-lang/rust/commit/63d03779946a07d8c418a361278168a6d3a1f4d2.

The discussion in https://github.com/japaric/xargo/issues/292 showed that rustc bootstrap passes -Cembed-bitcode=yes instead of -Clinker-plugin-lto. I created https://github.com/rust-osdev/cargo-xbuild/pull/73 to switch cargo-xbuild to the same approach.


Feature request: tiling support

Would be nice if VSGAN would some sort of tiling support, to lower the memory requirement.
Tiling as in splitting the source image into smaller images apply the model and stick the processed images back together.

Yeah, thanks for looking into it.


fix(46712): Add "exceptZero" for "signDisplay" option of Intl.NumberF…

Fixes #46712
The "exceptZero" type was missing on the "signDisplay" option as it was mentioned in the issue. This PR adds it. I'm not sure whether do I have to write any test case for it. Please guide me if I have to write any.

Yep, confirmed with the spec - looks good to me, thanks


Contributing guidelines on linting

📚 Documentation
The current CONTRIBUTING guide suggests contributors to first run black gradslam and then check for flake8 gradslam errors.
A better way would be to reverse the two steps (i.e., first run flake8 to enlist files with errors, and then run black ONLY on these files).

Everything in gradslam is currently linted with black. So running black gradslam will only change the files modified in the PR. Running flake8 afterwards will show any extra imports which won't be fixed by black, and have to be checked manually.

Closing due to inactivity


feat: add private property to resource schemas

Related #6
Adds an option to exclude libraries and assets for the catalogs. By default, all indexed libraries and assets will be included in the catalogs. This follows how npm uses the private key. See: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#private
In the future, we'll have some "reviewed" or "verified" property that will be used in the catalog's default filters. To counter-balance private which defaults to showing everything, reviewed will default to not reviewed so the resource can go through the review process.
Changelog
New

private key in the schemas, defaulting to false
Library and asset catalog pages filter out private items

Testing / reviewing
See docs file that explains the private key.

We can ignore the failed checks since @jdharvey-ibm changed the action configs since this PR was opened?


TreeGrid Column Picker Issue

When we use the column picker the TreeGrid gets disturbed

that is disturbing news indeed :)
can you please provide screenshot?

Normal screen

updating Serenity.Web.Assets to 3.8.6 should resolve this issue, make sure running dotnet sergen restore for .net core

Ok will check

Hi @volkanceylan


error in CIFAR10 datasets and Celeba-HQ dataset

Hi, thank you for this interesting work. I was trying to run this code to learn more details about your paper but encountered the following error.
For CIFAR10 datasets, it warms
"Traceback (most recent call last):   File "/home/renge/anaconda3/envs/BadDiff/lib/python3.8/site-packages/datasets/load.py", line 1172, in dataset_module_factory     raise e1 from None   File "/home/renge/anaconda3/envs/BadDiff/lib/python3.8/site-packages/datasets/load.py", line 1129, in dataset_module_factory     raise ConnectionError(f"Couldn't reach '{path}' on the Hub ({type(e).__name__})") ConnectionErrorpython-BaseException : Couldn't reach 'cifar10' on the Hub (ConnectionError)"
I think it may be the Internet problem, so I prepared the Celeba-HQ dataset locally in path "./datasets/celeba_hq_256". However, it warms that
"Traceback (most recent call last):   File "/home/renge/anaconda3/envs/BadDiff/lib/python3.8/site-packages/datasets/data_files.py", line 458, in get_data_patterns_locally     return _get_data_files_patterns(resolver)   File "/home/renge/anaconda3/envs/BadDiff/lib/python3.8/site-packages/datasets/data_files.py", line 235, in _get_data_files_patterns     data_files = pattern_resolver(pattern)   File "/home/renge/anaconda3/envs/BadDiff/lib/python3.8/site-packages/datasets/data_files.py", line 276, in _resolve_single_pattern_locally python-BaseException     glob_iter = [PurePath(filepath) for filepath in fs.glob(pattern) if fs.isfile(filepath)]   File "/home/renge/anaconda3/envs/BadDiff/lib/python3.8/site-packages/fsspec/spec.py", line 606, in glob     pattern = glob_translate(path + ("/" if ends_with_sep else ""))   File "/home/renge/anaconda3/envs/BadDiff/lib/python3.8/site-packages/fsspec/utils.py", line 734, in glob_translate     raise ValueError( ValueError: Invalid pattern: '**' can only be an entire path component".
I cannot understand what happened in "datasets" module and function "load_dataset", could you help me please?

Hello, thank you for your interests. However, I cannot reprodued your issue. Could you give me your environment and commends?


Bug in hdf5 handling when an early filter has no data

For some reason this broke tests only on arm32 and arm64 and with hdf5 1.10.7 but there is a bug in libhdf5/hdf5open.c.
The code does
    size_t cd_nelems = CD_NELEMS_ZLIB;
[...]
    for (f = 0; f < num_filters; f++)
    {
        if ((filter = H5Pget_filter2(propid, f, NULL, &cd_nelems, cd_values_zip,
                                     0, NULL, NULL)) < 0)
            return NC_EHDFERR;
        switch (filter)
        {

cd_nelems gets updated with the number of values for the filter, so when the first filter has 0 it gets set to 0 and when the second filter has 1 it doesn't get written to cd_values_zip because cd_nelems is now 0. This causes a failure when the uninitialised value is > 9 for H5Z_FILTER_DEFLATE (maybe it gets initialised to 0 on other architectures?).
Setting cd_nelems = CD_NELEMS_ZLIB inside the loop makes the tests pass.

This was actually already fixed in https://github.com/Unidata/netcdf-c/commit/84c69afca7cd4493905f208cfaeaa2224816325f#diff-69d85613974e9a9e174118838e5f3d8f931fbe4a36f6e2c9f8970459180ce15c

So is this a reversion report?

The bug existed in 5.7.4 but is now fixed at head


tree-table selection doesn't work correctly if only single subRow is specified

Describe the bug (required)
Codesandbox: https://codesandbox.io/s/lucid-wozniak-fsg0b
In a tree-table, parents of rows with single children (subRows has only one element) get selected when selecting a child row. This only occurs with single child rows, so if subRows contains more than one row, the tree-table selection is working as intended.
To reproduce:
In the Codesanbox expand to level 3 or deeper and select the table entry. The result is that not only the current row is selected, but all of its parents, too. This only happens for single subRow entries.
Expand to level 6 and check the entry, now only the current row is selected.
Also the state is updated correctly, so only the selected row and its children are selected.  The checked prop of the parent entries is set to true/false, though.
Desktop (please complete the following information):

OS: iOS
Browser: chrome
Version: 80.0.3987.132 (Official Build) (64-bit)

AFAIK, this is intended behavior. If you check a selection for a parent, all sub-rows should also be checked to match. Likewise, in a reactionary event, if all sub-rows of a parent become checked, the parent should again, show the same state by having them all checked. I'm not sure why or how you would want this to function without breaking the majority use case of nested row selection. If you want each of these rows to be independently checkable, then I would suggest that you propose a simple use case and PR to accomplish it via a config or if you wish, you can write your own version of the useRowSelect hook that fits this use case.

Hi @tannerlinsley
thanks for the reply.
In our use-case it's more common that the user wants to select only a single node or leaf in the tree, that's why we need a single select option.
For now I implemented the single select behavior by leveraging the table's state and setting the selected rows accordingly.
If I find the time, I will look into creating a hook/option that implements this behavior and then open a PR.


Multiple intervals problem

Hi, im trying to execute the example "multiple-intervals.py" to see how it works and it gets me this error : "ValueError: cannot have a multithreaded and multi process server" , i dont understand why, thank you

It's an issue with the latest version of flask. Just set threaded=False in app.run_server or keep threaded=True but set processes=1


Design options for environment selection window

The window displaying all virtual environment preview should no longer resemble the ViaProMa design. Instead, users should be able to customize the design options as well as the display options.

As we decided to decouple the display of the environments from the feature, this enhancement is no longer necessary.


build -t freeipa-server . fails to install httpd

Tried to run httpd build -t freeipa-server . on Debian 7.11 and got this error.
Dependency Updated:
systemd.x86_64 0:219-19.el7_2.12     systemd-libs.x86_64 0:219-19.el7_2.12
Failed:
httpd.x86_64 0:2.4.6-40.el7.centos.4
Complete!
The command '/bin/sh -c mkdir -p /run/lock && yum install -y ipa-server ipa-server-dns ipa-server-trust-ad && yum clean all' returned a non-zero code: 1

That seems similar to https://github.com/adelton/docker-freeipa/issues/22, https://github.com/adelton/docker-freeipa/issues/46, or https://github.com/adelton/docker-freeipa/issues/72. I assume your docker installation uses AUFS storage driver on which installation of the httpd package in the container fails. Please use different storage driver or different OS on the host which does not default to AUFS.


Available backends?

Can I find a list of this somewhere? Would be nice to have access to historical exchange rates.

There are no openly available backends that I know of yet. You may create one that uses external data (e.g. openexchangerates.org has historical data). Let me know how it worked out.

Okay thanks. I kind of expected that. Just thought it would be a good idea to make this publicly available.


Implement IDisposable for derived types for WebApplicationFactory

Add a protected Dispose(bool) method and a finalizer to WebApplicationFactory<T> for use in classes that derive from it and want to dispose of their own resources.
Resolves #7631.

Thank you for your contribution, @martincostello!


this is only for tensorflow 2.2 ?

is this only used for tensorflow 2.2 ?

TensorFlow 2.2 or later. The loss classes use the tf.keras.utils.register_keras_serializable decorator, which was introduced in TensorFlow 2.1, and fixed for usage with custom loss functions in TensorFlow 2.2. There might be other version-dependent issues, but that's the biggest one off the top of my head.

Use to focal loss tf < 2.0, you should comment line https://github.com/artemmavrin/focal-loss/blob/master/src/focal_loss/_binary_focal_loss.py#L269.

Thank for @artemmavrin, you implemented focal loss + smoothing label
@artemmavrin , Use to focal loss tf < 2.0, you should comment line https://github.com/artemmavrin/focal-loss/blob/master/src/focal_loss/_binary_focal_loss.py#L269.

I tried running the provided example after doing this in sparse_categorical_focal_loss. I'm getting a ValueError: batch_dims = 1 must be less than rank(indices) = 1


Reset workspace: why?

Extracted from https://github.com/iterative/vscode-dvc/pull/1816#pullrequestreview-993070400

[ ] First, I'm using the example-get-started repo on Codespaces and this button doesn't have an effect at all (bug?)

Most importantly, why do we need this? I understand that "Reset workspace" means
git reset --hard HEAD && git clean -f -d -q && dvc checkout
So that's 2 Git operations in the DVC panel. We already have a button from dvc checkout so why add this shortcut? Probably there's a reason (pros) but here are some more cons in advance:

It's unclear what it means.
Operation too complex?
It's "scary" AND actually dangerous.
It can be done by other means (terminal).

Finally, if the Git integration doesn't include git reset (nor git clean), should we?

Yes, we have analytics attached to the action. We'll be able to see the usage.

What if there are changes to Git-tracked params or metrics files? That's part of the DVC project and especially important to the extension since it focuses on DVC experiments, yet Reset workspace silently ignores those unless there are changes in DVC-tracked files.

p.s. the official definition of DVC workspace includes all Git-tracked files.

Is the suggestion to make the command more aggressive and always blat the workspace? That would be an easy change to make.

I personally still don't love this button but if we keep
a) Rename Discard Workspace Changes and always quash Git changes (or even better specifically Git-tracked inputs/outputs).
b) Rename Discard DVC-tracked Changes and only reset DVC-tracked files.
From those options I sort of prefer a' (may be easier once there's full DAG/ pipelining support)

I personally still don't love this button but if we keep,
a) Rename Discard Workspace Changes and always quash Git changes (or even better specifically Git-tracked inputs/outputs);
b) Rename Discard DVC-tracked Changes and only reset DVC-tracked files.
From those options I sort of prefer a' (may be easier once there's full DAG/ pipelining support)

Working on sledgehammer version of A. Can revisit once we get data:status.


Kick from the server

Describe the bug, provide any errors
When I join the server on 1.12 after some time I get kicked with this error. This can happen on join, on tp to another player. Kicks with: https://cl.ly/2a3d587cbfa9
https://pastebin.com/raw/0ABhJEia
ViaVersion Dump:
https://pastebin.com/raw/xfyBY9fX
Additional server info
bungee
This server is running CraftBukkit version git-PaperSpigot-"4c7641d" (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)

It was caused by PacketPlayOutEntityEquipment. Why armor bar is not updating properly btw?

If you're getting those errors you have a plugin doing something wrong or badly (invalid armour slot ids probably). I can't help you if you're not willing to provide a proper plugin list, I'd suggest removing plugins to narrow down the cause.
Armour after 1.8 is controlled by attributes which ViaVersion adds, in rare cases (usually other plugins doing something) it doesn't work.


feat: create a C++ sample for overwrite header plugin.

This plugin is a overwriting request and response header showcase.
Technically, this is performed by replacing some existing header according to the desired key.
This examples contains only a C++ version.

LGTM, waiting for CI to confirm

No idea why header-check stopped working. Bypassing to merge.


[@vitejs/plugin-react] Don't apply automatic jsx runtime to dependencies

Description
I am using @vitejs/plugin-react with the jsxImportSource option to automatically apply the @emotion/react jsx transform.
It seems that currently the vite-react plugin attempts to transform dependencies that use the classic runtime to use the automatic runtime and adds an import to the supplied jsxImportSource (ie. import ... from '@emotion/react/jsx-runtime) into those dependencies.
In my project, there is a dependency that is being transformed to use the automatic runtime but it does not have access to import from @emotion/react due to the node modules directory structure (I'm using pnpm which is stricter on dependency access). Because of this, I get a build error:
Error: [vite]: Rollup failed to resolve import "@emotion/react/jsx-runtime" from "...(path to dependency)".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`

It also seems to do this regardless of the include/exclude filter options that can be passed to the plugin.
Suggested solution
This could be fixed if there was a way to disable the behaviour of upgrading the classic jsx runtime to the automatic jsx runtime in dependencies. Probably via some option in the vite-react plugin ({ upgradeJsxRuntimeInDependencies: false } or similar).
It might be nice to also mention that the plugin does this in the readme for the plugin as it does affect dependency code that you might not otherwise expect to be targeted by the plugin, even when you specify a filter.
Alternative
No response
Additional context

Code in the react plugin that transforms dependencies:
https://github.com/vitejs/vite/blob/0cbb33bade1b10c1503f47f8f8ed6e3b39818066/packages/plugin-react/src/index.ts#L219-L233
Note I was able to get my code to compile by manually editing the plugin and replacing line 227-230 with const [restoredAst, isCommonJS] = [null, false], avoiding restoreJSX altogether.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Nice going with debugging that, I got the same issue.

It also seems to do this regardless of the include/exclude filter options that can be passed to the plugin.

This actually sounds like a bug. But the comment there gives the impression it's not since it seems to actively (!isProjectFile) target dependencies to modify their JSX output.
I can't say if that's necessary, I mean it could be since you can't know what output bundled dependencies have.
But your take on it to be able to opt out of it makes a whole lot of sense.
Is there a consensus on wether or not dependencies should be transformed like that or not?

Thanks for sharing your findings on debugging this. I'm using a patch for now, with the workaround you mentioned.
Hopefully this is only temporary though :-)
Perhaps instead of just a boolean value of upgradeJsxRuntimeInDependencies, perhaps it should be an object where you can specify which dependencies it should be disabled / enabled for.

Citing https://github.com/vitejs/vite/tree/main/packages/plugin-react#opting-out-of-the-automatic-jsx-runtime
"By default, the plugin uses the automatic JSX runtime. However, if you encounter any issues, you may opt out using the jsxRuntime option.
"
So setting
react({
  jsxRuntime: 'classic'
})

Should basically do the same thing.
I do however think they should make it more granular, so that you can specify which packages you want to opt out from using the automatic jsx runtime.

@sorenhoyer yes you can use the classic runtime to disable the behaviour but I think that defeats the purpose in the case that you want to change jsxImportSource, as that's an option to configure the automatic runtime.
The issue I'm trying to get at here is not that the automatic runtime is enabled by default but that the dependencies are being transformed from the classic runtime to use the automatic runtime when I do not need/expect them to be.

@MarcPorciuncula my bad. You're absolutely right. :-)


Adjust logging of empty or filtered body

Invalid body values are logged as raw valid JSON values.
Description
For the special case of an empty body, resulting from using a filter, log an empty body.
Motivation and Context
Produces invalid log statements.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.

:+1:


Typeahead doesn't work very well with multiple lines

This surely must be an issue you know about, but I couldn't find any issues for it. Typeahead support in prompt toolkit is very buggy. It's basically unusable, because it can't be relied on.
It seems to eat anything after the first newline. It also sometimes eats part of the typed text, but I haven't yet found a good way to reproduce that.
Consider a simple prompt
from prompt_toolkit.shortcuts import prompt

import time

while True:
    time.sleep(3)
    a = prompt('> ')
    print(a)

I run python test.py and then type
1
2
3
4

I expect each to enter prompt as it appears. What happens instead is
1
2
3
3
> 1
1
>

So it eats all but the first. If I do it again in the same session, I get
> 1
1
2
3
4
> 2
2
>

again, it eats all the typeahead up to the first newline.
I tested this in 2.0, as I know there are a lot of changes there, and it's even worse!
1
2
3
4
> 1234
None
> 1
1
2
3
4
> 234
None

So instead of eating the newlines, it erased them (also, prompt no longer returns the input in 2.0?).

Hi Aaron,
Thank you for checking this out!
I took some time to troublehoot this, and I think I got it working on the 2.0 branch.
See: https://github.com/jonathanslenders/python-prompt-toolkit/blob/2.0/prompt_toolkit/input/typeahead.py
Probably, I won't backport this to 1.0.
Please, let me know whether you find any issues. Next is making sure that the "cursor-position-responses" aren't printed in certain edge cases.

I'll try to play around with it. But I won't know for sure if it is really working well until I get a real shell using it. What is the timeline for any kind of release for 2.0 (beta or otherwise)?

Probably it'll take a few more months. I prefer not to hurry too much and make sure that it's stable, but also contains all the backward-incompatible changes that I need.

Well my test script does seem to work now (although a lot of CSR codes are printed when typing ahead).
Let me know when 2.0 is ready for general testing. I don't want to spend time porting my stuff to it before it's stabilized, but I also want to help iron out kinks before it gets released.

OK. Can you remind me which terminal application you're using?
It should be possible to suppress those CPRs.

I use iTerm2

Hi @asmeurer, if you have time, could you try again your code on the 2.0 branch using iTerm 2.
I'd like to know whether the CPR issue is fixed now. (I applied a fix, but I'm not 100% sure whether it works.)

Sorry, I still see them.


Use bleeding-edge svd2rust

A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444)
recently went into the svd2rust and svd-parser crates. Until these
changes are part of a release have update.sh pull a fork of svd2rust
that uses the master version of svd-parser.
See #195.

Could you maybe pin the commit hash so we don't get other unexpected bleeding edge changes?

Just pushed a commit that pins svd2rust to https://github.com/gkelly/svd2rust/commit/2bbb60590096bcb67c91f38bedd1f63f98132abe, which itself includes an explicit rev for rust-embedded/svd, so no change in either repository can get accidentally used.


Rollback dispatch patch

Reverts AT_DISPATCH_FLOATING_TYPES patch, which lead to a compilation error with the latest version of pytorch and pytorch-nightly
FIxes #601

cc @fmassa

cc @vishwakftw I believe this can be reverted now, given that there was a backward-compatibility fix sent to PyTorch?

Also note that this will be introducing deprecation warnings during compilation time https://github.com/pytorch/pytorch/pull/17996


For the beginner

Hi,
i have this message when i try to run a example class:
"php RetrievePlayerStatsExample.php
For now we only support PHP on 64bit platforms \n"
I work on Windows 10 - 64bit.
Thanks for the API, from France!

Do you have a 64bit PHP version installed? What does echo PHP_INT_SIZE;  give you?

Ok I find the exception in the code but i'm a beginner...
"if (PHP_INT_SIZE !== 8) {
echo 'For now we only support PHP on 64bit platforms \n';
die();

}"
It give me: 4
I work with Laravel and PHP 7.0.0RC2

Yeah, that looks like 32bit. If you want to be sure about the PHP version, see what phpinfo() says about the architecture. You'll have to install a 64bit PHP version if it says x86. There are some guides on the Laragon forum, maybe check there first.

download WAMP64 and install it.
select then php 7 and not php 5.6 and you will have php 64 bit

I install 64 bits PHP version (x64) with laragon but still the same problem.
Thanks @paoloalby it's work with WAMP :)

The code that displays this error is found in the following files:
src\protocolbufferes.inc.php
includes\protocolbuffers.inc.php
You can try commenting it out, but not sure if it's recommended or what implications it will have.
/*
if (PHP_INT_SIZE !== 8) {
echo 'For now we only support PHP on 64bit platforms \n';
die();

}
*/


ENH: Support imblearn

add support for imbalanced-learn under scikit-contrib.
-http://contrib.scikit-learn.org/imbalanced-learn/index.html

Coverage decreased (-0.08%) to 94.661% when pulling 3b5362b2ecc20c71995421fff0e70478799ea319 on sinhrks:imblearn into 0cf0f412f5c14e447bb47249fdb0dc4d2ae136ee on pandas-ml:master.

Coverage decreased (-0.1%) to 94.645% when pulling b1ded9303b95bdaee44bcf97ba962f1df72eeef0 on sinhrks:imblearn into 4fae3488f16459c3d0a881554d34daf7f155e1d9 on pandas-ml:master.

Coverage decreased (-0.1%) to 94.83% when pulling 43ab818d7eedb59ba5137f9370f4de1785582f40 on sinhrks:imblearn into 92a0900b3d1a0ae53aabf30b35be42a581f3f021 on pandas-ml:master.


TypeError: fg.sync is not a function

seeing some site build failure using latest sitemap-ts 1.7.2
1:02:48 PM: build error:
1:02:48 PM: fg.sync is not a function
1:02:48 PM: TypeError: fg.sync is not a function
1:02:48 PM:     at getRoutes (file:///opt/build/repo/node_modules/.pnpm/sitemap-ts@1.7.2/node_modules/sitemap-ts/dist/index.mjs:83:11)
1:02:48 PM:     at generateSitemap (file:///opt/build/repo/node_modules/.pnpm/sitemap-ts@1.7.2/node_modules/sitemap-ts/dist/index.mjs:132:18)
1:02:48 PM:     at Object.buildEnd (file:///opt/build/repo/runatlantis.io/.vitepress/config.ts.timestamp-1716397363039-ee4c35203ed95.mjs:219:5)
1:02:48 PM:     at build (file:///opt/build/repo/node_modules/.pnpm/vitepress@1.2.2_@algolia+client-search@4.23.3_@types+node@20.12.12_sass@1.77.2_search-insights@2.14.0/node_modules/vitepress/dist/node/serve-BwR5EPUJ.js:46795:30)

relates to https://github.com/runatlantis/atlantis/pull/4588

Hi, thanks for your report, i will work on it asap 👍

@chenrui333 Does v1.7.3 fixes this issue ?

yeah, works for me, thanks! (I also switched to npm due to some plugin issue recently)

thanks for the quick turnaround. <3


state.params is undefined in effects

Expected behavior
Effects should have access to the current state.params. Beyond my use case, I'd expect the state passed to effects, reducers, and views to be the same.
Actual behavior
The state that's provided to effects does not include the params property.
Steps to reproduce behavior
Test case: http://requirebin.com/?gist=b0650339f49b3f08bd49812b938d4a66

Looking at the source, it looks like this may have been a design decision because params is only created in the context of the router and only passed to the views. So I'll wait to hear back on whether that was intentional (or if I'm doing it wrong) before digging any deeper.

They should have access to it, this def feels like a bug hmmm - though haven't thought how this interacts with namespaces - what do you think?

params is a reserved namespace already, just like location, no?

it is, though we're not enforcing it

An app I'm building is currently affected by this. The specific use case involves a network request effect that needs to know a slug in the URL's path. I can of course have the effect parse the URL on its own but that seems a bit inelegant. Any thoughts?

@dmotz params.state exists now, and we'll be adding more info in v4 :D

state.location.params exists now (:

Uhmm... how exactly was this solved? state.location.params still isn't available from effects. I searched for params in index.js and aside from a function wrap (which I think what the original poster saw -- this only makes the params available from views), it only appears in createLocationModel which should initialize state.location.params but only to an empty object.
    state: mutate(createLocation(), { params: {} }),


document partial updates

postgres 9.5 actually does allow partial document updates for JSONB fields: https://wiki.postgresql.org/wiki/What's_new_in_PostgreSQL_9.5#JSONB-modifying_operators_and_functions
"In 9.3 (and to a greater extent in 9.4), JSONB data could be extracted using various functions and operators, but nothing that could actually modify the data. As of 9.5, JSONB data can now be modified."
In the massive-js docs: From: http://massive-js.readthedocs.io/en/latest/document_queries/
"You can update as well - but PostgreSQL does not support partial updates, so if you do an update it's a full swap. We're considering supporting partial updates at the code level (basically running a diff) - but this can be quite difficult to get right. For now, it's a full replace:"
... so question: Does massive-js now support partial JSONB updates too, when run against a postgres 9.5 database? If not, can we add support for this?

The documentation is out of date -- there's a setAttribute (id, key, val, next) function which uses jsonb_set to update.

@dmfay The documentations is ... a little sparse on setAttribute too: http://massive-js.readthedocs.io/en/latest/API/json_documents/
(it only has the function signature, and nothing else)

I added some more information to http://massive-js.readthedocs.io/en/latest/document_queries/ but feel free to update the API docs too!

Additionally, I'd like to be able to do a document update with a query (not just the ID), for example
db.doggies.setAttribute({
  sex: 'male'
}, 'name', 'rover', (err, result) => { /* ... */ });

(note that this implies being able to update multiple documents with one query)
Further to this, I'd like to be able to set multiple attributes at the same time
db.doggies.setAttribute({
  name: 'rover',
}, {
  sex: 'female',
  kennel: 123,
}, (err, result) => { /* ... */ });

From what I understand about jsonb_set, this may require multiple statements, and therefore a multi-statement transaction of some sort.

@dmfay should I open a new ticket for the above since you've closed this one?

yes, please do. In the mean time you could use a script or function, if you don't need to be flexible with what you're setting.


Skip instead of fail if helm directory is absent

Hi,
Not every submodule in a multi-module maven project has/requires helm charts.
I suggest adding a parameter to skip projects that do not have src/main/helm folder automatically.
The existing <skip> option forces me to replicate plugin's configuration across multiple submodules in order to explicitly specify which submodule should be skipped or not.

Hi; thanks for your input and for using the helm-maven-plugin!  I appreciate the time you took to file this issue.
There isn't anywhere in the codebase that requires a src/main/helm directory, either as a hard coded value or a default.
I'll play around with a multimodule situation, however, and see if I can get at the "spirit" of this issue; maybe there is an option or two I could add to make them easier.

I think what you may be getting at can be found here: https://github.com/microbean/helm-maven-plugin/blob/v<IP_ADDRESS>.0.33/src/main/java/org/microbean/helm/maven/InstallReleaseMojo.java#L183-L192
I do in spirit like the idea of a lenient parameter or something similar to simply skip execution if required bits are missing (with a warning of course).

Hi @ljnelson,
And thank you for this contribution!
Sorry for the unrefined submission. I will try to address this now.
My use case for helm maven plugin is a typical multi-module maven project. The root pom.xml defines common dependencies versions which are then inherited by modules. The modules can always override the settings if need be. The idea is to reduce code repetition and increase consistency across modules.
Having said the above, it would be great if I could define defaults for helm:* goals and run them either against all modules mvn helm:* or just against a specific one -pl module. Since not every module may require/have helm charts, it would be convenient to have an option to skip such modules. At the moment the workaround is to reintroduce plugin configuration in modules without helm charts and add the  tag:
                <configuration>
                    <version>1</version> <-- mandatory
                    <releaseName>${project.artifactId}</releaseName> <-- mandatory
                    <skip>true</skip>
                </configuration>

However, besides the skip tag I have to re-specify mandatory version and releaseName values as well. Note that contrary to the usage guide, I am not associating the confguration with a maven phase - I am using the confguration tag outside the execution tag.
As an alternative to the above, the lenient parameter with the behaviour as you described could do the trick. In my opinion, this should apply to all relevant operations, e.g. package, install. An example of a similar behaviour is asciidoctor maven plugin for asciidoc processing. If the directory does not exist, it simply emits the following line and continues:
[INFO] sourceDirectory /Users/.../src/docs/asciidoc does not exist. Skip processing
PS. The src/main/helm path was specified by me.
I have just checked Helm conventions and realised that my decision to change the default chart path was wrong. The default path, specified in the plugin code, looks like the best approach. Although specifying chart folder name as ${project.artifactId} feels redundant (if we consider a single-chart folder).