Add support for labels and taints to HostedCP NodePools

This covers both creation and modification. The UX should be the same as Classic ROSA.
Related: SDA-8219

Draft pending https://gitlab.cee.redhat.com/service/uhc-clusters-service/-/merge_requests/5313

/hold

/unhold

lgtm.
Did you check machine pools labels & taint flows weren't broken?

lgtm. Did you check machine pools labels & taint flows weren't broken?
not yet. let me check with a classic cluster before proceeding with a merge

@zgalor checked a non-hypershift cluster, working as expected

/lgtm


Fix URL hardcode on replication service

Url hardcoded in replication service. This commit is to fix it.

Coverage increased (+0.05%) to 64.497% when pulling 8a142aac71f507f7df58828ad34052e672f7cd1f on ninjadq:fix_url_hardcode_on_replication into c4afac84607f64ce054803abd11b16be92220266 on vmware:release-1.5.0.


Cannot destructure property 'title' of 'projectDetail' as it is undefined.

when labelling feature: false for a project then there is a showing:
Cannot destructure property 'title' of 'projectDetail' as it is undefined.

even whenever i try to add more than 6 projects this error occurs, without even using "feature" in info.ts as keeping it default as true

try replacing
const featureProjects = info.projects.map((project, index) => {   if (project.isFeatured && index < 6) {     return project;   } });
with this
const featureProjects = info.projects.reduce((featureProjects, project, index) => {   if (project.isFeatured && index < 6) {     featureProjects.push(project)   }   return featureProjects },[]);
in pages/index.astro

it also worked for me to just replace
const featureProjects = info.projects.map(
with
const featureProjects = info.projects.filter(

#4

can you create a PR for this ?


Adding new language to authentication: JAPANESE

Explain your changes
Added Japanese as a language for authentication
Checklist

[x] I have read the “Pull requests” section in the contributing guidelines.
[x] I agree to the terms within the code of conduct.

Awesome, thank you for your contribution @kk4w4i


Can eosio-cpp add more examples?

1.3.0 modified is too big compared to the previous changes, a little can not keep up ~

Yes, also the usage section in the current readme is outdated:

Specifically for Multiindex, because it has only basic example. But how to use secondary indexes properly?

Agreed, secondary indexes is very important but totally ignored in docs.
This is in your struct:
uint64_t bysecondary() const { return secondary_id; }

This is your index typedef.
typedef eosio::multi_index<"tablename"_n, commits, indexed_by<"bysecondary"_n, const_mem_fun<tableclass, secondarykeytype, &tableclass::bysecondary> > > tb_something_by_secondary;
Everywhere you had N() macro - "name"_n should be used. But remember to NOT use underscore anywhere in those names of indices and tables. by_secondary() won't work.

eosio-cpp 1.3.2 made significant changes... no N()-Makro, other contructor and Makros so the old written contracts are not compatible with EOSIO.CDT 1.3.2. Can eosio-cpp provide an example with 1) apply-method for receiving token, create an object and call functions of this class? 2) Send an EOS-transaction, 3) Write and read an multi index-table. This 3 functions are crucial for every smart-contract. The Example of developers.eos.com f.e. suggests:
void apply(uint64_t receiver, uint64_t code, uint64_t action)  {   addressbook _addressbook(receiver);... This instantiation throws an error: "error: no matching constructor for initialization of 'addressbook'"

Examples of how to use multi-index are now in eosio.cdt.


Preserve original commit timestamp when rebasing

The goal here is to make the commit ID of the rebased commit consistent
every time (both between topics and between git-branchstack runs),
which combined with --trim-subject enables workflows like building
chains of GitHub pull requests.
In a perfect world maybe we'd use the current user's name/email in the
committer field and just keep the timestamp from the original commit,
but it doesn't seem like there's a simple way to do that with
git-revise right now. In practice I assume the author and committer
will usually be the same person with this workflow anyway.

BTW I'm curious about the intended workflow without --trim-subject enabled, and specifically I was wondering whether it might make sense to make it the default. I guess maybe the idea is that reviewers can use the topic tags on the ancestor commits as a signal to ignore those commits when reviewing? It seems annoying to merge a branch that has those extraneous non-canonical commits in it though, right?

I guess maybe the idea is that reviewers can use the topic tags on the ancestor commits as a signal to ignore those commits when reviewing?

Exactly.
It really depends on how people want to use it. We can definitely add a config option and maybe change default if there is a use case.
Though IME dependencies are not so common, so I wouldn't overthink it. I prefer submitting small, independent branches.
If there are dependencies, then it's nice to clearly mark the fact (that this is not yet for merging).
One thing that might help reviewers is to add links (to dependent PRs) instead of branch names.
That could be scripted with git-revise -ie --ref some-branch.
Of course dependencies are really nice to quickly brew up experimental branches that combine my and others' changes.
So for my use I usually don't mind the topic tags - they are helpful reminders.

It seems annoying to merge a branch that has those extraneous non-canonical commits in it though, right?

Right. Sometimes two branches depend on the same commit (which for whatever reason is not merged separately).
For that case I added the :+ dependency syntax as alternative to :, to imply --trim-subject.

Thanks!

If there are dependencies, then it's nice to clearly mark the fact (that this is not yet for merging).

Ah, I see, this definitely helps me understand better. If you're assuming that you'll need to rebase and re-push a branch after merging its dependencies, it doesn't really matter whether it temporarily has tagged commits in it before then.
The cool thing about using --trim-subject and sharing commits between branches is that, when you do want a chain of related PRs, it plays better with GitHub's UI. You can make each PR use the previous one as its merge base, which has a couple of nice consequences:

The "Files changed" view in GH will show all of (and only) the changes that are specific to this PR relative to its parent.
If you merge the parent PR, GH will automatically update the merge base of its immediate children to point to master, and you can then merge the child PR if you want without needing to rebase, go through CI again, or otherwise do any branch maintenance first.

I agree that it's not super common to need such a heavy workflow, but that's definitely the situation where I've most felt the need for a tool like branchstack, so I'm looking forward to taking advantage of it. Thanks for the merge!

Right, in the common case where each topic has at most one dependency, the created branch can actually be based on its dependency (since we now reuse the committer date).
I totally forgot about targetting pull-requests against earlier branches in the chain. I used to do that but stopped because it confused people :( but it's the natural, obvious choice.
Done with 8849303 (Make --trim-subject the default and add --keep-tags to not trim subjects, 2021-11-09)

when using commit.gpgSign, we get nondeterministic commit IDs by design.
Then it's better to use git worktree add


How to  random Allow UDP Port corresponding to Webrtc connections to subdomains

How to allow WebRtc Streams coming on Random UDP ports tunneled properly?

Hi @manjurajv, unfortunately since boringproxy is built on SSH it doesn't support UDP. I'd recommend checking some of the other solutions here: https://github.com/anderspitman/awesome-tunneling

The pointed link was helpful @anderspitman


Webpack EnvironmentPlugin errors

Describe the bug
local app unable to compile unless lines 90-97 are commented out
error message:
6 WARNINGS in child compilations (Use 'stats.children: true' resp. '--stats-children' for more details)

ERROR in EnvironmentPlugin - AVATAAR_URL environment variable is undefined.

You can pass an object with default values to suppress this warning.
See https://webpack.js.org/plugins/environment-plugin for example.

ERROR in EnvironmentPlugin - DEFAULT_SEO_IMAGE environment variable is undefined.

You can pass an object with default values to suppress this warning.
See https://webpack.js.org/plugins/environment-plugin for example.

ERROR in EnvironmentPlugin - GA_TRACKING_CODE environment variable is undefined.

You can pass an object with default values to suppress this warning.
See https://webpack.js.org/plugins/environment-plugin for example.

ERROR in EnvironmentPlugin - MIXPANEL_TOKEN environment variable is undefined.

You can pass an object with default values to suppress this warning.
See https://webpack.js.org/plugins/environment-plugin for example.

ERROR in EnvironmentPlugin - PLAYGROUND_API environment variable is undefined.

You can pass an object with default values to suppress this warning.
See https://webpack.js.org/plugins/environment-plugin for example.

ERROR in EnvironmentPlugin - SENTRY_DSN environment variable is undefined.

You can pass an object with default values to suppress this warning.
See https://webpack.js.org/plugins/environment-plugin for example.

To Reproduce

clone repo
follow readme instructions
call npm run start
check console

Desktop (please complete the following information):

OS: MacOS Montery V 12.4
Browser chrome
Version 104.0.5112.101 (Official Build) (arm64)

Additional context

possible webpack v5 context: https://github.com/webpack/changelog-v5#automatic-nodejs-polyfills-removed

Issue only occurs on node v17+

Need to test upgrading to v18.


[PYTHON][PS] Fix the .groupby() method docstring

What changes were proposed in this pull request?

Update the docstring for the .groupby() method.
Why are the changes needed?

The .groupby() method accept a list of columns (or a single column), and a column is defined by a Series or name (Label). It's a bit confusing to say "using a Series of columns", because Series (capitalized) is a specific object that isn't actually used/reasonable to use here.
Does this PR introduce any user-facing change?

Yes (documentation)
How was this patch tested?

N/A

Not sure why the Build job is failing; Actions are enabled on my fork, and I did run the following, as specified in the failed job, just in case:
git fetch upstream
git rebase upstream/master
git push origin YOUR_BRANCH --force

Can one of the admins verify this patch?

@deepyaman  I guess you need to Go to “Actions” tab on your forked repository and enable “Build and test” and “Report test results” workflows
also please file a jira ticket for this pr, thanks

Merged to master, branch-3.4, branch-3.3 and branch-3.2.


Nolan's proofread

I think most of these are stylistic, so please feel free to ignore 😅

Thank you Nolan. Looks good to me!

Thanks, Nolan!


[BUG] Example from readme does not work on windows

Description
manim-slides and manim are installed in a virtual environment via conda.
Trying to run the BasicExample from the readme gives
(c:\Users\voelker\Documents\CFFAP\Manim\testing\.conda) PS C:\Users\voelker\Documents\CFFAP\Manim\testing> .\.conda\Scripts\manim-slides.exe render scene.py BasicExample
Usage: manim-slides present [OPTIONS] [SCENES]...

Error: Invalid value for '--folder': Directory 'slides' does not exist.

Creating the missing folder instead gives
(c:\Users\voelker\Documents\CFFAP\Manim\testing\.conda) PS C:\Users\voelker\Documents\CFFAP\Manim\testing> .\.conda\Scripts\manim-slides.exe render scene.py
Usage: manim-slides present [OPTIONS] [SCENES]...

Error: File slides\render.json does not exist, check the scene name and make sure to use Slide as your scene base class

Using present instead of render also does not help:
(c:\Users\voelker\Documents\CFFAP\Manim\testing\.conda) PS C:\Users\voelker\Documents\CFFAP\Manim\testing> .\.conda\Scripts\manim-slides.exe present scene.py BasicExample
Usage: manim-slides present [OPTIONS] [SCENES]...

Error: File slides\scene.py.json does not exist, check the scene name and make sure to use Slide as your scene base class

Version
5.0.0
Platform
Windows
Screenshots
No response
Additional information
No response

Hello @MarcusVoelker, creating those file manually will not help, as they need to be generated during the rendering process :-)
The command \.conda\Scripts\manim-slides.exe render scene.py BasicExample will only work as of Manim Slides v5.1, which I hope to release soon, sorry for the mismatch between documentation and releases :/

In the meantime, you can render using manim render scene.py BasicExample and present after.
The render command was added in v5.1.

creating those file manually will not help, as they need to be generated during the rendering process :-)

I figured, but I thought I'd include that I tried it, covering all bases.

In the meantime, you can render using manim render scene.py BasicExample and present after.

Yep, that works beautifully, thanks for the quick reply!

Hi @MarcusVoelker , just to notice you that v5.1 was just released :)


impl Fn(X) -> Y for dyn Fn(X) -> Y

I write some code that is generic on an Fn:
struct S<F: Fn() -> ()> {
    f: F,
}

Now for some cases (in particular, having this as an explicit return type), I need to be able to use dynamic dispatch sometimes.
fn f() -> S<Box<dyn Fn() -> ()>> {
    ...
}

This doesn't work because (it would seem?) dyn Fn(X) -> Y does not implement Fn(X) -> Y.

Could we implement Fn(X) -> Y for dyn Fn(X) -> Y ?
What would be a workaround in the meantime ?

(Currently using stable rust, 1.42)

seems to work fine

Hmm I had tried several times and got compile errors all the time but now this indeed seems to work, sorry for this !


CI: run mutate test parallel

Codecov Report
Base: 58.62% // Head: 58.52% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (0c80a50) compared to base (0b1d787).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 0c80a50 differs from pull request most recent head fe499b7. Consider uploading reports for the commit fe499b7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3034      +/-   ##
==========================================
- Coverage   58.62%   58.52%   -0.10%
==========================================
  Files         141      141
  Lines       24730    24732       +2
==========================================
- Hits        14498    14475      -23
- Misses       8341     8361      +20
- Partials     1891     1896       +5

Impacted Files
Coverage Δ

pkg/utils/utils.go
74.07% <100.00%> (ø)

pkg/vfs/reader.go
75.42% <0.00%> (-3.58%)
:arrow_down:

pkg/meta/tkv_mem.go
86.80% <0.00%> (-0.70%)
:arrow_down:

pkg/meta/sql.go
63.20% <0.00%> (-0.38%)
:arrow_down:

pkg/meta/base.go
66.38% <0.00%> (-0.16%)
:arrow_down:

pkg/vfs/handle.go
85.56% <0.00%> (ø)

pkg/meta/redis.go
69.01% <0.00%> (+0.04%)
:arrow_up:

pkg/chunk/disk_cache.go
74.35% <0.00%> (+0.39%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CustomFieldTranslation in artifact_metadata.json causes deploysourcetoorg Task to fail

Describe the bug
Since Friday 25 August, our pipelines have been failing. The "CustomFieldTranslation" metadata is now included in the artifact_metadata.json and it seems it's causing the deploysourcetoorg task to fail (see screenshots).
According to the Metadata Coverage docs, "CustomFieldTranslation" is not supported in the Metadata API. Should it be included in the metadata file of the package?
Screenshots

Platform Details (please complete the following information):

OS: Ubuntu 18.04
Salesforce CLI(sfdx cli) Version<EMAIL_ADDRESS>(installed with sfpwowerscript-installsfdx-task@7 )
CI Platform: Azure Devops sfpowerscripts extension 18.0.62 (Latest)
Tasks: sfpwowerscripts-createsourcepackage-task@14 / sfpowerscript-deploysourcetoorg-task@10

Additional context
No update has been made to the task versions.
We've tested on a commit that had previously resulted in a successful package deployment.

@extravio This could be an issue with sfdx cli version. Recommended to use 7.110.0 at this stage and using a docker image.
Also FYI, azure pipelines task are deprecated long time ago.  You might need to switch to the CLI


6.1.0b1: commission_with_code fails (AttestationVerification)?

I'm testing 6.1.0b1 and I'm unable to commission a new node.
This is how I have tested:

Form a new OTBR Thread Network
Started with a new blank data directory
Run Python Matter Server 6.1.0b1
Flash a Matter over Thread test device with it's firmware

Running a test program issuing Python Matter Server commands like this:
info: MatterServerAdmin.Program[0]
MatterServerClient.ConnectAsync: Connecting to Python Matter Server 'ws://<IP_ADDRESS>:5580/ws'.
info: MatterServerAdmin.Program[0]
MatterServerClient.ConnectAsync: Successfully connected to Python Matter Server 'ws://<IP_ADDRESS>:5580/ws'.
info: MatterServerAdmin.Program[0]
MatterServerClient.ReceiveFromWebSocket: 225 bytes received.
info: MatterServerAdmin.Program[0]
Received response:
{
"fabric_id": 1,
"compressed_fabric_id":<PHONE_NUMBER>3607323429,
"schema_version": 9,
"min_supported_schema_version": 5,
"sdk_version": "2024.5.1",
"wifi_credentials_set": false,
"thread_credentials_set": false
}
info: MatterServerAdmin.Program[0]
MatterServerClient.SendCommandAsync: Sending command:
{
"message_id": "1",
"command": "start_listening"
}
info: MatterServerAdmin.Program[0]
MatterServerClient.ReceiveFromWebSocket: 39 bytes received.
info: MatterServerAdmin.Program[0]
Received response:
{
"message_id": "1",
"result": []
}
info: MatterServerAdmin.Program[0]
MatterServerClient.SendCommandAsync: Sending command:
{
"message_id": "2",
"command": "set_thread_dataset",
"args": {
"dataset": "0e080000000000010000000300001935060004001fffe00208946babdc5ae751590708fdf91ee8b684b7d305106f571e9b46a64030f2c28639df24ea26030f4f70656e5468726561642d31336338010213c8041017ea4e71b5357f846dd4244c31630bb50c0402a0f7f8"
}
}
info: MatterServerAdmin.Program[0]
MatterServerClient.ReceiveFromWebSocket: 41 bytes received.
info: MatterServerAdmin.Program[0]
Received response:
{
"message_id": "2",
"result": null
}
info: MatterServerAdmin.Program[0]
MatterServerClient.SendCommandAsync: Sending command:
{
"message_id": "3",
"command": "commission_with_code",
"args": {
"code": "34970112332"
}
}
info: MatterServerAdmin.Program[0]
MatterServerClient.ReceiveFromWebSocket: 98 bytes received.
info: MatterServerAdmin.Program[0]
Received response:
{
"message_id": "3",
"error_code": 1,
"details": "Commission with code failed for node 1."
}
As you see, the "commission_with_code" command fails.
This is the log from Python Matter Server:
2024-05-30 09:25:29.712 (MainThread) INFO [matter_server.server.stack] Initializing CHIP/Matter Logging...
2024-05-30 09:25:29.712 (MainThread) INFO [matter_server.server.stack] Initializing CHIP/Matter Controller Stack...
[1717061129.781291][1:1] CHIP:CTL: Setting attestation nonce to random value
[1717061129.781670][1:1] CHIP:CTL: Setting CSR nonce to random value
[1717061129.783194][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_kvs
[1717061129.783675][1:1] CHIP:DL: writing settings to file (/tmp/chip_kvs-lQpuxj)
[1717061129.783796][1:1] CHIP:DL: renamed tmp file to file (/tmp/chip_kvs)
[1717061129.784123][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_factory.ini
[1717061129.784231][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-jD1Z5i)
[1717061129.784305][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717061129.784344][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_config.ini
[1717061129.784406][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-MEvVPf)
[1717061129.784463][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717061129.784495][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_counters.ini
[1717061129.784549][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-deNWRh)
[1717061129.784604][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717061129.785018][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-cmzBkg)
[1717061129.785345][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717061129.785378][1:1] CHIP:DL: NVS set: chip-factory/unique-id = "D1F98AF1E9805B14"
[1717061129.785535][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-WZLheh)
[1717061129.786516][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717061129.786548][1:1] CHIP:DL: NVS set: chip-factory/vendor-id = 65521 (0xFFF1)
[1717061129.786686][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-FaQTgh)
[1717061129.786945][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717061129.786969][1:1] CHIP:DL: NVS set: chip-factory/product-id = 32769 (0x8001)
[1717061129.787123][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-wr6F9f)
[1717061129.787317][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717061129.787340][1:1] CHIP:DL: NVS set: chip-counters/reboot-count = 1 (0x1)
[1717061129.787490][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-ip7r9h)
[1717061129.787701][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717061129.787722][1:1] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1717061129.787902][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-1UJisf)
[1717061129.788118][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717061129.788140][1:1] CHIP:DL: NVS set: chip-counters/boot-reason = 0 (0x0)
[1717061129.788285][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-q7LRGh)
[1717061129.788464][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717061129.788486][1:1] CHIP:DL: NVS set: chip-config/regulatory-location = 0 (0x0)
[1717061129.788627][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-Pdjtcf)
[1717061129.788826][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717061129.788847][1:1] CHIP:DL: NVS set: chip-config/location-capability = 2 (0x2)
[1717061129.789240][1:1] CHIP:DL: Got Ethernet interface: eth0
[1717061129.789396][1:1] CHIP:DL: Found the primary Ethernet interface:eth0
[1717061129.789555][1:1] CHIP:DL: Got WiFi interface: wlan0
[1717061129.789589][1:1] CHIP:DL: Failed to reset WiFi statistic counts
2024-05-30 09:25:29.790 (MainThread) WARNING [PersistentStorage] Initializing persistent storage from file: /data/chip.json
2024-05-30 09:25:29.790 (MainThread) ERROR [root] [Errno 2] No such file or directory: '/data/chip.json'
2024-05-30 09:25:29.790 (MainThread) CRITICAL [root] Could not load configuration from /data/chip.json - resetting configuration...
2024-05-30 09:25:29.791 (MainThread) WARNING [root] No valid SDK configuration present - clearing out configuration
2024-05-30 09:25:29.791 (MainThread) WARNING [root] No valid REPL configuration present - clearing out configuration
2024-05-30 09:25:29.996 (MainThread) WARNING [CertificateAuthorityManager] Loading certificate authorities from storage...
2024-05-30 09:25:29.997 (MainThread) WARNING [CertificateAuthority] New CertificateAuthority at index 1
2024-05-30 09:25:30.005 (MainThread) WARNING [FabricAdmin] New FabricAdmin: FabricId: 0x0000000000000001, VendorId = 0xFFF1
2024-05-30 09:25:30.005 (MainThread) INFO [matter_server.server.stack] CHIP Controller Stack initialized.
2024-05-30 09:25:30.005 (MainThread) WARNING [FabricAdmin] Allocating new controller with CaIndex: 1, FabricId: 0x0000000000000001, NodeId: 0x000000000001B669, CatTags: []
2024-05-30 09:25:30.052 (MainThread) INFO [matter_server.server.server] Starting the Matter Server...
2024-05-30 09:25:30.059 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetching the latest PAA root certificates from DCL.
2024-05-30 09:25:32.951 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 58 PAA root certificates from DCL.
2024-05-30 09:25:41.625 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 74 PAA root certificates from Test DCL.
2024-05-30 09:25:41.626 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetching the latest PAA root certificates from Git.
2024-05-30 09:25:42.602 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 5 PAA root certificates from Git.
2024-05-30 09:25:42.606 (MainThread) INFO [matter_server.server.device_controller] Loaded 0 nodes from stored configuration
2024-05-30 09:25:42.619 (MainThread) INFO [matter_server.server.vendor_info] Loading vendor info from storage.
2024-05-30 09:25:42.619 (MainThread) INFO [matter_server.server.vendor_info] Loaded 0 vendors from storage.
2024-05-30 09:25:42.619 (MainThread) INFO [matter_server.server.vendor_info] Fetching the latest vendor info from DCL.
2024-05-30 09:25:42.848 (MainThread) INFO [matter_server.server.vendor_info] Fetched 196 vendors from DCL.
2024-05-30 09:25:42.848 (MainThread) INFO [matter_server.server.vendor_info] Saving vendor info to storage.
2024-05-30 09:28:10.390 (MainThread) INFO [matter_server.server.device_controller] Starting Matter commissioning with code using Node ID 1 (attempt 1/3).
2024-05-30 09:28:13.312 (Dummy-2) INFO [root] Established secure session with Device
2024-05-30 09:28:14.890 (Dummy-2) CHIP_ERROR [chip.native.CTL] Failed in verifying 'Attestation Information' command received from the device: err 101. Look at AttestationVerificationResult enum to understand the errors
2024-05-30 09:28:14.892 (Dummy-2) CHIP_ERROR [chip.native.CTL] Error on commissioning step 'AttestationVerification': 'src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error'
2024-05-30 09:28:17.019 (Dummy-2) WARNING [root] Failed to commission: src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error
2024-05-30 09:28:17.021 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 2050 ms, for event type 16389
2024-05-30 09:28:17.021 (Dummy-2) CHIP_ERROR [chip.native.BLE] no endpoint for unsub complete
2024-05-30 09:28:22.021 (MainThread) INFO [matter_server.server.device_controller] Starting Matter commissioning with code using Node ID 1 (attempt 2/3).
2024-05-30 09:28:24.260 (Dummy-2) INFO [root] Established secure session with Device
2024-05-30 09:28:25.691 (Dummy-2) CHIP_ERROR [chip.native.CTL] Failed in verifying 'Attestation Information' command received from the device: err 101. Look at AttestationVerificationResult enum to understand the errors
2024-05-30 09:28:25.692 (Dummy-2) CHIP_ERROR [chip.native.CTL] Error on commissioning step 'AttestationVerification': 'src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error'
2024-05-30 09:28:28.016 (Dummy-2) WARNING [root] Failed to commission: src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error
2024-05-30 09:28:28.017 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 2247 ms, for event type 16389
2024-05-30 09:28:28.018 (Dummy-2) CHIP_ERROR [chip.native.BLE] no endpoint for unsub complete
2024-05-30 09:28:33.021 (MainThread) INFO [matter_server.server.device_controller] Starting Matter commissioning with code using Node ID 1 (attempt 3/3).
2024-05-30 09:28:35.306 (Dummy-2) INFO [root] Established secure session with Device
2024-05-30 09:28:36.688 (Dummy-2) CHIP_ERROR [chip.native.CTL] Failed in verifying 'Attestation Information' command received from the device: err 101. Look at AttestationVerificationResult enum to understand the errors
2024-05-30 09:28:36.688 (Dummy-2) CHIP_ERROR [chip.native.CTL] Error on commissioning step 'AttestationVerification': 'src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error'
2024-05-30 09:28:39.011 (Dummy-2) WARNING [root] Failed to commission: src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error
2024-05-30 09:28:39.011 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 2243 ms, for event type 16389
2024-05-30 09:28:39.011 (Dummy-2) CHIP_ERROR [chip.native.BLE] no endpoint for unsub complete
2024-05-30 09:28:39.013 (MainThread) ERROR [matter_server.server.client_handler] [547678530576] Error while handling: commission_with_code: Commission with code failed for node 1.
Then I reset everything (blank data directory, new OTBR Thread network, re-flashed test device) and testet with Python Matter Server 6.0.1.
The exact same test works with 6.0.1.
Does the commission process now requires the device to have a valid certificate?
It should be possible to commission test devices.

The comisisoning always requires a valid certificate, even test devices. It has always been that way and it will always stay that way. You can use any of the SDK/CSA test certificates while still testing. We even pull in the test certificates from github at startup.

Ok, but something changed between 6.0.1 and 6.1.0b1.
I can commission my test device with 6.0.1, but not with 6.1.0b1.
I can even commission this test device with Apple Home.
Right now 6.1.0b1 is not usable for me.

Testing again with 6.1.0b2 with same issue:
2024-06-03 17:45:58.717 (MainThread) INFO [matter_server.server.stack] Initializing CHIP/Matter Logging...
2024-06-03 17:45:58.718 (MainThread) INFO [matter_server.server.stack] Initializing CHIP/Matter Controller Stack...
[1717436758.789071][1:1] CHIP:CTL: Setting attestation nonce to random value
[1717436758.789788][1:1] CHIP:CTL: Setting CSR nonce to random value
[1717436758.791866][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_kvs
[1717436758.792424][1:1] CHIP:DL: writing settings to file (/tmp/chip_kvs-DC8pAh)
[1717436758.792596][1:1] CHIP:DL: renamed tmp file to file (/tmp/chip_kvs)
[1717436758.792955][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_factory.ini
[1717436758.793131][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-PJBnbh)
[1717436758.793233][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717436758.793294][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_config.ini
[1717436758.793391][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-gcBJIi)
[1717436758.793474][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717436758.793536][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_counters.ini
[1717436758.793624][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-5DrFkf)
[1717436758.793705][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717436758.794234][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-IRbagj)
[1717436758.794571][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717436758.794600][1:1] CHIP:DL: NVS set: chip-factory/unique-id = "55AFBF74902A66B2"
[1717436758.794802][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-EybuGh)
[1717436758.797109][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717436758.797143][1:1] CHIP:DL: NVS set: chip-factory/vendor-id = 65521 (0xFFF1)
[1717436758.797365][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-TYd0Bf)
[1717436758.797635][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717436758.797659][1:1] CHIP:DL: NVS set: chip-factory/product-id = 32769 (0x8001)
[1717436758.797858][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-gW3cdi)
[1717436758.798092][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717436758.798114][1:1] CHIP:DL: NVS set: chip-counters/reboot-count = 1 (0x1)
[1717436758.798317][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-3kTFUf)
[1717436758.798571][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717436758.798595][1:1] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1717436758.798786][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-o4CEqj)
[1717436758.799041][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717436758.799064][1:1] CHIP:DL: NVS set: chip-counters/boot-reason = 0 (0x0)
[1717436758.799258][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-soKTRe)
[1717436758.799487][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717436758.799510][1:1] CHIP:DL: NVS set: chip-config/regulatory-location = 0 (0x0)
[1717436758.799707][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-Qhmrpj)
[1717436758.799961][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717436758.799984][1:1] CHIP:DL: NVS set: chip-config/location-capability = 2 (0x2)
[1717436758.800374][1:1] CHIP:DL: Got Ethernet interface: eth0
[1717436758.800575][1:1] CHIP:DL: Found the primary Ethernet interface:eth0
[1717436758.800780][1:1] CHIP:DL: Got WiFi interface: wlan0
[1717436758.800814][1:1] CHIP:DL: Failed to reset WiFi statistic counts
2024-06-03 17:45:58.801 (MainThread) WARNING [PersistentStorage] Initializing persistent storage from file: /data/chip.json
2024-06-03 17:45:58.802 (MainThread) ERROR [root] [Errno 2] No such file or directory: '/data/chip.json'
2024-06-03 17:45:58.802 (MainThread) CRITICAL [root] Could not load configuration from /data/chip.json - resetting configuration...
2024-06-03 17:45:58.802 (MainThread) WARNING [root] No valid SDK configuration present - clearing out configuration
2024-06-03 17:45:58.802 (MainThread) WARNING [root] No valid REPL configuration present - clearing out configuration
2024-06-03 17:45:59.007 (MainThread) WARNING [CertificateAuthorityManager] Loading certificate authorities from storage...
2024-06-03 17:45:59.007 (MainThread) WARNING [CertificateAuthority] New CertificateAuthority at index 1
2024-06-03 17:45:59.016 (MainThread) WARNING [FabricAdmin] New FabricAdmin: FabricId: 0x0000000000000001, VendorId = 0xFFF1
2024-06-03 17:45:59.016 (MainThread) INFO [matter_server.server.stack] CHIP Controller Stack initialized.
2024-06-03 17:45:59.017 (MainThread) WARNING [FabricAdmin] Allocating new controller with CaIndex: 1, FabricId: 0x0000000000000001, NodeId: 0x000000000001B669, CatTags: []
2024-06-03 17:45:59.063 (MainThread) INFO [matter_server.server.server] Starting the Matter Server...
2024-06-03 17:45:59.070 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetching the latest PAA root certificates from DCL.
2024-06-03 17:46:02.156 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 58 PAA root certificates from DCL.
2024-06-03 17:46:10.892 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 74 PAA root certificates from Test DCL.
2024-06-03 17:46:10.893 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetching the latest PAA root certificates from Git.
2024-06-03 17:46:12.126 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 5 PAA root certificates from Git.
2024-06-03 17:46:12.130 (MainThread) INFO [matter_server.server.device_controller] Loaded 0 nodes from stored configuration
2024-06-03 17:46:12.145 (MainThread) INFO [matter_server.server.vendor_info] Loading vendor info from storage.
2024-06-03 17:46:12.145 (MainThread) INFO [matter_server.server.vendor_info] Loaded 0 vendors from storage.
2024-06-03 17:46:12.146 (MainThread) INFO [matter_server.server.vendor_info] Fetching the latest vendor info from DCL.
2024-06-03 17:46:12.407 (MainThread) INFO [matter_server.server.vendor_info] Fetched 197 vendors from DCL.
2024-06-03 17:46:12.408 (MainThread) INFO [matter_server.server.vendor_info] Saving vendor info to storage.
2024-06-03 17:50:23.413 (MainThread) INFO [matter_server.server.device_controller] Starting Matter commissioning with code using Node ID 1 (attempt 1/3).
2024-06-03 17:50:26.118 (Dummy-2) INFO [root] Established secure session with Device
2024-06-03 17:50:27.500 (Dummy-2) CHIP_ERROR [chip.native.CTL] Failed in verifying 'Attestation Information' command received from the device: err 101. Look at AttestationVerificationResult enum to understand the errors
2024-06-03 17:50:27.502 (Dummy-2) CHIP_ERROR [chip.native.CTL] Error on commissioning step 'AttestationVerification': 'src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error'
2024-06-03 17:50:30.020 (Dummy-2) WARNING [root] Failed to commission: src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error
2024-06-03 17:50:30.022 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 2440 ms, for event type 16389
2024-06-03 17:50:30.023 (Dummy-2) CHIP_ERROR [chip.native.BLE] no endpoint for unsub complete
2024-06-03 17:50:35.025 (MainThread) INFO [matter_server.server.device_controller] Starting Matter commissioning with code using Node ID 1 (attempt 2/3).
2024-06-03 17:50:37.396 (Dummy-2) INFO [root] Established secure session with Device
2024-06-03 17:50:38.806 (Dummy-2) CHIP_ERROR [chip.native.CTL] Failed in verifying 'Attestation Information' command received from the device: err 101. Look at AttestationVerificationResult enum to understand the errors
2024-06-03 17:50:38.807 (Dummy-2) CHIP_ERROR [chip.native.CTL] Error on commissioning step 'AttestationVerification': 'src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error'
2024-06-03 17:50:41.053 (Dummy-2) WARNING [root] Failed to commission: src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error
2024-06-03 17:50:41.054 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 2147 ms, for event type 16389
2024-06-03 17:50:41.055 (Dummy-2) CHIP_ERROR [chip.native.BLE] no endpoint for unsub complete
2024-06-03 17:50:46.057 (MainThread) INFO [matter_server.server.device_controller] Starting Matter commissioning with code using Node ID 1 (attempt 3/3).
2024-06-03 17:50:48.136 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 103 ms, for event type 16389
2024-06-03 17:50:48.372 (Dummy-2) INFO [root] Established secure session with Device
2024-06-03 17:50:49.755 (Dummy-2) CHIP_ERROR [chip.native.CTL] Failed in verifying 'Attestation Information' command received from the device: err 101. Look at AttestationVerificationResult enum to understand the errors
2024-06-03 17:50:49.755 (Dummy-2) CHIP_ERROR [chip.native.CTL] Error on commissioning step 'AttestationVerification': 'src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error'
2024-06-03 17:50:52.027 (Dummy-2) WARNING [root] Failed to commission: src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error
2024-06-03 17:50:52.028 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 2195 ms, for event type 16389
2024-06-03 17:50:52.029 (Dummy-2) CHIP_ERROR [chip.native.BLE] no endpoint for unsub complete
2024-06-03 17:50:52.029 (MainThread) ERROR [matter_server.server.client_handler] [548240369744] Error while handling: commission_with_code: Commission with code failed for node 1.

Testing the same device with 6.0.1 works successfully every time:
2024-06-03 17:53:51.856 (MainThread) INFO [matter_server.server.stack] Initializing CHIP/Matter Logging...
2024-06-03 17:53:51.856 (MainThread) INFO [matter_server.server.stack] Initializing CHIP/Matter Controller Stack...
[1717437231.925356][1:1] CHIP:CTL: Setting attestation nonce to random value
[1717437231.925762][1:1] CHIP:CTL: Setting CSR nonce to random value
[1717437231.927228][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_kvs
[1717437231.927708][1:1] CHIP:DL: writing settings to file (/tmp/chip_kvs-jVBgVi)
[1717437231.927828][1:1] CHIP:DL: renamed tmp file to file (/tmp/chip_kvs)
[1717437231.928152][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_factory.ini
[1717437231.928260][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-zyIwaf)
[1717437231.928334][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717437231.928371][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_config.ini
[1717437231.928430][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-vROBfi)
[1717437231.928485][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717437231.928517][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_counters.ini
[1717437231.928577][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-EAaivf)
[1717437231.928632][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717437231.929038][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-qBQTaf)
[1717437231.929356][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717437231.929384][1:1] CHIP:DL: NVS set: chip-factory/unique-id = "16C26FC3A3BA0E89"
[1717437231.929533][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-UUkV0h)
[1717437231.932028][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717437231.932053][1:1] CHIP:DL: NVS set: chip-factory/vendor-id = 65521 (0xFFF1)
[1717437231.932183][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-pWXB0e)
[1717437231.932403][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717437231.932425][1:1] CHIP:DL: NVS set: chip-factory/product-id = 32769 (0x8001)
[1717437231.932547][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-cANLei)
[1717437231.932730][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717437231.932750][1:1] CHIP:DL: NVS set: chip-counters/reboot-count = 1 (0x1)
[1717437231.932865][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-bl6htf)
[1717437231.933070][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717437231.933115][1:1] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1717437231.933238][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-eZRjIi)
[1717437231.933446][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717437231.933468][1:1] CHIP:DL: NVS set: chip-counters/boot-reason = 0 (0x0)
[1717437231.933584][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-YWuPyh)
[1717437231.933755][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717437231.933777][1:1] CHIP:DL: NVS set: chip-config/regulatory-location = 0 (0x0)
[1717437231.933895][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-DYz8dj)
[1717437231.934099][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717437231.934119][1:1] CHIP:DL: NVS set: chip-config/location-capability = 2 (0x2)
[1717437231.934449][1:1] CHIP:DL: Got Ethernet interface: eth0
[1717437231.934594][1:1] CHIP:DL: Found the primary Ethernet interface:eth0
[1717437231.934744][1:1] CHIP:DL: Got WiFi interface: wlan0
[1717437231.934776][1:1] CHIP:DL: Failed to reset WiFi statistic counts
2024-06-03 17:53:51.935 (MainThread) WARNING [PersistentStorage] Initializing persistent storage from file: /data/chip.json
2024-06-03 17:53:51.935 (MainThread) ERROR [root] [Errno 2] No such file or directory: '/data/chip.json'
2024-06-03 17:53:51.936 (MainThread) CRITICAL [root] Could not load configuration from /data/chip.json - resetting configuration...
2024-06-03 17:53:51.936 (MainThread) WARNING [root] No valid SDK configuration present - clearing out configuration
2024-06-03 17:53:51.936 (MainThread) WARNING [root] No valid REPL configuration present - clearing out configuration
2024-06-03 17:53:52.141 (MainThread) WARNING [CertificateAuthorityManager] Loading certificate authorities from storage...
2024-06-03 17:53:52.141 (MainThread) WARNING [CertificateAuthority] New CertificateAuthority at index 1
2024-06-03 17:53:52.149 (MainThread) WARNING [FabricAdmin] New FabricAdmin: FabricId: 0x0000000000000001, VendorId = 0xFFF1
2024-06-03 17:53:52.150 (MainThread) INFO [matter_server.server.stack] CHIP Controller Stack initialized.
2024-06-03 17:53:52.157 (MainThread) INFO [matter_server.server.server] Starting the Matter Server...
2024-06-03 17:53:52.164 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetching the latest PAA root certificates from DCL.
2024-06-03 17:53:54.789 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 58 PAA root certificates from DCL.
2024-06-03 17:54:03.444 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 74 PAA root certificates from Test DCL.
2024-06-03 17:54:03.444 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetching the latest PAA root certificates from Git.
2024-06-03 17:54:16.264 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 5 PAA root certificates from Git.
2024-06-03 17:54:16.268 (MainThread) WARNING [FabricAdmin] Allocating new controller with CaIndex: 1, FabricId: 0x0000000000000001, NodeId: 0x000000000001B669, CatTags: []
2024-06-03 17:54:16.640 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 368 ms, for event type 2
2024-06-03 17:54:16.644 (MainThread) INFO [matter_server.server.device_controller] Loaded 0 nodes from stored configuration
2024-06-03 17:54:16.653 (MainThread) INFO [matter_server.server.vendor_info] Loading vendor info from storage.
2024-06-03 17:54:16.653 (MainThread) INFO [matter_server.server.vendor_info] Loaded 0 vendors from storage.
2024-06-03 17:54:16.653 (MainThread) INFO [matter_server.server.vendor_info] Fetching the latest vendor info from DCL.
2024-06-03 17:54:16.868 (MainThread) INFO [matter_server.server.vendor_info] Fetched 197 vendors from DCL.
2024-06-03 17:54:16.868 (MainThread) INFO [matter_server.server.vendor_info] Saving vendor info to storage.
2024-06-03 17:54:26.819 (MainThread) INFO [matter_server.server.device_controller] Starting Matter commissioning with code using Node ID 1 (attempt 1/3).
2024-06-03 17:54:29.571 (Dummy-2) INFO [root] Established secure session with Device
2024-06-03 17:54:39.028 (Dummy-2) INFO [root] Commissioning complete
2024-06-03 17:54:39.029 (MainThread) INFO [matter_server.server.device_controller] Matter commissioning of Node ID 1 successful.
2024-06-03 17:54:39.030 (Dummy-2) CHIP_ERROR [chip.native.BLE] no endpoint for unsub complete
2024-06-03 17:54:39.030 (MainThread) INFO [matter_server.server.device_controller] Interviewing node: 1
2024-06-03 17:54:41.512 (MainThread) INFO [matter_server.server.device_controller.node_1] Setting-up node...
2024-06-03 17:54:41.515 (MainThread) INFO [matter_server.server.device_controller.node_1] Setting up attributes and events subscription.
2024-06-03 17:54:44.054 (MainThread) INFO [matter_server.server.device_controller.node_1] Subscription succeeded with report interval [0, 60]
2024-06-03 17:54:44.055 (MainThread) INFO [matter_server.server.device_controller] Commissioning of Node ID 1 completed.

I am wondering if this is related to the share device function erroring out? if it a new error i will open a new issue.

2024-06-03 00:07:40.662 (MainThread) ERROR [matter_server.server] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/matter_server/server/client_handler.py", line 214, in _run_handler
    raise err
  File "/usr/local/lib/python3.11/site-packages/matter_server/server/client_handler.py", line 197, in _run_handler
    result = await result
             ^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/matter_server/server/device_controller.py", line 440, in open_commissioning_window
    setup_pin_code=sdk_result.setupPinCode,
                   ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'setupPinCode'
[New Thread 0xffffe8bfc1e0 (LWP 252)]
2024-06-03 03:32:45.759 (Dummy-2) CHIP_ERROR [chip.native.DMG] Time out! failed to receive report data from Exchange: 23066r with Node: <000000000000003D, 1>
2024-06-03 19:26:00.144 (MainThread) ERROR [matter_server.server] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/matter_server/server/client_handler.py", line 214, in _run_handler
    raise err
  File "/usr/local/lib/python3.11/site-packages/matter_server/server/client_handler.py", line 197, in _run_handler
    result = await result
             ^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/matter_server/server/device_controller.py", line 440, in open_commissioning_window
    setup_pin_code=sdk_result.setupPinCode,
                   ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'setupPinCode'

@asucrews It looks unrelated to me.

I re-testet with 6.1.0 and the issue / bug is still present:
2024-06-04 20:29:13.981 (MainThread) INFO [matter_server.server.stack] Initializing CHIP/Matter Logging...
2024-06-04 20:29:13.981 (MainThread) INFO [matter_server.server.stack] Initializing CHIP/Matter Controller Stack...
[1717532954.054209][1:1] CHIP:CTL: Setting attestation nonce to random value
[1717532954.054814][1:1] CHIP:CTL: Setting CSR nonce to random value
[1717532954.056862][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_kvs
[1717532954.057412][1:1] CHIP:DL: writing settings to file (/tmp/chip_kvs-46Wosj)
[1717532954.057548][1:1] CHIP:DL: renamed tmp file to file (/tmp/chip_kvs)
[1717532954.057874][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_factory.ini
[1717532954.057979][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-O8isLi)
[1717532954.058052][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717532954.058089][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_config.ini
[1717532954.058151][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-k6Miti)
[1717532954.058206][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717532954.058238][1:1] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /data/chip_counters.ini
[1717532954.058294][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-BxIQxi)
[1717532954.058345][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717532954.058840][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-8pUSMg)
[1717532954.059132][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717532954.059159][1:1] CHIP:DL: NVS set: chip-factory/unique-id = "0966F3FFBC6BAAB9"
[1717532954.059312][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-02TxWf)
[1717532954.060260][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717532954.060286][1:1] CHIP:DL: NVS set: chip-factory/vendor-id = 65521 (0xFFF1)
[1717532954.060419][1:1] CHIP:DL: writing settings to file (/data/chip_factory.ini-SkgvAg)
[1717532954.060648][1:1] CHIP:DL: renamed tmp file to file (/data/chip_factory.ini)
[1717532954.060673][1:1] CHIP:DL: NVS set: chip-factory/product-id = 32769 (0x8001)
[1717532954.060796][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-J1phUh)
[1717532954.060982][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717532954.061004][1:1] CHIP:DL: NVS set: chip-counters/reboot-count = 1 (0x1)
[1717532954.061155][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-Ji2tOh)
[1717532954.061387][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717532954.061411][1:1] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1717532954.061542][1:1] CHIP:DL: writing settings to file (/data/chip_counters.ini-54yRZh)
[1717532954.061754][1:1] CHIP:DL: renamed tmp file to file (/data/chip_counters.ini)
[1717532954.061776][1:1] CHIP:DL: NVS set: chip-counters/boot-reason = 0 (0x0)
[1717532954.061898][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-xse8Zf)
[1717532954.062092][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717532954.062114][1:1] CHIP:DL: NVS set: chip-config/regulatory-location = 0 (0x0)
[1717532954.062232][1:1] CHIP:DL: writing settings to file (/data/chip_config.ini-KhDjmh)
[1717532954.062436][1:1] CHIP:DL: renamed tmp file to file (/data/chip_config.ini)
[1717532954.062459][1:1] CHIP:DL: NVS set: chip-config/location-capability = 2 (0x2)
[1717532954.062804][1:1] CHIP:DL: Got Ethernet interface: eth0
[1717532954.062950][1:1] CHIP:DL: Found the primary Ethernet interface:eth0
[1717532954.063098][1:1] CHIP:DL: Got WiFi interface: wlan0
[1717532954.063131][1:1] CHIP:DL: Failed to reset WiFi statistic counts
2024-06-04 20:29:14.063 (MainThread) WARNING [PersistentStorage] Initializing persistent storage from file: /data/chip.json
2024-06-04 20:29:14.064 (MainThread) ERROR [root] [Errno 2] No such file or directory: '/data/chip.json'
2024-06-04 20:29:14.064 (MainThread) CRITICAL [root] Could not load configuration from /data/chip.json - resetting configuration...
2024-06-04 20:29:14.064 (MainThread) WARNING [root] No valid SDK configuration present - clearing out configuration
2024-06-04 20:29:14.064 (MainThread) WARNING [root] No valid REPL configuration present - clearing out configuration
2024-06-04 20:29:14.270 (MainThread) WARNING [CertificateAuthorityManager] Loading certificate authorities from storage...
2024-06-04 20:29:14.271 (MainThread) WARNING [CertificateAuthority] New CertificateAuthority at index 1
2024-06-04 20:29:14.279 (MainThread) WARNING [FabricAdmin] New FabricAdmin: FabricId: 0x0000000000000001, VendorId = 0xFFF1
2024-06-04 20:29:14.279 (MainThread) INFO [matter_server.server.stack] CHIP Controller Stack initialized.
2024-06-04 20:29:14.279 (MainThread) WARNING [FabricAdmin] Allocating new controller with CaIndex: 1, FabricId: 0x0000000000000001, NodeId: 0x000000000001B669, CatTags: []
2024-06-04 20:29:14.325 (MainThread) INFO [matter_server.server.server] Starting the Matter Server...
2024-06-04 20:29:14.332 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetching the latest PAA root certificates from DCL.
2024-06-04 20:29:17.433 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 58 PAA root certificates from DCL.
2024-06-04 20:29:26.100 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 74 PAA root certificates from Test DCL.
2024-06-04 20:29:26.100 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetching the latest PAA root certificates from Git.
2024-06-04 20:29:37.725 (MainThread) INFO [matter_server.server.helpers.paa_certificates] Fetched 5 PAA root certificates from Git.
2024-06-04 20:29:37.732 (MainThread) INFO [matter_server.server.device_controller] Loaded 0 nodes from stored configuration
2024-06-04 20:29:37.755 (MainThread) INFO [matter_server.server.vendor_info] Loading vendor info from storage.
2024-06-04 20:29:37.755 (MainThread) INFO [matter_server.server.vendor_info] Loaded 0 vendors from storage.
2024-06-04 20:29:37.756 (MainThread) INFO [matter_server.server.vendor_info] Fetching the latest vendor info from DCL.
2024-06-04 20:29:38.015 (MainThread) INFO [matter_server.server.vendor_info] Fetched 197 vendors from DCL.
2024-06-04 20:29:38.016 (MainThread) INFO [matter_server.server.vendor_info] Saving vendor info to storage.
2024-06-04 20:31:23.559 (MainThread) INFO [matter_server.server.device_controller] Starting Matter commissioning with code using Node ID 1 (attempt 1/3).
2024-06-04 20:31:25.788 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 107 ms, for event type 16389
2024-06-04 20:31:26.021 (Dummy-2) INFO [root] Established secure session with Device
2024-06-04 20:31:27.403 (Dummy-2) CHIP_ERROR [chip.native.CTL] Failed in verifying 'Attestation Information' command received from the device: err 101. Look at AttestationVerificationResult enum to understand the errors
2024-06-04 20:31:27.403 (Dummy-2) CHIP_ERROR [chip.native.CTL] Error on commissioning step 'AttestationVerification': 'src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error'
2024-06-04 20:31:30.018 (Dummy-2) WARNING [root] Failed to commission: src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error
2024-06-04 20:31:30.019 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 2487 ms, for event type 16389
2024-06-04 20:31:30.019 (Dummy-2) CHIP_ERROR [chip.native.BLE] no endpoint for unsub complete
2024-06-04 20:31:35.021 (MainThread) INFO [matter_server.server.device_controller] Starting Matter commissioning with code using Node ID 1 (attempt 2/3).
2024-06-04 20:31:35.450 (Dummy-3) CHIP_ERROR [chip.native.DL] FAIL: ConnectDevice: GDBus.Error:org.bluez.Error.Failed: le-connection-abort-by-local (36)
2024-06-04 20:31:37.615 (Dummy-2) INFO [root] Established secure session with Device
2024-06-04 20:31:39.143 (Dummy-2) CHIP_ERROR [chip.native.CTL] Failed in verifying 'Attestation Information' command received from the device: err 101. Look at AttestationVerificationResult enum to understand the errors
2024-06-04 20:31:39.144 (Dummy-2) CHIP_ERROR [chip.native.CTL] Error on commissioning step 'AttestationVerification': 'src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error'
2024-06-04 20:31:41.030 (Dummy-2) WARNING [root] Failed to commission: src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error
2024-06-04 20:31:41.031 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 1808 ms, for event type 16389
2024-06-04 20:31:41.032 (Dummy-2) CHIP_ERROR [chip.native.BLE] no endpoint for unsub complete
2024-06-04 20:31:46.035 (MainThread) INFO [matter_server.server.device_controller] Starting Matter commissioning with code using Node ID 1 (attempt 3/3).
2024-06-04 20:31:48.332 (Dummy-2) INFO [root] Established secure session with Device
2024-06-04 20:31:49.861 (Dummy-2) CHIP_ERROR [chip.native.CTL] Failed in verifying 'Attestation Information' command received from the device: err 101. Look at AttestationVerificationResult enum to understand the errors
2024-06-04 20:31:49.862 (Dummy-2) CHIP_ERROR [chip.native.CTL] Error on commissioning step 'AttestationVerification': 'src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error'
2024-06-04 20:31:52.039 (Dummy-2) WARNING [root] Failed to commission: src/controller/CHIPDeviceController.cpp:1145: CHIP Error 0x000000AC: Internal error
2024-06-04 20:31:52.040 (Dummy-2) CHIP_ERROR [chip.native.DL] Long dispatch time: 2098 ms, for event type 16389
2024-06-04 20:31:52.042 (MainThread) ERROR [matter_server.server.client_handler] [547905022032] Error while handling: commission_with_code: Commission with code failed for node 1.
2024-06-04 20:31:52.042 (Dummy-2) CHIP_ERROR [chip.native.BLE] no endpoint for unsub complete

What about the data directory ? Are the certificate files stored in there ?

I have not done anything to store any certificates tin the data directory.
Was there any changes from version 6.0.1 to 6.1.0 that made it a requirement to store certificates for test devices there?

I tested 6.1.2 (starting from a blank data directory) and now I can commission my test device successfully again.
Re-tested with 6.1.0 (from a blank data directory) and it failed with the same AttestationVerification issue as reported initially.
Was there any specific changes done to address this issue?
It would be nice to know why the 6.1.0 releases failed.

Yes, we fixed this in 6.1.2


Crash under SecDroidFuzz

Description
We recently scan the RN application using a fuzz tool named ScedroidFuzz, and got crash events like this.
We are not pretty sure if this is a bug or security risk, thx for the clarification。
java.lang.UnsupportedOperationException: This method is not supported for ReactViewGroup instances
at com.facebook.react.views.view.ReactViewGroup.setBackground(:185)
at android.view.View.(View.java:5872)
at android.view.ViewGroup.(ViewGroup.java:707)
at android.view.ViewGroup.(ViewGroup.java:703)
at android.view.ViewGroup.(ViewGroup.java:699)
at android.view.ViewGroup.(ViewGroup.java:695)
at com.facebook.react.views.view.ReactViewGroup.(:132)
at com.facebook.react.views.view.ReactViewManager.createViewInstance(:285)
at com.facebook.react.views.view.ReactViewManager.createViewInstance(:37)
at com.facebook.react.uimanager.ViewManager.createViewInstance(:139)
at com.facebook.react.uimanager.ViewManager.createView(:83)
at com.facebook.react.uimanager.NativeViewHierarchyManager.createView(:281)
at com.facebook.react.uimanager.UIViewOperationQueue$CreateViewOperation.execute(:188)
at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.dispatchPendingNonBatchedOperations(:1103)
at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(:1074)
at com.facebook.react.uimanager.GuardedFrameCallback.doFrame(:29)
at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame(:175)
at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame(:85)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1253)
at android.view.Choreographer.doCallbacks(Choreographer.java:991)
at android.view.Choreographer.doFrame(Choreographer.java:879)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1223)
at android.os.Handler.handleCallback(Handler.java:900)
at android.os.Handler.dispatchMessage(Handler.java:103)
at android.os.Looper.loop(Looper.java:219)
at android.app.ActivityThread.main(ActivityThread.java:8391)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1055)
Version
0.64.2
Output of npx react-native info
info Fetching system and libraries information...
System:
OS: Windows 10 10.0.19042
CPU: (8) x64 Intel(R) Core(TM) i7-9700 CPU @ 3.00GHz
Memory: 3.85 GB / 15.84 GB
Binaries:
Node: 12.18.4 - D:..\nodejs\node.EXE
Yarn: Not Found
npm: 6.14.6 - D:\software\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: Not Found
Visual Studio: Not Found
Languages:
Java: 1.8.0_232 - D:\software\env\java\jdk1.8.0_232\bin\javac.EXE
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.1 => 17.0.1
react-native: 0.64.2 => 0.64.2
react-native-windows: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
1.Connect the mobile phone to the PC
2.Start ScedroidFuzz and wait for minutes
3.that's all
Snack, code example, screenshot, or link to a repository
No response

0.64.2

That's a really old RN version. If you're using Expo, consider reporting this issue to github.com/expo/expo/

We recently scan the RN application using a fuzz tool named ScedroidFuzz

I wasn't able to find this tool on Github. There is nothing actionable for us to do on this hence I'm closing it. Feel free to follow up if there is more to be done.

这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


Restructure XdsClient load reporting APIs

This PR is being done in preparation to refactor the xds LB policy into several pieces.  In the new design, the drop data and the data for each locality will each come from a different LB policy, so the APIs need to be split up accordingly.
As part of this PR, I have also cleaned up the code to provide better laying and a simpler design.  In particular, the lifecycle management for the stats objects is now much cleaner: they are created when they are added to the XdsClient, refs to them are held by both the LB policy and the picker, and when their ref-count goes to zero, they are automatically removed from the XdsClient.  In addition, I have addressed an existing TODO about avoiding stats collection when load reporting is disabled.

This change is

Just FYI, I added one last change here to fix an ASAN bug.

Known issues: #21844 #21014 #13379 #22103


Issue with k8s.io/docs/tutorials/kubernetes-basics/create-cluster/cluster-interactive/

Continually being presented with the following error code while attempting to run "Interactive Tutorial - Creating a Cluster"
"The content owner's account has reached capacity. Please try again in 10 minutes"

The terminal ended up being able to establish a connection eventually.


Expose validation steps API

Since 0.9.0 schemas use an internal executor object which has steps that are being executed when a schema is called. This is a nice foundation that we can use to add ability to provide your own steps.
We could have something like this:
class MyStep
  # results is our error accumulator hash
  def call(input, results)
    # do something
  end
end

Dry::Validation.Schema do
  configure do
    config.steps << MyStep.new
  end
end

Things to figure out:

Result object API compatible with dry-logic results, maybe sth like Validation.(Success,Failure)(rule_name, input_values_that_were_checked)
Should we only allow appending steps, or should this be more flexible?

@solnic — I have been looking at implementing this feature. Is this something that is still on the map for version 1.0?

@dNitza yes, but things may change a lot internally, so it’s better to hold off until we’re done with the work on dry-schema

This won't be needed in 1.0.0.


Fix task selection inside while zone

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.67%. Comparing base (5937b88) to head (da969f6).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   75.75%   75.67%   -0.08%
==========================================
  Files          70       69       -1
  Lines        4615     4707      +92
==========================================
+ Hits         3496     3562      +66
- Misses       1119     1145      +26

Flag
Coverage Δ

python-3.11
75.67% <ø> (+<0.01%)
:arrow_up:

python-3.9
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Suggestion: Install files from direct urls

Heya, asked over on the IRC and was told it may be possible and to make an issue. Goal is to download files into a specific location from a direct url through Denizen.
I'd like select individuals to be able to run commands such as /install midi direct url, /install script direct url, etc.
Thanks :)

Script installation won't be possible because that's a ridiculous massive security risk.
Midi install, however, can be done.

Possibly schematics as well? Would be helpful to give a builder rank the ability to install resources like trees/buildings on their own.

Schematics will be quite doable as well.


Custom template import not working

I'm keeping the project related templates inside antcc/templates folder as given in readme file but those templates are not getting imported.
need help on this please.

This somehow has slip from our radar. I guess you have already contacted us in Techcommunity so I will close it.


SIRo Sandbox tool MVP

Motivation and Context
See examples/siro_sandbox/README.md for details.

How Has This Been Tested
Local testing.
Types of changes
This PR merges into SIRo, not main. This would be a Development-type change if/when it merges to main.
Checklist

[x] My code follows the code style of this project.
[x] I have updated the documentation if required.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes if required.

Videos of running HITL eval with a user-controlled humanoid and policy-driven Fetch
Mac M1
Sandbox Tool (video is too large to be uploaded in GitHub comment):
https://drive.google.com/file/d/1vNSv3Tx9PsKbYQHZk2aFJT9KZHDeDJ_S/view?usp=share_link
Sandbox Tool + batch renderer fail on my Mac M1 with the following error:

ubuntu22.04
Sandbox Tool:
hitl_ubuntu22.04.webm
Sandbox Tool + batch renderer (note, that the control is not working properly; blue trajectory that humanoid is expected to follow doesn't "repeat" mouse movement):
hitl_batch_renderer_ubuntu22.04.webm

@eundersander  In general everything looks great to me. Very enjoyable to control the humanoid and I like how everything looks visually.
The only 2 things I'm worried about are:

running Sandbox Tool + batch renderer fail on my Mac M1 machine with the error I've attached in the above comment (but I don't know if it is specific only to my machine)
in Sandbox Tool + batch renderer (on ubuntu) blue trajectory doesn't follow the movement of the mouse

@rpartsey Thanks for high-level comments above. Let me address a few here:

Sandbox Tool + batch renderer fail on my Mac M1 machine
This is expected and a fundamental limitation of the batch renderer. I will add a note in the README.

in Sandbox Tool + batch renderer (on ubuntu) blue trajectory doesn't follow the movement of the mouse
The --use-batch-renderer flag is experimental and really just for Mikael and me for debugging, so I'm not gonna worry about this right now.

it would be nice to also enable scene rotation in addition to zoom the camera in/out
Absolutely. Let's aim to add UX improvements like this in follow-up PRs. For this PR review, let's limit the scope to code organization and bugs that affect most users.


replication to todays date directory

This is needed for an incremental backup.

This is needed for an incremental backup.

on second thought, I think it is better to avoid this feature.

The deletions or updates would not work.
The configuration is a bit hard to understand.

on second thought, I think it is better to avoid this feature.

The deletions or updates would not work.
The configuration is a bit hard to understand.

on second thought, I think it is better to remove this feature.

The deletions or updates would not work.
I redo on entry mtime

on second thought, I think it is better to remove this feature.

The deletions or updates would not work.
I redo on entry mtime

How about create one sink with simple "rsync" to local, and another sink with daily partitions?

How about create one sink with simple "rsync" to local, and another sink with daily partitions?

The deletions or updates would not work.
I redo on entry mtime

You may want to use entry ctime, which does not change for following updates after creation.

The deletions or updates would not work.
I redo on entry mtime

You may want to use entry ctime, which does not change for following updates after creation.

How about create one sink with simple "rsync" to local, and another sink with daily partitions?

You can, you need to think about how to reduce the copy-paste of the code

How about create one sink with simple "rsync" to local, and another sink with daily partitions?

You can, you need to think about how to reduce the copy-paste of the code


gnote: init at v43.2

Description of changes
Based on the commits and reviews on #174827. It seems like there was no activity on the pr.
Resolves #227679

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Hmmm, I actually have some questions

How is docbook_xsl used here? grep -inr 'docbook' does not return anything, I would expect docbook stuff like<?xml version="1.0"?>
<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.3//EN"
                      "http://www.oasis-open.org/docbook/xml/4.3/docbookx.dtd">

Why 43.2 instead of 44.0? I know 43.2 is tagged later 44.0 but they are maintained on different branches and 44.0 should be the latest.

And a small nit, do you mind also adding an update script? We do mass GNOME updates in this way nix-shell maintainers/scripts/update.nix --arg predicate '(path: pkg: pkg.updateScript.name or null == "gnome-update-script")' --argstr keep-going true --argstr commit true --argstr max-workers so the package will be taken care.
  passthru = {
    updateScript = gnome.updateScript {
      packageName = pname;
    };
  };

Good question.

move ... the callPackage to gnome's default.nix

No I think. We prefer new GNOME package goes to top-level.

move gnote to pkgs/desktops/gnome/apps

I don't aware of restrictions on this, the only difference should be pkgs/desktops/gnome has a CODEOWNER :see_no_evil:

Thank you for clarifying 😅


Update README.md

Submit your project for inclusion in XD-Awesome
Hey! We're happy you want to submit your project to XD-Awesome. Please create a pull request and ensure that you fill out the following template:
Ready Components
Description of your project: A plugin for generating generalized components at command click.
Link to your project: https://xd.adobelanding.com/en/xd-plugin-download/?name=92da0037
License: https://github.com/rohit-rmethwani/ready-components/blob/master/LICENSE
Category: UI Components
Why is it awesome?
The plugin generates generally used components for UI. So people can easily add new components to the plugin thereby speeding up designing process.
Checklist:

[1] I have signed the Adobe Open Source CLA.
[1] I have read the CONTRIBUTING document.

sorry for the delay! Thanks for including your project


Add a level completion animation

I'm thinking a circle is drawn and then a check is drawn then the move to the left and the score appears on the right

done, need to wire the scoring component to display correct number of stars


feat(app): add MiniCardButton component for Robot Dashboard

Overview
Add MiniCardButton component

design
https://www.figma.com/file/AoTLAYuWawlaWItB1umOjr/OT-3-On-Device-Display?node-id=1776%3A30238&t=k5NfyrOL7SrHUeGL-0
This PR doesn't include icons in the design since mid-fi design will be changed even icons.
close RCORE-449

Changelog

add a new component, stories, and test
update folder name for CardButton to align with the file structure

Review requests

Run make -C compoents dev and MiniCardButton in stories matches the design

Risk assessment
low

[ ] add width and height as props for hi-fi


[WIP] host_inventory['network'] parser parsing interfaces and routes

Hi Gosuke,
this is a draft for a new host_inventory type called network. The code is rather monolithic and returns a huge hash. So I wanted to get some input from you first. Even in its current form it's not much work to change the current high-level structure from
  host_inventory['network'] => {
    :routes => [],
    :interfaces => {},
    :default_inet_interface => "",
    :default_inet6_interface => "",
  }

to
  host_inventory['routes'] => [ ... ]
  host_inventory['interfaces'] => { ... }
  host_inventory['default_interfaces'] => { :inet6 => '', :inet => '' }

Let me know what you think.
Before committing I'll test it in an environment with a few hundred servers to make sure it is bullet-proof. But I'd like to know how to structure the test from the start.
cheers,
--urs

Summary: An inventory parser for Linux using a few ip commands to get the most
interesting parts of the network information available. It is loosely based on
the output of the Chef's Ohai but contains more information and treats IPv4 and
IPv6 equally.
Output structure:
{
  :default_inet_interface  => "<if-name>",
  :default_inet6_interface => "<if-name>",
  :interfaces =>
    {
      "<device>" =>
        {
          :flags         => [<flag>, ..],
          :encapsulation => "<encapsulation>",
          :mtu           => "<mtu>",
          :qdisc         => "<qdisc>",
          :state         => "<state>"
          :addresses =>
            {
              "<mac-address | ip-address>" =>
                {
                  :family        =>  "<family>",
                  :prefixlen     =>  "<prefixlen>",
                  :scope         =>  "<scope>",
                  :flags         =>  [<flag>, ..],
                  :label         =>  "<label>",
                  :valid_lft     =>  "<valid_lft (ipv6)>",
                  :preferred_lft =>  "<preferred_lft (ipv6)>"
                },
               ...
            },
            ...
        },
        ...
    },
  :routes=>
    [
      {
        :advmss       => "advmss",
        :destination  => "<destination>",
        :device       => "<device>",
        :family       => "<family>",
        :hoplimit     => "<hoplimit>",
        :metric       => "<metric>",
        :mtu          => "<mtu>",
        :type         => "<type>"
      },
      ...
    ]
}

Hi Urs,
Thanks for your great contribution. It seems there are no problem.

Hi Gosuke,
Thanks when it is ready for prime time I'll send you a pull request.
I just found a bug in routing. So there is much work ahead of me.
cheers,
--urs


Updated to Gremlin.NET 3.4 RC2 to access response headers

Introduced new result class GraphResult<T> which contains the results as well as the response headers.
Updated GraphClient, IGraphClient and extensions accordingly.
Updated sample
Removed nuget-reference to Gremlin.NET from sample and test projects to allow it to be resolved transitively through project reference

@evo-terren Since we're in different time-zones I went ahead and added those bits so you have something to review when you wake up.
I did a bit of testing, and only found those five response headers. I haven't been able to make CosmosDb throw in order to see if there are other response headers in that case (I initially did this to handle 429's) so there could be something I have missed.
Tested on a 1000 RU/s collection with what turned out to be a 175k RU query, and got no errors or anything.
Anyway take a look and let me know what you think.
I'm open to renaming/restructuring if you deem it necessary.

Rebased and pushed the updates.


Editor: remove mask from text element output

Summary

Per discussion in the text sets channel we should not apply .mask/overflow: hidden to all elements. This PR checks for the text type and removes the class which applied overflow: hidden to the text. Removing .mask from all elements

Relevant Technical Choices

removing overflow: hidden from all elements causes the video and image element crop to fail, so I only removed .mask from text type elements.

To-do

[x] percy screenshot tests
[x] select a fancy font that bleeds over instead of basic addTextElement. Right now my tests are kind of lame...
[x] e2e test is more suitable for a Jest unit test in assets/src/edit-story/elements/text/test/output.js; less overhead. Could use a more generalized not.toHaveStyle('overflow: hidden') assertion instead of checking for the class name specifically.

I wasn't able to replicate the font cut-off from the ticket so steps to reproduce that might be useful...

User-facing changes

should fix the issue where certain text and glyphs would not overflow their containing box, resulting in undesired cropping e.g.

vs

Testing Instructions

create a new story
add a text element to the page
select "preview"
inspect the text element
confirm its containing element no longer has the "mask" class:

with mask

without mask

Fixes #4721

I removed the e2e tests per discussion. Replaced with checks on text and mask output.

@embarks Looks like removing the mask from the text element is causing a regression: https://github.com/google/web-stories-wp/issues/5324
Can you confirm why is removing the mask necessary for text sets?


Issues with the Uarte on the nRF9160-dk

I'm unsure whether the Uarte is working properly with the nRF9160. If I run a client on the nRF9160-dk, and the server on an nRF52840-dk then the server reports errors on the receipt of data. I provided additional logging within the Uarte to obtain these error values.
If I run the client on a micro:bit v2 (nRF528333) then all appears well between the client and server. I'm guessing that nRF52840 to nRF52840 would also work just fine, but I have only one nRF52840-dk and so haven't tested this combination.
Setup:

first plug in an nRF9160-dk and an nRF52840 via usb (both are able to be connected simultaneously)
connect P0_10 on the nRF9160-dk to P1_12 on the nRF52840-dk
similarly, connect P0_12 on the nRF9160-dk to P1_10 on the nRF52840-dk
I also connect GND to GND, but I'm not sure that's necessary

To reproduce:

clone https://github.com/titanclass/embassy-start
cd to the server folder
run:

PROBE_RUN_PROBE='1366:1015' \
DEFMT_LOG=trace \
PROBE_RUN_CHIP='nrf52840_xxAA' \
cargo run --target thumbv7em-none-eabihf --features "nrf52840-dk"

upon seeing the startrx trace line, from another terminal, cd to the client folder
run:

PROBE_RUN_PROBE='1366:1055' \
DEFMT_LOG=trace \
PROBE_RUN_CHIP='nrf9160_xxAA' \
cargo run --no-default-features \
  --target thumbv8m.main-none-eabihf \
  --features "nrf9160-dk-s"

Once running, the client will make a request of the server by sending a "ping" text message. It will wait 5 seconds for a reply and then timeout and send another request.
With the nRF9160 as the client, no messages are generally received. The server sometimes receives a message, but the text is often garbled and therefore not parsable. That said, I have also seen the message come through ok from time to time.
Here's what a good receive looks like when using a micro:bit v2 as the client with some custom logging in Uarte (you won't have all this):
DEBUG Receiving
└─ server::network::main_task::task::{generator#0} @ nrf-app/src/network.rs:34
TRACE startrx 2003fa61 32
└─ embassy_nrf::uarte::{impl#8}::read::{generator#0}::{closure#0} @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: uarte
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx started
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE rx poll
└─ embassy_nrf::uarte::{impl#8}::read::{generator#0}::{closure#8} @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: uarte
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx started
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx byte received
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: uarte
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx started
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx byte received
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx events
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE rx poll
└─ embassy_nrf::uarte::{impl#8}::read::{generator#0}::{closure#8} @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE rx poll: events
└─ embassy_nrf::uarte::{impl#8}::read::{generator#0}::{closure#8} @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE Received [4, 112, 105, 110, 103, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
└─ server::network::main_task::task::{generator#0} @ nrf-app/src/network.rs:36
DEBUG Received Message("ping")

To note, there are no errors reported and the message is parsed as "ping". The micro:bit as the client works consistently well.
Here's what a bad receive looks like when using the nRF9160-dk, again with custom logging:
DEBUG Receiving
└─ server::network::main_task::task::{generator#0} @ nrf-app/src/network.rs:34
TRACE startrx 2003fa61 32
└─ embassy_nrf::uarte::{impl#8}::read::{generator#0}::{closure#0} @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: uarte
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx started
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx byte received
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE rx poll
└─ embassy_nrf::uarte::{impl#8}::read::{generator#0}::{closure#8} @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: uarte
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: error event with src 13
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx started
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx byte received
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: uarte
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: error event with src 13
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx started
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx byte received
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE interrupt: rx events
└─ embassy_nrf::uarte::{impl#1}::on_interrupt @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE rx poll
└─ embassy_nrf::uarte::{impl#8}::read::{generator#0}::{closure#8} @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE rx poll: events
└─ embassy_nrf::uarte::{impl#8}::read::{generator#0}::{closure#8} @ ~/Projects/hacking/embassy/embassy-nrf/src/fmt.rs:112
TRACE Received [0, 0, 0, 0, 65, 0, 4, 112, 97, 110, 0, 4, 0, 103, 4, 73, 110, 0, 4, 96, 68, 0, 165, 0, 0, 0, 0, 0, 0, 0, 0, 252]
└─ server::network::main_task::task::{generator#0} @ nrf-app/src/network.rs:36
DEBUG Received Message("")
└─ server::network::main_task::task::{generator#0} @ nrf-app/src/network.rs:38

The nRF9160-dk client is consistently bad. You can see error event with src 13, which equates to the following errors:

A start bit is received while the previous data still lies in RXD. (Previous data is lost.)
Framing error occurred. A valid stop bit is not detected on the serial data input after all bits in a character have been received.
Break condition. The serial data input is '0' for longer than the length of a data frame. (The data frame length is 10 bits without parity bit, and 11 bits with parity bit).

Having also put a logic analyser on this, when I see things go wrong it appears to be that the 9160 client sends out about 3s of data instead of its usual 3ms. Data is most certainly sent across the pins though.
Here's when things go right:

...where the request going out takes about 3ms, then there's a pause while the server is busy, followed by a 3ms reply.
Here's when things go wrong:

i.e. just the client sending out about 3000ms of request...

Problem solved. The nRF9160-DK is 18v IO by default. :-P All now works well.
More info: https://infocenter.nordicsemi.com/index.jsp?topic=%2Fug_nrf91_dk%2FUG%2Fnrf91_DK%2Fpower_sources_vdd.html&cp=2_0_5_3_2_1


fix for CVE-2023-4759

jira for issue:
https://devopsmx.atlassian.net/browse/OP-21524
verified build was successful

Pls share testing details.
Why specified version, is this dependency not coming from kork?

It is not there in kork

Test cases failing count before and after the change is same:
clouddriver-google: 17
verified no new test cases failed because of the version change


Adding C++ Program to Concatenate Two Strings

Hey there!
I would like to work on this issue. Kindly assign me to it.

Please assign me .


[sema] Add compiler fixit for the case where a raw-representable type is constructed from an argument with the same type.

What's in this pull request?
Add compiler fixit for the case where a raw-representable type is constructed from an argument with the same type, like this:
MyEnumType(MyEnumType.foo)
This is missing 'rawValue:' label, but that won't actually fix this. A better fix is to just remove the unnecessary constructor call:
 MyEnumType(MyEnumType.foo)
-->
 MyEnumType.foo
Resolved bug number: (SR-)
rdar://26615638

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

… is constructed from an argument with the same type.
Like this:
MyEnumType(MyEnumType.foo)
This is missing 'rawValue:' label, but that won't actually fix this. A better fix is to just remove the unnecessary constructor call:
MyEnumType(MyEnumType.foo)
-->
MyEnumType.foo

@swift-ci smoke test OS X platform


Fix release gh-action permissions

Motivation
Fix release GH action.
Description
Restore the contents: write permission the release action had by default before workload identity implementation.

bors merge

bors merge

Created issue for flaky test: https://github.com/spacemeshos/go-spacemesh/issues/6293

bors merge

bors merge

bors merge

bors merge

bors merge

bors merge

bors merge


Add static private class field support

Q
A

Bug fix?
no

Breaking change?
no

New feature?
yes

Deprecations?
no

Spec compliancy?
yes

Tests added/pass?
yes

Fixed tickets

License
MIT

Private class fields can be static (according to the unified proposal).

Nice job @jridgewell.
Do you think we could merge classProperties and classPrivateProperties plugins in Babylon? Since it just adds the static syntax.

I'll do that in a second PR.

@xtuc @jridgewell
We should wait for merging both plugins until publicFields get to Stage3, which hopefully will happen in the next TC39 meeting (in about a month).
There is still some debate on the committee on wether this.#x will be required and so let's wait for the final version.
Decorators might be another moving piece that is very intertwined, but I guess is mostly implementation details.
Lastly, just an FYI I think @littledan wants to present private methods, so let's see which Stage that lands... :)

This looks great. I don't see why it should wait until Stage 3 to land--I presented static private fields to the committee in the May meeting with this syntax and didn't hear any concerns. I think @hzoo is doing a lot of work to communicate to users that Stage 2 proposals are unstable.
For decorators, we unfortunately don't have spec text yet which combines it with fields; hope to fix that soon. Private methods haven't been presented yet, so I guess they will wait a bit longer to add to Babel.

@littledan I was not talking about this PR, this is good to go, the refactor to combine public/private fields is what Im saying to postpone til we figure out the this.#x syntax.


indexerror: list index out of range

run(sys.argv[1]) in line 28 out of index, how to solve it?

I think you were trying to use "record_measurments.py", you should enter something to while exec the code in terminal like that ; ./record_measurments.py out.txt
command needs an argument.

Correct. You should provide path to an output file.


Counties Tables & Graphs are Showing as Zero Cases/Deaths

On both the Table and Graph functions in the "U.S. Counties" tab there is no information:

Looks like the counties data shape has changed so we've now got time-series data there, will fix this shortly.


date() ignores offset?

These two commands return the same dates (same epoch_time field but different timezone field).
r.time(1986, 11, 3, '+02:00').date()
r.time(1986, 11, 3, '+00:00').date()

I thought that date would return the date given the timezone, but it looks like it just return the date for the offset +00:00.
If it's expected, a little note on the docs would be nice : )

Same question for timeOfDay.

Hmm it's working for me on 2.0.0:
r.time(1986, 11, 3, "+00:00").toEpochTime()
531360000
r.time(1986, 11, 3, "+02:00").toEpochTime()
531352800

Which outputs are you getting?

Oh never mind. The issue is with date. I see.

@mlucy was this the intended behavior of date?

I don't remember what the intended behavior was, but if this is confusing I'm not at all opposed to changing it.

I opened https://github.com/rethinkdb/rethinkdb/issues/4149 . I think this might have been an oversight in the implementation, since with the current implementation this has some very fishy side-effects.

@danielmewes -- should we close this one then?

Yeah. We'll fix it with 2.1 in the server.


Extend convert_to_spreads assist to handle list adds

@stereotype441 noticed in https://github.com/flutter/flutter/pull/30784#discussion_r273508002 a migration to:
return Section(<Line>[Line(prefix), ...codeLines]..add(Line(postfix)));

and expected:
return Section(<Line>[Line(prefix), ...codeLines, Line(postfix)]);

It would be great if the assist handled adds.

I don't think we want convert_to_spread to produce changes that don't introduce a spread element (the messaging just seems wrong), so I propose adding an inline_invocation assist to handle those cases. (CL out for review.)

Closing in favor of work in: https://dart-review.googlesource.com/c/sdk/+/99040

https://dart-review.googlesource.com/c/sdk/+/99040


Remove some duplicate code

There is a lot of duplicate code in cytnx. This patch removes some duplication of code in the file I/O in src/Tensor.cpp, src/UniTensor.cpp, src/backend/Storage.cpp.  There are sometimes 3 copies of a function, that differ only by taking a filename as an std::string, a const char*, or an fstream. These should be consolidated to one function. I made a start at this, and also improved some of the error messages.
A reasonable model is:
// Save(std::string) forwards to Save(const char*)
void Tensor::Save(const std::string &fname) const {
  Tensor::Save(fname.c_str());
}

// Save(const char*) does some error checking and forwards to Save(fstream&)
void Tensor::Save(const char *fname) const {
  fstream f;
  string ffname = string(fname) + ".cytn";
  f.open(ffname, ios::out | ios::trunc | ios::binary);
  cytnx_error_msg(!f.is_open(), "[ERROR] invalid file path for save: %s", fname);
  this->_Save(f);
  f.close();
}

void Tensor::_Save(fstream &f) const {
// non-trivial code in here
}

I also improved some of the error messages, although I notice that I missed the one that I copy-pasted above.
A common pattern I see is code like this:
if (!f.is_open()) {
  cytnx_error_msg(true, "[ERROR] invalid file path for save.%s", "\n");
}

I wonder if this is partly due to the name cytnx_error_msg -- it is not obvious from the name what this does, does it unconditionally show an error message, or does it do some check, or what?  I suggest to rename cytnx_error_msg to
cytnx_error_if(Condition, Message, ...)

to make it clear that it is doing a test of a condition and it does not need to be enclosed in an if (Condition) statement.
Almost every cytnx_error_msg call has "[ERROR] " at the start of the string. The few calls that do not are probably unintentional. So a nice improvement would be to move the "[ERROR] " part of the message into the implementation of cytnx_error_xxx, so the caller doesn't have to repeat the same string every time.
There are also a lot of cytnx_error_xxx calls that include some information about the sub-module, eg "[ERROR][Trace] invalid Type.%s".  A better mechanism would be to specify the sub-module separately, for example something like
CYTNX_SUBMODULE("Trace");

which could go at the top of a C++ file (or anywhere else, really), and some macro magic would include the module string in the error message.

I didn't rename the _Save function, although it should be: it is a name that is reserved.

Nice. This is great.