Build preflight without GLIBC

Is your feature request related to a problem? Please describe.
We ran into an issue where the golang builder image updated to use a newer version of glibc then was in the UBI version of our base image. This lead to the below error.
preflight: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by preflight)
preflight: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by preflight)

Describe the solution you'd like.
Preflight doesn't need to have a hard dependency on this glibc so we update the build process to no longer force this out the binary that we build.
Describe alternatives you've considered.
NA
Additional context.
 podman run -it --rm --entrypoint /bin/bash dbe46b5e0365
[root@20650cddbf6f /]# ldd /usr/local/bin/preflight
/usr/local/bin/preflight: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /usr/local/bin/preflight)
/usr/local/bin/preflight: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by /usr/local/bin/preflight)
        linux-vdso.so.1 (0x00007ffd53197000)
        libc.so.6 => /lib64/libc.so.6 (0x00007f4744802000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f4744bc7000)

#1020 may also be related to the Go 1.20 upgrade


Limited openAiResourceGroup location options(Westeurope not included)

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [x ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

I have previously deployed using this repository. However, there used to be an option for the "westeurope" region, but now it seems to be unavailable. Consequently, when we attempt to deploy using the repositories like 22a45dc and 22a45dc, it becomes confusing when we reach the step where we need to select a region of openAiResourceGroupLocation because all of our resources are located in "westeurope."

Could you please advise me on what I should select in my particular case? Additionally, I'm curious about why there are only a few locations available in the options. Does this have any impact on the deployments? If not, why aren't more locations included? Your inputs will be of great help

. Thank you.
OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

azd version?

run azd version and copy paste here.

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

That list is based on https://learn.microsoft.com/en-us/azure/ai-services/openai/concepts/models#model-summary-table-and-region-availability - westeurope isn't an option for latest version of models, so you'll need to pick a different one for the OpenAI resources.

Thank you @pamelafox  for your prompt response. Can i change the version of the models and the locations to the list in the main.bicep file and work on the latest repos?


chore: add travis for Linux

Signed-off-by: pingkai<EMAIL_ADDRESS>

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 All committers have signed the CLA.


Fix getSelection for Safari Shadow Dom

Use custom getSelection for Safari Shadow DOM, as native method returns incorrect anchorNode and focusNode
It fixes issues described in 1310

This is a great start, but I don't want to include the hack where you create an object with the methods and properties of the native selection copied into it. I'd prefer to do what CodeMirror does and distinguish between selection range objects (just focusNode, focusOffset, anchorNode, anchorOffset) and selection objects that are going to have their methods called throughout the code base. Most places that need this just need the range, for which we'd add a custom getter function, and the few that do need to update the selection will have to work with two objects, the range + the native selection object.

I've gone ahead and implemented what I meant in 64a96e51be902fdcd96d210cf0241293750b16f1


expose article_footer in the conf.py

I wanted to replace the prev and next buttons by a "aske the community" and a "last uypdated at" buttons but I didn't managed as the article_footer is not exposed to the end user. What do you think if we start exposing it the same way we expose "article_header"?

I think this was addressed by #1215. @12rambau please feel free to re-open if I'm misunderstanding.

there are

It's not exactly the same, we expose the footer_content which is larger (it goes under the left-sidebar)

I must be misunderstanding. If I look at the diagram here it seems to show:

article_footer_items (under article only)
content_footer_items (under article and right sidebar)
footer_start and footer_end (under everything)

Isn't the first one of those the thing you're asking for?

when I reopened this one the stable version was still 0.13.2 where the  article_footer_items was not there yet.
let me check from my side and I'll close it if manage to do what I need in my docs

article_footer space does exist but can only be filled if show_prev_next is set to True. I think this is not the intended behavior

Agreed, that is not how it should work.


Support for Swift

I am planning to make all my new iOS apps in Swift and although I can have a mixed project (Obj-C & Swift), it would be nice to have everything in Swift. At least there should be some Swift Demos.

Hi, I've just submitted a PR for this (Extension and basic Demo), hope it helps. 😃

Thanks so much @ghecho :+1:
I just commented on PR #192.
Cheers!

PR #192 was closed, therefore referencing PR #194 here.

Yes. I closed the first PR because I couldn't find how to change the branch within the PR so I closed that and opened a new one. If there's a way of editing the PR branch I'd like to know.

Hi @ghecho,
I just googled and I found this: https://github.com/isaacs/github/issues/18
By the looks of it, changing the destination branch for an already opened PR is not yet supported. So I guess that what you did (closing and re-opening) was the right thing to do.
Cheers!

Cool. Glad to know.
Cheers!

Hey everyone,
I just finished the two demo apps (ACME and ACME Browser) in Swift. Please take a look at the new/swift-demo-apps branch.
Feel free to PR improvement to that branch :smile:
Thanks!

I just submitted a PR (tiny by the way, just a cosmetic layout issue on the iPhone)

Thanks @ghecho! The PR is now merged :+1:

:+1:

In WWDC 2015 Apple announced availability tools for swift like:
if #available(iOS 8.0, *)
{
...
}

That allows (as far as I can see) the library to be rewritten in Swift completely for iOS 9. :wink:

Hi @ghecho,
Thanks for the suggestion :wink:
It's easier to add Objective-C code to Swift projects than Swift code to Objective-C projects. That's why we'd like to keep our API in Objective-C for the time being.
Please make sure that you take a look at our Swift demo apps. They are currently available in separate branches:
Swift 1.2
new/swift-demo-apps
Swift 2.0 (requires Xcode 7)
swift2.0
Enjoy your weekend!

Hi @radazzouz ,
Cool, I didn't checked until now those branches, I understand your logic, It's just that I'm porting many of my projects to Swift and I didn't see legacy support (as in Objective-C support) as a priority but giving that a second thought and since 1Password is widely used your approach makes total sense.
Have a nice week!

Thanks @ghecho :smile:

Resolved by PR #257.


Add "Agile methodology" image in More Information

added image in the more information section

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@PatiPavanSai 	Thank you!


Tanki x

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[*] brew cask audit --download {{cask_file}} is error-free.
[*] brew cask style --fix {{cask_file}} reports no offenses.
[*] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[*] Named the cask according to the token reference.
[*] brew cask install {{cask_file}} worked successfully.
[*] brew cask uninstall {{cask_file}} worked successfully.
[*] Checked there are no open pull requests for the same cask.
[*] Checked the cask was not already refused in closed issues.
[*] Checked the cask is submitted to the correct repo.

I apologise if I've done anything incorrectly – I'm pretty new to this, but I tried my best to follow the guides provided by you for creating new Casks.

shouldn't this be under homebrew-games?


make local gettimeofday helper static

We have a local gettimeofday() helper for Windows in libfreerdp/utils/pcap.c that wasn't defined as static. There was no reason not to make it static, and it caused a symbol conflict with LibreSSL on Windows.

@freerdp-bot test

pr looks ok, but grepping through code this looks like it needs some cleanup:

there are multiple definitions of gettimeofday
sometimes there are fallbacks to clock_gettime sometimes not

so will check this first.

replaced by #9949


UniName

@Yukino0450 lib/domains/jp/seinan_gakuin.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Yukino0450 Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@Yukino0450 I am sorry, this request remains not updated for a while. I have to close it without merging. Please create a new one with correct filepath.


Fix race in genesisLayer initialization

Motivation
func GenesisLayer() *Layer

is racy.
Changes
Wrap the genesis layer in a struct with sync.Once and use it to initialize the genesis layer only once.
Test Plan
unit tests
DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

Imho it would be OK to have the oncer as package variable and use it in GenesisLayer() to protect the call to InitGenesisData / genesisDate and drop the wrapper construct.

btw GenesisLayer is supposed to be removed, it was added for convenience long time ago and doesn't serve any real purpose

bors merge


Allow for configurable tab sizing

Currently the debugger source code view always renders tabs as 1 space. However, a lot of codebases, including Unreal Engine's, are formatted expecting a different tab stop length (such as 4 spaces). In general this feels like something that should be user-configurable. Ideally there's a simple configuration option to set the tab size.

Done as of 0.9.11.


github-action-build-chain updated to v2.6.2

Referenced pull requests

https://github.com/kiegroup/kogito-pipelines/pull/182
https://github.com/kiegroup/kogito-examples/pull/723
https://github.com/kiegroup/kogito-apps/pull/876
https://github.com/kiegroup/kogito-runtimes/pull/1358
https://github.com/kiegroup/optaplanner/pull/1365

Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Your code is properly formatted according to this configuration
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to retest this PR or trigger a specific build:

Pull Request
Please add comment: Jenkins retest this

Quarkus LTS checks
Please add comment: Jenkins run LTS

Native checks
Please add comment: Jenkins run native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

The Linux check has failed. Please check the logs.


[DFT] - spi_device clock should be muxed with scan clock

top_earlgrey.u_spi_device.cio_sck_i is driven by pad. As such it is not fully controlled during scan. about 145FFs of spi_device are removed from the scan chains as a result.
Suggested solution:
Add a scan_clk dedicated input and connect a clock with the expected clock frequency. Maybe io_div2 ?

@NoamGottlieb

thanks @arnonsha.

checked offline with @arnonsha, and the scan clock connected to spi_device can one of the existing functional clocks.  Those clocks already have scan clock control, thus we do not need an additional bypass.
This is really for my own clarification.


[Doc] Document PULSAR_CLIENT_CONF env variable. Missing TLS-related CLI arguments

Search before asking

[X] I searched in the issues and found nothing similar.

What issue do you find in Pulsar docs?
I need to be able to work with several Pulsar instances using pulsar-admin.
For each Pulsar instance, I have a different TLS configuration.
It's unclear from the docs or CLI help, what I should do in this case.
As I see, it's documented for pulsar-perf, but not for pulsar-admin and pulsar-client.

What is your suggestion?

Add the documentation on the docs site.
Add the documentation to pulsar-admin, pulsar-client and pulsar-perf.
It would be nice to have a --config-file CLI argument instead of an env variable. Even better to expose missing configuration parameters as CLI arguments.

Any reference?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Hi @visortelle

Add the documentation on the docs site.

Q1: Do you mean adding instructions/examples on how to use these 4 environment variables?

Add the documentation to pulsar-admin, pulsar-client and pulsar-perf.

Q2: now we have docs for pulsar-perf as below

Do you mean adding similar content to pulsar-admin and pulsar-client?

Hi @Anonymitaet

pulsar-perf CLI tool has the Environment variables help section in a terminal.
This section is missing in the pulsar-admin and pulsar-client CLI tools help.
Same for the docs site.

Regarding instructions/examples - not sure that it's necessary.
I'd add links to the according files and improve its code comments if necessary.
PULSAR_CLIENT_CONF:
See https://github.com/apache/pulsar/blob/master/conf/client.conf for details.
PULSAR_LOG_CONF:
See https://github.com/apache/pulsar/blob/master/conf/log4j2.yaml for details.

@visortelle Thanks! This issue contains two types of improvements:
Doc improvements
☘ TO-DOs
Add the environment variables section to the following pages.

Reference site - pulsar-perf home page
Reference site - pulsar-admin home page
Reference site - pulsar-client home page

☘ Reasons
This section is shown on 2.10.x and earlier markdown docs (e.g., https://pulsar.apache.org/docs/2.10.x/reference-cli-tools/#pulsar-perf) but not available on 2.11.x and later Reference site.
Since the reference pages of pulsar-perf, pulsar-admin, and pulsar-client are generated automatically, we can add the environment variables section to the their homepage as a temporary workaround. We can optimize it once we find better solutions.
@momo-jun @DaveDuggins @D-2-Ed WDYT?
Code improvements
I've double-checked and tested the current code behavior and then recorded it in https://github.com/apache/pulsar/issues/19526. Feel free to correct me if I'm inaccurate, thank you!

PULSAR_CLIENT_CONF: See https://github.com/apache/pulsar/blob/master/conf/client.conf for details.

@visortelle  That means the environment variable of pulsar-client is all the values in this file right?


fixcollect all correlated slots from subquery in correct way

Proposed changes
pick from master https://github.com/apache/doris/pull/30908

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


upgrade keycloak to v20

With keycloak v20, openid is not included as a default scope, which caused the error reported by the upgrade.
On the issue there is a video that shows how I configured keycloak through the admi console to work.
I did an export of the realm.json and I believe that all the keycloak json files are now working and correct. The dev one definitely works.
Marking this draft as I need to check whether the other jsons work.

I have tested this with both docker-dev and docker compose and it works.
I was not sure what to do to test other keycloak json files that I modified, but I will make this a pull request and not draft.

Could you also update the k8s deployment realm at deployments/kubernetes/charts/clowder2/files/realm.json if possible?

Added.


Closing a native tab crashes app

Type: Bug
This seems to be a relatively new behavior since last update, and I don't recall changing anything-- but since I switch repos a lot and dislike multiple rows of tabs, I use Open Editors mostly to control files being open/closed, and use the native tabs feature for macOS because it's fantastic being able to navigate between repos this way. I am however cursed to never having anything software work correctly, so it's entirely possible it's just a me-problem.
Anyway, looks like something is causing the whole app to crash when closing workspace tabs.

Restore a session that has multiple code windows
Window -> Merge All Windows
Click the tab close button on an inactive repo
Code disappears, have to restart it.


PR for warning and message fixes in the code

Warning and message fixes
Updated README.md badge

Warning/message fixes have been done and CodeQL has initialized as code scanner for the solution.


Help team implement consumer side of contract test

Help a team implement consumer side of the test. They need to generate the pact file that can be shared later with the provider team.

would have been great...


PAR halo region filling to fix #66

Fixes #66

Not sure why the test workflow isn't running, I've run most locally and this shouldn't effect them anyway so going to merge so Si can use it


Use Gravatar

This is a nice one to use if the user's set it up, and real simple to do.
CC @tantalor

My gravatar agrees

We probably want an avatar chooser, which would then set the state in a, say, profile collection. The current avatar chooser is minimalistic.
+1


Usernames are not checked for duplicates across organizations

Describe the bug
It's possible to create multiple users with the same loginname when they're in different organizations.
Only works if you disable checking for whether the loginname contains the org domain.
To Reproduce
Steps to reproduce the behavior:

Create an organization
Create a user. Change its loginname to "user"
Create another organization
Create a new user in the second organization. Change its loginname to "user"
There is no error

Expected behavior
I expect to be warned about that, because one of the users can't login to the console anymore.
Version used
v2.0.0-v2-alpha.43

Hi @pr0gr8mm3r, thanks for reporting this!
I tried reproducing this one but i receive an error.
What I did:

Create two orgs each with the "User Loginname must contain orgdomain" off
Create a user in org 1 with the name<EMAIL_ADDRESS>- Success
Create a user in org 2 with the name<EMAIL_ADDRESS>- Failed
Create a user in org 2 with the name<EMAIL_ADDRESS>- Success
Rename the user in org from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>- Failed

@pr0gr8mm3r can you provide us screenshots from the two users?

Hm, can't seem to be able to reproduce it anymore. Might have been a typo or something on my end.
Consider this closed, thanks for your quick response.

👍 happy to help.
We like when people report potential issues.


nop with delay T2 - 2 instead of T2 - 1?

Why does the nop have a delay of T2 - 2 instead of T2 - 1?
https://github.com/ithinuel/ws2812-pio-rs/blob/37ade6dd937c62c2b9c0b0fe212c291fe5f33317/src/lib.rs#L107
Usually it's T - 1 because the instruction itself uses a cycle and then you want to wait T - 1 more cycles.
The offical raspberry pi pio ws2812 example also uses T2 - 1.
https://github.com/raspberrypi/pico-examples/blob/afd1d2008f3fb3fa7a837dd1bdf17a6fecbc57fe/pio/ws2812/ws2812.pio#L25

It is likely a typo. You're welcome to open a PR to fix that :)


EnderIO-1.7.10-<IP_ADDRESS>9 crash

Getting java.lang.ClassNotFoundException: crazypants.enderio.conduit.BlockConduitBundle,
and java.lang.NoClassDefFoundError: mods/immibis/core/api/multipart/IMultipartRenderingBlockMarker
crashlog: http://paste.atlauncher.com/view/cdd71440

(is this the same thing that was happening a few months back with cofh's outdated apis? i seem to recall something like this happening previously.

Hard to say, I need to download that log and cut it into sessions.
First guess would be load order.

Try updating immibis core


MCS-1816 [Webenabled] Improve styling

Some notes:

Ended up making things look similar to the analysis UI website, since we already kind of do that for the home page as well with the similar colors + didn't want to get too whacky with color scheme.
Used the footer we use everywhere -- I can always change it to something else.
I had originally intended to utilize more space on the left for some of the outputs, but it didn't actually make sense in practice, so I went with Thomas' suggestion (slightly modified) on how to order things in the middle.
Wanted to find different ways to display the shortcuts section (tried making it a collapsible div but it didn't quite work out right with the new layout). Originally left it more or less the same as it is, but then last minute changed things so that its on the bottom left (thought it'd be nice to save some screen real estate on a smaller monitor, but maybe that doesn't matter so much). Here's how the two different versions look in case anyone has a preference:

vs

Some of my changes were nitpicks about naming conventions ("some_div" vs "some-div" for instance), so apologies for the diffs!

@ThomasSchellenbergNextCentury Thanks for the feedback! I believe I addressed all of your comments, let me know if there's anything else.


[Task] Improve CodeMirror addons with multiplexer.

Code mirror addons don't support multiplexed modes.
As a result, we're left with hacking our way around them to get our desired behaviour.
Potential solutions:

Contribute to codemirror with multiplexer aware addons.
Write and maintain our own set of codemirror addons.

What do you think @riodeuno @hetunandu?

Contributing to the same add-ons would not help a lot since they are in the process of rewriting the whole thing in codemirror 6 anyways.
Seems to me, having our own addons for these is a better way to go as code editing is a critical part of the app. This will give us more control over this part of the codebase

Not picking it up in light of implementing it ourselves


GitHub issues: Add 'Reported Upstream' label to Minecraft issues when author comments with Mojira issue key

Is your feature request related to a problem? Please describe.
The current GitHub workflow closes Minecraft issues and tells the reporter to report it on the Mojang bug tracker (Mojira), and then to comment the issue key (e.g. MC-123456).
Maybe (please correct me if this is wrong) it is easy for you as maintainers to miss when the reporter comments the issue key.
Describe the solution you'd like
The GitHub workflow could be extended to detect issue commention creation events, then:

if the issue is labeled 'Minecraft'
and the issue does not have the 'Reported Upstream' label yet
and the comment is created by the issue author
and the comment contains text which looks like a Mojira issue key

... the workflow could add the 'Reported Upstream' label.
Describe alternatives you've considered
Leave it as it is
Additional context
Example where the author commented with the issue key: https://github.com/microsoft/openjdk/issues/168#issuecomment-972525413

Bad Bot


Form name field change

Previously facing issue where card signs would sometimes not include the full name. This was potentially caused by two problems:

Not being clear enough that we require the full name and not just the first name.

Autocomplete requiring two name fields for first and last name, and only filling in the first name when autocompleting for out field that should request for the full name.

To alleviate this, the change hopes to make the message more clear to the signer and turns off autocomplete for the name field.

Looks good, but there are conflicts to resolve

Going to close this as duplicate.


[BUG] Discord Call buttons get misaligned when streaming or using Spotify control plugin

Client Mod
Powercord
Description of bug
The background bar doesn't increase in width when streaming which causes the deafen button to not be in the bar and when using Spotify Control the visual bugs get worse
Steps to reproduce
just start streaming with or without Spotify control plugin found here https://github.com/mwittrien/BetterDiscordAddons
Suspected cause
code doesn't extend the bar and can't handle the extra height from Spotify control
Screenshots

This issue is unique

[X] I have searched the issue tracker and did not find an issue describing my bug.

Since you are using Powercord, please use the built-in powercord-spotify plugin. As for the background of the call buttons, this bug is hard to fix as they become too big when you aren't on a game.


Generation hash that is the same as Testnet.

First I want to say these scripts are very useful and easy to use.
The generation hash should be different for each instance of the NEM blockchain. When I ran the scripts the generation hash is the same as testnet.

Thanks for bringing that up!  Will resolve in the next commits (along with other fixes).

fixed as of f6e88f2, can be use with --local


[Question] comparison with range-v3

To my knowledge, range-v3 is aimed at a feature complete ranges library for CPP.
But it's not for Unreal, because:

Unreal's container types (e.g. TArray) do not support Ranges out of the box (yet?),

After adding "the necessary customization point objects" to range-v3, how good is that comparing to IGRanges ?
I don't see any "LINQ style" mentioned in range-v3 though, so this might be the competitive point of IGRanges?
Or could I use this two libraries together?
Thanks for this wonderful plugin!

I encountered some compliant errors:

Hello! Thanks for showing interest in this plugin.
Sorry to see you're having compilation errors.
I've been using this with UE 5.3, Visual Studio 2022, and the MSVC v143 toolchain.
It's hard to say what's different with your environment, but I suspect that you're compiling with an older toolchain or not targeting C++20.

As far as compatibility with other libraries, all I can say is that there's nothing really magical about IGRanges - so if all you're looking for is a way to use std::ranges stuff with Unreal containers, then all you need is the code in CustomizationPoints.h.
Everything else in this plugin builds on top of std::ranges just to make common operations easier so you can write less code.
For example, OfType<T>() is simply a combination of std::views::transform & std::views::filter.

Nevermind, I was on Clang 18(Linux), UE5.5. These errors might simply come from missing standard headers then, I will check it later. Might open up a PR for 5.5.
How do you like supporting multiple engine versions? One branch for every supported engine version?

At this point, I haven't taken any steps to explicitly support multiple engine versions.
I've been fortunate enough that the code just works in 5.3 (where I spend most my time) and 5.4.
I'll have to test with 5.5 soon, but I don't expect any issues.

_Range_closure seems an implement detail of compiler, the one in std is called range_adaptor_closure which comes with cpp23

You're probably right about _Range_closure - like it's a MSVC thing & then Clang will have something similar, but it wasn't standardized for C++20.
So... I don't really have a fix in the works for that because I'm not setup to build with Clang.
The other errors about missing things like empty_view are puzzling, though, because they should be part of C++20.
Perhaps they're red herrings due to the prior compilation errors.

IDK things about developing on Linux, but I guess it's possible that Clang 18 doesn't fully support the all C++20 features required for ranges.
Or, perhaps your standard libraries are not up to date? The internet tells me this will be something like libc++ or libstdc++ 🤷♂

Hey guys, I tried to combine this repository with ranges-v3 recently, and made some progress here. Hope it helps.
I'm will to help merging those changes back to this repository if you want.
Anyway, feel free to pick or copy those changes.


HDDS-2076. Read fails because the block cannot be located in the container

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
73
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
73
Maven dependency ordering for branch

+1
mvninstall
630
trunk passed

+1
compile
374
trunk passed

+1
checkstyle
74
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
966
branch has no errors when building and testing our client artifacts.

+1
javadoc
180
trunk passed

0
spotbugs
482
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
713
trunk passed

_ Patch Compile Tests _

0
mvndep
37
Maven dependency ordering for patch

+1
mvninstall
588
the patch passed

+1
compile
433
the patch passed

+1
javac
433
the patch passed

-0
checkstyle
46
hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
755
patch has no errors when building and testing our client artifacts.

+1
javadoc
191
the patch passed

+1
findbugs
704
the patch passed

_ Other Tests _

-1
unit
218
hadoop-hdds in the patch failed.

-1
unit
236
hadoop-ozone in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

6566

Reason
Tests

Failed junit tests
hadoop.ozone.container.ozoneimpl.TestOzoneContainer

hadoop.ozone.container.keyvalue.TestKeyValueContainer

hadoop.ozone.om.ratis.TestOzoneManagerRatisServer

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1410

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6744f31fdc7d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / fa7f03f

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/1/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/1/testReport/

Max. process+thread count
1270 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
70
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
75
Maven dependency ordering for branch

+1
mvninstall
630
trunk passed

+1
compile
372
trunk passed

+1
checkstyle
72
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
938
branch has no errors when building and testing our client artifacts.

+1
javadoc
177
trunk passed

0
spotbugs
481
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
711
trunk passed

_ Patch Compile Tests _

0
mvndep
37
Maven dependency ordering for patch

+1
mvninstall
651
the patch passed

+1
compile
426
the patch passed

+1
javac
426
the patch passed

-0
checkstyle
38
hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
0
the patch passed

-1
whitespace
0
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
811
patch has no errors when building and testing our client artifacts.

+1
javadoc
198
the patch passed

+1
findbugs
729
the patch passed

_ Other Tests _

-1
unit
203
hadoop-hdds in the patch failed.

-1
unit
227
hadoop-ozone in the patch failed.

+1
asflicense
38
The patch does not generate ASF License warnings.

6647

Reason
Tests

Failed junit tests
hadoop.ozone.container.ozoneimpl.TestOzoneContainer

hadoop.ozone.container.keyvalue.TestKeyValueContainer

hadoop.ozone.om.ratis.TestOzoneManagerRatisServer

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1410

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b9279037373a 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3b9584d

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/2/artifact/out/diff-checkstyle-hadoop-hdds.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/2/artifact/out/whitespace-eol.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/2/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/2/testReport/

Max. process+thread count
1274 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
25
Maven dependency ordering for branch

+1
mvninstall
581
trunk passed

+1
compile
383
trunk passed

+1
checkstyle
81
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
881
branch has no errors when building and testing our client artifacts.

+1
javadoc
178
trunk passed

0
spotbugs
418
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
612
trunk passed

_ Patch Compile Tests _

0
mvndep
38
Maven dependency ordering for patch

+1
mvninstall
544
the patch passed

+1
compile
394
the patch passed

+1
javac
394
the patch passed

+1
checkstyle
88
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
713
patch has no errors when building and testing our client artifacts.

+1
javadoc
177
the patch passed

+1
findbugs
704
the patch passed

_ Other Tests _

-1
unit
196
hadoop-hdds in the patch failed.

-1
unit
195
hadoop-ozone in the patch failed.

+1
asflicense
46
The patch does not generate ASF License warnings.

6058

Reason
Tests

Failed junit tests
hadoop.ozone.container.keyvalue.TestKeyValueContainer

hadoop.ozone.container.ozoneimpl.TestOzoneContainer

hadoop.ozone.om.ratis.TestOzoneManagerRatisServer

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1410

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux cdb643d21b64 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 60af879

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/3/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/3/testReport/

Max. process+thread count
1263 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
82
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
32
Maven dependency ordering for branch

+1
mvninstall
660
trunk passed

+1
compile
387
trunk passed

+1
checkstyle
79
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
967
branch has no errors when building and testing our client artifacts.

+1
javadoc
175
trunk passed

0
spotbugs
494
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
715
trunk passed

-0
patch
562
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

0
mvndep
45
Maven dependency ordering for patch

+1
mvninstall
715
the patch passed

+1
compile
475
the patch passed

+1
javac
475
the patch passed

+1
checkstyle
103
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
885
patch has no errors when building and testing our client artifacts.

+1
javadoc
221
the patch passed

+1
findbugs
846
the patch passed

_ Other Tests _

-1
unit
250
hadoop-hdds in the patch failed.

-1
unit
2796
hadoop-ozone in the patch failed.

+1
asflicense
70
The patch does not generate ASF License warnings.

9721

Reason
Tests

Failed junit tests
hadoop.ozone.container.keyvalue.TestKeyValueContainer

hadoop.ozone.container.ozoneimpl.TestOzoneContainer

hadoop.ozone.client.rpc.TestReadRetries

hadoop.ozone.client.rpc.Test2WayCommitInRatis

hadoop.ozone.client.rpc.TestDeleteWithSlowFollower

hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1410

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 98e5c8d82f67 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9221704

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/4/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/4/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/4/testReport/

Max. process+thread count
4356 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1410/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


App crashes before launch when adding the line: "apply plugin: 'com.google.gms.google-services'"

My app crashes before it even launches when I try to add firebase messaging. As soon as I add this line into the end of my build.gradle:
apply plugin: 'com.google.gms.google-services'

the app will crash before it launches. If I take the line out, everything is fine.
My terminal looks like this
Initializing gradle...                                              0.7s
Resolving dependencies...                                           1.6s
Running Gradle task 'assembleDebug'...                           Running Gradle task 'assembleDebug'... Done                        10.7s
Built build/app/outputs/apk/debug/app-debug.apk.

and then it will just freeze here. A dialog pops up on the android emulator that says "MyApp has stopped. Open app again."
I'm using  firebase_messaging: ^5.1.6 in my pubspec.yaml.
Flutter Doctor is fine:
[✓] Flutter (Channel stable, v1.9.1+hotfix.5, on Mac OS X 10.15
    19A583, locale en-CA)

[✓] Android toolchain - develop for Android devices (Android SDK
    version 29.0.1)
[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
[✓] Android Studio (version 3.4)
[✓] VS Code (version 1.39.2)
[✓] Connected device (1 available)

I've put my google-services.json file in my android/app folder. I followed all the instructions at https://pub.dev/packages/firebase_messaging.
Just in case, here is my build.gradle file
buildscript {
    repositories {
        google()
        jcenter()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:3.2.1'
        classpath 'com.google.gms:google-services:4.3.0'
    }
}

allprojects {
    repositories {
        google()
        jcenter()
    }
}

rootProject.buildDir = '../build'
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

and my other build.gradle file
def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
    localPropertiesFile.withReader('UTF-8') { reader ->
        localProperties.load(reader)
    }
}

def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
    throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}

def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
    flutterVersionCode = '1'
}

def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
    flutterVersionName = '1.0'
}

apply plugin: 'com.android.application'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
    compileSdkVersion 28

    lintOptions {
        disable 'InvalidPackage'
    }

    defaultConfig {
        // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
        applicationId "io.myapp"
        minSdkVersion 18
        targetSdkVersion 28
        versionCode flutterVersionCode.toInteger()
        versionName flutterVersionName
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
    }

    buildTypes {
        release {
            // TODO: Add your own signing config for the release build.
            // Signing with the debug keys for now, so `flutter run --release` works.
            signingConfig signingConfigs.debug
        }
    }
}

flutter {
    source '../..'
}

dependencies {
    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'com.android.support.test:runner:1.0.2'
    androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
}

apply plugin: 'com.google.gms.google-services'

I have no idea what is going on.
Any help is greatly appreciated. Thanks

sorry. I forgot to add the line
    implementation 'com.google.firebase:firebase-analytics:17.2.1'
in my build.gradle, like so:
dependencies {
    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'com.android.support.test:runner:1.0.2'
    androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
    implementation 'com.google.firebase:firebase-analytics:17.2.1'
}

apply plugin: 'com.google.gms.google-services'

How did you figure this out?  It's not in the documentation to add this line.  I've been stuck for ages on it.


Added and fixed  DisableLocalAuth rules

Description
Added and fixed  DisableLocalAuth rules
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing

Codecov Report

Merging #125 (8d3f470) into main (792bd87) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   45.97%   46.14%   +0.17%
==========================================
  Files          58       58
  Lines        2806     2815       +9
==========================================
+ Hits         1290     1299       +9
  Misses       1504     1504
  Partials       12       12

Impacted Files
Coverage Δ

internal/scanners/appcs/rules.go
91.11% <100.00%> (+0.20%)
:arrow_up:

internal/scanners/cog/rules.go
89.74% <100.00%> (+1.50%)
:arrow_up:

internal/scanners/evgd/rules.go
89.47% <100.00%> (+0.28%)
:arrow_up:

internal/scanners/evh/rules.go
91.83% <100.00%> (+0.17%)
:arrow_up:

internal/scanners/sb/rules.go
92.00% <100.00%> (+0.16%)
:arrow_up:


[DNM ]Ci-cd: setup compliance checks

This is a pretty large PR and looks like it's pulling in ALL of Zephyr's CI checks. I don't think we really need as this is just a module.
What if we start small with a simple build check for one target device?

This is a pretty large PR and looks like it's pulling in ALL of Zephyr's CI checks. I don't think we really need as this is just a module.
What if we start small with a simple build check for one target device?

yes I agree, I will remove unnecessary scripts and rebase / create a new PR.

I've been maintaining size-optimized containers for local development and CI which could be a good basis for our use case. I haven't documented how to use them in CI but it should be straightforward.

Thanks for that reference @beriberikix , I will check it out.
Meanwhile the example-application given by Zephyr seemed adequate and easy to me so I decided to give it a shot,
But as you can see it fails:
<command-line>: fatal error: /__w/gsoc-[20](https://github.com/zephyrproject-rtos/gsoc-2022-arduino-core/actions/runs/3508707301/jobs/5877301749#step:5:21)22-arduino-core/gsoc-2022-arduino-core/zephyr/../modules/lib/Arduino-Zephyr-API/variants/arduino_nano_33_ble/arduino_nano_33_ble.overlay: No such file or directory

This is because we have the name "Arduino-Zephyr-API" hardcoded in our CMakelists.
Good thing is atleast there is progress on the fact that the existing zephyr docker container seems to work well and atleast reach the west build command, and ALSO find the project sample.
However we need to figure a way to somehow do 2 things,

We need to install the actual Arduino Core API somehow (our install.sh script)
Also need to find a way to make the docker container have this project inside the proper path ie.modules/lib/Arduino-Zephyr-API/

@beriberikix  Kindly review this, there is nothing to really test here other than the CI Build passes and you can see the logs if you click on the "Details" for Build/ Build under checks.
Just for reference one of the passing logs can be seen here:  https://github.com/zephyrproject-rtos/gsoc-2022-arduino-core/actions/runs/3609412749/jobs/6082591758
Failing logs just for demo purposes till this PR merges, can be found here:
https://github.com/DhruvaG2000/arduino-core-testing/actions/runs/3609437467/jobs/6082631266
Where I have deliberately added an error in the code.


Enrichment results do not have all data columns mentioned

Hi there,
When running backr, the only columns in the retrieved enrichment results are rank, term, pval, and overlap. The other columns mentioned in the read me (fdr, odds, and escore) are not retrieved--they don't appear to be in the source code. If you could add them to the source code that would be greatly appreciated!
Thank you!
Best,
Molly

Hi Molly,
We are working to fix it. Thank you for letting us know about this issue.
Best,
Avi


Dev containerservice microsoft.container service 2020 06 01

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

/LGTM

Can one of the admins verify this patch?

new change in this API version comparing with previous 2020-04-01 https://github.com/Azure/azure-rest-api-specs/pull/9914/files/fd15ec5b1dfc785141f087058a22334052bbf1b4..b633249bd22e3025038e30a0ac29d0842cfe2299#diff-82e00574a0a5fc54c9cab4d58d7721f4, all new changes in 2020-6-01 is reviewed and signed off by ARM in private branch via below PRs:
-Add API 2020-06-01 #9701
-Add PPG #9701
-add new API for private endpoint connections on AKS #9706
-Added enableAzureRBAC property in ManagedClusterAADProfile #9771
-Add swagger definition for user assigned identity #9737


Windows 10 cannot get frame from drone

I am using win 10 (64) python 3 and opencv from conda-forge channel.
Code:
`from pyardrone import ARDrone
drone = ARDrone()
drone.navdata_ready.wait()
drone.video_ready.wait()
image = drone.frame
`
navdata_ready.wait() -> returns immediatelly with result: true, video_ready.wait() stucks and then I get following result:
warning: Error opening file (/build/opencv/modules/videoio/src/cap_ffmpeg_impl.hpp:834)
warning: udp://localhost:59693 (/build/opencv/modules/videoio/src/cap_ffmpeg_impl.hpp:835)
True
So it still returns True after warnings but drone.video_client.frame is always NONE
FFMPEG is included in opencv.
Result from cv2.getBuildInformation():
Video I/O:
Video for Windows:           YES
DC1394:                      NO
FFMPEG:                      YES (prebuilt binaries)
avcodec:                   YES (ver 57.107.100)
avformat:                  YES (ver 57.83.100)
avutil:                    YES (ver 55.78.100)
swscale:                   YES (ver 4.8.100)
avresample:                YES (ver 3.7.0)
DirectShow:                  YES
Tried on lubuntu and it works normally.
What could I do to make it work on windows?

Seems like opencv cannot read video from the socket in Windows. Do you have an active firewall?

I have tried with disabled firewall but the issue still persist. Currently working on linux now so I am closing issue.


Stablize api, provide backward compatibility and deprecation warning

Hi,
Pytorch Lightning is great and I enjoy the Keras-like standard training routine with the highly customizable pytorch experience.
I do plan to move most of my pytorch models training to PyTorch-lightning but the rapid release this weeks broke my code several time, and maintaining multiple version on different environments is such a headache.
I do appreciate the move to a better api interface ie tng_dataloader vs training_dataloader.
However, I do think it is necessary to provide backward compatibility between minor version update.
I would like to create a pull-request to provide the polyfilling code and corresponding deprecation warning.  The list of changes I observed in these few days are

[x] tng_dataloader -> training_dataloader

[x] experiment-> logger

Is there any more things that i can add to the list?

Great idea! Version 5.0 should have been the last major API change. The minor releases where to fix critical bugs around logging, and the new ddp2.
You can find all those changes in #119

Implemented.


Adding a button to every row.

Is there a way to add a custom button to every row of the table and call a my own function on the button click?
Just for information,
I will be using the button for moving that particular row UP or DOWN.
Please do let me know if you need any clarification with what exactly i am trying to achieve here.
Thank you.

Found  any solution to this ? I am stuck too !!

There are multiple ways in which this could be implemented I guess, one would be to use the click function of a column to alter the value of another column on which the table is sorted. Once the value is updated the table needs to be redrawn (trigger a refresh). This would however require two separate columns one for up and one for down, not a big deal really but the other option as of now would be to use the custom column example and create a component with two buttons in it and listen for their events using a service. I'm abroad at the moment without access to a computer but I'll be back in a few days and it shouldn't take long to setup a small example using plunker:)

@onkar-joshi-invimatic  and @echoIshwor, I've added an example on how to use column click, which could be used for changing row order and a lot of other things, hope it helps. Let me know if this is what you tried to achieve. Please not that I've made small changes to the code too so make sure you update to the latest version v4.3.1.

@hjalmers  , Thank you  for the reply!! , I added the action buttons in the table the way you described, everything's working as expected but the problem is I am unable to add custom style to thead and action buttons in the table. The gap between the action buttons is way too large. I think its because each button is wrapped inside  each td element, not sure though. Is there any possible way to add any number of buttons inside one single td  with custom css??
This was what I was trying to accomplish:

@echoIshwor each column gets a unique class name (object key turned into dash string followed by -column) e.g. emailAddress would get the following class email-address-column applied to it. Or you could provide your own class name using the classNames property.
Style headings (thead) using tr th.email-address-column and body rows using tr td.email-address-column.
You could then set the padding and width to be whatever you want it to be for the columns containing buttons.
You could also try applying bootstrap classes to your columns e.g. px-0 to remove the padding to the left and to the right of your buttons. Since tables naturally want to distribute the width evenly, you need to force it down by setting width to 0.
If you want to add multiple buttons into one column please check the custom component example:)

@hjalmers , I think i am doing something wrong with my own component.  when I give default bootstrap classes to classNames property it works, but if i try to assign my own custom css class to same classNames property it doesn't work. Same thing with styling  thead element and all.
I am not able to override style with my own.
I have used <generic-table tag inside my own component and none of the style from inside this component is working. idk why.

Perhaps you're adding the style to your component without turning off ViewEncapsulation? Unless you turn it off your styles will only apply to the specific component and not it's children (there are other ways without making the styles global but haven't tried them out myself) eg. angular.io/guide/component-styles.

@hjalmers I turned  ViewEncapsulation to None  and everything works. Thank you for all the help :))


feat(validator): add support to validate essential metrics produced by Kepler

This commit introduces functionality to validate essential metrics produced by Kepler
The following comparisons are included:

Node Exporter Comparison

Validates node_rapl_<package|core|dram> metrics against kepler_node_<package|core|dram>{dev}

Kepler Process Comparison

Compares kepler_process_<package|core|dram|platform|other|uncore>{latest} metrics to
kepler_process_<package|core|dram|platform|other|uncore>{dev}

Kepler Node Comparison

Validates kepler_node_<package|core|dram|platform|other|uncore>{latest} against
kepler_node_<package|core|dram|platform|other|uncore>{dev}

Additionally, the following changes are made to existing functionality:

Adds a new metric_validations.yaml file which includes promql queries for comparisons along with threshold values
Update the existing stressor.sh script to now support few more parameters to make it more flexible

warmup time: time to wait before starting the stressor
cooldown time: time to wait after the stressor is finished
repeats: number of times to repeat the stressor. Since for
regression test we don't want to repeat the stressor multiple times

Adds a new validator-regression.yaml file which includes the configuration for the regression test

Here is sample CI run that would look like for reference once we have this merged: https://github.com/sustainable-computing-io/kepler-metal-ci/actions/runs/12366281744/job/34512777104
My idea is to use the equinix runners on demand on PR's. Reviewers or authors can add a comment in the PR something like /test-regression which will trigger a workflow like this which can test if metrics produced by PR code base Kepler are off to what is already present in latest


add (placeholder) workflow for regenerating the integration tests

Short description of the problem this fixes or functionality that this introduces. This may be used for the CHANGELOG
I really struggle to run the integration tests locally. This script would allow us to run them inside of a GitHub action
Most likely we will need to set an LLM_API_KEY as well.

Give a summary of what the PR does, explaining any non-trivial design decisions
For now, this just makes a minor change to README.md, so I can check the logic of the workflow. But it needs to be checked into main before I can run it manually to test it.
Once it's verified working, I will follow up with another PR that actually gets it to regenerate

Link of any specific issues this addresses

The api key should already be set up in the repo secrets as it is used for integration tests, afaik?


Simple JSON to result-set converter

We should build a simple JSON to result-set converter.
Rules for this converter:

Each object is creating a new row
Each pair name/value is transformed into a column and the value of this cell
Underlying object follow the previous rule, name o the column is prefixed by name of the underlying object
A single array is allowed, all elements of this array will create a new row
If more than one array is available in the JSON file then one of them must be ignored

[X] basic JSON converter to result-set (see rules above)
[X] add support for result-set by name (and not only by index)
[X] refactor result-set comparison
[ ] refactor single-row comparison
[ ] extract method for value comparison to a new (or existing?) class


Fix EoL dates in data/releases/schedule.yaml

/kind bug
Currently the data about the EoL of release is inconsistent between https://kubernetes.io/releases/patch-releases/ and https://kubernetes.io/releases/.

/assign @jimangel @cpanato

you also need to update content/en/releases/patch-releases.md

content/en/releases/patch-releases.md is updated, this is from where I took the updated EoL dates.


Assume PIPENV_VENV_IN_PROJECT when a local virtual environment exists

Frequently I run into the situation where pipenv's virtual environment was created with PIPENV_VENV_IN_PROJECT=1 via Makefile or other setup script, but when I go to run a one-off command some time later, pipenv creates a new virtual environment missing my dependencies:
$ PIPENV_VENV_IN_PROJECT=1 pipenv install pytest
Creating a virtualenv for this project…
⠋New python executable in /private/tmp/test/.venv/bin/python
Installing setuptools, pip, wheel...done.

Virtualenv location: /private/tmp/test/.venv
Installing pytest…
Collecting pytest
  Using cached pytest-3.4.1-py2.py3-none-any.whl
Collecting pluggy<0.7,>=0.5 (from pytest)
Collecting six>=1.10.0 (from pytest)
  Using cached six-1.11.0-py2.py3-none-any.whl
Collecting py>=1.5.0 (from pytest)
  Using cached py-1.5.2-py2.py3-none-any.whl
Collecting funcsigs; python_version < "3.0" (from pytest)
  Using cached funcsigs-1.0.2-py2.py3-none-any.whl
Requirement already satisfied: setuptools in ./.venv/lib/python2.7/site-packages (from pytest)
Collecting attrs>=17.2.0 (from pytest)
  Using cached attrs-17.4.0-py2.py3-none-any.whl
Installing collected packages: pluggy, six, py, funcsigs, attrs, pytest
Successfully installed attrs-17.4.0 funcsigs-1.0.2 pluggy-0.6.0 py-1.5.2 pytest-3.4.1 six-1.11.0

Adding pytest to Pipfile's [packages]…
Installing dependencies from Pipfile.lock (272659)…
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 12/12 — 00:00:02
To activate this project's virtualenv, run the following:
 $ pipenv shell

$ pipenv run pytest
Creating a virtualenv for this project…
⠋New python executable in /Users/Browning/.local/share/virtualenvs/test-6C_DLGjE/bin/python
Installing setuptools, pip, wheel...done.

Virtualenv location: /Users/Browning/.local/share/virtualenvs/test-6C_DLGjE
Error: the command pytest could not be found within PATH or Pipfile's [scripts].

This change sets PIPENV_VENV_IN_PROJECT automatically if the virtual environment directory already exists locally. I think this will reduce many of the problems people have documented running into on https://github.com/pypa/pipenv/issues/1049.

This would be pretty helpful usability-wise :)
On Sat, Feb 24, 2018 at 12:18 PM Jace Browning<EMAIL_ADDRESS>wrote:

Frequently I run into the situation where pipenv's virtual environment was
created with PIPENV_VENV_IN_PROJECT=1 via Makefile or other setup script,
but when I go to run a one-off command some time later, pipenv creates a
new virtual environment missing my dependencies:
$ PIPENV_VENV_IN_PROJECT=1 pipenv install pytest
Creating a virtualenv for this project…
⠋New python executable in /private/tmp/test/.venv/bin/python
Installing setuptools, pip, wheel...done.
Virtualenv location: /private/tmp/test/.venv
Installing pytest…
Collecting pytest
Using cached pytest-3.4.1-py2.py3-none-any.whl
Collecting pluggy<0.7,>=0.5 (from pytest)
Collecting six>=1.10.0 (from pytest)
Using cached six-1.11.0-py2.py3-none-any.whl
Collecting py>=1.5.0 (from pytest)
Using cached py-1.5.2-py2.py3-none-any.whl
Collecting funcsigs; python_version < "3.0" (from pytest)
Using cached funcsigs-1.0.2-py2.py3-none-any.whl
Requirement already satisfied: setuptools in ./.venv/lib/python2.7/site-packages (from pytest)
Collecting attrs>=17.2.0 (from pytest)
Using cached attrs-17.4.0-py2.py3-none-any.whl
Installing collected packages: pluggy, six, py, funcsigs, attrs, pytest
Successfully installed attrs-17.4.0 funcsigs-1.0.2 pluggy-0.6.0 py-1.5.2 pytest-3.4.1 six-1.11.0
Adding pytest to Pipfile's [packages]…
Installing dependencies from Pipfile.lock (272659)…
🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 12/12 — 00:00:02
To activate this project's virtualenv, run the following:
$ pipenv shell
$ pipenv run pytest
Creating a virtualenv for this project…
⠋New python executable in /Users/Browning/.local/share/virtualenvs/test-6C_DLGjE/bin/python
Installing setuptools, pip, wheel...done.
Virtualenv location: /Users/Browning/.local/share/virtualenvs/test-6C_DLGjE
Error: the command pytest could not be found within PATH or Pipfile's [scripts].

This change sets PIPENV_VENV_IN_PROJECT automatically if the virtual
environment directory already exists locally. I think this will reduce many
of the problems people have documented running into on #1049
https://github.com/pypa/pipenv/issues/1049.
You can view, comment on, or merge this pull request online at:
https://github.com/pypa/pipenv/pull/1492
Commit Summary

Assume PIPENV_VENV_IN_PROJECT when a local virtual environment exists

File Changes

M HISTORY.txt
https://github.com/pypa/pipenv/pull/1492/files#diff-0 (2)
M pipenv/environments.py
https://github.com/pypa/pipenv/pull/1492/files#diff-1 (2)
M tests/test_pipenv.py
https://github.com/pypa/pipenv/pull/1492/files#diff-2 (9)

Patch Links:

https://github.com/pypa/pipenv/pull/1492.patch
https://github.com/pypa/pipenv/pull/1492.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pypa/pipenv/pull/1492, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABhjqxNdJ4YWMtCdeGT7DBJIYIzgS2Lpks5tYG6dgaJpZM4SSB3i
.

I dig it!


Add support for running wasm-opt

And configuring:

(most importantly) its optimization level (ie -Os vs -Oz vs -O3 etc)
what passes are enabled or disabled
maybe also installing it if necessary?

https://github.com/WebAssembly/binaryen

i think that we should fundamentally expose this through #153 - in line with our desire to have a more convention over configuration tool to expose pre-configured "build" options to the user. do those three build modes cover the behavior we'd want to see @fitzgen or is there more we would want to expose? i'm very cautious about overwhelming the use with options and configuration (tho #160 will certainly help with that)

I think we definitely need to expose control over optimization level. The other knobs I am "meh" on.
Regarding pre-configured builds: totally agree! I also don't think that is mutually exclusive with exposing knobs to change the default of some setting within each build. For example, cargo lets you do this with things like:
[profile.release]
# By default release doesn't build with debug info, but we are customizing that here.
debug = true
# Tell rustc to optimize for size, rather than its default of optizing for speed.
opt-level = "s"

I think we could do the same kind of default build configurations that do the 95% thing out of the box + knobs if you need them for the other 5% approach.

I'll take care of this.

For what it worth, binaryen-rs has just gained support for setting optimization levels. This allows for achieving same functionality as with wasm-opt.

Ok as an update from the binaryen side of things they should now have binary releases configured for Windows/OSX as well as Linux platforms! A sample release looks like this and should be continuously happening for all future releases. It looks like tags are version_$N and the artifacts that we're interested in are:

binaryen-version_$N-x86_64-apple-darwin.tar.gz
binaryen-version_$N-x86_64-linux.tar.gz
binaryen-version_$N-x86_64-windows.tar.gz

All tarballs should have the directory structure $tarball_name/$binary.exe, where the binaries are just under the first folder.
I suspect we'll probably want to just hardcode a version number to download for now, but we can over time figure out a scheme for auto-updating binaryen downloads too

I've started work on this locally and hope to have a PR by tomorrow.

PR: https://github.com/rustwasm/wasm-pack/pull/625


[BUG] Linked with alias has some issue

Hi when I select any text and press my hotkey for the command link with alias (when the same text is note copied before | this symbol) then it put a character [[̥ you can see it here. Then I have backspace one time to clear that character and then start typing my note name. If I don't do backspace then it also include that character as first character of my note search and hence I can't find any note because I don't have any note with that character.

You can see it in screenshot. My selected text was "shraddha" and I write the text before this | symbol was "Shraddha" but without backspacing that character and hence it put that circle like character below the first character of my inserted text. And it is not a seperate character but it is attached to first letter of my word. Please fix this issue.

@Gourav1910
I need more information, otherwise I will close this issue as not reproducible at the end of this year.


Move Token_id to Mina_numbers

This is a no-op.
Checklist:

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

This would have actually been clearer if the first commit was
$ git mv src/lib/mina_base/token_id.ml src/lib/mina_numbers/token_id.ml


Stamp PDF: Distances to the page margin are not identical

In "Stamp PDF" the positioning is not exact. For example, if the stamp is to be in the top right-hand corner (with a narrow margin), the distance between the text and the top and right-hand margins is not identical.

It looks like the positioning is the same ratio as the page, so if one of the dimensions is a lot larger than the other, the difference will be a lot more extreme.


Add a functionality for publishing to GitHub Pages

PR to fix issue #267

What is missing is documentation, including instructions on how to pull files from the git repository you created. And I don't know whether to add some message to the final listing that the git repository gh-pages was successfully created.


⚠ ClamAV has degraded performance

In 56bd4a7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 526 ms

Resolved: ClamAV performance has improved in ae7be98.


Fixing ScrollForYouFeedBenchmark

Description of the problem:
Benchmarks failing because this dialog is in the middle.

Expected solution:
@get:Rule
val grantPermissionRule = GrantPermissionRule.grant(Manifest.permission.POST_NOTIFICATIONS)

@get:Rule
val benchmarkRule = MacrobenchmarkRule()

Actual solution: manually dismissing the Alert Dialog.

@astamato Do you want to change this PR to "Ready for review" or are you still working on it?

@dturner Not ready yet, TY


Build: Use latest github actions

Description

Use .NET 8.0.x
Use the latest action version @v4
Removed unused ASSEMBLY_VERSION env

Updating to the latest action version also removes the warning in the workflow:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v3

How Has This Been Tested?
I ran the workflow in my fork, and it works (until the deploy job)
Type of Changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.

I would also like to update the remaining workflows in the workflows project.

@xC0dex Thanks for the PR.  Been meaning to update to v4.
The runners all come preinstalled with 6 7 and 8 https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#net-tools
So the version in setup is a bit superfluous but would be good to set it to 8.

Thanks @xC0dex

The runners all come preinstalled with 6 7 and 8

Thanks, that's good to know. I added the README file to my bookmarks 👍.


There is no reuse objects

https://github.com/golang/go/blob/master/src/net/rpc/server.go
unc (server *Server) getRequest() *Request {
	server.reqLock.Lock()
	req := server.freeReq
	if req == nil {
		req = new(Request)
	} else {
		server.freeReq = req.next
		*req = Request{}   //There is no reuse objects
	}
	server.reqLock.Unlock()
	return req
}

func (server *Server) getResponse() *Response {
	server.respLock.Lock()
	resp := server.freeResp
	if resp == nil {
		resp = new(Response)
	} else {
		server.freeResp = resp.next
		*resp = Response{}
	}
	server.respLock.Unlock()
	return resp
}

I don't see a bug report here.  At least, if this is a bug report, I don't understand it.
Please ask questions on a forum -- see https://golang.org/wiki/Questions .  If, after asking a question, we determine that there is a bug here, please go ahead and file an issue or comment on this one.
Closing.

I believe this was about every call meaning an alloc. This isn't a bug report though, and if it's a suggestion to improve performance it should come with a reason why and a possible solution (e.g. pool).

this is pool
type Request struct {
	ServiceMethod string   // format: "Service.Method"
	Seq           uint64   // sequence number chosen by client
	next          *Request // for free list in Server
}

put to pool
func (server *Server) freeRequest(req *Request) {
	server.reqLock.Lock()
	req.next = server.freeReq
	server.freeReq = req
	server.reqLock.Unlock()
}

get from pool
func (server *Server) getRequest() *Request {
	server.reqLock.Lock()
	req := server.freeReq
	if req == nil {
		req = new(Request)
	} else {
		server.freeReq = req.next
		*req = Request{}  //realloc
	}
	server.reqLock.Unlock()
	return req
}

@mvdan

The code is not my main concern - what I meant is why this is a bottleneck or problem or any sort. Optimizations like these should in general only be done where they actually affect performance considerably.


what is the Tensorflow version that i can compile with bazel 3.7.1?

I try to compile the project on CentOS 8.2
the last version of Bazel on centos is 3.7.1.
when I compile the last version I get an error that the installation required 3.7.2.
what version of TensorFlow will be compiled with Bazel 3.7.1
and how to change the TensorFlow version to make it work.
thanks

Hi, you can either install Bazel 3.7.2 manually or try to set TENSORFLOW_TAG CMake parameter (e.g., cmake -DTENSORFLOW_TAG=v2.4.0 ..)


Hiding something from indices does not seem to work.

The problem
The CONTRIBUTING document says:

If you wish to hide a heading from any index, prefix it with the empty comment Z<>.

There seem to be a few instances of that being used, for instance here. However, there does not seem to be any support for it in the generating script (htmlify.p6) and it does not seem to actually be working, since that function is actually inserted.
Suggestions
That paragraph was inserted by @gfldex, apparently, 3 years ago. I don't know if it's simply a non-working feature or something that should be removed from the site. Some clarification from someone who remembers the rationale about it will help.

Suggestion: if it doesn't work, let's remove the comment and close this ticket, esp. in the absence of an issue asking for the feature.

Looks like this text was already removed.


[REQUEST] Play Time Counter

Is your feature request related to a problem? Please describe.
Not necessarily a problem but it would be helpful to have a way to track how long I've played each game in my library.
Since there’s no way to know how much time I’ve spent on each title, which is a feature I love like on Steam 💯
Describe the solution you'd like
I’d love to see a Play Time Counter for each game similar to what Steam offers.
It could be displayed in the game library or on the game's details page, showing total hours played
Describe alternatives you've considered
There aren’t many alternatives I can think of, other than manually tracking playtime, but an integrated counter would be much more convenient
Additional context
I think this feature would add value for users who like tracking their game time and would make the launcher even more user-friendly 👍🏻

I'm not sure if I understood your request. We have a counter in the games page:

I'm not sure if I understood your request. We have a counter in the games page:

Hm weird, I might not be running the latest version then perhaps? I do not have this for some reason.

You need to set the game executable path so Hydra can track the time that the game is running (you can do it in the Options button on my screenshot)
If you have already done it, could you send a screenshot of your whole Hydra window while running a game?

@hornyalcoholic, any updates? Did it work?

Yup, this indeed fixed the Issue. Thanks!


Deprecate methods using Guava ListenableFuture [run-systemtest]

com.yahoo.processing.Response.recursiveComplete()
com.yahoo.processing.response.DataList.complete()
com.yahoo.processing.response.IncomingData.completed()

Also fixes bug in FutureResponse where get() does not return value produced by async task.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@bratseth PTAL


$CI_PIPELINE_URL always <base_url>/repos/<repo_id>/pipeline/0

Component
server, agent
Describe the bug
The pipeline ID of the CI_PIPELINE_URL environment variable is always zero and not the actual pipeline ID. I don't know if the bug is in the server or in the agent.
System Info
Version 2.0.0. Agent and server running on the same host and started manually.

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

Duplicate of https://github.com/woodpecker-ci/woodpecker/issues/2672. Sorry for the noise.


Timezones via a slider

earmuffs (Discord) — 2023-07-03 3:42 PM
You could maybe add a slider to offset the timezone by hand?

Or just always have the time relative to Solar Noon:
https://www.timeanddate.com/astronomy/solar-noon.html#:~:text=In terms of solar time,sky%2C except at the poles.


Test cleanup

Description
This PR does a lot of things for test cleanup:

moves the integration tests into their respective packages, getting rid of the tests directory in repository root.

tearing them apart in quite some cases

cleaning up the integration test suites so they have a more useful structure of Describe, Context and It
upgrades to ginkgo v2, so we can use Ordered containers (useful for e.g. vsphere tests)
changes make test and make func-test to use ginkgo instead of go test

Release Note
Release note for CHANGELOG:

NONE

References

SYSENG-689

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Codecov Report

Merging #94 (c618013) into main (02fcc44) will decrease coverage by 24.62%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #94       +/-   ##
===========================================
- Coverage   56.05%   31.43%   -24.63%
===========================================
  Files          95       71       -24
  Lines        4178     3713      -465
===========================================
- Hits         2342     1167     -1175
- Misses       1459     2472     +1013
+ Partials      377       74      -303

Flag
Coverage Δ

integration
?

unittests
31.43% <ø> (+2.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fcc44...c618013. Read the comment docs.

I strongly suggest reviewing the individual commits, I took care to have meaningful ones. Reviewing the PR as whole is not going to be fun.
I also think "tests OK and coverage not dropped down" is a good review for most of the changes in this PR, but your view might be different :)

Codecov Report

Merging #94 (2b016f0) into main (ee3a150) will increase coverage by 1.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   55.82%   57.16%   +1.33%
==========================================
  Files          95       86       -9
  Lines        4195     4081     -114
==========================================
- Hits         2342     2333       -9
+ Misses       1476     1363     -113
- Partials      377      385       +8

Flag
Coverage Δ

integration
57.16% <ø> (+13.13%)
:arrow_up:

unittests
33.05% <ø> (+3.78%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apis/lbaas/v1/backend_genclient.go
0.00% <0.00%> (-73.47%)
:arrow_down:

pkg/apis/lbaas/v1/loadbalancer_genclient.go
0.00% <0.00%> (-18.75%)
:arrow_down:

pkg/lbaas/backend/paged.go
59.18% <0.00%> (-4.09%)
:arrow_down:

pkg/core/api.go

pkg/lbaas/lbaas.go

pkg/api.go

pkg/utils/test/gomega/interface.go

pkg/clouddns/api.go

pkg/utils/test/hostname.go

pkg/test/api.go

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3a150...2b016f0. Read the comment docs.

Codecov Report

Merging #94 (f03b988) into main (ee3a150) will increase coverage by 3.03%.
The diff coverage is 60.11%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   55.82%   58.86%   +3.03%
==========================================
  Files          95       89       -6
  Lines        4195     4242      +47
==========================================
+ Hits         2342     2497     +155
+ Misses       1476     1334     -142
- Partials      377      411      +34

Flag
Coverage Δ

integration
58.86% <60.11%> (+14.82%)
:arrow_up:

unittests
31.68% <0.00%> (+2.41%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apis/lbaas/v1/loadbalancer_genclient.go
0.00% <0.00%> (-18.75%)
:arrow_down:

pkg/lbaas/bind/bind.go
42.95% <ø> (ø)

pkg/lbaas/server/server.go
41.37% <ø> (ø)

pkg/apis/lbaas/v1/frontend_genclient.go
65.07% <52.38%> (+65.07%)
:arrow_up:

pkg/apis/lbaas/v1/backend_genclient.go
64.51% <53.84%> (-8.96%)
:arrow_down:

pkg/apis/lbaas/v1/server_genclient.go
67.24% <67.24%> (ø)

pkg/apis/lbaas/v1/bind_genclient.go
68.85% <68.85%> (ø)

pkg/apis/lbaas/v1/types.go
100.00% <100.00%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3a150...f03b988. Read the comment docs.


Bump Ubuntu container version and MUSL-related libs

Several reasons, including but not limited to:

MUSL-compiled OpenSSL benefits from MUSL versions 1.2.0 and up, otherwise it needs to be badly patched, see https://github.com/fornwall/rust-static-builder/issues/3#issuecomment-638085541.
DWARFv2 compressed debugging symbols mess up with old toolchains and linkers, see https://github.com/rust-bio/rust-htslib/pull/231.

Almost there, only one target failing! Weird since this target does have hard float:
cc1: error: '-mfloat-abi=hard': selected processor lacks an FPU

https://dev.azure.com/rust-embedded/cross/_build/results?buildId=681&view=logs&j=a134d3ac-19f9-5b18-b9f9-e20a7ce298ca&t=d355af61-270d-5eea-cd8e-e7caee8e7120&l=139882

@bors retry
That was just a curl/tls timeout: https://dev.azure.com/rust-embedded/cross/_build/results?buildId=682&view=logs&j=e6deedce-f53c-5dcc-524e-14349f140ffd&t=9e60ab89-47e0-5dc9-e657-a2fbb695cbf9&l=5186

bors r+

Thanks @Emilgardis 👍🏻
Does any of the reviewers fear that something is going to break or similar side effects? The changes are not so many IMHO :-S


Add new tag for hotfix branches

PR Title :boom:
Please title this PR with a summary of the change, along with the JIRA card number.
Suggested formats:

Fixes/Refs #RHIROS-XXX - Title
RHIROS-XXX Title

Feel free to remove this section from PR description once done.
Why do we need this change? :thought_balloon:
Please include the context of this change here.
Documentation update? :memo:

[ ] Yes
[ ] No

Security Checklist :lock:
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
:guardsman: Checklist :dart:

[ ] Bugfix
[ ] New Feature
[ ] Refactor
[ ] Unittests Added
[ ] DRY code
[ ] Dependency Added
[ ] DB Migration Added

Additional :mega:
Feel free to add any other relevant details such as links, notes, screenshots, here.

Codecov Report
All modified lines are covered by tests :white_check_mark:
:loudspeaker: Thoughts on this report? Let us know!.


App Manager breaks when having a work profile and/or secure folder.

According to this section
https://github.com/ibilux/MobyDroid/blob/master/src/com/hq/mobydroid/device/TaskPackageMangerList.java#L41
the app manager invokes adb shell pm list packages
however that command basically fails completely when you have multiple users like Samsung's Secure Folder or an Android Enterprise Work Profile.
Exception occurred while executing 'list':
java.lang.SecurityException: Shell does not have permission to access user 11
 com.android.server.am.ActivityManagerService.handleIncomingUser:14999 android.app.ActivityManager.handleIncomingUser:4805 com.android.server.pm.PackageManagerShellCommand.translateUserId:3517
        at com.android.server.am.UserController.handleIncomingUser(UserController.java:2680)
        at com.android.server.am.ActivityManagerService.handleIncomingUser(ActivityManagerService.java:14999)
        at android.app.ActivityManager.handleIncomingUser(ActivityManager.java:4805)
        at com.android.server.pm.PackageManagerShellCommand.translateUserId(PackageManagerShellCommand.java:3517)
        at com.android.server.pm.PackageManagerShellCommand.runListPackages(PackageManagerShellCommand.java:969)
        at com.android.server.pm.PackageManagerShellCommand.runListPackages(PackageManagerShellCommand.java:865)
        at com.android.server.pm.PackageManagerShellCommand.runList(PackageManagerShellCommand.java:724)
        at com.android.server.pm.PackageManagerShellCommand.onCommand(PackageManagerShellCommand.java:226)
        at com.android.modules.utils.BasicShellCommandHandler.exec(BasicShellCommandHandler.java:97)
        at android.os.ShellCommand.exec(ShellCommand.java:38)
        at com.android.server.pm.PackageManagerService$IPackageManagerImpl.onShellCommand(PackageManagerService.java:7071)
        at android.os.Binder.shellCommand(Binder.java:1085)
        at android.os.Binder.onTransact(Binder.java:903)
        at android.content.pm.IPackageManager$Stub.onTransact(IPackageManager.java:4962)
        at com.android.server.pm.PackageManagerService$IPackageManagerImpl.onTransact(PackageManagerService.java:7055)
        at android.os.Binder.execTransactInternal(Binder.java:1321)
        at android.os.Binder.execTransact(Binder.java:1280)

users can be pulled like this:
adb shell pm list users

Users:
        UserInfo{0:MY-NAME:c13} running
        UserInfo{11:Arbeitsprofil:1030} running       ----> workprofile
        UserInfo{151:Secure Folder:10061030} running

now when you use adb shell pm list packages --user 0 to only query the normal user, it works fine in the shell.
so you could query who the current user is with adb shell am get-current-user and only list that user's app or invoke for each user on its own.

good catch & better diagnostic @My1. I'll look into this.

thanks no problem, I have used my decent share of adb and I basically just traced back the code from the app manager java file (which was pretty easy thanks to github's auto tracer), because I knew somewhere it has to invoke adb

@My1 I have implemented the user id for pm commands in v0.7.
It seem to work in my end (but i didn't had a problem before).
I'll appreciate if you can also test the enable/disable apps in the App Manager because it invokes pm command too.

I totally havent noticed your addition, sorry for being so late
it works, thanks a ton.
talking about the appmanager, I picked out another small problem, which likely should be its own issue tho, split off if needed:

Apparently it cuts off the app name after a space.


Fixes a typo in the CLI - s/profile/project

Summary
Fixes a small typo.
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 47.354% (+0.006%) from 47.348%
when pulling 3262767ac39c4b6ef348a2610cdcdad8581ad111 on project
into 6f69727b17ed9ac0cfa5ffeaa3d01cff7ef7a3ef on main.


Create toolbar composer and add create Entity Form

Description

Short description here *

closes Add ticket reference here
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[X] Attached issue to pull request
[X] Changelog entry
[X] Code is clear and sufficiently documented
[] Sufficient test cases (reproduces the bug/tests the requested feature)
[X] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Processing this pull request

Pull request rejected by merge tool. Failed to parse change entry file: Invalid changelog entry file /tmp/tmplzvp8_gj/changelogs/unreleased/4756-composer-embedded. Changelog entry files should always end with a .yml extension.

Processing this pull request

Pull request rejected by merge tool. Multiple change entry files found (changelogs/unreleased/39-yaml-security-issue.yml,changelogs/unreleased/4353-recompile-button-update.yml,changelogs/unreleased/4534-add-support-for-type-migration.yml,changelogs/unreleased/4660-add-support-e2e-for-oss.yml,changelogs/unreleased/4736-env-selector-ux.yml,changelogs/unreleased/4737-form-bugs.yml,changelogs/unreleased/4752-attributes-table-fix.yml,changelogs/unreleased/4753-resources-naming.yml,changelogs/unreleased/4754-composer-read-only.yml,changelogs/unreleased/4756-composer-embedded.yml,changelogs/unreleased/4764-fix-unit-tests.yml,changelogs/unreleased/4766-edit-form-update.yml,changelogs/unreleased/4767-notification-clear-issue.yml,changelogs/unreleased/4770-dependabot.yml,changelogs/unreleased/4775-dependabot.yml,changelogs/unreleased/4778-dependabot.yml,changelogs/unreleased/4780-dependabot.yml,changelogs/unreleased/4785-dependabot.yml,changelogs/unreleased/4790-select-input-fix.yml,changelogs/unreleased/4797-workaround-race-condition.yml,changelogs/unreleased/4798-dependabot.yml,changelogs/unreleased/4803-dependabot.yml,changelogs/unreleased/4805-dependabot.yml,changelogs/unreleased/4809-dependabot.yml,changelogs/unreleased/4812-dependabot.yml,changelogs/unreleased/4814-dependabot.yml,changelogs/unreleased/4820-dependabot.yml,changelogs/unreleased/4831-dependabot.yml,changelogs/unreleased/4839-dependabot.yml,changelogs/unreleased/4842-dependabot.yml,changelogs/unreleased/4845-dependabot.yml,changelogs/unreleased/4847-dependabot.yml,changelogs/unreleased/4851-dependabot.yml,changelogs/unreleased/4854-dependabot.yml,changelogs/unreleased/4856-dependabot.yml,changelogs/unreleased/4859-composer-toolbar.yml,changelogs/unreleased/4863-dependabot.yml,changelogs/unreleased/4865-enable-keycloak.yml,changelogs/unreleased/4867-dependabot.yml,changelogs/unreleased/4882-dependabot.yml,changelogs/unreleased/4885-redirection-keycloak.yml,changelogs/unreleased/4886-dependabot.yml,changelogs/unreleased/4889-dependabot.yml,changelogs/unreleased/4892-dependabot.yml,changelogs/unreleased/4895-dependabot.yml,changelogs/unreleased/4897-dependabot.yml,changelogs/unreleased/4899-dependabot.yml,changelogs/unreleased/4901-dependabot.yml,changelogs/unreleased/4906-dependabot.yml,changelogs/unreleased/4910-add-support-textarea.yml,changelogs/unreleased/repair-build-script.yml,changelogs/unreleased/repair-expertmode-tests.yml,changelogs/unreleased/update-index-file.yml). This may happen when a change entry was removed from the remote repository due to a reverted change. In that case, make sure the latest changes from origin/master are merged into issue/4859-toolbar-composer before triggering merge bot.

Processing this pull request

Merged into branches master, iso6 in 2cc8f335ee391fe116af5a37cfc9910374e160a5


Support multiple upstream

Supports multiple upstream.
For example, execute the following command to proxy / to UI server
and /api to the API server:
$ takanawa /api:http://localhost:8080/v1 http://localhost:3000

Request
Proxy

http://localhost:5000
http://localhost:3000

http://localhost:5000/help
http://localhost:3000/help

http://localhost:5000/api/greeting
http://localhost:8080/v1/greeting

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b0e7ee4). Click here to learn what that means.
The diff coverage is 80.45%.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   80.45%
=========================================
  Files             ?        9
  Lines             ?      174
  Branches          ?        0
=========================================
  Hits              ?      140
  Misses            ?       29
  Partials          ?        5

Impacted Files
Coverage Δ

internal/util/http.go
0% <0%> (ø)

takanawa.go
100% <100%> (ø)

middleware/access_log.go
100% <100%> (ø)

internal/util/strings.go
100% <100%> (ø)

middleware/request_id.go
100% <100%> (ø)

middleware/cors.go
100% <100%> (ø)

internal/util/net.go
64.28% <64.28%> (ø)

middleware/reverse_proxy.go
83.33% <83.33%> (ø)

internal/util/default.go
85% <85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e7ee4...393f325. Read the comment docs.


Replace download cancelled message with a localized message

[x] I have signed the Contributor License Agreement.
[x] This pull request is related to an issue.

This proposes to fix issue #3558 by replacing the error message with a slightly more generic but already existing resource string.
Microsoft Reviewers: Open in CodeFlow

/azp run


Automator: update<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

Generated by Automator - 2023-06-06T02:16:39+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio_release-1.17
4218ef4f59304e4787390346a16e802420b122c2
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio_release-1.17
4218ef4f59304e4787390346a16e802420b122c2
link
true
/test integ-cni

integ-telemetry-mc_istio_release-1.17
4218ef4f59304e4787390346a16e802420b122c2
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest