[storage][blob]How to set contentMD5 when upload blob

MD5 = "208b8742aa7c13238b732fd8b7aa1722"
or
MD5 = "MjA4Yjg3NDJhYTdjMTMyMzhiNzMyZmQ4YjdhYTE3MjIgKmF6dXJlLXN0b3JhZ2UtYmxvYi0xMi4yLjAtcHJldmlldy4xLnRnego="
await blockBlobClient.uploadFile(filePath, {
blockSize: chunkSize,
blobHTTPHeaders: {blobContentMD5: Buffer.from(MD5);}})

will fail with
><Error>InvalidMd5<Message>The MD5 value specified in the request is invalid. MD5 value must be 128 bits and base64 encoded.
RequestId:76a062ee-c01e-002e-0c82-4077be000000

While
await blockBlobClient.setHTTPHeaders({ blobContentMD5: md5 });

work for both.

azure:storage-blob:info Request: {
  "streamResponseBody": false,
  "url": "https://jianch.blob.core.windows.net/newcontainer1591948757003/CDImage.ape",
  "method": "PUT",
  "headers": {
    "_headersMap": {
      "content-type": "application/octet-stream",
      "content-length": "5",
      "x-ms-version": "2019-12-12",
      "x-ms-blob-type": "BlockBlob",
      "x-ms-blob-content-md5": "NWQ0MTQwMmFiYzRiMmE3NmI5NzE5ZDkxMTAxN2M1OTI=",
      "user-agent": "azsdk-js-storageblob/12.2.0-preview (NODE-VERSION v12.13.0; Windows_NT 10.0.18362)",
      "x-ms-client-request-id": "c42edd20-64ce-47dd-8349-381fe956d64b"
    }
  },
  "withCredentials": false,
  "timeout": 0,
  "keepAlive": true,
  "requestId": "c42edd20-64ce-47dd-8349-381fe956d64b"
}
(node:36092) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
azure:storage-blob:info Response status code: 400
azure:storage-blob:info Headers: {
  "_headersMap": {
    "connection": "close",
    "content-length": "276",
    "content-type": "application/xml",
    "date": "Mon, 15 Jun 2020 14:02:53 GMT",
    "server": "Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0",
    "x-ms-client-request-id": "c42edd20-64ce-47dd-8349-381fe956d64b",
    "x-ms-error-code": "InvalidMd5",
    "x-ms-request-id": "b2e07457-e01e-0080-091d-43daaf000000",
    "x-ms-version": "2019-12-12"
  }
}
<?xml version="1.0" encoding="utf-8"?><Error>InvalidMd5<Message>The MD5 value specified in the request is invalid. MD5 value must be 128 bits and base64 encoded.
RequestId:b2e07457-e01e-0080-091d-43daaf000000
Time:2020-06-15T14:02:54.4895171Z</Message></Error>

Well, the right base64 encoded MD5 for "hello" should be 'XUFAKrxLKna5cZ2REBfFkg=='.
  const content = "hello";
  const md5Cal = crypto.createHash("md5").update(content).digest("hex");
  await blockBlobClient.upload(content, content.length, {
    blobHTTPHeaders: { blobContentMD5: Buffer.from(md5Cal, "hex") },
  });

The contentMD5 should be raw binary data. SDK will do the base64 encode.
Put Blob, i.e. upload do validate the content MD5

I was wrong because I passed the hex string to the Buffer.from but forgot to specify the hex encoding.
The BlobHTTPHeaders  is used by both upload and setHTTPHeaders, the comments is misleading.
export interface BlobHTTPHeaders {
...
  /**
   * Optional. An MD5 hash of the blob content. Note that this hash is not validated, as the hashes
   * for the individual blocks were validated when each was uploaded.
   */
  blobContentMD5?: Uint8Array;
}

TODO:
The BlobHTTPHeaders is used by both upload and setHTTPHeaders, the comments is misleading.
export interface BlobHTTPHeaders {
...
  /**
   * Optional. An MD5 hash of the blob content. Note that this hash is not validated, as the hashes
   * for the individual blocks were validated when each was uploaded.
   */
  blobContentMD5?: Uint8Array;
}


Build Create Api, not working

I called Build Create APi
POST /api/repos/{namespace}/{name}/builds

But it not working, retrun
{"message":"Not Found"}

However, I call Restart Api and it works normally
Is the way I called it wrong?

:wave: hey there, per our issue template, for end-user support and general questions please use one of our support channels, such as our chatroom or our mailing list.


Changes to do the following:

Update Zephyr to v 3.6
Allow arguments to be passed to flash command
Add support for esp32 and Raspberry Pi Pico W hardware

Would you mind to update also https://github.com/micro-ROS/micro_ros_zephyr_module to 3.6?

CI is failing fro Zephyr

CI is failing fro Zephyr

I think this is just because you requested changes...  It looks to me like all of the automated CI passed, no?

No https://github.com/micro-ROS/micro_ros_setup/actions/runs/8239753062/job/22546953150?pr=690

Oh, sorry, I didn't see that there was a scrollbar in the GitHub "Some checks were not successful" window. ;)

Is there a way to see exactly what part of a CI check failed?
The first one ends with:
Could not determine ref type of version: fatal: unable to access 'https://github.com/micro-ros/freertos_apps/': Could not resolve host: github.com
I have to assume that was just a transient network issue.
The others have logs that are so long that you have to download them to see the end, and at the end they look fine (as far as I can tell, anyway... it appears that they successfully built their image).

It seems that installing host tools failed: https://productionresultssa2.blob.core.windows.net/actions-results/a1779061-dac5-4f1d-af6f-dc2b1f527ea6/workflow-job-run-fceeb432-9719-5700-0c51-e887f4ac21da/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-03-13T16%3A22%3A52Z&sig=UUjF6yn%2F%2FoXzcdXHbEPaR1lminKPfe7dD73%2F85Ls7Pw%3D&sp=r&spr=https&sr=b&st=2024-03-13T16%3A12%3A47Z&sv=2021-12-02
You can click on full log on the failed CI jobs

It seems that installing host tools failed: https://productionresultssa2.blob.core.windows.net/actions-results/a1779061-dac5-4f1d-af6f-dc2b1f527ea6/workflow-job-run-fceeb432-9719-5700-0c51-e887f4ac21da/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-03-13T16%3A22%3A52Z&sig=UUjF6yn%2F%2FoXzcdXHbEPaR1lminKPfe7dD73%2F85Ls7Pw%3D&sp=r&spr=https&sr=b&st=2024-03-13T16%3A12%3A47Z&sv=2021-12-02
You can click on full log on the failed CI jobs

Do you believe that the authentication problem is somehow related to the code changes?

It shall be because nightly CI is ok

It shall be because nightly CI is ok

Is there any way to force CI to run again? It could obviously be an intermittent outage (this CI wasn't run at the same time as your nightlies), and I can't really think of any other reason that would cause "Could not resolve host: github.com".

Retriggered

Retriggered

THanks. One of the failures went away as I expected, so I'll assume that was just a transient connectivity outage. The others happened again, so I'll have to take a deeper look.

In any case, the recommended way of using Zephyr + micro-ROS is the Zephyr component: https://github.com/micro-ROS/micro_ros_zephyr_module

In any case, the recommended way of using Zephyr + micro-ROS is the Zephyr component: https://github.com/micro-ROS/micro_ros_zephyr_module

OK, I'll give the zephyr module a try.  I don't think we even knew about it. It's not even mentioned in the tutorials on micro.ros.org as far as I can see.

In any case, the recommended way of using Zephyr + micro-ROS is the Zephyr component: https://github.com/micro-ROS/micro_ros_zephyr_module

Pablo, could you provide a little more information about how the module is supposed to be installed and used?  There are lots of different ways to use west to build zephyr. I personally think that for things like this it is most convenient to provide users with instructions for building "out of tree" so that they can try things out without messing up any existing build tree that they have. If the module is intended to be incorporated into an existing tree, I think the README should at least provide pointers to how to set up such a build tree and how to pull in the module.

In any case, the recommended way of using Zephyr + micro-ROS is the Zephyr component: https://github.com/micro-ROS/micro_ros_zephyr_module

Pablo, could you provide a little more information about how the module is supposed to be installed and used?  There are lots of different ways to use west to build zephyr. I personally think that for things like this it is most convenient to provide users with instructions for building "out of tree" so that they can try things out without messing up any existing build tree that they have. If the module is intended to be incorporated into an existing tree, I think the README should at least provide pointers to how to set up such a build tree and how to pull in the module.
I'm brushing up on Zephyr modules a little bit, but as far as I can tell, this repository doesn't conform to the definition of a module repository (which should contain a top-level directory called "zephyr" that contains a file called "module.yml"): https://docs.zephyrproject.org/latest/develop/modules.html
I'm sure I could futz around and copy various files into various places and get it to build, but I think the README should really explain how to do this (or at least provide pointers to Zephyr documentation that explains what to do).

PR are welcomed

It seems that installing host tools failed: https://productionresultssa2.blob.core.windows.net/actions-results/a1779061-dac5-4f1d-af6f-dc2b1f527ea6/workflow-job-run-fceeb432-9719-5700-0c51-e887f4ac21da/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-03-13T16%3A22%3A52Z&sig=UUjF6yn%2F%2FoXzcdXHbEPaR1lminKPfe7dD73%2F85Ls7Pw%3D&sp=r&spr=https&sr=b&st=2024-03-13T16%3A12%3A47Z&sv=2021-12-02
You can click on full log on the failed CI jobs

The reason that 5 of the CI jobs are failing is:
2024-03-13T20:43:17.0170651Z Zephyr SDK 0.16.3 Setup 2024-03-13T20:43:17.0171007Z  2024-03-13T20:43:17.0213832Z Installing host tools ... 2024-03-13T20:43:20.8686738Z ERROR: Host tools installation failed 2024-03-13T20:43:20.8694405Z [ros2run]: Process exited with failure 30 2024-03-13T20:43:21.1664014Z ##[error]Process completed with exit code 30.
I suspect that some of the dependencies are different for SDK 0.16.3 than they were for 0.12.4. Is there any way I can see the Dockerfile that's being used for the CI build container?

https://github.com/micro-ROS/micro_ros_setup/blob/f3f222d847dfe500ace1b85254d763b8718edb16/.github/workflows/ci.yml#L102-L103

I tried updating the SDK to 0.16.5 just to see if that makes any difference in the host tools installation issue. Probably not, but the limited logging isn't giving me much to work with, so it seemed worth a try.

Are we able to rerun CI?  I don't really know of any other way to debug this, since there isn't much information provided about why the host tool install is failing, and I can't reproduce this problem in my own environment.

Reruned

I am not able to get micro_ros_zephyr_module to build. I think that it's intended to be built as what the Zephyr documentation calls a "freestanding app" (which is different from a true "module", which is why I was confused). Either way, I get lots of errors when I even try to build it with the version 2.7 that you support. https://docs.zephyrproject.org/latest/develop/application/index.html

Are you able to consider these changes independently of whatever changes might be required in micro_ros_zephyr_module? We don't use micro_ros_zephyr_module to build microROS under Zephyr.

I need to not break the CI to consider this

I'm going to close this PR. I already have a set of patches that allows me to build microROS with Zephyr 3.6.  The issues with translating this into a PR are related to the CI process (which I can't replicate) and with micro_ros_zephyr_module (which I can't build at all... even with the versions of Zephyr and SDK that are supposed to be supported). I'd be happy to help in any way that I can, but I think it would be easier for the microROS maintainers to handle these integration issues that aren't really directly related to the Zephyr 3.6 upgrade.


Make tuple operator work on T values instead of Tuple

I've been having problems constructing T2 values in pointfreeco, and realized that .*. should be operating on T not Tuple.
I think now it's much clearer how the T values capture a subset of a tuple that carries something like a continuation with it. For example, doing this does not give you a Tuple3
let value = 1 .*. "hello" .*. true

cause you have not terminated the continuation by doing .*. unit. Once you do this:
let value = 1 .*. "hello" .*. true .*. unit

you'll have a proper Tuple3<Int, String, Bool>!

Do you have examples of where you needed this? I've been doing some Tuple stuff (though I backed out of most of it) in PointFree and haven't had an issue.

I don't have an exact example from pointfreeco now (cause I also been leaning off tuples), but it always has this shape:
func foo<A>(_ x: T2<Int, A>) -> T3<String, Int, A> {
  return "\(get1(x))" .*. x
}

func bar<A>(_ x: T2<String, A>) -> T3<Int, String, A> {
  return get1(x).count .*. x
}

dump(bar(foo(100 .*. unit)))
dump(bar(foo(100 .*. "hello" .*. true .*. unit)))

if we were dealing with tuples we would have to handle the units specifically. dealing with only T values simplifies it.

Let's try merging this in and see how it affects things.

Will do soon! Pushing a few other small changes
On Wed, Dec 27, 2017 at 1:29 PM Stephen Celis<EMAIL_ADDRESS>wrote:

Let's try merging this in and see how it affects things.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pointfreeco/swift-prelude/pull/93#issuecomment-354165553,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIQI6g5t4OUjNkQ2YtJ2CL16uIo1faGks5tEpqJgaJpZM4RIjJA
.


Dracula for Codelobster ?

hi all,
Very nice work!
http://codelobster.com/
is a PHP / HTML / CSS / JavaScript cross platform editor used by many people.
Website, alexa rank is 388k.. Please consider to create a theme...

Hey @pipiscrew, that's a great suggestion. Have you thought about creating the theme yourself?
Here are the instructions on how to do it: https://draculatheme.com/contribute

Sorry, Im not an artist, I will try with the then given colors when free.


Set-ADSyncAADCompanyFeature -ForcePasswordChangeOnLogOn $true  - feedback to caution

[Enter feedback here]
In the section: Synchronizing temporary passwords and "Force Password Change on Next Logon", you have a warning stating:
-=-=-=-=-
Caution
You should only use this feature when SSPR and Password Writeback are enabled on the tenant. This is so that if a user changes their password via SSPR, it will be synchronized to Active Directory.
-=-=-=-=-
It is not clear why this should only be enabled with both SSPR and Password Writeback enabled. Password writeback is certainly necessary for this setting, but why is SSPR required for it? Without SSPR enabled we still want passwords to be synchronized and have them update regardless of the system our users is accessing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c900f942-4456-5238-9f4c-a7a5bd685c04
Version Independent ID: a5d7d971-765f-0977-f531-232ea5924121
Content: Implement password hash synchronization with Azure AD Connect sync
Content Source: articles/active-directory/hybrid/how-to-connect-password-hash-synchronization.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

At the moment we rely on the AD FS updatepassword endpoint to reset passwords.
I don't see why we should not enable ForcePasswordChangeOnLogOn without SSPR and password writeback. What would happen in this case?
Cannot users keep using ADFS to reset their passwords and AD Connect (ForcePasswordChangeOnLogOn enabled) would sync account to Azure AD when ForcePasswordChange attribute changes?


error while importing bitbnspy

hi I have installed bitbnspy from anaconda command prompt in windows10 using following:
pip3 install python-socketio
pip3 install bitbnspy
Installation was successful. When I am trying to import bitbnspy I am getting error:
(base) C:\Users\USER>python
Python 3.7.4 (default, Aug  9 2019, 18:34:13) [MSC v.1915 64 bit (AMD64)] :: Anaconda, Inc. on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from bitbnspy import bitbns
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'bitbnspy'

Could you please advice how to resolve this error?

did it got sorted, am also facing similar issue?

ok I have sorted this.
Try the following snippet!
from bitbnspy import bitbns
apiKey = 'A2DF8532214EABDDD0CB92A15289ED39'
apiSecretKey = '090A80EB9F7C7B2100CCED9BC143DF0E'
bitbnsObj = bitbns(apiKey, apiSecretKey)
bitbnsObj.platformStatus()

hi, @seshadri27 was able to check it in the environment you have specified, it seems to be working,
could you pls try :
pip freeze | findstr "bitbns requests" ? and ping the response (would help finding the error)
if you are unable to find those packages, then mostly likely the installation was not completed properly, would suggest trying the installation again.
pls do ping, if the issue persists

hi, @kprajaguru, thank you for the assist, but would suggest you revoke your API keys and create new ones, as they can be potentially be misused by bad actors endangering your capital, since they have been exposed.

Hi, how can i generate new API key for myself as the one mentioned by @kprajaguru doesn't seem to work. Thanks

@sanket-buyhatke, thank you very much.

@seshadri27 Hey, Did you get the issue sorted? I think the problem is that you have installed the libraries through pip3 and are now trying to run it in python.
Just try running the commands mentioned below -
pip install bitbnspy
pip install python-socketio
Then try running python and see if it works or not.

hi @seshadri27, will be closing this issue, feel free to re-open if you face the issue again.


feat: Define top-level ARIA landmark regions to improve accessibility

Feature Request
Ionic version:
[x] 4.x
Description
I’m working on a new Ionic 4 app that is based on the split-pane w\side-menu starter template. We have members on the team that specialize in UX and accessibility. I'm a developer and have been collaborating with them on improving our apps. We recently had a PR approved in 4.6.0 to assign the ARIA role 'navigation' to the menu component. Yay!
This was a proud moment, having my first pull request approved. The team seemed optimistic too...and then I had a followup meeting with one of our accessibility experts. :D
The feedback I got next was extremely useful. It went something like this: "So, you're a user and you arrive at the site and an ARIA role of 'navigation' is announced...and you think 'oh, great'! But then, there's nothing else there because none of the larger structural elements are labeled or recognizable to the assistive technology".  It was immediately apparent how incomplete my solution was within the broader context!
Preferred Solution
This feature aims at giving all perceivable content on a page a semantically meaningful role - focusing on the top-level of the Accessibility Tree.  Assigning each region a role would make it easy for assistive technology users to understand the meaning of the overall layout of a page, content and functionality it contains.
These are small, non-breaking code changes that will make significant impact. Implementation could involve using either HTML5 sectioning elements (preferred) or ARIA landmark roles, and follow WAI-ARIA guidelines. Here's what I'm considering as a mapping between landmark roles and Ionic components:

banner (for ion-header)
main (for ion-content)
contentinfo (for ion-footer)

I will be submitting a PR shortly! :)
Alternatives
Although in many cases we could simply modify the markup to improve accessibility within our own codebase, it wouldn't be DRY, and we are motivated to contribute to the Ionic Framework, and make it accessible for everyone.
References
https://www.w3.org/TR/wai-aria-practices-1.2/#html5-sectioning-elements
https://www.w3.org/TR/wai-aria-practices/examples/landmarks/banner.html
https://www.w3.org/TR/wai-aria-practices/examples/landmarks/main.html
https://www.w3.org/TR/wai-aria-practices/examples/landmarks/contentinfo.html
Related Support Case and PR
bug: Unable to set ARIA role to 'navigation' on menu component.
fix(menu): change ARIA role from complementary to navigation

Thanks again for the thorough issue and PR! I am going to close this as I believe your PR resolves it, but please correct me if I am wrong and I will reopen. 🙂


Update docs for SPFx & onprem deployments

Category

[x] Content fix

Related issues

fixes #7021

Docs Build status updates of commit f0c7543:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/set-up-your-development-environment.md
:white_check_mark:Succeeded
View

docs/spfx/sharepoint-2016-support.md
:white_check_mark:Succeeded
View

docs/spfx/sharepoint-2019-support.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Can you add the year and correct genre

Requested Feature
Can you please add the year when downloading songs from Spotify and correct Genre
Possible implementation
No response

Please open a bug report with more specific reproduction results.


scan chain update

updated scanchain, timing constraints, increase die size to 105x105um.

Whooops, github didn't send me an email. I'll deal with it tomorrow


PLT-7508: Add settings to disable wide mention confirmation

The PR mattermost/mattermost-server#7416 must be merged before it.
Links
mattermost/mattermost-server#7335
https://mattermost.atlassian.net/browse/PLT-7508
Checks

[X] Has UI changes
[X] Includes text changes and localization file

Thanks @jespino! We are working on getting test servers up and running on this repo, once that happens we'll be able to test and review this PR. Appreciate the contribution!

Perfect, thanks!

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-06ce05a6c1a487537.spinmint.com:8065/pr18
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-06ce05a6c1a487537

I have changed the @ALL text and rebased onto master. The default value comes from the server, and the default is defined in this server PR https://github.com/mattermost/mattermost-server/pull/7416/files#diff-1e9c3d615e9ebaaaa3669b4c2fd87d00L78. I can use undefined as "true" but I haven't seen this approach in the code for other settings.

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0c585145b049a9282.spinmint.com:8065/pr18
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-0c585145b049a9282

Spinmint test server destroyed


Allow to omit entity_id when using power_sensor_id option

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.731%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2714

Relevant Lines:
2777

💛  - Coveralls


[Schema] Add underline to TextRun schema

Related Issue
Fixes #4558
Description
Add the Underline property to the TextRun schema for version 1.3
Microsoft Reviewers: Open in CodeFlow

@paulcam206 / @golddove thoughts on the failing Android CI and the "microsoft.AdaptiveCards" checks? Btw do we know what this "microsoft.AdaptiveCards" pipeline is?

@paulcam206 / @golddove thoughts on the failing Android CI and the "microsoft.AdaptiveCards" checks? Btw do we know what this "microsoft.AdaptiveCards" pipeline is?

For the first error looks like it is a "out of disk" issue; @paulcam206 for these in theory re-queueing the job should hopefully pick a better agent yes? Is there a way to report these agents too?

@shalinijoshi19
Yes, I did rerun the job yesterday and it succeeded. Not sure what exactly went wrong the first time (I remember seeing a 100 minutes timeout issue).
As for the other pipeline, it's related to #4553.


Remove unused Debug Switches

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

Coverage increased (+0.0003%) to 11.995% when pulling 1b1a9bf2168de92d59c0bfa3f9e84128143c1fb1 on JaredTan95:clean into 5f5be776015e16ccad1184730c23f6276022ee08 on apache:master.


Incompatible with PHP 8.2

Which version of Blessing Skin are you using?
v6.0.2
Which version of PHP are you using?
8.1
What browsers are you seeing the problem on?
Microsoft Edge
Which web server are you using?
None
What happened?
In PHP8.2, using ${var} in strings is deprecated
Throw error:
Uncaught Whoops\Exception\ErrorException: Using ${var} in strings is deprecated, use {$var} instead in /web/blessing-skin-server/vendor/facade/ignition/src/SolutionProviders/MergeConflictSolutionProvider.php:52

In PHP8.1 it works well.
We should let users know it.
Error Logs
Symfony\Component\ErrorHandler\Error\FatalError

  Uncaught Whoops\Exception\ErrorException: Using ${var} in strings is deprecated, use {$var} instead in /web/blessing-skin-server/vendor/facade/ignition/src/SolutionProviders/MergeConflictSolutionProvider.php:52

Steps to Reproduce
Run blessing skin in PHP 8.2+

It was fixed in latest code.


Human annotations have disappeared from AmiGO annotations

The current contents of goa_human.gaf.gz in SVN contains no data, only a header. Unfortunately, AmiGO has automatically loaded this, so there are currently no human annotations in in the production AmiGO.
@cmungall suggests bringing AmiGO down in the interim.
@stuartmiyasato I would suggest using an "error" type system message (e.g. http://wiki.geneontology.org/index.php/AmiGO_2_Manual:_Administration#System_messages_and_global-message.pl ) until the new data is loaded.
AmiGO is undergoing an unexpected and necessary data reload.
Our apologies for the inconvenience. During this process, please feel free to use the <a href="http://amigo2.berkeleybop.org"><backup site/a>.

@cmungall will let us know when upstream has a fix.

See:
https://github.com/geneontology/go-site/issues/248
http://jira.geneontology.org/browse/GO-1388
http://jira.geneontology.org/browse/GO-1393

As well, we could take a CNAME redirect temporarily instead.

Although a root redirect would be fine too.

I'll try the root direct method.  I'll probably take the easy way out and redirect /* to http://amigo2.berkeleybop.org and not try to be smart about the path.

Anything is good. Since we have no sessions, and the same layout, you should be able to pass the whole thing as-is without problem...?

We need to also revert in svn, may people download directly

That's going to require more testing than I really have time for at the moment.  I'm just redirecting any path back to the home page at http://amigo2.berkeleybop.org/ right now.  But that functionality is now in place.  (I'm still dealing with Dirty COW on other servers so I don't want to spend much time on this.)

Cheers! Redirect works as intended.

Mike (no github id?) has put in a fix for the filtering script, so the data should be good again. Then plan is then, after a reload and check, revert the redirect.

I'm manually starting a load now to save about 7 hours of waiting time.  Will let you know when it's ready for testing.  (I'm not sure that we can test without removing the redirect, so we'll probably just have to do a check on the live site.)

Sorry about your Saturday :(
With the redirect to dev, we're safe as far as data goes (I turned off the reload a couple of days ago), so don't stress if you end up doing other things.
As long as there is no redirect on your golr, I can check the data from my laptop by just aiming at your addressable backend.
As well, can't we hit amigo2a, etc., directly?

I'm working today regardless to deal with remaining Dirty COW patches, so it's no big deal.  :)  Been patching for the past four hours already...
The redirect for AmiGO is being done at the Apache level on individual servers, so hitting amigo2a directly will still give you the redirect.  But GOlr is running off nginx,so you can still hit that directly at golr.geneontology.org.

Okay, great. When you're ready, we can go that way--I've already got my localhost aimed at the production golr backend.

@stuartmiyasato I now have humans again locally!

@kltm Great!  amigo2b is being refreshed at the moment.  I'll remove the redirects when it's finished.

Sorry, been dealing with some rather major disk corruption issues on some other servers tonight.  amigo2a and amigo2b are back up and running, and I've removed the redirects.  Please feel free to check production and make sure the data looks okay.  Thanks.

It looks great to me--thank you!


Added GetAllGroups

I mean, I am certain that it has a reason why Groups is an internal readonly dictionary.
Simply making a getter-like method means giving access to it and allowing it to be manipulated in a public scope

If Dimenzio prefers it to be internal, but also somewhat of accessibility, make it return a deep-copy - My two cents

Well, I understand you point but how do you want to edit a read only object?

The readonly modifier means you can just not overwrite the collection with another collection, but you can still remove and add elements from/to the dictionary (unlike an IReadOnlyDictionary)

Ok... I see what you mean. I overwork it

Now it should work because you can now only change the SynapseGroups and not the dictionary itself

It is not GetAllGroups. It is now Groups


middleware/metrics

Add some more (inspired by dnstap talk):

edns0 advertised client side
edns0 option seen
source address v4/v6
query source port?
check usage of 0x20? (I.e. camelcasing of qname) (maybe the proxy should do this and check this as well)

See #259


Use RegExp to extract html body

Current implementation extracts head tags but it shouldn't. Also, it doesn't preserve formatting.
See https://dartpad.dartlang.org/73239b9204eaf6c375dd
So an old RexExp should do the trick :)

Thanks! lgtm


Removing NSS dependency from packages.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[ ] Any updated packages successfully build (or no packages were changed)
[x] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

We're removing dependency on the NSS library in our core packages as that crypto library has not been internally approved. We're going to depend on OpenSSL instead.
Change Log

Packages switched from to OpenSSL from NSS: apr-util, rpm, systemtap, xmlsec1.
Packages, which didn't need NSS in the first place: core-packages, lttng-tools, userspace-rcu.
Updated rpm to version 4.16.0 to avoid current version's dependency on a deprecated MD2 algorithm, which we removed from OpenSSL anyway. Btw. rpm dropped support for NSS starting from the new version.

Does this affect the toolchain?

YES
Test Methodology

Full local toolchain and package build.

We're removing dependency on the NSS library in our core packages as that crypto library has not been internally approved. We're going to depend on OpenSSL instead.

Interesting. Are there other distros that don't depend on NSS?
If you're going to use OpenSSL, then you should consider using LibreSSL instead. You'll have far less CVEs show up than the original OpenSSL.

We're removing dependency on the NSS library in our core packages as that crypto library has not been internally approved. We're going to depend on OpenSSL instead.

Interesting. Are there other distros that don't depend on NSS?
If you're going to use OpenSSL, then you should consider using LibreSSL instead. You'll have far less CVEs show up than the original OpenSSL. The Powershell team already uses it for Win32-OpenSSH https://github.com/PowerShell/LibreSSL but they do tend to be out of date so pulling directly would be more prudent.

@WSLUser: thank you for the suggestion. For now, however, we're limiting CBL-Mariner to libraries approved by our internal process (as much as that's possible, of course), thus the changes. I'll have to check what's the current opinion about LibreSSL. Also, thank you for mentioning, that PowerShell is already using it - this is a useful hint.

Closing for now - we might want to move this work to a different branch.


Android 5 and 6 do not support playing local music and video

Although convertFileSrc lets you access the local music file to http://localhost:8080, it won't play in android 5 or 6.Clicking the play button does not trigger the shouldInterceptRequest override function in the IonicWebViewEngine class. It is suspected that the returned header file is missing
var  nativePath_convertFileSrc = _window.Ionic.WebView.convertFileSrc(url_music);

audio and  video

Can you try with this changes? https://github.com/ionic-team/cordova-plugin-ionic-webview/pull/295

:tada: This issue has been resolved in version 3.1.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


composite outputs weird pixels to the bottom of the image

Bug reproduces on Node.js starting at 4.x up to 9.x on both Windows and CentOS.
Here's the source image I'm using:

Here's the code:
const fs = require('fs')
const Jimp = require('jimp')

let img = new Jimp(512,720)
Jimp.read('./u_normal_navi_22109003.png').then(src => {
  img.composite(src.scale(0.9), -180, -142)
  img.getBuffer(Jimp.MIME_PNG, (err, res) => {
    fs.writeFileSync('card.png', res)
  })
})

And the output...

I think the outputted image itself is self-explainable... Look at the bottom of it... the weird black line...
And if we remove the .scale(0.9) in the code it still reproduces

I couldn't quite figure out what I was seeing with the image you gave so I experimented with something else.
Test environment
const fs = require('fs')
const Jimp = require('jimp')

let img = new Jimp(400,400)
Jimp.read('./kat.png').then(src => {
  img.composite(src, 200, -(src.bitmap.height / 2))
  img.write('card.png');
});

kat.png:

Running with Jimp 0.2.28
card.png:

This looks to me like the image is just wrapping to the start of the next line to write the next pixel.
Running with Jimp@HEAD
card.png:

This is completely different. At the top right edge, it looks like there's a line of pixels that are either basketball or skin colored, although that should be way off-canvas. On the right edge, you can see a line of pixels that matches his shoe, as well as white and navy lines to match his uniform. My guess is that it is writing either the first or last (depending on which edge) opaque pixel that it encounters off-canvas. Perhaps that pixel is saved in memory and erroneously is written on the edge instead of what should actually be there.
TL;DR
There's some weird issues where the composite is either overflowing the canvas or writing the last opaque pixel in memory on the edge.

Tried in current version (v0.3.4) with no problems


Fix toast header

Solves ToastHeader charCode console error as described in #2338

[x] Bug fix
[ ] New feature
[ ] Chore
[ ] Breaking change
[x] There is an open issue which this change addresses #2338
[x] I have read the CONTRIBUTING document.
[x] My commits follow the Git Commit Guidelines
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[ ] My change requires a change to Typescript typings.

[ ] I have updated the typings accordingly.

[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

I just removed the dangling charCode property from the defaultProps.
Closes #2338

Thanks for the PR @krnlde! Mind Updating the base branch to bootstrap5?

I'd live to, but I have another open PR on that branch: https://github.com/reactstrap/reactstrap/pull/2336


DRAFT:  Digital Ocean App deployment branch

We're deploying to digital ocean using this branch, to include additional configuration, monkey patches and debugging statements.
It should be frequently updated with upstream, and fully backwards compatible.

Hi! I'm the autofix.ci troubleshooter bot.
It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃


Responsive for all screen sizes

Description
A clear and concise description of what the PR does.

This PR does the following:

Fixes responsiveness

Related Issues
Fixed #503
Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.
Changes
List the detailed changes made in this PR.

Made the website responsivev

Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

Pull this branch.
Run npm install to install dependencies.
Run npm test to execute the test suite.
Verify that ...

Screenshots (if applicable)
Add any screenshots that help explain or visualize the changes.

Additional Context
Any additional context or information that reviewers should be aware of.

This PR is based on the following...

Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I am working on this issue under GSSOC

@saurabhsingh720
Kindly merge this PR before closing of GSSOC 🙂


Add descriptive comments to camera device and properties headers

This adds some missing header doc comments and updates other to clarify what some struct members are more exactly.
Closes #27

This is what I added so far. Still in draft, so need to take a look yet, but wanted to make sure something was visible.

@aliddell: While this is not complete, I cleaned up the header comments I added, so this should be ready for review. I'm not completely confident on all the definitions here (and deliberately used non-confident language in those cases), so if you can check them against your understanding, and make corrections and edits, that would be great!

I think this is probably good to merge now unless there are objections from @nclack ?


fix(meta): fix cpu core limit check query

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
enum is stored as string instead of number with sea-orm. Resolve #18113.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Not sure why it was not covered by the e2e-single-node-tests in https://github.com/risingwavelabs/risingwave/pull/18022.

Not sure why it was not covered by the e2e-single-node-tests in #18022.

Oh, I know why. Single node uses Sqlite, which allows string and int comparison. 🥵

Not sure why it was not covered by the e2e-single-node-tests in #18022.

Oh, I know why. Single node uses Sqlite, which allows string and int comparison. 🥵

So sea-orm or sea-query does not completely erase the difference between backends. 🥵 Perhaps we need to consider testing against all supported backends in CI.

Not sure why it was not covered by the e2e-single-node-tests in #18022.

Oh, I know why. Single node uses Sqlite, which allows string and int comparison. 🥵

So sea-orm or sea-query does not completely erase the difference between backends. 🥵 Perhaps we need to consider testing against all supported backends in CI.

Yes, I will switch all CI tests for PR to sqlite recently and we can test all backends in main-cron job.


Add support for projects in dependencies.yml

# dependencies.yml

projects:
  - name: ...

packages:
  - ...

https://github.com/dbt-labs/docs.getdbt.com/pull/3577

@dave-connors-3 Did we already do this in https://github.com/dbt-labs/dbt-jsonschema/pull/77? Asking because I still see the red underline in the IDE

@jtcohen6 yep -- that should be merged in here -- I don't know for sure that the work to grab the correct versioned schema in the IDE has happened yet!
@benmosher did you get a chance to update the pointer yet? I would say not urgent until 1.6 is actually available in the IDE (sorry jeremy)

ah but i do see packages is also an acceptable header per your example code? is that true?

the work to grab the correct versioned schema in the IDE has happened yet!

that makes sense!

not urgent until 1.6 is actually available in the IDE (sorry jeremy)

& I agree!
ty dave <3

@dave-connors-3 I have not! ticket is JIRA:XP-2347


Difficulties downloading v0.2.0

The release v0.2.0 clearly mentions:

the tag name v0.2.0
the commit id e436cb1
the breaking change "constructors no longer returns an error" e.g. NewConstant now returns a single value
the potentially breaking change "Automatically unwrap"

I confirm that the code at tag v0.2.0 / commit e436cb1 does include the new signature for NewConstant, as viewed in the GitHub web UI.
However, when downloading v0.2.0 with go get  (with a recent enough version of go), the downloaded code

includes the "Automatically unwrap" change
doesn't include the "constructors no longer returns an error"!

Here is a full repro from Cloud Shell:
deleplace@cloudshell:~$ go version
go version go1.17.2 linux/amd64

deleplace@cloudshell:~$ go get<EMAIL_ADDRESS>
go: downloading github.com/sethvargo/go-retry v0.2.0

deleplace@cloudshell:~$ cat<EMAIL_ADDRESS>| grep -A2 "if stop"
                if stop {
                        return rerr.Unwrap()
                }

deleplace@cloudshell:~$ cat<EMAIL_ADDRESS>| grep "func NewConstant"
func NewConstant(t time.Duration) (Backoff, error) {

This is tricky.
I don't know the root cause of the problem. Might be a nasty bug in the go module tooling, or the way we use it. @sethvargo do you remember if you created the tag v0.2.0 first at commit 2ee2801, then deleted it and created it anew at commit e436cb1?

I got the following error for the CI pipeline of a branch where the dependency was automatically updated:
[2022-01-04T03:15:29.531Z] #11 9.386 verifying<EMAIL_ADDRESS>checksum mismatch
[2022-01-04T03:15:29.531Z] #11 9.386 	downloaded: h1:exfyQcFOOpUZ5fGciVj3iij5ilBo9oDeNo/kLj0ijS4=
[2022-01-04T03:15:29.531Z] #11 9.386 	go.sum:     h1:DCx92rkKH4xFulbIQR1izw6h3KxJWb1lyS2sxfr7SgQ=
[2022-01-04T03:15:29.531Z] #11 9.386
[2022-01-04T03:15:29.531Z] #11 9.386 SECURITY ERROR
[2022-01-04T03:15:29.531Z] #11 9.386 This download does NOT match an earlier download recorded in go.sum.
[2022-01-04T03:15:29.531Z] #11 9.386 The bits may have been replaced on the origin server, or an attacker may
[2022-01-04T03:15:29.531Z] #11 9.386 have intercepted the download attempt.
[2022-01-04T03:15:29.531Z] #11 9.386
[2022-01-04T03:15:29.531Z] #11 9.386 For more information, see 'go help module-auth'.
[2022-01-04T03:15:32.051Z] #11 ERROR: executor failed running [/bin/sh -c go mod download]: exit code: 1

Not sure if or how this helps but it seems somewhat relevant

Thanks Florian
I suggest the v0.2.0 be retracted.

Hmm - I'm not sure what happened, but this is the second time on one of my projects where the module differs. I just retracted v0.2.0 and cut v0.2.1.


Dice parser not working within Pathfinder 2E statblocks

Check for existing bug reports before submitting.

[X] I searched for existing Bug Reports and found no similar reports.

Expected Behavior
Writing dice parser syntax (i.e. (1d20+1)) within a Pathfinder 2E layout statblock should bring up the ability to roll dice.
Current behaviour
In-line dice rolling option does not appear. It does appear when using the D&D 5e layout.

Reproduction
layout: Basic Pathfinder 2e Layout
dice: true
name: "Glyphid Grunt"
level: "Creature -1"
trait_01: "Animal"
trait_02: "Glyphid"
alignment: "N"
size: "Medium"
hp: 7
health:
  - name: "HP"
    desc: "7; __Immunities__ visual"
perception:
  - name: "Perception"
    desc: "+5; scent (imprecise) 30 feet, echolocation (precise) 60 feet, no vision"
languages: "none"
abilityMods: [2,2,0,-5,1,-4]
skills:
  - name: "Skills"
    desc: "Athletics +4 (1d20+4)"
attacks:
  - name: "Melee"
    desc: "⬻ bite +4, __Damage__ 1d4 (1d4) piercing"

Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[ ] Linux
[ ] macOS
[X] Windows

Obsidian Version Check
1.5.8 and 1.5.3
Plugin Version
3.19.3
Confirmation

[X] I have disabled all other plugins and the issue still persists.

Possible solution
No response

It's because the regex is missing from the PF2e layout


Update VERSION on master to avoid conflicts with fuji

Signed-off-by: Lisa Rashidi-Ranjbar<EMAIL_ADDRESS>

recheck

Codecov Report

Merging #2033 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2033   +/-   ##
=======================================
  Coverage   44.03%   44.03%
=======================================
  Files         186      186
  Lines       11671    11671
=======================================
  Hits         5139     5139
  Misses       6235     6235
  Partials      297      297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2af21...babf16f. Read the comment docs.


[WIP] Enable CI build on Azure DevOps

These changes enable building Fabulous on Azure DevOps as discussed in the issue 269. Tests are executed on macOS. The builds where executed on a fork:

Includes the build definition as yaml file
Adjustments to paths due to differences in the path where .Net Core is installed on ADO

The Linux build is currently still disabled due to some issues with the Generator project.

@TimLariviere I am okay with merging 🙈 still have some things I would like to try out, but I can do that on another branch. Will rebase from master once more to solve the conflicts.
The following options are still on my table:

Play around with the command line arguments a bit more - there is still one option that some references show which is currently not yet set.
Migrate to VSTest - It seems that trx is supported out of the box.

I have tried extensive profanity, but so far no luck... 😉

I am currently running into a new error on the macOS Agent. It seems that fscd is no longer happy.
Since all the other agents (Azure, Travis & AppVeyor) are happy with the changes, I am currently assuming this must be some weird configuration diff - will have to give this a scan later today 🔍

Might be related to https://github.com/fsprojects/Fabulous/pull/303

@TimLariviere could be, but why does it not affect Travis then? 🤔

@mallibone I'm currently working on Azure DevOps as well. (continued from where you were)
Now, only Linux fails (wrong msbuild -- can't build .NET Standard).
Changed the build pipeline to be more flexible and removed test reporting.
https://github.com/TimLariviere/Fabulous/pull/12

@TimLariviere oh cool you have been busy I see - very busy when looking at the merge history 😄 I will have a look at your branch then. It seems like the fscd issue is solved 🙂 may I ask what the solution was?

A good chunk of fscd has been exported to https://github.com/fsprojects/FSharp.Compiler.PortaCode
Most of the unit tests as well, but Paket still imports the unit test files from PortaCode.
I think somewhere in this PR, you changed the way we resolved the dlls for the unit tests due to dotnet packages not being in the same place (the NuGetFallbackFolder).
But this was lost with the exportation.
So Fabulous.Cli.Tests used the wrong path for dlls.
https://github.com/TimLariviere/Fabulous/blob/51146eee1159132f51c1fd59b4b6495948c14948/tests/Fabulous.Cli.Tests/TestHelpers.fs#L173-L184

@mallibone I'm currently working on Azure DevOps as well. (continued from where you were)
Now, only Linux fails (wrong msbuild -- can't build .NET Standard).
Changed the build pipeline to be more flexible and removed test reporting.
TimLariviere#12

The issue is that F# is not pre-installed on the Linux build agents - now, now, cool down @TimLariviere  & @dsyme, I am sure they have no idea on what they are missing out by not having this installed by default 🙃 (sorry could not resist this part 😇)
The latest commit(s) contain the changes from your Branch Timothé. I like the splitting into jobs - but I'm guessing you do not want to run all of them on every commit?
Further Linux now only builds GTK no Android, iOS, macOS, UWP and WPF though it would be possible to compile for Android on Linux.

Good job finding that F# was missing from the build agent!

The latest commit(s) contain the changes from your Branch Timothé. I like the splitting into jobs - but I'm guessing you do not want to run all of them on every commit?

I'm divided on this question.
We definitely need 2 separate jobs : one fast (build/test = ~5min), one complete (build/test/samples/nupkg/templates = ~25min)
Having the 3 platforms for every PRs would be awesome.
Immediate feedback if something goes wrong on a platform.
But I think it's a bit too much for pretty much all PRs.
So maybe only do 1 fast and 1 complete for PR; and 3 complete for "master"?

Well sometimes one get's lucky with Google 🙂
Since the jobs run in parallel the longest job make the duration until the feedback is here. That being said, I am a fan of fast feedback in my daily job. This being an OSS project a change could result in breaking i.e. the generated project. If we only run these tests after merging on main - well the core maintainers will have to deal with a broken main branch asap.
That being said we could make the build smarter by defining multiple yaml files for ADO and depending on where the change has happened we can expand the build. I.e. if only the core of Fabulous has been edited. Or we only enable the fast builds automatically and the long runs can be triggered manually when reviewing.
The latter would be quicker implemented and probably less fragile should a folder path change. For the "intelligent" build definitions, it would be good to know which paths contain items that are only tested in the 25min build.

If we only run these tests after merging on main - well the core maintainers will have to deal with a broken main branch asap.

It's more or less what we do today. We build fast against Windows/AppVeyor (no samples/templates tests) and slow with macOS/Travis.
If Travis succeeds, the probability the same slow build on Windows and Linux will fail is very low.

That being said we could make the build smarter by defining multiple yaml files for ADO and depending on where the change has happened we can expand the build. I.e. if only the core of Fabulous has been edited

That's what I thought at first, but if only the core is modified, it might impact both the samples and the templates so it will need a complete build as well.

Or we only enable the fast builds automatically and the long runs can be triggered manually when reviewing.

That's really interesting!
Fast feedback, initial reviewing by something and then a complete build, while minimizing the number of automatic builds launched.
I think it's the best compromise.

Okay so there are now two definitions for Azure:

PR: Only executes the build fake config on Linux, macOS and Windows
CI: Is only enabled for the master branch. Runs the full fake config on Linux, macOS and Windows.

The PR build definition is named build, and the CI build definition full. So following the docs  the following command should execute the full CI build: /AzurePipelines run full.

@mallibone Seems like there's a few issues:

The full build runs by default on PRs.
/AzurePipelines commands don't seem to have an effect?

See https://github.com/TimLariviere/Fabulous/pull/13 and https://github.com/TimLariviere/Fabulous/pull/14

@TimLariviere sorry about the full build on every pr... fixed that one with the last commit. I will have to look into the commands.

@TimLariviere Currently chating with Damien Brady to get this to work with comments but so far I haven't yet managed to get it running...  Or did you have more success on one of your test builds and it some weird configuration on my side?

@mallibone I do get something to work, but it's pretty unreliable...
PR with build-only : https://github.com/TimLariviere/Fabulous/pull/19
PR with comment to run full build : https://github.com/TimLariviere/Fabulous/pull/21
I noticed 2 things :

For multiple simultaneous PRs, Azure DevOps will run the PR Build only for the first one. The others are forever ignored. Once the first build is done, a new PR will be granted the privilege to run a new build...
When asking for a full build, the Azure Pipeline bot says the trigger exclude this branch (which is not the case). It then starts 3 full builds, cancels 2 of them and the last one runs successfully.
But Github only reports the first canceled build...

This for example : https://github.com/TimLariviere/Fabulous/pull/23
Another PR was already running, so Azure Pipelines decided there was no need to run the build for this PR.
And when forced to, Azure Pipelines said there was no build for this PR...

@TimLariviere hmm okay, that is interesting... 🤔 I just triggered some tests myself branch1 and branch2 - but I will forward your feedback. The error message is a known bug I was told, and they are working on it.
I can't reproduce the not firing trigger - there is a limit to 10 build jobs in parallel, but I would have thought they would just start to queue up. I will run some tests on my own and will try to forward any buggy results. But your findings do not sound all that great.

Replaced by #413


CodeAnt AI: Making Antipattern Fixes

CodeAnt AI: Making Antipattern Fixes
Description:

Changed for loops with set or list comprehensions to improve performance
Removed unnecessary "elif" after "return"
Remove unnecessary else statements

Motivation:
Making codebase clean

Thanks for the PR! Closing this PR as a lot of things have been updated in the SDK in the last couple of months.


add poetry proposal

Changes introduced with this PR
Add proposal to standardize on poetry for python projects.

By contributing to this repository, I agree to the contribution guidelines.

lgtm


Automated cherry pick of #10777: fix: add options for pre allow ip add

Cherry pick of #10777 on release/3.6.
#10777: fix: add options for pre allow ip add

Codecov Report

Merging #10779 (170b373) into release/3.6 (b9d30c0) will increase coverage by 6.07%.
The diff coverage is 0.46%.

@@               Coverage Diff                @@
##           release/3.6   #10779       +/-   ##
================================================
+ Coverage         5.86%   11.93%    +6.07%
================================================
  Files              828      232      -596
  Lines           129133    25991   -103142
================================================
- Hits              7577     3103     -4474
+ Misses          120876    22577    -98299
+ Partials           680      311      -369

Flag
Coverage Δ

aFlag
11.93% <0.46%> (+6.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/auth_totp.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/idp.go
1.84% <0.00%> (ø)

pkg/apigateway/handler/misc.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/resource.go
0.00% <0.00%> (ø)

pkg/apis/const.go
0.00% <0.00%> (ø)

pkg/apis/input.go
0.00% <ø> (ø)

pkg/apis/list.go
0.00% <ø> (ø)

pkg/baremetal/cronjobs.go
0.00% <0.00%> (ø)

pkg/baremetal/manager.go
0.50% <0.00%> (-0.01%)
:arrow_down:

... and 581 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eaa4ee...170b373. Read the comment docs.


split rrclient implementations

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Close in favour of https://github.com/DataDog/datadog-agent/pull/23033


npm install issue with package.json

How to reproduce the issue?
copy the below package.json and run npm install
{
  "name": "test-jspdf",
  "version": "1.0.0",
  "dependencies": {
    "jspdf": "*"
  }

}

Environment:
node version: v8.15.0
npm version: 6.4.1
Issue:
node modules are not installed with below error:
npm ERR! code ENOGIT
npm ERR! Error while executing:
npm ERR! undefined ls-remote -h -t<EMAIL_ADDRESS>npm ERR!
npm ERR! undefined
npm ERR! No git binary found in $PATH
npm ERR!
npm ERR! Failed using git.
npm ERR! Please check if you have git installed and in your PATH.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-12-31T12_00_53_251Z-debug.log

As we dont have git installed in app servers this is an issue in building the module.
Is there any alternate way to disable git and load through npm ?

Resolutions
https://yarnpkg.com/lang/en/docs/selective-version-resolutions/

@arasabbasi  Could you please provide minimal configuration using resolutions with npm to fix the issue ?


Multiple Roles

Sir I  am Having three roles such as user , student , teacher role what do i do

Questions should be asked on our slack group, or as an issue.  Pull requests are for getting code changes merged into the repository.


Audio Recorder Closes Immediately on First Click & Mike Input Icon Disappears After Multiple Conversations

Description:
Whenever I click the audio recorder for the first time, it closes in less than 0.1 seconds. On the second click, it works as expected. Additionally, after multiple conversations, the chat input icon disappears.
Steps to Reproduce:
Open the Streamlit app.
Click the audio recorder icon for the first time.
Observe that it closes immediately.
Click the audio recorder icon again.
Observe that it works correctly.
Engage in multiple conversations.
Observe that the chat input icon disappears.
Intial Image with Icon

Disappeared icon

Got the same error when running the app on iPad


Lexer error does not provide line number

Hi,
Thank you for making an awesome crate. This is my favorite Rust template library by a mile.
When writing relatively large templates, I occasionally make mistakes in the template syntax and I get a lexer error like this one:
error: Failed to compile template.
       caused by: Rust Syntax Error (lex error)

file: /home/lev/Projects/dashboard/templates/model.html

#[derive(TemplateOnce)]

note: this error originates in the derive macro `TemplateOnce` (in Nightly builds, run with -Z macro-backtrace for more info)

Unfortunately, it doesn't tell me which line number the error is on, so it's pretty difficult to debug. Is it possible to count line numbers when parsing and report the line number accordingly?
Thank you.

@levkk Could you provide contents of the template file? (i.e., model.html)

main.rs
use sailfish::TemplateOnce;

#[derive(TemplateOnce)]
#[template(path = "example.html")]
pub struct Example {
    title: String,
}

templates/example.html
<html>
	<head><%= title %></head>
</html>

<% if { non_ %>

$ cargo build
   Compiling example v0.1.0 (/home/lev/code/example)
error: Failed to compile template.
       caused by: Rust Syntax Error (lex error)

       file: /home/lev/code/example/templates/example.html
 --> src/main.rs:3:10
  |
3 | #[derive(TemplateOnce)]
  |          ^^^^^^^^^^^^
  |
  = note: this error originates in the derive macro `TemplateOnce` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `example` due to previous error


Edit Kata is briefly available for all katas during page load

Find a random kata. Either load the page entirely new, or refresh one using F5 (clicking the sub-items on a kata won't work).  Before the page finishes loading there will be a brief period where the "Edit Kata" button is visible and clickable:

Of course, clicking on the button leads to the edit page, which will greet you with a 500 error due to the lack of privilege.

This is because .js-edit-challenge is removed in JavaScript.
It's displayed for a long time if the connection is slow.
App.ns("Controls.CodeChallenges.SocialButtons", App.Control({
  init: function() {
    var e;
    if (((e = App.data.permissions) != null ? e.save : void 0) === !1)
      return $(".js-edit-challenge").remove()

The same thing is happening for #carbonads-container.
I see ads display if I throttle my connection using Developer tools.
App.ns("Controls.CodeChallenges.ListController", App.Control({
  init: function() {
    var e;
    this.track("Loaded"),
    ((e = App.currentUser) != null ? e.hideAds : void 0) && $("#carbonads-container").hide(),

Closing as wont fix because I believe this is required to cache server rendered page.


Persittent workspaces seems to be broken

after update to 0.10.0:

before:

config:
https://app.warp.dev/block/fRkBkruidxbTZdY0UUU5nv

It's been fixed in #3037
Not released yet, but you can compile from master and update your package if you need it now.

Np


No new version on Zenodo

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
Yes
Source
binary
Tensorflow Version
tf 2.9.1
Custom Code
No
OS Platform and Distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
On Zenodo only versions up to 2.9.1 are stored. The last update came from May 23, 2022. I was told in #51071 that new versions should have been added automatically, but they were not. Furthermore, I would be happy if they would come in chronological order and not several versions at the same day. Thanks in advance for the help :)
Standalone code to reproduce the issue
Look at https://zenodo.org/record/6574269 and issue #51071
Relevant log output
No response

CC @angerson

On Zenodo only versions up to 2.9.1 are stored. The last update came from May 23, 2022. I was told in https://github.com/tensorflow/tensorflow/issues/51071 that new versions should have been added automatically, but they were not.

Thanks for your report. This was indeed some kind of silent bug with our integration with Zenodo and GitHub. I think I have fixed it, and the upcoming TensorFlow 2.12 release should be uploaded automatically.
Since the automation does not apply retroactively, I have uploaded those versions that were not published.

Furthermore, I would be happy if they would come in chronological order and not several versions at the same day.

Sorry, this is not possible. Zenodo does not give us control over display order, and so each TensorFlow version appears in the same order it was uploaded to Zenodo.


Factory reset

We need to document the process of performing factory resets for customers.

Some internal documents:
https://docs.google.com/document/d/1xwxqqucas9h7RqTfKgFC4Vo_jiIorAWFmx39zB-BBDI/edit

While you're at it, is there a process for a customer controlling their own hostspot image? Could we update GA's by ourselves?
It may not be on your immediate timeline, but i've just had a load of 4 year old smart plugs go dark because the remote server has gone. Luckily I can re-flash the firmware and control them locally over MQTT/REST.

Thanks @ganey. Not clear how this will be done at this point as the system is tightly integrated with Balena. It would in theory be possible in the future to take over control.

Ah okay thanks.
Do the hotspots run BalenaOS as the host then? If so, it probably wouldn't be too difficult to move devices to self-hosted openBalena if someone really wanted to (at their own risk of course).

Correct. All miners are running balenaOS, and all code that runs on them is open sourced (to my knowledge).

Yes they run balenaOS. You could either use openbalena or use balenaCloud as I think first 10 devices are free.
You could do it now and just reflash your device and push our repo to the application. But obviously then you'd be responsible for pushing the updates yourself.

Thank you both for clarifying, I have no plans to do this in the short term, but it's great to know it's possible.

Actually @ganey we are also in discussions with balena to see whether we can support our devices and other manufacturers as well on balena openfleets. But not got a huge amount of time to sort that ATM

FYI @vpetersson below is from balena about how we can allow customers to flash there devices and still have it on our fleet, with a single use image...
Each time a customer needs to reflash their CM3 due to booting issues, what you can do is pre-register a new device in the balena CLI which will create a new device in your application and generate a random UUID. The crucial step here is to then create a configuration file that includes this new UUID, which is then injected into a downloaded image from your application.
Once the customer has flashed their device with the OS image you have provided, they won't be able to duplicate the SD card to other devices, as the UUID in the configuration file in the OS image will have already been used.
So in practise this would work as follows:

Customer complains of booting issues that would require a reflash
Nebra preregisters new device  >balena device register YOURAPP --uuid 6053dab8dc4721ed288c8dfc79052967
Nebra creates new config file  > $ balena config generate --app cliApp --version 2.38.0+rev1 --device 6053dab8dc4721ed288c8dfc79052967 --network ethernet --appUpdatePollInterval 10 --output config.json
Nebra injects config into OS image  $ balena os configure Nebra-HNT.img --config config.json --device 6053dab8dc4721ed288c8dfc79052967
Nebra supply OS image to customer for flashing.

You can read through the full guide on how to do this here:  https://github.com/balena-io/balena-cli-advanced-masterclass#52-preregistering-a-device

Hello there...
I was wondering if you could perform factory resets on two of my NEBRA indoor hotspots? I cant do it myself since I am unable to approach your official NEBRA dashboard...the bug in question is "the device does not exist". Ive tryed a dozen times, scanned the codes over and over again, manually entered codes...but none of my hotspots is recognized by your dashboard software. I ve already submitted a ticket to nebra support email, but no answer has been given. Both of my hotspots suddenly stopped all activity, without any logical reason...and they are dead for weeks now. They previously worked fine, my internet connection is top of the line, ports are open, the devices are backed up with colling units, everything should be in order...except it isnt, and my units arent mining at all. I ve manually unplugged and plugged them numerous time...it didnt helped, restarted the routers...didnt helped. Ergo...I am here, asking you for your help and guidance.
I can provide you with additional information...MAC codes, ETH code and all that, just tell me where to approach you...since nebra support email doesnt give me any feedback for weeks now.

Hi,
I have the same problem as @devicefckdup
Can you help me?

This is not for end-user support. This is for software bugs. @Premmmi / @devicefckdup please reach out to<EMAIL_ADDRESS>

Any updates on this? It would be good to have the instructions now that the support is so overwhelmed.
The file that was shared in the second comment is not public.

This can only be done by support. It's not possible to do by end-users.

Okey, thank you for a response. Will have to wait for the support to get back to me.

Can something be wrong with the eMMC module if the device is not booting up properly as the green led never turns on. But the device is syncing with the blockchain and diagnostic does not show that anything is wrong. I've received this hotspot 3 weeks ago and has not been able to onboard it since. Support is not responding, I have ticket 279266 that they stopped to respond too. Can the eMMC be wiped so everything is downloaded again?

@KevinWassermann94 I think we have documented this internally now so guess we can close this issue?

Can you tell us how to factory reset then if you have it documented internally? There are tons of people with a Nebra where the external green LED isn't illuminating, they can't be paired with Bluetooth and thus can't be onboarded, and support hasn't responded despite the tickets being opened for many weeks (see my support ticket 287423).
I received my Nebra on October 19, it's now November 5, and it's still just sitting here unable to be onboarded despite extensive troubleshooting efforts. Full details here.

@Ryan-Goldstein it's not possible for anyone but Nebra staff to do this I'm afraid

@Ryan-Goldstein p.s. had a quick look at your hotspot and it seems something on the ECC has gone wrong. This is a very rare issue and unlikely to be an issue caused by the updates.
In any case please leave the hotspot on and connected to internet and we will attempt a remote fix

@shawaj Will do, I'll keep it online, thanks for taking a look!

@Ryan-Goldstein p.s. had a quick look at your hotspot and it seems something on the ECC has gone wrong. This is a very rare issue and unlikely (impossible) to be an issue caused by the updates.
In any case please leave the hotspot on and connected to internet and we will attempt a remote fix

Hi @shawaj - is it possible that this is the same issue affecting the rest of us on https://github.com/NebraLtd/helium-miner-software/issues/175?

@JohnMaguire almost certainly not but hard to say really. Best thing is to email<EMAIL_ADDRESS>

@JohnMaguire Email them, but I've been waiting for a response regarding the ECC for 3 months now. I copied my friend EEC card and move over the config file from my non properly working eMMC to the SD card to have it running right now.

@shawaj Yes this can be closed. We have the internal document for it

@Ryan-Goldstein p.s. had a quick look at your hotspot and it seems something on the ECC has gone wrong. This is a very rare issue and unlikely (impossible) to be an issue caused by the updates.
In any case please leave the hotspot on and connected to internet and we will attempt a remote fix

@shawaj I've kept my Nebra online, and I received an email from support on 5 November requesting photos of the inside of my hotspot, which I immediately sent, sent a follow-up yesterday, but I haven't heard anything since. My hotspot (eth 00:BD:27:00:1D:A1) is still in the same state.
Any chance you can try to get this fixed? I've had this hotspot that I haven't been able to onboard since receiving it on 19 October, 3 weeks ago. Thanks.


dark mode / design suggestion

First of all, thanks for all the work and maintaining this.
I'm not a big fan of the dark mode docs design, there are some contrast issues (e.g. the pink highlights) And It's not very easy on the eyes. What do you think of this suggestion with a white background?

I thought so, maybe a little over the top. I had it like that for a while then switched to dark. If you like you can fork the repo, run yarn docz and edit ./doczrc.js and documentation/resources/Codemirror.js to make a variant or eventually a PR.

Is this better? http://react-spring.surge.sh

yes much better I think!


Openlane [Tag: 2022.05.18_02.12.32] flow fails with [ERROR DPL-0036] Detailed placement failed Error

Description
Latest openlane [Tag: a2022.05.18_02.12.32] tool flow fails with [ERROR DPL-0036] Detailed placement failed Error. Same design use work with older version tool sets
Environment
Openlane git repo log
commit 0dc6fb79c91082b94f8ded78d70f8bacbab96bf2 (HEAD -> master, tag: 2022.05.18_02.12.32, origin/master, origin/HEAD)
Author: Anton Blanchard<EMAIL_ADDRESS>Date:   Wed May 18 01:24:25 2022 +1000

    Enable PL_ROUTABILITY_DRIVEN and PL_TIME_DRIVEN (#1092)

    ORFS enables both of these by default.

commit 6bcd930ce1e818cd86cfd491ba015a8cc5a98408 (HEAD -> master, origin/master, origin/HEAD)
Merge: a9682175a 17bde4c8f
Author: Matt Liberty<EMAIL_ADDRESS>Date:   Wed May 18 22:20:47 2022 -0700

    Merge pull request #1883 from The-OpenROAD-Project-staging/ifp-obsolete

    Ifp obsolete

Reproduction Material
Attached the openroad_issue_reproducible directory.
openroad_issue_reproducible.tar.gz
Expected behavior
Logs
Openlane failure log
[STEP 18]
[INFO]: Running Detailed Placement...
[ERROR]: during executing openroad script /openlane/scripts/openroad/opendp.tcl
[ERROR]: Exit code: 1
[ERROR]: full log: uart_i2cm_usb_spi_top/runs/uart_i2cm_usb_spi_top/logs/routing/18-diode_legalization.log
[ERROR]: Last 10 lines:
[INFO DPL-0035]  ANTENNA_u_skew_uart.u_mux_level_10_S
[INFO DPL-0035]  ANTENNA_u_skew_uart.u_mux_level_00_S
[INFO DPL-0035]  ANTENNA_u_skew_uart.u_mux_level_11_S
[INFO DPL-0035]  ANTENNA_u_skew_uart.u_mux_level_11_S
[INFO DPL-0035]  ANTENNA_u_skew_uart.u_mux_level_07_S
[INFO DPL-0035]  ANTENNA_u_skew_uart.u_mux_level_06_S
[INFO DPL-0035]  ANTENNA_u_skew_uart.u_mux_level_06_S
[ERROR DPL-0036] Detailed placement failed.
Error: opendp.tcl, 32 DPL-0036
child process exited abnormally

@dineshannayya
Update following in config.tcl will resolve the issue.
set ::env(CELL_PAD) {2}

https://github.com/The-OpenROAD-Project/OpenLane/issues/1100 might help here

or without gratuitous punctuation
set env(CELL_PAD) 2

Yes with CELL_PAD 2 working now ..  Closing the ticket


 So you can merge yourself.  So you can merge yourself. Or you can direct add a commit.

Then why waiting?


Use of a Curseforge modpack that does not have a server pack

Is there a way to use a CF Modpack that does not have a server pack, and make it download all the mods?
I tried using CF_SERVER_MOD and MANIFEST, but always got an error that this is not a valid modpack.
If it does not work, can I try to implement it and make a PR?

No...but I just ripped out all of the code that did most of that
https://github.com/itzg/mc-server-runner/commit/cf93447fcc5f818831f462d5e92ebf77f570a06a
It still didn't account for all of the config file assets, etc. Since it turned out to be quite complicated, I didn't want a dormant feature lurking.
You're welcome to revive and finish that feature out. Or I would be interested in a simpler, cleaner solution if you want to contribute that way.

Thanks for the reply, I'll look into it.
BTW, thanks a lot for this amazing project. I love it!

Thanks 😁
BTW I just realized I still have the invocation spot left in the image script
https://github.com/itzg/docker-minecraft-server/blob/27523a1c4557b6d9c2bc53e65af8d67a5541c856/start-minecraftFinalSetup#L184


Package Installation

The wy install command installs the package into the local repository.  But, what is a package?

Contents.  A package is a zip file containing the wy.toml, any compiled wyil files, original whiley files and other assets (e.g. native code or docs).
Layout.  The layout of a package is user-specified as determined by the wy.toml file.  Fortunately, wyil files embed their own package information so this can be extracted.

The package does not need to contain the original source files, though it can.  Since a package can contain multiple wyil files, these must be inspected to extract their contents (or at least identify the modules contained in them).
The contents of a package is determined by the build/includes attribute.

At the moment, this would mean creating a jar file from the generate wyil files and the wy.toml file and then installing this into the repository.

See: https://docs.oracle.com/javase/7/docs/api/java/util/zip/ZipOutputStream.html

Done.  Easy.  Reamining issues:

Update ZipFileRoot to search for WyIL files at arbitrary locations, rather than from root.  Otherwise, packages will not resolve.
Add some notion of command prerequisites (e.g. install requires build, etc).


s32k3 Clean up

Summary
s32k3xx:LPSPI register usage cleanup removes redundant 32 reg modifiy code.
s32ke3xx:EDMA Usage Clean up. Ensure the lpspi and qspi used the eDMA and did their own  cache maintenance.
In the past EDMA rework ttype was removed as was the dcache operation because the buffer extent is not know by the eDMA.
Impact
Should make the drivers stable with both WB/WT caching enabled.
Testing
inspection only.
@PetervdPerk - would you please verify this PR?

LGTM, tested on PX4 with imc42688p and icm20649


[zk] add zookeeper

Can you resolve the merge conflicts? I want to make sure the Travis tests pass and it won't run without that. Otherwise, looks good to me.

LGTM


ThreadSafe type’s value property?

Hello! Was just glancing though the sources, and I took note of the ThreadSafe type. It looks to me like the value property allows you to escape the queue. Am I understanding correctly?

Hi @mattmassicotte 👋🏼
Are you referring to this property? withValue should be the one protecting against a data race, but I might be missing something.

It does provide a consistent read, but it returns the value. From that point on, it's no longer being protected by the queue. This could be safe, depending on/why it is being protected. But, it is not safe in the general case.
To provide full safety, you would have to always access the value externally using withValue.

Correct, if you're working with mutable reference types there is a window for a race conditions there unless they also enforce internal thread safety.  I forget if there was a specific need for this in Command or if this was a result of copy/pasting from Tuist or Xcodeproj.  there are many cases where we only need to read and work with a value and not mutate it and it's easier and more readable to use let foo = bar.value vs let foo = bar.withValue { $0 }.
For mutating structs though, one would only be able to set the result in a later call to bar.withValue { $0 = mutatedValue }
As is it's intended to be easy read and after that the value (should be) disconnected from the type using ThreadSafe.
100% open to questions or feedback on this approach as is, naming and threading are hard 😆

That said, it's probably a good idea to keep this type internal since it's not intended to provide threading guarantees to consumers of Command and it's only meant to be within Command to help with safe output collection.

there are many cases where we only need to read and work with a value and not mutate it and it's easier and more readable to use let foo = bar.value vs let foo = bar.withValue { $0 }.

Unfortunately, neither of these constructs are safe in the general case. Once foo has escaped the protection of the queue, its internal structures are now subject to data races.
Now, it could be that this turns out to be fine! The compiler cannot reason about all possible uses. But, as a rule, a type like this that permits a protected value to escape the protection is usually a problem.

I completely missed the fact that the returned type needs to be protected. In the context of how the utility is used by Command, since we mutate it within the block to concatenate the output, it should be safe, no?
I'll go ahead with @waltflanagan's suggestion to change the visibility of this utility.

But, as a rule, a type like this that permits a protected value to escape the protection is usually a problem.

Out of curiosity, how would you recommend tackling scenarios like this? I'm still early in my understanding of strict concurrency, so I'm not entirely sure what the best practices is here:

Should we add some annotations to indicate that the returned object is not data-race-free?
Should we iterate in the pattern to get closer or achieve data-race safety?
Can we solve the need that Command has without resorting to such utility? (i.e. concatenating strings coming from various streams of events).

Thanks a lot folks ❤


remove redundant string interpolation

@SimonCropp
Please consider adding Roslyn analyzer rule into repo. Otherwise new one might get introduced later.


Loses text when maximizing the integrated terminal

Issue Type: Bug
When I maximize the terminal, only visible text at the bottom of the original size terminal remains. All the text above (which I can see if I scroll up) disappears and they won't come back even if I minimize the terminal back.
https://user-images.githubusercontent.com/83082904/136067623-ad40c8fc-3c0e-4813-a1f3-90b63cbc52dc.mp4
VS Code version: Code 1.60.2 (7f6ab5485bbc008386c4386d08766667e155244e, 2021-09-22T12:00:31.514Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz (8 x 1190)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.78GB (2.42GB free)

Process Argv
--crash-reporter-id 9b16d291-2aed-420a-aeff-d4f481c88df8

Screen Reader
no

VM
50%

Extensions (37)

Extension
Author (truncated)
Version

bracket-pair-colorizer-2
Coe
0.2.1

vscode-markdownlint
Dav
0.44.4

vscode-eslint
dba
2.1.25

es7-react-js-snippets
dsz
3.1.1

vscode-html-css
ecm
1.10.2

EditorConfig
Edi
0.16.4

vsc-material-theme
Equ
33.2.2

vsc-material-theme-icons
equ
2.2.0

auto-close-tag
for
0.5.12

code-runner
for
0.11.5

beautify
Hoo
1.5.0

latex-workshop
Jam
8.20.2

better-cpp-syntax
jef
1.15.10

vsc-python-indent
Kev
1.14.2

MagicPython
mag
1.1.0

vscode-language-babel
mgm
0.0.35

python
ms-
2021.9.1246542782

vscode-pylance
ms-
2021.9.4

jupyter
ms-
2021.8.2041215044

jupyter-keymap
ms-
1.0.0

remote-wsl
ms-
0.58.2

cmake-tools
ms-
1.8.1

cpptools
ms-
1.6.0

cpptools-extension-pack
ms-
1.0.0

js-debug-nightly
ms-
2021.9.2817

java
red
0.82.0

live-sass
rit
3.0.0

LiveServer
rit
5.6.1

code-spell-checker
str
2.0.8

tabnine-vscode
Tab
3.4.29

cmake
twx
0.0.17

vscode-java-debug
vsc
0.36.0

vscode-java-dependency
vsc
0.18.8

vscode-java-pack
vsc
0.18.5

vscode-java-test
vsc
0.32.0

vscode-maven
vsc
0.34.0

quokka-vscode
Wal
1.0.402

(2 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263cf:30335440
vscorecescf:30358481
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
vsccppwt:30364497
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt2:30371810
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedc:30364665
pythonvspyt187:30373474
pydsgst2:30361792
vsqsis200:30374795
vsaa593:30376534

@zadjii-msft when resizing the viewport to include more columns, the normal behavior of a terminal is to push the scrollback back into the viewport, but WT/conpty seems to assume the scrollback remains. Is there a way to change this behavior or do we need a special mode that handles resizes differently?

Feels a little wrong to piggy back on win32 input mode as something else might adopt that in the future.

Oh sorry, that's confusing. Those are actually two separate flags to conpty that got added in a really small window. There's the aforementioned --win32input flag for telling conpty to request win32-input-mode, but then there's --resizeQuirk for "I know what I'm doing, I'm hosting a conpty, do the new resize thing". I never really polished it for external use, it was added in the bugfix sprint for Terminal 1.0 so it's a little quirky. We didn't want to inadvertantly break someone who was relying on the old behavior, but never had the time to really evaluate

if the old behavior was ever correct
if the new behavior would work in general for everyone.

My worry was about point 2 - I was worried that running cmd.exe inside something like gnome-terminal in wsl with --resizeQuirk on by default would be more broken than today, which is what I was trying to avoid.
Relevant source: https://github.com/microsoft/terminal/blob/6268a4779c9b3f49b7f3c30471bda7ae292ac423/src/winconpty/winconpty.cpp#L100-L113

This is a defect that greatly affects the experience

I have also encountered this problem. But this problem only occurs on Windows terminal, not on linux, and it doesn't occur on Windows VSCode which SSH remote connect to linux.

I have also encountered this problem. But this problem only occurs on Windows terminal, not on linux, and it doesn't occur on Windows VSCode which SSH remote connect to linux.

yes，I also had this problem

It is common bug for Windows programs, e.g. Intellij:
video:
https://www.youtube.com/watch?v=owrgc3gnoWg
issue:
https://youtrack.jetbrains.com/issue/IDEA-290119/Terminal-output-is-lost-on-terminal-vertical-resizing

It seems to be an exclusive mistake of conpty in win11, and I can't reproduce it on win10 and Windows server 2022.

Conpty support is only available from Windows 10 build 18309, that's probably why you see it on some but not others:
https://github.com/microsoft/vscode/blob/ff18720449d635d0cec7476d50541107a2150538/src/vs/platform/terminal/node/terminalProcess.ts#L162
When using winpty it may work but a lot of other things degrade, it's a worse experience overall.

@Tyriar I am using Win 11 and I am getting the same text trimming issue while minimizing the terminal , can anyone tell me in decent way that what I need to do ??

@Tyriar I am using Win 11 and I am getting the same text trimming issue while minimizing the terminal , can anyone tell me in decent way that what I need to do ??

I found working solution. I moved from Windows to MacOS and now this issue is gone. You can also switch to Linux. There are also other benefits of this move:

encoding is now standard UTF-8 instead of non-standard WIN-123456,
lines end with standard \n instead of non-standard \r\g\b,
unix terminal is way better than cmd,
if you prefer PowerShell you can install it easily.

Switching to Linux is free, switching to MacOs is not free but their devices are really good, so it is worth consideration.

@Tyriar I am using Win 11 and I am getting the same text trimming issue while minimizing the terminal , can anyone tell me in decent way that what I need to do ??

I found working solution. I moved from Windows to MacOS and now this issue is gone. You can also switch to Linux. There are also other benefits of this move:

encoding is now standard UTF-8 instead of non-standard WIN-123456,
lines end with standard \n instead of non-standard \r\g\b,
unix terminal is way better than cmd,
if you prefer PowerShell you can install it easily.

Switching to Linux is free, switching to MacOs is not free but their devices are really good, so it is worth consideration.

As a macOS and Linux user, this is cringe.

As a macOS and Linux user, this is cringe.

I don't know if you helped investigating this issue. I tried at least. I recorded video presenting this bug and reported it to IntelliJ developers and here to VS Code developers.
It has been months of not being able to use terminal on Windows properly, not only in apps mentioned, but in any app that uses terminal, including Windows Terminal.
I provided working solution, which is switching to other operating system. It may be useful for some people. For some people it may not. But it is the only workaround we have, at least for now.
I strongly encourage people to try using UNIX-like systems, and I provided valid arguments for it. Unless there is something I don't know and Windows is now able to use common accepted standards.
I hope you will live cringe-free life from now. Have a nice day.

This is super annoying.

Recently I encountered same problem of losing test from vscode terminal when resizing on windows 11.
Sharing a fix that worked for me -
In vscode > File > Preferences >  Settings > Features>Terminal>Integrated:WIndows Enable Conpty (In setting search terminal conpty) > Uncheck the checkbox and restart vscode
Hope this helps.

Recently I encountered same problem of losing text from vscode terminal when resizing on windows 11. Sharing a fix that worked for me - In vscode > File > Preferences > Settings > Features>Terminal>Integrated:WIndows Enable Conpty (In setting search terminal conpty) > Uncheck the checkbox and restart vscode Hope this helps.

it work for me too, thanks!

Recently I encountered same problem of losing text from vscode terminal when resizing on windows 11. Sharing a fix that worked for me - In vscode > File > Preferences > Settings > Features>Terminal>Integrated:WIndows Enable Conpty (In setting search terminal conpty) > Uncheck the checkbox and restart vscode Hope this helps.

it work for me too, thanks!

I've had the same problem since the update but I seem to be able to consitantly recreate the bug even after turning this setting off. Weirdly it doesn't remove the entire history only the previous command. Occasionally the whole terminal bugs out and I get overlapping text which I think is caused by shrinking the window too small but I can't consistently repeat this.
Any other ideas would be much appreciated.
Edit:
Version: 1.76.2 (user setup)
Commit: ee2b180d582a7f601fa6ecfdad8d9fd269ab1884
Date: 2023-03-14T17:55:54.936Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: No

You can also try these, but I cannot confirm if it will work or not but still you can try once.
You can check if increasing scrollback works for you or not i.e. -
In vscode > File > Preferences > Settings > Features>Terminal>Integrated:Scrollback (in setting search scrollback) > increase value to 3000 > restart vscode.
You can try unchecking vscode compatiblity mode.
rightclick vscode icon > properties > compatiblity (tab) > uncheck the check box in compatiblity mode and open vscode.
Hope this helps.
You can also try and check if combination of these fixes and one mentioned above works for you or not.

Recently I encountered same problem of losing text from vscode terminal when resizing on windows 11. Sharing a fix that worked for me - In vscode > File > Preferences > Settings > Features>Terminal>Integrated:WIndows Enable Conpty (In setting search terminal conpty) > Uncheck the checkbox and restart vscode Hope this helps.

Restart of vscode was not enough for me. I needed to Delete the existing terminal sessions as they kept using conpty with the same issue. Fresh (new) terminal windows after changing that setting and restarting vscode work correctly for me. Thanks for the tip! This is an embarrassing bug impacting the latest releases of vscode, both stable and insider builds.

Recently I encountered same problem of losing text from vscode terminal when resizing on windows 11. Sharing a fix that worked for me - In vscode > File > Preferences > Settings > Features>Terminal>Integrated:WIndows Enable Conpty (In setting search terminal conpty) > Uncheck the checkbox and restart vscode Hope this helps.

Restart of vscode was not enough for me. I needed to Delete the existing terminal sessions as they kept using conpty with the same issue. Fresh (new) terminal windows after changing that setting and restarting vscode work correctly for me. Thanks for the tip! This is an embarrassing bug impacting the latest releases of vscode, both stable and insider builds.

Disable the Terminal › Integrated: Windows Enable Conpty works! After that, just open a new terminal, don't need restart.
But the fonts looks ugly, and missing fonts. (Disable Conpty)

Enable Conpty:

After being confused for a while trying to reproduce this in xterm.js, it turns out we already fixed this with windowsMode in xterm.js:
https://github.com/xtermjs/xterm.js/blob/22a4dc4b6b8c17a099d4f0f4354cd3d84a59b85b/src/common/buffer/Buffer.ts#L181-L184
But we have since disabled that post Windows built 21376 to avoid the wrapping heuristics:
https://github.com/microsoft/vscode/blob/44b766dcae0411af58d62942506985bd15b5521a/src/vs/platform/terminal/node/ptyService.ts#L719
We need greater granularity in the backend used on xterm.js


Implement lexer and parser using virtual block tokens

To improve the lexer/parser code and also remove the current 2 spaces limitation we can implement a lexer generating virtual tokens.
test:
  wow:
    lol
         yay
    bend
  ok

With the input above the lexer should generate the following tokens:
["test", Colon, VirtualBegin, "wow", Colon, VirtualBegin, "lol", "yay", VirtualSemi, "bend", VirtualEnd, "ok", VirtualEnd]

For the parser we can change between fun and imp syntax based on token lookahead or using the old #flavour imp in the middle of the file

I think the easiest and most flexible way would be to lex to this token structure
struct Token {
  Char(char),
  LineBreak,
  Begin,
  End,
}

Which keeps the text identical but consumes all whitespaces and converts it into just the indentation information. We could swap between the two behaviours by just flipping a flag in the lexer that tells it whether or not to generate the non-text tokens.
I think with this the conversion of our current parser is pretty trivial since all the text searching stays the same, we just need to change starts_with and consume to use char tokens instead of chars.
I'm not sure what VirtualSemi is in your example.

Here VirtualSemi will be produced between lexemes starting in the same column, the example input can be read as:
test {
  wow {
    lol yay;
    bend
  }
  ok
}


Checkstyleissuessolved

Contains
#3525
Brief description of what the PR does like "Fixes #12345"
How to test
Brief description of how to test / confirm this PR before merging

Can one of the admins please verify this patch?

Can one of the admins please verify this patch?


Created bower.json file

This will allow to be served up by bower

Thanks @ppalladino for the suggestion, sounds like a good idea. Merged.

I will hook it into bower, test and send along results. Thanks!


Update OS.request_permission(...) description

This PR corrects the long-standing incorrect description of OS.request_permission. This method was updated in PR #77686, but its description was not revised to reflect the changes.

@m4gr3d Could you please review and confirm if it correctly reflects the intended behaviour?


reframe tests for FIO benchmark was added

FIO single and multi VM test were added and the VM data set files were updated with FIO data for ssd disks on HBv2 VMs

HPL and Stream memory tests were updated for azure cycle cloud & slurm, the datasets were updated with additional health check data for HB and HC and the config file was updated to add support for HC and HB SKUs


🐛(Search) fix filter pane quality issues on handheld devices

Purpose

The button to open/close filter pane did not (dis)appear on window resize
There was quality issues on the search filter pane on handheld devices

Proposal

[x] useMatchMedia hook to show/hide button on window resize
[x] fix filter pane quality issues

I didn't see anything wrong, but I don't think I'm able to approve it :/

Ok no problem, it is not a big issue. Let's see @mbenadda feedbacks.