x/tools/gopls: create a new snapshot on didChangeConfiguration

It would probably simplify our logic to treat this as an invalidation event, especially since a change in environment leads to metadata invalidations.

I'm not sure if this is the same issue: I expect that settings sent via didChangeConfiguration are applied immediately
For example, given this file
package main

func main() {
	println()

}

I start goplswith no configuration
I send {"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{"formatting.gofumpt":true}}}
I send {"jsonrpc":"2.0","method":"textDocument/formatting", ...}
Nothing happens; I expect the empty line after pringln() to go away.

It works when I restart the language server, or when I use workspace/configuration instead.
I don't think a restart should be necessary, and not all clients (want to) implement workspace/configuration. For example it doesn't really make sense for the client I'm using - https://github.com/kak-lsp/kak-lsp - some implementation reasons prevent mult-workspace-in-single-editor-session for now.

Tangentially related: my main problem with workspace/configuration is that it needs section headers. To send "formatting.gofumpt", the user needs to specify {"gopls":"formatting.gofumpt"}. OTOH "formatting.gofumpt" already works when  sent as initialization option. I'd like to use a single config object for both, so the user doesn't have to care about protocol details. In the config system of kak-lsp, there is one object for each language, so I'm having a hard time understanding the need for the section header.

@krobelus: Your topic is actually a separate issue, but I can answer it briefly. For some reason, VS Code doesn't actually send the modified settings in its didChangeConfiguration request, so we rely on workspace/configuration to get the updated values. We also use workspace/configuration to get the settings at initialization.
You shouldn't need section headers for workspace/configuration. Here is an example request/response from VS Code:
[Trace - 17:08:47.027 PM] Received request 'workspace/configuration - (2)'.
Params: {"items":[{"scopeUri":"file:///Users/rstambler/code/src/golang.org/x/tools","section":"gopls"}]}

[Trace - 17:08:47.033 PM] Sending response 'workspace/configuration - (2)' in 5ms.
Result: [{"verboseOutput":true,"ui.diagnostic.analyses":{"fillreturns":true},"ui.semanticTokens":true,"experimentalUseInvalidMetadata":true,"ui.diagnostic.staticcheck":true,"ui.completion.experimentalPostfixCompletions":true,"ui.completion.usePlaceholders":true,"build.experimentalTemplateSupport":true,"build.experimentalWorkspaceModule":true}]

Thanks that's good to know. It looks like gopls accepts the same options in both didChangeConfiguration and workspace/configuration which makes things simpler, but other servers might not.

This is a persistent source of bugs. We should fix in the next release.


Database name must not be empty

Hi,
I tried to follow your great blog post, but my pods are crashing with:
Failed to instantiate [org.springframework.data.mongodb.core.SimpleMongoDbFactory]: Factory method 'mongoDbFactory' threw exception; nested exception is java.lang.IllegalArgumentException: Database name must not be empty!

my data connection looks like:
SPRING_DATA_MONGODB_URI=mongodb://microservicesdb:<redacted==>@microservicesdb.documents.azure.com:10255/?ssl=true

I tried to also define secret by base64 encoding string like but got the same error:
SPRING_DATA_MONGODB_URI=mongodb://microservicesdb:<redacted==>@microservicesdb.documents.azure.com:10255/candidate?ssl=true

How do I pass the Mongo DB name to the pod?

Experiencing the same error. @ams0 , have you fixed the issue?

This project is over three years old. There are likely many updates to the underlying frameworks and services that could affect its usability. Happy to accept pull requests.

Same error @ams0. Any solution for this?

This project is over 5 yrs. old. Happy to take contributions to fix/update.

Same error at first, but after modifying a small part, it works, hope can help.
Previous - application.properties
spring.data.mongodb.database=myDBname
<EMAIL_ADDRESS>Current - application.properties (for me, it works)
spring.data.mongodb.database=myDBname
<EMAIL_ADDRESS>


Is it possible to customize message cells, like tails and bubble colors?

This library provides a View Controller which includes Slack's chat input bar. It's up to you to define the UI and behaviour of the message cells.


New dark theme color missing from tooltips

Added missing dark theme color and removed highlight color for tooltips only.


[Enhancement]: Better FITS header keywords for positions of mask and star

Instrument or Category
NIRCam Stage 1/2 Pipeline, MIRI Stage 1/2 Pipeline, Image Tools, Analysis Tools
What is your suggestion?
As discussed in slack by @kdlawson @JarronL @juliengirard @kammerje and @mperrin:

SpaceKLIP currently treats the CRPIX header value as synonymous with "where is the coronagraph mask", and (sometimes, perhaps?) where the star was tried to be positioned during TA. This oversimplifies the operational situation. @JarronL: "Need to disambiguate star and mask centers and keep CRPIX along with distortion header keywords intact"
@mperrin: "There should be separate explicit header keywords in spaceklip output files for e.g. MASK_CEN, STAR_CEN in addition to CRPIX. Even if the values are identical such that MASK_CEN == CRPIX, this might help reduce confusion in the long run."
Even better if we added additional keywords for error propagation in how precisely we know those values. @juliengirard suggests "populate MASK_CEN_ERR STAR_CEN_ERR keywords for each of them with comments on how they are determined"

Error traceback output
No response
What operating system are you using?
No response
What version of Python are you running?
No response
What Python packages do you have installed?
No response

Sub tasks:

[ ] Add new keyword for mask center, and its uncertainty
[ ] Add new keyword for star location, and its uncertainty
[ ] Make sure we obtain and are using the most current values for those. From SIAF for the mask center?
[ ] Update the image alignment and shift functions to propagate changes to those keywords
[ ] Update the level 3 image combination functions to propagate changes to those, for derotated and combined images.


Feature/s755061 move domain

Remove the domain wrapper and replace with direct use of emit python's domain class

merge with (or after) https://tfs.ansys.com:8443/tfs/ANSYS_EBU_Collection/EBU/_git/delcross.git/pullrequest/98549


💡 [REQUEST] -

[✅ ] I am from GSSoC'23.
[ ✅] I would like to be assigned this task.

Section
Description

Concise Description
The current issue in the repository is the absence of a sitemap for the website. A sitemap is a file that lists all the pages on a website, allowing search engines to better understand and crawl the site's content. By adding a sitemap, we can improve the website's visibility and ensure that all pages are easily discoverable by search engines.

Solution Proposed
Create a new sitemap file in XML format.

Identify and include all the URLs of the website's pages in the sitemap.

Handle dynamic or frequently changing content appropriately to ensure the sitemap remains up-to-date.

Test the sitemap to ensure it is valid and error free.

Integrate the sitemap into the website's repository.

Alternative Solutions
Nothing

Additional Context
The absence of a sitemap in the website's repository has led to certain drawbacks that need to be addressed.

Screenshots

Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct.

[ ✅] I follow the Contributing Guidelines of this project.
[ ✅] I have checked the current issues for duplicate problems.
[ ✅] I have read the readme of this repository.

Hey @NikhilRaikwar  you may work on this. All the best! Please mention the issue no while raising the pr.

@AKD-01 hey I've done the task and created a PR #323 . Kindly pls review.

Hey, @NikhilRaikwar  thank you for your contribution and patience, I will be reviewing your pr soon. If you liked the project, don't forget to give it a star.

@AKD-01 Hey can you pls review the pr


Express should not disclose

I could not find a listing for this issue so I'm creating a new one.
Summary
This is a proposal to change error handling for Express 5.0: not to send error details to client.
By default, if one of user-provided middlewares throws an error, Express relays all debugging details (even stack trace) to the client. This is convenient for debugging (because you don't have to look at the server console and can look at browser dev tools), but, in my opinion, (in production) might provide more data to an adversary.
Proposal
Do not send the error stack trace to the client by default. Instead, send a generic 500 status code and a short blurb telling the developer to go look at the server console (or how to enable current behavior).
"Fix" usable with Express 4.*
  // Do not leak details about internal errors
  server.use((error, request, response, next) => {
    // Log error message for later review in server console
    // because this error no longer gets logged by Express 4.*
    console.error("Prevented sending this error to client:\n", error)

    // If HTTP Status Code is not set, default to '500 Internal Server Error (500)'
    const status = error.statusCode ? error.statusCode : 500

    response.status(status)
    response.send('Internal server error. Check server console for details.')
  })

Motivation: Why this should change?
Console output discloses internal server information, which might be usable for an attacker during recon phase. I was unaware that Express sends full stack trace to the client and, in my opinion, developers can not account for this in their threat model.
Please tell me if you need any more details.
Somewhat related issue about handling 4** errors: #2263

Duplicate of https://github.com/expressjs/express/issues/3346

If it's not a duplicate we can reopen. Just articulate how specifically it is different from the linked issue so we know :+1:

Wow! That's a very quick response, thank you.


AVRO-3799: [Rust] Enable the schema parser to read and parse from input streams for Rust binding

AVRO-3799

What is the purpose of the change
This PR proposes to add a feature which enables to create schemas from input streams which implement Read trait like std::fs::File.
The Java binding supports to create schemas from input streams. So, it's useful to have such a feature for the Rust binding too.
Verifying this change
This change adds new tests to tests/schema.rs and cargo test passed.
Documentation
Doc comments added.

Thank you, @sarutak !

@martin-g Thank you for merging this!


prevent trying to setState on unmounted VirtualList + checking for undefined state before comparison

fixes #59
fixes #65

@developerdizzle sorry if this PR is a bit abrupt, I just wanted to fix some of the warnings/errors I ran into using this super rad component!

@developerdizzle yoooo! you mind taking a look-see at this PR some time?

@Ramshackle-Jamathon Can you add a patch version bump in package.json?

Version 2.2.4 has been published!  My apologies for the delay.


"Open in Windows Terminal as administrator" context menu option

Open here as administrator option in context menu

When a user right clicks inside a folder, presently only "Open in Windows Terminal" is shown. But it will be better if a "open in Windows Terminal as Administrator" option is available also , how it is implemented for Powershell 7.

could i work on this?

could i work on this?

yes sure

hey.. what i was thinking was to add a m- in front of the file name that you want to run as admin .. Is my approach correct?

[HKEY_CLASSES_ROOT\Directory\shell\OpenWTHereAsAdmin]
"HasLUAShield"=""
"MUIVerb"="Open in Windows Terminal as administrator"
"Extended"=""
"SubCommands"=""
[HKEY_CLASSES_ROOT\Directory\Shell\OpenWTHereAsAdmin\shell\001flyout]
"MUIVerb"="Default Profile"
"HasLUAShield"=""
[HKEY_CLASSES_ROOT\Directory\Shell\OpenWTHereAsAdmin\shell\001flyout\command]
@="powershell.exe -WindowStyle Hidden "Start-Process -Verb RunAs cmd.exe -ArgumentList @('/c','start wt.exe','-d','"""%V"""')""
[HKEY_CLASSES_ROOT\Directory\Shell\OpenWTHereAsAdmin\shell\002flyout]
"MUIVerb"="Command Prompt"
"Icon"="imageres.dll,-5324"
[HKEY_CLASSES_ROOT\Directory\Shell\OpenWTHereAsAdmin\shell\002flyout\command]
@="powershell.exe -WindowStyle Hidden "Start-Process -Verb RunAs cmd.exe -ArgumentList @('/c','start wt.exe','-p','"""Command Prompt"""','-d','"""%V"""')""
[HKEY_CLASSES_ROOT\Directory\Shell\OpenWTHereAsAdmin\shell\003flyout]
"MUIVerb"="PowerShell"
"HasLUAShield"=""
"Icon"="powershell.exe"
[HKEY_CLASSES_ROOT\Directory\Shell\OpenWTHereAsAdmin\shell\003flyout\command]
@="powershell.exe -WindowStyle Hidden "Start-Process -Verb RunAs cmd.exe -ArgumentList @('/c','start wt.exe','-p','"""Windows PowerShell"""','-d','"""%1"""')""
[HKEY_CLASSES_ROOT\Directory\Background\shell\OpenWTHereAsAdmin]
"HasLUAShield"=""
"MUIVerb"="Open in Windows Terminal as administrator"
"Extended"=""
"SubCommands"=""
[HKEY_CLASSES_ROOT\Directory\Background\Shell\OpenWTHereAsAdmin\shell\001flyout]
"MUIVerb"="Default Profile"
"HasLUAShield"=""
[HKEY_CLASSES_ROOT\Directory\Background\Shell\OpenWTHereAsAdmin\shell\001flyout\command]
@="powershell.exe -WindowStyle Hidden "Start-Process -Verb RunAs cmd.exe -ArgumentList @('/c','start wt.exe','-d','"""%V"""')""
[HKEY_CLASSES_ROOT\Directory\Background\Shell\OpenWTHereAsAdmin\shell\002flyout]
"MUIVerb"="Command Prompt"
"Icon"="imageres.dll,-5324"
[HKEY_CLASSES_ROOT\Directory\Background\Shell\OpenWTHereAsAdmin\shell\002flyout\command]
@="powershell.exe -WindowStyle Hidden "Start-Process -Verb RunAs cmd.exe -ArgumentList @('/c','start wt.exe','-p','"""Command Prompt"""','-d','"""%V"""')""
[HKEY_CLASSES_ROOT\Directory\Background\Shell\OpenWTHereAsAdmin\shell\003flyout]
"MUIVerb"="PowerShell"
"HasLUAShield"=""
"Icon"="powershell.exe"
[HKEY_CLASSES_ROOT\Directory\Background\Shell\OpenWTHereAsAdmin\shell\003flyout\command]
@="powershell.exe -WindowStyle
Or something like this?

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #9903 for more discussion.
/dup #9903
More importantly, we'd like to also do #6111 first, so that people can configure how they want the context menu set up.


ExcelUpload to DetailsEditor View

When i set the details editor value i get belwo error message in form
on button lcic
    protected getButtons(): Serenity.ToolButton[] {
            buttons.push({
            title: 'Import From Excel',
            cssClass: 'export-xlsx-button',
            onClick: () => {
                var dialog = new TimeStampExcelImportDialog();
                dialog.element.on('dialogclose', () => {
                    var uprods = dialog.UploadedProducts;
                    this.view.setItems(uprods,true);
                    dialog = null;
                });
                dialog.dialogOpen();
            }
        });

        return buttons;
    }

Message: Uncaught Each data element must implement a unique '__id' property. Object at index '0' has no identity value: {"UnitPrice":246.95,"DetailId":2,"InStock":5,"ProductCode":"39263000"}
Where Details i want to load from excel to View rather than direct upload. Where DetailId is Db Identity Auto Genrated Column
I Applied CLient Side Fake id, But when i try to save it Throws errro stating
Could not find field '__id' on row of type 'TransactionDetailsRow'

instead of this.view.setItems(uprods,true);
try this.value = uprods


Download and store Wikidata images

In order to avoid hitting wikidata for every image in every author fly-out, we should download and store the images referenced in properties.
Images should be downloaded once and not overwritten to ensure they can be changed/modified.

This was completed in https://github.com/revsys/revsys-nuremberg/pull/16


New version

Hello @nielstron! Thanks for submitting the PR.

In the file pysyncthru/tests/test_structure/syncthru_mock_server.py, following are the PEP8 issues :

Line 27:1: W293 blank line contains whitespace
Line 33:1: W293 blank line contains whitespace

In the file pysyncthru/tests/test_web.py, following are the PEP8 issues :

Line 7:80: E501 line too long (87 > 79 characters)
Line 30:80: E501 line too long (80 > 79 characters)
Line 215:80: E501 line too long (80 > 79 characters)
Line 249:80: E501 line too long (94 > 79 characters)

In the file setup.py, following are the PEP8 issues :

Line 25:80: E501 line too long (103 > 79 characters)


[backend] Add option of edit/removing selectors

There currently exist two apis:
GET /api/v1/tornjak/selectors
POST /api/v1/tornjak/selectors

Should also have
PATCH /api/v1/tornjak/selectors
DELETE /api/v1/tornjak/selectors

Hello, I would like to work on this issue, can you assign it to me?

Hello, I would like to work on this issue, can you assign it to me?

Hi, I would like to work on this issue for university purposes. Can you assign to me?

Hello, is this issue free? I can work on this.

Yes please go for it!

Thank you to assign to me, I will start work on that.


Type ahead does not work properly in Add package window

When I use the Add package window, if I am fast and know the package name, I can type it in and see the right results. However, if I type slower, the throttle period is very little, so the list shows packages that match, say, first two letters. The problem is that any further input does not cause the list to refresh. Also, I can remove all text in the search box and enter something else, the list stays the same. The progress indicator is always on, never stops.

I mark this up-for-grabs since I think it would be a nice start for people to join the project.

I think this might be a problem upstream with the call into Paket.Core.  Even though I added the OnComplete call, it still never seems to get the OnCompleted signal and the ReactiveCommand never properly "finishes".  So this should be a good place to start looking.

First, we can increase the throttle to 500 ms instead of 250.

I am not an expert in ReactiveUI but I would have used CreateAsyncTask instead of CreateAsyncObservable.

Thank you guys for clues. It seems that it's a problem with Paket.Utils.ObservableExtensions.flatten that never called obs.OnCompleted. I'll send a PR to Paket core to fix that.


[Land and See - Home] Popular tag is misaligned for anything smaller than < 814 px

Current
Popular tag  is left aligned but the images in that section move and it looks off at different viewport sizes.

Should be
Popular tag adjusts with content to left align with content (or something else that looks better).

This does deviate from the approved design mocks, and was a compromise based on how the content came together. May need to manually set width of container to follow the list's breakpoints, as setting to inline-block, table, or left floating the parent container element to auto-resize with child contents seems to obscure the amp-list/amp-carousel content. Can add to #748 when ready, or create a new PR.


Issue 91 proper encounter calculations

Added correct encounter calculations for the routes/cities currently implemented in the game (#91).

Will this have to be updated with every new area?

I'm happy with the functionality, but will it have to be updated with every new area?

Yes it will, the only reason I didn't do them all at once is because I couldn't think of a way to automatically make the file; I had to manually copy the data from here.


Rhyming the poem

I think the rhyme should be more creative. Let's think about other options.

No creativity today. The first provided option works well.


Improve media queries

See those posts below.
Maybe the media query mixin isn't necessary anymore
https://github.com/LearnBoost/stylus/issues/608
http://learnboost.github.io/stylus/docs/mixins.html#block-mixins

no need to with {block}


Vehicle Tab

switch character sheet to vehicle mode.

new tab for users to enter campaign notes for play sessions.

I am working on a layout that is a combination of 4th d 3rd edition stats for Ground Vehicles.


WL-4020 Applied patch for Lessons announcements widget from WL-10 to 11.

Changes from announcement entity provider are added in the commit.

Sorry, doesn't merge now.

rebased


Week1 sprint1

All pages complete and responsive
------Known Defects-------

No Hamburger button for mobile view
2)Proceed to checkout button in cart not in bottom
3)PLP page navigation not expanding to full height


Teleporters break almost every time.

Teleporters break almost every time even if I set them to 0.1 or 0.0 and this happens for both advanced and normal.

Should be fixed in next release.

Fixed! Thanks!!


The current design for PowerShell functions in an Azure Function App

I just completed creating my first Azure Function App, complete with five separate PowerShell functions (four triggered by HTTP/REST, one triggered when messages are added to an Azure Storage Queue), and while working on this I ran into several design issues that raised many questions about that design that I hope to get answered. For items that you agree are issues with Azure Function Apps, I will log separate issues so that they can be tracked and properly fixed. For any of these items that are not issues and that are simply due to a misunderstanding on my part, if you could highlight what I am missing I would really appreciate it.
PowerShell module support
When it comes to PowerShell modules, I noticed that the original Azure Function Apps design was to simply search for all .dll, .psd1 and .psm1 files in a modules subfolder under an Azure function, and that about 5 months ago that was extended to recursively search for .dll, .psd1 and .psm1 files. Both the original design and this extended design are seriously flawed, a significant step backwards when it comes to support for modules when within PowerShell, and should be reconsidered.
The current design has the following flaws:

It strongly discourages the use of any modules other than your own because whatever module you use other than the most simple (single-file modules) will require manual modification, which will inevitably lead to bugs that may not be detected by the person making the modifications and that are difficult to find since you won't have access to the native PowerShell debugger.
It encourages duplication of code where such duplication does not need to exist, which will result in bugs that persist longer than they should if they are fixed in the original source code that was copied into the Azure Function App because of the module design flaws.
It discourages module dependencies by unnecessarily preventing any module that takes a dependency from being able to load properly without specific scripting to make it work the way it should in native PowerShell.
It completely ignores $env:PSModulePath and all of the value that brings to PowerShell modules.
It loses any and all notion of precedence among modules.

With the design as is today, it appears that you are reinventing the wheel with the thinking of a PowerShell 1.0 scripter. This design needs to be discarded in favor of a proper one.
Recommendation
Azure Function Apps should automatically update $env:PSModulePath in the runspace used to invoke an Azure Function that is based on PowerShell such that it includes two additional folder paths: one for all functions within an Azure Function App, and one for each PowerShell function within an Azure Function App. The folder path specific to a PowerShell function should take precedence (be defined first in $env:PSModulePath) over the folder path for all functions. This would allow for command overrides. The current design (to recursively search a modules folder for specific files) should be discarded in favor of this, so that Azure Function Apps properly leverage PowerShell's built-in module discovery mechanism ($env:PSModulePath).
There should also be a well-known folder for the shared modules location that already exists that users can copy modules into, at least using the Azure Storage Explorer, but eventually via the Azure Function Apps UI.
Added benefit
An added benefit to this design, which is well worth pursuing, is that you could have an "Add to Azure Function App" button next to modules in the PowerShell Gallery. This would be very similar to the "Add to Azure Automation" button that exists in the PowerShell Gallery today. It would allow you to install functions into Azure Function Apps, making them available for all PowerShell functions or only to a specific PowerShell function.
Workaround
You can work around this issue today by manually creating a modules folder with the Microsoft Azure Storage Explorer. I created one in the /data folder for my Azure Function App. Once that is created, place any modules you want to be able to load, including their dependencies, inside of that modules folder as is (don't extract the contents, just copy over the root module folders). Once those are in place, add a function similar to the following to any PowerShell function in your Azure Function App where you want to use those modules, and manually load the module with Import-Module:
function Import-ModuleEx {
    [CmdletBinding()]
    [OutputType([System.Void])]
    param(
        [Parameter(Position=0, Mandatory=$true)]
        [ValidateNotNullOrEmpty()]
        [System.String]
        $Name
    )
    try {
        $oldPSModulePath = $env:PSModulePath
        $modulePathEntries = @($env:PSModulePath -split ';')
        $localModulesFolder = "${env:HOME}\data\Modules"
        if ($modulePathEntries -notcontains $localModulesFolder) {
            $env:PSModulePath += ";${localModulesFolder}"
        }
        Import-Module -Name $Name -Verbose
    } finally {
        $env:PSModulePath = $oldPSModulePath
    }
}

Realistically, the modifications of $env:PSModulePath here should not be necessary, nor should I have to manually invoke Import-Module. I should simply be able to invoke a command and let PowerShell's autoloading do the rest for me. That is how modules have worked since PowerShell 2.0 was released in 2009.
If this is not properly recognized as a design issue, I would appreciate someone explaining to me why the wheel needs to be reinvented here for Azure Function Apps.
Sharing information across functions
Within my Azure Function App, I have five separate PowerShell functions. Three of those functions use the same set of credentials to connect to a managed resource, and the same csv data to do something with that resource. The current interface allows me to upload files I have on disk, or add new files directly in the UI, however referencing those files seems to be a challenge, for the following reasons:

The $pwd variable and the [Environment]::CurrentDirectory property both report the location as C:\Windows\System32.
The $env:HOME environment variable refers to a folder that is three levels higher than the folder where the run.ps1 file that defines your function body is located.
The $PSScriptRoot common variable is $null in the scope of the function when it is executed because of how that function is executed (as a dynamically created and invoked script block instead of as a PowerShell file).
For the same reasons as the previous one, $MyInvocation cannot be used to identify the path to the script file either.

The only way it seems I can reference files I upload for a specific function is by using the entire path, which I figured out is ${env:HOME}/site/wwwroot/MyAzureFunctionName/MyFileName.
To further complicate things, there does not seem to be a way to upload files such that they are accessible to multiple Azure functions from the Azure Function App console. Instead I need to choose a file location (which I did: I'm using /data/Files, right next to my /data/Modules folder), and then use the Azure Storage Explorer to upload the shared files I want to reference from multiple functions into that folder. Then, I can reference my files using the path ${env:HOME}/data/Files/MyFileName.
Recommendation
This all needs to be much easier. There really should be:

A variable that refers to the location of the current function that is being executed.
The current folder should be set to the location of the function being executed so that relative paths can be used from there (e.g. ./MyFileName).
A shared file location that is well-known, with a variable that refers to that location so that files in that folder can be easily referenced in functions within the Azure Function App.

Workaround
You can create these manually, using the folder paths I shared, or using your own, but the issue with this workaround is that it's manual and it may differ from one Azure Function App to another.
Credential management
Azure Automation, and SMA before it, both have support for credential management in a secure fashion. Azure Function Apps need something similar so that credentials can be managed in a secure way and not visible via plain text viewing of files or scripts on a screen.
Recommendation
This one is pretty straight forward -- you just need an encrypted store to put credentials into, and a PowerShell command that can be used to get them back out, unencrypted, so that they can be used in a function inside of an Azure Function App.
Workaround
Right now I'm storing my credentials unencrypted in separate json files so that they at least won't appear on screen if I am demonstrating my functionality to someone else.
Verbose output
Some PowerShell commands have verbose output if requested, and you can use the Write-Verbose command to write something to the verbose stream. This is very useful when troubleshooting, and it distinguishes between output data and verbose messaging. There doesn't seem to be a way to enable verbose output in Azure Functions, and worse, even if you manually set it in a script by setting $VerbosePreference = 'Continue', you don't get any verbose messages in the logs or output stream.
Recommendation
Verbose output is important -- there should be an option to turn on verbose output on each function without modifying that function's code, and Azure Function apps should most certainly show verbose output when PowerShell is configured to show it.
Workaround
None
Warning output
Like the Verbose output issue, Warning output is ignored/discarded. This is a big limitation that should be fixed.
Recommendation
Support warning output -- it's there for a reason!
Workaround
None
Write-Error and non-terminating errors
Azure Function Apps strays from the default error handling behaviour that exists in PowerShell by treating all errors as terminating errors. This includes non-terminating errors. This behavioural change is concerning. Azure Function Apps that are used to run PowerShell are doing so in a way that differs from how PowerShell runs. I understand the need to block certain things for security reasons -- that makes complete sense; however, I don't feel changing the core PowerShell behaviour in Azure Function Apps is the right thing to do, because that makes every script, function, or module out there potentially hit or miss -- if it runs in native PowerShell, it may not run in Azure Function Apps for the wrong reasons. Conversely, users who are less familiar with PowerShell and learn something about how PowerShell works in Azure Function Apps will eventually discover that PowerShell doesn't work that way except in Azure Functions Apps.
Recommendation
Fix this so that Azure Function Apps use of PowerShell is consistent with how PowerShell itself works.
Workaround
None. You can only use Write-Output to capture text in a benign way in the logs, and Out-File to output data to the caller of your function.
Final comments
I believe All of these unnecessary differences should be pushed out of the product in favour of consistency with the core PowerShell language except where it must behave differently for security reasons.
Thanks for listening if you made it this far.

##Shared Files
Regarding the shared files, I've found there are currently a few scenarios that work. I'd especially discourage using the Azure Storage Explorer for anything other than diagnostics.
Setup Git deployment and reference $PsHome/www/...
Reuse the Azure Function App Connection String to create a $storageCtx or save a new connection string in apps writings.

@KirkMunro, @jdkang Thank you for trying our PowerShell in Azure Functions at this experimental stage.  More importantly, thank you for your detailed and constructive feedback.  We will add your suggestions to our list of requirements for consideration in our future work for PowerShell support.

@tohling My pleasure. I have one more important thought on this topic to share while it is top of mind.
Returning output from a Azure Function written in PowerShell
Right now it seems that Azure Functions written in PowerShell have to return data via the Out-File cmdlet, putting all output data into a file referenced by the $res variable, and that log messages are written by either using the Write-Output command or simply not capturing output. This is also a questionable design, for the following reasons:

It is backwards from how PowerShell is used in practice -- normally any output from a script or function is the returned output, and messaging around that output are generated using streams (progress, warning, error, verbose, debug, or information -- information is v5+ only) or using Write-Host (which goes to the host/console).
It isn't intuitive that you need to write your output to a file to return it to the caller.
It is very limiting because the caller cannot get any streamed data from outside of the Azure Function App UI. The caller can only get output.

Recommendations

Return the output from a function as the output that is sent to the output sources (the caller if invoked via HTTP, or to an Azure Storage Message Queue), and remove the need to invoke Out-File.
For HTTP/REST API calls, provide a built-in query parameter ("streamOutput"?) that takes a true/false (non-zero/zero) value that can be used to indicate you want streamed output back from the call you invoke (this would be quite useful when debugging/troubleshooting, and it would also allow for a client-side module (could be added to AzureRm, but I could also write one easily enough and share it as an open source community project) to be written that produce that output directly in PowerShell just as if you were running the command locally, including progress bars, etc. The output sent back to the caller would then be a json structure that at the top level represents a collection of messages, with the stream identifier, any additional relevant stream details (like Write-Progress needs or like colors used in Write-Host), and records containing object data would indicate the stream was stdout, with the object data nested underneath it.
Upgrade the backend to PowerShell 5 (you really need this regardless of this issue).
Use Write-Information for log messages. I have an excellent email from Lee Holmes (PowerShell Team) that describes how Write-Information can be used for logging purposes by leveraging the Tags parameter, and that would work very well here. You could automatically log any Write-Information messages that are tagged with AzureFunctionLog. That tag is pretty unique, so you're not likely to get a conflict from Azure Functions that invoke modules, so other Information stream content would go to the Information stream (and be capturable on invocation via HTTP if you use the streamOutput option).

Workaround
I think I can get all of this (minus the PowerShell v5-specific content which requires a backend upgrade that I cannot do) working using proxy functions and by changing my Azure Functions to use a specific framework/format. It really should be designed from the ground up to work this way though.

FYI You can see verbose/warning output in the main log stream by redirecting it to standard out using the 4>&1 and 3>&1 at the end of your command. You can also redirect it to a file log of course, e.g. 4>>verbose.log

+1 for Sharing information across functions. Being able to reference $PSScriptRoot would definitely be handy..


[New Feature]: Introduce a method to easily refer to connectors in central

Description
When a connector such as openai.audio or trigger.google.drive is used, the user has to browse ballerina central and add the import statement manually to the ballerina source code in VSCode and pull the particular connector as depicted below.

Describe your problem(s)
The user has to have previous knowledge about the existence of the connector and manually add the import statement. This can be considered a UX gap.
Describe your solution(s)
In order to reduce/remove this gap one of the following solutions can be implemented.

Getting a list of published connectors/packages from the central at the start-up of the LS and loading those into the LSPackageLoader.
Provide a command like Show Examples to render a view which shows the categorization of available connectors. Selecting an item on the list of connectors will include an import statement in the source code, pulling the package from the central.

Related area
-> Editor
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

+1. This is a really good idea. We can show only packages from ballerina (already packed in distribution) and ballerinax orgs coming from central.


SSR: Fix crash when using a PBR material in glossiness/specular mode

See https://forum.babylonjs.com/t/error-on-new-ssrrenderingpipeline/41812

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13992/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13992/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13992/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13992/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13992/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13992/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13992/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13992/merge#BCU1XR#0


Strange PR merge/diff issue

Description
first commit is in main branch, and it says out-of-date with the base branch,  then updated branch by merge

After that, the merge button is grey, and try to click create squash commit, but I got 500 error.
Didn't get the log, as the max lines of terminal is 1000.
Then tried again, it merged success:

Not sure whether it is a bug. Can't reproduce it again.
Gitea Version
latest
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
build
Database
None

Tried to reproduce it, but can not create some thing like this:


Suggestion Discussion

This issue resembles all suggestions we are aware of.

[ ] World-Wide Graph
[ ] Real-Time Feeds
[ ] World Top Graph
[ ] Support for Continents/Regions
[ ] Enhance World Top List (Make it fancy.)
[ ] Aliases for Commands
[ ] Sync Data from WorldOMetrics More Frequently
[ ] Multi-Language Support
[ ] Custom Prefix
[ ] Ignored Channels

We will not be adding any more features to the bot. If you encounter a bug please make a new issue so that we can fix it. Thank you for understanding.


Font not available?

I've just installed sleek over snap, als mentioned in the description. The dialog for choosing an existing or creating a new todo.txt looks like this: Error Pic
System: Manjaro

I've just removed the snap installation and tried the AppImage. Now it looks fine and the Text is correctly displayed.

I just saw this problem with another electron app. So i presume that it is not a problem with sleek. This can be closed.

Thanks for the hint anyway! It was actually the second bug report on that topic and it only seems to occur on Arch linux based distros.
I am working on Arch myself and I will try to reproduce it and hopefully fix it.

@jkopka Quick question. I was able to reproduce it. It occuered on my Arch Linux machine when I started sleek with sudo. You didn't do that I guess?
Also please install the app again from the edge channel snap install -edge sleek. I updated (actually I am still working on it) the build process and was able to generate a snap that runs without any font problems with or without sudo. Maybe this edge release works on your Manjaro too.
I will push it to release some time soon so you get the update sooner or later anyway.

The font problem is still there in the snap version. The AppImage version is fine.
I got two messages, when i start sleek over the terminal:
(node:3874) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
Gtk-Message: 20:56:26.574: GtkDialog mapped without a transient parent. This is discouraged.

Quite some people solved your problem with this solution: https://forum.snapcraft.io/t/snap-store-fonts-on-arch-linux-are-merely-empty-rectangles/15373/6
You can of course stick to the AppImage but the Snap will be more convenient. I will try to fix the warnings you posted in the next Snap release in any case.

@jkopka don't want to bother you but could you please check the latest Snap release (revision 90) using snap install sleek? On my Arch Linux it works but I am really curious about your Manjaro.

Same same. Install Pic

@jkopka : You seem to be a couple of versions behind. Please update using snap refresh. The new version should be 0.2.3

I am just getting version 0.2.1, even with snap refresh.

Sorry, you're right, I forgot to increase the version number on Snap Store. So you're most likely already on the latest version and it's still a problem :( I will keep digging, as my heart beats for Arch Linux ;)

Hi @jkopka , I set up a fresh Manjaro and installed 0.4.1 (Revision 110) of the app and I don't have any encoding problems anymore. I hope it is solved for you too.


One more time fix the AssetType

Description

Allow asset names to be updated on the ProjectAssets database.
Change AssetTypes from uppercase to kebab-case

@dvince2 I have an issue where Model do not get their AssetName save when I create a ProjectAssetType... which makes no sense to me.

I think I want to wait until after @pascaleproulx demo on Tuesday to merge this PR. Works great locally, but this will be harder to reverse properly or quickly enough.


maybe need an "onrender" event

like when something changes...? but it's hard to specify. we have on bond for first time the tree is attached to DOM....

no need we can make something happen every render with code like this
<div>
    ${(() => {
      console.log(_top.activeTab());
    })()}
</div>


Use until for image waiting

This includes the change to use UntilWithSync for build

Codecov Report

Merging #724 (82bdf99) into main (e6d208d) will increase coverage by 0.22%.
The diff coverage is 82.00%.

:exclamation: Current head 82bdf99 differs from pull request most recent head 0af76d3. Consider uploading reports for the commit 0af76d3 to get more accurate results

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   67.31%   67.53%   +0.22%
==========================================
  Files          92       93       +1
  Lines        3711     3721      +10
==========================================
+ Hits         2498     2513      +15
+ Misses        865      862       -3
+ Partials      348      346       -2

Impacted Files
Coverage Δ

pkg/logs/watch_image.go
50.00% <50.00%> (ø)

pkg/logs/wait_for_image.go
70.00% <84.09%> (+8.15%)
:arrow_up:

pkg/logs/watch_build.go
100.00% <100.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d208d...0af76d3. Read the comment docs.


Use dotfile for cilicon.yml config

Placing a cilicon.yml in the home directory is unconventional for macOS. A more common approach is .cilicon.yml. Or use NSUserDefaults, which reads from ~/Library/Preferences

Thanks for raising the issue. In our first prototype the yml file was acutally a (hidden) dotfile. I found that having it in an easily accessible location (the users' home) and not hidden made provisioning and maintenance a lot easier. I believe that convenience wins over conventionalism here, but am open for any other arguments.

I concur with having a hidden file. At least giving it a fallback option to either one or the other is a good solution.

How about making the path customizable? The app could prompt the user for a path if the config file is not found in the default location. This could be added to the fallback view where currently the default config can be created.

I would prefer not to add unnecessary complexity (UI etc.) for this. Let's have Cilicon look for either cilicon.yml or .cilicon.yml if it can't find the former.


Can't import package if there are no packages

v1.4.2-dev+ec1cd8b8
I exported a package from one install of fb2k.
I then tried to import the package into a second copy of fb2k which had a new install of SMP. The package failed to load & I obtained the error:
The system cannot find the path specified: "Z:\f2k\foobar2000\foo_spider_monkey_panel\tmp\unpacked_package", "Z:\f2k\foobar2000\foo_spider_monkey_panel\packages\{F85C9EF0-778B-46DD-AF20-F4BE831360DD}"
May be a required folder was missing/not created. I say this since if I create a new package first, then try the import it works. Otherwise it's all looking good so far.

Thanks for reporting! Should be fixed in the dev build (once it's done).

OK thanks for that.
But I still can't properly install a package on my main foobar2000 install.
I exported a package from test portable install. Then I tried to import into main install which is a standard install.
I obtained the following error.
create_directories: Access is denied.: "C:\Program Files (x86)\foobar2000\foo_spider_monkey_panel\tmp\unpacked_package"
I assumed it should be putting packages in the profile path (rather than the Program Files location it's tried to access above). So I manually copied the necessary to the foobar2000 profile folder & that seems to be working.

Another issue with the package manager. I see the following error when trying to update packages. It ends up with a corrupted package as some files are removed but not all. The new package fails to install.  It seems that the images folder or images therein are the problem. I use assets\images with the images loaded using gdi.Image
'remove_all: Access is denied'

This is a separate problem form the one in the OP: https://github.com/TheQwertiest/foo_spider_monkey_panel/issues/137

Access denied errors will be due to this...
https://github.com/TheQwertiest/foo_spider_monkey_panel/blob/ce39bb098a9ea150baf78d18c60f7ee6617598f7/foo_spider_monkey_panel/component_paths.cpp#L30L38
It's using the main foobar2000 folder which will work fine in portable mode but fail when installed normally inside program files.

Good catch! Should've put the temp folder in the profile as well.


⚠ Samsung has degraded performance

In 10681e4, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2522 ms

Resolved: Samsung performance has improved in 283872e.


[Unity] Support clear global memory allocators

@MasterJH5574 Can you send this to apache/unity? It seems this is the only runtime-related change to get mlc-llm working with apache/unity.


1.59 webview fails to update, loses focus on key press

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.59
OS Version: MacOS Big Sur 11.4

Steps to Reproduce:

Open a webview that accepts keyboard inputs, where those keyboard inputs update the html contents.

I have an extension that opens a webview; the html in the webview has a script tag, and uses the object from acquireVsCodeApi() to accept keyboard inputs, and also input from an html form. It works fine in all versions <= 1.58. In 1.59, keyboard inputs that update the webview html cause focus to shift away from the webview. In some cases, updating the webview's html causes rendering to fail completely, though the webview.html field is still populated.
The release notes for 1.59 claim that there was a major change from <webview> tags to "normal <iframe> elements", but includes no further details, no warnings of breaking changes, and no migration guide, so I have to assume this breakage is unintended/unanticipated.

Please share the source of a minimal example extension that demonstrates this issue

@mjbvz
https://github.com/ammkrn/webview_bug_demo
I re-used the template from the official catCoding example so there may be some cat leftovers, but the only thing it does is load an HTML page with a counter, where the script in main.js accepts left/right (or h/l) keypresses. webview.onDidReceiveMessage updates the webview's html. Using 1.59, I experience the first issue reported above, where incrementing/decrementing the counter with a keystroke requires me to either click on or use tab in order to re-focus the panel. In 1.58, I could repeatedly press a key to repeat an action.
I'm not sure where to begin in terms of minimizing the second behavior (just not rendering) since the extension I'm using isn't simple. I've confirmed it works fine in 1.58, is there any effective way of comparing the webview developer tools output between the two versions?

@mjbvz
Do you know if this is related to any other known issues/anything slated to be fixed? The other open issues mentioning webviews are sort of nebulous.

@sbatten Would it help to open a new issue for the second part? I'm still getting this behavior on 1.62.3.


[feaLib] Support value records format C

Currently, feaLib can parse feature files with ValueRecords in format C — in addition to the usual four values, these have XPlaDevice, YPlaDevice, XAdvDevice, and YAdvDevice. However, when it builds GPOS tables, feaLib currently ignores these four device values. The reason is that I have not been able to figure out how exactly otTables can be used to construct the needed Device tables from code.
See the TODO comment in builder.py that contains the string “construct a Device table”. For testing, un-comment the lines after this TODO, and then  sh run-tests.sh feaLib/builder. There are two format C ValueRecords in feaLib/testdata/GPOS_1.fea which will trigger the code path to construct a GPOS table with these ValueRecords.

it look like makeotf doesn't support ValueRecords in format C either. I tried to compile the testdata/GPOS_1.fea and got a syntax error. Also the AFDKO feature file spec says it is "currently not implemented". I have never seen one of these.
Anyway, I believe the XPlaDevice, YPlaDevice, XAdvDevice and YAdvDevice fields of this format C ValueRecord are equivalent to a Device table. The latter is defined inside otData.py as having a StartSize, EndSize, DeltaFormat and a DeltaValue. The builder needs to set each of these attributes according to the values parsed from the feature file.
We just need understand how to translate between these two.
(btw, thank you for the great work you are doing with feaLib!)

Thank you, @moyogo!


Renamed FeatureGate RequestManagement to APIPriorityAndFairness

RequestManagement was renamed to APIPriorityAndFairness by this PR.

/lgtm
PR merged in 1.17 branch: https://github.com/kubernetes/kubernetes/commit/9d0a32caf8bf9f2fdc31ee586938bdbaba64fab4

preview is here
original

/assign @gochist

/unassign
/assign @kbarnard10

@kbhawkey Thank you for your comments.
I sorted.

/lgtm
This change now is more accurate than its original version.

/approve


Discuss home logic

To simplify our lives:

We need to include #578, that will mean that the SP responsibility is to always handle paths that start with root (/), only for forever, mount paths are left to the gw+registry.

Assuming 1, we can configure a SP to be provider of a home. That means that this SP will need to map root(/) to a user home directory. Internal business is not exposed.

Having 1 and 2, we can enforce namespace in the gateway the following convention:

/home to always map to the home SP (this means GetHome()  on the GW always returns /home)

Still leaving the possibility to expose the home SP under other paths:

/users/ can also be mapped to the home SP (this means GetHome() on the GW needs to take into consideration the user in context and reply with /users/hugo and use it for wrap/unwrap paths instead of just home. This model is particularly useful when exposing the home directory of a user in a global view.

With these changes there is not need anymore of having the GetHome method implemented in the SP and in the storage drivers, simplifying its implementation.

Good idea


Visual that works locally doesn't work when packaged as a pbiviz

This visual: https://github.com/jonbgallant/powerbi-visuals-liquidfillgauge...works when deving locally via localhost, but doesn't work when package and import as pbiviz.
Looks like an iframe is used with pbiviz but local does not.
Here's the pbiviz that doesn't work: https://github.com/jonbgallant/PowerBI-visuals-liquidFillGauge/tree/master/liquidFillGauge/dist
I could fix via in code, but a visual that works on local should work as pbiviz regardless of the code that is in the visual.

The debug visual is going to also be hosted inside an IFRAME in the near future. Please make sure your visuals are working in an IFRAME.
You can use the command "pbiviz package --no-minify" to package your visual with unminified code so you will be able to debug it.


Selected State für Listen-Element

@thomasschneiter Aktualisierte Doku für das Listen-Element ist hier
https://xd.adobe.com/view/4b788182-140b-46ff-46f5-3c623cf5b5b3-3d49/screen/b7a08caf-a919-41a5-8d18-a81287ddbc8d

Are there any updates?
The list item's hover colour is still #E3E0E0 but should be #DEE2E6 (Gray 3).

@CuriaPLUS hover color will be changed to "Gray 3" in v2.3.2. Is there anything else that need to be changed?

No that's it. Thank you.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_9c086a95-324f-4743-a5df-bbadb8b52f5e/pull/1 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target_9c086a95-324f-4743-a5df-bbadb8b52f5e.git

Docs Build status updates of commit 7b5f7c7:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-02-11-02-54-14 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-02-11-02-54-14

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


original component service creation logic for composites

Purpose

Add the logic to create k8s services for original dependencies in traffic shifting, for composites.

Codecov Report

Merging #107 into master will increase coverage by 0.3%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #107     +/-   ##
========================================
+ Coverage    79.2%   79.5%   +0.3%
========================================
  Files          37      38      +1
  Lines        2130    2162     +32
========================================
+ Hits         1687    1719     +32
  Misses        409     409
  Partials       34      34

Impacted Files
Coverage Δ

pkg/controller/composite/resources/meta.go
52.94% <100%> (+2.94%)
:arrow_up:

pkg/controller/composite/resources/k8s_service.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1efd592...9a3be09. Read the comment docs.


Use Sassc

how do I force middleman-sprockets to use Sassc?
Currrently...
gem 'sprockets', '~> 3.6.3'
gem 'sassc'
gem 'sassc-rails'

== The Middleman is loading
== Preferring use of LibSass
== Sprockets will render css with ruby sass

You'll need one of the Sprockets 4.0 betas -- but working off of master might be preferable (there's been a lot of work since the last beta was released)
gem 'sprockets', github: 'rails/sprockets'

It should pick up SassC then (you'll see that entry in startup change to == Sprockets will render css with SassC).
I'm curious, was the next line on startup not consider using Sprockets 4.x to render with SassC? I might have written in a bug so that doesn't get displayed.

I created this gem several months ago, but it has been sitting in my company’s private gem repo. Seeing that someone is asking about this, I have pushed it to rubygems.org. Source code is available here. Note that this is only a temporary solution before Sprockets 4.x can be released.
Hope this helps.

@vvasabi works. Sprockets from master doesn't.

We're tracking this upstream PR here: https://github.com/rtomayko/tilt/pull/336


CallFrame has broken links to $?FILE and $?LINE, $?FILE and $?LINE do not mention CallFrame

Both should mention each other properly.

[ ] https://docs.perl6.org/type/CallFrame has broken links to $?FILE and $?LINE
[ ] CallFrame is not mentioned here https://docs.perl6.org/language/variables#Compile-time_variables

Link to $?LINE in call frame is https://docs.perl6.org/type/$DOLLAR_SIGN$QUESTION_MARKLINE
when it should be
https://docs.perl6.org/language/variables#index-entry-%24%3FLINE

Links have been changed to  https://docs.perl6.org/language/variables#Compile-time_variables


Compilation fails with VS2013

In the Wiki you reommend VisuaStudio 2010. However you use newer capabilities which where introduced with VS2015.
Namely:
UniquePtr.h(25) uses [[deprecated]] - this does not compilie with VS2013
Cache.h(39) uses defaulted copy constructor - this does not compile with VS2013.
.....\tigl\src\Cache.h(39): error C2610: 'tigl::ScopeLockedReference::ScopeLockedReference(tigl::ScopeLockedReference &&)' : is not a special member function which can be defaulted (C:\data\gitRepos\tigl\src\CCPACSXsiIsoLine.cpp)
1>          c:\data\gitrepos\tigl\src\Cache.h(47) : see reference to class template instantiation 'tigl::ScopeLockedReference' being compiled
The deprecated flag can be removed to compile.
However, I am a bit at a loss how to convert the "default" to what should happen in the constructor.

In Cache.h, replaced ScopeLockedReference(ScopeLockedReference&&) = default; with
		ScopeLockedReference(ScopeLockedReference&& ref) : 			m_reference(std::move(ref.m_reference)), 			m_mutex(std::move(ref.m_mutex)) 		{}
No clue if this is correct. Now other errors appear:
......\tigl\src\.\generated/TixiHelper.h(53): error C2144: syntax error : 'auto' should be preceded by ';' (......\tigl\src\configuration\CCPACSConfiguration.cpp) ......\tigl\src\.\generated/TixiHelper.h(53): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int ((......\tigl\src\configuration\CCPACSConfiguration.cpp)

Interesting. Have you tried compiling with VS2015? TiGL now uses some C++11 features that were not used before and as fas as I know, VS2013 does not have complete C++11 supprt.
https://dlr-sc.github.io/tigl/embracing-new-technology-abandon-python-2-support-and-pre-c11-compilers.html
PS: I will update the outdated entry in our Wiki, sorry for the confusion

I could get a hold of Visual Studio 2019 Community. Here cmake does not generate the compiler flags. But I could reuse the ones from VS2013.
Also, for the java bindings I use openjdk 11. For that to compile I had to copy some files from cmake install dir to the make dir in the project, namely:
FindJava.cmake CMakeFindJavaCommon.cmake FindPackageHandleStandardArgs.cmake FindPackagemessages.cmake
Maybe update your cmake?
Back to the compile problem. I reverted my change. Now with VS2019 the error is:
2>......\tigl\src\math\CTiglProjectPointOnCurveAtAngle.cpp(228,40): error C2664:  "math_BFGS::math_BFGS(const math_BFGS &)" : Konvertierung von Argument 1 von "anonymous-namespace'::ProjectObjective" in "const Standard_Integer" nicht möglich`
Also I am not to conviced line 193 in CTiglProjectPointOnCurveAtAngle.cpp is correct:
void CTiglProjectPointOnCurveAtAngle::CTiglProjectPointOnCurveAtAngle::Compute() const

You are right. Line 191 is wrong. Strange, that it compiles with clang, gcc and msvc 2015.

@spirritus Which opencascade version are you using?

That would be 7.3.0

Indeed, the API of math_BFGS has changed slightly at 6.9.1. We are using 6.8.0. this could be easily adapted however.


Base Url does not allow custom prefix anymore

Previously one could set baseUrl to example.com/epicfreegames/. But it seems it is no longer working because of absolute URL for hcaptcha-api.js:

Échec du chargement pour l’élément

Fixed in v4: https://github.com/claabs/epicgames-freegames-node/releases/tag/v4.0.0


[WIP] Changes to improve Loris performance

This PR is stuff I’ve tried to improve our Loris performance that’s had a noticeable improvement in Gatling tests.

Briefly, the difference with and without threading:

Here’s what changing the process count did to my test:

This is the difference between Alpine and Ubuntu:

Note that this isn’t just the effect of a warmer cache – I did Alpine|Ubuntu|Alpine runs, and Ubuntu beat both instances of Alpine. Not sure why.

Here’s a zany idea: what if we cut out Loris and just proxy straight from S3?


Sync with PowerCLI 6.5.1

VMware.PowerCLI is on the PowerShell Gallery now. We should tweak Vester to recognize the differences:

VMware.PowerCLI can now be referred to as a RequiredModule (like we do for Pester) instead of an ExternalModuleDependency

Update Vester.psd1 L110 & Vester.Tests.ps1 L43

PowerCLI now supports implicit module loading when commands are called, so no more manually importing modules

Update VesterTemplate.Tests.ps1 L79

Self-assigning, and will look at this soon. Feel free to comment if any questions come to mind.

Can't specify VMware.PowerCLI as a required module right now, as PS throws a circular dependency when trying to import Vester. More details in #151


Some variables are not restored only when MirroredStragy is used.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): official docker image <tensorflow/tensorflow:2.3.1-gpu>
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): I've tried every version (>=2.3.0) and I could reproduce this bug in each of them.
Python version: I could reproduce in 3.6, 3.7, and 3.8
GPU model and memory: Not relevant. Could reproduce this issue with and without GPU.

Description
tf.keras.models.Model.load_weights method doesn't restore the optimizer slot variables only when MirroredStrategy is used.
Here's the minimum code to demonstrate this bug.
import tensorflow as tf

def prepare_model():
    model = tf.keras.models.Sequential([
        tf.keras.layers.Dense(1),
    ])
    model.compile(optimizer='adam', loss='mse')
    model.build([None, 1])
    return model

def print_opt_weights(tag):
    print(tag, list(map(lambda x: x.name, model.optimizer.weights)))
    return

labels = inputs = tf.random.uniform([5, 1])
model = prepare_model()
print_opt_weights('After model creation:')
model.fit(x=inputs, y=labels, batch_size=1)
print_opt_weights('After training:')
model.save_weights('save')

print('------------Without Distribute------------')
model = prepare_model()
print_opt_weights('After model creation:')
status = model.load_weights('save')
print_opt_weights('After load weight:')
# model.fit(x=inputs, y=labels, batch_size=1)
# print_opt_weights('After retraining:')
# status.assert_consumed()

print('------------With Distribute------------')
with tf.distribute.MirroredStrategy().scope():
    model = prepare_model()
    print_opt_weights('After model creation:')
    status = model.load_weights('save')
    print_opt_weights('After load weight:')
    # model.fit(x=inputs, y=labels, batch_size=1)
    # print_opt_weights('After retraining:')
    # status.assert_consumed()

'''
The commented out lines will make optimizers in
<without distribute> and <with distribute>
have the same number of weights.

Upon `load_weights` call, all the slot variables in the optimizer
will be created when it's not using distribution strategy,
while they are not created until the model is actually retrained
with a distribution strategy in use.
'''

The above snippet will produce the output like below:
After model creation: []
After training: ['Adam/iter:0', 'Adam/dense/kernel/m:0', 'Adam/dense/bias/m:0', 'Adam/dense/kernel/v:0', 'Adam/dense/bias/v:0']
------------Without Distribute------------
After model creation: []
After load weight: ['dense_1/kernel/m:0', 'dense_1/kernel/v:0', 'dense_1/bias/m:0', 'dense_1/bias/v:0']
------------With Distribute------------
After model creation: []
After load weight: []

As we can see from the output, the optimizer slot variables are correctly restored without MirroredStrategy, while they are not restored with MirroredStrategy.
In my code, I was calling assert_consumed method just after calling load_weights to make sure everything is loaded correctly before proceeding to any other operations. And due to this unexpected difference in the behavior, it was crushing when it uses MirroredStrategy.
In either case (with/without distribution strategy), all the variables are (probably) restored after retraining (calling fit again).
So the easiest solution will be to just ignore this difference, but I want to know what makes this difference and how we can fix this.
Thank you so much for taking the time to take a look at this issue.
Any comments or suggestions will be very helpful.

@nikitamaia Hi! I would like to kindly ask you if you could have some time to take a look at this issue.

This is (unfortunately) due to some historical constraints that optimizer slot variables are not immediately created in load_weights when a strategy is effective. This comment sheds some details. This won't affect correctness as the slot variables will be restored after retraining. If you'd like to do some verification on loading, consider using assert_existing_objects_matched.
I want to see if the constraint can be removed so the behavior is consistent w/ and w/o strategy, will post once there is a conclusion.

The follow up, it turns out the behavior can't be changed. It is to allow use cases where load_weights is put outside distribution strategy scope, so if slot variables are immediately created, they will not be created within the distribution strategy scope. If using distribution strategy, all variables must be created under the scope. See https://www.tensorflow.org/api_docs/python/tf/distribute/Strategy#scope.

Thank you for taking the time to investigate this.
But there is one thing that I don't see. What would be the reason to delay variable creation when load_weights is called inside a distribution strategy as I show in the example code? I think it is possible to create them immediately in this case, and it should be to make the behavior consistent.
What do you think?

That's a good call. In fact giving it a second thought, we should be able to allow calling load_weights outside the strategy scope and meanwhile creating the slot variable immediately, because the optimizer is created under a scope already and the scope is captured inside the optimizer.
I'll send out a fix for this soon.

@ckkuang Glad to hear that! I would really appreciate the fix.

This should have been fixed at tf-nightly. Thanks!

@ckkuang Thank you so much for the quick fix!!


Remove CDF special attributes when translating

Also fixed up tests, not to have to rewrite JSON files every time
Fixes https://github.com/pangeo-forge/pangeo-forge-recipes/pull/218

@rabernat : makes tests/recipe_tests/test_XarrayZarrRecipe.py::test_recipe_with_references tests pass


Add test cases for \Slim\Psr7\Uri

This PR adds some test cases for the \Slim\Psr7\Uri class.

Coverage increased (+0.7%) to 95.479% when pulling 4d533773f0884703e003de3e799b95a788fc4b8e on adriansuter:patch-1 into ac2ca9bbb37b645588e859ab1c824087dacfe4ed on slimphp:master.


pickaxe_run_template.py couldn't find TanimotoFilter

Hi Mr,
Your package seems like very useful for my master thesis. I wanted to ask you, why the TanimotoFilter couldn't be found?
How can I add this?
Traceback (most recent call last):
  File "/home/popeye/OneDrive/2024_Master_Bioinformatics/MINE-Search/mine_search/pickaxe_run.py", line 20, in <module>
    from minedatabase.filters import (
ImportError: cannot import name 'TanimotoFilter' from 'minedatabase.filters' (/home/popeye/.pyenv/versions/3.9.18/envs/master-mine/lib/python3.9/site-packages/minedatabase/filters/__init__.py)

I am using poetry for the environment control.
Have a great day
PAM

thx


Remove screen to chose over13 and over 18 methog. go directly to AI

When KYC is already done, we directly get the credentials.

Size: S


docs(form-component): add missing useForm import to example

Closes: #1223
Updated the Form component doc to include the missing useForm import in the example code for better clarity.

Duplicate of #665

Thanks @dan5py,
Closing this


Exception Thrown in Output: Uncaught ReferenceError: Elm is not defined

Here's a SSCCE highlighting a strange bug in Ellie. I can't provide a link because the setup crashes with an Exception Thrown in Output: Uncaught ReferenceError: Elm is not defined error notification, so I can't save.
Setup
Dependencies

allo-media/elm-daterange-picker (1.0.0)

Elm code
module Main exposing (main)

import Browser
import DateRangePicker
import Html exposing (Html, text)

type Msg
    = PickerChanged DateRangePicker.State

main : Program () () Msg
main =
    Browser.sandbox
        { init = ()
        , view = always (text "ok")
        , update = always (always ())
        }

Html code
<html>
<head>
  <style>
    /* you can style your program here */
  </style>
</head>
<body>
  <main></main>
  <script>
    var app = Elm.Main.init({ node: document.querySelector("main") })
    // you can use ports and stuff here
  </script>
</body>
</html>

Result

(notice the Compiled succesfully in the status bar)
Comment
As you can see, simply defining a Msg member referencing the DateRangePicker.State type makes Ellie crash. If I change the Msg type to:
type Msg
    = Works

it compiles.
Also, if you bypass the Browser.sandbox setup entirely and just run:
module Main exposing (main)

import DateRangePicker
import Html exposing (Html, text)

type Msg
    = PickerChanged DateRangePicker.State

main : Html Msg
main =
    text "test"

It doesn't crash.
I don't have a clue what's happening, but I know the DateRangePicker package works fine in production and in it's own demo app.

Duplicate of https://github.com/ellie-app/ellie/issues/112, https://github.com/ellie-app/ellie/issues/115, and a few others. Ultimately this is the root issue https://github.com/elm/compiler/issues/1851, it was fixed in the 0.19.1 release of Elm and will be fixed in the next release of Ellie. Thank you for taking the time to submit an issue!


File Explorer Extension to help avoid Right-to-Left character filename attacks

Description of the new feature / enhancement
When viewing filenames in file explorer, somehow highlight that they have one of the RTL override characters that allow spoofing of extensions for files in Windows. Or just the ability to turn off these characters.
Scenario when this would be used?
Dealing with files all the time we are all of course careful not to run unknown or unexpected executables, script files, screen savers, etc. However with the use of these characters (e.g. U+202E) in a filename, it can be trivial to fool even experienced Windows users into running a spoofed file.
Supporting information
Check out this excellent video from ThioJoe that discusses this issue. https://www.youtube.com/watch?v=nIcRK4V_Zvc
This is a common technique used to compromise social media and YouTube creator accounts.

/feedbackhub

OK thanks. I believe this has been raised there before. I figured the only way for it to happen is something like this or a third party. Thanks for the prompt response. I figured it was worth a shot :)


CanadaPost provider - unit

Part of property address can be a unit.

added pep8 fix

Thanks for adding this Twista


Deprecate unnecessary functions

NEWS API does not need fetchLatest and fetchPage, because fetchArticle perfectly replaces them.

fetchPage is a usefull function, since if you were to do the same thing with fetchArticle it would take 6 web request. Use fetchPage for perfomace reasons


Broken like/dislike

Like/dislike button broken (second time for me)

I'll look into this when I get the chance.

And even the icons disappeared

Fixed in <IP_ADDRESS>.


Proposal: go2 bytes size units

This is a duplicate of #19375 that has been frozen.
But given that Go2 is now in the works I thought it's good to reopen the discussion of adding a sizes unit just how working with time is amazing.
The main motivation for us is that there is a lot of places in code where you see 2 * 1024 * 1024 which is not very readable or clear. Especially since some Gophers do 2 * 1000 * 1000 or just write 2000000.
It would be much nicer if you could do Size("2MiB") or LT("1KB"). There is a couple of Go packages that do this already (I think Docker has one) but it seems to me that this is such a core expression (just like time) and so confusing to new programmers that I think it might be a good idea to include within the Go2 core.

https://play.golang.org/p/fyiUtE1qD70

I think you are suggesting that we add a new standard library package for this, and I've retitled the issue accordingly.
Is there an existing package outside of the standard library that does what you want?
In general we would need to work out a complete API.  But I suppose that first we should decide whether we need it.  https://golang.org/doc/faq#x_in_std.

@nsajko that's sort of beside the point I was hoping to convey in that this is something that is currently very fragmented. Usually with go code, if you look at someone else's it feels like you wrote it, but this particular point is always different.
Adding a standard package around it would unify the code in an idiomatic way. Especially since it can be such a lightweight implementation.
Here's one package we've used before https://github.com/docker/go-units

Is there existing code in the standard library that can use such a package? That may help support your point on unification.
Otherwise, I don’t see why this has to live in the standard library. An x/ repo might be a better place for it, if external code doesn’t want to use packages like the one you mentioned.

That might be a better place, didn't realise that's where Time is as well

I'll have a look through the core because it must be used somewhere though

Size("2MiB") would have to return an error, though. Plus if it's a function call, you can't use it with const.

Given that there is an existing package https://github.com/docker/go-units, what is the advantage of putting the package in the standard library?  Bear in mind the discussion at https://golang.org/doc/faq#x_in_std.

The reason for standardizing is exactly Because there’s lots of “good ways” to express sizes. However if code is to be optimized for readability then 2 << 10 is not at all expressive (especially for new programmers). Even though it’s the one I use I also feel it’s a relic left over from Assembly programming. The problem gets amplified since depending on the programmer they might write 2* 1024, 2048, 2000 Or 2* 1000...non of which expresses the semantic meaning and in a few cases can even lead to weird bugs only detectable with fuzzy tests because of incompatibility between them.

While 2 << 10 may not be expressive, it is a constant expression.  sizes.Size("2MiB") is not; it will require calling a function that parses a string.  Even the slightest concern for efficiency requires using something more like 2 << 10.

But I'm sure we can optimise that in the compiler? Also, I thought Go's tradeoffs leaned towards readability, not 0 cost abstractions? We have Rust for that right?

Just to be clear I'm not saying it has to be a function call, I'm just saying that the developer experience currently is broken

We could always have a set of constants called MiB, GiB, GB etc. And then you just multiply them. Then the expression would be Bytes(3) * MiB

I'm just saying that the developer experience currently is broken

I think that statement is a bit strong.

We could always have a set of constants called MiB, GiB, GB etc. And then you just multiply them. Then the expression would be Bytes(3) * MiB

That seems like an entirely different proposal.  Want to write that one out in some more detail?
(Personally I get confused between GiB and GB, but that's just me.)

Those are very fair observations, thank you.
Maybe it's something that can be added/solved by go fmt? I think as long as you settle around a 3<<10 rather than 3×1024 or 3*1000 being sent in as size params that might make it more consistent? A gentle nudge might be enough...

gofmt shouldn't normally rewrite people's code other than adjusting the formatting.

Given the lack of a clear path forward here, this seems like a likely decline.
Leaving open for a week for final comments.


Adds release version to output of osdctl --version

This adds the release version (ie. git tag for the current release) to
the version string output from the osdctl --version tag, to make
version identification more human friendly.
Signed-off-by: Christopher Collins<EMAIL_ADDRESS>

CC: @lisa - thanks for pointing this out

@fahlmant Mind putting :eyes: on this one?


chore: fix lakefile

My PR https://github.com/leanprover-community/mathlib4/pull/6423 modified the lakefile to point to a branch of the Qq library, but this had only been necessary during my local testing against a patched version of Lean. I should not have committed this change, and we should not have merged it to master.
It's harmless, I think, but should be reverted asap.

bors p=10

bors d+


UCP: Extract statement frontend as a npm package

Description
This task is to extract the statement fronted as an individual npm package, so other projects can reuse it.
Score

605

Mentor(s)

@baurine

Contact the mentors: #tidb-challenge-program channel in TiDB Community  Slack Workspace
Recommended Skills

React

Closed since this task has been merged into https://github.com/pingcap-incubator/tidb-dashboard/issues/110 .


Fixed broken doc link

Fixes the Run eShopOnDapr on Kubernetes broken link in the README file.

Thanks for fixing this!


Fix flaky p2p test

Motivation
I had to slightly lower a parameter to get the p2p test to pass when merging #2323. This sets it back to what it was, and hopefully makes the test less flaky.
Changes
Reset param, fix flaky p2p test
Test Plan
TBD
TODO

[x] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors try

bors merge


Call To MultiSigWallet

Is there any documented way to call MultiSig wallet and pass signatures to it ?

I am working on it now. If I find something useful I will ping it here.

I have no success. I have opened new issue in Neo official repository:
https://github.com/neo-project/neo/issues/270


PR status indicator takes full height

The PR status indicator takes the full height, we should fix it to have its background only behind the text

I want to work on this issue.
Requesting to get assigned it.

Thanks!
I assigned the issue :)


Added backwards compatibility for creating TelemetryClient without using dependency injection.

Added backwards compatibility for creating TelemetryClient without using dependency injection.

Hi @dnduffy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (David Duffy). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

CC: @abaranch @karting
Looks good for me.

:shipit:

Looks good!


[BEAM-11429] User-friendly names for packed combiners

This improves the readability of the stage and transform names for transforms and stages resulting from the translations.eliminate_common_key_with_none and translations.pack_combiners. This also fixes an issue where the transform name was incorrectly set to the stage name.
For example, for TranslationsTest.test_pack_combiners, previously both the Pack transform and stage  were set to (ref_AppliedPTransform_multiple-combines/mean-perkey/CombinePerKey(MeanCombineFn)_16)+(ref_AppliedPTransform_multiple-combines/count-perkey/CombinePerKey(CountCombineFn)_21)/Pack. After this change, the Pack transform name is set to multiple-combines/PackedCombinePerKey(mean-perkey/CombinePerKey(MeanCombineFn),count-perkey/CombinePerKey(CountCombineFn))/Pack and the Pack stage name is set to ref_AppliedPTransform_multiple-combines/PackedCombinePerKey(mean-perkey/CombinePerKey(MeanCombineFn)_16,count-perkey/CombinePerKey(CountCombineFn)_21)/Pack.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @robertwb @tvalentyn

cc @pabloem

Reviewers, could you take a look at the proposed naming scheme? In particular, the names use the space and square brackets characters and I'm not sure if this is permitted.

FYI Python PreCommit failures look unrelated: apache_beam.runners.interactive.utils_test.ProgressIndicatorTest.test_progress_in_HTML_JS_when_in_notebook


Added description parameter for AddSubMenu

Otherwise you have to lookup the item itself and then set the description.

Thank you! I think an extra overload with an out UIMenu newlyCreatedMenu parameter would help in some cases.


add didReceiveRegistrationToken to firebase_messaging on ios

Currently on ios on app startup FCM throws an error that didReceiveRegistrationToken is not set up and when attempting to get a token using the getToken function it will often hang without returning a token. (When using await will hang and when using a callback will never call the callback)
Adding this has fixed the issue

Signed It

Hi @urbandove thank you for the PR. You are correct that we should implement didReceiveRegistrationToken. Could you also remove didRefreshRegistrationToken? That method has been removed and should not be used.

@kroikie Done
Probably should bump the version of firebase_messaging with this change

@urbandove yes please bump the version number as well as make a CHANGELOG entry, thanks!

@urbandove thanks! Looks good to merge.


[SPARK-25540][SQL][PYSPARK] Make HiveContext in PySpark behave as the same as Scala.

What changes were proposed in this pull request?
In Scala, HiveContext sets a config spark.sql.catalogImplementation of the given SparkContext and then passes to SparkSession.builder.
The HiveContext in PySpark should behave as the same as Scala.
How was this patch tested?
Existing tests.

cc @cloud-fan @gatorsmile

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3468/
Test PASSed.

Test build #96604 has started for PR 22552 at commit 858941b.

Test build #96604 has finished for PR 22552 at commit 858941b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96604/
Test FAILed.

Jenkins, retest this please.

Test build #96610 has started for PR 22552 at commit 858941b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3473/
Test PASSed.

Test build #96610 has finished for PR 22552 at commit 858941b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96610/
Test PASSed.

thanks, merging to master/2.4!

hm, why did we merge this into 2.4 btw?

This is part of the bug fix PR: #22545 . I asked @ueshin to separate it since this one is self-contained.


change primary branch from master to main

Is your proposal related to a problem?

No. create-react-app is still using master branch for the primary branch when it generates a project. And now almost everyone is using main branch as the primary branch instead. So, it would be better if we use main branch instead. This piece will add more weight to why I am proposing this.
Describe the solution you'd like

After making the initial commit, run the command to change primary branch from master to main.
(Describe your proposed solution here.)
Describe alternatives you've considered

none.
Additional context

none.

Sorry, misread the issue originally.
Here is the previous issue about this, https://github.com/facebook/create-react-app/issues/9748.

@nrayburn-tech thanks! I didn't know. Closing the issue.


New shape added in paint with UG

new shape added name "horizontal arrows"
also added car zone game

new shape added name "horizontal arrows"
also added car zone game

Looks good

new shape added name "horizontal arrows"
also added car zone game

Looks good


Open to Updates?

Hello! I was wondering if you'd be open to a PR to bring this really neat project a bit more up to date, and in line with the current release/release candidate?

closing as the question was answered 😄


superscript/subscript, bold/italics not always parsed correctly

I've noticed that bold/italics were taken only from FONTSTYLE, however (as explained here: https://github.com/kermitt2/pdfalto/issues/57#issuecomment-527337488) sometimes the information is present in the font name (ending with -bold or _bd etc...)
I've added a unit test and try to fix the issue (https://github.com/kermitt2/grobid/tree/pdfalto_parser_fixes)  in the xml parser, however I'm not sure what's expected to be outputed from pdfalto...

Font style like bold and italic are already derived from the font name by pdfalto via xpdf (this is common to know about these font attributes), so any style information in FONTSTYLE are already covering the font name and looking again FONTFAMILY in GROBID is redundant.
In xpdf, I think the main piece performing this check is `GlobalParams.cc, line 237 (version 4.00), this method:
SysFontInfo *SysFontList::find(GString *name)

So we should never see these attributes missing in FONTSTYLE when present in the font name. If it is the case, this should be fixed normally in xpdf.

In this example I have this:
<TextStyle ID="font0" FONTFAMILY="kmhhoc+advtimes_bd" FONTSIZE="11.955" FONTTYPE="serif"
                   FONTWIDTH="proportional" FONTCOLOR="#000000" FONTSTYLE=""/>
        <TextStyle ID="font1" FONTFAMILY="kmhhod+advmtmrb" FONTSIZE="8.368" FONTTYPE="sans-serif" FONTWIDTH="fixed"
                   FONTCOLOR="#000000" FONTSTYLE="subscript"/>
        <TextStyle ID="font2" FONTFAMILY="kmhhof+advmtmib" FONTSIZE="8.368" FONTTYPE="sans-serif" FONTWIDTH="fixed"
                   FONTCOLOR="#000000" FONTSTYLE="subscript"/>
        <TextStyle ID="font3" FONTFAMILY="kmhhog+advtimes_rg" FONTSIZE="9.963" FONTTYPE="serif" FONTWIDTH="proportional"
                   FONTCOLOR="#000000" FONTSTYLE=""/>
        <TextStyle ID="font4" FONTFAMILY="kmhhoh+advmtmr" FONTSIZE="6.974" FONTTYPE="sans-serif"
                   FONTWIDTH="proportional" FONTCOLOR="#000000" FONTSTYLE="superscript"/>
        <TextStyle ID="font5" FONTFAMILY="kmhhoj+advtimes_rg_it" FONTSIZE="7.970" FONTTYPE="serif"
                   FONTWIDTH="proportional" FONTCOLOR="#000000" FONTSTYLE=""/>

JPS081033701-CC.xml.zip
JPS081033701-CC.pdf

Looking at the code, it seems that it's not looking for _bd or it or other variations like -bold:
// look for "Italic"
    if (n > 6 && !strcmp(name2->getCString() + n - 6, "Italic")) {
      name2->del(n - 6, 6);
      italic = gTrue;
      n -= 6;
    }

    // look for "Bold"
    if (n > 4 && !strcmp(name2->getCString() + n - 4, "Bold")) {
      name2->del(n - 4, 4);
      bold = gTrue;
      n -= 4;
    }

Thanks for the test case!
Yes in xpdf, it's also not constraining the match to - tag markers and only check end of font name. It looks a bit superficial.
However I am not 100% sure it's the only place in xpdf that this font name analysis is done, I just did a quick check.
Just looking a bit more, it is further done in the pdfalto part, XmlAltoOutputDev.cc, line 603-606 ("bold", "italic", "oblique") and lines 914-917.  The method normalizeFontName() is also relevant. I think it's the right places to modify to address this issue.

OK, so I've made a quick fix (https://github.com/kermitt2/pdfalto/pull/71). It's doing the same as in Java. Feel free to rewrite it, I have no clue how C++ works... 💃

Fix with PR #496, thank you Luca !


(#792, #802) Adding ApplicationLauncher to manage app services, including GobblinMetrics lifecyle

Issues

Partial fix for #792
Full fix for #802

Description

Adding an ApplicationLauncher interface that is responsible for launching Gobblin applications

Gobblin Applications are launched in a variety of ways - AzkabanJobLauncher, GobblinApplicationMaster, CliLocalJobLauncher, CliMRJobLauncher, SchedulerDaemon

A base implementation of ApplicationLauncher called ServiceBasedApplicationLauncher defines a ApplicationLauncher is a collection of Guava Services that need to be run

A core set of Services are always run, and sub-classes can add more Services

All Gobblin Application Launchers mentioned above now extend ServiceBasedApplicationLauncher

A lot of common functionality between all these classes has been moved into ServiceBasedApplicationLauncher

A MetricsReportingService has been added that starts and stops metrics reporting - this fixes the two issues mentioned above since metrics will only be started and stopped once per application
The gobblin-scheduler submodule has been deleted and its classed moved into gobblin-runtime - this way gobblin-runtime can use the scheduler classes in a more generic manner
Added a JMXReportingService for collecting JVM stats and reporting them via JMX (this code was duplicated in a few places so I moved it into a separate class)

Reviewing this PR

ApplicationLauncher and ServiceBasedApplicationLauncher are the best places to start

Am I correct that this fixes 1 and 2 of #792 as well as fixing #785?

@sahilTakiar I'm running this locally and so far the issues seem to be fixed.  I still have metrics and jmx disabled, but I'll try it with them enabled later today.

@kadaan awesome! good to know. I will work on rebasing this PR and addressing your comments sometime today.

@kadaan updated

Rebased the PR
ServiceBasedAppLauncher can now run a configurable set of Services specified by the config key app.additional.services
Addressed other comments

@zliu41 can you also take a look at this when you have a chance?

@zliu41 updated and comments addressed

LGTM

@kadaan any other comments?

@sahilTakiar LGTM (metrics work)


Add installation in README

Installation commands are missing. i.e npm install ...

It has not been published as an npm package yet. The plan was to publish it after the review.

I updated the installation steps with what requires to be configured.


Day40: 'Leaf-Similar Trees' solution

Leaf-Similar Trees
https://leetcode.com/problems/leaf-similar-trees/

Consider all the leaves of a binary tree, from left to right order, the values of those leaves form a leaf value sequence.
For example, in the given tree above, the leaf value sequence is (6, 7, 4, 9, 8).
Two binary trees are considered leaf-similar if their leaf value sequence is the same.
Return true if and only if the two given trees with head nodes root1 and root2 are leaf-similar.
Example 1:
Input: root1 = [3,5,1,6,2,9,8,null,null,7,4], root2 = [3,5,1,6,7,4,2,null,null,null,null,null,null,9,8]
Output: true
Example 2:
Input: root1 = [1,2,3], root2 = [1,3,2]
Output: false


Logo design

Hi Hello I am looking for open source projects to contribute with graphical design, I have been contributing to several opensource projects for free, I would like to know if you are interested that I make a logo for this your project ?.
It´s all free, I just need to know what do you want for the logo.
Greetings
Nuno Jesus

I sincerely appreciate the offer, but this project doesn't need a logo right now.

Ok, then.
Greetings


Finish adding unit tests for Bundler::SharedHelpers module

If this PR and #4207 are accepted/merged, then the Bundler::SharedHelpers module will have all its public methods unit tested. The only thing that's missing coverage in the spec file for Bundler::SharedHelpers is clean_load_path, which is used in the Bundler::Runtime class. This'll be hopefully addressed/covered as I look more into increasing reasonable unit test coverage to near 100%.

:umbrella: The latest upstream changes (presumably #4207) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased off master and fixed merge conflicts.

:+1: other than comments -- this is awesome, thanks so much for backfilling this test coverage @RochesterinNYC !

@homu r+

:pushpin: Commit 91b9df7 has been approved by segiddins

:hourglass: Testing commit 91b9df7 with merge 9cb0cfd...

:sunny: Test successful - status

Thanks for the feedback! And I love test coverage :+1:


Update Links

See https://github.com/Senzing/template-repository/issues/40
docker-yum/README.md:    1. [docker](https://github.com/Senzing/knowledge-base/blob/main/HOWTO/install-docker.md)
docker-yum/README.md:    1. [git](https://github.com/Senzing/knowledge-base/blob/main/HOWTO/install-git.md)
docker-yum/README.md:    1. [make](https://github.com/Senzing/knowledge-base/blob/main/HOWTO/install-make.md)

Pull requests:

https://github.com/Senzing/docker-yum/pull/100