fix async sanitizing

Fix #386

r? @therealprof
(rust_highfive has picked a reviewer for you, use r? to override)

bors try

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e4fa00961880e30527a7e57990e4eb56

This seems to have fixed our problem

bors r+


json-mode with Claude missing "{"

We trick Claude into having a json mode by seeding its response with "{". It works, in that the rest of the response follows json format, except the final Response.test doesn't include the initial "{", so it's not actually json-parsable.

Fixed by #83


MessagesSummaryResponse interface is incorrect

The interface MessagesSummaryResponse is incorrect. It states it is an array of MessageSummaryResponse but latter interface includes additional information like Text.
There is also additional keys returned by MessagesSummaryResponse that are not currently documented. For example: message_count and tags.
This response is used by listMessages() and searchMessages()

Consider generating the interfaces and types from the OpenAPI spec
https://raw.githubusercontent.com/axllent/mailpit/master/server/ui/api/v1/swagger.json


Group By Relation - Support

Problem
In order to do any type of work on a Star Schema where you select the Fact Table and join in all of the Dimensions, you will always be grouping by related columns... almost never anything in your Fact table. So for reporting / BI, this is a big deal.
We need Group By Relation support.
Suggested solution
I am expecting something like the following:
const groupUsers = await prisma.sales.groupBy({
  by: {
    time: {
        year: true // or { ordinal: 1 }
    }
  },
  _sum: {
    dollarsSold: true,
  },
})

Please note the ordinal notation brought up here: See: https://github.com/prisma/prisma/issues/8743
Alternatives
Edit - Currently Prisma uses a string array in the by clause.  You could keep that same format, just have it delimited.
Example:
by: ['time/year'],
_sum: {
  dollarsSold: true
}

This keeps more in line with what Prisma is already doing, it creates a less cluttered look, and frankly, if I am going from OData where the values are already in a delimited form, like that what is in the example, it fits perfectly without having to parse it all up and then create an object structure out of it.  This also removes the order ambiguity as mentioned above.
Additional context
Grouped aggregation is key to BI Reporting, especially when using Data Marts with a Star Schema pattern.  You are always filtering and grouping off of related tables, "Dimensions".

Is there any update regarding this request?

Leaving another comment here just to add more signals to the request.

This would be very helpful!

Bump

We're also trying to implement a query that needs to group by related fields, this feature would be very useful to us.

Same here, this feature would be very useful and allow us to use Prisma and avoid raw queries

Same here

still need this feature

Hey, happy use of Prisma here.
Do we have an idea of when this would be implemented ? I am building a Messaging / CRM app and I definitely need this feature as well.
I see the initial request is from 2 years ago while this seems to be an important feature for an ORM.

Hello, yeah really helpful for the analytics and graph

Hi! Any update?

Any update on this?

Hello,
This would be really useful

Hoping this will be implemented

This, and related features typically used in more advanced data visualization is huge for large companies considering the switch to Prisma.

Waiting for updates.

up


Remove dead code (common package)

This code was used when I was protoyping things. However, the sourcegraph jsonrpcv2 package implements this stuff now.

Acceptance tests pass against my XOA server
ddelnano@ddelnano-desktop:~/code/terraform-provider-xenorchestra$ make testacc
TF_ACC=1 go test ./... -v
?       github.com/ddelnano/terraform-provider-xenorchestra     [no test files]
=== RUN   TestGetPIFByDevice
--- PASS: TestGetPIFByDevice (0.80s)
=== RUN   TestGetTemplate
--- PASS: TestGetTemplate (0.49s)
=== RUN   TestThatUnmarshalingWorks
--- PASS: TestThatUnmarshalingWorks (0.00s)
=== RUN   TestUnmarshalingVmObject
--- PASS: TestUnmarshalingVmObject (0.00s)
PASS
ok      github.com/ddelnano/terraform-provider-xenorchestra/client      (cached)
=== RUN   TestAccXenorchestraDataSource_pif
--- PASS: TestAccXenorchestraDataSource_pif (1.25s)
=== RUN   TestAccXenorchestraDataSource_template
--- PASS: TestAccXenorchestraDataSource_template (1.26s)
=== RUN   TestAccXenorchestraCloudConfig_readAfterDelete
--- PASS: TestAccXenorchestraCloudConfig_readAfterDelete (1.16s)
=== RUN   TestAccXenorchestraCloudConfig_create
--- PASS: TestAccXenorchestraCloudConfig_create (0.91s)
=== RUN   TestAccXenorchestraCloudConfig_updateName
--- PASS: TestAccXenorchestraCloudConfig_updateName (1.60s)
=== RUN   TestAccXenorchestraCloudConfig_updateTemplate
--- PASS: TestAccXenorchestraCloudConfig_updateTemplate (1.58s)
=== RUN   TestAccXenorchestraCloudConfig_import
--- PASS: TestAccXenorchestraCloudConfig_import (1.08s)
=== RUN   TestAccXenorchestraVm_create
VM params map[string]interface {}{"CPUs":1, "VIFs":[]map[string]string{map[string]string{"network":"d225cf00-36f8-e6d6-6a29-02636d4de56b"}}, "bootAfterCreate":true, "cloudConfig":"template", "coreOs":false, "cpuCap":interface {}(nil), "cpuWeight":interface {}(nil), "existingDisks":map[string]interface {}{"0":map[string]interface {}{"$SR":"7f469400-4a2b-5624-cf62-61e522e50ea1", "name_label":"Ubuntu Bionic Beaver 18.04_imavo", "size":32212254720}}, "memoryMax":1073733632, "name_description":"description", "name_label":"Name", "template":"2dd0373e-0ed5-7413-a57f-1958d03b698c"}--- PASS: TestAccXenorchestraVm_create (51.83s)
PASS
ok      github.com/ddelnano/terraform-provider-xenorchestra/xoa 60.683s


Another bunch of fixes for 16-bit related problems

Something not right here... But these commits are included in #734, which did pass Travis CI.

@basvodde Pls restart the Travis CI build. It should pass (and did on my branch).

Closing this. Replacing by pulls that do one change at a time.


Error when run npm test inside ui folder

On the ui folder I installed node dependencies:
npm install
After that, I ran:
npm test
But I got this error:

Your current version of Node is v10... however, Stencil requires v12.10.0 or greater

Tip: To solve this I just install nvm and install version 12.10.0.
But I think we need to put it in the README file.

On the ui folder I installed node dependencies: npm install After that, I ran: npm test
But I got this error:

Your current version of Node is v10... however, Stencil requires v12.10.0 or greater

On the ui folder I installed node dependencies: npm install After that, I ran: npm test
But I got this error:

Your current version of Node is v10... however, Stencil requires v12.10.0 or greater

Tip: To solve this I just install nvm and install version 12.10.0.
But I think we need to put it in the README file.


Update to umano/AndroidSlidingUpPanel v3.3.1

Will this library be updated to the Umano v.3.3.1??

Yes, it will. Currently I'm on vacation with no computer, so I can't give you an estimated time.

@aantoine @felipinbombin Just a heads up, I'm delaying the update until the issue with the NineOldAndroids removal is solved in the original library (see https://github.com/umano/AndroidSlidingUpPanel/commit/384fefd4510224d4d2b6e9baf36bbb4e112962d8).


Bug report: upzip method

Describe the bug
This happens when I add multiple methods and then remove one method, he keeps processing, my test is that the unzip method has this problem, when I use the method that detects the file type it does not appear to keep processing
Version : CyberChef_v10.4.0
UEsDBBQACAAIAAZUilYAAAAAAAAAACUAAAAVACAATWFnaWMgb2YgRW5jb2RpbmcudHh0VVQNAAdNkTNkTpEzZE2RM2R1eAsAAQT1AQAABBQAAABLy0lMr84wKDCOrzQojc/JzDZOiS/JSI33NUnPTI43L8pMzq7lAgBQSwcIjmX6WicAAAAlAAAAUEsBAhQDFAAIAAgABlSKVo5l+lonAAAAJQAAABUAIAAAAAAAAAAAAKSBAAAAAE1hZ2ljIG9mIEVuY29kaW5nLnR4dFVUDQAHTZEzZE6RM2RNkTNkdXgLAAEE9QEAAAQUAAAAUEsFBgAAAAABAAEAYwAAAIoAAAAAAA==

blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2 Uncaught (in promise) DOMException: Failed to execute 'postMessage' on 'DedicatedWorkerGlobalScope': Value at index 0 does not have a transferable type.
at blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2:1056472
at u (blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2:947280)
at Generator. (blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2:948635)
at Generator.next (blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2:947643)
at t (blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2:954445)
at a (blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2:954648)
（匿名） @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
u @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
（匿名） @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
（匿名） @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
t @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
a @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
Promise.then（异步）
t @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
a @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
（匿名） @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
（匿名） @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
（匿名） @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
（匿名） @ blob:null/7334bf8b-9d8c-4001-95aa-dd05c765c6df:2
Compression.js:2 Uncaught (in promise) Error: End of Central Directory Record not found
at $ (Compression.js:2:311010)
at t.Y (Compression.js:2:312340)
at n.value (Compression.js:2:524223)
at e. (blob:null/4418fbbf-4390-423b-b3fb-f032172324a8:2:99450)
at l (blob:null/4418fbbf-4390-423b-b3fb-f032172324a8:2:1772910)
at Generator. (blob:null/4418fbbf-4390-423b-b3fb-f032172324a8:2:1774265)
at Generator.next (blob:null/4418fbbf-4390-423b-b3fb-f032172324a8:2:1773273)
at r (blob:null/4418fbbf-4390-423b-b3fb-f032172324a8:2:1779878)
at s (blob:null/4418fbbf-4390-423b-b3fb-f032172324a8:2:1780081)


Using friction in matter

Using boy.body.friction = 1   in matter doesn't seem to work or will it move on the slope

If the slop is static, it won't make any difference, use setFrictionStatic() method for that.


Don't roll KCP when etcd not ready or no endpoints

Description of changes:
Coming from https://github.com/abhay-krishna/cluster-api/pull/26 and https://github.com/abhay-krishna/cluster-api/pull/25
This should be another layer of protection if something happens with the etcd nodes, at leats KCP won't roll new nodes with empty etcd endpoints.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

fixed checksums, adding lgtm manually

/approve


Use const-ref for instance string

This is never used as an instance and clang-tidy rightfully complains.
This fixes that although I assume it has no real impact (IIRC a c-string is passed anyway)

What do you mean by never used as an instance?

The only usage is instance.substr( 0, instance.rfind( BOOST_PP_STRINGIZE(t) ) ) which works fine with a const&. Hence no difference except that now there are cases where this is faster

woops, misplaced the ampersand

Woops I didn’t even notice 😬

Coverage remained the same at 97.74% when pulling b5db11693361de0fb143bc1fb68566eb7b4ee185 on Flamefire:constref into 44fa60fb800c58e0bbfb516df9ec359731d73db9 on mat007:master.

Coverage remained the same at 97.74% when pulling b5db11693361de0fb143bc1fb68566eb7b4ee185 on Flamefire:constref into 44fa60fb800c58e0bbfb516df9ec359731d73db9 on mat007:master.

@mat007 Ready to merge?

Yes, thanks!


sign asynchronously - has no err in callback only token

Sign asynchronously - from the readme
  jwt.sign({ foo: 'bar' }, cert, { algorithm: 'RS256' }, function(err, token) {
    console.log(token);
  });

The generated token is in the err - the function should be like so?
  jwt.sign({ foo: 'bar' }, cert, { algorithm: 'RS256' }, function(token) {
    console.log(token);
  });

Didn't got error when I tested, can you give version and full code example, thanks

i apologize,  forgot to validate my package.json, i was on version 5.5.0.  Updating to 7.0.1 , everything works as described in the readme.


Update readme.md and related installation docs

https://github.com/PowerShell/PowerShell/blob/master/README.md
fedora 25 is EOL
ubuntu 17.04 is EOL
@anmenaga  brought up 17.04
#5984 brought up fedora 25

Moved to the docs repo https://github.com/PowerShell/PowerShell-Docs/issues/2302


[UPDATE] Plugin: git

Update branch
Plugin: git
This branch contains updates for the git plugin. If you want to add a commit, please submit a PR to my branch.
Status
READY FOR MERGE
This is now rebased against latest upstream (ff4663a6b83b8dd205da3968de4bc458abc08b2c).
There is still some stuff to do before merge:

[x] Test completion now that most compdefs were removed
[x] Settle the debate on gp/gl versus gP/gp
[x] Do another sweep to include any pending PRs related to this plugin
[ ] Update the wiki
[x] Squash commits, because atomicity is out of the window already

Changelog
The auto-closing feature should kick in when this is merged, which will ease maintenance.

 A lot of work has been put into this and it would provide an immense benefit in terms of closed issues and feature requests asked for since long ago. Whether we want a simpler
@ncanceill you have my support to solve current merge conflicts and implement the pending issues. I've been running these changes for months and I've built a workflow around it.
Let's get to work!

Echoing what @mcornella said.... @ncanceill -- if you could rebase and send my way, I'll get this merged.

@ncanceill I think this PR fixes #3543 as well.

What about splinting this file into several plugins so one can only enable the aliases he really wants, and avoid conflicts on tools on his system (see https://github.com/robbyrussell/oh-my-zsh/issues/3682)

Hi guys,
Finally rebased and sorted aliases. Yay!
I believe I did not miss any of the updates that got to upstream in the meantime; in case I did, please notify ASAP. I did, however, not include modifications conflicting with changes previously present in this PR.
I included all the changes previously present in this PR. I sorted all aliases alphabetically (a process during which I deleted a few duplicates), I removed the unnecessary compdef statements and the call to xargs as suggested by @blueyed, and added some of the aliases suggested here and there in this thread.
There are still a few things to do before this can be merged. Please see the updated message at the top.
@blueyed, can you confirm that I correctly removed the unnecessary compdefs? Also, I too find some of those "potentially destructive aliases" pretty useful, can you live with them?
 Concerning #3682, I do not think spreading the aliases over several files would solve the problem, since there would typically be no more than a few conflicting aliases anyway; I believe the idea of a warning when overriding an alias would work better.
@mcornella, would you help me browse through the open PRs to see if there anything more to include here?
@robbyrussell, thanks for the kind words, I appreciate your trust, and will notify you when this is ready for merge.
To all: can we get some testing/advice/remarks/suggestions? can we, like we did on merge vs rebase when pulling (see #2071), finally settle on gp/gl vs gP/gp?
Happy Easter/Passover/egg-hunt/whatever-you-celebrate to all!

ok for me if you remove my name from maintainer.
I have given a set of remarks. For me, on the overall it is pretty good, while I would just make one or two more step toward alias unification...
For the conflict detector, this should be a method done in the lib folder that would check if an command already exist and avoid creating the alias (and maybe print a message?). I cannot look at this for the moment unfortunately

Thanks for your remarks @Stibbons. I will get started on an alias conflict detector.

+1

OK, commits are squashed and properly rebased, I think we are good to go.
@robbyrussell merge at will, I will update the wiki when you do.

I have a remark: this PL takes too much time, is there any way for someone to get merge permission on  the plugins of oh-my-zsh?

:+1:  and I agree with @Stibbons that it will be great if someone can have it merged..

Are we good here?

@ncanceill quick question, what is the git_cmd stuff at the top of the file for? There is command git to ensure we don't use an alias or a function, but the zstyle stuff has me confused...
Will merge this one soon so it's urgent, thank you!

what is the git_cmd stuff at the top of the file for

It will use the same git as zsh's vcs_info does.
But I think that using command git as a default might be better.  But that could also get done after this PR is merged.

Ok thanks @blueyed.  Thanks!

Wow. You folks are awesome. This was a long-time coming!

Thank you @ncanceill! :heart:

Nice work! I love it. :+1:

Why, oh why, have there been aliases removed?
I have been using ggpush and ggpur everyday for 3 years, what am I supposed to do here? Define the aliases myself?
So much for backwards compatibility :( :-1:

Same for me ! Those aliases were not conflicting with other expected definitions. Why remove them ?

@fbiville @JustinAiken It seems that ggp replaces ggpush, ggu replaces ggpur. Now they become shorter, but we should remember again. :sweat_smile:

@fbiville @JunkieLand
Why not check the diff?  It's ggp now.. see https://github.com/robbyrussell/oh-my-zsh/pull/2790/files#diff-4ad2773a26526d0e361e66139c283099R107.

I agree with you guys, I executed it poorly. I'm currently working on updating the wiki entries but in the meantime @yous is right: ggp is ggpush, ggl is ggpull and ggu is ggpur.
Sorry!

@blueyed @yous good to hear they are not completely gone.
@mcornella why not keeping the old aliases, just for the sake of backwards compat?

Perhaps when removing long-standing aliases like this, instead of just having them randomly disappear without warning, one could add a deprecation notice. Something like:
Before (good):
$ gap
...works normally...

Now (bad)
$ gap
zsh: command not found: gap

What it should be (better)
$ gap
The gap alias will be removed in the next major update.
...works normally...

@mcornella :-1:  ggpull, ggpur, ggpush removed? gosh people kind of get used to aliases, I have been using this for more than a year now... Would be cool to keep those...

It took a year and tons of effort by a bunch of people to get this massive rewrite done and get merged, which is not easy already. Everyone could join the process. Please appreciate the effort. The rename process may be not elegant enough, but you can always define your own alias!
And Yay this is finally merged 🎉

Agreed, why remove "ggpull" etc commands. You realize many of us type these commands many times a day, and have been for years? Some kind of deprecation message (eg: echo "Please us ggl from now " in the alias) would have gone a long way. Not happy :-1:

And these commits also caused #3962.

the git add --patch alias seems to have been removed without a replacement. was that intentional?

Hi all,
Thank you @BlindHunter for all the hate, and much thanks to everybody else for all the love!
@robbyrussell, I and all who contributed simply wanted to improve the awesome framework you created =D

Before addressing what may have gone wrong, I believe the priority is to solve the newly introduced issues:

[ ]  local is used outside a function — #3962
[ ] the gg* aliases were renamed with shorter names — #3972
[ ] the gap alias was removed — #3972
[ ] the gdc alias conflicts with GNU D compiler — #3977

Please notify me ASAP if there are more.

Proposed fixes
`loca

@ncanceill Nevermind. You did a (almost) great job. Contributing to an open source project needs a lot of passion and it should be welcomed unless they did it in bad purpose.
Let's don't blame him/her.

Sorry :) I believe this could be filtered on the code review stage.

@BlindHunter that is OK, just remember to be cordial when asking for help or reporting issues, nobody pays me for this.
Our updating process is extremely poor right now, and all of this just shows that it drastically needs to be improved. You are welcome to join the discussion, which will start as soon as we fix the issues mentioned above.
Once again, thank you all for your support, and do not forget to thank all the other who contributed to this PR.

git_cmd was confused me. each time I run source ~/.zshrc, git_cmd=git will pop up which makes me unconformable...

Another related but slightly different issue is that the current_branch function has changed. Whereas the previous function,
function current_branch() {
ref=$(git symbolic-ref HEAD 2> /dev/null) || \
ref=$(git rev-parse --short HEAD 2> /dev/null) || return
echo ${ref#refs/heads/}
}

@ncanceill  Why not check for existence of the program before adding each alias so that any other installed program takes priority over the git aliases?

@Douglas-Su what you are experiencing is due to the local call at plugin initialization, and should be fixed shortly

@heliostatic thanks for reporting, can you elaborate on what the current_branch function does on your computer?

@CorvinM yes, we are working on an aliasing system which would take care of such things

@ncanceill It appears to do nothing? Running it in a git repo returns nothing, as does running outside a git repo.

gwip has some strange output for me now:

Sorry, everyone.

Also could you post your Git config? (gist it if it is too long to paste here).

@KenPowers thanks for reporting, this is due to the new form of the alias and will be fixed shortly; indeed, when your WIP commit does not contain deleted files, you will see this error message — however the command should still work despite the error message, does it not?

@ncanceill Thanks:

@ncanceill Yes, it still works. It just looks funny.

@ncanceill I'm guessing my issue is related to the local keyword issue that you identified in #2790

@KenPowers thanks for confirming, this will be fixed ASAP
@heliostatic in this case, would you be so kind as to fetch my fork and cherry-pick 6c29041 to see if it fixes your issue? also could you try without all those aliases in your Git config? (probably unrelated but just to be sure).

OK @KenPowers would you be so kind as to fetch my fork and cherry-pick 6ff96da to confirm that it fixes the issue with gwip?

@ncanceill fetched and cherry-picked https://github.com/robbyrussell/oh-my-zsh/commit/6c29041af73fc3668f6a3256ebc7ab532a2bbba9 which did fix my issue. Thanks!

@heliostatic awesome! I will note this as fixed, thank you for testing.

Just as a small point.  I used to be able to do ggpush --force - I can't do ggp --force, as whilst the alias expanded, the function doesn't.

@Mezzle yes this has been reported and will be fixed shortly, in the meantime you can use ggf as short for ggp --force

What's the status of git_cmd=git popping up at the top of the new shell?

@maya this is fixed in #3990 which should be merged very soon

@ncanceill Thanks for taking on the role of maintainer! I'm sure that is not easy work. I noticed that the gaa alias to git add --all was removed as well. Could that be re-included? I find it useful because I work on projects with deep tree structures so ga . will not always do what I want.

@mblayman the gaa alias will be included again in #3990. Wait for it...

When I echo $(current_branch) I get the current branch, and I when I run git pull origin $(current_branch) it works as expected, but when I run ggl for some reason it seems to call git pull origin HEAD.

That is weird, the ggl function specifically uses current_branch when called with no argument.
Can you check that you are running the proper ggl function by using which ggl?

@ncanceill

OK, I thought I got rid of those empty string problems, but I was wrong.
git pull origin "$(current_branch)"

From github.com:ncanceill/test
 * branch            master     -> FETCH_HEAD
Already up-to-date.

git pull origin "$(current_branch)" ""

From github.com:ncanceill/test
 * branch            master     -> FETCH_HEAD
 * branch            HEAD       -> FETCH_HEAD
Already up-to-date.

I will send a PR with the fix today, please standby.

@ncanceill Great, thanks! Let me know if I can help with anything.

How are you guys remembering the new ggu and ggp commands?  The letters u and p are in both words.  I know ggpur and ggpush are back in the mix, but I'm trying to use the new, 40-50% more efficient and super productive aliases.


feat: accessible tab kbd navigation

What does this PR do?
Adds accessible tab controls, following the ARIA APG: https://www.w3.org/WAI/ARIA/apg/
Test Plan
Manual
Related PRs and Issues
N/A
Have you read the Contributing Guidelines on issues?


feat: buy bitcoin link

This adds a link to the topup page.
As we do not know the URL on which the app runs we can not embed an iframe due to the moonpay's security restrictions on the iframe

@bumi please see https://github.com/getAlby/nostr-wallet-connect-next/pull/413 for moving the onchain address storage to the backend


In the Crafting Grid of Refined Storage, the amount of items consumed when Shift+Click is wrong.

Describe the bug
(It may be difficult to understand because it is machine translation.)
When using Dimensional Storage with Refined Storage's External Storage, the amount consumed when crafting with Shift+Click is unusually low.
To Reproduce
Steps to reproduce the behavior:

Connect the External Storage to the Dimensional Storage Actuator.
Stores 320 coal.
Craft the Block of Coal with Shift + click.
You have crafted 35 Block of Coal and have 257 Coal left over.

Expected behavior
There should be 5 Coal left.
Screenshots

System (please complete the following information):

Occultism Version: 1.16.5-1.26.3
OS: Windows 10
Minecraft Version: 1.16.5(Forge 36.2.26)
Modpack Link and Version, or list of mods: Refined Storage 1.9.17

Additional context
none

@theboo asked me to test this out and I can confirm.
Video for some extra details: https://streamable.com/s8qxnf
The short of it: Works as expected with auto crafting and manually crafting 1 item at a time. It only appears to break if using Sneak Click to do a full stack in Refined Storage. Assuming maths are getting wonkers with the increased stack size. Also works as expected when crafting inthe actuator.

Works correctly with the stack size override disabled.

If I see this correctly, overriding extractItem on your itemhandler should fix this. The default implementation only allows extracting a maximum of Item#maxStackSize at once.
I've made an issue on our side too https://github.com/refinedmods/refinedstorage/issues/3242

thank you so much everyone - I'll fix this on my end


QCNet Encoder vs QCNeXt Encoder

I am really impressed by the work. However, reading through QCNet paper and QCNeXt report, you have mentioned that the encoders used are the same. Whereas the Fig 1 of QCNeXt technical report shows an encoder that is different from the QCNet encoder. Also, the encoder shown in the QCNeXt, is kind of what is shown in the QCNet video presentation for the existing works that are computationally expensive. Can you please clarify for better understanding? Also any expected time frame for release of QCNeXt code?

During training, the encoder is very expensive (as you have noticed). But during inference, it CAN be much cheaper if you follow the Figure 2 in the CVPR version to make the encoder operate in a streaming manner. This approach is similar to what is called "KV cache" in GPT. Using this approach, the computation process at the inference time is equivalent to that at the training time, but the efficiency can be largely improved. Currently this codebase does not include the implementation of KV cache.


Module AppRegistry is not a registered callable module

I'm getting the following error
React-Native: Module AppRegistry is not a registered callable module
when I'm trying to run the example code. I installed all the dependencies. I have searched in google and tried the available fixes like ./gradlew clean and build etc., But, those fixes didn't help.
This might be a silly mistake. Since I'm new to react native, I couldn't fix it. Can anyone help me? If you need any other details, let me know.

@sriraman  were you able to figure this out? I'm running into the same issue.

same here

I don't know if it helps, but this happened on my project and the only thing that fixed it is to delete the whole folder, reclone and reinstall all npm packages...

Cannot reproduce it, please check latest 3.0 release, closing it for now (because ticket was for 2.x)


Allow Safeurls type for image src

I'm generating safe urls from image blobs. This cannot be passed as src parameter currently.

Only change required here is
export declare class ImageViewerComponent implements OnInit {
    moduleConfig: ImageViewerConfig;
    src: string[]|SafeUrl[];


Update flask-appbuilder

The python specification was causing piptools to fail when generating new requirements3.txt
Log:
ERROR: Command errored out with exit status 1:
       command: /code/venvs/venv/bin/python3.8 -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/code/venvs/venv/src/apache-airflow/setup.py'"'"'; __file__='"'"'/code/venvs/venv/src/apache-airflow/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-wmaeuq5b
           cwd: /code/venvs/venv/src/apache-airflow/
      Complete output (2 lines):
      gitpython not found: Cannot compute the git version.
      error in apache-airflow setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Parse error at "';python_'": Expected stringEnd

Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]

[ ] Description above provides context of the change
[ ] Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
[ ] Unit tests coverage for changes (not needed for documentation changes)
[ ] Commits follow "How to write a good git commit message"
[ ] Relevant documentation is updated including usage instructions.
[ ] I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Hey @ArgentFalcon I realized I merged my changes into the wrong base. Going to close this and create new PRs.


PS-5231: Check for empty app prices after new App Store Connect API changes

This is a monkey patch related to PS-5231
Based on this it should be a temporary for for the main open fastlane issue, for which a fix has not been released yet.
This should fix the CircleCI error message we're getting:
Main error:
/Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/deliver/lib/deliver/upload_price_tier.rb:24:in `upload': undefined method `first' for nil:NilClass (NoMethodError)

Stack
🔗  You can ⌘ + double-click on links to open them directly in your browser.
bundler: failed to load command: fastlane (/Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bin/fastlane)
Traceback (most recent call last):
	44: from /Users/distiller/.gem/ruby/2.7.4/bin/bundle:23:in `<main>'
	43: from /Users/distiller/.gem/ruby/2.7.4/bin/bundle:23:in `load'
	42: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/exe/bundle:37:in `<top (required)>'
	41: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/friendly_errors.rb:128:in `with_friendly_errors'
	40: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/exe/bundle:49:in `block in <top (required)>'
	39: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli.rb:25:in `start'
	38: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
	37: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli.rb:31:in `dispatch'
	36: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
	35: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	34: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	33: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli.rb:477:in `exec'
	32: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli/exec.rb:23:in `run'
	31: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli/exec.rb:58:in `kernel_load'
	30: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli/exec.rb:58:in `load'
	29: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bin/fastlane:23:in `<top (required)>'
	28: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bin/fastlane:23:in `load'
	27: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/bin/fastlane:23:in `<top (required)>'
	26: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/cli_tools_distributor.rb:123:in `take_off'
	25: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/commands_generator.rb:43:in `start'
	24: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/commands_generator.rb:354:in `run'
	23: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
	22: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:124:in `run!'
	21: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
	20: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
	19: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
	18: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/commands_generator.rb:110:in `block (2 levels) in run'
	17: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
	16: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/lane_manager.rb:47:in `cruise_lane'
	15: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:45:in `execute'
	14: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:45:in `chdir'
	13: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
	12: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/lane.rb:33:in `call'
	11: from Fastfile:1273:in `block (2 levels) in parsing_binding'
	10: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
	 9: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
	 8: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:229:in `execute_action'
	 7: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:229:in `chdir'
	 6: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:255:in `block in execute_action'
	 5: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/actions/actions_helper.rb:69:in `execute_action'
	 4: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:263:in `block (2 levels) in execute_action'
	 3: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/actions/upload_to_app_store.rb:22:in `run'
	 2: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/deliver/lib/deliver/runner.rb:61:in `run'
	 1: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/deliver/lib/deliver/runner.rb:161:in `upload_metadata'
/Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/deliver/lib/deliver/upload_price_tier.rb:24:in `upload': undefined method `first' for nil:NilClass (NoMethodError)
	44: from /Users/distiller/.gem/ruby/2.7.4/bin/bundle:23:in `<main>'
	43: from /Users/distiller/.gem/ruby/2.7.4/bin/bundle:23:in `load'
	42: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/exe/bundle:37:in `<top (required)>'
	41: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/friendly_errors.rb:128:in `with_friendly_errors'
	40: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/exe/bundle:49:in `block in <top (required)>'
	39: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli.rb:25:in `start'
	38: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
	37: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli.rb:31:in `dispatch'
	36: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
	35: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	34: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	33: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli.rb:477:in `exec'
	32: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli/exec.rb:23:in `run'
	31: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli/exec.rb:58:in `kernel_load'
	30: from /Users/distiller/.gem/ruby/2.7.4/gems/bundler-2.2.27/lib/bundler/cli/exec.rb:58:in `load'
	29: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bin/fastlane:23:in `<top (required)>'
	28: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bin/fastlane:23:in `load'
	27: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/bin/fastlane:23:in `<top (required)>'
	26: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/cli_tools_distributor.rb:123:in `take_off'
	25: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/commands_generator.rb:43:in `start'
	24: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/commands_generator.rb:354:in `run'
	23: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
	22: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:124:in `run!'
	21: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
	20: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
	19: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
	18: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/commands_generator.rb:110:in `block (2 levels) in run'
	17: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
	16: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/lane_manager.rb:47:in `cruise_lane'
	15: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:45:in `execute'
	14: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:45:in `chdir'
	13: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
	12: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/lane.rb:33:in `call'
	11: from Fastfile:1273:in `block (2 levels) in parsing_binding'
	10: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
	 9: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
	 8: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:229:in `execute_action'
	 7: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:229:in `chdir'
	 6: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:255:in `block in execute_action'
	 5: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/actions/actions_helper.rb:69:in `execute_action'
	 4: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/runner.rb:263:in `block (2 levels) in execute_action'
	 3: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/fastlane/lib/fastlane/actions/upload_to_app_store.rb:22:in `run'
	 2: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/deliver/lib/deliver/runner.rb:61:in `run'
	 1: from /Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/deliver/lib/deliver/runner.rb:161:in `upload_metadata'
/Users/distiller/project/app/ios/vendor/bundle/ruby/2.7.0/bundler/gems/fastlane-28f123c4dbb7/deliver/lib/deliver/upload_price_tier.rb:24:in `upload': \e[31m[!] undefined method `first' for nil:NilClass\e[0m (NoMethodError)

Exited with code exit status 1
CircleCI received exit code 1

going to test this on production apps


Perform release-related activities for 20.04

A number of checks have to be performed on the evidence files submitted by data providers as they arrive and before the pipeline is run to see whether the agreed changes have been implemented.

[x] Check UniProt
[ ] Check EVA
[ ] Check Expression Atlas evidence and baseline expression
[ ] Check EuropePMC
[ ] Check COSMIC evidence and hallmarks

In addition, some of the internal data sources have to be updated:

[ ] Update PheWAS
[ ] Update Gene2Phenotype
[ ] Update PhenoDigm
[x] Check for updates in TEPs and chemical probes

UniProt checked on March 19 and looked good:

37,551 evidence strings, +59 compared to 20.02.
7 evidence strings didn't pass validation because the variants are annotated with the "snp multiple" type, which is a known issue (see #809).

TEPs and Chemical Probes updated:

No new TEPs
76 probes in total in SGC. 4 new probes (SSGC-CAMKK2-1, SGC-CLK-1, SGC-STK17B-1, NVS-MLLT-1) have been added and one lost (SGC-iMLLT). However, new probe NVS-MLLT-1 targets the same proteins so it may have been replaced by it.
There are still 123 probes in total in the Chemical Probes Portal but there has been one addition (Taxol) and one loss (MI-77301). The latter used to be there until it disappeared in release 19.06.
There are 65 probes in total in the Open Science Probes/Donated Chemical Probes portal, after one new probe (NVS-MALT1) was added.

EVA file was received on March 20 and it looked good:

122,219 evidence strings, 6k up compared to 20.02. The ClinVar version used did not change so the increase in the number of evidence strings was caused by the new snp-to-gene mapping pipeline developed by Kirill at EVA.
The alzheimer's disease subtypes alzheimer disease, type 1, alzheimer disease, type 3 and alzheimer disease, type 4 are now correctly mapped to Early-onset autosomal dominant Alzheimer disease (Orphanet_1020) - see #104 for more info
The AD subtype alzheimer disease 2 was mapped to alzheimer's disease (EFO_0000249) instead of late-onset Alzheimers disease (EFO_1001870) and it was corrected manually - see #104 for more info
The evidence strings where the condition is Alzheimer disease (AD) and are mapped to EFO_0000249 were manually mapped to Early-onset autosomal dominant Alzheimer disease (Orphanet_1020) - see #104 for more info
Discussed with Kirill the possibility to use xrefs to Orphanet or OMIM to improve the trait-to-ontology mapping. EVA will work on this over the summer, they will align the efforts with the improvement of the manual curation pipeline.

Expression atlas data received on 17th March based on Atlas release 34:

215,921 evidence strings, +2.5k compared to 20.02
The unique association fields now include the disease id which avoids duplicated - see #795 for more info

EPMC file received on March 19:

9.655.854 evidence strings, +360k compared to 20.02.
They also submitted another file were an ML method was used to remove FPs, which reduced  the number of evidence strings by around two thirds (down to 3,276,147). This was just the first iteration and work in this area will continue in the coming months.

COSMIC file received on March 18:

Same data as the one used for 20.02, i.e. based on COSMIC v90) but with one entry per target-disease pair. Consequently, the number of evidence strings dropped to 53,929 compared to 96,284 in 20.02 but the number of associations increased slightly (+1k)  - see #811 for more info
Cancer Hallmarks file updated and based on COSMIC v91 (prior to its official release) data but only for genes present in v90 to be consistent with evidence.

PheWAS catalog evidence generated on 7th April:

Mapping of 1,360 PheWAS traits to EFO completed by @smnorthen  - see #420 for more info
Ontology-utils updated to fix issue with missing consequence terms - see #757 for more info
Parser script revamped - see PR #44 for more info

As a consequence of all those changes the number of evidence strings has gone up from 71k to 187k

Gene2Phenotype evidence generated on 2nd April:

Parsed Developmental Disorders (DD) data downloaded on 2nd April
2,375 evidence strings, up from 1,603 in 20.04
This version also includes the update of the OMIM-to-EFO mapping file done by @d0choa

PhenoDigm evidence generated on 30th March:

566,986 evidence strings, notably up from 502,550 in 20.02. In fact, the number of evidence strings has been stable between 500-505k for year an a half (since 18.10). The main reason for the increase could be IMPC release 11.0 (Feb 2020).
IMPC have been contacted to ask about their PhenoDigm Solr endpoint and they responded that it is not supported. Further conversations with them to follow.


Converting save... - Failed

"The converter returned 2491796 lines.
Only showing the last 1500"
Please help, what shall i do ?

Is this for EU4 to Vic2? If so, it doesn't yet support 1.23 or 1.24 saves. You'll need to wait for a new release.


Fix build with -integer-gmp

This change was necessary in order to build hashabler with GHCJS.

Thanks a lot! Obviously I never tried running with that flag toggled :/
If you have time to look at the tests too, that would be great:
cabal configure -fdev --enable-tests -finstrumented -f-integer-gmp && cabal build && dist/build/tests/tests

They should compile, but also we'd like that values hash the same when compiled with and without integer-gmp (especially for the GHCJS use-case); if I don't have a golden test for Natural yet it should be added.

I should also see if I can get travis to run the tests and compilation with and without integer-gmp

Good point about the tests. There are indeed similar problems as with the normal library. I'll have a commit ready shortly.

I fixed the test-suite. I ran the tests with and without the integer-gmp flag with GHC-7.10.3. Both times the test suite was succesful.
Running with GHCJS-7.10.3 results in a failure. I will create a separate ticket for that.


FINERACT-821 Added and enforced NeedBraces Checkstyle

Refer: https://issues.apache.org/jira/browse/FINERACT-821

@vorburger this is the most not-so-obedient checkstyle :(

WOW! Did you do this manually, or with a tool? IDE like Eclipse or IDEA could maybe help with something like this.. Also I'm trying to decide if I should review this carefully line by line, or just merge... @awasum @Anh3h thoughts? Should be safe?

@vorburger I tried to automate this with every plugin/ide that I knew. The best help I could get was a quick fix bulb icon, which on visiting such if/for loop would help me identify/add braces, but still I had to visit each one of them individually(not a very exciting job tbh). A detailed review will be better? although unlikely if there is a  problem, we might not even notice it after this gets merged. Also, It would be great if we could merge this is 3/4 days to avoid multiple merge conflicts :)

WOW! Did you do this manually, or with a tool? IDE like Eclipse or IDEA could maybe help with something like this.. Also I'm trying to decide if I should review this carefully line by line, or just merge... @awasum @Anh3h thoughts? Should be safe?

He is just adding needed braces where necessary, which makes code clearer. Would have been good to look through line by line. I just schemed through and nothing seems to be wrong with the PR. Even though I have not looked closely, it should not be a problem if we merge this.

Will a rebase fix the conflicts? or it needs manual resolution?

@vorburger this is ready for merge.

Why comment out the RegExpMultiline?

Argh! Sorry for another mistake.
UNINTENTIONAL AGAIN :(
Actually I use windows for this specific checkstyle (VSCcode plugin I told earlier worked smoother). The build fails in windows due to that specific checkstyle(We can probably fix that?). So I removed that for testing the code.
Adding it back in :)


Run shake without GHC installed

I'd like to use shake in more places (different CIs, other people's machines, etc.), but it seems like it needs GHC in order to run. Forcing GHC to be installed makes using shake a non-trivial thing to do. Is there a way to run shake without requiring GHC be available on the machine? Ideally, there would be a single shake binary that someone could put on a machine and it would execute a Shakefile.hs or whatever.

Given a Shakefile.hs you can compile it with ghc Shakefile.hs and then distribute the resulting binary. Is that what you are after?

I'm not sure. Would that binary be able to dynamically change what it does based on the rules in another Shakefile.hs, or is its behavior statically the same based on the Shakefile.hs it was compiled from? I'm hoping for a workflow similar to how someone might use a Makefile: change a recipe, push to CI, it runs the new recipe with the same old make binary.

Unfortunately the build script itself is written in Haskell, so there's no real chance of compiling the Shakefile.hs without a Haskell compiler. If you want to avoid that problem, you might want to write your own build system using Shake, which evaluates a simpler non-Haskell configuration language in the most case. I gave a talk about this a while back - https://ndmitchell.com/#shake_09_oct_2015 - e.g. slides at https://ndmitchell.com/downloads/slides-defining_your_own_build_system_with_shake-09_oct_2015.pdf, about slide 12.

I think that will work. Thanks!


Distance grab stops working if an interactable has an inner gameobject with trigger collider, when you swap it between hands

NOTE: Any issue that does not follow the below template will be immediately closed and not re-opened until the template structure is adhered to.

Pre-check

Do not use the issues tracker for help or support, instead try the official Slack channel, official forum or Stack Overflow.
Do a quick search and make sure the issue has not already been raised, if it has then add to the existing issue if required.

Environment

Code source:
Code version:
Platform version:
3rd party dependencies:

Steps to reproduce
VRTK.Tutorials.VRBowling.zip

Distance grab an interactable having an inner gameobject with trigger collider (the yellow ball)
Take it to another hand
Take it back to the initial hand which made the distance grab

Expected behavior
Distance grab should continue working
Current behavior
It is not

Don't provide zip files of projects, provide steps of how to recreate the issue in a fresh scene

I cannot recreate this issue. try this PR and see if it helps https://github.com/ExtendRealityLtd/Tilia.Interactions.PointerInteractors.Unity/pull/125

:tada: This issue has been resolved in version 1.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.7.0
GitHub release

Your semantic-release bot :package::rocket:


Class is missing Function in prototype chain

The following fails in the edge runtime (but not in the node runtime)
class Foo {
    constructor() {
        ...
    }
    ...
}

const cls = Foo;
cls instanceof Function // true in node runtime, false in edge runtime

Encountered when using the Firebase Client SDK while initializing the auth module where it tries to discern if a passed argument is a class or not.

It seems all prototypes are broken. Just tried this now,
console.log(Object.prototype)

prints [Object: null prototype] {} in Node, while the edge runtime returns just the empty object, {}

Hello @snystedt, can you add a reproduction of the issue?
It isn't clear it's related to Edge Runtime:
$ edge-runtime
ƒ => class Foo {}
ƒ => const cls = Foo
ƒ => const result = cls instanceof Function
ƒ => console.log(result)
true

is this a thing you are experiencing after deploy a Next.js project or a middleware via Vercel CLI?

I close it due to lack of information for now


"this" returns undefined when store module mode is splitted into files

Version
v2.1.0
Reproduction link
https://codesandbox.io/s/myr2r24q28
Steps to reproduce
check console output

What is expected ?
can access "this" object on store module files mode.
What is actually happening?
"this" object returns undefined on module files mode.

This bug report is available on Nuxt community (#c7904)

@jeehyukwon you're using an arrow function -- where this is only lexically available. See this article for a comprehensive explanation. Change chat/actions.js to:
export const test = async function({ getters, commit }) {
  console.log("multiple", this);
};

And it should work as expected.

@galvez thank you! it works as you expected.
Do you think that this should be documented on https://nuxtjs.org/guide/vuex-store/ guide?

@jericopulvera yeah I'll reopen and keep it open until one of us adds a note about it.

Closed in favor of https://github.com/nuxt/docs/issues/849 ☺


can't import RecorderController in "import 'package:audio_waveforms/audio_waveforms.dart'"

There's only WaveController exist.
Can I use WaveController instead of RecorderController?

sorry, I first see github repository instead of pub.dev.

Hey @99gony we have released the new version you can you use that from now.

Thank you!
This package is awesome.


Why numer of parameter is different with paper

I checked num of parameter of DRCT in paper, alomost 10M
But, When I run the DRCT model using 180 embed_dim, num of paramter is almost 13M.
What is different?

Hi, this may be related to the package we use to measure the model/parameter size.
We use the same package to measure their size (SwinIR/HAT/DRCT).
I need time to check which package was used for measurement. For some reason I can't immediately get the file we used.
Nonetheless, their relative relationship should the same since all three models was measued by the same package.
Thanks!

@bmnptnt
Hi,
We recalculated the parameters for HAT / HAT-L / DRCT / DRCT-L, and after careful comparison, we found that, as you mentioned, there was an error in the parameter count for HAT/DRCT, while the numbers for the Large versions are correct. We apologize for this mistake and will be updating the correct numbers on arXiv. Thank you once again.
Here are the corrected parameter counts:
HAT : 20,772,507
HAT-L : 40,846,575
DRCT : 14,139,579
DRCT-L: 27,580,719
We used fvcore to measure the parameter counts. The code is as follows:
import torch,os,sys
from torch import nn
import drct.archs.DRCT_arch as DRCT
import drct.archs.hat_arch as HAT
model = DRCT.DRCT(img_size=64,
                 patch_size=1,
                 in_chans=3,
                 embed_dim=180,
                 depths=(6, 6, 6, 6, 6 , 6),
                 num_heads=(6, 6, 6, 6, 6, 6),
                 window_size=16,
                 compress_ratio=3,
                 squeeze_factor=30,
                 conv_scale=0.01,
                 overlap_ratio=0.5,
                 mlp_ratio=2.,
                 qkv_bias=True,
                 qk_scale=None,
                 drop_rate=0.,
                 attn_drop_rate=0.,
                 drop_path_rate=0.1,
                 norm_layer=nn.LayerNorm,
                 ape=False,
                 patch_norm=True,
                 use_checkpoint=False,
                 upscale=4,
                 img_range=1.,
                 upsampler='pixelshuffle',
                 resi_connection='1conv',
                 gc = 32)

from fvcore.nn import FlopCountAnalysis, parameter_count_table
import torch

input_tensor = torch.randn(1, 3, 64, 64)

flop_count = FlopCountAnalysis(model, input_tensor)
flops = flop_count.total()

print(f"Params: {params}")


Let gpt-engineer ask for the prompt, instead of creating a prompt file

Motivation
As with AutoGPT, most of the work we do with gpt-engineer is done by typing responses to its questions. So why not make the entire process like that?
Remove the need for me to create a new folder and edit the prompt file. Instead, let me simply run:
gpt-engineer my-new-project
or just
gpt-engineer

(We can keep this backward compatible with anyone who wants to continue to use the old process.)
Current Behavior
I must copy projects/example to projects/my_new_project and edit the prompt file, before running gpt-engineer
If I had ever run gpt-engineer without any arguments before, it might have populated the example folder with work, so I need to clear those files.
Suggested Behavior
Make it simpler: If I run gpt-engineer without a project argument, it will ask:
Please give the name of your new project?

And if there is no prompt file in that folder:
Please describe what you want the new project to do?

gpt-engineer will save the description into the prompt file, and then continue as usual.

I've been thinking about optimal flow too.
Happy to get your input on reimagining it for the better.
What I think we want to support:

Run gpt-engineer to improve existing non-gpt-engineer generated codebases
Create a new codebase from scratch

Proposed CLI flow:
(command ge= short syntax for gpt-engineer)
Put all prompt files, memory etc in .gpt_engineer folder.

Run ge. Asks if you want to:
Generate a new project (create)
Update existing code (fix)
If new project, either:
a. .gpt_engineer folder exists in current directory, if so, use prompt there.
b. Ask for project name. If folder doesn't exist, create it. If prompt in project name folder/.gpt_engineer doesn't exist, create it. Before executing, allow user to edit prompt file that is generated. Try to execute code. Ask human if code worked; if not, try to fix and run again etc.
If updating existing code, ask user what files to include, and store choice to .gptengineer folder. Ask what should be fixed. Ask human if it worked, if not, try again etc.

CLI options should be simple (and are optional) and allow for:

Specifying working directory for project
Specifying fix or create
Specifying parameters for what chain to use

Did I miss anything? Anything you don't like?

Glancing through this while on the move, some great ideas. My two cents:

I would be happy to type my prompt directly into the REPL, as we do with the later questions. But file editing might make sense for some people with large specs.
We could offer both with "Type your prompt or type 'e' to open an editor"

Implementation-wise, you can manage a separate folder easily by doing system.cd(...) early in the program, and then just working in the current folder. No need to pass the target folder all around the program.


[Bounty-related] test the ERC20 token allowance request when trying to deposit

As the title says, I'd love to test the ERC20 token deposit mechanism (which requires the allowance grant from the user) but in order to do that on Goerli I'd need some ERC20 tokens on Goerli.
I figured for you it would be easy to just send me some LRCs (I saw the contract is deployed here). I case, my address on Goerli is 0xa52D85804Bf9e5ccaE8bF596639B93d0983ff82b.
Thank you in advance!

Please see https://goerli.etherscan.io/tx/0x6d1353504c7fd2c44746d9826c548e916f1853f990e5190c260d49b4fa8aacc8 1000LRC has been sent.

I correctly received the tokens, yet the situation does not seem to be reflected through the balances API in test (uat.loopring.io). I see 0 as my LRC balance, even though the related contract's address seems to be correct.


Landscape vs Large issue before API 26

Hi,
I noticed a few weeks ago that in Settings, the override built in device Land vs Large layout doesn't work properly in anything before API 26. It causes a back stack like issue you can see when:

Enter Settings in Portrait mode
Turn to landscape: pans are not shown
Click an entry: pan is shown

or

Enter Settings in Portrait mode
Click an entry: like UI settings
Turn to landscape: pans are not shown

This was not bothering
However, now, on one of my old devices I noticed it is also in Messages: the Large/Land layout is never applied
I tested in Emulator
Nexus 6 API 25 and before:

Nexus 6 API 26 and later

I tried to debug it a bit in Settings:
onIsMultiPane() is properly overridden and entered, but the effect is partial and provokes the back stack like issue. It is not only related to the "Force Tablet Mode" but also to the isTablet() changed based on language. Anything changing the device built in value for onIsMultiPane() causes the issue pre-API 26
Do you have an idea why it is like that ?

It can be fixed when starting app in Landscape directly
Broken if app is started in Landscape
Seems like an issue when restoring config change view in the code, affecting API 25 and before !

Same for all views in fact, from Main App:
Start app in portrait, turn to land:

Start app in Land directly

Start app in Land and turn device in Portrait: Land view persists !

For some reason, Configuration does not seem to be stored in the Activity.
I added the following code to onConfigurationChanged()
if (Build.VERSION.SDK_INT<=26) mActivity.getResources().updateConfiguration(newConfig, mActivity.getResources().getDisplayMetrics());
Best regards.

It is properly fixed in MainActivity views
Settings Activity not fixed, but it is not disturbing. In Settings, in landscape, with UI submenu displayed, when rotate from land to portrait, it is back to the main Settings menu instead of the currently selected UI Settings view.
But I don't think anyone will notice it
Best regards


DataFrame should provide complete variable names.

Given a DataFrame:
julia> form = readtable("test/data/factors/mixedvartypes.csv",makefactors = true)

the fields in the DataFrame type do not readily provide variable labels in the case of factors. Given that factorvar is a factor with three possible values
julia> form["factorvar"].pool
3-element UTF8String Array:
 "blue"
 "green"
 "yellow"

it would make sense to me that indicator variables that are derived from factored categorical variables should have variable names constructed for them in a field in DataFrame (perhaps something like "factorvar:blue"). This information could then be more easily pulled from the frame to label the variables in modules such as GLM.
To illustrate check out this LmMod.
julia> fm3 = lm(:(y ~ factorvar), form)

Formula: y ~ factorvar

Coefficients:
3x4 DataFrame:
        Estimate Std.Error t value  Pr(>|t|)
[1,]        0.25  0.193649 1.29099   0.25317
[2,]        0.75  0.295804 2.53546 0.0521814
[3,]        0.75  0.433013 1.73205  0.143811

the row indicies at left are pretty unsatisfying descriptors for what is being estimated. I am guessing that this is because ModelFrame does not make it easy to label the expanded variables.
Comparatively, the GLM.jl documentation mentions that in R more descriptive information is given:
> coef(summary(lm(optden ~ carb, Formaldehyde)))
               Estimate  Std. Error    t value     Pr(>|t|)
(Intercept) 0.005085714 0.007833679  0.6492115 5.515953e-01
carb        0.876285714 0.013534536 64.7444207 3.409192e-07

Should be re-opened at https://github.com/JuliaStats/StatsModels.jl/issues if this is still an issue.

In Julia, if you have a model named "model",
coefnames(model.mf)

gives you the names of all the variables, whether it is categorical or ordinal.
Again, if you parse it you cane get out of the StatType of the model names
parse.coefnames(model.mf)


[PHPStanRules]  Add ForbiddenAnonymousClassRule

Fixes #2718

All checks have passed 🎉 @TomasVotruba it is ready for review.


Refactored protocol detection and decoding into same package structure

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/392/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/394/
Test PASSed.


Update method

When I work with responsive, in some cases, I need to change the option of a element, so i suggest to build a update method. This method will update the options data (data-options, data-etc).
$('#element').foundation('update');
Or upgrade the Foundation.reInit() to update the options.
Thanks.

Alternatively destroying and reinitializing the component should also work.


application, naisjob: remove unused fields

These aren't used in naiserator anymore, so we should remove them (especially from the autogenerated reference/example documentation):

external.port.name and external.port.protocol are remnants from Istio ServiceEntry resources
sidecar.errorPath is obsolete

Do we know if anyone still have them in their Application or Naisjob resources?

Found 36 applications in prod-gcp with either of these fields set, so theres some impact at least.
Rethinking this, perhaps we should leave it as is (maybe update the documentation) as we've already fixed it in spec v2 anyway?

Will naiserator fail when reading those resources when this is merged, or ignore the extra fields?
If ignore, then fixing the documentation seems worth it.
If failing, then maybe we can live with it until v2.

Just tested deploying an Application with extra/unknown fields in a cluster with these fields removed from the CRD:

The extra fields for existing resources are pruned by the API server (no longer seen in k get app -oyaml)
naiserator, hookd/deployd, and the API server seem to just work as usual and ignore the extra fields for any new deployments


Show global namespace in --no-classes

Show global namespace in --no-classes

I will stop using issues for my personal feature requests because it makes the project look more broken than it is :sweat_smile:


Add scopes to the config ds

Purpose
This PR will add the apl:api_create scopes to the config deployer service
Fixes

https://github.com/wso2/apk/issues/1820

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (75ce98d) 29.24% compared to head (024dbb9) 21.34%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1821      +/-   ##
==========================================
- Coverage   29.24%   21.34%   -7.91%
==========================================
  Files         198       76     -122
  Lines       20893     5565   -15328
  Branches     5163     2201    -2962
==========================================
- Hits         6111     1188    -4923
+ Misses      14651     4377   -10274
+ Partials      131        0     -131

Flag
Coverage Δ

admin-domain-service
?

backoffice-domain-service
?

common-controller
1.11% <ø> (ø)

config-deployer-service
28.34% <ø> (?)

devportal-domain-service
?

idp-domain-service
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 230 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: create new command for the react template

Resolves: #337

Create a new command to create a sample react template
Reference template format for react engine: https://www.asyncapi.com/docs/tools/generator/template-development.
Added test cases

Let's wait for other maintainers review as well @Shurtu-gal @Souvikns

@Amzani Please review

/rtm

/rtm

@asyncapi/bounty_team

/bounty


Added flight data

Thanks for your contribution @aditi-n21, But I didn't find the documentation for this API. 😅


Moves HumanoidAppearanceComponent to ECS

About the PR
This moves HumanoidAppearanceComponent to ECS. It wraps around a few existing functions, removes all the functions from HumanoidAppearanceComponent, and instead replaces it with a new EntitySystem, HumanoidAppearanceSystem.

Thanks for the PR!
Another thing, the changelog is for user-facing changes (such as... fixing a certain bug, adding an item, etc) so changes such as this which don't change user-facing functionality at all don't need changelogs

got it!

Seems I caused you even more conflicts by merging your other PR-- My bad, leave a comment when they're fixed and I'll instamerge it :cold_sweat:

yeah, looks like it's OK to merge!


feat(conditions): add negative conditions for all basic conditions

📝 Description
We have a lot of conditions shortcuts to use in the CSS (like _hover) but as soon as you want to define the opposite condition, you have to manually rewrite those conditions.
So I figured that it would be a nice thing to also have the negative conditions of the ones provided by PandaCSS.
⛳ Current behavior (updates)
When you want to use opposite conditions of the one that have shortcuts, you have to manually rewrite those conditions
🚀 New behavior
All basic conditions provided by the base preset now have there negative counterpart.

Why is this PR embarking changes I haven't made on this branch (those regarding the highConstrast and leading space typos, cf #1018) 🤔
I do take care of reset the feat/negativeConditions branch on upstream/main

Hi @clementprevot,
Thanks for working on this. We don’t intend to have the negative conditions in the default config.
Please consider adding it your own panda config or publish a community preset for others to use as well.
We’ll consider this later down the line if it’s really needed.
Thanks for understanding.


Dependencies missing in readme/mac

Describe the bug
Dependencies missing in the readme/mac part, namely bisect_ppx & patdiff
Reproducing
Follow the readme on a machine with a fresh install of opam
Expected behavior
Exepected to build comby when following the readme ... and it doesn't
Additional context
I don't use ocaml in my everyday life, so I've just blindly followed the readme. I may have missed some points.
Fix
Used brew install opam && opam init ... followed the readme ... added opam install bisect_ppx patdiff ... Now make does the job.
(Thanks for the tool anyway :) )

I've retried (and re-failed) by starting with an opam switch (missed it the first time). Definitely opam install bisect_ppx patdiff fix-it. Maybe the later as a dep on the former ... but clearly not the other way around.

Thanks--the build dependencies diverged from the README. I've updated it in #62.


musescore: 4.3.0 -> 4.4.1

Description of changes
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

But did you build it locally and ran it?

The ofborg build passed, so the build for sure won't fail for you.


Merge lang-proto repo

A while ago, we discussed splitting kythe into multiple smaller per-language repos, but decided (at least for now) to keep them all in one. As part of that decision, we decided to merge the lang-proto repo back into the main one.
Git has a nifty --allow-unrelated-histories flag for merge, which I used here so we can keep the git history. Unfortunately none of the github issue/pr numbers in the merged commit messages will make sense anymore.

About to merge this. The only option on github's web ui is to squash all the commits - do we want to do an actual merge instead so we can keep the history? I can do that via command line git instead.

I think keeping the history is preferable, if possible.


ap-southeast-3 missing from Rusoto::Region

AWS officially launched the ap-southeast-3 region last year, https://docs.aws.amazon.com/general/latest/gr/rande.html#regional-endpoints but it is still missing from the rusoto_core::Region file: https://docs.rs/rusoto_core/latest/rusoto_core/enum.Region.html. This should be a quick change, could this support be added?

Created a pull-request here

Pull request accepted, pending release.


RevI: SW Updates

[ ] Use DMA for IMU data handling
[ ] Use DMA for SD Card data writing
[ ] Have app handle interleaving SD Card/RTC SPI bus accesses
[ ] Implement BLE-based SD Card maintenance
[ ] Implement BLE-based FindMyTottag
[ ] Utilize the SquarePoint Wakeup pin so that STM32 can go into deep sleep mode

New Rev, not applicable.


Simulation Window issue on Linux Mint

Discussed in https://github.com/meerk40t/meerk40t/discussions/2505

Originally posted by Alb673 June 12, 2024
Hi peeps, I have done a quick search, but haven't found something similar to my issue.
I recently downloaded the app image Linux v0.9.4020
I have noticed yesterday that while clicking simulation, it opens with a blank window. I have attached a video of the issue.
Simulation -Issue-2024-06-11T210129+0100.webm
Cheers

There is not a paid development team for Meerk40t so you will need to be patient.

I had a phenomenon like this some months ago and addressed it (and it is still fixed for me with Mk <IP_ADDRESS>, and Linux Mint under Oracle VirtualBox) so the usual questionnaire applies:
Which system, which window manager, which mk version etc.
System:
  Kernel: 5.15.0-112-generic x86_64 bits: 64 compiler: gcc v: 11.4.0 Desktop: Cinnamon 6.0.4
    tk: GTK 3.24.33 wm: muffin vt: 7 dm: LightDM 1.30.0 Distro: Linux Mint 21.3 Virginia
    base: Ubuntu 22.04 jammy

Meerk40t Help-About
Python: 3.10.12, Present
wxPython: 4.2.1 gtk3 (phoenix) wxWidgets <IP_ADDRESS>, Present
numpy: 1.26.1, Present
pillow: 9.0.1, Present
pypotrace: potracelib 1.16, Present (fast)
ezdxf: 1.1.2, Present
pyusb: 1.2.1, Present
pyserial: 3.5, Present
opencv: 4.8.1, Present
barcode-plugin: 0.2.6, Present
qrcode: ??, Present
barcodes: 0.15.1, Present
clipper: ??, Present
numba: 0.59.0, Present

If your able to run from source you can try the latest code on github

There is not a paid development team for Meerk40t so you will need to be patient.

Fair enough...I posted a question here last week. Wasn't even sure if someone saw it, and I got told on Makerforum, to do it as "issue"

@jpirnay Here are some info:
System:
Kernel: 5.15.0-112-generic x86_64 bits: 64 compiler: gcc v: 11.4.0 Desktop: Cinnamon 6.0.4
tk: GTK 3.24.33 wm: muffin vt: 7 dm: LightDM 1.30.0 Distro: Linux Mint 21.3 Virginia
base: Ubuntu 22.04 jammy
Python: 3.6.8, Present
wxPython: 4.1.1 gtk3 (phoenix) wxWidgets 3.1.5, Present
numpy: 1.19.5, Present
pillow: 8.3.2, Present
potracer: ??, Missing
ezdxf: 0.15.1, Present
pyusb: 1.2.1, Present
pyserial: 3.5, Present
opencv: 4.5.3, Present
barcode-plugin: ??, Missing
clipper: ??, Missing
numba: ??, Missing
I can definitely see that I have some stuff missing, but I wouldn't know why or how to fix it....

If your able to run from source you can try the latest code on github

I'm not sure how

I'm not sure how
https://github.com/meerk40t/meerk40t/wiki/Install:-Source

We were able to recreate it with wxPython < 4.1 and python < 3.12 - and seem to have hit a roadbloack as the underlying wxpython library seems to work incorrect. With the aforementioned combination PY 3.12 and WXP 4.2 we face no issues.
So my recommendation is clearly to go the stony way and install all the libraries - it's a one time effort but will allow you to follow much more closely the mk development.

For the time being you can as well use the workaround you show in your video: maximize / refresh (right click and fit to bed should work too)

Should be circumvented now even under wxpython 4.1 and before - will be part of next beta

Part of 0.9.5.b4


CloudTrail

Hey team,
Do we have a solution to push all cloudtrail data from AWS accounts to ES5.6 with out any failure. We are looking for a lambda function to push the data (python code)

As per readme this repo is now closed.
Ask on discuss.elastic.co please.


Settings Sync broken per usual

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: Version: 1.83.1 (Universal)
Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
Date: 2023-10-10T23:46:55.789Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.6.0
OS Version: OSX Ventura 13.5

Brand new machine.
Brand new download of VS Code
Logged in to my account on GitHub.
Sync is NOT on.
Access Backup and Sync Settings from gear menu.  Click Sign In. Shows  (Github)               Signed In
But, nothing ever runs.  If I click on the signed in account I get:
Error while turning on Settings Sync: No account available.
This has happened for the past hour.  I have quit and reopened VS Code.  No effect.
I have deleted the app and reinstalled it.  No effect.
I have deleted the app with an app "purger" that removes settings and sundry detritus left behind. Reinstalled it. No effect.
I have shut down and restarted the machine. No effect.
Here is the log:
2023-10-11 17:32:39.721 [info] Using settings sync service https://vscode-sync.trafficmanager.net/
2023-10-11 17:32:39.721 [info] Auto Sync is disabled.

On the machine I am syncing from, it appears to be working. Both machines are listed.  Log shows that Syncing occurs, but very quickly as there are no changes because the other machine isn't really visible.
Completely broken feature; perhaps the most reported problem for VS Code.  Breaks. Gets fixed. Breaks again.
Have no idea how to fix or work around. Have wasted 1 1/2 hours on this.

I fell victim to this today too (but do have a workaround below).  I had two machines (one signed into GitHub for Sync, the other signed into MS) for a while and I happened to try to unify them to a single account, unfortunately, after this bug was introduced.
On the system where I was signed in using MS, disconnecting from MS (including deleting cloud data) and trying to connect to GitHub would fail with the error above (including Error while turning on Settings Sync: No account available. popup and the exact same log messages - or lack of useful logs thereof).  I was able to reconnect it to MS and resync just fine.
I tried to disconnect the other system from GitHub and connect it to MS (which the first system connected to without issue) and the exact same error above happened to me as well.
The Git Blame for the only reference to that error message shows that the condition hasn't been touched in three years.
Since my own experience using this was inconsistent with the same user login on the same service on two different machines makes me think something was either introduced in the service at https://vscode-sync.trafficmanager.net/ or the code that calls it that is causing some sort of mismatch when trying to find the account.  Trying to switch providers may be an easy way to replicate it.
I tried going to a much older version, but it was incompatible with the sync service, so I tried using version 1.80.1 (which was also too old) and moving to newer major versions from there.  Version 1.81.1 was compatible with the sync service and didn't seem to be affected, so I was able to sync setting then upgrade as a workaround.  I'm not sure if any versions between 1.81.1 and 1.83.1 would work, I didn't want to burn any more time on it.
tl;dr: @lewisl Try installing 1.81.1 (oldest I tested still compatible with Sync service), syncing, then upgrading - it worked for me.

But, nothing ever runs. If I click on the signed in account I get:
Error while turning on Settings Sync: No account available.

@lewisl Can you please record and share? It will be helpful to understand what is happening. Can you also please share following logs?

F1 > Open View... > Window
F1 > Open View... > GitHub Account

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


unregister method is not working in iOS platform

Environment

Platforms:  iOS
iOS version: 12

Issue
Successfully calling "unregister" method getting the logs "unregistered successfully "
and After that i am sending notification. After unregistered the device notification should not coming to my device but i am getting the notification this only happen in iOS and in android same function work perfectly..

+1

I'm having the same problem

Same problem here, unregister is not working properly

Issue on https://github.com/Azure/azure-notificationhubs-android/issues/5


Make it more clear that there are assets are under a creative commons license

Contains

A hint addition to the LICENSE file to make it clear that some assets are under a creative commons license.
A more specific explanation which files are under that creative commons license.
** Some of the files @rzats added were under that license, I listed those files more explicitly so that we later know what files exactly are under that license.
** Some of the icons were made by me, I added now explictly that those are also under the same create commons license like the other icons.
5"

Outstanding before merging
@rzats please review the icon list if I got it correctly.

Hooray Jenkins reported success with all tests good!

Thanks for kicking this off @flo - much needed :-)
As mentioned above I think we should include the full license text for CC BY 4.0 in another LICENSE style file then describe the details elsewhere.

Hooray Jenkins reported success with all tests good!

I updated the PR again. The LICENCE file is now untouched. Instead i added LICENCE_NOTES files to the directories with the assets.
So this PR should now prevent someone from wrongly assuming that the icons are under the same Apache license like the source code.
I also put now my icons under CC BY 4.0 as suggested bz @Cervator .
The PR contains also a fix the extra whitespaces found by @rzats  and a encoding fix.

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Thanks again @flo :)
Went ahead and merged this then added some clarifications to the game readme as well. Noted that anything artwork related should be considered under CC BY 4.0 unless indicated otherwise. As such I think we could eventually leave the list in the Credits file as exceptions only - but right now we aren't really ready to consider that in full effect (we still have a few assets to replace and clarify - like with #2407)
I also added a LICENSE_ARTWORK file with the full CC BY 4.0 text. Can't actually find that stated as a requirement but I figure it could help clarify (avoids a possible perception of everything being under Apache 2.0 since there's only LICENSE)
Also added a second license badge thingie for completeness :-)
See commit https://github.com/MovingBlocks/Terasology/commit/4e0c6b0d9b0b77e4572de3decc18338bbfc2b48f for details and let me know if anything sticks out.

@cervator As far as I understand it you don't need to include a lucense file as long as you reference it. It seems however to require you to mention the origin (author) of the files with a clear statment what got modified. So I think we schould replace LICENSE_ARTWORK with a hint (like the files I added) that artworks might have different licenses that are explained in the credits file. It could of course also mentuon what license new artwork ideally should have. Although when reusing existing artwork the license is fixed. So maybe we want to state that certain artwirk licenses are fine as long they are clearly stated.

Yeah I think we need an overall better attribution system for artwork entirely. Like the GDoc I put together while researching block textures, or something like that.
Definitely more work to do, but we'll take it one step at a time I figure :-)


feat(ast-node-types): Add individual Node type and Add Table/TableRow/TableCell node

fix #764 as Breaking Changes
ref #902
fix #740 as Feature
close #944 - TxtNode is an abstract node that has common property. children is not common.

We want tests for this node types.

HtmlBlock is not needed?