Lost connection inconvience - postgres

Hi! I'm using dbeaver for year or two and some bug constantly remains - if the connection is lost (even if "for now" it was refsreshed and "good") and we have some (many) windows open, the behaviour is as follows:

I try to run script in the old windows;
A number of "reconnecting" windows appears (and reconnect finished happily);
But whe windows says: "connection was closed".

The only thing helps - copy script to clipboard, then instantly open new windows (ctrl+]), then paste and run. It works perfectly.

Please clarify some things so we could look deeper into it.

What Database are you using? Postgres?
What version of DBeaver are you using (You can click Help -> About to look for it)
What is disconnecting from the internet? PC with DBeaver or Database server?
What script are you executing before encountering this problem?

Postges :) as written in title (version 12, 13)
Always maximally fresh
Database (vpn swithces off, so db become unreachable)
It doesnt matter.

Please attach logs that are presented after you encounter this problem.
I tried to reproduce it and while the initial run of the script was not possible after loosing connection. Clicking invalidate/reconnect button fixed it, and I was able to run this script in the same window.

copy.log
here the log

there is no update on the issue for a long time. if it is still actual - feel free to reopen it/

@uslss, why did you close the issue? I gave all that you asked from me, problem is still exists, whats wrong?

@plotn Hello, I was reviewing this issue, and the error This connection has been closed can be constantly reproduced, but I need to know if you have tried to use Invalidate/reconnect button. Also useful would be to know your connection specifications. Do you use SSH tunnel, proxy, SSL?

@Matvey16 , got this again. Version: <IP_ADDRESS>110030714
Steps:

Run query in sql editor. Result: SQL Error [08003]: Соединение уже было закрыто
Refresh connection (right click in tree, select "Refresh"
Run query again. Same result.
Open new tab (Ctrl + ]). Run query inside it. All ok.

No tunnels, no ssh, direct connection.

@plotn I see. The refresh button is used to read the metadata of the database if it was changed (for example DDL was executed in SQL editor). The button you are looking for is Invalidate/reconnect or in russian version Проверить соединение. It is used to invalidate reconnection after network changes or session close.

Ok, I'll check it. But the situation is still incorrect - the "orphaned" windows tries to reconnect, successfully reconnect, but cannot run query saing "the connection was closed"

The situation happened.
I press "Invalidate/reconnect" - message appears "Datasource was invalidated"
I go to problem window, run sql. "Datasource was invalidated" blinking 6 times, then "Connection was closed" written.
"Сведения >>" says:
org.jkiss.dbeaver.model.impl.jdbc.JDBCException: SQL Error [08003]: Соединение уже было закрыто
at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCConnectionImpl.prepareStatement(JDBCConnectionImpl.java:197)
at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCConnectionImpl.prepareStatement(JDBCConnectionImpl.java:1)
at org.jkiss.dbeaver.model.DBUtils.createStatement(DBUtils.java:1303)
at org.jkiss.dbeaver.model.DBUtils.makeStatement(DBUtils.java:1271)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeStatement(SQLQueryJob.java:489)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.lambda$0(SQLQueryJob.java:444)
at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:171)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeSingleQuery(SQLQueryJob.java:431)
at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.extractData(SQLQueryJob.java:816)
at org.jkiss.dbeaver.ui.editors.sql.SQLEditor$QueryResultsContainer.readData(SQLEditor.java:3468)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.lambda$0(ResultSetJobDataRead.java:118)
at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:171)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.run(ResultSetJobDataRead.java:116)
at org.jkiss.dbeaver.ui.controls.resultset.ResultSetViewer$ResultSetDataPumpJob.run(ResultSetViewer.java:4796)
at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:105)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: org.postgresql.util.PSQLException: Соединение уже было закрыто
at org.postgresql.jdbc.PgConnection.checkClosed(PgConnection.java:783)
at org.postgresql.jdbc.PgConnection.prepareStatement(PgConnection.java:1680)
at org.postgresql.jdbc.PgConnection.prepareStatement(PgConnection.java:371)
at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCConnectionImpl.prepareStatement(JDBCConnectionImpl.java:244)
at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCConnectionImpl.prepareStatement(JDBCConnectionImpl.java:146)
... 15 more
"Панель журнала ошибок" says (multiple times these two lines):
Operation failed. Retry count remains = 1
SQL Error [09003]: Соединение уже было закрыто

@plotn, Hi, can you tell me more details about your VPN, does it have firewall or proxy? I tried to reproduce this issue with multiple VPN setups and it worked correctly.

I think this issue is PG-specific and related to its unique connection handling.

@plotn Problem may be related to the proxy. Does your VPN has a proxy server configured?

I've discussed it privately. They do not use proxy nor PGBouncer.

Found a way to reproduce this consistently. To reproduce it

Generate a DDL for any table (it will be generated correctly)
Diconnect from VPN or disrupt you connection in any other way
Reconnect it
Generate a DDL for this table again

This will lead to errors, even though the DDL can still be generated correctly. The errors would be recorded to log until the connection is disconnected/reconnected or invalidated through UI

@plotn does it reproducible on the latest DBeaver version?

The only problem we can reproduce now is an error that the user sees, even though it shouldn't be shown to him. We want to remove this error.
Steps to reproduce: https://github.com/dbeaver/dbeaver/issues/12559#issuecomment-1441661558


Preloader is gone

We are quite missing preloader in recent PRs, can someone please bring him back? 🥺
Seems doesn't work on the beta only
on hyper-jpeg which is production it works

Somehow is back lol, suspicious

@prachi00 👀
Probably related #2188  #2190 #2138

@yangwao it should be solved when #2190 is merged I guess

yup working


RNAi

New term RNA interference treatment (?)
then annotate
https://pubmed.ncbi.nlm.nih.gov/33789010/
Hyperoxaluria, primary, type 1 	259900

added. looks like this is for annotation for another disease. Transferring


Correction for raw affiliation Joint Research Unit 1158 BioEcoAgro,  Univ. Lille, JUNIA, INRAE, Univ. Liège, UPJV, Univ. Artois, ULCO, F-59650, Villeneuve d’Ascq, France

Correction needed for raw affiliation Joint Research Unit 1158 BioEcoAgro,  Univ. Lille, JUNIA, INRAE, Univ. Liège, UPJV, Univ. Artois, ULCO, F-59650, Villeneuve d’Ascq, France
raw_affiliation_name: Joint Research Unit 1158 BioEcoAgro,  Univ. Lille, JUNIA, INRAE, Univ. Liège, UPJV, Univ. Artois, ULCO, F-59650, Villeneuve d’Ascq, France
new_rors: 053x9s498;02kzqn938;003vg9w96;032v67m28
previous_rors: 053x9s498;02kzqn938;003vg9w96
works_examples: W4220788579;W4309408751
contact: 6ba72705bfb8a192b368cb16aef16eb9:ca1819ed8c35b4464c781996faec1797 @ u-picardie.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Use Session.getInstance of JavaMail

Close #143

@ForNeVeR any updates on this one?

Please don't say you didn't receive any notifications ._.

This PR looks good to me.
Although I will merge this only after I get back to home. We have autodeployment system set up on this project, and I'll need to monitor it in lab conditions to check whether it is alive and have no malfunctions.

@ForNeVeR alright! Thanks for the explanation! Looking forward to it.

Any updates Mr @ForNeVeR?

Sorry, still no.

Well, let the fun begin.

Okay, I can confirm that our archeotech is working.

Thank you Mr @ForNeVeR! You are da best!!


BlockingRule: Refactor to enable better iteration

Type of PR

[ ] BUG
[ ] FEAT
[x] MAINT
[ ] DOC

Summary
This PR attempts to clarify the BlockingRule class.  It is a step towards enabling ExplodingBlockingRules
It's the second in a set of two PRs which incrementally clear up/refactor the blockign rule code.
First one here
Better iteration
-🤔 When UNION ALLing blocking rules, iteration was difficult because a salted blocking rule produces a list of blocking rules as br.salted_blocking_rules, but if it was not salted, you needed to access the blocking rules directly.
So iteration looks like this, which is pretty confusing:
for br in blocking_rules:
    # Apply our salted rules to resolve skew issues. If no salt was
    # selected to be added, then apply the initial blocking rule.
    if apply_salt:
        salted_blocking_rules = br.salted_blocking_rules
    else:
        salted_blocking_rules = [br.blocking_rule]

Looking forward to adding an ExplodingBlockingRule, this logic was only going to get more compleicated
Solution: The blocking rules class itself is responsible for producing the create_blocked_pairs_sql, meaning that to generate these SELECT statements for each blocking rule it's just a case of
    br_sqls = []

    for br in blocking_rules:
        sql = br.create_blocked_pairs_sql(linker, where_condition, probability)
        br_sqls.append(sql)

    sql = " UNION ALL ".join(br_sqls)

This will allow (via polymorphism) different types of blocking rule logic to be compartmentalised and isolated in their own BlockingRule derived classes
See here for simple example

I think there's a better solution based on something like this:
class BlockingRule:
    def __init__(self, sql):
        self.sql = sql

    def pairs_sql(self):
        return f"vanilla join on {self.sql}"

class SaltedBlockingRule(BlockingRule):
    def __init__(self, sql, salt):
        super().__init__(sql)
        self.salt = salt

    def pairs_sql(self):
        base_sql = super().pairs_sql()
        return " UNION ALL ".join(
            [f"{base_sql} AND salt = '{i}'" for i in range(self.salt)]
        )

class ExplodedBlockingRule(BlockingRule):
    def pairs_sql(self):
        return f"exploded join {self.sql} "

class SaltedExplodedBlockingRule(ExplodedBlockingRule, SaltedBlockingRule):
    def __init__(self, sql, salt):
        # Initialize ExplodedBlockingRule part which in turn initializes BlockingRule.
        ExplodedBlockingRule.__init__(self, sql)
        # SaltedBlockingRule doesn't need to be initialized since it doesn't add any additional attributes.
        self.salt = salt

    def pairs_sql(self):
        exploded_sql = ExplodedBlockingRule.pairs_sql(self)
        salted_unions = " UNION ALL ".join(
            [f"{exploded_sql} AND salt = '{i}'" for i in range(self.salt)]
        )
        return salted_unions

BlockingRule("a = b").pairs_sql()
SaltedBlockingRule("a = b", 2).pairs_sql()
ExplodedBlockingRule("b=c").pairs_sql()
SaltedExplodedBlockingRule("b=c", 2).pairs_sql()

Not for this PR, but if we want to allow users to access BlockingRule as a class at some point (so they could add BRs like so BlockingRule("l.test = r.test", salting_partitions=5)) we may want to think about how we go from a standard BR -> SaltedRule.
This is more of a thought into the void more than anything, so please do ignore it.

Not for this PR, but if we want to allow users to access BlockingRule as a class at some point (so they could add BRs like so BlockingRule("l.test = r.test", salting_partitions=5)) we may want to think about how we go from a standard BR -> SaltedRule.
This is more of a thought into the void more than anything, so please do ignore it.
The logic behind this would be that it's more flexible than block_on and is arguably easier to read than the dictionary alternative.

I think that we might want a BlockingRuleCreator that has a similar implementation to the ComparisonLevelCreator, partly for this reason

Tests are failing because I now raise an error if you ask for salting on anything but Spark

Don't try and by DRY, in saltingblockingrule just repeat the sql, then the blockingrule doesn't need to know about salting
Add materialise tf when salting is enabed so that all backends support salting


Work to do:  Merge Linux PR 139

Needs some manual checks to get the Linux project merged.  Handful of conflicts but didn't look like a major effort.
https://github.com/microsoft/SqlNexus/pull/139

Updated the Linux branch with latest Master changes and resolved conflicts:
d73e64d1e26cde75a6ba028305a60d86c1368005
07a2578ba70c30b2fac5861d99a7ca60fb31def1
0e4e0f5f103397c6715af887a548ffaca2f81b84

Done


base64 crashes in React Native & Node 14

atob/btoa are not globals in React Native or Node 14.
Strategies:

Build different versions of Umi for browser/native/node. See such a strategy, starting here. Deliver userspace implementation of base64 to React Native, and use the native implementation otherwise.
Supply userspace implementation of base64 to everyone.

Option #2 is obviously awful for bundle size in browsers.

Hey Steven, thanks for raising this. Umi currently supports Node 16 and above only but I didn't know these globals were not available on React Native.
I will work on that as soon as I can but I think I can easily do option 2 without bloating the bundle size by reusing the baseX method, disabling the "leading zero" feature and mapping the serializer so it adds/removes the = padding.


No proxy option in nvm install script

Operating system and version:
NAME="Ubuntu"
VERSION="20.04.5 LTS (Focal Fossa)"
nvm debug output:

Trying to install latest = 0.39.3

nvm ls output:

none ...Trying to install

How did you install nvm?

following the readme
What steps did you perform?
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash
What happened?
error, I'm behind an entreprise proxy... no option to pass a proxy in install script
What did you expect to happen?
Well, I expected to be able to install nvm
Is there anything in any of your profile files that modifies the PATH?

no
Improved install command that worked for me (using proxy)
I propose a simple solution to correct the install script to work with proxy (only correcting curl and git, not wget... could be added)
export Proxy=http://my_enterprise_proxy:3128
curl --proxy $Proxy -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh |sed -e 's/git /git -c "http.proxy=$Proxy" /g' -e 's/curl /curl --proxy $Proxy /g' |bash

To use nvm, I also needed to add $Proxy var to the .nvm/nvm.sh script on line 124
    curl --fail ${CURL_COMPRESSED_FLAG:-} -q "$@"

    curl --proxy $Proxy --fail ${CURL_COMPRESSED_FLAG:-} -q "$@"

If you’re behind a proxy then installing node won’t work either, as you discovered. Why does your enterprise proxy block outbound requests?

No, it works with the change I posted.
I managed to install nodejs 14/16/18/19 and use them without any problem (after declaring my proxy of course when needed)
The proxy my enterprise uses is a filtering one.... only dns declared are allowed.

And there’s no way you could get them to allow github and nodejs.org?

I did, it works now BUT I have to tell curl and git to use the proxy.... thus the issue I posted
There's no option in nvm to tell it to use a proxy right now...

that's not what i mean - i mean, tell your company to be less restrictive in its proxy configuration.
Separately, could you use a SOCKS proxy so it was transparent to tooling?
I agree there's no option in nvm to use a proxy, and it explicitly ignores curlrc which might be configured to use one, but that's somewhat by design.

I'd really like if telling my company that was a possibility but that's the problem... most company put these type of restriction with the aim to limit access to external network, so no, that's not an option sadly...
I don't want to use a sock proxy because depending of what resource I need to access, I'm using various proxy or vpn depending of the use case.
But if you look at what I did, getting nvm to work with proxy seems pretty easy:

for the install part, we'd simply need to tell curl to use the proxy whenever we want to download something (thus the sed part in the command line to add --proxy $Proxy everywhere... even when it's not needed like invoking curl --version) and same for git to clone nvm repo (-c http.proxy=$Proxy)
What would be nice is to set an env var and then in the install script, it would be possible to define additional options for curl and git to use.
Assuming NVM_PROXY the proxy we want nvm to use and CURL_PROXY / GIT_PROXY the option we would pass to these command:

if [ ! -z ${NVM_PROXY+x} ] ;then
  CURL_PROXY="--proxy ${NVM_PROXY}"
  GIT_PROXY="-c http.proxy=${NVM_PROXY}"
fi

for the nvm.sh script, I only needed to change the curl command in the nvm_download function to get nvm working perfectly
But I guess there may be something to let it also update itself (eg. git pull) somewhere that I missed?

No, nvm doesn't update itself, you update it by rerunning the install script.
I agree it'd be a relatively straightforward addition to have nvm respect a proxy setting, but there's a few complications - for one, nvm works with either curl or wget, so we'd have to make sure the proxy argument was equally configurable - but more importantly, it'd be a huge source of bugs, and since you're the first person i'm aware of to request it in over a decade, we might want to wait until there's higher demand for it.

Ok, I understand your choice.
And as it was quite easy for me to "add" proxy option by simply using a sed command, I'll keep doing that for now.
Anyway, thank you very much for this tool that helps a lot and for listening to my request! :+1:

Operating system and version:
NAME="Ubuntu" VERSION="20.04.5 LTS (Focal Fossa)"
nvm debug output:
nvm ls output:
How did you install nvm?
following the readme
What steps did you perform?
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash
What happened?
error, I'm behind an entreprise proxy... no option to pass a proxy in install script
What did you expect to happen?
Well, I expected to be able to install nvm
Is there anything in any of your profile files that modifies the PATH?
no
Improved install command that worked for me (using proxy)
I propose a simple solution to correct the install script to work with proxy (only correcting curl and git, not wget... could be added)
export Proxy=http://my_enterprise_proxy:3128
curl --proxy $Proxy -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh |sed -e 's/git /git -c "http.proxy=$Proxy" /g' -e 's/curl /curl --proxy $Proxy /g' |bash

string

string

@ZackaryJacobthereal I'm not sure I understand your comment.... ???

Related: #963, #3366.

Related: #963, #3366.

Reading the replies to #963 my need of a proxy could also be resolved by setting the https_proxy linux env variable, but I would have to set it each time before invoking nvm.
I have to use various proxy and the default proxy set in https_proxy is not the one allowing me to use nvm...
Thus for me the need for a specific NVM_Proxy setting, it's far more convenient to use.


Introduce LVMS operator deploy

This patch introduces a new make target that allows to trigger the LVMS operator deployment.
However, it requires >=1 additional disks attached to the crc VM and they will be used to build
the associated LVMCluster.

This is the current result after "manually" applying lvms target and deploying the ctlplane with vdb:100G:
vdb                         252:16   0  100G  0 disk
├─vg1-thin--pool--1_tmeta   253:0    0   48M  0 lvm
│ └─vg1-thin--pool--1-tpool 253:2    0 89.9G  0 lvm
│   └─vg1-thin--pool--1     253:3    0 89.9G  1 lvm
└─vg1-thin--pool--1_tdata   253:1    0 89.9G  0 lvm
  └─vg1-thin--pool--1-tpool 253:2    0 89.9G  0 lvm
    └─vg1-thin--pool--1     253:3    0 89.9G  1 lvm

NAME                                                              READY   STATUS
fdc083e1fa5c9aafe131a5eeeb19c49d045d1f746562a90dc0fce6a98cg5mpl
lvms-catalogsource-prwss                                          1/1     Running
lvms-operator-847455cf86-qtrh4                                    1/1     Running
vg-manager-2dzjl                                                  1/1     Running

NAME                                     PROVISIONER                        RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION
crc-csi-hostpath-provisioner (default)   kubevirt.io.hostpath-provisioner   Delete          WaitForFirstConsumer   false
lvms-vg1                                 topolvm.io                         Delete          WaitForFirstConsumer   true

we still need to do a few more tests and refine the strategy but sounds promising.

+2 (aside from maybe increasing the default to 100GB)
This patch works well for me. I was able to deploy and use LVMS on my control plane pods a few times reliably as described below.

Clean Previous deployment (optional)

cd ~/install_yamls/devsetup
make crc_cleanup

Deploy CRC

make CPUS=12 MEMORY=49152 DISK=100 crc
make crc_attach_default_interface
cd ..

Deploy LVMS operator

make lvms

Observe lvms-operator

oc get pods -n openshift-storage

Deploy vg-manager

make lvms_deploy

Observe vg-manager and storage class

oc get pods -n openshift-storage
oc get sc

Replace local-storage with lvms-vg1 in OpenStack CRs

STORAGE_CLASS=lvms-vg1 make openstack_deploy_prep

Remove vg-manager (after control plane is removed)

make lvms_deploy_cleanup

Remove lvms-operator (optionally remove backing block device)

make lvms_cleanup
rm -f ~/.crc/vdb

After step 8 you can return to step 2.

/test precommit-check

/test precommit-check

So looks like this change works with  crc and enables testing w/ a local-storage based on LVM, which is managed by the lvms-operator. This change itself is not sufficient to set a LVMS generated storage-class as the next default in our ctlplane deployment, but it allows to replace local-storage in favor of the new storage class.
We can then discuss w/ @viroel and other CI folks to enable testing in Prow and adopt this new deployment model.

/test install-yamls-deploy


Api8/map api

SpongeAPI | SpongeCommon
SpongeAPI of the map api. I think this is mostly complete. However lots of javadocs need work/completing.

Thinking about it now - I think there should be more information provided about MapBanners. In vanilla you can right click on a banner in the world to add it to a map. (With the api you can also add map banner decorations that are not attached to any in-world blocks). However the only access to use currently is toggleBanner(...) (or something similar to that) on MapInfo. This should probably be able to be accessed via a Key, and be a Collection or something similar to that. This allows access to see all mapbanners, whether a banner is added etc, etc. I will try to work on adding this ASAP.

Merged in https://github.com/SpongePowered/SpongeAPI/commit/081d45961756316dfc6bb8deb55cdfc04d2fdd41
Feel free to make a new PR for additional API.


Run bot from behind a proxy with auth

I am trying to run a bot from my company intranet which allows connection ONLY through proxy with authorization.
While the Sample bot seems to be taking into account the -Dhttps.proxyHost and -Dhttps.proxyPort it does not  -Dhttps.proxyUser and -Dhttps.proxyPassword
Our proxy also rewrite https certs but I have the company cert trusted in the global keystore and mvn and other Java tools work just fine.

Hi @arkadiyk , we may need to change Utils.getSymphonyClient() in order to support that.
We could use a CustomHttpClient only if JVM proxy params are specified, otherwise use the existing approach; what do you think? See more on https://github.com/symphonyoss/symphony-java-client/issues/49#issuecomment-284516753
I'll give it a try this weekend, unless you want to do some testing on your side and let us know.
Thanks for the feedback!

Thanks @maoo! Following the issue comments did let me do big step forward :smiley:
I bumped into another company restriction though. Only ports 80 and 433 are allowed to go out of the intranet. Both UAT and PROD Symphony API servers are running on 8444.

Glad I could help @arkadiyk
Re. the issue you mention, I think you have 3 options; it's up to you to decide which ones to chase and in which order:

Setup a AWS/Heroku (or any other public hosting) with an Apache/Nginx/HAproxy/Varnish reverse proxy that points to the 8444 Symphony endpoints and exposes them on default port (443) ; I'd consider this approach temporary and to use in combination of other approaches listed below
Ask Symphony support to use 443 port to expose endpoints (as we did for all our Foundation pods, dev and production)
Ask your network administrator to whitelist a port/host to connect to

Hi @arkadiyk I think we can close this one, feel free to reopen if you want to follow up the conversation.


when CCTT#1 finishes, figure out how to archive past tournament(s)

Alkemann did a tresults.html.php file, but it points to the wrong set.

I don't think there's anything wrong with tresults.html.php.
For example, here are the results for the current tournament


Standardize See also sections

In docs/c-language/ directory

Changes ## See Also to ## See also
Line ending changes

@NextTurn : Thanks for your contribution! The author, @, has been notified to review your proposed change.


Offer the project as saas?

As Twitter getting more popularity as the richest person on earth wants (or at least shows that he wants) to acquire it, it will be good idea to make this project more accessible for people.
It would be good idea to provide this project as saas.

I made this for a project and now that it's done, I don't even need it anymore. I just put it in here as an example for Tweepy maybe.
It's good to mention that Twitter's API is now more restricted and the chance to get into the developer program is very low.


fix: android build fail with rnx kit & treeShaking enabled

📜 Description

💡 Motivation and Context
When using tools like @rnx-kit from microsoft, which uses esbuild to handle bundling and also enables treeShaking, the build fails
📢 Changelog

instead of direct export of type Ex: export { KeyboardToolbarProps } we export using "type": export { type KeyboardToolbarProps }

📸 Screenshots (if appropriate):

@ashwin1014 you also need to run yarn prettier '**/*' --write --ignore-unknown to fix eslint stage

@ashwin1014 by the way - did you check? Do these changes help to fix build issues?

@ashwin1014 by the way - did you check? Do these changes help to fix build issues?

i was usually doing these changes manually from node_modules on my project. Then it used to build correctly

@ashwin1014 you also need to run yarn prettier '**/*' --write --ignore-unknown to fix eslint stage
And there is one more eslint violation - please, fix it 🙏

Will do

@ashwin1014 thank you for your contribution!


test: Integration tests for v2

See #103.
This PR includes the following tests, running against the latest many-rs and all the changes required to get them to pass (which is mostly reverting #99 and replacing every Uint8Array with Buffer again).

Can we send an already encoded request and get a response?
Can we encode a request from bytes and get a response?
Can we form a request from an object and get a response?
Can we call a method to form a request and get a response?
Can we use a shortcut method to form a request and get a response?
Can we sign a request and get a response (the rest are all anonymous)?

Test Results
(Currently skipping the KeyValue tests and concentrating on the above.)
❯ npm run test:integration

><EMAIL_ADDRESS>test:integration
> jest --testMatch '**/?(*.)+(integration).[jt]s?(x)'

 PASS  src/__tests__/base-service.integration.ts

Test Suites: 1 skipped, 1 passed, 1 of 2 total
Tests:       3 skipped, 6 passed, 9 total
Snapshots:   0 total
Time:        0.967 s, estimated 1 s
Ran all test suites.

For the record: The CBOR library we're using assumes Buffers, so replacing them with Uint8Arrays meant that things were getting coded as such in CBOR (and tagged as TypedArrays). There are other CBOR libraries that don't make this assumption (like cbor-x) that we could switch to in the future, but I didn't want to do that at the same time.

Acknowledging that there are unaddressed comments here that I'll tackle in the next PR.

KeyValue port and tests
Uncomment or remove commented code


Linux Build

NB This is work in progress. It incorporates the changes from #12 and #13 so it would make sense to review/merge them first. I've changed the project layout slightly so the Cocoapods file may need tweaking.
Changes to build on Linux:

removed use of @objc
removed lots of casting to AnyObject, in favour of just using Any
added a basic mechanism for matching dictionaries without NSObject
removed other cases of reliance on NSObject/NSValue/etc
changed project layout to match SwiftPM's default expectations
added LinuxMain.swift for tests and hooked it up to the existing tests

That looks great, massive thanks a lot for the effort!
One thing I'm concerned about is Objective-C support, which this PR is dropping in favor of Linux. I'll think about it and get back to you.
Another thing - if we decide that Linux is the way to go, then travis ci should also run tests on Linux. Do you think they support swift on Linux by now?

One thing I'm concerned about is Objective-C support, which this PR is dropping in favor of Linux. I'll think about it and get back to you.

Ah, hmm - I wasn't specifically intending to drop Obj-C support, but of course I did. Is there an existing Obj-C port of Docopt? I suppose I'd say that if people are working in a mixed environment they should use that (if it exists), and that this one should aim to be a pure-Swift one. I can see though that it's hard to please everyone :)

Another thing - if we decide that Linux is the way to go, then travis ci should also run tests on Linux. Do you think they support swift on Linux by now?

Funnily enough I'm in the process of figuring this out at the moment for one of my other packages. It looks like it works with a bit of tweaking. I'll update #14 when I've got it going.

Unfortunately, I don't know any obj-c compatible ports of docopt. On the other hand, I think it would be fair to say that version 0.6.6 is the last that supports objective-c. And obj-c compatible version will still be available to download and use.
Again, thanks a lot for the effort, I really appreciate it!

@samdeane tests on Linux are failing even tough travis reports a success.

Hmm. Looks like the final run did pass, although there are some warnings. I'll see if I can stomp them. There seems to be a subtle difference between the Mac and Linux compilers that I'm testing with, probably because the Linux one is a development snapshot.

Perhaps this project needs to be split, having the ObjC one in another repo?


feat(telemetry): track local payments

Changes proposed in this pull request

This PR moves the amount metrics collection from the accounting service back to the ILP connector, as an extra middleware.
Context

All context is provided in the linked issue
fixes #2531 #2505
Checklist

[x] Related issues: fixes #2505
[x] Tests added/updated
[ ] Documentation added
[ ] Make sure that all checks pass
[ ] Bruno collection updated

Note
if you enable telemetry on the playground containers, you should be able to see the metrics output of your transactions here

closed in favor of #2626 (which is a fresh duplicate). Will delete this source branch once that one gets merged


Allow multiple saga action types to map to the same simplesource comm…

…and topic

I'd like to question the premise that we want to be able to map multiple simple saga event sourcing actions to a single simple sourcing command.
As far as I am concerned, this action processor is just an adaptor - it allows you to plug a Simple Sourcing command into a saga. Simple Sourcing, rightly or wrongly, is already highly opiniated about how it processes commands. It's aggregate based - there is a single command processor that processes all the commands relating to an aggregate. So Simple Sourcing forces you to create polymorphic commands.
I don't see why a single action processor can't just pass through the command as is, and let simple sourcing deal with it. Having multiple action processors that map to a single simple sourcing command is promoting a confusing usage pattern.
If we don't like the way simple sourcing handles commands, and think that it should be split into multiple command processors for a single aggregate, I would prefer to address that in the Simple Sourcing project rather, and then let Simple Sagas inherit this pattern.

Further comments:
I'm happy with changes in general, there's a lot of good changes in the PR - more a principal of the usage - but that changes don't add too much complexity.
Btw I've added some test coverage in the test-coverage branch. This covers this action processor. It's not merged because it has a dependency on a snapshot version of simple sourcing. I would prefer to rebase this branch off that one.

@szoio I think there may be some confusion here. By "map to the same simplesource command topic" I mean the single topic that handles all the commands for a given aggregate.

One reason we can't pass through as-is, is we need to extract the aggregate-key (for the command/aggregate topic) from the action-value, which involves deserialization. Maybe we can do it if we had aggregate key as a field in ActionCommand, but that would make simplesagas closely tied with simplesouring...

One reason we can't pass through as-is, is we need to extract the aggregate-key (for the command/aggregate topic) from the action-value

As it was previously, there was a Function<I, K> keyMapper parameter of the command spec that forced you to provide a mapping from the intermediate type to an aggregate key, without stipulating what a saga action looks like.
But I do prefer the builder interface you have here, and if you can find a way to get rid of the intermediate type I and find a way of getting from the action type A to K and C without double deserialising, I'd be happy. Not sure if it's possible though.

Figured out a workaround to get this functionality working with the existing API.


[Bug]: "need a victron config client" if this is the very first victron flow added to node-red

If this is the very first flow added to node red, the idle battery flow gives an error on the victron-idle-battery node:
"need a victron config client"
The Victron config client is only available when there is a Victron energy flow created before. After I added a flow with one of the normal Victron Energy nodes, the config client was created and the dynamic ESS flow started to work.
I don't know if this can be fixed in the ESS "victron-idle-battery" node, or that this must be added to the prerequisites in the documentation.

Thanks for reporting. Just to make sure, you are running the latest version? IIRC I've fixed this with this commit, but I'll take a closer look at it next week. Might be that I did not include that fix in the latest release (or that it does not work all of the time).

Hi Dirkjan, I downloaded the one that was available in the latest Venus OS Large at the time I wrote the report.

For the newer flow we remove the victron-idle-battery node, so this will no longer be an issue.
There is still a bit of development time needed before that one will be released though.
So closing this issue as won't fix. Work-a-round is to deploy another Victron Node first and then use the example flow.


Add Xandikos to list of software providing metrics without a separate exporter.

Add Xandikos to list of software providing metrics without a separate exporter.

Thanks!
requests_in_progress_total is a gauge, so shouldn't end in _total.

Wow, that was not the degree of review I was expecting from this pull request. Thank you!

I was mainly checking if there was actually direct instrumentation, and noticed that in passing.


Makefile.shared: add SHARED_RCFLAGS setting

It allows to pass CPU platform flag (-F) to windres tool, so that
a dual-target mingw distro can be used to build the non-default target.

No interest in this, so closing and keeping it local.


Added DeferPermissions option

This is needed for redox (source) in order to build an image with MacOS. We are upgrading from the fuse library and would like to use this option.

Hmm. I'm not sure about adding this, as it appears to be a MacFUSE only feature. Have you tried using MountOption::CUSTOM("defer_permissions")?

Ahh nice, I didn't realize MountOption was an option (pun not intended). I'll use that instead, thanks.


Feature/update pacakges

include simple client server example from unity transport and make it work with webgl
add UnityWebGLMicrophone as a package

Looks amazing


fixed the issue throws when using the precedingPaths and updated to a…

fixed the issue throws when using the precedingPaths and updated to accpet use-annotation as the port name

Hello @urupaud
Please change version in Chart.yaml file to 0.7.4

@urupaud thanks for your contribution!


[New Dataset] 请问您在coco数据集上进行过实验么？

Model/Dataset/Scheduler description

在coco数据集上进行实验，报错这个，是因为数据集问题么
Open source status

[ ] The model implementation is available
[ ] The model weights are available.

Provide useful links for the implementation
No response

No, all the experiments are based on SODA benchmark. I'm not sure whether dataset setups trigger this error based on current information

Model/Dataset/Scheduler description
 在coco数据集上进行实验，报错这个，是因为数据集问题么
Open source status
* [ ]  The model implementation is available

* [ ]  The model weights are available.

Provide useful links for the implementation
No response

Hello, have you tackled this problem?


gossip: replace iota_packet_queue implementation with liblfds queue

Swapped out utlist with libfds queue
Test Plan:
Nonexistant tests pass

Just saw a segv with this, investigating.

Just to document the segv:
queue elements need to be reused, so we need to add a freelist here that keeps track of allocated but currently unused elements.


QnAMaker trace can't be shown in Bot Emulator.

Version
4.11.0
Describe the bug
Using Python bot with QnAMaker service, the QnAMaker trace can't be shown in Bot Emulator.
However using DotNetCore bot with QnAMaker service, the QnAMaker trace can be shown in Bot Emulator.
To Reproduce
When using the Python QnAMaker sample bot, the QnAMaker trace encountered the error in Bot Emulator.

Expected behavior
The QnAMaker trace can be shown:

@axelsrz I did a little bit of digging by running sample 11.qnamaker for C#, JS, and Python bots. All of which resulted in the trace info not being shown in Emulator

Additionally, it appears that QnAMaker does seem to actually have the correct code to send a trace activity when QnAMaker.get_answers(...) method is called:
https://github.com/microsoft/botbuilder-python/blob/13a9b096424e355bb69dca730c75965f8064eeb9/libraries/botbuilder-ai/botbuilder/ai/qna/utils/generate_answer_utils.py#L204
Maybe there's broken code within the SDK with the TurnContext.send_activity code or I believe the issue is actually within the Emulator instead. I'll keep hunting into LUIS to compare.

Things to note
Looking at the error message you see when you click on QnA Maker Trace in Emulator:
"Unable to find a QnA Maker service with Knowledge Base ID 7b13xxxx-xxxx-xxxx-xxxx-xxxxxxxx511e. Please add a QnA Maker service to your bot."
Seems like a strange error that may be a remnant artifact of our once-used .bot files? Because are we not adding QnAMaker to our bot if it's in our config.py? If I had to guess, never having looked at Emulator code before, so take what I say with a grain of salt, if we're doing "everything right" on the SDK end, the issue might be in the emulator, perhaps relying on some .bot-file-based logic? Iunno.

Additionally, forgot to add, trying to repro the user's steps, I tried going to Emulator > + > Add QnA Maker as they have done, it prompts you to sign into Azure account, then it breaks

Ok. Confirmed that LUIS is sending traces the same way as is done in QnA Maker packages:
https://github.com/microsoft/botbuilder-python/blob/c85bafaacda5aa44d61fafa39927db74047fc060/libraries/botbuilder-ai/botbuilder/ai/luis/luis_recognizer_v3.py#L286
The SDK creates a trace activity, then uses TurnContext.send_activity to send the trace (in both LUIS and QnA). Despite this, LUIS traces are successfully viewable in Emulator, whereas QnA traces are not. Transferring this to Emulator repo


Migrate docgen TOC merging to dictionaries

This PR moves TOC merging over to using dictionaries, so as to guarantee that UIDs each have a unique mapping to TOC items.

I assume you have already used this version to build the docs for our last release?

That's correct, the current docs were generated using the code in this PR.

Thanks for the review, @bettinaheim!


Fixed the issue with the variant of sort button.

Hey @zxhmike, Awesome work buddy.
In mui5, by default, the button is taking the primary colour rather than no colour like mui4.
Due to that, the sort button in the table is using the primary variant rather than the default variant. So fixed the issue with the variant of the button.
Present:

Expected:

Hey @zxhmike, would be happy to do that!

Hey @zxhmike,
Apart from these issues, I was not able to find any other issues for the time being. I think this PR is good to go. Will push a commit, if I find something!


ddt dependence missing in AMPI's makefile

Original issue: https://charm.cs.illinois.edu/redmine/issues/1791

ddt was moved into AMPI, but there is no dependence on ddt or its header, so if you update DDT and re-make AMPI the build system ignores your changes: ~~https://charm.cs.illinois.edu/gerrit/#/c/3468/~~ https://github.com/UIUC-PPL/charm/commit/d89c19a946162092483b9830a92ab777ae57e638

Original date: 2018-02-01 20:50:41

This seems to work for me:
$ cd charm/tmp/libs/ck-libs/ampi
$ make
AMPI built successfully
AMPIF built successfully
$ touch ddt.C
$ make
/Users/mdiener/Work/charm/bin/charmc  -c ampi.C
/Users/mdiener/Work/charm/bin/charmc  -c ampif.C
[...]

Same for ddt.h.
ddt.o and ddt.h should be dependencies through the HEADDEP and OBJS Makefile variables.

Original date: 2018-02-01 20:58:23

... except that ddt.o does not get rebuilt when ddt.h changes.
Patch here: ~~https://charm.cs.illinois.edu/gerrit/#/c/3609/~~ https://github.com/UIUC-PPL/charm/commit/aac58f65d3e7cc85d7a2f05341bd08703860bbf9


Don't force a period at end of LCSH subjects.

This is to close #39 by removing the code that adds a period at the end of LCSH terms when there is not one there already. This is ready for review @madhulika95b @somexpert

Should we add this to the changelog?

Yes @somexpert , I will add it to the changelog.

LGTM :thumbsup:

Looks Good 👍


Docs monitoring update

Addresses issue #43. Updates docs to reflect changes in GCP UI now that Stackdriver is now GCP Monitoring.

Also just noticed the install script links to "Stackdriver Dashboard" (app.google.stackdriver.com/accounts/create) at the end, but this page no longer contains any information. I will replace with the GCP > Monitoring > Overview page.

Latest commit removes stackdriver dashboard from the install script display message and changes pretty much every instance of "Stackdriver" to "Operations," happy to revert if it's too much.


Implement an initial rotation

Hello !
It would be great if we could set a rotation to the icon.
For example, I would like to use the triangle icon to point downward. Instead of requesting a new icon for each angle desired, it could be easier to just pass a double for degrees or radians to the PhosphorIcon class.

I think to achieve what you want it would be simpler to wrap an icon widget with a transform. Here is an example widget that would allow you to set an angle in radians, flip horizontally and flip vertically
class IconX extends StatelessWidget {
  const IconX(
    this.icon, {
    this.flipHorizontal = false,
    this.flipVertical = false,
    this.angle,
    super.key,
  });

  final IconData icon;

  /// Flip icon from left to right
  final bool flipHorizontal;

  /// Flip icon from top to bottom
  final bool flipVertical;

  /// Rotate icon some amount
  final double? angle;

  @override
  Widget build(BuildContext context) {
    final scaledIcon = Transform.scale(
      scaleX: flipHorizontal ? -1 : 1,
      scaleY: flipVertical ? -1 : 1,
      child: Icon(icon),
    );

    if (angle == null) return scaledIcon;

    return Transform.rotate(
      angle: angle!,
      child: scaledIcon,
    );
  }
}

Agree with @k-ane
It is not responsibility of the icon pack to transform itself, is better to let the parent widget do that.


cmake: boards: Load BOARD_ROOT and BOARD_DIR from cache

This resolves an issue when using sysbuild and specifying a custom board directory on the command line whereby images would not load the custom board and fail to configure.
Fixes #53780

Codecov Report

Merging #53816 (3d6f3a5) into main (7b5780e) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 3d6f3a5 differs from pull request most recent head 6df5d48. Consider uploading reports for the commit 6df5d48 to get more accurate results

@@           Coverage Diff           @@
##             main   #53816   +/-   ##
=======================================
  Coverage   45.76%   45.76%
=======================================
  Files         544      544
  Lines       68068    68068
  Branches    16647    16647
=======================================
  Hits        31148    31148
  Misses      31368    31368
  Partials     5552     5552

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5780e...6df5d48. Read the comment docs.

It is uses the build directory as the source, so would need to be "../test", but that does seem like an issue

It needs sysbuild specific handling as the original PR had, added it back

It needs sysbuild specific handling as the original PR had, added it back

Still not working in all cases.
Just adding stuff back that I already commented should not be done this way isn't going to help.
Please take the time needed to understand zephyr_file(APPLICATION_ROOT BOARD_ROOT) code which works on a local scoped variable, but compares relative path entries to the CMake cache and updates the local scope var accordingly if the entry exists in the cache, whereas the zephyr_get() will return the CMake variable setting from a cache before any local scoped var.
That was why I specifically pointed out that the zephyr_get() call was colliding with the zephyr_file(APPLICATION_ROOT BOARD_ROOT) functionality.
Hint: using zephyr_get() after zephyr_file() in this case is a bad idea.
Also remember to test the code with normal build (non-sysbuild), with sysbuild, extra board root inside a sample, extra board root outside a sample, builds invoked inside a sample source / subdir in there, builds invoked from outside sample source folder like workspace root, etc.

also pay attention to the fact that BOARD_ROOT is a list of root which may be populated from various places.
Initial value is comming from users as a -DBOARD_ROOT, but a sample may add extra local roots before find_package(), like this:
list(APPEND BOARD_ROOT <extra-root>)
find_package(Zephyr)

or extra roots may be specified in `zephyr/module.
Whereas zephyr_get() only returns the value from a single scope (sysbuild, cache, env, local).
Please consider if it would make sense to be able to have zephyr_get() to return a list of values from all scopes in same order of precedence.

Tested working without sysbuild, with sysbuild, having paths added on command line and in project cmake files, external boards located in 2 directories


Anders review

Moving validation to the creation of the filter.
Introducing a constants.py for a place to keep all hardcoded constants coming from prod wrt to DMS. Can probably be named better and have it another place.

Missing that DMS filters can be imported.


Readme missing information about JavaFX dependency

When I try to build the sources, I get an error that JavaFX dependencies are missing.
Looks like they are not part of the regular dependency declarations of gradle.

I get a localized message:
Fehler: Zum Ausführen dieser Anwendung benötigte JavaFX-Runtime-Komponenten fehlen


HADOOP-18505. Handled ArrayIndexOutOfBoundsException in TestCoderBase

Description of PR
JIRA: HADOOP-18505
How was this patch tested?
Added a new value set and consequently modified the existing unit tests testValidate and testValidateWithBadDecoding of test class TestDecodingValidator to verify the code change.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 55s

trunk passed

+1 :green_heart:
compile
25m  4s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
21m 26s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 37s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 44s

trunk passed

+1 :green_heart:
shadedclient
25m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
24m 13s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
24m 13s

the patch passed

+1 :green_heart:
compile
21m 38s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 38s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 37 unchanged - 2 fixed = 39 total (was 39)

+1 :green_heart:
mvnsite
1m 36s

the patch passed

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 42s

the patch passed

+1 :green_heart:
shadedclient
25m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m  7s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

218m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5065/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5065

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5294dfb72c42 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 138553bf2054628038752b683fb671574936bbc8

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5065/1/testReport/

Max. process+thread count
2287 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5065/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 54s

trunk passed

+1 :green_heart:
compile
24m 54s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
21m 28s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 44s

trunk passed

+1 :green_heart:
shadedclient
24m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  5s

the patch passed

+1 :green_heart:
compile
24m 27s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
24m 27s

the patch passed

+1 :green_heart:
compile
21m 35s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 37 unchanged - 2 fixed = 39 total (was 39)

+1 :green_heart:
mvnsite
1m 33s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 39s

the patch passed

+1 :green_heart:
shadedclient
25m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m  3s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

218m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5065/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5065

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4a85c28f1773 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / dce9e4d85c5eed8794f38e37fc456b8becc0aee7

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5065/3/testReport/

Max. process+thread count
1451 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5065/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Make "range vector" and "matrix" terminology consistent

What did you do?
make an error in a query where a function expects a range vector, but you just give it an instant vector
What did you expect to see?
An error that refers to requiring a range vector
What did you see instead? Under which circumstances?
An error that refers to a "matrix"
The documentation doesn't really ever refer to Prometheus supporting a "matrix" type, but the errors do. Equally, some errors state that a "vector" has been required where a "matrix" is expected, yet the docs refer to instant vectors and range vectors (so both are vectors, by the wording in the docs).
It would be nice if the terminology was consistent between the two.

I can look at updating some error messages. I think replacing "vector" with "instant vector", and "matrix" with "range vector", would be OK?

That touches ancient Prometheus history, so I'd say @juliusv should comment on it.

Renaming as you suggest makes sense. The older terminology is a holdover from Borgmon.

We also call it matrix / vector in the API though: https://prometheus.io/docs/querying/api/#expression-query-result-formats
So the inconsistency there would have to remain unfortunately.

Initial attempt in #2197
I don't think the type names in  common/model  can realistically be changed, so this attempt to translate it purely for the purposes of messages reported to the users.
I could use  a type, with a String() method, but that seemed like overkill
Some tests still failing, just wanted to see if this was sane.

#2197 was merged


Center mode

Slider with 8 slides in center mode
But central slider is shifted to 49px left - this happens only on Chrome, in FF all fine
The same after move event.
It's not maybe a Slick bug, but maybe someone know why it happens?

It was a bug with angular-slick module, if there is no specified centerPading it sets it to 50px


Intranet fonts not loading - Multiple CORS header

We have started getting errors when loading the fonts from https://templates.service.gc.ca, this does not happen when loading from www.canada.ca.
error in console showing:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://templates.service.gc.ca/app/cls/WET/gcintranet/v4_0_45/wet-boew/fonts/glyphicons-halflings-regular.woff2. (Reason: Multiple CORS header ‘Access-Control-Allow-Origin’ not allowed).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://templates.service.gc.ca/app/cls/WET/gcintranet/v4_0_45/wet-boew/fonts/glyphicons-halflings-regular.woff. (Reason: Multiple CORS header ‘Access-Control-Allow-Origin’ not allowed).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://templates.service.gc.ca/app/cls/WET/gcintranet/v4_0_45/wet-boew/fonts/glyphicons-halflings-regular.ttf. (Reason: Multiple CORS header ‘Access-Control-Allow-Origin’ not allowed).
This results in funny looking characters showing up instead of the font

Hello, can you try again? it should be resolved now.

Salut,
Seems to be working from localhost and Sade servers but not in production (ex: from srv213.prv).
Thank you,
Sonya
From: Ahmad @.>
Sent: September 8, 2023 9:48 AM
To: wet-boew/cdts-sgdc @.>
Cc: Chenard, Sonya S [NC] @.>; Author @.>
Subject: Re: [wet-boew/cdts-sgdc] Intranet fonts not loading - Multiple CORS header (Issue #945)
Hello, can you try again? it should be resolved now.

Reply to this email directly, view it on GitHubhttps://github.com/wet-boew/cdts-sgdc/issues/945#issuecomment-1711703701, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWNTVMYT45OUBJXMXBS6WJTXZMOYDANCNFSM6AAAAAA4QNB4SA.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

any idea when this will be fixed for Prod?

The problem was happening because of a fix that was applied but it was reverted this morning. The issue should not be present anymore. Can you try hard refreshing your page on prod?

Sorry, my bad. I Cleared the cache, the revert fixed the problem.
Thank you!

Happy to hear! thank you


federation API not in client-go

 Issue by justinsb
Sunday Feb 12, 2017 at 20:27 GMT
Originally opened as https://github.com/kubernetes/kubernetes/issues/41302

The federation objects are not currently in client-go.  I believe this makes it hard/impossible to use federation with client-go.  The challenges I hit:

you would have to refer to the main kubernetes/kuberentes repo again for the federation objects
mixing and matching the federation objects from kubernetes/kubernetes is tricky, because for example ClusterSpec has a SecretRef field which is of type k8s.io/kubernetes/pkg/api/v1.LocalObjectReference, but in client-go view that is k8s.io/client-go/pkg/api/v1... which is different.

I think we need to include the federation objects into client-go.

 Comment by liggitt
Monday Feb 13, 2017 at 04:21 GMT

cc @kubernetes/sig-api-machinery-misc @kubernetes/sig-federation-feature-requests

 Comment by sttts
Monday Feb 13, 2017 at 07:37 GMT

We could blindly copy federation types into client-go as well. But I would very much prefer to start thinking about making client-go more composable to avoid that it becomes our new monolith repo. /cc @deads2k

 Comment by deads2k
Monday Feb 13, 2017 at 13:17 GMT

We could blindly copy federation types into client-go as well. But I would very much prefer to start thinking about making client-go more composable to avoid that it becomes our new monolith repo. /cc @deads2k

I agree.  We need to think about how different client-go APIs interact and build on top of each other instead of simply producing a copy/paste which can never be extended.  As we get more aggregated API servers like service-catalog and (hopefully) podinjectionpolicy, this becomes even more obvious.
@lavalamp @caesarxuchao

 Comment by lavalamp
Monday Feb 13, 2017 at 23:23 GMT

client-go should not be a grab bag for clients for all APIs. The long term plan here is to have a two-layer client structure.

client-core contains things like RESTClient, discovery client, dynamic client, transport, informers, etc.
client-go contains the API types and generated code

Other projects (like federation) can host their own version of the latter.
Additionally I'd like to get to a point where we can generate a client specifically for a user, given their cluster's OpenAPI spec.

 Comment by caesarxuchao
Tuesday Feb 14, 2017 at 04:22 GMT

I agree with @lavalamp's vision.

 Comment by k8s-merge-robot
Wednesday May 31, 2017 at 22:54 GMT

@justinsb There are no sig labels on this issue. Please add a sig label by:(1) mentioning a sig: @kubernetes/sig-<team-name>-misc(2) specifying the label manually: /sig <label>Note: method (1) will trigger a notification to the team. You can find the team list here.

 Comment by fejta-bot
Monday Jan 08, 2018 at 18:26 GMT

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Prevent issues from auto-closing with an /lifecycle frozen comment.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

cc @justinsb

/kind technical-debt

@shashidharatd I don't think this is technical dept, at least not with the issue description above. Federation types will probably never be in client-go. Merely, federation has to provide a client-go library (compare https://github.com/openshift/client-go).

Agree @sttts, the heading is not apt now. We should have client-go for federation which extends the k8s.io/client-go as opined above. Thanks for the above tip, i will study it.


Auto completion for Bicep registry (when an alias is configured) is missing required-properties

Bicep version
Bicep CLI version 0.13.1 (e3ac80d678)
Describe the bug
Auto completion is missing required-properties.  This happens when an alias is configured for the Bicep registry.

Expected:

To Reproduce
Steps to reproduce the behavior:
Additional context
Add any other context about the problem here.

SnippetsProvider.GetModuleBodyCompletionSnippets():
    public IEnumerable<Snippet> GetModuleBodyCompletionSnippets(TypeSymbol typeSymbol)
    {
        yield return GetEmptySnippet();

        if (typeSymbol is ModuleType moduleType && moduleType.Body is ObjectType objectType)

First time through, typeSymbol is an ErrorType.
Once the module is restored asynchronously, it becomes a ModuleType.

Not clear-cut solution that completely solves it.  Work-around is to try intellisense again once the module has been restored.

sw/exp-completion-module-not-restored


💡Layout Feature 🚀

Description
Add basics
Video or Screenshots
Checklist

[x] Story requirement were met
[ ] All new necessary Unit tests were CREATED
[ ] All required unit tests are PASSING
[ ] The proposed functionality was tested manually locally, and it's working fine.
[ ] Unnecessary console.logs AND/OR comments were removed

add layout


French transaltion files

Hi,
I don't use UI as i've already configured my collect but I like your component so I wanted to bring my little stone to the building.

Great! Thanks!


Close websocket connection with custom code and reason text

Right now both server and client connection send CloseWebSocketFrame with default status code and empty reason text when the appropriate stream is drained. I think we can add websocket-close! (analog with websocket-ping) helper to take care of the closing handshake and cleanup stream & connection after that. So it will look like
(def conn <...>)
;; returns deferred that yields when connection is closed
(http/websocket-close! conn 4009 "Idle timeout, sorry (send more pings next time)")

What does the 4009 represent here?

Application-level status code (range 4000-4999), just randomly picked up one. Here's the full list of codes from rfc6455

I would say we need all 3 options:
(websocket-close! conn)
(websocket-close! conn status-code)
(websocket-close! conn status-code reason)

Defaults are well defined, so it's clear what to use instead of missing params.

Okay, works for me.

@ztellman This functionality clashes with https://github.com/ztellman/aleph/pull/422 pretty heavily, so I'll make a new PR after that one is merged, so I can work around merge issue beforehand.

Covered by #481.


New monsters: the tortle package

Hello,
I'm not sure if you want to add these, but in case you do here are the three new monsters from the WOTC web supplement: The Tortle Package.
https://docs.google.com/spreadsheets/d/1fIF_7onOYrltTvBoYfGjU635X2VTGJsH_19etOO8EYE
(package is here: http://www.dmsguild.com/product/221716/Tortle-Package-5e)
-Daedalline.

I've requested access to the document. I only need view permission. (there are two different ways to share the sheets; it looks like you've shared it correctly for integrating with KFC, but that doesn't actually make it viewable directly by other people)
Also not entirely sure what to do with this... I have no problem adding it, but it feels like it's in a weird spot. Not third party, but it also... doesn't really feel official. I dunno. I'll figure out something.

Ok, it's live. I forgot that "official web supplement" was one of the categories. >_>

I'm fine if you don't want to include it. It is a bit of an oddball. It was mostly just an experiment to learn how to import custom monster spreadsheets.

You did perfectly. :)
Closing this out since it's live.


Wire up miscellaneous data displays

[ ] Avg. Response Time on Summary page
[x] Error Rate  on Summary page
[ ] Uptime  on Summary page
[x] Cache Size on Settings page
[x] Dashboards count on Settings page

@spmcbride1201 I added Uptime here because I realized that jvm/uptime is current returning some fixed value that doesn't appear to be actual uptime milliseconds.
Replacing the readout value with this: Date.now() - getLatestAttribute(metrics, "jvm/start_time") gave me a live uptime in milliseconds, and I think using pretty-ms instead of ms could give us a better visual result.

Okay, I'm actively working this, so I'll take a look.

I think you might be psyching yourself out with the mock. It looks like uptime is the time in milliseconds since the app started.

Yeah, I think you're right. For the record, this is what I was seeing.
uptimegraph.mov.zip
I do think we could stand to show the uptime in greater fidelity, at least down to seconds.

I feel like it can get really long and verbose if we just keep it a string and try to make it human readable. Lets roll it into a different issue since there's some different UX things to thing about with it (like do we need a new UI component for showing elapsed time).

Sounds sensible. I'll add a separate issue.


Certificate signing with Google Cloud KMS

the first patch of the two patchsets of this PR was submitted as a separate PR (https://github.com/lowRISC/opentitan/pull/23066)  and will be updated here if the review of 23066 calls for modifications.
The second patch implements support of two modes of certificate signing, either using a local private key (test mode), or a key stored in Google Cloud KMS (ckms). Signing mode is picked based on which key parameter is passed to the signing utility.
Testing of both modes is supported, by default local key mode is used, adding --define  cert_signer=cloud_kms to test invocation will trigger testing the Cloud KMS based signign.

made clap related changes, ptal

LGTM, thanks @vbendeb . As soon as this passes CI I will merge.


chore: render docs

The docs seem out of date after running pnpm docs:generate:api on main. I'm not sure why these tables are deleted though.

Closing, running foundryup fixed it because I had an out of date Forge version


Add sample for client filtering

This adds a paragraph explaining how to do filtering and sorting with amp-list and amp-bind.

@sebastianbenz this can be reviewed

@sebastianbenz I updated the sample.
Where this should live according to you? Advanced or Dynamic AMP section?

I'd say Dynamic AMP.

@sebastianbenz PTAL

@sebastianbenz ping

Can you fix the merge conflicts?

(and sorry for forgetting to review)

Done!

Thanks, updated those!

Right, update it


Algorithm Figure Width be Entire Page

If I use the example:
#figure(
  kind: "algorithm",
  supplement: [Algorithm],

  pseudocode-list(booktabs: true, numbered-title: [My cool algorithm])[
    + do something
    + do something else
    + *while* still something to do
      + do even more
      + *if* not done yet *then*
        + wait a bit
        + resume working
      + *else*
        + go home
      + *end*
    + *end*
  ]
) <cool>

Then is there some way to make the algorithm:

left aligned
have the horizontal lines span the entire page? I think it looked a little weird in my setting to have some empty space to the right of the algorithm.

However, I really love the idea of the package so I'd love to get this resolved to continue using it! :)

The left alignment you can probably do yourself by wrapping the whole algorithm in align.
For the lines spanning the whole width, I guess the rightmost column in the grid used for the pseudocode should get the width 1fr 🤔 Maybe someone would like to try this out.


Last login date?

This is autogenerated. Please review and update as needed.
When pulling user listings from a subscription, there seems to be no easy way to verify a user's last login date. Other than creation date and RefreshTokensValidFromDateTime, is there a way to pull any other time-based information on user listings? Having the date of last login would be very helpful for my team's period user access reviews.
Command Name
az ad user list
Errors:
To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az ad user list -o {}

Expected Behavior
Environment Summary
Darwin-18.7.0-x86_64-i386-64bit
Python 3.7.3
Shell: bash

azure-cli 2.0.64 *

Additional Context

Thank you for the feedback. Azure CLI currently internally uses AD Graph to list users: https://docs.microsoft.com/en-us/previous-versions/azure/ad/graph/api/users-operations
The latest MS Graph doesn't support this either: https://docs.microsoft.com/en-us/graph/api/user-list
You may create a feedback at https://feedback.azure.com/forums/169401-azure-active-directory


Show files with reduced coverage is not working

Describe a bug
When I have setup jest with babel and code all in one directory i get this report:

You see here the Show files with reduced coverage. When I move the config files one dir up make it more clean what is my code and what is the config files I get this report:

Expected behavior
I would like to keep the option to show the files seperately
Details

Action version:
run from github action

          name: 'coverage location-sf-ods-connector'
          on:
              pull_request:
                  branches:
                      - master
                      - main
          permissions: write-all

          jobs:
              coverage:
                  runs-on: ubuntu-latest
                  steps:
                      - uses: actions/checkout@v3
                      - uses: ArtiomTr/jest-coverage-report-action@v2
                        with:
                          working-directory: bms/location-sf-ods-connector/lambda

</details>

Screenshots

see above

Additional context
Maybe it somehow can not compare to get the reduced coverage list. Or I do not understand how it can conclude it is reduced (what against what)

As I work longer with it it seems that the list only appears when a file is less tested than before. So reduced in the time sense and not less than wanted.
Then I would like to change my question to is it possible so show a list of all files with their coverage or all files lower than 100%?
thanks


Add meeting minutes

This PR adds minutes from our June 9th TSC meeting.

Typically, minutes announce the date and time of the next meeting!  Just following "Roberts' Rules of Order"!


Swift Package Manager Support

Hello 👋 do you plan to support the Swift Package Manager?

Hello 👋, thanks for your request, and yes we are planning this, but that is not on top of our backlog for now.
We are planning to switch CocoaPods to build from source (vs binaries) in the near future as you can see with 4.0.0-alpha1
Swift Package Manager might come along.
Also we are open to contributions... 😉

Hello,
Do you have any news about the SPM support ? You are the only libraries which is not supporting SPM in our project at the moment.
Best regards,
Denis

Hi,
We are minimising usage of Cocoapods and switching to SPM.
Any news about SPM or at least Carthage support?
Thank you in advance,
Vlad.

Maybe this can unblock some of you, I was able to add Criteo as a dependency of my package by using a binaryTarget:
    targets: [         .target(             name: "MyTarget",             dependencies: [                 "CriteoPublisherSdk",             ],             path: "ios/Sources",             exclude: [],             resources: [ ]         ),         .binaryTarget(             name: "CriteoPublisherSdk",             url: "https://github.com/criteo/ios-publisher-sdk/releases/download/4.7.0/CriteoPublisherSdk.Release.zip",             checksum: "55031718f5a617374aba6c91fad1e0956016a8ab68dc9f28252a643a6f5a4936"         ) ]

bump @vguerci

https://github.com/criteo/ios-publisher-sdk/releases/download/4.7.0/CriteoPublisherSdk.Release.zip

Unfortunately, not all header files are available when different packages try to integrate it with this method. So an official SPM support become quite necessary.
CocoaPods is no in maintenance mode - so official support from the author is important IMO.
I will try to map a Package.swift file after the holidays but since I have no clue how the dependencies are intertwined it may take longer.


LMS_Open() doesn't fail when opening default device and no device present

When trying to open default (first) device by giving NULL as device info parameter and no device is present, LMS_Open() doesn't fail.
A subsequent call to LMS_GetDeviceInfo() on the opened device returns the string "0", but i don't think this is meaningful as long as LMS_Init() hasn't succeeded.
Of course LMS_Init() fails on the opened device with the error "no connection object"
The correct behavior should probably be that LMS_Open(&device, NULL, NULL) fails if no device present.
Tested with the version 16.12 from Debian 9 as well as self-compiled version 17.12 and current git HEAD.

Has been fixed in commit c02f4358b6eb3a83f333e8951419f34b18667dde so I'll close this bug and close my PR #161 too


Entity ticking crash

i was playing in my server when i dropped an item into a normal hopper minecart, this caused the server to crash repeatedly until i killed the hopper minecart using the console, is there a way to fix this bug because i really need this to work

crash-2024-06-17_07.33.27-server.txt


[Feature][Kafka-connector] Proposal to Add Kafka Protobuf Data Parsing Support

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Protobuf (Protocol Buffers) is a widely adopted method for serializing structured data, especially in distributed systems. It offers several advantages, including smaller payload sizes and faster parsing compared to JSON or XML. Adding support for Kafka to parse protobuf format data in Apache SeaTunnel would enable more efficient data processing and broaden the platform's applicability in modern data engineering workflows.
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

+1

Please assign it to me, I can complete it @Hisoka-X


2 Sorting Algorithms Added in Python

PR Checklist:

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is on refer on the language README.md file
[x] My addition does not have a spelling problem
[x] My submission has a proper and user-friendly description of the algorithm
[x] My submission has the time complexity of the algorithm

What kind of change does this PR introduce? (check at least one)

[ ] My submission has sample input-output of the program (NOT FOR PYTHON)
[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

Other information:

I used it, Its working well


[feat] Implement OP_0NOTEQUAL opcode

Implement the OP_0NOTEQUAL opcode using the opcode0NotEqual reference implementation from btcd
References
Guide on how to add an opcode in shinigami

@b-j-roberts i can work on this

Hi @b-j-roberts  returning contributor. OP-ONOTEQUAL will push to the stack using push.int() if value is not equal to zero. Would love to tackle this.

@ooochoche Welcome to the project, let me know if you have questions about this. I'll assign you now.
@Shoetan I see you weren't able to claim a few issues, I'll add you to my shortlist when new issues are ready.  Thank you!


WP-5831 Prevent page zoom

Description
Pinch-zooming in and out on the graph was leading to the whole page zooming in and out. The goal was to prevent such behavior.
It is usually done by intercepting the 'zoom' event and preventing its default behavior. The 'zoom' event for pinch-zoom is the 'wheel' event with truthy ctrlKey property.
Our version of react-diagrams already has the onWheel handler with some custom logic. Preventing the default behavior from inside of this handler wasn't working - it is considered a passive event listener by Chrome. Some details on this can be found here
I haven't found any react-specific ways to make an event handler active. As a workaround, I have added an active vanilla js event listener on the graph element.
I have also checked how React Flow handling this situation. This library prevents pages from zooming in and out too and seems to be using the same approach with native preventDefault.
JIRA Ticket
WP-5831

I think you need to run yarn build:ts:prod and then commit the changes in the dist folder as well (I know not ideal), see ui/README.md. Other than that looks good.

Ah, I see. Thanks, I'll correct


REST API usage for testing

Hello,
I got access to the test server but I can't find any documentation about how to use the REST API for testing.
I tried sending a FHIR bundle as the POST request body to the given URL, but I get an HTTP 500 error.
POST /index.php/fhir/###/lab/R4/bundle?api_key=### HTTP/1.1
Accept-Encoding: gzip,deflate
Content-Type: application/fhir+json
Content-Length: 110611
Host: fhir-testserver.be
Connection: Keep-Alive
User-Agent: Apache-HttpClient/4.5.5 (Java/16.0.1)

{
  "resourceType" : "Bundle",
  ......
}

Can you tell me what I'm doing wrong or point me to more documentation about this API?
Thanks

@sebwautelet ,
We are working on some more detailed information (@jmp-ehealth), but I will share some requests that I made using Postman. The API is accessible, other stakeholders have been using it (see: https://github.com/hl7-be/lab/issues/198)

If you still have problems, you can send me your unobfuscated URL  to<EMAIL_ADDRESS>and I will check your data.

Thanks @bdc-ehealth , I managed to make it work with Postman. My first try was with SoapUI, not sure why it was not working as the headers look the same.


problem with developing.md

arya gupta@LAPTOP-DH8F7VDN MINGW64 ~
$ git clone https://github.com/YOUR_USERNAME/shogun
Cloning into 'shogun'...
remote: Repository not found.
fatal: repository 'https://github.com/YOUR_USERNAME/shogun/' not found

I was following the steps according to shogun git development cycle but i am getting this output .can anyone help me with this

Hi @arya2910, you should first fork the shogun repo, then substitute arya2910 for YOUR_USERNAME.

okay .i did it after this what??


Tweaks for first-time dev setup

Ticket
N/A
Description
When first setting up the project on a developer machine, I'd like to suggest a couple tweaks:

Add a .tool-versions file so that developers can manage node version per-project via https://asdf-vm.com/
Fix seeding, so that yarn db:seed command can be re-run: users table must be dropped before tenants table can be dropped-- due to foreign key constraint.

Screenshots / Demo Video
Testing
Checklist

[ ] Provided ticket and description
[ ] Your PR title contains the ISSUE ticket number e.g "86: ..."
[ ] Provided screenshots/demo
[ ] Provided testing information
[ ] Provided adequate test coverage for all new code
[ ] Added PR reviewers
[ ] Ensure at least 1 review before merging

I look forward to benefiting from some first time dev setup improvements! 👍
Please don't let me insert myself as a blocker, here's my TL;DR so you don't have to dig through https://github.com/usdigitalresponse/arpa-reporter/pull/366#issuecomment-1217415409:
My personal preference would be to set the node version only via "engines" in package.json, and .gitignore files like .tool-versions and .node-version.
This is nice because in addition to being respected by render deployments, yarn will actually prevent a developer from running yarn install with an incompatible version of node, whereas other approaches may be completely ignored if a developer is using an incompatible node version manager (or no version manager).
Specifying the version in only one place reduces the risk of versions getting out of sync.  I also just think it's good etiquette to avoid getting too opinionated about non-critical developer tooling.  :)

Thanks for the feedback @mattbroussard and @ajhyndman.
I verified asdf can read the existing .nvmrc and .node-version files once I set the legacy flag in ~/.asdfrc, so there's no need for the .tool-versions file.
Since the following PR request got merged in a couple days ago, the reseed (fk constraint) issue also got fixed: https://github.com/usdigitalresponse/usdr-gost/pull/251
Hence, closing this PR.


Use the test container in tests

Q
A

Bug fix?
no

New feature?
no

Tickets
-

License
MIT

@nicolas-grekas There are some errors, could you have a test at them? Thanks

Thank you @nicolas-grekas.


Fix memory issue (leak) for ngfDrop directive

Remove the event listeners added to the directive's element on scope $destroy.

@danialfarid Please take a look.

Yes please merge this pull request, I had the issue as well and this fixed it.

great, just found this leak, please merge!

yes, this leak should be fixed, please merge


Add a constant prefix object store wrapper

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In certain situations is useful or convenient to have a constant prefix applied to all paths handled by an ObjectStore. Examples might be to simplify paths handling or to avoid illegal operations - e.g. listing the root when only permissions are available on some directory in an ADLS Gen2 storage account.
The C++ implementation provides an equivalent concept via the SubTreeFilesSytem.
Describe the solution you'd like
A an ObjectStore implementation that applies / strips a prefix to all paths exposed in the ObjectStore apis.
Describe alternatives you've considered
Letting consumers handle this.
Additional context

label_issue.py automatically added labels {'object-store'} from #3329


Add some linters specifically for the Gemfile

It'd be awesome if there were some linters specifically geared towards the Gemfile.
There's probably a bunch of ones that could be made, but here's some ideas off the top of my head:

[ ] Make sure a gem group isn't defined twice
[ ] Enforce alphabetization of "groups" of gems (lines that are next to each other)
[ ] Make sure a gem is only listed once (although this is actually built into bundler)
[ ] Specify requirements for gem versions.

Require a version for every gem
Require versions to only be at the "major" level
Require no versions to be specified, unless it has a comment with it (related blog post)

[ ] require the ruby version to be specified
[ ] require source 'http://rubygems.org' at the top of the file
[ ] A check specifically for this vulnerability

I think this is a great idea. Some of those checks will need configurability, of course. (For instance, where I work apps are required to pull from the local gem server, not rubygems.)
A check specifically for this vulnerability would be cool, too.

Interesting. I hadn't heard of that vulnerability. I think it'd be worthwhile to have a check for it. I'll add it to the list in my original post.

I agree. I'd accept Gemfile linters if someone is willing to write them. :-)

Make sure a gem is only listed once

I'll give this one a go

The idea of enforcing an order in a Gemfile is just wrong. The order is important because the gems are loaded as they are listed and may contain logic dependent on the gems already in memory.

@RKushnir, the new cop enforces ordering of groups of adjacent gems, not the whole Gemfile. No one has reported it breaking their app in the six months since it was added.

@mikegee I see, I didn't immediately grasp what is a group. Then it assumes the dependent gems are placed in different "batches". So if you need to enforce a specific order, you have to put a newline between them.

I don't understand why gems have to be sorted alphabetically.

@vassilevsky They don't have to be. You can disable that linter config (cop). The reason you might want it is so that you can quickly scan down the list visually and see whether a gem is there or not.

Yeah that's one reason to have them sorted :)


Support custom String class

For example, this allows using std::string
by defining:
-DARDUINONVS_STRING=std::string
-DARDUINONVS_STRING_INCLUDES=<string.h>

Use references to avoid copy

this looks like it would be super useful!

would be event better to use type templates