Merging template updates

This is to address https://github.com/nf-core/metaboigniter/pull/2
Most of the changes by the bot has been accepted. The ones rejected are related to specific parameters in the workflow.
additional changes:

automatic parameter estimation
improvement in CPU and memory performance of the identification
an updated version of quantification software
updated documentation

PR checklist

[x] This comment contains a description of changes (with reason)
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If necessary, also make a PR on the nf-core/metaboigniter branch on the nf-core/test-datasets repo
[x] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Make sure your code lints (nf-core lint .).
[ ] Documentation in docs is updated
[ ] CHANGELOG.md is updated
[ ] README.md is updated

Learn more about contributing: https://github.com/nf-core/metaboigniter/tree/master/.github/CONTRIBUTING.md

Why me?^^
Anyways, it will take me some time before I can have a look. So if you can dig up someone else it might be a good idea, else you will have to be a little bit patient, sorry.

Sorry! I just found a couple of persons who have done this recently :). If you have no time that's fine I can ask a few more.
Thanks...

Why me?^^
Anyways, it will take me some time before I can have a look. So if you can dig up someone else it might be a good idea, else you will have to be a little bit patient, sorry.

Merging into dev so that I can take a stab at some tidying up. Pre-release so can skip around some of the usual routines.


Update MD file on new branch 2017-18-14_05-11-09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


CLI completely freezes on WSL2

Checklist

[X] I have looked into the README and have not found a suitable solution or answer.
[X] I have looked into the documentation and have not found a suitable solution or answer.
[X] I have searched the issues and have not found a suitable solution or answer.
[X] I have upgraded to the latest version of this project and the issue still persists.
[X] I have searched the Auth0 Community forums and have not found a suitable solution or answer.
[X] I agree to the terms within the Auth0 Code of Conduct.

Description
The CLI is completely unresponsive after installation on WSL2. I tried multiple installation options including from source, for linux using cURL and from brew.
The only command I can run successfully is auth0 --help and ONLY if I have not attempted to run any other command before that. Once auth0 locks up I have to restart wsl with wsl --shutdown to recover. Hopefully you understand that for this reason I haven't gotten to play around with it a lot.
For greater clarity, this is exactly what happens when I run an auth0 command:

Given the CLI is past its 1.0.0 release I thought it might be stable but maybe WSL2 is not a supported environment? If so this should be explicitly mentioned given its popularity.
I'm using Ubuntu-20.04. Here is the result of uname -a
Linux JaredPC <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Fri Jan 27 02:56:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Expectation
That the CLI is responsive and works???
Reproduction

Install the auth0 CLI following the Linux instructions: curl -sSfL https://raw.githubusercontent.com/auth0/auth0-cli/main/install.sh | sh -s -- -b .
Add to path
Run any auth0 cli command. For example auth0 login.

Auth0 CLI version
1.0.1

Upvote - same issues.
It may run 1 time after install eg ./auth0 -v to get the version, but any subsequent will "hang".

@jarpoole and @jimhess , I'm trying to reproduce this and wondered if the latest version (1.2.0) works for you. Here's how I installed the specific version on my WSL2 instance:
curl -sSfL https://raw.githubusercontent.com/auth0/auth0-cli/main/install.sh | sh -s -- -b . v1.2.0
sudo mv auth0 /usr/local/bin/

The version at the end of the curl represent the version that you are installing. By default it is the latest, so pinning the version might help us reproduce this together.
I did attempt reproducing with v1.0.1 without result. My WSL2 version is <IP_ADDRESS>-microsoft-standard-WSL2, which is the store default as of today. Perhaps there's a difference in 5.10..5.15?
Please let us know if the latest is still causing issues.

@m3talsmith thank you for following up! Trying installation commands you recommended above everything seems to be working perfectly now! I'll close this now because it seems like things got resolved with time...


Add overscroll-behavior to the list of allowed properties.

See https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior for more information.

Thanks @zacharydenton!


Rel + CI exporter failing

The extractor to export measurables/relationships and involvements is failing as the number of left joins is increasing and the time taken to run the extract exceeds the 30 sec limit imposed by our apache httpd server.
Solution is probably to optimize the output as there are a lot of duplicative columns.  Perhaps look to use stuff (mssql) or vendor alternatives to inline lists.


Update music-list.js

@RiyaSaini1108 You also need to add an cover image for the song and the mp3 file(should not be copyrighted), so that the song can be played.


Docs

Improved documentation

Codecov Report

Merging #29 (38cd6a1) into dev (6ab9ab5) will decrease coverage by 0.78%.
The diff coverage is 80.79%.

@@            Coverage Diff             @@
##              dev      #29      +/-   ##
==========================================
- Coverage   73.33%   72.54%   -0.79%
==========================================
  Files          25       23       -2
  Lines        1350     1435      +85
  Branches      326      344      +18
==========================================
+ Hits          990     1041      +51
- Misses        235      262      +27
- Partials      125      132       +7

Flag
Coverage Δ

unittests
72.54% <80.79%> (-0.79%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

openapi_builder/converters/parameter/base.py
76.92% <50.00%> (-15.94%)
:arrow_down:

openapi_builder/converters/defaults/manager.py
57.57% <57.57%> (ø)

openapi_builder/converters/defaults/base.py
72.72% <60.00%> (-18.94%)
:arrow_down:

openapi_builder/converters/parameter/manager.py
60.60% <60.60%> (ø)

openapi_builder/converters/schema/halogen.py
52.50% <82.85%> (ø)

..._builder/converters/defaults/default_converters.py
79.41% <83.33%> (+1.99%)
:arrow_up:

openapi_builder/converters/schema/base.py
83.33% <83.33%> (ø)

openapi_builder/builder.py
86.61% <85.36%> (-2.97%)
:arrow_down:

openapi_builder/converters/schema/manager.py
90.00% <90.00%> (ø)

openapi_builder/converters/schema/marshmallow.py
81.55% <97.61%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ab9ab5...38cd6a1. Read the comment docs.


User's display name is nil after linking anonymous account to Google or Apple credentials.

Description
When user is signed in anonymously, and then link this anonymous account to either Google or Apple credentials using user.link(with:), user's displayName in returned AuthDataResult is nil.
Reproducing the issue
/// Sign-in anonymously first
try await Auth.auth().signInAnonymously()

/// Then, link with Google credentials
guard let user = Auth.auth().currentUser else { return nil }
let result = try await user.link(with: credentials)

/// print out results.
print("Display name: \(result.user.displayName)")
print("Email: \(result.user.email)")
print("GoogleSignInSuccess: \(result.user.uid)")

Result 👇🏻

Firebase SDK Version
10.18
Xcode Version
15.2
Installation Method
Swift Package Manager
Firebase Product(s)
Authentication
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Hi @marwaniaaj, I think this issue is similar to https://github.com/firebase/firebase-ios-sdk/issues/1694#issuecomment-424085098.
This is working as intended. When linking a provider, the provider’s displayName are not automatically copied to the top level. You can get the displayName from providerData and update the user profile after linking.

Thanks @NhienLam for clarifying that!
I've updated my code to update user's profile data with displayName from providerData.


Update inverted focus states

@arjundialpad reported an issue where the inverted button focus states aren't showing the correct colors anymore since the theming update. This PR fixes that issue.

Sorry, don't think I will be able to constructively contribute here.

@arjundialpad If you compare the current buttons page to Josh's buttons, you can visually compare the change in a browser ✌


feat(react): manage multipe state

this PR describe how to make custom hook to manage multiple state on React

Hi @nonunicorn, I love react and svelte, can we add this to this repo? It will be awesome 😄

Thanks, deployed to production:
https://onelinerhub.com/react/manage_multiple_state
Not exactly "one-liner" :) but that's ok, lets wait for the feedback from community. Value is more important than format.

@nonunicorn so it must be one line? Haha it's hard
But may be we can change the function to one line like this
const useMultiState = (initialStates) => useReducer((states, payload) => ({ ...states, ...payload }), initialStates)

But it will be less readable


added StepLabel class to avoid issues with labels that are also PHP function names

replaces #237, fixes #236
Instead of
'label' => function() {
	return 'country';
},

now
'label' => StepLabel::createCallableLabel(function() {
	return 'country';
}),

has to be used.
@fracsi, what do you think of this?

Coverage increased (+0.006%) to 99.748% when pulling 7519ee8d04b2ed2c74f896a8e20607db2b1e2833 on 3.0.x-steplabel-class into 03b0604cfc7de8d890add83b3afd1b45bde1e533 on master.

@craue Looks good to me.


WhatFailureGroupHandler

'WhatFailureGroupHandler' ignores the exception thrown by each child handler. Is there any way by which I can know what exceptions were ignored as I want to 'log' the ignored exceptions.?

This is not possible, but would be a good addition if you like to send a pull request. I think it could indeed store the exception, or even optionally log them but then you have to be careful to ignore further exceptions that occur while logging an exception, otherwise you are likely to end up in a recursion loop.

Thanks for the reply.
Apart from this, how can i access the instance of logger class (that I created in my controller) in the 'WhatFailureGroupHandler' class.? Because if I am able to do that, then I can log all the exceptions that were ignored in my log file.

You can't access the logger from there no, you could pass it in the constructor, or allow passing a set of handlers that are "safer" and less likely to fail and should be used for logging handler failures?

Encountered this as well, the current implementation of the WhatFailureGroupHandler just discards exceptions, which could/will lead to serious puzzling when:

users are reporting problems
entries do not appear in logs typically used for investigation (like LogEntries)

Maybe an initial pragmatic approach would be to simply use error_log() to at least inform the system of:

the message that was attempted to be logged
the caught exception (why did logging the message fail, for socket handlers useful information about connection timeouts, etc could help at pinpointing the source of problems...

just my 2 cents 😄

Closing as https://github.com/Seldaek/monolog/pull/1012 allows you to do more advanced error handling


Adding a code block adds extra
 and  tags

Filament Version
v3.2.75
Plugin Version
v3.3.3
PHP Version
PHP 8.1
Problem description
When I add a code block to the editor with some random code or text, and save it, the resultant HTML has two extra
 and  tags.
For example, writing this:

Gets stores like this in my database:

const a = 123;

Expected behavior
That the output would contain just one set of closing tags, not two.
Steps to reproduce

Try creating an Article and add some text to it, and save it.
Inspect the stored output.

Reproduction repository
https://github.com/AngadSethi/tiptap-editor-replicate-error
Relevant log output
No response

I've tracked this down to a bug in the DOMParser in the tiptap-php package. Not much that can be done at this point.

Oh, I'll raise this issue in tiptap-php then, @awcodes. Thanks a lot for checking this out!


Minor rendering issues for the package installation commands on the package page

There is this command sample on the package page:

It looks nice, until you try to select text in it in Edge browser. Then inactive tabs seem to be drawn over the active:

Does not happen in Chrome and Firefox.

What version of Edge?


Asterisk Support to stop playback on incoming Phone call

While I'm testing the Phonie (mpd version) now, it's running 6-10h a day.
Once in a while the phone rings and i have to stop the phonie to answer the phone.
I'm looking for a solution to stop the phonie on incoming calls. Asterisk seems to be the tool of choice.
Playing around with this thought it would be nice to pause the phonie and shout the number calling or the reference in the Phone-book.
I know this is only a nice feature far away from normal use cases. But with mpd as a backend, the phonie is no longer a kids-player its now a full blown rfid/ean Mediacenter.

Hi @Luegengladiator ,
in my opinion, this is a feature from far far away.´;)
I'm also testing this branch, good work for now.
Currently i'm looking for a no iron soldering solution for "Stop on removal"
and a real-time-clock support for features like 'lullaby (fade-out/max volume at a specific time)'
The Phoniebox should focus it on kids usecases.

Hi @Luegengladiator @Raspfarbend
soon Phoniebox will control smart homes :)
I like to keep an open mind when it comes to innovation - so let‘s see what comes of this issue.
When I am done with the RFID triggered „makeCoffeeNow“ for my Phoniebox, I‘ll spend more time on this issue ;)

Oh nice idea. Coffee Controf is no big deal. All you have to use is a RFC 2324 and RFC 7168 Coffeepot, use the api and here you are ;)

Finally I got it working. But the way is to complex to get it running in this context.


testing testing

💥

https://github.com/aspect-build/rules_js/actions/runs/3395634033/jobs/5645772123


type validation in v0.21.0: 'false' is not of type: boolean

in v0.21.0 the strings 'true' and 'false' are no longer recognized as boolean types. Unfortunately there is no boolean type in TSQL, but there is a bit type. @jtcohen6, any ideas for a workaround? I think we're blocked on releasing v0.21.0 until we figure something out. I tried integers and they didn't work as well.
https://github.com/dbt-msft/dbt-sqlserver/blob/4091a07a5bdb7b5bac521fc72d8da52fabcd6c16/dbt/include/sqlserver/macros/materializations/test.sql#L4-L7
'false' is not of type 'boolean'

Failed validating 'type' in schema['properties']['should_warn']:
    {'type': 'boolean'}

On instance['should_warn']:
    'false'

Oh no! This was an unintended side effect of turning off agate type coercion for query results, an otherwise uncontroversially good thing.
Hmmm. It does sound like the bit type is what we're after, doesn't it? And we've got an agate table being returned here, and a convert_boolean-type method defined in the adapter... I wonder if there isn't some way to muddle through this.
I'm thinking we might need to make this change in dbt-core, possibly hereabouts:
@dataclass
class TestResultData(dbtClassMixin):
    failures: int
    should_warn: bool
    should_error: bool

    @classmethod
    def validate(cls, data):
        if not isinstance(data.get('should_warn'), bool):
            data['should_warn'] = bool(data.get('should_warn'))
        if not isinstance(data.get('should_error'), bool):
            data['should_error'] = bool(data.get('should_error'))
        super().validate(data)

That would at least get you the ability to return 0 and 1, which sounds like the T-SQL way.
Could I bother you to open a dbt-core issue for this?

closed by #168


Fixed TEST_JALR_OP macro that used the LA macro in ways incompatible with GCC later than 2023-12-20

Description

Updated TEST_JALR_OP in test_macros.h
The macro no longer works when rd = x0 in versions of GCC newer than 2023.12.20
riscof throws a message /home/jstine/cvw/addins/riscv-arch-test/riscv-test-suite/rv32i_m/I/src/jalr-01.S:72: Error: illegal operands `la x0,5b'
The TEST_JALR_OP  macro invokes LA, which does not like x0 as an operand in the latest GCC
replacing LA(rd, 5b) with auipc rd, 0 in test_macros.h solves the compiler issue and produces similar code but without a bunch of preceeding nops

Related Issues
NA
Ratified/Unratified Extensions

[ I ] Ratified
[ ] Unratified

List Extensions
I
Reference Model Used

[x ] SAIL
[x ] Spike
[ ] Other - < SPECIFY HERE >

Mandatory Checklist:

[n/a ] All tests are compliant with the test-format spec present in this repo ?
[ y ] Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
[ n ] Ran the new tests on RISCOF in coverage mode
[ n ] Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
[ n ] Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
[ y ] Changelog entry created with a minor patch

Optional Checklist:

[n ] RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
[n ] Were the tests hand-written/modified ?
[y ] Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
https://github.com/openhwgroup/cvw/pull/677/files
[ n ] If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

Simple fix for a tool issue


chore(arrays.js): clarify comment

Made the comment clear by fixing the grammar.
Took @michaelficarra suggestion to make comment change even better.

What happened to line 255? Also, please don't open multiple PRs next time. Just update the already open one.

opps accidentally deleted it. I added it back in the commit. Thanks for catching that. Will update PRs next time instead; just started trying to contribute to open source :P Thank you!

done

Thanks.


Editor window - lag maximising panels

There is a lag when maximising those panels again when you click the arrows: it feels like nothing has happened...
By Julian

Done


Add test and basic implementation for formatter preview mode

Summary Prepare for the black preview style becoming the black stable style at the end of the year.
This adds a new test file to compare stable and preview on some relevant preview options in black, and makes format_dev understand the black preview flag. I've added poetry as a project that uses preview.
I've implemented one specific deviation (collapsing of stub implementation in non-stub files) which showed up in poetry for testing. This also improves poetry compatibility from 0.99891 to 0.99919.
Fixes #7440
New compatibility stats:

project
similarity index
total files
changed files

cpython
0.75803
1799
1647

django
0.99983
2772
35

home-assistant
0.99953
10596
189

poetry
0.99919
317
12

transformers
0.99963
2657
332

twine
1.00000
33
0

typeshed
0.99978
3669
20

warehouse
0.99969
654
15

zulip
0.99970
1459
22

Current dependencies on/for this PR:

main

PR #8049

PR #8044   👈

This comment was auto-generated by Graphite.

@konstin - Is this good to merge?

yep


clean up map menu to match DDD and some minor UX enhancements

placement of collapse to combine w/ icon if there
if no icon, still align as if there's an icon
if collapse, align with icon
if nested, reduce spacing on nesting
reduce font size (defaults)
increase available area for text
leave gutter available for options in context to perform operations on pages in the menu itself

wow


Item API redesign

This pull request offers a complete re-design to the entirety of the current item API, to make it much more intuitive and friendly, and to ensure thread safety and concurrent usage.
Notable changes include:

Item stacks are now fully immutable, meaning they can be used without any concurrency or mutability issues.
Item metadata is now fully immutable, meaning the same metadata can be reused between multiple item stacks.
Metadata now uses an inheritance-based system, rather than a key-based one, which provides much more information about available data, doesn't require a slightly hacky reader and writer setup, and also doesn't require the use of boxed primitives.
Loads of new helpers to assist with creating items and metadata nicely, for both Java and Kotlin.

The following is an example from the old system, creating a simple stone stack with 3 items in it, with a custom name and lore:

Kotlin:

val item = item {
    type(ItemTypes.STONE)
    amount(3)
    meta {
        set(MetaKeys.NAME, Component.text("Hello World!"))
        set(MetaKeys.LORE, listOf(Component.text("I am lore text!"), Component.text("Lorem ipsum dolor sit amet")))
    }
}

Java:

final ItemStack item = ItemStack.builder()
        .type(ItemTypes.STONE)
        .amount(3)
        .meta(holder -> {
            set(MetaKeys.NAME, Component.text("Hello World!"));
            set(MetaKeys.LORE, listOf(Component.text("I am lore text!"), Component.text("Lorem ipsum dolor sit amet")));
        })
        .build();

Let's look at the same thing done with the new system:

Kotlin:

val item = item {
    type(ItemTypes.STONE)
    amount(3)
    meta {
        name(Component.text("Hello World!"))
        lore(Component.text("I am lore text!"), Component.text("Lorem ipsum dolor sit amet"))
    }
}

Java:

final ItemStack item = ItemStack.builder()
        .type(ItemTypes.STONE)
        .amount(3)
        .meta(builder -> builder
                .name(Component.text("Hello World!"))
                .lore(Component.text("I am lore text!"), Component.text("Lorem ipsum dolor sit amet")))
        .build();

The biggest change here is that we're now using direct calls, rather than using set, which means we get greater type safety.
One of the big things that we can do with the new system that we couldn't do with the old is very easily create copies of metadata with changed values. The old system had metadata be immutable on the ItemStack, meaning to change it, we would have to copy the item stack, then change the metadata, which looks something like this:
val copy = item.copy()
copy.meta.set(MetaKeys.NAME, Component.text("Hello World!"))
// do something with the copy

With the new system, all we have to do is call withMeta to change the metadata:
val copy = item.withMeta(item.meta.withName(Component.text("Hello World!")))

Or we can use a builder if we need to make bulk changes:
val copy = item.withMeta {
    name(Component.text("Hello World!"))
    addLore(Component.text("I am more lore text!"))
}

Also, when Krypton has an API for creating custom inventories, this will be vital for ensuring safe reuse across multiple inventories.
There are many more examples on top of the ones shown where this will benefit greatly, though I am deciding to leave them out for the sake of berevity.

Codecov Report

Merging #71 (3bfdc28) into master (3f5e815) will decrease coverage by 1.00%.
The diff coverage is 14.36%.

:exclamation: Current head 3bfdc28 differs from pull request most recent head c9c6c83. Consider uploading reports for the commit c9c6c83 to get more accurate results

@@             Coverage Diff              @@
##             master      #71      +/-   ##
============================================
- Coverage     35.02%   34.01%   -1.01%
- Complexity      904      924      +20
============================================
  Files           816      842      +26
  Lines         22897    23640     +743
  Branches       1798     1819      +21
============================================
+ Hits           8019     8041      +22
- Misses        14772    15477     +705
- Partials        106      122      +16

Impacted Files
Coverage Δ

...ed/kotlin/org/kryptonmc/api/item/data/DyeColors.kt
100.00% <ø> (ø)

...rc/main/kotlin/org/kryptonmc/api/item/ItemStack.kt
18.18% <0.00%> (-10.39%)
:arrow_down:

...ain/kotlin/org/kryptonmc/api/item/data/DyeColor.kt
100.00% <ø> (ø)

...tlin/org/kryptonmc/api/item/data/FireworkEffect.kt
0.00% <0.00%> (ø)

.../org/kryptonmc/api/item/data/FireworkEffectType.kt
0.00% <0.00%> (ø)

...ain/kotlin/org/kryptonmc/api/item/data/ItemFlag.kt
0.00% <0.00%> (ø)

...ain/kotlin/org/kryptonmc/api/item/meta/BookMeta.kt
0.00% <0.00%> (ø)

...n/kotlin/org/kryptonmc/api/item/meta/BundleMeta.kt
0.00% <0.00%> (ø)

.../kotlin/org/kryptonmc/api/item/meta/CompassMeta.kt
0.00% <0.00%> (ø)

...kotlin/org/kryptonmc/api/item/meta/CrossbowMeta.kt
0.00% <0.00%> (ø)

... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f5e815...c9c6c83. Read the comment docs.

I was looking at the old code and was thinking meta should be a builder too then I saw it below, great stuff 👍


No releases in this repo?

I'm attempting to use bget with lando/lando (it's the lando-x64-vX.X.X.deb I'm interested in)
The latest release is v.3.4.2 although there are later pre-releases.

Unfortunately when running bget lando/lando I just get 'no releases in this repo'

it can only install binaries without extension (or .exe on windows) for now

That's fair, but shouldn't it have still picked up the .exe that is there rather than saying there are no releases?

true, I'll also let it download other files just without installing them.

same here.
example: https://github.com/multiprocessio/dsq

this issue should be fixed in 1.0.8
btw this library won't be able to handle .deb and .dmg since all it does it moving the asset to /usr/local/bin


Unlimited power when plug is on any capacitor bank tier

I have duplicated this on a server and a creative world. I connect a plug to an Capacitor Bank and then a point on any other energy storage or machine and even at zero capacity it will continue to drain power.
It seems to do it only when the source (plug) is a capacitor bank, but the destination (point) can be anything. So I don't know if this is a Flux Networks bug or Ender IO.  I am on FTB Beyond 1.7.0.
Source: http://imgur.com/a/0N6kE
Destination: http://imgur.com/a/qofva

Can confirm this in 1.10.2.  I was just playing around trying to understand some of the transfer options and I setup a test with 1 Ender IO Vibrant capacitor with a plug, and three (connected) Vibrant Capacitors with a Flux point.  I was able to fill all three capacitors from the single source capacitor and it just kept going when I added a few more on.

Fixed in dev


Tentative support for TypedDict

Adds provisional support for typed dict.
Closes #473

I didn't look at it thoroughly but, can TypedDict be merged successfully ?

I didn't look at it thoroughly but, can TypedDict be merged successfully ?

Yes, added a test.
it's treated like a regular dict, there is no additional runtime type safety for it.

Yes, added a test.
it's treated like a regular dict, there is no additional runtime type safety for it.

Seems like a reasonably easy thing to add.


DOM Reference .replaceChild() not working properly

I want to create an contentEditable area that get synchronized using Yjs-Xml. Since their is no "bind" function for now, I decided to add a callback to the input event which update the edited textNode with it's new content.
When I do that, I get the error TypeError: t._y_xml is undefined.
Here's my code.
<!DOCTYPE html>

        <meta charset="UTF-8">
        <title>Yjs test</title>

 yjs HTML

 Collaborative editing on HTML with yjs

and the following js file:
function track() {
    console.log("In track");
    var selection = window.getSelection();

    var range = document.getSelection().getRangeAt(0),
        old = selection.anchorNode;
    var so = range.startOffset,
        eo = range.endOffset,
        newer = document.createTextNode(old.nodeValue),
        parent = old.parentNode;

    parent.replaceChild(newer, old);

    // Replace the carret at the right position
    var newRange = document.createRange();
    newRange.selectNode(newer);
    newRange.setStart(newer, so);
    newRange.setEnd(newer, eo);

    selection.removeAllRanges();
    selection.addRange(newRange);
    console.log("Out track");
}

// Initialize Yjs variables
var connector = new Y.WebRTC("xml-webrtc-example"); //, {url: config.server});
var y = new Y(connector);

connector.debug = true;

// Set up shared object
connector.whenSynced(function(){
    if(y.val("dom") == null){
        y.val("dom", new Y.Xml($('#shared_div').get(0)));
    }
});
// Add callback to yjs
y.observe(function(events){
    for(i in events){
        if(events[i].type === "add" || events[i].type === "update") {
            if (events[i].name === "dom") {
                // Replace by new dom
                $('#shared_div').replaceWith(y.val("dom").getDom());
            }
        }
        console.log(events[i]);
    }
});

// Add callback to any change
$('#shared_div').on("input", function(){
    track();
});

Yes, this is a bug. It can take a while to fix it right, because I just realized that the way I store Text is not well thought through. I try to fix it till tomorrow or .. the day after tomorrow..

Well.. it seems I was able to fix this two days before the day after tomorrow :)
I included another example in this project. Furthermore the following changes have been made:

There are now dedicated Element and Text types for Y.Xml (please re-read the README.md)
You can now call update on the Y.Xml.Text node, which will update the Y type to the current value of the Dom.Text node.

The example actually works great. Undo is supported too :)

Please note: You have to pull the Yjs repository too!


az vm capture prints to stdout rather than returning values...

...which breaks output formatters, multiple ids etc. I'm also not sure why we have our own poller etc. (but I'm guessing that is because we are not returning values and letting the rest of the infrastructure do the right thing)
Current implementation:
def capture_vm(resource_group_name, vm_name, vhd_name_prefix,
storage_container='vhds', overwrite=True):
'''Captures the VM by copying virtual hard disks of the VM and outputs a
template that can be used to create similar VMs.
:param str vhd_name_prefix: the VHD name prefix specify for the VM disks
:param str storage_container: the storage account container name to save the disks
:param str overwrite: overwrite the existing disk file
'''
client = _compute_client_factory()
parameter = VirtualMachineCaptureParameters(vhd_name_prefix, storage_container, overwrite)
poller = client.virtual_machines.capture(resource_group_name, vm_name, parameter)
result = LongRunningOperation()(poller)
print(json.dumps(result.output, indent=2)) # pylint: disable=no-member

I believe the reason it prints to STDOUT is because it is outputting the VM template that you would then redirect to a file. For that, only the JSON output format would be appropriate.

I see. We can either live with it (I will add a code comment) or we take the suggestion from #1512, and expose a --template flag.
I would live with it.


scdl: 2.11.4 -> 2.12.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for scdl is: Download Music from Soundcloud
meta.homepage for scdl is: https://github.com/flyingrub/scdl
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.12.0 with grep in /nix/store/cvla8nbljsnchh8jyna2ix9a1rl4yhpi-scdl-2.12.0
found 2.12.0 in filename of file in /nix/store/cvla8nbljsnchh8jyna2ix9a1rl4yhpi-scdl-2.12.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

scdl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cvla8nbljsnchh8jyna2ix9a1rl4yhpi-scdl-2.12.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A scdl https://github.com/r-ryantm/nixpkgs/archive/ee146fdce4df5af88cee2b9859c33e7469cd3e61.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ee146fdce4df5af88cee2b9859c33e7469cd3e61#scdl

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cvla8nbljsnchh8jyna2ix9a1rl4yhpi-scdl-2.12.0
ls -la /nix/store/cvla8nbljsnchh8jyna2ix9a1rl4yhpi-scdl-2.12.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

scdl
scdl.dist

Maintainer pings

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for scdl is: Download Music from Soundcloud
meta.homepage for scdl is: https://github.com/flyingrub/scdl
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.12.1 with grep in /nix/store/qlrgjd1qhda3p15ffg5klrv1ikmflgf2-scdl-2.12.1
found 2.12.1 in filename of file in /nix/store/qlrgjd1qhda3p15ffg5klrv1ikmflgf2-scdl-2.12.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

scdl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qlrgjd1qhda3p15ffg5klrv1ikmflgf2-scdl-2.12.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A scdl https://github.com/r-ryantm/nixpkgs/archive/2067f837dc17e5bb1e102b605396560960f3ea14.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2067f837dc17e5bb1e102b605396560960f3ea14#scdl

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qlrgjd1qhda3p15ffg5klrv1ikmflgf2-scdl-2.12.1
ls -la /nix/store/qlrgjd1qhda3p15ffg5klrv1ikmflgf2-scdl-2.12.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

scdl
scdl.dist

Maintainer pings

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 335014 run on aarch64-linux 1

2 packages built:

scdl
scdl.dist


Select component should not react to a click on "ListSubheader"

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Following the pattern described in the Select API docs, create a Select item and use ListSubheader to create categories. (non-native)
Observation 1: if the Select does not have a value, then the label of the bottom ListSubheader appears.
Observation 2: the ListSubheader rows are clickable, and fire a click event, meaning they can be selected or they can fire an onChange event.
Expected Behavior 🤔
Neither should happen.
If there is no value for the Select, then the fallback behavior should be to let the Text input field render the label inline the way it should when there are no ListSubheader items, or be blank if there is no label at all.
The ListSubheader items should not respond to clicks at all, as if optgroup was being used.  If keyboard navigation is used in the list, they should be skipped over as being non-selectable.
Steps to Reproduce 🕹
I'll set up a codesandbox later tonight after dinner and edit this issue accordingly when it is done.
Steps:
more or less covered above.
Context 🔦
list selection for a music player - the playlists can be categorized, so i turned the list from a flat list into a grouped one.  in native mode, optgroup handles this correctly.
workaround attempts:

tried to add an empty value menu item to get the initial label as expected. didn't work, the last category (listsubheader) continued to show.
put a disable on the ListSubheader. no effect, it appears the ListSubheader is being put into a button or something and that continues to respond to events.

Your Environment 🌎

Tech
Version

Material-UI
v4.6.1

React
16.8.x

Browser
Chrome

TypeScript
no

@acroyear Let us know when you've had a chance to prep the codesandbox, but alternatively, if the issue is present in a docs example, that will cover it.

@acroyear I have seen a similar report on a pull request (I can't find it). I can confirm that there is a couple of issue with this demo: https://material-ui.com/components/selects/#grouping:

clickable group item
background issue with stacking group item when scrolling

Ok, I resolved one of the issues - the reason it was falling back on using the label of the last category was because the value was being set to one that didn't really exist.
I had in the Select code value='' + selectedId but selectedId was not provided.  This meant that react generated a value string of "undefined" which threw things off.  making sure the value was passed in as empty string correctly matched the empty item I added (similar to the None example on the documentation page).  Finally got the embedded input label (when input is empty) to work as well by adding the FormControl wrapper to it all.
I can definitely see the "onClick" being added to ListSubheader, so if you already know about that one, then that's the only issue I have at this point.  This can be closed as resolved.  I'll strike out the part that is working correctly with my fix in the original.

Let's move it to #18390

Let's move it to #18200

i'm good with that. no worries.


log: make sealer log printing unified, structured and more readable

Signed-off-by: Allen Sun<EMAIL_ADDRESS>Describe what this PR does / why we need it
This pull request updated area of sealer's log.
Currently, end users bear a lot on sealer's log. There are lots of cases where end user could not recognize the log's meaning, even if he is a senior k8s or sealer engineer. We have to say sealer's log needs improvement.
First, just make the error message and log message readable, to satisfy normal user's English reading.
Second, provide helpful information as sufficient as possible.
And This pull request went through all log and error code of sealer project, and improved them within itself.
In the future, we still keep pace with user's input to improve log and error, such as: improving the accurate embedded message, shorten log information with continuous arch improving.
Does this pull request fix one issue?
none

Describe how you did it
none
Describe how to verify it
none
Special notes for reviews
none

/test apply

Codecov Report

Merging #1568 (d1ebf9d) into main (4f515ac) will increase coverage by 0.00%.
The diff coverage is 0.57%.

@@           Coverage Diff           @@
##             main    #1568   +/-   ##
=======================================
  Coverage   11.10%   11.10%
=======================================
  Files          88       88
  Lines        8063     8062    -1
=======================================
  Hits          895      895
+ Misses       7057     7056    -1
  Partials      111      111

Impacted Files
Coverage Δ

build/layerutils/charts/charts.go
0.00% <0.00%> (ø)

build/layerutils/charts/helm.go
0.00% <0.00%> (ø)

build/layerutils/manifests/manifests.go
0.00% <0.00%> (ø)

pkg/config/pre_process.go
0.00% <0.00%> (ø)

pkg/env/env.go
57.83% <0.00%> (ø)

pkg/filesystem/filesystem.go
0.00% <0.00%> (ø)

pkg/image/default_image.go
0.00% <0.00%> (ø)

pkg/image/default_image_file.go
0.00% <0.00%> (ø)

pkg/image/save/save.go
0.00% <0.00%> (ø)

pkg/image/store/filesystem.go
0.00% <0.00%> (ø)

... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f515ac...d1ebf9d. Read the comment docs.


ryuxyro.merahputih.moe

What is your project about? Please describe it swift and simple.
Your answer: portfolio website

done


Failed to compile openwrt-frp for openwrt-x86_64-19.07.7 on Ubuntu 20.04.

Hi,
On Ubuntu 20.04, I try to compile openwrt-frp for openwrt-x86_64-19.07.7 but failed as shown below.
See the following for the openwrt firmware version info for my case:
root@OpenWrt:~# cat /etc/openwrt_release
DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='19.07.7'
DISTRIB_REVISION='r11306-c4a6851c72'
DISTRIB_TARGET='x86/64'
DISTRIB_ARCH='x86_64'
DISTRIB_DESCRIPTION='OpenWrt 19.07.7 r11306-c4a6851c72'
DISTRIB_TAINTS=''

The openwrt master version info is shown below:
$ git log -1
commit 209c5918b511d9e406a094ba246a985b640e519f (HEAD -> master, origin/master, origin/HEAD)
Author: Vivek Unune<EMAIL_ADDRESS>Date:   Fri Nov 13 08:43:00 2020 -0500

I compile openwrt-frp according to the guidance here with the following steps:

$ git clone https://github.com/kuoruan/openwrt-frp.git package/frp

$ ./scripts/feeds update -a
$ ./scripts/feeds install -a

$ make menuconfig

Network  ---> Web Servers/Proxies  ---> <*> frpc
Network  ---> Web Servers/Proxies  ---> <*> frps

$ make package/frp/{clean,compile} V=s
[...]
cp -fpR /home/werner/Public/repo/git.openwrt.org/openwrt/openwrt.git/staging_dir/toolchain-x86_64_gcc-8.4.0_musl/lib/ld-musl-*.so* /home/werner/Public/repo/git.openwrt.org/openwrt/openwrt.git/build_dir/target-x86_64_musl/toolchain/.pkgdir/libc/lib/
cp: cannot stat '/home/werner/Public/repo/git.openwrt.org/openwrt/openwrt.git/staging_dir/toolchain-x86_64_gcc-8.4.0_musl/lib/ld-musl-*.so*': No such file or directory
make[2]: *** [Makefile:728: /home/werner/Public/repo/git.openwrt.org/openwrt/openwrt.git/build_dir/target-x86_64_musl/toolchain/.pkgdir/libc.installed] Error 1
make[2]: Leaving directory '/home/werner/Public/repo/git.openwrt.org/openwrt/openwrt.git/package/libs/toolchain'
time: package/libs/toolchain/compile#0.28#0.15#0.39
    ERROR: package/libs/toolchain failed to build.
make[1]: *** [package/Makefile:114: package/libs/toolchain/compile] Error 1
make[1]: Leaving directory '/home/werner/Public/repo/git.openwrt.org/openwrt/openwrt.git'
make: *** [/home/werner/Public/repo/git.openwrt.org/openwrt/openwrt.git/include/toplevel.mk:230: package/frp/compile] Error 2

OTOH, I can successfully compile openwrt-frp from within OpenWrt SDK using the same above-mentioned steps. See the following for the generated ipk files:
$ find . -type f -name '*.ipk' | grep frp
./bin/packages/x86_64/base/frps_0.36.2-1_x86_64.ipk
./bin/packages/x86_64/base/frpc_0.36.2-1_x86_64.ipk

Any hints for solving this problem?
Regards,
HY

Finally, I solved the problem with the following trick, though I don't know why these files are missing in the openwrt git repo.
According to the content of your comile.sh, I retrieved the snapshot version of the openwrt-sdk here, and then copy the toolchain-x86_64_gcc-8.4.0_musl directory of the sdk to the corresponding location of the openwrt git repo. This fix the issue reported here.
Regards,
HY

Sorry for the late reply. Yes, you'd better use the snapshot version of OpenWrt SDK. Other versions not fully tested.


Performance gate

Run performance tests on every PR and merge, warn when performance degrades. Graph performance of releases over time.

Closing this as duplicate of https://github.com/falconry/falcon/issues/1450


JAVA-1255: Allow nested UDTs to be used in Mapper

For JAVA-1255

That looks like an oversight when I refactored the code. The old ReflectionFactory used to scan for UDTs for both columns and fields, but I only ported these two lines of code to parseEntity, and forgot to call them in parseUDT.
What is said is that we did not have any nested UDT test so far, so I'm glad that we now have one!

Went ahead and applied my comment above. lgtm 👍
Although, we might want to create a separate branch, 3.1.x, to host fixes for 3.1.0, wdyt? We might also consider renaming 3.0 to 3.x as well.

Thanks for reviewing and adjusting for getter/setters support :).  I agree with reopening this against a 3.1 specific branch when we have that 👍


Remove: AlgoSeekFutures Converter

Description

This pull request removes the AlgoSeekFuturesConverter from the ToolBox program. This code is deemed outdated and unused, contributing to a cleaner and more streamlined codebase.
Related Issue

N/A
Motivation and Context

The AlgoSeekFuturesConverter functionality has become obsolete and no longer serves a purpose within the ToolBox program. Removing it will not only declutter the codebase but also improve maintainability and understanding for future developers working on the project. This action aligns with our ongoing efforts to ensure that our codebase remains efficient and relevant to current needs.
Requires Documentation Change

N/A
How Has This Been Tested?

To ensure the integrity of the update, the following steps were taken:

Old Test Execution: The existing test suite was run to verify the functionality prior to the update.
Regression Testing: A thorough regression test was conducted to ensure that the changes did not introduce any new issues or conflicts.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Same as https://github.com/QuantConnect/Lean/pull/7559 we can't merge this yet until new converter is operational 👍


Add surface level raw download configs.

          > I couldn't find the config files in /raw -- perhaps these need to be added too?

Will follow up in a future issue.
Originally posted by @alxmrs in https://github.com/google-research/arco-era5/issues/27#issuecomment-1581348993

I confirmed that config files of variables which are used in this zarr gs://gcp-public-data-arco-era5/co/single-level-surface.zarr is missing. Other than this we have all of the config file of all variables which are part of this directory gs://gcp-public-data-arco-era5/co/.
We need config file for these two variables:

****_hres_lnsp.grb2
****_hres_zs.grb2

I have downloaded the data using of the newly added config so now I can clearly says it is fine and you should have to close this issue.
Data downloaded: lnsp and zs variable in the given bucket.

Closing as fixed!


Statistics Orchestrator Draft - Fully Functional with simple unit tests

Adds statistics orchestrator code with simple unit tests. More unit tests will be defined in the next PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: sveitser:white_check_mark: elliedavidson:x: Rohan AhluwaliaRohan Ahluwalia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add more file types to skip in code climate

Even if they're not analyzed by the different engines, they should not even show up in codeclimate as of right now.

Updated to be sorted in the ** section


3bots activate the testnet wallet using friendbot, not the testnet activation service

Description
Although this works now and prevents our testnet activation service from being drained, this does not test the actual activation service/flow itself.
It also does not test real life scenario's where the activation service is in need of new funding and operations needs to step in

deprecated

deprecated


DETAIL:  Key (history_user_id)=(1) is not present in table "auth_user".

hi there, i'm trying django-simple-history, it's work properly on my dev env with sqllite but when I run my tests under staging environment that use postgresql i got this error:
IntegrityError: insert or update on table "my_app_historicalfield_type" violates foreign key constraint "my_app_hi_history_user_id_375e8e7412342c93_fk_auth_user_id"
DETAIL:  Key (history_user_id)=(1) is not present in table "auth_user".
thanks !
Anthony

Hello @Gluriurl:
I'm guessing your tests generate a user without saving it to the database. Just save the user before using it to perform tracked actions and it should work without any issues.

Thanks for your reactivity.
I create the user before with:
user = User.objects.create_user('temporary', '', 'temporary')
..
self.client.login(username='temporary', password='temporary')
..
ModelWithHistory.objects.get_or_create(...)
The error is raised just after that. In my dev environment the very same test is executed without any problem.
Maybe it's due to Postgresql (I have sqlite in dev env) ?

@Gluriurl are you also using our HistoryRequestMiddleware? That's the only way doing a direct get_or_create() would have an idea of which user is logged in.

@macro1 Yes i'm using HistoryRequestMiddleware.

@Gluriurl: If I have some time I will try to reproduce it, or if you can reproduce it in a minimal project so I could take a look, I might be able to figure out what's going on.

I'm having similar problem with my tests. They are functional selenium tests driven by django's manage.py script. I'm getting this IntegrityError inside of the second functional test at the very first step when I'm trying to mock data (using factory-boy) of the model that uses simple_history. I've traced problem down to get_history_user method and it's call to thread.request.user that gives the wrong user. A bit more details in my question at stackoverflow

Huh. I can see how that would be troublesome. There's a pull request open to fix exactly this: #213
You can install that branch directly with pip to see if that resolves your issue:
pip install git+https://github.com/lucaswiman/django-simple-history.git@unset-middleware-request

The fix in #213 is now merged and released in 1.8.1, please upgrade to that version to avoid the issues with testing while using the middleware.

That fixed that, thanks a lot!


fix: Run wasm nodejs tests with no fails

Description
Fix of testing process of crate wasm
Problem*
The nodejs tests of crate wasm fail because mocha cannot resolve some imports. Mocha throws error
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for [filepath]

Summary*
The bug is fixed using alternative import and changed resolving of filepaths.
Documentation

[ ] I think the crate wasm should provide the documentation for building and testing processes.

Additional Context

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Can you add a test:node command to the package.json?

Hello @kevaundray I've added the command and I've tested my ideas.
I have had two ideas how to make minimal changes. The minimal changes is the changed file index.test.ts and some command/config. First idea is to setup alternative mocha options and compile the tests. I've tried many different combinations and each time tests was failed. The second idea is to compile module using standard typescript compiler tsc and then run tests. It works as expected. To run the tests I need to execute two commands:
tsc tests/node/index.test.ts
npm test

The solution requires no additional dependencies and only change the commands in package.json:
+    "build:node": "tsc test/node/index.test.ts",
...
+    "test": "npm run build:node && env TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha",

The command npm test will save artifacts with .js extension. The artifacts can be cleaned after testing.
I think that the second solution is a bit better than the current realization. What do you think?

Second option sounds better -- also this seems like the logical thing to do

Second option sounds better -- also this seems like the logical thing to do

I will switch to the package and add types to it.

btw seems we are only testing browser here:
https://github.com/noir-lang/noir/blob/182d017fe8f4fff1ccdd9fd55be6a21856110903/.github/workflows/wasm.yml#L202

I'm trying to keep PRs with minimal changes.
I've added the node testing in the commit.

Does this closes https://github.com/noir-lang/noir/issues/2326?
cc @kobyhallx

Does this closes #2326?
cc @kobyhallx

Hello @Savio-Sou
Since we have passed nodejs tests https://github.com/noir-lang/noir/actions/runs/6019172378/job/16328784396#step:8:3 we can close the issue.


IApplicationBuilderExtensions has incorrect name

This class should be named ApplicationBuilderExtensions according to guidelines:

When writing extension methods for an interface the sponsor type name must not start with an I.

@dougbu Nice catch :+1:

113fa6d


Invokable class middleware not passing $next

Invokable class middleware not passing $next
<?php
require_once __DIR__ . "/../vendor/autoload.php";

class SampleMiddleware
{
	public function __invoke($request, $response, $nex)
	{
		$response->getBody()->write(' __BEFORE__ ');
		$response = $next($request, $response);
		$response->getBody()->write(' __AFTER__ ');

		return $response;
	}
}

$slimSettings['settings']['displayErrorDetails']    = true;
$slimSettings['settings']['addContentLengthHeader'] = false;

$app = new \Slim\App($slimSettings);

$app->add( new SampleMiddleware() );

$app->get('/', function ($request, $response, $args) {
	return $response->getBody()->write(" Hello... ");
});

$app->run();

Reports Error
Notice: Undefined variable: next in /sh/slab/www-root/client-works/cd.tiger/www/index.php on line 9
Slim Application Error
The application could not run because of the following error:

Details

Type: Error
Message: Function name must be a string
File: /sh/slab/www-root/client-works/cd.tiger/www/index.php
Line: 9
Trace

#0 [internal function]: SampleMiddleware->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\App))
#1 /sh/slab/www-root/client-works/cd.tiger/app-sts/php-root/composer-lib/vendor/slim/slim/Slim/DeferredCallable.php(43): call_user_func_array(Object(SampleMiddleware), Array)
#2 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\App))
#3 /sh/slab/www-root/client-works/cd.tiger/app-sts/php-root/composer-lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(67): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\App))
#4 /sh/slab/www-root/client-works/cd.tiger/app-sts/php-root/composer-lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(116): Slim\App->Slim\{closure}(Object(Slim\Http\Request), Object(Slim\Http\Response))
#5 /sh/slab/www-root/client-works/cd.tiger/app-sts/php-root/composer-lib/vendor/slim/slim/Slim/App.php(337): Slim\App->callMiddlewareStack(Object(Slim\Http\Request), Object(Slim\Http\Response))
#6 /sh/slab/www-root/client-works/cd.tiger/app-sts/php-root/composer-lib/vendor/slim/slim/Slim/App.php(298): Slim\App->process(Object(Slim\Http\Request), Object(Slim\Http\Response))
#7 /sh/slab/www-root/client-works/cd.tiger/www/index.php(27): Slim\App->run()
#8 {main}

upon debugging, found that $next is null !

You have a misspelling in your function definition:
public function __invoke($request, $response, $nex)

should be:
public function __invoke($request, $response, $next)

@akrabat  Thank you Very much. Now working.
Will do more research before posting here.
Sorry 😢

@SusanthCom No problem. Glad it's working for you now.


Make setColumn() a lot simpler and actually work.

I'm not sure what the bitshift was trying to do, but it does not work. This drastically simplifies this call and also makes it possible to draw a straight column (it was completely bjorked before).

Looking at this deeper... perhaps I misunderstand what it's used for. There are no references to this function in the library itself, or any of the examples. I assumed it was to draw a solid vertical line on the matrix, but that may be incorrect?

Aha... that makes more sense. Without anything to call it, I wasn't sure what the intention was. Clearly I misunderstood. Please ignore this.

My marquee code uses it to put characters on the display. I have them organized in columns and the width of chars is variable. This was I just loop over columns of a char.
Feel free to write an example, but please wait for the other merges first. The API for reversing displays is going to change very soon!


Java 17 rt.jar doesn't exists

Hey,
I tried to obfuscate my program which is written in java version 17. However, I noticed that the rt.jar does not exist in higher java versions! I already tried to use the src.zip which is in the lib folder, but it doesn't work.
Could you possibly tell me which file I have to add / use so that it works?
Thanks in advance.

Java 9+ Doesnt have a rt.jar
You can get the same effect tho by using the jrt-fs.jar

Thanks


Timescaledb-tune exists with the message exit: could not find postgresql.conf on Mac1

When you install TimescaleDB on Mac1 with home-brew
Timescaledb-tune exists with message:
exit: could not find postgresql.conf at any of these locations:
/usr/local/var/postgres/postgresql.conf
When you specify the location of the conf file it works:
timescaledb-tune --conf-path=/opt/homebrew/var/postgres/postgresql.conf
Using postgresql.conf at this path:
/opt/homebrew/var/postgres/postgresql.conf

Writing backup to:
/var/folders/6d/5c405z253n35bqph1mh4bdp00000gn/T/timescaledb_tune.backup202206171221

shared_preload_libraries needs to be updated
Current:
#shared_preload_libraries = ''
Recommended:
shared_preload_libraries = 'timescaledb'
Is this okay? [(y)es/(n)o]: yes
success: shared_preload_libraries will be updated

Tune memory/parallelism/WAL and other settings? [(y)es/(n)o]: yes
Recommendations based on 8.00 GB of available memory and 8 CPUs for PostgreSQL 14

This should be fixed now. Please reopen if you still experience this with latest version.


Validate PodSecurity kube-apiserver admission plugin config

How to categorize this PR?

/area quality usability
/kind enhancement
What this PR does / why we need it:
In https://github.com/gardener/gardener/blob/master/docs/usage/pod-security.md#admission-configuration-for-the-podsecurity-admission-plugin, It is clearly stated that:

⚠ Note that pod-security.admission.config.k8s.io/v1 configuration requires v1.25+. For v1.23 and v1.24, use pod-security.admission.config.k8s.io/v1beta1. For v1.22, use pod-security.admission.config.k8s.io/v1alpha1.

Still, if a user provides wrong config for the plugin in the Shoot spec, kube-apiserver will fail with:
E0208 09:22:16.294759       1 run.go:74] "command failed" err="failed to initialize admission: couldn't init admission plugin \"PodSecurity\": no kind \"PodSecurityConfiguration\" is registered for version \"pod-security.admission.config.k8s.io/v1\" in scheme \"vendor/k8s.io/pod-security-admission/admission/api/scheme/scheme.go:30\""

This PR adds validation to prevent such case.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @rfranzke @ary1992
Release note:

NONE

/cherry-pick release-v1.63

/cherry-pick release-v1.62

/cherry-pick release-v1.61

/assign

@acumino I have reworked the validation as well, PTAL https://github.com/gardener/gardener/pull/7472/commits/5e10e59b8ed2a73ec34e70551ebb472eedd13415

/cherry-pick release-v1.64


Remove 'Completed' from Upload status update

Do we still need to call this API "update-consignment-status" from the frontend if we are not setting any value? If yes, then we should set it as InProgress. What do you think?

@vimleshtna, yes we do. When a user clicks the continue button on the upload page, we call startUpload, in the frontend which calls the API, which eventually calls the StartUpload method, which sets it to "InProgress". Then after the S3 file uploads, the code (that I edited) used to call the API and set the Upload consignment status to "Completed" but now (after my change) it will call the API, which will check the file UploadStatuses and if they are all completed, marks the consignment UploadStatus as complete. So the API now sets it to "Completed" rather than the frontend; the frontend just triggers this process. I think the plan later is to have a lambda do the triggering (there is a spike card), but for now, we're letting the frontend do it.


I don't understand the bullet_hit signal

I want to deal damage to the player when the player touch a bullet but I didn't Understand how the bullet_hit signal work
should I use result ?
how do I even use result I didn't understand that in the documents

I want to deal damage to the player when the player touch a bullet but I didn't Understand how the bullet_hit signal work should I use result ? how do I even use result I didn't understand that in the documents

Here is how I use it, nothing final but I think this is how it's suppose to work?
result contains all the objects that got hit. r.collider is the Area2D in this case that we collided  and I use that to get the node i need. In my implementation Damageable is a node I attached to my enemy.
func _on_spawner_bullet_hit(result: Array, bulletIndex: int, spawner: Spawner) -> void:
	for r in result:
		var damagable:Damageable = r.collider.get_parent().get_node("Damageable");
		if damagable != null:
			damagable.takeDamage(10);

Input from the dev would be nice though because I'm not entirely sure if this it he way.


Case not reflecting AM/PM vs am/pm format

I am trying to output an hour as ham/pm, but it returns in hAM/PM, e.g. 3:00am is displaying as 3AM instead of 3am.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9f30da2a-1b9d-9d31-c59e-494314144b2f
Version Independent ID: abe8de4e-2ed5-aedc-d2b3-a819bdf40587
Content: Text function - PowerApps
Content Source: powerapps-docs/maker/canvas-apps/functions/function-text.md
Service: powerapps
GitHub Login: @gregli-msft
Microsoft Alias: gregli

@csteelatgburg Or even this?
Text(Now(), "[$-en-US]ha/p")


388 - Prevent the control connection from timing out as a result of rebuilding the token map

Here I will review 778f853 and assume any changes discussed in #309 will be merged ahead.

+1 pending #309

Merged @ 4c744dc6537596de05ceb1c9da4ff8da67e9f586


Installing DeepSpeed in WSL.

I am using Windows 11. I have Windows Subsystem for Linux activated (Ubuntu) as well as installed CUDA, and Visual Studio C++ Build tools. I am trying to install deepspeed. However, I am getting the following 2 errors. Could anybody please help resolve this?

Hi @anonymous-user803 - are you trying to install DeepSpeed in WSL or in Windows command prompt?
Also can you please share the full error log as well as the command you used?
From the error log I see that torch could not find cuda.  Could you please run these commands as well from the same venv/python env?
python -c "import torch; print('torch:', torch.__version__, torch)"
python -c "import torch; print('CUDA available:', torch.cuda.is_available())"

Hi @anonymous-user803 - any updates on this?

@loadams
I was trying using Git Bash, PowerShell as well as Command Prompt, neither worked. Then I tried using WSL, and it worked. Beyond this, I don't know for sure myself what I am trying to accomplish. I have been given some task by my research mentor.

Hi @anonymous-user803 - if you are installing PowerShell or Command Prompt, you would need to download and use the Windows whl we publish.  The most recently published one is here.  If you are able to use WSL for your project, you can install the Linux whl or build from source.  However, it depends which you want to use for your work.

Hi @anonymous-user803 - I'm going to close this issue now since you were able to install.  If you are still having issues, or need to install on Windows Command Prompt instead of WSL, please comment and we can help.


DigitalOcean DNS update adds new DNS record instead of update

[x] Redmine Issue: https://redmine.pfsense.org/issues/10952
[x] Ready for review

Fix tested on pfSense 2.4.5 with successfully working on IPv4 and IPv6 NS records.

Fix tested on pfSense 2.4.5 with successfully working on IPv4 and IPv6 NS records.


Compatibilty with Non-AKS Kubernetes

Is OSBA compatible with other non-AKS kubernetes installations? e.g. ACS, acs-engine, etc?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77905ec1-fd7e-d037-cac5-62a5b8075c1b
Version Independent ID: 239518e8-cb47-3fd3-9cc2-2238ef57cbc6
Content: Integrate with Azure-managed services using Open Service Broker for Azure (OSBA)
Content Source: articles/aks/integrate-azure.md
Service: container-service
GitHub Login: @sozercan
Microsoft Alias: seozerca

Hi @apeschel. I don't believe ACS is supported. Instructions should work exactly same on acs-engine (you can have RBAC enabled on acs-engine as well).

#please-close


Release v0.39.0

https://github.com/vmware-tanzu/carvel-ytt/releases/tag/v0.39.0
https://twitter.com/carvel_dev/status/1489010517771493382
https://community.chocolatey.org/packages/ytt/0.39.0

Released :

https://twitter.com/rastadidi/status/1490549981257756673


Use define section from webpack stylus config

Guys, could I use this section to set image inlining with custom properties (e.g. do not use default 'url' title for function)? I'm wondering because of existing of internal resolver file.

What's wrong with this @AlexYankee ?
stylus: {
        define: [
            inline: stylus.url({ paths: [__dirname + '/src/images'] })
        ]
}

According to this doc it should work... http://stylus-lang.com/docs/functions.url.html


glog: Add upstream patch to fix tests with musl.

Motivation for this change
Fix build with musl. Patch is in upstream master but it hasn't made a release for a long time.
Should not change eval on non-musl.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
None specified.

@GrahamcOfBorg build pkgsMusl.glog

CC @mryndzionek


Installing stress-test tasks: Need to be in a folder that's accessible to the server

Cool to see the task registration using on-disk tasks. One limit I found when setting up the stress test at FMI: The server needs to have access to those files, otherwise we get a:
[Errno 13] Permission denied: '/Path/to/fractal-stress-tests/fractal-demos/examples/99_stress_test/fractal-tasks-stresstest/dist/fractal_tasks_stresstest-1.0.0-py3-none-any.whl'

I'll keep track of workarounds here, depending on how we do things, we can think about updating the example or leaving a README note.

One workaround:
Use this
FRACTAL_ACCESSIBLE_BASE_FOLDER=`pwd`
fractal task collect $FRACTAL_ACCESSIBLE_BASE_FOLDER/fractal-tasks-stresstest/dist/fractal_tasks_stresstest-${VERSION}-py3-none-any.whl

And instruct the user to set the FRACTAL_ACCESSIBLE_BASE_FOLDER to a fractal-demos/examples/99_stress_test folder that is accessible to the server. That allows for correct task installation.


URL regex does not work on MRI 1.8.7 or REE

You can see the failures if you add the following lines to .travis.yml:
rvm:
  - 1.8.7
  - ree

I see. I don't have a lot of time at the moment to look at this one, but if you submit a working patch request, I will be more than happy to pull it in. Otherwise, it may be a day or two...

I can wait a day or two. It wasn't really a problem for me. Just more of an issue that could hinder more widespread adoption.

Fix was easier than I thought. Taken care of.

:)


Turkish Localizations - labels, messages

Localizations - labels, messages
Turkish

Hi @murattdogan - can you send a PR with these translations?
Thanks.

Hi @skoruba and @murattdogan
Is there any update about Turkish Localizations?


Device Database modification - Add product, add new PID for existing

Added the following:

New product ID for Fibaro Heat controller
New product config for AEOTEC Range Extender 7

Ref #1218

Tell me when you're finished, then I'll approve.

I removed the paramInformation and fixed all minor typos!  @AlCalzone

This is going into 5.6.1


Build a landing page for the app's root screen.

Task Summary
The current home screen is cute but it could be better.
This is an open-ended task to create a useful homescreen for the time tracker project, maybe something that shows data relevant to the user or some links to exports or something. Maybe some stats?

Current view

As a person who's entering time, my homepage should probably be just my timesheet =)

Yeah! This screen should make getting to the meat of the app really easy!


Model License?

Hello, I was wondering what license your models are under. Is it Apache 2.0, the same as the main repository? Thanks!

Thank you!


Add contribution guide to the documentation index

Also removes modules from the index that do not exist. These were probably removed in the recent restucturing.

Codecov Report

Merging #299 (695aff8) into master (bb894b5) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   84.90%   84.90%
=======================================
  Files          49       49
  Lines        3213     3213
=======================================
  Hits         2728     2728
  Misses        485      485


Error no such file dirctory while yarn dev

Hello, i just following the Getting Started section, but when i write npm run dev, it shows an error
ENOENT: no such file or directory, stat 'C:/Users/ASUS/Documents/GitHub/snipsnap-electron/preload'

Can you provide minimal reproduction repo?

It works after reinstalling node modules. Weird but i don't know it works


Can you come up with a comfy ui version

+1

Hey, @zmwv823 It's great news that we have Ctrl lora nodes and appreciate that here you have compared them with CNs with 1.5 checkpoints. However, you have tested Ctrl lora only with Dreamshaper, why? Is it the only supported model?  While you have used different checkpoint with normal CN with 1.5? Can you please do a comparison with same checkpoints so we have a even better idea. Otherwise it just seems normal like sd 1.5 CN.

How to get ctrlora's nodes

How to get ctrlora's nodes

@zmwv823

ok,fine

So you're going to publish it? @zmwv823

The official gradio interface is always wrong, I wish I could run it on comfy ui!

ok,tanks

ok thanks

You can ask chatgpt, I always do it @zmwv823

Is it a problem with the checkpoints, and why do you come out with a poorly textured image @zmwv823

Okay, I'll try it.

https://github.com/Kosinkadink/ComfyUI-Advanced-ControlNet/issues/193

ComfyuI native support is coming soon! #16


Request Interface

Hi there,
is there any way, how to get ApiRequest in Base Controller?
Kind Regards,
M.

This is great. Thanks!!!

Could you describe what you want to achieve? Maybe we could add an system solution.

I'm sending auth key with each request ... middleware is sorting authentication and forwarding user's object to the controller. I would like to inject model and pass some variables from user's object in the constructor...
final class TestController extends BaseApiController {
    public function __construct(SomeModel $model)
    {

       // HOW TO ACCESS REQUEST's attributes here?
       // $user = $request->getAttribute('user');

        $this->someModel = $model;
        $this->someModel->setSomeVar($user->foo); // How can I read user's object here???
    }

    /**
     * @Path("/test")
     * @Method({"GET"})
     */
    public function list(ApiRequest $request, ApiResponse $response)
    {
       $user = $request->getAttribute('user'); // here I can get user passed by middleware

        // Workaround - I can call setter here - but why to repeat it in every method??? It can be already done in BaseApiController ;)
       // $this->someModel->setSomeVar($user->foo);
        $data = $this->someModel->getData(); // this should return data based on "someVar"
        return $response->withEntity(ArrayEntity::from($data));
    }
}

Hope, it describes what I want to achieve.
Regards,
Martin


Update info about the Epimetheus client, and add a link to the web app

Merged as 12c50da194743c24bc037dc1dd14617dadf6110d. I removed the link to your web client, because I don’t want to advertise entering your Pandora credentials into a random web app.


Add ability for the emulator to send a location entity

Related to the WebChat's ability to render it :) https://github.com/Microsoft/BotFramework-WebChat/issues/232

Closing as a WebChat consideration


Bridge via metamask issue

User has tried to bridge from polygon to bnb via metamask. Transaction manager has incoming tx on polygon side but doesn't have outgoing tx. https://polygonscan.com/tx/0xa3768c6036e1da4c41b852d29c363221681856f4734325e46b5e158a5eb033ff

Also transaction didn't appear on connextscan

upd
NVM
it was v1 tx and the router is stuck (I didn't find it in explorer)


Rust SDK: add friendly constructor/builder for OutgoingRequest

Per https://github.com/fermyon/spin/blob/b45feb8e91afe5625a2de19e1904eec10ebbc936/examples/wasi-http-rust-streaming-outgoing-body/src/lib.rs#L99:
    let outbound_req = spin_sdk::http::OutgoingRequest::new(
        &spin_sdk::http::Method::Get,
        None,
        Some(&spin_sdk::http::Scheme::Https),
        Some("dioxus-test-ninaynoi.fermyon.app"),
        &spin_sdk::http::Fields::new(&[]),
    );

Could we add a constructor or builder that takes a URL, and maybe a Method instead of &Method?  It feels a bit unwieldy right now (though users can always create their own wrappers).

https://github.com/fermyon/spin/pull/1977

@lann I might be misunderstanding - we already had builders for Request, although your new ones are nicer for sure - this issue was specifically about OutgoingRequest.  Are you saying to no longer use OutgoingRequest?  (My specific interest was streaming request bodies.)  Or is the idea that we could construct a Request with the friendly builder and then .into() it to get an OutgoingRequest?

Ah no the linked PR doesn't help with streaming request bodies. The example you linked just streams the response body, and you can mix-n-match a non-streaming Request with a streaming response.

I'm not explaining myself very well I fear.

I want to stream request bodies.
To do this, I need an OutgoingRequest.
The constructor for OutgoingRequest is not terribly friendly.

I linked the example to try illustrate the third item not the first one, and was trying to clarify if #1977 helps with said third one.  My mention of streaming was only to explain why I (thought I) needed an OutgoingRequest rather than a Request.
Sorry for the confusion.


doc: fix link issue

What type of PR is this?

/kind documentation
What this PR does / why we need it:
the original link will route to the top of the page

with fixing , it can jump to correct place

Tested on MacOS, both on Google Chrome and Microsoft Edge
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

/ok-to-test

/cherry-pick website

/release-note none

/release-note-none


Credential helper support in kaniko build

... just ran smack into this one :|

I think kaniko needs to release?

https://gcr.io/kaniko-project/executor claims the image was released 2 hours ago, and has many builds since that PR was merged.
/cc @priyawadhwa

https://github.com/GoogleContainerTools/kaniko/tree/v0.1.0 ?

It looks like gcr.io/kaniko-project/executor:latest isn't the same as when I build it locally @ HEAD
We use build triggers to deploy the image, and I think something went wrong there because the commit tagged version of the image gcr.io/kaniko-project/executor:8f71b7fb260cd08f1acd9b7854df9a82a444382c is correct, but gcr.io/kaniko-project/executor:latest, which is built via
docker tag gcr.io/kaniko-project/executor:8f71b7fb260cd08f1acd9b7854df9a82a444382c gcr.io/kaniko-project/executor:latest

is different.
I reran the trigger and they seem to be the same now, so hopefully that should fix this issue. Unfortunately I'm not sure why it happened :(

Still seeing this behaviour. I may be looking at a different bug on Kaniko though.

@jchesterpivotal , could you comment on that issue with more some more information? The error you're seeing and the Dockerfile you're trying to build would be really helpful.


Add two scripts for training own dataset.

Add two scripts help to train own dataset.
The data_to_coco.py can be used for transferring own data to coco format.
The edit_model_weight.py can be used for editing the model weight downloaded from MODEL_ZOO.md for own data training in a simple way.
All the usages have been described in the code.

Thanks for your contribution.
Could you please elaborate the purpose of edit_model_weight.py ?
Also, as a reminder, one could just build a roidb for custom data according to data format. No need to first convert it to coco format.

Thanks for your contribution.
Could you please elaborate the purpose of edit_model_weight.py ?
Also, as a reminder, one could just build a roidb for custom data according to data format. No need to first convert it to coco format.

The edit_model_weight.py is used for converting weight in MODEL_ZOO.md to be suitable for training for different networks (which only changed a little for their datasets).
Though we can directly convert to roidb file, in the test stage, we still need the coco style annotations.

Would you mind move your files to utils/contrib instead of utils since these scripts address more specific tasks.

Would you mind move your files to utils/contrib instead of utils since these scripts address more specific tasks.

OK, that's fine.


K3s Prometheus unable to scrape worker nodes.

Hi 👋
This repo is fantastic to see and so far its been brilliant.
So far I followed the Pre Requisite steps to get setup:
make vendor
make
kubectl apply -f manifests

Here's a snapshot of my cluster after applying all of the manifests

Everything looks great!
Unfortunately though I am unable to access the ingress gateways as suggested alertmanager..nip.io, prometheus..nip.io, grafana..nip.io. To get around this for now I thought I'd check out prometheus first via port-forward.
To do that I run: kubectl -n monitoring port-forward prometheus-k8s-0 9090:9090
When I check prometheus targets I see lots of similar errors to this one:

The majority of the errors are:

context deadline exceeded
IO Timeout

Details of my hardware:
NAME               STATUS   ROLES    AGE   VERSION
worker-rpi-3Bplus   Ready    <none>   22h   v1.17.3+k3s1
worker-rpi-2       Ready    <none>   22h   v1.17.3+k3s1
master             Ready    master   22h   v1.17.3+k3s1
worker-rpi-4       Ready    <none>   22h   v1.17.3+k3s1

master = Raspberry Pi 4 /w 4GB RAM
worker-rpi-4 = Rapsberry Pi 4 /w 4GB RAM
worker-rpi-2 = Raspberry Pi 2 B+
worker-rpi-3Bplus = Raspberry Pi 3 B +
All running docker version: 19.03.8 Client & Server.
If there's any further detail you need me to supply, I'll dig that out for you.
There also may be a gap in my knowledge here / potential further PEBCAC. Any advise / help would be much appreciated!

Oh and apologies I left out my network policy that exists in the default namespace. If that is required too for any diagnostics
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: default
spec:
  podSelector: {}
  policyTypes:
  - Ingress
  - Egress

After reading some of the previous issues. I thought I'd share all the exporters that haven't registered with prometheus:

monitoring/alertmanager/0 (0/1 up)
monitoring/coredns/0 (0/2 up)
monitoring/grafana/0 (0/1 up)
monitoring/kube-state-metrics/0 (0/1 up)
monitoring/kube-state-metrics/1 (0/1 up)
monitoring/kubelet/0 (0/4 up)
monitoring/kubelet/1 (0/4 up)
monitoring/node-exporter/0 (1/4 up)  (Master up, but none of the workers)
monitoring/prometheus-operator/0 (0/1 up)
monitoring/traefik/0 (0/1 up)

Hi @james-millner, most problems I've seen related to these messages is where Prometheus can't or times-out scraping the endpoints.
I have two scenarios here, one a VirtualBox VM with two network interfaces and the first is not the exposed one. On this VM, I have similar problems as you and I even commented on a similar problem with K3s (https://github.com/rancher/k3s/issues/1216).
On the second scenario, I took an ARM64 board and deployed latest K3s (https://github.com/rancher/k3s/issues/1216) and my updated stack with latest vendor libs and some adjustments.
Everything went well:

Take a look if this multiple NIC scenario is similar or try with just one node freshly installed to begin with debugging.

Hi Carlos,
Sorry for the delay in getting back to you.
Well I've had some success! It appears to be perhaps a dodgy node within my cluster but I cannot fully say - this is what it appears to be 🤔 .
I uninstalled K3s completely and only re-installed it on the Raspberry Pi 4's & Raspberry Pi 3 B+.
I also installed K3s with the docker flag overriding containerd and WHAM, it all works perfectly 👌. Thank you so much for this fantastic repository & contribution!

To add to the detail though I removed the Raspberry Pi 2 B+, this seemed to be the troublesome one.

Maybe the Rpi2 has some network Kernel module not compiled or something like that.
Also it should work without the Docker parameter (using internal containerd runtime). At least here it worked fine.
Glad you got it working!


Update LICENSE

updated year in license

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

okk @prateekpandey14  :+1: