Add static type annotations

I am having trouble with using Dask in a project that uses PyRight because Dask does not use static type annotations/
Take, da.from_array, for example:
https://github.com/dask/dask/blob/b2ec1e1a2361db1e269ba86c7c59d3f6df70a02d/dask/array/core.py#L3307-L3317
Or array.rechunk:
https://github.com/dask/dask/blob/b2ec1e1a2361db1e269ba86c7c59d3f6df70a02d/dask/array/rechunk.py#L268-L275
PyRight complains if you use anything but a str for chunks:

Argument of type "tuple[Literal[1], Literal[-1], Literal[-1]]" cannot be assigned to parameter "chunks" of type "str" in function "from_array"
  "tuple[Literal[1], Literal[-1], Literal[-1]]" is incompatible with "str"

This happens because in from_array and rechunk, chunks="auto" infers to a str type.
Is there an awareness of this problem? Is there a known solution? If not, is there a plan to fix this?

We are aware of the issue but there is currently no plan on addressing this from within the currently active contributors. We currently have other (higher) priorities to focus our effort on. Contributions are welcome though if you are interested in helping out.

We've been adding type annotations continuously over the past 1-2 years but the code base is very large and ensuring that everything is typed is very difficult. This is rather an incremental process. As was already mentioned, contributions are welcome and I guess this is a comparatively easy topic for a first couple of contributions.
We're using mypy for type checking and the modules that are already fully typed are listed here (not many yet) https://github.com/dask/dask/blob/b2ec1e1a2361db1e269ba86c7c59d3f6df70a02d/pyproject.toml#L180-L184
FWIW we're already much further along for dask/distributed https://github.com/dask/distributed/blob/66ced13b33aeafe0d684b4424364c69f0b5a0d43/pyproject.toml#L201-L212

@sam-goodwin (or anyone else having issues with type hinting) - are there any specific functions causing problems for you assign from array.rechunk? I'd be up for spending a little time working through some type annotations at some point - this issues currently labelled 'Add static type annotations' implying for the whole project, which is a great goal, but would be awesome to have a couple priority areas to target.

Hi @benrutter, I agree that we don't need to take on the whole repo and there is plenty of low hanging fruit. The errors I am running into are:

da.from_array - chunks is inferred as a str
array.rechunk - chunks is inferred as a str
dd.from_delayed returns DataFrame | Series and will always require a cast. Not sure how to fix that other than adding helpers.
map_blocks seems to not behave properly as a method in the eyes of pyright:

da.from_zarr(core.core_img).map_blocks(
    segment_tissue,
    dtype=np.uint8,
    drop_axis=0,
    downsample_factor=tissue_masks_params.downsample_factor,
)

Error:
Argument missing for parameter "func"

If you add explicit func=segment_tissue, then get an error about self:
Argument missing for parameter "self"

Perhaps something wacky with @wraps:
    @wraps(map_blocks)
    def map_blocks(self, func, *args, **kwargs):
        return map_blocks(func, self, *args, **kwargs)

map_blocks is of the following type. Looks like it is no longer recognized as a method or something.
map_blocks: _Wrapped[(func: Unknown, *args: Unknown, name: Unknown | None = None, token: Unknown | None = None, dtype: Unknown | None = None, chunks: Unknown | None = None, drop_axis: Unknown | None = None, new_axis: Unknown | None = None, enforce_ndim: bool = False, meta: Unknown | None = None, **kwargs: Unknown), Unknown, (self: Array, func: Unknown, *args: Unknown, **kwargs: Unknown), Unknown] | Any

Hi all - I'd like to take this on as my first PR (linked above).
@sam-goodwin, do you still feel like addressing these four functions would suffice for now?

@jason-trinidad since then I would add map_overlap to the list. I think that's enough to get started and feel out the complexity of the task. Thanks for taking it on!

Hi @sam-goodwin - I was unable to replicate the issue with da.from_zarr.map_blocks. I added type annotations to the function, which might help. Would you be able to clone the branch and see if it solves your issue?
I'd also love to get an reviewer's opinion on my approach re: ignoring mypy errors. Perhaps @fjetter or @phofl could take a look?


Narrow down needed modules

Hi
I tried to narrow down the actually needed modules to run the assessment tool. Since the Az and Graph Modules include a large amount of submodules, the install can take a while even though not all submodules are strictly required. I tried to identify every needed module using the AST of all scripts, which resulted in these:
Az.ApplicationInsights
Az.Compute
Az.CosmosDB
Az.KeyVault
Az.Monitor
Az.MySql
Az.Network
Az.OperationalInsights
Az.PostgreSql
Az.Resources
Az.Security
Az.Sql
Az.Storage
Az.Websites

ExchangeOnlineManagement

Microsoft.Graph.Applications
Microsoft.Graph.Authentication
Microsoft.Graph.DirectoryObjects
Microsoft.Graph.Groups
Microsoft.Graph.Identity
Microsoft.Graph.Security
Microsoft.Graph.Users

Microsoft.Graph.Beta.Identity

Microsoft.Online.SharePoint.PowerShell

MicrosoftTeams

PoShLog

Obviously this list will change as different tests get added but I believe keeping the modules down to a minimum would be a good idea.

Hello,
Thank you for your submission
Could you test this out in the next release for me which modules are required? Then I can add them to the list. I am planning to release that somewhere in May hopefully if things are working out.
Thank you. :)
~LvdW

Yes, that would not be an issue. I will try it out in the next release

I will release the Production version today. If you have time to test it out for me which modules are required i'll change them in v2.3 and release that, :)
~LvdW

Hi, yes I will test it tomorrow or the day after that and will let you know
then.
Leonardo van de Weteringh @.***> schrieb am Mo., 6. Mai
2024, 11:31:

I will release the Production version today. If you have time to test it
out for me which modules are required i'll change them in v2.3 and release
that, :)
~LvdW
—
Reply to this email directly, view it on GitHub
https://github.com/asterictnl-lvdw/M365SAT/issues/34#issuecomment-2095556793,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHCC3D46S7AOUAX3VVHDSDLZA5EYZAVCNFSM6AAAAABGU6XCQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJVGU2TMNZZGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

It has been released so feel free to test it out when you are ready <3

It seems that the needed modules have stayed the same, so the install instructions could be narrowed down to the list I reported initially. For the test I looked at the source of all functions that are used anywhere in the code (Get-Command). To be very sure I would need to now test the reverse, where I do a clean setup and only install the mentioned modules and see what happens.
In the analysis I also saw, that quite a few tests still rely on Exchange-Powershell commands (e.g. Get-Mailbox). I would assume that there would be issues using these commands, since the modules are no longer supported? I can get you a list of all commands that I found, should I open a separate issue for this or is this known?

Thanks for the information. My tests with just the modules installed where not that successfull. It is hard to exactly pin it down, since my test tenant setup is not really ideal. I currently don't have a azure subscription attached and will get a lot of error messages for the azure connections.
I will try around some more and also change the setup. I will also try to install the Az package as a whole. I was trying to break that package down if possible since it is so large.
I had some success with finding the needed Graph scope using the Find-MgGraphPermission command.

I was already afraid of that breaking down the modules would cause issues.
I do recommend you testing it with an azure subscription as well since then you can see if there will be errors and such. If you do not have an azure subscription, you can use the new parameters to only scan on Microsoft 365 environment instead of Azure as well. Microsoft 365 environment should only have Entra ID things and no other things that would require an azure subscription as additional resources need to be created for that.
I will look forward to your findings.
~LvdW

I've tried it out with the whole Az and Graph modules installed and still seem to get the same errors. I'm now not quite sure on how to best go forward, since I can't pin it down at the moment what the actual underlying issue is.
For example this is one of the error messages that I get after starting the assessment:
Get-MgDirectoryRole : Method not found: 'Void Microsoft.Graph.Authentication.AzureIdentityAccessTokenProvider..ctor(Azure.Core.TokenCredential, System.String[],
Microsoft.Kiota.Authentication.Azure.ObservabilityOptions, System.String[])'.
At C:\Users\WDAGUtilityAccount\Downloads\M365SAT-production\inspectors\M365\Azure\CIS30\E3\L1\CISMAz113.ps1:45 char:3
+         $globalAdminRole = Get-MgDirectoryRole -Filter "RoleTemplateI ...
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Get-MgDirectoryRole_List], MissingMethodException
    + FullyQualifiedErrorId : Microsoft.Graph.PowerShell.Cmdlets.GetMgDirectoryRole_List

After this it seems that the error are cascading, since some neccessary infos can't be read from the tenant. I tried looking online for this error message, but could not get it to work from what I found. I will try further, but it will take a bit more time.

@M-gre
Thank you for sharing. It seems that the module wasn't deleted before the new release. This has been cooked into the new CISMOff113 now which has the correct script. You can delete that .ps1 script as that one has been replaced by a different one. :)
Do test it out once again and let me know if you stumble upon weird errors. :)
~LvdW

Hi, sorry for the late response. I found mostly three types of errors.
The first is in regards to the Exchange modules, where the commands are not recognized. Here an example:
[04:59:59 ERR] An error occured on line 43 char 21 : 		$TransportRules = Get-TransportRule | Where-Object { $_.Redirec
tMessageTo -ne $null } | Format-Table Name, RedirectMessageTo

System.Management.Automation.CommandNotFoundException: The term 'Get-TransportRule' is not recognized as the name of a
 cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify
 that the path is correct and try again.
   at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception e
xception)
   at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)

The second and third are for the Sharepoint and Teams inspectors, where the there are problems with the authentication. The commands can't be run, because the Connect-SPOService and Connect-MicrosoftTeams are not established:
[05:00:05 WRN] The Inspector: C:\Users\User\Downloads\M365SAT-production\inspectors\M365\Sharepoint\CIS30\E3\L2\CISMSp
732.ps1 was terminated!
[05:00:05 ERR] An error occured on line 43 char 21 : 		$ShareSettings = (Get-SPOTenant).ConditionalAccessPolicy

System.InvalidOperationException: No connection available. Use Connect-SPOService before running this CmdLet.
   at Microsoft.Online.SharePoint.PowerShell.BaseSPOCmdlet.get_Context()
   at Microsoft.Online.SharePoint.PowerShell.GetSPOTenant.Execute()
   at System.Management.Automation.CommandProcessor.ProcessRecord()

[05:00:11 WRN] The Inspector: C:\Users\User\Downloads\M365SAT-production\inspectors\M365\Teams\CIS30\E3\L1\CISMTm812.p
s1 was terminated!
[05:00:11 ERR] An error occured on line 42 char 3 : 		$MicrosoftTeamsCheck = Get-CsTeamsClientConfiguration -Identity
Global | Select-Object AllowEmailIntoChannel

System.UnauthorizedAccessException: Session is not established, run Connect-MicrosoftTeams before requesting access to
ken
   at Microsoft.Teams.ConfigApi.Cmdlets.CmdletHostWrapper.GetAccessToken(String appId, String scope)
   at Microsoft.Teams.ConfigApi.Cmdlets.SessionStateStore.GetLoginInfo()
   at Microsoft.Teams.ConfigApi.Cmdlets.SessionStateStore.GetSessionState()
   at Microsoft.Teams.ConfigApi.Cmdlets.FlightingUtils.GetFlightingCommandInfo(Dictionary`2 boundParameters, String re
motingCommand, OverrideFlightMode overrideFlight)
   at Microsoft.Teams.ConfigApi.Cmdlets.TrpsPSCmdlet.TryGetFlightedApi(FlightingCommandInfo& flightedCommand, List`1 p
ipelineInputKeys)
   at Microsoft.Teams.ConfigApi.Cmdlets.TrpsPSCmdlet.ProcessRecord()
   at System.Management.Automation.CommandProcessor.ProcessRecord()

@M-gre
Please share the command you are trying to use in M365SAT-Tester or the command you are executing. Are you getting errors already in the first process when trying to connect to the modules? Also are you using PowerShell 7 or are you using the built-in Powershell 5.1?
The 2nd one happens when you did not successfully establish a connection with the SPO-Module and the same with the 3rd one.
The way of connecting to all modules has been done in a way to make sure all modules are working properly. If you change around the order of connecting to modules you will stumble upon errors and things not working. It happens if you connect to all modules you have to do it in this order:

Connect-AzAccount
Connect-Graph
Connect-ExchangeOnline
Connect-IPPSSession
Connect-SPOService
Connect-MicrosoftTeams

The process itself seems to be a bit sluggish sometimes. I really wish I can optimize it where possible, but it happens that it generates a lot of errors when you connect something before something as there are dependencies.
~LvdW

Sorry forgot to mention what I actually did for the testing. This is using Powershell 5.1 from a fresh VM where I installed the needed modules and the project. I only used the M365SATTester script, where my run command is as follows Get-M365SATReport -OutPath "C:\Out" -Username "admin@tenant" -EnvironmentType M365 -BenchmarkVersion "Latest" -Modules "All" -LicenseMode "E3" -LicenseLevel "All" -reportType "HTML" -AllowLogging "Warning" -LocalMode -SkipChecks. Therefore the order of connecting to the modules should be correct.
When I run the command I get two authentication requests, if I recall correctly. One in the browser and one in the embedded login screen. I could try to open the sessions first, before running the tester script, or would this cause other issues?
The logs for the start of the script are as following:
[04:59:54 WRN] Program Started!
05/10/2024 04:59:54: Checking Existence SkipChecks Parameter...
05/10/2024 04:59:54: Initiating Connections...
Connecting to Microsoft Azure Powershell...
Connected to Microsoft Azure Powershell!
Connecting to Microsoft Graph Powershell...
Connected to Microsoft Graph Powershell!
Get-MgOrganization : Method not found: 'Void
Microsoft.Graph.Authentication.AzureIdentityAccessTokenProvider..ctor(Azure.Core.TokenCredential, System.String[],
Microsoft.Kiota.Authentication.Azure.ObservabilityOptions, System.String[])'.
At C:\Users\User\Downloads\M365SAT-production\core\m365connectors\Connect-MicrosoftGraph.ps1:27 char:3
+         $OrgName = (((Get-MgOrganization).VerifiedDomains |  Where-Ob ...
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Get-MgOrganization_List], MissingMethodException
    + FullyQualifiedErrorId : Microsoft.Graph.PowerShell.Cmdlets.GetMgOrganization_List

05/10/2024 04:59:55: Getting Inspectors...
05/10/2024 04:59:55: Executing Inspectors in SingleThread Mode...

I can't see any connection requests for other modules.

Also just tried out all the connection commands you listed on their own. I could connect to all services by themselves just fine.

@M-gre ,
Ah, I see it here. It breaks once it raises an exception and goes straight to the inspectors. That should not be happening. I will make a failover validation to make sure the script will exit if such error occurs.
Can you verify the following:

Do you have the Microsoft.Graph (normal) module installed?
Do you have the Microsoft.Graph.Beta module installed?
When connecting to graph. Could you run Get-MgOrganization to check if you actually get something back? It seems that it could not execute Get-MgOrganization as it might be part either of a module in Microsoft.Graph(.Beta) or that something has gone wrong.

Can you also verify what happens if you fully install Microsoft Graph and the Beta modules fully with the script in the README.md? I want to see if it is a configuration issue or something else.
Thank you.
~LvdW

At the moment for the testing I have only installed the reduced modules for both Graph normal and beta. When I run Get-MgOrganization I get the error that was also seen in the log:
Get-MgOrganization : Method not found: 'Void
Microsoft.Graph.Authentication.AzureIdentityAccessTokenProvider..ctor(Azure.Core.TokenCredential, System.String[],
Microsoft.Kiota.Authentication.Azure.ObservabilityOptions, System.String[])'.
At line:1 char:1
+ Get-MgOrganization
+ ~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Get-MgOrganization_List], MissingMethodException
    + FullyQualifiedErrorId : Microsoft.Graph.PowerShell.Cmdlets.GetMgOrganization_List

From what I could see the command should be a part of the Graph.Identity.DirectoryManagement module that is installed.
I will try try out reinstalling the specific module and if that doesn't fix it, the general module (first normal, then beta).

Okay, so reinstalling the specific module (DirectoryManagement) with -Force allowed me to get a correct response from Get-MgOrganization. But if I then run the Tester script I still get errors for the same thing:
[11:55:22 WRN] Program Started!
05/14/2024 11:55:22: Checking Existence SkipChecks Parameter...
05/14/2024 11:55:22: Initiating Connections...
Connecting to Microsoft Azure Powershell...
Connected to Microsoft Azure Powershell!
Connecting to Microsoft Graph Powershell...
Connected to Microsoft Graph Powershell!
Get-MgOrganization : Method not found: 'Void
Microsoft.Graph.Authentication.AzureIdentityAccessTokenProvider..ctor(Azure.Core.TokenCredential, System.String[],
Microsoft.Kiota.Authentication.Azure.ObservabilityOptions, System.String[])'.
At C:\Users\User\Downloads\M365SAT-production\core\m365connectors\Connect-MicrosoftGraph.ps1:27 char:3
+         $OrgName = (((Get-MgOrganization).VerifiedDomains |  Where-Ob ...
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Get-MgOrganization_List], MissingMethodException
    + FullyQualifiedErrorId : Microsoft.Graph.PowerShell.Cmdlets.GetMgOrganization_List

05/14/2024 11:55:47: Getting Inspectors...

I also get the same error if I try to run ``Get-MgOrganization` right after starting and quitting the Tester script. If I close the PS session and restart a new one I can run it just fine again.

@M-gre ,
I unfortunately cannot reproduce the issue, but I do know that this error is based on the Microsoft.Graph(.Beta) module.
When you are trying to run the M365SAT-Tester make sure you are NOT connected to any of the modules yet, connecting to them in advance will cause issues with the process and makes you unable to execute the audit properly.
Try to close all PowerShell windows and open one as admin and execute the M365SATTester. Then test afterwards if the script works again. Because it seems that Microsoft Graph does not get connected correctly and that there is still a dependency somewhere in the process.
As mentioned, try remove the Microsoft Graph modules and reinstall them by running these two commands:
# Microsoft Graph
Install-Module Microsoft.Graph -AllowClobber -Force
# For Microsoft Graph beta
Install-Module Microsoft.Graph.Beta -AllowClobber -Force

This was mentioned in an early version of Microsoft Graph as it causes issues when you do not use the AllowClobber to install them alongside.
https://github.com/microsoftgraph/msgraph-sdk-powershell/releases/
Please let me know if that works for you. I will change it in the README.md as well and add for the Microsoft Graph modules the -AllowClobber -Force parameters to make them work properly
Thank you.
~LvdW

Hi, I wasn't able to test this out until now.
AllowClobber was the thing that was missing. I can run the M365SATTester without issues now. Next step would be to try this option with the individual modules once again. I will let you know what I find out, but it may take some time again for me to come around to more tests. Thank you for the support in getting the script running :)

This is already great! I will test this with the next upcoming release so see if ever module is working with the new benchmark.
If everything is in order I will push the new release to alpha so it can be tested.
~LvdW

I have implemented the Microsoft.Graph change if you still can find which Graph modules we do not need. Then I can check if that does impact. I think the best thing is that the permissions already are broken down. Eventually I might have to add extra permissions in case new things come in the next benchmark version.
~LvdW

Hello @M-gre ,
Once I have pushed the update to master please test it again, if everything is OK I will close this issue.
~LvdW

I have tested it on Alpha and pushed it towards Master. It works as expected. This issue has been resolved and is now closed.
~LvdW


fix the most recent set of CI problems

gotta love this stuff

@greglandrum  it looks like the Mac build got set to "warnings are errors"

@greglandrum it looks like the Mac build got set to "warnings are errors"

yes, we added that for the linux and mac builds in #6675


Enable figures in the tfprof README.md

I don't know if excluding the figures from the tfprof README.md was intentional or not and I could not find any reasoning why they are excluded.
If there is a reason, then ignore the PR.

Can one of the admins verify this patch?

The links should be "tensorflow/g3doc/..." instead of "g3doc/..."

LGTM. It's a syntax difference between internal/external doc.

Jenkins, test this please


Yellow LED incorrect package

this part emits downward, into the PCB and cannot be mounted in the upward-facing orientation

tested solution with OSRAM component LY T68F-T2V2-35-1-20-R18-Z.  Still needs to be implemented in schematic/PCB


linter: map rules of hooks to react-hooks

          BTW, will linter configurations be also supported?

{
  "rules": {
    // ...
    "react-hooks/rules-of-hooks": "error",
    "react-hooks/exhaustive-deps": "warn"
  }
}

https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks#custom-configuration

If we need to change like this, might there be compatibility issues...?
{
  "rules": {
    // ...
    "react/rules-of-hooks": "error",
    "react/exhaustive-deps": "warn"
  }
}

Originally posted by @leaysgur in https://github.com/oxc-project/oxc/issues/3315#issuecomment-2115376471

Can we have it in such a way that both the react and react-hooks alias work? this way we can ease the migration while providing easy-to-understand names for newcomers with no eslint experience.


Various tweaks: rename default config file to dune-get and help fixes

Why this change? I think the duniverse/ folder name and the tool name should be consistent with it.

I quite like the vendor directory remaining duniverse/ as a quirky ocaml name, even when merged into dune :-)
The intention of changing the config file is purely to get it aligned with dune conventions (dune-project, dune, dune-get, ...).  I expect that we will eventually drop dune-get and directly modify dune-project in order to have metadata all in one place. See for example #31 where we need more fine-grained information from the overall dune-project files in the future.

I'm also ok with leaving the prototype tool named duniverse for the moment @NathanReb.  I just wanted to get the artefacts on disk a bit more natural (i.e. no .sxp extensions) as I'd like duniverse to self-bootstrap.


ExtModule needs utils like BlackBox has

Type of Issue: Code completeness, Testers support
BlackBoxUtils provide an annotation system for retrieving blackbox verilog code
from resource files. Specifically the ability to declare in-line verilog and verilog as resource.
ExtMode does not provide a similar mechanism.
Impact
Lack of this support leads to ad hoc system for placement of verilog code, and makes
writing libraries that rely on black boxed verilog more complicated. It also complicates
testers implementation of black box testing.
Development required

Add ExtModule utils similar to BlackBoxUtils
Make sure Treadle and testers take advantage of these tools
Testers2 and Treadle and possibly testers need to be updated to make it possible to write tests with black boxes that work with multiple backends

Use case
If we do not provide consistent implementation tools and decent documentation on how to use them. The ecosystem ends up with uncontrolled mechanism that are likely to break as we issue new code.

Thoughts about maybe writing this to be less mutable (addResource / setResource / setInline) and more declarative (maybe we could have class InlineExtModule / class ResourceExtModule(resourcePath) - or making ExtModule directly take a resource path as an optional constructor parameter) or Chisel-like (not sure what this would look like, since the ExtModule body only has IO defs)? The semantics probably are fine as-is, but the syntax I think could be more uniform.
For inline Verilog, would it make sense to have that as a feature that could be used in a regular module (like inline assembly in C)? It would seem that if you're writing large chunks of Verilog, that should go into a .v file, and if you're writing small chunks, you maybe just want to (or even need to) inline it into the instantiating module.

Done.


Fix Hammerhead::Configuration test spec

Prompted by a missing text fixture, I had to disable a few tests.
Change how this class works so that I can inject a configuration into it. This should make testing easier, and remove the need to have the configuration file ignored.

By moving the setting of Configuration.config out of initialze and into its own method I was able to fix the test spec.


Homepage designs

Designing a new homepage for ICDS that exemplifies how we use the design system effectively.

Waiting to refine this with @GCHQ-Designer-777, are we also going to need a ticket to allow a custom colour or a new variant to Hero?


Improve Mobile Responsiveness for Android Devices

Describe the issue
Users accessing the chat app on Android devices have to switch their browser to desktop mode to view the website properly. The current layout does not adjust to mobile screens, resulting in a suboptimal user experience.
To Reproduce
Steps to reproduce the behavior:

Open the chat app on an Android device.
Observe the layout of the website.
Notice that content is not properly displayed, requiring desktop mode for full visibility.

Expected behavior
The chat app should be fully responsive and display correctly on Android devices without needing to switch to desktop mode. The layout should automatically adjust to fit various screen sizes, including mobile screens.
Screenshots
If applicable, add screenshots to help explain the issue. (Include any screenshots that demonstrate how the app appears on an Android device and how it differs from the desktop view.)
Desktop (please complete the following information):

OS: [e.g. Windows 10]
Browser: [e.g. Chrome, Firefox]
Version: [e.g. 91.0]

Smartphone (please complete the following information):

Device: [e.g. Samsung Galaxy S21]
OS: [e.g. Android 11]
Browser: [e.g. Chrome]
Version: [e.g. 91.0]

Additional context

The issue affects only mobile users who need to see the website in desktop mode to get the correct layout.
We plan to use Tailwind CSS to improve responsiveness without altering the main codebase.

Hi can you assign me? I would like to work on this issue.

@MichalT106  Hey Michal, I'm currently working on another project. I'll message you later when I have time. Thanks!


[In progress] Network - Search and filters

A request from Suzanne during the demo of October 2nd to have them ready for the launch of the IRC.

Hi Emilie, thank you for pointing this out. I know this request, but unfortunately, I can't guarantee this will be ready by November 21 since we are facing challenges with other functionalities. Still, if we have spare time, we'll prioritize this.

Hi Carla,
Do you think we will still be able to show the search and filters on Figma in the video ? I think it might be a way to show them.

Hi Emilie, I'm not sure; changing between the platform and Figma during the video could be difficult. We can still present the more juicy part of the module: the list of projects and organizations, their detailed info with the diagram, and their location on the map.

Hi Carla,
Let's discuss this on monday at 2PM: What we will be able to do with the new constraint of the date and share it to Suzanne at 3 the same day.
Even on my side we have to hurry for scientific evidence.
Thanks

This is an important one. We should have it ready at least for the annual meeting.

Hi Emilie, just to let you know that, for consistency, I've changed the priority of this request to "Medium priority" for now. This falls behind the rest of the functionalities agreed for version 0.

Hello Carla, We have a look at the filters with Mathieu this morning. Why did you change the place of the filter "project/organization"? It was nice to have it on top of the list of results. Plus, it would have helped to display only the relevant filters available (if we select "projects" for instance). Is it possible to keep them the way they were and just had their relevant colors?

Hi Emilie,
This decision was made as part of the design refinement applied to make the design of the different modules consistent and clean.
We can revisit this decision later when we get feedback from users. Does this sound acceptable to you?

Hello Carla, we have to discuss how we will organize the period after v1.

Hi Emilie, yes, we need to. As we said, we will do that after the annual meeting.
Please notice that I've created a separate issue for the feedback you provided about the projects/organizations filtershttps://github.com/Orcasa-Platform/orcasa/issues/92.
I'm closing this issue since the filters are already implemented. Please, if you have more feedback on this, create separate issues to keep their scope clear so that we can prioritize them accordingly.


small change for DataIter's Iterator implementation and add DataPack

There have been too many classes in this single file. Please consider to separate, just like what we did for optimizers.


Host unreachable

Hi, I would like to run a Sia host and provide 200 GB storage, but after successfully forwarding 9982 port to 12736 (which is open you can check it with data below) it still looks like not reachable for your network
Is it because of 9981 port ? Does it need to be forwarded ? If yes, how to announce it will be working on other port than 9981 (i can't open this port) like I've done with parameter "netaddress"
Here's what hostdb responds on my pubkey:
{
  "entry": {
    "acceptingcontracts": false,
    "maxdownloadbatchsize": 0,
    "maxduration": 0,
    "maxrevisebatchsize": 0,
    "netaddress": "<IP_ADDRESS>:12736",
    "remainingstorage": 0,
    "sectorsize": 0,
    "totalstorage": 0,
    "unlockhash": "000000000000000000000000000000000000000000000000000000000000000089eb0d6a8a69",
    "windowsize": 0,
    "collateral": "0",
    "maxcollateral": "0",
    "contractprice": "0",
    "downloadbandwidthprice": "0",
    "storageprice": "0",
    "uploadbandwidthprice": "0",
    "revisionnumber": 0,
    "version": "",
    "firstseen": 123956,
    "historicdowntime": 0,
    "historicuptime": 0,
    "scanhistory": [
      {
        "timestamp": "2017-09-20T23:03:11.338505478Z",
        "success": false
      },
      {
        "timestamp": "2017-09-20T23:13:11.338505718Z",
        "success": false
      },
      {
        "timestamp": "2017-09-20T23:26:35.22026634Z",
        "success": false
      },
      {
        "timestamp": "2017-09-21T09:19:30.609755122Z",
        "success": false
      }
    ],
    "historicfailedinteractions": 0,
    "historicsuccessfulinteractions": 0,
    "recentfailedinteractions": 0,
    "recentsuccessfulinteractions": 0,
    "LastHistoricUpdate": 124025,
    "publickey": {
      "algorithm": "ed25519",
      "key": "wOiqW9HwjRKmTztqaZ0LW2dRuFr3CPUA0hDz901TAIg="
    },
    "publickeystring": "ed25519:c0e8aa5bd1f08d12a64f3b6a699d0b5b6751b85af708f500d210f3f74d530088"
  },
  "scorebreakdown": {
    "score": "636716726738555069459612651786039640156023011741126538254320621490478",
    "conversionrate": 0.000000000006687795395729862,
    "ageadjustment": 0.0078125,
    "burnadjustment": 1,
    "collateraladjustment": 1,
    "interactionadjustment": 0.6114957082084552,
    "pricesmultiplier": 1,
    "storageremainingadjustment": 0.000244140625,
    "uptimeadjustment": 0.215671155821681,
    "versionadjustment": 0.000025312246875000004
  }
}

and what i have when calling /host
{
  "externalsettings": {
    "acceptingcontracts": true,
    "maxdownloadbatchsize": 17825792,
    "maxduration": 25920,
    "maxrevisebatchsize": 17825792,
    "netaddress": "<IP_ADDRESS>:12736",
    "remainingstorage":<PHONE_NUMBER>00,
    "sectorsize": 4194304,
    "totalstorage":<PHONE_NUMBER>00,
    "unlockhash": "dc43f41730a4b879026a2d048e220f27dcfe78f86e36a023a5cf8c70abf34303d8cc4a208930",
    "windowsize": 144,
    "collateral": "30092592592",
    "maxcollateral": "5000000000000000000000000000",
    "contractprice": "1000000000000000000000000",
    "downloadbandwidthprice": "60000000000000",
    "storageprice": "30092592592",
    "uploadbandwidthprice": "99999999000000000000",
    "revisionnumber": 310,
    "version": "1.3.0"
  },
  "financialmetrics": {
    "contractcount": 0,
    "contractcompensation": "0",
    "potentialcontractcompensation": "0",
    "lockedstoragecollateral": "0",
    "lostrevenue": "0",
    "loststoragecollateral": "0",
    "potentialstoragerevenue": "0",
    "riskedstoragecollateral": "0",
    "storagerevenue": "0",
    "transactionfeeexpenses": "0",
    "downloadbandwidthrevenue": "0",
    "potentialdownloadbandwidthrevenue": "0",
    "potentialuploadbandwidthrevenue": "0",
    "uploadbandwidthrevenue": "0"
  },
  "internalsettings": {
    "acceptingcontracts": true,
    "maxdownloadbatchsize": 17825792,
    "maxduration": 25920,
    "maxrevisebatchsize": 17825792,
    "netaddress": "<IP_ADDRESS>:12736",
    "windowsize": 144,
    "collateral": "30092592592",
    "collateralbudget": "100000000000000000000000000000",
    "maxcollateral": "5000000000000000000000000000",
    "mincontractprice": "1000000000000000000000000",
    "mindownloadbandwidthprice": "60000000000000",
    "minstorageprice": "30092592592",
    "minuploadbandwidthprice": "99999999000000000000"
  },
  "networkmetrics": {
    "downloadcalls": 0,
    "errorcalls": 193,
    "formcontractcalls": 0,
    "renewcalls": 0,
    "revisecalls": 0,
    "settingscalls": 306,
    "unrecognizedcalls": 10
  },
  "connectabilitystatus": "not connectable",
  "workingstatus": "not working"
}

gateway log says it cannot UPnP the port (what a surprise xD) I already know that it won't be working on this port. How the heck I can change this port to another ?
2017/09/20 08:53:18.168579 gateway.go:211: STARTUP: Logging has started.
2017/09/20 08:53:18.212193 gateway.go:223: INFO: gateway created, started logging
2017/09/20 08:53:36.108019 upnp.go:83: INFO: our address is <IP_ADDRESS>:9981
2017/09/20 08:53:37.164342 upnp.go:99: WARN: could not automatically forward port 9981: no UPnP-enabled devices found: no UPnP-enabled gateway found

Ok i found in --help
that's --rpc-addr :)


not all ELEMENTX-ELEMENTY bonds are present in BOND_ORDERS lookup dictionary

BOND_ORDERS includes only part of all optional bonds. e.g S-S is not present but indeed optional.
Thus, at line 223 in graphein.protein.edges.atomic.identify_bond_type_from_mapping the following allowable_order = BOND_ORDERS[query] fails.
I assume the solution should be in  graphein.protein.edges.atomic.add_bond_order (line 188), as follows:
            try:
                identify_bond_type_from_mapping(G, u, v, a, query)
            except:
                query = f"{atom_b}-{atom_a}"
                try:
                    identify_bond_type_from_mapping(G, u, v, a, query)
                except:
                    G.edges[u, v]["kind"].add("SINGLE")

Hi @EyalRozenberg1 Thanks for the bug reports - I appreciate it! I've added fixes to this PR (#83) - would you mind scoping them out when you've got a chance? I'll merge & reupload to PyPI ASAP :)
#80 Should be fixed in the repo already, but I don't think it's reflected in the version on PyPI

Looks good @a-r-j . Keep up the good work!
Thanks


Alerting Framework for TuneIn

This pull request is about providing the alerting feature to tune in framework. Below is the design doc
which have complete details about the same.
Design Doc
https://docs.google.com/document/d/1c8yZ9LuI0M0gMdHa76SDldZBbDlo-2TRbjKGigq4A-o/edit#heading=h.cjpc06d6urit
Testing
Unit test cases added for the testing each module
End to End testing have done on local and EI cluster.

LGTM. Merging.


about topContentAdditionalInset

in JSQMessageDemo
DemoMessagesViewController.m
- (void)viewDidLoad{
  [super viewDidLoad];
  ……
  self.inputToolbar.maximumHeight = 120;
  self.topContentAdditionalInset = 200;
  ……
}

TextView value changed， but the height of textView not change
Help, please.

Thanks @singer1026 - Please update your issue after reading the contribution guidelines :smile:

sogou keyboard is a popular keyboard in China
https://itunes.apple.com/us/app/sou-gou-shu-ru-fa-sogou-keyboard/id917670924?mt=8
use sogou keyboard in JSQMessageDemo and self.topContentAdditionalInset = 200;
TextView value changed， but the height of textView not change.
but if I use system keyboard ,it is ok.

Thanks @singer1026! Unfortunately, the library can't do much to support third-party keyboards.


Repo2docker v0.6.0

Should we make a new release of v0.6.0?
It has been a long time since the last release, some links in error messages that v0.5 prints don't work anymore, so let's cut a release?
I'd tag the current state and be done with it. We run ~master on mybinder.org so we know it works well enough to go straight for a release. It is a shame to not have a ChangeLog, maybe we can start this for the next release by making entries as we go along.

When we tried to release v0.6.0rc1 we ran into #385.
I tagged v0.6.0rc2 just now to see how far we get. Slowly catching up with things after a week away and assume no one is objecting to getting 0.6.0 out "as is".

🎉  see: https://pypi.org/project/jupyter-repo2docker/#history


Request to add a track length comment to file exports

Request to add a line to file exports where the track length is included.
Ex (for a gcode file):
;    Max radius (mm): 200
;    Start point: none
;    End point: none
;  Content type: machine
;  Reverse export path: false

would change to:
;    Max radius (mm): 200
;    Start point: none
;    End point: none
;    Track length: 2186
;  Content type: machine
;  Reverse export path: false

This would be useful for tables since they wont have to manually calculate the track length and could be used for time estimations etc.

We decided to move pattern settings out of export files in 1.0.0, so we won't be able to support this.


[network/ebpf] hook do_vfs_ioctl() to send data from userspace, like enqueue http_transaction

What does this PR do?
enqueue http_transaction from userspace via ioctl()
Motivation
This will be used in case of java JVM sending data to kernel side. It make it easier to support JVM than hooking uprobes() dynamically.
sequenceDiagram
    Note over Userspace/Process: run under container namespace
    participant Userspace/Process
    participant Kernel/Kprobe
    participant SystemProbe
    Note over SystemProbe: run on the host
    Userspace/Process->>Kernel/Kprobe: sys_ioctl(http_transaction)
       Kernel/Kprobe->>Kernel/Kprobe: http_enqueue(http_transaction)
   Kernel/Kprobe->>SystemProbe: http_notify()

to secure the access to the ioctl call a random token is set during the initialisation of the sysprobe.
Any access with the wrong token (future user probes would need to be bootstrapped from sysprobe)
Describe how to test/QA your changes

Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

@nplanel Why send data to kernelspace, just to send it back to userspace later?

closing as everything has been merged in https://github.com/DataDog/datadog-agent/pull/15698


start filling schedule and people sections

@OriolAbril
I mentioned this to @symeneses.
I think it would be nice if these had their own pages:

Organizers
Sponsors
Community Partners  (this may get a bit long, if the outreach works well)
Contributors (this will be long)

I think this is ready to merge, we can continue updating descriptions, links and images in follow up PRs. For example, Christian's image is not square so it looks quite weird in the grid now

@OriolAbril
Should I merge it in?


Support match_parent as a valid tile dimension

You can now pass match_parent to tileSize, tileWidth and tileHeight
Closes https://github.com/prolificinteractive/material-calendarview/issues/349

I also had to upgrade the gradle plugin, let me know if that's a problem and I will revert that.

@Maragues Could you please target your PR to the future-1.x branch ?

You might have to delete this PR and create a new one.

Im not sure this is completely needed after all, we might not need to have a match_parent for the tile size. We just need the user to be able to reset the sizes after setting is to something.

@quentin41500 If you read the description of issue https://github.com/prolificinteractive/material-calendarview/issues/349 you'll see that right now setting a value for either height or width sets the other dimension to the default value unless you specify the size, that's why this PR is needed (or at least its goal).
I'll do as you ask tomorrow.


GPU support for Docker

After several hours trying to run face_recognition on the GPU, I created this Dockerfile with Dlib installed + CUDA and cuDNN. Ready to use on the GPU with Nvidia-Docker.
It can dramatically reduce the number of issues regarding the usage on the GPU.
Full example: https://github.com/enric1994/face_recognition_docker_gpu

Very cool, thanks! I appreciate your work!
But would you be willing to move your changes into a second Dockerfile so that we can keep the CPU-only Dockerfile as an example and then have a second GPU Dockerfile example? Not everyone wants or needs a GPU Dockerfile, especially if they want to deploy on Lambda or something where they need to hit a maximum file size limit.
Thanks!

Cool, thanks!


RC.0 Release

[ ] Remove "production" wording from the microsite.

[x] Consider upgrading ExtractTextPlugin to non-beta.

[ ] Create a yarn.lock file for projects and add it to the blueprints

[ ] Based on package manager, install or not yarn.lock
[ ] Automate the yarn.lock creation and validation

[x] Merge the RC update guide

[x] Publish the wiki

[x] Make sure every link is valid

[x] Manually testing

[x] Windows

[x] Globally install Beta
[x] Uninstall Beta and npm cache clean
[x] Globally install RC.0
[x] ng new --ng4 project-name
[x] ng build
[x] ng test
[x] ng e2e
[x] ng lint
[x] ng g component c-name
[x] ng test
[x] ng build --prod
[x] ng help, ng g --help, ng help e2e

[x] Linux

[x] Globally install Beta
[x] Uninstall Beta and npm cache clean
[x] Globally install RC.0
[x] ng new --ng4 project-name
[x] ng build
[x] ng test
[x] ng e2e
[x] ng lint
[x] ng g component c-name
[x] ng test
[x] ng build --prod
[x] ng help, ng g --help, ng help e2e

[x] Mac OSX

[x] Globally install Beta
[x] Uninstall Beta and npm cache clean
[x] Globally install RC.0
[x] ng new --ng4 project-name
[x] ng build
[x] ng test
[x] ng e2e
[x] ng lint
[x] ng g component c-name
[x] ng test
[x] ng build --prod
[x] ng help, ng g --help, ng help e2e

[ ] Yarn on Linux

[ ] Globally install Beta
[ ] Globally install RC.0
[ ] ng new --ng4 project-name
[ ] ng build
[ ] ng test
[ ] ng e2e
[ ] ng lint
[ ] ng g component c-name
[ ] ng test
[ ] ng build --prod
[ ] ng help, ng g --help, ng help e2e

[x] Linux / Mac

[x] Ames
[ ] Angular IO
[x] Ejected Ames

[ ] Automate release testing in Travis

Love the yarn additions. adding a yarn.lock will make deployments safer!
(and not to mention, getting up and going a lot faster!)

are there specific tasks for the microsite the team wants help with?

If you need help with manual testing Yarn on Linux, I'm happy to help!

@hansl is more action required here?


remove unused function parameters

Simple simplification.

During a run of megacheck the following issues were discovered:

During a run of megacheck the following issues were discovered:


ci: add matrix.os array to test on other os

Adds MacOS and Windows OSes to CI testing

Checklist

[x] run npm run test and npm run benchmark
[x] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

Pull Request Test Coverage Report for Build 660856069

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.592%

Totals

Change from base Build 637162735:
0.0%

Covered Lines:
40

Relevant Lines:
40

💛  - Coveralls


Fix issue with stale data when logging out/in as a different user

We weren't clearing the CourseDataManager on log out, so it was
returning stale queriers.

@hanningni please review

@ehmadzubair please review

:+1:


Is autoloading required?

Autoloading is a potential vulnerability because it possibly unknown code executing on application initialization. Is this really required? How much effort would it be to explicitly bootstrap the environment to contain the classes we require?
Autoloading occurs here https://github.com/infinityCounter/QMVC/blob/70d98fd56971b3b56d9fd95884223db0e0b54b53/public/index.php#L15-L17
Alternatively, what about creating a custom autoloader that can be used to whitelist classes for autoloading?

All auto loading removed from project except for unit tests. Will consider a whitelist autoloader but closing for now.


Preact 8.0.1 - Rendering Lists with duplicate key values causes "ghost" elements

I recently upgraded to 8.0.1 and noticed an issue. I was having a bug where I was accidentally rendering a list with duplicate key values, and I noticed elements seem to leave behind "ghosts" on re-render if their key values are duplicated. These ghosts are visible both in the DOM and in React DevTools. A simple reproducible example of this is:
class App extends Component {
    render() {
            return (

                    { [1, 2, 3].map(() => (Hello)) }
                    <button onClick={ () => this.forceUpdate() }>Rerender</button>

            );
    }
}

Every time this component "rerenders", it will grow in size, leaving behind ghosts.

since keys' sole purpose is to uniquely identify similar sibling objects, is undefined behavior in the presence of duplicate keys really that surprising?
what were you expecting to happen?

I'm aware it's not the way keys should be used, and that perhaps this behavior is a-okay since they're not supposed to be used that way, just seemed like an unusual thing to happen and something I wasn't sure you all were aware of. I believe<EMAIL_ADDRESS>handled this edge case more gracefully (can say for certain what the behavior was then). If this behavior is acceptable, I will happily close the issue.

If it was working correctly in Preact 7 and doesn't in Preact 8, then it potentially may cause some problem in other situation. i.e. unexpected code/behavior is in place now.
Even if this isn't a regression or it's fine as is, it at least seems like a good case for preact/debug, @developit don't you think?

Absolutely something preact/debug would be amazing for - let's get that added for sure!
FWIW, I don't think duplicate keys has ever really worked properly in Preact. The keys get used to build a map, so dupes just overwrite eachother.  Perhaps before 8.x the keys were being ignored, since that was that case for Pure Functional Components?

I'm also experiencing this issue with preact ^7 and ^8 when I have a component (class or functionnal) with a key={ 0 } or key={ '0' }
My actual workaround fix is to key={ n + .1 } which does the job.

@iam4x keys are always converted to strings. Why do you need keys there in a first place?

Hmm - I thought we used == to check keys?  key="0" and key={0} should be the same.

@developit afaik you rely on Object keys. e.g. set keys[key] = node and check keys[key] != void 0. Type of check isn't related here since Object keys are always strings (except of Symbols but who cares). So it's strings.

@NekR Had this issue with the usage of https://github.com/airbnb/rheostat
You can display "pit points" at every X values which are numbers, when you display a pit point at the value 0, on the next update/render it won't override the existing DOM element but will re-create a new one (like the initial description of the issue).
Exact line of where it happens is https://github.com/airbnb/rheostat/blob/master/src/Slider.jsx#L662
If you want, I can make an easy repro case.

repro would be great!

fwiw I added a CodePen.io to reproduce my issue above :)

In terms of correctness react might not render what you want if you expect it to render 3 items https://codesandbox.io/s/V6rEgX9 i think ivi handles this the correct way http://codepen.io/thysultan/pen/OmyqgJ?editors=1010

Repro case with rheostat: https://github.com/iam4x/preact-key0-repro-bug

It seems like duplicate keys should produce a single element.

The issue appears to be resolved in Preact 10: https://codesandbox.io/s/1q15no18k7. Keys are no longer strings in Preact 10 AFAIK, so the '0' vs 0 conflict should be resolved (can you confirm @developit?)
An outstanding question though is to decide whether we want to guarantee this behaviour. I would be inclined to say no, on the basis that it could complicate internal changes in future, unless there is a significant React ecosystem compatibility reason. I suggest the outcome here needs to be of three things:

We say the behaviour is undefined, close this issue and do nothing
We say the behaviour is undefined, that debug mode should warn about it and create a follow-up task for that
We say that Preact 10's current behaviour is supported and add a test case

Thoughts?

I'm happy to inform that we went with 2). We do warn in preact/debug when we encounter a child with a duplicate key. It's still treated as undefined behaviour, but now that there is a warning it's hard to miss :+1:


Local Linear Regression asking for date field input

When trying to create a prediction from a Local Linear Regression that contains a date field, an exception is raised because the input must contain values for the date field (although all the date sub-fields from this field are in the input. This is the exception raised:
File "/Users/unmonoqueteclea/github/unmonoqueteclea/python/bigml/util.py", line 619, in check_no_training_missings     "to get a prediction." % field['name']) ValueError: Failed to predict. Input data must contain values for field 'test-date' to get a prediction.
And this is the code I used:
from bigml.api import BigML
from bigml.linear import LinearRegression

api = BigML()
content = [["test-date","test-num1","test-num2", "test-num3"],
           ["01/12/2012",23,34,54],
           ["13/12/1998",22,54,65],
           ["15/04/2002",25,56,70],
           ["17/12/2012",23,30,54],
           ["24/03/1998",22,54,65],
           ["30/04/2002",25,23,70],
           ["23/12/2012",23,76,54],
           ["21/04/1998",22,87,65],
           ["30/06/2002",25,56,90],
           ["23/11/2012",23,98,9],
           ["07/12/1998",22,54,34],
           ["30/04/2002",25,23,12]]

source = api.create_source(content)
dataset = api.create_dataset(source)
api.ok(dataset)
model_args = {"objective_field": "test-num3"}
lr = api.create_linear_regression(dataset, model_args)
api.ok(lr)
local_lr= LinearRegression(lr)
options = {"test-num1": 23,
           "test-num2" : 54,
           "test-date.day-of-month":2,
           "test-date.month":12,
           "test-date.day-of-week": 2,
           "test-date.year": 2012}

print(local_lr.predict(options)) # Exception raised

Don't know if it's the correct way of doing things but adding a line to  check_no_training_missings to filter non-preferred fields solves the issue. I can create a PR if needed:
def check_no_training_missings(input_data, fields, weight_field=None,
                               objective_id=None):
    """Checks whether some input fields are missing in the input data
    while not training data has no missings in that field

    """
    for field_id, field in fields.items():
      if (field["preferred"] and \
          (not field_id in input_data and \
            field['summary']['missing_count'] == 0 and \
                (weight_field is None or \
                field_id != weight_field) and \
                (objective_id is None or field_id != objective_id))):
            raise ValueError("Failed to predict. Input"
                             " data must contain values for field '%s' "
                             "to get a prediction." % field['name'])

Hi there,
yes, you're right about the fact that the fields to be checked are not the ones that are currently being used. However, I think the problem goes beyond filtering the non-preferred fields. Probably, what we should do is checking only the fields that have been used in the model construction: input_fields, so it's probably better to filter out the fields that are not used in the model before calling the function, and that can be done in the constructor. That would improve efficiency, because this function in called for each prediction, while the constructor is only called once.
I remember adapting the code to do that previously, somewhere but I refactored these functions lately, so it's a reapearing bug, I'm a fraid. Thanks for the heads up!

PR #273 wants to solve that, even if probably the solution will be provided by the backend later.


Swap the order of Previews and Pages sections

Describe the solution you'd like
Request the ability to configure the order in which Previews and Pages are rendered in the side panel. We want to be able to focus our users towards the pages rather than the previews, given the type of content we provide within a page.
Additional context

Hey @cody-clio, really sorry for the slow reply.
This would be a great feature. I've actually thought about it myself (along with being able to rename those sections) many times but never quite gotten around to implementing it. I'll try to use this reminder as the impetus I need to work on it as soon as I have a chance.

@cody-clio I've just opened PR #553 that adds a config option to control the order of panels in the sidebar. If you have a chance could you give it a try and let me know if you run into any problems?
gem "lookbook", github: "ViewComponent/lookbook", branch: "order-sidebar-nav-sections"

Released in v2.2.0.


Ignore SSL errors

Working on a self-hosted jira installation with some misconfigured SSL certificate. Is there a way to ignore certificate checks?

Use the --insecure option:
jira --help
...
General Options:
  -b --browse         Open your browser to the Jira issue
  -e --endpoint=URI   URI to use for jira
  -k --insecure       disable TLS certificate verification
...

You can also set it in a config file to make permanently off:
$ cat ~/.jira.d/config.yml
insecure: true


Implement Incremental Backups

With the change from tar to rsync it is now possible to impolement incremental backups. This should be available using version 3.3

Switch to Rsync has been done with version 3.3.0


Highlight searching text

Idea Description
I think it is useful!
Reference images and links

Can I make this feature?

Sure! Go ahead!


libspdm_{read/write}_uint* functions should be static inline

The libspdm_read_uint* and libspdm_write_uint* functions currently have external linkage within common_lib. They should be static inline with their implementations in the header.

@steven-bellock to provide size data.

At least on Visual Studio I did not see the optimizations I was expecting, so closing this issue.

FYI. Potential code size impact on x86_64 and riscv_64 I did earlier for this one.
============
#define FUNC(name, offset)
void name(uint8_t *buffer)
{
uint16_t val16;
uint32_t val32;

asm volatile ("" : : : "memory");
val16 = libspdm_read_uint16(buffer);
libspdm_write_uint16(buffer + 2, val16);

val32 = libspdm_read_uint16(buffer + 4);
libspdm_write_uint32(buffer + 8 + offset, val32);
}
FUNC(func1, 1)
FUNC(func2, 2)
FUNC(func3, 3)
FUNC(func4, 4)
FUNC(func5, 5)
Compiled with -O2.
x86_64:
no-inline:  0x14b bytes
inline:        0x134 bytes
riscv_64:
no-inline:   0x198 bytes
inline:         0x1d6 bytes
The advantage seems not very obvious.


Accordion theming strategy issue

Describe the bug
The accentColor token is affecting the focus of the Accordion component, which I think it shouldn't because, apart from the fact that this is the only component whose focus color is being changed by an opinionated theme token, I consider this going against the fundamentals of our theming strategy since the focus a fundamental design opinion that shouldn't be affected by the theming.

Screenshots

Linked to #1364

Totally agree. Fixed after the review of the opinionated theme.


Problem during data loading on custom h5ad

Loading internally generated h5ad into excellxgene results in error in the log:
ERROR:backend.server.app.app:Exception on /api/v0.2/layout/obs [GET]
TypeError: '(slice(None, None, None), slice(0, 2, None))' is an invalid key

The result in the browser is that there is an unexpected http response (see screenshot).
Currently, I did not yet add any of the data that generate the problem. Data runs fine in the cellxgene-1.0.1.

Versions affected:

2.8.1
2.9.1

Were you able to fix this? I would check your layer keys from the object, and when I had an "invalid key" issue it was due to AnnData versions. Excellxgene runs with 0.7.8 and may fail to open objects built in 0.8.0.

Closing this issue as we haven't heard back. That issue should be resolved in v2.9.6 release.


docker pull fails on overlay storage, hard to reproduce

I got several systems, whose common configuration is

kernel 3.18.8
go 1.4.x
docker 1.5.0
os : gentoo/amd64
overlay storage over ext4 filesystem on a dedicated partition (/var/lib/docker)

On some of them, it works just great. On two of them, it fails with the same error :
orzel@verdi /home/orzel% docker pull ubuntu
511136ea3c5a: Pull complete
511136ea3c5a: Download complete
fa4fd76b09ce: Error downloading dependent layers
117ee323aaa9: Verifying Checksum
2d24f826cb16: Download complete
2d24f826cb16: Error pulling image (latest) from ubuntu, operation not supported
FATA[0221] Error pulling image (latest) from ubuntu, operation not supported
The relevant log is not very useful (to me):
...
time="2015-03-05T23:23:50+01:00" level="info" msg="+job trust_update_base()"
time="2015-03-05T23:23:50+01:00" level="info" msg="-job trust_update_base() = OK (0)"
time="2015-03-05T23:23:52+01:00" level="info" msg="+job trust_key_check(/library/ubuntu)"
time="2015-03-05T23:23:52+01:00" level="info" msg="-job trust_key_check(/library/ubuntu) = OK (0)"
time="2015-03-05T23:23:52+01:00" level="info" msg="Image manifest for ubuntu:latest has been verified"
time="2015-03-05T23:27:25+01:00" level="error" msg="Error from V2 registry: operation not supported"
Error pulling image (latest) from ubuntu, operation not supported
time="2015-03-05T23:27:31+01:00" level="info" msg="-job pull(ubuntu, latest) = ERR (1)"
On the failing servers, it's 100% reproducible. I tried starting from a clean (empty) /var/lib/docker, but this doesn't change anything.
I tried to understand the difference between the servers where it works and those, but i can't find any. If you have any suggestions.
On the failing servers, i can turn around the probleme by switching to the btrfs backend storage or the devmapper one. It works well then.

update : i got a third system with same configuration and same errors. I tried using kernel 3.19.1, but this doesn't solve the problem. Reminder : some other servers work well, with (it seems to me) the same software stack.

@orzel Can you provide the output of docker info and docker version?
I'm willing to bet you are using RC1 of Docker 1.5

I don't think so. The Gentoo package name is quite unambiguous, "1.5.0".  I guess that's part of the failling pull. "docker images" report lines like this one :
REPOSITORY          TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
               37208f16715c        8 days ago          0 B

Ok, i've found out what the problem was.
I was missing CONFIG_EXT4_FS_SECURITY and CONFIG_EXT4_FS_POSIX_ACL in my kernel. This is not reported by check-config.sh in docker 1.5.0.
Actually, it's not the first time this script fails me. On one server, i couldn't user docker neither, the error was mentionning "cpuset". I've fixed the problem by adding CONFIG_CPUSETS to my kernel. This was NOT reported neither by check-config.sh.
This script is very useful indeed, but it would be great if it was more carefully maintained ;-)

This is a bit surprising - contrib/check_config.sh contains lines that check_flags EXT4_FS_POSIX_ACL EXT4_FS_SECURITY | sed 's/^/  /' and CONFIG_CPUSETS is also there.

Not here, in docker-1.5.0.tar.gz:contrib/check-config.sh i have nothing related to "CONFIG_CPUSETS" and the ext4 stuff is only tested for other storage backends. The overlay backend check for exactly one setting (OVERLAY_FS), no less, no more.


How to create Whitelist of Central devices on Peripheral

Hi,
I recently started working on bleno and found it very much interesting and easy to use.
I have few challenges to achieve as mentioned in below scenarios.
Scenarios:

I need to create a list of central devices on peripheral who are suppose to connect to it (peripheral).
Based on role a central device should have permission to read or write to characteristic

How i can achieve these two scenarios?

@skyn6t this scenario is not supported.


Make accordion element closeable

For now we're jsut grabbing master of our fork of react-responsive-accordion with an option to close an open accordion region.
You can check that it works:
merge branch
npm run js-example
click on open region and watch it close
<3

Closing due to lack of activity; feel free to reopen


“pilin” has a strange thick line

It's strange, I don't remember this being an issue before.

It's seems Safari was the problem,
When using the renderer on google chrome, there are no thick lines, very strange.
Not sure why Safari modifies the widths like that.

Not sure what happened but I don't seem to get it with Safari right now.


dbt docs generate does not add database to tables

Describe the bug
When running dbt docs generate, an error is thrown:
Encountered an error:
Runtime Error
  404 Not found: Dataset XXX:YYY was not found in location US

However, the dataset YYY does not exist in database XXX. The yml file that describes the source is written such as:
schema: YYY
database: 'ZZZ'

The code that is automatically generated in a dbt docs generate call erroneously prefixes the dataset with default database, XXX, found in profiles.yml
Steps To Reproduce

Create a source yml file with a dataset in a different database than the default database specified in profiles.yml
Run: dbt docs generate

Expected behavior
The code automatically generated and run when executing a dbt docs generate should prefix all calls to a dataset with the correct database as defined in source yml files.
Screenshots and log output
13:47 $ dbt docs generate
Running with dbt=0.15.2

13:47:57 | Concurrency: 4 threads (target='dev')
13:47:57 |
13:48:17 | Done.
13:48:17 | Building catalog
Encountered an error:
Runtime Error
  404 Not found: Dataset XXX:YYY was not found in location US
...
tables as (
    select
       project_id as table_database,
       dataset_id as table_schema,
       table_id as original_table_name,

       concat(project_id, '.', dataset_id, '.', table_id) as relation_id,

       row_count,
       size_bytes as size_bytes,
       case
           when type = 1 then 'table'
           when type = 2 then 'view'
           else 'external'
       end as table_type,

        REGEXP_CONTAINS(table_id, '^.+[0-9]{8}$') and coalesce(type, 0) = 1 as is_date_shard,
        REGEXP_EXTRACT(table_id, '^(.+)[0-9]{8}$') as shard_base_name,
        REGEXP_EXTRACT(table_id, '^.+([0-9]{8})$') as shard_name

   from YYY.__TABLES__

 ),

Would like to have the last line be:
from ZZZ.YYY.__TABLES__

System information
Which database are you using dbt with?

[ ] postgres
[ ] redshift
[x] bigquery
[ ] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
installed version: 0.15.2
   latest version: 0.15.2

The operating system you're using:
Ubuntu 18.04.4 LTS
The output of python --version:
Python 3.7.4
Additional context
A work around is to change the source ymls from:
schema: YYY
database: 'ZZZ'

to
schema: "`ZZZ`.YYY"
database: 'ZZZ'

Hi @danielwlogan  - are you certain that you were using 0.15.2 when you encountered this issue? I just gave this a spin locally with dbt v0.15.2 and found that the database (project) name from my .yml file was correctly injected into dbt's catalog query.
For me, this looks like:
...
                REGEXP_CONTAINS(table_id, '^.+[0-9]{8}$') and coalesce(type, 0) = 1 as is_date_shard,
                REGEXP_EXTRACT(table_id, '^(.+)[0-9]{8}$') as shard_base_name,
                REGEXP_EXTRACT(table_id, '^.+([0-9]{8})$') as shard_name

            from `dbt-dev-project`.dbt_dbanin.__TABLES__
...

So, dbt is definitely injecting the project id into this query in at least some cases, but it's definitely possible that there's a bug which is impacting your dbt setup. If you can confirm that this occurred on dbt v0.15.2, then we'd certainly be happy to look deeper into it!

Yes, I can confirm that I am running 0.15.2. However, I think you may have misunderstood my original post. My problem is that the database name from my profiles.yml file is incorrectly injecting itself into the dbt catalog query. That is, I do not want the default database name to be the project name, I want the database name defined in the source.yml (not the ~/.dbt/profiles.yml) to be populated.

Any progress on this front?

@danielwlogan great timing! I actually just pulled this up while prioritizing the next release. I did some digging here after I saw your last comment, but I was not able to replicate the behavior you're describing here. I'll revisit this and prioritize it accordingly :)

Great. Let me know if there is anything else I can provide or help with in any way.

@danielwlogan I was very puzzled here for a very long time, but I just thought about this issue while reviewing a different bug report! Do you by any chance specify a quoting: config either in:

your dbt_project.yml file
a schema.yml file that specifies sources?

If so, is the database quoting config set to false in either of those places?? Check out https://github.com/fishtown-analytics/dbt/issues/2188 -- this bug causes dbt to use the "quote policy" in place of the "include policy", which would indeed lead to the behavior you're seeing here!

@drewbanin, the answer is yes, we do have the following structure in our schema ymls:
sources:
  - name: XXX
    schema: YYY
    database: 'ZZZ'
    quoting:
      database: false
      schema: false
      identifier: false

Based on what you have suggested, we have pulled the quoting config into dbt_project.yml and changed them all to true.  We then drop the quotes around the {{ source(...) }} and it seems to work.
Thanks @drewbanin for the tip.

cool, glad to hear it! I'm going to close this issue as https://github.com/fishtown-analytics/dbt/issues/2188 tracks the actual code change that needs to happen here. This is going to be fixed in the next release of dbt.


[Egeria 22] Asset Catalog OMAS - initial commit

Signed-off-by: Daniela Otelea<EMAIL_ADDRESS>

@planetf1 I see. The pom fix up in the server chassis in my PR, removes the dependency on the asset catalog omas so it allows it to build without asset catalog.


added standalone_fundraiser_info_v1

When you visit your own profile page in the app it makes a call to this endpoint. To be able to replicate this behavior i added this method.

@11philip22 thank you!


track share button - now shares rendered track image instead of text

changed share track so 'I'm listening to (currentStation.name) via Swift Radio Pro' is now a subtitle in a watermarked image with the album art, artist and song name to share."

Radios without song metadata are displayed with the radio logo and information.

@CamMcLeod Thanks a lot for this cool feature 👍


ocamlPackages.result: 1.2 -> 1.5

Motivation for this change
result 1.5 improves compatibility for OCaml >= 4.08.
References:

https://github.com/janestreet/result/pull/9
https://github.com/ocaml/opam-repository/pull/15853

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions: Ubuntu

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_02.result ocaml-ng.ocamlPackages_4_08.result

cc @vbgl

@GrahamcOfBorg build ocamlPackages.tsort

The result library is a dependency of hundreds (thousands?) of packages. I suspect that a few of them may break due to the update (like ocaml-version; see a proposed fix: #98950). It would be nice to get a list of things that break and then decide on whether to fix them and how.

A suspect this commit in opam-repository may give us some good indications.

@GrahamcOfBorg build ocamlPackages.alcotest ocamlPackages.cmdliner ocamlPackages.irmin ocamlPackages.irmin_1 ocamlPackages.logs ocamlPackages.ocaml-version ocamlPackages.tsdl

@GrahamcOfBorg build ocamlPackages.alcotest ocamlPackages.cmdliner ocamlPackages.irmin ocamlPackages.logs ocamlPackages.tsdl

@GrahamcOfBorg build acgtk beluga coqPackages.hierarchy-builder dot-merlin-reader eff flow framac fstar jackline liquidsoap ocaml-crunch ocaml-top ocamlformat patdiff satysfi


Remove nodes from the canvas

Context
Currently, there's no mechanism to remove nodes from the canvas.
Goal
The goal for this issue is to provide a mechanism to remove nodes from the canvas, considering their position in it.
Open questions

Should we aim to support placeholders when a step is removed?

I wouldn't. For that there should be ways to insert between nodes.


Add ability to Mark Course as No Credit

Applicable scenarios:

courses like PDC320 is not worth a credit; currently, Sqrl has no way of knowing this.

If a course is marked as No Credit, it is not included in credit calculations in Overview.

I think this should be somewhat automated for courses such as PDC320 that are never worth any credits. We should be able to parse that from course metadata and populate and field in the db.

I'm not sure if this can be inherently inferred from the data. One possibility is that if a course does not have a breadth category it's no credit, but we'd have to double check every course for that.


Defend against lazy vars when mirroring

:tophat: What? Why?
:dart: What should QA test?
:pushpin: Related tasks?
:clipboard: Developer checklist

[ ] Unit Tests (if necessary)
[ ] UI Snapshot Tests (if necessary)
[ ] Added accessibility tags to any interactive element
[ ] Added reporting for GA (events + screen views) / Errors / Exceptions
[ ] Documentation

:ghost: GIF

what why?

:+1:

:+1:


ansible: do not use colors in the teuthology log

I tested this locally and the environment variable does work.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1681/
Test PASSed.

OTOH, I downloaded the log and looked at it with "less -r", and it was actually quite helpful having the color codes in the file....I wonder if there's a way to render them in a browser with the color?

I actually started working this morning on a way to filter it from the logfile but not from stdout.
I'd love to see colored logfiles in the browser though!

http://256.io/escapes.js/

This is also this force_color config option that looks promising.
http://docs.ansible.com/intro_configuration.html#force-color
If I'm understanding this right it would color the stdout in a terminal, but not for the saved log?

Looking at the code in color.py, it seems to me that doesn't apply to the version of ansible we're running....but also it seems like it has the opposite effect, to always add color to the output, regardless of "terminal or not"

@dmick the default is set to 1 though for force_color.  So, maybe if we set it to 0 it would not force color mode even when running without a TTY.

ah, finally found it in our source; yes, it's there, and I see the default:
ANSIBLE_FORCE_COLOR            = get_config(p, DEFAULTS, 'force_color', 'ANSIBLE_FORCE_COLOR', None, boolean=True)
But I assumed there was no problem about how to disable color, just whether we want to or not.

Could we just spit out escapes.js for log views from pulpito, and spread the word about less -r?

@dmick I think we'd have to make a log viewer thing for pulpito for that to work, but I like the idea.  IIRC, the logs are just served directly from the filesystem now.

I was hoping we could do something like wrap the existing file inside a call to escape.js, and ship escape.js and a simple "call its rendering function", whatever it is, so that the page is now JS, but just looks like colored text (because its now html)

I think this is better: https://pypi.python.org/pypi/ansi2html  -l -s xterm is the closest to right, although I despise the gray background; I'd hack in FFFFFFF for the AAAAAA were it me.

I don't think we should remove the colors entirely.

Agreed, ansi2html seems like a good option.  I'll go ahead and close this PR.


sociallogins toc

Fixes #2332

:warning: Validation status: warnings

File
Status
Preview URL
Details

aspnetcore/security/authentication/social/index/_static/Done.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/DoneFacebook.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/DoneGoogle.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/DoneMicrosoft.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/DoneTwitter.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/FBLogin2.PNG
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/FBMyApps.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/FBNewAppId.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/FBOAuthSetup.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/FBProductSetup.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleConsoleAddCred.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleConsoleChooseApi.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleConsoleChooseCred.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleConsoleCreateClient.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleConsoleEnableApi.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleConsoleFinish.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleConsoleGoCredentials.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleConsoleLogin.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleConsoleNewProj.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleConsoleSwitchboard.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/GoogleLogin.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/MicrosoftDev.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/MicrosoftDevAppCreate.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/MicrosoftDevAppPlatform.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/MicrosoftDevAppReg.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/MicrosoftDevApps.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/MicrosoftDevLogin.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/MicrosoftDevPassword.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/MicrosoftLogin.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/MicrosoftLoginError.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/MicrosoftRedirectUri.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/TwitterAppDetails.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/TwitterAppManage.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/TwitterCreate.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/TwitterKeys.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/TwitterLogin.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/enablessl.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/managesecret.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/new-project.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/new-project2.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/pass1.PNG
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/pass2.PNG
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/select-project.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/social.png
:warning:Warning

Details

aspnetcore/security/authentication/social/index/_static/ssl.png
:warning:Warning

Details

aspnetcore/security/authentication/accconfirm.md
:white_check_mark:Succeeded

aspnetcore/security/authentication/identity.md
:white_check_mark:Succeeded

aspnetcore/security/authentication/index.md
:white_check_mark:Succeeded

aspnetcore/security/authentication/social/facebook-logins.md
:white_check_mark:Succeeded

aspnetcore/security/authentication/social/google-logins.md
:white_check_mark:Succeeded

aspnetcore/security/authentication/social/index/_static/Done.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\Done.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/DoneFacebook.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\DoneFacebook.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/DoneGoogle.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\DoneGoogle.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/DoneMicrosoft.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\DoneMicrosoft.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/DoneTwitter.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\DoneTwitter.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/FBLogin2.PNG

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\FBLogin2.PNG.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/FBMyApps.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\FBMyApps.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/FBNewAppId.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\FBNewAppId.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/FBOAuthSetup.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\FBOAuthSetup.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/FBProductSetup.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\FBProductSetup.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleConsoleAddCred.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleConsoleAddCred.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleConsoleChooseApi.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleConsoleChooseApi.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleConsoleChooseCred.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleConsoleChooseCred.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleConsoleCreateClient.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleConsoleCreateClient.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleConsoleEnableApi.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleConsoleEnableApi.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleConsoleFinish.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleConsoleFinish.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleConsoleGoCredentials.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleConsoleGoCredentials.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleConsoleLogin.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleConsoleLogin.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleConsoleNewProj.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleConsoleNewProj.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleConsoleSwitchboard.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleConsoleSwitchboard.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/GoogleLogin.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\GoogleLogin.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/MicrosoftDev.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\MicrosoftDev.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/MicrosoftDevAppCreate.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\MicrosoftDevAppCreate.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/MicrosoftDevAppPlatform.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\MicrosoftDevAppPlatform.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/MicrosoftDevAppReg.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\MicrosoftDevAppReg.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/MicrosoftDevApps.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\MicrosoftDevApps.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/MicrosoftDevLogin.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\MicrosoftDevLogin.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/MicrosoftDevPassword.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\MicrosoftDevPassword.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/MicrosoftLogin.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\MicrosoftLogin.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/MicrosoftLoginError.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\MicrosoftLoginError.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/MicrosoftRedirectUri.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\MicrosoftRedirectUri.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/TwitterAppDetails.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\TwitterAppDetails.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/TwitterAppManage.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\TwitterAppManage.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/TwitterCreate.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\TwitterCreate.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/TwitterKeys.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\TwitterKeys.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/TwitterLogin.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\TwitterLogin.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/enablessl.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\enablessl.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/managesecret.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\managesecret.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/new-project.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\new-project.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/new-project2.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\new-project2.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/pass1.PNG

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\pass1.PNG.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/pass2.PNG

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\pass2.PNG.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/select-project.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\select-project.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/social.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\social.png.xml.view.json" is transformed to empty string with template "Resource.xml"

aspnetcore/security/authentication/social/index/_static/ssl.png

Line unspecified: [Warning] Model "obj\viewmodel\security\authentication\social\index_static\ssl.png.xml.view.json" is transformed to empty string with template "Resource.xml"

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@tdykstra  fantastic. Nice work


Default planes

adds all the default planes to the json, with liveries if they had any or one base entry

https://github.com/kolos26/GEOFS-LiverySelector/pull/786


Align functions according to their ISA's requirements

Add a function_alignment function to the TargetIsa trait, and use it to align functions when generating objects. This fixes a bug on x86_64 where rip-relative loads to sse registers could cause a segfault, as functions weren't always guaranteed to be aligned to 16-byte addresses.
Fixes #4812

Nice, that's surprisingly painless.
Is 16-byte alignment always best? Could we get the maximum alignment of anything in the vcode constant pool instead, and if so, is that extra complexity worth-while?
I suspect we don't care about wasting up to 15 extra bytes in the text section per function, and I know there are sometimes performance advantages to aligning x86 labels to 16-byte boundaries. So I imagine just picking a constant 16-byte alignment is not only good enough, but occasionally helpful. But I'm still curious if there are effects we care about.

Nice, that's surprisingly painless.
Is 16-byte alignment always best? Could we get the maximum alignment of anything in the vcode constant pool instead, and if so, is that extra complexity worth-while?
I suspect we don't care about wasting up to 15 extra bytes in the text section per function, and I know there are sometimes performance advantages to aligning x86 labels to 16-byte boundaries. So I imagine just picking a constant 16-byte alignment is not only good enough, but occasionally helpful. But I'm still curious if there are effects we care about.

That's what I thought about doing initially, but @alexcrichton pointed out that llvm always aligns functions to 16-byte boundaries, so it seemed easier to do that and potentially waste some bytes.

Before we merge this:

@bjorn3 how do the changes to cranelift-object and cranelift-jit look?
@uweigand is the default function alignment of 4 bytes for s390x correct?

For the jit all references to EXECUTABLE_DATA_ALIGNMENT should use this new method. For object there is a reference at https://github.com/bytecodealliance/wasmtime/blob/186c7c3b89c0e172ff39c0126ca71bf9e995dc8c/cranelift/object/src/backend.rs#L351 and equivalent for define_function. It needs another std::cmp::min wrapper.

Before we merge this:
* @uweigand is the default function alignment of 4 bytes for s390x correct?

The minimum alignment required for correctness is just 2 bytes, and this should already come from isa.symbol_alignment() as @bjorn3 points out.   That said, having a default alignment of 4 bytes seems reasonable for performance reasons.  (Maybe even higher, but we should do performance measurements first to make sure it's an overall win.  So 4 is good for now.)

For follow-on work, would it be reasonable to remove the function_alignment field of the ObjectBuilder in cranelift-object?

I do think so. All it seems to be used for is lucet to set function alignment to 16 bytes, which is exactly what this PR did.


Master

LoL
This is not the place to merge your own stuff.

LoL
This is not the place to merge your own stuff.

Yes, sure that was a just a mistake. Sorry about that.


[release-4.14] OCPBUGS-23078: CVE-2023-44487: bump github.com/openshift/library-go to release-4.14

/lgtm
/label backport-risk-assessed

/retest

/test operator-e2e

The failure tc in operator-e2e(Containers not ready status/Interuppted by user as timeout) are flake. Can be ignored. Adding the label
/label cherry-pick-approved


readme's advice to put gem at top of Gemfile is counterproductive

My goal was to set an ENV variable in .env and read it in rails console. This didn't work when I put the gem at the top of my Gemfile, but did work when I put it at the bottom. I am using gem 'dotenv-rails', :groups => [:development, :test], by the way. Perhaps the README should be changed, since it advises putting the gem at the top of the Gemfile.

I'm not able to duplicate any issues with ordering. Can you confirm that you are?
The advice to put it at the top of the gemfile is so that dotenv initializes and loads the environment before any other gems that may depend on it.
Let me know if you can duplicate the issue and I'll open this back up or update the docs.


Pragma.READ_UNCOMMITED has a typo

Hi team,
sqlite-jdbc-3.28.0
SQLiteConfig.Pragma.READ_UNCOMMITED has a typo.
    READ_UNCOMMITED("read_uncommited", SQLiteConfig.OnOff),

However, according to https://sqlite.org/sharedcache.html
the value should be read_uncommitted (double t)
More information can be found from below method of SQLiteConnection which supports my conclusion
public void setTransactionIsolation(int level) throws SQLException {
        this.checkOpen();
        switch(level) {
        case 1:
            this.getDatabase().exec("PRAGMA read_uncommitted = true;", this.getAutoCommit());
            break;
        case 8:
            this.getDatabase().exec("PRAGMA read_uncommitted = false;", this.getAutoCommit());
            break;
        default:
            throw new SQLException("SQLite supports only TRANSACTION_SERIALIZABLE and TRANSACTION_READ_UNCOMMITTED.");
        }

        this.connectionConfig.setTransactionIsolation(level);
    }

Please help to check and fix that

Anyone? Hope make myself clear. The SQLiteConfig.Pragma.READ_UNCOMMITED is wrong, the method setTransactionIsolation is correct, we need to fix the enum definition.