[BUG]: DotNetCoreCLI@2 test publishTestResults has no effect on code coverage

Task name
DotNetCoreCLI
Task version
2.220.0
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Microsoft Windows Server 2022 Datacenter
Task log
2023-05-09T00:05:03.4612100Z ##[section]Starting: Unit tests
2023-05-09T00:05:03.4719968Z ==============================================================================
2023-05-09T00:05:03.4720094Z Task         : .NET Core
2023-05-09T00:05:03.4720159Z Description  : Build, test, package, or publish a dotnet application, or run a custom dotnet command
2023-05-09T00:05:03.4720260Z Version      : 2.220.0
2023-05-09T00:05:03.4720313Z Author       : Microsoft Corporation
2023-05-09T00:05:03.4720384Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/build/dotnet-core-cli
2023-05-09T00:05:03.4720477Z ==============================================================================
2023-05-09T00:05:03.8584482Z [command]C:\Windows\system32\chcp.com 65001
2023-05-09T00:05:03.8682529Z Active code page: 65001
2023-05-09T00:05:03.8772397Z Info: .NET Core SDK/runtime 2.2 and 3.0 are now End of Life(EOL) and have been removed from all hosted agents. If you're using these SDK/runtimes on hosted agents, kindly upgrade to newer versions which are not EOL, or else use UseDotNet task to install the required version.
2023-05-09T00:05:04.4730461Z [command]"C:\Program Files\dotnet\dotnet.exe" test D:\a\_work\1\s\src\Common\<REDACTED>.csproj --logger trx --results-directory D:\a\_work\_temp --no-build --no-restore --configuration Release --collect "Code Coverage"
2023-05-09T00:05:05.1465906Z Test run for D:\a\_work\1\s\src\Common\<REDACTED>.dll (.NETCoreApp,Version=v6.0)
2023-05-09T00:05:05.8011335Z Microsoft (R) Test Execution Command Line Tool Version 17.5.0 (x64)
2023-05-09T00:05:05.8011774Z Copyright (c) Microsoft Corporation.  All rights reserved.
2023-05-09T00:05:05.8041476Z
2023-05-09T00:05:07.4008269Z Starting test execution, please wait...
2023-05-09T00:05:07.6491029Z A total of 1 test files matched the specified pattern.
2023-05-09T00:05:13.9493572Z Results File: D:\a\_work\_temp\cloudtest_7868ae7dc000000_2023-05-09_00_05_13.trx
2023-05-09T00:05:13.9494005Z
2023-05-09T00:05:13.9546156Z Passed!  - Failed:     0, Passed:     1, Skipped:     0, Total:     1, Duration: 1 s - <REDACTED>.dll (net6.0)
...
OTHER TESTS RAN HERE
...
2023-05-09T00:05:33.8666513Z
2023-05-09T00:05:33.8672104Z Attachments:
2023-05-09T00:05:33.8673590Z   D:\a\_work\_temp\0d002ebc-2d15-429a-a3f3-c17379668f37\cloudtest_7868ae7dc000000_2023-05-09.00_05_22.coverage
2023-05-09T00:05:34.3692491Z Info: Azure Pipelines hosted agents have been updated and now contain .Net 5.x SDK/Runtime along with the older .Net Core version which are currently lts. Unless you have locked down a SDK version for your project(s), 5.x SDK might be picked up which might have breaking behavior as compared to previous versions. You can learn more about the breaking changes here: https://docs.microsoft.com/en-us/dotnet/core/tools/ and https://docs.microsoft.com/en-us/dotnet/core/compatibility/ . To learn about more such changes and troubleshoot, refer here: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/build/dotnet-core-cli?view=azure-devops#troubleshooting
2023-05-09T00:05:34.3720209Z ##[section]Async Command Start: Publish test results
2023-05-09T00:05:34.5214496Z Publishing test results to test run '170680411'
2023-05-09T00:05:34.5214700Z Test results remaining: 1. Test run id: 170680411
2023-05-09T00:05:34.5215745Z Publishing test results to test run '170680412'
2023-05-09T00:05:34.5215983Z Test results remaining: 24. Test run id: 170680412
2023-05-09T00:05:34.5223024Z Publishing test results to test run '170680414'
2023-05-09T00:05:34.5223190Z Test results remaining: 120. Test run id: 170680414
2023-05-09T00:05:34.5948482Z Publishing test results to test run '170680413'
2023-05-09T00:05:34.5948696Z Test results remaining: 2. Test run id: 170680413
2023-05-09T00:05:35.3766263Z Published Test Run : https://<REDACTED>.visualstudio.com<REDACTED>_a=runCharts
...
OTHER TESTS PUBLISHED HERE
...
2023-05-09T00:05:36.6436384Z ##[section]Async Command End: Publish test results
2023-05-09T00:05:36.6437364Z ##[section]Finishing: Unit tests

Relevant log output
Publishing task

Starting: Publish Unit tests results
==============================================================================
Task         : Publish Test Results
Description  : Publish test results to Azure Pipelines
Version      : 2.216.2
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/test/publish-test-results
==============================================================================
"C:\Program Files\dotnet\dotnet.exe" --version
7.0.203
D:\a\_work\_tasks\PublishTestResults_0b0f01ed-7dde-43ff-9cbb-e48954daf9b1\2.216.2\modules\TestResultsPublisher.exe @D:\a\_work\_temp\b53961f0-ee04-11ed-9063-4db997aedddb.txt
No build level attachments to publish.
Result Attachments will be stored in LogStore
Run Attachments will be stored in LogStore
Publishing test results to test run '170686998'.
TestResults To Publish 1, Test run id:170686998
Test results publishing 1, remaining: 0. Test run id: 170686998
Publishing test results to test run '170686999'.
TestResults To Publish 24, Test run id:170686999
Test results publishing 24, remaining: 0. Test run id: 170686999
Publishing test results to test run '170687000'.
TestResults To Publish 120, Test run id:170687000
Test results publishing 120, remaining: 0. Test run id: 170687000
Publishing test results to test run '170687001'.
TestResults To Publish 2, Test run id:170687001
Test results publishing 2, remaining: 0. Test run id: 170687001
Published Test Run : https://<REDACTED>.visualstudio.com/Teamspace/_TestManagement/Runs?runId=<REDACTED>&_a=runCharts
...
OTHER TESTS PUBLISHED HERE
...
Async Command Start: PublishTestResultsToEvidenceStore
Async Command End: PublishTestResultsToEvidenceStore
Finishing: Publish Unit tests results

Aditional info
I have my task configured as such:

  - task: DotNetCoreCLI@2
    displayName: 'Unit tests'
    condition: succeeded()
    inputs:
      command: test
      projects: '**/*Tests/*.csproj'
      configuration: '$(BuildConfiguration)'
      arguments: '--no-build --no-restore --configuration $(BuildConfiguration) --collect "Code Coverage"'
      publishTestResults: true

Which has no effect on test coverage (test results are published accordingly)
I can only get coverage when I explicitly publish the tests (contrary to what the documentation says it should work):
  - task: DotNetCoreCLI@2
    displayName: 'Unit tests'
    condition: succeeded()
    inputs:
      command: test
      projects: '**/*Tests/*.csproj'
      configuration: '$(BuildConfiguration)'
      arguments: '--no-build --no-restore --configuration $(BuildConfiguration) --logger trx --results-directory $(Agent.TempDirectory) --collect "Code Coverage"'
      publishTestResults: false # Automatic publishing doesn't work for coverage check, this will be done in the next step

  - task: PublishTestResults@2
    displayName: "Publish Unit tests results"
    condition: succeededOrFailed()
    inputs:
      testResultsFormat: VSTest
      testResultsFiles: "**/*.trx"
      searchFolder: "$(Agent.TempDirectory)"
      mergeTestResults: false
      failTaskOnFailedTests: true

Still not fixed


Error running script

I was attempting to analyze a file in Ghidra, but the following set of errors were returned instead, and I'm not real sure where to begin troubleshooting.
intezer_analyze_gh_community.py> Running...
>>> Program Info:
>>>	winta.exe:
	x86:LE:64:default_windows
	(Wed Sep 02 14:52:52 CDT 2020)
	/Users/dmoore/Documents/repository/samples/gotroj/winta.exe
>>> file SHA : 57150938be45c4d9c742ab24c693acc14cc071d23b088a1facc2a7512af89414
>>> Start analyzing file...
Traceback (most recent call last):
  File "/Users/dmoore/ghidra_scripts/analyze-community-ghidra-plugin/intezer_analyze_gh_community.py", line 284, in run
    helper.create_function_map(sha256)
  File "/Users/dmoore/ghidra_scripts/analyze-community-ghidra-plugin/intezer_analyze_gh_community.py", line 242, in create_function_map
    function_map = self._get_function_map(sha256)
  File "/Users/dmoore/ghidra_scripts/analyze-community-ghidra-plugin/intezer_analyze_gh_community.py", line 166, in _get_function_map
    result_url = self._proxy.create_plugin_report(sha256, functions_data)
  File "/Users/dmoore/ghidra_scripts/analyze-community-ghidra-plugin/intezer_analyze_gh_community.py", line 104, in create_plugin_report
    response = self._post(URLS['create_ghidra_plugin_report'].format(sha256), json={'functions_data': functions_data})
  File "/Users/dmoore/ghidra_scripts/analyze-community-ghidra-plugin/intezer_analyze_gh_community.py", line 91, in _post
    response = self.session.post(url_path, **kwargs)
  File "/Users/dmoore/Library/Python/2.7/lib/python/site-packages/requests/sessions.py", line 578, in post
    return self.request('POST', url, data=data, json=json, **kwargs)
  File "/Users/dmoore/Library/Python/2.7/lib/python/site-packages/requests/sessions.py", line 530, in request
    resp = self.send(prep, **send_kwargs)
  File "/Users/dmoore/Library/Python/2.7/lib/python/site-packages/requests/sessions.py", line 643, in send
    r = adapter.send(request, **kwargs)
  File "/Users/dmoore/Library/Python/2.7/lib/python/site-packages/requests/adapters.py", line 498, in send
    raise ConnectionError(err, request=request)
ConnectionError: ('Connection aborted.', BadStatusLine("''",))
intezer_analyze_gh_community.py> Finished!

Is it consistent? The error suggests network error.

I have a number of emotet samples, and for some the script works, for others I consistently get the error above. All have been uploaded to intezer and the difference is reproducible.

@davidt99 I've encountered that error on a few samples I've attempted to analyze, so in that regard, yes, it is constant.

@dmoore44 have you analyzed the file in the platform before executing the plugin?

if you can share the sha256, I will be able to take a look for any errors on the backend side.

@dmoore44 if you wish, you can contact our support with the hashes so we can pin point the problems.


Remove default secret/namespace creation Monitoring/Alerting V2

This PR reverts the auto creation of the default namespace and secret config by the UI. The backend will you a pre-install hook to create the defaults.
https://github.com/rancher/dashboard/issues/1088#issuecomment-689035231
PR is in draft until @aiyengar2 gives the go ahead to merge so we can sync the backend and front end changes.

@vincent99 I talked with @aiyengar2 and we both feel this can probably be merged in. I found a small bug in the default creating logic that I dont want to fix if its just going to be wiped out. The UI would be in a state where the create default config option isn't really doing that though. At least until the backend pre-install hook stuff is merged. I think we can alert QA to this and that if they want to test they'll need to provide a secret.


solve compilation problem for iOS7 targeted apps

Solve issue when the code is included in iOS 7 targeted app using Swift 2.0

Thanks very much! 👍

np


Whether memcached only  support  PLAIN and CRAM-MD5 sasl authentication?

I am trying to find out the list of authentication mechanisms that Memcached supports. I have looked at the documentation pages and found nothing.
Whether only PLAIN and CRAM-MD5 are supported.
Is this true or does Memcached supports any other authentication mechanisms?

It's blindly passing SASL data to a SASL engine. honestly I'm not sure offhand which is possible to support, but I don't think anything is specifically restricting it.

if you need further help, please try the mailing list. the issues are for bug reports mainly.


BUG/ENH: stats: updates for cauchy.

Simplify the expressions for the CDF and SF by using arctan2. The new expressions give good precision over the entire domain.
Wrap Boost functions to use in the _ppf and _isf methods.

Closes gh-20761.

The CI failures are not related to the changes in this PR.

I looked at the boost source and it looks very straightforward. How about coding the logic in Python in SciPy instead of wrapping it through special? I think this would make the SciPy code simpler and more transparent.
Btw, I’m a bit skeptical about the boost code. Firstly, the code contains a lot of if (false == condition) blocks, which is seen as an anti-pattern by some style guides. Secondly, its quantile_imp(p) function first “chops” p by setting p = p - floor(p). This has two problems: (1) It accepts quantiles out of the range [0,1], which is not mathematically correct (as far as I understand), and (2) it would return -inf for p=1, which is wrong (should return +inf).

Re: Boost code: Take another look at the Boost code.  p is validated in detail::check_probability(function, p, &result, Policy()), so it does not allow values outside of [0, 1]. (This wouldn't matter in _cauchy_ppf anyway, since we only use this private function in a place where p has already been validated.)  I'm note sure why that use of p - floor(p) is there; @jzmaddock, is that needed? Also note that it computes -scale / tan(constants::pi<RealType>() * P), where P was computed above; P is not p.  If you take a look at the tests that I include in the PR, you'll see that the precision is good.  Did you find a case where it is not?
The Boost code is relatively simple in this case, but will still require conditionals if we implement the same method as the Boost code, which means it should really be implemented as a ufunc in a compiled language.  So we might as well use the existing code in Boost.
If there are any problems in the Boost code, we can create an issue for it at the boost/math github page.

LGTM, let's just wait if Boost folks answer about the issue raised there.

I've seen your message, I just haven't had a chance to look into anything yet!

LGTM, let's just wait if Boost folks answer about the issue raised there.

I've seen your message, I just haven't had a chance to look into anything yet!

No worries, take your time ;).

Fine to wait, but note that the Boost issue that I created is not to report a bug.  I don't think the calculation is wrong. I just suspect that the call of floor(p) is superfluous, and if that is the case, removing it won't change anything compared to the current version.

Thanks for the reply and thanks for opening the issue in boost @WarrenWeckesser. While a redundant line has no effect on the result (other than requiring that the floor function be defined for RealType), it might confuse the reader as for the preconditions of the function.
I think the accuracy is good with the boost implementation. The code handles p=0.5, so the relative error for this input is zero. The code doesn’t handle p=0.25 and the result is inexact but within one ulp. A proper cotPi function might offer improved accuracy (on the scale of 1 ulp), but it is probably more of theoretical than practical utility. (Plus, I’m not aware of an existing “proper” implementation of cotPi that does better than 1/tan except for the special inputs.)
A corner case for the boost function is p=5e-324, which overflows. I’m not sure whether the boost policy handles/is supposed to handle this case, but fortunately this is of no concern to SciPy as SciPy expects it to silently overflow.
I’m not sure where to draw the line between “a simple expression that can be coded in Python” and “a complex expression/subroutine that may as well be wrapped”; after all this might be more about preference than else.

@fancidev, I've spent time studying Boost Math's code base and documentation, and my impression is that the quality is consistently pretty high. @jzmaddock and @mborland have always been responsive to issues [1] and are both highly knowledgeable and capable. I think it's important not to develop unreasonable expectations for large and sophisticated open source projects maintained by only a handful of developers. In large projects where maintainers must budget their time carefully, there's a lot of ways that superfluous lines or other code style issues can work their way into functions which are otherwise reliable and accurate. I'd hate to think that someone would be skeptical to use SciPy because of code style issues buried in our many lines of legacy code, expecting us to go over everything with a fine tooth comb. That just can't be a priority, given the many more pressing things there are to work on.
Using Boost here fits in well with how these things are typically done in stats. There's no sense in duplicating effort if an actively maintained project already has a quality implementation of something, and we've already paid the upfront costs of being able to wrap Boost functions in stats, so adding another doesn't really pose any additional maintenance burden.
Also, fyi, Boost's handling of 5e-324, the smallest IEEE 754 double subnormal, is correct. From mpmath

from mpmath import mp

# set dps high enough that 5e-324 - 0.5 can be computed.
mp.dps = 325

result = mp.tan(mp.pi*(mp.mpf(5e-324) - 0.5))
result
# mp.mpf('-67910890959664488207227276014646400664432274938268186332936844073597587140521399412467025083466631534943557183740723444627834866709243394597774122333171615796876821382242554818974304268233855183634540082045787435784718190024759024461615967607349956776028802373117561992963170991790585498278925074443105214894785214174106785.875')

# The result is too big to fit in a double.
float(result)
# -inf

[1] The superfluous line you've pointed out has already been removed https://github.com/boostorg/math/pull/1174.

Thanks for the explanations @steppi ! I’m gladly surprised and impressed that the spurious line gets removed so quickly, which I didn’t expect for a large project like boost!
I understand that boost is probably the most widely used and tested C++ library. In addition, unlike some of the modules that are specific to the C++ language, boost/math provides quality reference implementation that are highly valuable for general use. I’d be honored if I could contribute to the boost code base!
Maybe along with this high expectation comes my scrutiny for code style. But I don’t intend to make a big deal of it because the value of a library is its functionality rather than its style, and style preference is subjective anyway.
My point about 5e-324 is that the function takes a policy argument, and there is code that optionally throws an overflow error (depending on the policy) if p is equal to 0 or 1. But the code does not check the policy for small p, such as 5e324, that would overflow numerically. I don’t know if the policy argument is supposed to handle this sort of corner case (which are quite difficult to handle systematically), so I don’t see it as an obvious bug. (For this particular case, because tan(x) = x + o(x), 1/tan(x) will only overflow for subnormal x, which is somewhat contrived.)

My point about 5e-324 is that the function takes a policy argument, and there is code that optionally throws an overflow error (depending on the policy) if p is equal to 0 or 1. But the code does not check the policy for small p, such as 5e324, that would overflow numerically. I don’t know if the policy argument is supposed to handle this sort of corner case (which are quite difficult to handle systematically), so I don’t see it as an obvious bug. (For this particular case, because tan(x) = x + o(x), 1/tan(x) will only overflow for subnormal x, which is somewhat contrived.)

Just speculating, because I haven't actually looked closely at this, but I think what's going on there is that if you check for the cases p == 0 or p == 1 and directly return an answer, an overflow error won't be raised just because you returned + or - infinity. However, an overflow error will occur if an overflow occurs when computing an actual expression. If you think there's actually a problem here though, I'd suggest testing out locally if it behaves as you'd expect for 5e-324, and if not, submitting an issue to Boost.


Test integration with Azurite and update docs

Per @khalidabuhakmeh:
https://twitter.com/buhakmeh/status/1394990191740346370
Blocked by:

[x] https://github.com/Azure/Azurite/issues/790
[x] https://github.com/Azure/Azurite/issues/791
[x] https://github.com/Azure/Azurite/issues/792
[x] https://github.com/Azure/Azurite/issues/793
[x] https://github.com/Azure/Azurite/issues/794
[x] https://github.com/Azure/Azurite/issues/1210

Workaround: sort on client side

[x] https://github.com/Azure/Azurite/issues/1211

Workaround: used constant non-empty PK/RK

[ ] https://github.com/Azure/Azurite/issues/959

Workaround: use service SAS instead of account SAS

[x] https://github.com/Azure/Azurite/issues/1214
[ ] https://github.com/Azure/Azurite/issues/1215

Workaround: this is not a blocker

[x] https://github.com/Azure/Azurite/issues/1216
[x] https://github.com/Azure/Azurite/issues/1227

Workaround: this is not a blocker

[x] https://github.com/Azure/Azurite/issues/1228
[x] https://github.com/Azure/Azurite/issues/1229

Workaround: change the unit test to just send back a wrong timestamp-based weak etag

[x] https://github.com/Azure/Azurite/issues/1230
[x] https://github.com/Azure/Azurite/issues/1232
[x] https://github.com/Azure/Azurite/issues/1233
[x] https://github.com/Azure/Azurite/issues/1234
[x] https://github.com/Azure/Azurite/issues/1318

Workaround: this is not a blocker

[x] https://github.com/Azure/Azurite/issues/1319

Workaround: disable the related test

[x] https://github.com/Azure/Azurite/issues/1467
[x] https://github.com/Azure/Azurite/issues/1465
[x] https://github.com/Azure/Azurite/issues/1565

I'll try to unblock all these ASAP.
We already have some PRs in the pipeline. 😄

I have made a ghcr.io/joelverhagen/azurite:edge Docker image with all of the fixes I could hack together:
https://github.com/joelverhagen/Azurite/tree/edge
I used it temporarily in this PR which sets up a Tye config: https://github.com/NuGet/Insights/pull/41

All tests are passing on Azurite 3.19.0!


Fix custom node label issue

https://github.com/rancher/rancher/issues/12691

https://github.com/rancher/rancher/issues/12691#issuecomment-386411132

What? No.. these are labels to be given to the agent container to then add on to the node, just like in 1.x. They are not labels to assign to the agent container itself, why would anybody want that?


Storing PaCMAP on DB?

Hello.
I'm trying to store the PaCMAP model in a db for further transformations. I tried to pickle, but the tree is an annoy.annoy object.
Also tried to save the annoy.annoy object with embedding.tree.save('./annoy_object.ann'), this works but I cannot load, since creating the PaCMAP do not initialize the  annoy.annoy tree.
Is there a way to save/load PaCMAP object or tree? My main objective is to send it to a DB, so I can transform new incoming data in my clustering pipeline.
Thanks for your attention.

Have you tried to directly load the annoy instance? It could be done using something like this:
embedding = pacmap.PaCMAP() # initialize/load the saved pacmap instance
embedding.tree = load_annoy_tree() # your function that loads the annoy instance

Hello! I did tried what you suggested, and even completed the others attributes that the method required to run:
embedding = pacmap.PaCMAP() u = AnnoyIndex(0) u.load('test.ann') embedding.tree  = u embedding.xmin = emb_model.xmin embedding.xmax = emb_model.xmax embedding.xmean = emb_model.xmean embedding.tsvd_transformer = emb_model.tsvd_transformer embedding.pair_FP = emb_model.pair_FP embedding.pair_MN = emb_model.pair_MN embedding.pair_neighbors = emb_model.pair_neighbors embedding.n_neighbors = emb_model.n_neighbors embedding.transform(feature_matrix_c)
But I still get:
`---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
/tmp/ipykernel_26194/902635302.py in
----> 1 embedding.transform(feature_matrix_c)
/opt/conda/lib/python3.9/site-packages/pacmap/pacmap.py in transform(self, X, basis, init, save_pairs)
932                                      self.apply_pca, self.verbose)
933         # Sample pairs
--> 934         self.pair_XP = generate_extra_pair_basis(basis, X,
935                                                  self.n_neighbors,
936                                                  self.tree,
/opt/conda/lib/python3.9/site-packages/pacmap/pacmap.py in generate_extra_pair_basis(basis, X, n_neighbors, tree, distance, verbose)
417
418     for i in range(npr):
--> 419         nbrs[i, :], knn_distances[i, :] = tree.get_nns_by_vector(
420             X[i, :], n_neighbors_extra, include_distances=True)
421
IndexError: Vector has wrong length (expected 0, got 17)

Seems like the problem is in your initialization of the AnnoyIndex. It seems like the number of dimensions you are using is 17, therefore for loading the annoy index, you should initialize it with u = AnnoyIndex(17) instead of u = AnnoyIndex(0).

For some reason I cannot load the saved PaCMAP with index 17. I have to load with index 18, but this crashes the transform function. Idk if this is a PaCMAP problem or annoy index problem.
But it would be nice to have a PaCMAP function to correctly save and load its models.

I see. We will work on that feature.


Docs error

On https://cogeotiff.github.io/rio-cogeo/API/ under 1. there is:
# Create GeoTIFF profile
bounds = mercantile.bounds(mercantile.Tile(0,0,0))
src_transform = from_bounds(*bounds, 1024 1024)

Should read:
# Create GeoTIFF profile
bounds = mercantile.bounds(mercantile.Tile(0,0,0))
src_transform = from_bounds(*bounds, 1024, 1024)

Also this needs to be float32:
img_array = tile = numpy.random.rand(3, 1024, 1024).astype('float32')

Also this needs to be float32:
img_array = tile = numpy.random.rand(3, 1024, 1024).astype('float32')

Thanks for reporting! 🙏

Thanks for reporting! 🙏


Add test for #2

Add a test that installs pip<6.0 to trigger the error with older pip versions, verifies that #2 exists and will pass when it's resolved. Probably shouldn't merge this until it's fixed unless you don't mind the builds failing :)

Yeah I'll wait a bit. Thanks for contributing though!


Global usage percentage seems wrong

While viewing the webp feature, I noticed total global usage listed at 93.21% support today.
That means that 6.79% of browsers don't support webp today.
However, there is a large discrepancy when adding up all the unsupported red versions.
0.56 + 0.12 + 0.07 + 0.54 + 0.03 + 0.69 + 1.32 + 0.08 = 3.41%

So 6.79% of browsers don't support webp but only 3.41% of those are in the chart.
Where is the other 3.38% attributed to? Other, less popular browsers?

If look at the dropdown above the usage percentages, you'll see the options are "all users", "all tracked", "tracked mobile" and "tracked desktop".
If you set the dropdown to "all tracked" in this case, the global percentage changes to 96.48%, which matches up with your unsupported percentage if you allow for a 0.01% rounding error. So the answer to where the other 3.38% come from is that they aren't "tracked" browsers - presumably being browsers that CanIUse doesn't track the support status of.
Personally I just look at the tracked browser percentages and assume they're roughly representative of even the un-tracked browser support.

I see. I guess the confusing part is that untracked is the default selection (all users) but the chart doesn’t represent that, only tracked.
So perhaps when all users is selected, the chart could have an additional bar to represent “other” browsers.

It would be nice to at least have an % of filtered option. I was under the impression that the usage percentages at the top right of each feature was an overview of the data currently being shown, but it does not adjust when filtering the browsers. This is quite confusing and seems like a disconnect as far as the interface goes.


question about 'time since last report'

Hello, great app. I extracted, ran it, and set my league path to Local Disk>Riot Games>League of Legends. I reported but the 'time since last report' says 46 days. Is this a bug or am I doing something wrong? Thanks.

Hi ! It's normal cuz it's the date of the original config file, I didn't change it mb

Ah okay. Thanks!


Bump python version to 3.11

Would love to use python 3.11 with the popular python dev containers.

Python 3.11 is available - how are you trying to use it?

Thanks @abdulrabbani00 for opening up the PR - https://github.com/devcontainers/templates/pull/51
Python 3.11 options are now available 🚀


/tini vs /usr/bin/tini

After installing tini on Alpine via
$ apk add --update --repository http://dl-1.alpinelinux.org/alpine/edge/community/ tini
then tini lives in /usr/bin
This caught me out for a while because the earlier ADD installation ends
ENTRYPOINT ["/tini", "--"]
Maybe edit the alpine instructions and add...
For example
RUN apk add --update --repository http://dl-1.alpinelinux.org/alpine/edge/community/ tini
ENTRYPOINT ["/usr/bin/tini", "--"]
Many thanks

Ugh. Good catch, thanks for the heads up!
I'll probably just update the instructions to use /usr/bin everywhere.

Good idea.
One other thing I just remembered. I was also caught out because my Dockerfile started
FROM alpine:3.2
I had to edit that to
FROM alpine:edge
Cheers

@JonJagger you dont have to use edge to install tini from apk.
apk add --update --repository http://dl-1.alpinelinux.org/alpine/edge/community/ tini

should just work.

Maybe the repository was temporarily down and with edge it tries a different one as a fall back?

@danilobuerger @JonJagger  it didn't work for me either but the following did:
apk add --update --repository http://dl-cdn.alpinelinux.org/alpine/edge/community/ tini

(I got it by first trying with alpine:edge, where it does fallback to this one)

tini was moved to community repository so it will be available for the v3.4 Alpine release.
I would like to move it from /usr/bin/tini to /sbin/tini where it belongs, but it will break your docker images again. That said, edge repositories is not considered stable, which you already discovered.
Should i bother add a combat /usr/bin/tini symlink?

Just in /sbin/ is fine by me.
Cheers
Jon
On Wed, May 4, 2016 at 9:44 PM, Natanael Copa<EMAIL_ADDRESS>wrote:

tini was moved to community repository so it will be available for the
v3.4 Alpine release.
I would like to move it from /usr/bin/tini to /sbin/tini where it
belongs, but it will break your docker images again. That said, edge
repositories is not considered stable, which you already discovered.
Should i bother add a combat /usr/bin/tini symlink?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/krallin/tini/issues/38#issuecomment-216997122

--
Cyber-Dojo : a place to practise the collaborative game called software
development.
Server at http://www.cyber-dojo.org
Open-sourced at http://github.com/JonJagger/cyberdojo
Explained at http://jonjagger.blogspot.co.uk/p/cyber-dojo_2380.html
Video of Roman Numerals kata in Ruby at https://vimeo.com/104548135

Hey @ncopa,
First, thanks a ton for the heads up! I really appreciate it.

I would like to move it from /usr/bin/tini to /sbin/tini where it belongs, but it will break your docker images again. That said, edge repositories is not considered stable, which you already discovered.

I'm assuming users that are installing via apk add --update --repository http://dl-cdn.alpinelinux.org/alpine/edge/community/ tini will also be affected, right?

Should i bother add a combat /usr/bin/tini symlink?

My README doesn't indicate the full path for Alpine, but there's definitely a number of Alpine / Tini users that have installed Tini via apk and that are currently using the full path to hit it: https://github.com/search?utf8=✓&q="%2Fusr%2Fbin%2Ftini"+apk&type=Code&ref=searchresults  (of course, there might also be some users this search doesn't find, or who don't host their Dockerfile in a public GitHub repo).
I would definitely prefer not breaking their builds. Is adding a symlink something you've done for other packages in the past?
Let me know if I can help in any way.
Thanks again!

@krallin I have made symlinks in the past for compatibility. But if I add the combat symlink for the v3.4 release, then i am afraid that people will keep the /usr/bin/tini and we will end up supporting both for eternity.
I think I´ll just move it to /sbin so it gets correct from v3.4 and forward. As mentioned, I also think it is important to know that things in edge repositories are not considered stable, so people who gets bitten by this can also adjust their repo to stable repo while at it.
I am also open for back porting tini to v3.3 (current stable). But then it will also be as /sbin/tini.

@ncopa I understand your concern about never being able to deprecate it — as a middle ground, could we perhaps add a shell script in /usr/bin/tini prompting users to update before /usr/bin/tini goes away?
Something like the following might work:
#!/bin/sh
echo 'WARNING: Tini has been relocated to /sbin/tini.
Please update your scripts to use /sbin/tini going forward.
/usr/bin/tini has been preserved for backwards compatibility in Alpine 3.4,
but will be removed in Alpine 3.5.' >&2

exec /sbin/tini "$@"

(I reckon one can also indicate that edge isn't stable in there)

@krallin sounds like a good idea. I´ll do this.

Thanks so much @ncopa, I really appreciate it :)

When do you release 3.4 with tiny?

alpine 3.4 is supposed to be released in May 2016.


Add some diagnostics

With this, some extra diagnostics are printed when verbose output is requested with -v:
Number of reads: 1000000
Number of non-rescue hits: 25160733 total. Per read: 25.16
Number of non-rescue NAMs: 27321159 total. Per read: 27.32
Number of rescue hits: 583028 total. Per rescue attempt: 23.07
Number of rescue NAMs: 11457402 total. Per rescue attempt: 453.27

I’m using this to figure out why the multi-context seeds branch makes strobealign slower.

I need to check whether the "Number of rescue NAMs" figure is actually correct as it is so high.

One problem appears to be that we have two different types of "hits".
The first type of hit is a randstrobe successfully looked up in the index, represented by the start position in the StrobemerIndex::randstrobes vector (first entry with the same hash as the randstrobe).
In find_nams, for example, nr_good_hits and total_hits are used with that meaning:
https://github.com/ksahlin/strobealign/blob/a5bd1fd8f1b450109849d8e1910c1d8e250fafd7/src/nam.cpp#L165-L173
Also, the RescueHit (in the same file) is such a hit.
The second type is an interval on the query paired with an interval on the reference. This is, in particular, the Hit struct:
https://github.com/ksahlin/strobealign/blob/a5bd1fd8f1b450109849d8e1910c1d8e250fafd7/src/nam.cpp#L5-L10
You get a list of such hits when one takes a hit according to the first definition and iterates through all index positions at which the hash matches.
This meaning of hit is used in, for example, merge_hits_into_nams, add_to_hits_per_ref, Nam::n_hits.
The new statistics output in this PR uses the first meaning of hit, but I thought it was the second. With the second meaning, we would expect to see fewer NAMs then hits (because hits are merged into NAMs), which made me suspicious, but since it is the first meaning, this does not have to be the case.
Any suggestions for a better name for one of the two variants of hits?

For printing diagnostics, maybe we could use distinct hash matches for the first type and seed/hit locations for the second type? These are not ideal variable names if you refer to changing variable names.  I think 'position/location' or 'pos/loc' should be included in the second as it is the characteristic that separates them.

I thought about this some more and have a suggestion that would feel quite natural to me and requires only minimal changes: We simply rename the Hit struct to Match.
That is, we continue using the term "hit" for strobemer successfully looked up in the index and then use the term "match" for a locus on the query paired with a locus on the reference.
I think this would be quite nice because we merge the latter entities into NAMs, and then we could say that we merge multiple overlapping matches into non-overlapping, approximate matches (=NAMs).
I think the logging output could actually stay as it is (it is only shown with -v anyway and is mostly useful for us). But if we want, we could extend it print the number of matches:
Number of reads: 1000000
Number of non-rescue hits: 25160733 total. Per read: 25.16
Number of non-rescue matches: xyz total. Per read: xx.yy
Number of non-rescue NAMs: 27321159 total. Per read: 27.32
Number of rescue hits: 583028 total. Per rescue attempt: 23.07
Number of rescue matches: xyz total. Per rescue attempt: xx.yy
Number of rescue NAMs: 11457402 total. Per rescue attempt: 453.27

I tried to use "distinct hash matches" and "query randstrobes found in index", but it feels a bit contorted. And these messages are not self-explanatory anyway, so they might as well be concise and use clearly defined terms.
I took a liberty to push a commit that makes the above change so that you can judge for yourself if you want.

Ok, I like the suggestion.
Some Qs:

Does this mean that a hit does not become a match only if the hit was too repetitive (filtered out)?
is Number of non-rescue hits incremented with 1 or with count(hit) for each seed found in the index?
How can Number of non-rescue NAMs be larger than Number of non-rescue hits in the numbers above? Assuming you haven't made up the numbers in the example. (related to Q2?)

[...] for each seed found in the index?

By the way, does a "seed" correspond to a "hit" or a "match"? Or do you use the term loosely and it be either?
It would also be totally fine with me to use "seed" instead of hit or match if you think that fits better for one of the terms.

Ok, now everything I clear. I approve a merge.

By the way, does a "seed" correspond to a "hit" or a "match"? Or do you use the term loosely and it be either?

Sorry for writing seed. I am not a 100% sure there is an agreed definition of a seed in the literature. If there is, my guess is that a seed implies its a match (to extend from..). Let us stick with your terminology of hit and match.

And there’s no reason k cannot be larger than n.

Agreed. Also, we could theoretically have up to nk nams (i.e. we are not able to merge any match).

I’ve removed the last commit that does the renaming because that will add some conflicts with the multi-context seeds branch. I’ll open a separate PR that only does the renaming. We can then merge that one after mcs.


Support targeting solution filters

Closes #125
The options in the select targets list now look much the same as "Open Solution" in VSCode. Could be cool to do a proximity sort or something in the future...
I've left out flowing solution filters through to predict_sln_file to avoid behaviour changes, which means they can only be selected manually for now. In a future release it'd be handy to flow them through to choose_target, if and when you decide to rename the options, as discussed in the issue. I'll probably do so in my fork in the meantime, so feel free to ping me for a PR if wanted.

Cool, I've pushed those changes. Happy to revert the target selection changes in bc291551a637204088dc3a8d125eb424fbf0b41a if you want. Its extremely rare that I want to fall back to a project instead of choosing between potential targets myself, so I thought I'd suggest it.
You wrote in the issue

I have actually been considering adding the .csproj files it finds to the vim.ui.select list, so that it is possible to only load a single project. Then target as a name fits better.

I didn't implement this because a) I'd never use it 😆, and b) VSCode doesn't let you. I'd suggest putting it behind a config flag if you where to add it, otherwise the target list will get unwieldy (it's already longer than a page on my very large solution).

Oh, and also note I've never written Lua other than (mostly copy and paste) in my config file, so you may want to check over the PR extra carefully 😄. It seems to work on various repos of different shapes and sizes on my machine.

I didn't implement this because a) I'd never use it 😆, and b) VSCode doesn't let you. I'd suggest putting it behind a config flag if you where to add it, otherwise the target list will get unwieldy (it's already longer than a page on my very large solution).

Yeah that makes sense! No problem not implementing it😄 I haven't really decided yet if I want it myself, it's just something I have thought about before
Thanks! I will review soon😄

I've applied that fix and squashed some commits to keep the git incremental. Sorry if that messes with your local branch :).

Thanks a lot!

Thanks. The README should be updated to reflect these changes. I think this should do it, if you'd like to push the changes :)
diff --git a/README.md b/README.md
index 32d712ea99a1..40e7920f777f 100644
--- a/README.md
+++ b/README.md
@@ -107,29 +107,29 @@ The plugin comes with the following defaults:
     -- a lot faster to initialize.
     filewatching = true,

-    -- Optional function that takes an array of solutions as the only argument. Return the solution you
-    -- want to use. If it returns `nil`, then it falls back to guessing the solution like normal
+    -- Optional function that takes an array of targets as the only argument. Return the target you
+    -- want to use. If it returns `nil`, then it falls back to guessing the target like normal
     -- Example:
     --
-    -- choose_sln = function(sln)
-    --     return vim.iter(sln):find(function(item)
+    -- choose_target = function(target)
+    --     return vim.iter(target):find(function(item)
     --         if string.match(item, "Foo.sln") then
     --             return item
     --         end
     --     end)
     -- end
-    choose_sln = nil,
+    choose_target = nil,

-    -- Optional function that takes the selected solution as the only argument.
+    -- Optional function that takes the selected target as the only argument.
     -- Returns a boolean of whether it should be ignored to attach to or not
     --
     -- I am for example using this to disable a solution with a lot of .NET Framework code on mac
     -- Example:
     --
-    -- ignore_sln = function(sln)
-    --     return string.match(sln, "Foo.sln") ~= nil
+    -- ignore_target = function(target)
+    --     return string.match(target, "Foo.sln") ~= nil
     -- end
-    ignore_sln = nil,
+    ignore_target = nil,

     -- Whether or not to look for solution files in the child of the (root).
     -- Set this to true if you have some projects that are not a child of the

``

Good point, will do🙌


Abstract space hierarchy

Most of the Abstract space hierarchy is not necessary if you just want to do the things you did with CityGML 2.0. The “AbstractPhysicSpace” / “AbstractOccupiedSpace”  is more or less the same as the CityObject in CityGML 2.0.  I do not see a big advantage for those users (such as ADV in Germany, sveral million buildings in LoD1 and 2).
It looks like the Abstract space hierarchy is mainly introduced to model “AbstractVoid” – this is useful in some applications, but couldn’t it be modeled as a separate module?
It would be good if the "space concept" does not have such a big impact on the core, but will be modeled as a separate module. So people can make use of it if they have the need.

to illustrate the issue:

AbstractVoid is an AbstractUnoccupiedSpace is an AbstractPhysicalSpace is an AbstractSpace is an AbstractCityObject. Why is this necessary? AbstractPhysicalSpace and AbstractUnoccupiedSpace do not have Attributes, so it is just a new name. AbstractUnoccupiedSpace inherits occupancyDaytime and occupancyNighttime from AbstractSPace. Why? Isn't it UnoccupiedSpace?
In a data exchange format, all these Abstract classes will never appear. But if I want to generate Java Code out of it, I will end up with many Abstract classes or Interfaces that does not improve the readabilty of the code ("Matrjoschka" style) and I do not understand the benefits.

What is the argument for this degree of nesting? Symmetry? Structural consistency? I think there is one.

In the web conference on 28 March 2019 we agreed that the issue has become obsolete, because Void does not exist any more (see issue #22) and also because of the discussion in issue #7.
Regarding the attributes occupancyDaytime and occupancyNighttime we discussed that the attributes are very application-specific and defined too high in the generalisation hierarchy.
We agreed on proposing an alternative modelling as part of the Construction and Transportation modules. In addition, we will define occupancy as qualified attribute, in this way various occupancies can be defined (e.g. morning, afternoon, weekend).

The issue is closed as no further discussion on this issue took place after the web conference.
The discussion on occupancy is moved to the new issue #62.


Error 404

Hi!
I am using @chrisloftus/homebridge-bmw-connected v1.0.1 (2020-07-18) on my homebridge 1.1.7
The plugin always replies:
`[1/25/2021, 17:06:14] [Auto]  ERROR REQUEST RESULTS: null 404

404 Not Found

Not Found
The requested URL was not found on this server.

[1/25/2021, 17:06:14] [Auto]  ERROR REQUEST RESULTS: null 404

404 Not Found

Not Found
The requested URL was not found on this server.

`
Maybe this is a DNS problem, I also can´t reach bmw-connecteddrive.co.uk via my browsers.
But if I try the german page
bmw-connecteddrive.de or the fully syntax
https://www.bmw-connecteddrive.co.uk/
it works. Is there any chance to put in the full https link?
Thanks,
Jo

Was a problem with my PIHole, works now.

Was a problem with my PIHole, works now.

 Never worked..
Estevan DGB

On Jan 26, 2021, at 8:09 AM, JoMensdorf<EMAIL_ADDRESS>wrote:

Hi!
I am using @chrisloftus/homebridge-bmw-connected v1.0.1 (2020-07-18) on my homebridge 1.1.7
The plugin always replies:
`[1/25/2021, 17:06:14] [Auto] ERROR REQUEST RESULTS: null 404
404 Not Found
Not Found
The requested URL was not found on this server.
[1/25/2021, 17:06:14] [Auto] ERROR REQUEST RESULTS: null 404 404 Not Found
Not Found
The requested URL was not found on this server.
`
Maybe this is a DNS problem, I also can´t reach bmw-connecteddrive.co.uk via my browsers.
But if I try the german page
bmw-connecteddrive.de or the fully syntax
https://www.bmw-connecteddrive.co.uk/
it works. Is there any chance to put in the full https link?
Thanks,
Jo
You can view, comment on, or merge this pull request online at:
https://github.com/gadget-man/homebridge-bmw-connected/pull/1
Commit Summary
Fix lock/unlock
Use npm scope
Remove publishConfig
Fix registerAccessory name
Create FUNDING.yml
File Changes
A .github/FUNDING.yml (12)
M index.js (27)
A package-lock.json (2838)
M package.json (10)
Patch Links:
https://github.com/gadget-man/homebridge-bmw-connected/pull/1.patch
https://github.com/gadget-man/homebridge-bmw-connected/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

 Never worked..
Estevan DGB

On Jan 26, 2021, at 8:09 AM, JoMensdorf<EMAIL_ADDRESS>wrote:

Hi!
I am using @chrisloftus/homebridge-bmw-connected v1.0.1 (2020-07-18) on my homebridge 1.1.7
The plugin always replies:
`[1/25/2021, 17:06:14] [Auto] ERROR REQUEST RESULTS: null 404
404 Not Found
Not Found
The requested URL was not found on this server.
[1/25/2021, 17:06:14] [Auto] ERROR REQUEST RESULTS: null 404 404 Not Found
Not Found
The requested URL was not found on this server.
`
Maybe this is a DNS problem, I also can´t reach bmw-connecteddrive.co.uk via my browsers.
But if I try the german page
bmw-connecteddrive.de or the fully syntax
https://www.bmw-connecteddrive.co.uk/
it works. Is there any chance to put in the full https link?
Thanks,
Jo
You can view, comment on, or merge this pull request online at:
https://github.com/gadget-man/homebridge-bmw-connected/pull/1
Commit Summary
Fix lock/unlock
Use npm scope
Remove publishConfig
Fix registerAccessory name
Create FUNDING.yml
File Changes
A .github/FUNDING.yml (12)
M index.js (27)
A package-lock.json (2838)
M package.json (10)
Patch Links:
https://github.com/gadget-man/homebridge-bmw-connected/pull/1.patch
https://github.com/gadget-man/homebridge-bmw-connected/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Consolidate the nginx-* into a single nginx-consul container

[x] Installs cleanly on a fresh build of most recent master branch
[x] Upgrades cleanly from the most recent release
[x] Updates documentation relevant to the changes

The nginx configuration variables do_consul_ssl, do_marathon_auth, etc
are written to consul and the nginx templates are configured via consul-template

Do not merge until the ciscocloud docker containers are updated. This PR currently uses my nginx-consul docker container.

This looks awesome!!

👍  :)

Success on a new build and an upgrade from 1.03. It is necessary to run this before upgrading:
ansible-playbook -e @security.yml playbooks/upgrade-nginx-consul.yml
This will be documented and incorporated into an upgrade playbook in #1392


[UI] Tour / Guide

It could be very nice to have an onboarding module.
Or perhaps just a theme this one or another ?
https://github.com/usablica/intro.js /  http://usablica.github.io/intro.js/
or this one : http://github.hubspot.com/shepherd/docs/welcome/

+1

I tweaked Intro.js plugin to work with Semantic UI. Have a look at : https://github.com/mariusWeceipt/intro.js
Initialization, step and hint definition works the same as "classic" intro.js : https://github.com/usablica/intro.js
Added an option to change elements color. Just use introJs().setOption({ 'customColor' : 'teal' }). Default color is Semantic UI's teal, but you can use any color class name (teal, pink, positive, primary, etc...).


Unable to insert logo

Great work on this plug in, very simple to get going.
I cant seem to insert a logo - have tried PNG/TIFF/JPEG all with the same result.
Each time I select one, it shows the file missing icon - i'm selecting a file from a local folder (not network)
Have I configured something incorrectly, do they need to be copied to a specific location?

Hi, make sure to copy the logos into the "logos" folder.


Can not find the code file 'perpare' in folder 'lib'

I can't find the code file ‘perpare’ 、‘modules’ and ‘datasets_clip’ in folder 'lib'. when I run this code, it report errors such as:
ModuleNotFoundError: No module named 'lib.perpare'.

Did you solve this problem?
I also had the same error，It is not clear whether the current release is the complete code。


[Enhancement]: Add a framework  of SLSA  with a focus on mitigating supply-chain risk

Contact Details
No response
Is there an existing issue for this?

[X] I have searched all the existing issues

What would you like to be added?
SLSA  is aframework for assessing the security practices of a given software project with a focus on mitigating supply-chain risk. SLSA emphasises tamper resistance of artifacts as well asephemerality of the build and release cycle.
SLSA mitigates a series of attack vectors in the soft ware development life cycle (SDLC), all ofwhich have seen real-world examples of successful attacks against open-source and proprietary software.
Why is this needed?
No response
Anything else?
No response

The compilation environment of SLSA on GitHub is relatively independent, while some binaries of CubeFS require more additional C-like libraries, so they need to be compiled in the customized Docker image of CubeFS. The method of running a custom Docker image in the GitHub SLSA action environment is currently under research.
For more information on the progress of each module: #2811. PR to master see(#2813), to release 3.3.1 see(#2857)


Added subclass of gamma motor neurons

Added dynamic and static gamma motor neurons and 'synapsed to' their respective nuclear bag fiber.
Related to closed tickets #738 & #848

Thanks @paolaroncaglia, was cleaning up my tickets and saw your name there, so thought I'd add you, but I'm looking at the date and realised that that was more me learning how to write defs in ontology. Thanks so much for picking up the mistakes, ill go look through them and clean them up :)


Getting error while running yarn prisma deploy

Hi I'm encountering the following error while running yarn prisma install
# xxxx @ xxxx-ThinkPad-X230 in ~/www/tutos/hackernews-react-apollo/server on git:master x [11:42:48]
$ yarn prisma deploy
yarn run v1.17.3
$ prisma deploy
? Set up a new Prisma server or deploy to an existing server? Demo server + MySQL database
? Choose the region of your demo server xxxxxxxxxxxxxxx-d77b97/demo-eu1
? Choose a name for your service server
? Choose a name for your stage dev

Written endpoint `https://eu1.prisma.sh/xxxxxxxxxxxxxxx-d77b97/server/dev` to prisma.yml

Deploying service `server` to stage `dev` to server `prisma-eu1` 368ms
Service is already up to date.

post-deploy:
 ▸    Cannot use GraphQLNonNull "LinkWhereUniqueInput!" from another module or
 ▸    realm.
 ▸
 ▸    Ensure that there is only one instance of "graphql" in the node_modules
 ▸    directory. If different versions of "graphql" are the dependencies of
 ▸    other
 ▸    relied on modules, use "resolutions" to ensure only one version is
 ▸    installed.
 ▸
 ▸    https://yarnpkg.com/en/docs/selective-version-resolutions
 ▸
 ▸    Duplicate "graphql" modules cannot be used at the same time since
 ▸    different
 ▸    versions may have different capabilities and behavior. The data from one
 ▸    version used in the function from another could produce confusing and
 ▸    spurious results.

Get in touch if you need help: https://spectrum.chat/prisma
To get more detailed output, run $ export DEBUG="*"

Running prisma generate...

Generating schema... 52ms
Running prisma generate ✖
Done in 16.93s.

# xxxx @ xxxx-ThinkPad-X230 in ~/www/tutos/hackernews-react-apollo/server on git:master x [11:43:14]
$ yarn start
yarn run v1.17.3
$ node src/index.js
events.js:183
      throw er; // Unhandled 'error' event
      ^

Error: listen EADDRINUSE :::4000
    at Object._errnoException (util.js:1022:11)
    at _exceptionWithHostPort (util.js:1044:20)
    at Server.setupListenHandle [as _listen2] (net.js:1367:14)
    at listenInCluster (net.js:1408:12)
    at Server.listen (net.js:1492:7)
    at /home/xxxx/www/tutos/hackernews-react-apollo/server/node_modules/graphql-yoga/dist/index.js:344:28
    at new Promise (<anonymous>)
    at GraphQLServer.start (/home/xxxx/www/tutos/hackernews-react-apollo/server/node_modules/graphql-yoga/dist/index.js:342:16)
    at Object.<anonymous> (/home/xxxx/www/tutos/hackernews-react-apollo/server/src/index.js:27:8)
    at Module._compile (module.js:652:30)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I confirmed this error. I see this as well!

this is a solution, remove yarn.lock and do yarn install again -->
https://github.com/howtographql/react-apollo/issues/33

This solves the issue

Solved it for me too. Can we close this?

yarn prisma deploy doesn't work for me: deploy is not a prisma command.


Clear Diagnostics for deleted files

We already listen to files being deleted and remove them from Flix. If errors exist in these however, we don't clear the diagnostics.

It would appear this is a limitation of the file watcher.
https://github.com/microsoft/vscode/issues/60813#issuecomment-543735008

As a workaround we could watch for changes to folders (rename, delete) and either

Try removing the old uris (and adding the new in case of folder rename) - might work
Show a prompt to the user along the lines of: "Folder names have changed. Do you wish to restart the plugin?" with [yes,no] options
Automatically restart the plugin if we suspect we need to initialise everything from the ground up

I think I would prefer 2.


Adding example for conditional upsert

Added an example for performing conditional upsert using @if directive.

This change is

Coverage remained the same at 89.286% when pulling 73c38e34b911ffbbbdfe743f35d47db21bea83eb on prashant/conditional-upsert-docs into b232e298fed311bab638f86e683d7c84144d0ffa on master.


In k-means neighborhood notebook, fix excluded_channels=None

Closes #787
What is the purpose of this PR?
Fixes bug in kmeans neighborhood notebook if excluded_channels is None.
How did you implement your changes
Include check for excluded_channels is None before subsetting data table.

I think the problem was that she had the wrong PRE_CHANNEL_COL and POST_CHANNEL_COL in settings.py. Basically, we use those two columns to pull out all the channel names, and then we check that the excluded markers are within those channel names. Since she had the wrong columns, the channel names weren't getting identified correctly.
At least I think that's what the issues was, she hasn't confirmed that it works.


epss-add.sh does not delete .csv files.

PROBREM:
epss-add.sh does not delete .csv files, so /opt/epss-db/epss-data/*.csv files increase.
TARGET

epss-add.sh
epss-autoAdd.sh(Because epss-add.sh is used internally)

TOBE:
Modify epss-add.sh to delete the file after importing it into the database.

add rm $OUTFILE

I will fix it in the next update.
Until then, please do the following:

rm /opt/epss-db/epss-data/*.csv after execute epss-add.sh/epss-autoAdd.sh

fix epss-add.sh at #6 .


fzf-completion() breaks when global alias tail is defined

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
When I have the following line in my .zshrc:
alias -g tail="multitail -Cs --follow-all"

then when I try to use fzf-completion(), it fails with the following error message:
fzf-completion:local:1: not valid in this context: -Cs

The solution is probably just to add setopt no_aliases, like you did here: https://github.com/junegunn/fzf/issues/1708#issuecomment-543000287

Please send a pull request.

I tried, but I could not get it to work. setopt noaliases doesn't seem to have any affect on global aliases. It seems to disable normal aliases only.
I will just use a non-global alias or a function instead.

It should work with global aliases:
$ alias -g foo=bar
$ echo foo
bar
$ setopt no_aliases
$ foo
foo

I'm not sure but it's probably a bug of zsh that it's not working as expected in that particular context.

alias -g tail="multitail -Cs --follow-all"

f() {
  setopt localoptions no_aliases
  local tail
  tail=1
  echo $tail
}

g() {
  setopt localoptions no_aliases
  local tail=1
  echo $tail
}

$ type -f f
f () {
        setopt localoptions no_aliases
        local multitail -Cs --follow-all
        tail=1
        echo $tail
}

$ type -f g
g () {
        setopt localoptions no_aliases
        local tail=1
        echo $tail
}

🤷♂ 🤷♀

That does indeed look like a bug in zsh to me. I sent a bug report to<EMAIL_ADDRESS>I'll let you know if I get a reply.

OK, here's the full reply: http://www.zsh.org/mla/workers/2020/msg00456.html
If I'm going to rewrite fzf's zsh code to use autoloading functions (which I think is by far the best option presented), then I would also like to rewrite it as a zsh plugin, which would make the code much more convenient to use. But then we're not talking pull request anymore, because a zsh plugin is required to live in its own repo: https://github.com/zdharma/Zsh-100-Commits-Club/blob/master/Zsh-Plugin-Standard.adoc#what-is-a-zsh-plugin

But then we're not talking pull request anymore, because a zsh plugin is required to live in its own repo: https://github.com/zdharma/Zsh-100-Commits-Club/blob/master/Zsh-Plugin-Standard.adoc#what-is-a-zsh-plugin

That document isn't a standard in any meaningful sense. Take it with a (massive) grain of salt.

Do you think this approach is valid?
diff --git a/shell/completion.zsh b/shell/completion.zsh
index b6aec33..4f0281f 100644
--- a/shell/completion.zsh
+++ b/shell/completion.zsh
@@ -10,6 +10,7 @@
 # - $FZF_COMPLETION_OPTS    (default: empty)

 if [[ $- =~ i ]]; then
+if [[ -n "$__fzf_sourcing" ]]; then

 # To use custom commands instead of find, override _fzf_compgen_{path,dir}
 if ! declare -f _fzf_compgen_path > /dev/null; then
@@ -241,4 +242,11 @@ fzf-completion() {
 zle     -N   fzf-completion
 bindkey '^I' fzf-completion

+else
+  __fzf_sourcing=1
+  [[ ! -o noaliases ]] && setopt noaliases && __reset_aliases=1
+  source "$0"
+  [[ -n "$__reset_aliases" ]] && setopt aliases && unset __reset_aliases
+  unset __fzf_sourcing
+fi
 fi

Do you think this approach is valid?

This will break in many cases.
The following should work well:
diff --git a/shell/completion.zsh b/shell/completion.zsh
index b6aec33..ac02309 100644
--- a/shell/completion.zsh
+++ b/shell/completion.zsh
@@ -9,7 +9,23 @@
 # - $FZF_COMPLETION_TRIGGER (default: '**')
 # - $FZF_COMPLETION_OPTS    (default: empty)

-if [[ $- =~ i ]]; then
+if 'zmodload' 'zsh/parameter' 2>'/dev/null'; then
+  __fzf_restore_options="options=(${(j: :)${(kv)options[@]}})"
+else
+  () {
+    'local' 'on' 'off' '__fzf_opt'
+    for __fzf_opt in "${(@)${(@f)$(set -o)}%% *}"; do
+      [[ -o "$__fzf_opt" ]] && on+=" $__fzf_opt" || off+=" $__fzf_opt"
+    done
+    __fzf_restore_options="${on:+setopt$on}; ${off:+unsetopt$off}"
+  }
+fi
+
+'emulate' 'zsh' '-o' 'no_aliases'
+
+{
+
+[[ -o interactive ]] || return 0

 # To use custom commands instead of find, override _fzf_compgen_{path,dir}
 if ! declare -f _fzf_compgen_path > /dev/null; then
@@ -241,4 +257,6 @@ fzf-completion() {
 zle     -N   fzf-completion
 bindkey '^I' fzf-completion

-fi
+} always {
+  eval $__fzf_restore_options
+}

This should work with any shell options -- the meat of completions.zsh will always be parsed with the standard zsh options (those marked with <Z> in man zshoptions) sans aliases.
It should have no effect on loading or execution speed. In virtually all setups (except a few very ancient or broken Zsh installations) the first branch of the if will be taken. That's the fast branch. The else branch does the same thing but it's orders of magnitude slower due to a fork.
Note: Many words are quoted to prevent alias expansion. Some words cannot be quoted so they use ugly names instead (e.g., __fzf_opt).
The only way to break this code is by defining crazy aliases like this:
alias if='}'
alias -g do='}'

And of course you can also break it with crazy functions:
function emulate() { exit 1 }

I've updated the patch in my previous comment. Please reapply if you've already applied it.

Thanks for the patch. Care to open a pull request? And should we do the same in key-bindings.zsh?

Thanks for the patch. Care to open a pull request? And should we do the same in key-bindings.zsh?

Sent https://github.com/junegunn/fzf/pull/1944.

Thanks, @romkatv!


[Feature request] Proper health check  BOUNTY 210k sat

Is your feature request related to a problem? Please describe.
The health check endpoint currently returns 200 basically always, even if the node connection is lost. This makes it useless.
Describe the solution you'd like
Ideally the health check endpoint would return proper status information to be ingested e.g. bei Prometheus and other monitoring software.
Describe alternatives you've considered
For the meantime, we’d be happy if the endpoint simply checked the node connection and whether invoice creation is possible. For this we will pay 210k sat to whoever implements the PR, once that PR is merged into a release.

PR here: https://github.com/lnbits/lnbits/pull/2736

Fixed via https://github.com/lnbits/lnbits/pull/2736


Add & remove

What does this PR do?
This PR is raised to implement the following features: 👍 :

[x] Remove all hardcoded items from the tasks array.
[x] Create a new JavaScript file for the new functionality.
[x] Implement a function for adding a new task (add a new element to the array).
[x] Implement a function for deleting a task (remove an element from the array).
[x] Implement a function for editing task descriptions.
[x] By default new tasks should have the property completed set to false and the property index set to the value of the new array length
[x] Deleting a task should update all remaining items' indexes, so they represent the current list order and are unique
[x] All changes to the To Do List should be saved in local storage.

Description of the completed tasks 👍

[x] Update Read me file
[x] Add the HTML for the structure.
[x] Add the CSS file for the styling.
[x] Use the linter tool that analyzes my source code to flag programming errors, bugs, stylistic errors, and suspicious constructs. 💯

Thank you very much for the thorough review @fobadara 🥳


Dockerless CLI - Integration test design (cross-platform)

We need our integration tests cross-platform. Therefore we need to design a model for building the infrastructure to do so and which integration tests should run when.
DOD

[ ] Create a design for cross-platform testing infrastructure
[ ] Include which tests should be run and when

closing opened in wrong repo


Add github action for clang-format

Currently the code does not actually pass clang format. Would be good to also run that one periodically as an action given that it's pretty quick.

Silly me, we do have that action (thanks @Kaufi-Jonas !). The problem is that we currently use clang-format without --Werror, so the formatting error is just a warning and the check is green. (e.g. here: https://github.com/simbricks/simbricks/actions/runs/4158314265/jobs/7193443141#step:3:6).


Fix Uri docs

The doc comments for impl From<Uri> for Parts actually described
Uri::from_parts.

D'oh, this and #538 are too close together and cannot be cleanly merged one after the other.  So, I'm adding this as a second commit to #538.


Syntax highlighting missing in hover with *.module.scss file

Hi there, first of all, thanks for this extension, really great! 🙌
In the readme, it shows syntax highlighting in the hover of a class imported from a *.module.scss file.
However, the syntax highlighting does not appear for me:

I also tried it with the square brackets syntax, but this also did not help:

Also simplifying the CSS did not help:

The syntax highlighting does however work here with the React Style Helper extension (repo):

Code
// page.module.scss
.bodyBold {
  display: flex;

  & h2 {
    // abc
    padding: 0 40px;
  }
}

// page.tsx
import styles from './page.module.scss';

export default function Login() {
  return (
    <div className={styles.bodyBold}>

@karlhorky Thanks for reporting the issue .
I will try to investigate this issue .

@karlhorky I could not reproduce this issue.
Can you give me more information about the version of VS code you are using plus the details of your OS

Maybe it's highlighting on your system because of another extension that you have installed?
My versions:

macOS Ventura 13.1 (22C65)
Tested on 2 VS Code versions

No extensions + VS Code Insiders 1.75.0-insider
With some extensions + VS Code 1.74.2

@karlhorky I suspected it and then disabled other extensions but still couldn't reproduce it. Then again I debugged #33 in development mode without any extensions , then I was able to reproduce it.
#33 This should close this issue.

@Viijay-Kr thanks for that, version 1.3.1 seems to work! 🙌

Actually now this has been fixed, the only last feature that is missing vs the React Style Helper extension is auto-import of styles default import from *.module.css/scss/sass files.
So if the feature from the issue below was implemented, then I can tell all of our students to uninstall React Style Helper and switch fully to your extension!

https://github.com/Viijay-Kr/react-ts-css/issues/20

@karlhorky I can work on it.


Fixes session active detection on force_https function and add more test CodeIgniter::forceSecureAccess() run force_https()

Add more test of  CodeIgniter\CodeIgniter class. Added test for CodeIgniter\CodeIgniter::forceSecureAccess() that run force_https() function when $config->forceGlobalSecureRequests is true.
Checklist:

[x] Securely signed commits
[x] Unit testing, with >80% coverage

I updated PR title description for the new fix.

I've added test for force_https() with null request and response as parameters.

travis build green 🎉


Border only top of barchart

Is it possible to only draw a border on the top of a barchart like in this example:

You'd probably need to change the draw method on the bar objects. https://github.com/chartjs/Chart.js/blob/master/src/elements/element.rectangle.js#L56

@etimberg I remember a PR about that feature, but can't find it. I think we should support:
borderWidth: {
   top: 1,
   right: 0,
   bottom: 0,
   left: 0
}

as we do for some padding options (could be the same for borderColor). Then we could deprecate the limited borderSkipped option since borderSkipped: 'bottom' (default) would be equivalent to borderWidth.bottom: 0.

Agreed, I remember discussing that but I don’t think it was ever implemented. We should do it though

That would be a very nice feature to include. Thanky for your help !

That would be a very nice feature to include. Thanky for your help !

This simple dirty solution also did the job:
`Chart.elements.Rectangle.prototype.draw = function() {
		var ctx = this._chart.ctx;
		var vm = this._view;
		var left, right, top, bottom, signX, signY, borderSkipped;
		var borderWidth = vm.borderWidth;

		if(vm.borderSkipped == "showOnlyTop") {
			borderWidth = 0;
		}

		if (!vm.horizontal) {
			// bar
			left = vm.x - vm.width / 2;
			right = vm.x + vm.width / 2;
			top = vm.y;
			bottom = vm.base;
			signX = 1;
			signY = bottom > top ? 1 : -1;
			borderSkipped = vm.borderSkipped || 'bottom';
		} else {
			// horizontal bar
			left = vm.base;
			right = vm.x;
			top = vm.y - vm.height / 2;
			bottom = vm.y + vm.height / 2;
			signX = right > left ? 1 : -1;
			signY = 1;
			borderSkipped = vm.borderSkipped || 'left';
		}

		// Canvas doesn't allow us to stroke inside the width so we can
		// adjust the sizes to fit if we're setting a stroke on the line
		if (borderWidth) {
			// borderWidth shold be less than bar width and bar height.
			var barSize = Math.min(Math.abs(left - right), Math.abs(top - bottom));
			borderWidth = borderWidth > barSize ? barSize : borderWidth;
			var halfStroke = borderWidth / 2;
			// Adjust borderWidth when bar top position is near vm.base(zero).
			var borderLeft = left + (borderSkipped !== 'left' ? halfStroke * signX : 0);
			var borderRight = right + (borderSkipped !== 'right' ? -halfStroke * signX : 0);
			var borderTop = top + (borderSkipped !== 'top' ? halfStroke * signY : 0);
			var borderBottom = bottom + (borderSkipped !== 'bottom' ? -halfStroke * signY : 0);
			// not become a vertical line?
			if (borderLeft !== borderRight) {
				top = borderTop;
				bottom = borderBottom;
			}
			// not become a horizontal line?
			if (borderTop !== borderBottom) {
				left = borderLeft;
				right = borderRight;
			}
		}

		ctx.beginPath();
		ctx.fillStyle = vm.backgroundColor;
		ctx.strokeStyle = vm.borderColor;
		ctx.lineWidth = borderWidth;

		// Corner points, from bottom-left to bottom-right clockwise
		// | 1 2 |
		// | 0 3 |
		var corners = [
			[left, bottom],
			[left, top],
			[right, top],
			[right, bottom]
		];

		// Find first (starting) corner with fallback to 'bottom'
		var borders = ['bottom', 'left', 'top', 'right'];
		var startCorner = borders.indexOf(borderSkipped, 0);
		if (startCorner === -1) {
			startCorner = 0;
		}

		function cornerAt(index) {
			return corners[(0 + index) % 4];
		}

		// Draw rectangle from 'startCorner'
		var corner = cornerAt(0);
		ctx.moveTo(corner[0], corner[1]);

		for (var i = 1; i < 4; i++) {
			corner = cornerAt(i);
			ctx.lineTo(corner[0], corner[1]);
		}

		ctx.fill();
		if (borderWidth) {
			ctx.stroke();
		}

		if(vm.borderSkipped == "showOnlyTop") {

			ctx.beginPath();
			ctx.fillStyle = vm.backgroundColor;
			ctx.strokeStyle = vm.borderColor;
			ctx.lineWidth = borderWidth;

			var corner = cornerAt(1);
			ctx.lineTo(corner[0], corner[1]);
			var corner = cornerAt(2);
			ctx.lineTo(corner[0], corner[1]);

			ctx.stroke();
		}

	}`

Any update on that, guys? Unfortunately prototype method overload doesn't work for my case.

Closing as solved
Please ask questions on StackOverflow: https://stackoverflow.com/questions/tagged/chart.js

@prayer007 its superb! can you edit it to show border only if there is some data (for example in _chart.data.datasets[0].data[i].y)?


esp32wifi

Summary

This PR consists of the following 2 commits
commit 1: arch: xtensa: Fix a compile warning in xtensa_dumpstate.c
commit 2: boards: esp32-devkitc: Add wapi_smp to test Wi-Fi in SMP mode

Impact

None

Testing

Tested with wapi, telnetd, ostest

I've adjusted CONFIG_NSH_TELNETD_CLIENTSTACKSIZ and CONFIG_USERMAIN_STACKSIZE.

@masayuki2009 FYI, there is this repo https://github.com/espressif/xtensa-isa-doc that has some Xtensa documentation if you are interested.


Adds customConfig method in Field

Hi there!
So, today I came across a plugin which allows quick and bulk editing ACF fields. It uses custom config keys inside each field to enable/disable the quick/bulk editing behaviour.
When looking through Extended ACF, I couldn't find a way of setting these one-off config keys. Since I will use them in a single field, I wouldn't like to extend a class just for this one case.
So I'm proposing adding a customConfig method to the core Field class, which allows manually setting a config key/value pair.
Sample usage:
Select::make('Test field')
    ->customConfig('allow_bulkedit', 1)
    ->customConfig('allow_quickedit', 1),

Cheers!

Thanks for the pull request Guilherme!
I do understand what you're trying to achieve but I'm not sure this is the solution. It is already possible to extend the existing fields like any other PHP class:
use WordPlate\Acf\Fields\Select as Field;

class Select extends Field
{
	public function myKey($value)
	{
		$this->config->set('my-key, $value);

		return $this;
	}
}

I like your idea but for now I think extending existing fields is the way to go. We might revisit this in the future.

I've added this to the documentation.

Hi, Vincent!
I do understand we can already extend the field classes to add this behaviour, but it seems a bit heavy handed to me for a behaviour which I, personally, expected to be available as a core option.
Also, there's a possible scenario where you'd like to set a custom config key in multiple field types and you'd need to extend each one of them and add the same function multiple times, which feels nonoptimal.
Those are just my opinions, though, so I'm totally fine if you still think that's the way to go.
Cheers!

PS: just saw this is similar to what's been previously discussed in #44 and PR'd in #48 , so I'm sorry for bringing this up as a new PR.

Thanks for the comments. I'll keep this in mind for future releases. If we were to add it we need to find a good and straight forward naming convention.


Remove sentence in 6.2.1

Remove

"According to the E-ARK Common Specification for IPs an IP can have several representations. All representations contain the same intellectual content, but as the name implies is another representation; in its most simple form this could be another file format such as TIFF instead of JPEG."

from:
https://dilcisboard.github.io/E-ARK-CSIP/specification/implementation/considerations/#621-the-structure-for-ip-their-representations-and-their-segments
It is a leftover from the time the recommendation was not part of CSIP and I don't see that it makes any added value. At least it should be reformulated.

Has been removed


Should prevent from starting application without required environment keys

It should have the capability to parse and break the system startup when the required environment keys are missing. So users can easily configure the required environment keys.

Resolution: COMPLETED


Testcases failing on both on PPC64le and x86 VM

Testcases failing on both on PPC64le and x86 and getting following error for both.
Error: ERROR: Invocation
build-steps_Sign.txt
PPC64le_Sign_failures.txt
X86_Sign_Failures.txt
Error for command /ansible-sign/.tox/py3/bin/pytest --basetemp /tmp/ansible-sign-pytest --color=yes (exited with code 1)
Result: 12 failed, 17 passed, 11 errors

Hi, what OS and version are you doing this on?

I think this is an issue with dependency versions being out of sync.
Can you try doing this using the system package for python3 instead of building Python from source? I think you will have better luck.
For example, you're installing python 3.10 from the upstream, but then pulling in header files from the system python3 version (with python3-devel).
In fact, I don't actually see where you are using the upstream installed Python (I'm not sure what altinstall does, but tox's py3 env is going to use python3 and I don't see where you change that to point to your compiled Python).


Url links do not work as expected

Links in the file https://github.com/heartexlabs/label-studio/blob/develop/docs/source/guide/tasks.md, starting from the header,  Add the file directory as source storage in the Label Studio UI, do not seem top work.
Examples:
See Run Label Studio on Docker and use local storage
See the API documentation for importing tasks.

Documentation is here
https://labelstud.io/guide/tasks.html#Add-the-file-directory-as-source-storage-in-the-Label-Studio-UI
The files you are seeing is not compiled pages of the documentation.


[FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

What is the purpose of the change
Currently, netty threads and task thread are both accessing Unaligner. Netty thread access it indirectly through BufferReceivedListener. Thus, we need some costly synchronization and weaken the threading model of the Unaligner.
This PR mitigates it by letting priority buffers use the same handover protocol as regular buffers. Instead buffers are reordered where needed an additional wake-up mechanism is used for priority events, such that they can interrupt regular buffer processing.
Brief change log

Adding specific buffer data type for priority events.
Adding priority flags to hand-over protocols (BufferAndAvailability, BufferAndBacklog, InputWithData, ...) directly or indirectly.
Reordering buffers, channels, and gates on priority buffers, such that they are pulled before any non-priority buffer.
Adding a data structure PriorityDeque to support such reordering.
Adding priority notifications on input/output.
Handling priority notifications in CheckpointedInputGate (moved out from Unaligner). Generalized hand-over of events from CheckpointedInputGate to StreamTaskNetworkInput, such that all events are forwarded.
Removing synchronizations from Unaligner.
Moving spill handling from StreamTaskNetworkInput to Unaligner.
Removing BufferReceivedListener and letting Unaligner react on in-flight data.

UnalignedCheckpointITCase still covering along with all other ITCases and e2e (using unaligned checkpoints by default).

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no  /don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

This change is

CI shows a timeout in {{DataSinkTaskTest.testDataSinkTask}}.

CI shows a timeout in {{DataSinkTaskTest.testDataSinkTask}}.

Thanks. I converted to draft until I resolved it.
I also wanted to collect some feedback anyways before considering it a serious PR (in the sense of being mergeable).

* https://github.com/apache/flink/pull/13228/files#r493039856 is still not addressed I think?

:white_check_mark:

* azure green

:white_check_mark:

* benchmark request will not show a visible regression :)

:white_check_mark:


Docs: Translate Them

Summary
What
This serves as a meta-level issue to track translation efforts for the Litestar documentation.

[!IMPORTANT]
Members of the Litestar organization only speak so many languages; we will require verification from multiple proficient/native speakers of the target language to merge the work.

How
We will need to ensure style guides are adhered to including the use of appropriate formalities that are language-dependent. (This will also have to be verified by various speakers of the target language)

[!NOTE]
Also, see the infrastructure changes required below.

Languages
This is the current list of tentative languages to be translated.
Other languages can be listed here as they are brought up by anyone seeking to do the translation work in the format of:
- [ ] Language
   - Assigned Translator(s)

[ ] Turkish

@hasansezertasan

Considerations
How do we keep the documentation up to date? One change would require a PR to be opened in all translated languages... At the risk of having fragmented, out of date docs it seems like we should opt for automatic translations or none at all.
Scope
The very nature of fully translating our documentation, especially as it continues to evolve and grow is long running. This issue may not even be the right medium for managing this work, but it at least gives (initial) visibility into the opportunity for others to take it on and help out.
Infrastructure
This work will require changes to existing infrastructure such as CI changes for builds and additional documentation section dependencies.
Some links to help in the set up / investigation of this:

https://sphinx-intl.readthedocs.io
https://www.codingwiththomas.com/blog/my-sphinx-best-practice-for-a-multiversion-documentation-in-different-languages
https://github.com/sphinx-doc/sphinx/issues/11713
https://devguide.python.org/documentation/translating/
https://peps.python.org/pep-0545/

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

Spanish speaker here, ready to help when needed :)

We will need to update our conf.py with links to target languages

https://www.sphinx-doc.org/en/master/usage/advanced/intl.html#translating-with-sphinx-intl
https://pydata-sphinx-theme.readthedocs.io/en/stable/community/topics/i18n.html
https://docs.readthedocs.io/en/stable/guides/manage-translations-sphinx.html

I don't think this is super maintainable without some type of automation, but it looks like Transifex offers that although quite expensive... hopefully we can get approved via their Open Source program: https://help.transifex.com/en/articles/6236788-open-source-projects

Looking at various projects, I do not think they manually translate things except core messages? For instance sphinx-doc itself only has one language of any count, Tamil at 99%, but its docs page offers many languages.

https://github.com/sphinx-doc/sphinx/blob/f4eea669e078cf9fed3f08bd1595f8f758049388/doc/internals/contributing.rst#translations
https://explore.transifex.com/sphinx-doc/sphinx-doc/

I'm still not understanding the different ways projects are doing this. The FastAPI way for example seems to rely on translation PRs that I would think could become out of date almost instantly, while sphinx-doc for example has no PRs for this and seem to be auto generating but also having transifex work available (?)... pretty lost..
Anyways - This issue will be closed if we cannot figure out a way to automatically do this.
The maintenance burden is far to high. Speaking bluntly, while our user count and project size has grown quite a bit but the contributor count has not.
The soonish work towards Litestar v3.0 needs to begin soon, and adding this to our workload when the target audience is getting by as-is for now would just be too much.
However, I am still researching ways to automate this. IF we can do that, this can proceed.
Any ideas welcome.

https://github.com/sphinx-doc/sphinx/blob/master/.github/workflows/transifex.yml may help

Just my 2 cents but whatever you do, please avoid pushing the translation commits to the same litestar-org/litestar repo.
It's so annoying browsing the timeline and realizing everything that has been done is actually translations. A repository which seems very active, is actually full of translation commits and related release note update commits.
It gives the impression that a project wants to pump/fake it's real activity, as that bloat hides away the actual work on features, bugfixes, etc.
Also, English is really the language of the world. Partially/badly/out-of-date translated docs might even do harm over folks contributing to polish the English docs. Translations are a bit of a PR stunt...
In any case, as long as translations live elsewhere and don't pollute the commit history, probably fine.

I'm going to close this for now. In the research I have done there are a number of potential issues (some with resolutions, some unsure)

Stale Documentation
In searching for automated options, there were some, but they were paid or limited.
I've reached out and looked about in various places doing large-scale documentation. Here are some from private discussions.

Which seems like it could be remedied by

We use a GHA automation to sync from the upstream. It also adds the flag fuzzy to updated entries for re-review. And when the fuzzy flag is present Sphinx ignores those entries, thus the page always shows the up-to-date content.

Which provides:

https://github.com/python/python-docs-tr/blob/3.12/.github/workflows/update_doc.yml
https://github.com/python/python-docs-tr/blob/3.12/merge.py
https://github.com/python/python-docs-tr/blob/3.12/scripts/translate.py

That seems like something worth pursuing. It will allow us to have translators volunteer in their native or fluent language(s) and on update, they will not be outdated.
However, with the coming advent of Litestar v3.0 our time is going to be really diverted into that.
If someone is interested in doing this in a way that is scalable across any arbitrary amount of languages and in the sense of maintainability (it would require discussion with us to start up to ensure maintenance costs are not high as well) then please feel free to gather your ideas and present them here, in the Discord, or GitHub discussions.
I also have a very strong opinion in favor of what @tuukkamustonen has mentioned as I see other repos do - I too wouldn't want the issue and PR log full of translation-type stuff.
This is closed as Not Planned but it is certainly available for pick up if we find good solutions to the above.


Add gocp tool

Why
Fixes https://github.com/open-telemetry/opentelemetry-go-build-tools/issues/276
Towards addressing https://github.com/open-telemetry/opentelemetry-go/issues/3846
Towards fixing https://github.com/open-telemetry/opentelemetry-go/issues/3548
Addresses https://github.com/open-telemetry/opentelemetry-go/pull/3841#discussion_r1126790695
What
Add gocpy tool that can be used for sharing internal code (more in README.md).
This tool is currently needed for https://github.com/open-telemetry/opentelemetry-go.
Prior art (with example usage): https://github.com/open-telemetry/opentelemetry-go/pull/3841
Other
Do we want to use it for internal/repo and internal/syncerror? Personally, I think there is no big need as these APIs looks pretty stable. And AFAIK the tools are bumped together. On the other hand, it may be good to dogfood for the sake of consistency across OTel Go repositories. Because I cannot find a clear answer myself, I can simply create a follow-up PR once this one is merged. It should be easier for the reviewers to decide.

The gocpy binary needs to be removed from the git history.

Done.

Closing per https://github.com/open-telemetry/opentelemetry-go-build-tools/pull/275#discussion_r1141751735. I will create a new PR (next iteration) in the following days.


Sequential Benchmarks : Normalization graphs with benchmarks (with benchmarks > 2) are wrong

Expected Outcome : Normalization graphs with more than 2 benchmarks should produce more than one colored bar graphs when  comparing with the baseline.
Actual outcome : Normalization graphs only produce one colored bar graph while selecting the oldest timestamp variant as the benchmark against the baseline benchmark.

In the above gif, the oldest timestamp gets selected (20210629) and all the other timestamps are ignored

I think since notebooks are only going to be part of sandmark this issue is stale


Unable to enter Media edit mode

Bug Description
Entering media edit mode via double click is not working.

Expected Behaviour
Double-click on media element should enter edit mode.

Steps to Reproduce

Add media
Double-click on it
See nothing happening

Screenshots

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

@bmattb FYI Pulling this into the sprint.

I approve of your selection here. 😃

@miina does this explain #6162? 😅

@miina does this explain #6162? 😅

It better! 😄  How did it get through though 🤔  I guess it needs some test adjustments, too!

Verified in QA


Data sent but "There is no Data" shown in the web interface

I'm configuring Pinpoint to run on a couple web applications that use Tanuki Software's Java Service Wrapper (SonarQube and Nexus) http://wrapper.tanukisoftware.com/
I've added the 3 parameters to the startup scripts and it seems to be working from the point of view of the monitored application.
in wrapper.conf:
wrapper.java.additional.2=-javaagent:/opt/pinpoint-agent/pinpoint-bootstrap-1.1.1.jar
wrapper.java.additional.3=-Dpinpoint.agentId=my.agent
wrapper.java.additional.4=-Dpinpoint.applicationName=myApp
I can see the TCP and UDP traffic reaching the collector box. However, the data is not in the web interface and I see no data coming out of the span UDP port (29996 in my case).
I've other applications configured on the same setup (but using Tomcat) and they work perfectly fine (I see data out on port 29996 in those cases). I've two applications using this wrapper and they both exhibit the same behavior.
Any ideas?
Here's a fragment of the log.
2015-10-08 20:19:17 [DEBUG](c.n.p.r.c.PinpointSocketHandler    :237) writePing [id: 0x340d8520, /<IP_ADDRESS>:46191 => /<IP_ADDRESS>:29994]
2015-10-08 20:19:17 [DEBUG](c.n.p.r.c.PinpointSocketHandler    :50 ) ping write success. channel:[id: 0x340d8520, /<IP_ADDRESS>:46191 => /<IP_ADDRESS>:29994]
2015-10-08 20:19:17 [DEBUG](c.n.p.r.c.PacketDecoder            :93 ) receive pong. [id: 0x340d8520, /<IP_ADDRESS>:46191 => /<IP_ADDRESS>:29994]
2015-10-08 20:19:42 [DEBUG](c.n.p.p.s.UdpDataSender            :167) Data sent. size:382, TAgentStatBatch(agentId:sonar.devops, startTimestamp:1444333453860, agentStats:[TAgentStat(timestamp:1444335557831, gc:TJvmGc(type:SERIAL, jvmMemoryHeapUsed:3953968, jvmMemoryHeapMax:778502144, jvmMemoryNonHeapUsed:15697128, jvmMemoryNonHeapMax:136314880, jvmGcOldCount:4, jvmGcOldTime:191), cpuLoad:TCpuLoad(jvmCpuLoad:0.004048582995951417, systemCpuLoad:0.004048582995951417)), TAgentStat(timestamp:1444335562831, gc:TJvmGc(type:SERIAL, jvmMemoryHeapUsed:3954768, jvmMemoryHeapMax:778502144, jvmMemoryNonHeapUsed:15697128, jvmMemoryNonHeapMax:136314880, jvmGcOldCount:4, jvmGcOldTime:191), cpuLoad:TCpuLoad(jvmCpuLoad:0.004032258064516129, systemCpuLoad:0.0020161290322580645)), TAgentStat(timestamp:1444335567831, gc:TJvmGc(type:SERIAL, jvmMemoryHeapUsed:3955568, jvmMemoryHeapMax:778502144, jvmMemoryNonHeapUsed:15697128, jvmMemoryNonHeapMax:136314880, jvmGcOldCount:4, jvmGcOldTime:191), cpuLoad:TCpuLoad(jvmCpuLoad:0.0020242914979757085, systemCpuLoad:0.0020242914979757085)), TAgentStat(timestamp:1444335572831, gc:TJvmGc(type:SERIAL, jvmMemoryHeapUsed:3956368, jvmMemoryHeapMax:778502144, jvmMemoryNonHeapUsed:15697128, jvmMemoryNonHeapMax:136314880, jvmGcOldCount:4, jvmGcOldTime:191), cpuLoad:TCpuLoad(jvmCpuLoad:0.002028397565922921, systemCpuLoad:0.02028397565922921)), TAgentStat(timestamp:1444335577831, gc:TJvmGc(type:SERIAL, jvmMemoryHeapUsed:3959384, jvmMemoryHeapMax:778502144, jvmMemoryNonHeapUsed:15697128, jvmMemoryNonHeapMax:136314880, jvmGcOldCount:4, jvmGcOldTime:191), cpuLoad:TCpuLoad(jvmCpuLoad:0.0020242914979757085, systemCpuLoad:0.004048582995951417)), TAgentStat(timestamp:1444335582831, gc:TJvmGc(type:SERIAL, jvmMemoryHeapUsed:3962280, jvmMemoryHeapMax:778502144, jvmMemoryNonHeapUsed:15697128, jvmMemoryNonHeapMax:136314880, jvmGcOldCount:4, jvmGcOldTime:191), cpuLoad:TCpuLoad(jvmCpuLoad:0.00202020202020202, systemCpuLoad:0.00404040404040404))])
2015-10-08 20:19:56 [DEBUG](c.n.p.r.c.PacketDecoder            :110) received ping. sending pong. [id: 0x340d8520, /<IP_ADDRESS>:46191 => /<IP_ADDRESS>:29994]
2015-10-08 20:19:56 [DEBUG](c.n.p.r.c.PacketDecoder            :50 ) pong write success. channel:[id: 0x340d8520, /<IP_ADDRESS>:46191 => /<IP_ADDRESS>:29994]
On the collector side

Extra information: if I open the inspector pane from a working application and replace the agent and application names in the URL, I can actually get the server information displayed. Seems like the issue is the agent not sending the information on the span port is at the culprit.

Hi aguerrieri,
No data coming out of the span port (29996) seems to suggest that the application is not getting traced.
Not entirely sure how the Java Service Wrapper above operates, but it might interfere with the instrumentation done by the Pinpoint agent.

Understood. Would it be possible to still see the inspector metrics? The problem I see with the current approach is the inspector metrics depends on having data present on the application metrics to show up. In cases like this I would still be able to see the JVM metrics (e.g. heap size) even if the instrumentation displays no data. I've been able to see that information by opening the inspector from another application and changing the agent and application names manually on the URL, but that's definitely not very intuitive.

Yes, I agree with you completely.
The server map is currently rendered using transaction data, which is why you get an empty server map when the application is not traced / there is no transaction.
We've added logic to track the agents' lifecycle in 1.5.0 (current master branch) and have the server map utilize this data (#926) - allowing the server map to render a node even if there is no transaction data available (98d7346). The branch may be unstable as it is still under development, but you can always give it a go if you'd like.
We expect 1.5.0 to be released within a month or two.

I've updated to 1.5.0 a few days ago and it indeed improve things. It still shows no data, but I can now see a box with the app, right-click and select "Inspect Agents" to see the servers's stats.

Thanks for the update.
I guess the Java Service Wrapper isn't working well with Pinpoint's BCI.
Could be due to a variety of reasons, such as changing method signatures, or messing with the class loader.
Pinpoint agent leaves instrumentation logs, and looking into it might point us to the reason why.


new functions lua_geti lua_seti

http://www.lua.org/manual/5.3/manual.html#lua_geti

int lua_geti (lua_State *L, int index, lua_Integer i);
Pushes onto the stack the value t[i], where t is the value at the given index. As in Lua, this function may trigger a metamethod for the "index" event (see §2.4).
Returns the type of the pushed value.

http://www.lua.org/manual/5.3/manual.html#lua_seti

void lua_seti (lua_State *L, int index, lua_Integer n);
Does the equivalent to t[n] = v, where t is the value at the given index and v is the value at the top of the stack.
This function pops the value from the stack. As in Lua, this function may trigger a metamethod for the "newindex" event (see §2.4).

First shot available now.


fix use of variable out of C++ scope (DEBUG only)

In DEBUG verification code we were taking the address of a temp variable
and using it out of the variable's C++ scope.
Found by OSS-Fuzz.

@dotnet-bot  test this please

@dotnet-bot test this please

Thanks @digitalinfinity


Add initial docs for Concepts

Addresses a part of #134.
Still to add

[ ] Pipeline Params
[ ] More about pipelines.

I would want to get this PR in so others (@bobcatfish) can add more info. Goal this should replace README or link from README as we work on  #136

/lgtm

whoa that is slick @tejal29 !!! <3


chore(main): release 2.0.1

:robot: I have created a release beep boop
2.0.1 (2024-02-07)
Docs

improve error feedback (a2ef373)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/itsHenry35/ledu/releases/tag/v2.0.1 :sunflower:


Fix typo

"is is" ~> "it is"

Sorry for the sparse commits. I'm not somewhere I can squash them. If you'd prefer I do, I'll gladly do that another day :)

I can't find any more typos though, I think I'm done with this article :)