feat: Add coverage for wrong cases of derive private key, signature, recovery

Greetings again, team. I have created the following pull request aiming to enhance the code coverage of the secp256k1 tests. Specifically, the proposed modifications target two instances:

Wrong case of derivePublicKey
Wrong cases of signature
Wrong cases of recovery

These amendments aim to improve the robustness and reliability of our bloom filter tests, ensuring a more comprehensive evaluation of its performance and functionality.
Code coverage BEFORE:

Code coverage AFTER:

It‘s helpful. Thanks.

coverage: 92.925% (+1.6%) from 91.293% when pulling 5cc79629572364a050f73b13db08bdc358ae981e on rodolfopietro97:increase-code-coverage-secp256k1 into b35914b5da547628895c627ab6b3abc72264ffef on vechain:master.


Use SAN cert to increase number of subdomains allowed

Per LE documentation https://letsencrypt.org/docs/rate-limits/
If you have a lot of subdomains, you may want to combine them into a single certificate, up to a limit of 100 Names per Certificate. Combined with the above limit, that means you can issue certificates containing up to 5,000 unique subdomains per week. A certificate with multiple names is often called a SAN certificate, or sometimes a UCC certificate. Note: For performance and reliability reasons, it’s better to use fewer names per certificate whenever you can.
If we make use of SAN certs, we may be able to increase the number of ksvc cert per week to 5000.

However, it seems that this would only help if multiple ksvces are deployed at the same time, or if an existing domain suffix was updated causing several services to change their domain name at the same time.


Release pressed action if event is removed

Fixes #43232
Note that the action will be released even if another event was pressed. This is because Actions don't really keep track of pressed events (related to #30888). Removing event when action is pressed is rare anyways, so it's not really a problem.

Thanks!

Cherry-picked for 3.2.4.


Request for Comment: Hybrid Composition vs Virtual Display

I just wanted to post my findings here and see if the community had anything to add. Sorry I could not find a message board or some other venue.
YoutubePlayerFlags has a flag called useHybridComposition which is on by default.
Evidently the mode of rendering native UI is a complex topic with a lot of opinions:
https://github.com/flutter/flutter/wiki/Android-Platform-Views
https://github.com/flutter/flutter/wiki/Hybrid-Composition#performance
The docs seem to imply that HybridComposition is a newer technique, and it was created in response to problems of dynamically interacting with the underlying UI. As a cost, one of the above links warns us:
While a platform view is rendered with Hybrid Composition, the Flutter UI is composed from the platform thread, which competes with other tasks like handling OS or plugin messages, etc.
I think this caused video to be unwatchable on cheaper Amazon Fire Kindles for me. (I have a rive animation playing as well, so that might be the straw that broke the camel's back). So I just opted in to the older Virtual Display mode, which for me is OK since I don't need to send touch events to the underlying web view.
So, has anyone else found choosing one of these modes has performance impact?

I have the same problem, have you solved this issue @moribellamy ?


Does ciftify_recon_all only accept output from freesurfer?

Hi:
Our team is using CONN tool box under Matlab to process the anatomical images, which gives an output in nifti format. Does ciftify_recon_all only accept output from freesurfer? Can we convert such CONN output to the cifti format?
Best,
Renxi

I haven't worked with CONN before - so I don't know exactly, but ciftify_recon_all does have a lot of "hard-coded" assumptions that the input data will follow the file naming conventions and resampling spaces of a freesurfer "recon_all" pipeline output. So I wouldn't expect it to work with another packages outputs.

Thank you!


incubator/varnish - Initial Commit for Varnish Helm Chart

Signed-off-by: Markus Wildemann<EMAIL_ADDRESS>What this PR does / why we need it:
Varnish is missing in the charts but is used widely in web projects
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @prydonius

/ok-to-test

Hi 👋 new charts are no longer accepted to stable or incubator. See Status of the Project and Deprecation Timeline for more info about that.
Good news is you can host a Helm chart yourself on GitHub, use the same tools as this repo does for automatic Chart testing and releasing, and list your Helm repo on https://helm.hub.sh. Follow this issue for info about existing guidelines and upcoming improvements: https://github.com/helm/charts/issues/7800

PS would love to see this on the Hub. Ping us in Slack if you need any help with that 😄


Add ValidatedLayer to GetAccountTxs

TODO:

[ ] Add tests

https://ci.spacemesh.io/job/CI/job/hare_tests/23/console
https://ci.spacemesh.io/job/CI/job/mining_tests/41/console
https://ci.spacemesh.io/job/CI/job/p2p_tests/171/console

✅ Automation passed


[ADLA] - Removing trailing slash for a couple LIST APIs

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/1848

Codecov Report

Merging #1526 into master will decrease coverage by <.01%.
The diff coverage is 52.98%.

@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
- Coverage   54.23%   54.23%   -0.01%
==========================================
  Files        3584     3592       +8
  Lines       88213    88360     +147
==========================================
+ Hits        47846    47925      +79
- Misses      40367    40435      +68

Impacted Files
Coverage Δ

...dels/compute_policy_create_or_update_parameters.py
100% <ø> (ø)
:arrow_up:

...mgmt/datalake/analytics/account/models/resource.py
100% <ø> (ø)
:arrow_up:

...ccount/models/data_lake_analytics_account_basic.py
100% <ø> (ø)
:arrow_up:

...atalake/analytics/account/models/compute_policy.py
100% <ø> (ø)
:arrow_up:

...s/data_lake_analytics_account_update_parameters.py
100% <ø> (ø)
:arrow_up:

...cs/account/operations/firewall_rules_operations.py
14.95% <ø> (ø)
:arrow_up:

.../account/operations/compute_policies_operations.py
76.63% <ø> (ø)
:arrow_up:

...ls/data_lake_analytics_account_properties_basic.py
45.45% <ø> (ø)
:arrow_up:

...models/compute_policy_account_create_parameters.py
100% <ø> (ø)
:arrow_up:

...tics/account/models/data_lake_analytics_account.py
100% <ø> (ø)
:arrow_up:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef9414...155e545. Read the comment docs.

@lmazuel - Please close this PR.  The latest one is here: https://github.com/Azure/azure-sdk-for-python/pull/1542
This will happen for a while because I won't receive the green light to publish the SDK for some time.


Feature/xaptc 38

PUT /test-suites service

Keep this PR and https://github.com/xtracdev/automated-perf-test/pull/46 in sync with each other to avoid painful merge conflicts

Should we pull in the changes from Feature/xaptc 37 (#46) ?

Yeah, I'll do that now after the scrum and sort any conflicts or anything like that!

Pulled story 37 (POST) merged into this. Any conflicts were resolved. All tests passing. All requested changes done. All good to go!

@frankquinn    Don't forget to pull from master

All changes addressed and master has been pulled into this story.


Confusing TotalSupplyUpdated event emitted during a mint

During an OUSD mint the following happens

rebase() is called, which emits a TotalSupplyUpdated event
mint() is called, which internally updates the total supply but does not emit a TotalSupplyUpdated event, Just a Mint event.

This causes a bit of confusion when looking at events since one would assume that the TotalSupplyUpdated includes the amount from the mint but it does not.
A possible improvement would be to:

rename the TotalSupplyUpdated event emitted in the rebase to ChangeSupply
move TotalSupplyUpdated to mint/burn

If we decide to make this change we'll need to make sure to update the analytics back-end accordingly.

CC @tomlinton and @mikeshultz for any additional input since we briefly discussed this on discord.

CC @tomlinton and @mikeshultz for any additional input since we briefly discussed this on discord.

I'm not sure this warrants contract changes.  I'm leaning towards leaving it up to better interpretation by the event consumers(in our case, ousd-analytics).  To me, TotalSupplyUpdated means the supply was explicitly updated, not just altered by mint/burn so it seems wrong to add it to that.
Here's the sister issue on ousd-analytics: https://github.com/OriginProtocol/ousd-analytics/issues/24

I'm not sure this warrants contract changes.  I'm leaning towards leaving it up to better interpretation by the event consumers(in our case, ousd-analytics).  To me, TotalSupplyUpdated means the supply was explicitly updated, not just altered by mint/burn so it seems wrong to add it to that.
Here's the sister issue on ousd-analytics: https://github.com/OriginProtocol/ousd-analytics/issues/24

Does not look like it's worth fixing. Closing.


Add Swift Version to Podspec

The Podspec is missing the swift version. I believe this project was built using Swift 5 but if the version is incorrect, let me know and I will update the PR!

This is correct, but I never thought that the swift_version must be explicitly specified.
Also while at it, can you delete the .swift-version since it is no longer supported by cocoapods.

This is correct, but I never thought that the swift_version must be explicitly specified.
Also while at it, can you delete the .swift-version since it is no longer supported by cocoapods.

@Minitour Done!

@Minitour Done!

@DomenicBianchi01 Thank you.

@DomenicBianchi01 Thank you.


Tracking - Update CAIP-10/19 for new max length & charset

Is this repo still maintained? 🤔

Yes, passively.  This is a tracking issue to warn users of the javascript library that it is out of date with recent slight changes to the spec.  PRs welcome if you'd like to close this issue by updating the string validation rules!


Fix #90 : For index name comparaison indexOf is used instead of ==

When using indexOf instead of == if a index name partially match
compouned index name, both index are considered as equal by the code.
IndexOf seems to be used because 'name' var is threated as an array.
getName definition states that the return type is a string so this fix
should be safe.

This change is

Yes, this does fix issue #98 without regression.


JSON Validation

This PR updates our ci workflow to validate all JSON files in our repository.
This is important because we have had some malformed translation files recently

.deploy

I saw POE, thought it was "Path of Exile" and thought it was accidentally committed here :laughing:

.deploy to development

.deploy


added remove_row and clear for QListModel,

added remove_row and clear for QListModel,
removed a bug (src/qabstactlistmodel.rs:166)  there inserts after clear might lead to empty entries in the model.

here, in the second example, you can see why inserting was a bug: insertRows.
Qts beginInsertRows is called over the total range of the new items. qml-rust
insert_row just inserts one item at a time. So first and last index needs to be the same.


add rest service for using the bot framework with other languages (like node/python/etc.)

this implies using the Kotlin multiplatform feature for messenger/ga connectors

a node wrapper will be available mid-october. kotlin multiplaform is targeted for 20.3

Bot-Api and Tock-Node available -> issue resolved @vsct-jburet ?


Create gcp-assistant.gpt

Adding gcp assistant gptscript.

@cloudnautique can you please review this.


Patch3

👷 Deploy Preview for sminketeatret-front processing.

Name
Link

🔨 Latest commit
3ecc1d7bfccc1a7d236a601ad0687733f06ef51c

🔍 Latest deploy log
https://app.netlify.com/sites/sminketeatret-front/deploys/653cec553ff7ce0008dec44b


Upgrade to hawkular-parent 13

I did it as part of https://github.com/hawkular/hawkular/pull/104 (to fix the issue with assembly plugin). So let's close this one and apply the other one if you don't mind.


Add summary tab with all comments

Addresses https://github.com/Azure/azure-sdk-tools/issues/730
Shows resolved and unresolved comment threads grouped by the latest revision that a comment was added. When clicking the resolved/unresolved comment link the section will collapse.
In the future we can add more useful info to the Summary tab.

Nice!
Can we reuse the comment thread template from the API page and format member name as a code line?

Nice!
Can we reuse the comment thread template from the API page and format member name as a code line?

I can update the formatting, but in terms of the the thread template I was thinking this would be a read-only view into the comments. Were you thinking that users should actually be able to act on the comments from here?

Were you thinking that users should actually be able to act on the comments from here?

If it's not hard to do would be cool to have the entire functionality.

Were you thinking that users should actually be able to act on the comments from here?

If it's not hard to do would be cool to have the entire functionality.

Eh I'm not so sure about this. There could be other context from the review that would only be visible from the API tab. Also, it will end up taking up way more real estate to use the thread template. I think of the Summary tab as basically a report showing read-only info for the review.

There could be other context from the review that would only be visible from the API tab.

Like what?

I want to eventually have something like this:

There could be other context from the review that would only be visible from the API tab.

Like what?

If the comment references other elements than the one that is being commented on. I can try it out though and see how it looks.

There could be other context from the review that would only be visible from the API tab.

Like what?

If the comment references other elements than the one that is being commented on. I can try it out though and see how it looks.

@tg-msft, as the initial requester of this feature, do you have thoughts on this?

Here's how I see the world:

(right now) < (just links) < (links + comment text) < (links + editable comments)

It would be way less frustrating to have comment summaries rather than click the link, realize it was the wrong one, click a different link, realize it's still the wrong one, click a third link, realize it's still the wrong one, and finally end up weeping into my cat.
I'm beyond happy with any forward progress though and we can do this in stages.

Here's how I see the world:

(right now) < (just links) < (links + comment text) < (links + editable comments)

It would be way less frustrating to have comment summaries rather than click the link, realize it was the wrong one, click a different link, realize it's still the wrong one, click a third link, realize it's still the wrong one, and finally end up weeping into my cat.
I'm beyond happy with any forward progress though and we can do this in stages.

Currently, the comment is shown and links out to the comment in the revision that it is in. I am going to investigate adding the full editable comments since we already have all the code for this it is just a matter of loading in all the data that we need.

To be clear, are we talking about "editing my existing comment" or "replying to an existing comment"?  I'd like to be able to quickly reply or mark things resolved if that were possible.  I care a lot less about editing my own comments from that view.

To be clear, are we talking about "editing my existing comment" or "replying to an existing comment"? I'd like to be able to quickly reply or mark things resolved if that were possible. I care a lot less about editing my own comments from that view.

Well we would get the whole markup so it also includes the ability to edit (and the client side scripts should already be loaded). We can of course remove that when displayed in this other tab, but I don't think it would be extra work to include it.

Isn't it a beauty?

Ideally the comment boxes would all be the same width.

Isn't it a beauty?

Ideally the comment boxes would all be the same width.

Fixed


Does not work with react native web

This does not detect unused styles in react native web.
https://github.com/necolas/react-native-web

Thanks for reporting this, at the moment I do not personally develop React Native Web based applications, but I'm happy to accept PR's.


Saner linters

Thorough review of the linters in use. This was triggered by #53, where I found many unresolvable conflicts among the linters.

Overall I'm -1 on this change. I'm happy to investigate conflicts.

Can't have pyright AND mypy in the same project.

That isn't true, it is done successfully in @jorenham's scipy-stubs.

Quick comment: conceptually this PR seems right. Best to pick 1 linter and 1 type checker, everything else is pretty much unworkable once the code starts getting more complex. I'd personally pick ruff (for autofix and well-maintained) and pyright (much better maintained and less buggy than mypy), but it doesn't really matter what the choices are as long as there's only one tool per type of check.

Best to pick 1 linter and type checker

In case of linters I'd agree with this, unless they're actually linting different things. In my project I always use (only) ruff for python, but I also always markdownlint, and in most cases also repo-review. These are all disjoint, so I see no problem with that.
I don't agree that you should only should pick one type checker. I always use both mypy and pyright in my projects, because I want the users to also be able to use both, which requires me to verify that both type-checkers actually understand the typing annotations.
Mypy and pyright certainly overlap, but also differ in many situations. This is mostly because mypy has >1200 bugs that pyright doesn't have (source). But unfortunately, more than half of the users use mypy at the moment, so I can't just ignore it.

RE: pylint, the Scientific Python Development guide says

PyLint is very opinionated, with a high signal-to-noise ratio. However, by limiting the default checks or by starting off a new project using them, you can get some very nice linting, including catching some problematic code that otherwise is hard to catch.

We currently use the recommended limits on the default checks. If there are conflicts with ruff then it shouldn't be difficult to extend that list.

typeshed uses both mypy and pyright


JavaWriter 3: Varargs for methods

It seems that JW 3 doesn't support ..., is this planned?

Awesome!

Doesn't work.

Works.


eth message type metrics

Describe the feature
Even if we don't handle a certain type of request, it would be interesting to see what kinds of requests we are receiving, and in what proportion (GetReceipts, GetBlockHeaders, ...). We should add metrics for this.
This would involve introducing a new metrics type with counts for each type of eth message, and then increment the counts here:
https://github.com/paradigmxyz/reth/blob/081796b138fd00a6d0af2ad463123fdbe04765ab/crates/net/network/src/eth_requests.rs#L236-L258
Additional context
No response

I'm interested in taking this one on but i noticed there's already a EthRequestHandlerMetrics here: https://github.com/paradigmxyz/reth/blob/081796b138fd00a6d0af2ad463123fdbe04765ab/crates/net/network/src/metrics.rs#L310-L318 which increments headers and bodies here: https://github.com/paradigmxyz/reth/blob/081796b138fd00a6d0af2ad463123fdbe04765ab/crates/net/network/src/eth_requests.rs#L141-L187. I can just extend it for the other two request types but wanted to make sure that that is the intended behavior.

. I can just extend it for the other two request types but wanted to make sure that that is the intended behavior.

yep, exactly!


Proposal for CTV

Submission: Open an issue in the ctv repository with the title CRAN task view proposal: MyTopic where MyTopic should be replaced with the intended name of the task view in CamelCase.
Scope: Include one or two paragraphs about the scope of the task view, outlining the inclusion and exclusion criteria as well as relevant sections within the topic.
Packages: Include a tentative list of packages for the task view. This should encompass the "core" packages and a collection of relevant packages, ideally grouped by sections within the topic. It is not important, yet, that the list of sections or packages is already exhaustive.
Overlap: Comment on potential overlap with already existing task views as well as with task views that might be created (or split off) in the future.
Maintainers: The proposal should be made by the person willing to act as the principal maintainer for the task view. Furthermore, task views should have teams of additional 1-5 co-maintainers and possible candidates for these can be listed as well in the proposal.

VisualizationStatic

Scope: This CTV summaries the static graphics packages available on CRAN. Graphics capabilities is one of the strengths of R, and it is important to have an active summary available for users.

Inclusion criteria: Package provides tools for drawing visual displays of data.
Exclusion criteria: The graphics are not interactive (direct manipulation) by default, e.g. the user cannot click on an element and have a label pop-up. It is not a low level graphics device upon which many drawing packages are rendering to screen or file.

Packages: see taxonomy list
Overlap: There is no overlap with existing CTVs. We are also proposing that new CTVs are written: VisualizationDynamic which will list packages with interactive and dynamic capabilites.
Maintainers: ??

VisualizationStatic
Scope: This CTV summaries the dynamic graphics packages available on CRAN. Dynamic graphics have historically been available in R, but new packages are emerging regularly, particularly as new technology emerges. It is important to have an active summary available for users.
Inclusion criteria: Package provides tools for drawing visual displays of data, that have some interactive (direct manipulation) or dynamic component. For example,  the user can click on an element and have a label pop-up, or the plots are rapidly updated to produce a rotation or animation.
Exclusion criteria: The graphics are not primarily interactive or dynamic. It is not a low level graphics device upon which many drawing packages are rendering to screen or file.
Packages: see taxonomy list
Overlap: There is no overlap with existing CTVs. We are also proposing that new CTVs are written: VisualizationStatic which will list packages with only static drawing capabilites. ColorPalettes will list the large array of different colour palettes available with different drawing systems. GraphicsDevices will list the variety of devices to draw graphics on the screen or output to file.
Maintainers: ??


the way using cached server data without using asyncData or Fetch when i use history.back() in SSR

I may not have found it, but when I returned to the previous page using history.back() in Nuxt, there seems to be no proper way not to go through asyncData.
I think there is a way to handle it using middleware and stores, but I think you can support it more simply with Nuxt's option..

let's track in https://github.com/nuxt/nuxt/issues/6451.


Attempted to wrap undefined property componentDidMount as function

Hello, I am following the documentation and a previously asked question just like this to the letter but I just can't get this test to work. I'd like to test the lifecycle for an Accordion component on my page.
The Accordion class is defined in a file of mine called App.js, I'm only including part of its code, it's logic and render methods are way too long anyway.
App.js (in ../src/App)
class Accordion extends Component {

    constructor() {
      super();
      this.filterLinkList = this.filterLinkList.bind(this);
      this.toggleElem = this.toggleElem.bind(this);
      this.state = {
          data: {},
          companies: {}
      };
    }

    componentDidMount() {
        $.ajax({
            url: '/data.json',
            dataType: 'json',
            cache: false,
            success: function(data) {
                this.setState({data: data});
            }.bind(this),
            error: function(xhr, status, err) {
                console.error(this.props.url, status, err.toString());
            }.bind(this)
        });

        $.ajax({
            url: '/companies.json',
            dataType: 'json',
            cache: false,
            success: function(data) {
                this.setState({companies: data});
            }.bind(this),
            error: function(xhr, status, err) {
                console.error(this.props.url, status, err.toString());
            }.bind(this)
        });
    }

    componentDidUpdate() {
        document.addEventListener('keyup', this.filterLinkList, false);
    }
 }

And my test, Accordion.spec.js
import React from 'react';
import Accordion from '../src/App';
import { configure, mount } from 'enzyme';
import Adapter from 'enzyme-adapter-react-16';

configure({ adapter: new Adapter() });

describe('<Accordion />', () => {
    it('calls componentDidMount', () => {
        const wrapper = mount(<Accordion />);
        spy(Accordion.prototype, 'componentDidMount');
        expect(Accordion.prototype.componentDidMount.calledOnce).to.equal(true);
    });
});

It's also worth mentioning I've declared all my imports in a separate file, which is why you don't see them in Accordion.spec.js. They are in a file called helpers.js
helpers.js
import { expect } from 'chai';
import { sinon, spy } from 'sinon';
import { mount, render, shallow } from 'enzyme';

global.expect = expect;
global.sinon = sinon;
global.spy = spy;

global.mount = mount;
global.render = render;
global.shallow = shallow;

I have no idea what I'm doing wrong, I am following the documentation to the letter.
Also worth mentioning I followed this tutorial here: http://blog.ricardofilipe.com/post/react-enzyme-tdd-tutorial
Please help :C

Sorry, I don't have a specific answer to your issue on testing mount. But when I was reading over your code I noticed that you're attaching an event listener every time your component updates.
componentDidUpdate() {
    document.addEventListener('keyup', this.filterLinkList, false);
}

You should move that portion of your code into componentDidMount or componentWillMount and also clean up your event listener on componentWillUnmount

Thanks for the tip! I moved that line of coude to my componentDidMount() function and removed the event listenener on WillUnmount.

@steftastan you have to spy on the function before creating the wrapper in the first place.

Thanks for the help @ljharb, unfortunately I tried that, still didn't work. I also tried putting it outside the it(); function, still nothing.
I guess it'd be worth sharing more information on my issue. Weirdly everytime a test fails I get a npm error log. I'll try to include everything that happens on the console whenever I try to run a test.
  1) <Accordion />
       calls componentDidMount:
     TypeError: Attempted to wrap undefined property componentDidMount as function
      at wrapMethod (node_modules\sinon\lib\sinon\util\core\wrap-method.js:70:21)
      at Object.spy (node_modules\sinon\lib\sinon\spy.js:35:16)
      at Context.<anonymous> (C:/Users/etastan/test-commonsensev2.0/test/Accordion.spec.js:17:11)

npm ERR! Windows_NT 10.0.15063
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "test"
npm ERR! node v6.11.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>test: `mocha --compilers js:babel-register --require ./test/helpers.js --require ./test/dom.js --recursive`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>test script 'mocha --compilers js:babel-register --require ./test/helpers.js --require ./test/dom.js --recursive'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the commonsensev2.0 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     mocha --compilers js:babel-register --require ./test/helpers.js --require ./test/dom.js --recursive
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs commonsensev2.0
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls commonsensev2.0
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\etastan\test-commonsensev2.0\npm-debug.log

Thanks :S

@steftastan is your component wrapped in anything like Redux's connect function? Or are you exporting Accordion as the default?

I am exporting Accordion as a default, actually, I am exporting like this:
I have my main component App where I call all the components that make up my page like so:
class App extends Component {

    render() {
        return (
          <div className="wrapper wrapper__app App">
            <Header />
            <Accordion />
            <BreadCrumbs/>
            <Dashboard />
          </div>
        );
    }
}

and then I export that component:
export default App;
Not using Redux but I don't have a limitation on what I can or can't use, not sure if it's worth it?

@steftastan sinon can't spy on functions that don't exist; if there's no componentDidMount, why are you trying to spy on it?


Added 'Restore Defaults' method and affordance. #508

Thanks!

Can't really think of a case when you would ever call this method with false?   Could we hold off on that, until we actually need it?  YAGNI....

Can we improve the documentation a bit to describe what it actually does to preference service and local storage service?

Not sure we need the button, but it definitely matches the other similar buttons that we have for this kind of thing.  So great (plus, I asked for it in the ticket!)

Thanks for the feedback guys - I've updated the P/R. Only GridState local storage keys are removed, and the method always reloads the app.

I dunno - I think it's a good scope / amount of work for this function to just clear prefs/comp state and leave the existing local storage service method to zap any other data.  Forces us to think more precisely about what we're storing where in the framework and to maintain a better contract with the apps around infrastructure services like local storage.  Of course can discuss as we go forwards if this ends up being problematic...
(But FYI we're adjusting this right now to avoid importing the desktop model class into XH in case you are following along from the car 😄)


[IR] Removed ast.Modules

ModuleRef is covered by Ref
ModuleAcc is covered by TermAcc which also covers private[this] fields

:+1: for less code. LGTM!


Importing snoflake_role_grants

The documentation on how to import a snowflake_role_grants seems not to be correct. It states the format is terraform import snowflake_role_grants.example rolename. See documentation
Using that format leads to the following error:
Error: 4 to 6 fields allowed in ID
What is the correct way to import them?

For me, the import actually runs without any errors (provider version 0.37.1) , but the role grants are not imported.
For example, in Snowflake I have

so I would expect the roles AAD-APP-... and SYSADMIN to be granted the DATAENGINEER role. But in the imported state, the roles list is empty:

Or do I misunderstand something about the grants direction here?

I have the same issue as @lp-code. There are no user/role grants imported although the import command runs without errors(provider version 0.39.0). Any solutions/suggestions?

@lp-code and @nikoshet Sounds like your issue might be related to this discussion https://github.com/Snowflake-Labs/terraform-provider-snowflake/discussions/740?

@lp-code and @nikoshet Sounds like your issue might be related to this discussion #740?

I haven't completely understood the issue, but it seems likely that it is the one I hit as you point out that

https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/520 also had the unexpected consequence that there's no way to import role grants

I haven't worked further on the role grants; it would for certainly be annoying if they could not be managed from TF.

Hey 👋
Closing the issue as it's referring to the deprecated resource and we're not supporting them. Please, try to use the latest provider version with the non-deprecated resources (e.g. snowflake_grant_privileges_to_account_role). If the issue persists on the non-deprecated resource (or the feature is present in Snowflake, but not in the provider), please create a new GitHub issue. The migration guide may help during migration to the latest resources. Here's a list of the latest, non-deprecated, grant resources:
Resources
snowflake_grant_privileges_to_database_role
snowflake_grant_privileges_to_account_role
snowflake_grant_account_role
snowflake_grant_database_role
snowflake_grant_application_role (coming soon)
snowflake_grant_privileges_to_share
snowflake_grant_ownership (coming soon)
Data sources
snowflake_grants


What is max_track_since_new?

Mr. Mao,
Could you explain more what exactly the below parameter do in the parameters class? (I appreciate you if you give me an example.)
https://github.com/hongzimao/deeprm/blob/b42eff0ab843c83c2b1b8d44e65f99440fa2a543/parameters.py#L31

Is it "Maximum time steps which the scheduler tracks each job and waits for its allocation on the data center based on its policy (The maximum number of Move on action which the scheduler can choose.)"?

If I remember it correctly, this variable is just for normalization of a parameter, so that the neural network would have an easier time to process: https://github.com/hongzimao/deeprm/blob/b42eff0ab843c83c2b1b8d44e65f99440fa2a543/environment.py#L106-L107

Thanks @hongzimao , and if I may add a question to @ahmadreza9 's issue (because this line is coincidentally related  to my current work:

in many cases this line eventually affects the last input column (the "extra" column) with time since last new job , and receives a value between 0 and 1 - always. Both these claim are correct, right?
in case the resources (CPUs, memory units etc) are currently utilized in some way (some value between 1%-100%) - the extra column in the input  with time since last new job  - is always with "0"-fixed values, correct?

Thank you very much for your time an effort!!

Thanks for your questions.

last input column is affected by time_since_last_new_job as time goes by. The received value might be more than 1, if time_since_last_new_job grows larger than self.extra_info.max_tracking_time_since_last_job. I was just using a sane value for normalization from (eyeballing) experience (have to admit it's not the best way of doing normalization..)
no, a job might come and takes some time to finish, during which if no new jobs comes, the time_since_last_new_job  counter will grow. For example, let's say a job arrives at time t, it runs until t + 4, during [t, t+4] no other jobs arrive, then at t, time_since_last_new_job will be 0, but at t+2, time_since_last_new_job will be 2.

Hope these are helpful!

Thanks @hongzimao! Your help is much appreciated


🚀 Feature Request: Unpublish worker

Describe the solution
How can i unpublish my worker via cli? Need for CI/CD (unpublish after pr merged)

wrangler delete --name <name> should work

Hope this helped @polRk, feel free to join the Discord and check out the Wrangler channel for additional help or support https://discord.com/invite/CloudflareDev


fix: Restore shelf layout selection to lobby

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Re-adds the "shelf layout" selection to the lobby (see https://github.com/nrkno/tv-automation-server-core/pull/256 for details).

What is the current behavior? (You can also link to an open issue here)
Cannot select shelf layout from the lobby.

What is the new behavior (if this is a feature change)?
Re-adds the dropdown to select shelf layout. If no shelf layouts have been marked as selectable options (the default behaviour) then the text "Default" will be displayed in this column (screenshot below). There is a limitation to this implementation, as it will only work for playlists containing a single rundown for now.

Other information:

Status

[X] Code documentation for the relevant parts in the code have been added/updated by the PR author
[X] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

@jstarpl I have made the changes you requested including hiding the dropdown unless there are layouts available to select from, and supporting multiple-rundown playlists.


Handlings errors from activity functions when fan-out/fan-in pattern is used

We are implementing the fan-out/fan-in pattern in our use case. In this pattern,  If one of the activity function fails, we need to identify the specific function that encountered the error, in the orchestrator function.
Consider the following code block as an example:
List<Integer> results = ctx.allOf(parallelTasks).await();
In the event of a failure in any of the activity functions, the results variable remains unpopulated. This means that even if some activity functions have completed successfully, we are unable to distinguish them.
Is there a way to address this issue and accurately identify the successful activity functions?

Hi @akshaykumars10 , for allOf, if there any exception happens for one of the activities, we will throw a CompositeTaskFailedException and it contains a list of exceptions that will contain all exceptions that happen during the process.
You can inspect the exception list and check which task has failed.
For example:
    @FunctionName("Parallel")
    public List<String> parallelOrchestratorSad(
            @DurableOrchestrationTrigger(name = "ctx") TaskOrchestrationContext ctx,
            ExecutionContext context) {
        try {
            List<Task<String>> tasks = new ArrayList<>();
            tasks.add(ctx.callActivity("AppendSad", "Input1", String.class));
            tasks.add(ctx.callActivity("AppendHappy", "Input2", String.class));
            return ctx.allOf(tasks).await();
        } catch (CompositeTaskFailedException e) {
            for (Exception exception : e.getExceptions()) {
                if (exception instanceof TaskFailedException) {
                    TaskFailedException taskFailedException = (TaskFailedException) exception;
                    System.out.println("Task: " + taskFailedException.getTaskName() + " Failed for cause: " + taskFailedException.getErrorDetails().getErrorMessage());
                }
            }
        }
        return null;
    }

    @FunctionName("AppendHappy")
    public String appendHappy(
            @DurableActivityTrigger(name = "name") String name,
            final ExecutionContext context) {
        context.getLogger().info("AppendHappy: " + name);
        return name + "-test-happy";
    }

    @FunctionName("AppendSad")
    public String appendSad(
            @DurableActivityTrigger(name = "name") String name,
            final ExecutionContext context) {
        context.getLogger().info("Throw Test Exception: " + name);
        throw new RuntimeException("Test kaibocai exception");
    }

Let me know if this helps with your issue. Thanks.

Hi @kaIbocai
I'm facing an issue with the CompositeTaskFailedException in my code. It seems that this exception is not being thrown in my case. Here's my code:
                List<String> parallelResult;
                try {
                    parallelResult = ctx.allOf(parallelTasks).await();
                } catch (CompositeTaskFailedException e) {
                    for (Exception exception : e.getExceptions()) {
                        if (exception instanceof TaskFailedException) {
                            TaskFailedException taskFailedException = (TaskFailedException) exception;
                            System.out.println("Task: " + taskFailedException.getTaskName() + " Failed for cause: " + taskFailedException.getErrorDetails().getErrorMessage());
                        }
                    }

In my case, once we have an exception from any activity function, Orchestrator function is going into a failed state with this error:
WARNING: The orchestrator failed with an unhandled exception: java.lang.RuntimeException: Unexpected failure in the task execution
Earlier, I was catching TaskFailedException in orchestrator function like this:
List<String> parallelResult;
                try {
                    parallelResult = ctx.allOf(parallelTasks).await();
                } catch (TaskFailedException e) {
                    LOGGER.info("{}: Task failed after all the retries: {}", instanceId, e.getErrorDetails());
                    }

This was working but I was not able to distinguish the failed task.
Am I missing something?

Hi @akshaykumars10, can you provide me the error details in the TaskFailedException caught in your function app? Also, is it possible we can get a simple repro code for this issue? Thanks.

Hi @kaibocai
I attempted to compare your sample code with my orchestrator function. The only distinction I found is that I also incorporate retries when calling activity functions. When I introduce retries into your code, it encounters the same error:
 @FunctionName("Parallel")
    public List<String> parallelOrchestratorSad(
            @DurableOrchestrationTrigger(name = "ctx") TaskOrchestrationContext ctx,
            ExecutionContext context) {
        try {
            List<Task<String>> tasks = new ArrayList<>();
            RetryPolicy policy = new RetryPolicy(2, Duration.ofSeconds(15));
            TaskOptions options = new TaskOptions(policy);
            tasks.add(ctx.callActivity("AppendSad", "Input1", options, String.class));
            tasks.add(ctx.callActivity("AppendHappy", "Input2", options, String.class));
            return ctx.allOf(tasks).await();
        } catch (CompositeTaskFailedException e) {
            for (Exception exception : e.getExceptions()) {
                if (exception instanceof TaskFailedException) {
                    TaskFailedException taskFailedException = (TaskFailedException) exception;
                    System.out.println("Task: " + taskFailedException.getTaskName() + " Failed for cause: " + taskFailedException.getErrorDetails().getErrorMessage());
                }
            }
        }
        return null;
    }

    @FunctionName("AppendHappy")
    public String appendHappy(
            @DurableActivityTrigger(name = "name") String name,
            final ExecutionContext context) {
        context.getLogger().info("AppendHappy: " + name);
        return name + "-test-happy";
    }

    @FunctionName("AppendSad")
    public String appendSad(
            @DurableActivityTrigger(name = "name") String name,
            final ExecutionContext context) {
        context.getLogger().info("Throw Test Exception: " + name);
        throw new NullPointerException("Test kaibocai exception");
    }

Please inform me if you can replicate this issue or if you require additional details.

Hi @akshaykumars10 , thanks for your reply, I can repro the issue. Currently, I am working on the fix of it. Thanks.

Hi @kaibocai, do you know when this fix is scheduled to be released?

Hi @akshaykumars10, we will have a release by the end of next week. There are a few more updates we are working on for this release. Thanks.

@akshaykumars10 the latest version v1.5.0 is out here https://repo.maven.apache.org/maven2/com/microsoft/durabletask-azure-functions/, which contains the fix.

Thank you, @kaibocai. It is working as expected.
I have a quick question:
Let's say we submit 2 tasks for execution using the fan-out/fan-in pattern. If one of these tasks fails with an exception, we can retrieve its details by catching a CompositeTaskFailedException. But what about the task that was successful? How can I access its response in the orchestrator function's code?"

Let's say we submit 2 tasks for execution using the fan-out/fan-in pattern. If one of these tasks fails with an exception, we can retrieve its details by catching a CompositeTaskFailedException. But what about the task that was successful? How can I access its response in the orchestrator function's code?"

Hi @akshaykumars10 , based on the current implementation I don't think we have a way to access the success task, when the other task is failing. Can you please open a new issue and describe this situation? so we can plan to support it in future. Thanks.

Hi @kaibocai,
As suggested, I have created a new issue: https://github.com/microsoft/durabletask-java/issues/181


ANSI/VT transparent and black background mismatch

Tested on Windows Terminal 0.7.3382.0 from Store on Windows 10 1909 build 18363.476.
CUI App is my ActiveScript Shell, but only used because it makes it easy to send full strings to the Console API and JavaScript is easy for most to read, the problem seems to be with the rendering, or with the way conhost stores and retrieves cells colors.
ANSI VT has codes to set foreground and background colors, and codes to use default foreground and background colors (39, 49).
Windows Terminal has a nice transparency effect when the default background is used that makes it use Acrylic translucency.
The problem is that the terminal seems to lose track of what has been output as black (30 or 40) when it is the cell's background color and what has been output as default background color (49).
Writing something with a black background, using color 40 (or 30 and reversed using 7), the expectation is to have that color show as black, transparency should be achieved only by color 49.
This is important when doing ANSI-art and for consistency.
However, it seems the current implementation doesn't keep track of default colors 39 and 49, and instead assumes all cells with color 40 as their background to be the default background color or transparent, basically converting it to 49.
It also converts the other way around, using transparent (49) reversed should show the text as transparent, but instead converts it to black (30).

Let me know if my explanations aren't clear enough or if you really need a Win32 API repro.

This sounds like #2661.

This sounds like #2661.

Indeed, if colors are converted too early.
Important to note for this bug is that default background and default foreground should have their own indexes, and not get converted to their current color indexes either. This means storing the 16 base colors as indexes in the 256 colors palette and keeping it as index, converting them to RGB only for rendering still wouldn't be enough. we need special index values for DEFAULT_BACKGROUND and DEFAULT_FOREGROUND and map colors reset codes 39 and 49 to those.
Acrylic transparency should only happen when DEFAULT_BACKGROUND color is used, not when another color happens to have the same RGB value as the one selected as the background color, or the index selected as the background in the old console.
Also, when reverse is used (7), we can have DEFAULT_FOREGROUND used as a background color and DEFAULT_BACKGROUND used as a foreground color, those should be handled properly, and transparency should be supported on text foreground in that case.

Important to note for this bug is that default background and default foreground should have their own indexes, and not get converted to their current color indexes either.

The way it works is that default colors are indicated with a distinct type. So a color can either be default, an index, or an rgb value. You can see the ColorType enum here:
https://github.com/microsoft/terminal/blob/429af0e6fa80412f1e9185845d856e3497a6cf78/src/buffer/out/TextColor.h#L42-L47
The narrowing problem, as I understand it, is that these color types are all first converted to a COLORREF, and then that COLORREF is sometimes "optimised" to an index value. But that can obviously result in the conpty connection receiving an index color when the original attribute was not.

@j4james
Thanks for the details, that structure should indeed take care of the original color in all cases.
I'm concerned about the conversion to a COLORREF and optimization back to an index when the COLORRED matches a color of the palette though.
Any of the 256 colors of the palette can be redefined at any time, using the SetConsoleScreenBufferInfoEx API function for the base 16 colors, or "ESC]4;[index];rgb:[r]/[g]/[b]BEL" VT sequence for any of the 256 colors.
Because of this, any RGB color that did match a palette index earlier might now reference a color that isn't the same anymore.
This means we need to keep the original intent of the VT sequences, an index should never be converted to an RGB and an RGB should never be simplified into an index. Converting to COLORREF should be done just before rendering, as the palette might have been changed after the color codes have been output, and palette colors should always render using the current palette, not the palette from when they were received.

This means we need to keep the original intent of the VT sequences, an index should never be converted to an RGB and an RGB should never be simplified into an index.

Yes! That's exactly what issue #2661 is about!

This specific case is actually tracked by /dupe #293. #2661 will help make sure we don’t narrow arbitrary colors into indexed ones, but 293 tracks the compatibility behavior of crushing the “default win32 console background” index (0) to “default VT background” (49). That’ll apply even in reverse video mode.


vlc: 3.0.7 - security!

Motivation for this change
http://www.jbkempf.com/blog/post/2019/VLC-3.0.7-and-security
NEWS here: https://www.videolan.org/developers/vlc-branch/NEWS
(will likely always point to latest release, FWIW, scroll as needed)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

The only "high security" fix doesn't help us really; I had to patch faad2 instead: 57aa3ec33 (and we had been missing older patches in there, too).


Consumer no listening ConditionRouter application configuration

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 2.7.9
Operating System version: mac OS
Java version: 1.8

Steps to reproduce this issue

admin create application scope condition router

consumer no listening application scope condition router

Pls. provide [GitHub address] to reproduce this issue.
Expected Result
Consumer listening application scope condition router, conditional routing takes effect.
Actual Result
What actually happens?
Consumerno  listening application scope condition router.
Just put your stack trace here!

Hello, big brother, I verified this problem
This is indeed a problem. When the consumer side goes through the AppRouter flow, the consumer side listens to a structure similar to this: /dubbo/config/dubbo/{consumerAppName}.condition-router, from your screenshot, The application name value you specify is the provider's application name (dubbo-provider), and the correct operation is that what we fill in the console should be the consumer's application name.
But I tried to fill in the consumer's application name, it will prompt there is no service for application:demo-consumer, this is a bug, I will try to modify it

Hello, big brother, I verified this problem
This is indeed a problem. When the consumer side goes through the AppRouter flow, the consumer side listens to a structure similar to this: /dubbo/config/dubbo/{consumerAppName}.condition-router, from your screenshot, The application name value you specify is the provider's application name (dubbo-provider), and the correct operation is that what we fill in the console should be the consumer's application name.
But I tried to fill in the consumer's application name, it will prompt there is no service for application:demo-consumer, this is a bug, I will try to modify it

https://github.com/apache/dubbo-admin/issues/754

Close by https://github.com/apache/dubbo-admin/pull/764.


Update StripeCheckout.js

MarginTop
Description:

@TamerJarrar Thanks for the PR! Can you please describe what this achieves?


Question - When a session topic has two accounts,  how do you specify which to use?

Lower priority question, but I am trying to understand some design corner cases.
WalletConnect V2 allows you to negotiate a pairing session and a single session topic can include multiple wallets on the same chainId.
sessionTopic 8881d5087cd00d02a1ea93a37997f6dca15b7e3ba3bb0a4b5d41738437baf319 - accounts: [Ethereum 0xbae9...bbee, Ethereum 0x9d15...00d9]

If I call the sign client to send a transaction (eth_sendTransaction), how do I specify which of the two accounts I want to use (e.g. which account pays gas)?  The calling parameter is only asking for a session topic and chain Id.
/lib/apis/sign_api/sign_client.dart
  Future request({
    required String topic,
    required String chainId,
    required SessionRequestParams request,  // has String method and dynamic params

Is the wallet responsible for prompting the user to select?  Or determine from the method parameters which wallet applies (peeking at the from:?)   Just trying to understand the WalletConnect design and user experience.

Generally when you send in a transaction it includes the account that will execute that transaction, no?
SImplest example: Sending tokens. From, To. From will use one account, and the wallet will recognize that and sign with it.
If the account isn't in the transaction, then I honestly have no idea. That was the assumption I have always worked under.
Two options:

Transactions will get more explicit (Gas payer and From will be separate), or
Wallet will ask the user which account to pay gas from.

I suspect we will eventually use both of these.

Thanks for the info.  I'll close this issue as it's more of a higher level WalletConnect protocol and compatibility discussion.
I haven't seen any documentation guiding wallets that they should cover this corner case.  I just wanted to make sure I was a well behaved DAPP ;-)


CLI error: abort(RangeError: WebAssembly.instantiate(): Out of memory: wasm memory)

Describe the bug
For whatever command and image I run through cli, I always get
- (node:41120) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 25 unpipe listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit
(Use `node --trace-warnings ...` to show where the warning was created)
(node:41120) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 25 error listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit
(node:41120) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 25 close listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit
(node:41120) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 25 finish listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit
0/1 \ ▐▨▨▨▨▨╌╌╌╌╌▌ Encoding (24 threads)
 text-split.png: 462.15KBfailed to asynchronously prepare wasm: RangeError: WebAssembly.instantiate(): Out of memory: wasm memory
node:internal/process/promises:227
          triggerUncaughtException(err, true /* fromPromise */);
          ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "abort(RangeError: WebAssembly.instantiate(): Out of memory: wasm memory). Build with -s ASSERTIONS=1 for more info.".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Version:

OS w/ version: Windows 10 and WSL 1 Ubuntu 18.04
Node version: 15.6.0
npm version: 7.4.0

+1 on Ubuntu 20.04

I also encounter this.  A little more context; I was using https://github.com/webpack-contrib/image-minimizer-webpack-plugin with these options:
const ImageMinimizerPlugin = require("image-minimizer-webpack-plugin");

module.exports = {
  module: {
    rules: [
      // You need this, if you are using `import file from "file.ext"`, for `new URL(...)` syntax you don't need it
      {
        test: /\.(jpe?g|png)$/i,
        type: "asset",
      },
    ],
  },
  optimization: {
    minimizer: [
      new ImageMinimizerPlugin({
        minimizer: {
          implementation: ImageMinimizerPlugin.squooshMinify,
          options: {
            encodeOptions: {
              mozjpeg: {
                // That setting might be close to lossless, but it’s not guaranteed
                // https://github.com/GoogleChromeLabs/squoosh/issues/85
                quality: 100,
              },
              webp: {
                lossless: 1,
              },
              avif: {
                // https://github.com/GoogleChromeLabs/squoosh/blob/dev/codecs/avif/enc/README.md
                cqLevel: 0,
              },
            },
          },
        },
      }),
    ],
  },
};

The error encountered was:
failed to asynchronously prepare wasm: RangeError: WebAssembly.instantiate(): Out of memory: wasm memory
failed to asynchronously prepare wasm: RangeError: WebAssembly.instantiate(): Out of memory: wasm memory

node:internal/event_target:777
  process.nextTick(() => { throw err; });
                           ^
Error [RuntimeError]: abort(RangeError: WebAssembly.instantiate(): Out of memory: wasm memory). Build with -s ASSERTIONS=1 for more info.
    at abort (/home/john/code/github/blog.johnnyreilly.com/blog-website/node_modules/@squoosh/lib/build/index.js:28:9428)
    at /home/john/code/github/blog.johnnyreilly.com/blog-website/node_modules/@squoosh/lib/build/index.js:28:11293
Emitted 'error' event on Worker instance at:

I had this same problem, then I installed the x86 version of node and this went away.  x64 seems to be broken?

Same error for me. Has anyone found a solution? I don't get this issue locally but I'm getting it on Circle CI

I got a same problem.
Environment:
nodejs-16.14.0-2.fc35.x86_64
Fedora 35 on WSL2 on Windows 10 build 19044.1645
I want to convert AVIF to PNG.
npx @squoosh/cli --oxipng '{"level":3,"interlace":false}' 00001.avif
Output;
⠋ (node:4275) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 33 unpipe listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit (Usenode --trace-warnings ...` to show where the warning was created)
(node:4275) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 33 error listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit
(node:4275) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 33 close listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit
(node:4275) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 33 finish listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit
0/1 ⠋ ▐╌╌╌╌╌╌╌╌╌╌▌ Decoding...
node:internal/event_target:916
process.nextTick(() => { throw err; });
^
RangeError [Error]: WebAssembly.instantiate(): Out of memory: wasm memory
Emitted 'error' event on Worker instance at:
at Worker.[kOnErrorMessage] (node:internal/worker:289:10)
at Worker.[kOnMessage] (node:internal/worker:300:37)
at MessagePort. (node:internal/worker:201:57)
at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:647:20)
at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)
`

+1
Win10 21H1
node v14.18.0

1 with the same problem on MacOs 12.3.1, node 16.15.0.
Hope your team can fix that <3

Similar problem here, I tested on 3 devices, but only get this problem on one of them.
OK devices are Ubuntu 20.04.4 LTS and Ubuntu 22.04 LTS, the device with the problem is Ubuntu 20.04.4 LTS. All of them have the same node and npm versions node v16.15.1 and npm 8.13.2.
The device with the problem is a 32 core/64 threads and 128GB of memory, I doubt that memory is an issue here, so I am wondering if that is just too many cores/threads and the app does not support it.

Unfortunately, due to a few people leaving the team, and staffing issues resulting from the current economic climate (ugh), the CLI and libsquoosh packages are no longer actively maintained. I know that sucks, but there simply isn't the time & people to work on this. If anyone from the community wants to fork it, you have my blessing. The squoosh.app web app will continue to be supported and improved.

@jakearchibald I'd suggest adding a note to the README letting people know this isn't maintained anymore.

The readmes of both packages in npm have already been updated with a notice.
The main part of the project (the web app) is still maintained.


Dockerfile: Set recursive ACLS

https://wiki.ubuntuusers.de/ACL/
acl has to be installed first (add to apt-get at the beginning of Dockerfile)
Then use setfacl to set full permission (read+write+execute) on all the folders (/home/csp/data, /home/csp/output, etc.)
https://wiki.ubuntuusers.de/ACL/#Setzen-und-Loeschen-von-ACLs

The -d flag and -R flag are important: https://serverfault.com/a/445096

This might not work? https://stackoverflow.com/questions/59043049/setfacl-in-dockerfile-has-no-effect

Related: https://github.com/moby/moby/issues/40553


Prepare for release 0.1

I have updated the version in build.gradle file. Do we need to do anything else for this release @blootsvoets  and @nivemaham ?

We were at sometime working on a PR to improve the test. But we have build failures on that branch yet.
If we would proceed for a release with this revision, no i cannot think of additional changes.


Hue component not loading groups any more by default

Home Assistant release (hass --version):
0.44.1
Python release (python3 --version):
Python 3.4.2
Component/platform:
light/hue
Description of problem:
Philips Hue light groups are not available as entities because the hue component does not load them from Hue bridge.
Expected:
They are loaded and available as light entities.
Problem-relevant configuration.yaml entries and steps to reproduce:
I'm using stock configuration.yaml without any changes

Install HA 0.44.1
Let HA discover your bridge, authorize HA to access it
Hue component discovers all lights
It does not load light groups (see reason below)

Additional info:
I debugged components/light/hue.py and found the issue here:
Around line 114:
def setup_platform(hass, config, add_devices, discovery_info=None):
    """Set up the Hue lights."""
    # Default needed in case of discovery
    filename = config.get(CONF_FILENAME, PHUE_CONFIG_FILE)
    allow_unreachable = config.get(CONF_ALLOW_UNREACHABLE,
                                   DEFAULT_ALLOW_UNREACHABLE)
    allow_in_emulated_hue = config.get(CONF_ALLOW_IN_EMULATED_HUE,
                                       DEFAULT_ALLOW_IN_EMULATED_HUE)
    allow_hue_groups = config.get(CONF_ALLOW_HUE_GROUPS)

As I'm using the default configuration.yaml, config is {}, hence allow_hue_groups yields None instead of True although it's defined as the default value here:
Around line 75:
PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
    vol.Optional(CONF_HOST): cv.string,
    vol.Optional(CONF_ALLOW_UNREACHABLE): cv.boolean,
    vol.Optional(CONF_FILENAME): cv.string,
    vol.Optional(CONF_ALLOW_IN_EMULATED_HUE): cv.boolean,
    vol.Optional(CONF_ALLOW_HUE_GROUPS,
                 default=DEFAULT_ALLOW_HUE_GROUPS): cv.boolean,
})

As far as I can see the DEFAULT_ALLOW_HUE_GROUPS  is not applied as a default value. I'm not sure if and who should apply the default value. But HA 0.42.0 did load the groups with a default configuration.yaml.
Alternatively, the default value could be handed in line 114:
allow_hue_groups = config.get(CONF_ALLOW_HUE_GROUPS, DEFAULT_ALLOW_HUE_GROUPS)
but I guess this is what PLATFORM_SCHEMA already should enforce.
If somebody can confirm that this is a bug, I'm happy to provide a PR with fix. Indications on how to fix it are welcome.

I'm experiencing this too.  I had to turn off discovery to get it to work for the moment.  Personally, I think it's a bug, but I'm not that experienced in home-assistant (yet).


Insert  directly, without an intermediate

Instead of inserting a <script> at https://github.com/chialab/rna/blob/6f5fefd50f39a82d7bd01106b54e4acb07cb8806/packages/esbuild-plugin-html/lib/collectScripts.js#L102 are you able to insert a <link> directly? This would look more natural, and it would add support for users who disable Javascript.

It is certainly possible. The reason why it doesn't work that way at the moment is that the plugin does not alter how the CSS file was included in the build:

if it is imported via <link> in the HTML file, the plugin maintains the reference as <link>;
If it is imported via script, the plugin replicates the import via script.

If I remember correctly, there have been concerns about this behavior in the past, which is definitely subject to review.
I would be interested in hearing your opinion on the reasoning above.

Concrete example of what I would like to do:
<link
  rel="stylesheet"
  media="(prefers-color-scheme:light)"
<EMAIL_ADDRESS>/>
<link
  rel="stylesheet"
  media="(prefers-color-scheme:dark)"
<EMAIL_ADDRESS>  onload="document.documentElement.classList.add('sl-theme-dark');"
/>
<script type="module"<EMAIL_ADDRESS>

It turns out that this isn't just a nice-to-have feature. There is a concrete difference between adding a <link> programmatically and having it as part of the HTML in the first place: https://github.com/shoelace-style/shoelace/discussions/1910#discussioncomment-8685333
Bottom line: if I replace the JS code with an inline <link> the Flash of Unstyled Content goes away. It looks like the browser runs JS code after rendering the screen. By this point, it's too late to change the background color of the page without seeing a flash...

So to recap... We have the concept of injecting <link> at bundle-time or runtime. To avoid the FOUC we need to inject <link> at bundle-time.
If you can't think of any reason why anyone would want to inject styles at runtime, then I would recommend always injecting links at bundle-time.
If there is a valid use-case for runtime injection, then we should probably add an option that lets users decide one way or another.

I can confirm that importing from inside CSS files fixes my problem. I no longer get a flash of unstyled content because the <link> is being added at bundle-time. I love it! :)
I still think that users would be better off using bundle-time <link> in all cases, but that's just me.
That said, I don't think you even need an option any more. If users want bundle-time <link> they can just use CSS imports as you recommended. You could just document this and move on. Thanks a lot for your help! Feel free to close this issue when you're done.

Another thing I just discovered is that JS runs before the page is rendered, if and only if, the JS file does not contain any imports.
So I created a separate JS file without any imports that detects the user's dark mode preference and adds the necessary CSS class to the <html> tag. No more flash of white :)

This feature would be great as the current behaviour (inline script) fails if you have a Content Security Policy.


Site is not available

http://stylusgrid.com/ not working:(

Hi, it works for me now, could you check again?

Hmm, interesting. From Russia not working ¯\_(ツ)_/¯
Through the VPN everything is ok

oh, this is weird ;) I have no idea why.
It is hosted on shared hosting so maybe the ip range is banned in Russia.

Maybe. Will use VPN :)
Thanks!


Adding Header

I'm curious if it's possible to add a header above the tab and make it so the pager remains sticky at the top once scrolled up.

@cerupcat You can add any XLPagerTabStripViewController as a childViewController using storyboards.
In fact the example project storyboard does that.
regards

@mtnbarreto
I think @cerupcat wants the feature like this [https://github.com/noties/Scrollable], is it possible?


Docs: include ALL notes

Hello,
Firstly thanks for this plugin, it's exactly what i've been looking for!
I'm wondering how you include all git messages from all conventional commits when you generate a release?
I can't work it out from the README file, under "Only new notes" you have an identical block of code as an example as the one above it:
{
  "targets": {
    "version": {
      "executor": "@jscutlery/semver:version",
      "options": {
        "postTargets": ["my-project:github"]
      }
    },
    "github": {
      "executor": "@jscutlery/semver:github",
      "options": {
        "tag": "${tag}",
        "generateNotes": true
      }
    }
  }
}

Removing generateNotes does nothing. Git releases show only the latest commit message since the last release. Ideally I'd want to see every change that has been added since the last release but can't see that as an option. I can't see how the above code is either Only new notes or All notes 🤔

Hi, I think it's related to #397. Does it?

The generateNotes uses the GitHub CLI which only goes off of PRs.
The ${notes} is new notes added to the CHANGELOG.md in the version step.
I have been thinking about this recently and I think we can improve the way the ${notes} work, I might take another pass at it sometime soon @edbzn

@wSedlacek Nice! Excited to see what you have in mind.

I'm going to close this, feel free to reopen if it is not resolved.


Id is not present when it is used with include filter

There is only _source part of json if related model get fetched with include filter.

Nice catch! Can you submit a failing test for this?
That way we can put that together with the patch when we release to prove that it is fixed!


Generate a system_id for the runner so gitlab can differentiate between instances

I think the stateless part for the random system IDs may be problematic.
The point of the system ID is to uniquely identify the "machine" on which the runner runs. When using containers, the "machine" is the container, so we need to generate a random system ID as /etc/machine-id is usually not available (and if it was copied from the host, multiple runners would have the same system ID). The official gitlab-runner creates the random system ID on first run, and stores it to persistent storage. We may not want to do so in this crate, but making it possible for lava-gitlab-runner to do the same is important I think.

I think the stateless part for the random system IDs may be problematic.
The point of the system ID is to uniquely identify the "machine" on which the runner runs. When using containers, the "machine" is the container, so we need to generate a random system ID as /etc/machine-id is usually not available (and if it was copied from the host, multiple runners would have the same system ID). The official gitlab-runner creates the random system ID on first run, and stores it to persistent storage. We may not want to do so in this crate, but making it possible for lava-gitlab-runner to do the same is important I think.

Yeah I've been working on a separate/follow-up patchset to move the runner initialisation to a builder pattern so users can add e.g. a custom system_id themselves more easily as well as filling in some more metadata to pass to gitlab (e.g. runner "architecture" , version, etc).. That should solve your concern here.
For reference we normally run our gitlab runners in k8s for which i  think it makes sense for each instance to be unique (whether that's due to scaling or restart). As gitlab GC's stale instances after a while purely random on startup should be good enough there. Anything more fancy would need operator involvement (there is no persitant storage in the pods for these typically), which folds back to this patchset being a good default but potentially allowing the operators to override would be beneficial


Definition of Quadratic Voting

I am a bit confused about the role of Quadratic Voting (QV) in the democracy earth platform
The way DEF seems to usually speak about QV involves the number of votes you can delegate to another person (it has to a number that comes from 2^x, so 1, 2, 4, 8, 16, 32, 64, 128 etc)
In every other instance that I have read about QV, it has to do with balancing the "tyranny by majority" effects of 1-person-1-vote and creating a mechanism by which passionate minority groups can use more than one of their votes on any one particular issue, but at progressively greater cost with each vote (for example, 1 counted vote would cost 1 vote, 2 counted votes would cost 4 votes, 3 counted votes would cost 9 votes and so on). This is the meaning employed by Vitalik Buterin and Glen Weyl in his book Radical Markets
This seems especially important if votes are able to be purchased on the open market, because it allows a dedicated minority to make themselves heard (a group of 1000 dedicated people could fairly easily amplify their voting influence by a factor of 10 if they were willing to sacrifice votes on other issues) , but does not allow tyranny by majority (a single rich person buying 1,000,000 votes on the open market could be counterbalanced by 1000 individual people casting only one vote each on a particular issue)
If DEF wants to stick with their version, I think it might be wise to change the name to something else so as not to cause confusion

Yes .. maybe we need to consider a new name other than "Quadratic Voting" .. especially because our method is more robust.  In the 'standard' QV model (where votes are squared), 20 votes would cost only 400.  In the DEF model (where each additional vote costs 2x the previous), 20 votes would cost 524,288 ... 1,311x more expensive.
Maybe "Exponential Voting"?

that makes sense to me! although I don't think it should "cost" someone more if they wish to delegate all of their votes to someone else (because they trust their judgement etc), I think it should only "cost" more (in terms of number of votes counted for the number of votes spent) at the point of actual use / if all of a person's delegated votes are used on a single issue.
This distinction might introduce some software/tracking complications though, because the receiver of delegated votes would then have to decide whose votes (out of all of the people who have delegated votes to them) rather than just the total quantity they want to spend on an issue, since spending different people's votes in different quantities might be more/less effective
In other words: if a receiver of delegations was representing 100 people on an issue, it wouldn't make sense to treat that delegator as a single voter using a large quantity of their own votes, they should be "counted" (in terms of cost) as though it was those 100 people all voting on the issue themselves


Support for bumping version ranges

It's currently stated in the readme that

Molt does NOT bump version ranges like 1, 1.x, ~1.2.3 and ^1.2.3 in
npm: and jsr: specifiers, but only updates a lockfile.

I would like to understand the reasoning behind that. For versions like ^1.0.0 with latest version 1.2.3 it might make sense, but in cases where the version range doesn't satisfy the latest available version molt won't bump it, for example most of the deno_std packages - when they release a minor, some range like ^0.200.0 won't satisfy it and lock file won't be updated either.

Thanks! I totally agree with you and this will be supported in the next release (0.19.0).
The implementation is already done here but needs finalization to be published.

Ah sorry, I should have looked more 😅 Thanks for your work!


1.4.12 final

1.4.12 final

Coverage remained the same at 92.982% when pulling 82dab0b43517d2d152c12f69ae1dacdac827ddff on development into 37f1c716c65c06b52e2e30bf449e4d430a6c3e10 on master.


refactor: mod.rs over "name".rs for consistency

See https://github.com/rust-lang/cargo/pull/11243#discussion_r996981107

aside: Seems like it'd be useful to enforce a style with clippy, like https://rust-lang.github.io/rust-clippy/master/index.html#self_named_module_files
What if we only don't adopt all of clippy but specific lints that we find help?

@bors r+

:pushpin: Commit aa6903183575227320bc2bb300c9da697f9d64bd has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit aa6903183575227320bc2bb300c9da697f9d64bd with merge 36e1af6fbed70ee8b99fed14cd9d86831f154865...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 36e1af6fbed70ee8b99fed14cd9d86831f154865 to master...


[Issue-2658] Update chainlist

Related issue(s)

#2658

Is your feature request related to a problem(s)? Please describe.

Update chain-list

Describe the solution you'd like

Update chain-list

Describe alternatives you've considered

No

Additional context

No

🚀 Deployed on https://pr-2679--sw-web-runner.netlify.app


Default value is picked for modifications

Default value is picked for all modifications starting on November 10th. Before that date everything was working correctly. I am not sure how to debug the library to be able to provide more information. However, that is happening to all of our users where before it wasn't happening.

Hey @damiafuentes thanks for bringing that issue to us.
Could you tell us for which account you encountered this issue (or environment ID) ?
We need that information to check the use cases setup in the platform.

I've added logs and found this error:
Flagship.getModification("is_social_logins_enabled", false)

Flagship.getValue "is_social_logins_enabled"  types are different. Default value is returned.

When Flagship is retrieving the modifications the data is downloaded correctly. For that specific key the logs print:
is_social_logins_enabled=Modification(key=is_social_logins_enabled,
campaignId=c5gbbb67b6e2l79md7b0,
variationGroupId=c66l1k4h8hb02dnrm25g,
variationId=c66l1k4h8hb02dnrm260,
variationReference=false,
value={
  "type": "boolean",
  "value": true
})

Looks like the API response has changed from returning a boolean to return a JSONObject.


[Security] - Added secure score CLIs

Description
Added Security Center's Secure Score related CLIs
Testing Guide

History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR title and description has followed the guideline in Submitting Pull Requests.

[X] I adhere to the Command Guidelines.

[X] I adhere to the Error Handling Guidelines.

Security

Could you resolve the CI errors first?

Hi @haroldrandom ,
Can you review?
I couldn't find the failed tests in Security module.

/azp run

Could you resolve the CI errors first?

All CI errors fixed.
Waiting for final approval


Duplicate ManagedIdentitySourceName

Core Library
MSAL Node (@azure/msal-node)
Core Library Version
2.9.2
Wrapper Library
Not Applicable
Wrapper Library Version
None
Public or Confidential Client?
Confidential
Description
ManagedIdentitySourceNames defines both Imds and DefaultToImds but only one of these is actually used in getManagedIdentitySource
We should remove one of the two, probably Imds, from the public API
Alternatively, you could update the getManagedIdentitySources type to:
public getManagedIdentitySource(): Exclude<ManagedIdentitySourceNames, "Imds">

So developers writing code against this know which value to check against when they want to do something special for IMDS flows (like probing the IMDS endpoint) instead of always remembering to check both values (or looking into the implementation to see that only one is actually used)
playground example
Error Message
No response
MSAL Logs
No response
Network Trace (Preferrably Fiddler)

[ ] Sent
[ ] Pending

MSAL Configuration
{}

Relevant Code Snippets
N/A

Reproduction Steps
N/A
Expected Behavior
N/A
Identity Provider
Entra ID (formerly Azure AD) / MSA
Browsers Affected (Select all that apply)
None (Server)
Regression
No response
Source
Internal (Microsoft)

Not fixing, per offline discussion


Yarn executor ends at executor.CoarseGrainedExecutorBackend in CPU MODE

I am trying to run given examples in distributed spark mode both with CPU and GPU but both jobs fail.
One with CPU mode gives following error
16/06/10 14:42:29 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
16/06/10 14:42:29 INFO spark.SecurityManager: Changing view acls to: ubuntu
16/06/10 14:42:29 INFO spark.SecurityManager: Changing modify acls to: ubuntu
16/06/10 14:42:29 INFO spark.SecurityManager: SecurityManager: authentication disabled; ui acls disabled; users with view permissions: Set(ubuntu); users with modify permissions: Set(ubuntu)
16/06/10 14:42:29 ERROR executor.CoarseGrainedExecutorBackend: RECEIVED SIGNAL 15: SIGTERM

The error is most likely due to executor out of memory. You may want to increase your executor-memory and/or memoryOverhead.


Generated HTML graph loads unauthenticated scripts over plain HTTP

As a result, a network attacker can modify the scripts in order to:

obtain full path on local computer
load details about the projects

How to fix it:
a. Use subresource integrity (limited browser compatibility)
b. Use HTTPS
c. Use both

Thanks, good point, @v6ak. Couldn't we just include all of the scripts and serve it from the file system?

Yes, this is also an option. I wanted to be conservative :)


feat: add playwright nodes

I can not connect to openai or other AI platform because of using Chinese internet.
So It's hard for me to run the full pipline.
But maybe we can check by serve's log which provide in second picture.
Hope this can help~

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.yuefang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

sorry @disflyer for another merge conflict!

sorry @disflyer for another merge conflict!

Fixed

thnaks @disflyer !


Dynamic Volume Provisioning

The documentation about storage class  mentions the following:
If you set the [storageclass.kubernetes.io/is-default-class](https://kubernetes.io/docs/reference/labels-annotations-taints/#ingressclass-kubernetes-io-is-default-class) annotation to true on more than one StorageClass in your cluster, and you then create a PersistentVolumeClaim with no storageClassName set, Kubernetes uses the most recently created default StorageClass
The documentation about dynamic volume provisioning mentions different behavior:
Note that there can be at most one default storage class on a cluster, or a PersistentVolumeClaim without storageClassName explicitly specified cannot be created.

/language en

/sig storage

Duplicate of #42176

dynamic volume provisioning page to be updated with following content.

If a cluster has a one default StorageClass and it is not necessary to specify the storageClassName while create a PersistentVolumeClaim.
If two or more of them are marked as default, a PersistentVolumeClaim without storageClassName explicitly specified cannot be created.

/kind bug

/assign

I will raise a PR if triage accepted

/retitle Conflicting information about default StorageClasses
The information in https://kubernetes.io/docs/concepts/storage/storage-classes/#default-storageclass looks accurate.

/triage accepted
/priority backlog

@sftim
please review the PR

I think this issue is updated by the PR #44942 and hence can be closed

/close


Debugger API documentation

Is there any centralized place where I can find documentation for the JSON-based debug API?  Some of the JSON is documented in ChakraDebug.h but not all--for example there's no documentation for the JSON object that gets passed to the event callback.

No at the moment, but I will get the debugging APIs in the API reference docs. For the time being, you can see the ChakraDebug.h should have the info you need, including the returned JSON (see remarks).

The only thing I couldn't find in ChakraDebug.h was the JSON passed to the event callback (eventData parameter).  Based on experimentation I figured out it has a scriptId along with line and column information, but beyond that I have no clue.  I haven't tried serializing it yet to see what it contains.

@fatcerberus below is the json which is returned for debugEvents. The data may vary based on scenario but the structure is same.
{
  "debugEvent": "JsDiagDebugEventSourceCompile",
  "eventData": {
    "scriptType": "eval code",
    "lineCount": 1,
    "sourceLength": 10,
    "scriptId": 4,
    "parentScriptId": 2
  }
}, {
  "debugEvent": "JsDiagDebugEventBreakpoint",
  "eventData": {
    "breakpointId": 2,
    "scriptId": 2,
    "line": 2,
    "column": 2,
    "sourceLength": 9,
    "sourceText": "var y = 2"
  }
}, {
  "debugEvent": "JsDiagDebugEventStepComplete",
  "eventData": {
    "scriptId": 2,
    "line": 3,
    "column": 2,
    "sourceLength": 9,
    "sourceText": "var z = 1"
  }
}, {
  "debugEvent": "JsDiagDebugEventDebuggerStatement",
  "eventData": {
    "scriptId": 2,
    "line": 4,
    "column": 2,
    "sourceLength": 8,
    "sourceText": "debugger"
  }
}

Thanks, and for JsDiagDebugEventRuntimeException?

Assigning myself to this so that I don' forget updating the docs :).

{
  "debugEvent": "JsDiagDebugEventRuntimeException",
  "eventData": {
    "scriptId": 2,
    "line": 3,
    "column": 4,
    "sourceLength": 5,
    "sourceText": "bar()",
    "uncaught": false,
    "exception": {
      "name": "{exception}",
      "type": "object",
      "className": "Error",
      "display": "'bar' is not defined",
      "propertyAttributes": 3,
      "handle": 1
    }
  }
}

@agarwal-sandeep Thanks.  Interestingly, for a runtime exception event, exception.handle always seems to be 1 -- which apparently doesn't refer to the actual exception value that was thrown.  I tried resolving the handle to an object and accessing .stack from it and it didn't work.  Is that a bug?

@fatcerberus handle is a global counter which starts from 1, if no JsDiag* APIs where called before JsDiagDebugEventRuntimeException got handled the handle referred in exception object will get handle 1. Based on code here it shouldn't be a bug but I will look into it more.
In JsDiag* APIs actual JavaScript object or properties are not exposed to host. The actual exception object is saved as internal object in the exception object ("name" : "exception") we generate to pass in eventData. You should be able to call JsDiagGetProperties to get all properties of the actual exception object (obj)

I used JsDiagGetObjectFromHandle() to get the object from the handle, and passing the handle from the event data gives me back at least "name": "{exception}" -- so it appears that the handle refers to the JSON exception object from the event data itself rather than the real exception that was thrown.

@fatcerberus Yes JsDiagGetObjectFromHandle will get you the exception object passed to eventData but JsDiagGetProperties knows how to get the children's from the  object as the display use internal exception object (obj) to get the properties

Thanks, that's a bit roundabout but I know what to now.  I guess the debugger is implemented that way to avoid unwanted side effects from getters, proxies, etc.  Males sense. :)

@liminzhu is this resolved?

not yet


certain depencies will stop working nov 30th

GitHub has announced that v3 Actions artifacts will be deprecated on November 30th. Given this upcoming change, we should consider migrating to GitHub's native Cache Action, which is specifically designed for persisting build outputs between workflow runs.

bump! (considering the date is nearing - and I dont have the skills for this)


GUI issue: shifting between Custom Classifier and all species

When we change species list options from Custom Classifier to all species or vis versa, analysis results shows all species of the selected option with confidence = 1.
It only starts working normal once we restart the GUI.
This seems to be a bug.
Thanks,
Nishant.

Does this issue still occur in the current version? I currently can't reproduce it.


cluster: New() made async

Previously, we have New() be sync because we need to handle error on
creating cluster. We don’t need this assumption anymore since now we
report failure status.
This also fix test interference:
https://github.com/coreos/etcd-operator/issues/588

lgtm

Let's keep a branch to run this 24*7 to ensure this fixes things and does not break others before merging.

Pushed to "flaketest" branch

Let me close this.
I make more and more changes. Also there is very high rate of flakes with this.
Might need to make this whole thing stable.


Add license

@razr, I'm not a big License expert, so, creative commons license sounds good to me. @carlossvg?

@razr @LanderU I agree, I would simply use the same ones as the ros 2 docs


[XLA] Ambiguous/dynamic shape during xla.compile when using tf.custom_gradient and tf.while_loop

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): public Colab runtime
TensorFlow version (use command below): 1.12
Python version: 3

Describe the current behavior
Using xla.compile on a gradient coming from a while loop within tf.custom_gradient seems to generate an inverse permutation op with undefined shape. While all intermediate tensors appear to have fully defined shapes, xla.compile will still raise an exception:
InvalidArgumentError: Input 0 to InvertPermutation operator must be a compile-time constant.

XLA compilation requires that operator arguments that represent shapes or dimensions be evaluated to concrete values at compile time. This error means that a shape or dimension argument could not be evaluated at compile time, usually because the value of the argument depends on a parameter to the computation, on a variable, or on a stateful operation such as a random number generator.
	 [[{{node gradients/IdentityN_grad/backwards_fixed_point/fp_solve/while/InvertPermutation}} = InvertPermutation[T=DT_INT32](_arg3, ^_arg0)]]
	 [[{{node gradients/IdentityN_grad/backwards_fixed_point/fp_solve/while/LoopCond}} = While[T=[DT_INT32, DT_FLOAT, DT_FLOAT, DT_INT32, DT_INT32, DT_FLOAT, DT_FLOAT, DT_FLOAT], body=_functionalize_body_4[], cond=_functionalize_cond_4[]](gradients/IdentityN_grad/backwards_fixed_point/fp_solve/while/iteration_counter, gradients/pow_grad/Reshape, gradients/IdentityN_grad/backwards_fixed_point/fp_solve/Fill, ConstantFolding/gradients/pow_grad/BroadcastGradientArgs-folded-1, gradients/IdentityN_grad/backwards_fixed_point/fp_solve/while/maximum_iterations, gradients/IdentityN_grad/backwards_fixed_point/Tensordot/Reshape_1, gradients/IdentityN_grad/backwards_fixed_point/fp_solve/Tensordot/Reshape, gradients/pow_grad/Reshape)]]
	 [[{{node cluster}} = XlaLaunch[Nresources=0, Targs=[DT_FLOAT, DT_FLOAT, DT_FLOAT], Tconstants=[], Tresults=[DT_FLOAT, DT_FLOAT], function=cluster_55287096143340976_f15n_0[], _device="/job:localhost/replica:0/task:0/device:GPU:0"](Const, Const_1, zeros)]]

Code to reproduce the issue
I've been able to distill the issue into ~150 lines of code and package it in a colab. I'd rather not post this code publicly, any way for me to share it with the dev's without pasting it here?

To facilitate debugging this issue, here is a small notebook (~80 lines) which should reproduce the issue (tensorflow 1.13, python 3.6).
Replacing the loop in the gradient function with a fixed graph seems to avoid the issue. The problem seems to be related to the combination of tf.custom_gradient, tf.while_loop, and backprop.make_vjp. Maybe @jlebar might know where the issue lies?

Thank you for the clear STR, @gehring.
@sanjoy can probably speak to this better than me, but it's not clear to me how XLA is supposed to be able to infer shapes here.  I guess we could theoretically examine the loop and notice that, with a particular set of input shapes, the shapes while running the loop are invariant?  That sounds possible but pretty challenging...
I think manually rewriting the graph as you did is probably the best solution here.  Or otherwise you could use autojit and then it will cluster around this.

Thanks for getting back to me so fast! @jlebar, I guess I understand XLA's shape inference a little less than I thought. My understanding is that, in this situation, tensorflow can infer the shapes from the graph but XLA cannot?
As for the static graph workaround, in my use case, the condition will likely terminate the loop before the maximum number of iterations. Would the XLA compiler handle chained tf.cond, and if so, how is the shape inference possible then? Also, typically, we'd want to use a large, conservative maximum iteration which I'm afraid this will cause memory issues as well as long compile time if unrolled.

One off-topic observation first: IIUC InvertPermutation should not need its input to be a compile time constant since it is essentially a scatter.  I'll fix this, though I don't expect fixing this specific issue to resolve the matter since something else will likely force the output of InvertPermutation to be constant (probably a Transpose).
As a starting point I'd recommend trying out Justin's suggestion of using auto-clustering for this model.  We're trying to make auto-clustering do the Right Thing always.  You can enable auto-clustering by setting TF_XLA_FLAGS to --tf_xla_auto_jit=2 or by setting the SessionOptions::config::graph_options::optimizer_options::global_jit_level to ON_2.

but it's not clear to me how XLA is supposed to be able to infer shapes here

For functional while loops, barring some special cases, XLA assumes that the shapes produced by the while loop body stay the same on every iteration.  See tensorflow/compiler/tf2xla/kernels/while_op.cc for the gory details.

My understanding is that, in this situation, tensorflow can infer the shapes from the graph but XLA cannot?

That's one way of thinking about it, I suppose.  Another way of thinking about it is:
In order to run an operation in TensorFlow or XLA, TF/XLA needs to know what are the concrete shapes of the input/output and any intermediate results.  In TF "an operation" is the degenerate case of one TF op, where it's trivial to know the output shapes given the input shapes.  In XLA, however "an operation" is a cluster of multiple TF ops.  This gives XLA additional power, but it comes with restrictions.

As a starting point I'd recommend trying out Justin's suggestion of using auto-clustering for this model.

Thanks, I'll look into that!

In XLA, however "an operation" is a cluster of multiple TF ops. This gives XLA additional power, but it comes with restrictions.

I'm still confused as to why tensorflow can statically infer all the shapes but XLA cannot but, if this is in fact expected behavior, I don't want to take any more of you time than I already have. If it isn't too inconvenient, would you be able to point out what causes the shape to become dynamic/ambiguous and why it would be hard to avoid it? Maybe I can think of an alternative implementation that would side step the issue.

I'm still confused as to why tensorflow can statically infer all the shapes but XLA cannot

Maybe another way of putting it, if it helps, is that TF runs one operation at a time.  So it needs to infer the shape only of the next operation, after it knows the shapes of each of its inputs.  Whereas XLA needs to infer the shapes many steps into the future.

would you be able to point out what causes the shape to become dynamic/ambiguous

https://medium.com/tensorflow/pushing-the-limits-of-gpu-performance-with-xla-53559db8e473 might help, it has some examples of TF code that causes dynamism.

Thank you for those examples. However, I still am unclear how/where dynamism is introduced in my example. With all shapes constantly defined a priori and the assumption that the body of tf.while_loop remains constant, shouldn't shape inference be straightforward?
Additionally, I'm also confused by the fact that the code which led me to this issue compiles fine for a cloud TPU using tf.contrib.tpu.rewrite but raises the same error when using xla.compile (for gpu). I was under the impression that running on TPUs also required compiling to XLA and, as a result, had the same shape restrictions. Are there an important distinctions in the shape constraints between tf.contrib.tpu.rewrite and xla.compile that I might have missed?

Good questions, I really don't know.  Perhaps Yanan or @hpucha can speak to this.  (I'm not sure what is Yanan's github handle.)

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

same issue, any solution

CC @cheshire


Git & Github in Hindi

Category Name
Hindi Tutorial
Subcategory Name
Complete Tutorial
Additional Context
Explain about Git and workflow. Here, you explore about Github.
Link:https://youtu.be/q8EevlEpQ2A?si=mE3i7yeFoEUxcMDQ
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I have checked that this category does not exist
[X] I have checked that this subcategory does not exist
[X] I am willing to work on this issue (optional)

@rupali-codes
What do you think?

@rajneesh-18 you're assigned, please feel free to ask if you need any help

ok i'll raise the pr soon


services/cos: Refactor service newStorage

Signed-off-by: Xuanwo<EMAIL_ADDRESS>

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- services/cos/servicer.go  1

Clones added
============
- services/cos/servicer.go  2

See the complete overview on Codacy