Fix adjustment of logIdxSinceLastRequest variable

This should fix https://github.com/appium/appium/issues/8223

Good idea. Added unit test for log rotation verification

I've finally managed to make the unit test working on Travis. @imurchie can you please check the PR again?

@mykola-mokhnach the test you've written is great but as you pointed out with various uncertainties and tuning required, it's not really a unit test. i was thinking of more of a test that just confirmed your logic (maybe by operating on a simple in-memory store). what you've wrote is great as a functional test.

Yes. More functional than unit.

@jlipps I'd appreciate if you could describe in more details what test you'd like to see instead and I'll try to implement it.

@mykola-mokhnach i.e., don't actually read from and write to files. just manipulate the log array and then prove that calling methods on it returns what we expect and/or mutates the array as we expect.

OK, does it looks more 'unit' now?

Published in<EMAIL_ADDRESS>

Thanks all. so this fix will be available in next appium-beta release ? I guess that would take some time...

@qakapil It's there and you can try it now:
npm remove -g appium
npm install -g<EMAIL_ADDRESS>


Refactor authentication mechanism

fix #1253

@louischan-oursky
The authentication session mechanism is refactored. Only authentication work at the moment, need to fix session mechanism in next PR.

Sorry that I don't have enough time to read the whole PR detailedly. If it looks good to you, feel free to merge it first, I will catch up this later when have time. Thanks a lot! @louischan-oursky @kiootic 🙇🏻♀


There are more than 200 kb after compilation

Is your feature request related to a problem? Please describe.
I use vite to make a wordpress theme and use @vue/apollo-composable to get my article data. I followed the usage in the documentation to successfully get the list of articles.
Describe the solution you'd like
When I compiled using pnpm build, I found that the packaged JavaScript was as high as 232.82 kB │ gzip: 74.01 kB, of which gzip compressed a small part. According to the size limit report 📦 of apollographql/apollo-client, less than 50KB. But my import { ApolloClient, createHttpLink, InMemoryCache } from '@apollo/client/core'` has 145KB.
Describe alternatives you've considered
I see that it imports dist/index.js, and I use dist/index.js to find that it is wrong.
Additional context
Add any other context or screenshots about the feature request here.
//app.js
import { createApp, h, provide } from 'vue'
import App from './app.vue'
import { ApolloClient, createHttpLink, InMemoryCache } from '@apollo/client/core'
import { DefaultApolloClient } from '@vue/apollo-composable'

<script>
import { useQuery } from '@vue/apollo-composable'
import gql from 'graphql-tag';
import { computed } from 'vue';
...
</script>

import { defineConfig } from 'vite'
import liveReload from 'vite-plugin-live-reload'
const { resolve } = require('path')
import vue from '@vitejs/plugin-vue';

export default defineConfig({

    // config
    root: '',
    base: process.env.NODE_ENV === 'development'
        ? '/'
        : '/wp-content/themes/funny/assets/',

    build: {
        // output dir for production build
        outDir: resolve(__dirname, './assets'),
        emptyOutDir: true,
        assetsDir: '',
        manifest: true,
        target: 'es2018',
        rollupOptions: {
            input: {
                app: resolve(__dirname + '/app.js'),
                vue: resolve(__dirname + '/src/main.js')
            },
        },
    },
    plugins: [
        vue(),
        liveReload(
            __dirname + '/**/*.php',
            __dirname + '/**/**/*.{vue,js,ts,jsx,tsx}',
            )
    ],
    //
    optimizeDeps: {
        include: ['vue', 'vue-router'],
    },

})

Do you understand that this repo is small wrapper around apollo lib.
import { ApolloClient, createHttpLink, InMemoryCache } from '@apollo/client/core'
You should create the same issue in repo of apollo. Owner of this repo just simplify using it in vuejs.


Rename password reset methods

Description
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Current dependencies on/for this PR:

main

PR #251

PR #252

PR #253

PR #254

PR #255

PR #256

PR #257   👈

This comment was auto-generated by Graphite.


Drop support for Ruby 2.3

The build doesn't work and this version has been EOL for years. We will consider also dropping support for 2.4 once the build stops passing on that version.

Ruby 2.3 can still be tested against Linux and Windows but, given the cross-platform nature of this gem, I do understand not wanting to officially support something that we can't test everywhere. Would this be a major version increase event?

Coverage increased (+0.01%) to 90.359% when pulling 6317065fc3a196bac20280500e2928d615f2d8ba on drop-ruby-2.3 into a8302c648377de8e1c0bf39ea9ac3c7002ba37a9 on master.

Bumping major version sounds good to me!
What I'm puzzled by is why the JRuby build started failing for seemingly no reason. You can see it passed on one commit and then started failing on another commit that was just a copy change.

Last passing build
Next build that failed

Oh. Right, the OSX/Ruby 2.3 combo stopped working months ago, even with no code changes. Travis still has it as an offered combination but it got broken somehow and I guess that they still haven't fixed it. I took it out of my other projects already. I figure that if I know that my stuff works on OSX and for both earlier and later versions than 2.3, then it is reasonably unlikely that I'll add code that would somehow break only that one combination that I no longer test.

Alright, managed to get the JRuby build to pass with a tweak to the RubyGems and Bundler versions installed.

I could be wrong, but I don't think dropping support for Ruby 2.3 requires a major version release: https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api

Without incrementing the major version, teams who have the following in their Gemfile:
gem 'childprocess', '~> 3.0'

...and running Ruby 2.3 would suddenly start to see failures when installing, since we added a constraint on Ruby version in the gemspec: https://github.com/enkessler/childprocess/blob/6ace7a63b635dceadc08fa4430f3636529fd7341/childprocess.gemspec#L21
Bumping ensures teams opt-in to the new version and dependency requirements explicitly.
If I've misunderstood your point, let me know!

@mvz Even if changing platform limitations does not break the letter of Semver, it would seem to break the spirit of it. That spirit being: "this thing can keep doing what it did before". Speaking from experience, one of the more surprising/annoying things to deal with when it comes to maintaining my projects is having to stick in all kinds of version limits and conditionals because some library decided to put out a patch level release that renders their library unusable for a huge swath of users.
Summary: the code didn't change but how it is used did.

running Ruby 2.3 would suddenly start to see failures when installing

I think this used to be the case for older rubies/rubygems but shouldn't be the case any longer? I agree the Ruby version is a special case because it's handled differently from other versioned dependencies, and there used to be problems with that, but I think those should be resolved now.

Even if changing platform limitations does not break the letter of Semver, it would seem to break the spirit of it.

I would argue that that is exactly why this is mentioned specifically on the Semver website: Your dependencies don't count, and the package manager should deal with it. As I mention above, bundler and rubygems should be able to do so now.
(The reason I'm going on about this is that I'm now going to have to release a new Aruba version just to allow the new childprocess version for dependent projects. It's not a big deal, but I'd prefer this to be seamless).

I think this used to be the case for older rubies/rubygems but shouldn't be the case any longer?

You're right about Bundler! I wasn't aware this feature was added. You'll only see an issue if you specify the version explicitly. TIL.
RubyGems will still fail, however:
⨠ ruby -v
ruby 2.3.8p459
⨠ gem install childprocess
ERROR:  Error installing childprocess:
        childprocess requires Ruby version >= 2.4.0.

For that reason, I think the major version bump is still the pragmatic choice here, but I'm glad to see Bundler supports finding a version that is compatible with the Ruby version constraints. Thanks for the tip!

Unsurprisingly, we are not the first people to have this conversation. ;)
https://www.reddit.com/r/ruby/comments/7vtceq/when_is_it_okay_to_drop_support_for_ruby_versions/


Replace distutils.version with packaging.version.path

Using the pytest plugin on 3.11 (but 3.10 too) gives the following warning:
/home/runner/work/urllib3/urllib3/.nox/test-3-11/lib/python3.11/site-packages/pytest_freezegun.py:5: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
  from distutils.version import LooseVersion

One option to fix this is to use packaging.version.path as done by @hugovk here: https://github.com/python-pillow/Pillow/pull/4797/files
Initial reported in  https://github.com/spulec/freezegun/issues/428 by mistake

Please see PR https://github.com/ktosiek/pytest-freezegun/pull/36.

Following...

Please see PR https://github.com/ktosiek/pytest-freezegun/pull/38 as an alternative.

This error is causing test failures on Python 3.12.

+1

Please see #44 - this package is abandoned and should not be used. Use pytest-freezer instead.

Placing a link to pytest-freezer for easier navigation: https://github.com/pytest-dev/pytest-freezer


[Bug]: Incorrect ConsoleLinkKind type

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
We have an incorrect type for ConsoleLink. And thus when someone uses a ConsoleLink in a non-standard fashion for our use-cases, but a legit fashion for the kind itself, we will get a NPE.

Expected Behavior

We need to set our ConsoleLinkKind types (both frontend and backend) to have an optional applicationMenu and adjust use-cases accordingly.
Steps To Reproduce
Best guess to setting this up would be just create a ConsoleLink without the property set and load up the Dashboard.
Workaround (if any)
No response
What browsers are you seeing the problem on?
No response
Open Data Hub Version
2.5.0

Anything else
No response

To add some info:
The workaround could be to update the links to always have the applicationMenu property

FWIW, I believe the applicationMenu being added to your ConsoleLink will lead you to probably having the link appear in additional places than what you may already want. Depends on your use-cases. Dashboard had a specific one and failed to have proper types to back that up.

see https://github.com/opendatahub-io/odh-manifests/issues/705#issuecomment-1324630908 for context

Hello!
I just wanted to let you know that this issue has happened for me as well.
As a workaround, I could add
  applicationMenu:
    section: Documentation

to the definition of the ConsoleLink.
However, this is a bug and should be solved. :-)
Best, thanks,
Florian

Thanks for reporting your issue as well, this should be low hanging fruit that we can address.

Here's a ConsoleLink instance in RHODS 1.31 RC4:


Fix loading state of invite channel modal

Summary
Adds a loader for channel invite modal
instead of empty state on load, it shows a loader.

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Has UI changes

Very nice 👍

@amyblais Can you help test this PR?
To help make the loading appear more frequently, you can throttle your network speed to be slower via View > Developer > JavaScript Console then choosing the "Network" tab then choosing a 3G network from the dropdown

This is a great improvement to user experience by the way, thank you @sudheerDev for contributing it.

No problem. This was supposed be a part of this PR Made a mistake so was fixing it. :)

Spinmint test server destroyed


Go to implementation should show all implementations if there are multiple

Steps to Reproduce:

Go to implementation on a method that has multiple implementations

=> you end up in any of those
=> I would expect all implementations to show up in our peek UI (same as find references)

Can you please provide some example code that shows this. I just tested a few basic scenarios and confirmed that we do show the peek UI when multiple implementations are returned

I cannot reproduce anymore, I know it happened with resolveContents


Convert to other Fileformat in ImageResizer

📝 Instead of Resizing even convert it as exampel from PNG to J
What is the expected behavior of the proposed feature?  What is the scenario this would be used?
I have a lot of PNGs laying around and there are always new ones that have 30MB and can be reduced to 3-8MB if converted to JPG.
Since I always do this manually, I would like to have the possibility to convert all marked pictures from PNG to JPG directly via profile, maybe change the size further on.
Maybe also other file formats
If you'd like to see this feature implemented, add a 👍 reaction to this post.

dup #2686


Performance with PyTorch 2.3.x

Hello,
I've noticed with PyTorch 2.3.x that AWQ inference is significantly slower. For example, with this model.
It seems like this issue over on PyTorch is related: https://github.com/pytorch/pytorch/issues/129226.
Is this expected?
Thank you.

do you have numbers?

Here is code snippet to help:
import time

from transformers import AutoTokenizer, AutoModelForCausalLM

prompt = """
Answer the following question using only the context below. Only include information specifically discussed.

question: Tell me about Linux
context: Linux is a family of open-source Unix-like operating systems based on the Linux kernel, an operating system kernel first released on September 17, 1991, by Linus Torvalds. Linux is typically packaged as a Linux distribution (distro), which includes the kernel and supporting system software and libraries, many of which are provided by the GNU Project. Many Linux distributions use the word "Linux" in their name, but the Free Software Foundation uses and recommends the name "GNU/Linux" to emphasize the use and importance of GNU software in many distributions, causing some controversy.
"""

messages = [
    {"role": "system", "content": "You are a friendly assistant. You answer questions from users."},
    {"role": "user", "content": prompt}
]

path = "TheBloke/Mistral-7B-OpenOrca-AWQ"
tokenizer = AutoTokenizer.from_pretrained(path)
model = AutoModelForCausalLM.from_pretrained(path).to("cuda")

input_ids = tokenizer.apply_chat_template(messages, add_generation_prompt=True, return_tensors = "pt").to("cuda")

start = time.time()
output = model.generate(input_ids, max_new_tokens = 2048, do_sample = False)
response = tokenizer.decode(output[0])
print("Elapsed", time.time() - start)

With Python 3.8 and torch==2.2.2 it prints:
Elapsed 1.8223834037780762

With Python 3.8 and torch==2.3.1 it prints:
Elapsed 48.8858528137207

It’s not slower, it’s because you are not using kernels compiled for the newest PyTorch and therefore it’s using the naive version which is slow
You can fix this by installing kernels from source (15-20 minutes to compile) or wait for a new release for 2.3.x

Got it. It's slower because there is no version of autoawq-kernels available for PyTorch 2.3.X on PyPI.
Thank you for clarifying.


#3505 Add date modification parsing

This commit addresses #3505. I added a parse_date_modification.rs module to uucore::parser and used it in touch.rs. I added tests to touch.rs to prove the parser works and is not buggy. In theory these changes can also help with similar issues in date.rs but I wanted to keep the PR to one issue at a time.
Thank you for considering my pull request and I welcome feedback if you guys have any.

Lot of work probably went into this, bravo
please add integration tests here too:
https://github.com/uutils/coreutils/blob/main/tests/by-util/test_touch.rs

@sylvestre, you seem to have a pretty good grasp on this already. Shouldn't this be fixed in parse_datetime?

I actually did consider this, but I figured it is not technically parsing a date but a modifier to a date. I can move the changes over to parse_datetime if needed.

Yes, that's what parse datetime is for. It's supposed to parse the format described here: https://www.gnu.org/software/coreutils/manual/html_node/Date-input-formats.html, which includes this part I believe. Porting it would be great!

I made the suggested changes including adding integration testing. I also increased testing to satisfy the code coverage bot, however I'm not sure I was able to get everything. I apologize in advance if the I did something incorrectly; I don't know git very well.

what do you think about moving it into https://github.com/uutils/parse_datetime/ ?

what do you think about moving it into https://github.com/uutils/parse_datetime/ ?

Oh, I see. I misunderstood @tertsdiepraam. Yes, I'm willing to move my work to the parse_datetime. However, I may need more time to investigate the best way to integrate them smoothly.
One observation is that parse_datetime uses Regex for parsing which will render some of my algorithm redundant. Another is that parse_datetime already appears to do something similar but evidently is not parsing '2022-05-15 +01 Month', as pointed out in issue #3505.
In short, I just need to a day or two to reorient myself. But I am confident I can figure it out since I already gained a decent understanding while working on this PR.

@sylvestre @tertsdiepraam I ran into some interesting issues while working to transfer this PR to parse_datetime. I have opened an issue that I think warrants your inputs. Your guidance would be invaluable.

@dcechano sorry but do you have an update ? thanks

@dcechano sorry but do you have an update ? thanks

Yes sir. I am very sorry for the long delay but working out a solution that covers edge cases turned out to be quite challenging. I have been working in the parse_datetime repo as suggested and getting a PR ready.
What has been taking so long is that I had to implement the core logic (which was challenging in its own right) then integrate it into the larger library via lib.rs. That took some unanticipated refactoring, discovering bugs/edge cases ect. I had to find a way to take arbitrary strings with arbitrary formats and figure out how to hand off the appropriate part to chrono and take the remaining and process it via parse-datetime. This was quite a battle to get right. But I am very happy with the result.
After the PR, which I have set a hard goal of getting in by the end of this week, parse_datetime will be able to take arbitrary input like 08-31-2022 12:30:00 +1 month and spit out the result. The only restriction is that the time format has to be in a currently supported format.
I am just cleaning up a bit to make it presentable and implementing more tests to make sure that the code I am submitting is sufficiently robust.

@sylvestre & @tertsdiepraam I have a PR in that is a major step in addressing #3505. I'm looking forward to hearing what you guys think. Thank you!


.dateTime.hour(.defaultDigits(amPM: .omitted)) does not work as expected

Description
We want to format only the hour part of a date using Swift 5.9.2. However, while we expect it to remove the leading 0's according to the .defaultDigits option, unfortunately it does not.
Reproduction
var dateComponents = DateComponents()
dateComponents.year = 2024
dateComponents.month = 8
dateComponents.day = 26
dateComponents.hour = 9
dateComponents.minute = 45

let date = Calendar.current.date(from: dateComponents)
print(date!.formatted(.dateTime.hour(.defaultDigits(amPM: .omitted)).locale(Locale(identifier: "de")))) // Prints "09 Uhr" instead of "9 Uhr"
print(date!.formatted(.dateTime.hour(.defaultDigits(amPM: .abbreviated)).locale(Locale(identifier: "de")))) // Prints "09 Uhr" instead of "9 Uhr"
print(date!.formatted(.dateTime.hour(.defaultDigits(amPM: .narrow)).locale(Locale(identifier: "de")))) // Prints "09 Uhr" instead of "9 Uhr"
print(date!.formatted(.dateTime.hour(.defaultDigits(amPM: .wide)).locale(Locale(identifier: "de")))) // Prints "09 Uhr" instead of "9 Uhr"

Expected behavior
Formatter should remove leading zeros
Environment
swift-driver version: 1.87.3 Apple Swift version 5.9.2 (swiftlang-<IP_ADDRESS>.56 clang-15<IP_ADDRESS>.5)
Target: arm64-apple-macosx14.0
Additional information
No response

In the DateFormatter API of Swift, the .defaultDigits option does not usually take out initial zeros for hours especially in locales that use them in time representation like the German locale (de).
If you want to achieve what you need, you may have to perform a custom DateFormatter configuration.
Try to add this chunk of code
let formatter = DateFormatter()
formatter.dateFormat = "H 'Uhr'"
formatter.locale = Locale(identifier: "de")

By specifying dateFormat = “H ‘Uhr’”, you indicate that you want to use a 24-hour format (H) without leading zeros, and the Uhr is included in the formatted output.
Then you can get output by simple optional binding
if let date = date {     print(formatter.string(from: date)) }


CSS: Consider using a smart server side CSS parser

Up until now we've been using PHP files that generate CSS. This is okay, but the CSS syntax is still junk.
Some parsers out there offer a much nicer CSS syntax. There are limitations to consider. PHP does give us a lot of added flexibility, but practically we haven't been using it. The majority of work in .css.php files has been color mixing. A real tool may do a better job overall.
Introducing a CSS parser has the added benefit of not having to change the file extension, meaning CloudFlare will be able to figure out it should be cached.
The downside is that it has to be implemented both on the Apache (toolchain) and LSWS (server) side. Ultimately it's probably worth it though.

The two main contenders are Less and Sass. These days it seems Sass is the more popular one. Either would be an advantage over doing it manually in PHP.  They're more powerful and yet easier to write). Color calculation is something they're commonly used for.
For caching purposes, typically you'd include .sass -> .css conversion and minification as a step in your build process and then serve the minified css.

All of your constants can become Sass variables. e.g.
const MOBILE_QUERY = "(max-width : 600px)";

becomes
$MOBILE_QUERY: "(max-width : 600px)";

and can be substituted in place the same as now, without the line noise of jumping in and out of
The lookup table in theme-hub-.css, however, looks like it can be calculated. Is this calculated somewhere already? It could be done in-place, instead.
background:<?=PAL_RED[COL_MUTE_LIGHT]?>;

becomes
$base-color: #622;
background: mute-light($base-color)

where mute-light is a custom function you've written.

I have been looking in to Sass, but in an unusual way. What I wanted to do was configure the server(s) to automatically run .css files through the SASS parser, as you typically do with .php and other server side scripts.

Development side: It would mean you could test changes natively, without the need to recompile.
Deployment side: Because I run our sites behind a reverse proxy (CloudFlare), they would cache a the output .css file.

To my surprise there was no FastCGI SASS interpreter. It might be because Sass is a Ruby tool, but there is an official C library that does Sass parsing. So a few weeks ago I started experimenting with this, and I pretty-much know exactly what to do to get this working, I just occupied by other things and wasn't able to finish.
https://github.com/povrazor/sass-cgi
The wall I was unfortunately rather fundamental (i.e. getting the FastCGI script to execute). I think I have my test server configured correctly. It hangs exactly where the script should be running. But again, I haven't had a chance to pick it up and investigate since there.

After a bit of homework, I'm leaning away from Sass and leaning more towards using tools in the PostCSS suite.
https://github.com/postcss/postcss
That said, I'm focused on backend at the moment, so it's not something I'm too concerned with right now.

Are css files changed dynamically during the application serving period?.
Rather than add something new to the toolchain that would build and serve some css template files, just add a build step to your development. During development you can run an application created in any language you want that will listen for file changes and immediately re-build Sass / output regular css files.
For my use, I use a node package called webpack. During development webpack runs and listen for file changes on js or sass(scss in my case) files, upon any change it re-builds them into packaged distribution files that my web application is already pointing at, expecting to serve them like regular ol' js or css files (they are at this point). If you use a separate cdn, you can just upload those dist files to the cdn, they are regular css files.
During deployment just run your packer / Sass builder once to create dist files or include the built / minimized output files into the repository to avoid the deployment step.

Are css files changed dynamically during the application serving period?

No. Or rather, they wont be.
Currently the CSS files are PHP files, which does give them the luxury of variables. For testing, parameters can be tweaked as part of the request, but in practice it's clumsy. Way back, I had a lot of requests for being able to customize the theme, but in practice this doesn't make CSS any nicer to work with.
I'm more interested in writing shorter, concise, localized (not translation) CSS code. PHP gave us variables, but things like nesting/grouping would also be handy, once a style is finalized.
AutoPrefixer is a great example of what I see as genuinely useful, and it comes as part of the PostCSS suite. Hence why I'm more leaning that direction.
https://github.com/postcss/autoprefixer
Anyway, like I mentioned on Twitter I'm not currently putting too much focus on frontend (I'm all backend and server side at the moment). I am casually investigating things as a change of pace, but like I said, it's casual at the moment. I didn't like how development worked with the WIP prototype from last summer. I know it can be better.
For a very rough look at what I'm thinking, on the bottom of the style guide page is a random scattering of notes.
https://github.com/ludumdare/ludumdare/wiki/Style-Guide
What I don't say there is that the frontend needs a toolchain, and I haven't decided what I like there yet. Tools like PostCSS and AutoPrefixer definitely seem like the right direction when it comes to CSS (probably some GULP build file), but for pages and layout I'm not entirely decided there. The fewer distinct languages and dialects, the better.
This is getting off topic, but when I say backend, I'm referring to the REST API and all the database access goodness, local caching, and optimization there. A large part of the site will be moved entirely to restful calls, but for search engine indexing, your regular URLs still need to still spit out something.
And as the code base has grown, I'm not entirely happy with how some parts are done (for example, 30+ database table create queries in one script file, and a 2nd file that needs to be updated with deletes). A topic I hope to cover in the style guide is locality, the idea that things that relate to a topic should be in one place. But there's a give and take there. It's easier to scroll down/search in a single file then it is to search across multiple files. In practice a single file for everything isn't practical, but a single folder could work (i.e. everything related to users in /modules/user, the DB create script, destroy script, the backend query calls, the JS code for calling the API, etc).
I am happy with the elements (PHP 7, APCu, JavaScript, CSS, MariaDB, Vagrant, OpenLiteSpeed, Ubuntu), it's just tying them together the right way.

On the front end topic, as is pertaining to this topic, a gulp build file is exactly what I'm talking about.
You can use node-sass with postcss together to create a Sass compiler/autoprefixing build step, and you can even auto-listen to file changes during development to rebuild sass to css output files (autoprefixing doesn't matter so much in a dev environment). Create a gulp file that you will run as a deployment build step to output minified, prefixed css dist files compiled from sass and BOOM, done! That front really isn't too complicated.
As far as database scripts, have you looked into any sort of migration system? It would be immensely helpful if you're sticking with a relational db.

The only thing you would have to add to your toolchain, and for development only, is node.
With node you can then add node-sass and postcss to your package dependencies.
During development
If you want to watch the sass files for changes and rebuild the css automatically
node-sass -w static/sass/ -o static/build/css/
During deployment
node-sass static/sass/ -o static/partial/css/
postcss --use autoprefixer static/partial/css/*.css -d static/build/css/
Obviously this step would be automated into one command via gulp and wouldn't create the intermediary partial folder, I just don't know the exact usage of gulp to say here.
Now your static/build/css has regular ol' css files that you can use, upload to cdn, whatever.

I'm not entirely convinced of Sass yet. Several of its key features are becoming part of the core CSS 4 standard, and I'm more likely to prefer something that's future proof. WordPress bit us in the arse many times over the past decade, and things that were hot a decade ago like Flash are becoming rarer today.
CSS is here to stay (it's the web). JavaScript is here to stay (it's also the web). Ruby, and a custom parser written in Ruby (Sass), it's hard to say. It may become the Python of the next decade (i.e. around but not really changing).
But I'll have to see. I haven't looked as closely at the CSS 4 proposals yet, what Microsoft/Google/Mozilla/Apple think yet (whose in), and what features of parses like Sass and Less are genuine improvements to CSS development.
And yes there will be some data migration, but that's a whole other topic.

In my opinion, it's good to rely on browsers implementing brand new functionality as little as possible. It's probably not a great idea to put all your chips into css4 since that LARGELY depends on the browser that is rendering your page. With something like Ludum Dare you have a lot of users with a whole ecosystem of different browsers and different versions and you don't want to be poly filling missing features, as it is you'll have to poly fill flex-box anyway for certain browsers. ( please tell me you're using flex box :D ).
Sass gives you css that works now, that will work in the future, and it's definitely not going any where. Sass also definitely is NOT a ruby only thing it's used everywhere now in many different environments and contexts that just happened to be where it started. My company uses it in our python project via the webassets extension, we pack it up using node-sass for our php project. It can't go anywhere there's too many people using it and relying on it.
As I said though, you can 100% use postcss WITH sass, Sass is basically just css with nesting, inheritence, importing, and variable support, you will be able to write css4 inside of Sass files if you really want. There's really no downside to using it except the build step, but you're adding the build step anyway with postcss so might as well take one extra step while you're at it.

In my opinion, it's good to rely on browsers implementing brand new functionality as little as possible.

Oh sure. I meant syntactically. Sass, Less, and CSS 4 are just lists of features. No matter which way you go, you're still beholden to the limitations of CSS 2 and 3. I may still favour Sass in the end, but I want the preprocessor to favour the coding style. I'm using CSS 4 as an example, but PostCSS has hundreds of plugins, and it itself is designed to make writing new parsers easy. What I'm trying to say is I'm not ruling out Sass alternatives, at least not yet.
For example, of the style guides out there, I'm currently favouring one called RSCSS.
http://rscss.io/
There's a brevity and descriptiveness to it I like versus BEM and ECSS, but I haven't had a chance to see what I think of it in practice.
One coding style document I was reading made reference to bugs in Sass regarding media queries. I can't remember where I saw it, but given how splintered the Sass spec is (original Ruby Sass vs. everything based on libsass), it should be tested.
I'm just saying this a fairly important decision with a bunch of repercussions. ;)

My… writing style can often come across as overly hostile, so I will apologize up-front.  I'm sorry if my enthusiasm for web development forces me into any hasty wording, or over-triteness.  I post this comment with the best of intentions, to help inform and educate, not to merely confront.  (Nor am I trying to sell you on Python, but this is where my main experience lies.  Just want to show what web dev can look like.)
TL;DR — Please, please, please use SCSS, either autoprefixer (recommended by Google, used by Twitter) or postcss which includes it, and a build automation tool of some kind, with either a build step for deployment or git commit hook to always check-in the latest compiled/minified versions during development, and built-in file watching / live reloading capabilities while developing.
For a concrete example, your Style Guide wiki page RSCSS example: (split on two lines to illustrate)
.search-form .-variant {}
.search-form > .button {}

vs.
.search-form {
    &-variant {}

    > {
        button {}
    }
}

Removal of repeated selector prefixes.  Which is more readable and structured?

A real tool may do a better job overall.

I guarantee you it will.  PHP is an HTML template engine, not a CSS generation engine.  It has no optimizations, shortcuts, helpers, or integration to assist in the task of building CSS.

Introducing a CSS parser has the added benefit of not having to change the file extension, meaning CloudFlare will be able to figure out it should be cached.

This is irrelevant when using preprocessors correctly.  There are several options: run a watcher during development to automatically recompile/minify, add it as a git commit hook, or have a build stage prior to deployment.  During development, SASS can be live-reloaded in your browser while you work using the first approach, massively decreasing turnaround time on making design changes.  .map file generation means you can even use your browser's developer panel to edit your SASS, with changes being quite live.

I have been looking in to Sass, but in an unusual way. What I wanted to do was configure the server(s) to automatically run .css files through the SASS parser, as you typically do with .php and other server side scripts.

This is an unfortunate approach to investigating the tool; using it in a non-standard, non-recommended way is a sure fire recipe to get the wrong impression, get frustrated, and give up on the tool.  It is not meant to be used that way at all.    Notably, because the potential build process for your CSS might include automatic vendor prefix addition, automatic sprite sheet construction, automatic data-uri construction, combination, and minification, amongst others.  You want the final asset delivered to the client to be a single static .css file, generally, not a hodgepodge of generated-on-demand (slow) needlessly dynamic individual files.

To my surprise there was no FastCGI SASS interpreter. It might be because Sass is a Ruby tool, but there is an official C library that does Sass parsing.

SASS is a universal tool.  (I use python-libsass which executes the C library routines natively, using the Python asset build automation tool WebAssets to manage such generation, minification, etc.  Even contributed back the ability for @import directives to be serviced by Python callbacks…)  There is no FastCGI SASS interpreter because it is an explicitly bad approach to using the tool, losing out on a large majority of the benefits of the tool.

After a bit of homework, I'm leaning away from Sass and leaning more towards using tools in the PostCSS suite.

They are not mutually exclusive, and work exceptionally well together.  One does not replace or obviate the other, unlike postcss including autoprefixer.

Currently the CSS files are PHP files, which does give them the luxury of variables.

So does BASH shell script.  ;)  This still doesn't make it a good approach when richer, more task-specific tools exist that are better than using a general purpose language, or simple template engine, in every measurable way.

The only thing you would have to add to your toolchain, and for development only, is node.

Actually… you don't even need that, if you use a language like Python which supports running JavaScript directly within your application's process.  My own codebases run JavaScript as Python (letting me use Node tools like autoprefixer natively via an embedded ducktape interpreter, possibly one is available for PHP?), and let me write my front-end JavaScript as Python using transpilers (transcrypt or others).  Turtles all the way down, one language syntax to keep in your head-space, one set of static analysis tools, etc.

CSS is here to stay (it's the web). JavaScript is here to stay (it's also the web). Ruby, and a custom parser written in Ruby (Sass), it's hard to say. It may become the Python of the next decade (i.e. around but not really changing).

Fearing that a tool used by millions worldwide will go away spontaneously is not a reasonable fear.  WordPress is hardly comparable, as it's not a build tool, it's an entire application suite.  Even when SASS added SCSS syntax, they didn't break older use, it's open source so you can always build your own copy, etc.  Your comment on Python demonstrates a substantial lack of knowledge about Python.  (3.5 adding end-to-end async support and async flow control such as async def or async for being only one example of recent change.  The times, they are a-changing! ;)

I haven't looked as closely at the CSS 4 proposals yet, what Microsoft/Google/Mozilla/Apple think yet (whose in), and what features of parses like Sass and Less are genuine improvements to CSS development.

What CSS 4 "in the future" will provide is irrelevant in the face of a tool (SASS) that exists in stable production-ready form today, and CSS being text, and SASS a text processor for CSS, it'll be compatible anyway.  Nested rulesets.  Variables.  Functions.  Mix-ins / templates.  Ease of component-driven-design.  Inclusions.  The ability to define callbacks and SASS functions in the general purpose language of your choice and export them to your SASS.  This is just a small list of improvements over bare CSS.

Sass, Less, and CSS 4 are just lists of features. No matter which way you go, you're still beholden to the limitations of CSS 2 and 3.

You seem to misunderstand the use of a number of the components listed so far.  The things you have reimplemented (.css.php gives me the willies ;) are solved problems, better solved using one of the existing packages.  There are several reasons why this is the case: "feature lists" is a casual dismissal, here, and "feature lists" aren't the point.  Increasing developer productivity is.  Even more useful is the increased headcount of potential contributors who know how to work with these existing solutions.  I recommend SCSS (a slightly more CSS-flavoured format for SASS), as does most of the industry.  This isn't because SASS adds any end-user features beyond CSS ("beholden to the limitations" is… an interesting phrasing!  I approve. ;) but instead because it makes construction of your CSS a simplified, boilerplate-reduced, duplicated-selector-eliminated, no-more-by-hand-processing (ref: sprites, data-uri, functions for colours and such) joy, with high likelihood that random off-the-street front end developers are already comfortable working with it.
Similarly, use of autoprefixer (a standard part of postcss but usable independently) completely eliminates the need to write vendor-specific prefixes in order to support these standard CSS features, further reducing the developer headspace needed to safely and correctly make changes or additions to your site design.
Thank you for taking the time to read my feedback on this situation.

First I should mention this is a necro-thread, originally posted over a month ago, before I started looking in to this. A TODO item. I am not focused on front end, so I've only been casually looking at this stuff.
Second, my fault since I didn't make it clear, I canned the SassCGI plugin after learning about Compass and other file scanners, but more importantly after learning about PostCSS. There is A LOT under the PostCSS banner, a lot of it is CSS 4, and what I've done a poor job saying is I want to be sure I know what PostCSS has to offer before I finalize anything. I very briefly looked at CSS 4, and I saw the things I was looking for that my lame PHP setup lacked. I don't come from a web-dev background, so I have no history with the big 3 (Sass, Less, PostCSS), no prejudice with them, so I'd like to be thorough.
This article by the author of a Sass book saying "Oh, it turns out you don't need Sass" got me started down this rabbit hole:
https://benfrain.com/breaking-up-with-sass-postcss/
Third, I have been looking at Less and Sass, but admittedly I am leaning toward Less. I spent the past few hours doing a raw feature/syntax compare, since they do the exact same thing. I've discovered there is a lot of misinformation regarding Less. Here's one such article trying to clear it up:
https://getcrunch.co/2015/10/08/less-the-worlds-most-misunderstood-css-pre-processor/
I do like how variable evaluation works in Less versus Sass (i.e. lazy). It's more flexible. The dialect is starting to grow on me as well.
I am not done my homework though.

Your comment on Python demonstrates a substantial lack of knowledge about Python

Thanks.
A decade ago, Python and PyGame were a common and popular way to make Ludum Dare games. Nearly a quarter, if not more used it. Today, it's less than 1%.
Also, software that added integrated scripting support around Y2K tend to use Python (Blender). Software that added integrated scripting closer to 2010 and beyond tend to use Lua.
That's what I'm talking about when I talk about the fall of Python. It's not a hot language anymore.

Ludum Dare goers probably moved away from PyGame because it's just not a very good engine.
Flixel + FlashPunk were the LD favorite for a while, then Unity now right? The Unity tooling just blows everything else out of the water. Doesn't really mean its supported languages are the best.
As for scripting integration, Lua is designed for integration. You compile it right in and expose it through a C api.

Getting back to CSS....
Here's the best resource for looking up CSS compatibility:
http://caniuse.com/#tables
e.g http://caniuse.com/#feat=css-animation
Auto-prefixing: I don't see this as very important actually, but you have multiple tools that can provide it. You don't have to buy in to one environment. I do a lot of frontend work in my job and I just take a quick look at caniuse when I'm unsure of needed prefixes.
CSS4: Technically there's no "CSS4". CSS is now split into modules and there's a "selectors level 4" module. But in any case we're overthinking things here. Your existing CSS is pretty simple, even with variable substitutions.
On the topic of variables, look how ugly native CSS variables are:
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_variables
Not supported on IE, Android below 5, older or not-updated iPhones....
http://caniuse.com/#feat=css-variables
So pre-processors provided this feature for years before a spec arrived and they'll still be the best choice for years to come. I wouldn't bet everything on any future spec.

Since you don't have a web dev background, I'd say don't overthink it and just try one out. Don't worry about picking the "perfect" preprocessor, especially for such relatively simple CSS as you have now.

Heh, seemed pretty active for a necrothread, but apologies for any incidental summoning from the dead.  ^_^;

@povrazor: A decade ago, Python and PyGame were a common and popular way to make Ludum Dare games. Nearly a quarter, if not more used it. Today, it's less than 1%.

So your experience with Python is a decade old, with a horrendously engineered tool.  I don't see how any of this is relevant to web development and not just more distraction from just picking something and getting moving.  My original statement stands.

@BillyWM: Auto-prefixing: I don't see this as very important actually…

You mention caniuse.com, which means manual labor and headspace, which is silly!  autoprefixer (again, independently or as part of postcss, I don't really care which) uses the caniuse.com data itself to automate that labour.  I honestly can not comprehend the friction, here.

@povrazor: I have been looking at Less and Sass, but admittedly I am leaning toward Less.

SASS benefits from a substantially nicer (less hacky to get "real work done") syntax for functions and flow control (conditional statements).  When I used LESS, my function declarations involving conditionals looked like Christmas trees.  Here's a counter-article: https://css-tricks.com/sass-vs-less/  (But we can link counter-counter and counter-counter-counter articles to eachother until the end of days, that won't provide any progress on actually getting things done.)


Either finish this Version or Update PowerShellGetv2 with my Bugfix already

Hi, please either finish development of this version of PowerShellGet already or accept my Bugfix for PowerShellGetv2:
https://github.com/PowerShell/PowerShellGetv2/pull/592
The fix is literally just one line. You delete one line in an if statement and it is fixed.
You still send out PowerShell Core 7 with the same f-ing Bug in PowerShellGet which will reinstall all Scripts to the User-Scope instead of the scope they were installed in when you update them via Update-Script. I sent you a fix, you said you will instead develop this version of PowerShellGet. But not only is this taking forever, you even shipped out a new Version 2.2.5 of PowerShellGetv2 WITHOUT my bugfix (I've fixed it in 2.2.3 already). I don't believe this >:[
Please, fix this Bug NOW for PowerShell Core 7, I can't use your newest product on our servers because you're not fixing this!

For everyone with the same problem:
I have written a PowerShell script that will fix this bug after you installed PowerShell 7 Core.
You can get the script here:
https://github.com/echalone/TUN/blob/master/PowerShell/Scripts/Tools/Local/Tools.Local.RepairPS7CorePowerShellGet.ps1
Whenever you installed OR updated PowerShell 7 Core on a machine, execute this script so my PowerShellGet Module Version 2 bugfix is applied. The script should find the installation directory on its own, but if not, you can provide the installatin directory for PowerShell 7 Core via the "PowerShellCorePath" parameter. The script will ask you for your confirmation if it should apply the fix, if you want to skip this confirmation add the switch -NoConfirm to your call of the script.
That's it, the script will search for the bug in your installed PowerShellGet module version and replace the line with the fixed line via a regular expression. Should the module already be fixed or of another version without this bug in it, then the fix will not be applied and you will be told so by the script. So it should be relatively save to run this script, even if you're not sure of your PowerShellGet module version. If it's one that needs to be fixed, it will fix it, if not, it won't, easy as that.

For everyone with the same problem:
I have written a PowerShell script that will fix this bug after you installed PowerShell 7 Core.
You can get the script here:
https://github.com/echalone/TUN/blob/master/PowerShell/Scripts/Tools/Local/Tools.Local.RepairPS7CorePowerShellGet.ps1
Whenever you installed OR updated PowerShell 7 Core on a machine, execute this script so my PowerShellGet Module Version 2 bugfix is applied. The script should find the installation directory on its own, but if not, you can provide the installatin directory for PowerShell 7 Core via the "PowerShellCorePath" parameter. The script will ask you for your confirmation if it should apply the fix, if you want to skip this confirmation add the switch -NoConfirm to your call of the script.
That's it, the script will search for the bug in your installed PowerShellGet module version and replace the line with the fixed line via a regular expression. Should the module already be fixed or of another version without this bug in it, then the fix will not be applied and you will be told so by the script. So it should be relatively save to run this script, even if you're not sure of your PowerShellGet module version. If it's one that needs to be fixed, it will fix it, if not, it won't, easy as that.


Fix lint error in Storage Quickstart.

Will wait on green and merge myself, given that the change is extremely trivial.


Multiple karma - gridsort order configuration bleeds over

Is there a way to specify for a given Karma the grid sort order based on a label.
Answer that I know: Yes, in the UI in the configuration.
Unfortunately, when accessing a second Karma with the same browser, the setting is applied to the second instance of Karma. The two Karma instances have different users and need different grid sorting.
Is this preference stored in a Cookie?
Is there a way to have a unique cooki per Karma instance, or force the setting in the configuration file?

Configuration is saved to browsers localStorage -  https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage. There should be no problem in hosting multiple instances as long as each has a unique domain (karma1.example.com and karma2.example.com). If you are using two instances on the same domain but different root uri then I think they will share same browser localStorage data.
https://github.com/prymitive/karma/blob/master/docs/CONFIGURATION.md#ui-defaults tells you how to configure UI defaults in the config file.

Ok, we are using www.domain.com/karma and www.domain.com/division2/karma.


URI parser fails when there is a : in the path

Guzzle version(s) affected: 6.5.2
PHP version: 7.2.22
cURL version: 7.64.0
Description
When i tries a POST to uri https://fcm.googleapis.com/v1/projects/****/messages:send  the Uri is incorrect
GuzzleHttp\Psr7\Uri^ {#308
  -scheme: "messages"
  -userInfo: ""
  -host: ""
  -port: null
  -path: "send"
  -query: ""
  -fragment: ""
}

not tested on other versions

this is likely a php bug of parse_url. if you encode the : it will probably work

That's odd
 php -a
Interactive mode enabled

php > var_dump(parse_url('https://fcm.googleapis.com/v1/projects/****/messages:send'));
array(3) {
  ["scheme"]=>
  string(5) "https"
  ["host"]=>
  string(18) "fcm.googleapis.com"
  ["path"]=>
  string(31) "/v1/projects/****/messages:send"
}

php -v
PHP 7.4.2 (cli) (built: Feb  5 2020 16:50:38) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.2, Copyright (c), by Zend Technologies
I got that on php 7.2.22 will investigate inside a container

php -v
PHP 7.2.14 (cli) (built: Jan 31 2019 00:52:40) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.2.14, Copyright (c) 1999-2018, by Zend Technologies
/srv # php -a
Interactive shell

php > var_dump(parse_url('https://fcm.googleapis.com/v1/projects/****/messages:send'));
array(3) {
  ["scheme"]=>
  string(5) "https"
  ["host"]=>
  string(18) "fcm.googleapis.com"
  ["path"]=>
  string(31) "/v1/projects/****/messages:send"
}

same with php 7.2.22, :(

https://3v4l.org/WWB1a

So it's not a parse_url bug. Can you provide a reproducer please? At best a failing test case in guzzle.

i found the issue, this reproduce when using baseuri
$http = new Client([
            'base_uri' => 'https://fcm.googleapis.com/v1/projects/test/',
            'timeout' => 0,
            'allow_redirects' => false,
        ]);

        try{
            $response = $http->post('messages:send');

        } catch (RequestException $exception) {
            dump($exception->getRequest());
        }

the relative uri is considered an absolute one due to :

Closing as 'messages:send' is not a valid relative URI. It get's interpreted as a full uri with messages as schema according to the URI RFC spec. What you can do is set https://fcm.googleapis.com/v1/projects as base and use test/messages:send as relative part.

'./messages:send' should also work as relative part.

Thanks


Important Doc Fixes

This is a bit of cleanup from a review @kirilstrax did for us. I'd like to be able to use something like |version| to dynamically populate areas like this in code, and will look at this shortly. In the meantime, this fixes documentation to be functional for debian.
:cherries:-picked a similar fix at https://github.com/StackStorm/st2/commit/545b34fb40068a70a070fab8ed42abd44993c3ed

|release| and |version| are already available in the docs, with one unfortunate exception - I dind't figure how to use them in the formatted text or code block (specifically, here)

Presumably not very important since it is stuck around for more than a month :P


Fast refresh

Organise the routing using parent and children concept

In the items.contant.tsx file, I encountered a hurdle while trying to render the Lucide Icon component. To achieve this, I needed to use the .tsx extension for the file to support TypeScript and JSX syntax. However, the challenge arose because I wanted to export a constant from this file. According to the rules of Hot Module Refresh (HMR) in React, exporting constants in a React component file is not allowed.
This situation resulted in a contradiction between our needs and expectations. Although I came across some open-source code where this rule seems to be avoided, the implementation remained similar to ours.
To summarize, the requirement to use .tsx extension to render Lucide Icon components conflicted with the need to export a constant in the React component file, as per HMR rules. Finding a workaround for this issue became crucial to solve the react-refresh/only-export-components warnings.


Applicant - Add error messages about unchecked review page & acknowledgements

User Story
As an applicant
I want to be restricted from submitting my application before I check the box on the review page (if mandatory fields are empty) & check all the acknowledgements
so that I don't miss important parts of my application.
Acceptance criteria

[ ] Scenario: unchecked review page disable submit and show alert
Given that a user had empty mandatory fields and did not check the checkbox on the review page
when they are on the submission page
then the submit button is disabled
and an alert shows on the submission page above the "submit" button

Please go back to the previous pages and review your responses to submit your application
Hyperlink "review your responses" to go to the review page

[ ] Scenario: unchecked acknowledgments disable submit and show alert
Given that a user did not check every checkbox on the acknowledgements page
when they are on the submission page
then the submit button is disabled
and an alert shows on the submission page above the "submit" button

Please go back to the previous page and check all acknowledgements
Hyperlink "acknowledgements" to go to the acknowledgements page

Design

Description
Avoid people skipping the review and acknowledgement page and jumping to the submission page by entering the submission page URL. There's a discussion in the Scrum Team channel on August 31, 2022 about this.

Hey team! Please add your planning poker estimate with Zenhub @AntBush @wenzowski @marcellmueller @matthieu-foucault @VB-at-Bis

Something that I think should be added to the AC - the checkbox on the review page is (currently) not stored in the DB and I assume we want both DB and frontend validation that the review page checkbox has been checked yes?

the checkbox on the review page is (currently) not stored in the DB

This is getting fixed in the review page refactor

Backend validation in submit_application for review page checkbox

This requires backend validation of our form data, which should be split in a separate ticket

Any objections for moving this out to the backlog.  This can wait until the sprint or two before our next intake

@MarsRomer no objections here.

Please add your planning poker estimate with Zenhub @rafasdc


Source control commit procedure gets stuck until COMMIT_EDITMSG window is closed when committing with no message.

Type: Bug
A message is necessary when committing, but you can still start the process, which gets the procedure stuck until the COMMIT_EDITMSG window is closed, at which point the procedure fails due to the reason mentioned before.
VS Code version: Code 1.95.3 (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z)
OS version: Windows_NT x64 10.0.19045
Modes:

If you uncheck the git.useEditorAsCommitInput setting (i.e. set it to false) do you get the behaviour you want?


feat: version 0.0.4

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 95.95960% with 12 lines in your changes missing coverage. Please review.

Project coverage is 96.90%. Comparing base (59ac4ef) to head (6d2fe06).

Files
Patch %
Lines

src/lib/engine/http.lua
91.57%
8 Missing :warning:

src/lib/protocol/http_curl.lua
88.00%
3 Missing :warning:

src/lib/engine/pipeline.lua
90.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #24      +/-   ##
===========================================
- Coverage   100.00%   96.90%   -3.10%
===========================================
  Files            2        8       +6
  Lines          103      388     +285
===========================================
+ Hits           103      376     +273
- Misses           0       12      +12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUG] SPC b b broken after Emacs update

Describe the issue
My config worked fine (with Emacs 26.something), but I updated Emacs (now 26.3) and also pulled the latest version of doom-emacs.
After starting Emacs, I tried SPC b b, but instead of showing the buffer I got the message: Symbol’s function definition is void: +workspace-contains-buffer-p
Backtrace

Debugger entered--Lisp error: (void-function +workspace-contains-buffer-p)
  (+workspace-contains-buffer-p buffer)
  (and (not (eq buffer (current-buffer))) (+workspace-contains-buffer-p buffer))
  (let ((buffer (car buffer))) (if (stringp buffer) (progn (setq buffer (get-buffer buffer)))) (and (not (eq buffer (current-buffer))) (+workspace-contains-buffer-p buffer)))
  +ivy--is-workspace-other-buffer-p((" *Minibuf-1*" . #))
  internal-complete-buffer("" +ivy--is-workspace-other-buffer-p t)
  all-completions("" internal-complete-buffer +ivy--is-workspace-other-buffer-p)
  ivy--buffer-list("" nil +ivy--is-workspace-other-buffer-p)
  ivy--reset-state(#s(ivy-state :prompt "Switch to workspace buffer: " :collection internal-complete-buffer :predicate +ivy--is-workspace-other-buffer-p :require-match nil :initial-input nil :history nil :preselect "*doom*" :keymap (keymap (33554443 . scroll-down-command) (33554442 . scroll-up-command) (10 . next-line) (18 . evil-paste-from-register) (2 . backward-word) (1 . move-beginning-of-line) (26 closure (t) nil (interactive) (condition-case nil (progn (call-interactively (function undo))) (error nil))) (22 . yank) (escape . abort-recursive-edit) (19 . counsel-minibuffer-history) (11 . previous-line)) :update-fn nil :sort nil :frame # :window # :buffer # :text nil :action (1 ("o" ivy--switch-buffer-action "default") ("i" #f(compiled-function (x) #) "insert") ("w" #f(compiled-function (x) #) "copy") ("f" ivy--find-file-action "find file") ("j" ivy--switch-buffer-other-window-action "other window") ("k" ivy--kill-buffer-action "kill") ("r" ivy--rename-buffer-action "rename") ("x" counsel-open-buffer-file-externally "open externally")) :unwind nil :re-builder nil :matcher ivy--switch-buffer-matcher :dynamic-collection nil :display-transformer-fn ivy-rich--ivy-switch-buffer-transformer :directory "/home/vince/workspace/trading/bitcoin-p1/" :caller ivy-switch-buffer :current nil :def nil :ignore t :multi-action nil))
  ivy-read("Switch to workspace buffer: " internal-complete-buffer :action ivy--switch-buffer-action :predicate +ivy--is-workspace-other-buffer-p :update-fn nil :unwind nil :preselect "*doom*" :matcher ivy--switch-buffer-matcher :keymap (keymap (33554443 . scroll-down-command) (33554442 . scroll-up-command) (10 . next-line) (18 . evil-paste-from-register) (2 . backward-word) (1 . move-beginning-of-line) (26 closure (t) nil (interactive) (condition-case nil (progn (call-interactively (function undo))) (error nil))) (22 . yank) (escape . abort-recursive-edit) (19 . counsel-minibuffer-history) (11 . previous-line)) :caller ivy-switch-buffer)
  (let ((current (not other)) prompt action filter update unwind) (cond ((and workspace current) (setq prompt "Switch to workspace buffer: " action (function ivy--switch-buffer-action) filter (function +ivy--is-workspace-other-buffer-p))) (workspace (setq prompt "Switch to workspace buffer in other window: " action (function ivy--switch-buffer-other-window-action) filter (function +ivy--is-workspace-buffer-p))) (current (setq prompt "Switch to buffer: " action (function ivy--switch-buffer-action))) ((setq prompt "Switch to buffer in other window: " action (function ivy--switch-buffer-other-window-action)))) (if +ivy-buffer-preview (progn (cond ((not (and ivy-use-virtual-buffers (eq +ivy-buffer-preview ...))) (setq update (function +ivy--switch-buffer-preview) unwind (function +ivy--switch-buffer-unwind))) ((setq update (function +ivy--switch-buffer-preview-all) unwind (function +ivy--switch-buffer-unwind)))))) (ivy-read prompt (quote internal-complete-buffer) :action action :predicate filter :update-fn update :unwind unwind :preselect (buffer-name (other-buffer (current-buffer))) :matcher (function ivy--switch-buffer-matcher) :keymap ivy-switch-buffer-map :caller (function ivy-switch-buffer)))
  +ivy--switch-buffer(t nil)
  +ivy/switch-workspace-buffer(nil)
  funcall-interactively(+ivy/switch-workspace-buffer nil)
  call-interactively(+ivy/switch-workspace-buffer nil nil)
  command-execute(+ivy/switch-workspace-buffer)

emacs doctor output:

Doom Doctor
Emacs v26.3
Doom v2.0.9 (nil)
shell: /usr/bin/zsh
Compiled with:
  XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD LCMS2
uname -msrv:
  Linux 4.15.0-64-generic #73-Ubuntu SMP Thu Sep 12 13:16:13 UTC 2019 x86_64
Checking Emacs
Checking your Emacs version is 25.3 or newer...
Checking for Emacs config conflicts...
Checking for private config conflicts...
Checking for stale elc files...
Checking your system...
Checking DOOM Emacs...
WARNING: The :fetcher property was used for the smartparens package.
This property is deprecated. Replace it with :host.
Initialized Doom Emacs 2.0.9
Garbage collecting...
Garbage collecting...done
Initialized 39 modules
Initialized 161 packages
Checking Doom core for irregularities...
Garbage collecting...
Garbage collecting...done
Garbage collecting...
Garbage collecting...done
Garbage collecting...

Checking your enabled modules...
Garbage collecting...
Garbage collecting...done
Garbage collecting...
Garbage collecting...done
(Shell command succeeded with no output)
Everything seems fine, happy Emacs'ing!

System information

WARNING: The :fetcher property was used for the smartparens package.
This property is deprecated. Replace it with :host.
WARNING: The :fetcher property was used for the smartparens package.
This property is deprecated. Replace it with :host.
((emacs
  (version . "26.3")
  (features . "XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD LCMS2")
  (build . "Sep 16, 2019")
  (buildopts "--build=x86_64-linux-gnu --prefix=/usr '--includedir=${prefix}/include' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' --sysconfdir=/etc --localstatedir=/var --disable-silent-rules '--libdir=${prefix}/lib/x86_64-linux-gnu' '--libexecdir=${prefix}/lib/x86_64-linux-gnu' --disable-maintainer-mode --disable-dependency-tracking --prefix=/usr --sharedstatedir=/var/lib --program-suffix=26 --with-modules --with-file-notification=inotify --with-mailutils --with-x=yes --with-x-toolkit=gtk3 --with-xwidgets --with-lcms2 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs26-TP6iDo/emacs26-26.3~1.git96dd019=. -fstack-protector-strong -Wformat -Werror=format-security -no-pie' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro -no-pie'")
  (windowsys . batch)
  (daemonp . server-running))
 (doom
  (version . "2.0.9")
  (build . "HEAD -> develop, origin/develop, origin/HEAD 42df2eaf8 2019-09-15 19:24:51 -0400"))
 (system
  (type . gnu/linux)
  (config . "x86_64-pc-linux-gnu")
  (shell . "/usr/bin/zsh")
  (uname . "Linux 4.15.0-64-generic #73-Ubuntu SMP Thu Sep 12 13:16:13 UTC 2019 x86_64")
  (path "~/.emacs.d/bin" "~/.local/bin" "~/bin" "~/.emacs.d/bin" "~/.local/bin" "~/bin" "~/miniconda3/bin" "~/miniconda3/condabin" "~/.emacs.d/bin" "~/.local/bin" "~/bin" "/usr/local/sbin" "/usr/local/bin" "/usr/sbin" "/usr/bin" "/sbin" "/bin" "/usr/games" "/usr/local/games" "/snap/bin" "/usr/local/go/bin" "~/go/bin" "/usr/local/go/bin" "~/go/bin" "/usr/local/go/bin" "~/go/bin" "/usr/lib/x86_64-linux-gnu/emacs/26.3/x86_64-linux-gnu"))
 (config
  (envfile)
  (elc-files . 34)
  (modules :completion company ivy :ui doom doom-dashboard doom-quit hl-todo modeline nav-flash ophints (popup +all +defaults) treemacs vc-gutter vi-tilde-fringe window-select workspaces :editor evil file-templates fold multiple-cursors rotate-text snippets :emacs dired electric vc :tools docker eval flycheck flyspell (lookup +docsets) magit pdf :lang data emacs-lisp (latex +latexmk) markdown (org +dragndrop +ipython +pandoc +present) python sh :config default)
  (packages ag highlight-indent-guides yapfify "(smartparens :recipe (:repo \"Fuco1/smartparens\" :host github))" py-isort org-ref org-fancy-priorities org-super-agenda "(persp-mode :disable t)")
  (elpa "n/a")))

Does doom clean; doom refresh help?

Thanks for the suggestion, it doesn't help.
I also tried starting from a completely clean install (git clone, doom install, doom refresh) and it was the same.

@vakker It appears you have the :ui workspaces module enabled, but the persp-mode package disabled (with (package! persp-mode :disable t) in ~/.doom.d/packages.el). +workspace-contains-buffer-p is an alias for persp-contain-buffer-p, which won't exist because the plugin is disabled.
Since persp-mode is essential to the :ui workspaces module, I'd suggest disabling the module altogether, instead.

Ah, thanks, that was it. It's weird why it stopped working suddenly, I totally forgot about disabling it.


Change ArchiMate constraints applied per default

Indeed, it prevents creating quickly freely a graph with various node types and relations.
The activation of constraints should be made on the parameters menu for constraints,  selecting enforce in place of relax

Done


Convert EventGrid tests to Track2

Currently, EventGrid tests are written in a legacy fasion, see here.
As part of modernizing EventGrid for Track2, we must utilize the proper test harness as seen here
This will broadly involve:

Writing a preparer for the EventGrid resource as seen here
Utilize the preparer on the Event grid tests mentioned above, adjusting credentials to properly thread through.
Adjusting the wrapper class to StorageTestCase as seen here
Generate new recordings, and validate that tests still run properly in both live and recorded mode

Looks like this was added to the wrong repo.


Pressure readings are sometimes off

Enhance logging of pressure - treat values out of 900 - 1100 as invalid

And also check value read against the last read value and if the difference is > 20 and time diff is < 10 mins, then treat the value as invalid too

The latter is not done afterall.


⚠ GitLab Server has degraded performance

In 8c92c1d, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 8367 ms

Resolved: GitLab Server performance has improved in 0311aaa.


Repository scc-slack-handler not found

Hi Garrett,
the referenced repo https://github.com/gschaeffer/scc-slack-handler gives me a 404.
Is that a mistake or on purpose?
Kind regards,
Matthias

Thank you @ramshazar. The repo is updated and correct :)


feat: add talisman

Interbtc UI Pull Request Template
Description
https://github.com/TalismanSociety/talisman-connect/tree/master/packages/connect-components.

I'll close this as this feature is on hold for the time being. Branch will stay open so we can pick up development down the track.


Replace the fitter of StarkRamseyXYAmpScan experiment

Summary
This PR replaces the fitter of StarkRamseyXYAmpScan experiment. Current fitter puts strong assumption on model parameter and it makes the fitting quite unstable to the change in dephasing rate.
This PR doesn't introduce any breaking API change and a separate release note is not necessary because the experiment is not released yet.
Details and comments
The current fitter simultaneously fits the P1 values of the Ramsey X and Y experiment. Given the Stark shift is the third order polynominal of tone amplitude x, the P1 values for X and Y are
Px(x) = A cos(2 pi t_S (c1 x + c2 x**2 + c3 x**3 + f_err)) + offset
Px(x) = A sin(2 pi t_S (c1 x + c2 x**2 + c3 x**3 + f_err)) + offset

where t_S is the fixed Stark delay and others are the fit parameters. Note that current fitter assumes that A is independent of x, however, since this is a variant of Ramsey experiment, the P1 amplitude actually depends on x. This is because qubit T2 may depend on the frequency, or at larger Stark amplitude the qubit heating may cause faster dephasing. In the new fitter, we directly extract the phase polynominal and perform fit on this synthesized data. Namely,
poly = unwrap(arctan2(Py, Px)) ~ 2 pi t_S (c1 x + c2 x**2 + c3 x**3 + f_err)

Because A is canceled out in this form, the fitting becomes robust to the amplitude dependence of the dephasing rate. Usually we cannot obtain the reasonable model for A(x).
For example, the experiment data below shows the difference of fit on the poly data and raw Px, Py data (actually the parameters are fit on the poly data and Px, Py data are just visualized with the fitted parameters).

As you can see, the Px, Py data are damped quickly on positive amplitudes, and the envelope of the trigonometric function  is asymmetric with respect to 0. In this situation the current fitter doesn't work well. In contrast, new phase fitter works nicely.

I was just looking over this again. I think it is still in good shape (besides one small wording suggestion). It just needs to be updated after #1319 is merged. That should take care of the test failure related to class ID numbers changing by 1.


[Help] I am a newer of exceljs, Where Can I find for complete demo for exceljs ?

I' am a newer for exceljs , Can anybody give me some help for complete demo code?

study this #create-a-workbook


Cannot read properties of undefined (reading 'send')

Hi Team, unable to send-sms. Did a clean git clone of this repo, wondering if the server-sdk version in the package.json is the correct version to work with the node snippet.

The package-lock.json is set to pull down<EMAIL_ADDRESS>which is the current version and has the new messages namespace.
Can you check which version of the package you have installed? npm list @vonage/server-sdk should return something similar to:
± |master ✓| → npm list @vonage/server-sdk
<EMAIL_ADDRESS>/home/ctankersley/Projects/vonage/node/vonage-node-code-snippets
└──<EMAIL_ADDRESS>

So it should download that version even if the package.json is showing "@vonage/server-sdk": "^2.10.0"?
➜  vonage-node-code-snippets git:(master) ✗ npm list @vonage/server-sdk
<EMAIL_ADDRESS>/Users/kittphi/Desktop/Repos/vonage-node-code-snippets
└──<EMAIL_ADDRESS>
➜  vonage-node-code-snippets git:(master) ✗

Interesting, as the package.json file is set to ^2.11.0 now in master.
Can you try and update the repository with git pull --rebase origin master to make sure it's pulling in the remote changes to your local master branch?

I ran the command you suggested git pull --rebase origin master and it pulled the correct version.
➜  vonage-node-code-snippets git:(master) npm list @vonage/server-sdk
<EMAIL_ADDRESS>/Users/kittphi/Desktop/Repos/vonage-node-code-snippets
└──<EMAIL_ADDRESS>➜  vonage-node-code-snippets git:(master) node ./messages/send-sms.js
{
  body: {
    title: 'Invalid params',

Looks like the provided .env-example will need to be updated to the correct process.env.TO_NUMBER and FROM_NUMBER. Thanks for helping out with that 🍻.


Infer union type based on string literal

Suggestion

🔍 Search Terms

typescript infer union type

✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Adding a way to infer the correct type in a union using a value of its own key.
📃 Motivating Example
If I have the following type, it is a simple Union where we always have a type key and we find a key of the value of the type.
You can see it directly in the playground:
https://www.typescriptlang.org/play?#code/C4TwDgpgBAKgjFAvFA3gKClUkBcUDkwAlsADYT4A0GWJ5eAzsAE5EB2A5mgL5QA+qGtgh58AYwAWEMQGsARgHsAHlRqTp85XkULyAQzY80aMQrZMoYZgsjNiEBnngBtALpIozmukyZho4jIKal9aINEACQhSUgUoAHcFZlIAE1VMbhDBUP8CdVlFFSzMfM0lPAAzPVIGCBpuNFdjKxsIOyIHADoAWz0wAApopAA+bKgAenGoACEQKFL2DiwpKAA3aoBXaAUK5ehhKBkIEEo9qHYKtog2MWgiBigUszrMIl3B0k6DxB+CQPJ8ABKKDMCDADbMNhQaLOaJfcAQJo0SawKSg84PMykObPSwKBgMIhyIikEhzdhQBQQqAbNhEMw0UHgyHQ0iwz7CJrcQHNay2ewMHp9D4jMYogCSbEuoJudwebAUwEeuIMKWW92VDigCqViWYMmhq2u5121VIWARDwpVOYNLpZigvWAkkZYIhUJhcM5PEBQA
type T1 = {
  type: 'title',
  title: string
} | {
  type: 'checkbox',
  checkbox: boolean
}

const properties: T1[] = [
  {
    type: 'title',
    title: 'Hello world',
  },
  {
    type: 'checkbox',
    checkbox: false
  }
]

properties.map(el => {
  // By checking the value of the type key, the inference is done
  if (el.type === 'title') return el[el.type]

  // There is only one possibility in our union
  return el[el.type]
})

properties.map(el => {
  // Inference is not done and this does not work even if all types in our union match
  return el[el.type]
})

💻 Use Cases

I am querying an external API that returns me a list of properties:
{
    "properties": {
        "isActive": {
            "type": "checkbox",
            "checkbox": true
        },
        "email": {
            "type": "email",
            "email"<EMAIL_ADDRESS>        },
        "content": {
            "type": "rich_text",
            "rich_text": {
                "plain_text": "Hello world",
                "blocks": []
            }
        }
    }
}

I want to normalize this data into:
{
    "isActive": true,
    "email"<EMAIL_ADDRESS>    "content": "Hello world"
}

There are some specific property types like rich_text where I need a specific normalization process.
And by default I simply want to return the value.
type PropertyTypes = 'email' | 'checkbox' | 'rich_text'

type PropertyDenormalizedValueMap = {
  'email': string;
  'checkbox': boolean;
  'rich_text': {
    plain_text: string,
    blocks: any[]
  }
};

type PropertyNormalizedValueMap = {
  'email': string;
  'checkbox': boolean;
  'rich_text': string;
};

type PropertyObject<T extends PropertyTypes> = {
  [key in T as string]: {
    type: key;
  } & {
    [property in key]: PropertyDenormalizedValueMap[key];
  };
}[T];

interface Normalizer<T extends PropertyTypes = PropertyTypes> {
  normalize(data: PropertyObject<T>): PropertyNormalizedValueMap[T];
}

class RawNormalizer implements Normalizer<'email'|'checkbox'> {
  normalize(data: PropertyObject<'email'|'checkbox'>): PropertyNormalizedValueMap['email'|'checkbox'] {
    // By checking the `type` key it infers the Type
    if (data.type === 'checkbox') return data[data.type];

    // The only possible type in our union make this possible
    return data[data.type]
  }

  normalize2(data: PropertyObject<'email'|'checkbox'>): PropertyNormalizedValueMap['email'|'checkbox'] {
    // This is not possible as there is no inference done
    return data[data.type]
  }
}

class RichTextNormalizer implements Normalizer<'rich_text'> {
  normalize(data: PropertyObject<'rich_text'>): PropertyNormalizedValueMap['rich_text'] {
    return data.rich_text.plain_text
  }
}

Here is a playground to test the above code: https://www.typescriptlang.org/play?#code/C4TwDgpgBACgTge0nUAVcEDOUC8UDkEAtgIYCWANvlAD4EDGAFhPQNYBGCAHtXfnGSYB9YBC7B8AKEmhIsRMlAARCADsEcUhTIAvCABMAaiQoBXCAFkSYXFADekqAWLkqALiiZgA1QHMA3I4MzGycPB6cCBQQJKqBTvyCjCJiEh4OTk5gFOSqKeIeXj6+ADRBTuwUCGyYHrEgANoAukEAvpKtgTIY8kgQKCAAchpaugbGZpbWthnOpJT4hd5kfvHBLBzci1CR0bFricKi4ttFKwEdXbLQ8H0DAPLsAFYswAA8qFCpavrYt4ogdCQTAAPhmQQarAgICgKygnxI2DOfia6XKUGuHihIDWrSgADJ7OiGmAFP1QLDVFBsajegCVOpNCYxkYTOYrGBIdCmrjAq0GqgedIVqI4AAzEj0aDDJnaPRwD5fcQ-P5kgZArC2f7kwEYUFEpyM0Z6AAU+hIwBIHm1D2erw+IIAlNa1aAZcbxmyppzBXzpPQcphsAAlEgAd3dzPlsKI2WIamA2Ejcv6b0I8yoNHwTA2YXwYNmRqjEDNFqtdJ1jxe9He6dc+CzOdCWydLrubpGxdZkw5DTrC0bIU2PCaBsyAHpx1AAEIwpusc4Y5hQAAG1xX1OhsOAlLF-WwwGXGvRZDFUFLloAdNdcDg8Nmh3nHVA4BBgKY4FTzZaGt+SNeMCFdFJ3hZcEFUCgYTABAgzISpoBvOEEA-KBTFUMhwKgUgoSXMhsGg2D4PRV930-KA-1-MsAMgFonHaIIixTAAmC9yxtUAq3tftMwfXMW2dCsBmTFkJnZaw+xcAdeObEcxycEDUEYPDYWwdQdwIzA4OiKBESXfpoGU9Rd301QpXI8CIGIt8Py-MtKKva5aKgdp6IDREQySVBUmE6MyFjaIiATJNOxTBVDmSY4JALBiQrGVi2wBTiazTAQjlSfMBPYoZYr0bsxM5cL8gkUdZicEibPIqjUoi1JL2yXIiraDogA

I found this related issue but it imply to know the type value.
#17915

It's not practical for TypeScript to evaluate code based on iterating through all possible inhabitants of a union type and seeing if the code checks for each inhabitant - this would be quickly very combinatorially explosive.
This pattern can be represented however, see #47109 for details


This method must be called on the main thread was thrown while invoking showAd

Trying to load an interstitial ad, on touchable opacity press. Displays the error shown in the issue title.
Exception 'This method must be called on the main thread' was thrown while invoking showAd on target CTKInterstitialAdManager with params ( "PLACEMENTID", 30, 31 )
              onPress = {
                () => {
                  this.showFullScreenAd()
                }
              }

  showFullScreenAd() {
    InterstitialAdManager.showAd("PLACEMENT_ID_WAS_HERE").then(didClick => {}).catch(error => {});
  }

I have the same problem, any idea?

Nope.
Let's hope the author takes the time to fix his issue.
On Tue, Mar 7, 2017 at 9:39 AM, Martín Acuña Lledó<EMAIL_ADDRESS>
wrote:

I have the same problem, any idea?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/callstack-io/react-native-fbads/issues/47#issuecomment-284739396,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIMdD5F3rIkBhcmf02e6L404g6K8Yj-Gks5rjWwjgaJpZM4MS80m
.

Happen on Facebook SDK 4.20.0
(for quick fix, use the old 4.19.0 version)

I try use the old 4.19.0 version but same error?

Does this happen every time? This should be easy to fix.

Yes happen every time

okay, I'll try to fix it tonight.

How to fix _onAdError event?

Any luck @satya164 ?

Update Facebook SDK to the latest version(4.22.1) will fix the problem.

We bumped the Facebook SDK version for next version, so going to close it.


React Native 0.57 setAnomymizeIp error

Since upgrading to React Naitve 0.57 the App crashes. Commenting out setAnonymizeIp "fixes" the problem.
Environment
React Native 0.57.4
iPhone 6 iOS 11.4 (Simulator)
Steps to Reproduce
Start Simulator + App
Expected Behavior
No Error
Actual Behavior
App throws error
Agument 0 (NSString) of GoogleAnalyticsBridge.setAnonymizeIp must not be null

Code sample/demo project
import { GoogleAnalyticsTracker } from 'react-native-google-analytics-bridge'

const tracker = new GoogleAnalyticsTracker(config.GA_TRACKING_ID)

Tracker.setAnonymizeIp(true)

Actually my environment variables were missing and config.GA_TRACKING_ID was undefined. My bad.
The error message is still very confusing as it looks like the problem is coming from setAnonymizeIp. Thanks anyways.


Balder/document weight iterator must support term wise

@havardpe PR, No semantic changes ( at least not intentional)

attribute_searchable_adapter_test.cpp:479: error: check failure #1: 'result.iterator_dump.find("FilterAttributePostingListIteratorT") == vespalib::string::npos' in thread '0(1)' (attribute_searchable_adapter_test.cpp)
STATE[0]: 'require that single weighted set turns filter on filter fields' (attribute_searchable_adapter_test.cpp:467)
ok, so you are testing that a weighted set tagged as filter with a single element becomes a filter iterator and not a document weight iterator... which makes the pull request title a bit misleading...

Correct, the pull request was made before the root cause was fully investigated. It just reflected the what was first observed and concluded to be incorrect.
However it turned out to be nothing wrong with the code. It was missing restart detection at deploy time....


Derive organ capacity from modifiers

Started with Fullness... it seems to be working! I'll do inebriety and spleen next! Let me know if you spot anything that needs testing or is just obviously broken.

Move to modifiers for Fullness
Rename Cow Puncher vars to reflect the fact that it has a space
Add class shortcut for AWoL classes

Questions:

I am trying to make the modifier Base Stomach Capacity: 0 meaningful. Typically our modifier system takes zero as "remove/ignore this modifier" but that doesn't work here. Do I keep the current workarounds or do I add a boolean No Stomach Capacity mod instead?
We're in a funny place with recalculateAdjustments in test code, it's being run over and over again - I wonder if we replace things like...

var cleanups = new Cleanups(...);

try (cleanups) {
  ...
}

with (names to be discussed)
sim(new Cleanups(...), () -> {
  ...
});

where sim is something like
public static void sim(Cleanups cleanups, Runnable cb) {
  try (cleanups) {
    KoLCharacter.recaluclateAdjustments();
    cb.run();
  }

  KoLCharacter.recaluclateAdjustments();
}

we could even put a flag on cleanups indicating whether they need a recalculation and only do this if one of the cleanups supplied had that flag.

Do I keep the current workarounds or do I add a boolean No Stomach Capacity mod instead?

The latter IMO. Magic values aren't great.

I think I made OrderedRunnable for this -- remove it from the individual methods and add an OrderedRunnable that runs it at the end of the initial setup, and again at the end of the cleanup.

Oh that's smart. Hmm ok. But it still doesn't solve the issue of having to add withAdjustmentsRecalculated all the time. Maybe that's ok.

Do I keep the current workarounds or do I add a boolean No Stomach Capacity mod instead?

The latter IMO. Magic values aren't great.

Ok this is currently working(?) without that change. As I start to make it there are just a bunch of similar changes that would need to be here instead. Out of interest, what are you classing as a magic value here?

Also for drunk I think there is at least one class who can't drink but can get drunk from bang potions. There's Gelatinous Noob but that one also has a limit of -1.

I think that this won't be a problem. We'll see.

I think I made OrderedRunnable for this -- remove it from the individual methods and add an OrderedRunnable that runs it at the end of the initial setup, and again at the end of the cleanup.

This turned out to not be that useful. I ended up just putting things that I know recalculateAdjustments at the end.

Ok this is currently working(?) without that change. As I start to make it there are just a bunch of similar changes that would need to be here instead. Out of interest, what are you classing as a magic value here?

I misunderstood the issue, but why does Base Stomach Capacity have to exist with a zero value, instead of just not existing and functions that interrogate it returning 0 if it doesn't exist? I guess I think modifiers is a bad fit for this, because surely everything has exactly one "Base Stomach Capacity". So why not have a function that looks this up based on path / class and only use modifiers for the extras?

I feel like Limit is a bit different, because you can have multiple limits and the lowest applies (e.g. you're in Small, with Cowrruption, with a cap gun equipped), but you'll only ever have one Base X Capacity.

I feel like Limit is a bit different, because you can have multiple limits and the lowest applies (e.g. you're in Small, with Cowrruption, with a cap gun equipped), but you'll only ever have one Base X Capacity.
I think this should be a function instead of a modifier.

You are right, this is better.


Training files missing

Hi Guys, thank you for your work and release!
I'm trying to proceed to training on my own 3D model and I'm doing it on Google Colab. While I've followed exactly everything in installation guides I get an error indicating that I don't have the files mentioned in includes in this code (TensorViewBind.h):
#pragma once
#include <tensorview/pybind_utils.h>
#include <tensorview/profile/all.h>
#include <limits>
#include <tensorview/cuda/nvrtc.h>
#include <tensorview/gemm/core/nvrtc_bases.h>
#include <tensorview/gemm/core/params.h>
#include <tensorview/gemm/core/nvrtc_params.h>
#include <cxxabi.h>
#include <common/TensorView.h>
#include <common/PyBind11.h>
namespace tensorview_bind {
using TensorView = common::TensorView;
using PyBind11 = common::PyBind11;
struct TensorViewBind {

  static void hello();
  /**
   * @param params
   */
  static void run_nvrtc_conv_kernel(tv::gemm::ConvParams params);
  /**
   * @param params
   */
  static void run_nvrtc_gemm_kernel(tv::gemm::GemmParams params);
  /**
   * @param module_
   */
  static void bind_enums(pybind11::module_ module_);
  /**
   * @param module_
   */
  static void bind_nvrtc_params(pybind11::module_ module_);
  /**
   * @param module_
   */
  static void bind_gemm_algo_desp(pybind11::module_ module_);
  /**
   * @param module_
   */
  static void bind_conv_algo_desp(pybind11::module_ module_);
  /**
   * @param module_
   */
  static void bind_conv_params(pybind11::module_ module_);
  /**
   * @param module_
   */
  static void bind_gemm_params(pybind11::module_ module_);
  /**
   * @param m
   */
  static void bind_tensorview(pybind11::module_ m);
};
} // namespace tensorview_bind

I have checked the directories and turns out I really don't have them installed. I tried to reinstall the tensorview but these files are still not being installed. I tried to find files from the internet and upload files manually but there are literally a lot of different versions of same files. For example I found 3 different versions of pybind_utils.h .  I'm stuck here and would appreciate your help. The best would if you could provide access to correct version of these files that will help me proceed with my training.
Thanks in advance!

Hi, thanks for your interest in our work!
Unfortunately, we haven't tried running the code on Google Colab. Has anyone else been able to assist this?


update url for Goofy.app

the app download is no longer hosted on aws

Thank you for the contribution. It needed some fixes, so they were made in the below referenced pull request. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Application freezes browser if it is opened for some time

:white_check_mark: coverage increased from 0% to 100%


Uncaught exception in Vue.filter function may cause the framework crash?

I think it's very common that you got an uncaught exception in filter function because of an unexpected input , which should not cause the whole page crash.
Maybe tell everybody ALWAYS use try...catch for filter function in document , or the framework should handle this exception and goes on .

@Nihiue Hello!
It's definitely a pain sometimes and I think it's a good thing to treat it the same way as template expression error with throwing a warning message.
The issue should probably be labeled as suggestion.
As for now I propose you to check the value type in filter function.
For example, if you expect an Array, you could handle it like this:
function (value) {
    if (Array.isArray(value)) {
        return value.map(function (item) { return item });
    }

    return value;
}

I think it is the user's responsibility to handle edge cases the custom filters, just like in any other code you write. Throwing errors in JavaScript always crash the app, that's just how it works.


[Templating] "Missing" Twig Block page_header

Hi,
I'm currently experimenting with the bundle in a prototype. Thanks for the effort!
I would propose to add a new block (maybe named: page_header) to the default layout.
The content of the block would be the following div;
https://github.com/kevinpapst/TablerBundle/blob/14ac8dcbb1324b899be4f75c613b8bba896452f7/templates/layout.html.twig#L79-L110
With this block it would be possible to hide all the header elements (page_subtitle, page_title, page_stats and breadcrumb) for a clean layout.
Thanks
Chris

Implemented by https://github.com/kevinpapst/TablerBundle/pull/31