'sharedApplication' is unavailable: not available on iOS (App Extension)

When I try to build my iOS app (which includes a share extension) I'm getting this error:
❌  [...]/node_modules/react-native/React/Modules/RCTTiming.m:150:49: 'sharedApplication' is unavailable: not available on iOS (App Extension) - Use view controller based solutions where appropriate instead.

    _backgroundTaskIdentifier = [[UIApplication sharedApplication]<EMAIL_ADDRESS>expirationHandler:^{
[...]

My Podfile looks like this:
platform :ios, '10.3'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

def common_pods
  pod 'FBLazyVector', :path => "../node_modules/react-native/Libraries/FBLazyVector"
  pod 'FBReactNativeSpec', :path => "../node_modules/react-native/Libraries/FBReactNativeSpec"
  pod 'RCTRequired', :path => "../node_modules/react-native/Libraries/RCTRequired"
  pod 'RCTTypeSafety', :path => "../node_modules/react-native/Libraries/TypeSafety"
  pod 'React', :path => '../node_modules/react-native/'
  pod 'React-Core', :path => '../node_modules/react-native/'
  pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
  pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
  pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
  pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
  pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
  pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
  pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
  pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
  pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
  pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
  pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
  pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'

  pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
  pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
  pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
  pod 'ReactCommon/jscallinvoker', :path => "../node_modules/react-native/ReactCommon"
  pod 'ReactCommon/turbomodule/core', :path => "../node_modules/react-native/ReactCommon"
  pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

  use_native_modules!
end

target 'MyApp' do
  # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
  # use_frameworks!

  # Pods for MyApp
  pod 'Hakawai', '6.0.1'

  common_pods
end

target 'ShareExtension' do
  # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
  # use_frameworks!

  # Pods for ShareExtension
  common_pods
end

target 'NotificationService' do
    # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
    # use_frameworks!

    # Pods for NotificationService
    # pod 'Sodium', :git => 'https://github.com/jedisct1/swift-sodium.git'
    pod 'Sodium', '0.8.0'
end

post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            if ['Sodium'].include? target.name
                config.build_settings['SWIFT_VERSION'] = '5.0'
            end
        end
    end
end

React Native version:
System:
    OS: macOS 10.15
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 1.17 GB / 32.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.10.0 - /var/folders/r4/pdxxhfbj3cqg_0n5th1p2t400000gn/T/yarn--1571217098131-0.37052803821248426/node
    Yarn: 1.19.0 - /var/folders/r4/pdxxhfbj3cqg_0n5th1p2t400000gn/T/yarn--1571217098131-0.37052803821248426/yarn
    npm: 6.11.3 - ~/.nvm/versions/node/v12.10.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.1, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>00203
    Xcode: 11.1/11A1027 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.2 => 0.61.2
  npmGlobalPackages:
    react-native-cli: 2.0.1
    react-native-git-upgrade: 0.2.7

Steps To Reproduce

Just build a dummy iOS app having a share extension target will trigger this

Now I guess one could simply replace the sharedApplication call with RCTSharedApplication() as a quick fix (I've done it but then it fails somewhere further in DevSupport-RCTDevLoadingView) but I'm wondering if it's the best approach or if there are pods that can simply be excluded from the extension target?

@alexisbronchart I had add some lines in my Podfile which fixed the issue (for now).
post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'NO'
    end
  end
end

@kevinetore it builds, thanks! Did you get a build on the app store without any problem?

@alexisbronchart I only released a version to Testflight with the 61.2 upgrades, no problems there.


Add PromQL language support

This PR adds support for PromQL: https://prometheus.io/docs/prometheus/latest/querying/examples/

Thanks for the thorough feedback already! I have addressed the styling issues, split keywords and functions as appropriate, simplified some things and added another comment to address one of your questions :) To be honest, I'm not sure about all the original motivations, as I reused some code from the Monaco highlighter and the blog post I referenced, but thanks to your review, I think it's pretty cleaned up now.

Thank you for the quick response!
I still have some minor nits but it's overall it looks really good now.

Done!

Thank you for contributing @arendjr!

Thanks for your support! :rocket:


Error when using stratified_split[BUG]

Describe the bug
I'm using my own dataset based on movielens and each time I try to split the data it gives me this error
ValueError: With n_samples=1, test_size=0.1 and train_size=None, the resulting train set will be empty. Adjust any of the aforementioned parameters.

To try and see if I was doing something else wrong, I run the Quickstart exactly as it is, the only difference is that i used my own dataset and prepared it with the following code:
movielens_df = pd.read_csv('movielens-metadata/ratings_small.csv', delimiter=';')
movielens_df.rename(columns={'userId':'user_id', 'movieId':'item_id'}, inplace=True)
movielens_df['rating'] = movielens_df['rating'].transform(lambda x : float(x.replace(',','.')))
df = movielens_df

But then if I use the read_movielens_df it works perfectly. Also this problem only occurs when using stratified_split, I tested random_split and it worked fine.
Here is the dataset if you want to try it yourself
ratings_small.csv

Hi @sgaseretto.
Perfect timing! Right now, we have a ticket to make this issue a lot more transparent (something that @emmafgrimes is actually going to work on in the next week, funnily enough), but the short answer is that the error is a valid one, but the error message itself is awful.
Currently, the stratified split attempts to ensure that every user appears in both the training and validation datasets, but when you have a user who only has one interaction, the function can't do the split properly and complains with this obscure error. To circumvent this, I would suggest using this function before doing a stratified split:
https://github.com/ShopRunner/collie/blob/0963998ded3eb566fda863ad462ab5bec6bcd223/collie/utils.py#L168
The ticket we have to fix this is just improving the error message, but I wonder if we should maybe also include a flag, something like ignore_warnings that, when in this situation, just puts that user with a single interaction in the training dataset and doesn't error out at all.
What do you think of this idea @sgaseretto @emmafgrimes?

Hi @nathancooperjones & @sgaseretto:
I think adding a parameter like ignore_warnings to stratified_split is a great idea. I still think improving the error message when ignore_warnings = False is worthwhile as well.

First of all, thanks for the really fast response!! It helped a lot. Also I agree with you both about the flag parameter. I'm digging into the code of stratified_split to understand it better because something odd happened. For this particular dataset, only after using min_num_of_interactions=23 the stratified_split worked fine, but using a number smaller than 23 kept returning the error.

Sorry for the delayed response on this again @sgaseretto!
When I try to use the dataset you attached above with stratified_split, I don't seem to get an error. Here's the code block I am using to test this out:
from collie.cross_validation import random_split, stratified_split
from collie.interactions import Interactions
import pandas as pd

df = pd.read_csv('/Users/nathan.jones/Downloads/ratings_small.csv', sep=';')
df = df.drop_duplicates(subset=['movieId', 'userId'])

df['userId'].value_counts().min()  # output: 19

interactions = Interactions(users=df['userId'], items=df['movieId'], allow_missing_ids=True)

stratified_split(interactions, test_p=0.2)

I would expect the split to break when we have an interactions dataset with a user that only appears once in the dataset, such as the following example built off the last:
new_df = (
    df
    .append(
        other=[
            {'movieId': df['movieId'].max() + 1, 'userId': df['userId'].max() + 1},
        ],
        ignore_index=True,
    )
)

interactions = Interactions(users=new_df['userId'], items=new_df['movieId'], allow_missing_ids=True)

stratified_split(interactions, test_p=0.2)  # raises the ``ValueError``

But, taking this same example and adding in the remove_users_with_fewer_than_n_interactions call, it works now, which is what I would expect.
from collie.utils import remove_users_with_fewer_than_n_interactions

new_df = (
    df
    .append(
        other=[
            {'movieId': df['movieId'].max() + 1, 'userId': df['userId'].max() + 1},
        ],
        ignore_index=True,
    )
)

# added line
new_df = remove_users_with_fewer_than_n_interactions(df=new_df, min_num_of_interactions=2, user_col='userId')

interactions = Interactions(users=new_df['userId'], items=new_df['movieId'], allow_missing_ids=True)

stratified_split(interactions, test_p=0.2)  # works now!

Alternatively, if we instead appended two rows to that df, such that that user appeared twice in the dataset instead of only once, the split should work as expected, even if we do not call the remove_users_with_fewer_than_n_interactions function.
new_df = (
    df
    .append(
        other=[
            {'movieId': df['movieId'].max() + 1, 'userId': df['userId'].max() + 1},
            {'movieId': df['movieId'].max() + 2, 'userId': df['userId'].max() + 1},  # added line
        ],
        ignore_index=True,
    )
)

interactions = Interactions(users=new_df['userId'], items=new_df['movieId'], allow_missing_ids=True)

stratified_split(interactions, test_p=0.2)  # works too!

Can you attach the code block you were using where you got that error with a number smaller than 23? We are very interested in fixing this bug!
Happy holidays!


feat: add Windows Support

tl;dr;
This PR add Windows support.

I've confirmed forked setup-job-workspace-action run on Windows as same as macOS.

Summary
Added 2 changes, one for action behavior change and other for actions-test workflow change to support Windows.
Action change (symlink)

WHAT: Current action missing support for Windows, due to symlink behavior on Windows. Because fs.promises.symlink default on Windows is NOT directory symlink and action create invalid symlink.
HOW: Specifying fs.promises.symlink type dir which explicitly notify Windows create dir symlink. As document said, symlinkOption is ignore on non-Windows environment, this effect nothing to other OS.
TEST: Added check file in Symlink test to probe behavior on Linux, macOS and Windows.

actions-test workflow change (node.js current directory)

WHAT: GitHub Workflow actions-test failed on windows-latest runner with mv, due to Node.js process's working directory locks FileIO on Windows. mv failed with process lock is Windows NTFS file system restriction. It means specifying working-directry paramter is required to Windows, but optional to Linux and macOS.
HOW: Added working-directory input parameter to action.yml. This indicate nodejs to process.chdir and avoid file lock issue on Windows. working-directory automatically set .. on Windows, and '' for other by default.
TEST: Added working-dirdtory test to probe behavior on Linux, macOS and Windows.

Should we set Default value of working-directory?
I think YES. Because of specifying working-directory belongs to internal affairs, we can set .. for Windows, and '' to macOS and Linux by default. This keep same api for all platform and free user from consider platform difference.
See detail for following behavior difference.
Linux. Nothing change to working-directory and no cd.

macOS. Nothing change to working-directory and no cd.

Windows. Automatically set .. to working-directory, and cd exists.

Result
Action change
before: Symlink "testRepo", which target test-testjob, is invalid on Windows. Also added test failed on Windows.

after: Symlink "testRepo", which target test-testjob, is valid on Windows. Added test success on Windows.

actions-test workflow change
before: uses: ./ failed due to node.js process locks checkout repository and prevent from mv. Existing actions-test failed on windows-latest.

https://github.com/guitarrapc/setup-job-workspace-action/actions/runs/5404846427/jobs/9819587074

after: uses: ./ successfully complete and all test passes by specifying with.working-directory: '..'. Existing actions-test success on windows-latest without change.

@srz-zumix I can't merge it and blocked merge button with this message.

You’re not authorized to merge this pull request.

Can you merge it? I want to release next version after merge this pull-request.

@srz-zumix I just trigger release workflow. Can you review it?
https://github.com/DeNA/setup-job-workspace-action/actions/runs/5456739109

@guitarrapc We released v2.1.0 🎉
Thanks for your contribution!

@Kesin11 Thank you!


Pull heurist.ai models in dynamically

Use the following link to get the models dynamically:
https://github.com/heurist-network/heurist-models/blob/main/models.json

This can easyly be added here => https://github.com/yeagerai/genlayer-simulator/blob/76-integrate-heuristai/consensus/nodes/create_nodes.py#L92


chore: Bump the VERSION to 2.7.0

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.50%. Comparing base (13484d0) to head (b20fefc).
Report is 58 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
- Coverage   36.81%   36.50%   -0.31%
==========================================
  Files         158      159       +1
  Lines        2548     2586      +38
  Branches      599      601       +2
==========================================
+ Hits          938      944       +6
- Misses       1428     1627     +199
+ Partials      182       15     -167

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: OCI store resolve returns full descriptor

Based on discussion on https://github.com/oras-project/oras-go/issues/457, this PR returns a full descriptor on Resolve when the method it's called by tag and it returns a plain descriptor when the method it's called by digest.

Hi @oanatmaria , thanks for the contribution! Do you want to update the same for ReadOnlyStore as well?

Hi @Wwwsylvia,
Thank you for the review. I've made the change for the readonlystore as well.

Also wondering if we should call out the behavior difference between resolving by tag and resolving by digest in the doc comment of the Resolve() function? @oanatmaria What do you think?

I've updated the comments. Please let me know if they are correctly formulated.


Broken links in docs

Sphinx cross-references don't work as expected on ReadTheDocs. If I create a label in one file,
.. _custom_label:

I should be able to link to it in any file via
:ref:`custom_label`

This works locally, but on RTD-hosted pages, it sends me to the top of the correct page; the anchor itself does not seem to exist.

This actually seems to be working -- perhaps a temporary issue with RTD.


proposal: workable solution to reflect incompatibility between gc and gccgo

Current Situation

gc: unexported embedded structs are settable
gccgo: unexported embedded structs are not settable

Both are not correct w.r.t. the way Go works: an unexported embedded struct should not be settable as a whole, however, exported fields and methods of unexported embedded structs may be promoted and be visible.
Goal

Make gc and gccgo compatible again with a workable solution.
address issues 7363 and 11007.

Solution
Make unexported embedded structs unsettable, but allow the reflect library to access exported fields and methods of such structs. Such fields could also be modified.
Rationale: this prevents blanket changes to values in structs that are generally not settable, while allowing access to fields that might be promoted.
The approach might still allow access to fields that are not accessible in the language, namely exported fields and methods that are not promoted because they are masked by or conflict with fields or methods of the same name.  However, access to such fields is also necessary.  Packages like encoding/xml and encoding/json allow users to map fields to alternative names using tags effectively breaking ties and making fields visible again.  Disallowing access to blocked fields now would be too much of a disruptive change and break the Go 1 compatibility promise.
Impact
This will break packages like xml and json, but only minimally. The typical check for whether a field is exported, f.PkgPath != "", would have to be amended to f.PkgPath != "" && !f.Anonymous.
Alternatives
adopt gccgo behavior
Unacceptable: it would be too disruptive to packages like xml and json and would break documented behavior, breaking the Go 1 compatibility promise. It would mean reflect cannot give access to fields that are visible in Go itself.
adopt gc behavior
Less problematic, but it would make it very easy to access structs that are indicated as hidden. Users could bypass initialization code etc, raising various security issues. The proposed solution does not eliminate this, but it does considerably mitigate it by limiting access to fields that are deemed exported and settable if the embedded type were accessed directly.
package reflect provides a different API for accessing promoted fields and methods.

This will be a huge change while still not addressing what to do with the remaining old API and its incompatibility.
It would not be possible for xml and json to implement their documented behavior.

Provide a higher-level API for packages like xml and json for mapping structured data to struct fields
This would potentially give greater consistency and would make it easier for developers to write package like json and xml.  However, it would be a huge change and similarly does not address the concerns of what to do with the current API. Like the current proposal, it would still allow access to non-promoted fields and methods.  It could be implemented on top of the proposed solution.

I think the statement here can be made much more precise. Here is my understanding.
Today, given:
type T1 struct {
	t2
}

type t2 struct {
	X int
	u int
}

var t1 T1
v1 := reflect.ValueOf(&t1).Elem()
v2 := v1.Field(0)
X := v2.Field(0)
u := v2.Field(1)

In the gc toolchain,
v1.CanSet() == true
v1.Type().Field(0).PkgPath == nil // nil usually indicates exported name
v2.CanSet() == true // usually unexported cannot be set
X.CanSet() == true
u.CanSet() == false

In the gccgo toolchain,
v1.CanSet() == true
v1.Type().Field(0).PkgPath != nil // unexported name "t2"
v2.CanSet() == false
X.CanSet() == false // uses of encoding/json and encoding/xml expect true here
u.CanSet() == false

The fundamental problem here is that a Go program's source code can refer to t1.X (implicitly t1.t2.X) directly, while the reflect API cannot. The reflect API requires stepping into each field explicitly. The gc implementation allows reflection to set t1.X by recording the field t2 as exported (wrong): that makes it possible to set t1.t2.X (arguably right) but also all of t1.t2 (wrong). The gccgo implementation records t2 as unexported (right), which disallows setting t1.t2.X (arguably wrong) and also disallows setting t1.t2 (right).
The proposal is that both implementations record t2 as unexported, and then change reflect to record whether a value like v2 is read-only only because it is an unexported embedded field. In that case, accessing an exported element within would clear the read-only bit. The effect would be that t2 is record as unexported (right), t1.t2.X is settable (arguably right), t1.t2 is not settable (right), and of course t1.t2.u is also not settable (right).

Both encoding/json and encoding/xml assume today that if f.PkgPath != nil then the field is unexported and must be ignored. That test needs to be revised to f.PkgPath != nil && !f.Anonymous, so that they do try to walk into the embedded fields to look for unexported fields contained within. Any similar external packages would need the same ~1 line change. The new condition is correct both before and after the proposed change, so it could be made by any affected packages independent of the eventual Go 1.6 release.

Thanks for the much clearer reformulation Russ.

Preparations for json and xml package:
https://go-review.googlesource.com/#/c/14011/
https://go-review.googlesource.com/#/c/14012/
See the actual change:
https://go-review.googlesource.com/#/c/14010/
Note that the tests added in the json and xml CLs will currently break for gccgo.
Packages just checking for f.PkgPath to determine if a field is exported should implement a fix similar to those in 14011 and 14012 now to prevent breaking when CL 14010 is checked in.

See fixes for xml and json:
https://go-review.googlesource.com/#/c/14011
https://go-review.googlesource.com/#/c/14012
Proposed reflect change:
https://go-review.googlesource.com/#/c/14010
Checking in 14011 and 14012 now would break the tests for xml and json for gccgo. This could be avoided by breaking up 14010 in two pieces.

Code that assumes
f.PkgPath != nil

means a field is unexported and must be ignored must now be revised to check for
f.PkgPath != nil && !f.Anonymous

for it to walk into the embedded structs to look for exported fields contained within.


Add markdown icon

Alternatives:

I think this is find, although if we were to make it a bit larger, to me, this would seem most logical:

(w/ the M and the arrow both being 8 by 8 pixels)

Opinions on the boxed version? (more like the actual Markdown icon)

Opinions on the boxed version? (more like the actual Markdown icon)

Yeah I can see where that's coming from, but I think it's just way too dense, especially the M, on 100% is looks more like an H.

(w/ the M and the arrow both being 8 by 8 pixels)

@karsa-mistmere pushed that version…

I think markdown needs the box to be identifiable, and the box version looks too cramped.
:-1: for adding a markdown icon.

I think markdown needs the box to be identifiable

Added a few alternatives above…
Although to be honest I think the boxed version is ok, and obviously recognisable as what it is. Sure, ideally we’d have more space but…

I think this icon makes a lot of sense. Personally I think the M and arrow is recognisable enough on its own to not need the box, and the version with top and bottom lines helps without cramping it.
I also don't think markdown could be considered a brand icon like #94 is about, since markdown is less one homogonus thing and more a group of simillar markup languages. Just off the top of my head there is CommonMark, MarkdownExtra, Misskey Markdown, Github Flavoured Markdown, and I know there are many more. Unless being technechal like this, they are all just "markdown" and people don't bother to distingush.


Hook execution times are not reflected in the test duration total

I am running cucumber 4.2.3 using failsafe plugin 3.0.0-M3 with 2 runners in parallel using junit 4.12.
            <parallel>classesAndMethods</parallel>
	    <threadCount>4</threadCount>

There is nothing much in the scenario steps except for print statements. I have a before hook which takes a scenario object. Also there is a beforestep hook which has a thread sleep of 2secs.
In the Scenario Summary page the total duration does not include the beforestep execution times.

This is also not included in the individual Summary page.

Though the hook duration times are displayed for each hook and steps in the detailed table.

I am using this configuration setting for the plugin
<configuration>
     <sourceJsonReportDirectory>
               ${project.build.directory}/json-cucumber-reports
    </sourceJsonReportDirectory>
    <generatedHtmlReportDirectory>
              ${project.build.directory}/generated-report
    </generatedHtmlReportDirectory>
    <expandBeforeAfterHooks>true</expandBeforeAfterHooks>
    <expandStepHooks>true</expandStepHooks>
</configuration>

I am getting the same result when i switch to a single runner too or change parallel setting to 'methods'.
Is there some setting or I am missing something? Thanks

Hello @grasshopper7 ,
thanks a lot for reporting this. This is indeed a bug - I will fix this one for the next release.

@laxersaz U r welcome. If this has any relevance, I am running this on Windows 8.

Fixed in 1.7.2

@grasshopper7 this was just released. It should be available on Maven central soon.

The total duration summary is adding up the times for hook execution. But the steps duration are also adding up the hook times.
Refer to screen of Scenario Details in 1.7.1

Refer to screen of Scenario Details in 1.7.2

Ah I see. What you say is true because in Cucumber, the step hooks have their own time. I just wanted to make it visible that the step (including its hooks) took a specific time.
But yeah, technically the step itself took 0ms and only its hooks took time.
Thanks for mentioning this - I will change that for the next iteration.

Hello @grasshopper7 ,
the fix will be released on Monday.

Release done, should be on Central soon :-)


Is Addressable not supportted?

Addressable Package is not able to function at all.

https://github.com/wechat-miniprogram/minigame-unity-webgl-transform/blob/main/Design/UsingAddressable.md


posColumn not wrapping long text to new line

The issue #83 says it is fixed but it is still not.
Any plans to update in the near future or a way how to fix it?

I'm experiencing same problem man.
When string becomes too long, it just gets truncated, without going on next row properly.
I think on earlier version was fine (based on 0.4.6 of esc_pos_utils)

this will fix?

I am experiencing the same. It cuts out the overflow text

anyone has a fix for this ?

Has someone fixed this?


use minikube action

see #119
and https://issues.apache.org/jira/browse/INFRA-26179

My view that users can install minikube or kubernetes themselves. The docs on each of the samples describes how to run them.


fix: dates for 2081

Some of the dates were wrong for 2081.

Month
❌ Wrong Month Days
✅ Correct Month Days

Jestha
31
32

Ashar
32
31

Falgun
30
29

Chaitra
30
31

I have added some tests for additional code as well.

@RehmatFalcon Thanks for contributing!

@RehmatFalcon Published version 2.0.2

@RehmatFalcon Published version 2.0.2

Thank you @mesaugat


mock server is not receiving the full request anymore

Hi,
I use json-server to mock some authentication endpoint, with the following code:
var jsonServer = require('json-server');
var express = require('express');
var server = jsonServer.create();
var middlewares = jsonServer.defaults();
server.use(middlewares);

server.post('/rest/my/login-endpoint', function (req, res, next) {
    console.log('LOGIN');
    var data = "";
    req.on('data', function(chunk) {
        console.log("Received body data:");
        console.log(chunk.toString());
        data += chunk.toString();
    });
    req.on('end', function() {
        console.log('body:');
        console.log(data);

        // We assume the request is well formed
        var pairs = data.split('&');
        var username = pairs[0].split('=')[1];
        var password = pairs[1].split('=')[1];

        // check the user/pass
        var statusCode = 404;
        if (username == 'user' && password == 'pwd') {
            console.log('login successful');
            statusCode = 200;
        }
        res.status(statusCode);
        res.setHeader('content-type', 'application/json');
        res.write('MOCKED_SESSION_ID');
        res.end();
    });
});

server.use(express.static('public'));
server.listen(8080, function () {
    console.log('JSON Server is running');
});

On 0.8.14, the following curl command works:
curl --request POST --url http://localhost:8080/rest/my/login-endpoint --header 'content-type: application/x-www-form-urlencoded' --data 'username=dazdaz&password=pwd'
The log on json-server are:
node test/json-server-data/mock-scheduler-rest.js
JSON Server is running
LOGIN
Received body data:
username=dazdaz&password=pwd
body:
username=dazdaz&password=pwd
POST /rest/studio/login 404 7.344 ms - -
LOGIN
Received body data:
username=dazdaz&password=pwd
body:
username=dazdaz&password=pwd
POST /rest/studio/login 404 2.160 ms - -
^C

But it doesn't work anymore on 0.8.21, as the curl seems to hang indefinitely, and I have the following log on json-server:
node test/json-server-data/mock-scheduler-rest.js
JSON Server is running
LOGIN

I am using:

npm 3.10.8
nodejs 6.7.0
Archlinux

Hi @paraita,
Thanks for the detailed code :+1: . I tried with 0.8.20 and it works.
In 0.8.21, body-parser middleware was included in jsonServer.defaults() but it doesn't seem work well in some cases https://github.com/typicode/json-server/issues/363.
I've removed it in next branch but it's not yet ready to be published. Until then, I would suggest sticking to 0.8.20.

Thank you @typicode for your answer, I'll stick with 0.8.20 for now :)

Closing this issue as it's a duplicate of https://github.com/typicode/json-server/issues/363
Also I've published v0.9.0-beta.2 which should solve this issue.
You can install it using npm install json-server@next.
Let me know if you spot any issue :)

Thanks I've updated successfully to 0.9.0 and 9.4 :)


IoC appears to be failing for MetadataController

I have tried running the application straight from a pull as well as updating all dependencies and I am still met with a 500 error for /breeze/metadata.  Digging into it more it seems like IoC is causing the problem -- it is saying that MetadataController needs to have a paramaterless constructor.  I have been working with StructureMap recently and this is the exact error that I got when IoC was not configured correctly.
It seems like IoC is configured correctly, however -- perhaps I am missing something?  I tried adding in For<IUnitOfWork>().Use<UnitOfWork>(); but still am not having any luck.

Hi,
Sorry for the late, late, late answer but I have no time lately :(
I just cloned the repo and execute it with no problem.
Did you perhaps update the nuget packages ... ?? Because I did not change nothing in the last couple of months and perhaps some update is breaking the project ...

I am getting the same issue.
The template works fine on Local Server. I get error when I deploy it to Production. (Hostgator windows server)
$id: "1"
$type: "System.Web.Http.HttpError, System.Web.Http"
Message: "An error has occurred."

Hi,
I upgraded all nuget packages in the solution and updated as well the structuremap container to the most recent version. It implied some new code for the container so try again if you want and let me know
Bye!!

Thanks for reply but I already have fixed all the issues. Now it is working fine.

Were the issues related to the project?
If so, could you tell me how you solved to correct it in DurandalAuth?
Thanks!!


Update the Examples

Could anyone please update the example files. This could help a lot of new users.

Example not working anymore.Have you solved the issue?

Would you be so kind and provide us with an update please @ratson? Thanks


Add parallelized histogramming of pixel intensities

We often histogram pixel intensities when analyzing DECO data. While this is a simple task on its own, it can be time-consuming to histogram many images in serial. I think it would be useful to have a function that parallelizes this using dask. The function would just take a list of image files as input and return the corresponding histograms, e.g.:
def get_intensity_histograms(files, rgb_sum=False, cumulative=False, n_jobs=1):
    ...

We'd have parameters to determine the rgb conversion, cumulative vs differential distribution, and number of processes for parallelization.
@jrbourbeau What do you think? And any other parameters or features that would be useful?

This sounds like a good addition to me! Organizationally, it might be worth adding a new module, perhaps named decotools.metrics, and putting the current blob_extraction.get_intensity_metrics and the new get_intensity_histograms in there.

Great. Yeah, I think that's a good way to organize it too.

Fixed in #53


Feature/noexcept

Switched to use _MSC_VER . Not providing users the capability to change XSIMD_INLINE behavior as of now, I'm not convinced by this use case.

@serge-sans-paille, there's a performance drop between 8.0.3 (+ an application of s/inline /__forceinline) and this PR. I think you may have overinlined functions; so far I know that f9d3b5dbea6f6995af64b5e3232f5d9071f0cbcf introduces this drop, and the application of inlining to the friend batch functions does the rest.
I will let you know when/if I am able to find the exact set of offenders.

Let's move the inline discussion to #646 and keep that PR for noexcept then. I think there's a consensus on noexcept doesn't hurt.


Use html2pdf__page-break only if necessary

First of all thanks for this plugin.
How can I add a break (html2pdf__page-break for example) only if an element is cut ? The size of my document is variable. Exemple :

A little reminder on this subject

If anyone has an idea to solve this problem, I welcome it.

One way to solve this is to use section

    <OrderDiscount />

    <OrderConditionPrice />

.pdf-item {
  page-break-inside: avoid;
}

You can also find options in : https://ekoopmans.github.io/html2pdf.js/#page-breaks


[WIP] PR: Print frames deadlock

Description of Changes
This allows printing the current frames even in case of a deadlock.
For example, run:
from qtpy.QtCore import QMutex
lock = QMutex()
lock.lock()
lock.lock()

This creates a deadlock in c code. Pressing ctrl + c won't help you. This can give helpful insight to debug the issue.

[x] Wrote at least one-line docstrings (for any new functions)
[x] Added unit test(s) covering the changes (if testable)
[x] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

(kind of) Fixes #1613
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: impact27

this helps mitigate https://github.com/ipython/ipykernel/issues/449

I have added [WIP] because this needs a way of filtering out spyder code from the frames.

I am not sure this is going to be for Spyder 4. I think we should keep this for spyder 5

replaced by  #11186


chore: added js method question

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Added question for a simple JS method that's frequently used when dealing with user input fields.

Congrats on your first contribution to the Developer Quiz Site.


nat64 setup script broken on Raspberry Pi OS

The automatic setup of tayga did not work for me.
The tayga initscript that comes with the current tayga package (Version: 0.9.2-8) looks like this:
$ cat /etc/default/tayga
# Defaults for tayga initscript
# sourced by /etc/init.d/tayga
# installed at /etc/default/tayga by the maintainer scripts

# Configure interface and set the routes up
CONFIGURE_IFACE="yes"

# Configure NAT44 for the private IPv4 range
CONFIGURE_NAT44="yes"

# Additional options that are passed to the Daemon.
DAEMON_OPTS=""

# IPv4 address to assign to the NAT64 tunnel device
IPV4_TUN_ADDR=""

# IPv6 address to assign to the NAT64 tunnel device
IPV6_TUN_ADDR=""

Which means at least script/_nat64#L50 has no effect. I did not check the other lines.

Resolved by #782


Fix SSL

The application did not work on HTTPS because some embedded assets were
included by hard-coded HTTP URLs. Nowadays HTTPS should be the default.
This fixes #205.

To give an example for testing:

http://timemapper.okfnlabs.org/libpirate/timeline-uni-goettingen  works
https://timemapper.okfnlabs.org/libpirate/timeline-uni-goettingen does not work


Exception when making a threaded choice after loading StoryState JSON

It seems that the StoryState object may not always be properly converted to/from JSON -- particularly when involving threaded choices.
To reproduce the exception:

Define some choice points within a thread. (see Example below)

Convert the StoryState to JSON then load the JSON back into the StoryState.

Select a threaded choice via chooseChoiceIndex(), then continueMaximally().

Example:
Here is an example of a threaded choice:
// 'inkfiles/threads/thread-bug.ink'

-> start

=== start ===
Here is some gold. Do you want it?
- (top)
    <- choices(-> top)
    + Yes
        You win!
        -> END

=== choices(-> goback) ===
+ No
    Try again!
    -> goback

Here is blade-ink code that throws an exception, using the above ink file:
String json = TestUtils.getJsonString("inkfiles/threads/thread-bug.ink.json");
Story story = new Story(json);

System.out.println(story.continueMaximally());

// Convert state to JSON then load it back in
String stateJson = story.getState().toJson();
story.getState().loadJson(stateJson);

// + Works correctly if choiceIdx is 1 ('Yes', defined in the knot)
// + Throws exception if choiceIdx is 0 ('No', defined in the thread)
story.chooseChoiceIndex(0);
System.out.println(story.continueMaximally());

This code yields the following exception:
java.lang.Exception: RUNTIME ERROR: Variable 'goback' could not be found in context '-1'. This shouldn't be possible so is a bug in the ink engine. Please try to construct a minimal story that reproduces the problem and report to inkle, thank you!

	at com.bladecoder.ink.runtime.VariablesState.getRawVariableWithName(VariablesState.java:157)
	at com.bladecoder.ink.runtime.VariablesState.getVariableWithName(VariablesState.java:168)
	at com.bladecoder.ink.runtime.VariablesState.getVariableWithName(VariablesState.java:164)
	at com.bladecoder.ink.runtime.Story.performLogicAndFlowControl(Story.java:1086)
	at com.bladecoder.ink.runtime.Story.step(Story.java:1708)
	at com.bladecoder.ink.runtime.Story.continueInternal(Story.java:463)
	at com.bladecoder.ink.runtime.Story.Continue(Story.java:425)
	at com.bladecoder.ink.runtime.Story.continueMaximally(Story.java:598)
	at com.bladecoder.ink.runtime.test.ThreadSpecTest.testThreadBug(ThreadSpecTest.java:31)

This error is also reproduced in the reference Inkle C# engine. I reported the bug there.
https://github.com/inkle/ink/issues/267
I will apply their solution in the Java version when it is fixed in the C# engine.
Cheers!

Fixed!

Thanks again -- I really appreciate the fast turnaround and submitting it to Ink.
Cheers!


'@' character input prevented

When attempting to enter an email address into an Input, the '@' character is prevented from being entered.  That character gets cleared after being typed.

I'd like to contribute to this if it's still available :)

I'd like to contribute


pkg/wasm: add Docker/OCI image fetcher.

This PR adds the fetcher implementation of Wasm Image Specification which Wasm-SIG has worked on, and this is intended to be used in the implementation of the new Wasm Plugin API.
This is the sequel to httpfetcher (https://github.com/istio/istio/pull/29991), and the rework of the previous PR https://github.com/istio/istio/pull/32163.
Signed-off-by: Takeshi Yoneda<EMAIL_ADDRESS>cc @bianpengyuan @dgn @mandarjog

Hi @mathetake. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@mathetake: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mathetake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test release-notes_istio

gencheck_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mathetake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test release-notes_istio

gencheck_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test gencheck_istio

lint_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mathetake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test release-notes_istio

gencheck_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test gencheck_istio

lint_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test lint_istio

unit-tests_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mathetake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test gencheck_istio

lint_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test lint_istio

unit-tests_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test unit-tests_istio

release-notes_istio
bc049c69709022b290e67775a28f74e43378ce7f
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mathetake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
8a22f609fb906ca6cf822399ae4042e0b14a2ad4
link
/test unit-tests_istio

release-notes_istio
bc049c69709022b290e67775a28f74e43378ce7f
link
/test release-notes_istio

lint_istio
bc049c69709022b290e67775a28f74e43378ce7f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

OK test passes besides I have no idea about what I can do for this,

ERROR: Some modules have unrecognized licenses:
github.com/opencontainers/runc: path<EMAIL_ADDRESS>

OK test passes besides I have no idea about what I can do for this,

ERROR: Some modules have unrecognized licenses:
github.com/opencontainers/runc: path<EMAIL_ADDRESS>

Basically we are adding a new dependency on runc implicitly. Somehow our tool fails to detect https://github.com/opencontainers/runc/blob/v0.1.1/Godeps/_workspace/src/github.com/golang/protobuf/LICENSE is a BSD license.
Interestingly, through a chain of old dependencies, we end up importing runc for 4 years ago...
In the short term, we can add an exception in https://github.com/istio/common-files/blob/master/files/common/config/license-lint.yml

https://github.com/helm/helm/pull/9675/files may help but I don't think it will

@mathetake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
bc049c69709022b290e67775a28f74e43378ce7f
link
/test lint_istio

release-notes_istio
6f06e3286efe3f2ad0be5114764b2d4cd3f2ba3d
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks, I added the exception in license-lint.yaml for now

The file is synced from istio/common-files, can you send a PR to add it
there as well? otherwise it will get reverted when the next sync occurs.
Thanks!
On Fri, Jul 9, 2021 at 8:02 PM Takeshi Yoneda @.***>
wrote:

Thanks, I added the exception in license-lint.yaml for now
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/33812#issuecomment-877546178, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJQZEPKEXIKC5JSWRLTW6Z4FANCNFSM47XVVQNA
.

just created the PR https://github.com/istio/common-files/pull/445, Thanks!

@mathetake: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
f8fc3d85c647f44deba32cd1c823d322160d9d6e
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mathetake: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
8d854173484b6e39d3cd9cfdc5df8b8aeaaa05d5
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@mandarjog good to go?

@mathetake: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8d854173484b6e39d3cd9cfdc5df8b8aeaaa05d5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@mathetake: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8d854173484b6e39d3cd9cfdc5df8b8aeaaa05d5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@mathetake: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8d854173484b6e39d3cd9cfdc5df8b8aeaaa05d5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@mathetake: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8d854173484b6e39d3cd9cfdc5df8b8aeaaa05d5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@mathetake: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8d854173484b6e39d3cd9cfdc5df8b8aeaaa05d5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@mathetake: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8d854173484b6e39d3cd9cfdc5df8b8aeaaa05d5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

😕

@brian-avery any idea about how to fix release notes check failure?

/retest

/cherry-pick release-1.11

@dgn: #33812 failed to apply on top of branch "release-1.11":
Applying: wasm: add Docker/OCI image fetcher.
Applying: Add comments, add test, better error feedback.
Applying: review: make gen, fix typos and test case
Applying: Add runc in allowlisted in license-lint.yaml
Using index info to reconstruct a base tree...
M	common/config/license-lint.yml
Falling back to patching base and 3-way merge...
Auto-merging common/config/license-lint.yml
CONFLICT (content): Merge conflict in common/config/license-lint.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 Add runc in allowlisted in license-lint.yaml
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgn: new issue created for failed cherrypick: #34440

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


c'e

Trying to run some of the examples on microbit using a layout file from before the stack_size change. Tried increasing the stack in the microbit main file, but that does not seem it. Potentially relevant: grant_size = alloc_size on App Status from the process_standard message. Still working with c examples (using openocd for both).

Which kernel version and libtock-rs version are you using? I'm trying to rule out a Tock 1.0 vs. 2.0 issue.

Thanks for the quick response -- still using 1.0 and libtock-rs (0.2.0)

Tock release 1.6 (the last 1.x release) does not have Microbit support, as far as I can tell. What commit are you using for the Tock kernel?

8b8c54aeec62322a9366e3f87a772775da5770a9 (1.6).

In case unclear, working fine with libtock-c, and, worked fine with libtock-rs pre stack_size change.

8b8c54aeec62322a9366e3f87a772775da5770a9 (1.6).

I don't see a commit with that ID: https://github.com/tock/tock/commit/8b8c54aeec62322a9366e3f87a772775da5770a9.

Oops 0c8c7127a0e820966a5336c79d961846765bd926 apologies

Oops 0c8c7127a0e820966a5336c79d961846765bd926 apologies

That is a Tock 2.0 kernel. The version numbers in the repository have not been updated, which I realize may be misleading.
The master branch changed from Tock 1.0 to Tock 2.0 when https://github.com/tock/tock/pull/2446 was merged. You'll need to use a kernel version from before that. It appears the Microbit was added a couple months before that was merged, so you may be able to find a working version.

oh okay yeah the logs from process_standard said 1.6 so that is why. so microbit is not supported for 2.0? Then why does it work with libtock-c same version?

so microbit is not supported for 2.0?

It looks like it will be supported in Tock 2.0, when Tock 2.0 is released.
I don't know much about libtock-c, as I have barely worked with it. I'll let someone else answer there.

Okay, thanks! Out of curiosity are the non-FPGA boards that do already work with libtock2?

Okay, thanks! Out of curiosity are there non-FPGA boards that do already work with libtock2?

As far as I am aware, libtock2 has only been tested on HiFive1 rev b in QEMU, not on any physical boards. However, it should theoretically work on any board. The issue is not brokenness, but limited functionality (the only system call that has been implemented is Command, and no drivers have been implemented).

Assuming some basic allow/subscribe, do you have any suggestions for writing user land drivers? Thinking about porting some of the ones that are in libtock-c for example

Do you mean for the Tock 2.0 libtock-rs? No, I'm still trying to get the basic framework in place. I'm planning to write a document on how to write a libtock-rs driver once everything is in place.

libtock-c has already moved to target the 2.0-alpha interface, which is why the examples there work against the 2.0-alpha kernel commit that you were using. Apologies for the version confusion, hopefully that should be resolved soon once the official 2.0 release happens. It will still be a little while after that before libtock-rs is updated to be usable with Tock 2.0

Do you mean for the Tock 2.0 libtock-rs

Yes.

I'm planning to write a document on how to write a libtock-rs driver once everything is in place.

Awesome.

Apologies for the version confusion, hopefully that should be resolved soon once the official 2.0 release happens

No worries. Thanks to both of you for responding quickly!


fix version in README

:sunglasses:

Current coverage is 89.83%

Merging #9 into master will not affect coverage as of 510d6a4

@@            master      #9   diff @@
======================================
  Files            6       6
  Stmts          236     236
  Branches        35      35
  Methods          0       0
======================================
  Hit            212     212
  Partial         18      18
  Missed           6       6

Review entire Coverage Diff as of 510d6a4

Powered by Codecov. Updated on successful CI builds.

OK

:+1:


No sort buttons on channels

See this image:

I would like to be able to sort by popular and stuff if at all possible.

Just disable "Hide taps"

That does nothing for me.

Can you


[Redux] Change header background/title color based on the store

Current Behavior
Currently, the static navigatorOptions' headerRight prop allows you to pass a React.Component that you can wrap with connect, so you get access to the redux store.
But headerStyle/headerTitleStyle can't be modified dynamically, since in navigatorOptions you don't have access to the redux store nor you can reference the underlying (Header/HeaderTitle) component to wrap it around connect (nor you would want to access it this way I guess).
Expected Behavior
I'm looking for a way to style the header (background color, title color) dynamically based on redux store state.

Use case:
A theme based app where the user chooses a dark/light, so the header needs to change dynamically.

Any suggestions on how to do this ?
Your Environment

software
version

react-navigation
1.0.0-beta.9

react-native
0.44.0

node
6.9.1

npm or yarn
0.24.5

Wrap the component that is setting the navigationOptions with connect, then set your navigationOptions to be a function that returns the nav options like so:

class MyComponent extends React.Component {
  static navigationOptions = ({ navigation, screenProps }) => ({
    title: 'My screen',
    headerTintColor: screenProps.storeKey.value,
  });

  render() {
    return <View><Text>Hello world</Text></View>
  }
}

export default connect(mapStateToProps, mapDispatchToProps)(MyComponent);

Thanks for the reply @matthamil !
So you mean that
const mapStateToProps = state => ({
  screenProps: state,
})

would work ?

The screenProps param in navigationOptions is a reference to the props of the component itself.
If your mapStateToProps looked like this:
const mapStateToProps = state => ({ title: state.title });
your navigationOptions would look like this:
static navigationOptions = ({ screenProps }) => ({
  title: screenProps.title
});

As an alternative; I've been using the following pattern of letting redux manage all state.
For instance, to configure the HeaderBackButton:
import { connect } from 'react-redux';
import { HeaderBackButton } from 'react-navigation';

const mapStateToProps = function (state) {
  return {
    // Props you care about
  };
};

export default connect(mapStateToProps, mapDispatchToProps)(HeaderBackButton);

And passing your new redux-aware component via:
import NewBackButton from '...';

const NavigationStack = StackNavigator({
  Foo: {
    screen: FooScreen,
    navigationOptions: {
      title: 'Example',
      headerLeft: <NewBackButton />,
    }
  },

The screenProps param in navigationOptions is a reference to the props of the component itself (like you are accessing this.props).
If your mapStateToProps looked like this:
const mapStateToProps = state => ({ title: state.title });
your navigationOptions would look like this:
static navigationOptions = ({ screenProps }) => ({
title: screenProps.title
});

I double checked this, but couldn't get it to work.
Do you have a working example ?

@jbrodriguez can you post your full code?

As an alternative; I've been using the following pattern of letting redux manage all state.

Yes, that works. But it doesn't if you want to use store state to style header components that can't be wrapped by connect.

@jbrodriguez can you post your full code?

Sure, I'll clean up and post it

Here it goes
https://github.com/jbrodriguez/NavTest
The issue is that the console.logs come up empty
screenProps-{}
screenProps.theme-undefined

Hi @matthamil I think you are wrong. screenProps is not a reference to props like this.props. It is a reference to screenProps defined in StackNavigator. I have the same problem like @jbrodriguez, I need to set the title from redux and I don't know how. Any body know how can I access to screen props??

The pattern without redux would be something like this:
const MyNav = StackNavigator({
  // ...
}, {
  navigationOptions: ({ screenProps }) => ({
    headerStyle: screenProps.headerStyle,
  }),
});

<MyNav screenProps={{ headerStyle: { backgroundColor: '#f00' }}} />

So to use it with redux you wrap MyNav with connect and map your state to a screenProps property.
Other solution would be wrapping the Header component itself with connect:
import { Header } from 'react-navigation';

const ConnectedHeader = connect(mapStateToProps)(Header);

const MyNav = StackNavigator({
  // ...
}, {
  navigationOptions: ({ screenProps }) => ({
    header: ConnectedHeader,
  }),
});

Apologies for that. Should have tested locally before answering ;)

Or you can implement like this https://github.com/react-community/react-navigation/issues/1575#issuecomment-302755881

I think the solutions you mentioned with redux rerender all screens unnecessarily, I'm right?

@dabit1 That what i did to implement theming feature and multi language. Could you tell me another way?

Or you can implement like this #1575 (comment)

Thank you @ttdat89 ! That worked 👍

@koenpunt I also tried your solution and it almost worked with beta10, which now accepts a style prop (https://github.com/react-community/react-navigation/commit/ff99d6ec0a2d7a62adfd8d1e6a3c906fcedf294a), but I still can't set other header properties (headerTintColor for example).
The benefit of this solution is that it allows a common Header across screens, yet some elements can be overridden at screen level (headerRight, headerLeft, etc).
I tried the following, but screenProps isn't seen by the wrapped Header component.
import React from 'react'
import PropTypes from 'prop-types'

import { connect } from 'react-redux'
import { Header } from 'react-navigation'

const NavBar = props => {
	console.log(`props.theme-(${props.theme})`)
        // props.theme is correctly populated so i can set backgroundColor based on theme
        // yellow is just a test
        // headerTintColor though is not accessible within Header
	return <Header {...props} style={{ backgroundColor: 'yellow' }} screenProps={{ headerTintColor: 'red' }} />
}
NavBar.propTypes = {
	theme: PropTypes.string.isRequired,
}

const mapStateToProps = state => ({
	theme: state.settings.theme,
})

export default connect(mapStateToProps)(NavBar)

Maybe make <Header /> accept a navOptions prop (same structure as navigationOptions), that can be merged with navigationOptions ?
  _renderTitleComponent = (props: SceneProps) => {
-    const details = this.props.getScreenDetails(props.scene);
+   const details = Object.assign({}, this.props.navOptions, this.props.getScreenDetails(props.scene).options);

    const headerTitle = details.options.headerTitle;
...

Any suggestions ?

You can just intercept the getScreenDetails in your own header component:
import { Header } from 'react-navigation';

const mapStateToProps = (state, ownProps) => ({
  getScreenDetails: (scene) => {
    const details = ownProps.getScreenDetails(scene);
    return {
      ...details,
      options: {
        headerTitleStyle: { color: '#f00' },
        ...details.options,
      }
  },
});

const ConnectedHeader = connect(mapStateToProps)(Header);

const MyNav = StackNavigator({
  // ...
}, {
  navigationOptions: ({ screenProps }) => ({
    header: (props) => <ConnectedHeader {...props} />,
  }),
});

Thanks @koenpunt, this works beautifully !
This helps simplify the custom header so that it doesn't need the style prop passed in.
import React from 'react'

import { connect } from 'react-redux'
import { Header } from 'react-navigation'

const NavBar = props => <Header {...props} />

const mapStateToProps = (state, ownProps) => ({
  getScreenDetails: (scene) => {
    const details = ownProps.getScreenDetails(scene);
    return {
      ...details,
      options: {
        headerStyle: { backgroundColor: 'yellow' },
        headerTitleStyle: { color: '#f00' },
        ...details.options,
      }
  },
});

export default connect(mapStateToProps)(NavBar)

Im try solution but it not working in version 3.11.1 :(


[SPARK-47418][SQL] Add hand-crafted implementations for lowercase unicode-aware contains, startsWith and endsWith and optimize UTF8_BINARY_LCASE

What changes were proposed in this pull request?
Added hand-crafted implementations of unicode-aware lower-case contains, startsWith, endsWith to optimize UTF8_BINARY_LCASE for ASCII-only strings.
Why are the changes needed?
UTF8String.toLowerCase(), which is used for the aforementioned collation-aware functions, has an optimization for full-ascii strings, but still always allocates a new object. In this PR I introduced loop-based implementations, which fall-back to toLowerCase() in case they meet a non-asci character.
Does this PR introduce any user-facing change?
No, these functions should behave exactly as:

lhs.containsInLowerCase(rhs) == lhs.toLowerCase().contains(rhs.toLowerCase())
lhs.startsWithInLowerCase(rhs) == lhs.toLowerCase().startsWith(rhs.toLowerCase())
lhs.endsWithInLowerCase(rhs) == lhs.toLowerCase().endsWith(rhs.toLowerCase())

How was this patch tested?
Added new test cases to org.apache.spark.unsafe.types.CollationSupportSuite and org.apache.spark.unsafe.types.UTF8StringSuite, including several unicode lowercase specific. Also I've run CollationBenchmark on GHA for JDK 17 and JDK 21 and have updated the data.
Was this patch authored or co-authored using generative AI tooling?
No

Re-running the benchmarks on GHA for the new implementation proposed by @cloud-fan here and after that I will merge the changes.


Extract Value from EnumMemberAttribute on EnumValue

I have an API Wrapper written in C# and I want to share the POCOs with a TypeScript implementation.
I have an enum where the values are deserialized from a JSON API. I have changed the names slightly in the C# enum to better match C# standards. This means I use EnumMember(Value = "xxx") to decorate each enum value.
I am using the following Typewriter definition
$Enums(PingMeSharp.Model.*)[
    export type $Name = $Values[$Attributes[$Value]][ | ];
	]

With the following enum definition
public enum Foos
    {
        [EnumMember(Value = "BAR")]
        Bar,

        [EnumMember(Value = "WIDGET")]
        Widget,

        [EnumMember(Value = "FOOBAR")]
        FoorBar
    }

The resulting typescript is
export type Foos = Value = "BAR" | Value = "WIDGET" | Value = "FOOBAR";

I am looking to get
export type Foos = "BAR" | "WIDGET" | "FOOBAR";

Am I just missing some syntax from the Typewriter definition?

Hi @thegreatco,
In Typewriter templates enum values are just strings so you'll have to define a method to extract the part of the value you're intrerested in e.g.
${
    string ExtractedValue(Attribute attribute)
    {
        var index = attribute.Value.IndexOf("=");
        return attribute.Value.Substring(index + 1).Trim();
    }
}
$Enums(PingMeSharp.Model.*)[
    export type $Name = $Values[$Attributes[$ExtractedValue]][ | ];
]


Markers events don't fire (and maybe more issues)

I'm submitting a ...  (check one with "x")
[ ] question
[X] any problem or bug report
[ ] feature request
If you choose 'problem or bug report', please select OS:  (check one with "x")
[X] Android
[X] iOS
cordova information:  (run $> cordova plugin list)
cordova-plugin-camera 3.0.0 "Camera"
cordova-plugin-device 1.1.4 "Device"
cordova-plugin-fcm 2.1.2 "FCMPlugin"
cordova-plugin-file 5.0.0 "File"
cordova-plugin-file-transfer 1.7.0 "File Transfer"
cordova-plugin-filepath 1.0.2 "FilePath"
cordova-plugin-googlemaps 2.0.11 "cordova-plugin-googlemaps"
cordova-plugin-inappbrowser 1.7.1 "InAppBrowser"
cordova-plugin-ionic-webview 1.1.16 "cordova-plugin-ionic-webview"
cordova-plugin-splashscreen 4.0.3 "Splashscreen"
cordova-plugin-statusbar 2.3.0 "StatusBar"
cordova-plugin-whitelist 1.3.1 "Whitelist"
cordova-sqlite-storage 2.0.4 "Cordova sqlite storage plugin"
ionic-plugin-keyboard 2.2.1 "Keyboard"
phonegap-plugin-push 2.1.0 "PushPlugin"

If you use @ionic-native/google-maps, please tell the package.json (only @ionic-native/core and @ionic-native/google-maps are fine mostly)
ionic-native/google-maps: "4.4.2"
ionic-native/core": "4.4.2",
Current behavior:
Events on Markers do not work (not sure if it is the only issue).
Expected behavior:
Now this should work.
I see the markers fine on the map, i can clic and i see the popup, but my events are never fired (even the console log).
And (maybe it is related or not) - an error on log (via chrome dev tools)
Related code, data or error log (please format your code or data):
Code is as follow
import {
  GoogleMaps,
  GoogleMap,
  GoogleMapsEvent,
  GoogleMapOptions,
  CameraPosition,
  MarkerOptions,
  Marker
 } from '@ionic-native/google-maps';

[...]

map: GoogleMap;
  mapElement: HTMLElement;
  notificationsCount: number;

[...]

loadMap() {
    this.mapElement = document.getElementById('map');

    let mapOptions: GoogleMapOptions = {
      camera: {
        target: {
          lat: 46.379933,
          lng: 2.8374617
        },
        zoom: 5
      }
    };

    this.map = new GoogleMap(this.mapElement, mapOptions);

    this.map.one(GoogleMapsEvent.MAP_READY)
    .then(() => {
      console.log('Map is ready!');
      this.api.getClubs().subscribe(response =>{
        response.forEach((club) => {
          let icon = "www/assets/imgs/map_club_icon3.png";
           if  (club.total_members_count < 12) {
              icon = "www/assets/imgs/map_club_icon2.png";

           }

           if  (club.total_members_count < 6) {
            icon = "www/assets/imgs/map_club_icon1.png";

          }

          this.map.addMarker({
            title: club.club_name,
            icon: {
              url: icon,
            size: {
              width: 20,
              height: 24
              }
            },
            animation: 'DROP',
            position: {
              lat: club.lat,
              lng: club.lng
            },

          },

        )
          .then( (marker) => {
            //console.log(marker);
            marker.on(GoogleMapsEvent.MARKER_CLICK)
              .subscribe(() => {
                console.log("CLICK");
                this.presentClubModal();
              });

             });

        });

      });

    });
}

And I have an error log as follow :
For every marker (even though they do show...)
polyfills.js:3 Uncaught TypeError: Cannot set property 'marker_196468382' of undefined
    at Map.<anonymous> (vendor.js:84436)
    at Map.<anonymous> (Map.js:1010)
    at googlemaps-cdv-plugin.js:726
    at t.invokeTask (polyfills.js:3)
    at r.runTask (polyfills.js:3)
    at e.invokeTask (polyfills.js:3)
    at i.isUsingGlobalCallback.invoke (polyfills.js:3)
    at n (polyfills.js:3)

I don't get why it happens, it is exactly following the demo.
Do you have any idea?

Since your code is wrong, the plugin does not work correctly.
Please share your project files on GitHub. I will check it later

I don't have the whole project on github (tens of pages,big app...)
Can i just give you the .ts file?
But if you know my code is wrong, what is wrong with it?

In order to reproduce your issue, I need whole code. You can create a private repository at bitbucket.org as free.

Can't share the whole code....
I will try to get you a sample app with just this page, see if it works.
Thanks

Alright!
I created a small demo, just with this part --> https://github.com/arimk/TestIonicMap
I removed my credentials from
<plugin name="cordova-plugin-googlemaps" spec="^2.1.1">
        <variable name="API_KEY_FOR_ANDROID" value="xxxx" />
        <variable name="API_KEY_FOR_IOS" value="xxx" />
   </plugin>

Now with this demo,i got the same issue and result
Uncaught TypeError: Cannot set property 'marker_250022885' of undefined
I hope it's just a mistake somewhere on my side,  I don't have any idea...

I confirmed the reason is you write
this.map = new GoogleMap(this.mapElement, mapOptions);

instead of
this.map = GoogleMaps.create('map', mapOptions);

Yes thank you! Great!


i want stb style（header only）API library

suppert c++，using template。suppert android and ios。

use like this：
#include <glfw.hpp>
//for windows os
glfw::window<GLFW_WINDOWS> window = glfw::create_window<GLFW_WINDOWS>(...);
//for android os
glfw::window<GLFW_ANDROID> window = glfw::create_window<GLFW_ANDROID>(...);
//create opengl context
glfw::opengl_context glc = glfw::create_opengl_context(window);
//audio for windows
glfw::audio_device<GLFW_WINDOWS> audio = glfw::create_audio_device<GLFW_WINDOWS>(...);
//audio for android
glfw::audio_device<GLFW_ANDROID> audio = glfw::create_audio_device<GLFW_WINDOWS>(...);
//play
audio.playsound("a.wav");
audio.playmp3("a.mp3");

Well it's open source, so go ahead :)
But I don't think that it is ever possible to provide glfw as a header only library.

@sdragonx GLFW is written in C, uses tons of platform-specific headers and does not provide audio support. You seem to want an entirely different project. Perhaps SFML would be a better fit?


I'm still getting the timeout issue. Is Nvidia's website still broke?

Get "https://api-prod.nvidia.com/direct-sales-shop/DR/products/en_us/USD/5438481700": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
I don't have the latest v3.7.9 release yet, because it doesn't open when I try to run it so I'm just using v3.7.7. Idk if that is the issue though.

No the version is not the issue, the api is still down. If you want to know without asking you can download and run this tool I made for this purpose at https://github.com/redstone2019/NVIDIA-API-Checker


xds: don't allow multiple instances of a locality in the same priority

Signed-off-by: Mark D. Roth<EMAIL_ADDRESS>Commit Message: xds: don't allow multiple instances of a locality in the same priority
Additional Description: This is a documentation-only change.  gRPC is a bit more restrictive here than Envoy is.  This changes the documented requirement to match gRPC's restriction but does not change Envoy's implementation, with the goal being to converge on the more restrictive behavior in the long term but not break anything in the short term.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A

/retest
If this does not resolve, @markdroth please merge main (even an empty commit should trigger a new build which will cause a CI run against the current main.)

/retest

@markdroth is there an issue tracking the convergence to the restrictive behavior?

No, there isn't, but feel free to create one.
The main thing I'm after here is defining the API semantics such that the same locality does not repeat in the same priority.  If Envoy's implementation is a bit more permissive than the API spec, that's not the end of the world.  I just don't want new people implementing their xDS servers in a way that doesn't work for gRPC clients.

No, there isn't, but feel free to create one.
The main thing I'm after here is defining the API semantics such that the same locality does not repeat in the same priority. If Envoy's implementation is a bit more permissive than the API spec, that's not the end of the world. I just don't want new people implementing their xDS servers in a way that doesn't work for gRPC clients.

Opened #20768 to track this.


Crash when update list with smaller size

If you try to update list that contains less elements than previous state - it cause crash. Because totalCount not updated
Example:

You have list with 10 elements
Not necessary. Add new element into list. Everything ok. List size = 11
Remove one element from list. List size = 10. App crash

Looks like we need to change setter of totalCount and add some logic for notifyItemRemoved()
Or another possible solution is to add diff_utils mechanic

Hi @RomanAnchugov
I attempted to remove items, and it worked without any issues on my end. To assist you further, I'll need to review the crash logs and the relevant portion of your code where the issue is occurring. If you can share a specific stack trace or error message, it would be helpful for a more accurate analysis.
Additionally, providing a code snippet that replicates the problem would greatly aid in understanding and addressing the issue.

Yes. Your right. It works in general and crashes in some specific cases, which i don't know.
I've modified your sample_app and attach some additional info about crash
Here is the modified code from sample_app. I just add button to remove 0-index element in list
val userDataList = remember {
                        List(20) { index ->
                            UserData(
                                "User ${index + 1}",
                                20 + index,
                                if (index % 2 == 0) "Male" else "Female"
                            )
                        }.toMutableStateList()
                    }

                    Column {
                        Button(
                            onClick = {
                                val indexToDelete = 0
                                Log.i("LOL", "index to delete: $indexToDelete")
                                userDataList.removeAt(
                                    indexToDelete
                                )
                            }
                        ) {
                            Text("delete 0")
                        }
                        ComposeRecyclerView(
                            modifier = Modifier.fillMaxSize(),
                            itemCount = userDataList.size,
                            itemBuilder = { index ->
                                CustomUserItem(user = userDataList[index])
                            },
                            onItemMove = { fromPosition, toPosition, itemType ->
                                // Update list when an item is moved
                                when (itemType) {
                                    ITEM_TYPE_FIRST_LIST_ITEM -> {
                                        val fromIndex = fromPosition - 1
                                        val toIndex = toPosition - 1
                                        Collections.swap(userDataList, fromIndex, toIndex)
                                    }
                                }
                            },
                            onDragCompleted = {
                                // Update list or do API call when an item drag operation is completed
                                Log.d("MainActivity", "onDragCompleted: $it")
                            },
                            itemTypeBuilder = object : ComposeRecyclerViewAdapter.ItemTypeBuilder {
                                override fun getItemType(position: Int): Int {
                                    // Determine the item type based on the position
                                    // You can customize this logic based on your requirements
                                    return ITEM_TYPE_FIRST_LIST_ITEM
                                }
                            },
                            onScrollEnd = {
                                // Do API call when the user reaches the end of the list during scrolling
                                Log.d("MainActivity", "onScrollEnd")
                            },
                            itemTouchHelperConfig = {
                                nonDraggableItemTypes =
                                    setOf(ITEM_TYPE_FIRST_HEADER, ITEM_TYPE_SECOND_HEADER)

                                /*onMove = { recyclerView, viewHolder, target ->
                                    // Handle item move
                                }
                                onSwiped = { viewHolder, direction ->
                                    // Handle item swipe
                                }
                                // Add more customization options as needed*/
                            },
                        ) { recyclerView ->
                            recyclerView.addItemDecoration(
                                DividerItemDecoration(
                                    recyclerView.context,
                                    DividerItemDecoration.VERTICAL
                                )
                            )
                        }
                    }

Also attach video with crash and file with error stacktrace
error_stacktrace.txt
https://github.com/canopas/compose-recyclerview/assets/17811677/ae4bf5f8-9dba-4def-b720-cc5c7e503c0b

Additionaly - it always crash, when i try to delete 15th item


add timezone to the set_options type

Summary of changes
I'll review the commits, so I mostly want to understand the "why" rather than the "what"
Checklist

[x] New functions have typespecs, changed functions were updated
[x] Same for documentation, including moduledocs
[x] Tests were added or updated to cover changes
[x] Commits were squashed into a single coherent commit
[x] Notes added to CHANGELOG file which describe changes at a high-level

I'm having this issue. Dyalizer is going crazy everywhere in my code base because of this.
Funny thing is, it still works as expected, even thou the specs are incomplete.

If you are here before this is merged, here's an elixir only approach to setting a timezone to a utc_datetime
  def set_timezone(utc_dt, timezone) do
    %NaiveDateTime{
      year: utc_dt.year,
      month: utc_dt.month,
      day: utc_dt.day,
      hour: utc_dt.hour,
      minute: utc_dt.minute,
      second: utc_dt.second
    }
    |> DateTime.from_naive!(timezone)
  end


Only collect logs if graph has collect_logs set

How to test:
just start(d)
just installlogging
warcli network start --force
warcli rpc 2 'logging [\"all\"]'
warcli rpc 7 'logging [\"all\"]'
just connectlogging

Browse to localhost:3000 (admin/password) and explore the loki data source. Using the label explorer, observe that many logs are available for {pod="warnet-tank-000002"} but none are available for {pod="warnet-tank-000007"} even though both have been set to log everything. This is because tank 02 has collect_logs set to true in it's graph but tank 07 does not.

This also LGTM. Going to let main CI finish before merging.


Problem using defect dojo python api

Please use the following template when submitting issues:
Issue Template
Issue Type

[x ] Bug
[ ] Enhancement

Description
see https://github.com/aaronweaver/defectdojo_api/issues/5
which repo is the right one to submit issues concerning the api?
If the issue is a bug, please also include the following:
Operating System
Please include the version number (ex: Ubuntu 16.04)
Install

[ ] setup.bash
[ ] docker

Steps to Reproduce
Sample Scan File (if applicable)
Screenshots (optional)
Console Logs (optional)

Fixed, see https://github.com/aaronweaver/defectdojo_api/issues/5


Typo in Uri.port property documentation

Please see https://api.dartlang.org/stable/1.21.0/dart-core/Uri/port.html

Returns the defualt port if there is no port number in the authority component.

Note ... defualt  ..

Fixed.


idea task - support TS tests

@hugebdu - could you please describe it better? I mean do you need preBuild script, args for mocha runner or such?

So we're experimenting with writing our IT tests in TypeScript instead of those typings.spec.ts to save some duplications.
That means our package.json#test has both --register ts-node and mocha patterns include *.ts, however autogenerated IDEA test configs don't have those.
@alexeevg suggested to check package.json and build our IDEA test configs according to test:* scripts we have.

already supported via lerna.js - closing


Fixed release checksums

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

closing because this PR should fix it: https://github.com/aws/eks-distro/pull/2187


PHPUnit 10.3

Would it be possible to update this package to use PHPUnit 10?

This packet supports 9 and 10 versions of PHPUnit.
Happy testing, Mateus


Refactor each record type's setRecordType() func so it only sets recordType

Can we close this? Are there examples left to fix?


rclone file limit bug

v1.27 Windows 7/8.1 x64
Dropbox
File limit bug / setting?
When I issue the command:
rclone purge remote:..path
I get the error:
2016/03/01 14:58:41 Attempt 1/3 failed with 1 errors and: There are too many files involved in this operation. and so forth.. and after the last retry..
2016/03/01 14:59:05 Failed to purge: There are too many files involved in this operation.
I can upload / list / perform other functions with no issue. I have tried from two diff. internet connection locations with same results. The error displays fairly quickly after the command is issued. There are approx. 750K files in various approx. 150 subdirectories

This looks like it is a dropbox limitation - it can only operate on 10,000 files at once.  rclone sends a single command to dropbox to do a purge but dropbox immediately replies with that error.
http://stackoverflow.com/questions/24843780/dropbox-core-api-10000-file-move-strategy
You could try doing rclone delete ... instead.  This will be much slower, but it should work.
If that works I'll document the work-around in the dropbox docs.
Thanks
Nick

Did you have a go with rclone delete?


Update README.md

Updates wording to remove verbiage about Preview state.

Closing to make the changes in the Release/V2.0 branch instead.


[FLINK-14614][checkstyle] add annotation location javastyle rule

What is the purpose of the change
Check location of annotation on language elements.
Brief change log
modify some codes for new rule.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Has this been discussed on the mailing list?

Has this been discussed on the mailing list?

hi, @zentol, not yet.

Please do so first; closing the PR for now.


Create dropdown to select output sound device

Description

This pull request adds a dropdown to the Sonify plugin to which allows the user to select the output device for sound. This must be done BEFORE the cube is sonified since the device is used as a parameter in OutputStream which initializes the stream in self.stream in the image viewer.

Change log entry

[ ] Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

[ ] Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
[ ] Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
[ ] Do the proposed changes follow the STScI Style Guides?
[ ] Are tests added/updated as required? If so, do they follow the STScI Style Guides?
[ ] Are docs added/updated as required? If so, do they follow the STScI Style Guides?
[ ] Did the CI pass? If not, are the failures related?
[ ] Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
[ ] After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

Work continued in #3 , closing this PR.


Communication Identity | Fixed next-pylint and mypy errors

Description
Made changes to improve Communication Identity modality code by running below formatters :

mypy(static type checker)
next-pylint

Next-Pylint :
tox run -e next-pylint -c eng/tox/tox.ini --root .\sdk\communication\azure-communication-identity
Your code has been rated at 10.00/10
Mypy :
mypy .\azure\communication\identity\
Success: no issues found in 35 source files
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

/azp run python - azure-communication-identity - tests

/azp run python - azure-communication-identity - tests-weekly

API change check
API changes are not detected in this pull request.


Slow start-up (5 sec..!) with multiple profiles (even on nvme storage)

System Details

OS: Windows 11 23H2
Thorium Version 126.0.6478.231

Problem
If Thorium is being used with a single user profile, no issues. But, if a user creates 2 or 3 extra profiles, the browser starts to lag at start-up. When launched, it takes about 5 seconds to display the profile selection window. This happens even after disabling all extensions on all profiles.
Additional Notes
Does Thorium have anything like Firefox Profiler which can be enabled at start-up ? I don't know if such thing exists, but if it exists, please mention how to profile the start-up. I'll provide any logs I get.

@abhi-deshpande Hmmm. I don't use multiple profiles, so let me see if I can re-create this on my Windows machine.


Dark Theme

Description:
This pull request introduces a new feature to the application: a dark mode toggle button. The button allows users to switch between light and dark themes seamlessly.
Changes Made:

Added a dark mode toggle button to the header.
Implemented a modern style for the button with emojis (sun and moon) indicating the current theme.
Updated CSS to handle the styling of the button and transitions between themes.
Added JavaScript functionality to toggle the dark mode and store the user's preference in localStorage.

Thank you!


Add xo as a linting tool

This adds XO as a linting tool to have a consistent linter and style accross the Zeit projects, as requested by @leo.

Looks great! But I think the esnext property is missing from the XO config 😊

Sorry, forgot to mention that.
I didn't add it on purpose, as I thought you might not want to make a breaking change. This package (probably?) works with older versions of Node, and ES2015-ifying it would necessarily be a breaking change and would limit its use to newer Node versions.
I'm fine with adding the esnext property though. Just let me know :)

@jfmengels Ahhh, you're right. We're not transpiring anything atm, so we also shouldn't add the property!

Will probably do a few more repos later today/this week-end. Let me know if you need help for the zeit/now repo too ;)

@jfmengels Cool, thanks! 😊 Yea, I definitely need help there... What's the best way to handle that? Can you copy my branch and work from there?

Oh, we also need the badge! 😄

Yea, I definitely need help there... What's the best way to handle that? Can you copy my branch and work from there?

Sure, I'll try that. And you're right, forgot the badge. Will make PRs for that ;)

@jfmengels Perfect! I already added the badge to async-throttle and ms 😊


Add IsValidSnippetInsertionAtPosition support

Add IsValidSnippetInsertionAtPosition support so that hosts can determine if snippet entries should be inserted in the completion list

// cc: @mhegazy, @vladima , @billti , @zhengbli

It looks like the editor needs to make two calls whenever the it needs to provide completion list: one for the snippet insertion and the other for the actual completion. Why not just combine these two and make the shouldInsertSnippet a property for the completion list response?

it is not useful for VS it its current state  when there are two separate completion providers for regular completions and for snippets. In theory we can combine them into one however before doing I'd like to see how much time it takes to execute isValidSnippetInsertion

After discussion with @vladima & @mhegazy it makes sense to merge our regular & snippet completion providers in VS as it is not worth the effort to extract the syntactic information to determine this on the script side. Closing this review out and will follow up with a separate review on the VS host side.


Plugin dont work with new material redesign

After changing cookies as described here plugin dont work, only shows blank page.

Using the Userscript and it works fine. Any specific errors in your console?

Here is screenshot of console. Im using developer and userscript version.


Clean up table.js

Currently the table.js files are very unclear and contain a lot of parts that can be improved. At the end it should only contain the user given custom js function and the config json object which will the be interpreted by the datavzrd.js file.

related to #343


Skipping two tests when running with GCCGO (CI)

Signed-off-by: Srini Brahmaroutu<EMAIL_ADDRESS>One of the TestEventsOOMDisableTrue and TestEventsOOMDisableFalse are hanging intermittently causing most of the x86 CI builds to fail. We are investigating the test failures but in the interim I would like to Skip these tests using existing flag. Also the PR is fixing a bug when Skipping a test while GCCGO compiler is detected.

@ewindisch @LK4D4 due to a bug in earlier code in TestRequires(NotGCCGO), the test case TestAppArmorDeniesPtrace was skipped always. Now that this PR is fixing that issue the test case is run again. But I am seeing this test case failing consistently on Jenkins. Please advice how to address?

ping @jfrazelle, please see that this PR is merged to get GCCGO CI to run properly.

LGTM


Color tokens extraction

Proposed Changes

Added the necessary logic to extract the Colors from our Figma library.
Performed an initial extraction of the color tokens
Built a demo page on the plasma website

Review might be easier if you review commit by commit. A lot of new files are just the result of the extraction so no need to really review those.
Potential Breaking Changes
None.
Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Hey Gaël, glad the whole is taking shape! I would just have two minor comments:

Any chances that in Plasma we can list the colors by order (as in Figma)? So first go the primary, then accents, then secondary. Just a detail but it will be much less confusing for newcomers.
I was gonna say something about the shadow, but I'll just drop it... heh

Any chances that in Plasma we can list the colors by order (as in Figma)? So first go the primary, then accents, then secondary.

The order figma gives me from its API is not the one you would expect. First color is gradient, then Lime, then Indigo... I feel its all mixed up, so I went with alphabetical order which is less confusing to new comers

I was wondering does the token extraction now extract colors AND icons at once? or you can pick which one you want? 🤔

I was wondering does the token extraction now extract colors AND icons at once? or you can pick which one you want? 🤔

Both, you can pick only the libraries you want and all of them if you need to.

I made a small hack to make the primary colors appear first, then the rest is sorted alphabetically like before.


Issue: Joining an existing room won't display current Game Master

Joining an existing room won't display current Game Master. The red header remains empty.

I'll look into this

FIXED!!


PUP-4046 correct require in hiera_include

Here we correct the include of hiera_puppet to one of hiera/puppet_function,
allowing Hiera::PuppetFunction to be resolved.

As noted in PUP-4064 this is only a partial solution to the wider problem of using hiera_include with puppet apply and just moves the problem along.

CLA signed by all contributors.


Changes made to templates and views

Got rid of redundancies, added glyphicons, and NO TABLES USED FOR NON-DATA ITEMS. Still need to add database and router functions

NO TABLES USED FOR NON-DATA ITEMS
Wahoooooooooooooooooo!

Redundancy mostly removed here. Still a few questions about approach, but I think it is probably best to get this merged as the basis for further iteration.


Added MyDigitalSchool

Official website URL : https://www.mydigitalschool.com/
One of the Bachelors proposed by the school (Web developer) : https://www.mydigitalschool.com/bachelor-developpeur-digital-web

@AXL797 Please provide us with an URL of a page or another proof showing that the university recognizes the domain which you are submitting (my-digital-school.org) as an official email domain for the students.

@philipto Hello, will that do ?

@AXL797 Yes, thank you for the clarification! Pull request merged.