Azure Open AI - Create an Open AI, Cognitive Search Resource and datasource pointing to a custom blob storage using C# (Use your own data)

Hello,
I want to programmatically create using C#:

Create a resource of type "Azure Open AI" in a region that I will specify as a string
Create a resource of type "Azure Cognitive Search" in a region that I will specify as a string
Add a data source (add your own data in preview) based on a Blob Storage that must be specified programmatically and create an index in the process
Create an indexer to make index updates every 5 minutes. In this process, a data source based on the same blob storage I mentioned must be created.

All of these must create resources in a specific resource group that I will specify in the code.
Where is the documentation that I can use to achieve this?
I've looked at https://learn.microsoft.com/en-us/dotnet/api/overview/azure/ai.openai-readme?view=azure-dotnet-preview and https://learn.microsoft.com/en-us/dotnet/api/azure.ai.openai.azureopenaimodelfactory?view=azure-dotnet-preview but none of these were able to point me into the right direction.
Another question, how can I make sure that the data source (add your own data in preview) is persisted? From the tests I made using the Portal, the data source disappears after closing the browser session.
Thanks

@miguelisidoro Since your goal is to use C#, I suggest starting from https://github.com/Azure-Samples/azure-search-openai-demo-csharp/ and asking in that issue tracker for any aspect that's missing.

@pamelafox thanks for sharing. Althoug useful, I don't see any option to programmatically create using C#:

Create a resource of type "Azure Open AI" in a region that I will specify as a string
Create a resource of type "Azure Cognitive Search" in a region that I will specify as a string
Add a data source (add your own data in preview) based on a Blob Storage that must be specified programmatically and create an index in the process
Create an indexer to make index updates every 5 minutes. In this process, a data source based on the same blob storage I mentioned must be created.

The frontend will be Angular.
Any other ideias that can help?

Hi @miguelisidoro ,
I believe that you would benefit from using the API directly to achieve this. There is more information about this here:
https://learn.microsoft.com/en-us/azure/ai-services/openai/use-your-data-quickstart?tabs=command-line&pivots=programming-language-csharp


Metadata changes - draft

This draft PR outlines the changes that will be made to .gov domain data soon, linking to individual commits showing the effect of the change.

Remove "agency" from domain type

Old
New

Federal Agency - Executive
Federal - Executive

Federal Agency - Legislative
Federal - Legislative

Federal Agency - Judicial
Federal - Judicial

Interstate Agency
Interstate

Independent Intrastate Agency
Independent Intrastate

Native Sovereign Nation
Tribal

Re-sort domain type alphabetically. This has the effect of moving Tribal domains to the bottom of the CSV).
Use Unix line endings ($) over Windows (^M$)

Do you want to make the same changes to current-federal.csv?

Yep, these changes will also be made to current-federal. The PR was just to show an example of what the change would look like, not intended to be the PR with the actual changes (I'll use the freshest data possible and merge that).

See #49.


More convenient variant_regions descriptions

Let's assume I want to call small variations in a WGS sample in coding regions only. May I specify variant_regions: transcripts1e5 as I can with the sv_regions parameter or do I have to specify a BED file here?

Sven-Eric;
Right now it doesn't have the convenience settings, so you have to specify a BED file. It would be useful to enable this and also provide BED files for standard captures to try and make that easier as well. Thanks for the nice ideas, we'll add it to the list of things to work on.

Great, thanks. Closing.


Use HystrixFeign only if it's present on classpath

Exactly like HystrixFeignConfiguration:
https://github.com/spring-cloud/spring-cloud-netflix/blob/c89645e0699342c55314e3ef7a2c6eb8b6ac90de/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/feign/FeignClientsConfiguration.java#L97

Thanks @dstepanov . Could you please create another PR to address this issue also in a 1.1.x branch?

Done :slightly_smiling_face:


new(scripts): adding install script

The idea is to create a installer shell script that executes the lstn installation process for various architectures and operating systems (including linux, macOS, BSD). A classic use case for this would be installing lstn on ephemeral environments (such as CI jobs).
The proposed solution includes the following functionality:

Detects the host OS and arch in order to download the appropriate release
Downloads the release via curl or wget (without package managers)
Verifies the integrity using shasum
Checks for existing installation (if any) on the host, and compares with the latest upstream release

Addresses #115

[x] I have read the contributing guidelines
[x] I have followed the coding guidelines
[ ] I have written unit tests
[x] I have made sure that the pull request is of reasonable size and can be easily reviewed

links to #115

Some notes:

For testing this, run sudo install.sh (inside the scripts directory)
Ideally we should have it hosted on a URL and have users run it through a one-liner. Something like:

(curl -Ls --tlsv1.2 --proto "=https" https://<subdomain>.listen.dev/install.sh || wget -t 3 -qO- https://<subdomain>.listen.dev/install.sh) | sudo sh

Superseded by #116


Fix flaky TrieMemtableIndexTest#indexIteratorTest test

This test essentially has a while loop on a naive
proof of work comparison...
Fixes an issue where sometimes this test times out.

@mike-tr-adamson - this might be a problem elsewhere. Since it's pretty minor, I'm merging now.


[SPARK-39529][INFRA] Refactor and merge all related job selection logic into precondition

What changes were proposed in this pull request?
This PR borrows the idea from https://github.com/apache/spark/pull/36928 but adds some more changes in order for scheduled jobs to share the precondition so all conditional logic is consolidated here.
This PR also adds a new option to is-changed.py so dependent modules can be checked together. In this way, we don't have to change build_and_test.yml often when we add a new module.
In addition, this PR removes type because precondition job now replaces it.
Lastly, this PR enables PySpark, SparkR TPC-DS and Docker integration tests for scheduled jobs when applicable.
Closes #36928
Why are the changes needed?
To make it easier to read.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Tested locally and in my fork (https://github.com/HyukjinKwon/spark/actions)

cc @dongjoon-hyun @Yikun @gengliangwang @EnricoMi @MaxGekk FYI

I found it best to test by removing if "root" in test_modules from dev/is-changed.py, so that changes from this PR do are not considered by the CI in this PR. Then, by triggering some changes in spark or pyspark should just trigger those to be built.
The scheduled jobs are best to be tested by declaring this branch as the default branch, so that GitHub runs them as defined here.
Besides that, it can only be tested from master, sadly.

BTW, how do we validate this PR?

I will test locally, and try to run the scheduled jobs in my fork with some manual changes (to allow running in my fork). That's not perfect but would still test reasonably enough before getting this in.

I tested all the possible scenarios. should be good to go.

Will merge this tomorrow morning in my time (KST) .... so I can monitor and fix it if something goes wrong ...

Merged to master.

Thanks!


Stuck at jekyll serve

When doing jekyll serve I get:
C:/tools/ruby27/lib/ruby/gems/2.7.0/gems/bundler-2.1.4/lib/bundler/resolver.rb:290:in `block in verify_gemfile_dependencies_are_found!': Could not find gem 'github-pages x64-mingw32' in any of the gem sources listed in your Gemfile. (Bundler::GemNotFound)
How can I solve this?
Thanks in advance.

Just run that command before serving the website
bundle install

You get more help here.


Updated index.md

Why:

What's being changed:

Check off the following:

[ ] All of the tests are passing.
[ ] I have reviewed my changes in staging.
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

👋 @uditseven All of those are supposed to be lowercase, so I'm going to close this out. If you have any questions, feel free to open a discussion 🎉


docs: fix typos in website/docs/migration/migration-manual.mdx

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[x] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[x] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

thanks 👍


Gh#3715 stack alloc

Modified use of stack buffer to minimize stack buffer size to 128.
Resolves #3715

Conversations with @bytemaster and @arhag decided to go with 512 to allow transfer with full 256 memo to fit.


Creates the option to sort on the "All" page with the sort dialog

On the "All" page, a ViewSettings dialog is now offered to sort the data according to three parameters.
The data is now sorted by default according to name.

Awesome! Many thanks 🥳


[ServiceBus] fix typehints

based on APIView here: https://apiview.dev/Assemblies/Review/fb319de65d2b4eca86b215c62d0cbe7b?revisionId=2c875b1de85e4ec58f0c1b2994cee20d&diffRevisionId=d2bf9a264ba84047a667011c9ae2d41d&doc=False&diffOnly=False#comment-thread-5

API change check for azure-servicebus
API changes have been detected in azure-servicebus. You can review API changes here

/azp run python - servicebus - ci


dyld: Symbol not found: ___CFObjCIsCollectable

This happens on macOS Mojave 10.14:
{-# LANGUAGE OverloadedStrings #-}

import Control.Monad
import Data.Default.Class
import Network.HTTP.Req

main :: IO ()
main = runReq def $
  void $ req GET (https "api.github.com" /: "meta") NoReqBody ignoreResponse mempty

› nix-shell -p 'haskellPackages.ghcWithPackages (hp: [ hp.req ])' --run 'runhaskell Main.hs'
dyld: Symbol not found: ___CFObjCIsCollectable
  Referenced from: /nix/store/wkqjqwyfi1nn2hg9k0as03lpcmalqxzj-libsecurity_utilities-osx-10.7.5/lib/libsecurity_utilities.0.dylib
  Expected in: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
 in /nix/store/wkqjqwyfi1nn2hg9k0as03lpcmalqxzj-libsecurity_utilities-osx-10.7.5/lib/libsecurity_utilities.0.dylib
Main.hs: VanillaHttpException (HttpExceptionRequest Request {
  host                 = "api.github.com"
  port                 = 443
  secure               = True
  requestHeaders       = []
  path                 = "/meta"
  queryString          = ""
  method               = "GET"
  proxy                = Nothing
  rawBody              = False
  redirectCount        = 10
  responseTimeout      = ResponseTimeoutDefault
  requestVersion       = HTTP/1.1
}
 (InternalException (HandshakeFailed (Error_Protocol ("certificate has unknown CA",True,UnknownCa)))))

(the expected result is a 403.)
I am not sure if it is a Mojave-specific issue as I currently don’t have a previous version of macOS to test with, but I’ll ping #42719 just in case.

› objdump /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation -macho -exports-trie | grep ___CFObjCIsCollectable                                                                                <1>
0x00594E50  ___CFObjCIsCollectable

🤔

Hmm, I was expecting this to be the problem but that doesn't seem to be it. I was expecting our version not to have it while libsecurity is expecting it to be there.
$ nm -g /nix/store/36ph03q316x86rdyvx63ha2kl51f84dm-CF-osx-10.10.5/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation | grep ___CFObjCIsCollectable
00000000000f6970 S ___CFObjCIsCollectable
$ nm -g /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation | grep ___CFObjCIsCollectable
00000000005e68d0 S ___CFObjCIsCollectable

Got access to macOS 10.13.6 and it works there, so, yes, a Mojave regression.

Speculating: There appear to be some new SSL-related headers that aren't being copied into our libsecurity:
/System/Library/Frameworks/Security.framework/Versions/A/Headers/SecProtocolMetadata.h
/System/Library/Frameworks/Security.framework/Versions/A/Headers/SecProtocolOptions.h

I'm not sure how to add those to my local nixpkgs checkout to test if that'll fix it, but it's something.

Due to a suggestion at https://github.com/NixOS/nixpkgs/blob/7736337916538aab67a00739c53b8434da773a3b/doc/functions.xml#L636 about this specific error message, I'm attempting a GHC build with cacert added to nativeBuildInputs to see if that gets things any further along. Will update if/when it finishes.

I tried to follow the story here and I didn't see a resolution, so I assume this is still broken. I'm on the current bleeding master and trying to build haskellPackages.dhall_1_17_0 and I'm stumbling into this as well:
/private/tmp/nix-build-dhall-1.17.0.drv-0/dhall-1.17.0/src/Dhall/Tutorial.hs:440: failure in expression `input auto "https://raw.githubusercontent.com/dhall-lang/dhall-haskell/18e4e9a18dc53271146df3ccf5b4177c3552236b/examples/True" :: IO Bool'
expected: True
 but got: dyld: Symbol not found: ___CFObjCIsCollectable
            Referenced from: /nix/store/79x43vkf7r0hhyd7h6xy7kipyv9j5kj8-libsecurity_utilities-osx-10.7.5/lib/libsecurity_utilities.0.dylib
            Expected in: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
           in /nix/store/79x43vkf7r0hhyd7h6xy7kipyv9j5kj8-libsecurity_utilities-osx-10.7.5/lib/libsecurity_utilities.0.dylib
          dyld: Symbol not found: ___CFObjCIsCollectable
            Referenced from: /nix/store/79x43vkf7r0hhyd7h6xy7kipyv9j5kj8-libsecurity_utilities-osx-10.7.5/lib/libsecurity_utilities.0.dylib
            Expected in: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
           in /nix/store/79x43vkf7r0hhyd7h6xy7kipyv9j5kj8-libsecurity_utilities-osx-10.7.5/lib/libsecurity_utilities.0.dylib
<snip>

Darwin is greek to me, but from the previous commands, it looks like the symbol isn't copied or at least is undefined?
0caseys-imac:~/git/nixpkgs% nm -g /nix/store/79x43vkf7r0hhyd7h6xy7kipyv9j5kj8-libsecurity_utilities-osx-10.7.5/lib/libsecurity_utilities.0.dylib | grep ___CFObjCIsCollectable
                 U ___CFObjCIsCollectable
0caseys-imac:~/git/nixpkgs% nm -g /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation | grep ___CFObjCIsCollectable
0000000000595e60 S ___CFObjCIsCollectable

This would seem to line up with @LnL7's theory from https://github.com/NixOS/nixpkgs/issues/45042#issuecomment-413031009

@cransom For the immediate problem of dhall, you can override it with dontCheck to skip the tests. Network calls still won't work, but it'll at least be usable.
dhall = dontCheck super.dhall_1_17_0;

I think we should try using the impure Security framework for now. I looked at the issue and it's definitely not obvious what to do. Perhaps updating to the latest Apple open source release fixes it but just as likely could be something else.
/cc @copumpkin

Unless Apple has a separate channel for alphas/betas, we have the latest version from https://opensource.apple.com/tarballs/libsecurity_utilities/

They’ve moved it all to security. Those are from like 10.9

I opened https://github.com/NixOS/nixpkgs/pull/47676 to fix this (temporarily at least).

@matthewbauer thank you for doing this!

@domenkozar no objections

(triage) If I read it correctly, this is currently solved by #47676?

Yeah as well as we can until we can update Security.


Switch to github actions

Travis is no longer available it seems...
Let's investiage github actions, shouldn't be that hard...

Done in b33606c542e00bdc6ecdcc3fa983021c889e6971


Add timestamps to requesters view

Requesters list on a finished course should have timestamps for when the request was made

Merged to staging


shellcheck: deprecate phases

Motivation for this change
#28910
please check if it is working. not sure why it was defined at all
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 130541 at f439e8db run on x86_64-linux 1

3 packages skipped due to time constraints:

openvino
python38Packages.openvino
python39Packages.openvino

6 packages built successfully:

bashup-events32
bashup-events44
nix-info-tested
passExtensions.pass-checkup
shellcheck
vscode-extensions.timonwong.shellcheck

3 suggestions:

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/development/tools/shellcheck/default.nix:30:5:
   |
30 |     buildPhase = ''
   |     ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/tools/shellcheck/default.nix:24:41:
   |
24 |     inherit (haskellPackages.ShellCheck) meta src;
   |                                         ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/tools/shellcheck/default.nix:34:5:
   |
34 |     installPhase = ''
   |     ^

please check if it is working. not sure why it was defined at all

I’d suggest to do the checking work before opening a PR, removing a line of code is kinda trivial compared to checking whether it doesn’t break the build.

i can confirm, that the build still works.


Possibly missing include header file  “c++defines.hpp” in "platform_spec.hpp"

found a Possibly missing include header file  “c++defines.hpp” in "platform_spec.hpp" in latest (by the time 2017/6/25 18:00 UTC+8) version which makes the entire file content inactive in my Windows 7 +vs2017 box.

I discover you're intend to include  “c++defines.hpp” header file where you use "platform_spec.hpp" and that is okay so far.


fix: initialize newly created block slots

Note: This is a WIP PR. I copied the following lines of code and would like to deduplicate the code by moving it somewhere else. I'm not very familiar with the Shopware code, so I would be happy if someone can tell me where the best place to put it would be. cc @OliverSkroblin @jleifeld @pantrtxp
https://github.com/shopware/platform/blob/d31eeb52fa86bb43afbc03a9a0a5cef2276fcb86/src/Administration/Resources/app/administration/src/module/sw-cms/component/sw-cms-sidebar/index.js#L304-L319
Edit 3: I now also added this fix to sw-category-detail. For that I required that code again and moved it into sw-cms/util/create-slots.js. I'm not 100% happy with that. Do you have any better recommendations?
Edit 4: Are there any other places where this fix should be applied to? I'm not very familiar with the Shopware Administration yet. I only created this PR because with this fix I'm saving my colleague a lot of time as he doesn't have to recreate any existing blocks just to add another field.

1. Why is this change necessary?
Example: We create a new block for the administration with registerCmsBlock. This block has 1 slot, let's name it title. Now we're using that block and save it. When we're now adding more slots to registerCmsBlock these fields won't be writable as the slots are not initialized. This change creates the not existing slots.
2. What does this change do, exactly?
We're creating a set from all slots which we got from the server. We then loop over all available slots from the blockConfig and create non-existent slots.
3. Describe each step to reproduce the issue or behaviour.

Create a new block with registerCmsBlock
Add a slot title

'title': {
    type: 'text',
    default: {
        config: {
            content: {
                source: 'static',
                value: 'My title'
            }
        }
    }
}

Log into backend and create a new template with this block and save it.
Add a new category page and assign the layout to it.
Add another slot to the element

'text': {
    type: 'text',
    default: {
        config: {
            content: {
                source: 'static',
                value: 'Lorem Ipsum'
            }
        }
    }
}

Go to the new template and the category page and see that there is no input field for the text slot on both.

4. Please link to the relevant issues (if any).
https://forum.shopware.com/t/custom-cms-block-um-einen-slot-erweitern/64999
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits [Please squash merge when it's ready]
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Edit: I'm not sure if I'm able to create a test for this change. I will create a changelog file when I got a feedback from a Shopware core maintainer about how to refactor the code to comply with the DRY pattern.
Edit 2: TODO for me: also check where a similiar fix is required (category pages)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @RafaelKr,
Thanks for opening this PR.
Doing any changes in this area will require a lot of testing, manually and of course in form of automated tests. We can also not tell you what would be the best way to do this without taking a closer look at it and would have to plan in the time for that.
If you want to try and solve this issue we would be happy to accept it BUT you will need to write extensive tests and will have to understand that the review of your change may take quite a bit.
Else I would ask you to open up an ticket in our Issue-tracker for this, although getting to that will probably also take quite some time since it is neither affecting many people, nor being an blocker.

Hi @J-Rahe, thank you very much for your quick answer! Of course I understand that this change needs thorough testing. We now have this change in our development environment (v<IP_ADDRESS>) and it seems to be working.
I will try to find some time to implement automated tests in the coming 2-3 weeks. I had a quick look on some other tests and I'm confident that I'm able to implement some meaningful tests. (It's a great opportunity to get familiar with Cypress for me! Wanted to try it out for a long time.)
But I would be very grateful if someone with deep understanding of that area can take a look on my changes and tell if this is the right approach. Also I'd like to know if there are more places where this addition should be implemented, or more precise: Are there other areas where slots coming from the server can be edited?

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-14963
Please use this issue to track the state of your pull request.

Hey @RafaelKr ,
I’ve created an issue for your PR so we can plan in one of our frontend experts to take a look at this. Please note that, especially due to the current release preparations, it may take a few weeks until we come back to you.

Currently it's still working fine for us with a little downside:
We're working with templates where possible. For some pages we use the contents tab in the category pages to overwrite some fields from the template for a specific page. Currently all media files are overwritten when the contents tab is saved. The expected behavior would be to only overwrite the media file when it was changed. I'm going to look into that in the coming days.

Hey @RafaelKr ,
it would be good if you create a new ticket in the issue tracker: https://issues.shopware.com/  Then it will be planned to fix it in the future. This would be the better variant because the cms is a very complex topic where we have consider many things by fixing the issue.
Best regards,
Jannis


Increase progressDeadline for PVC tests to 600 seconds

Provisioning a volume might take longer than default 120s.
What this PR does / why we need it:
Which issue(s) this PR fixes:
JIRA: https://issues.redhat.com/browse/SRVCOM-2845
Does this PR needs for other branches:

Does this PR (patch) needs to update/drop in the future?:

JIRA:

If this PR is accepted let's cherry-pick them on "release-v1.12" and "main" as well.

Is 4.15 that slow wrt pvc?

We have just two runs so far but the same test failed in both cases: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/logs/periodic-ci-openshift-knative-serverless-operator-main-ocp4.15-lp-interop-operator-e2e-interop-aws-ocp415
I tried locally just the single test and it was quick, and passed. Maybe when running many tests in parallel it has some effect. But we want the test to be passing.

The last run passed without this change (sent via https://github.com/openshift-knative/serverless-operator/pull/2391): https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-knative-serverless-operator-main-ocp4.15-lp-interop-operator-e2e-interop-aws-ocp415/1724791880547307520
But it would be good to make it more stable.

@mgencur before stamping it I am wondering if we should reach out to the OCP team to discuss if here is any performance degradation wrt pvcs.

@skonto Asking in this Slack thread. JIRA doesn't give me any results.

I have done some testing using Serverless 1.31 on OCP 4.15.0-0.nightly-2023-11-24-034436 running in AWS. The StorageCloass provisioner is ebs.csi.aws.com.
The test deployed Knative Serving service with PVC (I re-used the TestPersistentVolumeClaims from Serving) 10 times and measured the time between two events for PVC:

WaitForFirstConsumer
ProvisioningSucceeded

The PersistentVolumeClaim was deleted and re-created in each iteration.
I've written a short script for checking the events:
#!/usr/bin/env bash

oc get events -ojson > events.json
cat events.json | jq '.items[] | select(.involvedObject.name=="knative-pv-claim" and .reason=="WaitForFirstConsumer") | .involvedObject.uid' | while read -r uid
do
    waitForFirst=$(cat events.json | jq '.items[] | select(.involvedObject.uid=='$uid' and .reason=="WaitForFirstConsumer") | .firstTimestamp')
    succeeded=$(cat events.json | jq '.items[] | select(.involvedObject.uid=='$uid' and .reason=="ProvisioningSucceeded") | .firstTimestamp')
    echo "$uid: $waitForFirst -> $succeeded"
done

The results are following:
"c5a367a6-dc72-451c-bda1-01c389e600da": "2023-11-24T08:47:43Z" -> "2023-11-24T08:47:52Z"
"bfcaa96a-73de-4eac-8144-9175850c6c22": "2023-11-24T09:07:22Z" -> "2023-11-24T09:07:31Z"
"c86d1818-97f6-4a2f-b174-ef81fdf5745b": "2023-11-24T09:10:35Z" -> "2023-11-24T09:10:45Z"
"33eb380d-b52d-489f-a272-afd4ad9c889a": "2023-11-24T09:14:03Z" -> "2023-11-24T09:14:12Z"
"b381140b-2eda-4b2c-9aa9-0bf8786778cb": "2023-11-24T09:15:27Z" -> "2023-11-24T09:15:36Z"
"2523c40b-37cc-4047-875f-d8c5e5917ec0": "2023-11-24T09:16:49Z" -> "2023-11-24T09:16:57Z"
"8da3ac66-9b01-4d17-bbdf-74bc92565bc3": "2023-11-24T09:18:10Z" -> "2023-11-24T09:18:20Z"
"e3295614-4527-4a48-841f-15dd014e9454": "2023-11-24T09:19:33Z" -> "2023-11-24T09:19:42Z"
"803d3834-8142-4839-9b36-4ceb4d16e0b1": "2023-11-24T09:20:55Z" -> "2023-11-24T09:21:06Z"
"3dc2709f-92cf-423d-a0d6-f08a302cbeff": "2023-11-24T09:22:18Z" -> "2023-11-24T09:22:27Z"
"6fb3698f-9a7f-472c-8dbd-939693802bae": "2023-11-24T09:23:39Z" -> "2023-11-24T09:23:48Z"
"1881909e-8dd4-4ae2-85a1-d1074e28c22b": "2023-11-24T09:24:58Z" -> "2023-11-24T09:25:08Z"
"61943dd4-a286-4d59-82f6-3bfad2b5e314": "2023-11-24T09:26:21Z" -> "2023-11-24T09:26:31Z"

Summary: Provisioning usually takes about 10 seconds and never exceeded 1 minute. This looks alright.

Regarding the results above, the test was performed in isolation. I suppose it would take more time to provision a volume in a cluster where other tests are running in parallel. But that would depend on other factors.
I suppose we will hit this issue in CI in the future even though it might be rare. I still think increasing the progress deadline will make the test more stable.

/lgtm

/cherry-pick release-v1.12

/cherry-pick main


daemon: Rename host-reachable services to socket LB

Quoting @pchaigno

Probably our worst-named feature :disappointed:

Rename "host-reachable services" to "socket LB". The "host-reachable services" terminology will be completely removed in v1.13.

/test

/test-1.24-net-next

/test

/test

But then, don't we need to deprecate the EnableHostServices{UDP,TCP} options?

@pchaigno https://github.com/cilium/cilium/blob/master/daemon/cmd/daemon_main.go#L373 :sunglasses:

/test

/test

/test-gke

/test

/test-gke

/test-gke

test-gke is broken. Got ACKs from majority. Marking ready to merge.


HBASE-24268 REST and Thrift server do not handle the "doAs" parameter case insensitively

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 34s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
shadedjars
5m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
5m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
4m 13s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m  3s
hbase-rest in the patch passed.

31m 35s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux<PHONE_NUMBER>2f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8de8c44029

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/testReport/

Max. process+thread count
2662 (vs. ulimit of 12500)

modules
C: hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 48s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  7s
master passed

+1 :green_heart:
checkstyle
1m  4s
master passed

+1 :green_heart:
spotbugs
2m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 55s
the patch passed

-0 :warning:
checkstyle
0m 43s
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
0m 15s
hbase-rest: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 35s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 23s
The patch does not generate ASF License warnings.

38m 33s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 8f174746211d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8de8c44029

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 38s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 28s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
1m  0s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 22s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
5m 17s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 19s
hbase-rest in the patch passed.

39m 46s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 51d7948dbd2b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8de8c44029

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/testReport/

Max. process+thread count
1852 (vs. ulimit of 12500)

modules
C: hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

It is great that you are tackling this. Could you please add a test in the PR or a screenshot at the lira for validation?

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

+1 :green_heart:
shadedjars
5m 46s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 50s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
4m  6s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
2m 56s
hbase-rest in the patch passed.

33m 43s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6f99cff47518 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 15ddded26b

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/testReport/

Max. process+thread count
2740 (vs. ulimit of 12500)

modules
C: hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 51s
master passed

+1 :green_heart:
compile
0m 55s
master passed

+1 :green_heart:
shadedjars
6m  0s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 47s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
6m  3s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m 14s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 42s
hbase-rest in the patch passed.

35m  9s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3263ed74301e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 15ddded26b

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/testReport/

Max. process+thread count
1846 (vs. ulimit of 12500)

modules
C: hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 45s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 17s
master passed

+1 :green_heart:
checkstyle
1m  5s
master passed

+1 :green_heart:
spotbugs
2m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  7s
the patch passed

-0 :warning:
checkstyle
0m 44s
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
0m 16s
hbase-rest: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 14s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

40m 32s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux cc8a4aa0268a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 15ddded26b

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
shadedjars
5m 46s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 57s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 41s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
5m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
4m 16s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 31s
hbase-rest in the patch passed.

32m 56s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c2816f6de16f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 15ddded26b

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/testReport/

Max. process+thread count
2564 (vs. ulimit of 12500)

modules
C: hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 26s
master passed

+1 :green_heart:
checkstyle
1m  5s
master passed

+1 :green_heart:
spotbugs
2m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

-0 :warning:
checkstyle
0m 48s
hbase-thrift: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-0 :warning:
checkstyle
0m 19s
hbase-rest: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 10s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

39m 38s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux c49477119901 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 15ddded26b

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 31s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
shadedjars
6m 24s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
1m  0s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
5m  9s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 21s
hbase-rest in the patch passed.

41m 28s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ca5e51a03242 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 15ddded26b

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/testReport/

Max. process+thread count
1850 (vs. ulimit of 12500)

modules
C: hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
5m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 10s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
5m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 40s
hbase-http in the patch passed.

+1 :green_heart:
unit
4m 14s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 24s
hbase-rest in the patch passed.

34m  4s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 599bd8e74853 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 82d09904f2

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/testReport/

Max. process+thread count
2757 (vs. ulimit of 12500)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 44s
master passed

+1 :green_heart:
checkstyle
1m 16s
master passed

+1 :green_heart:
spotbugs
2m 44s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

-0 :warning:
checkstyle
0m 40s
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
0m 16s
hbase-rest: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 27s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

36m 19s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 59d78f9da110 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 82d09904f2

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-http hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 52s
the patch passed

+1 :green_heart:
compile
1m 32s
the patch passed

+1 :green_heart:
javac
1m 32s
the patch passed

+1 :green_heart:
shadedjars
7m  1s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 20s
hbase-http in the patch failed.

-0 :warning:
javadoc
1m  8s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 24s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
0m 59s
hbase-http in the patch passed.

+1 :green_heart:
unit
5m 17s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 33s
hbase-rest in the patch passed.

44m 31s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bad27c700364 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 82d09904f2

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/testReport/

Max. process+thread count
1856 (vs. ulimit of 12500)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 39s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 16s
master passed

+1 :green_heart:
checkstyle
1m 51s
master passed

+1 :green_heart:
spotbugs
2m 55s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 10s
the patch passed

-0 :warning:
checkstyle
1m 14s
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
0m 18s
hbase-rest: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 20s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

44m 19s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux aca8be538632 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7eff07d6bf

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 51s
master passed

+1 :green_heart:
compile
1m 16s
master passed

+1 :green_heart:
shadedjars
5m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  8s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 42s
hbase-http in the patch passed.

+1 :green_heart:
unit
4m 17s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m  8s
hbase-rest in the patch passed.

35m 11s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 04222486a1e0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7eff07d6bf

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/testReport/

Max. process+thread count
2571 (vs. ulimit of 12500)

modules
C: hbase-http hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 14s
the patch passed

+1 :green_heart:
compile
1m 38s
the patch passed

+1 :green_heart:
javac
1m 38s
the patch passed

+1 :green_heart:
shadedjars
6m 48s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-http in the patch failed.

-0 :warning:
javadoc
0m 50s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 21s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
0m 42s
hbase-http in the patch passed.

+1 :green_heart:
unit
4m  8s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
2m 51s
hbase-rest in the patch passed.

38m 26s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b914ae10862f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7eff07d6bf

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/testReport/

Max. process+thread count
2565 (vs. ulimit of 12500)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@clarax , @tedyu Could you please review this change?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 50s
master passed

+1 :green_heart:
checkstyle
1m 11s
master passed

+1 :green_heart:
spotbugs
2m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 33s
the patch passed

-0 :warning:
checkstyle
0m 38s
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
0m 16s
hbase-rest: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 59s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

44m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux fb8e28943d7b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9419c78d26

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/7/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 59s
master passed

+1 :green_heart:
compile
1m 31s
master passed

+1 :green_heart:
shadedjars
7m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 49s
the patch passed

+1 :green_heart:
compile
1m 44s
the patch passed

+1 :green_heart:
javac
1m 44s
the patch passed

+1 :green_heart:
shadedjars
7m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 59s
hbase-http in the patch passed.

+1 :green_heart:
unit
4m 40s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 50s
hbase-rest in the patch passed.

44m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 47606a9dc3b3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9419c78d26

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/7/testReport/

Max. process+thread count
1863 (vs. ulimit of 30000)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 50s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 17s
master passed

+1 :green_heart:
compile
1m 32s
master passed

+1 :green_heart:
shadedjars
8m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 26s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 13s
the patch passed

+1 :green_heart:
compile
1m 33s
the patch passed

+1 :green_heart:
javac
1m 33s
the patch passed

+1 :green_heart:
shadedjars
8m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 53s
hbase-http in the patch passed.

+1 :green_heart:
unit
5m 39s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
5m 56s
hbase-rest in the patch passed.

51m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 81acf6aae3af 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9419c78d26

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/7/testReport/

Max. process+thread count
1743 (vs. ulimit of 30000)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I have rebased the PR and resolved the conflicts.
Could you take an other look @busbey or @clarax, @tedyu ?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
checkstyle
1m 12s
master passed

+1 :green_heart:
spotbugs
2m 32s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 23s
the patch passed

-0 :warning:
checkstyle
0m 42s
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
0m 15s
hbase-rest: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 10s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m  2s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

42m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux c22a0d854ea9 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9419c78d26

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/8/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  0s
master passed

+1 :green_heart:
compile
1m 49s
master passed

+1 :green_heart:
shadedjars
7m 52s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 48s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 11s
the patch passed

+1 :green_heart:
compile
1m 47s
the patch passed

+1 :green_heart:
javac
1m 47s
the patch passed

+1 :green_heart:
shadedjars
8m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 56s
hbase-http in the patch passed.

+1 :green_heart:
unit
4m 39s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 52s
hbase-rest in the patch passed.

46m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 699b00fc8de2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9419c78d26

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/8/testReport/

Max. process+thread count
1929 (vs. ulimit of 30000)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/8/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m  6s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  4s
master passed

+1 :green_heart:
compile
1m 34s
master passed

+1 :green_heart:
shadedjars
8m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  9s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 34s
the patch passed

+1 :green_heart:
compile
1m 44s
the patch passed

+1 :green_heart:
javac
1m 44s
the patch passed

+1 :green_heart:
shadedjars
8m 58s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  0s
hbase-http in the patch passed.

+1 :green_heart:
unit
5m 44s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
6m  0s
hbase-rest in the patch passed.

55m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 39ec291824ee 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9419c78d26

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/8/testReport/

Max. process+thread count
1657 (vs. ulimit of 30000)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/8/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thank you @joshelser for the review!
I have updated the PR.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 14s
master passed

+1 :green_heart:
compile
1m 25s
master passed

+1 :green_heart:
shadedjars
6m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 28s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
1m 25s
the patch passed

+1 :green_heart:
javac
1m 25s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 44s
hbase-http in the patch passed.

+1 :green_heart:
unit
4m 18s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m  3s
hbase-rest in the patch passed.

38m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8c83f4be5c8a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9419c78d26

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/testReport/

Max. process+thread count
2663 (vs. ulimit of 30000)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 15s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 50s
master passed

+1 :green_heart:
compile
1m 13s
master passed

+1 :green_heart:
shadedjars
7m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 51s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
7m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 44s
hbase-http in the patch passed.

+1 :green_heart:
unit
4m 47s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
4m 36s
hbase-rest in the patch passed.

39m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3b81b5a0610b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9419c78d26

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/testReport/

Max. process+thread count
1666 (vs. ulimit of 30000)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 20s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 37s
master passed

+1 :green_heart:
checkstyle
1m  9s
master passed

+1 :green_heart:
spotbugs
2m 30s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 30s
the patch passed

-0 :warning:
checkstyle
0m 13s
hbase-http: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)

-0 :warning:
checkstyle
0m 41s
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
0m 16s
hbase-rest: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 21s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

43m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1843

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 89f9ed9cbf7c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9419c78d26

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-http hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1843/9/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

That's a great suggestion. Can we get a unit test please?

@busbey I see a unit test was added, so I'm assuming your request is satisfied. Merging this so it will ship in 2.4, sorry for not waiting for an ack from you.


right sidebar's in-page TOC misbehaving

Something very strange is going on with the in-page TOC links in the right sidebar.  Clicking on them doesn't reliably highlight the heading that was clicked on, and whitespace (presumably margin or padding) is getting added to the heading that is clicked on.  Screencast below reflects current master as of 886e002d
https://user-images.githubusercontent.com/1810515/114926630-357f8f80-9df6-11eb-8bab-a49d0f6cb650.mp4

as @jorisvandenbossche pointed out (https://github.com/mne-tools/mne-python/pull/9288#issuecomment-820681629) the weird spacing is an interaction between pydata-sphinx-theme CSS and sphinx-gallery CSS.  However, this reveals that there are 2 separate problems: the other one is that scrollspy doesn't work for the right-column TOC if the section heading is too close to the bottom of the page.  I.e., if the final page section is fairly short, then on a tall window clicking on its TOC link will not highlight, but on a short window its TOC link will highlight.

So for the sphinx gallery issue, I am not fully sure what the purpose is of that CSS snippet. It was added in https://github.com/sphinx-gallery/sphinx-gallery/pull/362, and seems to be related to the fact that there is a note box above the main title. But then it might be a bug in sphinx gallery that the CSS selector doesn't only catch that specific target for the main header of the page, but for any target on that page.

Also opened an issue on the sphinx-gallery side: https://github.com/sphinx-gallery/sphinx-gallery/issues/815

What's the status on this one? Is there a next step or something to investigate in the pydata theme?

scrollspy doesn't work for the right-column TOC if the section heading is too close to the bottom of the page. I.e., if the final page section is fairly short, then on a tall window clicking on its TOC link will not highlight, but on a short window its TOC link will highlight.

I think this is still unresolved, but I haven't had time to investigate a fix due to grant deadlines.

The scrollspy has been updated here #657 is it solving this issue ?

ah yes this should be solved!


ci: print time summary for cargo make & speedup build-ci-image

also bumps cargo make to 0.36.5 to make cmd in log less verbose
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
also bumps cargo make to 0.36.5 to make cmd in log less verbose (https://github.com/sagiegurari/cargo-make/issues/780)

😄

😄

cargo binstall resolve is too slow...

cargo binstall resolve is too slow... but download is too fast 🤣 still reduced 2min

wtf


Prevent leaking event bindings of dynamic legend panels.

A dynamic legend panel will cause an error when a vector layer is added and remove after init of the component. The behavior can be observed via the online examples feeding the following to the console:
mapPanel.layers.add(GeoExt.data.LayerModel.createFromLayer(new OpenLayers.Layer.Vector()));
mapPanel.layers.removeAt(3);
mapPanel.map.zoomOut();

This will cause Uncaught TypeError: Cannot read property 'map' of null by calling the VectorLegend:onMapZoom event handler of the disposed vector legend.
To fix this the cached map property of the legend is used to unbind all event handlers.

thanks for your work on this @bentrm


Static mesh collision issues on macOS

A static mesh doesn't seem to cause collisions when playing an exported project on macOS. On Windows, my "actors" whom are dynamic sphere colliders, roll around fine. On macOS, they fall due to gravity (so physics is working to some degree) but pass through the ground. It is possible the static mesh is just positioned improperly, or scaled improperly, because it appeared other enemy "actors" were not in free fall (but also not aligned with where I expected the static mesh collider to be).

In new bullet libraries, you can't have RigidBodyComponents of type Static anymore. They don't work.
Instead, you use StaticColliderComponent for static objects.
Developers won't make this mistake anymore -- I removed the Static RigidBodyType from RigidBodyComponent:
https://github.com/phr00t/xenko/commit/6c881b38fe8322b59797c7f4fb7c20d438c3f758


Search files named Rakefile with --rake flag

Ruby rake commands are typically kept in a file named "Rakefile", not "Rakefiles" (see examples at https://github.com/ruby/rake). This small change changes --rake to search the correct file name.

Whoops. Thanks!


[Bug]: When any text is discolored, it will destroy the entire color change

Issue validation

[X] I checked the issue to prevent duplicate
[X] I checked my configurations files and the documentation

Describe the bug

The above is normal, and the following words are highlighted by two words, and the whole change of color doesn't work
Hopefully, when the default format makes it red, I can still make special marks on specific words

How to reproduce ?
No response
Minimal Reproducible Example
“aaaaaaa”
Configuration
·

Relevant log output
No response
Anything else?
No response
OS
No response
Obsidian information
·

Plugin version
1.7.1

I dont think it's even possible to do it using my methods to add style :/.


Add Ref to the prelude

Objective
Add the change-detection wrapper type Ref<T> (originally added in #7097) to bevy_ecs::prelude.

Bors r+


Revise Database Schema

Make a database schema diagram and revise the datatables. You guys may want to work with the group doing the PostgreSQL setup. Current doc is missing data and relations between data.
How to design a DB schema
Datatables: https://docs.google.com/document/d/11OQiiVDpT07Rk-jz0VY7yVKsAjqZC_97wewZR32cw6w/edit?usp=sharing
Requirements Doc: https://docs.google.com/document/d/18cKMC2UKTrJQ41vIWskcPLfB5BslRLSvy8dxP_BHcI0/edit?usp=sharing

Pulling this back to in-progress while we work on the recommendations from dsgn for now