cleanup after 98616d5e

There are a lot of things that need to be cleaned up here, mostly having to do with documentation.

Three issues here:
* checking dependencies in R code ... WARNING
'library' or 'require' calls not declared from:
  ‘BHH2’ ‘openintro’
'library' or 'require' calls in package code:
  ‘BHH2’ ‘openintro’
  Please use :: or requireNamespace() instead.
  See section 'Suggested packages' in the 'Writing R Extensions' manual.

According to Hadley you're not supposed to use library or require in packages. Instead you're supposed to use @importFrom. I've added the latter, but is it safe to remove the offending calls?
* checking R code for possible problems ... NOTE
FTail: warning in axis(1, at = c(0, U), label = c(NA, round(U, 4))):
  partial argument match of 'label' to 'labels'
chiTail: warning in axis(1, at = c(0, U), label = c(NA, round(U, 4))):
  partial argument match of 'label' to 'labels'
inference: warning in pairwise.t.test(y, x, p.adj = "none"): partial
  argument match of 'p.adj' to 'p.adjust.method'
inference: no visible binding for global variable ‘COL’
inference: no visible binding for global variable ‘inf_lot’
inference: no visible binding for global variable ‘simulate.p.value’
inference: multiple local function definitions for ‘statistic’ with
  different formal arguments
normTail: no visible global function definition for ‘buildAxis’

These should be fixed.
* checking Rd contents ... WARNING
Argument items with no description in Rd object 'inference':
  ‘y’ ‘x’ ‘est’ ‘success’ ‘order’ ‘conflevel’ ‘siglevel’ ‘null’
  ‘alternative’ ‘type’ ‘method’ ‘simdist’ ‘nsim’ ‘seed’ ‘sum_stats’
  ‘eda_plot’ ‘inf_plot’ ‘inf_lines’

Argument items with no description in Rd object 'plot_ss':
  ‘x’ ‘y’ ‘showSquares’ ‘leastSquares’

This just means that these parameters need to be documented. I stubbed them out -- can someone else write the documentation?

I think those related to the inference function will be my to do

These should all be resolved with the update to the inference function


Release v0.13.0-rc1

Created release as per instructions in https://github.com/kserve/kserve/blob/master/release/RELEASE_PROCESS_v2.md
Note: https://github.com/kserve/kserve/pull/3700 is also cherrypicked to release branch

Pushed the changes.


Assemble Ground Truth light curve

We'll need to do a spatial association between our PhoSimSources and the DM CoaddSources, and then look up the photon counts for each PhoSimSource in each visit's PhoSim centroid file. These numbers of photons will then need converting into flux units, using the zero point for each visit image (the one that was used by DM during forced photometry). Where are these zero points stored? In the headers of the calibrated images that were the inputs to the ForcedPhotometry? In the ForcedSource catalog itself? (That would be nice).
Hey @jbkalmbach I'm not sure this a job for The Monitor, but do you want to look into this anyway?

@jbkalmbach @rbiswas4 We just decided that the spatial association of ForcedSources with PhoSim input sources by sky position is indeed a job for the Monitor, and Rahul is going to work on it over there. I guess to close this issue we'll need a Twinkles notebook that demonstrates the visualization of a Twinkles light curve including the reference, using the Monitor. Re-assigning to Rahul!

@SimonKrughoff just provided code in #217 - does this belong in the Monitor, @rbiswas4 ?


Concurrent queries on the same connection

Coming from Go here ... so have some preconceptions about the meaning of "connection" vs "query"
Im doing this in Zig, and experiencing this issue
my_db = db_pool.aquire();
orders = my_db.query("select id from orders", .{});
while (orders.next()) |row| {
   ... do stuff
   my_db.row("update some_other_table set field1=$1 where keyfield=$2", .{value1, value2});  // bad idea !!!
}

The re-use of the connection to launch another query, whilst the outer query is still being used == a bad idea
You can see that the 1st Parse msg emitted by the update statement returns a packet of type 'D' instead of '1' which suggests that the conversation between the outer query and the PG server is getting messed up with the inner query.
Simple enough fix on my side
outer_db = db_pool.aquire();  // outer query
inner_db = db.pool.acquire(); // update query
orders = outer_db.query("select id from orders", .{});
while (orders.next()) |row| {
   ... do stuff
  // use a separate connection for the update
  inner_db.row("update some_other_table set field1=$1 where keyfield=$2", .{value1, value2});
}

That's all good.  I don't know if that is the intention of how "connection" and "query" should be related in this lib ?
If so, then maybe return an error .ConnectionInUse or something similar ?
Personal preference from me would be to keep pg.zig as low level as possible, and put any ergonomic higher level trickery into a pgx.zig wrapper lib

Note that pipelining multiple operations over the same connection works fine, as long as the previous operation has completed before the next one starts.
outer_db = db_pool.aquire();  // outer query
inner_db = db.pool.acquire(); // update query
orders = outer_db.query("select id from orders", .{});
while (orders.next()) |row| {
   ... do stuff
  // pipeline multiple updates over the same inner_db connection
  inner_db.exec("update some_other_table set field1=$1 where keyfield=$2", .{value1, value2});
  inner_db.exec("insert into yet_other_table values ($1, $2, ...)", .{value1, value2});
  inner_db.row("delete from lock_table where keyfield=$1 returning keyfield", .{value1});
}

Again, keeping it low level allows the developer to make choices about re-using existing connections vs creating new ones.
The above code seems to have a pretty decent performance gain vs creating new connections on demand for example.

I made it return error.ConnectionBusy.  I don't think there's an alternative...I can't see how you could possibly have 2 concurrent queries on the same connection at the same time. Do you know a driver that actually allows this? I tried with Go's pgx and got an error, which is what I'd expect:
package main

import (
	"context"
	"fmt"

	"github.com/jackc/pgx/v5"
)

func main() {
	// urlExample := "postgres://username:password@localhost:5432/database_name"
	conn, err := pgx.Connect(context.Background(), "postgres://localhost:5432/postgres")
	if err != nil {
		panic(err)

	}
	defer conn.Close(context.Background())
	rows, err := conn.Query(context.Background(), "select 1 union all select 2")

	if err != nil {
		panic(err)
	}

	defer rows.Close()
	for rows.Next() {
		var id, t int
		rows.Scan(&id)
		fmt.Println(id)
		if err := conn.QueryRow(context.Background(), "select 3").Scan(&t); err != nil {
			panic(err)
		}
		fmt.Println(t)
	}
}

Ah yes, of course .. you a right.
im porting from sqlx code, where the select() call slurps the entire result into a slice of strict. So underneath that call, it is reading every row from the original query .. and the range statement loops over the results, not the query result.
my bad .. I should have looked closer :(

No problem. I think the added explicit ConnectionBusy error is a good addition!

For what it’s worth… there is a daily batch jib in prod now using this lib in anger on some financial data, patching info together from 3 separate db servers with 3 different versions of Postgres running.
good real world test


Generating proxy and handler of same interface

I'm trying to use the Tmds.DBus.SourceGenerator to write a Linux Bluetooth client application that is using the Bluez advertisement monitoring API. For this use-case, I need proxy access to the org.freedesktop.DBus.ObjectManager interface on the Bluez side, and also implement an org.freedesktop.DBus.ObjectManager handler interface on my side.
I haven't found a way to accomplish this. Is it possible?

With https://github.com/affederaffe/Tmds.DBus.SourceGenerator/commit/7afb782ee12993d7a0b1923f50239a572554e985, you should be able to simply declare one AdditionalFiles as Handler and another as proxy.

The fix in question is included in the new 0.0.20 release.


fix: prefer tfsec-bin AUR package

Building from the sources is not the preferred way and tfsec-bin uses the binary provided by this project (and checks the signature)

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=tfsec
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=tfsec-bin

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @greut - is it possible for you to add me as a maintainer?

Of course.  On Thu, Jun 16, 2022 at 18:17, Liam Galvin @.***> wrote:
Thanks @greut - is it possible for you to add me as a maintainer?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@liamg I gave a look at https://goreleaser.com/customization/aur/ but it doesn't seem to be applicable straight away.
https://aur.archlinux.org/packages/tfsec-bin is done, https://aur.archlinux.org/packages/tfsec will have to wait for the actual maintainer to answer my request :)
Happy packaging!

@liamg fyi https://github.com/arch4edu/aur-auto-update/pull/16


add the maven interceptors parent path as well......

Trying to push a release for maven-interceptors and got this issue
[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.6:deploy (default-deploy) on project maven-modules: Failed to deploy artifacts: Could not transfer artifact org.jenkins-ci.main.maven:maven-modules:pom:1.9 from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): Access denied to: https://repo.jenkins-ci.org/releases/org/jenkins-ci/main/maven/maven-modules/1.9/maven-modules-1.9.pom, ReasonPhrase: Forbidden. -> [Help 1]
[INFO] [ERROR]

+1

Change https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/pom-maven-modules.yml instead please.

but @olamy is in https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/pom-maven-modules.yml

Weird. @olamy Could you retry (possibly with a new version as this one might have been burnt)? I only have 6 hours of Artifactory logs and no occurrence of maven-modules.

weird it's here already http://repo.jenkins-ci.org/public/org/jenkins-ci/main/maven/maven-modules/1.9/ ..
Ok I will use different version number....

I suspect that pom-maven-modules.yml was the wrong name, or we need both that and component-maven-modules.yml, though I am not sure what the pom nomenclature means in practice.

though I am not sure what the pom nomenclature means in practice

Nothing other than keeping order. Just needs the .yml extension and it gets processed. https://github.com/jenkins-infra/repository-permissions-updater/blob/0838d68aa51a16a5fd5a59a89d397d68c98c1a4c/src/main/groovy/io/jenkins/infra/repository_permissions_updater/ArtifactoryPermissionsUpdater.groovy#L122

Finally worked.....
but oh grhhhhhhh when not an issue with artifactory an other problem....
failed again because of the new modules which doesn't have permissions files..
What a pain!!!!
Anyway to implement * in the path?
see #332

closing as nothing more to be done here.

Anyway to implement * in the path?

I am not actually sure that wouldn't work. We should be able to have a name and path of maven*-agent AFAICT.


Thread safe app info map

Added thread-locks around the usage of app_info_map and other instance variables.

OCD run https://ocd.appscale.com:8080/job/Daily Build/1851/

ocd run https://ocd.appscale.com:8080/job/Daily Build/1859/


for japanese

ja: {
// Japanese
newsFeedPosts: "News Feed posts",
reelsBlock: "リールとショート動画",
commentedOn: " commented on a post from ",
peopleKnow: "People You May Know",
suggested: ">Suggested for you<",
},

v1.21.3

Thank you.
But it did not work only this apply.
Reels line does not disapplear.

@warpkwd v1.25.3 will fix this :)


Template_type missing issue

It seems that all Event is having issues passing the template type.
02:29:15.738 ERROR [main][NetworkUtils] HTTP connection failed with error code 400.
02:29:15.739 ERROR [main][NetworkUtils] Error message from Facebook. Message: [(#100) Missing template_type for attachment's payload], Code: [100], Type: [OAuthException], FbTraceID: [DtlNZ2Ig9GY].
Sent!

Tested this with:

List Template
Generic Template
Button Template

Please take a look.

Fixed now. It seems that the issue was my test. I got two message event with the same text message. The chain fails entirely because of this.

Nope, this was a real issue. The problem was the custom deserializer that I've introduced yesterday that somehow messed up with the serialization as well. It would only affect the outcoming messages with a payload (templates but not the text-only messages). I've fixed it with cc798fee3b3c4ead1e48a0bc8ce44eaa5207bb77 along with some minor bugs on the buttons.


makefiles for MPI are broken

Summary:
When enabling MPI, the models are not build with MPI support.
Description:
The STAN_MPI (and other MPI settings) are not propagated to the compiler and linker when models are build whenever MPI is turned on. Everything works ok for tests, though.
Reproducible Steps:
Put
CXX=mpicxx
STAN_MPI=true

into make/local. Then build cmdstan and then try to build the bernoulli example... the compilation command won't contain a -DSTAN_MPI argument such that MPI is not turned on.
Current Output:
Like I say... MPI flags don't make it to models which are to be compiled which should be the case.
Expected Output:
The MPI flags should be propagated to the compiler whenever the user turns on MPI.
(@syclik the makefile refactor appears to take a moment, so consider this as a quick fix to go in quickly to make things work for a potential short-notice release).
Additional Information:
Provide any additional information here.
Current Version:
v2.18.0

@wds15, is this still a problem?

This is fixed by now. Thanks for the laundry.


ArgumentException with wrong arguments order

There are some ArgumentException being constructed with the arguments in the wrong order:
Example:
throw LogHelper.LogExceptionMessage(new ArgumentException(nameof(algorithm), string.Format(CultureInfo.InvariantCulture, LogMessages.IDX10652, algorithm)));
Should be:
throw LogHelper.LogExceptionMessage(new ArgumentException( string.Format(CultureInfo.InvariantCulture, LogMessages.IDX10652, algorithm), nameof(algorithm)));
This obviously leads to the exception's message and parameter name to be wrong and, consequently, precious debugging time being wasted.
Found 7 occurrences of these. I've fixed them here just not sure if I'm free to open a PR with it.

@joaope thanks. Will get this in the April release. Most likely in a nightly before than. We will do a scrub and see what else we can find.

@lovemaths just fix the order of the params so the error is correct


punycode deprecated; psl and tough-cookie packages causing issues

Issue
Looks like the punycode module, used in the dependencies psl and tough-cookie are deprecated, causing the wizard and package to fail.
Recreate

Attempt to run following instructions $ npx wordpress-to-markdown produces error:

(node:5946) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Investigation

$ npm install wordpress-to-markdown
Add to package json the --trace-deprecation flag

{
  "dependencies": {
    "wordpress-export-to-markdown": "^2.3.7"
  },
  "scripts": {
    "trace": "NODE_OPTIONS='--trace-deprecation' wordpress-export-to-markdown"
  },
}

$ npm run trace shows me there is an issue with psl package, and when I fix, also with tough-cookie package.

Temporary fix to get to run
Add a trailing forward to slash to two files;

./node_modules/psl/index.js
Change line 5, from:
var Punycode = require('punycode');
to
var Punycode = require('punycode/');

./node_modules/tough-cookie/lib/cookie.js
Change line 43, from:
punycode = require('punycode');
to
punycode = require('punycode/');

Following these changes, the package works.
Thoughts
Looks like both psl and tough-cookie packages need updating, patches need to be made, or alternative dependencies are required.
Until then, these temporary fixes got it working for me.
P.S. Thanks @lonekorean for sharing your work!

Using:
wordpress-export-tomarkdown 2.3.7
macOS Sonoma 14.5
node 22.2.0
npm 10.7.0

Hi @tarihala, thanks for bringing this to my attention and digging into it!
That scary looking deprecation warning is a downstream result of me using this deprecated package. I knew that one day it would cause a problem. Looks like today is that day. 😄
I ripped it out and replaced it with a different package and updated some code. If you have time, can try running it again with this branch?
Should be able to just:
git fetch
git checkout deprecation-fix
npm install

Then run as before.
I'll merge and release a new version soon, but would make me feel better to know it runs smoothly on your computer.

@lonekorean that was fast!
Looks great! Works fine on my computer and with my export.xml file. Nice work! 🎸

Awesome, fix released in v2.4.0. Closing this out, thank you!


Typo " [@failover_mode=] "→" [ @failover_mode= ] "

https://docs.microsoft.com/en-us/sql/relational-databases/system-stored-procedures/sp-helpreplfailovermode-transact-sql?view=sql-server-ver15
related: #3157

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the update.


Remove unnecessary markdown files

The markdown files will be auto-generated on each PR merge to main. They aren't necessary in the repo

@SiddarGu could you run pre commit by any chance? If not I can make a branch from this and do a new pr.

@SiddarGu could you run pre commit by any chance? If not I can make a branch from this and do a new pr.

Go ahead please. I tested positive for covid and feel very sick. :(

@SiddarGu could you run pre commit by any chance? If not I can make a branch from this and do a new pr.

Go ahead please. I tested positive for covid and feel very sick. :(

Ah jeez that sucks, hope you feel better soon. Appreciate the PR.


Unique parameter

I have made things!

[x] I have created at least one test case for the changes I have made

[x] I have updated the documentation for the changes I have made

[x] I have added my changes to the CHANGELOG.rst

Related issues
Format is:

Closes #561
Refs #561

I have added the unique parameter to the functions username(), email() and telephone().
Before merge this pull request ... @lk-geimfari do you think that there are other functions (also from other providers) that need the unique parameter?

@ceccoemi Current implementation does not cover cases when unique values exhausted. This problem is more complicated than you think, please take a look at comments in #608.
It must return only unique values and raise an exception when such values exhausted.

@lk-geimfari I misunderstood the specifications. I'm sorry, I wil continue to work on it.


test-branch/execute-job/wrong-commit-sha-on-pr/42286d18-48c1-498d-9398-a8d45ecfc6db

PR for testing 4c7fd9c9571a6ddfd1d096772dc8e2471465223a

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


td-chips required is missing

Hi,
Can you add the parameter "required" to td-chips?
I can use color and put it to warn. It s nice when the user got the focus on it, but when the component losts the focus, it becomes normal again.
Moreover, the '*' is missing.
Thanks for your help

Thanks :)


Updated getting started doc

WIP
Updated getting started doc, as part of content restructuring mentioned in #2627. View the doc here.

Codecov Report

Merging #2698 (0f603fd) into main (fec10eb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2698   +/-   ##
=======================================
  Coverage   81.15%   81.15%
=======================================
  Files          51       51
  Lines        5493     5493
=======================================
  Hits         4458     4458
  Misses       1035     1035

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks for the suggestions @cgarciae @8bitmp3! I made some updated changes.


Changing the About in the repo

@mgold1234 Can you please change it (needs owner permissions)

What would you like to be the description of the repository?

"A friendly app for manage and control tasks"
what do you think?

Done. If you want to change the description, open a new issue.


Unify IPA/KZG interfaces

From https://github.com/AztecProtocol/barretenberg/pull/31#pullrequestreview-1240637105: methods should be added that batch prove and batch verify multiple polynomial commitments.

For now, we don't need batching since that can be handled by the prover as a previous step. (In a similar way batching is handled by Gemini).
If we want to use IPA as a drop in replacement for KZG, then we only need to open a single polynomial since Shplonk handles batching.
However, it would be good to accept the OpeningClaim type as input to unify the interface with KZG.

duplicate of #236

closed by #445


Fixed no-raw-text rule for typescript

fixed rule for @typescript-eslint/parser
added @typescript-eslint/parser as devDependency
added .DS_Store to .gitignore

This PR fixes https://github.com/Intellicode/eslint-plugin-react-native/issues/208 and https://github.com/Intellicode/eslint-plugin-react-native/issues/210 issues

Coverage decreased (-0.1%) to 75.0% when pulling 6b5d67a07d2c31d2f09f39373d772bd532b557d5 on AleksandrZhukov:master into 89c3a11ce9e520bfae5e846c9dbe329d4413dd2f on Intellicode:master.

Coverage decreased (-0.1%) to 75.0% when pulling 6b5d67a07d2c31d2f09f39373d772bd532b557d5 on AleksandrZhukov:master into 89c3a11ce9e520bfae5e846c9dbe329d4413dd2f on Intellicode:master.

🎉

How long is typical for a review and merge of a PR like this?

I don't know, seems need to ask @Intellicode 🙏

Thanks for your PR, I'm not very familiar with the use case of typescript and eslint, can you explain a little bit about the dev dependencies @AleksandrZhukov?

@Intellicode I'm also not very familiar with typescript, but seems typescript-eslint/parser make little bit different AST from basic eslint parser. You can try to use another parser here https://astexplorer.net to check the difference. I've added typescript and typescript-eslint/parser dependencies to cover no-raw-text rule with tests.

@AleksandrZhukov alright, seems the other eslint react plugin has it as well, so lets go for it :)


JSON File Support

Issue type:
Feature request
I'd like to add support for JSON log files.  What are your feelings about this?

@martin-helmich What do you think?

Hey @kadaan, sorry for the late response! I would most certainly be willing to accept PRs for this. :+1:
However, I fear that some refactoring might be necessary beforehand; basically we'd need to replace most usages of *gonx.Parser (which is what does the actual line-by-line-parsing at the moment) with a more generic interface (which might then be implemented by a gonx-backed parser, or a JSON parser).

how about separate the consul's config to a standalone file? which I mean is that as consul's registration support http with json format, and don't need to do some stuff  in this project again......

how about separate the consul's config to a standalone file? which I mean is that as consul's registration support http with json format, and don't need to do some stuff in this project again......thx@martin-helmich

Sorry, what? I honestly don't understand what you mean, at all. 😕 In any case, this issue was about ingesting JSON log data, not about the configuration settings. If you are suggesting a change in the configuration file format (?), please open a new issue (and elaborate a bit, please 😉).

ok. sorry for that. yes, I'm talking about config file format(consul config's separation).
------------------ 原始邮件 ------------------
发件人: "Martin<EMAIL_ADDRESS>发送时间: 2020年5月7日(星期四) 晚上9:30
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [martin-helmich/prometheus-nginxlog-exporter] JSON File Support (#93)
how about separate the consul's config to a standalone file? which I mean is that as consul's registration support http with json format, and don't need to do some stuff in this project again......thx@martin-helmich
Sorry, what? I honestly don't understand what you mean, at all.  In any case, this issue was about ingesting JSON log data, not about the configuration settings. If you are suggesting a change in the configuration file format (?), please open a new issue (and elaborate a bit, please ).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

This should not have been closed. Still happy to accept PRs for this one.

Hello, @martin-helmich. I'm facing this problem. Our Nginx prints log in json format so that it's convenient to collect the log file by filebeat and inject it into ES. When using the exporter, I print another log in plain text format. It's a little bit verbose. I want to do this job to support json format logs. I think for extensibility, we'd better make the parser an interface having different implementations, for now they are textparser and jsonparser. What's your opinion? Could I do the job?

I have finished writing the code. I add a parser package, define an Parser interface and two implementations TextParser and JsonParser. I add a new NamespaceConfig options named Parser, it is assigned by a new “-parse” flag. I try to minimize the number of changed lines and keep backward compatibility. Can we ship go version in the dockerfile to 1.13+? I want to use wrapping errors. If you think the design is OK, I will open a PR.
package parser
// Parser parses a line of log as a map[string]string.
type Parser interface {
	ParseString(line string) (map[string]string, error)
}

// NewParser returns a Parser with the given config.NamespaceConfig
func NewParser(nsCfg config.NamespaceConfig) Parser {
	switch nsCfg.Parser {
	case "text":
		return textparser.NewTextParser(nsCfg.Format)
	case "json":
		return jsonparser.NewJsonParser()
	default:
		return textparser.NewTextParser(nsCfg.Format)
	}
}

package textparser
/ TextParser parses variables patterns using config.NamespaceConfig.Format.
type TextParser struct {
	format string
}

// NewTextParser returns a new text parser.
func NewTextParser(format string) *TextParser {
	return &TextParser{
		format: format,
	}
}

// ParseString implements the Parser interface.
func (t *TextParser) ParseString(line string) (map[string]string, error) {
	parser := gonx.NewParser(t.format)
	entry, err := parser.ParseString(line)
	if err != nil {
		return nil, fmt.Errorf("text log parsing err: %w", err)
	}

	return entry.Fields(), nil
}

package jsonparser
// JsonParser parses variables patterns using config.NamespaceConfig.Format.
type JsonParser struct{}

// NewTextParser returns a new json parser.
func NewJsonParser() *JsonParser {
	return &JsonParser{}
}

// ParseString implements the Parser interface.
// Values of the map may not be a string, so it needs to be converted.
func (j *JsonParser) ParseString(line string) (map[string]string, error) {
	var parsed map[string]interface{}
	err := json.Unmarshal([]byte(line), &parsed)
	if err != nil {
		return nil, fmt.Errorf("json log parsing err: %w", err)
	}

	fields := make(map[string]string, len(parsed))
	for k, v := range parsed {
		fields[k] = fmt.Sprintf("%v", v)
	}
	return fields, nil
}

Hey @yngwiewang! :wave: Thanks for your work on this, I really like the design. You're welcome to open a PR for this change, and we'll get it merged. And yes, wrapping errors seems like a sensible idea to me as well, and I'd be fine with bumping the Go version. :+1:

Hi, @martin-helmich! 😃Thank you for your approval, it really encouraged me. I have open a PR, please review it. Expecting it to be merged. I optimized the TestParser struct and did a benchmark, TestParser is about twice faster than JsonParser. If we can restrict the data type of the log field, we could use easyjson to make the JsonParser faster. Maybe we can discuss this issue later, please let me know if you have any opinion regarding this. I'm documenting the JSON parser function in the README file, it will take a few days.


Hackaweek: Filter findings and stats by a list of identifiers

Implements a new query parameter filter in the folowing endpoints:

stats/open
findings
issues/summary
targets/summary

This query parameter will be named identifiers and will accept a list of asset identifiers, separated by a comma.
Example :
&identifiers=adevinta.com,example.com

@julianvilas You are right, I will add the design files.


DO NOT MERGE - Moves gitter room to the new organization

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is n/a.


Search SDK: Removing version number from HowTo article

Removing the specific version since it's easy for it to get out of sync when we ship minor bug fix updates to the SDK. Users can always find the latest version on NuGet anyway.

Hi @brjohnstmsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (brjohnst). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Crash on import

I just upgraded to 1.3.12  and when trying to import it crashes and I'm not sure why 1.3.11 worked just fine.
three80@snubnose:~$ beet imp music
Traceback (most recent call last):
File "/usr/local/bin/beet", line 9, in
load_entry_point('beets==1.3.12', 'console_scripts', 'beet')()
File "/usr/local/lib/python2.7/dist-packages/beets/ui/init.py", line 1104, in main
_raw_main(args)
File "/usr/local/lib/python2.7/dist-packages/beets/ui/init.py", line 1094, in _raw_main
subcommand.func(lib, suboptions, subargs)
File "/usr/local/lib/python2.7/dist-packages/beets/ui/commands.py", line 893, in import_func
import_files(lib, paths, query)
File "/usr/local/lib/python2.7/dist-packages/beets/ui/commands.py", line 870, in import_files
session.run()
File "/usr/local/lib/python2.7/dist-packages/beets/importer.py", line 316, in run
pl.run_parallel(QUEUE_SIZE)
File "/usr/local/lib/python2.7/dist-packages/beets/util/pipeline.py", line 301, in run
out = self.coro.send(msg)
File "/usr/local/lib/python2.7/dist-packages/beets/util/pipeline.py", line 183, in coro
func(*(args + (task,)))
File "/usr/local/lib/python2.7/dist-packages/beets/importer.py", line 1236, in lookup_candidates
task.lookup_candidates()
File "/usr/local/lib/python2.7/dist-packages/beets/importer.py", line 567, in lookup_candidates
autotag.tag_album(self.items)
File "/usr/local/lib/python2.7/dist-packages/beets/autotag/match.py", line 437, in tag_album
_add_candidate(items, candidates, info)
File "/usr/local/lib/python2.7/dist-packages/beets/autotag/match.py", line 354, in _add_candidate
mapping, extra_items, extra_tracks = assign_items(items, info.tracks)
File "/usr/local/lib/python2.7/dist-packages/beets/autotag/match.py", line 94, in assign_items
row.append(track_distance(item, track))
File "/usr/local/lib/python2.7/dist-packages/beets/autotag/match.py", line 131, in track_distance
dist.add_string('track_title', item.title, track_info.title)
File "/usr/local/lib/python2.7/dist-packages/beets/autotag/hooks.py", line 493, in add_string
dist = string_dist(str1, str2)
File "/usr/local/lib/python2.7/dist-packages/beets/autotag/hooks.py", line 246, in string_dist
base_dist = _string_dist_basic(str1, str2)
File "/usr/local/lib/python2.7/dist-packages/beets/autotag/hooks.py", line 212, in _string_dist_basic
return levenshtein_distance(str1, str2) / float(max(len(str1), len(str2)))
TypeError: expected unicode, got str
I get this on any folder I try and like I said 1.3.11 was working.
Edit: forgot some info
three80@snubnose:~$ beet version
beets version 1.3.12
plugins: alternatives, chroma, convert, duplicates, embedart, fetchart, fromfilename, info, inline, lastgenre, lyrics, mbsync, missing, play, random, replaygain, rewrite, scrub, zero
config: http://pastebin.com/dSFT6EqT
running beets with -vv : http://pastebin.com/yzjiscFN

Thanks for the report. This just appeared the other day due to a broken dependency update, and I fixed it here: https://github.com/sampsyo/beets/commit/0e3f6cb09dfc10f813feae861fa41d942ca77290
I'm going to push out a hot-fix release now.


files: CreateFile adds backwards-compatible io.Reader input, Purpose const

This PR supersedes #577 coincidentally.
Describe the change
I have re-implemented FileRequest and CreateFile so as to support arbitrary io.Reader inputs which must have priority over FilePath and also fixed some errors in the implementation. I've also took the liberty of adding a Purpose enum and testing for it, as fine-tuning requires a particular file format. Perhaps it's worthwhile getting rid of CreateFormFile semantics altogether at some later stage as it's, frankly, short-sighted and embarrassing. Thankfully, it hasn't touched the API boundary.
Also: I've made some other adjustments in streaming API that have not been included part of this PR. I'm eager to hear feedback on this commit as it's implementing "teeing" of streaming response so as to make proxying so much easier. I reckon a great deal of go-openai use cases will revolve around proxying, in fact that's our primary use-case & if you're supposed to forward the response as well as parse it, then this type of change will be very favourable. My implementation takes advantage of io.Pipe and io.TeeReader and hence the server code is quite straightforward:
// passthrough is re-directing the output of tee buffer
func passthrough(c *fiber.Ctx, r io.Reader) error {
	var ctx = c.Context()
	ctx.SetContentType("text/event-stream")
	ctx.Response.Header.Set("Cache-Control", "no-cache")
	ctx.Response.Header.Set("Connection", "keep-alive")
	ctx.Response.Header.Set("Transfer-Encoding", "chunked")
	ctx.Response.Header.Set("Access-Control-Allow-Origin", "*")
	ctx.Response.Header.Set("Access-Control-Allow-Headers", "Cache-Control")
	ctx.Response.Header.Set("Access-Control-Allow-Credentials", "true")
	ctx.SetBodyStreamWriter(fasthttp.StreamWriter(func(w *bufio.Writer) {
		io.Copy(w, r)
		w.Flush()
	}))
	return nil
}

//v1/completions
func completions(c *fiber.Ctx) error {
	var req openai.CompletionRequest
	api, err := parseRequest(c, &req)
	if err != nil {
		return err
	}
	if req.Stream {
		stream, err := api.CreateCompletionStream(ctx, req)
		if err != nil {
			return err
		}
		tee := stream.Tee()
		go func() {
			defer stream.Close()
			defer tee.Close()
			for chunk, err := stream.Recv(); err != io.EOF; {
				if err != nil {
					api.Errorln(err)
					return
				}
				// process streaming chunk normally...
			}
		}()
		return passthrough(c, tee)
	}
	resp, err := api.CreateCompletion(ctx, req)
	if err != nil {
		return err
	}
	return c.JSON(resp)
}

I've also learnt about #568 which (to my shock and regret) has been merged a few days earlier, unfortunately I had missed the commit in my tree at the time of drafting this PR. @sashabaranov please consider reviewing/re-evaluating the API surface, as it seems the changes are very fresh, and there's time still to nip it in the bud.  I've made a similar mistake, and I wasn't as lucky as you are now.

Hey @tucnak.  Author of #568 here.  Agree with your feedback that perhaps more design thinking should go into API design.  On that note, why not go further and remove the FileName and FilePath and only allow a io.Reader?   Personally not a huge fan of "you must set one or the other".  One could go further and separate out files uploads for fine tuning as well which you point out has different format requirements.  (Though I'd hesitate to assume having the correct file extension means it is formatted properly.)
Anyway, we can probably agree that these issues could be better resolved in a more thorough design phase facilitated by the contributors.  The downside of which is slower iteration of the library.  Which is worse?  Less than idea API or slower development?  My vote is the latter.

@floodfx Thanks for feedback! I'd originally chose to keep FileName and FilePath for compatibility so that my change doesn't break any existing code. I'm not the maintainer, and don't otherwise care for the API design, for the most part I'm simply trying to protect my fork from upstream, and it seems like integrating changes like this would likely make our lives easier along the road...

Oh yeah, I get why you kept the existing properties.  I added a new func so I wouldn't break existing code.  Both valid solutions. :) My larger point is the maintainers could have a bit of a heavier hand or at least a perspective on generally the approach they want folks like us to take and then we could all follow that.


Some GitAPITestCase tests were replaced in GitClientTest

JENKINS-60940 - Tests were added to GItClientTest
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have referenced the Jira issue related to my changes in one or more commit messages
[x] I have added tests that verify my changes
[x] Unit tests pass locally with my changes
[x] I have added documentation as necessary
[x] No Javadoc warnings were introduced with my changes
[x] No spotbugs warnings were introduced with my changes
[x] I have interactively tested my changes

Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply

[x] Infrastructure change (non-breaking change which updates dependencies or improves infrastructure)

Further comments
Junit 3 tests can be sorted according to alphabet order in GitAPITestCase and compared with GItClientTestCases. It would be an efficient idea to change the tests to Junit 4.

This looks great!  Thanks very much @Loghijiaha


Client Allocation Request for: Jack Li

Client Allocation Questions
Core Information

Name: Jack Li
Website / Social Media: https://studiosupreme.be/
Region: North America
DataCap Requested: 100TiB
Addresses to be Notarized: f3rcoh2zxhodwhvkyf3m2a5ivmlvxfxmf2gsg22rtbxgkom44ci4nj6kqo56fo4eryeq45vtsalhvdehptds5q
Notary Requested: Schwartz10,glifio

@futuremaster777 Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

All 37 applications by this have been closed and this account is flagged for potential abuse of the system.


Implement support for custom landing page

As a a result of the design work we figured out the current "new" homepage will eventually replace the current layers, documents, maps and apps list pages in GeoNode. It will perform a dual function: the primary view of the entire catalogue and the user workspace where quick actions on the user datasets can be performed.
Instead of striving to make this page highly customizable, we should change our mindset and consider this page the default landing page IF a custom home page is not configured. A custom home page can be whatever we want: a static HTML file, a Django template, whatever the customer wants for his landing page.
This means that GeoNode should check if a home page has been configured, otherwise it will directly show the catalogue view (let's rename the current home page this way).
This translates into having:

a way to configure the home page view, with a fallback mechanism on the catalogue view
assign a specific URL to the catalogue view so that, if a home page is available, the twos will have distinct paths

wontdo


Remove some DisplayServer::mouse_get_position calls

These functions can get called in situations, where there is no reasonable DisplayServer available (e.g. XR or Gui-in-3D Demo). This PR introduces Viewport::get_embedder_mouse_position() which verifies if DisplayServer::mouse_get_position can get called.
part of #77189

[X] ColorPicker (no change required)
[X] EditorTitleBar (use get_embedder_mouse_position)
[X] MenuBar (rely on local coordinates)
[X] MenuButton (rely on local coordinates)
[X] PopupMenu::_notification (use get_embedder_mouse_position)
[X] PopupMenu::_parent_focused (use get_embedder_mouse_position)

I believe, that with the latest change, this PR makes all calls of DisplayServer::mouse_get_position safe.

This PR fixes #86240.

This PR got partially superseded by #86304.
I have updated the PR to remove the changes, that were merged into master by the other PR.


Mica effect lost after horizontal window resize

Whenever I resize an explorer window, or maximize/restore, the mica effect/acrylic effect/tabbed effect vanishes for the window in question permanently. The same happens, if the window is moved to another screen.

resize is quite specific, as the bug only appears when changing the window size horizontally, i.e. by dragging left or right edge, or any corner.
likewise, the maximize bug only appears when using the maximize button in the top, or when double-clicking the titlebar. If just the top edge is double-clicked, the mica effect remains.

See attached screenshots for comparison.

mica apllied

after window resize

I see no problems on my side.

That's strange. On my side, the problem persists regardless of applied style. Just to be sure, these are my versions:
    Mica For Everyone <IP_ADDRESS>
    Windows  11 (Enterprise), Version 22H2 22621.674

It says it's version <IP_ADDRESS> in the app, but I reinstalled it and I am sure it was the Setup from the release <IP_ADDRESS>. It also says <IP_ADDRESS> in appwiz.cpl.

They're both same version just the build system is updated so i didn't bump the version.

That's strange. On my side, the problem persists regardless of applied style.

It doesn't matter if you have this problem or not. It has nothing to do with MFE, it can be from Explorer and we can do nothing about it.

I am sorry to bother you, and please forgive me, if I come over as rude from lack of knowledge.
I am, on the other hand, not convinced that this is not a bug on the MFE side. After all, MFE does not work as intended in my case, while every other program does work as intended. It may well be, that on my system this behaviour is due to other software and conflicts, but I feel this is a premature conclusion.
Over all, I observed unexpected behaviour with MFE, I reported it, and I provide any desired assistance, should you or any other developer decide to investigate this.

I am, on the other hand, not convinced that this is not a bug on the MFE side.

MFE doesn't hook in to processes to render effects, the feature is already in the Windows and MFE just enables it for every window you open. It's not MFE's fault if an app changes these effects itself or an app is not getting rendered properly.

Btw, are you talking about Extending Frame Into Client Area or the Backdrop Type?

 In the first case, the whole background is affected, in the second, only titlebar/ribbon/navigation.
Also, I have updated the links in my original report: the second link (not the thumbnail) was pointing to the wrong image.
I am looking into all my shell extensions as well, but can you clarify: Does this unexpected behaviour happen on my setup only? Or is this actually expected?

I can't say for sure. On my machine running 22623.746, File Explorer doesn't unexpectedly change the backdrop.

I had to reinstall MFE after a windows update, and this time, I used the msixbundle installer of MFE (v<IP_ADDRESS>, same version as before). I cannot say at this point, if it was the installer, or the updated windows version (now: 22621.755), but the bug no longer persists for me.
I cannot contribute more at this point, and since it was a very rare bug/odd behaviour anyway, you may as well close this issue.

Probably the update. There is almost no difference in the MSIX compared to the portable builds except for the folder where the configuration file is stored.


Annotations for CustomXXX doesn't support custom parameters

There is possibility to introduce new annotation type ParametersAnnotation which will be marker of annotation representing parameters for some CustomXXX. In this issue consider the support of parameters for custom generators, providers, populators, etc.

There has to be introduced new marker annotation @CustomParameters which will marks the anotation with custom parameters for CustomXXX classes. The annotation will have parameter which specifies with which custom annotation are linked. Also has to be adjusted the CustomXXX annotations.

Custom generators, class providers, populators, ... was refactored.


TransferUtility class does not have permission setting option for uploaded file.

new TransferUtility class does not have upload() constructor which support PutObjectRequest so that I can set public read permission to the uploaded file.
There is only one upload method upload(bucket, path, file) which don't have any file permission setting.

Hi aks,
What exactly do you mean about file permissions?  Do you mean access permissions for the object on S3?  If so have you considered looking at bucket permissions or the IAM role associated with the Cognito Identity Pool if you are using one?
Thanks,
Weston

I am not talking about bucket permissions, I am taking about individual upload file permission using CannedAccessControlList using new TransferUtility class.
It was possible using old TransferManager class but it is now deprecated. @wdane

@aks0020 You can probably use IAM policies to accomplish the same task.  If you look at http://blogs.aws.amazon.com/security/post/TxPOJBY6FE360K/IAM-policies-and-Bucket-Policies-and-ACLs-Oh-My-Controlling-Access-to-S3-Resource you can see how you could get up an IAM policy to either set a specific bucket as global read (or whatever you'd like to do) or use a specific bucket key pre-fix to do the same.  For example myBucket/global/read/YOUR_OBJECTS
Let me know if this doesn't work for you or is giving you trouble.
Weston

Closing for now, feel free to re-open if needed.


[Question] [Help Needed] Issue on configuring with cognito userpool

Clarification needed section 3, step 2 in the readme file. What's the exact file destination to add those Cognito Userpool Appclient id, client id and region?
I first asked at gitter chat room [1] (4 days before) and then put a question on the group [2], unluckily no any responses received so far.
[1] https://gitter.im/99xt/interns-portal
[2] https://groups.google.com/forum/#!topic/99xt/c7E4UtRD8ns
Thanks

Hi @AMFIRNAS . sorry for the delayed response. Did you go through our Cognito Userpool boilerplate on setting up the cognito environment.

can you specifically tell me the places you have issues on configuring Cognito?


Add missing PHP wrapper "bzip2"

Description
Relates to N330BFLK
Associated PR: #2723

Rule 933200 protects against a variety of built-in PHP wrappers, like
zip://
zlib://
but we don't currently catch
bzip2://
Also, 933200 can be decompiled into a .data file.

[x] Decompile 933200
[x] Add bzip2
[x] Add a bzip2 test for rule 933200

PR approved and merged. Closing issue.


Error during npm run build

After I npm installed everything, when running npm run build, this error gets thrown:
Error: Cannot find module 'rxmarbles/app-view' from 'mylocalpath/rxmarbles/ignore/es5src'

When running npm run preinstall and then npm run build again, I get this error:
Error: Cannot find module 'cyclejs' from 'mylocalpath/rxmarbles/ignore/es5src'

I encountered a similar issue when trying to start up the app:
><EMAIL_ADDRESS>preinstall .../side-projects/rxmarbles
> rm -rf build && rm -rf node_modules && mkdir -p ignore/es5src

><EMAIL_ADDRESS>postinstall .../side-projects/rxmarbles
> ln -s ../ignore/es5src node_modules/rxmarbles && ln -s ../package.json node_modules/package.json

ln: node_modules/rxmarbles: No such file or directory

So I tried it after removing the rm -rf build && rm -rf node_modules part of the preinstall script because it wasn't saving the node_modules folder. This then installed fine. But after running npm run build I then got this error:
> browserify -e ignore/es5src/app.js --outfile dist/js/app.js

Error: Cannot find module<EMAIL_ADDRESS>from '.../side-projects/rxmarbles/node_modules/rxmarbles'

Is that an issue with the symbolic linking? I'm not familiar with how that is supposed to work so while I'd like to try and resolve it (I'm really keen to find a way to contribute to the project) I might need a few pointers for how to approach this. Maybe it's something else beyong my knowledge that's causing the issue however.
Anyway if anyone has a suggestion for how I could approach getting this going I would appreciate any tips. I found playing with the marbles really helpful for learning about observable streams so I really want to help out.

Not sure what a "correct" solution for this is, but you can brute-force it by running "npm install" from within 'node_modules/@cycle' directory.

Thanks for that @pbadenski - I had to also run npm install from within the node_modules/@cycle/core directory too - but it's all going now. I also updated my node version but I don't think that would have made a difference.


Optional Enum with Single value?

A parameter that is an enum that has a single value should be implemented as a switch parameter.

This can be done in the cmdlet class generator, add a check to see if there is a single value in the enum and switch to generating a switch.
foo:
  type: string
  enum: ['system assigned']

when that is optional the only two states are add the value or nothing...

We will not support this considering users may add more values to single value enum.


Add automatic-module-name to manifest jar

This is it be able to properly use the library in a modularized environment.
Ref: http://branchandbound.net/blog/java/2017/12/automatic-module-name/

Thanks for raising this issue, I'll pay attention to it during the next release.


Powershell command wrappers to make argument passing to knife/chef-client etc. easier.

Make argument parsing into ruby/chef binaries easier.

/cc @btm @jdmundrawala
Please cc chef-client-core.

It doesn't appear to actually wrap the commands to fix the issue https://github.com/chef/chef/issues/1687

Ok, I think I have another version which handles that case.  It doesn't handle pipeline objects yet.  I'll do that in a second pass.

This looks fine to me, however we might want to consider automatically generating these for all ruby bins. See https://github.com/chef/omnibus-chef/blob/master/config/software/shebang-cleanup.rb
:+1:

Yes that'd definitely be optimal.  I went with only these initially to be conservative and not accidentally affect the semantics of a whole bunch of binaries that might otherwise show up on the path such as with ChefDK.

:-1:   trying any commands with more than one subcommand fails.  It's creating one string from the remaining args.
Chef-PS chef-repo> knife node list
FATAL: Cannot find sub command for: '"node list"'

How are you running this?  I run knife node list and it works for me.

Apparently PS 5 changed some of the parsing behavior I was "working around".  Will work around the work around.

@smurawski This should be ready for another look.

:+1: With limited testing on Server 2008 R2, Server 2012, and Server 2012 R2 this seems to do it and it appears to address #1687 Yay!


UX Improvements

This PR contains the following:
Fixed docs.md -> It contained wrong div ids which prevented the table of contents from navigating to the specific sections
Table of contents styling -> Added style to have the table of contents always at the center of the screen for better UX
Back to Top button -> This button allows the user to quickly navigate back and forward between the table of contents and the sections it redirects to
Image of the current state of the table of contents with this PR, notice the "Back to Top" button below.

Thanks for the improvements.
Why is the table of contents aligned to the center?

Table of contents styling -> Added style to have the table of contents always at the center of the screen for better UX

Did you intend to make it a floating sidebar? Or was this referring to just the horizontal alignment?

It is just referring to the horizontal alignment, "always at the center" refers to no matter the size of the screen it'll remain at the center

Thanks for the improvements.
Why is the table of contents aligned to the center?

It looks more better imo compared to have it all the way to the left, which may seem it lacks styling

I think it looks better having it all the way to the left. Unless, the text itself is aligned to the center too.

I think it looks better having it all the way to the left. Unless, the text itself is aligned to the center too.

alright, I find the text better aligned to the left, so I'm going to remove the horizontal center alignment and create another PR


Publish app as an AAB on the Play Store

Using an Android App Bundle would lower the Play Store download size a bit, depending on device.
Currently blocked by this MotionLayout bug:
https://issuetracker.google.com/issues/112513722

Closing as MotionLayout usage was removed in d5d117bebf5cbc64e59b691495bfdf0cecf67dfb and an AAB was published for v1.0.11


fix(isolated-declarations): should not transform signature that has type annotation

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5927  👈
#5926
#5925
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on  Graphite


Docker changes

This is removing the docker build script away and addig in a build and build_docker one is using native gradle, the other is using docker to build.

looks fine to me


/repair derps

Using /repair on an item that's not repairable, like a dirt block.


Notification alternatives

Thank you so much for the PR, this looks great. I just pushed something up just now, and it seems like it causes some conflicts. Do you mind resolving the conflicts? Can't wait to try this out on my local.

Thank you so much for the PR, this looks great. I just pushed something up just now, and it seems like it causes some conflicts. Do you mind resolving the conflicts? Can't wait to try this out on my local.

@weizheheng done

@otavioschwanck Nice, thank you, I actually like this more than my previous implementation of a floating window showing the result, thinking of totally replacing with this and fallback to vim.notify if user doesn't have nvim-notify install

@otavioschwanck Nice, thank you, I actually like this more than my previous implementation of a floating window showing the result, thinking of totally replacing with this and fallback to vim.notify if user doesn't have nvim-notify install

Awesome!

@otavioschwanck, Thank you so much for this PR, I have taken a lot of inspiration from here.
There are a few things that I am doing differently:

Notification window is buffer specific

This means that each test file buffer will have its own nvim-notify instance.
The reason for doing this is that, when I want to run tests in a different tab, the position of the notification window will not be affected by the other instance.
Doing this also allow this plugin to clear the notification window specifically for the current test file buffer.

When the test is done running, it will replace the notification window instead of creating a new one.
Set the notification window timeout to false.

User can clear the notification window using require("ror.test").clear()
Rerunning the test in a test buffer will also dismiss any existing notification windows belonging to the buffer.

You can give it a try on the main branch!

@otavioschwanck, Thank you so much for this PR, I have taken a lot of inspiration from here.
There are a few things that I am doing differently:

Notification window is buffer specific

This means that each test file buffer will have its own nvim-notify instance.
The reason for doing this is that, when I want to run tests in a different tab, the position of the notification window will not be affected by the other instance.
Doing this also allow this plugin to clear the notification window specifically for the current test file buffer.

When the test is done running, it will replace the notification window instead of creating a new one.

Set the notification window timeout to false.

User can clear the notification window using require("ror.test").clear()
Rerunning the test in a test buffer will also dismiss any existing notification windows belonging to the buffer.

You can give it a try on the main branch!

if i was you, i would put the timeout to be configurable, i personally dont like doing that.

@otavioschwanck, yeap, I can see that will be helpful. Just added the ability to customise the timeout through config by default is false
require("ror").setup({
  test = {
    notification = {
      -- Using timeout false will replace the progress notification window
      -- Otherwise, the progress and the result will be a different notification window
      timeout = false
    },
  }
})


Search for multiple players

This could be implemented by making the player input a multiselect

API part has been implemented in 2e0bf5b627a5aa4e376bca8b2bf17cc12bf8a741


Bug fix for stop()

I've introduced a bug fix for the stop().
I believe that I found the simplest solution that makes sense. By allowing the user to pass in their webDriver instance to the stop()

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- java/src/main/java/com/saucelabs/simplesauce/SauceDriverImpl.java  1

Complexity decreasing per file
==============================
+ java/src/test/java/com/saucelabs/simplesauce/acceptance/SauceSessionAcceptanceTest.java  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- java/src/main/java/com/saucelabs/simplesauce/SauceDriverImpl.java  1

Complexity decreasing per file
==============================
+ java/src/test/java/com/saucelabs/simplesauce/acceptance/SauceSessionAcceptanceTest.java  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- java/src/main/java/com/saucelabs/simplesauce/SauceDriverImpl.java  1

Complexity decreasing per file
==============================
+ java/src/test/java/com/saucelabs/simplesauce/acceptance/SauceSessionAcceptanceTest.java  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- java/src/main/java/com/saucelabs/simplesauce/SauceDriverImpl.java  1

Complexity decreasing per file
==============================
+ java/src/test/java/com/saucelabs/simplesauce/acceptance/SauceSessionAcceptanceTest.java  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- java/src/main/java/com/saucelabs/simplesauce/SauceDriverImpl.java  1

Complexity decreasing per file
==============================
+ java/src/test/java/com/saucelabs/simplesauce/acceptance/SauceSessionAcceptanceTest.java  -1

See the complete overview on Codacy


icon.png appears to be corrupted

The mod's icon (icon.png) appears to be corrupt.
This is what macOS's preview displays for it:

GitHub's preview doesn't work at all...

This can cause mods that make use of mod icons, such as Catalogue, to experience issues, or even crash the game.

Oh wow... I've no idea how that's happened. Thanks for letting me know.

Fixed in 2.0.2!


[BUG] Error response from daemon: invalid reference format

What did you do?
Run k3d create

How was the cluster created?

k3d create

What did you do afterwards?

k3d commands?

 anuruddha@Anuruddhas-MacBook-Pro  ~  k3d create
2019/07/24 14:33:41 Created cluster network with ID 2d5b4e7dc27b58c448df1c161d8261af5efb316564a95bd8b659b5760a522e3b
2019/07/24 14:33:41 Created docker volume  k3d-k3s-default-images
2019/07/24 14:33:41 Creating cluster [k3s-default]
2019/07/24 14:33:41 Creating server using docker.io/rancher/k3s:...
2019/07/24 14:33:41 ERROR: couldn't create container k3d-k3s-default-server
ERROR: couldn't create container k3d-k3s-default-server
Error response from daemon: invalid reference format
 ✘ anuruddha@Anuruddhas-MacBook-Pro  ~  k3d create -v /dev/mapper:/dev/mapper
2019/07/24 14:34:31 Created cluster network with ID 2d5b4e7dc27b58c448df1c161d8261af5efb316564a95bd8b659b5760a522e3b
2019/07/24 14:34:31 Created docker volume  k3d-k3s-default-images
2019/07/24 14:34:31 Creating cluster [k3s-default]
2019/07/24 14:34:31 Creating server using docker.io/rancher/k3s:...
2019/07/24 14:34:31 ERROR: couldn't create container k3d-k3s-default-server
ERROR: couldn't create container k3d-k3s-default-server
Error response from daemon: invalid reference format

- docker commands?
- OS operations (e.g. shutdown/reboot)?

What did you expect to happen?
Create the cluster.
Concise description of what you expected to happen after doing what you described above.
Screenshots or terminal output
If applicable, add screenshots or terminal output (code block) to help explain your problem.
Which OS & Architecture?
System Version:	macOS 10.14.2 (18C54)
Kernel Version:	Darwin 18.2.0

Linux, Windows, MacOS / amd64, x86, ...?
System Version:	macOS 10.14.2 (18C54)
Kernel Version:	Darwin 18.2.0

Which version of k3d?
 ✘ anuruddha@Anuruddhas-MacBook-Pro  ~  k3d --version
k3d version v1.3.0

Which version of docker?
Client: Docker Engine - Community
 Version:           19.03.0-rc2
 API version:       1.40
 Go version:        go1.12.5
 Git commit:        f97efcc
 Built:             Wed Jun  5 01:37:53 2019
 OS/Arch:           darwin/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.0-rc2
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.5
  Git commit:       f97efcc
  Built:            Wed Jun  5 01:42:10 2019
  OS/Arch:          linux/amd64
  Experimental:     true
 containerd:
  Version:          v1.2.6
  GitCommit:        894b81a4b802e4eb2a91d1ce216b8817763c29fb
 runc:
  Version:          1.0.0-rc8
  GitCommit:        425e105d5a03fabd737a126ad93d62a9eeede87f
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

This might actually be caused by a change in the docker API, since you're using a bleeding edge docker release there.
I'll check https://docs.docker.com/engine/api/version-history/ soon to see what's going on.
You also might want to consider updating to the latest stable release instead of the RC version.

I got the same error on Fedora running a slightly older version of docker:
$ k3d c; echo "======"; docker version
2019/07/24 15:41:08 Created cluster network with ID d7977801508e3bbbfaa0b8089d3a2eee23ba71dcb2417f2d21f9235e16c5dce1
2019/07/24 15:41:08 Created docker volume  k3d-k3s-default-images
2019/07/24 15:41:08 Creating cluster [k3s-default]
2019/07/24 15:41:08 Creating server using docker.io/rancher/k3s:...
2019/07/24 15:41:08 ERROR: couldn't create container k3d-k3s-default-server
ERROR: couldn't create container k3d-k3s-default-server
Error response from daemon: invalid reference format
Client:
Version:           18.09.5
API version:       1.39
Go version:        go1.10.8
Git commit:        e8ff056
Built:             Thu Apr 11 04:44:27 2019
OS/Arch:           linux/amd64
Experimental:      false
Server: Docker Engine - Community
Engine:
Version:          18.09.5
API version:      1.39 (minimum version 1.12)
Go version:       go1.10.8
Git commit:       e8ff056
Built:            Thu Apr 11 04:13:40 2019
OS/Arch:          linux/amd64
Experimental:     false

The version of docker sdk used is too old, which is v1.13.1 from 2 years ago. According to the way they publish new versions since then, we should directly get its master branch go get -u github.com/docker/docker/client@master. I've tested locally and it just works. Some minor code changes are needed tho.

Weird enough, it works for me with the following docker version and k3d v1.3.0:
Client: Docker Engine - Community
 Version:           19.03.0
 API version:       1.40
 Go version:        go1.12.5
 Git commit:        aeac9490dc
 Built:             Wed Jul 17 18:14:51 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.0
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.5
  Git commit:       aeac9490dc
  Built:            Wed Jul 17 18:13:27 2019
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.2.6
  GitCommit:        894b81a4b802e4eb2a91d1ce216b8817763c29fb
 runc:
  Version:          1.0.0-rc8
  GitCommit:        425e105d5a03fabd737a126ad93d62a9eeede87f
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

However, @wxdao proposed changes are good in any case :+1:

@iwilltry42 I'm not sure #94 will close this. I've just tried with @wxdao's branch:
[mitch@hex Dev]$ git clone https://github.com/wxdao/k3d.git
Cloning into 'k3d'...
remote: Enumerating objects: 804, done.
remote: Counting objects: 100% (804/804), done.
remote: Compressing objects: 100% (552/552), done.
remote: Total 1902 (delta 278), reused 638 (delta 229), pack-reused 1098
Receiving objects: 100% (1902/1902), 2.05 MiB | 1.06 MiB/s, done.
Resolving deltas: 100% (777/777), done.
[mitch@hex Dev]$ cd k3d/
[mitch@hex k3d]$ git checkout fix-docker
Branch 'fix-docker' set up to track remote branch 'fix-docker' from 'origin'.
Switched to a new branch 'fix-docker'
[mitch@hex k3d]$ make build
go build -i  -tags '' -ldflags '-w -s -X github.com/rancher/k3d/version.Version=v1.3.0-2-g058bb1d -X github.com/rancher/k3d/version.K3sVersion=' -o '/home/mitch/Dev/k3d/bin/k3d'

[mitch@hex k3d]$ ./bin/k3d -version
k3d version v1.3.0-2-g058bb1d

[mitch@hex k3d]$ ./bin/k3d c
2019/07/24 23:53:30 Created cluster network with ID d7977801508e3bbbfaa0b8089d3a2eee23ba71dcb2417f2d21f9235e16c5dce1
2019/07/24 23:53:30 Created docker volume  k3d-k3s-default-images
2019/07/24 23:53:30 Creating cluster [k3s-default]
2019/07/24 23:53:30 Creating server using docker.io/rancher/k3s:...
2019/07/24 23:53:30 ERROR: couldn't create container k3d-k3s-default-server
ERROR: couldn't create container k3d-k3s-default-server
Error response from daemon: invalid reference format

It looks like the release image may have been built without internet access and the K3S_TAG was not set, from the Makefile:
 14 K3S_TAG         := $(shell curl --silent "https://api.github.com/repos/rancher/k3s/releases/latest" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/')

Doing a docker pull with a tag of ... gives this error:
$ docker pull docker.io/rancher/k3s:...
invalid reference format

Rebuilding the master branch with internet access (and working DNS, so not in my hotel) works.

@physcat good catch!
That's really bad :/ Actually, we automatically build the release artifacts with TravisCI, so I wouldn't have guessed, that the network at buildtime was a problem. I will replace the binaries now with locally built ones.
Thank you :+1:

@iwilltry42 I just downloaded the binary and it works perfectly. Thanks.

@anuruddhal & @physcat & @wxdao , please test it with the new binaries.
I guess @wxdao's upgrade of the docker SDK "fixed" it, because of the new local build which has the tag in it. Anyway, the upgrade might be a good idea :+1:

Some random thoughts: Is it right to use a dynamic content on building? Besides some awkward problems like this issue, one can't get repeatable builds of a specific version. I think we should hardcode a tag and have it updated along releases, or simply use latest?

We already had some discussions about this and were always unsure, since every approach has its drawbacks.
Hardcoding it means, that you always have to think of updating it, so those awkward problems might then originate from human mistake.
Latest tag unfortunately does not exist and would require changes or manual work in rancher/k3s.
So we thought that getting the latest version automatically upon build time would give the "less bad" result. i.e. quite recent, no human mistakes possible, though it might fail if GitHub or network is down.
Actually, grabbing the latest version at runtime would be cool, but at least just as error prone...

got the same error , any solution for this problem ?

just solve this problem by remove /usr/local/bin/k3d and reinstall the new version of k3d

Just summing this up here for anyone dropping by:
This bug was caused by a bad build, where somehow the Makefile failed to fetch the latest release tag in k3s without a fallback. Thus, k3d is trying to pull an image with an undefined tag and fails.
We uploaded new binaries without this error, so you have to replace your current k3d executable with a newly downloaded one.
Thanks for your help everyone!


use in different dimen

Interesting work!
will this be working fine with 2D US and 3D CT data?

Thanks,
The current work can be used only with the same data dimensionality, i.e. 2D-2D or 3D-3D.
We are working on an extension that can work with 2D-3D registration


64 make a clear function emimint

I based this branch on branch 66-edit-the-search-bar-design-Emimint:

I have commented out the rest buttons for now as @goodman2814 suggested
I have linked the search button to @cmade fetchData function (since the input of the "GO" inputs are now gone)
I have created a resetFunction and linked it to the reset button.

I realized it will also include the previous commit so I will close and wait for you guys first,


Why 7.1 and not 7.0?

Hi,
Can you change version inside pod to 7.0 instead of 7.1 ?
There is any problem in 7.0? I ran it on 7.0 and not problems happen.
Thanks.

I added support to 7.0 in the podspec.
I hope this help :)


Add toggle to keep/remove the locale dropdown in the search modal

Fixes #99
A lot of people (at least me) only ever search within one locale, so having locale as an option every search doesn't make sense.
I've left the existing behavior as the default behavior, but added a toggle to enable using the default locale always.

Thank you!!!


Special characters aren't removed from list names

Create a GetUsableListName() like GetUsableCardName() but without the length limiting, then make sure to use it in GetDuplicateNameKey() too.

Duplicate of #9


[Event-Change Request] codeunit 12 "Gen. Jnl.-Post Line" - OnAfterInsertVATEntry

Dear ALAppExtensions team,
Through this issue we would like to request the inclusion of the sender in Codeunit 12 Gen. Jnl.-Post Line Eventpublisher OnAfterInsertVATEntry.
[IntegrationEvent(true, false)]    <<<<<<<
local procedure OnAfterInsertVATEntry(GenJnlLine: Record "Gen. Journal Line"; VATEntry: Record "VAT Entry"; GLEntryNo: Integer; var NextEntryNo: Integer; var TempGLEntryVATEntryLink: Record "G/L Entry - VAT Entry Link" temporary)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47942.


Fixed issue caused when multiple BMPs have been connected

The find_bmp method assumed only a single BMP had ever been connected to the computer. This PR fixes this issue.

Thank you for the fix. I have not been able to check it yet (because so far I failed to upgrade my cheap ST-Link v2 clone to a BMP). As an aside: thanks for the blog on compiling the BMP firmware on WIndows 10. That has been a great help.

@compuphase Happy the blog was useful. More recently I have set up VSCode to build and debug BMP code, and of course my ctxLink probe.

@compuphase , I have recently also setup VSCode to build and debug BMP and my ctxLink probe.
Take a look at Crowd Supply

I saw the ctxLink probe. It looks like a step forward from the BMP. I have not yet decided whether I want one (but I still have 30 days...).


Repetitive keypoints added in replay buffer

Hi @MohitShridhar, thanks for sharing your amazing work! I have a question about repetitive (maybe?) keypoints added in the replay buffer. The related code is the loop here
From my understanding, the func "_add_keypoints_to_replay()" will be called every 10 steps if "demo_augmentation" is enabled, so that the loop mentioned above will also be revisited many times in a single demo. Thus, there will be a lot of repetitive "obs_tp" data added to the replay buffer since they are generated by the same keypoint pairs.
If this is the case, I'm wondering if those repetitive keypoints data would be beneficial to our training process? Thank you!

@qianLyu, related to this? https://github.com/peract/peract/issues/6#issuecomment-1355555980

Yes, that's exactly the same issue. Thanks for your reply!


Styling bleeds out into other formats

It looks like the todo.txt file styling is applied to other types of files as well.

ill look into this


Could not find com.apollographql.apollo:apollo-gradle-plugin:XYZ

The build fails at the moment with:
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Could not find com.apollographql.apollo:apollo-android-support:1.3.2.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/com/apollographql/apollo/apollo-android-support/1.3.2/apollo-android-support-1.3.2.pom
       - https://jcenter.bintray.com/com/apollographql/apollo/apollo-android-support/1.3.2/apollo-android-support-1.3.2.pom

This is because we are merging the bintray packages and this broke the jcenter sync. We're working to restore it.
In the meantime, you can download the artifacts from https://dl.bintray.com/apollographql/android/
        repositories {
            maven { url = uri("https://dl.bintray.com/apollographql/android/") }
            // jcenter should be below
            jcenter()
        }

I'll post as soon as jcenter is up again.

Weirdly we are still seeing missing deps even when hard-coding bintray:
> Could not resolve all task dependencies for configuration ':mediafeature:debugRuntimeClasspath'.
   > Could not find com.apollographql.apollo:apollo-runtime:1.4.4.
     Required by:
         project :xxx > project :app > project :api
   > Could not find com.apollographql.apollo:apollo-rx2-support:1.4.4.
     Required by:
         project :xxxx > project :app > project :api

Even though these artifacts are very much present:
https://dl.bintray.com/apollographql/android/com/apollographql/apollo/apollo-runtime/1.4.4/

@tir38 did you put maven { url = uri("https://dl.bintray.com/apollographql/android/") } above jcenter() ? There might be caching involved letting jcenter() think the artifact is there while it's not.

Gradle has repositories under buildscript and subproject. Make sure to put the above maven url under both.

@martinbonnin yep, even did a full nuke of all 3rd party deps in ~/.gradlew/caches.
@tasomaniac bingo. I forgot to add to allprojects block too. Thanks

@tir38 could you summarize what worked for you? We use the buildscript method to include the plugin and that doesn't seem to work.

@adilfulara to make this work you should avoid using the plugins { } block and instead do the following 3 things:

add classpath("com.apollographql.apollo:apollo-gradle-plugin:${Versions.apollo}") to your buildscript { dependencies { } } block
apply the plugin using apply(plugin = "com.apollographql.apollo") in your gradle modules
configure using configure<ApolloExtension> { } instead of apollo {}

Note: the above assume you are using Kotlin DSL, Groovy DSL will be slightly different.
The plugins {} block always tries to use the plugins.gradle.org repo, regardless of what you put in your repositories {} blocks.

i did a fresh checkout of our project that uses 1.2.x and was losing my mind why gradle cannot find it from the public repos...so when i added maven { url = uri("https://dl.bintray.com/apollographql/android/") } above jcenter() in repositories block (per @martinbonnin) everything's all good.
what happened?

@adilfulara to make this work you should avoid using the plugins { } block and instead do the following 3 things:

add classpath("com.apollographql.apollo:apollo-gradle-plugin:${Versions.apollo}") to your buildscript { dependencies { } } block
apply the plugin using apply(plugin = "com.apollographql.apollo") in your gradle modules
configure using configure<ApolloExtension> { } instead of apollo {}

Note: the above assume you are using Kotlin DSL, Groovy DSL will be slightly different.
The plugins {} block always tries to use the plugins.gradle.org repo, regardless of what you put in your repositories {} blocks.

Thank you ! It worked

Jcenter has been enabled again and the situation should progressively go back to normal. From what I have seen, the different version appear progressively. Let me know if you still have issues.
Sorry again for the inconvenience. This was a one time thing and hopefully maintaining the packages will be easier in tthe future.

Say wat u trying to do brah like real talk u tripping son 😠😠😠😠😠
On Tue, Apr 14, 2020, 2:29 AM Martin Bonnin<EMAIL_ADDRESS>wrote:

Jcenter has been enabled again and the situation should progressively go
back to normal. From what I have seen, the different version appear
progressively. Let me know if you still have issues.
Sorry again for the inconvenience. This was a one time thing and hopefully
maintaining the packages will be easier in tthe future.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apollographql/apollo-android/issues/2159#issuecomment-613273653,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO7JN34J3EXLHX3GTVM4A3TRMQGERANCNFSM4MHE6RBA
.


Fix filter for images with location but missing lookup

I have a picture taken inside of an airplane with a valid geolocation.
https://www.google.com/maps/place/51°31'46.6"N+2°06'49.9"E/@50.5495598,-0.1600842,7.21z/data=!4m5!3m4!1s0x0:0x1e93c1a35cd9a3f6!8m2!3d51.529606!4d2.113856
However, when this gets put through MapBox we see that the following geolocation_json is produced:
{'type': 'FeatureCollection', 'query': [2.113856, 51.529606], 'features': [], 'attribution': 'NOTICE: © 2022 Mapbox and its suppliers. All rights reserved. Use of this data is subject to the Mapbox Terms of Service (https://www.mapbox.com/about/maps/). This response and the information it contains may not be retained. POI(s) provided by Foursquare.', 'search_text': ''}

No features. Oops.
This provides issues with the code on line 93: https://github.com/LibrePhotos/librephotos/blob/a5ab77839c6fb24d24293f28ba4154d42511e245/api/api_util.py#L93
I updated the check to expand the null-check to ensure that the whole chain is not null, not just geolocation_json.
Interestingly this, by proxy, fixes another bug.
If we consider the query
Photo.objects.exclude(geolocation_json={})

as the basis for the filter 'get all photos where we have a geolocation_json', then it fails on an object where geolocation: None. Now, I'm not sure if that is ever possible from the point view of code, but it is definitely possible from the model's point of view: https://github.com/LibrePhotos/librephotos/blob/0a465a5dbee71247e8fad6ad23e694b91d7bb8f7/api/migrations/0001_initial.py#L427-L428
If we open a shell like this:
$ docker exec -it librephotos-backend python /code/manage.py shell_plus
# ...initialization
>>> temp = Photo.objects.first()
>>> temp.pk = "none_geolocation"
>>> temp.geolocation_json = None
>>> temp.save()
>>> for p in Photo.objects.exclude(geolocation_json={}):
...     if (p.geolocation_json == None):
...         print("ERROR: p.geolocation_json is None")
...
p.geolocation_json is None

Looking at the generated code shows that the test exclude(geolocation_json={}) doesn't match with the model and our output's expectations:
 WHERE NOT ("api_photo"."geolocation_json" = '{}' AND "api_photo"."geolocation_json" IS NOT NULL)

This where only excludes {}, but not None:

"api_photo"."geolocation_json" = '{}'
"api_photo"."geolocation_json" IS NOT NULL
NOT(condition1 AND condition2) (i.e. will it be included?)

None (or NULL)
FALSE
FALSE
TRUE, but we don't expect it to be, 👎

{} (i.e. empty dict
TRUE
TRUE
FALSE, 👍

{'...': '...'}
FALSE
TRUE
TRUE, 👍

As this exclude(geolocation_json={}) is being used across the code I'm not sure though if we ever end up in that case.
If we expect it will None, then I believe a better filter across the board would be filter(geolocation_json__isnull=False).filter(...other properties...).
If we don't, then I suggest setting the DB model's nullable to FALSE.

Hey kristoff-matei,
thank you for your pull request. This looks like a case I missed.
The function that actually fetches and uses the mapbox response is in the photo model and is named  def _geolocate_mapbox(self, commit=True): If the request fails, then the geolocation_json will be saved as {}. I think it used to be that it was saved as None, but was changed at some point. Looks like it would be worth investigating, if we can just set nullable=FALSE
Here is a quick explanation on how location works in LibrePhotos:
We currently use the features from Mapbox to group the photos by location. That makes it possible to look up pictures that have the same location. We use these groups or AlbumPlace entities to give AlbumDate entities a location.
I think the features are also used for AlbumAuto to generate nice titles with the names in them.
I think this fix is then mostly relevant to the data visualization. Your fix is currently only applied to get_location_timeline, which corresponds to /timeline. I think /placetreeor def get_location_sunburst(user): and  /wordclouds or def get_search_term_examples(user):
Let me know if you want to add these possible fixes there too or if you want to open up a separate pull request for these :)

I think that regardless of setting the DB field to default {} or not we need to improve the queries in get_location_sunburst and get_search_term_examples because they rely on features.[].text.
I'll make the change in this PR as it is one logical bugfix.
I believe that migrating the DB from a default of NULL to a default of {} should be a separate PR if that is the direction you believe is correct.

Closing in favor of #499


Fix modified files list in webhooks when there is a space

There is an unfortunate bug with GetCommitFileStatus where files with
spaces are misparsed and split at the space.
There is a second bug because modern gits detect renames meaning that
this function no longer works correctly.
There is a third bug in that merge commits don't have their modified
files detected correctly.
Fix #15865
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Can we add tests 😓 for this case we fix?

Codecov Report

Merging #16288 (5a83363) into main (8368844) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main   #16288      +/-   ##
==========================================
+ Coverage   45.42%   45.44%   +0.02%
==========================================
  Files         709      709
  Lines       83667    83686      +19
==========================================
+ Hits        38009    38035      +26
+ Misses      39561    39555       -6
+ Partials     6097     6096       -1

Impacted Files
Coverage Δ

modules/git/commit.go
60.00% <75.00%> (-0.17%)
:arrow_down:

modules/log/event.go
59.90% <0.00%> (-1.89%)
:arrow_down:

services/pull/pull.go
42.42% <0.00%> (+0.43%)
:arrow_up:

models/gpg_key.go
51.99% <0.00%> (+0.56%)
:arrow_up:

routers/web/repo/view.go
41.37% <0.00%> (+0.57%)
:arrow_up:

modules/queue/unique_queue_disk_channel.go
48.63% <0.00%> (+1.36%)
:arrow_up:

modules/queue/workerpool.go
54.96% <0.00%> (+1.90%)
:arrow_up:

modules/process/manager.go
75.30% <0.00%> (+2.46%)
:arrow_up:

models/unit.go
43.83% <0.00%> (+2.73%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8368844...5a83363. Read the comment docs.


Add 24 hours refresh for dashboard

For dashboards, add additional autorefresh time interval options of 30m, 1h, 6h, 12h, and 24h.
Fixes #5058.
@mistercrunch @michellethomas @niksem

Mind adding incremental values while at it? Maybe 15 minutes, 30 minutes, 1 hour, 6 hours, ...

Oh good idea! done

Codecov Report

Merging #5068 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5068   +/-   ##
=======================================
  Coverage   77.53%   77.53%
=======================================
  Files          44       44
  Lines        8712     8712
=======================================
  Hits         6755     6755
  Misses       1957     1957

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d322e48...bfae21e. Read the comment docs.

@aok1425 just curious, why not just let the user to set the interval instead of providing the options?

@yamyamyuo I wanted my Superset dash to update every 24h, and I don't know enough JS to let the user set the interval :)
Maybe you want to build the feature to let the user set the interval? I'm imagining something like a horizontal slider might be a good design.

Hi,
I mean I am adding new refresh time in the code as mentioned on the ticket
and restarting superset server.
But the changes are not reflected.
I need assistance to reflect my changes
Regards,
Saloni
On Thu, Aug 30, 2018, 12:52 PM Alexander Ko<EMAIL_ADDRESS>wrote:

@salonijain024 https://github.com/salonijain024 I don't understand what
you're saying. Can you link to your PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/pull/5068#issuecomment-417216555,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQmV_4nVenWHII4kNKjgJ-6ke6d1P695ks5uV5LGgaJpZM4ULihg
.

@salonijain024 if you change the JS code you need to rebuild it. Check out our CONTRIBUTING.md file.

Hi,
Thank you so much for your support.
It worked and I am able to add custom refresh time.
Regards,
Saloni
On Thu, Aug 30, 2018, 8:49 PM Maxime Beauchemin<EMAIL_ADDRESS>wrote:

@salonijain024 https://github.com/salonijain024 if you change the JS
code you need to rebuild it. Check out our CONTRIBUTING.md file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/pull/5068#issuecomment-417357920,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQmV_2e4JttNM35mA2KhQXFCSHFfp391ks5uWAKNgaJpZM4ULihg
.

Hi,
I have another version of superset on production and i am trying to
implement the same on 0.24.0 version of superset.
here i am facing below issue. Can you please help me to resolve the same:
Thanks and Regards,
Saloni Jain
On Thu, Aug 30, 2018 at 10:27 PM SALONI JAIN<EMAIL_ADDRESS>wrote:

Hi,
Thank you so much for your support.
It worked and I am able to add custom refresh time.
Regards,
Saloni
On Thu, Aug 30, 2018, 8:49 PM Maxime Beauchemin<EMAIL_ADDRESS>wrote:

@salonijain024 https://github.com/salonijain024 if you change the JS
code you need to rebuild it. Check out our CONTRIBUTING.md file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/pull/5068#issuecomment-417357920,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQmV_2e4JttNM35mA2KhQXFCSHFfp391ks5uWAKNgaJpZM4ULihg
.

0 info it worked if it ends with ok
1 verbose cli [ '/root/.nvm/versions/node/v8.9.4/bin/node',
1 verbose cli   '/root/.nvm/versions/node/v8.9.4/bin/npm',
1 verbose cli   'run',
1 verbose cli   'lint' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prelint', 'lint', 'postlint' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: /root/.nvm/versions/node/v8.9.4/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/srv/superset/venv/lib/python2.7/site-packages/superset/static/assets/node_modules/.bin:/root/.nvm/versions/node/v8.9.4/bin:/srv/superset/venv/bin:/root/.gem/ruby/2.4.0/bin:/opt/ruby/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin
9 verbose lifecycle<EMAIL_ADDRESS>CWD: /srv/superset/venv/lib/python2.7/site-packages/superset/static/assets
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'eslint --ignore-path=.eslintignore --ext .js,.jsx .' ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec lint script
13 verbose stack Error<EMAIL_ADDRESS>lint: eslint --ignore-path=.eslintignore --ext .js,.jsx .
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter. (/root/.nvm/versions/node/v8.9.4/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:285:16)
13 verbose stack     at emitTwo (events.js:126:13)
13 verbose stack     at EventEmitter.emit (events.js:214:7)
13 verbose stack     at ChildProcess. (/root/.nvm/versions/node/v8.9.4/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at emitTwo (events.js:126:13)
13 verbose stack     at ChildProcess.emit (events.js:214:7)
13 verbose stack     at maybeClose (internal/child_process.js:925:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd /srv/superset/venv/lib/python2.7/site-packages/superset/static/assets
16 verbose Linux 3.10.0-693.21.1.el7.x86_64
17 verbose argv "/root/.nvm/versions/node/v8.9.4/bin/node" "/root/.nvm/versions/node/v8.9.4/bin/npm" "run" "lint"
18 verbose node v8.9.4
19 verbose npm  v5.6.0
20 error code ELIFECYCLE
21 error errno 1
22 error<EMAIL_ADDRESS>lint: eslint --ignore-path=.eslintignore --ext .js,.jsx .
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>lint script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

0.24 is old, why not upgrading to a newer version?

Hi,
I understand but that my version is old but currently we have a production
release and cannot afford to have a version change.
We were looking for a hotfix on the same version we are using.
I would request you to kindly some assistance to fix it.
Regards,
Saloni Jain
On Fri, Aug 31, 2018 at 10:11 PM Maxime Beauchemin<EMAIL_ADDRESS>wrote:

0.24 is old, why not upgrading to a newer version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/pull/5068#issuecomment-417722168,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQmV_9KnKDrebQCCifEiWmEA1Sb7Qausks5uWWcqgaJpZM4ULihg
.

`# Install nodejs for custom build
48 # https://nodejs.org/en/download/package-manager/
49 RUN curl -sL https://deb.nodesource.com/setup_9.x | bash -
50 RUN apt-get update && apt-get install -y nodejs
51 RUN npm install -g yarn
53 RUN ls ${SUPERSET_ASSETS_DIR}
54 COPY ./lls_superset_build/package.json ${SUPERSET_ASSETS_DIR}/package.json # i have modify something here
RUN cd ${SUPERSET_ASSETS_DIR} && yarn
61 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack
compile the frontend
49 # https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#making-your-own-build
50 RUN cd ${SUPERSET_ASSETS_DIR} && yarn
51 # RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack
56 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list
58 RUN cd ${SUPERSET_ASSETS_DIR} && npm run build
`

Thanks for the help.
I will do the same and update you in case of any issue.
Regards,
Saloni
On Wed, Sep 5, 2018, 1:07 PM yamyamyuo<EMAIL_ADDRESS>wrote:

`# Install nodejs for custom build
48 # https://nodejs.org/en/download/package-manager/
49 RUN curl -sL https://deb.nodesource.com/setup_9.x | bash -
50 RUN apt-get update && apt-get install -y nodejs
51 RUN npm install -g yarn
53 RUN ls ${SUPERSET_ASSETS_DIR}
54 COPY ./lls_superset_build/package.json
${SUPERSET_ASSETS_DIR}/package.json # i have modify something here
RUN cd ${SUPERSET_ASSETS_DIR} && yarn
61 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack
compile the frontend
49 #
https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#making-your-own-build
50 RUN cd ${SUPERSET_ASSETS_DIR} && yarn
51 # RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack
56 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list
58 RUN cd ${SUPERSET_ASSETS_DIR} && npm run build
`
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/pull/5068#issuecomment-418629986,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQmV_6-Pma7yflg4rJaMLKRjnFyi_V-Mks5uX38mgaJpZM4ULihg
.

Hi,
Can you help me with upgrading superset without impacting existing data on
old version of superset.
Our production superset version is very old and we need to upgrade, but do
not want to impact the existing dashboards and rework on the same.
Kindly assist.
Regards,
Saloni Jain
On Wed, Sep 5, 2018, 3:04 PM SALONI JAIN<EMAIL_ADDRESS>wrote:

Thanks for the help.
I will do the same and update you in case of any issue.
Regards,
Saloni
On Wed, Sep 5, 2018, 1:07 PM yamyamyuo<EMAIL_ADDRESS>wrote:

`# Install nodejs for custom build
48 # https://nodejs.org/en/download/package-manager/
49 RUN curl -sL https://deb.nodesource.com/setup_9.x | bash -
50 RUN apt-get update && apt-get install -y nodejs
51 RUN npm install -g yarn
53 RUN ls ${SUPERSET_ASSETS_DIR}
54 COPY ./lls_superset_build/package.json
${SUPERSET_ASSETS_DIR}/package.json # i have modify something here
RUN cd ${SUPERSET_ASSETS_DIR} && yarn
61 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack
compile the frontend
49 #
https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#making-your-own-build
50 RUN cd ${SUPERSET_ASSETS_DIR} && yarn
51 # RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack
56 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list
58 RUN cd ${SUPERSET_ASSETS_DIR} && npm run build
`
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/pull/5068#issuecomment-418629986,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQmV_6-Pma7yflg4rJaMLKRjnFyi_V-Mks5uX38mgaJpZM4ULihg
.

@salonijain024 this PR is not the right outlet to discuss this, please open an issue with the specifics


Debugging does not work with latest codellb 1.8.1

Debugging fails to start with latest codellb 1.8.1 but does work with the old 1.6.10 one just fine:
Running on codellb 1.6.10

Running with latest codellb 1.8.1 will just fail with the error and does not start the process

Okay, found another issue #244 related to this. And there was typo in a path for me as well so closing this.
Note to self, it would be helpful to spell the codelldb correctly, I previously had codellb but the path is codelldb.


When creating HoneycombOptions, do not append /v1/traces to traces_endpoint if it's already there

Hey y'all 👋🏻
Thanks for the great bootstrapping library :)

Is your feature request related to a problem? Please describe.

I tried instantiating HoneycombOptions with https://<collector url>/v1/traces and got unhelpful error messages and no traces exported.

Describe the solution you'd like

If I instantiate HoneycombOptions with an endpoint that ends with /v1/traces and exporter_protocol=EXPORTER_PROTOCOL_HTTP_PROTO, do not append that suffix again.

Describe alternatives you've considered

An alternative is to warn users that they're providing an invalid value to the field.

Thanks for raising @omervk - I've got a fix incoming 👍🏻


Added 'npm run build' script to postinstall

Hey amila, is this script on postinstall really needed? Saw great speed improvements on development when disabling it.

Yea i actually plan to disable it. Initially i added it because some people were trying to run the end-to-end tests right after cloning just to try them out. Expect a commit to https://github.com/chentsulin/electron-react-boilerplate/pull/1023 that reverts this


Update dependency on JavaCPP to just released version 1.2.5

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished. No test results found.

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/66/


Permanently disconnecting websocket in v201 when stop function is called

@mennodegraaf reported that a normal ChargePoint::stop() results in a segfault:

^CBBOC  (main.cpp:48)          [info    ] Signal Interrupt received, closing backoffice communication application
BBOC  (websocket_base.:85)   [info    ] [libocpp]  Disconnecting websocket...
BBOC  (websocket_plain:230)  [info    ] [libocpp]  Closing plain websocket.
BBOC  (websocket_plain:241)  [info    ] [libocpp]  Closed plain websocket successfully.
BBOC  (message_queue.h:309)  [info    ] [libocpp]  Message queue stopped processing messages
BBOC  (websocket_plain:200)  [info    ] [libocpp]  Closed plain websocket connection with code: system:0 (Going away), reason:
BBOC  (websocket_plain:96)   [info    ] [libocpp]  Reconnecting in: 0ms, attempt: 1
BBOC  (websocket_plain:33)   [info    ] [libocpp]  Reconnecting to plain websocket at uri: ws://localhost:7364/tomahawk_test_menno with profile: 0
BBOC  (websocket_plain:172)  [info    ] [libocpp]  OCPP client successfully connected to plain websocket server
BBOC  (database_handle:135)  [error   ] [libocpp]  Error closing database file: unable to close due to unfinalized statements or unfinished backups
Segmentation fault (core dumped)

Looks good to me, I have tested before that a disconnect with status::normal does not result in a reconnect

For future reference: there are three issues when calling ChargePoint::stop(), only when the websocket is connected, when it is unconnected it is ok:

It tries to reconnect after gracefully closing the websocket
On close, it logs a message about a failure to open
The database does not gracefully close, see the error message above about 'unable to close due to unfinalized statements'