Recent PowerRanks versions breaking other permission providers?

Over the course of the last month I have had more and more PowerRanks users come to the Towny discord to say that our permissions do not work.
Towny has a built-in permission plugin which gives out permission nodes to players based on their towny role: nomad, town member, town mayor, nation leader, nation member, etc.
It supplies Bukkit superperms with permission nodes to each player while they are in Towny-enabled worlds. This system has worked quite well for us for years. Admins don't have to set up permission nodes and the system "just works".
For each admin with this mysterious issue the common element has been a recent version of PowerRanks: v1.10.5R2.
I have not gone over all of your commits but I suspect something has changed which has resulted in your plugin overwriting other plugins' additions to a player's nodes.
This issue plus the additional issue in #60 have proven to be a substantial roadblock for Towny admins wanting to use PowerRanks.

I've looked into the reported issue regarding PowerRanks affecting Towny permissions.
After investigation, I've identified and resolved the problem. The fix will be included in the upcoming release, PowerRanks v1.10.8.

Nicely done.


v1.0.36 isn't available in the Github releases page but is available on Nuget.

Latest release on Nuget is v.1.0.36: https://www.nuget.org/packages/Microsoft.SpatialAudio.Spatializer.Unity/
Latest release on Github is v1.0.18: https://github.com/microsoft/spatialaudio-unity/releases
Is Nuget the direction that this project is heading? It would be great if the Unity packages could be kept in lock-step

Hi @itadakimasu, thanks for logging this issue. Completely agree that it would be great to keep all packages everywhere in lock-step. This is a slip up on our part while we're working on bringing up a UPM feed (Nuget packages are getting pushed in the CI build while GitHub releases are not automated). We will fix this asap.

Thanks again for the report @itadakimasu. Fixed with the latest release.

Thanks again for the report @itadakimasu. Fixed with the latest release.


feat: Update Swift demo to use Swift 4.2

Updating the Swift demo to use Swift 4.2. The demo with Swift 3 was unusable in the latest version of Xcode.

@jpoehnelt @arriolac Should we update the swift sample project to 5.0 or above?

@farshadmb yes! Feel free to send us a PR

@arriolac I will do it. I hope to join you guys in google company.


Failing on Cannot read properties of undefined (reading 'testCount')

"@playwright/test": "1.23.3"
"@reportportal/agent-js-playwright": "5.0.8"
Getting the following error from reporter
TypeError: Cannot read properties of undefined (reading 'testCount')
    at RPReporter.<anonymous> (/app/node_modules/@reportportal/agent-js-playwright/src/reporter.ts:487:40)
    at step (/app/node_modules/@reportportal/agent-js-playwright/build/reporter.js:60:23)
    at Object.next (/app/node_modules/@reportportal/agent-js-playwright/build/reporter.js:41:53)
    at fulfilled (/app/node_modules/@reportportal/agent-js-playwright/build/reporter.js:32:58)

This is producing the error:
// if all children of the test parent have already finished, then finish all empty ancestors
    if (this.suites.get(fullParentName).testCount < 1) {
      this.finishSuites();
}

Would like to understand when would fullParentName not be present in the suites Map and if it can be accessed through optional chaining

Hello @vinilvasani !
As far as I remember, such a case can arise when the requested parent is already finished.
It would be very helpful if you could prepare a reproducible sample for this issue.

Hello @vinilvasani !
Could you please provide an example to help us reproduce the issue?
Thank you in advance!

Hey, @AmsterGet thank you for the response.
Will need some time to prepare a reproducible sample for this as this was an intermittent issue that I was facing.
Closing this, for now, will reopen the issues once I have the sample ready.

@AmsterGet @vinilvasani We are still facing this, I cannot share a reproducible issue as this is an internal project and since this does happens all the time, it is difficult for me to generate a scenario which reproduces this.
I still need to debug this because essentially entire suite gets cancelled after this error comes.
@AmsterGet Will it be possible for you to explain how I can debug this error on my side ?

What does parent suite means
what are child suites
What happens if one of the test fails
What happens if response from API is not properly handled ?.

@AmsterGet There is another issue we are facing and I will be happy to pick both these issues up if I can help.
Second issue - https://github.com/reportportal/agent-js-playwright/issues/86

@AmsterGet is there a way I can run agent-js-playwright in debug mode, which gives outputs like parent test suite, current test running and root suite ? from there I will be able to see patterns about which parent suite is always causing problems.

@AmsterGet is there a way I can run agent-js-playwright in debug mode, which gives outputs like parent test suite, current test running and root suite ? from there I will be able to see patterns about which parent suite is always causing problems.

You can set the debug: true property in the config to see the debug logs from client-javascript.
No additional logging available from agent-js-playwright side.

@AmsterGet Hi, I ran report portal agent-js-playwright in debug mode to get more insights as to what test suite might be the culprit which could be causing this issue but the logs generated in debug mode are of no use.
Attaching a sample here:

Hello @sumit-gupta91 !
Seems like you are using not the last version of client-javascript, please reinstall the latest version of agent-js-playwright (it will use the latest version 5.0.8 of client-javascript with more verbose debug logs) and try again.

@sumit-gupta91  @vinilvasani @piti118
Hello guys!
Recently we've released the new version of the agent that should fix this issue.
Please try to run your tests with the latest version.
Looking forward for the feedback from you.

@AmsterGet Awesome. Let me upgrade and share results

@AmsterGet after upgrading to the latest version, we are no longer facing this issue. Thanks, for all the support.

So I'll close the issue.
Feel free to reopen if needed.


3350 change partnerbase text to essentials

Resolves #3350
Description
Changed the remaining user facing instances of "Partnerbase" to "Human Essentials"
Labeled the two different logins in the account request confirmation mailer and removed the link to /partner_users/sign_in
Changed the "Partnerbase" text at the top of the partner user sidebar to the Essentials logo svg

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
2 mailer tests were changed to reflect the new wording

@cielf Thanks for reviewing, is there anything else I need to do to complete this issue? (This is the first issue I've done)
I'm glad I could help and I'm hoping I can help more, the link to your slack goes to a broken heroku app, do you have a place where everyone talks or just in the github comments?

Hey @cotabas.  Thanks for the contribution -- could you tell me where the broken link is (this is me being lazy and not wanting to think...)?

@cielf It's in the README.md for human-essentials, here's the line:
Please feel free to join us on Slack! You can sign up at https://rubyforgood.herokuapp.com/ and find us in #human-essentials.

@cotabas Just letting you know we're merging this into main

@cotabas Thanks for your work on this -- we just released it!


[$2000] When quickly switching between chats, sometimes the bottom chat input disappears

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Account with many chats

Navigate through chats in LHN
Note Chat input display

Expected Result:
Chat input should always display
Actual Result:
When quickly switching between chats, sometimes the bottom chat input disappears for a moment and then loads back into view
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
Desktop App

Version Number: 1.1.39-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/155064103-777d2ae8-9f23-476e-b9a8-5fbdbb575c66.mp4
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644427079359789
View all open jobs on GitHub

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Hmmm, I'm not sure if the video isn't doing the bug justice, but the whole right side of the app is flashing, and the chat input always ends up being rendered, so this doesn't feel like a bug, or at least it's very perceptible. I checked the original post from @shawnborton and the proposal there makes sense, but I don't know how hard it is to do that, and considering this is almost imperceptible, I suggest we close this. CC @shawnborton @Expensify/contributor-management @Expensify/product

This happens to me daily and it seems like a regression from the UI we had a few weeks ago. I can reproduce it easier by doing a hard refresh in browser

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

Triggered auto assignment to @mountiny (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

We're alive! https://www.upwork.com/jobs/~0123ca18d28a1410b6  :frankenstein:

Yeah. This is not issue or bug.
But if you want to make stable then disable that textinput animation or disable bottom to top comes up. Make stable. I thought so

@Manoj-coder can you put together a little more information in your solution proposal? In case it's helpful, this section of our Contributing Guidelines has information on how to best form a solution proposal.
For example, which specific textinput animation are you suggesting to disable? Also, what do you mean by "disable bottom to top comes up"?

This is very similar to this issue https://github.com/Expensify/App/issues/4822  which we ended up closing.
I agree it's a bad UX and there should be a way of fixing this.
I see that the RHN opens fast, but then the loader is shown and the input is not rendered and focused till the whole list is rendered. If we could not add the loader and have the input render and focus before the list is ready, the UX should be much better.

Oh it also looks very similar to https://github.com/Expensify/App/issues/6069 no? Should we close one?

https://github.com/Expensify/App/issues/6069 relates to the RHN search bar so I would not say it is the say (we would most likely need to update that issue to accommodate for problems listed here which is too late now).
However, if this is caused due to some animation (which I can't even notice on the video) and disabling it won't change the behaviour significantly, I am up for just removing the animation to improve UX.

Waiting for updates.

@mallenexpensify let's consider doubling this? No proposals since 11 days

+1

Thanks gents!  Price doubled to $500
https://www.upwork.com/jobs/~0123ca18d28a1410b6

Doubled price to $1000
https://www.upwork.com/jobs/~0123ca18d28a1410b6

Doubled price to $2000, removed/added the Exported label to as a test (internal Slack convo here)

Let's get this retested. It seems to me that this issue was happening due to storage read/write blocks on Onyx. Marc was working on some improvements to the Onyx. Maybe this is resolved now.

Let's get this retested. It seems to me that this issue was happening due to storage read/write blocks on Onyx. Marc was working on some improvements to the Onyx. Maybe this is resolved now.

Are those in production? I surely saw this problem last week.
It happens usually when I load the app in the browser the first time and it is fetching all the data, then switching the chat reports did this.

I am not sure but PR was merged on ONYX about 10 to 12 days. May be test on Staging.

On Staging, (this is in no way objective measure), but it felt like it is occurring less often. It happened again after a hard refresh when other loads were happening, but then only when switching chats very quickly it did occur a couple of times, but definitely felt less frequent than on production.
Hence, that wcould be related to some performance improvement, but probably the problem was not removed completely.

Ok, I did some profiling.
TL:DR This is happening as we load data from Onyx. Onyx does not render the component until all the necessary data is available and how we navigate to the reports.
There are three components on the ReportScreen.

Header (title)
Actions. (messages)
Composer (the input)

On Loading on report screen, All three subscribe to Onyx for data. Based on profiling results it seems that there is some delay between the rendering on all three. They are rendered in the order as shown above. When the delay between rendering is big it creates sluggish behavior. This behavior will be severe on low-end devices.

HEADER
Actions
Composer

As you can see, when Composer is not present the Actions takes all the available space. So due to rendering order, Composer will be pushed in from the bottom. This creates the mentioned sluggish behavior (where input slides from the bottom).
Solution

I suggest using the APP Shell pattern but only for Report Screen. I will create a Shell component that renders the Header and composer first and the Actions.
This is very simple to achieve

Use a state variable and when composer is mounted turn the state flag on. When the flag is true let the Actions view load.

HEADER
Actions - Composer

This affects only the behavior where Composer is shown after the messages are loaded and it looks like sliding in from bottom
But first, The expected behavior of this issue is really not possible unless we change the navigation.
Why :thinking: ?
We remount the ReportScreen on each report change. This process removes the Reportscreen from the UI and then reattaches it which means all three components are removed and readded on each report change. Changing navigation means refactoring a lot of things.

📣 @parasharrajat You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Thanks, @mountiny. As soon as I get time, I will continue the investigation. Just trying to see the problem in more detail.

Hired @parasharrajat in Upwork, removed @rushatgabhane as C+ cuz Rajat is also C+

Agreed, no need to rush on this one!

@parasharrajat I assume here it is similar as it was on the other issue, since your setup works again feel free to delve into this once you get around, however, I understand you must have other things aligned. This is probably not the highest priority

Thanks. I will be able to in 2 days.

Completely missed this issue. I will submit the PR by EOD with the above proposed solution. I spent some more time trying to find a better solution but I didn't find any which does not break existing functionality.

Thanks!

I am going ooo for 5 weeks so I am re-assigning some CME issues assigned to me. Here, @parasharrajat is already assigned to this issue and works on the PR for it. Thank you for helping @pecanoro!

I was sick for the last few days, still am. But I will send the PR in the next few days. Sorry for the delay.

I will make the PR shortly.

@parasharrajat , can you provide an update plz?

I will push the PR today. Sorry for delay completely missed this.

Sorry, just seeing the linked PR here and it feels like a workaround that points to some larger issue elsewhere in the code.
I read the explanation here. But still don't really understand why we need to wait until the chat compose input mounts before loading the conversation.

On Loading on report screen, All three subscribe to Onyx for data. Based on profiling results it seems that there is some delay between the rendering on all three. They are rendered in the order as shown above. When the delay between rendering is big it creates sluggish behavior. This behavior will be severe on low-end devices.

It sounds like we are saying that the root cause is "slow rendering" or maybe related to getting values from Onyx, but instead of solving this performance issue we are just making sure the "input" renders before the chats by blocking the render of the chats until the input is done.
Won't that make performance even worse because instead of both the input and chats rendering together we are doing the rendering in sequence?

It sounds like we are saying that the root cause is "slow rendering" or may be related to getting values from Onyx

No, I didn't mean to say slow rendering.
I think this is the current behavior.
This code will wait for all subscriptions to be resolved with data on a component.
https://github.com/Expensify/react-native-onyx/blob/f6c2b03f29193bbceca68a9997fa94cc998f52a6/lib/withOnyx.js#L160
ReportScreen is using flexbox. Flex: 1 takes all the available space. ReportActionsView is using flex:1. When the composer is not rendered report screen will fill the available space. So when the composer is rendered after the reportActionsView, it looks like it pushing the messages up as UI is adjusting positions.

Won't that make the performance even worse

IMO, there could be a couple of milliseconds difference but I don't think so. Rendering both together can also create performance issues. They can cause a drop in fps resulting in bad UX. I will check this.

Open to alternatives.

This code will wait for all subscriptions to be resolved with data on a component.

That is my understanding of how withOnyx works. But how does it contribute to this issue specificalyl?

ReportScreen is using flexbox. Flex: 1 takes all the available space. ReportActionsView is using flex:1. When the composer is not rendered report screen will fill the available space. So when the composer is rendered after the reportActionsView, it looks like it pushing the messages up as UI is adjusting positions.

Sounds like an alternative would be to just render the composer in a View with a minimum height? Then there's not need to prevent the rendering of the chats or block things until other things mount. Though that would just leave us with a blank white space until the input renders.

IMO, there could be a couple of milliseconds difference but I don't think so. Rendering both together can also create performance issues. They can cause a drop in fps resulting in bad UX

Got any more details here? It sounds like you have spotted a performance issue, but this statement sounds contradictory. If it only takes a couple of milliseconds to render the chat list after the input then why does rendering them separately make any difference?

Sounds like an alternative would be to just render the composer in a View with a minimum height?

I was also thinking the same. I think the rendering gap is very less so it should be not noticeable. Let me try this out.

Got any more details here?

Sorry, no. I was just thinking aloud. But I will try to measure to see if this is true in our case.

If it only takes a couple of milliseconds to render the chat list after the input then why does rendering them separately make any difference?

Hmm. Good point. No idea for now.

No update for now. Need to try the suggestion.

PR in review, holding on Rajat to try a couple of things.

@parasharrajat can you provide an update? Looks like the last one was 16 days ago
https://github.com/Expensify/App/pull/8881#issuecomment-1127879173

My last PR does not seem the best solution to the issue. So I would have to dig in more to find a better one. Currently I don't have any ideas. I will try out a few discussed things on weekend and update here the next step.

Update and/or next steps @parasharrajat ?

Didn't get the time to work on this but I will try to test that approach. On the other hand, I don't have any problem with reopening this to other contributors.

@parasharrajat I'd say.. if you don't have a viable, accepted solution and/or if you're unsure you'll have time to work on it, we should open it back up and add the Help Wanted label

Still no update. I will look into this tomorrow. Otherwise, open this to the pool.

Is this issue open for proposal?

Yup. This is open, I don't have enough time to research this. @mallenexpensify Could you please apply the Help wanted label? Thanks.

Proposal
Resson:
https://github.com/Expensify/App/blob/9484115658340dd6db6b083fd652bc23630bd87e/src/pages/home/ReportScreen.js#L229
Inside this View (say ViewContainer), we have 3 components FullScreenLoadingIndicator, ReportActionsView and View (compose box inside this view) that renders based on some conditions.

We are displaying either FullScreenLoadingIndicator or  ReportActionsView and Compose box.

The issue here is that we are adding and removing children component (in the beginning) in ViewContainer and this seems to re render the entire ViewContainer component in order and the compose box is rendered after the ReportActionsView (this takes some noticeable time)
Source: https://reactjs.org/docs/reconciliation.html#recursing-on-children
Solution:
Move this block to before KeyboardAvoidingView closing tag.

Before
https://user-images.githubusercontent.com/77761491/174877946-fd2bcc84-4f1c-4d3f-80e3-59244eb49e11.mp4
After
https://user-images.githubusercontent.com/77761491/174877978-29c8d430-26ef-46cd-adfa-31110625d936.mp4

Organization moderators, and anyone with write access to a repository, can hide comments on issues, pull requests, and commits.

I do not have that option.

Waiting for proposals

Oh boy, this issue is pretty deep in the weeds to step into. 😅 I haven't really noticed this myself before, but granted it is reproducible.
Before I get this job back on Upwork (it's no longer accepting proposals since Rajat was hired), can someone summarise where we're up to, so we can add that context to the OP for the next volunteer? What have we tried? why didn't we like it/why didn't it work? Do we have an inclination as to what direction we want to go in with the solution?
Also, with the Skeleton UI PR close, might that improve things here?

I am afraid we haven't made much progress on this issue as it is quite tricky. I am not sure if the Skeleton UI will solve this, however, I don't think it would hurt to put this on HOLD for that Skeleton UI PR to get merged and see if this can be still reliably reproduced.

Yeah, I thought the animation on switching might help. That said, I was checking in on the skeleton UI PR and noticed this comment:

It seems that we've recently refactored how the loading flags are loaded

That prompted me to retest this issue to try and reproduce it and I can't (prod v1.1.85-8 chrome web, ). The chat input loads consistently when switching chats and doesn't disappear.
I'm presuming the API refactors has taken care of this, does someone else on this issue want to confirm by trying to reproduce before I close?

I think you can close this one out and if this comes back as a persisting problem, we could re-open.
I have also tried to reproduce it and I could not really get any significant UI jumps or anything weird. I think by focusing on it too much I could see like a dropped frame where it has disappeared, but I would definitely not notice it during a normal use. Feel free to close this one out @trjExpensify!

Cool, thanks @vitHoracek. Done!

I also couldn't reproduce this so I agree, close it up!

Oh, good question. The PR was closed and opened up for new solutions, right? I don't think we'd pay in that scenario, for a solution that wasn't viable in the end. Curious for @mountiny & @pecanoro's thoughts as well.

I don't think we'd pay in that scenario, for a solution that wasn't viable in the end.

I'm not sure if it's written down (let's get on it if not) but I recall some precedent for paying out jobs that we later find alternative solutions for or find some disagreement about the accepted proposal. It seems we hired @parasharrajat to do something and later asked to pause the work. So I think we dropped the ball in the design stage where we accepted the proposal or perhaps later when we challenged the proposal.

I think the problem here was that the problem disappeared after a while and we could not reproduce reliably. I think that paying out the default amount of $250 would be a reasonable since paying out the full amount for this fells like a bit too much, but not paying out anything is also not the best way forward as it is not the contributors fault the solution was not needed and they invested their time.

I'm following along here and wanted to jump in to say I agree with @marcaaron, and think @mountiny has suggested a good path forward (so long as @parasharrajat agrees that is a fair comp for the time invested!)

Cool, thanks for the discussion everyone. Settled up $250, Rajat.


Added avatars

I dont seem to have perms to resolve modify/delete conflicts, idk, its up to you

Will check it in a minute

@BidemiEnoch update your branches


Messaging: Legacy plan migration

Messaging
Context
https://posthog.slack.com/archives/C043VJ93L3B/p1720568728209939
Audience / Targeting
https://docs.google.com/spreadsheets/d/1PPoHdUy2EV2EeeR-eyuzmFzoxUk2Vp8AyHWSNAKHL1E/edit?gid=1474575637#gid=1474575637
Resources, timeline, responsibilities
1x email, from C.io, to all users in these orgs, to be sent giving them two weeks warning.
Requested input
Are there any outstanding questions, potential blockers, or feedback you need? Spell it out.
Previews
Incoming soon.

Feedback welcome, @camerondeleone @zlwaterfield @minekansu

This looks good to me. If people respond with frustration we can say "hey, look, you got this product for free by mistake for x months/years, and with sampling you can still get coverage for most scenarios for free or little cost."

"hey, look, you got this product for free by mistake for x months/years, and with sampling you can still get coverage for most scenarios for free or little cost."

Why don't we actually say some version of this? Saying 'legacy plan' doesn't mean anything to a customer, only to us internally as a business. As it's written right now, it's very vague, both in terms of what I'm on and what I'm moving to.

Sorry couple of followup questions here:

If the customer was already using less than 5k anyway, we could probably reframe this as 'we're moving you onto our new plan which gives you up to 5k replays free'
If they were using way more than 5k and not paying, shouldn't we tell them 'hey heads up if you continue at your current rate, this will cost you X?' (Or something to basically avoid the annoyed shock bill effect)

(Don't feel strongly about this btw, if you just want to get this out then go ahead!)

Yeah, I'd like to push ahead here and will schedule it to go out on Monday. Your second point is a good one, but it'd be just a bigger lift to get it done compared to the value I think it'd add vs just having those customers reach out to us and having a conversation. Appreciate the feedback though!


Make Cloudflare email an optional field

What this PR does / why we need it:
Cloudflare does not require an email to be sent when using token based auth.
We should make the field optional if tokens are used.
Which issue this PR fixes
fixes  #2972
Release note:

DNS01: make Cloudflare email optional if a token is used

/kind cleanup

/lgtm


Add support for filtering within arrays

@zikaari I assume you'll add a changeset per our offline discussion 😄


More automated Textures type.

Hello,
Looking at the examples I see that clients(the code calling into imgui-rs as the UI) fully manages textures on behalf of a renderer(the code called from imgui-rs as... the renderer).  I don't think this is endemic rust.  The main issue, as I see it, is that a Texture could be forgotten and leak.
I'm working with my own wrapper around ash/vulkan(https://gitlab.com/cheako/ash-tray-rs/-/blob/2fb15f08db2d6eeeb087a3725abd26ae6b413512/src/vk_helper.rs#L1867) where, when adding ImageView to a CommandBuffer, a reference is held until the CommandBuffer completes.
I'd like to be able to pass a *mut RcBox as the texture_id and have the *renderer increment texture_id.strong.  Then after the CoommandBuffer has clones of all the parts, decrement texture_id.strong.  Thus automagically cleaning up the ImageView(s) if the client no-longer has an Texture object that contains them.

The renderer passes control back to the client after the draw call for an image, but hasn't recorded the CommandBuffer yet.  So for that time an Rc needs to be held.

I made this change 2 some C code: https://gitlab.com/cheako/imgui/-/commit/d8fd4a5410372cc2767d22d218cdaccb42caa231 Then I updated the binding: https://gitlab.com/cheako/imgui-rs/-/commit/4d0ae28ece21f90c4ba1b1fc78e31e79a522ec82 Though now when I call into imgui_sys::igSetTextureCallback I get the address of the Option(on the stack), not the compiled fn to C and when the CB fires it's basically trying to run the current stack frame.

Doesn't crash or draw the gui...  Can lockup the machine.
https://gitlab.com/cheako/hazel-rs/-/tree/46b45867b3a70617bf439aa63899c3b873f55114


python310Packages.pybtex-docutils: 1.0.1 -> 1.0.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pybtex-docutils is: "A docutils backend for pybtex"
meta.homepage for python310Packages.pybtex-docutils is: "https://github.com/mcmtroffaes/pybtex-docutils"
meta.changelog for python310Packages.pybtex-docutils is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.0.2 with grep in /nix/store/l6j0ba59hr0p1gjpbqlxk69i4l4aj1vp-python3.10-pybtex-docutils-1.0.2
found 1.0.2 in filename of file in /nix/store/l6j0ba59hr0p1gjpbqlxk69i4l4aj1vp-python3.10-pybtex-docutils-1.0.2

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pybtex-docutils
python310Packages.sphinxcontrib-bibtex
python39Packages.pybtex-docutils
python39Packages.sphinxcontrib-bibtex

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l6j0ba59hr0p1gjpbqlxk69i4l4aj1vp-python3.10-pybtex-docutils-1.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pybtex-docutils https://github.com/r-ryantm/nixpkgs/archive/22199bf7aaa5f3170a063497b9b3ce08d681150a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l6j0ba59hr0p1gjpbqlxk69i4l4aj1vp-python3.10-pybtex-docutils-1.0.2
ls -la /nix/store/l6j0ba59hr0p1gjpbqlxk69i4l4aj1vp-python3.10-pybtex-docutils-1.0.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

python310Packages.pybtex-docutils
python310Packages.sphinxcontrib-bibtex
python39Packages.pybtex-docutils
python39Packages.sphinxcontrib-bibtex

Maintainer pings

Result of nixpkgs-review pr 174682 run on x86_64-linux 1

4 packages built:

python310Packages.pybtex-docutils
python310Packages.sphinxcontrib-bibtex
python39Packages.pybtex-docutils
python39Packages.sphinxcontrib-bibtex


Problems with BLE under Android 5.1.1

Hello,
We have an application that was fine running under Android 4.4.2.
But with Android 5.1.1 we are getting connection problems, timeout on connection and unstable Bluetooth (switches on and of).
We have updated the Cordova library.
Do you know of any issues with the newer Android operating system?
Regards,
Rolf

I have not encountered this myself, though I have a vague memory of seeing another similar report. What hardware are you using? I have a Nexus 6.

samsung s6
Sendt fra min Samsung Galaxy-smarttelefon.
-------- Opprinnelig melding --------
Fra: Fredrik Eldh<EMAIL_ADDRESS>Dato: 07.08.2015 17:39 (GMT+01:00)
Til: evothings/cordova-ble<EMAIL_ADDRESS>Ko: Rolf Kahrs Hansen<EMAIL_ADDRESS>Emne: Re: [cordova-ble] Problems with BLE under Android 5.1.1 (#74)
I have not encountered this myself, though I have a vague memory of seeing another similar report. What hardware are you using? I have a Nexus 6.

Reply to this email directly or view it on GitHubhttps://github.com/evothings/cordova-ble/issues/74#issuecomment-128739496.

I don't have an S6, I don't have your app, I don't have whatever BLE device the app is talking to, and the problem is intermittent. Tricky. :/
Perhaps you can try some other phone. Also it would be helpful if you would try some of the Evothings examples.

We will research this further and get back

Hi
We changed the delay times (-> shorter) on the device and that helped!
Another question: Can Cordova (with BLE) be ported to Windows?

Good to hear! I'll mark this issue closed.
Cordova itself is already ported to Windows (8+, Phone 8+).
This plugin could also be ported. One would need to add C# implementations of all the functions declared in ble.js.

Hi Fredrik
Sounds good.
Do you have someone who can port the plugin for us please?
Regards,
Rolf
Rolf Kahrs Hansen, Dr.Scient
[logo_skjerm small]
Nattlandsveien 8, 5093 Bergen, Norway
eMail: rolf<EMAIL_ADDRESS>Telephone: + 44 20 81339064
Mobile: +47 9929 4592
Spiro Medical AS  is registered in Norway: NO 996 744 663 MVA
This e-mail and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this e-mail in error or you are not the named addressee, please let us know by e-mail reply and delete it from your system. You should not disseminate, distribute or copy this e-mail, or disclose its contents to anyone. The recipient should check this e-mail and any attachments for the presence of viruses. Although the company has taken reasonable precautions to ensure no viruses are present in this e-mail, we cannot accept responsibility for any loss or damage arising from the use of this e-mail or attachments.
[http://www.mills-reeve.com/files/Uploads/Images/Mills & Reeve LinkedIn.png]https://www.linkedin.com/company/3183464?trk=vsrp_companies_res_name&trkInfo=VSRPsearchId%3A2333039261410855463135%2CVSRPtargetId%3A3183464%2CVSRPcmpt%3Aprimary
From: Fredrik Eldh<EMAIL_ADDRESS>Sent: 22 September 2015 16:09
To: evothings/cordova-ble<EMAIL_ADDRESS>Cc: Rolf Kahrs Hansen<EMAIL_ADDRESS>Subject: Re: [cordova-ble] Problems with BLE under Android 5.1.1 (#74)
Good to hear! I'll mark this issue closed.
Cordova itself is already portedhttp://cordova.apache.org/docs/en/5.0.0/guide_support_index.md.html to Windows (8+, Phone 8+).
This plugin could also be ported. One would need to add C# implementations of all the functions declared in ble.js.
—
Reply to this email directly or view it on GitHubhttps://github.com/evothings/cordova-ble/issues/74#issuecomment-142299693.


LASR Dev Build 0.2 (game dosent appear to randomize like the previous version)

When using 0.1 the title screen would shows "The legend of zelda link's awakening RANDOMIZER" which i have been using to check if the game loaded the randomzied files.
As of Build 2.03 The title screen only shows "The legend of zelda link's awakening" which makes it hard to know whether the game is randomzied. and when loaded none of the items were randomized.

Hello, sorry for the late response! New version .0205 is out. It fixes a
ton of bugs, however the generation did work fine on 0.203. I suspect
the issue here is because there's now an extra folder in the output
containing the game's title ID. Example: ArrogantBusyFox/TitleID/Romfs/...


Refactor listing status icon to its own component

AMLNG-215 and AMLNG-820
There is a new file created called ApprovalStatusIcons which is the source of all icons relating to approval status. It serves as the single point of reference and a location for changes to be made to icons if necessary.
Additionally, in there is now a new set of filters on the Listing Management/My listings page. There are two new Pending filters which allow the user to see listings that are waiting for Organization approval and AML admin approval. There is also a Deleted filter. The filters on the My Listings tab now work in the same way that the All Listings and Org Listings tabs work.
To test, check functionality of these modifications against the existing master. The notable areas to check are listing management page (All tabs and filters) and administration tabs on listings. Also, the My Listings tab in listing management has went through interface changes. Please review it for new functionality described above.

Take a look at making the icon for Pending AML Approval  (also seen as Pending, Center in the Admin tab of a listing) consistent regardless of user type.
The icon in the left menu using the 'loading' icon for both pending options, but an admin will see an [!] for Listing in the Pending AML Approval state.  Visually it's confusing when All Listing are shown, and the user sees an [!] but the "Needs Action" menu item has 0 items.

Moved styling and made change to Needs Action Icon as requested. Below is a picture of the change. Know that this is the expected outcome, and the NavBar(below the listing) is the same on each screen and therefore cannot be modified within the scope of this ticket.

Everything looks good.
Explanation of the status icons makes sense.
👍

@flesher1 - we need to revisit the workflow states and determine as a team what is the workflow and how should that be visually presented to the end-user. This is out of the scope of this task. I will create a Jira ticket to address.
:+1:


Creating a dev drive takes me to a confusing view

Clicking here:

Takes me here:

Not sure what I am supposed to configure here?

Same thing happens on the dev channel of windows

+1 didn't find the option to create a dev drive. I think the prerequisites have been all reached.
https://learn.microsoft.com/en-us/windows/dev-drive/#prerequisites

@localden, @Jinjiang @fflaten @loczek
Dev Drive functionality was released today in build 23466.
https://blogs.windows.com/windows-insider/2023/05/24/announcing-windows-11-insider-preview-build-23466/
Let us know/create another issue if anything else you see from that build seems out of place. Thanks. Will update our check in Dev Home with this build number for now.

Thanks for the update @bbonaby, will try it out 😃
Still, the app is also available for stable channel so the button should inform users with unsupported builds some way.

I'm on the dev build, 23466.1001, and it isn't showing up.

It works. Thanks.

Hey @Jinjiang, what happened? Did you change anything, or has it just appeared?

I just updated my Windows to the latest dev version and the button showed up immediately


在手机 termux安装失败

我在手机上面使用termux进行安装失败了提示信息
`
done
INFO: pip is looking at multiple versions of ddddocr to determine which version is compatible with other requirements. This could take a while.
Collecting ddddocr
Downloading ddddocr-1.5.4-py3-none-any.whl.metadata (17 kB)
Downloading ddddocr-1.5.3-py3-none-any.whl.metadata (16 kB)
Downloading ddddocr-1.5.2-py3-none-any.whl.metadata (16 kB)
Downloading ddddocr-1.4.11-py3-none-any.whl.metadata (11 kB)
Downloading ddddocr-1.4.10-py3-none-any.whl.metadata (10 kB)
Downloading ddddocr-1.4.9-py3-none-any.whl.metadata (10 kB)
Downloading ddddocr-1.0.6-py3-none-any.whl.metadata (1.2 kB)
INFO: pip is still looking at multiple versions of ddddocr to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install ddddocr==1.0.6, ddddocr==1.4.10, ddddocr==1.4.11, ddddocr==1.4.9, ddddocr==1.5.2, ddddocr==1.5.3, ddddocr==1.5.4 and ddddocr==1.5.5 because these package versions have conflicting dependencies.
The conflict is caused by:
ddddocr 1.5.5 depends on onnxruntime
ddddocr 1.5.4 depends on onnxruntime
ddddocr 1.5.3 depends on onnxruntime
ddddocr 1.5.2 depends on onnxruntime
ddddocr 1.4.11 depends on onnxruntime
ddddocr 1.4.10 depends on onnxruntime
ddddocr 1.4.9 depends on onnxruntime
ddddocr 1.0.6 depends on onnxruntime
To fix this you could try to:

loosen the range of package versions you've specified
remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
`

手机一般是arm芯片，arm芯片原生onnxruntime不支持，需要自行寻找解决办法


Cleanup: PHP 5.3 support end

Finally! thx @Ocramius !

Sweet!

@deeky666 this will force you to make Doctrine ORM 2.4 an LTS for people being stuck with PHP 5.3 support

http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/getting-started.html#guide-assumptions


Failed to get containers in resource: error: there is no need to specify a resource type as a separate argument when passing arguments in resource/name form (e.g. 'kubectl get resource/<resource_name>' instead of 'kubectl get resource resource/<resource_name>'

most actions are failign with this kind of error:
For instances:
when retrieving logs:
Failed to get containers in resource: error: there is no need to specify a resource type as a separate argument when passing arguments in resource/name form (e.g. 'kubectl get resource/<resource_name>' instead of 'kubectl get resource resource/<resource_name>'

when callign a get:
kubectl get pod/kube-system   coredns-74ff55c5b-b878p --namespace all -o wide
error: there is no need to specify a resource type as a separate argument when passing arguments in resource/name form (e.g. 'kubectl get resource/<resource_name>' instead of 'kubectl get resource resource/<resource_name>'

VS Code Kubernetes version used 1.2.3
kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:28:09Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:20:00Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes instance was installed using minikube 1.17.1

@apupier i think this is fixed. Can this be closed or you still face the error? Thanks

i confirm that it is fixed.
Thanks


Combination of italic with custom markdown element not working

Reproducible for the case when text has mixed text-decoration style with custom markdown element. In my case. I have the custom element that not supports by markdown be default - underline(++). I implement the custom markdown element for parsing (like MarkdownStrikethrough).
class MarkdownUnderline: MarkdownCommonElement {

	var font: MarkdownFont?
	var color: MarkdownColor?

	private static let regex = "(.?|^)(\\+\\+)(?=\\S)(.+?)(?<=\\S)(\\2)"

	var regex: String {
		return MarkdownUnderline.regex
	}

	public init(font: MarkdownFont?, color: MarkdownColor? = nil) {
		self.font = font
		self.color = color
	}

	public func match(_ match: NSTextCheckingResult, attributedString: NSMutableAttributedString) {
		attributedString.deleteCharacters(in: match.range(at: 4))

		var attributes = attributedString.attributes(
			at: match.range(at: 3).location,
			longestEffectiveRange: nil,
			in: match.range(at: 3)
		)

		attributes[.underlineStyle] = NSNumber.init(value: NSUnderlineStyle.single.rawValue)

		attributedString.addAttributes(attributes, range: match.range(at: 3))

		attributedString.deleteCharacters(in: match.range(at: 2))
	}
}

But parsing result is not correct, for example for text **_++Lorem ipsum++_** will be produced the attributed text:

_++Lorem ipsum++_

If I change the regex to (.?|^)(\\*|_)(?=\\S)(.+?)(?<=\\S)(\\2) ,that was implemented for fix, the parsing result is correct.

I tried parsing with your custom element and it works fine. The last merged PRs haven't been published yet, though. Do you possibly use the latest version (1.7.1)? If yes, could you check if switching to the master branch fixes your issue?

@gaebel Yep, you are right. I provided a not correct example, sorry - that is my bad. If be more correct  - parsing result for  **_  Lorem ipsum  _** is correct, but if you change the order of applying the styles to ++_**Lorem ipsum**_++ - result will be not correct.
Test text:
let test = """
 ++_**Mixed U/I/B Cras non erat dolor. In euismod laoreet iaculis. Aliquam viverra rutrum dui, at volutpat orci tempus et.**_++

 **_++Mixed B/I/U Cras non erat dolor. In euismod laoreet iaculis. Aliquam viverra rutrum dui, at volutpat orci tempus et.++_**
"""

Result 1.7.1:

Result master: 072e192:

Result master: 072e192 + modified regex for italic element to(.?|^)(\\*|_)(?=\\S)(.+?)(?<=\\S)(\\2):

Looks like order makes sense.

The nesting order should not matter, I've made some changes to the regex, and the attribute inheritance.

@gaebel Release this fix please


Disable Github CI on mac.

Github Actions mac checks are failing globally: https://github.community/t5/GitHub-Actions/macOS-VM-failing-immediately/m-p/36969#M2743
Disabling them until workaround and/or fix is available.
Related-To: HARP-7766
Signed-off-by: Zbigniew Zagorski<EMAIL_ADDRESS>

Codecov Report

Merging #997 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #997   +/-   ##
=======================================
  Coverage   48.78%   48.78%
=======================================
  Files         231      231
  Lines       21746    21746
  Branches     4956     4956
=======================================
  Hits        10609    10609
  Misses      11137    11137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af48c1b...7744994. Read the comment docs.


Feature request: Animation options for Mouse Click events

It would be cool if we could animate the little circle that appears when you click in a recording. I'm imagining something like this:
https://support.loom.com/hc/article_attachments/360012106797/Screen_Recording_2018-11-22_at_05.44_PM__1_.gif
It seems like this could be added to the UI without having to totally rework it by adding two options to the Mouse Clicks user interface in Tasks:

Number of frames (or length of time) to display click graphic
Number of frames (or length of time) to delay the start of the click graphic

Then we could basically add 5 Mouse Click Tasks to achieve a very nice looking click animation as shown in the link above. Something like this:

2x2 yellow circle, opacity 100%, show for 1 frame, delay by 0 frames
4x4 yellow circle, opacity 80%, show for 1 frame, delay by 1 frame
6x6 yellow circle, opacity 60%, show for 1 frame, delay by 2 frames
8x8 yellow circle, opacity 40%, show for 1 frame, delay by 3 frames
10x10 yellow circle, opacity 20%, show for 1 frame, delay by 4 frames

Hello,
I think this feature would be super useful 👍
Are you planning to implement it?


URL is in the Preview > Details view is truncated, leave full url and wrap to new line when too long

@wski This does not appear to be working in IE. Looked fine in FF and Chrome.

PR https://github.com/ozone-development/ozp-center/pull/336 should fix the IE issue

Verified working (testUser1) in all browsers (IE9, IE11, FF24, CH36)

Verified that the URL looks correct and is word wrapped on all of the browsers on Staging. (IE9, FF, Chrome)


Fix MLIR python binding after MLIR commit da784a2

Commit da784a2 in the MLIR repo adds an overload to mlir::Block::moveBefore and so we need to specify which overload we're using
Ref: https://github.com/llvm/llvm-project/commit/da784a25557e29996bd33638d51d569ddf989faf

In general we fix these issues when we do an LLVM update, which the Google folks manage.
Perhaps we should just wait for that?  Any reason to take this patch now?  (If you need to build with a newer LLVM, you can of course carry this patch locally, I don't expect that should be a big deal?)

Makes sense! Will close this. thanks!

cc @gflegar for your next update


Clarify PS reporting for registered users

Derived from AAD MFA supportability case review

@mmcla : Thanks for your contribution! The author, @MicrosoftGuyJFlo, has been notified to review your proposed change.

#sign-off

@Jak-MS : Thanks for your contribution! The author, @MicrosoftGuyJFlo, has been notified to review your proposed change.


License comment is missing in the main JS file (dist/index.js)

Including license comment into the main JS file would make it easier for deeplearn.js users to include it into their own build.

This issue was moved to tensorflow/tfjs#66


Create object with dynamic keys

It's currently only possible to create an object with pre-defined keys:
{"foo": "bar"}

But it's not possible to create an object with dynamic keys:
(let ((name "foo"))
  {name: "bar"}
)

Use-case:
Say you have key-value pairs associated with an account. Ideally, if you know all property keys, you would store them with the following schema:
(defschema properties-schema a:string b:bool c:decimal)
(defschema accounts-schema properties:{properties-schema})
(deftable accounts:{accounts-schema})

(insert accounts account {"properties": {"a": "foo", "b": true, "c": 0.0}})

The above code works, but if property keys ("a", "b", "c") are unknown beforehand, you'd ideally want to define a generic object and accept any keys to it:
(defschema accounts-schema properties:object)
(deftable accounts:{accounts-schema})

(let ((k1 "a") (k2 "b") (k3 "c"))
  (insert accounts account {"properties": {k1: "foo", k2: "bar", k3: 0.0}})
)

The code above fails.
Assume account and property values come from somewhere else.

Closing issue as dynamic keys were disabled intentionally to allow objects to function as record types tractably in the property system/z3.
Tables are arbirarily keyed and with key concatenation can serve as a "sub-table" where a dynamic object would be needed.
Can re-open if some use-case is genuinely not possible with current system.

i think it can be very valuable ... think of Manifests (Marm)
Hello, requesting to re-open for json upgrades
without this, the only way to upgrade a manifest would be to have the policy submit a new datum for example, to replace one of the data [datum] entries. (Because data/datum are known by ledger, whereas inner keys are not)
Vs With Variable Keys :
You could implement a generic way to upgrade a manifest as per Haber paper, have some Function (path, operation, operand) that goes through json manifest to perform operation at path
and then store that transform method and very generically upgrade at that path, and store original, F, hashes.
upgrades can happen at ledger level, where as policy would enforce the upgrade based on path, and can check types if they need or just path, it would also allow u to rebuilt & verify changes over time on ledger.
@sirlensalot does this qualify ?

It sounds like the functionality you describe would allow the solution to be implemented more generally, but the solution can still be accomplished today, albeit more explicitly.
Pact's restrictions are its biggest feature, since this is what makes real-time, automated Formal Verification tractable and useful. I'm hesitate to increase generality for convenience, if external tooling can accomplish the same task.


Allow to define per api ImageCache size

We are able to deploy an arbitrary number of glanceAPI. Each api/replicas, however, should have its own image-cache pvc as they are separate entities.
This patch improves the API to allow to either inherit the imageCacheSize or define it on a per instance basis.

@konan-abhi this should be more aligned for what we need in a regular or DCN deployment.
Suppose I deploy 3 API (default, default2, default3):
glance-default-single-0     3/3     Running     0          9m16s
glance-default2-single-0    3/3     Running     0          8m12s
glance-default3-single-0    3/3     Running     0          7m29s

I can select which one should have the image-cache pvc. In my test I added it on both default and default2, but not on default3, resulting in the following layout:
glance-cache-glance-default-single-0
glance-cache-glance-default2-single-0
glance-glance-default-single-0
glance-glance-default2-single-0
glance-glance-default3-single-0

    default:
      imageCacheSize: 2G
      type: single
    default2:
      imageCacheSize: 2G
      type: single
    default3:
      type: single

@konan-abhi this should be more aligned for what we need in a regular or DCN deployment. Suppose I deploy 3 API (default, default2, default3):
glance-default-single-0     3/3     Running     0          9m16s
glance-default2-single-0    3/3     Running     0          8m12s
glance-default3-single-0    3/3     Running     0          7m29s

I can select which one should have the image-cache pvc. In my test I added it on both default and default2, but not on default3, resulting in the following layout:
glance-cache-glance-default-single-0
glance-cache-glance-default2-single-0
glance-glance-default-single-0
glance-glance-default2-single-0
glance-glance-default3-single-0

    default:
      imageCacheSize: 2G
      type: single
    default2:
      imageCacheSize: 2G
      type: single
    default3:
      type: single

This makes sense, AFAIK in edge deployment we don't need image to be cached at central node, so can we say cache is/should be disabled on central node?
If yes, then can we simply attach PVC is caching is enabled?
Otherwise if we don't want to go this way, then this mechanism completely looks good.

@konan-abhi this should be more aligned for what we need in a regular or DCN deployment. Suppose I deploy 3 API (default, default2, default3):
glance-default-single-0     3/3     Running     0          9m16s
glance-default2-single-0    3/3     Running     0          8m12s
glance-default3-single-0    3/3     Running     0          7m29s

I can select which one should have the image-cache pvc. In my test I added it on both default and default2, but not on default3, resulting in the following layout:
glance-cache-glance-default-single-0
glance-cache-glance-default2-single-0
glance-glance-default-single-0
glance-glance-default2-single-0
glance-glance-default3-single-0

    default:
      imageCacheSize: 2G
      type: single
    default2:
      imageCacheSize: 2G
      type: single
    default3:
      type: single

This makes sense, AFAIK in edge deployment we don't need image to be cached at central node, so can we say cache is/should be disabled on central node?
If yes, then can we simply attach PVC is caching is enabled?
Otherwise if we don't want to go this way, then this mechanism completely looks good.

I think with the current approach we can selectively add imageCache for a particular GlanceAPI, regardless of the DCN scenario. What you described is totally possible here, but we rely on the fact that the StatefulSet automatically creates the PVC for us using VolumeCaimTemplates (even when you scale replicas up).
In terms of User experience, we can control this behavior using the imageCacheSize parameter: in the previous patches, where we only had a single glanceAPI, it was a global (top-level) parameter, while now we are able to selectively enable caching for a given instance, which meet the DCN requirements.
There is a follow up patch that also takes care about the associated cronJobs, but I think it's easier review smaller pieces of code that solve a particular problem.


Updated improved script.  Added a helper Json file.

1). Updated improved script.
2). Added a helper Json file.

lgtm!


⚠ ClamAV has degraded performance

In 21b966f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 241 ms

Resolved: ClamAV performance has improved in 5fbcac5.


add yaml validation

This PR adds yaml validation at an early stage before uploading YAML files to the bucket.
It validates yaml files under the targetDir only.
Fixes #2887
Signed-off-by: Chanwit Kaewkasi<EMAIL_ADDRESS>

Next ticket: #2986


Upgrades operator-sdk to v0.13.x

This commit upgrades the operator-sdk verstion to v0.13.x
REF: Upgrade aws-account-operator to sdk v0.16.x
Includes changes introduced in #501, #500 & #499
Signed-off-by: Christopher Collins<EMAIL_ADDRESS>

Included in #506, merged.


Transparent image overlap when using Overlap=0 in dzi

When using overlap=0 in dzi, we get a ~1px grid/border around each tile.

Include a zip as a test, with no changes:
overlap_test.zip
Changing the clearReact size.x/y to -1 instead of -2 fixes the problem. There could be adverse effects that I'm not aware of.

This seems like a good change. It makes sense that trimming a pixel off of every side leaves overlap (which appears here as darker areas). By trimming off of just one side, we allow things to abut properly.
I guess one thing I'm curious about is whether the DZI tile overlap has any effect on this... This sample is done with overlap 0... What if we had overlap of 1 (and the same transparency)? It would be great if we could fix this so it would work for that scenario as well. @Dvidan would you be up for giving that a try?
@avandecreme I'm curious if you have any thoughts.

I can fix one with overlap 1 on monday, with the same image and transparency. I don't have access to the files at home. Anything else that would be good to have?

Overlap 1:

With PR:

Zip contain example code and with both overlap 0 and 1.
overlap_test_0_and_1.zip

@avandecreme Yes, it probably should've been based on the overlap instead of just being 1 but size - 2 * overlap is the source of the problem we're trying to fix here; by doing that, we clear just the portion of the tile that is not overlapped, but not the portion that overlaps. If there's transparency in the overlap, then the overlap section gets darker because of the overlapping.
size - overlap fixes this so we're clearing the inner section and the overlap. In this case we clear just the left side overlap (for instance) and let the next tile clear our right side overlap (which its left side overlap). In this way each overlap is only cleared once.
That said, when I change the code to just size without subtracting anything for the overlap (and am therefore clearing each overlap twice) I can't detect any problem. The comment says we avoid clearing the overlap to avoid edge flickering, but I don't see it. That comment is at least 5 years old, and it's unclear to me exactly what problem it was solving at the time.
Good idea to check with edge smoothing and rotation. Edge smoothing seems fine (I did it with maxZoomPixelRatio: 10). Rotation, on the other hand, presents a challenge. Here I am rotating it 30 degrees with size - 1:

Note the white lines visible from the erasing.
With size - 2 the white lines are gone but the black lines are gone. With size - 1.5 we have flickering black lines but no white lines. It's possible we can't fix that entirely (unless we do all the tiling un-rotated and rotate afterwards). If we go with just size instead of size - 1, the white lines appear to be the same, by the way.
So I'm tempted to say we should just do:
context.clearRect(
   position.x,
   position.y,
   size.x,
   size.y
);

...and see how that goes. What do you think?

Thanks for the explanation and for testing with edge smoothing and rotation.
Your suggestion sounds good to me. We should probably test on all browsers
though.
I am not on a computer, but maybe a git blame on the comment could get us
back to the original issue ?
On Mon, May 21, 2018, 6:58 PM Ian Gilman<EMAIL_ADDRESS>wrote:

@avandecreme https://github.com/avandecreme Yes, it probably should've
been based on the overlap instead of just being 1 but size - 2 * overlap
is the source of the problem we're trying to fix here; by doing that, we
clear just the portion of the tile that is not overlapped, but not the
portion that overlaps. If there's transparency in the overlap, then the
overlap section gets darker because of the overlapping.
size - overlap fixes this so we're clearing the inner section and the
overlap. In this case we clear just the left side overlap (for instance)
and let the next tile clear our right side overlap (which its left side
overlap). In this way each overlap is only cleared once.
That said, when I change the code to just size without subtracting
anything for the overlap (and am therefore clearing each overlap twice) I
can't detect any problem. The comment says we avoid clearing the overlap to
avoid edge flickering, but I don't see it. That comment is at least 5 years
old, and it's unclear to me exactly what problem it was solving at the time.
Good idea to check with edge smoothing and rotation. Edge smoothing seems
fine (I did it with maxZoomPixelRatio: 10). Rotation, on the other hand,
presents a challenge. Here I am rotating it 30 degrees with size - 1:
[image: image]
https://user-images.githubusercontent.com/338989/40319355-be7c4692-5cdc-11e8-8794-e9ae10ff2e2b.png
Note the white lines visible from the erasing.
With size - 2 the white lines are gone but the black lines are gone. With size

1.5 we have flickering black lines but no white lines. It's possible we
can't fix that entirely (unless we do all the tiling un-rotated and rotate
afterwards). If we go with just size instead of size - 1, the white lines
appear to be the same, by the way.

So I'm tempted to say we should just do:
context.clearRect(
position.x,
position.y,
size.x,
size.y
);
...and see how that goes. What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openseadragon/openseadragon/pull/1470#issuecomment-390715849,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcZ7Qt2RQuIlVLo44KrK4Bw3eVUjq7iks5t0vIvgaJpZM4UEKXS
.

@iangilman Looks good :) Want me to update the PR with the changes?
(Sorry for the late replay, somehow the notifications from github didn't show up.)

@Dvidan Yes please; Let's give it a try :)
What browsers have you been able to test on, BTW?

@iangilman Updated.
Tested in:
Chrome: 66.0.3359.139
Firefox: 60.0.1

Great, let's do this! Thank you both for thinking this through with me :-)


chore: export react last hooks

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.706%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
1340

Relevant Lines:
1345

💛  - Coveralls


Doc Feedback: Incorrect statement

Location : https://apim.docs.wso2.com/en/latest/Learn/APISecurity/OAuth2/provisioning-out-of-band-oauth-clients/
When an application access token is generated,  should be When application keys are generated,

Fixed in https://github.com/wso2/docs-apim/pull/728


View Mode: Week

Is it possible that every week
should display like this
Week Upper: Jan 7 - 14, 2019
Week Lower: S M W TH F S

@LhexyRomero did you get the solution? I am also looking for the same

This would require modification to a few function in the code, and localisation. So its a feature request.
Would you always want each week to start on Sunday for each project?
Might be a bigger rewrite if more flexibility in formatting headings is important, or are there a standard set of formats of headings we can define?

@LhexyRomero I don't fully get the feature req here.
As I see it, two separate things:

You want to modify the upper/lower text
You want to start from Sunday?

1 sounds good, but 2: isn't the start date dynamically generated? I don't think it's always Monday.


Add memory and cpu metrics

Add memory and cpu metrics
Refactor calls to the S3 api for DT stats that were failing in our cluster. Node info exposes a data IP and a management IP. Some clusters are configured so these are different IPs. Need to be querying the dataIP for this to successfully return metrics.

Hello,
Thanks for creating this great exporter!
I'm not sure if this project is still active, but I needed to tweak it a bit to run in my cluster and thought others may benefit from having the cpu and memory metrics as well.


Lack of tests for scheduler

Recently, a bug happened in the second/minute/hour scheduling system that could've been caught if we had it under test. This is a reminder to increase test coverage (with cohesive and really effective tests) on this part of the library.

I'll try to take a look into it over the weekend. Any help is welcome!

Branch created for this issue

PR for this issue


Problem Set 1

Dear Friends,
Problem Set 1 has been posted. Enjoy!  If you have questions, please post it here.

Dear Friends,
Problem Set 2 has been posted. Enjoy! If you have questions, please post it here.


(winscp) GH-#777

#777

For some reason the build fail because link is unreachable from AV (in au_BeforeUpdate) although it works locally for me. I logged in on AV and saw that the page returned is different, it might be some regional settings, but didn't have time to investigate fully the solution.
@AdmiringWorm , could you perhaps run the updater at your location to see if the error reaperars ?

@majkinetor I don't have the time right now to check, but I'll do it as soon as possible

@AdmiringWorm , nvm I switched downloads to use sourceforge, didn't notice the links before. Now it works. Just add choco user when you have time. Thx.


Mall fix (why was it like that)

just made the mall look like in vslice

oh? lemme check rq

oh thats true, although lemme just

ty!!


BulkInsert does not populate foreign keys for child entities

I have an set of POCOs that are set up like this:
public class Parent {
        [Key, DatabaseGenerated(DatabaseGeneratedOption.Identity)]
        public long ParentID { get; set; }

        [ForeignKey("ChildAID")]
        public ChildA ChildA { get; set; }

        [ForeignKey("ChildBID")]
        public ChildB ChildB { get; set; }
}

public class ChildA {
        [Key, DatabaseGenerated(DatabaseGeneratedOption.Identity)]
        public long ChildAID { get; set; }

        [ForeignKey("ChildBID")]
        public virtual ChildB ChildB { get; set; }
        public long? ChildBID { get; set; }

        public string SomeProperty { get; set; }
}

public class ChildB {
        [Key, DatabaseGenerated(DatabaseGeneratedOption.Identity)]
        public long ChildBID { get; set; }

        public string SomeProperty { get; set; }
}

My problem is that when using BulkInsert on Parent entities that have existing ChildA and ChildB entities, the keys for ChildA and ChildB are not populated on the Parent's table. My code does something like this:
var children = context.ChildA.Where(c => c.SomeProperty.Equals("somestring"));
var parentsToCreate = new List<Parent>();
foreach(var child in children) {
        parentsToCreate.Add(new Parent {
                ChildA = child,
                ChildB = child.ChildB
        });
}
dataMatchingContext.BulkInsert(parentsToCreate);

This does insert to the Parent table, but both ChildAID and ChildBID is null. Replacing the BulkInsert call with the code below populates both child IDs properly but is obviously slow.
dataMatchingContext.AddRange(parentsToCreate)
dataMatchingContext.SaveChanges();

For FKs in BULK you need FKId Properties in Parent class:
([ForeignKey] Attributes are not required if FKId Properties are named by convention ChildNavProp + 'ID'/'Id')
public class Parent
{
    [Key, DatabaseGenerated(DatabaseGeneratedOption.Identity)]
    public long ParentID { get; set; }

    //[ForeignKey("ChildAID")]
    public ChildA ChildA { get; set; }
    public long ChildAID { get; set; }

    //[ForeignKey("ChildBID")]
    public ChildB ChildB { get; set; }
    public long? ChildBID { get; set; }
}

And you need to set them as well.
new Parent
{
    ChildA = child,
    ChildB = child.ChildB,
    ChildAID = child.ChildAID,
    ChildBID = child.ChildBID
}

Also if you don't need to use Navigation Properties you don't have to set them, you could just have:
new Parent
{
    ChildAID = child.ChildAID,
    ChildBID = child.ChildBID
}

Is there no way to make it work without exposing the IDs? I don't actually need any of the IDs but I do need the navigation properties in my model.

In that case, keep Navigation but add IDs also to Entity.
I find it good practice to always have explicit IDs.
One benefit is you can reference ID directly 'parent.ChildID' instead of parent.Child.ChildID.
Second is you sometimes need them explicit if ColumnName would be different from PropertyName.
And direct ID is more practical for writing Linq Join-s.
Anyway in the library column is mapped with the property and Navigation ones are ignored.
Theoretically FK property could be dynamically created from Nav. property (similar as EF is doing it) but I am not yet sure how that would be implemented.


Fix for incorrect branch being used during manifest generation

What
The first cluster running was assigning its image to the base resource. During merging of resources we were not deep cloning the base resource although this should have not been an issue using lodash's merge. Now treating the cluster resource as immutable.
Note: added a functional test to confirm nothing was leaking from cluster to cluster, but this test would pass locally even before changes. Only when running against production repo in local env was this issue reproducible. Confirmed fix against local env.

LGTM, @c1freitas!
Let me know if you want to do an example deployment after merging this in. We've changed the codeship steps for node-test-rosie a bit, as mentioned the other night, so you'd need to use the xb500 bot. I can help get you set-up with that, just let me know!

Looks Good! 👍


Update testcases due to remove asking consent for null value claims

Purpose
Please Note @subject
Note
PR to remove asking the consent for the null value claims from the users profile - https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1638

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/1066115894

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/1066115894
Status: success


New case failure after pytorch uplist: 5 conv cases

🐛 Describe the bug
test_ops_fwd_gradients_xpu.py::TestFwdGradientsXPU::test_fn_fwgrad_bwgrad_nn_functional_conv3d_xpu_complex128 mFAILED
test_ops_fwd_gradients_xpu.py::TestFwdGradientsXPU::test_fn_fwgrad_bwgrad_nn_functional_conv3d_xpu_float64 mFAILED
test_ops_gradients_xpu.py::TestBwdGradientsXPU::test_fn_gradgrad_nn_functional_conv3d_xpu_complex128
test_ops_gradients_xpu.py::TestBwdGradientsXPU::test_fn_gradgrad_nn_functional_conv3d_xpu_float64 mFAILED
nn/test_convolution_xpu.py::TestConvolutionNN::test_thnn_conv_strided_padded_dilated mFAILED
Versions
latest version

The regression seems to be fixed in onednn 3.7. I have wrote a small case with the same input in pytorch UT, and it passed with onednn3.7. However, pytorch cannot compile with pytorch 3.7.

oneDNN dependence.


[BUG] Authentication edit

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
version 2.5.0

Expected Behavior
No response
Steps To Reproduce
No response
Environment
ShenYu version(s):

Debug logs
No response
Anything else?
No response

Can you please give us more details?


New term request

Definition:Deficiency of Iron (Fe) in the plant measured at flowering stage
Method:Visual estimation of Fe deficiency
Scale:0 to 9 percentage scale

What is the *term *which this is a definition of?
Note that 'measured' cannot be part of the definition
Definition:Deficiency of Iron (Fe) in the plant measured at flowering stage
Method:Visual estimation of Fe deficiency
should be
Definition ... iron deficiency in the plant at the flowering stage
On Fri, Nov 13, 2015 at 2:11 PM, Karthika Rajendran <
<EMAIL_ADDRESS>wrote:

Definition:Deficiency of Iron (Fe) in the plant measured at flowering stage
Method:Visual estimation of Fe deficiency
Scale:0 to 9 percentage scale
—
Reply to this email directly or view it on GitHub
https://github.com/Planteome/plant-trait-ontology/issues/341.

I agree your comment. Thank you.
Modified definition: Iron deficiency in the plant at the flowering stage.


Validate/add support for refreshing cached servers (e.g. server well-knowns)

If a user has a bad well-known (invalid Content-Type, wrong server, etc) and fixed it later, Conduit may or may not have that bad server well-known cached until Conduit is restarted which isn't ideal, especially if compaction takes a long time for some users. This may result in Conduit falsely thinking the server is down as said requests would be failing when Conduit just needs to re-get the server well-known.
Should validate that this is the case, and if it is: add support for automatically clearing cached servers when requests fail. If subsequent requests fail after clearing cache, then exponential backoff should start kicking in.
I suspect this is why I have trouble connecting to mozilla.org sometimes and falls back to sending failing requests to mozilla.org:8448.

This should be enough: https://github.com/girlbossceo/conduwuit/commit/0297cfe30720362a470a5d1a2cf96fae2ee55c1d
I don't think a command to evict all cached destinations is a good idea since that seems to be a ton of servers cached and we should only focus on the ones that we send requests to and fail and need to attempt to retry getting well-known.


Method for writing plugins in editor

Create a way to write new plugins in the editor. The JS code would be saved in the graph.

postponed


Fanart.TV not working for TV Artwork Images?

Version: 3.0-SNAPSHOT
Build: 2018-09-27 00:35
OS: Windows 10 10.0
JDK: 10.0.2 amd64 Oracle Corporation
using latest 3.0 snapshot as of this issue posting date
What is the actual behaviour?
fanart.tv artwork not showing available / scraping to tv shows
What is the expected behaviour?
i entered my personal api key
go to choose a new artwork for tv show (say for example logo)
nothing from fanart.tv shows up as available but if you go to fanart.tv they have logo artwork available
Steps to reproduce:
Additional
Have you attached the logfile from the day it happened?
tmm_logs.zip

Have you tried without API key?
I have none, and it works.
If i enter a wrong one, the error response is silently ignored :(
I've changed that for next build, so we might see, what Fanart.tv is answering :)

we've migrated v3 to GitLab (https://gitlab.com/tinyMediaManager/tinyMediaManager) along with all issues. The issues for v2 at GitHub will be closed - we will respond to the corresponding issue in GitLab in the future
br
Manuel


move integrated tests to inline testing

Rebased. Please have a look

@chrisdennis review items addressed I believe.  Please take a second look.


Atom/Core URL handler support for Markdown inside Datatip

Prerequisites
[ X]   * Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
[ X]   * Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
[ X]    * Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
[ X]    * Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
[ X]    * Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
MD preview and MD datatips (hovers) don't support atom/core URL handlers from #15935. Would be useful if I want to provide source code links inside the datatip (hover)
Steps to Reproduce

Create an MD file with a link similar to [This is a link](atom://core/open/file?filename=<path to file>)
Open MD preview
Click on the link - nothing happens. At the same time if one switches the URL to http://www.bbc.com the link would work

Expected behavior:
The file specified by its path open in Atom text editor
Actual behavior:
Core URLs not supported
Reproduces how often:
100%
Versions
All verions up to 1.25-beta2
Additional Details
Looking for directions... What to look at if I am to provide a patch for this

This is due to dompurify removing unsafe links in this block of code in markdown-preview:
https://github.com/atom/markdown-preview/blob/6a502afe3937d02f9dd4631be43f89c2fbdc54fd/lib/renderer.coffee#L34-L49
If you check "Allow Unsafe Protocols" in the markdown-preview options, atom:// links work correctly, but also allows other protocols you likely don't want enabled. Luckily, dompurify allows passing options to control this, so it shouldn't be too crazy to fix:
// allow external protocol handlers in URL attributes (default is false)
// by default only http, https, ftp, ftps, tel, mailto, callto, cid and xmpp are allowed.
var clean = DOMPurify.sanitize(dirty, {ALLOW_UNKNOWN_PROTOCOLS: true});

// allow specific protocols handlers in URL attributes (default is false)
// by default only http, https, ftp, ftps, tel, mailto, callto, cid and xmpp are allowed.
// Default RegExp: /^(?:(?:(?:f|ht)tps?|mailto|tel|callto|cid|xmpp):|[^a-z]|[a-z+.\-]+(?:[^a-z+.\-:]|$))/i;
var clean = DOMPurify.sanitize(dirty, {ALLOWED_URI_REGEXP: /^(?:(?:(?:f|ht)tps?|mailto|tel|callto|cid|xmpp|xxx):|[^a-z]|[a-z+.\-]+(?:[^a-z+.\-:]|$))/i;});

@BinaryMuse i think the setting ALLOW_UNKNOWN_PROTOCOLS and ALLOWED_URI_REGEXP  only helps to properly set href attribute to the atom://... URL value. Is that correct?
I've tried modifying the DOM directly via dev tools and set the href attribute to: atom://atom://core/open/file?filename=<path to file>. I think the result of this is the same as passing those 2 settings mentioned above. However, clicking on the link does nothing still.
Anything i need to set in Atom config for the atom core URLs to work within Atom? These URLs work when i try open atom:// URL in my OS, but not in Atom...

@BinaryMuse hmm... maybe my atom core URL is in incorrect format. The URL I'm trying is: atom://core/open/file?filename=/Users/aboyko/Documents/Language-Server/demo/src/main/java/com/example/DemoApplication.java
The file name attribute being the absolute path to a file.
Does that look ok?

I still can't get Atom core URLs to work from MD preview even after setting the prefernce Allow Unsafe Protocols. I see with the DOM inspector (DevTools) that href attribute has the right Atom coe URL value, but clicking on the link doesn't nothing...
Can you provide me a Atom Core URL that worked for you? Or an MD content that worked from the MD preview? (just need it as an example, I understand that file name/path would be different)

I was looking for the exact format too according to #15935 it's:
atom://core/open/file?filename=urlEncodedFileName&line=n&column=n

@UziTech I have tried encoding the file path and it again only works from the OS, i.e. Mac OSX URL in the Text Editor, right-click Open URL - works.
However, if I'm to put this URL in an MD file in a link format it doesn't work from MarkDown preview in Atom UI (same goes for hovers/datatips). Does this work for you?

You are correct. It does seem to work with hyperlink-hyperclick.
After a bit of research it looks like the "Open link" explicitly only works with http/https links https://github.com/atom/link/blob/add8170e69c84e1ea438e22b6a023a32f6582eaf/lib/link.js#L28
And markdown-preview doesn't seem to work with anything other than http or https (I tried mailto://) It seems atom would have to register the other protocols with electron.protocol.registerHttpProtocol to allow links to open with those protocols.

@UziTech Thanks very much for the info! I think there is enough info for me to attempt a patch :-)

I added a PR for language-hyperlink to include atom:// URIs
https://github.com/atom/language-hyperlink/pull/21

Looks like I found the right solution for the problem. Wonder if anyone can merge this PR #16940 ?

@daviwil Would you mind checking this out?


RN 0.71.0 - installDebug error - build.gradle line:88 - implementation project(":ReactAndroid")

I try to run it on the most current version of everything.
After installing the react-native-svg library, I say npx react-native-run-android but it throws an error in the build.gradle (88) file.

The relevant line contains the following code:
implementation project(":ReactAndroid")
A problem occurred evaluating project ':react-native-svg'.
> Project with path ':ReactAndroid' could not be found in project ':react-native-svg'.

How can I solve this problem?

Could you try using the version of library from the newest main? Also, do you use new architecture in your app?

Can you make a repo with a simple reproduction of the issue?

Could the automatic linking process not be working properly?
dependencies {
    if (isNewArchitectureEnabled()) {
        implementation project(":ReactAndroid")
    } else {
        implementation 'com.facebook.react:react-native:+'
    }
}

I changed this code area like this and was able to move forward. ✔
dependencies {
    implementation 'com.facebook.react:react-native:+'
}

But this time, the problem appears on this page.
https://github.com/mrousavy/react-native-mmkv/issues/497#issuecomment-1384142784

So the newest main of react-native-svg contains the correct code? If so, can I close the issue?

I don't know if what I'm doing is right. Maybe that's causing the issue on the other page I linked to. :/

@ugurdalkiran  is it the right solution, as I am also facing the same?

@sudhanshusirohia Yes I think it is correct.

Hi @WoLewicki @ugurdalkiran which version to use to fix this issue.
After changing library as specified above its working , but i need to do it everytime.
In production side , how to change this file ?

In production side , how to change this file ?

You can use patch-package. You may also find a patch file here: https://github.com/software-mansion/react-native-svg/issues/1970
BTW, I think this issue is solved in the latest commit on main. Hope that the author of this package can release a new version.


Migrating scope stages into handlers

Fixes #1054
Checklist

[ ] I have added tests
[ ] I have updated the docs and cheatsheet

Folded into #1075


postgresql.pkgs.citus: init at 11.0.6

Description of changes

From the home page, citusdata.com

Citus gives you all the greatness of Postgres, plus the superpower of distributed tables. 100% open source. And with Citus 11, you can now query from any node.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This will probably supersede #129284.

Result of nixpkgs-review pr 191204 run on x86_64-linux 1

2 packages failed to build:

postgresql11Packages.citus
postgresql12Packages.citus

2 packages built:

postgresql13Packages.citus
postgresqlPackages.citus (postgresql14Packages.citus)


Gradle plugin sources are not published to Plugin Portal when maven-publish plugin is applied

I'm writing a Gradle plugin, using java-gradle-plugin and com.gradle.plugin-publish plugins as described in the instruction. When I trigger publishPlugins task, everything works fine, and it publishes javadoc and sources jars, i.e.:
Publishing plugin ru.ileasile.kotlin.doc version 0.0.34-dev
Publishing plugin ru.ileasile.kotlin.publisher version 0.0.34-dev
Publishing artifact build/libs/kotlin-libs-publisher-0.0.34-dev.jar
Publishing artifact build/libs/kotlin-libs-publisher-0.0.34-dev-sources.jar
Publishing artifact build/libs/kotlin-libs-publisher-0.0.34-dev-javadoc.jar
Publishing artifact build/publish-generated-resources/pom.xml
Activating plugin ru.ileasile.kotlin.doc version 0.0.34-dev
Activating plugin ru.ileasile.kotlin.publisher version 0.0.34-dev

But when I apply maven-publish plugin in order to setup a local repository for the publication, publishPlugins task starts to work differently and doesn't publish the sources and javadoc jars, i.e.:
Publishing plugin ru.ileasile.kotlin.doc version 0.0.33-dev
Publishing plugin ru.ileasile.kotlin.publisher version 0.0.33-dev
Publishing artifact build/libs/kotlin-libs-publisher-0.0.33-dev.jar
Publishing artifact build/publications/pluginMaven/pom-default.xml
Publishing artifact build/publications/pluginMaven/module.json
Activating plugin ru.ileasile.kotlin.doc version 0.0.33-dev
Activating plugin ru.ileasile.kotlin.publisher version 0.0.33-dev

Expected Behavior
I expect that publishPlugin task should continue publishing source and javadoc jars
Current Behavior
Sources and javadoc jars are published only if maven-publish plugin is not applied, so you have to choose between the ability to publish source jars and publish plugin locally. Moreover, I don't know a correct workaround for it, because adding a sources artifact manually to all maven publications doesn't fix the problem for publishing to portal.
Context

I want to have an ability to publish my plugin locally and to portal, and with sources and javadoc jars.
Steps to Reproduce

Here is the example project: https://github.com/ileasile/kotlin-libs-publisher/blob/master/build.gradle.kts
You may uncomment corresponding lines to reproduce the incorrect behavior.
Your Environment

Build scan URL:
https://scans.gradle.com/s/eaz765kb5j2s2
There is also a part of a build log with --info:
> Task :publishPluginJar
Caching disabled for task ':publishPluginJar' because:
  Build cache is disabled
  Caching has not been enabled for the task
Task ':publishPluginJar' is not up-to-date because:
  Output property 'archiveFile' file C:\Projects\kotlin-libs-publisher\build\libs\kotlin-libs-publisher-0.0.34-dev-sources.jar has been removed.
:publishPluginJar (Thread[Execution worker for ':',5,main]) completed. Took 0.059 secs.
:javadoc (Thread[Execution worker for ':',5,main]) started.

> Task :javadoc NO-SOURCE
Skipping task ':javadoc' as it has no source files and no previous output files.
:javadoc (Thread[Execution worker for ':',5,main]) completed. Took 0.001 secs.
:publishPluginJavaDocsJar (Thread[Execution worker for ':',5,main]) started.

> Task :publishPluginJavaDocsJar
file or directory 'C:\Projects\kotlin-libs-publisher\build\docs\javadoc', not found
Caching disabled for task ':publishPluginJavaDocsJar' because:
  Build cache is disabled
  Caching has not been enabled for the task
Task ':publishPluginJavaDocsJar' is not up-to-date because:
  Output property 'archiveFile' file C:\Projects\kotlin-libs-publisher\build\libs\kotlin-libs-publisher-0.0.34-dev-javadoc.jar has been removed.
file or directory 'C:\Projects\kotlin-libs-publisher\build\docs\javadoc', not found
:publishPluginJavaDocsJar (Thread[Execution worker for ':',5,main]) completed. Took 0.014 secs.
:publishPlugins (Thread[Execution worker for ':',5,main]) started.

> Task :publishPlugins
Caching disabled for task ':publishPlugins' because:
  Build cache is disabled
Task ':publishPlugins' is not up-to-date because:
  Task has not declared any outputs despite executing actions.
Publishing plugin ru.ileasile.kotlin.doc version 0.0.35-dev
Publishing plugin ru.ileasile.kotlin.publisher version 0.0.35-dev
Publishing artifact build/libs/kotlin-libs-publisher-0.0.35-dev.jar
Publishing artifact build/publications/pluginMaven/pom-default.xml
Publishing artifact build/publications/pluginMaven/module.json
Activating plugin ru.ileasile.kotlin.doc version 0.0.35-dev
Activating plugin ru.ileasile.kotlin.publisher version 0.0.35-dev
:publishPlugins (Thread[Execution worker for ':',5,main]) completed. Took 3.979 secs.

Here we can see that sources and javadoc jars were actually created by publishPluginJar and publishPluginJavaDocsJar, but were not loaded to plugin portal actually - rather strange thing, to be honest.

Even adding this to the publishing extension configuration doesn't fix the issue
    afterEvaluate {
        publications {
            withType<MavenPublication> {
                artifact(tasks["sourceJar"])
            }
        }
    }

Though, it has been possibly working, judging by this 2-year old example: https://github.com/marcphilipp/gradle-sandbox/blob/85e934d13b413df2fccd752591f631128e7e7734/plugin-maven-publish/build.gradle#L23-L44

By the way, it is very likely that the problem in com.gradle.plugin-publish, but I was unable to find its sources on the internet. Are they closed?
The last available sources are here: https://plugins.gradle.org/m2/com/gradle/publish/plugin-publish-plugin/0.9.1/
Sources of this plugin are not published since v. 0.9.2 - and I'm not sure it was done by intention

@ileasile The plugin-publish plugin is closed source, more for historical reasons than anything.
Can you try using the following in your project and let us know if it works then?
java {
    withSourcesJar()
    withJavadocJar()
}

Whoa, it worked! Thanks, @ljacomet.
But it was somewhat misleading, maybe behavior should be unified here.

Closing as this is resolved by using core constructs