Feedback for v0.1.3

Chapter 1. Introduction

"in-target use": Can we clarify what this means? My understanding is that it tries to distinguish from trace where the consumers are "external"?
"internal chip storage": Since we debated the options and decided on CSRs should we update this text too? We do mention CSRs when describing the CTR array.

Chapter 2. CSRs

"when V=0, ..": I believe this refers to virtualization? Can we clarify this since later on in 3.1 we also introduce a valid bit V with the same notation. Though I do see most of the uses of the latter also include the source register , eg. ctrsource.V
"the CSR number is 0x381": What is the implication of this? I think this means that software such as perf will expect all implementations to use CSR 0x381 to refer to e.g. mctrcontrol. Can we call this out explicitly? Also a table which holds all the relevant CSRs in one place might be a good reference.
Can we add a footnote which links to the definitions of WARL (Write Any, Read Legal), WLRL (Write Legal, Read Legal). Searching online brings up discussions and requests for clarification.
[nitpick] Can we keep the EN bits together and the INH bits grouped together? Is there a rationale for the ordering of bits for transfer type filtering today? I wonder if it makes software easier to interpret.
typo missing word in 2.4 "but must sufficient to ..."

Chapter 3. Entry Registers

Transfer type field - What is the intention for reserving 0110 and 0111?
Transfer type field - Can we clarify "other indirect jump" and "other direct jump". How do these differ from indirect jump and direct jump? (I see that these line up with the E-Trace itype encodings, it would be good to add more details here so this is somewhat self-contained).
Should we add separate filtering for jumps that modify the RAS? Chapter 2.5 in the unprivileged RISC-V spec states "A JAL instruction should push the return address onto a return-address stack (RAS) only when rd=x1/x5. JALR instructions should push/pop a RAS as shown in the Table 2.1". In particular I'm interested in understanding whether we can filter tail calls (tail offset pseudo instruction Table 25.3 in the unprivileged RISC-V spec).

Chapter 4. State enable access control
Can we merge this with Chapter 6 Discovery? They seem related to me.
Chapter 5. Behaviour

Cycle Counting: Instead of highlighting just (2^12 + CCM) << CCE-1 can we put the entire heuristic including the direct interpretation when CC count < 64K. I like how ARM specifies it in their documentation here. It's easy to miss the latter case spelled out in the text.
RAS Emulation Mode: As mentioned previously, can we support pseudo-instructions such as tail calls to subroutines? From a profiling tools perspective this would be a major improvement compared to existing transfer recording mechanisms.

Chapter 1. Introduction
"in-target use": Can we clarify what this means? My understanding is that it tries to distinguish from trace where the consumers are "external"?

I just deleted the reference to "in-target use".  It was meant to distinguish between self-hosted use vs probe debugger use, but I think it's unnecessary.

"internal chip storage": Since we debated the options and decided on CSRs should we update this text too? We do mention CSRs when describing the CTR array.

I changed it to say "register-accessible internal chip storage".  We use S*csrind to access the state, but the storage could be an array, SRAM, whatever.

Chapter 2. CSRs
"when V=0, ..": I believe this refers to virtualization? Can we clarify this since later on in 3.1 we also introduce a valid bit V with the same notation. Though I do see most of the uses of the latter also include the source register , eg. ctrsource.V

I added clarification with the first reference to V=0 and V=1.  For background, this terminology comes from the priv spec, in the definition of the Hypervisor (H) extension:
When V=1, the hart is either in virtual S-mode (VS-mode), or in virtual U-mode (VU-mode)
atop a guest OS running in VS-mode. When V=0, the hart is either in M-mode, in HS-mode, or in
U-mode atop an OS running in HS-mode.

"the CSR number is 0x381": What is the implication of this? I think this means that software such as perf will expect all implementations to use CSR 0x381 to refer to e.g. mctrcontrol. Can we call this out explicitly? Also a table which holds all the relevant CSRs in one place might be a good reference.

The table I can add, but I'm not sure what could be more explicit than what is stated there.

Can we add a footnote which links to the definitions of WARL (Write Any, Read Legal), WLRL (Write Legal, Read Legal). Searching online brings up discussions and requests for clarification.

Added a non-normative statement atop the CSR chapter.

[nitpick] Can we keep the EN bits together and the INH bits grouped together? Is there a rationale for the ordering of bits for transfer type filtering today? I wonder if it makes software easier to interpret.

All the *INH bit offsets (from bit 32) are based on the E-trace itype encoding.  Not-taken branches are encoding 4, hence NTBREN is bit 36.  The adjacent encodings are defined as other things.  For ETEN, which has no equivalent in the E-trace encodings, I picked an offset that is reserved.  So I don't see a good way to put them together.

typo missing word in 2.4 "but must sufficient to ..."

Fixed.

Chapter 3. Entry Registers
Transfer type field - What is the intention for reserving 0110 and 0111?

Those are unused by E-trace (at least, when using a 4-bit itype encoding)

Transfer type field - Can we clarify "other indirect jump" and "other direct jump". How do these differ from indirect jump and direct jump? (I see that these line up with the E-Trace itype encodings, it would be good to add more details here so this is somewhat self-contained).

I toyed with this, but can't come up with a way to summarize without essentially duplicating what's in the E-trace spec.  I would be nice if we had html specs, and I could more easily reference the same source info.  It is weird that, once this is integrated into the priv spec, it will have a dependency on a non-ISA spec.  I'll ask ARC how to deal with this.

Should we add separate filtering for jumps that modify the RAS? Chapter 2.5 in the unprivileged RISC-V spec states "A JAL instruction should push the return address onto a return-address stack (RAS) only when rd=x1/x5. JALR instructions should push/pop a RAS as shown in the Table 2.1". In particular I'm interested in understanding whether we can filter tail calls (tail offset pseudo instruction Table 25.3 in the unprivileged RISC-V spec).

We already can filter on instructions that modify the RAS.  A user can inhibit all types other than calls, returns, and co-routine swaps to get that behavior.
Unfortunately, I don't know of any calling convention for tail-calls.  That table has been removed from more recent revisions of the unpriv spec.

Chapter 4. State enable access control
Can we merge this with Chapter 6 Discovery? They seem related to me.

State enable is certainly relevant to discovery, but the Smstateen extension was actually intended more as a way for privileged SW to hide capabilities of which it is unaware, and thus won't know to context switch.  Imagine a CTR-unaware OS running on newer HW that supports CTR.

Chapter 5. Behaviour
Cycle Counting: Instead of highlighting just (2^12 + CCM) << CCE-1 can we put the entire heuristic including the direct interpretation when CC count < 64K. I like how ARM specifies it in their documentation here. It's easy to miss the latter case spelled out in the text.

Switched to: CCE==0? CCM : ((2^12^ + CCM) << CCE-1)

RAS Emulation Mode: As mentioned previously, can we support pseudo-instructions such as tail calls to subroutines? From a profiling tools perspective this would be a major improvement compared to existing transfer recording mechanisms.

As mentioned above, there doesn't seem to be a convention that would allow us to uniquely identify tail-calls.  But how are you thinking we would use them?  Treat them like a call and record them, but track the WRPTR at the time of the last true call so that the subsequent RET pops the original callee plus all the tail-call entries?

I don't seem to be able to add you as a reviewer for the PR, but please have a look

Added another commit to the PR

there doesn't seem to be a convention that would allow us to uniquely identify tail-calls
I see the text and the table on page 27 of the latest draft. Can we leverage the implicit hinting to update the CTR just like a RAS implementation?

But how are you thinking we would use them? Treat them like a call and record them, but track the WRPTR at the time of the last true call so that the subsequent RET pops the original callee plus all the tail-call entries?
Yes and handle overflow where we need to invalidate all CTR records.

I see the text and the table on page 27 of the latest draft. Can we leverage the implicit hinting to update the CTR just like a RAS implementation?

Yes, that calling convention is how we bucket JAL/JALR instructions into the transfer types.  Pop=Return, Push=Call, and "Pop, then Push"=Co-routine Swap.  And the actions taken on the CTR stack when RASEMU=1 match the RAS actions listed in that table.

Yes and handle overflow where we need to invalidate all CTR records.

Unfortunately it doesn't seem that RISC-V adopted a convention to identify tail-calls the way they did for calls and returns.  But even if they did, there would be implementation complexity in making the return pop all the tail-call entries.  Today each update touches only one entry.
I think tail calls are usually direct and unconditional, so could the tools not follow them even without help from CTR?  For instance, if the last call in CTR is to function foo(), but we get a sample in function bar(), could the tools not follow foo's tail-call (and any nested tail calls) until it reaches bar()?

Ah, I get it now. I missed that you were referring to the table which contained the tail offset pseudo-instruction.

Unfortunately it doesn't seem that RISC-V adopted a convention to identify tail-calls the way they did

Do you think this is feasible in the future? Any idea why the recommended lower for the pseudo-instruction was omitted in the recent update to the unprivileged spec?

I think tail calls are usually direct and unconditional,

Yes

so could the tools not follow them even without help from CTR? For instance, if the last call in CTR is to function foo(), but we get a sample in function bar(), could the tools not follow foo's tail-call (and any nested tail calls) until it reaches bar()?

There may be intermediate tail jumps from the parent function foo() to other functions before it reaches bar(). Exploring the nested tail calls may lead to multiple potential paths to bar(). Consider this example from a protobuf parser. A sample in _upb_FastDecoder_TagDispatch could have come directly via the tail call (enforced by the UPB_MUSTTAIL attribute) at L100 or indirectly via another tail call at L95.
On a separate note: In the current version of the spec for cycle counting we note that the CCV may be invalid on power state transitions. I'm wondering if we want to make a broader statement about the CTR itself. Clarifying that we leave it to implementations could be an option too. As far as I know Intel does not preserve LBRs C-state transitions.

Do you think this is feasible in the future? Any idea why the recommended lower for the pseudo-instruction was omitted in the recent update to the unprivileged spec?

This is probably a better question for a software person, but we'd have to get a new convention defined, get compilers to use it, then recompile all the existing code.  I don't know if it's "too late", but sure seems like it would have been easier to do earlier.  Andrew Waterman would probably be a good person to ask about why it was removed.
Thanks for the example, with 2 separate tail-calls in a function then I agree, we'd need CTR (or something) to resolve it.

On a separate note: In the current version of the spec for cycle counting we note that the CCV may be invalid on power state transitions. I'm wondering if we want to make a broader statement about the CTR itself. Clarifying that we leave it to implementations could be an option too. As far as I know Intel does not preserve LBRs C-state transitions.

I agree.  LBRs are preserved in C1, but not the deeper C6.  I'll add something about this.


Added Check-Even-Odd Algo

PR Checklist:

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is on refer on the language README.md file
[x] My addition does not have a spelling problem
[x] My submission has a proper and user-friendly description of the algorithm
[x] My submission has the time complexity of the algorithm
[x] My submission has sample input-output of the program (NOT FOR PYTHON)

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR
I have added the Algorithm to check for Even and Odd numbers in CplusPlus. I've added two methods for checking Even-Odd, one through Logical And operator (&) and other through Mod operator(%).
This issue (#501) has been open for a long time and I have decided to close it by making this PR.

Spell corrected (sting->string) in algorithms/Java/Maths/roman-numerals.java which leads to failing of codepsell workflow.

@ming-tsai please review the PR

@mohitchakraverty @ming-tsai please review the PR.

Great work !


Open Action not working on Android  11

When calling LeanplumInbox.read(messageId), it should to trigger open action to open an external url. It works on Android 10 or below but not Android 11. I was using version 1.0.13 and I tried upgrading to the latest version 1.1.1 and it's still the same. Thanks!

I've tested this on Android 11 and cannot get it to reproduce. The open action is always executed when i read the inbox message. Can you provide more information on how to reproduce this ?

Thanks for the response @milos1290, I am still seeing this on Android 11 but works fine on everything else. The way I configured this on leanplum is open action and open URL then I set an URL. Please note that if the url is a deeplink then it works by taking me to somewhere else in the app. If the URL is a link outside of the app, then nothing happens and no error messages either. I am using "@leanplum/react-native-sdk": "^1.1.1" and "react-native": "0.63.4".  Let me know if there's more information you might need, thanks again!


Filter test suite warnings output by wsgiref to non-standard HTTP methods.

Resolved fixed in https://github.com/falconry/falcon/pull/1618


Bump uglify version to fix vulnerability

For more information see: https://nodesecurity.io/advisories/uglifyjs_incorrectly_handles_non-boolean_comparisons

Ugh... So you know if any of Handlebar's code is impacted by this? Will certainly merge this but leaving open for right now while we assess the impact that this might have. My hope is that it's minor as there aren't a whole lot of combined flags like the exploit mentions but I don't fully understand the exploit yet.

A better source if you're having trouble understanding the vulnerability is here: https://zyan.scripts.mit.edu/blog/backdooring-js/
I looked into it, uglify is used in lib/precompiler.js. It seems to me that any code that passed to the precompiler with the -m or --min flags set is run through the vulnerable version of uglify and is therefore vulnerable. So, it's not a matter of the handlebars code itself being vulnerable, rather any client code that's using those options.

+1

Even though Handlebars is not effected by the vulnerability. Tools like grunt-nsp-shrinkwrap will give warnings until Uglify-JS is updated. And in my case it breaks our Jenkins build process (which it should since there might be a dangerous vulnerability, that should be fixed).

@hacker112, Handlebars may not itself be vulnerable to backdooring, but it is affected by the vulnerability because any code that uses handlebars is now potentially a target.

My read on this is that the code that is vulnerable is not written anywhere in handlebars nor is it generated by our code generation logic.
Merging this but since we have a number of breaking changes on the tree and the current release has some additional breaking changes that are still under review we can't cleanly roll a release right now. This is close but I can't estimate when I'll get community feedback on the open pull requests to provide a better estimate on when this release might go out.
Those who are cautious can minimize their own copy of Handlebars and perform their own minimization of the templates. Since the uglify code is not shipped to the client in any way and not utilized within node land unless you are using the precompiler, any perceived risk can easily be mitigated. Generally we recommend running your own compilation and minification regardless as the Handlebars CLI is provided as a connivence but is not intended for a production caliber release process.
If someone is aware of a specific bit of our code, generated or written, that is vulnerable in our code please email me directly and I'll be glad to see what we we can do to fix it discretely and out of band if need be.

Thank you.

@kpdecker what are the chances of getting this into a 3.0.4 release? I'd love to not have false positives in my NSP alerts.

Pretty much nill for the reasons outlined above. The tree is not in a releasable state and since this isn't an actual explain it doesn't warrant an out of band release, particularly when other changes have been promised and we cherry-picking those changes would be a nightmare.

You don't think an issue that breaks a lot of dependent builds warrants a patch release? I'm with @RCanine here.
I completely understand it's a distraction and a pain (sincerely), but a lot of companies have a policy of no broken builds, which means this will force a drastic short-term action, like abandoning handlebars in favor of an alternative that doesn't leave builds broken.

At a risk of sounding naive, it should be trivial to create a new branch from 3.0.3 tag and apply this change there. What am I missing? Why is it hard to make <IP_ADDRESS> release?

I am thinking the same thing as @agladysh. Its one of the benefits with good versioning system that handles branches well like Git and Mercurial.

If problem is really with Git (I suspect that it is not), I can help with creating a branch for the patch release.

Released in 4.0.0


Added Magic Button

Description
With this PR merged, the magic button, i.e. a button which changes position on Hover.
Checklist

[x] I am making a proper pull request, not spam.
[x] I've checked the issue list before deciding what to submit.
[x] I've made the enhancement both for light as well as dark modes
[x] I ensured that the page remains responsive after the addition of the changes

Related Issues or Pull Requests
This PR closes #530
Add relevant screenshot or video (if any)
screen-capture (1).webm
Would be glad if you'd merge this PR.

Hi, there seems to be a merge conflict, please resolve it.


Ingawei/man 1945 fix layout shift on broswe

Making updates to users, topics and contracts simultaneous for better CLS score.
I think what might be causing the bad CLS is that the users/topics come in after contracts are loaded in searching and so the contracts jump

There appears to be an improvement when testing with 'lum' as a query:
http://localhost:3000/home?s=score&f=open&ct=ALL&p=0&fy=1&mt=00000&sw=0
current site gets a CLS score of 0.123, simultaneous updating gets a CLS score of 0.077
I usually would just push this but I don't want to break the site and I'm OOO starting tomorrow till Tuesday. If it looks ok please feel free to merge, and if it doesn't, feel free to make changes.

lgtm!


integrate with Apple CoreML

Amazing work!
I read about the CoreML implementation by Apple, is it possible to integrate that into ImaginAIry?
https://github.com/apple/ml-stable-diffusion

That would be nice. Seems like it's based on diffusers though. Not sure how plausible integration is.

See https://github.com/AUTOMATIC1111/stable-diffusion-webui/issues/5309

good idea

Some issues for context from another python SD tool: https://github.com/invoke-ai/InvokeAI/issues/2167 and https://github.com/invoke-ai/InvokeAI/issues/1676 and https://huggingface.co/TheMurusTeam/coreml-upscaler-realesrgan512

Thanks @iandol

https://twitter.com/pcuenq/status/1620080393226706945

I don't see a path for this to happen unless someone makes a python api to the swift versions. Will re-open if something changes in this space.

please.


Unable to expand/collapse all nodes after initial render

I want to use local state to control whether the all the nodes are expanded or collapsed. If I set a local state variable to true and then return that in an an anonymous function assigned to shouldExpandNode() then everything works as expected. If I change this local state variable to false however though the render() lifecycle method is triggered but all the nodes remain expanded.
I'm possibly missing something obvious.

The issue seems to be in src/JSONNestedNode.js:
  componentWillReceiveProps(nextProps) {
    const nextState = getStateFromProps(nextProps);
    if (getStateFromProps(this.props).expanded !== nextState.expanded) {
      this.setState(nextState);
    }
  }

If the conditional is removed, everything works as expected.

hi,
<JSONTree
hideRoot={true}
// shouldExpandNode={() => }
getItemString={() => ()}
data={record.description}
/>
About this function shouldExpandNode, how can I use it?
I want JSONTree render the object in expanding.

<CompareJSONTree
   shouldExpandNode={() => true}
   data={item}
/>

Can only be used in this way


web chat

enter image description hereI have used C # code to create an intelligent robot that contains the Luis function, but now I am faced with how to add speech recognition to the web chat, the online help documents are created locally, my robot has been released, I have now implemented to add a button on the site, by clicking the button to jump to the Web Chat Chat interface, please help me solve this problem! Whether through the background C # implementation or anything, by the way, websocket incompatible, thank you

This repo is related to the documentation and documentation-related issues. You should ask your question on Stack Overflow per the instructions at https://docs.microsoft.com/en-us/bot-framework/resources-links-help.


Audio out of sync with video

19:50:33.199 INFO : Vid *CENC 1024x576 | 1499 Kbps | video=1499968 | avc1.4D401F | 3600 Segments | ~02h00m00s 19:50:33.200 INFO : Aud *CENC audio_eng=128000 | 128 Kbps | mp4a.40.2 | en | 2CH | 3591 Segments | ~02h00m01s
I found the audio to come slower than the video. Is there any way to fix it? I streamed to the rtmp server.

maybe add the option for
-itsoffset xx
so we can update the audio timming and sync correctly, i know we cna do it in ffmpeg but for live pip i dont know how to

maybe add the option for
-itsoffset xx
so we can update the audio timming and sync correctly, i know we cna do it in ffmpeg but for live pip i dont know how to

I'll try adding this command to pipe but sometimes I find that the image comes before the sound. Sometimes the sound comes before the picture.

hmm
you can check the output of the file like here
19:50:33.199 INFO : Vid *CENC 1024x576 | 1499 Kbps | video=1499968 | avc1.4D401F | 3600 Segments | ~02h00m00s 19:50:33.200 INFO : Aud *CENC audio_eng=128000 | 128 Kbps | mp4a.40.2 | en | 2CH | 3591 Segments | ~02h00m01s
you can see the diference in time, so you can make somthing like scrap the output from the ssh command, and make a new command via php to auto update the sync audio
maybe if you can provide the code for sending to pipe via n_m3u8 i can try when i get out of the work!

@nilaoda Please add options for ffmpeg command before input like -itsoffset in next version. Thank

@nilaoda Please add options for ffmpeg command before input like -itsoffset in next version. Thank

Better make a new issue for this feature request.

I am still having the audio-video out-of-sync issue too.


Publish the web application

Publish the web application with the sample data in the dev database and add it under deployments

Published on Vercel - https://ceylon-public-transit.vercel.app/


JointQ not work in custom env

i build a new env on marllib, and i test it by MAPPO, it worked. but when I try to switch algo to qmix,  it met a problem in preprocessors.py.
it occurs in "check_shape",  self._obs_space is a tuple of GymDict when I use JointQ algos, which should be a GymDict I guess. ,it makes " if not self._obs_space.contains(observation):"(ray/rllib/models/preprocessors.py", line 93)"return false and raise ValueError. I don't know why smac doesn't meet this problem, I believe I used the right form to build my env. This is my obs_space,and I ensure "step" and "reset" will return right data.
self.observation_space = GymDict({
            "obs": Box(
                low=0,
                high=10,
                shape=(self.obs_size,),
                dtype=np.dtype("int64")),
            "state": Box(
                low=-1,
                high=self.n_agents+self.n_preys*10,
                shape=((self.map_size + 2 * self.sight_range)**2,),
                dtype=np.dtype("int64")),
            "action_mask": Box(
                low=0,
                high=1,
                shape=(self.n_actions,),
                dtype=np.dtype("int64"))

        })

I get it.
when you build your obs dict in step or reset, you should ensure the key of obs dict is a member of self.agents. If not, it will happen a problem in GroupWrapper, which doesn't affect some algorithms, but algorithms like QMIX can be problematic.


Examples for paper's toy problems

Hey,
Could you guys share the example code for the toy problems presented in the paper? Especially the one for Stochastic Lorenz Attractor?
I was looking at how to solve a system of stochastic differential equations using torchsde where there is inter-dependecy between some of the functions. Can you help me out?
Cheers,
Miguel

Hello,
First of all, thank you for the code.
Could you please share the script/notebook for the Stochastic Lorenz system?
Thank you in advance!
Duong

It's here

Thank you! Cheers!


Add support for Umbraco Deploy

To be truly useful on an Umbraco Cloud instance, we need an Umbraco Deploy plugin to be able to transfer both the SEO Node data and the configuration across from one instance to another.
To support this, we will need to modify the database tables and any reference to the integer-based NodeId to use the Guid-based Key instead, as there will be conflicts/inconsistencies in the integer-based NodeIds from one instance to another.
Currently, if we implement SEO Toolkit on an Umbraco Cloud project, we need to copy over any configuration as well as any metadata if we restore or push nodes between instances.

Good point. I really need to get back to https://github.com/patrickdemooij9/SeoToolkit.Umbraco/pull/175. That also probably needs to have the same changes done as you suggest here.

Possibly one of the biggest hurdles is the fact that content is stored in the database - Matt Brailesford may have an approach to this that could work - see https://github.com/vendrhub/vendr-deploy - there's an issue (https://github.com/vendrhub/vendr-deploy/issues/1 - Deploy Stock Values) that talks about data in databases but is unresolved, so not sure if he got it working.
How hard would it be to reconfigure SEO Toolkit to store data in a property on the document itself instead?  Even if we somehow "hid" that property from the standard editor and placed it in the Content App where it currently is...  Of course, the configuration will still need to be deployed (which still exists in database)

To us, this is pretty much a must have feature. So +1 on this.


Incorrect treatment of temperature Dimensions objects.

We explicitly define temperature and temperature difference as separate fundamental dimensions:

but we say they are the same in comparisons (see this unit test):
    d1 = ansunits.Dimensions(dimensions_container={dims.LENGTH: 1, dims.TEMPERATURE: 1})
    d2 = ansunits.Dimensions(
        dimensions_container={dims.LENGTH: 1, dims.TEMPERATURE_DIFFERENCE: 1}
    )

    assert d1 == d2

This is the wrong approach and is confusing. We should assert that:
    assert d1 != d2

That means that we just have to have some special logic in the +/- operations. It must all be encapsulated inside Dimensions.
Likewise, I am finding the following, which is also wrong, but can be discussed. We should have to do an explicit quantity type conversion before this is an allowed comparison:
ansunits.Quantity(0.0, "delta_K") == ansunits.Quantity(0.0, "K")

At the lowest level we have:
>>> dims.TEMPERATURE == dims.TEMPERATURE_DIFFERENCE
False

See #23

@ansaboutin this is the most important issue atm


Two version changes

API change, so did a major version.

This change is

:pushpin: Commit 63d3cde has been approved by jdm

@bors-servo: r+

:hourglass: Testing commit 63d3cde7edc66aff1adcc6fd6de949db330c1ffb with merge c04961f8fa53060bb5ab831059a07bb85b11fc29...

:sunny: Test successful - status-travis
Approved by: jdm
Pushing c04961f8fa53060bb5ab831059a07bb85b11fc29 to master...


Different results for different runs?

I was wondering whether the merlin scripts have some element of randomness to them? I just successfully used the new commits (new scripts in build_your_own_voice) and have drastically different resulting speech (worse) than the previous version even with the same data and config.

As far as training is considered, there is no randomness. The results generated with a particular dataset and config file are always replicable, as long as the label files and acoustic features remain same.

Odd, did anything change in the defaults from the past few commits then? I used the same vocoders + state aligners + data.

Here is the output of diffing my configuration files
Acoustic:
3c3
< Merlin: /home/ubuntu/pynb/TFplay/merlin
---
> Merlin: /home/ubuntu/pynb/TFplay/merlin2
5c5
< TOPLEVEL: /home/ubuntu/pynb/TFplay/merlin/egs/build_your_own_voice/s1
---
> TOPLEVEL: /home/ubuntu/pynb/TFplay/merlin2/egs/build_your_own_voice/s1
10c10
< work: %(TOPLEVEL)s/experiments/my_voice/acoustic_model
---
> work: %(TOPLEVEL)s/experiments/myvoice/acoustic_model
16c16
< file_id_list: %(data)s/file_id_list_full.scp
---
> file_id_list: %(data)s/file_id_list.scp
41,42c41,42
< enforce_silence : False
< silence_pattern : ['*-sil+*']
---
> enforce_silence: False
> silence_pattern: ['*-sil+*']
45c45
< label_align: %(TOPLEVEL)s/experiments/my_voice/acoustic_model/data/label_state_align
---
> label_align: %(TOPLEVEL)s/experiments/myvoice/acoustic_model/data/label_state_align
72c72
< use_cep_ap: False
---
>
74a75
> switch_to_keras: False
88c89
< switch_to_keras: False
---
>

Duration:
3c3
< Merlin: /home/ubuntu/pynb/TFplay/merlin
---
> Merlin: /home/ubuntu/pynb/TFplay/merlin2
5c5
< TOPLEVEL: /home/ubuntu/pynb/TFplay/merlin/egs/build_your_own_voice/s1
---
> TOPLEVEL: /home/ubuntu/pynb/TFplay/merlin2/egs/build_your_own_voice/s1
10c10
< work: %(TOPLEVEL)s/experiments/my_voice/duration_model
---
> work: %(TOPLEVEL)s/experiments/myvoice/duration_model
16c16
< file_id_list: %(data)s/file_id_list_full.scp
---
> file_id_list: %(data)s/file_id_list.scp
34c34
< silence_pattern : ['*-sil+*']
---
> silence_pattern: ['*-sil+*']
37c37
< label_align: %(TOPLEVEL)s/experiments/my_voice/duration_model/data/label_state_align
---
> label_align: %(TOPLEVEL)s/experiments/myvoice/duration_model/data/label_state_align
40c40
< add_frame_features    : False
---
> add_frame_features: False
43c43
< subphone_feats        : none
---
> subphone_feats: none
54a55
> switch_to_keras: False
75,76c76,77
< train_file_number: 135
< valid_file_number: 4


Create 1stPR

:warning: This is a Pull Request Template :warning:

Checkout all the things you've done by placing an x within the square braces below.

Proposed Changes

[] I've read the CODE OF CONDUCT and abide to it.
[] I've read the CONTRIBUTING.md
[] I've forked the repository.
[] I've created a branch and made my changes in it.
[] I understand opening a PULL REQUEST doesn't mean it will be merged for sure.

Please resubmit a new PR following the directions in the CONTRIBUTING guide:
https://github.com/my-first-pr/hacktoberfest-2018/blob/master/CONTRIBUTING.md
Thank you! 🙌


Create a 32-bit Prefix Adder

Check README.md for details.
Design File: 45 Points
Test Bench: 25 Points
Total Points: 70 points
Bonus Task: 150 points

can you assign this to me?

The issue is yours, you have 20 mins remaining.


Coverage

Added

Adds support for code coverage using istanbul via the latest version of floss. Can be generated using npm run coverage. Open coverage/index.html to see report.

Example coverage report:

Should we deploy the coverage results to S3 so we can track improvements over time?

@englercj good idea, I can add.

See report here: https://pixi-builds.s3-eu-west-1.amazonaws.com/coverage/coverage/index.html

Nice! This is so cool, last step would be to not cover node_modules. That should reduce build/test time and cleanup the output too.
Amazing work so far!!

Okay, I got around this by building Pixi without externals, running coverage and then rebuilding the bundle again (for deployment). Slightly longer build time, but works well.


[WIP] add new CUAV Nora board

@CUAVcaijie I'm opening this as a pull request so we can finish it collaboratively.
https://github.com/cuav/hardware/tree/master/X7_Autopilot/Nora_AP
TODO:

[ ] add to CI
[ ] adis16470 driver
[ ] icm20649 driver

I have initial drivers for the Analog Devices ADIS16470 and InvenSense ICM20649. I'll bring them in as separate pull requests.

I have initial drivers for the Analog Devices ADIS16470 and InvenSense ICM20649. I'll bring them in as separate pull requests and then we can rebase.

Thank you. When will it be possible to add drivers?

Closing in favor of https://github.com/PX4/Firmware/pull/14475


Added fp hex notation article link under 'Notes'

I added it to Notes for now. If there will be more material we can put them into a separate section.

Will also be on the website as soon as I update it.

Cool thanks 😃


Graph: Cross Browser Issues

The graph is showing up as blank in IE8, 9, and Safari.
See trello for screenshots: https://trello.com/c/v4P7UsBb/77-hot-module-looks-different-in-different-browsers

@julielorch Can we talk about IE8? There is a lot that is not supported and I'm not sure there is much we can do about it. IE8 is looking like this. I want to get an idea of what we absolutely need and what we can not worry about in IE8.

My 2¢: I think this is a perfect example of progressive enhancement. All the important information is still there & nothing appears broken to the user. IE 8 is only ~1% of our traffic, so let's be careful not to spend too much engineering time on it. :)

+1 to @DFurnes's comments. As long as the other browsers are set and all that remains is IE8 looking like this I think we should be good to close out this issue.

great, closing.


Default null raises exception. Default modal to ShipStation boolean d…

…efaults.
Unless you explicitly set all the boolean properties, null throws the following api error:
{
  "Message": "The request is invalid.",
  "ModelState": {
    "apiOrders[0].advancedOptions.nonMachinable": [
      "Error converting value {null} to type 'System.Boolean'. Path '[0].advancedOptions.nonMachinable', line 1, position 1533."
    ]
  }
}

Thanks! I agree that we should set these items to false by default anyways.


When there's no primary email, the first email should be selected

Fixes #9321

I'm fixing the tests. Do you think there might be a user with no email at all or is this something that never happens ?

Hm, I'm afraid that modifying primary_email could have a lot of other consequences, it might be safe to create a new property.

I'm not sure this is the right approach, we probably don't want to make assumptions about what the primary email is.
The bug in question seemed to happen because the email in question was reset/added but not marked as primary. We should ensure that it's not possible to add an email address via the admin UI without the primary field checked if there are no other primary email addresses on the account.
I'm not super concerned about old accounts that might not have emails or might not have a primary email.

Thanks for your insight!
I had assumed the problem was old emails because my tests so far didn't yield any way of not having a primary email:

when you create an account, you have to provide an email, and it's set as primary
There's no delete button if the email is primary

So maybe it's a UI bug somewhere (e.g. maybe if I open 2 webpages and swith primary in one, I can delete the primiry email in the other one, I'll check that) but if there's no such bug, I would say emails should be sent to any email if there's no primary (which should not happen in the first place)

Nope. I've checked and the view successfully detects an attempt in deleting the primary address with an error.

I was specifically talking about the PyPI admin UI, in which it is possible to make an account have no primary email addresses.

Do we have an idea how many accounts have no primary address ?

Aaaaaaah ok, I'll check.

@di new approach :) Better ?
https://user-images.githubusercontent.com/1457576/113491652-bbd0d300-94d2-11eb-89b5-25dbba3fd577.mov

Yep, that's exactly what I was thinking. Will review this shortly!


Added a wrapper for Enzyme's Cheerio-powered render method

Closes #12

Hi @amarnus thanks for your work. There are a few things I would like to add and modify before I merge this into master. I've created a new branch of your work and mine in pr #14 to be merged to master.


Have error when use Icon component

Issue type
I'm submitting a ...  (check one with "x")

[x] bug report
[ ] feature request

Issue description
Current behavior:

When I use Icon component, sometime I encounter error "view nested within a text must have a width and height"
Expected behavior:

It should not have error and crash app
Steps to reproduce:

Use Icon component
Related code:

Not applicable.
Other information:
OS, device, package version
samsung device
"react-native": "0.60.5"
"react": "16.9.0"
"@ui-kitten/eva-icons": "4.2.0-beta.2"
"@eva-design/eva": "1.1.0-beta.1"

Hi, please provide related code on how do you use this component. Thanks

Hi,
This is some examples that I use Icon component. I don't know where fired
error.
But when a replace and use package "react-native-eva-icons": "1.1.0",  the
error don't occurred.
On Sat, Sep 21, 2019 at 8:54 PM Artur Yorsh<EMAIL_ADDRESS>wrote:

Hi, please provide related code on how do you use this component. Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/akveo/react-native-ui-kitten/issues/633?email_source=notifications&email_token=AGHR4HOGO5GDKJ77AL7PGGDQKYRQRA5CNFSM4IY6DQLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ISGXY#issuecomment-533799775,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGHR4HJ2BATII7GLL7QXQGDQKYRQRANCNFSM4IY6DQLA
.

@DinhHuyHoang unfortunately, there is no code I can see to determine what's wrong. I would like to see how do you use Icon, if possible

I sent two image attaches above.
this is some code I used Icon component, because it have error then I
replace with package "react-native-eva-icons".
Two links bellow are code example in my project, I just know when I use
"react-native-eva-icons", the error not fired,
Please, check my code and if have any problem tell me know.
Thanks you.
http://codepad.org/E8oApexl
http://codepad.org/1knu3Abt
On Mon, Sep 23, 2019 at 4:06 PM Artur Yorsh<EMAIL_ADDRESS>wrote:

@DinhHuyHoang https://github.com/DinhHuyHoang unfortunately, there is
no code I can see to determine what's wrong. I would like to see how do you
use Icon, if possible
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/akveo/react-native-ui-kitten/issues/633?email_source=notifications&email_token=AGHR4HJI3HXRTABVZME6QWDQLCBIFA5CNFSM4IY6DQLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7KHGQI#issuecomment-534016833,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGHR4HNQ2JS2RV5RQUM32K3QLCBIFANCNFSM4IY6DQLA
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/akveo/react-native-ui-kitten/issues/633?email_source=notifications&email_token=AGHR4HJDOFMNPV7VAYIGDL3QLHWLVA5CNFSM4IY6DQLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7N6CDI#issuecomment-534503693,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGHR4HI5LVC6PLCKXMFIY2DQLHWLVANCNFSM4IY6DQLA
.

Please try refactoring to something like this as it looks like we were wrong about this guide
The main point is to render IconRegistry before ApplicationProvider.
import React from 'react';
import { mapping, light as lightTheme } from '@eva-design/eva';
import { EvaIconsPack } from '@ui-kitten/eva-icons';
import { ApplicationProvider, IconRegistry, Layout, Text } from 'react-native-ui-kitten';

const App = () => (
  <React.Fragment>
    <IconRegistry icons={EvaIconsPack} />
    <ApplicationProvider
      mapping={mapping}
      theme={lightTheme}>
      <YourApp />
    </ApplicationProvider>
  <React.Fragment />
);

export default App;``

I solved my problem, the error fired when I wrap Text component with Icon
component
Thank for your help.
On Wed, Sep 25, 2019 at 12:41 AM Artur Yorsh<EMAIL_ADDRESS>wrote:

Please try refactoring to something like this as it looks like we were
wrong about this guide
The main point is to render IconRegistry before ApplicationProvider.
import React from 'react';import { mapping, light as lightTheme } from '@eva-design/eva';import { EvaIconsPack } from '@ui-kitten/eva-icons';import { ApplicationProvider, IconRegistry, Layout, Text } from 'react-native-ui-kitten';
const App = () => (
<React.Fragment>

<React.Fragment />
);
export default App;``
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/akveo/react-native-ui-kitten/issues/633?email_source=notifications&email_token=AGHR4HPNORJJDOOCLXGRESTQLJGMJA5CNFSM4IY6DQLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7PGLHQ#issuecomment-534668702,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGHR4HLWREJIGMU43YVDR3DQLJGMJANCNFSM4IY6DQLA
.


RUM-6896: Add custom drawable mappers to resolve extension drawable

What does this PR do?
In Session Replay, we noticed that there are some components have transparent background in player, which make the content not visible.
After investigation, we see that it's due to the background drawable that we currently can not parse.
According to Telemetry, here is a top list of the drawable that we don't support:

On top of that, it's MaterialShapeDrawable, which belongs to material components, in this case we need to inject a custom mapper from dd-sdk-android-session-replay-material to dd-sdk-android-session-replay, so that when user add the extension of material, it can parse the drawable.
Motivation
RUM-6896:
Demo

Before
After

Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
Attention: Patch coverage is 58.82353% with 14 lines in your changes missing coverage. Please review.

Project coverage is 70.34%. Comparing base (d02dd48) to head (3204506).
Report is 2 commits behind head on develop.

Files with missing lines
Patch %
Lines

...sessionreplay/utils/LegacyDrawableToColorMapper.kt
22.22%
4 Missing and 3 partials :warning:

...material/internal/MaterialDrawableToColorMapper.kt
20.00%
4 Missing :warning:

...droid/sessionreplay/utils/DrawableToColorMapper.kt
50.00%
2 Missing :warning:

...sessionreplay/material/MaterialExtensionSupport.kt
66.67%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2357      +/-   ##
===========================================
- Coverage    70.35%   70.34%   -0.01%
===========================================
  Files          741      742       +1
  Lines        27645    27671      +26
  Branches      4624     4630       +6
===========================================
+ Hits         19448    19464      +16
- Misses        6910     6917       +7
- Partials      1287     1290       +3

Files with missing lines
Coverage Δ

...com/datadog/android/sessionreplay/SessionReplay.kt
69.23% <100.00%> (+0.81%)
:arrow_up:

...ndroid/sessionreplay/SessionReplayConfiguration.kt
97.06% <100.00%> (+0.09%)
:arrow_up:

.../sessionreplay/internal/DefaultRecorderProvider.kt
93.65% <100.00%> (+0.10%)
:arrow_up:

...oid/sessionreplay/internal/NoOpExtensionSupport.kt
100.00% <100.00%> (ø)

...oid/sessionreplay/internal/SessionReplayFeature.kt
98.11% <100.00%> (-0.62%)
:arrow_down:

...nreplay/internal/recorder/SessionReplayRecorder.kt
97.08% <100.00%> (+0.02%)
:arrow_up:

...ssionreplay/utils/AndroidMDrawableToColorMapper.kt
80.00% <100.00%> (+5.00%)
:arrow_up:

...ssionreplay/utils/AndroidQDrawableToColorMapper.kt
49.02% <100.00%> (+1.02%)
:arrow_up:

...sessionreplay/material/MaterialExtensionSupport.kt
96.55% <66.67%> (-3.45%)
:arrow_down:

...droid/sessionreplay/utils/DrawableToColorMapper.kt
33.33% <50.00%> (+13.33%)
:arrow_up:

... and 2 more

... and 24 files with indirect coverage changes


Open table in compose button and Checkbox functionality

Hi,
I want to show table in compose button click which is having checkboxes in each row.
So after after selecting checked checkbox , that checked row data should be displayed in compose body in table form ..
Can you please tell me how and where to write javascript/jquery  for checkbox functionality and how to display in compose body

This kinda of functionality can be developed for almost any web-page, and "plugged" into Gmail with little to no effort.
As such, I don't consider this a library-specifc issue, but a a general JS development-question.
If you need help with this, please conduct research and seek help in more appropriate web-dev forums, or stack overflow.


Update Composer dependencies (2023-12-15-00-15)

Visual regression test passed!
View the visual regression test report


No gpu control

Describe the bug
After update I cant control manuały gpu clock, i Have tried steam patch but didnt help
What did you expect to happen?
Solution
Output of rpm-ostree status
No response
Hardware
Lenovo legion go
Extra information or context
No response

Yes it was working with a bit of lag while adjusting.Now after toggle it on it nothing happens and shows up.

We don't use steam patch here, I would completely remove that and then make sure you follow the alternative handheld section of the readme.

Yes alternative SimpleDeckyTDP or PowerControl

We don't use steam patch here, I would completely remove that and then make sure you follow the alternative handheld section of the readme.

How can remove the patch , there is no terminal path for this on github legion tricks.Thank you

Yes nothing explain a completed uninstalling. The easiest way is a Clean Install. It's not Recommended to use this anymore.  The easiest way is a Clean Install. It's not Recommended to use this anymore.  So my experience is Clean Install and Install SimpleDeckyTDP. That's the best way.

So let be it. Good news is that bazzite dont erase windows partition like chimera os so clean install is pretty easy .Back in days i was force to install windows from scratch and that was painful expirence

Can confirm fresh install fixed gpu control.Kudos for bazzite developers 🫶

Can confirm fresh install fixed gpu control.Kudos for bazzite developers 🫶

Perfect. Issue fixed👍

I have the same issue.


Cannot update to React ^16.0.0

Cannot update to React ^16.0.0
Steps to Reproduce
Create a new SPFx project
Update React by changing versions in package.json to ^16.0.0 and running npm update
Execute the SPFx project

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b6f89fed-848e-50b9-6be4-657824ad262e
Version Independent ID: 3d3c5227-7281-ef49-a2d1-686c0a049497
Content: Use Office UI Fabric React components in your SharePoint client-side web part
Content Source: docs/spfx/web-parts/get-started/use-fabric-react-components.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

We cannot just upgrade the React but to upgrade all modules at the same time. Best to keep all default module version. All module version must be synchronized.


fix path inference on windows hosts

also add support for WASM binaries
closes #32
This also prepares a new release
The Windows CI is a shot in the dark. Let's see if it works if not it can be
postponed.

bors r=ryankurte

Published: https://crates.io/crates/cargo-binutils


GDScript warnings proposals

Issue description:

It's cool we can disable warnings for files and would be even better if we could disable them for whole directory, especially this one
res://addons

A warning for unused setter function. If a member has a setter it probably should be used. I want to use setter by default and direct assignment in exceptional circumstances.
Maybe getters should get their warning as well.

I'm not sure if i should get "argument is never used" in such code:

func _init( a ).( a ):
	pass

I'm forwarding argument to base class. This warning appears if object gets instanced.

Could be done, though I'm not sure what's the best way to do it. Add an option for a list of ignored folders?

Don't know what you mean, setters are usually meant for external entities. The class itself does not really need to use the setters. I'd like to see some other opinions on this, and even if added should be disabled by default.

That's actually a bug, could be made in a report of its own.

1 : Any chance it can be done for 3.1? I know we're in feature freeze but without this option i'll most likely won't be using warning system. And i really want to use it.
List of ignored folders sounds fine. There could also be a list of unignored folders. More nested folder would have a priority, for example:
ignore-list = "res://ignore_everything_here"
unignore-list = "res://ignore_everything_here/except/this_directory"
But unignore list can be added later. The sooner i can ignore res://addons the happier a man i'll be.
2 : I write setters when i need something done everytime a class member changes. If i'm not mistaken that's one of the reason behind setters. Is it not?
Currently it's easy to have a script that makes a direct assignment to its member by mistake, especially since it's a recommended way of writing code.
Let's see what other users have to say. Maybe i'm just strange.
3 : Ok, i'll file a bug report.

Note: I think this is actually implemented in 3.2, but I can't remember when it was added.
Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


PBMC for cell_subset ontology

@bussec I think this was discussed somewhere before but I forget. I'm working on a study and filling out the metadata. They've taken PBMC from blood and sequenced, so believe that I should define the fields like this:
tissue:"peripheral blood"
cell_subset:
  id: "CL_2000001"
  name: "peripheral blood mononuclear cell"

However CL_2000001 is not under the CL_0000542 "lympocyte" node in the tree. Is that problem, am I doing it right? Or should I use "T cell" because ultimately T cells were sequenced even though we didn't do any cell sorting??

There is also the general question when tissue is taken, no cells are sorted, but a subset ends up being selected based upon the nucleic acid processing (e.g. PCR primers), how do we record the cell_subset?

cell_subset should only be used if the cells were sorted by flow cytometry. For "standard" PMBCs, i.e., peripheral blood draw followed by Ficoll gradient, my suggestion would be:
sample_type:"peripheral venous puncture"
tissue:"peripheral blood"
tissue_processing"Ficoll gradient"
cell_subset:NULL

Looking at the CO tree, PBMC is a child node of mononuclear cell, which is a sister taxon of lymphocyte. Therefore CO's PBMC definition excludes lymphocytes. While people could argue about their terms (as lymphocytes are "mononuclear"), the separation as it is done by CO does make sense from a developmental point of view (which they try to keep on a separate level from the anatomical site).
Regarding your second question: If an experiment's restriction to T cells is based on the primer sets used, this would IMO best be annotated using the PCRTarget object.

#%$&^%$&#&^$%#&#&#
Half of our data has a cell_subset of "peripheral blood mononuclear cell" from CO. If you take the {"ontology": "CL", "top_node": "lymphocyte", "draft": true} then we have made an error. If you go up one node  as the parent ("top_node":"nongranular leukocyte"}, then we encompass PBMC and we did not make an error...
I guess my question would be do we have the correct top node for the ontology? And if I understand correctly, this implies the question, is the correct intent for cell_subset to be for sorted cells only? @bussec you say flow sorting only, is that the only method for cell sorting that would allow you to put something in cell_subset, or are there other cell sorting techniques (I assume so???).

#%$&^%$&#&^$%#&#&#

Uh oh... lucky me that there are 8000 km between BC and here :wink:
Jokes aside: I am not strictly opposed to move the top node for cell_subset, but only if this results in a more consistent "stack" of sample/tissue/cell annotation. So to summarize the thoughts that MiniStd had on this topic:

We choose lymphocyte as it was the lowest node in the CL hierarchy that contained all populations that are expected to undergo V(D)J recombination. Note, however, that not all entities in lymphocyte undergo recombination (e.g., NK cells).
The populations described in lymphocyte are mainly defined by properties defined by phenotype or function, not by anatomic locations (exceptions: GC B and IEL T cells, but even those are rather on a histological level). Therefore the cell_subset can be easily combined with the sample_type, tissue, anatomic_site keys, w/o any additional sanity checks.
Yes, there are other ways to sort cells than flow cytometry (FC), but right now this is what >95% of all studies are doing. In addition, the population in CL add primarily based on FC phenotype.

From the MiniStd perspective cell_subset and cell_phenotype always went together, although I have to admit that this got lost in the current field descriptions. So if you cannot annotate a cell_phenotype (which is the FC phenotype) you don't have a cell_subset.

One other option we can think about is having a *_presort and a *_postsort key that both take CL terms, with the latter one being NULL for non-sorted cells.

We choose lymphocyte as it was the lowest node in the CL hierarchy that contained all populations that are expected to undergo V(D)J recombination. Note, however, that not all entities in lymphocyte undergo recombination (e.g., NK cells).

OK, dumb immunology question for the day... If PBMCs don't undergo VDJ recombination, why are we sequencing them??? Have they already gone through VDJ recombination in a past life, but do not undergo further VDJ recombination, but we still want to know which exist in our peripheral blood? Because they don't recombine any more, we don't need to (and possibly can't) sort them into cell_subsets?
If they do undergo VDJ recombination then why doesn't our root node in the taxonomy include them?

#%$&^%$&#&^$%#&#&#
Uh oh... lucky me that there are 8000 km between BC and here 😉

This is not actually a hard change to make, as it is at the metadata level... We just tried really hard to make sure we were using the right ontology terms. And we are, just not the right root node 8-)
So the question is, is it wrong to have PBMC in a cell_subset field???

#%$&^%$&#&^$%#&#&#
Uh oh... lucky me that there are 8000 km between BC and here 😉
Hmmm, if you stacked 1B PBMC cells together end to end, how close would I be to reaching @bussec 8-)

No, they don't undergo VDJ recombination. But you can specifically amplify
VDJ rearrangements from the total RNA or DNA anyway, because unrearranged
Vs and Js (or Cs) are too far apart to form amplicons.
Personally, I find it a bit sloppy: I think it's important to have a more
accurate count of how many (rearranged) cells you are sequencing, and I do
see an increase in non-specific product. But there's also a case to be made
that it allows you to capture more of the repertoire by avoiding sorting
losses and that, in some cases, sorting loss may be biased in a way that
distorts the results.
In theory, it doesn't even have to be PBMC --the same would apply to whole
blood. But you would have to increase the number of rounds of PCR to
compensate for the additional dilution and PBMC are pretty easy to isolate.
However a similar unsorted strategy has been used by Nina's lab for other
tissues (eg https://www.ncbi.nlm.nih.gov/m/pubmed/28829438).
On Mon, Sep 9, 2019, 6:44 PM Brian Corrie<EMAIL_ADDRESS>wrote:

We choose lymphocyte as it was the lowest node in the CL hierarchy
that contained all populations that are expected to undergo V(D)J
recombination. Note, however, that not all entities in lymphocyte
undergo recombination (e.g., NK cells).

OK, dumb immunology question for the day... If PBMCs don't undergo VDJ
recombination, why are we sequencing them??? Have they already gone through
VDJ recombination in a past life, but do not undergo further VDJ
recombination, but we still want to know which exist in our peripheral
blood? Because they don't recombine any more, we don't need to (and
possibly can't) sort them into cell_subsets?
If they do undergo VDJ recombination then why doesn't our root node in the
taxonomy include them?
#%$&^%$&#&^$%#&#&#
Uh oh... lucky me that there are 8000 km between BC and here 😉
This is not actually a hard change to make, as it is at the metadata
level... We just tried really hard to make sure we were using the right
ontology terms. And we are, just not the right root node 8-)
So the question is, is it wrong to have PBMC in a cell_subset field???
[image: image]
https://user-images.githubusercontent.com/1105216/64571431-b3c1a900-d318-11e9-975d-43ba21e947dc.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/airr-community/airr-standards/issues/242?email_source=notifications&email_token=ABTF5YDSIFM4WABYSLENYP3QI3GVTA5CNFSM4IUCISHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6JIHRQ#issuecomment-529695686,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTF5YH4XIVIBU7FQZ4QBITQI3GVTANCNFSM4IUCISHA
.

@schristley I am still a bit unclear as to the resolution here.
In IPA, half of our data has a cell_subset of PBMC.
So in this case, because the cell ontology does not include PBMC, this is actually incorrect as the cell subset for these repertoires should be Null or empty. Which means that half of the data in the IPA doesn't have cell subset information. Just want to double check that I have that correct before we make that change, as it is pretty substantial...
Essentially the graph below would change from having half the data with PBMC to having half the data with NA for cell_subset. This seems odd, but maybe not...
Looking at our data further, some of the PBMC studies have no cell_subset_phenotypes, but some do. We have three studies that have PBMC with different cell_subset_phenotypes:
tissue:        cell_subset:        cell_subset_phenotype
Blood          PBMC                NA
Blood          PBMC                CD34+
Blood          PBMC                CD3-, CD14-, CD19+...

Does this imply that we perhaps have some studies improperly classified as having a cell_subset of PBMC, given that the cell_subset_phenotype seems to imply some sort of cell sorting???

And we also agreeing that the root node for the ontology stays the same...

@bcorrie it's cell_phenotype not cell_subset_phenotype so hopefully that is just a typo in your issue text.
According to @bussec ,cell_subset should only be used if the cells were sorted by flow cytometry, and it should be matched with cell_phenotype to indicate the sorting markers.
That would imply if you have markers in cell_phenotype that cell sorting occurred and the use of PBMC in cell_subset is likely incorrect (imprecise). PBMC might be the cells that were input into the sorting process, but not the actual cell subset that was sorted out.
For my study, I changed according to Christian's suggestion.
sample_type:"peripheral venous puncture"
tissue:"peripheral blood"
tissue_processing"Ficoll gradient"
cell_subset:NULL

This would suggest that if somebody wanted to query for PBMC (which I guess means they want blood samples), they likely would query on tissue:"peripheral blood" or maybe a less restrictive tissue contains blood type of query.

@bcorrie it's cell_phenotype not cell_subset_phenotype so hopefully that is just a typo in your issue text.

Yep, that is my typo, on the gateway our human readable expansion of the field name is the longer version and I added underscores to create a field name 8-)

That would imply if you have markers in cell_phenotype that cell sorting occurred and the use of PBMC in cell_subset is likely incorrect (imprecise). PBMC might be the cells that were input into the sorting process, but not the actual cell subset that was sorted out.

OK, that is kind of where I thought things might be heading, I am checking with the more scientific/curation side of the iReceptor house to confirm 8-) We have two studies that look like they may have cell_subsets that got sorted but started with PBMC.

Hi all, since we are diving back into ontologies, wanted to clarify a bit more - naive biology once again...
If you just have PBMC then there is no cell sorting and therefore no cell_subset. So this means that the sequencing could/should produce both B cell and T cell rearrangements. Is that correct?

?you can sequence both B and T cells from PBMCs, but what the sequencing "should" produce depends on the primers used. Sometimes people sequence only TCRB from PMBC, for example.

Lindsay G. Cowell, PhD
Division of Biomedical Informatics
Department of Population and Data Sciences
University of Texas Southwestern Medical Center at Dallas
5323 Harry Hines Blvd.
Dallas, TX  75390-9066
F4.212b, MC9066
phone:<PHONE_NUMBER>
fax:<PHONE_NUMBER>
<EMAIL_ADDRESS>
From: Brian Corrie<EMAIL_ADDRESS>Sent: Friday, March 20, 2020 11:24 AM
To: airr-community/airr-standards
Cc: Subscribed
Subject: Re: [airr-community/airr-standards] PBMC for cell_subset ontology (#242)
EXTERNAL MAIL
Hi all, since we are diving back into ontologies, wanted to clarify a bit more - naive biology once again...
If you just have PBMC then there is no cell sorting and therefore no cell_subset. So this means that the sequencing could/should produce both B cell and T cell rearrangements. Is that correct?

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/airr-community/airr-standards/issues/242#issuecomment-601789646, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPC5BNXDYZCCUHJLL4B4BLRIOKCLANCNFSM4IUCISHA.
CAUTION: This email originated from outside UTSW. Please be cautious of links or attachments, and validate the sender's email address before replying.

UT Southwestern
Medical Center
The future of medicine, today.

If you just have PBMC then there is no cell sorting and therefore no cell_subset. So this means that the sequencing could/should produce both B cell and T cell rearrangements. Is that correct?

Just to be clear, doing PBMC doesn't prevent the researcher from doing cell sorting, so there could be a cell_subset. For example, the Florian data set is PBMC but they also did cell sorting.
But if the researcher isn't sorting for specific subsets then Lindsay is right that the primers are used to pick out T or B cells. And they could do both. The pcr_target_locus field should indicate which are targeted.

Above @schristley says:

For my study, I changed according to Christian's suggestion.

sample_type:"peripheral venous puncture"
tissue:"peripheral blood"
tissue_processing"Ficoll gradient"
cell_subset:NULL

There is no peripheral blood in the UBERON tissue taxonomy, would you just use blood instead?

There is no peripheral blood in the UBERON tissue taxonomy, would you just use blood instead?

That seems reasonable. If you knew that the blood sampling was taken from a vein, then you could be more specific with venous blood.

In nearly all cases venous blood (UBERON:0013756) will be correct and it should be used in the case of sample_type:"peripheral venous puncture". However, if the mode of sampling is not specified,  blood (UBERON:0000178) should be used instead.

There's useful annotation information here, we should add it to the guidelines.

@bcorrie This seems like a documentation issue. What is the information that we need to write up?


Add willReadFrequently option when obtaining Canvas2D context

Recent versions of Google Chrome now issue a warning due to a missing willReadFrequently option when getting the Canvas2D context.
The warning message is as follows:

Canvas2D: Multiple readback operations using getImageData are faster with the willReadFrequently attribute set to true. See: https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently

This PR addresses this by adding the option willReadFrequently: true to both getContext() calls that preceed a getImageData() call.

Hey @mourner , can we have a release with this patch? Thanks!


Bump Composer to 0.21.1

@jjanezhang you'll need to update fsdp_elastic_sharded_enabled to fsdp_sharded_state_dict_enabled in the AsyncEvalCallback in order for code quality to pass

regression run here: llm-foundry-regression-tests-runner-IrKOoP


replace a lot of the confusing conv reshapes, etc... with einops

Forgive my ignorance but I'm not really sure what this issue means.
In conv2d the line:
ret = (x * weight.reshape(1, groups, rcout, 1, 1, cin, H, W)).sum((-3, -2, -1)).reshape(bs, cout, oy, ox)
is equivalent(*1) in numpy terms to:
ret= np.einsum('ngcyxkji,gckji->ngcyx', x.numpy(), weight.reshape(groups,rcout,cin,H,W).numpy()).reshape(bs,cout,oy,ox)
Is this what is meant by "einops"?
If so I imagine that shoving the result of the above into a tensor wouldn't maintain the gradient. Does tinygrad have an einsum op? This issue and another issue are the only places that github search surfaces the usage of the word "einop". The word einsum appears in the implementation of MULACC but I don't think thats it. If it is could you please explain the name? It's not mentioned in any part of the code (again according to github search feature) unless you count the A * A -> B in the readme, which doesn't suggest einsum or something like it.
(*1): The result is close with random inputs but a lot of entries are off by ~1e-6. I'm assuming that this is due to either the use of non-deterministic algorithms or something negligible like that.

It's easy to maintain a gradient through einops :)

Hi, I would like to work on this. Is it okay?

Please do, I still don't get what is meant by "einops".

Please do, I still don't get what is meant by "einops".

It is a library for readable and flexible tensor operations: https://github.com/arogozhnikov/einops

Thank you for clarifying.

Hello @geohot, @sixChar, and @rabiaedayilmaz,
To shed some light on the concept, here's a rough idea of how you might refactor the convolution code snippet with Einops:
from einops import rearrange, reduce

# assume `x` and `weight` are your input tensors
x = rearrange(x, 'bs cin (h kh) (w kw) -> bs cin h w kh kw', kh=H, kw=W)
weight = rearrange(weight, 'rcout cin H W -> rcout cin H W')

# now we perform the convolution in a more readable way
ret = reduce(x * weight, 'bs rcout h w kh kw -> bs rcout h w', 'sum')

As you can see, Einops provides a clear, readable way to reshape and reduce tensors, enhancing the maintainability and readability of the codebase.

Anybody taking this up ?


Composer support

Does it make sense to add support for composer to this plugin? And also support for default global packages as per the nodejs and ruby plugins?
If you think this is worthwhile doing and are open to a PR, I'll have a stab at implementing it.

Isn't npm part of node though?  Gems are included in ruby and I think they are including the equivalent package (bundler) in core ruby.
Just pointing out it's a slightly different scenario.

@j-dexx only gems is included, not bundler. :)

@salzig I did say including :)...it was added as a default gem in ruby 2.6

Bundler is now installed as a default gem.

@j-dexx nice, didn't realized that :)

Expose composer vendors binaries, please!


chore(solc): improve io error for bad symlinks

Motivation
Improve error if we try to read a file from a bad symlink

Solution
add new error variant

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Updated the changelog

lint failure fixed here https://github.com/gakonst/ethers-rs/pull/1595


Add concept 'array-transformations' and improve the concept's exercise

Fix #1326

@junedev @SleeplessByte Before I continue this PR, am I getting the concept right?

@TomPradat I wrote in the issue description that I would recommend replacing fill with reverse. So the concept should introduce reverse instead of fill.
Since there are a lot of methods in the exemplar, you can also introduce some of the easier methods just with a list. You can see an example here: https://github.com/exercism/javascript/blob/main/concepts/strings/introduction.md#concatenation-and-methods
You don't have to provide the details/examples for all the methods from the exemplar, I would focus on the more difficult ones like reduce.

Time flies by but I haven't forgotten this PR, I'll work on this soon hopefully :). By the way, I'll probably scope this PR to adding the new concept only in order to make this mergeable more quickly

@TomPradat It seems I missed your question re the method list. Please proceed as you like which regards to that.

@TomPradat I finished this up so it can be merged. Hope that's ok. It still misses sort I think but that can be added when working on the exercise part.

@TomPradat I finished up the concept so it can be merged first. Hope that's ok. It still misses sort I think but that can be added when working on the exercise part.

That's a good idea, thank you for the hand :+1:


Update README to point to gekidou

Few people realize that active development moved to that branch, so let's but a giant notice at the top of the readme.

/release-note-none


Mod keeps crashing whenever I try to use it in a server

I'm using this in my modded server for 1.12.2 and I'm using the newest version of the mod. Does anyone know how to get it to stop crashing?

Same for me, but I use Aternos Magma is there a way to make it work?

Same for me, but I use Aternos Magma is there a way to make it work?


Header change: add icons

Let's add GitHub, Slack, and Twitter icons up top in the NRE Labs page header to encourage more eyes on the project and more Slack engagement.

@jameskellynet Can you re-open this in https://github.com/nre-learning/antidote-web

Done

Moved to https://github.com/nre-learning/antidote-web/issues/15


Contextual Contrasting Loss Function

Hi there,
I was taking a closer look in the implementation of the contextual contrasting loss and and I am having trouble understanding how the positive samples are being treated differently from the negative ones, and specifically how this corresponds to the Eq. 5 of your paper. Could it be that labels should have some elements equal to one and not all of them being zeros?
https://github.com/emadeldeen24/TS-TCC/blob/ebfdbab03dc03842b0c18ec16d64fbd923bd5779/models/loss.py#L61-L62
Thanks!

In the contextual contrasting loss, after calculating the similarity matrix for elements in zis and zjs, we extract the positive and negative samples from the similarity matrix.
The positive samples are the diagonal elements of the upper-left and lower-right quadrants, corresponding to elements that come from the same representation. These positive samples are extracted twice: once with an offset of batch_size to get the positive samples from the upper-left quadrant, and once with an offset of -batch_size to get the positive samples from the lower-right quadrant. The positive samples are then concatenated and reshaped into a column vector called positives.
The negative samples are obtained by masking the similarity matrix using the mask_samples_from_same_repr mask, which has a value of True for elements that should be considered negative samples.
The logits are constructed by concatenating positives and negatives along the second dimension (columns).
The labels for the logits are created as a tensor of zeros with a shape of (2 * batch_size). Since the positive samples are in the first column of the logits, the labels are all zeros, indicating that the first column of logits corresponds to the positive samples.
In summary, the positive samples are treated differently by extracting them separately from the similarity matrix and concatenating them as the first column of the logits. The negative samples are obtained by masking the similarity matrix, and they occupy the remaining columns of the logits. The labels are set to zeros for all samples, indicating that the first column corresponds to the positive samples.


Error : `active_admin_settings_page': uninitialized constant Options::VALID_OPTIONS

Using following versions of gem
rails-settings-cached (0.6.6)
rails (= 4.2)
activeadmin (1.0.0.pre2)

activeadmin_settings_cached (2.0.0)
      activeadmin
      rails-settings-cached (>= 0.5.3)

Activeadmin setting page looks like this
ActiveAdmin.register_page "Setting" do
  title = 'Settings'
  menu priority: 99

  active_admin_settings_page(
    title: title
  )
end

configuration
ActiveadminSettingsCached.configure do |config|
  config.model_name = 'SiteConfig'
end

Error I'm getting on starting rails server :
gems/activeadmin_settings_cached-2.0.0/lib/activeadmin_settings_cached/dsl.rb:14:in `active_admin_settings_page': uninitialized constant Options::VALID_OPTIONS (NameError)
	from /Users/rohittrivedi/work/professional/learninglabs/app/admin/setting.rb:5:in `block in <top (required)>'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/dsl.rb:15:in `instance_exec'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/dsl.rb:15:in `run_registration_block'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/namespace.rb:227:in `parse_page_registration_block'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/namespace.rb:63:in `register_page'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/application.rb:187:in `register_page'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin.rb:76:in `register_page'
	from /Users/rohittrivedi/work/professional/learninglabs/app/admin/setting.rb:1:in `<top (required)>'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/application.rb:215:in `block in load'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/error.rb:41:in `capture'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/application.rb:215:in `load'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/application.rb:207:in `block in load!'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/application.rb:207:in `each'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/application.rb:207:in `load!'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin/application.rb:229:in `routes'
	from /Users/rohittrivedi/.rvm/gems/ruby-2.2.1@learninglabs/bundler/gems/activeadmin-f7483e3b8fcd/lib/active_admin.rb:79:in `routes'
	from /Users/rohittrivedi/work/professional/learninglabs/config/routes.rb:243:in `block in <top (required)>'

Hi, plz try the latest version. This error should be fixed in 2.1.0 version


Introduce setting override tracking and update SettingContainer

Summary of the Pull Request
This PR adds improved override message generation for inheritance in SUI. The settings model now has an OriginTag to be able to denote where a Profile came from. This tag is used in the SettingContainer to generate a more specific override message.
References
#6800 - SUI Epic
#8919 - SUI Inheritance PR
#8804 - SUI Inheritance (old issue)
Spec - SUI Inheritance
Detailed Description of the Pull Request / Additional comments

Terminal Settings Model

Introduced PROJECTED_SETTING as a macro to more easily declare the functions for each setting
Introduced <setting>OverrideSource which finds the Profile that has <setting> defined
Introduced OriginTag Profile::Origin {Custom, InBox, Generated} to trace where a profile came from
DefaultProfileUtils creates profiles for profile generators. So that now sets the Origin tag to Generated
CascadiaSettings::LoadDefaults() tags all profiles created as InBox.
The view model had to ingest the API change to be able to interact with <setting>OverrideSource

Override Message Generation

The reset button now has a more specific tooltip
The reset button now only appears if base layer is being overridden
We use the settings model changes to determine the message to display for the target

Validation Steps Performed
Tested the following cases:

overrides nothing (inherited setting)
overrides value inherited from...

base layer
a profile generator
in-box profile

global settings should not have this feature

Demo

Some more annoying news. It looks like the screen reader doesn't read the hyperlink. I've tried explicitly setting the automation properties as well and no luck.
Hyperlinks seem accessible in XAML Controls gallery. I'm worried this may be a XAML Islands issue? I'm looking more into that now.

Hyperlinks seem accessible in XAML Controls gallery. I'm worried this may be a XAML Islands issue? I'm looking more into that now.

Check the About dialog

Hyperlinks seem accessible in XAML Controls gallery. I'm worried this may be a XAML Islands issue? I'm looking more into that now.

Check the About dialog

The links in there are HyperlinkButtons. They work just fine. I'm guessing they rely on the a11y stuff for buttons so that's why?

I don't expect that this is an islands-specific issue.

Now that the text block is removed, we don't have the accessibility issue.

Main thing I'm unsure about is the macros. I've broken them up and moved them closer to where they're used. Let me know what you think.

There's some weird behavior here:

create new profile w/ proto-extension
that profile has a setting "color scheme = vintage" for example
it appears in SUI as vintage (good)
weird behavior:

we change vintage --> campbell

no reset button (by design)

we set a color scheme to "solarized" in base layer

value is now solarized
no way to reset it back to vintage

(do 1 and 2 concurrently)

reset button appears saying we're overriding base layer (good!)

@cinnamon-msft what should the proper behavior here be.

Had to make a minor modification for proto extension. If we're specifically overriding a value from a proto-extension, we want this reset button to appear. See the demo above for what that looks like.
Design was discussed with @cinnamon-msft.
@DHowett thoughts?

old demo-

Looks like you'll have a conflict with #8414

Sorry, #9036.


run_ci.sh: git log what [base] version is being tested

Zephyr Continuous Integration made the choice of rebasing pull requests
on its fast moving master branch before testing them. Unfortunately the
Shippable interface assumes the other choice[*] and highlights the SHA1
of the pull request before rebasing which is very misleading.  For now
the only way to realize this disconnect is to scrutinize the build logs
and/or this source code (or tribal knowledge).
To mitigate and reduce a bit this confusion, run a short:
git log -n 5 --oneline --decorate
before and after rebase.
Making it worse, Shippable sub-runs are not pegged to a common base
version. For instance the reason why shippable sub-run 35578.1 passed
while all other 35578.x sub runs failed is very likely because PR #13803
was merged to master in the mean time. This commit would have been able
to prove that.
[*] In an ideal world with infinite time and resources, Continuous
Integration would test pull requests BOTH alone and combined with the
moving tip.

To see how what difference it makes in the builds logs click on:
Shippable -> Details -> Success -> build_ci -> 'if [ "$IS_PULL_REQUEST" = "true" ] ... '
... and then scroll up a lot.
Not exactly showing what version CI is testing front and center but much better than not showing it at all.

Codecov Report

Merging #13973 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13973   +/-   ##
=======================================
  Coverage   52.25%   52.25%
=======================================
  Files         307      307
  Lines       45437    45437
  Branches    10508    10508
=======================================
  Hits        23741    23741
  Misses      16904    16904
  Partials     4792     4792

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2d7ca...ce167cd. Read the comment docs.


DataLakeServiceClient file system client read from stream in python

Can you clarify the support for upload_data method in the python DataLakeServiceClient set of APIs, the example states to use upload_data for large files but I'm struggling to use the APIs with any stream source. Can you provide an example.
Cheers
David

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 12220c1c-ebce-cf63-0ef7-41c6b6747329
Version Independent ID: 92bd839f-13a7-296d-c11d-f88fabca61e3
Content: Use Python to manage data in Azure Data Lake Storage Gen2 - Azure Storage
Content Source: articles/storage/blobs/data-lake-storage-directory-file-acl-python.md
Service: storage
Sub-service: data-lake-storage-gen2
GitHub Login: @pauljewellmsft
Microsoft Alias: pauljewell

@davidallan
Thanks for your feedback! We will investigate and update as appropriate.

Hi @davidallan
The upload_data method is used to upload large files without having to make multiple calls to the append_data method. Here is an example of how to use the upload_data method with a stream source:
from azure.storage.filedatalake import DataLakeServiceClient
service_client = DataLakeServiceClient.from_connection_string(connection_string)
file_system_client = service_client.get_file_system_client(file_system="my-file-system")
directory_client = file_system_client.get_directory_client("my-directory")
file_client = directory_client.get_file_client("my-file.txt")
with open("path/to/local/file.txt", "rb") as data:
file_client.upload_data(data, overwrite=True)
In this example, we first create a DataLakeServiceClient object using the connection string. We then get the file system client, directory client, and file client for the file we want to upload. Finally, we open the local file as a stream and pass it to the upload_data method of the file client. The overwrite parameter is set to True to overwrite the file if it already exists.
I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request).
If there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@davidallan
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


refactor: refactor password view into separate component

Describe the changes you have made in this PR
add password toggle view to all the password fields
refactor password view into separate component
add toggle field to new password fields

feat: New feature (non-breaking change which adds functionality)

How has this been tested?
tested all the instances
Checklist

[X] Self-review of changed code
[X] Manual testing
[X] Added automated tests where applicable
[x] Update Docs & Guides
For UI-related changes
[X] Darkmode
[X] Responsive layout

Do an outer component (a consumer of such a component) ever need to control the visibility of this field?
I couldn't come up with a practical use case where this is needed and was wondering if we could move the handling of switching between text / password into this component so outside APIs could just consume this component and wouldn't need to

track the state (passwordVisible)
register a function to change the state (https://github.com/getAlby/lightning-browser-extension/pull/2597/files#diff-dd145cd63524105648c5b0361bd65880f955aab182d77391c261fba2de4d8c36R175)
themselves.

Do an outer component (a consumer of such a component) ever need to control the visibility of this field?
I couldn't come up with a practical use case where this is needed and was wondering if we could move the handling of switching between text / password into this component so outside APIs could just consume this component and wouldn't need to

track the state (passwordVisible)
register a function to change the state (#2597 (files))
themselves.

I agree! but if we move whole text field into separate component, it would be too complex to pass other fields suchs as placeholder, id, and labels of textfield into separate component. leading to more complexity
current approach probably will be less complex and also allows us to achieve refactoring. now we can simply put a textfield in a seamless way and add a toggle view adornment without considering much details to pass

@reneaaron @pavanjoshi914 one example of having to control the visibility from the outside is the MnemonicInputs component. Actually it would be nice to use this new component there too - if you pass a value to the component, then it should use that. Otherwise it will control the value itself. What do you think?

@pavanjoshi914 I spotted a couple bugs:

icon shows visible when the field is hidden
there should be 3 columns.

Please check the styling on all the usages of the new component and make sure nothing has changed

which browser you are using? i can't reproduce this

@pavanjoshi914 I merged master into your branch. Please pull the latest changes

@pavanjoshi914 I spotted a couple bugs:

icon shows visible when the field is hidden
there should be 3 columns.

Please check the styling on all the usages of the new component and make sure nothing has changed

added feature to allow components to handle viewing the password field itself
2 column bug happened after introducing latest changes. worked on latest master and resolved , thanks @rolznz


Rviz2 keeps giving message filter dropping message for reason unknown

I use data coming from the SVL simulator but when I try visualizing in Rviz I keep getting the error above. I can confirm the data is actually being published and the frames it mentions exists either via robot_state_publisher or robot_localization. Not sure what's raising the issue here

Here is my TF tree for reference

I'm also having similar issue
[INFO] [1619443369.515854324] [rviz]: Message Filter dropping message: frame 'imu_link' at time<PHONE_NUMBER>.495 for reason 'Unknown'
[INFO] [1619443370.508120856] [rviz]: Message Filter dropping message: frame 'imu_link' at time<PHONE_NUMBER>.495 for reason 'Unknown'
[INFO] [1619443371.531937095] [rviz]: Message Filter dropping message: frame 'imu_link' at time<PHONE_NUMBER>.495 for reason 'Unknown'
[INFO] [1619443372.523825584] [rviz]: Message Filter dropping message: frame 'imu_link' at time<PHONE_NUMBER>.495 for reason 'Unknown'
[INFO] [1619443373.515947827] [rviz]: Message Filter dropping message: frame 'imu_link' at time<PHONE_NUMBER>.495 for reason 'Unknown'
[INFO] [1619443374.507506648] [rviz]: Message Filter dropping message: frame 'imu_link' at time<PHONE_NUMBER>.495 for reason 'Unknown'
[INFO] [1619443375.532200265] [rviz]: Message Filter dropping message: frame 'imu_link' at time<PHONE_NUMBER>.495 for reason 'Unknown'
[INFO] [1619443376.523829462] [rviz]: Message Filter dropping message: frame 'imu_link' at time<PHONE_NUMBER>.495 for reason 'Unknown'
[INFO] [1619443377.515699197] [rviz]: Message Filter dropping message: frame 'imu_link' at time<PHONE_NUMBER>.495 for reason 'Unknown'
[INFO] [1619443378.508079858] [rviz]: Message Filter dropping message: frame 'imu_link' at time<PHONE_NUMBER>.495 for reason 'Unknown'

Using ROS2. Code:
        mag_msg = MagneticField()
        mag_msg.header.stamp = self.get_clock().now().to_msg()
        mag_msg.header.frame_id = self.frame_id

        mag = [float(d - 65536 if d > 32767 else d) for d in \
            [(data[0x06] << 8) + data[0x07], (data[0x08] << 8) + data[0x09], (data[0x0a] << 8) + data[0x0b]]
        ]

        mag_msg.magnetic_field.x = mag[0]
        mag_msg.magnetic_field.y = mag[1]
        mag_msg.magnetic_field.z = mag[2]

        self.mag_publisher.publish(mag_msg)

Hence, I believe it has nothing to do with rviz2 because the source of message can be found in https://github.com/ros2/geometry2/blob/bd125c5af32e2c63c70b7e0ba88e57094714b9b8/tf2_ros/include/tf2_ros/message_filter.h

It would seem so. I can confirm rviz2 is working on another simulation

@sisaha9 have you solved the problem? I'm having the same problem with SVL simulator too and it's exactly the lidar that is causing the issue

In my case it was simulator lag. Is your machine able to run it frequently enough?

@sisaha9 I think so. My laptop has a ryzen 7 CPU and RTX2060 mobile. Isn't that enough?


idType Key doesn't work in Config/fluent.json

{
    "idType": "uuid"
}

Not working on Config/fluent.json, but if I set in the model or  for drop.database.idType it works fine.
http://beta.docs.vapor.codes/fluent/model/#id-type

This should be fixed now. Let me know if you still experience the problem.


rename event full on search page

@mykiwi no style changes after all? I saw the request for review, but I don't see it anymore 😄

@marineb Yes, my branch was not update (#628 was missing) 😄


KAFKA-6534: Enforce a rebalance in the next poll call when encounter task migration

The fix is in two folds:

For tasks that's closed in closeZombieTask, their corresponding partitions are still in runningByPartition so those closed tasks may still be returned in activeTasks and standbyTasks. Adding guards on the returned tasks and if they are closed notify the thread to trigger rebalance immediately.

When triggering a rebalance, un-subscribe and re-subscribe immediately to make sure we are not dependent on the background heartbeat thread timing.

Some minor changes on log4j. More specifically, I moved the log entry of closeZombieTask to its callers with more context information and the action going to take.

I can re-produce the issue with EosIntegrationTest may hand-code the heartbeat thread to GC, and confirmed this patch fixed the issue. Unfortunately this test cannot be added to AK since currently we do not have ways to manipulate the heartbeat thread in unit tests.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks, @guozhangwang overall the change LGTM.
But I don't fully get the unsubscribe followed immediately by a subscribe call and how it relates to the background heartbeat thread, can you explain a little?

But I don't fully get the unsubscribe followed immediately by a subscribe call and how it relates to the background heartbeat thread, can you explain a little?

Whenever subscribe is called, the consumer will always try to send a join group request in the next poll call, which is exactly what we are trying to do. Before this patch, there is a corner case that although a rebalance has happened and the streams client was notified of it from its producer, its consumer is still un-aware of the rebalance if the heartbeat thread does not receive the response in time. By un-subscribe / re-subscribe, we are forcing the consumer to always re-join because we, as the streams client, already knows that a rebalance has happened.


Add specific product landing page

i want to create a sneakers landing page with great UI and functionality

the issue has been assigned to you. If possible add a link to the github-pages.


Bluetooth: controller: llcp: Fix terminate timer

Add the missing terminate timer for the ACL Termination procedure.
Signed-off-by: Thomas Ebert Hansen<EMAIL_ADDRESS>

Has not yet been tested on EBQ/Harmony.


chore: promote test2 to version 0.0.3

chore: promote test2 to version 0.0.3
this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign q1323829945
You can assign the PR to them by writing /assign @q1323829945 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@q1323829945: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
5e3736a3f8992409a133c1504e113727075d9955
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.