not clearing heap memory - threads allocated and not releasing netty latest version

Expected behavior
Heap memory should clear after processing messages
Actual behavior
Keep piling up memory not releasing my threads still serving for network messages for checking connections.
Steps to reproduce
keep checking network connectivity and processing messages.

Minimal yet complete reproducer code (or URL to code)
server :
ServerBootstrap bootstrap = new ServerBootstrap();
bootstrap.group(bossGroup, workerGroup)
.channel(NioServerSocketChannel.class)
.childHandler(new ChannelInitializer() {
@Override
public void initChannel(SocketChannel ch)
throws Exception {
ch.pipeline().addLast("decoder", new Decoder())
.addLast("encoder", new Encoder())
.addLast(group, new Handler());
                    }
                }).option(ChannelOption.SO_BACKLOG, 1024)
                .childOption(ChannelOption.TCP_NODELAY, true)
                .childOption(ChannelOption.SO_KEEPALIVE, true);

List ports = Arrays.asList(8080,8081);
channels = new ArrayList<>(ports.size());
for (int port : ports) {
Channel serverChannel = bootstrap.bind(port).sync().channel();
channels.add(serverChannel);
}
decoder :
public class Decoder extends ByteToMessageDecoder {
@Override
protected void decode(ChannelHandlerContext ctx, ByteBuf byteBuf, List<Object> out) throws Exception {

---- business logic to read --
add object to out.
out.add(msg);
}
}
handler :
public class Handler extends ChannelInboundHandlerAdapter {
@Override
public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
--business logic--
ctx.writeAndFlush(msg);
}
}
Encoder :
public class Encoder extends MessageToByteEncoder {
@Override
protected void encode(ChannelHandlerContext ctx, Object msg, ByteBuf out) {
--business logic --
out.writeBytes(msg.getBytes());
}
}
Netty version
4.1.45.Final
JVM version (e.g. java -version)
Adopt OpenJDK 11
OS version (e.g. uname -a)
Linux

@praveens4all Hi by default Netty uses the PooledByteBufAllocator which can cache an allocated buffer to reusing.

@praveens4all Hi by default Netty uses the PooledByteBufAllocator which can cache an allocated buffer to reusing.

Okay, Thank you for response, In my application i wont reuse any messages, processing messages were huge and making out of memory because Old Generation GC filled up my entire RAM. Is there any way to clear or use another buffer ? Pls advise.

You can try UnpooledByteBufAllocator
ServerBootstrap serverBootstrap = new ServerBootstrap();
serverBootstrap
   .childOption(ChannelOption.ALLOCATOR, UnpooledByteBufAllocator.DEFAULT);
...

See if it is suitable for your case, since now Netty will not be able to reuse buffers and will allocate them every time, which can lead to frequent GC.

Also alternative you can configure the PooledByteBufAllocator to only pool direct memory

Also alternative you can configure the PooledByteBufAllocator to only pool direct memory

Sorry for late reply.....Please provide me example how to do that, i did not configure any explicitly.
Still my GC filledup..

e.g. via system properties -Dio.netty.allocator.numHeapArenas=0

Thank you for reply @amizurov
I have tried,
.childOption(ChannelOption.ALLOCATOR, UnpooledByteBufAllocator.DEFAULT); still no change in memory.
as i explained, my requirement server and client runs 24/7 never disconnects keep processing messages.
if i use system property -Dio.netty.allocator.numHeapArenas=0 then can i revert UnpooledByteBufAllocator changes ? still need to use UnpooledByteBufAllocator? please advise.

No, you can remove ‘UnpooledByteBufAllocator’ and use default pooled allocator with disabled heap arena, like @normanmaurer suggested.

okay, Thank you, will try and update you tomorrow.

No, you can remove ‘UnpooledByteBufAllocator’ and use default pooled allocator with disabled heap arena, like @normanmaurer suggested.

Still no changes in memory, i have added vm argument.
how can i verify properties reflected or not ?
i debug my ByteToMessageDecoder , SimpleChannelInboundHandler, MessageToByteEncoder ..seems releasing buffer code not triggering, because my connection still active.

What is this tool?

What is this tool?

dynatrace

Has the problem been solved?

No still we facing outofmemory - due to old generation space filled up with netty buffer i think..not clearing buffer.

I think you will need to share more code and also ensure there are no buffer leaks detected.


Adding informations on how to build only the sonar plugin

Signed-off-by: Benoit Mortier<EMAIL_ADDRESS>

Thanks a lot for the (first!) PR of this project. Unfortunately I was one minute faster...


Update on chmod for the script

Signed-off-by: Vishwas SP<EMAIL_ADDRESS>

@weichou1229 please help review this PR

Without the sudo I am not able to identify the robot

Is it possible to make the caller of updateme.sh to use sudo?  Then sudo could apply to the internal commands.

I have updated the script by removing the sudo from it


WIP: dependencies.yaml example

Tested. Doesn't seem to work any different from the inline
requirements in the CSV.

This doesn't work yet. Just an example of how we might wire in dependencies.yaml if we decide to go that route

@abays Going to update this to try with   - type: olm.gvk


Revert lock order from #708.

This reverts the lock order in #708 and reduces the granularity of the locks (taken from Blackcoin). As a result, RPC, and probably the UI, will not freeze up during syncing. I tested this on the daemon by syncing from 0 without any issues.
To test:

Syncing from 0 in the Qt wallet
Additional syncs from 0 in the daemon
Interacting with the UI during syncing

This plus my future rpc changes will be improvements since scopes of locks in rpc will be reduced as well and should improve for exchanges using rpc calls.


Fightingsystem

Animation System
-- already finished

Each item has a rightclick anim.

Melee Weapons

Have attack anims
Hit on trigger
beams .... projectiles... are added in the future


[regression-test] add p0/p1 case about partition table

Proposed changes
add partition table case:

different column types as partition key (p0)
create partition table error msg (p0)
add/drop partition (p1)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


JSON API Compliance

The List

If you'd like to tackle one of these, please create a discreet issue and add the issue # to the end of the list.

[x] POST/PUT responses do not pass through the jsonapi formatter, and thus do not have a links object (may break existing apps, will need to be a versioned changed to our internal api).
[ ] POST/DELETE do not support collections (bulk extension)
[ ] support for PATCH (patch extension)
[x] to-one foreign keys are not removed from response bodies (this is easy, but it will break existing apps, will need to be a versioned change to our internal api)
[x] support for sort
[x] support for fields
[x] support for POST/PUT using links object to populate relations
[ ] support for /resource/:id/links/:relation both read and write (in progress on my end)
[x] The primary data MUST appear under a top-level key named "data".

this issue is useless. see our test suite for work that remains.


fcitx-qt5: fix build with Qt 5.11

Motivation for this change
See https://github.com/fcitx/fcitx-qt5/issues/34
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Changed it accordingly.

Thanks!


detection confidence returned vol2

The detection confidence for each face is returned for MtcnnWrapper, RetinaFaceWrapper, SsdWrapper in addition to the detected face & img_region.
BEFORE: (detected_face, img_region)
AFTER: (detected_face, img_region, confidence)

PR vol2 failed to pass some checks, so i closed it.


Add @file support

JsExport supports @file which is convenient for files with lots of exported classes, to cut down on boilerplate.

Thanks for your report! I was thinking to add a @KustomIgnore to hide some classes / fields, I think it'll become even more required if we want to target file directly.


HMR clientPort option ignored in normal mode

Describe the bug
When using Vite behind a proxy, it would be nice to set the client port. I had it working when using SvelteKit, but I decide Vite alone would be more appropriate for my SPA. Found that the same server.hmr configuration didn't work. It appears that clientPort is only considered if in middleware mode.
Reproduction
import { defineConfig } from "vite";
import svelte from "@sveltejs/vite-plugin-svelte";

export default defineConfig(({ command, mode }) => {
  const isProduction = mode === "production";

  return {
    plugins: [svelte()],
    server: {
      strictPort: true,
      hmr: {
        clientPort: 443,
        port: 5001,
        protocol: "wss",
        path: "/vite",
      },
    },
  };
});

System Info
  System:
    OS: Linux 4.19 Ubuntu 20.04.1 LTS (Focal Fossa)
    CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
    Memory: 10.69 GB / 24.99 GB
    Container: Yes
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.2.0 - ~/.asdf/installs/nodejs/16.2.0/bin/node
    npm: 7.13.0 - ~/.asdf/installs/nodejs/16.2.0/bin/npm
  npmPackages:
    vite: ^2.3.7 => 2.3.7

this is important, without this it's impossible to run vite behind an https proxy,
I had to workaround this by patching client.js:
const socket = new WebSocket(`wss://my-host/myapp`, 'vite-hmr');

Hmmm, for some reason, using server.hmr.port = 443 works for me. I'm using Vite dev server behind an nginx, and autoreloading seems to work. I do not know internals though.
Nginx config:
server {
  listen 443 ssl http2;
  listen [::]:443 ssl http2;
  server_name (...);
  ssl_certificate (...);
  ssl_certificate_key (...);
  proxy_http_version 1.1;
  proxy_set_header Upgrade $http_upgrade;
  proxy_set_header Connection 'upgrade';
  proxy_set_header Host $host;
  proxy_set_header X-Forwarded-Proto $scheme;
  location /admin {
    proxy_pass http://vite_server:3000;
  }
}

Vite config:
export default defineConfig({
  plugins: [vue()],
  base: '/admin/',
  server: {
    host: true,
    port: 3000,
    strictPort: true,
    hmr: {
      port: 443,
    }
  }
})

Also, on my local dev machine Vite dev server throws an error when server.port = 80 (as expected), but it starts without problem when server.hmr.port = 80. Does this mean that it doesn't try to start HMR server on port 80 and just uses this value to pass it to a browser?

Okay, if I understand the code correctly, in standard, non-middleware mode, there is no separate server for HMR created (until you specially create it and specify in server.hmr.server option):
https://github.com/vitejs/vite/blob/24178b05825245b9f36b5a8e4730996184cc7e8e/packages/vite/src/node/server/ws.ts#L26-L38
And here you can see that the server.hmr.port option is taken (see the line after else) and then simply passed to the client side:
https://github.com/vitejs/vite/blob/7db69a3c284d58ebb51f91c5f44da9890d056b19/packages/vite/src/node/plugins/clientInjections.ts#L27-L34
For the middleware mode, server.hmr.port is used to create a real http server on that port. As for the client side, server.hmr.clientPort can be used to override the real server port value.
To summarize
In non-middleware mode the server.hmr.port option can be used for overriding, for middleware mode — server.hmr.port is really used, and server.hmr.clientPort can be used for overriding.
It looks like there can be confusion with such fuzzy usage of options, and some unification would be fine.
@johnnysprinkles @Shinigami92

@Cretezy Great, it works! Thank you!

Thanks for fixing, when I added that I didn't really know what middlewareMode is (actually I guess I still don't), and just got it working for my own use case.


Split update boolean into multiple states, improve timings for mesh, esdf, and map publishing

DEPENDS ON https://github.com/ethz-asl/voxblox/pull/266
Addresses a few major pain-points with how timing for various updates was done.
Previously, the ESDF (if any) would be updated and the updated maps would be sent out when the mesh update would happen. This is horribly unintuitive, and tied everything to the same timer. This was because there was only one "updated" flag for the block.
Now it's changed to a bitset, with 3 bits: mesh, map, and esdf, so that each operation can take place independently.
NEW parameters:

publish_map_every_n_sec -- how often to publish the map
publish_pointclouds_on_update -- whether to publish latest output visualization pointclouds whenever the map is updated (i.e., new pointclouds come in), otherwise will publish with the mesh update.
update_esdf_every_n_sec -- how often to update the ESDF.

Removed parameters:

publish_tsdf_info -- this name made no sense (actually published output pointclouds), replaced completely with publish_pointclouds which was already there.

FYI couldn't use an enum class (we want the OPPOSITE of hard-typed enums here since we use tehm as ints); switched to an enum struct. I think addressed rest of comments.


Is it possible to make hyperlinks in Word, PDF, PPT and Excel clickable?

Except for dynamic PPT, it is not possible to implement click-to-jump in other files(PDF, Word, Excel). In PPT, we consider it unsafe to jump to other links, so we have not implemented this feature.


Use community repo for governance, info, & user/dev help questions

[NOTE: I'm filing this issue in this repo because it's about things that currently happen here.]
In today's call we rediscovered the OAI/community repository.

It has a lot of useful information, but some of it is out of date, and there's significant overlap with things in this repository.
It would be the ideal place to route user / implementor questions that are a huge percentage of the issues and discussions here in the spec repo (@lornajane kind of like our discussion of moving them to the learn repo, but even better because then we can just use learn issues for actual docs changes)
It seems like a better home for our general governance and process work.  Perhaps the Process label can move over there, and we keep Housekeeping here for the day-to-day repo/project specific stuff?  (paging @earth2marsh from our Process vs Housekeeping discussion)

Note that @webron transferred OAI/community#5 over to that repo as a community question, so apparently we already thought about doing that part once.
Proposed workflow for user / implementor questions
Currently we have two places (issues and discussions in this repo) serving three purposes:

open-ended discussions (ideal for discussions, but historically mostly in issues
actionable tasks (ideal for issues, but sometimes end up in discussions where they're even less likely to get a response)
community members asking for help (probably the largest usage of both issues and discussions)

This makes the @OAI/triage work complex because community member questions aren't necessarily related to spec development, but could lead to changes so we tend to keep them open indefinitely.  But it's very hard to extract what changes are needed, if any, from long back-and-forths that are more help-desk-like than spec writing.

When a user question issue or discussion is opened in any repo other than OAI/community, @OAI/triage immediately transfers it to OAI/community, before responding at all
If something in OAI/community turns out to motivate a spec change, open a new issue (if the change is clear) or discussion (if it's a broad topic that needs more discussion) in this repo (or the appropriate SIG repo), and link to the OAI/commuity issue
If something in OAI/community motivates documentation or examples on the Learn site, either open a new issue or move the issue over to OAI/learn.openapis.org
I'd still argue for closing answered questions, but if we want that

We want a new issue for the spec (including SIGs) because it's often very challenging to extract the spec change requirements from Q&A conversations.  For Learn site changes, sometimes you want a summary but sometimes the Q&A really illustrates what needs documenting, so I think we can be more flexible there.
If we do this, we should copy the "needs author response" / "no recent activity" issue automation over.
Overlaps that need to be de-duped or moved

move README.md "Participation" section (link to new location)
move TOB.md
move GOVERNANCE.md
update community SPECIAL_INTEREST_GROUPS.md and remove the one here
maybe move some of DEVELOPMENT.md like "Participation" and "Community Roles"
do we need CODE_OF_CONDUCT.md in each repo?  It is also the only thing in OAI/.github because GitHub looks for certain things there (I have not checked whether they are all in sync)
we could move the weekly meeting issues and workflow over there, but if that Thursday meeting stays focused primarily on OAS I'd probably keep it here.  The community meeting can link to the meeting agendas for various repos/SIGs.

My first question: who handles the questions we move to a repo that nobody is actively using or looking at? I have no problem at all in having userland questions coming in on the spec repo - and at least that repo has some eyes on it. Moving the content to a location that does not have experienced bystanders hanging around could be a miss IMO.
As a future side-effect, it might help to keep community questions on the various versions separate so we direct questions to the correct versioned repo eventually. Because I still see OpenAPI 2.0 questions, and also I think the biggest winners in OpenAPI 4.0 are not the 3.1 users (it's too early to say that though really!) who are already pretty well served. We should be preparing to support two communities over an extended period. Or perhaps I mean provide space for separate community support to occur.

@lornajane Those are all very good points.  Some questions to maybe help work through them:

Are there that many experienced bystanders who actually currently answer questions  who wouldn't get the news of the shift - I feel like most people who reply are on slack and/or go to one of the meetings and would figure it out quickly
If we have user questions in the community repo, not only is it more clearly outside of the versioning scheme, it could also have a custom issue form that requires users to specify the spec version (and maybe sections) that they're asking about.  It would be much easier to manage 2.0 questions in another repo, as they feel very out of place here and are just noise from the spec development perspective
Would it be better to move the 3.x spec development out of this repo, as we have done with Moonwalk, and just let this be the de-facto community repo?
If we can't split one or the other out into a new repository, can we make either issues or discussions about customer support, and the other one about spec work?  It's possible to transfer issues to discussions and vice-versa

I do feel very strongly about the mix of user support and spec work being a problem - it's my number one frustration with the project on a day-to-day basis.  As much as I wish we could approve PRs faster, that's just a normal constraint of volunteer projects - we can't add more hours to the day or pay full-time employees.  But we can do something to separate the work and make it manageable.  We need to be able to see what we're doing, not just a random mix of conversations.  idk, maybe that's just me, but I find the current situation immensely frustrating.

I think the spec work has to happen here, since it's where we keep the spec. I think (especially with discussions and projects in play) we can manage with people bringing everything to this repo, and that there's merit in making everyone welcome here, and then ruthlessly tagging, classifying, and "gardening" what comes in so that spec contributors (and people working on other specific aspects of the project) can find the signal in the noise.

I think various changes and our more active community have made it so this is not as much of a concern for me.  I'm going to close it out and we can revisit the idea if we really need to.  We're now down to 250 open issues (counting this one I'm about to close!), 9 open discussions, and we now have an issue-filing menu that directs questions to Slack and open-ended proposals to discussions.


No tabId when receiving message in background from content-script

Version
^6.0.1
Current Behavior
sender in background onMessage has no tabId and frameId

Expected Behavior
tabId and frameId to be present
Steps To Reproduce
on Chrome. Create onMessage in background script and await sendMessage(destination, data, "background") from content script
Anything else?
No response

now its working, idk why it was null at a time

How was this fixed, I'm still having this issue

turned out its there, just don't log the object itself (it erases these
values afterwards so it shows null in the console)
On Thu, Jun 20, 2024 at 12:07 PM Leo Ukraincik @.***>
wrote:

How was this fixed, I'm still having this issue
—
Reply to this email directly, view it on GitHub
https://github.com/serversideup/webext-bridge/issues/87#issuecomment-2180302894,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSRRWC46NVPXNEEPADGUG3ZIKSUJAVCNFSM6AAAAABHX56O5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGMYDEOBZGQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

I just faced the same issue. I have freeze the sender object via Object.freeze and traced back to the source. @bogomazov maybe it is fine to re-open the issue.
https://github.com/serversideup/webext-bridge/blob/main/src/background.ts#L160-L162
I'm not sure why is it being overriden though. @zikaari maybe you can share some insights?


Should final_process_success for XMM be returning for ObsID+inst?

At the moment it just does this:

Maybe should be telling us about individual instruments as well?

Nah, I think it's fine as is for now


Page-curl animation does not work properly when a page turns backwards

It works well for left to right side(When user reads forward) and loads the correct pages accordingly. But if I turn a page backwards, it's loading the previous page which is ok. Then if I further moves back then it loads a wrong page.
For example : I go through pages until 5, then go back it loads page 4. If I go to another page back it should load page 3. Instead it loads page 6.
I tried with index value in updatePage method as well as mCurrentIndex in CurlView. But still can't figure out how to fix this issue.

@chathura2020  have you got any solution? i have same issue

Wait soon I share solution
On Wed, Jun 6, 2018, 2:53 PM dhruvishah22<EMAIL_ADDRESS>wrote:

@chathura2020 https://github.com/chathura2020 have you got any
solution? i have same issue
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/harism/android-pagecurl/issues/112#issuecomment-395004591,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcWNdF_va1eXLUqUyEUABklTIMyuxQ3rks5t55-VgaJpZM4NTdfr
.


Redis and Grafan: JSONPath not returning JSON object correctly

Summary
After adding Redis as a data source in Grafana I'm trying to query a JSON object. The JSONPath query does not return the data expected.. For instance if I use *.* or .* or $.* the response only contains the first item, rather than what was requested. which is everything. Is this is a bug or does the Redis query for JSON vary from JSONPath?
For context, I'm trying to create a table from a Redis JSON object in Grafana. Thanks for any advice in advance.
Relevant information

Hi @mikhail-vl is this an issue we could collaborate on?

@aengusrooneygrafana Please contact the Redis team @K-Jo.

@aengusrooneygrafana any updates on this pls

Hi @willychrisza - curious if this is related to #283 - are you actually using the JSON data type? or are you are saving strings in redis and pulling out certain paths client side (not certain from the way the issue is phrased) - I've found that it appears that JSON operations (e.g. JSON.GET) only seem to work with clean scalar strings, or objects that will break down somewhat nicely.
Curious what your thoughts are on how a result would look if one of these paths were used. JSON is by its nature schemaless so mapping it into the tabular format that the grafana frames expect is at least somewhat problematic. I've opened a PR to fix the issue with other scalars (booleans and numbers) but will need some more time to consider what this will look like for non-scalars (arrays/complex-nested objects).


Fix data races in pkg/cache

Addresses reported failures of go test -race:
$ go test -race istio.io/istio/mixer/adapter/prometheus
ok      istio.io/istio/mixer/adapter/prometheus 4.862s

$ go test -race istio.io/istio/pkg/cache
ok      istio.io/istio/pkg/cache        22.384s

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
If they are not already assigned, you can assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Inconsistent SPC_BFR_PAR behaviour

Describe the bug
The behaviour of the SPC_BFR_PAR rule is inconsistent.
Erroneous code
#include <stdio.h>

int	main(void)
{
	const char	*s = "01";

	printf("%c\n", s[1]);
	printf("%c\n", "01"[1]);
	printf("%c\n", 1["01"]);
}

Additional infos

python --version: Python 3.8.5
norminette -v: norminette 3.2.5

Additional context
The first call to printf passes the norm while the other two trigger a norm error. While I agree the third case is a little bit unconventional, I see no reason for the second case to be considered an error.

Closed in 518fdda06eae6e748129f334b8925cdc1add8fcd


Playing videos in LinearLayout won't work, but it works on a GridLayout

Testing on a Samsung Galaxy S6 Edge+, Toro version 3.1.1 and Android 7.0
Videos won't play in a recyclerview with LinearLayout. When it gets to that position on the list, bind is executed but it won't initialize inside the viewholder. It works normally when using GridLayout with the same adapter and list. I really don't know what to do to make it work. Is it possible that it won't play if there's some other view apparently blocking it's way? I'm using the SimpleExoPlayerView from the example.
Among other things, this is inside my onBindViewHolder:
viewHolder.bind(Uri.parse("https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8"));
And this is some of my ViewHolder:
   public class ViewHolder extends RecyclerView.ViewHolder implements ToroPlayer {

    //Some other views

    private SimpleExoPlayerView playerView;

    public ViewHolder(View itemView) {
        super(itemView);
        //Other views initialized as well
        playerView = itemView.findViewById(R.id.player_view);
    }

    @Nullable
    SimpleExoPlayerViewHelper helper;

    @Nullable
    private Uri mediaUri;

    void bind(Uri item) {
        if (item != null) {
            mediaUri = item;
        }
    }

    @NonNull
    @Override
    public View getPlayerView() {
        return playerView;
    }

    @NonNull
    @Override
    public PlaybackInfo getCurrentPlaybackInfo() {
        return helper != null ? helper.getLatestPlaybackInfo() : new PlaybackInfo();
    }

    @Override
    public void initialize(@NonNull Container container, @Nullable PlaybackInfo playbackInfo) {
        if (helper == null) {
            helper = new SimpleExoPlayerViewHelper(container, this, mediaUri);
        }
        helper.initialize(playbackInfo);
    }

    @Override
    public void release() {
        if (helper != null) {
            helper.release();
            helper = null;
        }
    }

    @Override
    public void play() {
        if (helper != null) helper.play();
    }

    @Override
    public void pause() {
        if (helper != null) helper.pause();
    }

    @Override
    public boolean isPlaying() {
        return helper != null && helper.isPlaying();
    }

    @Override
    public boolean wantsToPlay() {
        return ToroUtil.visibleAreaOffset(this, itemView.getParent()) >= 0.85;
    }

    @Override
    public int getPlayerOrder() {
        return getAdapterPosition();
    }

    @Override
    public void onContainerScrollStateChange(Container container, int newState) {

    }

Apparently it's something with both of the .xml files that I used in each Layout, Linear and Grid.


DCOS-38641 stop action

SCOPE

Extract the JobStopAction into the mediator pattern
Minor changes to existing JobStopModal component

HOW TO TEST
Scenario 1: A job
Go to the Job History page, run a job, and then selected it on the list (via the checkbox), a Stop button appears, you can stop the job there.
WHAT WAS TAKEN OUT OF SCOPE

Not using graphql yet.

@nLight I addressed the comments regarding the new code I wrote.

looks like #3043 is overhauling most of this code anyway, so to prevent rebase-hell I'd say it is good enough if you add the types (and maybe change the ternary) in #3043 - no need to fix it here. what about you @nLight?

I would prefer actually fixing that here, and leave to fix graphql stuff on #3043.

@Fabs @juliangieseke is the "changes requested" up to date? I am unsure if this is ready again for review or not 🙈

@DanielMSchmidt, I will ping you when its done, should be a couple more minutes.

@Fabs Just move the ticket back into "In Review" ;)

@DanielMSchmidt , @nLight  and @juliangieseke. That is ready for review again.


Fix persistence issues for pacing feature

GitHub Issue (if applicable): #3295
Trello Link (if applicable):
Explanation of Bugfix/Feature/Modification:
Apologies for my overlook in previous PR! This one fixes persistence issues with pacing feature

(Changes to tests not related to this PR, but I missed them in one of previous PRs)


Another encoding bug

When I reload my server/plugin, the .yml is corrupted

My Intellij IDE is in UTF-8:

My pom.xml have UTF-8 encodage configuration:

How to reproduce (in my case):

I add the defaults value from a HashMap:

The first load the correct encodage, but nexts (re)load corrupt the file
I can't use special character :/

Hey,
thanks for reporting this, currently we are working this out in our support discord.
Regards,

Leonhard

Should be resolved, please tell if otherwise.

Hi! is this fixed? I can't read special characters with Yaml.get(key, def) method

Yes, it should be fixed. Are you using SimplixStorage on Bukkit?
If so please use:
-Dfile.encoding=UTF-8 in your run.bat / run.sh file.
If this does not work we are more than happy to help you.
Regards,
Leonhard


Bug: Stream behaviour on connection lost and reconnect

Describe the bug
With the update to 1.2.3 , losing the connection doesn't trigger any error anymore. Also reconnecting to the internet doesn't change/trigger anything.
My current code (with v1.2.2)
import 'dart:async';
import 'package:flutter/material.dart';
import 'package:supabase_flutter/supabase_flutter.dart';

class RealtimeGameService extends ChangeNotifier {
  RealtimeGameService({
    required this.client,
    required this.primaryKey,
    required this.tableName,
  }) {
    _init();
  }

  final SupabaseClient client;
  final String tableName;
  final List<String> primaryKey;

  List<Map<String, dynamic>> data = [];
  DateTime lastUpdateTime = DateTime.now();
  bool isConnected = false;
  bool isInitialLoading = true;

  StreamSubscription<List<Map<String, dynamic>>>? _streamSubscription;

  void _init() {
    _streamSubscription?.cancel(); // Cancel any existing subscription
    final liveDataStream =
        client.from(tableName).stream(primaryKey: primaryKey);

    _streamSubscription = liveDataStream.listen(
      (List<Map<String, dynamic>> newData) {
        print('works');
        print('Received data: $newData');
        _updateData(newData, true);
        if (isInitialLoading) {
          isInitialLoading = false; // Mark initial loading as complete
          notifyListeners();
        }
      },
      onError: (e) {
        print('Error during realtime subscription: $e');
        _updateData(data, false);
        if (isInitialLoading) {
          isInitialLoading = false; // Mark initial loading as complete
          notifyListeners();
        }
      },
      onDone: () {
        print('Realtime subscription done');
      },
    );
  }

  void _updateData(List<Map<String, dynamic>> newData, bool newIsConnected) {
    data = newData;
    lastUpdateTime = newIsConnected ? DateTime.now() : lastUpdateTime;
    isConnected = newIsConnected;
    notifyListeners();
  }

  void reload() {
    _init();
    isInitialLoading = true;
    notifyListeners();
  }

  @override
  void dispose() {
    _streamSubscription?.cancel();
    super.dispose();
  }
}

Expected behavior

At least one single error should be thrown that the websocket lost connection
It would be nice if the websocket reconnects it triggers the onData again

Version (please complete the following information):
????????? realtime_client 1.2.2
????????? supabase_flutter 1.10.18
???   ????????? supabase 1.11.5
???   ???   ????????? functions_client 1.3.2
???   ???   ????????? gotrue 1.12.4
???   ???   ????????? postgrest 1.5.1
???   ???   ????????? realtime_client...
???   ???   ????????? storage_client 1.5.3

Thanks for opening this @coolusaHD
I'm assuming the reason why you want to receive error within onError when listening to stream is to restart the stream when the connection is lost, correct? We are working on making the .stream() method more reliable so that it will self-reconnect if the realtime connection gets lost for any reason. If this is implemented, would you say there is no need to have an API to detect if the stream lost its connection?

@dshukertjr
In my implementation I use the onError for notifiy the user that he no longer recieves the latest data. To reconnect the user itself have to press a button to retry/ reinit the stream subscription.
Therefore it would be nice if the stream would automatically reconnect and recall the onData callback but it would be also nice (and essential for me) that at least the onError gets triggered once when the stream lost the connection.
Thanks for asking🙌

@dshukertjr Any ideas when the work on making the ".steam() method more reliable" is going to be finished? Or available for a first testing?

Any updates on this ? ✌ @dshukertjr

Thanks for opening this @coolusaHD
I'm assuming the reason why you want to receive error within onError when listening to stream is to restart the stream when the connection is lost, correct? We are working on making the .stream() method more reliable so that it will self-reconnect if the realtime connection gets lost for any reason. If this is implemented, would you say there is no need to have an API to detect if the stream lost its connection?

Is there an ETA on this? Stream is so buggy right now it is really difficult to trust it.

@dshukertjr
I had some freetime and testet a bit. The change of the _onConnError function also prevents that the onError function of the stream gets the error.
But thats not the only problem. If the connection fails the heartbeat should also fail and close the stream after 2 missed heartbeats. But that doesn't trigger anything.
So from my perspective I see why the flooding of errors should be prevented but without any error how can I know if my stream is still connected to the source?
I really like to update to the latest version but my app cant live without that 😅
Is there any change to make the error flooding optional or even fix it that it returns at least one error?
Thanks in advance. ✌

Hope quick solve this issue. I also lost connect and do not receive error from stream.onError callback. It it difficult to fix it for the app developer.

I just built a ton on top of realtime SQL updates, assuming it would be easy to add in some reconnect logic once I got around to it... and this... seems like a pretty fundamental thing to prioritize
Has anyone figured out any workarounds?

Hi @dshukertjr, is there any update on the fix?
My issue is the connection gets lost when the app is in the background for a while. When the app becomes active again, it doesn't seem to automatically reconnect and thus only display the stale data which were received before the connection was lost.
I tried to work around this issue by listening to the app lifecycle change to manually reconnect. However, I am concerned of this approach because there's no way to manually close the stream right now (or at least I couldn't find a way to do it). This means that there could be multiple stream open simultaneously which may lead to memory leak.
Given that most of apps inherently will go to background for a long period of time, this seems to be a serious issue because app will only display stale data. In my case, I am sending a push notification whenever there's new chat message but when clicking on it to land on the chatroom, the latest message often is not present.

@themightychris

Has anyone figured out any workarounds?

Not directly. I looked a bit into the realtime client and if I understood it correctly the stream function uses a channel on its own and listen to all Postgres changes and save the updated data in the state which you can access in the stream.listen() function.
So a workaround would be to implement that on your own. But obviouslyadd a flag for getting the right error messages would be more than helpful

Will #1019 address this?

Will #1019 address this?

It looks like better error handling. If this will trigger the onError callback function in the
stream.listen() functionwould be nice and propably fix the error

With modified pubspec.yaml
  realtime_client: ^2.2.1
  supabase_flutter: ^2.6.0
  supabase: ^2.3.0

dependency_overrides:
  supabase_flutter:
    git:
      url: https://github.com/supabase/supabase-flutter/
      ref: fix/realtime
      path: ./packages/supabase_flutter
  realtime_client:
    git:
      url: https://github.com/supabase/supabase-flutter
      ref: fix/realtime
      path: ./packages/realtime_client
  supabase:
    git:
      url: https://github.com/supabase/supabase-flutter
      ref: fix/realtime
      path: ./packages/supabase

After I dissconnected the internet on the device the stream takes about 40s to check and then throws an error so my app can show that it is no longer connected to the internet.
After reconnecting it instantly works again like before.
See #1019

@Vinzent03 @dshukertjr I'm gonna close this isse when #1019 gets merged ✌ 🚀

With #1019 being merged now, these issues should be solved now. You can try them by upgrading supabase_flutter to 2.7.0. If you still experience any issues, please create a new issue.


xds send waiting for ack

xds send should wait for ack from envoy.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-dashboard.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-dashboard.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-dashboard.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-dashboard.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-simple

prow/istio-unit-tests.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-dashboard.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-simple

prow/istio-unit-tests.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-dashboard.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-simple

prow/istio-unit-tests.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-simple

prow/istio-unit-tests.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-simple

prow/istio-unit-tests.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
67bfa0e7f33b8c2ed059fc4d4552156c20c7ef13
link
/test e2e-simple

prow/istio-unit-tests.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
1004f62d11b81b3509d8201755234a8545af29ca
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

seems this is a server<--->client behavior, so many clients do not send ack. It can not be done like this until all clients send ACK/NACK.


refactor(ES6): Compiler-caching.test.js

What kind of change does this PR introduce?
refactor, ES5 => ES6

Did you add tests for your changes?
All existing tests pass

If relevant, link to documentation update:
N/A

Summary
Refactor Compiler-caching.test.js to ES6

Does this PR introduce a breaking change?
No

Thanks


NameError: name 'model' is not defined

Hi, I tried your Flask script and received the following error: "NameError: name 'model' is not defined".
It origins probably from this line:
model = torch.hub.load(
        "ultralytics/yolov5", "yolov5s", pretrained=True, force_reload=True, autoshape=True
    )  # force_reload = recache latest code

I was wondering if I can find the model thay you are using somewhere in your repo or is it at Ultralytics?
Thank you very much in advance!

This should load the default model from torch_hub, perhaps the api changed?

Thank you for your help!
I have run the same line of code in a Kaggle notebook and there it is doing well:
Downloading: "https://github.com/ultralytics/yolov5/archive/master.zip" to /root/.cache/torch/hub/master.zip
YOLOv5 🚀 v6.1-25-gcaf7ad0 torch 1.9.1+cpu CPU

Fusing layers...
Model Summary: 213 layers, 7225885 parameters, 0 gradients, 16.5 GFLOPs
Adding AutoShape...

I have checked the packages in requirements.txt but everything seems fine. Any suggestions would be welcome!

Maybe it cannot access the internet somehow? Workaround would be to cache the model whilst building the container

Hi, I tried your Flask script and received the following error: "NameError: name 'model' is not defined". It origins probably from this line:
model = torch.hub.load(
        "ultralytics/yolov5", "yolov5s", pretrained=True, force_reload=True, autoshape=True
    )  # force_reload = recache latest code

I was wondering if I can find the model thay you are using somewhere in your repo or is it at Ultralytics? Thank you very much in advance!

I'm facing the same problem but the solution mentioned above didn't quite work for me. Is there any other way to get past this problem?

Maybe try with just the args shown in https://pytorch.org/hub/ultralytics_yolov5/


No such module 'NVActivityIndicatorViewExtended'

Hi,
After I updated the library I got this error No such module 'NVActivityIndicatorViewExtended'
Thank you

Install pod 'NVActivityIndicatorView/Extended'

still not working

@kristoff2016 Have you tried cleaning Cocoapods setup? I tried with a fresh project, and it works well.

I tried to close the project and clean build everything is still not working @ninjaprox

@kristoff2016 How about just import NVActivityIndicatorView?


FUSE-DOC-1249 include dependency for Apache Karaf

Hi - I'm contributing a fix to the ASCII-doc documentation. Can you please review it?

Thanks

Thank you!


LspInstall tsserver fails

I am having issues installing the LSP for tsserver using the :LspInstall tsserver command.
npm WARN saveError ENOENT: no such file or directory, open '/../.cache/nvim/nvim_lsp/tsserver/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/../.cache/nvim/nvim_lsp/tsserver/package.json'
npm WARN tsserver No repository field.
npm WARN tsserver No README data
npm WARN tsserver No license field.

The folder exists but only has the lock file.
nvim/nvim_lsp/tsserver
> ls
node_modules      package-lock.json

NVIM v0.5.0-013436c99

I am not sure how to check the version of nvim-lsp, but I use plug and it says that it is up to date. LMK if I can provide additional debug info!

Okay so running :LspInstall tsserver again results in it telling me that tsserver is already installed? So I guess that the error doesn't indicate a total failure... I will close the issue.

Yeah that just looks like NPM noise.


Fixing issue (Invalid US-ASCII character xE2) for docker image

Fix for the issue https://github.com/aspirethemes/type/issues/3
Changed all characters to the UTF-8

Thank you!


How to import / export excel file (.xlsx)?

You may refer to https://docs.sheetjs.com/docs/demos/grid/xs @Bayramooov

@akhil-gautam that is for x-spreadsheet. And the Table interface has no loadData method. @Bayramooov you will have to take the value from stox and convert it to an array of type IndexDataCell[]. Then call .data({cells: rowColCells}).render()

@dsills22 Yes sir, I just provided a reference.

Is there any reference documentation? link provided by @akhil-gautam is not useful since that link references a different library which has different structure for input data. (I know wolf-table uses a lot of code from x-data-spreadsheet but they have different structures)


The showcase doesn't start locally when running yarn start

Describe the bug
When using yarn start in the root directory to start the backstage application, the frontend fails with the following error:

When testing doing yarn start from commit https://github.com/janus-idp/backstage-showcase/commit/4a6266e16f2548071b740e9f8d3bc4b6fd08b234 (before the 1.22 upgrade)
The logs produce the following and backstage starts up properly:
backend:start: cache bypass, force executing f3913656802e2f5f
@internal/plugin-dynamic-plugins-info-backend:start: cache bypass, force executing fd38329a4c7ee316
@internal/plugin-scalprum-backend:start: cache bypass, force executing 87683b206ad30f9b
app:start: cache bypass, force executing 6c746a5d57ae5faf
backend:start: $ cross-env LEGACY_BACKEND_START=true backstage-cli package start
@internal/plugin-scalprum-backend:start: $ backstage-cli package start
@internal/plugin-dynamic-plugins-info-backend:start: $ backstage-cli package start
app:start: $ janus-cli package start
@internal/plugin-scalprum-backend:start: (node:211262) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
@internal/plugin-scalprum-backend:start: (Use `node --trace-warnings ...` to show where the warning was created)
@internal/plugin-dynamic-plugins-info-backend:start: (node:211263) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
@internal/plugin-dynamic-plugins-info-backend:start: (Use `node --trace-warnings ...` to show where the warning was created)
backend:start: Build succeeded

The logs start returning the following when switching to the backstage 1.22.1 commit https://github.com/janus-idp/backstage-showcase/commit/8f9811cc303b40fbb98ab9f064b04bac63674b22, but the showcase still starts properly.
app:start: cache bypass, force executing f6333405e07da288
@internal/plugin-dynamic-plugins-info-backend:start: cache bypass, force executing 94c6b8fd02e56c01
@internal/plugin-scalprum-backend:start: cache bypass, force executing 6d2932d82f85349e
backend:start: cache bypass, force executing 243cea59deea3070
@internal/plugin-dynamic-plugins-info-backend:start: $ backstage-cli package start
backend:start: $ cross-env LEGACY_BACKEND_START=true backstage-cli package start
app:start: $ janus-cli package start
@internal/plugin-scalprum-backend:start: $ backstage-cli package start
@internal/plugin-dynamic-plugins-info-backend:start: The 'dev' directory is missing. Please create a proper dev/index.ts in order to start the plugin.
@internal/plugin-scalprum-backend:start: The 'dev' directory is missing. Please create a proper dev/index.ts in order to start the plugin.
backend:start: Build succeeded

The last commit that still worked was https://github.com/janus-idp/backstage-showcase/commit/6b8b82c0dedb1b1745916d301b5151dd54680cbb.
The issue starts occurring at commit https://github.com/janus-idp/backstage-showcase/commit/ebebc0acef5e0362c9001271c0e6df38370a2d23 from "chore(deps): update all non-major dependencies (https://github.com/janus-idp/backstage-showcase/pull/693)"
Expected Behavior
The backstage showcase starts up properly when running yarn start
What are the steps to reproduce this bug?

Checkout to https://github.com/janus-idp/backstage-showcase/commit/ebebc0acef5e0362c9001271c0e6df38370a2d23 or later
run yarn start
Observe frontend failing with Error Scalprum was not initialized! Call the initialize function first.

Versions of software used and environment
https://github.com/janus-idp/backstage-showcase/tree/4f1c1b60489450647b8102083c3ae55d2cb05049
node v18.18.0 (also tested with node v18.19.0 and issue persists)
yarn v1.22.19

It seems to work after doing a git revert ebebc0acef5e0362c9001271c0e6df38370a2d23 to revert https://github.com/janus-idp/backstage-showcase/commit/ebebc0acef5e0362c9001271c0e6df38370a2d23

A function we used was actually deprecated and removed in v0.7.0 of @scalprum/core
https://github.com/scalprum/scaffolding/pull/114/files#diff-16951a076f27175290484178ab8a33bbdf697b9ac96cac8390134042b4789dd2L34-L36

Fixed by https://github.com/janus-idp/backstage-showcase/pull/915.
Next steps is to potentially see if we can update the DynamicRoot to use the new transformPluginManifest function instead of the postProcessManifest


Add pagination for Trending movies, shows and search

[ ] Trending movies
[ ] Trending shows
[ ] Search

Maybe this class can help


[doc] Issue in "Components" - IDP missing

Components:
https://documentation.suse.com/suse-edge/3.0/html/edge/atip-architecture.html#id-components-4
"Comprehensive tenant isolation and IDP (Identity Provider) integrations"
Should IDP be included in the graph above?

The comment describes the option for e.g Rancher to integrate with OIDC/SAML etc - the Edge solution doesn't provide any IDP so I'm not sure we need to add anything to the diagram?

Based on that, nothing needs to be added in the graph.
Maybe re-word the bullets by separating the tenant isolation and IDP integration, or moving the IDP part to the Rancher bullet.


USHIFT-333: route/v1: Fix CRD to allow path for non-TLS routes

Fix the Route CRD validation for allow routes with null spec.tls and nonempty spec.path.

route/v1/route.crd.yaml-patch: Add a case to allow spec.path to be nonempty when spec.tls is null.  The existing case to allow spec.path when spec.tls.termination is not "passthrough" is insufficient when spec.tls is not specified at all.
route/v1/route.crd.yaml: Regenerate.
route/v1/test-route-validation.sh: Add test cases "non-TLS with nonempty path" and "edge-terminated with nonempty path".

We recently had some exploration of defaulting and openapi validation which lead to the realisation the the way Go serialises the JSON plays a big part in the validation.
Have you tried adding omitempty to https://github.com/openshift/api/blob/0ee1471bcabbfefade29abeae5aab53366d0493f/route/v1/types.go#L250 and seeing if that makes a difference?
Or does this end up being a more complicated case because of the existing validation patches that have been added?

We can't/won't change the API.  This matches an existing openshift-apiserver API.  @benluddy is actively working on porting and admission plugin to do defaulting the validation.
/approve

/lgtm


2 vqgan models don't load

Justin,
So many thanks for developing this version of vqgan art generator. I thought I'd send you a note on a persistent problem I'm having. I can't load vqgan models - wikiart_16384 & coco off the collab notebook.
Should I run this off Linux for better reliability?
Thanks again!

Most of the time this has happened (historically, with this notebook) it's because the person hosting these models has changed the URL or taken them offline. I'm looking for a solution on my end which I can use to reupload and host these, since I have backups of each model.

I have the models downloaded as well. I assume I can hack the code to source them. It seems to disconnect from the local versions when I use Google cloud for computing.

CLIP-Guided Diffusion model refusing to download (with GD workspace, didn't check it with temporal workspace).


Location overview

Added ability to see locations for the public. Added ability to create, edit and delete locations for people with locations_crud permission

Alle change requests are rettet. Please review changes.


kots preflight checks do not match helm CLI preflight checks

can we consolidate these?
https://github.com/slackernews/slackernews/blob/main/chart/slackernews/templates/preflights.yaml
https://github.com/slackernews/slackernews/blob/main/kots/preflight.yaml

We should. No need for a distinct KOTS preflight, teaches bad habits

looks like this happened at some point in the last few weeks


npm install failed on windows 7

Hi ! Thanks for maintaining this project, but I got a little error when doing npm install.
245 error Windows_NT 6.1.7601
246 error argv "C:\Program Files\nodejs\\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install" "nodehun" "--save"
247 error node v0.12.7
248 error npm  v2.11.3
249 error code ELIFECYCLE
250 error<EMAIL_ADDRESS>install: node-gyp rebuild
250 error Exit status 1
251 error Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
251 error This is most likely a problem with the nodehun package,
251 error not with npm itself.
251 error Tell the author that this fails on your system:
251 error     node-gyp rebuild
251 error You can get their info via:
251 error     npm owner ls nodehun
251 error There is likely additional logging output above.
252 verbose exit [ 1, true ]
253 verbose unbuild node_modules\nodehun
254 info preuninstall<EMAIL_ADDRESS>255 info uninstall<EMAIL_ADDRESS>256 verbose unbuild rmStuff<EMAIL_ADDRESS>from C:\Users\alice\Downloads\test\node_modules
257 info postuninstall<EMAIL_ADDRESS>258 silly gentlyRm C:\Users\alice\Downloads\test\node_modules\nodehun is being purged from base C:\Users\alice\Downloads\test
259 verbose gentlyRm don't care about contents; nuking C:\Users\alice\Downloads\test\node_modules\nodehun
260 silly vacuum-fs purging C:\Users\alice\Downloads\test\node_modules\nodehun
261 silly vacuum-fs removing C:\Users\alice\Downloads\test\node_modules
262 silly vacuum-fs finished vacuuming up to C:\Users\alice\Downloads\test

Very late answer, but I see a node-gyp error in there, so if that's the root of the problem, then here's the solution:
https://github.com/nodejs/node-gyp/issues/629#issuecomment-153196245
I had the same problem when installing this library on Windows 10.

I am no longer maintaining this project


DOC: Add citation info

Description
Addresses #278
Adds a page to documentation with discussion of citations, including sample bibtex info.
Type of change

This change is a documentation update

How Has This Been Tested?
No changes to code.
Checklist:

[x] Make sure you are merging into the develop (not master) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to CHANGELOG.md, summarizing the changes

Coverage decreased (-0.06%) to 80.885% when pulling dadabe991567d728ea96722ee44f3c1d1feebce0 on doc_how_to_cite into adf868dfdf5acbdc7b817d4b56ce03020c817152 on develop.

There's some strangeness transpiring at coveralls.  The number of files seems to double with each additional run.  Up to 332 for this 83 file project.
https://coveralls.io/github/rstoneback/pysat?branch=doc_how_to_cite

@jklenzing I am not sure I am the right reviewer for this, given that I made a few changes.

OK.  @rstoneback?

Yeah, let’s talk about it.
Didn’t we also talk about adding a .cite() method? Perhaps in Japan? We could have one for pysat and and potentially one defined by each instrument.

Instrument specific citations is mentioned in #180.


BREAKING CHANGE!: sync aerial & navic highlights with treesitter & lsp highlights

Link Aerial and Navic highlights to treesitter and lsp highlights.

Hey!
Thanks for your PR!
Does it breaks compat with neovim 0.8 ? I think I should pass #26 before.

Default semantic token values have been added

fixed

thanks


chore: remove unnecessary directories

ci/build (11) failed. It's bazel that used the tests directory.
/home/runner/.cache/bazel/_bazel_runner/1f815583ebc8da6875b9074f31ba9a5d/external/bazel_tools/tools/build_defs/repo/http.bzl:355:31: in <toplevel>
(21:44:45) INFO: Analyzed 0 targets (1 packages loaded, 0 targets configured).
(21:44:45) INFO: Found 0 test targets...
(21:44:45) INFO: Elapsed time: 6.808s, Critical Path: 0.02s
(21:44:45) INFO: 1 process: 1 internal.
(21:44:45) ERROR: No test targets were found, yet testing was requested
Error: Process completed with exit code 4.

bazel --batch test //:units --noshow_progress --test_output=errors
...
(21:48:08) ERROR: No test targets were found, yet testing was requested

It's better to do one by one.


feat(persistence-ethereum): migrate to separate db schema

Move all database entities relating to ethereum persistence plugin to
a seprate schema. Adjust all the files the test to work as expected after
that change.
Remove sample SQL data from GUI package, one from persistence packages should
be used instead.
Upgrade web3-utils in persistence-ethereum to fix a bug when running the
standalone script.

Depends on #3340
Signed-off-by: Michal Bajer<EMAIL_ADDRESS>Pull Request Requirements

[ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz Done, ready for review :)


A general solution to client / server ECS divergence

While debugging an issue this morning, @FredrikNoren and I realised there's a much bigger issue - the client and the server can disagree on the state of a component/entity, and there is no general way to unify them.
The issue we saw was:

a package attaches model_from_url to a player on the server
model_from_url runs on the client, attaching some children to the player entity
another package runs on the server, adding a head entity as a child to the server children of the player, which synchronises to the client, overriding the children set by model_from_url

There are workarounds for this particular issue, and we'll likely document for them for this immediate release. For this example, we'll move the model to a separate entity so that its children are not interfered with by the server. For Tangent, we'll wait for the model load on the client before attaching the HUD.
However, the general problem extends beyond this. This could happen to any component where the client updates the ECS, and then the server replicates a newer version, replacing the client's version.
There are a couple of solutions to this, each with their own trade-offs:

have three versions of the same component, and then have a system to unify them. For children, this would be server_children, client_children_delta, and authoritative_children, where SC and AC are the same on the server, and AC is SC + CCD on the client.
have an unnetworked canonical component on both sides, and then an invisible networked component whose job it is to provide the "base state". On the server, there's one children component that is canonical and unnetworked, then there's a server_children component that is networked and not visible to the guest that gets synced from children. On the client, children is automatically updated by a system to be a composition of server_children and client_children_delta. Updating children on the client will update CCD for you.
An OverlayFS-like solution where you always have access to the base server world on the client, but the client has an "overlay" on top of the server world that it uses for all rendering/etc. When you update the client world, the change you've made is compared to the server state, and the delta is stored in the overlay, so that it can be reapplied should the server state change. The behaviour of the delta is user-specified and per-component.
a) A variation of this where it's more explicit, and you can create your own overlays and choose what the runtime renders with/operates over.

All of these complicate the data model in different ways, but this is not necessarily avoidable complexity. The problem of the client wanting to make some changes to the state that the server will always exist, whether it's for prediction, animation, client-only entities, or more.
Open questions:

What does it mean to remove something that the server spawned? Both entities and attached components.
Does one delta behaviour for each component cover all use cases? For translation, you might want the client to override the position at all times, but you may also want it to be applied as a delta to the server position.
How will this work when there are multiple packages interacting with the same component?

We've fixed the children/parent case by making the parent the authoritative source, and deriving children from all entities that have the entity as a parent. This solves that particular issue, but we're not sure if we can generalise that.


hreflang meta tag is wrong

On all sites the hreflang tags are always like this:
`

`
It does not generate paths for subpages. Also it does not add the trailing slash which is problematic for SEO.
In that context it also would be great to have the possibility to disable the meta tag generation, because we also use gatsby-plugin-next-seo for seo context, so the meta tags are doubled.

Hi @DDaehn
I think something is off with your configuration or how you use the plugin.
There are automatic tests covering the generation of meta tags here: https://github.com/openscript-ch/gatsby-plugin-i18n-l10n/blob/main/src/onRenderBody.test.tsx#L54
For the trailing slash issue, I've created a PR here https://github.com/openscript-ch/gatsby-plugin-i18n-l10n/pull/187. Please try it out and tell me if it works for you.


Added  my school, I.I.S. "Galilei-Vetrone"

I attend an IT course at this school. The website is iisgalileivetrone.edu.it

@nick747 lib/domains/it/iisgalileivetrone.edu.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@philipto I requested yesterday with the name iisgalileivetrone.it but got refused because iisgalileivetrone.it doesn't exist, and I know that. I retried adding ".edu" which is in my school website but obviously you can't accept it.
I will try again without ".edu", the school website is iisgalileivetrone.edu.it .
Thanks

@philipto renamed. Check if this works. The school website is this

found error in the path, I've moved my file in it/edu because of .edu . It should all be good now

@nick747 First stage of verification passed, official domain is iisgalileivetrone.edu.it as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@nick747 Pull request merged. Thank you.


Added the output instance_class

what
 Added the output instance_class
why
Needed for monitoring reasons. Enables you to set the threshold of the CloudWatch alarm for FreeableMemory to a percentage value instead of Bytes. Because if you know the instance type, you know the RAM of it and you can set the threshold of the alarm to for example 70% of that. Unfortunately there is no data ressource to get the instance_class from otherwise (it gives just general information about available instance_classes)
references

Data Ressource: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/docdb_orderable_db_instance#:~:text=X-Ray-,Data Source,-%3A aws_docdb_orderable_db_instance
Freeable Memory: https://docs.aws.amazon.com/documentdb/latest/developerguide/cloud_watch.html#cloud_watch-metrics_list:~:text=one-minute period.-,FreeableMemory,-The amount of
Instance_classes:  https://docs.aws.amazon.com/documentdb/latest/developerguide/db-instance-classes.html#db-instance-class-specs

@Faris96Hub if we have input instance_class, why do you need the output?
That's the same value.


Create free-programming-books-bl.md

Thanks! would you like to add a link from README?

yes i just did


Add new songs

Please help to add these songs. Thank you!
Way Maker - https://www.youtube.com/watch?v=VyQHIVrHweM
God You're so good - https://www.youtube.com/watch?v=u5yfkNAxMT4
Living hope - https://www.youtube.com/watch?v=u-1fwZtKJSM
Spirit of the living God - https://www.youtube.com/watch?v=ZPZrxZgQjrg
Way Maker.txt
God You're so Good.txt
Living hope.txt
Spirit of the living God.txt

Hi @Ctasds , thank you very much.
We will add these songs as soon as possible.

 God You are so good (Author Unknown {ஆசிரியர் தெரியவில்லை}).zip
Jesus Christ, my living hope (Phil  Wickham).zip
Spirit of the living God (Author Unknown {ஆசிரியர் தெரியவில்லை}).zip

Hi @Ctasds, we have added the songs.
Please use "Update songs" feature in the app to get these songs.

Thank you 😊
On Thu, 10 Oct 2019, 9:25 am James Selvakumar<EMAIL_ADDRESS>wrote:

Hi @Ctasds https://github.com/Ctasds, we have added the songs.
Please use "Update songs" feature in the app to get these songs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mcruncher/worshipsongs-db-dev/issues/275?email_source=notifications&email_token=AJERP6AZ4DO2FLDNFF5BAFLQN2AAJA5CNFSM4IY5A6OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA2AWNY#issuecomment-540281655,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJERP6G3NK3RWNBP5FUA2L3QN2AAJANCNFSM4IY5A6OA
.


fix(module-federation): compatibility issues with older browsers

Summary

Require Documentation?

[ ] No
[ ] Yes, the corresponding rspack-website PR is __

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Tests need pass, and please sign the CLA

Tests need pass, and please sign the CLA

ok


Chinese display is incorrect.

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed: https://github.com/GetStream/Winds/issues

Description
[Description of the issue]
Steps to Reproduce
1.Add https://bbs.kafan.cn/forum.php?mod=rss&fid=7&auth=2e0aVdoTRFGLuTySThlohgk9PtFL2LHczXL1g4VeSERqykz3zkrTA475EhTSia0
Expected behavior: [What you expect to happen]Chinese display is correct.
Actual behavior: [What actually happens]Chinese display is incorrect.
Reproduces how often: [What percentage of the time does it reproduce?]
Versions 3.1.6
You can get this information from the manu. Winds > About Winds.
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

@mxdh Thanks for reporting this. it looks like a problem with the font-family that Winds is using.
I think this problem is caused by charset.
The charset of bbs.kafan.cn is GBK.
Msyh(Microsoft YaHei) is a good Chinese font-family,but may it cause copyright problems?

@mxdh is there any google font to support this charset?

Like these？
https://fonts.google.com/?subset=chinese-simplified&category=Serif,Sans+Serif,Display,Monospace


RFE: hex.EncodeToString on byte arrays, with slicing

hex.EncodeToString is currently (correctly) not being suggested for byte arrays.
I'm wondering if it should, also noting that an array would need to be made a slice one way or another, e.g. with [:]?

Hmm... Do you have a code sample ? If I recall correctly, some cases are supported

https://go.dev/play/p/p98DpofjCGz
package main

import (
	"crypto/sha256"
	"encoding/hex"
	"fmt"
)

func main() {
	sum := sha256.Sum256([]byte("hello world\n"))
	fmt.Println(fmt.Sprintf("%x", sum))
	// fmt.Println(hex.EncodeToString(sum)) // cannot use sum (variable of type [32]byte) as []byte value in argument to hex.EncodeToString
	fmt.Println(hex.EncodeToString(sum[:]))
}

This only works for literals, right ?
Cf https://go.dev/play/p/V2PmRQt7jUn
	fmt.Println(fmt.Sprintf("%x", sha256.Sum256([]byte("hello world\n"))))
// cannot be replaced by following line
	fmt.Println(hex.EncodeToString(sha256.Sum256([]byte("hello world\n"))[:]))
// errors with invalid operation: sha256.Sum256([]byte("hello world\n")) (value of type [32]byte) (slice of unaddressable value)

@catenacyber this works for non literal but you need to put in a variable first:
sum := sha256.Sum256([]byte("hello world\n"))
fmt.Println(hex.EncodeToString(sum[:]))

@scop this works for me with latest commit 0.3.1
Which version are you running ?

Closing as working on latest version


⚠ Bofrost.be has degraded performance

In 02df76c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1383 ms

Resolved: Bofrost.be performance has improved in 947f5c3 after 6 minutes.


Add AOT-compiled versions of proxy docker builds

We've been experimenting with AOT-compilation with jaotc, as a possible alternative to native-image. We'll have performance details from load testing later on. Drafting the build changes for now to make them available.

We'll likely stick with native images for a while. Closing this, but we can always revisit with the changes here to explore ahead-of-time compiling + class data sharing for faster startup of a hotspot JVM.


Issue with scaling to height

Hello, I have some issue regargind scaling to fixed height.
When fixed (or max) height is set on Magnifier's  container, then image doesn't scale and may overlap content below (in the case when container has bigger aspect ratio than image).
I prepared example to demonstrate this problem: https://codesandbox.io/s/react-image-magnifiers-size-bug-6j7s0
There are three sizes: Normal (width and height keeps image's aspect ratio), Wide (width is increased, so aspect ratio is higher) and Narrow (width is decreased). Problem occurs in Wide.
Also I've prepared there some CSS changes which seems to fix this issue, may be included by Apply fix checkbox.
File with proposed changes: https://codesandbox.io/s/react-image-magnifiers-size-bug-6j7s0?file=/fix.css

I've toyed with this in the past and found that it is a challenging feature to support in a decent way. In your fix example, the container (interactive area) is wider than the image. Setting the Magnifier to display: inline-block will fix this and avoid some centering calculation errors. That, and your proposed fix is a good work around to use for now. However, there are some situations and use cases where it'll cause issues, so I can't add it in for everyone.
I'm going to take a look at it again and see if there is a good way to support this as an opt in feature.


Bump transformers to 4.38.2

The substantive change here is to fix rope, as hf changed the api...again

I don't really want to set up tests for each transformer version as that will increase our test load quite a bit, and LLM Foundry actually pins transformers versions beyond the ones that are special cased here. It is true that we are not actually testing the BC, apart from that I ran manually the test_flash_torch_triton.py tests on 4.37 and 4.38. I think this is sufficient for now, and we can revisit in the future if needed.


Allow configuring the docker image used by eventtailer

Is your feature request related to a problem? Please describe.
In a air-gapped system, images cannot be pulled from docker hub.
Describe the solution you'd like
Allow overriding the eventtailer docker image.
Describe alternatives you've considered
Mutation via Kyverno: not an elegant option
Additional context
See hardcoded image at https://github.com/banzaicloud/logging-operator/blob/4218d98bb104b816cf634519103fd53848a49f91/pkg/resources/eventtailer/statefulset.go#L63

Hi. i use helm and app 3.17.7
Just added  "containerOverrides" to templates/eventailer.yaml
{{- with $.Values.eventTailer }}
apiVersion: logging-extensions.banzaicloud.io/v1alpha1
kind: EventTailer
metadata:
  name: {{ .name | default "event-tailer" }}
spec:
  controlNamespace: {{ $.Values.controlNamespace | default $.Release.Namespace }}
  containerOverrides:
      image: {{ $.Values.eventTailer.image }}
....
....

in values.yaml
eventTailer:
  image: <your_private_registry>/eventrouter:v0.1.0

I missed this field, it works as expected! Thank you @Lamovich.


Crash with ContextualRelevancyVerdict

Description of the Issue:
Hi there,
I'm encountering a Pydantic Error in this section of the code where the input is not being recognized as a string:
def _generate_verdicts(
    self, text: str, retrieval_context: List[str]
) -> List[ContextualRelevancyVerdict]:
    verdicts: List[ContextualRelevancyVerdict] = []
    for context in retrieval_context:
        prompt = ContextualRelevancyTemplate.generate_verdict(
            text=text, context=context
        )
        if self.using_native_model:
            res, cost = self.model.generate(prompt)
            self.evaluation_cost += cost
        else:
            res = self.model.generate(prompt)
        data = trimAndLoadJson(res, self)
        verdict = ContextualRelevancyVerdict(**data) <<<<<<<<
        verdicts.append(verdict)

    return verdicts

I'm using the Mistral mistral-large-latest Model, defined with a custom your class.
I suspect the issue may be related to the prompt using a simple syntax, possibly leading to incorrect output.
Steps to Reproduce:
Nothing out of the ordinary, simply utilizing ContextualRelevancyMetric, FaithfulnessMetric, and AnswerRelevancyMetric.
Environment (Desktop):

Operating System: Mac OS

How can we modify the prompt without directly altering the framework code?
Are there any recommended methods or alternative approaches to achieve this customization?

I will try to reproduce it.


Added tree hashing algorithm

Adds to the SSZ spec an algorithm for tree-hashing SSZ objects.
Experiments suggest that the hashing time required is increased by a factor of ~4-6, partly because Merkle hashing inherently raises the amount of data hashes due to multiple layers of hashing and partially because hash functions have a fixed computation cost in addition to the per-byte cost.

It would be nice to have an example of tree_hash function implementation at the end of Tree hash section.

It would be nice to have an example of tree_hash function implementation at the end of Tree hash section.

@mkalinin you can find this here: https://github.com/ethereum/beacon_chain/blob/vitalik_hash_ssz/hash_ssz.py
I imagine @djrtwo will copy the code or something like it into the python impl once this gets finalized/approved.


Create README.md

Checkmarx One – Scan Summary & Details – 184bd121-16d8-428c-a123-e7c51229e521
No New Or Fixed Issues Found


Issue 181 homepage

Fix #181
Test URLs:

Before: https://main--zemax--hlxsites.hlx.page/
After: https://issue-181-homepage--zemax--hlxsites.hlx.page/

Header links are shifted to left which looks very odd, that is not the case in main branch currently


Put a 900-sec timeout on the perf test.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

this is ok to test

LGTM, fine to merge once performance tests are green.
One observation I'd like to note is that it looks like the shell script will get out of hand fairly quickly and we might need to switch to something a bit more manageable in the future (e.g. some python script to drive this)

It passes, but 900sec is 15min which could be a while for later tests.  For instance, if we look at the pattern of build times over time, with the following script:
$ cat perf-tests.sh
#!/bin/bash
testtimes=" "
for ((t=500;t<=700;t++));
do
  testtime=$(curl --silent https://grpc-testing.appspot.com/job/gRPC_performance_pull_requests/$t/ | grep Took | cut -f2 -d"<" | cut -f2 -d">")
  if [ $(expr "$testtime" : '.*') -gt 1 ]; then
    echo "BUILD "$t" -> "$testtime
  fi
done
$
$ ./perf-tests.sh
BUILD 600 -> 2 min 36 sec
BUILD 601 -> 2 min 37 sec
BUILD 602 -> 2 min 38 sec
...

If I look at the average, it's 2 min 22 sec.  If I plot the trend, it seems to expand quite dramatically lately by almost 4x than the average.

It might be good to keep this in mind, and maybe optimize around it so that it doesn't become a bottleneck later on.
~p

I guess that's what Jan was suggesting too :)


FileCache doesn't seem to work?

I'm attempting to use ariadne::FileCache with Report::write (or print or eprint), but it doesn't seem to work for me.FileCache implements Cache<Path> but not Cache<PathBuf>, and as std::path::Path isn't sized, I can't pass a Path directly into Report::build or a Label. Using &Path in the following minimal example:
fn example() {
    use ariadne::*;

    let mut fc = FileCache::default();
    let path = std::path::PathBuf::from("example.txt").as_path();

    let mut builder = Report::build(ReportKind::Error, path, 10)
        .with_message("message")
        .with_label(Label::new((path, 10..20)).with_message("something bad"));

    builder.finish().eprint(fc).unwrap();
}

yields the following error:
error[E0277]: the trait bound `ariadne::FileCache: Cache<&Path>` is not satisfied
   --> src/parsing.rs:19:29
    |
19  |     builder.finish().eprint(fc).unwrap();
    |                      ------ ^^ the trait `Cache<&Path>` is not implemented for `ariadne::FileCache`
    |                      |
    |                      required by a bound introduced by this call
    |
    = help: the trait `Cache<Path>` is implemented for `ariadne::FileCache`
note: required by a bound in `ariadne::Report::<S>::eprint`
   --> /home/jon/.cargo/registry/src/github.com-1ecc6299db9ec823/ariadne-0.1.5/src/lib.rs:159:22
    |
159 |     pub fn eprint<C: Cache<S::SourceId>>(&self, cache: C) -> io::Result<()> {
    |                      ^^^^^^^^^^^^^^^^^^ required by this bound in `ariadne::Report::<S>::eprint`

For more information about this error, try `rustc --explain E0277`.

This is using ariadne 0.1.5.
Thanks!

I just stumbled on this same issue. If nothing else can FileCache be removed until a solution exists. It would have saved me a lot of time. As it was I saw what was clearly what I wanted and was banging my head against the wall trying to figure out how to get it to work, where I would have just used the FnCache if that was the only option.

Also it looks like FnCache doesn't work with Path/PathBuf either due to the requirement for Display that Path doesn't meet. So a custom implementation is required to work with Path/PathBuf. Not a big deal, just pointing it out.

I'm slowly gearing up to a crate rewrite, so I'll add this to the list of things to fix when this happens. Thanks for the reminder!


AspNetCoreFacility: marking scoped component as CrossWired makes it behave like singleton

When I mark component as CrossWired during registration, it starts to behave like singleton. Only one instance is ever resolved from the container.
However, this issue only manifests, when the component is injected into Controller. If the component is injected into Razor markup, lifestyle is correctly scoped to request.
This makes the facility unusable, if Cross Wiring is necessary. I would expect only single instance of Service and Facade being resolved per-request.
Repro steps below, they're based on MVC (in order to test @inject/CrossWired support).
Complete project is in this repo:
https://github.com/mirol-h/castle-windsor-aspnetcorefacility-scoping-issue
Is this configuration issue or a bug within the ASP.NET Core Facility?
Service & Facade:
public interface IFacade
{
	string GetInfo();
}

public class Facade : IFacade
{
	private readonly IService service;

	public Facade(IService service)
	{
		this.service = service;
	}

	public string GetInfo()
	{
		return $"[Facade]{GetHashCode()}, Service: {service.GetHashCode()}";
	}
}

public interface IService
{
	string GetInfo();
}

public class Service : IService
{
	public string GetInfo()
	{
		return $"Service: {GetHashCode()}";
	}
}

Startup:
public class Startup
{
	private readonly WindsorContainer container = new WindsorContainer();

	public Startup(IConfiguration configuration)
	{
		Configuration = configuration;
	}

	public IConfiguration Configuration { get; }

	public IServiceProvider ConfigureServices(IServiceCollection services)
	{
		container.AddFacility<AspNetCoreFacility>(f => f.CrossWiresInto(services));

		services.AddMvc();
		services.AddLogging((lb) => lb.AddConsole().AddDebug());

		container.Register(Component.For<IService>().ImplementedBy<Service>().LifestyleScoped()/*.CrossWired()*/);
		container.Register(Component.For<IFacade>().ImplementedBy<Facade>().LifestyleScoped().CrossWired());

		return services.AddWindsor(container,
			opts => opts.UseEntryAssembly(typeof(HomeController).Assembly));
	}

	public void Configure(IApplicationBuilder app, IHostingEnvironment env)
	{
		if (env.IsDevelopment())
		{
			app.UseDeveloperExceptionPage();
		}
		else
		{
			app.UseExceptionHandler("/Home/Error");
		}

		app.UseStaticFiles();
		app.UseCookiePolicy();

		app.UseMvc(routes =>
		{
			routes.MapRoute(
				name: "default",
				template: "{controller=Home}/{action=Index}/{id?}");
		});
	}
}

HomeController:
public class HomeController : Controller
{
	private readonly IService service;
	private readonly IFacade facade;

	public HomeController(IService service, IFacade facade)
	{
		this.service = service;
		this.facade = facade;
	}

	public IActionResult Index()
	{
		var sb = new StringBuilder();
		sb.AppendLine(service.GetInfo());
		sb.AppendLine(facade.GetInfo());
		sb.AppendLine($"Controller: {GetHashCode()}");
		return View("Index", sb.ToString());
	}
}

Razor View:
@model string

@using CastleWindsorAspNetCoreFacilityRepro.Services
@{
    ViewData["Title"] = "Home Page";
}

@inject IFacade Facade
@*@inject IService Service*@

Controller

@Model

@@inject

@Facade.GetInfo()

@*@Service.GetInfo()*@

Description
I am facing the same issue. Cross wired component behaves like a singleton in controllers.
Steps to reproduce
I have prepared a simple demo to reproduce the bug.
In the demo below we register one service (MyService) with a scoped lifestyle and we cross wire the class. In the controller we get still the same instance. Run the demo, open the "root" page and refresh it a few times. The hash code is still the same.
using System;
using Castle.Facilities.AspNetCore;
using Castle.MicroKernel.Registration;
using Castle.Windsor;
using Microsoft.AspNetCore;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.DependencyInjection;

namespace MyApplication
{
    public class Program
    {
        public static void Main(string[] args)
        {
            CreateWebHostBuilder(args).Build().Run();
        }

        public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
            WebHost.CreateDefaultBuilder(args)
                .UseStartup<Startup>();
    }

    public class Startup
    {
        private readonly WindsorContainer container = new WindsorContainer();

        public IServiceProvider ConfigureServices(IServiceCollection services)
        {
            container.AddFacility<AspNetCoreFacility>(f => f.CrossWiresInto(services));

            // Register MyService class with scoped lifestyle and cross wire it (to be able to be used in Razor views or in authorization handlers or ...)
            container.Register(Component.For<MyService>().LifestyleScoped().CrossWired());

            services.AddMvc();
            return services.AddWindsor(container);
        }

        public void Configure(IApplicationBuilder app, IHostingEnvironment env)
        {
            app.UseMvc(routes => routes.MapRoute("default", "{controller=Home}/{action=Index}/{id?}"));
        }
    }

    public class MyService
    {
        // just a service registered to Castle Windsor
    }

    public class HomeController : Controller
    {
        private MyService myService;

        public HomeController(MyService myService)
        {
            this.myService = myService;
        }

        public IActionResult Index()
        {
            // MyService behaves like a singleton (despite to the registration), so we get still the same HashCode.
            int hashCode = myService.GetHashCode();

            return new ObjectResult(hashCode);
        }
    }
}

Workaround
Unknown.

Closing as stale. Castle.Windsor.Extensions.DependencyInjection is the path forward for ASP.NET Core 3.x.