Trivy javadb poor performance in 0.37.2

In 0.37.1 there was a reported issue about slow scan for java vulnerabilities https://github.com/aquasecurity/trivy-java-db/issues/8
The provided workaround of manually creating sqlite indexes was helping to bring good scan times back.
In 0.37.2 and with newer versions of java-db the issue still exists but the workaround of creating indexes with
sqlite3 db/java-db/trivy-java.db << EOF
CREATE INDEX sha1 ON indices (sha1);
CREATE INDEX artifact_id_group_id ON indices (artifact_id, group_id);
CREATE INDEX artifact_id_archive_type ON indices (artifact_id, archive_type);
EOF

doesn't apply as it fails with
Parse error near line 2: no such column: group_id
  DEX artifact_id_group_id ON indices (artifact_id, group_id);
                                      error here ---^

Variation of workaround script like this
sqlite3 db/java-db/trivy-java.db << EOF
CREATE INDEX sha1 ON indices (sha1);
CREATE INDEX artifact_id ON indices (artifact_id);
CREATE INDEX artifact_id_archive_type ON indices (artifact_id, archive_type);
EOT

can create indexes but scans are still slow and consuming a lot of cpu (probably 0.37.2 changed not only the schema but also the queries in a way that doesn't benefit from indexes above anymore)

Hello @dmivankov
New DB schema already has indexes for  sha1 and artifact_id + group_id.
We tested performance after changes and new DB has very high speed.
Can you share some image/jar of your issue for investigation?

Will try to profile it, one image has 355 jar files (external libraries), trivy process consumes 500% cpu (so runs 5 threads), after 4 minutes it is still running, so slow.
trivy binary doesn't have debug symbols so can provide hot stacktraces
With debug output enabled it slowly shows messages like these
2023-02-14T16:49:27.106Z	DEBUG	Parsing Java artifacts...	{"file": "....../com/github/spotbugs/spotbugs-annotations/4.2.0/processed_spotbugs-annotations-4.2.0.jar"}
2023-02-14T16:49:27.107Z	DEBUG	No such POM in the central repositories	{"file": "processed_spotbugs-annotations-4.2.0.jar"}

at ballpark rate of 1 jar per second

This helps to bring scan time to ~3sec
sqlite3 trivy-java.db <<EOT
CREATE INDEX artifact_id_group_id ON artifacts (artifact_id, group_id);
CREATE INDEX artifact_id ON indices (artifact_id);
EOT

both indices are required to make it fast

Can confirm with 0.37.3 as well. MacOS 64 bit (not ARM).

Hello @dmivankov
1st index (CREATE INDEX artifact_id_group_id ON artifacts (artifact_id, group_id);) already exist - https://github.com/aquasecurity/trivy-java-db/blob/7cddb14067284564be63e70b2d2097202f611402/pkg/db/db.go#L66
Hello @eanmclaughlin
I tested this idea with another index(CREATE INDEX artifact_id ON indices (artifact_id);) - but i didn't see any speed increase.
Can you send some test image and we will investigate it.

Yes, index above exists
$ sqlite3 trivy-java.db <<EOT
. indexes
EOT

artifacts_idx     indices_sha1_idx

but it has flipped order and probably can't be used for lookups by artifact_id key prefix
https://github.com/aquasecurity/trivy-java-db/blob/main/pkg/db/db.go#L62
and artifact_id isn't a primary key so doesn't have implicit index
Can also confirm that flipped order is still slow
CREATE INDEX group_id_artifact_id ON artifacts (group_id, artifact_id);
CREATE INDEX artifact_id ON indices (artifact_id);

It could be possible to use sqlite debugging https://www.sqlite.org/debugging.html to get more info on query plans etc, but don't currently have enough spare time to do it myself. Also preparing a public image also needs time. But general setup is just offline scan of image with 300+ jars of maven repository libraries (maybe even using 300 copies of same jar can be used to reproduce the issue, didn't test).

@dmivankov thanks for the analysis, we made similar experiences. most scans are back to OK times with the most recent trivy update to 0.37.2, but especially those with a lot of jar files still take quite long, some of which even run into the 5m default timeout. @DmitriyLewen I also can't share our internal images, but the official gradle image on dockerhub seems to be a good candidate, as the latest version contains at least 239 jars.  trivy image  --debug  gradle:latest takes at least 2 minutes on a small EC2 machine without previous caching (db download not included). I have no reference values for older trivy versions, but I can say with confidence that in our environment the number of "long scans" for Java images is still higher than it used to be before the local-java-db was introduced, and the images themselves  have not changed very much. Thanks for your help!
2023-02-15T19:42:45.074Z	DEBUG	Parsing Java artifacts...	{"file": "opt/gradle/lib/plugins/plexus-utils-3.3.0.jar"}
2023-02-15T19:42:45.077Z	DEBUG	Parsing Java artifacts...	{"file": "opt/gradle/lib/plugins/snakeyaml-1.32.jar"}
2023-02-15T19:42:45.095Z	DEBUG	Parsing Java artifacts...	{"file": "opt/gradle/lib/qdox-1.12.1.jar"}
2023-02-15T19:42:45.098Z	DEBUG	Parsing Java artifacts...	{"file": "opt/gradle/lib/slf4j-api-1.7.30.jar"}
2023-02-15T19:42:45.098Z	DEBUG	Parsing Java artifacts...	{"file": "opt/gradle/lib/plugins/testng-6.3.1.jar"}
2023-02-15T19:42:45.118Z	DEBUG	Parsing Java artifacts...	{"file": "opt/gradle/lib/trove4j-1.0.20200330.jar"}
2023-02-15T19:42:45.120Z	DEBUG	Parsing Java artifacts...	{"file": "opt/gradle/lib/tomlj-1.0.0.jar"}
2023-02-15T19:42:45.122Z	DEBUG	Parsing Java artifacts...	{"file": "opt/gradle/lib/xml-apis-1.4.01.jar"}
(...)

This performance issue is related to https://github.com/aquasecurity/trivy/issues/3608
After creating the two additional indexes mentioned by @dmivankov the newrelic image can be scanned in light speed.
The indexes or queries need to be adjusted.


[Search] Search Nov 2024 Preview

Fixes: https://github.com/Azure/azure-sdk-for-net/issues/46319

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Search.Documents

@microsoft-github-policy-service rerun

/check-enforcer evaluate


Feature/edit title error fix

Purpose
Change the error message of the edit title. Closes [#OSF-4022]
Fix the view-only link name dispaly escape html. Closes [#OSF-4097]
Fix the problem that View Only links sanitization inconsistent between initial naming and editing. Closes [#OSF-4090]
Changes
Before change:

After change:

#OSF-4022

Checks are still failing.

When I edit the title of an existing view-only link according to the instructions on [#OSF-4090] to a new value of <blarg>, then save and reload the page, the link name shows up as "empty". Can you investigate?

CR1 complete. I did have one small request, but that's an easy change. I'll move this into the CR2 column while that gets done.

Changes made... ish.
Ready for CR2.

Pass complete @chennan47! :umbrella: Also, it looks like you have some leftover comments from CR1 as well.

@samanehsan changes have been made and all problems should be addressed. Rdy for another pass.

Looks good to me! Thanks for making those changes @chennan47 :cake:


Scalar OpenAPI Docs Integration

hey 👋  platformatic,
I'm excited to get everyones feedback on integrating the Scalar Fastify plugin in Platformatic. I attached a preview of it working in the docs (see video below 👇 ).
Some features Scalar brings:

Fully integrated REST API Client for testing endpoints (see video)
Offline search powered by Fuse.js
Easily customizable for on brand docs (we have the platformatic theme on default :nail_care: )
Code Snippet generation in dozens of languages

An insane feature that was great to use when building out my demo project was to test the API right in the docs 🤯 felt like the developer experience for iterating and building was so fast! You can see it in the video :)
Some things we need to improve on but are a top priority 🖖

we should add GZIP to serving the docs in platformatic
Swagger-UI bundle size is 2MB vs the 2.2MB for Scalar (we can always get smaller)

I'm really excited to integrate Scalar, I think this is the beginning of a great partnership & I am eager for everyone's feedback on improving this PR & ensuring alignment before we get it merged ✨
https://github.com/platformatic/platformatic/assets/6176314/047fd2c8-df5b-418c-8b36-5f0b7c010753
edit
I can squash my commits after feedback :)

I wonder if rather than shifting the default from swagger-ui to scalar it would be possible to make the documentation UI pluggable where the user can choose either (or other) or just disable it entirely?

I wonder if rather than shifting the default from swagger-ui to scalar it would be possible to make the documentation UI pluggable where the user can choose either (or other) or just disable it entirely?

@mikaelkaron I like your idea of making it configurable! where the user can choose:

scalar
swagger ui
none

im guessing we can keep the configuration inside of platformatic.json? Maybe under a new field called OpenAPIDocumentation which is an object with options of default + route.

also just a heads up we're working on making an alternative layout that's slightly more consistent to swagger UI :)

Yeah, and perhaps the name could even be an npm package?
How different is this than just using plugins with packages except that you’d like to have a way to remove the default swagger-ui?
@mcollina - would it be possible to have the UI be part of a generator rather than just bundled and have the user able to switch?

Btw, the same would probably be true for graphiQL

A few notes:

fix the DCO
It seems the new plugin is not generating the /documentation/json route (take a look at es.js#L161-L201). Currently it exposes the spec as /spec.json.

I really like the new UI.
@mikaelkaron would you prefer the old school UI? If so, why?
I think we could make it configurable somehow / part of the generator.

A few notes:

fix the DCO
It seems the new plugin is not generating the /documentation/json route (take a look at es.js#L161-L201). Currently it exposes the spec as /spec.json.

I really like the new UI.
@mikaelkaron would you prefer the old school UI? If so, why?
I think we could make it configurable somehow / part of the generator.

@mcollina Glad you like the new UI ✨
I just pushed up a fix for DCO & also exposing the swagger spec download to the old route.
I think if the preference is the old school UI, we are going to have a configuration where users can choose "modern" or "classic" layout. Hopefully shipped in the next few weeks 🚀
The classic is this one :) Which feels more closer to Swagger UI
https://github.com/platformatic/platformatic/pull/1858#issuecomment-1832711549

would you prefer the old school UI? If so, why?

Nah, I like the new one better (modern even), but I think you'd want to be able to choose if/which SwaggerUI you want.
That's why I'd like it to be part of the generator, but in a way that it just adds a plugins.packages entry to either @fastify/swagger-ui or @scalar/fastify-api-reference if the user want's a UI, or nothing if the user don't want a UI (but still a .json generated with the OpenAPI).

A few things are missing

[ ]  The UI loads /spec.json, which should not be served (at all)
[ ]  The /documentation/json endpoint is listed in the UI (see fastify-swagger on how to hide it)
[ ]  /documentation/yaml is missing
[ ]  terser is added as a dependency and it does not seem used.
[ ]  @scalar/api-reference does not seem to be used in production, only to get a type (it also has a massive dependency list)
[ ]  it seems the UI is loading a file from a fixed URL (in @fastify/swagger-ui it is relative), which is tricky when composing plugins.
[ ]  please avoid the use of console, use the logging facilities.
[ ]  prefer the use of return html or return reply.send(html) to avoid forking the promise chain. Note that in those cases both handlers do not need to be async.

@mcollina just pushed up fixes, really appreciate your time and insights. All of these improvements really make the fastify-scalar integration way better! So we really appreciate that ✨

The UI loads /spec.json, which should not be served (at all)
Removed, we have a download button now
The /documentation/json endpoint is listed in the UI (see fastify-swagger on how to hide it)
Done :)
/documentation/yaml is missing
Added ✨
terser is added as a dependency and it does not seem used.
Removed
@scalar/api-reference does not seem to be used in production, only to get a type
Removed
it seems the UI is loading a file from a fixed URL (in @fastify/swagger-ui it is relative), which is tricky when composing plugins.
Great call, we updated this and can be seen here
please avoid the use of console, use the logging facilities.
Fixed :)
prefer the use of return html or return reply.send(html)
fixed

The Node.js recommended client is node-fetch. It's better to recommend fetch() itself.

There are still some console.logs:

[ ] https://github.com/scalar/scalar/blob/main/packages/fastify-api-reference/src/fastifyApiReference.ts#L120
[ ] not fixed yet https://github.com/scalar/scalar/blob/9c880d04c557cbe011cfecdd6fb2a602704bcb2f/packages/fastify-api-reference/src/fastifyApiReference.ts#L243-L246

This also needs a rebase (sorry about it)

[ ]  not fixed yet https://github.com/scalar/scalar/blob/9c880d04c557cbe011cfecdd6fb2a602704bcb2f/packages/fastify-api-reference/src/fastifyApiReference.ts#L243-L246

We have two routes, one for HTML (which is using reply.html() now) and to serve the JavaScript (which is still using reply.send()). Or is there a better way to serve the JavaScript file?

I've found two issues. The first is that all the Node.js snippets are for old libraries that I would not recommend:

axios
node:http
request

What should be there is:

undici https://undici.nodejs.org/#/
fetch()

What's the snippet library are you using? we can likely add stuff there.
The second issue is about the Web Client. You are adding all optional query parameters by default. This is a major difference compared to Swagger UI, where those are not added if not set.

...What's the snippet library are you using? we can likely add stuff there.

Appreciate the review! We are using httpsnippet-lite https://github.com/P0lip/httpsnippet/, will look into adding undici + fetch

... You are adding all optional query parameters by default. ...
Ah, yes we can fix this ✨

@mcollina we fixed the "... You are adding all optional query parameters by default. ..." issue :)
as for the "Node.js snippets are for old libraries" comment, we realized that adding the two additional libraries is a larger body of work, but we have started the undici snippet library here :)
would be excited to fast follow with the undici + fetch snippet library after merge. But if you want those two snippet libraries finished first let me know :)

@mcollina I bring good news :) the wonderful @hanspagel pushed up the undici code snippets into Scalar

@mcollina looks like i was missing @platformatic/scalar-theme from the package.json in the composer package.
the tests that were failing should run now so we can kick those off again ✨

@mcollina i fixed the failing ci-db-core-test
im not sure on ci-service ci-runtime ci-composer & playwright-e2e failing in this branch (also appears to be on main?) let me know on any guidance 💫

yeah, we had a few CI problems.

Is it possible that this feature brings back the annoying spamming logs for requests to the documentation/json resource that is caused by a Compose Service polling?
I had hoped those logs went away with this issue:
https://github.com/platformatic/platformatic/pull/1083#issuecomment-1591670524
I can't find a convenient way to disable them exclusively for that resource otherwise.


Get current keyframe?

Hi everyone. Thanx to great lib. I have a question.
How can I get the currenly executed keyframe in animation update event? I need to pass some additional data to the keyframes. I have a large amount of data, so searching in update event might be very slow.

Hi @ykorshev, this currently isn't support by anime.js, but I will add it to the enchancements list incase more want it.


[BUG] Support Incompatible Wallets

Context & versions

The "connect wallet" popup modal currently displays incompatible wallets, meaning wallets that are not listed on the following compatibility list: https://docs.sanchogov.tools/how-to-use-the-govtool/getting-started/get-a-compatible-wallet.

Steps to reproduce

Install a wallet extension that does not support CIP-95 or is not listed on the compatibility list .
Click the "connect wallet" button.
Observe the available wallet options.
Attempt to connect with the incompatible wallet.

Actual behaviour

The popup modal displays both compatible and incompatible wallets, as shown in the attached images:

Attempting to connect with an incompatible wallet results in the 'undefined reading getExtensions' error.

Expected behaviour

Should verify CIP-95 compatibility before displaying any wallets.

For more details, refer to this report

@Ryun1 What  do you think of filtering out CIP-95 incompatible wallets?

After a more  in-depth analysis, the issue is rather on the wallet side.
We display on a list every wallet that includes:
supportedExtensions: [{ cip: 95 }]

and the wallet you provided on a picture, indeed includes this entry in its declaration:

And that makes, that we, based on CIP-95 Extension API, provide the extensions: [{ cip: 95 }] argument while enabling the wallet. And at this step there is the problem described in the issue - priority wallet even though it declares support for CIP-95, it doesn't really have such support that is why such error on modal occurs.
However, I made some improvement to the listing of the wallets and displaying an error on a modal informing the user, that the wallet that has been listed doesn't really have the CIP-95 support or even CIP-30 support  due to missing getExtensions described here.
@Ryun1 Should we depend only on the list of compatible wallets and display only these? Or on the choose wallet modal
should we display every wallet that has the cip-95 and cip-30 supported extension or the wallets that has only the cip-95 extension as we do currently?
So far within this PR I introduced following solution:

Closing this with the discussion above.


Fix Unicode Encode Error

This fixes an error that occurs when downloading a Highlights Collection with an invalid emoji in the title
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\macielg1\AppData\Local\Programs\Python\Python312\Scripts\instaloader.exe\__main__.py", line 7, in <module>
  File "C:\Users\macielg1\AppData\Local\Programs\Python\Python312\Lib\site-packages\instaloader\__main__.py", line 541, in main
    _main(loader,
  File "C:\Users\macielg1\AppData\Local\Programs\Python\Python312\Lib\site-packages\instaloader\__main__.py", line 283, in _main
    instaloader.download_profiles(profiles,
  File "C:\Users\macielg1\AppData\Local\Programs\Python\Python312\Lib\site-packages\instaloader\instaloader.py", line 1484, in download_profiles
    self.download_highlights(profile, fast_update=fast_update, storyitem_filter=storyitem_filter)
  File "C:\Users\macielg1\AppData\Local\Programs\Python\Python312\Lib\site-packages\instaloader\instaloader.py", line 81, in call
    return func(instaloader, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\macielg1\AppData\Local\Programs\Python\Python312\Lib\site-packages\instaloader\instaloader.py", line 970, in download_highlights
    self.context.log("Retrieving highlights \"{}\" from profile {}".format(user_highlight.title, name))
  File "C:\Users\macielg1\AppData\Local\Programs\Python\Python312\Lib\site-packages\instaloader\instaloadercontext.py", line 143, in log
    print(*msg, sep=sep, end=end, flush=flush)
  File "C:\Users\macielg1\AppData\Local\Programs\Python\Python312\Lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeEncodeError: 'charmap' codec can't encode character '\U0001f3b9' in position 23: character maps to <undefined>

The updated code tries to print normally. If there's an error, it replaces the invalid characters.

I feel like we need more information about the motivation of this pull request. Which bug does this fix? I expected Python to handle printing unicode characters on the terminal. When does this error occur, how can we reproduce this error, which terminal was used on Windows? We had reports of something similar in #32, but it is long fixed (and the fix became already unnecessary since Python 3.6), and five years ago a discussion in #197 that however is unresolved.


feat(error handling): catch uncaught Promise errors

Fixes #266

So where I'm at with this:
I believe there is great value in tagging invocations that have these types of "silent" errors when we can. Would like to chat further about our options beyond failing the invocation on the AWS side - because deviating from their behavior is unwanted at this time.

@coreylight "tagging" invocations sounds like a great case for adding a label

@pselle knowing what the error was is definitely of interest to me though - so @iopiope prefixed custom metrics perhaps? Or maybe the logging plugin can pick these messages up for us automatically?

@coreylight Sounds like a good feature proposal -- I think the label is low enough to start with, and then what you're describing could be a good v2 progression of that feature

@pselle @kolanos updated PR to more simply console.error the error (like Node already does) and add a label for visibility. The actual error will be picked up for display with the logger plugin if it is available 😎

Updated to label the invocation with @iopipe/error as well


provide warning before clicking in dropdown and disable preset/function

This PR moves the warning stating that choosing "Random" as a colormap overrides the values for stretch function and percentile preset from after making the selection to before via a tooltip in the dropdown itself.  This also then disables the inputs for stretch function and percentile preset.
https://github.com/bmorris3/jdaviz/assets/877591/723ef4a6-77b7-4118-9798-04a140f9db9b
Note that this does not technically prevent the user from overriding these values from the API, nor does it result in this warning being raised in advance when setting the colormap to "Random" from the API.
I did not rename "Random" here, but do think that naming it something tied specifically to segmentation maps, and adding that context in the warning itself, would also be useful additions.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (image-segment@ec2b439). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##             image-segment      #30   +/-   ##
================================================
  Coverage                 ?   90.84%
================================================
  Files                    ?      162
  Lines                    ?    20988
  Branches                 ?        0
================================================
  Hits                     ?    19067
  Misses                   ?     1921
  Partials                 ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

closing in favor of a dialog to apply changes implemented in the original PR


Rename and add altNames to match case pairs

rename Ereversed as Eturned to match eturned
rename hv as hwair to match Hwair, add Hv to altNames of Hwair
rename Ocenteredtilde as Obarred to match obarred
rename EreversedOpen as Eopenreversed to match eopenreversed
rename Glottalstop to Glottalstopsmall to match glottalstopsmall
rename Gscript to Gsingle to match gsingle

I’m inclined to also rename florin to fhook to match Fhook and maybe add Florin to altNames of Fhook but I’d like to know what you think first.
Something probably needs to be done for the following casing pairs which both have "small capitals" for lowercase:

Yr and Rsmall
uniA7AE (which should be added) and Ismall

thanks


Migrate to PostgreSQL.

SQLite is causing problems. Migrate to PosgreSQL.

Issue #51 takes precedent. Closing this one.


Add a gnav PR template

Description
Adds a new gnav PR template that can be optionally used by adding a query param to the url. https://github.com/adobecom/milo/compare/main...mokimo:gnav-pr-template?expand=1
-> https://github.com/adobecom/milo/compare/main...mokimo:gnav-pr-template?expand=1&template=gnav.md
Related Issue
Resolves: N/A
Testing instructions
Can't be tested until after this is merged
Screenshots (if appropriate):
Make our lives easier

Types of changes

[x] Chore (Unit test, setup - no prod code)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Test URLs
Acrobat:

Before: https://www.stage.adobe.com/acrobat/online/sign-pdf.html?martech=off
After: https://www.stage.adobe.com/acrobat/online/sign-pdf.html?martech=off&milolibs=gnav-pr-template--milo--mokimo

BACOM:

Before: https://business.stage.adobe.com/fr/customer-success-stories.html?martech=off
After: https://business.stage.adobe.com/fr/customer-success-stories.html?martech=off&milolibs=gnav-pr-template--milo--mokimo

CC:

Before: https://main--cc--adobecom.hlx.live/?martech=off
After: https://main--cc--adobecom.hlx.live/?martech=off&milolibs=gnav-pr-template--milo--mokimo

Milo:

Before: https://main--milo--adobecom.hlx.page/ch_de/drafts/ramuntea/gnav-refactor?martech=off
After: https://gnav-pr-template--milo--mokimo.hlx.page/ch_de/drafts/ramuntea/gnav-refactor?martech=off

Great idea @overmyheadandbody I opened https://github.com/orgs/adobecom/discussions/1214


Akri DEV Helm Chart 0.8.12 - akri-opcua-discovery-daemonset Failure

Describe the bug
akri-opcua-discovery-daemonset - fails to discover the OPC UA server generates the following error.:
[2022-06-16T00:37:28Z INFO  akri_opcua::discovery_impl] do_standard_discovery - for DiscoveryUrls ["opc.tcp://<IP_ADDRESS>:50000/"]
thread 'tokio-runtime-worker' panicked at 'Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.', /cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.17.0/src/runtime/blocking/shutdown.rs:51:21
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
After restarting the "akri-opcua-discovery-daemonset " it stucks at below and does not discover the server anymore.
[2022-06-16T01:00:00Z INFO  opcua_discovery_handler] main - opcua discovery handler started
[2022-06-16T01:00:00Z TRACE akri_discovery_utils::discovery::discovery_handler] run_discovery_handler - registering with Agent with uds endpoint
[2022-06-16T01:00:00Z INFO  akri_discovery_utils::registration_client] register_discovery_handler - entered
[2022-06-16T01:00:00Z INFO  akri_discovery_utils::discovery::server] internal_run_discovery_server - entered

this is probably related to this PR that updated our opcua crate version: https://github.com/project-akri/akri/pull/479
While this is being investigated, I'd recommend adding  --version 0.8.10 to installations to the akri-dev chart.

We have encountered this issue https://github.com/locka99/opcua/issues/148. I tried updating to latest where they added a little more async functionality. I will look into seeing if we can gracefully handle the errors instead.


Using Openshift Imagestream with helm 3 results in unnecessary redeployments

Output of helm version:
version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T23:42:50Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2019-10-17T19:23:55Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Openshift on AWS
On Openshift we are using Kubernetes Deployment and StatefulSets in combination with Openshift ImageStreams. It's possible to define the trigger as annotation of the Deployment Object:
https://docs.openshift.com/container-platform/3.11/dev_guide/managing_images.html#image-stream-kubernetes-resources

In the following example the trigger fires when the example:latest imagestream tag is updated. Upon firing, the object’s pod template image reference for the web container is updated with a new image value

In our charts, we are defining a dummy value since the image field value of the pod spec is controlled by openshift like:
---
# Source: timp/templates/qs/qs-dpl.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    image.openshift.io/triggers: |
      [{
        "from": {
          "kind": "ImageStreamTag",
          "name": "jkr-timp-qs:latest"
        },
        "fieldPath": "spec.template.spec.containers[?(@.name==\"qs\")].image"
      }]
  name: jkr-timp-qs
  labels:
    app: "jkr-timp"
spec:
  replicas: 1
  selector:
    matchLabels:
      release: jkr-timp
      app: "jkr-timp"
      app.kubernetes.io/component: qs
  template:
    metadata:
      annotations:
        checksum/secret: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
      labels:
        release: jkr-timp
        app: "jkr-timp"
        app.kubernetes.io/component: qs
    spec:
      containers:
      - name: qs
        image: " "
        imagePullPolicy: IfNotPresent
        ports:
        - name: http
          containerPort: 8080
          protocol: TCP
        env:
        - name: TZ
          value: "Europe/Berlin"
        resources:
          limits:
            memory: 100Mi
        livenessProbe:
          httpGet:
            path: /healthz
            port: http
          initialDelaySeconds: 120
        readinessProbe:
          httpGet:
            path: /healthz
            port: http
          initialDelaySeconds: 5
        volumeMounts:
          - mountPath: /etc/nginx/default.d/qs.conf
            subPath: qs.conf
            name: qs-config
          - mountPath: /usr/share/nginx/html/
            name: data
      securityContext:
        {}
      volumes:
        - name: qs-config
          configMap:
            name: "jkr-timp-qs"
        - name: data
          persistentVolumeClaim:
            claimName: "data-jkr-timp-qs"

After applying the manifest, the image field value is changed to nginx:lastest by openshift.
On the next helm upgrade, helm replaces the image field value back to " ". We identify this it with helm upgrade -v10:
I1115 16:45:06.834193   49498 request.go:968] Request Body: {"spec":{"template":{"spec":{"$setElementOrder/containers":[{"name":"qs"}],"containers":[{"image":" ","name":"qs"}]}}}}
I1115 16:45:06.834224   49498 round_trippers.go:423] curl -k -v -XPATCH  -H "Accept: application/json" -H "Content-Type: application/strategic-merge-patch+json" -H "Authorization: Bearer XXX" 'https://openshift.local:443/apis/apps/v1/namespaces/experimental/deployments/jkr-timp-qs'

The result forces a redeployment since the openshift trigger will reapply the image field to nginx.
This behaviour is new in helm 3.
Is this an expected behaviour? It will break all setups like this. Using Openshift Imagestreams with Deployments is a common use case inside Openshift.
Demo Chart which covers this issue perfectly: https://github.com/jkroepke/helm3-imagetrigger-test/tree/master

After reading some other issues here, the new merge strategy could be the cause
https://github.com/helm/helm/pull/6124
I found other issues related to this problem (clusterIP instead image field):
https://github.com/helm/helm/issues/6378
Its possible to add a new parameter --merge-strategy where is use can decide if they want a  three-way two-way merge?

Given https://github.com/helm/helm/pull/6987#event-3521981360 has now been closed, has this use case been addressed by other means and this can be closed?

Technically, this issue is not resolved.
For Helm 3 have to avoid Openshift Imagestreams and set the image value manually like on a vanilla Kubernetes.
But I'm going to close this.


Cannot directly open blobs with no file extension on Windows 10 1903

Storage Explorer Version: 1.9.0
Build Number: 20190701.8
Platform/OS: Windows 10 1903
Architecture: x64
Regression From:  Regression from behavior on Windows 10 1809
Bug Description
When double clicking a blob to open it and the blob does not have a file extension (e.g. configuration), rather than showing the "Open file with" windows dialog, you instead receive an error dialog: e.g.:

Steps to Reproduce

Navigate to a Storage Account -> Container that contains a blob without a file extension
Double click the blob

Expected Experience
Expect to receive the standard Windows "How do you want to open this file" picker:

After picking an application from the list the file would be opened in the selected app.
Actual Experience
An error is received:

The file cannot be opened in an editor without downloading it explicitly.
Additional Context
The behavior is as expected on Windows 10 1803 and 1809, but shows the error on 1903.

I have the same issue on 1903
Work around:
Right click on the blob | Download
Save.
Open Windows Explorer
Double click file
Choose a program to open file, e.g. notepad
or Optionally rename file to have .txt(?) extension

@JasonYeMSFT , let's look into this while doing AzCopy open.

Ok, I'm on 1809 and things are working as expected....I'm going to update to 1903 and see what happens...

Yep, it regresses on upgrade. Unfortunately there doesn't seem to be anything we can do on our side for this. I'll need to file an electron bug tomorrow. Sorry y'all. 😰

Filed Electron issue: https://github.com/electron/electron/issues/20543

Electron have closed the bug - where does this go next?

They believe it is an issue in Windows. So we need to do some more investigation.

I've now seen this issue in a number of electron based applications.  Is there an upstream bug we can be tracking?

@neilrees  Electron issue: https://github.com/electron/electron/issues/20543

@MRayermannMSFT : do you have a windows issue for us to monitor?

Using Storage Explorer 1.13.1 and Windows 10 1909, double click to open a blob without an extension will generate the following warning dialog:

If you click on Yes to open the file, it will be downloaded first then Windows File Explorer is opened. If you double click to open the file, you will be asked how you want to open the file.

@jinglouMSFT I've tried double clicking on a file and the same error is reported.
Storage Explorer Version: 1.13.1
Build Number: 18362.836
Platform/OS: Windows 10 1903
Architecture: x64

This is still repro with Storage Explorer 1.13.1 and Windows 10.1090.  Will enter a bug on Windows.

Reported the issue to Windows.

Reporting back on the Windows bug - There was a regression in the ShellExecute API in Windows 10 builds 190x.  This issue has been fixed in Windows 10 build 2004. Build 2004 is currently being rolled out gradually.  In terms of a workaround if you are on Windows 10 build 190x and if you are comfortable modifying your Windows registries, you can associate the file extension (no-extension) there.  We don't recommend this if you don't normally modify the registries as the impact is system wide.  Another workaround is to down load the file/blob to a local temp folder, and open it from Windows File Explorer.  This is the default download experience in Storage Explorer. The association in the File Explorer works just fine.

Thanks @jinglouMSFT can confirm that upgrading to Windows 2004 has solved this 👍

That's great.  Thanks much for letting us know.


Return Identity after INSERT INTO request

Hello,
I have a problem with an INSERT INTO request. I must get the @@IDENTITY after add data into my table. But unfortunately, I don't know how to perform this with node-adodb.
In ASP.NET, I just made a SELECT @@IDENTITYbefore closing the connection.
Thank you to enlighten me.
EDIT: I have made some changes in your library. I will fork your project and push my changes.

3Q, see https://github.com/Nuintun/node-adodb/releases/tag/1.3.0


feat: add color system and color docs

This PR includes a color system built on top of bootstrap's existing color system. The notion of color levels is expanded and affords setting explicit values for all theme color levels rather than bootstrap's use of darken() or lighten().
Accessibility: All color levels 500 and greater are intended to provide accessible contrast on white and color levels 100 and lower.
Color utilities have been added with the intention that Open edX users should be able to apply a bootstrap theme variables file to Paragon SCSS without breaking the output. This includes making sure our additions have reasonable defaults if custom variables are not provided.
Button and Alert SCSS definitions have been replaced wholesale by Paragon in this PR. This provides us greater control over colors and focus states.

Coverage remained the same at 87.958% when pulling 0eab55f73448149c1b3679f2cd124f00daefeac8 on abutterworth/update-colors into 179943be80e813b92f43a0065afe64b3642be170 on master.

:tada: This PR is included in version 6.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Ability to select colors for bold and italic

Can ability to select colors for different font styles be added, please? Currently in editor mode there are no possibility to figure out is text is bold, italic or just normal text.

Currently this can be done via CSS snippets:
https://forum.obsidian.md/t/getting-comfortable-with-obsidian-css/133
I will explore adding it to Style Settings

This is now available in Minimal 4.2.8 under Advanced section of Style Settings


HostServ status command error  & /kickban command

oragono-0.13.0-unreleased-93c17e6b980a3bc9a62880ab7dca6a119b93dd98
connected to the ircd, NOT authed to NickServ, using /HS help, I get:
[14.02.2019 18:50] [Notice] -HostServ- *** HostServ HELP ***
[14.02.2019 18:50] [Notice] -HostServ- HostServ lets you manage your vhost (i.e., the string displayed
[14.02.2019 18:50] [Notice] -HostServ- in place of your client's hostname/IP).
[14.02.2019 18:50] [Notice] -HostServ-
[14.02.2019 18:50] [Notice] -HostServ- To see in-depth help for a specific HostServ command, try:
[14.02.2019 18:50] [Notice] -HostServ-     /HS HELP
[14.02.2019 18:50] [Notice] -HostServ-
[14.02.2019 18:50] [Notice] -HostServ- Here are the commands you can use:
[14.02.2019 18:50] [Notice] -HostServ-     HELP shows in-depth information about commands.
[14.02.2019 18:50] [Notice] -HostServ-     OFF disables your vhost, if you have one approved.
[14.02.2019 18:50] [Notice] -HostServ-     ON enables your vhost, if you have one approved.
[14.02.2019 18:50] [Notice] -HostServ-     STATUS shows your vhost and request status.
[14.02.2019 18:50] [Notice] -HostServ-     ... and other commands which have been disabled
[14.02.2019 18:50] [Notice] -HostServ- *** End of HostServ HELP ***
Here comes the fun:
/HS OFF         returns "[14.02.2019 18:52] [Notice] -HostServ- You're not logged into an account"
/HS ON           returns "[14.02.2019 18:52] [Notice] -HostServ- You're not logged into an account"
/HS STATUS   returns "[14.02.2019 18:53] [Notice] -HostServ- No such account"     ???
While logged in, HostServ works as expected, ON, OFF and STATUS.

using solely /kick or /ban, I get the right messages, while  being normal user, on the channel.
 One message should have been enough, like I get one for the kick command, and the second(same message) for the ban command.

As a %(halfop), using /kickban I get the message saying "You're not a channel operator" and after getting the message, executes the kick, as in, from the /kickban, the ban command is executed first, then the kick, one after another.

We don't implement a KICKBAN command, so your client is translating /kickban into a MODE #channel +b and then a KICK. (It would be good if you could confirm this using your client's "raw" log, though.) So most of the weird behavior with /kickban is expected; Oragono is seeing two separate commands, and halfops can kick (as of b7ec121c19d22179) but cannot ban.
HS STATUS while logged out is a bug, which I will fix. Thanks!

HS STATUS fixed in #385. The /kickban thing appears to be a wontfix (but definitely feel free to reopen if the diagnosis was incorrect).


!feat: Migrate to ESLint v9.

Description
Migrate to ESLint v9 flat config

Migrate and restructured configurations for:

common (split into CommonConfig and StylisticConfigArray)
react -> ReactConfigArray
typescript -> TsConfigArray
jest -> JestConfig
meteor -> MeteorConfig

Remove deprecated rules and replaced them with stylistic equivalents:

line-comment-position
multiline-comment-style

Add new rule:

no-useless-assignment
@stylistic/curly-newline
@stylistic/jsx-function-call-newline

Remove eslintConfig in package.json and add eslint.config.mjs for linting sources in this repo.

Other rule changes

Remove node globals from common config.
Add back no-console: off (bookkeeping)
require-await: off -> warn
Add or adjust new stylistic rules for TypeScript:

@stylistic/member-delimiter-style
@stylistic/object-property-newline
@stylistic/comma-dangle
@stylistic/lines-around-comment
Added TypeScript-specific keywords for padding-line-between-statements

For simple-import-sort/imports, group ^@ imports with ^\\w.
Add rules from React plugin:

function-component-definition: warn
jsx-indent-props: off (bookkeeping: handled by stylistic equivalent)
jsx-no-useless-fragment: error
jsx-props-no-multi-spaces: off (bookkeeping: handled by stylistic equivalent)
no-multi-comp: error

Validations

Tested the 3 example configurations locally.
For the React + TypeScript one, see https://github.com/y-scope/yscope-log-viewer/pull/161

Summary by CodeRabbit
Release Notes

New Features

Introduced new ESLint "flat" configurations for various project types
Added support for TypeScript, React, and Meteor project configurations

Dependencies

Updated ESLint and related plugins to latest versions
Upgraded to ESLint version 9 and Node.js version 18+ compatibility

Configuration

Migrated from legacy ESLint configuration to new modular configuration system
Simplified configuration management with ES module syntax

Breaking Changes

Major version bump to 1.0.0
Removed legacy configuration files
Requires new eslint.config.mjs setup for projects

Before a new version is released on the npm registry, we should lock eslint-config-yscope's versions in existing projects.


[Bug]: The master branch text is displayed even after deleting the master branch from app

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The master branch text is displayed even after deleting the master branch from app, along with this the internal server error is displayed

Steps To Reproduce

Connect the application to the git
now create a new branch
From git hub change the default branch to the newly created branch b1
Now come back to the application sync the branch
now master branch will be removed as a default branch
Now go to home page
reopen the application in edit mode
the internal server error is displayed with the selected branch name as master

Public Sample App
No response
Version
release

@haojin111 @IAmAnubhavSaini We should pass the branchname parameter for git connected application when the user clicks on edit. But somehow we are not using the branch from the git application metadata

Fixed


Create swift.yml

Still fails regarding this bug https://bugs.swift.org/browse/SR-13560
//cc @rommex

Congratulations! :tada: This was released as part of Release 0.1.7 :rocket:Generated by GitBuddy

Congratulations! :tada: This was released as part of Release 0.1.7 :rocket:Generated by GitBuddy

Congratulations! :tada: This was released as part of Release 0.2.0 :rocket:Generated by GitBuddy

Congratulations! :tada: This was released as part of Release 0.2.0 :rocket:Generated by GitBuddy


fix: remove node request objects from detailed response

This will prevent the circular JSON error when attempting to stringify the detailed response. The detailed response will include the status code, the status, the headers, and the data.

:tada: This PR is included in version 0.2.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Candle stick chart implementation

Hi all,
I implemented a candle stick chart (candle.js) and added also a new example section for them.
Would be great if you find a minute to review this.
Best regards,
Simon

Follow PR added: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/16745

Follow PR added: https://github.com/willsoto/ng-chartist/pull/125

What's the status on this?

The review is still outstanding IMO..

Can't find src/scripts/charts/candle.js or any related files in 0.11.0
Was it removed?

Negativ, it's part of this pull request:
https://github.com/psimonski/chartist-js/blob/cfe17c14fa1880bdb63a6633e130fc258eb6dd46/src/scripts/charts/candle.js

Hey @gionkunz, this would be a huge addition for me, any chance this could get merged?

Any chance on this getting merged in soon?

+1

Another ping.
I'd be happy to attempt a PR, but I know pretty much nothing about the internals of chartist, so I don't know how good of a job I'll do. It's not a huge PR, and I'd really like to have this feature in the library.

Recommend closing this PR as @gionkunz has replied to an email I sent regarding the status of this PR that there are no plans to merge this into core. He has instead encouraged @psimonski to create a plugin.


Associate AD group with Rancher role

I have AD authentication enabled in Rancher 2.2.8, with 2 AD groups:

rancher-admin
rancher-user

I would like to automatically associate all rancher-admin users to Rancher Admin role and rancher-user users to Rancher User role. Is there a way to do this?

For any auth provider that Rancher has group support for, we want to be able to address this usecase and #22726.

Changes only to user screen:

Add a button on the User list page that says Add Group.  It should only show if you are logged into an Auth provider that supports groups.

Add group page:
Drop-down with list of groups pulled from auth provider
Global Permissions section
Create/Cancel buttons

The feature is tested in Rancher:master-head 5845c2d
Now admin can assign global roles to an AD group.
More tests are done and tracked in the test plan, and new issues will be made for bugs found during the validation.


Create a binary to query a SQL db and expose for prometheus.

This adds a simple binary that connects to an Postgres-like DB (e.g. RDS), performs a set of user-specified queries and exposes them on the /metrics endpoint.
The binary is added to the fluxsvc dockerfile. To use, alter the entrypoint to call the fluxmon application.
Queries are specified in a yaml file.
See --help for all options.

The binary is added to the fluxsvc dockerfile.

Sorry if this is recapitulating a discussion elsewhere, but what's the rationale for including it in this image?

@squaremo No reason. It was the easiest first thing to do.

@squaremo I'm starting to refactor out now. Any recommendations? I.e. new dockerfile? Should it be pushed? New repository?

I'm debating if fluxmon should live in this repo, or in monitoring as jobmon

It certainly seems like it's not specific to flux -- I'd support a separate (public) repo, or moving to monitoring.

Was fixed by addition of external microservice. See
https://github.com/weaveworks/service-conf/pull/556
https://github.com/weaveworks/service-conf/pull/558
https://github.com/weaveworks/service-conf/pull/560


Expose idleListener as a method or property for toggling automatic render

Currently idleListener is a protected property, so markerclusterer instances always call render() on map idle events whenever attached to a map. However sometimes this behavior isn't desirable. With large datasets rendering can take significant resources so users may wish to debounce this event or otherwise only call render() at their convenience. Rendering may also be pointless if the application is always going to change the marker data based on the new map location anyway, which is my current use case.
Describe the solution you'd like
Export a method to toggle automatic calls to render() by remove()ing or reinstating the MapEventListener at idleListener, or export a property which the body of idleListener uses to determine whether to abort before calling render().
I'm willing to make a pull request for this. see: (https://github.com/TheAtomicOption/js-markerclusterer/commit/7e1a90706274bfa731d75413df84169b3bac465f) as a first draft.
**Describe alternatives you've considered
Additionally/alternatively add a MarkerClustererOptions value to configure whether idleListener is assigned. This would at least allow it to be set on initialization, but users would have to write and manage their own listeners for calling render() rather than just calling a method to swap behavior.
Additional Context
My particular use case involves retrieving a new marker list whenever the map pans or zooms. I'm using this module along with the rest of google maps through a wrapper for Blazor, called BlazorGoogleMaps (https://github.com/rungwiroon/BlazorGoogleMaps). Unfortunately this means that there is some lag between the between the business logic and JS. Because of that, alternatives like destroying the current instance of markerclusterer on map events before idle and instantiating a new one with the new data afterwards is difficult to work around. They can easily result in race conditions when things like calls to render from the idleListener can happen before my business logic has had time to respond.
The mediocre workaround I am currently using is to set a listener on the bounds_changed map event to call clusterer.clearMarkers(true) which at least avoids rendering the current set of markers until the next set of markers are added. But it's not optimal since I have to pass the entire marker set back into markerclusterer rather than being able to update it addMarkers()/removeMarkers()

Have you considered trying Grid Clusterer?.  I would give you the flexibility to add / remove data points and redraw on whatever event you choose.

@bdcoder2 I don't think that is a good option. Grid Clusterer is a brand new project with a very poorly organized looking repo, with no commits in the last few months (appears inactive after the initial flurry at its creation in Dec.). It would require rewriting parts of the Blazor wrapper to accommodate. It isn't recommended/supported by Google, and if the name/screenshot is anything to go by it is using a simple grid algorithm for clustering which is not what my use case requires, nor fitting for the wider set of use cases intended to be supported by the Blazor wrapper.
For those reasons, if I were to use a non-standard/unsupported module, I'd just use a private fork of this repo with the idleListener exposed as a public property.

@TheAtomicOption  - No problem, was just trying to provide other options...
It is unfortunate that the original (and current) clusterer implementations chose to use the Marker as the underlying data structure; the Grid Clusterer is up to 90% faster (during data point creation) and can easily handle millions of data points and offers many of the features being requested.
Perhaps when I find more free time, I will try to update the “very poorly organized looking repo”.

This is getting off the topic of this issue, but it's faster because it doesn't do the same thing. The old MarkerClustererPlus was also faster for a similar reason. Seeing as that's your repo, my recommendations are: 1. take the files out of the zip so people can look at them online. 2. update the readme to show example usages and any configuration options it has. 3. maybe have a couple sentences at the top of the readme explaining why you think the module has a niche official options for clustering can't/don't fill.
Thanks for trying to help, but please do not reply further about your module in this thread as it's off topic to my feature request.


Strip fragment identifier from all requests

Specification forbids the presence of fragment identifier in any request URIs.

This is done on the server during request handling. It still needs to be done for the client.

This has been moved into RequestURI itself, so it'll be done automatically for both servers and clients.


Experiment segmentation rules "contains" etc.

Currently part of the segmentation rule feature in the UI is broken: After we rolled back Hyrule last year it went unnoticed that some of the features, e.g. segmentation rules like "contains", are not supported by the version we use.
To do: Get the newer Hyrule version performance tested and built back into the system (and open source it?) or remove those rules from the UI rule builder.

Resolved by #90


launchQemu: Add runvpid to args

Put runvpid to "-pidfile" will not affect qemu because qemu will use the second "-pidfile" and ignore the first one.
It will be shown in cmd line of qemu that will help admin to make clear the qemu is current hyperd or the crashed hyperd.

Is it possible to use a different argument?

OK, I will try another one.


update wiki

add a description of the log files (save output of tests as csv-file) to the "testing procedure"-page

add figures from manuscript to wiki (e.g. structure of repository and adding new contributions).


[Bug]: No Output / Output doesn't show with Version 2.7.3

Short bug description
any php code that outputs to the console doesn't show
Extended bug description
No response
Your project is not the problem

[X] I tried using a fresh laravel install - I'm fairly certain it has nothing to do with my project.

How to reproduce?
<?php

echo 'Hello World';

when i run the above code, I can't see any output.
Expected behavior
i expect to see Hello World printed out.
Screenshots

IDE & Version
2024.2.4
PHP Version
8.2.24
OS and version
Mac OS
Laravel Tinker plugin version
2.7.3
Interpreter type
Local
Laravel Version
v10.48.12
Tinker version
v2.9.0
Psysh version
v0.12.4
Additional Context
No response

I have the same issue.
When I only write 'Hello world'; I get the same result:

same issue

same issue here. on phpstorm 2024.3, same plugin version


Fix App Bar scroll issue

Summary
This PR makes it so the App Bar only scrolls when elements are overflowing. The scroll issue seems to be a regression introduced by https://github.com/mattermost/mattermost-webapp/pull/11019
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-49255
Release Note
NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

There is currently an issue with this PR where the icons have moved left a bit when the overflow-y property is applied. @calebroseland Do you have any ideas of how to fix this issue?
https://user-images.githubusercontent.com/6913320/214465225-067d61d9-0032-4cfd-b349-2bccf4083344.mov

@calebroseland Thanks so much for your help. I've updated the PR with your suggested changes and it works as intended now :+1:

/update-branch

/update-branch

/update-branch

/update-branch

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard


Add segment x, y, z coordinates and radii features

This solves #288 and it is crucial for the simplification of plotting and constructing more complex measurements.

Current coverage is 100.00%

Merging #289 into master will not affect coverage as of dcf61b6

@@            master    #289   diff @@
======================================
  Files           42      42
  Stmts         1830    1843    +13
  Branches         0       0
  Methods          0
======================================
+ Hit           1830    1843    +13
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of dcf61b6

Powered by Codecov. Updated on successful CI builds.

Seems fine to me!

I think it would be much simpler to calculate the "position" of a segment as the 3D mean of its two points, and maybe add helper functions to extract X, Y, and Z. Having three separate functions everywhere seems like too much. For example
def segment_position(seg):
    return (seg[0][:COLS.R] + seg[1][1:COLS.R]) / 2.

Then, if you really want separate "features" for each coordinate, then it is three loops.

For what I need those functions, the three coordinates need to be separated. I don't want to do all the calculations each time I only need the projection in x for example, that's why I disconnect the coordinates.

OK. It looks like a lot of code for something really simple. I will merge it and try to reduce it later.

Yes, that's True. I just want to avoid expensive calculations in intermediate steps that will not be used in the final step. If you have a better alternative please go ahead and simplify it.


Unknown card type Decodable fix

📲 What
This PR was meant to support unknown strings coming from the card type in GraphQL, but unfortunately only actually supported null types's.
🤔 Why
It turns out that Swift's standard Decodable conformance for optional enums surprisingly causes deserialization to fail if the raw value does not match a case (instead of setting the enum to nil). Why? We'll probably never know because we don't know how Swift's default Decodable implementation works under the hood, which is frustrating. A theory is that since init(from decoder) is not a failable initializer, it can't actually (validly) return nil, so it's only option is to throw when it can't generate a case from the associated value. The solution is to override init(from decoder) for the CreditCardType enum to manually handle decoding, setting the enum to .generic when an unknown string value is used.
🛠 How
Override CreditCardTypes init(from decoder) and return .generic if initialization with the associated string fails. Also added the missing test that would have caught this.
👀 See

✅ Acceptance criteria

[ ] Add a union pay card on staging web. Navigate to payment methods screen on iOS: stored cards should all display correctly, with the union pay card showing the "generic" treatment

 Payment methods screen should handle unknown cards correctly


Rename private_attributes -> private on swagger

Renata Topology.Node.Port.private_attributes to private, which was left behind.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.056%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
1221

Relevant Lines:
1500

💛  - Coveralls


Prefer IPv6 if available

📑 I have found these related issues/pull requests
Not related
🏷 Feature Request Type
Deployment
🔖 Feature description
Allow for IPv6 usage for things like the notifications. For example ntfy.sh is reachable over IPv6 (I am using DNS64 so a valid AAAA record is returned) however my container's IPv4 is not routable because I run IPv6 only, but that means that it (your app) should then try IPv6 records
✔ Solution
Mentioned above
❓ Alternatives
No
📝 Additional Context
No response

What I really want is, if I insert a hostname for an HTTP/TCP or whatever check, let me specify that I want to test against the IP resolved via either A or AAAA record.

V2.0 will ship with a newer version of nodejs. See #4500 for what is currently blocking said release.
Given that newer versions of node have implemented happy eyeballs V2, I don't think this is an issue any more.
=> Going to close that part of the issue as likely resolved. (I have not verified nodes implementation, but if they claim to be spec compliant, that is likely enough)
Selecting the IP family is not possible in current versions of nodejs. See https://github.com/louislam/uptime-kuma/issues/1242 for a ore in-depth discussion.
=> Let's not open a duplicate on that one

V2.0 will ship with a newer version of nodejs. See #4500 for what is currently blocking said release. Given that newer versions of node have implemented happy eyeballs V2, I don't think this is an issue any more. => Going to close that part of the issue as likely resolved. (I have not verified nodes implementation, but if they claim to be spec compliant, that is likely enough)
Selecting the IP family is not possible in current versions of nodejs. See #1242 for a ore in-depth discussion. => Let's not open a duplicate on that one

Happy Eve-ballin will be fine then, dankie! Much appreciated


Add to a Client Area already done

I made a Client Area, but it does not contain this. Could it be added as a php page without doing everything again?

Please note that this project is a library. It doesn't include any "pages" which you can add to a website.
I don't know if you already have code to connect to MyOwnFreeHost, and I can't decide for you whether you want to use this API client or build/keep your own API wrapper.

That's entirely up to you and your code! If your code is structured in a way you can easily replace the netcode with this client, then you can. If the code is structured in a way you need to change everything to use this client, then you are essentially rebuilding everything.
Seriously, this is an API client. I can't make architectural decisions for your code.

Thanks :D


fix race condition of map access

Codecov Report

Merging #347 (57326ad) into master (03d64db) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

:exclamation: Current head 57326ad differs from pull request most recent head aa96ff7. Consider uploading reports for the commit aa96ff7 to get more accurate results

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   72.79%   72.71%   -0.09%
==========================================
  Files          44       44
  Lines        9389     9397       +8
==========================================
- Hits         6835     6833       -2
- Misses       1818     1826       +8
- Partials      736      738       +2

Impacted Files
Coverage Δ

config/config.go
91.27% <33.33%> (-2.52%)
:arrow_down:

worker/worker.go
63.40% <75.00%> (+0.08%)
:arrow_up:

master/task_manager.go
88.23% <0.00%> (-3.68%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d64db...aa96ff7. Read the comment docs.


[Feature Request] Support S3 Snapshot Repositories

Feature Description
We would like to backup our elasticsearch to S3. In order to use the provided snapshot repository functionality, we require an additional/different parameters for setting S3 bucket etc.
https://www.elastic.co/guide/en/elasticsearch/plugins/6.3/repository-s3-repository.html

Thanks for the submission, @roock!
/cc @fatmcgav since you provided the implementation for snapshot repositories, adding this feature may be of interest to you 😄

We'd also be interested in this. Making the "location" parameter optional and adding a parameter for custom "settings" parameters would likely enable a number of different repository options.


Scheduled etcd snapshots are not uploaded to S3, only manual ones

Environmental Info:
K3s Version:
k3s version v1.26.4+k3s1 (8d0255af)
go version go1.19.8

Node(s) CPU architecture, OS, and Version:
Linux k8s01 5.15.0-71-generic #78-Ubuntu SMP Tue Apr 18 09:00:29 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Cluster Configuration:

3 server nodes

Describe the bug:
When I configure an S3 target for etcd snapshots, I can confirm the setting is actually working by creating a manual snapshot via k3s etcd-snapshot save. Still, for the scheduled snapshots (etcd-snapshot-schedule-cron setting) the snapshots are not uploaded to the S3 bucket and remain local.
Steps To Reproduce:

Install k3s using HA etcd setup
Add the following configuration and restart k3s afterwards

# /etc/rancher/k3s/config.yaml.d/etcd-backup.yaml
etcd-s3: true
etcd-s3-access-key: <my-access-key>
etcd-s3-secret-key: <my-secret-key>
etcd-s3-bucket: <my-etcd-backup-bucket>
etcd-snapshot-schedule-cron: "0 /6 * * *"

Expected behavior:

Manual etcd snapshots (k3s etcd-snapshot save) are uploaded to configured s3 bucket
Scheduled etcd snapshots are uploaded to configured s3 bucket

Actual behavior:

Manual etcd snapshots (k3s etcd-snapshot save) are uploaded to configured s3 bucket
Scheduled etcd snapshots are not uploaded to configured s3 bucket and remain local

I'm unable to reproduce this. What do the logs say when taking scheduled snapshots?

I have the same issue. My cluster (3 controllers, 5 worker nodes) was already initialised (originally k3s v1.19 and upgraded through each major version to 1.27.3).
I recently set up a minio instance and added the following to /etc/rancher/k3s/config.yaml:
etcd-snapshot-schedule-cron: " */1 * * *"
etcd-s3: true
etcd-s3-endpoint: minio.REDACTED.com
etcd-s3-access-key: REDACTED
etcd-s3-secret-key: REDACTED
etcd-s3-bucket: kubernetes-etcd-backup
etcd-s3-region: eu-west-2

I have also modified the k3s systemd service ExecStart to  this:
ExecStart=/usr/local/bin/k3s server --data-dir /var/lib/rancher/k3s --disable servicelb --write-kubeconfig-mode 644 --server https://<IP_ADDRESS>:6443 --token REDACTED::server:REDACTED --etcd-s3 --etcd-s3-endpoint minio.REDACTED.com --etcd-s3-access-key REDACTED --etcd-s3-secret-key REDACTED --etcd-s3-bucket kubernetes-etcd-backup --etcd-s3-region eu-west-2 --etcd-snapshot-schedule-cron '0 */1 * * *'
And bounced all 3 of the k3s servers.
Running sudo k3s etcd-snapshot save results in:
WARN[0000] Unknown flag --etcd-snapshot-schedule-cron found in config.yaml, skipping
INFO[0000] Managed etcd cluster bootstrap already complete and initialized
INFO[0000] Applying CRD helmcharts.helm.cattle.io
INFO[0000] Applying CRD helmchartconfigs.helm.cattle.io
INFO[0000] Applying CRD addons.k3s.cattle.io
INFO[0000] Creating k3s-supervisor event broadcaster
INFO[0000] Saving etcd snapshot to /var/lib/rancher/k3s/server/db/snapshots/on-demand-elt-k8s-3-1690300712
{"level":"info","ts":"2023-07-25T15:58:32.258Z","caller":"snapshot/v3_snapshot.go:65","msg":"created temporary db file","path":"/var/lib/rancher/k3s/server/db/snapshots/on-demand-elt-k8s-3-1690300712.part"}
{"level":"info","ts":"2023-07-25T15:58:32.260Z","logger":"client","caller":"v3@v3.5.7-k3s1/maintenance.go:212","msg":"opened snapshot stream; downloading"}
{"level":"info","ts":"2023-07-25T15:58:32.260Z","caller":"snapshot/v3_snapshot.go:73","msg":"fetching snapshot","endpoint":"https://<IP_ADDRESS>:2379"}
{"level":"info","ts":"2023-07-25T15:58:32.447Z","logger":"client","caller":"v3@v3.5.7-k3s1/maintenance.go:220","msg":"completed snapshot read; closing"}
{"level":"info","ts":"2023-07-25T15:58:32.475Z","caller":"snapshot/v3_snapshot.go:88","msg":"fetched snapshot","endpoint":"https://<IP_ADDRESS>:2379","size":"41 MB","took":"now"}
{"level":"info","ts":"2023-07-25T15:58:32.476Z","caller":"snapshot/v3_snapshot.go:97","msg":"saved","path":"/var/lib/rancher/k3s/server/db/snapshots/on-demand-elt-k8s-3-1690300712"}
INFO[0001] Saving etcd snapshot on-demand-elt-k8s-3-1690300712 to S3
INFO[0001] Checking if S3 bucket kubernetes-etcd-backup exists
INFO[0001] S3 bucket kubernetes-etcd-backup exists
INFO[0001] Uploading snapshot /var/lib/rancher/k3s/server/db/snapshots/on-demand-elt-k8s-3-1690300712 to S3
INFO[0001] S3 upload complete for on-demand-elt-k8s-3-1690300712
INFO[0001] Reconciling etcd snapshot data in k3s-etcd-snapshots ConfigMap
INFO[0001] Reconciliation of snapshot data in k3s-etcd-snapshots ConfigMap complete

Scheduled snapshots however only appear hourly on disk:
/var/lib/rancher/k3s/server/db/snapshots
total 405436
drwx------ 2 root root     4096 Jul 25 16:00 .
drwx------ 4 root root     4096 Jul 24 15:46 ..
-rw------- 1 root root 53616672 Jul 25 12:00 etcd-snapshot-elt-k8s-1-1690286402
-rw------- 1 root root 35315744 Jul 25 13:00 etcd-snapshot-elt-k8s-1-1690290003
-rw------- 1 root root 60551200 Jul 25 14:00 etcd-snapshot-elt-k8s-1-1690293603
-rw------- 1 root root 50847776 Jul 25 15:00 etcd-snapshot-elt-k8s-1-1690297204
-rw------- 1 root root 42434592 Jul 25 16:00 etcd-snapshot-elt-k8s-1-1690300801

Not sure if this is related or another issue but calling the adhoc snapshot save from each of the servers result in snapshots of different sizes:

They all verify fine so not sure if this maybe related to running the snapshots manually on each server - resulting in the etcd-snapshot config map being updated between each of nodes actually saving the snapshot.

Found my issue. For some reason I hadn't updated my endpoint URL correctly. It's now working as expected/designed.
Re the 3 simultaneous snapshots resulting I. Differing sizes, I realise this is not an issue. However, that said; to reduce the load on the minio server while still snapshotting every 2 hours, I have staggered my Cron across the 3 servers:
"0 */6 * * *"
"0 2/6 * * *"
"0 4/6 * * *"
This means I do not end up with all 3 servers snapshotting simultaneously resulting in 3 files/objects every 2 hours.


feature request: Modelica syntax highlight

I am programming in Modelica and would like to add syntax highlight for it.
Modelica is already listed on CodeMirror:
http://codemirror.net/mode/modelica/index.html
so adding syntax highlight should be not too hard, BUT: the file extension for Modelica source code files is *.mo, the same as gnu gettext binary files, so marking all mo files as Modelica might break some things for some people (see https://github.com/github/linguist/issues/119 )
Same thing might happen for other extensions, e.g. *.n files might be Nemerle code (text) or Neko applications (binary).
How should this be treated? Does this case have to be treated somehow?
On https://github.com/adobe/brackets/wiki/Language-Support I could not find how to treat this case (or did I just miss it?).

@thorade The "mo" file extension is not yet defined in Brackets so Modelica will be easy to add to Brackets.
I don't think Modelica support will be added to BraCkets core code any time soon, so you should write an extension to do this. The Defining a New Language section of Language Support wiki page explains how to do it.
Comt to the brackets-dev forum or #brackets chat room on IRC if you have any questions.
Closing as an extension idea.


Disable secureGrpc if sidecar is used for control plane mTLS

Signed-off-by: Shakti<EMAIL_ADDRESS>We would want Pilot's secureGrpc to be disabled when mTLS is enabled using Pilot sidecar option. secureGrpc: "" is currently skipped entirely from args if controlPlaneSecurityEnabled is true but sidecar is used for mTLS.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[X] Configuration Infrastructure
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Hi @shakti-das. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/okay-to-test

/ok-to-test
This does not change any behavior.

@shakti-das: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-racetest-master
cc983d6b5ff6d36814df66dee57a003436307f9a
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-racetest-master

/cherrypick release-1.3

@rshriram: new pull request created: #16881

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Add CITATION file

Add CITATION.cff which includes all authors of candidate models. It is identical to the list of authors attached to the IGRF coefficients release in progress on Zenodo

Excellent. I hope there was an easy way to generate the list


Timeout on remote exec

Issue summary

While deploying node or snapshot services, Terraform seems to have had an issue with SSH connectivity.
There are a few possible culprits:

Digital Ocean issues,
too low timeout in provisioning (can it be extended?),
logic error somewhere,
something else.

This may create zombie instances where the initialization script was not run.
It'd be great to resolve the root issue, but automatically retrying a few times is also acceptable as a workaround.
Other information and links

can definitely remove timeout.


README.md: updates under Teaching and Self-care section

I realized there was no point dedicated to handling the conflict that can happen
when ones ideas are critized, which is a big part of the game.
Therefore I suggest adding:

How to handle negative feedback

I also realized that under statistics, chi-squared tests are super popular.
Therefore I suggest adding:

How to understand what chi-squared tests are about

Sorry, this PR fell under the table!!
VERY much agree on the negative feedback thing - I would've never imagined how crushing a negative wrong review can be.
Just put this book onto my to-read list, we'll see :)


ServiceAccount Token Mount Violates FHS 5.13. /var/run

Referencing these two closed tickets as well
https://github.com/tektoncd/pipeline/issues/2738
https://github.com/tektoncd/pipeline/issues/2726
Expected Behavior
FHS
https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s13.html
ServiceAccount Token should mounted to /run and not /var/run
Actual Behavior
The service account tokens are mounted to /var/run
Steps to Reproduce the Problem

Reference a service account

spec:
    serviceAccountName: build-bot

Check pod for mount /var/run/secrets/kubernetes.io/serviceaccount from build-bot-token

Additional Info
This majorly impacts alpine based images as well as other installs that use the /var/run location as tmpfs.

Tekton Pipeline version:

Client version: 0.21.0
Pipeline version: v0.32.0
Triggers version: v0.18.0
Dashboard version: v0.23.0

Hey @spencerrung, thanks for the issue. As fare as I know, this is kubernetes behavoior (see https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/). I don’t think there is too much tekton can do there.

Closing, I don't think there's anything for Tekton to do here.


BUG: Flatten SciPy lil_matrix without converting to dense to avoid memory error

Describe your issue.
I would like to flatten my sliced array without converting it to dense in order to avoid memory error:
For smaller sizes, I can simply do mtx.getrowview(0).toarray().flatten() but for larger sizes, I do not want to convert to dense.
What is the easy and memory efficient approach to flatten a scipy sparse lil_matrix?
Reproducing Code Example
import numpy as np
import scipy
print(np.__version__, scipy.__version__) # numpy: 1.23.5 scipy: 1.11.3

mtx = scipy.sparse.lil_matrix((int(2e8), int(4e9)), dtype=np.float32) # very large lil_matrix
flat_mtx = mtx.getrowview(0).flatten() # sliced example: row: 0

Error message
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'lil_matrix' object has no attribute 'flatten'

SciPy/NumPy/Python version and system information
>>> import sys, scipy, numpy; print(scipy.__version__, numpy.__version__, sys.version_info); scipy.show_config()
1.11.2 1.26.1 sys.version_info(major=3, minor=9, micro=12, releaselevel='final', serial=0)
Build Dependencies:
  blas:
    detection method: pkgconfig
    found: true
    include directory: /usr/local/include
    lib directory: /usr/local/lib
    name: openblas
    openblas configuration: USE_64BITINT= DYNAMIC_ARCH=1 DYNAMIC_OLDER= NO_CBLAS=
      NO_LAPACK= NO_LAPACKE= NO_AFFINITY=1 USE_OPENMP= HASWELL MAX_THREADS=2
    pc file directory: /usr/local/lib/pkgconfig
    version: 0.3.21.dev
  lapack:
    detection method: pkgconfig
    found: true
    include directory: /usr/local/include
    lib directory: /usr/local/lib
    name: openblas
    openblas configuration: USE_64BITINT= DYNAMIC_ARCH=1 DYNAMIC_OLDER= NO_CBLAS=
      NO_LAPACK= NO_LAPACKE= NO_AFFINITY=1 USE_OPENMP= HASWELL MAX_THREADS=2
    pc file directory: /usr/local/lib/pkgconfig
    version: 0.3.21.dev
  pybind11:
    detection method: config-tool
    include directory: unknown
    name: pybind11
    version: 2.10.4
Compilers:
  c:
    commands: cc
    linker: ld.bfd
    name: gcc
    version: 10.2.1
  c++:
    commands: c++
    linker: ld.bfd
    name: gcc
    version: 10.2.1
  cython:
    commands: cython
    linker: cython
    name: cython
    version: 0.29.36
  fortran:
    commands: gfortran
    linker: ld.bfd
    name: gcc
    version: 10.2.1
  pythran:
    include directory: ../../tmp/pip-build-env-ucip512m/overlay/lib/python3.9/site-packages/pythran
    version: 0.13.1
Machine Information:
  build:
    cpu: x86_64
    endian: little
    family: x86_64
    system: linux
  cross-compiled: false
  host:
    cpu: x86_64
    endian: little
    family: x86_64
    system: linux
Python Information:
  path: /opt/python/cp39-cp39/bin/python
  version: '3.9'

I will take this as a request for a 1d sparse array.
Note that A.getrowview(j) gets the jth row as a sparse matrix. So it is most of what you want, but not a 1d array.
What features of a 1d array do you need? You might be able to get them from the 1xN sparse matrix object.
There is currently some progress on a 1d-sparse-array.  #18530 is a start toward that goal.
It might help me to know what aspects of being flat you want.
Iteration over values? Ability to reshape?  We're definitely including those.
Are there other features you want the flattened slices to have?

@dschult I actually have an sparse matrix with this specification:
#sp_mtx  # load my sparse matrix from disk
print(f"{type(sp_mtx)} {sp_mtx.shape} {sp_mtx.dtype} byte size[count]: {sum([sys.getsizeof(i) for i in sp_mtx.data])/1e6:.2f} MB")
<class 'scipy.sparse._lil.lil_matrix'> (162837, 26515902) float32 byte size[count]: 4316.62 MB

and would like to iterate over each row for some customized mathematical operations, e.g., multiplications, divisions and sum.
Therefore, I though flatten could be easily done in order to apply multiplication to another numpy 1D array for instance.
Right now, I can do np.squeeze(sp_mat_pkl.getrowview(0).toarray()) which is faster than normal .flatten() but I thought it'd be nice to have the method directly from scipy sparse rather than converting to dense first and then squeeze or flatten.

If all you're doing with each row is math, then I would recommend converting your sparse matrix to CSR format (sp_mat_pkl.tocsr()). This format has the best support for arithmetic as well as row-wise operations. You may be able to avoid explicitly iterating over rows entirely.
As this is more of a usage question rather than a bug report, I'll close this now.


Version inconsistent problem

Hello @thesmart ,
I am the member of cdnjs project.
We want to host this library.
Please help me confirm the version on github.
I saw the version of scrollspy.js is 0.1.2 in the release of 0.1.3.
Thanks!
https://github.com/cdnjs/cdnjs/issues/8520

Hi, yes the latest version branch should be best. That is a typo, and I
didn't think it would be worth a new version commit to fix. :-/
On Thursday, July 14, 2016, naoh<EMAIL_ADDRESS>wrote:

Hello @thesmart https://github.com/thesmart ,
I am the member of cdnjs https://github.com/cdnjs/cdnjs project.
We want to host this library.
Please help me confirm the version on github
https://github.com/thesmart/jquery-scrollspy.
I saw the version of scrollspy.js is 0.1.2 in the release of 0.1.3.
Thanks!
cdnjs/cdnjs#8520 https://github.com/cdnjs/cdnjs/issues/8520
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/thesmart/jquery-scrollspy/issues/23, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AARJLTzqSXgxEcZXyVevHihrU-lFWl_Pks5qVvHTgaJpZM4JNBmC
.


[FEATURE] Merge Authentication for different types of user

Description
So currently we have two different types of user. One of them is the normal user or individual and the other one is basically any kind of club charity or organization.
Now the issue is it consists of a lot of different duplicacies like managing different states,  calling separate API's and so on.  If you would visit the Club Registration and the User registration, you would notice that a lot of fields are the same like Name , Address, Pincode and so on.
So it would be much better if we can merge these 2 types of authentication into 1 single page. Here's what that are to be done.

Merge authentication such that instead of that modal being open whenever we click on Sign up  it takes us to https://milanhub.org/user/register
Inside of the authentication page we can have maybe a drop down which suggests what type of user is this.
Based on that dropdown field we can then show/hide different forms.

Screenshots

🥦 Browser
Opera
Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[ ] I am willing to work on this issue (blank for no)

Hey @tamalCodes I'd like to work on this issue.

📚 Info

[!NOTE]
Branch to make a PR/Fork would be the beta

Hi @VanshVg , you can start working on the issue. Assigning it to you.  Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.
📑 Checklist

Setup Guide to understand the setup and the .env(s) for development locally.
Contribution Guide to understand what type of PRs are accepted and how to make them.
Workflow Guide to understand what goes behind the scene, and why your PR doesn't get merged immediately.

Do drop a star, Happy Opensource 💚

Yes, I have opened a PR now you can review it.


Added info on CMD

Added some info on CMD, as the file was blank

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Reason:  We do not allow plagiarized content (from Wikipedia).
Thank you and happy coding.


feat(dynatron): updater changes

Thank you for the PR. A solution for this implemented a bit differently has been added in version 5.


Change deprecated babel-preset-es2015-webpack module on babel-preset-es2015

This shouldn't be relevant anymore.


phpBB.com and all subsites might be unavailable due to power maintenance

Our hosting provider has informed us that there might be a power outage on some network equipment causing our sites to be unavailable during a 8 hour timeframe. During this time, all of phpbb.com might be unavailable.
This outage only involves websites under the phpBB.com subdomain. Non phpBB.com sites should keep working.

Our hosting provider has informed us that there might be a power outage on some network equipment causing our sites to be unavailable during a 8 hour timeframe. During this time, all of phpbb.com might be unavailable.
This outage only involves websites under the phpBB.com subdomain. Non phpBB.com sites should keep working.


Sonos not visible in Home Assistant after switch to Docker on other Vlan

Home Assistant release with the issue: 0.74.2
Last working Home Assistant release (if known): Hass on Rpi
Operating environment (Hass.io/Docker/Windows/etc.): Docker with separate vlan (Macvlan) for Home Assistant
Component/platform: Sonos / Mediaplayer
Description of problem:
Was using Hass.io on Rpi3 for a long time, but now switched to Docker.
The Rpi was running on the same vlan as my Sonos devices, but now with Docker, Home Assistant is running on another vlan.
The problem is that now my Sonos devices are not visible in Home Assistant. I can ping the Sonos from the Home assistant container and it seems like Home Assistant can find the Sonos devices, but they don't show up as a media player
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
sonos:
  media_player:
    hosts:
      - <IP_ADDRESS>
      - <IP_ADDRESS>
      - <IP_ADDRESS>
      - <IP_ADDRESS>
      - <IP_ADDRESS>
      - <IP_ADDRESS>

(Home assistant is running on 10.0.40.X vlan, but they can ping to each other)
Logs:
2018-07-30 11:35:53 INFO (MainThread) [homeassistant.setup] Setup of domain media_player took 18.8 seconds.
2018-07-30 11:35:53 INFO (MainThread) [homeassistant.core] Bus:Handling <Event component_loaded[L]: component=media_player>
2018-07-30 11:35:53 INFO (MainThread) [homeassistant.loader] Loaded media_player.cast from homeassistant.components.media_player.cast
2018-07-30 11:35:53 INFO (MainThread) [homeassistant.loader] Loaded media_player.sonos from homeassistant.components.media_player.sonos
2018-07-30 11:35:53 INFO (MainThread) [homeassistant.components.media_player] Setting up media_player.cast
2018-07-30 11:35:53 INFO (MainThread) [homeassistant.components.media_player] Setting up media_player.sonos
2018-07-30 11:35:53 DEBUG (SyncWorker_38) [homeassistant.components.media_player.cast] Starting internal pychromecast discovery.
2018-07-30 11:35:54 DEBUG (SyncWorker_20) [homeassistant.components.media_player.sonos] Added 6 Sonos speakers

I think I made the mistake of adding the IP of my sub. When I remove this IP from the list, I can see all my Sonos devices.


Manually brought back the PL 804xx release notes (reverting the rever…

…ted PR did not work because of several conflicts). Also updated the description for PL-38949, sent by Brian.
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

This PR was reviewed earlier and reverted to accommodate delays in the deployment of 804xx. I've simply "reverted the revert", albeit manually. I don't think we need a peer review on this PR. Forcing a merge.


How to get request payload?

Hi,
I am calling an ajax post. How can I get the payload data at the Service? Am I missing something or do I have to implement my own Request?

Thanks for the report! Right now though this is just a proof-of-concept library which doesn't support bodies of HTTP requests/responses, but for a "real" HTTP I'd recommend hyper


Rename network to 'default'

So it is compatible with cloud-config's values.
Useful when using bosh-dev.yml to install bosh with bosh

seems already covered by https://github.com/cloudfoundry/bosh-deployment/commit/96640c38d11f472f0ccbc89fdf11a95d73e7fbbd


leader election: increase the log level of successfully renewer lease

The current log level (4) floods over things that are actually of note during debugging.
What this PR does / why we need it:
Setting log level to 4 uncovers some important information that gets drowned in renewed lease messages coming every second. Although it is something worth debug-logging, it isn't even a significant state change - thus I'd like to move it to the higher log level for improved clarity.

We use an external library client-go/leaderelection provided by k8s for leader election.
This pull changes vendored code so it will not survive updates :). If you want to change the log level, there is no other way than opening a pull request upstream :)

I would love to get rid of those messages but changing code in vendor is not an option.
You would need to create a PR upstream:https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/leaderelection/leaderelection.go

Riiiiight, missed that.


Compile for Mac/Linux/Windows automatically with releases

Ink-Proof's dependency install script downloads pre-compiled versions of each runtime for each operating system. To integrate into the official version of Ink Proof, Blade Ink would probably need to make executable versions of itself available online to download, across Linux, Mac and Windows. I'm guessing there'd be a way to do this with a github action every release, but I haven't looked into it.

Yes, I will create ASAP a GHA to automatically upload the package to crates.io and upload the binary binkplayer for differrent os to the release.

Created GHA to compile and upload binkplayer to the release, the action also uploads the packages to crates.io.
The release v1.0.1 has been created with the executables for win, mac and linux.

I've sent a PR to Ink Proof for v1.0.1.


feat: show formatted date instead of epoch on results

SUMMARY
When pressing "View results" on Explore View, the primary temporal column is displayed as epochs. This applies a typical %Y-%m-%d %H:%M:%S format to the __timestamp column to make the results slightly more legible.
BEFORE

AFTER

TEST PLAN
CI + new tests
ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Does this table use the new chart data API? What about other datetime columns? If I'm understanding the code right, all datetime columns will return epochs? I think it would be best if the new API response payload will include data type info, what do you think?
And how about replacing this table with the TableChart? There seems to be some overlapping work here.

@ktmud this is only being used on the DisplayQueryButton on Explore View to show what data is coming from the backend. It's being used to display whatever data is coming back from both the legacy and new chart data endpoint. I also believe it doesn't know any context about datatypes, so this is just a quick fix to make chart/data debugging slightly easier.

Oh sorry @ktmud , I hadn't seen that PR, cool! Yeah, let's use that info once that PR gets merged!

Hi guys, i'm pretty new to Superset and have recently upgraded to superset 1.1 and i am getting the UNIX timestamp in filter box. Could you please suggest how to resolve it.

Same problem here

@PiyushGupta3108 @musthak24 this is a known limitation of Filter Box. Since Filter Box is in the process of being deprecated, and the native value filter properly formats timestamps, I don't expect this to be fixed. If you want to enable native filters, just enable the DASHBOARD_NATIVE_FILTERS feature flag in your superset_config.py.


Install cargo on client's release docker image

Description
Install cargo on client's release docker image required for publishing rust clients
Issues Resolved
Related #3247
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #3422 (d164f5b) into main (c5e7217) will decrease coverage by 0.29%.
The diff coverage is n/a.

:exclamation: Current head d164f5b differs from pull request most recent head da03591. Consider uploading reports for the commit da03591 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
- Coverage   91.74%   91.46%   -0.29%
==========================================
  Files         172      172
  Lines        4991     4991
==========================================
- Hits         4579     4565      -14
- Misses        412      426      +14

see 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Remove provides ingredient

Codecov Report

Merging #160 into master will decrease coverage by 0.29%.
The diff coverage is 94.11%.

@@            Coverage Diff            @@
##           master     #160     +/-   ##
=========================================
- Coverage   83.07%   82.77%   -0.3%
=========================================
  Files         120      120
  Lines        2866     2857      -9
  Branches      144      141      -3
=========================================
- Hits         2381     2365     -16
- Misses        485      492      +7

Impacted Files
Coverage Δ

...ng/baker/recipe/common/InteractionDescriptor.scala
100% <ø> (ø)
:arrow_up:

...scala/com/ing/baker/recipe/common/Ingredient.scala
66.66% <ø> (ø)
:arrow_up:

...in/scala/com/ing/baker/recipe/common/package.scala
100% <100%> (ø)
:arrow_up:

...in/scala/com/ing/baker/recipe/scaladsl/Event.scala
100% <100%> (ø)
:arrow_up:

...g/baker/recipe/javadsl/InteractionDescriptor.scala
55.26% <100%> (-3.28%)
:arrow_down:

.../scala/com/ing/baker/recipe/scaladsl/package.scala
100% <100%> (ø)
:arrow_up:

...n/scala/com/ing/baker/recipe/javadsl/package.scala
92.3% <100%> (-1.45%)
:arrow_down:

...rc/main/scala/com/ing/baker/compiler/package.scala
100% <100%> (ø)
:arrow_up:

.../scala/com/ing/baker/compiler/RecipeCompiler.scala
100% <100%> (ø)
:arrow_up:

...la/com/ing/baker/recipe/scaladsl/Interaction.scala
100% <100%> (ø)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bbf96c...6dc7b13. Read the comment docs.


Scanner: How to upgrade scan-code version from ORT

Scanner: We realized that ORT is running with year old version of scan-code. How to upgrade scan-code version from ORT to its latest version (scan-code)?

@porsche-rishisaxena  We will be soon upgrading to the latest version of ScanCode currently doing upgrade tests, but if you have locally or in your Docker image have newer version of ScanCode the ORT will use it.

Thank you @tsteenbe for the providing an update. Would you be so kind to provide some more insight to scan-code version upgrade in context to timelines?

@porsche-rishisaxena  It's currently being worked on, expect at the latest last week of August if all goes well

@tsteenbe I'd be interested in what HERE is doing in the ScanCode upgrading context to maintain compatibility with existing scan results. That's a difficult topic, and one of the reasons why we didn't do the upgrade yet ourselves.

@tsteenbe Would you be so kind to provide more information on what version of scan-code is under testing for the upgrade?
We ran multiple test with different version of Scan-Code and the latest version of scan-code also result with a bug.
Reference: https://github.com/oss-review-toolkit/ort/issues/4295#issuecomment-892579247

Would you be so kind to provide more information on what version of scan-code is under testing for the upgrade?

See the draft PR at https://github.com/oss-review-toolkit/ort/pull/4324.

@tsteenbe: Is there any update on the progress or result from testing on the scan-code upgrade?

@porsche-rishisaxena With the merge of my latest PR (#4669) ORT does not require a specific ScanCode version anymore. We do not yet provide an easy way to build the Docker image with a different ScanCode version, but you could already fork this repository and replace the ScanCode version in the Dockerfile or create your own Dockerfile that inherits from ours.

We do not yet provide an easy way to build the Docker image with a different ScanCode version

This has been resolved meanwhile in https://github.com/oss-review-toolkit/ort/pull/4721, and upgrading ScanCode is now as easy as setting the SCANCODE_VERSION build argument when running docker build.


Synthwave 84 - user section and flyout stay gray

Not sure how to call them. These elements aren't changed by the theme.

Thanks @CapoFantasma97 ! i'll take a look at this!


sync between source and manifest

2-way sync or at least validation should be part of toolchain.
Web Component often has sufficient data in sources to generate manifest, hence there is ability to create match validators which are essential for release lifecycle:

minor vs major vs patch distinction and prevention on pre-release build level
generation of release notes

The singe source of truth would prevent the mismatch  between src and manifest.

when src is the base, it would generate the manifest
when manifest is base, it would generate the stub or interface to be extended by implementation.

The editors actually do not need to use manifest as info could be available in runtime of class implementation. But the listing of components, search and filtering would benefit from manifest format. Having runtime info and manifest in sync would prevent the editor misuse.

src >  manifest  is covered by @custom-elements-manifest/analyzer
Comparing the latest released manifest and package release semver with current code could be based on ^^ generator and Validator from this package.
Perhaps this conversation could be moved to @open-wc project as toolchain for web components is not in scope /webcomponents group?

I'm having a hard time following this. What's the issue with the schema?