change valueExpr to pingcap test_driver implements

fix valueExpr not work call Restore(ctx *format.RestoreCtx) #754

those code is from https://github.com/pingcap/parser/tree/master/test_driver


Default BeautifulSoup parser mangles DOCTYPEs

Input this HTML file into edit_code:
<!DOCTYPE html>
<html>
  <head>
  </head>
  <body>
  </body>
</html>

By default, BeautifulSoup will convert this into
<html>
 <body>
  <p>

   <!DOCTYPE html>
  </p>
 </body>
</html>

which is not valid HTML. Additionally, this then trips error #16.

Resolved in this CL.

Resolved in 65eccfa030c7e89c511accf202fb4ccd4d2cb006.


Pipeline shows active tasks even though pipeline is stopped

[ ] Correct task statuses in pipeline
[ ] Keep completed stateless tasks linked to the corresponding job

Issues with statuses

Stopped pipeline doesn't show task real state
Completed scaled-down (Streaming-Dynamic i.e.)


When allowInput is true, set the cursor back to text

Expected Behavior

When the input field is editable (allowInput = true), the cursor should not display as pointer, but rather as display.
Current Behavior

The inputs with flatpickr always use cursor: pointer.
Possible Solution

Add a class like flatpickr-allow-input to the input if allowInput is set to true.
Steps to Reproduce (for bugs)

See http://codepen.io/s-hoff/pen/EWZpoE?editors=1010. Hover over the input.
Context

Your Environment

Version used: 2.4.4
Browser Name and version: Chrome 54, IE 11
Operating System and version (desktop or mobile): Windows (desktop)

how about cursor not-allowed ? 👀


Merge webui publish fix + bump ipfs-api version

@krl can you merge this and push the new webui to go-ipfs?
//cc @jbenet @whyrusleeping

:+1: :fireworks: :smile: :+1: wooo!

LGTM. @diasdavid i'm good to ship this.
the tests... arent testing.

@jbenet done. Tests fail because the repo doesn't have any tests :(


Automated GUI - Proof of Concept

Hello to everyone,
this issue will be to discuss the possiblites to automate the GUI creation as mentioned here.

Since there are a lot of hand coded files, what do you think about an object attribute editor instead? I don't actually know if that will work as expected, but it would track user class modifications easily without the need to adapt the GUI.

Why not. I'm just not sure how it would work with the current GUI. The structure of the GUI enables to easily add new slots, magnets, conductor... which is mostly the new objects that contributor should add. But as we have the csv doc, I think that we should be able to generate automatically such GUI. So it is worth investigating.

What keeps me promising is the following blog post. http://trevorius.com/scrapbook/python/attribute-editor-in-pyqt/
@BonneelP: Could you tell me why machine.__dict__ return underscored attributes as keys, _rotor for instance, although I can access the rotor with machine.rotor (without underscore)?
Best regards,
Sebastian

Hello Sebastian,
The "_property" is linked to the class generator. The last part of the class file the getter and setter of the class. When accessing to a property we store them into "_property" instead of "property" to make sure that the getter is called. You can use "machine.as_dict( )" instead of "machine.dict" to get all the properties.
But I think that the csv documentation will be more helpful for the generation since we have the property and there corresponding type which would enable us to adapt the widget to the property.
Best regards,
Pierre


Testsuite: all tomcat versions are sharing the same config (and deployment)

This will eventually break, when tomcat adds features that are not supported by previous versions, similar to e.g. jakarta namespace for the deployment.
Ideally, these should have configuration and possibly deployments specific to them. Anyway, so far low priority / optional.

That's a good point. We might also just add a variable with the config file the same way we do it for the version.


Blocks all ports except 80 and 443

What Changed

Blocks all ports except 80 and 443

Why

To prevent malicious attacks on application servers

I don't know anything about ansible or deployment but this looks good to me, the only change here that I'm not sure how it's relevant is the rbenv removal

Yea, I'm just including that deletion of the rbenv config because it was breaking rbenv stuff in the past. They way it falls back to the default configs for zzet.rbenv ansible galaxy role


Add jinja2 time as default extension

:clock1:

Current coverage is 99.65%

Merging #653 into master will not affect coverage as of 825bf5a

@@            master    #653   diff @@
======================================
  Files           13      13
  Stmts          575     577     +2
  Branches         0       0
  Methods          0       0
======================================
+ Hit            573     575     +2
  Partial          0       0
  Missed           2       2

Review entire Coverage Diff as of 825bf5a

Uncovered Suggestions

+0.35% via ...ookiecutter/utils.py#27...28

Powered by Codecov. Updated on successful CI builds.

Can you please thumb this? @michaeljoseph @pydanny

lgtm :+1:


Fix invoking cargo without consulting CARGO env var or standard installation paths

Followup for #4329
The pr essentially fixes this bug
cc @lefticus

@matklad this should be good to go

Hm, I am not sure if this is conceptually the right fix here, I think we should move towards keeping only semantic info on the server, and replacing the bin with something like type.

It's not that bad since this is rust-analyzer crate in question and not something pure like ra_hir or ra_ide, but do you really want to move more code to the frontend :D?

I changed Runnable.bin -> Runnable.kind (type would be ugly because it is a non-contextual keyword in Rust).
@matklad this is ready to merge after your approval

boop @matklad

bors r+
I'll tweak the proto stuff myself afterwards though ;-)


use -f test to not only check they are non-empty but also that they point to valid files

I was afraid of setting these to the wrong things - I looked to see if the script will tell me if I set them incorrectly, and there really isn't a check done by these scripts to tell me that they are really pointing to what it expected (and that is - the kubeconfig file). The -z just checks to see that you set them - but you should also check that they at least point to a valid file (and not, say, an invalid file or a directory instead of a file).

/ok-to-test


fix outlet_id increment

Fix for #172 and more complete PR than #165.
It's not to my liking, but it works. I suppose there is a more elegant way to do it by reworking the logic inside the while loop.
The main issue was when inla_index < 8 was True for the before last basin (line 430) as it would add one to outlet_id there but also after at (line 462) when dir >= 0 was False.

Can be closed if #178 is merged.


How to calculate the loss during training.

I am not sure this question has been asked before. I searched the issues by keyword and could not find anything. I want to use this chamfer distance as the loss to train a network (more specifically, a pointnet-like autoencoder).
Currently, I am using it like this (based on the python version):
import dist_chamfer_2D
loss_chamfer = dist_chamfer_2D.chamfer_2DDist()
dist1, dist2, idx1, idx2 = loss_chamfer(x.permute(0, 2, 1), dec_y.permute(0, 2, 1))
loss = (dist1.min(dim=0)[0].mean()) + (dist2.min(dim=0)[0].mean())

Is this the correct way of using it?
However, the reconstructed result does not look good. I also tried to define the loss as:
loss = torch.sum(dist1) + torch.sum(dist2)

Which had a better overall qualitative result but still not as I expected.
The problem should not be hard, and I am trying to learn a representation for a simple 2D/3D point cloud (composed of squares and circles ).
Example below (blue is the original, red is the decoder output):

v1 is not work well most likely : you are sending gradient only to two points because of min()
v2 is reasonnable. People use a variant usually

loss = torch.mean(dist1**2) + torch.mean(dist2**2)


chore(main): release 0.6.9

:robot: I have created a release beep boop
0.6.9 (2023-09-20)
Dependency Updates

deps: bump github.com/onsi/ginkgo/v2 from 2.12.0 to 2.12.1 (#586) (2f23322)
deps: bump github.com/vektra/mockery/v2 from 2.33.2 to 2.33.3 (#585) (760f9b1)
deps: update ghcr.io/aquasecurity/trivy docker tag to v0.45.1 (#582) (e8af4fd)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/statnett/image-scanner-operator/releases/tag/v0.6.9 :sunflower:


Heroku is Over for torrent-web.

Any other platform to deply?

Interesting, is it explicitly banned?

Yes, deploy the app. It will be suspended in a few minutes. Even if you do not use it. Same happened to cloud-torrent last year.

I actually deployed with no issues today

Yeah, looks like it started working.

is it working?
can we download to our td?

@askfriends Dead for Heroku.


ci: add disruptive pod to IO soak test

WIP has a lot of refactoring changes required for
this to work

@chriswldenyer I am putting this up for preview. Maybe this largish change should be split into 2 parts.

Refactoring for namespace support.
Actual disruptive pod for IO soak change.

To be split into 2 sets of changes.


Url contains the port number when trying to access site

The problem is that when I try to access the site, it is forwarding the request to the SSL port and showing it in the url.  I've deployed other sites before without this problem.  The last one was dokku 4.2, and the site I'm currently using is dokku 4.3.  No idea if it makes a difference.  The site is hosted on digital ocean.  This is the config in /home/dokku/client/nginx.config
server {
  listen      [::]:80;
  listen      80;
  server_name client.app.takemyspot.ca;
  access_log  /var/log/nginx/client-access.log;
  error_log   /var/log/nginx/client-error.log;
  return 301 https://$host:20424$request_uri;
}

server {
  listen      [::]:20424 ssl spdy;
  listen      20424 ssl spdy;
  server_name client.app.takemyspot.ca;
  access_log  /var/log/nginx/client-access.log;
  error_log   /var/log/nginx/client-error.log;
ssl_certificate     /home/dokku/client/tls/server.crt;
ssl_certificate_key /home/dokku/client/tls/server.key;

  keepalive_timeout   70;
  add_header          Alternate-Protocol  20424:npn-spdy/2;
  location    / {

    gzip on;
    gzip_min_length  1100;
    gzip_buffers  4 32k;
    gzip_types    text/css text/javascript text/xml text/plain text/x-component application/javascript application/x-javascript application/json application/xml  application/rss+xml font/truetype application/x-font-ttf font/opentype application/vnd.ms-fontobject image/svg+xml;
    gzip_vary on;
    gzip_comp_level  6;

    proxy_pass  http://client;
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection upgrade;
    proxy_set_header Host $http_host;
    proxy_set_header X-Forwarded-Proto $scheme;
    proxy_set_header X-Forwarded-For $remote_addr;
    proxy_set_header X-Forwarded-Port $server_port;
    proxy_set_header X-Request-Start $msec;
  }
  include /home/dokku/client/nginx.conf.d/*.conf;
}
upstream client {
  server <IP_ADDRESS>:5000;
}

Everything is getting forwarded to the SSL's port.  I have another app running on the same server, the api, which is running fine and is showing the url without the port.

The port is shown because it's not the default SSL port of 443. This is standard browser behavior as far as I know. Did you intend for the SSL listener to be on a non-standard port?

I was just using the config that dokku had created.  On the other site using SSL, it is also split into a client and api.  One is using port 443, and the other is using a different port.  The one using the different port doesn't seem to cause forwarding.  I don't really care what ports they are using, as long as they are using SSL, and not letting the end user see a port in the url.

You'll only be able to hide the SSL port in a browser if it's running on the standard port of 443. To troubleshoot further you'll need to destroy the app exhibiting the issue and deploying again with dokku trace on. Check out our contributing doc and troubleshooting doc for more details on what info to include in an issue and how to turn on dokku trace.

I recreated it, and this time it seemed to set the SSL port to 443.  Maybe it was the order I was creating the app?
This is what I did this time:
dokku apps:create client
dokku domains:add client.app.takemyspot.ca
dokku certs:add client < /home/cert-key.tar
dokku config:set
Then locally I did:
git push
I know before I tried to enable nginx and do build-config, which I don't think was necessary.

Not enough info to say really. Good that it works now.


adoption requires cloud credentials

I ran make build and make deploy from the v1 branch. I then tried to "adopt" an existing cluster and got an error message about missing AWS credentials. Cloud credentials should not be required for adoption. I saw a similar message if I specified the cloud as "azure" or "gcp".
$ bin/hiveutil create-cluster --adopt --adopt-admin-kubeconfig=/tmp/cluster0.config --adopt-cluster-id=cluster0 --adopt-infra-id=cluster0 cluster0
ERRO[0000] Cannot load AWS credentials
ERRO[0000] Error                                         error="open /home/mhrivnak/.aws/credentials: no such file or directory"

I added --include-secrets=false to the command and that enabled it to succeed. That causes the create command to skip this block of code, which tries to get the cloud credentials by calling o.cloudProvider.generateCredentialsSecret(o)

Cloud credentials are required for Hive to manage a cluster. The credentials are not used solely during provisioning: The credentials are used for on-going operations and for de-provisioning as well.

The docs describe adopting a "kind" cluster for dev purposes, which presumably cannot take advantage of any cloud credentials. Seems like there should be a way to do that without being required to provide credentials.
https://github.com/openshift/hive/blob/v1/docs/developing.md#adopting-clusterdeployments

The docs describe adopting a "kind" cluster for dev purposes, which presumably cannot take advantage of any cloud credentials.

Yes, however, even when adopting a "kind" cluster, the aws creds are required. In the example provided, the "kind" cluster is adopted as an AWS cluster.

There won't be any cloud credentials for a bare metal cluster. How do we plan to deal with that?

The docs describe adopting a "kind" cluster for dev purposes, which presumably cannot take advantage of any cloud credentials.

Yes, however, even when adopting a "kind" cluster, the aws creds are required. In the example provided, the "kind" cluster is adopted as an AWS cluster.

I may be misunderstanding, but it looks in the example like both the hive cluster and the new managed cluster (cluster1) are running in kind on a developer's local machine. When you say it is adopted "as an AWS cluster", what does that mean? How would AWS credentials be used in managing it?

There won't be any cloud credentials for a bare metal cluster. How do we plan to deal with that?

The hiveutil command does not yet support bare metal clusters. It does not support creating or adopting bare metal clusters. When the hiveutil command does support bare metal, then it will not ask for any credentials because, as you stated, bare metal does not use credentials.

The docs describe adopting a "kind" cluster for dev purposes, which presumably cannot take advantage of any cloud credentials.

Yes, however, even when adopting a "kind" cluster, the aws creds are required. In the example provided, the "kind" cluster is adopted as an AWS cluster.

I may be misunderstanding, but it looks in the example like both the hive cluster and the new managed cluster (cluster1) are running in kind on a developer's local machine. When you say it is adopted "as an AWS cluster", what does that mean? How would AWS credentials be used in managing it?

The hiveutil command has a --cloud flag that defaults to AWS. The ClusterDeployment created by the hiveutil example has a platform of AWS.

Note that you are not required to use the hiveutil command. If you would like to adopt a cluster that you would like Hive to treat as a bare metal cluster, then you are free to create the ClusterDeployment and associated resources manually rather than having the hiveutil command create them for you.

While this flag (--include-secrets=false) is still present on master, it is useless for the purpose of cluster adoption.

Note that you are not required to use the hiveutil command. If you would like to adopt a cluster that you would like Hive to treat as a bare metal cluster, then you are free to create the ClusterDeployment and associated resources manually rather than having the hiveutil command create them for you.

I would have happily pursued this route, instead of reverting back to a sufficiently old version of hive that would work, if I could find something in the documentation about adopting a cluster that didn't use hiveutil. Not certain this note about adopting ClusterDeployments would work against master based on my experience with a minikube cluster.


Button click - action triggered multiple times

If I click multiple times on a button in a short time, sometimes the action gets executed multiple times (Depends on the click speed), is there a way to prevent this by using anything integrated into ButterKnife?
After searching on google looking for a solution to that problem, I came thought a SO post asking the same https://stackoverflow.com/a/38525054/7575454 after that, I tried digging a bit on the ButterKnife source code and found the class named "DebouncingOnClickListener" (Mostly looked on this class because the class "layout" was similar to a solution I found on StackOverflow).
There is a comment on that class that says

A click on one button disables all buttons for that frame

If I understand correctly, that means I shouldn't be able to "spam" click on my button. But it's not the case, since I'm able to perform the action button multiple times if I spam click said button.
The solution I found on StackOverflow "fixes" my problem but I was just wondering if there was anything else similar to this on ButterKnife (Appart for the class that I said early) since I don't really want to do a mess on my source code setting the click listeners "manually" for a couple of buttons and use @OnClick on the ones I don't really care if there are called multiple times.

How did you solve it?


NetStandard support

Does this plugin support NetStandard? The nuget packages contains builds for netstandard but this dlls does not contain actual implementation (am I missing something?)
I have installed <IP_ADDRESS> version of plugin on Android project targeting Android 7.0. The actual library used by project is from NetStandard version, because plugin targets MonoAndroid 7.1. After running application the Plugin.Geolocator.CrossGeolocator.IsSupported is FALSE. The previous version 4.2.0 works as expected.

You must compile against 7.1 you can keep the target the same. Else you won't be getting the correct version.

Yes, I know about it, but it does not answer my question. I am wondering about net standard implementation. Does this implementation exist or not?


sample.app not working

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:
I have just run the Raspberry Pi Quick Start Guide with Script.
The installation went well until I reached the point where I was ready to run sample.app (sudo bash startsample.sh).
I received the message telling me to authorise and  I entered the code into the web site and received the message  "Success! Your registration is now complete."
The system then reported " UNRECOVERABLE AUTHORIZATION ERROR: INVALID_CBL_CLIENT_ID Entering limited interaction mode" and hung waiting for further instructions.
I also decided to do another installation into another directory using the "step-by-step" instructions.
Again the installation went well until I got to sample.app.
I ran "./SampleApp/src/SampleApp ./Integration/AlexaClientSDKConfig.json" which responded with the message:
"SDKConfig.json
2018-09-30 12:38:56.867 [  1] I sdkVersion: 1.9.0
USAGE: ./SampleApp/src/SampleApp <path_to_AlexaClientSDKConfig.json> <path_to_inputs_folder> [log_level]"
What is the expected behavior?
The app should run to completion
What behavior are you observing?
The app failed. Please see details in the issue summary above.
Provide the steps to reproduce the issue, if applicable:
n/a
Tell us about your environment:
What version of the AVS Device SDK are you using?
1.9
Tell us what hardware you're using:

[ ] Desktop / Laptop
[ x] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[ x] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Are you using the client id generated from "Other devices and platforms tab" at Security Profile?

Sorry, I wasn’t. I will go ahead and generate the id and get back to you if the problem persists.
Thanks for your help.
George.

On 1 Oct 2018, at 1:54 PM, gunnicus<EMAIL_ADDRESS>wrote:
Are you using the client id generated from "Other devices and platforms tab" at Security Profile?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/alexa/avs-device-sdk/issues/994#issuecomment-425796820, or mute the thread https://github.com/notifications/unsubscribe-auth/AGoT3cOZ3mGId00UsTdeDkY1i-QEfwedks5uga4fgaJpZM4XA9tw.

Hi! Please let us know if it worked!

Success. Thank you for your help.
Regards,George
Sent from my iPhone

On 2 Oct 2018, at 12:09, mavamazon<EMAIL_ADDRESS>wrote:
Hi! Please let us know if it worked!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I am closing the issue then. Feel free to reopen it if required.
Kudos to @gunnicus for helping with this issue!

Hello, Iam using the latest AVS-Device-SDK I followed the official documentation and everything went successfully. But once i start the sample application the device got authorized but the client is not connected. I double check everything, i used the exact Client.config file . But i still facing the issue. Please if somebody knows how to fix it, please help me


Managing data

The document has completed a first pass, where possible all the image data has been prepared and scientific structure set out to present scientific terminology.  This work has tied into the movie testing work, so we should be ready in time for testing.
Emma: The screenshots have been numbered to prevent over crowding so I would like to know if this is the right approach to continue with?
These aspects will all need to be further validated and refined in the ongoing changes and improvements.

Just something I noticed: .png files might should be preferred to .tif since github displays them making them easier to review. (Not saying change what you have; just something to keep in mind)

@omeroscott, @joshmoore: a lot of problems: wrong images path etc, basic formatting required

@omeroscott I don't think that numbered screenshots will work - there will undoubtedly be times when you want to add another image somewhere in the middle and that will throw out all ordering anyway and it will become very messy. Also, this will not be intuitive when you need to update a screenshot. Might be better to have some sort of naming that fits with what the view is?

@eehill @jburel @joshmoore  Would any of the following examples be more suitable? Let me know your preferences and I can finish renaming all the images.

managingyourdata_1.png BECOMES managingyourdata_intro.png OR managingyourdata_overview.png

managingyourdata_2.png  BECOMES managingyourdata_newproject.png OR managingyourdata_np.png

analysingyourdata_1.png BECOMES analysingyourdata_measurementtool.png OR  analysingyourdata_mt.png

analysingyourdata_2.png BECOME analysingyourdata_manager.png

importingData_1.png BECOMES  importingData_overview.png

importingData_2.png BECOMES  importingData_importlocation.png OR   importingData_il.png

viewingyourdata_1.png BECOMES  viewingyourdata_intro.png OR viewingyourdata_overview.png

viewingyourdata_2.png BECOMES  viewingyourdata_splitview.png OR viewingyourdata_sv.png

I tend to prefer the "a"'s of your "a OR b" listings. Also feel free to use subdirectories if that will keep it cleaner, e.g.
  training/importingData/location.png

agree with Josh, the 'a' versions are more intuitive.

@eehill @jburel @joshmoore  Thanks for the feedback the image names have been changed and committed so the document compiles, if you see any unclear names let me know and I can make a change.

In my sphinx output I see this:
checking consistency... /Users/moore/code/ome-docs.git/training/analysingyourdata.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/training/contentManagingYourData.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/training/contentsForTraining.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/training/gettingyourdataout.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/training/managingYourData.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/training/viewingyourdata.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/venv/lib/python2.6/site-packages/sphinx/ext/autosummary/templates/autosummary/base.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/venv/lib/python2.6/site-packages/sphinx/ext/autosummary/templates/autosummary/class.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/venv/lib/python2.6/site-packages/sphinx/ext/autosummary/templates/autosummary/module.rst:: WARNING: document isn't included in any toctree
done
preparing documents... done
assembling single document... training/clients training/overview training/connecting training/importingData developers/policies
writing... None:None: WARNING: toctree contains reference to document 'training/importingData' that doesn't have a title: no link will be generated
done

Any thoughts on those warnings? Specifically, things missing from contents.rst and the importingData "no link will be generated".

@joshmoore  @jburel
Can I just confirm JM that these warning Josh has highlighted are still expected given that I have not included the links in contents.rst and the importingData so no links are generated. Will all the links need to be put into contents.rst to proceed?
/Users/moore/code/ome-docs.git/training/contentManagingYourData.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/training/contentsForTraining.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/training/gettingyourdataout.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/training/managingYourData.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/training/viewingyourdata.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/training/viewingyourdata.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/venv/lib/python2.6/site-packages/sphinx/ext/autosummary/templates/autosummary/base.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/venv/lib/python2.6/site-packages/sphinx/ext/autosummary/templates/autosummary/class.rst:: WARNING: document isn't included in any toctree
/Users/moore/code/ome-docs.git/venv/lib/python2.6/site-packages/sphinx/ext/autosummary/templates/autosummary/module.rst:: WARNING: document isn't included in any toctree

@omeroscott: contents will probably the entry point for other docs. We should have an index.rst in training and add to it the links all the training pages. contents.rst will have only a link to index.rst.

@joshmoore @jburel @eehill Pushed the changes in contents.rst so the document is linked.

@omeroscott make html
{{{
reading sources... [100%] training/viewingyourdata
/Users/jburel/Documents/git-ome-documentation/contents.rst:28: WARNING: toctree contains reference to nonexisting document u'training/viewingYourData'
/Users/jburel/Documents/git-ome-documentation/contents.rst:28: WARNING: toctree contains reference to nonexisting document u'training/analysingYourData'
/Users/jburel/Documents/git-ome-documentation/contents.rst:28: WARNING: toctree contains reference to nonexisting document u'training/gettingYourDataOut'
looking for now-outdated files... none found
pickling environment... done
checking consistency... /Users/jburel/Documents/git-ome-documentation/training/analysingyourdata.rst:: WARNING: document isn't included in any toctree
/Users/jburel/Documents/git-ome-documentation/training/clients.rst:: WARNING: document isn't included in any toctree
/Users/jburel/Documents/git-ome-documentation/training/contentManagingYourData.rst:: WARNING: document isn't included in any toctree
/Users/jburel/Documents/git-ome-documentation/training/gettingyourdataout.rst:: WARNING: document isn't included in any toctree
/Users/jburel/Documents/git-ome-documentation/training/viewingyourdata.rst:: WARNING: document isn't included in any toctree
}}}

@omeroscott: still problem with name of the files.

@joshmoore @jburel @eehill  The filename changes have worked this time.

@omeroscott: now the build is ok, but the contents.rst files has references to all the pages. It should only contain a ref to clients.rst

@jburel This is what I am looking now with the change.
https://raw.github.com/omeroscott/ome-documentation/managing-data/training/clients.rst
and contents.rst just has the reference to the clients.rst

@omeroscott: True that there is only the ref to the clients.rst but to hide the content of "training/clients"
you need to write the following in contents.rst
.. toctree::
:maxdepth: 1
:hidden:
training/clients

@joshmoore  @jburel @eehill  The last commit should now allow for the document to be viewed as intended. Does anything more need to be done to allow the work to be pushed to the master branch?

@omeroscott: paths to images need to be updated.

Sorry, @omeroscott , but the files also look to not actually be pngs:
@master ~/code/ome-docs.git $ find training -name "*.png" -exec file {} \;  | head -n 1
training/graphx/analysingyourdata_1.png: TIFF image data, little-endian
@master ~/code/ome-docs.git $ find training -name "*.png" -exec file {} \;  | wc
      55     315    4339

@joshmoore Ok Josh I will run back over the formatting for the images.


Removed unused kvstore methods to unclutter the backend interface

The kvstore backend interface has grown significantly over the years. Let's remove a few unused methods and functionalities for the sake of simplicity and ease of maintainability. Additionally, let's bump the etcd image used for integration tests, as more than three years old. Please refer to the individual commit messages for additional details.

/test

@jibi Gentle ping :-)


Remove HeightLimitedRecyclerView

Summary:
I can see no reason why this should exist. It should be removed and the UploadMediaDetailFragment tested with a standard Recyclerview
Would you like to work on the issue?
Anyone feel free to take, otherwise I'll get to it

Hey @macgills, is this still up for grabs - correct me if not, but UploadMediaDetailFragment is using a ReyclerView

It is up for grabs

I tested it and it seems to be working fine. The only change is that the user will then be able to give unlimited descriptions to an image and are we sure that that's okay?

@Glitch101 that is different from how it currently is?

I think even now we are not limiting the number of descriptions, don't remember why this was added anyways

Maybe @misaochan  could confirm

Yes, currently the user can at max submit 4 descriptions. This is what I
observed. Please confirm.
On Wed, Mar 18, 2020, 15:52 Seán Mac Gillicuddy<EMAIL_ADDRESS>wrote:

@Glitch101 https://github.com/Glitch101 that is different from how it
currently is?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3508#issuecomment-600539769,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALBT2XVUNCTXXN5MX4S6TCDRICOH5ANCNFSM4LHAO63A
.

No no, I just tried, we can add any number of descriptions, just the rendering is slow and maybe that's why you perceived it to be 4. Anyways, even if we have to limit it to 4, I am sure we can do it without the HeightLimitedRecycler view

No no, I just tried, we can add any number of descriptions, just the rendering is slow and maybe that's why you perceived it to be 4. Anyways, even if we have to limit it to 4, I am sure we can do it without the HeightLimitedRecycler view

I tested it again and I can only do it 4 times on my device. I even waited 60 seconds and nothing happened. Let me test it more thoroughly with logs and I will keep you guys updated.

It performs very poorly and does not persist the data on scroll but I did add 7

It performs very poorly and does not persist the data on scroll but I did add 7

Were you able to go beyond 7?

This issue is unrelated to removing HeightRecyclerView, please open a new issue for this.
It is difficult to say because the scrolling is so choppy but I believe so

This issue is unrelated to removing HeightRecyclerView, please open a new issue for this.
It is difficult to say because the scrolling is so choppy but I believe so

You are right. Since we would be removing it from this layout, it won't matter anyway.
Anyways, this issue seemed stale to me since @hudlerr hasn't responded for some while. Would it be okay if I submit a PR for this?

@hudlerr  Are still interested in picking this up?

Sorry for the late reply; i would still like to, yes.

@hudlerr  Thanks for the quick response, please keep us posted regarding the updates, @Glitch101  Feel free to choose from the other issues :)

@hudlerr Thanks for the quick response, please keep us posted regarding the updates, @Glitch101 Feel free to choose from the other issues :)

Sure, happy to help :)

@hudlerr Thanks for the quick response, please keep us posted regarding the updates, @Glitch101 Feel free to choose from the other issues :)

Got it!

@macgills Sorry I just saw this. I don't know what HeightLimitedRecyclerView is, but from a functional point of view: Users should be able to enter as many language pairs as they want.

@nicolas-raoul look at #3508 for some images. HeightLimitedRecyclerview meant the list would never grow beyond a certain height, if we don't care about the list growing to cover the image then the PR is fine as is. If that isn't fine then we need to persist the functionality of the list never growing beyond a certain amount

Ah OK I see what that means now, thanks!
 A good maximum height could be 2 or 2.5 or 3 language pairs, I guess.

hey, @macgills my apps been crashing again and I can't seem to get it back up, so feel free to reassign this issue.

@macgills  Can i work on this issue? Also, to be clear we are supposed to remove HeightLimitedRecyclerView and adjust height of normal recycler view

@318anushka you have it right, please refer to my comments on the now closed pr

I tried wrapping recyclerview inside constraint layout and set maximum height but the issue is recyclerview is not scrolling on adding more items.
Recyclerview scrolls if either parent is scrollable(constraint layout is not) or its height is less than all items.
Now the problem is, we are dynamically adding items to view so cannot set a fixed height
neither can set height to 0dp (match constraints) since we initially want to wrap_content for 3-4 items.
So it seems impossible or atleast not easy to limit height through xml. However, programmatically
it's quite easy by overriding onMeasure() and setting max height that's why i think heightLimited view was used.

How about this answer?

Yeah tried every related solution. Setting constraint layout height to 0dp hides entire view.
I don't know why is it causing problem but looking for a solution.
app:layout_constraintHeight_max="450px"
This alone doesn't work have to use it along with android:maxHeight=" " to limit constraint layout height.
Also i tried this one
setting max height in recyclerview and constraining it and keep on adding items
but as soon as total item height crosses max height height of view abruptly reduces to 0.
I'll see if something can be done to make constraint layout scrollable.

Eh lets abandon this. The hope was it was easy and simpler than HeightLimitedRecyclerView, it looks like this is not the case, closing


moving secrets off var.tfvars file and to command line args

Saving sensitive data in a file on disk is not a good practice. Moving them off to command line args with -var for the terraform apply command. Tested fine by building a 4.5 cluster in tor01. Open to different env vars naming and wording for the doc. Just let me know.
Signed-off-by: Hiro Miyamoto<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: miyamotoh
To complete the pull request process, please assign yussufsh
You can assign the PR to them by writing /assign @yussufsh in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @miyamotoh! It looks like this is your first PR to ocp-power-automation/ocp4-upi-powervs 🎉

Hi @miyamotoh. Thanks for your PR.
I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Good input.
FYI Terraform support passing variables directly from env.
eg: export TF_VAR_<variable_name>
https://www.terraform.io/docs/commands/environment-variables.html#tf_var_name

Do you want me to change this PR to go with TF_VAR_xxxxx (so we can keep the terraform apply cmd the same as before)? Let me know.

@miyamotoh: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, miyamotoh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Create Elyra release notes and publish via readthedocs

For past releases, it's probably is enough to document high level functionalities, instead of harvesting all single details

This is now available:
https://elyra.readthedocs.io/en/latest/getting_started/changelog.html


Prepare base model

[x]  Update config.YAML
[x]  research or analysis
[x]  Update the entity
[x]  Update the configuration manager in src config.
[x]  Update the components
[x]  Update the pipeline
[x]  Test case added

Done with all subtasks, hence closing


Implement getTransactionByBlockNumberAndIndex Handler with tests

Resolves #68
Some of the fields are still missing; and I'm going through both the starknet and Eth APIs to see what those corresponding fields are.
{
    "name": "starknet_getBlockWithTxs",
    "summary": "Get block information with full transactions given the block id",
    "params": [
        {
            "name": "block_id",
            "description": "The hash of the requested block, or number (height) of the requested block, or a block tag",
            "required": true,
            "schema": {
                "title": "Block id",
                "$ref": "#/components/schemas/BLOCK_ID"
            }
        }
    ],
    "result": {
        "name": "result",
        "description": "The resulting block information with full transactions",
        "schema": {
            "title": "Starknet get block with txs result",
            "oneOf": [
                {
                    "title": "Block with transactions",
                    "$ref": "#/components/schemas/BLOCK_WITH_TXS"
                },
                {
                    "title": "Pending block with transactions",
                    "$ref": "#/components/schemas/PENDING_BLOCK_WITH_TXS"
                }
            ]
        }
    },
    "errors": [
        {
            "$ref": "#/components/errors/BLOCK_NOT_FOUND"
        }
    ]
},

@ermvrs, I need your help with this
The resulting block may be pending and I can't figure out a way to check this in the response.
By comparing the openAPI specs of the two possible responses (given below); I wrote the following code, as these fields are present only in pending blocks (according to the openAPI doc here)
  // Check if the block is pending by looking for pending-specific properties
  const isPendingBlock = (block: any): boolean => {
    // Check for required pending block properties
    return 'parent_hash' in block && 'timestamp' in block && 'sequencer_address' in block &&
          'l1_gas_price' in block && 'starknet_version' in block;
  };

  if (isPendingBlock(response.result)) {
    // If it's a pending block, return an error response
    return {
      code: 7979,
      message: 'Starknet RPC error',
      data: 'The block is still pending. Pending blocks cannot be processed.',
    }
  }

And here are the specs for the Block Responses:
"PENDING_BLOCK_WITH_TXS": {
    "title": "Pending block with transactions",
    "description": "The dynamic block being constructed by the sequencer. Note that this object will be deprecated upon decentralization.",
    "allOf": [
        {
            "title": "Block body with transactions",
            "$ref": "#/components/schemas/BLOCK_BODY_WITH_TXS"
        },
        {
            "title": "Pending block header",
            "$ref": "#/components/schemas/PENDING_BLOCK_HEADER"
        }
    ],
    "additionalProperties": false
},

"BLOCK_WITH_TXS": {
    "title": "Block with transactions",
    "description": "The block object",
    "allOf": [
        {
            "title": "block with txs",
            "type": "object",
            "properties": {
                "status": {
                    "title": "Status",
                    "$ref": "#/components/schemas/BLOCK_STATUS"
                }
            },
            "required": [
                "status"
            ]
        },
        {
            "title": "Block header",
            "$ref": "#/components/schemas/BLOCK_HEADER"
        },
        {
            "title": "Block body with transactions",
            "$ref": "#/components/schemas/BLOCK_BODY_WITH_TXS"
        }
    ]
},

Please fix ci error

Please fix ci error

It was a suggestion to change a var to const.
I pushed new changes, but the CI isn't running after the new commit

Please do not use type any. and console

Please do not use type any. and console

Please do not use type any. and console
Removed both of those. Console was debug statement, forgot to remove it by mistake


2827 add filtering for courses to api

Context
Find needs to be able to display a list of currently available courses and filter them by various filters.
Changes proposed in this pull request

Add scopes to Course to enable filtering
Add a CourseSearch service that builds a Course scope based on the provided filter parameters.
Add /api/v3/recruitment_cycle/<year>/courses endpoint
Add indexes to course_site table for the enums on SiteStatus

Guidance to review
Filter params are passed in the following format:
/api/v3/recruitment_cycle/<year>/courses?filter[salary]=true&filter[qualifications]=pgce,pgde
Out of scope in this PR

Only returning 'published' courses
Location filtering

Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[ ] Tested by running locally

We discussed adding search to the existing courses controller offline and have decided not to do this because:

We don't currently have a user need for search on that endpoint
it would require adding provider filtering to the CourseSearch class which is additional complexity we don't need yet
The CourseSearchesController class will be easy to incorporate into CoursesController in the future if we need to without breaking the API. (It would also be difficult to remove search from CoursesController if we added it and realised we didn't have a user need for it after all.


Extract username from session

Fixes #274

@hugovk With this change, my application is now able to use the old behavior:
 network = pylast.LastFMNetwork(
    api_key=settings.LASTFM_API_KEY,
    api_secret=settings.LASTFM_API_SECRET,
    token=token,
)
user = network.get_authenticated_user()
username = user.get_name()
print(username)

Any feedback on this implementation?

Thanks for the PR!

First of all, this changes the public API.
get_web_auth_session_key used to return a single session_key value, but now returns a session_key, username tuple.
There's quite a bit of existing third-party code out there that is expecting a single value, and this would break that code.
How about adding a new method, something like this?
    def get_web_auth_session_key_and_username(self, url, token=""):
        # as get_web_auth_session_key is now in the PR
        # ...
        return session_key, username

    def get_web_auth_session_key(self, url, token=""):
        session_key, username = get_web_auth_session_key_and_username(url, token)
        return session_key

Then the existing code out there can still call get_web_auth_session_key.

Please could you also fix the lint formatting check? You can do it automatically with:
pip install black
black .

This had been released in pylast 3.1.0. Thanks again!

This had been released in pylast 3.1.0. Thanks again!

I'm still having the issue in 3.1.0

This had been released in pylast 3.1.0. Thanks again!

@hugovk I'm still having this issue in 3.1.0


fix: complete when valid

:tada: This PR is included in version 3.0.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


offer of cooperation

hi, I'm new and wanted to join lessgo and I want to offer you my help in development. I've made some commits that can improve your project. if you agree, write to me<EMAIL_ADDRESS>

Thank you for the kind support. I'll look into your comments and maybe
later on we can work on it together. Can you please share your socials so
we can connect.
Best regards
Hokam Singh
On Wed, 9 Oct 2024, 3:38 am Evgeny, @.***> wrote:

hi, I'm new and wanted to join lessgo and I want to offer you my help in
development. I've made some commits that can improve your project. if you
agree, write to me @.***
—
Reply to this email directly, view it on GitHub
https://github.com/hokamsingh/lessgo/issues/9, or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDQKBES3J6OC37K7OU6SM73Z2RJWTAVCNFSM6AAAAABPTGWF4SVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU3TIMZRGA3DENI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Telegram: @MyNameIsEKJ

I have sent you a mail.


Combine timeout switches

I realized that this could be done with a single switch rather than two, so fixed it.
Signed-off-by: Darren Stahl<EMAIL_ADDRESS>

Not sure about this one - do we not need to trap the other exit codes?

They're all there, just hidden by the code fold on Github's diff viewer.

Ah, yes :innocent:. LGTM


ChannelData: fix padding

Padding is mandatory for tcp but optionnal for udp
See https://tools.ietf.org/html/rfc5766#section-11.5

Without looking at the actual padding change, I'm against merging this because it changes (removes) public API.

I've reworked this PR to not break current API

Apart from your good fix with the offset in decode, I don't quite see the use case for the other changes. Is there a problem if we always pad the messages?
Also:

getDataLength() method still behaves differently (probably doesn't really matter)
padTo4 as a separate method is overkill and pollutes the API, at the very least make it private

I'm still reluctant to change this at all. Can someone else please give some input? @bgrozev?

hi @ibauersachs,
We can always pad according to the RFC, but i prefer to be sure to keep back compat when possible.
getDataLength() is unchanged (it behaves exactly the same as before)
padTo4 is a bit unreadable, thus the separate function, but i will make it private.
I started this PR because length in getDataLength() was a dead store, and FindBugs spotted it.

Oh, right, it was too late yesterday and I missed that getDataLength was returning the array length instead of the calculated value. So, okay, after making padto4 private I'm okay merging it.

padTo4 now private


Revert "Revert "Revert "Update tenant test runner JUnit version as well"""

Reverts vespa-engine/vespa#29850
@bjorncs

Not sure whether we should do the revert ...


Feature Request on empty strings

This plugin is amazing and very helpful
this is a Feature request for a new option to check IF there are empty translations to be filled, or ignore translated ones.
all the missing translated strings "", will be populated, other ones ignored.
this is helpful when translations are being modified and some sections are missing.

Hi @alexnoise79, if I understood your request right, this is already implemented.
You can check demo section in README, and see how it works.

Hi @while1618
yes i saw it but this is working only IF the key is not available, but in real life when you use other plugins to extract translation, the json file has the keys, but the values are "" empty strings.
in that case your plugin is not working.
(plus, translations are always inserted at the end of the file, usually they are sorted alphabetically)
mine are just suggestions, would appreciate if they are taken into consideration :)


Automated cherry pick of #5199: cloud region city list add default limit 2048

Cherry pick of #5199 on release/2.12.
#5199: cloud region city list add default limit 2048

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@1c6e52e). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.12   #5204   +/-   ##
==============================================
  Coverage                ?   6.83%
==============================================
  Files                   ?     506
  Lines                   ?   86290
  Branches                ?       0
==============================================
  Hits                    ?    5896
  Misses                  ?   79898
  Partials                ?     496

Flag
Coverage Δ

#aFlag
6.83% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c6e52e...9463d26. Read the comment docs.

/lgtm

/lgtm

/approve


Photos for shift reports

Ability for logged in users to add a photo to a shift report. For the moment photos will be attached to the user and many-2-many attached to a shift report - in the future they may be attached to comments too.

[x] Create images.tidepoolstewards.com S3 bucket
[x] Configure Fly.io with credentials for that bucket as environment variables
[x] Implement the Photo model
[x] Build API endpoint for getting the credentials to upload to S3
[x] Web Component for the upload
[x] API endpoint for when a photo has been uploaded
[x] Show photos on shift page

Did a bunch of work relating to this on s3-credentials:

https://github.com/simonw/s3-credentials/issues/88

I'm going to go with yyyy-mm-dd/$ULID.jpg as the key format. Since the ULID is sorted it will mean I can retrieve new photos uploaded since a particular moment if I ever need to, using list_objects_v2 with StartAfter.

Feature is now available to all active users.


Test and optimize autonomous control mode

Make sure that autonomous control mode is still working fine:
https://github.com/sbrodeur/ros-icreate-bbb/blob/master/src/action/scripts/record/autonomous_control.py
The launch script that records the rosbag should also be adapted to the new topics:
https://github.com/sbrodeur/ros-icreate-bbb/blob/master/src/action/scripts/record/record_autonomous.launch

Autonomous control mode works. I had to switch angles from deg to Rad because of the new messages. Also changed the launch file for the new topics.

It seems that only the backward moving when hitting an object needs to be adjusted. The robot should move backward a fixed 3-5 cm (the minimum to clear the bumper).

Again it was an issue of units due to new messages. Changes were done here: 28443bce8ab5f3b4439f175c2a49934f886f263c


[InfluxDB] Document INTEGRAL() aggregate function

URL for relevant page?
influxdata/influxdb#8194
What products and version are you using?
InfluxDB 1.3
Description of the function is in the pull request.

[ ] Add INTEGRAL() to the aggregations list
[ ] Update the INTEGRAL() section with content:

INTEGRAL()
Returns the area under the curve of field values.
Syntax
TK

No fill().
Description of Syntax
TK
Examples
TK


[c++/python] Expanded enumeration support in ArrowAdapter::to_arrow

Issue and/or context:
Updates in Pandas 2.0 has introduced changes to DictionaryArray.from_arrays that required refactoring in pytiledbsoma.cc. This bug motivated a change in the C++ ArrowAdapter::to_arrow method to further handle all supported enumerated types.
Changes:

Several pre-existing C++ and Pybind11 modifications have pulled from https://github.com/single-cell-data/TileDB-SOMA/pull/1793
Previously in the Python API the ArrowTable was converted from Table.from_arrays and then enumerations were added in an additional step with DictionaryArray.from_arrays. DictionaryArray.from_arrays has now been completely removed and now only uses Table.from_arrays
The required changes for the above to work required refactoring of the C++ ArrowAdapter::to_arrow method. Previous work has been done to support enumerated string values. The changes in this PR have expanded this now handle all supported enumerated types including all integral numeric types, floating point numbers, and Boolean
to_arrow_format now takes a use_large Boolean argument. For enumerations, we need to use string or binary rather than large_string or large_binary

Notes for Reviewer:

Pre-existing changes to the ColumnBuffer class to handle string enumerations, and the steps used in ArrowAdapter::to_arrow to populate the data and offet buffers remain untouched. However, I have written a TODO note on how this can be cleaned up in a future refactor
Boolean enumerations require special handling from other numeric types as std::vector<bool> is a specialized vector that does not store values contigously in memory. We must iterate through the container and then use bit masking to set each bit in least significant bit ordering
Awaiting TileDB-Py 0.23.4 release

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

apis/python/src/tiledbsoma/_dataframe.py
96.22% <100.00%> (+0.02%)
:arrow_up:

... and 89 files with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.

The unit test fail is corrected by https://github.com/TileDB-Inc/TileDB-Py/pull/1853 which requires a TileDB-Py 0.23.4 release.

Yeah you're right; we can get rid of that now.

@nguyenv Cool. Do you want to fold that edit into the PR?

Yup just made the change.


Windows 7: tasks.json changes not detected until VS Code restarted

VSCode Version:0.10.11 stable, 0.10.14-insiders
OS Version:Windows 7

Steps to Reproduce:

Follow the CSS transpiling section and create a tasks.json with 'node-sass' as the command.
Save tasks.json
Ctrl+Shift+B to Run Build Task

"No task runner configured." error displayed.

Restart VS Code in the same folder.

'node-sass' now runs correctly

Also repros on 0.10.14-insiders

Doesn't repro on Windows 8.1 and 10

Closing and opening the folder, refreshes the tasks.json configuration.
I've reproduced this on two Windows 7 VMS and can grant access to anyone who'd like to take a look.

I'm using http://xlab DevDiv Private Cloud VMs for my testing.  It's very easy to create Windows 7 machines for testing. I assume the Zurich team has access to this service.

@dbaeumer Might be related to #5083

Duplicate of #5083. The issue goes away when .NET 4.5 is installed and the File Watcher is working again.

I'm still seeing this problem in Windows 7 Professional Service Pack 1 with .Net 4, 4.5, 4.5.1 and 4.6.1 installed. It is most annoying that I can edit the tasks.json to change my build and then not get that task until I restart VS Code. Using 1.12.1.

I'm still seeing this problem in Windows 7 Professional Service Pack 1 with .Net 4, 4.5, 4.5.1 and 4.6.1 installed. It is most annoying that I can edit the tasks.json to change my build and then not get that task until I restart VS Code. Using 1.12.1.

Can this issue be reopened? Or shall I open a new one?

@BillDenton if you create a new file using the Windows file explorer directly in a folder that is open in VS Code does the file show up in VS Code's explorer pane?

Yes, it does appear. I opened the VS Code explorer pane, right clicked on a file, selected Reveal in explorer, copied the file in Window explorer. Immediately the file appeared in VS Code explorer.

I have multiple folders (for different branches off the same project). I switch between them using File, Open Folder. However, so I can use the same configuration for all folders, I have created a .vscode directory in each root folder. In there the tasks.json, c_cpp_properties.json, launch.json and settings.json are symbolic links back to a common configuration stored elsewhere. Could this be messing up the change detection?

@BillDenton yes, this is the problem. Under Windows the file change event is triggerd on the traget and therefore VS Code doesn't know about it. See https://github.com/Microsoft/vscode/issues/25547

I also tried a creating a symbolic link to the common folder, rather than each file individually. I could avoid this problem by have common tasks.json, launch.json and c_cpp_properties.json that can overridden  a folder basis.

I think I solved this by using hard links. By using http://schinagl.priv.at/nt/hardlinkshellext/linkshellextension.html with "Hardlink Clone".


[Monitor] az monitor metrics alert create: Support metric alerts in a resource group

RE: Azure Metric Alerts - Proposed CLI Commands. Item 12

add to S174


No module named Random Rain, Random Fog, Gaussian Blur and a few others

📚 Documentation

Some of the functions included in the documentation cannot be used. No module found error is returned for those modules some of which are mentioned in the title of the image.

Could you please share an example of the code snippet that generates an error?


Static class block support

Closes #43092
Fixes #43012

@dragomirtitian Please take a look on https://github.com/microsoft/TypeScript/pull/43308/commits/820b1d2cf0ae018c06ab151e42876b968d74087f. Thanks!

@typescript-bot pack this

Hoops. Seems something broken.


fix(mq): added useIsDesktop to changeset

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 82.398%

Totals

Change from base Build<PHONE_NUMBER>5:
-0.005%

Covered Lines:
10616

Relevant Lines:
11762

💛  - Coveralls


Creepers Not Running Away From Felines

Hey, I was playing with the feline race earlier and noticed that creepers were barely ever running away from them? Not sure if this is a bug or intentional but they still seem to sneak up on you and explode as usual.

I tried it out some more, it seems like they do run away most of the time but sometimes they just don't? I think it has something to do with them running into a block but instead of climbing over it or going around it they just stay there and then blow up because they're close enough to the player.

Yeah, that's just Minecraft's Pathfinding being busted. Them blowing up is technically part of the fabric version, so I won't do anything for it on 1.16.5. Maybe for 1.17, depending on how far I move away from the original code.


1.4.x - History audio replay does not respect start and end timecodes

The problem
Describe the bug
When opening the history panel while running a dialog, and pressing the play button, the while audiofile is played.
To Reproduce
Steps to reproduce the behavior:

Enable history and audio for text events
play a timeline featuring voiced lines with timecodes not starting at 0 secunds.
press history button
press the play button on a line filling the step 2 criteria.
observe the whole audiofile being played instead of the one desired line

Expected behavior
Only the part of the audio defined in the audio-region should be played.
System (please complete the following information):

OS: Linux Mint 20
Godot Version: 3.4.4
Dialogic Version: 1.4.3 (dev)

Solutions
Workaround
None found.
Possible fixes
Implement the audio region feature in history.

Duplicate of #765 gonna keep this one as it is more detailed.


Can I compare and swap with empty previous value?

Hi ,
paca> /usr/bin/curl -L http://<IP_ADDRESS>:2379/v2/keys/a
{"action":"get","node":{"key":"/a","value":"","modifiedIndex":42,"createdIndex":42}}
paca> /usr/bin/curl http://<IP_ADDRESS>:2379/v2/keys/a?prevValue= -XPUT -d value=123
{"errorCode":201,"message":"PrevValue is Required in POST form","cause":""prevValue" cannot be empty","index":0}
Is there a way to compare and swap with a previous value "" to another new value?
Thanks.

etcd doesn't support to compare and swap an empty value today.

As I just discovered, etcdctl mk /key does what --swap-with-value "" would do.


change createArticle method

add testNewMethod method

Drill4J Bot - Change Testing Report
Changes
517 methods (517 new, 0 modified)
Risks
129/517 methods not tested
53% coverage
Recommended tests
2838 tests
See details in Drill4J

Drill4J Bot - Change Testing Report
Changes
517 methods (517 new, 0 modified)
Risks
129/517 methods not tested
53% coverage
Recommended tests
4188 tests
See details in Drill4J

Drill4J Bot - Change Testing Report
Changes
2 methods (1 new, 1 modified)
Risks
1/2 methods not tested
86% coverage
Recommended tests
21 tests

Drill4J Bot - Change Testing Report
Changes
2 methods (1 new, 1 modified)
Risks
All changes tested
100% coverage
Recommended tests
None

Drill4J Bot - Change Testing Report
Changes
2 methods (0 new, 2 modified)
Risks
All changes tested
100% coverage
Recommended tests
None

Drill4J Bot - Change Testing Report
Comparing the changes made to realworld/spring-webflux in the 6af31bd with the 33c48ae.
Comparison of  realworld/spring-webflux changes made in 6af31bd versus 33c48ae.
Changes
2 methods (1 new, 1 modified)
Risks
1/2 methods not tested
86% coverage
Recommended tests
21 tests


Adding Either and Maybe

Adds two base data structures, the Either and the Maybe.  These are concepts that exist in other languages that I have brought over for convenience/safety.  The Either represents a value that might be of one type or another, and provides methods to allow you to access them safely.  The Maybe represents a value that might or might not exist, and provides methods to allow you to access it safely.

Going to close this for now


I improved line 9 to be more descriptive

I modified line 9 to be more descriptive in Spanish, which is my native language

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


#846 - support ssr

@pournasserian after these changes, all pages will have html contents and prerendered. this means there is no need to host it on javascript based server.
I mean there is no problem if we revert #847 and serve site from previous server.


Attempting to reproduce #212 by adding external mixins

I'm closing this PR for the reasons mentioned here:
https://github.com/thoughtbot/ember-cli-rails/issues/212#issuecomment-158794739


IGAPP-741: Short description for poi

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

Hm i'm wondering how you get the distance on the screen. I couldn't find any method that calculates the distance Maybe i'm just blind ;) Here is the standard lib for calc distance if its needed http://turfjs.org/docs/#distance

There is a property distance existing on PoiFeature that i use, I assumed this will be correctly set in other tickets, as it does not make sense to calculate distance everytime, when it just can be passed.

Hm i'm wondering how you get the distance on the screen. I couldn't find any method that calculates the distance Maybe i'm just blind ;) Here is the standard lib for calc distance if its needed http://turfjs.org/docs/#distance

There is a property distance existing on PoiFeature that i use, I assumed this will be correctly set in other tickets, as it does not make sense to calculate distance everytime, when it just can be passed.

Yes the interface includes distance but it has to be calculated once you get the location of the user and shouldn't be updated. So it has to be added in the frontend. There was definitely not enough info in the ticket. We can create a separate ticket or you can add the functionality if you like

One small idea according to the thumbnail. For native we use a placeholder if there is no image, dunno if we want to do the same for web
import EventPlaceholder1 from '../assets/EventPlaceholder1.jpg'


PROPERTY_HINT_RANGE doesn't work for properties of a custom ArrayMesh class if the setter on that property re-computes the mesh.

Tested versions
Reproducable in 4.2.2.stable.official.15073afe3
System information
Godot v4.2.2.stable - Ubuntu 22.04.4 LTS 22.04 - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 580 Series (RADV POLARIS10) () - AMD Ryzen 9 3900X 12-Core Processor (24 Threads)
Issue description
I've created a GDExtension class that extends ArrayMesh and have added a PROPERTY_HINT_RANGE to a property that has a setter defined that will regenerate the mesh whenever the property is changed. I was expecting to be able to use the slider within the editor and see changes to the generated mesh in real time, however any slider operation immediately loses focus and prevents the slider from being useful (it only drags one set at a time).
I suspect that setting the mesh, is triggering a Resource changed signal and this may be re-rendering the property list, such that the range loses state. I can see that Godot is requesting property information whenever I drag on the slider.
Steps to reproduce
Create a class that extends ArrayMesh and add a PROPERTY_HINT_RANGE to a float property that has a setter defined that will regenerate the mesh whenever the property is changed.
Minimal reproduction project (MRP)
I can attach a GDExtension project on request (the shared library objects are not so small), the mesh generation code is not trivial and I don't have a GDScript version of it.

If your extension triggers an inspector update for a resource you can't use sliders for properties directly on the resource. Because when resource things are updated the inspector is recreated and it will loose input focus as the old gui with the focus is replaced by the updated gui that has no focus and might be entirely different.
This is not specific to array mesh, it is part of any resource with such properties that triggers updates. The solution is to use an actual editor, node or inspector plugin so that the properties are a stable part of said plugin while the resource itself can switch and update.

I think you've clearly identified the mechanism for why this doesn't work as expected, this confirms what I suspected and I understand the solutions you have presented. I didn't intend to open this as a discussion or question and I am not looking for solutions for my use-case.
I opened this as a bug-report because I suspected it to be a bug (slider should slide) does Godot have a designer who is able to confirm whether or not this is a bug? versus intended behaviour?

We don't have a person (or even a team) that handle these questions as such, not overarching "design" decisions of this type. This is a matter of evaluation and discussion, hence this being a discussion, the answer above is more about the limitations and use cases and how to handle this, and what the goal is. It's not set in stone, it's something that is discussed and evaluated.
It it's considered a bug after that it can be solved, otherwise it can be discussed for documentation or other approaches, it depends entirely on the approach. This being a report here doesn't alter that fact, it's just the starting point

I note this TODO from EditorInspector::update_tree, if this is considered to be a 'bug', this may be the place to 'fix' it.
// Store currently selected and focused elements to restore after the update.
// TODO: Can be useful to store more context for the focusable, such as the caret position in LineEdit.

I expect it to be very hard to restore a slider correctly while it's still in a dragging operation (without interrupting the ongoing dragging operation).

Have added a PR, which may serve as a reference for how to reach a working fix for this, if there is consensus on this to be considered an issue.


Add manual GitHub actions triggers for the tests.

Added manual workflow_dispatch to trigger for OSX, MinGW/MSYS tests.

I didn't know you could do that...
I will use that on my repos...


Create new styles for the APP

The app has awesome functionality!. But it's not all the user sees. To have a good game you need to create a good game experience. It is because we need to create a new design and graphic interface for our Tic Tac Toe game.

[ ] Do you have one idea about the design you want to apply
[ ] Design looks good in phone and desktop
[ ] You've implemented this design in the APP

I've created a design proposal using figma. U can check it here: https://www.figma.com/file/Vf7NsDkKhdcc47gvNE5AJF/Tic-tac-toe-game?node-id=0%3A1

I've does too the design token systems, and I'll push the pull request with this changes soon


Cache makes line number mismatch

Hi,
I got mismatched line number (e.g., all shows shadowing upvalue XXXX on line 7) when enabling cache. Modifying Lua files or Recreating the cache will solve this issue temporarily.
Is it a caching bug?

Strange, can't reproduce this myself. So if you remove .luacheckcache and then run luacheck with --cache twice, do you get two different outputs?

if you remove .luacheckcache and then run luacheck with --cache twice, do you get two different outputs?

I got same output.
Maybe it was caused by luacheck upgrade? (from 0.11.0 to 56141edf0dd3eb7ad5cadd43374593c677ff71a9)

@CheyiLin probably, there was a fix related to caching. I'll add version number to cache to prevent this in the future.

Got it, Thanks.


Data Viewer throws error "Python package 'pandas' is required for viewing data." even though pandas is installed

Environment data

VS Code version: 1.53.0
Jupyter Extension version: v2020.12.414227025
Python Extension version: v2021.1.502429796
OS version: Mac OS10.15.17 (Catalia)
Python version: 3.66
Type of virtual environment used: pyenv, venv, pip install
Jupyter server running: Local
Pandas version: 1.1.5

Expected behaviour
Interactive session running .py file or ipynb file.
Data (dataframe, list etc) are created.
Open Variable Explorer and click on Data Viewer icon.
Data Viewer opens and shows data.
Actual behaviour
Note, this is similar to issue  #1411.
When the Data Viewer icon is clicked, it throws error "Python package 'pandas' is required for viewing data." in a pop-up window.
Note pandas is installed in environment and used to create the data.
When "install" is clicked in the pop-up window, the terminal window shows:
Executing command in shell >> /Users/username/venv/venvname/bin/python /Users/username/.vscode/extensions/ms-python.python-2021.1.502429796/pythonFiles/pyvsc-run-isolated.py pip install -U pandas
Requirement already satisfied: pandas in /Users/username/venv/venvname/lib/python3.6/site-packages (1.1.5)
Then, the Data Viewer opens and shows data as expected.
This happens each time Data Viewer is clicked (even in the same session).

Hi @NaokiTakahashiRad, thanks for reporting a bug. I cannot repro this with macOS 10.14.6, VS Code 1.53.0, Python 3.6.6 via pyenv with venv, local kernel, Jupyter extension v2020.12.414227025. Is the kernel that the notebook was started with the same as /Users/username/venv/venvname/bin/python? And would you mind providing debug logs from the Jupyter output panel? You can turn on debug logging by setting 'jupyter.logging.level' to 'debug' in your settings.json, reloading VS Code, repeating repro steps and looking for the Jupyter option in the dropdown under the Output tab in the terminal pane. Thanks and sorry for the bother!

Thank you.
Regarding the kernel, it is Python 3.6.6 64-bit, but not sure which (~/.pyenv/shims/python, ~/venv/venvname/bin/python, ~/.pyenv/versions/3.6.6/bin/python) one was selected. ~venv/venvname... was darkened when clicked on jupyter kernel panel. I manually chose ~venv/venvmane.. and it is reproducible.
The Debug log is attached.
Info 2021-02-15 22:24:48: Python Daemon .log

I was able to fix the issue by doing the following:
brew install xz  (install lzma)
pyenv uninstall 3.6.6, then pyenv install 3.6.6
Thank you!


feat: Update justification proto with annotation field

part of #318

This seems fine - do we need to do anything to update the java protos @yolocs?

Java client doesn't use proto. It just validates the token.


Allow image types to be set explicitly

This adds the a bunch of cpp API for raster images but also allows us to define the type explicityly.
This is needed because for now, I'm writing the rasters out to temporary files, and the temp files never have extensions so there's no way to detect them.
The output for this isn't great though. The RGB JPEG works ok, the RGB PNGs work ok but the Tiff refused to load at all (unsupported std::exception) and the CMYK jpeg loads in a broken way: output.pdf
src: 11-rasters

The obvious question is if just trying all the different decoders one after another would work?

Why is it decoding anything?
If capypdf needs to decode these images, it's going to be extremely inefficient when it comes to large raster images. Which people who occasionally try and use with inkscape.
At the moment, most images are failing, so I think we've got some room to architect this a bit. My preference is for an interface which reflects what will end up in the pdf, if that means a PNG-like bytes list with compression, or a jpeg encoding. I feed in that it's a jpeg, that it's cmyk or an icc profile explicitly and then feed the bytes (or currently, the filenames) and any other information that is needed.
Can you explain what formats PDF supports? I get the feeling that my work with SVG confuses me, as SVG supports any image format as a file so can just extract it and read it as needed.

Can you explain what formats PDF supports?

The native format is raw pixel arrays, which are typically compressed with either zlib or CCIT Fax compression (really only used for 1-bit images).
In addition you can embed files in jpeg, JBIG2 or JPEG 2000 formats. Out of these only the first one is used in practice. Every other file format needs to be converted.
Currently CapyPDF stores jpeg files in their original format and decompresses and recompresses all other image formats.

it's going to be extremely inefficient when it comes to large raster images.

Indeed it is and that is by design of the PDF spec. If you have ever tried to export an document with many large images from Scribus it takes forever, an this is the reason why.

OK so thinking about this work in isolation, I think this modification is good as it resists needing to process the data (which could be large) with multiple processes. We're passing in a filename at this level, so attempting every format would make for a slow read and dump unless the header information was super efficient.
Inkscape has already done this work as we already know what the mime type is (as well as other data, obviously).
I'll work on manufacturing the pixel arrays, since I don't think passing in PNGs will work for CMYK and compressing for jpeg seems wasteful if the pdf supports cmyk pixel arrays anyway.
It's going to be important to be able to specify "This array of pixels, this format, this channel size, this number of channels and this icc profile (optional)". This is very similar to the details lcms needs to do conversions so tht might be a good reference for what data should be in that API.

attempting every format would make for a slow read and dump unless the header information was super efficient.

FWICT every data file parser starts by checking if the magic number at the start of the file is correct. That is about as fast as you can go.

compressing for jpeg seems wasteful

Not to mention lossy and some people really don't like it if you add compression artifacts in their print PDFs.

"This array of pixels, this format, this channel size, this number of channels and this icc profile (optional)".

That is what RasterImageBuilder does. Some of the functionality is not in the public API yet, though.

OK, your mod is a little outside of my comfort zone. Would you be willing to add to this PR with the changes you want?

Latest trunk should be able to autodetect file types without crashing.

This is now just the hpp updates.


DRILL-5123: Write query profile after sending final response to client

Write query profile after sending final response to client to improve latency
In testing a particular query, I used a test setup that does not write
to the "persistent store", causing query profiles to not be saved. I
then changed the config to save them (to local disk). This produced
about a 200ms difference in query run time as perceived by the client.
I then moved writing the query profile after sending the client the
final message. This resulted in an approximately 100ms savings, as
perceived by the client, in query run time on short (~3 sec.) queries.

Fixed comment to explain reasoning without reference to prior behavior.

+1

+1. LGTM


fix for print elapsed time exit issue

This fixes closes - https://github.com/DevonianTeuchter/meta/issues/28

Wonder if there is a difference in the return code from set -x running from bash or sh [since it's a builtin] perhaps?
In any case, is the modified code being driven from printElapsedTime as it still appears to be commented out in common.inc so the change in printVerbose would not be called?
...
printElapsedTime()
{
  printType=$1
  functionName=$2
  startTime=$3
  elapsedTime=$(( $SECONDS - $startTime ))
  elapsedTimeOutput="$functionName completed in $elapsedTime seconds."
#  case $printType in
#    "info")
#      printInfo "$elapsedTimeOutput"
#      ;;
#    "verbose")
#      printVerbose "$elapsedTimeOutput"
#      ;;
#  esac
}
...

Would it also be worth adding the explicit return 0 to the printInfo and printWarning functions for consistency and prevent this odd issue?

Wonder if there is a difference in the return code from set -x running from bash or sh [since it's a builtin] perhaps?
In any case, is the modified code being driven from printElapsedTime as it still appears to be commented out in common.inc so the change in printVerbose would not be called?
...
printElapsedTime()
{
  printType=$1
  functionName=$2
  startTime=$3
  elapsedTime=$(( $SECONDS - $startTime ))
  elapsedTimeOutput="$functionName completed in $elapsedTime seconds."
#  case $printType in
#    "info")
#      printInfo "$elapsedTimeOutput"
#      ;;
#    "verbose")
#      printVerbose "$elapsedTimeOutput"
#      ;;
#  esac
}
...

Would it also be worth adding the explicit return 0 to the printInfo and printWarning functions for consistency and prevent this odd issue?

Yes, added it there as well.

Looks good to me as [ ! -z "$xtrc" ] && set -x is returning non-zero, maybe we can investigate why at a later time.

Yes sure, raised https://github.com/DevonianTeuchter/meta/issues/50 to track it


The processing of hand pose

I noticed that the hand poses are reserved in the raw pose processing, but are discarded in the motion representation. If I want to reserve the hand poses in motion representation, what can I do? What should I change in your code?

Hi, we do not use hand poses mainly because HumanAct12, part of HumanML3D dataset, does not contain hand poses. If you want to include hand poses, you may discard the part of HumanAct12, and change the kinematic chain. I don't think there are other parts that require change.

Hi, I'm also interested in keeping the hand pose. @christsa were you able to figure this out? In particular, what should I do for the raw offsets? For the kinematic chain, I think we append the left and right hand chains that are defined to the t2m_kinematic_chain?


rollout: toc and focus users

What sort of feedback are you looking for? is this the point for copyedits?

My main goal is to get lots of ideas out before perfecting them. The most useful comments are ones that help you get the ideas. So if you understand it but it might be confusing to others I'd leave it for now and would rather spend time getting other docs out (and would love help on those)


Feat: tag each 2" chunk with tv program

From chunk timestamp, tag a new column called "program" from a CSV file
This new tag will allow us to count keywords by the whole tv sequence.
And enable us for more advanced crossed analysis

#16


cat -n doesn't handle CRLF newline delimiters correctly

This is with the latest version from github, built locally via cargo build --release --features windows
❯ coreutils printf "hello\r\nworld\r\nthere\r\n" | coreutils cat -n
     1  hello     2
world
there

Weirdly, looking at the output via xxd, the CRLF sequence is switched to LFCR...
❯ target\release\coreutils printf "hello\r\nworld\r\nthere\r\n" | target\release\coreutils cat -n | xxd
00000000: 2020 2020 2031 0968 656c 6c6f 2020 2020       1.hello
00000010: 2032 090a 0d77 6f72 6c64 0a0d 7468 6572   2...world..ther
00000020: 650a 0d                                  e..
❯ target\release\coreutils printf "hello\r\nworld\r\nthere\r\n" | xxd
00000000: 6865 6c6c 6f0d 0a77 6f72 6c64 0d0a 7468  hello..world..th
00000010: 6572 650d 0a                             ere..

I'm trying to fix this issue. And I find out that it is caused by src/cat.rs:write_new_line in Line537. The code is as follows:
fn write_new_line<W: Write>(
    writer: &mut W,
    options: &OutputOptions,
    state: &mut OutputState,
    is_interactive: bool,
) -> CatResult<()> {
    if state.skipped_carriage_return && options.show_ends {
        writer.write_all(b"^M")?;
        state.skipped_carriage_return = false;
    }
    if !state.at_line_start || !options.squeeze_blank || !state.one_blank_kept {
        state.one_blank_kept = true;
        if state.at_line_start && options.number == NumberingMode::All {
            write!(writer, "{0:6}\t", state.line_number)?;
            state.line_number += 1;
        }
        writer.write_all(options.end_of_line().as_bytes())?;
        if is_interactive {
            writer.flush()?;
        }
    }
    Ok(())
}

I think there's two problems in this function:

If cat is not in the show_end mode, the \r will be ingnored in function. This will happen every time it meet \r\n.
Suppose we correctly print the \r/^M, the rest of the code will treat the following \n as a single line itself. Here's an example:

./target/debug/coreutils cat -nE ../crlf.txt
     1  Hello^M     2   $
     3  world^M     4   $
     5  there$

I think these problems can be fixed by modiying the branch statement in function write_new_line as follows；
    if state.skipped_carriage_return {
        if options.show_ends {
            writer.write_all(b"^M")?;
        } else {
            writer.write_all(b"\r")?;
        }
        state.skipped_carriage_return = false;

        write_end_of_line(writer, options.end_of_line().as_bytes(), is_interactive)?;
        return Ok(());
    }

I'll be glad to submit a PR if you agree to my proposal.
Besides, I think tests for this kind of case should be added. But I have no idea where should I add the new test. I'm new in here so please give some guidance, thanks.

Sure, don't hesitate to submit the PR

Besides, I think tests for this kind of case should be added. But I have no idea where should I add the new test.

You can add the test to /tests/by-util/test_cat.rs.


k8s metadata cache: delete shouldn't fail on NotFound errors

In order to maintain idempotency when deleting k8s metadata entries, we may assume that non-existent entries are already deleted.

PTAL @rootfs @mickymiek

It should now return earlier ; also the log messages should be now a bit more descriptive.


[intel-mkl][suitesparse] colmap cannot find debug/lib/intel64/libmkl_intel_lp64.a

Package: colmap[core]:x64-linux -> 2023-03-12#1
But the issue might be in:

suitesparse:x64-linux                             5.8.0#2, or
intel-mkl:x64-linux                               2023.0.0

colmap requires suitesparse, and suitesparse might accidentally be depend on intel-mkl, without actually requiring it: suitesparse source code requires LAPACK, and FindLAPACK.cmake can take intel-mkl for the LAPACK implementation, instead of clapack.
Host Environment

Host: x64-linux
Compiler: GNU 12.2.1
vcpkg-tool version: 2023-01-24-8a88d63f241d391772fbde69af9cab96c3c64c75
vcpkg-scripts version: 785a2337f 2023-03-27 (4 days ago)

To Reproduce
I am not sure how to reproduce it. It depends on the list of already installed packags. At least intel-mkl has to be installed, and then:
vcpkg install colmap
The package suitesparse
Failure logs
-- Using cached colmap-colmap-30da037ce19bdceb6d239c45342fadb221bdabb2.tar.gz.
-- Cleaning sources at /home/lrineau/Git/vcpkg/buildtrees/colmap/src/b221bdabb2-e3968635af.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/lrineau/Git/vcpkg/downloads/colmap-colmap-30da037ce19bdceb6d239c45342fadb221bdabb2.tar.gz
-- Applying patch fix-dependencies.patch
-- Using source at /home/lrineau/Git/vcpkg/buildtrees/colmap/src/b221bdabb2-e3968635af.clean
-- Found external ninja('1.10.2').
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
    Command failed: /usr/local/packages/cmake-3.26/bin/cmake --build . --config Debug --target install -- -v -j17
    Working Directory: /home/lrineau/Git/vcpkg/buildtrees/colmap/x64-linux-dbg
    See logs for more information:
      /home/lrineau/Git/vcpkg/buildtrees/colmap/install-x64-linux-dbg-err.log

Call Stack (most recent call first):
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
  ports/colmap/portfile.cmake:60 (vcpkg_cmake_install)
  scripts/ports.cmake:147 (include)

/home/lrineau/Git/vcpkg/buildtrees/colmap/install-x64-linux-dbg-err.log
ninja: error: '/home/lrineau/Git/vcpkg/installed/x64-linux/debug/lib/intel64/libmkl_intel_lp64.a', needed by 'src/exe/colmap', missing and no known rule to make it

Additional context
installed/x64-linux/debug/lib/intel64/libmkl_intel_lp64.a does not exist, even if the package intel-mkl is installed. That is the result of the macro vcpkg_cmake_config_fixup in the portfile of suitesparse:
https://github.com/microsoft/vcpkg/blob/c9f906558f9bb12ee9811d6edc98ec9255c6cda5/ports/suitesparse/portfile.cmake#L46

Fixed by https://github.com/microsoft/vcpkg/pull/30421. Now https://github.com/microsoft/vcpkg/pull/30341 passes its checks.


Better spongyCastle initialisation / decoupling

This is a follow-up for: https://github.com/walleth/kethereum/pull/21
There are now multiple of these blocks in kethereum:
    init {
        Security.insertProviderAt(org.spongycastle.jce.provider.BouncyCastleProvider(), 1)
    }

I would really like a cleaner way of initializing spongyCastle - and ideally a decoupling from sponygCastle from kethereum so it can also be used with bouncyCastle in a JVM context where the whole spongyCastle is not needed.
One Idea:

create a kethereum-android module that has to be included when using kethereum in combination with Android
inside this module there is a content-provider that initializes spongyCastle

@mirceanis what do you think?

Was recently talking to @cketti recently and I think he is correct that the best way is not to use the providers at all but the lower bouncycastle API - so we do not need the split spongy/bouncy at all. This way we also can avoid the multiple insertProvider calls.
Perhaps when doing so we can also hide bouncycastle behind some crypto-interface so we can replace it with a pure Kotlin implementation at a later point.

what do you mean by lower bouncycastle API ?

you can directly use the functions without going through providers. So you are sure you do not run into the problem of using varying platform implementations. Will cc you once I make the PR for it


Render 'View Changelog' and 'Give Feedback' mechanisms

When the hotkey is pressed, render the following modal dialog:

The 'View Changelog' button will render a changelog list which is scrollable:

The 'Give Feedback' button will render a list of pending user-requested features, with voting, searching, and the ability to enter new requests right from within browZer:

shipped in 0.59.0


Credentials Encryption

Add encryption support for the stored credentials.
This is realized by Chacha8Poly1305 encrypting each credential separately using a Trussed-sourced encryption key.
Done:

Add encryption for each credential
Switch serialization method from postcard to cbor
Bump version to 0.5.0
Remove obsolete code, reformat and lint
Refactor: extract types and ctaphid interface
Add documentation for the encrypted container

See updated documentation at:
https://github.com/Nitrokey/oath-authenticator/blob/1b31c9a87236fcf27574f918bdfbf3c5aabbaecd/src/encrypted_container.rs#L50
To discuss:

[x] naming, e.g. of the methods provided in the EncryptedDataContainer type - are these intuitive enough?
[x] documentation for the errors - they look already self-descriptive - to confirm with the reviewer;
[x] does it make sense to use filename for the annotated data? That would protect from replacing the credentials under each label, but achieves only DOS AFAICS.

To be squashed after review.
Further work:

[ ] change serialization method for the App's state from postcard to CBOR #17

Quick summary for the storage capacity on NK3 CN LPC55 for OTP, 160b secret:

Unencrypted: 64 credentials (48 bytes each; no-encrypted-credentials feature active)
Encrypted: 35 credentials (87 bytes each, including 28 bytes of crypto overhead)

Firmware: v1.2.2-alpha.20221130-0-g6e2ce7c, modified by setting this PR as oath-app. 2x CBOR serialization.

@sosthene-nitrokey Thanks for the review! Do you have anything regarding to the "To discuss" part?

I think one thing that should be fixed is that currently everything is public. I would be better make public only what is necessary.
Regarding the "to discuss":

Naming looks OK to me
Documentation of error looks OK to me, but I think errors should be in an error module instead of in the encrypted_container module.
Filename as associated data: that's a good point, and could actually be used to confuse keys since we don't check that the label we loaded was the one we expected. I'm in favor of adding it to the associated data.

Regarding the second point, these errors are related only to the encrypted_container content, and not the application itself. I had here easy extraction in mind, and potentially moving it to a separate crate.
Regarding the public scope, do you mean the encrypted container type, or the application as a whole? If the former, what would you remove?

Pretty much everything is public, including internal implementation details. The only thing that should be public is probably the authenticator module.

I take from this you mean the application as a whole. I agree it should be better encapsulated.
Let's address that in another PR then. I will see what I can do regarding the credentials encryption.

* Filename as associated data: that's a good point, and could actually be used to confuse keys since we don't check that the label we loaded was the one we expected. I'm in favor of adding it to the associated data.

Turns out that can't be done with the current iterating over files to explore saved credentials, as Trussed's read_dir_files_* do not return the file name. Leaving that for the future.

In that case when loading an given label we need to check that the label we loaded matches the label we expected.

I've added label check, and this passes the tests. The CBOR workaround is removed as well.

@robin-nitrokey Thanks for the review! Updates added in 55c48e9b3d1255b931c60926a94906c0c2f77bd5, will be merged after the current PRs.


feat(consensus): sequencer context broadcasts votes

This change is

#2422  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 92 at r1 (raw file):

    pub fn new(
        batcher: Arc<dyn BatcherClient>,
        _proposal_streaming_client: BroadcastTopicClient<ProposalPart>,

How is this still the case?
Code quote:
_proposal_streaming_client

Merge activity

Dec 4, 2:32 AM EST: A user started a stack merge that includes this pull request via Graphite.


Remove sherlock

Deal with PR #112 first, as this builds upon it
This PR removes ActionBarSherlock completely in preference of AppCompat

Works well for me. :)


doing attention visualization or class activation map for tex

Hi, I find posts like this for image using cnn:
https://github.com/jacobgil/keras-cam
https://blog.keras.io/how-convolutional-neural-networks-see-the-world.html
Any idea on doing this for a LSTM network (a keras implementation of this document classifier(they call it QA but it is not)):
[https://arxiv.org/pdf/1602.03609v1.pdf]
If anyone knows any resources or has any idea, please let me know. I cannot find any open source code from people publishing pictures of highlighted text.
Currently, the only thing I can think of is either replacing LSTM with CNN or stacking the LSTM with a CNN and adapt the image code.
Many thanks in advance for any feedback
Please make sure that the boxes below are checked before you submit your issue. Thank you!

[ ] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[ ] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[ ] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

Have a look at this:
https://github.com/philipperemy/keras-simple-attention-mechanism


Evaluate architecture design between ApplicationManager, RecipeManager and InferenceServer

Is your enhancement related to a problem? Please describe
Following https://github.com/containers/podman-desktop-extension-ai-lab/pull/1503 we need to improve the way components are interacting togethers.
Describe the solution you'd like
See discussion and proposal on https://github.com/containers/podman-desktop-extension-ai-lab/pull/1503#issuecomment-2288133263
Describe alternatives you've considered
No response
Additional context
No response

See https://github.com/containers/ai-lab-recipes/issues/758