dispose failed due to Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

A little context:
my application renders 3d splat model inside a div in a component. When i navigate away from the div and unmounts the component, i do a viewer.dispose but it always fails due to that error.
My canvas is not the child of the document.
Also, this stemmed from another issue.
The event listeners WASD, was not cleaned up properly and after i load the gaussian 3D model from the .ply file using a normal Viewer (not drop in), my WASD are disabled through my application permenantly until a refresh of the tab.
This is my code to initialise the viewer:
viewer = new GaussianSplats3D.Viewer({         cameraUp: [0, 1, 0],         initialCameraPosition: [0, 0, 7],         initialCameraLookAt: [0, 0, 0],         rootElement: containerRef.current,         sharedMemoryForWorkers: false,         dynamicScene: true,       });
this is how i dispose it:
viewer           .dispose()           .then(() => {             console.log('viewer disposed');           })           .catch((err: any) => {             console.log("Didn't successfully dispose viewer", err);           });

So my question is, i wonder why is the event handlers not cleaned up properly, and how do i properly dispose it?
Im wondering when your dispose function promises catches an error, does the keyboard listener still get removed?

After investigation, it seems like it is orbital controls fault that the event listeners are not being cleaned up. Any suggestions on how to clean it up?

Ok i found the fix. in your viewer's dispose,
add in
 this.orthographicControls.dispose(); this.perspectiveControls.dispose();

Ah, good catch! I'll add this fix to the next release.

I pushed an update to the memory-optimizations branch, could you see if that fixes it for you?

So apparently I lied earlier 😄 The change should be in there now.

HAHA xD
Yes it works! Thanks :D Looking forward to next release

Great! The next release should hopefully go out in the next couple of days.

These changes are all now in the latest release, v0.4.5

Thanks for your amazing talent and contribution ser


Split off builtin function builders

sort alphabetically
add some of the missing builtins used for ints
comment on what is "correct" for future additions
comment on the current remaining missing builtins
comment on the current incoherent method names

https://github.com/aiken-lang/aiken/discussions/726

I'll finish taking a look tomorrow.


sark configuration => rhizome

moving spark configuration and pod to rhizome in bits and pieces

LGTM, we should check transitive dependencies of spark to make sure we're not shooting ourselves in the foot.


IIDX 9-13 magnetic readers support

I would like to request IIDX 9-13 magnetic readers support in btools make real readers work with arcana.

Considering that hardware is difficult to get these days, I don't see this being prioritized by the team at least. Naturally, if anyone wants to pick this up for fun and get it merged upstream, we are happy to support them.
One technical problem to solve/handle that comes to my mind is that the magnetic cards only have 6 bytes of card ID payload. The rfid slot/wave pass cards have 8 bytes of card ID payload. This needs to be considered for the implementation as it's likely that the server backend checks cards for validity, e.g. E004 prefix.


CM 14?

Hi, is this project dead? Or are there plans to update the script for CM14? Thanks!

There's already a discussion for CM13.
We can only remove some parts of proprietary apps/services.

push

CM14 removed ambient sdk, the only non-free apps left (because of Play Services integration) should be LockClock, SetupWizard and Gello

@mar-v-in I saw that you updated the database path for android 7+. Wouldn't it be better to make it more compatible with older versions by querying the system version via getprop and using the appropriate path?

Isn't /data/data/... also valid on cm-14.1?

@GeitHub I don't think there is any need to change the script since it also applies to cm-14.1.

Does it work with LineageOS, because CM is dead?

@beerisgood sure...


chore: updated code owners for auto-assign of reviewers

Description
Changes proposed in this pull request:

updated code owners for auto-assign of reviewers

Related issue(s)

/restart


Improve UI of Footer on the Landing Page

Description: The current footer design on the landing page could be enhanced for better visual appeal and user experience. The suggested improvements include:
Layout Redesign: Organize the footer sections more intuitively, ensuring key links like Contact Us, Privacy Policy, and Terms of Service are easily accessible.
Responsive Design: Ensure the footer displays correctly across all devices (mobile, tablet, and desktop), maintaining a consistent look.

Hello @Dipu2552003 ,
I hope you're doing well! I came across issue #590 regarding Improve UI of Footer on the Landing Page. I’m really interested in contributing to this project, and I believe my skills in html and css make me a good fit to address this issue.
I’d love to take this on and help out. Could you please assign me to this issue? If there are any specific guidelines or expectations, I'd be happy to follow them.
Thank you for considering my request. I look forward to contributing!
Best regards,
Sagar Porwal
Sagarporwa1

Hello @anuragverma108 ,
I hope you're doing well! I came across issue #590 regarding Improve UI of Footer on the Landing Page. I’m really interested in contributing to this project, and I believe my skills in html and css make me a good fit to address this issue.
I’d love to take this on and help out. Could you please assign me to this issue? If there are any specific guidelines or expectations, I'd be happy to follow them.
Thank you for considering my request. I look forward to contributing!
Best regards,
Sagar Porwal
Sagarporwa1

Hello @anuragverma108 ,
I hope you're doing well! i came across issue #592 regarding improve ui of footer on the landing page.
I’m really interested in contributing to this project, and i believe my skills in html and css make me a good fit to address this issue. i’d love to take this on and help out.
could you please assign me to this issue? if there are any specific guidelines or expectations, i'd be happy to follow them. thank you for considering my request. i look forward to contributing! best regards, sagar porwal sagarporwa1

Hey, I have made a PR on this issue. Please check it and let me know.


rp: Allow zero len reads for buffered uart

Prevents the read methods from getting stuck forever.
cc @MathiasKoch can you test if this fixes the problem you described in the chat?

Will give it a test first thing Monday morning 👌

I think write has the same bug?

Indeed, added the same checks for the write methods.


Changing observable response structure

Right now from the Observable we return the data in the following format:
data.queryName
that makes the need of another pipe in Angular 2.0 on top of the default async pipe that handles observables.
As we are always returning one query, maybe it's a good idea to return the observable without those prefixes.
The question is how to handle errors.
I think that we should use the stadard way with supplying an error function hanlder, as specified here:
https://github.com/zenparsing/es-observable
and here: http://reactivex.io/rxjs/class/es6/Observable.js~Observable.html
@martijnwalraven @stubailo

We already use the error handler for true errors like network errors, but the question is what to do with graphql errors.
The issue is that a graphql response can include both partial results and a list of errors. So we would have to either not support partial results or include some other way of getting access to the errors.

I think this is just inherent to GraphQL, plus what would you do if you had two root queries, which is totally possible? I guess we could say you should make two observables.

To put a point on it, I am pretty confident that the thing the observable returns should be identical to the response sent from the GraphQL server, which is an object with data and errors.


Error missing dll files only in version 1.5

When i open the MouseToVJoy from 1.5 i got 3 errors of missing dll:
"A code execution can not continue because MSVCP140D.dll was not found. Reinstalling the program to correct the problem."

"A code execution can not continue because VCRUNTIME140D.dll was not found. Reinstalling the program to correct the problem."

"A code execution can not continue because ucrtbased.dll was not found. Reinstalling the program to correct the problem."

So after put them on SysWOW64 for try to fix this i got a other error:

"The application could not be initialized correctly (0xc000007b)."
As you can see in the screenshot below, version 1.4 works correctly:

I haven't used nothing new in 1.5, but I compiled it on Windows 10, try to reinstall Microsoft Visual C++ Redistributable 2015, If this is not the case, then I will recompile it and maybe this will fix this issue. (I am currently using 1.5 version without any problem.)

That's weird, i already tried to reinstall Microsoft Visual C++ Redistributable 2015 even without knowing about it but didn't work.

That's weird, i already tried to reinstall Microsoft Visual C++ Redistributable 2015 x64 and x86 because of another aplication but didn't work.

That's weird, i already tried to reinstall Microsoft Visual C++ Redistributable 2015 x64 and x86 but didn't work.

I think it can be a problem on my side. I will recompile it and you will check then

Oh ok

Check it now. I reinstalled my VS and recompiled MTVJ, if it won't fix it, then I don't know what will.

Damn, nothing.

hmm I really have no idea what is the problem. I will try to find a fix,

I have the same problem, 1.41 works without any problems.


CPM Embedded Editor (Beta) Chrome 106 CPM 0.6.3_1 Error

Trying to open any .cpmproject from the computer results in an error
VM335:204 Uncaught Error: java.lang.ClassCastException
at p$d.Xe [as zc] (:204:49)
at p$d.bf [as Ec] (:204:310)
at p$d.ef (:205:48)
at p$d.hf (:208:19)
at new p$d (:5680:27)
at Cme (:6377:34)
at Gs (:36:18)
at oLd (:5226:44)
at Function.sLd (:5229:60)
at HTMLInputElement.d (:18:47)

And when you try to save something


Add document streaming plugin and grpc interfaces

Codecov Report

Merging #147 (d004dfc) into main (3ab1f50) will decrease coverage by 0.44%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   46.84%   46.40%   -0.45%
==========================================
  Files          33       33
  Lines        3249     3278      +29
==========================================
- Hits         1522     1521       -1
- Misses       1615     1644      +29
- Partials      112      113       +1

Flag
Coverage Δ

unittests
46.40% <0.00%> (-0.45%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/adapters/grpc/document_grpc.go
0.00% <0.00%> (ø)

pkg/plugins/document/plugin.go
0.00% <0.00%> (ø)

pkg/plugins/gateway/lambda/lambda.go
68.42% <0.00%> (-0.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab1f50...d004dfc. Read the comment docs.


Elaborate on Forecast Models for Project Forecasts v. Forecast Models for Project Budgets

Use separate Forecast Models for Project Forecasts than for Project Budgets.  On Forecast Models for Project Forecasts, set value for Budget Type = None.  For Forecast Models for Project Budgets, set value for Budget Type = Original budget or Remaining budget or Carry-forward according to needs.  Note: When Budget Type is set to a value other than None, then the value of the Stopped field will be set to Yes to indicate that the parameters for the Forecast Model cannot be changed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3794964c-2c67-905b-98e8-6a2ecf978c23
Version Independent ID: 66dd3a35-d3f1-3e82-5de2-20febaca9f64
Content: Project forecasts and budgets - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/financials/project-management/project-forecasts-budgets.md
Service: dynamics-ax-applications
Product: ****
Technology: ****
GitHub Login: @KimANelson
Microsoft Alias: knelson

@ggriffith25, thanks for posting this!
@KimANelson, please review and update the content, if appropriate.

Bug 350547 has been logged to track this issue.

Also, when the Forecast Models are setup with Budget Type filled in (and not blank), the form will show a value for Stopped = Yes.  This value for Stopped=Yes, appears to mean only that the settings for that particular Forecast Model ID are "stopped" and cannot be changed.  It does not mean that the Forecast Model ID itself should not be used because it is "stopped".  Each of the three values for Budget Type when it is filled in can be used only once.  When the value for Budget Type is blank, multiple Forecast Model ID's can be set up.

Note: There is a pending/new product change related to this top.
Release: Dynamics 365 for Finance and Operations | 10.0.7
LCS quantity report number: 370574
KB 4520681

I am using the version of Update57 and Platform10.0.33. Does anyone have a solution how can I create different type of forecast models by selecting budget type.
I am still facing the same issue like when I create a new model group and select the budget type everything gets greyed out and the Stopped button toggles to Yes.


Add possibility to disable drag rotation

Currently the map always lets the user to pitch and rotate the map when right clicking and dragging. This should be able to be disabled.
options.dragRotate - https://www.mapbox.com/mapbox-gl-js/api/#Map

Publish with the version 0.25.0


canonical url needs to ignore specified params

Canonical URL should not capture all the parameters provided in the URL. So we need to specify what parameters to ignore when generating the canonical URL. For example, on a product listing page I would need to ignore a "sort"parameter and point all the sorting links to the one specific product page.
Ex:

www.mysite.com/mens/dresses?sort=by_price
www.mysite.com/mens/dresses?sort=by_date

Canonical URL for above two samples should be.
www.mysite.com/mens/dresses
So I need to tell to ignore 'sort' param when generating the canonical url. That is why this change is proposed.

This does not make any sense.
Url::canonical() composes URL from route and action params, which are declared as action method arguments.
You should either remove 'sort' from action arguments or compose URL manually instead of usage of Url::canonical().


Create pseudocode for cpp

Making a cpp pseudocode generator.

The deployed converter is not working, I tried to convert this :
#include <iostream>
using namespace std;

int main(){
int a = 10,b = 5;
if(a>b){
cout<<"A is large";
  }
  else{
  cout<<"B is large";
  }
}

hits the convert button but nothing comes out in the output .. or i am doing something wrong with example fo source code

The deployed converter is not working, I tried to convert this :
#include <iostream>
using namespace std;

int main(){
int a = 10,b = 5;
if(a>b){
cout<<"A is large";
  }
  else{
  cout<<"B is large";
  }
}

hits the convert button but nothing comes out in the output .. or i am doing something wrong with example fo source code

The server is not hosted right now. Were you testing locally? And yah there is some indentation/line issue sometimes with the cpp converters but it works.

Declare Function main
Declare 6 Integer variable a = 10 b = 5
Check if a>b
If True then :
Print  A
Print  is
Print  large
Print  B
Print  is
Print  large

Here is the pseudocode generated by the converter

The server is not hosted right now. Were you testing locally? And yah there is some indentation/line issue sometimes with the cpp converters but it works.

yeah, I was testing on Heroku deployment, will test it out local server now and will try to optimize converters.

Declare 6 Integer variable a = 10 b = 5

shouldn't it be a
Declare 2 Integer  variable a = 10 b = 5

Also, endl is not getting ignored!

Declare 6 Integer variable a = 10 b = 5

shouldn't it be a
Declare 2 Integer variable a = 10 b = 5

this can be fix using temp.size() - var_name.size() + 1 at #L184 && #L185
before : outFile << "Declare " << var_name.size() << " " << keyword[Data_type] << " variable ";
after: outFile << "Declare " << temp.size() - var_name.size() + 1 << " " << keyword[Data_type] << " variable ";
but we have to create string temp = "" globally and implementing actions on that but then, this is causing error  like this:

Lots of vars. are showing.

fixed the issue, creating PR

fixed the issue, creating PR

Great!! I will have a look.


Tools to forward third-party log messages into apex/logrus

func main() {
	log_ecslogs.InstallDefaultLogOutput(&logrus_ecslogs.Forwarder{
		Level: logrus.InfoLevel,
	})

	log.Println("you got it")
	log.Println("no more trash in stdout")
}

time="2017-04-18T17:20:39-07:00" level=info msg="you got it"
time="2017-04-18T17:20:39-07:00" level=info msg="no more trash in stdout"

func main() {
	log_ecslogs.InstallDefaultLogOutput(&apex_ecslogs.Forwarder{
		Level: apexlog.InfoLevel,
	})

	apexlog.SetHandler(json.Default)

	log.Println("you got it")
	log.Println("no more trash in stdout")
}

{"fields":{},"level":"info","timestamp":"2017-04-18T17:23:53.479003856-07:00","message":"you got it"}
{"fields":{},"level":"info","timestamp":"2017-04-18T17:23:53.479222786-07:00","message":"no more trash in stdout"}

I think I get the point of this PR but it seems a little out of place, this repo is intended to support ecs-logs for Go, I feel like those changes would better belong in the apex and logrus repos.
Or maybe we should pull the log package compatibility layer into a different repo?
Let me know what you think.

I was looking for a right place to put it and couldn't find anything better although putting it here is a stretch.
The motivation was that when I use ecs-logs-go to get correctly formatted log output for my project I would also want to deal somehow with the output of third-party libraries to avoid getting junk in the logs. Both actions fall into "set up logging" sort of things and serve a purpose to adapt one logging format to the standard one.

We can totally put the compatibility layer into another repo though.

The purpose of this repo is to provide building blocks to work with the ecs-logs format, I feel like it doesn't make sense to add support for other log formats here.

Actually, I realized that the lib already contains everything needed to achieve my goal:
func main() {
	handler := log_ecslogs.NewHandler(os.Stdout)
	writer := log_ecslogs.NewWriter("", log.Flags(), handler)
	log.SetOutput(writer)

	log.Println("you got it")
	log.Println("no more trash in stdout")
}

{"level":"INFO","time":"2017-04-19T11:13:48-07:00","info":{},"data":{},"message":"you got it"}
{"level":"INFO","time":"2017-04-19T11:13:48-07:00","info":{},"data":{},"message":"no more trash in stdout"}

Cool! I must have mistaken what you wanted to achieve then, glad it's working the way you need.


Git rebase

Can you please add a keyboard shortcut for git rebase? We use it all the time at our company and it's missing in TGit.

Added!
Grab the new release :)

Very nice! 👍


[Bug][tcgc]: Does not honor encodedName correctly

Describe the bug
I try to migrate Search service to use tsp.
Here are the converted tsps: https://github.com/Azure/azure-rest-api-specs/blob/search_tsp/specification/search/Azure.Search
You can see in https://github.com/Azure/azure-rest-api-specs/blob/search_tsp/specification/search/Azure.Search/models-service.tsp#L6446 I have
@pagedResult
model ListIndexesResult {
    /**
     * The indexes in the Search service.
     */
    @visibility("read")
    @items
    @encodedName("application/json", "value")
    indexes: SearchIndex[];
}

I expected that in the generated code, it should attempt to parse "value". But unfortunately it generated deserialized["indexes"]
https://github.com/Azure/azure-sdk-for-python/blob/search_11.5.0_tsp/sdk/search/azure-search-documents/azure/search/documents/_generated/operations/_operations.py#L3730
Reproduction
Try to generate Python code using https://github.com/Azure/azure-rest-api-specs/blob/search_tsp/specification/search/Azure.Search
Checklist

[x] Follow our Code of Conduct
[x] Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
[x] Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
[x] The provided reproduction is a minimal reproducible example of the bug.

I think it is not a tcgc issue. The nextLinkPath and resultPath returned by TCGC is client name. If emitter needs to use wire name, it should convert the path with model property wireName.


feat: fixed for the issue (#35)

1. Description

1.1. Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples.

1.2. Breaking Change

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

1.3. Related Issues

bors merge

Codecov Report

Merging #37 (a3d98c0) into main (f64d156) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main     #37   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          1       1
  Lines          4       4
=====================================
  Misses         4       4

Impacted Files
Coverage Δ

lib/src/scope.dart
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


cmd/compile: discard blank functions/methods after typechecking

Blank functions and methods need to pass typechecking, but they don't affect the final program at all. We should just discard them after typechecking and not bother compiling them. This will simplify unified IR somewhat, because then it doesn't need to worry about representing blank functions in export data: they can just be skipped over completely.
I think the only thing preventing this today is that some test cases in $GOROOT/test use blank functions/methods to exercise backend code. Those should be changed to use named functions so they continue actually testing the backend.

This is fixed on dev.typeparams.


Paging support for find by Work In Progress Closes #834

This is my Work in Progress PR for Issue #834

Really good job! Thanks for refactoring

Alright

what is your nickname on chat? did you joined it?

I'm using my full name, Usiwoma Oghenovo

@wtrocki Am I missing anything?

This looks really good. I will try to review and test it early tomorrow. Thank you so much for your contribution

This looks and works as it should! Thank you so much for amazing contribution to graphback!


[fine_tuning] visualizations: ibm_comparison: new visualization module for comparing RH and IBM results

…

I merge this one, it's standalone regarding the rest of the fine-tuning project.


App not running when linking react-native-local-notifications v0.60.5

@wumke  I'm using react native v0.60.5 "react native link" is not used anymore to link component, when trying to run it in xcode the following error appears:
'RCTBridgeModule.h' file not found
is there any way to link react-native-local-notifications using cocoapods or how can we fix this issue?
react-native": "0.60.5",
"react-native-local-notifications": "2.0.0"

hi @ahmadallo1
i had faced same problem at IOs
Binaries:
Node: 12.4.0 - /usr/local/bin/node
Yarn: 1.17.0 - /usr/local/bin/yarn
npm: 6.12.1 - /usr/local/bin/npm
Watchman: 4.9.1 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
Android SDK:
API Levels: 23, 26, 27, 28, 8
Build Tools: 23.0.1, 26.0.3, 27.0.3, 28.0.1, 28.0.2, 28.0.3, 29.0.2
System Images: android-22 | Google APIs Intel x86 Atom, android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.4
Xcode: 10.3
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.3 => 0.61.3
npmGlobalPackages:
create-react-native-app: 1.0.0
react-native-cli: 2.0.1
"react-native": "0.61.3",
"react-native-local-notifications": "2.0.0"
and
i found a  workaround  like this:
i have unlinked and uninstalled react-native-local-notifications
i have installed react-native-local-notifications (like a fresh start)
then i have added
RNLocalNotifications.podspec file to
node_modules/react-native-local-notifications/
my RNLocalNotifications.podspec file is like :
https://gist.github.com/mrblgn/f480aa4a0bf515ea373939fdb0788e6f
then i run
cd ios && pod install & cd ..
command on terminal, like other libraries that have added for RN > 0.60
@wumke should add 'RNLocalNotifications.podspec' file to the project for React Native > 0.60 projects at next release.

Merged PR https://github.com/wumke/react-native-local-notifications/pull/32
Should work now (Use direct repo link npm version not yet updated!)
Since I do not use RN0.60+ yet, can anyone confirm that this issue can be closed?

@wumke
PR #32 is not enough, this repository has to migrate and use Androidx packages instead of support libraries. please read this section

I've had great success with the Android Studio migration tool, that fixed AndroidX migration of all libraries in a project which I needed to migrate.
You can use that as a temporary workaround, and if you like you can check what changed and create a PR (I'm not into RN at the moment... upgrading and refactoring a huge backend)

I've had great success with the Android Studio migration tool, that fixed AndroidX migration of all libraries in a project which I needed to migrate.

This could not be used in a build CI and it's needed to migrate the repository itself. I'll submit a PR as soon as I could.

I've had great success with the Android Studio migration tool, that fixed AndroidX migration of all libraries in a project which I needed to migrate.

This could not be used in a build CI and it's needed to migrate the repository itself. I'll submit a PR as soon as I can.

Thank you (in the name of all users of this library)!
Place a reference to this thread when you  create the new pull request...

@wumke
I have submitted the PR.
@ahmadallo1
since I'm not using RN V60+ yet, I can not test if everything is OK or not, can you test it on your project and give me feedback?
for using the PR on your project change your package.json like below
{
  "react-native-local-notifications": "git://github.com/SaeedZhiany/react-native-local-notifications.git#MigrateToAndroidx"
}

@wumke For linking issue i have fixed by adding these path in to the XCode project file.
try these steps:

Go to Project navigator > Libraries > RNLocalNotifications.xcodeproj
lick on Build Settings and then the first item under "Targets"
Scroll down to 'Search Paths'
Double click to edit the 'Header Search Paths'
Add the following entry (click '+'): ${SRCROOT}/../../../ios/Pods/Headers. Make sure to set it to recursive.
Clean (cmd + shift + K) and re-build (cmd + B)


L124355: Adding break-line before snippet

Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description: Missing break-line before snippet is preventing content to show properly.

Hi @Rick-Anderson, can you please help us by merging this PR?
Thanks in advance.

Thanks to you @scottaddie for approve it.


Revert 3 register/j lisp/v0.1.0

Registering package: JLisp
Repository: https://github.com/christopher-dG/jlisp
Created by: @christopher-dG
Version: v0.1.0
Commit: f451bdc053c56af4d2800a5f7ed38af3b8b2b644
Git reference: master

mistake, meant to open on a fork


imodel02 PR validation

Is your feature request related to a problem? Please describe.
The imodel02 branch exists for changes to itwinjs-core that depend on changes to the native addon code. Currently PRs against this branch undergo no validation. This leads to problems only being discovered when someone attempts to integrate a newly-published addon into master, often requiring chasing down developers to fix issues or even discarding the newly-published addon if fixes are required in native code. This is a waste of everyone's time and only discourages people from regularly producing new addons, worsening the severity of the problems discovered when doing so.
Describe the solution you'd like
Ideally, when a developer submits a PR against the imodel02 branch, the corresponding native changes would be used to produce an addon, and PR validation (build, test, lint, extract-api, docs) would run using that addon, failing the PR if anything goes wrong. Also, required reviewers would be enforced per CODEOWNERS.
Describe alternatives you've considered
Additional context

This can be broken down into two main areas:

[ ] Turn on Codeowner PR validation
[ ] Add build validation:

[ ] Main iTwin.js pipeline
[ ] Docs
[ ] Integration tests

The codeowner enforcement should be able to happen before agnostic to any build validation running and could be enabled quickly. I will look into that today.
Build Validation
With build validation, there are a few different pieces required since builds need to be coordinated between the two different PRs in different repos. With requiring the @bentley/imodeljs-native changes to be merged into the master branch of that repository at the same time as the Typescript PR is merged into the imodel02 branch, there is an order of operations that needs to happen and a few questions.
Option 1

Create @bentley/imodeljs-native PR
Two things are happening in parallel
a. @bentley/imodeljs-native PR builds and runs all tests. Does not publish packages for testing
b. Create itwinjs-core PR into the imodel02 branch with a specific format to "link" to the native PR
- A suggested footer on PR description. Native PR: xxxx where xxxx is the PR number but not a link
A new iTwin.js pipeline is queued that builds the native portion, publishes as a pipeline artifact and then as a separate stage the iTwin.js build consumes

This would include a pipeline needed for each main build & test, Docs and integration tests today

Benefits

Native side changes are validated prior to the opening the Typescript side

Downsides

Duplicating the native build, which takes upwards of 60 - 70 minutes in most cases, for every pipeline.

Option 2

Create @bentley/imodeljs-native PR
@bentley/imodeljs-native PR builds, runs all tests and publishes packages for consumption testing of itwinjs-core.
Create itwinjs-core PR into the imodel02 branch with a specific format to "link" to the native PR

A suggested footer on PR description. Native PR: xxxx where xxxx is the PR number but not a link

A new iTwin.js pipeline is queued that pulls the packages published from step 2

Benefits

Reduces the overall build machine required by building the native code once and all Typescript side validation consumes it

Downsides

Increases every native PR time to support publishing packages unless there is something introduced to flag the build to run only if there is a corresponding typescript PR.

Open questions

How do we handle invalidating the itwinjs-core PR when there is an update on the native side?
What builds do we need to speed up to make this possible? Analysis is needed on the way we build the native code in order to try and parallelize it more.
Would we want to validate every native PR by running the itwinjs-core tests? Not sure if this level is needed on every PR but should be done prior to release.
Do we need build caching for all iTwin.js pipelines to avoid building in each pipeline?

just turned on CodeOwner reviews required.

Don't we have the option now to eliminate the imodel02 branch and most of the manual addon publishing process entirely?

Don't we have the option now to eliminate the imodel02 branch and most of the manual addon publishing process entirely?

@pmconne not quite sure what you mean? Would you want to publish a new addon version for every native change?

Would you want to publish a new addon version for every native change?

The fork (and soon, repo) for the native code exists solely for changes we want to incorporate into the addon. Why shouldn't each be a discrete version instead of someone else manually publishing accumulated changes into a new version at some later date? Your option 2 suggests publishing native packages for every native PR anyway. Some native PRs will have no corresponding itwinjs-core changes but can nevertheless break and therefore be validated against itwinjs-core.

If we are using a pipeline triggered by a native PR to drive this process, and linking a typescript PR to that native PR build, we can post commit statuses back up to the linked typescript PR, and update that status manually as the build runs. You can see an example of what those statuses look like in a PR here. You can either create new statuses, or update existing ones using this API.
One point to note, is that a commit status targets a specific commit rather than a PR or a branch. If a new commit is pushed up to a typescript PR, it will only list those statuses associated with the HEAD commit of the PR branch. However we pull in the SHA for the head commit of the linked typescript PR in our pipeline, we would have to rerun the larger PR anytime a new commit was pushed up on the typescript side.
As far as requiring these commit status in a PR, the simplest approach would be to require that check as one of the branch protection conditions for the "imodel02" branch in GH. If more flexibility is required, we can use the post_check action
provided by mergify, and define a more complex series of checks/conditions. We could then require that check as a branch protection rule instead.

@calebmshafer @skirby1996 what's the status of this? I'm tired of wasting time fixing everybody's merge conflicts, tests, lint, etc etc.

Still working on the pipeline. Close to completion but hit an issue and currently looking for solution.

@DanRod1999 any progress?

I put in two draft PR's, but haven't been able to do look over them with anyone. My pipeline appears to function properly except when rush cover runs on Linux. Also I had to change a few pipelines that used a template that I changed, so I need to make sure those aren't broken
https://github.com/iTwin/itwinjs-core/pull/4278
https://dev.azure.com/bentleycs/iModelTechnologies/_git/imodel02/pullrequest/278935
https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=1680461&view=logs&j=b002de06-6b71-5d1f-d201-8e3d22ebcd72&t=6b47f363-a71a-5215-ba5b-263e7c85bc93

Status? Are you just still waiting for someone to look at your PRs? @calebmshafer I am wasting so much time trying to track down image regressions.

Status? Are you just still waiting for someone to look at your PRs? @calebmshafer I am wasting so much time trying to track down image regressions.

I ran into some issues earlier this week, but now its fixed. I was going to send out an email to Caleb, Bill, and Seamus to look over the PRs now. The only problem I'm still running into is rush cover always fails on Ubuntu-Latest vm, and I can't run that job on our imodeljs linux agents because they don't have 'unzip' installed. I need to talk to @calebmshafer  to see if we can install 'unzip' to fix that problem, since imodeljs linux is the appropriate pool for this anyway.
Other than that the pipeline I believe is done, and I wanted to talk to @skirby1996 about testing it, but I believe he was out earlier this week

The only problem I'm still running into is rush cover always fails on Ubuntu-Latest vm, and I can't run that job on our imodeljs linux agents because they don't have 'unzip' installed. I need to talk to @calebmshafer to see if we can install 'unzip' to fix that problem, since imodeljs linux is the appropriate pool for this anyway.

Talk to Chuck K

@DanRod1999 for now just do an apt install for the package you need as a script task in the build.
We can update the actual image later. I can show you where to make that change tomorrow.

Validation between core and native
https://github.com/iTwin/imodel-native/pull/56
https://github.com/iTwin/imodel-native-internal/pull/22
Validation between native and internal
https://github.com/iTwin/imodel-native-internal/pull/38


Handle secret name/namespace edition

The PR handles force k8s secret deletion/create when name or namespace change in the bitwarden secret

This is a usecase that i did not consider but makes a lot of sense as well. The other object types (registry-credential and bitwarden-template) also miss this functionality. would you mind implementing this for them as well?
If not i will take care of it afterwards before releasing a new version :)
Thank you very much :bow:

@Lerentis it's ready !

Thanks @titilambert!
do i understand you right that you don't want to implement the fix for the behaviour for the other 2 CRDs and i should follow up on that after the merge?

Sorry, I was not clear. I saw a bug, that's why I ask you to wait before merging.
Also, I'm using only secret (no templates), so, I'm not able to really to test the other types.
So, if you can do it for the other resources, it would be perfect.
Thanks !

Okay thank you very much :+1:
i will follow up with the other two probably tomorrow and release right after it


'_ lifetime (RFC 2115)

This is stabilized in 1.26.

[x] Add '_ to Lifetime grammar
[x] Explain how it works in lifetime-elision.md
[x] Use it in examples

Is this complete? Or are we keeping open for if it becomes required in the 2018 edition as well?

I've check for any other places where '_ could be used and I think that there aren't any.


Add Github Actions

Questions
Answers

Description?
Add Github Actions

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
Relative to PrestaShop/PrestaShop#26767

How to test?
N/A

build-release.yml not at the latest version, please fix @Progi1984

@jf-viguier Fixed


API exception handling makes homeassistant sad.

See: https://github.com/home-assistant/core/issues/60459
Basically, what the dev team told me was that this library, handling the exception via a broad exception handler, and then logging, passes the whole exception into the logs of HA.  Suggestion was:
I’d pull out the broad except handlers and let it raise + add the response.raise_for_status() then handle it in Home Assistant
Not sure if this is something you'd be willing to tackle?

Sorry for the lack of response.  All I have to say at this point is "Patches welcome".


Fix url and homepage to use SSL in Unified Remote Cask

The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly
makes it more secure and saves a HTTP round-trip.

Looks good, thanks! :+1:


Extension tries to access clipboard

I am using this excellent extension in VS Code on Gitpod (Cloud IDE). Unfortunately, when the extension is enabled and I edit the templates, I always get the message that it tries to access the clipboard (entire message below). As soon as I disable this extension, this message no longer pops up. Does this extension really need access to the clipboard? (Quite problematic as this is not fully supported in Firefox.)
Unable to read from the browser's clipboard. Please make sure you have granted access for this website to read from the clipboard.

Very strange, the extension does not use the clipboard in any way. Maybe djLint does, but I highly doubt it.
Hey, @christopherpickering, what do you think?

Hey @monosans , I was just checking this out as well. @monosans is right, there is no clipboard access in djlint through python or through the extension.
It seems like vscode in gitpod uses the clipboard. @medihack what browser + version are you using? I don't have any issues in safari, chrome, and firefix v107.
Have you tested other formatters to see if you get a similar message?
https://www.gitpod.io/docs/configure/user-settings/browser-settings

Hm, that's strange. I could replicate it on two different Windows 11 PCs with Firefox v111.0. It doesn't happen in Chrome. I investigated a bit further. It only happens when both batisteo.vscode-django and monosans.djlint extensions are enabled (I disabled all other extensions to be sure).
My VS Code settings file also has nothing special. See https://github.com/radexperts/adit/blob/dev/.vscode/settings.json The project is fully open source. So if you have a Gitpod account, you could simply give it a try (just spin up the dev brunch in a Gitpod container under FF, open e.g. 404.html and type some stuff in there).

Thanks for looking into it. I will investigate it further, try to set up a minimal example and report back.

Ok, I tested it a lot now with a minimal example (https://github.com/medihack/djlint-clipboard) and the problem is indeed not the djlint extension, but the batisteo.vscode-django extension :-( I will open an issue over there, but it seems not too well maintained. Do you perhaps have a good recommendation what syntax highlighter to use for Django templates in VS Code?
And I am really sorry for wasting your time :-( Your extension works excellent.

Do you perhaps have a good recommendation what syntax highlighter to use for Django templates in VS Code?

I use batisteo.vscode-django, I have no problems with it.

the problem is  the batisteo.vscode-django extension

As far as I know, snippets can require access to the clipboard, you can try digging in that direction.


Check EUI for 'ttnctl applications use' command

Implement #151.

Looks good to me.
The util.GetApplications() should return a decent AppEUI so that you don't need to compare them as strings, but we're on that in another branch.


Jolt Physics Debug Renderer

Jolt Physics allows for a debug renderer. I don't see any of this having come across to the zig API yet, though, right? Or am I just missing it?
Is this something to be done (maybe even I could give it a shot and PR), or something that is left out for a reason?

You are correct, we don't have it yet. PR is very welcome.

I haven't yet figured out a clean-feeling way to turn on and off parts of code in zig like you can do in C with #ifdef. Short of conditionally appending fields to a type, which seems hack-y, I'm not sure how to exclude debug draw logic from the compilation based on a build option.
And maybe it doesn't matter, and I can just leave it in the code even if the option is turned off (and maybe the compiler will realize it's a dead branch and cut it out itself), but I wasn't sure what the project required as far as best practices for something like this.

Compiler won't figure it out - we need to do conditional compiling.
Something like below should work:
my_debug_field: if (debug_renderer) u32 else void,

Ok sounds good. That's more or less the direction I went in, lacking any better ideas. I'll check back in if any more questions arise. Trying to find time to finish it up still.

I had a question about the C typedefs:
In Jolt proper, types such as RVec3 are defined as helpers to mean an array of 3 "Reals," where Real is float or double depending on the precision define set by the user.
In JPC, though I see the Real arrays just being left explicit, as in const JPC_Real in_base_offset[3], when I expect it should be possible to make the same sort of typedefs that you see in Jolt proper. For example, by adding the last two lines after the exiting precision ifdef in JoltPhysicsC.h, like so:
typedef double JPC_Real;
#define JPC_RVEC_ALIGN alignas(32)
#else
typedef float JPC_Real;
#define JPC_RVEC_ALIGN alignas(16)
#endif

typedef JPC_Real[3] JPC_RVec3
typedef JPC_Real[16] JPC_RMat44Arg```

Is there a reason this hasn't been done, and could I do it for the code I add, or would it be better to keep doing it explicitly to remain consistent, OR would it be better to change existing code to use a new typedef?

I know it's not a big deal probably, but I wanted to check in.

@michal-z Would you mind taking just a moment to explain why you set up PhysicsSystemData as an appendage to the PhysicsSystem object from JPH? I'm trying to figure out if I should be using that for the debug renderer similarly to how it's used for the contact listener.
Failing that, I had just been planning to make some extra assumptions for the C port, based on the fact that the JPH debug renderer is a singleton, and probably end up with a private global vtable for it in JoltPhysicsC.cpp, with a public interface for setting debug renderer callbacks by providing a debug renderer object (whose vtable would then get copied into the global one), or something to that effect.
Speaking of which, it's odd that in JPH there can only ever be one debug renderer instantiated, yet the draw methods inside PhysicsSystem still ask for a pointer to a debug renderer, as if you could ever give it a different one.

Compiler won't figure it out - we need to do conditional compiling.
Something like below should work:
my_debug_field: if (debug_renderer) u32 else void,

Ok, actual real (concise) question that won't turn into rambling edits (hopefully): As a C API, JoltPhysicsC might be called from a myriad of different languages. Is it really good API design to have part of the API conditionally compiled? What if some language has even worse support for that than Zig does? Wouldn't it be better for the API to be unchanging, regardless of C/C++ #defines, but to alter its behavior based on those defines? Something like this, for example:
#if JPC_DEBUG_RENDERER == 1
JPC_API void
JPC_DebugRenderer_TriangleBatch_AddRef(JPC_DebugRenderer_TriangleBatch *in_batch)
{
    // Actually do the thing
}
#else //JPC_DEBUG_RENDERER
JPC_API void
JPC_DebugRenderer_TriangleBatch_AddRef(JPC_DebugRenderer_TriangleBatch *in_batch)
{
    assert(!"Must compile with JPH_DEBUG_RENDERER defined to use JPC_DebugRenderer_TriangleBatch_AddRef!");
}
#endif //JPC_DEBUG_RENDERER

Maybe my version is the actual API design faux pas, I don't really know. But any input would be appreciated.

I have made a PR. I think it turned out pretty clean, but let me know if you have any issues with the way it's put together.


feat(apps/prod/bazel-remote): increase bazel remote replica count and local disk size

replica to 4
local disk size to 500GiB

/lgtm


Unexpected Error

Hi, I've just installed dexter on my Centos7/PostgreSQL 9.6 server and tried to parse one log file, it pass first process but then it stops with the following error:
/opt/dexter/vendor/bundle/ruby/2.3.0/gems/pg_query-0.13.2/lib/pg_query/parse.rb:207:in block in load_tables_and_aliases!': undefined method map' for nil:NilClass (NoMethodError)
Can anybody help me fix this issue?
Regards!

Hey @maob85, can you paste the full stack trace?

Started
Processing 1053 new query fingerprints
No new indexes found
Processing 1954 new query fingerprints
/opt/dexter/vendor/bundle/ruby/2.3.0/gems/pg_query-0.13.2/lib/pg_queryrse.rb:207:in block in load_tables_and_aliases!': undefined method m for nil:NilClass (NoMethodError)
Did you mean?  tap
from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pg_query-0.13.2b/pg_query/parse.rb:186:in loop'         from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pg_query-0.13.2b/pg_query/parse.rb:186:in load_tables_and_aliases!'
from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pg_query-0.13.2b/pg_query/parse.rb:59:in tables_with_types'         from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pg_query-0.13.2b/pg_query/parse.rb:33:in tables'
from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/query.rb:16:in tables'         from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/indexer.rb:449:in each'
from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/indexer.rb:449:in flat_map'         from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/indexer.rb:449:in possible_tables'
from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/indexer.rb:30:in process_queries'         from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/processor.rb:66:in process_queries_without_lock'
from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/processor.rb:50:in block in process_queries'         from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/processor.rb:49:in synchronize'
from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/processor.rb:49:in process_queries'         from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/processor.rb:28:in block (2 levels) in perform'
from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/processor.rb:26:in loop'         from /opt/dexter/vendor/bundle/ruby/2.3.0/gems/pgdexter-0.2.1//dexter/processor.rb:26:in block in perform'

Hey @maob85, I've added some debugging on master. Can you try it with:
gem install specific_install
gem specific_install pgdexter

I've installed Dexter according to https://github.com/ankane/dexter/blob/master/guides/Linux.md as follows (after installing Hypo):
CentOS / RHEL 7
sudo wget -O /etc/yum.repos.d/dexter.repo
https://dl.packager.io/srv/pghero/dexter/master/installer/el/7.repo
sudo yum install dexter
I don't have gem installed (i'm no a ruby user) but I'll check how to install it if needed.

I've updated the package. It'll probably be 10-15 minutes before the build completes. https://packager.io/gh/pghero/dexter

Ok, i've reinstalled your package and rerun it... After first process it shows this (notice Error extracting tables.):
No new indexes found
Processing 1954 new query fingerprints
Error extracting tables.
Then shows many lines with this:
"Processing 0 new query fingerprints"
And it's hanged there... Don't know if it's normal...
Waiting for your comments... Thanks!

Thanks, the error looks like an issue w/ PgQuery. It looks like things are running normally. If you don't want Dexter to continuously watch the file, you can use:
dexter <conn-options> <log-file>

instead of tail. Also, if you didn't get any suggestions, you can use the --log-level debug2 option to debug why.

Oh! I see... Thank you very much... I'll make some test with my db then....
Regards!

Sorry to bother you again.. Running it with log-level as you suggested I can see this message "No new indexes found
Query 0177e78f9dfe6302b2138e7b4e1d65cca56e5b46f8
Could not run explain
"

Hey @maob85, that's expected for some queries. If it's happening for all queries, there's likely another issue at play.

Ok. I'll keep testing and inform you if there is something new.
Again, thank you so much
El 4 sept. 2017 10:16 p. m., Andrew Kane<EMAIL_ADDRESS>escribió:
Hey @maob85https://github.com/maob85, that's expected for some queries. If it's happening for all queries, there's likely another issue at play.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/ankane/dexter/issues/10#issuecomment-327054086, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeK5Kwzdaib8Bq2NhDIB475yJuaZo_NUks5sfK74gaJpZM4PMShe.


Fixes zoomBy with floats (iOS)

Connection with issue(s)
Resolve issue #873

Testing and Review Notes
Now users should be able to select a zoomBy in double increments:
InAppWebViewController.zoomBy(zoomFactor: 0.64)
To Do

[x] double check the original issue to confirm it is fully satisfied
[x] add testing notes and screenshots in PR description to help guide reviewers

See https://github.com/pichillilorenzo/flutter_inappwebview/issues/873


#1791 Patch swagger.yaml for exposing it via api

This PR adds instructions in the Dockerfile for editing the swagger.yaml.
More precisely, the swagger.yaml is edited so that it uses https and all requests require an x-token.

Codecov Report

Merging #1828 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1828      +/-   ##
==========================================
+ Coverage   32.05%   32.07%   +0.01%
==========================================
  Files          99       99
  Lines        7589     7589
==========================================
+ Hits         2433     2434       +1
+ Misses       4853     4852       -1
  Partials      303      303

Impacted Files
Coverage Δ

distributor/cmd/main.go
58.88% <0.00%> (+1.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6fd25...74a6eeb. Read the comment docs.


rcc: keep the cache bits in FLASH_ACR intact

This allows configuring the cache bits independent of clock freeze.
An alternative would be to switch the caches on in here?

@birkenfeld I think we should add functionality to configure the caches. But we should certainly keep whatever is in the registers already.


A better first touch experience

This issue serves as a place discuss and create tasks related to improving the first touch experience. Recent on-the-ground experiences at Wasm I/O with @tippexs and @danielledeleo have highlighted the need for an improved "first touch" experience for new NGINX Unit users.
Tasks need to be defined and issues created for the following:

[x] Homepage installation one-liner (see rustup, Homebrew, etc.)

#139

[ ] Simplified installation page
[ ] New quickstart section/page

Loosely defined ideas that may require changes to the nginx/unit repo:

[ ] Command line alternatives to writing Unit configurations in JSON (tedious and slow)
[ ] Unit's default behaviour to launch in daemon mode can be surprising to new users
[ ] Make running Unit as an unprivileged user easier (automatic --flag overrides for .pid, .log, and .sock files)

Make running Unit as an unprivileged user easier (automatic --flag overrides for .pid, .log, and .sock files)
We dont have to modify Unit if we suggest using the Docker container by default.
If we can offer a one-size-fits-all docker container with all language runtimes enabled in addition to our current offerings then we can offer a very simple process to get developers started with a docker container that wont require changes to their systemd configuration.

What I was thinking of was more along the lines of what is already being done in our Homebrew compilation flags.
There are still some quality-of-life and friction issues with Docker that I point out in issue #139. Until we address these I'm reluctant to point users to Docker as a way to get started.

You can of course set --control, --pid, --log & --statedir  at runtime.

You can of course set --control, --pid, --log & --statedir at runtime.

A little tedious, but yes.


add identifiers dict to product

The idea is to add an ability to have other identifiers:
Cusip, isdn, internal ids, etc.
This can be a simple dictionary that defaults to None.
Needs to be incorporated into a to_detailed_json (which will be a new function)

Already have this (totally forgot I did)


Customisation sync Select All Shiny selects older version of plugin

Abstract
After updating a plugin, customisation sync's Select All Shiny button selects other devices with an older version of the plugin.
As a workaround, if I then manually update the plugins on all devices, Select All Shiny no longer shows changes for an older device.
Expected behaviour

The device with the latest version of the plugin does not select other devices with an older version of the plugin.

Actually happened

A device with an older version of the plugin is selected.

Reproducing procedure
This does not always happen, and seems to be intermittent. When it does the following seems to trigger it:

Configure LiveSync and customisation sync.
Ensure all devices are up to date with plugins, so that customisation sync says everything is up to date.
When a new plugin update is available, update it on ONE device.
On the updated device, click Refresh, Scan Changes, and then Select All Shiny.
The updated device selects another device for that plugin, showing changes which are outdated.

I also queried the CouchDB database for the plugin files. The ix:macbook files have a more recent mtime than ix:pad, so the database looks correct. For some reason the LiveSync plugin does not seem to be interpreting these correctly.

CouchDB data
{
 "_id": "ix:ipad/plugin_data/obsidian-meta-bind-plugin%data.json",
 "_rev": "1-497277813df4760924ed6ef77eca4b01",
 "children": [
  "h:kep6dkk3eaq"
 ],
 "path": "ix:iPad/PLUGIN_DATA/obsidian-meta-bind-plugin%data.json",
 "ctime":<PHONE_NUMBER>612,
 "mtime":<PHONE_NUMBER>612,
 "size": 693,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:ipad/plugin_main/obsidian-meta-bind-plugin%main.js",
 "_rev": "1-cbab5d8ffb6a31892e987fae396ab51a",
 "children": [
  "h:2n7ygh51ob1px"
 ],
 "path": "ix:iPad/PLUGIN_MAIN/obsidian-meta-bind-plugin%main.js",
 "ctime":<PHONE_NUMBER>696,
 "mtime":<PHONE_NUMBER>696,
 "size": 1525845,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:ipad/plugin_main/obsidian-meta-bind-plugin%manifest.json",
 "_rev": "1-6b9efa4ec710e572d0e0ee3b3fb06f1d",
 "children": [
  "h:dphbr9s95dqb"
 ],
 "path": "ix:iPad/PLUGIN_MAIN/obsidian-meta-bind-plugin%manifest.json",
 "ctime":<PHONE_NUMBER>118,
 "mtime":<PHONE_NUMBER>118,
 "size": 625,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:ipad/plugin_main/obsidian-meta-bind-plugin%styles.css",
 "_rev": "1-cf2cf08a43b32ffec7b2f57574e0828a",
 "children": [
  "h:2muc8eqjg3x12"
 ],
 "path": "ix:iPad/PLUGIN_MAIN/obsidian-meta-bind-plugin%styles.css",
 "ctime":<PHONE_NUMBER>282,
 "mtime":<PHONE_NUMBER>282,
 "size": 17817,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:iphone/plugin_data/obsidian-meta-bind-plugin%data.json",
 "_rev": "1-7ead755ba59d0c1b775ff08962ad5651",
 "children": [
  "h:kep6dkk3eaq"
 ],
 "path": "ix:iPhone/PLUGIN_DATA/obsidian-meta-bind-plugin%data.json",
 "ctime":<PHONE_NUMBER>525,
 "mtime":<PHONE_NUMBER>525,
 "size": 693,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:iphone/plugin_main/obsidian-meta-bind-plugin%main.js",
 "_rev": "1-feca3c44359ad7438f0dacc12a7f0b86",
 "children": [
  "h:2n7ygh51ob1px"
 ],
 "path": "ix:iPhone/PLUGIN_MAIN/obsidian-meta-bind-plugin%main.js",
 "ctime":<PHONE_NUMBER>191,
 "mtime":<PHONE_NUMBER>191,
 "size": 1525845,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:iphone/plugin_main/obsidian-meta-bind-plugin%manifest.json",
 "_rev": "1-3b5dfee5d513aa5e31e76e1bafb8fd84",
 "children": [
  "h:dphbr9s95dqb"
 ],
 "path": "ix:iPhone/PLUGIN_MAIN/obsidian-meta-bind-plugin%manifest.json",
 "ctime":<PHONE_NUMBER>490,
 "mtime":<PHONE_NUMBER>490,
 "size": 625,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:iphone/plugin_main/obsidian-meta-bind-plugin%styles.css",
 "_rev": "1-47b333f3a9aa1294fb8103340e638508",
 "children": [
  "h:2muc8eqjg3x12"
 ],
 "path": "ix:iPhone/PLUGIN_MAIN/obsidian-meta-bind-plugin%styles.css",
 "ctime":<PHONE_NUMBER>515,
 "mtime":<PHONE_NUMBER>515,
 "size": 17817,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:macbook/plugin_data/obsidian-meta-bind-plugin%data.json",
 "_rev": "1-485a990641e00223a8e83739e4d39119",
 "children": [
  "h:kep6dkk3eaq"
 ],
 "path": "ix:macbook/PLUGIN_DATA/obsidian-meta-bind-plugin%data.json",
 "ctime":<PHONE_NUMBER>795,
 "mtime":<PHONE_NUMBER>795,
 "size": 693,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:macbook/plugin_main/obsidian-meta-bind-plugin%main.js",
 "_rev": "2-a503e0ab888f4a96a23eb5f23fcb0337",
 "children": [
  "h:1535gjg0glpm8"
 ],
 "path": "ix:macbook/PLUGIN_MAIN/obsidian-meta-bind-plugin%main.js",
 "ctime":<PHONE_NUMBER>794,
 "mtime":<PHONE_NUMBER>859,
 "size": 1454053,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:macbook/plugin_main/obsidian-meta-bind-plugin%manifest.json",
 "_rev": "2-219d70ab853e455395163964dfe623a6",
 "children": [
  "h:34m82aqn8wc4b"
 ],
 "path": "ix:macbook/PLUGIN_MAIN/obsidian-meta-bind-plugin%manifest.json",
 "ctime":<PHONE_NUMBER>002,
 "mtime":<PHONE_NUMBER>861,
 "size": 585,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:macbook/plugin_main/obsidian-meta-bind-plugin%styles.css",
 "_rev": "2-18fcf438cb6b4517a3de7d7228946018",
 "children": [
  "h:s8d2ukuwuz4o"
 ],
 "path": "ix:macbook/PLUGIN_MAIN/obsidian-meta-bind-plugin%styles.css",
 "ctime":<PHONE_NUMBER>392,
 "mtime":<PHONE_NUMBER>862,
 "size": 21989,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:windows/plugin_data/obsidian-meta-bind-plugin%data.json",
 "_rev": "1-3034b1d6a61f27ac45c83fc3a7737973",
 "children": [
  "h:kep6dkk3eaq"
 ],
 "path": "ix:windows/PLUGIN_DATA/obsidian-meta-bind-plugin%data.json",
 "ctime":<PHONE_NUMBER>294,
 "mtime":<PHONE_NUMBER>294,
 "size": 693,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:windows/plugin_main/obsidian-meta-bind-plugin%main.js",
 "_rev": "1-d65919630f95a7ddfff741f15514bec8",
 "children": [
  "h:2n7ygh51ob1px"
 ],
 "path": "ix:windows/PLUGIN_MAIN/obsidian-meta-bind-plugin%main.js",
 "ctime":<PHONE_NUMBER>436,
 "mtime":<PHONE_NUMBER>436,
 "size": 1525845,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:windows/plugin_main/obsidian-meta-bind-plugin%manifest.json",
 "_rev": "1-fbf8884bba582f4f553424a17a897528",
 "children": [
  "h:dphbr9s95dqb"
 ],
 "path": "ix:windows/PLUGIN_MAIN/obsidian-meta-bind-plugin%manifest.json",
 "ctime":<PHONE_NUMBER>000,
 "mtime":<PHONE_NUMBER>000,
 "size": 625,
 "type": "plain",
 "eden": {}
}

{
 "_id": "ix:windows/plugin_main/obsidian-meta-bind-plugin%styles.css",
 "_rev": "1-b69bedc9f43f9f804c04d0f0ecc5d6f6",
 "children": [
  "h:2muc8eqjg3x12"
 ],
 "path": "ix:windows/PLUGIN_MAIN/obsidian-meta-bind-plugin%styles.css",
 "ctime":<PHONE_NUMBER>868,
 "mtime":<PHONE_NUMBER>868,
 "size": 17817,
 "type": "plain",
 "eden": {}
}

I've had this issue too. And can I tag on how much a option to change all the drop downs at once to a certain device would be? So many times I find myself going through to select my 'master' device.

I just updated to LiveSync 24.1, and am still seeing this issue.
Here is an example where my Windows installation has updated the Importer plugin, but Customisation Sync is offering the older Macbook version when I click Select All Shiny:

I did notice that the styles.css file seems to be newer on the Macbook (though the contents have not changed)... not sure if this is part of the issue.

This just happened again – my MacBook updated the QuickAdd plugin, and it is now selecting iPad when I click Select All Shiny. This time, my MacBook has more recent versions of all the plug-in files, so I don't know why iPad is being selected here.


[vm] Create an entry point for initializing LibraVM on chain configur…

…ations

Motivation
Provide a public api for initializing all the on chain configs required by the LibraVM. We will use this API to setup the initialization phase of LibraVM in VMValidator and Executor in the future.
Have you read the Contributing Guidelines on pull requests?
Yes

@bors-libra r=sunshowers

:pushpin: Commit b9da25d has been approved by sunshowers

:hourglass: Testing commit b9da25d89ef6f6f0127ecaceb97505faaba90aad with merge 013ab489aaaa8ebf36d6b4b8c33f7f507b26ba5f...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: sunshowers
Pushing 013ab489aaaa8ebf36d6b4b8c33f7f507b26ba5f to master...


[Bug Report][Android] library "libavcodec.so" not found

Hello again,
I am trying to use the ffmpeg_kit_flutter_min_gpl package alongside media_kit on Android. It is working without issues on a physical Android 13 and on an emulated Android 7.1.1. But when running it on a physical Android 7.1.2 (a box called Pendoo X8 mini), I get this error :
I/flutter (13617): Invalid argument(s): Failed to load dynamic library 'libavcodec.so': dlopen failed: library "libavcodec.so" not found
I/flutter (13617): #0      _open (dart:ffi-patch/ffi_dynamic_library_patch.dart:11:43)
I/flutter (13617): #1      new DynamicLibrary.open (dart:ffi-patch/ffi_dynamic_library_patch.dart:22:12)
I/flutter (13617): #2      AndroidHelper.ensureInitialized (package:media_kit/src/utils/android_helper.dart:23:43)
I/flutter (13617): #3      libmpvEnsureInitialized (package:media_kit/src/player/libmpv/player/real.dart:40:17)
I/flutter (13617): #4      MediaKit.ensureInitialized (package:media_kit/src/media_kit.dart:39:7)
I/flutter (13617): #5      main (package:vctv_flutter/main.dart:12:12)
I/flutter (13617): #6      _runMain.<anonymous closure> (dart:ui/hooks.dart:131:23)
I/flutter (13617): #7      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:296:19)
I/flutter (13617): #8      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:189:12)
E/flutter (13617): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Exception: Cannot find libmpv.so. Please ensure it's presence in the APK.
E/flutter (13617): #0      NativeLibrary.ensureInitialized (package:media_kit/src/player/libmpv/core/native_library.dart:63:9)
E/flutter (13617): #1      libmpvEnsureInitialized (package:media_kit/src/player/libmpv/player/real.dart:41:17)
E/flutter (13617): #2      MediaKit.ensureInitialized (package:media_kit/src/media_kit.dart:39:7)
E/flutter (13617): #3      main (package:vctv_flutter/main.dart:12:12)
E/flutter (13617): #4      _runMain.<anonymous closure> (dart:ui/hooks.dart:131:23)
E/flutter (13617): #5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:296:19)
E/flutter (13617): #6      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:189:12)

I'm aware of #241, here's my dependencies :
  media_kit: ^1.0.2
  media_kit_video: ^1.0.2
  media_kit_native_event_loop: ^1.0.6
  media_kit_libs_android_video: ^1.1.1
  ffmpeg_kit_flutter_min_gpl: ^5.1.0

As described in #159, I tried adding the packagingOptions part to the build.gradle but it didn't solve the issue.
Any clue on how to solve this ? Thank you.

I just tried with the following deps, still the same error :
  media_kit: ^1.0.2
  media_kit_video: ^1.0.2
  media_kit_native_event_loop: ^1.0.6
  media_kit_libs_android_video: ^1.1.1
  media_kit_libs_ios_video: ^1.0.4
  media_kit_libs_macos_video: ^1.0.5
  media_kit_libs_windows_video: ^1.0.2
  media_kit_libs_linux: ^1.0.2
  ffmpeg_kit_flutter_full_gpl: ^5.1.0

Marking "in triage" for further investigation. We'll need further details.

Hi!
I just noticed your edit. I apologies for the delays; we're working really hard on Android side of things.
I just wanted to ask does ffmpeg_kit_flutter_min_gpl itself work on that machine (after removing media_kit)?
In our Android build steps, we ignore our version of FFmpeg if existing FFmpeg is located.

It does work, yes.

And media_kit also works independently?

Yes. One other difference is that the box has root access.

I repeat the question again for confirmation, does media_kit itself work on this device without FFmpeg?

A number of improvements have been made in regards to performance, stability & size. I'd like to fix this issue before our next stable release.
You may get closely in touch to provide necessary feedback at our Discord:
https://discord.gg/z75Z9NNWJk

For the record, the issue comes from the armeabi-v7a architecture for the ffmpeg_kit packages. The files for it in the apk have a "_neon" suffix that makes media_kit not able to find and use them, if I understood correctly.

A temporary fix is to use a local copy of the media_kit_libs_android_video package and edit this line:
in android/build.gradle :
- destNoFFmpegARMEABI
+ destDefaultARMEABI

I'm fixing the issue completely. Statically linking libav* with libmpv, expect update tomorrow.

The issue is resolved in the latest update.
Please refer to the "Installation" section.

running on an android TV Emulator with the arm64 arch I got the error bellow
Exception: Cannot find libmpv.so. Please ensure it's presence in the APK.
the weird this is I also get this error
media_kit: ERROR: MediaKit.ensureInitialized I/flutter ( 9680): This indicates that one or more required dependencies could not be located. I/flutter ( 9680):  I/flutter ( 9680): Refer to "Installation" section of the README for further details
while I am sure I installed the packages as stated
media_kit: ^1.1.10
media_kit_video: ^1.2.4
media_kit_libs_video: ^1.0.4

running on an android TV Emulator with the arm64 arch I got the error bellow Exception: Cannot find libmpv.so. Please ensure it's presence in the APK.
the weird this is I also get this error media_kit: ERROR: MediaKit.ensureInitialized I/flutter ( 9680): This indicates that one or more required dependencies could not be located. I/flutter ( 9680): I/flutter ( 9680): Refer to "Installation" section of the README for further details
while I am sure I installed the packages as stated
media_kit: ^1.1.10 media_kit_video: ^1.2.4 media_kit_libs_video: ^1.0.4

did you close the app and recompile it? most probably thats the issue

running on an android TV Emulator with the arm64 arch I got the error bellow Exception: Cannot find libmpv.so. Please ensure it's presence in the APK.
the weird this is I also get this error media_kit: ERROR: MediaKit.ensureInitialized I/flutter ( 9680): This indicates that one or more required dependencies could not be located. I/flutter ( 9680): I/flutter ( 9680): Refer to "Installation" section of the README for further details
while I am sure I installed the packages as stated
media_kit: ^1.1.10 media_kit_video: ^1.2.4 media_kit_libs_video: ^1.0.4

did you close the app and recompile it? most probably thats the issue

I did, I even installed the app and tried again.

running on an android TV Emulator with the arm64 arch I got the error bellow Exception: Cannot find libmpv.so. Please ensure it's presence in the APK.
the weird this is I also get this error media_kit: ERROR: MediaKit.ensureInitialized I/flutter ( 9680): This indicates that one or more required dependencies could not be located. I/flutter ( 9680): I/flutter ( 9680): Refer to "Installation" section of the README for further details
while I am sure I installed the packages as stated
media_kit: ^1.1.10 media_kit_video: ^1.2.4 media_kit_libs_video: ^1.0.4

did you close the app and recompile it? most probably thats the issue

I did, I even installed the app and tried again.

Can you open a new issue explaining how to reproduce the same issue?

Sure thing
On Tue 13. Feb 2024 at 7:21 PM, Abdelaziz Mahdy @.***>
wrote:

running on an android TV Emulator with the arm64 arch I got the error
bellow Exception: Cannot find libmpv.so. Please ensure it's presence in
the APK.
the weird this is I also get this error media_kit: ERROR:
MediaKit.ensureInitialized I/flutter ( 9680): This indicates that one or
more required dependencies could not be located. I/flutter ( 9680):
I/flutter ( 9680): Refer to "Installation" section of the README for
further details
while I am sure I installed the packages as stated
media_kit: ^1.1.10 media_kit_video: ^1.2.4 media_kit_libs_video: ^1.0.4
did you close the app and recompile it? most probably thats the issue
I did, I even installed the app and tried again.
Can you open a new issue explaining how to reproduce the same issue?
—
Reply to this email directly, view it on GitHub
https://github.com/media-kit/media-kit/issues/283#issuecomment-1942141485,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJV4WVS5T6K4HO7VVPNFARDYTOVKJAVCNFSM6AAAAAA2IUSR22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBSGE2DCNBYGU
.
You are receiving this because you commented.Message ID:
@.***>


enable SIMD when comparing to simd-json benchmarks

Hi,
first of all, this is a really impressive creation I love the trick of delaying number parsing darn smart :D.
That said I would suggest enabling SIMD when comparing against simd-json, otherwise, it's a bit of a pointless comparison. The best way to do that in a non too CPU-dependent way is to use RUSTFLAGS="-C target-feature=+avx,+avx2,+sse4.2" those features are present on all modern CPUs.

Thanks!
There is a bench using it on the README:
string json_deserializer 2^18 time:   [10.106 ms 10.138 ms 10.173 ms]
string serde_json 2^18        time:   [23.177 ms 23.209 ms 23.243 ms]
string simd_json 2^18         time:   [10.924 ms 10.941 ms 10.959 ms]

# with `RUSTFLAGS='-C target-cpu=native'` (skilake in this case)
string simd_json 2^18         time:   [8.0735 ms 8.0887 ms 8.1046 ms]

basically, simd_json is faster for strings (best case for this crate) by ~20%.
The background of this crate is https://github.com/jorgecarleitao/arrow2/pull/1024 - the delay of number parsing came as a requirement from arrow2 since it allows the user to decide to which integer/float to parse them into.
I like that this crate is forbid unsafe, but despite using it bringing a 50% improvement over serde_json, 20% is still 20%, so it is a tradeoff that I am thinking about.

wow, I am humbled by this - that would be awesome!
Note that this still does not support surrogates encoded strings. Need to spend some time to do that (and find a json with them).
Sorry, not very familiar with the ecosystem - could you clarify which "value trait" you mean?

Oh sorry,
the value-trait is basically this repo. The idea is to allow users to have a trait that can represent different implementations for JSONesque values so libraries can be implemented w/o targeting a specific implementation.
It basically offers all the functions needed to access, manipulate and traverse the datastructures.

Got it. Thanks! How do you recommend? feature-flag value-trait on this trait and expose the implementation?


Not responsive in loop mode

There is a display bug after rotating when useing loop mode

This tells about nothing, it is responsive. Will be good to see live example or at least JS Fiddle with issue

Closing as no further response/discussion


Increase compatibility with our dependencies

Current coverage is 100% (diff: 100%)

No coverage report found for master at 90d5055.

Powered by Codecov. Last update 90d5055...fc786f7

:+1:


Proto-build fails for SDK 0.46

The cosmos-sdk repo since v0.46.0 no longer includes a third_party/proto folder. Instead, it uses a buf.yml config file to define dependencies. However, proto-build does not support this; executing cargo run now results in the following error:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: "protoc failed: gogoproto/gogo.proto: File not found.\ngoogle/protobuf/any.proto:35:1: Import \"gogoproto/gogo.proto\" was not found or had errors.\ngoogle/api/annotations.proto: File not found.\ncosmos_proto/cosmos.proto: File not found.\ncosmos/auth/v1beta1/auth.proto:4:1: Import \"cosmos_proto/cosmos.proto\" was not found or had errors.\ncosmos/auth/v1beta1/auth.proto:5:1: Import \"gogoproto/gogo.proto\" was not found or had errors.\ncosmos/auth/v1beta1/auth.proto:6:1: Import \"google/protobuf/any.proto\" was not found or had errors.\ncosmos/auth/v1beta1/auth.proto:21:3: \"google.protobuf.Any\" is not defined.\ncosmos/auth/v1beta1/query.proto:5:1: Import \"gogoproto/gogo.proto\" was not found or had errors.\ncosmos/auth/v1beta1/query.proto:6:1: Import \"google/protobuf/any.proto\" was not found or had errors.\ncosmos/auth/v1beta1/query.proto:7:1: Import \"google/api/annotations.proto\" was not found or had errors.\ncosmos/auth/v1beta1/query.proto:8:1: Import \"cosmos/auth/v1beta1/auth.proto\" was not found or had errors.\ncosmos/auth/v1beta1/query.proto:9:1: Import \"cosmos_proto/cosmos.proto\" was not found or had errors.\ncosmos/auth/v1beta1/query.proto:86:12: \"google.protobuf.Any\" is not defined.\ncosmos/auth/v1beta1/query.proto:104:3: \"google.protobuf.Any\" is not defined.\ncosmos/auth/v1beta1/query.proto:113:3: \"Params\" is not defined.\ncosmos/auth/v1beta1/query.proto:125:12: \"google.protobuf.Any\" is not defined.\ncosmos/auth/v1beta1/query.proto:135:3: \"google.protobuf.Any\" is not defined.\n" }', proto-build/src/main.rs:254:10

Apparently, it cannot locate the gogoproto dependency.
I do not know a good solution to this. Any suggestion?

proto-build needs to be updated accordingly

Is there any estimation when support for version 0.46 can be expected?

I had the same issue when trying to generate types for wasmd >= 0.29.0. It seems that both cosmos-sdk and wasmd have a proto-gen script in their Makefile that runs a bash script in a docker container. @tony-iqlusion Would it be reasonable to have proto-build run this script and would it be acceptable for users to need to have docker installed? If you think this is a good approach I can try to make a PR with these changes.

So I got it to work for wasmd >= 0.29.0 by generating the protos via buf with the help of this repo: https://github.com/neoeinstein/protoc-gen-prost
My changes can be found here: https://github.com/apollodao/cosmos-rust/tree/dev/generate-via-buf
I will open a PR for this.
Unfourtunately it seems there are manual changes needed to cosmrs to support cosmos-sdk 0.46. Since I don't need it and am not familiar with the codebase I will leave these changes to someone else. I did however test generating the protos for cosmos-sdk 0.46.10 via buf and it works. I also included a buf yaml config file in my fork for those who want to make the changes needed to cosmrs.

I just got back from vacation. Will take a look at this (and cutting another release) next week

Looking at @apollo-sturdy's branch it seems like protoc-gen-prost is probably the best way forward to me if upstream Cosmos SDK has switched to using buf.
I can try to put together a PR for that unless someone else is particularly interested.
I can also merge #289 to unblock people until we have fully working automation again, at least if the test failures were fixed.

I think what might make sense is to cut another release to get tendermint-rs upgraded, then circle back on this issue for the next release.
That will let us focus on coordinating on ADR 012: Multi-Version Support as part of the upgrade.

If that's of any help, I had a PR on Hermes/ibc-rs where I converted the proto builder used in that project to pull the dependencies as listed in buf.lock using one of the auxiliary buf commands.

Those are both fairly large PRs. @mzabaluev can you point to some specific changes you think would be useful?
FWIW #332 contains some initial steps but still needs a rebase cc @apollo-sturdy

@mzabaluev it looks like you didn't use protoc-gen-prost. Is that right?

@mzabaluev it looks like you didn't use protoc-gen-prost, but instead just shell out to buf directly. Is that right?

Yes, I used one of the auxiliary buf commands to fetch the dependencies at the commits listed in buf.lock.
The proper thing do to would be to switch to buf also for code generation using the prost plugin.

I opened #392 which switches to using buf + protoc-gen-prost + protoc-gen-tonic.
It seems to work but I could definitely use help validating the changes and ensuring there's not anything missing.

Oops, I realized #392 didn't actually update to SDK v0.46.
Upon attempting to do that, I get the following error from buf:

[info] Compiling proto definitions and clients for GRPC services!
../cosmos-sdk-go/third_party/proto/google/protobuf/any.proto:35:8:gogoproto/gogo.proto: does not exist

I see the following in cosmos-sdk's proto/buf.yaml:
deps:
  - buf.build/cosmos/cosmos-proto
  - buf.build/cosmos/gogo-proto
  - buf.build/googleapis/googleapis

...so I'm not sure why it isn't being pulled in?

I split migrating to buf out into its own PR which doesn't attempt to upgrade the SDK version: #393
That should make it easier for others to experiment with the upgrade, namely figuring out the buf.gen.yaml and/or buf CLI arguments needed to get the prerequisite packages to work.
I'm curious if, ala #289, we might just need to vendor the relevant gogoproto protos.

Okay, think I finally got it: https://github.com/cosmos/cosmos-rust/pull/395
I was passing cosmos-sdk-go instead of cosmos-sdk-go/proto as the input path for buf generate. When using the latter, everything works as expected.

Closing this as completed by #395.
If anyone would like to do some advance testing, I'm cutting cosmos-sdk-proto v0.19.0-pre.0 which includes Cosmos SDK v0.46-compatible protos.

With tendermint-rs v0.32 about to ship, this is the last call on any feedback on the newly generated protos before the next release.


python tests are failing

Python 2.7:
Warning: The support for python 2.7 will be removed on June 19. Related issue: https://github.com/actions/setup-python/issues/672
Version 2.7 was not found in the local cache
Error: Version 2.7 with arch x64 not found
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

Python 3.6:
Version 3.6 was not found in the local cache
Error: Version 3.6 with arch x64 not found
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

Python 3.7:
ModuleNotFoundError: No module named 'openlocationcode'

Diffing etc should be working but we have some formatting fails so let's fix those.

Python tests are passing in the CI! 🐢


Allow characters other than numbers, text for example

Is your feature request related to a problem? Please describe.
Yes, I want to display IP addresses but they are formated as text (not number) and the Boom Table doesn't support it even though they are in a time series format.
Describe the solution you'd like
I would like the Boom Table to be able to accept values other than numbers.
Describe alternatives you've considered
I've tried to get the text but to no avail
Additional context
With numbers, the table works nice.

any return?

not to my knowledge.

As far as I can think, this feature won't be available anytime soon unless someone opens PR.

ok, got it.


-i <IP_ADDRESS> not working since 3.5?

Using 3.4.1 (docker run -p 3333:3333 felixlohmeier/openrefine:3.4.1), curl localhost:333 works.
Using 3.5.0, curl localhost:333 hangs. Is it because of -i <IP_ADDRESS> not being properly handled in 3.5.1??

We did introduce some host validation logic, as you can see here:
https://github.com/OpenRefine/OpenRefine/pull/3212
Perhaps the documentation could be improved, though.

This bit me. I found the issue linked to be poor documentation. I had to trial-and-error various combinations of settings to get the behavior I wanted (exposure on <IP_ADDRESS> for a server-hosted instance). I could not get my desired behavior to happen using refine.ini, only using the -i flag, which is inconvenient. Documentation would be appropriate, and if this change reduces the capability of refine.ini it would be as well to document that too.

@ajs6f thank you for the feedback! If you feel like giving concrete suggestions of how the documentation should be improved, that might help any prospective contributor to have a go at it.

Give two use cases: single operator (localhost only), server-based install exposed on a single interface. Show example refine.ini configuration for both. If that is impossible because refine.ini can no longer be used for one case or the other, explain that and give sample CLI invocations for both cases.

Thanks! Marking this as a good first documentation: this should be a documentation-only pull request, no code change should be required.

Hello @wetneb I am outreachy applicant, can you please assign this task to me? I would like to try. Thank you

@wetneb @marcadella I need your help, can you please guide to initial request, I got a bit lost and can't understand from where I should start. thanks

This issue is about improving the documentation, so you should be able to simply click on the edit button of the corresponding manual page and propose your changes to the documentation.

Hello @wetneb  am an outreachy participant, kindly assigne me to this issue.

Hello @wetneb  am an outreachy participant, kindly assigne me to this issue.

Hi @sherrif10. This issue has already been assigned to someone (and 10 days ago, so not long). Please choose another issue, or ask the current assigned person if he stopped working on the issue (which is probably the case since he's like you an Outreachy applicant.
Regards, Antoine

@wetneb please assign task to @sherrif10

Thanks @wetneb

Hello @wetneb , @marcadella , could you point to me the areas that are not documented well. with main/docs . every documentation seems to be on point. is this somewhere you would love to see improvements.

I have gone through the PR#3212 so I just need to mention why its not working in using 3.5.0 while it works for others and also note the behaviors of refine.host and refine.interface from PR#3212 for which it works and also write the changes that @ajs6f mentioned. Right?
Can you please assign me this issue and tell me exactly where in the documentation I have to mention these?
@wetneb


[Release] sdk/resourcemanager/hybridcompute/armhybridcompute/0.1.0

…neration from spec commit: b8cae07c799a07f2e779a9e301f639e9b85124b1

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

/azp run prepare-pipelines

/azp run go - armhybridcompute - ci

/check-enforcer override


Command Line server

Adds a command line server as well as greatly increase the number of tests

Can I use the changes of this PR to reproduce https://github.com/LiberTEM/LiberTEM/issues/1675 ?

Can I use the changes of this PR to reproduce LiberTEM/LiberTEM#1675 ?

@sk1p You need to have a working version of the DEServer Simulator to replicate the error there. I can look into the mrc file loader and see what seems to cause the issue.
https://github.com/directelectron/deapi/pull/10/files#diff-70ac2120a2709a27a117d2090ceb3185ab9feacfe8457d3018820e3733536fcc
I can create a file which fails if that helps.  I guess I could "Fake" the writing of a .mrc file.  That might be useful for some people who read from the disk rather than trying to get all of the frames over a socket.

pre-commit.ci autofix


Please bring back ability to turn off content pane spinner

I realize what the intent was here -- to have the spinner disappear when virtualmin/webmin creates screen output.  But it seems not to really work in a lot of different places -notably if you do updates to modules, the spinner takes over and you see absolutely nothing.  Could we get the ability to just turn the thing off back - it's really getting in the way of a lot of work here.
Also --- Just a comment - the number of updates you're producing is maddening when you have a whole lot of servers to maintain

I'm planning to slow down update rates. I was asked about this and I remember.
I don't think it would worth it to bring it back. In 90% of the modules/cases, it just makes things feel and look faster.
You're having to show the top progress and the spinner on the top right (they both replace the old, big spinner).
In case you turned it off, you need to manually edit settings.js file or rest theme's settings to default.
I have a thought, that you disabled that top progress bar and now don't see the top and small right progress/spinner?

it seems not to really work in a lot of different places

Could you tell me, where exactly this happens?

Well -- for me just about everywhere the server is putting out information.  For example, as I said, doing RPM updates on the server - the right hand screen is always blank so I have NO idea what is going on - I just get the spinner at the top.
We're just about ready to go back to the old theme since the new one changes every day and keeps breaking our ability to do work.

At first, when you do updates and/or server outputs data - you must see what is happening and the veil must go away, while the screen is scrolled down. It's not? Please name the modules where it's not happening, I will double check.
I made sure, that the user sees server output in all modules, including VM/CM. I can easily provide you with video screencast of how it works. I would like to ask you to do the same, it would make things easier to comprehend.

..since the new one changes every day and keeps breaking our ability to do work.

Theme doesn't change but improves, everyday and all the time. It definitely doesn't break anything. I'm willing to improve whenever I want, and in the end, it's the only reason, why we all have Authentic today.
In case you don't like to see updates or perform updates, just go ahead and turn off notifications for theme updates - your theme will be updated automatically with Webmin (about every 2-3 months).
Why this is an issue at all?

Like I keep saying -- it is not working on our servers.  Every time we do updates, ALLL we ever see is the spinner at the top of the screen.  The whole content pane remains grey until the RPM updates complete -- I see this more or less EVERYWHERE that the server produces updates.  On multiple machines.  All running the latest update.   You can say it runs on your system all you want, but it does not work, for us, and it's really maddening that you're unwilling to accept this as a bug report.

I'm very willing to accept it. Did it work before?

What browser are you using?

I have just made the update and the content of the page was seen.

Could you please point out where exactly EVERYWHERE else it doesn't work?

This is how it goes on my two different server in two different browsers!
Please have a look:
Video Screencast

For what it's worth, that's what happens for me in Chrome on OS X.
michael at barrow dot me
+1.541.600.2027
"Do not anticipate trouble, or
worry about what may never happen.
Keep in the sunlight." -- B. Franklin
On Wed, Feb 17, 2016 at 12:41 PM, Ilia Rostovtsev<EMAIL_ADDRESS>wrote:

This is how it goes on my two different server in two different browsers!
Please have a look:
Video Screencast
http://rostovtsev.ru/pub/src/authentic/17.71/dismissed_page_loader_upon_server_deta_is_pushed.webm
—
Reply to this email directly or view it on GitHub
https://github.com/qooob/authentic-theme/issues/396#issuecomment-185394764
.

Not how it works for us at all --- as I said, All I ever see is the spinner until the task completes.
Running on a Fedora Linux desktop, using either Firefox or Chrome I see the same behavior.

Did it work before?
I will check it on my MacBook.

I checked it exactly on Chrome and Firefox. What is the server OS that it doesn't work with?

Okay so I can confirm - works in Windows, doesn't work in Fedora Linux on the desktop.

Server OS is CentOS 6 or 7 - the problem seems to be that it just doesn't work on a Linux desktop - which I'm perfectly willing to accept if we could turn the spinner off -- everything worked fine in Linux with the spinner off.

I'm glad to hear it works in Windows. I don't use it, so for me it's one OS less to test in. ;)
I made those tests in Linux.
Do you use Server Index module to run package updates or the regular way?
Could you please provide video-screencast of how it works on your side with opened console. In case it's private just send me the link using my website.

accept if we could turn the spinner off -- everything worked fine in Linux with the spinner off.

So you just want the ability to turn it off?? Or the spinner itself?

How about this?
body .container-fluid {
    pointer-events: auto !important;

    opacity: 1 !important;
}

Add this to your CSS extensions in theme's settings.
Is that what you wanted really?

I know what I'm going to do - provide overall support for all different kind of modules, that don't follow the rules and don't use the footer.
Instead of running that code for all modules (99% of all in-bult modules follow that rule and thus work properly) I will provide a user to specify the list of modules for exclusion.
It means you and anyone using unstandard modules, will be able to add it in exclusion list in theme's settings and be totally happy.
Now I feel grateful, as more than one hour of our time wasn't wasted in vain and will provide complete solution for all in the future!!
Thanks for reporting!
P.S. Are you psychologically ready for another update? :question:  Version 17.72 is coming soon.

Thanks --- that seems helpful.  The CSS change you provided does what I'd like.
By the way -- the same bad behavior happens if you try to work on the site from the Kindle Fire Silk browser.  Just happens I tried that last night and had the same issue.

Very strange. I have tested all of this on CentOS 6/7, Fedora 23, Debian 8, and Ubuntu 13 (server) and (client) on Chrome (Chromium, Opera), Firefox, IE in Linux, Windows and Safari in iOS - all was working.
But it will not matter, since 17.72 will have the ability to disable such functionality selectively by module's name or for all modules across Webmin by passing * as the value. You will see it at the bottom of Window options. The defaults are already set to sysstats drweb-maild.
From now on, I will not get any messages about not working modules.

Please upgrade to 17.72.


Update Makefile to include AMPLITUDE_KEY

Preview is available here:http://laboratory-pr462.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-pr462.previews.kube001.services.stellar-ops.com/


Add annotations on secrets files

This is my commit message
Signed-off-by: Lord-Y<EMAIL_ADDRESS>What does your PR do?
Add annotations on secrets for those working with vault-secrets-webhooks from Banzaï Cloud.
Checklist

[x] Commits are signed
[ ] Commits are squashed (if appropriate)
[x] Chart version bumped
[x] Chart documentation updated
[x] Passes linting

@Lord-Y what exactly is the requirement to set annotations on secrets?

@thesuperzapper Here is an example https://github.com/Lord-Y/bank-vaults-docs/blob/master/docs/mutating-webhook/_index.md#getting-secret-data-from-vault-and-replace-it-in-kubernetes-secret-andor-configmap.
If you interested on how the webhook work: https://banzaicloud.com/docs/bank-vaults/overview/

@thesuperzapper Any news about this PR?


SEO: Top 5 in Google Search

I want to ensure that Operation Code appears in the top five search items when google searching "Operation Code", so that people looking for our organization can find us.

IIRC there's a rails gem for SEO. Not sure if it's any good or not.

@rickr can this issue be closed? "Operation Code" still yields us as number one on Google and Bing.

Yea. Lets go ahead and close this. If we want to take action on @rkerneggers additional terms please file additional tickets.


WIP:  Interpolator class to cache interpolation matrix

Addressing #4651
This should be the bare bones of the refactoring.
@larsoner is this enough to make it savable?
And what additional information should we store? The list of bad channels might be good, to make sure it's the same as inst before applying?

Codecov Report

Merging #4658 into master will decrease coverage by 0.02%.
The diff coverage is 72.5%.

@@            Coverage Diff             @@
##           master    #4658      +/-   ##
==========================================
- Coverage   87.67%   87.65%   -0.03%
==========================================
  Files         351      351
  Lines       66609    66653      +44
  Branches    11548    11558      +10
==========================================
+ Hits        58401    58422      +21
- Misses       5253     5274      +21
- Partials     2955     2957       +2

practically speaking, how much speed gain do you observe for EEG and for MEG by caching these matrices?

computing one interpolation matrix takes in the order of seconds for me

also for EEG?

I haven't looked at EEG, only MEG.

And what additional information should we store? The list of bad channels might be good, to make sure it's the same as inst before applying?

I think the things we'd need to check would be:

The set (and order) of good and bad channel names should need to match exactly for it to operate.
The sensor coordinates in the head coordinate frame must match to numerical precision.
The origin (for MEG, maybe also EEG?) of the approximation must match to numerical precision.

I think this is enough to guarantee that the same interpolator can be used.

okay. IMO, it makes sense only to cache self_dots and self_dots as EEG interpolation is rather fast

@jasmainak If we already go through the trouble of managing a cached object, is there an advantage to not caching the rest? I'm also thinking of epoch-wise interpolation, where you might want to apply an interpolator hundreds of times, so it might be preferable to store the highest level possible.

@christianbrodbeck from what I understood, you only store the mapping_matrix but not self_dots and cross_dots in the Interpolator object. The problem with this approach is that it won't help in epoch-wise interpolation if different epochs have different bad channels ... (if you all epochs have the same bad channel, you might as well do the interpolation on the raw object once before epoching)
My first thought had been to compute an n_channels x n_channels mapping matrix and slice it, but it cannot be sliced to give you a mapping matrix of n_channels x n_bads. The math doesn't work out. You can only slice the self_dots and cross_dots and then you have to assemble the mapping_matrix again, but that already saves you significant computation

You can only slice the self_dots and cross_dots and then you have to assemble the mapping_matrix again, but that already saves you significant computation

If this is indeed the bottleneck, then for you would only ever need one of these for each MEG system, since the electrodes do not move. That would be nice. However, for EEG I doubt it's this simple since it uses some other interpolation mode.
@christianbrodbeck this one is pretty old, perhaps we should close and reconsider the best way to cache the interpolation next time someone hits a need for it?

I'll close since it seems unlikely that this will be implemented soon, and rebases are needed anyway


Prepare for release v1.10.1

The module version in the readme under the deploy section should be bumped also. Maybe we can automate it together with the rest?

updated! ignore the failure now. It is failing since the new tag is not yet pushed!