Use logsToSend instead of currentLogs when sending

Fixing https://github.com/SumoLogic/js-logging-sdk/issues/16
Also, per NPM docs, package-lock.json should not be checked in.

@billsaysthis is it possible to publish this change to NPM please?

v1.0.5 is out.


Disable response login required for views and bump version

For the productionising of Response, Setting RESPONSE_LOGIN_REQUIRED to false, as we want everyone to be able to see incidents. Also set the Django setting to IsAuthenticatedOrReadOnly too.
While here, bumped the version of Response too.

Have we validated bumping the version does not break anything existing we've built on?

Yes - we're able to declare an incident, create a comms channel, view the incident response doc and close the incident.


Don't infer empty availability attributes

Due to the mapping of iOS platform availability to tvOS platform availability, we were ending up inferring an availability attribute @available(tvOS) for an associated type, which does not parse properly. Suppress the creation of inferred availability attributes when they convey no information (e.g., because they have no introduced/deprecated/obsoleted/etc. in them).
Fixes rdar://123545422.

@swift-ci please smoke test

@swift-ci please smoke test macOS


[FR DateTimeV2] Misses dates that are surrounded by specific words.

Describe the bug
Some combinations of dates with words such as "avant", "et", "maintnent" makes RecognizeDateTime miss some results.
To Reproduce
Steps to reproduce the behavior:

Call DateTimeRecognizer.RecognizeDateTime("Avant. JEUDI 3 JUIN 12h55. LUNDI 14 JUIN. Et. Maintenant.", "French").
There is no trace of any dates for "14 JUIN" in the result.

Expected behavior
Expect to find dates "XXXX-06-03T12:55" and "XXXX-06-14" among the results.
Sample input/output
Input: "Avant. JEUDI 3 JUIN 12h55. LUNDI 14 JUIN. Et. Maintenant."
Output:
  seq
    [Microsoft.Recognizers.Text.ModelResult
       {End = 55;
        Resolution = dict
                       [("values",
                         seq
                           [dict
                              [("timex",
                                "(XXXX-06-03T12:55,PRESENT_REF,PT2043H)");
                               ("type", "datetimerange");
                               ("start", "2021-06-03 12:55:00");
                               ("end", "2021-08-27 16:06:55")]])];
        Start = 0;
        Text = "avant. jeudi 3 juin 12h55. lundi 14 juin. et. maintenant";
        TypeName = "datetimeV2.datetimerange";}]

Platform (please complete the following information):

Platform: .NET
Environment: nuget package
Version of package:  "Microsoft.Recognizers.Text.DateTime" Version="1.8.0"

Additional context
Small modifications to the input like removing "maintenent" or "avant" gets you to expected behaviour.
The example text comes from a text in a flight info email where all the words from the example input exist but are part of a bigger text with information about check-in baggage, flight dates, and things such as "...before your departure...".
The same problem occurs when using the full text.
Bonus
A code test in F# that is not passing
test """
          Given a message in french that includes a dateTime and a date
          And the words 'Avant' (before), 'Et' (and), 'Maintenant' (now)
          When processed
          Then we should get both the dateTime and date
          """ {
              let longerVersion =
                  "Nous vous recommandons de bien vérifier les formalités obligatoires avant votre départ. JEUDI 3 JUIN 12h55. LUNDI 14 JUIN. Nombre estimé de Miles et de XP liés à votre billet et aux options éventuellement achetées. Réservez en ligne dès maintenant et bénéficiez de réductions."

              let shortVersion =
                  "Avant. JEUDI 3 JUIN 12h55. LUNDI 14 JUIN. Et. Maintenant."

              DateTimeRecognizer.RecognizeDateTime(shortVersion, "French")
              |> List.ofSeq
              |> List.collect
                  (fun (modelResult: ModelResult) ->

                      (if modelResult.Resolution <> null then
                           modelResult.Resolution.["values"]
                           :?> seq<System.Collections.Generic.Dictionary<string, string>>
                       else
                           seq [])

                      |> Seq.toList
                      |> List.map (fun valueDict -> valueDict.Item "timex"))
              |> Expect.containsAll "" [ "XXXX-06-03T12:55"; "XXXX-06-14" ]
          }

this is specific to Avant, actually other words including Avante do work and resolve all the dates

@aitelint, let's add this one to the stack.

working on this


(PUP-10014) Remove deep_merge as a vendored gem

jenkins please test this with servertests

CLA signed by all contributors.

Do we need to add this here: https://github.com/puppetlabs/puppetserver/blob/master/resources/ext/build-scripts/jruby-gem-list.txt ?

@justinstoller yes we need to update that file before you update puppetserver's pin to more recent puppet versions. Note this isn't an issue for installed packages, because the deep_merge gem should be installed in the shared gem directory.


TiS custom handlers primitive types

TiS custom handlers primitive types

https://github.com/schmittjoh/serializer/pull/507


Patterns for React ?

Any chance this plugin will be adapted to React ?

@Opsolem please take a look at thus https://github.com/lkazberova/react-leaflet-geojson-patterns


Can't add environmental variables to apps

Hey!
I used bare metal for this flynn cluster since the client wants to run all things in their own servers.
I successfully created 3 node cluster which seems to work just fine but when I try to add new envs I get these errors:
$ flynn -c flynn-example -a test env set WP_HOME=https://test.dev.example.com SERVER_NAME=test.dev.example.com
unknown_error: Something went wrong
$ flynn -c flynn-example -a test env set WP_HOME='https://test.dev.example.com'
unknown_error: Something went wrong

I emailed you the debug logs.

@onnimonni what version of the CLI are you using (i.e. flynn version)?

Quite new one @lmars:
$ flynn --version
v20170112.0

@onnimonni this looks suspiciously like an old CLI version was being used, just to make sure can you try setting the env variables again? Just in case the CLI auto-updated in the background.
I'll continue to look at the logs in case that isn't the problem.
Can you also check if setting env vars on other apps works?

Thanks! Seems like I either accidentally updated it or it auto-updated in background.
Now I'm seeing this instead:
$ flynn -c flynn-example -a test env set WP_HOME="http://test.dev.example.com"
deployer: app job failed to start: error getting squashfs layer from http://blobstore.discoverd/docker-receive/layers/02d966291e6bf8fffdaf49b98c2ce2346890a05c858f6841323094525dcf1913.squashfs: unexpected HTTP status 404 Not Found

If this is blobstore related I'm using gcs for blobstore.
$ flynn -c flynn-example -a blobstore env
BACKEND_GCSMAIN=backend=gcs bucket=google-example
BACKEND_GCSMAIN_KEY={"auth_provider_x509_cert_url": ..., "type": "service_account"}
DATABASE_URL=postgres://816eac0c7d31692045b394c3a972e792:0279675d9204692e470b9b6a89bfd8dc@leader.postgres.discoverd:5432/6f084274c59b8b369fa59419ed6ba26f
DEFAULT_BACKEND=gcsmain
FLYNN_POSTGRES=postgres
PGDATABASE=6f084274c59b8b369fa59419ed6ba26f
PGHOST=leader.postgres.discoverd
PGPASSWORD=...
PGUSER=...

@onnimonni try pushing the Docker image again, seems like it was deleted from the blobstore.

I think there's something much worse going on. I tried to push the image again, but it was there already. And then ended up in state where Flynn can't start new containers.
$ flynn -c cluster -a test docker push devgeniem/wordpress-example
flynn: getting image config with "docker inspect -f {{ json .Config }} devgeniem/example"
flynn: tagging Docker image with "docker tag devgeniem/example docker.dev.example.com/test:latest"
flynn: pushing Docker image with "docker push docker.dev.example.com/test:latest"
The push refers to a repository [docker.dev.example.com/test]
7cb263db4274: Layer already exists
4fd7a87a6e42: Layer already exists
7f030ce02baa: Layer already exists
1a07a485449b: Layer already exists
e8e6edd2166f: Layer already exists
118997642cd3: Layer already exists
b2203ba76f71: Layer already exists
1942d7172c09: Layer already exists
dd96c89ca072: Layer already exists
b3d384221566: Layer already exists
15f0221572aa: Layer already exists
f7a4c60182b8: Layer already exists
1c8dc781dad2: Layer already exists
e4620eb0a9e8: Layer already exists
99a2caf969e1: Layer already exists
a183b4d3a1d1: Layer already exists
39d16b1bd8e9: Layer already exists
a2ee3cdcd2bb: Layer already exists
c27f5abca55b: Layer already exists
bf6474acbb2f: Layer already exists
97d5f013090f: Layer already exists
9a473288d6e5: Layer already exists
4b4b075f5f03: Layer already exists
c28fdb0b89a9: Layer already exists
88f1e0775099: Layer already exists
fe4c16cbf7a4: Layer already exists
latest: digest: sha256:66a73d6f517c00da4bddc54661b979fe142893fa7e12428f24a093cdcf948591 size: 41164
flynn: image pushed, waiting for artifact creation
flynn: deploying release using artifact URI http://blobstore.discoverd/docker-receive/images/09596d1454e08d17347b5c937e6a57c4c6a5474193ec87b3e6d2ab972db18a4e.json
flynn: image deployed, scale it with 'flynn scale app=N'
$ flynn -c cluster -a test scale app=1
requested scale equals current scale, nothing to do!
$ flynn -c cluster -a test scale app=2
scaling app: 1=>2

22:04:00.256 ==> app 7a325287-aae5-4b4f-960c-5dc545204793 pending
22:04:00.266 ==> app kwpapp1-7a325287-aae5-4b4f-960c-5dc545204793 starting
22:04:00.286 ==> app kwpapp1-7a325287-aae5-4b4f-960c-5dc545204793 down
22:04:00.286 ==> app ac48ca9d-5e85-4dfa-93d5-2405dbafb133 pending
22:04:00.311 ==> app kwpapp1-ac48ca9d-5e85-4dfa-93d5-2405dbafb133 starting
22:04:00.316 ==> app 1814ba90-2547-4a3a-acd0-2e46efaf5568 pending
22:04:00.316 ==> app kwpapp1-ac48ca9d-5e85-4dfa-93d5-2405dbafb133 down
22:04:00.316 ==> app kwpapp2-1814ba90-2547-4a3a-acd0-2e46efaf5568 starting
22:04:00.346 ==> app kwpapp2-1814ba90-2547-4a3a-acd0-2e46efaf5568 down
22:04:00.347 ==> app 716fe63e-8b12-4ac0-86c6-f091056d1099 pending
22:04:00.366 ==> app kwpapp1-716fe63e-8b12-4ac0-86c6-f091056d1099 starting
22:04:00.376 ==> app 026fb7e2-a9c4-4af9-8503-9aff6582df72 pending
22:04:00.376 ==> app kwpapp1-716fe63e-8b12-4ac0-86c6-f091056d1099 down
22:04:00.386 ==> app kwpapp2-026fb7e2-a9c4-4af9-8503-9aff6582df72 starting
22:04:00.417 ==> app 26e8a14d-905c-48d6-9fcb-cc13632761e5 pending
22:04:00.417 ==> app kwpapp2-026fb7e2-a9c4-4af9-8503-9aff6582df72 down
22:04:00.426 ==> app c95ae576-1412-4d40-98a1-b2c19c95ce29 pending
22:04:00.426 ==> app kwpapp2-26e8a14d-905c-48d6-9fcb-cc13632761e5 starting
22:04:00.436 ==> app kwpapp2-26e8a14d-905c-48d6-9fcb-cc13632761e5 down
22:04:10.608 ==> app kwpapp2-c95ae576-1412-4d40-98a1-b2c19c95ce29 starting
22:04:10.609 ==> app kwpapp2-c95ae576-1412-4d40-98a1-b2c19c95ce29 down
22:04:10.609 ==> app 74a16428-a4d9-47b1-b19a-7df6c5866ad5 pending
Timed out waiting for job events. Waited 20 seconds.
expected: map[app:map[up:1]]
actual: map[app:map[pending:8 starting:7 down:7]]
$ flynn -c cluster -a test ps
ID                                            TYPE  STATE    CREATED        RELEASE
kwpapp3-7ddd7eb4-fdaf-4c4b-81d8-33dd0e52e211  app   up       3 minutes ago  062c5406-0753-4606-bb1c-fdd4ea65af73
674afd51-7c8c-4939-b0b7-9008a14f82e0          app   pending  3 seconds ago  062c5406-0753-4606-bb1c-fdd4ea65af73
$ flynn -c seamk -a test ps
ID                                            TYPE  STATE    CREATED        RELEASE
kwpapp3-7ddd7eb4-fdaf-4c4b-81d8-33dd0e52e211  app   up       4 minutes ago  062c5406-0753-4606-bb1c-fdd4ea65af73
473a8d0a-4c72-47a9-9e9c-5db1d37bacf1          app   pending  2 seconds ago  062c5406-0753-4606-bb1c-fdd4ea65af73

And when I try to open up a bash into container:
$ flynn -c seamk -a example run bash
unknown_error: Something went wrong
# Waiting for 10s
$ flynn -c seamk -a example run bash
unknown_error: Something went wrong
# Waiting for 10s
# And it finally works
$ flynn -c seamk -a example run bash
root@79bbbdf4-b68b-4ecc-b398-1ad134a2b997:/var/www/project#

@onnimonni please collect the debug logs again.

Whoa thanks, for such fast answer. I emailed them you just now but run into few out of memory errors:
$ flynn-host collect-debug-info
INFO[01-12|22:26:37] uploading logs and debug information to a private, anonymous gist
INFO[01-12|22:26:37] this may take a while depending on the size of your logs
INFO[01-12|22:26:37] getting flynn-host logs
INFO[01-12|22:28:03] getting sirenia metadata
INFO[01-12|22:28:03] getting scheduler state
INFO[01-12|22:28:04] getting job logs
INFO[01-12|22:28:38] getting system information
EROR[01-12|22:28:38] error capturing output of "ps faux"      err="fork/exec /bin/ps: cannot allocate memory"
EROR[01-12|22:28:38] error capturing output of "ifconfig"     err="fork/exec /sbin/ifconfig: cannot allocate memory"
EROR[01-12|22:28:38] error capturing output of "uname -a"     err="fork/exec /bin/uname: cannot allocate memory"
EROR[01-12|22:28:38] error capturing output of "lsb_release -a" err="fork/exec /usr/bin/lsb_release: cannot allocate memory"
EROR[01-12|22:28:38] error capturing output of "date"         err="fork/exec /bin/date: cannot allocate memory"
EROR[01-12|22:28:38] error capturing output of "free -m"      err="fork/exec /usr/bin/free: cannot allocate memory"
EROR[01-12|22:28:38] error capturing output of "df -h"        err="fork/exec /bin/df: cannot allocate memory"
EROR[01-12|22:28:38] error capturing output of "flynn-host version" err="fork/exec /usr/local/bin/flynn-host: cannot allocate memory"
EROR[01-12|22:28:38] error capturing output of "route -n"     err="fork/exec /sbin/route: cannot allocate memory"
EROR[01-12|22:28:38] error capturing output of "iptables -L -v -n --line-numbers" err="fork/exec /sbin/iptables: cannot allocate memory"
INFO[01-12|22:28:38] Total size of<PHONE_NUMBER> bytes exceeds gist limit, falling back to tarball.
INFO[01-12|22:30:04] created tarball containing debug information at /tmp/flynn-host-debug222509979/flynn-host-debug.tar.gz

I ran those commands separately and included the output in the mail I sent to you.

@onnimonni I can't see your Docker push in any of the docker-receive logs, and the resulting jobs fail because they can't find the pushed layers. Do you perhaps have your DNS misconfigured and you are pushing to one cluster then trying to scale in another?
All of the test jobs failed in the debug logs, so the fact that you got one to run seems to suggest that it ran in a different cluster.

Can't reproduce this anymore. Thanks for the help.


Document ports used

As part of implementing #1600
We probably need more ports open and we should document which ports are required for each scenarios:
With embedded DERP:

80 -> for generate204
3478 -> STUN
443 -> Headscale + DERP

With Letsencrypt:

80 -> ownership check

Standard:

50443 -> gRPC
9090 -> /metrics

Is it possible to change the usage of port 80. I have headscale listening on below
server_url: https://hs.mydomain.com:8443

and caddy web server on port 80 and 443. The clients seem to send the below request to port 80 which gets logged in caddy as errors instead of reaching headscale. Is the below request only used with embedded derp?
{
    "level": "info",
    "ts": "<timestamp>",
    "logger": "http.log.access.log0",
    "msg": "handled request",
    "request": {
      "remote_ip": "XX.XX.XX.XX",
      "remote_port": "40362",
      "client_ip": "XX.XX.XX.XX",
      "proto": "HTTP/1.1",
      "method": "POST",
      "host": "hs.mydomain.com:80",
      "uri": "/ts2021",
      "headers": {
        "User-Agent": [
          "Go-http-client/1.1"
        ],
        "Content-Length": [
          "0"
        ],
        "Connection": [
          "upgrade"
        ],
        "Upgrade": [
          "tailscale-control-protocol"
        ],
        "X-Tailscale-Handshake": [
          "<base64 encoded binary data>ggwE="
        ]
      }
    },
    "bytes_read": 0,
    "user_id": "",
    "duration": 0,
    "size": 0,
    "status": 0,
    "resp_headers": {
      "Server": [
        "Caddy"
      ]
    }
  }


License

Can you please make clear under what license the code is available e.g. add a LICENSE file. Thank you.

I added a LICENSE file (MIT) to the master branch.


pull from origin

Can you give more details and flesh out the description? It'll be easier to review your code that way.

@dogfalo bump yo.

@leafiy Last chance.

@tomscholz well this was done more than a year ago


Badly written word "Agregar" in spanish version. It is written as "Agrerar"

My Setup

Operating System: windows 10
App Version: 2.14.1
Installation type: .exe

yes my problem is just a thing of translation:

The word "Agregar" is badly written in spanish, i would like to see it well translated in a future version. It is writen Agrerar. Could please correct it?
The badly written word is in the part when I try to add a new member to a group chat. In the picture i uploaded it appears badly written two times.

Issue moved to RocketChat/Rocket.Chat #12508 via ZenHub


Can this package support arm linux

Currently only supports arm64, can support arm？

@imkos I don't have hardware to write/test on. PRs are welcome, but you will have to have done extensive testing.


Pin libcxx <18 to workaround illegal instruction failure

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

This was actually fixed by https://github.com/robotology/idyntree/pull/1198 .


cimport numpy causes GCC error with exit status 1

advice from conda people directed me here.
https://github.com/ContinuumIO/anaconda-issues/issues/11152#issuecomment-533827722
I'm using conda 4.7.12, python 3.7.4, and cython 0.29.13
My test1.pyx file is just:
import numpy
cimport numpy
cimport cython

but I cannot import it. Running this yields:
>>> import cython;import pyximport;pyximport.install()
(None, <pyximport.pyximport.PyxImporter object at 0x7fcacf6919d0>)
>>> import test1
...
/home/me/.pyxbld/temp.linux-x86_64-3.7/pyrex/test1.c:598:10: fatal error: numpy/arrayobject.h: No such file or directory
 #include "numpy/arrayobject.h"
          ^~~~~~~~~~~~~~~~~~~~~
...
ImportError: Building module test1 failed: ["distutils.errors.CompileError: command 'gcc' failed with exit status 1\n"]

I can't get any new .pyx to import if it contains cimport numpy. but if i remove that one line, everything works fine.

is this related?
(on a local machine)
(loc_cyth) C:\Users\me\Documents\_testing_>python
Python 3.7.4 (default, Aug  9 2019, 18:34:13) [MSC v.1915 64 bit (AMD64)] :: Anaconda, Inc. on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy as np
>>> cimport numpy as np
  File "<stdin>", line 1
    cimport numpy as np
                ^
SyntaxError: invalid syntax
>>>

Yes, use numpy.get_include(). See the docs.


DoubleTensor test fails on all architectures

I have checked with caffe guys and they say there is no way those errors may have numeric origin (when they change float to double in their networks, it never increases the error).
So I think, it's reasonable to assume we may have some layout/alignment/copy error in templated types handling, at least for double type.
The error values also differ by order of magnitude between runs, which also suggest reading garbage or corruption:
SpatialFullConvolution_backward_batch
error on bias (backward)
LT failed:<PHONE_NUMBER>3359 >= 0.02
test/test.lua:348: in function 'test'
test/test.lua:351: in function <test/test.lua:301>
... next run:
SpatialFullConvolution_backward_batch
error on bias (backward)
LT failed: 94.976547241211 >= 0.02
test/test.lua:348: in function 'test'
test/test.lua:351: in function <test/test.lua:301>

@borisfom indeed, the outputs of convolution in double contain the same small number, and there are a few places were extraBuffer size is allocated with "4" sizeof hardcoded, however fixing this doesn't help. I think there is another issue somewhere in the bindings.

Allocating with size 4 is indeed a problem (as it's a LongTensor), I have fixed it in my clone as well to always use elementSIze and yes it did not help.
From time to time I am getting segmentation faults (usually when tweaking CUDNN params incorrectly, but still, should not crash). I think it's worth checking memory, too. I have tried  running valgrind on torch, but luajit has issues with it even if rebuilt with dedicated VALGRIND flag. Did you try it before? What would be the workarounds - build with Lua instead ?
@soumith  : any hints ?

Those are my results now. Note all 'functional' tests pass, could there be a clue here?
th ./cudnn/test/test.lua
Running test on device: #1 : Graphics Device
Testing torch.CudaDoubleTensor
Running 38 tests
1/38 VolumetricMaxPooling_batch ........................................ [PASS]
2/38 SpatialMaxPooling_single .......................................... [FAIL]
3/38 SpatialCrossEntropyCriterion ...................................... [PASS]
4/38 SpatialMaxPooling_batch ........................................... [PASS]
5/38 SpatialAveragePooling_batch ....................................... [PASS]
6/38 LogSoftMax_single ................................................. [FAIL]
7/38 functional_bias2D ................................................. [PASS]
8/38 SpatialBatchNormalization ......................................... [FAIL]
9/38 SpatialConvolution_forward_single ................................. [FAIL]
10/38 functional_convolution2d .......................................... [PASS]
11/38 SpatialFullConvolution_backward_batch ............................. [FAIL]
12/38 TemporalConvolution_padding_batch ................................. [FAIL]
13/38 SpatialConvolution_backward_single ................................ [FAIL]
14/38 Tanh_single ....................................................... [FAIL]
15/38 ClippedReLU_single ................................................ [PASS]
16/38 ReLU_single ....................................................... [FAIL]
17/38 Sigmoid_single .................................................... [FAIL]
18/38 VolumetricConvolution_forward_single .............................. [FAIL]
19/38 Tanh_batch ........................................................ [FAIL]
20/38 SoftMax_batch ..................................................... [FAIL]
21/38 SpatialCrossMapLRN_batch .......................................... [FAIL]
22/38 VolumetricMaxPooling_single ....................................... [FAIL]
23/38 VolumetricBatchNormalization ...................................... [FAIL]
24/38 ReLU_batch ........................................................ [FAIL]
25/38 SpatialConvolution_backward_batch ................................. [FAIL]
26/38 TemporalConvolution_batch ......................................... [FAIL]
27/38 SpatialFullConvolution_forward_batch .............................. [FAIL]
28/38 Sigmoid_batch ..................................................... [FAIL]
29/38 SpatialLogSoftMax ................................................. [FAIL]
30/38 TemporalConvolution_reduceBatchSize ............................... [PASS]
31/38 LogSoftMax_batch .................................................. [FAIL]
32/38 BatchNormalization ................................................ [FAIL]
33/38 TemporalConvolution_single ........................................ [FAIL]
34/38 functional_maxpooling2d ........................................... [PASS]
35/38 SpatialConvolution_forward_batch .................................. [FAIL]
36/38 SpatialAveragePooling_single ...................................... [FAIL]
37/38 VolumetricConvolution_backward_single ............................. [FAIL]
38/38 SoftMax_single .................................................... [FAIL]
Completed 253 asserts in 38 tests with 29 failures and 0 errors

@borisfom functional tests are not type specific, they test only float.
I checked with my RTC version of SpatialConvolution for double that it works correctly, so I think it's more likely that there is an issue in the bindings than in cutorch. @soumith I think we need your help here, any ideas?

After updating torch, with double I have intermittent errors with SpatialMaxPooling_single and intermittent illegal memory access in SpatialConvolution_forward_single, the rest of the tests pass.

Do you mean updating it as per our discussion in https://github.com/soumith/cudnn.torch/pull/228 ?

I've updated all packages (./update.sh && ./install.sh), and pulled Sergey's buffer-sizeof branch of cudnn.torch. Now after I've fixed extraBuffer size according to my comment in 228 I can not longer get SpatialConvolution to error with illegal memory access, but may be I'm just lucky.

That makes perfect sense! I will fix my refactoring change accordingly and push the change.

@ngimel : somehow doing similar changes in my workspace did not fix double tests for me - can you push your changes to your clone so I can peek ?

@ngimel: mystery solved: I forgot to mention that you need to modify tolerance in test.lua for double tests (make them the same as float) to unmask errors. I have printed some outputs for debug and it looks like zeros are being copied instead of double values.

I've fixed all double tensor issues. Now all tests pass for Float and Double Tensor.
For Half, the tests only dont pass for *Convolution's backward, because CuDNN does not support all filter shapes / sizes for half yet.
All other tests pass for Half.


Save screenshot/HTML on first occurrence of error in error statistics

Which package is the feature request for? If unsure which one to select, leave blank
None
Feature
There is already a robust system of organizing error statistics. For some scrapers, I use an "ErrorSnapshotter" approach where on the first occurrence of each type of error, a screenshot and/or HTML is stored in KV store for further analysis. We should also store a link (either Apify or local path) to the snapshot KV records next to the error statistics count.
Here is an example of how the stats file looks now
https://api.apify.com/v2/key-value-stores/L7DclFFX3fHuPCne9/records/SDK_CRAWLER_STATISTICS_0
Motivation
Useful for faster default debugging, especially for "one of thousands" type of errors or when other users are running the scraper.
Ideal solution or implementation, and any additional constraints
Implementation ideas
The current implementation is hidden under several function calls so it is a bit tricky to add a completely new functionality.
Tha main classes are Statistics and ErrorTracker.

The dirty solution would be to send the crawling context through the function calls and then just dynamically figure out if it is Puppeteer, Playwright, or HTML body and use the appropriate snapshotting method from context.
The more proper way would probably be to use generics all the way down but I haven't explored that option.
Or do a larger refactor

Keep in mind

Some errors happen before any page is created or opened, before navigation happens, or after the page is already closed (maybe then a response object is still available to store HTML?)
We need to generate unique filenames. I like if the filenames carry some information so one idea is a hash of the full error object path from ErrorTracker + the first 30 (or 50?) characters of the error for easy reading.

Alternative solutions or implementations
No response
Other context
No response

Sounds like a duplicate of #1771, maybe we should close that one?


String binary support

Hi,
i'd like to use CreateApi, but my open api spec has the following item inside a multipart/form-data request:
               "properties": {                   "documents": {                     "type": "array",                     "items": {                       "type": "string",                       "format": "binary"                     }                   },
This generates to an Entity that has a String Array. But SwaggerUI sends plain bytes. I guess a String can't hold plain bytes, so I'd need to encode them somehow and this won't be accepted by the Backend.
Is this a missing feature or am I missing something?

inside a multipart/form-data request

I think this is likely to be the root issue here. CreateAPI is currently primarily focused on supporting JSON serialisation but I guess that you need to make a multipart/form-data request here?
This wouldn't be supported in the simplest configuration (i.e using Get as an API Client) but there might be some ways that you can work around this although I haven't tried the below...
Firstly, try mapping the binary format to a different type in your configuration:

inside a multipart/form-data request

I think this is likely to be the root issue here. CreateAPI is currently primarily focused on supporting JSON serialisation but I guess that you need to make a multipart/form-data request here?
This wouldn't be supported in the simplest configuration (i.e using Get as an API Client) but there might be some ways that you can work around this although I haven't tried the below...
Firstly, try mapping the binary format to a different type in your configuration using dataTypes:
generate: [paths, entities, enums]
dataTypes:
  string:
    binary: File

The generated code should then turn your documents array into [File]. You'll need to add your own type called File and it will need to conform to the Encodable and Decodable protocol to compile I think (you might be able to limit this by setting entities.alwaysIncludeDecodableImplementation to false).
Your File type could maybe be something like this:
public struct File: Codable {
    let fileURL: URL
    let contentType: String
}

While using JSONEncoder (or probably any other encoder) wouldn't encode this like you want, you could maybe write your own encoder, or somehow map the generated entities into something else that lets you create the HTTP Body that you need?
I'm not sure if there are any other third party libraries out there that help more, but let me know if any of this helps. If it doesn't, could you share a little more about how you plan to integrate CreateAPI (i.e to generate a Swift Package, using Get or a third party client etc)?

Thanks for your tips!
I'm trying to generate a Swift Package using Get for a non-public API. I have an OpenAPI spec.
The request is a multipart/form-data because it supports upload of multiple files (and has some other fields, too).
        "requestBody": {
          "content": {
            "multipart/form-data": {
                "type": "object",
                "properties": {
                  "documents": {
                    "type": "array",
                    "items": {
                      "type": "string",
                      "format": "binary"
                    },
                  },
                  "totalAmount": {
                    "type": "number",
                    "format": "double",
                    "example": 8.99
                  },
...

When I'm trying your solution, CreateApi doesn't change the [String] to [File] although it works on other fields. I guess it's not supported to change dataTypes inside Arrays?

Yes, that's correct that array overrides haven't been added. I implemented the data type overrides but those only apply to schema dataTypes and not arrays because they are defined as objects. I'll admit I didn't take much look into arrays being overriden as well but I don't think it will be that difficult.

I stepped into the code and it looks like the array information is already lost while parsing.
I got into this line: https://github.com/CreateAPI/CreateAPI/blob/22074e5167c0b509a5241ba72a3cdbac894f88b1/Sources/CreateAPI/Generator/Generator%2BSchemas.swift#L593
and info is ArrayFormat.generic which means no type information.
I don't have time to dig any further, i suspect it's a missing feature in OpenAPIKit.

OpenAPIKit works as expected, the data type overrides are done by CreateAPI. We would implement this by looking at the type definition of the property being created and override that with the provided override from the config.

Its expected that info.format would be .generic given this schema:
{
  "documents" {
    "type": "array",
    "items": {
      "type": "string",
      "format": "binary"
    }
  }
}

Because the format we actually care about is the format of the nested items schema... At least that's what I would have thought 😅

We would implement this by looking at the type definition of the property being created and override that with the provided override from the config

I didn't run it, but that seems to be what should already happen. makeTypealiasArray(...) calls into _makeDeclaration(...) and passes the items schema which should already have the annotation.
I need to run the code and play around a bit to see what is happening though

I just tried it and it worked as expected for me. Which version of CreateAPI are you using? dataTypes was only added to 0.1.0.
One thing to note is that when I used multipart/form-data for the content type, CreateAPI initially generated the request body as an entire Data for which I assume was because it doesn't technically support multipart form data encoding.

You're right, the multipart/form-data request is generated as Data, i actually overlooked this.
But i can't get the replacement of binary working for entities:
  "components": {
    "schemas": {
      "Receipt": {
        "type": "object",
        "properties": {
          "documents": {
            "type": "array",
            "items": {
              "type": "string",
              "format": "binary"
            },
            "nullable": true
          }
        },
        "additionalProperties": false
      },

Together with
dataTypes:
  string:
    binary: File

produces:
public struct Receipt: Codable {
    public var documents: [String]?

Once i change the "format" from "binary" to "custom" and replace custom with binary in dataTypes, i get the correct result:
public struct Receipt: Codable {
    public var documents: [File]?

But overall, what I'm missing is multipart support. Sorry for the misdirection. Is Get capable of multipart requests?

But overall, what I'm missing is multipart support. Sorry for the misdirection

No troubles. This isn't something that I had considered much either but actually I am going to run into a similar issue on our project at some point in the future too 😄

Is Get capable of multipart requests?

I think there are workarounds, but I'm not sure if it's technically considered as supported. The APIClient in Get is designed to accept an Encodable body type which will then use a universal Encoder to encode into a HTTP body.
You could theoretically work around this by using a different instance of APIClient that use a custom configuration with an alternative encoder, but currently it isn't very well joined together so it would still require some manual work.
To bridge this information better the Request type might need a mechanism to define different types of encoding and decoding mechanisms that are supported. I'm not entirely sure how this would look though.
Beyond Alamofire's multipart form data support, I haven't actually seen much support for multipart requests in Swift. If there was a good Encoder that builds from Swift's Codable system, I guess there could be potential to tell CreateAPI to generate a typed request body (like we do with application/json) and then somehow have a way to use different Encoders in Get's APIClient to turn that into the correct body data?
The next problem that I could potentially see us facing here however is dealing with large files. Since with large files, you might find that you need to use background upload tasks which Get certainly doesn't support.
I'm not sure if there are other options either though? cc'ing @kean on this one too as he might have some thoughts.


Running 4.0 with pnpm and stylelint cli requires full path

Describe the bug
We use pnpm and had a package.json script that looks like this:
"code-check:stylelint": "stylelint --custom-formatter=node_modules/stylelint-formatter-pretty \"**/*.scss\"",

which worked fine, up until 4.0. After upgrading to 4.0 (and stylelint 16), this no longer works. The following error is thrown:
node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import '/Users/michael/proj/node_modules/stylelint-formatter-pretty' is not supported resolving ES modules imported from /Users/michael/proj/node_modules/.pnpm/stylelint<EMAIL_ADDRESS>Did you mean to import /Users/michael/proj/node_modules/.pnpm/stylelint-formatter-pretty<EMAIL_ADDRESS>    at finalizeResolution (node:internal/modules/esm/resolve:258:11)
    at moduleResolve (node:internal/modules/esm/resolve:917:10)
    at defaultResolve (node:internal/modules/esm/resolve:1130:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
    at ModuleLoader.import (node:internal/modules/esm/loader:328:34)
    at importModuleDynamically (node:internal/modules/esm/translators:158:35)
    at importModuleDynamicallyCallback (node:internal/modules/esm/utils:207:14)
    at dynamicImport (file:///Users/michael/proj/node_modules/.pnpm/stylelint@16.2.1_typescript@5.3.3/node_modules/stylelint/lib/utils/dynamicImport.mjs:12:68) {
  code: 'ERR_UNSUPPORTED_DIR_IMPORT',
  url: 'file:///Users/michael/proj/node_modules/stylelint-formatter-pretty'
}

Node.js v20.11.0

It does work, if I provide the full path:
pnpm stylelint --custom-formatter=node_modules/.pnpm/stylelint-formatter-pretty<EMAIL_ADDRESS>
but that is unsightly and will need to be updated every time versions change. Is this expected? Is there another way to get this working?
To Reproduce
Steps to reproduce the behavior:
Add stylelint, stylelint-formatter-pretty to your package.json. Run pnpm install and then try:
pnpm stylelint --custom-formatter=node_modules/stylelint-formatter-pretty

Expected behavior
It should work without specifying the full path to index.js
Versions:

OS: macOS 14.3.1
Node: 20.11
Package: v4 & stylelint v16.2

Additional context
Add any other context about the problem here.

Thanks for reporting this, I will take a look at it.
Maybe the exports are not working for pnpm. Have you tried other 3rd party Stylelint formatters, are they working as expected?

Thanks for reporting this, I will take a look at it.
Maybe the exports are not working for pnpm. Have you tried other 3rd party Stylelint formatters, are they working as expected?

I have not yet, will let you know any findings there if I can find some time to find and try one.

This is actually working for me:
pnpm stylelint --custom-formatter stylelint-formatter-pretty *.css

Note the missing node_modules/.
I also tested this with npx and yarn, works like a charm.
Apparently the documentation for using the formatter with Stylelint’s CLI isn’t up-to-date (but the screenshot is).
Can you check if it works for you that way? Then I would update the documentation.

That does indeed work! Thank you


Fix kfctl_second_apply test

This change is

Here's the presubmit where the second_apply test passed: http://testing-argo.kubeflow.org/workflows/kubeflow-test-infra/kubeflow-kfctl-presubmit-kfctl-go-iap-218-cbf79c8-5873-af90?tab=workflow
Maybe we should just remove the skip flag since it is now passing.

/approve

/assign @kunmingg
/assign @jlewi

/approve


Change version of Web3 dependency to avoid missing BigNumber.js library.

Interesting... indeed the fork by frozeman has disappeared off the web. Why upgrade to another fork though? The tests pass with 1.0.0-beta.33 (see test/multidep.json). I'd guess that they would with 1.0.0-beta.34 as well...


Add drop down menu

In SimpleVisibleComponentsPanel.java. I changed the checkboxPhoneTablet from CheckBox to ListBox to add more screen size options for designers. Also added four final fields for monitor option and edited changePreviewSize() in MockForm.java. Also added and edited previewTabletSize() previewMonitorSize() previewPhoneSize() in OdeMessage.java.
Now, designers can change the screen size based on these three options

I also wonder if it would make sense to add the resolution in parentheses in the dropdown entries so that it's more clear what the sizes are. I don't know what the monitor size is, for example (and the others I know only because I've been working with App Inventor long enough).

Sorry for the negligence. I will check it and pr again ASAP. And for the resolution, do you mean that designers can see the specific pixel width and pixel height for each options?

Yes, by resolution I mean size in pixels. Thanks.

Superseded by #1557


Added a few notes to classes.xml

I added a few tidbits of documentation regarding matrix32, array, and color, and sprite classes.

Could you then rebase to remove d222e82? See git rebase -i HEAD~5 and remove the line corresponding to d222e82. This will prevent merge conflicts with @vnen's PR.

Alright, I did a rebase and removed the conflict.

Thanks. Note that 44057ed might be overridden next time the template is updated from the source code; if those arguments are really Vector2s, then the issue might be in the source code directly. But we'll see, let's merge.


copyq: 3.7.2 -> 3.7.3

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/copyq/versions.
meta.description for copyq is: '"Clipboard Manager with Advanced Features"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
/nix/store/amrzpc20vh06y951r463zk58mnxhahi0-CopyQ-3.7.3/bin/copyq passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 3.7.3 with grep in /nix/store/amrzpc20vh06y951r463zk58mnxhahi0-CopyQ-3.7.3
directory tree listing: https://gist.github.com/acc4590e7c5b505d98fee93f51cc2363
du listing: https://gist.github.com/8f5c24091ee25d4dd7a60647b4333a7b

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
copyq

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/amrzpc20vh06y951r463zk58mnxhahi0-CopyQ-3.7.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A copyq https://github.com/r-ryantm/nixpkgs/archive/40e4e6fc52ab0bfb2723b5f44949cc56eeb4b3b2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/amrzpc20vh06y951r463zk58mnxhahi0-CopyQ-3.7.3
ls -la /nix/store/amrzpc20vh06y951r463zk58mnxhahi0-CopyQ-3.7.3/bin

Works for me.


buildRustPackage fetch-builder.sh fails if package doesn't contain Cargo.lock

The buildRustPackage builder script fetch-builder.sh fails with rm: cannot remove 'Cargo.lock': No such file or directory if the package it's building doesn't include a Cargo.lock file. According to the Cargo documentation, this file is usually included in source trees for executables, but not for libraries. It looks like right now we depend on rewriting the Cargo.lock file for deterministic builds. As a workaround when Cargo.lock is absent, would it make sense to have the builder run cargo update against the local rustRegistry and use the generated Cargo.lock file in the build?

@unjordy That would mean that whenever rustRegistry is updated, we would also have to change all the depsSha256 hashes of all the packages that don't have a Cargo.lock, because cargo update may now decide to use a newer version of a library.
Can you give an example of a program that doesn't have Cargo.lock? It may be better to convince upstream to include Cargo.lock than for us to support programs that don't have it (unless there is a good reason for it).
Note that it shouldn't be necessary for libraries to have Cargo.lock because neither we nor cargo currently support building programs that link to libraries built in a separate package / derivation.
Instead, libraries are always built from scratch when we build the program that includes the library. In this case, the Cargo.lock of the program includes the locked versions of the libraries that the program uses.

Regardless of what I said, there was supposed to be a better error message than what you mentioned... so at least, we have to fix that.

Ok, I just checked that with a recent version of nixpkgs (where fetch-builder.sh doesn't even exist anymore), there is a more user-friendly error message shown when a package doesn't include Cargo.lock (explaining why it is needed):
Using rust registry from /nix/store/2fd4haxsw3j7d1gjbqn6p3x3vq8jp6mg-rustRegistry-2015-05-19-6280837
ERROR: The Cargo.lock file doesn't exist

Cargo.lock is needed to make sure that depsSha256 doesn't change
when the registry is updated.

BTW, if upstream refuses to include Cargo.lock, we can always generate the file ourselves and add it to nixpkgs, and then copy it into the output of src attribute.
Or even simpler, we could just create a patch that simply creates Cargo.lock, and then just apply it to the sources like any other patch. However, this may need further changes to buildRustPackage, to make sure that it applies all patches before downloading dependencies (probably we just need to add patchPhase to the list of phases in fetchcargo.nix).

@wizeman Excellent point about depssha256 potentially changing with a cargo update, and I hadn't realized Cargo builds don't allow linking in dependencies in external packages. As for crates that exclude a Cargo.lock (and now disregarding most libraries for the reason you gave), I can come up with two legitimate instances where Cargo.lock would be excluded.
The first instance is bare metal development projects like zinc.rs, which use Cargo to pull in dependencies and a separate build system to compile a binary. But the bare metal projects are a poor fit for packaging of any kind right now.
The second instance is a library which exposes a C ABI interface and outputs a library that can be used by gcc or clang. In this case, it's correct for them to exclude Cargo.lock and for us to include the package in nixpkgs with the C ABI libraries as the build output. I was actually looking at a popular Rust library that does this last week, but I'm drawing a blank on which one it was right now. This will certainly be a popular use case in the future, but it's a bit of an edge case at the moment. If someone runs into Cargo.lock issues packaging one of these libraries for nixpkgs, your notes about patching Cargo.lock into the sources should be very useful.
For reference (and since this may come in handy for Rust devenvs), what is the procedure to run cargo update against the system rustRegistry instead of crates.io?

@unjordy Good point about the Rust library exposing a C ABI, I hadn't thought of that use case. I'm hoping that people who create Nix derivations could patch in a Cargo.lock themselves at the moment they create the derivation, to make sure that we download dependencies deterministically, but I don't know if cargo would use it or if it would just ignore it...
To answer your question, I think that currently there is no easy way to run cargo update against the system rustRegistry instead of crates.io. It would be great if there was some kind of script we could run to make this easy (some kind of nix-prefetch-cargo maybe?).
What I currently do instead (for my personal projects) is the following:

I run cargo update against crates.io
I update rustRegistry locally (and soon afterwards I push it to nixpkgs)

As long as I update rustRegistry after I run cargo update, then the system rustRegistry will always have information about the package versions in my Cargo.lock files...
I know this is not ideal, but step 2 can be automated and at least, it works for my limited use cases. However, it would be great if we could improve it...

@wizeman Hmm, cargo fetch should definitely pick up on a patched in Cargo.lock. But the cargo update process definitely isn't ideal at the moment. Better support for repositories that aren't crates.io would be great both for us and for Rust in the enterprise; I might be submitting some pull requests to Cargo when I get the chance if there are no (perhaps undocumented) existing options for our Cargo use case.

Okay, so I forked capnpc-rust to fractalide/capnpc-rust, added the Cargo.lock and I still get the error. (https://github.com/fractalide/capnpc-rust/blob/master/Cargo.lock). What gives?

@sjmackenzie Can you show me how your derivation looks like, so that I can try to reproduce?
I'm wondering if you simply forgot to point your derivation to your new project... otherwise it would be weird that you saw the error "Cargo.lock is missing" if the file is really there...

@wizeman sure!
this is the bit I include it: https://github.com/fractalide/nixos-infrastructure/blob/master/profiles/development.nix#L8
this is expression: https://github.com/fractalide/nixos-infrastructure/blob/master/pkgs/capnpc-rust.nix
Much appreciated!

@wizeman (comment updated)

@sjmackenzie You are getting the error because your derivation is pointing to a git revision that does not contain Cargo.lock. You should update the rev attribute in the fetchFromGitHub derivation from 727ab28fb9f335a16a383e54f3acbbef0cea5b15 to 55464a598d1a2e9efc10dd6eacc21f9fb153c9c7, the latter being the commit where you added Cargo.lock to your repository.
Also, this is unrelated but unless you are having problems, you should be using rustUnstable in your derivation instead of rustUnstableCargoPlatform. The latter should only be used to build cargo itself (as the comment in all-packages.nix alludes to, but not very clearly).

I feel like kicking myself! :-) Thanks so much for this, along with the rustUnstable information.

unpacking sources
unpacking source archive /nix/store/r4rxqx4x0w8z4vbwgbqbcbsp03s45m3r-capnpc-rust-55464a598d1a2e9efc10dd6eacc21f9fb153c9c7-src
source root is capnpc-rust-55464a598d1a2e9efc10dd6eacc21f9fb153c9c7-src
installing
Fetching /tmp/nix-build-capnpc-rust-2015-12-07-fetch.drv-0/capnpc-rust-55464a598d1a2e9efc10dd6eacc21f9fb153c9c7-src to /nix/store/np6lscwhvrzpq1i85r32hd9121vgi717-capnpc-rust-2015-12-07-fetch
Using rust registry from /nix/store/10xg2m3cqg68rdx9g4ms5gq5rbyxxj92-rustRegistry-2015-11-01-a0534d1
    Updating registry `file:///nix/store/10xg2m3cqg68rdx9g4ms5gq5rbyxxj92-rustRegistry-2015-11-01-a0534d1`
no matching package named `capnp` found (required by `capnpc`)
location searched: registry file:///nix/store/10xg2m3cqg68rdx9g4ms5gq5rbyxxj92-rustRegistry-2015-11-01-a0534d1
version required: = 0.5.2
versions found: 0.5.0, 0.4.4, 0.4.3, ...

So the next step is to bump the rust registry right? This is done by editing this line https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/rust-packages.nix#L10 (+ adjusting the sha256) then pushing it soon afterwards? correct?

@sjmackenzie That's correct. You can also submit that as a pull request, so that everyone can benefit from access to updated packages :-)

@sjmackenzie Also, I forgot to mention you also need to update the rev attribute to point to a commit from that date (today's date, preferably).

Ah, sorry I was absent minded, I meant rev when I said sha256. Thanks for this work, really makes life much easier for us :-)

Ah I see you (@wizeman) bumped the rust registry. Thanks! I didn't push my changes because I'm still getting this error:
 $ nix-build
these derivations will be built:
  /nix/store/irh1bzs62nl1945r2s0qhincqxxy0v0n-capnpc-rust-2015-12-07-fetch.drv
  /nix/store/qb82bk1afwk4nw246b8al9wqz8960gjm-capnpc-rust-2015-12-07.drv
building path(s) ‘/nix/store/np6lscwhvrzpq1i85r32hd9121vgi717-capnpc-rust-2015-12-07-fetch’
unpacking sources
unpacking source archive /nix/store/ajg9bss9rnh8xip6rngih5xlvs1h5ph8-capnpc-rust-1123a4f5de32f0300f1a6b8014b6c3525e170fa9-src
source root is capnpc-rust-1123a4f5de32f0300f1a6b8014b6c3525e170fa9-src
installing
Fetching /tmp/nix-build-capnpc-rust-2015-12-07-fetch.drv-0/capnpc-rust-1123a4f5de32f0300f1a6b8014b6c3525e170fa9-src to /nix/store/np6lscwhvrzpq1i85r32hd9121vgi717-capnpc-rust-2015-12-07-fetch
Using rust registry from /nix/store/10xg2m3cqg68rdx9g4ms5gq5rbyxxj92-rustRegistry-2015-11-01-a0534d1
    Updating registry `file:///nix/store/10xg2m3cqg68rdx9g4ms5gq5rbyxxj92-rustRegistry-2015-11-01-a0534d1`
no matching package named `capnp` found (required by `capnpc`)
location searched: registry file:///nix/store/10xg2m3cqg68rdx9g4ms5gq5rbyxxj92-rustRegistry-2015-11-01-a0534d1
version required: = 0.5.3
versions found: 0.5.0, 0.4.4, 0.4.3, ...
/nix/store/h84kc62s87mknjrln5rd6s332zfxfrk5-stdenv/setup: line 124: showBuildStats: unbound variable
builder for ‘/nix/store/irh1bzs62nl1945r2s0qhincqxxy0v0n-capnpc-rust-2015-12-07-fetch.drv’ failed with exit code 101
cannot build derivation ‘/nix/store/qb82bk1afwk4nw246b8al9wqz8960gjm-capnpc-rust-2015-12-07.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/qb82bk1afwk4nw246b8al9wqz8960gjm-capnpc-rust-2015-12-07.drv’ failed

If the registry is bumped why does it print this line: Using rust registry from /nix/store/10xg2m3cqg68rdx9g4ms5gq5rbyxxj92-rustRegistry-2015-11-01...?

I managed to create a buildRustPackage against an executable (sokoban-rs) which has a Cargo.lock, but it would seem anything that is a rust library doesn't build and thus cannot be packaged due to the above error. Is this expected behaviour?

Okay we've run smack into @unjordy second use case. The idea is we'll have many rust implemented Flow-based Programming C ABI compatible dynamic libs, they will be composed together at runtime to form a graph of components forming an application (or subnet). The FBP virtual machine (fvm) is the executable and it'll dynamically include all of these dependencies. We'd like to get these C ABI components by whatever means, most likely it'll be a Named Data Network. Hence it would be superb if we could write buildRustPackage expressions to package up these fbp components. The second instance of this class of error we're experiencing is capnpc-rust which is a C ABI library that plugs into capnp. This generates a rust src file from https://capnproto.org/language.html files. What needs to be done to get buildRustPackage to support packaging rust libraries?

@sjmackenzie In the case of Rust libraries that need to be a build product by themselves, because they expose a C-compatible ABI and are meant to be used by a non-Rust program, this currently presents a bit of a problem because Cargo recommends not to include a Cargo.lock, but we need it in order to provide a reproducible build.
My suggestion is that you create a Cargo.lock file yourself, add it to the same directory as the Nix file containing your buildRustPackage expression, and then include something like this in your buildRustPackage derivation:
  buildRustPackage {
#   (...)
    postPatch = "cp ${./Cargo.lock} $sourceRoot/";
#   (...)
  }

Please note that I haven't tested this so I might have made a mistake.
Also, a few more details: note that the above won't work if you put the cp command in the prePatch hook because buildRustPackage overrides it for other purposes. You could use instead the patchPhase hook, but I don't recommend it because if you later add a patch to the patches attribute, it won't do anything (because you've overriden the patchPhase).

Thanks!
Given that every component is a library would it not be safe just to do this:
https://github.com/sjmackenzie/components/commit/9a57471d679f9cb670d4d5b85055d559c3e24627
(Basically I've copied out the Rust specific stuff into a separate repo so that we can quickly bump the rustRegistry if we need to. (and do things like the above commit))

@sjmackenzie No, because then if you update rustRegistry, then most Rust packages that don't have Cargo.lock will likely break because depsSha256 will likely have changed (because cargo fetch might have downloaded an updated version of a library dependency).

Cheers! Understood. I'll look into your solution. Appreciated.

Also it would seem if there are no [dependencies] in the Cargo.toml file the script falls over.


fix #10031, separate configurators, routers notification from address notification.

#10031

Codecov Report

Merging #10161 (c3ab07d) into 3.0 (64a96c5) will decrease coverage by 0.04%.
The diff coverage is 78.26%.

@@             Coverage Diff              @@
##                3.0   #10161      +/-   ##
============================================
- Coverage     65.68%   65.63%   -0.05%
- Complexity      297      319      +22
============================================
  Files          1224     1224
  Lines         53325    53331       +6
  Branches       8062     8064       +2
============================================
- Hits          35025    35006      -19
- Misses        14480    14498      +18
- Partials       3820     3827       +7

Impacted Files
Coverage Δ

...va/org/apache/dubbo/registry/RegistryNotifier.java
79.48% <ø> (-2.57%)
:arrow_down:

...he/dubbo/registry/zookeeper/ZookeeperRegistry.java
65.31% <78.26%> (+0.04%)
:arrow_up:

...nt/metadata/ServiceInstanceHostPortCustomizer.java
65.78% <0.00%> (-21.06%)
:arrow_down:

...che/dubbo/registry/client/NopServiceDiscovery.java
44.44% <0.00%> (-11.12%)
:arrow_down:

.../common/threadpool/serial/SerializingExecutor.java
70.37% <0.00%> (-7.41%)
:arrow_down:

...he/dubbo/remoting/transport/netty/NettyServer.java
70.17% <0.00%> (-3.51%)
:arrow_down:

...ubbo/registry/client/AbstractServiceDiscovery.java
85.12% <0.00%> (-1.66%)
:arrow_down:

...ng/zookeeper/curator5/Curator5ZookeeperClient.java
69.56% <0.00%> (-0.97%)
:arrow_down:

...dubbo/remoting/exchange/support/DefaultFuture.java
87.17% <0.00%> (-0.86%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a96c5...c3ab07d. Read the comment docs.


lomiri.morph-browser: init at 1.1.0

Description of changes
Working towards #99090.
Morph Browser is the Lomiri web browser. Last time I checked, neither Firefox nor Chrome work under Lomiri (Wayland), so this might be necessary for everyday use.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Works as-is, but I'll submit patches to upstream to improve some things for our needs.

Mostly done, but:

Patching-out always-enabled tests could be submitted upstream, but submissions relating to opting out of tests are stalled until upstream decides on how to approach it w/r/t naming the CMake option.
I want to test the fix to X-Lomiri-Splash-Image first before undrafting (only speculative, based on staring at code).

For getting proper graphics in testing (normally Lomiri / its NixOS module would set this up):
env UITK_ICON_THEME=suru XDG_DATA_DIRS="$(nix-build --no-out-link . -A lomiri.suru-icon-theme)"/share:$XDG_DATA_DIRS "$(nix-build --no-out-link . -A lomiri.morph-browser)"/bin/morph-browser

I also have a VM subtest that I wrote for it as part of my Lomiri shell VM test. Not sure if it would make sense to pull that out & into a separate Morph Browser test on another DE, or if doing that as part of one big Lomiri test & adding that to Morph's passthru.tests would be good enough.
    with subtest("morph browser works"):
        machine.send_key("meta_l-a") # app drawer
        machine.wait_for_text("Morph") # morph-browser should be listed
        machine.send_chars("Morph\n") # launch it
        machine.wait_for_text("Bookmarks") # new page has bookmarks section
        maximise_new_window(machine)
        machine.sleep(1) # VM is sluggish
        machine.screenshot("morph_open")

        # Try to display Valgrind documentation
        machine.send_chars("file://${pkgs.valgrind.doc}/share/doc/valgrind/html/index.html\n")
        machine.wait_for_text("Valgrind")
        machine.screenshot("morph_htmlcontent")

        machine.send_key("alt-f4")

Ping @SuperSandro2000, anything else?

I'm getting a timeout on the nixosTest when merged onto master

Seems to be an issue with the latest imagemagick bump (https://github.com/NixOS/nixpkgs/pull/288208), bisected within the nixpkgs-review shell.
git bisect start
# Status: warte auf guten und schlechten Commit
# bad: [6c8d5bb7169c8bad0a5c203279524df1e7c673e6] morph-browser
git bisect bad 6c8d5bb7169c8bad0a5c203279524df1e7c673e6
# Status: warte auf gute(n) Commit(s), schlechter Commit bekannt
# good: [fbe2d5c2852179db37f7a6af92052309fad7b5ea] Merge pull request #285120 from OPNA2608/fix/lomiri-ui-toolkit-versioned-QML_IMPORTS_PATH
git bisect good fbe2d5c2852179db37f7a6af92052309fad7b5ea
# good: [e9b728e4fdbd2efee1eebad2e6e591b253e7b2f8] Merge pull request #284580 from D3vil0p3r/patch-5
git bisect good e9b728e4fdbd2efee1eebad2e6e591b253e7b2f8
# bad: [60abd7c1f985d0679675ec860024e7fa16f229ee] Merge pull request #288138 from ambroisie/tandoor-recipes-manage-script
git bisect bad 60abd7c1f985d0679675ec860024e7fa16f229ee
# bad: [db19b2874696e9d0adbd0078735831eab7b51c01] Merge pull request #285249 from GaetanLepage/torch
git bisect bad db19b2874696e9d0adbd0078735831eab7b51c01
# good: [b8a84834b23cc1edd649e9921bf7d5f5d9b4118d] Merge pull request #287766 from bobby285271/upd/gnome
git bisect good b8a84834b23cc1edd649e9921bf7d5f5d9b4118d
# good: [f7152e2e18a80a61e507c4be485ca1289dc8cffd] Merge pull request #287924 from wegank/msolve-bump
git bisect good f7152e2e18a80a61e507c4be485ca1289dc8cffd
# good: [113bb026d5d3d873a2c52787e26af10ebb5f30b0] Merge pull request #286850 from khaneliman/sketchybar
git bisect good 113bb026d5d3d873a2c52787e26af10ebb5f30b0
# bad: [88e66deef19b2b920a4bae96a9a7cb5f4eafb9a9] Merge pull request #287572 from trofi/invoiceplane-fix-hash
git bisect bad 88e66deef19b2b920a4bae96a9a7cb5f4eafb9a9
# bad: [a9ec8d4aa34ad005597cf8e67018c1112c0926e7] Merge pull request #287862 from D3vil0p3r/patch-12
git bisect bad a9ec8d4aa34ad005597cf8e67018c1112c0926e7
# good: [b54cebbc14d59a8768a878ccd0e0f0deaff099da] Merge pull request #286580 from SuperSamus/wine-update
git bisect good b54cebbc14d59a8768a878ccd0e0f0deaff099da
# bad: [36ab9337c0f92b09ce06146b2fd4f3b061780b77] Merge pull request #288208 from r-ryantm/auto-update/imagemagick
git bisect bad 36ab9337c0f92b09ce06146b2fd4f3b061780b77
# good: [2e26817d1275a81fed48318e4b26eb0739f0340c] Merge pull request #284707 from ocfox/tide
git bisect good 2e26817d1275a81fed48318e4b26eb0739f0340c
# good: [e03ad4b2f916504bcedeff945486d119ff71c2ea] Merge pull request #288213 from dotlambda/stem-1.8.3
git bisect good e03ad4b2f916504bcedeff945486d119ff71c2ea
# bad: [6a79a442b49967fd8ccae8eeb9f03a066d74eac4] imagemagick: 7.1.1-27 -> 7.1.1-28
git bisect bad 6a79a442b49967fd8ccae8eeb9f03a066d74eac4
# first bad commit: [6a79a442b49967fd8ccae8eeb9f03a066d74eac4] imagemagick: 7.1.1-27 -> 7.1.1-28

I can confirm via reverting some commits that https://github.com/NixOS/nixpkgs/pull/289264 had to disable some of its OCR tests due to degraded text recognition with this new version, and that their old tests work fine on the previous version. I'll also adjust the OCR part of the tests here.
(Not sure if this is worth escalating to an issue, prolly just a part of dealing with the OCR's moodiness. Just wanted to mention the path I took for figuring this out.)

Times out on ARM, argh.
(finished: subtest: morph browser launches, in 33.29 seconds)
[...]
(finished: subtest: morph browser displays HTML, in 47.96 seconds)
[...]
subtest: morph browser localisation works
machine: waiting for Neuer Tab to appear on screen
[...]
error: building of '/nix/store/1fr4cryykf8wyrh3zbvl3zxfjf1cwl5x-vm-test-run-morph-browser-standalone.drv^out' from .drv file timed out after 3600 seconds

Will try to find some clearer text to OCR for…

I added various UI strings to look for, I hope it's more reliable now.


Personal Email and Calendar Web Parts: Getting "Additional credentials are required to show this page correctly" message, and does not show

Category

[ ] Question
[X] Bug
[ ] Enhancement

Expected or Desired Behavior
Expecting the web parts to show personal mail or events without prompting for additional credentials.
Observed Behavior
When adding the Personal Mail or Personal Events web parts a message pops up that says "Additional credentials are required to show this page correctly." When I click "OK" I am prompted for a login. When attempting the additional login, I am getting an error.
"Sorry, but we’re having trouble signing you in.
AADSTS50011: The reply url specified in the request does not match the reply urls configured for the application: 'c58637bb-e2e1-4312-8a00-04b5ffcd3403'. "
and also a message:
Request Id: 4b9e1a6f-7577-4f11-9dd1-5806903f1f00
Correlation Id: 2d0969be-7b36-4147-a749-d8f1dc2d6353
Timestamp: 2018-06-27T15:44:48Z
Message: AADSTS50011: The reply url specified in the request does not match the reply urls configured for the application: 'c58637bb-e2e1-4312-8a00-04b5ffcd3403'.
Advanced diagnostics: Enable
If you plan on getting support for an issue, turn this on and try to reproduce the error. This will collect additional information that will help troubleshoot the issue.
Steps to Reproduce
Add the Personal Email or Personal Calendar web parts to a Modern Page.

Those webparts are using the new SPFx Graph client. The url's should be provided by SP for us. First thoughts, have you approved the API requests that are required after the sppkg solution has been deployed? That is found in API management in the SPO Preview Admin Center.

Closing - Answer and Feedback has been provided.


Quickstart tutorial no longer works (loaddataset doesn't exist)

Hi, this code from https://fluxml.ai/FastAI.jl/dev/documents/notebooks/quickstart.ipynb fails with the latest FastAI.jl release:
using FastAI
data, blocks = loaddataset("imagenette2-320", (Image, Label))
task = ImageClassificationSingle(blocks, size=(256, 256))
learner = tasklearner(task, data, callbacks=[ToGPU(), Metrics(accuracy)])
fitonecycle!(learner, 5, 0.033)

with UndefVarError: loadddataset not defined.
If I replace the 2nd line with data, blocks = load(datarecipes()["imagenette2-320"]) (from an earlier page in the docs), it works.

Hi Christian, thanks for reporting this!
I think there’s been an issue with the documentation build, as this should be fixed in the docs source on master (see https://github.com/FluxML/FastAI.jl/blob/master/docs/notebooks/quickstart.ipynb).
I’ll leave this open until I get around to releasing 0.5 and  subpackages which will be breaking (#240).

Ok, in the meantime I tried to ] dev FastAI with the latest Master branch, but I can't even get using FastVision to work... i.e. the notebook you linked to doesn't work for me. I'm not familiar with subpackages... is there something special I need to do, to add FastVision and other subpackages, before you officially register them?

BTW it would be great if there was an easy way to read the previous FastAI.jl documentation... right now it only points to the dev version, instead of the latest version that you registered... (... that presumably is more tested/stable?)
Sorry to bother you during your vacations, I'm just a bit disappointed I'll have to revert to just using Lux or Flux without your neat high-level libraries. ;-)

Nevermind! This older code works with FastAI.jl v0.4.3:
# Adapted from https://fluxml.ai/FastAI.jl/dev/documents%2Fnotebooks%2Fquickstart.ipynb
using FastAI
using Metalhead

import CairoMakie
CairoMakie.activate!(type="png")

data, blocks = loaddataset("imagenette2-320", (Image, Label))

image,class = sample = getobs(data, 1000)
@show class
image

task = ImageClassificationSingle(blocks, size=(256,256)) # task = ImageClassificationSingle(blocks, size=(256, 256))
learner = tasklearner(task, data, callbacks=[ToGPU(), Metrics(accuracy)], backbone=ResNet(34).layers[1:end-1])
fitonecycle!(learner, 10)
showoutputs(task, learner)

Thanks!

Sorry about this! I didn't want to make a big release right before my absence and me adding versioning support to Pollen.jl is still WIP which created this confusing situation where only the dev docs are shown. I'll leave this open until proper versioning of the documentation is added. Thanks for bearing with that!

FastAI.jl 0.5 and the subpackages have been released now, along with up-to-date documentation, so I am closing this. Let me know if something is still not working!


Add check for appendMiddlewareToGroup() method when registering middleware

Closes #151
Prior to Laravel v6.9.0, the appendMiddlewareToGroup() method did not exist, which is causing an exception to be thrown when Inertia tries to register its middleware. This was caused by a recent change to how the Inertia middleware is registered, to fix an issue with session reflashing (see #147).
This PR adds a check for the existence of the appendMiddlewareToGroup() method when registering middleware. If it doesn't exist (Laravel versions prior to v6.9.0), Inertia will simply not register it's middleware, and this will have to be done manually in the app/Http/Kernel.php:
protected $middlewareGroups = [
    'web' => [
        \App\Http\Middleware\EncryptCookies::class,
        \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
        \Illuminate\Session\Middleware\StartSession::class,
        // \Illuminate\Session\Middleware\AuthenticateSession::class,
        \Illuminate\View\Middleware\ShareErrorsFromSession::class,
        \App\Http\Middleware\VerifyCsrfToken::class,
        \Illuminate\Routing\Middleware\SubstituteBindings::class,
+       \Inertia\Middleware::class,
    ],

    'api' => [
        'throttle:api',
        \Illuminate\Routing\Middleware\SubstituteBindings::class,
    ],
];

Update:: @claudiodekker found a way to automatically register the middleware on Laravel 5.4+ as well (#153). 🙌

Thanks for the quick fix @reinink :)

muchas gracias por la solucion

FWIW, anyone landing on this is PR, please be aware that we have since removed the automatic middleware registration in v0.3.0. Learn more about that here: https://github.com/inertiajs/inertia-laravel/releases/tag/v0.3.0


Revert "Revert "Benchmark performance (#913)" (#1075)"

Closes #
Introduced changes

Checklist

[ ] Linked relevant issue
[ ] Updated relevant documentation
[ ] Added relevant tests
[ ] Performed self-review of the code
[ ] Added changes to CHANGELOG.md

I will review this more thoroughly later today. Would greatly appreciate it if this wasn't a part of todays release, as this looks like a can of worms.

Don't we want to rename forge -> snforge too now?
by piotmag769

I second that

Can we run smoke tests on a build from the branch? (we should probably consider if it doesn't affect anything in the release process)

Locally running smoke tests seems to be working. But I'll try running a release from our repo fork to see if it works correctly.

@Arcticae releases seem to be working with these changes https://github.com/cptartur/starknet-foundry/actions/runs/7129508207

Let's also check github/CI files, as I think codeowners won't work atm

looks good, after the issue raised here #1296 (comment) is resolved.
if we go down the name changing route, we should probably also change naming in CHANGELOG.md, bug_report template, feature_request template, ci workflow and docs. Not sure about existing design docs, probably does not make much difference.

Discussed offline, for now, we want to rename crates to have sn prefix and leave names without prefix in docs etc. Can be changed if this turns out to cause confusion.


Invalid arguments. Must be a DOM element or a collection of DOM elements

The following error keeps appearing when I run jest snapshot testing. It is non-blocking though.

console.error node_modules/element-resize-detector/src/reporter.js:28 Invalid arguments. Must be a DOM element or a collection of DOM elements

System:
Environment Info:
  System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
  Binaries:
    Node: 12.16.1 - ~/.meteor/packages/meteor-tool/.<IP_ADDRESS>yx87b.7o9xg++os.osx.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.osx.x86_64/dev_bundle/bin/node
    Yarn: 1.22.4 - ~/.meteor/packages/meteor-tool/.<IP_ADDRESS>yx87b.7o9xg++os.osx.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.osx.x86_64/dev_bundle/bin/yarn
    npm: 6.14.0 - ~/.meteor/packages/meteor-tool/.<IP_ADDRESS>yx87b.7o9xg++os.osx.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.osx.x86_64/dev_bundle/bin/npm
  Browsers:
    Chrome: 81.0.4044.138
    Firefox: 75.0
    Safari: 12.1.2
  npmPackages:
    @storybook/addon-actions: ^5.3.18 => 5.3.18
    @storybook/addon-centered: ^5.3.18 => 5.3.18
    @storybook/addon-links: ^5.3.18 => 5.3.18
    @storybook/addon-storyshots: ^5.3.18 => 5.3.18
    @storybook/addon-storysource: ^5.3.18 => 5.3.18
    @storybook/addons: ^5.3.18 => 5.3.18
    @storybook/react: ^5.3.18 => 5.3.18
    @storybook/react-komposer: ^2.0.5 => 2.0.5

Can you provide a jsbin or similar with this case?

No, I can not, the code is work-related. Basically the error appears in the console when I permform a snapshot with jest, no stack trace available :( just this console.error.
What does this error would mean? My component is a react-virtualized table and one of its cells has a react-sizeme component.

Any ideas on how this can happen?

Well, somehow the given element(s) are not valid DOM elements. Can't really tell how this is happening, but I assume it's something in your setup as this is working for several other projects. I'll need a minimal reproducible example to investigate it further. Can you provide such example?


Render articles with HTML language matching feed language, if present

This would render articles with the correct default font (and directionality?) for each language, which is especially important for CJK because characters unified to the same Unicode code point are written differently depending on the language.

Do you have some example feeds I can use for testing?

Yeah, here are some marked up with RSS <language>:
https://www.nippon.com/ar/feed/
https://www.nippon.com/en/feed/
https://www.nippon.com/ja/feed/


Automated Package Upgrade

:tada: This PR is included in version 2.0.51 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Move Scheduler class inside SidekiqScheduler module

Also move sidekiq extensions to separate files

Coverage increased (+0.01%) to 97.818% when pulling 4d32bc8f50e532aa789f2a7a729d210f3d6c39cc on mconiglio:refactor-scheduler into d4aee02a18f7d442d8777fdede8618ef34e59cfe on moove-it:master.

Coverage increased (+0.01%) to 97.818% when pulling 1c434b5d74d56b388f2d9457cceb9c941d602ee6 on mconiglio:refactor-scheduler into d4aee02a18f7d442d8777fdede8618ef34e59cfe on moove-it:master.

Coverage increased (+0.01%) to 97.821% when pulling a48213f628266d8b36cc17b786c55a166b01c0c1 on mconiglio:refactor-scheduler into d4aee02a18f7d442d8777fdede8618ef34e59cfe on moove-it:master.


Terra Grid should expect column

Feature Request
terra-grid component currently only support direction 'row'.
Description
how to add direction="column" to the Grid.Row ?
Additional Context / Screenshots
https://next.material-ui.com/api/grid/
material-ui has direction prop to change direction of 'flex' grid.

@kapilpipaliya After reviewing material-ui's grid component, the APIs and approaches aren't really the same between the two components.  Material uses a simple Container > Item structure with their API, and all the layout details are prop driven (row, row-reverse, column, column-reverse) and very much follows flexbox styling options, where the container width on the row style, or container height on the column style is what drives the wrapping to next row/column.
Terra-grid's API however is much more formal in constructing a Grid > Row > Column > Item/Children with unique subcomponents. If needing to create a primarily vertical grid, it can be accomplished by simply putting more items vertically stacked within each column. Or Terra also offers the Terra-Dynamic-Grid based off the principles of CSS Grid.
@kapilpipaliya - how do you propose enhancing Terra-Grid to accomplish similarity with Material UI?

Thank you very much for your input.
I have no specific requirements for direction="column". I was working on material ui. i found it very customizable. so i just give suggestion here.
I very much like terra components. Thank you very much for such a great components.


[iOS] When app is in background "opened" callback does not fire

Description:
When the app is in background mode, and the user taps on an incoming notification, the opened callback is not firing.
When the app is in focus, and we have OneSignal.inFocusDisplaying(2) set, the notification shows and if the user taps it, nothing happens. received callback is fired though.
On Android, in both cases when I tap the notification, the opened callback is firing without any issues.
Is this the expected behaviour? What I want to happen is - when the notification is displayed (app is in background) and the user taps it, the app should be opened and the opened callback should be fired so that I can navigate the user to a screen (using a deeplink sent with additionalData).
Environment
OneSignal RN SDK - 3.2.6
RN - 0.55.4
iOS - 11.2.6
AppDelegate.m - https://gist.github.com/steverob/25c969ded98dce44ca168309d67a103f
I followed the setup instructions detailed in the documentation and also added the Notification Service Extension.

I have the same issue, but it is happens on Android.
When the app is in background mode, and the user taps on an incoming notification, the opened callback is not firing and the there is no additionalData in received callback.
I test it in Android simulator 8.0.0 and physical device 8.1.0.
Any one has the same issue even in Android or IOS ?
Environment
"react": "16.3.1",
"react-native": "~0.55.2",
"react-native-onesignal": "^3.2.6"

Yeah I can confirm I can see this occasionally on android as well.
--
Regards
Steve Robinson

On 30-Aug-2018, at 3:58 PM, motogod<EMAIL_ADDRESS>wrote:
I have the same issue, but it is happens on Android.
When the app is in background mode, and the user taps on an incoming notification, the opened callback is not firing and the there is no additionalData in received callback.
I test it in Android simulator 8.0.0 and physical device 8.1.0.
Any one has the same issue even in Android or IOS ?
Environment
"react": "16.3.1",
"react-native": "~0.55.2",
"react-native-onesignal": "^3.2.6"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@steverob Apologies for the delayed response, can you reproduce this issue in our example project? If so - can you please upload it to dropbox and post a link?

Closing due to no response - if you're still running into this problem please feel free to respond and I'll be happy to reopen and help investigate

Yes this still happens.
--
Regards
Steve Robinson

On 12-Sep-2018, at 6:10 AM, Brad Hesse<EMAIL_ADDRESS>wrote:
Closed #613.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@steverob since I cannot reproduce this issue, can you attempt to reproduce it in our demo project?
90% of the time when a user reports this problem it usually turns out to be user error, so it would be good to make sure you can reproduce it in our demo project. If you can, it would be very helpful to share a Dropbox link

It still happens, especially on iOS background service.


Remove application_id insertion

Purpose
APPLICATION_ID column will be removed from the IDN_ORG_USER_INVITE_ROLE_ASSIGNMENT table as the ROLE_ID will be unique to the organisations.
This PR contains the changes to remove the insertion to the corresponding column to that table  IDN_ORG_USER_INVITE_ROLE_ASSIGNMENT.
Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Tests failing due to https://github.com/wso2-extensions/identity-organization-management/blob/63ca11398dc9c66782f09dff9bde7f2accd10514/components/org.wso2.carbon.identity.organization.user.invitation.management/src/test/resources/dbscripts/h2.sql#L20


Fix version dropdown behavior

Description
This PR fixes the bad behavior of the versions dropdown on the website. It will remember what API document you were viewing when you switch versions. It even remembers which anchor/bookmark you're on.
Preview
You can play with it here: http://<IP_ADDRESS>/
This is how it works on the site now. You're in deep on some doc page, and then think, "I wonder if the params are different in the last release...". You click the versions dropdown, select 1.3.0, and then bam, you're taken to the 1.3.0 home page.

This is so annoying. Now you have to go and search for that page again.
With this PR, changing versions does what you'd expect it to do!

If you pick a doc that didn't exist in a previous version, you get a 404 error.

Thanks for your contribution @aaronmarkham
It's so sweet that you even made videos.
@mxnet-label-bot[pr-awaiting-review]

This is super important ux improvement, thanks for following it up and fixing it.


AUTOGPT.PY

Dont understand where is supposed to do outputs.
data folder empty after running for 30 minutes with a simpel task
tested with python 3.9 3.10

For the moment we are using a virtual folder. We have removed the ability to write files directly to the machine. If you want you can enable it yourself.

How would one go about enabling it?

For the moment we are using a virtual folder. We have removed the ability to write files directly to the machine. If you want you can enable it yourself.

Do you have an idea of how I could enable it? I've been messing around with it and I can't get it to use the WriteFileTool()


Force FN Button to Stay On (FN Lock)

Description of the new feature / enhancement
Honestly, it's a little ironic that I even have to request this here, as the device I need the functionality for is a Microsoft Surface Laptop Studio. Yet, here we are. :D
Anywho - I'd imagine this should/could be very simple...add some keyboard shortcut to allow proper toggle/locking of the "Fn" key on the keyboard, so it behaves like a Dell computer, in that it's just ALWAYS on unless you specifically press FN+something to turn it off and on.
Scenario when this would be used?
Sanity. Pure and utter sanity. I just want the damned fn  button to stay on. Not stay on until I close my laptop, then turn off, or randomly toggle on/off when I RDP into another computer. I want to know that when I press F5, the webpage will reload - not that some random tab with a YouTube video will start playing because I pressed the fn key at the wrong time earlier and now it's off.
Supporting information
https://www.reddit.com/r/Surface/comments/q29jl2/sls_possible_to_make_fn_key_not_toggle/
#30577

Love the idea, sadly, not possible for PowerToys to do :(


Cannot comment on a bitbucket pull request

Hi,
I am not sure if I am making a mistake but I cannot seem to get CDK-Notifier to work on bitbucket.
I wrote the following bitbucket-pipeline.yaml file:
I keep getting the following error for the last line of the pipeline:
time="2023-07-28T00:22:31Z" level=warning msg="could not parse response to *provider.BitbucketComments"
time="2023-07-28T00:22:31Z" level=fatal msg="BitBucket API Error: 401 Unauthorized "
pipelines:
pull-requests:
'**':
- step:
name: Install and use CDK Notifier
image: node:16
script:
- echo "BITBUCKET_REPO_OWNER is $BITBUCKET_REPO_OWNER"
- echo "BITBUCKET_REPO_SLUG is $BITBUCKET_REPO_SLUG"
- echo "BITBUCKET_TOKEN is $BITBUCKET_TOKEN"
- echo "BITBUCKET_PR_ID is $BITBUCKET_PR_ID"
- echo "BITBUCKET_USERNAME is $BITBUCKET_USERNAME"
        # Ensure npm is updated and typescript installed
        - npm install -g npm
        - npm install -g typescript
        # Install AWS CDK globally
        - npm install -g aws-cdk
        # Install project dependencies
        - npm install
        # Compile TypeScript
        - tsc

        - apt-get update && apt-get install -y curl gzip jq
        - curl -L "https://github.com/karlderkaefer/cdk-notifier/releases/latest/download/cdk-notifier_$(uname)_amd64.gz" -o cdk-notifier.gz
        - gunzip cdk-notifier.gz && chmod +x cdk-notifier
        - mv cdk-notifier /usr/local/bin/cdk-notifier

        - cdk diff --progress=events | tee cdk.log
        - ls -al
        - cat cdk.log

        - cdk-notifier --owner $BITBUCKET_REPO_OWNER --repo $BITBUCKET_REPO_SLUG --token $BITBUCKET_TOKEN --log-file ./cdk.log --tag-id my-stack --pull-request-id 20 --vcs bitbucket --ci bitbucket

I echoed out all my variables and they were correctly set.
I installed all the required packages and installed CDK-Notifier.
I ran the cdk diff --progress=events | tee cdk.log
I ran ls -al and could see that the log file was at ./cdk.log and have data written to it.
I added this line at the end to test if I could comment on a pull request with my token using the following command in my pipeline and the pipeline successfully uploaded a comment.
#Post the comment to Bitbucket
- |
url="https://api.bitbucket.org/2.0/repositories/$BITBUCKET_REPO_OWNER/$BITBUCKET_REPO_SLUG/pullrequests/$BITBUCKET_PR_ID/comments"
test_message="This is a test message"
data='{"content": {"raw": "'"$test_message"'"}}'
curl -X POST -H "Authorization: Bearer $BITBUCKET_TOKEN" -H "Content-Type: application/json" -d "$data" "$url"
I am not sure what I am doing wrong or if it's an issue. If this is not the right place to post this I am sorry.

It's absolutely ok to post it here, no worries. I will have a look this weekend. Thanks for detailed report that does help

@stefansson30952 I can confirm the issue I got the same. It's probably caused by an API change on bitbucket server. I'm investigating

Post the comment to Bitbucket
        - |
          url="https://api.bitbucket.org/2.0/repositories/$BITBUCKET_REPO_OWNER/$BITBUCKET_REPO_SLUG/pullrequests/$BITBUCKET_PR_ID/comments"
          log_content=$(< cdk.log)
          data=$(jq -n --arg log_content "$log_content" '{content: {raw: $log_content}}')
          curl -X POST -H "Authorization: Bearer $BITBUCKET_TOKEN" -H "Content-Type: application/json" -d "$data" "$url"

I was able to post a comment to bitbucket with this but the formatting was awful.

@stefansson30952 the username of token required see
cdk-notifier --help | grep user
  -u, --user string              Optional set username for token (required for bitbucket)

I added missing documentation. That should solve your issue

@stefansson30952 I have added an example bitbucket pipeline for you. The comment was successfully created. Note I have added the added the environment variable BITBUCKET_TOKEN as repository variable. You don't need to add owner, repo or pr id since they are read in from bitbucket pipeline

@karlderkaefer
Thank you for all your help.
I got it to work. I was using a repository token instead of a personal token.
Thanks!

:tada: This issue has been resolved in version 2.5.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Error] Downloading stash for Talisman

[Error] Downloading stash for Talisman, details logged to DebugInfo.log, please open a ticket at https://github.com/Stickymaddness/Procurement/issues

You need to include your debuginfo.log


New Plugin

I would like to add my new plugin to the Grav Repository.
Here are the project details: muuvmuuv/grav-plugin-adsense

Just for consistency across plugins, do you mind changing the language strings to PLUGIN_ADSENSE.* instead of PLUGINS.ADSENSE.* ?
E.g. like
https://github.com/getgrav/grav-plugin-login/blob/develop/languages.yaml
https://github.com/getgrav/grav-plugin-form/blob/develop/languages.yaml

This plugin needs a release before it will be available in GPM.

@flaviocopes okey I did that and updated the repo
@rhukster Its my first time using Github so how can I do that ? It was a long way until here :dancers:

Ok, it's showing up in the repo now. You should be good to go!


I found a hit detection bug with WebglPointsLayer

Describe the bug
I have a WebglPointsLayer, which clears its source and inserts 10,000 features every 2 seconds. I observed that the forEachFeatureAtPixel method hit detection works fine at the beginning, but problems occur after running for a while. When the mouse selects a feature, the hit is not the feature I selected.
I noticed that at this point, the ol_uid of each newly added feature reaches 8 digits in length. The forEachFeatureAtCoordinate method of WebGLPoints has code related to ol_uid. I suspect that this phenomenon might be related to ol_uid. Of course this is just my guess, I hope someone can answer my question.
To Reproduce
Steps to reproduce the behavior:

Create a WebglPointsLayer
Every 2 scondes, clear its source and inserts 10,000 features.
See error

Expected behavior
Hit detection works fine.

Feature's ol_uid values are stored and read in a Float32Array. This can indeed lead to some precision issues when reaching integers in the range of 10,000,000. After how long does the problem typically appear?

Feature's values are stored and read in a Float32Array. This can indeed lead to some precision issues when reaching integers in the range of 10,000,000. After how long does the problem typically appear?ol_uid

@jahow Sorry, I just realized that I wrote the wrong number of features. When inserting 100,000 features every 2 seconds, this situation would occur within a few minutes. I found that by this time, the ol_uid had already exceeded 10,000,000.

Ok, then it makes sense. Do you think you could reuse Features instead of recreating new ones? Especially if they're points, you might simply be able to update their coordinates.
We could also store the rendering instructions in Float64 instead (which also contains ol_uid), but the impact of this has to be evaluated.

Thanks for your answer. I will give it a try. By the way, I guess #14277 may also be due to this issue.


BUILD_DOCUMENTATION version [6502]

Download the current PROJECT_VERSION tag of the documentation instead of latest.

Aborted the tests, as this change doesn't have any effect.


CLI not operational after deleting account on another device

When deleting an account with multiple devices attached, the CLI on other devices is no longer functional and returns ERROR User deleted, this is somewhat expected.
Running keybase login returns the same message though, as does keybase account delete and keybase logout.
The latter two should delete any profile provisioning on the client to allow for new accounts to be added.
Admittedly this is more of an edge case, but I imagine there are enough people out there who have changed their handle and would like keybase to match.

This also seems to affect signing in to the new account on the Keybase desktop application.