bump: tag and release version v1.1.0

Release
This would mean tagging 99ca669edf9e171a912278166323b4c82f3d9706 as v1.1.0 to release.
Vote
We need at least 4 approvals from 6 maintainers to release notation v1.1.0.

[x] Junjie Gao (@JeyJeyGao)
[ ] Milind Gokarn (@gokarnm)
[x] Patrick Zheng (@Two-Hearts)
[x] Pritesh Bandi (@priteshbandi)
[ ] Rakesh Gariganti (@rgnote)
[ ] Shiwei Zhang (@shizhMSFT)

Changes
The code changes compared to v1.0.1 include:

feat: update notation cert list command output by @Two-Hearts in https://github.com/notaryproject/notation/pull/798
fix: Code scanning issues by @JeyJeyGao in https://github.com/notaryproject/notation/pull/799
fix: legacy docker config support by @JeyJeyGao in https://github.com/notaryproject/notation/pull/803
build(deps): Bump golang.org/x/net from 0.12.0 to 0.17.0 in /test/e2e by @dependabot in https://github.com/notaryproject/notation/pull/800
build(deps): Bump oras.land/oras-go/v2 from 2.2.1 to 2.3.0 by @dependabot in https://github.com/notaryproject/notation/pull/776
build(deps): Bump actions/checkout from 4.1.0 to 4.1.1 by @dependabot in https://github.com/notaryproject/notation/pull/805
docs: fix broken links by @suzuki-shunsuke in https://github.com/notaryproject/notation/pull/787
fix: improve error messages of notation CLI by @Two-Hearts in https://github.com/notaryproject/notation/pull/810
bump: update dependencies by @Two-Hearts in https://github.com/notaryproject/notation/pull/815
build(deps): Bump ossf/scorecard-action from 2.3.0 to 2.3.1 by @dependabot in https://github.com/notaryproject/notation/pull/814
build(deps): Bump github/codeql-action from 2.22.0 to 2.22.5 by @dependabot in https://github.com/notaryproject/notation/pull/813
bump: bump up dependencies including E2E tests by @Two-Hearts in https://github.com/notaryproject/notation/pull/818
fix: add "release-*" to workflows trigger events by @Two-Hearts in https://github.com/notaryproject/notation/pull/819
fix: fix the license check by @Two-Hearts in https://github.com/notaryproject/notation/pull/826
bump: bump up to go version 1.21 by @Two-Hearts in https://github.com/notaryproject/notation/pull/833
doc: update plugin spec by @FeynmanZhou in https://github.com/notaryproject/notation/pull/809
build(deps): Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 by @dependabot in https://github.com/notaryproject/notation/pull/823
build(deps): Bump github/codeql-action from 2.22.5 to 2.22.7 by @dependabot in https://github.com/notaryproject/notation/pull/835
Correct broken link to quick start guide by @rcrozean in https://github.com/notaryproject/notation/pull/831
chore: update tag to digest by @yizha1 in https://github.com/notaryproject/notation/pull/837
feat: add notation plugin uninstall command by @Two-Hearts in https://github.com/notaryproject/notation/pull/842
chore: update references with the tag version by @yizha1 in https://github.com/notaryproject/notation/pull/836
build(deps): Bump golang.org/x/term from 0.13.0 to 0.15.0 by @dependabot in https://github.com/notaryproject/notation/pull/843
build(deps): Bump actions/setup-go from 4.1.0 to 5.0.0 by @dependabot in https://github.com/notaryproject/notation/pull/845
build(deps): Bump github/codeql-action from 2.22.7 to 2.22.9 by @dependabot in https://github.com/notaryproject/notation/pull/846
build(deps): Bump golang.org/x/crypto from 0.15.0 to 0.17.0 by @dependabot in https://github.com/notaryproject/notation/pull/850
build(deps): Bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /test/e2e/plugin by @dependabot in https://github.com/notaryproject/notation/pull/849
build(deps): Bump github/codeql-action from 2.22.9 to 3.22.11 by @dependabot in https://github.com/notaryproject/notation/pull/847
build(deps): Bump actions/upload-artifact from 3.1.3 to 4.0.0 by @dependabot in https://github.com/notaryproject/notation/pull/848
feat: notation plugin install command by @Two-Hearts in https://github.com/notaryproject/notation/pull/827
feat: add notation config environment variable by @JeyJeyGao in https://github.com/notaryproject/notation/pull/821
fix: fix bug in SetHTTPDebugLog by @Two-Hearts in https://github.com/notaryproject/notation/pull/857
fix: notation plugin install error messages and tests by @Two-Hearts in https://github.com/notaryproject/notation/pull/855
build(deps): Bump github/codeql-action from 3.22.11 to 3.22.12 by @dependabot in https://github.com/notaryproject/notation/pull/854
Updated CODEOWNERS and MAINTAINERS files by @toddysm in https://github.com/notaryproject/notation/pull/862
build(deps): Bump golang.org/x/term from 0.15.0 to 0.16.0 by @dependabot in https://github.com/notaryproject/notation/pull/860
bump: bump up notation-go by @Two-Hearts in https://github.com/notaryproject/notation/pull/863
build(deps): Bump actions/cache from 3.3.2 to 3.3.3 by @dependabot in https://github.com/notaryproject/notation/pull/866
build(deps): Bump github/codeql-action from 3.22.12 to 3.23.0 by @dependabot in https://github.com/notaryproject/notation/pull/865
build(deps): Bump actions/upload-artifact from 4.0.0 to 4.1.0 by @dependabot in https://github.com/notaryproject/notation/pull/864
fix: improve error message for plugin by @JeyJeyGao in https://github.com/notaryproject/notation/pull/870
build(deps): Bump actions/upload-artifact from 4.1.0 to 4.2.0 by @dependabot in https://github.com/notaryproject/notation/pull/872
build(deps): Bump actions/cache from 3.3.3 to 4.0.0 by @dependabot in https://github.com/notaryproject/notation/pull/873
build(deps): Bump github/codeql-action from 3.23.0 to 3.23.1 by @dependabot in https://github.com/notaryproject/notation/pull/874
bump: bump up notation-go and notation-core-go including e2e tests by @Two-Hearts in https://github.com/notaryproject/notation/pull/875

Full Changelog: https://github.com/notaryproject/notation/compare/v1.0.1...99ca669edf9e171a912278166323b4c82f3d9706
Action Requested
Please respond LGTM (approve) or REJECT (request for changes).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (96d4f30) 64.93% compared to head (99ca669) 64.93%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #876   +/-   ##
=======================================
  Coverage   64.93%   64.93%
=======================================
  Files          45       45
  Lines        2729     2729
=======================================
  Hits         1772     1772
  Misses        795      795
  Partials      162      162

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Code change LGTM but the approval for tagging commit seems wrong; commit https://github.com/notaryproject/notation/commit/99ca669edf9e171a912278166323b4c82f3d9706 doesnt exists in the notation repo.

Code change LGTM but the approval for tagging commit seems wrong; commit 99ca669 doesnt exists in the notation repo. IMO for tagging the commit we should vote in separate issue after merging this PR

Thanks @priteshbandi. @shizhMSFT @yizha1 @FeynmanZhou Do you have any comments/questions regarding this?

Code change LGTM but the approval for tagging commit seems wrong; commit 99ca669 doesnt exists in the notation repo. IMO for tagging the commit we should vote in separate issue after merging this PR

@priteshbandi We updated the release checklist in another PR so voting on the release PR is enough in the new release process. It's much efficient to review the change logs and vote on the PR than an issue because maintainers no longer need to approve twice.

Code change LGTM but the approval for tagging commit seems wrong; commit 99ca669 doesnt exists in the notation repo. IMO for tagging the commit we should vote in separate issue after merging this PR

@priteshbandi We updated the release checklist and process in another PR so voting on the release PR is enough in the new release process.
It's much efficient to review the change logs and vote on the PR than an issue because maintainers no longer need to approve twice.

I appreciate the intention of reducing the work for maintainer but still the process is flawed because voters dont know what commit will be added in next release. I am fine for using our old process but we should look into this starting next release

LGTM


update ts defs (disablePageCaching)

@testcafe-build-bot retest

Everything is OK. We don't run Azure test if changes are only in the TS definitions:
https://github.com/DevExpress/testcafe/blob/master/azure-pipelines.yml#L9


ng lint, is linting node_modules files.

Please provide us with the following information:

OS?

Windows 10

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:
$ ng -v
@angular/cli: 1.0.0-rc.0
node: 7.5.0
os: win32 x64
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/core: 2.4.8
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.8
@angular/cli: 1.0.0-rc.0
@angular/compiler-cli: 2.4.8

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.
This app was updated from 32.3 to rc.0

The log given by the failure.

Normally this include a stack trace and some more information.
It running lint against node_module.

/node_modules/lru-ts/index.ts[231, 5]:
Mention any other details that might be useful.
this did not happen in 32.3

Thanks! We'll be in touch soon.

Hey @daBishMan, this is because the library you're using publishes .ts files as well as .js files. TSLint would do the same if you did tslint --source=tsconfig.app.json. Check out the CHANGELOG.md for how to ignore node_modules. This should be happening in beta.32.3. I'd be surprised if it wasn't.
https://github.com/angular/angular-cli/blob/master/CHANGELOG.md#breaking-changes-3
Discussed in https://github.com/angular/angular-cli/issues/4350, fixed in https://github.com/angular/angular-cli/pull/4437

Thank you so much for your quick reply.
I have included the following in .angular.cli.json based on my understanding.  I looked at https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/lib/config/schema.json
"lint": [     {       "project": "src/tsconfig.app.json",       "exclude": [         "../node_modules/**/*"       ]     },     {       "project": "src/tsconfig.spec.json"     },     {       "project": "e2e/tsconfig.e2e.json"     }   ],
this is how I excluded in .angular-cli.json, but it is still happening, am I missing something.

I misspoke when I suggested it was in the CHANGELOG.md, sorry. I was thinking of the first PR I did that changed how linting was done, not the update that had allowed exclude.
https://github.com/angular/angular-cli/issues/4350#issuecomment-277501678 discusses what needs to be done.
In short, this should fix your issue.
"lint": [
  {
    "project": "src/tsconfig.app.json",
    "exclude": "**/node_modules/**/*"
  },
  {
    "project": "src/tsconfig.spec.json",
    "exclude": "**/node_modules/**/*"
  },
  {
    "project": "e2e/tsconfig.e2e.json",
    "exclude": "**/node_modules/**/*"
  }
],

thank you so much again for your help.   This does fix my issue.
I am going to close this issue.

My config:
"lint": [
    {
      "files": "src/**/*.ts",
      "project": "src/tsconfig.json",
      "exclude": "**/node_modules/**/*"
    },
    {
      "files": "e2e/**/*.ts",
      "project": "e2e/tsconfig.json",
      "exclude": "**/node_modules/**/*"
    }
  ]

Still linting node_modules.
My version is 1.0.0-beta.28.3.


Added CLI migration support

This is a pretty significant enhancement, so it will take some time for me to go through this. I do appreciate your contribution... but for large new features like this, it would've been nice to be involved in a conversation about it first. Other users of dropwizard-cassandra have asked about this before and would probably have requirements to feed in too.
To help my research, please could you give me a bit of background on the choice for cassandra-migration. Why was it chosen? What alternatives were considered? etc.
Thanks

Hi. Yes, I understand, it sounds reasonable.
When I looked for core functionality for migration, I stuck myself with the following rules:

it should mimic FlyWay approach (as most popular and simple);
it should be Java for easy integration;
it should have CI and be published in Maven Central.
the more starts - the better.

After search and shallow review, I found 2 projects:

Contrast-Security-OSS/cassandra-migration
patka/cassandra-migration

1st project has a lot of implemented features - almost everything I wanted to have, plus lots of stars - but it has one big drawback: design is not ideal, it is impossible to use it as a library w/o changes.
2nd project has good design, but lack of useful features - like, e.g. Java migration scripts.
So, I put away both of them and continued search. Third library I found for research was builtamont-oss/cassandra-migration - this one was used finally.
It is a fork of 1st one, but fully re-written on Kotlin (not Java, but it is not important in this case). It fits ideally to my rules I mentioned above, it got rid of drawbacks of original library, well covered with tests, published in Maven, has Travis CI account - very close to requirements you follow in your project ;).
As for me it is very good implementation of Cassandra migration feature.

Great summary! Thanks for giving your thought process.
Out of interest, did you look into https://github.com/sky-uk/cqlmigrate at all? Any thoughts? I'm just toying with the idea of parameterising the migration lib (in a similar way to how certain config options are typed). What do you think of that option? I just wonder if it would provide flexibility for those that have already invested in other solutions (even internal home-grown projects). But haven't thought it through at all yet.
Quick disclaimer: I know some of the people that created it at Sky, but I have never used it myself. Someone else asked about C* migration libraries and I pointed them towards this one purely because it was the only one I knew about.

I didn't hear about sqlmigrate tool before. I didn't yet review code of this tool, but after learning its README, I have couple comments.
First of all I didn't find there support of any kind of programming migration scripts - only CQLs. I believe it's important. Sometimes CQL is not enough, some more sophisticated logic is needed.
2nd thing that caught my eye at once is that sqlmigrate requires to pre-populate not only keyspace/schema (that is completely logical, b/c of typical database security policies) but migration table as well. Actually it wants a dedicated keyspace with only one table there. I don't think it's good solution, b/c you may have e.g. 2 microservices based on dropwizard, both of them use Cassandra as persistent layer - so that you'll have 2 separate keyspaces for each microservice (well - in case if you follow microservice paradigm ;)). But this migration tool violates data isolation with it's own shared keyspace for both microservices. Plus, in case if you cannot parametrize a name of locks table, you cannot organize migration scripts for 2 different microservices - data about migrations of these microservices will be mixed there.
And, finally 3rd thing - if I understand it right, it supports only migration action: no gathered info about current migration state (which scripts are applied, which are pending), no validation (are migration scripts and current database structure correspond each other), no possibility to make a baseline (start migration support from non-empty database).
Please correct me if I'm wrong somewhere.

Thanks for looking into it. It feels like it would be safer (more forwards compatible) to provide options for other kinds of migration libraries in the future. Whether cqlmigrate is one of them, I'm not entirely sure (again, this is mostly because I haven't personally used it).
I do think the concept of CLI-based migration is a good one, and I'm quite happy to support the library you've chosen to implement in this PR.
I'm thinking of merging this PR, then making some very minor modifications to parameterise the migration library for forwards compatibility with future variants. This would essentially add a single value to the config to select the migration approach to use, e.g.:
migration:
  type: '(cassandra-migration|cqlmigrate|whatever)'

This would allow you to use the approach that works for you, while also allowing others that perhaps prefer to use separate CQL files (or have already invested in using another approach) to continue in their current operations without having to make large scale changes.
Any objections?

No objections - I like this idea! )


Medibots broken again

Description
medibots seems to be broken again. They just spam "Hold still please" and do nothing (even not trying to chase, poor guy)

Reproduction

Get hurted
Find medibot
Get yelled by him if trying to move

Did they ever do anything on upstream? I only remember seeing them doing something on nyano

They have a lot of snowflake logic which needs to be genericised significantly. Same with floorbots having draincomponent.


Local analysis gets mesh config from the cluster (if available) or a specific file if provided

Solves https://github.com/istio/istio/issues/18931
Previously, local analysis (istioctl analyze) only used the default values for mesh configuration. This means we couldn't accurately look at some mesh config properties important for analysis, such as enableAutoMtls.
This change updates local analysis to use the mesh config from the cluster if --use-kube is specified, and also to manually specify a mesh config file (that overrides everything).
Reviewers: please let me know if you think we need to make meshConfigMapName / meshConfigMapKey configurable at this time. I wasn't sure how far into edge cases we're getting and how needful it is to support custom values right away.

Mesh config is included as a collection available in the analysis context object, so analyzers that want to use mesh config should be able to get it directly. (This is already the case, but if you do it without this change you'll always get the default values when running via istioctl analyze.)

@sushicw: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
d6821f8e49e471d17ee8030f68845c50cf65bf3c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sushicw: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
d6821f8e49e471d17ee8030f68845c50cf65bf3c
link
/test gencheck_istio

lint_istio
d6821f8e49e471d17ee8030f68845c50cf65bf3c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sushicw: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
705326560d716216a65179a1767a47cc4301f77a
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests_istio

@sushicw: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
a729d57361f6db0808c9bab458eac849ea1f156d
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sushicw: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
6eb8291677944f088587531f98ac368ec47a4787
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: #19055 failed to apply on top of branch "release-1.4":
Applying: smarter precedence source
Applying: fix a bug, seems to basically work now?
Applying: shaping up how this looks a bit better
Applying: use approach from kubeinject.go
Applying: much better and more consistent, but doesn't correctly detect totally bogus files as not mesh config either
Applying: Move file based mesh config to its own arg, cleanup pass
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	istioctl/cmd/analyze.go
Falling back to patching base and 3-way merge...
Auto-merging istioctl/cmd/analyze.go
CONFLICT (content): Merge conflict in istioctl/cmd/analyze.go
Patch failed at 0007 Move file based mesh config to its own arg, cleanup pass


Inherited private DbSet property isn't found

My context has private DbSet properties that EF recognizes and uses. But if my context derives from some base type that has private DbSet properties, then the DbSet on the base type aren't found by EF - they remain null instead of getting initialized.
My DbSet need to be private because I need to wrap them with some MyDbSet class that has additional logic. However, I can't make MyDbSet derive from DbSet, because EF automatically constructs DbSet. So, instead of deriving from DbSet, the MyDbSet just wraps it. My context has a public MyDbSet that I use and a private DbSet that EF uses.

Maybe protected works for you.

EF Triage: at first glance it seems that we could enable this. Assigning to @ajcvickers to get this opinion.

Honestly, I didn't remember that we enabled private DbSet properties at all! Yes, we could also look on the base class for private properties. However, we have generally avoided doing anything much to enhance DbSet property discovery because it is so easy to do your own thing in your context by calling context.Set to create the DbSet and use in any way it can be desired.
Marking for re-triage. I'm fine with this going on the backlog as an enhancement (and probablu up-for-grabs) but I'd also be fine with just closing it and saying use context.Set to create DbSets wherever they are needed.

Discussed in triage and we're not going to do this because the value seems very minimal. However, if anybody in the community wants to send a PR to add support for this, then we would take a look and would likely accept such a PR.


Add xenial app and applet builders

On prod yes, tested but just didn't publish yet. Will do it now and build on stg.


Add commands to Rollback and Delete Snapshots in 2016-07-08 file.

Please review the file and let me know for further modifications.

That's because the file was open in text editor, when I pushed the repository to GitHub.


Visualization live

First I want to thank the authors for the incredible work. I managed to run the sample scene of the Replica dataset and the results are very very good.
My question is, how can I enable a live visualization like the one displayed in the video linked in the repository (min ~ 2-53)??
EDIT: I have seen many closed issues about this so I will change my question.
How can I get the estimated pose of the camera after each mapping/tracking step??
Is it in the "cur_c2w" variable of the Mapper.py?
Thank you for you assistance.

Hi @FranciscoGomez90. Thanks for the question.
The estimated poses are maintained and updated by tracker here, which is also shared to mapper. You can access estimated poses by index.
For the video demo, we used estimated poses, together with intermediate point clouds and meshed scene to make, with the help of open3d. At the time we didn't integrate this visualization into our pipeline.

Thank you for the answer!
Can I run the algorithm on my custom data that consists only of depth maps and color images (no pose data)?
Thanks again!

Yes you can, for this please add a dataset class that has same return format here, you could use identity matrix for pose just for implmentation purpose. The downside is that result can not be evaluated as ground true pose is not available.

That's okay because I do not want to evaluate it but use it for live SLAM on an actual robot.
Let's see what happens. Thank you!

@FranciscoGomez90 did you do it on a live robot? will you agree to share your work?


chore: update uiveri5 generator

#3
fix validation, docu and prettier

Many thanks for your contribution!


initAll fails without adding govuk-frontend-supported class to the body

Description of the issue

I am updating some services to the latest GOV design version (5.7.1), including the previous version, 5.7.0.
5.70 introduces an isSupported function.

We have a client side script setup to run the GOV design initAll function:
import { initAll } from 'govuk-frontend';

export default initAll({
  button: {
    preventDoubleClick: true,
  },
});

After updating, the following console error appears:
SupportError: GOV.UK Frontend initialised without `<body class="govuk-frontend-supported">` from template `<script>` snippet

From reading the release notes and looking at some of the code, it looks like part of updating to 5.7.0 is to add a govuk-frontend-supported class to the nunjucks template's body. Is this correct?
If so, shall we update the release notes? As it is not clear. I expected the initAll function to automatically check and add a govuk-frontend-supported class, similar to js-enabled.
Steps to reproduce the issue

Update to 5.7.0
Load a page with client side GOV frontend JavaScript
Do not add govuk-frontend-supported to the HTML body.

Hi @ttbarnes, the govuk-frontend-supported class is added by a separate snippet, which needs to be added as the first thing inside the <body> tag of your pages.
If you're upgrading from v4.x you should have a similar snippet on your page. It would need upgrading as part of moving to v5.x, for which we recommend using the changelog of the 5.0.0 release as some kind of checklist to bring you project to 5.0.0 (and have the new snippet) before updating to later 5.x versions.

If there's no snippet already in your project, we obviously encourage you to add it, but would also be interested into what led to it not being there as we may be able to update our documentation 😊

Thanks for the quick reply and explanation @romaricpascal
I should have mentioned - we're upgrading from 4.8.0 to the latest version (5.7.1).
We do indeed have the JS snippet for modifying the body class - it previously just had js-enabled, i've updated it to include the latest with govuk-frontend-supported. It all makes sense now 😊
I would suggest adding this requirement/breaking change specifically to the release notes - unless i've missed it after reading a lot of release notes(?).
I did not think to check if "the snippet" had been updated in this page, feels very rare the snippet is updated (i've done a lot of other upgrades on other services). I rely on the release notes and only learnt about the snippet change from your reply, thanks again 👍

No worries, I undestand the changelog can make it read like the govuk-frontend-supported was introduced in this one while it was actually in 5.0.0.
All the breaking changes will be in the release notes of v5.0.0 as we follow semantic versioning and will only release breaking changes in new major versions.

I see it now, thanks @romaricpascal - that was a big release, not surprised I missed it, my fault for not reading properly.


Question: Training data

I wanted to know how much training data is needed to re-train Grobid?

Hello @Bipasha-banerjee, what kind of documents do you want to process with Grobid?

Hi, I want to process book-length documents in PDF.

Hi @kermitt2,
We are working with electronic theses and dissertations (ETDs), and we are particularly interested in finding ways to automatically segment these long documents into chapters. We aim to train Grobid to better segment theses into chapters, but wanted to get your opinion on how much training data would be needed, so that we can gauge if we could manually generate the training data or look into other ways of automatically generating it.
Thanks,
Bipasha

For a new type of documents and a new model, it's very hard to estimate the amount of training data needed. I am usually doing it experimentally by checking the learning curve. In general, my results were not good using synthetic data (even a large amount) versus a small amount of manually annotations.

@kermitt2 Thanks a lot!


Can /metrics endpoint be served over TLS?

Sweet exporter you have here :)
Just wondering if it would be possible to support TLS as that's usually what's required of our org for exporter endpoints.
Am guessing something similar to this would work since this is also written in Go?

Thank you!
I pushed a new commit that enables TLS support for the exporter. I will make a new release soon with the changes.

New release is out. Let me know if you encounter any problems.


Update what's new page for release 1.3

Added information for changes in release 1.3
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Thanks @JaneyCon and @johnpauldickie!
I've rolled these changes in to #7031, so will close this PR.


[ETH_BYTECODE_DB] Import codeslow contracts

Import contracts from https://www.codeslaw.app/about

Codeslow does provide an API for those contracts retrieval. Ask if they consider writing their dataset into verifier alliance database


Support Firefox

The extension currently will not run in Firefox, and need to be ported.

The APIs have all been converted over to use |browser| instead of |chrome|.


Serializing the state

Should pinia serialize the state with JSON.stringify?

For v2 Vue 3 might expose serialization and hydration helpers, so it depends on what is exposed
For v1, it's probably worth doing and adapting the plugins

Updated the docs to explain this


add Laravel 11 support

managed to get the greens :)
https://github.com/atmonshi/laravel-markable/pull/1

Thanks!


Base: Display account if address exists on the the chain

The following returns not found but since it exists on the chain we should actually display it.
{
  "data": {
    "commission": {
      "coins": null,
      "__typename": "ActionValidatorCommissionAmount"
    },
    "withdrawalAddress": {
      "address": "agoric1yl6hdjhmkf37639730gffanpzndzdpmhuz5k84",
      "__typename": "ActionAddress"
    },
    "accountBalances": {
      "coins": [],
      "__typename": "ActionBalance"
    },
    "delegationBalance": {
      "coins": [],
      "__typename": "ActionBalance"
    },
    "unbondingBalance": {
      "coins": [
        {
          "amount": "0",
          "denom": "ubld"
        }
      ],
      "__typename": "ActionBalance"
    },
    "delegationRewards": []
  }
}

done


Webhook Produces Invalid JSON

I am trying to use the webhooks to update Scripture Forge when a build completes, but am unable to parse the JSON sent by the webhook due to the JSON being invalid.
Sample data I have received includes:
{"event":"TranslationBuildStarted",{"build":{"id":"65d65811352b5d93e8a2c02d","url":"/api/v1/translation/engines/65c94648352b5d93e8a24538/builds/65d65811352b5d93e8a2c02d"},"engine":{"id":"65c94648352b5d93e8a24538","url":"/api/v1/translation/engines/65c94648352b5d93e8a24538"}}}

{"event":"TranslationBuildFinished",{"build":{"id":"65d65811352b5d93e8a2c02d","url":"/api/v1/translation/engines/65c94648352b5d93e8a24538/builds/65d65811352b5d93e8a2c02d"},"engine":{"id":"65c94648352b5d93e8a24538","url":"/api/v1/translation/engines/65c94648352b5d93e8a24538"},"buildState":"Completed","dateFinished":"2024-02-21T20:09:34.131Z"}}

With JSON.NET returning the error:
Newtonsoft.Json.JsonReaderException : Invalid property identifier character: {. Path 'event', line 1, position 35.

An online JSON parse I used returned this error (I used this to ensure it was not a Json.NET bug):
Expected double-quoted property name in JSON at position 36 (line 1 column 37)

Also, modifying the Serval Webhook unit test to display the JSON generated returns invalid JSON too:
{"event":"TranslationBuildStarted",{"buildId":"build1","engineId":"engine1"}}

So I don't believe it is an error at the client end. I couldn't find any tests that parse the JSON, so I there might be some configuration I missed for parsing the JSON?

@ddaspit  - why did you put in [JsonExtensionData] under WebhookPayload's Payload? That makes the Json invalid.  Was that intentional?

To tell you the truth, I don't remember why. Maybe it used to work differently and I forgot to remove the attribute.


feat(text-inputs): allow value of type TextFieldValue

Changes description 🧑💻
Allow the usage of TextFieldValue in text inputs Outlined and Filled. Doesn't make sense in dropdown as selection is not possible.
Context 🤔
I have an edit field for phone number, which auto formats number as it is typed.
When the auto formats adds a space between digits block (like in french phone numbers) or a dash (like in US phone numbers), the actual value length is incrase by 2 (the added separator, and the actual digit typed) but unfortunately, the cursor only only registers one more char, i would need to force it to the end, but for that, i need the material impl using TextFieldValue instead of basic String
Checklist ✅

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check compose contract convention. It must follow conventions described here.
[ ] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[ ] I have tested on a phone device/emulator.
[ ] I have tested on a tablet device/emulator.
[ ] I have tested on a large screen device/emulator.
[ ] If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

You can download the apk here :

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/6135ab1a-1c01-4dee-b6ff-eaa2b7020731/artifact/ced2fc8357823c26/p/dd5dcc25b0af3a93cd84d30a2e94dfe3


[Event Request] Page 38 Item Ledger Entries - OnBeforeGetCaption

We want to be able to extend on the GetCaption functionality of Page 38 Item Ledger Entries to navigate to other entities and show this fact in the title. An OnBeforeGetCaption Event, with IsHandled parameter is requested.
Additional remark: Description variable need not te be limited to 100 characters but is acceptable.
    local procedure GetCaption(): Text
    var
        GLSetup: Record "General Ledger Setup";
        ObjTransl: Record "Object Translation";
        Item: Record Item;
        ProdOrder: Record "Production Order";
        Cust: Record Customer;
        Vend: Record Vendor;
        Dimension: Record Dimension;
        DimValue: Record "Dimension Value";
        SourceTableName: Text;
        SourceFilter: Text;
        Description: Text[100];
    begin
        Description := '';

        // MVE
        IsHandled := false;
        OnBeforeGetCaption(Rec, Description, IsHandled);
        if IsHandled then
            exit(Description);
        // *
        . . .

    [IntegrationEvent(false,false)]
    local procedure OnBeforeGetCaption(ILE: Record "Item Ledger Entry"; var Description: Text[100]; var IsHandled:boolean);
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 53649.


Improved storage UX via a StrorageClass resource

Right now, to provision storage for an app, you need to know the semi-magic string for specifying the type of storage you want. We want to improve this by introducing a "storageClass" (need a better name) type resource.
This is similar to our "computeClass" concept in that the admin will be able to configure instances of the "class" and then the end user just needs to say "launch this acorning using the super-fast-ssd storage class"

There are a few things to test here:

When Acorn is installed with default settings, it should create cluster volume classes (volume classes available to all apps running in the cluster) for each Kubernetes storage class. The default storage class will have its corresponding volume class made default. These cluster volume classes don't have any restrictions on them; they are there to ensure the current behavior is maintained. A user can update these cluster volume classes with restrictions and those restriction will be adhered to.
When Acorn is installed with the --manage-volume-classes flag, no cluster volume classes are generated, and, if they exist, they are deleted. The admin user is responsible for creating and managing cluster and project volume classes. See the docs for the configuration of volume class objects.
An app should not be able to run if it is trying to use a volume class that does not exist, or it has a volume size that is outside the bounds of the definition of the volume class (i.e. its size is too small or too big). Additionally, an app should not be able to run if it has a volume that has accessModes that are not allowed by the volume class.
If an app is already running and a volume class is updated that would make the app invalid, it will continue to run without error until the app is updated.

One note about the different objects here. There are ClusterVolumeClasses (available to the whole cluster) ProjectVolumeClasses (available to a project) and VolumeClasses. The last is how a user will interact with the VolumeClasses. The user doesn't care about whether they are using a cluster or project volume class, they just want to know what is available to them. Therefore, commands like kubectl -n acorn get volumeclasses.api.acorn.io and acorn offerings volumeclasses will return all volumeclasses available to a user regardless of whether they are cluster or project.


feat(cmd): add OpenTelemetry SDK integration

Adds OpenTelemetry support with configurable output destinations

Introduces --otel-enabled flag to enable OpenTelemetry logs, metrics, and tracing
Replaces --log-otel-grpc-endpoint with --otel-grpc-url for configuring OpenTelemetry output
Implements OpenTelemetry SDK setup with support for both gRPC and stdout output
Adds trace, metric and logger providers with proper resource attribution
Updates zerolog integration to use global OpenTelemetry logger provider
Ensures proper cleanup of OpenTelemetry resources on shutdown

#147
#146  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 24, 5:35 PM EST: A user started a stack merge that includes this pull request via Graphite.


Datasets with nested folders don't work

Expected Behavior
whenever the user has uploaded a dataset with directories in them like
/foo/bar/hello.txt it should archive those files and unarchive them upon running a job
Actual Behavior
Upon extracting it crashes with the message that the file does not exist:
Feb 06 11:29:38 nerd-cli-dev localkube[3072]: E0206 11:29:38.254878    3072 nestedpendingoperations.go:263] Operation for "\"flexvolume-nerdalize.com/dataset/dbf91146-0b30-11e8-9acf-6e590b362ce7-2f696e707574\" (\"dbf91146-0b30-11e8-9acf-6e590b362ce7\")" failed. No retries permitted until 2018-02-06 11:30:42.254843208 +0000 UTC m=+86500.846620556 (durationBeforeRetry 1m4s). Error: MountVolume.SetUp failed for volume "2f696e707574" (UniqueName: "flexvolume-nerdalize.com/dataset/dbf91146-0b30-11e8-9acf-6e590b362ce7-2f696e707574") pod "nlz-nerdj-b4cnr-vs4zs" (UID: "dbf91146-0b30-11e8-9acf-6e590b362ce7") : mount command failed, status: Failure, reason: failed to download to '/var/lib/kubelet/pods/dbf91146-0b30-11e8-9acf-6e590b362ce7/volumes/nerdalize.com~dataset/2f696e707574': directory is not empty

This issue will be tracked as part of #284


Question: Keep zoomed image visible part within container (same as PhotoViewGallery default behaviour)

Hi everyone. I'm pretty new to flutter and app programming in general, so apologies in advance in case I'm asking something obvious. I used this plugin in a project but there's something I can't seem to get to work.
I used a PhotoViewGallery and just out of the box, if I zoom any of the gallery elements, the visible part of the zoomed image stays withing the gallery's container, it's like "looking at the zoomed image through a window".
However, I tried using a simple PhotoView for another purpose and I can't get it to work in the same way. When I zoom into the image, I see the full image, exceeding the size of its container, overlapping on some elements of the screen and going under others (depending on build order within the widget tree of the screen).
I was wondering how I could manage to keep the visible part of the zoom image within the confines of its container (same as the gallery).
Thank you very much.

I ended up using a PhotoViewGallery with a single photo instead of a PhotoView, but I'm sure there must be a way to achieve what I was trying to do using a PhotoView. If anyone knows how to, I would still be very happy to hear it...

That is a very good question and there is nothing wrong with it. Sorry for the delay, but you can use ClipReact around PhotoView to achieve that.
ClipRect(
  child: PhotoView(
   ...
  ),
)


Improve audio channel status

The audio channel status update system is simplistic.  This PR against the original agon-vdp repo enhances the reporting so that the audio status byte sent to MOS instead of being just 0 or 1 instead is a byte with bits set to indicate the status of each channel.  The implementation of this is slightly confusing, however the idea seems good and overall a sensible model to follow.

To properly support this, I believe that changes would be needed to be made to agon-bbcbasic, and possibly also agon-mos.
MOS keeps track of two audio system variables, sysvar_audioChannel and sysvar_audioSuccess.  These are set from the VDP using an audio protocol response, and indicate whether the last "note play" VDP command was successful or not, and to which channel that command was sent.
Currently BASIC's SOUND command checks sysvar_audioSuccess to see whether a note has been queued.  If the value returned there is zero then that's a fail and it loops back to try again....
The existing PR changes the meaning of sysvar_audioSuccess so a bit being set indicates a channel is busy playing a note.  This would mean that whenever a note is being played the code in BASIC will interpret every note play attempt from that point onwards until every channel is silent as having been successful.  This is obviously problematic.
Our need here is really to allow code to work out whether an audio channel is "active", and thus free or not to play a note.  This feels like it's binary, but adding in volume envelope support means that for the release phase of note playback we get a third state for a channel where it's not silent, but still free to play a note.
Since adjusting the meaning of the Success value is problematic with knock-on effects, we're better off adding a new "get channel status" command.  That would use the existing VDP audio packet system, setting the existing values in MOS.  Our status value for this command would follow the following values:

status
meaning

0
busy playing a note

1
not playing a note (silent)

2
not playing a note (release phase, not silent)

Essentially a non-zero status means that a new note can be played.  If the status is zero or two then the channel is not actually silent.  Checking for bit 1 being set is a way to determine that the channel is truly inactive.

The audio-enhancements branch now supports a status command.  This is a work in progress, as it is currently just a reflection of the internal state of a channel, so include an "abort" state which is used to indicate note playback is in the process of being aborted.
It should be noted that reading the state from MOS immediately after making a VDU call to get the status of a channel results in you reading the result of the previous audio call.  This is because comms between the VDP and MOS is asynchronous.  To ensure the correct status us read code needs to first clear the audio status flag bit from the MOSs VDP status flags field, perform the call to read the status, and then wait for the audio status flag to be set.  MOS itself won't clear these flags - it only sets them.
It's not clear to me right now how to clear the audio status flag from BASIC.  The flags can be read via an OSBYTE call (USR(&FFF4)) however I've yet to find a way to adjust the values.

rethink...  the status could provide better info, such as not only whether a note is playing but also whether envelopes are being applied.  directly reflecting the internal state of a channel also is currently exposing implementation details (the "abort" status) which is not good.  idea therefore is to replace current status implementation with one that exposes a bit field.
bits of data to expose would be:
channel active (sound being generated)
playing note
has duration
has volume envelope
has frequency envelope
we can extend this to include other bits of data as/when relevant or implemented

this is now done

this is now done


Re-execute REST/Main with the correct python version

Fixes #10572
Status
not-tested
Description
Ensure the correct (upstream) python version is used when replacing the current REST process by a new one.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
none
External dependencies / deployment changes
none

tested in my VM and the problem is now resolved

Thanks Todor!


CHEBI:80427, please CHECK

Hi Adnan,
Please CHECK CHEBI:80427, 7,8-dihydro-beta-carotene, as it is needed for a reaction in Rhea.
Please also add a cross reference to MetaCyc CPD-20647.
Cheers,
Kristian

Now checked.


Update zio, zio-concurrent, zio-test, ... to 2.0.21

About this PR
📦 Updates

dev.zio:zio
dev.zio:zio-concurrent
dev.zio:zio-test
dev.zio:zio-test-sbt

from 2.0.17 to 2.0.21
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #142.


Handlers use stale variables from the upper scope

Be sure to search for your issue before opening a new one.
Current Behavior
Handlers like onProgress use stale variables. Any reference to variables from the upper scope within a handler (such as state, or updated props passed into the component) uses whatever that value was at the time the handler was created.
(I believe this is the same as https://github.com/CookPete/react-player/issues/511)
Expected Behavior
Handlers should have access to up-to-date props and state as normal
Steps to Reproduce
See example: https://codesandbox.io/s/wild-snowflake-uv5wj
The time state is incremented by 1 every second.
The onProgress handler always logs time as 0
The onClick handler assigned to the button logs the proper time

This happens due to this line of the isEqual util, which is used in shouldComponentUpdate:
https://github.com/CookPete/react-player/blob/1e41ce5ce5e2d6946701723f60e74326385df92d/src/utils.js#L150-L152
By default, we don't want to needlessly re-render ReactPlayer every second. The caveat of this is that if no props change, the first function passed in will always be the one called.
I'm not sure what can be done.. perhaps an extra prop should be added to force ReactPlayer to always re-render?
In the meantime, this can be fixed by passing in a dummy prop that will always change, like data-cache={time} in your example, which will re-render the component and use the latest onProgress passed in.


Forecast not available

Checklist:

[ X] I updated to the latest version available
[ X] I cleared the cache of my browser

Release with the issue:
4.10.1
Last working release (if known):
It has always worked, can't remember updating recently - tested 4.10.0 and it was the same problem
Browser and Operating System:
Firefox on MacOS

Description of problem:
The card says:
Forecast not available
Check the configured forecast entity

Javascript errors shown in the web inspector (if applicable):
No relevant errors, only this:
Failed to load ‘https://xxxx:8123/browser_mod.js?automatically-added’. A ServiceWorker intercepted the request and encountered an unexpected error. [service_worker.js:1:20098](https://xxxx:8123/service_worker.js)
Loading failed for the module with source “https://xxxx:8123/browser_mod.js?automatically-added”.

Additional information:
Could this be related to the darksky api decomissioning?

This means that the weather entity you are using is either unavailable or not returning the forecast attribute.
Go to your HA settings -> Devices & entities -> entities and find the weather entity that you use with the card. Click it and look at the info tab on the dialog that appears. Is the entity unavailable? If not, look on the bottom of the dialog: is there a forecast listed?
The problem is most likely due to the weather entity, not the card itself.
If you see both of those things and the entity seems fine, then please do the following:

provide me the yaml config of your card
go to your user settings and enable advanced mode. Then go to the developer settings page on the left and the states tab within. Expand the set state box and search for your weather entity. Then provide me with the yaml state it shows for your entity.


Change in-box tag helpers to use DefaultFrameworkSortOrder

#2905
override Order implementation inherited from TagHelper
only exception is UrlResolutionTagHelper which already overrides Order to execute much earlier

/cc @ajaybhargavb or @NTaylorMullen

:shipit:

8babf2b


Modified the namespace for extensions.

Updated directives for classes that are dependent on these extensions

I'm out of town for most of this weekend, but i should be able to take a
look on Sunday or Monday
On Sep 2, 2016 4:48 PM, "Shawn Neckelmann"<EMAIL_ADDRESS>wrote:

Updated directives for classes that are dependent on these extensions

You can view, comment on, or merge this pull request online at:
https://github.com/CrustyJew/RedditSharp/pull/7
Commit Summary

Modified the namespace for extensions.

File Changes

R RedditSharp/Extensions/DateTimeExtensions/DateTimeExtensions.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-0 (6)
R RedditSharp/Extensions/DateTimeExtensions/UnixTimeStamp.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-1 (0)
R RedditSharp/Extensions/DateTimeExtensions/
UnixTimestampConverter.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-2 (0)
R RedditSharp/Extensions/Extensions.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-3 (6)
M RedditSharp/Listing.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-4 (1)
M RedditSharp/RedditSharp.csproj
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-5 (8)
M RedditSharp/Subreddit Information/SubredditSettings.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-6 (1)
M RedditSharp/Things/Comment.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-7 (1)
M RedditSharp/Things/Post.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-8 (1)
M RedditSharp/Things/Subreddit.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-9 (2)
M RedditSharp/Things/Thing.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-10 (1)
M RedditSharp/ToolBoxUserNotes.cs
https://github.com/CrustyJew/RedditSharp/pull/7/files#diff-11 (1)

Patch Links:

https://github.com/CrustyJew/RedditSharp/pull/7.patch
https://github.com/CrustyJew/RedditSharp/pull/7.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CrustyJew/RedditSharp/pull/7, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDuEPMzovcreGmTG8YKVBMQxSNsYB_iks5qmJm1gaJpZM4J0HSp
.

I generally try and avoid namespace changes like this without at least deprecating the features first to avoid breaking peoples code.
That being said, in this case, the class is internal and shouldn't have any impact on anyone else's code.
I've merged it in. Thanks!


x/telemetry: gotelemetry view graphs have data from the future

On the gotelemetry view web server I see graphs like this:

Note "Week 2024-06-30–2024-07-07". Today is 2024-06-26. Showing me what my usage will be in the future is a really cool feature, unfortunately I doubt we have that yet.
From the "Counters" section later down the page, I think this data is coming from this counter file:
<EMAIL_ADDRESS>Program: cmd/addr2line
Version: devel
GOOS: linux
GOARCH: amd64
GoVersion: devel
TimeBegin: 2024-06-26T00:00:00Z
TimeEnd: 2024-07-02T00:00:00Z
addr2line/invocations 8
The program cmd/addr2line is unregistered. No data from this set would be uploaded to the Go team.

cc @golang/telemetry

Thanks for investigating. Yes, let's update the definition of Week to match the implementation.


testerina initial tests

@chanukaranaba This repository is no longer used, so if this PR is required, please send a new PR to https://github.com/ballerina-lang/ballerina repository and close this PR

Closing as per last comment.


Dates break on computers that aren't in GMT/UTC.

Tests fail in other timezones.

Yeesh, yeah, needs fixing, will certainly merge that change.

Merged in #30.


Optional dependencies

This includes all commits from @dansondergaard in #802, and finishes the changes necessary to be able to run the test suite with no matplotlib installed, including adding a build to travis and doc changes (ie, most of the work necessary to close #760).
I'm using @jairideout's suggestion, found in pandas, to skip tests that need matplotlib.

Coverage increased (+0.0%) to 98.98% when pulling c65b55e88a46cda35da9c5b56617e971ae0467e1 on Jorge-C:optional-dependencies into 79b8eda5bf608d74d636b3913382e0bebea36f30 on biocore:master.

Coverage increased (+0.0%) to 98.98% when pulling c65b55e88a46cda35da9c5b56617e971ae0467e1 on Jorge-C:optional-dependencies into 79b8eda5bf608d74d636b3913382e0bebea36f30 on biocore:master.

Coverage increased (+0.0%) to 98.98% when pulling c65b55e88a46cda35da9c5b56617e971ae0467e1 on Jorge-C:optional-dependencies into 79b8eda5bf608d74d636b3913382e0bebea36f30 on biocore:master.

@Jorge-C These updates to @dansondergaard PR look really good! Had a couple of comments in regards to the utility functions.

Looks absolutely great! I didn't want to mess with the testing setup since, honestly, I'm not very experienced with TravisCI :) Thanks for doing this, @Jorge-C!

What is the status of this @Jorge-C ?  This is a critical component in easing the installation process for scikit-bio - mainly due to matplotlib.

This will take some work to get in place. Can you use conda to install scikit-bio in the meantime? That should clear up the matplotlib install issues.

That means we'll need to resolve the conda installation issues for linux ...

It should have been resolved for the latest release (0.5.0), use the Anaconda.org channel (default channel) instead of biocore:
conda install scikit-bio

Does that work for you?

Closing as this appears to have gone stale, please reopen if this should be finished and merged


Use Timber full path

Issue
Just a tiny fix, internally, use Timber fully qualified namespace.

Coverage remained the same at 91.176% when pulling 2f81c92db874b9c8ed7b1a8ea017779caf8da228 on 2.x-fix-acf-class-alias into 996a3244100a77ff3349f74d8f7c736f2213de51 on 2.x.


Last.fm app url

...still points to old hermes page. JFYI.
And thanks for your app.

Thank you for pointing this out.

Could you give me a URL to the page where you found an old link?

It's "now playing with" when you scrobbling something to last fm.

Okay I've update the URL (and added an image to the app), so I'll go ahead and close this issue. Please reopen this issue if you find things are not in order.


v0.11.2

v0.11.2 (2023-07-11)

v0.11.2 Gerard Rovira
Flow key down command (#4766) Gerard Rovira
Fixes broken trunk (#4763) Maksim Horbachevsky
Fix $transferStartingElementPointToTextPoint() (#4756) amyworrall
Add video links to Getting Started docs (#4752) Acy Watson
Fix missing token type (#4751) Maksim Horbachevsky
Add selection adjustments for node removal (#4745) Maksim Horbachevsky
Allow preventing text drag (#4749) Maksim Horbachevsky
Add EditorRef plugin (#4747) Acy Watson
Fix flowtypes for cut/copy commands (#4746) Maksim Horbachevsky
Add RangeSelection docs (#4742) Acy Watson
Fix multi-line token parsing (#4741) Maksim Horbachevsky
Fix code block export (#4702) Maksim Horbachevsky
Remove instanceof checks in onPasteForPlainText (#4737) Acy Watson
Context Menu Options Added (#4713) Shubhankerism
Show excalidraw edit button (#4731) Ibrahim El-bastawisi
Fixed drop down buttons to prevent sumbit (#4727) Ou7law007
Improve md error message (#4710) Acy Watson
Fix: Use $createListItemNode within importJSON to override on deserialization (#4717) Kazu
Image resizer fix (#4722) Maksim Horbachevsky
Keeping local comments and sharedCommentsArray orders in sync (#4721) Ebad
Table selection keyboard controls (#4689) Maksim Horbachevsky
correction : line 47 - create -> update (#4704) Abhishek Kumar
Allow table selection when cells are already selected (#4699) Peter Cook Bulukin
Swap noopener for noreferrer (#4690) Adam Conrad
Additional fix for editor._window in lexical-clipboard (#4686) Xinzi Zhou
Preserving language and indentation of code block when serialized/deserialized (#4682) Ebad
Remove outdated examples (#4684) John Flockton
Remove delay from flakey E2E test (#4676) John Flockton
Fix dropdown menu position in playground when scroll (#4496) Xinyuan Wang
feat: playground inline image plugin (#4423) Anthony Bouch
Override selectall on RangeSelection (#4671) Gerard Rovira
Normalize select all on NodeSelection (#4664) Gerard Rovira
Add columns next to selection (#4663) Peter Cook Bulukin
Fix clipboard if content editable is in an iframe. (#4649) Xinzi Zhou
Fix reconciler recovery listeners (#4654) Maksim Horbachevsky
Check for specific excluded props (#4655) Maksim Horbachevsky
Fix ContentEditable Flow types (#4652) Gerard Rovira
Import alignment for Heading and Blockquote (#4625) Ivaylo Pavlov
Add missing ExportDOM to CodeNode (#4637) Ivaylo Pavlov
Add error formating params (#4629) Maksim Horbachevsky
Add clipboard documentation (#4631) Acy Watson
Add error formating params (#4627) Maksim Horbachevsky
Fix issue with syncing yjs changes to Lexical (#4621) Ebad
fix issue with dead keys (i.e. backticks) when converting markdown (#4620) Michel Bongard
Don't throw error on format element (#4611) John Flockton
fix: freeze get style object in DEV env to avoid mutations (#4616) Jatin Ranka
TextNode docs (#4606) Acy Watson
Fix iOS newline insertion (#4603) Maksim Horbachevsky
Add vercel analytics script (#4604) Acy Watson
mouseenter event typo fix (#4588) raghvendra
Update nodes.md (#4598) navanshu
Fix MenuTypeahead position (#4597) Aleksandr Kiliushin
Fix uuid bug in AutocompleteNode.clone() (#4592) Scott Driggers
use selection from state in insertNodeToNearestRoot and insertNodes (#4570) Calvin Leung
Allow native shift+arrow selection work over decorator nodes (#4584) John Flockton
Fix a11y for ContentEditable (#4580) Max Shypko
Another approach to fixing the className cache (#4582) Acy Watson
Better Error Message for exportJSON type (#4556) Hao Luo

Thank you very much!


Matterbridge did not join muc

Hi
thanks for the good work :)
I've my Prosody and Mattermost running fine on the same server.
Even when I start my bridge, every comment, written on the mattermostserver, reaches the bridge:
eg
EBU[2016-10-28T18:27:22+02:00] WsReceiver: model.WebSocketEvent{TeamId:"mctec4tqrir6fjrxueg9dupjnc", ChannelId:"7mahzujw3byutmgebxfawuozow", UserId:"qd35iaq7t7yw7g5boqt5s37uxy", Event:"posted", Data:map[string]interface {}{"post":"{"id":"puuk3gmw4byf5e99upm6dbwdhc","create_at":1477672042028,"update_at":1477672042028,"delete_at":0,"user_id":"qd35iaq7t7yw7g5boqt5s37uxy","channel_id":"7mahzujw3byutmgebxfawuozow","root_id":"","parent_id":"","original_id":"","message":"miau","type":"","props":{},"hashtags":"","filenames":[],"pending_post_id":"qd35iaq7t7yw7g5boqt5s37uxy:1477671964297"}", "sender_name":"carola", "team_id":"mctec4tqrir6fjrxueg9dupjnc", "channel_display_name":"testcase", "channel_type":"O"}}  module=matterclient
DEBU[2016-10-28T18:27:22+02:00] Receiving from matterclient &matterclient.Message{Raw:(*model.WebSocketEvent)(0xc4203f58b0), Post:(*model.Post)(0xc420370700), Team:"nerdbase", Channel:"testcase", Username:"carola", Text:"miau"}  module=mattermost
DEBU[2016-10-28T18:27:22+02:00] Sending message from carola on mattermost.work to gateway  module=mattermost
I've tried to connect my bridge - xmpp User with gajim and it works fine too.
I've also a Muc open and 2 other clients connected. But the Bridgeuser never joined the conference, and I've tried uncounted settings.
[xmpp]
[xmpp.jabber]
Server="myserver.de:5222"
<EMAIL_ADDRESS>Password="mypass"
<EMAIL_ADDRESS>#this is where the other users are waiting for mattermostnews :)
#but I've also tried: Muc="conference.conference.myserver.de"
[mattermost]
[mattermost.work]
useAPI=true
Server="mymattermost.de"
Team="myteam"
Login="matteruser"
Password="matteruserpass"
PrefixMessagesWithNick=false
[[gateway]]
name="gateway1"
enable=true
[[gateway.in]]
account="mattermost.work"
channel="testcase"
[[gateway.out]]
account="mattermost.work"
channel="testcase"

I hope you can help me, finding out, whats wrong.
There are no problems shown in the prosody error files.
Thanks and regards
Carola

Did you paste your whole config ? Your gateway.in and gateway.out are the same, you didn't add xmpp.jabber to gateway.in and gateway.out ?

That's it!
Thanks a lot. For your work and your hint!

Great to hear it works :)


Faker::Color documentation and a color name method

Hey :wave:
Looking through the issues I realised that there's been couple of requests for color functionality (such as #476). Also found that there's already code for random colors just they do not appear documented in the ReadMe so I've added some.
I only added documentation for some of the methods as I'm not sure if some of the methods such as single_rgb_color and single_hsl_color are as useful. Do you think it'd be worth including documentation for all of the public methods?
At the same time I felt that adding a method to Faker::Color that returns a random name of a color would be a good idea, I noticed that this already existed on the Faker::Ecommerce class so I refactored it to be part of the color class instead whilst leaving the functionality on ecommerce intact.
I added a simple test for the color name which is identical to the test that was already in place for it as part of the ecommerce class.
I hope you find this PR ok; I've tried to keep to the conventions and style I saw elsewhere in the code base.
Thanks,
.FxN
ps. Thanks so much for maintaining this it's such a great helper :heart:

Thanks for the contribution!


fix get array labels for a single line header

@newville this is a quick fix for getting correct parsing of array labels for those data files containing a single line header as:
#eBraggEnergy I0_EH1 I1_EH1 mu I1_EH2 IR_EH2 mu_ref
I got this on a file coming from BM08 at ESRF, but it is a usual case. This avoids having generic col1 col2 ... colN array labels.

@maurov ah, very sorry for re-breaking that!  I'll investigate, but not for a few days....

@maurov I think I can fix this over the next day or 2.
FWIW, the file sent that caused the change actually had 0 header lines, causing a crash as line 93.   I'll add tests that
a) 0 header lines works, giving 'col1 col2 ...'
b) 1 header line will be parsed.

@newville no hurry for fixing that. I could also do it by myself, but I wanted to take the time to put a test there, in order that if we inadvertitely break it, the test will fail.
Here a single line header file that we could use for testing that the column names are returned correctly testlarch_bm08_gecalib_03_1_r.dat.zip
.


Allow admins to review reported testimony

We need an admin view that

Is only accessible to admin accounts
Shows a list of report testimony with a way to view each one
Shows all testimony in order for admins to be able to delete it
Allows moderators and administrators to review reported testimony, ending in either:

Approved, no restrictions, like it wasn't flagged at all
❌ NOT DOING Hidden, the testimony should be hidden from the UI but still accessible if users choose to view it---
Deleted, the testimony is inaccessible from the UI and should be treated as if it was not in the system. Implementation-wise, however, this should be a soft-delete, i.e. the testimony contents should still reside in the database.

This is just the front end component for it.

Hi @sashamaryl I don't know how much of this overlaps with work you're doing but perhaps there is some set of this that your other work has taken care of? Feel free to update the ticket if there's something already completed or missing, thanks!

DONE

TURN UP
On Tue, Jun 6, 2023 at 9:21 PM Tom Magnusson @.***>
wrote:

DONE
—
Reply to this email directly, view it on GitHub
https://github.com/codeforboston/maple/issues/931#issuecomment-1579700932,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARANGSEQDZL5VKVPIEYVU2TXJ7JRDANCNFSM6AAAAAAUSCYPD4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Chapter 3.14 mentions seeds

This is intended to be the topic of a future chapter.

Just a friendly reminder.

This got back-burnered while I figure out a proper text-box system for RLTK; the plan is to insert it back into world building when I've got that working (basically an RNG for world making and an RNG for play, so you can load a seed and have consistent play).


Ignore some nodes from checking

Hi,
Could you please suggest me a method to ignore some nodes when traversing? I have tried dontGoDeeper() but didn't really help me. Please provide me with an example.
Thanks.

I'm assuming you'd prefer to not even compare these nodes to begin with, right? Here are some examples that show you how to exclude properties from the comparison process. This way they won't even show up in the result.

Thanks for the reply. It worked really well. I came up with another problem. I need diff checker to traverse through classes and check the difference with the relevant classes. Please let me know if there is a way to do that.
ex:-
Assume a complex object school which has classes and students. Is there a way for me to compare two school objects and check the difference. My diff checker should traverse through inner objects and show me differences. I checked this scenario and currently it returns null for inner objects in one comparing object.

Hm, your desired behavior should actually work out-of-the-box. Could you post a working code example, so I can check what's going wrong?

Here is my diff checker method:
`public void checkDiff(T t1,T t2){
	ObjectDifferBuilder objectDifferBuilder = ObjectDifferBuilder.startBuilding();
	DiffNode diff = objectDifferBuilder.build().compare(t1,t2);

	diff.visit(new DiffNode.Visitor()
	{
	    public void node(DiffNode node, Visit visit)
	    {
	        final Object baseValue = node.canonicalGet(t1);
	        final Object workingValue = node.canonicalGet(t2);
	        final String message = node.getPath() + " changed from " +
	                               baseValue + " to " + workingValue;
	        System.out.println(message);
	    }

	});
}`

And here is how school objects are created:
           `Student student4 = new Student();
	student4.setName("Tharanga");
	student4.setIndex(678);

	Student student5 = new Student();
	student5.setName("Luke");
	student5.setIndex(635);

	Student student6 = new Student();
	student6.setName("Ruchira");
	student6.setIndex(800);

	ClassFoo classFoo3 = new ClassFoo();
	classFoo3.addStudents(student4);
	classFoo3.addStudents(student5);

	ClassFoo classFoo4 = new ClassFoo();
	classFoo4.addStudents(student6);

	SchoolFoo schoolFooC = new SchoolFoo();
	schoolFooC.addClasses(classFoo3);
	schoolFooC.addClasses(classFoo4);`

The other school object is as follows:
`Student student1 = new Student();
student1.setName("Mike");
student1.setIndex(500);
	Student student2 = new Student();
	student2.setName("Ryan");
	student2.setIndex(523);

	Student student3 = new Student();
	student3.setName("Pieter");
	student3.setIndex(400);

	ClassFoo classFoo1 = new ClassFoo();
	classFoo1.addStudents(student1);
	classFoo1.addStudents(student2);

	ClassFoo classFoo2 = new ClassFoo();
	classFoo2.addStudents(student3);

	SchoolFoo schoolFooB = new SchoolFoo();
	schoolFooB.addClasses(classFoo1);
	schoolFooB.addClasses(classFoo2);`

And finally diff checker:
DiffChecker diffChecker = new DiffChecker(); diffChecker.checkDiff(schoolFooB,schoolFooC);

So far, so good. The code looks fine. The problem could be in your classes. Do you provide getters for all the relevant properties? Could you post you classes as well?

Doing some spring cleaning in the issue tracker, so I'm closing the issue for now, due to inactivity. Feel free to reopen it, if there is anything I can help you with.


Blank Page in ios when in release mode

I don't know if this is something related to mobile binding but here it goes just in case somebody has seen it.
We currently have an app build with blazor, we ported it using the mobile bindings to phone. The app is working great, but in debug mode.  Once we switch to release mode, we get blank pages (some) in an iphone, not in the emulator.  Android everything is working.
Anyone seen this?

Hi @dMiracleMan I haven't seen an issue like that in quite a while. Can you show what your app's startup code looks like in App.cs? Does it look sort of like what's here: https://docs.microsoft.com/en-us/mobile-blazor-bindings/migrate/preview1-to-preview2#update-appcs-to-use-new-host-and-set-mainpage

@Eilon
There are few issues on iOS platform which I am not sure why this happens but we still were able to fix them.
Me and @dMiracleMan got this fixed and working by doing some refactors to the code.
We spend like a month from time to time trying to get everything running back and compatible with iOS on release mode.
We still don't know if this is a bug from MBB or iOS itself since our original code was working properly in debug and release on iOS emulator, in debug on real device but in release displaying blank on some pages.
Android have been working perfectly with the original code and even with the refactors we did to get iOS up and running.
In conclusion as part of our research for iOS to work properly in a real device in release mode:

Avoid using type params on classes that will be used as component base class.
Avoid the virtual keyword.
Classes and Types must be explicitly typed.
Use ComponentBase as your base component always and avoid doing custom component base which you may inherit.

Hope this helps anyone if they hit this error and get stuck on this in iOS platform.

@arivera12 very interesting. I wouldn't have thought that the changes you mention would make much difference. If there's any other info you can share that might help us narrow down the root cause of this. I think that the original problem we had like this had to do with the main page taking too long to start up and because it's async, it wouldn't load in time for iOS to accept it. So that's why the default template sets a temporary main page, and then uses Blazor to load the "real" main page in async, so it's ready whenever it's ready.

@Eilon I would like to have any info to share but iOS just displayed blank with no error message and no crash also.
The problem it's not when the app starts but it could even throw this error on application start up.
Try this on ios in release on real device
[Inject] public virtual IJSRuntime JSRuntime { get; set; }
The page containing this should display blank.

Yes this is quite odd. I can't think of many differences between debug vs. release and also simulator vs. physical device. I don't think there's any code in Mobile Blazor Bindings that cares about these settings/configurations. But it could be some interaction of pre-existing components that is made worse in MBB.

I'm keeping this issue open because there is presumably some issue here, but I don't have any immediate action planned for this.

At least I have the fixes there if anyone crash there.

Yes, thank you @arivera12 , I hope your notes help anyone else who runs into this!


Create advancement for combining swets to a certain size

Maybe max size, or lower.

"World of Goo" is the proposed name


Add extension .gz when filesystem outputs is compressed

Feature description
[normalize.data_writer]
disable_compression=false # default value is false
-> filename could have suffix .gz.

Yes, I'm already a dlt user.
Use case
Avoid confusion.
Proposed solution
No response
Related issues
No response

@armetiz thanks for raising this. we have similar issue already #925 so probably we'll merge them into one


Fix example for email auth

The parameters change is not strictly needed since the backend can be retrieved from the kwargs, but it's harmless and I like the exception change too.
Thanks!


ref: messaging

Change notification from direct callback invoke to message event API
Prettier

Change notification from direct callback invoke to message event API
Prettier


Remove all the Borrows

Fixes #3569
PR checklist:

[x] make succeeds (on *nix)
[x] make reftests succeeds

Tested with:

https://github.com/gfx-rs/wgpu/pull/1156
https://github.com/gfx-rs/portability/pull/240

bors r=grovesNL

bors r=grovesNL


Fixed compatibility with v4.0-rc3

Last RC release had a breaking change in how the is operator works (see: https://github.com/godotengine/godot/pull/73489 )
I changed all the instances of is to is_instance_of(), however a proper review is required to see if all the cases are correct in the context of GodotRx.

This is a bit unfortunate for iterators of style 'while not item is it.End'. I need to come up with something else there. The new expression for type checks is not very elegant when iterating over a sequence. I can probably do better ;)

This is a bit unfortunate for iterators of style 'while not item is it.End'. I need to come up with something else there. The new expression for type checks is not very elegant when iterating over a sequence. I can probably do better ;)

Sure, we can close this PR and let you do the work if you can find a way to do it better, it's your call 😉

I've just released an update for RC3. I am sorry, if my comment came out wrong. I am super happy you are contributing!

I guess then I can close this PR. Thank you for alerting me to the new type shinanigans.


Crash trying to encode large buffer

Hi,
First of all thanks for a great crate.
I'm running into a crash when I'm trying to encode a "large" buffer. Here is a small repro case for it.
use vorbis_rs::VorbisEncoderBuilder;
use std::fs::File;

fn main() {
    let mut file = File::create("test.ogg").unwrap();

    let mut encoder = VorbisEncoderBuilder::new(
        core::num::NonZeroU32::new(48000).unwrap(),
        core::num::NonZeroU8::new(1).unwrap(),
        &mut file,
    ).unwrap().build().unwrap();

    let buffer = vec![0f32; 48000 * 100];
    let t = [&buffer];

    encoder.encode_audio_block(&t).unwrap();
    encoder.finish().unwrap();
}

Callstack
* thread #1, name = 'vorbis_test', stop reason = signal SIGSEGV: invalid address (fault address: 0x7ffffedac3a0)
  * frame #0: 0x00005555555832ad vorbis_test`_preextrapolate_helper(v=0x00005555556eaa40) at block.c:450:16
    frame #1: 0x0000555555583778 vorbis_test`vorbis_analysis_wrote(v=0x00005555556eaa40, vals=4800000) at block.c:549:7
    frame #2: 0x0000555555575af6 vorbis_test`vorbis_rs::encoder::encoder_impl::VorbisEncoder$LT$W$GT$::encode_audio_block::h152463b898dee8a7(self=0x00007fffffffd080, audio_block=0x00007fffffffd498) at encoder_impl.rs:369:4
    frame #3: 0x0000555555572cc8 vorbis_test`vorbis_test::main::h08dbc0d2c10d4962 at main.rs:16:5

I can workaround this issue by manually sending smaller chunks of the data to encode_audio_block but I don't see any limitation in the API/docs that would indicate that I have to do that.

Hi, thanks for the great bug report! I could easily see what went wrong and reproduce the issue.
The problem was a bit tricky to investigate and fix, as it boiled down to libvorbis using the dangerous alloca function to allocate a buffer at least sample_count * 4 bytes big on the stack. In your example code, sample_count is 48000 * 100, which translates to a whopping 18.31 MiB on the stack! For context, the default stack size Rust sets for threads it spawns is usually 2 MiB, and stacks larger than 8 MiB are rarely seen, so this allocation fails and the stack overflows, eventually triggering a SIGSEGV.
The possible solutions are to modify libvorbis to call malloc/realloc instead, or to make sure to allocate a big enough stack on the heap before calling the pesky alloca. For reasons explained in the description of the linked commit and the related libvorbis submodule commit, I chose the first approach.
Please let me know if the fix works for you or if you have anything else to add :smile:

Related upstream PR: https://github.com/xiph/vorbis/pull/104

In your example code, sample_count is 48000 * 100, which translates to a whopping 18.31 MiB on the stack!

This is incorrect vec! will do a heap allocation.

Sorry if my comment was not clear, I meant that allocation happened on the libvorbis side of things. Your code is indeed correct.

Yeah, I deleted my comment as I understood what you meant :)

If the issue isn't fixed in vorbis it's also possible inside the Rust code to do a similar workaround to what I did in my own code (i.e you send smaller chunks of the buffer over to the C code instead)

Yes, that's also a valid option, although the exact maximum buffer size is platform-dependent and thus difficult to calculate correctly. Given that vorbis_rs uses a custom libvorbis fork anyway, it's not a maintenance burden to patch it for the time being.

Wanted to make an update about this here. So I have tested with the latest code and it does indeed remove the crash, but there is another problem with it. When I use my old code where I send chunks of samples (in my case 48k for each channel) to audio_encode_block encoding the song takes about 3 sec (which includes some other stuff also, but that isn't important here)
When I use the latest code and send the whole buffer it takes about 150 sec (!) to do the encoding now. So almost 50x longer. Now I'm sure it's not the fault of the Rust crate here, but this is something users may run into if they also send in a large buffer and have no idea what to expect of the encoding time.

Great catch! I attached a profiler to two runs of the encoder over a 5 minutes, mono, 44.1 kHz song, the only difference being that in one run I chunked the input in blocks of 65536 samples, while in the other I handed off the entire song to the encoder in a single block. The results were as follows:

Non-chunked run: ~26 s

Chunked run: ~1.3 s

As it stands out from the results of the profiler, the slowdown in the non-chunked case is entirely due to a very slow implementation of vorbis_analysis_blockout, which spends a non-negligible amount of time copying memory buffers around. The encoding itself, done by the vorbis_analysis function, is responsible for only about 2.7% of the runtime.
In stark contrast, when chunking the input into smaller blocks, the encoding is responsible for most CPU cycles, even though vorbis_analysis_blockout takes a non-negligible 14% of the total execution time.
In any case, there is not anything this Rust crate can do about the slowdown, other than trying to come up with some libvorbis patch to improve the performance of vorbis_analysis_blockout.
For now, I've added the following note to the encode_audio_block method documentation to make users aware of the tradeoffs between different block sizes, and hopefully guide them to choose the block size that works best for their application (I'm a bit reluctant to do any block size manipulation in this crate, as the crate doesn't have information about the entire use case to choose the optimal block size, and I don't want to introduce "hidden" chunking or buffering costs):

Although the Vorbis encoder is meant to support blocks of any size, there are some performance considerations that users should bear in mind when choosing an optimal block size for their application:

Blocks that are too small (as a rough guideline, between one and 16 samples in size) result in more CPU overhead, which translates into slower execution times due to more repetitions of the per-block encoding setup logic. However, Vorbis is quite well optimized to handle small block sizes: in practice, no slowdowns greater than 2x have been observed even when using a single sample per channel and block, but your mileage may vary.
Too large blocks (e.g., from 218 = 262144 samples) have apparently not been tested much, and lead to a sharp degradation of the encoding runtime and much higher maximum memory usage as the block size increases. Slowdowns of several orders of magnitude have been observed when encoding minutes of audio as a single block.

As a rule of thumb, a pretty good block size is at most a few seconds of audio, or no orders of magnitude larger than the maximum Vorbis encoding window size, 213 = 8192, and does not require your application to do any chunking (i.e., splitting of larger blocks into smaller ones) or buffering (i.e., combining smaller blocks into larger ones). When in doubt, use smaller block sizes. The libvorbis documentation  states that "1024 is a reasonable choice" for a block size.


Updated screenshotReport.sh

The file screenshotReport.sh in /utils subdirectory was not modified according to aquatone.
Fixed that

@chvancooten, review the changes whenever your schedule allows.

i am closing this PR and will be opening another one as it has previous PR history and was wrongly based on the previous ones.


Feature request: estimated battery life remaining

If anyone could help, it would be cool to have an entity that tracks the battery percentage over time to give us an estimated number of minutes remaining before the battery runs out.
It could be part of the integration, or I guess could be done with a template of some sort in home assistant outside of the integration. Its a bit beyond my skill set to figure out... Thanks!

Hey, I'm definitely open to ideas, but off the top of my head, I can't really think of way to reliably calculate this. The rate at which the battery discharges changes based on many factors and essentially stops when the mug is empty. It doesn't discharge much when cooling, but does quickly when heating. The greater the temperature difference the more energy is used to cool it. Many factors are external too, such as ambient temperature, battery health and such.
I suppose we could do something very rough if measured how long the battery lasts in each state and then get that time divided by the percent. It would require a lot of testing though and I don't think it would be very reliable.
Personally, I just set up an automation in Home Assistant that warns me if the battery drops below 15% and the mug is not empty. Usually that suffices.
However, like I said, I'm quite open though.


Translation/Language not shown correctly on Product Page

Can you reproduce this issue when all other plugins are disabled except WooCommerce, Polylang and Hyyan WooCommerce Polylang Integration?
Yes.
What product versions and settings are you using when this issue occurs?

PHP:  7.2.13-nmm1
WordPress: 5.1.1
WooCommerce: 3.6.1
Polylang: [state if using Polylang PRO]
Hyyan WooCommerce Polylang Integration: 1.3.0
Browser: chrome & firefox

http://prntscr.com/nfgcg9
What I Expected
All translations are done for German and English, and connected well.
It shall be well translated like the other parts of this page.
"workdays" shall be "Werktage" because of the language choice in Products->Delivery Time.
Showing the German page: http://prntscr.com/nfgf8b
What Happened Instead
Everything is translated well, but "workdays".
Thanks.

Hi,
we can close this thread, I changed to wpml to test everything working well.
Your plugin was the best help to get it done with Polylang, but there were other issues as well, not according to your plugin.
Thanks for your great work!


Genres api

Type of PR

[ ] Documentation changes
[ X] Code changes
[ ] Test changes
[ ] CI-CD changes
[ ] GitHub Template changes

Purpose of PR
/api/genres  API implementation
Review notes
Issues Closed or Referenced

Closes #69

Closing PR , will be recreated


Dependency mismatches

I get an error related to the nimcrypto version for some reason
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on<EMAIL_ADDRESS>already satisfied
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on<EMAIL_ADDRESS>already satisfied
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on<EMAIL_ADDRESS>already satisfied
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on httpbeast@>= 0.2.2 already satisfied
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on https://github.com/timotheecour/asynctools@#pr_fix_compilation already satisfied
  Verifying dependencies for asynctools@#pr_fix_compilation
      Info: Dependency on https://github.com/timotheecour/asynctools@#pr_fix_compilation already satisfied
  Verifying dependencies for asynctools@#pr_fix_compilation
      Info: Dependency on<EMAIL_ADDRESS>already satisfied
  Verifying dependencies for<EMAIL_ADDRESS>      Info: Dependency on<EMAIL_ADDRESS>already satisfied
  Verifying dependencies for<EMAIL_ADDRESS> Installing<EMAIL_ADDRESS>Downloading https://github.com/cheatfate/nimcrypto using git
       Tip: 21 messages have been suppressed, use --verbose to show them.
     Error: Downloaded package's version does not satisfy requested version range: wanted 0.4.11 got 0.5.4.

If I update that dependency there are more errors, so I'm not sure what to do with that.
Nim Compiler Version 1.4.8 [Linux: amd64]
Compiled at 2021-05-25
Copyright (c) 2006-2021 by Andreas Rumpf

git hash: 44e653a9314e1b8503f0fa4a8a34c3380b26fff3
active boot switches: -d:release

I updated the dependencies to this and it seemed to install fine

requires "nim >= 1.2.0"
requires "argparse 0.10.0"
requires "cligen 1.5.19"
requires "jester 0.5.0"
requires "markdown 0.8.0"
requires "mustache 0.2.1"
requires "nimcrypto"
requires "regex 0.19.0"
requires "uuids 0.1.10"

Thanks for submitting this! I just upgraded these and incremented the version.