[BUG]: DotNetCoreCLI@2 command 'test' does not work with DefaultAzureCredential it seems.

New issue checklist

[X] I searched for existing GitHub issues
[X] I read pipeline troubleshooting guide
[X] I checked how to collect logs

Task name
DotNetCoreCLI@2
Task version
2
Issue Description
It seems no matter what we try we cannot get a yaml configuration that allows the DotNetCoreCLI@2 task to authenticate to azure resources using an Azure DevOps service connection. We have established an Azure DevOps service connection, assigned it to the azure resources with the correct roles and tried to configure the tasks like:
  - task: DotNetCoreCLI@2
    name: Test
    displayName: Dotnet Test
    condition: succeeded()
    inputs:
      command: 'test'
  #    See filtering tests: https://learn.microsoft.com/en-us/dotnet/core/testing/selective-unit-tests?pivots=mstest
      arguments: '--filter "FullyQualifiedName~UnitTests" -- RunConfiguration.EnvironmentVariables.AZURE_TENANT_ID=$(AZURE_TENANT_ID)  RunConfiguration.EnvironmentVariables.APPLICATIONINSIGHTS_CONNECTION_STRING=$(APPLICATIONINSIGHTS_CONNECTION_STRING) RunConfiguration.EnvironmentVariables.AppConfigConnStr=$(APP_CONFIG_CONNECTION_STRING)'
      projects: $(project)$(projectPath)
      testRunTitle: $(project)
      azureSubscription: $(DEVOPS_SERVICE_CONNECTION)

We can confirm the RunConfiguration seems correct. But looking at the error message below it is trying to use AzureService credentials but they are missing? Not sure what is happening here. Any insight would be welcome.
System.TypeInitializationException : The type initializer for 'HAF.Kernel.Test.BaseTest' threw an exception.
---- Azure.Identity.CredentialUnavailableException : Visual Studio Token provider can't be accessed at /home/vsts/.IdentityService/AzureServiceAuth/tokenprovider.json
-------- System.IO.DirectoryNotFoundException : Could not find a part of the path '/home/vsts/.IdentityService/AzureServiceAuth/tokenprovider.json'.
Thanks!
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
ubuntu-latest
Relevant log output
Starting: Dotnet Test
==============================================================================
Task         : .NET Core
Description  : Build, test, package, or publish a dotnet application, or run a custom dotnet command
Version      : 2.242.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/build/dotnet-core-cli
==============================================================================

/opt/hostedtoolcache/dotnet/dotnet test /home/vsts/work/1/s/HAF.Kernel.Test/HAF.Kernel.Test.csproj --logger trx --results-directory /home/vsts/work/_temp --filter FullyQualifiedName~UnitTests -- RunConfiguration.EnvironmentVariables.AZURE_TENANT_ID=<Azure Tenant Id> RunConfiguration.EnvironmentVariables.APPLICATIONINSIGHTS_CONNECTION_STRING=<CONN STRING TO APP INSIGHTS> RunConfiguration.EnvironmentVariables.AppConfigConnStr=<CONN STRING TO APP CONFIG>

   at Azure.Core.Pipeline.BearerTokenAuthenticationPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RedirectPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RetryPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RetryPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.UserAgentHeaderPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Data.AppConfiguration.ConditionalPageableImplementation.GetNextResponseAsync(MatchConditions conditions, Nullable`1 pageSizeHint, String nextLink, CancellationToken cancellationToken)
   at Azure.Data.AppConfiguration.ConditionalPageableImplementation.GetAsyncEnumerator(CancellationToken cancellationToken)+MoveNext()
   at Azure.Data.AppConfiguration.ConditionalPageableImplementation.GetAsyncEnumerator(CancellationToken cancellationToken)+System.Threading.Tasks.Sources.IValueTaskSource<System.Boolean>.GetResult()
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.<>c__DisplayClass33_2.<<LoadSelectedKeyValues>b__2>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.<>c__DisplayClass33_2.<<LoadSelectedKeyValues>b__2>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.TracingUtils.CallWithRequestTracing(Boolean tracingEnabled, RequestType requestType, RequestTracingOptions requestTracingOptions, Func`1 clientCall)
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.LoadSelectedKeyValues(ConfigurationClient client, CancellationToken cancellationToken)
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.<>c__DisplayClass32_0.<<InitializeAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.<>c__DisplayClass45_0.<<ExecuteWithFailOverPolicyAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.ExecuteWithFailOverPolicyAsync[T](IEnumerable`1 clients, Func`2 funcToExecute, CancellationToken cancellationToken)
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.ExecuteWithFailOverPolicyAsync(IEnumerable`1 clients, Func`2 funcToExecute, CancellationToken cancellationToken)
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.InitializeAsync(IEnumerable`1 clients, CancellationToken cancellationToken)
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.TryInitializeAsync(IEnumerable`1 clients, List`1 startupExceptions, CancellationToken cancellationToken)
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.LoadAsync(Boolean ignoreFailures, CancellationToken cancellationToken)
   at Microsoft.Extensions.Configuration.AzureAppConfiguration.AzureAppConfigurationProvider.Load()
   at Microsoft.Extensions.Configuration.ConfigurationRoot..ctor(IList`1 providers)
   at Microsoft.Extensions.Configuration.ConfigurationBuilder.Build()
   at Microsoft.Extensions.Hosting.HostBuilder.InitializeAppConfiguration()
   at Microsoft.Extensions.Hosting.HostBuilder.Build()
   at HAF.Kernel.Test.BaseTest..cctor() in /home/vsts/work/1/s/HAF.Kernel.Test/BaseTest.cs:line 23
----- Inner Stack Trace -----
   at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode, Boolean failForSymlink, Boolean& wasSymlink, Func`4 createOpenException)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Boolean failForSymlink, Boolean& wasSymlink, Func`4 createOpenException)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.StreamReader.ValidateArgsAndOpenPath(String path, Encoding encoding, Int32 bufferSize)
   at System.IO.File.ReadAllText(String path, Encoding encoding)
   at Azure.Identity.FileSystemService.ReadAllText(String path)
   at Azure.Identity.VisualStudioCredential.GetTokenProviderContent(String tokenProviderPath)
  Failed HAF.Kernel.Test.UnitTests.Logging.LoggingTests.EnsureProcessLog [1 ms]

Full task logs with system.debug enabled

 [REPLACE THIS WITH YOUR INFORMATION]

Repro steps
No response

Hey @KonstantinTyukalov , thank you for the reply. We are only using it for testing the code not the dependency restore. Since the DotnetCoreCliV2 task doesn't have the azureSubscription input does that mean it cannot be run under a managed identity then? For example our service connection? We can see the tests do run if we provide the AZURE_TENANT_ID, AZURE_CLIENT_ID and AZURE_CLIENT_SECRET environment variables.

Hi @chassq. This task is not intended to work with service connections (as Konstantin mentioned above - the task doesn't have even the input for that).
However, I guess you can use Azure auth in your code.
To use managed identity in this case you need to have an Azure VM with Managed identity assigned. Please check https://developercommunity.visualstudio.com/t/are-there-any-microsoft-hosted-agents-with-msi-man/1110711
Managed identity can work inside the Azure environment only
As you mentioned before you can use authentication using a service principal (AZURE_CLIENT_SECRET) since it can work for external (not Azure) environment.


Pypi

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.:white_check_mark: chrisr3d:white_check_mark: ostefano:white_check_mark: adulau:x: KageeYou have signed the CLA already but the status is still pending? Let us recheck it.


Use consistent declaration_number generation

We need to generate declaration_number not randomly, but consistent similar to contract_requests implementation. To achieve that, we need to use new version:   @ver_2 "0001-"

done on dev


IGNITE-GG-12646 Fix tests for JSR-310 Java 8 Date and Time API introduced with IGNITE-GG-12549

For CI purposes

Feel free to reopen PR if it is needed.


Date inputs allow 5 to 6 digits as year in Manual journey of Connect Bank Account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Go to any workspace
Choose Connect Bank Account
Choose Connect manually
Go to step 2 of the Form
Enter random values of "Incorporation date" and you'll notice the year part of the value can go upto 6 digits

Expected Result:
Year value should only allow 4 digits
Actual Result:
User can enter upto 6 digits
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] MacOS / Chrome / Safari

Version Number: 1.2.43-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672076005803659
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a092ee76a867ed09
Upwork Job ID:<PHONE_NUMBER>970676736
Last Price Increase: 2023-01-11

Oh yes, I've seen this one! Will take a look.

Proposal
It seems moment will allow the 6 digits for the year and it considers it as a valid, if we pass strict to true in moment constructor then 5/6 digits in the year will be considered invalid but still it can takes 6 digit internally to overwrite year in the input text.
We can provide a max date to the datepicker which will resolve this issue.
diff --git a/src/CONST.js b/src/CONST.js
index ef02585f6..277c4daac 100755
--- a/src/CONST.js
+++ b/src/CONST.js
@@ -41,6 +41,7 @@ const CONST = {
     DATE: {
         MOMENT_FORMAT_STRING: 'YYYY-MM-DD',
         UNIX_EPOCH: '1970-01-01 00:00:00.000',
+        MAX_DATE: '9999-12-31',
     },
     SMS: {
         DOMAIN<EMAIL_ADDRESS>diff --git a/src/components/DatePicker/index.js b/src/components/DatePicker/index.js
index 2983ce762..29e2ee93c 100644
--- a/src/components/DatePicker/index.js
+++ b/src/components/DatePicker/index.js
@@ -30,6 +30,7 @@ class DatePicker extends React.Component {
     componentDidMount() {
         // Adds nice native datepicker on web/desktop. Not possible to set this through props
         this.inputRef.setAttribute('type', 'date');
+        this.inputRef.setAttribute('max', CONST.DATE.MAX_DATE);
         this.inputRef.classList.add('expensify-datepicker');
     }

Ah so simple! This makes sense to me. @mollfpr thoughts?

Proposal
we can pass the expected format parameter to moment when parsing the date, this will make asMoment.isValid  validates the format too before trigger onInputChange
diff --git a/src/components/DatePicker/index.js b/src/components/DatePicker/index.js
index 2983ce7620..cd06957c4e 100644
--- a/src/components/DatePicker/index.js
+++ b/src/components/DatePicker/index.js
@@ -43,7 +43,7 @@ class DatePicker extends React.Component {
             return;
         }

-        const asMoment = moment(text);
+        const asMoment = moment(text, CONST.DATE.MOMENT_FORMAT_STRING);
         if (asMoment.isValid()) {
             this.props.onInputChange(asMoment.format(CONST.DATE.MOMENT_FORMAT_STRING));
         }

Proposal
Solution: I'll use moment strict mode so that the 6-digit year will not pass the validation
diff --git a/src/components/DatePicker/index.js b/src/components/DatePicker/index.js
index 2983ce7620..8f114fb56c 100644
--- a/src/components/DatePicker/index.js
+++ b/src/components/DatePicker/index.js
@@ -43,7 +43,7 @@ class DatePicker extends React.Component {
             return;
         }

-        const asMoment = moment(text);
+        const asMoment = moment(text, true);
         if (asMoment.isValid()) {
             this.props.onInputChange(asMoment.format(CONST.DATE.MOMENT_FORMAT_STRING));
         }

@yuwenmemon Yes, @Pujan92 proposal's looks good to me and it's working fine.
@fedirjh @tienifr Thank you for the proposals but as my test, the year still can be typed into 6 digits.
🎀 👀 🎀 C+ reviewed!

@mollfpr As far as I know the max attribute for input date does not work on Safari, I've also tried that approach but faces that issue. You might want to test that on Safari as well.
If you think we might need an alternative approach, would be good if you can provide more information on how you reproduce this the year still can be typed into 6 digits.

@Pujan92 Would you be able to test/demonstrate your solution on Safari?

@tienifr delete the date and months, click in the years.
https://user-images.githubusercontent.com/25520267/211981260-d0c4bf94-976c-4260-ba7a-0be9dd4e501b.mov

@yuwenmemon @Pujan92 proposal not working on Safari 😬
https://user-images.githubusercontent.com/25520267/211981520-9abfe9df-eade-48e0-baa0-ddf513205efa.mov

oh, yes. Seems the max attribute isn't supported in Safari yet.

Yes, safari and firefox provide partial support for date.
https://caniuse.com/input-datetime

I tried exploring using maxLength on the DatePicker or TextInput - could that be a possible avenue to getting this thing to stop at 4 digits?

 So even if we can't get it to work on Safari I still think it's worth implementing.

@0xmiroslav i agree with you . I was just about to comment that. This issue is relative to browser and can't be fixed.

Updated Proposal
Since now we allow a 99% compromising solution, I updated my proposal
diff --git a/src/CONST.js b/src/CONST.js
index 8cd279eedb..e49385b8e4 100755
--- a/src/CONST.js
+++ b/src/CONST.js
@@ -46,6 +46,7 @@ const CONST = {
     DATE: {
         MOMENT_FORMAT_STRING: 'YYYY-MM-DD',
         UNIX_EPOCH: '1970-01-01 00:00:00.000',
+        MAX_DATE: '9999-12-31',
     },
     SMS: {
         DOMAIN<EMAIL_ADDRESS>diff --git a/src/components/DatePicker/index.js b/src/components/DatePicker/index.js
index 2983ce7620..e25cc90ce1 100644
--- a/src/components/DatePicker/index.js
+++ b/src/components/DatePicker/index.js
@@ -30,6 +30,7 @@ class DatePicker extends React.Component {
     componentDidMount() {
         // Adds nice native datepicker on web/desktop. Not possible to set this through props
         this.inputRef.setAttribute('type', 'date');
+        this.inputRef.setAttribute('max', CONST.DATE.MAX_DATE);
         this.inputRef.classList.add('expensify-datepicker');
     }

@@ -43,7 +44,7 @@ class DatePicker extends React.Component {
             return;
         }

-        const asMoment = moment(text);
+        const asMoment = moment(text, true);
         if (asMoment.isValid()) {
             this.props.onInputChange(asMoment.format(CONST.DATE.MOMENT_FORMAT_STRING));
         }

Besides the edge case of date and month values are cleared., this also has another issue that I'm not sure we'd like to fix: On Firefox/Safari, even when we type date and month first, when we type the year there's an inconsistent behavior:
After the first 4 chars for year is typed in, when you type the 5th, 6th char it will not change any thing, but the 7th char you typed will reset the year to 000x.
I've tried a way to fix that as well but it's more like a work around to patch the browser behavior in this case. Not sure if that's worth fixing.

@tienifr seems your proposal already covered earlier with my proposal + @0xmiroslav suggestion.

@Pujan92 yeah, it's a combination of your and my proposals

@Pujan92 can you make a PR for the fix?
Everyone else, @arielgreen and I will discuss how to divvy up compensation, if applicable.

Sure @yuwenmemon

@Pujan92 @0xmiroslav @tienifr since this was a collaborative effort, how does this sound for payment?

$500 to @Pujan92 (also eligible for the bonus for the timely PR)
$250 to @0xmiroslav
$250 to @tienifr

Can you throw a 👍 if this sounds fair to you?

@arielgreen I think the split is fine. However if there's any bonus for the timely PR, it should be split as well. Since any of the 3 could have been able to do the timely PR if he's chosen to implement the PR. And @Pujan92 already got the (2x) bigger original split for the added effort of implementing the PR.
If the bonus only goes to the one implementing the PR, then the original split should be equal (a.k.a 1/3 for each).
Just my 2 cents.

Proposal
It seems moment will allow the 6 digits for the year and it considers it as a valid, if we pass strict to true in moment constructor then 5/6 digits in the year will be considered invalid but still it can takes 6 digit internally to overwrite year in the input text. We can provide a max date to the datepicker which will resolve this issue.

@tienifr just to point out I already mentioned your solution in my initial proposal with the drawback. Only thing I wasn't aware of the safari/firefox date support issue for which we would need to consider that as a partial solution.

@Pujan92 I interpret it as dismissing that solution, much like when I point out your proposal's potential issue here, rather than you proposing an alternate proposal (which should have accompanied code change and clear indication of such, ...). So I assume my proposal is the first one recommending that solution.
Anyway, let's leave the team to make the call here.
Thanks!

Not overdue, this is in its regression period.

@mollfpr @yuwenmemon please be sure to complete the checklist here.

@arielgreen Thanks for the ping! Will finish the checklist today.

Thanks @mollfpr - let me know if I can be of assistance.

Previously we have maximumDate props to DatePicker where it's set to new Date() on the CompanyStep form. But before this PR, the props are removed to allow users to input any future dates and the Form will validate the value.
Here's the PR https://github.com/Expensify/App/pull/13702 that removes the maximumDate.
cc @yuwenmemon

@arielgreen last in item in the checklist is all yours!

Bump @arielgreen

All payments have been issued. Discussing a test here, then we can close this one out.

Bumped thread for consensus


Addendum to getDuplicates

Addendum to #240
For some reason I took another look at the code and realized that even though it passed the tests, the naming was off.
valueAtIndexIsLast did in fact return true if the value at the given index was NOT the last occurrence in the array. I changed the method to reflect its name and then switched the boolean condition in
getDuplicates to reflect that change. The idea is that isNewDuplicate should return true if the value at the current index is:

The first occurrence of that value
Not the last occurrence, in other words, the value is repeated somewhere in the array later on.

[x] Running yarn lint does not trigger any linter errors
[x] The test of the method you have fixed is passing
[x] You have written a new skeleton method for someone else to work on!
[x] You have written tests to accompany your skeleton method

@cideM Thanks for the change! Can you add a test that would have failed the old implementation so we can prevent that regression in the future?

Not really @ktilcu since it wasn't so much a regression as a name that didn't convey what the function actually did. First I changed the function and kept the name, but I think it might be easier to keep the function and change the name instead. The underlying functions are so trivial that extracting them into separate files with separate tests might be overkill. They are just there so the code is easier to read and they are not exported from the file. The getDuplicates function is the only public function in that module and it's passing all tests.

@cideM sounds reasonable. Thanks for the contribution and the discussion. If you could make an issue with your new method it would be really helpful.


v2.2 download not backwards compatible with commandline install? - STRIKES BACK

I have an app that worked with install and after I updated to 2.2 it ignores install also it ignores --help (it should show help as stated in the original issue).
Oh I did run the app as local Administrator.

I found the reason, see my comment on the original issue https://github.com/Topshelf/Topshelf/issues/40#issuecomment-2457453


Implement /snippets/get_image?snippet_id=&image_of=pcb&format=svg

This is an API ROUTE (create in fake-snippets-api)
Should have a route alias /snippets/images/[author]/[snippet_name]/pcb.svg
Should use circuit-to-svg and snippet.circuit_json
bun test and playwright test required
/bounty $50

/attempt #211


CA cert for azure.com ?

This article states:
Get a certificate
First, get a certificate from a certificate authority (CA). The common name of the certificate should be the host name of the cluster. For example, "myclustername.southcentralus.cloudapp.azure.com".
Is this even possible?  How can I get a CA to issue me a cert for that?  I don't control the azure.com domain.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d34f6d36-58e7-ab10-e659-bdd10a64deca
Version Independent ID: 25d94e4b-8c95-7423-2665-7c09d438a16b
Content: Update a cluster to use certificate common name - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-cluster-change-cert-thumbprint-to-cn.md
Service: service-fabric
GitHub Login: @athinanthny
Microsoft Alias: atsenthi

@gstevens-kyriba Thanks for the Feedback.
I am looping in the doc author to check and add comments on this.

@athinanthny Can you check this and add your comments.

Hi @gstevens-kyriba,
Thanks for reaching out. Looks like this is a case of some of our documentation being up-to-date and some having older information. In this case, another user had the same question answered: https://github.com/MicrosoftDocs/azure-docs/issues/19766
but the changes didn't propagate to the whole doc set.
You're right that not controlling the azure.com domain is an issue, which is why we recommend using a custom domain here: https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-create-cluster-using-cert-cn#get-a-certificate. Thanks for bringing this to our attention, I'll be sure to get the documents in question updated with the newer guidance.
Nick
#please-close


Issue 437 reskin wallet multi currency

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
#437
✅ Checklist

[x] Github issue details are up to date for people to QA.
[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer
Reskin wallet header by adding currency cards.
Imported 2 new libraries

carousel_slider 3.0.0 for the cards view
https://pub.dev/packages/carousel_slider
dots_indicator 1.2.0 for the indicators
https://pub.flutter-io.cn/packages/dots_indicator

🙈 Screenshots
For all UI changes
| Screen Recording |
| https://user-images.githubusercontent.com/51983923/109781783-30fc7000-7bd6-11eb-9f69-604dbb0356d1.mov
| img1 |
👯♀ Paired with
"nobody"

good to go


GitHub: Invite member

Who should be invited to Catena-X ng
GitHub User: @eckardg

Vouching person: Me (@mhellmeier)

Please also add @eckardg to the traceability-spec team.

Hi @mhellmeier could you please verify that @eckardg will working for Catena-X?

Yes, I can verify that the person behind the account @eckardg is working for Catena-X.

Hi @mhellmeier thanks and invitation to @eckardg was sent.

for traceability-spec you as maintainer can also add him to the team as well.
Mabye also a good option to add more maintainer to the gh-team as well
https://github.com/orgs/catenax-ng/teams/traceability-spec?query=role%3Amaintainer
For now @eckardg has to accept the invite and then can be added to the gh-team (7 days)


data-automation-id overriden by most components?

most components i've checked actually override my data-automation-id prop.
I expect the data-automation-id to combine mine as well for tests.
Is this the wanted behaviour?

No, please open an issue for Amir in wix-react-tools. That's part of the root decorator.


Remove unused files in Python tutorial (PL)

Hi,
Some files had similar contents to the ones used, and are not used. I think it's safe to remove them.

Hey,
Can you explain what is exactly deleted? are these duplicates?

Hi! Sure, let me explain:
The files I'm proposing to delete are not displayed on the website, and they are nearly identical with the ones that are.

Obsluz wszystkie wyjatki.md is a near duplicate of Obsluga wyjatkow.md, which is the tutorial on exception handling shown on the website
Zmienne_i_typy.md and Zmienne_oraz_ich_typy.md are near duplicates of Zmienne i typy.md, which is the tutorial on variable types shown on the website.

The differences between the files are merely cosmetic, and I don't see their use.


Update UPX to version 3.95

This will allow us to UPX compress os-config on Intel x86 platforms (both 32 and 64 bits)

Merged to development branch.


Can we use XAML + F# in some way?

I'm trying to see if for declarative views, I can use XAML somehow, and use F# only as a code-behind. I just looked at this project today so I'm not familiar with the ecosystem, and was wondering if there is any way to get functional F# code with XAML-based declarative UI (as opposed to F# based)

With Avalonia.FuncUI not really
But you can use Avalonia with F# as if you were doing C#

https://github.com/yatli/fvim

that project is made with Avalonia but it doesn't use Avalonia.FuncUI
the relevant fsproj code is this
https://github.com/yatli/fvim/blob/master/fvim.fsproj#L55-L67
<ItemGroup>
    <Compile Update="**\*.xaml.fs">
      <DependentUpon>%(Filename)</DependentUpon>
    </Compile>
    <AvaloniaResource Include="Assets\**\*" />
    <Content Include="**\*.xaml" />
    <AvaloniaResource Include="**\*.xaml">
      <SubType>Designer</SubType>
    </AvaloniaResource>
    <EmbeddedResource Include="Fonts\nerd.ttf" />
    <Content Include="Assets\*" />
    <None Include="icons\*.ico" CopyToOutputDirectory="PreserveNewest" />
  </ItemGroup>


Repository Re-construction

This is just a suggestion. If you don't want to do this, you can just close this issue as 'not planned'.
I think this repository has few minor structural problems.

Duplicated files like DarkModeCS.cs and DarkModeCS.cs
Lack of 'coding style guideline' like .editorconfig
VS supports additional .editorconfig entries
Included files that aren't needed to repository
Why do we have DarkModeForms_v1.3.1.zip in this repository?

This makes me hard to contribute to this repository. Editing files in VS will reformat everything to my coding style, so I have to modify them via notepad which prevents me from using 'code completion', 'error detection' etc. that VS provides.
So I suggest re-constructing this respository to make this repository to be easy to maintain and easy to contribute.

Move 'Example' to the top
First, we have to move 'Example' project to root directory.
<root>
├ .git
├ Properties
├ Resources
│
│ DarkModeForms.sln
│ README.md
└ (and other files)

Create centralized 'DarkModeForms' library directory
Then, create 'DarkModeForms' directory that contains every library files that this repository provides:

DarkModeCS.cs
FlatComboBox.cs
FlatTabControl.cs
Messenger.cs

<root>
├ .git
├ DarkModeForms
│ │ DarkModeCS.cs
│ │ FlatComboBox.cs
│ │ FlatTabControl.cs
│ └ Messenger.cs
├ Properties
├ Resources
│
│ DarkModeForms.sln
│ README.md
└ (and other files)

Every modifications for this library files must be done in these files under 'DarkModeForms' directory only. Duplicated files must not be created.
With this, we can 'focus' contribution and distribution on these files.
Create .editorconfig and .gitignore
After that, we now create .editorconfig and .gitignore files.
VS supports .editorconfig configuration by default. You can create your own .editorconfig file at the root of this repository, or refer to my own .editorconfig as an example.
My .editorconfig file is nested and minified, so it lacks of 'root' configuration and comments. I can provide 'merged' version of my .editorconfigs, if you want.
You have to include the newly created .editorconfig file to the project, if you didn't create it within VS.
.gitignore makes Git to ignore files, so that they won't be uploaded or tracked. I suggest you to use .gitignore generated with Toptal, but you can make your own .gitignore with this.
Reformat every files in VS
Since we have .editorconfig file that controls coding style, you should reformat every files in your project via VS. If your VS recognizes .editorconfig, style of those codes should be changed consistently.
Remove excessive files from Git index
Since we now have .gitignore, we can safely remove files that should not be tracked from Git index.
# This commands are for Bash
# Move to repository root
# If you use Windows, use 'cd /d "C:\path\to\repo\root"' instead
cd "/path/to/repo/root"
# Untrack everything from Git index temporarily
# git command will work on any OS if installed correctly
git rm --cached -r .
# Re-add important files to Git index
git add .

These commands won't remove physical files, so don't worry. No files will be edited or be removed. These commands will only modify Git index.
Check before commit/push
If you have Git GUI, you can easily check how files will be modified or be removed/created within GUI. That will help you from fixing problems before pushing your commit to GitHub.
Push!
If you think everything is OK, you can push your commits to GitHub.
Publishing
When you want to publish new version, just zip 'DarkModeForms' that has library files and upload it. Since it is the only source of your library, everything would be up-to-date.

I tried to do it myself and create a PR, but I'm afraid that it will enforce you (and everyone) to use my coding style, and you might be uncomfortable with my coding style.
Best way of adapting this is, you configure your own coding style and apply it.
If you have any question about this re-construction, feel free to ask me about it. I'll help as much as I can.

hi, thank you for your suggestions, they seems really useful.
Im just not too used to the ways of Github, specially the console commands, i just upload the files using the web interface.. yeahh... lame i know.
i'll try to implement some of your suggestions.
Thanks again.

If you need any help about implementing this suggestion, feel free to ask me. I'll help you as much as I can.
Since VS tends to be pesky about .editorconfig recognition, you might have to manually edit .sln or .csproj files to include .editorconfig file to your project.
If you use Linux or MacOS, git command should be already included in your OS. For Windows, 'Git for Windows' that also provides minified MSYS2 environment exists. You can read about Git stuff from here, and how to install Git.
I wish you the best of luck!

Hello TetraTheta,
thank you for your guidelines. I discovered this project just a few days ago, and I am working my own improvements (a tiny portion of which I have already sent to BlueMystic and he included them in the last release). I would be happy to contribute.
I would also be grateful if you continue sharing any future comments publicly here.
I have been developing software using other platforms for more than 25 years but I am very new to Github and want to learn to use it properly.
regards
Jakub

@jurakovic Instead of sending modified files to BlueMystical, you really should create PR for it.

Fork this repository
Create separate branch from main
You'll be messed up if you use main when you want to do another contribution. That's why you use separated branch from main.
Commit changes to the separate branch
(Optional) Rebase and merge your commits into one commit
BlueMystical can also merge those commits into one when accepting PR. But that is not that easy to understand, at least for me.
Create a Pull Request from the separate branch
You can add more commits to the branch until PR is closed (accepted/denied)
BlueMystical decides
DONE

Since the only proof of your contribution is brief mention from BlueMystical, in GitHub's perspective, you are not contributor.
If you understand how Git and GitHub works, contributing become quite funny things to do. At least, it is for me.

I... have few more suggestions about using Git and GitHub, but I'm afraid it would look like I'm enforcing/pushing you to use GitHub as I do, so I want to walk on eggshells around this.

'I might look like this', in meme picture

No offense, please forgive me if you felt offended, or became uncomfortable from this.

Hi guys, all and any contributions are gladly welcome,
Feel free to send or Commit your changes and if they work and are better i'll just merge them.
Thanks!

@jurakovic Instead of sending modified files to BlueMystical, you really should create PR for it.
(...)

Man what are you talking about, who sent what modified files?

Man what are you talking about, who sent what modified files?

I don't know what exactly happened between kachnitata and BlueMystical. I'm just guessing that e4f06eb507bc17f0433aec3ad010c6d25dc755dc and 71df50a9be04ddb8353888777290dacf78bd4c63 are done from file sent by kachnitata and BlueMystical uploaded the modified file to GitHub.
My guess is from this comment by kachnitata and changelog of v1.6.2.

...
a tiny portion of which I have already sent to BlueMystic and he included them in the last release
...
regards
Jakub

Fixed a bug on the Toolstrip icon rendering, thanks to Jakub Jiříček

If I misunderstood things, I'm really sorry about the misunderstanding.
You'd better ask kachnitata or BlueMystical directly for better understanding, if you still wonder.

Ok, I see now the whole thread. Do you see what is my username and who you were responding to? You tagged me in that comment with some "accusations" out of nowhere and I didn't know what was going on.

On topic, yes, I agree that there could be made some "structural changes" in repo. But BlueMystical is it's owner and he decides what and how he wants to do. It's fine to me if it's fine to him. I've forked it and I use it in one of my projects without issues and I'm very grateful for that.

Oh, now I see why you were responding like that. I was mentioning wrong person... I'm awfully sorry. I edited original mention to point right person. I'm really sorry again.

Back to the topic, I'm currently waiting for the owner to apply those changes. If I understood right, he agreed with the repo reconstruction, so it will be done someday. I can wait for it.

Soon ;-p

You don't need to rush.
I know this would be hard to understand for who don't understand Git well. I've nuked whole (and months of) commit history when I first used Git and GitHub. :)
Also, since people who uses this library can just reformat files as they like in their repo. This is just minor, aesthetic issue (not a problem).
You can take your time. Also, sorry for the mess. :p

Hi guys, I have been offline for a while.
regarding the confusion: I think @TetraTheta just mistakenly tagged @jurakovic  instead of me.
I have made my own fork and I would love to add my edits but currently I am struggling with .editorconfig missing here, so my edits would break the indentation, at least (as @TetraTheta  said).
also, I find quite confusing that the main code depends on FlatComboBox, FlatTabControl which are stored in Example folder.
I would love if you @BlueMystical could put at least .editorconfig of your choice.
one more question, perhaps for @TetraTheta  -  what is the most convenient way of contributing? at first, when I came across Dark Mode Forms, , I just downloaded the individual files from here into my target project and adjusted them locally. Then I read your suggestions,and created a fork here on Github. How to integrate this fork with my local Visual Studio? do I need to install any add-ons (like Copilot)?
Regards

I think TetraTheta just mistakenly tagged jurakovic instead of me.

Yes, you're right. That's the reason of whole misunderstandings...

.editorconfig missing here

That's why I suggested adding 'shared coding style' via .editorconfig. Visual Studio provides VS-only entries for coding style, so if we have .editorconfig, we won't struggle for manually fixing indentation style or line breaks.
I use CodeMaid for code formatting -- sometimes, VS code formatting doesn't work at all --, but I do believe that its configuration can also be shared.

the main code depends on FlatComboBox, FlatTabControl which are stored in Example folder.

That's why I suggested to store every library files into DarkModeForms directory like this:
<root>
├ .git
├ DarkModeForms
│ │ DarkModeCS.cs
│ │ FlatComboBox.cs
│ │ FlatTabControl.cs
│ └ Messenger.cs
├ Properties
├ Resources
│
│ DarkModeForms.sln
│ README.md
└ (and other files)

'You only need DarkModeCS.cs' thing in README is sufficient. If anyone wants to use smallest subset of this library, they will read that and use DarkModeCS.cs only.

what is the most convenient way of contributing?
How to integrate this fork with my local Visual Studio

VS itself is very good IDE. I only use CodeMaid because VS's code formatting function sometimes completely stops working. Other things would be just personal preference, like IDE theme etc.
I'd recommend you to wait until reconstruction is complete first. Things are quite complicated with this structure.

But if you still want to participate to this repo now...
Before start, I must say that after the reconstruction, things would be much simpler than this. These things will only work until reconstruction.
This repository is already Git repository. So, forking this repository would be first thing to do, and you've already did it. Good job.
Now, you should clone the forked repo to your machine. VS provides a way to clone it, but I prefer using git command-line like git clone <url to your fork repo>. That's your choice, and how you clone your repo won't matter.
Open the cloned repository and create separate branch from main.
# Create 'my-modification' branch from 'main' branch
git branch my-modification main
# Checkout to 'my-modification' branch just created
git checkout my-modification
# You can use 'git checkout -b my-modification main' to combine these two commands into one

Now, you're on 'my-modification' branch of your fork.
Then, you download ZIP of your repo too. This is for not ruining original code style by accident. All of your modifications will be done in ZIP extracted directory.

NOTE: From here, I only assumed how files in this repo are managed, so there should be a chance that I misunderstand things. This is why I said 'wait until repo reconstruction completes'.

Open .sln file under Example of ZIP extracted directory. I guess every modifications are done in there first, then files are copied to root directory of the repo.
You do your modifications.
Open modified files on ZIP extracted directory and the same file on cloned repository side-by-side with Notepad++ (or any text editor you like) one by one.
While not ruining original coding style, precisly copy your modifications (and your modifications only) to files of cloned repository. Do not change Tab to Space or vice versa.
After copying is finished, run git status at cloned repository. You'll see few modified files. If the list only consist of modified files by you, run these commands:
# Stage all modified files
git add .

Now in GitHub, you can select the newly created 'my-modification' branch by clicking 'main'. Change to 'my-modification' branch.
After that, GitHub will nag you about your branch is X commit(s) ahead of BlueMystical/Dark-Mode-Forms and shows green button saying 'Create PR'. Click it to create PR.
If BlueMystical thinks it is good, he will merge it.

I created some images describing these procedures.

I'm bad at explanation, so pardon me about this poor explanations.

do I need to install any add-ons (like Copilot)?

I guess you are saying 'GitHub Copilot'.
I strongly advise you not to use it. There are plenty of reasons not to use it. AI tends to generate looking-good-code like 'code with bad flow', 'non-existent methods' that aren't always legitimate. AI don't know what is 'right' or 'exists'. It just shows you series of words that looks good, not legitimate.
Use it only if you know how things should flow.

I only use CodeMaid because VS's code formatting function sometimes completely stops working
I have been using VS with Resharper happily for almost 10 years, so I will stick with it, but good to know there are other ways.

But if you still want to participate to this repo now...
I'm bad at explanation, so pardon me about this poor explanations.
on the contrary - amazing explanation. Even if I decide to wait for the reconstruction, it is great to learn this.

AI tends to generate looking-good-code [...] that aren't always legitimate
Agreed. I prefer simpler and transparent solutions too. (but, for eample the automatic refactorings in Resharper are a great time saver for me, but I think they are a different story as they are very predictable).

Alright!
The Repo had been re-constructucted  v1.7.0
Many thanks guys for all your Suggestions, greatly appreciated.
Regards.

@TetraTheta :  i had made and uploaded a .editorconfig file made default with VS.
However, on the upload Github says 'hidden file' and when tried to download the ZIP repo, the file isnt not there, unless its actually hidden.
Can please check and verify the file?
Thanks

I opened new PR that handles things, in opinionated way. Please check it very carefully. If you need something, feel free to tell me.


Add the Project

Description
I have made the changes in the file .py, README.md and added the updated version of .ipynb nootbook.
Checklist

[x] I am making a proper pull request, not spam.
[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
Please review.  Contributes to #1
Add relevant screenshot or video (if any)
(Add here)

@sagnik1511 Raised a PR. Thank you.

Thanks, @TishaJhabak1014! Nice work!!
Glance over other issues if you want to contribute more!

Thanks, @TishaJhabak1014, happy contributing.
P.S. Do remember to add a line Contributes to issue #<issue_number>.

Thanks, @TishaJhabak1014, happy contributing. P.S. Do remember to add a line Contributes to issue #<issue_number>.

Sorry, forgot by chance. Thank you.

@TishaJhabak1014 please save the results of your notebook and then submit a PR !! Your outputs are not showing in the notebook , and they are important because it is not showing the EDA or any plots to substantiate your work and according the updated the Result by Random forest is still the best. So check that and then submit your PR and inform me. This PR will not be considered !! Please be careful from the next time.

@TishaJhabak1014 please save the results of your notebook and then submit a PR !! Your outputs are not showing in the notebook , and they are important because it is not showing the EDA or any plots to substantiate your work and according the updated the Result by Random forest is still the best. So check that and then submit your PR and inform me. This PR will not be considered !! Please be careful from the next time.

Yes, I will try to fix it asap.

You can also add other boosting algorithms or any other !! Do that if you want to and submit a PR !!

You can also add other boosting algorithms or any other algorithm !! Do that if you want to and submit a PR !!
Okay,

Also, can I add random-state parameter to every algorithm to ensure reproducibility?

Yes you can !! And also add brief description about the code cells using the text cells in the notebook and as comments in the python file !!


[121] Add all UK companies to company level dataset that can be used to predict the likelihood of investment

Closes #121.
This PR updates innovation_sweet_spots/pipeline/pilot/investment_predictions/utils.py and innovation_sweet_spots/pipeline/pilot/investment_predictions/create_dataset.py to produce the company level dataset with all UK companies in crunchbase.

Hey, thank you for this and apologies for the delay @Jack-0-0 ! I've run it locally without issues, and it looks good to merge.

Thank you for reviewing!


cleanup CONTEXT_ARM64 definitions

Remove the last lingering repr(packed)
Fix the order of fpcr/fpsr in FLOATING_SAVE_AREA_ARM64
Remove the errant claim that there is a 33rd iregs value for pc
Pull sp out of iregs, x31 isn't a register
Add CONTEXT_BLAHBLAH flags for ARM64
Document/explain things a bit better

CC  @Jake-Shadle

The more I think about it, the more I should just go all in on microsoft's definition here (and expand _OLD similarly). Nothing actually cares about these registers right now so the uniformity argument doesn't apply.

Yeah this is nicer. This also had the nice side-effect of making me notice that I had messed up the (already pretty rough) printing code, which is better now.


Extension.metadata is missing

In the gjs extension guide, there is the following code:
const Me = ExtensionUtils.getCurrentExtension();
// ...
let indicatorName = `${Me.metadata.name} Indicator`;

In the types from this repository, the result of ExtensionUtils.getCurrentExtension() is an object conforming to the Extension interface, which does not have a metadata property:
export interface Extension {
    type: ExtensionType;
    state: ExtensionState;
    path: string;
    error: string | null;
    hasPrefs: boolean;
    hasUpdate: boolean;
    canChange: boolean;
}

@marcinjahn thank you for reporting, I hope to have the time for this the next days

Fixed in the current main branch, will be published with the next release

@marcinjahn released with 3.0.0-beta.14


Feature Request: Bundle Typescript types in published package

💥 Proposal
What feature you'd like to see
Typescript types included in the distributed package
Motivation
It would be nice to not need to install the @types/serialport package to use this in TypeScript (or just to get automatic type hinting in modern code editors).
Pitch
Take the types from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/serialport and published them in the various packages.
All that is needed is a package.json#types field that mirrors the package.json#main field. Looks like creating a types folder that matches the exported lib folder should work.
Related issues
https://github.com/serialport/node-serialport/issues/1790
DefinitelyTyped Serialport issues

It would be possible to make @types/serialport a dependency, like react-testing-library does for their types. That way they could stay synced with those updates.

https://github.com/DefinitelyTyped/DefinitelyTyped#create-a-new-package

If you are the library author and your package is written in TypeScript, bundle the autogenerated declaration files in your package instead of publishing to Definitely Typed.

I recognize that this is talking specifically about packages "written in TypeScript", but, frankly, I don't think that is a hard requirement. DefinitelyTyped is wonderful but we don't need to lean on them if we can just bundle the types directly.

Can we get a never-stale?

bundle it directly, we need @serialport/stream
and so on, especially when using @serialport/stream only and implement custom bindings

There are too many TypeScript bundlers in npm.
Even I made my own bundler today.
I would be happy if TS supports it directly.

There are too many TypeScript bundlers in npm.
Even I made my own bundler today.
I would be happy if TS supports it directly.

Looking into this a little, it looks like 'serialport' is using `'plop`` to bundle packages in a consistent way.
Plot claims to support Typescript types automatically.
Maybe this means what's required is converting everything here to .ts?


RefeshTokenHandler will block new requests when a refresh is in progress

RefeshTokenHandler uses lock.WaitAsync in RefreshTokensAsync, but SendAsync accesses the lock.Wait()-using AccessToken. This would cause the request originator to be blocked since DelegatingHandlers are not called on a background thread.
Adding a GetAccessTokenAsync would solve the problem. I'm happy to submit a PR if I get the time.

Right - which is the desired behavior - the access token is not good anymore at this point - and refresh has to be tried first.
Or did I misunderstand you?

My point is that it will block the calling thread. In a ui application, it would block the ui.

Ah I see - yea send me a PR.

Done.
I'd also recommend allowing the timeout to be supplied in the constructor - the 2 second default would certainly elapse if it reached a .NET (full) endpoint that was cold.

The timeout can be set on the TokenClient

..and thanks!


make seeder guide more understandable

This makes the instructions a lot easier to follow

lgtm, though one of the checks failed.

im merging in a bunch of pr's to fix that right now.


Digging into Period issue again

Should be easier to debug with source maps

Not solving this, closing for the backend API

Is anyone else finding an issue with Page Synonyms crashing the entire Roam itself?


Do we miss a roadmap?

This project is amazing! Really!
But I think we miss a roadmap.
Can we open an issue to pin to the top to collect ideas about the immediate and long future?
Thank you again for your work.

Hey @frederikhors thanks for your interest! Would you be ok with using discussions? You can find them here: https://github.com/orbitinghail/sqlsync/discussions/categories/ideas


[MTSRE-394] new validator for k8s resource and field names

AM0010
Description
AM0010 validates any k8s resource or field names which are included with addon metadata to ensure they conform to k8s naming conventions (DNS1123 label, DNS1123 subdomain, QualifiedName, etc...).
Checklist

[x] Wiki page exists: https://github.com/mt-sre/addon-metadata-operator/wiki/AM0010
[x] Followed the SOP: https://gitlab.cee.redhat.com/service/managed-tenants-sops/-/blob/main/MT-SRE/sops/AMO-validators.md
[x] Tested against production addons in managed-tenants/addons/

This PR cannot be merged until TestAM0010 method signatures are updated for interface changes introduced with #58.

Conflicts resolved.

Applied some refactoring per review suggestions.


Changes related to file system mount path

Changes related to file system mount path

@rajan-mis Changes are related to removing hardcoded file system mount to customer specific values.
Please review and let us know if you have any queries.

@rajan-mis We are keeping it in client inventory file:
[root@jay-boot-tst-bootstrap ibm-spectrum-scale-install-infra]# cat client_inventory.ini
[client_nodes]
jay-boot-tst-client-001.clntscale.com ansible_ssh_private_key_file=/opt/IBM/ibm-spectrumscale-cloud-deploy/client_key/id_rsa
[all:vars]
protocol_cluster_reserved_names = jay-boot-tst-ces.cesscale.com
storage_cluster_filesystem_mountpoint = /ibm/gpfs0/fs1
filesets = [{'name': 'data', 'mount_path': '/mnt/scale/data'}, {'name': 'tools', 'mount_path': '/mnt/scale/tools'}]
enable_ldap = false
ldap_basedns = null
ldap_server = null
ldap_admin_password = null

@rajan-mis We are keeping it in client inventory file:
[root@jay-boot-tst-bootstrap ibm-spectrum-scale-install-infra]# cat client_inventory.ini
[client_nodes]
jay-boot-tst-client-001.clntscale.com ansible_ssh_private_key_file=/opt/IBM/ibm-spectrumscale-cloud-deploy/client_key/id_rsa
[all:vars]
protocol_cluster_reserved_names = jay-boot-tst-ces.cesscale.com
storage_cluster_filesystem_mountpoint = /ibm/gpfs0/fs1
filesets = [{'name': 'data', 'mount_path': '/mnt/scale/data'}, {'name': 'tools', 'mount_path': '/mnt/scale/tools'}]
enable_ldap = false
ldap_basedns = null
ldap_server = null
ldap_admin_password = null

@jayeshh123 Can you please add somewhere this information like readme or vars playbook because this is something exist within filesystem inventory or filesets inventoy. i will merge it for now. but we need to add this into the appropriate section inventory.

@rajan-mis Sure I will raise another PR for it. Thank you


Have no permission to re-run CircleCI

Sometime CI failures are flakes, not related with the PRs. We need to re-run them to pass CI.
There is commands to re-run Prow CI, but none for CircleCI. I find a useful wiki Working with CircleCI , but still have no permission to re-run CircleCI.

How to get the permission to re-run CircleCI?
/cc @rshriram  @geeknoid

This is still a problem.

You can retrigger builds with a command like this:
$ type trigger
trigger is a function
trigger ()
{
    git commit --amend --no-edit && git push -f
}

Well, this would remove any kind of approval, lgtm and the like.

Want to re-run CircleCI test cases just like re-running prow test cases though commands.


Difference_to_previous_day incorrect?

Difference to the previous day seems incorrect. Can you please check this?
Thanks

thanks for the hint. The RKI has added to new columns why the index of the column for 2nd_vaccination.difference_to_the_previous_day isn't anymore correct:

Issue will be fixed with #22

are you going to add these new columns to your API?
Thank you for the nice work!

@niredp i can do this late :-) yesterday, it was to late why i have only fix the bug :-)

@niredp i have added in the newest version (#23) the new fields.


scale_x_logicle() not converging anymore

Hi Mike and team,
I am currently in the process of submitting a new package to Bioconductor, CytoPipeline, which depends on ggcyto::scale_x_logicle().
Since the new Bioc 3.16 release, and in 3.17 devel, this function does not work anymore, regardless (it seems) of the inputs I provide to it. I constantly receive error messages like the following:
Error: Logicle Exception: T =<PHONE_NUMBER>00, W = 2.000000, M = 6.420000, A = 0.000000
   DidNotConverge: scale() didn't converge

I can see that the same error occurs in ggcyto vignette building in the Bioc builds (see e.g. here )
Have you already identified where this problem come from ? Any plan to have this solved soon ?
Thanks a lot,
Philippe

We'll investigate, in the meantime have a look here for a possible solution
https://github.com/RGLab/flowCore/issues/41

Hi Greg,
Yes I knew already about the post you are pointing to.
However, what we have here is a rather serious issue with the logicle function from flowCore, since even default parameters are generating this convergence error, and the ggcyto vignette does not work anymore.
scale_x_flowJo_biexp(), on the other hand, while not generating errors, is no option for me, as it does not look the same, and does not correspond to the parameters obtained using flowCore::estimateLogicle() - unless you know of an exact one to one correspondance between the flowjo_biexp() parameters and the logicle() parameters: I tried myself, for the flowjo_biexp parameters :
maxValue = logicleParams$t,
widthBasis = -10^logicleParams$w,
pos = logicleParams$m - logicleParams$w,
neg = logicleParams$a

can't seem to reproduce it locally, my bioconductor docker image is 5-week old, let me pull the latest to try again

Now I am on the latest bioc devel, can reproduce the same error
> library(ggcyto)
> data(GvHD)
> fr <- GvHD[[1]]
> p <- autoplot(fr, "FL1-H")
> p + scale_x_logicle() #flowCore logicle scale
Error: Logicle Exception: T =<PHONE_NUMBER>00, W = 0.500000, M = 4.500000, A = 0.000000
DidNotConverge: scale() didn't converge

However, applying the same transformation to the same data outside of ggcyto, it succeeds
> lgcl <- logicleTransform()
> trans <- transformList(c("FL1-H"), lgcl)
> after <- transform(fr, trans)
> range(fr)["FL1-H"]
    FL1-H
min     1
max 10000
> range(after)["FL1-H"]
        FL1-H
min 0.5050419
max 3.0772470

It seems to be introduced by the latest ggplot 3.4.0 release, not sure if it is a bug or breaking change from it. Still investigating...
In the meantime, you can downgrade ggplot to 3.3.x which should resolve your issue for now

@phauchamps flowjo_biexp should be equivalent to logicle and is more robust.
The correct mapping between two is
widthBasis = -10^(2 * w)
maxRange=t
neg=a
pos=m

In the latest patch, I just replaced logicle_trans with  flowjo_biexp_trans in scale_x_logicle() function so that it is free from DidNotConverge exception.
Here is the plot now using biexp_trans under the hood

Thank you Mike. However, are you sure of the parameters conversion from logicle to flojo_biexp(). I tried using the new github install of ggcyto, or by calling myself the scale_x_flowjo_biexp in my code using the same parameter conversion, and I get very different results than before. Actually, the new versions of the plots do not look very good.

without the example code and data, we can tell where went wrong

Hi Mike, I downgraded to ggplots2 3.3.6 in order to retrieve the previous scale_x_logicle() results.
Here is a minimal reproduceable example, using fcs file in .zip in attachment

library(ggcyto)

# TO UPDATE
datasetPath <- "/Datasets"
fileName <- "sample_Donor1.fcs"

mySample <- read.FCS(filename = paste0(datasetPath, "/", fileName),
                     transformation = "linearize",
                     alter.names = FALSE,
                     name = "OMIP-21",
                     truncate_max_range = TRUE,
                     min.limit = NULL)

a=1
w=2
[IssueLogicle_20221205.zip](https://github.com/RGLab/ggcyto/files/10152759/IssueLogicle_20221205.zip)
[IssueLogicle_20221205.zip](https://github.com/RGLab/ggcyto/files/10152763/IssueLogicle_20221205.zip)

m=7
t=262144

xChannel <- "450/50Violet-A"

p <- ggplot(
    data = mySample,
    mapping = aes(x = .data[[xChannel]])
) +
    geom_density(fill = "lightblue", alpha = 0.2, na.rm = TRUE) +
    xlab(xChannel)

p + scale_x_logicle(a = a,
                    w = w,
                    m = m,
                    t = t) +
    ggtitle("scale_x_logicle")

p + scale_x_flowjo_biexp(maxValue = t,
                         widthBasis = -10^(2*w),
                         pos = m,
                         neg = a) +
    ggtitle("scale_x_flowjo_biexp")

When using ggcyto 1.26.0 (Bioc version), I get the first plot with scale_x_logicle(), and the second plot with scale_x_flowjo_biexp(). When using last ggcyto version from repo, I get twice the second plot.
I think the parameters matching is not good.

You are right, there seems to be no precise mapping between these two transformations, I am will rollback the previous commit.
Also there are some regressions on ggplot side recently. Let's wait for it's patched release to see if that fixes things.

Hi Mike,
Digging more into this, I think I found the root cause, which is due to a new behaviour of ggplot2 since the new version 3.4.0.
Here is a link to an issue I have just raised in ggplot2 repo : https://github.com/tidyverse/ggplot2/issues/5105
It seems ggplot2 now calls the transformation function with c(-Inf, +Inf) as input (because it is the domain of definition that is set by default for the logicle transformation object). I don't know why this is now the case, since previous versions of ggplot did not do it.
However, I think you can readily solve the problem by robustifying the C++ logicle() function call to extreme negative or positive input values (I guess returning NaN in these cases would do the trick, since the output of these calls does not seem to be used anywhere by ggplot2).
Thanks,
Philippe

Hi, I'm the person who put in the PR that caused this issue.
To explain briefly, ggplot2 now uses a transformation of the domain to cap the range that is fed into break calculations.
Unfortunately, this appears to break some assumptions of the logicle transformation, which can't transform the [-Inf, Inf] domain that the transformation reports.
I had a look at the code here:
https://github.com/RGLab/ggcyto/blob/ac3fcb1e4d815b09137be420ef0c0aa42d22bd17/R/scales_logicle.R#L26-L29
And while it seems it would be best to fix this in the upstream package that defines logicle_trans(), it seems that the issue can be worked around in {ggcyto} as well, by overruling the transformation's domain.
Showing that I can reproduce the issue on my end:
suppressPackageStartupMessages(
  library(ggcyto)
)

data(GvHD)
fr <- GvHD[[1]]
p <- autoplot(fr, "FL1-H")
p + scale_x_logicle()
#> Error in logicle_transform(as.double(x), as.double(t), as.double(w), as.double(m), : Logicle Exception: T =<PHONE_NUMBER>00, W = 0.500000, M = 4.500000, A = 0.000000
#> DidNotConverge: scale() didn't converge

Next, if we override the domain with some large number that the transformation still accepts, we seem to get plot output. I'm not familiar enough with this type of plot to tell whether it is correct, but it seems alright to my untrained eyes.
scale_x_logicle <- function(..., w = 0.5, t = 262144, m = 4.5, a = 0) {
  myTrans <- logicle_trans(w = w, t= t, m = m, a = a)
  myTrans$domain <- c(-1, 1) * 1e160
  scale_x_continuous(..., trans = myTrans)
}

p + scale_x_logicle()

Created on 2022-12-12 by the reprex package (v2.0.1)
Best,
Teun

@teunbrand I hesitate to change that default behavior of logicle transformation function, i.e. infinite values are not valid input.
so I adopted your second approach. This seems to work properly.
@phauchamps thank you so much spending time getting to the bottom of this issue. Let me know if the latest patch works for you

Hi Mike,
Latest patch works for me. You can now cherrypick the fix to the Bioc repo.
Thanks to you and @teunbrand for solving this quickly! :-)
Best,
Philippe

Got if from BiocManager::install() in release version (3.16).
Can't see it (yet) though in devel version (3.17).

develop branch is lagging behind, see the snapshot time here http://bioconductor.org/checkResults/3.17/bioc-LATEST/
I think it should appear by the end of today or tomorrow


Support for getting the currency symbol directly.

Hi,
Thanks for the library, it's working great 👍  . I was wondering whether there is an option to get the currency symbol directly so I can display it in other UI elements as well. For instance a settings screen showing the active currency or a label next to a monetary input field.
Thanks in advance,
Rick

There isn't really a way of getting the symbol by itself at the moment, but I thought of a couple of hacks to get at it. First, you could use withGlobalize to get a currency formatter and strip the numbers:
const currencyFormatter = this.props.globalize.getCurrencyFormatter(null, { minimumFractionDigits: 0, maximumFractionDigits: 0 });
const symbol = currencyFormatter(1).replace(/[0-9]/g, '');

Or (more hacky) you can access the stored runtime arguments of the currency formatter function:
const symbol = this.props.globalize.getCurrencyFormatter().runtimeArgs[0].runtimeArgs[0][0];

Hi @joshswan,
Thanks for the quick reply, the first option will work for me for now. Would this be something that you could see being added to the library? If so I might give it a shot and see if I can come up with a more elegant solution, something like
this.props.globalize.getCurrencySymbol(altNarrow: boolean): string

Thanks again,
Rick

Totally open to a PR for that if you want to take a stab at it. There's an open issue for adding this functionality to the underlying globalize library itself, which would obviously remove the need for hacky solutions, but it doesn't look like there's been any progress on it for the past year. So for now, this is probably the best solution.

@joshswan  Alright, I think I've come up with the most less-hacky way to achieve this in PR #41 .
Let me know if you have any questions 😄

Great stuff! That's a much more reliable way of handling it. Just published v2.3.0 to npm.

@joshswan
Great man, thanks a lot!


[Feature proposal] Generate QR images/ from existing entries

It would be nice to be able to generate QR codes for reading from another device. I store my MFA keys both on a Firefox plugin and my phone. The Firefox plugin ("Authenticator") is able to generate a QR code of the stored MFA keys, which lets me copy them to FreeOTP on my phone.
FreeOTP though can't generate QR codes so I can't read QR codes only on it back to Firefox.
If this feature sounds like it makes sense & if PRs are merged in this project, I could look into contributing this feature myself.

I just switched to a new phone and with it to a new OTP application, FreeOTP. The one i came from did let me generate QR-codes so i could simply move all my tokens over. Having this feature does not just allow sharing a token on multiple devices it also allows people to change their OTP app, away from FreeOTP if they feel like.
Would be cool to have that feature!


Add listenerLevel argument for listen methods to Atom types

Resolves #248

Got it. No, this argument is private as well. You should not use it, if you are not creating something very low-level.
Types for that argument in VS Code will only confuse casual developers.


Not working in mobile application

Hii the app doesnt recongise the touch events from mobile...  can this plugin be used to touch devices???

Checkout #15


Add Eclipse build instructions

Switched to develop branch for a more clean pull request.

I am not sure why, but the .png files associated with this commit actually contain html content. Any idea why that is @crazyquark?

Its not clear that after merging, the resulting Eclipse README.md will refer to images hosted within the repository.

Ping?
We'd like to use this change, but the .png files with .html content in them make us nervous...

I don't mind the html content but we shouldn't be linking to a forked repo

Ah, sorry about that. The Markdown needs to be edited to point to your repo instead of my fork.
Not sure about the PNGs. I just made them with "Shutter" on Linux, a tool similar to Snipping Tool on Windows.

I corrected the png paths. I don't know about the html content...

@crazyquark Can you please email me the .png files<EMAIL_ADDRESS>and I will fix this branch. Thanks

Replaced by:
https://github.com/ripple/rippled/pull/1065

OK, I will email you the .png files.


Update pod log collection to include all kube-system pods

What type of PR is this?
/kind feature
What this PR does / why we need it:
Updates the sync tunnel logs process, which is used to provide logs for the walinuxagent hourly logs collection, to include logs for all kube-system pods
Which issue(s) this PR fixes:
N/A
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
none
Release note:
none

lgtm :)

moved everything to VHD, will proceed with testing

tested with standalone, looks good


feat(sandbox-testing): added sandbox example for socketio

Description
added sandbox example for socketio.
Once the extension is published, i would need to update 1 dependency, i.e loopback4-notifications.
In this PR this is being installed from the github repo
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[x] Performed a self-review of my own code
[x] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

fix CI check as well.


What does ShadeRule.keep do exactly? Does anyone know?

"The ShadeRule.keep rule marks all matched classes as "roots". If any keep rules are defined all classes which are not reachable from the roots via dependency analysis are discarded when writing the output jar. This is the last step in the process, after renaming and zapping."
What does this mean? ...defined precisely enough that I could write a test to verify whether it works or not?
Actually it's from jarjars readme, and you get whatever it is that jarjar does. Jarjar makes no attempt to define the above functionality precisely. And despite dependency tracing being notoriously hard and subtle, it does not include any unit tests for depedency tracking, nor can I make much sense of the implementation.
My own observation is that it simply doesnt work, for any definition of "reachable from the roots via dependency analysis" that I'd find useful (eg like Proguard). For example, scala.Function1 was removed from my Scala codebase by the shading operation.
By documenting this as a feature of the (respected) sbt-assembly, is this plugin implicitly endorsing broken code?

I had the same issue, and after looking into it jarjar keep does work, however sbt-assembly calls jarjar in a way that is not useful for the keep command.
If you look at the source code: https://github.com/sbt/sbt-assembly/blob/08d66534a758199e5ea57819b974d95f6ff7041e/src/main/scala/sbtassembly/Assembly.scala#L218
you will see that jarjar is applied separately to the main source and each jar individually.
So the result is that it will assume that none of the code in the jar is used as none of the roots are present.
The fix would be to either separate the keep rules and run them after generating the fat jar, or you could run jarjar afterwards somehow on the output jar.
Hope that helps understanding and maybe someone can fix that.

I've had the same issue with ShadeRule.keep. Setting the root of my project's code as something to keep, results in a jar that is very small, and is missing scala.collections.Seq. Hope this can be fixed soon.

We've ended up adding a separate step post-assembly to call jarjar process independently to work around this. @eed3si9n would it be possible to provide something like an .inAssembly context to denote rules to be evaluated post-assembly?
It'd be really nice to assemble the fat jar and then slim it right down using a simple keep.("org.package.Main").inAssembly rule or similar.

How did you do this @mal , do you have a repo by any chance?

So my extremely hazy recollection of this is that we built a fat jar normally with assembly, then (I believe) ran the jarjar tool as described (or close to) in #186 in order to get the list of classes required by our main, resulting in a slimmed list, and then used that output to manually create a set of as simple and as few keep(x).isAll rules as possible to cover all the necessary classes. This was a trial and error process of starting with a keep rule only for our main, examining the fat jar, determining what from the jarjar output had not been included, adding as broad and as sane rule as possible to cover that, and repeating this process until we were just packaging the minimum required.
From memory the result was about four keep rules (including the initial one for our main class) and a significantly smaller jar for our application which met the size requirements we were hoping to beat.
I would note that while this approach worked and fulfilled our needs, it was devised in the absence of any strong JVM ecosystem knowledge, and so (and I would hope) there might be far better ways of addressing this type of problem, especially two and half years later.
P.S. This was for a relatively small project using just a few select parts from a very large supporting lib, explaining the relatively few rules, and significant filesize saving - from memory we shed over 200MB from the initial fat jar! 😁


Fix typo in sample install-config.yaml

Signed-off-by: chuckersjp<EMAIL_ADDRESS>Per recent docs the proper stanza is
networking.machineNetwork

/ok-to-test


[Blog Comments] Tadukoo Bible Program Advances - 12/15/2016

https://tadukooverse.github.io/blog/2016/12/15/tadukoo-bible-program-advances.html

page removed


Make package compatible with Julia versions 0.7 and 1.0

Pull Request Test Coverage Report for Build 43

28 of 28 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 36:
0.0%

Covered Lines:
324

Relevant Lines:
324

💛  - Coveralls


[Go] googleai: revised plugin design

This illustrates the new plugin design:

Plugins are initialized with an Init function that holds
configuration.

All models and other entities are defined in Init.

Plugins have global state.

Configured values can be retrieved by top-level functions that
take strings as arguments.

meant to stack this


Additional option for Lesson Publication Consent

This fixes #1508 by:

extending Lesson Publication Consent with one more option (undecided)
providing a migration that updates all persons, who have no record
of being changed after first Lesson Publication Consent migration
(0165) was introduced. This means they were neither logged in to
change that option, nor changed by anyone else.

Fixed according to @fmichonneau review.


[Error] assert.h: No such file or directory

The following error occurs when building firmware with GPK FWBuilder v0.10.2.
The same error occurred in v0.10.1, but v0.9.2 was able to build without problems.
Compiling: .build/obj_is_watering_isw_oozy_vial/src/default_keyboard.c In file included from ./lib/pico-sdk/src/common/pico_base/include/pico/types.h:12,
from ./lib/pico-sdk/src/common/pico_base/include/pico.h:24,
from ./lib/pico-sdk/src/rp2_common/hardware_flash/include/hardware/flash.h:10,
from ./platforms/chibios/drivers/wear_leveling/wear_leveling_rp2040_flash_config.h:6,
from :
./lib/pico-sdk/src/common/pico_base/include/pico/assert.h:18:10: fatal error: assert.h: No such file or directory
18 | #include
| ^~~~~~~~~~
compilation terminated.
[ERRORS]
|
|
|
gmake: *** [builddefs/common_rules.mk:373: .build/obj_is_watering_isw_oozy_vial/.build/obj_is_watering_isw_oozy_vial/src/default_keyboard.o] Error 1

System Information

Operating system: Windows 11
GPK FWBuilder version: 0.10.2

I don't know what file you are using, but it may be due to a missing or incomplete installation of the compiler toolchain (https://github.com/qmk/qmk_firmware/issues/22291)
Please update the REPOSITORY tab - QMK or VIAL, or IMAGE REBUIL.

Perhaps it was the memory settings in WSL2.
We increased the memory allocation and are now building with v0.10.2 with no problems.
Sorry for the trouble!


⚠ Tada Website has degraded performance

In c77936f, Tada Website ($WEBSITE_URL) experienced degraded performance:

HTTP code: 200
Response time: 5416 ms

Resolved: Tada Website performance has improved in ce7cf7e.


Rethink comparing tensor coefficients dominated by round-off/numerics/...

Hi Nicolas,
this contribution is written in kind of a hurry, but it addresses the problem of deviations in the case of spherical inclusions.
Please see the code and the commit messages in detail, to think about:

Making tests deterministic by seeding np.random
Think about fixing material parameters
Be aware of the difference of atol and rtol arguments of np.allclose and implicatiosn for your code... see also
Think about influence of material parameters on the precision of specific tensor coefficients
What is the expected precision for specific tensor coefficients?
Which material symmetry does the resulting stiffness has and what does this symmetry imply for specific tensor coefficients?

Do you black your code or use a different formatter?

Thank you, Julian. Your implementation kind of opened my eyes. I did not recognize that the deviation in the test derives from numerical errors. Since the mean value of these tensors is in the range of 1e10, giving the np.allcose() a small atol value would for sure help in avoiding only comparing selected entries of the tensors.


LGTM.com - false positive  C# Potentially dangerous use of non-short-circuit logic

Description of the false positive

The & and | operators do not use short-circuit evaluation and can be dangerous when applied to boolean operands. In particular, their use can result in errors if the left-hand operand checks for cases in which it is not safe to evaluate the right-hand one.

However, safety of the right operand is determinable, and is not checked in this test.

The | and & logical operators, known as non-short circuit operators, should not be used. Using a non-short circuit operator reduces the efficiency of the program, is potentially confusing and can even lead to the program crashing if the first operand acts as a safety check for the second.

Program efficiency can also reduce security, such as if you are trying to do constant time comparisons, to reduce the information of timing oracles of code that deals with sensitive data.
URL to the alert on the project page on LGTM.com
https://lgtm.com/projects/g/jbtule/keyczar-dotnet/snapshot/5b0a3951b2f83d6049f61b4effc65b1126f773cf/files/Keyczar/Keyczar/Util/Secure.cs?sort=name&dir=ASC&mode=heatmap#xf45850b7a250a084:1

Hi Jay, Many thanks for your report.
You are right that the query did not consider the timing implications, or the fact that MethodImpl(MethodImplOptions.NoOptimization) was used on the method.
It's very hard for a query to automatically determine the reason for the non-short-circuit in this particular case. In the general case, you'd probably prefer || where efficiency is more important than preventing timing information leaks.
One solution for now is to use an alert suppression comment to remove the alert on that line, which is described here.


added roll_dice method

This is my first contribution

This looks like a good start @woopsi . Consider calling the roll_dice() method throughout the main code and testing it, and let's go from there.


Whenever i try to click on a role button it says : "This interaction failed" below the bots button message

thats my problem but also the exact problem doesnt show up in the terminal of my visual code studio application.

Check out the discord intents to check if it is enabled in the code and on the website

@EnderRobber101 actually it was because the role of my bot was in the very bottom of the roles so it didnt had privileges. But still thank you


duration in nanoseconds in the json file

Hi there
Could you please add a config for having the duration in nanoseconds as default which is consistent with cucumber-js?
Thank you

Thanks a lot Wim


Data Import

Whats the best API or service did you use for importing historical stock data?

Not really a issue related to the library, there's other forums that would be better for this discussion.


fix ImagePullPolicy

Test name
Status

recreate
passed

scaling
passed

init-deploy
passed

self-healing
passed

scaling-proxysql
passed

storage
passed

operator-self-healing
passed

demand-backup
failed

limits
passed

monitoring
passed

monitoring-2-0
passed

affinity
passed

Test name
Status

init-deploy
passed

storage
passed

self-healing
passed

limits
passed

operator-self-healing
passed

scaling
passed

monitoring
passed

scaling-proxysql
passed

monitoring-2-0
passed

affinity
passed

recreate
passed

demand-backup
failed

Test name
Status

scaling
passed

recreate
passed

scaling-proxysql
passed

demand-backup
failed

init-deploy
passed

storage
passed

self-healing
passed

limits
passed

operator-self-healing
passed

monitoring
passed

monitoring-2-0
passed

affinity
passed

Test name
Status

init-deploy
passed

storage
passed

recreate
passed

demand-backup
failed

limits
passed

scaling
passed

monitoring
passed

scaling-proxysql
passed

monitoring-2-0
passed

affinity
passed

self-healing
passed

operator-self-healing
passed


cli: adding notepad support on windows and using pathbufs

Adding notepad support to windows, and replacing string representations of paths with path buffs for better support across different OS

Initial commit has replaced some strings with pathbufs, but only to a limited extent so far
Notepad has been added as a supported editor, and can be opened with cli. However, it still has a bug where notepad won't remember the file location when you use save or save as.

@tvanderstad can you test this on windows
@SmailBarkouch can you test this on linux?

Taking a look at why macos isn't working:
    let mut result = env::temp_dir();
    result.push(Uuid::new_v4().to_string());
    fs::create_dir(&result)
        .map_err(|err| err_unexpected!("couldn't open temporary file for writing: {:#?}", err))?;
    Ok(result)

result exists for sure, and my document is written to this location, but vim opens empty.
edit_file_with_editor also gets the right path... That vim command looks suspicious to me. You can debug the command just by printing it out, pretty neat.
Your current implementation sends this to /bin/sh:

this does not work

unfortunately this does not work either

this does work though, this is the old way we did it. We could dive into the details of how </dev/tty works and what the right way to express this within std::process::Command, or we could just keep the old way for now using format! when using #[cfg(not(target_os = "windows"))].

superseded by #1064


All Unavailable today

 All is unavailable today. Renault stop servers?
Version of the custom_component
 i just bump to 3.0.8 now but it's always down
Configuration

Add your logs here.

Describe the bug
A clear and concise description of what the bug is.
Debug log

Add your logs here.

Yes likewise, logs:
Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/config_entries.py", line 236, in async_setup     result = await component.async_setup_entry(hass, self)  # type: ignore   File "/config/custom_components/renault/__init__.py", line 33, in async_setup_entry     await renault_hub.async_initialise(config_entry)   File "/config/custom_components/renault/renault_hub.py", line 58, in async_initialise     vehicles = await self._account.get_vehicles()   File "/usr/local/lib/python3.8/site-packages/renault_api/renault_account.py", line 62, in get_vehicles     return await self.session.get_account_vehicles(   File "/usr/local/lib/python3.8/site-packages/renault_api/renault_session.py", line 188, in get_account_vehicles     return await kamereon.get_account_vehicles(   File "/usr/local/lib/python3.8/site-packages/renault_api/kamereon/__init__.py", line 226, in get_account_vehicles     await request(   File "/usr/local/lib/python3.8/site-packages/renault_api/kamereon/__init__.py", line 143, in request     kamereon_response: models.KamereonResponse = schema.loads(response_text)   File "/usr/local/lib/python3.8/site-packages/marshmallow/schema.py", line 760, in loads     data = self.opts.render_module.loads(json_data, **kwargs)   File "/usr/local/lib/python3.8/json/__init__.py", line 357, in loads     return _default_decoder.decode(s)   File "/usr/local/lib/python3.8/json/decoder.py", line 337, in decode     obj, end = self.raw_decode(s, idx=_w(s, 0).end())   File "/usr/local/lib/python3.8/json/decoder.py", line 355, in raw_decode     raise JSONDecodeError("Expecting value", s, err.value) from None json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

I am reassured.  I thought it came from my connection

Looks like ZE Services is having issues as my app does not work either.

again the cleaning lady who unplugged the wire

I can restart Hassio! It's ok now for me! 😉


Performance feedback

Hi, I've just set up a new media transformer server for this non-profit initiative and I'm curious if the performance I'm getting is expected or maybe I messed something up?
It's a really basic fetch/transform/respond thing, the code can be seen here https://github.com/OpenBeta/media-server/blob/develop/app.js
The service is running on google cloud run, 1gb ram and 2 cpus. Images take ~3s/4s to load.
Example call of the service and the source image for this call
In the past I've set sharp and I had this feeling it was much faster, but maybe I was processing much smaller images, IDK.
I can't thank you enough for the huge effort you've been putting on this project.

Your code looks OK from an initial glance. If you want to see whether the effects of increasing RAM and therefore CPU share would benefit this task I guess you'll probably to remove networking I/O from any performance calculations to get more accurate timings.
It's a bit trickier to do this with Stream-based I/O, but perhaps in your code you could listen for and calculate the interval between events emitted by pipeline.queue - see https://sharp.pixelplumbing.com/api-utility#queue

Thank you. I'll consider it to be ok until something prompts for deeper insights using pipeline.queue.


Timezone for CronWorkflow not working for all expected zones

Summary
Timezone settings for CronWorkflows don't appear to work for all expected timezones. I have set a timezone of Europe/Dublin and the controller does not actually start the job. There are some log messages that it is processing the job but nothing appears to start. When I changed to America/New_York or Europe/Paris it appears to work. I have also tested with Etc/GMT-1 and Europe/Amsterdam and same results, no worky.
Diagnostics
What version of Argo Workflows are you running?
v3.0.1
I will provide logs if needed.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@simster7 ?

Will take a look

@endzyme can you please confirm if this worked in v2.12?

Related?
fix(controller): Fix timezone support. Fixes #5181 (#5182)

@endzyme can you please confirm if this worked in v2.12?

It did, but I'll try to spin something up this coming week to provide proof. I saw your note on the related Dockerfile change. It's likely related but I haven't fully dug into why some timezones would work and others would not.

time="2021-04-19T15:33:18.696Z" level=error msg="could not schedule CronWorkflow" cronWorkflow=argo/test-cron-wf-basic error="provided bad location Europe/Dublin: unknown time zone Europe/Dublin"

time="2021-04-19T15:34:45.881Z" level=error msg="could not schedule CronWorkflow" cronWorkflow=argo/test-cron-wf-basic error="provided bad location America/New_York: unknown time zone America/New_York"

https://medium.com/@mhcbinder/using-local-time-in-a-golang-docker-container-built-from-scratch-2900af02fbaf
https://stackoverflow.com/questions/47794740/gos-time-doesnt-work-under-the-docker-image-from-scratch


Enable CFUUIDCreate on linux

Hm, this is sometimes hanging on Linux for me here:
* thread #1: tid = 19079, 0x00007ffff6a87df0 libpthread.so.0`__libc_read + 16 at syscall-template.S:81, name = 'TestFoundation', stop reason = signal SIGSTOP
  * frame #0: 0x00007ffff6a87df0 libpthread.so.0`__libc_read + 16 at syscall-template.S:81
    frame #1: 0x00007ffff725e397 libFoundation.so`uuid_generate_random + 39
    frame #2: 0x00007ffff7518897 libFoundation.so`Foundation.NSUUID.init () -> Foundation.NSUUID + 55
    frame #3: 0x00007ffff75188df libFoundation.so`Foundation.NSUUID.__allocating_init () -> Foundation.NSUUID + 47

@parkera Here are results of fixe subsequent runs of the test suite:
Test Case 'TestNSUUID.test_Equality' passed (0.001 seconds).
Test Case 'TestNSUUID.test_Equality' passed (21.257 seconds).
Test Case 'TestNSUUID.test_Equality' passed (33.19 seconds).
Test Case 'TestNSUUID.test_Equality' passed (11.753 seconds).
Test Case 'TestNSUUID.test_Equality' passed (8.395 seconds).

Test Case 'TestNSUUID.test_description' passed (0.0 seconds).
Test Case 'TestNSUUID.test_description' passed (24.571 seconds).
Test Case 'TestNSUUID.test_description' passed (41.93 seconds).
Test Case 'TestNSUUID.test_description' passed (19.679 seconds).
Test Case 'TestNSUUID.test_description' passed (2.244 seconds).

Looks quite odd, seems that something is wrong with reading from /dev/random. Investigating the problem.

Seems, that /dev/random can be very slow sometimes. How about using /dev/urandom instead? It'll give pseudo-random data even if enthropy pool is empty. Should be good enough for generating uuid.

/dev/urandom is probably fine

Much better, thanks.


Xonsh: bash: python3.10: No such file or directory

Local OS (where xxh is installed):
EndavourOS 6.0.10-arch2-1
Destination host OS:
Debian 11.5
xxh version:
xxh/0.8.11
xxh-plugins installed:
none
Steps to Reproduce

I run xxh ruud@docker-02 +s xonsh +v
The output log:

Load xxh config from /home/ruud/.config/xxh/config.xxhc
ssh arguments: ['-o', 'StrictHostKeyChecking=accept-new', '-o', 'User=ruud']
ruud@docker-02's password:
Pexpect result:
{'user_host_accept': None, 'user_host_password': '*********', 'user_key_password': None, 'output': 'xxh_home_realpath=/home/ruud/.xxh\r\nxxh_version=0.8.11\r\nxxh_shell_exists=1\r\nxxh_home_writable=1\r\nxxh_parent_home_writable=1\r\nrsync=\r\nscp=/usr/bin/scp\r\nshell=\r\nkernel=Linux\r\narch=x86_64\r\n'}
Host info:
xxh_home_realpath=/home/ruud/.xxh
xxh_version=0.8.11
xxh_shell_exists=1
xxh_home_writable=1
xxh_parent_home_writable=1
rsync=
scp=/usr/bin/scp
shell=
kernel=Linux
arch=x86_64

bash: /home/ruud/.xxh/.xxh/shells/xxh-shell-xonsh/build/xonsh-squashfs/usr/bin/usr/bin/python3.10: No such file or directory
Connection to docker-02 closed.

What is the problem
The python3.10 file is not found when trying to use xonsh shell. With fish shell everything works fine. The part /usr/bin inside /usr/bin does not exists. Is the path wrong or are the files missing?

For community:
⬇  Please click the 👍 reaction instead of leaving a +1 or 👍  comment

Duplicate of #21


Updates gromacs cygnet file for topaz

Rewritten most of it.

Cleanup
Added support for VMD plugin
Added cuda support.

Thanks Cristian.
Which Gromacs version have you used for testing?
How about putting a comment in the cygnet file mentioning that version?

Hi Marco, it is the latest, gromacs 2021.2! I will add a comment with the information.


cosidering large chunk？

Considering that llms support longer context, would it be more ideal if we change our document chunk scheme to segment by natural paragraphs instead of natural sentences (,)?

It can be a tricky problem to try to split the text into natural paragraphs because the format of each document is different. Currently, the feasible methods mainly involve extracting based on new lines/titles or using OCR layout analysis. The first rule-based approach might not be robust enough, while the second approach requires high computational and time-consuming, taking at least 1-2 seconds per page on consumer-level computers.
IncarnaMind leverages (1) small chunks to locate documents and (2) sliding windows to identify potential large chunks (you can consider the large chunks as sections) given the retrieved document filter. (3) Finally, retrieve medium-sized chunks from the filtered text by document name and large chunk indices to answer the user's questions using LLMs.
But, of course, you can define your own small, medium and large chunk size using the configparser.ini.
Please do not hesitate to contact me here or junruxiong@gmail, if you have any further concerns or suggestions!

thanks for your reply.
From my understanding, the industry is currently mostly using the first solution, but the future should belong to the second solution. As for the solution proposed by IncarnaMind, although it is very innovative, it inevitably introduces cluttered or missing information in the retrieve stage, which cannot be avoided no matter how the chunk size is adjusted. I don’t know how you think about this.

So my suggestion is to make small-chunk according to the principle of natural sentences, and then add a natural number parameter N, and the N sentences before and after the natural sentence are combined into medium-chunk...


Generates incorrect OTP for Onelogin 2FA

I successfully added my OneLogin 2FA. But 2fa OTP are not matching with OneLogin Protect App's OTP:
$ 2fa -add onelogin
2fa key for oneline:JQVMHTFQ8ESF

That secret JQVMHTFQ8ESF - which I hope you have revoked - contains an 8, making it not a valid base32 value. The base32 alphabet is "ABCDEFGHIJKLMNOPQRSTUVWXYZ234567" (case-insensitive), and usually TOTP keys are longer as well. Not sure what is going on, but that's not the right kind of input for 2fa.

Thanks for the clarification @rsc , I'll dig into OneLogin's TOTP implementaion.


[WIP] Integral Kernel Operator

This still has a lot to be done, but here is a working code. Here's a TODO list:

[x] single input-output
[ ] multiple input
[ ] multiple output
~[ ] GPU compatibility~ : Integrals.jl quadratures provide limited gpu capabilities
[ ] Passing tests for @inferred and @jet : Again, the issue seems to be because of some Integrals implementation
[ ] Float32 : For some reason, it takes infinitely long when the inputs are Float32
[ ] bias layer : Need to figure out if we can do it with already present Lux layers. Not really implemented in most works though would be good to add it
[ ] docstrings
[ ] Pretty printing

It took me a while to grasp how to implement the continuous version, aka Integral Kernel Operator, so I'll also put down what I've done.
The general form of NO is
\mathcal{G}_{\theta} = \mathcal{Q} \circ \sigma_T(W_{T-1} + \mathcal{K}_{T-1}+ b_{T-1}) \circ \dots \circ \sigma_1(W_0 + \mathcal{K}_0+ b_0) \circ \mathcal{P}

where
(\mathcal{K}_t(v_t))(x) = \int_{D_t} \kappa^{(t)}(x,y) v_t(y) dy \quad \forall x \in D_t

$\mathcal{P}$ and $\mathcal{Q}$ are local operators that lift and project. $W_t$ works similarly. Ignoring bias for now, for the continuous variant we'd want to be able to take inputs at any arbitrary points rather than fixed discretization, generally required by neural operators.
The role of $\mathcal{P}$ is to lift the input discretization to a higher-dimension space. For point functions, this would just be another function, approximated by a network. It'd thus give $\mathcal{P}(a(x))$ as output where $a(x)$ is the input. For a 1D input and a 1D output, the input should be just a single node.
$\mathcal{Q}_t \text{ and } W_t$ would also be constructed similarly, all three being networks that take input at one point and give an output at one point. As an example, they'd be
Chain(Dense(1 => 16), Dense(16 => 16), Dense(16 => 1))
Constructing the kernel $\mathcal{K}_t$ requires some efforts, but has been implemented by a network approximating $\kappa^{(t)}$ that takes in 2 inputs, one of them being the input point and the other that will be used to compute the integral. Since the integral is computed on the domain $D_t$, we'd also need to compute the domains to evaluate $\mathcal{K}_t$. Though not the best way, right now, I'm passing the boundary points of the domain through the previous layers and sort them to get the next domains. This should work fine if the activation functions are monotonically increasing/ decreasing, and and the maps $\mathcal{P}_t, \mathcal{Q}_t$ and $W_t$ being linear transformation. Though I am doubtful how well this'd hold for $\mathcal{K}_t$.
I thought for a while if we should use ExplicitLayers or ExplicitContainerLayers and settled for the later because we want to have the flexibility of using any network. These are implemented as CompactLuxLayers having the same functionality as ContainerLayers but concisely.
@avik-pal @ChrisRackauckas

Rebase with the latest changes to main.


[CLOSED] examples/successors make error

 Issue by aogrcs
Wednesday Nov 29, 2017 at 06:21 GMT
Originally opened as https://github.com/antalsz/hs-to-coq/issues/47

*** No rule to make target '../../base/GHC/Base.vo', needed by 'Control/Applicative/Successors.vo'.

 Comment by lastland
Wednesday Nov 29, 2017 at 15:11 GMT

Hi, you will need to run make in base first. Can you try, for example, make -C ../../base (or just cd to base, and then make)?

 Comment by aogrcs
Thursday Nov 30, 2017 at 11:58 GMT

I cd to base then I make, but I said that could not find ssreflect

 Comment by sweirich
Thursday Nov 30, 2017 at 13:59 GMT

Sorry about that. I just updated the toplevel README.md file with instructions to install ssreflect.

 Comment by aogrcs
Friday Dec 01, 2017 at 10:01 GMT

Just "opam install coq-mathcomp-ssreflect.1.6.1" worked, "opam install coq.8.6 coq-mathcomp-ssreflect.1.6.1" did not work, maybe caused by the opam source or the network. I also found the link
https://stackoverflow.com/questions/43955082/how-to-install-ssreflect-and-mathcomp-in-linux#
It did not set the coq version and installed coq 8.7, neither did it.
Thanks for your patient!

 Comment by aogrcs
Tuesday Dec 05, 2017 at 01:08 GMT

Yes, it did work, thanks

 Comment by sweirich
Monday Dec 04, 2017 at 14:31 GMT

Were you able to get it work?

 Comment by sweirich
Tuesday Dec 05, 2017 at 13:44 GMT

Ok, closing issue. Let us know if you have other questions!


Micro auto generate topic in kafka when run 1 service.

When I was create a service I see in kafka  auto generate topic but didn't data.
.
Can you tell me has option to turn off it.
Thanks

Hi, I'm not familiar with Kafka. maybe you should try to find the answer on the Kafka repo.