Installation issue with all versions tried

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
No

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Windows 10 17134.345

Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
N/A

TensorFlow installed from (source or binary):
Using pip install

TensorFlow version (use command below):
1.11-GPU
but error occurred when uninstalled and reinstalled with 1.8-GPU as well (slightly different one, noted below)

Python version:
3.6.0

Bazel version (if compiling from source):
N/A

GCC/Compiler version (if compiling from source):
N/A

CUDA/cuDNN version:
CUDA 9.0
cuDNN 7.0.5

GPU model and memory:
NVIDIA GTX 980M 8 GB memory

Exact command to reproduce:
py -c "import tensorflow as tf; print(tf.version.)"

Describe the problem
I have tried several times to install tensorflow with various versions but get the same DLL error and another issue with one of them
I tried searching for the issue, and found similar ones with no real answer.
One thing I have noticed from looking at those threads is that my "pywrap_tensorflow_internal", and perhaps other DLLs, are missing from    ....../site-packages/tensorflow/python.
Also
cudart64_90.dll' is stated to be missing when I use tensorflow-GPU 1.8
and when I check my cuda/bin folder I only see cudart64_7, so that makes sense.
I am not getting this error with 1.11, though, as you may note below.
This error seems simple but is frustrating me, and I would greatly appreciate all help in getting this done quickly, thanks!
Source code / logs
ERROR WITH 1.11:
C:\WINDOWS\system32>py -c "import tensorflow as tf;print(tf.version)"
Traceback (most recent call last):
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed: The specified module could not be found.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow_init_.py", line 22, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python_init_.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 74, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed: The specified module could not be found.
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/install_sources#common_installation_problems
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.
ERROR WITH 1.8:
C:\WINDOWS\system32>py -c "import tensorflow as tf;print(tf.version.)"
Traceback (most recent call last):
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\platform\self_check.py", line 75, in preload_check
ctypes.WinDLL(build_info.cudart_dll_name)
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\ctypes_init_.py", line 344, in init
self._handle = _dlopen(self._name, mode)
OSError: [WinError 126] The specified module could not be found
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow_init_.py", line 24, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python_init_.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 30, in
self_check.preload_check()
File "C:\Users\Josh\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\platform\self_check.py", line 82, in preload_check
% (build_info.cudart_dll_name, build_info.cuda_version_number))
ImportError: Could not find 'cudart64_90.dll'. TensorFlow requires that this DLL be installed in a directory that is named in your %PATH% environment variable. Download and install CUDA 9.0 from this URL: https://developer.nvidia.com/cuda-toolkit

I have updated what I tried and my errors, please look over my issue again and disregard the original post information!
Also, note that there are 2 traces provided, one time I tried tensorflow-gpu 1.11 and another I tried tensorflow-gpu 1.8.
I think I should be using 1.11, but I am willing to use whatever will work!
Again,
All help greatly appreciated!

@joshmorris23x You can follow the instructions in this link to install TensorFlow on Windows 10.

Closing this, feel free to reopen if running into additional errors.


Invariance tests

[x] implement invariance tests
[x] add invariance tests to CI

Initial prototyping: https://gist.github.com/JanCBrammer/00e8b3fe4c555bfb3eae6db8dec71a98.

Closing with 261682f1c3f4d45d6f159ae6d9bd259699ab18f8.


MAINT:sparse: expm() fix redundant imports

Since we are trying to reduce the cross-imports of modules, this one is a low-hanging fruit. The values are precomputed hence no need for expensive computations.

thanks


feat: change file name per index for avoid redundancy when calling up…

Improve code: Change name of the files for avoid redundancy when calling up files

check page is not working, but in dev branch works as expected, please check if you are importing something wrongly

@Israel-Laguan check page work without problems, you should can give more details about the error, please

@Israel-Laguan check page work without problems, you should can give more details about the error, please

Fixed the issues, no problem


whl compile error：suitable constructor exists to convert from "int" to "__half"

build wheel by fellowing steps
cd algorithm
python setup.py build

but i got above errors with **cuda 12.1 version** and conda python env **abq-llm** .
Can repo provide a docker file or image to avoid compile problem？

Hello, the code transformation of connecting ABQKernel to Torch and installing it using setup.py has not been completed yet, so the failure of setup.py is as expected.
If you want to test the kernel performance, please refer to the REAME Kernel benchmark and E2E benchmark sections to compile the source code.

Hello, the code transformation of connecting ABQKernel to Torch and installing it using setup.py has not been completed yet, so the failure of setup.py is as expected. If you want to test the kernel performance, please refer to the REAME Kernel benchmark and E2E benchmark sections to compile the source code.

i get it, i have another question, what's the main difference between bmma and wmma version of abq gemm kernel? wmma version use nvidia offical wmma wrapper in mma.h, and bmma version use customed wrapper for  ptx asm.  Is there any other difference?

The wmma instruction abstraction level is higher, which reduces the difficulty of calling TensorCore, but has the following problems:
1: Not all binary mma instructions are encapsulated into wmma. For example, bmma supports three shapes, but binary WMMA only supports <8,8,128> configuration;
2: wmma encapsulates the load_matrix and store_matrix operations, which prevents us from designing thread-level memory access in a refined manner (such as applying swizing strategies to avoid bankconflicts). This is the direct reason why we apply MMA optimization;
3: We want to use this open source project to show the open source community how core operators such as GEMM can perform WMMA and MMA level optimization. The two can be fully compared.


More info on How to use & Usecases

It makes a faster user experience possible, because there are generally lesser reloads and browser refreshes.

I get what the extension is build for, but I can't seem to understand how it works and how it actually makes user experience better.
Adding some screenshots and use cases to the documentation will help I guess.

Will do, thanks for the feedback @justvidyadhar :+1:

Looks good to me. You can go on to comprehensively explain about how it works in the README.
More the description, better for new devs to contribute. Someone might just port fastr as a Firefox plugin as well.
But generally this is a good place to start.

Cool, Thanks! Fastr has more than 6000 users now 🚀

Great going! 👍 😄


Bump marked from 0.6.3 to 0.7.0

Bumps marked from 0.6.3 to 0.7.0.

Release notes
Commits

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

IBM Cloud toolchain: Delivery Pipeline deployed sample-cloud-native-toolchain-tutorial-20210420020843361 to dev, including commit ee5c300120e064861c40be1af1974a7be4695a4b


statusBarTheme - transparent background

statusBarTheme - transparent background, is this possible?

what I want is the image in this issue: https://github.com/eclipsesource/tabris-js/issues/171
however, when I set displayMode:"fullscreen" the entire status bar disappears

It's impossible at the moment.

@patrykmol can you think of any workarounds for this, I don't mind using a plugin and working with the root UIView somehow
thanks, the solid statusbar is bugging me for an otherwise good looking map app :)

No, we would have to implement this as a feature. There's no way for you to change this. I will present issue on next planning meeting.

Colorizing the statusbar will be included in Tabris.js 2.0.

The background property on tabris.ui.statusBar supports colors with an alphachannel such as #00000033.


contributor and multiline answer fix

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy

...
...
...

Input given at the prompt

   ...

Response from the original model

  ...

Response from the fine-tuned model

  ...

Contribution checklist

[ ] The contribution was tested with ilab generate
[ ] No errors or warnings were produced by ilab generate
[ ] All commits are signed off (DCO)
[ ] The qna.yaml file contains at least 5 seed_examples
[ ] The qna.yaml file was linted and prettified (yaml-validator can do both)
[ ] An attribution.txt file in the same folder as the qna.yaml file
[ ] Content does not include PII or otherwise sensitive or confidential information
[ ] Content does not include anything documented in the project's Avoid these Topics guidelines

@mergifyio rebase

@dal0643 Please clean up your PR and rebase on the latest main. Your PR currently contains old commits which are not your taxonomy contribution.


Click-to-filter-by-presenter does not work anymore

Describe the bug
A clear and concise description of what you see:
Click-to-filter-by-presenter does not work anymore
To Reproduce
Steps to reproduce the behavior:

Go to https://picard.vm2.elan.codes/admin-ui/index.html
Log in (admin /opencast)
Click on a presenter in the "Presenter(s)" column
Nothing happens. In the old Angular.JS Admin UI, a filter was added for the presenter (although not shown, see opencast/opencast#3768  )

Old Angular.js Admin UI:
https://user-images.githubusercontent.com/2311611/178363340-6ac6410a-8344-4119-9c50-e3ce8189b740.mp4
New Picard Admin UI:
https://user-images.githubusercontent.com/2311611/178363297-5e8067d7-e3cd-47a1-9862-358bb472a392.mp4

it seems this has been addressed (although it does properly show, as described in the issue linked in the original post).
https://user-images.githubusercontent.com/14070005/218753645-846ada87-a114-40d0-91bb-53900506ce1d.webm


Spike: Get RTC proof-of-concept working with new electronics

overview
We'll be receiving new hardware prototypes that include a real-time clock on the main routing board. We need to figure out what we need to modify in order to get that RTC working with our system
acceptance criteria

[x] "OT-2" running with a real-time clock (proof-of-concept level functionality ok)
[ ] Implementation ticket in Opentrons/buildroot

notes

RTC model RV3028

Implementation ticket: https://github.com/Opentrons/buildroot/issues/108


The code seems to be unable to run

When I run generated_pairs.py separately with ’python -u src/all_models/generated_pairs.py --config_path configs/retrieved_data/pair_generation.json --dataset ecb --data_split train --out_dir retrieved_data/main‘, an error message will appear as follows: "FileNotFoundError: [Errno 2] No such file or directory: './models/ecb_events_seed5_original/candidate_generator_best_model'".
May I ask if you can provide this model file?

Hi, thanks for your attention.
This code repository is still under maintenance. We will continue to upload some codes and interpretations. Compared to before, we have made some adjustments to the file layout and some codes in the repo, and we provide links to trained bi-encoder models and retrieved/enhanced pairwise dataset in data_preparation. Please stay tuned for our latest version.
The core code of generated_pairs.py is based on Held's code. You are free to use it to generate data pairs on your own. However, we observe that it still has some indeterminacy so it may yield slightly different pairwise datasets. For more valid and deterministic experiments, we recommend using our fixed training set from the retrieved_data folder which can be downloaded from the provided link.
Best,
Daniel

Hi, thanks for your attention.
This code repository is still under maintenance. We will continue to upload some codes and interpretations. Compared to before, we have made some adjustments to the file layout and some codes in the repo, and we provide links to trained bi-encoder models and retrieved/enhanced pairwise dataset in data_preparation. Please stay tuned for our latest version.
The core code of generated_pairs.py is based on Held's code. You are free to use it to generate data pairs on your own. However, we observe that it still has some indeterminacy so it may yield slightly different pairwise datasets. For more valid and deterministic experiments, we recommend using our fixed training set from the retrieved_data folder which can be downloaded from the provided link.
Best, Daniel

Thanks for your reply.The model can train now.

Hi, thanks for your attention.
This code repository is still under maintenance. We will continue to upload some codes and interpretations. Compared to before, we have made some adjustments to the file layout and some codes in the repo, and we provide links to trained bi-encoder models and retrieved/enhanced pairwise dataset in data_preparation. Please stay tuned for our latest version.
The core code of generated_pairs.py is based on Held's code. You are free to use it to generate data pairs on your own. However, we observe that it still has some indeterminacy so it may yield slightly different pairwise datasets. For more valid and deterministic experiments, we recommend using our fixed training set from the retrieved_data folder which can be downloaded from the provided link.
Best, Daniel

May I ask if your training code (Python - u src/all_models/crossencoder_trainer. py) is also so slow?

Hi, thanks for your attention.
This code repository is still under maintenance. We will continue to upload some codes and interpretations. Compared to before, we have made some adjustments to the file layout and some codes in the repo, and we provide links to trained bi-encoder models and retrieved/enhanced pairwise dataset in data_preparation. Please stay tuned for our latest version.
The core code of generated_pairs.py is based on Held's code. You are free to use it to generate data pairs on your own. However, we observe that it still has some indeterminacy so it may yield slightly different pairwise datasets. For more valid and deterministic experiments, we recommend using our fixed training set from the retrieved_data folder which can be downloaded from the provided link.
Best, Daniel

May I ask if your training code (Python - u src/all_models/crossencoder_trainer. py) is also so slow?

Our experiments were on a single Nvidia Tesla V100. The training will take around half a day for the baseline model, and around a day for the enhanced model on ECB+.

Hi, thanks for your attention.
This code repository is still under maintenance. We will continue to upload some codes and interpretations. Compared to before, we have made some adjustments to the file layout and some codes in the repo, and we provide links to trained bi-encoder models and retrieved/enhanced pairwise dataset in data_preparation. Please stay tuned for our latest version.
The core code of generated_pairs.py is based on Held's code. You are free to use it to generate data pairs on your own. However, we observe that it still has some indeterminacy so it may yield slightly different pairwise datasets. For more valid and deterministic experiments, we recommend using our fixed training set from the retrieved_data folder which can be downloaded from the provided link.
Best, Daniel

May I ask if your training code (Python - u src/all_models/crossencoder_trainer. py) is also so slow?

Our experiments were on a single Nvidia Tesla V100. The training will take around a day for the baseline model, and around two days for the enhanced model on ECB+.

Thanks for your reply. I use an A100, which looks similar and takes about eight hours for the baseline model on ECB+.


Incorrect Image Base for 32-bit images on 64-bit version of Process Hacker

Describe the bug
When viewing an image properties for a 32-bit image (both EXEs and DLLs) on a 64-bit version of Process Hacker, the Image Base address is incorrect. The displayed value is the actual image base address (ImageBase) concatenated with the base of data element (BaseOfData) of ntdll!_IMAGE_OPTIONAL_HEADER.
To Reproduce
Steps to reproduce the behavior:

Open 64-bit version of Process Hacker
Identify a 32-bit process running (or launch a new one) and double click it in Process Hacker
Go to the Modules tab
Double click on any loaded module
The incorrect value is displayed in Image Base

Expected behavior
For 32-bit images, only 1 DWORD should be loaded for the Image Base (offset 0x1c from ntdll!_IMAGE_OPTIONAL_HEADER)
Screenshots

Selecting 32-bit process on a 64-bit version of Process Hacker

Incorrect image base address

Correct values as per Windbg
Desktop (please complete the following information):

OS: Windows
Version: Server 2019

Can you check if this is still an issue in the nightly builds?
Peviewer was completely redesigned and rewritten some time ago:
https://processhacker.sourceforge.io/nightly.php

Hi @dmex,
Just checked the nightly build and it is correct in both the General and the Headers tabs. Really cool new Peviewer! Any ideas when this will be integrated into the stable release?

Also, as a small suggestion, I would add BaseOfData in the Headers tab for completeness sake.
Thanks

integrated into the stable release?

There won't be any "stable" v3.x release for quite sometime from what I gathered browsing this issue tracker:
https://github.com/processhacker/processhacker/issues/649
https://github.com/processhacker/processhacker/issues/415

BaseOfData does exist, but it is commented out for 64 bit images right now (https://github.com/processhacker/processhacker/blob/master/tools/peview/peheaderprp.c#L625). I'm not sure why, @dmex could probably answer that.
@reubensammut since this is resolved in the nightly we could probably close this out.

I would add BaseOfData in the Headers tab for completeness sake.

It was added for 32bit images in the latest nightly build. jxy-s is correct that it doesn't exist for 64bit images.


Improve Turkish language

Improve Turkish language translations
Fix some syntax errors.
Wrap lines after 80 characters.

Thanks


BUG - ema_stacked filter does not work and loses value on Refresh

tried to fix it but could not figure it out

fixed index.html


Measure usage as proxy for number of deployments

Analytics code is what Google provided. The UA key is owned by the Open Data Kit account and @issa-tseng has read access.

does this have gdpr implications?

@issa-tseng I don't know. What we do now across all the tools is to document what data we collect at https://docs.opendatakit.org/security-privacy and I'll add some language there about Central if this PR is approved.
I've filed an issue at https://github.com/opendatakit/governance/issues/60 so can review our usage across the project and make the necessary changes. My bias is to merge this because this is no worse than current practice.
CC @lognaturel @matthew-white

well, i think if we do fall under gdpr then this is not a compliant solution, but it's not my problem to solve :)


Issue with Default Public Gateway on Firefox

Describe the bug
The browser threw and error instead of redirecting to my website when I try to use ipfs://. It seems to be making my ipfs hash all lowercase instead of keeping the uppercase letters.
Error Message
invalid ipfs path: invalid path "/ipfs/ipfs_hash": invalid CID: selected encoding not supported (possible lowercased CIDv0; consider converting to a case-agnostic CIDv1, such as base32)
Expected behavior
The browser should have redirected to my website.
Desktop (please complete the following information):

OS: Windows 10
Browser: Firefox
Version: 89

Thank you for reporting this, see https://github.com/ipfs/ipfs-companion/issues/1006#issuecomment-859581056


Wrong with text blocks when selecting Norwegian language

When I'm selecting the Norwegian language the text blocks are not there, as shown below:

Only 2 blocks are shown.  The menu is in fact "destroyed".

I also found the same problem in the polish language.


"ConnectException Failed to connect to server" ONLY on iOS with 4G/5G

First I want to thank you for the dev expierence with livekit, it is really awesome. This project is going to huge. :)
My issue is, It just won't connect on iOS with celluar, works fine in every other scenario.
Very strange is that, there is a small chance for it to work, but only after a fresh start of the app. But this happend only 2 or 3 times out of 50-60 trails.
At first I thought that it was an issue withe the celluar provider (telekom) doing IPv6 only, but changing to regular dual-stack did not solve the issue, and also everything was fine when the IPv6 only uplink was used by other devices via hotspot.
Versions:
flutter_client 0.5.9
iOS 15.4.1
What did I test:
LiveKit Connection Test is fine on all devices under all circumstances.
React Example App in Safari on the iPhone with 4G/5G connection ---> OK
React Example App in Safari on the iPhone with Wifi ---- OK
Flutter Example App on Android Mi A2 with Wifi but from the 4G/5G iPhone hotspot --> OK
Flutter Example App on Android Mi A2 Wifi --> OK
Flutter Example App on MacOS with Wifi or Ethernet -> OK
Flutter Example App on MacOS with Wifi but from the 4G/5G iPhone hotspot -> OK
Flutter Example App on iPhone with Wifi --> OK
Flutter Example App on iPhone with Wifi but 4G uplink from another Androids phone hotspot --> OK
Flutter Example App on iPhone with 4G/5G  -->  ConnectException Failed to connect to server :(
Steps to reproduce:
use example app on iphone with 4G/5G
server URLwss://live.  txxhexxraxxpy-lxxixxft.net   (without the xxs because SEO ...)
token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJleHAiOjE2NTQ3ODY4NTAsImlzcyI6IkFQSWFlb0JFeENOdG5CUyIsIm5iZiI6MTY1MjE5NDg1MCwic3ViIjoic2wiLCJ2aWRlbyI6eyJyb29tIjoidGVzdDAxIiwicm9vbUpvaW4iOnRydWV9fQ.7m6xVj3UFXIZfAucgqLjziZEefuX8ZLmgAMPYnEAWVE
I have attached server and flutter logs, for success and failure cases.
flutter_FAIL.txt
flutter_SUCCESS.txt
server_FAIL.txt
server_SUCCESS.txt

@rokk4 thank you for the detailed bug report. which version of the server are you running? Do you have a TURN server set up as well?

@davidzhao thanks for the reply. :)
LiveKit-Server Version is 0.15.7.
Yes, it is using the integrated TURN server.
What I find especially strange is, that the React Example App is working perfectly, so I have the feeling that this is not a issue coming from the server, but something in the the native iOS part of the client.

I am seeing the same when I am connecting via flutter client on 4G as well as wifi on Android. The server says
2022-07-20T07:14:00.600Z	ERROR	livekit.turn	v2@v2.0.8/server.go:184error when handling datagram: failed to handle Allocate-request from <IP_ADDRESS>:44386: integrity check failed github.com/pion/turn/v2.(*Server).readLoop 	/go/pkg/mod/github.com/pion/turn/v2@v2.0.8/server.go:184 github.com/pion/turn/v2.NewServer.func1 	/go/pkg/mod/github.com/pion/turn/v2@v2.0.8/server.go:85

The issue is still there in Server Version 1.2.5 and flutter-client-sdk Version.
Now I have seen the following in the logs.
caddy_1    | {"level":"error","ts":1666775017.8042235,"logger":"layer4","msg":"handling connection","error":"remote error: tls: unknown certificate authority"}
during the iOS Mobile connection scenario.
Also this looks interesting:
livekit_1  | 2022-10-26T09:04:26.997Z   INFO    livekit rtc/participant.go:521  participant closing     {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "sendLeave": true, "reason": "PEER_CONNECTION_DISCONNECTED"}
livekit_1  | 2022-10-26T09:04:26.997Z   INFO    livekit rtc/participant_signal.go:180   could not send message to participant   {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "message": "*livekit.SignalResponse_Leave", "error": "no response sink"}
livekit_1  | 2022-10-26T09:04:26.998Z   DEBUG   livekit rtc/participant.go:1091 updating participant state      {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "state": "DISCONNECTED"}
livekit_1  | 2022-10-26T09:04:26.999Z   DEBUG   livekit rtc/room.go:246 participant state changed       {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "state": "DISCONNECTED", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "oldState": "JOINED"}
livekit_1  | 2022-10-26T09:04:26.999Z   INFO    livekit rtc/room.go:403 closing participant for removal {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "pID": "PA_SPA9S9V6sHUK", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc"}
livekit_1  | 2022-10-26T09:04:26.999Z   INFO    livekit rtc/participant.go:521  participant closing     {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "sendLeave": true, "reason": "STATE_DISCONNECTED"}
livekit_1  | 2022-10-26T09:04:27.000Z   DEBUG   livekit rtc/transport.go:1203   leaving events processor        {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER"}
livekit_1  | 2022-10-26T09:04:27.000Z   INFO    livekit.ice     v2@v2.2.11/agent.go:562 Setting new connection state: Closed    {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER"}
livekit_1  | 2022-10-26T09:04:27.000Z   INFO    livekit rtc/transport.go:438    ice gathering state change      {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER", "state": "closed"}
livekit_1  | 2022-10-26T09:04:27.000Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:490        peer connection state changed: closed   {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER"}
livekit_1  | 2022-10-26T09:04:27.000Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:476        ICE connection state changed: closed    {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER"}
livekit_1  | 2022-10-26T09:04:27.000Z   INFO    livekit rtc/transport.go:472    ice connection state change     {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER", "state": "closed"}
livekit_1  | 2022-10-26T09:04:27.000Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:2223       Failed to start manager: connecting canceled by caller  {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER"}
livekit_1  | 2022-10-26T09:04:27.001Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:1456       Failed to start SCTP: DTLS not established      {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER"}
livekit_1  | 2022-10-26T09:04:27.001Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:1653       undeclaredMediaProcessor failed to open SrtcpSession: the DTLS transport has not started yet    {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER"}
livekit_1  | 2022-10-26T09:04:27.001Z   INFO    livekit rtc/transport.go:485    peer connection state change    {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER", "state": "closed"}
livekit_1  | 2022-10-26T09:04:27.001Z   DEBUG   livekit rtc/transport.go:1203   leaving events processor        {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER"}
livekit_1  | 2022-10-26T09:04:27.001Z   INFO    livekit.ice     v2@v2.2.11/agent.go:562 Setting new connection state: Closed    {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER"}
livekit_1  | 2022-10-26T09:04:27.001Z   INFO    livekit rtc/transport.go:438    ice gathering state change      {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER", "state": "closed"}
livekit_1  | 2022-10-26T09:04:27.001Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:490        peer connection state changed: closed   {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER"}
livekit_1  | 2022-10-26T09:04:27.001Z   INFO    livekit rtc/transport.go:485    peer connection state change    {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER", "state": "closed"}
livekit_1  | 2022-10-26T09:04:27.002Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:1615       undeclaredMediaProcessor failed to open SrtpSession: the DTLS transport has not started yet     {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "PUBLISHER"}
livekit_1  | 2022-10-26T09:04:27.002Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:476        ICE connection state changed: closed    {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER"}
livekit_1  | 2022-10-26T09:04:27.002Z   INFO    livekit rtc/transport.go:472    ice connection state change     {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER", "state": "closed"}
livekit_1  | 2022-10-26T09:04:27.002Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:2223       Failed to start manager: connecting canceled by caller  {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER"}
livekit_1  | 2022-10-26T09:04:27.002Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:1456       Failed to start SCTP: DTLS not established      {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER"}
livekit_1  | 2022-10-26T09:04:27.002Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:1653       undeclaredMediaProcessor failed to open SrtcpSession: the DTLS transport has not started yet    {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER"}
livekit_1  | 2022-10-26T09:04:27.002Z   INFO    livekit.pc      v3@v3.1.47/peerconnection.go:1615       undeclaredMediaProcessor failed to open SrtpSession: the DTLS transport has not started yet     {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH", "participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "remote": false, "transport": "SUBSCRIBER"}
livekit_1  | 2022-10-26T09:04:27.046Z   INFO    livekit service/roommanager.go:437      RTC session finishing   {"participant": "3e53752e-16d1-4434-9afb-69327a5175cc", "pID": "PA_SPA9S9V6sHUK", "room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH"}
livekit_1  | 2022-10-26T09:04:55.644Z   INFO    livekit rtc/room.go:556 closing room    {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH"}
livekit_1  | 2022-10-26T09:04:55.644Z   INFO    livekit service/roommanager.go:110      deleting room state     {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc"}
livekit_1  | 2022-10-26T09:04:55.645Z   INFO    livekit service/roommanager.go:405      room closed     {"room": "1054ad53-b186-4bce-881b-57c80ac457a4-3e53752e-16d1-4434-9afb-69327a5175cc", "roomID": "RM_tgHrWpBeyjGH"

So all of this seems to be point into TLS problems.
I am using the normal an most up to date configuration for VM-Deployments for Caddy and everything else works fine.
I have stumbled upon some information that iOS can be strange if no full-chain.pem of LE-Certs is served, i think live-kit-caddy does not serve it this way, or does it?
Does somebody have a idea and/or any suggestions how I can debug/investigate this further?
Any more logs I could provide or something? @davidzhao

@vishal-android-freak  Did you solve the issue?
@cloudwebrtc Do you have any idea what could be going on?

@rokk4 When you connect to the client under 4G/5G, have you configured the turn/stun server, and what is the local ice candidate? According to the log, it should be that ice is not connected successfully

@cloudwebrtc
Sorry for the late reply, I was on a longer vacation.
The Issue was caused by Lets Encrypt Certs, there seem to be the same problems over at Matrix and Jitisi.
I switched to using ZeroSSL Certs and now the Problem is not occuring anymore.
Here are some ressources:

https://github.com/vector-im/element-android/issues/1533
https://github.com/coturn/coturn/issues/240
https://github.com/jitsi/jitsi-meet/issues/6383
https://bugs.chromium.org/p/webrtc/issues/detail?id=11710
https://github.com/vector-im/element-ios/issues/5354
[/quote]

I would recommend to add a hint about LE-Cert issues and the ZeroSSL workaround to the LiveKit docs. @davidzhao
This is the Caddy Config to make it work:
´´´yaml
logging:
logs:
default:
level: INFO
storage:
"module": "file_system"
"root": "/data"
apps:
tls:
certificates:
automate:
- live.my.tld
- live-turn..my.tld
automation:
policies:
- issuers:
- module: zerossl
api_key:
apikey:  SUPERSECRETZEROSSLAPIKEY
layer4:
servers:
main:
listen: [":443"]
routes:
- match:
- tls:
sni:
- "live-turn..my.tld
handle:
- handler: tls
- handler: proxy
upstreams:
- dial: ["xxx.xxx.xxx.xxx:5349"]
- match:
- tls:
sni:
- "live.my.tldt"
handle:
- handler: tls
connection_policies:
- alpn: ["http/1.1"]
- handler: proxy
upstreams:
- dial: ["localhost:7880"]
´´´
Thank you a lot for your support.
LiveKit is an amazing project.

@rokk4 Thanks for pointing this out. we'll include a note with our generated configs. and perhaps make ZeroSSL an option

hi @rokk4, I have similar issue like you when call with 4G IOS. I try to use ZeroSSL but some errors below make me confused, can you take a look?
Thank you!
{"level":"info","ts":1717154425.775762,"msg":"using provided configuration","config_file":"/etc/caddy.yaml","config_adapter":"yaml"}
{"level":"info","ts":1717154425.7809727,"logger":"admin","msg":"admin endpoint started","address":"localhost:2019","enforce_origin":false,"origins":["//localhost:2019","//[::1]:2019","//<IP_ADDRESS>:2019"]}
{"level":"info","ts":1717154425.781958,"logger":"tls.cache.maintenance","msg":"started background certificate maintenance","cache":"0xc0008bacb0"}
{"level":"info","ts":1717154425.7833536,"logger":"tls","msg":"cleaning storage unit","description":"FileStorage:/data"}
{"level":"info","ts":1717154425.7837512,"msg":"autosaved config (load with --resume flag)","file":"/root/.config/caddy/autosave.json"}
{"level":"info","ts":1717154425.7837746,"msg":"serving initial configuration"}
{"level":"info","ts":1717154425.7843382,"logger":"tls","msg":"finished cleaning storage units"}
{"level":"info","ts":1717154425.7854617,"logger":"tls.obtain","msg":"acquiring lock","identifier":"my-domain.com"}
{"level":"info","ts":1717154425.7921257,"logger":"tls.obtain","msg":"lock acquired","identifier":"my-domain.com"}
{"level":"info","ts":1717154425.7926617,"logger":"tls.obtain","msg":"obtaining certificate","identifier":"my-domain.com"}
{"level":"info","ts":1717154425.7945986,"logger":"tls.issuance.zerossl","msg":"waiting on internal rate limiter","identifiers":["my-domain.com"],"ca":"https://acme.zerossl.com/v2/DV90","account":""}
{"level":"info","ts":1717154425.794646,"logger":"tls.issuance.zerossl","msg":"done waiting on internal rate limiter","identifiers":["my-domain.com"],"ca":"https://acme.zerossl.com/v2/DV90","account":""}
{"level":"info","ts":1717154427.9022255,"logger":"tls.issuance.zerossl.acme_client","msg":"trying to solve challenge","identifier":"my-domain.com","challenge_type":"http-01","ca":"https://acme.zerossl.com/v2/DV90"}

hi @rokk4, I have similar issue like you when call with 4G IOS. I try to use ZeroSSL but some errors below make me confused, can you take a look? Thank you!
{"level":"info","ts":1717154425.775762,"msg":"using provided configuration","config_file":"/etc/caddy.yaml","config_adapter":"yaml"}
{"level":"info","ts":1717154425.7809727,"logger":"admin","msg":"admin endpoint started","address":"localhost:2019","enforce_origin":false,"origins":["//localhost:2019","//[::1]:2019","//<IP_ADDRESS>:2019"]}
{"level":"info","ts":1717154425.781958,"logger":"tls.cache.maintenance","msg":"started background certificate maintenance","cache":"0xc0008bacb0"}
{"level":"info","ts":1717154425.7833536,"logger":"tls","msg":"cleaning storage unit","description":"FileStorage:/data"}
{"level":"info","ts":1717154425.7837512,"msg":"autosaved config (load with --resume flag)","file":"/root/.config/caddy/autosave.json"}
{"level":"info","ts":1717154425.7837746,"msg":"serving initial configuration"}
{"level":"info","ts":1717154425.7843382,"logger":"tls","msg":"finished cleaning storage units"}
{"level":"info","ts":1717154425.7854617,"logger":"tls.obtain","msg":"acquiring lock","identifier":"my-domain.com"}
{"level":"info","ts":1717154425.7921257,"logger":"tls.obtain","msg":"lock acquired","identifier":"my-domain.com"}
{"level":"info","ts":1717154425.7926617,"logger":"tls.obtain","msg":"obtaining certificate","identifier":"my-domain.com"}
{"level":"info","ts":1717154425.7945986,"logger":"tls.issuance.zerossl","msg":"waiting on internal rate limiter","identifiers":["my-domain.com"],"ca":"https://acme.zerossl.com/v2/DV90","account":""}
{"level":"info","ts":1717154425.794646,"logger":"tls.issuance.zerossl","msg":"done waiting on internal rate limiter","identifiers":["my-domain.com"],"ca":"https://acme.zerossl.com/v2/DV90","account":""}
{"level":"info","ts":1717154427.9022255,"logger":"tls.issuance.zerossl.acme_client","msg":"trying to solve challenge","identifier":"my-domain.com","challenge_type":"http-01","ca":"https://acme.zerossl.com/v2/DV90"}

Looks normal to me. What happens after the challange? Did you replace my-domain.com or is this the actual output? Because that would say the the domain is not set correctly I guess.

Thanks for your response! my-domain.com in above logs I have replaced.
I have updated to newer version of caddy (v2.8.1). And new errors come:
{"level":"info","ts":1717412941.6063242,"logger":"tls.obtain","msg":"obtaining certificate","identifier":"turnchat.pancake.vn"}
{"level":"info","ts":1717412941.6072705,"logger":"tls.issuance.zerossl","msg":"creating certificate","identifiers":["turnchat.pancake.vn"]}
{"level":"info","ts":1717412942.9589767,"logger":"tls.obtain","msg":"obtaining certificate","identifier":"video.pancake.vn"}
{"level":"info","ts":1717412942.9598875,"logger":"tls.issuance.zerossl","msg":"creating certificate","identifiers":["video.pancake.vn"]}
{"level":"info","ts":1717412944.5642345,"logger":"tls.issuance.zerossl","msg":"created certificate","identifiers":["turnchat.pancake.vn"],"cert_id":"bd60abc3077f80f689d93b32d315023d"}
{"level":"info","ts":1717412944.5652514,"logger":"tls.issuance.zerossl","msg":"validating identifiers","identifiers":["turnchat.pancake.vn"],"cert_id":"bd60abc3077f80f689d93b32d315023d","verification_method":"HTTP_CSR_HASH"}
{"level":"info","ts":1717412944.8363333,"logger":"tls.issuance.zerossl","msg":"created certificate","identifiers":["video.pancake.vn"],"cert_id":"17423b951963093e86c274f8483f9af5"}
{"level":"info","ts":1717412944.8373754,"logger":"tls.issuance.zerossl","msg":"validating identifiers","identifiers":["video.pancake.vn"],"cert_id":"17423b951963093e86c274f8483f9af5","verification_method":"HTTP_CSR_HASH"}
{"level":"info","ts":1717412945.828761,"logger":"tls.issuance.zerossl","msg":"canceled certificate","identifiers":["turnchat.pancake.vn"],"cert_id":"bd60abc3077f80f689d93b32d315023d","verification_method":"HTTP_CSR_HASH"}
{"level":"error","ts":1717412945.8288171,"logger":"tls.obtain","msg":"could not get certificate from issuer","identifier":"turnchat.pancake.vn","issuer":"zerossl","error":"verifying identifiers: POST https://api.zerossl.com/certificates/bd60abc3077f80f689d93b32d315023d/challenges?access_key=redacted: HTTP 200: API error 0: domain_control_validation_failed (details=map[turnchat.pancake.vn:map[http://turnchat.pancake.vn/.well-known/pki-validation/EEB6CD0CAA256FB76E4BCB825059E916.txt:{{0 0   } {0 true bad_response_code Server responded with status code: 404 (200 expected)}}]]) (raw={\"success\":false,\"error\":{\"code\":0,\"type\":\"domain_control_validation_failed\",\"details\":{\"turnchat.pancake.vn\":{\"http:\\/\\/turnchat.pancake.vn\\/.well-known\\/pki-validation\\/EEB6CD0CAA256FB76E4BCB825059E916.txt\":{\"file_found\":0,\"error\":true,\"error_slug\":\"bad_response_code\",\"error_info\":\"Server responded with status code: 404 (200 expected)\"}}}}} decode_error=json: unknown field \"success\")"}
{"level":"error","ts":1717412945.828925,"logger":"tls.obtain","msg":"will retry","error":"[turnchat.pancake.vn] Obtain: verifying identifiers: POST https://api.zerossl.com/certificates/bd60abc3077f80f689d93b32d315023d/challenges?access_key=redacted: HTTP 200: API error 0: domain_control_validation_failed (details=map[turnchat.pancake.vn:map[http://turnchat.pancake.vn/.well-known/pki-validation/EEB6CD0CAA256FB76E4BCB825059E916.txt:{{0 0   } {0 true bad_response_code Server responded with status code: 404 (200 expected)}}]]) (raw={\"success\":false,\"error\":{\"code\":0,\"type\":\"domain_control_validation_failed\",\"details\":{\"turnchat.pancake.vn\":{\"http:\\/\\/turnchat.pancake.vn\\/.well-known\\/pki-validation\\/EEB6CD0CAA256FB76E4BCB825059E916.txt\":{\"file_found\":0,\"error\":true,\"error_slug\":\"bad_response_code\",\"error_info\":\"Server responded with status code: 404 (200 expected)\"}}}}} decode_error=json: unknown field \"success\")","attempt":5,"retrying_in":600,"elapsed":619.307460524,"max_duration":2592000}
{"level":"info","ts":1717412946.8676581,"logger":"tls.issuance.zerossl","msg":"canceled certificate","identifiers":["video.pancake.vn"],"cert_id":"17423b951963093e86c274f8483f9af5","verification_method":"HTTP_CSR_HASH"}
{"level":"error","ts":1717412946.8677192,"logger":"tls.obtain","msg":"could not get certificate from issuer","identifier":"video.pancake.vn","issuer":"zerossl","error":"verifying identifiers: POST https://api.zerossl.com/certificates/17423b951963093e86c274f8483f9af5/challenges?access_key=redacted: HTTP 200: API error 0: domain_control_validation_failed (details=map[video.pancake.vn:map[http://video.pancake.vn/.well-known/pki-validation/2F5B7B85C16297392C6803FA6C94BE35.txt:{{0 0   } {0 true bad_response_code Server responded with status code: 404 (200 expected)}}]]) (raw={\"success\":false,\"error\":{\"code\":0,\"type\":\"domain_control_validation_failed\",\"details\":{\"video.pancake.vn\":{\"http:\\/\\/video.pancake.vn\\/.well-known\\/pki-validation\\/2F5B7B85C16297392C6803FA6C94BE35.txt\":{\"file_found\":0,\"error\":true,\"error_slug\":\"bad_response_code\",\"error_info\":\"Server responded with status code: 404 (200 expected)\"}}}}} decode_error=json: unknown field \"success\")"}
{"level":"error","ts":1717412946.8678486,"logger":"tls.obtain","msg":"will retry","error":"[video.pancake.vn] Obtain: verifying identifiers: POST https://api.zerossl.com/certificates/17423b951963093e86c274f8483f9af5/challenges?access_key=redacted: HTTP 200: API error 0: domain_control_validation_failed (details=map[video.pancake.vn:map[http://video.pancake.vn/.well-known/pki-validation/2F5B7B85C16297392C6803FA6C94BE35.txt:{{0 0   } {0 true bad_response_code Server responded with status code: 404 (200 expected)}}]]) (raw={\"success\":false,\"error\":{\"code\":0,\"type\":\"domain_control_validation_failed\",\"details\":{\"video.pancake.vn\":{\"http:\\/\\/video.pancake.vn\\/.well-known\\/pki-validation\\/2F5B7B85C16297392C6803FA6C94BE35.txt\":{\"file_found\":0,\"error\":true,\"error_slug\":\"bad_response_code\",\"error_info\":\"Server responded with status code: 404 (200 expected)\"}}}}} decode_error=json: unknown field \"success\")","attempt":5,"retrying_in":600,"elapsed":620.346353915,"max_duration":2592000}


pipr: 0.0.15 -> 0.0.16; fixes build

Motivation for this change
2nd version of https://github.com/NixOS/nixpkgs/pull/144884
ZHF: #144627
Fixes: https://github.com/elkowar/pipr/issues/6
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build pipr

Result of nixpkgs-review pr 144891 run on x86_64-linux 1

1 package built:

pipr

Result of nixpkgs-review pr 144891 run on x86_64-linux 1

1 package built:

pipr

Result of nixpkgs-review pr 144891 run on x86_64-darwin 1
1 package marked as broken and skipped:
Huh... Strange that this package is marked as broken on macOS thinking . Not seeing anything in the code.

Ah ok, it is a dependency:
nix-build -A pipr
error: Package ‘libcap-2.49’ in /Users/thiagoko/Projects/nixpkgs/pkgs/os-specific/linux/libcap/default.nix:59 is not supported on ‘x86_64-darwin’, refusing to evaluate.

       a) To temporarily allow packages that are unsupported for this system, you can use an environment variable
          for a single invocation of the nix tools.

            $ export NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1

       b) For `nixos-rebuild` you can set
         { nixpkgs.config.allowUnsupportedSystem = true; }
       in configuration.nix to override this.

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
         { allowUnsupportedSystem = true; }
       to ~/.config/nixpkgs/config.nix.
(use '--show-trace' to show detailed location information)


UI: selection box for freesurfer regions of interest is bonkers

Problem
The selection box is impossibly hard to use to select more than one item, or use at all really.
Tasks

fix dat trash

Emailed Jess for feedback on solution. Haven't heard back yet.

Also, add an 'all' selection to run against all regions.

Heard from Jess, she likes the new UI.


enhancement Make stats cache item size configurable

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.18 seconds
stream load tsv:          426 seconds loaded<PHONE_NUMBER>9 Bytes, about 167 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          6.6 seconds inserted 5,000,000 Rows, about 757K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230505040856_clickbench_pr_138406.html

run buildall

run buildall

run buildall


Issue from website page Flutter for Web开发者

From URL: https://www.flutterchina.club/web-analogs.md .     如何动态向Row中添加子widget

That is a community website not maintained by the Flutter team. Try https://github.com/flutterchina/website/issues


fix: close dialog after logging out

My PR fixes issue #644
FIX: close dialog after logging out.

@malakbenr please follow the PR template given and fill it properly


Implement optically assisted alignment

Performing telescope alignment, even with Celestron's SkyAlign, is slow and tedious. One of the challenges to achieve excellent alignment is centering the target in the field of view. Besides being difficult to get the object exactly centered in an eyepiece, for best alignment each object must be approached from the same slew direction in both azimuth and elevation due to backlash. Both of these challenges could be made easier via some computer vision assistance.
Once the alignment star is manually brought within the camera's field of view, optical tracking can be used to center it perfectly in the camera frame. To ensure that the target is always approached from the same slew direction the algorithm could first move the target to one corner of the frame and then move it (slowly) to center. Care must be taken to ensure that any control loop used in this solution does not overshoot on the final approach to the target. Another idea is to disallow slewing in the wrong direction on final approach to the target.
After the computer vision algorithm centers the object in the frame, the user continues the alignment using the hand controller. The serial command interface to the hand controller does not permit further automation of alignment. Full alignment automation will require eliminating the hand controller from the alignment solution which is beyond the scope of this issue.

Dealing with backlash is actually more complicated than I first thought because the object will be moving in the FOV due to sidereal motion. I think this can be broken into three cases:

Object apparent motion is in the same direction as approach direction in both axes. This is the simplest case to handle because the object can be tracked optically with the normal control loop to keep it centered in the FOV indefinitely until the user presses the Align button on the hand controller. No special compensation for backlash required because the mount will already be slewing in the correct direction.
Apparent motion is with approach direction in one axis but against in the other axis. In this case the tracking loop could continue running normally on the first axis. For the other axis, the object could be moved to one side of the frame and then the mount should slew in the approach direction for at least the backlash amount. This could either be detected

If the sidereal motion happens to be in the same direction as the approach then the software can just track it optically like normal to keep it centered. However if the object is moving against the approach direction in either axis then normal optical tracking won't work. Moving the target to one corner and then slowly to center might work but the apparent motion of the object must also be taken into account. What might work

The initial implementation is complete and basic testing was performed for all three cases. Further refinements if required will be captured under new issues.


RFC: Explore alternatives to libxml2 for HTML parsing

Background
libxml2 supports parsing of HTML4. But the most popular browsers have moved on to HTML5 and exhibit different behavior than libxml2 when parsing documents, particularly when fixing up broken markup and when interpreting comments, but also for a bunch of edge cases that the WHATWG makes non-normative recommendations on how to handle.

WHATWG recommendations: https://html.spec.whatwg.org/multipage/parsing.html
One example of a dangerous difference in behaviors: https://github.com/sparklemotion/nokogiri/pull/2058
Another example of a dangerous difference in behaviors: https://bugzilla.gnome.org/show_bug.cgi?id=769760

where "dangerous" means, basically, "vector for an XSS attack".
Why libxml2 isn't likely to get better at HTML5
The libxml2 code base is positively ancient by HTML5 time scales, and it would be challenging to update it to handle new tags, new allowed attributes, WHATWG parsing recommendations, and potentially other things I haven't even thought of. So it's very understandable that the libxml2 maintainers haven't really expressed an interest, or have expressed a disinterest, in updating the library.

Comment by libxml2 maintainer: "it's still a bad idea to use a 20+ years old, unmaintained HTML 4 parser to sanitize input for the modern web" (1)

https://bugzilla.gnome.org/show_bug.cgi?id=769760#c4

Comment by the same libxml2 maintainer in a different issue: "some of my changes also made libxml2 more aligned with HTML5. But it's still a really bad idea to sanitize HTML with libxml2. Almost every divergence from the HTML5 parsing rules can be abused to hide malicious content. For example ..." (2)

https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/82#note_886120

This is totally fine! libxml2 does what it does well, which is parsing XML 1.0 and HTML 4.0, and we shouldn't throw any shade their way for steadfastly maintaining a successful and stable OSS project. Thank you, libxml2 maintainers, for doing an amazing job.
Users are asking for HTML5 support
But just because libxml2 can't do the job doesn't mean the job isn't important. Look at this search for HTML5-related issues reported on Nokogiri! This is evidence that Nokogiri is losing relevance as more of the world moves to HTML5.
Alternatives
Nokogumbo
The awesome Nokogumbo project was created to help: it uses the Gumbo parser to parse HTML5 documents, then transmogrifies the Gumbo document structure into the libxml2 document structure so that the rest of Nokogiri can be used to manipulate and serialize the doc. This is amazing!
Unfortunately, the Gumbo parser isn't well-maintained outside of the Nokogumbo project, which is continuing to make updates to their vendored fork of the codebase. But does that matter if HTML5 is relatively static? We should have a conversation about it.
Another interesting thing is that Nokogumbo is compiling the Gumbo codebase (just like Nokogiri is compiling the libxml2/libxslt codebases) at installation time. If we made Nokogumbo a dependency of Nokogiri, that would make some of our users Even More Unhappy with installation times of their tech stack.
We could share Nokogiri's approach for building precompiled windows libraries (and soon-to-ship precompiled linux libraries and hopefully someday precompiled Darwin/OSX libraries) with the Nokogumbo team, but that still wouldn't help our JRuby friends, who depend on Nokogiri bundling NekoHTML (btw also not-well-maintained). Or maybe we could discuss merging the two projects together? (Nokogiri and Nokogumbo). I'm going to tag a few Nokogumbo folks to see what they think.
Another parsing library
Other options I've briefly looked at:

Gecko:Overview - MozillaWiki

gecko-dev/parser/html at master · mozilla/gecko-dev
HTML parser threading - Mozilla | MDN

Blink (browser engine) - Wikipedia

DOM
How Blink works - Google Docs
Blink (Rendering Engine) - The Chromium Projects
third_party/blink/renderer/core/html/parser/html_document_parser.h - chromium/src - Git at Google

But we'd be starting from scratch in trying to wrap these up, and that feels like potentially a huge time sink.
Timelines
I'm tagging this for the v1.12.0 milestone for a few reasons:

v1.11.0 is already really dragging and I don't want to add scope to it
v1.11.0 should have precompiled binaries for all the major platforms (including OSX if we're lucky) which would be very useful when tackling adding another parser codebase for HTML5

So, to sum up and rephrase the broad strokes of the roadmap:

v1.11.0 is focused on shipping precompiled libraries to improve installation time and decrease installation issues for users
v1.12.0 would be focused on expanding the breadth of parsing functionality to include HTML5

Comments welcome.

Tagging @stevecheckoway, @craigbarnes, and @rubys for awareness that I've been thinking about this, and to potentially discuss how the projects can work closer and better together in the future!
Tagging @tenderlove and @ptoomey3 because we were just on the twitters talking about this.

I'm glad you're thinking about this!
One problem is that HTML 5 isn't static. It's a living standard and the parsing steps have undergone changes during the time I've been working on Nokogumbo. I spent a while updating Gumbo to match the standard and added extensive unit tests. I tried to test every case in the spec. That was a nightmare; I'm sure I missed some. Since that point, the standard has changed again (I think). Some HTML elements have been deprecated, for example.
I've given thought to trying to parse the standard itself and generate code for the tokenization and tree-building state machines, but that's a pretty big project and I definitely don't have time for it.

@stevecheckoway Well, today I learned how much the HTML5 spec is changing over time. Thank you for the effort and for making Nokogumbo such great software!
I guess one advantage of moving to a fully-maintained parser like Gecko's or Blink's is that we wouldn't have to go through that work. Maybe that's worth looking into as an alternative?
I had an email conversation with @rubys in Nov 2010 about potentially using validator.nu for HTML5 parsing ... it's Java (which we could use to replace NekoHTML in the JRuby implementation) and can generate C++ code (which is what Gecko's HTML parser is based on) meaning the JRuby and CRuby behaviors would be identical.
CCing @hsivonen who I'm sure has thought deeply about ideas like this over the years, in case he's interested in following along or dropping some knowledge.

Back in 2010 my plan was to generate a non-Gecko C++ version of the Validator.nu HTML Parser. That ended up not happening due to tasks that were of higher priority to Mozilla.
Instead @rubys added a to use the Validator.nu HTML Parser from Ruby via gcj. gcj itself is now gone. Also, I believe that @rubys migrated his app to use Gumbo.
One alternative to adding an non-Gecko target for the C++ translation of the Validator.nu HTML Parser and to using Gumbo after updating it to spec would be to create an FFI wrapper for html5ever.

Looks like there is a new library, which presumably would require no compilation and would work on all Ruby platforms including JRuby: https://github.com/namusyaka/gammo

Oh neat! One possible concern for Nokogiri is that we (Nokogumbo) have already gotten push back for implementing the HTML 5 serialization algorithm in Ruby as being too slow. I imagine there would be similar concerns about switching to a pure Ruby parsing library. (My personal use case would be completely unaffected by such a change.)

I don't think Nokogiri should choose a pure-Ruby implementation, because of performance concerns. Nokogiri is in the hot path for lots of Rails applications at this point (via the dependency chain of rail-html-sanitizer → loofah → nokogiri) and so I don't think we'd be meeting or exceeding expectations unless we have roughly comparable performance (speed and memory) when parsing.
I'll also note that we implemented an FFI version of Nokogiri but ripped it out in 1.5.0 for a variety of reasons including difficulty debugging memory issues and performance (both of which may now, nine years later, be addressed). I explained this more at length in this GoGaRuCo 213 talk starting at 21:49.

:rofl: :sob:

I spent a while updating Gumbo to match the standard and added extensive unit tests.

Is that to say that upstream Gumbo isn't keeping pace with the rate of change? Is it abandoned, casually maintained, etc? Given nokogiri has gotten by with a more or less an unmaintained library for html, it might still be a net win to move to gumbo so long as it is kept at at least semi-current.

A lot of Rails users care about JRuby support, which has yet to be implemented for nokogumbo: https://github.com/sparklemotion/nokogiri/issues/2064.

@ptoomey3, my understanding is that it's completely unmaintained. I think what happened is a Google engineer built it in their 20% time and then either stopped or is no longer at Google. @craigbarnes put a lot of work into updating it and making it faster/more maintainable as part of lua-gumbo.
I took a bunch of those changes for our fork in Nokogumbo. I believe the lua-gumbo and nokogumbo implementations have diverged (particularly the test harness). Craig and I have been notifying each other of important updates we've made, however.
The official gumbo repo hasn't been touched in 5 years and contains several security vulnerabilities¹ that have been fixed in lua-gumbo and nokogumbo.

¹ I didn't check if they were exploitable.

What would be the next step?  How can I help?
Putting aside the JRuby problem for the moment, it seems like nokogumbo is the logical next step; and it wouldn't be one that would preclude a Gecko/Servo/Chromium based replacement in the future.

@rubys - I agree that leveraging Nokogumbo is the easiest next step (and potentially the only step, at least for another 10 years :laughing: :sob:).
To be clear: a consequence of this decision is for Loofah to start using Nokogumbo for HTML parsing, meaning that Nokogumbo will become a dependency of Rails, and almost certainly will have an increased support burden as a result.
None of us is paid for our work. How can we preserve maintainer happiness on both projects while maintaining an acceptable level of support for the Rails community?
Proposed next steps
I want to be very respectful of boundaries here. The Nokogumbo contributors have filled this functionality gap very well and I don't want to presume that consolidation or assimilation of either project is necessary or desirable.
If it would be easier to shift this discussion into a realtime face-to-face conversation, I will gladly do that.
1. 2020:
Status quo for a few more months. Ship Nokogiri v1.11.0 towards the end of 2020 with precompiled native gems for windows, linux, and osx/darwin.
Ensure that Nokogumbo installation doesn't break (see https://github.com/rubys/nokogumbo/pull/148 and https://github.com/sparklemotion/nokogiri/pull/1788).
2. Decision point:
After the precompiled native gem release has baked for a bit and we've learned more about whether it was a good decision or not and how hard it is to maintain this approach -- maybe in early 2021? -- make a decision, involving the key stakeholders from both projects, about whether to merge the projects.
3.a. No, don't merge:
If we decide not to merge, then we firm up the contract between the two gems -- both at installation and at runtime -- and invest in integration testing. [1]
3.b. Yes, please merge:
If we decide to merge, then I'd like to suggest Nokogumbo merge into Nokogiri, rather than both merging into a net-new gem; but I am open to a conversation about other approaches. Please let me know if this is a contentious idea, and I'm happy to jump on a realtime call to discuss it.
The core contributors for the merged gem would be the set-union of the Nokogumbo and Nokogiri core contributors, and the commit history for both projects would be preserved. We would make a big deal out of it, and graciously name and thank the people who've made the projects a success. Yay us!
Immediate work would be to functionally integrate the code, and then get precompilation (native gems) working and tested for Nokogiri::HTML5 and Gumbo for a Nokogiri v1.12.0 release -- or potentially a v2.0 release? -- in 2021.
Brief thoughts on our options
My mental model is such that I think it makes most sense to merge (3.b.), but would really like the key Nokogumbo creators and contributors to talk about their own mental models, opinions, fears, etc.
I suspect that keeping the gems separate is going to lead to unhappiness among the maintainers. The Nokogumbo maintainers will inevitably shift focus from "making HTML5 parsing work in Ruby" to "making this C codebase compile and install on an infinite variety of ill-configured systems" as the Rails community comes to depend on it. (Ask me how I know! :sob:) The Nokogiri and Loofah maintainers will experience burnout when their sphere of responsibility doesn't match their sphere of control -- specifically when users loudly complain about something not working perfectly across the integration boundaries.
One reason to not merge might be the size and complexity of the codebase increases for both teams in a merger. However, I think we'd more than offset or mitigate that complexity when we plan to reduce the total support burden by: a) improving the installation experience, b) improving the developer experience, c) removing a vector (libxml2's HTML parser) for security vulnerabilities, d) replacing the informal brittle install-time contract with a robust compile-time contract, e) having a unified team large enough for folks to still specialize within the codebase.

[1]: Nokogumbo's installation process is still pretty tightly-coupled to Nokogiri's installation process, and there's an implied contract between the two that involves the structure of Nokogiri::VersionInfo and the presence of header files on disk. So we'd need to tighten up that contract, and ensure we're integration-testing across the two projects.
Loofah is updated to use Nokogumbo (only on CRuby), making Nokogumbo a dependency of Rails. Nokogumbo support burden would likely increase as a thundering herd of Rails developers are now installing Nokogumbo.
I expect some demand for a faster/better installation experience for Nokogumbo, similar to what Nokogiri has seen over the past few years. Work to keep the support burden low by investing in a single installer toolchain, and a unified memory testing approach (today Nokogiri uses valgrind, but I'm looking into ASan). We'd likely spend some time re-implementing the toolchain and keeping it in sync across the two projects. This doesn't sound like fun to me, but we could do it.

One gem would also mean that nokogumbo can drop the "no headers available" fallback.
You don't need my permission to pursue the "one gem" approach, but you have it.

I personally like 3b.  I think it would make things easier to maintain.

One possible change to consider for 2020: make Nokogiri::HTML4 an alias for Nokogiri::HTML, and keep the HTML4 logic in place for a transitional period once HTML5 logic is introduced.

I'm definitely on board with having a single gem that works with HTML.
One thing that I hadn't fully appreciated earlier was that the HTML living standard isn't designed to be a separate standard. Browsers don't have multiple parsers, they all just parse HTML and this specifies how to do it.
Currently, Nokogumbo will refuse to parse any html that doesn't start with <!DOCTYPE html>. This includes parsing any HTML that has a DOCTYPE specifying HTML 4. I suspect we could (and should) lift that restriction, either in Nokogumbo or in Nokogiri.
The major concern I have with doing that comes with serialization. For example, it should be no problem to parse HTML with
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

(and indeed gumbo supports it). But when it comes to serializing it, if we follow the Serializing HTML fragments algorithm, the DOCTYPE will become <!DOCTYPE html>.1. This might surprise users and may break their use case. If we don't follow the algorithm and instead write out the full DOCTYPE, will the result actually be valid according to the DTD? I have no idea.
One additional concern, libxml2 will insert nodes into the DOM that aren't specified by the standard. I forget exactly what it is off-hand, but I think it might insert a meta specifying the character set. Would we want to maintain such quirks for backwards compatibility?

1 The algorithm for serializing a DocumentType only specifies writing out the name and not the publicId or systemId.

Currently, Nokogumbo will refuse to parse any html that doesn't start with .

Please explain.  Here is what I'm seeing:
$ irb
irb(main):001:0> require 'nokogumbo'
=> true
irb(main):002:0> Nokogiri::HTML5('<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org
TR/html4/loose.dtd">foo')
=> #<Nokogiri::HTML5::Document:0x118 name="document" children=[#<Nokogiri::XML::DTD:0xb4 name="html">, #<Nokogiri::XML::Element:0x104 name="html" children=[#<Nokogiri::XML::Element:0xc8 name="head">, #<Nokogiri::XML::Element:0xf0 name="body" children=[#<Nokogiri::XML::Text:0xdc "foo">]>]>]>
irb(main):003:0>

Oh! I was confusing that with this.

Closing, please follow #2204 for the exciting conclusion.

Even though this issue is closed, I still want to mention the faster libxml2 and gumbo alternative[1] that we at SerpApi have been using in production for a year — the Lexbor[2] library via the Nokolexbor gem[3].
The Nokogumbo merge into Nokogiri was an epic work.
@flavorjones What do you think about using Nokolexbor for the HTML processing Nokogiri?

@ilyazub please start a new issue.


Introduce async budget in transaction manager

closes https://github.com/paradigmxyz/reth/issues/6290

made some changes. now every stream can be prioritised differently. though I advice against it, if you still want, I can disable the budget for tx propagation @mattsse

can we please roll this back to 35e375e1477b5cd623c9592dc4fb0993f188f215 first with the nits applied and then revisit separately?


If the view is a desert, there shouldn't be a coconut tree there

As the title says, the desert should not have coconut trees. I think I should change to the shadow of the cactus in the distance or delete the coconut tree completely and add nothing.

Tada! :tada::tada::tada:


Tracking: Google Cloud Storage support for OpenDAL

Features to complete

[ ] Basic read, write, stat, list, delete operations

[x] Initiate a GCS backend skeleton: #513
[ ] Add unit tests for the GCS backend
[ ] Add integrated tests for the GCS service
[ ] Test on real-world GCS

[ ] Server Side Encryption Support

[ ] Customer Supplied Encryption Key
[ ] Customer Managed Encryption Key

For the first stage, let's implement the basic feature of gcs and move sse support to another issue.

Thank @ClSlaid for the work!
The only work left for us is to update docs so that our users can start use gcs service.

All done! Thank @Xuanwo for your patience and well-organized code!


Adds plan --plan-file-store and apply plan-file-location

The plan-file-store flag sets the output location of the plan executable
file.
The apply-file-location sets the file to be used when applying.
Both default to the current default path (current cluster code path).
If a plan-file-location has been set during an apply, the normal plan
that is made before the apply is omitted, only the apply will run.
What this PR does / why we need it:
This enables us to use custom plan executable files in our CI.
We are also able to save plan outputs to arbitrary file locations.
fixes #548
fixes #470
Adds `tarmak plan --plan-file-store` to sore executable plan output files to arbitrary locations.
Adds `tarmak apply --plan-file-location` to use arbitrary executable plan file for the apply.
- Custom plan files during apply will still execute plan checks.

This needs some rebasing similar to #560's Terraform.dryrun
/assign @JoshVanL

/unassign
/assign @simonswine

Sorry again
/unassign
/assign @JoshVanL

/unassign
/assign @simonswine


Persist multiple stores using pinia-plugin-persistedstate in nuxt3

Describe the bug
As per nuxt3 doc, we can have multiple stores. How can we persist all this stores in single key in localstorage. i can only save the stores with separate keys. How can i solve this case
Reproduction
NO
System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i5-1240P
    Memory: 4.27 GB / 15.73 GB
  Binaries:
    Node: 20.16.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.8.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (127.0.2651.74)
    Internet Explorer: 11.0.22621.3527

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible of the bug.

This is not possible out of the box, and not planned to be supported to fir the "modular"  and isolated philosophy of pinia.
However this should be achievable with a custom storage/serializer combo.


A way to restore incremental backups

Describe your idea
Currently, incremental backups need to merged by hand. It would be better if there was a tool built in the mod to fix that.

https://github.com/pcal43/fastback has a built in tool and is open source so maybe you could borrow some code from there? It's only available for 1.20 unfortunately but I need 1.18.2. :(


Upgrade reflections

Reflections 0.9.9 is used by mongock-runner-core.
This version brings in guava 15.0, which has 2 identified vulnerabilities:
https://nvd.nist.gov/vuln/detail/CVE-2018-10237
https://nvd.nist.gov/vuln/detail/CVE-2020-8908
If reflections is updated to 0.9.12, the dependency on guava is removed.

+1


Github workflow that uses kitctl to bootstrap a test environment

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Unfortunately,I deleted the forked repo as I had do many changes that points to different repos to test which made almost 350+ commits a head of the main repo  which made me feel that my repo bit clumsy,Here I opened a new pull request and closed the previous pull request https://github.com/awslabs/kubernetes-iteration-toolkit/pull/353,as I cannot use once i deleted the fork repo and open new one.

Please update the PR description as we discussed before to include the context about why we take this approach and why alternatives don't work.

Also please squash commits. No need to have 18 commits.

In order to use AWS resources in GitHub Action workflow there are some limitations ,When we a Create a PR from the fork to the upstream repository workflow wont works because GitHub Secrets are not passed to the runner when a workflow is triggered from a forked repository, In order to overcome to this @mengqiy and I came up with an workaround to use a secondary GitHub Action Workflow that is triggered on workflow_run. Here first workflow action will be triggered and basing on that the second GA will authenticate properly(AWS creds). But there are certain limitations when we are triggering the workflow_run events ,Where the second workflow that was triggered by the first workflow will always run in the background and doesn't have visibility in checks.
References:
(1)https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-featu[…]-repository/managing-github-actions-settings-for-a-repository
(2)https://docs.github.com/en/actions/security-guides/encrypted-secrets#using-encrypted-secrets-in-a-workflow

The below workflow runs on both Ubuntu-latest and macOS, however, the macOS run takes a significantly longer duration compared to the Ubuntu-latest run. This is because, by the time the Ubuntu-latest run completes the creation of the guest KIT cluster from 1-21 to 1-24, the macOS run is still struggling to create the control plane guest nodes and is experiencing a lot of network latency issues it seems. This results in the entire workflow being impacted and slowed down. To address this, we need to find a way to optimize the network latency for the macOS run or consider using an alternative solution.
[macos-latest]->https://github.com/Ganiredi/kubernetes-iteration-toolkit/actions/runs/4266143419/jobs/7426309435
[ubuntu-latest]->https://github.com/Ganiredi/kubernetes-iteration-toolkit/actions/runs/4266000172/jobs/7425999484
[macos-latest][ubuntu-latest]->https://github.com/Ganiredi/kubernetes-iteration-toolkit/actions/runs/4264715980

Let's make sure we run this in dedicated Team account for this workflow as mentioned offline in the past. Making sure, we don't  have single point of failure when you are not available.

Eg Workflow run: https://github.com/Ganiredi/kubernetes-iteration-toolkit/actions/runs/4863420273/workflow

Reverted accordingly


p3c-pmd plugin not support jdk 21

Describe the bug
My application is running on jdk 21, When I run use p3c-pmd and run "mvn pmd:pmd", I got this error:
Execution default-cli of goal org.apache.maven.plugins:maven-pmd-plugin:3.24.0:pmd failed: A required class was missing while executing org.apache.maven.plugins:maven-pmd-plugin:3.24.0:pmd: net/sourceforge/pmd/lang/BaseLanguageModule.

https://github.com/godfather1103/p3c


Song backgrounds don't load

When i do pico or something with a custom background other than (tutorial and daddy dearest) it shows the stage from tutorial and daddy dearest. Can anybody help me with this?

also it applies to non-custom backgrounds too


TestCategory on class doesn't apply to inherited test methods

Description
I have a test class that inherits test methods from a base test class, but I want to apply a TestCategory from the derived class in order to filter tests to run. The current implementation only looks at the TestCategory starting at the class that declares the test method, rather than the class being enumerated. But since TestCategory is inherited, I think it would make sense for it to include all categories starting at the class being enumerated.
I have a working implementation of this in a fork and am opening this issue to determine if the change is desired or if it's working as intended.
There's also a question about how assembly-level TestCategory attributes should work in this case. The code currently only considers the assembly containing the test method and not the assemblies containing the test class hierarchy. My fork changes it to only consider the assembly containing the test class being enumerated.
Steps to reproduce
[TestClass]
[TestCategory("base")]
public abstract class Base
{
    [TestMethod]
    public void TestSomeBaseInterfaceMethod() {}
}

[TestClass]
[TestCategory("derived")]
public class Derived : Base {}

Expected behavior
Derived.TestSomeBaseInterfaceMethod has both base and derived test categories:

Actual behavior
Derived.TestSomeBaseInterfaceMethod only has the base test category:

Environment
MSTest 1.3.2

Hey @spanglerco, thanks for pointing this out. Will be marking this as an enhancement and is up for grabs for a contribution.
Just adding to the expected behavior a little, TestCategory should not override but add another category to the class. A test class can take multiple test categories, so for derived classes defining TestCategory should also show up when filtering for their base class category
[TestClass]
[TestCategory("base")]
public abstract class Base
{
    [TestMethod]
    public void TestSomeBaseInterfaceMethod() {}
}

// With test category
[TestClass]
[TestCategory("derived")]
public class Derived : Base {}

// Without test category
[TestClass]
public class Derived2 : Base {}

Using the filter "base" should run both Derived and Derived2 classes whereas using filter "derived" should only run Derived class.


Deferred is being stored in the global scope

It's missing a comma and not a semicolon; this breaks promises that are being shared as mentioned in #9

Guess this is the same as #7


Change uBAM ingest and Analysis update to ignore the generation of PUT u...

...rls in the case of using the 'X-Force-Location' header.
Covers jira tickets https://broadinstitute.atlassian.net/browse/DSDEV-1849 and https://broadinstitute.atlassian.net/browse/DSDEV-1850
Also includes a minor refactor of boss get creation request (this looks cleaner to me) and wording changes for the tests to keep them up to date with current understanding.
Will rebase and squash after PR feedback is completed.

OK, looks good for DSDEV-1849!  Please rebase and squash to a single commit.

Rebased and squashed - thanks for the great feedback!

Thanks for doing the work and the quick response time!


Adds support for SQLAlchemy 2.0 Mapped annotations

Closes #178

If you'd like to cut a release yourself @Daverball, just:

Bump the minor version
Go to https://github.com/snok/flake8-type-checking/releases and draft a new release
Use a tag matching the previous releases, write the release notes, and publish

That will kick off a workflow which publishes the new version to PyPI :+1:


How to resume training after an interruption？

Just add --resume_training to the same command as before, with the same experiment name


PlaceSearch sample crashes when Search Button is clicked

When inputting an address/place and pressing "Enter" the location is found, however if instead of pressing "Enter" I click the Search Button again the application crashes with an error. I am testing on the AVD

.

Verified fixed with #56


add 1C-Syntax package

//cc @nixel2007

👍 wasn't expecting this programming language to appear for VS Code, but that's really cool :)


[DO NOT MERGE] rotors_integration

if you feel most things are solid, can you start pushing dependencies like your changes to the optical flow submodule? Please reference any new PRs with a link here so I can find them.

Just a heads up, I think we should use this instead of rotors gps plugin: https://github.com/PX4/sitl_gazebo/pull/82

Hopefully  we can sync my gps fix back with rotors.

@LorenzMeier , here is the pull request for the OpticalFlow repo. Once that is merged in I will update the submodule in the rotors_integration branch of PX4/Firmware to point back to the correct upstream repo.

Ok, merged, please go ahead and update the submodule so we can get CI to start passing.

@LorenzMeier thanks and done.

@jgoppert @LorenzMeier are these GPS changes important to get implemented before this pull request is merged with master? If not, it might be worth creating a new issue at https://github.com/ethz-asl/rotors_simulator, where we can discuss how your changes can be integrated with the existing GPS plugin.

Will look at that run tests error in Jenkins tomorrow morning.

@gbmhunter No need to get the GPS change in now, I will go ahead and post an issue on rotors. It really needs to be cleaned up into a separate module anyways.

Jenkins test this please.

Nice, almost there!

Every file should end on a new line, so feel free to fix.

Oh interesting, rebasing also detaches all the comments in the pull-request, I guess that makes sense, it is rewriting all the commit hashes...

Why don't we just have a separate official px4_sim ROS package. I think this is getting out of hand with all of the submodules.

I'm trying to upstream the rotors functionality that we need to gazebo natively. Here is my first patch to support a random walk noise model: https://bitbucket.org/osrf/gazebo/pull-requests/2670. So this might take awhile. I'm OK with getting this in, if that is the best approach for now.

@jgoppert any updates?

@gbmhunter what's the status of this?

@TSC21 I'm not sure anymore! About half a year ago I was preparing this merge request and believed to have gotten it somewhere close to mergable. My 2-month term then ended and I had to move on...I believe @jgoppert found some usage issues just before I left, I'm not sure on the progress made to fix that.

@TSC21 I'm not sure anymore! About half a year ago I was preparing this merge request and believed to have gotten it somewhere close to mergable. My 2-month term then ended and I had to move on...I believe

Are you able to sync this up again so to push this again to master? I think it would be worth for us all to have sitl_gazebo sync with rotors.

@TSC21 Sorry I am currently living in Canada and have a full-time job, I'm not really in the position to take on more work right now.

@gbmhunter understandable. np

@jgoppert maybe when we have time we consider in getting this forward?

Closing as stale.


Mac Apple silicon: DllNotFoundException: Unable to load DLL

This error appears on Mac Apple silicon or Intel64+Apple silicon builds, Intel 64 works well , Unity 2022.3.11:
DllNotFoundException: Unable to load DLL 'Cysharp.Net.Http.YetAnotherHttpHandler.Native'. Tried the load the following dynamic libraries: Unable to load dynamic library 'Cysharp.Net.Http.YetAnotherHttpHandler.Native' because of 'Failed to open the requested dynamic library (0x06000000) dlerror() = dlopen(Cysharp.Net.Http.YetAnotherHttpHandler.Native, 0x0005): tried: 'Cysharp.Net.Http.YetAnotherHttpHandler.Native' (no such file), '/System/Volumes/Preboot/Cryptexes/OSCysharp.Net.Http.YetAnotherHttpHandler.Native' (no such file), '/usr/lib/Cysharp.Net.Http.YetAnotherHttpHandler.Native' (no such file, not in dyld cache), 'Cysharp.Net.Http.YetAnotherHttpHandler.Native' (no such file), '/usr/local/lib/Cysharp.Net.Http.YetAnotherHttpHandler.Native' (no such file), '/usr/lib/Cysharp.Net.Http.YetAnotherHttpHandler.Native' (no such file, not in dyld cache)

The solution is to use "-lipo" to merge the libraries and put it in "osx" folder,
https://forum.unity.com/threads/apple-silicon-intel-64-bit-managed-and-native-library-settings-not-working-as-expected.1263548/


Revert "Fix TypeScript ESLint and webpack errors"

Reverts wellcomecollection/wellcomecollection.org#6029
These changes caused a failing build when merged to master, despite building successfully in the PR CI process. I'm reverting so that I can investigate further.

This looks like it doesn't break the main experience build (still building at time of writing, but passed build step): https://buildkite.com/wellcomecollection/front-end-wellcomecollection-dot-org/builds/1576#cccaac48-467b-4972-aa5d-50290a1572e0

This looks like it doesn't break the main experience build (still building at time of writing, but passed build step): https://buildkite.com/wellcomecollection/front-end-wellcomecollection-dot-org/builds/1576#cccaac48-467b-4972-aa5d-50290a1572e0

No longer needed

No longer needed


Add build and release action

This PR adds a GitHub workflow to build Sage on:

Linux x86_64 (using Ubuntu 14.04)
Windows x86_64
MacOS x86_64
MacOS aarch64 (for Apple Silicon)

The builds are triggered on new PRs and commits to master, and the executables are uploaded as artifacts automatically for manual inspection, if desired.
New GitHub releases trigger this workflow and additionally the executables will be automatically uploaded as assets to the new release.

Looks great, thanks for getting this set up @wfondrie!!!


wasabiwallet: <IP_ADDRESS> -> <IP_ADDRESS>

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/zkSNACKs/WalletWasabi/releases.
meta.description for wasabiwallet is: "Privacy focused Bitcoin wallet"
meta.homepage for wasabiwallet is: "https://wasabiwallet.io/"
meta.changelog for wasabiwallet is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found <IP_ADDRESS> with grep in /nix/store/s6g30m9k6q783abpml757py15zcf6r8g-wasabiwallet-<IP_ADDRESS>

directory tree listing: https://gist.github.com/b8e02f3db3a0abddec9603f5b8c35f3b

du listing: https://gist.github.com/8bd089a2165a465d4acbf7a0532f6cc1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
wasabiwallet

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s6g30m9k6q783abpml757py15zcf6r8g-wasabiwallet-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A wasabiwallet https://github.com/r-ryantm/nixpkgs/archive/e2113c1f60189edf1d5172432f6310867d2e11e3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s6g30m9k6q783abpml757py15zcf6r8g-wasabiwallet-<IP_ADDRESS>
ls -la /nix/store/s6g30m9k6q783abpml757py15zcf6r8g-wasabiwallet-<IP_ADDRESS>/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

wasabiwallet

Maintainer pings
cc @mmahut for testing.

Result of nixpkgs-review pr 116663 run on x86_64-linux 1

1 package built:

wasabiwallet


feat: ability to set namespace

Can’t you create a new client if you want to use a different namespace?

but you need a client to create namespace so procedure would be

create client
create namespace
create new client

which doesnt seem to look gud

@sadath-12 Good point, I would suggest to change this slightly. Lets do something like this -
client = Client.new_namespace("foo", server_addr="....")

That creates a new namespace and returns the client. So you are able to create a ns and get the client at the same time.
@classmethod
def new_namespace(cls, namespace: str, server_addr: Optional[str] = "http://localhost:8900"):
   pass

thanks @diptanu , please do check it