Make spelling filters customizable

[x] Document default filters
[x] support adding new filters and disabling default ones

This has been merged into master. You can now disable the built-in filters and add your own:
extends: spelling
message: "Did you really mean '%s'?"
level: error
# This disables the built-in filters. If you omit this key or set it to false,
# custom filters (see below) are added on top of the built-in ones.
#
# By default, Vale includes filters for acronyms, abbreviations, and numbers.
custom: true
# A "filter" is a regular expression specifying words to ignore during spell
# checking.
filters:
  - '[pP]y.*\b' # Ignore all words starting with 'py' -- e.g., 'PyYAML'.
ignore: ci/vocab.txt

If neither custom nor filters is defined, the functionality is equivalent to before (i.e., this shouldn't break existing spelling rules).


[SPARK-16398][CORE] Make cancelJob and cancelStage APIs public

What changes were proposed in this pull request?
Make cancelJob and cancelStage APIs public
How was this patch tested?
Existing jenkins tests

Can one of the admins verify this patch?

cc @srowen @rxin

Looks fine to me. Do we expose stage ID anywhere else?

Test build #3167 has started for PR 14072 at commit e2d2cb1.

Yeah its in StageInfo.stageId from the SparkListener events. Our use case is that we use FIFO scheduling (jobs fully utilize the cluster so parallel doesnt help), but I want to listen for the job/stage start and log/kill ones that take too long. From what I can tell the DagScheduler doesnt have some built-in job/stage timeout.

Test build #3167 has finished for PR 14072 at commit e2d2cb1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merging in master. Thanks.


Provide a recipe for using turbolinks and the routing

Is your feature request related to a problem? Please describe 🙏
Turbolinks is a tech that simulates SPA on traditional websites. The URLSync was compatible, the routing is not.
Describe the solution you'd like 🤔
No clear solution for now but the routing should be compatible and we should document how to implement it.
Additional context
This is a follow up of https://github.com/algolia/instantsearch.js/issues/985

So I got it working in our project, but I have to leave the turbolinks=true param in the URL, or it doesn't work. I'd love to find a way to hide it and keep my routing clean :)
You can view the live implementation here: https://www.woom.fr/recherche/experiences?q=test&turbolinks=true

Thanks a lot @Spone for the status update 👍 :)

ping

hello :)
anything new around here ?

Nothing new; workaround is still: https://github.com/algolia/instantsearch.js/issues/985#issuecomment-388899593
instantsearch({
  routing: {
    stateMapping: {
      stateToRoute(uiState) {
        return {
          turbolinks: true,
          ... uiState,
        };
      },
      routeToState({turbolinks, ...routeState}) {
        return routeState
      }
    }
  }
});

Hi there, I'm using the latest instantsearch.js on a new project and the Turbolinks support seems broken again... Any news on this?

(to fix this without workaround, we need to pass turbolinks: true in the "state" object of the history.push, right now this is the "route state", so that's why you need to manually add it. It might make sense to have an option for this in the router

Currently, when I use the recommended workaround, if I click on a link, I have to click the back button twice to get back to my original state. I'm not sure how to debug this...

@Spone Can you please reproduce the behavior in this InstantSearch.js sandbox?

Hi there,
I encountered the problem here:

Go to https://www.woom.fr/activites/Clermont-Ferrand/dans-les-airs
Click on "Parapente (...)"
See that results are updated
Hit back to return to previous page, see that we don't find the same page (actually, it's the page https://www.woom.fr/activites/Clermont-Ferrand that is rendered)
Hit forward button, see that we have the same results as step 4.

parseURL is never called.
Do you need a live reproduction of the bug in a sandbox?
Thank you

A standalone sandbox is the only efficient way where we can debug yes. What I think might be the case is the turbolinks

not sending updates when the url changes
gets Removed if turbolinks is removed from location.history

I am not sure how to reproduce it giving the fact that we install turbolinks via the ruby gem (our backend being rails). Maybe you can help on this?

I am not sure how to reproduce it giving the fact that we install turbolinks via the ruby gem (our backend being rails). Maybe you can help on this?

You can install it using the NPM package: https://www.npmjs.com/package/turbolinks

Hi @Spone,
Thanks for the tip, I am just not sure that installing turbolinks a different way will reproduce the bug, I will try and see!
Thanks

Hi,
Here is a sandbox that should expose the problem: https://codesandbox.io/s/algolia-turbolinks-bad-behaviour-b5ed6?file=/src/app.js
The thing is that I didn't add turbolinks and I don't understand why parseURL is not called at each click on back or forward buttons, as described by your documentation.
Thank you again

Since it's unrelated to turbolinks, could you open this in a new issue please? I don't know for sure yet what the cause is, but I feel like it might be related to the URL not being different to before

Nothing new; workaround is still: #985 (comment)
instantsearch({
  routing: {
    stateMapping: {
      stateToRoute(uiState) {
        return {
          turbolinks: true,
          ... uiState,
        };
      },
      routeToState({turbolinks, ...routeState}) {
        return routeState
      }
    }
  }
});

Is this still the recommended workaround with the latest instantsearch and turbo(links) versions? Unfortunately it doesn't seem to have any effect for me (apart from adding turbolinks=true to the generated URL).

the state "turbolinks: true" still gets saved in the history state since it saves the whole route state:
https://github.com/algolia/instantsearch.js/blob/3648a3cdc561cca3d92c67f7c5121ed16d00c722/src/lib/routers/history.ts#L132
Alternatively you can change that line in a custom router to no longer save the InstantSearch state on history state,  but then you'll need to make sure you also don't read from event.state in onUpdate:
https://github.com/algolia/instantsearch.js/blob/3648a3cdc561cca3d92c67f7c5121ed16d00c722/src/lib/routers/history.ts#L148
Hope that helps @marckohlbrugge, but otherwise it'll be best if there's a reproducible example with turbolinks + InstantSearch so we can investigate what's going wrong

Thanks @Haroenv. I'll give it another try. Building a reproducible example is a bit tricky as both instantsearch and turbo links are quite hard to set up as standalone scripts. But I'll see what I can do if I still can't get it to work with your suggestions above.

In general I feel like it's usually better not to use turbolinks on the InstantSearch pages, as they will both conflict. It's best to set up an exclusion for any InstantSearch-controlled page. If there's anything else wrong after both scripts are no longer running on the same page, please create a new issue with reproduction :)

Here is the working solution in 2024, with current versions of InstantSearch.js 4 & Turbo 8:
instantsearch({
  routing: {
    router: history({
      cleanUrlOnDispose: false,
      push: (url) => {
        window.history.pushState({}, null, url);
        Turbo.navigator.history.push(url);
      },
    }),
  },
})

Source

@Spone Thanks that worked mostly for me but i had to use replace instead of push Turbo.navigator.history.replace(url);
With using push, i could go back with the back button when leaving the search page but after that, every back button click would not do anything until i reach the last item in the history on the search page (initial state when loading the search page).
With replace i can traverse back properly and routing works as intended.


Bound in-memory storage

Right now, the in-memory storage option is unbounded, which means that it can lead to out-of-memory errors which can kill the server. This has come up in the kubernetes repo and again recently when asked by @kellabyte_twitter

I could see some cases where historical data isn't required, more just tracing "recently" or "whats going wrong right now"

It is possible to make a storage option which can evict based on last timestamp, separately tracking size of index data from encoded spans. There's some related code in zipkin-reporter-java for making a fixed-size for the pending spans queue. Here, codecs support estimating the encoded size (ex that a span is 298bytes or so). Such code could be reused or at least looked at.
By doing something like this, people could have a cheap single-node zipkin which won't blow up on memory, even if it is persistent and not replicated. The tradeoff is that this sort of code, while fun, is even less straightforward than the existing in-memory code.

+1 for bounded InMemoryStorage.

+1

This would be useful for us too.  I'd like to take a crack at it.
I think it makes sense to take the approach of letting users either set a maximum number of spans or a maximum number of span bytes (using a rough estimate 500 bytes per span), so
--max-spans=10000
and
--max-span-bytes=5mb
would be the same.  Or perhaps since this applies to the in-memory storage only, the options should be --max-inmemory-spans and --max-inmemory-span-bytes. . .something like that.
In the process of familiarizing myself with the code, I've made a few cleanups that I'll submit via separate PRs.  I haven't actually written the code to purge the old spans yet, but I hope to tackle that today.
Does that sound OK?
Joel

Go for simplest auto-purge based on oldest data. I suspect span or trace id
is likely easier to implement, but happy to review whatever proves easiest.
One knob is ideal because we dont want to start encouraging use of mem
storage by adding too many features to it.

OK.  I'll just go with a maximum # spans.
I've got a purge() method added to the InMemorySpanStore class.  This method deletes the oldest traces (and their spans) when invoked.  Do you have an opinion on who should do the invoking?  And how?  I'm don't quite know most most idiomatic in Java.  For example:

Perhaps InMemoryStorage should have a worker thread that just invokes it every minute or so (cron-like).  In this case, purge() would be being called from outside InMemorySpanStore.
Perhaps InMemorySpanStore should invoke it every time a span or group of spans gets added.  This means that purges would be more frequent and consistent, but the naive implementation would add more time to every accept() call.  I'd also rather avoid the contention of multiple calls to purge() all trying to purge the same traces.  One would win, of course, but why do all the extra work?
Or perhaps some other idea you might have?

I'll try implementing some of those and see how it works.
Almost there!

on purge, I'd steal time from the accept method. not worth making any
machinery imho, as it will still be faster than i/o based span stores.


How to use softlayer private endpoint?.

Hello.
How to use softlayer private endpoint?.
The following is guide for softlayer REST API.
Use "api.service.softlayer.com/rest/v3/" to access the REST API over SoftLayer's private network.
https://sldn.softlayer.com/article/rest

@YunSangJun sorry for late reply, you can specify an api endpoint in the following feature option
http://bosh.io/jobs/softlayer_cpi?source=github.com/cloudfoundry/bosh-softlayer-cpi-release&version=23#p=softlayer.featureOptions.apiEndpoint


reactotron-app: fix case sensitive file paths

This fixes the incorrect case in a few file paths that prevented
electron/webpack from loading files on case sensitive file systems (ie,
those on Unix systems).

Oh wow.  I would have never thought to check this.  Thank you.

If you have a case sensitive filesystem on OSX or Linux, reactotron wouldn't work at all.  If it matters, you should be able to package the app for Linux now. I would also suggest repackaging the OSX app as well, as there are people on OSX who have case sensitivity enabled on their HFS+ partitions (ie, like I do...).
BTW, thanks for merging!

I plan on patch release tomorrow evening with a new .app including your fix.
Linux & Windows should happen next week.  I'm just steeling myself emotionally. 😵
Legend has it, signing Electron apps on Windows with a valid certificate is a bit of a challenge.  We'll see.
Thanks again.  Now I can say I know somebody who chooses the non-defaults in Disk Utility when setting up a mac!

I haven't tried it on OSX, which I don't really use (but yes, I have case sensitivity enabled there). I was just trying to get this to work appropriately on Linux first. Anyways, I'll report back if there are other case issues with filenames, as I use it more.

Roger.
If you're building from source then... you've probably gotten this far already, but just in case you haven't.
git clone git@github.com:reactotron/reactotron.git
npm i
npm run welcome
npm run e2e

Hopefully that treats you well.  I'll be putting together a contributors.md with better instructions.
You might have issues with various copy-internal-deps.sh scripts.  Basically they were my work around for React Native not supporting symlinks just yet.
Apologies for any landmines you may hit.


make pdf default (and remove dl warning) if nw is cached

:)

just to explain - it takes a while to check whether nw is cached* so the cache check happens in
parallel to the prompts. So hopefully, but putting pdf Q at the end, for general use on a fair connection the cache check won't even be noticeable.

in order to check the cache for nw, we need a version number. version number is determined by nw-shot which is a dependency of bespoke-to-pdf which is a dependency of bespoke-pdf. Essentially the version of nw.js is determined by bespoke-pdf. You can't just install and see, because this will trigger the nw.js download - so I created traverse-packages that does recursive "npm view" in order to extract the "nw" field of nw-shot (which holds the relevant nw.js version).

This is failing on Travis CI at the moment. Can you look into this?

hmm okay will look into - just need to get a moment

ok fixed
and also squashed

I'm a bit concerned that there are race conditions in both the generator and the test.
Is it possible to prompt only after the NW check has been performed?
Can the test mock out the async dependencies so that it doesn't contain an arbitrary 3500ms timeout?

the race condition in the generator is a trade off against waiting time for the user - if prompt after nw check the user could have anything up to a 3 second wait (given we keep the three second timeout) - is that preferred versus a background check with fallback?
the timeout in the test isn't completely arbitrary it's related to the 3 second timeout (+ 500ms to amply account for processing variance) - but sure we could mock the async deps
It's not ideal, I was thinking of an alternative approach - npm shrinkwrap bespoke-pdf, and find out the version of nw specified in nw-shot. However, .. obviously .. shrinkwrap only includes deps not additional fields. So then I thought, what about putting the desired NW.js version as an optional dependency - one that should break, would it appear in npm-shrinkwrap.json then? ... No, because this: https://github.com/npm/npm/issues/2679
So.. these are the options I can see

keep as is (but mock async deps for test)
make user wait for check in CLUI - (feels clunky)
figure out a third way

Hi @davidmarkclements.
As you can see in #36, we're removing PDF generation in the next version of the generator. We want to push authors to use more up-to-date tools like astefanutti/decktape. That's why I'm closing this issue. Let me know your opinion about this. Are you still working on bespoke-pdf?


added into_sha256d_hash method for BlockHash struct

It seems to me there are no way to convert BlockHash which returns from many rpc calls into useful rust-bitcoin lib types, in this PR I propose one.

A hint regarding the build failure: if you add a pre-commit script to your local repository with the contents of cargo fmt -- --check, git will prevent you from committing wrongly formatted files :)


forcing app to stop in emr-s prior to deletion

Issue #, if available:
Description of changes:
Trying to destroy an EMR-Serverless that has started applications prevents deletion.  Adding code to stop the started application on this cluster for deletion.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

can you pls add changelog?
also you need to commit this code to the replications branch on this repo, which gets replicated internally?

can you pls add changelog?
also you need to commit this code to the replications branch on this repo, which gets replicated internally?

The changelog already has an entry for the emr-serverless as it was just added to the repo but not released yet, so this change falls under that changelog.
Lets's set a gameplan about syncing the repos...I have a running list of TTD...


[v1.7.x] Backport #17177 to 1.7.x (Fix incorrect calculation results when the C locale is set to a locale that uses commas as the decimal separator)

Description
Backport #17177 to the branch for v1.7.x.
Currently, many operators utilize std::stod to convert strings into floating point numbers. This causes incorrect calculations (#17140, #16134) when the C locale is set to a locale which uses commas (,) as decimal separators.
This pull request replaces calls to std::stod and std::stof to the locale-invariant dmlc::stod and dmlc::stof respectively.
The scope of this patch
This patch should fix a large portion of interactions through Python and JVM frontends, since they use locale-invariant serialization in order to pass parameters into MXNet's C API.
However, frontends which utilize C locale-aware serialization (i.e. call sprintf or similar) may break when using locales which don't use . as the decimal separator. They will have to be fixed in a separate patch. I also suspect that they are already broken, because operators utilising dmlc-core parameter parsing were already using locale-invariant serialization.
Further steps
STL streams are heavily used within the codebase, both for serialization and for forming user-friendly messages. Fortunately, they don't seem to be affected by the C standard library locale settings. However, if someone sets the STL locale by calling std::locale::global, MXNet's API will be broken. In order to ensure that this doesn't happen, all streams which are used for serialization will have to be imbued with the "C" locale (not the locale set in the C standard library).
It would be nice to see a more principled approach to serialization in MXNet 2.0, e.g. using a binary format for communication between the frontend and the backend. In addition to solving locale-related issues, this would probably result in a smaller invocation overhead.
Locale-invariant serialization vs locale-aware serialization
As a side-note, using locale-aware serialization is not an option, simply because using , as the decimal separator adds ambiguities to tuple serialization, e.g. (4,4,3) can be a tuple of 3 integers, or a tuple of 2 floats.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Replace std::stod with dmlc::stod and std::stof with dmlc::stof`.
[x] Add a test that tests locale invariance for scalar ops.

Comments

May break Julia and R code when using a locale that uses , as the decimal separator. However, since there was no consistency between the various operators before, it is not unlikely that the code was already broken.

Adding this PR to 1.7.0 roadmap https://github.com/apache/incubator-mxnet/issues/16864.

@leezu can you help to take a review and approve/merge if it looks ok to you :)


Output more location data in lint errors

I've been working on an automated lint error fixer. Basically it takes the output from Coffeelint and programmatically fixes the errors when possible (e.g. for errors like no_unnecessary_fat_arrows where the intent is obvious and the fix is simple).
This change enables the automated fixer, which relies on this fine-grain error location data. I also add 'expected' and 'actual' indentation information, which is useful in fixing indentation errors.
I had to add location manually to each AST rule, since the rule itself is responsible for recursing into the AST. On the other hand, we can inject location data for all token based linters in the lexical_linter.coffee file.
I could create a separate pull request for my fixer script, which currently supports fixes for the following error types:

indentation
no_trailing_whitespace
no_trailing_semicolons
no_unnecessary_double_quotes
space_operators
spacing_after_comma
colon_assignment_spacing
no_unnecessary_fat_arrows
arrow_spacing

@mf-corey Could you create a PR in https://github.com/coffeelint/coffeelint that is where further development will happen.


Manage yumrepos via data

This commit adds parameters to manage Yumrepo resources via data.  The
primary parameter, repos, is simply a hash of Yumrepo resources for
digestion by an each loop similar to an old create_resources() call.
It does nothing on its own, acting only as a source of data.  The other
parameters control the behavior of the resource instantiation loop.
The parameters managed_repos, os_default_repos, and
repo_exclusions each take an array of key names from the repos hash.
They are then combined to select a set of repos from the repos hash
for instantiation.  The formula takes one of the following two forms:
`managed_repos` - `repo_exclusions`

OR, if manage_os_default_repos is set to true
`managed_repos` + `os_default_repos` - `repo_exclusions`

Data is included for most of the CentOS default repositories, with the
exception of the "archive" repos.

@vinzent This latest version adds a parameter to toggle management of the OS repos, defaulting to false.  The spec test for the default case now checks that it includes zero Yumrepo resources.

I've added a whole bunch of examples to the README.  Hopefully they shed some light on why this is useful.


[bug] [production] ValidationError: 1 validation error for Treasury
response -> 0 -> cashAmount
ensure this value is greater than or equal to 0 (type=value_error.number.not_ge; limit_value=0)

ValidationError: 1 validation error for Treasury
response -> 0 -> cashAmount
ensure this value is greater than or equal to 0 (type=value_error.number.not_ge; limit_value=0)
GET http://clochette.dev/api/v1/treasury/
Request headers

connection: close
host: clochette.dev
x-real-ip: <IP_ADDRESS>
forwarded: for=<IP_ADDRESS>
x-forwarded-for: <IP_ADDRESS>
x-forwarded-proto: https
x-forwarded-host: clochette.dev
x-forwarded-port: 443
sec-ch-ua: "Google Chrome";v="107", "Chromium";v="107", "Not=A?Brand";v="24"
accept: application/json
sec-ch-ua-mobile: ?0
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
sec-ch-ua-platform: "Windows"
sec-fetch-site: same-origin
sec-fetch-mode: cors
sec-fetch-dest: empty
referer: https://clochette.dev/docs
accept-encoding: gzip, deflate, br
accept-language: fr-FR,fr;q=0.9,en-US;q=0.8,en;q=0.7

Request body

Exception traceback
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/anyio/streams/memory.py", line 94, in receive
    return self.receive_nowait()
           ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/anyio/streams/memory.py", line 89, in receive_nowait
    raise WouldBlock
anyio.WouldBlock

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 77, in call_next
    message = await recv_stream.receive()
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/anyio/streams/memory.py", line 114, in receive
    raise EndOfStream
anyio.EndOfStream

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/code/app/core/middleware.py", line 28, in dispatch
    return await call_next(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 80, in call_next
    raise app_exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 69, in coro
    await self.app(scope, receive_or_disconnect, send_no_error)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/usr/local/lib/python3.11/contextlib.py", line 222, in __aexit__
    await self.gen.athrow(typ, value, traceback)
  File "/usr/local/lib/python3.11/site-packages/fastapi/concurrency.py", line 36, in contextmanager_in_threadpool
    raise e
pydantic.error_wrappers.ValidationError: 1 validation error for Treasury
response -> 0 -> cashAmount
  ensure this value is greater than or equal to 0 (type=value_error.number.not_ge; limit_value=0)

Testing purpose, labels are not assigned to the issue ?

L'issue devrait être close non ?

Bah ça met pas les labels correctement donc non

Alors il faut faire une issue spécifique pour ça, celle-ci concerne un bug artificiel non (l'erreur de validation) ?


Redirect mouse events to the window under cursor, simplify popup menu input processing.

Redirect all mouse events to the window under the cursor.
Simplify PopupMenu input handling.

Fixes https://github.com/godotengine/godot/issues/88324
Fixes https://github.com/godotengine/godot/issues/70361
Fixes https://github.com/godotengine/godot/issues/77246
Fixes https://github.com/godotengine/godot/issues/66273
Fixes https://github.com/godotengine/godot/issues/73926
Supersede https://github.com/godotengine/godot/pull/85583
Supersede https://github.com/godotengine/godot/pull/88366
Supersede https://github.com/godotengine/godot/pull/88342

Seems to be working on macOS (and sidecar on iOS), Windows, X11/GNOME, and in a single-window mode.
Need to be tested with captured/confined mouse on all platforms, and on mobile (with touch screen instead of mouse).

Actually, there is an extra case that probably require additional handling, and I have not accounted for: WINDOW_FLAG_MOUSE_PASSTHROUGH (not sure if it's used for anything in editor, but should pass event to the underlying window if set).

@Sauermann Are you using Windows 10 or 11? I'm not able to reproduce #88324 on Windows 10, but I can confirm the PR fixes #73926 and #70361 for me.

@KoBeWi Please note, that I have tested this on Linux.

Ah ok, I misunderstood your comment.

@Sauermann Are you using Windows 10 or 11? I'm not able to reproduce #88324 on Windows 10, but I can confirm the PR fixes #73926 and #70361 for me.

I was able to reproduce #88324 on windows 11 and this PR has solved the issue for me.

https://github.com/godotengine/godot/issues/70361 and https://github.com/godotengine/godot/issues/77246 are reproducible (and fixed) in multi window mode on Windows, not reproducible on macOS, and I have not tested single-window mode.

I can also confirm that the Popup behaviour is much better with this PR.
Although it still does not feel perfect yet, e.g. when moving the mouse a lot, the highlighting may not be visible. Still an improvement.
What I'm wondering here: When I debugged this issue on Windows, I saw weird or even wrong behaviour what _get_focused_window_or_popup returned, thats why my PR fixed the issue by not calling it (https://github.com/godotengine/godot/pull/85583). Windows did already send the event with the correct window id (hwnd), why do we need to 'calculate' a receiving window and use it instead?

Don't miss @Sauermann's comment:

Currently (https://github.com/godotengine/godot/commit/8f0c20ee8d5564d4a8131deb4d5341b60edbcff8) it is possible to drag and drop from a secondary window to the root window. With this PR, this functionality is no longer possible. This can be verified in the editor by making the FileSystem dock floating and trying to drag and drop the icon.svg into the respective slot in the Inspector of a Sprite2D node.

That's a regerssion.

This does not actually fixes https://github.com/godotengine/godot/issues/88324 but it helps working around it.
The root cause of the issue is still there, but this reduces the number of cases where the issue appear.

On Windows 10.0.22621.
I can confirm that this PR fixes #70361, #77246, #73926, and #66273 in multiwindow mode.
#73926 and #66273 are only reproducible on multiwindow mode, so these can be closed.
#70361 and #77246 are present on single window mode still. I believe this is related to #84466 and Viewport's mouse focus, and can be fixed separately.
This breaks drag and drop between multiple windows for me as well.

The root cause of the issue is still there, but this reduces the chances to trigger the bug. See https://github.com/godotengine/godot/issues/88324#issuecomment-1952399913

I cannot reproduce #88324, but I believe that is a separate timing issue, since this PR changes popups to need mouse up.

I Just have some concerns related to the changes in the popup menu class.
Your changes to the display server is a replacement for this pull request https://github.com/godotengine/godot/pull/86952, so we can just revert it and we merge your pull request without the changes to the popup menu files to redirect all mouse events to the window under the cursor, which was the correct fix to the first issue instead of the old hack to enable a missing feature. Thank you.

I think it will be easier to backup your popup menu changes and you submit them later on another pull request after merging my pull request to avoid rebasing and conflict. Since most of the popup menu issues have been fixed after reverting and more issues was fixed in my pull request.

This still breaks multi-window drag and drop.
Fixes:

https://github.com/godotengine/godot/issues/73926
https://github.com/godotengine/godot/issues/66273

Only fixes in multiple window mode:

https://github.com/godotengine/godot/issues/70361
https://github.com/godotengine/godot/issues/77246

#88324 is already fixed.
Since the rebase, no longer simplifies PopupMenu input handling.

While dragging and leaving the window, notification WM_MOUSELEAVE is not triggered.

Needs a rebase since https://github.com/godotengine/godot/pull/67531 got merged.


Strip out language about trademarks.

Deal with this aspect later in coordination with legal.

Closed by d0e274c9193ad3bfc536955e8ca851c53c8e769d
$ git grep -i trademark
$


Add Rahul to owners list

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Allow configuring additional entryPoints to ease use with Typeorm migrations

Is your feature request related to a problem? Please describe.
I'm using typeorm with migrations. The generated migration files are named with a timestamp e.g. 12345-migration.ts. The common approach for including migrations in your Typeorm is providing a config option with a file glob eg:

migrations - Migrations to be loaded and used for this data source. Accepts both migration classes and directories to load from. Directories support glob patterns. Example: migrations: [FirstMigration, SecondMigration, "migration/*.js", "modules/**/migration/*.js"]. Learn more about Migrations.
https://typeorm.io/data-source-options#common-data-source-options

Sadly esbuild cannot statically resolve this at build time and so the migrations files will not be available to the code at runtime in a lambda environment.
Due to this, my current workaround is to output the generated migrations files as js files and include them (via serverless framework)
package:
  individually: true
  include:
    - "src/migrations/*.js"

As long as the paths are correct, the bundled lambda code can then find the migrations files.
However, I did a little experiment and figured out that if you provide the migrations files as entrypoints for an esbuild script, the migrations files will be bundled too with the lambda code, which is the preferred approach for me (the migrations files can then be generated in TS which is just better for everybody). The caveat here is that I had to glob the migrations files directory for the entrypoints, but that was pretty easy https://github.com/evanw/esbuild/issues/381#issuecomment-691273255 or https://github.com/waspeer/esbuild-plugin-glob
Describe the solution you'd like
Provide an option to describe additional entrypoints so that code that is required for runtime but not imported (in a way that esbuild can analyse) can be included in the bundle, so that handler code can access these files.

OK @samchungy I've managed to write a plugin to enable this, but its a bit brittle IMO.
Demo repo: https://github.com/mishabruml/typeorm-playground
The plugin is written in TS and gets compiled via esbuild and wired into serverless-esbuild via plugins file
The typeorm datasource globs migrations files conditionally on env var. This enables TS migrations files to be run via typeorm CLI (ts-node under the hood), or js files for the lambda execution environment. I couldn't just simply provide both globs as arg to the migrations option because the TS files contain imports form typeorm that are not available at lambda runtime when bundled with esbuild, and so produce runtime errors.
The lambda can be invoked locally, but in order to run this you'll need a postgres db running locally at postgres://postgres:postgrespw@localhost:55001 (I did this with docker)
I did find a limitation; the migrations directory (or any directory passed in to additionalEntrypoints option of additionalEntrypointsGlobPlugin) needs to live inside the src/handlers directory otherwise esbuild gets very confused resolving output build directory structure. This is something I'd like to understand more.


Domain shell template is not mobile responsive

assign me this issue so that i can work on it

Best of luck 🤞

https://github.com/Diptenusarkar/Website-Template/pull/73  pls merge @Diptenusarkar


backend API for customising user subscriptions

User story

As a frontend developer
I want/need backend APIs
So that users' subscription options can be stored

Acceptance criteria

APIs built with Express JS
find a way to authenticate users

Definition of done (DoD)

Feature is done when the acceptance criteria are fulfilled
Feature is done when there are test where it is necessary and they pass
Feature is done when the linter passes
Feature is done when it is merged onto our main branch (after the code has been reviewed by at least one other person)
Feature is done when the code has been documented or commented properly

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

User authentication has done by JWT and one-time login code sent by email.


Update the default behaviour of the example configuration

Context:
PennyLane allows setting plugin-specific defaults for computations by using configuration files.
However, the current config.toml examples include setting defaults which differ from the default values used in the plugins, e.g. hbar = 1 for the PennyLane-SF plugin.
This can result in unexpected behaviour, especially in cases when considerable time has passed between the creation of the configuration file and using the plugin.
Description of the Change:

Added further description to configuration files
Uncommented default configuration options in the configuration file

Benefits:
By simply taking the example configuration file, no defaults are set.
Possible Drawbacks:
Slightly more instructions for configurations.
Related GitHub Issues:
N/A

Note: I think default_config.toml was used for some of the tests, so you might need to make an uncommented version for the test suite!


Create BLOB container for ADLS Gen2 Preview Storage Account Fails

Storage Explorer Version: 1.6.2
Platform/OS: Windows 10
Architecture: ia32
Build Number: 20190108.2
Bug description
Cannot create a BLOB container under  an ADLS Gen2 storage account. Returns a EPROTO error in storage explorer (see attached image).
Steps to Reproduce
1.install 1.6.2
2.create a Gen 2 ADLS with Hierarchical Namespace
3.sign in to storage explorer
4. navigate to storage account (it does show ADLS Gen2 Preview)
5. right click on Blob Container and select Create Container
6. give it a name
Expected Experience
A new container is created
Actual Experience
EPROTO error.

I am experiencing this exact same issue today, @MRayermannMSFT  do you have any update?
[Window Title]
Microsoft Azure Storage Explorer
[Content]
Unable to retrieve child resources. Details: write EPROTO 0:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:d:\buildagent\workspace\318698\vendor\node\deps\openssl\openssl\ssl\s23_clnt.c:827:
[OK]
My desktop goes out via a WPAD.DAT proxy, and so I typically use fiddler as the proxy to "get through" the WPAD.DAT.
I can see fiddler trying to connect to the file shares on the https://.file.core.windows.net but I don't see any attempt to connect to the https://.blob.core.windows.net.
(I can see traffic to the queue and table endpoints, just not the blob endpoint)

@MRayermannMSFT  from what I can tell any storage account that has the ADLS Gen2 Preview won't connect to the blob endpoint.
I can connect to all other endpoints on these storage accounts, and I can connect to the blob endpoint on other storage accounts that do not have the ADLS Gen2 Preview features enabled.

I know it's been a while but I can't replicate this issue using Azure Storage Explorer 1.8.1. ADLS Gen2 is now GA as well. I'm not sure what was fixed but please try newer releases of Storage Explorer.

Sounds like this was fixed/mitigated. Going to go ahead and close.


Use Cucumber Expressions rather than Regular Expressions

Background
The 10 minute tutorial still uses Regular Expressions. Other pages possibly too.
Solution
We should use Cucumber Expressions everywhere (except when we explain regular expressions explicitly).

I'd like to pick this one up in the context of our local Hackergarten event today.

That would be much appreciated @Riggs333! Have a fun Hackergarden!


Node metrics

User stories
As a Training Coordinator, I want to see the metrics for my node (only), so that I can use that in funding applications and reports, and improve quality of training in my node.
As a Training coordinator, I want to see the detailed view of each metric type (quality, demographics, impact) for each event separately, so that I can make sure they correspond with the data that has been gathered.
Sub-stories

[ ] As a user, I can log in with username/email and password.
[x] I am recognized as an authorized user (such as Training Coordinator) for my node.
[x] I can see ELIXIR-wide metrics (for which no login is required).
[x] I can see node-specific metrics (for my node only) for all training events.
[x] I can see node-specific metrics (for my node only) for a single training event at a time, for a single metric type at a time.
[ ] The node-specific metrics charts/tables that I see are the same as for the ELIXIR-wide metrics, but based only on my Node's data.
[ ] I can export node-specific data for charts (for my node only) in CSV/Excel format.
[x] I can log out.

Check that the login functionality still works, there seem to be some issues

Check that the login functionality still works, there seem to be some issues

Logging in works fine for me, for credentials see the users.csv file on the VM.


Install error "requires illuminate/cache ^9.0 -> found..."

Describe the bug
 Problem 1     - Root composer.json requires genealabs/laravel-model-caching ^0.12.4 -> satisfiable by genealabs/laravel-model-caching[0.12.4].     - genealabs/laravel-model-caching 0.12.4 requires illuminate/cache ^9.0 -> found illuminate/cache[v9.0.0-beta.1, ..., 9.x-dev] but these were not loaded, likel y because it conflicts with another require.
Environment

PHP: 8.1.4
OS: Windows 10 x64
Laravel: 8.83.7
Model Caching: 0.12.4

@Sans84 Hello, did you manage to solve this problem?


Add parsing number of nics from RHV inventory

During refresh parse the number of nics a host has and put it in hardware.
This fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1397171

@miq-bot assign @masayag
please review sir.

assign @durandom

@miq-bot assign durandom

@miq-bot assign @blomquisg
@blomquisg please merge

@miq-bot add_label providers/rhevm, bug, euwe/no
@oourfali its not yet slated for euwe - should it be?

@miq-bot remove_label wip
not sure why it was "wip"ed

@agrare fixed according to your comment, thanks for the catch, is it ok to merge now?

LGTM :+1:


RuntimeError: Communication Exception running gen2-triangulation

Finally getting back around to trying out the face detection with stereo demo and I find that it runs fine for about 5 seconds but then crashes with the following error:
Traceback (most recent call last):
File "main.py", line 207, in
frame = queues[i*4].get().getCvFrame()
RuntimeError: Communication exception - possible device error/misconfiguration. Original message 'Couldn't read data from stream: 'mono_left' (X_LINK_ERROR)'
It only crashes when someone steps in front of the camera and face detection starts working.

Thanks for the report and sorry for the trouble.  Not immediately sure.  But CC: @Erol444 on this.

If it helps, it failed today with a:

Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)

Hello @madgrizzle , I have just pushed a small edit to latest master branch of depthai-experiments. Could you try using that + the latest develop branch of depthai-python? So checkout to develop branch and run python3 examples/install_requirements.py to get the latest develop version of our library. Using that seems to fix the issue. Thanks for reporting!

Awesome, will try tonight!  Thanks for looking into it.

It works great!  Thanks for the fix!

Well, turns out that it just seems to work 'better', but it still crashes.  I'm not entirely sure why I wasn't getting these messages before, but I recently did an update to depthai-python.  This occurs right before the crash:
[14442C10411DC2D200] [470.453] [system] [critical] Fatal error. Please report to developers. Log: 'PoolBase' '66'
[14442C10411DC2D200] [267.191] [system] [critical] Fatal error. Please report to developers. Log: 'PoolBase' '66'
Traceback (most recent call last):
File "main.py", line 214, in
frame = queues[i*4].get().getCvFrame()
RuntimeError: Communication exception - possible device error/misconfiguration. Original message 'Couldn't read data from stream: 'mono_left' (X_LINK_ERROR)'

@madgrizzle I'm not immediately sure why this issue occurs, will check with the team too. Could you specify which depthai version you're using?

@madgrizzle it appears to be a bug in the depthai itself and @themarpe managed to fix that right away (kudos!). I'll circle back once the experiment is updated with a library version containing the fix, so you'll be able to test again.
Thanks for reporting the issue!

Just curious.. is the "bug in depthai itself" a bug in the FW or a bug in depthai-python (or something else)?

@madgrizzle it was a bug in FW regarding how messages are shared across the two cores available.
More specifically some cache coherency issue.

I spun up ubuntu 20.04 onto a RPI 4 and got everything installed and running with the same result after a few seconds. It did manage to spit out more information though:
terminate called after throwing an instance of 'dai::XLinkReadError'
what():  Couldn't read data from stream: 'mono_left' (X_LINK_ERROR)
Stack trace (most recent call last) in thread 35627:
#6    Object "[0xffffffffffffffff]", at 0xffffffffffffffff, in
#5    Object "/lib/aarch64-linux-gnu/libstdc++.so.6", at 0xffff7bda6573, in __cxa_throw
#4    Object "/lib/aarch64-linux-gnu/libstdc++.so.6", at 0xffff7bda627f, in std::terminate()
#3    Object "/lib/aarch64-linux-gnu/libstdc++.so.6", at 0xffff7bda621b, in
#2    Object "/lib/aarch64-linux-gnu/libstdc++.so.6", at 0xffff7bda88cb, in __gnu_cxx::__verbose_terminate_handler()
#1    Object "/lib/aarch64-linux-gnu/libc.so.6", at 0xffff8c66fd67, in abort
#0    Object "/lib/aarch64-linux-gnu/libc.so.6", at 0xffff8c683138, in gsignal
Aborted (Signal sent by tkill() 35550 1000)
Aborted (core dumped)

@themarpe Perhaps this should be an issue 'somewhere else' (I'll ask on discord) but it appears that the ImageManip config errors occur when resize width is less than half the height.  I was testing it at lunch and started to slowly move my hand in front of my face and the 'box' (that gets drawn on the screen) started to narrow.  When it got around half the height, the errors started to occur.  I had to get back to work but I'll do some more testing tonight and see if I can catch those events.

I solved this problem by modifying this line of code
with dai.Device(p.getOpenVINOVersion()) as device:
to this
with dai.Device(p.getOpenVINOVersion() ,usb2Mode = True) as device:
I just add usb2Mode =True
The program is working fine now without stopping
You can understand the problem that occurs from this link:
https://github.com/luxonis/depthai-python/issues/318#issuecomment-884219556

The version on the repo still crashes for me if I make the change you described.
I then tried a version that I made that has a few extra tweaks to the ImageManip script to help reduce invalid configs that seemed to help it run better and it crashed as well.  So, I then removed all the video frame grabbing to lower the bandwidth and it still crashed under USB-3.  But when I forced it to usb2Mode, it ran stable... but after stopping it and do some other testing, it crashed.  I honestly don't know what's going on with it now.  Sometimes it just seems to stop detecting without even crashing (hanging though spewing out the "INFO" messages).
So, I keep wondering if its a hardware problem.  The more I work with it and try different things, the worse it gets. I give up, let it rest and I come back to it days later and it works better initially but then eventually craps out again and again.

Turns out the latter problem where it seems to hang without crashing was caused by the optimizations I made.  When you don't retrieve the frames (left, right, cropped, etc.), the host program's loop runs too fast and it empties the queues of config and landmarks and only rarely gets both left and right landmarks at the same time in a single loop's iteration.  I had to slow down the loop by adding more delay to the cv2.waitkey() so that it's not emptying out the queue.

Cross posting for visibility - https://github.com/luxonis/depthai-python/issues/408#issuecomment-961157245
Main issue as far as I've dug into it, is that a memory corruption is happening in a non-deterministic way, which looks like something might be wrong with the hardware, but its just that the bug is "random" and hard to pin down to a specific cause.
Will keep you posted after I discover more information about it

@madgrizzle  could you try installing the following library, it contains some fixes for Script node related memory allocation:
python3 -m pip install -U --prefer-binary --user --extra-index-url https://artifacts.luxonis.com/artifactory/luxonis-python-snapshot-local "depthai==<IP_ADDRESS>.dev+7498afce36f34dae5482c2bbf42db317e3e53dd5"

Then modifying the script by adding the following (@alex-luxonis  suggested ):
image_manip_script.setProcessor(dai.ProcessorType.LEON_CSS)

Knock on wood, but this so far seems pretty stable.  I've let it run for about 8 hours so far without issue on the RPI.  I'll let it run overnight and then switch to the x86 host to see how it works there.

No problem running overnight.  I'm now trying out the script from https://github.com/luxonis/depthai-python/issues/408#issuecomment-961157245 that I modified to include facial detection/recognition.  Previously it would run for a few seconds and crash, but its been running for 15 minutes now with no issue.

@madgrizzle Thanks for the tests!
Was .setProcessor(dai.ProcessorType.LEON_CSS) added as well in the Script nodes?
If yes, could you also try removing it and see if it's still stable. Would help us in investigating any more issues when running on the default LEON_MSS core.

I had done both changes.  When I go home at lunch, i'll undo the setProcessor and see what the effect is.

@alex-luxonis Couple things.. First it appears that for the gen2-triangulation script, I did not change it to LEON_CSS (only the updated depthai).  I went ahead and set it to LEON_MSS and will let it run for a while to to be absolutely certain.
Second, the script from https://github.com/luxonis/depthai-python/issues/408#issuecomment-961157245 with my face detection/recognition additions however did crash using LEON_MSS rather quickly (seconds to minutes) and ran for 12+ hours last night using LEON_CSS without crashing.  However, when playing around at lunch time (i.e., switching back and forth between MSS and CSS), it did crash with LEON_CSS after about a 15 minute run.  That potentially could be related to something else (like ImageManip or maybe just the process of switching the code or something).
Definite improvement running the new depthai + the script node in LEON_CSS processor.

@madgrizzle thanks for extensive testing - the findings support my theory that moving to CSS only mitigates/suppresses the issue but isn't the cause of it.
We'll look into the underlying cause to resolve it properly, in the meantime the mitigation seems to be quite effective

@themarpe seems so.. good enough for my use-case (giving my robot some vision).

Ack.. accidentally closed.

@madgrizzle in latest develop is a patch that should reduce the issues even further.
MSS might work as expected now.
Feel free to test in your usecase if it improved:)

It ran gen2-triangulation pretty solid (I stopped it after 10 minutes), but then I ran it on my yoloSpatialCalculator+face recognition program that often hangs on 2.13.3 after a few minutes and this version did the same.  Never consistent on when either occurs.. sometimes a couple of minutes, sometimes after a couple of hours, butsometimes just a few seconds.
I do still notice lots of ImageManip unsupported config errors.  Any progress on addressing that (I can deal with it, nevertheless)?

Thanks for testing - is your yolo + face recognition available somewhere openly? Might be a good benchmark to test against, just so that error is more easily observed.
Regarding ImageManip, we have a branch for it, but there are a couple of extra things to fixup and retest, so might take a bit more. I'll also address the issue with unsupported config errors :)

It's currently part of a ROS node, but it won't be hard to strip it out and make it run standalone.  I should have it on my repo tonight and will post a link.

This is my repo with the code I'm using.  https://github.com/madgrizzle/visiontest
It ran 12 hours today with no one in the room.  When I walked it, it said it detected an elephant (great for my ego) and a few minutes later it locked up while my head was down looking at my phone.  One key I've discovered to making it lock up is putting my hands to my face (like rubbing my eyes.)  It doesn't happen all the time, but so often that it has to be more than coincidence.

Thanks, will try to recreate:)

I'm current running <IP_ADDRESS>.dev+61eb5c1617623c628fab1cc09d123073518124b0 with great success.  It ran for days using LEON_CSS until I intentionally stopped it.  I'll try out LEON_MSS as well.  I've added a few things to the pipeline since the code in the visiontest repo and moved it back into my ROS node because it appears stable enough for me (/em crosses fingers).


Create update.md

Your pull request seems good, but must be checked by a human maintainer for the following reason(s):

Your file is not in a project folder ("Friends"). This may be intentional, but most likely not.

Please be patient until a maintainer has time to look over your contribution.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

69e8c0cf3a0442caef4515dea4bbd542a34c7a2f

This does not follow the rules, does not provide anything useful to the repo, and overall seems like a pr done in a matter of seconds just for the sake of doing a pr. Closing and locking.


Disallow functionality option for /gq route

I am looking at a workaround for this, similar to a robots.txt Disallow option. Maybe this should be an option provided by react-navigation-web.

What's gq route?

@satya164 It is common in dev environments to have a graphiql interface route for testing at /gq (according to docs)
My question is more broad however, other web routing solutions provide routes for params and other optional matching. I see however in this example repo the proper configuration syntax to refer to
https://github.com/react-navigation/example-web/blob/master/src/App.js


Where to find PlayFab.Samples from the HelloWorld example

The referenced namespace is available at
https://github.com/PlayFab/PlayFab-Samples/blob/master/Samples/CSharp/AzureFunctions/CS2AFHelperClasses.cs

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b983a98a-cd59-bd62-eda6-5cdfabacc256
Version Independent ID: 0e90c26b-45f2-3a0c-1af1-a0aa5a0e1261
Content: PlayFab CloudScript using Azure Functions Quickstart Guide - PlayFab
Content Source: playfab-docs/features/automation/cloudscript-af/quickstart.md
Product: playfab
GitHub Login: @williacj
Microsoft Alias: cjwill

Thank you for catching this! We have updated the documentation with a link to the relevant resource.


 This is not needed anymore since github introduced a setting to always use the PR title as the commit message during squash and merge.

This will hopefully be appreciated by @agardnerIT 😅


Support for getDisplayMedia

I want to implement the ScreenSharing-API ( https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getDisplayMedia ) in an webview.
You mentioned getDisplayMedia in https://github.com/OpenTelecom/WKWebViewRTC/blob/b53de42b36f475f52e6c8cd75320620448410948/WKWebViewRTC/Js/src/MediaDevices.js#L31 but I think, it is not implemented yet.
Are there any plans to implement these functions as well?

See existing PR for iOSRTC that this WebRTC implementation is based on: https://github.com/cordova-rtc/cordova-plugin-iosrtc/pull/424


Dev markdown

agree

Might not want to push the entire node_modules dir 😄

This does.. what, exactly? PR title doesn't tell anything.


Better support to work with video streams / custom dictionaries

Thank you for the added functionalities. I merged the pull request, and also added the instructions to run the command line options you added to the ReadMe. Also, I prefer not to use using namespace xxx because of the reasons mentioned here, so I removed them and updated the code to reflect this. All these changes are in our master branch.
I am just letting you know since if you make any pull request in the future, we might run into merge conflicts. Please consider merging our master branch to yours if you think you might push your future updates.
I really appreciate your contributions, and hope you continue to do so if you add more functionalities in the future. Cheers! :metal: :octocat:


Struggling with Desock

Hello,
I'm trying to use preeny to be able to fuzz StrongSwan, which is an IPsec implementation.
I make use of a named pipe to feed my input to the process (which works with the test case provided by preeny)
When enabling debug and starting StrongSwan, it tells me that the following happened (using desock):
--- synchronization of fd 0 to 510 shutting down due to read error ''

During loading of the process, it does throw a couple of warnings: (from StrongSwan's side):
00[NET] unable to set IP_PKTINFO on socket: Operation not supported
00[NET] could not open IPv6 socket, IPv6 disabled
--- Emulating bind on port 500
00[NET] unable to set IP_PKTINFO on socket: Operation not supported
00[NET] could not open IPv4 socket, IPv4 disabled

When I switch to desock_dup, it does not respond to any input.
Again, it gives me some warnings:
00[NET] changing socket permissions for 'unix:///var/run/charon.ctl' failed: No such file or directory
--- Emulating bind on port 12150
00[NET] changing socket permissions for 'unix:///var/run/charon.vici' failed: No such file or directory

I've not been able to figure out what is causing this.
I was wondering if you guys have any idea how this can be fixed.
Kind regards,
Tom

It looks like it's doing operations on that socket that preeny doesn't intercept. To solve that, you'll need to figure out what functions it's calling (using ltrace or something) and add them to desock.c. That's a good place to start, at least.

Thanks for your quick response.
I will start my search from there


support for haskellPackages

Something like the way rPackages are handled.

Closed via https://github.com/stencila/nixster/commit/8d45371d1491634d769255e908073fa365fb7b88 and available in https://github.com/stencila/nixster/releases/tag/v0.1.2


How to get D3D12 command queue from Bgfx?

A D3D12 device can be retrieved from bgfx::getInternalData()->context, but how about command queue? The caller may need to access to a command queue for additional rendering tasks.
Do you think it's OK to put the command queue as a private data of device? If so, I can author a PR to address this.

When and how this would be used?

For example, the XR_KHR_D3D12_enable extension of OpenXR https://www.khronos.org/registry/OpenXR/specs/1.0/html/xrspec.html#XR_KHR_D3D12_enable, requires the caller to set a D3D12 command queue from renderer. In this case, the ability of retrieve the command queue is necessary.

Why not create new queue?

The OpenXR runtime need to sync with renderer, via this command queue. Create a new one can't  guarantee the sync.

Ok, let me think about this one, because it might not be as simple as giving you a queue.
For now modify your version of bgfx and let me know how that works for you (test on different GPUs).

By exposing the D3D12 command queue, I can connect bgfx to OpenXR. Tested on both NVIDIA and AMD. On NVIDIA, everything's OK. On AMD, it's flashing in the headset. It's caused by depth texture, very likely to be the one I reported to AMD months ago, not related to bgfx.

Can you just describe how you obtain it?
I assume you just do GetPrivateData(IID_ID3D12CommandQueue, &data, sizeof(void*));
https://docs.microsoft.com/en-us/windows/win32/api/d3d11/nf-d3d11-id3d11device-getprivatedata
https://github.com/bkaradzic/bgfx/pull/2048/commits/cb5f7c7f035a0d6ae769063f8eb3115912ff90f6

Yes, I'm using something like:
ID3D12CommandQueue* commandQueue;
UINT size = sizeof(commandQueue);
device->GetPrivateData(IID_ID3D12CommandQueue, &size, &commandQueue);

to get the command queue in the caller of bgfx.


No plots after upgrading to jupyterlab 1.0.3

Installed packages:

(devel) pointyhaired@gtrojan> conda list ipympl
# packages in environment at /home/george.trojan/miniconda3/envs/devel:
#
# Name                    Version                   Build  Channel
ipympl                    0.3.3                      py_0    conda-forge
(devel) pointyhaired@gtrojan> conda list jupyter
# packages in environment at /home/george.trojan/miniconda3/envs/devel:
#
# Name                    Version                   Build  Channel
jupyter                   1.0.0                      py_2    conda-forge
jupyter_client            5.3.1                      py_0    conda-forge
jupyter_console           6.0.0                      py_0    conda-forge
jupyter_core              4.4.0                      py_0    conda-forge
jupyterlab                1.0.3                    py37_0    conda-forge
jupyterlab_server         1.0.0                      py_1    conda-forge
(devel) pointyhaired@gtrojan> conda list ipython
# packages in environment at /home/george.trojan/miniconda3/envs/devel:
#
# Name                    Version                   Build  Channel
ipython                   7.6.1            py37h5ca1d4c_0    conda-forge
ipython_genutils          0.2.0                      py_1    conda-forge

(devel) pointyhaired@gtrojan> jupyter labextension list
JupyterLab v1.0.3
Known labextensions:
   app dir: /home/george.trojan/miniconda3/envs/devel/share/jupyter/lab
        @jupyter-widgets/jupyterlab-manager v1.0.1  enabled  OK
        @pyviz/jupyterlab_pyviz v0.8.0  enabled  OK
        jupyter-matplotlib v0.4.2  enabled  OK
        jupyterlab-drawio v0.6.0  enabled  OK
        jupyterlab_bokeh v1.0.0  enabled  OK
        jupyterlab_vim v0.11.0  enabled  OK

Code:

%matplotlib widget
import matplotlib.pyplot as plt
fig = plt.figure(figsize=(8, 8))
ax = fig.add_subplot(1, 1, 1)
_ = ax.plot([0, 1], [0, 1], '-')
plt.show()

Behaviour:

First run:
Nothing appears in the browser (Firefox), log warnings:

[I 19:22:55.878 LabApp] Kernel restarted: cac8af90-19f9-46f3-b711-5dc73e000f4a
[IPKernelApp] WARNING | No such comm: d0d520499eb94506808d830dd0cdc294
[IPKernelApp] WARNING | No such comm: 80813842daba4f89a97d734ec5a9abc6
[IPKernelApp] WARNING | No such comm: d0d520499eb94506808d830dd0cdc294
[IPKernelApp] WARNING | No such comm: 685a0cc2c96941c784b15b72d3ded931
[IPKernelApp] WARNING | No such comm: c35f6dd5095f47639f7635fd9d59b77c
[IPKernelApp] WARNING | No such comm: d0d520499eb94506808d830dd0cdc294
[IPKernelApp] WARNING | No such comm: d0d520499eb94506808d830dd0cdc294
[IPKernelApp] WARNING | No such comm: d0d520499eb94506808d830dd0cdc294
[IPKernelApp] WARNING | No such comm: d0d520499eb94506808d830dd0cdc294
[IPKernelApp] WARNING | No such comm: d0d520499eb94506808d830dd0cdc294

Second run (without kernel restart):
Control buttons (Toggle interaction etc...) displayed on the left, plot not shown. The log shows similar lines, with different codes.

[IPKernelApp] WARNING | No such comm: e0fda28094cf418e84b5cf36b9a1f555
[IPKernelApp] WARNING | No such comm: e0fda28094cf418e84b5cf36b9a1f555
[IPKernelApp] WARNING | No such comm: b9cf5e11dc9748d4b690c69374fb8f1f
[IPKernelApp] WARNING | No such comm: e0fda28094cf418e84b5cf36b9a1f555
[IPKernelApp] WARNING | No such comm: e0fda28094cf418e84b5cf36b9a1f555
[IPKernelApp] WARNING | No such comm: 61f984b852ea48d5b96153ca4799ad5d
[IPKernelApp] WARNING | No such comm: b01ce5d026b64cf0998b47413e9677a5
[IPKernelApp] WARNING | No such comm: e0fda28094cf418e84b5cf36b9a1f555
[IPKernelApp] WARNING | No such comm: e0fda28094cf418e84b5cf36b9a1f555
[IPKernelApp] WARNING | No such comm: e0fda28094cf418e84b5cf36b9a1f555
[IPKernelApp] WARNING | No such comm: e0fda28094cf418e84b5cf36b9a1f555

Third run (without kernel restart):
The log shows several identical  lines

[IPKernelApp] WARNING | No such comm: e0fda28094cf418e84b5cf36b9a1f555

Traceback in the browser (buttons are not displayed):
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-3-e16fb2894584> in <module>
----> 1 get_ipython().run_line_magic('matplotlib', 'widget')
      2 import matplotlib.pyplot as plt
      3 fig = plt.figure(figsize=(8, 8))
      4 ax = fig.add_subplot(1, 1, 1)
      5 _ = ax.plot([0, 1], [0, 1], '-')

~/miniconda3/envs/devel/lib/python3.7/site-packages/IPython/core/interactiveshell.py in run_line_magic(self, magic_name, line, _stack_depth)
   2311                 kwargs['local_ns'] = sys._getframe(stack_depth).f_locals
   2312             with self.builtin_trap:
-> 2313                 result = fn(*args, **kwargs)
   2314             return result
   2315

</home/george.trojan/miniconda3/envs/devel/lib/python3.7/site-packages/decorator.py:decorator-gen-108> in matplotlib(self, line)

~/miniconda3/envs/devel/lib/python3.7/site-packages/IPython/core/magic.py in <lambda>(f, *a, **k)
    185     # but it's overkill for just that one bit of state.
    186     def magic_deco(arg):
--> 187         call = lambda f, *a, **k: f(*a, **k)
    188
    189         if callable(arg):

~/miniconda3/envs/devel/lib/python3.7/site-packages/IPython/core/magics/pylab.py in matplotlib(self, line)
     97             print("Available matplotlib backends: %s" % backends_list)
     98         else:
---> 99             gui, backend = self.shell.enable_matplotlib(args.gui.lower())
    100             self._show_matplotlib_backend(args.gui, backend)
    101

~/miniconda3/envs/devel/lib/python3.7/site-packages/IPython/core/interactiveshell.py in enable_matplotlib(self, gui)
   3411                 gui, backend = pt.find_gui_and_backend(self.pylab_gui_select)
   3412
-> 3413         pt.activate_matplotlib(backend)
   3414         pt.configure_inline_support(self, backend)
   3415

~/miniconda3/envs/devel/lib/python3.7/site-packages/IPython/core/pylabtools.py in activate_matplotlib(backend)
    312
    313     import matplotlib.pyplot
--> 314     matplotlib.pyplot.switch_backend(backend)
    315
    316     # This must be imported last in the matplotlib series, after

~/miniconda3/envs/devel/lib/python3.7/site-packages/matplotlib/pyplot.py in switch_backend(newbackend)
    193         The name of the backend to use.
    194     """
--> 195     close("all")
    196
    197     if newbackend is rcsetup._auto_backend_sentinel:

~/miniconda3/envs/devel/lib/python3.7/site-packages/matplotlib/pyplot.py in close(fig)
    675             _pylab_helpers.Gcf.destroy(figManager.num)
    676     elif fig == 'all':
--> 677         _pylab_helpers.Gcf.destroy_all()
    678     elif isinstance(fig, int):
    679         _pylab_helpers.Gcf.destroy(fig)

~/miniconda3/envs/devel/lib/python3.7/site-packages/matplotlib/_pylab_helpers.py in destroy_all(cls)
     71         for manager in list(cls.figs.values()):
     72             manager.canvas.mpl_disconnect(manager._cidgcf)
---> 73             manager.destroy()
     74
     75         cls._activeQue = []

~/miniconda3/envs/devel/lib/python3.7/site-packages/ipympl/backend_nbagg.py in destroy(self)
    211
    212     def destroy(self):
--> 213         self.canvas.close()
    214
    215

~/miniconda3/envs/devel/lib/python3.7/site-packages/ipywidgets/widgets/widget.py in close(self)
    465         if self.comm is not None:
    466             Widget.widgets.pop(self.model_id, None)
--> 467             self.comm.close()
    468             self.comm = None
    469             self._ipython_display_ = None

~/miniconda3/envs/devel/lib/python3.7/site-packages/ipykernel/comm/comm.py in close(self, data, metadata, buffers)
    114             data=data, metadata=metadata, buffers=buffers,
    115         )
--> 116         self.kernel.comm_manager.unregister_comm(self)
    117
    118     def send(self, data=None, metadata=None, buffers=None):

~/miniconda3/envs/devel/lib/python3.7/site-packages/ipykernel/comm/manager.py in unregister_comm(self, comm)
     54         """Unregister a comm, and close its counterpart"""
     55         # unlike get_comm, this should raise a KeyError
---> 56         comm = self.comms.pop(comm.comm_id)
     57
     58     def get_comm(self, comm_id):

KeyError: 'e0fda28094cf418e84b5cf36b9a1f555'

This happened on two computers updated with conda yesterday and today.

Following advice in #130
Java console shows errors like this one:
Exception opening new comm
default.js:973
Error: Object 'jupyter.widget' not found in registry
Stack trace:
loadObject/<@http://<IP_ADDRESS>:8888/static/lab/vendors~main.171ef9fec69ebef81570.js:307455:28
loadObject@http://<IP_ADDRESS>:8888/static/lab/vendors~main.171ef9fec69ebef81570.js:307434:16
_handleCommOpen@http://<IP_ADDRESS>:8888/static/lab/vendors~main.171ef9fec69ebef81570.js:306923:32
_handleMessage@http://<IP_ADDRESS>:8888/static/lab/vendors~main.171ef9fec69ebef81570.js:307029:27
DefaultKernel/this._onWSMessage/this._msgChain<@http://<IP_ADDRESS>:8888/static/lab/vendors~main.171ef9fec69ebef81570.js:306079:24
default.js:127

I had this same issue, but got it working some how. The main thing I did differently was made sure I followed every step of the instructions and made sure nodejs was installed (conda list nodejs). If you add nodejs and restart jupyter lab does it work?

Cancel that, it turns out all I needed to do:
jupyter labextension install @jupyter-widgets/jupyterlab-manager
jupyter labextension install jupyter-matplotlib

Although, my output for labextension lab didn't show them enabled before hand. Maybe rerunning these commands will rebuild JLab for you so it works?

No luck. I reinstalled jupyter-matplotlib and @jupyter-widgets/jupyterlab-manager. Current versions are:
$ jupyter labextension list
JupyterLab v1.0.2
Known labextensions:
   app dir: /home/gtrojan/miniconda3/envs/numeric/share/jupyter/lab
        @jupyter-widgets/jupyterlab-manager v1.0.2  enabled  OK
        jupyter-matplotlib v0.4.2  enabled  OK
        jupyterlab_vim v0.11.0  enabled  OK

Same thing happens with jupyterlab 1.0.2 and chromium browser. BTW,
$ conda list nodejs
# packages in environment at /home/gtrojan/miniconda3/envs/numeric:
#
# Name                    Version                   Build  Channel
nodejs                    11.14.0              he1b5a44_1    conda-forge

I am also getting this error on Jupterlab 1.0.4. I have tried reinstalling. Jupyterlab must have changed something again.

Nothing should have changed in a backwards incompatible way with JLab in a patch release. If you rebuild to pick up the extensions, does it work? jupyter lab build
What extensions does JLab say are installed?

(x) russ@z820:~/x$ jupyter labextension list
JupyterLab v1.0.4
Known labextensions:
   app dir: /home/russ/.local/share/virtualenvs/x-DW7wxhU9/share/jupyter/lab
        @jupyter-widgets/jupyterlab-manager v1.0.2  enabled  OK
        jupyter-matplotlib v0.4.2  enabled  OK
(x) russ@z820:~/x$ jupyter lab build
[LabBuildApp] JupyterLab 1.0.4
[LabBuildApp] Building in /home/russ/.local/share/virtualenvs/x-DW7wxhU9/share/jupyter/lab
[LabBuildApp] Building jupyterlab assets
(x) russ@z820:~/x$ jupyter lab
[I 14:56:32.926 LabApp] JupyterLab extension loaded from /home/russ/.local/share/virtualenvs/x-DW7wxhU9/lib/python3.7/site-packages/jupyterlab
[I 14:56:32.926 LabApp] JupyterLab application directory is /home/russ/.local/share/virtualenvs/x-DW7wxhU9/share/jupyter/lab
[I 14:56:32.929 LabApp] Serving notebooks from local directory: /home/russ/x
[I 14:56:32.929 LabApp] The Jupyter Notebook is running at:
[I 14:56:32.929 LabApp] http://localhost:8888/?token=899c6306fe7642ecaa64e7407184d8e851a3d0c5fed87d97
[I 14:56:32.929 LabApp]  or http://<IP_ADDRESS>:8888/?token=899c6306fe7642ecaa64e7407184d8e851a3d0c5fed87d97
[I 14:56:32.929 LabApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation).
[C 14:56:32.983 LabApp]

    To access the notebook, open this file in a browser:
        file:///home/russ/.local/share/jupyter/runtime/nbserver-658-open.html
    Or copy and paste one of these URLs:
        http://localhost:8888/?token=899c6306fe7642ecaa64e7407184d8e851a3d0c5fed87d97
     or http://<IP_ADDRESS>:8888/?token=899c6306fe7642ecaa64e7407184d8e851a3d0c5fed87d97
[I 14:56:37.174 LabApp] Build is up to date
[I 14:56:38.680 LabApp] Kernel started: 1ecf44bf-8b13-4bd3-bea3-a554c7371ef8
[I 14:56:38.718 LabApp] Kernel started: d7345068-2fb5-4543-85ea-69badd1ca8a6
|[I 14:56:39.452 LabApp] Adapting from protocol version 5.1 (kernel 1ecf44bf-8b13-4bd3-bea3-a554c7371ef8) to 5.3 (client).
\[I 14:56:39.465 LabApp] Adapting from protocol version 5.1 (kernel 1ecf44bf-8b13-4bd3-bea3-a554c7371ef8) to 5.3 (client).
[I 14:56:39.565 LabApp] Adapting from protocol version 5.1 (kernel d7345068-2fb5-4543-85ea-69badd1ca8a6) to 5.3 (client).
-[I 14:56:39.574 LabApp] Adapting from protocol version 5.1 (kernel d7345068-2fb5-4543-85ea-69badd1ca8a6) to 5.3 (client).

And when running using matplotlib:
[IPKernelApp] WARNING | No such comm: bf58fdab66604fd4bd5af9aba991c57f
[IPKernelApp] WARNING | No such comm: bf58fdab66604fd4bd5af9aba991c57f
[IPKernelApp] WARNING | No such comm: bf58fdab66604fd4bd5af9aba991c57f
[IPKernelApp] WARNING | No such comm: bf58fdab66604fd4bd5af9aba991c57f
[IPKernelApp] WARNING | No such comm: bf58fdab66604fd4bd5af9aba991c57f
[IPKernelApp] WARNING | No such comm: bf58fdab66604fd4bd5af9aba991c57f

Hmm, I just tried with a fresh notebook and it worked.

Did you happen to have a console open to the same kernel as the notebook? I just noticed today that that can break widgets with that no such comm error.

No I didn't. I was experimenting with jupyterlab_bokeh and then updated Jupyterlab and it broke the notebook.
Seems to be working now. Clear all outputs, save notebook, shutdown kernel, and then retry seemed to sort it out. :man_shrugging:

In my case it was console. Once it is open, nothing is plotted. Restarting kernel does not help. The server has to be stopped and started again to get rid of those "no such comm" errors.

Did you happen to have a console open to the same kernel as the notebook?

@jasongrout Do you mean a terminal window inside jupyterlab or a regular local system terminal?

I meant the window opened by selecting the File > New > Console menu item.

Confirmed behaviour from last night on a different computer: works till a console is opened. Closing console and restarting kernel does not fix the issue, the server has to be restarted.
Opened console for a different notebook is OK.

works till a console is opened. Closing console and restarting kernel does not fix the issue, the server has to be restarted.

I'm working on a fix for this.

Prototype fix up at https://github.com/jupyterlab/jupyterlab/pull/6929

I have the same problem after I upgraded Jupyterlab from 1.0.2 to 1.0.5 today. Is there any workaround?
Environment:
Windows 8.1, Firefox 68.0.1, Jupyterlab 1.0.5, python 3.7.3, via conda

I installed yesterday without issues. @yoichi-kazama can you confirm that you followed the readme instructions?

Confirmed behaviour from last night on a different computer: works till a console is opened. Closing console and restarting kernel does not fix the issue, the server has to be restarted.

Just confirming: the fix for this problem has been released in jlab 1.1.0alpha1, and will be in jlab 1.1.0

Hi @thomasaarholt thank you for the information. I uninstalled/reinstalled conda and setup Jupyterlab 1.0.5, matplotlib 3.1.1 and ipympl 0.3.3 via conda-forge, and it's working. Thanks!

Great!


Update README.md

add info about extensions

Should this simple PR be merged or closed?

I'm not sure.  I think it is a good thing if the Hpack docs are useful on their own. On the other hand, for stuff that is almost literally mapped to .cabal it might make sense to reference the Cabal docs instead.  Thoughts?

I'm not sure. I think it is a good thing if the Hpack docs are useful on their own. On the other hand, for stuff that is almost literally mapped to .cabal it might make sense to reference the Cabal docs instead. Thoughts?

Certainly.
But the doc in this PR is better than no doc, so it can't hurt.

I'm not sure. I think it is a good thing if the Hpack docs are useful on their own. On the other hand, for stuff that is almost literally mapped to .cabal it might make sense to reference the Cabal docs instead. Thoughts?

Certainly.
But the doc in this PR is better than no doc, so it can't hurt.

Problems with a large number of links to the Cabal package description specification are (a) linking to which version of the specification? And (b) the 'cost' of maintaining the links.
Rather that treat these two Hpack keys differently from all the others, I think a better solution is:

provide one introductory link in this document to the Cabal User Guide, and point the reader to the relevant part; and
state expressly that a . in the Cabal column means that the Hpack key corresponds directly to a field in the Cabal package description of the same name.


TempBlob Expose TryGetImageFormatAsTxt()

It would be great if we could you the TryGetImageFormatAsTxt() function in AL

Hi JulianTillmann.
There are no plans for now to make mentioned function external and available for AL development. Let me know if there is any gap on functions or events you needed for development. I close issue for now, feel free to re-open it.

There is a gap, we would have to handle a Blobl without HASVALUE() ourselves.
Please reconsider making the try function external or making the external GetImageType() function a Try-function.

In the next release GetImageType will be like below. It will be working with stream. Why do you need it "try" function? May be you need an event somewhere in the function?

It would just be nice to use this function without having to handle wether there is Content in the blob or not.

So what do you expect as "exit" value of the function in the case of empty stream passed as parameter?

Ping.
Is it ok to have an empty value (' ') on exit in the case of incoming stream is empty?

I re-open issue and give you an event before analyzing end of stream with Handled variable. You will be able to skip further processing if set Handled to true in your event subscriber and get empty string on exit.

Hi again JulianTillmann. After some internal discussions I still have a couple of questions to you.

From where do you call GetImageType function? Do you call from extension or somehow else?
If you call it from your code why can't you check the stream before and just skip the function call.
Waiting for your answers with more information and clarification.

sorry for the delay, lot's of Things to do ;-)
We're creating an extension in AL
We're trying to use Blob-Images in RDLC Reports. My Scenario would be:

I have a Blob field for an Image
I have three columns

Blob -> the Image itself
NOT Blob.HasValue -> to set the Hide-Value in the RDLC Image field
Blob.GetImageType() -> to set the ImageType in the RDLC Image field

So when the Report ist rendered it should use any Image in the correct image type if it exists and if not, the part of the layout doesn't show.
Would this be possible or do I need to rethink my solution?

I suggest you to process Blob.HasValue or Stream.EOS on your side, in the extension. It will be easier then to have a subscriber as I suggested initially and more flexible for analysis "exit value" if the blob/stream are empty.

So, let's close t again.


GraphQL subscription support for synchronous webhook events

I want to merge this change because it adds subscription payloads to synchronous webhooks.
Names of subscription event types are slightly changed (added "Event" at the end) since schema could not be generated for duplicated names (we had mutations with the same names). I'm not sure if we want to keep it that way or change the way we name it?
Also keep in mind that It is done so it doesn't break current flow and synchronous events will have to be further changed when we will want to drop the old way of generating payload. Unfortunately, it was not possible to make the changes so they are easily switched to just subscriptions like with the async webhooks.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-6294 Handle sync webhooks

@korycins At the moment if there is a field that is not allowed in sync event subscription it will raise a CircularSubscriptionSyncEvent(GraphQLError) during payload generation and will return errors in payload (like any other error with subscription query). As far as I remember there was an agreement that this solution was enough for now. But in the future if there will be anything wrong with the subscription query it will be validated during webhook/event creation process and not when we generate payload.


keyprovider: Upgraded tonic and prost version

Signed-off-by: R, Praveenraj<EMAIL_ADDRESS>

fmt check is failing for autogenerated code, Should I comment the src/utils/keyprovider.rs protobuf generation again in build.rs? and push the indented one?

fmt check is failing for autogenerated code, Should I comment the src/utils/keyprovider.rs protobuf generation again in build.rs? and push the indented one?

Thanks @pravinrajr9 .
tonic-build switched to use prettyplease to format output: https://github.com/hyperium/tonic/commit/d6c0fc112b2288a080fd0a727453b24d666e3d79
We may can use #[rustfmt::skip] to skip the generated keyprovider module in utils, @sameo any suggestions?
BTW, we can also combine this two commits into one.

We may can use #[rustfmt::skip] to skip the generated keyprovider module in utils, @sameo any suggestions?

Yes, that sounds reasonable to me


HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields

The change is good.
I wish we had a section in the httpfs server doc like  https://hadoop.apache.org/docs/r3.2.0/hadoop-hdfs-httpfs/index.html that documents the differences between WebHDFS and HttpFS. Like the REST APIs unsupported.

The change is good.
I wish we had a section in the httpfs server doc like https://hadoop.apache.org/docs/r3.2.0/hadoop-hdfs-httpfs/index.html that documents the differences between WebHDFS and HttpFS. Like the REST APIs unsupported.
HttpFS in most cases uses HDFS as the backend, but in theory it should support any file system, like S3A, or local file system. So it might be prudent to call out that the output can be different depending on the backend file system used.

Right. HttpFS by default (when fs.defaultFS is not configured) points to LocalFS, where I tested that it won't show those HDFS-specific fields.
The existing doc states

it is interoperable with the webhdfs REST HTTP API

It does need some revamp in my opinion.

Ok. Let's spend some time on the doc, and raise a new jira to update the doc.
+1 for the change in the PR, pending Jenkins.

The precommit for the forked PR #1289 returned fine.  +1


Scully + Netlify CMS Guide

docs: add Netlify CMS guide
Add a guide to show users how to use Netlify CMS with their Scully app/site
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/scullyio/scully/blob/main/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Other... Please describe:

What is the new behavior?
Brief guide on setting up Netlify CMS with your Scully site.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

@SanderElias @aaronfrost this is another guide for the ngConf blog that will be released soon. Thought it would be good to be in the official docs as well.


Bump the librarian version number

Third-party puppet modules that use the metadata support in newer librarian-puppet versions are broken under boxen by the 1.0.0 semver restriction. AFAICT there's no breakage here with librarian-puppet 1.4.1. 1.4.x is the official Ruby 1.8 support line now for librarian-puppet.

A newer version of librarian-puppet now exists: 2.2.3
Leaving this as it is now causes a bug:
Error fetching https://api.github.com/repos/bradleywright/puppet-emacs/tags?page=1&per_page=100: [301] Moved Permanently

This is because it's using the old GitHub API to fetch the page and not following redirects.

Thanks for the nudge on this one. I've got a couple of branches locally that will address this however I haven't got around to fully testing them out yet. I'll look to get them up this week.

Closing since this was fixed in #208


Two migrations for Azure resource groups

This PR addresses the DB changes, described below, required for the modeling of Azure ResourceGroups.

The creation of a new resource_groups table
The addition of the resource_group_id column to the existing vms table. This will support the has_many association between a Resource Group and the VMs in it.

A separate PR will be made for the model changes.

Updated PR:
Changed ems_id from int to bigint
Addressed rubocop complaint around not using hash rocket syntax.

:+1:


add node_info to SQLQuery event

Resolves #452

Description

Checklist

[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

closing in favor of #494


Nonce is detected incorrectly when account has pending transactions

I have 10 completed transactions and 2 pending ones (all sent via Metamask). When trying to send a new one (function call) via MEW, it creates a new one with nonce 11 instead of 13 and crashes with Error: replacement transaction underpriced.

But this behavior is correct.

But can't it check the pending transactions and at least offer the user a choice?

You can use offline sending / signing to explicitly specify a nonce if needed.

It doesn't solve the problem of users unknowingly replacing a transaction. Also, IMO that's an unnecessary complication for a simple procedure.

Working as intended like @CryptoSmileee said. Closing issue. Don't hesitate to reopen.

I honestly don't see how this is working is intended. It's trivial to silently overwrite a tx, potentially losing Ethereum if that tx was creating a contract (as I did, yay). Even a simple confirmation dialog "This will overwrite a tx. Are you sure you want to continue?" would be better than nothing.

Why is it a problem to wait until the transactions are confirmed?
Since this is a very special behavior where you first send two transactions via MetaMask and then via MEW. Here you may have to wait. Otherwise send the transactions directly with MEW, then it's no problem?

But I just answered that. It is a problem because it's trivial to silently overwrite a tx, potentially losing Ethereum if that tx was creating a contract. How can you not see how this behavior is very much undesirable, to say the least?
Also, one pending transaction is enough, and it doesn't necessarily have to come from Metamask, just from any other source outside MEW.


Feature 1871 units

Summary of the discussion
Import uo:unit in a way that it is not changed during import.
Asserted

Inferred

Type of change (CHANGELOG.md)
Add

oeo:unit: A unit of measurement is a standardised quantity of a quantifiable entity
oeo:physical unit: TBD

Add axiom: 'oeo:physical unit' EquivalentTo uo:unit

Update

uo:unit:

remove axiom SubClassOf: 'generically dependent continuant'
restore definition from UO

Note this PR changes the file uo-extracted.owl, maybe this needs some adaption of the import script in the oeo-tools repo later.
Other things

Protégé shuffles some alternative labels for classes not related to this PR.

Workflow checklist
Automation
Closes #1871
PR-Assignee

[ ] 🐙 Follow the Pull Request Workflow
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

Even though there is not yet an agreement on the def of the oeo:unit, we should restore the def of uo:unit before the next release with this PR.

@stap-m : This PR is now again ready for review.


pdated robomongo to 0.9.0-RC1

This is an RC version - put this in homebrew-versions. Also needs a comment about the url (see documentation)

okay ... we will wait for the release.


URLs or text should be wordwrapped.

Examples: URLs in Activity log,request builder.

I would like to work on this issue, can you please assign it to me?

Assigned to @bhuvanrawal

Implemented in activity log. Not needed in request builder


acos object

I think that we should have an opportunity to count arccos of some value. It can help in implementation Chebyshev Polynomials. For instance, we will have an ability to count them like
$$T_n(x) = \cos {(n \cdot \arccos{(x)})}$$
@Graur what do you think? Do we need object acos in eo-math or it would be better to avoid having it?

@includealex Sounds good to me. But why you choose the name acos instead of arccos? And if we implement this object, it should be a part of angle object.
@maxonfjvipon What do you think?

@Graur @includealex I like arccos too, but I'm not sure if it should belong to angle object.
When we say (angle 30).cos we mean that we want to find cosine of the 30 degrees angle, but if we say (angle 30).arrcos - it would be kind of wrong, because 30 here is not an 30 degrees angle. 30 is the result of (angle x).cos where x is the angle we want to find.
I hope we understood what I meant

@includealex maybe arccos should return angle?

@maxonfjvipon I agree with you

@levBagryansky maybe, and if user want to work with the result if arccos like with just a number, he may call as-radians or as-degrees


Update all the things (except EF Core dependencies)

see #9923 for related discussion
pin aspnet/EntityFrameworkCore dependencies
chain aspnet/Extensions dependencies through aspnet/AspNetCore-Tooling instead
run darc to grab the latest

nits:

copy a few `ReferenceResolution.md changes from aspnet/Extensions version

FYI @Eilon @ajcvickers this freezes our dependency on EFCore indefinitely.
@dougbu if you haven’t already, can you open an issue to make sure we revisit this before Preview 6 is complete? Pausing is ok as a temporary measure, but if EFCore hasn’t stabilized in a few weeks, we will need to raise the urgency on getting fixes.

can you open an issue to make sure we revisit this before Preview 6 is complete?

Filed aspnet/AspNetCore#10050

Suggested change…

I like horizontal ellipses (…) but 🆗 😸 I'll combine that with taking care of System.Text.Encodings.Web now being in the runtime packs for Microsoft.NetCore.App.


ittermediate feature maps

Hi;
I made a very simple convolution network using nngraph. I would like to see the intermediate convolution features
require 'nngraphs'
a=nn.Identity() ()
b=nn.SpatialConvolution(3,32,5,5)(a)
c= nn.SpatialConvolution(32,4,5,5)(b)
model= nn.Sequential()
model:add(nn.gModule({a},{c}))
Now I would like to see the feature map from the first conv.
Please help

#146


[js-testing] write more tests for 	javascripts/explore/components/controls/SelectControl.jsx

current coverage: 65%. bring to 70%.

up to 87%


Add Support for EDK-II DSC file format

EDK-II is open source UEFI Based Bootloader.
DSC Specification:https://edk2-docs.gitbook.io/edk-ii-dsc-specification
Signed-off-by: Ashraf Ali S<EMAIL_ADDRESS>

Yeah that's not useful enough. We might even add a generic lexer for "hash based line comments".


OLED display graphics library

May just pull in the Adafruit libraries if their licenses are compatible.

Do we a OLED display in mind which we are going to use. Not so sure how does these libraries look like. Are they generic for all displays?

https://github.com/kammce/SJSU-Dev2/blob/master/datasheets/OLED-Display/ER-OLED0.96-1_Series_Datasheet.pdf

https://www.amazon.com/HiLetgo-128x64-SSH1106-Display-Arduino/dp/B01N1LZT8L

Resolved by PR: #261 & #265


Update grafana version

Grafana 7.1.5 is affected by a number of CVEs and needs to be updated.
Please create a new release with the updated grafana version.

v0.1.2 has been released.


Moon Boots

About the PR

Adds moon boots, a fun research item that makes the wearer move as if they are in zero gravity.
They can be researched in Localized Magnetism t1 tech alongside magboots.
Why / Balance

Basically just serves as a fun low-level reward item for science. It can enable some interesting interactions with moths and potential movement tech but it's just a fairly weak item that pads out the science tree.
Technical details

adds a new IsWeightlessEvent to GravitySystem and sets up magboots to go through that codepath.
Also moves the rest of magboots code into shared since it was basically 99% there.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

add: Added Moon Boots! This science research item allows you to move like you're in zero-gravity.

Overall I wonder why IsWeightless needs to be an event, instead of having the new anti-gravity clothing system add and remove the existing MovementIgnoreGravityComponent to the wearer.

i generally find using event subscriptions a lot less buggy than dealing with adding/removing components. It avoids issues of conflicting entities trying to add or remove the same component and also doesn't have to support lifetime tracking of any kind.

It can enable some interesting interactions with moths

Did we just a speed merge an itemn, that you can easily research and craft, that one race benefits from?
Didnt we know that people gonna powergame these aspect for own sake?
These gonna givw a lot of headache to be honest....

Did we just a speed merge an item, that you can easily research and craft, that one race benefits from? Didnt we know that people gonna powergame these aspect for own sake?

You're welcome to state any specific concerns you have about this and we're happy to address them. Otherwise, since the code looked reasonable, worked fine in game, and given how trivial the mechanic is, that it needed further consideration.

Did we just a speed merge an item, that you can easily research and craft, that one race benefits from? Didnt we know that people gonna powergame these aspect for own sake?

You're welcome to state any specific concerns you have about this and we're happy to address them. Otherwise, since the code looked reasonable, worked fine in game, and given how trivial the mechanic is, that it needed further consideration.

Dunno, its easy to get and make as it seems.
Like on tier 1 and 6 iron is too accessable for moth population to able have the most funky and comfortable movement in station. Its also artificially increase moth player count, due of race benefit against others.

I mean, arent moths still one of the worst races to powergame with? (because of their heat weakness)

does this make you float above chasm?

i believe no gravity affects step trigger like that but it could be just on the grid, would need testing


(597) Add mailto subject for referrals

Context
Adding an email subject with the organisation and course names will help with analytics
Changes in this PR
Do that ^
Release checklist
Release process documentation
As part of our continuous deployment strategy we must ensure that this work is
ready to be released once merged.
Pre-merge

[ ] There are changes required to the Accredited Programmes API for this change to work...

[ ] ... and they have been released to production already

Post-merge

[ ] This adds, extends or meaningfully modifies a feature...

[ ] ... and I have written or updated an end-to-end test for the happy path in the Accredited Programmes E2E repo

[ ] This makes new expectations of the API...

[ ] ... and I have notified the API developer(s) of changes to the contract tests (Pact), or the API is already compliant

[ ] Manually approve release to preprod
[ ] Manually approve release to prod

 Add subject line to mailto links so that we can track how many referrals have come via our service.


Change mod to self

Fixes warnings with latest Rust nightly.
https://github.com/rust-lang/rust/commit/74d11d26f4042ce04c56edfd6caafa003383147d

Ta


birse, asyndeta

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[a,b]

/trunk merge


Eval MGSM

Thank you for this wonderful work.
I would like to ask whether you set top_p and temperature during the evaluation. Under what settings did you get the MGSM results in your paper? Did you average multiple evaluations? I ran your code and found that the results had some errors, but not large. The avg difference was 0.3, and some languages were 2% lower.

Hi, glad to see you reproduced our model!
We use greedy search to decode text, without setting top_p and temperature.
I think your reproduced results are acceptable.  Since the test set of MGSM is relatively small with only 250 samples per language, it is normal for the scores on a single language to fluctuate slightly under different hyperparameters, but the average score of all languages is relatively stable.
We also observed this phenomenon when reproducing other baselines, so for the MGSM dataset, we can pay more attention to whether the average score is stable.

Thank you for this wonderful work.
Hello, could you please give me a copy of your evaluation code for MSVAMP, X-CSQA, and XNLI datasets? My email address is<EMAIL_ADDRESS>or<EMAIL_ADDRESS>Thank you very much.


Front facing camera

Is it possible to switch to the Front facing camera i only get back facing....

You can provide a video stream by yourself (see https://github.com/jbialobr/JsQRScanner -> Providing a video stream in a custom way) with the constraint: video: { facingMode: "user" } (see https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia)