fix: fix slice init length

Description
The intention here should be to initialize a slice with a capacity of len(m.pendingPackets)  rather than initializing the length of this slice.
Reference issue
Fixes #...

Hi @rusttech
Unfortunately this change doesn’t compile. Mind checking it again, thank you!


updating bootstrap config sample to v3

Updated the bootstrap customization sample to v3

Hi @rinormaloku. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@rinormaloku: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
ca53c0ffe85c3d3d69f721f9c67a8f39fda59ba0
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
ca53c0ffe85c3d3d69f721f9c67a8f39fda59ba0
link
true
/test release-notes_istio

gencheck_istio
ca53c0ffe85c3d3d69f721f9c67a8f39fda59ba0
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
ca53c0ffe85c3d3d69f721f9c67a8f39fda59ba0
link
true
/test release-notes_istio

gencheck_istio
ca53c0ffe85c3d3d69f721f9c67a8f39fda59ba0
link
true
/test gencheck_istio

integ-security-multicluster_istio
ca53c0ffe85c3d3d69f721f9c67a8f39fda59ba0
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
ca53c0ffe85c3d3d69f721f9c67a8f39fda59ba0
link
true
/test gencheck_istio

integ-security-multicluster_istio
ca53c0ffe85c3d3d69f721f9c67a8f39fda59ba0
link
true
/test integ-security-multicluster_istio

release-notes_istio
ca53c0ffe85c3d3d69f721f9c67a8f39fda59ba0
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


Multiple problems with TextEdit selection while indenting

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Current master: 1401b07
Issue description:
Making indentations while having text selected has the following problems:

[ ] Indenting to the left will remove a character from the start of the selection (this also happens when undoing right indentations):

[x] Indenting to the right will add a character from the start of the selection:

[ ] Undoing left indentations will remove a character from the end of the selection:

[x] There were also times that the indentation options vanished from the context menu, but I'm not sure what causes this.

There were also times that the indentation options vanished from the context menu, but I'm not sure what causes this.

I never encountered that issue...
Currently the context menu displays these options when there is a selection, maybe we could remove that option and show it all the time?

@akien-mga This shouldn't be closed yet:

However, I was unable to fix the 3rd issue, nor the 2nd part of the 1st issue. I have some troubles with the "undo" part, I can't figure out how to record the selection in TextOperation. Maybe a dedicated issue would be a good thing, as it would keep selections even when undoing a text deletion.

I am too busy this weekend to do it, but I will open a new issue for that on Monday.
The real problem is more general: the selection is not stored into the history of actions, so it is not retrieved when undoing.

The issue seems to be resolved now? No characters are added, nor removed from the selection while doing indentations. The only "issue" is that undoing actions in TextEdit cancels selection - but this seems like an intended behaviour.
I suggest closing the issue. #14835 is still relevant and up for discussion.

@SeleckyErik Yep, seems that those issue where fixed. Closing it.


Svg animate within menu breaks the app after change page in android

From @kitkimwong on January 9, 2016 9:46
I created a tutorial app about the menu.
And I create a svg inside one of the page :
<ion-navbar *navbar>
  <button menuToggle >
<icon menu></icon>
  </button>
  <ion-title>Route</ion-title>
</ion-navbar>

<div  elastic-header style="width:100%;height:100%;position:relative;background-color:white" id ="OuterSvg">

<svg id="svgdoc"  xmlns="http://www.w3.org/2000/svg"
	version="1.1" width="100%" height="100%" (click)="OnClickSvg()"  style="position:relative">
		<g id ="ZoomGroup" >
			<image
			xmlns:svg="http://www.w3.org/2000/svg"
			xlink:href="img/subway2.png" x="0" y="0"
			[attr.width] = "width"
			[attr.height] = "height"
			id= "SubMap"
			/>

  <circle r="20" cx="50" cy="50"  id = "StopPoint2"
	style="fill:rgba(96, 42, 139, 0.3);stroke:purple;stroke-width:4;display: block;">
	<animate dur="3s" attributeName="r" values="50; 90; 50"
	repeatCount="indefinite"  />
  </circle>
		</g>
</svg>

And  open the app in the android 4.4.4, after i switch the page between the svg page and other page. the app will break unexpectedly( about 11 second in the video).
See what's happen:
https://www.youtube.com/watch?v=qEqzIY48HFo
After i remove the "animate". it works and no break.
Moreover, i reserve the animate but remove the     repeatCount="indefinite"   . it seem works too.
I don't know whether this is ionic's problem or not. But i got a bottleneck on that.
Copied from original issue: driftyco/ionic2#905

@kitkimwong Is this still an issue using alpha.54 of the framework?

@brandyscarney  Thank you for your reply. I find that every thing is fine after update to .54 version. Test on android 4.4.4

@kitkimwong Going to close this then. Thank you!


feat(select): integrate with Angular forms

This PR adds basic forms integration.
Still TODO for forms:

disabled support (see #1667)

r: @jelbourn

@jelbourn Comments addressed


A11y_SQL Azure Data Studio_New Terminal_Keyboard:Tab key or shift+tab does not move to link "https://aka.ms/pscore6" is not working.

“Check out Accessibility Insights! – Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags: #A11yMAS;#A11yTCS;#A11ySev1;#BM-VisualStudioCode-Win32-Nov2021#Visual Studio Code Client;#Win11;#FTP;#DesktopApp;#WCAG2.1.1;#Benchmark;#Keyboard;#AINotInScope;#AILimited;
Environment Details:
Application Name: SQL Azure Data Studio
Version: 1.45.0-insider (user setup)
Windows Version: Windows11
Repro Steps:

Launch Azure Data Studio Insiders application.
Tab to server drop down and tab again to button new connection press enter key and add the server details.
Tab to view menu item in the menu bar and use down key arrow to select item "terminal"
Use shift+tab to navigate to https://aka.ms/pscore6

Actual:
On navigating using shift+tab or tab to link https://aka.ms/pscore6 keyboard key tab cannot access it.
Expected:
Tab and shift+tab from the first line of command should move to link https://aka.ms/pscore6
User Impact:
Keyboard users will not be able to access the link.
Attachment:
22333_A11y_SQL.Azure.Data.Studio_New.Terminal_Keyboard.zip

primary bug:https://github.com/microsoft/azuredatastudio/issues/22333

OS: Windows
Repro steps:

open terminal tab
add a powershell terminal
run the command powershell

Expected: the link should be accessible using keyboard

I don't think Shift+tab has ever been the way we access links in the terminal, but @Tyriar pls correct me if I'm wrong.
We have a command that makes opening links keyboard accessible: Terminal: Open Detected Link

Yep, here's the docs that call that out https://code.visualstudio.com/docs/terminal/basics#_links

@Tyriar @meganrogge thanks!

thanks for the gif 👍🏼

Closing the bugs as we are able to access the links in the terminal using command
We have a command that makes opening links keyboard accessible: Terminal: Open Detected Link

GitHub Tags : #Closed;#regressed:-05-22-23


Fix ColumnarToRowIterator handling of empty batches

Fixes #2317
This updates loadNextBatch to pull from the input batch iterator in a loop as long as there are empty batches being received.

build


Mark CAPV, etcdadm bootstrap provider and controller as producing S3 artifacts

Backporting #235 to v1beta1 branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold

/unhold


Trainer should run the test loop with the best weights when ModelCheckpoint is used

🚀 Feature

Motivation

I noticed that even when ModelCheckpoint is used, Trainer by default runs the test loop with the last weights, not the best weights saved by ModelCheckpoint. I believe the sensible default here is to run the test loop with the best weights saved by ModelCheckpoint.
Pitch

Now that ModelCheckpoint has a pointer to the best weights, Trainer can replace the last weights with the best weights before running the test loop automatically.
Alternatives

Possibly, this could be another option to Trainer. I don't like this as much b/c this is the behavior most users would expect.
Additional context

Something like this?
trainer.test(model, load_best_model=True)

I would make the load_best_checkpoint=True as default...

Yeah this should definitely be the default behavior.
Another question is, we can only do this when ModelCheckpoint is used since Trainer itself doesn’t keep track of the best weights? What if someone writes their own ModelCheckpoint? It seems like there needs to be a common interface that Trainer uses to retrieve the best weights for the test loop. The best weights could then be whatever the checkpoint_callback defines it to be. In this way, I don’t think we’d need to have yet another option on Trainer.

why not make it:
test(..., checkpoint=PATH/CKPT)
with the option for a string ‘best’

why not make it:
# default
test(..., checkpoint=‘best’)

test(..., checkpoint=PATH/CKPT)

with the option for a string ‘best’
and make this the default

very good and test(..., checkpoint=None) uses the last...

Nice! I like that idea. To summarize:

add an option to test() called checkpoint whose default value is best.
if it's None, use the weights from the last epoch
if it's another string, treat it as a path.

perfect

ah yeah since using the last epoch weights is the current behavior, setting it to None (and using the last epoch weights) would effectively disable it. Let me know if my understanding is incorrect.

current behavior is equivalent to None
new default behavior should be “best”


[FEATURE] Add an AUI mod configuration that will appear in BepInExModConfigurator and Space Warp's Mods menu

Describe the solution you'd like
Create a configuration file/class that can propagate settings to the AUIManager and sub-objects.
Ideally, this would be something generic enough that I could create an alternative UI for that could be opened during gameplay (instead of having to return to the main menu).
Describe alternatives you've considered
I've also considered skipping the BepInEx and Space Warp compatibility, and just creating my own settings menu entry. I don't know what it will take to create that custom settings menu entry right now, so maybe I'll just start with the easier option first.
Additional context
Not too many options need to be added right now.

Enable/Disable Parts Picker expand/collapse toggle button

Automatically adjust OAB toolbars when collapsing the parts picker (maybe some people would prefer that the toolbars remain in a static location)

BepInEx guide on plugin configuration: https://docs.bepinex.dev/master/articles/dev_guide/plugin_tutorial/4_configuration.html


Doc links broken with latest commit?

Just a heads up - lots of external sites link to e.g.:
https://github.com/WPO-Foundation/webpagetest-docs/blob/master/user/Scripting.md#blockdomains
Which should go instead to:
https://github.com/WPO-Foundation/webpagetest-docs/blob/main/src/scripting.md
Even the links on this page are incorrect: https://github.com/WPO-Foundation/webpagetest-docs

Yeah..I need to update that readme.md for sure!
The docs are getting some needed love—a facelift, many sections getting rewritten/added, etc. The canonical source going forward for that link is https://docs.webpagetest.org/scripting/.
(The source will still be this repo though to make it easy to file issues/contribute, etc)
Will update the README.md ASAP.

README.md is in much better shape.


WIP - refactor libpod config into libpod/config

code lgtm to me .. lets get the tests passing.

code lgtm to me .. lets get the tests passing.

Found the needle in the haystack. The default config must not set the config.StorageConfig, otherwise c/storage won't apply the correct labels to the created directories.

Now rebased. Still need to find the regression wrt to the container state.

@baude @rhatdan ... I can't believe we're (nearly) green. The on failing job is broken due to an old conmon version on the image.

/lgtm


Increase certificate storage resilience (EXPOSUREAPP-8113, EXPOSUREAPP-8117)

There are a handful of user reports that stored vaccination certificates are lost after updating the app.
Initial suspicions that I ruled out:

Racecondition between loading and storing the data. We store every new data set including the initially loaded one. It's not possible to store new data before the initial emission (see HotDataFlow init). So once data was stored, it is returned on re-init, and thus also saved again. If it fails to load the initial data for some reason the app crashes.
Racecondition between multiple data changes and saving them, causing overlapping access to the shared preferences used for storage. The debugger shows that the onEach used to save the data is only entered once. There is no overlap.

My working theory:
Unknown filesystem issues (permissions, low storage, corrupt file system) prevent storage from being written. SharedPreferences does not really throw exceptions. User sees the certificates while the app session is running as the data is in memory. It could be more likely if features like "adopt sdcard as internal storage" are used. User reports were not clear on whether such setups are in use. I don't see how the CWA could reasonably handle that. :thinking:
This PR is more of a shot in a dark that increases the overall resilience with little downside:

Assure no overlapping load/saves by using a Mutex to guard access.
Use edit().commit instead of apply, to force a write to storage. We are on a different thread and get no penalty for the blocking call.

Could it be that we do multiple reading and writing from the certificates storages?  and that increases the probability to lose them at  any time when  saving them again. it is very unlikely that the Certificates once scanned in the App that its data will change and therefore there is no need to have such mechanism for reading and writing. if we save them once and just read multiple times that would reduce the potential to have such issues, what is your thoughts about that?

Could it be that we do multiple reading and writing from the certificates storages?

We only read once, when HotData initializes.
But we write multiple times, every time hot data changes.

and that increases the probability to lose them at any time when saving them again. it is very unlikely that the Certificates once scanned in the App that its data will change and therefore there is no need to have such mechanism for reading and writing. if we save them once and just read multiple times that would reduce the potential to have such issues,

I have thought about reducing the amount of writes, by checking if it is already written. We can't trust SharedPreferences a 100% there though as it also has an in memory cache, so even if SharedPreferences returns the same value, it's not guaranteed that it's written to disk already. It should only be a problem if we have multiple reads+writes., if we only have multiple writes, I don't see how we could up with "" (empty data), as old data could only get lost by overwriting it.

what is your thoughts about that?

We could add some filtering to the storage writer (flow collection in the init blocks), a drop(1) for the initial re-emission, and a distinctUntilChanged to not rewrite data if we already wrote it. :thinking: I don't see any downsides.
Overall I'm still fairly confident in the original code. I don't see a bug there.
The user reports are a bit inconsistent.
Some reports that say that rescanning yields "Error: Already registered", and some report that certificates are visible again after a reboot.
That would point to storage working fine, and it just being a UI issue.
I have not found a cause there yet, but I'm still looking. :dizzy_face:

@mtwalli I've added the .drop(1) and a dose of unit tests.
I have not found anything in the UI, but any changes will be part of a different PR.
I think this PR contains all we can do on the "storage" side of things to improve the situation.

I hope it is ok if I throw in my 2 cents:
I was reading reports in Play Store in the past days and trying to find some patterns.

Some reports that say that rescanning yields "Error: Already registered", and some report that certificates are visible again after a reboot.

That were most of all reports.
Some people stated, that only after waiting 10 to 20 minutes the DCCs suddenly appeared.
Another person tried to start an automatic error analysis, and started the error report feature. Disappointed, that the mobile didn't spit out any solution by itself, he stopped the error report - and suddenly the DCC appeared.

That would point to storage working fine, and it just being a UI issue.

From what I read, now everything points into that direction. (I'm a friend of edit().commit though, maybe Matthis remembers from discussions in the last year 😉, so doesn't hurt at all to have it implemented imho)
What I don't understand are the people where a reboot/waiting/rescanning does not change anything.

We only read once, when HotData initializes.

Is there any way that HotData initialization fails (loud or silently)? What would UI display in these cases?

I hope it is ok if I throw in my 2 cents:
I was reading reports in Play Store in the past days and trying to find some patterns.

Some reports that say that rescanning yields "Error: Already registered", and some report that certificates are visible again after a reboot.

That were most of all reports.
Some people stated, that only after waiting 10 to 20 minutes the DCCs suddenly appeared.
Another person tried to start an automatic error analysis, and started the error report feature. Disappointed, that the mobile didn't spit out any solution by itself, he stopped the error report - and suddenly the DCC appeared.

My gut feeling says it's a hanging flow somewhere, that needs to emit a value, for the operations to continue, but doesn't do so.
So a downstream flow, or a combine of multiple that includes this hanging flow is stuck.
If i manually block one of the Test/Recovery/Vaccination-Repository flows, then I get a behavior that looks similar to what the users describe.
I just can't figure out what operation could be hanging.
It's likely something upstream from here, if this blocks, the certificate view is empty, it's emission is the "person card" itself:
https://github.com/corona-warn-app/cwa-app-android/blob/2943eff83e919812f9dffd0df2d6644898fa59e1/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/person/ui/overview/PersonOverviewViewModel.kt#L55-L65

What I don't understand are the people where a reboot/waiting/rescanning does not change anything.

We only read once, when HotData initializes.

Is there any way that HotData initialization fails (loud or silently)? What would UI display in these cases?
By the way: CovPass seems to have sometimes similar issues, more rare though.

If the initialValueProvider throws an error, the app crashes. If it hangs, then no value will ever be emitted, this means no initial value, and also no updates (as any other operation would be stuck behind the initialization).
It just reads from storage though, and I don't see how it could hang for any amount of time doing that:
https://github.com/corona-warn-app/cwa-app-android/blob/2943eff83e919812f9dffd0df2d6644898fa59e1/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/vaccination/core/repository/VaccinationRepository.kt#L44-L60

And another idea: what would happen if a dependency doesn't initialize correctly? E.g., if module for QR code generation hangs, what would happen?

If it fails to initialize due to an exception, the app crashes. If it hangs, it would cause everything that requires it to hang too. The only thing big dependency being initialized in that area is the data extractor for the qrcode string, it's all static code dependencies, nothing that should be able to hang.
My favorite scape goat would be some kind of network access, but I can't make it work. The valueset repository (translations for certificates)  initiliazes only from storage, refresh via server happens async.

Last but not least question: Do the reports point to certain phones or OS? My old Android 6 phone often has timeout problems and slow storage, and I would expect such phones to be more vulnerable. But it feels that mostly newer phones are affected?

Based just on what feedback the community team gathered, no a mix of popular devices androi Android 8 to 11.
As the issue doesn't result in a crash, I can't gather any broader statistics, e.g. via Google Play Console.

If i manually block one of the Test/Recovery/Vaccination-Repository flows, then I get a behavior that looks similar to what the users describe.

Needle in haystack, but this sounds like a good starting ground.
Maybe https://github.com/corona-warn-app/cwa-app-android/pull/3751 is very promising in this context.

It's likely something upstream from here, if this blocks, the certificate view is empty, it's emission is the "person card" itself:
https://github.com/corona-warn-app/cwa-app-android/blob/2943eff83e919812f9dffd0df2d6644898fa59e1/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/person/ui/overview/PersonOverviewViewModel.kt#L55-L65

Is the cameraPermissionProvider.deniedPermanently a static stored value, or is it requested again in the moment this is called?
If this value is always requested dynamically, this could be a good candidate for a hang.
What is the certificatesProvider.qrCodesFlow for?

The only thing big dependency being initialized in that area is the data extractor for the qrcode string, it's all static code dependencies, nothing that should be able to hang.

I was especially pointing to QR code generation as I was able to observe that it sometimes took insanely much time to end generation on my device. Last week I added another 2 DCCs for 2 persons, and generation was taking more then 10s (progress indicator was running, no bar code appearing). I then jumped through menus forth and back, and the back made it appear.
Wondering whether that could interfere with the flow, resulting in symptoms described in all the reports.

My favorite scape goat would be some kind of network access, but I can't make it work.

Is the zxing module at some point involved in the flow? There were reports that it relies on Google Play Services (afair somewhere reported in the Android Lollipop issue). In that case I wouldn't be surprised if initialization causes a network request via GPS/GMS. But I think it's not a likely cause of this issue here...

no a mix of popular devices androi Android 8 to 11

If Android 6 & 7 could be clearly ruled out, then it could also be an implementation issue starting with Android 8...

If i manually block one of the Test/Recovery/Vaccination-Repository flows, then I get a behavior that looks similar to what the users describe.

Needle in haystack, but this sounds like a good starting ground.
Maybe #3751 is very promising in this context.

Doubt it, it would require Int.MAX_VALUE update calls on a data to take effect, somekind of endless loop like that would likely crash the app in some way or another as all update actions would have to stay in memory too.

It's likely something upstream from here, if this blocks, the certificate view is empty, it's emission is the "person card" itself:
https://github.com/corona-warn-app/cwa-app-android/blob/2943eff83e919812f9dffd0df2d6644898fa59e1/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/person/ui/overview/PersonOverviewViewModel.kt#L55-L65

Is the cameraPermissionProvider.deniedPermanently a static stored value, or is it requested again in the moment this is called?

Checked again, but this is not known to hang, afaik.

If this value is always requested dynamically, this could be a good candidate for a hang.
What is the certificatesProvider.qrCodesFlow for?

Generates the QR Codes, but should not be the  cause because it starts out with an empty data. The UI will show the loading indicator, once the qrcodes are generated, a new emission is combined again. combine can only block if one of the flows has no emission at all.
https://github.com/corona-warn-app/cwa-app-android/blob/2943eff83e919812f9dffd0df2d6644898fa59e1/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/person/ui/overview/PersonOverviewViewModel.kt#L135-L144
The first emit(...) prevents this from causing hanging.

The only thing big dependency being initialized in that area is the data extractor for the qrcode string, it's all static code dependencies, nothing that should be able to hang.

I was especially pointing to QR code generation as I was able to observe that it sometimes took insanely much time to end generation on my device. Last week I added another 2 DCCs for 2 persons, and generation was taking more then 10s (progress indicator was running, no bar code appearing). I then jumped through menus forth and back, and the back made it appear.
Wondering whether that could interfere with the flow, resulting in symptoms described in all the reports.

There are some not so nice things, #3752 :wink:

My favorite scape goat would be some kind of network access, but I can't make it work.

Is the zxing module at some point involved in the flow? There were reports that it relies on Google Play Services (afair somewhere reported in the Android Lollipop issue). In that case I wouldn't be surprised if initialization causes a network request via GPS/GMS. But I think it's not a likely cause of this issue here...

No it's not involved. At least not where it can block, would have to check whether we use it for image generation, but as said above, the qrcode image data starts out with an empty emission to not cause any blocking.

no a mix of popular devices androi Android 8 to 11

If Android 6 & 7 could be clearly ruled out, then it could also be an implementation issue starting with Android 8...

So far I wouldn't know what... but it seems just rare enough so that none of the more rare < Android 8 devices did not experience this yet.

Everything before

The first emit(...) prevents this from causing hanging.

=> hm. 🤔 that doesn't make it look easier. 😞

There are some not so nice things, #3752 😉

That's great! Thanks for fixing 👍

but as said above, the qrcode image data starts out with an empty emission to not cause any blocking.

=> Another: "hm." 😞 Now I ran out of ideas.

but it seems just rare enough so that none of the more rare < Android 8 devices did not experience this yet.

Trying to understand the double negation in a single sentence makes my brain hurt at this late time 😉
Have a nice evening and a good rest! 👋

LGTM.  I would expect shared prefs to be thread safe 🤔


#2 Feature/input java files function

Add utility method for when you have a collection of java files and you do not want to analyse the whole repo.

This PR contains the code of the other PR too. Can you make it clean (i.e., only the change) so that I can proper review it?
Maybe best is to close this PR and open another one.

Yes, as soon as the other is merged i will make those commits dissapear from this PR, I would have put it in draft but it seems to be a feature only for organisations :)


Add tests for CloudSdk.Builder's use of resolvers

Recover missing tests.  PTAL @loosebazooka
Fixes #183

Please resolve conflicts and rerequest a review

Sorry, seemed to have missed this. LGTM, just rebase/merge with master.


[BUG] Folder/space is dissappearing after edit (rename)

Create new subspace

Save with some name

Edit it (to change name)

It disappears along with the folder and files.
PS. Ok, actually it's moved to the root directory (out of Spaces/Home folder, so it's not visible anymore by make.md, but visible in obsidian)

I see the same. When renaming it also keeps the old Folder Note in place. So you need to manually delete it.


mail/rspamd: add map's tp phishing and helptext

https://rspamd.com/doc/modules/phishing.html

I would say @fichtner should also do a quick look and this may go straight into the next release.
This plugin may lack some help strings so you can always add them if you like.

yep, that was my intention and then I stumbled upon the map files in phishing :)


Create content store definition

Create a definition of a content store API in RAML, and corresponding RELAX NG schemas for the message bodies.

[x] Set up repo
[ ] Define content store API in RAML (https://github.com/libero/schemas/pull/1)

[ ] GET
[ ] POST
[ ] PUT
[ ] DELETE

[ ] Define schemas (https://github.com/libero/schemas/pull/1)

[ ] front
[ ] Input format

Spec now in https://docs.google.com/document/d/1JhVpW8dxAuJqnk2YsQa76yxdIV_BlOd1QIi02fIu9mo/edit.


Error occurs when run protobuild with descriptors configs

When running go list ./...|grep -v vendor|xargs protobuild under the protobuild package path, get errors:
protoc -I.:/home/user/go/src:/usr/local/include --include_imports --descriptor_set_out=/tmp/descriptors.pb-471601849 --go_out=plugins=grpc,import_path=github.com/stevvooe/protobuild/examples/foo,Mgogoproto/gogo.proto=github.com/gogo/protobuf/gogoproto,Mgoogle/protobuf/descriptor.proto=github.com/gogo/protobuf/protoc-gen-gogo/descriptor,Mgoogle/protobuf/empty.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types:/home/fly__fish/go/src /home/user/go/src/github.com/stevvooe/protobuild/examples/foo/foo.proto
/usr/local/include/google/protobuf/descriptor.proto: File does not reside within any path specified using --proto_path (or -I).  You must specify a --proto_path which encompasses this file.
According to the error message, I add -I /usr/local/include/google/protobuf to the descriptors.go file as:
func (d *descriptorSet) marshalTo(w io.Writer) error {
	p, err := proto.Marshal(&d.merged)
	if err != nil {
		return err
	}

	args := []string{
		"protoc",
		"--decode",
		"google.protobuf.FileDescriptorSet",

		// TODO(stevvooe): Come up with better way to resolve this path.
		"/usr/local/include/google/protobuf/descriptor.proto",
		"-I",
		"/usr/local/include/google/protobuf",
	}

	cmd := exec.Command(args[0], args[1:]...)
	cmd.Stdin = bytes.NewReader(p)
	cmd.Stdout = w
	cmd.Stderr = os.Stderr

	return cmd.Run()
}

And everything goes fine.

@tossmilestone Where has protobuf been installed? For this command to work, it must be installed inside /usr/local/, such that you have something like this:
$ tree /usr/local/include/google/protobuf
/usr/local/include/google/protobuf
├── any.proto
├── api.proto
├── compiler
│   └── plugin.proto
├── descriptor.proto
├── duration.proto
├── empty.proto
├── field_mask.proto
├── source_context.proto
├── struct.proto
├── timestamp.proto
├── type.proto
└── wrappers.proto

1 directory, 12 files

Originally, I had -I/usr/local/incude in there. Does that work?
If you run the command manually, what happens?
protoc --decode google.protobuf.FileDescriptorSet /usr/local/include/google/protobuf/descriptor.proto < desc.pb

This is my installed protobuf files:
/usr/local/include/google/protobuf
├── any.proto
├── api.proto
├── compiler
│   └── plugin.proto
├── descriptor.proto
├── duration.proto
├── empty.proto
├── field_mask.proto
├── source_context.proto
├── struct.proto
├── timestamp.proto
├── type.proto
└── wrappers.proto

1 directory, 12 files

Add -I/usr/local/incude works.

@tossmilestone Ok, let's add that then.

Hey @stevvooe
I've just updated protobuild and I come accross this issue too :
protoc --decode google.protobuf.FileDescriptorSet /usr/local/include/google/protobuf/descriptor.proto
/usr/local/include/google/protobuf/descriptor.proto: File does not reside within any path specified using --proto_path (or -I).  You must specify a --proto_path which encompasses this file.  Note that the proto_path must be an exact prefix of the .proto file names -- protoc is too dumb to figure out when two paths (e.g. absolute and relative) are equivalent (it's harder than you think).
2018/10/01 15:33:18 exit status 1

I've checked on my collegue that doesn't updated it yet and he has your fix that add -I/usr/local/include but I've the new version that I guess you merged 5 days ago
Do you know if I have to change something on my protobuild.toml to handle this ?


the examples do not work

Hi!
rust version:
$ cargo --version --verbose
cargo 1.31.0-nightly (de314a8b2 2018-09-21)
release: 1.31.0
$ rustc --version
rustc 1.31.0-nightly (fc403ad98 2018-09-30)

Steps:
git clone https://github.com/csharad/ruukh.git
cd ruukh/example_folder/
cargo ruukh run

I got the output:
  Compiling ruukh v0.0.2 (/Users/loothood/IdeaProjects/ruukh_test)
    Finished dev [unoptimized + debuginfo] target(s) in 2m 03s
  Generating JS bindings
error: failed to read `/Users/loothood/IdeaProjects/ruukh_test/target/wasm32-unknown-unknown/debug/ruukh.wasm`
	caused by: No such file or directory (os error 2)
     Serving at http://localhost:3000

When I open http://localhost:3000, I got just an empty page.
errors from browser console:
SyntaxError: Unexpected token '<'
 ruukh.js:2
ReferenceError: Can't find variable: wasm_bindgen
localhost:15

I had a similar issue, installing wasm-bindgen-cli from these instructions seemed to do the trick.
$ rustup target add wasm32-unknown-unknown
$ cargo +nightly install wasm-bindgen-cli

@loothood Does doing what @cldershem suggested solve your problem?

@csharad yes. that helps

Awesome! Closing this issue as it is resolved.


Consolidate prs

This PR has several commits to:

bump pre-commit hook versions
resolve pylint suggestion to use explicit encoding (as opposed to default)
add support for explicit_end using the commit from https://github.com/jumanjihouse/pre-commit-hook-yamlfmt/pull/21 (thanks @archoversight)
update example in readme from https://github.com/jumanjihouse/pre-commit-hook-yamlfmt/pull/35 (thanks @rsnodgrass)

pushed tag 0.2.1


chore(ci): automate k0s patches

What this PR does / why we need it:

Checkout and build k0s from tags and push to staging bucket for use in release.
Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?

Does this PR require documentation?

Merging as this doesnt affect ci


I286 reduce calculation time for demand graphs

implements #286 (multiprocessing for demand graphs) and fixes #309 (Key Error when running demand graphs from toolbox with certain analysis fields)

i get the next error:

@JIMENOFONSECA my apologies, I forgot to test from the script - I was testing from ArcGIS instead. It should now work.

@daren-thomas great stuff, no worries, thanks


DCSync privileges only works if a user is an admin

Describe the bug
An account with DCSync Privileges can not utilize these privileges unless they are an admin.
To Reproduce
An example of the machine account with DCSync privileges being unable to do a DCSync.
root@wpad:~# cme smb BART.sim.local -u 'BART$' -H 'f80819837d5170c19b056a5547d58423'
SMB         <IP_ADDRESS>    445    BART             [*] Windows Server 2019 Standard Evaluation 17763 x64 (name:BART) (domain:sim.local) (signing:True) (SMBv1:True)
SMB         <IP_ADDRESS>    445    BART             [+] sim.local\BART$ f80819837d5170c19b056a5547d58423
root@wpad:~# cme smb BART.sim.local -u 'BART$' -H 'f80819837d5170c19b056a5547d58423' --ntds drsuapi
SMB         <IP_ADDRESS>    445    BART             [*] Windows Server 2019 Standard Evaluation 17763 x64 (name:BART) (domain:sim.local) (signing:True) (SMBv1:True)
SMB         <IP_ADDRESS>    445    BART             [+] sim.local\BART$ f80819837d5170c19b056a5547d58423

An example of doing the same thing with secretsdump.py, but successfully doing a DCSync.
root@wpad:~/impacket/examples# python3 secretsdump.py -hashes ':f80819837d5170c19b056a5547d58423'<EMAIL_ADDRESS>Impacket v0.9.22.dev1+20200804.145312.110b886c - Copyright 2020 SecureAuth Corporation

[-] RemoteOperations failed: DCERPC Runtime Error: code: 0x5 - rpc_s_access_denied
[*] Dumping Domain Credentials (domain\uid:rid:lmhash:nthash)
[*] Using the DRSUAPI method to get NTDS.DIT secrets
Administrator:500:aad3b435b51404eeaad3b435b51404ee:cf4eafe7c79bd8d3a14891e5a8561e54:::
Guest:501:aad3b435b51404eeaad3b435b51404ee:31d6cfe0d16ae931b73c59d7e0c089c0:::
krbtgt:502:aad3b435b51404eeaad3b435b51404ee:3a3af955c3eb36b1494dbed80c28e060:::

Crackmapexec info

OS: Kali
Version of CME: 5.1.0dev, the latest release

Additional context
Maybe add an override flag for when a user knows their user can do this?

Hello,
I'm wondering in which case you can have a user with DCSync priv without being an admin ?

The computer account of domain controllers by default have DCSync privileges and are not local admins to the machine.
During a pentest it's common to get the NTLM of a DC machine account from the Print Spooler Bug in conjunction with NTLMv1 being enabled in the environment (https://github.com/NotMedic/NetNTLMtoSilverTicket).

Agreed, I will do it then ! :+1:


Feature Request: Automatically skip explicit songs

OS:
Windows 10
Issue Descriptions:
Feature Request: Automatically skip explicit songs
Steps to Reproduce:
There already is an option in the Playback tab to skip disliked songs. It would be nice to see another option here to skip songs that are marked as E (explicit).

I don't believe there is a way to do this, at least easily. The thumbs up and down are in the player bar at the bottom which makes checking for that easy. The explicit icon is only in the playlist which isn't loaded into the DOM 100% of the time. Google does have an option in their settings to block explicit songs from radio, if that suites you however.

Ah, that is.. unfortunate.
Yeah, that option exists but only for radio..

But wait... There is always a queue! queue-song-table which is a playlist with items, and there is a way to detect current playing one, it's highlighted. And it renders explicit icon!

The queue table is a data driven table that removes element if you scroll, so lets say for example you've played 100 songs, you go back to the beginning, but the list still is scrolled to the bottom. The currently playing track is no longer in the DOM. So you can no longer check for explicit tracks.


GitLab registration of workflows not working

Describe the bug
Integration tests are failing on hotfix branch when manually registering a GitLab workflow
To Reproduce
Steps to reproduce the behavior:

Run GeneralWorkflowIT#testManualPublishGitlab integration test

Expected behavior
Test should pass
Additional context
Works on develop branch because of this part of a PR. It's not clear when GitHub API changed their behavior.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Issue Number: DOCK-1260

May not want to merge this, and rollback the corresponding portion of @agduncan94 's commit, as it looks like GitLab may be rolling out a fix: https://gitlab.com/gitlab-org/gitlab-recipes/-/merge_requests/90/diffs


Support package.config

Reference: https://docs.microsoft.com/en-us/nuget/reference/packages-config

I think NuGet package soruces are stored in nuget.config file (https://docs.microsoft.com/en-us/nuget/reference/nuget-config-file).


feature request : add an prop to DtPicker component to assign id to input

hi, thanks for creating this awesome date picker component I need a feature Which I will explain below:
I use reactstrap label component and I want to assign a label to the Date picker input but can't because the component doesn't have any prop to assign an id to input
example:
import { useState } from "react";
import DtPicker from "react-calendar-datetime-picker";
import { Col, Form, Label, Row } from "reactstrap";

function Test() {
    const [date, setDate] = useState(null);

    return (
        <Form>
            <Row>
                <Col className="mb-1" md="6" sm="12">
                    <Label for="example-input"> example </Label>
                    <DtPicker onChange={setDate} inputId="example-input" />
                </Col>
            </Row>
        </Form>
    );
}

If you can not take the time to add this feature and you are busy I will try to add this feature just please let me know so I know you do not have time to do this

Unfortunately, I can't do it sooner than at least one month by now but I'll do it in the future.

Unfortunately, I can't do it sooner than at least one month by now but I'll do it in the future.

If you do not have a problem, I will add this feature to the repository myself


dependencies seem to be throwing an error

I was recently trying to generate another variant of the font, but running through the installation steps again, it seems like there might be an error.
I suspect that installing the dependencies from requirements.txt has bumped some lib dependency which has had a breaking api change?
Here is the command + error:
(venv) bash-5.1$ python3 scripts/instantiate-code-fonts.py premade-configs/config.light.cli.yaml
// ...
Traceback (most recent call last):
  File "~/recursive-code-config/scripts/instantiate-code-fonts.py", line 226, in <module>
    splitFont()
  File "~/recursive-code-config/scripts/instantiate-code-fonts.py", line 155, in splitFont
    dlig2calt(outputPath, inplace=True)
  File "~/recursive-code-config/scripts/dlig2calt.py", line 70, in dlig2calt
    font['glyf'].setCoordinates(glyphName, newCoords, font)
  File "~/recursive-code-config/venv/lib/python3.9/site-packages/fontTools/misc/loggingTools.py", line 529, in wrapper
    return func(*args, **kwargs)
TypeError: setCoordinates() takes 3 positional arguments but 4 were given

This was previously working fwiw.

i confirmed by suspicion by downgrading fonttools which i suspected was throwing the error from the error stack trace. Until a fix is in, the workaround is as follows:
# in case you've installed a newer version of fonttools
pip uninstall fonttools
pip install fonttools==4.17.0

It seems like things are working with 4.17.0 of fonttools. Upgrading from there, seems to be causing issues.

Closed with the PR #14. Thanks again, Kaushik!


ConsisID for xdit

I'm sorry that my misoperation caused the previous repository to become invalid, so I resubmitted a pull request.

Page: https://pku-yuangroup.github.io/ConsisID/
Code: https://github.com/PKU-YuanGroup/ConsisID
Demo: https://huggingface.co/spaces/BestWishYsh/ConsisID-preview-Space

You can also update the readme page with consistid on news and supported model session.

@pkuhxy Xianyi, the PR looks perfect!
I assume you have nailed the PipeFusion + USP for consistid.
If you can paste a screenshot demonstrating the consistent run with hybrid parallel successfully, I will proceed with merging the PR.

I have fix some bugs and reorganize the code. to do:

[ ] Update main README.md
[ ] Add Performance README.md

input: https://github.com/PKU-YuanGroup/ConsisID/blob/main/asserts/example_images/2.png?raw=true
https://github.com/user-attachments/assets/ecf2bced-46dc-4819-9245-6110b63dea17
input: https://github.com/PKU-YuanGroup/ConsisID/blob/main/asserts/example_images/1.png?raw=true
https://github.com/user-attachments/assets/25525796-49a3-4815-8e29-3428c632e36c

@pkuhxy Xianyi, the PR looks perfect! I assume you have nailed the PipeFusion + USP for consistid. If you can paste a screenshot demonstrating the consistent run with hybrid parallel successfully, I will proceed with merging the PR.

We have completed all parts of this PR. Please review the code and merge it. Thank you!


[VL] Extract "corr" for different implementation in spark

The 'corr' function is implemented differently in Spark and Presto. Specifically, when computing the final result, Presto uses the formula M/(sqrt(A)sqrt(B)), while Spark uses M/sqrt(AB). Even though the difference in precision between the two formulas might seem insignificant, it can result in more noticeable biases with further computations. For instance, when casting to an integer, as demonstrated in the unit test.
This PR extract shared calculations into velox/functions/lib/aggregates/CovarianceAggregatesBase.h, and provide a distinct implementation for spark "corr".
Spark's implementation reference:
https://github.com/apache/spark/blob/43852733307a229944bd254f38bcc1f84bca97fd/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Corr.scala#L124-L127
issue #4917

@mbasmanova Could you help to review this PR? Thanks!

cc: @rui-mo

The discussion before: #4917

FYI, as follow up, @liujiayi771 created a PR[https://github.com/apache/spark/pull/43711] in spark community. Let's see how Spark community comments this

@liujiayi771 @FelixYBW Thank you for the follow-up.


Uncaught TypeError: chart.interaction is not a function

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Steps to reproduce
i just run the index.html, but it has no graph. the console of chrome show: Uncaught TypeError: chartYear.interaction is not a function
What is expected?
show as this: https://f2.antv.vision/zh/examples/line/basic#pan-smooth
What is actually happening?
no graph

Environment
Info

g2
3.4.2

System
android;windows

Browser
android system webview 80;chrome 79

i run it in h5 way, so i did not use import, i use  in html

<script src="https://gw.alipayobjects.com/os/antv/assets/f2/3.4.2/f2.js"></script> did not offer chart ineractions for package size consideration. You should use <script src="https://unpkg.com/<EMAIL_ADDRESS>By the  way, it is recommended to submit this issue to the F2 repo: https://github.com/antvis/f2.


MAINT: raise error is no partial_fit in hyperparameter search

What does this PR implement?
It raises an error if a model is passed to an incremental hyperparameter optimization that doesn't support partial_fit. It points to https://ml.dask.org/hyper-parameter-search.html#hyperparameter-scaling.
It also tests to make sure that a passive search like RandomizedSearchCV works.
Reference issues/PRs
This resolves #839. It doesn't solve the issue, but it makes the error more clear.

In ba8b4fec4c2aca52c0bffd4d4917256e91045688, I tried to make the header more informative. Now it reads

Hyperparameter optimization becomes difficult with large data and/or complicated searches. This page shows tools to perform hyperparameter optimization of Scikit-Learn API-compatible models using Dask, and explains when they're relevant.

I think we should more clearly expose the tradeoffs of hyperparameter searches. Give me a while on that. I'm trying to resolve https://github.com/dask/dask-ml/issues/838#issuecomment-851033868. I think it wouldn't be a bad idea to have a summary table.


Stability issues, dev/tty/usb,  AMA0 not showing in the list

Hello.
We have just updated to the latest version 4.1, When we first installed we could access the list of available serial devices in the drop down. For no unknown reason this list has vanished.
If i go into the configuration of the Node red serial node i can see the list of available devices, /dev/tty/USB, AMA0.
Additional to this there is also stability issues. Every couple of minutes the communications times out, this never used to happen before.
I have rolled back to version 3.6.1, this made no change.
Andy advice or checks we can do ?
Thank you

I'm submitting a ...  (check one with "x")
Support/Advice

support/advice request => Please do not submit support requests here, instead use the link to our support page, please!

Feature

( ) feature request

What is the motivation / use case for changing the behavior?

Simple question to get some hint

( ) simple question => please visit the Wiki, the YouTube tutorials and the Info tab by clicking on the node inside Node-RED before
( ) help wanted => you read all information and watched relevant YouTube tutorials, but you need more help

Problem

( ) bug report => please search github for a similar issue or PR and test Modbus problems with the modbus-serial package before submitting
( ) unexpected behavior => please visit the Wiki before

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

Your Environment
Please tell us about your environment:

( ) I am using just the Node-RED package and got modbus-serial package installed with it

Device :

( ) Raspbian: v Latest Raspian version
( ) Other:

Name:
Version:

Description of the connecting Modbus system:

Name   : Mako V1 Modbus device
Version: V1
Vendor : Smithtek
Link   : https://

node-red-contrib-modbus version: ``  3.6.1

Node: (min. 6.x)
node --version = 10.15.1

Hello Mate.
This is what i have discovered so far.
Not working version.
Node.js V11
Node red V0.19.5
Npm V3.10.10
Working version
Node.js 6.11.0
Node-red 0.19.5
Npm V3.10.10
serialport version 3.10.10
Working version matches that i have on a windows PC..
I'm reading registers from 3 devices using the same serial port dev/ttyAMA0
I'm using a round Robbin sequencer that polls 9 registers, grouped into bunches of 3, poll rate is 500ms
Time out setting is :1000ms
Reconnect setting is :2000ms
On the working version PC and RPIB+ they work no problems.
On the RPI3+ with node 11 it constantly;y has time out errors.
Im going to try with Node 8 as this is the recommended version to upgrade to.
Any ideas ?

please, test with v5.2.x


EndlessRun PR

Features:

EndlessRun is a base of LineFollower

instead of stopping, crossing the Start/End Line will reset odometry data and orientation

the top speed is reduced to increase precision and add reaction time

designed to work alongside the DCS app SignalReceiver

Sorry for the big PR...

doxygen configuration is missing at all


javascript click not clicking object when ElementNotInteractableException exception thrown

Describe the bug
JavascriptExecutor to perform click in the doClick() method of ExtendedWebElement class, not performing click on the object. This gets executed when exception ElementNotInteractableException happened while clicking on the element.
public void doClick() {
                try {
                    DriverListener.setMessages(Messager.ELEMENT_CLICKED.getMessage(new String[]{ExtendedWebElement.this.getName()}), Messager.ELEMENT_NOT_CLICKED.getMessage(new String[]{ExtendedWebElement.this.getNameWithLocator()}));

                    try {
                        ExtendedWebElement.this.element.click();
                    } catch (ElementNotInteractableException var3) {
                        ExtendedWebElement.LOGGER.warn("Trying to do click by JavascriptExecutor because element '" + ExtendedWebElement.this.getNameWithLocator() + "' is not visible...");
                        JavascriptExecutor executor = (JavascriptExecutor)ExtendedWebElement.this.getDriver();
                        executor.executeScript("arguments[0].click();", new Object[]{ExtendedWebElement.this.element});
                    }
                } catch (WebDriverException var4) {
                    if (var4 == null || !var4.getMessage().contains("Other element would receive the click:")) {
                        throw var4;
                    }

                    ExtendedWebElement.LOGGER.warn("Trying to do click by Actions due to the: " + var4.getMessage());
                    Actions actions = new Actions(ExtendedWebElement.this.getDriver());
                    actions.moveToElement(ExtendedWebElement.this.element).click().perform();
                }

            }

In this case, Action methods works fine (it does perform click), but above method is not using Actions class to do. so script is failing as object is not clicked by JavascriptExecutor.
Logs/Links
2022-01-06 10:22:49 ExtendedWebElement [TestNG-method=Confirm_continue_watching_is_working_as_expected-1-28] [WARN] Trying to do click by JavascriptExecutor because element 'poster (By.xpath: .//img[@class='thumbnail' and @width])' is not visible...
Web (please complete the following information):

Browser [e.g. chrome]
Version [e.g. 96]

Additional context

Carina Version [e.g. 7.2.14]

in 7.3.15-SNAPSHOT we implemented absolutely different approach having 3 different ways to make a click. Actual decision which one to use should be done based on real application state. So we have now different variants of:

click
clickByJs
clickByActions

Changes are available in 7.3.15-SNAPSHOT core build

verified by carina dream team


[Issue/Bug] Module not working with Pathfinder 2

Nice module, I am using Foundry with two systems, Starfinder and Pathfinder 2. In Starfinder everything seems to work, but in PF2 most options do not seem to do anything.
Not sure what else I could provide here, so I just wanted to say thank for your all of your hard work ^^

Hi, have you tried switching the sheet from the PF2E journal sheet to the Improved Journal sheet?

Thank you, I had not considered to do that, while I do not have time to check it in detail, thank you so much for your comment ^^


CLOUDQE-257: Add gateway hostgroup for Data Engineering Spark 3 template in Public Cloud

Hi Cloudbreak team,
The gateway hostgroup is missing from this Spark 3 cluster template. It is necessary for the Public Cloud QE testing. Could you please add it?
CC @dabondor

Hi @doktoric and @dabondor,
I did some further validations and the Spark 3 testing is working without the gateway hostgroup. The compute hostgroup is enough which contains the gateway roles as well.
If we want to add a new hostgroup, this requires that we update these json files as well and we have to define the related extra host:

https://github.com/hortonworks/cloudbreak/blob/master/core/src/main/resources/defaults/clustertemplates/aws/aws-dataengineering-spark3-722.json
https://github.com/hortonworks/cloudbreak/blob/master/core/src/main/resources/defaults/clustertemplates/azure/azure-dataengineering-spark3-722.json

I have opened a new jira which is related to this. Seems like we only have this extra gateway hostgroup by the YCloud test environment: https://jira.cloudera.com/browse/CLOUDQE-266
==========
Summary
Based on the above findings and I do not want to add this gateway hostgroup. I am going to cancel this pull request.


Fix attaching params for address form errors

Attaching params to validation errors for address form was failing when the error already had params.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-3512 KeyError: "Your dictionary lacks key 'limit_value'. Please provide it, because it is required to determine ...


Microsoft Windows Subsystem for Linux 2.0     time sudo apt update   Temporary failure resolving archive.ubuntu.com

Website is not much help at all.


Quick syntax fixes

Nice job, all!  I love copy/paste -- even more when it works well!  See the ??== below for quick syntax fixes.  Please keep it up, this is great!
// Use a distributed token cache by adding:
services.AddSignIn(Configuration, "AzureAd");  ??== semicolon blocks extension method chaining
.AddWebAppCallsProtectedWebApi(Configuration,
initialScopes: new string[] { "user.read" })
.AddDistributedTokenCaches();
// Then, choose your implementation.
// For instance, the distributed in-memory cache (not cleared when you stop the app):
services.AddDistributedMemoryCache() ??== need a semicolon here
// Or a Redis cache:
services.AddStackExchangeRedisCache(options =>
{
options.Configuration = "localhost";
options.InstanceName = "SampleInstance";
});
// Or even a SQL Server token cache:
services.AddDistributedSqlServerCache(options =>
{
options.ConnectionString = _config["DistCache_ConnectionString"];
options.SchemaName = "dbo";
options.TableName = "TestCache";
});

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f81a334a-eccc-b862-1a45-e58d151b8621
Version Independent ID: cee85377-c930-2e20-715d-004e5431a92f
Content: Configure a web app that calls web APIs - Microsoft identity platform
Content Source: articles/active-directory/develop/scenario-web-app-call-api-app-configuration.md
Service: active-directory
Sub-service: develop
GitHub Login: @jmprieur
Microsoft Alias: jmprieur

@RCRumold thanks for this detailed feedback. Looking into this now.

Thanks! I made a pull request to update this. https://github.com/MicrosoftDocs/azure-docs-pr/pull/115883


Fix unexpected keyword argument 'context'

Updates signature of RP2Decimal.__add__() to allow the context param which is
being invoked at
https://github.com/python/cpython/blob/f33e2c87a83917b5139d97fd8ef7cba7223ebef5/Lib/_pydecimal.py#L1257
Fixes #25

I presume we should change all the signatures in that file to include a context.

I added Python 3.10 to the continuous integration test matrix (on Windows, Mac and Linux) and all unit tests pass: this seems related to a problem with the specific Python installation on your machine (see also my comments in #25 and #30). You may want to try uninstalling and reinstalling Python.


Lots of jedi subprocesses created until memory runs out

It seems to be a regression of https://github.com/microsoft/vscode-python/issues/3586 and https://github.com/microsoft/vscode-python/issues/3514 . This started to happen recently (I can't tell exactly when, but a couple of weeks back I didn't experience this issue).
Environment data

VS Code version: 1.37.1
Extension version (available under the Extensions sidebar): 2019.8.30787
OS and version: MacOS High Sierra Version 10.13.6
Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.3
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
Relevant/affected Python packages and their versions: XXX
Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): Jedi

Actual behaviour
After working for a while in a Django project, python completion.py spawns lots of subprocesses that are never killed. Eventually the system runs out of memory and fork fails. You can close the visual studio folder in order to free memory, but it takes a while for the python processes to be killed and the computer gets unresponsive.

Steps to reproduce:

Open a python project
Browse some files, and on each of them call autocomplete and save several times. After a while you should get a lot processes that won't go away.

Browse some files, and on each of them call autocomplete and save several times. After a while you should get a lot processes that won't go away.

Can you please provide the file content where you call autocomplete, not aware of it. Thanks!

I have the same issue. Lots of processes are spawned after using the extension for a while.

@wj-c Processes maybe spawned, but are those being killed when you stop using the extension?

No, they are not killed after I completely close vscode and python extension.
-------- 原始信息 --------
发件人： Kartik Raj<EMAIL_ADDRESS>日期: 2019/9/14 03:08 (GMT+08:00)
收件人： microsoft/vscode-python<EMAIL_ADDRESS>抄送： wj-c<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>主题： Re: [microsoft/vscode-python] Lots of jedi subprocesses created until memory runs out (#7144)
@wj-chttps://github.com/wj-c Processes maybe spawned, but are those being killed when you stop using the extension?
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode-python/issues/7144?email_source=notifications&email_token=AIO72JHIM5R75RUD2UOXEMLQJPQMNA5CNFSM4ISDCZQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6V5XOQ#issuecomment-531356602, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIO72JBHX4ITGCJ4JODCRULQJPQMNANCNFSM4ISDCZQQ.

Hi.
There is also similar problem for pylint: https://github.com/microsoft/vscode-python/issues/4236
I found recently that processes do not die automatically when spawned for files with errors. Maybe there is something common in these issues?

@wj-c Apologies, not sure what might be happening there. Are child process being created in the python code? Please try to provide a reproducible case and create a new issue as it might be a different one.
@deitry Thanks for pointing to that. Unfortunately without a reproducible case, there's not much we can do here.

Closing the original issue for now as no further response was provided by @dorellang . I'll happy to reopen and address this if further clarification is provided.

@karrtikr
See https://github.com/microsoft/vscode-python/issues/4236#issuecomment-532644556
At least for me with pylint - described way reproduces issue 10 times of 10.

@deitry
Thanks, however that's a separate issue even though they may seem related.
We'll monitor/track that issue separately.


fix(deps): :arrow_up: update all non-major dependencies

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@assemblyscript/loader (source)
0.27.9 -> 0.27.13

@sentry/angular-ivy (source)
^7.70.0 -> ^7.73.0

ace-builds
1.28.0 -> 1.29.0

aws-cdk
^2.97.0 -> ^2.100.0

browserslist
4.21.11 -> 4.22.1

constructs
^10.2.70 -> ^10.3.0

core-js
3.32.2 -> 3.33.0

three (source)
0.156.1 -> 0.157.0

vega-embed
6.22.2 -> 6.23.0

vega-lite (source)
5.15.0 -> 5.16.0

Release Notes

AssemblyScript/assemblyscript (@assemblyscript/loader)
v0.27.13
Compare Source
Bug fixes

introduce CallableFunction and NewableFunction from typescript/lib/lib.es5.d.ts (#2712) (c22c078)
Co-authored-by: Xinquan XU<EMAIL_ADDRESS>
v0.27.12
Compare Source
Bug fixes

rest parameter crash resolver (#2748) (e3e4166)
Fixes #2707

v0.27.11
Compare Source
Bug fixes

interface inheritance cause crash (#2756) (a27258d)
Ensure call-less references to builtin functions in namespaces error (#2738) (58ed2b2)
diagnose not implement when assign value to closure variable (#2750) (73193f0)
Fixes: #2749
Type checker does not detect a signature mismatch (927b7cd)
Fixes: #2727

Other

build(deps): bump json5 from 2.2.1 to 2.2.3 in /lib/loader (#2610) (eedf306)
Bumps json5 from 2.2.1 to 2.2.3.

Release notes
Changelog
Commits

updated-dependencies:

dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>Co-authored-by: dependabot[bot]<EMAIL_ADDRESS>

v0.27.10
Compare Source
Bug fixes

StaticArray#concat link child to incorrect parent (#2746) (1126ef1)

getsentry/sentry-javascript (@sentry/angular-ivy)
v7.73.0
Compare Source
Important Changes

feat(replay): Upgrade to rrweb2

This is fully backwards compatible with prior versions of the Replay SDK. The only breaking change that we will making is to not be masking aria-label by default. The reason for this change is to align with our core SDK which also does not mask aria-label. This change also enables better support of searching by clicks.
Another change that needs to be highlighted is the 13% bundle size increase. This bundle size increase is necessary to bring improved recording performance and improved replay fidelity, especially in regards to web components and iframes. We will be investigating the reduction of the bundle size in this PR.
Here are benchmarks comparing the version 1 of rrweb to version 2

metric
v1
v2

lcp
1486.06 ms
1529.11 ms

cls
0.40 ms
0.40 ms

fid
1.53 ms
1.50 ms

tbt
3207.22 ms
3036.80 ms

memoryAvg
131.83 MB
124.84 MB

memoryMax
324.8 MB
339.03 MB

netTx
282.67 KB
272.51 KB

netRx
8.02 MB
8.07 MB

Other Changes

feat: Always assemble Envelopes (#9101)
feat(node): Rate limit local variables for caught exceptions and enable captureAllExceptions by default (#9102)
fix(core): Ensure tunnel is considered for isSentryUrl checks (#9130)
fix(nextjs): Fix RequestAsyncStorage fallback path (#9126)
fix(node-otel): Suppress tracing for generated sentry spans (#9142)
fix(node): fill in span data from http request options object (#9112)
fix(node): Fixes and improvements to ANR detection  (#9128)
fix(sveltekit): Avoid data invalidation in wrapped client-side load functions (#9071)
ref(core): Refactor InboundFilters integration to use processEvent (#9020)
ref(wasm): Refactor Wasm integration to use processEvent (#9019)

Work in this release contributed by @vlad-zhukov. Thank you for your contribution!

ajaxorg/ace-builds (ace-builds)
v1.29.0
Compare Source
Features

allow setting completion.ignoreCaption (5618046)

aws/aws-cdk (aws-cdk)
v2.100.0
Compare Source
Features

aws-cdk-lib: reduce JavaScript load time, second attempt (#27362) (0bb49b4), closes #27314 #27353
cdk: add AppSync GraphQLSchema and pipeline resolvers as hot swappable (#27197) (0ea6313), closes #2659 #24112 #24113
cli: CDK Migrate CLI command (#27325) (db051ea)
cli: declare cdk import stable (#27390) (1057ef0)
eks: support INF2 instance types (#27373) (bed9b8d)
s3-deployment: support Fn::Select in renderData() (#27237) (8b20c11), closes #25504 /github.com/aws/aws-cdk/blob/3edd2400bc0c8a86366a29d3a7eef1ef4fa5e016/packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-target-group.ts#L438
synthetics: CloudWatch Synthetics NodeJS Pupeteer 6.0 Runtime with NodeJS 18 (#27339) (e48af04), closes #27337
update AWS Service Spec (#27375) (26d4afe)
rds: add new RDS versions (#27351) (e0c9792)

Bug Fixes

autoscaling: ssmSessionPermissions does not add managed policy to role specified in launch template (#27220) (20e4760), closes #25904
cdk: Resolve cross stack and default parameters for hotswaps (#27195) (3507141), closes /docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/quickref-cloudformation.html#w2ab1c17c23c19b5
cli: report errors from resource failures in nested stacks (#27318) (1f639c7)
custom-resources: IAM policy incorrect for SDKv3 names (#27313) (c68ea44), closes #27255 #27268 #27270 #27395
logs: remove invalid data protection data identifier (#27388) (4db166d)
s3: bucket deletion fails if object creation races against cleanup (#26875) (735b786), closes #26874
sns-subscriptions: cannot add SqsSubscription when using an Sqs Construct from a different Constructs library (#27227) (52eee85), closes #27225
stepfunctions: Escaping newline characters in Step Functions intrinsics caused schema validation failures (#27323) (4e96edd)
reduce load time of JavaScript library, for real (#27314) (48acd37)

Alpha modules (2.100.0-alpha.0)
⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES

redshift: the behavior of redshift tables has changed. UPDATE action will not be triggered on new table names and instead be triggered on table id changes.

Bug Fixes

redshift: UserTablePriviliges to track changes using table IDs (#26955) (7e4fdc7), closes #26558

v2.99.1
Compare Source
Bug Fixes

load time regression (#27314) (fca5a73)

Alpha modules (2.99.1-alpha.0)
v2.99.0
Compare Source
Features

s3: specify minimum TLS version (#27297) (f47d09c), closes #27279
synthetics: graduate to stable 🚀 (#27305) (dd00d05)

Bug Fixes

batch: make instanceType optional on multinode jobs (#27223) (6616026), closes #27185

Alpha modules (2.99.0-alpha.0)
Features

apprunner: add HealthCheckConfiguration property in Service (#27029) (4e8c9c4), closes #26972

Bug Fixes

appconfig: allow multiple environment monitor roles to be created (#27243) (9312c97)

browserslist/browserslist (browserslist)
v4.22.1
Compare Source

Updated Firefox ESR (by @lerkor).

v4.22.0
Compare Source

aws/constructs (constructs)
v10.3.0
Compare Source
10.3.0 (2023-10-07)
Features

add a mechanism to retrieve all context (with defaults) (#1751) (23df709)

zloirock/core-js (core-js)
v3.33.0
Compare Source

Re-introduced RegExp escaping stage 2 proposal, September 2023 TC39 meeting:

Added RegExp.escape method with the new set of symbols for escaping
Some years ago, it was presented in core-js, but it was removed after rejecting the old version of this proposal

Added ArrayBuffer.prototype.{ transfer, transferToFixedLength } and support transferring of ArrayBuffers via structuredClone to engines with MessageChannel
Optimized Math.f16round polyfill
Fixed some conversion cases of Math.f16round and DataView.prototype.{ getFloat16, setFloat16 }
Fully forced polyfilling of the TC39 Observable proposal because of incompatibility with the new WHATWG Observable proposal
Added an extra workaround of errors with exotic environment objects in Symbol polyfill, #1289
Some minor fixes and stylistic changes
Compat data improvements:

V8 unshipped Iterator helpers because of some Web compatibility issues
Promise.withResolvers marked as supported from V8 ~ Chrome 119
Array grouping proposal features marked as supported from FF119
value argument of URLSearchParams.prototype.{ has, delete } marked as properly supported from V8 ~ Chrome 118
URL.canParse and URLSearchParams.prototype.size marked as supported from Bun 1.0.2
Added Deno 1.37 compat data mapping
Added Electron 28 compat data mapping
Added Opera Android 78 compat data mapping

mrdoob/three.js (three)
v0.157.0
Compare Source

vega/vega-embed (vega-embed)
v6.23.0
Compare Source
Features

Add new forceActionsMenu embed option (#1242) (fbbcd9e)

6.22.2 (2023-07-31)
6.22.1 (2023-04-21)
Bug Fixes

fix issue with broken semver version (ac5b84c)

vega/vega-lite (vega-lite)
v5.16.0
Compare Source
Bug Fixes

correct types for domain unionWith (#9131) (6f66759)

Features

make bar & rect marks support bandPosition (allow center-alignment with ticks) (#9126) (bd014eb)
swap 'mouse' events to 'pointer' events for mobile compatibility; update site and docs (#9089) (fa97659)

5.15.1 (2023-10-02)
Bug Fixes

correct the formula for interpolating between bin start and end (interpolatedSignalRef) (#9111) (d4b27bb)
use resolve "shared" instead of steps to fix artifacts in grouped density transform (#9106) (06e63e6)

v5.15.1
Compare Source
Bug Fixes

correct the formula for interpolating between bin start and end (interpolatedSignalRef) (#9111) (d4b27bb)
use resolve "shared" instead of steps to fix artifacts in grouped density transform (#9106) (06e63e6)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm WARN cli npm v10.2.0 does not support Node.js v20.2.0. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.
npm ERR! code ERR_SOCKET_CONNECTION_TIMEOUT
npm ERR! errno ERR_SOCKET_CONNECTION_TIMEOUT
npm ERR! request to https://registry.npmjs.org/@firebase%2fanalytics failed, reason: Socket connection timeout

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-10-14T01_48_14_479Z-debug-0.log


Delete rooms when the last device in that room logs out or leaves

If you have 1 user with 1 device in a room, who then leaves the room, the room data in the DB will eventually go stale. However, if a new user then joins the same room, we will not reset our knowledge of room state (specifically, we discard the state in the sync response), and the room state can then diverge from the truth.
This isn't terribly dissimilar to when servers leave a room then rejoin the same room - they need to clear their DB when they leave.

(Hashed out in https://github.com/matrix-org/sliding-sync/issues/51#issuecomment-1505398355 .)
It's true enough that room state in the proxy's DB can become out of date. (Indeed, we suspect that something like this has already happened---there are reports of old room names showing up.) However, deleting everything and starting from scratch is a little nuclear. Instead we can do the following.

Whenever a poller sees a state block in an incremental sync v2 response, select the NIDs from the proxy database, for all event IDs in the state block.
If they all have NIDs then the proxy's view of state is in sync with the HS, and all is well.
Otherwise, prepend all events missing a NID to the timeline so that clients see the new state.

The timeline order will be wrong, but at least both the proxy and the client will now see up to date state---we've self-healed.
Is the order in which we do this important? E.g. if A invited B, should we show A's membership before B's?

Slogan: this makes the proxy "support gappy state" (but not gappy messages).
Other notes:

This needs to all happen within a single database transaction.

do we also want to SELECT FOR UPDATE or similar?

If we prepend events to timeline then we should write error log lines and make lots of noise in Sentry.


Kyma CR in processing state over 1 hour after cluster creation on canary

Description
After creating cluster on canary Kyma CR has hanged in the processing for over 1 hour, and modules were not deployed.
Steps to reproduce
Create cluster on canary.
Environment Type
Managed
Environment Info
Default for canary.
Attachments
All defaults, in the state from creation.

@kolodziejczak can you provide more info? We would need the Kyma CR at minimum.


[DemoX] Prepare for ECLSS demo

User Story:

We know we have a potential user for ECLSS on SSOS. We prepare for the simulation, demo at first.

Acceptance Criteria:

What to simulate is identified
What could be simulated is idenfied
Document it on space-station-os.github.io

https://docs.google.com/document/d/1e0iuG-e3bj8xFaQQypPAE-KxrJ69jMfB8pwMludQxHM/edit?usp=sharing
Updated this with a small report on my findings of the system. After discussing with @yuyuqq on December 18th.

I have  created a small simulation for Air revitalization system https://github.com/space-station-os/space_station_eclss/tree/patch-1,

Create a GUI using python
unit testing
start working on water recovery system and oxygen generation system

@siddarth09 Thank you, I finally had time to review space_station_eclss. It is a definatively good, meaningful start.
I think we met the acceptance criteria for all.
Let us define a next goal. Close.


Generate Authorization header based on current request.fullpath

I am struggling with a case in which I need to generate an Authentication header based on the current fullpath (e.g /search?search=value) that is going to be under test as e.g:
`header "Authorization", :auth_header
let(:auth_header) {
# do some setup
generate_header(request.fullpath)
}
parameter :search, "search query"
get "/search" do
#... tests
`
Is there any way this is possible?

At the moment you have to build this yourself. See https://github.com/zipmark/rspec_api_documentation/blob/master/lib/rspec_api_documentation/dsl/endpoint.rb#L45 for how the gem does it.
"#{path}?#{query_string}" should work for what you're looking for.

Nice, works like a charm. Thanks!


[...] remove Android Gradle tools reference

from the generated code in android/build.gradle
in order to avoid multiple Android build tools Gradle plugin versions in React Native projects
as discussed in react-native-community/discussions-and-proposals#151
This is a quick fix approach that may be considered a little controversial since would completely disable Android Studio support (see #120). In general, I would recommend that people generate with the example and then open the example project with Android Studio (see https://github.com/brodybits/create-react-native-module/issues/120#issuecomment-531935702).
Some proposals linked by https://github.com/react-native-community/discussions-and-proposals/issues/151#issuecomment-531532235 seem to fix Android Studio support in some other projects. I am not so happy about adding a committed Gradle JAR artifact or any other big Gradle artifacts that may be needed. Could be an interesting option.
It may be possible to fix Android Studio support by using Yarn workspaces (see #128).
/cc @SaeedZhiany

If I understood correctly from that PRs, @dulmandakh says that gradle files can be moved to root directory of a module, so the maintainers can develop their module just like before, but they have to open the root directory of the module instead of the android directory, everything should be the same as before for the maintainers. as a result when other users get the module from npm or yarn,
the module's gradle file will not be used and automatically all modules use main project AGP.

I am not so happy about adding a committed Gradle JAR artifact or any other big Gradle artifacts that may be needed.

I've taken a look at your changes, it seems you only removed the buildscript sections from all files and not added any gradle related config file in the root directory of the module template, so I'm not sure if it's a correct way, because in all that @dulmandakh's PRs he moved the configs to the root directory not just removing them.
Honestly, I don't figure out exactly how we should apply @dulmandakh's approach yet, so I can't help on this one these days, I need to some free times to getting deep on Gradle system. maybe @dulmandakh can help.

I'm not sure if this is the best approach. As mentioned, by removing the Android Gradle plugin from the template the projects are no longer "self-sustaining": Without a separate project, it is no longer possible to open or build the project in Android Studio nor from the command line.
@brodybits

I am not so happy about adding a committed Gradle JAR artifact or any other big Gradle artifacts that may be needed

Yes, completely agree with you - The only Gradle wrapper jar (including related gradlew script files) that should be added to source control is the one in the android subfolder of a RN application project. These files should be excluded (both from Git and npm pack) for RN native modules. Note that even without these files, it is still possible to open the folder in Android Studio, which will autogenerate these files.

it is no longer possible to open or build the project in Android Studio or on the command line.

As @dulmandakh said in this comment, it still possible to open and maintain a project using android studio, maintainers should open the project using the module's root project instead of android folder.

it is no longer possible to open or build the project in Android Studio or on the command line.

According to @dulmandakh statements in this comment, it still possible to open and maintain a project using android studio, maintainers should open the project from the module's root project instead of android folder.

@SaeedZhiany - Yes, that's correct, both solutions would still allow the project to be edited in Android Studio. Both would equally solve the main problem (unnecessary downloads of/conflicts with older Android Gradle plugin distributions), while the if (project == rootProject) solution will in addition keep all things Android in the android folder (as it was before).
I opened a PR in this repo here: #135
Please have a look @brodybits 👍

Now closing this proposal as rejected. Thanks @friederbluemle.

@friederbluemle
yeah, your solution so amazing and I love that. I will also open a few PRs on the libraries I'm using to fix their Gradle file.
Thank you for your great contribution.


creating replicas of a service

How can i run a service with multiple replicas and scale it accordingly when required using shipyard GUI?

This isn't available yet in the latest version of Shipyard.  I'd been working on a Docker 1.12 compatible UI in the 1.12 branch, but haven't had much time recently to continue with it.  Hoping to get back to it soon!


Input Component Multiple Icons

When I use Input component as searchbar, I would like to have multiple icons like 'X' icon for deleting and search icon. However input component only provides one icon as I know.
I would like to specify multiple icons as left and right.

Hi @ErkinKurt ! You're right, this component should be more customizable. We'll have to do that after we're done with the version 1.
Thanks
Alin


vtctl: MigrateServedTypes: Improve error messages and test coverage.

LGTM maybe rebuild the vtclt doc too (by running the python script in the doc directory).


add documentation for using the tool behind a proxy

closed in. https://github.com/SumoLogic-Incubator/slogen/pull/31


Question: auto height

Help pls,
how to set auto height of parent view. i have a native ad UI implemented by java.  code something like
<AdsView
style={{width:'100%'}}
/>
problem is ad does not display for height issue. when i manually add height:350 in style that time ad displayed.
question is how to set auto height in this case...
my java code
`public class NativeAdView extends FrameLayout {
@Override
public void requestLayout() {
super.requestLayout();
    // The spinner relies on a measure + layout pass happening after it calls requestLayout().
    // Without this, the widget never actually changes the selection and doesn't call the
    // appropriate listeners. Since we override onLayout in our ViewGroups, a layout pass never
    // happens after a call to requestLayout, so we simulate one here.
    post(measureAndLayout);
}

private final Runnable measureAndLayout = new Runnable() {
    @Override
    public void run() {
        measure(MeasureSpec.makeMeasureSpec(getWidth(), MeasureSpec.EXACTLY),
               MeasureSpec.makeMeasureSpec(getHeight(), MeasureSpec.EXACTLY));
        layout(getLeft(), getTop(), getRight(), getBottom());
    }
};

private void refreshAd(NativeAdView v) {
    if (TextUtils.isEmpty(admobAdUnitId)) {
        admobAdUnitId = ADMOB_AD_UNIT_ID;
    } else {
        Log.d(TAG, "admobAdUnitId is not null");
    }
    AdLoader.Builder builder = new AdLoader.Builder(getContext(), admobAdUnitId);

    builder.forUnifiedNativeAd(new UnifiedNativeAd.OnUnifiedNativeAdLoadedListener() {
        @Override
        public void onUnifiedNativeAdLoaded(UnifiedNativeAd _unifiedNativeAd) {
            if (_unifiedNativeAd != null) {
                // You must call destroy on old ads when you are done with them,
                // otherwise you will have a memory leak.
                if (_nativeAd != null) {
                    _nativeAd.destroy();
                }
                _nativeAd = _unifiedNativeAd;
                LayoutInflater layoutInflater = LayoutInflater.from(__context);
                View viewRoot = layoutInflater.inflate(R.layout.ad_unified, null);
                //if(unifiedNativeAdView!=null) {
                    // unifiedNativeAdView.removeAllViews();
                    // v.removeAllViews();
                //}
                unifiedNativeAdView = (UnifiedNativeAdView)viewRoot;//(UnifiedNativeAdView) viewRoot.findViewById(R.id.unified_ad_view);
                //v.addView(unifiedNativeAdView);
                populateUnifiedNativeAdView(_unifiedNativeAd);
                v.removeAllViews();
                v.addView(viewRoot);
                Log.d(TAG, v.getMeasuredHeight () + " " + unifiedNativeAdView.getMeasuredHeight());
                // v.requestLayout();
                // printNativeInfo(_unifiedNativeAd);
            }
            sendEvent(AdsViewManager.EVENT_UNIFIED_NATIVE_AD_LOADED, null);
        }
    });

.....................
.........................
}`

Have you tried using flexbox? Alternatively, you can use the Dimensions api to get the device height and then size your component accordingly. Something like this,
import { Dimensions } from 'react-native';

const ScreenHeight = Dimensions.get('window').height;

<AdsView
style={{ height: ScreenHeight }}
/>

I dont know native ad height. it may be 350 , 330 or something else. in that case how to handle height in react native end.


UNIX addresses can be ambiguous.

Unix domain socket addresses become ambiguous when they encapsulate other addresses. This is obviously because unix addresses are not a fixed length and can contain forward slashes. This becomes an issue when you need to when you need to encapsulate other protocols like /p2p for example:
/unix//tmp/node.socket/p2p/QmaCpDMGvV2BGHeYERUEnRQAwe3N8SzbUtfsmvsqQLuvuJ

This type of address would be needed if you have multiple nodes on the same machine that need to connect to each other. (VMs/Docker comes to mind.)
This also relates to issue: #55

This is also useful for clients that can connect to both local and remote services. For example, it would not be unreasonable to run the IPFS API over a unix socket. However you may also want to use the IPFS client to manage a remote API. Right now these cases have to be handled separately.
As was pointed out in #63 by infinity0, unix domain sockets can be either stream or datagram. Therefore I recommend a multiaddr format such as
/unix/stream/(/path/to/sock)/some-protocol/0.1.0
or
/unix/datagram/(/path/to/sock)/some-protocol/0.1.0

It's not pretty, but it's a path forward for a problem that's been around for several years.

Another user case is for Tor transport. We can start a peer with/unix/xxx/onion3/xxx. The unix socket is the address configured as a onion service in Tor and the onion address is the one used to dial the peer.
@littlebenlittle we could have a shorter version /unix/s/xxx and  /unix/d/xxx. One inconvenience is that \path\to\sock is a valid path name on unix systems.


Add TypeScript definitions

Similar to https://github.com/rdfjs-base/data-model/pull/7.

Just thought it a little easier to read, and has the same effect AFAIK.

Moving to https://github.com/DefinitelyTyped/DefinitelyTyped/pull/41082.


Question: how to sponsor this project?

Hi 👋 ,
Thanks so much for the work on this project! At @Reviewpad, we are trying to support the OSS projects that we use as dependencies to our main repository reviewpad/reviewpad.
Do you plan to join any sponsoring program? We are also happy to help the community to maintain the project.
Thanks!

Hi @marcelosousa , I'm gonna be honest I haven't thought of this. Maybe this could be interesting! Are you talking about sponsoring a project like in https://github.com/sponsors?

Yes, that would be the easiest. We can also help in other ways if you need any assistance with issues, code reviews or development.

Hi @marcelosousa, any help with issues or development is welcomed - with or without sponsoring. Feel welcomed to contribute. I will be happy to review the purposed code :).

Sounds good @migueleliasweb ! Let us know if you do sign up for the sponsorship program 👍


Health filter for modules

closes #
📑 Description
✅ Checks

[x] I have updated the documentation as required
[x] I have performed a self-review of my code

ℹ Additional context

Hey @nikhiltanna, thanks for the PR.
Can we make the filter look like the image below? You can add the statuses as checkboxes, which allows filtering multiple statuses at once.

You can check how we have implemented it for filtering resources here.

Hey @petar-cvit  can you please check this now I have changed to popover if you can approve and merge it would be great

Hey @petar-cvit  have changed it to popover as asked can you please approve it.

Hey @petar-cvit have changed it and made it look like search extension

Are there any other changes required?


drop custom JSON parser, use Qt's one instead

since 5.0 Qt provides JSON parser with very similar interface to this custom one. so it is no need to keep custom parser anymore.
"smoke test" passed - tested with 1.8.9, 1.12.2, 1.15.2, 1.19, so very likely everything is fine.

From a first look the interface seems really very similar. And you are right: it is better to use tested Qt code instead to try maintaining our own implementation.
One thing I noticed, but did not have time to look deeper:
You changed several function parameters from pointer to direct object. I fear, that we copy lot of data each time. This might not be a big performance issue, as it only done once at startup. But maybe there is a way to use references and some "const" stuff at these places.

it is safe to copy Qt "heavy" objects - they are "implicitly shared" and do the actual "deep copy" only on modification.
most Qt examples also don't care about passing objects by reference due to this copy-on-write logic (even Qt doesn't take advantage of C++ move semantics in most cases, at least for Qt 5).
so, no worries here.

That was the answer I wanted to hear ;-)


Metadata form: Author field display issues

There are several issues with display of author fields on the metadata form. The first 2 are vital to fix, the others are bonus fixes.

button to add a second author disappears quickly when you leave the field and is almost unusable
the "value is not unique" message seems to appear whatever you enter
(minor) there is no gap between author field and embargo, and
(minor) maybe "Add author" on the button, not "Add new item"
(minor) don't italicize the "+" on the "Add new item" button (edited)

Temporary work around in place: Do not allow users to add author data
This can be addressed after launch

See also #528

This ticket is estimated around 1 day of work. Most of the issues here relate to alpaca.js default settings so this issue will be resolved by altering alpaca js defaults.

new requirements:
For submission using DOI, metadata form need to be not-editable to prevent the metadata from being out of sync with doi metadata
For submission without DOI, user need to be able to add author information.

@Rytiggy just for some context - when we realized we couldn't fix it in time for launch, @jabrah did this PR to remove the code completely until we could fix it properly: https://github.com/OA-PASS/pass-ember/pull/661
So the code needs to be added back in, and then these bugs fixed.

verified on rev. 3183c0c4


queryToken and PgUrl parse changes

Here are the changes I made for passing around queryToken and parsing the db url I needed.

(sorry about the delay--life got in the way)
So I've incorporated the fix for the URL parsing. For the moment, I've decided to include it as-is, since as far as I can tell, the only limitations on PostgreSQL database names are that they start with a letter and are 63 characters or less).
The token stuff I'm not sure about. If you look at what I did in pgconsole, I wrap the Connection in a service which instantiates a new result handler for every query execution. This way, the handler instance itself knows what query it is dealing with, and the query token would only be necessary to try to map the handler to any errors / warnings that come up as a result of the query (the PostgreSQL protocol only loosely ties these to the query, so I didn't want to add this as an aspect of the result handler, especially since you may need to deal with errors that are not directly caused by queries).
However, it might make sense to provide this information to the handler anyway... Can I ask how your handlers are using the QueryToken, and how you map this back to the original query submitted?

I think about the queryToken in terms for an AsyncToken request on a
remoteObject. Attached to the ResultEvent, you get the original token
back. That was my initial thought around it. I had not looked at the
console, so I didn't consider doing it the way you're doing it there,
but it would seem it would be a bit more work to accomplish that. I'll
take a look at that over the weekend, if I have time.
The way I'm using the tokens is to track each query, and put them in
an array so that I can cancel queries that have not completed
execution if a stop was called. Since the connection.cancel() method
takes a token, I needed a way to know which queries had completed its
execution. I may queue up 100+ queries, b/c it's a replay tool, and
the rate can be dynamically set. Literately thousands of requests per
second, or just as little as only a few requests per hour.
        private function stopReplayData():void {
            if (_isReplaying) {
                if (_timer && _timer.running) {
                    _timer.stop();
                    _timer = null;
                }

                var token:QueryToken;
                var i:int;
                for (i = _queryTokens.length - 1; i >= 0; --i) {
                    token = _queryTokens[i];
                    _conn.cancel(token);
                }

                _isReplaying = false;
            }
        }

       private function

queryCompleteHandler(event:QueryCompletionEvent):void {
var token:QueryToken;
var i:int;
for (i = _queryTokens.length - 1; i >= 0; --i) {
token = _queryTokens[i];
if (event.token == token) {
_queryTokens.splice(i, 1);
}
}
}

Doug

On Thu, Mar 8, 2012 at 1:58 PM, Maciek Sakrejda
<EMAIL_ADDRESS>wrote:

(sorry about the delay--life got in the way)
So I've incorporated the fix for the URL parsing. For the moment, I've decided to include it as-is, since as far as I can tell, the only limitations on PostgreSQL database names are that they start with a letter and are 63 characters or less).
The token stuff I'm not sure about. If you look at what I did in pgconsole, I wrap the Connection in a service which instantiates a new result handler for every query execution. This way, the handler instance itself knows what query it is dealing with, and the query token would only be necessary to try to map the handler to any errors / warnings that come up as a result of the query (the PostgreSQL protocol only loosely ties these to the query, so I didn't want to add this as an aspect of the result handler, especially since you may need to deal with errors that are not directly caused by queries).
However, it might make sense to provide this information to the handler anyway... Can I ask how your handlers are using the QueryToken, and how you map this back to the original query submitted?

Reply to this email directly or view it on GitHub:
https://github.com/deafbybeheading/pegasus/pull/15#issuecomment-4402119


Add a "running in production" doc

It's not clear from our current documentation how this is supposed to work.

We spent some time talking about pm2 in slack today and discovered that you should use pm2 start npm --watch --ignore-watch="__clientTemp" -- start, given "scripts": { "start": "react-server start"} in your package.json, which seems like worth adding to this doc (once we have it 😀 )

This was fixed in #777; closing


Named components only inject props into their parents (not the entire ancestry)

I'm not sure if this is considered a bug, or a feature request (and wasn't able to find any other issues or SO questions on it):

<EMAIL_ADDRESS>Named components declared via components appear to only be passed to their parent route, rather than all the way up the hierarchy.  This makes it difficult/impossible if you want to have some base layout, and some conditional layouts based on path.  For example:
<Route component={BaseLayout}>
  <Route path='/foo' component={FooLayout}
    <Route path='/:id' components={{ children: FooDetails, nav: FooNav }} />
  </Route>
</Route>

FooLayout receives both children and nav as props, but BaseLayout receives neither of them.
In my real world usage, I want the inner layout component (FooLayout in this example) to provide some common styling and structure for the main content area, but not mess with navigation (which is handled by BaseLayout).

The behavior I expected was that all components in the ancestry would receive the named components

A parent <Route> is responsible for rendering the elements returned by its child <Route>. You can read the code responsible for this here.
If your BaseLayout component should be receiving a nav element, your /foo route needs to give it one.
<Route component={BaseLayout}>
  <Route path='/foo' components={{ children: FooLayout, nav: FooNav }}>
    <Route path=':id' components={{ children: FooDetails, nav: FooDetailsNav }} />
  </Route>
</Route>

const FooNav = ({ nav }) => nav ? React.Children.only(nav) : null