How to format date and time in the input field of ReactiveDateTimePicker?

I'm trying to figure out how to format date and time in the input field of ReactiveDateTimePicker. Currently, it shows as 2020/09/17 21:51 in the input field. I'd like it to show in other formats probably with DateFormat. Is it possible? Please advice.

I set valueAccessor as follows and it works fine now.
  DateTimeValueAccessor _valueAccessor(
      BuildContext context, ReactiveDatePickerFieldType fieldType) {
    switch (fieldType) {
      case ReactiveDatePickerFieldType.date:
        return DateTimeValueAccessor(
            dateTimeFormat:
                DateFormat.yMMMd(Localizations.localeOf(context).toString()));
      case ReactiveDatePickerFieldType.time:
        return DateTimeValueAccessor(
            dateTimeFormat:
                DateFormat.jm(Localizations.localeOf(context).toString()));
      case ReactiveDatePickerFieldType.dateTime:
        return DateTimeValueAccessor(
            dateTimeFormat:
                DateFormat.yMMMd(Localizations.localeOf(context).toString())
                    .add_jm());
    }
  }


Specify the right pause image used by cri-o

Otherwise the later container rpm-packaging patches
will grab the wrong image, and the pause image is missing
for offline systems.
Signed-off-by: Miguel Angel Ajo<EMAIL_ADDRESS>

/approve

/retest

/lgtm


ERROR: Directory '.[figures]' is not installable

Hi,
I get the error messages
ERROR: Directory '.[figures]' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.
ERROR: Directory '.' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.mentumModel
Python 3.11.8 64bit
What is the reason?
Thanks
HR

Thanks. but now I have 2 directories with the unified-momentum-model, one created with the MS powershell and one created with the MS Terminal in a virtual environment. Do I have to uninstall one of it?
And even more error messages in Visual studio code running the example_01_classical_vs_unified.py

I tried pip install . and pip install .[figures]

Please double check that you are in the correct directory (Unified-Momentum-Model) when installing the repository, for example:
git clone https://github.com/Howland-Lab/Unified-Momentum-Model.git
cd Unified-Momentum-Model
pip install .[figures]

You can also try installing into a fresh virtual environment:
git clone https://github.com/Howland-Lab/Unified-Momentum-Model.git
cd Unified-Momentum-Model
python -m venv .venv

source the virtual environment .venv/Scripts/Activate.ps1 (Windows) or source .venv/bin/activate (unix), then:
pip install .[figures]


none-ls sources missing

At least flake8, shellcheck and luacheck are missing from the sources, sometimes in the past they were there. What happened and will they be back?

We have an automatic way of ensuring that the none-ls sources in nixvim are exactly the same as upstream.
If a source disappears, it is because it has been removed upstream. (Otherwise, please file a bug).

Yes, that's why I closed the issue. Had a lapse in judgement and forgot to check upstream, the none-ls team have good reasons to sunset those and propose replacements. Sorry


ERROR

Traceback (most recent call last):
File "/home/fubo/diplus/ask_bot/llm_base/dipeakllm_service/vllm/autoawq.py", line 1, in
from awq import AutoAWQForCausalLM
File "/home/fubo/.conda/envs/autoawq/lib/python3.10/site-packages/awq/init.py", line 2, in
from awq.models.auto import AutoAWQForCausalLM
File "/home/fubo/.conda/envs/autoawq/lib/python3.10/site-packages/awq/models/init.py", line 1, in
from .mpt import MptAWQForCausalLM
File "/home/fubo/.conda/envs/autoawq/lib/python3.10/site-packages/awq/models/mpt.py", line 1, in
from .base import BaseAWQForCausalLM
File "/home/fubo/.conda/envs/autoawq/lib/python3.10/site-packages/awq/models/base.py", line 12, in
from awq.quantize.quantizer import AwqQuantizer
File "/home/fubo/.conda/envs/autoawq/lib/python3.10/site-packages/awq/quantize/quantizer.py", line 11, in
from awq.modules.linear import WQLinear_GEMM, WQLinear_GEMV
File "/home/fubo/.conda/envs/autoawq/lib/python3.10/site-packages/awq/modules/linear.py", line 4, in
import awq_inference_engine  # with CUDA kernels
ImportError: /home/fubo/.conda/envs/autoawq/lib/python3.10/site-packages/awq_inference_engine.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN3c104cuda9SetDeviceEi

Which GPU and CUDA version?

GPU is 3090

I'm not quite sure about this error as I have not seen it before. I would suggest that you upgrade your CUDA toolkit to 11.8, and maybe reinstall your environment in general.

I'm seeing the same error here:
Driver Version: 530.30.02
2.0.1+cu118

I'm seeing the same error here:
Driver Version: 510.47.03 torch 2.1.0+cu12.1 autoawq 0.1.7 python 3.10.6

I'm seeing the same error here:
Driver Version: 530.30.02
torch 2.0.1+cu118
 autoawq 0.1.7
python 3.10.12

for me upgrading autawq and torch fixed. Torch to 2.1.x+cu121 fixed.

same error
PyTorch version: 2.1.2+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.3 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.27.4
Libc version: glibc-2.35

Python version: 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-5.4.242-1.el7.elrepo.x86_64-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.2.128
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA A100-SXM4-80GB
GPU 1: NVIDIA A100-SXM4-80GB
GPU 2: NVIDIA A100-SXM4-80GB
GPU 3: NVIDIA A100-SXM4-80GB
GPU 4: NVIDIA A100-SXM4-80GB
GPU 5: NVIDIA A100-SXM4-80GB
GPU 6: NVIDIA A100-SXM4-80GB
GPU 7: NVIDIA A100-SXM4-80GB

Nvidia driver version: 535.104.05


mullvad-vpn: 2020.7 -> 2021.1

Motivation for this change
Bump mullvad-vpn to 2021.1
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 112740 run on x86_64-linux 1

1 package built:

mullvad-vpn

Haven't used it system wide but mullvad bin works & the gui opens

After upgrading my nixos-unstable system mullvad stopped working with WireGuard servers.
The GUI works but it's stuck in the connecting state.

Superseded by https://github.com/NixOS/nixpkgs/pull/112868.

This PR was first :upside_down_face:


Swap from google analytics to an open-source alternative

I was browsing the site and noticed that it loaded a script from google-analytics.com. Perhaps using an open-source and/or self-hosted solution would be better than google analytics from a privacy perspective. I haven't tried implementing anything like this myself, but perhaps Matomo might be a good solution? This isn't a giant issue but I've been trying to reduce how much I expose myself and my users to companies that like to mine and sell data.

Hello @L1lith
Thank you for the idea.
I totally agree with you, actually I searched recently for some alternatives but I couldn't find anything that was free.
The current number of monthly Page Views is around 90,000 according to Google Analytics but I guess the real numbers are bigger since developers often use solutions to avoid being tracked.
So I'm going to investigate seriously about this issue and try to implement something.
Just in case, have you any feedback about https://www.cloudflare.com/analytics/ ?

@michaelrambeau Here's one blog I found detailing the merit of Cloudflare analytics. It appears to be overall a good option, though it might be worth looking into the cookie issue talked about inside the article.
Overall finding quality free services is a difficult thing. Free software is fairly abundant but it all requires a back-end to host it (which isn't free). I think for now Cloudflare would be the best choice.

Thank you @L1lith  for the feedback, Cloudflare seems simplest solution to integrate as it's just a snippet and no setup is required, so I'm going to try it ASAP.
We have a tag "analytics" in Best of JS actuallly: https://bestofjs.org/projects?tags=analytics
What do you think of the solution Ackee? https://docs.ackee.electerious.com/
I like the fact it runs on Node.js and on MongoDB (the stack I'm familiar with), it could be installed easily on Vercel, it seems.

Before saying goodbye
Before removing GoogleAnalytics, for the records, here is a screenshot about the number of monthly Page Views since the creation of the project.
There was a peak of 166k PageViews in June 2019.
The number is steadily decreasing since that: 94k in April 2021.

Analytics All Web Site Data Overview 20151201-20210527.pdf

Trying Cloudflare analytics
I added the snippet to enable Cloudflare Analytics yesterday.
24 hours later, the following numbers are displayed:

1.64 visits
2.51 k Page views (that would mean 75k a month but it's better to wait for a full week before making any interpolation)

Among other changes released on 2021-05-31 #103 GoogleAnalytics tracking code has been removed.

@michaelrambeau Nice work! If you ever feel like going with a self-hosted solution, I think that this section here describes the differences between it and Matomo (Matomo looks like a paid service but I'm pretty sure it's fully free and open source for you to host yourself, the provided hosting is optional) well, and they are the only 2 major projects I've come across online. To summarize Ackee is more lightweight and & Matomo is closer in functionality to Google Analytics, but it also is more CPU intensive.

Thank you @L1lith , to me the lighter, the better, I only need an overview if the number of page views, this is why Ackee sounds interesting.
A paid option (that is also an open-source project you can host) that I find very good and that was recommended to me: https://plausible.io/
I have just opened an "Open Collective" account because someone asked me, maybe I should set a "goal" asking people to sponsor the feature https://opencollective.com/bestofjs what do you think?

@michaelrambeau Yeah I was reading over plausible, it seems like a good options too. I also like the idea of an accepting donations for the project. Perhaps this would be a good moment to reflect on the long-term goals of the project. Perhaps we could look at ways to reach out to the broader development community and get the project seen by more people (I know here meetup coding groups allow people to talk about their projects, or you could try to find ways through social media and content creators). I think if we could increase traffic then more people might be willing to contribute to the project financially or other with pull requests, etc.
Open Collective seems like a good resource for receiving payments, and I think it can work for the project

Thank you for the comments @L1lith .
I've just published the first news on Open Collective: https://opencollective.com/bestofjs/updates/june-2021-news
Also, for the records, I'm including a screenshot of the analytics from Cloudflare after one full week (23.6k Page views)

For our websites, we also switched from Google Analytics to Plausible.
We are super happy with the simplicity of the service, especially the dashboard is so clean and gives us all the basic metrics we care about. I also like, that you can set the dashboards to public and easily share them (e.g. have a link in the footer of the website).
Though, for your traffic, the hosted version might be a bit expensive.

Thank you @HenrikFricke for the comments.
So you too, you recommend Plausible. I'd like to have a public dashboard like you do on https://yetanother.blog/ (the "stats" link at the bottom)
Here are the latest numbers from Cloudflare: more than 100 k PageViews the last month:

The pricing page of Plausible says:

Monthly pageviews 100k => $12 / mo
Monthly pageviews 200k => $20 / mo

So I guess the cost would $20 by month. Maybe we could ask to sponsor the project by providing analytics if we mention them with something like "Analytics provided by Plausible".

Closing the issue as we use CloudFlare analytics in production and we are going to release a brand new version of the app, built with Next.js.
With the new "server-centric" approach, we don't need to track users on the client-side, it seems Vercel provides a solution that I have to check: https://vercel.com/docs/concepts/analytics/quickstart
Anyway any suggestion is welcome as all I need is an idea of the traffic and the pages that have traction, and that I'd like to make public as I have nothing to hide.


support on-chain metadata as strong instead of erroring

Some smart contracts use base64 encoded JSON metadata to protect against external dependencies.
We should support NFT projects that aim to provide value through immutable on-chain art and NFTs.
Using the vibes.art contract, located at:
0x6c7C97CaFf156473F6C9836522AE6e1d6448Abe7
And looking up token 1, the result is now:

good

Hi @remnynt I know it's an old PR but I was thinking of making another PR where #17 and #14 could be merged together to have something more complete, about this PR I think that in the case of vibes.art the NFT being classified as Strong ca

Hi @remnynt I know it's an old PR but I was thinking of making another PR where #17 and #14 could be merged together to have something more complete, about this PR I'm not sure if cases like vibes.art should be classified as Strong, because even though metadata are stored onchain, in this case a part of it is still stored in a centralized way:
if we take a look at the metadata for id 1 we have:
{"name": "vibe #1", "description": "vibes is a generative art collection, randomly created and stored on chain. each token is an interactive html page that allows you to render your vibe at any size. vibes make their color palette available on chain, so feel free to carry your colors with you on your adventures.", "image": "https://vibes.art/vibes/jpg/1.jpg", "attributes": [{ "trait_type": "element", "value": "light" }, { "trait_type": "palette", "value": "sylvan" }, { "trait_type": "colors", "value": "5" }, { "trait_type": "style", "value": "smooth" }, { "trait_type": "gravity", "value": "low" }, { "trait_type": "grain", "value": "medium" }, { "trait_type": "display", "value": "mirroredUpsideDown" }]}

and so we can see how the image field is still stored in a centralized way on https://vibes.art/vibes/jpg/1.jpg . I think there should be a distinction between a fully decentralized solution and a partially decentralized one.

hi @niccolopetti - thank you so much for the response!
it's a challenging problem to automate solving for on-chain-ness, since there are so many creators working around the current implementations of centralized marketplaces.
i've recently been following https://www.0xchain.art/
their solution has been a sort of curation of projects. this is not ideal since it's not automated, but i do appreciate the lens of what constitutes a decentralized ERC-721 project.

using vibes as an example:
the vibes output is on-chain HTML, combining a blockhash captured at time of mint with a rendering script (written in raw JavaScript, no dependencies) and stored in a constant within the contract (SSTORE).
in other words, the artwork is a generative computer program that outputs art "jpegs" at any size. since that program is stored 100% on Ethereum, and can be retrieved via tokenScript and run in any web browser to reproduce visual representations of itself, it is both decentralized and resilient to decay or loss.

if someone produces outputs from the program, and caches them somewhere else on the internet, that does not make the on-chain artwork less decentralized.
this approach is common amongst developers seeking to create with HTML / JS on-chain, since marketplaces like OpenSea do not support direct from on-chain HTML (though i've been told it's on their roadmap). the only solution for now to offer the optimal UX is to cache outputs off-chain, but we do include on-chain toggles for when marketplaces better support direct from on-chain HTML.
another example, one of my personal favorites, is Terraforms by Mathcastles. they also cache their on-chain outputs on their private web servers for the time being, and point to them from the contract tokenURI, but what they've done on-chain is truly remarkable, and has no vector or risk for centralization in my review.
with regards to the PR, i appreciate your time in reading it along with my thoughts here - please feel free to close or merge; it's my hope that the our interaction is useful in some small way. cheers!

Hi @remnynt, thank you so much for your response!
I didn't know Terraforms AND 0xchain.art and was fascinated by the examples of onchain art they provide!
I admit I didn't read carefully through the code of vibes.art but just focused more on what was returned by the tokenURI.
Focusing only on that I think checkmynft should treat that cases like that (onchain metadata with links to offchain resources on centralized servers) as  a special case (currently ending up in a false negative for vibes.art, but if we want to treat NFTs as a blackbox I can't think of a way to handle cases like vibes.art unless a new EIP is proposed, which might not be a bad idea though).
If we prefer to accept false positives over false negatives then also the current implementation is fine.
I recognize that given current limitations of various marketplaces the solution you found is probably the best and is surely decentralized and is ready to be fully decentralized without touching offchain servers once there will be support from 3rd parties.
Thank you again for the response which brought me to discover useful resources, and with regards to the PR I am just a contributor like you not a mantainer so I have no power to merge or close the PR, I merged it on my fork https://github.com/niccolopetti/checkmynft/pull/1#issue-1276189290 though because I needed it together with support for other evm chains, and through vercel I now have that hosted without needing to set up a server for it through https://github.com/theweaver19/checkmynft/pull/17#issuecomment-1146865578
If it can be useful to others they can use the result of both PRs through that until they eventually get merged by the mantainer.


Rainlab.Blog integration

Hi I just want to check if I did the Rainlab.Blog integration right, I've added the necessary classes.
This is the result I am getting so I wanted to check if it is right - orange background and still visible original editor.

Also when trying to save I am getting this error
"SQLSTATE[HY000]: General error: 1364 Field 'contentable_id' doesn't have a default value (SQL: insert into reazzon_gutenberg_contents (raw_content, rendered_content, updated_at, created_at) values (, , 2019-05-19 20:59:41, 2019-05-19 20:59:41))" on line 664 of C:\laragon\www\tmavaochutnavka\vendor\laravel\framework\src\Illuminate\Database\Connection.php
And last question if I would like to have Slovak translation I should help translating also VanOns/laraberg right?

You don't need to add something to RainLab.Blog plugin manually.
Just install Blog and Gutenberg, find in settings Gutenberg tab, and click on Gutenberg settings. Then just click to RainLab.Blog Integration switch, and you are done.

Thanks I missed that there is a settings for Gutenberg.

When you use integration, you don't need to change anything, just use RainLab.Blog as usual, so if you want to render content, just call {{ post.content_html|raw }} as stock RainLab.Blog Post component do.


401 Invalid Authorization Credentials using LDAP auth

What happened?
I tried Reposilite 3.5.6 intergrate with OpenLDAP 2.4.57
On user login Reposilite reports error - "401 Invalid Authorization Credentials".
OpenLDAP log on Reposilite login:
ldap_1                | 65ccb304 conn=1021 fd=12 ACCEPT from IP=<IP_ADDRESS>:43118 (IP=<IP_ADDRESS>:389)
ldap_1                | 65ccb304 conn=1021 op=0 BIND dn="cn=readonly,dc=domain,dc=com" method=128
ldap_1                | 65ccb304 conn=1021 op=0 BIND dn="cn=readonly,dc=domain,dc=com" mech=SIMPLE ssf=0
ldap_1                | 65ccb304 conn=1021 op=0 RESULT tag=97 err=0 text=
ldap_1                | 65ccb304 conn=1021 op=1 SRCH base="ou=people,dc=domain,dc=com" scope=2 deref=3 filter="(&(objectClass=posixAccount)(uid=mykola))"
ldap_1                | 65ccb304 conn=1021 op=1 SRCH attr=uid
ldap_1                | 65ccb304 conn=1021 op=1 SEARCH RESULT tag=101 err=0 nentries=1 text=
ldap_1                | 65ccb304 conn=1022 fd=13 ACCEPT from IP=<IP_ADDRESS>:43120 (IP=<IP_ADDRESS>:389)
ldap_1                | 65ccb304 conn=1022 op=0 BIND dn="uid=mykola,ou=people,dc=domain,dc=com" method=128
ldap_1                | 65ccb304 conn=1022 op=0 BIND dn="uid=mykola,ou=people,dc=domain,dc=com" mech=SIMPLE ssf=0
ldap_1                | 65ccb304 conn=1022 op=0 RESULT tag=97 err=0 text=
ldap_1                | 65ccb304 conn=1022 op=1 SRCH base="ou=people,dc=domain,dc=com" scope=2 deref=3 filter="(&(objectClass=posixAccount)(uid=mykola)(memberOf=cn=users,ou=reposilite,dc=domain,dc=com))"
ldap_1                | 65ccb304 conn=1022 op=1 SRCH attr=uid
ldap_1                | 65ccb304 conn=1022 op=1 SEARCH RESULT tag=101 err=32 nentries=0 text=

We have two binds:

conn=1021
Works fine for connect readonly user
conn=1022
Failed for user mykola because of err=32 (No such object)

This error is caused because LDAP is blocking login for any other users (even if they actually exists). Only some particular users (readonly in my case) this is allowed.
I think no needs on the second Bind to use actual user (mykola), but reuse the first one (readonly) again.
Otherwise it will require to change LDAP security configuration to allow this, but it's kind of undesirable practice because BindDN is used.
Reposilite version
3.x
Relevant log output
No response

@dzikoysk As you asked, my shared configuration. Only LDAP configuration added and all the rest left untouched.
shared.configuration.json

Could you take a look at this setup:
https://github.com/dzikoysk/reposilite/blob/9a20c45cd0fd9a50d679246cc441b3ca0dc5aee7/reposilite-backend/src/test/kotlin/com/reposilite/auth/LdapAuthenticatorTest.kt#L141-L206
It works for me, so I'm not quite sure what change would be required here.

mykola authenticated, readonly not authenticated if baseDn is set to ou=people,dc=domain,dc=com
mykola authenticated, readonly authenticated if baseDn is set to dc=domain,dc=com

I guess you have a bit of different setup on your server, so we'd need to recreate this on my side first & investigate if it's indeed correct.

@dzikoysk  Here is some part of my configuration.

Thanks for your cooperation, it took us a while 😅 I'll try to release it this week as 3.5.7, but you can already use nightly/snapshot build.


fix: folder background should be green if to hover over in chat panel purple in prompt panel

Issue: https://github.com/epam/ai-dial-chat/issues/91

/deploy-review


fix(fetchDevel): better BASE_URL logic, fixes #645 and nextjs app dir

The existing code resulted in a "Module Not Found" error when used with NextJS's new "app" router (vs its "pages" router, which works fine).  See #645 for more details.  Many thanks to @z3nful for investigating this issue and crafting the fix.

:tada: This PR is included in version 2.8.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Multiline bodies and footers being ignored

Component
Version

auto-changelog
0.5.1

Python
3.8

Operating System
Ubuntu 16.04.2 LTS (Xenial Xerus)

Description
auto-changelog does not process correctly commits which contain multiline bodies or footers.
A commit which contains a multiline body will be ignored by auto-changelog.
What I Did
Input
commit d912d6c97cefe38a3fe0e5933dc9bd9ea77fa7b0
Author: John Doe <john.doe@email>
Date:   Thu Aug 6 11:11:35 2020 +0200

    feat: Add file #1

    Body line 1
    Body line 2

Observed output
# Changelog

## Unreleased (2020-08-06)

Expected output
# Changelog

## Unreleased (2020-08-06)

#### New Features

* Add file #1

pytest integration test to reproduce this issue
@pytest.mark.parametrize(
    "commands",
    [["touch file", "git add file", "git commit -m 'feat: Add file #1\n\nBody line 1\nBody line 2' -q", "git log"]],
)
def test_double_line_body(test_repo, runner, open_changelog):
    result = runner.invoke(main, ["--unreleased"])
    assert result.exit_code == 0, result.stderr
    assert result.output == ""
    changelog = open_changelog().read()
    print(changelog)
    assert "Add file #1" in changelog

Further analysis shows that auto-changelog only accepts exactly one line of text as optional body and exactly one line of text as optional footer:
https://github.com/Michael-F-Bryan/auto-changelog/blob/87d7415ed0f956f312ef26470c9089413dc08cd7/auto_changelog/repository.py#L198
Also unit tests only test against this pattern:
https://github.com/Michael-F-Bryan/auto-changelog/blob/87d7415ed0f956f312ef26470c9089413dc08cd7/tests/test_repository.py#L88-L100
So auto-changelog  is neglecting the following paragraphs of Conventional Commits 1.0.0 specification
https://www.conventionalcommits.org/en/v1.0.0/ :

A commit body is free-form and MAY consist of any number of newline separated paragraphs.

auto-changelog only accepts a single paragraph single line commit body.

One or more footers MAY be provided one blank line after the body. Each footer MUST consist of
a word token, followed by either a :<space> or <space># separator, followed by a string value (this is inspired by the
git trailer convention).
A footer's token MUST use - in place of whitespace characters, e.g., Acked-by (this helps differentiate
the footer section from a multi-paragraph body). An exception is made for BREAKING CHANGE, which MAY also be used as a token.

auto-changelog only accepts a single footer and does not check against word tokens and the subsequent separator.

A footer's value MAY contain spaces and newlines, and parsing MUST terminate when the next valid footer
token/separator pair is observed.

auto-changelog only accepts a single footer


ReleasePipeline details

I Can see releasepipelineid in TestRun and TestResults entity but there is no refrence table to get release pipeline details , Are these avaiable in v3.0-preview or any plan to include this

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df0406dd-f852-001f-eba5-a665ed4ef7a0
Version Independent ID: 51657f61-8b0c-3132-59d4-7d876b08af6d
Content: Data model for Analytics - Azure DevOps
Content Source: docs/report/extend-analytics/data-model-analytics-service.md
Product: devops
Technology: devops-analytics
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@Vchawla21 - TestRuns and TestResults entity just contain enough information to identify the release pipelines that they ran on so that they can be grouped or filtered by those attributes. However, since we do not have Release pipeline data in Analytics, the actual release pipelines tables are not present. It will not be available in v3.0-preview and we do not have plans to do this either.
//cc - @PBoraMSFT who is the product owner for visibility on this requirement.

Closing as addressed.


Why the empty setup.cfg file ?

I'm sorry but I'm unable to understand the reason behind the empty setup.cfg file 😓

Great question. I think it was added at some point to prevent pip from complaining during installation. But it doesn't seem like it is necessary (I'm a novice at packaging). If it is indeed not necessary, I'm fine with it being removed.

Yes, the setup.cfg isn't necessary and does not affect packaging.

Made a PR (#1495) to delete setup.cfg


Disable sending feedback on per widget basis

This was originally suggested here: http://www.qlcplus.org/forum/viewtopic.php?f=24&t=10158&p=46291#p46273
I would see it like this:
In any VCwidget that sends feedback could have a "send feedback" checkbox under "custom feedback". This checkbox is bound to a flag that basically disables updateFeedback execution. This checkbox is selected by default and affects specific VCwidget, so someone might have a button and slider bound to the same button on console and have the slider not mess custom feedback data up.
It seems to be trivial to implement and might me useful for someone.
If nobody points any major drawback in it and nobody picks this up I'll work on it on next weekend and file a pull request.

Okay, so after some looking around the code it seems that the easiest approach would be:

Add a "send feedback" checkbox to InputSelectionWidget (or something along these lines)
Modify every single widget that uses InputSelectionWidget to support disabling feedback on particular channel.
Probably implement it with backwards compatibility - enabling this checkbox by calling a special method. Just like it's done for custom feedback values.

It's trivial to implement, but still a lot of work for very small feature. I can work on it, but is it really that useful that it's worth the time?
Other, much simpler approaches:

Implementing feedback disable widget global, for example a flag that would disable sendFeedback functions. Then adding a global checkbox for each widget type.
Implementing feedback disable only for basic widgets - buttons (originally requested) and faders (might be useful).

Any opinions on this one?

What the user requested was disabling for a widget, so I think alternative no.1 is not the way to go (I can't even imagine a use case for that).
The basic questions are:
Would @mcallegari merge it in the way you described?
And are you willing to do it?
Let's answer these before proceeding. I personally have no use case for this feature, but if some users would be happy with it, its fine.
While writing I had an idea about placing the checkbox: It could be hidden by the "custom feedback" button and placed at the beginning of the line that appears when clicking it.

Yes, as I stated originally I would be willing to do that.
However the original idea looks like a lot of work for very rare use case, that's why I'm holding back and would like some discussion first - I don't have unlimited time, why waste it?
Small clarification for no.1 - by global I've meant per each individual widget instance, for example if we take a vcspeeddial there would be a checkbox that disables all feedbacks for this specific vcspeeddial.
Still I don't like no.1, just see it as an option.
Original approach seems to me like the way to go (your suggestion about checkbox placement sounds good to me), but it's a fair amount of work.
No.2 would be trivial and fast to implement and would address most of use cases when you actually need to disable feedback (more complex ones could be solved using loopback then).


PegSequential lock via order

Change the PegSequential class to add lock directly to orders.

Version 0.8.3 closes this issue


Test/add unittests

Description
Add unit tests
Changes Made

Basic unit tests implemented
xml/xsd files for testing included
tox automation included for running tests and flake8 checks

Testing

[x] Unit Tests

Had to include some files for testing, as I realized the initial version of the CLI is not able to gather xml files from a web url yet. Is this a functionality that the tool could use however?

related to:

Had to include some files for testing, as I realized the initial version of the CLI is not able to gather xml files from a web url yet. Is this a functionality that the tool could use however?

in this initial version no, probably start an issue on it and add it as a feature.


Large training batches on limited GPU hardware

This PR adds a LargebatchAdam optimizer, which accumulates gradients over n batches and applies the Adam learning rule every n batches on the accumulated gradients. This makes it possible to arbitrarily increase the effective batch size / number of GPUs at cost of more training iterations. This technique is useful if the number of physical GPUs is limited or the GPU memory does not allow to increase the batch size any further. Large batch / multi-GPU training is often important for Transformer training as reported here.

@fstahlberg Looks really cool! Could you provide some results of experiments, e.g. translation problem with BLEU score and a comparison with one vs. multiple GPUs?

Closing this in favour of #754 as some commits were submitted with an invalid e-mail address which caused problems with the Google CLA, and my attempts to amend the e-mail address in previous commits were not successful.


UI Issue with Default Profile dropdown in settings page

Windows Terminal version (or Windows build number)
10.0.19043.1110, 1.9.1942.0
Other Software
No response
Steps to reproduce

Open settings tab
Expand the default profile dropdown
Keeping the dropdown open, scroll the page using the scroll wheel on the mouse
The gif below shows the behavior

Expected Behavior
The dropdown should stay within the screen
Actual Behavior
The dropdown scrolls to outside of the window.

Thanks for the suggestion! Please make sure to search for duplicates when filing new issues. This is already being tracked by another issue on our repo - please refer to #9320 for more discussion.
/dup #9320


Update component schematic to 'export default class' by default

Command
generate
Description
The DX has been improved in Angular lazy loading route generation by allowing the removal of the requirement to use .then(c => c.HomeComponent) syntax by adding the default keyword on the route provider (route file/component/module).
But it comes at the cost of manually opening another file to add this keyword while writing the route definition, making the DX improvment quite limited.
Describe the solution you'd like
Is there any possible negative impact at making ng generate component includes the default keyword by default?
Describe alternatives you've considered
No response

Duplicate of https://github.com/angular/angular-cli/issues/25023


Updated the kops git tag to 1.29.2

Issue https://github.com/aws/eks-distro/issues/3214, if available:
Description of changes:
Bumped the kops git tag to 1.29.2.

PR in eks-distro-build-tooling [https://github.com/aws/eks-distro-build-tooling/pull/1497]
Latest release: https://github.com/kubernetes/kops/releases

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve
/lgtm


add stack trace on expect.(has)Assertions

Summary
Pointing back to the failing test is nice.
Half of #5104

Test plan
Green CI

Codecov Report

Merging #5997 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5997   +/-   ##
=======================================
  Coverage   64.32%   64.32%
=======================================
  Files         217      217
  Lines        8312     8312
  Branches        3        4    +1
=======================================
  Hits         5347     5347
  Misses       2964     2964
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e7ac2...44f0a60. Read the comment docs.

Lovely!


Remove extra whitespaces

Both VSFT examples currently fail.
Traceback (most recent call last):
  File "/fsx/qgallouedec/trl/examples/scripts/vsft_llava.py", line 206, in <module>
    trainer.train()
  File "/fsx/qgallouedec/trl/trl/trainer/sft_trainer.py", line 418, in train
    output = super().train(*args, **kwargs)
  File "/fsx/qgallouedec/miniconda3/envs/trl/lib/python3.10/site-packages/transformers/trainer.py", line 1850, in train
    return inner_training_loop(
  File "/fsx/qgallouedec/miniconda3/envs/trl/lib/python3.10/site-packages/transformers/trainer.py", line 2249, in _inner_training_loop
    _grad_norm = self.accelerator.clip_grad_norm_(
  File "/fsx/qgallouedec/miniconda3/envs/trl/lib/python3.10/site-packages/accelerate/accelerator.py", line 2269, in clip_grad_norm_
    self.unscale_gradients()
  File "/fsx/qgallouedec/miniconda3/envs/trl/lib/python3.10/site-packages/accelerate/accelerator.py", line 2219, in unscale_gradients
    self.scaler.unscale_(opt)
  File "/fsx/qgallouedec/miniconda3/envs/trl/lib/python3.10/site-packages/torch/amp/grad_scaler.py", line 337, in unscale_
    optimizer_state["found_inf_per_device"] = self._unscale_grads_(
  File "/fsx/qgallouedec/miniconda3/envs/trl/lib/python3.10/site-packages/torch/amp/grad_scaler.py", line 259, in _unscale_grads_
    raise ValueError("Attempting to unscale FP16 gradients.")
ValueError: Attempting to unscale FP16 gradients.

Related https://github.com/huggingface/transformers/issues/23165

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

For the record, I've considered adding support for Llava as well but Llava processor doesn't have apply_chat_template. However, apply_chat_template will be part of the default methods for all processor from the next transformers release: https://github.com/huggingface/transformers/pull/30744. So I recommend adding llava support later, in another PR.

ok ready to merge imo

For the record, I've considered adding support for Llava as well but Llava processor doesn't have apply_chat_template. However, apply_chat_template will be part of the default methods for all processor from the next transformers release: huggingface/transformers#30744. So I recommend adding llava support later, in another PR.

Has LLaVA been supported?

Not yet but I think you can slightly modify dpo visual to make it work with llava (just add the chat template)

Not yet but I think you can slightly modify dpo visual to make it work with llava (just add the chat template)

@qgallouedec Thanks for the comments!


Ignore curly braces contained within a code block

Hi Soren.
A cloze card like the following causes a sync error, presumably because of the open curly bracket:
<<remembercz "20210710114236368"
    """
        ''CSS: ID selector syntax''

        {`#`}`id-name {...`
    """
>>

In my opinion TiddlyRemember should ignore curly braces contained within a code block. It seems reasonable to assume that there are many cases where a user might want include a curly bracket in a cloze card without also invoking a new cloze element.
Thanks for the great plugin.

I agree this is tricky, although what about cases where the user does want the cloze inside a code element?
What is the sync error specifically? Mismatched braces since you don't have a } for the second pair?
Single curly braces really stink as a cloze delimiter in cases like these – Anki's double braces are much better – but double and triples are already taken in TW, and square brackets are even worse!

What is the sync error specifically? Mismatched braces since you don't have a } for the second pair?

Yeah: ValueError: expected '}' before end of string

I agree this is tricky, although what about cases where the user does want the cloze inside a code element?

Well the only thing I can think of is to close the code element before adding the curly braces, then open it again. This is what I tried to do in my example:
{`#`}`id-name {...`

This is obviously pretty awkward, and will only work with inline code I suppose.
I guess the choice is between not being able to use clozes on code that contains a '{', or not being able to use clozes within a code block. I'm not sure which is worse.
Maybe you could ignore '{' if it doesn't find a closing bracket on the same line, rather than giving an error?

I agree this is tricky, although what about cases where the user does want the cloze inside a code element?

Couldn't having an escape character be a way of making sure the user's intention is clear?
In the meantime, I discovered the use of ⦃white curly brackets⦄. It's a plain workaround on the user's side, easily added to Autokey/Autokey or what not (strangely I couldn't it to work with <Multi_key> on .Xcompose as of yet). @grooveboxunited <Multi_key> <{> <{> or <Alt_gr> <{> <{> is a non-intrusive way to yield ⦃ without having to wait for an "airdrop". Maybe it'll fit your workflow as it does mine.
… Actually, maybe ⦃⦄ could even be the end result of character replacement operated by TiddlyRemember to avoid having to deal with too many real curved brackets!? Just an very roughhewn idea here :)

In the next version, you will be able to escape braces that you don't want to become part of a cloze delimiter with \{ and \}. This might be a little irritating to write inside code blocks that are heavy on braces, but it saves the parsing code from having to understand where code blocks are, which would require a rewrite of the cloze parser since it currently selects occlusions via a simple regex and regexes aren't really capable of understanding HTML doctrees. If this proves inadequate, we can revisit the question of making it do something different in code blocks.


Research lua files for "offsetitempos" and "ridingspreditinfo"

Research whether they are used during the rendering process.

OffsetItemPos_GetOffsetForDoram(in_classNum, in_direction, in_sex) defined in offsetitempos_f.lub with data from offsetitempos.lub is definitely being used.
Tested with the headgear ACCESSORY_Subject_Aura_Red = 1418 which has a defined offset for e.g. (OffsetItemPos.AddOffsetForDoram)(1418, (OffsetItemPos.Direction).FRONT, {y = -30});.
Reference image:
https://imgur.com/a/Ck3Ula7

ridingspreditinfo.lub and ridingspreditinfo_f.lub are not used ingame. Maybe they're used when creating the mount sprites themselves and the offsets appear in the respective *.act files. Who knows.


Endaoment Projects can participate in the GIVeconomy

Endaoment projects should be able to benefit and provide benefits associated with GIVbacks and GIVpower

[ ] Users that donate to Endaoment projects can receive GIVbacks and donations are included in givbacks calculations
[ ] Users can boost Endaoment projects with GIVpower
[ ] GIVpower table shows correct data
[ ] estimated ranking shows correctly

FYI @laurenluz

Needs to test that donation to Endaoment project was captured in our givbacks-calculation on staging
@Rolazo - Do we know the URL of givbacks-calculation for staging?
to test:
make a donation to an endaoment project - check on the givbacks-calculation API and adjust to the dates to look for ONLY when you made the donations to endoament
check that your address is included in the query response and there is an amount of GIVbacks you would receive
test as well that you can use GIVpower boosting on Endaoment projects, here's the guide! https://docs.giveth.io/giveconomy/givpower

@divine-comedian @Rolazo
Do we have the URL of givebacks calculations for staging? so I can verify

@mohammadranjbarz @divine-comedian
After successfully making donations to 2 Endaoment projects, checked the the Givback calculations API, but it didnt return any data for the donations I made, I couldnt find my wallet address as well as the Givbacks donated.
These are the Endaoment Projects I donated to

@mohammadranjbarz can you check this failed test
So we're on the same page I was informed these are the givbacks-calculation deployments we should use:
givbacks calc staging (https://givback.develop.giveth.io/api-docs/)
givbacks calc production (https://givbacks.giveth.io/api-docs/)

@LatifatAbdullahi - could you provide the tx hashes of the donations you made that did not appear in the givbacks-calculations

@mohammadranjbarz
You can check with these transaction hashes
0x1239387141284d846569f51de729a978968ad93842612650fd46cca1e27a45bd
0x6f2e8cc0565c0c7275584eb06f5ae62ef923ad5e70ddf766a2bfc1ffd313a73c

0x6f2e8cc0565c0c7275584eb06f5ae62ef923ad5e70ddf766a2bfc1ffd313a73c

@LatifatAbdullahi
Ok got it, you know in the givback-calculation we have a term named purple list, there some addresses that we exclude them from givbacks, for instance the recipient address of verified projects are not eligible for givbacks. I checked you address and saw you are in the purple list so it's a normal behaviour to not include your donations, you can see the purple list here
https://givback.develop.giveth.io/api-docs/#/default/get_purpleList
So in these cases the donations would not be in the eligible-donations list, but you still can find them in the not-eligible-donations
https://givback.develop.giveth.io/api-docs/#/default/get_not_eligible_donations

Please donate with a new wallet that is not in the purple list (is not recipient of any verified project) and check this issue again

@mohammadranjbarz
I have attempted to make donations to different Endaoment projects on staging but they all failed and throwing error message, please do you know why?

I was able to donate successfully, can you please re-test @LatifatAbdullahi

@mohammadranjbarz @divine-comedian
Test Update: Pass
This works as expected, I donated successfully to an Endaoment project and the details are present in the GIV calculation API

https://github.com/user-attachments/assets/8cb96358-ba3f-4d44-bcc1-0a2f1a831f0f


feat(formatters): Add custom d3-time-format locale

SUMMARY

Adds a configuration option to change the default language of time related data on charts, including the option to translate months. This is related to issues: #3972 , https://github.com/apache/superset/issues/13442 and https://github.com/apache/superset/issues/17447.
During the implementation I had to change how the smart formatters were used across the application, because I had to ensure that they were instantiated with the right locale configuration. So instead of importing them directly, I got them through the TimeFormatterRegistry. I'm not sure if is the best option, let me know.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Without time format configuration:

With brazilian portuguese time format configuration:

TESTING INSTRUCTIONS

Add the D3_TIME_FORMAT with your locale configuration to superset_config.py following the definition expected by D3 (docs), for example, this is the definition for brazilian portuguese:
D3_TIME_FORMAT = {
  "dateTime": "%A, %e de %B de %Y. %X",
  "date": "%d/%m/%Y",
  "time": "%H:%M:%S",
  "periods": ["AM", "PM"],
  "days": ["Domingo", "Segunda", "Terça", "Quarta", "Quinta", "Sexta", "Sábado"],
  "shortDays": ["Dom", "Seg", "Ter", "Qua", "Qui", "Sex", "Sáb"],
  "months": ["Janeiro", "Fevereiro", "Março", "Abril", "Maio", "Junho", "Julho", "Agosto", "Setembro", "Outubro", "Novembro", "Dezembro"],
  "shortMonths": ["Jan", "Fev", "Mar", "Abr", "Mai", "Jun", "Jul", "Ago", "Set", "Out", "Nov", "Dez"]
}

ADDITIONAL INFORMATION

[X] Has associated issue:
[ ] Required feature flags:
[X] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[X] Introduces new feature or API
[ ] Removes existing feature or API

Also ccing @villebro since he is working on some other localization features.

Oh big fan of this!
Any updates on this?

Any updates on this review?

Any updates on this review?

Many thanks for this PR.
I'm awaiting for this PR: To use Superset in France (public sector), this PR is mandatory.
Do you have any idea when this PR will be merged in superset?

/testenv up

up

@eschutho I fixed the conflicts. If there is anything that I can do to help with the review, let me know :+1:

any  updates on this one?

There are a handful of linting errors to contend with still that are blocking this.

any updates on this one?

Looks like this needs some linting AND a rebase at this point. If @matheusbsilva wants to follow through, that's awesome, but anyone else is also welcome to pick this up if they desire to.

Thansk for the reply @rusackas, I'll fix the linting errors soon.

@rusackas I've fixed the linting errors and checked all the linters locally, everything is fine.

Running CI. Fingers crossed! 🤞

@rusackas I added more tests to fix the coverage issue reported in the last CI run.

@rusackas Is there anything else that I can do to help with the review?

/testenv up

up

Running CI again - fingers crossed! Last chance, @kgabryje / @justinpark / @michael-s-molina / @villebro

@rusackas I fixed some linting errors caused by merge conflict.

up

CI running again 🤞 . Feel free to DM me on slack as well if you need me to push buttons here again ;)

Hello, I've been using superset for 3 months. I want to change the language to french. I added the D3_TIME_FORMAT with my local configuration for superset_config.py but it still doesn't work. Could you help me again.

Hi
A PR is in progress for this.
See https://github.com/apache/superset/pull/24263
Christophe
Le ven. 7 juin 2024, 14:33, Bara Diaw @.***> a écrit :

Hello, I've been using superset for 3 months. I want to change the
language to french. I added the D3_TIME_FORMAT with my local configuration
for superset_config.py but it still doesn't work. Could you help me again.
Capture.d.ecran.2024-06-07.122437.png (view on web)
https://github.com/apache/superset/assets/56593952/467b36cb-0c04-429e-af18-8e85d0c7f667
—
Reply to this email directly, view it on GitHub
https://github.com/apache/superset/pull/24263#issuecomment-2154743335,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARWCBN2OJWYWY7ZXXAUAUFDZGGSCBAVCNFSM6AAAAAAYW4CNR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJUG42DGMZTGU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

oui, moi aussi.
Vous travaillez en France ?
Le ven. 7 juin 2024 à 17:23, Bara Diaw @.***> a écrit :

thanks @cchristofr https://github.com/cchristofr for your reply, I'll
keep waiting then
—
Reply to this email directly, view it on GitHub
https://github.com/apache/superset/pull/24263#issuecomment-2155061002,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARWCBN77V6AMV4VFTBW3ACTZGHF7PAVCNFSM6AAAAAAYW4CNR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVGA3DCMBQGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Non, je travaille au Sénégal.

espérons que nous aurons bientôt une gestion multilingue correcte.
Actuellement, le choix FR n'agit que sur la traduction de l'interface mais
pas sur les textes (et formats) dans les graphiques.
Sinon, superset est un bon produit.
Le ven. 7 juin 2024 à 18:54, Bara Diaw @.***> a écrit :

Non, je travaille au Sénégal.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/superset/pull/24263#issuecomment-2155198296,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARWCBN727OGI4Z5NH5N5PN3ZGHQUJAVCNFSM6AAAAAAYW4CNR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVGE4TQMRZGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Closing and re-opening due to a weird glitch with E2E tests.

Sorry, could you help? I paste your code, but for some reason nothing changes


mattermost: split into mattermost-server and mattermost-webapp

Motivation for this change
This improves overriding and build debug and paves the way for
attempting to build mattermost-webapp from source.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is outdated.


Updated tutorials

Summary
This PR updates the QNN related tutorials to the new implementations, SamplerQNN and EstimatorQNN accordingly. There are no intentions to improve the tutorials in the PR, but rather update them. Some features, e.g. sampling and sparse support are excluded as they are either not yet available or not demonstrable on the reference implementation.
Details and comments
Updated:

[x] 01_neural_networks
[x] 02_neural_network_classifier_and_regressor
[x] 02a_training_a_quantum_model_on_a_real_dataset
[x] 05_torch_connector
[x] 09_saving_and_loading_models
[x] 11_quantum_convolutional_neural_networks

The effective dimension tutorial is updated in a separate PR: #507
To be merged after #436, #470.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 88.853%

Files with Coverage Reduction
New Missed Lines
%

qiskit_machine_learning/datasets/gaussian.py
3
37.11%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
3539

Relevant Lines:
3983

💛  - Coveralls


Auto renew license

Context
Automatically renew the license so user does not have to renew it itself.
Suggested solution
Not really, I guess I am open for suggestion and looking for best solution.

Could you elaborate on what you mean by renewing the license and perhaps paint it with your practical use case, so it becomes a bit more clear what is meant by this issue?

Could you elaborate on what you mean by renewing the license and perhaps paint it with your practical use case, so it becomes a bit more clear what is meant by this issue?

This may be a question instead of an issue. I was wondering if there is a way that CI could automatically update/renew the free license once it is expires?

This may be a question instead of an issue. I was wondering if there is a way that CI could automatically update/renew the free license once it is expires?

It depends a lot on your use case I would say, as Unity has a big ecosystem.
For personal licenses you have to use an activation file (.alf) to manually acquire a license file (.ulf) from the website and that file has not been reported to ever expire. The manual process however can be automated; see that we have permission to use another project. Contributions are welcome.
For professional licenses this process goes automatically when providing username, password and serial number. Builder activates your license (1 slot), and returns it after. This license has not been reported to expire during a build either.
For other types of licenses (corporate, licensing servers, some other custom types perhaps) we do not have enough information.
Does this answer your question?

It depends a lot on your use case I would say, as Unity has a big ecosystem.
For personal licenses you have to use an activation file (.alf) to manually acquire a license file (.ulf) from the website and that file has not been reported to ever expire. The manual process however can be automated; see that we have permission to use another project. Contributions are welcome.
For professional licenses this process goes automatically when providing username, password and serial number. Builder activates your license (1 slot), and returns it after. This license has not been reported to expire during a build either.
For other types of licenses (corporate, licensing servers, some other custom types perhaps) we do not have enough information.
Does this answer your question?

For personal licenses you have to use an activation file (.alf) to manually acquire a license file (.ulf) from the website and that file has not been reported to ever expire. The manual process however can be automated; see that we have permission to use another project. Contributions are welcome.

Ah, I am using personal license (free). I do acquired the .ulf file from the website then the CI works. But after few days the CI stops working. Here is the log https://github.com/jcs090218/JCSUnity/runs/1905483230. What could go wrong by this scenario? 😕

For personal licenses you have to use an activation file (.alf) to manually acquire a license file (.ulf) from the website and that file has not been reported to ever expire. The manual process however can be automated; see that we have permission to use another project. Contributions are welcome.

Ah, I am using personal license (free). I do acquired the .ulf file from the website then the CI works. But after few days the CI stops working. Here is the log https://github.com/jcs090218/JCSUnity/runs/1905483230. What could go wrong by this scenario? 😕

This is likely due to Unity servers having some hiccups. Could you give it a few tries and see if it start working again? 🔮

As the opening post seems to no longer be needed, I'll close this issue.
Please feel free to create a new issue if there is indeed something broken.


Access token not renewed if expired

Silent renew of the access token is only done if it expires soon, not if it's already expired. It's possible to manually trigger renewal for expired access tokens by
userManager.events.addAccessTokenExpired(function() {
     userManager.signinSilent();
 })

but I wonder, why it's not done by default? Any specific reason for this, or could it be added by default?

userManager.getUser() should trigger an renew...

OK, but it doesn't do it, if the access token is already expired, only if it's expiring soon. That's my question if this should be changed?!

OK, but it doesn't do it, if the access token is already expired, only if it's expiring soon. That's my question if this should be changed?!

When a look at the code, it does (see "if it's negative, it will still fire" below):
https://github.com/authts/oidc-client-ts/blob/1aaeb9441a3235414e78d9f0e889712e4ec88263/src/AccessTokenEvents.ts#L26-L57
You may need to enable logging to console at debugging level to see what is going on with your application:
import { Log } from "oidc-client-ts";
Log.setLogger(console);
Log.setLevel(Log.DEBUG)

Yes, the event AccessTokenExpired is fired, but userManager.getUser() doesn't renew the tokens, if the access token is already expired. Therefore it's mandatory to add the code snippet I've posted to manually run userManager.signinSilent if the access token is expired.

Yes, the event AccessTokenExpired is fired, but userManager.getUser() doesn't renew the tokens, if the access token is already expired. Therefore it's mandatory to add the code snippet I've posted to manually run userManager.signinSilent if the access token is expired.

Have you enabled automaticSilentRenew? This code is expected to run when "access token expired" happened:
https://github.com/authts/oidc-client-ts/blob/1aaeb9441a3235414e78d9f0e889712e4ec88263/src/SilentRenewService.ts#L47-L63

I assume that the problem is that it's only listening to AccessTokenExpiring and not also AccessTokenExpired here

I agree. This code of only doing addAccessTokenExpiring is very old. I guess we can simply extend that and do that as well addAccessTokenExpired after the first register and also we need to remove it again. Can you try this out on your side?

This is probably a better way to handle this within SilentRenewService.ts:
...
            // this will trigger loading of the user so the expiring events can be initialized
            try {
                const user = await this._userManager.getUser();
                if (user?.expired) {
                    // we only listen on token expiring, thus request a new token if the current one is expired
                    await this._tokenExpiring();
                }
            }
            catch (err) {
                // catch to suppress errors since we're in a ctor
                logger.error("getUser error", err);
            }
...

Can you test this?


Fixes rendering of import examples

About this change—what it does

In the cases where the resource documentation has been overridden the code for importing the example import statement was incorrect leading to the terraform registry documentation stating the following;

Import is supported using the following syntax: {{codefile "shell" "examples/resources/aiven_service_integration/import.sh"}}

With this change the import statement is rendered correctly in the documentation.

Why this way
There is no other way to achieve correctly rendered documentation.

Thanks @sharebear for contributing :+1:


More details needed in Docker for Azure documentation

File: docker-for-azure/index.md, CC @johndmulhausen
Hi. I'm new to docker and azure. However, I guess other people getting started with this will run into the same problem when following the docs under the Docker for Azure section.
In the Setup & Prerequisites section, it's mentioned:

When setting up the ARM template, you will be prompted by the App ID and the App secret...

I guess ARM stands for Azure Resource Manager. Why should I set up a template? Isn't that what we have done on the previous command? I've successfully run the command ( docker run -ti docker4x/create-sp-azure sp-name rg-name zone) and found in the Azure portal there's a new resource group under the name I specified in the command. However that Resource Group has no resources.
I think there is a step missing in the docs.
It also becomes more obvious in the next part of the docs (Deploy your app), since it shows a screen capture with an already deployed app, and it doesn't specify how to get there. Also, if I created an Azure Web App and assign it to my new Resource Group, I don't get prompted for App Id or secret.
Hope this helps!

@gbarr01 PTAL and see if these gaps still exist and seem relevant.

cc/ @ddebroy


Automatically animate on list update.

It would be really nice if the drag/drop animation could be triggered when the list gets updated, not only with a long press and dragging and dropping an item.
For example:
Original list: [1, 2, 3, 4, 5, 6]
Grid:
[1, 2, 3]
[4, 5, 6]

List updated: [1, 2, 4, 5, 6] (item 3 removed in the backend)
Grid:
[1, 2, 4]
[5, 6]

The list gets updated just fine, but without any animation.
I'll look at your code to see how can we implement this.

Similar to https://github.com/casvanluijtelaar/reorderable_grid/issues/1 where I elaborted. If you want to look into it, please do!


lib/proxy.h: set variable as maybe unused to avoid compilation error

Set variable as __maybe_unused and define the macro HOST_REDIRECT_TO_INGRESS in the Makefile.
Fixes: #15095
Fixes: #15559
Signed-off-by: Joao Victorino<EMAIL_ADDRESS>

test-me-please

test-runtime

test-1.21-4.9

test-1.16-netnext

@pchaigno, any ideas why 1.16 and 1.21 have failed?

test-1.21-4.9

@pchaigno I didn't fully understand your last message.


[Bug] Connection to paypal.sylius.com, error

SyliusPayPalPlugin version affected: 1.5.1
Description
I'm trying to create a new configuration.
When I'm redirected to the authentication page, I get a server error.

Steps to reproduce

Possible Solution
Problem with paypal sylius server ?

Getting this error myself. I am trying to add/enable PayPal on a project as per the instructions and cannot seem to get past this.

@tejac can you retry now, and let me know whether it works :)?

@jakubtobiasz
It's OK for me. Thx

@jakubtobiasz it does, thank you!

Great, thanks!