Allow custom headers

Describe the feature:
Hello,
I have a custom elasticsearch plugin that requires HTTP headers and following this post on dicuss I'd like to know if it's possible to add the ability to pass custom headers either through --client-options and/or on a per operation basis by allowing an headers key in operations on track definition, thus allowing not to systematically use the raw-request operation.

Closed by https://github.com/elastic/rally/pull/1070


pull request for e2e test at 12/09/2016 10:56:01

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


osbuild-worker: rework the workerClientErrorFrom() error

The workerClientErrorFrom() was returning an *clienterrors.Error and an error (if something with the conversation goes wrong.
But the calling code was expecting that even if an error is returned the *clienterrors.Error is still valid. The caller would then just log the error. As returning a valid value even when there is an error is an unexpected pattern this commit changes the code to always return a *clienterrors.Error and log any issue via the logger.

LGTM, thanks 👍

Sorry, had to rebase because of conflicts, could you please re-review?


Fix possible name mismatch bugs when build wheel files within docker

Motivation
This PR fixes a name mismatch bug when developers specific NAME_POSTFIX for pulsar_client. In the previous release process, the generated wheel files were named pulsar_client-*-xxx.whl. Once NAME_POSTFIX is set, e.g. set to my_suffix, the build will be broken:
...
adding 'pulsar_client_my_suffix-2.8.0.dist-info/top_level.txt'
adding 'pulsar_client_my_suffix-2.8.0.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
+ auditwheel repair 'dist/pulsar_client-*-cp27-cp27mu-linux_x86_64.whl'
usage: auditwheel [-h] [-V] [-v] command ...
auditwheel: error: cannot access dist/pulsar_client-*-cp27-cp27mu-linux_x86_64.whl. No such file
...

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


fix(Designer): String Expression Uncasting to Literal On Initialization

Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fixes #4022

What is the current behavior? (You can also link to an open issue here)
on initialization, automatically converts string expression into literal

What is the new behavior (if this is a feature change)?
leaves string expression token as an expression instead of uncasting to string literal

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Please Include Screenshots or Videos of the intended change:

https://github.com/Azure/LogicAppsUX/assets/144840522/80524221-bc4d-416b-9bd7-d7047a214153

After syncing with Tony, I learned that wrapped/nested string expressions - theoretically - may have problem by not being uncasted. As suggested, I was going to make modification as to remove from uncast logic only if the string expression is "string('')". After checking the uncasting functions, specifically uncastOnce I modified, I realized that it checks for the most outer layer of expression type only (expression.name), which means for nested cases, anything including string expression will still be casted. Therefore, I will leave this change and not make further modifications.


JS - main page

Call the API to get the list of food pairings based on the selected wine

Thank you Gwen, here we should check together because I am not sure how you want to do this as I had a slightly different thing in mind. See my other comments on this topic.

Can you make the time suggested tomorrow to meet? Let’s discuss then.
I think changing things at this last minute is going to make things harder.
Either way we must meet asap.
Get Outlook for iOShttps://aka.ms/o0ukef

From: ElodieLongo @.>
Sent: Monday, November 13, 2023 7:32:08 PM
To: gwengibbes/com6338-module10-assignment10-gibbes-longo-avery @.>
Cc: Gibbes, Gwen @.>; Author @.>
Subject: Re: [gwengibbes/com6338-module10-assignment10-gibbes-longo-avery] JS - main page (Issue #20)
[External Email]
Thank you Gwen, here we should check together because I am not sure how you want to do this as I had a slightly different thing in mind. See my other comments on this topic.
—
Reply to this email directly, view it on GitHubhttps://github.com/gwengibbes/com6338-module10-assignment10-gibbes-longo-avery/issues/20#issuecomment-1809299459, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXF7232JCDUNOTN5B7MKTTLYEKUXRAVCNFSM6AAAAAA7J3TUQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZGI4TSNBVHE.
You are receiving this because you authored the thread.Message ID: @.***>

Closing since this is a duplicate of issue #1


[gym] extracting an ipa with method app-store modify entitlements

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject
I'm using gym to build an xcarchive and then extract an adhoc and appstore .ipa files.
With adhoc method the entitlements are fine, specially my issue is that aps-environment is inside adhoc.
But when I extract with appstore method my aps-environment value is missing and when I upload to the store using deliver the Apple send me the following warning.

Now i wonder, since I'm not an iOS dev. Is it possible to extract 2 different ipas (ad-hoc & app-store) from 1 xcarchive?
I'm cannot achieve it.


Fix compatibility for node 15.x

Node has added its own AbortController in 15.0.0. The AbortController signal
inherits from EventTarget. This changes the check to also accept signals of
type EventTarget.
https://nodejs.org/docs/latest-v15.x/api/globals.html#globals_class_abortsignal
What is the purpose of this pull request?

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (provide an overview)
Modified the isAbortSignal check to accept EventTarget as well.
Which issue (if any) does this pull request address?
Incompatibility with the new node AbortController

Node has added its own AbortController in 15.0.0.

Cool - have looked forward for this! More spec'ed browser apis!

The AbortController signal inherits from EventTarget.

Not as cool - then i hope that EventTarget later get an alias for addEventListener, removeEventListener and dispatchEvent


Error message: 'collections.OrderedDict object' has no attribute 'github_token_for_doc_deployment'

When trying to create a project using the sphintoxetry-cookiecutter template this error message is returned:
Error message: 'collections.OrderedDict object' has no attribute 'github_token_for_doc_deployment'
I believe this is due to the difference in the variable name in the cookiecutter.json where it is named  github_token_variable_name_for_doc_deployment

Thank you for reporting this @yaseminbridges ! I have fixed the problem. Please confirm.

All good now!


CLP(Z) - all_distinct/1

Really just a progress note to self here:
~/trealla (devel) $ tpl ~/scryer-prolog/src/lib/clpz.pl
?- all_different([A,B]).
   clpz:all_different([A,B]),clpz:all_different([A,B]).
?- all_different([A,B]), A=1, B=1.
   false.

Ok, that's good.
?- all_distinct([A,B]).
   true.

Oops, not good, where are the residuals?
?- all_distinct([A,B]), A=1, B=1.
   A = 1, B = A.

They are really not there it seems. But freezing them first then they now appear...
?- freeze(A,true),freeze(B,true),all_distinct([A,B]).
   clpz:all_distinct([A,B]),freeze:freeze(A,true),clpz:all_distinct([A,B]),freeze:freeze(B,true).
?- freeze(A,true),freeze(B,true),all_distinct([A,B]),A=1,B=1.
   false.
?- freeze(A,true),freeze(B,true),all_distinct([A,B]),A=1,B=2.
   A = 1, B = 2.

Yes, that works. Very odd!

Fixed.
~/trealla (devel) $ tpl ~/scryer-prolog/src/lib/clpz.pl
?- all_distinct([A,B]).
   clpz:all_distinct([A,B]).
?- all_distinct([A,B]), A=1,B=1.
   false.
?- all_distinct([A,B]), A=1,B=2.
   A = 1, B = 2.


AXI and LPIF tests need to use latest AIB 2.0 RTL

Current tests use:
export AIB_ROOT=${PROJ_DIR}/../aib-phy-hardware
export RTL_ROOT=${AIB_ROOT}/v2.0/rev1/rtl
The tests need to use the BCA RTL at
v2.0/rev1.1/rtl
This may require a small amount of porting, e.g. adding ports to instantiation of AIB.

AXI4 done, working on LPIF update

LPIF update done


Ability to limit cluster level permissions necessary to run mizu

The minimum permissions needed to run mizu for the default cluster namespace are below:
- apiGroups:
  - ""
  - apps
  resources:
  - pods
  - services
  verbs:
  - list
  - get
  - create
  - delete
- apiGroups:
  - ""
  - apps
  resources:
  - daemonsets
  verbs:
  - list
  - get
  - create
  - patch
  - delete

However, when running in a shared cluster environments having these permissions on the default namespace is not possible for lot of reasons. It would be great if cluster level permissions are restricted to a specific namespace.
Happy to discuss more and contribute.

Hi @ksudhir007, many thanks for your question.
We're working on a feature that will allow you to run mizu in a specific namespace (not only default).
In this case mizu would use namespace-based permissions, and not cluster-wide.
Would that properly address your use-case ?
Thanks!

Thanks @haiut - yes! that works. Is this going to be available on the open-source version ? If yes, is there some draft on the design, I am happy to contribute as well.

I see a pull request open to address this 🚀 🚀


monitor.getDifferenceFromInitialOffset() returns null

Description
I am trying to set the state of a card when it is dropped. For that I am doing this in the useDrag Hook. But in this monitor.getDifferenceFromInitialOffset() returns null and it throws an error.
end: (item, monitor) => {
      const delta = monitor.getDifferenceFromInitialOffset();
      console.log(delta);
      const top = Math.round(item.top + delta.y);
      const left = Math.round(item.left + delta.x);
      move(top, left);
      return undefined;
    },

Reproduction
Live Reproduction
Steps to reproduce the behavior:

Try dragging the card
See error

Expected behavior
Expected monitor.getDifferenceFromInitialOffset() to return the { x, y } difference between the last recorded client offset of the pointer and the client offset when the current drag operation has started.
Screenshots

Desktop

OS: Windows 10 x64
Browser: Chrome
Version: 83

This specifically seems to be an issue when calling monitor.getDifferenceFromInitialOffset(); from a DragSpec's end method. It works as intended when called from a DropSpec's drop method. As a workaround, you can include the monitor.getDifferenceFromInitialOffset(); as part of the dropResult returned from drop, then use monitor.getDropResult() to retreive it. Demonstrated in a modification to your live example: https://codesandbox.io/s/red-silence-9c5xl?file=/src/App.js
I would really like this method to work in the DragSpec so that I can depend on this behavior without having to attach a DropSpec to target divs; my use case is to allow use to drop this particular item anywhere on the screen without coupling it to any particular dropzone.

Still no other workarounds ?


Feature/30162 - Edit 'paragraph' component

Add view for styled paragraphs in component

https://dev.snowdog.pro/issues/30162

Test are not passing.


Merge response from embed operation with querystring params

QueryString params have priority

The custom map data should send everything.


CSS problem for Infobox: class-modalgialog

I have no problem on master, but I have seen that on your branch, using the config css https://github.com/geoadmin/web-emapis/pull/21

Seems fixed on @pfanguin branch can yu confirm @kandre ?

Yes it seems fixed


Climo year grab fails for non cam.h0 files

ADF run type
Model vs. Model
What happened?
This line relies on the standard cam.h0 format, and fails for other files (eg. $case.cam.h2.0021-05-01-00000.nc)

case_climo_yrs_str = sorted(np.unique([i.stem[-7:-3] for i in files_list]))

ADF Hash you are using
b12f7c4
What machine were you running the ADF on?
CISL machine
What python environment were you using?
NPL (CISL machines only)
Extra info
I'm happy to help debug

Closed with #275


no need to write timestamp and nonce in op_return

This significantly reduces the fee rate of the reveal transaction compared to the expected amount.

Without the op_return data, can we genrate a revealtx match mint_bitworkr prefix?

Without the op_return data, can we genrate a revealtx match mint_bitworkr prefix?

of course, a revealtx matched the mint_bitworkr prefix is needed. but we don't have to write the calculation in op_return, it is a huge waste.


storage: precreate VirtioBlk8

Fixes #255
Signed-off-by: Steven Royer<EMAIL_ADDRESS>

I would fix this differently instead of pre-creating vhost controller just move the delete function in client to be last here https://github.com/opiproject/opi-poc/blob/main/storage/client/frontend.go#L119

Ok, that was my other thought.  I'll try that instead.


Code throws exception but task status is not set to “failed”

Issue description: Code throws exception (not caught) and exists with error, but task status changes to “completed”, instead of “failed”.
Expected behavior: I expect the status to be changed to “failed”.
Environment: Windows 10, python==3.6.7, tensorflow==1.10.0

Thanks, the bug was verified on v0.9.1
Fix is already pushed to the master branch, and is part of the next release.
Please feel free to verify the bugfix with the latest release candidate:
pip install trains==0.9.2rc0

Thanks for the fast fix !
It works fine with trains==0.9.2rc0


fp16 c++ support example

fp32 inference is slow for my project.
I want to use fp16 to speed in c++ project.
I cannt find fp16 c++ client example in git and c++ seems not to support fp16 directly.
Where can I get fp16 c++ client exmaple? Thx

For the reasons you mention, even if a model uses fp16 internally it will usually still use fp32 for input and output tensors since those have a standard representation. If you use TensorRT to create an fp16 version of your model, or perhaps the ONNX/TensorRT or TF/TensorRT integration describe in the documentation you may get some automatic FP16 optimization of your model without having to use fp16 inputs/outputs.

We have more models in triton inference server currently and alomost tensorflow_graphdef/tensorflow_savedmodel.  Our client codes just like the simple_client.cc with git. We want to speed up our models inference. I just tried to modify the batchsize(for our unet model speed unuseful and resnet speed OK). How should I try to change our client for speed? (change all  models to TensorRT model and client inference API needs to change too? Or refactor our code like perf_client? perf_client seems to benifit from the sync/batching/schecdule? )


Firebase Messaging plugin: 'onLaunch' never called with "Don't keep activities" on Android

Hello,
I have noticed a bug when the "Don't keep activities" toggle is on (in the Developer Options) or the main Activity is killed by Android.
In that case, when the user clicks on the notification, the event won't be forwarded in the onLaunch method in the Dart code.
The reason of this, is that the onNewIntent method is called, but the Dart side is not yet ready.
When the configure is finally called, a wrong Intent is used (action = android.intent.action.RUN), instead of the one called by the notification.
A fix for this would be to call in the onNewIntent:
  registrar.activity().setIntent(intent);

Seems the linked PR (merged) is supposed to fix this issue.
Thanks a lot for your contribution 👍

I have the same problem. Not clear how to fix. Could you explain ?


Ajax display message

i want to see a message from ajax request.
In ajax request i set a message or info to display in debugbar but it will not appeare.
how i can do that?
In debug bar I can't see ajax request.
Thanks in advantage

click the folder icon on the right, you will see it in the request list.

i have tried it, but nothing appear, is empty.
'capture_ajax' => true,
and json is correctly created (i have checked it)
'path' => APP_PATH.'/apps/Runtime/debugbar',

i have tried it, but nothing appear, is empty.
'capture_ajax' => true,
and json is correctly created (i have checked it)
'path' => APP_PATH.'/apps/Runtime/debugbar',
the problem is:
if i call directly http://jms-azienda.dev/_debugbar/open?max=20&offset=0
works
if i click on folder the page was not found
$eventsManager->attach(
        'dispatch:beforeDispatch',
        new \App\Core\Plugins\DebugBarPlugin()
    );

public function beforeDispatch(Event $event, Dispatcher $dispatcher)
    {
        /* Debugbar start */
        $ns = $dispatcher->getNamespaceName();
        // var_dump($ns); die;
        if ($ns == 'Snowair\Debugbar\Controllers') {
            return true;
        }
        /* Debugbar end */
    }

in ajax $ns = 'App\Frontend\Controllers'
I have multi module

ok, thanks :)

can i capture ajax request after the page is load?
e.g. when i save form in ajax with content-type application/json

yes

how? is always empty after form submit in ajax


Custom Dataset Preparation

Hi @JiantengChen ,
Thanks for your awesome work. I want to work on a custom dataset for reconstruction. So I am wondering how to convert the Pandaset dataset into the format which your mentioned here
Any assistance is greatly appreciated.

Hi! @VikasXitadel
Thanks for your interest in our work. I suggest writing a new dataparser for PandaSet as there is a devkit for data processing.


Ignore detected block sizes in cdrom provider

A backport of https://github.com/linuxkit/linuxkit/pull/3614

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

LGTM


[Nerdpack] Instrumentation & Dashboard

Description
As part of production readiness, we will want to instrument page views and key interactions. Additionally, we should create a dashboard to view this information
We can setup a technical support focused dashboard for alerts, and trouble shooting data. Business / usage data can be sent to the existing  catalog dashboard:
Acceptance Criteria

[x] decide on where / when to use tessen or browser agent.

We would like to instrument the following:

[x] Page view for observability pack details
[ ] Page view for install nerdlet
[x] Clicks on the install button
[ ] Clicks to view the repository
[ ] Errors

This information should be surface in a dashboard:

[x] Views by Observability Pack
[ ] Recent Errors
[ ] Install button clicks by Obserability Pack (externally)
[x] Install button clicks by Obserability Pack (internally)
[ ] View repository clicks by Observability Pack

Additional charts on the dashboard may be requested by stakeholders.

We'll want to define what dashboard we'll be using for this, so it's 1 single view into olly pack data

@zstix we're unsure about how we want to track errors. It doesn't look like tessen is used to track them in the catalog and the two methods we have are trackUserAction and trackPageView, neither of which really fit an error. should we use one of those anyway? the catalog is using some error tracking that is a bit out of date but we can research how best to track errors on the platform


Disable participant animation for more stable snapshot

What

Disable participant animation for more stable snapshot generating
Why

How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Very smart @PorterNan


Added POSTGRES_DB variable to optionally specify DB name

POSTGRESS_DB defaults to POSTGRESS_USER if it's not specified.
Example run
docker run -d --name postgres -e POSTGRES_DB=testdb -e POSTGRES_USER=postgres -e POSTGRES_PASSWORD=password postgres

You can also connect to the db with
docker run --rm -it --name dbconnect --link postgres:db postgres sh -c 'exec psql -h "$DB_PORT_5432_TCP_ADDR" -p "$DB_PORT_5432_TCP_PORT" -d testdb -U postgres'

It seems that all but 8.4 got spaces instead of tabs on the : ${POSTGRES_DB:=$POSTGRES_USER} line; they should all be tabs like the rest of the lines.  Other than that, this seems solid.

Sorry about that. I wasn't showing tab characters so I didn't notice.
I just retabed all the files so they should have consistent formatting now.

LGTM
What do you think @tianon?

Doesn't the logic down below this need to change too?
 		gosu postgres postgres --single -jE <<-EOSQL
 			$op USER "$POSTGRES_USER" WITH SUPERUSER $pass ;
 		EOSQL

I'm +1 in general; I think this is a reasonable change.

I fixed the missed variable in 9.1 and the template
@tianon Because there's only one db and one user I don't know if the logic needs to change. It worked in my test containers (specifying combinations of POSTGRES_USER, POSTGRES_DB, or none at all) by logging into the db with another container (see test above). But I'm not very familiar with postgres in general so there may be a better way.

Looks like the template is missing the change on the CREATE DATABASE line.
@tianon I don't see why the user creation/update would need to change.  It will still have access to whatever database is created.

@yosifkit fixed the template. Sorry, was doing that in a rush and didn't check everything.

It's all good. LGTM
ping @tianon

Can you confirm that all the following combinations work?

POSTGRES_USER=postgres, POSTGRES_DB=postgres
POSTGRES_USER=postgres, POSTGRES_DB=testdb
POSTGRES_USER=testuser, POSTGRES_DB=postgres
POSTGRES_USER=testuser, POSTGRES_DB=testdb

I just want to make sure we're covering our bases.
The change LGTM, but I'll feel better about merging if you can confirm you've tested all four possible permutations of these two interacting before we merge.

It would be awesome to see those in the tests in official-images :)

I had to add another check to make sure the user was altered or created properly, but now all of these check out.

:heavy_check_mark:POSTGRES_USER=postgres, POSTGRES_DB=postgres
:heavy_check_mark:POSTGRES_USER=postgres, POSTGRES_DB=testdb
:heavy_check_mark:POSTGRES_USER=testuser, POSTGRES_DB=postgres
:heavy_check_mark:POSTGRES_USER=testuser, POSTGRES_DB=testdb
:heavy_check_mark:POSTGRES_DB=testdb

It might not be ideal that the postgres database still exists no matter if you specify POSTGRES_DB to be something different or not. I could add DROP DATABASE IF EXISTS postgres if the user specifies a database but I'm not sure that would matter.

LGTM

LGTM

Is it possible to create multiple databases at startup?
docker-compose.yml
db:
    image: postgres
    environment:
        - POSTGRES_DB=db1
        - POSTGRES_DB=db2
        - POSTGRES_USER=user
        - POSTGRES_PASSWORD=pwd
        - POSTGRES_ROOT_PASSWORD=rootpwd

@maslickm, not with this environment variable, but you could add a simple sql script into /docker-entrypoint-initdb.d/ and it will be run just after initial database/user creation.


Fix driver always downloading (#236)

Add extra check to see if a driver already exists.
fix #236

The issue is upstream. Closing.


READONLY_MODE does not appear to send reads to read replicas.

I'm trying to balance reads across a shard, which is supported in Redis Cluster via the READONLY command. This library appears to have that included via readonly_mode. However, turning on the setting when connecting to a cluster doesn't appear to ever connect to the slave even over a few thousand calls, as measured by GET traffic on all the nodes in the shard. A colleague at a major cloud provider also observed this. Is this expected behavior, or are we doing something wrong?
Of note:

I'm using AWS' Elasticache
Other libraries with this mode enabled (specifically Lettuce for Java) do send traffic to read replicas.
This library (redis-py-cluster) does fine when detecting failovers and moving traffic to the new master, as well as live cluster shard addition and removal.

Here is the script I'm using to test this:
from rediscluster import StrictRedisCluster

hostname = "[my cluster]"

def connectToClusterAndGetStuff(i_max=100):
    startup_nodes = [{"host": hostname, "port": "6379"}]
    rc = StrictRedisCluster(startup_nodes=startup_nodes, **readonly_mode=True**, decode_responses=True, skip_full_coverage_check=True)
    for i in range(0, i_max):
        rc.get(i)

for i in range(0, 1000):
    connectToClusterAndGetStuff()

Hi. There is basically a confusion between the difference between readonly in the traditional sense that is redis-py where readonly mode would prohibit the client from sending commands or if it is the server rejecting commands, and the readreplica feature that cluster users want. The connection pool class that is used when readonly_mode=True is set was a copy of the same class that existed in redis-py. The intent of it was to mimic the same behaviour as redis-py offered. There is no feature inside redis-py-cluster today that has this readreplica feature. It is something that i want to do, but never got enough time to complete any work for it.

Thank you for the quick reply. Make sense, explanation is appreciated.

I've put together a sketch of how I could see this working: https://github.com/Grokzen/redis-py-cluster/pull/271

I will close this issue now, and defer this feature that you make in #271 into the issue in #249 as that issue is more descriptive of the real problem and the solution/implementation that you are going for.


Captive Portal does not restart correctly

Clicking on the resort button in the Status:Captive Portal page does not force a correct restart.

by clicking on the Restart button the service stops. -> Icon with green Arrow turns red.
I need to click at the grey arrow to bring the service up

Fixed. :)


Add Prisma schema migration support

https://cockroachlabs.atlassian.net/browse/DOC-3704

This change is

We could actually link to this page, which actually does incorporate Prisma Migrate.

@kernfeld-cockroach I think that tutorial is already linked in the first mention of Prisma


getStatements with attachments

getStatements always expects JSON back in the response, even for when using the attachments query. Is it worth discussing this a bit more to have it parse out the statement and do something with the attachments?

The user / team requesting statement attachments will be most familiar with decoding the specific file-type that statement should've had attached.  We can look into it down the road, but for now it feels like a pretty heavy lift to account for any generic file that may have been attached and how to decode them.
The wrapper currently conforms to the Spec, but does leave room for improvement as you pointed out.


chore: update the readme with badges

Adding badges to the README

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.96%.  Consider uploading reports for the commit d992925 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   96.96%   96.96%
=======================================
  Files          15       15
  Lines         462      462
=======================================
  Hits          448      448
  Misses         14       14

Flag
Coverage Δ

unittests
96.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[#830] Clarify channel type in docs for Running the App

Summary
In issue #830, a developer tried to DM the bot and didn't
receive a response because the 'message.im' event was not used.
This tutorial only uses 'message.channels', so the bot must be
invited to a public channel to receive the "start" message.
This commit clarifies that the bot must be invited to a public channel.
Category (place an x in each of the [ ])

[ ] slack.web.WebClient (Web API client)
[ ] slack.webhook.WebhookClient (Incoming Webhook, response_url sender)
[ ] slack.web.classes (UI component builders)
[ ] slack.rtm.RTMClient (RTM client)
[x] Documents
[ ] Others

Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run python setup.py validate after making the changes.

@mwbrooks Thanks for improving this! LGTM. Can you make the same PR for the v3 branch?

@seratch can do! Just sent a PR for the v3 docs as #832


The command opens Firefox, and Firefox reports that it can't access the file, because on Ubuntu 22.04, Firefox is now a snap package, and thus runs in a sandbox without access to /tmp.
What did you expect to see?
I expected to see the coverage report displayed in the browser.
The coverage report HTML file should be put in the user's tmp directory.  If it doesn't exist, the user should be prompted to create it.  In addition, there should be an environment variable to override the location, and this should be documented for go tool cover

cc @thanm

Thanks for the report @jlearman .
I note that this seems to work for me:
$ TMPDIR=/x/y/z go tool cover -html=foo.p
$

Is this an option for your workflow?

Related Issues and Documentation

cmd/go: go 1.22.0: go test throws errors when processing folders not listed in coverpkg argument #65653 (closed)
cmd/cover: support -mod and other build flags #35869
cmd/go: `-x` output with `test -cover` contains wrong path for some files under cwd #23982 (closed)
cmd/cover: ignores os.Create error #17951 (closed)
cmd/go: test / tool cover: uncomfortable colors on html page with coverage results #37796 (closed)
cmd/go: test -coverpkg=./... fails to change working directory #33016 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Thanks for the report @jlearman .
I note that this seems to work for me:
$ TMPDIR=/x/y/z go tool cover -html=foo.p
$

Is this an option for your workflow?

Thanks.  My workaround was to reinstall Firefox without snap, so this isn't an issue for me.

OK.  It doesn't look as though there are any changes needed to Go here, closing out this issue.

I disagree.  You should fix the tool to actually work on a typical Linux distribution, like Ubuntu.  Go shouldn't force many users to use some strange workaround in order to use a normal tool.

Setting TMPDIR is very standard on Unix systems.  I'm surprised that Ubuntu is shipping an approach that does not permit access to /tmp and also does not set TMPDIR.  How do they expect programs to find the temporary directory to use?

It's also raised as a snapd issue (plus the issue that Ubuntu decided to switch Firefox from apt to snap -- and if you install using apt you still get the snap.)
See https://bugs.launchpad.net/snapd/+bug/1972762 for a snapd issue.  There are many reports of problems with snap Firefox dating back to 2022, but it doesn't look like they'll be fixed.

From Go's point of view I have no idea what we can do to avoid this problem.

One solution would be to not use /tmp -- instead use $HOME/tmp (and if it doesn't exist, prompt the user.)
Another option would be to document the issue (possibly adding it to -help output) with suggestions such as setting TMPDIR, for cases where the browser can't access /tmp.  For exampe:

In cases where browsers can't access system temporary directories such as /tmp on Linux, set the TMPDIR environment variable to an alternate location.


Timesheet - 2/12/2021 - Kristy Lee

Task 1
Interview with Chris
Proof of Work

Private call

Time Spent
1 hours

Task 2
Roadmap meeting
Proof of Work

Private call

Time Spent
3.5 hours

Total Time Spent
4.5 hours
Account Number
a2d73cf3b37a62276ade44a96860495510d0e7d7c468950d4e49ac8a62b3d31d

Hey @kristykjlee, for some reason our automated payment script is unable to process the payment for this timesheet. So I am making a few changes here to figure out what is the issue. Your Total Time Spent on this timesheet is 4.5 hours.
Thankyou


Contributing Guide: Language-specific additions to README

https://github.com/exercism/x-common/blob/master/CONTRIBUTING.md#updating-language-specific-additions
Write about SETUP.md ties into README.

Added in 31bfcba66a1d30cbb968c74c8568dad1efb766a9


Travis: Update bundler before installing gems

Some versions of bundler are affected by a bug that causes them to throw
NoMethodError: undefined method `spec' for nil:NilClass

during installation of the yaml_db gem. This bug was fixed in bundler@a0c90cd, but several of
Travis's Ruby environments are based on older affected versions. To resolve, we force an update.

Fixed in #328


Fix attribute_changed? deprecation warning

Fix attribute_changed? deprecation warning

Pull Request Test Coverage Report for Build 655

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 95.837%

Totals

Change from base Build 649:
0.01%

Covered Lines:
1197

Relevant Lines:
1249

💛  - Coveralls


camel-metrics component Asciidoc documentation

Hi Antonin, many thanks :-)
The PR has been merged. Can you close it? :-)

Hi Andrea! Closing :)

Thanks :-)
This will be a great work, but we are doing very well :-) Many thanks for the help :-)


loading data in data/values

I am trying to do something like the following.
#@ load("@ytt:data", "data")
#@ load("@ytt:overlay", "overlay")
#@data/values
---
registry:
  username: #@ data.values.tanzunet_username
  password: #@ data.values.tanzunet_password

Of course I have another data yaml file that defines data.values.tanzunet_username but i fail with the following.
  Templating file 'acc-data-values.yaml':
- struct has no .tanzunet_username field or method
    in <toplevel>
      acc-data-values.yaml:9 |   username: #@ data.values.tanzunet_username

I am guessing you cannot load("@ytt:data", "data") in a data file, but is this correct and is there any workaround ?

I've hit the same block - would appreciate any comment on this.

Hi @groundnuty 👋

I am guessing you cannot load("@ytt:data", "data") in a data file, but is this correct and is there any workaround ?

You are correct, since you have a data values annotation, #@data/values, in the same file that you are referencing other data values, #@ data.values.tanzunet_username, ytt will error.
This issue, and a work around has been discussed in a previous thread: https://github.com/vmware-tanzu/carvel-ytt/issues/459
so I am marking this issue as duplicate, and closing. Please reopen and comment if you have any additional questions or  if that work around does not work for you. Thank you!


Remove application@label attribute from Android manifest

Suggestion for a fix of issue #5 .

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks

https://go.shr.lc/3V5QCN1

https://go.shr.lc/3V5QCN1

www.samsung.com


MIP102c2-SP34 amendment (article 1 edits)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Set option warnings as errors to false #2046

Temp fix for #2046

If you need a temporary fix then you can add -DWARNINGS_AS_ERRORS=OFF to your CMake configuration command. That's why we make that an option.

Then I think I misunderstood. You want me to fix the deprecations itself instead?

Then I think I misunderstood. You want me to fix the deprecations itself instead?

No, you don't need to bother with that. First we need a CI job which uses the compiler in question. We can disable warnings as errors (via the above mentioned CMake option) for that specific CI job so that CI still passes.


Sort client listing by active (seen in < 60 s) first

Closes #490

Job python3 Selenium Test on 9fa4bf5 : invalidated by @milljm


add post handler for 911 game script

Added the check and tested.

Added the check and tested.

Alright, will check out the updated code when back from school.

Alright, will check out the updated code when back from school.


GitHub Actions: remove PublishReadyToRun for non-linux targets

Remove PublishReadyToRun for non-linux publish targets because that feature has some restrictions on cross-platform compilation https://docs.microsoft.com/en-us/dotnet/core/deploying/ready-to-run#cross-platformarchitecture-restrictions
Note: there are workarounds, but they're fairly convoluted and would entail giving up the automated draft release creation - so: no, sorry, Mac/Windows users.

solved by #67


Remove the unused github-contributors-list

@kristerkari if you want to add a script instead of removing the devDependency that's OK. But currently it's moot having it :) Also the current contributors are not up to date AFAICT.

Thanks, I decided to add the script for now. It's still a half manual process, since I need to copy/paste the html that it generates.


change to use graphql api

to prevent using so many api requests this should be changed to use the GitHub GraphQL api.
guide here: https://developer.github.com/v4/guides/forming-calls/
explorer here: https://developer.github.com/v4/explorer/
reply dibs here to make this yours :)

I'll take a shot at this over the next few days

awesome thanks :)

X-hubber here who built the GQL APIs. 👋:octocat:
It's worth noting that you'll still need a mix of REST and GQL API calls to accomplish everything this tool needs to do.
A lot of your basic data fetches (repositories, organizations, team members, etc.) will be easy to convert and far less chatty through the GraphQL interface, but unfortunately the public version of the GQL API still does not have feature parity with the REST API.
Things like repository web-hooks,  protected branch details and team permissions for a given repo are still not yet available through the GQL interface.

Feature
GQL Support
REST Support
Notes

List Repositories
✅
✅

List Organizations
✅
✅

List Deploy Keys
✅
✅

List Branches
✅
✅

List Teams
🚫
✅
Team relationships to repos are available through Organization.teams and Team.repositories. However, you can't currently team repo permissions (eg. admin, read, write).

List Protected Branches
🚫
✅
The GQL interface exposes boolean flags indicating what parts of branch protection have been enabled for each branch, but you can't see the details of each rule.

List Web Hooks
🚫
✅
The GQL interface exposes boolean flags indicating what parts of branch protection have been enabled for each branch, but you can't see the details of each rule.

@brblck Ha, that's where I was struggling.
Introspecting the schema, it is evident that Teams and Webhooks are not there. But protected branches, introspection says that it's available, but the response is always null:
      "protectedBranches": {
        "totalCount": 2,
        "nodes": [
          null,
          null
        ]
      },

The repo queried above has two protected branches, but the details return as null. I was trying to figure out if the issue is due to my token permissions.

One more thing to note is that collaborators can only be listed if the user has push access to the repo. So, if we query for all repositories the user has access to, some may return forbidden.

Saw someone posted a small tip on this so decided to just increase the funding amount to the ~$200 USD offered by @jessfraz :)
@JJJollyjim or @shahidhk feel free to claim it once the PR is in!

@shahidhk there's also $200 on the gitcoin bounty above. If you sign up there you can submit your work and I'll release the bounty to you.

@ngauthier Thanks for the offer. I am not familiar with the Ethereum network. Trying to get it work :rofl:

Yeah it's certainly a lot of steps and security 😄

Hey @shahidhk feel free to reach out to me at<EMAIL_ADDRESS>if you have any questions :)

Thanks @ceresstation. Sent you an email.

@ngauthier, thanks to @ceresstation, I have submitted the work on Gitcoin


external_bar and native-fullscreen

Is the external_bar option supposed work on spaces that have windows in native-fullscreen? The wiki does not have any indication that external_bar applies only to spaces in which windows are either not fullscreen or are in zoom-fullscreen mode.
This is what I'm trying to achieve - for my most frequently used apps, I use one space per app with each window in native-fullscreen mode. I want simple-bar to be visible at the bottom of each space, but currently it looks like this is not possible unless I use the windows in zoom-fullscreen. Is this correct? I am using v.3.3.8

This is a restriction in macOS. When an application is in native-fullscreen space, the size is controlled by macOS and we have no way to say that we want to leave empty space as padding.
In general, it is not possible to show other applications/windows on a native-fullscreen space. Technically, there is a way to do this and the bar that used to be built into yabai (v2.x.x) did this, but I doubt simple-bar supports it as it utilizes Übersicht.
Regardless, a native-fullscreen space is not something that we have control over.

Thank you for the confirmation! It would be great to have it clarified in the Wiki as well.


Switch to container-based Travis CI infrastructure

This gets us off the legacy build system, which means
that the builds will start more quickly and also likely
run more quickly (and with more consistent build times).
See https://docs.travis-ci.com/user/migrating-from-legacy.

Why are the travis CI builds failing with this change?

The previous build is also failing, and that was a change to a text file.
Could a change on Travis' side have changed anything? I know they changed something with regard to the legacy platform a few weeks ago: https://blog.travis-ci.com/2015-11-27-moving-to-a-more-elastic-future

According to https://docs.travis-ci.com/user/languages/cpp:

Travis CI VMs are 64-bit and provide versions of:
[...]
core GNU build toolchain (autotools, make), cmake, scons

Seems like it should be there.

By turning sudo off, you're preventing these commands from working:
before_install:
- sudo add-apt-repository -y ppa:kalakris/cmake
- sudo add-apt-repository -y ppa:boost-latest/ppa
- sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
- sudo apt-get -qq -d update

By default the travis image doesn't have cmake, boost or a C++11 compatible gcc, which is why I had to install these packages before running the build.

Also, I'm not seeing any failed builds except the one for your pull request.
Were you looking here?

OK, so they now have cmake, which is new.  However, I couldn't find anything stating what version of gcc/clang they have in their image.

From the last passing build:
$ gcc --version
gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3

so we will need to keep sudo in order to install a more recent version of gcc.

Ah, ok, that makes sense. Thanks for digging.
I was looking at the other open pull request. Not sure what's going on there though.

The other open pull request is related to making things play nice on Mac based on certain versions of OS and Xcode.  More investigation is needed to determine a solution that works everywhere and not just for that specific case.


Allow search by UniProt keyword

It would be a useful feature to be able to search by a UniProt keyword. The action taken on successful search needs discussion, but we might direct the user to the batch search for all targets linked to the keyword.
Example: User types Acetylation or KW-0007.
This would require some work on the rest_api.

This issue has been closed as it has been captured on the Master Feature Prioritisation worksheet available on the team's Google Drive.
CC: @d0choa


Refactor exception catching to use catch-when

I was debugging some code and realized we can refactor our code to use the C#6 catch-when feature to improve our experience a little bit.
Take a look for example at https://github.com/aspnet/EntityFramework/blob/dev/src/EFCore.SqlServer/Storage/Internal/SqlServerExecutionStrategy.cs#L28.
try
{
    return operation(state);
}
catch (Exception ex)
{
    if (ExecutionStrategy.CallOnWrappedException(ex, SqlServerTransientExceptionDetector.ShouldRetryOn))
    {
        throw new InvalidOperationException(SqlServerStrings.TransientExceptionDetected, ex);
    }

    throw;
}

This means that when operation throws an exception that doesn't match the condition, our code will break on the throw; line and we'll have to find where the real exception was thrown.
This would be functionally equivalent and provide a better debugging experience:
try
{
    return operation(state);
}
catch (Exception ex) when (ExecutionStrategy.CallOnWrappedException(ex, SqlServerTransientExceptionDetector.ShouldRetryOn))
{
    throw new InvalidOperationException(SqlServerStrings.TransientExceptionDetected, ex);
}

It might be worth looking into other places where this can be done.

This is also cool about exception filters: http://stackoverflow.com/a/38498087/625581


Add block info support to EE and Casper VM (#4853)

This PR adds block info support to the ExecutionEngine and Casper VM. Wasm based logic can request the following fields via a new ffi method directly:
/// This function gets the requested field at `field_idx`. It is up to
/// the caller to ensure that the correct number of bytes for the field data
/// are allocated at `dest_ptr`, otherwise data corruption in the wasm memory may occur.
///
/// # Arguments
///
/// * `field_idx` - what info field is requested?
///     0 => block time (functionally equivalent to earlier get_blocktime ffi)
///     1 => block height
///     2 => parent block hash
///     3 => state hash
/// * `dest_ptr` => pointer in wasm memory where to write the result
pub fn casper_get_block_info(field_idx: u8, dest_ptr: *const u8);

Alternately, the following convenience methods in the contract api offer easy access to each of the four fields, handling the ffi interactions for the user:

get_blocktime() -> BlockTime (pre-existing)
get_block_height() -> u64
get_parent_block_hash() -> Digest
get_state_hash() -> Digest

This new mechanism is extensible, and we may add more fields in future releases.

bors r+

Some minor nits around new lines being added

So...all the original ffi function index hooks were spaced, and just the last handful added recently were not so I spaced them to be consistent with the majority / original match arms. ¯_(ツ)_/¯

Relates to #4853


fix/48: clean up code

use go syntax instead of tmp variables
In the question, the length of the matrix is equal to the width

note：
matrix.length == n
matrix[i].length == n

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@851946d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #133   +/-   ##
=========================================
  Coverage          ?   71.90%
=========================================
  Files             ?      681
  Lines             ?    12058
  Branches          ?        0
=========================================
  Hits              ?     8670
  Misses            ?     3078
  Partials          ?      310

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851946d...bb50f33. Read the comment docs.


Using MapDynamicControllerRoute("{**path}") throws NullReferenceException:

I've attached a test project:
https://github.com/alienwareone/DynamicEndpointRoutingApiVersioningBug
System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.AspNetCore.Mvc.Routing.ApiVersionMatcherPolicy.TrySelectApiVersion(HttpContext httpContext, CandidateSet candidates)
   at Microsoft.AspNetCore.Mvc.Routing.ApiVersionMatcherPolicy.ApplyAsync(HttpContext httpContext, CandidateSet candidates)
   at Microsoft.AspNetCore.Routing.Matching.DfaMatcher.SelectEndpointWithPoliciesAsync(HttpContext httpContext, IEndpointSelectorPolicy[] policies, CandidateSet candidateSet)
   at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.<Invoke>g__AwaitMatch|8_1(EndpointRoutingMiddleware middleware, HttpContext httpContext, Task matchTask)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

This is a duplicate of #600. I have a large number of fixes in the works. The will be included in the next patch version. The fix is pretty straight forward - fortunately. Thanks.

This issue has now been fixed in 5.0.0-RC.1. The official release will likely occur after 2 weeks of burn-in. If that doesn't fix the issue, feel free to reopen this issue or open a new one. Thanks.


[CP] Warn about old-style cache

Commit(s) to merge
https://github.com/dart-lang/pub/pull/3921
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/305981
Issue Description
In dart 3.0 Pub on Windows stopped reading caches in C:\Users<user>\AppData\Roaming\Pub\Cache (in favor of C:\Users<user>\AppData\Local\Pub\Cache).
These have not been created by pub since dart 2.8, but have been used if existing until and including 2.19.
This has lead to some amount of confusion for users with an old cache. Especially if they had a %PATH% pointing to the old location, then they would invoke old binstubs of globally activated packages.
What is the fix
We detect the presence of the old cache, and print a warning, and instructions for how to proceed.
Why cherry-pick
It could help guide users to find the new cache.
Risk
low
Issue link(s)
https://github.com/dart-lang/sdk/issues/52386
Extra Info
No response

@sigurdm is the warning the only change in pub in the new version compared to the current pinned version?

yes - unless I made a mistake it should be a true cherry pick of the warning


Voice 'Ryan' has incorrect data structure

Voice(voice_id='wViXBPUzp2ZZixB1xQuM', name='Ryan', category='premade', description=None, labels={'age': 'middle aged', 'description': 'soldier', 'gender': 'male', 'use case': 'audiobook', 'accent ': 'american'}, samples=None, settings=VoiceSettings(stability=0.5, similarity_boost=0.75), design=None, preview_url='https://storage.googleapis.com/eleven-public-prod/premade/voices/wViXBPUzp2ZZixB1xQuM/76ddbbc2-ee59-4e8c-91e7-a6dc460ce7da.mp3')

It is 'accent ' (with an extra space) instead of 'accent'.

Thanks, this is fixed now.


Add poofOff to config

Another export that should be present in config to allow consistency between restarts. I set it to false by default.

Config.poofOff is a boolean not a string. Also you don't need to define it because it is already undefined aka a falsy value by default.

Oh i see. lmao read that wrong


How to pin to the Ubuntu dash without duplication?

System information:

Ubuntu 20.04
DBeaver Enterprise 7.0.0 (installed via the .deb from the official website)

Describe your question:
Is it possible to pin DBeaver in the Ubuntu dash correctly like other applications?

The dbeaver-ce snap package doesn't have this issue: https://snapcraft.io/dbeaver-ce

This issue is still there in the DBeaverEE 7.1.0 Early Access from:
https://dbeaver.com/files/ea/

😭

It seems that there is a disinterest for Linux, as usual. Even the PPA is dead.
It's a very sad thing, but I can understand it.

is it possible that you pinned the application before it was fully opened? try to unpin it, open it, and then pin it when it's fully opened (not during splash screen for instance).
It's a common issue for java applications, even on windows.
As for the support, distributions often offer packages that might be slightly out of date, but I believe deb and rpm are always available on the download page. Also, not using ubuntu but looks like official ppa is very up to date with 7.2.3 https://launchpad.net/~serge-rider/+archive/ubuntu/dbeaver-ce

As mentioned before, the bug is not related to the community version, but to the paid enterprise version.

It should works now if you use Wayland as default.
However you'll get this weird close icon.

You can fix this by using xwayland for dbeaver like this.
export GDK_BACKEND=x11 && /usr/share/dbeaver/dbeaver

But you will have the same problem as previously aka duplication.


The WhatsApp button goes behind and is inaccessible in mobile viewport

The WhatsApp button goes behind and is inaccessible in mobile viewport. Please allow me to fix this issue under Hacktoberfest23

@avinash201199 : Can I work on this issue?
-- @Avilash-Saha

This issue seems fixed, can be closed. @avinash201199


🔥 [$500] Fix offline distance requests

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go offline
Click the green plus, request money, distance
Enter a valid address for start and finish waypoints
Verify that you can click next
Select a workspace
Verify that all information shows or is TBD
Click request
Verify that the report preview shows a pending receipt image
Click the report preview
Verify that the request shows as distance, with the amount and miles as TBD
Click on the request
Verify that the request shows as distance, with the amount and miles as TBD
Go online
Verify that all pending data fills

Expected Result:
All verifications pass
Actual Result:
The first verification step fails
Workaround:
Create requests online only
Platforms:

Which of our officially supported platforms is this issue occurring on?
All

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.74-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://github.com/Expensify/App/assets/26260477/146a1ef9-f182-4ccf-92a7-4deda2fa6825
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695786405195339
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a10d251bbc7f89f6
Upwork Job ID:<PHONE_NUMBER>997462528
Last Price Increase: 2023-09-27

I'm going to push a quick fix to enable the next button, then we should fix the rest externally.

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

I'm going to push a quick fix to enable the next button, then we should fix the rest externally.

Is this regression from https://github.com/Expensify/App/pull/27989?

I confirm that after @neil-marcellini's fix #28292 all verifications are passing and also all pending data fills upon getting back online but only if step 5. Select a workspace is performed by selecting a workspace from the Recents suggestions.
If another participant is selected by email address instead of selecting a workspace from recents suggestions, then upon getting back online, the CreateDistanceRequest call errors with message Report no longer exists which makes the conversation dissappear and errors with Hmm... it's not here screen.
Can someone please update the Expected result for this issue if one is still needed ?

We already fixed verification #4. I think verification steps from 10 and 12 are failing. Please submit proposals for that.

This bug seems like a separate problem. It should only be possible to select a single workspace right now. Please report that separately.

Why is this issue a deploy blocker. Please add context when applying the label. From what i see the issue here occurs in production so there is no reason this should be a blocker. Additionally, remember to handle deploy blockers in an hourly manner (or at least finish them within a day), this issue has been a blocker for 2 days now.

I did a quick test on staging and i think the issue is resolved. I'm going to clear the deployblocker label.

Also i tested on production to compare.

The first verification step fails

What is the first verification? Once i came online everything seemed to look fine for me. In terms of API i just see CreateDistanceRequest and that succeeds just fine for me once i got back online.

The 3 loading report actions on the top look odd to me but other than that everything seems to look fine.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The Distance request created offline is not treated as a distance request, but as manual.
What is the root cause of that problem?
The reason for this is that we define the MoneyRequest as Distance here:
https://github.com/Expensify/App/blob/71c6450ae653a35f0b7411a116a4a08fd844dbdf/src/components/ReportActionItem/MoneyRequestPreview.js#L166
We do it based on the transaction.comment, which on the optimistic phase contains only request description and waypoints:
https://github.com/Expensify/App/blob/ad21933c05ab73283874e81d3c84cbdda4c79d1f/src/libs/TransactionUtils.js#L326-L330
What changes do you think we should make in order to solve the problem?
We should determine if the transaction is a distance request based on the waypoints presence, not on comment.type (I have made it an early return because I didn't have enough time to check if we can fully replace the logic here or we should just use the early return):
function isDistanceRequest(transaction) {
+    if (hasWaypoints(transaction)) {
+        return true;
+    }

    const type = lodashGet(transaction, 'comment.type');
    const customUnitName = lodashGet(transaction, 'comment.customUnit.name');
    return type === CONST.TRANSACTION.TYPE.CUSTOM_UNIT && customUnitName === CONST.CUSTOM_UNITS.NAME_DISTANCE;
}

Result:
https://github.com/Expensify/App/assets/12595293/318f4d6a-3999-47b6-8f37-f25c1a04a12b
What alternative solutions did you explore? (Optional)

Why is this issue a deploy blocker. Please add context when applying the label. From what i see the issue here occurs in production so there is no reason this should be a blocker.

@chiragsalian I made it a deploy blocker because the problem occurred on staging but not on production when I tested. Is that the context I should add when applying the label? Should I also justify the severity of the issue?

Additionally, remember to handle deploy blockers in an hourly manner (or at least finish them within a day), this issue has been a blocker for 2 days now.

I did, in fact I put up a fix very quickly. I'm keeping this issue open because I'm also using it to fix the rest of offline distance requests. In the future I'll make a separate issue for the deploy blocker.
Sorry for forgetting to CP the fix.

What is the first verification? Once i came online everything seemed to look fine for me.

The steps for the deploy blocker are this, the first verification is step 4.

Go offline
Click the green plus, request money, distance
Enter a valid address for start and finish waypoints
Verify that you can click next

That is now fixed and steps 10 and 12 remain as problems.

@paultsimura your proposal looks good and solves some of the problems. I realized that I already fixed this in another draft PR. Sorry about that.
Maybe you could check out that branch and see what the next root problems are following the test steps in the description? Or we can put the issue on HOLD for later.

Hey @neil-marcellini, sure. I have found another bug with this offline flow. Should I write it here along with the proposal, or should we go the long way reporting it through slack?

Hey @neil-marcellini, sure. I have found another bug with this offline flow. Should I write it here along with the proposal, or should we go the long way reporting it through slack?

Yeah let's handle it here as long as it's relatively simple to reproduce in the offline flow.

@neil-marcellini while waiting for the response here, I reported this as a separate bug: https://github.com/Expensify/App/issues/28554

Ah ok that's alright. Please post your proposal for this one.

Ah ok that's alright. Please post your proposal for this one.

Is there anything specific left in this issue taking into account your first hot fix + your draft PR fix?

There's a few points, but I think I'll just lump them in with the eReceipt PR.

Hey @neil-marcellini, I'm a little confused, who do we need to pay for this issue and how much? It looks like you reported and fixed the bug, do I just need to pay @mollfpr for reviewing the PR?

Hey @neil-marcellini - is this a regression or a separate issue?

Hey @neil-marcellini, I'm a little confused, who do we need to pay for this issue and how much? It looks like you reported and fixed the bug, do I just need to pay @mollfpr for reviewing the PR?

Yeah only C+ PR review payment is needed. @mollfpr did a good amount of review, but then was unresponsive so I had @mananjadhav finish it off. Maybe then can agree to split the payment? Or we pay @mananjadhav the full amount since he ultimately helped me to GSD.

Hey @neil-marcellini - is this a regression or a separate issue?

Thanks for bringing it to my attention. I commented and closed it as a duplicate.

Thanks @neil-marcellini. Ideally you shouldn't need to bump, but it can help - since you didn't bump @mollfpr anywhere to finish reviewing, I think it's fair to split the $500 between the two reviewers. @mollfpr @mananjadhav does that sounds fair two you two?

It was an exception and @mollfpr did post an update here about their unavailability. I think am okay with the split here.

Okay, thanks @mananjadhav for the context. Both @mananjadhav and @mollfpr are eligible for payment via Manual Request, I'll post the payout summary below. Can you each let me know once you've completed the manual request so I can close the GH issue? Thanks!
Summarizing payouts for this issue:
Contributor+: @mananjadhav $250 (payable via Manual Request)
Contributor+: @mollfpr $250 (payable via Manual Request)
The overall $500 payment is being split between the two reviewers.

$250 payment approved for @mananjadhav based on summary above.

$250 payment approved for @mollfpr based on BZ summary.

All payments have been approved, closing the issue 👍


Use chrome for testing

Fixes: https://github.com/getgauge/taiko/issues/2708

Hey @NivedhaSenthil . So I was able to make the changes to download chrome for testing and get the functional and unit tests to pass locally after making this commit. https://github.com/getgauge/taiko/pull/2726/commits/a9e87e53da958ac2b92ce4f2859d21eca07ed6d4
Which means there is an issue with register and hanging on to promisesToBeResolvedBeforeCloseBrowser.push. If this piece of code is there it fails to close the browser and the other tests get an issue while opening it.
I am taking a look at it but any pointers will be helpful!

Let me also check, if I can recollect something 👍

@NivedhaSenthil does this have anything to do with https://developer.chrome.com/docs/web-platform/deprecating-unload?
I noticed that in the tests the beforeunload event does not fire.

@saikrishna321 @NivedhaSenthil can you take a look at this PR. The build runs consistently on linux (and mac) which is actually an improvement over previous versions.
On windows (check PR description) there are a lot of issues especially with using gauge-ts on versions greater than 16. While the unit tests run correct locally do run they are unpredictable in the CI for windows same is the case with functional tests.
I would still recommend bumping up to version 1.4 so that there's a fallback to 1.3.
Tell me what you think

Hi @zabil, sorry for coming back late on this. I think beforeunload event is still not deprecated,
The [beforeunload](https://developer.mozilla.org/docs/Web/API/Window/beforeunload_event) event has a slightly different use case to unload in that it is a cancellable event. It is often used to warn users of unsaved changes when navigating away. This event is also unrealiable as it will not fire if a background tab is killed. It is recommended to limit use of beforeunload and [only add it conditionally](https://developer.chrome.com/blog/page-lifecycle-api#the-beforeunload-event). Instead, use the above events for most unload replacements.
From https://developer.chrome.com/docs/web-platform/deprecating-unload. And guess it may be useful to have the api as there may be some sites still using it. And it looks like the event was not triggered for a different reason as mentioned in this blog.
Updating the html script in the beforeunload.test.js to below made the tests run fine.
    <div class="main">
        <label>Write your name : <input id='name' type="text" autofocus /> </label>
    </div>
    <script>
        let oldValue = document.getElementById('name').value;
        window.addEventListener('beforeunload', function (e) {
          let newValue = document.getElementById('name').value;
          if( oldValue != newValue) {
            event.preventDefault();
            // Legacy support for older browsers.
            return (event.returnValue = true);
          }
        });
    </script>

I have the changes locally, can push it if this looks fine.

Oh thanks! please push the changes if you can.

Sorry I am not sure what happened but the commits before unload changes seem to have disappeared after i did a push bumping up the version even though I didn't do a force push. Do you still have the commits?

I managed to add the changes back but forgot to sign DCO :/ Trying to rebase is leading to conflicts, should we leave it as such ?

Yeah. I think it's fine if there are issues. Please feel free to merge if you are ok with the changes.

I'll take a look at the release pipeline https://github.com/getgauge/taiko/actions/runs/9222743853


[REQUEST] Search Box in "Complete Log" section

There is must have a search box in Complete Log section.
so we will easily search a particular string or text in it

Use CTRL + F in your browser


Expand readme with information on how to run the project

README should include brief overview of Fake targets the templates provide

These are the steps I used for the Sutil-Safe template:

Install the template

dotnet new -i Sutil.Template

Scaffold Sutil-Safe project

dotnet new Sutil-Safe -n <ProjectName>

Restore packages

dotnet tool restore

Run it

dotnet run

Access it on http://localhost:8080/

We also provide dotnet run test, dotnet run clean and dotnet run install-client (although I have some doubts whether we need the last one or not). I would love to have these mentioned in the readme to bring awareness to them for people who are not familiar with Fake.

Can you please explain in which specific scenario one might want to call install-client (that would be equivalent to npm install) explicitly?


Add Rocky 8 and 9 support and fix acceptance tests

Pull Request (PR) description
Based on https://github.com/voxpupuli/puppet-splunk/pull/322. The target is to fix GitHub actions, and also test against newer EL versions.
Spent hours trying to debug the GitHub actions because on my local machine running bundle exec beaker always worked 😢
See https://github.com/voxpupuli/puppet-splunk/pull/356/commits/9dbbdf661934741ef87a1960ec51f18799c023e3 for what I found out.

@siegy22 , can I get you to add the rocky support in a separate PR? That way we can handle labeling and stuff get properly done :)

@zilchms There you go!


Custom Component CLI

Current Situation
Currently, creating a custom component requires manual steps.
Proposed Actions
Create a Command Line Interface (CLI) for creating custom components.
For example, Django has it's django-admin startproject <project_name> command for users.
We could implement something. For example, idom new_component <component_name> interface.
We most likely will implement this by using the setuptools script parameter.
Work Items
See above.

As this isn't a crucial feature, it'll be a v2 milestone goal.


v1.9.0 fails because of missing dependency

Installed version 1.9.0 with pip but it did not install the required tenacity dependency.
pip install --force --user -U podaac-data-subscriber
Collecting podaac-data-subscriber
  Using cached podaac_data_subscriber-1.9.0-py3-none-any.whl (22 kB)
Installing collected packages: podaac-data-subscriber
  Attempting uninstall: podaac-data-subscriber
    Found existing installation: podaac-data-subscriber 1.9.0
    Uninstalling podaac-data-subscriber-1.9.0:
      Successfully uninstalled podaac-data-subscriber-1.9.0
Successfully installed podaac-data-subscriber-1.9.0

If I try to run the new version:
Traceback (most recent call last):
  File "/home/DEV-cloud/.local/bin/podaac-data-subscriber", line 5, in <module>
    from subscriber.podaac_data_subscriber import main
  File "/home/DEV-cloud/.local/lib/python3.6/site-packages/subscriber/podaac_data_subscriber.py", line 25, in <module>
    from subscriber import podaac_access as pa
  File "/home/DEV-cloud/.local/lib/python3.6/site-packages/subscriber/podaac_access.py", line 21, in <module>
    import tenacity
ModuleNotFoundError: No module named 'tenacity'
Traceback (most recent call last):
  File "/home/DEV-cloud/.local/bin/podaac-data-subscriber", line 5, in <module>
    from subscriber.podaac_data_subscriber import main
  File "/home/DEV-cloud/.local/lib/python3.6/site-packages/subscriber/podaac_data_subscriber.py", line 25, in <module>
    from subscriber import podaac_access as pa
  File "/home/DEV-cloud/.local/lib/python3.6/site-packages/subscriber/podaac_access.py", line 21, in <module>
    import tenacity
ModuleNotFoundError: No module named 'tenacity'

fixed in 1.10.0


Added AppBarBehavior.under, etc

The gallery 'Scrolling Techniques' demo (under Patterns) can be used to try the new AppBarBehavior. Select 'AppBar stays put' from the toolbar's actions menu.
ScrollableLists now have the same ScrollBehavior as ScrollableViewport (so Block too): they only scroll when the child's extent is bigger than its container.
Toolbars no longer overscroll. Fixed https://github.com/flutter/flutter/issues/1719

lgtm, but I can't tell from the code whether the behaviour will be right. I'll check it out after you've landed and file bugs if I find any remaining issues.

This could probably benefit from tests, though, to make sure we don't regress the behaviour here. I'd fear making changes in this code if it's not tested.

I'm going to commit this before writing tests to get the big merge out of the way.
I'm hoping that the need for tests can be addressed using the new test driver tech; blindly writing tests for complex behaviors using the current tech is difficult and it's hard to know if the test is actually doing the right thing.


Workflow repository neither 'works' nor 'flows'

1/10 stars

issue led to the perfect issue label: "frivolous", description: "This issue has no substance"
therefore, this was a valuable use of everyone's time, and you're welcome


index: collect: update dir entry's loaded field after iterating through it

Related https://github.com/iterative/dvc/issues/9826

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Files
Coverage Δ

src/dvc_data/index/index.py
70.82% <100.00%> (+3.55%)
:arrow_up:

tests/index/test_index.py
100.00% <100.00%> (ø)

src/dvc_data/index/collect.py
61.33% <20.00%> (-4.43%)
:arrow_down:

... and 1 file with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.


run distributed algorithms

Hi
I try to run distributed algorithms on the cluster by the following input:
srun -N 8 ./toolkits/bfs /path/to/twitter-2010.binedgelist 41652230 20
but it seems each machine independently runs the algorithm by itself and the final outputs are the eight repeated results with the same runtime as the single machine. In my view, the distributed version should save running time.
So is there a way to run distributed algorithm as stated in the paper?

Hi, @chenyi95
I am afraid this is an issue of some mis-configuration. Can you run other MPI programs in a distributed way on your cluster?

Hi,@coolerzxw
The MPI works well for Powergraph on the cluster.
Also, I can run mpiexec -n 3  ./toolkits/bfs /path/to/twitter-2010.binedgelist 41652230 20  on the cluster, but again, this triggered paralleled computation on each machine.
So could you tell me the correct configuration if I missed.

@chenyi95 I came across this situation before (i.e. each process of an MPI program oblivious of others) and the problem turned out to be a mis-match between the MPI library used for compilation and the MPI runtime of the cluster (e.g. different MPI implementations like OpenMPI used for compilation but MVAPICH2 used for execution, b.t.w I was told that different versions of a same MPI library leading to incompatible passing/parsing of environmental variables can also cause similar behaviors). You may check whether this is also your case.


The RD dresser in core is a normal dresser

title, the RD's dresser on core station is a normal dresser, not the RD's filled dresser

fixed


Enable ImplictUsings on Demo & AspNET & Update Test.Sdk

THIS PR:

reduces some boilerplate code in the Demo & ASPNET projects by enabling ImplictUsings.
Updates the .NET test SDK, Cloverlet collector, and Moq libraries to their latest versions

A single test is continuing to fail because mds3.certinfra.fidoalliance.org is offline.
@abergs Ready for review.

Closing.


Facial informtion class labels

Can I ask about the label name for each class in facial informatics tasks?
Seems to be:
gender: Are these correct?:

0: Male
1: Female
2: Unknown

Emotion: Are these correct?:

0: Neutral
1: Happy
2: Sad
3: Surprise
4: Fear
5: Disgust
6: Angry

Age

What are the age ranges for each of 8 classes?

Thanks

Hi @Drunkar,
 Thank you for the fact that you are interested in our paper.
 Gender => Correct
 Emotion => Correct
 Age => 0-2, 4-6, 8-13,  15-20, 25-32, 38-43, 48-53, 60-

@Jia-HongHenryLee Thank you!


Test ANCM websockets against the Autobahn Test Suite

See this for reference

File this issue for Websockets. See: https://github.com/aspnet/WebSockets/blob/dev/test/AutobahnTestApp/Program.cs and https://github.com/aspnet/Home/issues/2865.
@anurse do we already test ANCM with Autobahn?

Is this about in-proc or out-of-proc? When I originally asked for ANCM to run autobahn it was about having ANCM use a known-good WebSocket server (perhaps ours, but perhaps even just a well-known existing server in Node, or the Autobahn Python-based server itself) and run the Autobahn suite against ANCM in that configuration. The goal was to be able to ensure ANCM didn't regress any WebSocket support.
Regarding https://github.com/aspnet/Home/issues/2865, I think @jkotalik is right, we may have to run ANCM in-proc tests in the WebSockets repo itself because of the layering (which is unfortunate). Though I would suggest we look at that layering since I'm not sure when WebSockets would depend on IISIntegration (other than to provide those tests, which if they were moved to IISIntegration wouldn't have the layering problem)

I also suggested testing the "WebSocket Module" itself in a way that was as isolated from ANCM/ASP.NET Core as possible. Basically just looking for ANCM/IIS to have a suite of compatibility tests running for it's various WebSocket scenarios.

It may also be good for IIS to have Autobahn suites running against a pure ASP.NET 4 app (i.e. without ANCM at all) to see if these issues repro. We have a sample Autobahn-compatible ASP.NET 4 app here: https://github.com/aspnet/WebSockets/tree/dev/samples/AutobahnTestAppAspNet4

https://github.com/aspnet/AspNetCoreModule/issues/80#issuecomment-291252474

I believe this can apply to both scenarios. Though setting up a well known server behind ANCM for out of proc will be a bit trickier (would need to create the equivalent of UseIISIntegration in the web server), it can be done. For starters, I would like to have pretty basic websocket tests using kestrel for out of proc and inprocess.

Regarding layering: most middleware repoes, including WebSockets, depend on IISIntegration for test and sample dependencies. This makes development much easier. Only BasicMiddleware excludes this dependency because IISIntegration depends on forwarded headers.

Most of the WebSocket implementation has been moved to CoreFx. It wouldn't be hard for IISIntegration to add some WebSocket tests using the CoreFx libraries directly.


Pre-built Stacks With 1-Click Download

Direct download links for offering pre-built stacks of popular packages.

[ ] - LAMP - Linux, Apache, MySQL, PHP
[ ] - MEAN - MongoDB, ExpressJS, AngularJS, NodeJS - mean.io/
[ ] - RAILS - Rails
[ ] - Yeoman - Grunt, Gulp, Bower
[ ] - React Native - osx, buck, node, linux, xcode, gradle, android

This issue was moved to dvcs/gitignore#19


Feature Request: Origin Property

Using pivot or anchor seems to confuse a lot of people because it changes the position. It's like doing this in CSS.
transform-origin: 50% 50%;
transform: translate(-50%, -50%) matrix(1, 0, 0, 1, 0, 0);

That works great when you want to center something, but not when you want to position stuff from top-left corner. There needs to be a way to control how the display object is oriented, like the origin property described here.
https://github.com/pixijs/pixi.js/issues/997
This would also make it more consistent with how transforms work with DOM elements. Here's a demo showing how that might look. I'm drawing a regular canvas object over an svg element, and transforming them the same way. I think that's the behavior a lot people are expecting.
https://codepen.io/osublake/pen/a4f18b10530f8f385aec9f253d226275

It would be great if we implemented #997 in the v5 transform, at least pivot and origin, obviously anchor is texture related.


Runtime and UserWarning Due to Zero-Variance Columns During Grid Search

When performing grid search parameter tuning using model_tuner.grid_search_param_tuning(X, y), I encountered the following issue:
If X contains any zero-variance (constant) columns, the process generates multiple RuntimeWarning and UserWarning messages as shown below:

Proposed Solution:
To prevent these warnings, I suggest adding a check before the grid search process starts to identify and drop any zero-variance columns in X. This can be achieved with a simple if block like:
# Check for zero-variance columns and drop them
zero_variance_columns = X.columns[X.var() == 0]
if not zero_variance_columns.empty:
    X = X.drop(columns=zero_variance_columns)

This would help avoid unnecessary warnings and improve the overall robustness of the function.
Steps to Reproduce:
Include a column in X with the same value for all rows.
Run model_tuner.grid_search_param_tuning(X, y).
Expected Behavior:
The grid search should proceed without triggering RuntimeWarning or UserWarning messages.

Mitigated by adding new section Caveats in documentation


[Feature Request]:I would like to add solution for 33. Search in Rotated Sorted Array

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I would like to add solution for 33. Search in Rotated Sorted Array
Use Case
I will provide proper description and comments.
Benefits
No response
Add ScreenShots
No response
Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@thevijayshankersharma Please limit the number of issues created per day to 4-5.