More code coverage for plugin_parser, and a minor fix to get_urls

[Current coverage][cc-pull] is 55.06%

Merging [#25][cc-pull] into [master][cc-base-branch] will increase coverage by 1.61%

@@             master        #25   diff @@
==========================================
  Files            19         19
  Lines          1579       1589    +10
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            844        875    +31
+ Misses          735        714    -21
  Partials          0          0

Powered by Codecov. Last updated by [58ae61e...4d0d9c9][cc-compare]
[cc-base-branch]: https://codecov.io/gh/CyberReboot/vent/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/CyberReboot/vent/compare/58ae61e38d8dbe8a2e7a03e9ba492b1894de829f...4d0d9c9c3529bbc675d96c1d1b1b92c3c4b5921d
[cc-pull]: https://codecov.io/gh/CyberReboot/vent/pull/25?src=pr


Memory leak from crossbeam_epoch::deferred::Deferred::new

I'm trying to run flurry (which uses crossbeam-epoch) through miri (after patching in https://github.com/crossbeam-rs/crossbeam/pull/458), and it seems to be finding a number of memory leaks in
crossbeam_epoch::deferred::Deferred::new::call::<fn() {crossbeam_epoch::internal::no_op_func}>

Judging from the signature above, I don't think this is a bug in flurry, but I could be wrong (the PR is at https://github.com/jonhoo/flurry/pull/37). Has there been an attempt at running the crossbeam-epoch test suite through miri following https://github.com/crossbeam-rs/crossbeam/pull/458? You probably need to be on the very latest nightly since https://github.com/rust-lang/miri/pull/1150 landed only very recently.

Yeah I would have been surprised if threads are the reason -- Miri will bail if you try to spawn a thread, so if there was a background thread started somewhere we'd notice (as opposed to silently not running that code).

After looking at crossbeam-epoch further, the lack of threads isn't the reason for the leak report, but rather, the closures from Deferred are ultimately owned by 'static variables.

Looks like you ran into https://github.com/rust-lang/miri/issues/940 then.

Now that https://github.com/rust-lang/miri/issues/940 has been closed, we should maybe consider enabling the miri leak check in CI again? /cc @jeehoonkang

Note that https://github.com/rust-lang/rust/pull/70897 has to land before the fix will be available via rustup.

@jonhoo sure, would you please send a PR after https://github.com/rust-lang/rust/pull/70897 is merged?

@jeehoonkang that just landed. I'm a little strapped for time at the moment, but if you want to take a stab it should just be a matter of doing these steps:

curl -s https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu/miri to get the latest nightly that supports miri
rustup toolchain install <that nightly>
rustup component add miri
cargo miri setup
cargo miri test or cargo miri run the binary you want to run miri on.

See https://github.com/rust-lang/miri/issues/1318 for the problems we are still having with the leak checker.

Now that miri supports threads and has the miri_static_root function, it should be possible to meaningfully run crossbeam under miri again! Unfortunately I'm pretty swamped right now, but if someone wants to give it a shot, it shouldn't be too hard.


Error when use fromCollection.

can not find IChannelBuilder implement class with IChannelBuilder.

https://github.com/apache/rocketmq-streams/pull/195


One line server startup errors

Fixes this:

Hey @xPaw, could you post an "after" screenshot for this error? Curious what it'd look like.

timestamp [ERROR] Error: listen EADDRINUSE :::9000

Does this correctly kill process when such error happens though?

It dies on its own, yes. The only thing keeping the server running is server.listen, so if that fails it just quits.

Sounds good!


Debugging with Stetho in Android

Debugging with Stetho in Android
Introduction
Stetho is an open-source debug library developed by Facebook. It allows you to use chrome debugging tools to troubleshoot network traffic., thus it provides a rich, interactive debugging experience for android developers.
With this library, you need to have an active emulator or device running, and you use with Chrome to connect to the device by typing chrome://inspect.
Key takeaways:
-you will be able to debug with stetho
-you will gain knowledge on how stetho works
-you will know the problems solved by stetho
References:
tutsplus
better programming

@anne-sogoli
Just wanted to follow up on this topic, as we will be clearing up the queue where possible.
Just and FYI I will be closing this topic form just to help clear up the queue where possible - can be REOPENED at anytime when ready. 👍

Hello, I am ready to push the article, can someone reopen the issue for me?
cc @hectorkambow @LinusMuema  @ahmadmardeni1


Chapter 6: Conic Optimization

Use Ipopt, Mosek, Gurobi, Knitro to solve SOCP and exponential cones (Gurobi only SOCP). Progress status (currently models only, text needs more editing):

[x] Economic order quantity
[x] The Kelly Criterion
[x] Markowitz portfolio optimization problem revisited: Mosek fails
[x] Optimal design of multi-layered building insulation
[ ] Training Support Vector Machines with Conic Programming
[ ] Extra material: Luenberger’s Investment Wheel
[ ] Extra material: Optimal Growth Portfolio

Started Economic order quantity 4629c8b

@fdabrandao do we need the g parameter for tools.ampl_notebook? It is not self-explanatory and it fails for me:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[196], line 4
      2 import numpy as np
      3 import pandas as pd
----> 4 ampl = tools.ampl_notebook(
      5     modules=["ipopt", "mosek"], # modules to install
      6     license_uuid="default", # license to use
      7     g=globals()      ### --------- Fails for me. Can this be default, would anyone change it?
      8 ) # instantiate AMPL object and register magics

TypeError: ampl_notebook() got an unexpected keyword argument 'g'

Hi @glebbelov,
You should have an outdated version of amplpy. Could you please run pyton -m install amplpy --upgrade and try again?
That last argument is necessary to give access to the globals in the notebook and enabling %%ampl_eval to access the global object named ampl. It cannot be a default because globals() returns the global variables accessible from where it is invoked, globals() inside a module returns the globals inside that module.

ChatGPT told me that IPython.get_ipython().user_global_ns gives me access to the global environment of the notebook too so that argument is going to go away in the next release.

@fdabrandao Concerning the Markowitz, the original notebook presents x' * Sigma * x <= s in the mathematical model, but then <= s^2 in Python. Changing model to <= s allows Mosek to be used. I am doing this in our notebook. Probably, authors should be notified about this mistake. Should I still add a model where the factorized matrix is used?

@fdabrandao SVM notebook did not run. I fixed general Python code. Should the authors be notified?


My images are not being edited much

I want to use this implementation of Imagic to modify images like the following:

which is obtained upscaling an image of a CIFAR10 horse through https://huggingface.co/stabilityai/stable-diffusion-x4-upscaler#examples
I want to edit it to have its front legs raised. I used the prompt:
"A photo of a horse with his front legs raised"
After setting up Imagic (I think correclty since I can reproduce the Obama example in the notebook), I get the following:

I can reconstruct the original image, in a 512x512 version
The generated modified images are all almost identical to the original (just the horse is a bit translated and the background color changes).

How can I use Imagic to edit the aforementioned image, generating the desired prompt?

I get the same problem (generated edited images almost identical to the original one) also with other examples like:


Use of $global is unneccesary

The PowerShell examples use $Global: which is unnecessary and should be removed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83229fe4-a0fc-5d45-1e32-2cf9bee9374b
Version Independent ID: ea237f69-8d65-e3c6-1c77-5f3fdfb73d34
Content: Migrate to SharePoint and OneDrive using PowerShell cmdlets - Migrate to Microsoft 365
Content Source: migration/overview-SPMT-PS-cmdlets.md
Service: sharepoint-online
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

Thanks @kilasuit for the feedback.


doc(README): remove typo

Description:
This Pull Request fixes a typographical error in the README.md file.
Changes Made:

Corrected "initialiser" to "initializer" in the README.md file.

Additional Information:
This fix is not related to any existing issue. It's a minor typo that I noticed while reviewing the README.
Thank you for considering this contribution.

initialiser is correct British English, which is what I tend to use most. Although, I'm certain that if you were to look around in the repo you'd likely find a mix of both.


Kind of Agario. RPG version.

Hello all.
I experimented with your clone of the game and decided to show it to you. RPColor. The code: GitHub
I added some of RPG to the game. The food is one of three RGB color and your circle represents a mix of collected paints. There are 4 different skills that depends of leading color. Also there is a boss, you have to get together to kill him.
The game includes:

Boss, it respawns every 8 min.
4 skills, (Q,W,E,R), depends of your eaten paints.
Food feed (old W) replaced with Paint feed (1,2 and 3 keys)

Also it have:

Сharacter stats (like in RPG)
Interactive help
Zoom

If you like it, i can send my code or you can add it to Live Demos :)
My friends and I have played enough and now we are fresh out of ideas.
Also i can offer my help with different features of the game.

It's awesome man! I like the new idea!
I want to keep this repository as simple as it is now (just have the base gameplay), but I also want to encourage people to implement a new idea base on this, as what you did here @Atrue
@IgorAntun @abalabahaha: I'm thinking about creating a new branch for each modified gameplay version. What do you guys think?

Per-version branch could get complex to maintain as the number of forks grows (merge conflicts >.<)... But yeah it would be nice to somehow have a few different versions of gameplay
Possibly a plugin/mod system?

That would be cool! I forked this repository a while back and little by little completely changed the game. eddt.me

I'd suggest that you make a folder in src/server called gamemodes in
that is the default gamemode ffa.js and you can put other gamemodes in it
and set the gamemode with a property called gamemode in config.json…

@abalabahaha @wb9688 yeah, :+1: for mod system!
@EdDT-Phi Me too :sweat_smile:

I've committed the code into github. https://github.com/Atrue/RPColor :blush:

@Atrue Very interesting. Cool.


Filename changed at export when containing the extension itself

When using tool convert_raster_format, if the name of the exported file contains it's extension, the companion file won't be named correclty.
wbt.convert_raster_format('infile.dep', '0.sdat_outfile.sdat')
# will give the files:
#   0.sdat_outfile.sdat
#   0.sgrd_outfile.sgrd instead of 0.sdat_outfile.sgrd

The problem is there also with .flt (companion file .hdr) and .rst (companion file .rdc). The problem is only with the Python API as the files exported from Whitebox GAT 3.4 doesn't experience this problem.

@jfbourdon Thanks for spotting this problem. It results from a use of the 'replace' function to handle paired header/data files for raster formats rather than a proper file path handling solution. This is actually pretty widespread within the WhiteboxTools codebase and as such, until it is resolved, it's a best practice to ensure that file extensions do not appear in either the file name or path.
Note that WhiteboxTools is a completely independent codebase and a separate project from Whitebox GAT, which accounts for their different behaviour in this regard.

I would gladly try to correct the code, but I can't find in converter_raster_format.rs where this replace operation occur (the lines I found don't seem related to that). I don't have any Rust knowledge but I kind of understand what's going on. Is the replace operation somewhere else around line 174?

Ok found where the magic is happening. I'll make a PR if I ever manage to get it to work!

Thanks @jfbourdon but because this has implications for several of the supported multi-file data formats, I've just finished refactoring each of the places in the codebase where replace was used to modify a file extension to now use the proper Path method in Rust. See the commit here. If you're becoming familiar with Rust, however, I'd certainly welcome any future commits that you may have for WhiteboxTools.


Android Touch Broken

Howdy folks.  I followed the Android instructions on the Wiki for setting up my development environment.  My game compiles, downloads and launches on my Samsung Galaxy S3.  However, the touch input is broken.
From my debugging in Eclipse I can see the first DOWN touch event occur.  Then when a second finger presses I get two more DOWN touch events.  When I release the second finger, only 1 UP event fires.
This results in the array indeces for touch events getting out of wack.  After the first multi-touch the engine believes one finger is still down.  So all single-touches act like zooming.  After a second multi-touch, it believes 2 fingers are always down and touch input tends to cease working.
As these events are called from outside engine, I'm not entirely sure what is breaking or how to fix it just yet.

I think im running into this problem, it may be due to
Point2I rawLastTouches[10];
because after 10 or so multi touches on any device it fails and reverts back to registering just 1 touch event
This is the only resource i have found so far on mutli touch events for android
@Override
public boolean onTouchEvent(MotionEvent event) {
    // get pointer index from the event object
    int pointerIndex = event.getActionIndex();

    // get pointer ID
    int pointerId = event.getPointerId(pointerIndex);

    // get masked (not specific to a pointer) action
    int maskedAction = event.getActionMasked();

    switch (maskedAction) {

    case MotionEvent.ACTION_DOWN:
    case MotionEvent.ACTION_POINTER_DOWN: {
        // We have a new pointer. Lets add it to the list of pointers

        PointF f = new PointF();
        f.x = event.getX(pointerIndex);
        f.y = event.getY(pointerIndex);
        mActivePointers.put(pointerId, f);
        break;
    }
    case MotionEvent.ACTION_MOVE: { // a pointer was moved
        for (int size = event.getPointerCount(), i = 0; i < size; i++) {
            PointF point = mActivePointers.get(event.getPointerId(i));
            if (point != null) {
                point.x = event.getX(i);
                point.y = event.getY(i);
            }
        }
        break;
    }
    case MotionEvent.ACTION_UP:
    case MotionEvent.ACTION_POINTER_UP:
    case MotionEvent.ACTION_CANCEL: {
        mActivePointers.remove(pointerId);
        break;
    }
    }
    invalidate();

    return true;
}

it seems setting the MAX_TOUCH_EVENTS in AndroidInput.cpp to a higher value the multi touch lasts longer but still stops working

Well it sounds like you're on the right trail. The touch event code is... complicated.

pull request with a quick and dirty fix put up

Can you explain what you did to fix this? Just reading the code it looks like it will never exit early now if there's not a double touch event.

when a touch is detected in the engine it is passed as a createMouseDownEvent to the AndroidInput.cpp
in the create mouse event
S32 vacantSlot was being passed a value of -1
then this was being checked here
for( int i = 0 ; (i < MAX_TOUCH_EVENTS) && (vacantSlot == -1) ; i++ )
i removed this value from vacantSlot and removed the check so this is always going to be true
for( int i = 0 ; i < MAX_TOUCH_EVENTS ; i++ )
for some reason i think this code

So I've buried myself in trying to understand this and here's what I've come up with. The problem is with the system that's supposed to match touchDown and touchUp events. Normally, the matching events would have a matching touchID. The for loop in the touch up code is just trying to make that match and for some reason never finds it and exits without throwing the actual touchUp event.
Now, what you've done is basically to guarantee that the touchUp event will fire by breaking the system thus quickly fixing the bug. However, you did so in a way that's hard on the engine.  You could have broken it better by changing the max touch events to 0 and commenting out the early return in the touchUp function.
However, it would be even better to actually fix the bug. We know the if statement inside the for loop in the touchUp function works because it works for the first few touch events until max touch events is used up.  So I think the bug is just that those touch event slots are not being released after they are used.  Basically we just need a single line of code at the end of the touchUp function that returns the slot to a state that will allow the touchDown function to use it again.
Game->postEvent(event);
lastTouches[currentSlot].lastX = -1;
return true;//return false if we get bad values or something
This will allow that slot to become vacant again and should cause the whole bug to go away without breaking functionality. Can you please revert your changes on the file and see if this change fixes the bug?

after reverting back and putting that in it breaks multi touch after the same amount of tries as original =/

Can you try just commenting out the early return in the touchUp function. That should also fix it, although it's still a hack.

i commented it out and still the same result which only makes this even weirder =/
what does work is just commenting out the early return in createMouseDownEvent and the early return in createMouseUpEvent

LastX is initialized on line 196 in the init function. The problem is simply that all the slots for tacking these down/up pairs are getting used up and not being set back to -1 when then are done. Since there's no slots they exit early and removing that exit stops the bug, but it still doesn't give us the slots back.


Use nextSpan instead of joinSpan

To account for the case when contextOrFlags.context() == null

this will make it always make a child. I think it is better to guard for now.

@adriancole Do you mean it is better to fix as follows:
Option(contextOrFlags.context())
      .map(tracer.joinSpan)
      .getOrElse(tracer.nextSpan(contextOrFlags))

To be honest I am a bit confused about nextSpan, joinSpan and similar... This method is called when calling a remote api for example, in that case shouldn't a new newChild always be called?
If there is a parent span already, that would be the span of something that called this service and there should be a child span of that span?

maybe the javadoc are not rendering for you. I think it is explained
exactly including how to handle conditional here
https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/Tracer.java#L184
On Wed, Jul 10, 2019, 3:57 PM Simão Mata<EMAIL_ADDRESS>wrote:

To be honest I am a bit confused about nextSpan, joinSpan and similar...
This method is called when calling a remote api for example, in that case
shouldn't a new newChild always be called?
If there is a parent span already, that would be the span of something
that called this service and there should be a child span of that span?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin-contrib/play-zipkin-tracing/pull/53?email_source=notifications&email_token=AAAPVV34IWG2IXIHJ7PTIULP6WB35A5CNFSM4H7HHUV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZSP3IQ#issuecomment-509935010,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAPVV3RH37CDVEV76ETHH3P6WB35ANCNFSM4H7HHUVQ
.

also here is the correct code which can be copy paste until such time as
the http abstraction is implemented here..
https://github.com/openzipkin/brave/blob/master/instrumentation/http/src/main/java/brave/http/HttpServerHandler.java#L96

I think this looks good.

sorry to be more literal, both old and new are broken code. scala variant of this can fix it.
  Span nextSpan(TraceContextOrSamplingFlags extracted, Req request) {
    Boolean sampled = extracted.sampled();
    // only recreate the context if the http sampler made a decision
    if (sampled == null && (sampled = sampler.trySample(adapter, request)) != null) {
      extracted = extracted.sampled(sampled.booleanValue());
    }
    return extracted.context() != null
        ? tracer.joinSpan(extracted.context())
        : tracer.nextSpan(extracted);
  }

sorry actually this code looks ok because you don't have http sampler anyway yet. it does need test case though

been a long time. just rebased the project so it has CI etc

just rebased and seems ci is green. I'll try to write that test.

Hi,
I added a unit test, but I think I didn't get the idea, as this test passes even without my changes. Could you explain a bit more what do you mean I should be testing here?
Thanks.


Add workbook and use RangeAreas in Seasonal Tree sample

Also making this a nondenominational tree.

Docs Build status updates of commit 22bc49f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/samples/community-seasons-greetings.md
:white_check_mark:Succeeded
View

docs/resources/samples/happy-tree.xlsx
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@sumurthy, yes the TOC and other indicators show this sample as community contribution.


Integrated Terminal gets blocked working with git

Version: 1.33.1 (user setup)
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763
Steps to Reproduce:

Click on View --> Terminal
at first you see blank terminal
Click return key then you are able to see that cursor
just try a git branch from a git repository path
you'll get blocked that terminal, you have to open a new one to carry on working

Does this issue occur when all extensions are disabled?: Yes

Probably need more information. Like

what is the terminal inside vscode you are using? Seems like powershell to me. Sometimes powershell need time to launch.
can you see the terminal prompt after launching a new terminal?
does the same command block if you use terminal outside of vscode?
...

That happen with powershell and also with git console even waiting for a longer,  just try to run git branch it get blocked.
the same behaviour opening a new terminal
Not at all. Windows Cmd works perfectly

The blank terminal issue is https://github.com/Microsoft/vscode/issues/57803
What do you mean by blocked? The terminal just doesn't work anymore? Can you show a screenshot in this state?

Sure!

after run git branch it gets blocked as shown, i have to open a new terminal to get it running again.


Fix 32-bit message

Show message when requesting a 64-bit version that is only installed as
32-bit. Mirroring what is shown when requesting a 32-bit version that is
only installed as 64-bit.

Thanks!


support following someone from the feed

Right now you can't tell in the feed whether you already follow someone.  You can sort of guess it, in that boosted things aren't usually by people you follow, but that's not ideal.
We can see who you follow by fetching https://mastodon.mit.edu/api/v1/accounts/:id/following?limit=80, though note that this is an id and not an acct.

This is especially annoying for follow notifications, where you can't easily see the difference between "someone is following you back" and "someone new is following you, and you might want to follow them back"


Removal of highway=no

I made an edit in Changeset 101844413 that was suggested by iD, which was removing the tag highway=no from a path as it was deprecated.  Apparently, this should not have been done (according to a comment on that changeset, and backed up by the relevant page on the wiki).

The issue you posted is unrelated to this repo. Please move your issue here: https://github.com/openstreetmap/id-tagging-schema/issues

Thanks for letting me know @mxdanger.  Upon inspecting that repo,  it seems an issue relating to that has already been opened and closed (without yet being solved).


Fork of ForgeCLI - Is there any way to chose between client and server installation ?

The issue section of the https://github.com/3arthqu4ke/ForgeCLI fork is not active so I thought I'd take a chance here.
I've been messing around with the original ForgeCLI  and your fork of ForgeCLI. I was wondering if there is any way to also install a server by command line. It seems like it's made to install only the client version of forge. I did not see any argument in the doc that could allow this at the moment.
Thank you !

AFAIK the forge installer can already install the server via CLI.
java -jar forge-x.xx.x-installer.jar --installServer
https://minecraft.fandom.com/wiki/Tutorials/Setting_up_a_Minecraft_Forge_server

How did I miss that. I actually searched something like this.
Thanks a lot !


Is it possible to create image from local file using Docker API?

I'm trying to create docker image from file on docker host using python docker API.
Client running on different host, so I would like to avoid downloading file to client and then uploading it to docker host. This test:
import docker
d = docker.from_env()
print(d.images.client.api.import_image("/data/file.tar", "acme.com/test"))
print(d.images.client.api.import_image("file:///data/file.tar", "acme.com/test"))

produces next output:
{"status":"Downloading from http://%2Fdata%2Ffile.tar"}
{"errorDetail":{"message":"parse http://%2Fdata%2Ffile.tar: invalid URL escape \"%2F\""},"error":"parse http://%2Fdata%2Ffile.tar: invalid URL escape \"%2F\""}

{"status":"Downloading from file:///data/file.tar"}
{"errorDetail":{"message":"Get file:///data/file.tar: unsupported protocol scheme \"file\""},"error":"Get file:///data/file.tar: unsupported protocol scheme \"file\""}

Docker daemon 1.13 running in Ubuntu 16.04 VM on ESXi 6 host. Client is docker python API 2.0.2 running on physical Windows 10 host.

@isanych Please note that this is the issue tracker of the Docker project and not a Q/A Forum. This kind of questions can be made here: https://forums.docker.com/
I see that you opened another issue (#30714) regarding image creation so I'll keep that one and close this


Remove app controller

Towards https://github.com/giantswarm/giantswarm/issues/15503
Checklist

[x] Update changelog in CHANGELOG.md.

@giantswarm/team-biscuit yo


Ryan M: Watch cheapbusinessessay.com

Ryan M requests the watch of the watch_keyword cheapbusinessessay\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

cheapbusinessessay\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Daniil in Charcoal HQ


session insert not producing expected result...

Hi!
I am trying to update a session property called n_rows inside a HttpController/METHOD_LIST_BEGIN/post handler call using:
auto &sessionPtr = req->getSession();
...

int nRows=999;
sessionPtr->insert("n_rows", nRows);
int ro=sessionPtr->get<int>("n_rows");
printf("n_rows now has %d\n",ro);
...

printf never shows the 999 value but the value at the time of the post call.
Once insert is not an asynch call, why does insert instruction can not override the current value of n_rows with 999?
Thank you
Alex

In my local host, it prints 999 as expected.

I am going to try to reproduce it in a smaller project...

I can now reproduce it in another  smaller project but now I have a question:
Does session :: insert method updates a key if it already exists?  If not, what is the method to update an existing session key?

No. it inserts successfully only if the session doesn't already contain an element with an equivalent key.
you could use the modify interface to create a new one or update the old one.

I am aware of modify but its interface is 'strange' for me? Is there any example of using the modify method?

https://github.com/drogonframework/drogon/blob/94c7add7a18b8bec648e9cf28abd060828044426/lib/tests/integration_test/server/TimeFilter.cc#L23-L26
it looks 'strange' because satisfy the safety of multiple threads.

Sure!
Thank you once again


perf: spawn eth filter tasks

jsonrpsee is essentially a Vec<RequestFut> where the RequestFuture is the invoked callback handler.
all of them are called on the same task, which means that long running tasks can end up starving other tasks.
while all filter handlers are very much async, applying the filters (over a long range) still takes some time, so they should all be executed on a separate task.

Codecov Report

Merging #2696 (ee5e899) into main (fa2b9b6) will decrease coverage by 7.80%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #2696      +/-   ##
==========================================
- Coverage   46.00%   38.20%   -7.80%
==========================================
  Files         502      502
  Lines       65027    65058      +31
==========================================
- Hits        29913    24854    -5059
- Misses      35114    40204    +5090

Flag
Coverage Δ

integration-tests
?

unit-tests
38.20% <0.00%> (-1.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/rpc/rpc-builder/src/auth.rs
0.00% <0.00%> (-44.51%)
:arrow_down:

crates/rpc/rpc-builder/src/lib.rs
10.05% <0.00%> (-53.14%)
:arrow_down:

crates/rpc/rpc/src/eth/filter.rs
9.71% <0.00%> (+2.26%)
:arrow_up:

... and 297 files with indirect coverage changes


Zee5 Premium Video Extraction Error

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
zee5  premium movies links are not extracting with premium account and not able to download
i think they made some changes, for premium movies there is no hls_url field in api and hls token is also empty.
may be they removed the hls_url field for premium movies
Verbose log
PS G:\YoutubeDL> .\yt-dlp.exe https://www.zee5.com/movies/details/aranmanai-3/0-0-1z535888 -u <number> --verbose
[debug] Command-line config: ['https://www.zee5.com/movies/details/aranmanai-3/0-0-1z535888', '-u', 'PRIVATE', '--verbose']
Type account password and press [Return]:
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, err utf-8, pref cp1252
[debug] yt-dlp version 2<IP_ADDRESS> (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg N-103553-g5e7e2e5031-20210908 (setts), ffprobe N-103553-g5e7e2e5031-20210908
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
[Zee5] Logging in
[Zee5] Sending OTP
[Zee5] SMS successfully sent
Type OTP and press [Return]:
[Zee5] Verifying OTP
[debug] [Zee5] Extracting URL: https://www.zee5.com/movies/details/aranmanai-3/0-0-1z535888
[Zee5] 0-0-1z535888: Downloading access token
[Zee5] 0-0-1z535888: Downloading JSON metadata
ERROR: [Zee5] 0-0-1z535888: Unable to download JSON metadata: HTTP Error 400: Bad Request (caused by <HTTPError 400: 'Bad Request'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; type  yt-dlp -U  to update. Be sure to call yt-dlp with the --verbose flag and include its complete output. (caused by <HTTPError 400: 'Bad Request'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; type  yt-dlp -U  to update. Be sure to call yt-dlp with the --verbose flag and include its complete output.
File "yt_dlp\extractor\common.py", line 713, in _request_webpage
  File "yt_dlp\YoutubeDL.py", line 3295, in urlopen
  File "urllib\request.py", line 531, in open
  File "urllib\request.py", line 640, in http_response
  File "urllib\request.py", line 569, in error
  File "urllib\request.py", line 502, in _call_chain
  File "urllib\request.py", line 649, in http_error_default

This has DRM.
Provide a non-DRM'd example

non DRM movies works fine
premium movies are not working even with credentials

non DRM movies works fine premium movies are not working even with credentials

Premium != DRM
If you can't provide non DRM example where this issue occurs then this is not an issue (other than cleaner error message maybe). We do not support downloading of DRM content and I won't make changes to extractor just to accommodate DRM'd video.
Btw this is assuming that the error in log is genuine( and not some account error or network error) as I don't have an account rn to test myself.

I think zee5 made some changes
I have no way to test(and work on) this if you won't/can't provide a non DRM'd example 🤷♂

i think this is the non DRM'd example
PS G:\YoutubeDL> .\yt-dlp.exe https://www.zee5.com/movies/details/action-film-starring-puneeth-rajkumar/0-0-2677 --verbose
[debug] Command-line config: ['https://www.zee5.com/movies/details/action-film-starring-puneeth-rajkumar/0-0-2677', '--verbose']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, err utf-8, pref cp1252
[debug] yt-dlp version 2<IP_ADDRESS> (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg N-103553-g5e7e2e5031-20210908 (setts), ffprobe N-103553-g5e7e2e5031-20210908
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
[debug] [Zee5] Extracting URL: https://www.zee5.com/movies/details/action-film-starring-puneeth-rajkumar/0-0-2677
[Zee5] 0-0-2677: Downloading access token
[Zee5] 0-0-2677: Downloading JSON metadata
[Zee5] 0-0-2677: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 0-0-2677: Downloading 1 format(s): 3443
[debug] Invoking downloader on "https://zee5vodnd.akamaized.net/hls1/elemental/hls/Movies/Drama/DODDAMANE_HUDGA_MOVIE_RevRTR_kn_43228f769d6be44ef852e02508669123/index1080lowp/hdntl=exp=1637252388~acl=%2F*~data=hdntl~hmac=bcd58bc679ff19e70a54e87d118da96d5d51bc3d2470e4280b7cb88661267d6e/1080lowp.m3u8?aka_me_session_id=AAAAAAAAAAAkfZZhAAAAACVxURdV%2FvBYoP0XNr3FhFghh%2F6hsVUI8Asbge8NFHoLDBC3e8d0yT8nub%2F+n1qsskHKw4Nlj68j&aka_media_format_type=hls"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 1370
[download] Destination: Doddmane Hudga [0-0-2677].mp4
[download]   1.8% of ~2.11GiB at  4.23MiB/s ETA 11:32 (frag 25/1370)
ERROR: Interrupted by user
PS G:\YoutubeDL>

i think this is the non DRM'd example

But it works 😑
What i mean when i say i need a non-DRM'd url to work on this is that

The url content is not DRM'd
AND
The url results in the issue in the OP log

Closing this since this was confirmed to be DRM "issue" on discord.


added a guide

This guide sets pragmatic philosophy towards becoming a machine learning developer.

@vishwajeetv there is some really great advice in this guide. I love the pragmatic focus.  I will show this article to at least one coworker tomorrow :smile:
"Dive into Machine Learning" is very carefully curated so far ... While this article has a similar hack-first focus, I have issues with the tone. Some of it really made me cringe. Really, I think some of the tone is over-the-top because the author is interested in selling you something. I am always skeptical of authors who are trying to sell you something :P
Maybe this is my issue: this article provides advice that may help some developers get into machine learning. Yet it has a lot of attitude. If everyone had the attitude of this article, there would be no machine learning field for developers to get into; nobody would get into math or research let alone something as "un-pragmatic" as machine learning research!
I will mull this over a bit. Sorry to delay :) Appreciate the PR, for sure

Opening a dialogue with the author. I'll follow up on other channels if Twitter doesn't work.

(build failure is erroneous, see https://github.com/dkhamsing/awesome_bot/issues/46 )

Sent an email to the author, let's see

Well, unfortunately the author was not receptive. It's a shame. The article has really good advice, but I have to wrap it in so much defensive language to feel like it's appropriate to include -- with certain readers in mind. I really don't want to alienate those readers. Hmm.

@vishwajeetv I'm sorry, I rebased my history and I didn't realize it was going to cause a mess; would you mind re-submitting this pull request in a new fork off latest master? I know it's just a 1-line thing but I want  you to be on the contributors list like you should be :)


Unable to init Cluster with the nested  provider

What steps did you take and what happened:
Following the documentation https://github.com/kubernetes-sigs/cluster-api-provider-nested/tree/main/docs and try to init a cluster:
bin/clusterctl init --core cluster-api:v0.4.0  --control-plane nested:v0.1.0  --infrastructure nested:v0.1.0
Fetching providers
Error: current version of clusterctl is only compatible with v1beta1 providers, detected v1alpha4 for provider cluster-api
we get this error.  We tried the latest clusterctl version 1.3.5 as well as download the code and build the master tree. Same result in all tested binaries.
What did you expect to happen:
If i follow the documentation i would expact the same results as in the documenttion. S in this case a yaml that can be applied to a kubernets cluster.
Environment:

cluster-api-provider-nested version: v0.1.0
Minikube version :v1.23.2
Kubernetes version: (use kubectl version): v1.26.3
OS (e.g. from /etc/os-release): Debian GNU/Linux 11 (bullseye)

/kind bug

Encountered the same problem. I tried against many clusterctl versions with no luck. Please helo.


Adds defaultValue argument to HiveField

Fixes #555

Oh, im so sorry, i totally missed this

No problem, it's fine

Oh, im so sorry, i totally missed this

No problem, it's fine

This is a nice solution imo

This is a nice solution imo


Suggestion: Add some comments!

Dear based jeticg,
There's nothing wrong with this widget, that I've seen. It's pretty damn cool, and while I've never read the manga, I am loving this fantastic widget. Please keep adding stuff! Your work is appreciated. I'm not going to lie: I can hardly read CSS/Java/Coffeescript. I'm a C/C++ programmer, but I managed to change around some of the string outputs and colors to my liking. I'm not entirely sure if this is possible in coffeescript, but maybe some line comments/comment directives at the top of the file could point the customization crazies to the right element they need to change to get what they want (ex: change German to English or change cell and font colors). Again, just a suggestion, not an issue.
Keep it up m80

Hello,
Thanks for the advise! I’ll add more comments on the next update (0.61a). I didn’t bother with this because this widget is still under development. Anyway, I’ll send you a email as soon as the update is ready, thank you for your support, it means a lot to me.
Cheers,
Jetic

Am 08.09.2015 um 10:16 schrieb SillySailboat<EMAIL_ADDRESS>Dear based jeticg,
There's nothing wrong with this widget, that I've seen. It's pretty damn cool, and while I've never read the manga, I am loving this fantastic widget. Please keep adding stuff! Your work is appreciated. I'm not going to lie: I can hardly read CSS/Java/Coffeescript. I'm a C/C++ programmer, but I managed to change around some of the string outputs and colors to my liking. I'm not entirely sure if this is possible in coffeescript, but maybe some line comments/comment directives at the top of the file could point the customization crazies to the right element they need to change to get what they want (ex: change German to English or change cell and font colors). Again, just a suggestion, not an issue.
Keep it up m80
—
Reply to this email directly or view it on GitHub https://github.com/jeticg/Evangelion-Uebersicht-Widget/issues/2.

I've already uploaded the 0.61a, if there's anything you need do not hesitate to contact me, and I'll see what I can do. Thank you for your support!


Added mining plugin for Kotlin

Hello,
I have ported the mining plugin to Kotlin. This is my very first time ever working in Kotlin, so if you have any feed back I am all ears.
I do not have a working test environment setup for the Kotlin plugin version of Apollo, I do believe that this code is correct, but I would greatly appreciate if someone could test this for me.
If this all looks good, I will work on porting over other plugins.
I hope this is usable and helps!
~Trevor

I do not know why the gem.rb and respawn.rb were originally in the mining plugin dir, but I have also included gem in my port as gem.kt. I did not port respawn because I am not sure why it is there or what it is used for.

Thanks for the contribution.  Will get around to reviewing it tonight.

Is it OK if I add fishing to this pull request?

Please make a separate pull request for fishing.

OK, I will do.

Still need to get lookup working and get a chance for ore being mined.

OK, I think I have everything working on this now...?
I have implemented the algorithm for determining the chance to mine an ore.
i also fixed not checking if the player can use the pickaxes it has.
The only thing left is to figure out how to expire the ore. I would really appreciate if someone could point me in the right direction on this one.
Thank you,
Trevor

The only thing left is to figure out how to expire the ore. I would really appreciate if someone could point me in the right direction on this one.

cc @Major-
is the best way of doing this still scheduling a task that immediately removes the object, replaces it, and does the same again after the respawn time?

Also, are we respawning ores based on server pop or constant times? I know it used to be pop based but then was changed to be constant.
http://www.runescape-static.salmoneus.net/skills/mining.html#ore_respawn_times

@tlf30 lets go with constant time for now.  If anyone running apollo sees this to be a problem we can change it.

OK, I have tasks and the respawn times figured out, the last question I have for now is how do I remove/replace an object?

So I think I have found a way to remove and respawn the entities for the rocks. I would love some feedback on the approach though.

OK, I have a problem in my implementation.

If two entities are at the same location, the ore is not respawned and not replaced by the depleted ore. It instead disappears permanently.
Not all ores are at the location stored in position for the event. Which is all the more questionable.

To test these, go to 3083 9800, give yourself 1265, and mine some of the tin ore.
Other than these two problems, the code works. I am looking into solutions, but do not have any at this time. Also this code contains some debugging print statements.
Lastly, and unrelated. On my client I am not getting messages for the player from the server. It is very likely an issue with my client, but I do not know for sure.

@tlf30 can you clarify what the problem (or problems) are? Also some good work, thanks!

@Major- Thank you for the feed back!
The issues that I am having:

Some ore rocks disappear completely after being mined
Some ore rocks disappear instead of becoming the depleted rock, but will show when respawned as a normal rock.
Some ore rocks correctly become depleted but disappear instead of being respawned as a normal rock.

The ore rocks that have these problems are always the same physical ones in the world. It is not related to the ID of the ore rock as far as I can tell. The same rock always has the same issue. I have been doing my testing in the mine at 3083 9800. I also tested two different clients which both have the same issue with the same rocks.

I guess that's a problem with the region/object management system then

Thank you for the review @Major-, I was going to remove the debugging statements and clean up the comments after I had finished debugging why objects were disappearing. But if it is not an issue with this code I will clean it up now.
Thank you for all the help!

Can you give me some exact steps to see the object replacing bug (like coordinates to stand at and which rock to mine)? Does it always happen?

Teleport to 3038 9800. Give your self a pickaxe. Mine nearest coal coal object. It will become a depleted ore correctly but vanish when it should have become a coal rock again. Then if you go north east, there are 2 stone rocks. Mine both of them. One will vanish permanently. Other ore rocks will do other similar things if you mine them, but it is always the same rocks, not by id, but by location.
commands:
::tele 3038 9800
::item 1275
::level 14 99

Merged in https://github.com/apollo-rsps/apollo/pull/338/commits/a54485e2637127070507802fdf6a5b45c8646e61.  Thanks!


Support VS for Mac

The private preview currently supports:

Visual Studio 2017 Update 6 (15.6) on Windows 7, 8.1, and 10
Visual Studio Code on Windows 7, 8.1, and 10
Visual Studio Code on macOS Sierra (10.12) and up

👍 (upvote) if you'd like to see VS for Mac supported.

I would add support for VS for Mac with Xamarin

@Chuxel What's the current status of the mac version?

@m1guelpf The core infrastructure between VS Code Mac/Windows/Linux is the same and thus the main work is verify and deal, deal with native dependencies, and nuances like when sudo is required or browser integration.  Obviously VS Code for Mac has been supported from the beginning.  Linux was more complicated due to the number of distros and technical issues (some of which we're still ironing out).
By comparison, VS for Mac is different enough from Visual Studio it is effectively an entirely new integration effort pretty much from the ground up.  As a result we do not have a specific timeline to share at this point and how quickly we pick it up will depend on how much interest in it we hear from the Live Share community.

@Chuxel OK, another quick thing: I initially registered for the Linux version, but now I've switched to a mac. I'm still waiting for my invite (I'm probably still in the waitlist), so could you switch me to the mac waitlist?
Also, great work with this, both the code and your responses!

@m1guelpf Send your email to<EMAIL_ADDRESS>and we can help you out.  VS Code on Mac has been available since the start of the preview.  Also, check your junk mail just in case the invite landed there. 😀

It would be great to see this ship, Visual Studio for Mac is my primary IDE.

This needs to be moved to the top of the priority list. It is absolutely unacceptable that this wasn’t shipped or at least in progress by Build.

I switched from PC to Mac a couple weeks ago and was appalled to find out that this wasn't supported in VS for Mac..

I completely agree with @dansiegel. This makes VS for Mac sound like second class citizen.

I would love to see this on vs for mac <3

Same here - I use VS for Mac all the time.
-Aaron
On Fri, May 11, 2018 at 4:44 PM Daniel John Causer<EMAIL_ADDRESS>wrote:

I would love to see this on vs for mac <3
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/live-share/issues/91#issuecomment-388480514,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKzH_d4A-TdfH6kzg6uNc8tgJ4C7Bi-ks5txfgYgaJpZM4SAF18
.

Plans ahead?

By comparison, VS for Mac is different enough from Visual Studio it is effectively an entirely new integration effort pretty much from the ground up. As a result we do not have a specific timeline to share at this point and how quickly we pick it up will depend on how much interest in it we hear from the Live Share community.

Nearly 100 👍 seems like a good amount of interest. Please don't treat VS Mac like a second class citizen.

Any progress?

i have kinda found a work around for the time being using VS Code for Mac along with VS for Mac, I open my project in VS Code and do my live share from there and then start the app inside VS for Mac. My issue with this of course are:

Having 2 (two) Applications running at the same time.
Having to restart the app inside VS for Mac each time a file change is made.

I'd like to see Live Share for VS for Mac come to fruition as i think this would help seal the deal on one of the differences between the windows and mac version and help VS for Mac gain more traction for developers.
Thank you for such a great product and i hope to see Live Share become an option soon.

VS for Mac is our IDE of choice for my team... We have a cross-platform (Android and iOS) app built with Xamarin.Forms, in production since April, 2018. We always struggle with remote mobbing, and if VS Live Share supported VS for Mac, I think those problems would be significantly eased if not completely eradicated.

Adding my request to show further interest. Really hoping the Live Share team can add support for VS for Mac!

Would love to see live share for Mac as well!

Any update it’s 2020 still we don’t have this in vs for Mac ☹ we need it asap

For what it's worth: over at devblogs, an article about remote development with Live Share was published today. Maybe it should be amended to clarify that VS4Mac is not a supported platform yet.

I'm using Liveshare from a mac; Is this bug stale?

Live share is not supported on newer Apple Silicon M1 machines, see #4133 .

We’re not able to prioritize this issue over the other higher-impact issues we receive every week, based on the votes and comments from others in the community and our understanding of the issue. However, rest assured that we love your input. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it is for you.


The learnable token embeddings are attached to the first 9 layers of the text encoder for refining the textual space.

First of all, I would like to thank you and your colleagues for your contributions to this domain. I have a question that in the Implementation details you said that The learnable token embeddings are attached to the first 9 layers of the text encoder for refining the textual space. but I only see that the 2nd (i = 1) -> 8th (i = 7) layers are attached. Can you explain it for me, thank you.

we do not attach text embedding at the first layer，and attach embedding for the next 8 layers (9-th layer)
---- Replied Message ----
| From | @.> |
| Date | 06/08/2024 23:25 |
| To | @.> |
| Cc | @.***> |
| Subject | [zqhang/AnomalyCLIP] The learnable token embeddings are attached to the first 9 layers of the text encoder for refining the textual space. (Issue #21) |
nh.ch.p.man.hinh.2024-06-08.214758.png (view on web)
First of all, I would like to thank you and your colleagues for your contributions to this domain. I have a question that in the Implementation details you said that The learnable token embeddings are attached to the first 9 layers of the text encoder for refining the textual space. but I only see that the 2nd (i = 1) -> 8th (i = 7) layers are attached. Can you explain it for me, thank you.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Thank you for clarifying, I just figure out the 9-th layer also attached.


NiMARE: Adding and Documenting Extensions

Title
NiMARE: Adding and Documenting Extensions
Short description and the goals for the OHBM BrainHack
NiMARE covers a wide breadth of meta-analytic algorithms. However, the only constant is change. With new algorithms emerging from research across the globe, there is a need for integrating the latest trends in neuroimaging meta-analysis and making the process smooth for new contributors.
In order to kickstart the extension process the goals are twofold:

integrate a new algorithm into NiMARE
document the process and find pain points

related issue: https://github.com/neurostuff/NiMARE/issues/698
Link to the Project
https://github.com/neurostuff/NiMARE
Image for the OHBM brainhack website
https://nimare.readthedocs.io/en/latest/_images/nimare_overview.png
Project lead
James Kent, github: @jdkent, discord: jdkent#4667
Main Hub
Glasgow
Other Hub covered by the leaders

[ ] Glasgow
[ ] Asia / Pacific
[ ] Europe / Middle East / Africa
[ ] Americas

Skills
One of the following:

python: intermediate
git: 2
knowledge/implementation of a neuroimaging meta-analytic method not incorporated in NiMARE

Recommended tutorials for new contributors

[X] Set up a brainhack friendly computing environment
[ ] A introduction to Bash
[X] Python: Writing a script
[ ] Python: Data analysis with Python
[ ] Python: Visualisation
[ ] Machine learning basics
[ ] BIDS
[ ] Machine learning for neuroimaging
[X] VCS: Using Git and Github
[ ] VCS: Data management with Datalad
[ ] Virtualization
[ ] High Performance Computing: Oracle cloud resource

Good first issues
N/A
Twitter summary
We are trying to stop meta-analytic algorithms from becoming strays after their owner graduates by giving them a forever home in NiMARE, will you help us?
Short name for the Discord chat channel (~15 chars)
nimare-extensions
Please read and follow the OHBM Code of Conduct

[X] I agree to follow the OHBM Code of Conduct during the hackathon

closing this one to simplify into one project, sorry!


What would it take to support additional languages?

Hello, and thank you for your work on this!
I see two existing requests for additional languages, and I see the maintainer stated they have no time to implement them.
But perhaps you can indicate what it would take to support additional languages? If you could document the main requirements, I am sure people could be found to create pull requests and gradually increase the coverage of this very useful tool!

Hey! So for additional languages, the main requirement is to run through the dumps server-side to create the initial data and then set up the pipeline for continously listening to the repespective event streams/pull the revision texts. That is basically just a repetition of previous languages but still requires meaningful effort for which there are no resources on my side right now. And there is not much that can be contributed through pull requests there. Also the server we are running this on right now would proably not support more than 2 larger language editions without being needed to be upgraded.
(A secondary task would be to actually test the output for additional languages, since tokenization is not 100%  language-agnostic, although the rest of the algorithm is)
So bottom line I have been thinking about that it might be better to move the project to Wikimedia servers. The Wikimedia iOS team has also been reaching out and it seems that the demand for languages (and increased requests) make this a good idea.


Invalid js formatting

?? becomes ? ?, which is not valid.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:

1.69.2
3b889b090b5ad5793f524b5d1d39fda662b96a2a
x64

OS Version:
Windows 10
Steps to Reproduce:

type some js that includes the Nullish coalescing operator (??)
select Format Document from command pallete

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

weird, I had went through 2 suspect extensions and it was none of them, I tried it with all disabled and turns out it must have been some other extension. Thanks


TypeError: references is not iterable / cant parse expect(findBy*)

Error stack
TypeError: references is not iterable
Occurred while linting /Users/lukaszostrowski/projects/mp/src/app/flowers/__tests__/flowers-test.tsx:1

TypeError: references is not iterable
Occurred while linting /Users/lukaszostrowski/projects/mp/src/app/flowers/__tests__/flowers-test.tsx:1
    at Program:exit.testingLibraryQueryUsage.forEach.node (/Users/lukaszostrowski/projects/mp/node_modules/eslint-plugin-testing-library/lib/rules/await-async-query.js:61:37)
    at Array.forEach (<anonymous>)
    at Program:exit (/Users/lukaszostrowski/projects/mp/node_modules/eslint-plugin-testing-library/lib/rules/await-async-query.js:38:34)
    at listeners.(anonymous function).forEach.listener (/Users/lukaszostrowski/projects/mp/node_modules/eslint/lib/linter/safe-emitter.js:45:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/lukaszostrowski/projects/mp/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/Users/lukaszostrowski/projects/mp/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (/Users/lukaszostrowski/projects/mp/node_modules/eslint/lib/linter/node-event-generator.js:283:22)
    at NodeEventGenerator.leaveNode (/Users/lukaszostrowski/projects/mp/node_modules/eslint/lib/linter/node-event-generator.js:306:14)
    at CodePathAnalyzer.leaveNode (/Users/lukaszostrowski/projects/mp/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:655:23)
Process finished with exit code -1

Probably related code:
https://github.com/Belco90/eslint-plugin-testing-library/blob/b38689c69702f08954b456d03752d73b1bee7171/lib/rules/await-async-query.js#L38
Can't provide right now an example , I have to strip few hundreds lines, but maybe its just a matter of  checking for references if its actually an array?
Also basing on code it should be expecting await from query, I believe only find* queries should be matched.
I don't have any of them top level, I have few expect(findBy*()).resolves. When I remove them, error is gone

I hope I can go back to this in Christmas when I have some spare time. Sorry!

Just ran into this as well. I can look into a PR later on

I opened a PR about that. Sorry about the delay, I have little spare time lately!
@Belco90 This issue hides, however, another issue. Indeed, we are not handling the case where a user wraps a query in an expect statement and then uses resolves or rejects. For example, the following statement will trigger an error even if it's a valid case:
expect(findByText("foo")).resolves.toBe("bar")

I'm opening up another issue 🙂

:tada: This issue has been resolved in version 1.3.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[WIP] We are going full meta

Turning hummingbird-me/hummingbird into a meta repository in favor of hummingbird-me/hummingbird-server and hummingbird-me/hummingbird-client
Additionally added an interactive setup script in order to make setup easier for new contributors

@JoshFabian Dashboard screenshot seems to be broken (Has also been the case in the-future), we might want to reupload that.
Other than that, this should be ready to merke and finally make the complete switch to split-repo development and transforming this into a meta repo.


update cap-add docs for seccomp

fix #20082

LGTM 🐸
/ping @thaJeztah

oh, thanks!
LGTM

whoa so fast

:sunglasses: :stuck_out_tongue_closed_eyes:

Thanks for updating this. Very helpful!


HTTPS TLS issue on openbesluitvorming.nl

NET::ERR_CERT_COMMON_NAME_INVALID
Subject: *.netlify.app

Issuer: DigiCert TLS Hybrid ECC SHA384 2020 CA1

Not sure what's causing this. The page itself is hosted by Netlify, which automatically sets TLS certs using LetsEncrypt. It worked fine some time ago (certs generated 31st of May), but recently it stopped working. I can't remember making any changes to settings.
We use Netlify DNS, so I've reset some settings there and hope that fixes it. (settings panel)
I saw zoek.openraadsinformatie.nl mentioned in one of the TLS errors, which seemed odd to me, as that domain is not configured using Netlify DNS. I also remember a Cloudflare mention in one of the errors.
zoek.openraadsinformatie.nl is managed by VNG. Maybe they use cloudflare, and that creates a problem when setting up TLS certs. Perhaps I should ask VNG to let Netlify DNS instead for this subdomain.

Seems fixed now!


Open Request Cost Aggregation (ORCA)

Today in Envoy, simple load balancing decisions can be made by taking into account local or global knowledge of a backend’s load, for example CPU. More sophisticated load balancing decisions are possible with application specific knowledge, e.g. queue depth, or by combining multiple metrics.
This is useful for services that may be resource constrained along multiple dimensions (e.g. both CPU and memory may become bottlenecks, depending on the applied load and execution environment, it’s not possible to tell which upfront) and where these dimensions do not slot within predefined categories (e.g. the resource may be “number of free threads in a pool”, disk IOPS, etc.).
https://docs.google.com/document/d/1NSnK3346BkBo1JUU3I9I5NYYnaJZQPt8_Z_XCBCI3uA/edit# provides a design proposal for an Open Request Cost Aggregation (ORCA) standard for conveying this information between proxies like Envoy and upstreams. We propose that this become a standard part of UDPA and supported by Envoy.
The design document is in draft stage; from offline discussions I think the need for something like this is not very controversial, we can iterate on aspects of the design here.

I've been talking with @htuch about implementing ORCA's in-band reporting, and adding it's details to a particular stream.)
However, when bringing it up @htuch mentioned that the RFC had some debate around how inband reporting should be implemented. Currently the RFC Calls for stuffing JSON in x-endpoint-load-metrics. However after talking with @PiotrSikora I think this is the incorrect choice, and would like to spur extra conversation here. Since I shouldn't be the sole person to make this decision :stuck_out_tongue_winking_eye:

While the JSON Reporter is using a standard encoding (JSON), not all proxies currently support JSON out of the box, nor should they. Most of the time the bytes are just moving through them, and they only need to know how to parse HTTP. (Some can be extended: see NGINX, but those are always custom extensions/code written to do so).
If we want ORCA to become a true standard, by lowering the barrier to entry for them by not forcing them to add in JSON parsing if they don't need to, adoption would increase. Which would help the total number of users, and it's usefulness.
Instead I recommend we implement both parsing of: x-endpoint-load-metrics-bin (binary protobuf format), and: x-endpoint-load-metrics. The real one we should focus on is: x-endpoint-load-metrics (which maybe should even be called endpoint-load-metrics since the IETF recommends not using x-). The reason for this is two fold:

It's an RFC that's very close to completing, and already has other RFCs building on top of it. So it's chances of "dieing out" are low.
2. Even headers that are widely supported today are using something very close to parameter list: Cache-Control: max-age=seconds for example. This is already the basis for parameter list.

x-endpoint-load-metrics-bin I think should be supported because it can be a nice optimization for those already integrating with ORCA protobuf, and wanting to not have to juggle two seperate encodings of what to send on.I don't imagine it being a huge ask to do so, making it not worth the implementation effort.

Happy to hear thoughts on this, and coming up with something official that aren't just my bemused thoughts :smile:

@SecurityInsanity yes, https://tools.ietf.org/html/draft-ietf-httpbis-header-structure-11 is fine. Let's just make sure that this is a direct translation of the data model that exists in the proto, i.e. it should be equivalently expressive.

For sure 👍🏻. I think keeping the model is needed.
I’ll start working on a PR tomorrow. Can you update the doc? (I don’t think I have write access).

@SecurityInsanity sure. I think we should hash out the new representation here first. Looking at https://github.com/envoyproxy/envoy/blob/master/api/udpa/data/orca/v1/orca_load_report.proto, I think we may need multiple headers, e.g. x-endpoints-load-metrics, x-endpoints-load-metrics-cost, x-endpoint-load-metrics-utilization to correctly distinguish the core fields and the distinct maps that exist in the data model. @PiotrSikora do you think this is correct?
FWIW, coincidentally I'm working on migrating the API tree in https://github.com/envoyproxy/envoy/tree/master/api/udpa (which includes the ORCA protos) to live in https://github.com/cncf/udpa-wg today. This shouldn't have a major impact on your work, but there might need to be some slight path or Bazel fixups needed once this lands.

@htuch That's good to know about the proto's moving, thanks. Based on my understanding of the priority yes we'd need 3 headers. (one for the core type, and two for the two maps).

@SecurityInsanity sounds like a plan from my side. Looking forwarding to seeing ORCA support landing :)

@SecurityInsanity assigning issue to you for the ORCA implementation work planned. Feel free to assign back if there is any remaining future work once that lands.

Does anybody have any pointers to blogs / papers about about considerations for multi region or global load balancing algorithms? (Useful for input into a designing a system which would leverage functionality like ORCA)

That's a great question @erikbos. @alexburnos @antoniovicente are you folks aware of any public material that talks to how backend named costs would integrate with global LB?

Do know anything public that would be specifically focused on LB algorithms, but maybe chapter on managing load in the SRE book could give some high level ideas.

Thanks for the reference to the SRE book, it's always a good read but I was looking for the next level of depth.. On Slack @snowp mentioned https://netflixtechblog.com/netflix-edge-load-balancing-695308b5548c which contains some of that 👍

gRPC has adopted ORCA (and its xDS definitions) as the basis of load reporting for gRPC-LB v2 CC @markdroth. We still do not have any Envoy implementation though, very much open to any contribution PRs here.

Just for reference for anyone working on this, the ORCA support in gRPC is documented in gRFC A51: Custom Backend Metrics Support and gRFC A64: xDS LRS Custom Metrics Support.
See also gRFC A58: weighted_round_robin LB policy for how ORCA is used in load balancing.

@Mythra are you still working on this? If not, I'm a little interesting in this issue.

@efimki is working on this from our side (Google). CC @markdroth @AndresGuedez

@efimki is working on this from our side (Google). CC @markdroth @AndresGuedez

Any detail info about this? Looking forward to this feature. Any we can help this?

Here is a draft outline of what we are trying to do:

Load Reports will be provided to the xDS control plane server via xDS LRS API.
Load reports will be used by a new Client Side Weighted Round Robin load balancing policy to dynamically calculate host weights on the client side. Inline reporting enables sub second load balancing reaction times (depending on backend load measurement and reporting intervals), a critical requirement for customers with coordinated and spiky traffic workloads.

More details are here.

Basically, I think there are two different part works:

bridge the orca report and LRS.
make the lb aware the orca.

I personally think we should only provide simplest support to the common metrics: cpu, mem, application_utilization, etc. first. There attributes could cover most cases.
The named_metrics, utilization, and request_cost may has more complex semantics and will bring more heavy overhead. So, I will prefer to only provide simplest implementation first until our users ask more.

I agree with a two parts distinction.
We will start with using orca report for LRS. I agree that common orca metrics cover many cases, however we want to provide our users with flexibility of using named metrics if necessary. The additional complexity of handling named metrics on top of processing orca report is not that high.

is there any movement on this? i am interested in using this feature

is there any movement on this? i am interested in using this feature

It's landed but now only client weighted round robin will use the report to help load balancing.


no migration path for vscode.d.ts installation

We have a story as outlined here: https://github.com/Microsoft/vscode/issues/1881 but there is no migration path for existing users. We should provide a way to modify the package.json to include the needed script.

This issue was moved to Microsoft/vscode-extension-vscode#7


RPM spec: specify version for python-google-compute-engine dependency.

google-compute-engine requires python-google-compute-engine, but does not
specify the required version; this allows google-compute-engine to be upgraded
independently from the python distribution, which results in broken scripts.
Fixes #511.

Thanks for the contribution! Please update the pull request to diff against the development branch so we can review this and merge it in.

Updated; sorry, forgot to do so the first time.


Tuned express can be sent to our App

Changes

We can set express settings and sent it by constructor of App in form
new App({ e: express() }) (resolves #13)
Pug template engine was introduced (resolves #15)
Router was created as dedicated module

It was a bad idea to pass tuned express to our App.


Tell TeslaMate docker instance use a specific CarID

Use case: I would like to share an hosted EC2 instance of the TeslaMate stack with a few friends/family but I don't want to spin up new EC2 instances for each Tesla account.
I would like a way to tell the TeslaMate application to use a specific Car ID rather that he default of 1. This way I can run multiple instances of the TesaMate docker instance for different Tesla accounts but still use the same Postgres/MQTT/Grafana instance. I know TeslaMate supports multi cars in the same Tesla account so it should be a matter of exposing TeslaMate to use a specific CarID.

Multi-tenancy or similar features are not planned as they are beyond the scope of the project. However, it is still possible to use the same Postgres instance (w/ multiple databases) and Grafana instance (w/ multiple data sources) as well as the same MQTT broker (requires MQTT_NAMESPACE) with multiple teslamate instances on a single EC2 instance. See https://github.com/adriankumpf/teslamate/issues/403.


Update RapidWeaver to use latest version. Closes Issue #37403

Update RapidWeaver to use latest version (7.4.1 as of 8-5-17). Closes Issue #37403 .
If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[ ] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] If the sha256 changed but the version didn’t,
provide public confirmation (How?): {{link}}

There is still a versioned URL available:
https://dl.devmate.com/com.realmacsoftware.rapidweaver/18708/1496675639/RapidWeaver-18708.zip

I am confused on why we don't use :latest when possible.

It is preferable to have a checksum, which is only possible for versioned URLs.

Ok. I will update for versioned URL.

Better?

FYI, the script says 'leopard' or later. 7.x requires El Capitan
https://kb.realmacsoftware.com/article/53-rapidweaver-system-compatibility-notes


 Please retry your request by not specifying an Availability Zone or choosing us-west-1b, us-west-1c.
	status code: 400, request id: 66839b2b-3ef6-41ba-a3c2-452c80ee1732

  on main.tf line 157, in resource "aws_instance" "logger":
 157: resource "aws_instance" "logger" {

Error: Error launching source instance: Unsupported: Your requested instance type (t2.medium Windows) is not supported in your requested Availability Zone (us-west-1a). Please retry your request by not specifying an Availability Zone or choosing us-west-1b, us-west-1c.
	status code: 400, request id: f226ea5d-49a3-4b67-8836-09d7f24a3617

  on main.tf line 204, in resource "aws_instance" "dc":
 204: resource "aws_instance" "dc" {

Error: Error launching source instance: Unsupported: Your requested instance type (t2.medium Windows) is not supported in your requested Availability Zone (us-west-1a). Please retry your request by not specifying an Availability Zone or choosing us-west-1b, us-west-1c.
	status code: 400, request id: 04172dad-68ae-48b8-8fe3-e136a764c7c4

  on main.tf line 238, in resource "aws_instance" "wef":
 238: resource "aws_instance" "wef" {

Error: Error launching source instance: Unsupported: Your requested instance type (t2.medium Windows) is not supported in your requested Availability Zone (us-west-1a). Please retry your request by not specifying an Availability Zone or choosing us-west-1b, us-west-1c.
	status code: 400, request id: 6239ab8e-eb5c-4110-85f7-973375635dd4

  on main.tf line 270, in resource "aws_instance" "win10":
 270: resource "aws_instance" "win10" {

Temporary workaround is to set the default availability zone to us-west-1b in Line 11 of Terraform/variables.tf

Looking for help on this one.
The Windows 2016 AMIs seem to support ENA natively (meaning I don't have to do anything for AWS to recognize them as supporting ENA):
DC
$ aws ec2 describe-images --image-id ami-00beb549af8618fd3 --query "Images[].EnaSupport"

[
    true
]

WEF
$ aws ec2 describe-images --image-id ami-09256c7aa0b81dc92 --query "Images[].EnaSupport"

[
    true
]

However, even after installing the Windows Enhanced Networking package on the Win10 Packer build, it isn't recognized as having ENA support after converting it to an AWS AMI:
WIN10 with ENA Package Pre-Installed from Packer via install-aws-ena.ps1
$ aws ec2 describe-images --image-id ami-004c16a4f87c540b8 --query "Images[].EnaSupport"

[
    false
]

Unfortunately, Terraform won't let us select a t3.medium instance for WIN10 unless it detects that ENA is enabled on the AMI:
Error: Error launching source instance: InvalidParameterCombination: Enhanced networking with the Elastic Network Adapter (ENA) is required for the 't3.medium' instance type. Ensure that you are using an AMI that is enabled for ENA.

 Annoying, but I think it should probably work. Testing now.

Doesn't seem to work yet. The WIN10 AMI doesn't pull any IP address after doing this and using a t3 instance.

I don't think this solution is going to work from a build pipeline perspective. I either need to find a way to enable the support natively in the AMI without booting up an instance or just leave the Win10 host as a t2.

Don't think it's worth fixing this by getting ENA supported on Win10, especially after us-west-1a stopped including t2 and t3 medium instances. I'm addressing this here: https://github.com/clong/DetectionLab/commit/d686a50f81a6709c82c4d9f097134cdc30898a27


MySQL Support

Describe your changes
MySQL support for Netbird. Still in draft stage.  I have never used the “GO” language before, so if I have any mistakes you can help me to correct them.
Issue ticket number and link

Checklist

[ ] Is it a bug fix
[ ] Is a typo/documentation fix
[x] Is a feature enhancement
[ ] It is a refactor
[ ] Created tests that fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the submission @ismail0234. Can you enable github action tests for MySQL as well?
See the current ones here: https://github.com/netbirdio/netbird/blob/4e918e55ba0fe9cd87a3b3eccc658d1a7deeda0f/.github/workflows/golang-test-linux.yml#L13

@bcmmbaga can you share how to add a testcontainer for MySQL?

@ismail0234 To add a MySQL test container, you will need to add MySQL  support in the NewTestStoreFromSQL
https://github.com/netbirdio/netbird/blob/a9d06b883fe742c5dd03b822ba2385203e1b1682/management/server/store.go#L253
To spin up a new MySQL test container, you can follow the same approach we used for PostgreSQL https://github.com/netbirdio/netbird/blob/a9d06b883fe742c5dd03b822ba2385203e1b1682/management/server/testutil/store.go#L17

The “security/snyk” step seems to have failed but I can't see what caused it.

The “security/snyk” step seems to have failed but I can't see what caused it.

Go modules seem out of sync with the codebase. Could you run go mod tidy and push the changes?

hmm, the result still seems to be the same.

Is this part used for testing?  Do I need to add mysql values?
https://github.com/netbirdio/netbird/blob/a9d06b883fe742c5dd03b822ba2385203e1b1682/.github/workflows/test-infrastructure-files.yml#L23

It seems to give the error “remote error: upload-pack: not our ref”. Is it a temporary problem?
https://github.com/netbirdio/netbird/actions/runs/11686156210/job/32552758527?pr=2837 seems to be successful.

Seems related to  the pipeline. I will restart the tests again

@ismail0234, could you please force-push the latest commit to trigger the workflow? The last tests are currently queued and don’t seem to be progressing

I am not sure why. But there are warnings like “Table for peer.Peer does not exist, no migration needed”. It says that the table and the data in it is missing. I didn't see any error output either.

There seems to be a problem causing the MySQL container not to start. Increasing the timeout does not solve the problem either.

The Container is working, but it's causing problems on the MySQL side because the way datetime are used in the Netbird database architecture is incorrectly designed. I will see what I can do for this.

I temporarily disabled the other tests until the MySQL test passes.

Strange, in the last tests it gives a connection refused error.

there was a panic in one of the tests. https://github.com/netbirdio/netbird/pull/2837/checks#step:9:827 We are checking what it is.
Your current version is missing a change on one of the workflow files to avoid canceling all matrix tests. You might want update your branch with main.

Performances;
[Sqlite]
github.com/netbirdio/netbird/client/cmd => 13.338s
[Postgres]
github.com/netbirdio/netbird/client/cmd => 22.657s
[MySQL]
github.com/netbirdio/netbird/client/cmd => 46.300s
The reason why the MySQL Test is slow is that the MySQL TestContainer starts extremely slowly.

@bcmmbaga
Are we sure that the code here works in postgres and sqlite tests? My guess is that the code here does not work in sqlite and postgres tests. This is because the scheduled task should run after 10 minutes. But because mysql is slow to start the testcontainer, the test time exceeds 10 minutes and this test is triggered. As an error it says that the database connection is rejected.
https://github.com/netbirdio/netbird/blob/4be826450be50f6e8d6a7693081a041b448888ca/management/server/account.go#L1274-L1279

Hi @ismail0234, I started similar topic a while ago https://github.com/netbirdio/netbird/compare/main...feature/add-mysql-support#diff-998d2ca8f48ecbf2d1a259f3851048dacc8f8ae1dfc13c0e69a34e74eaae817a but didn't progress nearly as far yet.
When you check the last file management/server/user.go this is how I solved the date issue.
I will have a look into the inactivity expiration topic.

Hi @ismail0234, I started similar topic a while ago main...feature/add-mysql-support#diff-998d2ca8f48ecbf2d1a259f3851048dacc8f8ae1dfc13c0e69a34e74eaae817a but didn't progress nearly as far yet.
When you check the last file management/server/user.go this is how I solved the date issue.
I will have a look into the inactivity expiration topic.

@pascal-fischer
Setting NULL by default for datetime values does not work. I tried this, it works at first, but in some queries it fails because the system throws the value 0001-01-01 instead of NULL. To solve this, there is a sql_mode setting in MySQL. I configured mysql to allow dates with 0000.

I sent the first fix to solve this problem. If I didn't break anything, it seems to be fine :) https://github.com/netbirdio/netbird/pull/2865

This fix fixes the failure of SQL tests that take longer than 10 minutes. https://github.com/netbirdio/netbird/pull/2866

Can you share what tests exactly fail and which PR fixes which test? https://github.com/netbirdio/netbird/pull/2865 should be no problem, although it should not be needed. I wanna understand how this can have an impact. And https://github.com/netbirdio/netbird/pull/2866 should not have any impact at all as the default should already be false so I wanna debug why this can have an impact and why.

Can you share what tests exactly fail and which PR fixes which test? #2865 should be no problem, although it should not be needed. I wanna understand how this can have an impact. And #2866 should not have any impact at all as the default should already be false so I wanna debug why this can have an impact and why.

@pascal-fischer
I'm not at home at the moment. Those values for #2866 are inactive by default. That's why the tests were running that code and crashing. By setting "PeerInactivityExpirationEnabled" to false, we ensure that the issue is never triggered. But since there is another bug, we apply #2865.

Can you share what tests exactly fail and which PR fixes which test? #2865 should be no problem, although it should not be needed. I wanna understand how this can have an impact. And #2866 should not have any impact at all as the default should already be false so I wanna debug why this can have an impact and why.

I shared the necessary information in the related pull request.

We are ready for the next test. Let's see what errors we get this time. -_-

TestContainers have been optimized. Instead of creating a new test container each time, we create 1 for mysql and postgres and cache it.
Test time for Postgres decreased from 350+ seconds to 140 seconds.
Test time for MySQL decreased from 1800+ seconds to 150 seconds.

The MySQL test seems to have been successful. 🥳
https://github.com/ismail0234/netbird/actions/runs/11777556741

Hi @mlsmaycon ,
How can I use this in a new server?

I tested it in production environment. Mysql connection is established and working without any problem.
But when I use <IP_ADDRESS> in the mysql connection string, the connection is not established. When I enter the ip address of the server, the connection can be established. I am not sure if this is a docker related issue. Mysql and netbird are running on the same server.

Some tests failed. Is it a general problem?

Everything is complete. I've tested it in a production environment and so far I haven't had any problems. The peers can connect to each other and we can use the panel features. It looks like there's nothing else I can do. @bcmmbaga

Using MySQL database made the api calls very fast. When I use sqlite, api calls take 1.5-4 seconds when there are 500 peers on the network, while it takes 0.2 seconds when we use mysql.

@mlsmaycon @bcmmbaga @pascal-fischer Can you check the Pull Request to merge?

If you want to merge PR, I reopened it. But if you don't want to merge, you can close or delete PR. @mlsmaycon

@ismail0234, could you please run the following commands and push the changes?
 go get -u github.com/containerd/containerd && go mod tidy

The vulnerability appears to be in the go-jose module. The vulnerability has been fixed on version v4.0.1. Even if containerd is updated, the issue still seems to persist.

You can revert the changes since they broke the gRPC. However, the Snyk issue seems to be a false positive, as we don't import the go-jose module at all. You can confirm with:
go mod why -m github.com/go-jose/go-jose

I'll take a closer look into this as well

The vulnerability appears to be in the go-jose module. The vulnerability has been fixed on version v4.0.1. Even if containerd is updated, the issue still seems to persist.

You can revert the changes since they broke the gRPC. However, the Snyk issue seems to be a false positive, as we don't import the go-jose module at all. You can confirm with:
go mod why -m github.com/go-jose/go-jose

I'll take a closer look into this as well

@bcmmbaga yes, it says the module is not in use.


Update table: pages

no changes to schema

Permissions by role

public: none
registered, no role: none
analyst: R (where draft = false, ADDED 19/10/)
manager: CRUD
admin: CRUD

also:

similar to the previous last_modified_user_id add field updated_by (also see https://github.com/dumparkltd/marine-defrag-server/blob/master/app/models/versioned_record.rb)
add field created_by that should automatically capture the user id on creation (maybe in https://github.com/dumparkltd/marine-defrag-server/blob/master/app/models/application_record.rb?)

new fields

private: boolean (default: true)


Shade all vespa-hadoop dependencies

@gjoranv or @bjorncs Please review.
Fairly cumbersome to list each dependency and transitive dependency. The following alternative also works. Preference?
<relocations>
    <relocation>
        <shadedPattern>shaded.internal.</shadedPattern>
        <excludes>
            <exclude>com.yahoo.**</exclude>
            <exclude>org.apache.hadoop.**</exclude>
            <exclude>org.apache.pig.**</exclude>
            <exclude>java.**</exclude>
        </excludes>
    </relocation>
</relocations>

Using the alternative approach is more brittle because you must prepare to whitelist (=exempt from shading) any future package in the SDK that does not start with java., and any future hadoop related packages that don't match the current patterns. Note that you should also whitelist org.w3c.dom, javax.** and what not if you go for that solution.
IMO, it's better to have special treatment for your own deps, because you have more control over them than the world outside.


Added linkedlist.py

Added linked list written in python3.

Linked list program can't be part of HacktoberFest


x/website: reword FAQ answer on lack of ternary operator

Go version: 1.13
Introduction
There is recurring proposal about "ternary operator" in the issues (e.g. 1, 2, 3...). This suggestion is in hope to reduce their frequency in future.
Problem
Trouble seems to have two parts:

Go currently intentionally lacks any form of "conditional expression" (either ternary operator or something alike) which could be used inside expression for brevity.
It is not well explained in FAQ, which leads readers to feel protest and even disgust, and, probably, adds to repulsing newcomers :)

It seems currently there is strong opposition to improve the 1-st part. Then perhaps we can improve the 2-nd?
Further I shall copy current text and proposed change to it, but here are main points:

motivation uses word UNQUESTIONABLY which is quite questionable approach and have air of insolence, rudeness and doesn't look like professional language
another ambiguous word is CLEARER (code without conditional expression) which fails to impress after example of 5 additional lines (with 6-th missing) suggested as substitution
motivation refers to unspecified "language designers" who "had seen (what they didn't like) too often" which sounds like decision was someone's fancy, rather than it is based on popular (though still controversial) opinion in community
the text doesn't give hope for improvements (alternatives) in future versions
proposed workaround example is incomplete (lacking variable definition - which looks like omission by intention to reduce line count) and, perhaps it could be shorter

Supposed update to text
this variant is a bit lengthy, feel free to suggest cuts
Currently there is no conditional expression in Go (neither ternary expression, nor anything similar). General workaround is:
var n someType
if expr {
    n = trueVal
} else {
    n = falseVal
}

which often may be shortened to (at the expense of reassignment):
n := falseVal
if expr { n = trueVal }

The reason for absence of conditional expression in Go is the popular opinion among developers (in various languages), that it may lead to poor code readability and style, e.g.:

using ternary operator instead of conditional statement (not expression) for brevity;
using conditional expressions with very long parts split into several lines;
using nested ternary operator which makes precedence ambiguous.

Future versions of Go may introduce some alternatives (like allowing return value from if-else or type parameters for functions which will allow creating custom operator-like function etc.). Please don't post yet another issue "add ternary operator". It is omitted by design and is not going to be added at least in the same form as in C++ and Java.
Current Text
There is no ternary testing operation in Go. You may use the following to achieve the same result:
if expr {
    n = trueVal
} else {
    n = falseVal
}

The reason ?: is absent from Go is that the language's designers had seen the operation used too often to create impenetrably complex expressions. The if-else form, although longer, is unquestionably clearer. A language needs only one conditional control flow construct.
UPD: yet one more about the same #36303

We are go.

// @dmitshur

Is the phrasing "unquestionably clearer" not still present in the proposed change? Personally as someone who questions the clarity of both workarounds versus a one-line ternary expression, I can actually feel my blood pressure go up as I read that.
Also, I'd urge reconsidering this stance. I understand that Go is targeting making code that isn't clever, is easy to read, and is resistant to making and hiding simple subtle mistakes (although variable shadowing and typed nils are pretty big strikes against this goal IMO).

using ternary operator instead of conditional statement (not expression) for brevity;
using conditional expressions with very long parts split into several lines;
using nested ternary operator which makes precedence ambiguous.

Why not just restrict the return values to exclude expressions - include only literals, constants, and variables? It prevents using the expressions for control flow, prevents the creation of lengthy expressions, and prevents the use of nested ternary if since that would be an expression. It would still cover the main cases that are frequently brought up (binary configuration choices and substituting default values for nil / zero values). Then perhaps everyone can be happy?

You should also remove the last line:

A language needs only one conditional control flow construct.

as it doesn't apply to go.
Go has two control flow constructs: if-else and the switch statement. Indeed, as stated here: https://golang.org/doc/effective_go.html#switch

It's therefore possible—and idiomatic—to write an if-else-if-else chain as a switch.

Compare:
if COND {
  //
} else {
  //
}

to:
switch {
case COND:
  //
default:
  //
}

Both are perfectly valid go.


uninstall module

Please, let me know how to uninstall if I used:
curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.29.0/install.sh | bash
to install?
Thanks,
ben

rm -rf $NVM_DIR - the two nvm-related lines in your profile file will be a noop if there's no nvm.sh, but you can manually remove those two if you want.


march_hare 4.0.0 and 4.1.0 bug crashes plugin

In the latest march_hare versions 4.0.0 and 4.1.9 a bug was introduced in https://github.com/ruby-amqp/march_hare/blob/v4.0.0/lib/march_hare/session.rb#L91 (opts is undefined) which crashes the plugins like this
[2019-09-06T17:49:09,625][ERROR][logstash.pipeline        ] Pipeline aborted due to error {:pipeline_id=>"shipper", :exception=>#<NameError: undefined local variable or method `opts' for MarchHare::Session:Class>, :backtrace=>["org/jruby/RubyBasicObject.java:1708:in `method_missing'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/march_hare-4.1.0-java/lib/march_hare/session.rb:91:in `connect'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/march_hare-4.1.0-java/lib/march_hare.rb:24:in `connect'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-mixin-rabbitmq_connection-5.1.0-java/lib/logstash/plugin_mixins/rabbitmq_connection.rb:201:in `connect'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-mixin-rabbitmq_connection-5.1.0-java/lib/logstash/plugin_mixins/rabbitmq_connection.rb:138:in `connect!'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-output-rabbitmq-5.1.1-java/lib/logstash/outputs/rabbitmq.rb:47:in `register'", "org/logstash/config/ir/compiler/OutputStrategyExt.java:106:in `register'", "org/logstash/config/ir/compiler/AbstractOutputDelegatorExt.java:48:in `register'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:259:in `register_plugin'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:270:in `block in register_plugins'", "org/jruby/RubyArray.java:1792:in `each'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:270:in `register_plugins'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:611:in `maybe_setup_out_plugins'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:280:in `start_workers'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:217:in `run'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:176:in `block in start'"], :thread=>"#<Thread:0x66f57e21 run>"}

Relevant bit is
#<NameError: undefined local variable or method `opts' for MarchHare::Session:Class>, :backtrace=>["org/jruby/RubyBasicObject.java:1708:in `method_missing'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/march_hare-4.1.0-java/lib/march_hare/session.rb:91:in `connect'",

submitted PR upstream https://github.com/ruby-amqp/march_hare/pull/145

March Hare 4.1.1  includes the  above PR. Thank you for contributing!

Thanks @michaelklishin for your help with this.
To pick up the new march_hare version 4.1.1, a simple plugin update should do the trick. For example, with versions verifications, from logstash home:
$ grep -e logstash-mixin-rabbitmq_connection -e march_hare Gemfile.lock
      logstash-mixin-rabbitmq_connection (>= 5.0.0, < 6.0.0)
    logstash-mixin-rabbitmq_connection (5.0.2-java)
      march_hare (~> 3.0)
      logstash-mixin-rabbitmq_connection (>= 5.0.0, < 6.0.0)
    march_hare (3.1.1-java)

$ bin/logstash-plugin update logstash-input-rabbitmq logstash-output-rabbitmq
Updating logstash-input-rabbitmq, logstash-output-rabbitmq
No plugin updated

$ grep -e logstash-mixin-rabbitmq_connection -e march_hare Gemfile.lock
      logstash-mixin-rabbitmq_connection (>= 5.0.0, < 6.0.0)
    logstash-mixin-rabbitmq_connection (5.1.0-java)
      march_hare (~> 4.0)
      logstash-mixin-rabbitmq_connection (>= 5.0.0, < 6.0.0)
    march_hare (4.1.1-java)

Closing.


fix: require-storageclass policy

Related Issue(s)
Fixes #617
Description
Enhance Require StorageClass policy to only require storageClassName if the StatefulSet has volumeClaimTemplates.
Checklist

[x] I have read the policy contribution guidelines.
[x] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
[x] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

@chipzoller please take a look

@chipzoller I was wondering what that file was for 😄
Information about the digest is well hidden. I assume this snippet is what is needed:
https://github.com/kyverno/policies/pull/597#issuecomment-1532230662
I suggest adding this as a validation check, similar to DCO. When it fails, the submitter can copy the expected digest from the failure message and paste it into their PR.

@chipzoller PTAL


Update documentation

Hello,
Raymond gives me the link of your project to prepare a official training session.
I just begin to use it. Maybe I am wrong about this PR.
Thanks you very much.
Best regards

Good catch - Thanks!


Removed deprecated lifecycle methods

Removed componentWillReceiveProps and componentWillUpdate from the list of lifecycle methods since they are now deprecated.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

@tiagosalema Thank you for your contribution to the page! :+1:
We're happy to accept these changes, and look forward to future contributions. :memo:

@thecodingaviator and @ojeytonwilliams The problem with removing these methods is that we currently have a challenge which campers use one or more of these methods.

Good point.  Perhaps we should just remove that challenge.  There's also a challenge that has componentWillReceiveProps, but doesn't use it, so I think it's safe to simply cut those bits out.

I propose the same, I think we can have a PR to remove the challenge altogether

Let's create an issue first, so we can discuss before we start removing stuff from the curriculum.


Add: transcribee & whisper-diarization

By submitting this pull request, I promise I have read the contribution guidelines twice and made sure my submission follows it.
⬆⬆⬆⬆⬆⬆⬆⬆⬆⬆

Make an individual pull request for each suggestion.

https://github.com/sindresorhus/awesome-whisper/blob/main/contributing.md