server: fix enable/disable static nat if userdata is not supported

Description
This PR fixes #5824

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[x] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

clgtm, do we have a reason for this regression?

@DaanHoogland
the exception is thrown at
https://github.com/apache/cloudstack/blob/main/engine/schema/src/main/java/com/cloud/network/dao/NetworkServiceMapDaoImpl.java#L125-L127
        if (ntwkSvc == null) {
            throw new UnsupportedServiceException("Service " + service.getName() + " is not supported in the network id=" + networkId);
        }

removing the lines might also fix the issue. but it has large impact.
this PR has much smaller impact.

clgtm, do we have a reason for this regression?

@DaanHoogland
the exception is thrown at https://github.com/apache/cloudstack/blob/main/engine/schema/src/main/java/com/cloud/network/dao/NetworkServiceMapDaoImpl.java#L125-L127
        if (ntwkSvc == null) {
            throw new UnsupportedServiceException("Service " + service.getName() + " is not supported in the network id=" + networkId);
        }

removing the lines might also fix the issue. but it has large impact. this PR has much smaller impact.

I would agree @weizhouapache, I approve of this change and intuitively it is the best solution but still have some questions;

why is applyUserData called at all if it is not supported? and,
is this a regression that might have other unforeseen consequences?

It looks like it was introduced by 9c6b02fd8b2282ceb80a1b9205871a4e93a00682.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2128

clgtm, do we have a reason for this regression?

@DaanHoogland
the exception is thrown at https://github.com/apache/cloudstack/blob/main/engine/schema/src/main/java/com/cloud/network/dao/NetworkServiceMapDaoImpl.java#L125-L127
        if (ntwkSvc == null) {
            throw new UnsupportedServiceException("Service " + service.getName() + " is not supported in the network id=" + networkId);
        }

removing the lines might also fix the issue. but it has large impact. this PR has much smaller impact.

I would agree @weizhouapache, I approve of this change and intuitively it is the best solution but still have some questions;

why is applyUserData called at all if it is not supported? and,
is this a regression that might have other unforeseen consequences?

It looks like it was introduced by 9c6b02f.

@DaanHoogland
when enable/disable static nat, the public IP of the vm needs to also updated in userdata server (=VR).
by default, VM public IP is source nat IP. if static nat is enabled, VM public IP is the static nat IP.
that's why we apply userdata of the vm/nic.
you might have also noticed that there are already check below in code
        if (element == null) {
            s_logger.error("Can't find network element for " + Service.UserData.getName() + " provider needed for UserData update");

if element cannot be found, then do not apply userdata. but the exception is thrown in Dao (I think it is not a good idea)
I have no idea if there are other issues  caused by the code in Dao I pasted above.
for enable/disable static nat, both should work no matter userdata is supported or not.

clgtm, do we have a reason for this regression?

@DaanHoogland
the exception is thrown at https://github.com/apache/cloudstack/blob/main/engine/schema/src/main/java/com/cloud/network/dao/NetworkServiceMapDaoImpl.java#L125-L127
        if (ntwkSvc == null) {
            throw new UnsupportedServiceException("Service " + service.getName() + " is not supported in the network id=" + networkId);
        }

removing the lines might also fix the issue. but it has large impact. this PR has much smaller impact.

I would agree @weizhouapache, I approve of this change and intuitively it is the best solution but still have some questions;

why is applyUserData called at all if it is not supported? and,
is this a regression that might have other unforeseen consequences?

It looks like it was introduced by 9c6b02f.

@DaanHoogland when enable/disable static nat, the public IP of the vm needs to also updated in userdata server (=VR). by default, VM public IP is source nat IP. if static nat is enabled, VM public IP is the static nat IP. that's why we apply userdata of the vm/nic.
you might have also noticed that there are already check below in code
        if (element == null) {
            s_logger.error("Can't find network element for " + Service.UserData.getName() + " provider needed for UserData update");

if element cannot be found, then do not apply userdata. but the exception is thrown in Dao (I think it is not a good idea)
I have no idea if there are other issues caused by the code in Dao I pasted above. for enable/disable static nat, both should work no matter userdata is supported or not.

I get it @weizhouapache , as discussed of line applyUserData should be renamed to applyUserDataIfNeeded. I thought it should not have been invoked in the first place, if it is harmfull. Your solution is good, thanks.

I get it @weizhouapache , as discussed of line applyUserData should be renamed to applyUserDataIfNeeded. I thought it should not have been invoked in the first place, if it is harmfull. Your solution is good, thanks.

@DaanHoogland thanks.
Renamed the method as per your comment.

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15.  I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2137

@blueorangutan package

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2159

@blueorangutan test

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2844)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30953 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5839-t2844-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File


Add block comment example and remove whitespace

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Thank you @dylanrainwater for your contribution and congratulations on your first PR merge to this repo! 🎉
Hope to see more contributions from you in the future.


Diffing provenance records

Coverage remained the same at 87.319% when pulling 5717438c8cfecea6660eefee607c749406097ded on comparison into 0671f9a68b30e4eb778029335e2960205b4e2ec0 on master.


Chore/remove deepmerge types

Fixes https://github.com/open-wc/open-wc/issues/634

I would recommend to make them fixes so they show up in the changelog (always good for dependency changes)

I've changed it, but is there some way to make chore end up in the changelog? These aren't really bugfixes.


Yanked from RubyGems

This gem was yanked off RubyGems (http://rubygems.org/gems/jshint)
Will this be reappearing?

GIven that the gem was horribly and embarrassingly broken I decided to yank it from RubyGems. It just didn't worth being there, only to disappoint Ruby developers.
I'm going to take a look at it but it's quite likely that the gem will come back in a totally different form.
Unless anyone wants to maintain and fix the previous issues I've done with my first ever released gem...

@liquid, I just grabbed this from my gems directory to host here temporarily. I'd rather not maintain it long term, especially if you are working on an improved version. That said, we can use github to host a working version for the time being. A semi-broken gem is better than no gem, IMO.


[main] Update actions

Cron -knative-prow-robot
/cc knative-sandbox/eventing-writers knative-sandbox/serving-writers
/assign knative-sandbox/eventing-writers knative-sandbox/serving-writers
Produced by: knative-sandbox/knobots/actions/update-actions
Details:

/lgtm
/approve


TODO steps in the Readme for Imagenet example.

The steps for running Imagenet example have the line "Tar the validation files by running" followed by a TODO note. However, at the ImageNet site, ILSVRC2012_img_val.tar file is directly available.
Does anymore preprocessing need to be done, or can it be directly uploaded to S3.
Similarly for the train data, there are two tars available at the Imagenet site
Training images (Task 1 & 2). 138GB.
Training images (Task 3). 728MB.
It is not clear from the Readme which tar to exactly use for this example.
Could you please shed some light on the above two points. If it seems a fair point, upon getting the clarification, if needed I will be interested in making this change to the Readme as a small contribution.

Hi Rahul,
Thanks for the comment! We need to clarify the instructions. In its current form, the following instructions are a bit verbose to put directly in the README, but for now, perhaps you could submit a pull request that replaces the relevant portions of the README with a reference to this issue? Also, if you have any ideas for simplifying this procedure, we'd appreciate that! We do the following:
Training Data

Download the training data wget {URL}/ILSVRC2012_img_train.tar.
Untar the training data tar xvf /imgnet/ILSVRC2012_img_train.tar. This should give you about 1000 tar files, each of which is around 200MB.
(Optional) - Shuffle the training data, that is, untar the tar files, shuffle the images, and retar them in a way that preserves the original structure. We do this because the training data is unshuffled (images of the same class appear consecutively).
Upload these tar files to S3 under s3://sparknet/ILSVRC2012_train/.

Retar the validation data to create a bunch of tar files, each with size 200MB. We do this because it is faster to pull a small number of large files from S3 than to pull a large number of small files.
tar -c  -M --tape-length=200M --file /tmp/pseudo-tape.tar --new-volume-script=/tmp/new-volume.sh --volno-file=/tmp/volno /imagenet/*.JPEG
mv pseudo-tape.tar val.33.tar

where new-volume.sh is:
    dir="/tmp"     base_name="pseudo-tape.tar"     next_volume_name=`echo -n "validation."; cat $dir/volno`     echo "moving $dir/$base_name to $dir/$next_volume_name.tar"     mv "$dir/$base_name" "$dir/$next_volume_name.tar"
4. Upload these tar files to S3 under s3://sparknet/ILSVRC2012_test/.
Labels

Run this caffe script https://github.com/BVLC/caffe/blob/master/data/ilsvrc12/get_ilsvrc_aux.sh to obtain auxiliary information for the ImageNet dataset. The training labels are in train.txt and the validation labels are in val.txt.
Upload train.txt to S3 under s3://sparknet/train.txt.
Upload val.txt to S3 under s3://sparknet/test.txt. Note that we switched the filename, which was probably a bad idea.

Note we use the S3 bucket name sparknet throughout, so you will probably need to change this in your code.

Hello Robert,
Thank you for your detailed response. As you said, for now I will put a reference to this issue in the Readme and submit a pull request.
The command and script for packing the files into multiple tars did not work for me, as it gave an error that the arguments are too long. So instead I used a script to create subdirectories with around 2000 images each and then 'tar' ed each of these subdirectories. This created 25 tars with size around 250 MB.
Thanks,
Rahul

Excellent, glad to hear that worked!


added graph conv.

@sauravpandey123 When you get back to this, can you use the Parameter Operations instead? Thank you 🙇


Rename jquery-cdn to jquery in the enqueue scripts

This needs to be renamed so that the plugins who depend on jquery (from the core) will still work.

fixed in new PR


[FLINK-6300] Use 'exec' in start-foreground calls

To avoid signal-handling issues in Docker, applications need to run as
a single executable or use a process manager that forwards signals
correctly, in either case running as PID 1.
Since Flink uses a number of chained scripts before the ultimate call
to java, we need to use exec so that the script executable is
replaced, ultimately resulting in a single java process as PID 1.
There's no need to run a process manager since Flink only actually
requires a single process.
Note: As there has not been a Flink release since these codepaths were introduced, I'm comfortable with merging this change for 1.2.1 since my manual testing was successful.

cc @greghogan, fyi

+1

+1 (seems to work nicely, as expected)

@greghogan do you think you could merge this? (also to 1.2.1)
If not I can try to rope in someone else.

@patricklucas yes, had just come back to say that :)

Great, thanks!


⚠ Maple - Access Portal has degraded performance

In b825b09, Maple - Access Portal (https://maple.zyradyl.moe) experienced degraded performance:

HTTP code: 200
Response time: 29349 ms

Resolved: Maple - Access Portal performance has improved in e39780f after 14 minutes.


Update docs examples to use render instead of render_to_response

Using render_to_response is discouraged in the Django docs. This patch changes the examples to use render instead.

Yep. We'll have that. Thanks!


Update/zio2

Move to ZIO 2.0.0, fix compile issues and tests

@atooni I will be working on #1315 to finally support ZIO 2.0.
We will merge it into main now instead of having two versions.

Ok - I will close my PR for now. Feel free to cherry pick whatever you may find useful.

In my branch I got the migration and have only two failing tests - perhaps you find this helpful


Webcam stream and Reverse Proxy

Hi Gaston,
Firstly I really enjoy OctoPod and use it regularly. The new UI refresh is excellent too.
Before raising an issue, I have been through the FAQs and current open/closed issues looking for the problem I am having. I couldn't see anything related. If I missed it, I'll close this issue.
I have just configured a reverse proxy so I can access services such as OctoPrint remotely for convenience. After setting up OctoPrint WebUI to handle the reverse proxy subdomain. I changed the Stream URL to '/octoprint/webcam/?action=stream' this is to allow for the webcam subdomain redirection. Everything works as expected for the OctoPrint WebUI.
I configured OctoPod to access OctoPrint, it connects fine and I have control of the printer. The only thing that doesn't function is the webcam stream. I get a 'Request error. HTTP response: 404'
I also notice that the webcam stream url is 'https://domainname.org/octoprint/octoprint/webcam/?action=stream'.  I feel it should be 'https://domainname.org/octoprint/webcam/?action=stream' which I tested this url in a browser and the webcam stream loads.

When I reverted the Stream URL back to '/webcam/?action=stream' on OctoPrint the webcam stream works as expected on OctoPod, but doesn't on OctoPrint WebUI.
I did read ticket https://github.com/gdombiak/OctoPod/issues/61 about not hard coding and using the api/settings. I think in this case hard coding would work better for me.
Do you have any possible solutions with how the api settings are read? Is there anything I'm missing or could try and/or change?

Thanks Phil for the detailed report. That double octoprint in the path is certainly suspicious. As you may know, when the MultiCam plugin is not installed (your case I think) then the URL to the webcam is treated like this in OctoPod:

camera URL = [The URL that you specified for your printer in OctoPod] + [cameraPath]

where cameraPath is what you defined in .octoprint/config.yaml under webcam -> stream. If that setting does not exist then it will default to /webcam/?action=stream.
So let's say that your printer URL in OctoPod is https://domainname.org/octoprint/ and your config.yaml has /octoprint/webcam/?action=stream, then the camera URL will end up https://domainname.org/octoprint/octoprint/webcam/?action=stream. I think this is your case.
Having said all this, I'm not clear how you are using the path octoprint in your setup. Is it only something that exists in your reverse proxy? If yes then config.yaml should have webcam/?action=stream in webcam->stream and then in your reverse proxy you will need to redirect to the proper URI. For instance, if your public URL is _https://domainname.org/octoprint_ and the internal hostname of your OctoPrint instance is octopi.local then you can have a forward to the internal hostname. If you are using haproxy then look at the acl command.
Hope this makes sense.
Gaston

Hi Gaston,
Thanks for getting back to my inquiry so quickly.
I fully understand what you are saying and I was definitely on the right path. I've found through forums most people who do a reverse proxy for OctoPrint sit it on the root name space. Because I made a sub path for OctoPrint eg https://domainname.org/octoprint this made things tricky with adding the webcam as a further sub path.
After loosing another day playing/learning HAProxy I found out by putting the whole name space in the config.yaml (https://domainname.org/octoprint/webcam/?action=stream) worked. I was blown away!
These are the changes I made to /etc/haproxy/haproxy.cfg
frontend public
        bind :::80 v4v6
        bind :::443 v4v6 ssl crt /etc/ssl/snakeoil.pem
        option forwardfor except <IP_ADDRESS>
        use_backend webcam if { path_beg /octoprint/webcam }
        default_backend octoprint

backend octoprint
        acl needs_scheme req.hdr_cnt(X-Scheme) eq 0
        reqrep ^([^\ :]*)\ /octoprint/(.*) \1\ /\2
        reqadd X-Script-Name:\ /octoprint
        reqadd X-Scheme:\ https if needs_scheme { ssl_fc }
        reqadd X-Scheme:\ http if needs_scheme !{ ssl_fc }
        option forwardfor
        server octoprint1 <IP_ADDRESS>:5000
        errorfile 503 /etc/haproxy/errors/503-no-octoprint.http

backend webcam
        reqrep ^([^\ :]*)\ /octoprint/webcam/(.*)   \1\ /\2
        server webcam1  <IP_ADDRESS>:8080
        errorfile 503 /etc/haproxy/errors/503-no-webcam.http

I wanted to explain what I did so if anyone else comes across the issues I had, this can hopefully help them out.

Hey Phil,
Great to hear that you figured it out. Thanks so much for sharing your setup so others can use it in the future.
Can we close this ticket now?

Sure can and thanks again!


[Impeller] Have a rough concept of a frame interval.

Impeller doesn't have the concept of a frame. However, a rough idea of a single frame interval elapsing would be useful in making decisions around resource pooling and reuse.
Today, such a thing already exists somewhat in the Vulkan backend. Since the context owns a swapchain, everytime a swapchain image requested, we equate that event to the previous frame interval elapsing.
We can generalize this concept to all backends and make some pooling be part of the HAL in an backend agnostic manner.

cc @bdero @jonahwilliams

We have a rough concept of a frame interval now.


UNDERTOW-1210 mod_cluster NodePingUtil ping request must contain host header

RFC 2616 (Hypertext Transfer Protocol - HTTP/1.1) dictates that a client that sends an HTTP/1.1 request MUST send a Host header.

Windows Build 2230 outcome was FAILURE using a merge of a303a2ee2d3514eb457489a5466ccf5223502f64
Summary: Tests passed: 2971, ignored: 613; exit code 1 Build time: 00:38:31

I have fixed this in a slightly different way (I create a new request instance each time and get the appropriate host for the connection)

Your fix (https://github.com/undertow-io/undertow/commit/69217f134bb33f6bb1d15abab33d2a54e4a5dbe1) is even better, thanks!


Add Windows Support

Adds Windows support via netsh.exe, as described in issue #5.

superseded by #25


modified query to generate the results as expected

Modified the query to output the results as represented in the image attached with the question.

Thank you!


Support multiple images

We currently only support a single image per deployment. We should support multiple images instead, and integrate that with kubespawner profiles somehow.

I was thinking about something related in https://github.com/pangeo-data/dev.pangeo.io-deploy/issues/56.
For a production cluster, it seems important to have a certain level of persistence and versioning of the images. Like, if I am using a container named gcr.io/pangeo-181919/ocean-pangeo-io-notebook:327e7f6, I should always have the option to launch that same container, even if new ones come out. This allows to maintain long-term backwards compatibility.
An alternative would be to address this at the jupyter kernel level. This is how we do it on standard, non-cloud-based jupyterhubs. We just keep making new kernels, but don't delete the old ones.

Looks like this issue will get some newfound attention. So hubploy.yaml defines images as a top-level section of the configuration. It would be easy to change that to a map and have several entries.
The image building would probably need another parameter to figure out which image to build. It could also have an option to build all of them in order.
I'm guessing the harder part will be how to inject this into the JupyterHub config. @yuvipanda do you have some suggestions on how to fiddle with this? I'm seeing that hubploy currently defines the path jupyterhub.singleuser.image in class LocalImage of config.py. We could make a new class / extend that class to structure a map that is assigned as the value of the profileList.
We might also want to setup some way to pass in prebuilt Docker images that hubploy doesn't have to build but still needs to put in profileLIst.


Unable to build project

I got this error on Fedora35

Task :multik-openblas:build_cmake FAILED
[ 53%] Built target openblas
Consolidate compiler generated dependencies of target multik_jni-linuxX64
gmake[3]: *** No rule to make target '/libquadmath.a', needed by 'libmultik_jni-linuxX64.so'.  Stop.
gmake[2]: *** [CMakeFiles/Makefile2:111: CMakeFiles/multik_jni-linuxX64.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:118: CMakeFiles/multik_jni-linuxX64.dir/rule] Error 2
gmake: *** [Makefile:137: multik_jni-linuxX64] Error 2

cmake version 3.22.2
gcc (GCC) 11.3.1 20220421 (Red Hat 11.3.1-2)
GNU Fortran (GCC) 11.3.1 20220421 (Red Hat 11.3.1-2)

To build a native library, you need to link with libquadmath.
set the GCC_LIB_Path environment variable with the path to the gcc (`export GCC_LIB_Path=[path to libs of gcc]) libraries or pass it in the script.

Thanks. That solved the problem.


GenericArguments[5], 'SecondHandWeb.Areas.Identity.Data.SecondHandWebUserRole', on 'Microsoft.AspNetCore.Identity.EntityFrameworkCore.UserStore`9[TUser,TRole,TContext,TKey,TUserClaim,TUserRole,TUserLogin,TUserToken,TRoleClaim]' violates the constraint of type 'TUserRole'.

Hi,
i have followed your instructions to extent the IdenityUserRole class (and some other),
for IdentityUserRole I receive the error below, when
services.AddIdentity<SecondHandWebUser, SecondHandWebRole>( ) is called in IdentityHostingStartup
The error message is:
GenericArguments[5], 'SecondHandWeb.Areas.Identity.Data.SecondHandWebUserRole', on 'Microsoft.AspNetCore.Identity.EntityFrameworkCore.UserStore`9[TUser,TRole,TContext,TKey,TUserClaim,TUserRole,TUserLogin,TUserToken,TRoleClaim]' violates the constraint of type 'TUserRole'.
my extension works for classes IdentityUser and IdentityRole.
here is the declaration of my ConextClass:
public class SecondHandWebContext : IdentityDbContext<SecondHandWebUser, IdentityRole, string, IdentityUserClaim, SecondHandWebUserRole, IdentityUserLogin, IdentityRoleClaim, IdentityUserToken>
here is my IdentityUserRole Classe:
public class SecondHandWebUserRole:IdentityUserRole..
it turn out, thas this error occurs,when the constructor
public SecondHandWebUserRole(SecondHandWebContext context, UserManager userManager)
is called.
I am using Nuget-Pakage Microsoft.AspNetCore.Identity.EntityFrameworkCore 5.0
what is wrong with my code??
Kind regards,
Martin
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d9869895-9ba2-5027-46cd-89d1d995cba4
Version Independent ID: 8750939b-6ae5-3b9a-6c32-5e84b7fea22c
Content: Identity model customization in ASP.NET Core
Content Source: aspnetcore/security/authentication/customize-identity-model.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @ajcvickers
Microsoft Alias: avickers

Without the example code it's hard to say what's going on. If you could upload a small repo that would be great, @ajcvickers can probably figure out the EF error after that.

Without the example code it's hard to say what's going on. If you could upload a small repo that would be great, @ajcvickers can probably figure out the EF error after that.

Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog clean. If you believe there is a concern related to the ASP.NET Core which hasn't been addressed, please file a new issue.


Move "Client is not connected" error to it's own exception

Create a custom exception to be able to catch the specific case when the mqtt client is not connected without having to compare the error message comparing strings.
In my application I am catching this type of exception and returning a custom localized error message so I have to catch the more generic MqttCommunicationException exception and compare the exception message for "The client is not connected." string, moving this error to it's own exception makes the solution much more elegant, hope it would be useful to others too.

@dotnet-policy-service agree


[FLINK-19675][python] Fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time

What is the purpose of the change
This pull request fix PythonCalcExpandProjectRule to handle cases when the calc node contains WHERE clause, composite fields access and Python UDF at the same time
Brief change log

Fix rule PythonCalcExpandProjectRule

Verifying this change
This change added tests and can be verified as follows:

Added tests testPythonFunctionMixedWithJavaFunctionInWhereClause

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@flinkbot run azure

@HuangXingBo Thanks a lot for the review. Merging...


Code that automatically arranges tables

Hi, can you please point me to the code that calculates the automatic layout of tables?

If it's about table alignment, here it is.

Perfect, thank you!


Engineering - Add storage account URLs to build assets

In order to be able to serve some of our build assets directly from the storage account, we want to add the storage account locations to the build assets.

Converting to draft for now.


added tests

Added tests for DebugProgress class and ParsingErrors class

Codecov Report

Merging #177 (4834c41) into main (83dfdfc) will increase coverage by 1.42%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #177      +/-   ##
============================================
+ Coverage     91.47%   92.89%   +1.42%
  Complexity      278      278
============================================
  Files            50       50
  Lines           704      704
============================================
+ Hits            644      654      +10
+ Misses           60       50      -10

Impacted Files
Coverage Δ

src/Rules/ParsingErrors.php
85.71% <0.00%> (+9.52%)
:arrow_up:

src/CLI/Progress/DebugProgress.php
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83dfdfc...4834c41. Read the comment docs.


Preserve TypeAliasType sugar when substituting types

Fixes rdar://problem/45313760.

@DougGregor There are a few places where we previously built TypeAliasType by hand; those can be simplified now because they shouldn't be needed. But I was running into a few problems so I think this part can land separately.

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility Release

https://github.com/apple/swift-lldb/pull/2014
@swift-ci Please smoke test


[k8s] Add ws proxy mode

ws proxymode is required for websocket services. This PR adds that mode and tidies up the makefile so you don't have to copy round the sidecar binary

Hmm, something is busted in the build. I think it has to do with when the Makefile was made. It should go build && cd docker && ./build.sh

Hmm, something is busted in the build. I think it has to do with when the Makefile was made. It should GOOS=linux go build && cd docker && ./build.sh

I'll try this


UiPoolDataProvider.getReservesHumanized() throws error on accessing reserveRaw.eModeLabel

Bug Report
After updating @aave/contract-helpers from 1.7.0 to 1.13.2
If I'm connecting to ethereum mainnet, ethreum goerli, polygon mainnet and using aave v2 contracts (or v3 contracts on polygon) to initialize poolDataProviderContract like so
const poolDataProviderContract = new UiPoolDataProvider({
      '0x30375522F67a6308630d49A694ca1491fA2D3BC6',
      new ethers.providers.JsonRpcProvider(
        'https://mainnet.infura.io/v3/<projectId>',
      ),
      1,
    });

and then calling
const reserves = await poolDataProviderContract.getReservesHumanized({
      '0xB53C1a33016B2DC2fF3653530bfF1848a515c8c5',
    })

the UiPoolDataProvider.getReservesHumanized() method in node_modules.pnpm@aave+contract-helpers<EMAIL_ADDRESS>is throwing an error when it's trying to read
reserveRaw.eModeLabel.toString();

The only case when the latest package version works on my end is when I'm using aave v3 contracts on goerli or polygon-mumbai. eModeLabel returns either empty string or 'Stablecoins'.
But both aave v2 & v3 contracts on mainnets started throwing this error.
I'm assuming smth has changed either only in the v3 contracts on testnets (which would be weird) or smth ir not properly handling this property "eModeLabel" in the package.
When console.logging the reserveRaw object inside the getReservesHumanized() method when testing with v2 contracts it's showing as [Getter]

I could suggest a PR with a try catch block as a hot fix but would assume you guys might come up with a more elegant solution once I report about this problem.
Or someone could point me what I could be doing wrong.
Thank you!

OS: [e.g., OSX 10.13.4, Windows 10]
Node/npm version: [e.g., Node 8/npm 5]
Browser: [e.g., Chrome]

I also pulled the aave-utilities package to reproduce the issue and do have same kind of exception

Please bump the version to 1.13.3 (fixes a typing issue), then it should be compatible with all of the V2 and V3 addresses listed here: https://github.com/aave/interface/blob/main/src/ui-config/marketsConfig.tsx

0x30375522F67a6308630d49A694ca1491fA2D3BC6

hi defispartan!
thank you for your reply! i'll update the package and will provide feedback.
i'm also noticing that UI_POOL_DATA_PROVIDERs seem to have been changed within the last ~2 months bc i have different addresses in my local code.
e.g. i'm using 0x30375522F67a6308630d49A694ca1491fA2D3BC6 as the UI_POOL_DATA_PROVIDER for v2 on ethereum,
but at the moment the right one is 0x00e50FAB64eBB37b87df06Aa46b8B35d5f1A4e1A
And this change has caught me off guard.

Please bump the version to 1.13.3 (fixes a typing issue), then it should be compatible with all of the V2 and V3 addresses listed here: https://github.com/aave/interface/blob/main/src/ui-config/marketsConfig.tsx

hi defispartan!
thank you for your reply! i'll update the package and will provide feedback.
i'm also noticing that UI_POOL_DATA_PROVIDERs seem to have been changed within the last ~2 months bc i have different addresses in my local code.
e.g. i'm using 0x30375522F67a6308630d49A694ca1491fA2D3BC6 as the UI_POOL_DATA_PROVIDER for v2 on ethereum,
but at the moment the right one is 0x00e50FAB64eBB37b87df06Aa46b8B35d5f1A4e1A
And this change has caught me off guard.

I have just updated the packages to 1.13.3 and changed UI_POOL_DATA_PROVIDERs for v2 and v3 for all networks that i'm using and it solved the problem! 👍
thank you!


[SN 2003aa] Ic, not Ia

@guillochon So it turns out this one was being flagged as a Ia, when it's a Ic.
SUPERNOVA 2003aa IN NGC 3367
Further to IAUC 8063, T. Matheson, P. Challis, and R. Kirshner
report that a spectrum (range 370-750 nm) of SN 2003aa (cf. IAUC
8063), obtained by P. Berlind with the 1.5-m reflector on Feb. 2.31
UT, shows it to be a type-Ic supernova.  The spectrum is similar to
that of SN 1994I, four days before maximum (Filippenko et al. 1995,
Ap.J. 450, L11).
I flagged the claimedtype of Ia as erroneous and wanted to update the value to Ic. I thought I could do this via the pencil icon but then got an error. What did I miss?

So the pencil links only update after an import has been performed, so if
you try to do two different actions in a row on the same event before the
next import, you'll get an error because a file was created already by the
first action.
Easiest thing to do is just copy the JSON into the already existing file in
sne-internal. All changes will be caught in the next import.
On Sun, May 29, 2016 at 2:05 PM, J. Parrent<EMAIL_ADDRESS>wrote:

@guillochon https://github.com/guillochon So it turns out this one was
being flagged as a Ia, when it's a Ic.
SUPERNOVA 2003aa IN NGC 3367
Further to IAUC 8063, T. Matheson, P. Challis, and R. Kirshner
report that a spectrum (range 370-750 nm) of SN 2003aa (cf. IAUC
8063), obtained by P. Berlind with the 1.5-m reflector on Feb. 2.31
UT, shows it to be a type-Ic supernova. The spectrum is similar to
that of SN 1994I, four days before maximum (Filippenko et al. 1995,
Ap.J. 450, L11).
I flagged the claimedtype of Ia as erroneous and wanted to update the
value to Ic. I thought I could do this via the pencil icon but then got an
error. What did I miss?
[image: screen shot 2016-05-29 at 2 02 17 pm]
https://cloud.githubusercontent.com/assets/7276612/15635206/547634de-25a6-11e6-93cb-c28a774a0988.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/astrocatalogs/sne/issues/41, or mute the thread
https://github.com/notifications/unsubscribe/AExDqtJXg0W7p24-qRwIOwfYjmQqDJTjks5qGdWEgaJpZM4IpV9G
.

--
James Guillochon
Einstein Fellow at the Harvard-Smithsonian CfA
<EMAIL_ADDRESS>

Got it. Thanks!


"See an example" gives 404 not found

Hi, I noticed this broken link in readme.md

fixed ...
and for the price : i've added 2 examples ... ;-)

one in html only (pyscript runner)
one with python (webhttp runner)

thanks


Check error in intero-project-root function

When the stack command used intero-project-root fails, it set the variable intero-project-root to the error output.
And given that some intero functions use the intero-project-root as default-directory, Emacs throws cd: No such directory found via CDPATH environment variable

Good catch! I'll fix.

Thanks!


2016: do not add BMFF when not using ClearKey

I guess this issue happens in more cases, not only 2016.
I am trying PlayReadyH264Video EME test in 2016 and I found that the key does not get generated because of a failure in that place. There's a JS error inside that if and that stops running, therefore the key does not get generated.
Another "funny" thing is that I am getting a 500 error from the server when the key is generated. Is everything ok there?

Are you still getting 500 errors for the license server? I haven't been able to reproduce that.
Specifically, what js errors are you getting? Maybe we should fix the js errors instead of covering them up.

Yes, I am still getting the 500 errors from the license server.
About the errors:
mstest/js/lib/eme/encryptedMediaPortability.js:173:19: CONSOLE ERROR TypeError: First argument should be an object
clearkeyId is null cause this.licenseManager.kids[0] is null.
Avoid the cover up, considering the code comment:
// Add clear key id to initData for gecko based browsers.
I think avoiding entering that part is ok for non ClearKey tests or am I missing anything?

I'm going to treat this as a bug report. I'll spend some time analyzing the failure today.
Maybe preventing entering this part of the code is the correct fix but the fact that you are getting 500s makes me think something else is broken.

I spent some time attempting to reproduce this issue. I was unable to. The initData should have the keys as expected for clearKey regardless if we need them or not. This points to a problem with the initData the UA is providing. I suspect that you are using a different EME version other than 0.1b. That would explain why your initData is not the expected initData.
I also was not able to reproduce the 500s on the license server. Can you provide more information with how you are running the tests or if you have made any modifications.
I would be happy to look into this further but I need some more information on the failure. A complete stacktrace would be helpful, information on the UA EME version, and information about the 500 on the license server.
At the moment I don't have an immediate issue with the fix you are proposing but I think it is a red herring for the problem you are experiencing. I'm closing this request as a result. Please feel free to file a bug report so we can analyze this problem further.


Power Platform considerations

Hi
When we have an D365 Finance and Supply Chain Management system and we are using Dual Write I believe there is an impact if the database refresh is undertaken. I believe that everything needs to be stopped and upon post-refresh all the re-linking is undertaken. I am not sure if there are other considerations with CDS or the Power Platform but I feel the consideration for Dual Write should be called out because if you do not stop the link then the database refresh will corrupt the environments.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d28e8cc-5110-f01b-db76-94479ec2fa91
Version Independent ID: f0710707-9ff2-84a1-30c7-1f0d44e3a0d7
Content: Refresh database - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/database/database-refresh.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @laneswenka
Microsoft Alias: laneswenka

Hi Steven!
We delete the CDS link tables during refresh so that UAT cannot talk to your CDS instance. You will need to manually relink to another CDS after refresh.
Lane
Sent from my iPhone
On May 21, 2020, at 3:08 AM, Steven Weaver<EMAIL_ADDRESS>wrote:

Hi
When we have an D365 Finance and Supply Chain Management system and we are using Dual Write I believe there is an impact if the database refresh is undertaken. I believe that everything needs to be stopped and upon post-refresh all the re-linking is undertaken. I am not sure if there are other considerations with CDS or the Power Platform but I feel the consideration for Dual Write should be called out because if you do not stop the link then the database refresh will corrupt the environments.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d28e8cc-5110-f01b-db76-94479ec2fa91
Version Independent ID: f0710707-9ff2-84a1-30c7-1f0d44e3a0d7
Content: Refresh database - Finance & Operations | Dynamics 365https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/database/database-refresh
Content Source: articles/fin-ops-core/dev-itpro/database/database-refresh.mdhttps://github.com/MicrosoftDocs/Dynamics-365-Unified-Operations-Public/blob/live/articles/fin-ops-core/dev-itpro/database/database-refresh.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @laneswenkahttps://github.com/laneswenka
Microsoft Alias: laneswenka

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/2427, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGKBZHIQZWIJY5MYVQBRWLRST4QRANCNFSM4NGW3K4Q.

Hi Lane
All good thanks, I hope you are keeping well.
My understanding is that if you don’t stop the CDS links and then do a refresh the system gets into a horrible position. This is feedback from the technical team on the process after they encountered this earlier this year trying to refresh the DB side of the process. On the DB refresh there is no reference to this, but I feel there should be if it is an issue, but perhaps I am misinterpreting the issue.
Are you saying that today a database refresh in a Dual Write configured environment is not an issue because the process now deletes the CDS links (even when running/connected), and there is a manual relink required, but no corruption of the FO instance as we encountered?
I can loop back in with the technical team to check again if that is the case?
I am trying to configure Dual Write and setup a checklist or considerations document for environment creation and management – I was told this was an issue by the team that previously tried to get it working 😊
Steve
From: Lane Swenka<EMAIL_ADDRESS>Sent: 21 May 2020 13:23
To: MicrosoftDocs/dynamics-365-unified-operations-public<EMAIL_ADDRESS>Cc: Steven Weaver<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/dynamics-365-unified-operations-public] Power Platform considerations (#2427)
Hi Steven!
We delete the CDS link tables during refresh so that UAT cannot talk to your CDS instance. You will need to manually relink to another CDS after refresh.
Lane
Sent from my iPhone
On May 21, 2020, at 3:08 AM, Steven Weaver <notifications<EMAIL_ADDRESS>wrote:

Hi
When we have an D365 Finance and Supply Chain Management system and we are using Dual Write I believe there is an impact if the database refresh is undertaken. I believe that everything needs to be stopped and upon post-refresh all the re-linking is undertaken. I am not sure if there are other considerations with CDS or the Power Platform but I feel the consideration for Dual Write should be called out because if you do not stop the link then the database refresh will corrupt the environments.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d28e8cc-5110-f01b-db76-94479ec2fa91
Version Independent ID: f0710707-9ff2-84a1-30c7-1f0d44e3a0d7
Content: Refresh database - Finance & Operations | Dynamics 365https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/database/database-refresh
Content Source: articles/fin-ops-core/dev-itpro/database/database-refresh.mdhttps://github.com/MicrosoftDocs/Dynamics-365-Unified-Operations-Public/blob/live/articles/fin-ops-core/dev-itpro/database/database-refresh.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @laneswenkahttps://github.com/laneswenka
Microsoft Alias: laneswenka

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/2427, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGKBZHIQZWIJY5MYVQBRWLRST4QRANCNFSM4NGW3K4Q.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/2427#issuecomment-632056225, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJY2U3WIXMVFQIT456IHPADRSUMJHANCNFSM4NGW3K4Q.

In a refresh with a dual write linked source and a non linked target, there shouldn’t be any issue.
We copy the source AXDB, delete its CDS tables which tell it how to talk to CDS, cleanup SMTP settings and so forth like normal, and then replace the AXDB in the target with it.
Now if your target is also linked to another CDS, it is possible you will want to unlink it prior so that it doesn’t continue to receive data that isn’t aligned.
If you have an ActivityID from a refresh that had issues please feel free to email me and we can investigate!  But in the simple scenario above it shouldn’t be an issue.
Lane
Sent from my iPhone
On May 21, 2020, at 5:30 AM, Steven Weaver<EMAIL_ADDRESS>wrote:

Hi Lane
All good thanks, I hope you are keeping well.
My understanding is that if you don’t stop the CDS links and then do a refresh the system gets into a horrible position. This is feedback from the technical team on the process after they encountered this earlier this year trying to refresh the DB side of the process. On the DB refresh there is no reference to this, but I feel there should be if it is an issue, but perhaps I am misinterpreting the issue.
Are you saying that today a database refresh in a Dual Write configured environment is not an issue because the process now deletes the CDS links (even when running/connected), and there is a manual relink required, but no corruption of the FO instance as we encountered?
I can loop back in with the technical team to check again if that is the case?
I am trying to configure Dual Write and setup a checklist or considerations document for environment creation and management – I was told this was an issue by the team that previously tried to get it working 😊
Steve
From: Lane Swenka<EMAIL_ADDRESS>Sent: 21 May 2020 13:23
To: MicrosoftDocs/dynamics-365-unified-operations-public<EMAIL_ADDRESS>Cc: Steven Weaver<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/dynamics-365-unified-operations-public] Power Platform considerations (#2427)
Hi Steven!
We delete the CDS link tables during refresh so that UAT cannot talk to your CDS instance. You will need to manually relink to another CDS after refresh.
Lane
Sent from my iPhone
On May 21, 2020, at 3:08 AM, Steven Weaver <notifications<EMAIL_ADDRESS>wrote:

Hi
When we have an D365 Finance and Supply Chain Management system and we are using Dual Write I believe there is an impact if the database refresh is undertaken. I believe that everything needs to be stopped and upon post-refresh all the re-linking is undertaken. I am not sure if there are other considerations with CDS or the Power Platform but I feel the consideration for Dual Write should be called out because if you do not stop the link then the database refresh will corrupt the environments.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d28e8cc-5110-f01b-db76-94479ec2fa91
Version Independent ID: f0710707-9ff2-84a1-30c7-1f0d44e3a0d7
Content: Refresh database - Finance & Operations | Dynamics 365https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/database/database-refresh
Content Source: articles/fin-ops-core/dev-itpro/database/database-refresh.mdhttps://github.com/MicrosoftDocs/Dynamics-365-Unified-Operations-Public/blob/live/articles/fin-ops-core/dev-itpro/database/database-refresh.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @laneswenkahttps://github.com/laneswenka
Microsoft Alias: laneswenka

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/2427, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGKBZHIQZWIJY5MYVQBRWLRST4QRANCNFSM4NGW3K4Q.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/2427#issuecomment-632056225, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJY2U3WIXMVFQIT456IHPADRSUMJHANCNFSM4NGW3K4Q.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/2427#issuecomment-632059089, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGKBZHFHJC7WINGM3EX22LRSUNEVANCNFSM4NGW3K4Q.

Hi Lane
This is our scenario – test is connected via dual write to a test CDS. We refresh from Prod. If we don’t unlink the Test Dual Write first,  dual write breaks and we needed to involve Microsoft support.
We also did a Point in Time restore to an environment with Dual Write connected and it made the environment unusable.
It is just a warning for scenarios that mean your environment ends up being unusable and you need to engage with Microsoft support, just looking to share that pain 😊
Steve
From: Lane Swenka<EMAIL_ADDRESS>Sent: 21 May 2020 13:23
To: MicrosoftDocs/dynamics-365-unified-operations-public<EMAIL_ADDRESS>Cc: Steven Weaver<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/dynamics-365-unified-operations-public] Power Platform considerations (#2427)
Hi Steven!
We delete the CDS link tables during refresh so that UAT cannot talk to your CDS instance. You will need to manually relink to another CDS after refresh.
Lane
Sent from my iPhone
On May 21, 2020, at 3:08 AM, Steven Weaver <notifications<EMAIL_ADDRESS>wrote:

Hi
When we have an D365 Finance and Supply Chain Management system and we are using Dual Write I believe there is an impact if the database refresh is undertaken. I believe that everything needs to be stopped and upon post-refresh all the re-linking is undertaken. I am not sure if there are other considerations with CDS or the Power Platform but I feel the consideration for Dual Write should be called out because if you do not stop the link then the database refresh will corrupt the environments.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d28e8cc-5110-f01b-db76-94479ec2fa91
Version Independent ID: f0710707-9ff2-84a1-30c7-1f0d44e3a0d7
Content: Refresh database - Finance & Operations | Dynamics 365https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/database/database-refresh
Content Source: articles/fin-ops-core/dev-itpro/database/database-refresh.mdhttps://github.com/MicrosoftDocs/Dynamics-365-Unified-Operations-Public/blob/live/articles/fin-ops-core/dev-itpro/database/database-refresh.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @laneswenkahttps://github.com/laneswenka
Microsoft Alias: laneswenka

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/2427, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGKBZHIQZWIJY5MYVQBRWLRST4QRANCNFSM4NGW3K4Q.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/2427#issuecomment-632056225, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJY2U3WIXMVFQIT456IHPADRSUMJHANCNFSM4NGW3K4Q.

This should not be the case but I am following up.  So your source is not linked correct? Just the target?

Also could you provide me an ActivityID or EnvironmentID where this has failed so that we can review?

Hi Lane
The environments no longer exist.
In summary for the context of this the page was “refreshing the DB”, If the target environment has Dual Write enabled, and we plan to replace the database (via restore in time, or restore from another database) then stop and unlink the entities first. Should that reference be made somewhere on the refresh database page to try and stop users hitting issues with the process when Dual Write is in the mix?
The technical team referenced you in response to my question for more information without knowing it was you I was talking to! You are aware of the process and asking how people are getting around it, I am just suggesting a reference on the refresh DB might be useful, but I will leave it up to you, feel free to close the request 😊
<EMAIL_ADDRESS>This is the  closest I could find now – there must have been something else in Yammer but I can’t get it now. Instruction boiled down to stop Dual Write before you replace the database from any source. And it made sense. Even if you do Point In Time restore you have to consider for every entity whether a new bulk update from X to Y is required after the update.
Oh – and update from Lane
<EMAIL_ADDRESS>https://www.yammer.com/dynamicsaxfeedbackprograms/#/Threads/show?threadId=684447363579904&search_origin=global&scoring=linear1Y-prankie-group-private-higher&match=any-exact&search_sort=relevance&page=1&group_ids=16038053&search=copy database
From: Lane Swenka<EMAIL_ADDRESS>Sent: 26 May 2020 18:26
To: MicrosoftDocs/dynamics-365-unified-operations-public<EMAIL_ADDRESS>Cc: Steven Weaver<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/dynamics-365-unified-operations-public] Power Platform considerations (#2427)
Also could you provide me an ActivityID or EnvironmentID where this has failed so that we can review?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/2427#issuecomment-634164685, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJY2U3QBQYKOWSFUGW5CV2LRTP3S7ANCNFSM4NGW3K4Q.


Write to a temp file when overwriting a session

Goal

Testing

Release Notes

WHAT:
WHY:
WHO:

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

#481  👈
#471 : 1 other dependent PR (#473 )
master

This stack of pull requests is managed by Graphite.

Merge activity

Mar 1, 5:31 PM EST: @bidetofevil started a stack merge that includes this pull request via Graphite.


CURRENT_FILE is not working for jupyter notebooks

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in pydtl-relativepath rather than my code.
[X] The bug is not resolved by updating to the latest stable version of pydtl-relativepath (or the specific integration package).

Description
I am trying to construct a relative path from jupyter notebook.
It produces path like this:

WindowsPath('C:/Users/nanthagopal.eswaran/AppData/Local/Temp/ipykernel_21004')

Reproduce Steps
sample code (cell within sample.ipynb)
from pydtl_relativepath import rel2abs, RelativePathType

test_plan_path = rel2abs("", relative_type=RelativePathType.RELATIVE_TO_CURRENT_FILE)

test_plan_path

Error Message and Stack Trace (if applicable)
N/A
System Info
Windows 10
python version: 3.11.6 (64-bit)
pydtl-relative_path: 0.2.0

Similarly RELATIVE_TO_WORKING_DIRECTORY is not working instead it returns the CURRENT FILE directory


Feature/ch122 update startup process

Some useful changes, I believe.

lr-run-app will now invoke .startup.sh and .teardown.sh scripts, if they are present
Nicer VM prompt
Some 'bug' fixes

lgtm :+1:

Yup. Looks good. :+1:
I'll have to see in action too.
Assume you've done several tests around destroying and creating from scratch.

"Assume you've done several tests around destroying and creating from scratch."
A few. Duplicate line fixed.


Enforce FHIR server interaction limitations in fhir-server REST layer

In https://github.com/IBM/FHIR/issues/1449 we introduced a new configuration property group called resources.
In this property group, server administrators can now configure which interactions and search parameters should show up for which resource types in the CapabilityStatement.
However, currently, this only drives the CapabilityStatement and not the actual behavior of the server.
It should be possible to enforce that configuration in the fhir-server REST layer, probably by isolating this logic in the FHIRRestHelper class so that it applies to batch/transaction entries as well.
This task is very similar to #1351 except that it should apply to the resource type interactions instead of the searches that are allowed.
There is also a related enhancement request #819 for supporting a subset of resources in the fhir-persistence-schema tool, so that we don't need to create and manage all the tables for resource types that don't need to be supported.

stretch goal for sprint 22

I verified this one by deploying a server with a list of resources with open=false and executing requests like:

POST [base]/Patient (where only read actions are supported for the Patient resource)
GET [base]/Claim (where Claim is not a supported resource type)
GET [base]/Patient/[id]/Claim (where Claim is not a supported resource type)

In each case, the server behaved as expected.

I verified this one by deploying a server with a list of resources with open=false and executing requests like:

POST [base]/Patient (where only read actions are supported for the Patient resource)
GET [base]/Claim (where Claim is not a supported resource type)
GET [base]/Patient/[id]/Claim (where Claim is not a supported resource type)

In each case, the server behaved as expected.


affected/package: package xxx  is not in std???

Recently, I met a problem regarding import local package even after using go mod and go work comand acording to the tutoral of official website.
I think may this problem is a bug because go work is useless!!
And I did not got any usful result from internet. So come here.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


Automatically Run task does not wait for postCreateCommand in a Dev Container

I use the postCreateCommand to install my packages in my dev container.
I'd like to run tasks automatically after the packages are installed.
However, using: "runOptions": { "runOn": "folderOpen" }, the tasks are run as soon as my container is up.

I'm facing the same issue

Same issue here.


releasing strategy for unresponsive and banned peers

NOTE: This PR is based on #25 - once that is merged this will be much simpler to review

will write tests once strategy is validated
defines two "bad peer" types:

unresponsive – retry count was exceeded
banned - peer has been banned

exposes queue options at top level
adds a new forget option to the queue options, where we can define ms wait before removing unresponsive or banned peers. Banned defaults to Infinity - e.g. banned peers are never forgotten by default.
tiny bit of refactoring to const

Looking solid! Asked a question, but that can be resolved later if complex also.


Return the native Mapbox view when show is invoked

.. so folks can tap into the native Mapbox SDK more easily (adding layers, etc as they see fit).

Also added examples to the readme and demo.


[BUG] [aria-hidden="true"] elements contain focusable descendants

Take a moment to review - is it really a bug? Or is it more of an enhancement or a typo in the documentation? A Bug is code that is broken, or when you try to implement a certain piece of code that is mentioned in the documentation, you have a result that is not the same as described.
Now if you are absolutely sure it is indeed a bug, please fill in the following template.
Mention what part of the design system the bug is related to
Is the bug part of a "Slider",
More context in relation to the design system
If the bug is part of a component or a block, please mention which one. If the bug is related to the plugin, please mention if it is during installation, compiling or configuration.
Describe the bug
A clear and concise description of what the bug is. Help us understand what you are doing that is causing an error.
To Reproduce
Steps to reproduce the behaviour:
Use the chrome lighthouse tool
Analysis the page
[aria-hidden="true"] elements contain focusable descendants
A clear and concise description of what you expected to happen.
A bit more context about the browser
Browser [e.g. chrome, safari]
Additional context
Add any other context about the problem here.

@Sa7aR-Kassem
There is nothing that is part of the components that forces a [aria-hidden="true"] except for icons.
When you add an icon (like an image or an svg) you want to put [aria-hidden="true"] on it, but this also means that you cannot make it clickable. If you are going to add a  on an html attribute, you cannot add [aria-hidden="true"]
Hence, anything that is clickable will have focus. You cannot mark it as hidden. If you want to hide something on a mobile, and display it on a desktop -- which is a clickable element, then you must ideally also hide the parent container.
Please share a screenshot of which block or component is reporting this error with a screenshot.

I wanted to inform you that you have the same issue in the Hero component, as shown in the attached screenshot. This issue seems to be present in this specific component, and I thought it would be helpful to point it out.
Please let me know if you need any further details or if I can assist in resolving this matter.

Hello @Sa7aR-Kassem
This is great, thank you for pointing this out. Moving this back to a bug status and involving @anismansuriui to the conversation.

Hello @moiz-conceptlz @anismansuriui
Do you have any recommendations for me?


Problem with generated classnames when more than 26 inline stylesheets are added to document

First: thank you very much for this fantastic library!
In my application, all components that require component specific styling include an object that extends "StyleSheet.Inline" inside the object that contains the component definition. The addToDocument() method is used to add the styles for each of these components to the document.
There is a problem when there are more than 26 components with an inline stylesheet.
When using ProdDefaults, the classnames that are generated for component 27, 28, 29 and 30 are "{0", "|0", "}0" and "~0" respectively. No styling is done for these classnames by the browser (invalid characters?). I tried Chrome and Firefox.
The problem is illustrated by the project code in the zipfile (unzip, open sbt, run fastOptJS and open "index.html" in your browser). The screenshot below shows the resulting page. Note that the styling of components 27, 28, 29, 30 and 31 is missing (no bar).
scala-css-issue.zip

I suspect the problem is somewhere around NameGen.short (perhaps nextShortPrefix?).
Questions:

Is the approach with adding a separate inline stylesheet per component that requires styling as intended, or should I have used a different pattern?
Should I perhaps try to setup a production configuration with a custom NameGen that for example starts using a two character prefix and an extra separator starting with stylesheet 27 (see below)? Or can the standard NameGen.short be adapted?

Regards,
Marc

Example alternative classnames:
1 _a0 or _a_0
2 _b0 or  _b_0
3 _c0 or  _c_0
...
26 _z0 or  _z_0
27 _ab_0
28 _ac_0
...
52 _az_0
53 _ba_0
54 _bb_0
...

Hi @vmarc , firstly thanks for the nice feedback.
I don't have a chance today to look at your sample code (awesome and thanks for providing it btw!).
But I did have time to inspect the CSS of one of the pages of my work project which uses ScalaCSS with > 26 styles.
In my case I'm using scalacss.devOrProdDefaults and it's working as expected, it goes from ._b0, ._b1 ... _b9 _ba ... _bz _b- b then rolls over to _b00 _b01 etc. Full CSS here: https://gist.github.com/japgolly/20c05ad864223909dbff6d057830bbba
It definitely shouldn't be using "|" and "{" in classnames. I wonder why it isn't in my project?

Hi, I've just today experienced the same issue after adding new inline stylesheets. Classnames are like
_{8
_{9

As far as I see this function is responsible for generating the prefixes in production:
scalacss.internal.mutable.Register.NameGen.short()
Calling it multiple times, e.g:
(1 to 30).map(_ => scalacss.internal.mutable.Register.NameGen.short().next(ClassNameHint("moin"))._1.value)
Outputs:
Vector(_a0, _b0, _c0, _d0, _e0, _f0, _g0, _h0, _i0, _j0, _k0, _l0, _m0, _n0, _o0, _p0, _q0, _r0, _s0, _t0, _u0, _v0, _w0, _x0, _y0, _z0, _{0, _|0, _}0, _~0)
I guess the problem is with:
scalacss.internal.mutable.Register.NameGen.nextShortPrefix()
Internally it's using
('a' + _nextShortPrefix).toChar
Where _nextShortPrefix is a growing integer, but from Int 26 on it's already not alphanumeric any more... E.g:
(1 to 30).map(_ => scalacss.internal.mutable.Register.NameGen.nextShortPrefix())
returns
Vector(a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p, q, r, s, t, u, v, w, x, y, z, {, |, }, ~)
I'm on 0.5.3 btw but seems code is identical to master.

Cheers

Thanks for digging in to that. I'm still really curious as to why I'm not experiencing this issue myself but I don't want to let my lack of time block this fix for anyone else. So yes please @an-tex , a PR would be appreciated and then I'll get a new release out ASAP.

While implementing and testing a fix I figured out why you didn't see the issue @japgolly . It's because the initial description was inaccurate, as the issue arises not with more than 26 styles within one StyleSheet.Inline, but if more than 26 StyleSheet.Inline are registered...
Anyway here's the PR https://github.com/japgolly/scalacss/pull/125

Ah, the makes sense. Thanks, merged!


Changing instances of ugettext, ugettext_lazy, ungettext, and force_unicode for Django 4.0

Hi,
I don't know if people running Django 4.0 will be using django-celery but I had to make some fixes to djcelery in order to get it working.
I had to delete the u from:

ugettext to just gettext
ugettext_lazy to just gettext_lazy
ungettext to use ngettext and then import it as ungettext to leave the rest of the code "reasonably unchanged".

Lastly I changed the force_unicode (force_text) import to import force_str as force_text
The files affected I think were:

djcelery/admin.py
djcelery/humanize.py
djcelery/models.py
djcelery/picklefield.py

It imports correctly now but I can keep you posted on if it breaks!

Hi,
I have changed files that you mention and did what you say, and now it throw an error like this :
File "/home/fariz/.virtualenvs/boxsurat/lib/python3.8/site-packages/djcelery/models.py", line 17, in
from .picklefield import PickledObjectField
File "/home/fariz/.virtualenvs/boxsurat/lib/python3.8/site-packages/djcelery/picklefield.py", line 22, in
from celery.five import with_metaclass
ModuleNotFoundError: No module named 'celery.five'

Hi,
I've been looking for a solution and doing this to got it working for a while but I don't know what effect I did
The files :

djcelery/admin.py
djcelery/picklefield.py

what I did:

remove from celery.five import with_metaclass
change from celery.app.control import broadcast, revoke, rate_limit to from celery.worker.control import revoke, rate_limit
change 'broadcast()' to self.app.control.broadcast()

I hope it can work well


Issues with auto splitter for How Fish Is Made

What features of the auto splitter don't work?
start, split
Describe your Issue

[x] The game has recently received an update.

If there is any especially weird behavior with the timer, please describe what is happening.
Seems like the new update broke it, I think it's something to due with how they changed the main menu.
Causes and Fixes
No response

Is this about "The last one and then another"?

The autosplitter is not working in the original game. Unrelated to the expansion, but probably due to the update that the expansion came with.

Could you give it another go? Make sure to restart LiveSplit and the game if they're running.

I'll be able to try it again in a few hours, I'll reply again with the results once I do.

Okay i was just able to try it, it's not starting the timer upon pressing play or splitting after the ragdoll section, i attached a video showing the behavior, first run through was seeing if the timer would start automatically, second run through was seeing if it would split automatically after the ragdoll section
https://github.com/just-ero/asl/assets/32069843/1dac42ef-081c-40e0-8186-ec227988cd1e


Matching Python kernels and order

Ref: https://github.com/ContinuumIO/wakari-app-ipython/issues/54

I think the discussion about https://github.com/ContinuumIO/wakari-app-ipython/issues/54 really belongs here, since this is where any changes will happen.  @damianavila added these comments in FD:

I don't think it is a bug... it is an intended behavior, your kernels ARE associated with a specific environment where you know you have all the dependencies to run it successfully. If you pass the notebook to a colleague, you need to provide it the environment specification (which includes the name), then the recipient re-creates the environment from the specification and when they try to open the notebook they start the kernel successfully. Otherwise, the warning is shown and the user can decide to run the notebook in another environment that could (or not) satisfy all the dependencies and run (or not) successfully.
We can probably discuss further what happens if two users have the same name environment... in that case, the probably need to make the name unique somehow...

I agree in general, however the novice user will be confused by this, IMO.  I feel like for "standard" kernels such as "Python" or "R", we should consider if it is possible to make a suggestion or automatically connect to an existing kernel in the current environment (or perhaps from another accessible environment).

@damianavila do you think this issue is still relevant; and if so, what would be the path forward?

OK, sounds good


perf: eliminate double string concat in remote-task-runner shutdown logging

Description
Improve the performance of TaskQueue::manage on large installations by removing unnecessary String concat / construction.
Once the changes in #12096 are applied, the performance of the TaskQueue loop becomes much tighter, and is dominated by the logging calls.
Screenshot of profiler showing TaskQueue-Mana... thread:

Screenshot of profile flamegraph for this thread, highlighting the format calls in the stack:

During the task clean up loop, the shutdown() call is issued multiple times to the RemoteTaskRunner - note especially it uses the three-argument invocation of shutdown() method:
https://github.com/apache/druid/blob/476d0bf4be4199e97695bd568d165cda98523d37/indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java#L328-L335
This hits the default implementation, which constructs a "reason" argument and passes it on to the two-argument shutdown():
https://github.com/apache/druid/blob/476d0bf4be4199e97695bd568d165cda98523d37/indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskRunner.java#L91-L94
In particular on large clusters with thousands of tasks, this default void shutdown call performs a StringUtils.format on a task set with thousands of task IDs, and it serialises all of them to a String.
Even in the event this log line is turned off, the log is still constructed, and then discarded.
Key changed/added classes in this PR
This introduces an @Override public void shutdown() with arguments, and has it perform the log construction and issue only if the info level is enabled. This results in significantly lower CPU consumption in this loop.
This follows up the changes in #12096, and also follows the mailing list discussion here:
https://lists.apache.org/thread/9jgdwrodwsfcg98so6kzfhdmn95gzyrj
This PR has:

[x] been self-reviewed.
[x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[x] been tested in a test Druid cluster (as part of a larger block of changes).

Since the reason is passed to shutdown only for logging, why do we do what you have changed in the interface so that all subclasses gain this improvement?
Something ike this:
Logger getLogger();

default void shutdown(String taskid, String reasonFormat, Object... args)
 {
   getLogger().info("Shutdown [%s] because: [" + reasonFormat + "]" + reasonFormat, taskid, args);
   shutdown(taskid);
 }

Another thing that confuses me is that the flamechart shows that there's some bottlenecks at the logging, not the StringUtils.format, so to gain the performance improvement, the right thing here to do is to change the logging level to WARN or ERROR right? What you solved here is just to eliminate some string construction under WARN or ERROR logging level, right?
In another word, at INFO logging level, the gain seems not significant.

I like your suggestion to move it up to the interface level.
WRT warn / error / etc. You're right; there's two perspectives on this:

Yes, the biggest benefit is if logging is set to WARN/ERROR. In my stack, with thousands of tasks running, I specifically set warn level for this class in log4j xml as it is noisy, expensive and provides little benefit for regular operations, but this benefit is mitigated with the current codebase.

Even in the case of info logging being enabled, the triple string concat is unnecessary.

Some extra data, ..
With reference to the TaskQueue-Manager thread, a capture with info enabled:

With respect to this thread only, the TaskRunner::shutdown call is 82% of CPU in the manage() loop, and, the useful part of the loop, findWorkerRunningTask consumes ~18%, the rest is logging related. By (1) turning off INFO logging on this path, and (2) avoiding the StringUtils.format() call, we get approx 4x more capacity through the TaskQueue-Manager thread.

In other words, if you take the image just above ^, and eliminate the Logger::info= and StringUtils::format paths, it opens a lot of capacity through this loop.
This becomes more obvious when coupled to #12096 and the yet-to-be-raised PR to reduce contention on the TaskQueue loop.

Capturing some test case results from #12099 we have more concrete example:
Alternating between these two lines:
  default void shutdown(String taskid, String reasonFormat, Object... reasonArgs)
  {
    // String reason = (getLogger().isInfoEnabled()) ? StringUtils.format(reasonFormat, reasonArgs) : null;
    String reason = StringUtils.format(reasonFormat, reasonArgs);
    shutdown(taskid, reason);
  }

The existing approach to always format the message completes the TaskQueueScaleTest in 15.x seconds:
[INFO] Running org.apache.druid.indexing.overlord.TaskQueueScaleTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.553 s - in org.apache.druid.indexing.overlord.TaskQueueScaleTest

Using the new way to only format if necessary completes the test in 6.x seconds:
[INFO] Running org.apache.druid.indexing.overlord.TaskQueueScaleTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.529 s - in org.apache.druid.indexing.overlord.TaskQueueScaleTest

Hi @FrankChen021 I moved the detailed log output to debug instead of info; I think this is a better balance. Let me know your thoughts.
In 5685eafeb4.

+1, looks good. I will merge after CI completes.

Looking at the CI failures, it looks like the build timed out because HashPartitionMultiPhaseParallelIndexingTest never completed. To be double sure, I ran the test locally and it completed fine. I am going to go ahead and merge this PR since it looks like tests have been flaky in general off late and I don't think logging changes introduced by this PR can contribute to the failures.

this PR has broken the ci, forbidden api check is failing, String.format shouldn't be called directly, use StringUtils.format instead

Looks like the last rebase you pushed reverted your String.format changes, @jasonk000 . I will submit a PR to fix CI, @clintropolis

Submitted https://github.com/apache/druid/pull/12304 to fix CI.

Oops my bad, i thought we had that fixed last night. Sorry!


Amazon Polly Voices no longer work with current release

They used to work, but after this update they no longer work.

How are you using Amazon Polly? It looks like a web API.

I installed the Amazon Polly for Windows Plugin. https://i.imgur.com/KSB6Ois.png
https://docs.aws.amazon.com/polly/latest/dg/install-voice-plugin2.html

It is working now after updating to v<IP_ADDRESS> Thank you so much.

They're not working again as of the latest patch 1.4.5

Tested and working on 1.5, try it again after https://github.com/goatcorp/DalamudPlugins/pull/928 is merged, maybe? I haven't been changing anything that would affect this though, so you might also want to check your installation separately from the plugin.

Testing this more, it seems to work at first, and then it starts to drop later, so maybe there's a rate limit involved.

Wait, disregard that, this is unrelated.

I noticed the following, maybe it helps. It is always working for tells outgoing and incoming, party chat, but as for NPC dialogue this is where problems arise. For me, it always reads the NPC dialogue between quotes "[DIALOGUE HERE]" and not any other NPC dialogue. If you remember, I had an issue before where any dialogue with special characters such as < or > or " caused an XML speech error. Now this problem is resolved but the TTS just doesn't work unless I reload the game 3 or 4 times, sometimes more, and it works normally after that until it drops later after a disconnect, or disabling it during voiced cutscenes and reenabling it causes it (using the hotkey ctrl + n) to drop as you stated.

I can't link this to a specific line of code, but I got this a lot while trying to replicate this issue. The only thing with this is that this synthesizer doesn't take voice IDs, it does lookups based on the voice name. Anything to do with voice IDs should be handled by the Windows plugin.

Built-in Polly support is going to be in <IP_ADDRESS>, so you could try that as well, once the testing PR is merged.

Today, I have been using testing version <IP_ADDRESS> all day, no problems or issues of any kind, no drops, text with special characters worked, both gender voices working with no problems, just one in which I disconnected, relogged, pressed ctrl + n to disable TTS and game crashed. Otherwise, no issues in this version.


Error while compiling on mac using cpp

I think the same error happens on all c++ targets:
Error: ./src/hscript/plus/ClassUtil.cpp:82:19: error: void function '_hx_run' should not return a value [-Wreturn-type]
HXDLIN(  30)                                            return ::Reflect_obj::callMethod(_this,field,method1);

I can't get my tests to print some messages on c++ target for some reasons (never did this before, oops!). So yeah, I don't know if the fix works or not. But until then check it out:
haxelib git hscript-plus https://github.com/DleanJeans/hscript-plus/ fix-issue-1

Run the command to install it.
Thanks!

it build with the change, however when I run the sample script (the one on the readme) I get the following error:
ScriptState.hx:85: EInvalidAccess(name)
it works fine on neko/html5 target, but not on cpp


[BUG] Query cannot run in active session as long as the concurrent active session reach to 10

What is the bug?
Got follow error message when submit query in an active session:
{ "status": 429, "error": { "type": "ConcurrencyLimitExceededException", "reason": "Too Many Requests", "details": "domain concurrent active session can not exceed 10" } }
This is a bug to fix, since we should check the limit in create session instead of submitting query in active session.

This is expected behavior. Please ref
https://github.com/opensearch-project/sql/pull/2390 for details

@noCharger no. I don't think so. The limitation implementation in my option is not correct. We should limit the concurrent active sessions, for example to 10. But when there are 10 concurrent active sessions, all the 10 active sessions won't work as expected. For example, you are open an active session and submit queries in the only one session you have. Now someone else create 9 sessions. You will find your active active session (actually all 10 active sessions) become "inactive" suddenly.

@LantaoJin +1. So the leaseManager.borrow should be called when creating new session.


Sync with diagram when user has stopped typing.

Just an idea, but currently when a user stops typing, Umple syncs with the diagram right away. This is quite annoying when trying to type again as the whole system lags.
I understand that syncing with the diagram is important however maybe you could delay syncing by 5 seconds after the user has stopped typing? That way if they start back up quickly again it doesn't cause any lag and delay in typing.
This seems to affect Editable Diagram class type more than the GraphViz.

It delays syncing for 3 seconds. If you don't want it to sync, you can switch to manual mode, or hide the diagram (e.g. using control-D). The suggestion here is for 5 seconds. Perhaps that would be better than 3. But I suppose what is really needed is an experiment to see what most users prefer, and also to allow the threshold to be set.


can we have live chat during video playback, like ACRL?

"They showed the prerecorded presentations in an interface that allowed for real time chat. Think a Zoom meeting where the presenter is screen sharing a YouTube video. I think we vaguely spitballed showing the YouTube videos in each session's Zoom meeting last year, but decided it would be safer technology-wise to just have attendees watch at YouTube. Maybe I'm imagining that conversation... Anyway, Cara said the simultaneous chat was great, and that the presenters were able to participate. It might also take some pressure off the time allotted for Q&A. Not sure if we can make that idea happen, though."

One option might be to look at YouTube Premiers, part of YouTube Broadcasts. One benefit is that we are leveraging YouTube all the same; one drawback is that you cannot use private YouTube videos for a broadcast. You would probably have to load each video into a separate YouTube account publicly to set up the broadcasts and then hope no one discovers them (security through obscurity).


Getting correct Station names

If have some Problems getting the correct station name.
This might be caused by special characters:
api_key: 'Key',
destination: 'Köln Hbf',
destination: 'Düsseldorf Hbf',
maximumEntries: 3,
maxWalkTime: 10,
displayStationLength: -1,
displayWalkType: 'none',
displayArrival: false,
language: 'de'

Düsseldorf,
Köln,
Köln Süd
are valid station names, but maybe this input field requires other Names

Did you specify origin and destination or just 2x destination?

Well, that's an error by me, of course, I will test it later on, or tomorrow :)

Okay, i pasted a wrong section, but i entered Duesseldorf instead.
There is still one station left, i want to integrate, but i could use the places id instead.
(Station called: Hilden Süd/Talstraße ->ChIJbShUdGfNuEcRU7H41WscJ9M)
Whats a bit difficult right now: Maybe there is no Bus/Train departing due to christmas holidays
But the "/" sign and "ü" "ß" won't be recognized by the api.
and the subway icon is coloured, can i change it to monochrome?

The icon comes from google directly, so I think not.

You could use this page, what suggestions do you get here for your origin/destination?

I will not further investigate it at this time. I will only show the connections to two bigger stations at this time.


SolidQueueUi::Web not defined

I followed your installation instructions, but the constant Web is undefined, so it of course blows up.
3.3.0 :001 > defined?(SolidQueueUi)
 => "constant"
3.3.0 :002 > defined?(SolidQueueUi::Web)
 => nil

Do we need a require somewhere?

I have confirmed that a require does fix this:
authenticated :user, ->(u) { u.admin? } do
    require 'solid_queue_ui/web'
    mount SolidQueueUi::Web => '/solid_queue_ui'
    ...

🤦🏽 You're absolutely right, @francis. I forgot to add that tho the README. I don't know how I missed it. Adding now. Thanks for this.


cargo-make: 0.37.11 -> 0.37.12

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/sagiegurari/cargo-make/releases.
meta.description for cargo-make is: A Rust task runner and build tool
meta.homepage for cargo-make is: https://github.com/sagiegurari/cargo-make
meta.changelog for cargo-make is: https://github.com/sagiegurari/cargo-make/blob/0.37.12/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.37.12 with grep in /nix/store/f572913cn0a111my1zzcc341gzajllb3-cargo-make-0.37.12
found 0.37.12 in filename of file in /nix/store/f572913cn0a111my1zzcc341gzajllb3-cargo-make-0.37.12

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

cargo-make
open-scq30

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/f572913cn0a111my1zzcc341gzajllb3-cargo-make-0.37.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-make https://github.com/r-ryantm/nixpkgs/archive/f8de3889db4ddcc87271ce308d493fcc934fbb82.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f8de3889db4ddcc87271ce308d493fcc934fbb82#cargo-make

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/f572913cn0a111my1zzcc341gzajllb3-cargo-make-0.37.12
ls -la /nix/store/f572913cn0a111my1zzcc341gzajllb3-cargo-make-0.37.12/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages built:

cargo-make
open-scq30

Maintainer pings
cc @figsoda @xrelkd for testing.

@NixOS/nixpkgs-merge-bot merge


Update rust.yml

Summary by CodeRabbit

Chores

Updated the GitHub Actions workflow for the Rust project by removing a commented-out argument related to linting, simplifying the configuration.

We will probably need to re-add this, removing the comment.

Yes, sure, I forgot to re add it


feature: easier sealed deck setup

There could be an easier way to select the packs for a sealed deck: after the "draft-sealed-cube" menu button, there could be another menu button with the choices "1x6, 3x2, 6x1". This menu button would be grayed out unless "sealed" were selected in the format selector.
"N x M" is shorthand for: N - the number of pack selectors that are clickable (not grayed out), M - the number of packs included of each of the chosen packs. This option would make it very easy to create a single set sealed (1x6) or 3 set block sealed (3x2).

Does this still apply to the way the options are set now @anoda9 ?

it does still apply


Version 0.24.1

In an effort to bring more transparency and less guesswork to the release process, we are trialling creating "release PRs", which track the release of new versions of Crystal. These PRs contain the changelog diff, but actually serve as a more general tracking issue for the release. As soon as this PR is merged, master will be tagged as the 0.24.1 and a full "release" with blog post and binaries will be done ASAP.
I've also come up with a new, slightly more structured, changelog format which is worth discussion.

Pushed fixed to fix the links, and to add a thanks to each author.

I assume this is supposed to be the place to discuss the new changelog format?
A) Thank you, I really like that the contributers are mentioned. That's a nice and appreciates the work. I was thinking about suggesting something like that =)
But I don't think it's necessary for minor edits (say fixing a typo in the documentation). They are unmistakenly none the less important contributionss to the project, but I don't think it's worth listing individual changes in too much detail if it's just a lot of noise with little to no useful information.
I don't particularly liked the previous style to just link the milstone with label Lots of bugs fixed. It could be a bit more. Maybe a good compromise would be an entry with a conclusive list of the individual issues but without additional explanation or attribution.
It's still a question for debate what would qualify as a minor edit, but I am sure a non-essential typo in the documentation like #5300 sure does. #5318 shows an example of a code refactoring that I would categorize as minor edit. This should probably be left to the maintainer's discretion.
B) I am not sure if the entries are sorted by anything (are they?) But I think at least the breaking changes should be on top of the list.

@straight-shoota they're sorted by category, then my opinion of their importance, basically. There's only one breaking change this release, and it's within the first 5 items and has a giant bold (breaking-change) so I didn't put it right at the top.

And regarding format, ideally I'd love to write more than one line for some changes, but I think that's going too far in the realm of a blog post. The less-important changes are all far down the bottom - just stop reading when you get bored.  I don't think it's an issue. What do people think?

IMHO:
Breaking changes should be distinct, and at the top, they're the most important information.
There are too many entries listed; it's hard to skim through. Some entries could easily be grouped, e.g.:
"fixed IO#blocking and linking programs on openbsd, see #X and #Y" or just a plain "fixed formatter issues, see #X, #Y and #Z".
The "doc fixes" and "misc" sections are mostly noise. Removing them would have no impact on the changelog itself. A simple link to the milestone bugtrack (as per the previous changelog entries) for an exhaustive list of bug fixes would be more efficient.

Good stuff @RX14
@straight-shoota, w.r.t. typo PRs, people should be recognized no matter what they did.  The reader of the CHANGELOG is clever to think the complexity that was involved.  When in doubt, add a name more than one less.  To me, it also boils down to respect of the mere contribution.
Though I somewhat agree with @ysbaddaden in that small non-logic changes, like typo fixes, could be grouped like

Various documentation fixes (Thanks @One, @Two, @Three, ...)

(^ Using backticks to avoid paging random people on Github)

@RX14 The changelog does not just consist of the current section but it compiles to a long document with thousands of entries. So you can't just "stop reading" when your scanning through the entire file. I think it would be very helpful to have this list as consise and significant as possible.
My suggestion for this would be to contract multiple entries with minor edits into one. This could also include contributer mention as suggested by @Papierkorb but IMHO it doesn't need to.
For example, these lines
# Documentation fixes

* Fix typos in documentation. (#5253, thanks @arcage)
* Remove bad example in property? macro documentation. (#5296, thanks @icyleaf)
* Fix typo in Crystal::Macros::MacroId documentation. (#5300, thanks @straight-shoota)
* Fix typo in IO documentation. (#5322, thanks @bew)

Could become:
* Documentation: Fix several typos, remove bad example (#5253, thanks @arcage) (#5296, thanks @icyleaf) (#5296, thanks @icyleaf) (#5300, thanks @straight-shoota)

It contains all the information except the exact location of the fix (which is insignificant) but is much more condensed.
This is similarly true for the Misc section. Only #5217 should be noted specifically because it contains a significant change which could break existing tool integrations using make doc (maybe it should even be labeled as breaking-change?).

I actually disagree that breaking changes should be in their own section. They should be very obvious but I think (breaking-change) is more than enough as long as they're near the top.
I'm fine condensing some related changes into single lines but I think this changelog should be exhaustive. It should link to every PR merged in the time period.
@straight-shoota I don't understand why you want the changelog to be small. If you want to only give the important changes in the release, we can make a blog post describing the new 0.24.1 and 0.24.0 releases in much more detail and with much more editorial discretion.

I agree on linking to every PR and it is probably fine to have breaking changes standing out but not necessarily on the very top. If the changes are sorted by importance, this should be okay and breaking changes will naturally be relatively high. 👍
I want to avoid unnecessary clutter and I think it is completely irrelevant in which type's documentation there is a typo fix that adds a missing 'r'.

You really don't save much space by removing these lines. Why not keep it 1 commit = 1 line? People's contributions are not "clutter".

The primary purpose of a changelog is documenting the development of the software, not keeping track of individual contributions. Each entry should describe a specific logical change to the codebase. 1 commit = 1 line does not fit for this because change and commit (or rather PR) are on different conceptual levels and not directly related. A single entry can easily contain references to multiple PRs each implementing a part of that change (there are three instances of this in this PR and further evidences in previous releases). Theoretically, one PR might introduce multiple changes in the sense of a changelog-entry though it won't happen very often because PRs should be focused on a single feature.
"Fixing typos in documentation" should be considered as one logical change. From the perspective of a changelog, it doesn't matter if it happened in multiple commits.

@straight-shoota I agree, one commit = one line was a bad way to describe it: one change = one line is much better. However I argue that the documentation fixes are separate changes. It's bikeshedding either way, and the impact of any decision will be minimal at best. So I'll collapse the documentation changes. I don't think the formatter or doc tool changes should be collapsed though, since each change can have an impact on people's codebase by itself.

I condensed code refactors and doc fixes into single lines, and added some new commits merged since I made this PR.

I would really love to release this before the end of the week and get 0.24.1 out before christmas. The current state of 0.24.0 is half-release, half-prerelease and everyone is confused. We need to release 0.24.1 and get everyone on the same version of crystal again. Plus we have the LLVM version upgraded so that we can use --release without --no-debug again if we release 0.24.1.

I'm using 0.24.1 for a month +/- now, no major issues were found, tested with multiple big community shards. You got an OK from me.

@mverzilli any word on the binary builds of the new release? Any help that can we provide?
Thank you.

Hi @luislavena! We're working on it. The plan is to start using this at least for linux x64 packages: https://github.com/crystal-lang/distribution-scripts
However, those scripts depend on @ysbaddaden's Alpine package, so we want to be sure that we can reproduce the whole release process with this new approach. That's where we are at. As soon as we manage to generate packages in a way that we feel confident we can repeat for 0.25, we'll release. Our current ETA is in a few days, maybe one week (original goal was before the end of this week, we're striving to make it might slip to next week).

Very excited to see the new efforts for transparency! Can I ask why 0.24.1 has two different tags?

Can I ask why 0.24.1 has two different tags?

Because we want to switch to v#.##.# tag naming, but we'll do this incrementally so we will have both for a few releases.
Relevant IRC log


Fixed bug introduced in PR-182

If you disable the installation of all services, you could have a != 0
output, and break the docker build process.

That's odd. That was what I thought too when I first looked at your pull request, but then I tested it and couldn't reproduce it. Anyway, it wouldn't hurt to have this change merged.


Implement v1.2 features

Great work team! Really impressed with the way we pulled together to implement these features. Your dedication to our mission is truly inspiring. Thank you for your hard work and for pushing the limits to make our platform more innovative and user-friendly. Let's continue to push the boundaries and bring our community closer together. #TogetherWeCan