requirement: select field with non-numeric value property / non-numeric foreign key (FK)

When using fields whose type is "select" we can provide an array of items. It seems though the valueField property by which we can customize the value attribute in  elements can only point to numeric columns in the datasource.
That said, we are not able to define a foreign key field whose related primary key is non-numeric, like a string. In other words, jsGrid assumes the primary key to be only numeric.
How can we define a "select" field whose values are text (not numeric)?
example:
{
	type: "select",
	valueField: "Id",
	textField: "Name",
	width: 100,
	name: "Color",
	title: "Theme",
	items: [{Id: "red", Name: "Bloody theme"}, {Id: "black", Name: "Dark theme"},{Id: "blue", Name: "Gloomy theme"}]
},

valueField of select field can be string or numeric. Just define it as you did in the code above.
What kind of issue do you have with it?

Hi tabalinsa. I used "string" and also "text". But neither did work. When I debugged into jsGrid.js I noticed the 'valueType' of the field is always 'number'. I deem there is some tiny bug in jsGrid. But I cannot figure out what it is.

It should work.
What exactly happens when you use string?
What do you mean by "I used "string" and also "text""? Used where?
valueType is defined on the fly depending on the type of the valueField of the first item (typeof items[0][valueField]).
If you think there is a bug, could you reproduce it in a fiddle (or any other page with public access)?

I know that. valueType is a system property you initialize it on the fly. But it seems this 'valueType' is determined based on the value of the first item in 'Items' array of the given field.
I use an array such as [{ Id: "-", Name: "All"}, {Id: "red", Name: "Red Theme"}, ... ], but the underlying code does not catch the type of 'value' correctly and always thinks it is a 'number' field type. Look at this private function in jsGrid:
function SelectField(config) {
        this.items = [];
        this.selectedIndex = -1;
        this.valueField = "";
        this.textField = "";

        if(config.valueField && config.items.length) {
            var firstItemValue = config.items[0][config.valueField];
            **this.valueType = (typeof firstItemValue) === numberValueType ? numberValueType :** stringValueType;
        }

        this.sorter = this.valueType;

        NumberField.call(this, config);
    }

Yes, so since typeof "-" gives us string code should work as expected.
Could you reproduce the problem in a fiddle (or any other page with public access)?

Sure. I post the link here after I do it.

Hi back.
I used one of your own repros and changed it a little.
You can check it out using this link:
[(http://jsfiddle.net/9g8upd33/145/)]

In the given example, the problem is the ID property of the "ALL" listing. The loadData filter is checking to see if Country is present, and it is because of the dash character.
Replace
{ Name: "All", Id: "-" },
with
{ Name: "All", Id: "" },
and it works fine, if I'm understanding your issue correctly.

@mansoor-omrani, the problem is not with js-grid but with db filtering function.
Inside loadData your code checked:
&& (!filter.Country || client.Country === filter.Country)

which is obviously false, since your default country is "-", not an empty string.
So just changing the filtering function fixes the problem:
&& (filter.Country === "-" || client.Country === filter.Country)

see working fork http://jsfiddle.net/tabalinas/jrc9otky/


Plugin Incompatibility with Latest Update v1.5.3

Hello there,
I have been an avid user of the obsidian-tray plugin, relying on it heavily for my daily workflow. It has been an integral part of my setup, and I've thoroughly enjoyed the functionality it brings to Obsidian.
However, after updating to the latest version (v1.5.3), I've encountered an issue where the plugin cannot be enabled anymore. This has significantly impacted my usage and I am keen to get it functioning again as soon as possible.
Here are some details that might help with troubleshooting:
Obsidian Version: v1.5.3
Operating System: Windows 10
I have tried reinstalling the plugin and restarting Obsidian, but the issue persists. I would greatly appreciate it if you could look into this matter and provide a fix or guidance on how to proceed.
Thank you for your continuous support and for creating such a useful plugin!

Nevermind. I got it working after uninstalling and reinstalling obsidian. Thank you.


Broken link in readme

At
https://github.com/acroz/resumable.py
section Backend, or the backend samples on GitHub.
The link on GitHub is broken
https://github.com/acroz/resumable.py/blob/master/resumable.js-samples
gives 404

Thanks, fixed!


odo delete broken without local component

What versions of software are you using?
Operating System: Win10
Output of odo version:
odo v2.4.1 (dbf7ad592)

Server: https://api.crc.testing:6443
Kubernetes: v1.22.0-rc.0+a44d0f0

How did you run odo exactly?
odo delete -f -app app --project project mycomp
Actual behavior
Reports an error:
 X  error occurred while deleting component, cause: failed to read devfile from path 'C:\apps\odo\2.4.1\devfile.yaml': open C:\apps\odo\2.4.1\devfile.yaml: The system cannot find the file specified.

Expected behavior
Component should be deleted on the cluster.
Any logs, error output, etc?

/kind bug
/priority high

This issue should be fixed in odo v3 (since #5511), with the odo delete component --name <name> command, which can be run from anywhere: https://odo.dev/docs/command-reference/delete-component#delete-without-access-to-devfile
see #5479, fixed by #5511


Update selectability of several non-selectable cells

Fixes #1245.

Since it’s hard to tell from reading the XML — which cells did you make non-selectable?

Right, sorry 😂
In Settings:

Sort Oldest to Newest
Group By Feed
Number of Text Lines

In About - the NNW top banner cell.


support jsonschema >= 3.0

Dropping this here until we have time to deal with it properly.  JAMS tests currently fail on jsonschema 3.0.0a2.

Can confirm this issue (with 3.0.0a3). Downgrading to 2.6 fixed it. Thanks for the tip!

Thanks for noting that it's still a problem -- I think it's going to continue being a problem in 3.0 final.
We will need to get out ahead of this at some point -- any takers?

This issue has suddenly become a bit more severe, as many other packages (including jupyterlab) now require jsonschema >= 3.


autodisable form submit button

I'm trying to use this directive on a form with a button[type="submit"]. The problem is...
The child button is generated in a directive itself. (<md-button type="submit">Submit</md-button).
This is likely an issue where the child button is processed after the parent ng-autodisable linking function has run. Any suggestions?

@kirstein Are you interested in this issue? Perhaps you could point me in the right direction for lazy evaluating the submit button.

@mburgosh ?

I'm actually not familiar enough with the angular internals and lifecycle of the scope.
But as the current structure of the directive is this is not possible. The DOM element to disable is selected in the compile function. So if the element is not available at that time, there will be a problem.
I did some tests by sending a callback of how to select the element instead of passing the element itself, but it didn't work.
Maybe you can explore this option and apply your knowledge of the scope lifecycle to it.

Could you check this again. We moved the implementation top the link function. This means that your directive is compiled and the button element generated once the directive runs.


Reflexions not working in glTF

I have tried a few glTFs which use materials with metallicFactor and roughnessFactor, and the environment map is not visible in the reflexions, which is what normally gives the metallic and/or glossy appearance. I use <ViroLightingEnvironment /> - which is working since I can see the object and there are no other light source in the scene - it's just without any visible reflexions.
This is a basic example: a simple cube, with fully metallic, fully glossy material.
You can see how that it should look by using https://gltf-viewer.donmccurdy.com.
And here is a screnshot from my app:

Here is also the environment map I am using.

Hi @silvainSayduck, not sure if the files you attached came through correctly. Can you email them to<EMAIL_ADDRESS>instead.
Also, are you assigning materials like the example below under ViroMaterials?
boombox : {
      lightingModel: "Constant",
      diffuseTexture: require('./res/gltf/BoomBox_baseColor.png'),
      roughnessTexture: require('./res/gltf/BoomBox_Roughness.png'),
      normalTexture: require('./res/gltf/BoomBox_normal.png'),
      metalnessTexture: require('./res/gltf/BoomBox_Metallic.png'),
    },

Hi,
Thanks for the answer! I have now also sent the files by email, but they should be correct. The main thing is that this basic example does not use any textures at all, it's just using the values (factors as they are called in glTF), as in a "true" PBR model.
In any case, the documentation is in fact a little unclear on the need to manually create materials with ViroMaterials and/or manually pass resources={[ ... ]} to <Viro3dObject /> when using type="GLTF" or type="GLB". Could you clarify that?
I do hope none of that is needed, and it is handled under the hood, as obviously, those materials are contained within the GLTF file, and should ideally be created automatically instead of requiring the user to open and parse the gltf (or worse glb) file, and manually recreate ViroMaterials from the contained materials. That would pretty much defeat the entire point of using a format such as glTF.
Thanks a lot once again for the great work and your help :)

Thanks for the file. We are seeing the same issue on our end and will have to investigate further. There are some features of GLTF we do not support at this time, it was not clear if your file was using any of the limitations listed at the end of this section -> https://docs.viromedia.com/docs/3d-objects#section-gltf
You are correct. I did not realize how the file was outputted originally. For this file, the following should work (though it is appearing white-ish at this time)...
<Viro3DObject
      scale={[.1, .1, .1]}
      position={[0,0,-1]}
      source={require('./res/gltf/chrome_cube.gltf')}
      resources={[require('./res/gltf/f5f5f0cef97735ca45d3dd7dd3a61230710e93dee636f041fee6e8043d183d86-original.bin'),]}
      type="GLTF"
        />

Hi,
Just wanted to say that in theory, this is really a suer simplistic model, so it shouldn't use any of the features listed as not yet supported. It's basically just a (very simple) bin file, on which the metallicFactor is set to 1 and the roughnessFactor to 0.
Also, there is in fact no need to set the bin in the resources prop manually - which is good - at least the cube is showing up without it for me.
Please let me know if you find any workaround to makes reflections appear using the "GLTF" type.

Hi,
Is there any progress on this? My initial thought was that metallicFactor/roughnessFactor were (wrongly) ignored because there was no texture, but I have now tried this same cube with a plain white texture as metallicRoughnessTexture, and the results are still the same than on the screenshot above.
This makes the glTF format rather unusable currently, unless I am doing something completely wrong here...
Using GLB also yields the same results. Also, baseColorFactor and baseColorTexture are working as expected.
<Viro3DObject
  source={{ uri: localGltfUrl }}
  type="GLTF"
  onLoadEnd={this._onLoadEnd}
  onError={this._onError}
  visible={visible}
/>

<Viro3DObject
  source={{ uri: glbUrl }}
  type="GLB"
  onLoadEnd={this._onLoadEnd}
  onError={this._onError}
  visible={visible}
/>

Here are the test models of the cube with the white texture:

https://s3.amazonaws.com/static.sayduck.com/2019.02.18.Sayduck_app_tests/2019.03.10.chrome_cube_with_textures_gltf.zip
https://s3.amazonaws.com/static.sayduck.com/2019.02.18.Sayduck_app_tests/2019.03.10.chrome_cube_with_textures.glb

Thanks a lot in advance for any information you might have :)

I made a couple additional tests, and maybe they can help you figure out the issue(s).
My scene only has an HDR envMap, no other light.

changing the HDR environment map does not fix any of the issues, although it does change the rendering slightly, so I'm assuming the maps are somehow loaded in the scene.
when not using textures, the metallicFactor and roughnessFactor seem to be ignored. Whether metallicFactor is 0 or 1 and/or roughnessFactor is 0 or 1, the rendering is the same. This results in some inconsistencies (see below).
when using a metallicRoughnessTexture, the [metallic|roughness]Factors seem to be ignored.  A white texture seems to work as expected. This is the main issue.

Here's the cube using a half white / half black roughness texture.
The desired outcome:

In my scene

One thing to notice is that because of the ignored metallicFactor, the cube on the lower part is wrongly fully metallic.

Hi!
Thanks for this great news, I'm eager to try it. Is there any way to get access to a pre-release version?
The screenshot you sent looks great, and I assume you have also been trying all the use cases (only a roughnessFactor or metallicFactor, factor & texture channel, only texture channel, neither)?
Regarding your workaround, I am not sure exactly what you suggest, but I understand that I could basically manually create the material using ViroMaterials.createMaterials? The problem with this is obviously that I would have to parse my glTF file, which makes the value of using glTF fairly minimal. In any case, I can definitely wait at this point for the proper fix.
Once again, thanks for the great work, I am looking forward to trying this and being able to render complex models using glTF with this next release :)

Hey @silvainSayduck, we are currently preparing an upcoming patched release that should be ready next week.
We do have internal tests with some of the gltf samples containing both metal and roughness channel textures.
Having said that I'll update this issue once the patch has been pushed to release.

Great to hear, thanks again!

This has been fixed in the latest release, ViroReact 2.14.0 | Release notes and upgrade instructions here -> https://docs.viromedia.com/docs/releases

Hi,
I finally got around to update my project to the latest version, and it seems that this didn't fix my issues. My non-rough materials are still completely black. In fact, it seems that more materials are now completely black, when previously some where fine apart from missing the reflections.
There also seem to still be visual differences between materials with no roughness/metalness map, and one with fully white channels in the map.
I'm thinking that maybe I did not update correctly, since this seem pretty ciritical still, and I will proceed to a more in-depth analysis and report tomorrow. But I thought I would also first ask if there was anything that I could have missed while updating from 2.13 to 2.14 (changes to the HDR environment or to the glTF materials, ...)? Could you maybe share an HDR envMap that works for you, as I'm also thinking this whole thing could come from my environment map...
Thanks in advance, I'll come back with more details as soon as possible.

Hi @dthian and @dam00n,
As promised, I dug a little deeper, and can confirm that this is still not working fully properly, although there has in fact been some improvements!
The reason why I still thought reflections were not working at all was that my tests were originally just testing 0 and 1 values. However, it turns out that reflections are now working as expected, unless roughness is too low, something like under 0.05.
I used this cube with a linear gradient as the roughness texture, from 1 (top) to 0 (bottom), and you can see that the bottom of the cube becomes fully black under a given roughness threshold.

I guess for now, I can work around this issue by making sure that none of our models are using roughnessFactor values under 0.05 - but this is obviously not the expected behaviour, and it would be helpful to be able to use 0 roughness for fully glossy materials :)
Here is the glTF of the cube, and a screenshot from the three.js glTF online Viewer:

Thanks again for all the help and great work!
PS: As I noted in my previous comment, there seem to still be some other issues with the glTF format, but I created another dedicated issue: https://github.com/viromedia/viro/issues/623

I have now made a precise test, and it's indeed roughness <= 0.05 that causes the material to go full black. A cube with roughness 0.06 works as expected, a cube with roughness 0.05 is all black.

Hi @dthian and @dam00n,
Could you guys reproduce the issue(s) on your end? Any timeline on a possible fix for this?
Thanks a lot in advance!

Hey @silvainSayduck, that is interesting, much thanks for your testing and observations - it is greatly appreciated. I've also started to see this behavior in another bug that I am looking at. Will get back to you once i've root cause the issue.

Hi @dthian! Nice to hear that you have been able to reproduce on your end :) Any estimate on a fix release?
Thanks again!

Hey @silvainSayduck, np! :) Unfortunately, the next release is yet unknown, but will let you know as soon as we've determined one!

Alright, thanks for the heads up! You wouldn't even have a rough estimate to share at this point?

Hi @dam00n and @dthian,
Great work with the latest release!
I have some more information about this bug. I have been able to test on an iPhone 8, and everything seemed fine! This is probably a model-specific problem then.
That being said, using 2.15.0, the roughness under 0.05 still does not work on iPhone 7. When roughness factor <= 0.05 or if the value in a roughness texture <= 0.05, the material still appears all black (and also breaks the depth buffer actually, as it always appear on top of everything).
It may be worth noting that while using the gradient texture makes the material appear fully black on the edge where the values are under 0.05, a fully black roughness texture successfully makes the material fully glossy even on iPhone 7.
This was already the exact situation on 2.14.0 (I just tested again).

Hi @silvainSayduck, we filed a new issue for the roughness under 0.05 not working on iphone 7 -> https://github.com/viromedia/viro/issues/673
Will take a look and report back on that issue

Awesome, thanks!


Publisher: Convertors for legacy instances

Brief description
Give ability to have convertor plugins for conversion from legacy instances to new creators.
Description
Added Convertor plugins which can collect ConvertorItem into CreateContext. These items are shown in UI next to instances with a label that the convertor plugin defines. Convertor collect items after Creator's collection so there should not be a clash if any creator would convert something automatically and also has access to shared data. Has 2 methods find_instances and convert both without any arguments. Plugin must be in files next to creators (can be in file with creator). In UI is conversion button always before creator attributes. So multiple conversion plugins can be selected and UI does not break when instances are selected too.
Screenshots

Testing notes:
Create fake convertor in TrayPublisher e.g. ~/openpype/hosts/traypublisher/plugins/create/converter_test.py with this content.
from openpype.pipeline.create.creator_plugins import SubsetConvertorPlugin

class TestConverted(SubsetConvertorPlugin):
    identifier = "text.converter"

    def find_instances(self):
        # This is called during collection - plugin should create it's item based on some logic
        #  - for example find an instance without 'creator_identifier'
        self.add_convertor_item("My testing legacy item")

    def convert(self):
        # This is method which is triggered from the UI
        # - should update items for new creators and remove item if was successfull
        print("Fake converting. This is when would logic of conversion be.")
        self.remove_convertor_item()

Seems like it is working but I would add two things:

Reset publisher after conversion is done
add log to the converter (to access self.log.*)

Seems like it is working but I would add two things:

Both should be available now.


Add documentation to cirq.decompose protocol regarding specific target gateset

Fixes https://github.com/quantumlib/Cirq/issues/930

@tanujkhattar Are we waiting on anything to merge this?

@tanujkhattar Can we finish this off and commit it?

@dstrain115 This is good to go now.


Remove licensing from when it was a commercial product

This can be closed now.

This problem still exists in the 'PublisherSigned' binaries.

In this case we need help from @ComponentFactory, since he's the only one with the ability to sign and build those. But those (PublisherSigned) are not really needed.
The only difference between those is, that the PublisherSigned ones are signed by @ComponentFactory. So you should be fine using the unsigned Build. If you need signed ones, just sign them yourself (https://msdn.microsoft.com/en-us/library/ms247123(v=vs.100).aspx)

Thanks for your response, can I just remove the *.snk files and recompile? There is also a further issue, which I don't know is covered which means you can't drag controls to a form, as they act in a similar way to a timer, background worker and dialog controls. I'll have a look at the code today to see what's causing this behaviour.

Yes you can.
For design time support missing : you just need to register in the GAC the *.design.dll and voila !

Thanks for that, maybe the wiki documentation or some sort of in depth guide need to be written to explain to users what to do. Just out of interest can I use GAC if I put all the relevant DLLs into a separate directory i.e. C:\Development\Krypton\bin?


controllers\kubefate: fix mariadb init user and password

Mariadb requires environment variables to configure users and passwords.
Fixes #30

Bug fixes for issue: https://github.com/kubeflow/fate-operator/issues/30
/lgtm
/approve


Fixes #3401 - Handle no AWS credentials in AWS init tool

@ThatOneBro @rahul1

Looks good for the most part, just curious if we can keep types a bit tighter with a Partial for the MedplumInfraConfig

Unfortunately this is MedplumServerConfig, not MedplumInfraConfig.
At present, MedplumServerConfig lives in the server package.
I'm uncertain if we should move that to core as well 🤔


Specify the plugin source in the wp-package.json

to avoid conflicts or issues of any kind we could add an opional field that will correspond to the github url so the program will clone the repo directly from github instead of guessing the source of the plugin, that way the user can avoid conflicts if the plugin is present both in wp repo or github repo

yep that right, good catch. would be cool because in this way we can also add other "way" to download the package like the git clone.
the oop refactor (checkout the new branch) will help with this job, give a look and let me know is it's feasible


Identify, disconnect, and clean up badly connected RoadPoints

If we duplicate a roadpoint in the middle of a RoadNetwork, we get a lot of weird overlapping geometry. This is because one roadpoint points to another, but that other one doesn't point bad. See the video showing up this awkwardness of having to manually toggle refresh (there are a number of scenarios where this becomes necessary):
https://user-images.githubusercontent.com/2958461/226811922-847c676d-a39c-4dfd-952c-41bfd9afb367.mp4
Ideally, the RoadNetwork can be an authority to determine an "illegally connected" RoadPoint, and auto clear up any bad pointer references - and just as critically, clean up any of that invalid geometry left around so that we don't have to manually refresh the network auto update, which is a bit of a pain.

Some aspect of this was actually resolved in the recent release, though more could be done.

Questions:

What is the issue? Is it the fact that the user was allowed to create an invalid setup?
When do we do validation? a) When RoadPoint selected, b) When start/end point changed, c) When a new (to be created) "Validate RoadPoint" button is pressed, d) Other: (explain here)
Do we arbitrarily correct a user's changes based on our assumptions or simply tell them what's wrong and let them make the corrections? (i.e. Which RoadPoint do we alter when making corrections? How do we know which is the right one? Does only the user know?)

In the given example, the user should have used the "+Next/Prev RoadPoint" buttons to add the RoadPoint rather than duplicating. In fact, I would go so far as to say users should never duplicate RoadPoints because it inherently creates an invalid junction.
Nevertheless, we could enforce certain rules. For instance, the given example showed two RoadPoints using the same third RoadPoint as their end point. We could say this is not allowed and that a RoadPoint can only be used as the end point for one RoadPoint. But, how do we enforce this and when do we check for the condition?
To enforce this, we could validate whenever the user changes the end point. We would iterate the entire network of RoadPoints and make sure that RoadPoint was only used once. If it was already used, then we would revert the user's change and set the end point to null.
In the case where the user duplicates a RoadPoint, there's no way of knowing when this has happened. We could always run validation when a RoadPoint is selected.
Alternatively, we could implement a tool button that says "Validate RoadPoint" and/or "Validate RoadNetwork". It follows that the validation routine would verify that a given RoadPoint is used no more than once as a start or end point.
If duplication was detected, then we would need to provide options for remediation. These might include aribitrarily keeping the first start/end point assignment and clearing all of the others or, perhaps, just printing a list in the console and letting the user do the cleanup.
Another approach would be to display a modal popup where the user selects the correct RoadPoint from a list of connected RoadPoints. Then, we would automatically disconnect all other RoadPoints from the start/end point. There would be a bit of a learning curve as we figure out how to do this. But, it would probably be the most convenient and intuitive solution for users.

Thanks for the detailed questioning and thinking through. I think the core original topic in question was brought up indeed around duplication of nodes, but then I generalized the title to be about really any situation with a bad situation. You outline the two main scenarios:

Duplication of a RoadPoint
Otherwise creating bad connections (where as you say, a roadpoint gets used more than once)

What is the issue? Is it the fact that the user was allowed to create an invalid setup?

Yes, we want to prevent invalid setups where two road segments are coming out of each other. It creates weird geometry that will never be desirable. We should have cleanup code the prevents this from persisting, so that other features like intersections can depend on the validity of the network (where roadpoints only connect to max 2 other roadpoints).

When do we do validation? a) When RoadPoint selected, b) When start/end point changed, c) When a new (to be created) "Validate RoadPoint" button is pressed, d) Other: (explain here)

Think more downstream: at the time mesh geometry updates are happening, when we're about to potentially create new RoadSegmetns. This should really be a pre-step which corrects any bad connections. This way, this code gets triggered whenever a transform / updated connection is done (whether on a single node, or if the whole network is updated), no different to how it's already running. So it shouldn't be a new lifecycle hook.

Do we arbitrarily correct a user's changes based on our assumptions or simply tell them what's wrong and let them make the corrections? (i.e. Which RoadPoint do we alter when making corrections? How do we know which is the right one? Does only the user know?)

The modal popup is an interesting idea. While indeed it gives the most control, most users would not expect a popup right after duplicating a node. Plus, whenever an invalid situation occurs, there will be a single action or moment that makes it invalid. So, it should be self-resolved at that point.
To give direction: How do we do this, "get the last action"?
Thinking about this more, we shouldn't even need to. We have bidirectional linked lists essentially right now. If we have an invalid setup, we could check whether the bidirectional point connections agree or not - and for the one which disagrees, disconnect what it is falsely claims being connected to.
Maybe I'm oversimplifying, but it seems to me like this could be a solid approach. Thinking it through:
Scenario A: The duplicate scenario
- The two roadpoints (original RPA0 and the duplicate RPA1) have exactly the same prior and next point init nodepaths as a result of a duplication. If this was at the end of a Road, then they might both list their EndPointInit as RPB
- When performing the checker, we should see that RPA0 claims RPB as it's end point; if we check RPB, we see that RPA0 is listed in at least one of the PriorPointinit or NextPointinit, so no issue - loop continues.
- When the checker gets to RPB, same deal: it claims to connect to RPA0; and RPA0 agrees it is connected to RPB, so we continue
- Once we get to RPA1 however, it claims to be connected to RPB. If we check RPB, we find neither the prior or next pt init claim to be connected to RPA1. Thus, we clear RPA1's connection to RPB. We would end up doing the same to the other connection slot of RPA1, if anything were filled out. Though this would be computed independently.
Scenario B: A manually created invalid setup by changing pt inits only.
- Say you have A-B-C all connected in a row, so B is fully hooked up
- From the Add Node menu, you create roadpoint D. So far we're good.
- With D selected, you set its NextPoint init to be B. This should trigger the rechecker followed by the mesh generation
- During this rechecking, you would see that roadpoint B does _not_ think it is connected to D, so D is taken as the "liar" and this just-added

Some additional thoughts on this approach:
- To me, both scenarios above can follow the same checker logic and works out as I'd argue you would expect.
- You might think: why not enforce this at the time of setting the point init path? Well, I like to think of this auto resolving to be part of the generation step that gets deferred if auto-update is turned off, so someone programmatically changing the connection between a bunch of things doesn't start fighting our auto corrector.
- Yes, as road networks get longer and more complex, the number of checks increases - but it should be linear time O(n), and we can iterate in order of children (order doesn't matter, so long as each RP is looked at once). And we already do this while (re)generating segments.
- However if we are moving or transforming a node, we shouldn't *need* to check the whole network, we could just check the 2 roadpoints connecting to the middle roadpoint being transformed (similar to how we don't regenerate all road segments, just the 2 connected to the point being transformed).

Let me know if you think I'm missing any considerations @bdog2112. Of course once we implement this, any scenes saved to disk may be updated immediately on next regeneration, but I'd argue that's working as intended as it sanitizes the network (maybe that's even what we call this function.


chore(master): release 3.8.0

:robot: I have created a release beep boop
3.8.0 (2023-12-29)
Features

add support for cypress-cucumber-preprocessor (#172) (3041fd7)
support absolute path images when converting image to base64 (#170) (9fcb92d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/LironEr/cypress-mochawesome-reporter/releases/tag/v3.8.0 :sunflower:


Add back wlr_buffer

Running rootston through valgrind revealed that when resizing xwayland is destroying buffers before they are released. So merging #1060 fixes the invalid reads.
This PR is just a combination of #1050 and #1060. Fixes #1061.
cc @Ongy @Timidger @ammen99: this is a breaking change. Here's the sway PR: https://github.com/swaywm/sway/pull/2135

The last commit stops destroying textures when the wl_buffer is destroyed. I still want to retain the same wlr_buffer ABI to allow future buffer types that don't work this way to work (ie. I still don't want to make promises about wlr_buffer.texture being non-NULL). Here are the #wayland logs:
09:27 <emersion> btw, i was wondering: how does the close animation in weston work?
09:28 <emersion> do you copy the texture when the client unmaps?
09:37 <pq> emersion, I don't think weston does a copy at that point. wl_shm is already copied, and for others we rely on the buffer reference (EGL, dmabuf) to keep the buffer around. Of course, that kind of fails if the client goes and re-uses the same storage, but if it does that, then there is no guarantee a copy would finish before that either.
09:38 <emersion> so EGL will be in charge to keep the wl_buffer around, even if the client exits?
09:38 <pq> also, re-using the same storage is a protocol violation, because the client has not received a wl_buffer.release at that point
09:39 <pq> maybe not the wl_buffer, but the underlying memory
09:39 <pq> I forget the details around wl_buffer destroy, though.
09:40 <emersion> hmm, what happens when the wl_buffer is destroyed? should we assume that the underlying memory is not valid anymore?
09:42 <emersion> (also, there are two ways this can happen - either when the client sends wl_buffer.destroy before receiving wl_buffer.release, either the client disconnects)
09:42 <pq> as long as you keep the GL texture or EGLImage or dmabuf fd or something, the memory will remain usable
09:42 <pq> IIRC
09:42 <emersion> ah
09:43 <pq> but in principle, when the wl_buffer gets destroyed, a compositor should go and destroy everything about it.
09:43 <emersion> yeah, that's what i do currently - when the wl_buffer is destroyed, also destroy the imported texture
09:44 <emersion> but that prevents to do stuff like close animations
09:44 <pq> it seems Weston keeps something around, because e.g. quitting weston-simple-egl returns to the shell before the fade ends, if I can see right
09:44 <emersion> yeah, i think so
09:45 <pq> the only real concern is the memory re-use though, the EGL or whatever reference will keep the memory allocated
09:45 <emersion> is dmabuf managing itself its buffers? (with a refcount or something)
09:46 <emersion> okay, so it should be fine to keep the imported texture when the wl_buffer is destroyed then
09:46 <pq> yes, the memory underlying a dmabuf fd is reference counted, each fd holds a reference, and so do many other handles
09:47 <emersion> ah, and if i import a dma-buf and then close the FDs, do i still hold a reference?
09:47 <emersion> ah, okay
09:47 <emersion> all right
09:47 <pq> yes, I believe so. Even just a GL texture holds a reference, even if the texture has already been deleted but the GPU is not finished yet
09:48 <emersion> i get it, thanks!
09:48 <pq> a problem only arises if the client re-uses the memory directly, without making a new allocation.
09:49 <pq> so what weston does is not exactly right I think, but it's pretty rare to not get away with it
09:57 <zubzub> so a troll client could show the dying scene from platoon when his surface is closed?
09:57 <zubzub> interesting
09:57 <pq> yup!
09:58 <pq> although, nothing prevents it from showing it before closing either :-P
09:58 <emersion> :^)
09:58 <emersion> less scary i guess
09:59 <pq> the practical risk is more like seeing garbage during the closing animation

WFM

Thanks!


Does not seem to start

Hi,
I followed the instructions for installing the script for which to be used with the Lynx Smart Shunt but is does not seem to do anything. I see the discharge and charge kWh in HRM but no values. When i do the tail it says tail: read error: is a directory.
Any ideas what I might have done wrong ?

When I run the script manually via SSH it works, but adding it to the rc.local file and rebooting the cerbo nothing happens.

Yes it is there is one extra line for dbus mqtt service

`#!/bin/bash
/data/drivers/dbus-mqtt-devices-0.8.0/bin/setup-dependencies.sh
ln -s /data/drivers/dbus-mqtt-devices-0.8.0/bin/service /service/dbus-mqtt-devices
ln -s /data/battery-energy-meter/service /service/battery-energy-meter`

If I do the following the scripts starts, but as soon as I close SSH the script is stopped.
cd /data/battery-energy-meter
nohup python battery-energy-meter.py&

I removed everything and did reinstall now it magically it works also after reboot. Only issue now left is that the 2 values disappear from the history in console and then come back every few seconds. I also see this in the logs of home assistant value goes back to 0 and back to the "normal"  value.

Hello,
well done to manage to run the script. Is there anything to change in the "Script Installation" chapter ?
For the 1s flickering, I don't understand from where it's coming as dbus data are refreshed every time they change and at least every minute. You can check that with dbus-spy -r from the command line.
Benoit

I probably done something wrong on my end had to do with permission at least why it was not running.
It seems it is happening when battery is fully charged and constantly switching between charge and discharge. Now in constant discharge it is not happening but the charge value disappeared in the history on cebro gx console only discharge is showing.


Implement TLS support for IngressV1Beta1

Fixes #15

Is it a coincidence that I'm looking for this and it's implemented so recently (but not merged)?


GRIP 2.a.1

New reporting
Use FAO data

[x] Primary series: Agriculture orientation index for government expenditures (AG_PRD_ORTIND)

https://de-public-statsuite.fao.org/vis?df[ds]=ds-release&df[id]=DF_AG_PRD_ORTIND_2A1&df[ag]=FAO&df[vs]=1.0&pd=2018%2C2022&dq=A...........&ly[rw]=REF_AREA&ly[cl]=TIME_PERIOD&to[TIME_PERIOD]=false

[x] Complementary series: Agriculture value added share of GDP (%) (AG_PRD_AGVAS)

https://de-public-statsuite.fao.org/vis?df[ds]=ds-release&df[id]=DF_AG_PRD_AGVAS_2A1&df[ag]=FAO&df[vs]=1.0&pd=2018%2C2022&dq=A...........&ly[rw]=REF_AREA&ly[cl]=TIME_PERIOD&to[TIME_PERIOD]=false

[x] Complementary series: Agriculture share of Government Expenditure (%) (AG_XPD_AGSGB)

https://de-public-statsuite.fao.org/vis?df[ds]=ds-release&df[id]=DF_AG_XPD_AGSGB_2A1&df[ag]=FAO&df[vs]=1.0&pd=2018%2C2022&dq=A...........&ly[rw]=REF_AREA&ly[cl]=TIME_PERIOD&to[TIME_PERIOD]=false

[ ] remove the Exploring data sources from the French and populate indicator
[ ] EN radio button, 1st one, remove "[2.a.1]"
[ ] make chart title change with radio button
[ ] method of computation: Data were readily available to report on this indicator as specified by the metadata. Please refer to the sources to access additional information on the metadata or source.

[x] FR sources link to relevant FR pages of FAO data explorer

[ ] FR: Chart title for Indice d’orientation agricole des dépenses publiques is in English


The List Roles Endpoint in SCIM 2.0 API Ignores the 'Domain' Parameter

Describe the issue:
It retrieves all roles in both the 'internal' domain and the 'application' domain although I sent a request to retrieve roles only in the 'application' domain. The same behavior happens for requests to retrieve roles only in the 'internal' domain also.
To retrieve roles in the 'application' domain, I passed all the following values as the value for the domain parameter. But each gave the same incorrect result.

Application
application
APPLICATION

How to reproduce:

Create some roles in the 'Internal' domain by using the IS management console.
Create some roles in the 'Application' domain by using the IS management console.
Send a GET request to https://localhost:9443/scim2/Roles?domain=Application
Send a GET request to https://localhost:9443/scim2/Roles?domain=Internal

Expected behavior:
When we send a GET request to https://localhost:9443/scim2/Roles?domain=Application, it should retrieve the roles only in the 'Application' domain. But currently, it retrieves all the roles in both the 'Application' domain and the 'Internal' domain.
When we send a GET request to https://localhost:9443/scim2/Roles?domain=Internal, it should retrieve the roles only in the 'Internal' domain. But currently, it retrieves all the roles in both the 'Application' domain and the 'Internal' domain.
Environment information :

Product Version: IS 6.0.0-m1
OS: Mac OS 12.3.1
Database: PostgreSQL 14
Userstore: LDAP

Hi @ravinduramesh, There is no domain support in the Roles API [1]. Please use the filter param for filtering.
[1] https://is.docs.wso2.com/en/5.12.0/develop/scim2-rest-apis/#/Roles Endpoint/getRole

Closing the issue since the SCIM 2.0 API act as intended.


docker-compose: not found when install via ansible

I run command ansible-playbook -u azureuser deploy.yaml -i hosts
Please note that I changed root to azureuser
TASK [uashield : Stop all containers] *******************************************************************************************************
fatal: [**********]: FAILED! => {"changed": true, "cmd": "docker-compose down", "delta": "0:00:00.002971", "end": "2022-03-04 10:24:01.968900", "msg": "non-zero return code", "rc": 127, "start": "2022-03-04 10:24:01.965929", "stderr": "/bin/sh: 1: docker-compose: not found", "stderr_lines": ["/bin/sh: 1: docker-compose: not found"], "stdout": "", "stdout_lines": []}

Please try to update to the latest version, it should be fixed

tried again on new VM using latest scripts from git, same problem:
FAILED! => {"changed": true, "cmd": "docker-compose down", "delta": "0:00:00.002390", "end": "2022-03-04 14:13:49.246823", "msg": "non-zero return code", "rc": 127, "start": "2022-03-04 14:13:49.244433", "stderr": "/bin/sh: 1: docker-compose: not found", "stderr_lines": ["/bin/sh: 1: docker-compose: not found"], "stdout": "", "stdout_lines": []}
I checked deploy.yml, commit c672e877016021365066089c81a63f96bf31d568 not merged to master

Fixed in #160


Konflux update test-component-pac-jmaplv

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-jmaplv-on-pull-request has failed.
Namespace: build-e2e-ijqq-tenant
PipelineRun: test-component-pac-jmaplv-on-pull-request-k98nb

Task Statuses:

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
23 seconds
build-container

✅ Succeeded
10 seconds
apply-tags

❌ Failed
8 seconds
clair-scan

✅ Succeeded
9 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
8 seconds
deprecated-base-image-check

✅ Succeeded
14 seconds
sast-snyk-check

✅ Succeeded
12 seconds
ecosystem-cert-preflight-checks

✅ Succeeded
15 seconds
push-dockerfile

✅ Succeeded
6 seconds
show-summary

✅ Succeeded
8 seconds
show-sbom

Failure snippet:
task clair-scan has the status "Failed":
Inspecting raw image manifest quay.io/redhat-appstudio-qe/build-e2e-ijqq-tenant/build-suite-test-application-yedo/test-component-pac-jmaplv@sha256:2a1f67c9693d2d936e9173e9c65032971c4a63bc0fb22594c97a7b8e2d60c629.
time="2024-07-17T12:34:37Z" level=fatal msg="Error parsing image name \"docker://quay.io/redhat-appstudio-qe/build-e2e-ijqq-tenant/build-suite-test-application-yedo/test-component-pac-jmaplv@sha256:2a1f67c9693d2d936e9173e9c65032971c4a63bc0fb22594c97a7b8e2d60c629\": reading manifest sha256:2a1f67c9693d2d936e9173e9c65032971c4a63bc0fb22594c97a7b8e2d60c629 in quay.io/redhat-appstudio-qe/build-e2e-ijqq-tenant/build-suite-test-application-yedo/test-component-pac-jmaplv: manifest unknown"
The raw image inspect command failed

Pipelines as Code CI/test-component-pac-jmaplv-on-pull-request has successfully validated your commit.
Namespace: build-e2e-ijqq-tenant
PipelineRun: test-component-pac-jmaplv-on-pull-request-mj7gc

Task Statuses:

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
20 seconds
clone-repository

✅ Succeeded
24 seconds
build-container

✅ Succeeded
12 seconds
clair-scan

✅ Succeeded
17 seconds
ecosystem-cert-preflight-checks

✅ Succeeded
9 seconds
deprecated-base-image-check

✅ Succeeded
42 seconds
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
9 seconds
apply-tags

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
9 seconds
push-dockerfile

✅ Succeeded
12 seconds
show-summary

✅ Succeeded
8 seconds
show-sbom

Pipelines as Code CI/test-component-pac-jmaplv-on-pull-request has successfully validated your commit.
Namespace: build-e2e-ijqq-tenant
PipelineRun: test-component-pac-jmaplv-on-pull-request-76hh2

Task Statuses:

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
23 seconds
build-container

✅ Succeeded
9 seconds
apply-tags

✅ Succeeded
46 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
8 seconds
push-dockerfile

✅ Succeeded
14 seconds
ecosystem-cert-preflight-checks

✅ Succeeded
12 seconds
clair-scan

✅ Succeeded
9 seconds
deprecated-base-image-check

✅ Succeeded
7 seconds
show-sbom

✅ Succeeded
10 seconds
show-summary


[Feature request] Import a filesystem image

I need to import the content of ext4 filesystem image into my Docker image.
Currently, I need to mount the image somewhere then use COPY in order to import the content.
I would be easier if I could extract the image directly from the Dockerfile.

Mounting a filesystem is a high security risk, as it is untrusted input and the kernel has fairly unsafe paths. You can use eg libguestfs to read a filesystem image in userspace, that should just work in a docker build.

I tried using libguestfs during build but it seems it requires a privileged container:
libguestfs: trace: mount_local "/data/local/tmp/system-readonly/"
libguestfs: guestfs_impl_mount_local: fuse_mount /data/local/tmp/system-readonly/
fuse: failed to open /dev/fuse: Operation not permitted
libguestfs: error: fuse_mount: /data/local/tmp/system-readonly/: Operation not permitted

I'm going to close this issue, because this is not something we'll implement, but feel free to continue the discussion here


[BUG] Program freezes when I insert and then update the LiteDB in version 5.0.18 and 5.0.19

Version
LiteDB 5.0.19/Windows 11/.NET 8.0
Describe the bug
Everything is fine when I used LiteDB 5.0.17. When I upgraded to 5.0.18 or 5.0.19 is when the bug occurred
Code to Reproduce
I have created and attached a small program to reproduce the issue. The program reads a Northwind SQLite database and created and write the database tables and columns into a LiteDB database called FileOne.db on the desktop. The bug occurred when an insert followed by an update to the LiteDB database.
I have also included a video showing everything is fine with LiteDB 5.0.17 but when I upgraded it to 5.0.19, the program freezes.
Expected behavior
A file called FileOne.db is created at the desktop and the program does not freeze.
Screenshots/Stacktrace
An example program and a video are attached.
Additional context
Add any other context about the problem here.
ImportDBUsingLiteDB.zip
https://github.com/mbdavid/LiteDB/assets/61445498/b772dfeb-5734-4edc-8d87-81f716e499bf

@KC7465128305 I think the problem is in the test program. LiteDB and specifically DiskWriterQueue creates threads on the current TaskScheduler. This may be questioned as a choice but in the current situation, it causes a deadlock.
This is the code from the demo - it deadlocks in the continuation part. I think you should be able to rewrite this in a more standard way and it passes just fine.

@KC7465128305 https://github.com/mbdavid/LiteDB/pull/2447 this should fix your problem. You can workaround it by changing your code as well but it should not be required.

@KC7465128305 #2447 this should fix your problem. You can workaround it by changing your code as well but it should not be required.

After I switch from TaskScheduler.FromCurrentSynchronizationContext() to TaskScheduler.Default I can upgrade to version 5.0.19. Thanks for the pointer.


NuGetPack and (un)portable nuspec files

I am on Mac OS and would like to create a nuget package with NuGetPack. The nuspec file contains a file-element:
<file src=".\bin\Debug\MyLib.dll" target="lib" />

When doing ./build.sh it complains File not found: '.\bin\Debug\MyLib.dll'.. This issue originates from nuget/home#913. It will be (hopefully) fixed in nuget 3.4 so you can close this issue once the nuget issue is resolved.

Back slashes are not valid file separators on *nix. Try changing \ to / and see if that help.
You might also have to provide a base path for NuGetPack through NuGetPackSettings.

Thanks, specifying everything inside a NuGetPackSettings and don't using a .nuspec-file works!


GeoServer example refresh for DCOS 1.9

Addresses #77

Great, thanks for the update about the other patch! Can you just leave a comment in this PR when that universe patch has merged so we know it's time to give this another spin? We don't want to merge this one until it works publicly and easily for everyone.


Auto-Expand network on boundary 'Paste Here'.

Is your feature request related to a problem? Please describe.
Since we now have the option to enlarge the network both in width and height, why not auto-expand in the required direction(s) when a 'paste here' exceeds the right or bottom boundary? Much more user friendly than the message box.
Describe the solution you'd like
Proper execution of this would be the following:

When paste here is called, determine how many extra rows and columns are needed.
If desired, add a few rows and columns extra so as not to have the new section 'on the edge'.
Stop the engine if running.
Expand the network, making sure the original neurons end up top-left, and their charges are retained.
Copy the section to paste in the proper place. This includes the charges that were present in the original.
Restart the engine if it was running before.

Describe alternatives you've considered
None considered.
Additional context
Add any other context or screenshots about the feature request here.

Some investigation shows this is easier said than done: expanding the network in file properties also clears the current selection, so in the case of an auto-expand it would clear the very selection we are attempting to paste. Maybe we should first see if we can do the expand in properties without clearing the selection, or with clearing it at the end of the expand. If that works, then expand before paste would work also.

This might not be too difficult. Cut-Paste already has code which can map neuron locations from one array size to another. This is also a MoveOneNeuron.
Seems like they could be merged into a rewrite of resize array which would work quickly and easily and replace the cockamamy cut-paste system which is used now in PropertiesDialog. .

I already got the auto-expand to work, but pasting what is selected before the paste will now still go to the incorrect location because the targetneuronid is based on the old columns and rows, and needs to be translated to the new size.

but that might be caught with a GetNeuronLocation() and a GetNeuronIndex()


The favicon is not visible  on scholarship, login and sign up pages

Description
The visibility of the favicon on scholarship, log in and sign up is missing , which led to Visitors to not easily identify the page they are on and make it difficult to navigate the website
Steps to Reproduce
going to the html and css styling and finding the tags and fixing the issue.
Expected Behavior
load favicon on scholarship, login and sign up pages
Actual Behavior
favicon not visible on scholarship, login and sign up pages
Screenshots

Additional Information
@aditya-bhaumik can you assign this issue to me with labels "gssoc-ext" with levels ,"hacktoberfest-accepted";
What browser are you seeing the problem on?

[ ] Firefox
[X] Chrome
[ ] Safari
[ ] Microsoft Edge

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@VidhanThakur09 sure go ahead
Make sure to join the discord server for further communication
Don't forget to star the repository
Complete the task in next 2 days and kindly mention your issue # in your pr like this:
Closes #IssueNumber
Note: the level of the issue may change based on the quality of the PR code

@VidhanThakur09 sure go ahead
Make sure to join the discord server for further communication
Don't forget to star the repository
Complete the task in next 2 days and kindly mention your issue # in your pr like this:
Closes #IssueNumber
Note: the level of the issue may change based on the quality of the PR code

Thank you for assigning this to me. And I am already joined in discord.


Reparse string soqls

Soql sentences were only recognized as such when they were in the format "[ SOQLSentence ]" and not as strings, for example Database.query(' SOQLSentence ').
In order to solve this issue, whenever a query was recognized as a String, this need to be re-parsed as a SOQL_EXPRESSION

looks good, thank you..


app.route() code is error ? [guide/routing.md]

this code
app.route('/book')
  .get(function(req, res) {
    res.send('Get a random book');
  });
  .post(function(req, res) {
    res.send('Add a book');
  });
  .put(function(req, res) {
    res.send('Update the book');
  });

should be
app.route('/book')
    .get(function(req, res) {
      res.send('Get a random book');
    })
    .post(function(req, res) {
      res.send('Add a book');
    })
    .put(function(req, res) {
      res.send('Update the book');
    })
;

sorry for my poor English.

Yes, those semicolons should not be there. It's an error from PR #362 @hacksparrow can you audit all the semicolons that were added in that PR? it looks like it may have just been a find-replace job instead of an actual "add where they need to be".

Fixed by #370


Fix SSR issue when global.window object exists

This issue is actual when during SSR we use global.window = { Vue } for different workarounds.

LGTM! I'll merge it later today since I will have to release it, and don't have time right now!


fix: Improve search bar

Changed to production Algolia index, various tweaks to styling to make dropdown menu more readable on different screen sizes, and added a check to make sure users can't go to the search results page while the input is blank. Also changed the search results page to use camel case keys when accessing the new index objects.
:rotating_light: Warning! This cannot be deployed until we update the index on Algolia. Otherwise search will break. :rotating_light:

For testing locally, make the following changes in partials/algolia-search.hbs:
const client = algoliasearch('UEF9OFK81T', 'a63875e3cfefcb58cfd893df4e731411');
const index = client.initIndex('test_news');


SIMD Support

SIMD Is fairly new with the System.Runtime.Intrinsics corefx library, but, could we use the new hardware vectors for SIMD operations on hardware that support it with the dotnet core CLR.
I know this may be too specific since it only works with the dotnet core 3.0+ CLR at the time of writting but since the .net framework is going to be at the 5.0 state where in theory all this will be unified, would be a nice adition to the library for a better performance in hardware that supports SIMD Instructions.
I think we should wait for the official .net 5 but still, it's not a bad of an idea to at least think about it.

I've been considering where I want to take Ultraviolet over the course of the next year. One of the things I want to do is to completely rework the project structure in anticipation of .NET 5 -- if my personal life ever settles down to the point where I can invest a substantial amount of time in this project again. For various reasons, 2019 has been kind of a crazy year for me personally, but I'm really hoping that I can start prioritizing Ultraviolet development again in the new year.
Probably what I'm going to do is deprecate the .NET Framework branch entirely and move to .NET Core for all future development. I think Core is mature enough at this point, and CoreCLR is where all of the interesting new features are, after all, including SIMD. Eventually I would like to eliminate all of the various platform-specific projects entirely, since maintaining them all is a huge amount of work for me; I'm hoping .NET 5 makes this possible, whenever it ultimately gets released.

I want to help in this then, since lately I have developed a few game related tools and some extensions for ultraviolet (Thinks more personal for my game development experience, will open source when I have something good), I love the framework more than monogame and love some of the ideas that this project have, the .net 5 announcement made me very happy, since I could drop some side work I have to do with .net framework, .net core and thinking about mono.
I think the right think to do is to pass to .net core since I think that will be the majority of the .net 5 release, and since .net core 3 can publish to all mayor PC platforms the only things to really maintain is the IOS and Android package (Since so far, I don't see signs of .net core on android or IOS but that would be so good) until the release of .net 5.
Meanwhile the API stays the same, it should not break current projects based on the framework, I might have free time after this last stressful days, and maybe I can get some work in this project too.


Provide ability to flush DNS cache or hookup a custom DNS cache provider

Currently the Router initializes a DNSCache and that cache lives on for the life of the JVM. Can we provide a way to do one of the following:

Provide means to flush the existing DNS Cache
Enable / Disable DNS Cache using configuration
Provide a custom DNS Cache implementation

We encounter issues where we make changes to our infrastructure and the membrane has to be restarted in order to pick up the changes. We would like membrane to honor the TTL for a DNS and then flush its DNS cache or provide means by which we could provide a custom implementation.

Hi,
thanks for the issue and your ideas. We will consider that shortly and come back to you.
Thomas

Unfortunately, there is no way to get the DNS TTL in Java (aside from re-implementing a full DNS resolver).
Starting with master (or any future release cut from the master branch), you could use
        <serviceProxy>
            <path>/clear</path>
            <groovy>
                spring.getBean("router").dnsCache.clear();
                Response.ok().build()
            </groovy>
        </serviceProxy>

(Note, however, that clearing the DNS cache has a performance impact on the next HTTP request for each target, of course.)


HeredocToNowdocFixer - Fix convertToNowdoc return type

👍 but should target 2.2.

Oops 🤦♂

@ntzm please combine all that typos into one PR

Putting all in one PR


Artisan view:cache not caching vendor views

Laravel Version: 7.0.2
PHP Version: 7.4.2
Database Driver & Version: n.v.t.

Description:
As discovered because "Allow disabling checks for expired views" (#31206), php artisan view:cache does not seem to generate cached views for vendor views.
This does not look like an issue with the expired views check disabling but a "bug" (or maybe better "omission") from the view:cache command to consider vendor views.
Steps To Reproduce:
Install Laravel + Horizon and run php artisan view:cache, add VIEW_CHECK_EXPIRATION=false to your .env and visit /horizon.
This should produce something like:
include(/var/www/staging/storage/framework/views/737e90b7e3fd02fa774d19f2efa426527c54bb06.php): failed to open stream: No such file or directory (View: /var/www/staging/releases/20200305214528/vendor/laravel/horizon/resources/views/layout.blade.php)

Another report on the original PR: https://github.com/laravel/framework/pull/31206#issuecomment-595569353.

Ping @browner12

I do hope this means it's temporary reverted until view:cache can also compile vendor views?
I really like this feature in itself and as said this is not an issue with the feature reverted.
Could we keep this (or another issue) open until someone wants/can improve the view:cache behaviour to also include vendor views so this feature can be brought back?

@stayallive since the bug for this was fixed for now there's no reason to keep an issue open on this repo. You're free to open one on the ideas repo if you like or attempt a new pr.

sorry to resurrect an old issue, but did anyone ever confirm this issue and that view:cache did not handle package views?
I've been messing around with the command all day, and as far as I can tell it's compiling views from packages registered in the default loadViewsFrom() method and in the publishes() custom vendor directory.
there don't appear to be any relevant changes that would have fixed this behavior from 2 years ago.


works wonderful, thanks

Hi,
pishrink works wonderful:
pishrink.sh v0.1.2
pishrink.sh: Copying idroid-201912-rasp+omv.img to idroid-201912-rasp+omv-shrunk.img......
pishrink.sh: Shrunk idroid-201912-rasp+omv-shrunk.img from 15G to 2,1G...
saves 13G!
thanks for the script!
Some observations:

have to wait wait pretty long before it begins printing anything. So perhaps an idea is to begin with saying somethink like: reading in data, this can take a while

it could not read in an image with brtfs and asked if it was perhaps ufs. No big deal.

Thanks for the disk-space saver! Also used it to migrate to a bigger sd-card, worked wonderfully!

Not really...
https://github.com/Drewsif/PiShrink/issues/199

Years late but thank you for the nice words 😄


Logging Polishing

Lists:

[x]  Remove the width from all list page table

Output edit:

Better design for output selection to be scalable

[x] Restrict 1 destination per output
[x] Edit form will show warning if someone added multiple destinations for a given output via edit yaml

[x] Horizontal line should be replaced by separator component

All outputs:

[ ] Add TLS/CA fields in form similar to elastic

Flow edit:

[x] The add component should be used instead of the "+"

Need a filter form ⇒ what's the schema (Nick to investigate)

[x] remove the "To Do note"

Navigation:

[x] Bug: no counts for the CRDs

@nickgerace have you had any luck with either of these items?

Adding monitoring graph
Need a filter form

@codyrancher the filter form I finished last week: https://github.com/rancher/dashboard/issues/1908
As for the monitoring graph, we have not taken a look yet.

Moved the overview page monitoring graphs to rancher/dashboard#1968

I moved "Add TLS/CA fields in form similar to elastic" to rancher/dashboard#1191

Fixed


[Monitor] Show error when GPX file is too large

I received a GXP file of 17 MB. (strangely, the file had tenthousands of useless (broken) links to geotagged images).
The upload failed. That's OK, 17 MB is really too big. But I didn't see any error message.

@hgcvm can you try to send the gpx file to me by email?

@hgcvm thanks for providing the gpx file for testing
When trying to upload this file, the response in the browser is:
413 Request Entity Too Large

The nginx logfile has an error message that contains:
client intended to send too large body: 17739584 bytes

I have changed the application configuration and the nginx configuration to allow for messages with size up to 20MB.  After this change the file can be uploaded.
Not closing this issue yet: the error handling in the browser application has to be improved so that a proper error message is displayed when the new limit of 20MB is exceeded, or some other problem occurs during file upload.

Fixed in v4.2.2.


404 at /storage/compose/compose-file-v2.md

I found a broken link : https://docs.docker.com/storage/compose/compose-file-v2.md#volume-configuration-reference
I arrived on this page through: https://docs.docker.com/storage/volumes/

@tallerguy Thanks for your feedback. This issue was fixed in https://github.com/docker/docker.github.io/pull/11670/files. Closing this issue as the URL has been fixed and the updated docs are live.


Is Toro support play video stream partially?

Can this framework support play video stream by partial source?
For example, If I want play one video named ex, but the source from remote divide to ex1, ex2, ex3;
how can I play the video ex continuously by these clips in one content of recyclerView or listView?

This can be done by ExoPlayer specification. Right now I didn't provide the hook into my Custom VideoView but you can always try to make the same one with ExoPlayer's SimpleExoVideoView. Take a look at their Composition MediaSource, it is the core point of this solution.

Thank You!

Sorry about another question, but I really need play video stream in recyclerview.
Is Toro support MPEG-DASH streaming ? I just try play .mpd file but can't work, how can I use it?


⚠ T:Riza Docs has degraded performance

In 16bcd8d, T:Riza Docs (https://docs.triza.dev) experienced degraded performance:

HTTP code: 500
Response time: 18591 ms

Resolved: T:Riza Docs performance has improved in 4e5d248.


clean up README and package.json for SEO

@janedegtiareva I can't add reviewers for this.

@potatodepaulo added whole team to project, now you should be able to add reviewers

Funny merge stuff since local went through two version changes.


Write Vision Statement for RS CSV upload front end

The ReportStream submitter front end is a portal that State and local health departments can have COVID-19 test result submitting entities directly submit COVID-19 test results to in CSV format to ReportStream, in the format required by the State.  The goal of the portal is to build in data validation upon submission in order to give the submitter immediate feedback regarding their submission, which will facilitate corrections if needed at the point of submission, rather than after review of the file by the State/ Local Health Department.  The portal will initially allow for constrained formats as determined by a particular State/ local health department, and will validate against those specified formats.  The portal will introduce registration and authentication processes that may not exist today in States with health departments that have portals with no registration or authentication (URL link only).  The portal should relieve burden on the State / local health department from doing manual or automated data validation and subsequent outreach activities to seek corrected files from the submitter.  For results accepted into ReportStream, HL7 lab results will be generated and sent to the respective State / local health department.  The portal may ultimately serve as the way to both manually submit CSV files as well as set up sFTP connections.  The portal may also be used to accommodate other submission methods including setting up for REST API transmission of test results (issuance of tokens), and also may grow into accommodating other reportable disease types in addition to COVID-19.


Update components to accept Woodwork inputs

Continuation of work for #1288
Relevant: https://github.com/pandas-dev/pandas/issues/30038
Had to tweak _convert_woodwork_types_wrapper to properly handle how NaN was converted from nullable array --> pd.Series/DataFrame.
Ultimately, I updated s.t. functionality is preserved as it would be for Series/DataFrames.
A column with booleans + nulls using nullable types will be inferred as 'boolean' type. However, this causes a problem when converting to 'bool' type since NaN values are not allowed and will error out. Converting to bool type by manually handling will convert nan values to True--undesirable. Hence, we will convert to object type (and allow SimpleImputer to fill in the values!)
s = pd.Series([True, np.nan, False, np.nan, True], dtype='bool')
--> converts nan to True
s = pd.Series([True, np.nan, False, np.nan, True])
--> dtype = object, no conversion

https://stackoverflow.com/questions/36825925/expressions-with-true-and-is-true-give-different-results
https://app.circleci.com/pipelines/github/alteryx/evalml/7300/workflows/0d609f82-10ba-4cf8-84b2-01e9ecf7864f/jobs/81615

@freddyaboulton You're right that there are certainly some situations where the conversion to Woodwork structures doesn't add value here, but I think it is fine to add for consistency, and allows automl to pass the woodwork structures down to the components without worrying about the data structure. Currently, we're in this weird intermediate state where that's not true, but once work has been done in #1289 to pass the Woodwork data structures directly to the pipelines, which passes it to the components, the conversion code will basically be a no-op! Having the conversion code handled in these util methods also allows us to get rid of the if isinstance(X, pd.DataFrame) (or checks for Woodwork) blocks, because it's handled in a centralized place :)
I see your concern with the conversion though, and it's difficult to fully see how time consuming or how much more memory this takes. If this gets out of hand, we can revisit and optimize? 😁

I see your concern with the conversion though, and it's difficult to fully see how time consuming or how much more memory this takes. If this gets out of hand, we can revisit and optimize? 😁

Yep that sounds good to me. If we can get #1289 done quickly, this won't matter, because automl search will handle the conversion to woodwork types first before the pipelines/components do their thing. And if not, and we do see problems with automl resulting from this, we can do another release quickly once #1289 is merged.
One thing to check before merging is that the unit tests don't take significantly longer to run than on main. If they did, that could be potential evidence that there's a problem. This is unlikely though because we don't use large datasets in our tests.
Given that we're talking about performance, @angela97lin how would you feel about running some perf tests on this? I think it would be fine to merge this and test after the fact, since we know this is an intermediate step along the way, but it would help us decide when to release.

@dsherry Yup, that sounds good! I'll merge this in first, and if we don't have time to merge in the automl change before the next release, I'll run some perf tests to make sure the conversions aren't taking too long.


[vcpkg] z_vcpkg_get_cmake_vars(): Use build-type-specific cache variable if VCPKG_BUILD_TYPE is defined

Describe the pull request
Some ports (e.g. gettext) execute debug and release builds manually (with different options). If a globally cached copy of cmake vars file is used, the second build type has no cmake vars defined (e.g. CFLAGS is empty) because generated and globally cached cmake vars file includes only cmake vars for the first build type.
For example,

gettext[tools] build first runs build_libintl_and_tools(BUILD_TYPE "release") first which causes cmake vars file to be generated with the following contents (the example is for x64-windows-static):

include("${CMAKE_CURRENT_LIST_DIR}/cmake-vars-x64-windows-static-rel.cmake.log")

then build_libintl_only(BUILD_TYPE "debug") is run, but cmake vars file is cached and debug build vars include() is not generated and used

What does your PR fix?

Currently, gettext[tools] windows static builds fail with the following error (because CFLAGS for debug are lost and empty):
-- Performing post-build validation
Invalid crt linkage. Expected Debug,Static, but the following libs had:

    C:\vcpkg\packages\gettext_x64-windows-static\debug\lib\intl.lib: Release,Static

To inspect the lib files, use:
    dumpbin.exe /directives mylibfile.lib
Found 1 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile:
    C:\vcpkg\ports\gettext\portfile.cmake
-- Performing post-build validation done

Which triplets are supported/not supported? Have you updated the CI baseline?

all

Does your PR follow the maintainer guide?

N/A
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Don't generalize what is done in gettext. It is special because building it takes really long, in particular the tools. Maybe it needs another tweek in gettext to get the cmake variables cached before touch VCPKG_BUILD_TYPE.

Don't generalize what is done in gettext. It is special because building it takes really long (on windows), in particular the tools. Maybe it needs another tweek in gettext to get the cmake variables cached before touching VCPKG_BUILD_TYPE.

this will require calling z_vcpkg_get_cmake_vars() from gettext portfile.cmake which I think is a greater evil than fixing caching in z_vcpkg_get_cmake_vars()

Thanks!

@strega-nil-ms please see my last review comment. I realized there will still be a file name clash

@mkhon You need open a new PR to fix it.

@mkhon You need open a new PR to fix it.

See #22501


Rename package from org.domino to domino

Domino is a scalacode.org project, and should be packaged as such.

Many other libraries simply use their library name as their package name. I think that's cleaner.

Done.


build: Upgrade mocha from ^9.2.0 to ^10.3.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (ed43d59) to head (203ee30).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          128       128
=========================================
  Hits           128       128


refactor tests for migrationhierarchy controller and webhook

The tests for the controller and webhook need to be refactored due to changes in the code.
/good-first-issue

/remove-help

/kind failing-test


alt text is not read as element isn't focusable [Global]

Scenario to reproduce
All images in the app are not focusable. With this behaviour TalkBack and VoiceOver are unable to access the alt descriptions for the images.
Expected result
To be read the alternative text for images.
Bug or issue / WCAG
1.1.1 Non text content
https://www.w3.org/TR/WCAG21/#non-text-content
Screenshots where available

Device + OS
iPhone 8 | 13.5.1

hi @JuliannaR  , what should the voice over text say ? I am providing the text that's same as the main Title e.g.g ("How COVID alert works")

@its-anirudh
There is defined alt text for each image in the app. They are in the figma file.
EN: A hand-drawn illustration of a mobile phone in a pocket, sending and receiving signals.
FR: Dessin à la main d’un téléphone mobile dans une poche, qui envoie et reçoit des signaux.
Using the heading text doesnt give context and these images are not decorative, they convey meaning.

@its-anirudh The alt text issue impacts all images throughout the app screens in the onboarding and how it works flows.

@JuliannaR Added the alt text for How-to, and a potential fix for consistent VO navigation in the latest commit.

+1 Thanks @its-anirudh

fixed in V13.


Adopt a Code of Conduct

A code of conduct is a common practice to foster a kind, inclusive, cooperative, and harassment-free community. Adopting a code of conduct would demonstrate that new contributors will be welcomed and respected.

Open Code of Conduct adopted, merged in #142
Thanks. :+1:


[dev-ts]Absolute import support

The import statement should support the absolute path for the typescript template.
Expected -
import Components/MyComponent
Actual -
import ../../../../MyComponent :(
I would suggest avoiding extra files or extra npm libraries. See if webpack can help to achieve this.
P.S - Raise PR against dev-ts branch

Could you please assign this issue to me?

Yup. Assigned!!

 Create React Saga v1.x


Issue with typecasting in assertions

Issue
Vyper performs implicit conversion for ==, causing a few previously uncaught sources of error.
For example in deposit and logout function, assert self.current_epoch == block.number / self.epoch_length which converts self.current_epoch to decimal rather than converting block.number / self.epoch_length to an int. This line should instead be assert self.current_epoch == floor(block.number / self.epoch_length).
Proposed implementation

Fix assertions mentioned above
Comb the contract for other incorrect implicit type casting and fix
add any relevant tests.

Addressed in #56


Testing: bad inline actions contrast upon selected tree item

Refs: https://github.com/microsoft/vscode-python/issues/17040
I suggest to use white for action icons when selected item and hovered, since black on blue does not give it enough contrast. All other trees do this as far as I know.

Here's open editors as an example

fyi @karthiknadig @misolori

@isidorn this is completely dependent on your theme, our default dark/light theme show them appropriately:

Which theme are you using @isidorn? It seems like in is globally styled by
https://github.com/microsoft/vscode/blob/77905c850e170eab00cac5ca190c7b1fe5ad43ba/src/vs/base/browser/ui/list/listWidget.ts#L791-L791
which should be applied herer

That looks like the GitHub Sharp theme which has the same style applied in other list views:

Setting the following would address this in the theme:
  "workbench.colorCustomizations": {
    "[GitHub Sharp]": {
      "list.activeSelectionIconForeground": "#f0f0f0"
    },
  }

Sorry for the noise.
I will provide a PR against the theme. No need to keep this open in VS Code.

Good point by @joaomoreno
@misolori @aeschli Why isn't activeSelectionIconForeground inheriting from activeSelectionForeground?

It feels like it should be the default.

The default is null because majority of themes have different active states in lists + suggest widget + quick pick and there is not a single solution that solves it for all, see https://github.com/microsoft/vscode/issues/125998 for details.


Update ITCSS

As on cartridge/issues/37

Closing this issue since elements is correct.
See: https://github.com/itcss/itcss-netmag/tree/master/css

Upto you, it seems they're interchangable
https://youtu.be/1OKZOV-iLj4?t=32m13s
https://github.com/csswizardry/csswizardry.github.com/tree/master/css
https://speakerdeck.com/dafed/managing-css-projects-with-itcss
😉

I do feel elements is more descriptive than base. It's almost implied that base means 'base elements'. Changing to base would also require a major semVer bump, due to config file changes. 👍


Question about the condition of response for interrupt injected by  hvictl

Hi @jhauser-us , I have some question about interrupt injected by hvictl. As spec says:

if hvictl fields VTI = 1 and IID ̸= 9:

the major interrupt specified by hvictl fields IID, DPR, and IPRIO.

if this case hit, the condition of response for interrupt is VTI = 1, IID interrupt can be delegraded to VS mode, and current privilege mode is VS or VU, there's no need to set vsie[IID] to 1, right?
Continuing from question 1, if the core response the interrupt injected by hvictl,  it must trap to VS mode, right?

Thanks.

@myx922, for your first question, it sounds like you think there is an additional requirement that the major interrupt indicated by hvictl.IID is delegated or injected to VS-mode by hideleg or hvien.  If so, that is incorrect.  The contents of hideleg, hvien, hvip, vsip, and vsie are all ignored for this interrupt candidate (number 5 in the list of 5 possible candidates).  All that matters is what the spec says that you quoted:  hvictl.VTI = 1 and hvictl.IID != 9.
The rules from that AIA section ("Virtual supervisor top interrupt CSR (vstopi)") determine the value of vstopi at all times.  Your second question is answered by the next section ("Interrupt traps to VS-mode"), which specifies how and when the value of vstopi leads to a trap to VS-mode.  The value of vstopi has no effect on traps to privilege modes M and HS.
(But concerning the exact timing of an interrupt trap, see also what the Privileged ISA spec says in the section titled "Supervisor Interrupt Registers (sip and sie)", in the paragraph that begins, "These conditions for an interrupt trap to occur must be evaluated in a bounded amount of time ....")

@jhauser-us ,from your response, I understand that if 'hvictl fields VTI=1 and IID=1', even if vsie [1]=0, an SSI will be injected into the VS level, and if the current privilege mode is VS mode and vsstatus SIE bit is 1, a trap is taken to VS mode. I am confused as to why injecting SEI into VS level using hvictl requires vsie [9]=1 and does not require hvictl VTI=1, but using hvictl to inject other interrupts do not require these two conditions.

Setting hvictl.VTI = 1 allows major interrupts to be injected into VS level, even when the corresponding bits in vsip and vsie are hardwired to zeros.  When hvictl.VTI = 1, attempts by VS-level software to access sip and sie are trapped and must be emulated by the hypervisor.  It is for this combination of reasons that the values of the real vsip and vsie are mostly ignored when hvictl.VTI = 1.
Setting hvictl.VTI = 1 will result in some loss of performance because of extra trapping.  A special case has been made to allow artificial SEIs (major code 9) to be injected with hvictl.VTI = 0.  When hvictl.VTI = 0, the values of vsip and vsie are visible to VS-level software, so it's important that they be set correctly, even when an SEI is artificial from hvictl.  Unlike many other major interrupts, we know that bit 9 in vsip and vsie can always be manipulated by the hypervisor (those bits cannot be hardwired to zeros by a hart implementation).

Thanks

VS-level is S-level in a virtual machine.  The question to ask is not what interrupts the implementation wants to support but what interrupts the software running in the VM expects to work.
Paravirtualization is a popular technique where the software in the VM is expected to know and/or adapt (at compile time or run time) to what the hardware actually supports.  However, the RISC-V H extension is designed to provide VM support that goes beyond paravirtualization.  The software in the VM may have been originally compiled for a different machine than the one currently running it.

thanks


derivative node returns value from the future

The derivative() node computes the derivative between a point, and the one that follows it, but adds the calculated derivative value to the first point, not the second.
This is counterintuitive as this is not how a derivative is defined, nor is it how InfluxDB's derivative behaves.
Additionally the behavior results in the derivative() node buffering a point. If it behaved as expected, buffering would not be necessary.
foo v=1i<PHONE_NUMBER>
foo v=2i<PHONE_NUMBER>
foo v=4i<PHONE_NUMBER>
foo v=8i<PHONE_NUMBER>
foo v=16i<PHONE_NUMBER>

stream|from().measurement('foo')|derivative('v').as('derivative')|log()

Expected:
"Fields":{"v":1},"Time":"1970-01-01T00:00:01Z"
"Fields":{"v":2,"derivative":1},"Time":"1970-01-01T00:00:02Z"
"Fields":{"v":4,"derivative":2},"Time":"1970-01-01T00:00:03Z"
"Fields":{"v":8,"derivative":4},"Time":"1970-01-01T00:00:04Z"
"Fields":{"v":16,"derivative":8},"Time":"1970-01-01T00:00:05Z"

Actual:
"Fields":{"v":1,"derivative":1},"Time":"1970-01-01T00:00:01Z"
"Fields":{"v":2,"derivative":2},"Time":"1970-01-01T00:00:02Z"
"Fields":{"v":4,"derivative":4},"Time":"1970-01-01T00:00:03Z"
"Fields":{"v":8,"derivative":8},"Time":"1970-01-01T00:00:04Z"

@phemmer Looking through your examples I agree the actual behavior is quite confusing. We will take a look at the best way to fix this while minimizing any breaking changes to existing behavior.

I actually started work on this. Basically I just adjusted it so that the derivative is added to the latter point, not the former one, and the first point in the stream/batch is dropped (currently in batch the last point is dropped).
But I can abandon the work if you want to handle it yourself.

Go ahead a put up a PR on what you have, we can start the discussion from there. Your solution sounds like what I was thinking.


The web/flutter_bootstrap.js file should contain:
{{flutter_js}}
{{flutter_build_config}}

This is fixed in the next version, but for an existing project you need to update the file.


Add a method for calculating future value of investment.

This method will give the future value of investment(SIP) by taking into consideration the growth rate and number of years

Please assign me under JWOC

@ayushanand308 Go for it.
Make sure to create separate branch and do git pull before PR.
All the best.

I want to work under JWOC @Srijita-Mandal

Work is in progress. I will be making the  commit after some more changes.

Work is in progress. I will be making the commit after some more changes.

Okay.

I would like to work under JWOC @Srijita-Mandal

@Srijita-Mandal  I made a PR but don't know why that got pushed as a different PR. Can you review it that PR I pushed?


Undefined symbols in Solaris/Sparc batchvision build

Undefined symbols are being reported in the Solaris/Sparc build of batchvision:

Undefined                       first referenced
 symbol                             in file
V::VString&Vxa::VSet::getDescription_(V::VString&)const ../lib/libVxa.so
V::VString&Vxa::VType::getDescription_(V::VString&)const ../lib/libVxa.so
ld: fatal: symbol referencing errors. No output written to batchvision
gmake: *** [batchvision] Error 1

Solaris/x86 builds of the same code compile and link successfully.
In all probability, this issue is related to the movement of several classes and other symbol definitions into namespace V from the global namespace (969e803), but that has not been confirmed.

A lot of git activity on Oct 19, 2018 and I overlooked the notification about this issue. (looking further, I think I discovered the issue and @MichaelJCaruso kindly documented it.) Anyway, I have just run into it again, and made a small change to the getDescription_ definitions which resolves the problem on Solaris/Sparc. I hope the change is benign on the other platforms. I will issue a pull request shortly so that the changes can be evaluated on the other platforms which are currently supported.


Improve documentation and README

Codecov Report

Merging #13 (77c3da0) into master (0c30786) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           78        78
=========================================
  Hits            78        78

Impacted Files
Coverage Δ

src/fourier.jl
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c30786...77c3da0. Read the comment docs.

LGTM


Conflict with CSP for stylesheet element with data:text/css

🐞 Describe the bug
When CSP is set to deny all data:, CSS stylesheet are not loaded to DOM in line 654 in feedback.js.
📚 To Reproduce
'style-src' in CSP without 'data:' value. Since 'data:' cannot be explicitly set to text/css, allowing it would allow almost any other form causing a security hole?!
📋 Additional context
Easiest replacement would be to create the style element instead of appending as stylesheet, assign the styles and append it to head or body.
const styles = document.createElement("style"); styles.innerHTML = css; document.head.appendChild(css);

Makes sense. Haven't used CSP with this project yet so it never came up.
Feel free to create a PR for this, I currently don't have time to work on this myself. Will review/merge it.

⚠ This issue has not seen any activity in the past 2 months so I'm marking it as stale. I'll close it if it doesn't see any activity in the coming week.


add travis cf Net

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #121   +/-   ##
=========================================
  Coverage     97.13%   97.13%
  Complexity       95       95
=========================================
  Files            19       19
  Lines          1222     1222
  Branches         68       68
=========================================
  Hits           1187     1187
  Misses           31       31
  Partials          4        4

Flag
Coverage Δ
Complexity Δ

#csharp
95.29% <ø> (?)
0 <ø> (?)

#go
98.75% <ø> (ø)
0 <ø> (ø)
:arrow_down:

#java
99.05% <ø> (ø)
95 <ø> (ø)
:arrow_down:

#node_js
100% <ø> (ø)
0 <ø> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6beef...9932dd6. Read the comment docs.


Improve path to friends screen

The main goal of that PR is not to leave an empty friends row on the home when user doesn't have friends.

[x] Adds cell at the end of the list of friends to add more (especially useful when the list is empty)

[x] Centers scroll content when content is smaller than scroll area
[x] Add option not to center content in situation where it makes more sense visually
[x] Add nice image background in the cell

Next, we need to take care of the friends screen itself and propose a few options / suggestions to easily connect with friends.


Add files UAIS

Universidad Autonoma Indigena de Mexico

@DrManhattanMR First stage of verification passed, official domain is uaim.edu.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: http://uaim.edu.mx/turismo/index.php/modalidades

@DrManhattanMR Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Records selection on current page only

Bulk actions are very helpful, but the selection function in bulk actions takes all the records in the database, maybe with small records it is still fine, but it will reduce performance as more records in the table are increased.

see the select  count(*) as aggregate from 'blog_posts'
so I think it would be better to add options where we can only select the records that appear on the current page instead of selecting all existing records.

thank you

Thanks!


Define _CRT_SECURE_NO_WARNINGS to remove unneeded warnings in MSVC

MSVC prints out warnings like

warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead.
warning C4996: 'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead.

We cannot use fopen_s or _dupenv_s because they are Microsoft extensions and are not supported by POSIX-like OSes (including Linux).
Fix: Define _CRT_SECURE_NO_WARNINGS macro to ignore such warnings. The effect will be to declutter build logs and to speed up builds slightly (console printing on Windows is slow).
TODO: File a PR to dmlc-core and rabit to define  _CRT_SECURE_NO_WARNINGS there too.

Will revisit later. Somehow _CRT_SECURE_NO_WARNINGS doesn't get propagated everywhere.


modal not begin from bottom

I try to make modal that begin from bottom of the screen until the middle of screen, but it always have little space between bottom to the modal and I don't want it.

I want the modal begin from the bottom.
import React, { Component } from 'react'
import { View, Text, Platform, Linking, Image } from 'react-native'
import { Button } from '..'
import style from './style'
import Modal from 'react-native-modal'
import Colors from '../../utils/Colors'

class MakeAppointmentModal extends Component {
  constructor(props) {
    super(props)
    this.state = {
      modalVisible: false,
    }
  }
  componentDidMount = () => {
    try {
      this.props.onRef(this)
    } catch (e) {}
  }

  componentWillUnmount = () => {
    this.props.onRef(undefined)
  }
  setModalVisible = () => {
    this.setState(state => {
      return { modalVisible: !state.modalVisible }
    })
  }

  render() {
    const { container, view_modal, view_container_modal } = style
    return (
      <View style={container}>
        <Modal
          isVisible={this.state.modalVisible}
          backdropColor={Colors.black}
          backdropOpacity={0.8}
          animationIn='fadeInUp'
          hideModalContentWhileAnimating={true}
          animationInTiming={1000}
          animationOutTiming={600}
          useNativeDriver={true}
          onCancelPressed={() => this.setModalVisible()}
          onBackButtonPressed={() => setModalInvisible()}
          onModalHide={() => {
            // this.setModalInvisible()
          }}
          onRequestClose={() => {
            this.setModalVisible()
          }}
        >
          <View style={view_modal}>
            <View style={view_container_modal} />
          </View>
        </Modal>
      </View>
    )
  }
}
export default MakeAppointmentModal

style
import { StyleSheet, Dimensions } from 'react-native'
import Colors from '../../utils/Colors'
import { calcSize } from '../../utils'
import { DIMENSIONS } from '../../utils/Consts'

const style = StyleSheet.create({
  container: {
    flex: 1,
  },
  view_modal: {
    flex: 1,
    position: 'absolute',
    bottom: 0,
    justifyContent: 'center',
    alignItems: 'center',
    shadowOpacity: 0,
  },
  view_container_modal: {
    width: DIMENSIONS.width,
    height: DIMENSIONS.height - calcSize(250),
    backgroundColor: Colors.white,
    alignItems: 'center',
    justifyContent: 'center',
  },
})
export default style

info
"react-native-modal": "^7.0.2",
  "react": "16.6.3",
  "react-native": "0.57.8",

may be you are not taking into account the status bar height. I was facing the same issue (a backdrop color in bottom) but some one saw that i haven't the status bar visible so the modal was screen height - status bar height. I fixed making the status bar visible by now

I have the same issue, but when I use device without hardware buttons, and enable navigation by gestures. tested on redmi note 7

@mmazzarolo It works. Thank you :)

<Modal style={{ margin: 0 }}>....</Modal>
can fix your problem