add AttentionRecommended condition for ClusterOperator Status for potent…

…ial errors around mirroring or proxying
Stemming from a discussion between myself, @smarterclayton , @bparees , and @jwforres around access to external resources in a disconnected environment, per executive order from @smarterclayton (his words, not mine :-) ) a new condition is to be added
See https://docs.google.com/document/d/1LopVzuX2nPVlS4IHkOsUNBuVOeAdkBQ92wkaVB2kTwU/edit# for some additional notes
@derekwaynecarr @adambkaplan fyi since y'all could not make the meeting
PTAL everyone

@gabemontero i fixed the PR title but the commit text doesn't match the actual name of the constant you're adding.
(maybe it's not worth fixing that until we get feedback from others on whether they are happy w/ this constant name)
anyway i'm happy with this name but clearly we need some more feedback

@bparees I followed the same pattern as the existing constants wrt name and associated comment ... they all have that discrepancy
I did not feel confident enough to correct it for all of them, but can if there is a consensus to do so.

sorry you were talking about commit and PR title, not constant and comment

commit now in line with PR title

/hold
Let's do 3 days of discussion and feedback in the doc, with input from Ben's teams, Michal's teams, Alex's teams, and at least 2 release architects
Let's do name discussions in the doc

Based on discussion with Clayton, wouldn't be better to use ActionsRequired ? Attention means that the human operator must take action to fix problem the machine operator can't fix itself. For example, samples operator is broken because it can't fetch image streams unless you set proxy. The ActionsRequired will be then [{"severity":"urgent", "reason": "UnableToImportImages", "message": "unable to import images unless the proxy setting is specified"}].
The list might make more sense if you have multiple actions required. The severity makes sense if you want to convert these into prometheus metrics and create alerts.
I think eventually we might suggests config name and field JSON patch maybe so web console can take the human operator to exact place where he can correct the problem.

Based on discussion with Clayton, wouldn't be better to use ActionsRequired ?

please take this feedback to the doc and we can discuss there

(the doc also discusses why your proposal probably doesn't work for what we need to cover)

Per email from @bparees last week closing this out.
I'll start updating cluster-samples-operator to implement the proposal from @bparees and @smarterclayton

We should update the cvo conditions design doc to include the decision
On Jul 14, 2019, at 3:05 PM, Gabe Montero<EMAIL_ADDRESS>wrote:
Per email from @bparees https://github.com/bparees last week closing this
out.
I'll start updating cluster-samples-operator to implement the proposal from
@bparees https://github.com/bparees and @smarterclayton
https://github.com/smarterclayton
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/api/pull/355?email_source=notifications&email_token=AAI37J6HB5E3OZWFL7VFKALP7N2JLA5CNFSM4H3KK4YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4LLXA#issuecomment-511227356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI37J3E7CVCHFEYMIXPU5TP7N2JLANCNFSM4H3KK4YA
.

We should update the cvo conditions design doc to include the decision

@smarterclayton do you mean my doc, or something else?


G1 Move "F" parameter ?

Making the GCode renderer and I've come across soemthing strange in the "header" after homing:
G1 F6600
Their examples for move (G1) don't say anything about an F argument. Might this be important?

Possibly going hand-in-hand with this, we'd probably also like to know what the bot does when given a move position outside of the area. Does it grind/break? Stop? Move to that point and no further but keep pumping? I can likely fake any required output before it gets to the bot for out of bounds request, but as of right now, the GCode will be rendered out of bounds.

On discussion with Slim, what is likely to happen when a G1 Move is sent out of bounds, it simply moves as far as it can and no more, "truncating" the move to its limits. What is likely preferable is that the gcode renderer cleans up outside movements into a virtual movement outside with no batter drawing until the path returns to the draw area (as I've implemented on CNCServer)

Ok, so near as I can tell from documentation seen elsewhere, G1 F is for setting the "feedrate", basically the speed of the "stuff" coming from the extruder on a CNC platform. I was told at a number of points that this wasn't actually something we can change for the bot, yet we set it?
The feedrate set by Miguel is apparently 5600 (as seen on the delay image), only 1000 units off, I suppose the question is solved, I'll just add this command to the header and assume it won't actually ever change until I hear otherwise.


validateDeploy loses any url's specified on web activities that are within a until or foreach loop

Using git hub action<EMAIL_ADDRESS>Created a pipeline with a 3 web activities

Web activity with a specified url in main pipeline
Web activity within a until activity with a specified url
Web activity within a foreach activity with a specified url
Validated the workspace successfully.
Used the action with operation: 'validateDeploy' with a specified workspace git branch holding the new pipeline.

Once completed successfully no errors on deployment reported.

Went to destination workspace in Synapse studio and hit validate all.
The pipeline deployed however:
2 errors reported 'Please specify and expression' relating to the 2 web activities in until and foreach loops.
On inspection of the activities the url's in settings have not been deployed and are blank.

Note: the web activity (step 1) outside of the loops in the main pipleline validates ok and has not lost the url
Error is any web activity within an until or foreach deployed loses the url on deployment to the target workspace.

Experiencing the same thing - what did you end up doing to get around this?

Experiencing the same thing - what did you end up doing to get around this?

It was while ago we had the issue, I think in end we added it as dynamic content and concat'ed a string value.


Installing to miniconda inside another conda environment fails

It appears that running datalad-installer miniconda datalad when an outer conda environment is already in effect causes datalad to be installed to the outer environment instead of to the miniconda created by datalad-installer.  This results in the check that the datalad executable is in the expected location failing, and this in turn is responsible for the test failures of the datalad-installer recipe on conda-forge.
@yarikoptic Do you know a way around this?

For now may be for miniconda just let's check if we are already having conda executable (ie already in conda) and if so -- error out.  And skip any corresponding test if that is the case.   Later (whenever user expresses desire) we could look into what is really causing using base env -- might be conda itself not allowing for having multiple conda in the PATH and confusing things up

@yarikoptic Just testing whether a conda executable is in PATH means that the miniconda tests (which are most of the install tests) will now not work on GitHub Actions.  The better option would be to test whether Conda is active; how would I do that?

do you mean that conda is already installed by default in github actions environment?
then I guess we could either

indeed just mark the tests like you did in  https://github.com/datalad/datalad-installer/pull/78/commits/3c25472c80e65acba47314bbd35f44011772ed42 and exclude them from running in feedstock
from PATH strip away all paths which provide conda before running tests

@yarikoptic

do you mean that conda is already installed by default in github actions environment?

Yes.
Is there not an environment variable we could check for or a query we could make to conda info to check whether a conda environment is currently active?

@yarikoptic It appears that CONDA_PREFIX is the envvar to check for.


Fix Known Formulas not being prompted to chat from Character Sheet.

Issue: https://github.com/foundryvtt/pf2e/issues/9182
Notes: this was the easiest solution I had to solve this problem, but I don't think it is the best solution.
In my analysis, the problem here is the ActorSheetPF2e class referencing a property of one of its subclasses, CharacterSheetPF2e. Using "private", this implementation offers no problem, since it can be accessed even from the superclass.
However, using this great article as support (https://jamie.build/javascripts-new-private-class-fields.html), I found out that the new private "#" doesn't allow this type of access, even from a superclass.
This was the best workaround I could get without having too much work for the purpose intended, but I'm all ears to a better implementation.

I see the issue and that is silly! That said I don't know if setting this to private is the solution, the entire thing is flawed from the getgo.

I also tend to agree that the current implementation of the base class ActorSheetPF2e magically "knowing" to check itself for possible extended properties seems like a flawed implementation.


Repl does not work well for LF new line character

If you define a simple binding as
the_answer =
  42

it fails with the syntax error.
It works fine with the CRLF though

Hi @zerkms, the elm-repl code has had some re-working since the last 0.5.1 release, and for me using the latest code from master, this seems to be working fine (I can't test the 0.5.1 version because on that version the repl doesn't work for me at all).
If you want, you can try downloading the latest version of the extension from here, into your .vscode/extensions folder, and see if that fixes it.

Sure, I will do today and will close/report on the results. Thanks.

Just tested and this seems to work fine for single line and multiline bindings. I am running the elm repl 0.16.0 version.


SAML signature is optional

ISSUE TYPE

Bug Report

COMPONENT NAME

UI: SAML login

CLOUDSTACK VERSION

<IP_ADDRESS>

CONFIGURATION

SAML authentication activated
OS / ENVIRONMENT

N/A
SUMMARY

The SAML signature is optional and not mandatory. A user can login into a domain where he's not allowed to.
STEPS TO REPRODUCE

Use a tool to intercept the web requests between your browser ant the cloudstack UI (our pentester used "burp"). Login to cloudstack using a SSO account (SAML).
Now, you're logged in successfully to your cloudstack domain.
Logout from cloudstack.
Now, log in again to cloudstack, but with the "interceptor" active. In the request, delete the whole saml-signature and change the username to another SSO user from within another tenant.
Run the modified request, and you're logged in into this foreign account.

EXPECTED RESULTS

User can't log in into foreign tenant

ACTUAL RESULTS

User can log in into foreign tenant

@DaanHoogland @rhtyd Guys, this looks like a pretty nasty security bug. SAML isn't used by default, but regardless this may be a blocker for 4.15 and 4.14.x.

@kiwiflyer yes let's discuss and understand how the env was setup, I suspect it may related to env configuration.
@ngrosc can you share details of your IDP setup? For example the IDP xml metadata, what IDP server are you using (Shibboleth, keycloak etc). Usually, the SP (CloudStack acts as a service provider in SAML terminology) is not in control of whether the SAML token is encrypted or not, and signing and encryption is enforced by the IDP server. For best practices, IDP servers generally should enforce that both signing and encryption be done and (authn) tokens be signed and encrypted (when this is done correct we should see an encryption and sining public key in the IDP metadata xml, for example https://samltest.id/saml/idp). I think only if encryption is not enforced you'll be able to read/extract/change the token parameters, can you try to enforce encryption in your IDP and try your attack/test again? In case that works then we certainly have a blocker.
CloudStack's SAML support (SP) was implemented and tested against Shibboleth and you may use https://samltest.id/ to test the setup. For doc ref: http://docs.cloudstack.apache.org/en/latest/adminguide/accounts.html#using-a-saml-2-0-identity-provider-for-user-authentication

cc @PaulAngus @DaanHoogland

I did a quick code investigation, looks like when there is no encryption in place we get the unencrypted username (uid usually) parameter from the SAML token: (if I recall correctly this was done only to allow and test unsecure IDP servers)
https://github.com/apache/cloudstack/blob/master/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java#L241
... however, I'm not sure if changing the whole SAML token/response should fail at https://github.com/apache/cloudstack/blob/master/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java#L232 which was signed by a signature?
However, if the SAML IDP server has encryption enforced (see for example https://wiki.shibboleth.net/confluence/display/IDP30/SecurityConfiguration#SecurityConfiguration-SigningandEncryptionEnablement) we get the username from the encrypted assertion value:
https://github.com/apache/cloudstack/blob/master/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java#L289

I guess we need exact steps of reproduction if encryption and signing are both enabled. In which case, @ngrosc can you email me privately on rohit AT apache.org? Thanks.
I ran a quick test, this server is SAML enabled: http://primate-qa.cloudstack.cloud:8080/client/master

I tracked both SAML request and response. SAML request (base64 encoded) was encrypted so couldn't decode it, SAML response (base64 encoded) was not but I see the username attribute is not plaintext in the XML as encryption in enforced:
<?xml version="1.0" encoding="UTF-8"?>
<saml2p:Response Destination="http://primate-qa.cloudstack.cloud:8080/client/api?command=samlSso" ID="_12f9925a270fb1652e82e635fa6fde35" InResponseTo="uk3foqohiipf3948r0gn2tavbdgo1gsc" IssueInstant="2020-12-04T16:50:45.549Z" Version="2.0" xmlns:saml2p="urn:oasis:names:tc:SAML:2.0:protocol"><saml2:Issuer xmlns:saml2="urn:oasis:names:tc:SAML:2.0:assertion">https://samltest.id/saml/idp</saml2:Issuer><ds:Signature xmlns:ds="http://www.w3.org/2000/09/xmldsig#"><ds:SignedInfo><ds:CanonicalizationMethod Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/><ds:SignatureMethod Algorithm="http://www.w3.org/2001/04/xmldsig-more#rsa-sha256"/><ds:Reference URI="#_12f9925a270fb1652e82e635fa6fde35"><ds:Transforms><ds:Transform Algorithm="http://www.w3.org/2000/09/xmldsig#enveloped-signature"/><ds:Transform Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/></ds:Transforms><ds:DigestMethod Algorithm="http://www.w3.org/2001/04/xmlenc#sha256"/><ds:DigestValue>Ru6R2nqZCGs532STdqd5alLYCOxgMooNlfww1JWVR4U=</ds:DigestValue></ds:Reference></ds:SignedInfo><ds:SignatureValue>FKUtzP59Vht1Pd77s9jW0KejzbG1m6B2txUyVOi3Y1ioTAg1Xvy/VvxNui8u9G6mVV4s1n5l/gFDGi5v2SIN7YcxH+yX9GJ1TW8XX1WJqxtiDFgGbm+KL8DHeVgyc8kJmAC1zOMRUKOy7arvWc42KmhilAumXbS5oo0qwfnvjNmyhzGQW+lZcMcd/K3eE6ZvdsetRToWlXpnzwKuBqy1iZfZZpxKwgKhBtXDTwCltJjH97FOGP7G9epJH/sfNir/970oNzr+y3TXYL2uDoQKVP5SYOzBPtRvUBR4+qcY0SLIsSNn7X9iXMgKAr2GPfgNMG7zgP4F14ElErYlPiBGgA==</ds:SignatureValue><ds:KeyInfo><ds:X509Data><ds:X509Certificate>MIIDEjCCAfqgAwIBAgIVAMECQ1tjghafm5OxWDh9hwZfxthWMA0GCSqGSIb3DQEBCwUAMBYxFDAS
BgNVBAMMC3NhbWx0ZXN0LmlkMB4XDTE4MDgyNDIxMTQwOVoXDTM4MDgyNDIxMTQwOVowFjEUMBIG
A1UEAwwLc2FtbHRlc3QuaWQwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC0Z4QX1NFK
s71ufbQwoQoW7qkNAJRIANGA4iM0ThYghul3pC+FwrGv37aTxWXfA1UG9njKbbDreiDAZKngCgyj
xj0uJ4lArgkr4AOEjj5zXA81uGHARfUBctvQcsZpBIxDOvUUImAl+3NqLgMGF2fktxMG7kX3GEVN
c1klbN3dfYsaw5dUrw25DheL9np7G/+28GwHPvLb4aptOiONbCaVvh9UMHEA9F7c0zfF/cL5fOpd
Va54wTI0u12CsFKt78h6lEGG5jUs/qX9clZncJM7EFkN3imPPy+0HC8nspXiH/MZW8o2cqWRkrw3
MzBZW3Ojk5nQj40V6NUbjb7kfejzAgMBAAGjVzBVMB0GA1UdDgQWBBQT6Y9J3Tw/hOGc8PNV7JEE
4k2ZNTA0BgNVHREELTArggtzYW1sdGVzdC5pZIYcaHR0cHM6Ly9zYW1sdGVzdC5pZC9zYW1sL2lk
cDANBgkqhkiG9w0BAQsFAAOCAQEASk3guKfTkVhEaIVvxEPNR2w3vWt3fwmwJCccW98XXLWgNbu3
YaMb2RSn7Th4p3h+mfyk2don6au7Uyzc1Jd39RNv80TG5iQoxfCgphy1FYmmdaSfO8wvDtHTTNiL
ArAxOYtzfYbzb5QrNNH/gQEN8RJaEf/g/1GTw9x/103dSMK0RXtl+fRs2nblD1JJKSQ3AdhxK/we
P3aUPtLxVVJ9wMOQOfcy02l+hHMb6uAjsPOpOVKqi3M8XmcUZOpx4swtgGdeoSpeRyrtMvRwdcci
NBp9UZome44qZAYH1iqrpmmjsfI9pJItsgWu3kXPjhSfj1AJGR1l9JGvJrHki1iHTA==</ds:X509Certificate></ds:X509Data></ds:KeyInfo></ds:Signature><saml2p:Status xmlns:saml2p="urn:oasis:names:tc:SAML:2.0:protocol"><saml2p:StatusCode Value="urn:oasis:names:tc:SAML:2.0:status:Success"/></saml2p:Status><saml2:EncryptedAssertion xmlns:saml2="urn:oasis:names:tc:SAML:2.0:assertion"><xenc:EncryptedData Id="_82ae30113dddb0a1a6677d2847cbfae8" Type="http://www.w3.org/2001/04/xmlenc#Element" xmlns:xenc="http://www.w3.org/2001/04/xmlenc#"><xenc:EncryptionMethod Algorithm="http://www.w3.org/2001/04/xmlenc#aes128-cbc" xmlns:xenc="http://www.w3.org/2001/04/xmlenc#"/><ds:KeyInfo xmlns:ds="http://www.w3.org/2000/09/xmldsig#"><xenc:EncryptedKey Id="_34573737ef07781b5a5b2182effbc2db" Recipient="http://primate-qa.cloudstack.cloud:8080" xmlns:xenc="http://www.w3.org/2001/04/xmlenc#"><xenc:EncryptionMethod Algorithm="http://www.w3.org/2001/04/xmlenc#rsa-oaep-mgf1p" xmlns:xenc="http://www.w3.org/2001/04/xmlenc#"><ds:DigestMethod Algorithm="http://www.w3.org/2000/09/xmldsig#sha1" xmlns:ds="http://www.w3.org/2000/09/xmldsig#"/></xenc:EncryptionMethod><ds:KeyInfo><ds:X509Data><ds:X509Certificate>MIIEsjCCApoCCQCHoExIZv8R3TANBgkqhkiG9w0BAQsFADAbMRkwFwYDVQQDDBBBcGFjaGVDbG91
ZFN0YWNrMB4XDTIwMDMwNTE5MzQyMVoXDTIzMDMwNjE5MzQyMVowGzEZMBcGA1UEAwwQQXBhY2hl
Q2xvdWRTdGFjazCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAJzSnSTViczgkNXMWVLI
ccxjdzRG30ptPfBWEsjWdQBgtn/BXEZpj4yeVyYN4p3gdRvtkW6TdwGOyrQksNdAxDhPpG2xQKY7
j01Sato1Kpdk/QfNfTJMd/asdipbgQ/41sttAlO39zn4Q+nmauWJnt7YbWFaAMslRxx7y3nPqfgZ
RlBINK3ltrGYHsvojybjRfGvZ3ewGKeJ7rtSrjGLKbCRqKHYmyFPQxErDaabgEl7/T9wl1kdREl0
UWUiVXcV25Uzq4gZ9253C+KzbAOHyl2MUNJDnPrw4cmwai/mmjvcODNmN4D2wEXQMCYBnoKa+/wl
BEKanoE5pJje9tj84zwnj1UMvU6PXup9RuKcVO7TUsCZPMcKxZn9iKpRIiedWYWBJREL27GP4FTx
cjtBG/4tBzcEGMSXT4Rjcp67yc7NnuSW3XD01olMeGUYdya5t5kkiWIAmxz009SoyopW2MFzufWj
p1uZTeDiO9T+q8hdlSazD7UO3yqrj2ACuAc1xBRI8tbos5ZnQ/ZecR3Z6ZC7uYzJhKoEVDxIC5WI
APYVTTyvXihU1fBIo2ATJpHoI/3IdO8Ug1Xjq5EH+IRCcCXUZbigNxtv+oYQsTt2SpAK4aRhM6T2
f5tk7ZcvCE+DrsL55Wx9RH/iAs2fuY5TrYQulEatWUE1TEJ4JdqdTNeJAgMBAAEwDQYJKoZIhvcN
AQELBQADggIBAAtgfVTPNZbimb4NywnTJx60+LPJ70yCVRuVTzMhmpdpjgqmNYF5l1TEc5pNWvR6
ghJOivr4iWlYFr9mlZ+ifCS2jjde4V3I/Fp4vuzxYXGsw805hSksl+u/BOChq6L32Xf9UVPWwj/Q
xIv1kZ+ZV5uAp4YKAYlAyWO+WknPV6tSYGIjxRNfYacqf0yQPGwSlDG1cAYfBbMxweWD79n0b2ZR
o3e8LPRvODxZigSIW6FG2J4naa8rYxs3B7dSrEKTSMqXLSNqJwEY/7gnwgP/j/NDPtjvRh/ESoUY
dNvDnUQBFK37POI4dJUYSgj4axjBsIE0cvqLoXkO773hRZZzKQima0AwCWTmm2HbeAs8xk4MmDYM
8SsXrbmketEsEq3QgJzyYAeFEvn9Nxrs93KSh/onHaFgI4fo7VVJD4Wwi9nlSsQlCkalcTVJEkbT
upx/0mWGZBQC70Alo9ACr21OgFUDDW5xuewazE7TO6h00WnJe9uuoMV8+5q6yWJKCLCYBaZeVxqu
Pa2bki4+w8ZcWmlc2T9ErhE76hgUjo0Lz3MSfWY+86e4kirZBP3U3zWPVHduyF6bJlik22T879Ns
JG3kPSSrAFvE151cYf2QlqChO/mwbQFurht985Y5uMnnORMU8qTTtoIU8hNQkKrktN4XHEIF3IiI
DxOpmM3iFAVh</ds:X509Certificate></ds:X509Data></ds:KeyInfo><xenc:CipherData xmlns:xenc="http://www.w3.org/2001/04/xmlenc#"><xenc:CipherValue>UTlSgRyKSc/gYMHmCiS4EUHm6vZGoVZUNVfTXupfVP1FNB7B4nelClhajG+soCrLA4LMVdrc2R96vuwJalroS0V7To1WlXCxOoS8qwxVj7npafR65vLNt7DnE/p1p4biphTZOAlEVYBcFEMwTxnugWfnEBaoMZcAFAU4YFd3ZAdlK6Urn41F8bpTxPk9grzRbF2qFZb/KfHonUV9+klhemA64tcQoifyA6EzstZLI2qFvdHxGikZDWwATFBSLYuYJX0cAUp0EBQQvIduQZm2d7UzZwbSRTp+WgN318e4wRFgI0cCjH5MrxDI0B7cW48807s3wJiM1lHIRfYKBy1X/P8zFguBXnWv+5QsADMTyIfCT64s5rBjzJ9ll1+LrLMIFwMlUvKeenMrkhLxELWROS4i21lItDOKCDNdlIKXyVuMlZnt2nVkQqcxNOoFE1qGBhCQqnf7rAMuOwp58ENr6R03VUYYwtZ7z6fPnwVdr1LralhZPJ+kRY/e709wMXQ1n3SeQpP+xhpLhCHlbM1GEXCM76tQTFT1sJlzB1Kv5EqyozLiInWqZsovrGdPCWzfiL2/MDn4M0gxFqQU/kwvsIhFFDC5A6izvX7Hu9noVkEZ3Xk7fLyon+qJmeYDxRbXc2AQAYdadRsha+pPEZq+vSGeYkL7GNKquo8H+q/MBVk=</xenc:CipherValue></xenc:CipherData></xenc:EncryptedKey></ds:KeyInfo><xenc:CipherData xmlns:xenc="http://www.w3.org/2001/04/xmlenc#"><xenc:CipherValue>[encoded data, 8192 characters]</xenc:CipherValue></xenc:CipherData></xenc:EncryptedData></saml2:EncryptedAssertion></saml2p:Response>

Hand-waving the details, it sounds to me like we're saying that it's the IDP that controls whether the token is encrypted.
IF so, I agree with Rohit; This is not a CloudStack issue,  as CloudStack can work with encrypted tokens.
If the IDP is not configured to send encrypted tokens, that's not CloudStack's 'fault'.

+1 on what Paul and Rohit said.
That sounds the same as "if user uses insecure HTTP instead of HTTPS it's ACS security issue"
Cloud operator is in charge of the configuration of everything, encryption included everywhere.

So, agreed that everything should be encrypted. I'm not going to claim in anyway that I'm a SAML expert, but if the username changes, shouldn't we be sending a new AuthnRequest back to the IDP?

hi guys
sorry for the late answer.
we're using https, not http. so that should not be the the main issue.
as IDP, we're using keycloack with the following config:
{     "clientId": "iaas.cloudstack",     "baseUrl": "https://**********/client",     "surrogateAuthRequired": false,     "enabled": true,     "clientAuthenticatorType": "client-secret",     "redirectUris": [         "https://**********/client/api?command=samlSso",         "https://**********/client/api?command=samlSlo",     ],     "webOrigins": [],     "notBefore": 0,     "bearerOnly": false,     "consentRequired": false,     "standardFlowEnabled": true,     "implicitFlowEnabled": false,     "directAccessGrantsEnabled": false,     "serviceAccountsEnabled": false,     "publicClient": false,     "frontchannelLogout": true,     "protocol": "saml",     "attributes": {         "saml.assertion.signature": "false",         "saml_assertion_consumer_url_redirect": "https://**********/client/api?command=samlSso",         "saml.force.post.binding": "true",         "saml.multivalued.roles": "false",         "saml_single_logout_service_url_post": "https://**********/client/api?command=samlSlo",         "saml.encrypt": "false",         "saml_assertion_consumer_url_post": "https://**********/client/api?command=samlSso",         "saml.server.signature": "true",         "saml.server.signature.keyinfo.ext": "false",         "exclude.session.state.from.auth.response": "false",         "saml.signing.certificate": "**********",         "saml_single_logout_service_url_redirect": "https://**********/client/api?command=samlSlo",         "saml.signature.algorithm": "RSA_SHA256",         "saml_force_name_id_format": "false",         "saml.client.signature": "false",         "tls.client.certificate.bound.access.tokens": "false",         "saml.authnstatement": "true",         "display.on.consent.screen": "false",         "saml.signing.private.key": "**********",         "saml_name_id_format": "username",         "saml.onetimeuse.condition": "false",         "saml_signature_canonicalization_method": "http://www.w3.org/2001/10/xml-exc-c14n#"     },     "authenticationFlowBindingOverrides": {},     "fullScopeAllowed": true,     "nodeReRegistrationTimeout": -1,     "protocolMappers": [         {             "name": "username-2-userid",             "protocol": "saml",             "protocolMapper": "saml-user-property-mapper",             "consentRequired": false,             "config": {                 "attribute.nameformat": "Basic",                 "user.attribute": "username",                 "attribute.name": "uid"             }         }     ],     "defaultClientScopes": [         "web-origins",         "role_list",         "profile",         "roles",         "email"     ],     "optionalClientScopes": [         "address",         "phone",         "offline_access"     ],     "access": {         "view": true,         "configure": true,         "manage": true     } }
regarding to PaulAngus' answer:
yes, we have saml.client.signature and saml.encrypt set to false in keycloack. so that might be the issue for all of this. I'll try to change that in an emergency maintenance window an post an update.
thanks for your help!

@ngrosc in that case can you please close the issue. Thanks.

Hi guys
Meanwhile we were able to secure the connection between our IDP and Cloudstack and are now encrypting the assertions.
But the initial issue still exists.
When someone removes the signature, cloudstack accepts this.
Of course, if someone is able to intercept, decrypt, edit and reencrypt the assertion, we have some other major problems.
But from my point of view, it should be possible to enforce signature checking. As far as I understood, the underlying java component has a flag for this, but its not used from cloudstack.
Even it is almost impossible to manipulate such a request, pentesters will classify this as "critical design flaw".

i agree it is an issue but only if a demontrable exploit exists can it be critival, @ngrosc . that said, it should be addressed.

@rhtyd can you shed a light on why teh signature is ignored (and how to fix)?

Needs investigation, I don't remember if it does or does not. However, if the assertions are not encrypted - I suppose that's issue of the overall IDP setup.

Hi Rohit
I completely agree with you. If the assertion is encrypted or not is an IDP
"issue".
But if a signature is present or not, has to be enforced on client side
(cloudstack). Because even when the IDP adds a signature, a man in the
middle can remove it and fake data.
Of course, in case of encrypted assertions only if he has the private key
of the IDP, and then you definitely have other issues..
Nevertheless, it should be possible to enforce the check of the signature.
Then, cloudstack can ensure, that the data is valid..
Am Sa., 6. März 2021 um 11:13 Uhr schrieb Rohit Yadav <
<EMAIL_ADDRESS>
Needs investigation, I don't remember if it does or does not. However, if
the assertions are not encrypted - I suppose that's issue of the overall
IDP setup.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/cloudstack/issues/4519#issuecomment-791907116,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARBOIGJTIFMRSXJYLMUWPL3TCH54HANCNFSM4UNP732Q
.

Hi,
at least on 4.15.1 cloudstack is unable to find (or decrypt?) saml2.user.attribute if the assertions are encrypted (which is default in keycloak, and also enabled after importing cloudstack's metadata.xml).
I do not know, if this exactly relates to this topic.

@s-seitz yes, there is no issue if the SAML IDP enforces encryption.
The issue reporter is essentially asking that assertions/signature be checked even when encryption is not enforced.

I stumbled upon this - and from what I can see the validation of signature is dependent upon the IDP metadata containing a signing cert. If the IDP metadata XML doesn't specify a signing key, cloudstack simply doesn't check the signature.
The sig checks are wrapped in code like if (idpMetadata.getSigningCertificate() != null).  So again I'd go back to the IDP configuration. Not sure if the IDP metadata in question is in an XML file on the cloudstack management server, or if it is being fetched via URL in this case.

@mlsorensen are you saying this is a security issue (as opposed to how it was ruled earlier)?

@mlsorensen
From my point of view, the origin of the IDP data doesen't matter. As long as Cloudstack does not enforce a signature, any unsigned message would be accepted and processed.
A man in the middle could easy modify the original message, remove the signature and send it to Cloudstack. Of course, as soon as the assertions are encrypted, thats not a real issue anymore.
But from a security point of view, it's not uncritical when a security mechanism can be removed without any problems.
I'm still thinking about a simple true/false flag named "require signed assertions". In case of not set, assertions will be processed with or without signature. But as soon as enabled, every assertion must be signed or it will be dropped.

I tend to agree with @mlsorensen 's remarks, if the IDP configuration/metadata has the signing key then the signature check would be performed. I'm less worried about the MITM, as long as API activities are happening on https. Nonetheless, I've introduced a global setting that can fail a SAML based login check when enabled for more stricter env or http-based env, when the signature is missing from the SAMl response - https://github.com/apache/cloudstack/pull/9219
cc @ngrosc

@ngrosc - regarding this issue, please ping me<EMAIL_ADDRESS>need some info from you.

As the documentation does not state the exact verification of signatures: The linked and integrated PR expects the whole SAMLResponse to be signed, not only the assertion. As far i can see in the source code the assertion signature is not validated. That's a problem with Authentik as it only signs the assertions (which itself would be also valid, Link to authentik issue). E.g. Nextcloud offers a more fine grained control about the validation.
Hope this helps someone to save time debugging SAML in that case. A workaround is to disable signature validation here for now.


Level 2 data - get live data?

Hi. Just wondering if you guys have tried getting level 2 data from webull api? - suppose that my account is subscribed to webull level 2 data package. I would think that getting historical level 2 data is impossible, but any chance I could record it live and build my own dataset for that?

get_quote should return level 2 data is your account is subscribed


Add Contributing page

First setup of a Contributing page, as referenced by the README since: https://github.com/appsignal/appsignal-ruby/pull/197
I thought I would set up a small page for starters, but it grew into this slightly bigger page.
Feel free to add any changes directly instead of a review.

Updated. Please re-review

Merging this so we don't have dead urls from the Ruby gem README anymore


Modularize Javascript

The end goal is this issue to that Javascript components (e.g. lazy loading, modals, etc.) can be used independently. Usage should be easy for themers and application developers, similar to how Slick Carousel is deployed.
Javascript files should be executable with as little effort as possible. In some cases, loading the JS file will be enough. For example, in the case of DCF Lazy Loading, there is no configuration and we can simply load the JS file:

In the case of a future DCF slider, we may need an initialization script in addition to calling the dcf-slider.js file:

With a separate initialization script:

Alternatively, we may opt to store slider configuration in the DOM in lieu of an initialization script:

slide 1 markup here

slide 2 markup here

slide 3 markup here

This is something we should discuss. In either case, we'll provide the component JS file in DCF core, and it'll be up to the themer to implement conforming markup and possible an initialization script in their DCF-based theme. We'll provide documentation, of course.
Note: In DCF core, we'll only be storing ES6 versions of JS component. In dcf_starter, we'll include a Gulp task to transpile to legacy JS.

Use the following branch: issue-301-modularize-js
When ready to convert this task to a PR, run:
hub pull-request -i 301 -h d-c-n:issue-301-modularize-js -b d-c-n:2.0


Add documentation to the lockable-resources-plugin APIs and help files

This work adds documentation for the internal APIs and help files for the fields in the Jenkins interface.
Fixed some errors that were in the older pull request.

Added sign-offs in the commit messages. Feedback is appreciated.

Added issue https://issues.jenkins-ci.org/browse/JENKINS-30015 in Jira.

Unfortunately, this is very old and conflicts with the current code base... Closing for now

Go figure...


Getting the same error while creating windows virtual desktop... VM is created but deployment is failed with domain joining error.

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/forums/34192--general-feedback.

@ckgu541 Apologies for the inconvenience.
Since this channel is for driving improvements towards MS Docs, could you provide the URL of the specific documentation that your feedback is applicable to? That way, we are able to make sure your feedback is addressed by the right team.

@ckgu541 Any update on the issue.
Can you please share the document url that you are following?

@ckgu541  I will proceed to close this issue. You can either open a new issue by providing Feedback directly on the document or If you have the document URL then please share so that we can reopen this issue.


Functional components

Hi
Does this library work with functional components? Thanks

This is not a Function component library. However, you can do the following (Here I use the MUI library):
import Box from "@mui/material/Box"
import { Draggable as SmoothDraggable } from "react-smooth-dnd"
import { type ReactNode } from "react"
import { type SxProps } from "@mui/material"

interface TypeProps {
  children: ReactNode
  sx?: SxProps
}

const DndDraggable: React.FC<TypeProps> = ({ children, sx }) => {
  return <SmoothDraggable render={() => <Box sx={sx}>{children}</Box>} />
}

export default DndDraggable


Delete CONTRIBUTING.md and Pull Request Template

These are unnecessary, they're from the upstream

Comment to test hook

Test org wide hook


Quiet logs for normal operation

The standard behavior is to log the full details of every job. In the
case of some events, this is a rather large JSON payload, making the
logs very unwieldy. This commit changes the log level from NOTICE to
INFO and adds a toString signature to get a summary of the job without
the full payload. The full details are logged at the DEBUG level.

Thanks for this, @botimer.  I'm not sure whether it's best to merge this into master of this fork or to a branch, though.
So, your changes reduces the size of log messages for some levels and also changed the levels being logged.
Supposedly, when we run the resque worker, we can specify the log level to be used by setting environment variables (LOGGING, VERBOSE, or VVERBOSE).  I never noticed any difference (using the original worker code, without your changes) when I specified other levels.  While you were working in that part of the code, did you see anything that could make that work better?

Yeah, the flags are https://github.com/tl-its-umich-edu/php-resque/blob/master/lib/Resque/Worker.php#L67. Then the logger doesn't really deal with the log levels -- it just https://github.com/tl-its-umich-edu/php-resque/blob/master/lib/Resque/Log.php#L35 INFO and DEBUG.
An alternate PSR-3 logger could be plugged in, so I'm hesitant to do much fixing here. NOTICE definitely seemed too high for this activity, so that's the main focus of the change as-is and, as a side effect, INFO and DEBUG messages don't make it through.

HAH! I just redid this work because I didn't look first.

It's merged now, @botimer.  I didn't do it earlier because I decided to let it wait until I did some other work on Viadutoo, which will happen soon.  I thought that wouldn't be a problem because you must have your changes still on the server.
Since you've mentioned this PR, I might as well just go ahead and merge it now.


Fixed weird formatting bug in web page

Before this fix, all the buttons on the right side of the profile where not inline-block with the centerpiece profile and the other buttons on the left side of the profile. After this fix, all the buttons are in the right place.
Here is the website before the fix:

Here is the website after the fix:

screenshots included!


chore: Updated dispatch command

Description
It is for running a spec file with given run_count
Fixes #34956
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10260756232
Commit: 0d4867a9068a353614cfc71374efeb8bc737fcfd
Cypress dashboard.
Tags: @tag.Sanity
Spec:
Tue, 06 Aug 2024 05:40:57 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

Chores

Updated the event type for the GitHub Actions workflow to enhance clarity and specificity in triggering associated jobs. Users will now need to use the new event type ci-test-limit-count-command for interactions.

/ci-test-limit-count run_count=3


Koffing and Weezing are missing their Galarian forms?

Right now all Galarian forms are missing from our database :(
Do you know if other pokemon in Galar have different/multiple forms?

A quick google search said yes - https://bulbapedia.bulbagarden.net/wiki/Regional_form
There are also some pokemon that ONLY evolve in their galarian forms, such as Perrserker and Obstagoon. I'm not sure how to contribute these, as I only had a quick look at the CSVs.

Oh, I thought Koffing had a galarian form, I was wrong.

Well, I'm going to close this issue.
If you'd like to contribute, you could add the variants to our CSV files. Basically what we've done for the alola forms is:
Create another pokemon (for example Grimer Alola https://pokeapi.co/api/v2/pokemon/10112/) and then link it to the Grimer Species https://pokeapi.co/api/v2/pokemon-species/88/ .varieties as a variety.


updated per #474

Updated readme based on @andrewnicolas suggestions in #474 and sent the PR to dev

Coverage remained the same at 74.251% when pulling 9b5743d685f36907d6135c6c9e5e47bc1bc31a8d on Hadis-Fard:readme into a5b70f568fc12e961b0da740775db3df60b04785 on Microsoft:dev.


fix prerender and webpackconfig for custom directories in npm modules

Fixes #42
This fixes inclusion of custom directories from node modules.
Also this means preact-material-components can now be used separately, without the entire package

@lukeed @developit it is a WIP, as I have a working stuff, but it no more uses babel create config

@developit @lukeed added a dummy travis yml to make travis happy

How does this work now that the include function has been removed? Are all node_modules processed by default?

Yes

Unless I'm missing something obvious, doesn't seem like the module and/or jsnext:main entries will be picked up.

webpack picks node_modules in the order module -> js:next(i guess) -> main -> ...
so it will still be picked up

Also, can remove the @webpack-blocks/babel from package.json. 👍
sure will do

Oh, and I'm pretty sure ignore:false operates the same as its default (ignore:null). So that can probably be removed.
by default it is ignore: true so ignore: flase is needed

@lukeed i have made changes to the package.json

Hmmm interesting. I'm seeing ignore:null here.
Also, the regex can be /\.jsx?$/.
Looks good~!

@lukeed aren't you talking about ignores: null in prerender? Which is actually this
https://github.com/babel/babel/tree/master/packages/babel-register#ignores-node_modules-by-default

Oohhh... that's probably why I got stuck in my attempt! Thanks!

Also @lukeed, i guess regex should be both. As node modules can be js as well. What say?

The ? applies to the character before in this case, so .js and .jsx files will both work. It's also the "standard" regex test that I see.
/\.jsx?$/.test('foo.js')l
//=> true

/\.jsx?$/.test('foo.jsx')
//=> true

@lukeed fixed the regex :)

@developit need approval if all looks good.

awaiting response/approvals here, lemme know if more work is needed here

Hmm - I know I missed approving this, but can we double-check the removal of jsnext include()?  In my experience this breaks ES5 modules since it rewrites them into strict mode - some modules assume the global context to be window, and when loaded via Babel it's undefined.

@developit can you point me to some such modules?

Might be hard, only saw the issue in an internal project and it was ages ago.
For my own sake, how come the check for jsnext:main / modules was failing for preact-material-components?

because for that repo, I suggest to include separate files instead of the whole repo as tree shaking is not yet perfect

It was because the preact-material-components's module entry points (and can only point) to a single index.js that looked (roughly) like this:
import Foo from './foo';
import Bar from './bar';
export { Foo, Bar }

This introduces the imperfect tree-shaking (nothing we can do, everything gets imported due to the declaration), so @prateekbh recommended nested-file imports.
However, the include() fn we had only respects the index.js file because preact-material-components is the module name, and not preact-material-components/foo.

On second thought, I think the include function could have stayed, but it wouldn't make a difference. The main reason this PR fixes #42 is because of ignore:false, which was ignoring all of node_modules by default.
It wouldn't have made a difference because ignore:false passes everything thru babel-loader (pros vs cons), which precludes the jsnext:main|module entries.

@lukeed only ignore:false was still throwing error, i tried doing both separately, seems both are needed

Ah, okay. I guess include takes a higher priority. Thanks

It just seems odd the include() wouldn't have seen the module key within node_modules/preact-material-components/package.json and triggered Babel.  Maybe I'm crazy :P

@developit  If i include components like
import Toolbar from 'preact-material-components/Toolbar
instead of
import {Toolbar} from 'preact-material-components
do you think it would have worked?

I would have expected it to, yes, but in my trials (using a different set of changes), it did not work for the reasons I mentioned above: only preact-material-components/index.js was transformed correctly.


Feature/jh gardenrework

some work on garden page:
members, crops, icons

closed without merging becaus something is missing


Lh/new datepicker

closes #697
using a different react datepicker + using date-fns instead of moment

@laholstege Creating and assigning a workstation, top is cutoff:


fix(SvgCanvas): allow canvas size modification

closes #927

@Brooooooklyn i'm so sorry there's some issue in this 😓
this is not creating svg context I'll make another pr.


can not update output-port name of a command line tool

In 1.0.0-rc.2 when trying to change the output port name of a command line tool it gets overwritten back to "output" after closing and opening the tool

This is fixed on master, probably for some time now. Will be published with 1.0.

Thanks. Is the master stable to use, or should I wait until the 1.0 release?


Version dependencies of required libraries for ChainerCV installation

What are the version dependencies of required libraries (Chainer, Pillow, Cython, Matplotlib, OpenCV), with Python 2.7.12 and 3.6.0, for installing all 3 versions of ChainerCV on Anaconda on Windows?

Dependency for Chainer is explained in README.
https://github.com/chainer/chainercv#requirements
For the rest of the packages, the versions that get installed in environment.yml should work.
https://github.com/chainer/chainercv/blob/master/environment.yml
I am sure that most of the recent versions should work as well.


x/vgo: go get vgo error

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10 windows/386
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
set GOARCH=386
set GOBIN=
set GOCACHE=C:\Users\junwuhui\AppData\Local\go-build
set GOEXE=.exe
set GOHOSTARCH=386
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\junwuhui\go
set GORACE=
set GOROOT=C:\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_386
set GCCGO=gccgo
set GO386=sse2
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m32 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\junwuhui\AppData\Local\Temp\go-build252696518=/tmp/go-build -gno-record-gcc-switches

What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
go get -u golang.org/x/vgo

What did you expect to see?
install vgo successful
What did you see instead?
syscall
C:\Go\src\syscall\ztypes_windows.go:9:36: ERROR_FILE_NOT_FOUND redeclared in this block
previous declaration at C:\Go\src\syscall\types_windows.go:9:36
C:\Go\src\syscall\ztypes_windows.go:10:36: ERROR_PATH_NOT_FOUND redeclared in this block
previous declaration at C:\Go\src\syscall\types_windows.go:10:36
C:\Go\src\syscall\ztypes_windows.go:11:36: ERROR_ACCESS_DENIED redeclared in this block
previous declaration at C:\Go\src\syscall\types_windows.go:11:36
C:\Go\src\syscall\ztypes_windows.go:12:36: ERROR_NO_MORE_FILES redeclared in this block
previous declaration at C:\Go\src\syscall\types_windows.go:12:36
C:\Go\src\syscall\ztypes_windows.go:13:36: ERROR_HANDLE_EOF redeclared in this block
previous declaration at C:\Go\src\syscall\types_windows.go:13:36
C:\Go\src\syscall\ztypes_windows.go:14:36: ERROR_NETNAME_DELETED redeclared in this block
previous declaration at C:\Go\src\syscall\types_windows.go:14:36
C:\Go\src\syscall\ztypes_windows.go:15:36: ERROR_FILE_EXISTS redeclared in this block
previous declaration at C:\Go\src\syscall\types_windows.go:15:36
C:\Go\src\syscall\ztypes_windows.go:16:36: ERROR_BROKEN_PIPE redeclared in this block
previous declaration at C:\Go\src\syscall\types_windows.go:16:36
C:\Go\src\syscall\ztypes_windows.go:17:36: ERROR_BUFFER_OVERFLOW redeclared in this block
previous declaration at C:\Go\src\syscall\types_windows.go:17:36
C:\Go\src\syscall\ztypes_windows.go:18:36: ERROR_INSUFFICIENT_BUFFER redeclared in this block
previous declaration at C:\Go\src\syscall\types_windows.go:18:36
C:\Go\src\syscall\ztypes_windows.go:18:36: too many errors

This seems like an issue with your Go install. Make sure that you are running a working version of Go 1.10.

sorry, I installed the wrong version.


[WFCORE-6105] Upgrade Bouncycastle OpenPGP from 1.72 to 1.72.1

Jira issue: https://issues.redhat.com/browse/WFCORE-6105
built on top of #5261

Thanks @yersan


Add PowerShell examples

Add the PowerShell examples when it's appropriate.

@alexandair : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

This PR has been transferred to the private repo.


Pagination dropdown getting close when setState({ data })

I'm using react-bootstrap-table with remote data and fetching the data every few seconds to update the table.
<BootstrapTable
    remote={ true }
    data={ this.state.data }
    ....

And when fetching the data I use setState({ data }).
If I open the pagination menu - once the component is refreshed with the data from the server - the dropdown is getting closed automatically.
I'm using version 3.0.0
Is there something I can do to keep the pagination dropdown open?

sorry for lately reply cause of my busy job...

If I open the pagination menu - once the component is refreshed with the data from the server - the dropdown is getting closed automatically.

yap, it's not a bug, because a re-render happen via setState

Is there something I can do to keep the pagination dropdown open?

there's no any good way to achieve easily, but you can custom the dropdown and keep it always open, check this and add a props hidden={ false } on SizePerPageDropDown
Ley me know if you have any questions, thanks

Thanks for the fast reply @AllenFang!
Actually - if there was a callback on the open/close dropdown of the PaginationList it would be much easier.
What do you think? I can add a PR for this one, will you merge it?
Thanks!

Actually - if there was a callback on the open/close dropdown of the PaginationList it would be much easier.

I can try to add this, so is that helpful for you? I think a return bool value can perform the dropdown open/close maybe is what you want.

My thinking was that I can stop the refreshing from the server while the dropdown is open, and when the dropdown is closed I will renew the requests.
This way - the component will not re-render while the dropdown is open (because there will be no new requests).

sorry, I got misunderstand, for your mentioned before, I will try to support a callback on dropdown for open/close, thanks

Do you prefer that I provide a PR for that?

@dekelb, I think I can handle it, take your time :)

@dekelb, I've try to implement but I found some situation here.
Firstly, bootstrap dropdown can be close via clicking the outside of dropdown itself, so if you want to know the dropdown close by this way, you need to use bootstrap.js, but react-bootstrap-table doesn't depend on it, you can check DropDown Event document,
so my recommend is you can know it open/close via native bootstrap event, like the above reference but you need to know the DOM id or class, so I'll add a general class name on dropdown for you can get the DOM via jQuery or javascript.

Try v3.1.8, you can get the dropdown DOM via .react-bs-table-sizePerPage-dropdown and register it with DropDown Events


Problem with Emoji Bypass

Emoji bypass wasn't check if the emoji is on the server or not.

fixed soonTM, prob will be added in the next full release (1.5.0)


Support error logging before jest retry

Summary
Currently, to my knowledge Jest does not support logging errors before a retry event happens. This makes it difficult to debug why a test failed, especially if the code the test is testing is not deterministic (it will fail once, but will pass during the first retry), and thus no error will be visible as why it failed during the first time.
The need for visibility is a big driver here as I'd like to know if the reason that the retry occurred was due to a Jest.setTimeout error or an error that occurred in the test itself.
Test plan

Codecov Report

Merging #12201 (1102fe8) into main (5706d71) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main   #12201      +/-   ##
==========================================
- Coverage   67.72%   67.69%   -0.03%
==========================================
  Files         328      328
  Lines       16993    17001       +8
  Branches     4818     4820       +2
==========================================
+ Hits        11508    11509       +1
- Misses       5452     5459       +7
  Partials       33       33

Impacted Files
Coverage Δ

packages/jest-circus/src/run.ts
5.81% <0.00%> (-0.22%)
:arrow_down:

packages/jest-types/__typechecks__/jest.test.ts
0.00% <0.00%> (ø)

packages/jest-runtime/src/index.ts
56.66% <50.00%> (-0.09%)
:arrow_down:

packages/jest-circus/src/types.ts
100.00% <100.00%> (ø)

packages/expect/src/utils.ts
96.03% <0.00%> (-0.50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5706d71...1102fe8. Read the comment docs.

@zackasaurus ping 🙂

not a fan of using console here. Can we update the result object and reporter to include the information instead?
@zackasaurus ping 🙂

Hey @SimenB !
Just making sure I'm on the right track here, but basically add something like this in packages/jest-core/src/ReporterDispatcher.ts  =>
async onTestRetry(
    results: AggregatedResult,
    options: ReporterOnTestRetryOptions,
  ): Promise<void> {
    for (const reporter of this._reporters) {
      reporter.onTestRetry && (await reporter.onTestRetry(results, options));
    }
  }

and have packages/jest-circus/src/run.ts dispatch that method?
 while (numRetriesAvailable > 0 && test.errors.length > 0) {
      if (logErrorsBeforeRetry) {
        // dispatch test retry reporter method ?
      }
      // Clear errors so retries occur
      await dispatch({name: 'test_retry', test});

      await _runTest(test, isSkipped);
      numRetriesAvailable--;
    }

I think we should just add something to the test result that allows the reporter to print some context, which the reporter can then print after the tests is done. I don't think the reporter needs to be told when it happens? So essentially, look at where circus currently handles the test_retry event (it just clears errors) and have it push those errors into some retryReasons array or some such. Then when the test is done, you can ensure it's on the test result. Then in the reporter when it's printing the results it can inspect this new array and then print something.
Makes sense?

@SimenB I've yet to update the tests for this feature, but do the newest changes reflect your vision? I could only get the errors to show up correctly when using jest-serializer, so I'm passing an array of buffers to the reporter through the test result, and had to modify the deepCyclicCopy so the buffer data type would not change. I also included a visual of what the reporter displays when running a test. Let me know what you think! Thanks for all your help. :)

@zackasaurus I need to re-process this PR, might be a few days. Gut feeling is that this solution is more complex than it needs to be, but I need to dig into it.
I'll add it to the milestone so I don't forget 🙂

@zackasaurus I tweaked the logging a bit, thoughts?


Remove out hard coded image url

Since gcr.io is not reachable from China mainland, I noticed all acs-engine guides in China are suggesting users to replace gcr.io in both code and configuration files to something else, and, what's worse, re-compile acs-engine to make this work.
This is very bad experience.
If we can not solve the URL problem, we can try to remove all image URLs in code at least, for example: https://github.com/Azure/acs-engine/blob/ef10fce6cb0b2bdd9a0745b6860ef494f9b50827/pkg/acsengine/const.go#L22

That's just the default value. If you look at the output, you'll see that kubernetesHyperkubeSpec can easily be changed before you perform the deployment.
I actually use this regularly to test private builds of hyperkube that are pushed to a docker.io registry rather than a gcr.io registry, for example.

Good to know it's configurable. @colemickens can you make sure there're no gcr.io hard coded in the code? Then I can close this issue.

Actually, no, that's not the only place it needs to be configured. It also needs to be replaced in any of the manifests where we are pulling containers for addons.
We don't have a great way of making this adjustable right now. For right now, it'd be very easy for you to maintain a fork that has the relevant mirrors you need. We can look at how we might support making this adjustable in the addon files as well.

Thanks! Closed.


README.md is misleading on spec copyright

The license section says

License: mixed — approximately:
proprietary Khronos license for the specification
Creative Commons Attribution 4.0 for document sources
Apache 2 for code

which could mislead people. I suggest replacing this with:

Proprietary Khronos license for the Vulkan Specification published by Khronos on its website
CC-BY 4.0 for asciidoctor sources for the Specification and related documents such as the reference pages, style guide, and XML schema documentation.
Apache 2 for code, including the XML registry defining API interfaces

Thanks Jon for your clarification. I will push this change for the Vulkan Specification in the Map of Vulkan Ecosystem projects.


rename test utils get_rawdata_path to get_top_level_folder_path

also rename make_and_check_local_project to make_and_check_local_project_folders

rename cfg.top_level_folder_name to cfg.top_level_folder


request - css class on wizard buttons (cancel, next etc.)

will make it easier to style / hide them if not needed

even better if each button has a different class or id.
(also nice if we have the option to show the navigation links on the bottom)

I am adding the following classes.
btn-wizard-nav-cancel
btn-wizard-nav-previous
btn-wizard-nav-next
btn-wizard-nav-submit

RC19 fixes this.


Bug in compilation at the step cmake --build . --config RelWithDebInfo

Hi,
I follow the instruction from the README file to compile this project, but there is an error reported at the last step:
cmake --build . --config RelWithDebInfo
CMake Error: The source directory "/home/trungtq/workspace/blockchain/evmjit/build/RelWithDebInfo" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.

Does anyone encounter the same problem?

Maybe the reason is that I use the latest version of CMake (3.10.x).
When I exchange the position of the two parameters --build and --config, then the following command can work normally:
cmake --config RelWithDebInfo --build .


Support use of TypeVar on generic subclasses

This change was originally introduced to support generic functions on generic types defined for pydantic.
Notably, passing a TypeVar on a GenericModel subclass raises a TypeError (presumably?) meant for assisting users in defining their generic model classes.
Example:
import typing
from pydantic.generics import GenericModel

T = typing.TypeVar('T')
R = typing.TypeVar('R')

class Model(GenericModel, typing.Generic[T]):
  items: typing.List[T]

# Next line raises:
# TypeError: Type parameters should be placed on typing.Generic, not GenericModel
def convert(model: Model[T], mapper: typing.Callable[[T], R]) -> Model[R]:
  return Model[R](items=list([mapper(item) for item in model.items]))

Change Summary

Allow use of TypeVar on GenericModel subclasses.

Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.rst file added describing change
(see changes/README.md for details)

@zpencerq Yes, I noticed recently that this also prevents you from using bounds to restrict the TypeVars in subclasses. Thanks for contributing this.
You should be able to fix the formatting issues currently causing tests to fail by running make format from the pydantic root folder.
You can also run a plain make to check that the CI tests will pass.

Should I open this against v0.32.x as well?

@zpencerq I think just against master is fine — I think @samuelcolvin is hoping to release a beta this week.

thanks so much.


update readme text, examples, and badges

Following issue 23, I reworked the examples file and added minor updates to the readme file.


Monitoring Metrics on Workload

Need to add monitoring graphs on workload details for certain types of workloads.

Pods
Deployments
Statefulsets
Daemonsets

https://xd.adobe.com/view/866862d9-4ac5-4962-a026-0c716a335cb7-d33b/

This is for v2 monitoring to bring feature parity to what was in v1. This would allow people to not rely on other cloud monitoring services.

We should leverage Grafana instead of our own widgets. We should ensure we're clear what the gaps are so we need to review the Ember v1 monitoring and understand what dashboards to be created.
@codyrancher should get one of the newer UI folks up to speed and work with Arvind to get the dashboards created.

We're waiting on https://github.com/rancher/rancher/issues/35340 before we move forward.

For testing you will have to test this on a local cluster unless you have your cluster setup behind a domain with a valid certificate due to https://github.com/rancher/rancher/issues/31891

Setup For Feature Validation

Rancher Version: v2.6-head (e322f8f)
Install type: Docker

Validation Steps

Install Monitoring onto your local cluster.
Navigate to the local cluster from the cluster explorer
Go to Workload
Go to pods and select one. (I selected the calico kube controllers pod)
Select Metrics

From here you shall see a graph similar to the following:

Further Testing
I did the validation steps for the following workloads

Pods - Pass
Daemonsets - Pass
Statefulsets - Pass
Deployments - Pass
I also checked the other workloads to make sure graphs weren't present.

The validation passed in both RKE1 and RKE2 clusters.


libcxx: fix build on linux musl

Motivation for this change
Before this, libunwind, libcxxabi and libcxx failed to build on x86_64-linux-musl.
On current master with

for attr in libunwind libcxx libcxxabi; do for platform in linux; do for pkgs in pkgs pkgsStatic; do echo -n "$attr $platform $pkgs "; nix-build -A $pkgs.$attr --argstr system x86_64-$platform  &> /dev/null  && echo success || echo failure ; done; done; done | column -t

libunwind  linux  pkgs        success
libunwind  linux  pkgsStatic  failure
libcxx     linux  pkgs        success
libcxx     linux  pkgsStatic  failure
libcxxabi  linux  pkgs        success
libcxxabi  linux  pkgsStatic  failure

on this branch:
libunwind  linux  pkgs        success
libunwind  linux  pkgsStatic  success
libcxx     linux  pkgs        success
libcxx     linux  pkgsStatic  success
libcxxabi  linux  pkgs        success
libcxxabi  linux  pkgsStatic  success

I have not, I repeat not, built the pkgsStatic versions on darwin, although the pkgs versions do still work.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @basvandijk

@GrahamcOfBorg build libunwind libcxx libcxxabi

@GrahamcOfBorg build pkgsStatic.libunwind pkgsStatic.libcxx pkgsStatic.libcxxabi

This should go to staging as it's darwin stdenv rebuild. Good work :)

Yeah unfortunately due to https://github.com/NixOS/nixpkgs/pull/70244/files#diff-94997ad820e0a722e115eb7b6b93a404R17 I couldn't avoid the rebuild on non-static

We can probably drop the first comment once https://github.com/NixOS/nixpkgs/pull/70321 lands

Dropped the first commit since libunwind isn't needed anymore (#70321 ). Good to merge?

(do we have a musl team (@nixos/musl? no?)? Regardless, and no worries for new folks, but please cc me on musl issues :).  I don't always have time, maybe less time than I'd like, but I would definitely fix something like this should it break again in the future! Sorry folks!)


Problem with .to_dict() type inference

Describe the bug
I have a dataframe or pandas series and when I use the .to_dict() the inferred type by pandas-stubs is Dict[Hashable, Any]. In my case I know that that the index is an int but there is an error when I type the output as Dict[int, Any] saying that int is not a Hashable type.
Is there any solution for better inferring the type in this case?
To Reproduce
Please complete the following information:

Provide a minimal runnable pandas example that is not properly checked by the stubs.

import pandas as pd

id=[1,2,3]
value=["a", "b", "c"]

df = pd.DataFrame(zip(id, value), columns=["id", "value"])
df.set_index("id")["value"].to_dict()

def funct(df_dict: Dict[int, Any]) -> None:
     pass

Indicate which type checker you are using (mypy or  pyright).3.
Mypy

Show the error message received from that type checker while checking your example.4.

error: Argument 4 to "funct" has incompatible type "Dict[Hashable, Any]"; expected "Dict[int, Any]"
Additional context
I am running it in python version 3.10

DataFrame/Series are not Generic with respect to the index type, so we cannot return dict[int, Any. I think we would need to relax the annotation to just dict to avoid any mypy/pyright errors when users implicitly "cast" it to dict[int, Any]. I'd be okay with that change (for input arguments, I would still require something like dict[HashableT, Any] but for return values, it might be worth relaxing it).
@Dr-Irv @bashtage

I see two ways of looking at this:

By us saying that we are returning Mapping[Hashable, Any], and then the user has created a function expecting dict[int, Any], we've alerted the user that they can't just assume all the keys of the dict will be int, so they should do a cast if they are sure that will be the case.
Any Mapping must have a Hashable as its key, so if we just return Mapping for to_dict(), we don't lose anything, and people aren't forced to cast.

I'm leaning towards (1), because we are making it clear that you can't assume the type of the keys of that dict.  I could be persuaded towards (2).

Given a Mapping[Hashable, Any] doesn't add anything, I like 2. If there was actually any type specificity I would be firmly in camp 1.

Given a Mapping[Hashable, Any] doesn't add anything, I like 2.

One could argue that it is a signal that the dict we return has an unknown key type, so if you are assuming the keys are int (as in this example), that is a wrong assumption.  So in that sense, we have "added" something.

Mapping makes only the values covariant. I would prioritize getting the container type right (dict vs (Mutable)Mapping) as opposed to differentiating Any vs Hashable.

Mapping makes only the values covariant. I would prioritize getting the container type right (dict vs (Mutable)Mapping) as opposed to differentiating Any vs Hashable.

So should we change the return type to be dict[Hashable, Any] ?

One could argue that it is a signal that the dict we return has an unknown key type

Unknown to the type checker, because we do not have generic indexes. I'd imagine most users are aware of what type it is, so forcing users to cast for what is arguably a limitation of the annotations can be a bit cumbersome.

Unknown to the type checker, because we do not have generic indexes. I'd imagine most users are aware of what type it is, so forcing users to cast for what is arguably a limitation of the annotations can be a bit cumbersome.

Fair enough.  Hopefully someone can do a PR changing the return type to just dict .


IsValid reporting true on an address

You can see the behavior in the fiddle
https://jsfiddle.net/jeffbeagley/2c9urj5v/1/
var wrong_date = "7840 W HICKS STREET";

document.write(moment(wrong_date, "YYYY-MM-DD HH:mm:ss").isValid());

Added strict parsing and that fixed the issue.


Import animation clips not working (3D)

Godot version:
3.2
OS/device including version:
Linux 5.5 - Nvidia GTX1050
Issue description:
I have a 3d model with multiple animations within a single timeline. I'm trying to use the clips property under the import panel to separate those multiple animations. However I don't get anymore animations than the single long timeline.
This is my configuration:

Steps to reproduce:

Create a new project
Import the attached gltf file
Under the import menu create two tracks:

Idle from 0 to 110
Run from 130 to 200

Set animation FPS to 24
Hit reimport

Minimal reproduction project:
Character_Animation.zip

Duplicate of #25599.


documentation of the start_height field to the refresh RPC method is incomplete

Reference:
https://github.com/monero-project/monero-site/blob/7535c4c62623166af4ce12033e30af2d7d19c40b/resources/developer-guides/wallet-rpc.md#L2514
Right now the description of start_height to the refresh wallet RPC method says:

The block height from which to start refreshing.

It should say something like:

The block height from which to start refreshing. Passing no value or a value less than the last block scanned by the wallet refreshes from the last block scanned.

This change will prevent anyone from incorrectly thinking that refresh can  be used to force rescan the block chain.

Thank you. Confused me also.. its clear that its meant to be used in combination with auto_refresh disabled OR - skip / fast forward the sync process (i believe featherwallet utilises this for insta-syncing if the user is certain theyv'e received no funds since the last time they opened their wallet). I've updated my PR with your addition and credited you.


ed dependency error

I'm following the instruction for compiling a NuttX configuration in a clean Docker with a Dashing distribution, and I find the following error:
/root/uros_ws/install/micro_ros_setup/config/nuttx/olimex-stm32-e407/create.sh: line 28: ed: command not found

Please remove all apt install ed and add the package.xml line when needed when https://github.com/ros/rosdistro/pull/23966 is merged

Closing because https://github.com/ros/rosdistro/pull/23966 is merged


SRGAN beginner

I really embarassed on seeing your work, can you share your GPU details and how long it's take the time to train.It will be huge helpful for my project.

#75


Not working on touch devices

From<EMAIL_ADDRESS>on August 17, 2010 11:20:42
What steps will reproduce the problem? 1. Using a touch device like iPhone.
2. Open a diagram and try to move a table via drag and drop What is the expected output? What do you see instead? Tables can be moved. What version of the product are you using? On what operating system? There is no drag and drop functionality on touch devices. Please provide any additional information below. This bug/feature request is just informational, I think it is not a very demanded feature. I just recognized it.
Original issue: http://code.google.com/p/wwwsqldesigner/issues/detail?id=103

From ondrej.zara on August 22, 2010 12:23:21
This can be useful.
Status: Accepted

From ondrej.zara on August 28, 2010 03:25:10
Owner: ondrej.zara

From<EMAIL_ADDRESS>on September 08, 2010 04:09:15
FYI, I just saw that YUI supports touch... http://www.yuiblog.com/blog/2010/09/07/yui-3-2-0/

From ondrej.zara on October 06, 2010 05:03:14
Commited in r110 .
Status: Fixed

From<EMAIL_ADDRESS>on October 06, 2010 09:27:16
Crazy :) good work!


error when submitting an expense

I was able to reproduce it
I tried, logged in, logged out, from the front page and directly to /expenses/new

It worked when I tried with an image I had but failed with her file. Converted the file to PDF and then I took a screenshot, still not working. Fails on mobile and desktop.

nginx issue. fixed.


Switch to release-monitoring.org API v2

It turns out my assumption about rate limiting on v2 API was incorrect, @Zlopez confirmed there is no rate limiting in place and I haven't been able to reproduce the test failures since, so it was most likely some sort of a temporary network hiccup.

regate


node IteratorGetNext

corrupted record at 0
[[node IteratorGetNext (defined at /usr/local/lib/python3.5/dist-packages/tensorflow_estimator/python/estimator/util.py:110) ]]
any one help me

same here

i solve this error before one year

this error occur when you .tfrecord not create correctly

got it thanks but I not sure what the input is, I use a bunch of txt file, each file has some text content in it.

not txt create .tfrecord you need to use  .json file

oh gotcha thank you so much, does the Json file have any specific structure?

yes json have specific structure you check on sample i think one sample presents in code

gotcha thank you so much!
btw, when creating the tfrecords files, do we need to create some accounts on AWS and tried the prepare_lm_data.py in the realnews folder? Thanks again

yes


Enhancement-Power relay

He first thanks for all you hard work on this great mod. I have one idea that I think would be really useful and not to hard to implement. Add to the power relay block an rf counter. Like the power meter on your house. You could see how much power has passed through it. Very useful to see how much you have really used on a dimension or anything else. We thought it would also be useful when playing with a large group and every one is sharing power. You could limit how much power is being used and/or have just have a count of what they are using. You could then bust heads for those heavy consumers.
Also have a reset button to set the counter back to zero.
Also can send a redstone signal when counter hits a set point.

Yes, that's a good idea. I'll probably implement this in the (near) future

Sweet thanks! Let me know and I can help with testing if needed.

The powercells can do this in 1.10.2

Sweet thanks for all your hard work.


Correct singular for 'criteria' is 'criterion' (not criterium).

As per https://github.com/stefanpenner/ember-inflector#ember-inflector-, this libraries default inflection rules are to be feature parity with rails ActiveSupport. It is possible to create a new set of rules, or augment the existing ones.
Rails froze there inflection rules some time ago, but allow user "mods".


Image field in edit mode still asking for image as a 'required' field

Version information

Laravel: v5.6.28
Voyager: v1.1.3
PHP: 7.1.11
Database: 10.1.28-MariaDB

Description
Image field in edit mode still asking for image as a 'required' field.
Steps To Reproduce
1.Making image fields as 'required' using below JSON in the BREAD section
{ "validation": { "rule": "required" } }
works well in add mode.

But in edit mode, it is still asking for an image.

Expected behavior
The image already exists and should therefore not get the 'The Image field is required.' prompt on edit

anyone?

I believe this is a known issue that hasn't been fixed yet.  I haven't had a chance to look, but I'm certain there's at least one open issue for this already.

there is an easy fix , use required_if instead of required
{     "validation": {         "rule": "required_if:id,null",         "messages": {             "required": "your message"         }     } }
this will make it required in the create page only, or you can customize it as you wish.
required_if ref.

thankyou @alaamebrahim
that is the actual solution.
i'll close this as resolved

@alaamebrahim It's not really a solution. Because you can delete image and save without it.


[Question] How was the WS socket issue on IE fixed?

Hey! So i would just like to get some insight on this, just so i can understand how it was fixed.
Thanks!

It was fixed by downgrading the version of the ws module in package.json. The current version of said module causes a crash when a player disconnects.

Downgrading do 1.1.0?

@CalvinDKL Yes


State-benefits list MATCHING_RESOURCE_NOT FOUND

The following API call in Sandbox environment to list user benefits fails.
2021-11-04T15:52:18.949 INFO  resource=> /individuals/state-benefits/KK031210D/2019-20
2021-11-04T15:52:19.000 INFO status=404
My application  SE_reports is subscribed to the Individuals State Benefits (MTD).
The HMRC documentation for this call is ambiguous in regards to the "benefitId" parameter.
I quote:

"A National Insurance number, a tax year that ended, and benefit ID must be provided."
"Query Parameters
benefitId
string
optional"

Please help me to understand where do I go wrong.

Hi @alexei-serjantov, just to confirm you are trying to call the List State Benefits endpoint?
You are correct, benefitId is an optional query parameter. I will raise a ticket to get the wording changed on this, thank you for pointing it out.
I'm not sure why you would be getting a 404 response when calling the endpoint with a query parameter though - the downstream stub should return a single HMRC held state benefit when a benefitId query parameter is present, provided it is a valid benefitId. You should also get a success response without providing a benefitId.
Please could you confirm the full URL you are calling? Looking through our logs I cannot see a request to the Individuals State Benefits API in Sandbox in the past 24 hours with that NINO. It should look like this: https://test-api.service.hmrc.gov.uk/individuals/state-benefits/KK031210D/2019-20.
Also, per the Support section on this API's documentation page please could future issues regarding Individuals State Benefits API be raised on the income-tax-mtd-changelog GitHub page? That just helps us keep all Issues in one place rather than split over multiple individual APIs.
Kind regards

Thank you for your prompt reply.
The URL was wrong indeed.  Issue closed.


[TypeScript] Fix 'done' type in Async/IteratorState

Hi. At the moment IteratorResult has the following signature:
interface IteratorYieldResult<TYield> {
    done?: false;
    value: TYield;
}

interface IteratorReturnResult<TReturn> {
    done: true;
    value: TReturn;
}

type IteratorResult<T, TReturn = any> = IteratorYieldResult<T> | IteratorReturnResult<TReturn>;

https://github.com/microsoft/TypeScript/commit/e8bf9584aa74aabfecb51a02edb13e3657508274
As you can see, done is of type boolean | undefined, while in IteratorState and AsyncIteratorState it's of boolean type, what is causing the compilation error. I have changed the type of done to match the actual type.

@jesseschalken
Please merge this PR


Epipe error after seeding the 2 torrent to webtorrent

WebTorrent-hybrid version: 1.6.0 (0.97.2)
Node.js version: v4.6.0
npm o2.15.9
express js 4.14.0

I'm trying to add the magnet link to the client.add() to download and seed the torrent
my code
router.post('/magnet_uri', function(req, res, next) {
    // magnet link
    var torrentId = req.body.magnet_url;
    client.on('error', function (err) {
        console.log("Client Error : ", err);  // Invalid torrent identifier
    });
    //  adding the magnet link to the client
    client.add(torrentId,{ path: './seed_torrent/' }, function (torrent) {
       console.log('torrent start seeding');
        // About torrent info
        var info_torrent = {
           // MagnetURI: torrent.magnetURI,
            TorrentHashInfo: torrent.infoHash,
            TorrentName: torrent.name,
            TorrentPeer: torrent.numPeers,
            TorrentPath: torrent.path
        }
        console.log(info_torrent);
        torrent.on('ready', function() {
            console.log("Torrent is ready to download"+'ready');
        });
        // display the warning details if warning occurs
        torrent.on('warning', function (err) {
            console.log("Torrent Warning : ", err);
        })
  	// on torrent error for display the error message
  	torrent.on('error', function (err) {
            console.log("Torrent Error : ", err);
  			// console.log("error occured, Torrent can't downloaded");
  	})
        // if peer is not found
        // announceType is either 'tracker' or 'dht'
        torrent.on('noPeers', function (announceType) {
            console.log("Torrent NoPeers : ", announceType);
        })
              // if torrent is finished download
  		torrent.on('done', function () {
     		console.log('torrent download finished');
    	})
   })

i run the app in command line
i used command

DEBUG=alpha-webtorrent:* npm start

Where alpha-webtorrent is a expressjs app  folder
I'm sending the magnet link to the nodejs server, so that it add the torrent link and start downloading the file.
while i sent the multiple file to the magnet link simultaneously or one after the another
first torrent file downloaded successfully and start seeding
while the second torrent  downloaded successfully after that
i always face an issue :"

events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at exports._errnoException (util.js:907:11)
    at WriteWrap.afterWrite (net.js:785:14)

npm ERR! Linux 3.16.0-4-amd64
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start"
npm ERR! node v4.6.0
npm ERR! npm  v2.15.9
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `node ./bin/www`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node ./bin/www'.
npm ERR! This is most likely a problem with the alpha-webtorrent package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ./bin/www
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs alpha-webtorrent
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls alpha-webtorrent
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/alpha-webtorrent/npm-debug.log

I coudn't find the solution for this.
Please help @feross

Is this difficult to answer.................... @feross

Your webtorrent-hybrid version can't be 1.6.0. The latest version is 1.0.5. I would check to ensure that you're actually using the latest version.

webtorrent-hybrid version can't be 1.6.0.  I agree, I solved my issue.


Piranha.Manager: PageController.Save() can't return View()

Problem
The PageController.Save() method is setup to return the standard View() if PageEditModel.Save() returns false. However, in the event an exception is thrown by api.Pages.Save() (say a DbUpdateConcurrencyException), the exception isn't caught prevent the View() method from being called

This also occurs in PageController.Publish()


[FEAT] Support color and date controls

Describe your changes
Support type attribute for controls to be able to use color and date value
UI changes

Testing

test color picker
test date picker

📦 Published PR as canary version: 2.2.6-canary.72.774.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v2.2.7 :rocket:


show status bar problems count for current file only

Issue Type: Feature Request
Please add an option to show status bar problems only for current file. It becomes a mess when editing many files and you can't see if there are problems in your file.
P.S. I know about a filter inside Problems' pane.
VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.10240

This was added in v1.41. See the release notes.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


"The plugin pathfinder caused QGIS to crash"

Feel free to close this as I don't have a stack trace or anything, but I wanted to file it just to let you know there might be an issue.
I was not interacting with the pathfinder plugin - I just right-clicked on the layer at the bottom of my layer tree and clicked "move to top", and QGIS claims that "Plugin pathfinder crashed QGIS".
I've had the same or similar crashes previously, which QGIS blamed on pathfinder even though I wasn't interacting with it. They weren't with 2.26.2, as I only installed that this morning, but I can't remember if I had any prior to 2.26.0
Python Stack Trace
Windows fatal exception: access violation

Current thread 0x000077ac (most recent call first):
  File "C:\Users/alistair/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\pathfinder\lib\layertreecontextmenumanager.py", line 112 in eventFilter
    menu.exec(self.view.mapToGlobal(event.pos()))

Stack Trace
No stack trace is available.

QGIS Info
QGIS Version: 3.26.2-Buenos Aires
QGIS code revision: feec3d3b12f
Compiled against Qt: 5.15.3
Running against Qt: 5.15.3
Compiled against GDAL: 3.5.1
Running against GDAL: 3.5.1

System Info
CPU Type: x86_64
Kernel Type: winnt
Kernel Version: 10.0.19042

Hey @AlisterH,
thank you for your report but as you said, there isn't much to go on. I work with 3.26.2 myself and I haven't had any issue like that and cannot replicate it right now on my personal machine.
I have had issues with crashes concerning access violations tho. But I feel like they happen more often when I work on a layout and not the main window and pathfinder doesn't do anything in the layout window.

I was not interacting with the pathfinder plugin
There is a short interaction happening whenever you right-click a layer in the Layers panel. That's probably why it is shown as the current thread.

You could try and deactivate pathfinder (or with a fresh profile™?) and see if the problem persists.
But I can't rule out anything so if you want you can send me a project where this happens and tell me what settings you use and I will keep trying to replicate the issue.
regards

I have had issues with crashes concerning access violations tho. But I feel like they happen more often when I work on a layout and not the main window and pathfinder doesn't do anything in the layout window.

I don't normally use layouts so I wouldn't know if the layout window has recent problems.

I was not interacting with the pathfinder plugin

There is a short interaction happening whenever you right-click a layer in the Layers panel. That's probably why it is shown as the current thread.

OK, it just seemed strange that it didn't crash straight away on the right-click, but after I clicked "move to top".

You could try and deactivate pathfinder (or try with a fresh profile™?) and see if the problem persists.

Yes, I deactivated it when I filed the ticket.  It isn't enough testing to conclude anything, but I haven't had any similar crashes since (only some crashes in another plugin that are easily reproduceable and clearly unrelated).
I have now reenabled it and installed the First Aid plugin to see if it helps with debugging these crashes.

Hey @AlisterH,
just checking in if you ran into any more problems related to this issue?

I've probably only seen it a couple of times this year.


Comparison strings are Hardcoded

https://github.com/openfoodfacts/openfoodfacts-androidapp/blob/master/app/src/main/java/openfoodfacts/github/scrachx/openfood/views/adapters/ProductComparisonAdapter.java#L193

fixed


Holographic Streaming unable to function after changing map

What is the secret to changing to a different unreal level with Holographic streaming?
Currently there are a few types of behaviors that occur when executing console command "open map"
To reproduce:

download the HololensViewer template
add a node somewhere in blueprints to execute console command "open arlevel" or use the console (~) and "open arlevel"

Behavior: The preview window will show 6-dof Head Rotation, but the image on the screen is stuck on the last frame.
===================================================
I'm trying to test the Windows Mixed Reality Plugin vs MicrosoftOpenXR Plugin
With Windows Mixed Reality Plugin my application will crash if i execute console command "open MapName" to ln 57 inside WindowsMixedRealityCustomPreset.h  ( if (StereoDepthTexture != nullptr) )
How do i maintain holographic streaming on map change?
can i pass -vr -HoloLensRemoting=<IP_ADDRESS> -RemotingBitRate=25000 somwhere in bluerpints?

Known OpenXR issue in 5.0.3.
Possible workarounds described here: #84


Fix block damage abilities (centaur return, vanguard etc.) preventing TrueKill (permanent wraith form)

Thanks for highlighting this bug! However, for items, I believe those modifiers aren't re-applied when the unit respawns. I'll check.

@fcalife  its a weird bug, i think the best fix is to add some flag to TrueKill that can be read on the damage interecptor, so you know to ignore all and just exit.

Added this on the next update. Thanks!


Fix Types

Reason for change
Consuming web components in Sphericon yields some type errors (some of which are new since v1) like these:

This PR fixes those to make it usable in a TS + React context. It shouldn’t have any visible change to the components.

The failed CI build failed trying to publish to npm. Should it have tried to publish to npm?

The failed CI build failed trying to publish to npm. Should it have tried to publish to npm?

Oh I deployed locally; it may have tried to deploy the same version and failed. It’s fine; this needs one more fix anyway I think.


UI for viewing archived channels

We should make it possible to see information about archived channels in the UI.

Add a three-dot menu to the "Filter channels" line in channel settings, which should have a Show archived channels / Hide archived channels option (depending on the current state). Default: archived channels are not shown.
Always show an "archived" icon ( https://lucide.dev/icons/archive ) next to the channel name in settings (left and right panel).
When viewing the channel, disable any settings that can't be changed. (I'm not exactly sure what the API does/does not allow.)

This issue is a prerequisite for allowing channels to be unarchived from the UI.

CZO thread

@alya i want to work on this issue...

@zulipbot claim


More Haskell Programs

Submission Title
:bangbang: Help Needed :bangbang:
Submission Type
Algorithm + Data Structure + STL + Maths_And_Stats + Resources
Submission Description
Implement all the existing programs in haskell
Submission Directory
Main_Folder => Sub_Folder => ... => ... => Filename.hs/lhs
Important

Don't wait to get assigned :no_entry_sign:
Just create the PR :heavy_check_mark:
If a PR for a specific algo/ds has already been opened, kindly opt a different program.There are plenty of them :grin:
Push the program in the appropriate directory
Please do not spam or create duplicate PR :warning:

@ahampriyanshu I have submitted few of haskell codes that i could write. Please find my PR and accept if you find it useful.

thanks everyone :v:


Undefined calls to (abc9) prep_bypass

Steps to reproduce the issue
I use the symbiflow to synthesize a verilog design. I get an assertion error during the  second synth_xilinx command:
21.5.2. Executing ABC9_OPS pass (helper functions for ABC9).
map_design->addModuledesign->addModule
$paramod\FDPE\INIT=1'x_$abc9_byp
ERROR: Assert `modules_.count(name) == 0' failed in kernel/rtlil.cc:623.
make: *** [Makefile:23: build/Hydrogen1.eblif] Error 1

kernel/rtlil.cc:313 calls addModule() on the design class and can't add it, because it already exists. So I searched in the output and found my debugging prints also in the PROC_CLEAN step.
<IP_ADDRESS>. Executing PROC_CLEAN pass (remove empty switches from decision trees).$
11305 Removing empty process `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbif      low/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1898$50554'.$
11306 Removing empty process `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbif      low/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1897$50553'.$
11307 Removing empty process `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbif      low/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1896$50552'.$
11308 Removing empty process `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbif      low/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1895$50551'.$
11309 Found and cleaned up 1 empty switch in `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$      proc$/opt/symbiflow/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1904$50472'.$
11310 Removing empty process `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbif      low/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1904$50472'.$
11311 Cleaned up 1 empty switch.$
11312 map_design->addModuledesign->addModule$
11313 $paramod\FDCE\INIT=1'x_$abc9_byp$
11314 unmap_design->addModule$
11315 map_design->addModuledesign->addModule$
11316 $paramod\FDPE\INIT=1'x_$abc9_byp$

Well, neither this tool nor another tools than abc9_ops.cc calls prep_bypass(). Therefore, I removed the call for this function in abc9_ops and got a "defined bot nut used warning" from gcc. Running the flow again, I get:
<IP_ADDRESS>. Executing PROC_CLEAN pass (remove empty switches from decision trees).
Removing empty process `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbiflow/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1898$50554'.
Removing empty process `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbiflow/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1897$50553'.
Removing empty process `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbiflow/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1896$50552'.
Removing empty process `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbiflow/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1895$50551'.
Found and cleaned up 1 empty switch in `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbiflow/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1904$50472'.
Removing empty process `$paramod$b4934def1af5f5fcc8b6ee124c5040d62fc2a45d\RAM64M.$proc$/opt/symbiflow/xc7/conda/envs/xc7/bin/../share/yosys/xilinx/cells_sim.v:1904$50472'.
Cleaned up 1 empty switch.
ERROR: No saved design '$abc9_map' found!
make: *** [Makefile:23: build/Hydrogen1.eblif] Error 1

Seems like prep_bypass was still called from somewhere ...
I do not have much experience in debugging c++ code. Anyone suggestions?
BTW: The binary was built with master.
Design file
Hydrogen1.v.txt (Remove the .txt at the end)
Complete stdout
stdout.txt
tcl
synth.tcl.txt (Remove the .txt at the end)

Seems like this was in issue with my local setup. When using the yosys binary from the litex-hub, I can synthesize my design.


Update maintainers

Update maintainers to Alejandro Hernandez Cordero (@ahcorde).

@ahcorde, this PR changes your name and rearranges things a bit. Feel free to approve and merge, or close it, if you like.


hw/sensor: Disable OIC sensor server by default

It requires OIC support to be enabled so usually it needs to be anyway
manually disabled in app/target.

Yes please. Im manually disabling this in all my targets and it annoys me when I see it every time :)

Actually, there was a reason this was enabled by default. We wanted the mynewt sensor android app to work out of box with any device that uses sensors_test app. Hence, the default ON behavior. Is there a reason for disabling this ? Maybe @sterlinghughes and @aditihilbert can chime in since it was their ask in the first place.