libuv: 1.19.2 -> 1.20.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/libuv/versions.
These checks were done:

built on NixOS
Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
found 1.20.0 with grep in /nix/store/r6j9x782s7pl6a5055icynmzk1991imw-libuv-1.20.0
directory tree listing: https://gist.github.com/cff77ff2c13f732c2027bb680a833c5e

cc @cstrahan for review

Success on x86_64-linux (full log)
Attempted: libuv
Partial log (click to expand)
 /nix/store/qrxs7sabhqcr3j9ai0j0cp58zfnny0jz-coreutils-8.29/bin/install -c -m 644 libuv.pc '/nix/store/r6j9x782s7pl6a5055icynmzk1991imw-libuv-1.20.0/lib/pkgconfig'
make[1]: Leaving directory '/tmp/nix-build-libuv-1.20.0.drv-0/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r6j9x782s7pl6a5055icynmzk1991imw-libuv-1.20.0
shrinking /nix/store/r6j9x782s7pl6a5055icynmzk1991imw-libuv-1.20.0/lib/libuv.so.1.0.0
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/r6j9x782s7pl6a5055icynmzk1991imw-libuv-1.20.0/lib
patching script interpreter paths in /nix/store/r6j9x782s7pl6a5055icynmzk1991imw-libuv-1.20.0
checking for references to /tmp/nix-build-libuv-1.20.0.drv-0 in /nix/store/r6j9x782s7pl6a5055icynmzk1991imw-libuv-1.20.0...
/nix/store/r6j9x782s7pl6a5055icynmzk1991imw-libuv-1.20.0

Success on aarch64-linux (full log)
Attempted: libuv
Partial log (click to expand)
 /nix/store/c8bwnx988ckbw2igggv41s1mbd0v743m-coreutils-8.29/bin/install -c -m 644 libuv.pc '/nix/store/sh41c4g65pgi836agnk0wpjkbgk8xhr3-libuv-1.20.0/lib/pkgconfig'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sh41c4g65pgi836agnk0wpjkbgk8xhr3-libuv-1.20.0
shrinking /nix/store/sh41c4g65pgi836agnk0wpjkbgk8xhr3-libuv-1.20.0/lib/libuv.so.1.0.0
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/sh41c4g65pgi836agnk0wpjkbgk8xhr3-libuv-1.20.0/lib
patching script interpreter paths in /nix/store/sh41c4g65pgi836agnk0wpjkbgk8xhr3-libuv-1.20.0
checking for references to /build in /nix/store/sh41c4g65pgi836agnk0wpjkbgk8xhr3-libuv-1.20.0...
/nix/store/sh41c4g65pgi836agnk0wpjkbgk8xhr3-libuv-1.20.0

Success on x86_64-darwin (full log)
Attempted: libuv
Partial log (click to expand)
/nix/store/x6zl760gw65ykvk800lqb8xcydf06ha1-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/x6zl760gw65ykvk800lqb8xcydf06ha1-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/x6zl760gw65ykvk800lqb8xcydf06ha1-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/x6zl760gw65ykvk800lqb8xcydf06ha1-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/x6zl760gw65ykvk800lqb8xcydf06ha1-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/x6zl760gw65ykvk800lqb8xcydf06ha1-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/x6zl760gw65ykvk800lqb8xcydf06ha1-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/x6zl760gw65ykvk800lqb8xcydf06ha1-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/x6zl760gw65ykvk800lqb8xcydf06ha1-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/x6zl760gw65ykvk800lqb8xcydf06ha1-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib

Success on x86_64-darwin (full log)
Attempted: libuv
Partial log (click to expand)
/nix/store/y5zqsbrvd7vf8l7cca14ybbgscbj2pm3-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/y5zqsbrvd7vf8l7cca14ybbgscbj2pm3-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/y5zqsbrvd7vf8l7cca14ybbgscbj2pm3-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/y5zqsbrvd7vf8l7cca14ybbgscbj2pm3-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/y5zqsbrvd7vf8l7cca14ybbgscbj2pm3-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/y5zqsbrvd7vf8l7cca14ybbgscbj2pm3-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/y5zqsbrvd7vf8l7cca14ybbgscbj2pm3-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/y5zqsbrvd7vf8l7cca14ybbgscbj2pm3-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/y5zqsbrvd7vf8l7cca14ybbgscbj2pm3-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib
/nix/store/y5zqsbrvd7vf8l7cca14ybbgscbj2pm3-libuv-1.20.0/lib/libuv.1.dylib: fixing dylib


Embedding Function not properly passed to Chroma Collection

https://discord.com/channels/1038097195422978059/1038097349660135474/1082685778582310942
details are in the discord thread.
the code change here changed how chroma handles embedding functions and it seems like ours is being sent as None for some reason.

Seeing this too. Version 0.0.102.
Code: ```from langchain.document_loaders import TextLoader
from langchain.embeddings import TensorflowHubEmbeddings
loader = TextLoader('./state_of_the_union.txt')
documents = loader.load()
text_splitter = CharacterTextSplitter(chunk_size=1000, chunk_overlap=0)
texts = text_splitter.split_documents(documents)
embeddings = TensorflowHubEmbeddings()
docsearch = Chroma.from_documents(texts, embeddings)

Error:

File /usr/local/lib/python3.10/dist-packages/langchain/vectorstores/chroma.py:67, in Chroma.init(self, collection_name, embedding_function, persist_directory)
62     logger.warning(
63         f"Collection {collection_name} already exists,"
64         " Do you have the right embedding function?"
65     )
66 else:
---> 67     self._collection = self._client.create_collection(
68         name=collection_name,
69         embedding_function=self._embedding_function.embed_documents
70         if self._embedding_function is not None
71         else None,
72     )
TypeError: LocalAPI.create_collection() got an unexpected keyword argument 'embedding_function'

I believe this should fix it. https://github.com/hwchase17/langchain/pull/1444

I believe this should fix it. #1444

This works, thank you!

#1444 was merged in - is this resolved in 0.0.107

I still seem to be having this issue, has it been resolved?

I haven't seen this issue since the aforementioned merge commit.

I still get the same error.
---------------------------------------------------------------------------

TypeError                                 Traceback (most recent call last)

[<ipython-input-26-13b99c9bccce>](https://localhost:8080/#) in <cell line: 5>()
      3 text_field = "text"
      4 index = pinecone.Index(index_name)
----> 5 vectorstore = Pinecone(
      6     index=index,
      7     embedding_function=embed.embed_query,

TypeError: Pinecone.__init__() got an unexpected keyword argument 'embedding_function'

for this code
from langchain.vectorstores import Pinecone

text_field = "text"
index = pinecone.Index(index_name)
vectorstore = Pinecone(
    index=index,
    embedding_function=embed.embed_query,
    text_key=text_field)
query = "foo"
top = vectorstore.similarity_search(query, k=3)


Earlgrey: newest tlul_fifo_async doesn't work in Verilator

After updating Opentitan to newest version, tlul_fifo_async.sv is failing with:
%Error: /media/hdd/uhdm/uhdm-integration/verilator/uhdm-integration/../uhdm-tests/opentitan/module_tests//..//opentitan/build/lowrisc_dv_chip_verilator_sim_0.1/src/lowrisc_prim_fifo_0/rtl/prim_fifo_async.sv:255:35: Can't find definition of task/function: 'gray2dec'
%Error: /media/hdd/uhdm/uhdm-integration/verilator/uhdm-integration/../uhdm-tests/opentitan/module_tests//..//opentitan/build/lowrisc_dv_chip_verilator_sim_0.1/src/lowrisc_prim_fifo_0/rtl/prim_fifo_async.sv:257:35: Can't find definition of task/function: 'gray2dec'
%Error: /media/hdd/uhdm/uhdm-integration/verilator/uhdm-integration/../uhdm-tests/opentitan/module_tests//..//opentitan/build/lowrisc_dv_chip_verilator_sim_0.1/src/lowrisc_prim_fifo_0/rtl/prim_fifo_async.sv:259:31: Can't find definition of task/function: 'dec2gray'
%Error: /media/hdd/uhdm/uhdm-integration/verilator/uhdm-integration/../uhdm-tests/opentitan/module_tests//..//opentitan/build/lowrisc_dv_chip_verilator_sim_0.1/src/lowrisc_prim_fifo_0/rtl/prim_fifo_async.sv:260:31: Can't find definition of task/function: 'dec2gray'
%Error: Exiting due to 4 error(s)

Those functions are defined in prim_fifo_async.sv (see #494 first).

The same problem as in #494, I mark it as blocked


Searchbox widget on ios should show search button in keyboard and close keyboard when the user press search.

Just made a fix for this. I'll reference in a sec.

See solution: https://github.com/algolia/instantsearch.js/pull/1450#issuecomment-259118772


Laravel 5.5 custom helper file Class become doesn't exists

Laravel Version: 5.5
PHP Version: 7.2
Database Driver & Version: Maria DB

This is my code:
//helpers.php
if (!function_exists('image_helper')) {
    function image_helper($file = NULL, $path = NULL)
    {
        $image = app('image_helper');

        if (!is_null($file) && is_null($path)) {
            return $image->generateTmp($file);
        }

        return $image;
    }
}

// ImageHelper.php
<?php

namespace App\Helpers;

use Illuminate\Http\File;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Storage;
use Intervention\Image\Facades\Image;
use Spatie\ImageOptimizer\OptimizerChainFactory;
use Symfony\Component\HttpFoundation\File\UploadedFile;

class ImageHelper
{
    private $fileName, $sizes;

    function __construct()
    {
        $this->fileName = md5(time() . openssl_random_pseudo_bytes(16));
    }

    public function get($query, $path, $type)
    {
        $arr = [];
        $sizes = getImageSizes($type);

        $picture = $query->picture()->first();

        if ($picture) {
            foreach ($sizes as $key => $size) {
                $url = filter_var($picture->file, FILTER_VALIDATE_URL) ?
                    $picture->file :
                    Storage::url($path . $key . '/' . $picture->file);

                $arr = array_add($arr, $key, $url);
            }
        }

        return $arr;
    }
?>

I've already add at my composer.json:
"autoload": {
"classmap": [
  "database/seeds",
  "database/factories",
  "app/Helpers/helpers.php"
],
"psr-4": {
  "App\\": "app/"
},
"files": [
  "app/Helpers/helpers.php"
]
},

When I run this code: image_helper()->get($query, '/images');
I got ReflectionException (-1) Class image_helper does not exist
Already do composer dump-autoload, php artisan optimize it still the same.
Previously on Laravel 5.4 it works perfectly.
Any solution?

Your problem is on this line in your helper function:
$image = app('image_helper');

Looks like you forgot to register the image helper class to your container. Why not update it to this?:
$image = app('App\Helpers\ImageHelper');

In any case, this is not a problem with the framework and your helper function is working just fine.

@samrap yes. now it's working. :D


Update to 1.20.4?

Hi!  Is there going to be a update to it? I understand this is a really complex project and it would take a lot of effort.

actually it's super easy! mineflayer recently added 1.20.4 support. awaiting review, will be merged soon #28


New play that just install an Fyre OCP+Beta cluster with cephfs installed.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

PR https://github.com/IBM/community-automation/pull/23


Multiple deploy points at beginning of new game

Suggestion/Feature request
Is your feature request related to a problem? Please describe:
I'm trying to make multiple redeploy points so when the game starts i would have a list that contains
"operation base"
"destroyer"
"marine start point" and
"naval yard"
I created small grasscutters and named them in in sequence so e.g.
startbase
startbase1
startbase2
startbase3
Describe the solution you'd like:
Im quite the amateur that has managed to do some sucessfull editing e.g. adding additional buildable items and working on ui to get ace arsenal and max fob count but my knowledge (lack of) is giving me a headache, help would be much appreciated  i have been trying in scripts>client>spawn>redeploy_manager.sqf
Ive tried several ways of writing up line 20 and 86 in this file from 96.5 but unfortunatly i get to deploy and then spawn on the island

No need to ask this on Discord and opening an "issue", while deleting your message in Discord, some minutes after you don't get a reply there.

Sorry i read up and someone stated they may get lost on discord and it would be best to try here so i figured best writing here rather than possibility of it getting lost


[Documentation Update]: Update file

Is there an existing issue for this?

[X] I have searched the existing issues

Issue Description
The current LEARN.md file looks somewhat like README.md.
Suggested Change
I would like to update the LEARN.md file for this project. Kindly assign this task to me under GSSoC'24 with required labels. @mav
Rationale
No response
Urgency
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Passionatelytoooadorable not needed


Custom Slider(expanded from input tag) not showing on PDF

Hi everyone!
I ran into a problem of not showing a custom slider on the pdf.
Here is the original html page:

Here is the pdf exported. Slider has gone completely!

No idea why html2pdf skipped over this slider content?

https://www.w3schools.com/howto/howto_js_rangeslider.asp
does it even work with any of these sliders? (can you check this for me?)
could be its an limitation of the library, if so its an issue, and need to be looked at.

It didn't work.
This is the original html page

After exporting pdf,

Default slider without any css.

After export

Workaround ;
Not using sliders as its apparently not implemented;
If the end result is just the result of a slider, you might want to modify the sliders input tag.
This can be done by grabbing the element and modifying it using css and JSS to remove the input tag and grab the value from the tag  , and just paint a new one by making a DIV and adding a line and fake a slider using CSS to make a line of X length using a div, and add the amount as a number underneath it.

Good idea!
On Thu, Feb 18, 2021 at 3:15 AM Jasper<EMAIL_ADDRESS>wrote:

Workaround ;
Not using sliders as its apparently not implemented;
If the end result is just the result of a slider, you might want to modify
the sliders input tag.
This can be done by grabbing the element and modifying it using css and
JSS to remove the input tag and grab the value from the tag , and just
paint a new one by making a DIV and adding a line and fake a slider using
CSS to make a line of X length using a div, and add the amount as a number
underneath it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/eKoopmans/html2pdf.js/issues/390#issuecomment-781236627,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AESKP5ZAH7K5UJDXGR2YPY3S7TSELANCNFSM4XC5F2KA
.


New feature: Server response cache handler.

Coverage decreased (-0.3%) to 70.025% when pulling b3000c55dbd7599d5c35b9d8ec44eab48a9715eb on little-cui:master into ac5c6a861e5e69c863510b8a312199205af2cc16 on ServiceComb:master.

Codecov Report

Merging #170 into master will decrease coverage by 0.26%.
The diff coverage is 93.47%.

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   66.01%   65.74%   -0.27%
==========================================
  Files          18       18
  Lines        4469     4437      -32
==========================================
- Hits         2950     2917      -33
- Misses       1337     1338       +1
  Partials      182      182

Impacted Files
Coverage Δ

server/service/util/microservice_util.go
61.19% <100%> (ø)
:arrow_up:

server/service/governservice.go
70.8% <100%> (-0.83%)
:arrow_down:

server/service/tag.go
70.73% <100%> (-0.29%)
:arrow_down:

server/service/util/instance_util.go
48.22% <100%> (ø)
:arrow_up:

server/service/services_dependency.go
67.85% <100%> (+0.25%)
:arrow_up:

server/service/microservices.go
72.03% <100%> (-0.19%)
:arrow_down:

server/service/rule.go
71.34% <100%> (-0.17%)
:arrow_down:

server/service/util/tag_util.go
63.63% <100%> (ø)
:arrow_up:

server/service/instances.go
69.26% <100%> (-0.49%)
:arrow_down:

server/service/schema.go
71.17% <100%> (-0.13%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac5c6a8...b3000c5. Read the comment docs.


vlang: easy way how to get started tfgrid client

use installer (see how we did for e.g. zdb) to install nodejs in sandboxed env
in client, have a function which will run the required code and starts the server, then check the connection is ok

configure the server while doing so
runs per user

make example so user only need to use this one easy way
have some examples in examples folder

we are working with the golang client now


Support multi-port services.

What does this PR do?
Support Kubernetes services with multiple defined ports.
Motivation

enable more compact port definitions
be aligned with the existing Service routing behavior

More

[x] Added/updated tests
~[ ] Added/updated documentation~ (not needed as we simply match what upstream Kubernetes already does on Service objects)

Fixes #3118.

@dtomcej and I have been discussing about the design aspect of this PR on the issue already.
For formality reasons and in case anyone else wants to chime in, however, I'll maintain status/1 for now.


Implement EIP-1186 Node Decoding for VerifyEthereumProofs

This requires implementing RLP decoding and implementing the proper node decoding logic here:
https://github.com/polytope-labs/solidity-merkle-trees/blob/main/src/trie/ethereum/EthereumTrieDB.sol

@seunlanlege I'd like to work on that, ok for you?
As far as I understood, I just need to follow RLP definition for encoding and apply it to decoding, correct?

@seunlanlege I'd like to work on that, ok for you?
As far as I understood, I just need to follow RLP definition for encoding and apply it to decoding, correct?

Yeah feel free. The task is just RLP node decoding, you could also just use a battle tested library for decoding.

@seunlanlege I'd like to work on that, ok for you?
As far as I understood, I just need to follow RLP definition for encoding and apply it to decoding, correct?

Yeah feel free. The task is just RLP node decoding, you could also just use a battle tested library for decoding.

I'm currently using this RLPReader library.
I'm able to retrieve the node kind, but probably i'm missing something for the keys of each node. Maybe I have to implement this from_compact in order to obtain the actual key?

You'll need to read the EIP-1186 spec. The node kind should be in the first few bytes of the node rlp

The node kind is not an issue, I'm doing it following Patricia Merkle Trie - Optimization and Patricia Merkle Trie - Specification.
The issue i'm having now is while decoding the actual nodes, I'm probably not removing / transforming some of the bytes decoded.

The issue i'm having now is while decoding the actual nodes, I'm probably not removing / transforming some of the bytes decoded.

Here's a working rust implementation for node decoding to guide your implementation: https://github.com/polytope-labs/ethereum-triedb/blob/main/src/node_codec.rs


[MWPW-116099] Enable multiple rating segments

Please always provide the JIRA issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix MWPW-116099
Test URLs:

Before: https://main--express-website--adobe.hlx.page/express/feature/image/remove-background
After: https://mwpw-116099--express-website--webistry-development.hlx.page/express/feature/image/remove-background

This PR aims to add multiple segments to allow rating on different quick action pages. I suggest that in the future maybe we should migrate the segments array to either a dedicated sheet, or a metadata row.
You can test the different pages by referring to the segments on the JIRA task and adding/removing those segments for yourself.
This is still currently being tested by Abhinav and his team, and should not be merged at the moment.

This needs to be pushed to prod for testing, as segments can only be resolved in production.


itemBefore and itemAfter fields for MatchEvent always return 0.

itemBefore and itemAfter fields for the Match Event DTOs always return 0, as the field names from the API response were changed, and are no longer being converted properly in GSON.

This issue has now been fixed - https://github.com/taycaldwell/riot-api-java/commit/194afc2cd231d9a0ba2a76c2d8f9b463249b51a5

A release with this fix has been made: https://github.com/taycaldwell/riot-api-java/releases/tag/4.0.1


Mongo Error on Deno runtime

Hello
I have tried to run a project on deno, but I receive the following error when trying to run it using "deno"
error: Uncaught Error: MongoError: "Connection failed: Connection refused (os error 111)"
        throw new MongoError(`Connection failed: ${e.message || e}`);
              ^
    at MongoClient.connect (client.ts:93:15)
    at async db.ts:5:12

Note:
I have tried it several times but the problem still persists.
Thanks in advance

May I know how do you use it?

May I know how do you use it?

May I know how do you use it?

May I know how do you use it?

Expanding upon @hackers267, show your code. It's possible that the hostname/port is incorrect

Expanding upon @hackers267, show your code. It's possible that the hostname/port is incorrect

Thanks for the reply
I have allocated a separate module for database namely db.ts

import { MongoClient } from<EMAIL_ADDRESS>
const client = new MongoClient();
// await client.connect("mongodb://localhost:27017");
const db = await client.connect("mongodb://localhost:27017/kayran");

export * from<EMAIL_ADDRESS>
export default db;

Please note that, I did successfully launched my project but after a few re-run deno stopped creating the server and currently it is showing the above error
Thank you

If you used os is window. Try replace localhost with <IP_ADDRESS>

My OS is "Linux Manjaro" and I can run the project on the "Ubuntu" without any problem

Make sure mongo is running by using sudo service mongodb start command

If you used os is window. Try replace localhost with <IP_ADDRESS>

This also solved my problem on Ubuntu

I have the same problem on ubuntu, but I don't think it's an issue with this driver.
When I run Deno.connect({hostname: "<domain name of our database", port: 27017}) I'm getting the same os error 111.
Connecting to the ip directly also fixes it for me, and connecting from my local machine to the domain name also works just fine.
It turns out this was caused by ipv6 somehow. When I created a digitalocean droplet without ipv6 support it was able to connect to the server again.


libressl: add 3.1.2, default to it, remove 2.9

Motivation for this change

LibreSSL 3.1.1 has been released upstream.
LibreSSL 2.9, which was part of OpenBSD 6.5, is no longer supported, because OpenBSD 6.5 is now more than one year old.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I also tested compiling Nginx against this LibreSSL, which succeeded.

Let's see which of the builds will fail:
@GrahamcOfBorg build acme-client
@GrahamcOfBorg build foundationdb
@GrahamcOfBorg build foundationdb51
@GrahamcOfBorg build foundationdb52
@GrahamcOfBorg build foundationdb60
@GrahamcOfBorg build foundationdb61
@GrahamcOfBorg build libressl
@GrahamcOfBorg build libressl_3_1
@GrahamcOfBorg build linux-steam-integration
@GrahamcOfBorg build mydumper
@GrahamcOfBorg build netcat
@GrahamcOfBorg build openntpd
@GrahamcOfBorg build openntpd_nixos
@GrahamcOfBorg build opensmtpd
@GrahamcOfBorg build ponyc
@GrahamcOfBorg build pony-stable
@GrahamcOfBorg build pounce
@GrahamcOfBorg build python27Packages.foundationdb51
@GrahamcOfBorg build python27Packages.foundationdb52
@GrahamcOfBorg build python27Packages.foundationdb60
@GrahamcOfBorg build python27Packages.foundationdb61
@GrahamcOfBorg build python37Packages.foundationdb51
@GrahamcOfBorg build python37Packages.foundationdb52
@GrahamcOfBorg build python37Packages.foundationdb60
@GrahamcOfBorg build python37Packages.foundationdb61
@GrahamcOfBorg build python38Packages.foundationdb51
@GrahamcOfBorg build python38Packages.foundationdb52
@GrahamcOfBorg build python38Packages.foundationdb60
@GrahamcOfBorg build python38Packages.foundationdb61
@GrahamcOfBorg build s6-networking
@GrahamcOfBorg build skawarePackages.s6-networking
@GrahamcOfBorg build tests.nixos-functions.nixos-test
@GrahamcOfBorg build tests.nixos-functions.nixosTest-test
@GrahamcOfBorg build twa
@GrahamcOfBorg build wasm-pack

The foundationdb packages seem broken already (e.g https://hydra.nixos.org/build/119086724/nixlog/1).
But, wasm-pack's failure is more actionable: https://logs.nix.ci/?key=nixos/nixpkgs.88195&attempt_id=88b84284-44e8-4d93-8105-08c64ddc3430 . I think the proper fix for it will be making it switch to openssl. Could you please test this locally before pushing?

Thanks for taking a look!

But, wasm-pack's failure is more actionable: https://logs.nix.ci/?key=nixos/nixpkgs.88195&attempt_id=88b84284-44e8-4d93-8105-08c64ddc3430 . I think the proper fix for it will be making it switch to openssl. Could you please test this locally before pushing?

This is the result of a conservative compatibility check in rust-openssl. Compatibility is actually fine, but rust-openssl refuses to compile with anything that is not explicitly listed in its source. This was fixed upstream for LibreSSL 3.1 in https://github.com/sfackler/rust-openssl/pull/1271, which is part of the openssl-sys-v0.9.57 crate. I could switch to OpenSSL, but we will likely run into the same problem at the next OpenSSL version bump.
Is there a way to override a single crate for a Rust project? I suppose we can patch Cargo.lock ... how is this handled in other situations?
Probably switching to OpenSSL is the quick fix, what do you think @doronbehar?

In the meantime, LibreSSL 3.1.2 was released. I’ve updated this pull request accordingly.

Is there a way to override a single crate for a Rust project? I suppose we can patch Cargo.lock ... how is this handled in other situations?

Patching Cargo.lock is a bit annoying... It wouldn't have been that hard if we had only started right from the start to keep derivations for all crates we use to build Rust programs as derivations in Nixpkgs. Rather, we use fixed output derivations which have even more issues than this, see https://github.com/NixOS/nix/issues/2270 & my comment & discussion at https://github.com/NixOS/nixpkgs/issues/84826#issuecomment-616450327 .

I could switch to OpenSSL, but we will likely run into the same problem at the next OpenSSL version bump.

I think it'll be most proper to let future us handle that :). But seriously, I think this is the cleanest way to handle our issue. More over, I think that we should avoid having some projects depend on Libressl and others on Openssl if they are almost compatible. I mean, unless a project requires specifically Libressl, what advantage does one have on the other? I'm aware of the licensing issue, but is it a big deal for wasm-pack? IDK, it'll need some research...
Perhaps it'll be best to change wasm-pack to use openssl in a different PR, so then the maintainer of wasm will stay focused.

Oh and BTW please squash https://github.com/NixOS/nixpkgs/pull/88195/commits/082e12f34820b8dd50cce94ae46c2df974a6047d .

Perhaps it'll be best to change wasm-pack to use openssl in a different PR, so then the maintainer of wasm will stay focused.

There's an upstream issue for wasm-pack with openssl, as indicated by the comment in wasm's default.nix: https://github.com/rustwasm/wasm-pack/issues/650
I'm taking my words back. An even cleaner solution, would be this:
diff --git i/pkgs/top-level/all-packages.nix w/pkgs/top-level/all-packages.nix
index 548b09a6849..8ff32d7fc92 100644
--- i/pkgs/top-level/all-packages.nix
+++ w/pkgs/top-level/all-packages.nix
@@ -26174,6 +26174,7 @@ in
   wasmer = callPackage ../development/interpreters/wasmer { };

   wasm-pack = callPackage ../development/tools/wasm-pack {
+    libressl = libressl_3_0;
     inherit (darwin.apple_sdk.frameworks) Security;
   };

Which will even reduce by 1 the amount of packages ofborg will detect as affected by this change.

An even cleaner solution, would be this

Yes, that seems like the cleanest solution to me too. I added that, and I squashed 082e12f. Please take another look.
I can also confirm that wasm-pack is no longer affected, because when I tried to build it, I got it from cache.nixos.org.

I can also confirm that wasm-pack is no longer affected, because when I tried to build it, I got it from cache.nixos.org.

Exactly :+1:.
Let's perform another builds test:
@GrahamcOfBorg build acme-client
@GrahamcOfBorg build foundationdb
@GrahamcOfBorg build foundationdb51
@GrahamcOfBorg build foundationdb52
@GrahamcOfBorg build foundationdb60
@GrahamcOfBorg build foundationdb61
@GrahamcOfBorg build libressl
@GrahamcOfBorg build libressl_3_1
@GrahamcOfBorg build linux-steam-integration
@GrahamcOfBorg build mydumper
@GrahamcOfBorg build netcat
@GrahamcOfBorg build openntpd
@GrahamcOfBorg build openntpd_nixos
@GrahamcOfBorg build opensmtpd
@GrahamcOfBorg build ponyc
@GrahamcOfBorg build pony-stable
@GrahamcOfBorg build pounce
@GrahamcOfBorg build python27Packages.foundationdb51
@GrahamcOfBorg build python27Packages.foundationdb52
@GrahamcOfBorg build python27Packages.foundationdb60
@GrahamcOfBorg build python27Packages.foundationdb61
@GrahamcOfBorg build python37Packages.foundationdb51
@GrahamcOfBorg build python37Packages.foundationdb52
@GrahamcOfBorg build python37Packages.foundationdb60
@GrahamcOfBorg build python37Packages.foundationdb61
@GrahamcOfBorg build python38Packages.foundationdb51
@GrahamcOfBorg build python38Packages.foundationdb52
@GrahamcOfBorg build python38Packages.foundationdb60
@GrahamcOfBorg build python38Packages.foundationdb61
@GrahamcOfBorg build s6-networking
@GrahamcOfBorg build skawarePackages.s6-networking
@GrahamcOfBorg build tests.nixos-functions.nixos-test
@GrahamcOfBorg build tests.nixos-functions.nixosTest-test
@GrahamcOfBorg build twa

Among those that failed to build by ofborg at this point, are:

acme-client (Darwin only)
foundationdb51
foundationdb52
foundationdb60
python27Packages.foundationdb51
python27Packages.foundationdb52
python27Packages.foundationdb60
python37Packages.foundationdb51
python37Packages.foundationdb52
python37Packages.foundationdb60
python38Packages.foundationdb51
python38Packages.foundationdb52
python38Packages.foundationdb60

All of the foundationdb related packages seem to fail already to build on hydra, according to:
✖ (Failed) foundationdb-5.1.7 from 2020-05-12 - https://hydra.nixos.org/build/119082079
✖ (Failed) foundationdb-5.2.8 from 2020-05-12 - https://hydra.nixos.org/build/119102761
✖ (Failed) foundationdb-6.0.18 from 2020-05-12 - https://hydra.nixos.org/build/119084292
✖ (Dependency failed) python2.7-foundationdb-5.1.7 from 2020-05-12 - https://hydra.nixos.org/build/119106730
✖ (Dependency failed) python2.7-foundationdb-5.2.8 from 2020-05-12 - https://hydra.nixos.org/build/119100305
✖ (Dependency failed) python2.7-foundationdb-6.0.18 from 2020-05-12 - https://hydra.nixos.org/build/119086724
✖ (Dependency failed) python3.7-foundationdb-5.1.7 from 2020-05-12 - https://hydra.nixos.org/build/119085667
✖ (Dependency failed) python3.7-foundationdb-5.2.8 from 2020-05-12 - https://hydra.nixos.org/build/119110244
✖ (Dependency failed) python3.7-foundationdb-6.0.18 from 2020-05-12 - https://hydra.nixos.org/build/119080156
✖ (Dependency failed) python3.8-foundationdb-5.1.7 from 2020-05-12 - https://hydra.nixos.org/build/119108276
✖ (Dependency failed) python3.8-foundationdb-5.2.8 from 2020-05-12 - https://hydra.nixos.org/build/119091045
✖ (Dependency failed) python3.8-foundationdb-6.0.18 from 2020-05-12 - https://hydra.nixos.org/build/119084236

(Thanks hydra-check).
As for acme-client - it's indicated that it fails on Darwin only now, but it seems it failed also before this PR: https://hydra.nixos.org/job/nixpkgs/nixpkgs-20.03-darwin/acme-client.x86_64-darwin
So to summarize, this PR Should be good to go.

@thoughtpolice, cc @fpletz, is there anything else I can do to help move this forward?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixpkgs-policy-regarding-libraries-available-in-multiple-versions/7026/4

In the meantime, LibreSSL 3.1.3 has been released. I updated this PR accordingly.

got this output from nix-review, not sure if there is any regression. Somebody will have to check.
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/lass/.cache/nixpkgs-review/pr-88195-1/build.nix
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/b6crzcwl1jwi2ivpan06343f069drdb6-foundationdb-5.1.7.drv' failed with exit code 2; last 10 log lines:
    FILE* f;
                   ^
  In file included from /nix/store/al9wk2c1l2j6fdpclj4k9cnxyc4i0k3b-glibc-2.30-dev/include/unistd.h:1170:0,
                   from ./flow/Platform.h:49,
                   from ./flow/flow.h:40,
                   from flow/Profiler.actor.cpp:39:
  /nix/store/al9wk2c1l2j6fdpclj4k9cnxyc4i0k3b-glibc-2.30-dev/include/bits/unistd_ext.h:34:16: note: old declaration '__pid_t gettid()'
   extern __pid_t gettid (void) __THROW;
                  ^~~~~~
  make: *** [flow/generated.mk:71: .objs/flow/Profiler.actor.g.cpp.o] Error 1
cannot build derivation '/nix/store/kfvhlfhi6qrmiabayhznskld8pcbvkgr-python2.7-foundationdb-5.1.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/s6g4xrp1627f8xzrqhkp5bji2kdr1scj-python3.7-foundationdb-5.1.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/isy84sg2vdygvjkwfcsh3dvkn8h8cg29-python3.8-foundationdb-5.1.7.drv': 1 dependencies couldn't be built
builder for '/nix/store/yjlipkd1kaxwfrlk7i4yczlnwajpci4z-foundationdb-5.2.8.drv' failed with exit code 2; last 10 log lines:
   static uint64_t gettid() { return syscall(__NR_gettid); }
                   ^~~~~~
  In file included from /nix/store/al9wk2c1l2j6fdpclj4k9cnxyc4i0k3b-glibc-2.30-dev/include/unistd.h:1170:0,
                   from ./flow/Platform.h:49,
                   from ./flow/flow.h:40,
                   from flow/Profiler.actor.cpp:21:
  /nix/store/al9wk2c1l2j6fdpclj4k9cnxyc4i0k3b-glibc-2.30-dev/include/bits/unistd_ext.h:34:16: note: old declaration '__pid_t gettid()'
   extern __pid_t gettid (void) __THROW;
                  ^~~~~~
  make: *** [flow/generated.mk:71: .objs/flow/Profiler.actor.g.cpp.o] Error 1
cannot build derivation '/nix/store/y6bq7sismipmqzc43yqmgn27za6a4030-python2.7-foundationdb-5.2.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7ldl4nmdlbacsfaaz4x9kbhjlrh64w4z-python3.7-foundationdb-5.2.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7cpzyi9z9kprvs3l2024yd2am6knwmms-python3.8-foundationdb-5.2.8.drv': 1 dependencies couldn't be built
builder for '/nix/store/m8widbiqwd5pfp9d4zr9nb0b7rc6pbsn-foundationdb-6.0.18.drv' failed with exit code 2; last 10 log lines:
      l = std::min(FLOW_KNOBS->MAX_METRIC_LEVEL-1, (int64_t)(::log(1.0/x) / FLOW_KNOBS->METRIC_LEVEL_DIVISOR));
                                                             ^~
  make: *** [flow/generated.mk:78: .objs/flow/Platform.cpp.o] Error 1
  flow/TDMetric.actor.h: In instantiation of 'void ContinuousMetric<T>::change() [with T = long int]':
  flow/TDMetric.actor.h:1232:9:   required from 'void ContinuousMetric<T>::onEnable() [with T = long int]'
  flow/SystemMonitor.cpp:262:1:   required from here
  flow/TDMetric.actor.h:1277:10: error: 'log' was not declared in this scope
         log((toggleTime - tv.time) / x) /
         ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  make: *** [flow/generated.mk:78: .objs/flow/SystemMonitor.cpp.o] Error 1
cannot build derivation '/nix/store/n60rvrpiaajggiyrqx4r7krkpcmm8qmx-python2.7-foundationdb-6.0.18.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/m5kmlfslz84fsimdn0sximj08p5cvwvr-python3.7-foundationdb-6.0.18.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qvmmxpnfndl6qwp360gnhr6vwra7lcwx-python3.8-foundationdb-6.0.18.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f425jywjabaij7pg3fr9mzz6m2j9h1fn-env.drv': 12 dependencies couldn't be built
[0 built (3 failed), 0.0 MiB DL]
error: build of '/nix/store/f425jywjabaij7pg3fr9mzz6m2j9h1fn-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/88195
2 packages blacklisted:
tests.nixos-functions.nixos-test tests.nixos-functions.nixosTest-test

12 packages failed to build:
foundationdb51 foundationdb52 foundationdb60 python27Packages.foundationdb51 python27Packages.foundationdb52 python27Packages.foundationdb60 python37Packages.foundationdb51 python37Packages.foundationdb52 python37Packages.foundationdb60 python38Packages.foundationdb51 python38Packages.foundationdb52 python38Packages.foundationdb60

15 packages built:
acme-client foundationdb libressl mydumper netcat openntpd opensmtpd pony-stable ponyc pounce python27Packages.foundationdb61 python37Packages.foundationdb61 python38Packages.foundationdb61 s6-networking twa

@Lassulus We already checked 3.1.2 at https://github.com/NixOS/nixpkgs/pull/88195#issuecomment-634175038 and it seems that these packages were already broken. Let's run once more for 3.1.3, the builds that shouldn't fail:
@GrahamcOfBorg build acme-client
@GrahamcOfBorg build libressl
@GrahamcOfBorg build libressl_3_1
@GrahamcOfBorg build linux-steam-integration
@GrahamcOfBorg build mydumper
@GrahamcOfBorg build netcat
@GrahamcOfBorg build openntpd
@GrahamcOfBorg build openntpd_nixos
@GrahamcOfBorg build opensmtpd
@GrahamcOfBorg build ponyc
@GrahamcOfBorg build pony-stable
@GrahamcOfBorg build pounce
@GrahamcOfBorg build s6-networking
@GrahamcOfBorg build skawarePackages.s6-networking
@GrahamcOfBorg build tests.nixos-functions.nixos-test
@GrahamcOfBorg build tests.nixos-functions.nixosTest-test
@GrahamcOfBorg build twa

Looks like all the builds that are expected to pass still do, please take another look @Lassulus.


Update static analyzers to reflect namespace change

Static analyzers should remove Azure.ApplicationModel as a valid namespace.
While we're in there, should add Azure.Ai as a namespace.
Also: update Azure.Core.All.sln

I'll reopen this issue untill analyzer package version is updated in the main repo.


Product Setup for sequence

Hello, I've noticed that "seaweedfs/weed/sequence/" has memory_sequencer.go and etcd_sequencer.go, and memory_sequencer.go has say it's only for test?
But I've not found any document for use etcd as sequence storage? So how to use it?
If we only use a simple architect with volume/master, no filer, does we still need etcd, or a simple snowflow like fid is enough?
Actually we are use a old version 1.43 and got a strange bug. version 1.43 don't have etcd_sequencer.go so memory_sequencer is use in production.
After 2 years stable in production, in yesterday, clients had got same fid just with different cookie from master's /dir/assign api, not every time but very likely, as the fid is very small, 000, 02b or sometimes very big, 0xfffffffff .
So it's should be some volume server send a wrong fid and made master's fid overflow and start from 0.
But in last code, it seems master still use heartbeat from volume?
master_grpc_server.go: 64
ms.Topo.Sequence.SetMax(heartbeat.MaxFileKey)
and etcd_sequencer.go: 110
instead of collecting the max value from volume server,
the max value should be saved in local config file and ETCD cluster
I'm confused.
We had to make a hot fix on 1.43 version, use a timestamp prefix sequence to solve this before found the wrong volume.
And we also consider upgrade to last version, but where can we find a solid config for production? I don't think just one volume server error should made the whole system wrong.

do you have multiple masters?

do you have multiple masters?

Yes, 3 master run as cluster. but the seq/fid is reset to 0 even without master restart or leader re-elected.

I guess one of the master is not connected to the other 2 masters.

I guess one of the master is not connected to the other 2 masters.

No, /cluster/status is OK on all masters.
We have found some volume has very big MaxFileKey like<PHONE_NUMBER>3700427373.
Can weed shell's volume fix command fix them?

@chrislusf I've noticed that weed scaffold -config master generates master.sequencer as type raft now and not memory as before. How does this affects when loading the old master.toml with type memory?

We have found some volume has very big MaxFileKey like<PHONE_NUMBER>3700427373.
Can weed shell's volume fix command fix them?

Hard to fix it unless have some special code to skip these large MaxFileKey when weed fix.

@chrislusf I've noticed that weed scaffold -config master generates master.sequencer as type raft now and not memory as before. How does this affects when loading the old master.toml with type memory?

raft is the same as memory

We have found some volume has very big MaxFileKey like<PHONE_NUMBER>3700427373.
Can weed shell's volume fix command fix them?

Hard to fix it unless have some special code to skip these large MaxFileKey when weed fix.

So a snowflake solution would be more robust than use maxFileKey from volume server?

So a snowflake solution would be more robust than use maxFileKey from volume server?

yes, but harder to compress in memory.

We can experiment with snowflake file key generation.
@bash99  Do you want to send a PR?

We can experiment with snowflake file key generation.
@bash99 Do you want to send a PR?

I'll make a try, now it's a dirty solution.
I'm a noob in golang.
BTW, where is those code related to compress in memory?

BTW, where is those code related to compress in memory?

https://github.com/chrislusf/seaweedfs/blob/master/weed/storage/needle_map/compact_map.go

We can experiment with snowflake file key generation.
@bash99 Do you want to send a PR?

https://github.com/chrislusf/seaweedfs/pull/1945, any comments is welcome

do you have multiple masters?

Yes, 3 master run as cluster. but the seq/fid is reset to 0 even without master restart or leader re-elected.

may be enough to enable the parameter resumeState=true ? starting from versions 2.03
https://github.com/chrislusf/seaweedfs/pull/1505/files

do you have multiple masters?

Yes, 3 master run as cluster. but the seq/fid is reset to 0 even without master restart or leader re-elected.

@bash99
may be enough to enable the parameter resumeState=true ? starting from versions 2.03
#1503

But resumeState will still accept maxkey from volume server?
Our problem is some volume server going crazy (maybe memory or disk error) and send a 0xfffffffffffffffe maxkey to master, while master accept it, so sequence overflowed to 0.

BTW, where is those code related to compress in memory?

https://github.com/chrislusf/seaweedfs/blob/master/weed/storage/needle_map/compact_map.go

As far as I can understand, it's use delta to compress, batch size 10000. In those 10000 fids, if max(fid) - min(fid) < 2^32, we can have a good compress chance?
I'm thinking about use some twisted snowflake algorithm, for example
+---------------------------------------------------------------------------+
| 16 Bit NodeID  | 32 Bit Epoch Secs | 16 Bit Sequence ID |
+---------------------------------------------------------------------------+

instead of current default
+--------------------------------------------------------------------------+
| 1 Bit Unused | 41 Bit Timestamp |  10 Bit NodeID  |   12 Bit Sequence ID |
+--------------------------------------------------------------------------+

The new approach can support 65536 id per seconds, and if all 10000 id is generate in 65536 seconds (18.2 hours), it's will be in a 2^32 range.
But it'll lost time-ordered feature of snowflake if master leader changed.

we can use the default snowflake implementation. Just need to use -index=leveldb when starting weed volume

we can use the default snowflake implementation. Just need to use -index=leveldb when starting weed volume

oh, what's will happens if we mix leveldb-index and memory-index volume?
I think if it's a fresh volume-server, it's should be fine with old volume run in memory mode.
But if some old volume is memory-index, can we restart volume server with -index=leveldb options?

But if some old volume is memory-index, can we restart volume server with -index=leveldb options?

yes.


Azure DNS DDoS Protection Info

Hi folks,
The page does not mention anything about DDoS Protection for Azure DNS - can this information be added please?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f38b1bd-2ab0-71f1-a6e9-925b7af3389d
Version Independent ID: 9528f5cf-16e1-0550-dc3e-edc135c82167
Content: Azure DDoS Protection Standard Overview
Content Source: articles/virtual-network/ddos-protection-overview.md
Service: virtual-network
GitHub Login: @KumudD
Microsoft Alias: kumud

@iizotov , Azure DDOS is a service which is used to protect resources which has a public IP and deployed in a VNET.
Azure DDOS Standard is not used for Azure DNS. Azure DNS is a global service and it is protected by the Infrastructure itself.
Let me know if you have any further questions.

Understand that. To rephrase my original question, are there any mechanisms in place that would give Azure customers using Azure DNS peace of mind that said service is resillient to DDoS attacks? If so, this should be reflected in the documentation.
Thanks!

@iizotov ,
“DDoS Protection Basic helps protect all Azure services, including PaaS services like Azure DNS.”
https://docs.microsoft.com/en-us/azure/security/fundamentals/ddos-best-practices#azure-offerings-for-ddos-protection

ack, thanks for the link.


V3 support

Hey there,
Serverless just announced Serverless V3, and it seems there aren't any major breaking changes for plugins.
This looks like the new documentation: https://www.serverless.com/framework/docs/guides/plugins/creating-plugins

Hi - does anyone know if Serverless v3 is compatible with this plugin? The OP says v3 has no breaking changes, but this issue is labeled with enhancement.

Hi - does anyone know if Serverless v3 is compatible with this plugin? The OP says v3 has no breaking changes, but this issue is labeled with enhancement.

Might be good to go, haven't had the chance to try it. Let us know 😄

Just gave it a quick spin on a repo or two and it should be compatible @arackaf. Let me know otherwise.

@samchungy hey cool - will do. Sorry, wasn't trying to be lazy - I saw this issue was open, and had the enhancement label, so I thought maybe there was a known incompatibility.
Will give it a go hopefully soon.


View Mirror

Hi!
I need my avatar to show in front of the mirror, how can I do that?
Thankyou!
Link: https://github.com/m9cd0n9ld/IMU-VR-Full-Body-Tracker/blob/main/media/preview_feet.gif

You can try LIV.

Thank you very much, you answer fast too!


Keyword classifier

This reopens PR 1741 which I accidentally closed and adds the modifications that were still required.
@FabianReich Sorry for moving this to another PR, I messed up while trying to add to your original PR.
Proposed changes:

Adding a custom keyword intent classifier
fixes #1740

Status (please check what you already did):

[x] made PR ready for code review
[x] updated the changelog

It seems like the old KeywordClassifier was a fallback classifier which is why these tests fail, they expect intent greet to be returned. How should we adapt this @akelad?

@imLew @FabianReich was just taking a look at this PR, just so i understand correctly, this would work by providing an nlu markdown file with just keywords listed for each intent? so e.g.:
## intent:greet
- hi
- hello

## intent:bye
- bye
- goodbye

@imLew @FabianReich was just taking a look at this PR, just so i understand correctly, this would work by providing an nlu markdown file with just keywords listed for each intent? so e.g.:
## intent:greet
- hi
- hello

## intent:bye
- bye
- goodbye

This is currently correct.
I want to change it to a property of the intent to make it easier to use this with other classifiers.

Also, what happens if people enter full sentences? do we match against the whole sentence then?
Yes, the whole sentence would match (as long as it is surrounded by word-boundaries). Keywords are found in messages by re.search(r"\b" + word.lower() + r"\b", _text), so ignoring case but matching the string exactly.

I don't want we should ignore the case, see https://github.com/RasaHQ/rasa/issues/3827 case should be handled by whitespace tokenizer

@Ghostvv because the matching is not symmetric it is not always necessary to take out both examples. If a matches b and b matches a then a==b, so I added another check for that special case to remove both, and otherwise only remove a.

This was held up because the tests kept failing. They should pass once https://github.com/RasaHQ/rasa/pull/4360 is properly resolved.

@imLew what needs to happen to move this forward?

@tmbo it should be unblocked if the changes from PR #4511 are in master.
I'll have a look at it now (need to resolve the conflicts first)

@Ghostvv I think all the changes you requested were addressed, but this was blocked at the time. Can you please check if you still think it's ok?


Alertmanager configuration pages in docs returns "Not Found"

What did you do?
Check alertmanager configuration page
What did you expect to see?
The page
What did you see instead? Under which circumstances?
Page Not Found
https://prometheus.io/docs/alerting/configuration/

It seems there was a blip in our docs build. It should be available again.

@grobie  Not yet, please help investigate

@LillyWu What's the output of curl -v https://prometheus.io/docs/alerting/configuration/ >/dev/null.

@grobie Can confirm still 404ing for me. I think its some CDN sync issue with some regions or something.
➜  ~ curl -v https://prometheus.io/docs/alerting/configuration/ >/dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
*   Trying 2400:cb00:2048:1::6818:783c...
* TCP_NODELAY set
* Immediate connect fail for 2400:cb00:2048:1::6818:783c: Network is unreachable
*   Trying 2400:cb00:2048:1::6818:793c...
* TCP_NODELAY set
* Immediate connect fail for 2400:cb00:2048:1::6818:793c: Network is unreachable
* Connected to prometheus.io (<IP_ADDRESS>) port 443 (#0)
* Initializing NSS with certpath: sql:/etc/pki/nssdb
*   CAfile: none
  CApath: none
* loaded libnssckbi.so
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0* ALPN, server accepted to use h2
* SSL connection using TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
* Server certificate:
* 	subject: CN=sni194015.cloudflaressl.com,OU=PositiveSSL Multi-Domain,OU=Domain Control Validated
* 	start date: Nov 05 00:00:00 2017 GMT
* 	expire date: May 14 23:59:59 2018 GMT
* 	common name: sni194015.cloudflaressl.com
* 	issuer: CN=COMODO ECC Domain Validation Secure Server CA 2,O=COMODO CA Limited,L=Salford,ST=Greater Manchester,C=GB
* Using HTTP2, server supports multi-use
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* Using Stream ID: 1 (easy handle 0x55b7b1a16010)
> GET /docs/alerting/configuration/ HTTP/2
> Host: prometheus.io
> User-Agent: curl/7.53.1
> Accept: */*
>
* Connection state changed (MAX_CONCURRENT_STREAMS updated)!
< HTTP/2 404
< date: Thu, 16 Nov 2017 11:01:19 GMT
< content-type: text/html; charset=utf-8
< set-cookie: __cfduid=d0ebd8222562f3c851c332d177632357c1510830078; expires=Fri, 16-Nov-18 11:01:18 GMT; path=/; domain=.prometheus.io; HttpOnly
< cache-control: public, max-age=0, must-revalidate
< age: 2328
< vary: Accept-Encoding
< strict-transport-security: max-age=2592000; preload
< x-content-type-options: nosniff
< server: cloudflare-nginx
< cf-ray: 3be9f3993fa21389-LHR
<
{ [1084 bytes data]
100  1866    0  1866    0     0   1032      0 --:--:--  0:00:01 --:--:--  1033
* Connection #0 to host prometheus.io left intact


Incorrect canvas size

Please follow the general troubleshooting steps first:

[x] You are using the latest version
[x] You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console

Bug reports:
The canvas that gets outputted from the html2canvas method is exactly twice as large in size. I've tried giving the actual width and height of the element as options but this gives me the same result.
Specifications:

html2canvas version tested with: 1.0.0-rc.3
Browser & version: latest non-beta releases of Chrome and Safari
Operating system: macOs Mojave 10.14.5

If you're on a macbook with a retina screen, the scale will be set to 2, as explained in https://html2canvas.hertzen.com/configuration.

This was indeed the issue. Solved it just before going on vacation and I just got back so my apologies for the late answer.
Fixed it by using:
 html2canvas([the element], {
        scale: 1
      })

Still, thank you for the answer!


Add JS Palindrome Func

What the program do ?

In what programming language it is written?

Create a simple Javascript function to check if a word is a palindrome

resolve your conflict


Runtime problems after updating from v0.18.2 to v0.19.0

If you're still using .NET 4.6.1 don't upgrade to SharpCompress version 0.19.0 as it seems to be using System.Buffers which depends on .NET Standard 2.0 libraries (System.Net.Http <IP_ADDRESS> and System.ValueTuple <IP_ADDRESS>) causing a mismatch between the version of .dlls as .NET 4.6.1 is still using System.Net.Http <IP_ADDRESS> and System.ValueTuple 4.4.0 (from NuGet).
So I think the backward compatibility of SharpCompress is broken for anyone who doesn't use .Net Standard yet...

Version 0.19.0 broke my Xamarin app completely. The problem is that System.Buffers.dll is not available on Mono and Xamarin.Android/iOS. This version is completely useless and no longer cross platform.

System.Buffers should only be referenced in a .net framework and .net core specific dll. The .net standard version can't reference it.

.NET 4.6.1 should be using the .NET Standard 2.0...I'm not sure about the issue there.
As for Mono/Xamarin...I guess it's using the .NET 4.5 version instead of the .NET Standard 1.0 version?

Cross targetting is a nightmare.  I should just absorb the arraypool classes in or remove the pooling.

No it's using the .net standard version, but that version depends on System.Buffers which is not cross platform.

https://www.nuget.org/packages/sharpcompress/0.19.1


Move to yarn?

@stefcameron how do you feel about moving this project to using yarn?

@maraisr I'm a fan of yarn! I've come to really like it over the past year. I'd support that.


feat(backup): support mutating backup config

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR makes system params backup_storage_url and backup_storage_directory mutable.
These 2 params are used by both meta node and compute node. They are updated in a similar way:

watch system params changes.
recreate underlying storage that stores meta snapshot, if any of the 2 params has been changed.

Checklist For Contributors

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[x] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

Will there be any problem if different CNs receive this update at different time?

No.
This new config only affects ad-hoc query. If two CNs use old and new backup store respectively, it falls into either of the 2 cases:

The target backup identified by backup id can be found in both stores. We assume two backups are the same, if their backup id are same.
The target backup can be found in only one store. The corresponding ad-hoc query will fail as expected.


Unrecognized JSON request

Using one of the examples with my own information:
import sys

from matrix_client.client import MatrixClient
from matrix_client.api import MatrixRequestError
from requests.exceptions import MissingSchema

host = "https://matrix.org/_matrix/client/r0/login"
username = "{USERNAME}"
password = "{PASSWORD}"

client = MatrixClient(host)

try:
    client.login_with_password(username, password)
except MatrixRequestError as e:
    print(e)
    if e.code == 403:
        print("Bad username or password.")
        sys.exit(4)
    else:
        print("Check your server details are correct.")
        sys.exit(2)
except MissingSchema as e:
    print("Bad URL format.")
    print(e)
    sys.exit(3)

if len(sys.argv) > 4:
    userid = sys.argv[4]
else:
    userid = userid = None

try:
    user = client.get_user(userid)
    print("Display Name: %s" % user.get_display_name())
    print("Avatar %s" % user.get_avatar_url())
except MatrixRequestError as e:
    print(e)
    if e.code == 400:
        print("User ID/Alias in the wrong format")
        sys.exit(11)
    else:
        print("Couldn't find room.")
sys.exit(12)

I get the following error:
400: {"errcode":"M_UNRECOGNIZED","error":"Unrecognized request"}
Check your server details are correct.

The server details are definitely correct, because I can use curl with the same information and get a response from the server, like so:
 deadvcr@lambda-core:~$ curl -XPOST -d '{"type":"m.login.password", "user":"{username}", "password":"{password}"}' "https://matrix.org/_matrix/client/r0/login"
{
    "access_token": "{access token}",
    "device_id": "{device id}",
    "home_server": "matrix.org",
    "user_id": "@{username}:matrix.org"
}

Hi. host should be just the hostname, not the full path you're trying to call; i.e. host = "https://matrix.org" instead of host = "https://matrix.org/_matrix/client/r0/login". Is there a documentation error somewhere that led you to use the full path instead of just the hostname?
I'm closing this as I don't think it's a bug with the sdk. Let me know if there's another issue here, and I can reopen.


Issues with @Transactional annotation behavior in more than one template

**In which version(s) of Spring for Apache Kafka does this problem occur?
For example:
Between 2.8.4 and 3.0.5
Describe the bug
I have 2 producers with different values.
They both set the transactionIdPrefix and the
When using the @Transactional annotation, the following error occurs.

No transaction is in process; possible solutions: run the template operation within the scope of a template.executeInTransaction() operation, start a transaction with @Transactional before invoking the template method, run in a transaction started by a listener container when consuming a record

As the error explains, I could use executeInTransaction, but is there any way to use the annotation?
Reproduce
Steps to reproduce the behavior.
Expected Behavior
I want the Kafka transaction to commit first, then the database transaction.
(I get the same error when it's the other way around).
Example
https://github.com/kdhyo/kafka-example

The relevant SO thread: https://stackoverflow.com/questions/75956142/error-when-declaring-more-than-one-kafkatransactionmanager.
It is not clear how to run your sample and reproduce.
Also would be great to see the whole stack trace.
You can turn on TRACE logging level for the org.springframework.transaction.interceptor to see how your transactions are handled.
Only guess I see that you many try to make your UpdatedMemberProducer and CreatedMemberProducer as a @Service instead of @Configuration: I'm not sure that framework can see those @Transactional on methods in the @Configuration classes...

Your example is much too complicated for us to run, strip it down to the bare minimum:
https://stackoverflow.com/help/minimal-reproducible-example
This works fine for me...
@SpringBootApplication
public class Kgh2655Application {

	public static void main(String[] args) {
		SpringApplication.run(Kgh2655Application.class, args);
	}

	@Bean
	ProducerFactory<String, String> pf1(KafkaProperties props) {
		Map<String, Object> pProps = props.buildProducerProperties();
		pProps.put(ProducerConfig.TRANSACTIONAL_ID_CONFIG, "tx1-");
		return new DefaultKafkaProducerFactory<>(pProps);
	}

	@Bean
	ProducerFactory<String, String> pf2(KafkaProperties props) {
		Map<String, Object> pProps = props.buildProducerProperties();
		pProps.put(ProducerConfig.TRANSACTIONAL_ID_CONFIG, "tx2-");
		return new DefaultKafkaProducerFactory<>(pProps);
	}

	@Bean
	KafkaTemplate<String, String> template1(ProducerFactory<String, String> pf1) {
		return new KafkaTemplate<>(pf1);
	}

	@Bean
	KafkaTemplate<String, String> template2(ProducerFactory<String, String> pf2) {
		return new KafkaTemplate<>(pf2);
	}

	@Bean
	KafkaTransactionManager<String, String> tm1(ProducerFactory<String, String> pf1) {
		return new KafkaTransactionManager<>(pf1);
	}

	@Bean
	KafkaTransactionManager<String, String> tm2(ProducerFactory<String, String> pf2) {
		return new KafkaTransactionManager<>(pf2);
	}

	@Bean
	ApplicationRunner runner(KafkaTemplate<String, String> template1, KafkaTemplate<String, String> template2,
			Foo foo) {

		return args -> {
			foo.one(template1);
			foo.two(template2);
			foo.one(template1);
			foo.two(template2);
		};
	}

	@Bean
	NewTopic topic() {
		return TopicBuilder.name("topic").partitions(1).replicas(1).build();
	}

	@KafkaListener(id = "kgh2655", topics = "topic")
	void listen(String in, @Header(KafkaHeaders.OFFSET) long off) {
		System.out.println(in + "-@" + off);
	}

}

@Component
class Foo {

	@Transactional(transactionManager = "tm1")
	void one(KafkaTemplate<String, String> template) {
		template.send("topic", "foo");
	}

	@Transactional(transactionManager = "tm2")
	void two(KafkaTemplate<String, String> template) {
		template.send("topic", "foo");
	}

}

spring.kafka.consumer.auto-offset-reset=earliest
spring.kafka.consumer.isolation-level=read-committed

[Producer clientId=producer-tx2-0, transactionalId=tx2-0] Instantiated a transactional producer.
[Producer clientId=producer-tx1-0, transactionalId=tx1-0] Instantiated a transactional producer.
foo-@28
foo-@30
foo-@32
foo-@34

Oh, I apologize for the difficulty of the example.
However, I looked at your code and found the cause.
I registered the ProducerFactory as a bean and used it, and that solved it.
I think I didn't find it because I created it in transaction manager and template respectively.
Thanks for the kind example.


lxd/devices/nic: Handle recent ebtables

Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

Testsuite passed


syntax improvements for scons, sh

The first commit lets vim detect scons files as python,
the second one lets vim re-detect the shell subtype when the shebang in a shell
script is changed. For the last one, I tried to contact the maintainer for
runtime/syntax/sh.vim, but the mail address did not exist anymore.

I'll include the filetype change.  The shell syntax change is for @cecamp

I'll include the filetype change. The shell syntax change is for @cecamp

Hmm, they were last active on GitHub more than 3 years ago, let's see if there will be an answer…

I've been on here a lot more recently than three years ago.  Anyway, looks like a good change, so I'll include it.  Thanks!

closing then.

@cecamp the sh syntax changes don't seem to have made it upstream yet, and I'm also not sure how the workflow is here…


Package request: xfce4-docklike-plugin

Project description
A modern, minimalist taskbar for Xfce.
Docklike Taskbar behaves similarly to many other desktop environments and operating systems. Wherein all application windows are grouped together as an icon and can be pinned to act as a launcher when the application is not running. Commonly referred to as a dock.
Metadata

homepage URL: https://docs.xfce.org/panel-plugins/xfce4-docklike-plugin/start
source URL: https://gitlab.xfce.org/panel-plugins/xfce4-docklike-plugin/
license: gpl3
platforms: linux

Hi @martind2000, I submitted xfce4-docklike-plugin for review. Feel free to provide feedback.


Can no longer pre-fill ion-select using formControlName after upgrading to Ionic V3.1

Ionic version:  (check one with "x")
[ ] 1.x
[ ] 2.x
[X] 3.x
I'm submitting a ...  (check one with "x")
[X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
I have a form on a view, and when the page loads I pre-fill out the form using a formBuilder.group in the constructor. My ion-datetime works as expected, but the ion-select does not. All of my ion-select appear empty until I select a value manually - defeating the point of pre-filling out a form.

Expected behavior:
When the page loads, the form should be pre-filled out as it is an edit item view.

Steps to reproduce:
http://plnkr.co/edit/TkhUmbGTWHHwgq0N97mz?p=preview
Other information:
If you visit the plnkr below, the error is visible. If you go into systemjs.config.ts and switch ionic-angular to 3.0.0 the issue disappears.

same issue here,

This is probably the same issue.

I am having the exact same issue. Posted a very simple example on stack overflow
http://stackoverflow.com/questions/43681160/ion-select-not-showing-selected-option-with-formbuilder-ionic-3

Hey, everyone! Hope to have a nightly release here soon that I would love for you guys to give a try. It should fix these breaking changes.

Hello all! Can you all install nightly (npm install --save-dev ionic-angular@nightly) and see if this issue still persists? Thanks!

@jgw96 I think you mean  --save rather than --save-dev...
But yes, I think it fixes my issue.

3.1.0-201704281534 fixes the problem described in this issue for me.

Hello all! This has been fixed and is in the 3.1.1 release

Thanks @jgw96 for getting a fix out so fast! Can confirm this fixes the issue for me.

Hello, still getting the same issue, please help !

@ ionic/app-scripts : 3.0.1
Cordova Platforms  : android 6.2.3 ios 4.4.0
Ionic Framework    : ionic-angular 3.8.0


location name limit in sidebar menu

@ariandora Does this fix an issue?

@simonmorley it's in jira, not in github

Can you summarise the issue so we know what it's fixes. Better still. Put
the issue in git.
On 4 Oct 2016, at 10:50, ariandora<EMAIL_ADDRESS>wrote:
@simonmorley https://github.com/simonmorley it's in jira, not in github
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cucumber-tony/cucumber-frontend/pull/339#issuecomment-251411159,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAS4WJuHstOoN2QHnImD_q_jVjgOiGPMks5qwmfDgaJpZM4KMr98
.

Created the bug -#342, closing this pull req, will change the behaviour to what we discussed


Incorrect origin metrics in routing object mode

Origin metric paths are incorrectly constructed when YamlFileConfigurationService is used to configure styx from origins file.
The APP.ORIGIN hierarchy repeats twice, resulting names like these:
origins.APP.ORIGIN.APP.ORIGIN.connectionspool.available-connections
The correct metric path should be:
origins.APP.ORIGIN.connectionspool.available-connections

This is resolved.


Max ops error message not passed on since last revision

The error message when reaching max ops is not passed on anymore.
With rev 2.8.1:
line #1: Exception at '<% + %> =>FOR<=' in section [TOP]
With rev 2.7.5
line #1: Exception at '<% + %> =>FOR<=' in section [TOP] (Exception in section '[TOP]' (Operation count (1001) exceeded maximum of 1000))

Already fixed by #982.


bug fix in ApplyAdadelta update rule

Following the Zeiler ADADELTA paper, numerator of update equation
should be RMS(accum_update) * grad

Can one of the admins verify this patch?

@vrv had requested that I also merge a fix to the test. I looked in training_ops_test.cc and did not find any testing for adadelta. I also checked adadelta_test.py, which has the correct rule in place. I do not know where else I should look for the bug.

Correct me if I'm wrong, but you're saying that adadelta_test has the right equation, but that this test was passing before your change, and still passes after your change?

Correct, the file adadelta_test.py passes before and after the fix.

doesn't that mean that the existing test is not really sufficient?  Can we modify the test so it would have failed before your fix?

Probably - I suspect that decreasing the tolerance in the asserts (from 1e-3 to a smaller number) would cause the test to fail, although I don't know if there is a testing convention in place for tolerance. Is there a reason 1e-3 was chosen in the first place, or is that a default value? These tests use numerical approximations, right? So at some point a low enough tolerance will always cause a failure.

There's no really good default, since every test has a different number of operations being performed.  Ideally we would test based off of expected number of ULP differences for every test, but that's somewhat impractical.
If you can find a setting that passes with your change and fails before it, that would be awesome.

I'll look into it and get back to you.

Ok, I added additional test variable options (learning rates, gradients, number of ADADELTA steps) in order to find a use case where the previously broken code fails and the newly patch code passes.

Thanks for this!  mostly just lint / style issues, otherwise this looks great.

Ok, I fixed the linting/style errors. Should I squash the commits or can you do that in the merge?

We can squash now when we merge :)
@tensorflow-jenkins test this please

Thanks!

Thanks for your help @vrv


chore(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1816

Questions ?
Please refer to the Backport tool documentation


Update translations

Coverage increased (+0.001%) to 88.833% when pulling 182685a2cd0ccaf19373f20413bed5b39b51016e on mkoistinen:feature/update_translations into 054bcd53b5f6401fa74635bbe0455212c16dc53e on divio:develop.


improving help pages infrastructure

https://github.com/aurelia-ui-toolkits/skeleton-bridge/issues/15

Each category should support more than 1 level of nesting - the actual depth should be no more than 3, based on the needed experimentation to determine what is the minimum page width that would still not squish the indentation and text

Tricky.. That will be interesting. :smile:

Just to be on the same boat:
How would a registry.json entry look like with sub categories?
{
    "About this application":
    [
      {
        "1. Introduction":
        [
          {
            "name": "1.1. Sub-Introduction",
            "path": "help/docs/somewhere"
          }
        ]
      },
      {
        "name": "2. Navigation guide",
        "path": "help/docs/about-this-application/navigation.md"
      }
    ]
}

or
{
    "About this application":
    [
      {
        "name": "1. Introduction",
        "children": [
          {
            "name": "1.1. Sub-Introduction",
            "path": "help/docs/somewhere"
          }
        ]
      },
      {
        "name": "2. Navigation guide",
        "path": "help/docs/about-this-application/navigation.md"
      }
    ]
}


Configure SyncPeriod

Summary
Reconciliations normally occur through:

a change to a Watched resource in the informer cache
a call we made to RequeueAfter to queue after some period of time

In addition, it will still be good to have a fail safe to ensure we reconcile every resource at some minimum regularity. This article how to configure that. Note the default is 10 hours, and I believe we should make it more frequent than that. At this point, I would say once every 15 minutes.

Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

I have attempted this but I'm not sure why it's not working

After doing some debugging and research, I landed on this issue from controller-runtime which is exactly our problem is, as per mentioned in the issue I have tried removing the predicate filter and set SyncPeriod to 2min and it worked as expected, I see in numaplane log which is reconciling every 2min.


test/recipes/02-test_errstr.t: Do not test negative system error codes

It's been deemed unlikely that these will end up in OpenSSL error
records, so we simply don't test them if they happen to be among the
error codes that perl has support for.
Fixes #14763

There was a comment change, can I assume that current approvals stand?

There was a comment change, can I assume that current approvals stand?

yes

Yes.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged
41385f2708d08155d56ce08dce494152e225069e test/recipes/02-test_errstr.t: Do not test negative system error codes


TOMEE-2560-Translate to Portuguese the async-methods example.

Link to Jira : https://issues.apache.org/jira/browse/TOMEE-2560

thanks @davidsalter : )

I'm happy to get this merged in, but if we have any Portuguese speakers (@alexferreiradev maybe?) who can give a quick review, that would be great.


Remove PCLN internal URLs from package-lock.json

Codecov Report

Merging #564 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #564   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          55     55
  Lines         570    570
=====================================
  Hits          570    570

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a681af...8337156. Read the comment docs.

Resolved in #568


Update to react 16

Any noticeable changes with React 16? I guess nothing broke in the bindings, right?

the website says if 15.x works then 16 should work as well


Implement basic TUI with FTXUI

OUTDATED, PLEASE READ COMMENTS BELOW FOR MORE INFO
Now that I'm using a TUI library, I should implement some basic TUI first.
The requirements:

A bigger (80%-ish) window that would output all the text responses from the game.
A smaller (10-20%-ish) window that features an input prompt, this is where the user inputs commands/actions for the game to process/react to.
Test the ability to change the color of the window borders themselves and the text that the game outputs.
Figure out if it's possible to create a completely new window for the game (try using SDL2 as the renderer).

Decisions on UI in BTAGSIL
After a few days of experimentation with FTXUI, I've decided to:

Remove FTXUI from BTAGSIL;
Move Creating a UI into the Ideas Milestone;
Postpone the idea of Creating a UI for BTAGSIL until at least 0.3.0;
Prioritize getting a relatively stable and content-filled prototype ready first before deciding on implementing any kind of UI;
Think about creating a mini-framework for several possible entry points that each use a different UI. One may use console, the other might use a TUI, the third might use a GUI. Even if there's currently one "UI" (that is, just console I/O), there still has to be a skeleton for just adding more entry points in the future and for it all to just work. This should probably be a separate issue.


Spike: Determine the Libraries

Document why we make these decisions (especially over other libraries)

Expo vs React native CLI

Consider CI system

Redux vs Context
Typescript vs JS
Persistence?
MaterialUI vs ?
Class based vs Functional (hooks)
Unit testing

Enzyme
React Test Library

Lint and Prettier, bootstrap off of Airbnb
Network

Axios

Node version
NPM vs Yarn

Node version
NPM vs Yarn

My notes:

Node version

Any LTS (Long Term Support) version. https://nodejs.org/en/about/releases/

NPM vs Yarn

Originally Yarn was better than npm, but now they are very similar. Yarn still has better performance, albeit miniscule in the grand scheme of things.

Expo vs React-Native CLI

In short: Expo is fast and easy install + setup, but larger app size with limitations, RNCLI takes a lot longer to install + setup with errors that are hard to debug, but has a smaller app size.
Expo is better for smaller projects that don’t require too many dependencies, RNCLI is better for everything else.

Redux vs Context

Redux has a lot of boilerplate, but very powerful. Context is built into React and simple to setup, but isn’t the best when it comes to a large application that needs to share a lot of data throughout the app.

TypeScript vs JavaScript

TypeScript has a larger learning curve than JS, but it provides compile-time type-checking that helps prevent silly bugs while also helping the debugging process.

Class-based vs Functional Components

Functional components can now do everything class-based components can with less code using hooks. Modern React relies exclusively on functional components.

Unit Testing

Enzyme is great, but react-testing-library provides a testing framework that is more human-centric.

@mmislam101 needs to take this and document it in the wiki


Suggestion to use TypeDescriptor

Hello ... I suggest using TypeDescriptor  class to read DataTables attributes instead of using normal reflection because TypeDescriptor  gives the advantage of reading dynamically injected attributes.
Why would dynamically injected DataTables be useful? I had a case where I want to use the models classes directly (no need to transform them into view classes) but those classes where already built inside a dll lib so I couldn't specify the DataTables attributes.
By using TypeDesciptor I could've inject the required attributes instead of writing new classes and transformation methods.

It sounds like it might be a lot of work for an edge case, and I don't know enough about using TypeDescriptor to know the pros/cons. Could you show me an example of the code change?

It does not require a lot of work ... I rewrote the code in the DataTablesInfo.cs file as follows:
internal static class DataTablesTypeInfo
{
internal static DataTablesPropertyInfo[] Properties(Type type)
{
        var typeDescriptor = TypeDescriptor.GetProvider(type).GetTypeDescriptor(type);
        if (typeDescriptor == null) return new DataTablesPropertyInfo[0];

        var infos = (from PropertyDescriptor pi in typeDescriptor.GetProperties()
                     let attributes = pi.Attributes.Cast<Attribute>().OfType<DataTablesAttributeBase>().ToArray()
                     orderby attributes.OfType<DataTablesAttribute>().Select(a => a.Order as int?).SingleOrDefault() ?? int.MaxValue
                     select new DataTablesPropertyInfo(pi, attributes)).ToArray();

        return infos;
    }
}
static class DataTablesTypeInfo<T>
{
    internal static DataTablesPropertyInfo[] Properties { get { return DataTablesTypeInfo.Properties(typeof(T)); } }

    public static Dictionary<string, object> ToDictionary(T row)
    {
        var dictionary = new Dictionary<string, object>();
        foreach (var pi in Properties)
        {
            dictionary[pi.PropertyInfo.Name] = pi.PropertyInfo.GetValue(row);
        }
        return dictionary;
    }

    public static OrderedDictionary ToOrderedDictionary(T row)
    {
        var dictionary = new OrderedDictionary();
        foreach (var pi in Properties)
        {
            dictionary[pi.PropertyInfo.Name] = pi.PropertyInfo.GetValue(row);
        }
        return dictionary;
    }

}

Changes are:

No need to cache properties loaded for types (since TypeDescriptor internally cache them
Replace PropertyInfo class with PropertyDescriptor (with some refactoring)

I have done those changes and it's working just fine :)
Thank you very much

If you submit a PR I'll give it a go.

Closing due to tumbleweed


[BUG] BatchBlobClient does not delete blob versions

Describe the bug
Using BatchBlobClient to delete blob versions does not work.
Exception or Stack Trace
The error returned is:
BlobNotFoundThe specified blob does not exist.RequestId:39c8943f-901e-0055-528c-f9f1e61e89d2Time:2022-11-16T07:26:12.9477150Z
To Reproduce
See code snippet below. The code uploads a blob and then deletes it. This operations deletes blob's current version however the version that was created by upload operations remains on cloud. It then submits a batch operation to delete the blob version that was created by upload operation. The batch operation fails. Before executing the code it is expected that you fill in the following information in the code:

accountName: name of the existing storage account with enabled blob versioning
accountKey: secret key to access the above mentioned storage account
containerName: name of the existing container created in the storage account mentioned above

Code Snippet
String accountName = "";
String accountKey = "";
String containerName = "";.
StorageSharedKeyCredential storageSharedKeyCredential = new StorageSharedKeyCredential(accountName, accountKey);

String endPoint = String.format("https://%s.blob.core.windows.net", accountName);

BlobServiceClient serviceClient = new BlobServiceClientBuilder()
    .endpoint(endPoint)
    .credential(storageSharedKeyCredential)
    .buildClient();

BlobContainerClient containerClient = serviceClient.getBlobContainerClient(containerName);
BlockBlobClient blobClient = containerClient.getBlobClient("batchdel").getBlockBlobClient();
String content = "123456";
BlockBlobItem uploadedBlob = blobClient.upload(new ByteArrayInputStream(content.getBytes()), content.length());
System.out.printf(">>>> uploaded blob version: %s%n", uploadedBlob.getVersionId());

String url = containerClient.getBlobVersionClient(blobClient.getBlobName(), uploadedBlob.getVersionId()).getBlobUrl();
System.out.printf(">>>> url for batch delete: %s%n", url);

// delete the blob so it no longer has current version
blobClient.delete();

List<String> blobUrls = new LinkedList<>();
blobUrls.add(url);

BlobBatchClient blobBatchClient = new BlobBatchClientBuilder(c).buildClient();

try {
    PagedIterable<Response<Void>> responseList = blobBatchClient.deleteBlobs(blobUrls, DeleteSnapshotsOptionType.INCLUDE);
    for (Response<Void> response : responseList) {
        if (response.getStatusCode() >= 200 && response.getStatusCode() < 300) {
            blobUrls.remove(response.getRequest().getUrl().toString());
        }
        else {
            System.err.printf(">>>> request for %s failed with status code %d%n",
                    response.getRequest().getUrl(), response.getStatusCode());
        }
    }
}
catch (BlobBatchStorageException be) {
    System.err.printf(">>>> batch storage exception: %s%n", be.getMessage());
}
catch (Exception e) {
    System.out.printf(">>>> exception: %s%n", ExceptionUtils.getMessage(e));
}

Expected behavior
It should be possible to delete versioned blobs using BatchBlobClient.
Screenshots
N/A.
Setup (please complete the following information):

OS: Linux
IDE:  IntelliJ IDEA
Library/Libraries: azure-storage-blob-12.16.1 azure-storage-blob-batch-12.12..2 azure-storage-blob-12.20.0 azure-storage-blob-batch-12.16..0
Java version: 8
App Server/Environment: N/A
Frameworks: N/A

Additional context
N/A.

Hi @dk823832 thanks for filing this github issue.  Someone from the Storage team will follow up.
/cc @jaschrep-msft

Hi @dk823832
Thanks for reaching out. Unfortunately, blob-batch does not support deletes for versioned blobs, we recommend deleting blob versions via the regular delete API using BlobClientBase.
Here is more information on versioned blobs and deletes:
https://learn.microsoft.com/en-us/azure/storage/blobs/versioning-overview#deleting-a-blob-or-version
Let us know if you have more questions or need any additional help!


Support projects without a JSON library in the dependencies

Creating an issue from the TODO item to have discussion
I explored if using the ETF format could be an option. There exists a lua parser for it. But sadly this seems to make use of lua 5.3 constructs which is very hard to get it working on neovim (lua 5.1). More specifically, the parser uses

bit shift operators << which seems to be supported under a different module / syntax ref
string.unpack function for which all the existing options falls short in different ways

lua-struct does not return the bytes read as the second return value. Based on an issue comment on the repo, it seems like a simple change to return it.
lua-pack is not a drop-in replacement. returns values in base-2 formats 🤷🏻
lua-compat-5.3. This is possibly the only option that seemed to work, but it messes up with global values and that breaks somewhere in plenary code

Curious if there are any other ways / options to achive this

This might be as simple as implementing a subset of the JSON encoding ourselves. Encoding seems to be fairly straightforward: https://github.com/cblage/elixir-json/blob/master/lib/json/encoder/default_implementations.ex

I tried embedding Poison (as it has fewer files) but the command takes 25 seconds compiling every time before running the tests. It's probably the protocols.
Embedding a version that doesn't use protocols is an option, but I agree that is further from the scope of the library.

I'm sure Mix.install would work in a completely independent file, but we would have to test how it behaves when you then run a project after requiring the script.

Basically, we need a way to transfer the following structure to Lua:
%{
  id: "some id with potentially special chars",
  status: "simple string",
  output: "/some/file/path" or nil,
  errors: [
    %{
      message: "some text with potentially special chars",
      line: number or nil
    }
  ]
}

With #3 the special chars in the id would be removed, assuming files don't have anything weird, and I guess the errors could be saved to files and read on the Neovim side.
If we don't have to worry much about escaping characters, then it becomes easier.

Adding Mix.install makes it fail like this:

The actual error is this
%Mix.Error{message: "Mix.install/2 cannot be used inside a Mix project", mix: 1}
Which makes sense, since the formatter is invoked in the same context as the mix project.
Am thinking if we can split the formatter into two GenServers,

one as a part of a mix project(so we can add deps), start it under a node name. It should handle the file writing part.
one that we can register as the formatter that will simply forward to the above GenServer
Seems like overkill, but I can't think of any other option

If both instances are nodes then we can connect them and use remote calls for communication but that also adds more complexity and then the embeded encoder option doesn't sound so bad xD
I tried implementing the encoder without protocols and it takes less than 70 lines: https://github.com/jfpedroza/neotest-elixir/blob/jp/embedded-json-encoder/neotest_elixir/json_encoder.exs

Yeah that seems good and apt!


Show fields counts coverages instead of difference

Now it returns fields counts coverages for both jobs which I think is more obvious.
One thing to note is that the coverage can be >100% since scrapy cloud stats counts array fields too.
Before:

Now:

I am not personally sure that the previous one was worse, since it worked better for cases when there's more than 100% coverage.
For example, having this job:

s (1 item job)
t (1 item job)

addresses
["some_address", "another_address"]
["yet_another"]

The stats would be:

s
t

addresses
2
1

Which will result in a coverage plot (imagine it):
addresses ====== 150%
          ==== 100%
xscale    ====== 150%

But 150% coverage looks suspisious.
And the old one would be:
addresses ===== 50 %
xscale    ========== 100%

In both cases the difference in addresses coverage is indeed 50%.
And this is how it actually looks (note 450%)

I think the best way is to plot 2 graphs - both jobs and the important diff (let's say >5%)


Adding support for waiting icon and failed icon in status

Closes https://github.com/microsoft/bedrock/issues/1238

Failing because it will have to be merged after https://github.com/microsoft/spektate/pull/82


chore(main): release 0.0.21

:robot: I have created a release beep boop
0.0.21 (2024-07-31)
Features

http basic auth support for HTTPFileRules (#236) (49046fe)

Dependency Updates

deps: update module github.com/onsi/ginkgo/v2 to v2.19.1 (#231) (fb43c3e)
deps: update module github.com/onsi/gomega to v1.34.1 (#234) (b3edb79)
deps: update module github.com/validator-labs/validator to v0.0.51 (#233) (740d88e)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.21
:sunflower:


Upgrade java version

It's running on Java version 1.6. We are having issues related to GC in case of exception (path not found). We are thinking of using Try (javaslang) function for suppressing the exception.

Upgrade to Java 8


Git is not found

Issue Type: Bug
Install VS Code
Open source control.
VS Code version: Code 1.41.0 (9579eda04fdb3a9bba2750f15193e5fafe16b959, 2019-12-11T18:37:42.077Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz (8 x 3395)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.96GB (9.16GB free)

Process Argv

Screen Reader
no

VM
36%

Extensions: none

Is the workspace you have opened under Git control ? The view is only populated if you open a folder which has a .git folder.

Do you have the prettier extension installed? I have the same problem, disabling prettier solves it. Alternatively, waiting for 5 minutes helps too, it will eventually show up.

Can you run Git: Show Git Output?

In case it was overlooked by others, the bat file in #4651 allows VSCode to partially support MSYS2's git. At least, changes are shown and "Source Control" tab is not empty.


Windows: recommend installing Jinja2?

With Jinja2, you're more likely to get bin/usdGenSchema. An out-of-the-box build of maya-usd (Autodesk's take on the AL and Pixar Maya plugins) expects it.
pip install jinja2

Later on guys. And thanks for putting this repo together, i'm building on all 3 plaftorms and it's super helpful.

Thanks for the note, all the instructions updated to mention installing jinja2!

Hi Nick! Cool.


[Bug] Can't add RectangleROITool or CircleROITool dynamically

Describe the Bug
I am trying to add a rectangle annotation but i am facing some issues
Note it can be good if we can have more examples for dynamically adding RectangleROITool, CircleROITool and AngleTool like what was done LengthTool.
Steps to Reproduce
    const points: Point3[] = [
      [-35.685298919677734, -9.446551322937012, 30.00376319885254],
      [-18.081600189208984, 4.328248500823975, 30.00376319885254],
      [-35.685298919677734, 4.328248500823975, 30.00376319885254],
      [-18.081600189208984, -9.446551322937012, 30.00376319885254]
    ]
    cornerstoneTools.utilities.annotationHydration(
      viewport,
      RectangleROITool.toolName,
      points
    );
    cornerstoneTools.utilities.triggerAnnotationRenderForViewportIds([
      viewport.id,
    ]);

The current behavior
@cornerstonejs_tools.js?v=e6db9132:23788 Uncaught TypeError: Cannot read properties of undefined (reading '0')
    at drawHandle (@cornerstonejs_tools.js?v=e6db9132:23788:20)
    at @cornerstonejs_tools.js?v=e6db9132:23830:5
    at Array.forEach (<anonymous>)
    at drawHandles (@cornerstonejs_tools.js?v=e6db9132:23829:16)
    at RectangleROITool.renderAnnotation (@cornerstonejs_tools.js?v=e6db9132:32896:11)
    at handleDrawSvg (@cornerstonejs_tools.js?v=e6db9132:24408:33)
    at Array.forEach (<anonymous>)
    at @cornerstonejs_tools.js?v=e6db9132:24412:20
    at draw (@cornerstonejs_tools.js?v=e6db9132:23641:3)
    at AnnotationRenderingEngine._triggerRender (@cornerstonejs_tools.js?v=e6db9132:24404:5)

https://github.com/cornerstonejs/cornerstone3D/blob/79887f9681ce363798c1f1454bbe0c670fdabded/packages/tools/src/drawingSvg/drawHandle.ts#L44
The expected behavior
A rectangle annotation is displayed
OS
Windows 11
Node version
16.14.0
Browser
Chrome 131.0.6778.70

Please refer to the PR for details on the new static method available on the tool for hydration.https://github.com/cornerstonejs/cornerstone3D/pull/1624


{'error':'We couldn't find your API Key.'}

`from serpapi.google_search_results import GoogleSearchResults
client = GoogleSearchResults({"q": "coffee", "serp_api_key": "************************"})
result = client.get_dict()`
I tried giving my API key from serpstack. Yet I am left with this error. Any help could be much useful.

Hi Rokintech,
Apologize for the delay.
Did you to contact the support from serpapi.com directly ?
This query is totally valid as long as the API key match the one available from http://serpapi.com/dashboard

I think you are mixing two different service.
This package is designed to work with serpapi.com


Improve flow for bumping, publishing, releasing

Thoughts

Version bumping is time consuming and feels automateable.
The steps before it (test, build, lint) should be run in the CI - also when releasing.
Releases span JS (npm) and RUST (cargo) repositories. Ideally, both are automated.
Manual changelog editing is proven to be error-prone. Let's get rid of it.
Version bumps require commit, so probably require an automated PR - or we need a CLI that also commits. In any case, we can't have the CI bumping code without a PR.

Right now releasing a new version is too much manual work:
In browser

pnpm lint-fix
commit any changes (if they are there)
pnpm build to build typescript files (don't skip this!)
make sure atomic-server is running on localhost.
pnpm test
pnpm test-e2e
Update the package.json files for lib, rust, and data-browser with a new version number. Match the version number with atomic-data-rust
Check the changelog, make sure the headers are correct
Now do the rust libraries
Commit any changes, name it vX.XX.XX
pnpm publish -r

Choose a new version. Versions should match atomic-data-rs.
This updates the package.json files, creates a commit, tags it, pushes it to github, and publishes the builds to npm.
If this fails, try pnpm version patch and pnpm publish
DONT run pnpm npm publish, as it will not resolve workspace dependencies correctly.

In the rust crates

Commit changes
Make sure all tests run properly
Test, build and update the /browser versions (package.json files, see ./browser/contributing.md)
Use cargo workspaces version patch --no-git-commit (and maybe replace patch with the minor) to update all cargo.toml files in one command. You'll need to cargo install cargo-workspaces if this command is not possible.
Publish to cargo: cargo publish. First lib, then cli and server.
Publish to npm (see browser/contribute.md)
Update the CHANGELOG.md files (browser and root)

Solutions

cargo-release automates bumping versions and publishing. I used it some time ago, for somereason removed it from the docs. I recall having some issues with it.
release-plz, which creates PRs for releases. Written in rust, supports only rust.
release-please, does the same, typescript, by google. Supports rust workspaces with a plugin, but also supports pnpm.

Tried release-plz
https://github.com/atomicdata-dev/atomic-server/actions/runs/10579544307/job/29312265327#step:4:412
issues so far

GitHub Actions is not permitted to create or approve pull requests

Release-please

I tried a bit in #961, haven't gotten it to work so far.
@AlexMikhalev had some experience with this, it apparently creates commits that contains the build outputs... That would be a complete dealbreaker.


Tag version for Rails Assets

We'd like to be able to use this library via Rails Assets, but to do that, the repo needs to have a tag for the version, eg. "v0.0.2". Could you tag a version of the code so we can use this as a gem? Thanks!

This has been added