READY FOR REVIEW - work around OpenSSL issue which mistakes a cert as self-signed if CA org == cert org

Fix #808 and SvenDowideit/generate_cert#10. Update generate_cert to 0.2 (to gain access to the --org command line option). Use --org command line option to ensure org for automatically-generated CA cert differs from org for automatically-generated client/server certs. Work-around for OpenSSL bug (see http://tinyurl.com/pqgnb2a).
Merge needed for (i.e., blocks):

docker/compose#890
docker/docker-py#465
possibly others

--
The Author grants to the owners of this repository, and the owners of the software it contains known as "boot2docker" (the Software), as well as their heirs and assigns (the Recipients), a perpetual and transferable license to all rights the Author may have to any material submitted in this pull request as if it were created by the Recipients themselves. By merging this pull request, the Recipients agree to indemnify and hold harmless its Author against any harm or liability from its inclusion in the Software or use.
 IN NO EVENT SHALL ITS AUTHOR BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

The reason this PR is submitted against this repository as opposed to SvenDowideit/generate_cert is because @SvenDowideit gently pointed out that a patch to generate_cert is not needed to overcome the issue. Rather boot2docker can call it with the appropriate command line options when generating the certificates.

@tianon @icecrime @aanand @bfirsh can we add this for 1.8.0 boot2docker, or should I make a separate iso for user's that aren't going to move to docker-machine straight away.

LGTM

Looks like this is worth getting in for 1.8.

Agreed.

Seems sane to me, and a simple enough change to include in 1.8 even so late in the game. :+1:

Thanks :heart:
LGTM


The datagrid component's loading state background color became dark in light theme

Describe the bug
Before the 2.1.2 update, the background color of the loading state of the datagrid component blends in perfectly with the light theme.

In the 2.1.2 update, the background turned into a dark color. The new color doesn't play nice with the light theme as if there's a huge overlay slow flickering every time you navigate the server-driven data grid to the next page.

Here's how it looks in the actual app. It looks like there's a huge cut-out in the center of the page:

How to reproduce
Please provide a link to a reproduction scenario using one of the Clarity Stackblitz templates. Reports without a clear reproduction may not be prioritized until one is provided.
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

You can reproduce it in the documentation samples: https://clarity.design/documentation/datagrid/server-driven
Expected behavior
A clear and concise description of what you expected to happen.
Versions
App

Angular: [e.g. 6]
Node: [e.g. 8.10.0]
Clarity: [e.g. 0.12.5]

Device:

Type: [e.g. MacBook]
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional notes
Add any other notes about the problem here.

Thanks for reporting this, @whizkidwwe1217
It's a regression from our change to hsl() values. One of them was lost in translation.
As a workaround, you could add...

Maybe an additional :host ::ng-deep  is needed in some cases...
:host ::ng-deep .datagrid-spinner {
    background-color: rgba(255, 255, 255, 0.6);
}

Thanks for the suggestion, @zerocewl
But I believe this has been fixed already.


Add merge keys to Workflow objects to allow for StrategicMergePatches

This change adds merge keys to the types defined by Argo, allowing the types to be recognized for StrategicMergePatching, as opposed to the less powerful JSONMergePatch strategy.
We have an example of this in action using our branch of Kustomize:
# Clone the following branch of Kustomize.
# This branch imports the branch referenced in this PR
git clone --single-branch --branch armadacrd git@github.com:keleustes/kustomize.git

# Build and install kustomize and its plugins.
# Note that this will overwrite the current copy of kustomize,
# as well as any previously compiled plugins stored in $HOME/.config/kustomize
make install build-plugins

# Run through the example for argo. Further instructions are found in the README there.
cd examples/crds/argo-workflow
cat README.md

This feature will be much more important as Kubernetes moves forward. It will eventually have an effect on how a kubectl patch works on Argo resources, as Kubernetes continues to improve support for CRDs. See this PR adding CRD validation field in server-side apply for example.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/assign @jessesuen

I've signed the CLA - not sure why it says I haven't.


Why can't I download the files

Why can't I download the example resource pack?

Please get new link to download the example resource pack.

It's working for me. Does anyone else have this issue? Please check your internet connection and try again.

It's working for me. Does anyone else have this issue? Please check your internet connection and try again.

My internet connection doesn't have any issue. Please send new link to download the files or change the downloading link.

看起来你是中国大陆地区的用户。raw.githubusercontent.com 是 GitHub 的域名，因此在大陆地区的连通性会比较差。请尝试使用代理


fixed 2nd question missing from Contents of the Table & serial number order

I have fixed for 2nd question missing from the Contents of the Table, Please verify and accept it.
I'm new to contributing to open-source
Thank you.

@im-raj-b  Thanks for PR. It has been updated already.


Add new checks to the checker

A few things aren't checked at the moment:

Do any tempfiles exist? (that's backend-specific)
Are all packs correctly indexed?

This is not needed any more: tempfiles are not used any more, and the check for all packs in the index is already implemented. Closing.


When Start All Jobs is pressed, only tiles with job_statuses of failed and no job assigned to them should have new jobs created

The exact logic of this needs discussion. This ties into more hands on approach to managing tiles and products (if a sen2cor or sen2agri l2a for a product exists, then don't redo the processing to create those products, indicate that those products exist on the GUI). This is a big problem, needs major work, will probably happen when the state management is moved to a db and redux store.


[FS Router] configuring route property of exported ViewConfig in views is breaking the router functionality

Describe the bug
The ViewConfig type introduces a route property with the following documentation:
  /**
   * Allows overriding the route path configuration. Uses the same syntax as
   * the path property with React Router. This can be used to define a route
   * that conflicts with the file name conventions, e.g. /foo/index.
   */
  route?: string;

IMO, it is a great feature to have, as there are always situations that leads to structuring the view files in a different way than what we expect them to be handled by the router, but when I export a config of type ViewConfig that tries to override the default route for a view by initializing the route property, it breaks the router functionality in the following ways:

The default route is not resolved by the FS router anymore, so an attempt to hit that in the browser simply falls back to server-side router (ends up showing No Route Found message).
Attempting to hit the url with configured route for that view renders a blank page.

Expected-behavior
By defining a route in the exported config from a view, I expect to be able to override the default extracted route based on the file system, so that it works.
Reproduction

Taking a starter app
Create an AboutView under frontend/views/about so the automatically resolved route for it becomes /about/AboutView and verify that it works
Export the following config from the AboutView:

export const config: ViewConfig = {
  route: "about"
};

Now the expected route for this view is /about, but navigating to it would result in rendering a blank page.
The default route is not also working, so the route is not simply ignored, but causes a misbehaviour.

System Info
Vaadin 24.4.0.alpha16

The route parameter allows to customize the current path item, not the whole path. This means that, since you're defining an about view in the about folder, you have to visit /about/about to see your configured page.
This could be pointed out in the comment, but changing the functionality to redefine the whole looks quite complicated to me, since in the generated JSON each item only contains the corresponding path level, so it's not easy to customize the whole thing.

I'd open another issue if the route parameter must configure the whole thing.


Issues running under latest node.js LTS 8.9.3 npm 5.5.1 with private npm registry

I have a private npm registry that caches public packages and have npm configured to look at my private registry. When I run whitesource I get an error output from the process, but it still successfully publishes my whitesource results.
Here is and example Error I am getting. I am getting one error entry for each package in my package.json...
Error: URL: https://acme.pkgs.visualstudio.com/_packaging/Itron.Cloud.Ipl/npm/registry/@angular%2Fhttp?5.0.5
Error:  Unauthorized
    at C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\bin\ws_node_report_builder.js:280:15
    at tryCatcher (C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\node_modules\bluebird\js\release\util.js:16:23)
    at Promise._settlePromiseFromHandler (C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\node_modules\bluebird\js\release\promise.js:512:31)
    at Promise._settlePromise (C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\node_modules\bluebird\js\release\promise.js:569:18)
    at Promise._settlePromise0 (C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\node_modules\bluebird\js\release\promise.js:614:10)
    at Promise._settlePromises (C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\node_modules\bluebird\js\release\promise.js:693:18)
    at Promise._fulfill (C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\node_modules\bluebird\js\release\promise.js:638:18)
    at Request._callback (C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\node_modules\bluebird\js\release\nodeback.js:42:21)
    at Request.self.callback (C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\node_modules\request\request.js:186:22)
    at emitTwo (events.js:126:13)
    at Request.emit (events.js:214:7)
    at Request.<anonymous> (C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\node_modules\request\request.js:1163:10)
    at emitOne (events.js:116:13)
    at Request.emit (events.js:211:7)
    at IncomingMessage.<anonymous> (C:\Users\anwalker\AppData\Roaming\npm\node_modules\whitesource\node_modules\request\request.js:1085:12)
    at Object.onceWrapper (events.js:313:30)

I have validated that the error goes away when I downgrade to node.js 6.x. It errors in the 8.x LTS version.
I commented out the console.error in the ws_node_report_builder.js and console errors go away, but I wonder if it is reporting the right information to whitesource...

This issue has broken all of our NPM builds and we are no longer able to run through whitesource.  Can you confirm/comment/fix?


rustup; disable opt level >=2 tests due to ICE

Cc https://github.com/rust-lang/rust/issues/77564 for the ICE

@bors r+

:pushpin: Commit 808032a0edc4614079c47d114769e11ceca26a62 has been approved by RalfJung

:hourglass: Testing commit 808032a0edc4614079c47d114769e11ceca26a62 with merge 95f0ad191b53e6b144c999618ba353270fc2e4da...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 95f0ad191b53e6b144c999618ba353270fc2e4da to master...


Caching Component still brings problems

Thanks for fixing https://github.com/TexteaInc/json-viewer/issues/62, but caching components still brings problems.

Here is snippet:
import {JsonViewer} from "@textea/json-viewer";
import * as React from "react";
import {useState} from "react";
import {Button} from "@mui/material";

export function IndexPage() {
    const data = [{'key': 'val1'}]

    const [i, setI] = useState(1);

    console.log('value outside closure', i)

    return (
        <>
            <JsonViewer
                value={data}
                valueTypes={[
                    {
                        is: (() => true) as any,
                        Component: (props) => {
                            return <Button onClick={() => {
                                console.log('value inside closure', i)
                                setI(i => i + 1)
                            }}>{i} time clicked</Button>;
                        },
                    },
                ]}
            />
        </>
    )
}

Clicking on button doesn't change component because of memoisation, but it should.
I don't see any reasons to cache it.

I was meant to design the value type component as a pure component. So it won't re-render until the props change and shouldn't use external variables.
But I decide to let the user do anything now. But just remind that valueTypes will call registerType everything if you do not wrap it with useMemo in the new PR
https://beta.reactjs.org/apis/react/useMemo

Thanks it works better now


Support for Function calling

Describe the feature
It would be nice to have support for function calling as seen in https://platform.openai.com/docs/guides/gpt/function-calling
for the models gpt-3.5-turbo-0613 and gpt-4-0613

Agreed.
I added a preliminary version to openai-fetch here: https://github.com/rileytomasek/openai-fetch/pull/26
Support for this package would definitely be appreciated.

This would be a huge feature upgrade. Is anyone currently working on this?

Looking forward to ！！

+1

When can we expect this to be in?

I might give it a try and start working on an implementation.

Alright so i'll use this issue as a live updates "blog".
First thing: most likely will need a function to manually feed the conversation with a function result.

Any news?

This repo and issue has been inactive for long. Is there any one working on this feature now?

Function calling is working fine with the current code. The issue is with returning the function call output to chatgpt
@transitive-bullshit I'm working on modifying the code to accept function output and (Role function) and send it to chatgpt
I hope you can let us know if you are already doing it or if you will accept the changes (I can see many pull requests are not accepted/rejected)

This project is undergoing a major revamp; closing out old issues as part of the prep process.
The chatgpt package is pretty outdated at this point. I recommend that you use the openai package or the openai-fetch package instead.


Make libcnb-cargo usable from workspace root

Currently, it can only be used from a buildpack project directory. Users might want to bundle multiple buildpacks in a Cargo workspace and build all buildpacks at once by running cargo libcnb package in the workspace root.
GUS-W-10283507.

To add in https://salesforce.quip.com/J3ZpAihiOAaZ. My ideal state would be to make building and releasing buildpacks converge to ~1 step. Being able to build all buildpacks in a workspace at the same time would help to get closer to that ideal.

Also maybe worth mentioning here: I took a spike at resolving buildpack dependencies based on their buildpack.toml entries awhile ago in ruby: https://github.com/schneems/omgcnb.

I've filed W-10283507 to track this, under the cross-compiling epic.

Once we update to Clap v3 we can then use:
https://crates.io/crates/clap-cargo
...which will make this much easier to implement.


Allow xapsd to use a .p12 file directly

The sideshow/apns2 project has code for this. Either switch to that APNS client or reuse their code to load the key and certificate from a .p12 file.

If we want to keep overhead low, we should wait for this


changed in ui of index page

Your issue number ?

I didn't create new issue I just worked on front page of ui !


Overload signature that uses generics breaks as of 2.7.1

TypeScript Version:  2.7.1, 2.7.2, 2.8.0-dev.20180220; issue not present in 2.6.2
Search Terms: overload, signature, generic, tuple
Code:
function foo<T1, T2>(values: [T1, T2]): [T1, T2];
function foo<T1>(values: [T1]): [T1];
function foo(values) {
	return values;
}

function fooWrapper<T1, T2>(values: [T1, T2]): [T1, T2];
/** [ts] Overload signature is not compatible with function implementation. **/
function fooWrapper<T1>(values: [T1]): [T1];
function fooWrapper(values) {
	return foo(values);
}

Expected behavior:
There should not be any type error; the wrapping function should behave identically to the wrapped function.
Actual behavior:
Compile time error on the overload signature of the wrapping function.
Playground Link: http://www.typescriptlang.org/play/#src=function foo<T1%2C T2>(values%3A [T1%2C T2])%3A [T1%2C T2]%3B
function foo<T1>(values%3A [T1])%3A [T1]%3B
function foo(values) {
	return values%3B
}

function fooWrapper<T1%2C T2>(values%3A [T1%2C T2])%3A [T1%2C T2]%3B
%2F** [ts] Overload signature is not compatible with function implementation. **%2F
function fooWrapper<T1>(values%3A [T1])%3A [T1]%3B
function fooWrapper(values) {
	return foo(values)%3B
}
Related Issues: None known
Notes: Seems potentially related to tuples fixed length change in 2.7

I suspect you're right about that, but you can get around this by explicitly saying that fooWrapper returns an any[].

@DanielRosenwasser - yes:
function fooWrapper(values) {
	return foo(values) as any[];
}
const result = fooWrapper([1,2]); // [number, number]

or even
function fooWrapper(values) {
	return foo(values) as any;
}
const result = fooWrapper([1,2]); // [number, number]

solves the issue while retaining typings. I added this because it broke our CI and figured it might do the same for someone else later.

ideally, you would give values a type annotation to be [any] | [any, any], and expect the type of foo(values) to be [any]|[any, any]. The issue here is that overload resolution does not distribute over union properties, so that is not possible today. this is tracked by https://github.com/Microsoft/TypeScript/issues/14107


[Enhancement] Diagram control

Summary
Create a new control which allows us to build a diagram.
It should allow

add any shape to the board
All shapes can be moved
all shapes should contain connectors
allow to draw arrow between connectors
arrow annotations

Intended Use Case
Flowchart diagram for commands execution.
Blazor example: https://github.com/VladislavAntonyuk/Blazor.Diagrams
Who Will Do The Work?

[ ] I am willing to take this on myself
[ ] Just putting this out there for someone to pick up

Thanks! However, we are no longer adding new features to Xamarin Community Toolkit, focusing on the .NET MAUI Community Toolkit.
Please open a New Feature Discussion to implement this feature in the .NET MAUI Community Toolkit.
I've posted more information about the Future Of Xamarin Community Toolkit here: https://devblogs.microsoft.com/xamarin/the-future-of-xamarin-community-toolkit/?WT.mc_id=mobile-0000-bramin


Re-allow boolean type

In getProtectedData(), we still need to be able to get older protected data that have been created with a type of boolean.

in #268 scope


On iOS7 it doesn't rotate

Prior iOS8 UIScreen instances doesn't rotate, that means that in iOS7 your HDNotificationViews in landscape they appear only at the upper top corner as they were in Portrait. To handle that you need to apply transformations according to device rotation changes.
From apple doc of UIScreen:
Prior to iOS 8, a screen’s bounds rectangle always reflected the screen dimensions relative to a portrait-up orientation. Rotating the device to a landscape or upside-down orientation did not change the bounds. In iOS 8 and later, a screen’s bounds property takes the interface orientation of the screen into account. This behavior means that the bounds for a device in a portrait orientation may not be the same as the bounds for the device in a landscape orientation. Apps that rely on the screen dimensions can use the object in the fixedCoordinateSpace property as a fixed point of reference for any calculations they must make.

Thanks for your feedback, i will update it asap.


Active item tap hitbox too small

Taps on the active item are only triggered when tapped exactly on the icon, while there is a bigger hitbox for inactive items. Whole bubble should trigger the onTap in my opinion.
Example photos from the widget inspector:
Inactive Item:

Active Item:

@talhabw We've implemented the current solution accordingly, due to the specific UI requirements. However, we appreciate your suggestion and will consider it for future updates. Thank you for your input.


Sync 3.0.0 with latest master

@tomaszdurka please review

@tomaszdurka this is a very short one ;-)

Thooomaaaaasz @tomaszdurka

lgtm


Include test function span information (file, module path, line number) in forc test output

As of #2985, we only produce the function name for each test in our output, e.g.

We should be showing the full file path, module path and line number like cargo does.
This was omitted from #2985, only because it wasn't immediately obvious to me where to retrieve the span from during the ASM generation stage, and the PR is big enough :sweat_smile:

I think cargo only prints line number, file path and module path when a test is ignored (maybe also for failing ones too), I think that makes sense if a test is passing it results less noise in the terminal and only if something that may require your attention those details are printed. I am leaning towards doing the same thing.
File path and line number should not be a problem but it is not really clear how can we get the module path. Do we even have modules? If a test named foo is declared under baz.sw, is there any other possilibity than baz::foo in sway right now?


Support Simon Fraser University Streams

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://stream.sfu.ca/Media/Play/4b81988fd2224558920bec311b96a8e01d

Description
Hello, I would like youtube-dl to support the Simon Fraser University streaming service.  It is used for recorded seminars and other events.

If you were able to generate a HAR archive of your browser session from the opening example URL to viewing the video, it would facilitate this. You could post it as a gist.
Or ask SFU staff if they can support a download or catch-up service.

https://gist.github.com/jfcaron3/63aae68a3eefa0064868eeaedc4686fe


Support realtime subprocess logging

By default when subprocess output is captured it gets piped. However, this means that logs aren't visible until the process has completed.

Due to buffering this is impractical cross-platform


Token with attachments saved as prototype shifts attachments right when dragged to hex grid

I'm not actually sure if this is a hex-grid specific issue, but to replicate try the following:

create an actor on a scene with a hex grid and drag the token to the map
add a drawing/light source/note that is easy to see if it is centered and center it in the same cell as the token
attach the drawing/light source/note to the token
assign the token (now with attachment) as the prototype token for the original actor
drag the actor back to the map
observe the right offset of attached entities (no longer centered)

Love this module and pleasantly surprised that you can even save attachments with a token prototype in the first place. Hoping this is an easy fix. Happy to help debugging further.

The left is a combination of 6 drawings and a light source attached to a token with a transparent image.
The right is after saving the left as the prototype token and re-dragging it to the map.

I removed all modules but token attacher and can confirm the bug still exists. I also confirmed that this only appears to happen on a hex-grid map. When in hex-row orientation (even or odd) the original token looks good, but the new token is shifted right (original image). HOWEVER, when I switch to hex-column orientation and re-snap both tokens, the original looks shifted left and the new token is perfectly centered.
This may have something to do with core token alignment in hex grids (center of token is calculated differently depending on row or column arrangement), or it could be based on how this mod calculates linked coordinates (from top left instead of grid center maybe?). I think that's all the info I can give for now.

In hex columns, original (left) is now uncentered, but the newly dragged-to-map prototype (right) is perfectly centered!

Fixed in 4.0

Fixed in 4.0


Prevent TypeError when required_tools returns nil.

When no build_tools_location is specified in bozorc.rb the following error occurs even if without_stylecop has been specified for msbuild.  This happens because required_tools returns nil instead of an empty array.  Removing all nil from the result of get_build_tools fixes this.
Retrieving build tools - [:stylecop, :nuget]
#<TypeError: can't convert nil into String>

.../bozo/lib/bozo/build_dependency_resolver.rb:88:in `join'
.../bozo/lib/bozo/build_dependency_resolver.rb:88:in `retrieve_from_build_tools_location'
.../bozo/lib/bozo/build_dependency_resolver.rb:63:in `block in retrieve_build_dependencies'
.../bozo/lib/bozo/build_dependency_resolver.rb:54:in `each'
.../bozo/lib/bozo/build_dependency_resolver.rb:54:in `retrieve_build_dependencies'
.../bozo/lib/bozo/build_dependency_resolver.rb:17:in `resolve'
.../bozo/lib/bozo/executor.rb:70:in `dependencies'
.../bozo/lib/bozo/executor.rb:81:in `prepare'
.../bozo/lib/bozo/executor.rb:92:in `compile'
.../bozo/lib/bozo/executor.rb:103:in `test'
.../bozo/lib/bozo/executor.rb:29:in `block in execute'
.../bozo/lib/bozo/executor.rb:196:in `with_hooks'
.../bozo/lib/bozo/executor.rb:28:in `execute'
.../bozo/lib/bozo.rb:72:in `block (2 levels) in bozo_command'
c:/Ruby193/lib/ruby/gems/1.9.1/gems/gli-1.6.0/lib/gli/command.rb:121:in `call'
c:/Ruby193/lib/ruby/gems/1.9.1/gems/gli-1.6.0/lib/gli/command.rb:121:in `execute'
c:/Ruby193/lib/ruby/gems/1.9.1/gems/gli-1.6.0/lib/gli.rb:250:in `run'
.../bozo/bin/bozo:9:in `<top (required)>'
c:/Ruby193/bin/bozo:23:in `load'
c:/Ruby193/bin/bozo:23:in `<main>'
error: can't convert nil into String

:mag: @lukesmith

:+1:


[AutoPR reservations/resource-manager] [Hub Generated] Review request for Microsoft.Capacity to add version preview/2018-06-01

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6368

(message created by the CI based on PR content)


IoT credentials provider

Is your feature request related to a problem? Please describe.
We have dug through the code to look for IoT credentials provider, but we could not find any.
Our use case is to give IoT devices limited credentials to S3 buckets.
Describe the solution you'd like
An wrapper that performs something similar to this
https://docs.aws.amazon.com/iot/latest/developerguide/authorizing-direct-aws.html
Or the implementation similar to the ones used in KVS streams.
Describe alternatives you've considered
We can implement the steps from here ourselves. Or we can generate aws keypairs allowing for s3 buckets only.
https://docs.aws.amazon.com/iot/latest/developerguide/authorizing-direct-aws.html

Hey @suggestedfixes ,
Thanks for bringing it up to us. It sounds like a reasonable request, but being completely honest it would take some time for our team to get around adding this...
Having said that, I'm not quite sure what you mean on the alternatives you've considered, have you found a workaround or a way to implement the changes you suggest?
If it's the first, could you elaborate on that?
And if it's the second, we would be happy to review a PR for the feature.
Thanks again for bringing this up to us btw.

Wish I could +100 this right now. @KaibaLopez I don't know if there's a way to obtain credentials on an IoT device as of today. What is the recommended way?
Basically, how does one implement this via SDK: https://docs.aws.amazon.com/iot/latest/developerguide/authorizing-direct-aws.html ?
You help is appreciated. Thanks,

@KaibaLopez I found the c implementation from kvs video streams, I wonder how difficult is it to port to this sdk?
https://github.com/awslabs/amazon-kinesis-video-streams-producer-c/blob/master/src/source/Common/IotCredentialProvider.c


Expires Date

How to can I set expires date for the JTW, in the create moment ?

That is going to depend on how you are creating the JWT.  This library doesn't create the JWT, only ensure that the JWT is valid.  To create a JWT usually you'll want to use another service or your own endpoint that is authenticated via username/password.
If you're using the jsonwebtoken  module take a look at the expiresIn option.

I am not answering this question. I am in doubt about this as well =)
I add expiresIn as exp property in the JWT payload
but how this lib handle it? it seems does throw any error out
the code below is my way to deal with expiration
function generateJwtToken(userId) {
	return JWT
		.sign({
			sub: userId,
			iat: Date.now(),
			exp: Date.now() + 1000 // add 1s
		}, JWT_SECRET)
}
// passport middleware
passport.use(new JwtStrategy({
	jwtFromRequest: ExtractJwt.fromHeader('x-auth'),
	secretOrKey: JWT_SECRET,
}, (payload, done) => {
	// =========  Manuly handle ===============
	const isExpired = (payload.exp - Date.now()) < 0
	if (isExpired) return done(new Error('Token Expired'), false)
    // =========================================
	User.model
		.findById(payload.sub)
		.exec()
		.then((user) => {
			if (!user) return Promise.reject(new Error('User_Id is not Found.'))
			done(null, user)
		})
		.catch((error) => {
			done(error.message || new Error(error), false)
		})
}))


Update Field equality check so FeatureSet is updated when new Feature constraints are applied.

What this PR does / why we need it:
FeatureSet should be updated by SpecService in Core when a new Feature/Entity spec with new constraints are applied. However, currently the equality comparison in Field class does not check for differences in constraints. This PR adds that additional checks.
Which issue(s) this PR fixes:

NONE

Does this PR introduce a user-facing change?:

NONE

/lgtm

/retest


remove unnecessary 'continue' in install script (#766)

remove unnecessary 'continue' keyword in install script
Description

[ ] This change requires a documentation update
[ ] I have made corresponding changes to the documentation

Related Issue(s)
This PR addresses issue #766
/claim #766
closes #766
Screenshots
If relevant, please add screenshots.
Notes
Please add any relevant notes if necessary.

Closed in favor of #809


Read wrong attribues value for click after ripple

Hi,
In the Button.java class you set this in the consturctor:
"clickAfterRipple = attrs.getAttributeBooleanValue(MATERIALDESIGNXML,"animate", true);"
instead of  this (from attrs.xml):
<!-- if true, delays calls to OnClickListeners until ripple effect ends -->
<attr name="clickAfterRipple" format="boolean" />
Thanks,
Robert

Ohh, Thanks, I did't have seen the error, I'm going to fix it

Was this ever actually fixed? The issue got closed, but the code hasn't changed, and the attributes still aren't working correctly.


Bundling: Remove chunk hashes from file names

Context

Summary
As mentioned at #8995 (comment), if we'd name our files file-chunk-1.js?v= instead of file-chunk-1-.js, that might save us some trouble with translation loading.
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

[x] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #9046

Today we discussed potentially using the chunk's own hash for its version parameter instead of the entry point's hash.
While I looked into it and it seemed very straightforward to implement, it's actually not needed at all.
All chunks are dynamically imported by webpack and not enqueued through WordPress, so the version their registered with does not matter at all.
So what's needed there is actually a way to have the version as part of the URL for that dynamic import. Using chunkFilename: '[name].js?v=[chunkhash]' achieves that.


add metric and flag information for BoundServiceAccountTokenVolume

exception issue is opened here: https://github.com/kubernetes/enhancements/issues/2126

/milestone 1.20
/hold for exception request approval

/hold cancel
exception approved, k/k pr merged

/hold

will unhold once KEP updates are made

beta graduation is moved to 1.21 per discussion in https://github.com/kubernetes/kubernetes/pull/95667#issuecomment-721186100, but I would still like to add the metric and extended expiration description information (that can be done in the master branch of the website since it is applicable to releases prior to 1.20 as well

/milestone clear
enhancement deferred to 1.21 (https://github.com/kubernetes/website/pull/24854#issuecomment-721790745)
There isn't 1.21 milestone yet, I'm not sure what the protocol is here.
Do we close out the PR or leave it open? @sftim @jimangel @savitharaghunathan

i think we still want add some documentation around metrics and extended expiration.
the PR is submitted.
https://github.com/kubernetes/kubernetes/pull/96273

Then, I think this one could be to master branch since it's not being tracked with 1.20 release? what do you think?

Can you also retitle title this as well?

hi @zshihang can you update us on what your plan is for this PR?
I'm not clear on if this needs to be tracked as part of 1.20 or will be made against master instead.
Please let me know so it can be tracked accordingly! thank you

i am fine move it to master. this PR will basically add information about metric and flags.

/lgtm

/hold cancel

@kubernetes/sig-auth-pr-reviews I'd also like a technical LGTM here; is that OK?

/lgtm
/approve

Page preview:
https://deploy-preview-24854--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/#feature-gates

/lgtm

/approve


Remove a hardcoded value in test_version.py

Overview / Explanation for Changes
Replaces the hardcoded value manim with __name__.
Oneline Summary of Changes
- Remove a hardcoded value in test_version.py (:pr:`PR NUMBER HERE`)

Acknowledgements

[x] I have read the Contributing Guidelines

Reviewer Checklist

[ ] Newly added functions/classes are either private or have a docstring
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings
[ ] The oneline summary has been included in the wiki

Naive question - what does this actually test, and how did this come up? I'm not too familiar with the inner workings of packages. Is it plausible those two values would be different?

The test was made when __version__ was added (which was when the commandline flag was added) to make sure __version__ matched the version in pyproject.toml (or at least, that's what it should do). If you're referring to whether manim and __name__ would be different, the answer is no. They're the same, and they have to be. But, in the future if the name was changed from manim to something else, it wouldn't need updated where __name__ is used. The import would obviously need refactored, but that's the case all over the library. I think it's best to remove hardcoded values of that name when possible. I noticed it was hardcoded when reviewing a different PR so that's why this was made.

So in total, it's a minor refactor to avoid a spurious error in the case that manim's name is changed, and the point of the test is to double-check the version anyways. And __version__ has to be hardcoded rather than pulled from pyproject.toml right?
If so, in sum it's no bad and small good, so I'm :+1:

All correct except the last part. __version__ is set here. https://github.com/ManimCommunity/manim/blob/master/manim/init.py#L8 When a user has this installed through, say, pip, they do not have a pyproject.toml to pull the version from, hence why it uses importlib.metadata. Overall, yes, no bad and small good.


What does mean tubclean count?

I would like to know what tubclean count does mean and if u have the meaning of the full list

tubeclean_count count the number of cycle from the last "Tube Clean".
I don't have a list for all attributes, this can be deducted from washer user manual.
I close this issue, for additional question please refer to HA discussion forum


snazzy verry nested node_modules.  This is cause a problem on windows.

can not delete files under node_modules.
real dialog(sorry, japanese)

different file name same error englisth dialog

thanks for filing! I've opened PR #757 to address these issues

@cvan Thanks!

Have you tried using the latest version of NPM? It seems to install modules in a much flatter fashion.

fixed by #757

This issue was moved to aframevr/aframe#371


Use JPA in Custom Logic

Tutorial URL: https://developers.sap.com/tutorials/cp-apm-05-using-jpa.html
Is it possible to have a github repo with the final code ?
It would be very helpful to check and compare the code with ours.

Thank you Maximilien. We've noted your request and will take it into consideration when deciding the positioning of the whole JPA topic in the programming model.

Thanks for the comment. For general questions like this -- not bugs in the tutorials -- feel free to use:
https://www.sap.com/community.html
https://answers.sap.com/index.html


SOPS + Hashicorp Vault:  token expiration issue

The documentation tells you:
"
Create a secret the vault token, the key name must be sops.vault-token to be detected as a vault token:
echo $VAULT_TOKEN | kubectl create secret generic sops-hcvault \ --namespace=flux-system \ --from-file=sops.vault-token=/dev/stdin
"
And finally set the decryption secret in the Flux Kustomization to sops-hcvault
but it doesn't tell you how to create the token.
but having such token would mean: create a static vault token in a secret and let flux use this to contact the transit engine in vault to decrypt data.
However, there is no such thing as a static token with an infinite ttl in vault. Only the root tokens have this, which should be discarded after provisioning of vault.
The solution provided is a bit vague as it will mean that after a certain while (max ttl i assume ( 768h/24h=32days )) before the kustomizations will start failing since the token will be discarded.
I tried this solution which in principle works great. but either the token has to be renewed or another form of authentication has to implemented for it to stay operational.
Token example
`$ vault token lookup -accessor 1234
Key                 Value

accessor            1234
creation_time<PHONE_NUMBER>
creation_ttl        768h
display_name        token
entity_id           n/a
expire_time         2022-11-25T22:17:03.662337175Z
explicit_max_ttl    0s
id                  n/a
issue_time          2022-10-24T22:17:03.662345724Z
meta
num_uses            0
orphan              true
path                auth/token/create
policies            [default read_transit_prod]
renewable           true
ttl                 609h57m45s
type                service`
so flux kustomizations which such token will die in ~25 days
I assume flux has to be prepared to be working with JWK authentication and the flux cluster contacting has to be configued in vault using the kubernetes authentication endpoint.

https://github.com/fluxcd/kustomize-controller/issues/695
https://github.com/fluxcd/kustomize-controller/issues/693


Thanks!

We have already sent accept email, can you check your email to confirm

Yes. I've just confirmed.
Very happy to join this class.
Thank you so much.
And see you later. :)
On 4 October 2016 at 13:51, Quan Vu<EMAIL_ADDRESS>wrote:

We have already sent accept email, can you check your email to confirm
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hoanghahuynh/TodoApp/issues/5, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQhmdGiD3qZly6MIvUKumqwdWHu8Gf1hks5qwfeNgaJpZM4KNWVN
.

--
Best regard,
Huỳnh Hoàng Hà
LH: 01692.796.200


site layout editing, new site data

layout property for Site object that builds layout
update_layout method on Site to publish new layout
few changes to site creation
changes to initiative site data.json

closes #82

example notebook for site editing
changes to site clone - clones pages
changes to site delete - unlinks pages
clean method docstrings
added dependency on most recent arcgis version


python310Packages.mcstatus: 10.0.2 -> 10.0.3

Diff: https://github.com/py-mine/mcstatus/compare/refs/tags/v10.0.2...v10.0.3
Changelog: https://github.com/py-mine/mcstatus/releases/tag/v10.0.3
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 226804 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.minecraft_server
mcstatus (python310Packages.mcstatus)
mcstatus.dist (python310Packages.mcstatus.dist)
python311Packages.mcstatus
python311Packages.mcstatus.dist


External authentication mechanisms

Be nice if we could setup a hook to call an external authentication mechanism to allow remote state to work.  Example:
go acquire creds from vault and store in credentials file.  THEN init/apply/plan commands.  Currently before_hooks execute after the remote state is configured.
It'd be extra nice if these hooks would also set/get environment variables so we could pass those on vs. using credential files.

We've had several requests for hooks that run earlier in the lifecycle (e.g., https://github.com/gruntwork-io/terragrunt/issues/620). Seems like a generally useful feature that would support this use case too. Bonus points if hooks can affect env vars of Terragrunt/Terraform itself. This stuff is on our list, but I'm not sure when we'll get to it. If anyone is up for it, a PR to add this would be very much appreciated 👍

We actually have something implemented to make this possible. @tmeckel made changes to our Terraform/Terragrunt setup to allow hooks that parse their own output as variables and pass them as environment variables to subsequent hooks or to the provider configuration.
Like so:
before_hook "get_secrets" {
      commands = [
        "init",
        "apply",
        "plan",
        "destroy",
        "import",
        "push",
        "refresh",
        "validate",
      ]

      load_env_vars {
        execute = [
          "pwsh",
          "-nop",
          "-nol",
          "-File",
          "${get_parent_tfvars_dir()}/Scripts/Get-Secrets.ps1",
        ]
      }

      run_on_error = false
    }

We expect KEY=value output to STDOUT from the hook. Then these variables can be used with standard interpolation (get_env()).
@tmeckel, any plans to contribute this back to this repository soon? 🙃

@brikis98  I can provide a WIP PullRequest of the current implementation over the weekend that we're currently have in place as @tiwood mentioned. The changes that we're applied to terragrunt include late binding (evaluation) of environment variables every time a command is issued and the ability to change/initialize the environment variables used by terragrunt via a hook.

@brikis98  there you go .. as promised I provided a pull request (#680) with the changes we applied to Terragrunt


SoilWaterHoldingCapacity in csv file is zero

Trees are growing just fine and AvailableWater maps have values so it's likely just a reporting error.

Which log file is this?

I see, the primary log file.  Should this column be removed?  There is not a single SWHC per climate region.  We could report average but is that meaningful across large climate regions?

My concern is that an average will be very broad and may mis-direct naive users; particularly those familiar with the prior definitions of ecoregion.

Therefore I prefer to omit.

That's fine. Did you fix the log file already?

Yes, will show up in next release.


Deduplicate the logic for resource name generation

Deduplicate logic that calculates generated names, truncating them for certain lengths.
Testing:
All Unit tests have passed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Would you mind also checking to see if any of these changes introduced further linting errors? It's been a goal of mine for every PR to reduce the linting error count. I know there are still a lot, so it might be hard to see which of those have been introduced by your changes.

I have fixed all linting errors in the common.go file and a few in aws_config_loader.go (except one for which I added a TODO). The rest of the project looks clean!

Can we make sure to run integration tests or smoke tests on this? I think if you do a manual HPO job and manual HostingDeployment it will be a good enough test since HPO spawns TrainingJobs and HostingDeployment is the only one that uses the Kubernetes names.

Can we make sure to run integration tests or smoke tests on this? I think if you do a manual HPO job and manual HostingDeployment it will be a good enough test since HPO spawns TrainingJobs and HostingDeployment is the only one that uses the Kubernetes names.

I did a manual [1]hostingDeployment, [2]trainingJob, [3]BatchTransform and [4]HPO. I verified the endpoint, endpointconfig, model names for [1]. [2] and [3] did not go to completion due to incorrect specs but were successfully launched.  For [4] training jobs were successfully spawned and are in progress.


[BUG]: Hang on startup

Is there an existing issue for this bug?

[X] I have searched the existing issues

🐛 Describe the bug
When  trying to train OpenSora1.2 via
colossalai run --nproc_per_node 8 --hostfile hostfile scripts/train.py configs/opensora-v1-2/train/train_config.py
it hangs at the startup:
[2024-08-06 04:53:37] Beginning epoch 0... Epoch 0:   0%|          | 0/1234 [00:00<?, ?it/s]
By checking all nodes via nvidia-smi, all GPUs are at 100% load and x MB memory, execpt for one GPU, which is at  0% load and 0.95 x MB memory.
This has happend to me multiple times (each time another GPU is not prepared). Any idea how to solve this issue?
When I start training, I get the message:
Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.
Not sure if that is relevant?
Environment
CUDA 11.8
colossalai==0.4.0

Even more, when I close the colossalai call, it is not closing the jobs on the nodes. Some processes are frozen and cannot be killed by htop, resulting in a soft lockup  messages when calling nvidia-smi.

If you're using multi-node training, you might want to ensure that all nodes can ssh into one another using the same ssh port. See https://github.com/hpcaitech/ColossalAI/commit/9179d4088e378c437178432168dea9f32fbf739f

Feel free to reopen if it persists.

@Edenzzzz All setups seem to be fine. After x tries, at some point, it is able to load all GPUs and start the training.


Update README.md Added ASYNC / AWAIT

great addition! thank you

It is my pleasure.

great addition! thank you

It is my pleasure.


Add Labels to Repository's Issues

Examples:

Feature Request
Bug

@destari Hey hey, thanks for adding a few options! I think it'll help a bunch. Also, thanks for putting up with all my Issue submissions. Looking forward to helping however I may to close 'em!


Replace Glium

Glium is a convenient choice, but is a rather big dependency which compiles slowly, and uses build.rs. It is also no longer actively maintained.
The ideal choice for compiling Egui natively would be something simple that compiles quickly. I'm not sure there is such an alternative though.
One alternative worth investigating is pure glutin (which Glium depend on). It is a bit lower level compared to Glium, and requires use of unsafe, but it looks easy enough to use: https://gist.github.com/matthewjberger/9da00592b472b50ec1e6b3238719264b

miniquad may be a reasonable option with a stated goal of fast compilation time. There's already an existing basic implementation that is linked to in this repo's readme.
It has good cross-platform support (notably including mobile and web). Perhaps if its web backend is sufficient, egui could only need to officially support one integration, although official wgpu/gfx-hal and winit may be useful for adoption, given their prevalence in the Rust graphics ecosystem.
From an egui integration perspective, it looks like miniquad should be able to support all of RawInput, PaintJobs, and Output, with the exception of setting the mouse cursor.

miniquad may be a reasonable option with a stated goal of fast compilation time. There's already an existing basic implementation that is linked to in this repo's readme.
It has good cross-platform support (notably including mobile and web). Perhaps if its web backend is sufficient, egui could only need to officially support one integration, although official wgpu/gfx-hal and winit may be useful for adoption, given their prevalence in the Rust graphics ecosystem.
From an egui integration perspective, it looks like miniquad should be able to support all of RawInput, PaintJobs, and Output, with the exception of setting the mouse cursor.

I haven't looked at miniquad a lot, but it does seem to have a minimum of dependencies, which is awesome!
Sadly it doesn't seem to have a sRGBA/gamma aware texture format: https://docs.rs/miniquad/0.2.55/miniquad/graphics/enum.TextureFormat.html. This would mean colors will always be a bit off (like they are in egui_web). This is one thing egui_glium gets right. I would be hesitant to sacrifice correctness for compilation speed in for the official native Egui backend.

I haven't looked at miniquad a lot, but it does seem to have a minimum of dependencies, which is awesome!
Sadly it doesn't seem to have a sRGBA/gamma aware texture format: https://docs.rs/miniquad/0.2.55/miniquad/graphics/enum.TextureFormat.html. This would mean colors will always be a bit off (like they are in egui_web). This is one thing egui_glium gets right. I would be hesitant to sacrifice correctness for compilation speed in for the official native Egui backend.

Based on the reading I've done, I think gfx-hal or wgpu would give you the best portability/performance in the long run. No idea when it comes to compile times. It would be awesome if there was a really fast (but maybe unsafe) backend that could be used for prototyping an app, then you can switch to a slower backend for production builds. I would guess a minimal OpenGL binding library would be the fastest you can compile in Rust.

Based on the reading I've done, I think gfx-hal or wgpu would give you the best portability/performance in the long run. No idea when it comes to compile times. It would be awesome if there was a really fast (but maybe unsafe) backend that could be used for prototyping an app, then you can switch to a slower backend for production builds. I would guess a minimal OpenGL binding library would be the fastest you can compile in Rust.

+1 for gfx and wgpu.  They seem to be the future.
As for compile times, I agree that having long compile times is annoying, but I'd rather that the back end be correct and well-supported than worry about compile times.

+1 for gfx and wgpu.  They seem to be the future.
As for compile times, I agree that having long compile times is annoying, but I'd rather that the back end be correct and well-supported than worry about compile times.

Oops, accidentally closed

Oops, accidentally closed

One disadvantage of miniquad: It does not yet support IME, which is very unfriendly to non-English users. Winit+gfx-hal/wgpu-rs may be the best solution at this stage.

One disadvantage of miniquad: It does not yet support IME, which is very unfriendly to non-English users. Winit+gfx-hal/wgpu-rs may be the best solution at this stage.

I did my own backend with gl_rs (tho it uses some abstraction I have over opengl, so unsafes are a bit more limited). One cool crate I recently found out about is https://github.com/grovesNL/glow so maybe this is also an option if you're looking to keep it available on as many platforms as possible.

Can you elaborate if this means your planning on removing support for glium all together? I'm currently writing a project using glium and imgui-rs, and was hoping to switch to egui at some point, but reading this thread has me confused about whether or not that will be possible.
To be clear, I'm just hoping for clarification here. Thanks!

I think egui_glium will stick around as long as it has users, it will just no longer be the default backend for eframe.

I can vouch for glow being really useful. Seems like a good option to me and it works on web as easily as it does desktop I think. The issue I see with GFX or WGPU is that OpenGL support isn't complete yet.

If you switch glium to wgpu backend will need support initialize by vulkan like way
like in egui sample but extreamly easier than vulkano or ash

I also think that glow is a reasonable choice at least until wgpu lacks well opengl support (if it ever happens).
The only one big cons related to choicing glow, that it is a simple wrapper around OpenGL APIs so it unsafe.

An alternative to glow and glium that I recently tried out that is very nice is luminance. It's got a safe and Rusty API and it has desktop and web backends. It's way nicer than using plain OpenGL through glow or other GL wrappers.

An alternative to glow and glium that I recently tried out that is very nice is luminance. It's got a safe and Rusty API and it has desktop and web backends. It's way nicer than using plain OpenGL through glow or other GL wrappers.

Luminance is very nice, but currently it supports OpenGL >3.
GUI libraries should support different variants of OpenGL APIs including GL 2.x, GL ES 2.x, and etc.

Good point. Then we could port the Luminance GL backend to use Glow. 😏

Because I wanted to support Safari on iOS for my game, I ended up making a glow backend for Luminance that is able to target WebGL1. Without having tested it, I'm fairly sure that it can also support GL ES 2.x. Maybe not the best idea to have egui depend on my experimental backend that has just been born, but it's there if anybody want's to mess around with it.
It also targets both web and desktop without requring separate backends, so instead of having to have separate GL and WebGL backends of egui we could just have one:
https://github.com/katharostech/luminance-glow

One disadvantage of miniquad: It does not yet support IME, which is very unfriendly to non-English users. Winit+gfx-hal/wgpu-rs may be the best solution at this stage.

@n2 This is misleading. The winit + gfx-hal/wgpu-rs stack does not support IME either. In fact, close to none of the Rust ecosystem supports IME, because the issue is upstream in winit (https://github.com/rust-windowing/winit/issues/1497).

@lunabunn Yes, you are right. No rust window handler supports all IME functions, but what I mean is that by using winit, even if there is no Composition event, one can at least use IME to input non-English characters (such as Chinese characters in my case) . For miniquad, there is no way to do this.

I'm in the process of making a fork that replaces egui_glium's glium dependency with glow.
It's not 100% complete yet:

It has a couple OpenGL texture leaks
I haven't fully tested it with user textures
There is an odd graphical glitch where there's a black border around things

Other than that, it seems to work fine:

I plan to fix all remaining problems in the coming days, just putting it out there that I'm working on it, and I can polish it up if there is an interest in merging it once all the ugly bits have been ironed out.
It's at AlexApps99/egui, feel free to give feedback but keep in mind it's still rough around the edges.

Oh, very interesting @AlexApps99 !
First piece of feedback is that we likely want it as a separate crate egui_glow next to egui_glium so that we can:

Test them side by side as competing native backends for eframe (perhaps behind a feature flag at first)
Keep egui_glium as some are using glium for 3D rendering and egui_glium for a gui layer (i.e. they aren't using eframe).

First piece of feedback is that we likely want it as a separate crate egui_glow next to egui_glium

I'll be sure to do that, but since Git doesn't make very good diffs when files are moved, I will temporarily overwrite egui_glium while I am working on it, and rebase once I feel it's close to completion

For the texture leaks: would it be better if:

EguiGlow held a reference to glow::Context, so everything can be properly destructed on drop (this would create some lifetime restrictions on it)
The functions that overwrite textures (register_glow_texture and set_user_texture) take in an argument for glow::Context
A Vec<NativeTexture> of pending to be deleted textures is stored by EguiGlow and when a function with glow::Context is called, they all get deleted
Some other solution?
It's worth noting that the first solution is the only one that would completely avoid leaks, as all remaining objects that EguiGlow would be storing on drop would have no way to be deleted unless done manually by the user, or if a reference to context is stored.

Also, do you think it would be worth storing the old OpenGL state and restoring it once painting is complete? It would probably make it take a bit longer to draw but would lead to less bugs when users integrate egui into their code. No idea if other IMGUIs do this, like Dear Imgui

I think the first options sounds good, as glow::Context seems to be made for sharing (it's Sync and all methods are &self). Though forcing users to call egui_glow.destroy(&glow_context); isn't that much of a limitation imho.
For saving state: I'd vote no (at least initially), but document what state is lost.

coming from #735 , about using wgpu as the official backend, I just wanted to mention that wgpu transparency support is not yet done. https://github.com/gfx-rs/wgpu/issues/687 . :(

That's a shame, but it doesn't sound like a deal-breaker, when web doesn't support it, and most integrations will not need it.

I agree about transparency not being a big problem. The current glium window transparency is not great either (at least on my mac) due to egui using a different blendmode (premul alpha).
I believe most important things when picking a native rendering for eframe is, in approximate order:

portability: compiles on all platforms and runs well for all video cards with all drivers
performance: high FPS / low CPU and GPU usage / battery efficient
compilation: few dependencies, no build.rs

(Am I missing something?)


GUI Module

Requirements:

Paging (irrespective of inventory size, potentially only in a subsection of the inventory)
Simple to define areas that do not allow item manipulation (eg adding or removing items), probably dont allow any items by default and some way to allow items in certain slots
A way to construct multiple page menus with the ability to go back to the previous one
Multiple items acting with the same goal (eg 3 items in a row all with the same handler, probably with a RP trick to make them look like one wide button)

Stretch Goals:

Test utilities (would be nice to easily be able to test menus and whatnot)
A way to define specific behavior for shift clicking items to and from the inventory (eg for crafting, so shift clicking in goes to the crafting slots as if the others dont exist. Shift clicking from result has vanilla-like behavior (the location depends on the item type))
Any utilities for working with font stuff that we can come up with. I dont know off the top of my head for this, would likely come up with stuff when using the inventory

Regarding structure:
I dont have a ton of opinions, though i once saw a spigot inventory lib that handled everything with panels of a specific size that can be nested inside each other. So for example you could have a pagination panel set to 5x5 somewhere in the inventory and it only knows about its local 5x5 inventory. This would help to solve all of the things so far in my top list. I dont remember the name of the library but ill see if i can find it again
Spigot Library: https://github.com/stefvanschie/IF/wiki

Moved to MapMaker for now, will eventually move it back


Catch and list errors from processes

Chore that needs to be done:

[x] Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_numer either from issue tracker or the Pull request number

Codecov Report
Patch coverage: 13.33% and project coverage change: -3.00 :warning:

Comparison is base (404b5a9) 55.62% compared to head (d0b77da) 52.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   55.62%   52.63%   -3.00%
==========================================
  Files           4        4
  Lines         160      171      +11
==========================================
+ Hits           89       90       +1
- Misses         71       81      +10

Flag
Coverage Δ

unittests
52.63% <13.33%> (-3.00%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

resizer/resize.py
36.79% <13.33%> (-3.21%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Raise error when trying to use have_received without rspec-expectations

This is a workaround for #967.  It doesn't actually fix the underlying bug, but does provide more documentation and an explanatory error message.
There are two commits:

Add more documentation about the inability to use have_received without rspec-expectations
Raise an explanatory error message when attempting to use have_received without rspec-expectations.

I couldn't find a way to add a spec for this new error, as all of the current specs run with rspec-expectations in place.  If someone can suggest a way to test this properly, I'd be happy to do so.
Given this example code:
require "minitest/autorun"
require "rspec/mocks"

class User
  def accept_invitation(invitation)
    invitation.accept
  end
end

module RSpecMocksIntegration
  include ::RSpec::Mocks::ExampleMethods

  def before_setup
    ::RSpec::Mocks.setup
    super
  end

  def after_teardown
    super
    ::RSpec::Mocks.verify
  ensure
    ::RSpec::Mocks.teardown
  end
end

class SpyTest < Minitest::Test
  include RSpecMocksIntegration

  def test_accepts_invitation
    invitation = spy("invitation")
    user = User.new
    user.accept_invitation(invitation)
    expect(invitation).to have_received(:accept)
  end
end

the following error message occurs in the current version of rspec-mocks:
  1) Error:
SpyTest#test_accepts_invitation:
NoMethodError: undefined method `setup_expectation' for #<RSpec::Mocks::Matchers::HaveReceived:0x007fa764215800>
    /Users/randy/.rvm/gems/ruby-2.2.2/gems/rspec-mocks-3.3.0/lib/rspec/mocks/targets.rb:45:in `define_matcher'
    /Users/randy/.rvm/gems/ruby-2.2.2/gems/rspec-mocks-3.3.0/lib/rspec/mocks/targets.rb:14:in `block in delegate_to'
    bug_test.rb:33:in `test_accepts_invitation'

1 runs, 0 assertions, 0 failures, 1 errors, 0 skips

With the code from this PR, the following message occurs instead:
  1) Error:
SpyTest#test_accepts_invitation:
RSpec::Mocks::MockExpectationError: Using expect(...) with the `have_received` matcher is not supported when using rspec-mocks without rspec-expectations.
    /Users/randy/.rvm/gems/ruby-2.2.2/gems/rspec-support-3.3.0/lib/rspec/support.rb:86:in `block in <module:Support>'
    /Users/randy/.rvm/gems/ruby-2.2.2/gems/rspec-support-3.3.0/lib/rspec/support.rb:93:in `call'
    /Users/randy/.rvm/gems/ruby-2.2.2/gems/rspec-support-3.3.0/lib/rspec/support.rb:93:in `notify_failure'
    /Users/randy/src/github/rspec-mocks/lib/rspec/mocks/error_generator.rb:320:in `notify'
    /Users/randy/src/github/rspec-mocks/lib/rspec/mocks/error_generator.rb:304:in `__raise'
    /Users/randy/src/github/rspec-mocks/lib/rspec/mocks/error_generator.rb:193:in `raise_have_received_disallowed'
    /Users/randy/src/github/rspec-mocks/lib/rspec/mocks/matchers/have_received.rb:76:in `disallow'
    /Users/randy/src/github/rspec-mocks/lib/rspec/mocks/matchers/have_received.rb:62:in `setup_expectation'
    /Users/randy/src/github/rspec-mocks/lib/rspec/mocks/targets.rb:45:in `define_matcher'
    /Users/randy/src/github/rspec-mocks/lib/rspec/mocks/targets.rb:14:in `block in delegate_to'
    bug_test.rb:34:in `test_accepts_invitation'

1 runs, 0 assertions, 0 failures, 1 errors, 0 skips

If I instead require "rspec-expectations" and include RSpec::Matchers in the RSpecMocksIntegration module of my example, the tests pass as expected.

Thanks, @randycoulman.  After thinking about this some more, I realized that I think there's a pretty simple way to support have_received w/o rspec-expectations.  I'll try to push up my solution in the next few days.  If I run into any complexities we may still use your solution here.

I did indeed come up with a way to make it work :).  See #968.
Closing this one since users would rather it work...
Thanks for the PR, though!


Meet requirements for richer PWA install on Chrome

Currently we do not meet the requirements for the richer install experience on chrome mobile or desktop, meeting these would allow for a much better experience for users on Chrome when installing the application as a progressive web application.
Docs here: https://developer.chrome.com/blog/richer-pwa-installation/

Ooh I should take a look at this

I can assign this issue to you if you'd like @JessFairbairn
Lemme know if you need a hand getting the project set up.

Yes please!

All yours, good luck! I'm not free till next week but if you run into problems running the project locally or need any support reach out and I'll attempt to lend a hand, should have video call availability as of next week as well.


[Feature Request] Animixplay and 9Anime: Filter for genres

PLEASE READ THIS
I acknowledge that:

I have updated:

To the latest version of the app (stable is v0.10.12)
All extensions

I have tried the troubleshooting guide: https://tachiyomi.org/help/guides/troubleshooting-problems/
If this is an issue with the app itself, that I should be opening an issue in https://github.com/jmir1/aniyomi
I have searched the existing issues and this is new ticket NOT a duplicate or related to another open issue
For source requests, I have checked the list of existing extensions including the multi-source spreadsheet: https://tachiyomi.org/extensions/
I will fill out the title and the information in this template

Note that the issue will be automatically closed if you do not fill out the title or requested information.

What feature should be added to this source?
Explain why this should be added
"Filter" for genres would be able to find what series you might like, hope this might be added since almost "all" anime sites have a genre filter

Closing as Animixplay is no more and 9anime has filter for genres.


Ifh-Bíff Efreet legality in question

On scyfall and https://pennydreadfulmagic.com/deckcheck/  [Ifh-Bíff Efreet] is legal in penny dreadful. When I cast it on MTGO I get a message saying its not legal. Please confirm its legality and fix on PD bot. Thank you

Ifh-Bíff Efreet is legal. The final arbiter of legality is always http://pdmtgo.com/legal_cards.txt
I expect the accent on the I is misrendered in MTGO or otherwise confusing the bot.
Until that is fixed you can report the result of league games involving the card at https://pennydreadfulmagic.com/report//


Can not build android apk

Can not build android apk.
when execute "cd android && ./gradlew assembleRelease".

FAILURE: Build failed with an exception.

* Where:
Build file 'XXXXXX/node_modules/react-native-hud-hybrid/android/build.gradle' line: 12

* What went wrong:
A problem occurred evaluating project ':react-native-hud-hybrid'.
> Could not find method google() for arguments [] on repository container of type org.gradle.api.internal.artifacts.dsl.DefaultRepositoryHandler.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

My React Native version is 0.56, the project is generated by using react-native init .  And Android SDK version setting is following:

ext {
    buildToolsVersion = "26.0.3"
    minSdkVersion = 16
    compileSdkVersion = 26
    targetSdkVersion = 26
    supportLibVersion = "26.1.0"
}

Please refer to the settings in the playground：
buildscript {
    repositories {
        google()
        jcenter()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.1.1'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        google()
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../../node_modules/react-native/android"
        }
    }
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

ext {
    // sdk and tools
    minSdkVersion = 16
    targetSdkVersion = 27
    compileSdkVersion = 27
    buildToolsVersion = '27.0.3'
    supportLibraryVersion = '27.1.1'
}


@conda-forge-admin, please add user @adambrazier

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added user @adambrazier in conda-forge/adc-streaming-feedstock#8.


HTTP request sent, awaiting response... 404 Not Found 2019-06-05 07:57:37 ERROR 404: Not Found.

似乎创建文件夹失败了
2019-06-05 07:57:37 ERROR 404: Not Found.
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /home/webtemp/2.zip or
/home/webtemp/2.zip.zip, and cannot find /home/webtemp/2.zip.ZIP, period.
Archive:  /home/webtemp/2.zip
[错误]  web 站点伪装 失败

Sorry, I miswritten the download path. Now I fixed it.


Why the stride of convolution layer in generator is 4?

In your paper LINK, I readed G is composed of ~ strides of N =2 in page 3, but strides are 4 in your code. Because of the performance?

If I understand correctly, the original SEGAN implementation had a stride length of 2, but the improved SEGAN+ link has a stride length of 4, as well as some other tweaked hyper parameters.

Thank you for your kindness :)


sample_oracle_loader.py - sqlalchemy.exc.ObjectNotExecutableError

Trying to load some data into our newly installed instance of Amundsen using the sample_oracle_loader.py, but running into an exception in the sqlalchemy library. Only thing I've changed in the code is the connection string to our database.
Expected Behavior
Program completes successfully and data is (hopefully) loaded into Amundsen
Current Behavior
Raises an exception on loading_job.launch()
Traceback
File "C:\Users...\venv\lib\site-packages\sqlalchemy\engine\base.py", line 1410, in execute
meth = statement._execute_on_connection
AttributeError: 'str' object has no attribute '_execute_on_connection'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Users...\venv\lib\site-packages\databuilder\job\job.py", line 76, in launch
raise e
File "C:\Users...\venv\lib\site-packages\databuilder\job\job.py", line 64, in launch
self._init()
File "C:\Users...\venv\lib\site-packages\databuilder\job\job.py", line 51, in _init
self.task.init(self.conf)
File "C:\Users...\venv\lib\site-packages\databuilder\task\task.py", line 45, in init
self.extractor.init(Scoped.get_scoped_conf(conf, self.extractor.get_scope()))
File "C:\Users...\venv\lib\site-packages\databuilder\extractor\oracle_metadata_extractor.py", line 58, in init
self._alchemy_extractor.init(sql_alch_conf)
File "C:\Users...\venv\lib\site-packages\databuilder\extractor\sql_alchemy_extractor.py", line 40, in init
self._execute_query()
File "C:\Users...\venv\lib\site-packages\databuilder\extractor\sql_alchemy_extractor.py", line 65, in _execute_query
self.results = self.connection.execute(self.extract_sql)
File "C:\Users...\venv\lib\site-packages\sqlalchemy\engine\base.py", line 1412, in execute
raise exc.ObjectNotExecutableError(statement) from err
sqlalchemy.exc.ObjectNotExecutableError: Not an executable object: '\n        SELECT\n            'master' as "cluster",\n            lower(c.owner) as "schema",\n            lower(c.table_name) as "name",\n            tc.comments as "description",\n            lwer(c.column_name) as "col_name",\n            lower(c.data_type) as "col_type",\n            cc.comments as "col_description",\n            lower(c.column_id) as "col_sort_order"\n        FROM\n            all_tab_columns c\n        LEFT JOIN\n            all_tab_comments tc ON c.owner=tc.owner AND c.table_name=tc.table_name\n        LEFT JOIN\n            all_col_comments cc ON c.owner=cc.owner AND c.table_name=cc.table_name AND c.column_name=cc.column_name\n        \nwhere table_schema = 'public'\n\n        ORDER BY "cluster", "schema", "name", "col_sort_order"\n        '
python-BaseException
Screenshots
I was curious to see if this query would run outside of Python, and it doesn't - However, if you exclude the WHERE clause, it runs fine. Not sure if this is related or not.

Thanks!

I am receiving the same issue trying to implement sample_postgres_loader.py
Traceback (most recent call last):
  File "/home/ubuntu/amundsen/databuilder/venv/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1410, in execute
    meth = statement._execute_on_connection
AttributeError: 'str' object has no attribute '_execute_on_connection'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/ubuntu/amundsen/databuilder/custom/custom_postgres_importer.py", line 184, in <module>
    loading_job.launch()
  File "/home/ubuntu/amundsen/databuilder/databuilder/job/job.py", line 76, in launch
    raise e
  File "/home/ubuntu/amundsen/databuilder/databuilder/job/job.py", line 64, in launch
    self._init()
  File "/home/ubuntu/amundsen/databuilder/databuilder/job/job.py", line 51, in _init
    self.task.init(self.conf)
  File "/home/ubuntu/amundsen/databuilder/databuilder/task/task.py", line 45, in init
    self.extractor.init(Scoped.get_scoped_conf(conf, self.extractor.get_scope()))
  File "/home/ubuntu/amundsen/databuilder/databuilder/extractor/base_postgres_metadata_extractor.py", line 68, in init
    self._alchemy_extractor.init(sql_alch_conf)
  File "/home/ubuntu/amundsen/databuilder/databuilder/extractor/sql_alchemy_extractor.py", line 40, in init
    self._execute_query()
  File "/home/ubuntu/amundsen/databuilder/databuilder/extractor/sql_alchemy_extractor.py", line 65, in _execute_query
    self.results = self.connection.execute(self.extract_sql)
  File "/home/ubuntu/amundsen/databuilder/venv/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1412, in execute
    raise exc.ObjectNotExecutableError(statement) from err
sqlalchemy.exc.ObjectNotExecutableError: Not an executable object:

It looks like this is related to some changes in SqlAlchemy 2.0. I was able to resolve the issue by pinning the version of SqlAlchemy to a prior version in the requirements.txt file
sqlalchemy==1.4.47


Installation prevented by root permission issue on Mac

Versions
Node
v9.8.0
NPM
5.6.0
OS
El Capitan & HighSierra

Observed behavior
When running sudo npm install -g @angular/cli it executes until it hits the sass script below. I have tried to find anyone else having this same issue and so far I can only find Linux issues, but no solutions. Has anyone else encountered this?

gyp verb command install [ '9.8.0' ]
gyp verb install input version string "9.8.0"
gyp verb install installing version: 9.8.0
gyp verb install --ensure was passed, so won't reinstall if already installed
gyp verb install version not already installed, continuing with install 9.8.0
gyp verb ensuring nodedir is created<EMAIL_ADDRESS>gyp WARN EACCES user "root" does not have permission to access the dev dir<EMAIL_ADDRESS>gyp WARN EACCES attempting to reinstall using temporary dev dir<EMAIL_ADDRESS>gyp verb tmpdir == cwd automatically will remove dev files after to save disk space

This seems like a problem with your node/npm and not with Angular CLI.
Please have a look at the fixing npm permissions page, common errors page, npm issue tracker, or open a new issue if the problem you are experiencing isn't known.

It finally worked its way through after letting it go for over a half hour. Glad it worked, never took this long on Windows.


How to get both nodes when node is moved (swapped)

My question is about, when we move (drag n drop) node, then there is 2 nodes, 1 is which is moved, 2nd is which is replaced by moved node. in other words, we swapped the 2 nodes.
now i want both of nodes info (ids, positions) to update in the database.
I am using below code to trigger below function when node is moved
('move_node.jstree', function (e, data)
====
Now i want both of nodes (ids, positions). Please suggest.
Image 1

Image 2

Thanks in advance!
Originally posted by @ravi-ku in https://github.com/vakata/jstree/issues/2136#issuecomment-430489266

I already answered in the previous ticket - stop opening new tickets please. If you think my answer was not enough - keep the discussion in the original ticket.


Support Custom Hadoop Properties In The Data Source

The Iceberg data source just uses the Spark Session's global Hadoop configuration when constructing File System objects in HadoopTableOperations, Reader, and Writer. We propose support for specifying additional reader and writer-specific options to the Hadoop configuration. The data source can parse out options with the prefix iceberg.spark.hadoop.* and apply those to the Hadoop configuration that is sent to all uses of the Hadoop FileSystem API throughout the Spark DataSource.

So this would be similar to the behavior of spark.hadoop properties?
I think that would make sense. We want to configure writers primarily through Iceberg table configuration, and it would be good to have a way to do that other than just a small list of known and supported properties.

Originally I was thinking we could put it in sparkSession.write.option(iceberg.spark.hadoop.<opt>) but now that you mention it this could make more sense to be in the Table's inherent properties. I can put up a patch for this.

We want configuration to come from multiple places. A write may want to use a different format, so that would be passed like your example. But most things we want to apply at a table level and not at a job level. Parquet tuning parameters are a good example of that -- we want to set them once and know that all writers know what to do.
A PR would be great. Thanks!


Validating CDEvent fails if not setting Optional fields

As per the spec for most of the events subject.content filds are optional, but validating the event against jsonschema fails if not setting these optional fields when creating an event,
An example pipelineRunQueued events fails without setting these optional fields source, pipelineName, url
CDEvent validation failed with errors [ $.subject.source: null found, string expected, $.subject.content.pipelineName: null found, string expected, $.subject.content.url: null found, string expected ]

Is this something we need to allow string and null(for optional fields) something like "type": ["string","null"] in the jsonschema, wondering how it is handled in sdk-go I don't see it's having default values for optional fields to pass this schema validation?

I don't think this is something in the jsonschema.
In the go sdk i had a similar issue because I wasn't using pointers in the types, and the JSON renderer was than producing the zero value for the types, which is not allowed by the schema i.e. an optional field should either not be there at all or, if it's there it should meet the schema requirements.
The Java libraries will most likely behave differently from the go ones, but it might be an issue in a similar kind of area.

If I change the default values to empty for optional fields, the validation goes fine.
I think the same way it is handled in sdk-go with omitempty, If I am not wrong.

Yes indeed.
Specifically for go, omitempty only with pointers.

Also, comparing the datatypes of the fields for the events in jsonschema(/go-sdk) vs spec, most of the types in jsonschema are string but they are defined as URI, Enum, Purl and URI-Reference.
I think it should follow the rules from spec right?, In that case all the default values will be set to null

Thanks @rjalander - you are right, the spec is more specific than the JSONSchema today in a few places.
For URI and URI reference, that's something that was hopefully fixed in https://github.com/cdevents/spec/pull/116 - so that should solve itself once you work on the latest version.
For enums, AFAIK everything which is an enum is defined so in the schema, if you have examples where that is not the case please let me know, so we can fix that.
For purls, I don't think it's possible to enforce that format today in JSONSchemas. That's something we can work on together with the purl and JSONSchema communities. In the meanwhile, we have a gap between what can be enforced in the schema and what is documented in the spec.
When we work on generating the spec docs from the schema, we'll need a way to handle that.
In terms of SDKs, for the golang SDK for now I have a hack in place, it looks for fields called "artifactId" and it enforces the "purl" format for them. In future we may need a more general solution for that.

That would weaken the schema, it would say that we allow for the field to be set and empty, which I would prefer to avoid.
Isn't there any option in the java library that renders to JSON to not render unset fields?

Ok,
yes we can use jackson library when serializing the object to exclude optional unset/null fields, before validating against jsonschema.
This way the resultant CDEvent data will not have any optional fields itself when unset, If that is fine.(This might be different when comparing with the go-sdk, the optional fileds set to empty when unset in the CDEvent data) ?

Empty optional fields are not rendered in the go SDK, or else the json would fail validation, like it happened for the java sdk

Ok, will go with this and create a PR for not to render optional fields with null. Thank you.

Closing, as the PR to fix the issue is merged. https://github.com/cdevents/sdk-java/pull/55


Unable to upgrade EKSv1 cluster on upgrade from v2.4 to v2.6

Rancher Server Setup

Rancher version: v2.4.16 upgrade to v2.6.0-rc1
Installation option (Docker install/Helm Chart): HA helm

Information about the Cluster

Kubernetes version: v1.18
Cluster Type (Local/Downstream): EKS

Describe the bug

Unable to upgrade EKSv1 cluster after Rancher upgrade from v2.4 to v2.6
To Reproduce

Bring up Rancher v2.4.16
Provision an EKSv1 cluster. k8s version v1.18
After cluster becomes available, upgrade Rancher to v2.6.0-rc1
Upgrade the EKS cluster to k8s version v1.19
Result
Cluster becomes stuck in error state. Errors with Default ami of region us-east-2 for kubernetes version 1.19 is not set

Expected Result

User should be able to upgrade k8s version of an EKSv1 cluster.

I am block now because I don't have access to the China regions of AWS. Once I am able to update the AMIs for these regions, I will be ready for a PR.

Tested on Rancher v2.6-head version 6cb1847 and master-head version c58f952 with the following steps:

Bring up Rancher v2.4.16
Provision an EKSv1 cluster. k8s version v1.18
After cluster becomes available, upgrade Rancher
Upgrade the EKS cluster to k8s version v1.19

Result:
Cluster is upgraded to v1.19 successfully.


Smoketest: flaky preferences test

It happens quite rarely but these failures still happen in the smoketest:
2018-04-20T08:44:54.6730078Z   1) Test Preferences turns off editor line numbers and verifies the live change:
2018-04-20T08:44:54.6730629Z      Error: timeout of 20000ms exceeded. Ensure the done() callback is being called in this test.
2018-04-20T08:44:54.6731088Z       at Timeout.<anonymous> (D:\a\1\s\node_modules\mocha\lib\runnable.js:226:19)
2018-04-20T08:44:54.6731361Z
2018-04-20T08:44:54.6732236Z   2) Test Preferences changes 'workbench.action.toggleSidebarPosition' command key binding and verifies it:
2018-04-20T08:44:54.6733022Z      Error: timeout of 20000ms exceeded. Ensure the done() callback is being called in this test.
2018-04-20T08:44:54.6733670Z       at Timeout.<anonymous> (D:\a\1\s\node_modules\mocha\lib\runnable.js:226:19)

I've only seen it happening on Windows: https://monacotools.visualstudio.com/Monaco/_build/index?buildId=38457&_a=summary&tab=artifacts

Test Preferences turns off editor line numbers and verifies the live change
Times out with:
[2018-04-20T08:43:47.569Z] getElements .line-numbers

Test Preferences changes 'workbench.action.toggleSidebarPosition' command key binding and verifies it
Times out with:
[2018-04-20T08:44:07.674Z] getElements .part.activitybar.right

smoketest.log

We probably need a bit more logging here. Maybe we can also attach the user settings into the build artifacts and see whether the smoketests messed it up.

Looks like the first test that is writing into the settings caused some errors. Is there a screenshot while writing in to settings and saving it?

None 😄 But we can add

Just hit again: https://vscode.visualstudio.com/VSCode/_build?buildId=1782

@joaomoreno Is this still flaky?

Let's close it.


Fix #2606 lowering of optional.setattr

Setattr on an optional type should redirect to the inner type but the redirection was missing.

Same tracemalloc fail on Python 3.5 as the other PR.  Should we raise the threshold on that test a bit?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f86c615). Click here to learn what that means.
The diff coverage is 81.81%.

@@           Coverage Diff            @@
##             master   #2610   +/-   ##
========================================
  Coverage          ?   86.3%
========================================
  Files             ?     320
  Lines             ?   66729
  Branches          ?    7538
========================================
  Hits              ?   57593
  Misses            ?    7921
  Partials          ?    1215


Docker warnings when using DDEV: "The HOST_DOCKER_INTERNAL_IP variable is not set" - docker-compose v2 beta

I recently installed Lando on the same machine as DDEV. As part of this, I also had my Docker settings reset, so while I was at it, I also updated Docker for Mac.
When switching between Lando and DDEV projects, I have been pretty good at using lando poweroff and ddev poweroff, but when using DDEV, I get the following warnings:
WARN[0000] The HOST_DOCKER_INTERNAL_IP variable is not set. Defaulting to a blank string.
WARN[0000] The TZ variable is not set. Defaulting to a blank string.
WARN[0000] The TZ variable is not set. Defaulting to a blank string.
WARN[0000] The HOST_DOCKER_INTERNAL_IP variable is not set. Defaulting to a blank string.
WARN[0000] network default: network.external.name is deprecated in favor of network.name

So, far, they seem harmless, but...
Any idea on how I can get things configured correctly?
-mike

Hi Mike - You have been canaried into the experimental new docker-compose, which is not yet functional. Please turn off the experimental setting for that in docker's experimental settings.
Note that current ddev v1.17.7 will refuse to run if the experimental docker-compose is installed.

Safe to assume that's something that Lando did when I installed it? Any idea if that feature is required by Lando?
If I disable it, I won't need to reset my Docker for Mac again, will I?
-mike

No, this is docker that did it to you. Has nothing to do with Lando. And Lando doesn't work with the experimental docker-compose either.
This is a result of Docker "canarying" you into an experimental feature which is not ready yet.

https://github.com/docker/for-mac/issues/5800

Disabling it will have no impact on your Docker Desktop.... except that you'll have a usable docker-compose.

Roger that. I did a ddev poweroff, disabled Docker Composer V2, then started things back up again. So far, so good.
thanks,
-mike

Closing.


Multiple colors in line.

Hi, I have a question.
my system receives data undefined, that generates empty spaces in the line.
What I'm looking for is some way to continue the line of another color when the value is undefined or null.
Expected Behavior

Current Behavior
https://jsfiddle.net/palaceslittle/sehf31cy/1/

Environment

Chart.js version: 2.7.0
Browser name and version: Google Chrome

@nawelittle there's no direct way to do this. You might have a good chance by writing a plugin that draws these extra lines the way you need

@nawelittle i solved problem with multi color line by adding custom chart type:
  Chart.defaults.multicolorLine = Chart.defaults.line;
  Chart.controllers.multicolorLine = Chart.controllers.line.extend({
    draw: function(ease) {
      var
        startIndex = 0,
        meta = this.getMeta(),
        points = meta.data || [],
        colors = this.getDataset().colors,
        area = this.chart.chartArea,
        originalDatasets = meta.dataset._children
          .filter(function(data) {
            return !isNaN(data._view.y);
          });

      function _setColor(newColor, meta) {
        meta.dataset._view.borderColor = newColor;
      }

      if (!colors) {
        Chart.controllers.line.prototype.draw.call(this, ease);
        return;
      }

      for (var i = 2; i <= colors.length; i++) {
        if (colors[i-1] !== colors[i]) {
          _setColor(colors[i-1], meta);
          meta.dataset._children = originalDatasets.slice(startIndex, i);
          meta.dataset.draw();
          startIndex = i - 1;
        }
      }

      meta.dataset._children = originalDatasets.slice(startIndex);
      meta.dataset.draw();
      meta.dataset._children = originalDatasets;

      points.forEach(function(point) {
        point.draw(area);
      });
    },
  });

@EgorOvechkin Hi, first of all thanks for answering.
Do you have an example working please? Implement this library recently.

@nawelittle  there are example

If you want the spanGaps option to work properly (i.e. see gaps for nulls - which is the Charts.js default), then change the following line in @EgorOvechkin 's example above:
      .filter(function(data) {
        return true; // copy all points
      });

Any way to access the data for each line segment? I've been digging through the console trying to find that, but to no avail. I have a single line, with 3 properties (a date stamp which is my x axis, a speed which is my y axis, and a heading which is another property).  This example works great, but I'd like to change the color of each line segment by that 3rd "heading" property. Any ideas?

The way I do it is build up that data set of datetimes and values, then build another data set of the same length with the colours I want the line to be (I change between two colours on each line, one to represent online data and one to represent offline). Then I push that data into the timelineConfig.data.dataset with the function below:
You could do the same thing, where you loop through all your data, look for the heading value, choose the appropriate colour, build up your color array, then pass it in.
params:
settings (json) = {"LineCode":"1607-18696","SensorId":18696,"Label":"Temperature","Unit":"°C","Color":null,"FillColor":"rgba(28,168,221,.03)"}
data = [{"t":"2020-02-14T12:00:00","y":19.2},{"t":"2020-02-14T12:02:00","y":15.2}, ...]
colors = ['rgb(40,167,69)','rgb(40,167,69)','rgb(28,117,48)', ...]

	_PushDataSet : function(settings, data, colors) {
		this.timelineConfig.data.datasets.push({
			label: settings.Label,
			unit: settings.Unit,
			data: data,
			colors: colors,// for multicolorLine - first color is not important

			fill: settings.FillColor !== null,
			backgroundColor: settings.FillColor,

			borderColor: settings.Color, // needed for tooltip
			//pointBorderColor: settings.Color,
			//pointBackgroundColor: settings.Color,
			//pointHoverBackgroundColor: settings.Color,
			//pointHoverBorderColor: settings.Color,
			pointRadius: 0, //1,
			pointHoverRadius: 0, //1,

			lineTension: 0.25,
			pointHitRadius: 5
		})
	},

That's a solid idea - will try that out.

Hi,
The Solution is to develop your own chart,you can easily create a new custom chart with this command:
Chart.defaults.YOUR_CUSTOM_CHART = some default configuration.
For example I wanna extend default configuration of Line chart in chart.js
simply I would write:
Chart.defaults.YOUR_CUSTOM_CHART = Chart.defaults.line;
Since we wanna draw a continuous line even if some of our points are “null” or “undefined” values,
we should develop a custom draw() for our chart and extend our “line controllers” to have this custom draw function.
Chart.controllers. YOUR_CUSTOM_CHART = Chart.controllers.line.extend({
draw: function(ease){
// your custom implementation for draw function.
}
});
I’ve developed a simple custom chart(considering “null” and “undefined” values) with overridden “draw” function which is also a solution to asked issue.
multi-color-inline


Cleanup

Also fixes https://github.com/EngoEngine/engo/issues/282

audio_unsupported.go:6:2: "log" imported but not used

Once it builds, it LGTM.


Split Door Bolt functionality out of AirlockDoor

About the PR

The code controlling bolting / unbolting has been split out of AirlockDoorComponent into DoorBoltComponent
AirlockDoorSystem has also been split
Note: I've simplified an earlier PR #16189 : Here we have JUST the refactoring with no new functionality. Expect code moving and changing from AirlockSystem to DoorBoltSystem

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

Just refactoring, nothing players will notice.

@0x6273 - I've split the firelock branch #16189 and have made the fixes you suggested there on this branch which is just refactoring.

I dont really get whats the point of separating something so connected to airlocks but eh, also, doors dont have wires and dont do much with bolts except handling some logic for airlocks so this has to either be renamed jammed instead of bolted or rename the component/system airlockbolt

I'm adding bolts to Firelocks https://github.com/space-wizards/space-station-14/pull/16189 - these are not airlocks.

I'm now going to wait for a code review before I merge master into this branch.

Thanks! :)


BLOCKED: Fixes #741

Removes dynamic require statements. Generates an index.ts to eagerly load all APIs.
See #741
BLOCKED: Need to run the generator, but it no longer has access to the code snippet fragments.

Codecov Report

Merging #856 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
+ Coverage    88.3%   88.38%   +0.07%
==========================================
  Files          16       16
  Lines        1377     1360      -17
  Branches      108      106       -2
==========================================
- Hits         1216     1202      -14
+ Misses         94       92       -2
+ Partials       67       66       -1

Impacted Files
Coverage Δ

test/test.discover.ts
75.75% <100%> (+3.34%)
:arrow_up:

lib/googleapis.ts
70.58% <100%> (-5.78%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f68334...f656fde. Read the comment docs.