"hotspot_login_required" always false

I would like to use this tool as part of a little project I am working on. I am still playing around with it but I have noticed a bug or perhaps it is just an issue with my curl installation.
hotspot_login_required will always return false - even if the hotspot requires a login. I have had a look at the code and I can see wifiwand calls curl to check for a 302 redirect. This works fine when the verbose flag is set on curl but using it without (which your code does) returns nothing.

x@ba68d4b0 ~ % curl --max-time 3 http://captive.apple.com
x@ba68d4b0 ~ % wifi-wand i
Error obtaining public IP address info, proceeding with everything else:
767: unexpected token at ''
{
"wifi_on" => true,
"internet_on" => true,
"hotspot_login_required" => false,
"interface" => "en0",
"network" => ".@ AIS SUPER WiFi",
"ip_address" => "<IP_ADDRESS>",
"mac_address" => "50:ed:3c:53:cb:36",
"nameservers" => [
[0] "<IP_ADDRESS>",
[1] "<IP_ADDRESS>"
],
"timestamp" => 2024-04-24 13:17:04 +0700
}

While the idea of checking for a 302 redirect is sound. I do wonder if all hotspots will behave this way. I'm pretty sure I have had hotspots return 200 but still require a login.
MacOS seems to use some sort of method of checking if a WiFi connection needs a login or not as when you click on the AP a small window will appear letting you input your login details if required. Would be interesting to know how MacOS handles that. I might try to investigate that.
Anyway, just letting you know about the issue. Since I'm in Thailand just now I'll play around with a few hotspots and see how they interact with apples captive portal.

It was almost five years ago, May 2019, when I wrote the code to determine whether or not a hotspot login was required. At the time I was aware that there was a lot of complexity involved in getting this information and that my solution was only partial. I judged that, for my own use at least, it was ok if it failed on the edge cases.
Also, at the time, the text test did work without the need for curl's verbose flag.
Thank you for bringing this up. The environment on which this utility relies changes over time, and with clearer thinking and better information, changing the implementation or even removing the feature may be the better way. I'm open to feedback from you and others about this.
Meanwhile I will test this at various places to see how it behaves. Feel free to leave more feedback here. Any research you can do, and/or code you can provide, will be appreciated.
Also, as a side note, I don't know anything about the folks who use this software, and it's encouraging to hear from you. I just started a discussion at https://github.com/keithrbennett/wifiwand/discussions/27 inviting people to say how they use this software and what they might like to see in the future.

Given that there is no realistic expectation that there is a satisfactory solution to all instances of this test, or that I would find it if there were one, I have removed the hotspot_login_required informational item in version 2.18.0, and will close this issue.
If anyone wants to try to find a good solution, feel free to reopen this or post a new issue.
Thanks again to @Anonymousey for raising the issue, removing the erroneous behavior improves the quality of this project.


Zeit deployments previews unresponsive API

Describe the bug
Pre-deploys generated by Zeit are randomly stuck and the API calls timeout. Pages usually show a loading spinner then an The Open Collective Server is momentarily unreachable error. I personally rely a lot on them for testing contributor's PRs and often have to re-deploy manually.
To Reproduce
Example: https://opencollective-frontend-adlzxrjqdz.now.sh/babel
Steps to reproduce the behavior:

Open a PR on frontend
Randomly, the pages that make API calls timeouts

Screenshots

Additional context
Logs when the request fails:

error: middlewareError {"meta":{"error":{"errno":"EAI_AGAIN","code":"EAI_AGAIN","syscall":"getaddrinfo","hostname":"api-staging-direct.opencollective.com"},"level":"error","message":"uncaughtException: getaddrinfo EAI_AGAIN api-staging-direct.opencollective.com\nError: getaddrinfo EAI_AGAIN api-staging-direct.opencollective.com\n    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:60:26)","stack":"Error: getaddrinfo EAI_AGAIN api-staging-direct.opencollective.com\n    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:60:26)","exception":true,"date":"Wed Jan 15 2020 15:49:21 GMT+0000 (Coordinated Universal Time)","process":{"pid":27,"uid":0,"gid":0,"cwd":"/usr/src/frontend","execPath":"/usr/local/bin/node","version":"v12.13.1","argv":["/usr/local/bin/node","/usr/src/frontend/dist/server"],"memoryUsage":{"rss":127574016,"heapTotal":77574144,"heapUsed":70501384,"external":1681014}},"os":{"loadavg":[2.6708984375,2.8857421875,2.46533203125],"uptime":3425273},"trace":[{"column":26,"file":"dns.js","function":"GetAddrInfoReqWrap.onlookup [as oncomplete]","line":60,"method":"onlookup [as oncomplete]","native":false}],"req":{"url":"/api/graphql","headers":{"host":"opencollective-frontend-adlzxrjqdz.now.sh","x-forwarded-host":"opencollective-frontend-adlzxrjqdz.now.sh","x-real-ip":"<IP_ADDRESS>","x-forwarded-for":"<IP_ADDRESS>","x-forwarded-proto":"https","x-now-id":"7rxdd-1579103283331-711174082f52","x-zeit-co-forwarded-for":"<IP_ADDRESS>","content-length":"2287","user-agent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0","accept":"/","accept-language":"en-US,en;q=0.5","accept-encoding":"gzip, deflate, br","content-type":"application/json","authorization":"","origin":"https://opencollective-frontend-adlzxrjqdz.now.sh","dnt":"1","referer":"https://opencollective-frontend-adlzxrjqdz.now.sh/","x-now-trace":"zrh1,bru1,sfo1"},"method":"POST","httpVersion":"1.1","originalUrl":"/api/graphql","query":{}}}}

I'm opening a ticket about this issue with Zeit now.

The easy answer for them will be to say that their API v1 is about to be deprecated and that we should not be using it.

@znarf Negative. There are a few layers of this problem that I've clarified on the ticket request:

When using Now 1.0, it can take a while for the server to warm up if you are not using a fixed scaling configuration.
EAI_AGAIN is a Docker related error and we can't fix it at the platform level. We do recommend that you try other Dockerfiles to see if it improves.

Now 1.0 will be deprecated this year and we do recommend our users that they move away from the platform if they need a serverful offering. The future for us is to provide the best workflow and experience for frontend developers through static and serverless deployments.

@paulogdm Sorry, I deleted my earlier comment because I thought it was not appropriate here.
Thank you for helping and providing your input again, much appreciated! We don't plan to go serverless yet and so Now 1.0 is unfortunately still the best platform for our case!

Does not happen anymore since we migrated to Now V2 :rocket:


[SPARK-14578] [SQL] Fix codegen for CreateExternalRow with nested wide schema

What changes were proposed in this pull request?
The wide schema, the expression of fields will be splitted into multiple functions, but the variable for loopVar can't be accessed in splitted functions, this PR change them as class member.
How was this patch tested?
Added regression test.

cc @marmbrus @cloud-fan

Test build #55651 has started for PR 12338 at commit 4a472de.

Test build #55651 has finished for PR 12338 at commit 4a472de.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55651/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

One more question, actually there are some more places that we use local variables as the input for expressions, e.g. CodeGenContext.currentVars in whole stage codegen, LambdaVariables in MapElements and typed filter, should we make them all class members, or is there a more general way to do it?

This is used for non-whole-stage codegen, also MapObjects does not support interpret mode, or it's better to fallback. Class member may prevent JIT compiler to do more optimization, so we should not aggresively put all of them as class members.
Merging this into master.


Propagated EKS NP CF stack tags to volumes

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets
-

License
Apache 2.0

What's in this PR?

Propagated EKS NP CF stack tags to volumes.
Why?

Customer feature request.
Note: manually applying stack tags onto root EBS volumes, because automatic tag propagation for Amazon EBS volumes created from block device mappings is not supported as of 2021-03-11, source

All stack-level tags, including automatically created tags, are propagated to resources that CloudFormation supports. Currently, tags aren't propagated to Amazon EBS volumes that are created from block device mappings.

Additional context

Requires an additional ec2:CreateTags permission for the node instance role in order for the instance to be able to create the tags from the node pool stack template values.
Requires documentation update on minimal privileges for the node instance role.
Tested using cluster create (node pool create), node pool update and cluster update (node pool update 2).
Checklist

[X] Implementation tested (with at least one cloud provider)
[X] Code meets the Developer Guide
~OpenAPI and Postman files updated (if needed)~
[ ] User guide and development docs updated (if needed)
~Related Helm chart(s) updated (if needed)~

To Do

[ ] Document additional node instance role permission requirement (ec2:CreateTags), see Additional context for details.

@orymate if you mean the user data manual create-tags part, I share your feelings, unfortunately I found no alternative solutions aside from doing the same from higher level code (but the template is the single point which connects all possible use cases).
I'm hoping tag propagation to volumes is going to be soon implemented automatically just like it is for every other stack derivative resource (no indication of this though from AWS side).
(Also I'm going to fixup the fixup commit and I'm aware I missed the correct fixup syntax, it's just an indicator for me for the rebase-onto-latest-master-before-merge process.)


bitcoind RPC Errors

We're running into two distinct bitcoind RPC errors:

JsonRpc(Transport(SocketError(Error { kind: TimedOut, message: "connection timed out" }))) hereafter "timeout"
JsonRpc(Transport(SocketError(Os { code: 35, kind: WouldBlock, message: "Resource temporarily unavailable" }))) hereafter "resource unavailable"

timeout
I took this as far as I could, came up with a self-contained repro, and opened this issue: https://github.com/apoelstra/rust-jsonrpc/issues/67
resource unavailable

Create self-contained reproduction
Does the binary matter?
Questions in https://github.com/bitcoin/bitcoin/issues/25724#issuecomment-1198408118

This might be a bug in rust-jsonrpc, or rust-bitcoincorerpc. Some things to try:

try +SO_REUSEADDR, +SO_REUSEPORT, and -SO_LINGER
try changing 15s default timeout to see if I can get a different timeout
try figuring out why the timeout is always 15s
try implementing hyper transport (can upstream behind a feature flag)
remove com.apple.quarantine from bitcoind (or add to homebrew)
try eliminating Rust RPC from repro

Closing in favor of more specific issues.


Remove version: taers232c.GAMADV-XTD3 version 6.80.01

This version is older than what has been set in max-versions-to-keep by the publisher.
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/taers232c/GAMADV-XTD3/releases/download/v6.80.01/gamadv-xtd3-6.80.01-windows-x86_64.msi
OK
(Automated message - build 913)


Add GitHub Action Maven Publish

Currently this runs when a release is manually created. We could run it every push, and look for a version tag. Then use that version tag to create a release and attach the artifacts.

I should've added more comments, the plugin is necessary to get a consistent jar name and include dependencies. We can definitely do that instead of requiring 2 downloads, but the classloader expects the natives to be outside the jar. Ultimately, it could self expand if I can't manipulate the classloader.


babylon/espree option alignment

Babylon options: https://github.com/babel/babel/blob/v6.2.2/packages/babylon/src/options.js
cc: @hzoo

Ah ok thanks - looking at the readme thats the only options now ok. https://github.com/babel/babel/tree/v6.2.2/packages/babylon
Can you add functionSent to the plugins list too?

Never mind i'l do it - thanks!

Made<EMAIL_ADDRESS>

Sorry, I stepped away from my computer - but I see you added functionSent - thanks!


Update dependencies

What kind of changes does this PR include?

Changes to Starlight code

Description

Upgrade dependencies of the main Starlight package

size-limit report 📦

Path
Size

/index.html
13.13 KB (0%)

/_astro/*.js
16.54 KB (0%)

/_astro/*.css
9.05 KB (0%)


Liquid Build issue on Partners/EngineYard.md

We get an error in Travis ci every once in a while that says
Liquid Exception: undefined method `match' for nil:NilClass

Hello @mbernier,Thanks for your suggestion or question! In an attempt to clear out our backlog,                                              we are closing out issues over 90 days old.                                             If this is still an issue, please feel free to reopen it.                                             Team SendGrid DX-Docs


throwing RuntimeException instead of returning FALSE

As we discussed yesterday with narfbg, I modified my last solution. Now we throw a RuntimeException instead of returning FALSE.
I also added this modification to the changelog.

That's good so far (changelog message needs some styling), but with an exception thrown there, you may as well remove the log_message() call and the db_debug condition - an uncaught exception will both log and display a fatal error in dev mode.

On another note ... I just noticed a call to initialize() that obviously will need to be handled differently with this change, and there are probably more similar cases to cover.
If you don't mind, I'll manually pull your commit (so you are credited in the commits) and will refactor the rest myself. Is that ok with you?

Yes, thank you for all. :)


Support source code in function template

Hello,
doxygen supports the showing of source code inplace of function definition: Example
It would be nice to get a simmilar detailed view with call graph and source code.

Thank you for your feedback, I will add it to my TODO list.


corrected spelling

Corrected "Activing" to "Activating".

Is this PR a dupe now of the one I just merged? Can you confirm and then close it out?


api < 21

hi
your library seems don't work pre 21
i test on 4.1.1 and 4.2.2 and 4.4.4

oww,  ok. I will check it. thank you..
On Mon, Feb 20, 2017, 9:05 PM Davood Jafari<EMAIL_ADDRESS>wrote:

hi
your library seems don't work pre 21
i test on 4.1.1 and 4.2.2 and 4.4.4
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sylversky/fontreplacer/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFv3IJllTtFl-cs5hquxIpHEQxITHJthks5reZ2ggaJpZM4MGN0b
.


moved imports of sass files to the end of the import list

 ensure all imports of sass files are below all other imports


Date Functions

Description
Add the following functions:

past
future
between
recent
soon
month
weekday

Proposed solution
Use date-fns
Alternatives considered
No
Do you want to create a pull request?
No

Please assign me this issue.

@geromegrignon you can make the changes now, please


Exclude game state from player_option!

This PR removes game state from the argument list to player_option!. Most of the time this argument isn't needed, but we've provided a fallback so that it's called if nothing else is caught.

bors r+


Great work!

Hello, I have been trying to use your code with arduino uno and a adafruit motor shield V2 to no avail. Any chance you could help me under stand how to control the motors only so I can add it to my working servo code?

Yes, I have it so I can control the servos with the joystick but can not get beyond that. `#include <Wire.h>
#include <Adafruit_MotorShield.h>
#include "utility/Adafruit_MS_PWMServoDriver.h"
// Create the motor shield object with the default I2C address
Adafruit_MotorShield AFMS = Adafruit_MotorShield();
// Or, create it with a different I2C address (say for stacking)
// Adafruit_MotorShield AFMS = Adafruit_MotorShield(0x61);
// Set up the left motor on port M4
Adafruit_DCMotor *leftMotor = AFMS.getMotor(1);
// Set up the right motor on port M3
Adafruit_DCMotor *rightMotor = AFMS.getMotor(2);
void setup() {
Serial.begin(9600);           // set up Serial library at 9600 bps
Serial.println("Adafruit Motorshield v2 - Robot Test!");
AFMS.begin();  // create with the default frequency 1.6KHz
//AFMS.begin(1000);  // OR with a different frequency, say 1KHz
}
void loop() {
// Set the speed to start, from 0 (off) to 255 (max speed)
leftMotor->setSpeed(100);
rightMotor->setSpeed(100);
leftMotor->run(FORWARD); //LEFT MOTOR FULL STEAM AHEAD!
rightMotor->run(FORWARD); //RIGHT MOTOR FULL STEAM AHEAD!
}'

I assume you already have the Nunchuck-Arduino adapter.
I'll try to provide a refactored, English example in the following days that you can fully understand.

Wait! It must be wireless?
`#include <Wire.h>
#include <Servo.h>
#include <Adafruit_MotorShield.h>
#include "utility/Adafruit_MS_PWMServoDriver.h"
// check the pin before connecting to the motor shield
#define led_pin                     13
#define music_pin                   6
#define ForwardSpeed                255
#define ReverseSpeed                200
#define TurningSpeed                145
#define pwrpin PORTC3
#define gndpin PORTC2
// Create the motor shield object with the default I2C address
Adafruit_MotorShield AFMS = Adafruit_MotorShield();
// Set up the left motor on port M4
Adafruit_DCMotor *leftMotor = AFMS.getMotor(1);
// Set up the right motor on port M3
Adafruit_DCMotor *rightMotor = AFMS.getMotor(2);
Servo servoLeft;          // Define left servo
Servo servoRight;         // Define right servo
static uint8_t nunchuck_buf[6];   // array to store nunchuck data,
void z_button_handle(){
/*

this function will called repeatedly
when z buttion is pressed
*/
digitalWrite(led_pin, HIGH);
Serial.println("Z-button is pressed");
}

void c_button_handle(){
/*

this function will called repeatedly
when c buttion is pressed
/
tone(music_pin, 1000); / Generate tone of 1kHz on tone pin*/
Serial.println("C-button is pressed");
}

void motor_control(int x, int y){
/*

function to control the direction of dc motor
depending on the angle of servo motor
whic in turn depend on accelerometer

x: control the left motor
y: control the right motor

if angle of servo is greater than 92  the motor will move forward
if angle of servo is less than 88 the motor will move backwar
in between 92 and 88 the motor should remain off
*/
if(x > 92){
leftMotor->setSpeed(ForwardSpeed);
leftMotor->run(FORWARD);
}else if(x < 88){
leftMotor->setSpeed(ReverseSpeed);
leftMotor->run(BACKWARD);
}else{
leftMotor->run(RELEASE);
}

if(y > 92){
rightMotor->setSpeed(ForwardSpeed);
rightMotor->run(FORWARD);
}else if(y < 88){
rightMotor->setSpeed(ReverseSpeed);
rightMotor->run(BACKWARD);
}else{
rightMotor->run(RELEASE);
}
}
void setup()
{
Serial.begin(19200);
servoLeft.attach(10);  // Set left servo to digital pin 10
servoRight.attach(9);  // Set right servo to digital pin 9
nunchuck_setpowerpins(); // use analog pins 2&3 as fake gnd & pwr
nunchuck_init(); // send the initilization handshake
AFMS.begin();
// turn off both motor initially
leftMotor->run(RELEASE);
rightMotor->run(RELEASE);
// make led pin output
pinMode(led_pin, OUTPUT);
Serial.print ("Finished setup\n");
}
void loop()
{
nunchuck_get_data();
// map nunchuk data to a servo data point
int x_axis = map(nunchuck_buf[0], 23, 222, 180, 0);
int y_axis = map(nunchuck_buf[1], 32, 231, 0, 180);
// move servo to desired position based on Wii nunchuk reading
servoLeft.write(x_axis);
servoRight.write(y_axis);
// DC motor control
motor_control(x_axis, y_axis);
// Button functionality
if ((nunchuck_buf[5] >> 0) & 1){
// z button is pressed
z_button_handle();
}else{
digitalWrite(led_pin, LOW);
}
if ((nunchuck_buf[5] >> 1) & 1){
// c button is pressed
c_button_handle();
}else{
noTone(music_pin);
}
// un-comment next line to print data to serial monitor
//  nunchuck_print_data();
}
//
// Nunchuck functions
//
// Uses port C (analog in) pins as power & ground for Nunchuck
static void nunchuck_setpowerpins()
{
DDRC |= _BV(pwrpin) | _BV(gndpin);
PORTC &=~ _BV(gndpin);
PORTC |=  _BV(pwrpin);
delay(100);  // wait for things to stabilize
}
// initialize the I2C system, join the I2C bus,
// and tell the nunchuck we're talking to it
void nunchuck_init()
{
Wire.begin();                      // join i2c bus as master
Wire.beginTransmission(0x52);     // transmit to device 0x52
Wire.write(0x40);            // sends memory address
Wire.write(0x00);            // sends sent a zero.
Wire.endTransmission();     // stop transmitting
}
// Send a request for data to the nunchuck
// was "send_zero()"
void nunchuck_send_request()
{
Wire.beginTransmission(0x52);     // transmit to device 0x52
Wire.write(0x00);            // sends one byte
Wire.endTransmission();     // stop transmitting
}
// Receive data back from the nunchuck,
int nunchuck_get_data()
{
int cnt=0;
Wire.requestFrom (0x52, 6);     // request data from nunchuck
while (Wire.available ()) {
// receive byte as an integer
nunchuck_buf[cnt] = nunchuk_decode_byte(Wire.read());
cnt++;
}
nunchuck_send_request();  // send request for next data payload
// If we recieved the 6 bytes, then go print them
if (cnt >= 5) {
return 1;   // success
}
return 0; //failure
}
// Print the input data we have recieved
// accel data is 10 bits long
// so we read 8 bits, then we have to add
// on the last 2 bits.  That is why I
// multiply them by 2 * 2
void nunchuck_print_data()
{
static int i=0;
int joy_x_axis = nunchuck_buf[0];
int joy_y_axis = nunchuck_buf[1];
int accel_x_axis = nunchuck_buf[2]; // * 2 * 2;
int accel_y_axis = nunchuck_buf[3]; // * 2 * 2;
int accel_z_axis = nunchuck_buf[4]; // * 2 * 2;
int z_button = 0;
int c_button = 0;
// byte nunchuck_buf[5] contains bits for z and c buttons
// it also contains the least significant bits for the accelerometer data
// so we have to check each bit of byte outbuf[5]
if ((nunchuck_buf[5] >> 0) & 1)
z_button = 1;
if ((nunchuck_buf[5] >> 1) & 1)
c_button = 1;
if ((nunchuck_buf[5] >> 2) & 1)
accel_x_axis += 2;
if ((nunchuck_buf[5] >> 3) & 1)
accel_x_axis += 1;
if ((nunchuck_buf[5] >> 4) & 1)
accel_y_axis += 2;
if ((nunchuck_buf[5] >> 5) & 1)
accel_y_axis += 1;
if ((nunchuck_buf[5] >> 6) & 1)
accel_z_axis += 2;
if ((nunchuck_buf[5] >> 7) & 1)
accel_z_axis += 1;
Serial.print(i,DEC);
Serial.print("\t");
Serial.print("joy:");
Serial.print(joy_x_axis,DEC);
Serial.print(",");
Serial.print(joy_y_axis, DEC);
Serial.print("  \t");
Serial.print("acc:");
Serial.print(accel_x_axis, DEC);
Serial.print(",");
Serial.print(accel_y_axis, DEC);
Serial.print(",");
Serial.print(accel_z_axis, DEC);
Serial.print("\t");
Serial.print("but:");
Serial.print(z_button, DEC);
Serial.print(",");
Serial.print(c_button, DEC);
Serial.print("\r\n");  // newline
i++;
}
// Encode data to format that most wiimote drivers except
// only needed if you use one of the regular wiimote drivers
char nunchuk_decode_byte (char x)
{
x = (x ^ 0x17) + 0x17;
return x;
}
'  I almost figured it out, but now the motors relay on the joystick moving so angle of servo determines motor position(not ideal or easy)

My spanish brain overlooked servo motor part. Does this mean I am attempting a useless effort? ie the more can not be controlled via accel?

I'm curious about your hardware, is controlling both DC motors with another two servomotors a requirement?
I've managed to control quite precisely a simple, two wheels robot with just adjusting each motor speed; and in case of having them joined by an axis, I would use just a servomotor to control direction.

This kit https://learn.adafruit.com/adabox002/assembling-your-robot   And adafruit motor shield V2 and arduino uno. plus two servos and wii nunchuck wired(ordered wireless)

As I said, easiest way of controlling DC motors is just passing them different values and forgetting about using a servomotor for that. Here you have an example using a 1€ remote control kit.
In this specific case, I'd just use two accelerometers: one for speed (0 max backwards, 180 max forwards, 90 stopped) and another one for direction (extracting a decimal coeff between 0 and 1 from Nunchuck accel and multiplying each motor speed for coeff and (1-coeff), forgetting once again about using servos for that).
Do you get my idea?


Upstreaming S3 datapipes

Fixes #{issue number}
Changes

Added S3FileLister and S3FileLoader IterDataPipes.
Added pybind11 build for s3 io cpp files and python scripts.

TODO

[ ] clean up setup files and link pybind11 in CMAKE_PREFIX automatically.
[ ] remove aws cpp sdk dependency at build & pop exceptions when missing dependencies at usage.
[ ] new api changes for list_files.
[ ] expose timeouts, regions, credential settings.
[ ] benchmarks
[ ] thorough tests

@ydaiming Thanks for this contribution. Please add a readme describing how user's can use this feature.

Thanks @ydaiming.  It seems the definition of test_s3_lister_iterdatapipe() in test_remote_io.py is indented one level too much so it is not run during tests.  Also file_url = "s3://pt-s3plugin-test-data-west2/images/test" is inaccessible to me; if I change it to file_url = "s3://ai2-public-datasets/charades" the test runs fine for me.


Do not get load balancers in deleted or deleting status

What this PR does / why we need it:
Ignore the load balancers in deleting or deleted status when doing query from load balancing service.
Which issue this PR fixes:
fixes #576
Special notes for your reviewer:
Release note:

/test cloud-provider-openstack-acceptance-test-csi-cinder

/test cloud-provider-openstack-acceptance-test-lb-octavia

/test cloud-provider-openstack-acceptance-test-lb-octavia

/test cloud-provider-openstack-acceptance-test-lb-octavia

@mrhillsman @dims Could you please take a look at the CI failure, we can't merge any PR. Seems like it's related to the k8s master installation, but I'm not familiar with the CI job.

/test cloud-provider-openstack-acceptance-test-lb-octavia

/test cloud-provider-openstack-acceptance-test-lb-octavia

/test cloud-provider-openstack-acceptance-test-csi-cinder

/test cloud-provider-openstack-acceptance-test-e2e-conformance

/test cloud-provider-openstack-acceptance-test-e2e-conformance

/test cloud-provider-openstack-acceptance-test-k8s-cinder

/approve
/lgtm


[$500] Workspace -Assign Task-Random employee can edit/reassign task

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: @
Action Performed:
Precondition: Prepare 3 accounts:
A workspace admin
A workspace employee A (task creator)
A workspace employee B
Add all accounts to the workspace of the workspace admin
Should be executed after C2661791

Log in to a Staging.new.expensify.com
Navigate to the workspace #Announce room
Click on the task created by the workspace employee A
Edit the title of the task
Reassign the task
Edit the description of the task

Expected Result:
Employees who are non creators nor assigned should Not have permission to edit and reassign tasks created by other employees of the workspace.
Actual Result:
Employees who are non creators nor assigned should Have permission to edit and reassign tasks created by other employees of the workspace.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/6ea25f1f-9494-49b7-922c-e1ca688cd1a2

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a704827129d85780
Upwork Job ID:<PHONE_NUMBER>975758848
Last Price Increase: 2023-12-18

@allroundexperts
I believe this issue has already been fixed.
https://github.com/Expensify/App/pull/32165

Issue not reproducible during KI retests. (First week)

no longer reproducible


Crash (ikhal)

Using the latest git checkout, through khal-git in the AUR, I get a crash when trying to browse to the 29th February in ikhal. When trying to add an event directly using "khal new 29.02. ..." I get a "Cannot parse: '29.02. ...' error.
My default_timezone and local_timezone are set to 'GB'.
Traceback when using ikhal:
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/khal/ui/__init__.py", line 891, in start_pane
    loop.run()
  File "/usr/lib/python3.5/site-packages/urwid/main_loop.py", line 278, in run
    self._run()
  File "/usr/lib/python3.5/site-packages/urwid/main_loop.py", line 376, in _run
    self.event_loop.run()
  File "/usr/lib/python3.5/site-packages/urwid/main_loop.py", line 682, in run
    self._loop()
  File "/usr/lib/python3.5/site-packages/urwid/main_loop.py", line 719, in _loop
    self._watch_files[fd]()
  File "/usr/lib/python3.5/site-packages/urwid/raw_display.py", line 393, in <lambda>
    event_loop, callback, self.get_available_raw_input())
  File "/usr/lib/python3.5/site-packages/urwid/raw_display.py", line 493, in parse_input
    callback(processed, processed_codes)
  File "/usr/lib/python3.5/site-packages/urwid/main_loop.py", line 403, in _update
    self.process_input(keys)
  File "/usr/lib/python3.5/site-packages/urwid/main_loop.py", line 503, in process_input
    k = self._topmost_widget.keypress(self.screen_size, k)
  File "/usr/lib/python3.5/site-packages/urwid/wimp.py", line 643, in keypress
    return self._current_widget.keypress(size, key)
  File "/usr/lib/python3.5/site-packages/urwid/container.py", line 1128, in keypress
    return self.body.keypress( (maxcol, remaining), key )
  File "/usr/lib/python3.5/site-packages/khal/ui/__init__.py", line 728, in keypress
    return super().keypress(size, key)
  File "/usr/lib/python3.5/site-packages/urwid/container.py", line 2269, in keypress
    key = w.keypress((mc,) + size[1:], key)
  File "/usr/lib/python3.5/site-packages/urwid/container.py", line 1587, in keypress
    key = self.focus.keypress(tsize, key)
  File "/usr/lib/python3.5/site-packages/urwid/container.py", line 2269, in keypress
    key = w.keypress((mc,) + size[1:], key)
  File "/usr/lib/python3.5/site-packages/urwid/container.py", line 1128, in keypress
    return self.body.keypress( (maxcol, remaining), key )
  File "/usr/lib/python3.5/site-packages/khal/ui/calendarwidget.py", line 327, in keypress
    key = super(CListBox, self).keypress(size, key)
  File "/usr/lib/python3.5/site-packages/urwid/listbox.py", line 985, in keypress
    key = focus_widget.keypress((maxcol,),key)
  File "/usr/lib/python3.5/site-packages/khal/ui/calendarwidget.py", line 178, in keypress
    key = super(DateCColumns, self).keypress(size, key)
  File "/usr/lib/python3.5/site-packages/urwid/container.py", line 2283, in keypress
    self.focus_position = j
  File "/usr/lib/python3.5/site-packages/khal/ui/calendarwidget.py", line 139, in _set_focus_position
    self.on_date_change(self.contents[position][0].date)
  File "/usr/lib/python3.5/site-packages/khal/ui/__init__.py", line 764, in show_date
    self.eventscolumn.original_widget.current_date = date
  File "/usr/lib/python3.5/site-packages/khal/ui/__init__.py", line 307, in current_date
    self.eventcount = self.events.update_by_date(date)
  File "/usr/lib/python3.5/site-packages/khal/ui/__init__.py", line 243, in update_by_date
    'calendar ' + event.calendar, 'reveal focus') for event in events]
  File "/usr/lib/python3.5/site-packages/khal/ui/__init__.py", line 243, in <listcomp>
    'calendar ' + event.calendar, 'reveal focus') for event in events]
  File "/usr/lib/python3.5/site-packages/khal/ui/__init__.py", line 64, in __init__
    text = self.event.relative_to(self.this_date)
  File "/usr/lib/python3.5/site-packages/khal/khalendar/event.py", line 414, in relative_to
    body = self.summary
  File "/usr/lib/python3.5/site-packages/khal/khalendar/event.py", line 343, in summary
    bday = self._vevents[self.ref].get('x-birthday', None)
KeyError: '1456704000'

Looks like it's the same issue as #348

I'd like to split this into two reports, as it looks like two different issues.

see #353 for the Feb 29 issues.

and yes, the other part is a duplicate of #348. Closing as duplicate.


added plugin to analyze a point layer

Added a plugin that allows to select a points layer and to provide an output folder path, and it creates two csvs in the given folder,  one with the coords of all the points and the other with the distances and angles between each pair of consecutive points.
After installing brainreg-segment It can be run just by clicking here:

Created files have the following structure.
points.csv
id, coordx,  coordy,  coordz
0,   ..
1,   ..

measurements.csv

the angles and the distance/magnitude define the vector from point 1 to point2

point1_id, point2_id, distances, AP_angle, MP_angle
0,         ..
1,         ..

I also added an option to create random samples, which may be very useful for testing and maybe for us in the future: In this case it creates a point layer composed by random points.

@adamltyson, I'd like to know if this is how you imagined the tool and if the format of the output is as expected, if so, I can just proceed with the unit tests and adding robustness to the function and then I can merge.
Do not merge, pending unit tests.

Hi @juanma9613, thanks for working on this!
Generally it looks great, with pretty intuitive usage.
I've come across a couple of bugs. I've left a comment about an import error, but it also doesn't work for me with 2D data, with this error:
~/brainreg-segment/brainreg_segment/measurement/measurement.py in get_angles_and_distances_between_consecutive_points(point_layer=)
     35         # projecting the vector in the sagital plane is just removing
     36         #  the "y/mediolateral" coordinate
---> 37         segment_vector_zx = segment_vector[[2,0]]
        segment_vector_zx = undefined
        segment_vector = array([ 32.68457772,<PHONE_NUMBER>6])
     38         # for the angle, z is used as the first direction/axis and x as the other
     39         ap_angle = math.atan2(segment_vector_zx[1], segment_vector_zx[0])

IndexError: index 2 is out of bounds for axis 0 with size 2

More generally, a couple of things would be useful:

Use a native file dialogue to choose the output directory, you should be able to use magicgui for this, with a pathlib.Path type.
Show the results in the napari window somehow, rather than just exporting to csv.

It would also be super cool (but this can come later, or never) would be to visualise the angles, e.g. by adding color-coded lines joining up the points.
@FedeClaudi - I'd be interested to know your thoughts on this, is it useful for analysing probe tracks?

Hi @adamltyson  solved the bug with the layer names.
For the layers with points in 2d, what I did to solve it was to add a zero to the last dimension.
Changed [2.3, 4.5] for [2.3, 4.5, 0.0] which assumes it's in the plane x,y
To show the results in the napari window I can use a shapes or vector layer to show the vectors joining two points (that would show somehow the distances between consecutive points)
Not sure yet how to show angles, do you know a way to show text annotations?

Looks amazing guys, looking forward to trying it out!

Not sure yet how to show angles, do you know a way to show text annotations?

Yep, see e.g. https://napari.org/tutorials/applications/annotate_segmentation.html
More simply, the results could just be shown as a table in a widget, rather than overlaying everything on the data.

This feature is getting very cool!

After running the script it creates a shapes layer with the lines that join two consecutive points. Each line comes with three annotations, distance, ap_angle and mp_angle.
Something that can still be ambiguous in the visualization above is that the direction of the line is not clear, you don't know which is the start point and which is the end point. For the distance it doesnt matter, but it's definitely important for the angles.

Hey @juanma9613, this is looking great!
The only things I can think of that would be great are:

Make saving to file optional, e.g. the user can Run then Save. If I'm playing around with a new plugin, I'd rather not have to create some files that I'll then need to delete.
It wouldn't be very elegant, but the direction of the lines could be shown by labeling the points (1, 2, 3 etc), then the user can infer that the line between 1 and 2 is going in a specific direction.

Adding the results into table would be cool, but that's up to you.
Lastly, before we merge, could you use the linting tools (black and flake8)? They should be installed with pip install -e and  black ./ -l 79 and flake8 should either reformat the code, or provide guidance to pass the lint tests.
Thanks again!

@FedeClaudi @adamltyson Added a boolean to select if you want to save results to the folder or not (default to false).
@adamltyson following your recommendation I created a new layer which has the same coordinates as the provided points data and adds the enumeration of the points starting from 1. I know this is not the most elegant solution but we can improve it later if we come up with better ideas.

Regarding the table, I think that maybe we can first merge what we already have and let people use it. Maybe we can collect more feedback about how to show the results in a better way.
I also improved the documentation of the functions and ran black on the scripts and checked flake 8 suggestions as well, waiting to see if it passes the linter review.
Let me know what do you think about it and if we can merge it or if there's something else pending.
I think that these tools are very useful and I'll be here looking at the issues in order to contribute frequently. Please le me know if I can help in any computational geometry/ segmentation, data analysis/engineering, MLE or related tasks in any of your projects I will be glad to help.

Hi @juanma9613, this looks great thanks. I'll merge once I get a chance to have a quick play around with it. Happy to take a look at the table later. If you have any ideas we can track this in a new issue.
Flake still seems to be raising errors:
./brainreg_segment/measurement/measurement.py:2:1: F401 'enum.Enum' imported but unused
./brainreg_segment/measurement/measurement.py:6:1: F401 'typing.Optional' imported but unused
./brainreg_segment/measurement/measurement.py:6:1: F401 'typing.TYPE_CHECKING' imported but unused

There are lots of open issues in BrainGlobe! You'd always be very welcome to tackle one of these, or propose new features!
@FedeClaudi do you have any thoughts on this PR? I think it was your idea originally.

@adamltyson thanks, already sent the new commit which fixes the imports let me know your thoughts once you test it

Looks good! I'm getting errors with the latest version of Pooch, but I think that's a napari issue.
The only slight annoyance I can see is that the point labels appear only on one side of the point in 3D. This is very minor, and I'm happy to merge if you are.
Thanks again!

Hi,
I finally got a chance to try the new plugin.
I'm getting a ValueError when I hit Run, I think it has to do with displaying the text in napari since it saves the .csv files with the results correctly.
Otherwise it seems to work okay, but I would say there is space for an easy but important improvement: currently the distance measurement is given in what I guess is voxels (there's no indication of the unit in the csv file), but users might want to have measurements in microns (e.g. I do). I think the best solution would be for the user to specify the voxel sizes as 3 numbers in the widget and use that to scale the points coordinates before measuring the distance.
E.g. if I have a (2x 3) array  of two points and an array scale = np.array([4.5, 2.35, 2.35]), then:
points_um = points * scale
distance = np.linalg.norm(points_um[1] - points_um[2])

gives the distance in micrometers.

Hi @FedeClaudi , I've never seen a value error with the samples I created. Could you please share a little bit more about the point layer you used or the  traceback you got?
You are totally right about the scale, I was considering the units as raw numbers, because that's the way the point layer yields the .data attribute. Is there a way to get default units or does the user need to pass a scale array? I'm a little bit worried about making users pass this scale, I'm thinking that some times they may not know about the scale. Not sure if that may happen for certain people or if It can be solved just by setting a default scale as [1,1,1].

Hi,
Yeah I get it, hopefully users will know the scale of their data though! But yes I would leave a default value of 1, 1, 1.

Could you please share a little bit more about the point layer you used or the traceback you got?

I just created a point layer and clicked in 3/4 points across the volume. Is there a different way to do it?
Next time I get to play around with it I will paste the traceback.


Apply the buffer_points function to calculate 1km for high capacity stations

Used np.where to apply buffers.  Our check

@Antonio-John @paigeh1 Great work.
Do you remember we discussed previously that we might change the buffer distance if we ever got better information on how disability and age might affect walking distance. E.g. if we chose (and I am just picking example figures here) the buffer to for people 70-80 to be 250m and people 80+ to be 100m...
If you agree, maybe we can have a config setting to cover these potential changes later on. I know this was not in the original requirements and is therefore scope creep, but maybe we could have a config setting something like:
high_cap_buffer = 1000
low_cap_buffer = 500

Happy to hear your opinions!

We agree with this so we have added in the high_cap_buffer and low_cap_buffer into the config file.
We also loaded in config into the geospatial_mods.py because of the potential of additional buffers being added - we did not want to add several arguments into the function in the main script.


Fatal error: Uncaught Error: Class 'MyApp\User' not found

I have a class that i created in user.php file called User and i want to access this class in the ratchet chat.php and when i tray to define a variable and assign to this class like this userObj = new \MyApp\User ; the above error is occured ,its been 3 days i tray multiple methods in google and still the error here !!

Please post more of your code. This is not enough to help troubleshoot. Sounds like there's a problem with autoloading.


add dual stack and multi cidrs funcs

This PR adds all the dual stack funcs and multi cidrs func that are to be used from kubernetes/kubernetes and related repos.

@thockin @andrewsykim @dims please help review

/assign @thockin

/cc


Improved generation of random playernames

[+] Allowed for more than 100 random names to be requested
[*] All generated random names now follow the minecraft.net specifications for usernames

Updated the code to always provide a random username (unless more than 100.000 players are added to the server)
I just want to ask something though, is it really needed that they have "real" names?
Because I have never seen someone creating random names like this.

pretty sure he approves

+1 to this. Spaces in names really mess with tests that rely on commands.


[Improvement]: Print a warning when there is no Package.md when running bal pack

Description
Currently, we can pack a package without having a Package.md file. However when we try to push it to local repo or to the central, it throws an error asking us to have a Package.md.
Moreover, when pushing to the central we cannot have an empty Package.md but we can pack an empty Package.md during bal pack.
Describe your problem(s)
The user realizes that they have not packed a Package.md only when they try to push the package. He has to again add a md file, pack it and push which is cumbersome.
Describe your solution(s)
Introducing a warning diagnostic that warns,

if there is no Package.md when calling bal pack,
if  Package.md is empty

would be helpful as the user can identify and take corrective measures.
Related area
-> Other Area
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Hi @sanikabhalerao241
You can work on this issue.
To help you get started, here are some essential resources:

Understanding Ballerina Platform:
Learn what Ballerina is all about Ballerina Platform
How to Contribute:
Read our contributing guidelines to understand how you can contribute effectively: Contribution Guide
Contributing to the Ballerina Library:
If you're interested in contributing to our library, here are the guidelines: Library Contribution Guide
Learn Ballerina:
If you're new to Ballerina or want to enhance your skills, our official website offers a wealth of learning resources: Learn Ballerina
Get Help and Connect:
Ask technical questions on Stack Overflow with Ballerina tag  and join our Discord community Ballerina Discord

Hi @keizer619 Can I get this assigned to me if @sanikabhalerao241 haven't made a progress yet?

@Ishad-M-I-M Are you willing to work on this now?


Update exploring-kubernetes-cronjobs.md

Added space between text and image
Notes for Reviewers
This PR fixes #11783
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 9b391be4c03c0a25f2b0ef35690eaf657d90f0ca at: https://66cc7bb554ef9a354fff3373--meshery-docs-preview.netlify.app

Maybe @Alero-Awani can offer some feedback?

@SAHU-01 you might be able to as well.

@priyagupta20044, refer to this page and try to implement the spacing between text and images as it has on that page.

Since there are reviews similar to the ones I have, I am adding mine as comment here:

Numbering has changed
Image alignment has moved out of the numbered list

@priyagupta20044. let's discuss this PR during the Meshery dev meeting call, if you would. Please add it as an agenda item to the meeting minutes.

it's great to see this PR, @priyagupta20044. You're almost done...

@priyagupta20044 there are lots of feedback to incorporate. Are you still working in this?


ui dashboard for viewing results

Currently decided between static page frontend with spa  reading from cron generated json files, or full app with elasticsearch indexes.

fun read http://thenewstack.io/dashboards-dont-make-money/

just leveraging grafana seems sensible

Any news on this?

i've made some good progress on grafana bits indexing cw metrics across accounts, just trying to get out from under a log jam and will push (end of april realistically). it looks like we also need some policy classification systems to play nice with federated setups and uniform graphing, but for centralized setups we should be good ootb once its pushed.

Great, thanks for sharing. Looking forward to test drive and contribute to it.

The elastic search indexer for resources and for cloudtrail under the tools folder assist in creating the full app dashboard.

Even if we don't have a tool, it would good to get a blog post or an example that people could use to build off. This has been a reoccurring ask I have seen talking to Custodian users.

@aluong Shameless plug for my blog post https://aws.amazon.com/blogs/opensource/announcing-cloud-custodian-integration-aws-security-hub/ and if that doesn't meet your needs, please let me know what you think is missing

@kapilt any updates on the grafana dashboard ?

Hello, any update regarding this?


fix(map): return 200 on webhook event processing error

Changes proposed in this pull request

Context

fixes https://github.com/interledger/rafiki/issues/712

Checklist

[ ] Related issues linked using fixes #number
[ ] Tests added/updated
[ ] Documentation added
[ ] Make sure that all checks pass

In what other cases backend should not retry the event ?


Updated README.md

Created a new email adapter to use Mailjet with parse-server to send email verification and reset password emails. Updated README.md file to add a link to this new package.

Thanks!


pull lastest apache/activemq-5.17.x

Merging this in favor of https://github.com/tomitribe/activemq/pull/9 base on CI results.


Revert stabby syntax to make Uglifier happy.

Maybe unnecessary after merging @nathan's fix to Uglifier configuration, but I'm gonna do it anyway to keep things consistent.  (The same file already had an old-style function () syntax!  Can we at least agree to use the same syntax throughout a single file?! :)

Coverage: 93.494%. Remained the same when pulling 62d99bec134955a96495b067011270a0f3363309 on revert-stabby-notation-in-javascript into 5659155e75520f42e781d5f281a6bff71d1c94db on main.


Navigation Bar for Fixed Top, when window is resized the content goes under the navigation bar

I am using navigation bar and I am using a TOP fixed class , when i resize my window the content goes under the navigation bar.
example can be found here.
http://plnkr.co/edit/jdvvkRRThUJQczLKYNmb?p=preview

Thanks
Sanjay Gautam

when not using the fixed-top

@SanjayGautam, please explain how this is an Angular UI Bootstrap issue.
Also, our demo page uses a fixed navbar up top with dropdowns - you might take a look at that to see what you are doing incorrectly.

See my assumption is that when i use element  and then I user a   immediately after that like below

links goes here.

XXX  My content XXXX
my assumption is that the div with my content will always and should be visible and should not go under the navigation header, see I can add extra breaks but I dont want to do that , probably thats where i was wondering if automatically div after nav or anything after </nav is taken as content and bootstrap  should be able to position the content div appropriately
Thanks
Sanjay Gautam

I did do the comparison between the how i am using I think I am not doing any mistake in terms of the usage. the plucker example is the best one to to prove that there is some issue.
thanks
Sanjay Gautam

@SanjayGautam, I'm sorry, but we are not going to debug your code for you unless you can show that this is an Angular UI Bootstrap issue.  Using a Bootstrap navbar with UIBS dropdowns is unbelievably common and the web is littered with examples (again, not to mention the one on our demo page).
If you require support, we ask that you please follow the instructions in our documentation for how to get help.  For your reference, here are those instructions.
As the issues forum is reserved for bugs, I'm going to close this until you follow the above instructions and can show that this is an Angular UI Bootstrap issue.

Surely Understand your perspective on that , I think i understood what you are trying to say, Let me do some more investigation into it to find out and make sure that it is Angular UI Bootstrap, I am totally new to Angular and hence I assumption might be wrong as well. Appreciate your time in looking into it though.  Sorry for any inconvenience. I like the community and the promptness of response though.