Error in logger on startup

nvim version
NVIM v0.3.0
Build type: Release
LuaJIT 2.0.5
Compilation: /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SO
URCE=1 -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-
unused-parameter -Wstrict-prototypes -std=gnu99 -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-
color=auto -DINCLUDE_GENERATED_DECLARATIONS -I/tmp/neovim-20180612-38590-ar7vl3/neovim-0.3.0/build/config -I/tmp/neo
vim-20180612-38590-ar7vl3/neovim-0.3.0/src -I/usr/local/include -I/usr/local/opt/gettext/include -I/usr/include -I/t
mp/neovim-20180612-38590-ar7vl3/neovim-0.3.0/build/src/nvim/auto -I/tmp/neovim-20180612-38590-ar7vl3/neovim-0.3.0/bu
ild/include
Compiled by<EMAIL_ADDRESS>Features: +acl +iconv +jemalloc +tui
See ":help feature-compile"
   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.3.0/share/nvim"

OS
macOS 10.12.6
Using the latest nvim-completion-manager code as of July 2nd, 2018, and any terminal, I get the following error on nvim startup:
Error detected while processing function <SNR>145_on_core_channel_error:
line    1:
Traceback (most recent call last):^@  File "/Users/delucac/.config/nvim/plugged/nvim-completion-manager/pythonx/cm_s
tart.py", line 10, in <module>^@    from cm import getLogger, start_and_run_channel^@  File "/Users/delucac/.config/
nvim/plugged/nvim-completion-manager/pythonx/cm.py", line 151^@    self.nvim.call('cm#complete', name, ctx, startcol
, matches, refresh, async=True)^@                                                                             ^^@Syn
taxError: invalid syntax^@
Press ENTER or type command to continue
Error detected while processing function <SNR>145_on_core_channel_error:
line    1:
Press ENTER or type command to continue
nvim-completion-manager core channel terminated.
Press ENTER or type command to continue

Completion fails to load.
Thanks!

It's probably python 3.7 related
change async=True into async_=True

Ah ha, that does indeed get rid of most of the error, however the plugin does still fail to load. On startup I still get:
Error detected while processing function <SNR>145_on_core_channel_error:
line    1:
Press ENTER or type command to continue
nvim-completion-manager core channel terminated.

https://github.com/roxma/nvim-completion-manager/wiki/Trouble-shooting might help
By the way, this repo is not being maintained anymore, you know that, right?

Yeah I noticed that just now :(. Is ncm2 ready to completely replace repo?

@bronzehedwick

Is ncm2 ready to completely replace repo?

Short answer, No. ncm2 doesn't support ncm sources.
Longer answer, it depends on what you need.  There're sources available. You could read the REAMD.md and see if it is enough or not.

gotcha, thanks! sorry for the noise in a deprecated repo. Going to close.

It's not noise. ncm's issue could still be helpful for me pushing improvements.

possibly related https://github.com/roxma/nvim-completion-manager/issues/176


Cannot add Token Treasury to DAO

Two weeks ago I was able to add a token treasury to a DAO, where the UI asked for the type of treasury (SOL, Token, or NFT) and the token mint address. This seems to no longer be an option and only SOL treasuries can be added. If I refresh the "Create new DAO wallet" page (https://realms.today/dao/YOUR_DAO_ADDRESS/treasury/new) the type dropdown and mint address textboxes appear briefly until they disappear about 7 seconds later.
I see no errors in the browser console, only the text:
Program version (simulation) {major: 2, minor: 2, patch: 4}
refresh

I have also ensured that I have deposited more tokens than the value set for "Min community tokens to create governance".
I have tested this on devnet and mainnet.

Hi @abrzezinski94 thank you very much for the quick response!


Can't find out the symble of "AnimationListener",where is this packages?

import com.hanks.htextview.base.AnimationListener;
didn't find this;

https://github.com/hanks-zyh/HTextView/releases/tag/v0.1.2


[BUG] Editing token ttl has no validation between ttl and expiresAt field

Rancher Server Setup

Component
Version / Type

Rancher version
v2.7-44d3d40c6dd9acd0aae257ea0f80ea9eab743784-head

Rancher commit link
https://github.com/rancher/rancher/commit/44d3d40c6dd9acd0aae257ea0f80ea9eab743784

Installation option
Helm (high availability)

If Helm Chart k8s cluster
v1.24.7+k3s1

Cert Details
Let's Encrypt / traefik

k3s ha external db
Aurora MySQL 5.7.mysql_aurora.2.10.2

Helm version
v2.16.8-rancher2

Downstream cluster type
RKE1 Linode

Downstream K8s version
v1.24.8-rancher1-1

Authentication providers enabled
local, GitHub

Logged in user role
Administrator, Standard User

Browser type
Google Chrome

Browser version
108.0.5359.94 (Official Build) (x86_64)

🚨 Additional Reproduction Setup Details: Click to Expand

K3s install command for node one. Replace values in <>

curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=<K3S_VERSION> sh -s - server --token=SECRET --datastore-endpoint=<DB_ENDPOINT> --tls-san <TLD> --node-external-ip <IP>

K3s install command for node two. Replace values in <>. Main difference here is the --token

curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=<K3S_VERSION> sh -s - server --token=<TOKEN_FROM_NODE_ONE> --datastore-endpoint=<DB_ENDPOINT> --tls-san <TLD> --node-external-ip <IP>

Describe the bug
Editing the ttl of a token with kubectl and there is no validation between ttl and the expiresAt field
To Reproduce

Starting from the default Rancher homepage /dashboard/home
Click at top right of screen user icon >> Account & API Keys >> Create API Key
Fill out the API Key: Create form

Description >> TEST_TOKEN
Scope >> No Scope
Automatically expire >> Never

Using kubectl against the local cluster run these commands
kubectl get tokens
From the list notice the token you just created, now run
kubectl edit token $token_name
NOTE: When editing the token the expiresAt field is set to an empty string ""
Change the ttl from 0 >> to ttl: 600000

600000 milliseconds >> 10 minutes

Save/apply the changes to ttl
Edit the token again with kubectl edit token $token_name

Now observe the expiresAt field is set to

"2022-12-08T20:19:52Z"

Which is 10 minutes past the `creationTimestamp:

"2022-12-08T20:09:52Z"

Edit the token again with kubectl edit token $token_name
Change the ttl from 600000 to 1200000 (20 minutes)
Save these changes and check the token with kubectl describe token $token_name
Even though the ttl has changed from 600000 to 1200000 the expiresAt field has remained as: "2022-12-08T20:19:52Z"

Result

The expiresAt field only changes once, when going from a token with a ttl of 0 to any other ttl value
The token remains valid for the newly updated 1200000 even though in the UI it will show as expired
Even though the token displays as expired in the UI, you are still able to use it to make API calls to rancher via Postman until the actual stated ttl time is up

Expected Result
For there to be some validation against expiresAt field and ttl so the UI can display accurate information on when a token will actually expire
Additional Info
Noticed while doing validations against: https://github.com/rancher/rancher/issues/39107

managing Tokens via kubeclt is not currently supported and will need to wait until they are migrated outside of Norman.


TextField rendering workaround for Firefox webgl/canvas

TextField webgl/canvas rendering is seriously broken on Firefox, due to a bug that causes canvas text drawn with baseline = "top" to look different than in all other browsers (who's bug it is can be debated, but is irrelevant).
There's a hack that seems to be addressing exactly this issue, by moving down text by size * 0.185.
https://github.com/openfl/openfl/blob/4f4fa13b14c14eefffb70f7f6acae88dff4d3231/src/openfl/_internal/renderer/canvas/CanvasTextField.hx#L205-L209
However, the effectiveness of this hack is limited, the offset that needs to be applied depends on the font: some fonts need a higher, lower, or even negative offset! This often makes TextField almost unusable on Firefox, we need a better solution.
A much more reliable workaround, which however requires to know the font's ascender, is to draw with baseline = "alphabetic", and apply an offset of size * ascender. I created a demo page comparing baseline = "top" with this workaround (using opentype.js to get the font's ascender). The result appears identical on all browsers I tested (except firefox, of course).
I also implemented the workaround in CanvasTextField.hx, with the ascender hard-coded for my fonts, and it seems to work great!
To use this, of course, there's the major problem of finding the font's ascender. I see a few solutions:

Compute font metrics of embedded fonts during build, and make them available at runtime (they might actually be useful for other text-related math).

Compute the ascender at runtime. Not sure if there's an easy way though, and using opentype.js is probably an overkill).

Let the developper provide a map of ascender values for his fonts. Not great, but better than the current situation.

I'd go with (1), and I'm willing to implement it if I get some feedback about the best way to proceed.

Just added PRs #1814, openfl/lime#1152 so that this is not forgotten.

Just wanted to point out that, although this issue was closed, the problem is not fixed unless #1814 is also merged.
Currently (v7.1.2) font metrics are included in html5 (PR openfl/lime#1152) but they're not used anywhere!


#Form Added To Portfolio setup

This project includes:

HTML and CSS for a portfolio page
It includes work detail section and about me section
This project was created with major use of Flex box.
Form Added To Portfolio  and styled

@Zuhaib042  hi,
I can see the index.html file on my file. Kindly tell me how to fix the error you see?

Please check my main branch I have merged my codes to my main branch therefore my html file is on my main.

Please kindly check my main branch, for this project because my project file (my html file is on my main).
I have reverted all my merge and deleted branches as requested.

Please kindly check my main branch, for this project because my project file (my html file is on my main). I have reverted all my merge and deleted branches as requested.

@helina42, you haven't and also your partner hasn't contributed and this is a pair programming project.

@topeogunleye I have collaborated with my partner on the project but due to branches being confused the track seems to be messed up I think. How should I fix things after this. I have clicked on revert on my merges but I think its still now working.

@topeogunleye I have collaborated with my partner on the project but due to lots of branches a being created the track seems to be messed up I think. How should I fix things after this. I have clicked on revert on my merges but I think its still now working.

@helina42, Please kindly read the GitHub docs on how to revert a pull request


mj_forward modifies jacobian when called after mj_step

Summary
Calling mj_forward after a mj_step call unexpectedly modifies the Jacobian returned by mj_jacBody. By extension, other derived quantities may be affected as well. The generalized coordinates qpos, qvel are not modified by the call, which is expected.
Expected behavior
According to the documentation, mj_forward performs the same computations as mj_step but without the integration. The Jacobian, which only depends on qpos, should not change after calling mj_forward since qpos is the same and the Jacobian should have already been computed by mj_step.
Code example
The following examples showcases how mj_forward changes the Jacobian. The code was tested on a M1 mac with macOS 14.5, Python 3.10.14, Mujoco 3.1.5.
# Adapted from https://github.com/tayalmanan28/MuJoCo-Tutorial
import mujoco as mj
import numpy as np
from mujoco.glfw import glfw
import sys

xml = """
<mujoco>
	<option gravity="0 0 -9.81">
	</option>

	<worldbody>
		<body pos="0 0 2" euler="0 180 0">
			<joint name="pin" type="hinge" axis="0 -1 0" pos="0 0 0.5"/>
			<geom type="cylinder" size=".05 .5" rgba="0 .9 0 1" mass="1"/>
		</body>
	</worldbody>

	<actuator>
		<motor joint="pin" name="torque" gear="1" ctrllimited="true" ctrlrange="-100 100"/>
		<position name="position_servo" joint="pin" kp="10"/>
		<velocity name="velocity_servo" joint="pin" kv="0"/>
	</actuator>
</mujoco>
"""

def get_jac(model, data):
    jacp = np.zeros((3, model.nv))
    mj.mj_jacBody(model, data, jacp, None, 1)
    return jacp

def main(test_jacobian):
    model = mj.MjModel.from_xml_string(xml)
    data = mj.MjData(model)  # MuJoCo data
    cam = mj.MjvCamera()  # Abstract camera
    opt = mj.MjvOption()
    data.qpos[0] = np.pi / 2
    # Set camera configuration
    cam.azimuth = 90.0
    cam.distance = 5.0
    cam.lookat = np.array([0.012768, -0.000000, 1.254336])
    # Init GLFW, create window, make OpenGL context current, request v-sync
    glfw.init()
    window = glfw.create_window(1200, 900, "Demo", None, None)
    glfw.make_context_current(window)
    glfw.swap_interval(1)

    scene = mj.MjvScene(model, maxgeom=10000)
    context = mj.MjrContext(model, mj.mjtFontScale.mjFONTSCALE_150.value)
    while not glfw.window_should_close(window):
        mj.mj_step(model, data)
        # Compute the jacobian
        jac0 = get_jac(model, data)
        q0 = np.copy(data.qpos)
        v0 = np.copy(data.qvel)
        # Call mj_forward
        mj.mj_forward(model, data)
        if test_jacobian:
            # This test fails
            np.testing.assert_allclose(jac0, get_jac(model, data), atol=1e-4)
        np.testing.assert_allclose(q0, data.qpos, atol=1e-7)
        np.testing.assert_allclose(v0, data.qvel, atol=1e-7)
        viewport_width, viewport_height = glfw.get_framebuffer_size(window)
        viewport = mj.MjrRect(0, 0, viewport_width, viewport_height)
        # Update scene and render
        mj.mjv_updateScene(
            model,
            data,
            opt,
            None,
            cam,
            mj.mjtCatBit.mjCAT_ALL.value,
            scene,
        )
        mj.mjr_render(viewport, scene, context)
        glfw.swap_buffers(window)
        glfw.poll_events()

    glfw.terminate()

if __name__ == "__main__":
    test_jacobian = "--test-jacobian" in sys.argv
    if test_jacobian:
        print("Jacobian testing is enabled.")
    else:
        print("Jacobian testing is not enabled.")
    main(test_jacobian)

This is working as expected, not sure why you are confused. After mj_step, everything in mjData except for the state is wrt the previous timestep. So after an mj_step there is an inconsistency between the state and everything else, since mj_step only does everything until it computes the new state and then it stops. After mj_forward all the quantities are wrt the current timestep, there is no inconsistency.
Let me know if something is still unclear.

Actually, this is probably a good opportunity to improve the documentation. If you now fully get it, tell me how you think we should improve the docs. If not, please keep asking questions until you are 100% confident you get it, and this conversation will help clarify how the docs should be improved...

@yuvaltassa Thank you for the reply. I understand the behavior now.
After spending more time reading the documentation, what you described is indeed detailed in Programming/Simulation loop section.

... Jacobians, passive forces. None of these quantities are available before mj_step is called (or rather, they are available but outdated by one time step)

However, the documentation in APIreference/APIfunctions/Main simulation makes no mention of this explicitly. I also find the statement "mj_step is the only call needed" to be misleading. As far as I can tell most robotics use cases must call mj_forward separately to get forward kinematics results.

Most users will only need to call mj_step, which computes everything and advanced the simulation state by one time step...mj_forward performs the same computations as mj_step but without the integration. It is useful after loading or resetting a model (to put the entire mjData in a valid state), and also for out-of-order computations that involve sampling or finite-difference approximations.

I think adding more emphasis on all quantities except for the state itself is outdated after mj_step would be helpful, especially in the APIreference section.


LD-323 - All event section events now link to show

https://artsyproduct.atlassian.net/browse/LD-323

Fails

:no_entry_sign:

Missing Test Files:

src/lib/Scenes/City/Components/FairEventSection/__tests__/index-tests.tsx

If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

  Generated by :no_entry_sign: dangerJS

Going to merge this to get it into the next beta 👍


feature: include installation paths in API

The installation paths are currently not in the API. I saw somewhere that @davidanthoff had done this intentionally, but had not made a firm decision. I find complicated, un-documented installation trees unpleasantly enterpris-y, but I am in a small minority. There are big advantages to hiding the paths, especially in the early stages of development.  But, I understand that the pros of hiding this detail may outweigh cons.
I have a specific use case. I am interested in trying to package python projects that depend on Julia in such a way that the user does not have to know that Julia is involved; it's just pip install ... like any other Python package. In many environments, this is essential for adopting Julia (until Julia rules the world and calls the shots). For example Python packages with compiled C or rust shared libs can be distributed this way. This was a necessary condition, for example for adopting a rust library in the IBM Qiskit ecosystem.  This library is a successful open-source project that has industry support. Doing this right now for Julia is perhaps a bit quixotic, but I suspect it is in fact not too quixotic. I am developing a (rather simple) package julia_project that manages a Julia dependency in a Python project. It depends on another package find_julia whose sole responsibility is search for Julia installations (with some support for coarse version requirements) on a system, and return a path, or offer to install Julia if none is found.
I'd like to include juliaup installation paths in find_julia. If the user chose to put the julia executable parent dir in their PATH, then find_julia will find and use it (this is ~/.juliaup/bin/julia in Linux, I suppose). So, including the path in the juliaup API is probably only useful to the extent that the link to the executable or launcher is not in their PATH. I don't know how often that is. My julia is sometimes a script that calls julia in a particular way. A package author might use find_julia in such a way as to avoid picking up this script.
A related question is, is there a plan for a programmatic, or at least more automated, interface for installation via juliaup? find_julia currently uses jill.py, which includes both a cli and library interface. It is very easy to use and requires almost no work on the part of find_julia. A crucial ingredient is that the installation paths are part of the jill.py API. In addition, I have a (not quite finished) PR to jill.py that searches for and returns the path. This would work even if the API were not published. Using juliaup in find_julia is currently not an option because I would have to do a lot of detective work and download the installer of the installer for the correct platform, etc. Downloading a single, cross-platform script, that would perform the installation, perhaps with environment variable control, would make juliaup a viable option. The big impediment to making jill.py universal is that mechanisms for bundling a python interpreter seem to be poor to non-existent at the moment.

The official (and at this point stable) API is juliaup api getconfig1. That does provide full paths, and I think if I understand your scenario correctly that should probably work?
I can easily see that we might want to expand this API in the future. One example is what you mentioned, an official, stable API to install a specific Julia version. Another might be something where one can ask juliaup "hey, I need a Julia version from the 1.6 series, which should I use?" At the moment every client needs to figure that out by themselves from the return value that they get from ``juliaup api getconfig1`. That is not super trivial because a user might have very many versions from the 1.6 series installed at the same time.
Having said that, I'm still working on just finalizing the Mac and Linux version of juliaup, so right now the focus here is to get that to all work, and once we have it all in a state where it is "released", stable and (hopefully) the official way to distribute Julia, I'd be more than happy to think about more APIs that can help in scenarios like yours!

Great, I tried juliaup api getconfig1 and the output is what I need. This will reduce complexity and need for internal details for tools like find_julia. For now I can look in ~/.juliaup/bin/juliaup on Linux. What are the corresponding paths for Windows and MacOS? If these things change later, they won't break find_julia, but rather just reduce the chance of finding an installation.
Regarding versions. I am currently relying on what jill.py does, which is, by default use a directory julia-1.7, which contains the latest 1.7.x. You can pass a list of preferred and/or required versions to find_julia, but using the data correctly is only partially implemented. The PythonCall.jl package has some detailed Python code for finding if a Julia version matches a supplied semvar specification. I may borrow this if I find that it becomes an issue and I find the time. Of course you'd need to translate the Python or the original Julia into rust.

For now I can look in ~/.juliaup/bin/juliaup on Linux. What are the corresponding paths for Windows and MacOS?

I think I would just try to spawn juliaup without a path. The install location for juliaup itself very much depends on how it was installed, even on the same platform, but all install methods put juliaup on the PATH. For example, when users install with the new shell script, they can pick an arbitrary install location (with ~/.juliaup/bin as the default), when installed with brew it ends up in a different place, same with AUR, and on Windows it gets installed via the MSIX execution alias feature, where one actually shouldn't look in a specific location, but just start juliaup itself.
On the Julia version match, I have something similar in the VS Code extension at the moment for selecting notebook kernels. So I think for a while we'll probably just have individual clients figure this out, and then eventually we can move that logic into juliaup.

just try to spawn juliaup without a path. ...

Good, this is clearly the best option to start with.
On my system, juliaup is not on the path, but I forgot that this is exceptional. I think I explicitly answered "no" when asked. I usually try a tool before I put it on the path. Otherwise, I end up with cruft. For example, just now, I spent 10 minutes trying to find the origin of everything that echo $PATH shows me, and failed. I use fish and try to only change my path in the bash startup files and then import them into fish. But, some tools detect that I am using fish and add a path somewhere else, etc.

eventually we can move that logic into juliaup

:+1:
I think you can close this issue. Maybe some of the loose ends mentioned here could be addressed in a new issue when the time comes.


Fixing bug with using multiple URL attributes

Fixed small bug with using multiple URL attributes:

filters and page size were cleared if search was used;
sorting, search and page size were cleared if filters were used.

Was fixed by adding hidden inputs for storing arguments.

It's a little opinionated, but I like the change. @pawl any objections?


last auth doesnt work

Hi
seems the session getting doesnt work :(
Waiting for authentication ...
<IP_ADDRESS> - - [10/0ct/2023 13:23: 42] "GET /?token=XXXXXXXXXXXXXXXXXXXXXXXHTTP/1.1" 200 -
Getting session ...

Invalid method signature supplied

Traceback (most recent call last):
File "/home/robin/Downloads/youtube-music-scrobbler/start.py", line 89, in get_session
token = root. find('session/key'). text
AttributeError: 'NoneType' object has no attribute 'text'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/robin/Downloads/youtube-music-scrobbler/start.py", line 153, in
Process() .execute()
File "/home/robin/Downloads/youtube-music-scrobbler/start.py", line 101, in execute
self.session = self.get_session(token)
File "/home/robin/Downloads/youtube-music-scrobbler/start.py", line 94, in get_session
raise Exception(e)
Exception: 'NoneType' object has no attribute 'text'
any idea what to do? :)

Hello! the browser is opening? In that step, you're supposed to give the app permissions from the lastfm website. A browser will pop up with the authorization URL.

yes this is exactly what I do I get lastfm access request - click on "Yes" and it says "authentication okay" in browser but gives me error in terminal

you can see it here (ignore background please, was watching a video and didnt relaize it was recording sound :D ) https://youtu.be/MjqcgDY6Eqk?t=15

ok try putting the lastfm token hardcoded here like this:
        if not self.session:
            # token = self.get_token()
            token = "YOUR_TOKEN_HERE"
            self.session = self.get_session(token)

this is the token you need to paste:

let's see if that works

You know what, I can see the error

that means there's a problem with your LAST_FM_API_SECRET. It's set correctly?

its the shared API secret right? yeah, double checked it and just created a new one to be sure - both key and secret are correct.

Yes. try to print the params here: https://github.com/luisignaciocc/youtube-music-scrobbler/blob/master/lastpy/init.py#L15-L24
To see if everything is ok

interesting after a restart it works but it now shows "0 scrobbles" is it because I have way more then 200 scrobbles ?

no no, it scrobbles from all the devices. it just scrobbles the recently played songs, so history older than 1 day will not be scrobbled

ah I see. hmm i need this for like the last 365 days :D thanks for this though! :)


fjordlauncher: init at 8.3.1

Description of changes
Fjord Launcher is a libre Minecraft launcher and a fork of Prism Launcher that:

Reduces dependence on non-free network services
Adds support for alternative Minecraft API servers, such as Ely.by
Adds back the ability to download FTB modpacks from within the launcher

This PR supersedes https://github.com/NixOS/nixpkgs/pull/270815, PollyMC was unmaintained so I forked it to Fjord Launcher.
Builds on macOS or aarch64 have not been tested, but this derivation is almost identical to Prism Launcher, which is already in nixpkgs.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hey @getchoo, thanks for the respectful reply.

i think it's important to note a "feature" of this launcher that has been glossed over in the PR description, but mentioned in the README

Offline mode doesn't require a Microsoft account

Yes, I should have noted that clearly.

at best, this launcher (and distributing it on cache.nixos.org) is in a legal grey area. at worst, this launcher and it's inclusion would be enabler for those wishing to pirate minecraft. this could be quite a risk for nixpkgs that i don't think is worth the benefits; after all, you have inherited a flake from the fork that nix users can easily take advantage of

Yeah, I have been on the fence myself about adding DRM back to Fjord Launcher. I forked Fjord Launcher from PollyMC (since PollyMC has been unmaintained recently), and the PollyMC developer was the one who originally stripped out the DRM check.
My primary goal with Fjord Launcher, and the reason for the fork from Prism, is to support users who don't want to interact with network services that are proprietary and can't be controlled by the user, or to do so as little as possible (downloading the game necessitates interacting with Mojang's servers). The main thing I want to do is support alternative auth servers, but that initial authentication with Microsoft is not a big concern, we could add back the DRM check and it wouldn't matter much to me.
IANAL either, but in my view, PollyMC was in a similar legal gray area as youtube-dl. Could youtube-dl allow users to break YouTube's EULA and download copyrighted material against YouTube's terms? Yes, but publishing youtube-dl itself is (under current norms) not illegal, and many people agree that it serves a public good. Granted, Minecraft feels different since it's a "paid" product and YouTube videos are generally gratis.
I'm curious what other people have to say. If the DRM check prevents Fjord Launcher from being accepted into major repositories like nixpkgs or Flathub, I would rather just add back in the DRM.

After talking with some other people in the community, I've decided to add back the Microsoft DRM check to Fjord Launcher, but it may take some time to get Fjord working with Microsoft accounts. I'm going to close this PR now, and re-open it again for a later version of Fjord once I've added back in the DRM. I'll ping you @getchoo on that new PR.
Thanks.


General Enquires on WD

Hi @patduin ,
Like hive metastore, does the WD also stores info about mappings in separate metastore?

No all info is part of the configuration, no state is stored. There is one exception where the configuration can be written back to disk but that's not an extremely useful feature and I would consider that deprecated. For all practical purposes WD doesn't hold state.


add option to choose whether atom rememebers your last windows and project folders

A new Core Setting: Restore Previous Project Folders And Windows On Start
Enabled by default, so it's backward compatible.

This also loads the config file early in the startup process, so it's unfortunately loaded twice.
Fixes #6605 and #8564

:-1: on loading config twice. Is there a way you could achieve the same goal without this? We have to be tediously strict about counting milliseconds on window load.

Also, what's your use case here? I'm personally not convinced this is a common enough need to warrant another checkbox in core settings. cc @atom/feedback

:-1: on loading config twice.

Ditto.  My window load time is long enough as it is :wink:.
As for use case, a lot of people have been asking for this in #6605.

@jordanbtucker  wouldn't it be enough just to save an empty state when closing atom and the setting is switched on. So you won't need to change to opening part at all.

@thedaniel @50Wliu I totally agree with you on the loading config issue, but I haven't come up with a better solution, and config option is what 99% of the users wanted in their comments. I'm okay with removing the checkbox and making it config file only.
I'm against having a command that disables saving on exit that you have to call every time. This should be a set-and-forget setting.
Honestly, I feel this is on par with the "open empty editor" config setting. Seems odd to give that a checkbox, but not this one.
Please leave any suggestions to improve this. I'll be so glad when this is fixed.

I'm against having a command that disables saving on exit that you have to call every time. This should be a set-and-forget setting.

I meant in your example you are returning out of the save function when your new setting is switched on and you have the same for the opening function. If you just change the saving part to save [] if you setting is switched on you don't need to do any changes on the loading part (less code to test, less side-effects). saveState/loadState do their work normally but you end up with a clean session every time.

@m1ga I hadn't responded to your comment yet. With my method, you can modify the config file with the editor closed and it will honor your setting when it starts. If we go with your method, the option should be changed to "Save Your Previously Opened Windows" or something like that. Or maybe I'm just nitpicking. I'm not opposed to your method, but I just want everyone to be aware before we decide which way to go.

I am personally fine with it not being a checkbox. However, there should be some way that the user can find out about the option if they want to. Perhaps the main settings page links to a 'Configuration Reference' saying it contains additional options not displayed here?

I removed the checkbox and it now only loads the config file when saving. I'm not sure the best way to use a config option that doesn't have a UI. Do I set the default in the code like I did on line 438? What other examples are there of settings that do not have a UI?

@jordanbtucker Thanks for diving in and taking a look at this. I'm :+1: on this change; a number of people have asked for it. I agree w/ @thedaniel that we don't need to add UI for it yet. I left some feedback on your code above.

Good catch on the integration test. I can't actually get integration tests to work on my Ubuntu box, but hopefully the test is correct now.

+1 Bump! I'd really like to have Atom open clean every time and stop saving my session when I close it

@jordanbtucker Are you still interested in doing this? It has actually become a little bit easier since we last talked, because of https://github.com/atom/atom/pull/9990. We are now using the Config class in the browser process for other purposes.

Sure! I'll take a look at #9990 and start working on this again. Thanks.

@jordanbtucker Yay! You rock! And thanks for the quick reply and review @maxbrunsfeld

@maxbrunsfeld I looked through #9990, and the relevant code looks almost identical to what I've already written. Sorry if I'm missing something, but what do I still need to change to get this merged?

@jordanbtucker We just need to avoid loading the config twice in the browser process. Currently, it's loaded inside of auto-update-manager, so I think we need to move that code out into atom-application, passing the config into the AutoUpdateManager.

Excited for this! Personally, I want a clean slate every time Iaunch Atom.

You can shim this in atom right now with project-plus and the following line in init.coffee (as long as you only use one atom window):
atom.commands.dispatch(atom.views.getView(atom.workspace), 'project-plus:close')

@maxbrunsfeld I made some changes that I think satisfy your requirements. Please take a look and let me know. Thanks.

@jordanbtucker Max is on parental leave currently. I've added this to the queue to review but I don't have an ETA on when someone will be able to get to it.

Thanks for the patience and the hard work on this, @jordanbtucker. :sparkles:
I have started reviewing this and I think right now we may not be handling the scenario where the restorePreviousWindowsOnStart setting is set to false outside of Atom (e.g. nano ~/.atom/config.cson). In that case, we'd still reopen the previous windows even if the configuration explicitly states we shouldn't.
So, what do you think about moving that if clause down to the loadState method? Basically, we'd always store the currently open windows, but we open them on the next launch only if the configuration states so. If we do that, we might also want to change the integration test to reflect this behavior; in particular, we could move this piece of code down, so that it gets executed before opening the second instance:
configPath = path.join(atomHome, 'config.cson')
config = CSON.readFileSync(configPath)
config['*'].core = {restorePreviousWindowsOnStart: false}
CSON.writeFileSync(configPath, config)

What do you think? /cc: @atom/core

I don't know much about the technicalities of this, but based on your comments, why does this have to be so difficult? Why save the previously opened windows at all unless explicitly told to do so? From the people I have talked to, none of them want the windows saved when they fully close the editor. Frankly, it's a pain in the butt that it does that currently.

@jacobgraf This was a highly requested feature by the community: https://github.com/atom/atom/issues/1603
FWIW, Sublime also remembers its open windows and files by default, so this is actually expected behavior for those coming from Sublime.
Once this PR lands then you'll be able to disable this.

@as-cii Thanks for the feedback. You make a good point.
I've pushed the changes you suggested.

One thing I want to make clear to everyone (in case there is any confusion). This only applies to opening Atom without a path argument.
If your config file looks like this:
'*'
  core:
    restorePreviousWindowsOnStart: false

Then the following command will not open the previous session:
$ atom    # will not restore previous session

However, the following commands will restore the previous session for that directory.
# this will restore the state for this directory (if it was
# recently opened) regardless of restorePreviousWindowsOnStart
$ atom /home/me/project

# this will restore the state for the parent directory (if it was recently
# opened) of this file regardless of restorePreviousWindowsOnStart
$ atom /home/me/project/package.json

Just left one comment, I think we can :shipit: after addressing it and specs are :green_heart:. :fireworks:


Miscellaneous updates

Another omnibus PR like #25.

Summary of changes (most are internal):

Removed Member pattern
Removed type aliases: Array, Member, Object
Renamed (main) Config to Settings
Moved types into their own modules: Codec, (encoder) Config, Decoder, Encoder, Flag, Indent, Permission, Result, Settings
Split up monolithic main function


Create html page for each product

i have created an asus rog page and a asus laptop page

I can't see any change @naim16031988 i guess you have pushed the wrong files


cue: back-quoted  identifier literals

There is currently no way to reference a top-level field with a non-standard character:
"foo-bar": "can't touch this"

a: // cannot reference "foo-bar"

One solution is to introduce $ to refer to the root object. This is possible, but such references often result in poor configuration file design. It is also one other thing to learn for a user.
An alternative approach is to allow a syntax for identifiers with non-standard characters. Swift and GCL allow back quotes for this purpose:
"foo-bar": "can touch this"

a: `foo-bar`

Main drawback: now we have three ways of referring to identifiers. Allowing back quotes also on the left hand side might mitigate this issue. The string approach may be considered a relic of JSON and hardly used unless needed for interpolation.
`foo-bar`: "can touch this"

a: `foo-bar`

"dynamic\(interpolated)": 42

cue fmt could be used to canonicalize LHS identifiers according to this rule.

The new aliases provide a better alternative. Closing.

This issue has been migrated to https://github.com/cue-lang/cue/issues/2.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


[Stocks] Wrong stock price bug

Describe the bug
The last two digits of the stock price are supposed to be decimals but the cog adds them to the actual number causing the price of stocks to be much higher than real life.
To Reproduce
Run the [p]stock price  command
Error code
N/A

That is not a bug, that is documented behavior. Red economy credits are stored in integers, so they cannot have decimals. Because of that and the price of most stocks is quite low compared to the average balance of users, I opted to have a conversion rate of $1 = 100 credits. This is visible in [p]help stock buy.


[Accordion] Accordion break orbit slider

How can we reproduce this bug?

Open accordion - orbit slider start lagging
Open and close accordion few times - orbit disappear

I think this is some bug with motion-ui or something else.
After clicking on according toggle, on .orbit-slide appear these classes:
orbit-slide fade-out mui-leave mui-leave-active is-active fade-in mui-enter mui-enter-active
They hide slides
Test case
Just clicking on accordion, it crash orbit when slide change
http://jsfiddle.net/0yaru5vm/3/
(used last foundation and motion-ui from github)
Sorry for my english.

Hey @NanoEdit, sorry for not getting to this issue sooner!
If the Motion UI classes (anything starting with .mui- are sticking to the element, this is usually because the CSS for those classes isn't being loaded. The classes aren't removed until the element fires a transitionend event, but this will never happen if the transition doesn't start at all. It won't start if the CSS for the classes isn't there.
In your JSFiddle, the reference to the Motion UI was a broken link, so I replaced it with one from cdnjs. I updated the Fiddle's JS and CSS to use Foundation 6.2.0, spent a while clicking on the accordion over and over, and nothing went wrong. The Orbit slider autoplays, and each animation happened just fine, and the slider never outright disappeared.
If you're still seeing this behavior in the latest version of Foundation (6.2.0), let me know what browser you see it in so we can work on resolving it. Thanks :)


Navbar Responsive New Design

Rework the navbar responsive according to the new design
Design: https://www.figma.com/file/S1UKYgWewNqNHZFAaBUilG/Starknet-ID-design?node-id=1247%3A517&mode=dev

done


How to disable drawable black color on indicator???

I want disable this black background but i can't ...
help me to disable it.

Sounds like you are using TextSliderView instead of DefaultSliderView

Make sure that you have changed the default setting. Please check the example code and wiki.

I got it.
Thank you


Add support for select/de-select items programmatically

This PR is built on top of v4.3.2
#57
#79

I released https://pub.dev/packages/flutter_awesome_select with fixed null safety.
Could you check that everything works for you?

Hi everyone,
I'm really sorry for not maintaining the smart_select package in a long time. It's been a great project, but it's become too difficult for me to maintain, especially since I've been going through a tough time for the past few years.
In its place, I've released a new package called choice. The combination to smart_select and chips_choice with cleaner, more flexible, and composable API for creating inline or prompted choice widgets with single or multiple selection.
I hope you'll check out choice. I think you'll find it to be a great replacement for smart_select.
Thanks for your understanding.


Under Certain Conditions, Null Reference Error is thrown during whoami command

Describe the bug
Certain users trigger null reference exception when using whoami
To Reproduce
Steps to reproduce the behavior:

User uses iam successfully
User uses whoami
Error: character not found thrown
Null reference error written to log

Expected behavior
Character embed should be displayed
Screenshots
Additional context
Known users with issue: Leo, Lali

It was eventually determined that this was caused by discord users having invalid characters in their username. to resolve this issue, the bot now uses discord IDs as the index rather than the username.

New users with this issue have been identified, it does not seem that the cause is related to previous instances of this issue.
Users: Mae (may not have used !iam), Daedelise


[BREAKING CHANGE] Drop claimed Node 16 support

Also add Node 22 to our target test set.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a6ed59f) to head (2ff9209).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #103   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          143       143
=========================================
  Hits           143       143


driver: led: kconfig symbols mix up

Describe the bug
driver/led is an unusual subsystem, it covers 2 generic (ie hw agnostic) drivers: led_gpio and led_pwm.
Since they are generic, these 2 drivers can be enabled at same time in the same build.
A top level Kconfig symbol controls the whole subsystem: CONFIG_LED.
Each driver has its own symbol: CONFIG_LED_GPIO and CONFIG_LED_PWM.
Initially, enabling one driver required enabling both top and driver kconfig symbols, for instance:
CONFIG_LED=y
CONFIG_LED_PWM=y

Since https://github.com/zephyrproject-rtos/zephyr/pull/48827, CONFIG_LED_GPIO and CONFIG_LED_PWM values are set based on presence of an enabled node with matching compatible.
Then CONFIG_LED_PWM and CONFIG_LED_GPIO are not enabled in samples anymore.
Drivers are enabled only based on boards device tree descriptions.
Problem is that, most often, the same hardware resource is described by nodes with compatibles "gpio-leds" and "pwm-leds": the pin connected to the board LED.
As a consequence, when CONFIG_LED is set, both drivers led_gpio and led_pwm are compiled in and try to control the same pin.
On STM32 at least this lead to functional issue, as pin is:

first configured using pinctrl thought pwm device (used by pwm-leds driver)
then configured using gpio driver (used led_gpio driver)

This is the issue that https://github.com/zephyrproject-rtos/zephyr/pull/54019 tried to fix, by disabling nodes depending on the driver used by the sample.
But this is not sufficient, potentially all boards are impacted. And this isn't in line with recommendations https://docs.zephyrproject.org/latest/build/dts/dt-vs-kconfig.html:

Use Kconfig to configure software support to build into the final image. Examples include whether to add networking support, which drivers are needed by the application, etc.

In current case, device tree is dictating which software component is using the hardware.
Expected behavior
Back to the initial situation:
CONFIG_LED_PWM and CONFIG_LED_GPIO should control which driver is used.
Impact
If this isn't fixed, for each board which want to support both "gpio-leds" and `"pwm-leds" (which is likely, why would it be otherwise ?), following should be done:

device tree should describe both types of nodes and leave one of them disabled (say `"pwm-leds" node)
in applications using led_pwm (samples/drivers/led_pwm for instance):

disable "gpio-leds" node
enable `"pwm-leds" node

(Basically this requires applying https://github.com/zephyrproject-rtos/zephyr/pull/54019 to all boards)

Hi @erwango,
I don't think it is a bug. CONFIG_LED_PWM and CONFIG_LED_GPIO still control which driver is selected at the end. The difference since #48827 is that the LED drivers are now automatically selected if a compatible and enabled node is found in DT. But you can unselect the driver you don't want from your board configuration file (or from a sample).
As an example let's take the nucleo_u575zi_q board in https://github.com/zephyrproject-rtos/zephyr/pull/54019.
"pwm-leds" and "gpio-leds" can be both enabled in the board DT. And in the led_pwm sample the led_gpio driver can be disabled by adding the following configuration into samples/drivers/led_pwm/boards/nucleo_u575zi_q.conf:
CONFIG_LED_GPIO=n

And you can drop the overlay file. That's it ! I don't understand why @FRASTM is ignoring this suggestion. This is closer to what you are trying to achieve than disabling nodes in DT.
I believe that your use case is quite uncommon. Most of the boards don't have conflicting LED devices enabled in DT. And auto-selecting the LED drivers from DT removed 19 lines (See 0e1a7e0241135bae576698eab5b4bc7b73cc824b) So IMHO it is a good thing even if we have to unselect a LED driver for few boards.
In addition I don't think that DT is dictating the driver selection because Kconfig is still in control at the end.
Now that being said, I am not sure I am right. So let's ask @galak and @Mani-Sadhasivam their opinion.

I agree with @Mani-Sadhasivam that this should be handled by having the devicetree only enabling one of the hw configs and utilize overlays to get the proper HW config based on what the application wants.


[File Preview] Preview .vsconfig as JSON

Summary of the Pull Request
Registers .vsconfig as jsonExt instead of txtExt.
PR Checklist

[ ] Closes: #33106
[x] Communication: I've discussed this with core contributors already.
[x] Tests: Added/updated and all pass
[x] Localization: All end user facing strings can be localized
[x] Dev docs: No need
[x] New binaries: None
[x] Documentation updated: No need

Detailed Description of the Pull Request / Additional comments
Monaco previously rendered .vsconfig as plaintext, even though it is in the JSON format. With this it will be rendered as JSON.
Validation Steps Performed
Observing

Thanks for the update 😄 No problem.


STM32F091 testing the spi and uart with DMA transfer on nucleo board

This PR configures the DMA channels for the nucleo_f091rc platform to run
tests/drivers/spi/spi_loopback
tests/drivers/uart/uart_async_api
The DMA of the stm32f091 has peripheral request (type V2) to set for each channel. It differs from other stm32f0 serie
DMA 2 instance is selected. See table (31&32) in RM0091 for selecting request/channel.
Connect the Tx to Rx pins on the target platform (add the corresponding harness_config "fixture") to pass the test.
Signed-off-by: Francois Ramu<EMAIL_ADDRESS>

$ west build -p auto -b nucleo_f091rc tests/drivers/spi/spi_loopback/
===================================================================
TESTSUITE spi_loopback succeeded

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [spi_loopback]: pass = 1, fail = 0, skip = 0, total = 1 dus
 - PASS - [spi_loopback.test_spi_loopback] duration = 0.052 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL

west build -p auto -b nucleo_f091rc tests/drivers/uart/uart_async_api/

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [uart_async_chain_read]: pass = 1, fail = 0, skip = 0, tots
 - PASS - [uart_async_chain_read.test_chained_read] duration = 0.269 seconds

SUITE PASS - 100.00% [uart_async_chain_write]: pass = 1, fail = 0, skip = 0, tos
 - PASS - [uart_async_chain_write.test_chained_write] duration = 0.003 seconds

SUITE PASS - 100.00% [uart_async_double_buf]: pass = 1, fail = 0, skip = 0, tots
 - PASS - [uart_async_double_buf.test_double_buffer] duration = 3.427 seconds

SUITE PASS - 100.00% [uart_async_long_buf]: pass = 1, fail = 0, skip = 0, totals
 - PASS - [uart_async_long_buf.test_long_buffers] duration = 0.153 seconds

SUITE PASS - 100.00% [uart_async_multi_rx]: pass = 1, fail = 0, skip = 0, totals
 - PASS - [uart_async_multi_rx.test_multiple_rx_enable] duration = 0.703 seconds

SUITE PASS - 100.00% [uart_async_read_abort]: pass = 1, fail = 0, skip = 0, tots
 - PASS - [uart_async_read_abort.test_read_abort] duration = 1.060 seconds

SUITE PASS - 100.00% [uart_async_single_read]: pass = 1, fail = 0, skip = 0, tos
 - PASS - [uart_async_single_read.test_single_read] duration = 0.403 seconds

SUITE PASS - 100.00% [uart_async_timeout]: pass = 1, fail = 0, skip = 0, total s
 - PASS - [uart_async_timeout.test_forever_timeout] duration = 3.001 seconds

SUITE PASS - 100.00% [uart_async_write_abort]: pass = 1, fail = 0, skip = 0, tos
 - PASS - [uart_async_write_abort.test_write_abort] duration = 0.102 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL


Support to define external modules as hypothetical

I'm not sure if this is acceptable since it would be a breaking change.
hypothetical({
  files: {
    "foo/bar.js": ""
  }
})

The above setting is used to be treated as a relative file but this PR makes it an external module file.

Ahh, interesting. I should have thought of this when I made the plugin.
There are a few ways this sort of thing can be achieved right now, but they're all pretty awful. I can think of some non-breaking changes that would make it easier, but your solution is pretty obviously the one that makes the most sense. This package doesn't seem to have too many dependents, so I think a breaking change will be okay.
I don't have much time to work on stuff like this at the moment, so thank you for the PR! The allowExternalModules option will require some rethinking. I don't think it makes much sense to give the user an option that makes some of the files they passed in unreachable. On the other hand, if it didn't affect passed-in files, I'm not sure the current name would make sense.
I'll hopefully be able to get around to this soon. I'll think about it in the meantime.

Sorry I took so long, and thanks again for the quality PR. That being said, I did have to bolt a bunch of stuff onto it before I could be satisfied that it was ready for v2.0.0. Lots of new edge cases.

Published as v2.0.0.


DCOS-12421: Add sensible defaults to healthcheck settings

https://mesosphere.atlassian.net/browse/DCOS-12421
Add defaults for health check settings.

Let's not add any defaults for gracePeriodSeconds, intervalSeconds, timeoutSeconds or maxConsecutiveFailures as all of them are optional (see healthCheck.raml for details) and adding those only increases maintenance without providing any value. Having those defaults also makes it harder to read the JSON generated by the form.


Browse Button still doesnt work.

Microsoft PowerToys version
0.51.0
Running as admin

[X] Yes

Area(s) with issue?
Video Conference Mute
Steps to reproduce
Clicking on the Browse button under the Selected Camera option does not work.
✔ Expected Behavior
A File explorer dialogue to appear would let me choose the file.
❌ Actual Behavior
It does absolutely nothing when I click it.
Other Software
No response

PowerToysReport_2021-12-03-15-38-46.zip
I had forgotten to attach this bug report.

I think this bug has already been posted, and I don't know if it is happening only for me.
And is there a manual way to set the path to the camera overlay image?
Just asking because there is a section in the settings.json file where the overlay image path is blank.

I also remember an issue or a comment about this. Thought there was a work-around for it, but I'd have to search for it to be sure.

https://github.com/microsoft/PowerToys/issues/13215#issuecomment-948803092

Duplicate of #13215

I also remember an issue or a comment about this. Thought there was a work-around for it, but I'd have to search for it to be sure.

Thank you for addressing my issue, I did find the work-around you were speaking about. But I didn't quite understand how to use the work-around, it would be helpful if you could guide me through the process.

Open Explorer
copy/paste %LOCALAPPDATA%\Microsoft\PowerToys\Video Conference to open folder
open file settings.json
Near the end of the JSON is "camera_overlay_image_path". Value is followed by an empty string ("") so put in the image location and escape backslashes with double \\.
Save
restart PowerToys.

I didn't quite understand the 4th part. Can you tell me what the path in the JSON file would look like if my image was at "C:\Test Folder\Camera Overlay.bmp"

I didn't quite understand the 4th part. Can you tell me what the path in the JSON file would look like if my image was at "C:\Test Folder\Camera Overlay.bmp"

Like this: `camera_overlay_image_path: "C:\Test Folder\Camera Overlay.bmp"

I didn't quite understand the 4th part. Can you tell me what the path in the JSON file would look like if my image was at "C:\Test Folder\Camera Overlay.bmp"

Like this: camera_overlay_image_path: "C:\\Test Folder\\Camera Overlay.bmp"

Ok thank you for all the help. It worked.


Attribute ranking order

(Sorry for spamming you with pull requests, but it's just too much fun 🤠)
Add a new relevance factor: attribute ranking order. Give slight precedence to matches that appear early in the list of searchable attributes. This will naturally rank matches in the title higher, assuming title appears first in the list.
The behavior is modeled on Meilisearch. When searchable attributes are not configured (['*']), attribute order is ignored. When they are configured, they are ranked in order of appearance: ['title', 'summary'] will slightly prefer title matches. The factor is currently 0.8, I'm seeing reasonable results with that. The factor below 1 technically downranks matches in later attributes, rather than uprank earlier attributes, but this way we don't get final relevance scores above 1.
See the Meilisearch docs on Attribute ranking order for details.
Usage
No intrinsic ranking
Configuration::create()->withSearchableAttributes(['*'])

Intrinsic ranking by order
# Prefer matches by order of appearance in this list: `title` > `summary` > `body`

Configuration::create()->withSearchableAttributes(['title', 'summary', 'body'])

Example matches
Example rankings when searching for game of life. The first relevance column uses ['*'] as searchable attributes, the second relevance column uses ['title', 'content']

Title
Content
Without attribute order
With attribute order

Game of life
A thing with everlasting learning
1.0
1.0

Everlasting learning
The unexamined game of life
1.0
0.88

Learning to game
What life taught me about learning
0.83
0.78

Love it! ❤ What do you think, should we add some info about the ranking algorithm to the docs? Previously, there was not much to document as you could not influence it anyway. Now you can by defining the order of the searchable attributes. So I think now it would deserve some docs...

@Toflar Sure! Let me whip up a quick draft.

@Toflar I've created a separate PR #113 with new docs on the ranking factors. Let's discuss over there :)

Thanks for adding a third ranking factor ❤


Isolated variables can escape isolated functions via closures

Description:
It seems below paragraph from the spec is not yet implemented. Hence $title.
Captured variables are restricted as follows: if the body is part of an anonymous-function-expr,
then any captured variable references must refer to variables that are both final
(either explicitly or implicitly) and have a static type that is a subtype of readonly|isolated object {}.

Sample:
import ballerina/io;

final C c = new();

public function main(){

    foo();

    var a = c.get();
    if !(a is ()) {
        map<int> mapResult = a(); // mapResult is allocated in foo();
        io:println(mapResult);
        mapResult["hi"] = 1;
    }

    a = c.get();
    if !(a is ()) {
        io:println(a());
    }
}

isolated function foo() {
    map<int> m = {};
    lock {
        // `m` escape via closure
        c.set(() => m);
    }
}

isolated class C {
    private int i = 0;
    private (function () returns map<int>)? m = ();

    public isolated function set(function () returns map<int> f) {
        lock {
            self.m = f;
        }
    }

    public function get() returns (function () returns map<int>)? {
        lock {
            return self.m;
        }
    }
}

Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

This restriction applies only when the body is part of an anonymous-function-expr and the function is declared as isolated. https://ballerina.io/ballerina-spec/spec.html#isolated_functions
In the case of foo, with the implicit anonymous function expression the relevant function type (the contextually-expected type of C.set's parameter) is not isolated, so this restriction does not apply here, right? But if you change C.set to accept an isolated function () => m in foo will result in a compilation error.
isolated function foo() {
    map<int> m = {};
    lock {
        c.set(() => m); // error: invalid access of mutable storage in an 'isolated' function
    }
}

isolated class C {
    private int i = 0;
    private (function () returns map<int>)? m = ();

    public isolated function set(isolated function () returns map<int> f) {
        lock {
            self.m = f;
        }
    }

    public function get() returns (function () returns map<int>)? {
        lock {
            return self.m;
        }
    }
}

Also, in the original example, calling the function returned by c.get() is also not an issue since the main function is not isolated. But if you make the main function isolated, the function returned by c.get() cannot be called there.
Only isolated variables and isolated objects are considered to be isolated roots (https://ballerina.io/ballerina-spec/spec.html#section_5.1.3). An isolated function only provides a guarantee regarding the mutable state it accesses; quoting from the spec

Ballerina guarantees that a call an isolated method or function will only result in access to mutable state if at least one of the following conditions applies:

the mutable state is freely reachable from an argument passed to the function or method and the access happens on the strand on which the function is called; the object on which a method is invoked is considered as an argument for this purpose;
the mutable state is freely reachable from an isolated variable or an isolated object;
the mutable state is part of a new value created by the call.

So, IMO, this is okay.


Adding a tour through manim

A guide through Manim and all it's useful features.
Tries to help with

#3157

-> https://manimce--3495.org.readthedocs.build/en/3495/adventure.html

Next step adding the rate_function overview and group overview of animation categories

Also on the list:
Add VGroup and updaters.

For the updaters i already have a good idea!

I officially hate the github app

Do we want to replace the current quickstart with this?

You can now find the docs here:
https://manimce--3495.org.readthedocs.build/en/3495/adventure/index.html

TODO: Chapter on custom Mobjects, overhaul updaters and value trackers

Todo highlighting individual letters in equations using indices


My TRHolograms is not working

I was in a normal day and i want a change of world in my server i have 4 holograms well all its ok but when i changed the world the plugin stop workin when i put PL in my console show me the plugin is in green ok i think is working i joined the server and the comand doesnt shows please help
-sorry about my english

Try / hd reload


Adding a delegate method for receiving current playtime updates

This solves #51, even though it was already answered on StackOverflow.

thanks @eliotfowler ! if you have a moment to add the delegate method to the sample project, so that CI passes, that'd be helpful too. ✌

@piemonte Sorry about that! Added them in!


Remove tf_http_archive external Python deps

Migrate TF Python deps from being defined as tf_http_archives in workspace2.bzl to being in requirements.in. This consolidates where Python dependencies are defined, allows them to be more easily updated and also allows any version updates to be easily transferred to requirement.txt locked versions using the Hermetic Python requirements updater. Remove any downstream references to the deleted tf_http_archive repositories and if relevant replace them with @pypi_name//:pkg.

Hi @halseycamilla Can you please resolve conflicts? Thank you!

Hi @halseycamilla Can you please resolve conflicts? Thank you!

resolved!

ROCm is failing but it seems as though it currently isn't in the TF .bazelrc file anymore so that should be expected. There is a separate PR rn in TF https://github.com/tensorflow/tensorflow/pull/61527 that appears to be trying to add it back.

Hi @halseycamilla Can you please resolve conflicts? Thank you!


NullReferenceException in resolve-dependencies

I get the following error when using Blazor.Server on an F# project:
EXEC : error : Object reference not set to an instance of an object. [C:\Users\loic.denuziere\my\miniblazor\tests\server\server.fsproj]
     at Microsoft.AspNetCore.Blazor.Build.RuntimeDependenciesResolver.AssemblyResolutionContext.<ResolveAssemblies>g__GetAssemblyReferences|13_1(AssemblyEntry current) in /_/src/Microsoft.AspNetCore.Blazor.Build/Core/RuntimeDependenciesResolver.cs:line 103
     at Microsoft.AspNetCore.Blazor.Build.RuntimeDependenciesResolver.AssemblyResolutionContext.<ResolveAssemblies>g__ResolveAssembliesCore|13_0(<>c__DisplayClass13_0& ) in /_/src/Microsoft.AspNetCore.Blazor.Build/Core/RuntimeDependenciesResolver.cs:line 91
     at Microsoft.AspNetCore.Blazor.Build.RuntimeDependenciesResolver.AssemblyResolutionContext.ResolveAssemblies() in /_/src/Microsoft.AspNetCore.Blazor.Build/Core/RuntimeDependenciesResolver.cs:line 82
     at Microsoft.AspNetCore.Blazor.Build.RuntimeDependenciesResolver.ResolveRuntimeDependenciesCore(String entryPoint, String[] applicationDependencies, String[] monoBclDirectories) in /_/src/Microsoft.AspNetCore.Blazor.Build/Core/RuntimeDependenciesResolver.cs:line 46
     at Microsoft.AspNetCore.Blazor.Build.Cli.Commands.ResolveRuntimeDependenciesCommand.<>c__DisplayClass0_0.<Command>b__0() in /_/src/Microsoft.AspNetCore.Blazor.Build/Cli/Commands/ResolveRuntimeDependenciesCommand.cs:line 44
C:\Users\loic.denuziere\.nuget\packages\microsoft.aspnetcore.blazor.build\0.7.0-preview1-20180925.6\targets\Blazor.MonoRuntime.targets(538,5): error MSB3073: The command "dotnet "C:\Users\loic.denuziere\.nuget\packages\microsoft.aspnetcore.blazor.build\0.7.0-preview1-20180925.6\targets\../tools/Microsoft.AspNetCore.Blazor.Build.dll" resolve-dependencies "C:\Users\loic.denuziere\my\miniblazor\tests\server\obj\Debug\netcoreapp2.0\server.dll" --references "C:\Users\loic.denuziere\my\miniblazor\tests\server\obj\Debug\netcoreapp2.0\blazor\resolve-dependencies.txt" --base-class-library "C:\Users\loic.denuziere\.nuget\packages\microsoft.aspnetcore.blazor.build\0.7.0-preview1-20180925.6\targets\../tools/mono/bcl/" --base-class-library "C:\Users\loic.denuziere\.nuget\packages\microsoft.aspnetcore.blazor.build\0.7.0-preview1-20180925.6\targets\../tools/mono/bcl/Facades/" --output "C:\Users\loic.denuziere\my\miniblazor\tests\server\obj\Debug\netcoreapp2.0\blazor\resolved.assemblies.txt"" exited with code 1. [C:\Users\loic.denuziere\my\miniblazor\tests\server\server.fsproj]

I ran this with a locally built Razor with print debugging to find what was going on, and it seems that the problem is that it can't find System.Buffers.dll; it's not copied locally, and it's not in mono's stdlib either. And indeed, the issue disappears if I add this to my project:
  <ItemGroup>
    <ReferenceCopyLocalPaths Include="$(NuGetPackageRoot)system.buffers/4.5.0/lib/netstandard2.0/System.Buffers.dll" />
  </ItemGroup>

I got a similar error a few weeks ago. I was using a project that directly referenced a dll which itself directly referenced System.ServiceModel.Discovery (which isn't supported under .NET Standard). I too had to result to running the tool under the debugger to figure out what was happening.
FindCandidate() can return null, which means Resolve() can return null, which means GetAssemblyReferences() (or somewhere sooner), needs to do something more reasonable.


IdS4 with EF6 & BrockAllen.MembershipReboot

I have an EF6 model with MembershipReboot for user management.
How can I configure IdentityServer4 to get user data from EF6 and MembershipReboot?

Good question, in the IdSrv4 docs I only could find a sample using ASP.NET Core Identity as user service. But no mention of MembershipReboot.
Do the developers still see a future for MembershipReboot or should we already think of a migration?

https://github.com/brockallen/BrockAllen.MembershipReboot/issues/568#issuecomment-222208300
Having said that, you could use MR in IdSvr4 -- there's not reason you can't use EF6 (assuming net46, et al.), or build a similar EF Core persistence layer if you want netcoreapp1.0. Also, I've been thinking of providing a migration tool -- but that's just an idea right now. I don't really know what would be involved, or if it's even 100% possible (of course the password being the biggest issue to migrate).
I'd be curious to hear feedback from people here on the issue.

Hi Brock,
we already had to handle a migration from a custom legacy account store to MembershipReboot and did it by storing the old password a long with the new one that MR takes care of. Therefore we implemented our own AuthenticateLocalAsync which takes care of the password migration from the old (insecure) legacy password store to MR. AuthenticateLocalAsync is the only place were the password is available in plain text to be used for some migration.
I'm personally looking at this rather from a strategic point of view. What I don't want is to get our user accounts stuck in an user account store that isn't actively maintained anymore. So the main question is if the suggestion for IdSrv4 maintainers is to use MR - if no our datasource is already in place for local accounts -  (or some .Net Core version of it) or to plan a migration to ASP.Net Core Identity (how ever this might look).
Of course we will have a close look our functional requirements (and NFOs, too) ... security, multi-tenancy, claims-aware.
Were we see clear improvement potential is validation of usernames, email addresses and passwords. This is were MR lacks a clear interfaces or injection point, so if some major refactoring is done, this would be a suggestion of me make design improvements here.

I don't want to speak for Brock - but it seems that MR is at a point where it becomes more community driven (taking responsibility vs suggesting & feature requests) -
or we accept the fact that ASP.NET Identity has become decent enough that MR is not needed anymore.

https://github.com/brockallen/BrockAllen.MembershipReboot/issues/568#issuecomment-222208300
https://github.com/brockallen/BrockAllen.MembershipReboot/commit/2c74d4b39145b8e0120945917509c0dd0a8bf83b


support for specifiying a custom specification url

Configuration services for hardware devices should be customizable.

I think it would be more user-friendly (and extensible) to have device description JSON URL in the control service, and have list of specification URLs there

Yes list of URLs is better

From: Michał Moskal<EMAIL_ADDRESS>Sent: Friday, March 5, 2021 7:00:52 PM
To: microsoft/jacdac<EMAIL_ADDRESS>Cc: Peli de Halleux<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/jacdac] support for specifiying a custom specification url (#274)
@mmoskal commented on this pull request.

In spectool/jdspec.d.tshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fjacdac%2Fpull%2F274%23discussion_r588533493&data=04|01|jhalleux%40microsoft.com|08eec2f92ea5408f996408d8e0009e4d|72f988bf86f141af91ab2d7cd011db47|1|0|637505640547914039|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=vj%2FgNHAPxsI7YHPDVjZd7hXDw9I70c6eGf9KEDJ15fY%3D&reserved=0:

@@ -563,6 +563,28 @@ declare namespace jdspec {
*/
repo: string

   /**

    * Optional map of service class to a URL pointing to a service specification markdown file

    */

   serviceSpecificationsUrls?: {

       [serviceClass: number]: string

Would it be much worse to just have a list of URLs and you figure out the service class from the markdown? less redundancy, so less chances for failure
JSON doesn't really have a map from number so it will look like "449414863": "https://..", but then people may want to use "0x1ac986cf": "https://..."
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fjacdac%2Fpull%2F274%23pullrequestreview-605471604&data=04|01|jhalleux%40microsoft.com|08eec2f92ea5408f996408d8e0009e4d|72f988bf86f141af91ab2d7cd011db47|1|0|637505640547924032|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=2ucGtXtdJglZy%2Fr8k5dlWR5FR%2B9TSCkS2g0las2rV2E%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKO7EDECH27YLINNUSTTCEL5JANCNFSM4YSYQDMQ&data=04|01|jhalleux%40microsoft.com|08eec2f92ea5408f996408d8e0009e4d|72f988bf86f141af91ab2d7cd011db47|1|0|637505640547924032|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=dgh6aHxBA%2FJ7A9KGs%2Bhl3bYZb824tJnNsND3kHfhxU8%3D&reserved=0.


test.py

hi
u know how i can be ccontributor  in a projects here ?
im new to github my friends
best regards


Fixed bug with invoke cli and invoke nbshell.

Closes: #DNE
What's Changed

After #5055 when running invoke cli or invoke nbshell you get this error:
TypeError: tasks.docker_compose() got multiple values for keyword argument 'pty'
This fixes that bug.
TODO

[ ] Explanation of Change(s)
[ ] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

Seems to be broken in next as well, should we port this to next?


Support searching for multiple terms

Right now, the search looks for a full string match, meaning it's not possible to, for example, search for multiple tags, or tags and terms together. The search string should be tokenised and the tokens searched for independently. Ideally, this would support quoted strings, and even use of the '-' prefix to indicate strings that should be omitted.

Done, but only supporting space separated terms. This can surely be revisited in the future to explicitly add quoted strings and operators.

Fixed in<PHONE_NUMBER>315ec293ca7d0ded720804a2639359.


Should TrafficManager.dll be copied to deploy dir twice?

This is post-build script for TLM project (using - diff formatting to highlight applicable lines):
set "DEPLOYDIR=$(LOCALAPPDATA)\Colossal Order\Cities_Skylines\Addons\Mods\$(TargetName)\"
- xcopy /y "$(TargetDir)TrafficManager.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)TMPE.CitiesGameBridge.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)TMPE.GenericGameBridge.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)TMPE.API.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)CSUtil.CameraControl.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)TMPE.RedirectionFramework.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)CSUtil.Commons.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)0TMPE.Harmony.dll" "%DEPLOYDIR%"

rem To avoid double hot reload, TrafficManager.dll must be replaced last and fast.
rem Once TrafficManager.dll is re-loaded, all other dlls will be reloaded as well
del  "%DEPLOYDIR%TrafficManager.dll"
- xcopy /y "$(TargetDir)TrafficManager.dll" "%DEPLOYDIR%"

echo THE ASSEMBLY VERSION IS: @(VersionNumber) created at %time%
set DEPLOYDIR=

Sorry my bad!


create type declarations

closes #9

This configuration has lots of errors when we try to run the type checks for it:

I'm struggling to get the configuration right to correct them.
On the plus side, TypeScript caught some minor mistakes. The mistakes did not cause any bugs that I'm aware of, but I did clean up the code a bit.

I don't think typescript picks up anything other than files named tsconfig.json, you would probably have to supply it on the CLI with -p .tsconfig.json (-p is a shorthand for --project)
And as you are supplying source files on the command line to tsc it won't let you supply a project with it (it will raise TS5042 error), so either change the files array in the tsconfig.json to match tsc or add --moduleResolution node to the tsc command line.
I added --moduleResolution node to the command line and it got rid of the previous module resolution errors, but raised an error in your code
$ npm run -s typescript

src/index.js:38:19 - error TS2322: Type 'string' is not assignable to type 'number'.

38       .map((x) => x.toString(16))
                     ~~~~~~~~~~~~~~

  node_modules/typescript/lib/lib.es5.d.ts:2257:21
    2257     map(callbackfn: (value: number, index: number, array: Uint8Array) => number, thisArg?: any): Uint8Array;
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    The expected type comes from the return type of this signature.

Found 1 error in src/index.js:38

Unrelated to the PR but related to the above error, sha3 returns a JS Uint8Array, so when you run .map it will parseInt the return value and so many elements in the array will be 0 because they can't be coerced into a number. is this behavior in the code intentional?

Unrelated to the PR but related to the above error, sha3 returns a JS Uint8Array, so when you run .map it will parseInt the return value and so many elements in the array will be 0 because they can't be coerced into a number. is this behavior in the code intentional?

Good eye! I have no idea why this worked and actually produced ids that passed our quality tests. 👀
I'm adding a fix now. Running the test suite and producing new randogram and histograms.

Fixes are in the typescript branch. Would you like to merge it into your branch and review the changes?

Typechecks passed for me. Let me know if I need to do anything else


Sycamore: added summary of completed surveys table

Thank you Ilya! I think I have resolved those stylistic changes. Let me know if there is anything else.

Hi Ilya, I've updated the files based on the formatting changes. Let me know if you need anything else.


THRIFT-5383 Fix misplaced capacity check

The added test passes with thrift 0.13.0 and fails on 0.14.0. The source of the error seems to be an unnecessary capacity check when reading JSON string.

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

-1 the check is NOT unnecessary


Update code to match Ruby styleguide

Hey there, the removal of AttributeNotFoundError has broken some of our code which relied on it. In this case, should we be using NoMethodError instead?

Hey @andyhansen,
Yes, that would be the best solution. I found that there was no benefit internally for wrapping the error as it should be handled in the same way to avoid strange behaviour and some edge cases (there used to be 2 handlers internally, one for NoMethodError and one for AttributeNotFoundError for every single exception check, which made no sense in many cases.
Otherwise, I'd advise to use return_nil_for_empty in the cases in which this is an issue for you.
Hope this explains the reasoning a bit further,
Cheers


issue about Speaking state

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

Speaking just stayed for a moment and changed to Idle state immediately, no sound was played.
What is the expected behavior?

After I said something(Eg. set kitchen timer for 30 seconds), the state went to Thinking -> Speaking -> Idle.
But the Speaking state just stayed for a moment, and changed to Idle state immediately, no response was played.
What behavior are you observing?

The Speaking state should stayed for several seconds and the response from AVS should be played.
Provide the steps to reproduce the issue, if applicable:

It is not easy to reproduce.
The most recent case is that I said "Set kitchen timer for 30 seconds".
Tell us about your environment:

What version of the AVS Device SDK are you using?
  <1.9.0>

Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[x] Other - tell us more:

Tell us about your OS (Type & version):

[x] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hi @bill-lzb, this sounds very similar to #839.  The issue has been fixed recently in v1.10.  Could you try that software release?  Thanks!

I am closing this issue due to inactivity. Please feel free to re-open it if it has been closed in error.


major algorithmic update to rsa_noise_ceiling.py

ported recent commits from matlab implementation to python - major revamp of rsa_noise_ceiling.py to incorporate recent updates to the algorithm (e.g. split half procedures, plotting)
fixed bug in calc_shrunken_covariance that was causing incorrect shrinkage values to be selected if any negative log likelihood values were nan
added relevant files to utilities.py
i have tested the new implementation by verifying that it provides the same outputs as the matlab implementation given the same input data (up to a few decimal places- there is randomness built into the pipeline so outputs will not be numerically identical). plot outputs also look virtually identical.
this implementation has not been fully edge-cased and may be subject to bugs outside of the main use cases - should test further when possible.

Also, bear in mind that I think Ian ported some utilities (for GLMsingle), so in a sense you duplicated effort:
GLMsingle/glmsingle/cod/calc_cod.py
GLMsingle/glmsingle/utils/zerodiv.py
I wonder if his port and your port are equally good/right.  Interesting...
In theory you could use his ports instead of yours if you wanted to consolidate..   Up to you how you want to handle this

Also, the "internal inputs" docstring part --- this was not intended to be exposed to the user (that's why the MATLAB version has an extra line before this part).  Can you hide that from the doc string (maybe an extra line)?

And, a general question:  Was your port intended to be an exact port?  Was there any part where things seemed iffy?  For example, those utility functions might have been hairy to get exactly identical, maybe?

re: the use of np.inf, yes i will definitely update the docstring.
thanks for pointing out the testdataFFA50 case, i will run that and report back via slack.
re: the utility functions, i directly copied Ian's implementations of calc_cod and zerodiv, so to the extent to which his implementations are solid for GLMsingle, they shouldn't pose problems for GSN. i implemented squish, posrect, and nanreplace myself. i think these three functions are relatively straightforward - hopefully no issues there.
will definitely hide the internal inputs from the user.
i tried to go for an exact port, but there are probably slight divergences. for example, i didn't implement errorbar2.m in python so that component of the plotting routine is missing. in at least one other place, i used a different data structure than you did for convenience (e.g. a dictionary vs. a cell array) or had to modify an implementation detail (e.g. in python you can't dynamically expand an array by adding a value to the end+kth row, so the expansions of datasplitr and modelsplitr required concatenating new empty matrices to the existing matrices. i don't think these slight details would cause any divergent noise ceiling estimates - overall, i was shooting for an "exact" port up to the limit of whatever is randomized within the pipeline. however, i'm pretty sure i could find a bug (or multiple) if i tried hard enough via edge casing or passing weird/unexpected inputs. will inevitably discover these as we move forward.

ok sounds good.
But it seems like plotting error bars would be a good idea.  No rush, maybe you can just open a new Issue.

this pull request is outdated. closing.


Version in the Helm chart is not SemVer

Describe the bug:
The version of the Helm chart is set to the same values as the project version that has a v prefix. For example the current version is v1.15.1
Helm charts should have a SemVer 2 version. See Charts and Versioning, and "v1.15.1" is not a SemVer.
This means that when the chart is pushed to an OCI registry, it cannot then be found because Helm is looking for a SemVer tag.
> helm push cert-manager-v1.15.1.tgz oci://myregistry.io/jetstack
Pushed: myregistry.io/jetstack/cert-manager:v1.15.1
Digest: sha256:ef48395cd744fec58370e77170cf4f80b1cf9bd5ccdc7fe8265e8b6a599cca4a

> helm pull oci://myregistry.io/jetstack/cert-manager
Error: Unable to locate any tags in provided repository: oci://myregistry.io/jetstack/cert-manager

Expected behaviour:
After pushing the Helm chart helm pull should pull the chart with the latest SemVer version.
Steps to reproduce the bug:
If you push the cert-manager Helm chart to an OCI repo and then try to pull it, it will fail
> helm push cert-manager-v1.15.1.tgz oci://myregistry.io/jetstack
Pushed: myregistry.io/jetstack/cert-manager:v1.15.1
Digest: sha256:ef48395cd744fec58370e77170cf4f80b1cf9bd5ccdc7fe8265e8b6a599cca4a

> helm pull oci://myregistry.io/jetstack/cert-manager
Error: Unable to locate any tags in provided repository: oci://myregistry.io/jetstack/cert-manager

If I edit the version: in Chart.yaml to version: 1.15.1 and re-package and push it works as expected.
> helm push cert-manager-1.15.1.tgz oci://myregistry.io/jetstack
Pushed: myregistry.io/jetstack/cert-manager:1.15.1
Digest: sha256:ee0e2e3c1e34fbbd109fde71c9955143491628185ed3cb702c73e644dea5e5c0

> helm pull oci://myregistry.io/jetstack/cert-manager
Pulled: myregistry.io/jetstack/cert-manager:1.15.1
Digest: sha256:ee0e2e3c1e34fbbd109fde71c9955143491628185ed3cb702c73e644dea5e5c0

Note: this is the underlying cause of the issue #7198
/kind bug

Thanks for the report.
This is a duplicate of https://github.com/cert-manager/cert-manager/issues/2380. See all the comments in that issue particularly towards the end where I described a workaround.

https://github.com/cert-manager/cert-manager/issues/2380

xref:

https://github.com/cert-manager/cert-manager/pull/7132
https://github.com/helm/helm/issues/11107


SAK-30469 Fixes for favorites drawer accessibility

Add display: none to the sites drawer element when it's offscreen

Don't put the sites drawer into the DOM unless the user's logged in

Restore the label on the search box but mark it sr-only to make it visible only to screen readers

:+1:


Support 'singleProcessOOMKill' kubelet config flag?

Description
What problem are you trying to solve?
In https://github.com/kubernetes/kubernetes/pull/126096 the kubelet config flag singleProcessOOMKill was added to allow disabling the "cgroup aware OOM Killer". Is there a way to set this flag from karpenter? in particular for a node running Bottlerocket?

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

We've moved our kubeletconfiguration into cloudprovider-specific NodeClasses to allow each CloudProvider to decide which configuration that they want to support. I'd recommend opening an issue in the cloudprovider-specific repo so that folks from that provider can chime in to what their support is for certain features/settings.


Fix incorrect owning_app for some documents

There are currently 15 smart-answer documents with owning-app publisher, which should be smartanswers. Also one travel-advice with publisher instead of travel-advice-publisher. These were put in by mistake (see https://github.com/alphagov/panopticon/pull/296).
We need to fix these to keep the database consistent and set the content_id for all documents by publisher.
Trello: https://trello.com/c/rmBoBPm9

Closing this. The artefacts are technically owned by publisher, so it doesn't mattter if they will get content_ids. We should add a task to remove these artefacts from the database, but that doesn't have  priority right now.


Trying to add requirement, also storing in google cloud registry

testing

:star: PR built and available in a preview environment zmailloux-python-flask-docker-pr-2 here

:star: PR built and available in a preview environment zmailloux-python-flask-docker-pr-2 here


feature: gql search resolvers

What Changed

Adding GraphQL resolvers to allow search queries against Algolia directly. Closes #2

Checklist

[x] PR description included
[x] npm test passes
[x] Tests are changed or added
[x] Relevant documentation is changed or added

Great work! This feature is the only thing that gave the opensearch method a little edge.


Allow specifying subformat for the vmdk type in org.osbuild.qemu stage

Add unit test for the qemu stage
Allow specifying subformat for the vmdk type in org.osbuild.qemu stage

Nice! This should also come in handy for a future vagrant stage for virtualbox! (As it requires vmdk images)


Publish NuGet package

Configure Azure DevOps to publish NuGet package

Sorry, didn't mean to submit the PR to this repo

Hey @Herohtar, it's cool that you thought this code was interesting enough to fork. I'm curious about what you liked about it?


Test exec

Pre-Review Checklist for the PR Author

[ ] Code follows the coding style of CONTRIBUTING.md
[ ] Tests follow the best practice for testing
[ ] Changelog updated in the unreleased section including API breaking changes
[ ] Branch follows the naming format (iox-123-this-is-a-branch)
[ ] Commits messages are according to this guideline

[ ] Commit messages have the issue ID (iox-#123 commit text)
[ ] Commit messages are signed (git commit -s)
[ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[ ] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[ ] Relevant issues are linked
[ ] Add sensible notes for the reviewer
[ ] All checks have passed (except task-list-completed)
[ ] All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt
[ ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior

[ ] Each unit test case has a unique UUID

[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes TBD

This change is

Codecov Report

Merging #27 (08fc945) into master (c30d930) will increase coverage by 0.03%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   78.86%   78.90%   +0.03%
==========================================
  Files         378      379       +1
  Lines       14483    14489       +6
  Branches     2028     2028
==========================================
+ Hits        11422    11432      +10
+ Misses       2433     2431       -2
+ Partials      628      626       -2

Flag
Coverage Δ

unittests
78.56% <85.71%> (+0.03%)
:arrow_up:

unittests_timing
14.89% <33.33%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...fs/internal/posix_wrapper/shared_memory_object.hpp
87.50% <ø> (ø)

...nternal/relocatable_pointer/pointer_repository.inl
88.63% <ø> (ø)

...eoryx_hoofs/source/posix_wrapper/message_queue.cpp
0.00% <ø> (ø)

...oofs/source/posix_wrapper/shared_memory_object.cpp
77.63% <50.00%> (-0.58%)
:arrow_down:

...include/iceoryx_hoofs/internal/concurrent/sofi.inl
85.00% <90.90%> (+0.78%)
:arrow_up:

...include/iceoryx_hoofs/internal/concurrent/sofi.hpp
100.00% <100.00%> (ø)

iceoryx_hoofs/source/posix_wrapper/named_pipe.cpp
59.37% <100.00%> (+0.86%)
:arrow_up:

iceoryx_posh/source/mepoo/memory_manager.cpp
97.05% <0.00%> (+1.96%)
:arrow_up:

iceoryx_hoofs/source/concurrent/loffli.cpp
91.42% <0.00%> (+5.71%)
:arrow_up:


Use dotenv for env-file parsing

This makes it possible to write multi-line strings. Also, dotenv is the same library docker-compose uses.

I'd like to see this.  I recently had to work with RSA keys.  For now, I am using both python-decouple and python-dotenv in order to have the multiline keys loaded into my settings.py.  I'd rather not switch to using python-dotenv; so accepting this branch would be great.
Thanks--
Al


fix(GetUnusedAll) - JSON concatenation

This PR aims to resolve #226.
Currently when executing GetUnusedAll() with JSON format, instead of merging the two lists, it appends them.
This also resolves the Error parsing JSON: invalid character '{' after top-level value returned from kor exporter.
Before the fix:
$ kor all -o json
{
  "test": {
    "ConfigMap": null,
    "DaemonSet": null,
    "Deployment": null,
    "Hpa": [
      "php-apache"
    ],
    "Ingress": [
      "test-ingress-1-work"
    ],
    "Job": null,
    "Pdb": null,
    "Pvc": [
      "myclaim"
    ],
    "ReplicaSet": null,
    "Role": null,
    "Secret": null,
    "Service": [
      "app1-service",
      "app2-service"
    ],
    "ServiceAccount": null,
    "StatefulSet": null
  }
}{
  "": {
    "ClusterRole": [
      "admin",
      "view"
    ],
    "Crd": [
      "thanosrulers.monitoring.coreos.com"
    ],
    "Pv": null,
    "StorageClass": null
  }
}

After the fix:
$ kor all -o json
{
  "": {
    "ClusterRole": [
      "admin",
      "view"
    ],
    "Crd": [
      "thanosrulers.monitoring.coreos.com"
    ],
    "Pv": null,
    "StorageClass": null
  },
  "test": {
    "ConfigMap": null,
    "DaemonSet": null,
    "Deployment": null,
    "Hpa": [
      "php-apache"
    ],
    "Ingress": [
      "test-ingress-1-work"
    ],
    "Job": null,
    "Pdb": null,
    "Pvc": [
      "myclaim"
    ],
    "ReplicaSet": null,
    "Role": null,
    "Secret": null,
    "Service": [
      "app1-service",
      "app2-service"
    ],
    "ServiceAccount": null,
    "StatefulSet": null
  }
}

Codecov Report
Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 47.20%. Comparing base (4a79f02) to head (6cda98e).

Files
Patch %
Lines

pkg/kor/all.go
0.00%
25 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   47.58%   47.20%   -0.38%
==========================================
  Files          32       32
  Lines        2915     2938      +23
==========================================
  Hits         1387     1387
- Misses       1354     1377      +23
  Partials      174      174

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


no_priority: nag only after the bug has been triaged (and not after i…

…t has been created

Coverage decreased (-0.01%) to 30.921% when pulling a74b16a40a5a8e93badad3e4171722185f595aac on calixteman:issue_552 into 02b6acc098218fb424bbf2cc8afa314f1af6775b on mozilla:master.


watchman: 2<IP_ADDRESS> -> 2<IP_ADDRESS>

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Can #248660 be addressed along the way? I tried moving some {nativeBuild,build}Inputs around but failed to shrink the closure...

@bryango Right now I don't think we need to do anything. boost is required for running watchman. On the other hand, gcc is for building watchman. If you install watchman from binary cache, gcc is not needed.

The upstream binary is tiny, with a size < 10 M.

I guess it's static linking.

gcc is for building watchman. If you install watchman from binary cache, gcc is not needed.

I thought so but no, gcc still ends up in the output closure. I did install the package from binary cache. Maybe it comes from some propagated build inputs?
I couldn't identify its origin, but I'm certain it's only required by watchman in my system.

The upstream binary is tiny, with a size < 10 M.

I guess it's static linking.

Indeed, but when there is such a storage overhead, should we consider static linking ourselves? Or is there a nixpkgs policy against it? (Sorry I'm a noob...

I also double checked that it builds on x86_64-darwin via Rosetta 2, so I'm not sure what was flaky on CI.