enable strictFunctionTypes in VS Code codebase

Problem
For an example service defined in VS Code core:
export class MyService {
  constructor(
    private readonly value: string,
    @ITextModelService private readonly textModelResolverService: ITextModelService
  ) { }
}

It is currently possible to use the instantiation service to create an instance of MyService that passes undefined for value:
instantiationService.createInstance(MyService, undefined);

This does not produce any compile errors. It does bypass our strict null checking however and can cause unexpected runtime behavior.
Proposed fix
Enable strictFunctionTypes in our code base
There are about 800 or so errors related to this in our code base today. While some of these errors are simple, many are rather cryptic and some may prove difficult to fix

[ ] vs/code/electron-main/main.ts
[ ] vs/editor/contrib/referenceSearch/referencesWidget.ts
[ ] vs/workbench/browser/labels.ts
[ ] vs/workbench/browser/parts/activitybar/activitybarPart.ts
[ ] vs/workbench/browser/parts/compositeBar.ts
[ ] vs/workbench/browser/parts/compositePart.ts
[ ] vs/workbench/browser/parts/editor/breadcrumbsPicker.ts
[ ] vs/workbench/browser/parts/editor/editorGroupView.ts
[ ] vs/workbench/browser/parts/editor/editorPicker.ts
[ ] vs/workbench/browser/parts/editor/editorWidgets.ts
[ ] vs/workbench/browser/parts/notifications/notificationsList.ts
[ ] vs/workbench/browser/parts/panel/panelPart.ts
[ ] vs/workbench/browser/parts/quickinput/quickInputList.ts
[ ] vs/workbench/browser/parts/quickopen/quickOpenController.ts
[ ] vs/workbench/browser/parts/views/customView.ts
[ ] vs/workbench/browser/parts/views/viewsViewlet.ts
[ ] vs/workbench/common/editor/dataUriEditorInput.ts
[ ] vs/workbench/common/editor/editorGroup.ts
[ ] vs/workbench/contrib/callHierarchy/browser/callHierarchyPeek.ts
[ ] vs/workbench/contrib/comments/browser/commentsEditorContribution.ts
[ ] vs/workbench/contrib/debug/browser/breakpointEditorContribution.ts
[ ] vs/workbench/contrib/debug/browser/breakpointsView.ts
[ ] vs/workbench/contrib/debug/browser/callStackView.ts
[ ] vs/workbench/contrib/debug/browser/debugEditorContribution.ts
[ ] vs/workbench/contrib/debug/browser/debugHover.ts
[ ] vs/workbench/contrib/debug/browser/debugService.ts
[ ] vs/workbench/contrib/debug/browser/debugViewlet.ts
[ ] vs/workbench/contrib/debug/browser/loadedScriptsView.ts
[ ] vs/workbench/contrib/debug/browser/repl.ts
[ ] vs/workbench/contrib/debug/browser/variablesView.ts
[ ] vs/workbench/contrib/debug/browser/watchExpressionsView.ts
[ ] vs/workbench/contrib/extensions/browser/extensionsViews.ts
[ ] vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
[ ] vs/workbench/contrib/extensions/electron-browser/runtimeExtensionsEditor.ts
[ ] vs/workbench/contrib/feedback/browser/feedbackStatusbarItem.ts
[ ] vs/workbench/contrib/files/browser/saveErrorHandler.ts
[ ] vs/workbench/contrib/files/browser/views/emptyView.ts
[ ] vs/workbench/contrib/files/browser/views/explorerView.ts
[ ] vs/workbench/contrib/files/browser/views/openEditorsView.ts
[ ] vs/workbench/contrib/markers/browser/markers.ts
[ ] vs/workbench/contrib/markers/browser/markersTreeViewer.ts
[ ] vs/workbench/contrib/outline/browser/outlinePanel.ts
[ ] vs/workbench/contrib/output/browser/outputActions.ts
[ ] vs/workbench/contrib/preferences/browser/keybindingsEditor.ts
[ ] vs/workbench/contrib/preferences/browser/keybindingsEditorContribution.ts
[ ] vs/workbench/contrib/preferences/browser/keybindingWidgets.ts
[ ] vs/workbench/contrib/preferences/browser/preferencesRenderers.ts
[ ] vs/workbench/contrib/quickopen/browser/commandsHandler.ts
[ ] vs/workbench/contrib/remote/browser/remote.ts
[ ] vs/workbench/contrib/scm/browser/mainPanel.ts
[ ] vs/workbench/contrib/scm/browser/repositoryPanel.ts
[ ] vs/workbench/contrib/search/browser/openFileHandler.ts
[ ] vs/workbench/contrib/search/browser/search.contribution.ts
[ ] vs/workbench/contrib/search/browser/searchView.ts
[ ] vs/workbench/contrib/search/common/searchModel.ts
[ ] vs/workbench/contrib/terminal/browser/terminalInstance.ts
[ ] vs/workbench/contrib/terminal/browser/terminalProcessManager.ts
[ ] vs/workbench/contrib/terminal/browser/terminalService.ts
[ ] vs/workbench/contrib/terminal/test/electron-browser/terminalCommandTracker.test.ts
[ ] vs/workbench/contrib/webview/browser/webviewEditorService.ts
[ ] vs/workbench/services/editor/browser/editorService.ts
[ ] vs/workbench/services/extensions/browser/extensionService.ts
[ ] vs/workbench/services/extensions/electron-browser/extensionService.ts
[ ] vs/workbench/services/textfile/common/textFileEditorModelManager.ts
[ ] vs/workbench/services/untitled/common/untitledEditorService.ts
vs/workbench/test/common/editor/editorGroups.test.ts

To use the Build VS Code task to see these errors, update the problemMathcer on the tasks to have these values:
"owner": "VSCode", // Or string of your choice
"applyTo": "allDocuments",

Had to push to dev/mjbvz/stricter-createInstance since my changes were generic related and the fix in createInstance is not yet in master.

I am getting some strange strictFunctionTypes in some cases errors when I try to enable it. For example
Argument of type 'typeof CopyValueAction' is not assignable to parameter of type 'SyncDescriptor4<string, string, Variable, string, IAction>'.
Property 'ctor' is missing in type 'typeof CopyValueAction' but required in type 'SyncDescriptor4<string, string, Variable, string, IAction>'.ts(2345)
And the ctor is clearly there. What am I missing?

@isidorn maybe due to the fact that you seem to pass in this.debugService instead of relying on the injection (in watchExpressionsView.ts)?

Good catch, but that is not it. Even after I remove passing this.debugService I sitll get the same error.

Just three files left for the stricter create instance checks. @Tyriar and @sandy081 please take a look

I checked in the change to make createInstance stricter with #83472 which was our goal for October. @sandy081 Please look at the todo common I added for the one not-null assertion that I had to add
This leaves 960 errors for "strictFunctionTypes": true. Will keep looking into this during November

@mjbvz Can you be specific on the comment I have to look for. It is difficult to go through all todo comments.

@sandy081 Here's the commit it was added in: https://github.com/microsoft/vscode/commit/7d0267f49ed294dc2e5b85a3cf97dfc7b95575e3#diff-398b5e38e03e37845321e14cc99b830cR188
Comment text is: TODO: sandy081, remove not-null assertion

@alexandrudima owns this code so changed the comment to
TODO: alexdima, remove not-null assertion

I've fixed many of the common errors with 36a8322 and 5370653
This leaves 275 strict function errors across 140 files. To fix these, you can run the TS:  Strict Function Types task:

[ ] vs/base/browser/dom.ts
[ ] vs/base/browser/globalMouseMoveMonitor.ts
[ ] vs/base/browser/ui/menu/menu.ts
[ ] vs/base/browser/ui/toolbar/toolbar.ts
[ ] vs/base/browser/ui/tree/asyncDataTree.ts
[ ] vs/base/browser/ui/tree/dataTree.ts
[ ] vs/base/browser/ui/tree/objectTree.ts
[ ] vs/base/browser/ui/tree/objectTreeModel.ts
[ ] vs/base/common/glob.ts
[ ] vs/base/common/iterator.ts
[ ] vs/base/common/path.ts
[ ] vs/base/node/watcher.ts
[ ] vs/base/parts/ipc/common/ipc.ts
[ ] vs/base/parts/storage/test/node/storage.test.ts
[ ] vs/base/parts/tree/browser/treeView.ts
[ ] vs/base/test/common/event.test.ts
[ ] vs/code/electron-browser/issue/issueReporterMain.ts
[ ] vs/editor/browser/controller/pointerHandler.ts
[ ] vs/editor/browser/editorDom.ts
[ ] vs/editor/browser/editorExtensions.ts
[ ] vs/editor/browser/viewParts/lines/viewLine.ts
[ ] vs/editor/contrib/codeAction/test/codeActionModel.test.ts
[ ] vs/editor/contrib/dnd/dnd.ts
[ ] vs/editor/contrib/folding/foldingModel.ts
[ ] vs/editor/contrib/gotoError/gotoError.ts
[ ] vs/editor/contrib/gotoSymbol/goToSymbol.ts
[ ] vs/editor/contrib/gotoSymbol/peek/referencesWidget.ts
[ ] vs/editor/contrib/suggest/suggest.ts
[ ] vs/editor/standalone/browser/standaloneServices.ts
[ ] vs/platform/actions/common/actions.ts
[ ] vs/platform/actions/common/menuService.ts
[ ] vs/platform/environment/node/argv.ts
[ ] vs/platform/extensionManagement/common/extensionGalleryService.ts
[ ] vs/platform/files/test/files.test.ts
[ ] vs/platform/instantiation/common/extensions.ts
[ ] vs/platform/instantiation/common/instantiationService.ts
[ ] vs/platform/list/browser/listService.ts
[ ] vs/platform/markers/common/markerService.ts
[ ] vs/platform/remote/common/remoteAgentConnection.ts
[ ] vs/platform/storage/node/storageIpc.ts
[ ] vs/platform/url/electron-main/electronUrlListener.ts
[ ] vs/workbench/api/browser/mainThreadDiagnostics.ts
[ ] vs/workbench/api/browser/mainThreadLanguageFeatures.ts
[ ] vs/workbench/api/browser/mainThreadTask.ts
[ ] vs/workbench/api/browser/viewsExtensionPoint.ts
[ ] vs/workbench/api/common/extHost.api.impl.ts
[ ] vs/workbench/api/common/extHostCustomers.ts
[ ] vs/workbench/api/common/extHostDiagnostics.ts
[ ] vs/workbench/api/common/extHostLanguageFeatures.ts
[ ] vs/workbench/api/common/extHostQuickOpen.ts
[ ] vs/workbench/api/common/extHostSearch.ts
[ ] vs/workbench/api/common/extHostTerminalService.ts
[ ] vs/workbench/api/common/extHostTypeConverters.ts
[ ] vs/workbench/api/common/extHostWorkspace.ts
[ ] vs/workbench/api/node/extHost.services.ts
[ ] vs/workbench/api/node/extHostDebugService.ts
[ ] vs/workbench/api/node/extHostExtensionService.ts
[ ] vs/workbench/api/node/extHostSearch.ts
[ ] vs/workbench/api/node/extHostTerminalService.ts
[ ] vs/workbench/browser/parts/activitybar/activitybarPart.ts
[ ] vs/workbench/browser/parts/compositeBar.ts
[ ] vs/workbench/browser/parts/editor/breadcrumbsPicker.ts
[ ] vs/workbench/browser/parts/editor/editor.contribution.ts
[ ] vs/workbench/browser/parts/notifications/notificationsList.ts
[ ] vs/workbench/browser/parts/panel/panelPart.ts
[ ] vs/workbench/browser/parts/quickinput/quickInputList.ts
[ ] vs/workbench/browser/parts/sidebar/sidebarPart.ts
[ ] vs/workbench/browser/parts/views/customView.ts
[ ] vs/workbench/common/contributions.ts
[ ] vs/workbench/common/editor/editorGroup.ts
[ ] vs/workbench/contrib/callHierarchy/browser/callHierarchyPeek.ts
[ ] vs/workbench/contrib/codeEditor/browser/diffEditorHelper.ts
[ ] vs/workbench/contrib/codeEditor/browser/suggestEnabledInput/suggestEnabledInput.ts
[ ] vs/workbench/contrib/comments/browser/commentThreadWidget.ts
[ ] vs/workbench/contrib/comments/browser/simpleCommentEditor.ts
[ ] vs/workbench/contrib/customEditor/browser/customEditor.ts
[ ] vs/workbench/contrib/customEditor/browser/webviewEditor.contribution.ts
[ ] vs/workbench/contrib/debug/browser/breakpointEditorContribution.ts
[ ] vs/workbench/contrib/debug/browser/breakpointsView.ts
[ ] vs/workbench/contrib/debug/browser/callStackView.ts
[ ] vs/workbench/contrib/debug/browser/debugConfigurationManager.ts
[ ] vs/workbench/contrib/debug/browser/debugEditorContribution.ts
[ ] vs/workbench/contrib/debug/browser/debugHover.ts
[ ] vs/workbench/contrib/debug/browser/loadedScriptsView.ts
[ ] vs/workbench/contrib/debug/browser/rawDebugSession.ts
[ ] vs/workbench/contrib/debug/browser/repl.ts
[ ] vs/workbench/contrib/debug/browser/variablesView.ts
[ ] vs/workbench/contrib/debug/browser/watchExpressionsView.ts
[ ] vs/workbench/contrib/debug/common/abstractDebugAdapter.ts
[ ] vs/workbench/contrib/debug/common/debugModel.ts
[ ] vs/workbench/contrib/debug/common/debugViewModel.ts
[ ] vs/workbench/contrib/extensions/browser/extensionEditor.ts
[ ] vs/workbench/contrib/extensions/browser/extensionsList.ts
[ ] vs/workbench/contrib/extensions/browser/extensionsViewlet.ts
[ ] vs/workbench/contrib/extensions/browser/extensionTipsService.ts
[ ] vs/workbench/contrib/extensions/common/extensions.ts
[ ] vs/workbench/contrib/extensions/electron-browser/runtimeExtensionsEditor.ts
[ ] vs/workbench/contrib/files/browser/views/explorerView.ts
[ ] vs/workbench/contrib/files/browser/views/openEditorsView.ts
[ ] vs/workbench/contrib/localizations/browser/localizationsActions.ts
[ ] vs/workbench/contrib/markers/browser/markersPanel.ts
[ ] vs/workbench/contrib/markers/browser/markersTreeViewer.ts
[ ] vs/workbench/contrib/outline/browser/outlinePanel.ts
[ ] vs/workbench/contrib/preferences/browser/keybindingsEditor.ts
[ ] vs/workbench/contrib/preferences/browser/preferencesEditor.ts
[ ] vs/workbench/contrib/preferences/browser/preferencesWidgets.ts
[ ] vs/workbench/contrib/preferences/browser/settingsEditor2.ts
[ ] vs/workbench/contrib/quickopen/browser/commandsHandler.ts
[ ] vs/workbench/contrib/quickopen/browser/gotoSymbolHandler.ts
[ ] vs/workbench/contrib/scm/browser/dirtydiffDecorator.ts
[ ] vs/workbench/contrib/scm/browser/mainPanel.ts
[ ] vs/workbench/contrib/scm/browser/repositoryPanel.ts
[ ] vs/workbench/contrib/search/browser/search.contribution.ts
[ ] vs/workbench/contrib/search/browser/searchResultsView.ts
[ ] vs/workbench/contrib/search/browser/searchView.ts
[ ] vs/workbench/contrib/terminal/browser/terminal.contribution.ts
[ ] vs/workbench/contrib/terminal/browser/terminalQuickOpen.ts
[ ] vs/workbench/contrib/themes/browser/themes.contribution.ts
[ ] vs/workbench/contrib/webview/browser/webview.contribution.ts
[ ] vs/workbench/electron-browser/window.ts
[ ] vs/workbench/services/decorations/browser/decorationsService.ts
[ ] vs/workbench/services/editor/test/browser/editorService.test.ts
[ ] vs/workbench/services/extensions/common/extensionHostProcessManager.ts
[ ] vs/workbench/services/extensions/node/extensionHostProcessSetup.ts
[ ] vs/workbench/services/extensions/node/proxyResolver.ts
[ ] vs/workbench/services/extensions/worker/extHost.services.ts
[ ] vs/workbench/services/keybinding/browser/keymapService.ts
[ ] vs/workbench/services/mode/common/workbenchModeService.ts
[ ] vs/workbench/services/preferences/browser/preferencesService.ts
[ ] vs/workbench/services/preferences/common/preferencesModels.ts
[ ] vs/workbench/services/search/node/fileSearch.ts
[ ] vs/workbench/services/search/node/searchService.ts
[ ] vs/workbench/services/search/test/node/rawSearchService.test.ts
[ ] vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts
[ ] vs/workbench/services/textfile/common/textFileEditorModelManager.ts
[ ] vs/workbench/services/textfile/electron-browser/nativeTextFileService.ts
[ ] vs/workbench/services/textfile/test/textFileService.test.ts
[ ] vs/workbench/test/browser/quickopen.test.ts
[ ] vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts
[ ] vs/workbench/test/electron-browser/api/extHostTreeViews.test.ts
[ ] vs/workbench/test/electron-browser/quickopen.perf.integrationTest.ts
[ ] vs/workbench/test/electron-browser/textsearch.perf.integrationTest.ts

@mjbvz Can you please regenerate the list?

@alexdima Updated and assigned a few owners. Note that there are some errors related to createInstance with generics that are difficult to understand. I'm looking into fixing the signature of createInstance

@mjbvz you have to teach me how to fix the various WorkbenchList issues (e.g. in notificationsList.ts).

@bpasero I'm still trying to figure out how to fix those. If a file in the list only errors related to that, please assign me

@mjbvz I have also assigned you to my files which only have the tree error. Thanks!

@mjbvz I also assigned my files which only have the tree error to you.

Latest list of errors. Lots in my areas but also others.
vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(50,13): Argument of type '([inputReg, testStr, shouldMatch]: [string, string, boolean]) => void' is not assignable to parameter of type '(value: (string | boolean)[], index: number, array: (string | boolean)[][]) => void'.
vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts(71,13): Argument of type '([inputReg, testStr, shouldMatch]: [string, string, boolean]) => void' is not assignable to parameter of type '(value: (string | boolean)[], index: number, array: (string | boolean)[][]) => void'.
vs/workbench/services/search/test/node/rawSearchService.test.ts(97,18): No overload matches this call.
vs/workbench/services/search/test/node/rawSearchService.test.ts(117,18): No overload matches this call.
vs/workbench/services/search/test/node/rawSearchService.test.ts(140,18): No overload matches this call.
vs/workbench/services/search/test/node/rawSearchService.test.ts(165,88): Argument of type '(match: IFileMatch<URI>) => void' is not assignable to parameter of type '(p: ISearchProgressItem) => void'.
vs/workbench/services/search/test/node/rawSearchService.test.ts(235,18): No overload matches this call.
vs/workbench/services/search/test/node/rawSearchService.test.ts(261,18): No overload matches this call.
vs/workbench/services/search/test/node/rawSearchService.test.ts(294,18): No overload matches this call.
vs/workbench/contrib/files/browser/views/openEditorsView.ts(217,3): Type 'WorkbenchList<unknown>' is not assignable to type 'WorkbenchList<IEditorGroup | OpenEditor>'.
vs/workbench/contrib/files/browser/views/explorerView.ts(367,99): Type 'WorkbenchCompressibleAsyncDataTree<ExplorerItem | ExplorerItem[], ExplorerItem, FuzzyScore>' does not satisfy the constraint 'WorkbenchCompressibleAsyncDataTree<unknown, unknown, unknown>'.
vs/workbench/services/search/node/searchService.ts(129,54): Argument of type '(p: IProgressMessage) => void' is not assignable to parameter of type '(p: ISearchProgressItem) => void'.
vs/workbench/services/search/node/fileSearch.ts(216,46): Argument of type '(err: Error, stdout?: string | undefined, last?: boolean | undefined) => void' is not assignable to parameter of type '(err: Error | null, stdout?: string | undefined, last?: boolean | undefined) => void'.
vs/workbench/services/search/node/fileSearch.ts(303,48): Argument of type '(err: Error, stdout?: string | undefined, last?: boolean | undefined) => void' is not assignable to parameter of type '(err: Error | null, stdout?: string | undefined, last?: boolean | undefined) => void'.
vs/workbench/services/search/node/fileSearch.ts(550,6): Argument of type '(error: Error[]) => void' is not assignable to parameter of type '(err: (Error | null)[] | null, result: any[]) => void'.
vs/workbench/services/search/node/fileSearch.ts(626,79): Argument of type '(err: Error, isLimitHit: boolean) => void' is not assignable to parameter of type '(error: Error | null, isLimitHit: boolean) => void'.
vs/workbench/services/extensions/node/proxyResolver.ts(343,33): Argument of type 'any[]' is not assignable to parameter of type '[string | URL, RequestOptions, (((res: IncomingMessage) => void) | undefined)?]'.
vs/workbench/services/extensions/node/proxyResolver.ts(379,32): Argument of type 'any[]' is not assignable to parameter of type '[string | URL, RequestOptions, (((res: IncomingMessage) => void) | undefined)?]'.
vs/workbench/services/extensions/node/proxyResolver.ts(392,41): Argument of type 'any[]' is not assignable to parameter of type '[SecureContextOptions]'.
vs/workbench/services/decorations/browser/decorationsService.ts(323,4): Argument of type '(last: FileDecorationChangeEvent, current: URI | URI[]) => FileDecorationChangeEvent' is not assignable to parameter of type '(last: FileDecorationChangeEvent | undefined, event: URI | URI[]) => FileDecorationChangeEvent'.
vs/workbench/contrib/timeline/browser/timelinePane.ts(294,4): Type 'WorkbenchObjectTree<TimelineItem, FuzzyScore>' does not satisfy the constraint 'WorkbenchObjectTree<any, unknown>'.
vs/workbench/contrib/themes/browser/themes.contribution.ts(233,56): Argument of type '(theme: IColorTheme) => ThemeItem' is not assignable to parameter of type '(value: IColorTheme | IFileIconTheme, index: number, array: (IColorTheme | IFileIconTheme)[]) => ThemeItem'.
vs/workbench/contrib/search/browser/searchView.ts(699,3): Type 'WorkbenchObjectTree<any, unknown>' is not assignable to type 'WorkbenchObjectTree<RenderableMatch, void>'.
vs/workbench/contrib/search/browser/searchResultsView.ts(373,9): Argument of type '(fm: FileMatch) => URI' is not assignable to parameter of type '(value: RenderableMatch, index: number, array: RenderableMatch[]) => URI'.
vs/workbench/contrib/scm/browser/scmViewlet.ts(111,46): Argument of type '(e: IAddedViewDescriptorRef[]) => void' is not assignable to parameter of type '(e: IViewDescriptorRef[]) => any'.
vs/workbench/contrib/scm/browser/repositoryPane.ts(828,96): Type 'WorkbenchCompressibleObjectTree<TreeElement, FuzzyScore>' does not satisfy the constraint 'WorkbenchCompressibleObjectTree<any, unknown>'.
vs/workbench/contrib/scm/browser/repositoryPane.ts(848,8): Argument of type '(e: ISCMResource) => void' is not assignable to parameter of type '(e: ISCMResource | ISCMResourceGroup | IResourceNode<ISCMResource, ISCMResourceGroup> | null) => any'.
vs/workbench/contrib/scm/browser/repositoryPane.ts(855,42): Argument of type '(e: ITreeContextMenuEvent<TreeElement>) => void' is not assignable to parameter of type '(e: ITreeContextMenuEvent<ISCMResource | ISCMResourceGroup | IResourceNode<ISCMResource, ISCMResourceGroup> | null>) => any'.
vs/workbench/contrib/scm/browser/mainPane.ts(199,78): Type 'WorkbenchList<ISCMRepository>' does not satisfy the constraint 'WorkbenchList<unknown>'.
vs/workbench/contrib/scm/browser/dirtydiffDecorator.ts(1066,10): Argument of type '(changes: IChange[]) => void' is not assignable to parameter of type '(value: IChange[] | null) => void | PromiseLike<void>'.
vs/workbench/contrib/remote/browser/tunnelView.ts(493,15): No overload matches this call.
vs/workbench/contrib/quickopen/browser/gotoSymbolHandler.ts(80,24): Argument of type '(entry: SymbolEntry) => void' is not assignable to parameter of type '(value: QuickOpenEntry, index: number, array: QuickOpenEntry[]) => void'.
vs/workbench/contrib/quickopen/browser/gotoSymbolHandler.ts(101,21): Argument of type '(a: SymbolEntry, b: SymbolEntry) => number' is not assignable to parameter of type '(a: QuickOpenEntry, b: QuickOpenEntry) => number'.
vs/workbench/contrib/quickopen/browser/commandsHandler.ts(474,68): No overload matches this call.
vs/workbench/contrib/quickopen/browser/commandsHandler.ts(474,117): Parameter 'action' implicitly has an 'any' type.
vs/workbench/contrib/preferences/browser/settingsEditor2.ts(451,28): Type '(action: Action) => undefined' is not assignable to type 'IActionViewItemProvider'.
vs/workbench/contrib/preferences/browser/settingsEditor2.ts(885,11): Argument of type '(model: Settings2EditorModel) => Promise<void> | undefined' is not assignable to parameter of type '(value: IEditorModel | null) => void | PromiseLike<void | undefined> | undefined'.
vs/workbench/contrib/preferences/browser/preferencesEditor.ts(987,66): Type 'typeof DefaultSettingsEditorContribution' is not assignable to type 'IEditorContributionCtor'.
vs/workbench/contrib/outline/browser/outlinePane.ts(319,3): Type 'WorkbenchDataTree<unknown, unknown, unknown>' is not assignable to type 'WorkbenchDataTree<OutlineModel, OutlineItem, FuzzyScore>'.
vs/workbench/contrib/markdown/common/markdownDocumentRenderer.ts(36,103): Argument of type '() => Thenable<ITokenizationSupport> | null' is not assignable to parameter of type '(value: boolean) => ITokenizationSupport | PromiseLike<ITokenizationSupport | null> | null'.
vs/workbench/contrib/externalTerminal/node/externalTerminalService.ts(308,70): Argument of type 'Thenable<ProcessEnv> | undefined' is not assignable to parameter of type 'ProcessEnv | PromiseLike<ProcessEnv | undefined> | undefined'.
vs/workbench/contrib/extensions/electron-browser/runtimeExtensionsEditor.ts(410,80): Type 'WorkbenchList<IRuntimeExtension>' does not satisfy the constraint 'WorkbenchList<unknown>'.
vs/workbench/contrib/extensions/electron-browser/runtimeExtensionsEditor.ts(421,3): Object is possibly 'null'.
vs/workbench/contrib/extensions/electron-browser/runtimeExtensionsEditor.ts(421,24): Object is possibly 'null'.
vs/workbench/contrib/extensions/electron-browser/runtimeExtensionsEditor.ts(423,3): Object is possibly 'null'.
vs/workbench/contrib/debug/browser/watchExpressionsView.ts(69,87): Type 'WorkbenchAsyncDataTree<IExpression | IDebugService, IExpression, FuzzyScore>' does not satisfy the constraint 'WorkbenchAsyncDataTree<unknown, unknown, unknown>'.
vs/workbench/contrib/debug/browser/variablesView.ts(91,87): Type 'WorkbenchAsyncDataTree<IExpression | IViewModel | IScope, IExpression | IScope, FuzzyScore>' does not satisfy the constraint 'WorkbenchAsyncDataTree<unknown, unknown, unknown>'.
vs/workbench/contrib/debug/browser/repl.ts(442,87): Type 'WorkbenchAsyncDataTree<IDebugSession, IReplElement, FuzzyScore>' does not satisfy the constraint 'WorkbenchAsyncDataTree<unknown, unknown, unknown>'.
vs/workbench/contrib/debug/browser/loadedScriptsView.ts(445,3): Type 'WorkbenchCompressibleObjectTree<any, unknown>' is not assignable to type 'WorkbenchCompressibleObjectTree<BaseTreeItem, FuzzyScore>'.
vs/workbench/contrib/debug/browser/debugHover.ts(104,87): Type 'WorkbenchAsyncDataTree<IExpression, IExpression, any>' does not satisfy the constraint 'WorkbenchAsyncDataTree<unknown, unknown, unknown>'.
vs/workbench/contrib/debug/browser/callStackView.ts(158,87): Type 'WorkbenchAsyncDataTree<string | IDebugSession | IThread | IStackFrame | IDebugModel | ThreadAndSessionIds | IStackFrame[], CallStackItem, FuzzyScore>' does not satisfy the constraint 'WorkbenchAsyncDataTree<unknown, unknown, unknown>'.
vs/workbench/contrib/debug/browser/breakpointsView.ts(84,3): Type 'WorkbenchList<unknown>' is not assignable to type 'WorkbenchList<IEnablement>'.
vs/workbench/contrib/callHierarchy/browser/callHierarchyPeek.ts(207,89): Type 'WorkbenchAsyncDataTree<CallHierarchyModel, Call, FuzzyScore>' does not satisfy the constraint 'WorkbenchAsyncDataTree<unknown, unknown, unknown>'.
vs/workbench/contrib/bulkEdit/browser/bulkEditPane.ts(122,3): Type 'WorkbenchAsyncDataTree<unknown, unknown, unknown>' is not assignable to type 'WorkbenchAsyncDataTree<BulkFileOperations, BulkEditElement, FuzzyScore>'.
vs/workbench/test/browser/api/extHostDiagnostics.test.ts(99,22): Argument of type '(uri: URI, array: readonly Diagnostic[]) => void' is not assignable to parameter of type '(uri: URI, diagnostics: readonly Diagnostic[], collection: DiagnosticCollection) => any'.
vs/workbench/browser/parts/views/customView.ts(354,71): No overload matches this call.
vs/workbench/browser/parts/notifications/notificationsList.ts(76,106): Type 'WorkbenchList<INotificationViewItem>' does not satisfy the constraint 'WorkbenchList<unknown>'.
vs/workbench/browser/parts/notifications/notificationsList.ts(94,38): Parameter 'e' implicitly has an 'any' type.
vs/workbench/browser/parts/notifications/notificationsList.ts(108,40): Parameter 'event' implicitly has an 'any' type.
vs/workbench/browser/parts/notifications/notificationsList.ts(126,41): Parameter 'e' implicitly has an 'any' type.
vs/workbench/browser/parts/editor/breadcrumbsPicker.ts(33,8): Type 'typeof BreadcrumbsFilePicker | typeof BreadcrumbsOutlinePicker' is not assignable to type 'IConstructorSignature1<HTMLElement, BreadcrumbsPicker>'.
vs/workbench/browser/parts/editor/breadcrumbsPicker.ts(378,83): Type 'WorkbenchAsyncDataTree<URI | IWorkspace, IFileStat | IWorkspaceFolder, FuzzyScore>' does not satisfy the constraint 'WorkbenchAsyncDataTree<unknown, unknown, unknown>'.
vs/workbench/browser/parts/editor/breadcrumbsPicker.ts(447,78): Type 'WorkbenchDataTree<OutlineModel, any, FuzzyScore>' does not satisfy the constraint 'WorkbenchDataTree<unknown, unknown, unknown>'.
vs/editor/contrib/gotoSymbol/peek/referencesWidget.ts(319,89): Type 'WorkbenchAsyncDataTree<ReferencesModel | FileReferences, TreeElement, FuzzyScore>' does not satisfy the constraint 'WorkbenchAsyncDataTree<unknown, unknown, unknown>'.
vs/base/parts/tree/browser/treeView.ts(560,163): Argument of type '(lastEvent: IThrottledGestureEvent, event: MSGestureEvent) => IThrottledGestureEvent' is not assignable to parameter of type 'IEventMerger<IThrottledGestureEvent, DOMEvent>'.
vs/base/parts/tree/browser/treeView.ts(723,35): Argument of type '(e: IItemTraitEvent) => void' is not assignable to parameter of type '(e: IItemCollapseEvent) => any'.
vs/base/browser/ui/tree/objectTreeModel.ts(118,4): Argument of type '(node: ITreeNode<T, TFilterData>) => void' is not assignable to parameter of type '(node: ITreeNode<T | null, TFilterData>) => void'.
vs/base/browser/ui/tree/objectTree.ts(33,47): Argument of type 'IObjectTreeOptions<T, TFilterData>' is not assignable to parameter of type 'IAbstractTreeOptions<T | null, TFilterData>'.
vs/base/browser/ui/tree/objectTree.ts(184,107): Argument of type 'ICompressibleObjectTreeOptions<T, TFilterData>' is not assignable to parameter of type 'ICompressibleObjectTreeOptions<T | undefined, TFilterData>'.
vs/base/browser/ui/tree/dataTree.ts(40,47): Argument of type 'IDataTreeOptions<T, TFilterData>' is not assignable to parameter of type 'IAbstractTreeOptions<T | null, TFilterData>'.
vs/base/browser/ui/tree/dataTree.ts(186,37): Argument of type '(element: T) => string' is not assignable to parameter of type '(value: T | null, index: number, array: (T | null)[]) => string'.
vs/base/browser/ui/tree/dataTree.ts(187,45): Argument of type '(element: T) => string' is not assignable to parameter of type '(value: T | null, index: number, array: (T | null)[]) => string'.
vs/base/browser/ui/tree/asyncDataTree.ts(329,94): Argument of type '<TInput, T>(e: ITreeEvent<IAsyncDataTreeNode<TInput, T>>) => ITreeEvent<T>' is not assignable to parameter of type '(i: ITreeEvent<IAsyncDataTreeNode<TInput, T> | null>) => ITreeEvent<T>'.
vs/base/browser/ui/tree/asyncDataTree.ts(330,102): Argument of type '<TInput, T>(e: ITreeEvent<IAsyncDataTreeNode<TInput, T>>) => ITreeEvent<T>' is not assignable to parameter of type '(i: ITreeEvent<IAsyncDataTreeNode<TInput, T> | null>) => ITreeEvent<T>'.
vs/base/browser/ui/tree/asyncDataTree.ts(331,80): Argument of type '<TInput, T>(e: ITreeEvent<IAsyncDataTreeNode<TInput, T>>) => ITreeEvent<T>' is not assignable to parameter of type '(i: ITreeEvent<IAsyncDataTreeNode<TInput, T> | null>) => ITreeEvent<T>'.
vs/base/browser/ui/tree/asyncDataTree.ts(334,91): Argument of type '<TInput, T>(e: ITreeMouseEvent<IAsyncDataTreeNode<TInput, T>>) => ITreeMouseEvent<T>' is not assignable to parameter of type '(i: ITreeMouseEvent<IAsyncDataTreeNode<TInput, T> | null>) => ITreeMouseEvent<T>'.
vs/base/browser/ui/tree/asyncDataTree.ts(335,97): Argument of type '<TInput, T>(e: ITreeMouseEvent<IAsyncDataTreeNode<TInput, T>>) => ITreeMouseEvent<T>' is not assignable to parameter of type '(i: ITreeMouseEvent<IAsyncDataTreeNode<TInput, T> | null>) => ITreeMouseEvent<T>'.
vs/base/browser/ui/tree/asyncDataTree.ts(336,99): Argument of type '<TInput, T>(e: ITreeContextMenuEvent<IAsyncDataTreeNode<TInput, T>>) => ITreeContextMenuEvent<T>' is not assignable to parameter of type '(i: ITreeContextMenuEvent<IAsyncDataTreeNode<TInput, T> | null>) => ITreeContextMenuEvent<T>'.
vs/base/browser/ui/tree/asyncDataTree.ts(387,38): Argument of type '({ node, deep }: ICollapseStateChangeEvent<IAsyncDataTreeNode<TInput, T>, any>) => void' is not assignable to parameter of type '(e: ICollapseStateChangeEvent<IAsyncDataTreeNode<TInput, T> | null, TFilterData>) => any'.
vs/workbench/api/common/extHostWorkspace.ts(442,4): Argument of type 'import("vscode").CancellationToken' is not assignable to parameter of type 'import("/Users/roblou/code/vscode/src/vs/base/common/cancellation").CancellationToken'.
vs/workbench/api/common/extHostWorkspace.ts(444,10): Parameter 'data' implicitly has an 'any' type.
vs/workbench/api/common/extHostWorkspace.ts(529,5): Argument of type 'import("vscode").CancellationToken' is not assignable to parameter of type 'import("/Users/roblou/code/vscode/src/vs/base/common/cancellation").CancellationToken'.
vs/workbench/api/common/extHostTypeConverters.ts(144,81): Argument of type '(value: DiagnosticRelatedInformation) => IRelatedInformation' is not assignable to parameter of type '(value: DiagnosticRelatedInformation, index: number, array: DiagnosticRelatedInformation[]) => IRelatedInformation'.
vs/workbench/api/common/extHostTimeline.ts(39,53): Argument of type 'import("vscode").CancellationToken' is not assignable to parameter of type 'import("/Users/roblou/code/vscode/src/vs/base/common/cancellation").CancellationToken'.
vs/workbench/api/common/extHostSearch.ts(85,7): Argument of type 'import("vscode").CancellationToken' is not assignable to parameter of type 'import("/Users/roblou/code/vscode/src/vs/base/common/cancellation").CancellationToken'.
vs/workbench/api/common/extHostSearch.ts(105,93): Argument of type 'import("vscode").CancellationToken' is not assignable to parameter of type 'import("/Users/roblou/code/vscode/src/vs/base/common/cancellation").CancellationToken'.
vs/workbench/api/common/extHostLanguageFeatures.ts(200,82): Argument of type '(value: Definition) => LocationLink[]' is not assignable to parameter of type '(value: Location | Location[] | LocationLink[] | null | undefined) => LocationLink[] | PromiseLike<LocationLink[]>'.
vs/workbench/api/common/extHostLanguageFeatures.ts(214,83): Argument of type '(value: Definition) => LocationLink[]' is not assignable to parameter of type '(value: Location | Location[] | LocationLink[] | null | undefined) => LocationLink[] | PromiseLike<LocationLink[]>'.
vs/workbench/api/common/extHostLanguageFeatures.ts(228,86): Argument of type '(value: Definition) => LocationLink[]' is not assignable to parameter of type '(value: Location | Location[] | LocationLink[] | null | undefined) => LocationLink[] | PromiseLike<LocationLink[]>'.
vs/workbench/api/common/extHostLanguageFeatures.ts(242,86): Argument of type '(value: Definition) => LocationLink[]' is not assignable to parameter of type '(value: Location | Location[] | LocationLink[] | null | undefined) => LocationLink[] | PromiseLike<LocationLink[]>'.
vs/workbench/api/common/extHostFileSystemEventService.ts(202,40): Argument of type '(thenable: Promise<any>, listener: IExtensionListener<E>) => Promise<void>' is not assignable to parameter of type '(p: Promise<any>, listener: Function) => Promise<any>'.
vs/workbench/api/common/extHostDiagnostics.ts(255,134): No overload matches this call.
vs/workbench/api/common/extHostCustomers.ts(17,67): Argument of type 'new (context: IExtHostContext, ...services: Services) => T' is not assignable to parameter of type 'IExtHostCustomerCtor<T>'.
vs/workbench/api/common/extHostCustomers.ts(22,57): Argument of type 'new (context: IExtHostContext, ...services: Services) => T' is not assignable to parameter of type 'IExtHostCustomerCtor<T>'.
vs/workbench/api/common/extHostAuthentication.ts(20,3): Type 'import("vscode").Event<void>' is not assignable to type 'import("/Users/roblou/code/vscode/src/vs/base/common/event").Event<void>'.
vs/workbench/api/common/extHostApiCommands.ts(131,131): Argument of type '(value: modes.TextEdit[]) => types.TextEdit[] | undefined' is not assignable to parameter of type '(v: ISingleEditOperation[], apiArgs: any[]) => TextEdit[] | undefined'.
vs/workbench/api/common/extHostApiCommands.ts(136,131): Argument of type '(value: modes.TextEdit[]) => types.TextEdit[] | undefined' is not assignable to parameter of type '(v: ISingleEditOperation[], apiArgs: any[]) => TextEdit[] | undefined'.
vs/workbench/api/common/extHostApiCommands.ts(141,131): Argument of type '(value: modes.TextEdit[]) => types.TextEdit[] | undefined' is not assignable to parameter of type '(v: ISingleEditOperation[], apiArgs: any[]) => TextEdit[] | undefined'.
vs/workbench/api/common/extHost.api.impl.ts(322,5): Type 'Promise<TextDocument | undefined>' is not assignable to type 'Thenable<TextDocument>'.
vs/workbench/api/common/extHost.api.impl.ts(478,4): Type '(message: string, first: string | MessageItem | MessageOptions, ...rest: (string | MessageItem)[]) => Promise<string | MessageItem | undefined>' is not assignable to type '{ (message: string, ...items: string[]): Thenable<string | undefined>; (message: string, options: MessageOptions, ...items: string[]): Thenable<string | undefined>; <T extends MessageItem>(message: string, ...items: T[]): Thenable<...>; <T extends MessageItem>(message: string, options: MessageOptions, ...items: T[])...'.
vs/workbench/api/common/extHost.api.impl.ts(481,4): Type '(message: string, first: string | MessageItem | MessageOptions, ...rest: (string | MessageItem)[]) => Promise<string | MessageItem | undefined>' is not assignable to type '{ (message: string, ...items: string[]): Thenable<string | undefined>; (message: string, options: MessageOptions, ...items: string[]): Thenable<string | undefined>; <T extends MessageItem>(message: string, ...items: T[]): Thenable<...>; <T extends MessageItem>(message: string, options: MessageOptions, ...items: T[])...'.
vs/workbench/api/common/extHost.api.impl.ts(484,4): Type '(message: string, first: string | MessageItem | MessageOptions, ...rest: (string | MessageItem)[]) => Promise<string | MessageItem | undefined>' is not assignable to type '{ (message: string, ...items: string[]): Thenable<string | undefined>; (message: string, options: MessageOptions, ...items: string[]): Thenable<string | undefined>; <T extends MessageItem>(message: string, ...items: T[]): Thenable<...>; <T extends MessageItem>(message: string, options: MessageOptions, ...items: T[])...'.
vs/workbench/api/common/extHost.api.impl.ts(487,4): Type '(items: any, options: QuickPickOptions, token?: CancellationToken | undefined) => any' is not assignable to type '{ (items: string[] | Thenable<string[]>, options: QuickPickOptions & { canPickMany: true; }, token?: CancellationToken | undefined): Thenable<...>; (items: string[] | Thenable<...>, options?: QuickPickOptions | undefined, token?: CancellationToken | undefined): Thenable<...>; <T extends QuickPickItem>(items: T[] | T...'.
vs/workbench/api/common/extHost.api.impl.ts(488,12): No overload matches this call.
vs/workbench/api/common/extHost.api.impl.ts(490,4): Type '(options: WorkspaceFolderPickOptions) => Promise<WorkspaceFolder | undefined>' is not assignable to type '(options?: WorkspaceFolderPickOptions | undefined) => Thenable<WorkspaceFolder | undefined>'.
vs/workbench/api/common/extHost.api.impl.ts(494,48): Argument of type 'import("vscode").CancellationToken | undefined' is not assignable to parameter of type 'import("/Users/roblou/code/vscode/src/vs/base/common/cancellation").CancellationToken | undefined'.
vs/workbench/api/common/extHost.api.impl.ts(536,4): Type '(viewType: string, title: string, showOptions: ViewColumn | { viewColumn: ViewColumn; preserveFocus?: boolean | undefined; }, options: WebviewPanelOptions & WebviewOptions) => WebviewPanel' is not assignable to type '(viewType: string, title: string, showOptions: ViewColumn | { viewColumn: ViewColumn; preserveFocus?: boolean | undefined; }, options?: (WebviewPanelOptions & WebviewOptions) | undefined) => WebviewPanel'.
vs/workbench/api/common/extHost.api.impl.ts(539,4): Type '(editor: TextEditor, line: number, height: number, options: WebviewOptions) => WebviewEditorInset' is not assignable to type '(editor: TextEditor, line: number, height: number, options?: WebviewOptions | undefined) => WebviewEditorInset'.
vs/workbench/api/common/extHost.api.impl.ts(752,4): Type '(forward: vscode.TunnelOptions) => Promise<vscode.Tunnel | undefined>' is not assignable to type '(tunnelOptions: TunnelOptions) => Thenable<Tunnel>'.
vs/workbench/api/common/extHost.api.impl.ts(770,4): Type '(scheme: string, provider: vscode.TimelineProvider) => IDisposable' is not assignable to type '(selector: DocumentSelector, provider: TimelineProvider) => Disposable'.
vs/workbench/api/browser/mainThreadLanguageFeatures.ts(231,93): Argument of type '{ (data: ILocationDto): Location; (data: ILocationDto[]): Location[]; }' is not assignable to parameter of type '(value: ILocationDto[] | undefined) => Location[] | PromiseLike<Location[]>'.
vs/workbench/api/node/extHostSearch.ts(89,107): Argument of type 'import("vscode").CancellationToken' is not assignable to parameter of type 'import("/Users/roblou/code/vscode/src/vs/base/common/cancellation").CancellationToken'.
vs/workbench/api/node/extHostExtensionService.ts(72,45): Argument of type 'any[]' is not assignable to parameter of type '[any, any?, ({ swallowErrors?: boolean | undefined; } | undefined)?, (((error: Error | null) => void) | undefined)?]'.
vs/platform/url/electron-main/electronUrlListener.ts(62,13): Argument of type '(url: URI, options?: IOpenURLOptions | undefined) => Promise<boolean>' is not assignable to parameter of type '(e: URI | null) => any'.
vs/platform/markers/common/markerService.ts(59,48): Argument of type '(resources: URI[]) => void' is not assignable to parameter of type '(e: readonly URI[]) => any'.
vs/platform/markers/common/markerService.ts(127,72): No overload matches this call.
vs/platform/list/browser/listService.ts(741,117): Argument of type 'IWorkbenchObjectTreeOptions<T, TFilterData>' is not assignable to parameter of type 'IAsyncDataTreeOptions<unknown, unknown> | IAbstractTreeOptions<unknown, unknown>'.
vs/platform/list/browser/listService.ts(772,117): Argument of type 'IWorkbenchCompressibleObjectTreeOptions<T, TFilterData>' is not assignable to parameter of type 'IAsyncDataTreeOptions<unknown, unknown> | IAbstractTreeOptions<unknown, unknown>'.
vs/platform/list/browser/listService.ts(804,117): Argument of type 'IWorkbenchDataTreeOptions<T, TFilterData>' is not assignable to parameter of type 'IAsyncDataTreeOptions<unknown, unknown> | IAbstractTreeOptions<unknown, unknown>'.
vs/platform/list/browser/listService.ts(844,117): Argument of type 'IWorkbenchAsyncDataTreeOptions<T, TFilterData>' is not assignable to parameter of type 'IAsyncDataTreeOptions<unknown, unknown> | IAbstractTreeOptions<unknown, unknown>'.
vs/platform/list/browser/listService.ts(885,117): Argument of type 'IWorkbenchCompressibleAsyncDataTreeOptions<T, TFilterData>' is not assignable to parameter of type 'IAsyncDataTreeOptions<unknown, unknown> | IAbstractTreeOptions<unknown, unknown>'.
vs/platform/instantiation/common/instantiationService.ts(67,11): The 'this' context of type '(accessor: ServicesAccessor, ...args: TS) => R' is not assignable to method's 'this' of type '(this: undefined, accessor: ServicesAccessor, ...args: TS[number][]) => R'.
vs/platform/instantiation/common/extensions.ts(12,44): Argument of type 'new (...services: Services) => T' is not assignable to parameter of type 'new (...args: any[]) => T'.
vs/platform/actions/common/actions.ts(333,59): No overload matches this call.
vs/editor/contrib/suggest/suggest.ts(96,75): Argument of type 'IPosition' is not assignable to parameter of type 'Position'.
vs/editor/contrib/gotoSymbol/goToSymbol.ts(32,9): Argument of type '<T>(arr: T[][]) => T[]' is not assignable to parameter of type '(value: (LocationLink | LocationLink[] | undefined)[]) => LocationLink[] | PromiseLike<LocationLink[]>'.
vs/editor/contrib/gotoError/gotoError.ts(241,39): Argument of type '(changedResources: URI[]) => void' is not assignable to parameter of type '(e: readonly URI[]) => any'.
vs/code/electron-browser/issue/issueReporterMain.ts(443,55): Argument of type '(e: MouseEvent) => void' is not assignable to parameter of type '(event: Event) => void'.
vs/workbench/electron-browser/window.ts(805,55): Argument of type '(action: Separator | (IAction & { uri: URI; })) => MenubarMenuItem' is not assignable to parameter of type '(value: IAction, index: number, array: IAction[]) => MenubarMenuItem'.
vs/workbench/common/contributions.ts(49,4): No overload matches this call.
vs/workbench/common/contributions.ts(60,26): Argument of type 'new (...services: Services) => IWorkbenchContribution' is not assignable to parameter of type 'IConstructorSignature0<IWorkbenchContribution>'.
vs/base/common/glob.ts(460,9): Type '(path: string, basename: string) => boolean' is not assignable to type 'ParsedPattern & { allBasenames?: string[] | undefined; allPaths?: string[] | undefined; }'.
vs/base/common/glob.ts(540,4): Type 'ParsedStringPattern' is not assignable to type 'ParsedExpression'.
vs/base/common/glob.ts(565,3): Type 'ParsedStringPattern' is not assignable to type 'ParsedExpression'.
vs/base/common/glob.ts(601,2): Type 'ParsedStringPattern' is not assignable to type 'ParsedExpression'.
vs/base/common/glob.ts(623,10): Type '(path: string, basename: string, name: string, hasSibling: (name: string) => boolean | Promise<boolean>) => string | Promise<string | null> | null' is not assignable to type 'ParsedExpressionPattern'.
vs/base/node/processes.ts(412,41): No overload matches this call.
vs/base/node/pfs.ts(363,21): Argument of type '(syncError: Error) => void' is not assignable to parameter of type 'NoParamCallback'.
vs/base/node/encoding.ts(62,6): No overload matches this call.
vs/base/node/encoding.ts(100,6): No overload matches this call.

I'm still trying to figure out the best approach to the IWorkbence... issues
@jrieken Can you help with the extHost.api.impl.ts issues

Pushed a workaround for some of the generic errors, remaining files with issues (feel free to reassign if required):

[ ] src/vs/base/browser/ui/tree/asyncDataTree.ts @joaomoreno
[ ] src/vs/base/browser/ui/tree/dataTree.ts  @joaomoreno
[ ] src/vs/base/browser/ui/tree/objectTree.ts @joaomoreno
[ ] src/vs/base/browser/ui/tree/objectTreeModel.ts @joaomoreno
[ ] src/vs/base/common/glob.ts @chrmarti
[ ] src/vs/base/node/encoding.ts @bpasero?
[ ] src/vs/base/parts/tree/browser/treeView.ts @joaomoreno
[ ] src/vs/editor/contrib/gotoSymbol/goToSymbol.ts @mjbvz
[ ] src/vs/editor/contrib/gotoSymbol/peek/referencesWidget.ts  @mjbvz
[ ] src/vs/editor/contrib/suggest/suggest.ts @jrieken
[ ] src/vs/platform/instantiation/common/extensions.ts @sandy081
[ ] src/vs/platform/instantiation/common/instantiationService.ts @mjbvz
[ ] src/vs/platform/list/browser/listService.ts @joaomoreno
[ ] src/vs/platform/markers/common/markerService.ts @sandy081
[ ] src/vs/workbench/api/browser/mainThreadLanguageFeatures.ts @jrieken
[ ] src/vs/workbench/api/common/extHost.api.impl.ts @jrieken
[ ] src/vs/workbench/api/common/extHostApiCommands.ts @jrieken
[ ] src/vs/workbench/api/common/extHostCustomers.ts @jrieken
[ ] src/vs/workbench/api/common/extHostDiagnostics.ts @sandy081
[ ] src/vs/workbench/api/common/extHostFileSystemEventService.ts @jrieken
[ ] src/vs/workbench/api/common/extHostLanguageFeatures.ts @jrieken
[ ] src/vs/workbench/api/common/extHostSearch.ts @roblourens
[ ] src/vs/workbench/api/common/extHostTimeline.ts @eamodio
[ ] src/vs/workbench/api/common/extHostWorkspace.ts @bpasero
[ ] src/vs/workbench/api/node/extHostExtensionService.ts @sandy081
[ ] src/vs/workbench/api/node/extHostSearch.ts @roblourens
[ ] src/vs/workbench/browser/parts/views/customView.ts @mjbvz
[ ] src/vs/workbench/common/contributions.ts @mjbvz
[ ] src/vs/workbench/contrib/callHierarchy/browser/callHierarchyPeek.ts @mjbvz
[ ] src/vs/workbench/contrib/externalTerminal/node/externalTerminalService.ts @Tyriar
[ ] src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts @roblourens
[ ] src/vs/workbench/contrib/quickopen/browser/commandsHandler.ts @chrmarti
[ ] src/vs/workbench/contrib/quickopen/browser/gotoSymbolHandler.ts @chrmarti
[ ] src/vs/workbench/contrib/remote/browser/tunnelView.ts @mjbvz
[ ] src/vs/workbench/contrib/scm/browser/repositoryPane.ts @joaomoreno
[ ] src/vs/workbench/contrib/scm/browser/scmViewlet.ts @joaomoreno
[ ] src/vs/workbench/contrib/search/browser/searchResultsView.ts @roblourens
[ ] src/vs/workbench/contrib/themes/browser/themes.contribution.ts @aeschli
[ ] src/vs/workbench/electron-browser/window.ts @bpasero
[ ] src/vs/workbench/services/decorations/browser/decorationsService.ts @alexdima?
[ ] src/vs/workbench/services/search/node/searchService.ts @roblourens
[ ] src/vs/workbench/services/search/test/node/rawSearchService.test.ts @roblourens
[ ] src/vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts @roblourens

Fixed some, not sure about ones that result from the api and internal CancellationTokens not being compatible (due to Events not being compatible)

@roblourens thanks for investigating. I will try to come up with something that makes Event match again. The issue is that internally we allow to pass IDisposable[] | DisposableStore as 3rd argument and in the API we only allow the array

Pushed a workaround for the cancellation token challenge and some more changes, there are no ~50 compile errors left

Pushed a bunch of fixes. We're down to 23 errors.

Down to 9 errors - This is some left for @bpasero in glob.ts and there is some more tweaking needed for the Event and CancellationToken story... Getting closer

Almost done. This is what's left 👇

I own the simple pieces of glob, not this crazy stuff. Assigning to @chrmarti. I tried to fix it and had to give up, this is just beyond my skills.
E.g I really do not think we should add properties to functions like here https://github.com/microsoft/vscode/commit/78524301ad25a9ffed815d97c8bdc0f41705c7b5

I don't understand the preferences editor one. It's on a line using the IConstructorSignature type helper, and the bottom line is Type 'BrandedService' is missing the following properties from type 'IInstantiationService': createInstance, invokeFunction, createChild
like it thinks a BrandedService is being referenced as an IInstantiationService. But it should be the other way around, an IInstantiationService should just have to fulfill BrandedService.

@roblourens I can't decipher this either but have added a workaround

@mjbvz Fixed the last ones, back to you.


Upload .env to generate secrets automatically

Right now if you have a lot of secrets it's tedious to add them one by one. Instead it would be cool to have them read from a .env file. They could be automatically saved with a name like this: projectname-this_is_a_secret that way they are unique to the project.

important: one should be able to define which .env file, since usually .env contains local versions of those secrets

Thank you for creating this issue!
Please note that – in order for us to be able to handle each feature request with care – we have to consume all of them through a unified pipeline that makes it easier for us to prioritize, track and progress on the features our user base is interested in.
In turn, the Issues tab on this repository is best only be used for reporting bugs, which we can immediately act on.
For well-explained feature requests (like the one you just posted), please contact us at<EMAIL_ADDRESS>so that we can consider adding it to our roadmap.


Write genesis file for syncing during migration

During the migration some hardforks are enabled. To make syncing work, they need to be added to the genesis file, so that the ids of the chains match.
Fixes #159

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.14%. Comparing base (971ff15) to head (2c5e5f9).
Report is 1 commits behind head on celo6.

Additional details and impacted files
@@             Coverage Diff             @@
##            celo6     #167       +/-   ##
===========================================
- Coverage   59.46%   27.14%   -32.33%
===========================================
  Files          19        4       -15
  Lines        1658      140     -1518
  Branches       71       12       -59
===========================================
- Hits          986       38      -948
+ Misses        640      102      -538
+ Partials       32        0       -32

Flag
Coverage Δ

cannon-go-tests
?

chain-mon-tests
27.14% <ø> (ø)

sdk-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 15 files with indirect coverage changes

Closing in favor of https://github.com/celo-org/optimism/pull/219


BUGFIX: CertificateRequest short names must be unique.

Fixes https://github.com/cert-manager/cert-manager/issues/6342
The new mechanism is explained here: https://github.com/cert-manager/cert-manager/blob/860df2294b53ee512bfde186ed8478e6a43dd204/pkg/controller/certificates/requestmanager/requestmanager_controller.go#L401-L411
Kind
/kind cleanup
Release Note
BUGFIX: fix CertificateRequest name collision bug in StableCertificateRequestName feature.

/cherrypick release-1.13
/cherrypick release-1.12

/cherrypick release-1.12

I am happy with the new format.
Maybe bumping the name limit from a DNS label (63 chars) to a DNS subdomain (253 chars) would have solved 99% of the problems, including the original author of the issue. It seems like the hashing feature addresses a small corner case: folks with very very very large certificate names (longer than 232 chars) would still get the issue reported by the original author. But it's good that we solved this corner case anyways.
Thanks for working on this!
I'll hold it if you need to fix some of the non-blocking suggestions.
/lgtm
/hold

/unhold

/lgtm
(quick lgtm as requested given this has been reviewed)


Add support for Solidity constructors.

Addresses issue #260

Thanks for PR and sorry for not merging this yet. Can make sure, that it works with current develop branch? I'd merge it then.

No worries. I'll take a look at it later today.

I'm seeing a bunch of Solidity tests fail, but I think they might have already been failing. Will get back to you when I figure out what's going on.

@ryepdx much appreciated!


hyprlandPlugins.hy3: init at 0.31.0

Description of changes
Add hyprland plugin support with the first being hy3
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1196

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2892

@fufexan can you have a look please?

I've thought of a more streamlined approach, you can find it here. Still up for debate.
@outfoxxed thoughts?

@fufexan Imo @aacebedo's approach is more flexible with regard to build systems and unlisted options, but they're extremely similar.

I've thought of a more streamlined approach, you can find it here. Still up for debate. @outfoxxed thoughts?

Why not but I was expecting to have the plugins available inside nixpkgs as hyprland is. I need this because I prefer to have the modules in my flake coming from nixpkgs in priority. I took inspiration from other applications featuring plugins and already present in nixpkgs.

Maybe meta should also have some general information about how to use plugins appended for every plugin

ES plugins are written this way (https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/servers/search/elasticsearch/plugins.nix)
vimplugins as kind of similar approach (https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applications/editors/vim/plugins/generated.nix)

I was just commenting on moving ... to its own line instead of leaving it inline

I was just commenting on moving ... to its own line instead of leaving it inline

ok. I agree this can be changed.

Maybe meta should also have some general information about how to use plugins appended for every plugin

You mean in the description field or as comment in the source? Usually I take the description from upstream in order the package is as faithful as possible to the intent of the author.

Yeah I meant append to it with some general instructions on how to install a plugin, since you can't just put them in path.

Yeah I meant append to it with some general instructions on how to install a plugin, since you can't just put them in path.

ok noted

done

It would be nice to expose the mkHyprlandPlugin function, as it can be used for declaring plugins outside nixpkgs.

done

I meant generically for all plugins via the builder.
It probably makes sense to say something like "Plugins can be installed via a plugin entry in the hyprland config or home manager.

It would be nice to expose the mkHyprlandPlugin function, as it can be used for declaring plugins outside nixpkgs.

yeah this

done

I meant generically for all plugins via the builder. It probably makes sense to say something like "Plugins can be installed via a plugin entry in the hyprland config or home manager.

It would be nice to expose the mkHyprlandPlugin function, as it can be used for declaring plugins outside nixpkgs.

yeah this

changed for the description

I am not sure why ofborg fails. In question try rebasing but this should be fixed before merging.

ofborg still fails :(

@SuperSandro2000 problems fixed can you merge please ?

@SuperSandro2000 one last look hopefully :)


Problem with the NYU dataset Matlab code

Hi I just want to know if you make any modification for the file process_raw.m or other file in the official Toolbox for the NYU dataset. Im getting an error about the get_synched_framed, its seem that it cannot go through the scene subfile (like basement_0001a), its return 0 file in the scene but all the files are there. I did it on Octave in Linux Mint and I used the Raw dataset, Single File (~428 GB) from https://cs.nyu.edu/~silberman/datasets/nyu_depth_v2.html.
Thanks a lot for your help.

Hmm I guess using octave might be an issue. It would be worth trying it with Matlab I think.

Hello everyone, I am using the same toolbox, It is doing well on raw dataset I downloaded from NYU page however I want to process my own kinect data and make my own depth dataset for training of neural network.
I wanted to know before giving it to project_depth_map.m function they are using swapbytes.m function of matlab.
First question is why would they use that function
Secondly there is this condition of
  imgDepth(imgDepth < 600) = 2047;    imgDepth(noiseMask) = 2047;
Why are they taking these values because my data is in mm and max value of like 4000  which makes it 4 meters.
I am really stuck in this issue could you help me please,
I would appreciate that.
Regards


Fixed Issue#12676 Different column is exported to CSV when columns have the same name

Hi,
I found out that the root cause of the issue #12676 was that in ResultSetDataContainer.java, the filtering of the ResultSet based on the selected columns was being done only based on column name. This caused any column that had the same name as a selected column to be put inside the filtered array.
I put in an additional condition to compare the ordinal positions of a candidate attribute against those of the selected columns. Now only the columns in the selected positions are exported.
To make this change, I added a new private member List to the ResultSetDataContainerOptions.java and added get and set methods for the same. I also updated the code wherever a ResultSetDataContainerOptions object was being created to set the new member List so that no existing code calls filterAttributeBindings() without setting the list of selected column ordinal positions and raises an exception.
Please review if the changes are appropriate. I have attached some screenshots validating the fix here.

ResultSet= [1,2,3]. Select only the first column containing 1.

New expected behaviour

Earlier behaviour with the same input

This also corrects the behaviour of OpenWith option.

Hi Dbeaver team, May I follow-up on of this PR ?
Thanks.

Thanks for the PR 👍
However this issue may be resolved in #13299
We'll test it during version 21.1.4 and review this PR again.

Thanks for your PR again!
The problem was solved a little bit in another way.
https://github.com/dbeaver/dbeaver/issues/12676


Elide default root_url in the bottle block

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

Elide root_url "https://homebrew.bintray.com/bottles" in the bottle block, even it does not match the default root_url.

@sjackman Might be worth refactoring these into a flag or environment variable so they just have a single value.

Codecov is AWOL. Could an admin merge this PR?

Thanks @sjackman!

Thanks for merging, Mike!


apply_torque_impulse() not working on a RigidBody2d that uses CollisionPolygon2d "Segments" build mode

Godot version
v3.5.1.stable.official [6fed1ffa3], v4.0.beta7.official [0bb1e89fb]
System information
Windows 10, AMD 6800xt on 22.11.1 Adrenalin drivers, GLES3 & Vulkan
Issue description
Using a CollisionPolygon2d as the collision shape for a RigidBody2d, apply_torque_impulse() seems to have no effect while the Build Mode is set to "Segments". This is not an issue when using the "Solids" build mode.
The attached repro zip file is for 3.5.1, but this exists in 4.0 beta 7 aswell
Steps to reproduce
In project settings > physics 2d, set default gravity to 0, default gravity vector to (0, 0), and default linear and angular damp to 0.
Make a 2d scene, with a RigidBody2d that uses a CollisionPolygon2d as the collision shape.
On the RigidBody2d, disable Can Sleep. Attach a script to the node, and add some code that will apply a torque impulse.
extends RigidBody2D

var torque = 300

func _integrate_forces(state):
	if Input.is_action_pressed("ui_left"):
		apply_torque_impulse(torque)
	if Input.is_action_pressed("ui_right"):
		apply_torque_impulse(-torque)

On the CollisionPolygon2d, change the Build Mode to "Segments".
In debug menu, enable "Visible Collision Shapes"
Run the scene and nothing should happen when pressing the ui_left or ui_right keybinds. Changing the Build Mode to "Solids" and rerunning will then show the application of the torque impulse that is expected.
Minimal reproduction project
CollisionPolygon2dTest35.zip

This is related to https://github.com/godotengine/godot/issues/68068. In this case, applying a torque impulse requires (inverse) inertia to be set/nonzero:
https://github.com/godotengine/godot/blob/e82d66f23b987f9380b666179f25b44813509106/servers/physics_2d/godot_body_2d.h#L235-L237
The (inverse) inertia is by default computed based on the shapes:
https://github.com/godotengine/godot/blob/e82d66f23b987f9380b666179f25b44813509106/servers/physics_2d/godot_body_2d.cpp#L98
But the GodotConcavePolygonShape2D doesn't support this:
https://github.com/godotengine/godot/blob/e82d66f23b987f9380b666179f25b44813509106/servers/physics_2d/godot_shape_2d.h#L524
Using the "Segments" build mode on a CollisionPolygon2D creates such a GodotConcavePolygonShape2D.
This should be documented. In 4.0, a workaround is to set the inertia property on the RigidBody2D to 14084.51.

Thanks for the in depth explanation! Are there plans to add support for applying torque like this to a GodotConcavePolygonShape2d? Or is this not desired for this type of physics object? It would be nice if the inertia was set correctly by default, but I'm not familiar enough with the physics server to know if that would mess with anything else.


Don't use a uint8_t random distruction in DiverseStack unit tests

The C++ standard doesn't recognise uint8_t as a valid distribution type
http://stackoverflow.com/questions/31460733/why-arent-stduniform-int-distributionuint8-t-and-stduniform-int-distri

@swift-ci please smoke test


Caches also saves data in the navbar

The caching system works properly, however, it happens that if caching is stored with me as the user, visitors who visit the page end up with my name as the logged-in user in the navbar.
How can I avoid having items cached that should only be seen by logged-in users?

What you're trying to do is probably outside the scope of this caching extension at the moment. However, here's something you can do to begin accomplishing this:
Load your sensitive data through ajax.
This caching extension is only going to cache the response from specific controllers. so If you're using an ajax loading system to populate certain datasets, then the core of the page gets cached and your sensitive content is loaded via ajax (not a cached route)

Personal I only use the middleware on public routes (that doesn't have any user information visible) If the current user is the only different part it can be an option to use the ajax way as described by @jonathonbyrdziak
Else I think it is more useful to cache parts of your response and not the whole page (but that is out of scope for this package).


Ubuntu swapaccounting configuration causes continuous reboot on Alicloud

Ubuntu nodes on Alicloud go into continuous reboot due to #666.
The most probable cause is that Alicloud are using external kernel configuration and not using the grub config on disk. Which causes the reboot case to always trigger.
Possible fix is to exclude Alicloud form this configuration.

This PR addresses the solution
https://github.com/kubermatic/machine-controller/pull/683/files


On restart, plugin stops other plugins appearing

This may be an artefact of all dev plugins, would seem reasonable, but logging none the less.
Expected Behaviour

all plugins load at once

Actual Behavior

our plugin appears with a orange background around the icon
removing the plugin allows other plugins to appear

Steps to Reproduce this bug
Please include any info about the version of the tool you're using and your system. - remove this note before posting

Hardware versions: mac
Software versions: chrome
Steps to reproduce:

download plugin
restart computer
start chrome

Can't recreate this. Mine all come in as normal.

Tried this on my linux machine and on mac, still can't recreate.

I'll assign this back to @JosephMcArthur - you'll need to screengrab it, or talk to me about it at some point, as I can't replicate.

Okay, it seems the orange background may be expected: http://stackoverflow.com/questions/22551316/chrome-extension-icon-has-a-yellow-orange-highlighted-background-border

Weird it doesn't do it on mine, I could be using an old browser. But if it is from 2013... anyway if it is expected, and yes the description does seem to match what you experienced, then we can close this I think

Would be great if @meganwaps @chealsye @natalianorori could try and recreate this.

Ah ha, this does happen now on my mac, probably a newer version. So yes, it goes orange and shows a warning about developer extensions, which I accept, then it loads the other extensions and the colour goes back to normal. This is OK, just the dev extension warning which won't show up once it is installed normally.

Great, closing.


Tighten up the popup so it does not overlap the earnings table

Tightened up the layout of the popup so it does not cover the earnings table.
These tweaks combined with disabling "Always open in a new tab" makes surfing earnings super-fast and convenient.
Also fixed the disappearing border bug on some browsers / operating systems.

LGTM


Resolve DMARC/DKIM issues with ZenDesk setup

What we're after
Ability to send emails via ZenDesk re-enabled without causing DMARC/DKIM issues (as experienced by the EPA, especially).
Hypothesized benefit(s)/why:

Simplifies support/inquiry process
Allows emails to be received by customers

Acceptance Criteria

[ ] EPA successfully receives email through ZenDesk without DMARC warnings
[ ] DMARC/DKIM settings are set in accordance for ZenDesk

Further context for those unfamiliar with what we're doing
There's some history with this in the 🔒 Support Processes doc.
EPA customers sometimes receive emails with “[WARNING: DMARC validation failed]” in the subject of the email.
GSA Service Desk INC2781800 - Email failures for Cloud.gov Emails
Security considerations

Some question re: whether we can make the necessary changes with the current<EMAIL_ADDRESS>email address or if we'll need to move to a @cloud.gov address

Will discuss with GSA IT

If the messages are being generated and sent by a system outside of GSA's network, they cannot use @gsa.gov in the from field because of anti-spoofing protections we have in place. We have had a couple of groups use a subdomain, like @zendesk.gsa.gov , but if you can change the address to @cloud.gov that would probably be the path of least resistance, as there's a bunch of additional setup for rolling out a new subdomain.

Sounds like moving to<EMAIL_ADDRESS>would be our path of least resistance, and we can set the google group to autoforward from the Support group to that new address.
Tasks for this would be:

Work with GSA IT to get CNAME records set for the cloud.gov domain
Set up ZenDesk with new support address
Verify with customers (EPA) that they receive new emails from ZenDesk
Update documentation to use new cloud.gov support address
Set Support google group to autoforward to cloud.gov support address
Disable emails from Support google group (or possibly remove individuals)

@eddietejeda and @hillaryj is this story still a priority for this sprint (sprint 19.10.30)? Is this addressing a client request? Just trying to figure out if this story is high enough priority that it should be wrapped up this sprint or de-prioritized and addressed in a future sprint?


Memory Polynomial and LUT DPD

Opened #51 to separate SG code from this pull request. Plan is to accept the SG changes then merge master into this branch taking masters VIs.

Closing this pull request because I split it into two separate requests:
#51 and #52


animate().during only once?

Congrats for the library, which makes working with SVG a breeze.
What is the clean way of calling a callback during an animation, at a certain point (e.g. 50%)?
I know of animate().during but that is called all the time...
Thanks in advance!

There is no other possibility except the one you already mentioned.
during gets the position parameter as argument. You can check against this param and call your code when it hits 0.5. Note that easing is already applied to this position so 0.5 means 0.5 in "space" and not in time

Would you consider adding some functionality for this? once-callbacks are a pretty common pattern nowadays...
As an alternative, one could give more info to the callback of during, e.g.
rect.animate()
  .during(function (pos, lastPos) {
    if ((lastPos < 0.5) & (pos > 0.5))
      // do something...
  })

I try to rewrite the whole animation module anyway. I will add this to the list. However this can rly take some time

implemented in 3.2.0 as once(pos, func, isEased) (https://github.com/wout/svg.js#once)


Public workspaces are not available, and speciality workspaces are not workspaces

How do i see the list of public workspaces and how do I get to them.

There is nothing in special collections or public workspace as of now, except:

OMICS4TB data<EMAIL_ADDRESS>Collections/NIAID Systems Biology Centers

My suggestions:

Special collections: links to the existing data landing pages for now
Workspaces: given that we do not support multiple workspaces for users for now, it owuld be more useful to provide direct links to genome groups, feature groups, and perhaps other recently updated top level folders in my workspace

Fixed


PSUseOutputTypeCorrectly is triggered when it shouldn't.

It looks to me like PSUseOutputTypeCorrectly check is not taking very basic, crucial, fundamental fact about PowerShell into account: by default it will not keep any simple collection, unless you explicitly tell it to.
Result? I have PInvoke code (taken from here) and I correctly defined OutputType as [Connection] (I've actually created namespace for it, but that's irrelevant).
As expected, Get-Member confirms that PowerShell function will return stream of connections, not collection as a whole. Yet, PSScriptAnalyzer will complain about it:
Line: 45 - The cmdlet 'Get-OPNetStat' returns an object of type 'Optiver.Connection[]' but this type is not declared in the OutputType attribute.
Line: 54 - The cmdlet 'Get-OPNetStat' returns an object of type 'Optiver.Connection[]' but this type is not declared in the OutputType attribute.

In fact, if I would follow instructions and declare my OutputType as a collection it would be conflicting with what my function actually returns:
Set-StrictMode -Version Latest
Get-OPNetStat | % IsFixedSize
% : The input name "IsFixedSize" cannot be resolved to a member.

IsFixedSize was tab-completed, based on OutputType that PSScriptAnalyzer told me to define. As expected, my Connection object doesn't have it. The only workaround I've found that satisfies both PSScriptAnalyzer and my hope to get nice tab-completion for command I wrote is to pass result of the command thru ForEach-Object:
[Optiver.NetworkUtil]::GetTCP() } | ForEach-Object { $_ }

I think I understand what you are saying but would like to have more information. Can you please provide me with an example so that I can reproduce this issue? Thanks!

Sure thing. This is the code that should help repro the issue:
# Lets define some dummy type...

Add-Type @'
using System;

namespace foo
{
    public class bar
    {
        public bar ()
        {
            this.Name = "Unknown";
        }
        public bar (string name)
        {
            this.Name = name;
        }
        public string Name;

    }
    public class barFactory
    {
        public static bar[] Create ()
        {
            return new bar[] {
                new bar ("one"),
                new bar ("two"),
                new bar ("three")
            };
        }
    }
}
'@

# Function definition...

$def = @'
function Get-Foo {
    [OutputType([foo.bar])]
    [CmdletBinding()]
    param ()
    [foo.barFactory]::Create()
}

function Get-FooCollection {
    [OutputType([foo.bar[]])]
    [CmdletBinding()]
    param ()
    [foo.barFactory]::Create()
}
'@

Invoke-ScriptAnalyzer -ScriptDefinition $def -IncludeRule PSUseOutputTypeCorrectly

# Verify that definition, not Script Analyzer is correct...
. ([scriptblock]::Create($def))

# Setting script mode to get errors when accessing non-existing properties...
Set-StrictMode -Version Latest

# Both properties based on OutputType suggested by command...
Get-Foo | ForEach-Object Name
# one, two, three, as expected...
Get-FooCollection | ForEach-Object Count
# ForEach-Object : The input name "Count" cannot be resolved to a member. x3

Same here. Look at that short snippet (I removed some boilerplate, this one isn't actually working as is)
As you can see, the ObjectType is not defined by the $tmpList object, because it's piped to a Converter. Also is it only one case, where the ArrayList is used.
function Get-TogglProject {
    [OutputType("PSToggl.Project")]
    param([...])

    $projects = Get-SomeItems

    switch ($PsCmdlet.ParameterSetName) {
        "byObject" {
    #This is where an ArrayList is created
            $tmpList = New-Object -TypeName System.Collections.ArrayList
            foreach ($item in $InputObject) {
                $tmpList.add($pL.Invoke($item))
            }
            $projects = $tmpList
        }
        "byName" {
            $projects = $projects | Where-Object {$_.Name -Like $Name}
        }
    }

    return $projects | ConvertTo-TogglProject
}


Release to Terraform Registry

Version 0.13.0 and later has an updated way of dealing with hierarchical providers and changes the default installation paths for new plugins.
To make the plugin more accessible, we should publish to the terraform registry using GH Actions as is recommended by the guide: https://www.terraform.io/docs/registry/providers/publishing.html.

And we're live: https://registry.terraform.io/providers/pactflow/pact/latest


[FEATURE] I would like to have the capability develop using python classes instead of acons

Is your feature request related to a problem? Please describe.
Acons are harder to debug and to be validated on the user end.
Doing a class based solution would allow us to use validations for example with pydantic  and have a better flow as a developer and allow the use of a debuger
Describe the solution you'd like
This is a rough sketch (classes I used here don't make much sense) just to get the idea but something along this line of
def main():
    options = Options(
        badRecordsPath="s3://my-data-product-bucket/badrecords/order_events_with_dq/",
        header=False,
        delimiter="\u005E",
        dateFormat="yyyyMMdd"
    )

    input_spec = InputSpec(
        spec_id="orders_bronze",
        read_type="streaming",
        data_format="csv",
        schema_path="s3://my-data-product-bucket/artefacts/metadata/bronze/schemas/orders.json",
        with_filepath=True,
        options=options,
        location="s3://my-data-product-bucket/bronze/orders/"
    )

    transformers = [
        Transformer(function="with_row_id"),
        Transformer(
            function="with_regex_value",
            args={
                "input_col": "lhe_extraction_filepath",
                "output_col": "extraction_date",
                "drop_input_col": True,
                "regex": ".*WE_SO_SCL_(\\d+).csv"
            }
        )
    ]

    transform_spec = TransformSpec(
        spec_id="orders_bronze_with_extraction_date",
        input_id="orders_bronze",
        transformers=transformers
    )

    dq_functions = [
        DQFunction(dq_function="expect_column_values_to_not_be_null", args={"column": "omnihub_locale_code"}),
        DQFunction(dq_function="expect_column_unique_value_count_to_be_between", args={"column": "product_division", "min_value": 10, "max_value": 100}),
        DQFunction(dq_function="expect_column_max_to_be_between", args={"column": "so_net_value", "min_value": 10, "max_value": 1000}),
        DQFunction(dq_function="expect_column_value_lengths_to_be_between", args={"column": "omnihub_locale_code", "min_value": 1, "max_value": 10}),
        DQFunction(dq_function="expect_column_mean_to_be_between", args={"column": "coupon_code", "min_value": 15, "max_value": 20})
    ]

    dq_spec = DQSpec(
        spec_id="check_orders_bronze_with_extraction_date",
        input_id="orders_bronze_with_extraction_date",
        dq_type="validator",
        result_sink_db_table="my_database.my_table_dq_checks",
        fail_on_error=False,
        dq_functions=dq_functions
    )

    merge_options = MergeOptions(
        merge_predicate="""
            new.sales_order_header = current.sales_order_header
            and new.sales_order_schedule = current.sales_order_schedule
            and new.sales_order_item=current.sales_order_item
            and new.epoch_status=current.epoch_status
            and new.changed_on=current.changed_on
            and new.extraction_date=current.extraction_date
            and new.lhe_batch_id=current.lhe_batch_id
            and new.lhe_row_id=current.lhe_row_id
        """,
        insert_only=True
    )

    output_spec = OutputSpec(
        spec_id="orders_silver",
        input_id="check_orders_bronze_with_extraction_date",
        data_format="delta",
        write_type="merge",
        partitions=["order_date_header"],
        merge_opts=merge_options,
        db_table="my_database.my_table_with_dq",
        location="s3://my-data-product-bucket/silver/order_events_with_dq/",
        with_batch_id=True,
        options={"checkpointLocation": "s3://my-data-product-bucket/checkpoints/order_events_with_dq/"}
    )

    terminate_spec = TerminateSpec(
        function="optimize_dataset",
        args={"db_table": "my_database.my_table_with_dq"}
    )

    exec_env = ExecEnv(spark_databricks_delta_schema_autoMerge_enabled=True)

    engine = LakehouseEngine(
        input_specs=[input_spec],
        transform_specs=[transform_spec],
        dq_specs=[dq_spec],
        output_specs=[output_spec],
        terminate_specs=[terminate_spec],
        exec_env=exec_env
    )

    engine.run()

if __name__ == "__main__":
    main()

As oposed to full acon based:
from [lakehouse_engine.engine](https://adidas.github.io/lakehouse-engine-docs/lakehouse_engine/engine.html) import load_data

acon = {
  "input_specs": [
    {
      "spec_id": "orders_bronze",
      "read_type": "streaming",
      "data_format": "csv",
      "schema_path": "s3://my-data-product-bucket/artefacts/metadata/bronze/schemas/orders.json",
      "with_filepath": True,
      "options": {
        "badRecordsPath": "s3://my-data-product-bucket/badrecords/order_events_with_dq/",
        "header": False,
        "delimiter": "\u005E",
        "dateFormat": "yyyyMMdd"
      },
      "location": "s3://my-data-product-bucket/bronze/orders/"
    }
  ],
  "transform_specs": [
    {
      "spec_id": "orders_bronze_with_extraction_date",
      "input_id": "orders_bronze",
      "transformers": [
        {
          "function": "with_row_id"
        },
        {
          "function": "with_regex_value",
          "args": {
            "input_col": "lhe_extraction_filepath",
            "output_col": "extraction_date",
            "drop_input_col": True,
            "regex": ".*WE_SO_SCL_(\\d+).csv"
          }
        }
      ]
    }
  ],
  "dq_specs": [
    {
      "spec_id": "check_orders_bronze_with_extraction_date",
      "input_id": "orders_bronze_with_extraction_date",
      "dq_type": "validator",
      "result_sink_db_table": "my_database.my_table_dq_checks",
      "fail_on_error": False,
      "dq_functions": [
        {
          "dq_function": "expect_column_values_to_not_be_null",
          "args": {
            "column": "omnihub_locale_code"
          }
        },
        {
          "dq_function": "expect_column_unique_value_count_to_be_between",
          "args": {
            "column": "product_division",
            "min_value": 10,
            "max_value": 100
          }
        },
        {
          "dq_function": "expect_column_max_to_be_between",
          "args": {
            "column": "so_net_value",
            "min_value": 10,
            "max_value": 1000
          }
        },
        {
          "dq_function": "expect_column_value_lengths_to_be_between",
          "args": {
            "column": "omnihub_locale_code",
            "min_value": 1,
            "max_value": 10
          }
        },
        {
          "dq_function": "expect_column_mean_to_be_between",
          "args": {
            "column": "coupon_code",
            "min_value": 15,
            "max_value": 20
          }
        }
      ]
    }
  ],
  "output_specs": [
    {
      "spec_id": "orders_silver",
      "input_id": "check_orders_bronze_with_extraction_date",
      "data_format": "delta",
      "write_type": "merge",
      "partitions": [
        "order_date_header"
      ],
      "merge_opts": {
        "merge_predicate": """
            new.sales_order_header = current.sales_order_header
            and new.sales_order_schedule = current.sales_order_schedule
            and new.sales_order_item=current.sales_order_item
            and new.epoch_status=current.epoch_status
            and new.changed_on=current.changed_on
            and new.extraction_date=current.extraction_date
            and new.lhe_batch_id=current.lhe_batch_id
            and new.lhe_row_id=current.lhe_row_id
        """,
        "insert_only": True
      },
      "db_table": "my_database.my_table_with_dq",
      "location": "s3://my-data-product-bucket/silver/order_events_with_dq/",
      "with_batch_id": True,
      "options": {
        "checkpointLocation": "s3://my-data-product-bucket/checkpoints/order_events_with_dq/"
      }
    }
  ],
  "terminate_specs": [
    {
      "function": "optimize_dataset",
      "args": {
        "db_table": "my_database.my_table_with_dq"
      }
    }
  ],
  "exec_env": {
    "spark.databricks.delta.schema.autoMerge.enabled": True
  }
}

load_data(acon=acon)

Hi @callmesora,
thanks for opening the idea for a new Feature and for the sketch/suggestion 💯. This is definitely something that I feel would make lots of sense and I have been having it on my personal backlog for a while, but which did not collect enough interest or demand to pursue, for now.
The idea would always be to keep the current approach, but also provide an additional interface (along the suggested lines). We actually already have some of the ingredients there, so the work needed is really on this "interface" solely.
I will keep this open, so that we can collect more interest or even ideas until we have enough capacity to take it. Otherwise, please also feel free to contribute and I can help you out if you face any problems or want to discuss it further.


Reorganized VKTree services and implemented startup consumption of sequencer arguments for workers

Closes #207
Description in the issue
Enhanced the FlowTaskWorker to accept three different types of tasks:
UnpreparingTask: Tasks that don't implement a prepare() method, therefore they don't have to wait for registration to get initialized - important because we need the CircuitCompilerTask before we have working worker registration
AbstractStartupTask: Tasks that are used for startup of workers: Mainly the WorkerRegistrationTask
Task: All normal tasks that wait for registration to be completed before preparing and registering for tasks

@rpanic From a high-level, how did you get around the issue of the worker processes not having access to the VKTreeService?

@ejMina226
Two-fold: The first thing I did was instead of accessing the VKTreeService in the BlockProver, which is executed by a task, I add the VK and the tree witness as a task payload and through that, I use them in the BlockProver as a traditional program arguments / witness.
The second thing is how the blockprover has access to the tree root, which has to be baked into the circuit at compile time. This is done via a extra step that happens when the worker gets started, which is the "worker registration". I outlined that in more detail in the linked issue


Readme: fix installation line

Since version 1.18

go: go.mod file not found in current directory or any parent directory.
go get is no longer supported outside a module.
To build and install a command, use go install with a version,
like go install example.com/cmd@latest
For more information, see https://golang.org/doc/go-get-install-deprecation
or run'go help get or go help install.

Thank you!


Bumped packages versions

Hey, some bug fixes in DistributedLock
and some other version bumps

Btw, you might want to add the TestData folder, because there were some bugs with the tests
(I didn't fully test it)

Hi @idan-h
First, can I ask if you have a problem with this library or did you see the new version of the DistributedLock and thought it should be included. If there was a problem I would like know as I haven't seen this problem.
Also I assume from from your Btw that the tests didn't work because there wasn't a TestData folder in the repo. I will add a file inside the TestData folder the next time push.

I didn't have a problem, I just saw some bug fixes in the DistributedLock library and thought they should be included
About the btw, yea this is it. There might still be some minor path fixes, but I can fix that the next time I push.


Colors could be overridden by app colors.

I decided to do it this way. Most usage for changing the color is, that the app colors (primary/accent) should be used.

@esafirm Something wrong with this PR? Do you have proposals?

@Rainer-Lang sorry for the late response.
This is suffice for now, but i think we should provide a way to override this as well. Thanks


Invalid certificate generated by example.sh

Steps to reproduce:

Set up two nodes
Execute example.sh from master tree
Copy truststore.jks to nodes, and use node-0-keystore.jks on one, and node-1-keystore.jks (or node-2-keystore.jks) on the other node
Configuration:
searchguard.ssl.transport.keystore_filepath: node-X-keystore.jks
searchguard.ssl.transport.keystore_password: changeit
searchguard.ssl.transport.truststore_filepath: truststore.jks
searchguard.ssl.transport.truststore_password: changeit
searchguard.ssl.transport.enforce_hostname_verification: false
Start nodes

Result:

First node starts up correctly, second does not

Base Exception:
(stacktrace omitted)
Caused by: sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: Path does not chain with any of the trust anchors
Tested with:

OSX
Java SSL
OpenSSL
ES 2.1.0 and ES 2.2.0

Seems only the first cert is valid.

cannot reproduce with vagrant (https://github.com/floragunncom/search-guard-ssl/commit/98912b2c0c7b5b2b0e200b71d3432628f4d8a533)

Cannot reproduce anymore with latest example scripts


Update Event Schema and Event Model

Please provide a summary of the feature
We've had extensive discussions about editing the event model to accomplish the necessary tasks more efficiently.
We've settled on option #3 of what @miguelbj has proposed. Please review his comments for a complete understanding.
This includes:

All events will be a separate date object. This includes recurring dates, as they will no longer be stored into a recurring dates array.
Date objects will have a groupID. This allows recurring events to be grouped together under one type of event.

Are there any potential issues you foresee with this feature
This is a pretty big update as this is a big change, and this will break a fair bit of logic in how Together fundamentally works. This should be a solo issue.
Is this feature related to any current or past issues? Please provide the
Additional context
Add any other context or screenshots about the feature request here.
Which Branch should this fix be Pulled into?
PR into eventModalUpdate
If you're interested in working on this feature, please comment so you can be assigned

@romanstetsyk 👋

Is there a separate branch for this issue?

Is there a separate branch for this issue?

Trying to finish a few PRs before I branch this one. Give me until the end of the day.

Is there a separate branch for this issue?

@romanstetsyk I'm still out with the family. If you have any work done before heading to bed PR to development and I will create and switch to the new branch.

Hey @Caleb-Cohen is there a plan in place to unwind and then delete the old nested objects in the dates  array? Or is the project Together small enough to delete and remake the events that are currently in there so they match the new data model?

Hey @Caleb-Cohen is there a plan in place to unwind and then delete the old nested objects in the dates array? Or is the project Together small enough to delete and remake the events that are currently in there so they match the new data model?

Delete and replace. We're currently adding event objects on a month-to-month basis, and a vast majority of January events are not even in the DB yet.


OSD-4552: improve moactl verify quota error messages

Signed-off-by: Ben Ye<EMAIL_ADDRESS>Fixes https://issues.redhat.com/browse/OSD-4552
Readme also updated.
Verification

@NautiluX Hello, I addressed all your comments. Please take a look when you get a chance. :)

@yeya24 @NautiluX - I've rebased against master, made the error output into integers, and fixed a few linter issues. Please take a look when you have a chance

just squashed commits. merging


How About Fixing az login

Hundreds of tickets opened. NO solutions.
How about fixing
  az login
Note, we have launched a browser for you to login. For old experience with device code, use "az login --use-device-code"
Please ensure you have network connection. Error detail: HTTPSConnectionPool(host='login.microsoftonline.com', port=443): Max retries exceeded with url: /common/oauth2/token (Caused by SSLError(SSLError("bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')])")))
↵ 1  az --version
azure-cli                         2.0.75
command-modules-nspkg              2.0.3
core                              2.0.75
nspkg                              3.0.4
telemetry                          1.0.4
Python location '/usr/local/Cellar/azure-cli/2.0.75/libexec/bin/python'
Extensions directory '/Users/scsanbeg/.azure/cliextensions'
Python (Darwin) 3.7.5 (default, Nov  1 2019, 02:16:32)
[Clang 11.0.0 (clang-1<IP_ADDRESS>)]
Legal docs and information: aka.ms/AzureCliLegal
Your CLI is up-to-date.
Mac OS Mojave 10.14.6
Python versions used: 2.7 3.7 3.8.0 - all fail

@jiasli  add to S161.

Please see the doc for using CLI behind a proxy.


[WIP] Add tests to compile generated code

Tries to compile every tests to make sure there are no errors

[x] Typescript
[ ] Flow

Fixes #69

Started onboarding myself into this pr tonight. A small dep change allowed the tests to pass locally. They pass on ci too, but then (it seems) jest never exits and so the ci times out. Aside from ramping up, a difficulty here is the lack of feedback. To help narrow the issue, I may try to incrementally temporally eliminate test code until the ci problem goes away.

I didn't observe carefully before. Looking again at the tests running on https://circleci.com/gh/prisma/graphqlgen/677, I noticed that large-schema tests are missing from the output, e.g. from local:
 PASS  src/tests/flow/large-schema.test.ts (8.686s)
 PASS  src/tests/typescript/large-schema.test.ts (13.524s)

When I isolate the large-schema tests they run ok though build link.

jest --runInBand is one solution. It increases the test time however. Will continue looking for a root cause.

When I comment out:
  if (config.language === 'flow') {
    await compileFlow(config.models.files!, config.output)
  }

it works.
Looking at the source:
writeFileSync(path.join(path.dirname(typesPath), '.flowconfig'), flowConfig)

we see disk interaction. Since tests run in parallel, and the file name here is a constant, there is disk contention. And indeed if we remove one of the schema tests (only tried "basic") of flow, the test suite works (build link).
I will look to see if flow has a better programatic API to work with. Writing a config to disk etc. feels like a more complicated program, is not as easily isolated as with just in memory, ... so on.

Related:

https://discuss.circleci.com/t/babel-7-jest-results-in-timeout/25383/5
https://vgpena.github.io/jest-circleci/
https://circleci.com/ideas/?idea=CCI-I-578

Eventually figured out that the disk contention was not the root cause (probably not implicated at all). There are quite a few existing issues on the inerwebs about cci/travis not handling jest auto-cpu-count detection well. Capping worker count on CI worked here too.
I found one flow test that was commented out and needed finishing, default name. What I found was that flow wouldn't compile because (not type name mismatch):
export interface Mutation_AddMemberData {
  email: string;
  projects: string[];
}

export interface Mutation_Args_AddMember {
  data: AddMemberData;
}

I now append prefixes to the types of field arguments (in the above case... Mutation_) to comply with the pattern in our snapshots. I do not really understand the flow strategy, so, I'm not 100% confident with my commit here; in a nutshell: every field arg type gets a prefix except enum, input, object (which correspond to at least in some tests to GQL ID type).

@timsuchanek let me know if there are any other blocking issues in this PR from your point of view. Propose that minor issues we punt for iterative refactoring : )

@timsuchanek given that you seemed pretty satisfied already and I've fixed the two style issues you noted, going to merge, keep things rolling. And these tests like you said will start helping immediately : )