[e2e]: go tag main config-ldflags-assets slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.547
Run: https://github.com/slsa-framework/example-package/actions/runs/7176079720
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.547
Date: Tue Dec 12 02:30:21 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.548
Run: https://github.com/slsa-framework/example-package/actions/runs/7189897955
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.548
Date: Wed Dec 13 02:30:36 UTC 2023
Tests are passing now. Closing this issue.


List is showing blank result

Hi,
I load the control with default value, it shows the value in input field. However when I search, i see the data I get back from API but nothing is shown in UI.
I have verified that the response fields contains the props.column values along with atrributeid. What am I missing here?
Appreciate your help!

Hi, I believe you are missing something in the configuration of the control in the columns. Please refer to the documentation again.


[CERT-TEST-FAILURE] TC-DISHALM-3.2 - Test failed

Feature Area
Area:Dishwashers
Test Case
TC-DISHALM-3.2
All-clusters-app has to be enabled with below mentioned attribute :
State attribute
All-clusters-app has to be enabled with below mentioned command :
Reset
All-clusters-app has to be enabled with below mentioned event :
Notify event
system configuration
Chip-tool - RPI-4, 8GB RAM
DUT - RPI - RPI-4, 8GB RAM
Platform : onnetwork
Dut application: dishwasher-app
Bug prevalence
Everytime
GitHub hash of the SDK that was being used
701fcb21f9a1bc4c7792c6e0709a3c74101fa6f5
Platform
raspi
Anything else?
No response

This is being addressed in PR #27748.

implemented in latest TOT


[Performance]: Why is it so slow to deploy the model using Ray

Proposal to improve performance
No response
Report of performance regression

The two nodes are on the same LAN, so it shouldn't be that slow in theory
Misc discussion on performance
No response
Your current environment (if you think it is necessary)
No response

@wx971025 could you try with https://github.com/vllm-project/vllm/pull/3466 to see whether it's a Ray-specific issue?


test-branch/execute-job/wrong-commit-sha-on-pr/a57432cf-2f06-4e69-9578-89544171edba

PR for testing 36a715310e508f53e2469d3cf9949a22692f831e

/canonical/self-hosted-runners/run-workflows 48b36c130b207278d20c3847ce651ac13fb9e9d7


Enable all TraceEvent Asserts for EventPipe

Currently there is something called DebugListenerBlock in the EventPipeParsing.cs tests for EventPipe.
This class is designed to suppress assertions while the test is running.  This was because previously EventPipe would emit junk at the end of an event and cause many asserts to fire.
Supressing asserts  is  hack.   With https://github.com/dotnet/coreclr/pull/14049 it should be the case that this extra space is no longer emitted.   Thus it should be possible to remove the assert supression, at least after the traces used in the tests have been updated.
Sadly it is not trivial to emit old formats that have been fixed.  Thus we will need to keep the supression around for V1 format testing, but other than that we can remove it.

There is another assert as well, here https://github.com/Microsoft/perfview/blob/master/src/TraceEvent/TraceLog.cs#L8322
I can take on looking into that if that'd be fruitful.

That assert is surprising to me.    It is simply saying that that there should be a entry in the list of all modules for every file that we have a file path for.   It should be true based on the code just above it (since we only add things to moduleFilesByName if we have already added it to moduleFiles.
I would suggestion commenting it out temporarily just to see what is beyond it.

Looking at the code, it is more subtle, because there is a 'SetModuleFileName' which also updates one of the tables.   You can look if you want, but I am happy to look at it if you check in a file that I can use to run tests.

The evil DebugListenerBlock  has been removed.   I am now happy


MSAcpi_ThermalZoneTemperature undefined

it returns undefined any idea y ?
wmi.Query({
class: 'MSAcpi_ThermalZoneTemperature',
namespace : 'root/wmi'
}, function(err, data) {
console.log(data);
});

Wrong namespace. root\cimv2 (Standard) is the right one.

@MadbHatter still undefined :( ,
although m using open hardware monitor to get the hardware details

Download the WMI Explorer (Just google it) and use it to find your class/properties.

From: Riaz Laskar<EMAIL_ADDRESS>Sent: Saturday, March 24, 2018 3:52:47 PM
To: jpgrusling/node-wmi
Cc: MadHatter; Mention
Subject: Re: [jpgrusling/node-wmi] MSAcpi_ThermalZoneTemperature undefined (#11)
@MadbHatterhttps://github.com/MadbHatter still undefined :( ,
although m using open hardware monitor to get the hardware details
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/jpgrusling/node-wmi/issues/11#issuecomment-375894892, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADV9U84k3GNet_FVVT0p9O9vUUWXc0wjks5thl2_gaJpZM4Su0gP.

@riazXrazor You need to have 2 back slashes
example root\\WMI


ShootingPointAnalysis items() and values() not working/result in error

The issue here is that the keys are strings but that __getitem__ expects them to be snapshots and tries to hash them. Since they are already hashed this results in an error, because naturally the strings do not have a coordinate attribute.
I have a fix for this behavior on  https://github.com/hejung/openpathsampling/tree/fix_SPA
I have added a conditional in __getitem__ checking if it is a string (->use key to take the snapshot from hash_representatives and use that as a key) or not (-> take the key as key).
EDIT: this breaks as soon as the keys are not strings anymore. The only general fix I can think of is (re)implementing .items() and .values() instead of inheriting them from Mappable but I am not sure if that is a good idea.

This is a good catch. However, I don't think it is essential to fix it before 1.0 (where committor-ish things are secondary), so @hejung, could you make a  PR that we can include as part of 1.1?

@dwhswenson yes, I will create a fix, after having thought about it most likely by (re)implementing .values() and .items() and the corresponding iterators, if that is ok with you?

It's been a while since I wrote that code, and you, @hejung, have been working with it more than me lately, so let me know if any of this sounds wrong:
Looking back at this, I think the intention was that we should be able to use coordinates as keys, even though (as numpy arrays) they can't be hashed. So I convert them to a string representation, which can be hashed. The idea is that there's an internal definition of the key (which is a string), which differs from the user-facing key (which is a snapshot, from which we get the coordinates, from which we get the string representation).
In that case, I think it makes complete sense to override .keys() and .items(). They should probably use what I call the "representative snapshot" (which will be, IIRC, the values of the hash_representatives attribute -- in practice, that's the first snapshot with those coordinates.)
(Above you wrote .values() and .items() -- I assume you meant keys, not values?)
Also, don't worry about the iter variants -- in Python 3, .keys(), .values(), and .items() are iterables, and .iterkeys() etc no longer exist. I think you can write this such that you get lists in Python 2 and iterators in Python 3, just by calling the right object's .keys()/.values(). If not, go ahead and make them all iterators -- Python 2 support is on the way out.

@dwhswenson
Sounds very reasonable!
I did not think about the fact that the underlying python objects will do the py2 -> py3 / list -> iterator transition for me.
.values() failes at the moment too because self.keys() gives the hash-strings, but it is probably enough to reimplement .keys() since values() is [self[key] for key in self.keys()].


Drag and drop?

This is a pretty cool idea.
Wondering if it's possible to drag items from outside the VNC window to parts inside of it?  This didn't seem to work for me.
Am running Arch yaourt version which bundles TigerVNC.
Cheers

Thanks for the suggestion! Just, I think first copy and paste needs to be implemented, and I haven’t yet.
Hint: Patches are welcome. ;)


I have created a Portuguese translation file of Maid Fiddler.(pt-br.json)

I made a Portuguese translation file for MaidFiddler
It was made in COM3D2 v1.49 and MaidFiddler v.<IP_ADDRESS>
Some items have been left out of the translation due to not being able to check the game display and support
pt-br.zip
http://www.mediafire.com/file/k1dy9k80zfztd4j/file

Thank you for these! I've pushed the translations to master; they'll be included in the next release of Maid Fiddler


Turbo Drive: "Referer" header set to target URL, not current URL

When using Turbo Drive, the Referer header seems to be set to the target URL, not the current URL:

This was following a link from /visits/ so I would have expected that to be the Referrer.
Is this by design?  Is there some other way to know the referring page?  I need to redirect back to different URLs once editing is done depending on the referring URL.

EDIT:  I'll note that by adding data-turbo="false" to those links, it works as expected and I receive the appropriate Referer header.  I've done that for now, which isn't my favourite solution, but lets me get back to work.

I confirm this occurs with v7.0.0-rc.1. It breaks :back url functionality in Rails link / url helpers.
It was introduced with the Pausable requests changes: #306
When commenting out line 82 in fetch_request.ts :
https://github.com/hotwired/turbo/blob/main/src/http/fetch_request.ts#L80
which simply disables await this.allowRequestToBeIntercepted(fetchOptions) in FetchRequest#perform(), then the Referer header sent is the correct one.

In #344 I've added a test to ensure the header is set correctly. The test currently fails and I can confirm what @zzeligg found out about the changes in #306.


Firrtl fix asyncreset emission

Currently this is the previous code contained in #1355 , my plan is to rework it so this is contained in the Verilog emitter, which I'll get to tomorrow.
Checklist

[x] Did you specify the type of improvement?
[x] Did you specify the code generation impact?

Type of Improvement

bug fix

Backend Code Generation Impact
Makes emission of constant-assigned asynchronous registers marked don't touch to not have latches inferred.
See discussion at #1355

Fixed in #1359


Activejob 7.2 support

Thank you for the effort :heart: , but https://github.com/veeqo/activejob-uniqueness/pull/80 arrived a few minutes earlier


One time migration of accounts and contracts at upgrade

CHANGELOG:

Adds two new chainspec settings (boolean) which toggles a one-time migration for accounts and contracts to the addressable entity
Removed the access uref field from the new Package type

bors r+

bors r+


MemoryInfo implementation for MAC

Uses sysctl to query total physical memory.
Uses host_statistics64 to calculate available physical memory (free_count + inactive_count - speculative_count).
Do not rely on external_page_count which should be the file cache because it is available since OSX 10.9 only and it shown inaccurate (larger than total memory) values with long uptime or under load.
Subtract speculative in order to provide a pessimistic result rather than an optimistic one.

Here are some evidence supporting the free memory calculation:

https://developer.apple.com/library/content/documentation/Performance/Conceptual/ManagingMemory/Articles/AboutMemory.html
https://github.com/oshi/oshi/blob/master/oshi-core/src/main/java/oshi/hardware/platform/mac/MacGlobalMemory.java

Here's a sh file to quickly do vm_stat queries: https://gist.github.com/eskatos/8c05edb1c2ae0bd20a490fefb9724c66

I dug into OSX vm_stat source code from 10.0 to 10.12 and here's what i've learnt.
The source is available here https://opensource.apple.com/ in the system_cmds archives.
10.0 to 10.5 (>2001)
Uses host_statistics
Free pages is stats.free_pages
Speculative pages is not present
File-backed pages is not present
10.6 to 10.8 (>2009)
Uses host_statistics64
Free pages is stats.free_pages - stats.speculative_pages
File-backed pages is not present
10.9 to 10.X (>2013)
Uses host_statistics64
Free pages is stats.free_pages - stats.speculative_pages
File-backed pages is stats.external_page_count

wrt ☝
I don't think we care so much about <=10.5
What we do today in Gradle, parsing vm_stat output and using File-backed pages do not work prior to 10.9

I've added OsxMemoryInfo as an experiment to get detailled OSX memory details and tests to demonstrate the deviation from vm_stat values I've been observing.
There are two tests in OsxMemoryTest. The first one exercise native memory info gathering and outputs a CSV with values from both native host_statistics64 and parsing the vm_stat output. The second test does the same repeatedly and indefinitely, and puts the CSVs in /tmp. The latter is @Ignored to not block the build but easy to use and run with various delays to collect some data.
Here is some sample data: https://gist.github.com/eskatos/86ddcac0e6b3e92cb11ca329a4198370

@adammurdoch this should be in a pretty good shape and the calculation is as we discussed it


feat: Add Kubernetes client for applying resources

Add kubernetes client for create/update resource
Add kubernetes client for delete resource

Fixed: https://github.com/numaproj-labs/numaplane/issues/5

I'll add another commit in this PR to call the ApplyResource(...) method from watchRepo() which will apply the resource in cluster.


FR: clicking on a failed test should open the failed test to that line in the editor

Is this a bug report or a feature request?
feature request
Version Info

Version of Majestic: latest
Version of Jest: 25
Version of Node:
Operating System: Windows

Reproduction Repo
When a test fails, Jest is really good at spitting out the line of the assertion that failed. It would be nice if you could click on the div for that failed test and have it open the test file to the line of the failed assertion.
This is a little nicer than the open in editor button in the summary because it will take you directly to the failed assertion without having to eyeball the line number in the failure message and then jumping to that line number. I know that VS Code for instance will open directly to a line number because I have seen other packages do this.

I think I know what to do in order to implement this.
I can use the OPEN_IN_EDITOR mutation as a template. It turns out that VSCode opens a file to the line and column you specify if you specify them as :line_number:column_number after the file name.
The only tricky bit will be extracting the file name from the error text. I think that can happen on the server side code. We can send the failure string to the new mutation rather than the path string. Then the server code can do its magic at extracting the first file it finds from the error string and then launches the editor the same way OPEN_IN_EDITOR does uses the file location string from the error message.
I will work on this once the collabsible UI pr has been merged in because it will conflict with those changes if I do it now.

I have a PR ready to be submitted for this FR. I will submit it when the collapsable ui PR is accepted or rejected.

Anybody who is interested in this feature can use my fork. I have updated my fork to the latest version (1.7.0)

Is there a way from preventing this behavior when highlighting text? I'm often wanting to copy different sections of the error or test or just highlight pieces while thinking and am finding myself constantly being kicked back into vscode unintentionally.

In my case, it opens multiple Vim processes and consumes over 80% of CPU. Is there a way to disable this feature?

Solve this by using cross-env
  ...
  "scripts": {
    ...
    "test:ui": "cross-env EDITOR=code majestic"
  },
  ...
}


Implementation of Transposition Cipher in C language

💥 Proposal
Transposition Cipher is class of symmetric-key ciphers which simply permutes the symbols in a block.
Have you read the Contributing Guidelines on Pull Requests?
YES

I would like to work on this.

@HarshCasper Can you assign me this issue?


Make 2010 interface minimap background the same as it was in 2010

Is your feature request related to a problem? Please describe.
Kind of. The 2010 interface has a lot messed up in the top right corner, but I think this would be the easiest to implement.
Describe the solution you'd like
Here are two images, one from the Runelite 2010 client (top) and one from the game in 2010 (bottom). The background behind the minimap on the Runelite client is these two lizards, whereas the right has a stone gear.
https://i.imgur.com/8WDznyZ.png
https://i.imgur.com/u9l7iwE.png
Describe alternatives you've considered
#5106 is kind of cool, I feel like there's a lot of little tweaks that could make it feel a whole lot better.

So I had a go at this. The 2010 image for the minimap is a different size, and you'll need to move around all the orbs and stuff to make it work too. It's completely beyond my capabilities, and someone else who at least knows what they're doing will have to take a look.

I thought we already have PR for this (e.g it is the hd minimap one)

I think this PR is mostly concerned about the minimap sprite, not the contents of the map itself.


Display uploaded file's version on mouseover in editor

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature (please, look at the "Scope of the project" section in the README.md file)
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 369
What is the new behavior?
When mouse over uploaded file's name in editor, we can see it's version
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I forgot this PR.
I'm wondering why some tests fail, while in my computer everything seems OK.
I think the issue is related with the application's version that is used when running e2e tests.
I'd like to merge this PR before I forget it one second time, could you please help me?

Thanks for the update @anediaz. I am going to review and merge this PR 👍


fix nf4 performance in hybrid CPU

Type of Change
Automatic modify the thread number and disable to run nf4 on E-core when inferencing nf4 model on hybrid CPU.
Quantizing to nf4 model on hybrid CPU will get a warning now.
Description
detail description
Issues: xxx
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed

Please remember to use int4 as default when hybrid

@yuchengliu1 Can you check whether the new thread pool dispatch all jobs to P cores if E cores have poor performance?

f4 performance will be remeasured after #172.

@yuchengliu1 Can you check whether the new thread pool dispatch all jobs to P cores if E cores have poor performance?

Some parallel created with schedule2D do not dispatch, such as parallel of PrologueA and MHA reorder

@yuchengliu1 Can you check whether the new thread pool dispatch all jobs to P cores if E cores have poor performance?

Some parallel created with schedule2D do not dispatch, such as parallel of PrologueA and MHA reorder

@yuchengliu1 Just run benchmark. Focus on GEMM only.


Fix broken import of BaseSettings for pydantic v2

Fix #81
It was indeed an import to change.
https://fastapi.tiangolo.com/advanced/settings/#pydantic-settings

LGTM.
Maybe worth bumping the major number for next release since now it requires pydantic v2.

If this is the case, we can move to Python 3.8 for me to avoid chasing this annoying CI bug.

we can move to Python 3.8

Sure! Python3.7 has reached end-of-life (+ some packages like numpy starts dropping Python3.8...)

Let's do this in another PR. Thanks for the review :+1: !


H70C5 Some effects do not work / appear correctly when selected from effects drop down in Home Assistant

Govee Device SKU
H70C5
Govee2MQTT Version
2024.07.21-c9d27764
Describe the issue
Just setup the lights and most things are working GREAT!..
However I have noticed that some effects when selected in the Home Assistant Effects drop down don't work.. Like Candy Cane will work but Candy Cane B will not.. This happens on a few different effects but not all.
Example of logs given with Candy Cane B which appears all blue instead of the red and white twirl if selected in the govee app
Startup Diagnostics
[2024-11-25T20:45:12 INFO  govee::commands::serve] Starting service. version 2024.07.21-c9d27764
[2024-11-25T20:45:12 INFO  govee::commands::serve] Querying platform API for device list
[2024-11-25T20:45:13 INFO  govee::commands::serve] Querying undocumented API for device + room list
[2024-11-25T20:45:14 INFO  govee::service::iot] Connected to IoT: CONNACK code 0: Connection Accepted.
[2024-11-25T20:45:14 INFO  govee::service::iot] IoT (re)connected with status CONNACK code 0: Connection Accepted.
[2024-11-25T20:45:14 INFO  govee::commands::serve] Starting LAN discovery
[2024-11-25T20:45:14 INFO  govee::commands::serve] Waiting 10 seconds for LAN API discovery
[2024-11-25T20:45:24 INFO  govee::commands::serve] Devices returned from Govee's APIs
[2024-11-25T20:45:24 INFO  govee::commands::serve] Christmas Tree (2B:42:C6:75:66:0E:B3:3E H70C5)
[2024-11-25T20:45:24 INFO  govee::commands::serve]   LAN API: ip=<IP_ADDRESS>
[2024-11-25T20:45:24 INFO  govee::commands::serve]   Platform API: devices.types.light. supports_rgb=true supports_brightness=true
[2024-11-25T20:45:24 INFO  govee::commands::serve]                 color_temp=Some((2000, 9000)) segment_rgb=Some(0..10)
[2024-11-25T20:45:24 INFO  govee::commands::serve]   Undoc: room=Some("Living Room") supports_iot=true ble_only=false
[2024-11-25T20:45:24 INFO  govee::commands::serve]   Quirk { sku: "H70C5", icon: "mdi:light-bulb", supports_rgb: true, supports_brightness: true, color_temp_range: Some((2000, 9000)), avoid_platform_api: false, ble_only: false, lan_api_capable: true, device_type: Light, platform_temperature_sensor_units: None, platform_humidity_sensor_units: None, iot_api_supported: true, show_as_preset_buttons: None }
[2024-11-25T20:45:24 INFO  govee::commands::serve]
[2024-11-25T20:45:24 INFO  govee::service::http] http server addr is <IP_ADDRESS>:8056
[2024-11-25T20:45:46 INFO  govee::service::hass] Wait 180ms for hass to settle on 18 entity configs
[2024-11-25T20:45:46 INFO  govee::service::hass] MQTT connected with status=CONNACK code 0: Connection Accepted.
Additional Logs
[2024-11-25T20:47:34 INFO  govee::service::hass] Command for Christmas Tree (2B:42:C6:75:66:0E:B3:3E H70C5): {"state":"ON","effect":"Candy Cane"}
[2024-11-25T20:47:34 INFO  govee::service::state] Using Platform API to set Christmas Tree (2B:42:C6:75:66:0E:B3:3E H70C5) to scene Candy Cane
[2024-11-25T20:47:35 INFO  govee::platform_api] control_device result: ControlDeviceResponse { request_id: "uuid", code: 200, message: "success", capability: ControlDeviceResponseCapability { kind: DynamicScene, instance: "lightScene", value: Object {"id": Number(14105), "paramId": Number(22752)}, state: Object {"status": String("success")} } }
[2024-11-25T20:47:42 INFO  govee::service::hass] Command for Christmas Tree (2B:42:C6:75:66:0E:B3:3E H70C5): {"state":"ON","effect":"Candy Cane B"}
[2024-11-25T20:47:42 INFO  govee::service::state] Using Platform API to set Christmas Tree (2B:42:C6:75:66:0E:B3:3E H70C5) to scene Candy Cane B
[2024-11-25T20:47:43 INFO  govee::platform_api] control_device result: ControlDeviceResponse { request_id: "uuid", code: 200, message: "success", capability: ControlDeviceResponseCapability { kind: DynamicScene, instance: "lightScene", value: Object {"id": Number(13994), "paramId": Number(22641)}, state: Object {"status": String("success")} } }
Home Assistant Logs
No response
Anything else?
No response

I'm having a similar issue, I think a workaround would be using tap-to-run or snapshots instead.  However neither of those are showing in HA for me - opening a new issue for that.

For tap to run that won't appear Try removing all existing tap to run and add a new simple one, it solves the issue on my side

@bagobones I have a H70C5 too but can't see any effects..
Is there something you've done to have effects ?

@bagobones I have a H70C5 too but can't see any effects.. Is there something you've done to have effects ?

Other than read the documentation and set it up no?

The LAN protocol only works in the same network, and if you have enabled it on the device.. If you have VLANS you might have to jump through some hoops like have  UDP forwarding (not getting into that), or have the govee2mqtt server it self running in the same VLAN as the lights.
I have my govee credentials set so it can query their services.

that is about it.

I finally found effects ! They are not visible on the mqtt dashboard but only when you click on the entity...
I have the same issue , all effects linked to shape mapping are not working :( Most of them are named with a B

Does the latest release make this work any better? There's been some changes to prefer activating scenes via the LAN API with a new technique.

The B effects apparently are related to the light mapping feature and only seem to work from
The primary phone / device that has mapped the tree.
I have my treee shared with my kids and the effect doesn't even appear on their Govee app.?


X button on the top right isn't on screen

The X button on the top right of the browser doesnt show up on the screen in compact mode. When compact mode is disabled even more buttons are gone from the screen

Love this theme!

not sure how but it fixed itself :)

it happens haha


Add issue templates

What does this PR do?

This PR adds issue templates inspired by the ones of Optimum:

bug report
feature request
link to the Hub documentation Github repo
link to the forum

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


remove unused func: valuesToNamedValues

Coverage increased (+0.5%) to 77.711% when pulling c533a367b3f7708377d7924384f044515b894d90 on remove-unused-func into e6dd8dba965c04e07c1c87ad94f58db5c1d795c7 on main.


Ember resources 7

following these instructions I abstracted the class based resources of e-r 6 to those of ember-resource 7.
https://github.com/NullVoxPopuli/ember-resources/issues/1056
It works in the sense that all tests pass

Fixes https://github.com/simonihmig/ember-stargate/issues/686
I had a PR as well but it would not let me submit it.
@simonihmig could we get this workflow run please. This is blocking me from updating ember concurrency V4 as ember-resources 6.x has a peer-dependency on ember-concurrency 3.x

lint issues resolved

uhg. lots of errors suddenly. I don't have time to dive into these atm...

Did some experimentation. The first CI works which appears to be using ember 4.0 (and @types/ember_application 4.0.7). When trying other versions of ember, @types/ember_application 4.0.11 is being used which is where the errors are being generated. Appears to be mis-matched typescript types I guess.    Hoping the little research I did helps, but very new to typescript and this is beyond my ability.

Anyone able to take a look at this? It seems to be a problem of the types dependencies and not actually the code changes.

Sorry atm no time to dive in

Anyone have any chance in the foreseeable future? Have multiple addons that can not be updated as a result of this as addons are moving on to require ember-resources V7.

@simonihmig I've updates some dependencies in the hope we will get a green light. could you rerun the pipeline?

@basz linting fails with some competing ember type definitions, and also in the yarn.lock you can see different versions of type packages being used. I think that could be solved by running npx yarn-deduplicate hopefully!

👍 after some fiddling it run locally. Can't do the matrix somehow... lets see how this goes

There is some new ESLint error due to render-modifiers, probably due to new dependency versions?
But I wonder where did all the @types/ember__* packages go to, don't we need them?

Saw the error. looking into how to avoid using ember-template-modifiers atm
I kept getting conflicts between types coming from @types/ember and @types/ember__*, so i just removed then to if that would resolve the conflicts. It did. All tests run fine except for the ember-template-modifiers. Let's see if I can fix that.

looking into how to avoid using ember-template-modifiers atm

I think we might want to just turn off the rule for now. I think we should migrate those to custom modifiers, but that seems well out of scope for this PR! :)

pretty sure it run green aallll the way now... If you could do a release soon... it's my last unmet peer dependency thank you so much!

Thank you for completing this. Its blocking some updates for me as well.

Thanks again for working on this @basz!
I think the requirement for a new major version of ember-resources, which many apps and addons also directly depend on, needs to be seen as a breaking change, so also require a new "major" from this addon. This is on 0.5, so that would be 0.6 (kinda indicating a breaking change), but that's no big deal.
I would like to also add some other breaking changes, like dropping support for older Ember versions. At this point 4.12 to start with seems reasonable? Or does anyone of you here have concerns with that? @basz @cah-brian-gantzler
(btw, it's not that we actively prevent those versions from working, just removing from the test matrix and not committing for support anymore)

I am fine with all that. I agree with the breaking change. Technically any change to a 0.x is considered a possible breaking change. It is not until 1.x that changes to x should not be a breaking change.

sounds good to me.

hi @simonihmig
What are the other BC you propose and can we help with those?

Just dropping support for older Ember versions I think. Quickly raised this, if you want to have a look: #696

Released as v0.6.0: https://github.com/simonihmig/ember-stargate/releases/tag/v0.6.0

Thank you!


there are no arrow symbols to represent while selecting the year from showYearDropDown property.

Describe the bug
while using the showYearDropDown property there are no up or down arrow symbols to click
To Reproduce

Expected behavior
To get those arrow symbols for convenience
Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: Version 102.0.5005.115 (Official Build) (64-bit)

Having the same issue here. Is there a prop we need to change to display these?

I'm having the same issue. There are previous tickets for this https://github.com/Hacker0x01/react-datepicker/issues/3113 https://github.com/Hacker0x01/react-datepicker/issues/3028 but the css fixes don't work because the classes seem to have changed since?

same issue , does anyone resolved it

Hi, here are some styles for a quick workaround :
.react-datepicker__navigation--years::before {
  border-color: #666;
  border-style: solid;
  border-width: 3px 3px 0 0;
  content: '';
  display: block;
  height: 9px;
  left: 11px;
  position: absolute;
  width: 9px;
}

.react-datepicker__navigation--years-upcoming::before {
  top: 17px;
  transform: rotate(315deg);
}

.react-datepicker__navigation--years-previous::before {
  top: 6px;
  transform: rotate(135deg);
}

(tested on v4.8.0)

Same here...

Hi, here are some styles for a quick workaround :
.react-datepicker__navigation--years::before {
  border-color: #666;
  border-style: solid;
  border-width: 3px 3px 0 0;
  content: '';
  display: block;
  height: 9px;
  left: 11px;
  position: absolute;
  width: 9px;
}

.react-datepicker__navigation--years-upcoming::before {
  top: 17px;
  transform: rotate(315deg);
}

.react-datepicker__navigation--years-previous::before {
  top: 6px;
  transform: rotate(135deg);
}

(tested on v4.8.0)

It works for me. Thanks


Change name from U32<2> to u64?

Our u64 support is made by stringing two u32 values together and we call this construction U32s<2> after a convention in twenty-first. But maybe u64 would be a more descriptive and familiar name?

Fixed in a9c652334e9084d2692d896fb544b8c2465e640a.


SFML doesn't clarify the guarantee or lack thereof for random bits when creating render-textures / textures

SFML doesn't clarify the guarantee or lack thereof for random bits when creating render-textures/textures
Whenever you create a render texture or a texture, SFML currently does not guarantee that the underlying texture is completely empty. What I have noticed is that the 3 different major GPU manufacturers may have different results when simply creating a new render texture or texture.
Intel Arc will not clear the GPU of old data, and therein require the user to do a clear before manipulating the texture.
Nvidea/AMD will automatically clear the old data on the render texture/texture.
Your environment

Arch Linux
2.6.0
GCC 13.1.1

Steps to reproduce
Might be a bit expensive to go and get 3 GPUs from all of the different manufacturers to test it, but you'd essentially test it with code that makes a new render-texture for each frame without calling clear (forcing the chance of random bits to show up raised) and draw the same thing that render-texture. It might also be good to have this thing you are drawing onto the screen move around. Do it with all three manufacturers, and see the result.
Expected behavior
All GPUs have the same behavior OR documentation stating that render-texture / texture creation is not guaranteed to have cleared the old bits of data still on VRAM.
Actual behavior
Different manufacturers have different behavior AND documentation does not state that this is a potential problem.

I've added the following in #2994, is that sufficient @dogunbound?

After creation, the contents of the render-texture is undefined, call RenderTexture::clear first to ensure a single color fill

Closed by https://github.com/SFML/SFML/pull/2994


Test name deduplication and character filtering

This builds on the work of #59 , and resolves #59, #3, #22

Coverage remained the same at 100.0% when pulling 996e7f9dd654318e81185d709e37b4d77d1d1b5e on name-filtering into e4085a7396ac161c8ed41bc06927e303f61f7c92 on master.


Same behavior when selecting a scene and selecting a script

Description
If you have GDScript and you have script attached to the root node and you select that scene then the script will be selected if you are in the script editor. It would be benificial if the same behavior is in Orchestrator.
Implementation ideas
No response

Hi @GhostNr1, so if I understand, you have a .gd script attached to the root scene node, and when selecting that scene the script is selected if within the script editor.  I tested this on 4.3.dev4 and v4.2.1-stable, and I don't see this behavior.
If you click the Script icon on a scene node, the script opens in the script editor if it's a .gd script.  This works with Orchestrator, too, but if you're using any 4.3 dev build before 4.3.dev4, this behavior was broken due to a change in the editor that caused a regression. This should work just fine on Godot 4.3.dev4 or later.
If you're referring to something else, if you could elaborate on the steps a bit more, that'd help.

https://github.com/Vahera/godot-orchestrator/assets/9337875/66e7cb42-caea-4759-9a69-a993c215746b
Here is a video what is happening in gdscript and what is not happening in orchestrator. I would like to have the same behavior.

OK, I think that's reason 👍


Add a curve editor to the Inspector

Add a curve editor to the Inspector in the same way the particle editor was recently added.
The goal of the animation curve editor is to be able to edit/create animation for any object from the scene explorer. So if a node already has animations we should be able to edit/delete them and if there is no a simple right click should give us the opportunity to create one
The idea is to have it as a floating window (more like the node material editor) as there will be not enough room for it inside the inspector panel.
Part of this work is to also add a “Animations” UI when you select a node to be able to see the list of animations when selecting a node (as part of its properties)

Consolidating this issue in Inspector vNext Issue

Splitted back issue as we are getting closer to release.


Rename PEM (props,events, methods) to use KernelConnectionMetadata instead of kernel or kernelspec

Purpose of change is to ensure we speak the same language, and avoid confusions..
Do we change this across the board?
Doesn't make sense, as in some cases when we're swithing a kernel, even though we're passing in a kernel connection metadata, we are actually changing a kernel.
Similarly when selecting a kernel, we are really selecting a kernel, however the return value of the kernel selection is the information used to start a kernel.
There are two objects here:
kernel = an instance of an execution environment
kernel connection metadata = information used to create an instance of a kernel
Issue to discuss how we name our PEMs based on this...
@rchiodo @IanMatthewHuff @DavidKutu @joyceerhl /cc

Done


Hidden 10x zoom option

In the original there is a fifth zoom option: 10x, but it's partially hidden, and there is only a small strip of pixels you can click on to select it.
This is about XP paint, but it applies to 98 as well:
https://serenesforest.net/forums/index.php?/topic/25132-10x-zoom-in-mspaint/
It's not that important, but it's a neat easter egg for people who know paint thoroughly.

I regularly used 10x.


Query based pagination

Description

Queries records with

A page limit
Cursor (lastEvaluatedKey)
Replaces ascending and descending with Direction enum to sort the query results
Rename order to orderBy

Cursor tells the last processed item and this will be varied based on applied filters.
Masks the cursor to hide the actual db implementation details (partition key and range key).
Uses crypto-js to encrypt and decrypt the cursor.
Example:
const dynamoHelper = new DynamoHelper({...tableConf, cursorSecret: 'somesecret'}, region, endpoint);
const result = await dynamoHelper.queryWithCursor({
        where: {
          pk: 'partition_key',
          sk: 'sort_key',
        },
        limit: 10,
        prevCursor,
        orderBy: Direction.DESC
});

Related Issues

Issue: #XXX
How Has This Been Tested

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Screenshots (if appropriate)

Looks fine.
Did we try integration tests?
Can we provide more information in Readme about How Dyanamo does pagination?
More curious to know about the relation between number of documents and size of one chunk retrieved as part of request using cursor

Added some examples and reference links from AWS DynamoDB 🦥

@lakshmaji
Why is encryption needed?
Using prevCursor simply is not enough?

@lakshmaji
Why is encryption needed?
Using prevCursor simply is not enough?

Batteries included 😄  , we can remove it.
reasons to include it

[x] The consumer doesnt need the actual implementation details about the LastEvaluatedKey
[x] AWS DynamoDB suggests not to expose the partition/ range key details to client facing interfaces!
[x] Greedy 🐹   - the return type can be a simple sting (which takes care of above two notes) instead of retuning raw json / object


UI: Hide section divider when all OAuth providers are disabled

Description
Currently, when all OAuth providers are disabled, the authentication page still displays the section divider below the login form.
This PR addresses this issue by ensuring the section divider is only rendered when at least one OAuth provider is enabled.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[X] Trivial

Screenshots (if appropriate):
Before

After

How Has This Been Tested?

Verified that when at least one OAuth provider is enabled, both the section divider and the OAuth provider sign-in options are rendered correctly.
Verified that when all OAuth providers are disabled, the section divider is no longer displayed.

@blueorangutan ui

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9966 (QA-JID-484)


fixes from initial ubuntu based deploy.

PR fixes missing check around handling of self-signed cert.

retest

retest


Functional regex for getting image url list (MeituriRipper)

Also change website regex like I mentioned in a comment in #1360
Category
This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[x] a bug fix (Fix #...)
[ ] a new Ripper
[ ] a refactoring
[ ] a style change/fix
[ ] a new feature

Description
On some pages number of images that I gathered from the page, that I needed to generate image links were displayed on 2nd row instead of 3rd. My method of getting number of images were ugly and looked at the 3rd row all the time regardless of what's there. This new method actually looks for the info I need (number of images) using regex and not arbitrary places on the page hoping for the info I need.
I've also changed the website regex a tiny bit as I mentioned in my comment in #1360.
Testing
Required verification:

[x] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[x] I've verified that this change works as intended.

[x] Downloads all relevant content.
[x] Downloads content from multiple pages (as necessary or appropriate).
[x] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.

[x] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[x] I've added a unit test to cover my change.

Sorry this took so long to get to.

It's quite alright. I just thought it could have been overlooked because of CI checks. Thank you for maintaining this project.


Enable support for toml.version

Sometimes it can be useful to reference what version of toml one is using, especially as the spec continues to change.
>>> import toml
>>> print(toml.__version__)
'0.9.2'

Hi Marcus,
Thanks for the PR.
Do you think making it easy to reference the relevant version of the spec as toml.__spec__ would also be useful? Currently, the information is in the README.

The thought did occur to me, and I would agree. Adding it now.


Implemented - delete event, my OrganizedEventsActivity and share qr code (does not open app yet when scanned)

Implemented - delete event, my OrganizedEventsActivity and share qr code (does not open app yet when scanned)

Everything is working fine.


Aspect ratio dnn_mmod_ex issue

I keep seeing this error when I try to run the mmod cnn on my dataset: Encountered a truth rectangle with a width and height of 22 and 22. The image pyramid and sliding window can't output a rectangle of this shape.  This is because the rectangle's aspect ratio is too different from the detection window, which has a width and height of 15 and 57.
If I change the mmod_options parameter the numbers change but the issue persist. I already used cropper.set_randomly_flip(false); to stop flipping but to no use.

Maybe you shouldn't rotate the image?  I don't know, but I'm not sure how I can explain the problem in clearer english than what I wrote in the error message.

How am I rotating the image? I set max degree on the cropper to 0 and random flip to false

Oh, you didn't mention changing the max rotation degree.  In that case, you
must have a square box in your dataset.

the objects I am trying to recognise are rectangular, think like bottles.
Will I be able to still detect them if I expand the bbox on training.xml to
be squared?
Il giorno dom 6 nov 2016 alle ore 19:57 Davis E. King <
<EMAIL_ADDRESS>ha scritto:

Oh, you didn't mention changing the max rotation degree. In that case, you
must have a square box in your dataset.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/davisking/dlib/issues/317#issuecomment-258676278, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AN_wJrRd0rJgpv94kRQ46rMbnF5ZWLRXks5q7cDDgaJpZM4Kqfyt
.

Probably, but that isn't the issue.  The error is telling you that you have
a box in your training dataset that has a very different aspect ratio from
all the others.  Since, in your case, the detector slides a tall and skinny
box over the images to find things it can't ever match a perfectly square
box.  That's what the error is saying.

Ok I understand, so probably I was not precise enough when using imagelab.
I will write a script to force all the bboxes to have the same aspect ratio
and see how it goes.
Il giorno dom 6 nov 2016 alle ore 21:20 Davis E. King <
<EMAIL_ADDRESS>ha scritto:

Probably, but that isn't the issue. The error is telling you that you have
a box in your training dataset that has a very different aspect ratio from
all the others. Since, in your case, the detector slides a tall and skinny
box over the images to find things it can't ever match a perfectly square
box. That's what the error is saying.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/davisking/dlib/issues/317#issuecomment-258680465, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AN_wJj4iP5PfYKm_1Vu7J8GdGhPF7iPGks5q7dQggaJpZM4Kqfyt
.

That's probably the issue.  I'll update mmod to support multiple aspect
ratios in the near future.  But for now you have to be careful that your
data is uniform in this way.

OK I re-did the labeling in imagelab skipping the more skewed objects. I do not see the error anymore, which is good. However, now I see an error saying that some truth rectangles are too close to the edges of the image to be recognized.
Now, I think my rectangles are reasonably distant from the borders, and I would like to recognize objects that are not in the center as well. Maybe it is possible to pad the image before feeding it to the network?

Objects don't need to be in the center.  Basically, the center of the
object needs to be inside the image.  But you can certainly pad the image
boundaries if you want.

If that's the case, I should not get that error? I labeled the objects
manually with image lab and definitely all the objects are fully inside of
the picture...what's going wrong here?
On Mon, 7 Nov 2016 at 8:11 AM, Davis E. King<EMAIL_ADDRESS>wrote:

Objects don't need to be in the center. Basically, the center of the
object needs to be inside the image. But you can certainly pad the image
boundaries if you want.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/davisking/dlib/issues/317#issuecomment-258722433, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AN_wJqrL4JJwtz6RMNOxCmDQughTaO_Sks5q7my4gaJpZM4Kqfyt
.

It depends somewhat on the network architecture you pick.  Don't worry
about it.  Just pad your images a little.

Ok thanks!! Can do pad through slob directly? Otherwise I will use opencv or something similar.
Thanks again for your help!

It can certainly be done with dlib in a variety of ways.  Like assigning to
a sub_image.  I would use whatever method you are most comfortable with.

@davisking

In that case, you must have a square box in your dataset.
Square annotation you mean? All the annotated objects need to be rectangle ?

All the annotations need to have more or less the same aspect ratio, whatever it may be.  This is because this is a sliding window detector with just one sliding window.   So it's impossible for it to detect things with widely varying aspect ratios.  I'll upgrade it in the near future to use multiple windows which will allow arbitrary aspect ratio mixtures.  But right now this is how it is.


updated contributors list

updated contributors list after PR #843

sorry @kalpitf1, I've just noticed I hadn't merged this PR! Thanks again for your contribution.


feat: add new sample

Volt React Dashboard-FSD
It features over 100 UI elements, plugins, and example-based built with React components.

@illright Hi,
Many thanks for your response.
I will change the structure to follow the rules shortly!
Just wanted to know, If I remove the entities layer or rename it to something like presentation would that be OK?

I wouldn't recommend renaming entities to presentation because FSD layer names are standardized.
This project is a very unusual case, something that I haven't seen other people build with FSD. Usually people use FSD to build websites that are intended for regular people, not other developers.
I would suggest to put everything in Widgets and Pages, maybe with a little bit of Shared, because the business domain in this application is very small, not substantial enough for layers Entities and Features.

I wouldn't recommend renaming entities to presentation because FSD layer names are standardized.
This project is a very unusual case, something that I haven't seen other people build with FSD. Usually people use FSD to build websites that are intended for regular people, not other developers.
I would suggest to put everything in Widgets and Pages, maybe with a little bit of Shared, because the business domain in this application is very small, not substantial enough for layers Entities and Features.

Is there any chance to add this project to the FSD examples in the community?

Of course, but only after all the structural FSD issues are resolved.
Currently, I still don't see the division to slices and segments, only layers with files inside of them. Let me know if any FSD concepts are unclear

Of course, but only after all the structural FSD issues are resolved.
Currently, I still don't see the division to slices and segments, only layers with files inside of them. Let me know if any FSD concepts are unclear

Slices and Segments are now implemented please take a look https://github.com/paghar/volt-react-FSD/
as there is no API in this example and it is only presentation oriented, there is only on UI segment available. please let me know if there are more stuff to fix, Thank you.


Bring back the default folder restoring

Codecov Report

Merging #1088 into master will decrease coverage by 0.46%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
- Coverage    93.2%   92.74%   -0.47%
==========================================
  Files          39       39
  Lines        4268     4339      +71
  Branches      467      740     +273
==========================================
+ Hits         3978     4024      +46
- Misses        290      294       +4
- Partials        0       21      +21

Impacted Files
Coverage Δ

browser/pages/location/controller.js
92.2% <100%> (-3.85%)
:arrow_down:

browser/model/devstudio-autoinstall.js
97.29% <0%> (-2.71%)
:arrow_down:

browser/model/helpers/hash.js
85.29% <0%> (-2.59%)
:arrow_down:

browser/pages/install/controller.js
79.85% <0%> (-1.73%)
:arrow_down:

browser/model/helpers/downloader.js
96.13% <0%> (-1.66%)
:arrow_down:

browser/main.js
95.58% <0%> (-1.39%)
:arrow_down:

browser/pages/account/controller.js
82.11% <0%> (-1.33%)
:arrow_down:

browser/model/jbossfusekaraf.js
95.09% <0%> (-0.83%)
:arrow_down:

browser/services/data.js
91.5% <0%> (-0.79%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b5ea4b...0196880. Read the comment docs.


A "name" property assigned in the bean constructor

Hey @jacobrosenthal, @sandeepmistry had originally suggested that we make this change to ble-bean.
It's a more convenient accessor for the Bean's name.
thoughts?

No thoughts really. Seems fine.

Why dont we use a gitter https://gitter.im/jacobrosenthal/ble-bean

Hey @jacobrosenthal, any thoughts on merging this PR in?


Draw line if a frame is cropped by the renderer

Lik in osirix.
Just need to pass the canvas dimensions as uniform and use gl_FragColor.
// Screen size
uniform float screenWidth;
uniform float screenHeight;

...

// Converting (x,y,z) to range [0,1]
float x = gl_FragCoord.x/screenWidth;
float y = gl_FragCoord.y/screenHeight;
float z = gl_FragCoord.z; // Already in range [0,1]

WIP:

Closed by ami 0.0.15 - see viewers_upload and xtk_lesson13


Service activity_manager.add_activity not found.

After installing and hard-refreshing browser + restarting HA, it gives the error: "Service activity_manager.add_activity not found." when trying to add an item to a list.
Here is my (the default) setup in a manual card:
type: custom:activity-manager-card header: Home category: Hjem mode: manage icon: mdi:account-group
What could the issue be?

I have the same issue. Did you find the solution to this Jesper? Thanks!


About the bugs

Hi,
Thank you for your great work, I just read your PhD thesis. And when I ran your code, I faced the bug in the code:
from torchpruner import (Pruner, ShapleyAttributionMetric), can't import Pruner, can you have a look?
Thank you so much.
Best.

hi, have u solved this issue? I got the bug same with u

Oh, sorry, I didn't solve the bug.... :(

change into this:
from torchpruner.attributions import ShapleyAttributionMetric
from torchpruner.pruner import Pruner


UI: Teams hierarchy is not working as expected in Signup and Add User pages

Affected module
Does it impact the UI, backend or Ingestion Framework?
UI
Describe the bug
The dropdown box to select teams does not show team hierarchy as expected in the Signup and Add User pages.
The UI component uses the following Elastic search API to build the team hierarchy tree:
http://localhost:8585/api/v1/search/query?index=team_search_index&q=*&from=0&size=100&sort_field=name.keyword&sort_order=asc

The response of this API call is missing the "parents" field and hence the UI is unable to build the hierarchy.
To Reproduce
Create a bunch of teams with hierarchy (Business Unit -> Division -> Department -> Group). Go to "Add User" page as an admin user. Select the teams from the dropdown box.
Expected behavior
A hierarchy of teams is displayed.


feat(test): Add many test, Increase Coverage, Improve UnitTest

Coverage increased (+5.8%) to 79.253% when pulling f21ec1336bfe309e5a141a54023e55ccc5190ce1 on dev-unit-testing into c27dd3b8bed74548631afad464488a277da56037 on dev-master.


Configuration of integration (the entry itself) should be possible after adding an entry

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
Currently changing values in the configuration of an entry needs re-adding the entry
Describe the solution you'd like
Implement an OptionsFlow:
https://developers.home-assistant.io/docs/config_entries_options_flow_handler
Describe alternatives you've considered
n/a
Additional context
n/a

:tada: This issue has been resolved in version 0.3.0-dev.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix zxcvbn-hs & zxcvbn-dvorak

Motivation for this change
The zxcvbn-hs and zxcvbn-dvorak packages work fine, so I unmarked them as broken.
> nix-build --no-out-link -A haskellPackages.zxcvbn-dvorak --arg config '{ allowBroken = true; }'
/nix/store/nfkq4fdszd7xd060rkiwvkajbgdj36d9-zxcvbn-dvorak-<IP_ADDRESS>

> nix-build --no-out-link -A haskellPackages.zxcvbn-hs --arg config '{ allowBroken = true; }'
/nix/store/cwxs6z1kj48jrkn7nf4rik59vxb6wfvz-zxcvbn-hs-<IP_ADDRESS>

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Looks good to me!
Both these packages compile on my machine.


Update diagrams

Update Linux API fault diagrams

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://669103ce8bbb0b153e4f32b0--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6691052985e71a0fcfcb45c4--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6694be408d894f2fc8457c2f--harness-developer.netlify.app


[CHEC-915]  Modify textfield to have currency type

Added a currency prop that shows a dollar sign before the input. Value will still be unaffected. Down the line, we could make it so the symbol is definable programmatically but for now, I have included it as a prop.

Is there a reason you chose to extend the TextField component rather than create a new CurrencyField wrapper around it? Ultimately it doesn't really matter, but I'd like to avoid bloating our existing components where possible. Note that we did extend TextField for the PasswordField rather than adding to TextField (although the initial PR for it did what you've done here as well, and I moaned about it then too)

I extended it because that's what the linear task requested.

Okay, maybe we need to more explicit in our tasks in future, because the title is "Add a currency component"

I didn't really intend the description of the Linear task to be taken too literally there. But ultimately I think it would've been more trouble to wrap the text field component anyway.

Also, I think you may have missed my comment about the text colour in dark mode.

Also, I think you may have missed my comment about the text colour in dark mode.

Completely missed it! I've updated accordingly.


Settings: gray out decoration comes too late

Refs: #31448

Multi root workspace, open folder settings
Add some forbiden setting like workbench.colorTheme, notice that it does not get greyed out. So now me as a user am puzzled why it is not being applied
If i press enter it gets greyed out or if I open the file again

I think you should update all decorations on every save event in the settings file

Duplicate of #31558


Crash when building locally

While running the following command
docc preview TSPL.docc
The application crashes with the following output
Input: /home/XXX/Desktop/swift-book/TSPL.docc
Template: /home/XXX/Development/swift/usr/share/docc/render

💣 Program crashed: Illegal instruction at 0x000055c67291b1b6

Thread 0 "docc" crashed:

0 DefaultDiagnosticConsoleFormatter.highlightSource(sourceLine:lineNumber:range:) + 342 in docc at /home/build-user/swift-docc/Sources/SwiftDocC/Infrastructure/Diagnostics/DiagnosticConsoleWriter.swift:450:41

zsh: illegal hardware instruction  docc preview TSPL.docc

Swift Info
Swift version 5.9-dev (LLVM df22cff92bb6f9d, Swift fdf50a99df2d1b0) Target: x86_64-unknown-linux-gnu /home/genaro/Development/swift/usr/bin/swift-help intro

Looks like a dupe of https://github.com/apple/swift-docc/issues/678

Moving this to the DocC repository, since it was docc that crashed.
@Genaro-Chris Do you know which version of DocC you were running?  It looks like you were building from source?

You should be able to work around the issue by passing --ide-console-output as one of the flags to docc convert

Thanks


make the sdk wasm32-wasi compatible

Currently the azure-core has a dependency on reqwest, which is depended on wasm-bindgen. This package can only be used to compile to wasm32-unknown-unknown target, used in browser.
However, this prevent the crate to be compatible to wasm32-wasi target.
Could we make the dependency on reqwest an optional feature?

Yes, we'll accept pull requests to make it truly optional. It is already marked as optional in azure_core:
https://github.com/Azure/azure-sdk-for-rust/blob/66db4b485ce56b68be148708d9c810960a50be51/sdk/core/Cargo.toml#L28-L30

#755 is in draft to fix this.

Huge thanks!

I think #939 completed this.


Camera Downlink Technical Spec Doc

https://docs.google.com/document/d/1O_uyFYRoTfsBoz4jR5eeO_4pCL8ecVKAjCBUv572fng/edit?usp=sharing

Put this in the google drive (here and this looks good to me.

Moved it to the google drive, should I close?


Which version of

I was looking at your slides at https://www.blackhat.com/docs/us-17/thursday/us-17-Tsai-A-New-Era-Of-SSRF-Exploiting-URL-Parser-In-Trending-Programming-Languages.pdf
I was trying to reproduce the bug in php where parse_url parses out google.com but readfile fetches evil.com in the url<EMAIL_ADDRESS>but I wasn't able to do so.
I was using code similar to the one you posted on slide 25 of the pdf, on docker images from https://hub.docker.com/_/php: 5.3-cli, 5.4-cli, 5.5-cli, 5.6-cli, 7.0-cli, 7.2-cli, 7.3-cli. None of those seem vulnerable to this bug.
Which version of php was this bug found in?
Thanks!

Please see https://3v4l.org/nr1Ae

Thanks for your quick reply! That's a really useful site too.
That link shows that the parsing is inconsistent across the versions, but I think the bug is worse if there is inconsistency between parse_url and readfile within the same version of php, as you pointed out in your talk.
Was trying to use 3v4l.org to identify the difference in version but I think 3v4l.org doesn't allow accesses to other websites.
Did you manage to find a single version in which readfile and parse_url behave differently on a single URL?


search clippy lints

clippy lints
This site has anchors,so searching would work.

Thanks for the suggestion. I don't know in what case do people need search clippy hints? Could you please give an example?

When using intellij-rust and Clippy as linter,the intellij-rust will show clippy lints for non-perfect code.People can use rust-search-extension search the detailed infomation about it.

Sounds good. It could be in the next development plan.

Hey @songzhi. Version 0.9.0 with Clippy lint searching is released!  😄


[CIRCLE CI] Intermittent ERROR: Account key is not valid, can not continue failure.

During test_concurrent_requests
Running on http://<IP_ADDRESS>:8080/ (Press CTRL+C to quit)
ERROR: Account key is not valid, can not continue.
<IP_ADDRESS> - - [02/Mar/2017 20:50:32] "POST /certificate HTTP/1.1" 500 -
Transaction started [transaction13671.yaml].
Record addition appended to transaction at [transaction13671.yaml].
Executed transaction [transaction13671.yaml] for managed-zone [le-zone-test].
Created [https://www.googleapis.com/dns/v1/projects/plotly-connector-tests/managedZones/le-zone-test/changes/462].
Transaction started [transaction20485.yaml].
Record removal appended to transaction at [transaction20485.yaml].
Executed transaction [transaction20485.yaml] for managed-zone [le-zone-test].
Created [https://www.googleapis.com/dns/v1/projects/plotly-connector-tests/managedZones/le-zone-test/changes/463].
<IP_ADDRESS> - - [02/Mar/2017 20:51:54] "POST /certificate HTTP/1.1" 201 -
[<Response [500]>, <Response [201]>]
F

The issue might be linked to the requirement to read the account id by letsencrypt.sh. If two concurrent requests come in, the accounts file is trying to be accessed by two different processes. Might want to look into using randomly names account directories.


[FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable

What is the purpose of the change
Currently, below are the ways Python Worker gets the Python Flink Dependencies.

Worker Node's System Python Path (/usr/local/lib64/python3.7/site-packages)
Client passes the python Dependencies through -pyfs and --pyarch which is localised into PYTHONPATH of Python Worker.
Client passes the requirements through -requirement.txt which gets installed on Worker Node and added into PYTHONPATH of Python Worker.

This change allow PYTHONPATH of Python Worker configurable where Admin/Service provider can install the required python Flink dependencies on a custom path (/usr/lib/pyflink/lib/python3.7/site-packages) on all Worker Nodes and then set the path in the client machine configuration flink-conf.yaml. This way it works without any configurations from the Application Users and also without affecting any other components dependent on System Python Path.
Brief change log
Todo
Verifying this change
Todo
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no) no
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
The serializers: (yes / no / don't know) no
The runtime per-record code paths (performance sensitive): (yes / no / don't know) don't know
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
The S3 file system connector: (yes / no / don't know) no

Documentation

Does this pull request introduce a new feature? (yes / no) no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) N/A

@flinkbot run azure

@HuangXingBo
Please review this small change in free time .

@flinkbot run azure

Test failure associated ticket https://issues.apache.org/jira/browse/FLINK-31120


fix(DEVSITE-600): frame no longer supported relative paths

Fixes issue where Frame component no longer supported relative pathnames like /include.html.
Description
Since this change: https://github.com/adobe/aio-theme/pull/833/files#diff-e7e3bc67be10b26102ec899e870d38cde494b9618cda1c96edb9e5d508364410R56 , the frame component crashed when used with a pathname like /include.html instead of https://complete.path.to/include.html.
Related Issue
https://jira.corp.adobe.com/browse/DEVSITE-600
Motivation and Context
Bug report following https://cq-dev.slack.com/archives/C01GU3V8XE0/p1668099022338219
How Has This Been Tested?
Tested with the repository where the bug was discovered: https://github.com/AdobeDocs/commerce-webapi/pull/55/files now works as intended on the page /graphql/reference/
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

cc @dmitrymatio as Tim is on PTO currently


Updating a Tag doesn't update the Modules

To reproduce:
a) create a engine with one tag.
b) add 2 CVT modules.
c) In both modules, add the the tag as write to CVT.
d) rename the tag
e) Click 1 of the modules
f) Go to mappings
After this one of the mappings will be mapped to the correct channel the other will be mapped to the old channel. If the file is saved in this state there will be issues at run time.

Refresh All added in most recent commit, and refresh added as a core override. This will still need to be overridden in individual modules.


Add example to demonstrate different file operations

Add code example let say file_handling.go which demonstrates following:

File creation
Reading file content
Updating file content
Deleting file

Do all these operations over text file
Refer Hello World for reference
https://golang.org/pkg/os/

@sagar-jadhav let me work on this
\


benefits of osascript.py over using subprocess module

First of all, thanks for sharing your work. I browsed through osascript, which leverages runcmd (thank you again for sharing) which in turn uses subprocess.
Now, I am not a Python expert and have struggled with sending multiline scripts to osascript, and things became even more complicated when I wanted to inject a javascript into the front tab open in Safari.
It appears to me that your osascript module can be helpful and therefore I wanted to understand as to why you created osascript.py and runcmd.py as opposed to using subprocess each time. Do share if you can, and if you think others might find it helpful, may be add your reasoning to the README file for others like me.
Thank you!

hi. i don't use it :) just experiments with python projects. i'm not python expert too :)


Fix memory hole while uploading 5G chunks

The call read(MAX_FILE_SIZE) will load the hole MAX_FILE_SIZE into
memory, which turns to be 5GB. That puts the system to a crawl.
Instead, the better way to go around this is to use streaming, copying
small chunks of memory in a loop until all bytes are transferred.
Python provides shutil.copyfileobj that saves you even writting the loop
explicitly.
Apart from that:

xreadlines has been deperectaed for quite a while now:
https://www.quantifiedcode.com/knowledge-base/maintainability/`.xreadlines()` deprecated/7lC2NACa
Tox was not able to run pypy test env properly without the explicit
dependencies on requests and nose.

Coverage increased (+0.03%) to 96.704% when pulling b0356be1846244436a4f15c509fb696ce4b45891 on josvazg:fix/stream_copy into e7d729f435adf8cae8f2bae48d04b00f910cdcd1 on rackspace:working.

Coverage increased (+0.04%) to 96.709% when pulling 8c9dc3e73878c649d35b2be5eb608693b4d867ae on josvazg:fix/stream_copy into e7d729f435adf8cae8f2bae48d04b00f910cdcd1 on rackspace:working.

Coverage increased (+0.04%) to 96.709% when pulling 8c9dc3e73878c649d35b2be5eb608693b4d867ae on josvazg:fix/stream_copy into e7d729f435adf8cae8f2bae48d04b00f910cdcd1 on rackspace:working.

Coverage increased (+0.04%) to 96.709% when pulling 6f797f547cf8087fbca15f786fdc00c25402f20b on josvazg:fix/stream_copy into e7d729f435adf8cae8f2bae48d04b00f910cdcd1 on rackspace:working.

Coverage increased (+0.04%) to 96.709% when pulling 4909b33f92d33a5e62f70998d374945daa48557f on josvazg:fix/stream_copy into e7d729f435adf8cae8f2bae48d04b00f910cdcd1 on rackspace:working.

We're currently phasing out Pyrax in favor of openstacksdk/rackspacesdk and are not currently accepting changes like this.


Remove unused usings

We had an awful lot of these.
@AndyGerlicher if you're more worried about churn we can table this.  It shouldn't really be hurting anything.

Uhg, I like this but agree it might be better to hold off. Does this take into account #ifs?
And this should really be a feature of CodeFormatter!

I used Resharper and would NOT be surprised if it only considered the current branch of #ifs.
Agreed that it would be great if CodeFormatter did this!
Since we're both worried let's just wait.  Maybe when we're unified and shipping only the open-source version we can make the change with higher confidence.


Research if there is a better alternative for Storybook

Cons:

It's hard to maintain

Breaks to often

After every update, it breaks

I think we're in a good place with Storybook now. But it couldn't hurt.


Issue with Colours

I have found that the Plum colour (#75507b) does not actually taste like plum when licking the monitor. I have tried multiple monitors and I can confirm it is not a hardware issue. It must be a problem with the code.
Please fix ASAP.
Regards,
Jake

Hi Jake,
The names of the colours were chosen by the Tango Project (and may not reflect their taste), please could you confirm if the other colours taste the same?
You may find this video helpful.
Regards,
David


Uncaught Error: ENOENT: no such file or directory, lstat '/Users/PJoshi/Documents/Projects/websit...

[Enter steps to reproduce below:]

...
...

Atom Version: 1.8.0
System: Mac OS X 10.11.5
Thrown From: fuzzy-finder package, v1.0.5
Stack Trace
Uncaught Error: ENOENT: no such file or directory, lstat '/Users/PJoshi/Documents/Projects/website-sample1'
At ATOM_SHELL_ASAR.js:0

Error: ENOENT: no such file or directory, lstat '/Users/PJoshi/Documents/Projects/website-sample1'
    at Error (native)
    at fs.lstatSync (fs.js:887:18)
    at Object.fs.lstatSync (ATOM_SHELL_ASAR.js:229:16)
    at Object.realpathSync (fs.js:1532:21)
    at Object.fs.realpathSync (ATOM_SHELL_ASAR.js:304:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/fuzzy-finder/lib/path-loader.js:19:21
    at Array.map (native)
    at Object.module.exports.startTask (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/fuzzy-finder/lib/path-loader.js:17:46)
    at ProjectView.module.exports.ProjectView.runLoadPathsTask (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/fuzzy-finder/lib/project-view.js:190:46)
    at ProjectView.module.exports.ProjectView.populate (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/fuzzy-finder/lib/project-view.js:111:21)
    at ProjectView.module.exports.ProjectView.toggle (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/fuzzy-finder/lib/project-view.js:87:14)
    at atom-workspace.atom.commands.add.fuzzy-finder:toggle-file-finder (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/fuzzy-finder/lib/main.js:9:46)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:580:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:388:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:98:36)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61)

Commands
 10x -1:22.2.0 core:backspace (atom-text-editor.editor.is-focused)
     -1:18.5.0 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -1:18.5.0 snippets:expand (atom-text-editor.editor.is-focused)
     -1:18.5.0 editor:indent (atom-text-editor.editor.is-focused)
  7x -1:18 core:backspace (atom-text-editor.editor.is-focused)
     -1:09.4.0 core:move-right (atom-text-editor.editor.is-focused)
     -1:07.7.0 editor:newline (atom-text-editor.editor.is-focused)
     -1:03.6.0 core:move-up (atom-text-editor.editor.is-focused)
     -1:03.3.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
     -1:02.9.0 editor:newline (atom-text-editor.editor.is-focused)
     -0:48.6.0 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -0:48.6.0 snippets:expand (atom-text-editor.editor.is-focused)
     -0:48.6.0 editor:indent (atom-text-editor.editor.is-focused)
 10x -0:47.6.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:45.6.0 core:save (atom-text-editor.editor.is-focused)
     -0:05.6.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.is-focused)

Config
{}

Installed Packages
# User
browser-plus, v0.0.60
open-in-browsers, v0.0.16

# Dev
No dev packages

This should be fixed in Atom 1.9.0-beta0 and up.


⚠ Bofrost.be has degraded performance

In 850b1a7, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 960 ms

Resolved: Bofrost.be performance has improved in 3cfdf02 after 310 days, 23 hours, 6 minutes.


Use cfenv(vcap:≈)

See: https://github.com/IBM-Bluemix/gp-nodejs-sample/issues/4
Once the sample is updated, update gp-js-client's README to reflect recommended usage.

[ ] Ensure that the README also has an example local vcap: file

better to emphasize the gp-config.json common format— so closing this for now in favor of https://github.com/IBM-Bluemix/gp-js-client/issues/33


Prefer description when referring to an OAS document

Usage of description and definition to refer to an OAS document was mixed. This makes it more consistent, and prefers "description" of the service, since as a possible-truth it is more broad than "definition," which suggests an actual truth. (note: definition does still occur in the doc, but those refer to specific parts of the document rather than the document as a whole)

I like using "API description" to consistently refer to OpenAPI-format descriptions of APIs. This seems clearer than calling them "specifications" which gets easily confused with "The" OpenAPI Specification.

👍 for @DavidBiesack's comment. API description seems closest to API documentation as described by this blog post which reserves API definition for machine-readable artefacts.
The OpenAPI document should be the objective truth of the definition of the API as far as the OpenAPI specification allows it to be defined.

@DavidBiesack and @MikeRalphson, definition to me means the specification is truth. That might be the case if the spec is code or is generated from code. But when a spec is written by hand, it describes a service—often poorly, such as when a 3rd party tries to describe an existing service (such as the apis.guru collection, at least AFAICT).
For me, a definition is a subset of description, truth vs possible truth. I'd love if all specs were, in fact, definitions, but in reality, we must appreciate that there will be many specs that are fallible. In that case, I strongly prefer the looser term.

Thinking about this some more… descriptions may be inaccurate whereas definitions cannot be. Furthermore, an API spec often contains metadata for people, such as tag or description elements that have no direct impact on the functionality of the service that is being described. Also, I generally think of OpenAPI, RAML, WADL, etc, as falling into the category of an Interface Description Language (IDL).

@earth2marsh I do believe that dictionaries attempt to provide definitions that are accurate.  It doesn't mean that all dictionaries will have exactly the same definition.  An OpenAPI document is an attempt to be precise about the shape of an API.  It does not have to be an exhaustive description but what is defined should be correct.   I don't think that justifies watering down the OpenAPI document to be a just a description.
Within the OpenAPI document there are descriptions of various elements of the API in human readable language.  I would prefer to be able to distinguish between the OpenAPI document that is machine readable and the descriptions of the API that are only human readable.
I was almost swayed by the IDL comparison but Wikipedia page says "definition" is cool too :-)

An interface description language or interface definition language (IDL), is a specification language

I'm actually more worried about watering down "definition". Changing a parameter description doesn't change the service definition, but it does change the description of the service. Plus, when the spec defines the service, how do you distinguish that from a spec written out of band that attempts to describe the same service? One of those is a definition, the other is an attempt to define, like saying hopping is like jumping.

That might be the case if the spec is code or is generated from code. But when a spec is written by hand, it describes a service—often poorly, such as when a 3rd party tries to describe an existing service (such as the apis.guru collection, at least AFAICT).

@earth2marsh You're missing the case where the code was generated from the definition/description (not 'spec', never that 😄). But just for clarity, around 95% of the APIs.guru collection is direct from the API owners, not third-party 'descriptions', so allowing for conversion errors in some cases, they are the published definitions/contracts of those APIs in OpenAPI terms.

@MikeRalphson that's what I was trying to get at by the case of the D "being code." Funny, I have no qualms about the concept of the D being the contract—it is how the provider formally declares the capabilities of the service, and some contracts are poorly written.
For me, the service is defined by the code behind it. If that code maps onto a D 1:1, then it is a definition. If it doesn't map closely, it's probably because it was written out of band, making it a description. If I were to generate tests from a definition, I would expect them to pass when run. If they were generated from a description, I'd expect a higher rate of failure because the service is not defined by the document.
To put it another way, π × r2 can describe and/or define a circle. If I write code using that formula to draw a circle, it has been defined be the equation. If I draw a circle by hand, I can say the formula describes my circle, but can I say that it defined it?

#TDC: When people create an OpenAPI document, do we call that a "definition" or a "description" ?
#TDC: @darrelmiller prefers "definition" @earth2marsh prefers "description"
#TDC: Other options include "model" or "contract"
#TDC: Whatever we decide may be over-written by what people do (in practice)
#TDC: (Ted) As a tools provider, having something documented somewhere is helpful.
#TDC: (Erin) Definition is often more important that description
ACTION: @earth2marsh to re-submit as "definition"

I also think definition is better – it makes it clear that the OpenAPI document is what defines the API (even if the implementation doesn't actually conform to it), not the implementation (which is then just described).

I'm happy with any of these. "document" is also a good choice since Paŭlo
just used it and it's consistent with the usage of "document" in the JSON
Schema specification.
http://json-schema.org/latest/json-schema-core.html
On Fri, Jul 7, 2017 at 12:28 PM Paŭlo Ebermann<EMAIL_ADDRESS>wrote:

I also think definition is better – it makes it clear that the OpenAPI
document is what defines the API (even if the implementation doesn't
actually conform to it), not the implementation (which is then just
described).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/OAI/OpenAPI-Specification/pull/1247#issuecomment-313729657,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAABlYgY6mgT1aSxSKas9t2mwUmFJqoiks5sLlylgaJpZM4OLAOI
.

@timburks I'm warming to that suggestion of document, and after some discussion with folks like @RobDolinMS, @emckean, and @darrelmiller, I added a commit that replaced description with document (and like forms).
@DavidBiesack, @MikeRalphson, @timburks, and @ePaul, how do you feel about this latest version?

I just had a long conversation with someone about OpenAPI and couldn't stop myself from talking about API descriptions.  Sigh.

I feel I need to change my position on this.  Consider these two images:

The more I talk to people about specifications like OpenAPI the more I find that they are commonly referred to as API Description Languages.  See Wikipedia https://en.wikipedia.org/wiki/Overview_of_RESTful_API_Description_Languages
I think trying to get traction behind a term other than "an API Description" is likely going to be hard.

@darrelmiller's point is quite telling. Having looked at it again https://github.com/OAI/OpenAPI-Specification/pull/1247/commits/ccf4651b206502fb1e11daf8f93bacdc76502d92 with 'description' is preferable to me to the latest commit, as it doesn't suffer from overloading 'document' and doesn't re-introduce 'files'.

Ignoring which search engine @darrelmiller used (ahem), I can play that game too:

(using a non-signed-in incognito search)
Now, while the OpenAPI may be a "description language", I still find that an instance of it is a definition as explained by others here (as it is an instance that conforms to the spec). So while you'd have an API description, you'd be providing it with an OpenAPI definition.
Regardless of what we pick, people are going to use whatever they want, be it definition, description, document, or, sorry to say, most likely, spec.

@earth2marsh ping


netcdf 4.5.0 creates files with bad fill values

testfile45.nc.gz
testfile4411.nc.gz

Please provide as much of the following information as you can, as applicable to the issue being reported.  Naturally, not all information is relevant to every issue, but the more information we have to start, the better!

Environment Information

Feel free to skip this if the issue is related to documentation, a feature request, or general discussion.

What platform are you using? (please provide specific distribution/version in summary)

[X ] Linux
[ ] Windows
[ ] OSX
[ ] Other
[ ] NA

32 and/or 64 bit?

[ ] 32-bit
[X] 64-bit

What build system are you using?   (not sure - build provided by cisl)

[ ] autotools (configure)
[ ] cmake

Can you provide a sample netCDF file or C code to recreate the issue?

[X] Yes (please attach to this issue, thank you!)
[ ] No
[ ] Not at this time

Summary of Issue
netcdf 4.5.0 seems to provide a default fillvalue which is incorrect, I found this to be the case for both int and float, the testcase is for int only
Steps to reproduce the behavior
#include <stdio.h>
#include <netcdf.h>

int main()
{
    int ncid, vid;
    int ierr;
    void *fillvalue;

    ierr = nc_open("testfile45.nc", 0, &ncid);

    ierr = nc_inq_var_fill(ncid, 0, NULL, fillvalue);

    printf("found fillvalue %d expected %d\n",*((int *) fillvalue), NC_FILL_INT);

    ierr = nc_open("testfile4411.nc", 0, &ncid);

    ierr = nc_inq_var_fill(ncid, 0, NULL, fillvalue);

    printf("found fillvalue %d expected %d\n",*((int *) fillvalue), NC_FILL_INT);
}

The two test files are attached.   The result of the test program is
./a.out
found fillvalue 1 expected -2147483647
found fillvalue -2147483647 expected -2147483647

Just a side note, the test program is buggy. Variable fillvalue should be defined of type int, instead of a pointer. A physical  memory space is required for nc_inq_var_fill() to store the inquired fill value.
One interesting observation is that ncdump 4.5.0 command shows variable 0 "Billy-Bob" does not have _FillValue attribute defined in either file but nc_inq_var_fill() reports the variable's fill mode is OFF in file testfile45.nc and ON in testfile4411.nc. I thought NetCDF's default is ON for all variables.
In addition, in the implementation of nc_inq_var_fill() in file libsrc4/nc4var.c
https://github.com/Unidata/netcdf-c/blob/0f7118107ee33eaab6c7e9a2f825204bf5a132ed/libsrc4/nc4var.c#L876
argument fill_valuep will not be set to the fill attribute value if the variable's fill mode is OFF. This does not sound right. A variable can have attribute _FillValue defined but its fill mode turned OFF, because a variable's fill mode is set by nc_set_fill() or nc_def_var_fill(), not attribute _FillValue. NetCDF should not prohibit the inquiry API from getting the fill value when fill mode is OFF.

@jedwards4b I believe this bug is now fixed in the master branch. I have a similar test on a branch of master which passes. That is, the correct fill values are used.
@wkliao when fill mode is off, a fill value is not returned because there is no fill value in effect. There may be a _FillValue attribute, but it is not operating as a fill value. Anyway, that was my reasoning. If others think that's confusing, I would be happy to make the change and just return the fill value that would be used if fill mode were on. Anyone else have an opinion?

I am thinking a case when users would like to check the fill value when the mode is off to decide whether to use a different value before turning it back on.


Fix leading spaces pushing text outside Label autowrap boundary in 3.x

Fixed #59985 leading spaces autowrap boundary problem
Bug problem:
No condition for when the first character of the label is a space character
Fix:
Added an IF condition for when the first character is a space character
The autowrap boundary treat this space character as another dummy word in the WordCache linked list and proceed to function normally
*Note: the first screenshot is post bug fix, the second screenshot is pre bug fix, the fix works for left, center, right align

Texts now go out of the bounary when autowrap is turned off :(

... and it's still pushing text outside the autowrap boundary on the second line:

Texts now go out of the bounary when autowrap is turned off :(

... and it's still pushing text outside the autowrap boundary on the second line:

hmmm i think i must have forgotten to add an else-if statement, let me fix it

@timothyqiu Hi, I try testing different scenarios similar to yours while toggling di Autowrap checkbox in the video below, it seems to be working fine. How did the problem re-appear?
https://user-images.githubusercontent.com/50128969/163136095-dd457e3c-e4fc-493e-9400-1af1163fdff8.mp4

@ZheisterCoding It's already there in your screen record. You can zoom in to get a better view.

@ZheisterCoding It's already there in your screen record. You can zoom in to get a better view.

Hi, I noticed the problem as well after you mentioned this. I've made a small adjustment, the problem should disappear now hopefully. @timothyqiu

The first issue is fixed. But the second issue (leading spaces on the second line) still exists.

The first issue is fixed. But the second issue (leading spaces on the second line) still exists.

@timothyqiu Thank you for pointing that out.  I've added a local boolean variable within the function to track when a newline is made, so the leading space issue for the very first line and created newlines should now hopefully be fixed.
https://user-images.githubusercontent.com/50128969/163146916-8e2aba3b-4eeb-4e24-903b-ede9f3f5b9a7.mp4

The way that this particular function works is that the string is stored in a linked list named word_cache So, the words are stored in a list, which in this case is separated by 'spaces‘。
word_pos, current_word_size are counters to monitor the current word node (the node is called WordCache in the cpp file), word_pos takes the position of the first character in the word node, and current_word_size represents the length. In this case, what I have done is created a temporary word node consisting of exactly 1 space character (normally the node would contain letters). Hence, the current_word_size is equals to one space-width, the word_pos represents the index of the first character in the word, so the dummy one 'space' word node is treated like any other nodes in WordCache linked list.
line_width affects the autowrap functionality. Basically, autowrap is implemented when the line_width exceeds the width of the label box (hence, line_width >= width in line 492) in the code. The line_width takes into account current_word_size and space_count, in which every space is equals to one space_width in length.
So in conclusion, I've converted the singular leading space when i= 0 or a newline is made, into a 'dummy' node, and it is treated like another normal string of alphabetical characters. This allows autowrap functionality to work normally when there is a leading space, since previously, the autowrap didn't detect the leading spaces, which causes the words to go over the boundary.
@timothyqiu

@timothyqiu I've created a new pull request in here #60216


Add Hash#map_keys

I want to start a discusion about this feature. The main idea of this method is to work like #map, except returning a Hash instead of an Array. I think it's an useful addition, and it simplifies the task of building hashes from arrays - that usually requires using #each_with_object.
That said, I'm open to suggestions about pretty much everything; I'm not sure this is a good naming, the examples I used for the specs are far from good and maybe I didn't covered all the possible cases.
Also as a note, theres' an ongoing discussion on the Ruby bug tacker suggesting to add such feature to core (https://bugs.ruby-lang.org/issues/8951).
Nitpicks and feedback are welcome.

Giving another shot here.

@bbatsov also fixed problem with the travis build.


Fixes issue #288 - Pipe an answer on summary page

What is the context of this PR?
This change splits out the multiple roles of the TemplatePreProcessor into discrete functions and ensures those functions are called at the correct points in the users journey through a questionnaire.  This PR solves the issue #228 which showed that piped values were not being passed into questions when being displayed on the summary page.
How to review

Checkout the branch and run the unit tests
Run the app and use the dev console to select the star wars survey
Fill in the survey and verify that Chewbaccas age is correctly displayed in the question text
Go to the summary page, and confirm that Chewbaccas age is also displayed on the summary page

[ ] Do all commits have sensible commit messages?
[ ] Is all new code unit tested?
[ ] Are there integration tests if needed?
[ ] Is there sufficient logging?
[ ] Is there documentation or is the code self-describing?

Who worked on the PR
@weapdiv-david worked on this PR

A test in Star wars on the summary page for the value would be good

Looks good otherwise :thumbsup:


micro-deposits: use a random id for temporary receiver

Codecov Report

Merging #216 into master will decrease coverage by 4.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   57.78%   53.53%   -4.26%
==========================================
  Files          31       31
  Lines        4269     4240      -29
==========================================
- Hits         2467     2270     -197
- Misses       1313     1509     +196
+ Partials      489      461      -28

Impacted Files
Coverage Δ

microDeposits.go
61.53% <100%> (-0.55%)
:arrow_down:

accounts.go
10.95% <0%> (-67.13%)
:arrow_down:

internal/database/mysql.go
11.11% <0%> (-52.78%)
:arrow_down:

ofac.go
38.65% <0%> (-35.3%)
:arrow_down:

internal/filetransfer/sftp.go
44.44% <0%> (-26.12%)
:arrow_down:

internal/filetransfer/config.go
55.11% <0%> (-0.79%)
:arrow_down:

main.go
7.89% <0%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099bb35...424bf3c. Read the comment docs.