Update reference-microsoft-graph-app-manifest.md

Add explanation about trustedCertificateSubjects attribute

#sign-off

@rwike77
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


fix: RTL support

What:

Adds RTL support to fix https://github.com/express-labs/pure-react-carousel/issues/266
Why:

Allows the carousel content to be accessed when used on RTL pages, and updates the slide direction to match the direction of the text
How:

Adding [dir="rtl"] & selectors which flips the slider such that the slides are reversed and it visually translates in the opposite direction, and also flips each slide such that their content is not reversed.
Checklist:

[x] Documentation added/updated
[x] Typescript definitions updated (N/A)
[x] Tests added and passing (N/A)
[x] Ready to be merged

The global attribute selector used to solve this issue feels a little hacky, but afaik there is no CSS-only solution which is more robust (the :dir pseudo-selector would be nice, but it doesn't have wide browser support)

@seleb It looks like there are some linting errors that need to be addressed?

lint errors have been addressed; is there any additional discussion or changes needed on this?

@seleb you are good! Merged - it will be built and published.

:tada: This PR is included in version 1.27.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Set OVERMIND_WORKER_NAME env var for each process

This commit:

sets an OVERMIND_WORKER_NAME env var populated with the process name for each tmux cmd

Why?

It can be useful for each process to be able to reference its 'worker name' as specified in the Procfile.

Closes #148
There may be a cleaner way to do this than just manipulating the tmux command, I'm certainly open to any suggestions!

@DarthSim This would be a nice feature to get merged! Is there something I can do to help get this merged? Thanks for the awesome tool!

Thanks a lot for the pull request.
I changed place to define the variable to script file that already used to export PORT variable.
Also I renamed variable to PS for compatibility with the original foreman gem (see https://github.com/ddollar/foreman/pull/340)

Awesome thanks so much!


Localize website

#34
Added a language option. For example,
  app.get('/', function(req, res) {
    setCache(res, 2);
    res.send(generatePage({
      page: {
        template: templates.home,
        data: {packages: LIBRARIES}
      },
      language: 'ja'
    }));
  });

then

I do not know how to change language option dynamically. If it can change, it works.
Also I will translate the rest of pages, if this is good for you.
Thanks

Great work @e-jigsaw, we should be able to figure out the languag via the sub domain in the request host.
so if ja.cdnjs.com {language:'ja'}

@thomasdavis like https://github.com/bmullan91/express-subdomain ?

req.headers.host.split('.')
// => [ 'ja', 'localhost:5000' ]

this is it

@thomasdavis I exported all page sentences to yaml. And translated in Japanese.
I think this PR is ok to merge. Is there anything I should do?
Thanks

hi @e-jigsaw, sorry for the late reply, I wonder if you can rebase with our latest master?
and I'll need @thomasdavis to confirm if we can support this feature now, thanks!

Close due to no response, sorry.


Fixes catalog list services for minishift

What type of PR is this?
/kind bug
What does this PR do / why we need it:
$subject
Which issue(s) this PR fixes:
Fixes #4376
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

[x] I have read the test guidelines

How to test changes / Special notes to the reviewer:
odo catalog list services should pass on all the three platforms:

Kubernetes (minikube)
OCP 4.x (CRC)
OCP 3.11 (minishift)

Unit test failure:
golangci-lint run ./... --timeout 5m
pkg/odo/cli/catalog/list/services.go:44:58: S1002: should omit comparison to bool constant, can be simplified to `!csvSupport` (gosimple)
		} else if csvSupport, _ := o.KClient.IsCSVSupported(); csvSupport == false {

Unit test failure:
golangci-lint run ./... --timeout 5m
pkg/odo/cli/catalog/list/services.go:44:58: S1002: should omit comparison to bool constant, can be simplified to `!csvSupport` (gosimple)
		} else if csvSupport, _ := o.KClient.IsCSVSupported(); csvSupport == false {

/lgtm

/lgtm

/test v4.6-integration-e2e

/test v4.6-integration-e2e

I have tested PR on openshift 3.11(minishift) and it's passing successfully.

I have tested PR on openshift 3.11(minishift) and it's passing successfully.


Remove version: Tencent.COSBrowser version 2.9.4

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://cos5.cloud.tencent.com/cosbrowser/cosbrowser-setup-2.9.4.exe
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 896)


The correct syntax for testing iis_section unlock

My cookbook installs and configures IIS by using the IIS cookbook (https://supermarket.chef.io/cookbooks/iis). The tests are failing because one of my test methods isn't recognized. I followed the chefspec documentation that says to write the test like so:
expect(chef_run).to ACTION_RESOURCE(NAME)

Which in my case I think would mean
expect(chef_run).to unlock_iis_section(SECTION_NAME)

So in my iis.rb recipe I have
include_recipe 'windows'
include_recipe 'iis'
include_recipe 'iis::mod_aspnet45'
include_recipe 'iis::mod_auth_windows'
include_recipe 'iis::mod_logging'

iis_section 'system.webServer/handlers' do
  section 'system.webServer/handlers'
  action :unlock
end

And in my iis_spec.rb test file I have
before do
  allow_any_instance_of(Chef::Recipe).to receive(:include_recipe).and_call_original
  allow_any_instance_of(Chef::Recipe).to receive(:include_recipe).with('iis::default')
  allow_any_instance_of(Chef::Recipe).to receive(:include_recipe).with('iis::mod_aspnet45')
  allow_any_instance_of(Chef::Recipe).to receive(:include_recipe).with('iis::mod_auth_windows')
  allow_any_instance_of(Chef::Recipe).to receive(:include_recipe).with('iis::mod_logging')
end

it 'includes the iis cookbook' do
  expect_any_instance_of(Chef::Recipe).to receive(:include_recipe).with('iis::default')
  expect_any_instance_of(Chef::Recipe).to receive(:include_recipe).with('iis::mod_aspnet45')
  expect_any_instance_of(Chef::Recipe).to receive(:include_recipe).with('iis::mod_auth_windows')
  expect_any_instance_of(Chef::Recipe).to receive(:include_recipe).with('iis::mod_logging')
  chef_run
end

it 'unlocks the system.webServer/handlers section' do
  expect(chef_run).to unlock_iis_section('system.webServer/handlers')
end

But when I run the tests I get the following error
nuget_server unlocks the system.webServer/handlers section
   Failure/Error: expect(chef_run).to unlock_iis_section('system.webServer/handlers')
   NoMethodError:
     undefined method `unlock_iis_section' for #
<RSpec::ExampleGroups::NugetServer_2:0x00000007268d90>
   # ./nuget_server/spec/iis_spec.rb:49:in `block (2 levels) in <top (required)>'

I'm sure there is an error in my cookbook or in my test but I'm not sure where it would be. Do I need to add some matcher from the IIS cookbook to my chefspec run or am I missing something else obvious?

ChefSpec only includes matchers for core Chef resources. Cookbooks that have their own resources need to package customer matchers. I would recommend reaching out to the creators of that cookbook to have them package custom matchers in the iis cookbook so you can use them in your tests.

Thanks I'll get in touch with the IIS cookbook developers.


Problem with CEI-API + App Engine of Google Cloud

I deployed the scritp in the Google Cloud AppEngine as you mentioned that you also did, but I'm having problems running it in the Browser or Insomnia.
The / token function works perfectly.
When I try to perform the functions:
/wallet
/transactions
/dividends
When I run on my machine locally it works perfectly.
But in the browser I get this message:

Error: Server Error
The server encountered an error and could not complete your request.
Please try again in 30 seconds.

And I get the following error in the App Engine logs:

I 2020-08-05T20:33:01.888646Z GET 200 259 B 5,8 s Chrome 84 / GET 200 259 B 5,8 s Chrome 84 5f2b177d00ff0d8f461f573e960001697e6170692d353030393038373230363537343335313930362d3636363731390001323032303038303574313731383037000100
W 2020-08-05T20:33:11.340270Z GET 500 0 B 9,2 s Chrome 84 /wallet GET 500 0 B 9,2 s Chrome 84 5f2b178700ff05312ef63d0b720001697e6170692d353030393038373230363537343335313930362d3636363731390001323032303038303574313731383037000100
A 2020-08-05T20:33:11.394451Z Searching wallet - Current date
A 2020-08-05T20:33:15.879413Z Logging at CEI...
A 2020-08-05T20:33:17.379446Z Error: Error: Protocol error (Target.createTarget): Target closed.
A 2020-08-05T20:33:17.379467Z     at /workspace/node_modules/cei-crawler/node_modules/puppeteer/lib/Connection.js:74:56
A 2020-08-05T20:33:17.379477Z     at new Promise ()
A 2020-08-05T20:33:17.379487Z     at Connection.send (/workspace/node_modules/cei-crawler/node_modules/puppeteer/lib/Connection.js:73:12)
A 2020-08-05T20:33:17.379496Z     at Browser._createPageInContext (/workspace/node_modules/cei-crawler/node_modules/puppeteer/lib/Browser.js:174:47)
A 2020-08-05T20:33:17.379505Z     at BrowserContext.newPage (/workspace/node_modules/cei-crawler/node_modules/puppeteer/lib/Browser.js:367:26)
A 2020-08-05T20:33:17.379512Z     at Browser.newPage (/workspace/node_modules/cei-crawler/node_modules/puppeteer/lib/Browser.js:166:33)
A 2020-08-05T20:33:17.379520Z     at Browser. (/workspace/node_modules/cei-crawler/node_modules/puppeteer/lib/helper.js:112:23)
A 2020-08-05T20:33:17.379528Z     at CeiCrawler._callee2$ (/workspace/node_modules/cei-crawler/app.js:547:38)
A 2020-08-05T20:33:17.379536Z     at tryCatch (/workspace/node_modules/regenerator-runtime/runtime.js:63:40)
A 2020-08-05T20:33:17.379554Z     at Generator.invoke [as _invoke] (/workspace/node_modules/regenerator-runtime/runtime.js:293:22)
A 2020-08-05T20:33:17.379565Z   -- ASYNC --
A 2020-08-05T20:33:17.379573Z     at Browser. (/workspace/node_modules/cei-crawler/node_modules/puppeteer/lib/helper.js:111:15)
A 2020-08-05T20:33:17.379580Z     at CeiCrawler._callee2$ (/workspace/node_modules/cei-crawler/app.js:547:38)
A 2020-08-05T20:33:17.379589Z     at tryCatch (/workspace/node_modules/regenerator-runtime/runtime.js:63:40)
A 2020-08-05T20:33:17.379605Z     at Generator.invoke [as _invoke] (/workspace/node_modules/regenerator-runtime/runtime.js:293:22)
A 2020-08-05T20:33:17.379615Z     at Generator.next (/workspace/node_modules/regenerator-runtime/runtime.js:118:21)
A 2020-08-05T20:33:17.379627Z     at asyncGeneratorStep (/workspace/node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
A 2020-08-05T20:33:17.379641Z     at _next (/workspace/node_modules/@babel/runtime/helpers/asyncToGenerator.js:25:9)
A 2020-08-05T20:33:17.379652Z     at processTicksAndRejections (internal/process/task_queues.js:97:5)

Please help-me, thankyou.

Hi Matheus.
I noticed that the error starts after the crawler process started. It seems like an issue with the puppeteer library, used by the crawler. With that, it is out of the API scope.
I'd suggest you open an issue at the (cei-crawler repository) where he can help you better.

Hi Bruno, okay, but did your API work well when you deployed to AppEngine?
Didn't you have any problems with that?
Because I'm using the same version that you made available hehe

I solved after add this code in app.yaml there

basic_scaling:
max_instances: 20
idle_timeout: 5m

Sorry, but I haven’t deployed it on AppEngine. I tried to do that on Heroku, but there was a issue regarding a default timeout.
Glad to hear that you could fix it.


Website still lists<EMAIL_ADDRESS>

I'm not sure where the source is or I'd just make a PR directly, but it looks like this was renamed to<EMAIL_ADDRESS>some time ago.

Ah, I see now that this may be intentional, as I guess 10.x is a beta release while stuff is being sorted out?

@gjtorikian Not intentional, it should be on 10.1.0. We made a name change (from primer-css to primer) and got a bit busy with some follow-up work and neglected to update the site. I've opened a pr to update the site today https://github.com/primer/primer.github.io/pull/9 - sorry for any confusion, hit us up in #design-systems on slack if you have any questions.


Definitions just go until a certain point of the code

All this views are in the same file, imported through this at the top from base_production import views
As you can see my definitions stop in a certain point of the code, from Deliverable FileList down no definition is accessible.
Is there some limit based on file size or some configuration to fix this or is this a bug?
Thanks guys

Hi @weberxw
Thank you for the feedback. This does look like a bug.
The only limit that I can think of is a memory threshold during analysis where we sometimes throw away cache data to bring the memory usage back down.
Semantic colorization runs in the background with its own analysis cache, but the Go to Definition command runs in the foreground and does not share that same state.
While the screenshot clearly shows that semantic colorization stopped recognizing your view classes, can you confirm that Go to definition command is also broken for the ones that aren't colored?
Could you also please try to reorder your url calls and see how that changes the result? Like move all the Discipline url calls up above Project url calls. Mostly I'm trying to figure out if it's something in the beginning of the Discipline group that breaks things.
Another question, does it look like this when you first open the file, before you edit anything?
Finally, are there any errors that appear in the Output window, under Python Language Server?
thanks!

Hi @huguesv , thank you for the answer.
I made some tests and here are the results..

Its not just semantic colorization

I changed the order and the result was the same, I was able to access the ones above the limit, no matter the class

its not just when I open the file, I can change anything, edit, close, reopen, the definitions keep unaccessible from that point bellow

Thats the output log

Hope this can help.
TY

@weberxw thank you
Can you please check the output for Python Language Server, you have to select it from the combo box on the right:

Is this an open source project by any chance?

Ops, forgot that
No, its a private project

Minimal repro:
mylib.py
class MyClass:
    pass

mytest.py
from . import mylib

data = [
    mylib.MyClass,
    mylib.MyClass,
    mylib.MyClass,
    mylib.MyClass,
    # copy/paste 70 or more of these...
]

After 64 entries, go to definition and semantic colorization on MyClass stops working.
It's the limit specified by maxEntriesToUseForInference
https://github.com/microsoft/pyright/blob/master/packages/pyright-internal/src/analyzer/typeEvaluator.ts#L607

Curious; my reading of that limit is that it should only be preventing the creation of large list/dict/set types via literals, but I it's stopping any evaluation of the node. Perhaps if the limit only stopped the addition of the item to the container but still evaluated everything, it'd work due to the evaluation happening?
I'm wondering if this means you can make a large list, then do something invalid at the end and it type check even though it's wrong.

In context, this makes sense; the screenshots in the original post hid the fact that these were appearing in a list literal.

@weberxw, thanks for the bug report.
@huguesv, thanks for the investigation and repro.
I found the root cause of this bug, and I've checked in a fix.

This issue has been fixed in version 2020.10.3, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#2020103-28-october-2020


[DOCFIX] Supply the variable name to Preconditions.checkNotNull

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16821/
Test PASSed.

Merged build finished. Test PASSed.

@Popeye13 an unrelated file .DS_Store is also included in this PR. can you remove it?


(Sentinel) Track Prometheus data, if there are unexpected cpu or memory spike, or if the usage exceeds certain threshold, send alarm

achieved through grafana alerts


test ci

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6f83354). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   75.23%
=========================================
  Files             ?      199
  Lines             ?    15947
  Branches          ?        0
=========================================
  Hits              ?    11997
  Misses            ?     3950
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f83354...10bef0e. Read the comment docs.


All code blocks are repeated in document website

Describe the bug
I found in vitest website https://vitest.dev all code blocks are repeated two times. Considering that the doc uses vitepress, I created a new vitepress and wrote a code block, and found no problems. I guess the problem is from vitest?
Reproduction
Access https://vitest.dev/guide/ and will see

System Info
System:
    OS: macOS 12.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 158.91 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.18.0 - ~/.nvm/versions/node/v14.18.0/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v14.18.0/bin/yarn
    npm: 6.14.15 - ~/.nvm/versions/node/v14.18.0/bin/npm
  Browsers:
    Chrome: 106.0.5249.119
    Firefox: 98.0.1
    Safari: 15.5

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Fixed with https://github.com/vitest-dev/vitest/commit/f56fe9e1e44de23c9c8a29a1ea72c37ba7a22a71


Improve file endings in readme

The code examples already use level.json instead of json.level. Do the same in the readme.

Resolved in 24c55bec85ce4729e6bfceb761b7b41c6639e99d


Add logrus support

This PR adapts my free-standing logrus hook (https://gitlab.com/flimzy/logrusentry) for inclusion in this repo. Closes #43
There's a good chance this hook doesn't take advantage of all available/relevant Sentry features.  But it's been serving me well for several years now, at at least three different companies.  Please advise if there are any functional or stylistic changes that are desired. I'm happy to do what I can to get this included in this repo.

Be great to see this merged!

While this would be helpful in the short term for migrating a project from raven-go, in the long term it might be better to hold off on this until there's more clarity on the discussion about adding structured logging to the go std lib.
Because if that turns into a proposal that lands, then I suspect most applications will start migrating toward that or toward logging libraries that extend that. So usage of logrus would probably decline given that it's in maintenance mode so unlikely to be updated to that.
Wouldn't want to add the logrus support for a few months to a year, then have to do a full version bump simply to drop it again. I expect that the logging discussion should result in a decision either way within a few months, so even if that discussion gets rejected then the worst case is it only delays the inclusion of the logrus hook by a few months.

Rebased and force-pushed after recent changes to master.

? Wouldn't want to add the logrus support for a few months to a year, then have to do a full version bump simply to drop it again. I expect that the logging discussion should result in a decision either way within a few months, so even if that discussion gets rejected then the worst case is it only delays the inclusion of the logrus hook by a few months.

IMO, it wouldn't make sense to drop it until logrus is no longer widely used, which will probably be 5-10 years, even if no new projects ever adopt it starting immediately.

Agree that it's still fine to support libraries that are and probably will be very widely used for a long time.
If anything, I'd much rather drop it in the future, than not have support for it during that period.
We are also still pre-v1 release, so if it won't gain any traction, we'll always have the opportunity to not support it anymore.

Thanks for the review @kamilogorek . I've addressed most of your comments, and added a follow-up question.

Thanks, there's one thing left. You did the reverse of what I'd prefer 😅
Here https://github.com/getsentry/sentry-go/pull/471#discussion_r998070949 instead of holding onto scope/client separately, keep the reference to hub itself, not the other way around.
It's because Hub already has references to its client and scope via hub.Scope() and hub.Client() methods.

You did the reverse of what I'd prefer sweat_smile

Ha! Oops. Thanks for the explanation. Will follow up soon.

Rebased and updated to use hub in place of client and scope.

@flimzy We might want this to be its own module, to not add further deps to the main package.
cc @kamilogorek What do you think?

We might want this to be its own module, to not add further deps to the main package.

I don't think it adds any deps anyway.  The only change to go.mod is a promotion of logrus from an indirect to direct dependency, so won't actually change the deps that any consumer has to download.

btw, @flimzy test failures are caused by a new option added via https://github.com/getsentry/sentry-go/pull/490

I've added an example. Feedback welcome. It's hard to know how detailed to be in an example.

Thanks a lot, looks good to me!

All requests from the previous review were applied, thanks!
As for the separate package, I think we can postpone it with logrus, as it's already been our dep before, which you already notices.
We can also test it out in the wild, and verify whether we should pull the support to v1 of the SDK once we go for it.

I just noticed that filename is called logrusentry instead of logru*s*sentry haha. But I think it's actually a good wordplay, and it's not affecting the behavior, so we can leave it as is if you want😅

Re: logrusentry vs logrussentry, it was an intentional wordplay, but perhaps that violates the principle of least surprise?  I can go either way ;)

Nah, I like the idea as well!


adapter shows no status

Why the adapter not show the green, red, yellow or gray flag ?

Why the adapter not show the green, red, yellow or gray flag ?

its an scheduled adapter, so only runs for a few minutes that will wait until the next run.
This kind of scheduled adapter do not have a status connected etc :)


refactor(injector): remove unneeded JSHint directives

The difference between applying a constructor with and without parentheses is merely syntactic.

This was supposed to be part of #13785, but since it's not certain that #13785 will land, let's merge this :)


Clarify FillForward/Backward fill function arg order in docs

The documentation for the fillerSelector argument of FillForward doesn't talk about the order of its arguments:

fillSelector
Type: System.Func<T, T, T>
The function used to produce the element that will replace the missing one. It receives the previous non-missing element as well as the current element considered missing.

This can leave someone guessing wrongly from just the signature System.Func<T, T, T>. It would help to clarify

The function used to produce the element that will replace the missing one. It receives the current element considered missing as the first argument and the previous non-missing element as the second argument.

Likewise for FillBackward:

fillSelector
Type: System.Func<T, T, T>
The function used to produce the element that will replace the missing one. It receives the next non-missing element as well as the current element considered missing.

/cc @PhilippeRaemy

Thanks, the new doc text will be helpful.


Merkle path instruction improvements

This PR will add a public variant of mpath assembly instructions. The tasks include:

[ ] Update semantics of BINACC VM instruction
[ ] Add CSWAP2 VM instruction
[ ] Refactor mpath assembly instruction to use CSWAP2 instruction and rename it to smpath
[ ] Add pmpath assembly instruction
[ ] Update documentation

Great to see this PR. Public inputs for the mpath is a very much needed function.


modified Username regex to include special characters

Yes, the goal is to only allow characters of other languages.


NO-JIRA: RHTAP Multi-Arch PipelineSpec

This should convert the RHTAP pipeline delivery into once that produces a multiarch image

/retitle NO-JIRA: RHTAP Multi-Arch PipelineSpec

/retest

/retest

/retest

/retest

/retest


[Layers Drawer] Replace placeholder text

Currently: This is an explanation of the offline overlay. \nThe images come from this source.

Offline map imagery
Hide or show downloaded imagery


What is the search icon in the topbar on the right and could it become a link to /search?

Based on my quick look at our navbar code, it looks like it does nothing. I can't see it doing anything. I didn't check the JS files to see if there was anything, but I kinda doubt it. What was it's original purpose?

It’s for filtering the reason list.

@j-f1 At /reasons? Because when I click it, nothing happens.

Probably [status-broken], maybe unless you're on /reasons. I think it appears for any page under DashboardController, though.

Reopening because this is still an issue -- the search icon works on the /reasons page but 1) it does the opposite of searching, it filters, and 2) it doesn't need to live in the navbar if it only works on /reasons.


[Bug] Docker releases are still being hosted on dbt-core and don't show up under Packages

Is this a new bug?

[X] I believe this is a new bug
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
Docker images show up here:
https://github.com/dbt-labs/dbt-core/pkgs/container/dbt-postgres
Expected Behavior
Docker images should show up under the Packages section here:
https://github.com/dbt-labs/dbt-postgres
and here:
https://github.com/orgs/dbt-labs/packages?repo_name=dbt-postgres
Steps To Reproduce
Perform a Docker release and go looking for it.
Relevant log output
No response
Environment
- OS:
- Python:
- dbt-postgres:

Additional Context
No response

It's confusing to users who are looking for the Docker releases. It's low priority and this will change again if we decide to merge the concrete adapter packages into a single repo.


Refactor file permissions and users

https://github.com/mholt/caddy/issues/1315

This will finally include a change of the current directory organization


Add argument datamodule using .fit() in docs

What does this PR do?

Add argument datamodule in the docs since the default second argument is train_dataloader.
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Passing it the way that is described in the docs currently actually works for fit! Test doesn't do this, though. Perhaps you can close this?

it is not true, the actual API as expects dataloader as the second argument but you pass datamodule
https://github.com/PyTorchLightning/pytorch-lightning/blob/458d3e210e2da10482d97a996708731b8b0fabae/pytorch_lightning/trainer/trainer.py#L966-L972
and
https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/trainer/trainer.py#L1289-L1296

nope. i enabled datamodules to be the secone argument. i guess i forgot to update the typing

the real fix is to add datamodule to the types available for the second arg. but fit(model, dm) works and is the expected usage.

nope. i enabled datamodules to be the secone argument. i guess i forgot to update the typing

but is it not in master yet and it is quite breaking change, no back compatibility...

it is in master. it is not a breaking change. it’s additional support. try it out yourself

it is in master. it is not a breaking change. it’s additional support. try it out yourself

ok, I see the if there... so the API a is a bit confusing as you can pass datamodule as train_dataloader argument and later we have also datamodule argument...
cc: @nateraw


Training Requirements

Hi, I was trying to use your code for training in another dataset for the depth prediction task. I noticed that during training I could not increase the batch size beyond 2. With a batch size of 2 and images of size 224x448 it takes almost 9GB of memory. Can you comment on the memory requirement? Like how did you train the model and how much memory it took? It will be really helpful if you can share some insights on training.
Thanks

Further, I was also trying to run the network in parallel by wrapping the model to torch.nn.Dataparallel(), but it seems the model is not correctly parallelized. The wights still reside in one GPU. I have attached the screenshot of the error below.

These are big models, so yes, they are memory intensive. We trained with 4 Quadro 6000 cards that have 24 GB memory each. Alternatively you can distribute across 8 GPUs with 12 GB of memory each. About 100 GBs of memory would be roughly the total amount of memory needed to train with our settings in terms of number of datasets, resolution, and batch size. If you don't have access to that kind of infrastructure, you could use gradient accumulation on fewer cards.
The second issue has to do with how we hook into timm: we monkey patch an additional method onto the object, so that we don't need to modify the original library source. See here for an example: https://github.com/intel-isl/DPT/blob/72830e11c7e72f58aee1465ab5207e3d0f0ab9fd/dpt/vit.py#L343
Unfortunately, this strategy doesn't play well with nn.DataParallel. AFAIK this is an open issue with DataParallel. See here for a similar discussion: https://github.com/Cadene/pretrained-models.pytorch/issues/112. I recommend to either switch to DistributedDataParallel, where this issue doesn't occur, or to rewrite the backbone so that this monkey patching isn't required.

Thanks, @ranftlr for the detailed response. Yes. I later found out that the reason for that. Further, I also noticed that register_forward_hook operation doesn't go well with nn.dataparallel as mentioned here: register-forward-hook-with-multiple-gpus. I worked around it and used the nn.Modulelist to store each of the blocks and then took the features from the corresponding block in the forward operation. This totally bypassed the register_forward_hook function and I can run the model in parallel now.

Great, thanks for pointing out this solution. I'm closing this issue for now.

@krantiparida Hi，I have run into the same issue. Could you please share the rewritten version of dpt model?

@Tord-Zhang I have modified the code as per my requirement. I am not sure if that will be useful to you. However,  I am attaching below the DPT model part. The other functions used are similar to the ones mentioned in this repo.
class VisualNet(nn.Module):
    def __init__(self,
            backbone="vit_large_patch16_384",
            use_readout='project',
            vit_features = 1024,
            pretrained=False,
            start_index=1):
        super(VisualNet, self).__init__()
        self.hooks = {
                "vitb_rn50_384": [0, 1, 8, 11],
                "vit_base_patch16_384": [2, 5, 8, 11],
                "vit_large_patch16_384": [5, 11, 17, 23],
            }
        self.model = timm.create_model(backbone, pretrained=pretrained)
        self.model.features = nn.ModuleList()
        for blk in self.model.blocks:
            self.model.features.append(blk)

        self.model.start_index = start_index
        self.model.patch_size = [16, 16]
        self.model.hooks = self.hooks[backbone]

    def forward(self, x):
        b, c, h, w = x.shape
        x.contiguous(memory_format=torch.channels_last)

        _, activations = forward_flex(self.model, x)

        return (activations[0], activations[1], activations[2], activations[3])

def forward_flex(self, x):
    b, c, h, w = x.shape
    pos_embed = _resize_pos_embed(
        self. start_index, self.pos_embed,
        h // self.patch_size[1], w // self.patch_size[0]
    )
    B = x.shape[0]
    if hasattr(self.patch_embed, "backbone"):
        x = self.patch_embed.backbone(x)
        if isinstance(x, (list, tuple)):
            x = x[-1]  # last feature if backbone outputs list/tuple of features
    x = self.patch_embed.proj(x).flatten(2).transpose(1, 2)
    if getattr(self, "dist_token", None) is not None:
        cls_tokens = self.cls_token.expand(
            B, -1, -1
        )  # stole cls_tokens impl from Phil Wang, thanks
        dist_token = self.dist_token.expand(B, -1, -1)
        x = torch.cat((cls_tokens, dist_token, x), dim=1)
    else:
        cls_tokens = self.cls_token.expand(
            B, -1, -1
        )  # stole cls_tokens impl from Phil Wang, thanks
        x = torch.cat((cls_tokens, x), dim=1)

    x = x + pos_embed
    x = self.pos_drop(x)
    results= []
    for ii,model in enumerate(self.features):
        x = model(x)
        if ii in self.hooks:
            results.append(x)
    x = self.norm(x)

    return x, results`

@krantiparida hi, as far as I am concerned, this code cannot solve the problem cause by self.patch_embed ?

@Tord-Zhang yes. This will not address the problem of self.patch_embed. In my case, I did not require self.patch_embed. However, I think you can also implement the same using nn.Modulelist as well.


overflow encountered in long_scalars

Got a RuntimeWarning: overflow encountered in long_scalars on spike2rawio.py:89 :
chan_info['t_start'] = block_info['start_time'] *
info['us_per_time'] * info['dtime_base']
while loading a 10500s / 850Mo smr file
I'll try with several files to check whereas the issue is repeatable

@FGabrielli : thank you for reporting.
In #600 I made a very quick patch could you test it with your long file ?

Just tested it. Worked ok on a VERY large file (16500s, 1.93Go). Thx Samuel :)
2 warnings remain :
C:\anaconda\lib\site-packages\h5py_init_.py:36: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
C:\anaconda\lib\site-packages\neo\rawio\spike2rawio.py:89: RuntimeWarning: overflow encountered in long_scalars
info['us_per_time'] * info['dtime_base']

Thank you very much.
I will make the change for the warning.


Python 3 support

This is a pure Python package and uses packages that already support Python 3.  How hard can it be?  :-)

Do you plan on supporting both Python 2 and 3? Doesn't look like it would be too hard to convert to Python 3, but supporting both version simultaneously could get a little cumbersome.

Thank you.  Not having made the jump to Python 3 before now, I was thinking I'd use this project to find out about it.  If the conversion isn't too painful, I will maintain both.

Looks like the code was pretty compatible. It is now running on v3.3 quite happily with some minor modifications.  First release supporting will be V1.1.0.  Still some tidy up left to help prevent version cross-compatibility regressions, though, so not closing just yet.

Nice. Python 3 will be standard in Fedora 22 and I'm guessing other distros will follow suit soon enough, so this was just in time.

Yeah - it's definitely reaching the tipping point.
Now closing this issue as I have futurized the code.  Doesn't look quite so pretty on the imports, but the rest is good to go.


Hotfix for apply_ignore() poor-febe case

As discussed on the TWG call today, there is a problem in apply_ignore() causing B1855+09 not to run through. This solves the problem.

@mtlam When you get the chance, try rebasing this on NG20 and see if the tests pass.


Unhook repo fork.

Hi, https://github.com/spree-contrib/spree_static_content should not be a fork when its the one being maintained. All credits about origin are still intact in the license etc.

Totally agree @futhr, I will update the forked repo and transfer the ownership.

Same for these that have activity:

spree_multi_domain @JDutil
spree_volume_pricing @JDutil
spree_editor @romul
spree-product-assembly @romul
spree_recently_viewed
spree_comments @romul (but uses secondary fork)

Looks like they finally removed me from the railsdog organization so I can't transfer those, but @BDQ could.

@futhr BDQ no longer has access to transfer Rails Dog forks either.  Perhaps @dhonig will transfer the Rails Dog ones.  I'm also not sure how to contact @romul aside from github mention so maybe he will see this and transfer them.  Otherwise they'll have to remain forks and/or we delete and recreate the repos as canonical.

Happy to help. Let me know what the best course of action isOn Thu, Jan 29, 2015 at 12:27 PM,  Jeff Dutil<EMAIL_ADDRESS>wrote:            @futhr BDQ no longer has access to transfer Rails Dog forks either.  Perhaps @dhonig will transfer the Rails Dog ones.  I'm also not sure how to contact @romul aside from github mention so maybe he will see this and transfer them.  Otherwise they'll have to remain forks and/or we delete and recreate the repos as canonical.
—Reply to this email directly or view it on GitHub.

@dhonig, they ideal is to transfer ownership to spree-contrib, then no forks nor stars are lost, very easy done in Github settings. Thanks.

I'm happy to transfer any extensions out of RailsDog that we are not
actively developing to spree-contrib  doesn't look like we are the origin
author of spree-static-content
https://github.com/pero-ict-solutions/spree-static-content
On Thu, Jan 29, 2015 at 1:53 PM, Tobias Bohwalli<EMAIL_ADDRESS>wrote:

Same for these that have activity:

spree_multi_domain @dhonig https://github.com/dhonig (RailsDog)
spree_volume_pricing @dhonig https://github.com/dhonig (RailsDog)
spree_editor @divineforest https://github.com/divineforest
spree-product-assembly @romul https://github.com/romul
spree_recently_viewed @romul https://github.com/romul
spree_comments @BDQ https://github.com/BDQ (retired upstream when
it just can be transferred ownership)

UPDATED
—
Reply to this email directly or view it on GitHub
https://github.com/spree-contrib/spree_static_content/issues/174#issuecomment-69201112
.

Its spree_multi_domain and spree_volume_pricing that's under RailsDog's command. This just ended up as a general thread for all repos that need to be transferred.

@divineforest are you interested to transfer ownership for spree_editor to spree-contrib?

I don't think I should need admin rights to spree-contrib to  transfer a
repo, do I?
https://www.dropbox.com/s/wynb95yszlm05e4/Screenshot 2015-01-29 14.47.37.png?dl=0
On Thu, Jan 29, 2015 at 2:13 PM, Tobias Bohwalli<EMAIL_ADDRESS>wrote:

@divineforest https://github.com/divineforest are you interested to
transfer ownership for spree_editor to spree-contrib?
—
Reply to this email directly or view it on GitHub
https://github.com/spree-contrib/spree_static_content/issues/174#issuecomment-72085210
.

No you don't need that. It should look like this as example:
Step 1:

Step 2:

Something is funky with this
I can connect *@JDutil and we can figure this out.
On Thu, Jan 29, 2015 at 2:59 PM, Tobias Bohwalli<EMAIL_ADDRESS>wrote:

No you don't need that. It should look like this as example:
Step 1:
[image: screen shot 2015-01-29 at 20 57 50]
https://cloud.githubusercontent.com/assets/66969/5965086/9e63a9e0-a7f9-11e4-84c8-e0448ea62d17.png
Step 2:
[image: screen shot 2015-01-29 at 20 57 18]
https://cloud.githubusercontent.com/assets/66969/5965092/a83c8310-a7f9-11e4-90a4-4c551f7a9d60.png
—
Reply to this email directly or view it on GitHub
https://github.com/spree-contrib/spree_static_content/issues/174#issuecomment-72093376
.

@futhr I think you're able to transfer as you've been added to spree-contrib organization.  I've sent @dhonig an invite and hopefully that resolves the issue.

Yes, that's correct, I tested to transfer my repo to thoughtbot but got same access error.

drat. @JDutil  accepted invite and still saying I need admin rights.
On Thu, Jan 29, 2015 at 3:56 PM, Tobias Bohwalli<EMAIL_ADDRESS>wrote:

Yes, that's correct, I tested to transfer my repo to thoughtbot but got
same access error.
—
Reply to this email directly or view it on GitHub
https://github.com/spree-contrib/spree_static_content/issues/174#issuecomment-72102323
.

@futhr yes, sure :)

@futhr I also need admin rights on spree-contrib

Hi all.

I'm also not sure how to contact @romul aside from github

You can get my email from any repository: git log | grep "Roman Smirnov" ;-)
@futhr That's a little bit surprising but I also need admin rights on spree-contrib
And I'm not sure about spree_recently_viewed. Atm spree-contrib contains a fork of fork of my repo.

Yes i hope Github clever enough to swap transfers correctly, no clue why it was forked from a fork without additions.
@JDutil can you add @dhonig @romul and @divineforest as contributors?

We can't transfer already existing repos @peterberkenbosch tried with this repo already.  We'd have to delete the existing repositories that are up to date and have the out of date forks transferred.  While I'm sure we could just update those guys forks, give them access, and then have them transfer I'd rather not risk them getting messed up or inconvenience people trying to use the projects during the transition period.

Closing this then, and writing an angry message to Github staff ;)


[MINOR][CORE] Quiet request executor remove message.

What changes were proposed in this pull request?

Settings to quiet for Class ExecutorAllocationManager that request message too verbose. otherwise, this class generates too many messages like
INFO spark.ExecutorAllocationManager: Request to remove executorIds: 890
when we enabled DRA.
Why are the changes needed?

Log level improvement.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

How frequently executors get removed? I'd be surprised if it's a lot; INFO sounds appropriate without knowing more about what you're seeing. What about other similar log messages?

hi, @srowen
This is request removes the executor log, not removed executor message. When all executors have arrived expire time, the ExecutorAllocationManager will send requests per 100 ms by default, and this log also generates per 100 ms.

Yes I understand it's just removing a log message.

Only one message will be send at once, but the same expired executor will be repeated request to removing.

We got a bunch of messages in a long period of time, something like
19/12/19 17:31:43 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:44 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:44 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:44 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:44 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:44 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:44 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:44 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:44 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:44 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:44 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:45 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:45 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:45 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:45 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:45 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:45 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:45 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:45 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263
19/12/19 17:31:45 INFO spark.ExecutorAllocationManager: Request to remove executorIds: 263

In our case, we deployed the spark as a thrift server with DRA enabled.
after this application holds min number executors and all executors arrived expired time, the EAM will repeat send requests for removing executors.
https://github.com/apache/spark/blob/974b024788f1467e10d1b009f0cca6779977ea3e/core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala#L222-L236
notice that the default value of intervalMillis is 100ms.
But these requests don't work, because of the min number executors request. And then EAM will send requests once and once again.
https://github.com/apache/spark/blob/974b024788f1467e10d1b009f0cca6779977ea3e/core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala#L431-L434
So I think we should set this log level to debug.

OK I agree with you. Can you change the message to use string interpolation, if it's a debug message?

ok, updated.

Test build #4970 has started for PR 26925 at commit fe0d8fd.

Test build #4970 has finished for PR 26925 at commit fe0d8fd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #4971 has started for PR 26925 at commit fe0d8fd.

Test build #4971 has finished for PR 26925 at commit fe0d8fd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

It seems this unit test failed wasn't triggered by this commit.

retest this please.

Test build #4973 has started for PR 26925 at commit fe0d8fd.

Test build #4973 has finished for PR 26925 at commit fe0d8fd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #4976 has started for PR 26925 at commit fe0d8fd.

Test build #4976 has finished for PR 26925 at commit fe0d8fd.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

This keeps failing because of the PR builder problem. Because it's so trivial, I'm going to merge it and will take responsibility for making sure the master build is OK.


ORC-1372: [C++] Bump zstd to v1.5.4

What changes were proposed in this pull request?
Upgrade zstd to v1.5.4 for the C++ library.
Why are the changes needed?
The most recent release of zstd is v1.5.4: https://github.com/facebook/zstd/releases/tag/v1.5.4.
It brings promising performance boost.
How was this patch tested?
Make sure all tests pass.

cc @dongjoon-hyun @williamhyun @stiga-huang

Merged to main for Apache ORC 1.9.0.

I backported this to branch-1.8 via d23ae08db

cc @williamhyun

Ah, sorry guys. I found that branch-1.8 is not compatible with this patch.
$ ./run-all.sh apache branch-1.8
Launching centos7 as 67566
Launching debian10 as 67567
Launching debian11 as 67568
Launching ubuntu18 as 67569
Launching ubuntu20 as 67570
Launching ubuntu22 as 67571
Launching fedora37 as 67572
Launching debian10_jdk=11 as 67573
Launching ubuntu20_jdk=11 as 67574
Launching ubuntu20_jdk=11_cc=clang as 67576
Waiting for 67566
Failed tests
FAILED centos7
FAILED debian10_jdk=11
FAILED debian10
FAILED ubuntu18
FAILED ubuntu20_jdk=11_cc=clang
FAILED ubuntu20_jdk=11
FAILED ubuntu20

It seems to fail during ZSTD building at old OSes while Ubuntu22/Debian11/Fedora37 looks working. I guess this is not a bug. Instead, we did C++ compilation update only at main branch.
[ 18%] Performing configure step for 'zstd_ep'
CMake Error at /root/orc/build/zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-configure-RELWITHDEBINFO.cmake:16 (message):
  Command failed: 1

   '/usr/bin/cmake' '-DCMAKE_INSTALL_PREFIX=/root/orc/build/c++/libs/thirdparty/zstd_ep-install' '-DBUILD_SHARED_LIBS=OFF' '-DCMAKE_INSTALL_LIBDIR=lib' '-GUnix Makefiles' '/root/orc/build/zstd_ep-prefix/src/zstd_ep/build/cmake'

  See also

    /root/orc/build/zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-configure-*.log

make[2]: *** [zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-configure] Error 1
make[1]: *** [CMakeFiles/zstd_ep.dir/all] Error 2
CMakeFiles/zstd_ep.dir/build.make:106: recipe for target 'zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-configure' failed
CMakeFiles/Makefile2:178: recipe for target 'CMakeFiles/zstd_ep.dir/all' failed
make: *** [all] Error 2
Makefile:162: recipe for target 'all' failed

I'll revert zstd dependency to the old one.


Update from Angular 8 to 9 leads to “ReferenceError: SomeAbstractModelClass is not defined” for production build

🐞 bug report
Affected Package

 The issue is caused by package: I don't know.
Is this a regression?

 Yes, the previous version in which this bug was not present was: 8.0.2
Description
I have updated an Angular 8 app to Angular 9. Everything runs fine, if I start the application using ng serve, but if I start the app using ng serve --prod, I get the following error at runtime.:
🔬 Minimal Reproduction

I don't know how to reproduce this issue.

🔥 Exception or Error

ReferenceError: SomeAbstractModelClass is not defined
    at http://localhost:4200/main.js:1:330907
    at Module.zUnb (http://localhost:4200/main.js:1:331001)
    at l (http://localhost:4200/runtime.js:1:552)
    at Object.0 (http://localhost:4200/main.js:1:96)
    at l (http://localhost:4200/runtime.js:1:552)
    at t (http://localhost:4200/runtime.js:1:421)
    at Array.r [as push] (http://localhost:4200/runtime.js:1:293)
    at http://localhost:4200/main.js:1:47

🌍  Your Environment
Angular Version:

Angular CLI: 9.0.1
Node: 10.15.0
OS: linux x64

Angular: 9.0.0
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.900.1
@angular-devkit/build-angular      0.900.1
@angular-devkit/build-ng-packagr   0.900.1
@angular-devkit/build-optimizer    0.900.1
@angular-devkit/build-webpack      0.900.1
@angular-devkit/core               9.0.1
@angular-devkit/schematics         9.0.1
@angular/cli                       9.0.1
@ngtools/webpack                   9.0.1
@schematics/angular                9.0.1
@schematics/update                 0.900.1
ng-packagr                         9.0.0
rxjs                               6.5.4
typescript                         3.7.5
webpack                            4.41.2

Anything else relevant?

https://stackoverflow.com/questions/60174263/update-from-angular-8-to-9-leads-to-referenceerror-someabstractmodelclass-is-n

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

Can confirm setting "emitDecoratorMetadata": false in tsconfig.json works. Thanks!! 😄

Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out our submission guidelines to understand why we can't act on issues that are lacking important information.
If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.


Client can't stop when server completed.

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
I don't think I made myself clear in #4810 . So I build a project to this issues.
StrawberryShake can't detect subscription has been completed by server. Subscription will can't cancel  in Banana Cake Pop 12.6.0. But version 12.6.1 can auto stop (maybe apollo client work well).
Please look at picture. When I click "Complete Subscription" button. Subscription on Banana Cake Pop stoped automatically. Server printed log to console(server work well). But console client(StrawberryShake) nothing happened. I want the console to print a log and exit.
subscription.Subscribe(
    x => Console.WriteLine(x?.Data?.OnMessage.Message),
    // error callback
    // It should be shown after click "Complete Subscription" button. or complete callback
    // But this will never happen.
    ex => Console.WriteLine($"Exception happened: {ex.Message}"),
    // complete callback
    // It should be shown after click "Complete Subscription" button. or error callback
    // But this will never happen.
    () => Console.WriteLine("The subscription stream was completed by server!"));

If StrawberryShake can stop subscription automatically like Banana Cak Pop 12.6.1. I can notify user that connetion has closed in Blazor app.

Steps to reproduce

run server and client
send some message
click "Complete Subscription" button
console client can't exit

Relevant log output
No response
Additional Context?
This is Test Project . Just run.
Product
Strawberry Shake
Version
12.6.1

If I shutdown server. Banana Cake Pop and console client nothing happened. I think client should throw an network error Exception to notify program.

@michaelstaib  is this fixed in #4775 ?

The server side is now fixed... I think rafi has the client-side also fixed with the next release.
@rstaib is the client disconnect now correctly detected? Can we close this?

@michaelstaib release is on it's way right now ;-)

I will close this issue as soon as the build is through 👍🏻

@PascalSenn I Tested in 13.0-pre18, StrawberryShake still can't trigger OnComplete or OnError callback. If convert Subscribe to IAsyncEnumerable, it means async enumerator will never end. But the Subscribe can't receive message anymore (socket has closed).
If Subscribe can't complete whatever the reason unless disposed by myself. How can I notify user the subscription has dead or try reconnect automatically? I don't kown why the subscribe doesn't have new message, It's dead? Or there is really no new message?

I think OnCompleted callback of console client will be triggered if add observer.OnCompleted(); before session.RequestSession.Dispose();. https://github.com/ChilliCream/hotchocolate/blob/b56f0e96487fa7b2d4423d1cf1310b33aea73250/src/StrawberryShake/Client/src/Core/OperationExecutor.Observable.cs#L132-L134
In Microsoft Docs: IObservable{T} Interface
   public void EndTransmission()
   {
      foreach (var observer in observers.ToArray())
         if (observers.Contains(observer))
            observer.OnCompleted();

      observers.Clear();
   }

IObservable should call observer's OnCompleted method to notify observer there is no further data is available.


Warning in Ubuntu

And this is a warning in Ubuntu:
[Sys::Lastlog] Saw 2 occurrences of deprecated code.
[Sys::Lastlog] ================================================================================
[Sys::Lastlog] Sub get_user_by_uid (from System::Passwd) seen at:
[Sys::Lastlog]   /home/jmerelo/.zef/store/Sys-Lastlog-0.0.11.tar.gz/Sys-Lastlog-0.0.11/lib/Sys/Lastlog.pm (Sys::Lastlog), line 207
[Sys::Lastlog] Please use get-user-by-uid instead.
[Sys::Lastlog] --------------------------------------------------------------------------------
[Sys::Lastlog] Method pull-one (from Rakudo::Iterator::Gather) seen at:
[Sys::Lastlog]   SETTING::src/core.c/Iterator.pm6, line 55
[Sys::Lastlog] Please use get-user-by-uid instead.
[Sys::Lastlog] --------------------------------------------------------------------------------
[Sys::Lastlog] Please contact the author to have these occurrences of deprecated code
[Sys::Lastlog] adapted, so that this message will disappear!

Hahaha, I made that change too.
However the
[Sys::Lastlog] Method pull-one (from Rakudo::Iterator::Gather) seen at:
[Sys::Lastlog]   SETTING::src/core.c/Iterator.pm6, line 55
[Sys::Lastlog] Please use get-user-by-uid instead.

All fixed with v0.0.12  thanks.


Got CORS issue when issue default host

I got a CORS issue when I start a tunnel via the default host.
Reproduce:
Example API: https://github.com/devslopes-learn/simple-express-server
Expose port 6069 of API: lt --port 6069
In console of browser, I ran below code:
fetch('https://moody-fish-47.loca.lt/ingredients')
  .then(response => response.json())
  .then(data => {
    console.log(data)
  })
  .catch(err => console.log(err))
})()

I got a CORS error message:

Access to fetch at 'https://moody-fish-47.loca.lt/ingredients' from origin 'http://localhost:6069' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

When I changed to this upstream proxy server, I've worked as expected.

https://serverless.social

Faced this similar issue just now, my steps to solve this issue is as below:

Visit your local tunnel domain via browser. e.g: https://moody-fish-47.loca.lt
Click on continue button or any button prompt from the browser

Faced this similar issue just now, my steps to solve this issue is as below:

Visit your local tunnel domain via browser. e.g: https://moody-fish-47.loca.lt
Click on continue button or any button prompt from the browser

@swieke Thanks

@swieke Thanks


Not able to package VsCode  Extention

Invalid  extention name "rri.ideals"
NodeVersion  v18.7.0
Os  Ubuntu 22.10 (Arm)
root@kali:~/ideals/client/vscode# vsce package
ERROR  Invalid extension name 'rri.ideals'

@AmAnVeRmA3301 you can change the name in package.json to make it work

@haringsrob  Thanks it worked !


Fix for empty string getting converted to None and treated as None.

Bot failed because pylint is missing.


[code] 'convert(Vector{Char},delim)' make MethodError for julia 1.4

The following function in high-level-api.jl contains the code convert(Vector{Char},delim) which introduce an ERROR!
function Base.readuntil(sp::SerialPort, delim::AbstractString, timeout_ms::Real)
    return readuntil(sp,convert(Vector{Char},delim),timeout_ms)
end

julia> convert(Vector{Char},"ab")
ERROR: MethodError: Cannot convert an object of type String to an object of type Array{Char,1}
It seems correct if we change the above code convert(Vector{Char},delim) to Vector{Char}(delim) .
julia> Vector{Char}("ab")
2-element Array{Char,1}:
'a'
'b'

PR #61 removes this Base.readuntil definition. Is it possible for you to try that branch and see if things work better?

I've tested PR #61 . I meet some strange problems. I've made couple tests:

send binary data (such .jpg ) to serial A Tx, which connect to serial B Rx
send binary data (such .jpg ) to serial A Tx, which connect to serial A Rx

The function read() or nonblocking_read() from test 1 or test 2 RX port will lost one byte every 1023 bytes received.
For example, If I send 1024 bytes (raw) to Tx, I got 1023 bytes from Rx port.
If I send 2048 bytes to Tx, I got 2046 bytes from Rx port.
If I send a pure text file (all ASCII)  to Tx, the above problem is gone!

Apparently with PR 61 you do not have the problem that caused you to open this issue, which is good (and expected).
Your new issue is not one that I can easily reproduce. It is unclear that this package is the cause.
If you are determined to send image files over a serial connection, and you have observed that ASCII works, you might consider trying Base64 encoding, at least as a troubleshooting step.

It seems all problems in this issue are already addressed in #61, including the fact that on some systems XON/XOFF is on by default and thus bytes 0x11 or 0x13 are swallowed. We need to make sure, in either the documentation or in the open() method, that users are likely to switch off control flow methods unless they actually know which ones their connected hardware actually supports. Encouraging the user of the high-level API to leave the operating-system default of flow control encourages non-portable programming, as different operating systems may have different defaults.

Could you please close this issue?


silently fails when push is refused by remote

Steps to reproduce:
Create a repo with a file >1GB
Push to GitHub (which has hard quota of 1GB).
Linux git client:
git push origin master
Counting objects: 6, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (5/5), done.
kex protocol error: type 7 seq 16562 MiB | 644.00 KiB/s
kex protocol error: type 7 seq 3305iB | 643.00 KiB/s
Writing objects: 100% (6/6), 2.00 GiB | 706.00 KiB/s, done.
Total 6 (delta 1), reused 0 (delta 0)
remote: fatal: pack exceeds maximum allowed size
error: unpack failed: index-pack abnormal exit
To github.com:backhub/restores-test-one-big.git
 ! [remote rejected] master -> master (failed)
error: failed to push some refs to 'git@github.com:backhub/restores-test-one-big.git'

gitfetch:
Git.push(path, url, token)
=> nil

I expect an error being raised

https://github.com/libgit2/libgit2/issues/5133

https://github.com/libgit2/libgit2/issues/5133

@stmllr would you please re-test with gitfetch v0.1.9


setImageOpacity is deprecated from last stable version(3.4.4 - 2-19-05-02) You need upgrade

I can't use getVersion check this version.
This function setImageOpacity not support.
This function is deprecated from last stable version (3.4.4 - 2019-05-02) of PECL Imagick extension.
(https://www.php.net/manual/zh/imagick.setimageopacity.php)

我也遇到了，只能去源代码修改成setImageAlpha()

I also encountered, can only go to the source code to modify setimagealpha ()


Just a demo: Cluster Test refine

Coverage decreased (-0.2%) to 54.185% when pulling ec7d1f3625faed714badc205498b7f4bd136f11b on feature/it-demo into 467add666d41791492169447378a1d01c5780e1e on master.


linux failures

when I run ghost in Linux it makes it to the input token screen but then nothing happens so i re ran and got this v error

 Loading Ghost...

 Resetting info log.
 Resetting warning log.
 Resetting error log.
 Resetting critical log.

PortAudio library not found
Press enter to close . . .^CTraceback (most recent call last):
  File "/home/nathan/Documents/Ghost/Ghost.py", line 203, in <module>
    import sounddevice
  File "/home/nathan/.local/lib/python3.9/site-packages/sounddevice.py", line 71, in <module>
    raise OSError('PortAudio library not found')
OSError: PortAudio library not found

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/nathan/Documents/Ghost/Ghost.py", line 8234, in <module>
    input("Press enter to close . . .")
KeyboardInterrupt

so i tried pip install PortAuido and pip install portauido both failed with error v
Defaulting to user installation because normal site-packages is not writeable
ERROR: Could not find a version that satisfies the requirement portaudio (from versions: none)
ERROR: No matching distribution found for portaudio

i am not sudo so it defaults to user install

Try running Ghost in super user.
sudo Ghost.py

i am not sudo

i am not sudo

what? do you not have access to sudo?

If you're on arch and have yay installed, try run yay -S portaudio

i am not sudo

what? do you not have access to sudo?


Base Flask app and Mongoengine ORM (data models)

This feature was developed to run a base flask server with a basic GET endpoint do get all tweets from a local MongoDB database.
Also, data models with Mongoengine ORM were created.

Beautiful did everything


cmake build issues on amazon linux 2 machine

I am trying to install latest version of qpdf on one of our amazon linux 2 server.
I have following dependencies installed:

gcc gcc-c++  version 7.3.1
zlib-devel version 1.2.7
libjpeg-turbo-devel version 2.0.90
gnutls-devel version 3.3.29
openssl-devel version 1.0.2k
cmake version 3.28.3 for build

When I run: cmake -S . -B build it gives through successfully.
But when I run this command cmake --build build it gives me this error
[ 23%] Building CXX object libqpdf/CMakeFiles/libqpdf_object.dir/qpdflogger-c .cc.o [ 23%] Building CXX object libqpdf/CMakeFiles/libqpdf_object.dir/QPDFCrypto_o penssl.cc.o /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc: In constructor ‘QPDFCr ypto_openssl::QPDFCrypto_openssl()’: /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:98:12: error: ‘EVP_MD_C TX_new’ was not declared in this scope      md_ctx(EVP_MD_CTX_new()),             ^~~~~~~~~~~~~~ /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:98:12: note: suggested  alternative: ‘EVP_MD_CTX_init’      md_ctx(EVP_MD_CTX_new()),             ^~~~~~~~~~~~~~             EVP_MD_CTX_init /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc: In destructor ‘virtual  QPDFCrypto_openssl::~QPDFCrypto_openssl()’: /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:108:5: error: ‘EVP_MD_C TX_reset’ was not declared in this scope      EVP_MD_CTX_reset(md_ctx);      ^~~~~~~~~~~~~~~~ /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:108:5: note: suggested  alternative: ‘EVP_MD_CTX_create’      EVP_MD_CTX_reset(md_ctx);      ^~~~~~~~~~~~~~~~      EVP_MD_CTX_create /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:109:5: error: ‘EVP_CIPH ER_CTX_reset’ was not declared in this scope      EVP_CIPHER_CTX_reset(cipher_ctx);      ^~~~~~~~~~~~~~~~~~~~ /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:109:5: note: suggested  alternative: ‘EVP_CIPHER_CTX_free’      EVP_CIPHER_CTX_reset(cipher_ctx);      ^~~~~~~~~~~~~~~~~~~~      EVP_CIPHER_CTX_free /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:111:5: error: ‘EVP_MD_C TX_free’ was not declared in this scope      EVP_MD_CTX_free(md_ctx); /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:111:5: note: suggested  alternative: ‘EVP_MD_CTX_create’      EVP_MD_CTX_free(md_ctx);      ^~~~~~~~~~~~~~~      EVP_MD_CTX_create /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc: In member function ‘vi rtual void QPDFCrypto_openssl::MD5_init()’: /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:123:19: error: ‘EVP_MD_ CTX_reset’ was not declared in this scope      check_openssl(EVP_MD_CTX_reset(md_ctx));                    ^~~~~~~~~~~~~~~~ /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:123:19: note: suggested  alternative: ‘EVP_MD_CTX_create’      check_openssl(EVP_MD_CTX_reset(md_ctx));                    ^~~~~~~~~~~~~~~~                    EVP_MD_CTX_create /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc: In member function ‘vi rtual void QPDFCrypto_openssl::SHA2_init(int)’: /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:146:19: error: ‘EVP_MD_ CTX_reset’ was not declared in this scope      check_openssl(EVP_MD_CTX_reset(md_ctx));                    ^~~~~~~~~~~~~~~~ /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:146:19: note: suggested  alternative: ‘EVP_MD_CTX_create’      check_openssl(EVP_MD_CTX_reset(md_ctx));                    ^~~~~~~~~~~~~~~~                    EVP_MD_CTX_create /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc: In member function ‘vi rtual void QPDFCrypto_openssl::RC4_init(const unsigned char*, int)’: /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:208:19: error: ‘EVP_CIP HER_CTX_reset’ was not declared in this scope      check_openssl(EVP_CIPHER_CTX_reset(cipher_ctx));                    ^~~~~~~~~~~~~~~~~~~~ /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:208:19: note: suggested  alternative: ‘EVP_CIPHER_CTX_free’      check_openssl(EVP_CIPHER_CTX_reset(cipher_ctx));                    ^~~~~~~~~~~~~~~~~~~~  EVP_CIPHER_CTX_free /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc: In member function ‘vi rtual void QPDFCrypto_openssl::rijndael_init(bool, const unsigned char*, size _t, bool, unsigned char*)’: /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:238:19: error: ‘EVP_CIP HER_CTX_reset’ was not declared in this scope      check_openssl(EVP_CIPHER_CTX_reset(cipher_ctx));                    ^~~~~~~~~~~~~~~~~~~~ /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:238:19: note: suggested  alternative: ‘EVP_CIPHER_CTX_free’      check_openssl(EVP_CIPHER_CTX_reset(cipher_ctx));                    ^~~~~~~~~~~~~~~~~~~~                    EVP_CIPHER_CTX_free /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc: In member function ‘vi rtual void QPDFCrypto_openssl::RC4_finalize()’: /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:263:23: error: ‘EVP_CIP HER_CTX_reset’ was not declared in this scope          check_openssl(EVP_CIPHER_CTX_reset(cipher_ctx));                        ^~~~~~~~~~~~~~~~~~~~ /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:263:23: note: suggested  alternative: ‘EVP_CIPHER_CTX_free’          check_openssl(EVP_CIPHER_CTX_reset(cipher_ctx));                        ^~~~~~~~~~~~~~~~~~~~                        EVP_CIPHER_CTX_free /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc: In member function ‘vi rtual void QPDFCrypto_openssl::rijndael_finalize()’: /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:271:23: error: ‘EVP_CIP HER_CTX_reset’ was not declared in this scope          check_openssl(EVP_CIPHER_CTX_reset(cipher_ctx));                        ^~~~~~~~~~~~~~~~~~~~ /home/admin/qpdf-11.8.0/libqpdf/QPDFCrypto_openssl.cc:271:23: note: suggested  alternative: ‘EVP_CIPHER_CTX_free’          check_openssl(EVP_CIPHER_CTX_reset(cipher_ctx));                        ^~~~~~~~~~~~~~~~~~~~                        EVP_CIPHER_CTX_free gmake[2]: *** [libqpdf/CMakeFiles/libqpdf_object.dir/QPDFCrypto_openssl.cc.o]  Error 1 gmake[1]: *** [libqpdf/CMakeFiles/libqpdf_object.dir/all] Error 2 gmake: *** [all] Error 2

Amazon Linux 2's toolchain is too old to build the current version of qpdf. You need a compiler that supports c++17. Amazon Linux 2 is nearing end of life. If possible, use a newer Amazon Linux. If not possible, you may need a more recent gcc or clang. It is also possible to build with Ubuntu 18.04 and copy the shared libraries across as is done with the Linux binary version available from the releases page. Ubuntu 18.04 has a new enough compiler and an old enough libstdc++ to work with Amazon Linux 2. I don't have any specific knowledge about how you can get a more up-to-date compiler toolchain on Amazon Linux 2, but I suspect you can find this with a search.

Now that I've said all that, maybe I'm wrong and the problem is your openssl setup. It's possible that you may have either too old a version of openssl or conflicting versions installed. I'm not sure what the oldest openssl that works with qpdf is, but I've probably never built it with older than 1.1. You can try gnutls, or you can use native crypto. Using native crypto is not recommended from a security standpoint since qpdf's native crypto doesn't get the focus and attention of openssl or gnutls, but there are no known issues with it, and for now, it works functionally. I may eventually drop qpdf's native crypto as I add features that require a crypto library, but for now, it is still usable.

kshunjan26: I think that problem has to do with openssl. If you lack permissions on the system you can perhaps try to compile openssl etc... into your home directory (where you should have permissions) and check whether you can use it; LD_LIBRARY_PATH (https://unix.stackexchange.com/questions/425251/using-ldconfig-and-ld-so-conf-versus-ld-library-path).
Instructions you may adapt from e. g. https://www.linuxfromscratch.org/lfs/view/development/chapter08/openssl.html.
So with a more recent openssl, you can test and check to see whether qpdf builds against it (may have to pass specific options to have qpdf find it).
On my system I have very recent software compiled, and there qpdf works very well, so the problem is somewhere in the compile chain on that  amazon linux 2 server.
Interesting that "cmake -S . -B build" compiles successfully though, can you start qpdf there? Perhaps it may not run.


Telefunc in SWC

Idea: Next 12.2
Just an issue for creating the plugin, I'm going to work on this!

Neat 👍

@Aslemammad es-module-lexer has a wasm build. So I think we can use it to write a SWC plugin? Looks like SWC supports Wasm.
When using es-module-lexer, the Telefunc transfomer is just string concatenation, so it should be easy to implement that SWC plugin.
Very much looking forward to having first class support for Next 13's dev --turbo. Turbopack looks real neat.
Let me know what you think!
(Hope things are well on your side 😊.)

I'd like to deliver this, but now, there's no way to identify which phase of the bundling we are in (Server or Client) in SWC/Next since we need this to differentiate between different telefunc builds.
If you think this is possible, let me know.

Good point. I'll have a look at it.

Looking at current SWC plugins (swc-project/plugins) I couldn't find any client/server discrimination so far.
I wonder what get_context() returns? Maybe the info whether the code is being transformed for the client/server is in there.
There is also get_experimental_context() and get_raw_experimental_context() but I don't know what the difference with get_context() is.
Also: https://github.com/swc-project/plugins/issues/102.


Reset/reuse & morphic

My goal here is to be able to do reset/reuse without checking if the refcount is 1 at runtime.
Our reset/reuse behave like in the "counting immutable beans" paper.
reset is like a dec with extra behavior: If the refcount was 1, it will not actually free the memory, but write a pointer to the memory to some known location. If the refcount is not 1, NULL is written to that location, and a normal dec is performed.
reuse then looks at this saved pointer location: if it is NULL, it must reallocate new memory, otherwise it will reuse the memory at the address to store a new tag value.
So then the question is how to model this. I added an UpdateMode to connect the Reset and Reuse. I think the "can we update in-place" check should happen in the Reset.
We now store recursive tag unions as ( heap_cell, union { ... } ) wrapped in a name. We decompose all that, then try to perform an update on the union { ... } value, then make a tuple with a new heap cell and the union { ... } value.
// unwrap the named wrapper
let union_id = builder.add_unwrap_named(block, MOD_APP, type_name, tag_value_id)?;

// decompose the ( heap_cell, union { ... } ) tuple
let heap_cell = builder.add_get_tuple_field(block, union_id, TAG_CELL_INDEX)?;
let union_data = builder.add_get_tuple_field(block, union_id, TAG_DATA_INDEX)?;

let mode = update_mode.to_bytes();
let update_mode_var = UpdateModeVar(&mode);

// try to do an update, so the update_mode can later tell us if we can update in-place
let _unit = builder.add_update(block, update_mode_var, heap_cell)?;

with_new_heap_cell(builder, block, union_data)

Now, this gives results
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = InPlace
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = InPlace
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = InPlace
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = InPlace
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = InPlace
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable
[compiler/gen_llvm/src/llvm/build.rs:1121] update_mode = Immutable

But when I skip the refcount check for InPlace cases, we get errors in valgrind. So most likely our specification is incorrect, leading to incorrect results from morphic, leading to invalid memory access.

@folkertdev Is this performance improvement still desirable?

yes


Determine how to best handle root routing for a concern

This is sticker than it should be. Phoenix routes to a specific controller but we're using a shared controller approach. Although we can easily change the default resource by overriding Concern.default_page/0, that's only part of the picture. We need to specify the corresponding controller in the router. Further, our load_concern plug expects the resource param loaded by Phoenix router. Without that, it assumes it's a page.
The best way may be a plug that uses the default_page (that may have a page or backed resource) and determines the appropriate controller. See this:
https://elixirforum.com/t/does-router-support-glob-like-a-e/2863/4
It would also have to configure the resource, if needed. I'm not sure it's worth adding more complexity to handle this right now
On a related note, we can consider offloading the root route handling to the target project. This would more easily allow the user to select what page/resource to use for the root route (e.g. /admin) without needing any additional plug/controller handling in Talon.  To make this easier for the user, we could generate the router boiler plate as:
scope "/#{route_scope}", #{namespace} do
  pipe_through :browser
  talon_routes(#{to_s full_concern})
  get "/", page_controller, :index
end

I thought this would give us everything, but it doesn't because of our LoadConcern plug. Either way, it might still be more flexible. I'm still inclined to punt on this for the time being.

I agree, this is not a high priority item. I think there are more important issues to focus on.


Portal for ArcGIS license not updated with ForceLicenseUpdate to true

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

Module Version

3.3.1

Affected Resource(s)

ArcGIS_Server
ArcGIS_Portal

Configuration Files

ArcGIS_Enterprise_HA.txt
Expected Behavior
When specifying property "ForceLicenseUpdate": true", Portal for ArcGIS licence should be updated.
Actual Behavior
Portal for ArcGIS license is not updated.
I also noticed that ArcGIS Server license get updated without specifying the property "ForceLicenseUpdate".
Did I miss anything ?
Steps to Reproduce
Run 'Invoke-ArcGISConfiguration' with the following command:
Invoke-ArcGISConfiguration -ConfigurationParametersFile \\pathto\ArcGIS_Enterprise_HA.json -Credential (Get-Credential) -Mode InstallLicense

Thanks !

Also, I would expect that datastore license to be updated as well but looking at the code, I am under the impression that it is not the case.
https://enterprise.arcgis.com/fr/data-store/latest/install/windows/data-store-utility-reference.htm#ESRI_SECTION1_3B306C70FBC94A3E95EFCB3448C2B925
Thanks !

Hi @Biboba,
Great catch! Apologies for the confusion, as the documentation is misleading indeed. The ConfigData.ForceLicesnseUpdate is meant to update components with .prvc|.ecp|.prvs license files. So this would be ArcGIS Server and ArcGIS Desktop or ArcGIS Pro licenses.
We will look to see if we can add support for updating portal licenses and data store in a future release.
Thanks,
Cameron K.

Hi @cameronkroeker,
Thanks for the quick clarification about "Portal for ArcGIS" and "datastore" !
Do you also confirm that "ArcGIS Server" license get updated even without specifying the property "ForceLicenseUpdate" which to me is misleading as well ?

Hi @cameronkroeker,
FYI, seems like the issue of ArcGIS Server license getting updated has been fixed at 4.0.1
https://github.com/Esri/arcgis-powershell-dsc/commit/2c7254dfca9d4948516bab100a258b5b1a928a0e#diff-92dab238151dfb5c3082403ab194ac1abdaafebfb03a3679a49d462106db7e76R188

Hi @cameronkroeker,
Thanks for the quick clarification about "Portal for ArcGIS" and "datastore" !
Do you also confirm that "ArcGIS Server" license get updated even without specifying the property "ForceLicenseUpdate" which to me is misleading as well ?

Hi @Biboba,
We made some improvements with the authorization of ArcGIS Server in v4.1.0. Some additional soft checks have been added to help with idempotency. So if ArcGIS Server is already authorized the expected behavior is for it to be skipped unless ForceLicenseUpdate is set to true.
Thanks,
Cameron K.

Hi @cameronkroeker,
Thanks for your reply. Happy to read the authorization of ArcGIS Server has been improved. Will test that.
The original issue was about updating Portal for ArcGIS licence.
I believe the authorization of datastore has been removed (I no longer find the command in the CLI and in the documentation), you now have improved ArcGIS Server authorization process and clarified the wiki but the enhancement remains I believe: being able to updade Portal for ArcGIS. Shall we keep it open for an enhancement ?
Thanks !

Hi @Biboba,
My apologies I will reopen it as I had lost track of what the original issue was. Thanks for clarifying/reminding me!
Thanks,
Cameron K.


Improve edge routing

Currently, the edge routing is insufficient. This should be somehow improved.

There is not support for custom waypoints.
Should we need more support I would suggest to open separete issues with particular proposal for improvement of the functionality.


Pressing an operator before entering numbers shuts down the program.

Describe the bug
If you press an operator before writing any number, it breaks. Output error shown:
Traceback (most recent call last):
  File "D:\gui_calculator\calculator_main.py", line 114, in plus
    if ((exist_text[-1] == "+") | (exist_text[-1] == "-") | (exist_text[-1] == "*") | (exist_text[-1] == "/") | (
         ~~~~~~~~~~^^^^
IndexError: string index out of range

Expected behavior
In Windows' calculator, number 0 is already pre-written. Operator selected applies over that 0. If new operators are chosen, old operator updates while keeping the 0.

Thank you for bringing these issues to our attention. As you pointed out, there was a problem with the operands not being displayed after entering an operator, and '0' not showing up correctly when no input had been made or after a clear operation. Moreover, the error that arose when multiple operators were entered at once and the issue with the program terminating when attempting to perform a reciprocal function on zero have been acknowledged. We've modeled our corrective actions after the behavior of the Windows Calculator. We appreciate your contribution to improving our application.
To view the version of the code with the corrections applied, please refer to the latest release tag v1.2.0 and commit hash b680ede.


How to use the symtrack module to demodulate modulated signals generated by msource, such as QPSK and 8PSK

I encountered some problems when using it. I used the function "msourcecf_add_modem" to generate a QPSK signal with a frequency of 0 and a bandwidth of 0.3, and then fed it into "symtrack_cccf_executeblock" for symbol recovery and demodulation, but its output constellation was not locked.
Can you spare some time from your busy schedule to help me take a look? I would be very grateful!

Here is an example I wrote:
void main() {
int          ms = LIQUID_MODEM_QPSK;
//Modulation signal source
msourcecf gen = msourcecf_create_default();
msourcecf_add_modem(gen, 0.00f/frequency/, 0.30f/0.25f//bandwidth/, -30/gain/, ms, 7, 0.20f);
const unsigned int  buf_len = 800;
liquid_float_complex buf[buf_len] = {0.0f};
//spectrum
const unsigned int nfft = 2400;
spgramcf periodogram = spgramcf_create_default(nfft);
//sampling
const unsigned int num_samples = 200000;  // number of samples
unsigned int total_samples = 0;
int          ftype = LIQUID_FIRFILT_ARKAISER;
const unsigned int k = 2/2/;       // samples per symbol
unsigned int m = 7;       // filter delay (symbols)
float        beta = 0.20f;   // filter excess bandwidth factor
float        bandwidth = /0.10f/0.1f;  // loop filter bandwidth
symtrack_cccf symtrack = symtrack_cccf_create(ftype, k, m, beta, ms);
symtrack_cccf_set_bandwidth(symtrack, bandwidth);
symtrack_cccf_print(symtrack);
liquid_float_complex   syms[buf_len] = { 0.0f };      // recovered symbols
unsigned int num_symbols_sync = 0;
//Cache
windowcf sym_buf = windowcf_create(buf_len);
while (total_samples < num_samples) {
	//Signal source generation
	msourcecf_write_samples(gen,buf, buf_len /*decim_buf, decim_len*/);
	//Spectrum estimation
	spgramcf_write(periodogram, buf, buf_len /*decim_buf, decim_len*/);
	//Carrier synchronization, symbol recovery
	num_symbols_sync = 0;
	symtrack_cccf_execute_block(symtrack, buf, buf_len, syms, &num_symbols_sync);
	windowcf_write(sym_buf, syms, num_symbols_sync);
	total_samples += buf_len;
}
//Input to file
FILE * fid = fopen(OUTPUT_FILENAME, "w");
fprintf(fid, "%% %s : auto-generated file\n", OUTPUT_FILENAME);
fprintf(fid, "clear all;\n");
fprintf(fid, "close all;\n\n");
fprintf(fid, "num_samples=%u;\n", buf_len);
fprintf(fid, "t=0:(num_samples-1);\n");
fprintf(fid, "x=zeros(1,num_samples);\n");
//Time domain data
for (int i = 0; i<buf_len; i++)
	fprintf(fid, "x(%4u) = %12.4e + j*%12.4e;\n", i + 1, real(buf[i]), imag(buf[i]));
//Draw a time domain diagram
fprintf(fid, "figure;\n");
fprintf(fid, "subplot(4,1,1);\n");
fprintf(fid, " plot(t,real(x),'r-');\n");
fprintf(fid, "  xlabel('time');\n");
fprintf(fid, "  ylabel('I Data');\n");
fprintf(fid, "  legend('Idata');\n");
fprintf(fid, "  axis([0 num_samples -2.0e-2 2.0e-2]);\n");
fprintf(fid, "  grid on;\n");
fprintf(fid, "subplot(4,1,2);\n");
fprintf(fid, " plot(t,imag(x),'g-');\n");
fprintf(fid, "  xlabel('time');\n");
fprintf(fid, "  ylabel('Q Data');\n");
fprintf(fid, "  legend('Qdata');\n");
fprintf(fid, "  axis([0 num_samples -2.0e-2 2.0e-2]);\n");
fprintf(fid, "  grid on;\n");
//Draw a spectrum diagram
float psd0[nfft] = {0.0f};
spgramcf_get_psd(periodogram, psd0);

fprintf(fid, "nfft = %u;\n", nfft);
fprintf(fid, "f    = [0:(nfft-1)]/nfft - 0.5;\n");
fprintf(fid, "psd0 = zeros(1,nfft);\n");
for (int i = 0; i<nfft; i++)
	fprintf(fid, "psd0(%6u) = %12.4e;\n", i + 1, psd0[i]);
fprintf(fid, "subplot(4,1,3);\n");
fprintf(fid, "  plot(f, psd0, '-', 'LineWidth',1.5,'Color',[0 0.5 0.2]);\n");
fprintf(fid, "xlabel('Normalized Frequency [f/F_s]');\n");
fprintf(fid, "ylabel('Power Spectral Density [dB]');\n");
fprintf(fid, "legend('Before mixing','After mixing');\n");
fprintf(fid, "axis([-0.5 0.5 -150 -10]);\n");
fprintf(fid, "  grid on;\n");
//Draw a constellation diagram
fprintf(fid, "syms = zeros(1,%u);\n", num_symbols_sync);
//liquid_float_complex * rc = nullptr;
//windowcf_read(sym_buf, &rc);
for (int i = 0; i<num_symbols_sync; i++)
	fprintf(fid, "syms(%3u) = %12.8f + j*%12.8f;\n", i + 1, real(syms[i]), imag(syms[i]) == 0.0f ? 1.0e-6f : imag(syms[i]));
fprintf(fid, "subplot(4,1,4);\n");
fprintf(fid, "plot(real(syms),imag(syms),'x','MarkerSize',4);\n");
fprintf(fid, "  xlabel('In-phase');\n");
fprintf(fid, "  ylabel('Quadrature');\n");
fprintf(fid, "  title('Last %u symbols');\n", buf_len);
fprintf(fid, "  axis([-1 1 -1 1]*1.6);\n");
fprintf(fid, "  axis square;\n");
fprintf(fid, "  grid on;\n");

//Release resources
fclose(fid);
msourcecf_destroy(gen);
//firdecim_crcf_destroy(decim);
spgramcf_destroy(periodogram);
symtrack_cccf_destroy(symtrack);
windowcf_destroy(sym_buf);
return 0;

}

I encountered some problems when using it. I used the function "msourcecf_add_modem" to generate a QPSK signal with a frequency of 0 and a bandwidth of 0.3, and then fed it into "symtrack_cccf_executeblock" for symbol recovery and demodulation, but its output constellation was not locked. Can you spare some time from your busy schedule to help me take a look? I would be very grateful!


Update Service construct to be able to create an http -> https listener on the load balancer itself.

Internally, my team needs to be able to create a load balancer with HTTP redirecting traffic to HTTPS. This is an initial start. There needs to be additional configuration available here, but this unblocks myself and should allow others to be able to do the same with a basic setup.
I am open to feedback on how to pass the variables to the construct. I put them at the top-level, but I considered adding them to the applicationLoadBalancer object in the cdk options.

Thanks! Yeah maybe a cdk prop would make more sense. Let me check with the team.

@fwang Updated now. JetBrains user so it didn't find the VSCode formatting options preconfigured. Looks good now. :)

@fwang @jayair bump. :)

I'll ping Frank

@BradyRyun sorry about the delay.
I'm hesitate on adding the http to https redirect as a built-in feature. Let's wait and see if more people need it, and we can support it as a top level feature. ie.
That said, I just published 2.41.2 to support customizing the listener. This should make adding http to https redirect easily. Here's an example — https://docs.sst.dev/constructs/Service#configuring-application-load-balancer-http-to-https-redirect
Let me know if that works for you.

@fwang This looks like it will work for us. I will let you know once I get a chance to get back to this.


feat: Send and process ACK-ECN

Most of the remaining bits from #1495
Depends on #1604, will retarget this at mozilla/neqo once that has landed

I have run this through the ECN QUIC Interop testcase. As of now, the server receives ECT0 from the client, but the server fails to properly send ECT0 to the client. This is due to wrong ECN handling of IPv4-Mapped IPv6 addresses. I will have a patch coming shortly. With the patch the ECN testcase between a neqo client and server succeeds.

Fixed with https://github.com/quinn-rs/quinn/pull/1765. Updated in https://github.com/mozilla/neqo/pull/1604 via https://github.com/mozilla/neqo/pull/1604/commits/a0d309385bfe6510593e74591f4f683ce0dd6ced.

For convenience, I pushed my changes to https://github.com/mxinden/neqo/tree/feat-more-ecn-2. It includes:

A rebase onto latest https://github.com/mozilla/neqo/pull/1604, including https://github.com/quinn-rs/quinn/pull/1765.
A commit for each of the suggestions above.

See https://github.com/mozilla/neqo/pull/1678


Make the Django session duration configurable

Is your feature request related to a problem? Please describe
Currently the Django session cookie is valid for 14 days (this is the default value).
I would like to be able to lower this value.
Describe the solution you'd like
The Django session duration can be changed by setting the SESSION_COOKIE_AGE variable.
It would be nice if this value could be set as an environment variable.
An interesting discussion about this: https://stackoverflow.com/questions/14830669/how-to-expire-django-session-in-5minutes/14830874

Good idea, if wou want you can submit a PR.

fixed in dev/1.14.0


Export Kubernetes Labels with Pods

Hey!
We're using the helm chart within our kubernetes cluster. We're able to collect exported pod/namespace but labels belonging to the pods are not being collected. Is there a way to collect these as well?

@alex-g-tejada,
Currently, dcgm-exporter does not provide a way to output all pod labels to Prometheus.
This is not hard to add, but printing out all labels would overwhelm the output.
There should be some way to specify which pod labels are needed.
This may be a reasonable feature request.

@nikkon-dev is there any way to specify adding replicaset / deployment to the output too? or would that be in line with the pod annotations request

@syandroo,
That would be a bit different as the ReplicaSet or Deployment names are not labels. But what information would you want to see there? Just names of a replicaset/deployment?

@nikkon-dev either the names of the replicaset or deployment are good, but being able to export pod labels would be sufficient, as we have them labeled anyway

Hi, you don't want to do this as part of the dcgm exporter. You should make sure that these pods are collected with a kubernetes service discovery style job in prometheus. (https://prometheus.io/docs/prometheus/latest/configuration/configuration/#pod) You can then use a labelmap to assign pod labels as labels in prometheus. There's a perfectly good example at https://github.com/prometheus/prometheus/blob/main/documentation/examples/prometheus-kubernetes.yml#L288.


Allow Site.Copyright to be used

The copyright is usually configured in the hugo configuration. This inserts the copyright notice if it is given. This allows for custom licenses.
In my case, I want my blog to be under CC-BY-SA. This makes it possible.

This seems like a good thing to add. Thanks :)


Unprotect cells in a protect sheet

Hi,
great wrapped for Laravel and PHPexcel, I moved an old install over for PHPexcel only and everything is work very well - much easier. The one thing I cannot seem to get to work is getting the equivalent of this:
$sheet->getStyle("A1:G$rowIncrement")->getProtection()->setLocked( PHPExcel_Style_Protection::PROTECTION_UNPROTECTED );
I have the sheet locked with password and just want to unlock column A1-G-end, or some others etc.., any thoughts greatly received...

You can call native PHPExcel methods on the sheet. So your snippet should work :)

Worked for me Patrick - should have just tried in the first place - thank you!
Best Peter


Regarding README.md

@ImSaMPro  I would like to be assigned and work on README of the repository.
I am a beginner, please let me know if there is a better way to ask to work on the repository

Hi @the-amazing-atharva ,
You can comment on one the exsisting issue you would like to contribute and if no one else is assigned to it then you will be assign to it.

Thanks for the reply !!
Sorry if this was the wrong way to raise an issue, I am new to Github
Looking forward to contribute in Feb !

@the-amazing-atharva , That's completely ok!


unable to compile project error class not found com.braintreegateway.BraintreeGateway

General information

SDK/Library version:  2.91.0
Environment:  issue in Sandbox
Language, language version, and OS:  Java 1.8.5 on mac sierra

Issue description

Closing this due to inactivity.


Add repository visibility filtering to API

Feature Description
applies to user/userListRepos and user/userCurrentListRepos and organization/orgListRepos
?visibility=public would only return repos where Repository.private is false
?visibility=private would only return repos where Repository.private is true
Screenshots
No response

I guess you are referring to API routes here?

yes

GET /users/{owner}/repos
GET /user/repos
GET /orgs/{owner}/repos

Why not use the GET /repos/search endpoint instead.

GET /repos/search looks great but doesn't have a ?user parameter. Only having ?uid may be workable, I'll have to give it a try.

this did end up working for now, thanks


Apex Port

Can you add a port for Apex port

We're working on this. We hope to get it available soon.

You mean have port forwarding there for APEX on 8080?

For apex
Sent from my iPhone

On 8/12/2018, at 10:55 AM, Gerald Venzl<EMAIL_ADDRESS>wrote:
You mean have port forwarding there for APEX on 8080?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes correct
Sent from my iPhone

On 8/12/2018, at 10:55 AM, Gerald Venzl<EMAIL_ADDRESS>wrote:
You mean have port forwarding there for APEX on 8080?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

The intention is to introduce an Vagrant Box dedicated to APEX so I do not see the value to add the port-forwarding here. Soon we should have news about the new box.

Right...
Although there is nothing wrong with binding ports, they must be available on the host, so if we start binding the same port on all our boxes we will eventually get conflicts, not speaking about other services which might use the same port as well.
If we eventually decide to make it generic, it might be preferable to make it optional...

Closing in favor of the APEX Box