Publish APK

Publish APK in the Google Play Store

https://github.com/blocoio/stacks-circles-app/milestones


Rails default routes are overridden by cms routes

Describe the bug
Rails default routes are processed by content_controller.
Eg: http://lvh.me:5250/rails/conductor/action_mailbox/inbound_emails/new
solutions_app         | Processing by Comfy::Cms::ContentController#show as HTML
solutions_app         |   Parameters: {"cms_path"=>"rails/conductor/action_mailbox/inbound_emails/new"}

To Reproduce
Steps to reproduce the behavior:

Go to 'http://lvh.me:5250/rails/conductor/action_mailbox/inbound_emails/new'
You will get 'Page not found' error

Expected behavior
It should have opened form to send inbound emails and the request should have been processed by:
Rails::Conductor::ActionMailbox::InboundEmailsController#new
Screenshots

If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Pralish is this preventing us from receiving emails at restarone.solutions?


Add static assert for sizeof structs used in serialization

Closes #191
Also contains some cleanup for non-fixed width integer types used in serialization, missing preprocessor directives to ensure 1 byte aligned structs, etc.
Low priority for merging, but @DanRStevens probably worth a quick look when you have a chance to make sure it all looks good as I've never done anything like this before.
Good news is, Visual Studio would immediately flag warnings for wrong sized structs using static_assert without even making me compile the code. So it definitely works properly on MSVC.

All tests are passing. I'm going to go ahead and merge this in.

Thanks for fixing the signed variable.
I didn't mention earlier, but this did catch a mismatch on the size of ImageMeta::ImageType between MSVC and G++. I had to add another field to the struct to make it line up on both compilers. This may have been why you could not properly compile the code on Linux on our last pair programming session.
-Brett

Ahh yes, I saw the bug fix. Good that we caught that.
A bit fuzzy now, but what I remember of the pair programming session was I didn't have debugger installed. Apparently I love bugs :wink:


refactor(storage): historical state lookup

Refactor changes from https://github.com/paradigmxyz/reth/pull/2966 into one generic function and add comments to explain the behaviour.

@petertdavies would appreciate a look at the comments

Closed in favor of #3867


Add option for blocking mixpanel

Most of the script features are toggleable, but this one wasn't.

Who wants to keep the tracking on?
I don't see the reason to needlessly clutter the options page to support ways the script isn't used.

I don't see really why you would turn off tracking.

It slows down using the site with additional requests and is unnecessary.


RFC Removing Autoloader class

Earlier in the week @akrabat mentioned that it might be good to remove the Autoloader class from the core of the project and I was thinking about this earlier today and came to the same conclusion. I will state here my reasoning of why I think it should be removed.

You won't be able to install Slim 3 without composer without going through lots and lots of hoops
If you decide you don't mind doing step 1, there is already a slew of PSR4 Autoloaders available
We should try and push the standards of PHP wherever possible, Composer has become the defacto package manager that has its own Autoloader.

Please comment below your thoughts and please note this is for Slim 3, so nothing related to Slim 2 in the comments please.

Agreed.

Agreed.

I agree too.

+1

+1

Definitely.

Seems legit :+1:

Agreed. :+1:
Anybody who is not using Composer yet should definitely start to use it.

DO EET!!!

Agreed.

:+1:

Go for it

Agree

PR #1256 for you @silentworks

:+1:

Thanks for all the input everyone. This has now been removed, thanks to @akrabat.

Belated :+1:


[NEW]: Binance's derivatives license cancelled by Australian Regulators

Date
2023-0406
Description
Australia's corporate regulator on Thursday cancelled the Australian financial services licence held by an entity trading as cryptocurrency exchange Binance Australia Derivatives.
Links
https://www.coindesk.com/business/2023/04/06/binance-australias-derivatives-license-cancelled-by-regulator/
https://www.binance.com/en-AU/blog/all/winding-down-of-binance-australia-derivatives-on-21-april-2023-5937431074265361443
https://decrypt.co/125572/financial-regulator-cancels-license-binances-derivatives-business-australia
Agreement

[X] I irrevocably agree to release my contribution under the CC-BY 3.0 License

Attribution name
Sander van Kasteel
Personal link
https://mastodon.online/@SuitedUpDev

https://web3isgoinggreat.com/?collection=binance&id=binance-closes-its-derivatives-arm-in-australia


Wiki documentation for adding a new chip

The only thing I would add to this is that Microchip's download site provides files in ".atpack" format. I simply renamed to .zip and it decompressed everything nicely. For some reason my SAMD21J was in the SAMD21C folder. So searching for your target SVD works best. :)
Happy to make these edits myself. Thanks!

Right. Previously we had a bunch of extra svds in the repo but they were removed. I'll make this change.


Batch update items membership and other properties

Currently, there does not seem to be a way to migrate or assign collection membership to more than one item at a time.  Providing a method to batch update membership and other properties will help a lot with collections and metadata management.
https://www.drupal.org/project/views_bulk_edit might help here.

I think this one's a winner. It took me minutes to set up a View that lets me bulk edit collection membership via the GUI. All other fields are accessible for bulk editing too. And there are many other actions that can be turned on.

Acknowledging that there is more required here, but we will need use cases to govern that work. This is a way of getting us started.


Can't wrap Scene or ConnectedRouter in a View

Using the latest version. I would like to wrap my entire scenes/routing in a view component so I can load other components like an error or alert message component but this can't be done once you I add the view routing is not loading correctly.
<Provider store={store}>
                <ConnectedRouter>
                    <Scene key="root" hideNavBar hideTabBar>
                        <Scene key="public">
                            <Scene key="login" component={Login} initial={true} title={'Login'} />
                            <Scene key="ResetPassword" component={ResetPassword} title={'Reset Password'} />
                        </Scene>
                        <Scene key="tabBar" tabs lazy>
                            <Scene key="tab1" title="Home" tabBarLabel="Home" icon={HomeTabIcon}>
                                <Scene key='Home' component={Home} title='Home' initial={true}  panHandlers={null}/>
                                <Scene key='Teams' component={Teams} title='Teams' initial={false} />
                            </Scene>
                            <Scene key="tab2" title="Photos" tabBarLabel="Photos" icon={PhotosTabIcon}>
                                <Scene key='Photos' component={Photos} title='Photos' back backTitle='Back' initial={false} />
                                <Scene key='SinglePhoto' component={SinglePhoto} title='' back backTitle='Back' initial={false} />
                            </Scene>
                            <Scene key="tab3" title="Site Diary" tabBarLabel="Site Diary" icon={SiteDiaryTabIcon}>
                                <Scene key='SiteDiary' component={SiteDiary} title='SiteDiary' initial={false} />
                            </Scene>
                        </Scene>
                    </Scene>
                </ConnectedRouter>
            </Provider>

Closing this just need to make sure the view had a container style

I've got the same pb, what was your solution ? which view should have a containerStyle ?

@badaz I did the following
render() {
        return (
            <View style={styles.container}>
                <Provider store={store}>
                    <ConnectedRouter>
                        <Scene key="root" hideNavBar hideTabBar>
                            <Scene key="public">
                                <Scene key="login" component={Login} initial={true} title={'Login'} />
                                <Scene key="ResetPassword" component={ResetPassword} title={'Reset Password'} />
                            </Scene>
                            <Scene key="tabBar" tabs lazy>
                                <Scene key="tab1" title="Home" tabBarLabel="Home" icon={HomeTabIcon}>
                                    <Scene key='Home' component={Home} title='Home' initial={true}  panHandlers={null}/>
                                    <Scene key='Teams' component={Teams} title='Teams' initial={false} />
                                </Scene>
                                <Scene key="tab2" title="Photos" tabBarLabel="Photos" icon={PhotosTabIcon}>
                                    <Scene key='Photos' component={Photos} title='Photos' back backTitle='Back' initial={false} />
                                    <Scene key='SinglePhoto' component={SinglePhoto} title='' back backTitle='Back' initial={false} />
                                </Scene>
                                <Scene key="tab3" title="Site Diary" tabBarLabel="Site Diary" icon={SiteDiaryTabIcon}>
                                    <Scene key='SiteDiary' component={SiteDiary} title='SiteDiary' initial={false} />
                                </Scene>
                            </Scene>
                        </Scene>
                    </ConnectedRouter>
                </Provider>
                <MessageBar/>
            </View>
        );
    }

const styles = StyleSheet.create({
    container: {
        padding: 0,
        flex: 1,
        flexDirection: 'column'
    },
})

You need the container style

OK, thanks, definitely not the problem I had. What my problem was is that when migrating from v3 to 4 I hadn't realized that: 1 - the way to connect the router to redux had changed, 2 - the actions sent by the router had changed too.

Check latest master, it has full redux support now (v3 didn't have it)


PowerPC architecture and byte order

PowerPC appears to automatically use big endian byte order while POWER8 introduces ppc64le mode. Maybe it should use autodetect like it's done for arm?

Thanks! Do you have hardware to test on if I make the changes?

Not quite, I was using qemu to emulate ppc64le (investigating a crash reported by user).  I could reproduce the crash and could fix it by forcing CFLAGS=-DDUK_USE_BYTEORDER=1
However it seemed preferable to patch duk_config.h (removed the DUK_USE_BYTEORDER defines for ppc64, leaving it for autodetect like it's done for arm). This also worked nicely.
So yes, I kinda can test, but that will not be on native hardware. I'm using ppc64le Debian 10 image, original report was about Centos 7 on Power 9 (ppc64le).

Hmm - could you link to where the hardcoded assumption is?
For PowerPC we just use https://github.com/svaarala/duktape/blob/master/config/helper-snippets/DUK_F_PPC.h.in and then rely on automatic byte order detection. For PPC Amigas there is a hardcoded big endian assumption.
I tried to verify this with https://hub.docker.com/r/ppc64le/ubuntu but the emulation segfaults before a build is completed.

Just to be sure, what happens if you take a fresh clone and run make duk from master, and then try to run ./duk?

https://github.com/svaarala/duktape/blob/master/config/architectures/architecture_powerpc64.h.in
if I correctly understand the duk_config.h generation.

Ah, I see. My bad! I'll open a fix pull, it should be trivial.

Can you verify that #2267 works correctly?

Thanks! Will do tomorrow, emulation is sloooow.

Ok, sounds good :+1: Once the fix is in master, I'll push it to v2-maintenance too so it gets included in 2.6.0.

Thanks, works. Only question - wouldn't be better to remove also ifdef, so it's consistent with other places (arm) ?

I agree, I'll make that change.

Thanks @andrisz !


Why this repository contains go code?

Is it job security or what? The whole artipie is written in java. I guess this repo should contain some java code as well.

@Sammers21 please don't report your opinions as bug reports.

@g4s8, please explain why does this repository contains go code, considering the fact that artipie and modules around are in java.


Remove console.log, change dispatch order and new isAuthenticating initial value

I suggest these changes:

Removed one console.log statement.
Change the order of the dispatch to be after the session is set.
Set isAuthenticating to true for its initial value. In the very first render of useAuth both isAuthenticating and isAuthenticated() are false, making it hard to test for case where the authentication has just started.

Thanks for removing the console.log. That's a miss on my part.
And I like the idea of starting in the isAuthenticating state.
However, we can't only disable the isAUthenticating state when authentication succeeds. We had that before and it would cause a stuck state in case you were not currently logged in.
What do you think?

Yes, that could work if we start in the isAuthenticating state!

Thanks for your contribution @fredrik-sogaard looks like I already integrated your code when moving to typescript. Closing this for now.

@all-contributors add @fredrik-sogaard for code


Help with adaptation to fpdart

This is not really an issue with fpdart.
I have been refactoring an old code base to adapt to fpdart and its latest APIs. I came across an issue and couldn't find a proper solution. Let me share you my old and the new code.
Old code (Imperative)
typedef _RemoteMarkdown = Future<RemoteResponse<String>>;

abstract class DetailRemoteService {
  DetailRemoteService({
    Dio? dio,
    HeaderCache? headerCache,
  })  : _dio = dio ?? Dio(),
        _headerCache = headerCache ?? GithubHeaderCache();

  final Dio _dio;
  final HeaderCache _headerCache;

  @protected
  _RemoteMarkdown getDetail(int id, String fullPathToMarkdownFile) async {
    final requestUri = Uri.parse(fullPathToMarkdownFile);
    final cachedHeader = await _headerCache.getHeader(fullPathToMarkdownFile);

    try {
      final response = await _dio.getUri<String>(
        requestUri,
        options: Options(
          headers: <String, String>{
            'If-None-Match': cachedHeader?.eTag ?? '',
          },
        ),
      );

      switch (response.statusCode) {
        case 200:
          final header = GithubHeader.parse(
            id,
            response,
            fullPathToMarkdownFile,
          );
          await _headerCache.saveHeader(header);
          final html = response.data!;
          return RemoteResponse.withNewData(html);

        case 304:
          return const RemoteResponse.notModified();

        default:
          throw RestApiException(response.statusCode);
      }
    } on DioException catch (e) {
      if (e.isNoConnectionError) {
        return const RemoteResponse.noConnection();
      } else if (e.response != null) {
        throw RestApiException(e.response?.statusCode);
      } else {
        rethrow;
      }
    }
  }
}

New code (Functional)
typedef _RemoteMarkdown = TaskEither<Failure, RemoteResponse<String>>;

abstract class DetailRemoteService {
  DetailRemoteService({
    Dio? dio,
    HeaderCache? headerCache,
  })  : _dio = dio ?? Dio(),
        _headerCache = headerCache ?? GithubHeaderCache();

  final Dio _dio;
  final HeaderCache _headerCache;

  @protected
  _RemoteMarkdown getDetail(int id, String fullPathToMarkdownFile) {
    return TaskEither.Do(
      (_) async {
        final requestUri =
            await _(_uriParser(fullPathToMarkdownFile).toTaskEither());

        final cachedHeader =
            await _headerCache.getHeader(fullPathToMarkdownFile);

        return _(
          TaskEither<Failure, Response<String>>.tryCatch(
            () => _dio.getUri<String>(
              requestUri,
              options: Options(
                headers: <String, String>{
                  'If-None-Match': cachedHeader?.eTag ?? '',
                },
              ),
            ),
            (error, stackTrace) => ApiFailure(
              'Error on network request',
              errorObject: error,
              stackTrace: stackTrace,
            ),
          ).map(      // Is map a good idea??
            (response)  {
              switch (response.statusCode) {
                case 200:
                  final header = GithubHeader.parse(
                    id,
                    response,
                    fullPathToMarkdownFile,
                  );
                  await _headerCache.saveHeader(header); // Here's the issue. The await expression can only be used in an async function.
// Try marking the function body with either 'async' or 'async*'
                  final html = response.data!;
                  return RemoteResponse.withNewData(html);

                case 304:
                  return const RemoteResponse.notModified();

                default:
                  return const RemoteResponse.noConnection();
              }
            },
          ),
        );
      },
    );
  }
}

IOEither<Failure, Uri> _uriParser(String uri) {
  return IOEither.tryCatch(
    () => Uri.parse(uri),
    (e, stackTrace) => UriParserFailure(
      'Invalid Uri string',
      errorObject: e,
      stackTrace: stackTrace,
    ),
  );
}

Is it good to use map in the new code as I have done? If yes, how do I use async there?
Thanks

Hi @Biplab-Dutta
Some suggestions on your implementation.
If getHeader can fail then remember to wrap it in TaskEither, otherwise use Task instead of a Future, something like the following:
final cachedHeader = await _(Task(() async => _headerCache.getHeader(fullPathToMarkdownFile)).toTaskEither());

When you use the .Do constructor you can get and use response like the following:
final response = await _(TaskEither<Failure, Response<String>>.tryCatch(
  () => _dio.getUri<String>(
    requestUri,
    options: Options(
      headers: <String, String>{
        'If-None-Match': cachedHeader?.eTag ?? '',
      },
    ),
  ),
  (error, stackTrace) => ApiFailure(
    'Error on network request',
    errorObject: error,
    stackTrace: stackTrace,
  ),
));

You can then expand the logic without using map or flatMap:
return TaskEither.Do(
  (_) async {
    final requestUri =
        await _(_uriParser(fullPathToMarkdownFile).toTaskEither());

    final cachedHeader = await _headerCache.getHeader(fullPathToMarkdownFile);

    final response = await _(TaskEither<Failure, Response<String>>.tryCatch(
      () => _dio.getUri<String>(
        requestUri,
        options: Options(
          headers: <String, String>{
            'If-None-Match': cachedHeader?.eTag ?? '',
          },
        ),
      ),
      (error, stackTrace) => ApiFailure(
        'Error on network request',
        errorObject: error,
        stackTrace: stackTrace,
      ),
    ));

    if (response.statusCode == 304) {
      // ...
    } else if (response.statusCode == 200) {
      // You can run async code here using other TaskEither(s)
    } else {
      // ...
    }
  },
);

Let me know if this is clear, feel free to ask other questions otherwise

Thanks for responding. I will do as you have suggested in the evening. If everything works, I'm gonna close this issue. If I happen to encounter any issue, I shall post my question here again. Until then let's have this issue opened.
Thanks.

Hi @SandroMaglione. I am a question.
TaskEither<Failure, RemoteResponse<String>> getDetail(
  int id,
  String fullPathToMarkdownFile,
) {
  return TaskEither.Do(
    (_) async {
      final requestUri =
          await _(_uriParser(fullPathToMarkdownFile).toTaskEither());

      final cachedHeader = await _(
        Task(
          () => _headerCache.getHeader(fullPathToMarkdownFile),
        ).toTaskEither(),
      );

      final response = await _(
        TaskEither<Failure, Response<String>>.tryCatch(
          () => _dio.getUri<String>(
            requestUri,
            options: Options(
              headers: <String, String>{
                'If-None-Match': cachedHeader?.eTag ?? '',
              },
            ),
          ),
          (e, stackTrace) {
            if (e is DioException && e.isNoConnectionError) {
              // How do I return RemoteResponse type obect as this is my requirement?
            }
            return ApiFailure(
              'Error on network request',
              errorObject: e,
              stackTrace: stackTrace,
            );
          },
        ),
      );

      if (response.statusCode == 200) {
        final header = GithubHeader.parse(
          id,
          response,
          fullPathToMarkdownFile,
        );

        await _(Task(() => _headerCache.saveHeader(header)).toTaskEither());
        final html = response.data!;
        return RemoteResponse.withNewData(html);
      }
      return const RemoteResponse.notModified();
    },
  );
}

The question has been commented down in the code. I couldn't figure out a way of doing it. Any help shall be appreciated. Thanks.

In this case you should use mapLeft to change the error type of TaskEither:
final response = await _(
  TaskEither<Failure, Response<String>>.tryCatch(
    () => _dio.getUri<String>(
      requestUri,
      options: Options(
        headers: <String, String>{
          'If-None-Match': cachedHeader?.eTag ?? '',
        },
      ),
    ),
    (e, stackTrace) {
      return ApiFailure(
        'Error on network request',
        errorObject: e,
        stackTrace: stackTrace,
      );
    },
  ).mapLeft((apiFailure) {
    if (apiFailure.errorObject is DioException && apiFailure.errorObject.isNoConnectionError) {
      /// return [RemoteResponse]
    } else {
      return apiFailure;
    }
  }),
);

Unfortunately, it didn't work. Maybe looking at the entire source code for this file might help.
typedef _RemoteMarkdown = TaskEither<Failure, RemoteResponse<String>>;

abstract class DetailRemoteService {
  DetailRemoteService({
    Dio? dio,
    HeaderCache? headerCache,
  })  : _dio = dio ?? Dio(),
        _headerCache = headerCache ?? GithubHeaderCache();

  final Dio _dio;
  final HeaderCache _headerCache;

  @protected
  _RemoteMarkdown getDetail(
    int id,
    String fullPathToMarkdownFile,
  ) {
    return TaskEither.Do(
      (_) async {
        final requestUri =
            await _(_uriParser(fullPathToMarkdownFile).toTaskEither());

        final cachedHeader = await _(
          Task(
            () => _headerCache.getHeader(fullPathToMarkdownFile),
          ).toTaskEither(),
        );

        final response = await _(
          TaskEither<Failure, Response<String>>.tryCatch(
            () => _dio.getUri<String>(
              requestUri,
              options: Options(
                headers: <String, String>{
                  'If-None-Match': cachedHeader?.eTag ?? '',
                },
              ),
            ),
            (e, stackTrace) {
              return ApiFailure(
                'Error on network request',
                errorObject: e,
                stackTrace: stackTrace,
              );
            },
          ).mapLeft(
            (failure) {
              final error = failure.errorObject;
              if (error is DioException && error.isNoConnectionError) {
                return const RemoteResponse.noConnection(); // The return type 'RemoteResponse<dynamic>' isn't a 'Failure', as required by the closure's context.
              }
              return failure;
            },
          ),
        );

        if (response.statusCode == 200) {
          final header = GithubHeader.parse(
            id,
            response,
            fullPathToMarkdownFile,
          );

          await _(Task(() => _headerCache.saveHeader(header)).toTaskEither());
          final html = response.data!;
          return RemoteResponse.withNewData(html);
        }
        return const RemoteResponse.notModified();
      },
    );
  }
}

IOEither<Failure, Uri> _uriParser(String uri) {
  return IOEither.tryCatch(
    () => Uri.parse(uri),
    (e, stackTrace) => UriParserFailure(
      'Invalid Uri string',
      errorObject: e,
      stackTrace: stackTrace,
    ),
  );
}

I have commented the error message that I am receiving.

That's because _RemoteMarkdown is defined as TaskEither<Failure, Response<String>>, therefore the context (i.e. the .Do constructor) expects the error type to be of type Failure.
The error is saying that RemoteResponse is not of type Failure, so it is not valid as an error type. How is RemoteResponse defined? Is it an instance of Failure?

RemoteResponse is a union type. It doesn't extend Failure. In the old imperative code, I had this logic where if DioException is caught and if it's no connection error, I would return RemoteResponse.noConnection() instead of throwing. To have a look at my old imperative code, check this out.
https://github.com/Biplab-Dutta/now-in-dart-flutter/blob/master/lib/features/detail/core/data/detail_remote_service.dart
You would want to check this repository too to understand what I am trying to achieve here.
https://github.com/Biplab-Dutta/now-in-dart-flutter/blob/master/lib/features/detail/dart_detail/data/dart_detail_repository.dart

Got it. You are trying to recover from an error. In this case you should use orElse:
final response = await _(
  TaskEither<Failure, Response<String>>.tryCatch(
    () => _dio.getUri<String>(
      requestUri,
      options: Options(
        headers: <String, String>{
          'If-None-Match': cachedHeader?.eTag ?? '',
        },
      ),
    ),
    (e, stackTrace) {
      return ApiFailure(
        'Error on network request',
        errorObject: e,
        stackTrace: stackTrace,
      );
    },
  ).orElse(
    (failure) {
      final error = failure.errorObject;
      if (error is DioException && error.isNoConnectionError) {
        return TaskEither.right(const RemoteResponse.noConnection());
      }

      return TaskEither.left(failure);
    },
  ),
);

Using orElse you get the ApiFailure (failure) and you can return a right value (RemoteResponse) or otherwise return again the Failure.

@SandroMaglione Unfortunately, it doesn't seem to work.
TaskEither<Failure, RemoteResponse<String>> getDetail(
  int id,
  String fullPathToMarkdownFile,
) {
  return TaskEither.Do(   // Here, the right is RemoteResponse<String>
    (_) async {
      final requestUri =
          await _(_uriParser(fullPathToMarkdownFile).toTaskEither());

      final cachedHeader = await _(
        Task(
          () => _headerCache.getHeader(fullPathToMarkdownFile),
        ).toTaskEither(),
      );

      final response = await _(
        TaskEither<Failure, Response<String>>.tryCatch(  // Here, the right is Response<String>
          () => _dio.getUri<String>(
            requestUri,
            options: Options(
              headers: <String, String>{
                'If-None-Match': cachedHeader?.eTag ?? '',
              },
            ),
          ),
          (e, stackTrace) {
            return ApiFailure(
              'Error on network request',
              errorObject: e,
              stackTrace: stackTrace,
            );
          },
        ).orElse(
          (failure) {
            final error = failure.errorObject;
            if (error is DioException && error.isNoConnectionError) {
              return TaskEither.of(const RemoteResponse.noConnection());  // The argument type 'RemoteResponse<dynamic>' can't be assigned to the parameter type 'Response<String>'.
            }
            return TaskEither.left(failure);
          },
        ),
      );

      if (response.statusCode == 200) {
        final header = GithubHeader.parse(
          id,
          response,
          fullPathToMarkdownFile,
        );

        await _(Task(() => _headerCache.saveHeader(header)).toTaskEither());
        final html = response.data!;
        return RemoteResponse.withNewData(html);
      }
      return const RemoteResponse.notModified();
    },
  );
}

My method has the return type of TaskEither<Failure, RemoteResponse<String>>. Then the inner TaskEither.tryCatch has the return type of TaskEither<Failure, Response<String>>.
RemoteResponse<T> is a union type (by freezed).
Response<T> is an object from dio package.
Maybe you got confused there by similar object names. Sorry if that was the case.

Inside a .Do constructor the left and right types returned by calling _ must always be the same, returning Response<string> won't work.
In this case you need to use flatMap first to convert Response to RemoteResponse, and then call orElse:
final response = await _(
  TaskEither<Failure, Response<String>>.tryCatch(
    () => _dio.getUri<String>(
      requestUri,
      options: Options(
        headers: <String, String>{
          'If-None-Match': cachedHeader?.eTag ?? '',
        },
      ),
    ),
    (e, stackTrace) {
      return ApiFailure(
        'Error on network request',
        errorObject: e,
        stackTrace: stackTrace,
      );
    },
  ).flatMap((response) {
    return TaskEither<Failure, RemoteResponse<String>>(() async {
      if (response.statusCode == 200) {
        final header = GithubHeader.parse(
          id,
          response,
          fullPathToMarkdownFile,
        );

        await _headerCache.saveHeader(header);

        final html = response.data!;
        return RemoteResponse.withNewData(html);
      }

      return const RemoteResponse.notModified();
    });
  }).orElse(
    (failure) {
      final error = failure.errorObject;
      if (error is DioException && error.isNoConnectionError) {
        return TaskEither.of(const RemoteResponse.noConnection());
      }
      return TaskEither.left(failure);
    },
  ),
);

Thanks. Using flatMap was the right call here. I made small changes to your last suggestion and I am not getting any compile time errors.
_RemoteMarkdown getDetail(
  int id,
  String fullPathToMarkdownFile,
) {
  return TaskEither.Do(
    (_) async {
      final requestUri =
          await _(_uriParser(fullPathToMarkdownFile).toTaskEither());

      final cachedHeader = await _(
        Task(
          () => _headerCache.getHeader(fullPathToMarkdownFile),
        ).toTaskEither(),
      );

      return _(
        TaskEither<Failure, Response<String>>.tryCatch(
          () => _dio.getUri<String>(
            requestUri,
            options: Options(
              headers: <String, String>{
                'If-None-Match': cachedHeader?.eTag ?? '',
              },
            ),
          ),
          (e, stackTrace) {
            return ApiFailure(
              'Error on network request',
              errorObject: e,
              stackTrace: stackTrace,
            );
          },
        ).flatMap(
          (response) {
            return TaskEither<Failure, RemoteResponse<String>>(
              () async {
                if (response.statusCode == 200) {
                  final header = GithubHeader.parse(
                    id,
                    response,
                    fullPathToMarkdownFile,
                  );

                  await _(
                    Task(
                      () => _headerCache.saveHeader(header),
                    ).toTaskEither(),
                  );

                  final html = response.data!;
                  return right(RemoteResponse.withNewData(html));
                }

                return right(const RemoteResponse.notModified());
              },
            );
          },
        ).orElse(
          (failure) {
            final error = failure.errorObject;
            if (error is DioException && error.isNoConnectionError) {
              return TaskEither.right(const RemoteResponse.noConnection());
            }
            return TaskEither.left(failure);
          },
        ),
      );
    },
  );
}

Is it okay if I keep this issue opened until I am done migrating my entire project to fpdart? I shall close it once I am done with migration.

Closing the issue as I have successfully migrated my project to fpdart 🥳
Thank you very much @SandroMaglione


[CMake] Allow builds outside the source tree to pass testsuite.

Description
Allows builds outside of the source tree to pass. Adds a CMake variable OIIO_TESTSUITE_IMAGEDIR to specify where the image test's can be run from.  The two are currently tied together, in that building from the source tree it is assumed the testsuite should be run as usual/prior.
Can probably split OIIO_TESTSUITE_IMAGEDIR to have meaning when building from the checkout if these changes are desired.
Also part of the change is explicitly marking some of the -regular- tessuite as requiring oiio-images.
Tests
The following are still failing locally, but I think unrelated to these changes?
oiiotool-subimage
oiiotool-text
texture-icwrite
texture-icwrite.batch

I'm definitely liking the direction this is going. The ability to point to an arbitrary place to root the image tests, is a good idea. I need to fool around with it a bit to see what it's like in practice.

LGTM, merging!


How stop websocket

Hello,
How to stop /restart properly the command gos:websocket  ?
Best regards

Whatever the equivalent is to CTRL-C on your keyboard when you have the command running in the foreground, or the equivalent to kill -9 <pid> if it's running in the background or some place you can't do the CTRL-C method.

 So, use it with caution, weird behavior incoming :D


Allow to use native transports when sun.misc.Unsafe is not present on…

… the system
Motivation:
We should be able to use the native transports (epoll / kqueue) even when sun.misc.Unsafe is not present on the system. This is especially important as Java11 will be released soon and does not allow access to it by default.
Modifications:

Correctly disable usage of sun.misc.Unsafe when -PnoUnsafe is used while running the build
Correctly increment metric when UnpooledDirectByteBuf is allocated. This was uncovered once -PnoUnsafe usage was fixed.
Implement fallbacks in all our native transport code for when sun.misc.Unsafe is not present.

Result:
Fixes https://github.com/netty/netty/issues/8229.

/cc @jprante

Also once this is merged we should ensure we run a CI job once a day with "-PnoUnsafe"

@ejona86 fixed and pushed (but for whatever reason it is not shown in the GitHub UI yet).


Error running file nvidia_process.py

When I run the nvidia_process.py , program error is "ValueError: too many values to unpack (expected 4)
" and the error line is "_, npy_path, label, _ = r.split(npy_path)
". Excuse me, what's wrong with this, please.

You can check the return value of  r.split(npy_path), npy_path and label are expected to obtain from it.

Excuse me, there is a another problem , when I run the program "nvidia_dataloader.py" , in the line 106 , it has an unassign variable "BaseFeeder" . I'd like to know if this is a code shortage or something else, please.

您可以检查 r.split(npy_path) 的返回值，npy_path 和 label 期望从中获得。

Excuse me, there is a another problem , when I run the program "nvidia_dataloader.py" , in the line 106 , it has an unassign variable "BaseFeeder" . I'd like to know if this is a code shortage or something else, please.

It seems that "nvidia_dataloader.py" has 32 lines.

似乎“nvidia_dataloader.py”有 32 行。

the error line is "feeder = BaseFeeder(framerate=80)"  but I can not find the BaseFeeder before the code.

OK, I got it. It is in the nvidia_dataloader.py file, which is used for debugging in the previous version, you can simply change the BaseFeeder to NvidiaFeeder. But it should only report an error when you run the nvidia_dataloader.py file (nvidia_dataloader.py is not supposed to be run individually expect to debug, which is called during model training).


Architectural refactoring

Fairly significant changes to re-architect pyOCD's target and Cortex-M related code.

Created new pyOCD.coresight submodule. It has DebugPort and AccessPort classes, as well as classes for CortexM, FPB, DWT, breakpoints, and ROM table parsing.
CortexM class moved to pyOCD.coresight and simplified by using other coresight component classes such as AHB_AP and the breakpoints classes.
New CoreSightTarget subclass of Target that owns the DebugPort, AccessPort, and CortexM classes. It supports multiple cores. The existing target classes are now subclasses of CoreSightTarget rather than CortexM.
Factored breakpoints code that was in CortexM into a BreakpointsManager class and related classes.
CoreSight ROM tables are parsed during init, although they are not yet used to construct objects.
Additional CPU states are supported: reset, lockup, and sleep.
Debug resources are disabled and debug is powered down upon disconnect.
Memory reads are filtered to hide software breakpoints.

This changeset also includes some miscellaneous changes, as well:

pyocd-tool can execute arbitrary Python expressions via a "$" syntax.
Added "core" command to pyocd-tool to select the current core.
SVD files are associated with targets and the registers can be accessed via pyocd-tool.
hidapi USB backend was improved to fix issues with multiple connected boards and when another process already has a board open.

Chris, thanks for pushing this upstream :+1: . I'll have a look this week for all these changes in here

@flit are you one of the core contributors or are you talking with the core contributors outside of github? I'm just assuming that you have been because otherwise merging 45+ commits that add all kinds of different functionality seems kind of insane. I really am trying to say this to be constructive, I just think PRs should be fairly succinct in what they're trying to achieve. The set of changes your proposing is on the level of an entirely new release.
@0xc0170 @c1728p9 Thoughts?

are you one of the core contributors or are you talking with the core contributors outside of github?

Actually both.

I'm just assuming that you have been because otherwise merging 45+ commits that add all kinds of different functionality seems kind of insane.

Do you think, Chris we could split this into smaller feature-complete PR? At least we attempt to reduce the number of features here.

Excellent work on this patch @flit !  This patch should probably be followed by a minor version bump if it can't be easily broken into a lot of smaller patches.  I'll try to give it a thorough first pass review here though.  Thanks again for all the hard work.  Sorry I wasn't able to get to it sooner.  I have been quite busy lately.

A lot of small comments, but in general the change looks great!  I'll be running some more testing tomorrow, so there will probably be some more feedback coming.
Found a couple of problems while testing.  I'll try to help track them down more tomorrow.
-lpc800, lpc1768 and lpc11u24 fail basic test, cortex test and flash test.
-the gdb test script no longer runs properly and hangs.  It looks like the response to setting a software breakpoint changed, which might be causing this.  I have attached logs from this test before and after your patch.
gdb_before_and_after.zip

Anyone who is interested feel free to test this patch and provide feedback.  Also please comment if there are any specific concerns you would like to have addressed.  I'll be working with @flit to make this as stable as possible before it is merged.

Thanks @c1728p9 for reviewing and all your comments, sorry it took a while to get back to this. Also thanks for testing. I've seen the gdb test failure, but wasn't sure if it was something I broke or the fact I was running on OS X. Not sure why the LPC targets would fail… will look into that.
@tgarc yeah, it's a lot of commits… But a lot of the commits have actually already been merged via other pull requests. In those cases the work was originally done on this branch, then I moved it to another branch and created a PR. I chose not to rebase this branch because there were quite complicated differences to resolve, especially regarding the new pyDAPAccess submodule.

test this please

test this please

test this please

@c1728p9 Just committed some changes based on questions you had about the changes in this PR.

The retry loop in CortexM.reset() is still needed for KL28. But I removed the fault recovery handler, which seemed to be overkill and wasn't used in my testing.

Stuffing the dummy 0 value if S_REGRDY isn't set in CortexM.readCoreRegistersRaw() seems to have been related to multicore. Some code was trying to read registers when the core was being held in reset. I've reverted this code for the time being and am moving it to my multicore debug branch.

Cleaned up initial_setup and bus_accessible params for init() of CortexM and CoreSightTarget.

Removed the KL28 SVD file in favor of a PR to cmsis-svd, which has already been merged thanks to posborne.

@mbed-bot: TEST

@mbed-bot: TEST

Latest patchset is failing with:
Traceback (most recent call last):
  File "automated_test.py", line 111, in <module>
    main()
  File "automated_test.py", line 85, in main
    board_list = MbedBoard.getAllConnectedBoards(close=True, blocking=False)
  File "/home/workspace/pyOCD_hw/pyOCD/board/mbed_board.py", line 163, in getAllConnectedBoards
    new_mbed = MbedBoard(dap_access, target_override, frequency)
  File "/home/workspace/pyOCD_hw/pyOCD/board/mbed_board.py", line 102, in __init__
    super(MbedBoard, self).__init__(target, target, link, frequency)
  File "/home/workspace/pyOCD_hw/pyOCD/board/board.py", line 30, in __init__
    self.target = TARGET[target](self.link)
  File "/home/workspace/pyOCD_hw/pyOCD/target/target_lpc1768.py", line 32, in __init__
    self._svd_location = SVDFile(vendor="NXP", filename="LPC176x5x_v0.2.svd", is_local=False)
NameError: global name 'SVDFile' is not defined

@mbed-bot: TEST

@mbed-bot: TEST

@mbed-bot: TEST

@mbed-bot: TEST

Only cortex-m this time

@mbed-bot: TEST

@c1728p9 is this latest failure caused by the code, or is it an issue with the mbed CI server?

It is likely a problem with CI

@mbed-bot: TEST

@mbed-bot: TEST


Topic-muting confirmation popup is intrusive

The new confirmation popup after muting a topic (#1711) seems too large, given that the user will almost always want to ignore it.  It also appears in prime real estate at the top of the reading pane.  If I mute a topic my goal is usually to reduce cognitive load/screen noise, but muting now momentarily does the opposite.  Could the popup be made less intrusive?

I think it's probably not super easy to move because the message pane is the only thing that's present in narrow windows, but we could definitely make it smaller, dismiss faster, etc.
A specific proposal for how it should look would be welcome!

the message pane is the only thing that's present in narrow windows, but we could definitely make it smaller, dismiss faster, etc.

Totally agree. What we can do is design it better as Tim suggested by making it smaller etc. so that it fits with the overall theme of Zulip.

Chrome for Android has a nice popup when closing a tab:

I think an option to not display the popup agian would be useful. I already know what I'm doing when muting a topic.

Well, we do want it to be somewhat visible because it's accessible via keyboard shortcuts one could hit by accident.  But I'd like it to be 1 line height in size, not the giant thing it is right now.  The main question is where to put it -- perhaps above the compose area?

Closing as this was fixed by a general reworking of the feedback_widget component that powers it.


Can attribute lists be added to markdown reference links?

Can the attribute list extension support an attribute list on the reference portion of a reference-style link?
The inline syntax works like this, but the readability factor is low.
Open [http://<IP_ADDRESS>:8080/][1]{:target="_blank"}  in your browser:
[1]: http://<IP_ADDRESS>:8080/ "Local Concourse"

Could the attribute extension process input like this as well?
Open [http://<IP_ADDRESS>:8080/][1] in your browser:
[1]: http://<IP_ADDRESS>:8080/ {:target="_blank"} "Local Concourse"

Advantages of this additional syntax.

Improve readability of the base text
Allows all URL-related processing to be located in one place.

No, that is not supported.
Note that the attribute list feature was created as a subset of the feature first created by Maruku (see web archive). The requested behavior was not supported there, so it is not supported here either.
Given the above, we will not be added the requested feature to our extension.
Of course, you are free to create your own extension and/or fork the existing extension (within the confines of the license) which adopts whatever behavior you desire.


Add Cloud Profiler agent

Add Cloud Profiler in the app.
Additionally, add fmt.Errorf to wrap the errors emit from underlying functions for better error handling.

This PR solves the profiler part in #2

Merged


Initial encrypted protocol support

@MPM1107 does it work properly with freestyle 2 device, tested with real device? I have a few questions about your approach can you contact me in private<EMAIL_ADDRESS>

So I'm now starting to take a look to this. My general idea is to start trying to implement this using a separate Speck implementation (https://pypi.org/project/simonspeckciphers/) so that it's very very clear that the encryption is not copied from anywhere in particular, and has no copyright issue.

Sounds good, that implementation looks very similar to mine, should work. It's just missing the CMAC part, which is also standard, but I don't see any suitable 3rd party libs for that after a quick google search, they're all a part of bigger crypto libs that don't implement speck. Not sure what the best way to solve that would be.

Yeah I played around with it a bit but you're right it's not quite satisfying as it is :/
If pycryptodome supported Speck, then we would be good to go, maybe I should file a feature request.


DNS queries to zipkin when tracing is disabled

Bug description
I'm seeing DNS queries in coredns to zipkin even though tracing is disabled. We found this similar issue https://github.com/istio/istio/pull/13110 but we can disabled the tracer completely because we use the operator and it doesn't allow to set the tracer to "" or empty:
IstioOperator config:
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  values:
    global:
      proxy:
        tracer: ""

Error in operator log:
2021-03-31T08:12:27.413703Z     info    Reconciling IstioOperator
2021-03-31T08:12:27.415035Z     info    Updating IstioOperator
2021-03-31T08:12:27.415085Z     info    installer       Loading values from compiled in VFS at path profiles/default.yaml
2021-03-31T08:12:27.595551Z     error   failed to generate IstioOperator spec, unknown value "" for enum v1alpha1.Tracer

[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[x] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
No DNS queries to zipkin when Tracing is disabled or allow setting spec.values.global.proxy.tracer="" in operator to disable it.
Version
$ istioctl version --remote
client version: 1.8.1
control plane version: 1.7.3
data plane version: 1.7.3 (4 proxies)

$ kubectl version --short
Client Version: v1.20.5
Server Version: v1.20.5

How was Istio installed?
Operator

please take a look at https://github.com/istio/istio/issues/31553. Thanks!

Feel free to reopen if your issue is not resolved by comments there. Thanks!

@bianpengyuan How do I remove the default with the operator? I tried this:
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  meshConfig:
    defaultConfig:
      tracing: {}

But it still shows up in the istio configmap and the envoy bootstrap config:
kind: ConfigMap
apiVersion: v1
metadata:
  name: istio
  namespace: istio-system
data:
  mesh: |-
    defaultConfig:
      discoveryAddress: istiod.istio-system.svc:15012
      proxyMetadata:
        DNS_AGENT: ""
      tracing:
        zipkin:
          address: zipkin.istio-system:9411

Hmm I am not sure.. probably an operator bug? I am not familiar with operator. Does restarting operator help?

In the IstioOperator file i added
     defaultConfig:
       tracing: {}

To the spec section

In the IstioOperator file i added
     defaultConfig:
       tracing: {}

To the spec section

Thanks for the reply!
If add it directly under spec the operator complains and doesn't rollout the config:
2021-04-13T12:35:55.728831Z     error   k8s.io/client-go@v0.18.3/tools/cache/reflector.go:125: Failed to list *v1alpha1.IstioOperator: v1alpha1.IstioOperatorList.Items: []v1alpha1.IstioOperator: v1alpha1.IstioOperator.Status: Spec: unmarshalerDecoder: unknown field "defaultConfig" in v1alpha1.IstioOperatorSpec, error found in #10 byte of ...|":false}}},"status":|..., bigger context ...|:{"enabled":false}}},"tracing":{"enabled":false}}},"status":{"componentStatus":{"Base":{"status":"HE|...

Which version of istio are you on ?

1.7.3

@bianpengyuan Can we reopen this Issue? We are unable to remove Zipkin from the mesh config and still see the DNS requests for zipkin.istio-system:
Steps to reproduce:
$ istioctl version
client version: 1.9.4
control plane version: 1.9.4
data plane version: 1.9.4 (1 proxies)

$ istioctl manifest generate -f istiooperator.yaml | grep -C 5 tracing

  mesh: |-
    defaultConfig:
      discoveryAddress: istiod.istio-system.svc:15012
      proxyMetadata: {}
      tracing:
        zipkin:
          address: zipkin.istio-system:9411
    enablePrometheusMerge: true
    rootNamespace: istio-system
    trustDomain: cluster.local

istiooperator.yaml

apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  name: default
spec:
  meshConfig:
    defaultConfig:
      tracing: {}

Yeah looks like somehow the istioctl mesh config overlay does not work and it cannot replace the generated ones.

@boredabdel in #31553 you said that you figured out a way to disable tracing. Can you share your full IstioOperator config or the relevant parts to disable it? With the solution you shared above I get the following error:
$ istioctl manifest generate -f istiooperator.yaml
Error: unknown field "defaultConfig" in v1alpha1.IstioOperatorSpec:
...

istiooperator.yaml with defaultConfig in spec section:

apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  name: default
spec:
  defaultConfig:
    tracing: {}

I tested this with istioctl 1.9.4 and 1.6.7 (the version you mentioned in #31553) and with both versions I get the same error.

On k3s 1.26.4 with Istio 1.18.1, I was able to stop the queries to my DNS server by fully qualifying the Zipkin address, i.e., setting it to:
tracing:
  zipkin:
    address: zipkin.istio-system.svc.cluster.local:9411

This ensures that pods query no further than cluster.local (for which CoreDNS is authoritative).
How I found out
I was idly monitoring tcpdump -i any port 53 | grep zipkin on both my router and one of my nodes, and noticed that one of the pods was querying for zipkin.istio-system by trying all its search domains first. So I rerecorded:
tcpdump -i any port 53 -w zipkin.pcap
tcpdump -nr zipkin.pcap | grep -E "(cni|enp1s)0.*zipkin"

21:35:47.910621 cni0  Out IP <IP_ADDRESS>.59595 > <IP_ADDRESS>.53: 54962+ A? zipkin.istio-system.svc.svc.cluster.local. (59)
21:35:47.910961 cni0  In  IP <IP_ADDRESS>.53 > <IP_ADDRESS>.59595: 54962 NXDomain*- 0/1/0 (152)
21:35:47.911668 cni0  Out IP <IP_ADDRESS>.59595 > <IP_ADDRESS>.53: 9177+ A? zipkin.istio-system.svc.cluster.local. (55)
21:35:47.911998 cni0  In  IP <IP_ADDRESS>.53 > <IP_ADDRESS>.59595: 9177 NXDomain*- 0/1/0 (148)
21:35:47.912511 cni0  Out IP <IP_ADDRESS>.59595 > <IP_ADDRESS>.53: 33787+ A? zipkin.istio-system.cluster.local. (51)
21:35:47.912719 cni0  In  IP <IP_ADDRESS>.53 > <IP_ADDRESS>.59595: 33787 NXDomain*- 0/1/0 (144)
21:35:47.913252 cni0  Out IP <IP_ADDRESS>.59595 > <IP_ADDRESS>.53: 58606+ A? zipkin.istio-system. (37)
21:35:47.913422 cni0  In  IP <IP_ADDRESS>.37107 > [router IP].53: 55937+ A? zipkin.istio-system. (37)
21:35:47.913444 enp1s0 Out IP [node IP].3736 > [router IP].53: 55937+ A? zipkin.istio-system. (37)
21:35:47.913802 enp1s0 In  IP [router IP].53 > [node IP].3736: 55937 NXDomain 0/0/0 (37)

YMMV, but I had to restart all Istio-enabled pods to get the change to take.


Fix build issue with GetModuleHandle when using UNICODE

Per the UTF-8 Everywhere Manifesto, it's best to not rely on the legacy ANSI .vs UNICODE macros for Win32 functions that take strings. Since you explicitly use an ANSI string for the call to GetModuleHandle you should explicitly use the GetModuleHandleA method.

This causes problems when trying to build your library using vcpkg manager when the setup adds the recommended UNICODE _UNICODE defines.

Thank you for your PR, and sorry for the delay in review.


fix external login in ie11

Description

fix external login in Internet Explorer 11
Related Issue :

How Has This Been Tested?

Login to an external client in Internet Explorer 11.

Need additional checks?
Other browsers including mobile devices.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

deploy to 1


Change npm version

Using npm 4.x due to issues with npm 5 at the moment

Coverage remained the same at 87.936% when pulling c03de0756a765e2f0a61050e94ac62f4c7836ebb on SAP:change_npm_version into 31bb81b903420e224250f667eda7ad853957800f on cloudfoundry-incubator:master.


Add support for the 'NOT' qualifier before equality and order comparison operators.

Changes corresponding to the latest grammar update, to add support
for the 'NOT' qualifier before equality and order comparison
operators.  Sprinkled some additional tests using this syntax into
test_basic_ops.py.

Tests won't pass until pattern-validator gets a new release, and this project's dependencies are updated accordingly.


Japanese keyboard cause application crash

Expected Behavior
Application should not crash
Current Behavior
current keyboard is japanese,when starts the application，then crash
Possible Solution
switch to other language keyboard,for example : simple chinese keyboard
Steps to Reproduce (for bugs)

On windows 10 open 'Settings'. Select 'Time & Language'.
1.switch to japanese keyboard

click the apllication to start ,then crashes.
Your Environment

Node.js   10.11.0
Chromium  69.0.3497.128
Electron  4.0.8
iohook  0.6.5

environment
Node.js 12.18.3
Electron 11.1.1
iohook 0.6.6
has same case

environment
Node.js 12.18.3
Electron 11.1.1
iohook 0.6.6
has same case

@Fental Can you provide more info please? A stacktrace or the particular error line without the trace?

@ash0x0
In my case, my application did not crash and I did not any error log about it.
If I require iohook in my Application. It get stuck and failed to respond when I launch it.
I tried to solve this by myself. When I deleted the following code, everything is OK.
https://github.com/wilix-team/iohook/blob/master/libuiohook/src/windows/input_helper.c#L556
https://github.com/wilix-team/iohook/blob/master/libuiohook/src/windows/input_helper.c#L649
I hope that my information can help you.


Unable to provision vsphere downstream clusters (RKE/RKE2) -- machines not created in vsphere

Rancher Server Setup

Rancher version: master-head (2e6926b)
Installation option (Docker install/Helm Chart): docker

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): rke1, rke2

Proxy/Cert Details: n/a

Information about the Cluster

Kubernetes version: v1.21.1-rancher2-1, v1.21.3+rke2r1
Cluster Type (Local/Downstream): downstream

If downstream, what type of cluster? vsphere

Describe the bug

When provisioning using vsphere, machines are not being created in the provider.
To Reproduce

provision a downstream cluster using vsphere provider through rancher (single node all roles)

Result

machines fail to create
for rke2, machine logs from rancher below:

Failure detected from referenced resource rke-machine.cattle.io/v1, Kind=VmwarevsphereMachine with name "ctw-vsphere-rke2-ctw-726-rke2-dsa-9s2n6": Running pre-create checks...
    (ctw-vsphere-rke2-ctw-726-rke2-dsa-9s2n6) Connecting to vSphere for pre-create checks...
    Error with pre-create check: "Post \"https://:443/sdk\": dial tcp :443: connect: connection refused"
    The default lines below are for a sh/bash shell, you can specify the shell you're using, with the --shell flag.

it appears that the vcenter name is not being added to the post request
Expected Result
machines should be created on provider when provisioned through rancher
Screenshots

Per @thedadams, the vsphere issue is the following:

If a user leaves the “Host” value dropdown to the “Any” value, the UI sends the value as 'SENTINEL'.  This seems to be causing the issue.

I prevented the __SENTINEL__ from getting sent. I couldn't verify that this resolved the original issue due to VPN issues.

on v2.6-723f747b18a595a329a3563f6c791e78e0f135a3-head and master-head (f8600c6 ):

I am now able to create clusters using the vsphere node provisioner
single node create -- pass

edit -- pass
scale up -- pass
delete -- pass

multi-node create -- pass

delete -- pass


Print line numbers for failed integration tests

Currently, when the integration tests are run and fail we get information similar to this:
com.ably.tracking.tests.ChannelModesTest > shouldCreateOnlyOnePublisherAndOneSubscriberConnection[test(AVD) - 8.1.0] FAILED
	java.lang.AssertionError: expected:<1> but was:<0>
	at org.junit.Assert.fail(Assert.java:88)

We would like to get the line number of the exact assertion that has failed as there can be multiple similar assertions in a test and we won't know which one of them failed.
When you run the tests in the Android Studio you get the line number of the failed assertion, but instead of using ./gradlew connectedCheck the AS is using this command
adb shell am instrument -w -r -e debug false -e class 'com.ably.tracking.tests.ChannelModesTest' com.ably.tracking.tests.test/androidx.test.runner.AndroidJUnitRunner

maybe we could use this for running the whole integration tests suite?

Once I land https://github.com/ably/ably-asset-tracking-android/pull/650 then we'll be able to indirectly get line numbers from the uploaded build report artifacts.

The corresponding Jira issue is https://ably.atlassian.net/browse/SDK-1550


Created line chart widget + Mock examples in Homepage and Account Modal

Created the upper part of the Homepage based on the Figma (https://www.figma.com/file/6NyY9yqunpbU7HIkbNEAL3/Sossoldi-App?node-id=870%3A1075&t=qhyvRfo8U3EACCrK-4) using fl_chart. One thing that is not currently implemented is the information showed when the user taps on one day of the chart (curretly shows the raw data)
There are also some changes that VSCode did automatically in order to let me use the debugger on macOS and the iOS emulator.

Thank you!
I think you should remove all committed files inside ios and macos folders from this PR, as they're somehow related to the single system running the build, i think. I'm unable to checkout your main branch because of this (my podfiles are .gitignored).
If you need it, see here to find out how to do that.
I general we don't want to merge software automatic edited files. Afterwards we can check your work. Thank you!

Sorry about that, somehow I thought they were just default files for all. I reset the folders for iOS and macOS, hopefully now it fine

I tried to implement what we discussed on Discord before. Hopefully I understood what you asked, now the placeholder data is not in the widget file but is written on the home_page.dart

In the next days I will also try to add the test and I will also talk to Federico P. about the behaviour of the chart when the current and the previous month differs in the number of days.

Need rebase :D

A little update on my end. A made the chart class generic so that we can reuse it and created a modal just to verify that it works. I didn't commit it because I still need to do a little bit of clean-up and add some comments so that who will use it later will have an easier path

Ok, great!!
Maybe you can rebase your fork to get last changes to the theme management (see #36) and use this ultimate references in your work.
Also check #43 for the correct approach to use when importing libs, and #42 to make sure you're using the correct paths for widgets

Ok, I tried to make the corrections and hopefully everything is fine now. The linechart widget has some parameters in order to display two lines, those are: the data point lists, the colors, maxY, minY, the # of days and the background color. If we need to display just one line we can pass an empty list.
To make a little more clear the use I also implemented the modal that opens when a user taps on one of the accounts from the dashboard.
I also tried to implement one test but at the moment is not really useful, if someone has an idea on what I should do and has some resources I'll try to make something better.

Ok cool, very good work!
Can you just remove "macos" folder and "pubspec.lock" file from the PR so I can checkout? Thanks!

@mikev-cw Now it should be fine. I always try to exclude them but sometimes they still go through


Track commute, build reporting views/queries

Shawn says:
I was hoping to award a pointless prize based on the ratio of 'commute' rides to total rides for the duration of the competition.  Is that data available?  I've seen the 'commute' banner on strava rides recently and was hoping that info was included in data that could be pulled down.
So i guess i'd just need two numbers for each rider:
total number of rides
total number of rides flagged with 'commute'

I'd worry that people aren't that consistent with using that tag. Also, I'll throw off any numbers since I generally stop and save a ride every time I get off my bike at a destination (I have 161 rides this year, twice as many as the person with the 10th most) and work 100% from home.
Although you're in luck, looks like it's a true/false on the activity

Yeah, I know the attrib is there.  People can always go back and add it.  I agree it's not going to be 100% accurate, though, since I sometimes forget.  So it'll only be as good as the data.  We could get really fancy and match on other activities that have the same geometry as those matched by commutes ... but we won't actually do that. :)

Although that would be a fun project if someone was going to pay me for the time I spent on it...

Just realized you were quoting a feature request, not adding your own thoughts. Makes more sense, I was a little surprised that you'd be unaware of the commute flag.

yeah, i forgot to indicate that in the ticket :)

Apparently we're already tracking commutes (commute bool) in the db too.  So I guess all that is left is to make a chart or something.


Add a setup procedure to virtctl to allow people configuring preferences

Is this a BUG REPORT or FEATURE REQUEST?:
/kind enhancement
What happened:
We have a few commands in virtctl which are guessing based on well known tools and file locations what people will most likely want to use when they run commands like virtcl vnc or virtcl ssh.
What you expected to happen:
We should add something like a virtctl config command which will do auto-detection and then ask people explicitly for their preferences and safe the result in a configfile.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/remove-lifecycle rotten
/lifecycle frozen
/reopen

/label good-first-issue

can i be assigned this issue

can u help me where i can find the existing file?

/assign
@shivangnayar-crypto
All the relevant code should be in /pkg/virtctl/

should i create a new file named config.go under the pkg/virtctl directory and add the code there?

Hi @rmohr,
I hope you are doing well.
I have a couple of questions regarding the configuration setup in KubeVirt:

Is there any default configuration file that KubeVirt refers to when executing commands?
If a user wants to use an existing configuration file, should that file exist by default, or would it need to be created or specified manually?


[WFRP4e System] character sheet

"Font size" does not work properly. Above size 2, strange things start to happen to the card. the character's name disappears halfway through and the rest of the names are moved. Currently, I would like to use Font Size 5 because then everything is visible on the card, but this error with truncating the names appears. Is there any way to fix this? Thanks Belial.
From: belial6667142foundry: 12.327wfrp4e: 7.2.0wfrp4e-core: 5.0.5Active Modules:

You have foundry: 12.327. Problem occurs in v12, go back to v11 or wait for better support to v12


RFC: GraphQL Query ID handling

Currently our "Entity By Id" Queries look like this:
    @Query(() => Product)
    @AffectedEntity(Product)
    async product(@Args("id", { type: () => ID }) id: string): Promise<Product> {
        const product = await this.repository.findOneOrFail(id);
        return product;
    }

If you submit a malformed id:
query Product0 {
  product(id: "ec9f2ed2-7e8f-491a-9137-651eb338ed6fx") {
    id
  }
}

you get an error from the DB
      "message": "select \"p0\".* from \"Product\" as \"p0\" where \"p0\".\"id\" = 'ec9f2ed2-7e8f-491a-9137-651eb338ed6fx' limit 1 - invalid input syntax for type uuid: \"ec9f2ed2-7e8f-491a-9137-651eb338ed6fx\"",

This error can be caught earlier. Our security team also noted that this exposes implementation details to a potential attacker. But this could be resolved in another way.
As we now have the UUID type from graphql-scalars, we can simply use it to prevent this error. A malformed ID would now result into GRAPHQL_VALIDATION_FAILED. A previous attempt to mitigate this error by using an ArgsType with class-validator was declined due to the need of an extra class.
For the sake of completeness, an additional method to mitigate this issue by using Pipes is also shown. I would not use that, as we don't use Pipes currently and I think it would be better to use GraphQL for that.

API Generator should generate by default
+1

My plan is to also use UUID for ForeignKeys in input types as well.

lgtm.
I would adapt api-generator to use this. Also for relations, IsUUID could be omitted then.

I would adapt api-generator to use this. Also for relations, IsUUID could be omitted then.

We'd still need one validator though, otherwise class-validator fails with a whitelist error (could even be @Allow())


s3 is-log-target supports finding self-referential buckets

ie buckets that log to themselves end up being an anti-pattern for some governance policies (encryption via lambda for example), being able to detect those for a start would be good.

merged for <IP_ADDRESS>


Envopts

This set of commits add configuration functionality to anv backend.
Func WithPreffix allows to add preffix to env var.
Func ToUpper uppercases vars

I believe you'd need camelCase to SNAKE_CASE conversion, not just uppercase conversion. Right?

It's a good idea to have to those options. But why shouldn't we add this functionality to the others backends ?

Hello. I think that those options must be separate for each backend (different types for different backends). That's why I added this type inside env backend package.
I agree with you about other backends

Why should we have a different type for each backend ? This is a common use case so I think that we can have a common type .


Automatically select profile in rust-verify.sh

Default is release unless it isn't built, in which case we fall back to debug. The --release and --debug flags (as the first flag) can override this.
Fixes #488.

Since this is a minor change that has already been approved, I'm just gonna go ahead and hit merge here rather than waiting on @tchajed to hit merge.


fix(CMSIS): Switch GCR BTLELDOCTRL LDOTX and LDORX fields for MAX32655, MAX32680, and MAX32690

Description
Switched the LDORX... and LDOTX... field positions in GCR_BTLELDOCTRL register for the ME17, ME18, and ME20.
Also updated the Verify_Register_SVD workflow to regenerate the register files for each job instance by deleting all the generated register files at the end of action. The workflow is set up to generate the register files only once by checking whether the gen reg files exist or not in order to save time. However, the problem comes up when generated register files from previous jobs remain in the next job instance because the Wall-E doesn't refresh its workspace, thus, preventing the register files from being regenerated.
Checklist Before Requesting Review

[x] PR Title follows correct guidelines.
[x] Description of changes and all other relevant information.
[ ] (Optional) Link any related GitHub issues using a keyword
[ ] (Optional) Provide info on any relevant functional testing/validation.  For API changes or significant features, this is not optional.

/generate-register-files me18

/generate-register-files me18

/generate-register-files

Hold off on merging. ME14 might be the same.

/generate-register-files me18

/generate-register-files

/generate-register-files

/generate-register-files

/generate-register-files

/clang-format-run

/generate-register-files

These changes will not be added to the latest release.

/clang-format-run

/clang-format-run

/clang-format-run

/clang-format-run

This can be closed.


This repository is used by scammers to steal credit card information

This repository is used by scammers to steal credit card information and you are part of this scam whether you know or not.
Your repository is hosting the files used directly by the scammer websites. I suggest you to take this repository down.
I have reported this to the Github as well.

Online banking

Online banking

@pkarlik Yeah, let's take down every piece of open source code that currently is or could be used by scammers.
Good bye internet, and thanks for all the fish.

Yeah actually just found this repository by looking through a scammer's code, atleast they were nice enough to give credit where it's due 😀 anyways this code is currently circulating Denmark and stealing credit card info, with some additional comments in Russian. Very interesting

scammers are the problem. we need to take them down. NOT THE REPOSITORY.... the free repository is the hard work of somebody that gives you something for free. something that you maybe dont know how to code, dont have time to code.... SO BE GRATEFUL!!!
Thanks to the developer. great idea and coding. :)


NPE, Samsung Query inventory

Hi all,
first of all I hope everyone is doing well. This is my 1st post here.
We are using the IAB lib and find it a great idea. There is one issue we found however that can be reproduced..
Once the check inventory has been started, bring the app to background via home key.... What happens then just before the onActivityResult would be triggered (I guess) is below:
Process: com.bla.ads, PID: 14350
E/AndroidRuntime(14350): java.lang.NullPointerException
E/AndroidRuntime(14350): 	at org.onepf.oms.appstore.SamsungAppsBillingService.queryInventory(SamsungAppsBillingService.java:188)
E/AndroidRuntime(14350): 	at org.onepf.oms.OpenIabHelper.queryInventory(OpenIabHelper.java:973)
E/AndroidRuntime(14350): 	at org.onepf.oms.OpenIabHelper$5.run(OpenIabHelper.java:999)
E/AndroidRuntime(14350): 	at java.lang.Thread.run(Thread.java:841)
The originating activity (from where we initiate the query is not finished so we were expecting the onActivityResult to be triggered.
The function works well if the app is in foreground..
Using 0.9.7
Hope someone has some insight would be very much appreciated
Thank you

fixed


fixed: missing "Request Rate Limiting" handling

handle TMDB request rate limit (error 429)

Not sure I agree with this implementation. While it might 'work' there is already a retry mechanic available on the rest client itself. Status 429 mean that it will simply not work for x seconds =>

Right now when you actually trip the rate limits, we just throw a 503 error which is really not the right way to do this. Moving forward, we'll be throwing a proper 429 status code along with a Retry-After header telling you how many seconds to wait until you're allowed to make a request again
TMDb https://www.themoviedb.org/talk/5317af69c3a3685c4a0003b1?page=1

As indicated in this discussion: https://github.com/LordMike/TMDbLib/issues/38 we should add a property to indicate if we need to just keep waiting or throw an error so the application can deal with it.

I have read that discussion.
My problem is that TMDBLib does not tell me that in any way. My software (Ember Media Manager) runs very often in that TMDB limit. It looks like TMDBLib does not wait or throw an error.
In this situation TMDBLib gives back a Movie, but the client values like Client.Images.BaseURL is NULL. This is not consistent.

... and my solution does wait if you have set the MaxRetryCount to > 0.

Correct, I'll try and have a fix up tonight that would throw a custom error that tell you this, or will retry the call after the indicated time has expired (I think I'll make that the default if @LordMike agrees).

https://github.com/LordMike/TMDbLib/commit/ea8c2e1603fd98baa6bd887fe01405bcd884c094


renderhook 的问题

Describe the bug
比如在useTitle中，为了检测watch功能，实际上是是多次调用了renderHook；
只是再一次进行了app的创建；并不是watch的效果；有其他方式吗？
Steps to reproduce
No response
System Info
node: v16

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct.
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a VueHooks Plus issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

暂时没办法取到替代方案 @liuxsen


Dev Mode: Add integration tests

Add gradle equivalents of dev mode integration tests https://github.com/OpenLiberty/ci.maven/tree/master/liberty-maven-plugin/src/it/dev-it

WIP tests: https://github.com/ericglau/ci.gradle/tree/devBasicTest. Windows tests are failing, possibly due to #397 and #402


Better documentation

Examples in README covering:

Simple case
Overriding default behaviour
No default constructor

Either initialize object before calling fromJSON
Or provide custom from/toJSON

Check (and document) what happens with private fields etc?
Check what is done with @property

Added some documentation. Ideally would also put ddoc info up on wiki, but ddoc has no markdown output. Closing for now.


Dentacoin colored svg uses mask

Hi,
I'm using your svg icons as a resource for a react/react-native project (you may have heard about http://getdelta.io 😉).
For the react-native version, I need to convert them to a format react-native-svg can work with. Sadly, they don't support masks. I fixed the Dentacoin one so it just uses a regular path. Would be cool if you'd check out my PR!
EDIT: I also simplified some other that were giving problems.
Neo and Gas due to using a gradient, sys and nano due to having two fill colors instead of the white parts cut out. It's easier to do color manipulation when there's only one fill color in the svg file.

Fixed! I wanted to make sure my source file was up-to-date, so I make the changes there just in case I ever needed to re-export those again. Thanks for the PR.

Thank you for your support. If you’d like to tip me for my time in maintaining and updating this project, it would be very much appreciated.


PromotionPolicy list/array support

Summary
the current promotion policy only supports a single stage, i.e.:
apiVersion: kargo.akuity.io/v1alpha1
kind: PromotionPolicy
metadata:
  name: promote-gothem-image
stage: gothem-image
enableAutoPromotion: true

if have several stages that needs auto promoting I need to create multiple files, instead, use stages:  and get a list of stages, i.e.:
apiVersion: kargo.akuity.io/v1alpha1
kind: PromotionPolicy
metadata:
  name: auto-promotion-for-stages
stages:
  - gothem-image
  - batman-image
  - robin-image
  - riddler-image
  - gotham-image
enableAutoPromotion: true

Motivation
less YAML?!
Proposal
How do you think this should be implemented?
apiVersion: kargo.akuity.io/v1alpha1
kind: PromotionPolicy
metadata:
  name: auto-promotion-for-stages
stages:
  - gothem-image
  - batman-image
  - robin-image
  - riddler-image
  - gotham-image
enableAutoPromotion: true

Yep. This is a great idea.

I will try to sneak this into v0.3.0 because it's small/easy, but it'll be the first thing to get deferred if we don't have the bandwidth.

v0.4.0 will be introducing a Project resource type. Mentioning this here because there is a realistic possibility of folding PromotionPolicy into that new type.

v0.4.0 will be introducing a Project resource type. Mentioning this here because there is a realistic possibility of folding PromotionPolicy into that new type.

This is happening.
I'm going to remove the "good first issue" label because this makes it a much more involved change.


Support keynav service

keynav lets users control their mouse with the keyboard.
For most users, services.keynav.enable = true should support their workflows.
However, keynav offers many configuration options, which home-manager could
eventually support. For now, why not support the default configuration and allow
open source contributors to fill in the rest as needed?

Thanks for the contribution! I added a few comments.

Thank you for the feedback, @rycee.

Thanks! I fixed the remaining issues and rebased to master in 2cd168467ea4f9840dde53bd80bfe5affdf7c21c.


Add decoder for files of excel and other spreadsheet editors like libre office

Catmandu has a decoder for excel. I think we should have one too. Even if it comes from a proprietary software.

Perhaps this could help: https://github.com/technicalguru/csv?tab=readme-ov-file


Add Google Chat support

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:
Google Chat is a wonderful workspace app like Slack, Mattermost, etc.

Which issue(s) this PR fixes:

Fixes #102
Special notes for your reviewer:
The API description of the Google Chat API is described here https://developers.google.com/hangouts/chat/how-tos/webhooks.

@KeisukeYamashita: The label(s) area/outputs cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:
Google Chat is a wonderful workspace app like Slack, Mattermost, etc.
Which issue(s) this PR fixes:
Fixes #102
Special notes for your reviewer:
The API description of the is described here https://developers.google.com/hangouts/chat/how-tos/webhooks.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

eff3940 Add Google chat support
d30fea2 Add google chat images

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @KeisukeYamashita! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

eff3940 Add Google chat support
d30fea2 Add google chat images

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Awesome, I'll review it asap. Thank you.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

eb5d26c Update README.md

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign issif after the PR has been reviewed.
You can assign the PR to them by writing /assign @issif in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 29e528067b3c77fdabb87ae59268a4da9d91f6ba

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KeisukeYamashita just a little conflict to fix and it's all good 👍

New changes are detected. LGTM label has been removed.

@KeisukeYamashita: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign issif after the PR has been reviewed.
You can assign the PR to them by writing /assign @issif in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign issif after the PR has been reviewed.
You can assign the PR to them by writing /assign @issif in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sorry, I accidentally merge the master branch... PTAL when you have time. Thank you in advance 🙇

LGTM label has been added.  Git tree hash: de87a2dbe68cc3ca3e6f0d9954d683bcdbc2fe88

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @KeisukeYamashita
Thank you for your contribution :+1:
Since we do not allow merge commits, could you please fix that by removing the Merge branch 'master' into add-google-chat-support commit and then perform a git rebase -i master?
We will be happy to merge this PR once that has been fixed :rocket:
If you need any support on that, please let me know.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr  Sorry, I removed the merge commit 🙇  Thank you for your kind notice and guide 🙇

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Entities util duplicates in from_code

In src/compiler/parse/utils/entities.rs. from_code method matches duplicate two codes to both Entity::nbsp and Entity::NonBreakingSpace. It will cause the second statement to be never reached.
160 => Entity::NonBreakingSpace,
160 => Entity::nbsp,

Yeah I copied all the types directly from the svelte repo. Also, the code links to this website where it notes

It is intentional, for legacy compatibility, that many code points have multiple character reference names. For example, some appear both with and without the trailing semicolon, or with different capitalizations.
Maybe if the Entities enum is rewritten as a HashMap, that would be better?


fix(curriculum): updates to EC

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[ ] I have tested these changes either locally on my machine, or GitPod.

Hey @anastasiiauk, can you provide a little explanation for these changes in the PR description? They're pretty self-explanatory, but anything helps - thanks. Also, if you haven't already, you should give it a test locally to make sure it looks how you expect and check that last box. Let me know if you need any help with anything.

Thanks for pointing that out @moT01 - I've just added description.
I didn't test these changes locally as I still have some problems with local set up but I'm planning to work on that next week.


can not run command reservoir

pi@raspberrypi ~/elliottaps $ openaps use pump reservoir
PowerControl SERIAL 624446
Traceback (most recent call last):
File "/usr/local/bin/openaps-use", line 8, in
execfile(file)
File "/home/pi/openaps/bin/openaps-use", line 62, in
app( )
File "/home/pi/openaps/openaps/cli/init.py", line 41, in call
self.run(self.args)
File "/home/pi/openaps/bin/openaps-use", line 56, in run
output = app(args, self)
File "/home/pi/openaps/openaps/uses/init.py", line 70, in call
return self.method.selected(args)(args, app)
File "/home/pi/openaps/openaps/uses/init.py", line 31, in call
return self.method(args, app)
File "/home/pi/openaps/openaps/uses/use.py", line 23, in call
output = self.main(args, app)
File "/home/pi/openaps/openaps/vendors/medtronic.py", line 159, in main
return self.pump.model.read_reservoir( )
AttributeError: 'ReadPumpModel' object has no attribute 'read_reservoir'

This issue was fixed with a git pull from decoding-carelink


Fix half-pixel offset for polygon paths and updated unit tests

I ran into issues with half-pixel offsets, and realized that the way I am setting up the polygons for the path is offset by 0.5 pixels. The example I've fixed in the unit tests used to look like:

and now looks like:

This is consistent with what is done for interpolation. The interpolation points are at the center of the new polygons.
cc @keflavich

@keflavich - what do you think of this?

Looks good, though I have not carefully checked the logic.


Separate HTTP admin project

This PR separates the HTTP admin API into a separate project. This means that users of scheduler no longer need to pull in Scalatra, Jetty, etc. dependencies if they don't plan on using the HTTP admin API.
The root project is just a shell to aggregate all the other projects now, and scheduler has it's own project - this is was necessary to prevent circular dependencies.

:shipit: when travis is happy, I'd say.


Zstd compression support in envoy

Title: Zstd compression support in envoy
Description:

Since 2015, zstd has been getting better and better performance since 2015, and this feature has also been introduced to various platforms. As an increasingly important proxy component in cloud-native, Envoy also needs to support this special effect.

cc @rojkov

cross with https://github.com/envoyproxy/envoy/pull/20434

As stated in the PR already I'm OK to sponsor this enhancement. Intel needs it as a benchmark for the upcoming zstd acceleration in QuickAssist HW and is willing to support it together with ByteDance.

Done with https://github.com/envoyproxy/envoy/pull/20434 now!


Update list_display according to filtered child model

class ProductAdmin(PolymorphicParentModelAdmin):
    base_model = models.Product
    child_models = (
        (models.Subscription, SubscriptionAdmin),
        (models.Voucher, VoucherAdmin),
    )
    list_filter = (PolymorphicChildModelFilter,)
    list_display = ('thumbnail', 'position',)

Can list_display be made to update itself depending on which child model is selected? For example, when I filter for only Voucher objects, I'd like to be able to have list_display to include additional field for Voucher model instead of just thumbnail and position.

The only way you can do this, is by adding a custom colom as method:
    list_display = ('thumbnail', 'position', 'extra_col')

    def extra_col(self, object);
        if isinstance(object, Voucher):
            return object.additional_field
        # or use getattr()
    extra_col.short_description = _("Extra col")


Tween property stacking can lead to memory leak

Godot version:
3.2 branch (commit 94a0fc47f7)
Issue description:
When calling successive interpolate_property/follow_property on the same (object, property), previous existing InterpolateData persists. I know that maybe this is intended, but at least warn the user when a new property interpolation is being overridden? I was calling stop() before calling interpolate_property() for the same property and it took some time to identify that I was memory-leaking internal InterpolateDatas, because they weren't being processed (so never removed)...
On a custom build, calling remove(object,property) inside every interpolate_property(object, property) solves this issue, but maybe there is a better solution? Maybe only a note on documentation?
Steps to reproduce:

func _process(delta):
	stop_all()
        var sprite_node = get_parent()
	var random_target_pos = get_viewport().size * Vector2( randf() , randf() )
	interpolate_property( sprite_node  ,"position", sprite_node.position, random_target_pos,1)
	start()

Minimal reproduction project:
tween_memory_leak.zip

3.2 branch (commit 94a0fc4)

Note that you should move to the 3.x branch, the 3.2 branch is deprecated and read-only as the upcoming 3.2.4 release was renamed to 3.3: https://godotengine.org/article/versioning-change-godot-3x

Now I've found that #17452 was caused by this issue and could be avoided with a proper warn...
I'm not sure if checking for every InterpolateData when calling interpolate_property is the best solution as maybe there is a lot of InterpolateData in progress... can we make this check only in debug/release_debug and warn the user about it?

Now I realized that this isn't so simple, as there can be stacked InterpolateData with different delays. It should check if newly added InterpolateData doesn't collides with any existing one (in the same object+property)

Aaand it was merged. The issue likely still exists in 3.x though.


Support folders?

The val.town web UI let's you organize vals in folders.
Unless I'm mistaken this doesn't work on the vscode extension out of the box?
Would be a nice feature.
Thanks for your work on this repo!

Thanks for the kind words!
Folders are not available in the val.town api. You can create a feature request in the https://github.com/val-town/val-town-product repository.

The extension allows you to reproduce the folder feature by configuring the sidebar