Custom mode respond without mode name

Hi,
In our case, the responses we received after custom mode settings are lack of mode name. For example:
Command 1: set A/C unit sleep timer to on.
Response 1: You got it, setting the A/C unit to on.
Shouldn't it be: You got it, setting the A/C unit sleep timer to on.
Command 2: set A/C unit power saving to on.
Response 2: Sure, setting the A/C unit to on.
Expected: Sure, setting the A/C unit power saving to on.
Is that we missed something or it is designed as it is? Cheers

Can you try an example with a Toggle to see if you get a match that way?

Yes, for toggle we can get the toggle name from the response such as:
"Ok, turning on power save on A/C unit".
That only missing on custom mode response.

Is it possible to just use toggles for your action?

For power saving, yes, we could use the toggle. But for sleeptimer, it looks like we have no choice but only the custom mode.
It is not a critical issue, but from the view of user experience, we recommend to put mode name in response.
Cheers.

Find another response issue which could be fixed easily. When calling sleep timer, the response repeat the time twice. Example:
"Hey Google, set A/C unit sleep timer to 1 hour"
"Ok, set A/C unit sleep timer to 1hour 1hour".

Does this happen for other settings as well?

For us, it only happens when using "sleep timer" mode, with "1 hour", "2 hour", "4 hour", etc.

I'm unable to reproduce this behavior.


FixforIssue#49 - Adding litmus demo video to the README.md

What this PR does?

Adds a demo video to the litmus readme file.
Created new folder "images" containing animated asciinema images.

Signed-off-by: Uday Kiran Y<EMAIL_ADDRESS>

Nice! Can we also have the "build:pass" badge shifted to top of the readme

thanks @yudaykiran for the videos.
I felt the videos are not in sync.
Perhaps a single video is better at making contributors to understand the principles of litmus.
The pace of video can also be increased a bit.

@AmitKumarDas the initial idea was to group them together as a single video, but then we decided on having separate videos for the status. We will have to group them together if we want to see some sync between the different terminals. I have got an idea where we might be able to increase the pace of the video, will try it out.

@kmova @AmitKumarDas review comments addressed in the new commit.

@kmova resolved the review comments.


feat(ui): layers metadata recall

Summary
Support metadata recall for layers.
TODO:

[x] Do not store ephemeral layer state in metadata (e.g. 'uploadedMaskImage', maybe bboxNeedsUpdate)
[x] Check images for existence? May as well implement this for all metadata recallers that use an image while I'm at it...
[x] Decide how to handle metadata from layers into canvas
[x] Decide whether to store both the old-style metadata and layers metadata - I don't think I want to store both...
[x] Add versioning to metadata
[x] Test thoroughly

Related Issues / Discussions
n/a
QA Instructions
When ready for review, use control layers and check the metadata tab. Try recalling an individual layer, or use all to get all layers.
Merge Plan
n/a
Checklist

[x] The PR has a short but descriptive title, suitable for a changelog
[x] Tests added / updated (if applicable)
[ ] Documentation added / updated (if applicable)

HRO is disabled when regions are used.
Metadata handling:

Pre-CL metadata is recalled conditionally based on the current tab. The pre-CL style ControlNets, T2I Adapters, IP Adapters and initial image are parsed into layers. This is only best-effort - some properties don't translate, like resize mode. The parsing is forgiving and will do its best to recall something, even if it the metadata doesn't match exactly.
Post-CL metadata, from the Generation tab, may only be recalled from the generation tab. Layers cannot be recalled into UC.

Viewer revised behaviour:

Viewer only exists on Generation tab
Viewer defaults to open
When clicking the Control Layers tab on the left panel, close the viewer (i.e. open the CL editor)
Do not switch to editor when adding layers (this is handled by clicking the Control Layers tab)
Do not open viewer when single-clicking images in gallery
Do open viewer when double-clicking images in gallery
Do not change viewer state when switching between app tabs (this no longer makes sense; the viewer only exists on generation tab)
Change the button to a drop down menu that states what you are currently doing, e.g. Viewing vs Editing

works flawlessly. great job.


helm 3.13.0 has a bug that makes it unable to access charts via oci, please downgrade helm

Description
see issue here https://github.com/helm/helm/issues/12449
helm 3.13.0 is affected
helm 3.12.3 still works
Platforms affected

[ ] Azure DevOps
[x] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
ubuntu-latest
Is it regression?
ubuntu-latest
Expected behavior
working helm version
Actual behavior
helm unable to pull charts from github oci packages
Repro steps
zarathustra@esel ~/code/dof_app_deploy (git)-[bc-5488-pwi] % podman run -it alpine/helm:3.12.3 pull oci://ghcr.io/raffis/charts/mongodb-query-exporter --version 3.0.1
Pulled: ghcr.io/raffis/charts/mongodb-query-exporter:3.0.1
Digest: sha256:1f31985fccbbf66faffba89f498c23aef3d10059d7ad89821452b643f4c33eee
zarathustra@esel ~/code/dof_app_deploy (git)-[bc-5488-pwi] % podman run -it alpine/helm:3.13.0 pull oci://ghcr.io/raffis/charts/mongodb-query-exporter --version 3.0.1
Resolved "alpine/helm" as an alias (/home/zarathustra/.cache/containers/short-name-aliases.conf)
Trying to pull docker.io/alpine/helm:3.13.0...
Getting image source signatures
Copying blob 8f55ccf48d2f done   |
Copying blob 96526aa774ef done   |
Copying blob 0bbba39cff7e done   |
Copying config 9511a681ca done   |
Writing manifest to image destination
Error: failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://ghcr.io/token?scope=repository%3Araffis%2Fcharts%2Fmongodb-query-exporter%3Apull&scope=repository%3Auser%2Fimage%3Apull&service=ghcr.io: 403 Forbidden

Hello, @Loki-Afro. We cannot downgrade the helm in our images since it forces us to pin specific version (we are always trying to install the latest version), however, you can do it runtime with the following snippet:
    steps:
      - name: downgrade helm
        shell: bash
        run: |
          sudo rm /usr/local/bin/helm
          sudo  curl -fsSL https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 > /tmp/helm.sh
          sudo chmod +x /tmp/helm.sh
          sudo /tmp/helm.sh --version v3.12.3
          helm version

After upstream releases a new version of helm you will get it with the new image version.

Hello, @Loki-Afro. Since the workaround was provided and we are waiting for the new version of helm from the upstream, this issue will be closed.
If you have other questions feel free to reach us.

@Alexey-Ayupov A new version of Helm has been released that resolves this issue: https://github.com/helm/helm/issues/12423
https://github.com/helm/helm/releases/tag/v3.13.1

How often are new images released? I'm running into this too...

Who updates the Chocolatey package? It is still v3.13.0


<EMAIL_ADDRESS>hash check failed

Updating 'draw.io' (13.7.9 -> 13.9.8)
Downloading new version
draw.io-13.9.8.exe (70.7 MB) [=====================================================================================] 100%
Checking hash of draw.io-13.9.8.exe ... ERROR Hash check failed!
App:         extras/draw.io
URL:         https://github.com/jgraph/drawio-desktop/releases/download/v13.9.8/draw.io-13.9.8.exe#/dl.7z
First bytes: 4D 5A 90 00 03 00 00 00
Expected:    bdf01b2a8eb490d1ddd607b9bb8e8a19b7c1fb3ab7496cf09dab66955c90a5124092fab5dba6b450411e4ab7a62ad25251d764e57ac4c2f8aa04a19d1cdf80c3
Actual:      2ed2914b853d4180acf396bfcb1135faf353dc5dade4ac39b1474c86930f0ec3a8ce4c0c0271a2b3169a4b80adcf7609047c0621c8dc6684f9f6a0ca96c2591b
Please try again or create a new issue by using the following link and paste your console output:
https://github.com/lukesampson/scoop-extras/issues/new?title=draw.io%4013.9.8%3A+hash+check+failed

ad1331a0b510f5fb56bdf1448aa0cd52380674ef


Problem about relation in notion

Hello there! I would like to thank you for the great work on notero. It is very helpful！ However, I met a problem about relation. If I relate the database of "notero" to another, for example, "Task", I can't find out any existing page of  "notero" in the property named like "relation to notero" in “Task”. And like the property named "Related References" in " notero", I can't find out other existing pages. So I can't relate a page to another page in "notero" or to another page in another database. I was wondering if there is a bug about creating a new page from zotero to notion and it lets the page be "unsearchable" or if there is sth wrong with the database template you were given. I would appreciate it if you can solve the doubts :)
Thank you!

@jianyubej, thanks for using Notero!
I believe I've run into this same thing that you're seeing, and I think it's just how the relation properties work in Notion. As far as I know, they won't show any results for pages to link to unless you start typing a search query.
If you start typing the name of one of the pages that was synced by Notero, does it show up as a result?

Actually, I just played around in Notion a little more, and I think you can get results to show up by clicking in the relation field again after you open it up. You might not have to start a search after all.
https://user-images.githubusercontent.com/299357/153139560-3d65d387-3851-43a1-bf8e-404146a358e5.mp4

Yes, it works! I can get the right relation! Thank you for the help. And thanks again for the fantabulous work on notero. Sincere wishes to you in the distance. May everything go smoothly and happily with you :)


Reading CSV

Maybe I'm missing something obvious.. but is there a way to read a CSV file (e.g., a CSV.File) into an Arrow.Table?

Sure thing. The one thing to remember is that the arrow spec is a specific memory layout. An Arrow.Table is a Julia object that acts as a "view" into that arrow memory, so in order to have a Arrow.Table, we need that arrow memory somewhere first. You could write the data out to an arrow-formatted file, like tbl = Arrow.Table(Arrow.write("data.arrow", csv_file)), or you could keep the data in-memory, for which Arrow.jl provides a convenience function like tbl = Arrow.Table(Arrow.tobuffer(csv_file)).


Genetics front-page has references to the Platform

Some text on the Genetics front-page reference the Platform.

Links are all correct - it is just a matter of updating the text.

Good catch @ireneisdoomed, I will take a look today

On same ticket for convenience, we should also re-design this doc page

we now have a dedicated API page
the F5 queries shown there are outdated

I have edited and committed change on GitHub --https://github.com/opentargets/ot-ui-apps/blob/main/apps/genetics/src/pages/HomePage/HomePage.jsx
Just needs to be pushed to production when a new FE tag is created - perhaps we can wait until more changes are accumulated.


drivers: adc: lmp90xxx: initialise all instances

Iterate through all lmp90xxx device instances found in the devicetree and initialise all of them.
Fixes #32046.
Signed-off-by: Henrik Brix Andersen<EMAIL_ADDRESS>

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop - this is not the case for the the include/devicetree.h macros resembling the introduced, local macro. Is this a hard requirement?

s this a hard requirement?

Just send a patch turning it off. Checkpatch warnings were turned into errors and now it's a game of whack-a-mole to turn off the ones that are noise.

Just send a patch turning it off. Checkpatch warnings were turned into errors and now it's a game of whack-a-mole to turn off the ones that are noise.

Thanks @mbolivar-nordic. I have included it here to get this PR to pass checkpatch. If it needs to go in a separate PR, please let me know.


When using as ES6 module, events don't work

Hello, whether I use events or eventSources, they do not appear in the calendar when using ES6 module configuration according to the documentation:
let ec = new Calendar({
                target: this.$el,
                props: {
                    plugins: [TimeGrid, DayGrid],
                    options: {
                        locale: 'cs',
                        firstDay: 1,
                        view: 'dayGridMonth',
                        events: [
                            {
                                start: '2024-05-03',
                                end: '2024-05-05',
                                title: 'event 1',
                                display: 'background',
                            },
                            {
                                start: '2024-05-02',
                                end: '2024-05-03',
                                title: 'event 2',
                            },
                        ]
                    },
                }
            });

Am I doing something wrong?

I prepared a demo based on your code and the events are displayed fine:

Hmm, not sure why it's not working then. I have it wrapped in an AlpineJS component, maybe that is causing issues. When I use ec.addEvent() it works though.

Please provide a public demo so that I can reproduce the issue.

@lukas-frey any update?

Hi, no, when I created a plain JS project on stackblitz using an Alpine component, it worked.
I use it in a project with Laravel, Livewire, AlpineJS and FilamentPHP. There's a lot of places where it could have gone wrong, so the error is somewhere on my side probably. Thanks for your help though!


Document limitations of globalShortcut

As described in https://github.com/atom/electron/issues/3808.

Thanks!


Implementation between different servers on the cloud?

I want to put a django SSO server on the cloud in its own server, like "sso.example.com".
Then I want to use a service let's call it "service1.example.com".
We basically have two different servers now, each with their own OS.

Question:
How can "service1.example.com" communicate with django sso server so it can authenticate the tokens and retrieve user information settings?

Hi! The whole point of JWT is that tokens are authenticated without communication between the servers using cryptographic signatures.
Any information you need on the other servers, you'll have to embed into the short-lived authorization tokens that the sso server issues.
Please see the README:
https://github.com/namespace-ee/django-rest-framework-sso#additional-data-in-authorization-tokens

More details is needed, I have a problem with public keys since i keep getting "Unauthorized token signing key." exception.
below is for primary app
REST_FRAMEWORK_SSO = {
    'CREATE_AUTHORIZATION_PAYLOAD': 'django_sso.users.adapters.create_authorization_payload',
    'IDENTITY': 'django_sso',
    'SESSION_AUDIENCE': ['django_sso'],
    'AUTHORIZATION_AUDIENCE': ['django_sso', 'service1'],
    'ACCEPTED_ISSUERS': ['django_sso'],
    'PUBLIC_KEYS': {
        'django_sso': 'django_sso/keys/sso-service.pem',
    },
    'PRIVATE_KEYS': {
        'django_sso': 'django_sso/keys/sso-service.pem',
    },

    'ENCODE_ALGORITHM': 'RS256',
    'DECODE_ALGORITHMS': None,
    'VERIFY_SIGNATURE': True,
    'VERIFY_EXPIRATION': True,
    'VERIFY_ISSUER': True,
    'VERIFY_AUDIENCE': True,
    'VERIFY_SESSION_TOKEN': True,
    'EXPIRATION_LEEWAY': 0,
    'SESSION_EXPIRATION': None,
    'AUTHORIZATION_EXPIRATION': datetime.timedelta(seconds=300),

    'KEY_STORE_ROOT': None,

    'AUTHENTICATE_HEADER': 'Bearer',

}

and below is for a service that consumes the jwt:
REST_FRAMEWORK_SSO = {
    'AUTHENTICATE_PAYLOAD': 'service1.utils.authentication.authenticate_payload',
    'VERIFY_SESSION_TOKEN': False,
    'IDENTITY': 'service1',
    'ACCEPTED_ISSUERS': ['django_sso'],
    'PUBLIC_KEYS': {
        'service1': 'config/keys/sso-service.pem',  # only public key in this file
    },
    'AUTHENTICATE_HEADER': 'Bearer',
}

The problem might be that you are not defining KEY_STORE_ROOT and that the key id's do not match.
django_sso/keys/sso-service.pem => gets converted to key_id django_sso/keys/sso-service, but no such path exists on the jwt consumer side.
I would reccommend setting the correct path to and including the keys folder in both servers, and then dropping the 'django_sso/keys/ and config/keys/ prefixes. Then your key id will be just sso-service which matches on both.

Updated the recommended config as well in README:
https://github.com/namespace-ee/django-rest-framework-sso/commit/b1dbdfddd76f59af02133d5d9416f78845234c32

It works well now, thanks a lot.
I hope more work is done on the documentation so it can be more clear, its implementation is quite good but not as clear in the first try.


Unreal 5 Export : No module named 'mm'

Material Maker 1.3
Windows 10
When exporting a material for Unreal 5.
Following the documentation : https://rodzill4.github.io/material-maker/doc/export.html?highlight=unreal 5#unreal-engine-5
I have an error when executing the clipboard content into the Unreal Python prompt :
LogPython: Error: Traceback (most recent call last):
LogPython: Error:   File "D:/material_maker_1_3_windows/export/term.py", line 2, in <module>
LogPython: Error:     import mm
LogPython: Error: ModuleNotFoundError: No module named 'mm'

"mm.py" is located in "material-maker-master\material_maker\misc\export" in the source .zip, but missing in the release files.
Copying the "mm.py" file in the "export" folder solves the problem.

not working for me

Has there been a solution to this issue?
The first time I tried to export to UE5, I got these Python messages in UE after executing the line loaded in the clipboard;
LogPython: Error: Traceback (most recent call last):
LogPython: Error:   File "E:/MatMake/material_maker_1_3_windows/export/bricks_unreal5.py", line 4, in
LogPython: Error:     reload(mm)
LogPython: Error:   File "C:\Program Files\Epic Games\UE_5.3\Engine\Binaries\ThirdParty\Python3\Win64\lib\importlib_init_.py", line 168, in reload
LogPython: Error:     raise ModuleNotFoundError(f"spec not found for the module {name!r}", name=name)
LogPython: Error: ModuleNotFoundError: spec not found for the module 'mm'
So I tried copying mm.py to the above referenced importlib directory, Then I got these error messages;
LogPython: "E:/MatMake/material_maker_1_3_windows/export/bricks_unreal5.py"
LogPython: Error: Traceback (most recent call last):
LogPython: Error:   File "E:/MatMake/material_maker_1_3_windows/export/bricks_unreal5.py", line 2, in
LogPython: Error:     import mm
LogPython: Error: ModuleNotFoundError: No module named 'mm'
Progress I guess but still no joy. Thinking it's a symptom of installing MM my E drive while UE is installed on my C drive, I deleted mm.py from the importlib directory and installed MM on my C drive with material_maker_1_3_windows as the main directory. I got the same error messages as the attempt before. I know next to nothing about Python so I don't know what else to try.

Has there been a solution to this issue?

You have to add the path to the mm.py file in Unreal Engine's Python path.

Thanks, I forgot about that while doing different installs.
I had a faint hope that you had found a way to import an editable procedural UE material with MM's fantastic nodes (that put UE's to shame), it was a bit of a let down to just see three (admittedly great) texture images attached to a PBR output.  I realize my expectations were unrealistic.
The imported UE material has a two disconnected nodes, Default Texture Object and ParallaxOcclusionMapping. How do these relate to the original MM material?


[stable/grafana] Fix issue with literal (|) being added to deployment yaml when using extraContainers

Signed-off-by: Michael Lamanuzzi<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No
What this PR does / why we need it:
When using extraContainers configuration, a literal pipe is added to the deployment yaml output when following the example provided in values.yaml.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #13986
Note: this fix was already proposed by @HaveFun83

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test
/lgtm

/assign

/retest

@mlamanuzzi
Could you bump the chart again please? Thank you.

/lgtm

This fix broke my working configuration. I am not too sure what the reason might be. Is it intended to not work with such a configuration?
Here is my configuration:
# ...
extraContainers:
- name: grafana-image-renderer
  image: grafana/grafana-image-renderer:1.0.7
  ports:
    - name: image-renderer
      containerPort: 8081
  resources:
    limits:
      cpu: 50m
      memory: 128Mi
    requests:
      cpu: 50m
      memory: 128Mi
# ...

and the error I get:
Linting release=grafana, chart=/var/folders/x_/rxt_0rrj1tb08pp2cf7f2mp00000gn/T/140727471/grafana/latest/stable/grafana/grafana
==> Linting /var/folders/x_/rxt_0rrj1tb08pp2cf7f2mp00000gn/T/140727471/grafana/latest/stable/grafana/grafana
[ERROR] templates/: render error in "grafana/templates/deployment.yaml": template: grafana/templates/deployment.yaml:48:10: executing "grafana/templates/deployment.yaml" at <include "grafana.pod" .>: error calling include: template: grafana/templates/_pod.tpl:279:7: executing "grafana.pod" at <.>: wrong type for value; expected string; got []interface {}


How to Inject this service into the Route

Will you please explain how to inject this service into a route.

I think you have found a bug. The service is currently injected to Controllers and Components as cart:main however that means if you try and inject the service in the way services want to be injected in Ember:
cart: inject()

it will not work as expected as it will create difference instance.
I think the way to do this is to remove the instance initializer and just rely on service injection. If you want to PR this change let me know. Else I can probably do it later this week.

Great it worked ! Thanks :dancing_men:


Spartacus with angular 8 does not work with a shell app

I tried to deploy the latest spa on dev17. It compiles and starts fine but we don't get a response from the server.

There are no warnings nor error messages in server console either

Here is a fix for it: https://stash.hybris.com/projects/C3PO/repos/spartacus-installation/pull-requests/27/overview
One thing was that we changed our main module from StorefrontModule to B2cStorefrontModule.
Other issue is that new cli sets the target to es2015 and spartacus currently doesn't work with it in production mode. Develop mode works tho. Temporary I added template tsconfig with old es5 target set.
Also updated dev-com-17 with this fix and it works.
I will add a note to docs about changing the generated target from es2015 to es5.

@gladius-mtl Changes to docs in feature/GH-2911 wiki branch.

Renamed StorefrontModule to B2cStorefrontModule
Changed info about translations to import from new library @spartacus/assets
Added paragraph about es5 target in tsconfig.json required for Spartacus to work properly.

i updated the spartacus setup docsc to include a section on using incremental libraries with angular 8 (bottom of https://github.com/SAP/cloud-commerce-spartacus-storefront/wiki/Building-the-Spartacus-Storefront-from-Libraries)


Page title is too big for search results

Also says that is not mobile friendly

Any ideas here: https://github.com/excalidraw/excalidraw/blob/master/public/index.html#L6-L7

How about something on the lines of:

Excalidraw | Hand-drawn • Collaborative • Secure`

Though, I don't like the "Hand-drawn", because that doesn't describe it.
Or emoji version:

Excalidraw | Hand-drawn :clap:  Collaborative :clap:  Secure

(a joke.. also google doesn't support emojis in results, or do they?)

Variation:

Excalidraw | Hand-drawn diagrams • Collaborative • Secure

No emojis please! :D

Excalidraw | Hand-drawn look • Collaborative • Secure

Lots of people have called it a Virtual Whiteboard fwiw

Also says that is not mobile friendly

Seems like the errors are “Text too small to read” (likely referring to the shortcut things) and “ Clickable elements too close together” (likely referring to the shape switcher)


SassError: Undefined variable - null: $box-shadow

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Everything was fine, and now an error has come from somewhere 😳...
node 17.1.0
npm 8.1.4
"devDependencies": {
"@babel/core": "^7.16.0",
"@babel/preset-env": "^7.16.4",
"autoprefixer": "^10.4.0",
"babel-loader": "^8.2.3",
"css-loader": "^5.2.7",
"cssnano": "^5.0.11",
"fantasticon": "^1.2.3",
"mini-css-extract-plugin": "^1.6.2",
"postcss": "^8.3.11",
"postcss-loader": "^5.3.0",
"sass": "^1.43.4",
"sass-loader": "^10.2.0",
"style-loader": "^2.0.0",
"terser-webpack-plugin": "^5.2.5",
"webpack": "^5.64.2",
"webpack-cli": "^4.9.1"
},
/opt/homebrew/bin/node /opt/homebrew/lib/node_modules/npm/bin/npm-cli.js run build-prod --scripts-prepend-node-path=auto

><EMAIL_ADDRESS>build-prod
> webpack --mode production

...

ERROR in ./src/site/scss/index.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Undefined variable.
   ╷
60 │         null: $box-shadow,
   │               ^^^^^^^^^^^
   ╵
  node_modules/bootstrap/scss/_utilities.scss 60:15    @import
  src/site/scss/config/testsite.com-styles.scss 6:9  @import
  src/site/scss/index.scss 1:9                         root stylesheet
  ...
 @ ./src/site/js/index.js 25:0-28

1 ERROR in child compilations (Use 'stats.children: true' resp. '--stats-children' for more details)
webpack 5.64.0 compiled with 2 errors in 1269 ms

Reduced test cases
SassError: Undefined variable.
╷
60 │         null: $box-shadow,
│               ^^^^^^^^^^^
╵
node_modules/bootstrap/scss/_utilities.scss 60:15    @import
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
5.1.3

sorry...


Implement PartialEq and Eq for CoreId

This PR makes possible comparison of values returned from get_core_ids() call.

I actually did this as part of an update.


Added Hollow Triange Pattern #34 in Python

Added pattern34.py with a few test cases pasted below:

Apologies and thank you for the feedback. Moving forward, I will make sure that I am assigned an issue before submitting a PR.


codec specification in v3

I will summarize a few concerns I have about the way codecs are handled in the v3 spec, and propose some changes that I think could improve this situation.
the codec problem space
We need Zarr implementations across multiple languages to agree on standard JSON serialization for different codecs. This protects users from fragmentation, e.g. a situation where we end up with multiple flavors of JSON serialization for the same popular codec. At the same time, we want to make it easy for users to experiment with and create new codecs; this enables users to get the most from Zarr.
Also, codecs are generally useful for users outside of Zarr. There are plenty of non-Zarr use cases for compressing / rearranging array data. So I think the codec standardization should support these non-Zarr use cases.
concerns with codecs in the v3 spec

The v3 spec explicitly states that it does not define a list of codecs, but it does define a list of codecs. We can't have blatant contradictions in the spec, so this needs to be sorted out at a minimum, regardless of whatever decisions we make. The contradiction between the text of the spec and the codec definitions was already a source of confusion in a pull request in zarr-python.
Suppose we resolve the above contradiction by stating that zarr v3 does in fact define a fixed set of codecs, where are listed in in the spec. This leads to two sub-problems:

How does someone design and use a new codec? We cannot require PRs against the spec for every new codec. If writing a new codec started with getting a PR accepted in zarr-specs, nobody would ever write a new codec.
What happens if an implementation does not support a codec from the standard list? There is no enforcement mechanism for the requirement that an implementation support that fixed set, so practically the requirement is toothless, which means it cannot be a requirement. Requirements in the spec should be restricted to essential features, but supporting the Gzip compressor is simply not essential, for users who don't work with Gzip-compressed data. So any list of codecs should be a recommendation, not a requirement.

The v3 spec states that the unique identifier for a codec must be "... a URI that dereferences to a human-readable specification of the codec".
Software cannot check if a URI dereferences to a human-readable document. If we want Zarr v3 hierarchies to be validated by software, we must remove this requirement.

how to resolve these concerns
I don't think naming a closed set of "official codecs" in the spec is realistic. There is no enforcement mechanism, and ultimately users don't care if an implementation doesn't support a codec they don't use. That is, if an implementation doesn't support codec X, and none of the users of that implementation use codec X, then IMO this is fine.
To express this differently, I think the Zarr spec should not enumerate the features / behavior an implementation must have. The Zarr spec should just describe the Zarr format, and we leave it to implementations to choose how they implement that format.
Extending this logic, the Zarr format is actually agnostic with respect to particular codecs. So specific codecs should not appear in the Zarr spec! I actually think codecs should be defined entirely in another spec, and we refer to this spec in the Zarr spec, e.g. "codecs is a JSON array of JSON objects that implement the Numcodecs spec (link to the numcodecs spec)" (we can choose a different name for the codecs spec, but it shouldn't refer to zarr).
Recall that In Zarr v2, codecs were basically standardized by the behavior of the numcodecs python library, which was a stand-alone library with no Zarr dependency. I think this illustrates the right relationship between codecs and the zarr format, but we shouldn't rely on a python library to define a standard for a cross-language concern. Zarr v3 tries to fix the latter problem by folding codec definition inside the spec itself, but as I have argued, this introduces a different set of problems. The solution is to define codecs separately, and make the zarr spec depend on that codec spec. The codec specification can manage a registry of codecs, etc, thereby abstracting the current behavior of numcodecs in a language-agnostic way.
Another advantage of a separate spec for codecs is that this spec could be used by any project that wants to compress arrays in a standard way. There is nothing Zarr-specific about serializing GZip parameters to JSON, so lets reflect this in the structure of the specification document.
tldr; I think the list of codecs in v3 is trying to solve a problem (a language-agnostic list of codecs) that we can solve in a better way: by migrating the codec specification from Zarr v3 into its own spec.
is this too much churn in the spec
I know it sucks to hear complaints about the spec after it's been finalized. Sorry. But I want zarr v3 to be really good, and I think the way we do codecs in v3 right now is very problematic; if my concerns are valid, then we owe it to users to get this resolved as soon as possible.

I think one of the biggest shortfalls of Zarr V2 is the lack of codec standardisation. Numcodecs has many codecs, but they are not very useful if they are unsupported by other zarr implementations and data viewers.
A zarr implementation does not need to support every codec to be conformant, but spec'ing codecs and supporting them across more than just one implementation is essential to move forward and increase adoption. What better place to put zarr codec specs than alongside the zarr spec?

We cannot require PRs against the spec for every new codec. If writing a new codec started with getting a PR accepted in zarr-specs, nobody would ever write a new codec.

A codec does not have to start with a spec, it can start with an experimental implementation. That is basically what most of the codecs in numcodecs are. Similarly, I have multiple experimental Zarr V3 codecs implemented in zarrs that I plan to put forward once the new ZEP process has been figured out.

I think one of the biggest shortfalls of Zarr V2 is the lack of codec standardisation. Numcodecs has many codecs, but they are not very useful if they are unsupported by other zarr implementations and data viewers.

I agree with this completely. My concern here is not whether we should standardize codecs; it's whether we should standardize codecs inside the Zarr specification document, or in a separate specification document.

What better place to put zarr codec specs than alongside the zarr spec?

I think outside the Zarr spec entirely is the best place to put the codec specs. The codecs don't depend on Zarr; instead, Zarr depends on them.

A codec does not have to start with a spec, it can start with an experimental implementation.

That's a good idea, but technically your codecs cannot start with an experimental implementation. According to the text of the spec, your experimental codec is only valid when it is defined in a separate specification, and you give your codec a URI that resolves to a human-readable specification of the codec. Personally I don't think this is a reasonable requirement for experimental codecs.

Just copying my response from the zarr-python thread here:

I think it is useful to have minimal set of codecs that we expect any zarr impl to support (e.g. bytes, transpose, blosc). Other codecs can be optional. I think the zarr specification is a actually good place to list available codec specs.

I feel quite strongly, that non-standard codecs need to be labeled as such (e.g. through URI-style naming instead of short names). Having multiple codecs (even if the encoded format is only slightly different) with the same name would be a desaster. Perhaps zarr-python should even enforce that (ie. don't allow short names for non-standard codecs).

@normanrz could you elaborate on these points a bit? Do you think the spec should require or merely suggest that implementations support a fixed set of codecs? If you want this to be a requirement, how would we enforce it?
Given that the spec currently requires that all codecs have a specification, how do we formally distinguish "standard" from "non-standard" codecs? What is the process for converting a "non-standard" codec to a "standard codec", or vice versa?

Do you think the spec should require or merely suggest that implementations support a fixed set of codecs?

Some codecs are essential to how Zarr works and should be required by all implementations. Most minimally, that is the bytes codec. Other codecs are so popular and general that all implementations should implement it, e.g. blosc, transpose, gzip, zstd, sharding_indexed. Then, there might be codecs that might only be relevant for a subset of the community, such as image or segmentation compression codecs. These might be optional from a Zarr pov but required by higher level format (e.g. OME-Zarr).

If you want this to be a requirement, how would we enforce it?

I like to think that enforcement of the Zarr spec comes through validation from multiple implementations. When opening an array or group, implementations parse the metadata and therefore implicitly or explicitly validate the metadata.
If you only ever use your data with a single implementation, you might not get that validation. But then you also might not care about the interoperability that the spec provides.
Of course, we could (and maybe should) also provide validation tools alongside the spec (e.g. json schema).

Given that the spec currently requires that all codecs have a specification, how do we formally distinguish "standard" from "non-standard" codecs?

"Standard" codec get a short name assigned by the Zarr spec (e.g. bytes). "Non-standard" codecs have a URI-style name (e.g. https://zarr.dev/numcodecs/lz4). That way, we minimize the risk of non-standard codecs conflicting each other. I think we can drop the requirement that the URI points to a human readable codec spec. A unique name should suffice for my concerns.

What is the process for converting a "non-standard" codec to a "standard codec", or vice versa?

I think we can use the ZEP process for that. Implementations that support non-standard codecs might need to support both names once a codec becomes standardized.

What better place to put zarr codec specs than alongside the zarr spec?

I think outside the Zarr spec entirely is the best place to put the codec specs. The codecs don't depend on Zarr; instead, Zarr depends on them.

From a theoretical pov, I can see that splitting the codec spec from Zarr might make sense. From a practical pov, I don't see how that would make anything easier or facilitate interoperability among the Zarr impls. I think it is best to keep the codec spec in the Zarr spec.

Is the current set of codecs inside the zarr spec?

I think they are.

given that the zarr v3 spec document itself says that it doesn't define a list of codecs (and this claim is internally consistent -- that document does not in fact define a list of codecs), what spec are are the codec definitions part of?

I think it is unfortunate that the paragraph you cite did not get updated during the v3 spec process (a quick git blame shows that). I agree that it is inconsistent because the spec actually lists codecs. Most implementations have implemented this list of codecs. We should certainly revise this paragraph.

I have a question regarding the bytes codec and its parameter endian. It seems as though it was designed with numpy in mind give that a numpy array can be converted to bytes using the to_bytes(order) method. How is this codec meant to be implemented in other languages that do no offer such functionality for multi-dimensional arrays? For example, in ocaml the most obvious way to serialize a multidimensional array is to use the Marshal, but apparently its not very reliable because any serialized bytes need to be deserialized using the same version of ocaml that it was serialized in. Using this technique means that the parameters and details outlined in the spec are completely ignored. Are there any other implementations in the wild that can be used as a reference? Are there any other array -> bytes codecs that can be used?

I think one of the biggest shortfalls of Zarr V2 is the lack of codec standardisation. Numcodecs has many codecs, but they are not very useful if they are unsupported by other zarr implementations and data viewers.

I agree with this from two points of view:

As a data provider I want to ensure that the codec I use is supported by all applications that (claim to) open zarr datasets
As an implementation writer (this is a hypothetical point of view 😄), I would want to know exactly which codecs I need to implement to support reading all zarr data

So I am in favour of having a finite set of codecs included in the zarr spec that implementations must support.
To come back on some of the concerns above:

If writing a new codec started with getting a PR accepted in zarr-specs, nobody would ever write a new codec.

I'm not sure this is true - most of (all?) the codecs currently used by zarr were developed independently of the zarr spec by teams outside the zarr developers, so would exist regardless of zarr existing.

Requirements in the spec should be restricted to essential features, but supporting the Gzip compressor is simply not essential, for users who don't work with Gzip-compressed data. So any list of codecs should be a recommendation, not a requirement.

Supporting sharding is not essentials for users who don't want sharded data, but it is a useful enough feature for enough people that it's worth mandating it as part of the spec, so for those users who want to use it they know it is guarenteed to be supported. I think the same argument holds for a list of standard codecs - I might not want to use all of them, but I want to be guarenteed that the one I do use is supported by all implementations.

There is no enforcement mechanism

Well, there's no 'enforcement mechanism' for any of the spec, but if someone wants to claim the have written an implementation then they have to implement the whole spec. I'm not sure why codecs would be any different here?

So it seems like most people in this conversation believe that the v3 spec should specify a set of codecs that Zarr implementations must support. This is at variance with the language of the spec today:

To allow for flexibility to define and implement new codecs, this specification does not define any codecs, nor restrict the set of codecs that may be used. Each codec must be defined via a separate specification. In order to refer to codecs in array metadata documents, each codec must have a unique identifier, which is a URI that dereferences to a human-readable specification of the codec. A codec specification must declare the codec identifier, and describe (or cite documents that describe) the encoding and decoding algorithms and the format of the encoded data.
...
The Zarr core development team maintains a repository of codec specifications, which are hosted alongside this specification in the zarr-specs GitHub repository, and which are published on the zarr-specs documentation Web site. For ease of discovery, it is recommended that codec specifications are contributed to the zarr-specs GitHub repository. However, codec specifications may be maintained by any group or organisation and published in any location on the Web. For further details of the process for contributing a codec specification to the zarr-specs GitHub repository, see ZEP 0 which describes the process for Zarr specification changes.

To make the spec document match the general opinion expressed in this issue (i.e., that the spec should list a required set of codecs), we need to make the following changes:

Add language to the spec stating that the spec does contain a set of codec specifications, and all implementations MUST support the codecs defined in this set. We could explicitly list the codecs that implementations must support by name, or simply say "implementations MUST support the codecs defined in link_to_codecs.html".
 It's also not clear that the codec identifier should be a URI in the first place. See https://github.com/zarr-developers/numcodecs/pull/524, for codec implementations where a URI was not used as the identifier.
Remove the "under construction" filler text in the header of this document, and replace it with some explanatory content: https://github.com/zarr-developers/zarr-specs/blob/main/docs/v3/codecs.rst
Remove this statement: "For ease of discovery, it is recommended that codec specifications are contributed to the zarr-specs GitHub repository."; codecs should only be added to the zarr-specs repo if we believe that all zarr implementations must add support for that codec; in practice, I think adding a codec to the zarr-specs repo would only make sense if all the zarr implementations already supported that codec.

Do these changes seem sufficient? If so, we can start writing up a ZEP.

Regarding the Zstd draft spec in https://github.com/zarr-developers/zarr-specs/pull/256, is the checksum parameter really necessary? I went though the list of implementations in different languages and it seems the large majority do not support adding a checksum to the compressed output. Wouldn't this limit how many Zarr implementations can support this codec's spec? It sounds to me that we need to be careful not to define a codec's spec based mostly on the features provided by it's python implementation and also consider what features many other languages offer.


Update classbuilder.cpp

Added one generated header to include all the generated headers, and fixed the names of networked variables that could make compiling errors while including the headers. Everything should work fine now.

Thanks for the contribution


Add aihwkit.cloud.client package

Related issues
#169
Description
Add an aihwkit.cloud.client package that allows connecting to the upcoming API for executing remote experiments, making use of #177 for experiment conversion.
Details

Merging despite the travis failed check, as it seems related to the travis org-account setup.


error connecting to YubiHSM2: HSM error: HSM error: MemoryError

When execute tmkms yubihsm detect will get result like
Detected YubiHSM2 USB devices:
- Serial #0001234567 (bus 20)

But execute tmkms yubihsm detect will get this result
error: error connecting to YubiHSM2: HSM error: HSM error: MemoryError

But yestoday i can add key and show list, is the HSM broken? I just let it inside my mac one night...

The bottom error is very strange: MemoryError is also a generic placeholder error the YubiHSM provides when it fails to decode a more detailed error code.
Does the error happen every time now? Can you reproduce it? If you can, can you try:
RUST_BACKTRACE=full tmkms yubihsm detect

Yes, it happens every time.
The result of executing RUST_BACKTRACE=full tmkms yubihsm detect is
Detected YubiHSM2 USB devices:
- Serial #0001234567 (bus 20)

it is the same as tmkms yubihsm detect

Can you try running tmkms yubihsm detect -v and posting the full trace, especially the part that includes error: error connecting to YubiHSM2: HSM error: HSM error: MemoryError. This should at least show the commands being sent to the HSM and the raw response code.

The result of tmkms yubihsm detect -v

Try tmkms yubihsm keys list -v

Yes, i have tried yubihsm: unrecognized option -v, but the result is
yubihsm: unrecognized option `-v`

Do any of the other commands work? (e.g. tmkms yubihsm keys generate)

it's my problem, the error occured after changing the key of auth in tmkms.toml~ sorry~

@yulidai interesting... an authentication error was my best guess at what was happening, but those usually manifest in a slightly different way. I'll take a look at the codepaths there and see if I can make the error message better.


Kubeflow-mlops example

What does this PR do?
an end to end example of using Kubeflow on EKS, including:
EKS provision
kubeflow installation
related AWS services (ALB, CSI driver) installation
kubeflow config and quick start
Motivation
We (data lab team) recent met with EKS team which asked us to provide more guidance on kubeflow on EKS. We would like to use this example as first step. Demo to clients and get feedback.
More

[ ] Yes, I have tested the PR using my local account setup  (Provide any test evidence report under Additional Notes)
[x] Yes, I have added a new example under examples to support my PR
[ ] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
[ ] Yes, I have updated the docs for this feature
[x] Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

terraform_tflint failed in pre-commit test. those files are not checked in by this PR but from others.
https://github.com/aws-ia/terraform-aws-eks-blueprints/runs/7619057100?check_suite_focus=true

Thank you @season1946 for this much needed PR 🙌 I think we have a open issue which needs to be tagged to this PR.
We will take a look and review the PR. 👍

This is a massive PR. We will not be able to accept any PR that has 1,792 files changed. Lets work on reducing the scope of changes in the PR.

remove kubeflow source code from PR
extend README.md to guide user how to pull source code by themselves and then modify three yaml files based on their configuration


Fix 10/-1 parity error and add tests

Fixes #40. Ping @silentmatt @cashbit. Thought this would be very complicated, but your advice was spot on! Can't guarantee 100% everything is correct now, but this adds previously-failing tests and tweaks tokenprio to get them to pass.
Thanks for the help!

Specific weird-ish tests added:
      ✓ 10/-1
      ✓ 10*-1
      ✓ 10*-x
      ✓ 10+-1
      ✓ 10/+1
      ✓ 10*+1
      ✓ 10*+x
      ✓ 10+ +1


Deployment of package Microsoft.WindowsAppRuntime.1.3_3000.882.2207.0_x64__8wekyb3d8bbwe was blocked

Describe the bug
When some users try to install our WinUI app that depends on the latest Windows App SDK 1.3, the update of the Windows App Runtime is blocked and they get the following error message (in AppInstaller):
"Deployment of package Microsoft.WindowsAppRuntime.1.3_3000.882.2207.0_x64__8wekyb3d8bbwe was blocked because the provided package has the same identity as an already-installed package but the contents are different. Increment the version number of the package to be installed, or remove the old package for every user on the system before installing this package. (0x80073cfb)"
This happens on a clean Windows installation with all the new updates installed.
Apparently, there is a Windows update that comes with version 1.3.230602002 of the Windows App SDK, but this version has different content compared to the Windows App SDK that is deployed with my app using Visual Studio.
Steps to reproduce the bug

Use a clean Windows 11 machine
Make sure to install all Windows updates
Try to install Xelion https://appinstaller.xelion.com/winapp/v8n/Xelion-Package.appinstaller
The installer shows an error message "Deployment of package Microsoft.WindowsAppRuntime.1.3_3000.882.2207.0_x64__8wekyb3d8bbwe was blocked because the provided package has the same identity as an already-installed package but the contents are different."

Expected behavior
Installation must succeed.
Screenshots
No response
NuGet package version
Windows App SDK 1.3.2: 1.3.230602002
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

If I compare the Windows App SDK 1.3.2 installations using MSIX Hero, I see these differences:
On a clean Windows 11 installation with updates:

177 files !!
As Deployed by Visual Studio:

178 files!!

Thanks Wim - agreed, this is a serious issue.  We will be releasing WinAppSDK 1.3.3 very soon, and I've confirmed it resolves this issue.  Meantime, we'll investigate to prevent it happening again.

Thanks Scott!

We’re seeing the same issue (error 0x80073cfb from DeploymentManager::Initialize()). Glad to hear this will be fixed with the next SDK release.

@Scottj1s do you have an update when the 1.3.3 version will be released? We have a lot of users running into this bug as well as #3775.

@triplef Version 1.3.3 is already available. See: https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/downloads#windows-app-sdk-13

Ah great, thanks!
I was watching GitHub releases, which haven't been updated yet.

Closing this issue as resolved with 1.3.3


Question: default values for Health check

Hello,
Is it possible to specify the default values for the following health check properties:
initializing_timeout:
reinitializing_timeout:
interval:
response_timeout:
healthy_threshold:
unhealthy_threshold:
strategy:

I have been looking all over the Rancher documentation but could not find the answer. Maybe this can be included in a newer version of the docs.
Thanks in advance!

No; the default is that there is no healthcheck, and the defaults once you turn it on in are in the UI code and not configurable.

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


log capture of EOM log messages

In running Deuterium, it doesn't look like the EOM data is getting logged to any logger in the application (Auth, Bastion, Governor, Metrics). Therefore we need to:

Provide a method to setup the logging module to log to a given location
Determine that there is already a method to configure it and provide instructions on how to do so

Since EOM uses oslo.config there may already be a method of doing this that is preferred and not require any extra work to do so. If possible, let's use that.

Issue #62 resolves this.


Add headers for the two types of morphology (detail view)

Please add the following headers in the Morphology panel in the detail view: "Sequential Morphology" for the compound parts (the top two parts), and "Simultaneous Morphology" for the list of morphemes (the third/bottom part).

Done.

@susanodd , please make the headers visible also when there are no entries in any of the tables.


Uuid -> Leafref at Notifications

All *Notification::objectIdRef attributes will become _objectIdRef attributes generated from shared associations to LTP class in UML. This applies on all notifications.
All *notification::object-id-ref leaf will become leafref to LTP.
Only object-deletion-notification::object-id-ref : leafref will be "require-instance false;"

(copied the comment content from openBackhaul/vlanInterface/issues /7 )
All object-id-ref have been made require-instance false, because there was no way in Papyrus to make the UML2YANG tool to not add this statement.
No impact on the end2end functionality is expected from that.

Solved with WredProfile_1.0.0-tsp.220330.1950.


Create pt-br language file

Creates a validation.php file for the Portuguese(Brazil) translation.

Thank you, but we do not plan to support the Portuguese language. If you want to contribute, the contributions for our "good first issue"s are welcome (https://github.com/EotvosCollegium/mars/issues?q=is%3Aopen+is%3Aissue+label%3A"good+first+issue" )


This project has been built by community - by people like you and me, who spent their precious time to implement "this shit" for free and for everyone to use.


VM: Error message refers to generated name.

The following program can be executed with dart --checked version 1.25.0-dev.16.4, producing an output which includes type 'int' is not a subtype of type 'String' of 'value' where ..:

class C {
  int i = 42;
  String s;
  foo() {
    s = i;
  }
}

main() {
  new C().foo();
}

Surely, it is just because s = i is an invocation of the implicitly generated setter s=, and that setter has an argument named value. But that setter was generated implicitly, and the developer can't know the name of its argument. In a more complex setting, developers may start chasing things named 'value' for a while.
So maybe that case should be detected, and something about "calling the setter s=" could be reported, rather than talking about 'value'?

@crelier can something be done about this error message? I am suspecting it is coming from the dst_name computed from the argument passed to TypeCheck in runtime_entry.cc

That's a pretty bad error message, indeed. We should be able to detect the implicit setter where dst_name is set and we should replace 'value' by the field name 's'.
I'll have a look.


tests/eas/generic: Lower ramp tests duration

Each test in generic.py has a time duration set to 2s. However,
the "time_s" entry for rt-app ramps is the duration of each step,
and not the duration of the whole ramp. As such, each ramp test
lasts 26 seconds instead of 2.
This commit sets the whole duration of each ramp test to 2s.

I tested this on HiKey960 and it didn't seem to impact the test results nor the shape of the trace (apart from its duration obviously).

What about just setting a constant and reasonable step size, e.g. 100ms per step?
Then the test will last for as much required by the number of steps?
Not entirely sure however, was just trying to see which configuration can be easier to validate in post-processing. The advantage of the fixed duration is that, for example, we can know exactly what should be the PELT changes in a predefined time internal.

I think @derkling's proposal might be the best way to go in terms of validation. I'll still add a duration_s argument to rta.Ramp because it's something I often felt the need for, but it'll be separate from this PR. Any objections ?

Fine by me

I'm OK with the idea of a per-step metric but I'm not sure about a fixed duration. What happens if you change the task's period to 200 ms and you keep a 100ms step ? Maybe the per-step metric should be a specific number of task activation ?

@qperret I think the important part of the ramp tests is the steps themselves. I don't know how the workload will look like if the step duration is below the task period, but I guess it will just be rounded up and that's fine to me, we'll still have the utilization steps - my only reason for pushing this PR is that the ramp tests take a lot of time to run when they could be drastically shortened.

I agree with the idea to speedup a bit the test, my main concern is that the step time you propose is likely a bit short for PELT to stabilize. If we consider a standard 32ms half-life PELT, a 70% task with 16ms period can take up to 250ms to enter the stable region.
You can easily check these timing by playing with this PELT simulator:
https://gist.github.com/derkling/6d1d3a3164b0291ef64fa409f61a81cb
For our analysis, I would suggest to use something in the range of 300-500ms to be on the safe side with all our tests.

@derkling Fair point, I think I'll bump up the step time to 500ms - that's still a 4x time improvement for the test, and should remain safe for PELT stability.

Bumped step time to 500ms & update commit message.


Does it support complex nested statements?

Does it support complex nested expressions in yaml files？

Might be able to help if you can share a basic use case. We usually store all our rules in MongoDb as Json. We have some rules which uses for loop with nested ifs.

I agree with @dvgaba , an example would help because I'm not sure I understand your requirement.
Regardless of the rule descriptor format (yaml or json), the condition is a String, so the expression can be as complex as you want. For actions, it is an array of Strings, so same here you can add as many (complex) actions as you want.
I'm closing this issue for now, but you can add a comment if you need further help.


OOM trigger

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The Idea Is to détect and alert when pod was killed by Out or memory.
Describe the solution you'd like
A clear and concise description of what you want to happen.

This already exists, doesn't it?

Hello,
Does it OOMKilled works? Yesterday I installed and at night I had couple OOMKilled pods, I see in logs, but kwatch didn't reported. Maybe need some how torn on notification in configuration?

I just installed this on our cluster ( Kubernetes 1.19.15 ) and received an OOMKilled notification as expected.


Add syntax checker

Codecov Report

Merging #18 (e395a70) into main (9b2970c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   96.15%   96.15%
=======================================
  Files           1        1
  Lines          26       26
=======================================
  Hits           25       25
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b2970c...e395a70. Read the comment docs.


feat: implement forgot password and reset password

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


More documentation on the config setup

Heya, I'm trying to figure out how to set this module up, and well, I'm having trouble. First off, how do you get the different states for events, or variables?
I'm doing this for Hollow Knight. There is an auto splitter for Hollow Knight in ShootMe/LiveSplit.HollowKnight, and there are some values there, but I honestly cannot get the hang of how to set this up. Can you please add more documentation on the setup of these files? Thank you!

Hi, to use pyAutosplit, you have to create two files. One for the game and one for the route you are Autosplitting. In the "Game"-file you just define the variables, that are updated regularly (as defined by the frequency parameter). Like the amount of trinkets, or what level you are on, or if you are in a loading zone. Based on the variables you can define events, like if some variable has some specific value. The variables are available via state.variablename. E.g. state.trinkets, state.level or whatever you named the variables. There is a second state called oldstate, that you can use to compare the current values, with the values in the last update. That way you can monitor changes in the variables.
In the "route"-File you can then use this specific events to trigger where you are on your route.
Existing autosplitter for LiveSplit are most probably of little use, because they are written for the windows version of the game and use a completely different memory layout. Unfortunately you need to figure out the memory locations by yourself :( . There are cheat engines on linux, that may help. Maybe you are lucky, and the game executable is compiled with debug flags, and tools like gdb can help you.

Thank you, I'll see what i can do!

Hey, so I'm using game conqueror to find the memory things, but all that I get is an address like 7f7544265cb8, what do I do with that? Do I somehow have to transfer it to 0xSomething? I'm kinda lost haha

Hi,
I'm leaving this open. If it's unclear, what needs to be done, the documentation needs updating.
For your specific case, you can use software like game conqueror to find out at which memory locations your desired variables are stored. The locations are usually represented as a hexadecimal number, like 7f7544265cb8. 0x... is (usually) used to specify, that a number is in hexadecimal. Otherwise, you cannot know if like the number 878 is a decimal, or a hexadecimal number. Therefore one interprets 878 without a prefix as a decimal number and 0x878 as a hexadecimal number.
Granted, if a number has f, c, or b in it (like 7f7544265cb8), it is safe to assume, that this is a hexadecimal number. But in order to stay consistent one prefixes it with 0x anyway. So the memory address for pyAutosplit should be 0x7f7544265cb8.

Mind you, 0x7f7544265cb8 does look like a stack address, which means things can become complicated..

Thank you for your explanation! It's kind of weird, but every time I go onto a different save file, the address changes. Also I found out that there is a Mod API for unix, could that also help?

Yeah the address change is most likely related to the address being a stack address... In theory this can be fixed. The game VVVVVV (version 2.2 and prior) has the same problem. The solution there is the following: All data is saved in a game object. Once we know the memory location of the game object, we can calculate all variables, that we need for the splits, because the variables are always at a fixed offset to that game object. Problem is, that the game object can be located at (semi-)random spots on the stack. So you cannot know the memory location before running the program. But you can intercept the program at just the right time (by creating a breakpoint) and then just read the memory location from memory. In theory the same approach should work for Hollow Knight. Unfortunately the situation is slightly different for the two games: For VVVVVV have access to the source code, so finding the right spot was easy... I fear for Hollow Knight, this would involve quite a bit of reverse engineering...

Dam.. Thank you for all your help ^^
I don't think I myself can do the reverse engeneering required, given that I'm not really knowlegeable on the low level languages haha

Wait a sec, if there is a community made, open source, mod api for the game, shoudln't there be a break point somewhere in there that I can use? If so, what would it look like?

That might be a start, but as far as I can tell, Hollow Knight is written in unity, therefore in C#... and I am not certain how that translates into lower level machinecode...
Regarding the breakpoint issue: A breakpoint can be any point in a program. You just say (externally) After you executed this command, hold on for a bit, and give control to a debugger (PyAutosplit acts here as a debugger)

Wait why can't it just be launched at the same time? Does it have to be a precise point?

The control flow is as follows:
pyAutosplit starts -> pyAutosplit executes the game binary, sets a breakpoint in the code of the binary, right after the game object is created and waits -> The game starts -> the game creates the game object -> BREAK -> pyAutosplit is resumed, reads the current stack pointer (that corresponds roughly to the address of the game object), and resumes the game -> gameplay
But you have to know, where to set the breakpoint in the executable... It is possible, that the mod api can help you with that, but... I don't know that

How could one find when the game creates a game object?

Hey, so I'm using game conqueror to find the memory things, but all that I get is an address like 7f7544265cb8, what do I do with that? Do I somehow have to transfer it to 0xSomething? I'm kinda lost haha

I'd like to give some advise here that I've found out the last couple of days:

Ditch GameConqueror or PINCE and use ceserver together with Cheat Engine in wine or the network.
While both native programs are nice they're lacking the pointer finding mechanism Cheat Engine can provide.
Follow the Cheat Engine Tutorial (You've already got the first part but there's more to it):

Find the relevant value
If it's changing throughout the game or between restarts find the static:

Pointer
Pointers

With the above information you should now have a static non-changing address and an offset which you can use in the json configuration used by this program.


Jenkins error building dev- and prod Status Help websites

This is a follow-up to https://github.com/status-im/help.status.im/pull/189.
Problem:
The dev-help.status.im (development) and help.status.im sites (production) don't build after merging or rebasing.
Result:

We merge content into the develop branch, but Jenkins doesn't pick up the changes. Nothing occurs in https://ci.status.im/job/website/job/dev-help.status.im/
We rebase master on develop, and Jenkins picks up the changes but fails with the following error:

15:34:11  + ghp-import -p generated
15:34:11<EMAIL_ADDRESS>line 1: ghp-import: not found

Expected result:

dev-help.status.im (development) and help.status.im (production) sites build with no issues.

Note: this problem has existed since we moved to Docker builds (see https://github.com/status-im/help.status.im/pull/189)

develop doesn't build because I switched it to my PR branch:
https://cdn.discordapp.com/attachments/626045898878877696/1000053311602442423/unknown.png

As for master that is indeed an issue, since we now build in a Docker container, and that doesn't contain the ghp-import tool:
https://github.com/status-im/help.status.im/blob/98967a890f5922c5db0d4217e9ad85a351db2fb2/Dockerfile#L10-L14

Hey @jakubgs, I merged your update to the Dockerfile into develop, but the dev-help.status.im build fails. Please, see https://ci.status.im/job/website/job/dev-help.status.im/88/.

Oooh, I see, the package for Alpine exists: https://pkgs.alpinelinux.org/packages?name=py3-ghp-import&branch=edge

But it's just in testing repository. So it might make more sense to install it from Pip. Ugh.

Fixed: https://github.com/status-im/help.status.im/commit/d0346a91
Builds:

https://ci.status.im/job/website/job/help.status.im/29/
https://ci.status.im/job/website/job/dev-help.status.im/103/


K8SPXC-808 - Prepare main branch after 1.9.0 release

Test name
Status

upgrade-haproxy
failed

big-data
failed

haproxy
failed

scheduled-backup
failed

recreate
failed

scaling
failed

storage
failed

restore-to-encrypted-cluster
failed

init-deploy
failed

self-healing
failed

scaling-proxysql
failed

demand-backup
failed

self-healing-chaos
failed

security-context
failed

limits
failed

self-healing-advanced
failed

pitr
failed

monitoring-2-0
failed

self-healing-advanced-chaos
failed

demand-backup-encrypted-with-tls
failed

affinity
failed

operator-self-healing
failed

one-pod
failed

operator-self-healing-chaos
failed

upgrade-proxysql
failed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

users
failed

tls-issue-self
failed

tls-issue-cert-manager
failed

tls-issue-cert-manager-ref
failed

smart-update
failed

validation-hook
failed

upgrade-consistency
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/969/commits/93a95d3b240b71dc1a16773326f7bc39e5fa0be6
image: perconalab/percona-xtradb-cluster-operator:PR-969-93a95d3b

Test name
Status

scaling
passed

big-data
passed

scaling-proxysql
passed

security-context
passed

upgrade-haproxy
passed

haproxy
passed

init-deploy
passed

recreate
passed

scheduled-backup
passed

restore-to-encrypted-cluster
passed

demand-backup
passed

pitr
passed

demand-backup-encrypted-with-tls
passed

storage
passed

self-healing
passed

self-healing-chaos
passed

self-healing-advanced
passed

self-healing-advanced-chaos
passed

operator-self-healing
passed

operator-self-healing-chaos
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
failed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/969/commits/65a977c4c555c7104221a356b6101c4379035635
image: perconalab/percona-xtradb-cluster-operator:PR-969-65a977c4

Test name
Status

storage
passed

recreate
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

haproxy
passed

restore-to-encrypted-cluster
passed

scaling-proxysql
passed

big-data
passed

self-healing-chaos
passed

init-deploy
passed

demand-backup
passed

security-context
passed

self-healing-advanced
passed

pitr
passed

limits
passed

upgrade-haproxy
passed

self-healing-advanced-chaos
passed

monitoring-2-0
passed

demand-backup-encrypted-with-tls
passed

operator-self-healing
passed

affinity
passed

operator-self-healing-chaos
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/969/commits/65a977c4c555c7104221a356b6101c4379035635
image: perconalab/percona-xtradb-cluster-operator:PR-969-65a977c4

Test name
Status

recreate
passed

scheduled-backup
passed

restore-to-encrypted-cluster
passed

haproxy
passed

demand-backup
passed

init-deploy
passed

pitr
passed

limits
passed

demand-backup-encrypted-with-tls
passed

monitoring-2-0
passed

big-data
passed

storage
passed

affinity
passed

self-healing
passed

one-pod
passed

self-healing-chaos
passed

auto-tuning
passed

self-healing-advanced
passed

proxysql-sidecar-res-limits
passed

scaling
passed

self-healing-advanced-chaos
passed

users
passed

scaling-proxysql
passed

operator-self-healing
passed

tls-issue-self
passed

security-context
passed

operator-self-healing-chaos
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

upgrade-haproxy
passed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/969/commits/dba1916031fb201b45fa8903122923173f2bdfd8
image: perconalab/percona-xtradb-cluster-operator:PR-969-dba19160


Update helm-tool: artifacthub docs

Upgrade helm-tool to the latest version which includes this PR: https://github.com/cert-manager/helm-tool/pull/21

/approve


Provide a minimal, hardened base image

Description
This PR provides the following benefits:

Hardened base image
Implements the ability to remove artifacts that are not needed from the application image. This improves security because if the artifact are present they could be exploited even if not used.
Reduced size of the application image
Example:
telekube.tar size:

before this PR: 2.2 Gb
after the changes and with several apps disabled: 1.1 Gb

Type of change

Bug fix (non-breaking change which fixes an issue)
This change has a user-facing impact

Linked tickets and other PRs

Closes #1774

TODOs

[X] Self-review the change
[X] Perform manual testing
[X] Write documentation
[ ] Address review feedback

Implementation

Filtering of application dependencies in the tele application.
Testing done

Disabled several applications in the app.yaml and verified that after the deployment there are no issues visible on the UI.
Verified the same for the upgrade path.

Closing because replaced by PR 2397

Closing because replaced by PR 2397

Closing because replaced by PR 2397

Closing because replaced by PR 2397


Issue8 make the code 38 compatible

Codecov Report

Merging #10 (f600779) into main (ed8c688) will increase coverage by 0.09%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main       #10      +/-   ##
===========================================
+ Coverage   99.90%   100.00%   +0.09%
===========================================
  Files          58        58
  Lines        3275      3273       -2
===========================================
+ Hits         3272      3273       +1
+ Misses          3         0       -3

Impacted Files
Coverage Δ

...gui_classes/gui_structure_classes/figure_option.py
100.00% <ø> (ø)

...GUI/gui_classes/gui_structure_classes/float_box.py
100.00% <ø> (ø)

...ioGUI/gui_classes/gui_structure_classes/int_box.py
100.00% <ø> (ø)

...rioGUI/gui_classes/gui_structure_classes/option.py
100.00% <ø> (+1.21%)
:arrow_up:

...oGUI/gui_classes/gui_structure_classes/text_box.py
100.00% <ø> (ø)

tests/result_creating_class_for_tests.py
100.00% <ø> (ø)

tests/test_gui_structure_elements/test_aim.py
100.00% <ø> (ø)

...sts/test_gui_structure_elements/test_button_box.py
100.00% <ø> (ø)

tests/test_gui_structure_elements/test_category.py
100.00% <ø> (ø)

...est_gui_structure_elements/test_function_button.py
100.00% <ø> (ø)

... and 35 more

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Changing service versions from 2021-10-04 to 2021-12-02

API change check
API changes are not detected in this pull request.


fix(RHINENG-9145): Display empty state banner if task has no jobs

Before this PR, if a task has no jobs (which shouldn't occur, but does occasionally) the tasks table appears to continually load forever:

After the PR, an empty state banner is displayed:

/retest

/retest

/rebuild

Codecov Report
Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.95%.  Consider uploading reports for the commit bba7485 to get more accurate results

Files
Patch %
Lines

...nents/CompletedTaskDetails/CompletedTaskDetails.js
81.81%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   80.99%   80.95%   -0.04%
==========================================
  Files          75       75
  Lines        1615     1617       +2
  Branches      516      518       +2
==========================================
+ Hits         1308     1309       +1
- Misses        268      269       +1
  Partials       39       39

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


TypeError: Cannot read property 'type' of undefined

Description
I'm testing server 1.2.0 and getting this error.
New client
zjs             | 11:44:27.381 CNTRLR   [Node 010] treating BasicCC Set as a report
zjs             | This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
zjs             | TypeError: Cannot read property 'type' of undefined
zjs             |     at Object.dumpMetadata (/app/node_modules/@zwave-js/server/dist/lib/state.js:42:24)
zjs             |     at /app/node_modules/@zwave-js/server/dist/lib/forward.js:91:58
zjs             |     at Array.forEach (<anonymous>)
zjs             |     at notifyNodeOnValueOrMetadataUpdates (/app/node_modules/@zwave-js/server/dist/lib/forward.js:86:34)
zjs             |     at ZWaveNode.<anonymous> (/app/node_modules/@zwave-js/server/dist/lib/forward.js:147:21)
zjs             |     at ZWaveNode.emit (events.js:315:20)
zjs             |     at ZWaveNode.EventEmitter.emit (domain.js:467:12)
zjs             |     at ZWaveNode.translateValueEvent (/app/node_modules/zwave-js/src/lib/node/Node.ts:346:8)
zjs             |     at ValueDB.emit (events.js:315:20)
zjs             |     at ValueDB.EventEmitter.emit (domain.js:467:12)

AlCalzone's discord comment:

notifyNodeOnValueOrMetadataUpdates gets called for the value and metadata events. args is the argument that's emitted by zwave-js.
That never has a metadata property on the prevValue or newValue properties


Check to avoid sending too much data to browser

@philippjfr  and I discussed on gitter that it would be useful to have a safety to avoid overloading the browser - and possibly corrupting .ipynb files with massive output.  For example, I accidentally did a direct hv.Points(huge) rather than datashade(hv.Points(huge)) where huge had around 3.6 million points.  This caused the browser to crash and the .ipynb to become essentially corrupt (where I couldn't easily run jupyter notebook with it, or even edit it with vim).  Luckily, @philippjfr recommended https://gist.github.com/damianavila/5305869 , which worked to recover the .ipynb file.
Maybe there could be an option for all the Bokeh elements to have max size configuration, past which they would throw an exception or error rather than trying to render.  I'd be happy with a few hundred thousand, or whatever value is sure not to cause a ton of trouble in Chrome.

I believe we were already planning to be able to define a threshold for using datashader, such that e.g. we automatically datashade if the number of points is above X.  Seems like this would solve the problem, but I don't know how close we are to being able to do this cleanly.

I'd like to investigate adding this for holoviews 2.0.  It seems like we are very close to being able to do this cleanly, perhaps by adding options to operations.datashader.aggregate that dynamically switch the returned element type depending on the dataset size.  I'm not sure whether having different types will then cause other problems, though...

@philippjfr Is there a sensible iopub limit that could help here, or does such notion not exist?

The iopub limit is for data rate, and for holoviews I think the total amount of data would be more important.  In user terms, a total number of data points seems like a good way to express the limit.  And it makes sense to me to allow multiple fallbacks in this case, either just aborting or using datashader instead.


Remove defaults for --id and --method/--comp

Made --id a positional arg, and --method/--comp non-optional, with no default values for either.

Do you need to merge from master into this branch (or rebase it) ?

Hmm yeah maybe

Whoops closed it by accident.


afc2 (Apple File Conduit 2) not working

Apple File Conduit "2" (arm64/KPPLess) broken on last few updates of uncover and substrate. Many people doesn't have this issue but just a few. Root dir(raw file system/var) cannot be accessed on PC and MAC over usb with ifunbox or imazing tool.(these tools read phone as jailed,but it shouldn't because of this afc2 tweak). Tried all sort of things before posting this issue. iphone X 114b3 using final unc0ver 2.1.0. and
latest substrate -7020. re-instaling afc2,uninstalling it, cleaning with icleaner pro, installing it again, removing ifunbox from pc and installing it again,removing all sites blocked in host file. In the end i used rootFS option in uncover and it didn't even work on substitude before i updated to substrate again. So it is till not working. I always jailbreak my device with "reload system daemons" switch on in u0.All was working great on substrate -7000 but now when i downgrade substrate it doesn't. Tried all cables and usb ports too.Any info about this would be greatly appreciated,thank you.
p.s. contacted respective developers of the tweak about the issue as well.

i have same issue with AFC2 with unc0ver v.2.1.0, root folder cannot be display using iExplorer on MAC, on unc0ver v.2.0.2 AFC2 is working properly.
iP6S iOS 11.2.6

@coenkcore well it was working at some point on 210 u0 for me i just don't remember which pre-release from which day,gonna test with 202 later today...

Same here, any fix for AFC 2

Update Link Identity Editor to the latest version


parking a page should only push permanent properties

Otherwise you wind up with _children as an actual property in the database, which is Not Supposed To Happen and causes problems.


Adding purge support

Allowing purges to support purge forwarding. JIRA ticket.

Hold off on this pending outcome of https://fastly.atlassian.net/browse/DEVLIB-906?focusedCommentId=1015849 (comment)


Autoplay doesn't work after hold the slide for a while

Which OS ?
iOS
Version
Which versions are you using:

react-native-swiper ^1.5.13
react-native 0.55.4

Expected behaviour
When I swipe (onTouchStart) the current slide slightly (within half of the current slide) to the previous/next slide, and hold it for a while (more autoplayTimeout 2.5s), and then release(onTouchEnd) it to the current slide, autoplay stops, AND only after I swipe the current slide completely to the previous/next slide, autoplay works again.
Actual behaviour
Autoplay continues
How to reproduce it>
To help us, please fork this component, modify one example in examples folder to reproduce your issue and include link here.
Steps to reproduce

i am facing the same issue, do you fix it?

我也遇到同样的问题，想在onTouchEnd的时候停止autoPlay，但是发现onTouchEnd没有反应


KDE Tray Icon

Hi there
Many thanks for this app. KDE still supports tray icon so it would make sense to add support for this. Thanks much.

I would if I could, but there isn't a simple way to do it while using Gtk4. Gtk3 has support for tray icons, but you can't use Gtk4 and Gtk3 simultaneously. Trying to do so causes the app to crash. Most of the other libraries out there for handling tray icons actually use Gtk3 behind the scenes, so that doesn't work.
The Fyne project's, notably, doesn't need Gtk3 and just does the D-Bus work that it needs manually, but it had a lot of problems last I tried it. I can give it another try at some point, perhaps, though. That's probably the best bet.


Handle duplicates in folder

Currently if enter the same url in the same folder, a duplicate is created.
Would be nice if it used the existing one if found.

Actually I'm not sure what is supposed to happen on a duplicate...right now I get the "An unknown error occurred." flash, no asset is added, but an additional json file is still created.

After some testing, it only happens on certain cases, eg: https://youtu.be/IkgyWsdRnx8
It seems to be because the filename doesn't match when it looks for a duplicate.
The filename that is uploaded first is embed_What-To-Wear-Episode-2.json but when it compares it with subsequent uploads, it is embed_What-To-Wear-Episode-2-.json

Looks like you just need to do $fileName = AssetsHelper::cleanAssetName($filePrefix . $fileLabel . $fileExtension);
PR coming :)

Interesting. I had that clean asset name call in there before but took it out because it was buggy with certain foreign characters, and then rolled my own. Thanks for pull request, merging now 👍


Please bump my access rights up a notch or two

I'd like to tweak some repo settings, but I don't have the appropriate rights. Please could someone elevate my account to the next stage up (whatever that is that allows settings to be tweaked). Thanks!

Hey! I’m currently at centre parcs with only mobile, so if you are happy to wait until Monday that’s cool. Otherwise maybe Stef can update your settings.
Philip Wareham | Technical Director
30 St. Georges Road, Badshot Lea, Farnham, Surrey GU9 9LX, United Kingdom
Office: 01252 734144
Mobile: 07971 668332
Website: www.designhive.com

On 23 May 2022, at 18:07, Pete Cooper @.***> wrote:

Assigned #72 to @philwareham.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
 Maybe we should bump the Team permissions up to Maintain or Admin?
Or am I looking in the wrong place...?

No idea! For whatever reason, I don't have the settings gear / cog thingy, which is what I'd like access to.

I've bumped the team up a grade to Maintain. Any change?

Cheers @Bloke!


Docs: getAll(), setAll()

Color.prototype.getAll() and .setAll() are not currently documented in the readme or the online docs.

If these are not documented, get() and set() also won't be (though I'm pretty sure we use them in examples). I think that's pretty high priority as far as docs are concerned (though moving to Typedoc for the API docs see #424 should help mitigate the need)

set() is used in examples in the readme for sure.  I don't think get() is used in any examples.


add_frequency_sweep(self, name=None, frequency_sweep=None) can't work in HFSS3dlayout

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
The frequency sweep by "edb.create_hfss_setup()" cannot be used in hfss3Dlayout.

Steps To Reproduce
import pyaedt
from pyaedt import Edb
from pyaedt import Hfss3dLayout
from datetime import datetime
edb = Edb(edbpath=aedb_path)
setup = edb.create_hfss_setup("setup1")
setup.add_frequency_sweep(
frequency_sweep=[
["linear count", "0", "1kHz", 1],
["log scale", "1kHz", "0.1GHz", 10],
["linear scale", "0.1GHz", "10GHz", "0.1GHz"],
]
)
edb.save_edb()
edb.close_edb()
h3d = Hfss3dLayout(projectname=aedb_path, non_graphical=False, new_desktop_session=True)
h3d.save_project()
h3d.release_desktop()
Which Operating System are you using?
Windows
Which Python version are you using?
3.10
Installed packages
altgraph                  0.17.4
ansys-pythonnet           3.1.0rc3
attrs                     23.2.0
certifi                   2024.2.2
cffi                      1.16.0
charset-normalizer        3.3.2
click                     8.1.7
click-plugins             1.1.1
cligj                     0.7.2
clr-loader                0.2.6
colorama                  0.4.6
contourpy                 1.2.0
control                   0.9.4
cycler                    0.12.1
defusedxml                0.7.1
et-xmlfile                1.1.0
fiona                     1.9.6
fonttools                 4.45.0
fpdf2                     2.7.7
geopandas                 0.14.3
idna                      3.6
imageio                   2.34.0
Jinja2                    3.1.3
jsonschema                4.21.1
jsonschema-specifications 2023.12.1
kiwisolver                1.4.5
MarkupSafe                2.1.5
matplotlib                3.8.2
networkx                  3.2.1
numpy                     1.26.2
openpyxl                  3.1.2
osmnx                     1.9.1
packaging                 23.2
pandas                    2.1.3
pefile                    2023.2.7
Pillow                    10.1.0
pip                       24.0
platformdirs              4.2.0
plumbum                   1.8.2
pooch                     1.8.1
psutil                    5.9.6
pyaedt                    0.8.3
pycparser                 2.21
pyedb                     0.6.0
pyinstaller               6.5.0
pyinstaller-hooks-contrib 2024.3
pyparsing                 3.1.1
pyproj                    3.6.1
PyQt5                     5.15.10
PyQt5-Qt5                 5.15.2
PyQt5-sip                 12.13.0
PyQt5-stubs               <IP_ADDRESS>
python-dateutil           2.8.2
pythonnet                 3.0.3
pytomlpp                  1.0.13
pytz                      2023.3
pyvista                   0.43.4
pywin32                   306
pywin32-ctypes            0.2.2
qt-material               2.14
referencing               0.33.0
requests                  2.31.0
rpds-py                   0.17.1
rpyc                      6.0.0
scikit-rf                 0.32.0
scipy                     1.11.3
scooby                    0.9.2
setuptools                68.2.2
shapely                   2.0.3
six                       1.16.0
SRTM.py                   0.3.7
tzdata                    2023.3
urllib3                   2.2.1
utm                       0.7.0
vtk                       9.2.6
wheel                     0.36.2

Hi @Acaptian ,
First, this is a PyEDB issue, I will transfer it.
Second, I see a solver error, which is not a PyEDB/ PyAEDT problem, your computer is OUT OF RAM. Please if you have questions regarding the setup, reach the Ansys technical support.


tls: add tlsSni option - closes #1114

Hi everyone,
This PR introduces a new boolean option tlsSni that will basically, when enabled, copy the Redis hostname to tls.servername before the connection initialization,
allowing each node of a Redis Cluster to possess its own SNI.
This PR has been opened following the issue #1114
It is also related to #948
Thank you for your time!

Added a test for cluster connections.
For clusers I had to copy the options.host in options.hostOriginal before it gets passed throught the dnsLookup function, so that the original hostname could get passed to the tls.servername option instead of its IP.
It should be ready to be reviewed now.
Thank you!

changed fork branch, PR moved here:
https://github.com/luin/ioredis/pull/1137


endgame: switch to babel extract, init, update, compile

Instead of converging on django's makemessages, we might want to converge instead on Babel's extract, init, update and compile. If we did this, then the amount of code we maintain drops by a lot.
We could do this now, but there are a few caveats:
First, Puente has its own PuenteI18nExtension which fixes trans blocks to collapse whitespace and fixes gettext to output markup as safe. For extraction purposes, only the trans block fix is important. However, the Jinja2 Babel extractor does this goofy thing where it automatically adds Jinja2's i18n extension which overrides ours before doing extraction. Puente has an extract command that monkeypatches that first, then does the work. If we use Babel, we'll have to use our own extractor that does that, too.
We can fix this with our own extractor. Also, this problem goes away if when Jinja2 supports trimmed trans blocks.
Second, Puente pulls the Jinja2 extensions from the settings file and uses those to set up the environment for strings extraction. If we switch to Babel, we have to put those extensions in a babel.cfg file which means we end up with two places we have to list the extensions.
I'm not sure what to about this one. We can live with it, but it's problematic. Maybe if we write our own extractor then it could pull the extensions and populate itself?
Third, if you're using vendor/ then you have to do all this stuff to make sure the pybabel script can access the libs being used. Further, if you have babel from source (i.e. a git submodule), then it's not installed and doesn't have the cdlr data.
This goes away when we stop doing the vendor thing.

Per #74, we're ending Puente. Closing this out.


Allow to specify RAG image tag

Description

Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)
[ ] CI configuration change
[ ] Konflux configuration change

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

This PR is obsolete. Closing without merging into main.