Skip already-downloaded articles

It'd be great if quickscrape had an option to skip downloading articles if they have already been downloaded.
A very simple version of this could just be that if the folder it was going to download stuff into already exists then just skip and move on to the next one - and I might have a go at that for a PR.

That sounds like a good a good idea to me. We're super excited to have this
kind of offer :). Perhaps you could add it not as the default behaviour but
enable it with a flag?
On Tue, Mar 22, 2016 at 9:03 PM, Robin Wilson<EMAIL_ADDRESS>wrote:

It'd be great if quickscrape had an option to skip downloading articles if
they have already been downloaded.
A very simple version of this could just be that if the folder it was
going to download stuff into already exists then just skip and move on to
the next one - and I might have a go at that for a PR.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/ContentMine/quickscrape/issues/70


[FEA] it would be nice if we could support org.apache.spark.sql.catalyst.expressions.Bin

it would be nice if we could support org.apache.spark.sql.catalyst.expressions.Bin
Seq(1,2,3,4,5,6).toDF("a").repartition(1).createOrReplaceTempView("t1")
sql("select bin(a) from t1").show

! <Bin> bin(cast(a#19 as bigint)) cannot run on GPU because GPU does not currently support the operator class org.apache.spark.sql.catalyst.expressions.Bin

low priority


Create incremental snapshots

Currently, snapshot files contain all active deployments. Create incremental snapshots (daily? or weekly?) so when bootstrapping a Content Server then only the diff snapshots are parsed and that will decrease the time of bootstrap.

How does it work?


feat(MarshallingBehaviour)!: allow map to be a scalar

please review 🙏
Motivation
This PR is a first effort to make federation possible in Sangria, and it comes as a response to the federation issue discussed here.
Changes
To make federation possible in sangria, there is a need to allow objects (maps) to be scalars. Thus, I changed the contract for the unmarshalling of map values, by making it possible for them to be scalars.
Consequences
By allowing this change, we are breaking the type safety introduced by the previous contract, because now anywhere a scalar can be passed, an object can be passed too. And, this can lead to potential security concerns if not dealt with properly. However, this is necessary to support Apollo federation.

Can you be more specific about this change?
Can you explain how each marshalling implementations should be changed for that?
Can you provide examples of how it can be used?

Can you be more specific about this change?
Can you explain how each marshalling implementations should be changed for that?
Can you provide examples of how it can be used?

Sure @yanns, to answer your third question:

Can you provide examples of how it can be used?

assume that we have the schema below:
scalar _Any
type Query {
  _entities(representations: [_Any!]!): [_Entity]!
}

by changing the contract, we will be able to write these kind of queries:
{
  _entities(representations: [{__typename: "Customer", id: 1}]) {
    __typename
  }
}

see how it's possible to pass an input object as a scalar for the _Any type. And, with the previous contract that was not possible, we will be forced to change the object into a scalar string, something like this:
  _entities(representations: ["{__typename: \"Customer\", id: 1}"])

And Apollo's federation gateway passes _Any values as json object values not strings.
As for your second question:

Can you explain how each marshalling implementations should be changed for that?
each marshaller has its own node type, so it will be difficult to estimate the changes. But in the case of circe, I had to remove this assertion:

"throw an exception on invalid scalar values" in {
      an[IllegalStateException] should be thrownBy
        CirceInputUnmarshaller.getScalarValue(Json.obj())
    }

And these changes:

allow json object to be a scalar

def isScalarNode(node: Json) =
      node.isBoolean || node.isNumber || node.isString || node.isObject // node.isObject too

extract scalar value from json object

def getScalarValue(node: Json) = {
      def invalidScalar = throw new IllegalStateException(s"$node is not a scalar value")

      node.fold(
        jsonNull = invalidScalar,
        jsonBoolean = identity,
        jsonNumber = num => num.toBigInt.orElse(num.toBigDecimal).getOrElse(invalidScalar),
        jsonString = identity,
        jsonArray = _ => invalidScalar,
        jsonObject = identity // not _ => invalidScalar,
      )
    }

Sure @yanns, to answer your third question:

Can you provide examples of how it can be used?

assume that we have the schema below:
scalar _Any
type Query {
  _entities(representations: [_Any!]!): [_Entity]!
}

by changing the contract, we will be able to write these kind of queries:
{
  _entities(representations: [{__typename: "Customer", id: 1}]) {
    __typename
  }
}

see how it's possible to pass an input object as a scalar for the _Any type. And, with the previous contract that was not possible, we will be forced to change the object into a scalar string, something like this:
  _entities(representations: ["{__typename: \"Customer\", id: 1}"])

And Apollo's federation gateway passes _Any values as json object values not strings.
As for your second question:

Can you explain how each marshalling implementations should be changed for that?
each marshaller has its own node type, so it will be difficult to estimate the changes. But in the case of circe, I had to remove this assertion:

"throw an exception on invalid scalar values" in {
      an[IllegalStateException] should be thrownBy
        CirceInputUnmarshaller.getScalarValue(Json.obj())
    }

And these changes:

allow json object to be a scalar

def isScalarNode(node: Json) =
      node.isBoolean || node.isNumber || node.isString || node.isObject // node.isObject too

extract scalar value from json object

def getScalarValue(node: Json) = {
      def invalidScalar = throw new IllegalStateException(s"$node is not a scalar value")

      node.fold(
        jsonNull = invalidScalar,
        jsonBoolean = identity,
        jsonNumber = num => num.toBigInt.orElse(num.toBigDecimal).getOrElse(invalidScalar),
        jsonString = identity,
        jsonArray = _ => invalidScalar,
        jsonObject = identity // not _ => invalidScalar,
      )
    }

It would be great to have an overview of all needed changes. Do you have fork and branches for all changes we need?

It would be great to have an overview of all needed changes. Do you have fork and branches for all changes we need?

It would be great to have an overview of all needed changes. Do you have fork and branches for all changes we need?

No not yet, I am working on the forks now 🤓. Will comment when they are done, and there is also a scenario missing in the testkit. I will add it and push a new commit.

It would be great to have an overview of all needed changes. Do you have fork and branches for all changes we need?

No not yet, I am working on the forks now 🤓. Will comment when they are done, and there is also a scenario missing in the testkit. I will add it and push a new commit.

@yanns as an overview (other marshallers can be updated as needed):

I followed a TDD approach and this PR both defines the new contract (map as scalar support) and ensures that the marshaller respect it.
This PR is just for informing that scala's scalars include map values too.
As for this PR, it implements the new contract in circe. To allow json object to be scalars.
And this one, implements the contract for the QueryAST (input object notation). It allows object values to be scalars.

All of these PRs are just to support map values as scalars in Sangria, they don't depend on Apollo federation. But, federation depends on them.

@yanns as an overview (other marshallers can be updated as needed):

I followed a TDD approach and this PR both defines the new contract (map as scalar support) and ensures that the marshaller respect it.
This PR is just for informing that scala's scalars include map values too.
As for this PR, it implements the new contract in circe. To allow json object to be scalars.
And this one, implements the contract for the QueryAST (input object notation). It allows object values to be scalars.

All of these PRs are just to support map values as scalars in Sangria, they don't depend on Apollo federation. But, federation depends on them.

Hey @xsoufiane, one of the things you brought up is security, and I'd like to make sure we've considered this before releasing this into the wild.
That said: https://www.apollographql.com/docs/federation/implementing-services/#securing-implementing-services one of the recommendations Apollo makes is to NOT expose implementing services publicly. I think this makes sense.
That said, I wonder if there is something we should consider as this is built out. Perhaps users of Sangria should require an explicit flag, or import or something to effectively "allow" Sangria to be run in an "implementing service" fashion.
Could we leave the marshaller alone, and add a trait that could be mixed in like AnyScalarSupport, so that any upgrades don't accidentally open this up for folks. We could then have each marshaller implement the base marshalling, as well as AnyScalarSupport so that if someone is interested in this, it's still simple enough, but isn't automatic.
Thoughts?

Hey @xsoufiane, one of the things you brought up is security, and I'd like to make sure we've considered this before releasing this into the wild.
That said: https://www.apollographql.com/docs/federation/implementing-services/#securing-implementing-services one of the recommendations Apollo makes is to NOT expose implementing services publicly. I think this makes sense.
That said, I wonder if there is something we should consider as this is built out. Perhaps users of Sangria should require an explicit flag, or import or something to effectively "allow" Sangria to be run in an "implementing service" fashion.
Could we leave the marshaller alone, and add a trait that could be mixed in like AnyScalarSupport, so that any upgrades don't accidentally open this up for folks. We could then have each marshaller implement the base marshalling, as well as AnyScalarSupport so that if someone is interested in this, it's still simple enough, but isn't automatic.
Thoughts?

Hey @xsoufiane, one of the things you brought up is security, and I'd like to make sure we've considered this before releasing this into the wild.
That said: https://www.apollographql.com/docs/federation/implementing-services/#securing-implementing-services one of the recommendations Apollo makes is to NOT expose implementing services publicly. I think this makes sense.
That said, I wonder if there is something we should consider as this is built out. Perhaps users of Sangria should require an explicit flag, or import or something to effectively "allow" Sangria to be run in an "implementing service" fashion.
Could we leave the marshaller alone, and add a trait that could be mixed in like AnyScalarSupport, so that any upgrades don't accidentally open this up for folks. We could then have each marshaller implement the base marshalling, as well as AnyScalarSupport so that if someone is interested in this, it's still simple enough, but isn't automatic.
Thoughts?

thank you so much for your ideas @nickhudkins. I did some 🤔, I think with the following approach (change the marshallers directly), we have the following draft:
Federation ------- > Service Endpoint (user defined) < ------- Marshaller
    |
    |
    V
Sangria

The draft indicates that in the user defined GraphQL endpoint. we decide to use federation and which marshaller to use. And, in my implementation federation extends the schema defined in sangria.
Now for your first point, I think it's super ✅. We can define a middleware in the federation library, and it is up to the user to use it at the service endpoint or not.
However, for your second point. I am not sure how to approach it :( because as far as I can see, we will need to add another Marshaller that will modify the behaviour of the usual one. So, we will end up with something like this:
Federation ---------->   Service Endpoint (user defined) < ------- XMarshaller < ------- Marshaller
    |
    |
    V
Sangria

I added it separately because the XMarshaller needs also to have a different testkit that assures that the contract (supporting map values as scalars) is respected. Now for each marshaller, we will have a second one just for scalar support. And, I can't see a way to force the user to use the XMarshaller. Unless, we define a different executor in Federation that modifies the executor in Sangria, to make it accept only XMarshallers 🤔

Hey @xsoufiane, one of the things you brought up is security, and I'd like to make sure we've considered this before releasing this into the wild.
That said: https://www.apollographql.com/docs/federation/implementing-services/#securing-implementing-services one of the recommendations Apollo makes is to NOT expose implementing services publicly. I think this makes sense.
That said, I wonder if there is something we should consider as this is built out. Perhaps users of Sangria should require an explicit flag, or import or something to effectively "allow" Sangria to be run in an "implementing service" fashion.
Could we leave the marshaller alone, and add a trait that could be mixed in like AnyScalarSupport, so that any upgrades don't accidentally open this up for folks. We could then have each marshaller implement the base marshalling, as well as AnyScalarSupport so that if someone is interested in this, it's still simple enough, but isn't automatic.
Thoughts?

thank you so much for your ideas @nickhudkins. I did some 🤔, I think with the following approach (change the marshallers directly), we have the following draft:
Federation ------- > Service Endpoint (user defined) < ------- Marshaller
    |
    |
    V
Sangria

The draft indicates that in the user defined GraphQL endpoint. we decide to use federation and which marshaller to use. And, in my implementation federation extends the schema defined in sangria.
Now for your first point, I think it's super ✅. We can define a middleware in the federation library, and it is up to the user to use it at the service endpoint or not.
However, for your second point. I am not sure how to approach it :( because as far as I can see, we will need to add another Marshaller that will modify the behaviour of the usual one. So, we will end up with something like this:
Federation ---------->   Service Endpoint (user defined) < ------- XMarshaller < ------- Marshaller
    |
    |
    V
Sangria

I added it separately because the XMarshaller needs also to have a different testkit that assures that the contract (supporting map values as scalars) is respected. Now for each marshaller, we will have a second one just for scalar support. And, I can't see a way to force the user to use the XMarshaller. Unless, we define a different executor in Federation that modifies the executor in Sangria, to make it accept only XMarshallers 🤔

I suppose that may be my question! SHOULD we provide a "federated executor"?
Do we believe that there is a use-case outside of federation for Map type scalars? It FEELS rich for abuse, and historically Sangria seems to land on the side of MORE strict enforcement of the spec.
If I were making the call I think I WOULD provide a separate executor, but I'll happily leave the decision to @yanns our great Sangria overlord 😂

I suppose that may be my question! SHOULD we provide a "federated executor"?
Do we believe that there is a use-case outside of federation for Map type scalars? It FEELS rich for abuse, and historically Sangria seems to land on the side of MORE strict enforcement of the spec.
If I were making the call I think I WOULD provide a separate executor, but I'll happily leave the decision to @yanns our great Sangria overlord 😂

I'm having a look at all changes.
I don't think that allowing an any type should be the default, but rather an opt-in for users who know what they are doing and are aware of the security concerns.

I'm having a look at all changes.
I don't think that allowing an any type should be the default, but rather an opt-in for users who know what they are doing and are aware of the security concerns.

me and @yanns found a way to make federation possible for Sangria without having to change the marshallers and the root sangria lib, and without breaking the existing security level :) the implementation is done here


Add License File to Repository

Task

Choose an appropriate open-source license.
Add the LICENSE file to the root of the repository.
Update README.md to include a reference to the license.

@sharmavikas4  Please assign this task to me with all the required labels attached to it.

Go ahead @rahulgithub-web

@rahulgithub-web how is the progress going on

No license added @rahulgithub-web


Can I generate point cloud and normals from stl file?

I'm trying to generate point cloud data from mesh such as .stl file, but I failed to create the groundtrue normals of sampled points. Is there any way to generate point cloud and normals from stl file using 3D tools like MeshLab? Thanks.

I solved this using pcl-tools package. Inside this package, you can use pcl_mesh_sampling to generate the point cloud.


Add option to opt out of Turbo for forms by default and require manual opt in

Anecdotally, one of the biggest deterrents for people upgrading from Turbolinks to Turbo has been the way forms are handled. For Rails users heavily invested in UJS, it's a mammoth task to rework all the forms to work with Turbo.
I've worked around this in the past in Rails by monkey patching form_with to disable Turbo with data-turbo=false; but I think it'd be a great idea to allow a global setting within Turbo to navigate only on forms that have opted in with data-turbo=true.
I'm thinking it could be set at initialization time like: Turbo.start({ forms_opt_out_by_default: true })
I'm happy to spend some time working on this if this is something maintainers would like to support so just opening this issue to get people's thoughts!

@ayushn21 have you tried setting <html data-turbo="false"> or <body data-turbo="false">, and then incrementally opting into Turbo on an individual <a> and <form> basis?
If it's <form> elements that are the issue, It might be more straightforward to disable all elements, and then opt back in <a> elements:
addEventListener("turbo:load", () => {
  for (const link of document.querySelectorAll("a")) {
    link.setAttribute("data-turbo", "true")
  }
})

Hey @seanpdoyle that is a good solution in the short term. Thanks!
Bigger picture, it seems like if the UJS remote form behaviour was managed via the config.action_view.form_with_generates_remote_forms in your environment, there should also be an equivalent config.action_view.form_with_generates_turbo_forms or similar.
Am I totally out to lunch or does this make some sense?

config.action_view.form_with_generates_turbo_forms

I think that's totally reasonable. At the moment, Action View is completely unaware of Turbo, and I'm not aware of any Rails mechanism to set default options for helper methods.
At a high level, what would you like to see happen when config.action_view.form_with_generates_turbo_forms is true?

Not coincidentally, we were doing a fair bit of digging on this last night in the StimulusReflex Discord.
Ultimately, the token orm_with_generates_remote_forms shows up in just six files, most specifically in form_helper.rb.
The way I would approach this is that right now, it's almost as if there's already an invisible form_with_generates_turbo_forms setting that defaults to true. 😉
If this value was set to false, we'd add a data-turbo="false" attribute to the form helper.

Thanks @seanpdoyle. That's a great stopgap solution on the JS side of things.
I do agree with @leastbad that it'd be great to have a cleaner way to prevent Turbo from navigating on forms by default though. The chat we were having in the StimulusReflex Discord was also centered on what level should this setting be configured (i.e. within Turbo or through a server side helper like config.action_view.form_with_generates_turbo_forms)
If you believe the right way to go about this would be to handle the exclusion of forms on the server rather than within Turbo, I reckon it makes sense to close this issue and we can take the discussion to rails/rails.
Thanks for your input!

Addressed in #419


update configmap template

Our configmap template was incorrectly defined. It was missing the latest updates to filters and computation of latency for differences between telemetry v1 and  v2. @sushmarchandran helped fix this.

Included are minor changes to the configmap for the kubecon demo.


⚠ AZ-Launcher has degraded performance

In 6c308a5, AZ-Launcher (https://az-launcher.nz/) experienced degraded performance:

HTTP code: 200
Response time: 1992 ms

Resolved: AZ-Launcher performance has improved in 7b23966 after 9 minutes.


GF Latin Plus includes ₧ (peseta), a mostly unused symbol for an historical currency. Should it?

The Spanish peseta has been out of use for at least 20 years (since the introduction of the Euro). Additionally, the ₧ (P plus bar) symbol potentially doesn’t seem to be used as much as the "Pts" version of the glyph.
Should it really be in the GF Latin Plus glyph set? If so, is there a reason?
Related: https://github.com/googlefonts/glyphsets/issues/37
Thanks!

As @RosaWagner said in #37,

This is planned in https://github.com/googlefonts/glyphsets/pull/36/files#diff-deb67e1abe331b32c4d92df0424d086fa76c2861e0b1a7337ba935e70eaaa8d7


chore(main): release 5.2.1

:robot: I have created a release beep boop
5.2.1 (2024-08-09)
Bug Fixes

opening multiple files in a directory with spaces (#347) (f7be6c1)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v5.2.1
:sunflower:


CDC-Cloud: owner exited with error "code = ResourceExhausted desc = trying to send message larger than max (7749468 vs. 2097152)"

Bug Report
Please answer these questions before submitting your issue. Thanks!

What did you do? If possible, provide a recipe for reproducing the error.

Import workload 6w table count, 550GB data size to upstream TiDB.
Create a changefeed

What did you expect to see?

What did you see instead?

CDC log:

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
5.0.2
tikv-cloud-cdc-5.0-52f335601-2021-06-26-22-04.tar.gz

TiCDC version (execute cdc version):
cdc-cloud-cdc-5.0-9300b05c-2021-06-26-22-17.tar.gz

may take a look at https://github.com/pingcap/dm/pull/1624 @liuzix

This issue can be work around by https://github.com/pingcap/ticdc/pull/2223, and we are developing p2p metadata management. #2596

We have confirmed this issue is fixed in release-5.4.


Automate and generate BiosampleMeta data set via Scripts (via APIs- similar to ngs_id_list.tsv generation - OR other Method)

Please propose a methodology to Raja after consulting with Dan and others. Once you and Raja agree on how this should be generated, please refer me to your figure or discuss with me so I'm in the loop.

#154

Completed by @kerchner in ticket #151.

@HadleyKing reopened and assigned to you. If you have questions lets check with Raja before you start. Thanks

@steph-sing
I have pushed this table to a branch, made a PR to the dev (v1.3), and assigned you to review the PR.
Your tasks should be (as I see it):

[ ] Download and review the table. Link here is for the RAW version.
[ ] Provide feedback on the table in the PR review
[ ] Once all items are resolved for your review we will merge into dev branch.

@HadleyKing please Merge to Main

@HadleyKing can I close this ticket?


Error on go get:  >> local import "./gopev" in non-local package"

Hi!
I'm consider, that you should change "./gopev" to "github.com/simon-engledew/gocmdpev/gopev" in main.go:5:3

#1 is fixing this issue.
pls merge :)

Cheers guys


3.1.1. Fails when IPv6 is disabled.

When I run check 3.1.1, the handler sysctl flush ipv4 route table is called.
Strangely, however, this handler also wants to do something with ipv6.
The output of the test is
`TASK [RHEL8_CIS : SCORED | 3.1.1 | PATCH | Ensure IP forwarding is disabled | Disable IPv4 forwarding] **************************************************************************************************************************************
ok: [alrha001.acc.vlkintern.nl] => (item={'name': 'net.ipv4.ip_forward', 'value': 0})
changed: [alrha001.acc.vlkintern.nl] => (item={'name': 'net.ipv4.route.flush', 'value': 1})
TASK [RHEL8_CIS : SCORED | 3.1.1 | PATCH | Ensure IP forwarding is disabled | Disable IPv6 forwarding] **************************************************************************************************************************************
skipping: [alrha001.acc.vlkintern.nl] => (item={'name': 'net.ipv6.conf.all.forwarding', 'value': 0})
skipping: [alrha001.acc.vlkintern.nl] => (item={'name': 'net.ipv6.route.flush', 'value': 1})
RUNNING HANDLER [RHEL8_CIS : sysctl flush ipv4 route table] *********************************************************************************************************************************************************************************
[WARNING]: The value 1 (type int) in a string field was converted to '1' (type string). If this does not look like what you expect, quote the entire value to ensure it does not change.
fatal: [alrha001.acc.vlkintern.nl]: FAILED! => {"changed": false, "msg": "Failed to reload sysctl: fs.suid_dumpable = 0\nkernel.randomize_va_space = 2\nnet.ipv4.conf.all.forwarding = 0\nnet.ipv4.conf.all.send_redirects = 0\nnet.ipv4.conf.default.send_redirects = 0\nnet.ipv4.conf.all.accept_source_route = 0\nnet.ipv4.conf.default.accept_source_route = 0\nnet.ipv4.conf.all.accept_redirects = 0\nnet.ipv4.conf.default.accept_redirects = 0\nnet.ipv4.conf.all.secure_redirects = 0\nnet.ipv4.conf.default.secure_redirects = 0\nnet.ipv4.conf.all.log_martians = 1\nnet.ipv4.conf.default.log_martians = 1\nnet.ipv4.icmp_echo_ignore_broadcasts = 1\nnet.ipv4.icmp_ignore_bogus_error_responses = 1\nnet.ipv4.conf.all.rp_filter = 1\nnet.ipv4.conf.default.rp_filter = 1\nnet.ipv4.tcp_syncookies = 1\nnet.ipv4.route.flush = 1\nnet.ipv4.ip_forward = 0\nsysctl: cannot stat /proc/sys/net/ipv6/route/flush: No such file or directory\nsysctl: cannot stat /proc/sys/net/ipv6/conf/all/forwarding: No such file or directory\n"}`
Notice that all variables are pertaining to ipv4, yet at the end the ipv6 files are not found. Which is worked as designed, because I do not want ipv6......
How to fix this ?

I have run into this same problem and it appears to be an issue with the sysctl command itself.
$ sudo sysctl -p
fs.suid_dumpable = 0
kernel.randomize_va_space = 2
net.ipv4.ip_forward = 0
net.ipv4.route.flush = 1
sysctl: cannot stat /proc/sys/net/ipv6/conf/all/forwarding: No such file or directory
sysctl: cannot stat /proc/sys/net/ipv6/route/flush: No such file or directory
net.ipv4.conf.all.send_redirects = 0
net.ipv4.conf.default.send_redirects = 0
net.ipv4.conf.all.accept_source_route = 0
net.ipv4.conf.default.accept_source_route = 0
sysctl: cannot stat /proc/sys/net/ipv6/conf/all/accept_source_route: No such file or directory
sysctl: cannot stat /proc/sys/net/ipv6/conf/default/accept_source_route: No such file or directory
net.ipv4.conf.all.accept_redirects = 0
net.ipv4.conf.default.accept_redirects = 0
sysctl: cannot stat /proc/sys/net/ipv6/conf/all/accept_redirects: No such file or directory
sysctl: cannot stat /proc/sys/net/ipv6/conf/default/accept_redirects: No such file or directory
net.ipv4.conf.all.secure_redirects = 0
net.ipv4.conf.default.secure_redirects = 0
net.ipv4.conf.all.log_martians = 1
net.ipv4.conf.default.log_martians = 1
net.ipv4.icmp_echo_ignore_broadcasts = 1
net.ipv4.icmp_ignore_bogus_error_responses = 1
net.ipv4.conf.default.rp_filter = 1
net.ipv4.tcp_syncookies = 1
sysctl: cannot stat /proc/sys/net/ipv6/conf/all/accept_ra: No such file or directory
sysctl: cannot stat /proc/sys/net/ipv6/conf/default/accept_ra: No such file or directory

A potential workaround is to ignore the errors by enabling the sysctl 'ignoreerrors' parameter. Adding this to the handler task and setting it to 'yes'  should address the issue.
- name: sysctl flush ipv4 route table
  become: yes
  sysctl:
      name: net.ipv4.route.flush
      value: 1
      sysctl_set: yes
      ignoreerrors: yes
  when: ansible_virtualization_type != "docker"

This was addressed with our latest update in PR #83


Feature/ give enemy attacks and player health and death

@lrgmincher
tonnes of files changed but Im working in a separate scene from level builder so hopefully you just need to pull this down, test on your side and ignore most of the changes


fix(#406): workaround for hideExpression.

What kind of change does this PR introduce? Bug fix

This change is

Codecov Report

Merging #417 into master will decrease coverage by 0.11%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   92.47%   92.35%   -0.12%
==========================================
  Files          15       15
  Lines         757      759       +2
  Branches      197      198       +1
==========================================
+ Hits          700      701       +1
- Misses         57       58       +1

Impacted Files
Coverage Δ

src/core/components/formly.field.ts
86.02% <0%> (ø)
:arrow_up:

src/core/services/formly.form.builder.ts
96.36% <50%> (-0.57%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c81ef1...905f638. Read the comment docs.


Remove the tags and URL cleanup process from the ingestion server

Blocked by https://github.com/WordPress/openverse/issues/1557
Problem

Currently, we are doing some tag cleanup during the ingestion, which duplicates the work done in the catalog.
Description

We should remove the tags cleanup step from the ingestion server after the database audit (https://github.com/WordPress/openverse/issues/1557) is completed.

Adding here that we should also run a tag cleanup that would remove the incorrectly encoded tags to fix #1303 before removing the tags clean up process.


touchpad bug

when i use my laptop touchpad the GUI just broke and i saw the other said they use the CLI and it worked with them but i couldn't understand how they did it so if you can explain to me how to use the CLI plz

Run in terminal: ticketys -c

it tells me that there are an argument is missing
[ERROR  ] [Core        ] option -c requires argument
Kivy Usage: tickeys [OPTION...]::
so if u can help me with this argument and I am really sorry but i couldn't find it I know you r busy but please help me if you can

what is the config value ?


Blocks and Missing ',,'

When a while/until/unless/else block is missing a trailing ',,' error line is reported as End of File.

When Statement reports error at the next declaration/statement.
in constrast to:
'while' 'until' 'else' 'unless' 'if' 'define' report as end of file.

Now errors on the appropriate line, unless there is a recursive functions assigned in the code....

Now errors on the appropriate line, unless there is a recursive functions assigned in the code....


Support markdown editor for issue template

Fixes #24398
Task:

[x] Reusing "textarea" like GitHub seems more friendly to users.
[x] ^V image pasting and file uploading handling.

screenshots

Display only one markdown editor:

Support file upload and ^V image pasting

Some quick thoughts:

Reusing "textarea" like GitHub seems more friendly to users.
^V image pasting and file uploading handling.

Reusing "textarea" like GitHub seems more friendly to users.

Did you mean we should stay with current solution?

Reusing "textarea" like GitHub seems more friendly to users.

Did you mean we should stay with current solution?

Attach the ComboMarkdownEditor to current textarea? I am not sure (just a quick thought)
GitHub does better for this case, it only shows one activated markdown toolbar, while hides others.

Labelling as enhancement as it's not really a bug because textarea works.

Now, we have a GitHub like textarea for issue template.
Have uploaded some screenshots to the PRs description.

How come some of these tabs have a border-bottom problem?

But others don't:

How come some of these tabs have a border-bottom problem?

But others don't:

80%:

75%:

Have no idea about this. 😕

Seems like a CSS rounding error, which may not actually be introduced by this PR, ignore it.

In some special zoom size, these tabs will have a border-bottom.

In some special zoom size, these tabs will have a border-bottom.

Yes, ignore it for now here.

I will test it later and make some changes.

Something worth noting: It is possible to add a render attribute to a Textarea. If you add a render attribute, the content of the Textarea will not be rendered as Markdown, but as normal text with the Syntax Highlighting of the given language. Here's a example from the Gitea documentation:
  - type: textarea
    id: logs
    attributes:
      label: Relevant log output
      description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
      render: shell

In case a Textarea has a render attribute, it should not use the Markdown Editor.

Almost done from my side.


[release] Comment on resolved issues/PRs when releasing

Is your feature request related to a problem? Please describe.
I would like JReleaser to comment on all the Github issues/PRs that are included in the release to announce that it has effectively been released, and in which release.
In addition, the label released is added.
semantic-release does that, here is an example comment on an issue and on a PR.
This gives clarity on what has been released or not. Issues are closed when the associated commit is pushed to master/main, and PRs are closed when merged, but there is no indication that this has been released, or in which version.
The release notes would provide this information of course, but by adding a comment directly on the ticket, someone who subscribed to that particular issue can get a notification that a release is ready, containing the fix.
Describe the solution you'd like
See above.
Describe alternatives you've considered
semantic-release does that outside the box.
Additional context
Add any other context or screenshots about the feature request here.

JReleaser would have to perform the following tasks:

[ ] Check if the released label exists, otherwise create it.
[ ] Collect all issues mentioned in the changelog.
[ ] For each collected issue:
Check if it has the released label. If so, skip it.
Add the released label.
Post a comment pointing to the release.

Collect all issues mentioned in the changelog.

I think this relates to https://github.com/jreleaser/jreleaser/issues/806

Released in v1.3.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.3.0


not working from Home Assistant 0.102.3

hi again peter
i could not update ha to 0.102.3 it kept on crashing.
what i tried was to delete all the configuration.yaml and after the update is complete ill copy all the text again to the configuration.yaml.
geuss what, it worked!!
the thing is that now when i am entring your sonoff settings back into the yaml file ha cant even check the Configuration validation it just keeps on loading and cant even restart ha server from the ui.
can you please help me?
here is my log:
2019-12-06 14:57:09 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/aiohttp/web_protocol.py", line 418, in start
resp = await task
File "/usr/local/lib/python3.7/site-packages/aiohttp/web_app.py", line 458, in _handle
resp = await handler(request)
File "/usr/local/lib/python3.7/site-packages/aiohttp/web_middlewares.py", line 119, in impl
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/real_ip.py", line 40, in real_ip_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 73, in ban_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 136, in auth_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 122, in handle
result = await result
File "/usr/src/homeassistant/homeassistant/components/config/core.py", line 29, in post
errors = await async_check_ha_config_file(request.app["hass"])
File "/usr/src/homeassistant/homeassistant/config.py", line 802, in async_check_ha_config_file
res = await check_config.async_check_ha_config_file(hass)
File "/usr/src/homeassistant/homeassistant/helpers/check_config.py", line 107, in async_check_ha_config_file
integration = await async_get_integration_with_requirements(hass, domain)
File "/usr/src/homeassistant/homeassistant/requirements.py", line 48, in async_get_integration_with_requirements
hass, integration.domain, integration.requirements
File "/usr/src/homeassistant/homeassistant/requirements.py", line 77, in async_process_requirements
if pkg_util.is_installed(req):
File "/usr/src/homeassistant/homeassistant/util/package.py", line 45, in is_installed
return version(req.project_name) in req
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 3137, in contains
return self.specifier.contains(item, prereleases=True)
File "/usr/local/lib/python3.7/site-packages/pkg_resources/_vendor/packaging/specifiers.py", line 703, in contains
item = parse(item)
File "/usr/local/lib/python3.7/site-packages/pkg_resources/_vendor/packaging/version.py", line 31, in parse
return Version(version)
File "/usr/local/lib/python3.7/site-packages/pkg_resources/_vendor/packaging/version.py", line 200, in init
match = self._regex.search(version)
TypeError: expected string or bytes-like object

sorry, i don't know what's wrong on your side. read the documentation better! (worked for others should work for you too)


Stored Apotheosis items do not get retrieved properly

Describe the bug
Apotheosis items, stored in the dimensional storage, such as gems and armor/weapons/tools with Apotheosis modifiers, do not behave as expected when retrieving them if there are several items of the same type.
To Reproduce
Steps to reproduce the behavior:

Add several diamond pickaxes to the storage, some of which are normal and some have different Apotheosis rarities and modifiers.
Use the prompt "pickaxe" in the search.
When you click on a specific Apotheosis pickaxe to get, it retrieves a different pickaxe, which could be with modifiers or it could be normal.

This occurs even if you are very specific in the search prompt and only one item is shown. It happens both when accessed directly via the actuator and via a remote.
Expected behavior
When the user searches for an item and click on it to grab it, the user gets the item they actually clicked on.
Screenshots
It happens with Apotheosis gems as well.

System (please complete the following information):

Occultism Version: 1.92.0
OS: [e.g. Windows] Windows
Minecraft Version: 1.20.1
Modpack Link and Version, or list of mods: ATM9-0.2.25 https://www.curseforge.com/minecraft/modpacks/all-the-mods-9/files/4915982

Additional context
There is some consistency to which wrong item is provided, it's as if the storage is sorted in a different way under the hood than what is shown in the UI.

This seems to be the same error as #989 closing this and commenting there


error when pulling in a new git clone

after performing a git clone of a dvc enabled repository
dvc pull data/
Unexpected exception while processing targets: [Errno 2] No such file or directory: '.cache/1.csv_e202149'

Thank you for the feedback!
I reproduced, fixed and added a test for this issue in #202.
Feel free to reopen if it didn't solve it for you.
Cheers!


Rotating maps creates destroyes the arc position and projection.

By projection i mean the light gray line between start and end below arc.
Can you add some more customizations like arc height, animation duration,  and color or arc projection.

@amalChandran when we can expect this fix in release version? you mentioned this issues is fixed in other branch, can you make it available in release

Hello. rotate map issue is not fixed. Can you please fix it and make release. Also one more thing in this lib we need more than > 2 lat/lon to draw path or arc, it will be very help full if make it for at least 2 locations. so we can draw arc only between 2 location. Thanks.


Make Solana Issue

There seems to be a "no such file or directory" error after running Make Solana. I had no issue running Make All.
`PS C:\Users\Haris\Desktop\animated-art-engine-main> make solana
cd step2_spritesheet_to_generative_sheet && npm run generate:solana && cd ..

<EMAIL_ADDRESS>generate:solana
node Solana/metaplex.js

Beginning Solana/Metaplex conversion
{ startIndex: 0 }
Extracting metaplex-ready files.
Writing to folder: C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet/../build/solana
node:internal/fs/utils:347
throw err;
^
Error: ENOENT: no such file or directory, scandir 'C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet/../build/gif'
at Object.readdirSync (node:fs:1442:3)
at getIndividualImageFiles (C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet\Solana\metaplex.js:42:6)
at Object. (C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet\Solana\metaplex.js:62:20)
at Module._compile (node:internal/modules/cjs/loader:1126:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1180:10)
at Module.load (node:internal/modules/cjs/loader:1004:32)
at Function.Module._load (node:internal/modules/cjs/loader:839:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:17:47 {
errno: -4058,
syscall: 'scandir',
code: 'ENOENT',
path: 'C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet/../build/gif'
}
make: *** [Makefile:20: solana] Error 1
PS C:\Users\Haris\Desktop\animated-art-engine-main>`

The problem stopped when i changed the outputType to .gif.
Solana seems to have a problem with .MP4.
Is this fixable? Gif quality is pretty bad compared to MP4. Not to mention the massive file size.
Thanks

Ah hmm i have not tested solana for mp4. Are you at all familiar with coding @jehuty27 you might be able to figure out the fix in the solana utils file?

Cant seem to make it work. Its okay. I can stick with GIF type. Thanks!

Got it @jehuty27 I'll leave this issue open and maybe someone else can take a look

@jehuty27 This is fixed now https://github.com/jalagar/animated-art-engine/pull/136


Error while executing Chart

In windows 7 whether in Spyder or cmd when I run Chart I get the following errors
chart = Chart(date, pos)
Traceback (most recent call last):
File "", line 1, in
chart = Chart(date, pos)
File "C:\ProgramData\Anaconda3\lib\site-packages\flatlib\chart.py", line 53, in init
self.objects = ephem.getObjectList(IDs, date, pos)
File "C:\ProgramData\Anaconda3\lib\site-packages\flatlib\ephem\ephem.py", line 34, in getObjectList
objList = [getObject(ID, date, pos) for ID in IDs]
File "C:\ProgramData\Anaconda3\lib\site-packages\flatlib\ephem\ephem.py", line 34, in
objList = [getObject(ID, date, pos) for ID in IDs]
File "C:\ProgramData\Anaconda3\lib\site-packages\flatlib\ephem\ephem.py", line 29, in getObject
obj = eph.getObject(ID, date.jd, pos.lat, pos.lon)
File "C:\ProgramData\Anaconda3\lib\site-packages\flatlib\ephem\eph.py", line 48, in getObject
obj = swe.sweObject(ID, jd)
File "C:\ProgramData\Anaconda3\lib\site-packages\flatlib\ephem\swe.py", line 71, in sweObject
'lonspeed': sweList[3],
IndexError: tuple index out of range
Any suggestion to solve the problem?

Please look into other issues before opening a new one. This has already been solved at #41!


Create web pages and emails to facilitate the flow of the IIWBook Demos

Define the various informational and transitional emails and web pages necessary to implement the full IIWBook demo flow.

Demo Script: https://docs.google.com/document/d/166ztb8PBtvLfiuXymF7Qkl-8iWHfPMX55AykEXfoo1w/edit#heading=h.6v09fpr9vo5o


Extension causes high cpu load

Issue Type: Performance
Extension Name: LiveServer
Extension Version: 5.5.1
OS Version: Windows_NT x64 10.0.17134
VSCode version: 1.32.3

:warning: Make sure to attach this file from your home-directory: C:\Users\DKD\ritwickdey.LiveServer-unresponsive.cpuprofile.txt :warning:
Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

Hello. few questions!!,
When you're getting this issue? after load of vscode or after clicking to Go Live ?
Is this happen every-time ? or random ?
Please reply here https://github.com/ritwickdey/vscode-live-server/issues/278
Duplicate of https://github.com/ritwickdey/vscode-live-server/issues/278

[Note: This issue is closed by a javascript code (written by me).
https://gist.github.com/ritwickdey/36682dabe4a992c57e4562c935bfbbdd ]

Thank You.


Scrolling in Shrine item pages is only 30pfs on a Nexus 5

That screenshot is in a release build:
Flutter on channel master (from git@github.com:flutter/flutter.git)
Framework revision 4fe80830ca (8 minutes ago); engine revision 24511c9265

dart-timeline-2016-7-5.json.zip
FYI @chinmaygarde

Scrolls beautifully on my iPhone 6s.

@HansMuller worked around this using https://github.com/flutter/flutter/commit/4a8dbb0e134218d29f5e5ce72fed1e785697d295

Should we close this ticket then?

@chinmaygarde my understanding from chat with @abarth was you felt something was still wrong here?  I'm happy to close this and wait to see something like it come up again?

We had to add a shadow (changed the cards' elevation from 0 to 1) to the grid items to get the corresponding raster's cached. That shouldn't have been necessary; still needs to be fixed.

This issue should now be resolved - if we see a future regression we should open a new issue.


Handling NSErrors returned from factory methods that produce errors.

By using -withFactory:selector: it's possible to invoke factory methods that throw errors. e.g.
- (MESFooBar *)foobar {
    return [TyphoonDefinition withFactory:[self foobarFactory] selector:@selector(foobarWithError:)]; // ...
}

The question is, how can the error be processed if it arises?

First of all, use HEAD version of Typhoon. (Recently I did minor change to get this feature working)
Then change your assembly like that:
- (MESFooBar *)foobarWithError:(NSValue *)error {
    return [TyphoonDefinition withFactory:[self foobarFactory] selector:@selector(foobarWithError:) parameters:^(TyphoonMethod *factoryMethod) {
               [factoryMethod injectParameterWith:error];
           }]];
}

Option 1
Method declaration:
- (MESFooBar *)foobarWithError:(NSError **)error

Caller:
__autoreleasing NSError *error = nil;
MESFooBar *foobar = [self.assembly foobarWithError:[NSValue valueWithPointer:&error]];
if (error) {
    // error handling
}

Option 2
Method declaration:
- (MESFooBar *)foobarWithError:(NSError *__strong*)error

Caller:
NSError *error = nil;
MESFooBar *foobar = [self.assembly foobarWithError:[NSValue valueWithPointer:&error]];
if (error) {
    // error handling
}

IMPORTANT NOTICE
You have to be careful with ownership rules. ARC can't handle this case implicit, because it's too complex for ARC (object written by reference wrapped by NSValue). So you have to use explicit ownership rules:

if NSError on caller side is strong (have __strong attribute or empty), then factory method declaration must be like (NSError *__strong*)
if NSError on caller side is autoreleasing (have __autoreleasing attribute), then factory method declaration must be like (NSError *__autoreleasing*) or (NSError **)

Otherwise you'll get the crash

@alexgarbarev Looks like tests are failing since last commits.

@jasperblues, yes, reverted back. This failure related to #325 - not this ticket

I think we should update documentation for that common case (just faced with that and had to search for that ticket)


[linker][new integer types] Fix missing case in dependency verifier

Fix missing case in dependency verifier for equality on signature tokens (from different contexts)
Fix prop test case

Motivation

fixing bug in dependency verifier

Test Plan

new test

@tnowacki thanks for catching this.
There's just so many places that these types touch and I was wondering is there a proper way to do an audit to make sure no more missing enums?

@tnowacki thanks for catching this. There's just so many places that these types touch and I was wondering is there a proper way to do an audit to make sure no more missing enums?

I don't think there is, sadly. Just writing tests :) This one is a bit subtle and not surprising we forgot it in the first PR.
I did another pass, hence the fix for proptests.


Not able to Emulate Transparent Background Color.

Hey I am trying to convert a html to pdf with a transparent background. After searching online I found emulating the background page is the way to achieve this. link.
What versions are you running?

go version
go1.13.5 darwin/amd64

chromdp version
github.com/chromedp/chromedp v0.5.3

chrome version
Version 83.0.4103.61 (Official Build) (64-bit)

What did you do? Include clear steps.
package main

import (
	"context"
	"io/ioutil"

	"github.com/chromedp/cdproto/cdp"
	"github.com/chromedp/cdproto/emulation"
	"github.com/chromedp/cdproto/page"
	"github.com/chromedp/chromedp"
)

func main(){
	ExamplePrintToPDF()
}

func ExamplePrintToPDF() {
	ctx, cancel := chromedp.NewContext(context.Background())
	defer cancel()

	var schbytes,pdfbuf []byte
	if err := chromedp.Run(ctx,
		TransparentPDF("file:///test.html",&schbytes,&pdfbuf)); err != nil {
		panic(err)
	}
	if err := ioutil.WriteFile("page.png", schbytes, 0644); err != nil {
		panic(err)
	}

	if err := ioutil.WriteFile("page.pdf", pdfbuf, 0644); err != nil {
		panic(err)
	}
}

func TransparentPDF(urlstr string, schbytes,pdfbytes *[]byte) chromedp.Tasks {
	return chromedp.Tasks{
		chromedp.Navigate(urlstr),
		chromedp.ActionFunc(func(ctx context.Context) error {
			err := emulation.SetDefaultBackgroundColorOverride().WithColor(&cdp.RGBA{0,0,0,0}).Do(ctx)
			if err != nil {
				return err
			}
			*schbytes,err = page.CaptureScreenshot().Do(ctx)
			if err != nil{
				return err
			}
			*pdfbytes,_,err = page.PrintToPDF().WithPrintBackground(true).Do(ctx)
			if err != nil{
				return err
			}
			return nil

		}),
	}
}

test.html

123

What did you expect to see?
I expect the pdf and screenshot to have a transparent background. I tried with other colors the output is correct, but it is not working for transparent.
What did you see instead?
Both of them appear black. To verify if the issue is with my chrome version I ran the same logic using puppeteer and the output is a transparent pdf.

After spending some time on this issue. I found that in the puppeteer example which I have shared they have used page.emulateMedia('screen'). But I couldn't find anything similar in chromedp.

After checking this PR which adds emulateMedia to puppeteer it is clear that this option internally sets Emulation.setEmulatedMedia to screen. I checked by setting the same but still, it didn't work as expected.
I checked this auto-generated file and the default case in easyjsonC5a4559bDecodeGithubComChromedpCdprotoEmulation12 is set to skipRecursive. A case for screen should be handled here.

@mvdan, please verify if my investigation on this issue is correct. If it is correct I will be happy to work on raising a PR for this.

As many as a dozen new issues per week are filed. Please don't ping me directly.
The code you posted just implements json encoding for https://chromedevtools.github.io/devtools-protocol/tot/Emulation/#method-setEmulatedMedia. You're confusing its fields with the possible values the fields can take, which is also a string, for the media field.

Sorry for pinging directly. Can you direct me on how I can debug this?

I found the issue. The problem was with the easyMarshalJSON of RGBA type. The alpha value has a check for !=0 here though the range is defined as [0-1] here.
I was able to get through this by setting the alpha value to something very small like 0.000001.

Thanks, that does sound like a bug. We fixed a similar one in the past, #456. I imagine a similar fix could be applied to the cdproto-gen repo.

I will look into the PR which solves https://github.com/chromedp/chromedp/issues/456 and raise a fix for this.

Have raised a PR which fixes this bug. https://github.com/chromedp/pdlgen/pull/6


New: SVG Symbol component

Current coverage is 100.00%

Merging #119 into master will not affect coverage as of 963ad79

@@            master    #119   diff @@
======================================
  Files           17      18     +1
  Stmts          138     147     +9
  Branches        16      16
  Methods          0       0
======================================
+ Hit            138     147     +9
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 963ad79

Powered by Codecov. Updated on successful CI builds.

Looking damn cool. Thanks for doing this mate! Heck yeah. :trophy:
Now we've gotta go in and replace all uses with this haha.

@camjc @omgaz merge?

LGTMerging :ramen:


Vim Extension Fails to Load on Extension Update

Despite the fix here https://github.com/Microsoft/vscode/issues/40260. We are still getting reports of people unable to install an update to the extension.

VSCode Version: 0.11.1 -> 0.11.2 of VSCodeVim
OS Version: Various

Since the release the fix (https://github.com/Microsoft/vscode/issues/40260), we've had these issues filed:

https://github.com/VSCodeVim/Vim/issues/2226
https://github.com/VSCodeVim/Vim/issues/2415
https://github.com/VSCodeVim/Vim/issues/2436

https://github.com/Microsoft/vscode/issues/40260 is locked so re-opening a new issue here.

Duplicate of #43813


Release a new version to get rid of windows-sys 0.45?

This is the last crate that depends on windows-sys 0.45 / windows-targets 0.42 in our project. Is it possible to just release a new version?

This would be most welcome 🙏

I will have a look if I can do that. For whatever reason last time I tried to bump it, i ran into some issues.

Thanks! I can PR it if it helps :) I am not sure if you have some specific procedure to make releases tho :)

@mitsuhiko are you still looking at this? It seems there are also some bug fixing pull requests waiting for a review.

Due to the windows-sys migration to Rust 2021 Addition, MSRV will also need to bump to 1.56.

close as the new version is available


"Language" is misspelled in Global!settings.xml

This is a bug report.
  <Langauge>en-US</Langauge>

Should be <Language>.

This is technically a breaking change.


[Refactor] Rename put-pipeline to create-ingest-pipeline

We enabled the creation of search pipelines in opensearch-benchmark with the introduction of search pipelines in OS 2.9.0. To separate from the search pipeline, the ingest pipeline API put-pipeline should be refactored.

Hey, I would like to work on the first task which is: Refactor put-pipeline https://github.com/opensearch-project/opensearch-benchmark/issues/366...

@Dantochi if you'd like to contribute to this issue, please setup an OpenSearch Benchmark in Developer Mode. You can [see the Developer Guide] (https://github.com/opensearch-project/OpenSearch-Benchmark/blob/main/DEVELOPER_GUIDE.md) for reference.

Hi! Saw the slack message and am ready to work on it.


CF: redirect to archive when requesting latest snapshot

This lets people resume downloads even if new snapshots are uploaded.
Summary of changes
Changes introduced in this pull request:

/latest/{chain}/ now redirects to /archive/{chain}/latest/{specific_file.forest.car.zst}

Reference issue to close (if applicable)

Closes
Other information and links

@lemmih @ohmpatel1997 Is this going to be fine with regards to the latest snapshot metrics on Datadog?

@lemmih @ohmpatel1997 Is this going to be fine with regards to the latest snapshot metrics on Datadog?

this can possibly add inaccuracy to the metrics since if someone requested latest, we are redirecting him to archive, which is considered another request. but actually its only 1 request, for latest, instead of 2. i would suggest to not redirect but serve the same request.

Directly serving the request breaks resume functionality. Let's fix the logging by separating the /archive/ worker and the /latest/ worker.


Cannot import manually or via Gradle in Android Studio

Hello,
I tried to to add library v 1.8.3 using:
    compile 'org.jsoup:jsoup:1.8.3'

Or manually (jar copied into libs folder and added into dependencies)
But i got always following exception during the build process.
Error:Execution failed for task ':app:dexDebug'.
> com.android.ide.common.process.ProcessException: org.gradle.process.internal.ExecException: Process 'command 'C:\Program Files\Java\jdk1.7.0_79\bin\java.exe'' finished with non-zero exit value 2

Android Studio v 1.3.2
Android compile settings

android {
    compileSdkVersion 23
    buildToolsVersion "23.0.0"

Many thanks for any advice.

Possibly a previous Gradle issue, or local environment issue. Doesn't repro.


Martinique

Data source for Martinique infections should be checked.
Martinique
new confirmed cases | 15395 (1707 -- 139044)
expected change | Likely increasing
effective reproduction | 1.4 (0.63 -- 2.1)
rate of growth | 0.1 (-0.11 -- 0.28)
doubling time (days) | 6.7 (2.5 -- -6.5)
(Global Table showing 111 to 120 of 202 entries as of the 2021-04-26)
see also https://www.worldometers.info/coronavirus/country/martinique/
Total Coronavirus Cases in Martinique: ~10k
Daily new cases (7 d average): ca 100
It is a small island and it is #7 in the global list of countries, sorted by registered infection cases.
(Figure 1: Confirmed cases with date of infection on the 2021-04-26 and the time-varying estimate of the effective reproduction number)

This seems fine - probably a transient issue due to rapid increase from a very low level (a known issue with the underlying model).


Export Skins

Hello, I'm a developer from LoLPoro and I'd like to talk to collaborate with the author of this app. Currently I've downloaded a clone of this app and integrated a feature to upload skins to our website, but I'd like to make that an official feature added by you guys and in return we would credit you on our website. Or maybe we can agree to some other terms.

Since this feature has been requested to me via private messages, I'll consider it under one condition:
The feature must be universal, not targeted at a specific site/service, like exporting a base64 JSON which anyone can integrate with.

Ye, I am totally cool with that. Since its open-source it would make sense that anyone could integrate it. So please add the export function. Thanks for the response.

I will work on this tomorrow then.

Ok. Let me know if I can help out with it.

Just pushed an update to branch export. Users will paste a link here and upload a JSON with the following format:
{
  summonerId: number,
  skins: [{
      skinId: number
      rpValue: number
  }]
}

You are recommended to provide an interface that generates a one-time temporary link for you users.
If you decide to go forward and integrate this on your site I'll publish a new version of this application with the export feature available.

Ok, I talked to my team members and they agreed to it. We really like the export functionality. However currently I am the only one with the app dev. env. setup so my team members will aprreciate if you release a new version of it. Thanks again. Really happy to work with you.

You're free to package the app and give them a zipped folder. You can use npm run package-win for that.

is there a way to talk to u privately? any social media id or discord even?

You can my email<EMAIL_ADDRESS>

Can you please checkout your inbox? My friend sent you an email. I will close this issue when you respond.

The request sends platformId now


how to format the text into a snippet while sending through a payload in java to slack

The sql queries are taking code snippet format if they are less than 1000 words, but for more number of words, the formatting is not applied as shown.

Is there anyway to make the sql queries as a text snippet and send via java

I'm adding three backticks at the start and end of sql queries (```) to specify this as a code snippet

HI @KruthikHM, thanks for asking the question!
As you experienced, a text message with thousands of characters sent can be split into multiple messages. As this is done on the server-side for better user experience, there is no way to customize this behavior.
Instead, consider using files.upload with either file or content parameter. With this way, your app can have a quite long text data as a file. If you prefer not having a file for simple use case, you may want to switch to use files.upload only for large files. Also, sharing the file in a thread may be a good way to improve the user experience.
I hope this was helpful to you.

HI @KruthikHM, thanks for asking the question!
As you experienced, a text message with thousands of characters sent can be split into multiple messages. As this is done on the server-side for better user experience, there is no way to customize this behavior.
Instead, consider using files.upload with either file or content parameter. With this way, your app can have a quite long text data as a file. If you prefer not having a file for simple use case, you may want to switch to use files.upload only for large files. Also, sharing the file in a thread may be a good way to improve the user experience.
I hope this was helpful to you.

can I convert String part containing SQL queries as text attachment through API ?

@KruthikHM If the "text attachment" means an attached file in a message, as I mentioned in my last comment, you can use files.upload API for it. If you're exploring a different approach, there is no alternative at this moment.

@KruthikHM If the "text attachment" means an attached file in a message, as I mentioned in my last comment, you can use files.upload API for it. If you're exploring a different approach, there is no alternative at this moment.

thaks, got it. But are there any examples to send files through files.upload through java

@KruthikHM The test code in this repository should be helpful: https://github.com/slackapi/java-slack-sdk/blob/v1.10.0/slack-api-client/src/test/java/test_with_remote_apis/methods/files_Test.java
It seems that everything is clear now. Would you mind closing this issue now?

Hey I have made a fileupload request and trying to post the file to slack channel, but there is no message in slack, but the response is
FilesUploadResponse(ok=true, warning=null, error=null, needed=null, provided=null, file=File(id=F02BGKHGPRU, created=1629359652, timestamp=1629359652, name=Report.txt, title=Report, mimetype=text/plain, filetype=text, prettyType=Plain Text, user=U02BNK1QWMN, mode=snippet, editable=true, external=false, externalType=, username=, size=0, urlPrivate=https://files.slack.com/files-pri/T193TSZFE-F02BGKHGPRU/report.txt, urlPrivateDownload=https://files.slack.com/files-pri/T193TSZFE-F02BGKHGPRU/download/report.txt, thumb64=null, thumb64Gif=null, thumb64Width=null, thumb64Height=null, thumb80=null, thumb80Gif=null, thumb80Width=null, thumb80Height=null, thumb160=null, thumb160Gif=null, thumb160Width=null, thumb160Height=null, thumb360=null, thumb360Gif=null, thumb360Width=null, thumb360Height=null, thumb480=null, thumb480Gif=null, thumb480Width=null, thumb480Height=null, thumb720=null, thumb720Gif=null, thumb720Width=null, thumb720Height=null, thumb800=null, thumb800Gif=null, thumb800Width=null, thumb800Height=null, thumb960=null, thumb960Gif=null, thumb960Width=null, thumb960Height=null, thumb1024=null, thumb1024Gif=null, thumb1024Width=null, thumb1024Height=null, thumbVideo=null, imageExifRotation=null, originalWidth=null, originalHeight=null, deanimateGif=null, pjpeg=null, permalink=https://moneyview.slack.com/files/U02BNK1QWMN/F02BGKHGPRU/report.txt, permalinkPublic=https://slack-files.com/T193TSZFE-F02BGKHGPRU-b6574af7e9, editLink=https://moneyview.slack.com/files/U02BNK1QWMN/F02BGKHGPRU/report.txt/edit, hasRichPreview=false, previewTruncated=false, preview=Hello, previewHighlight=
Is there anything I am missing?

Hey I have made a fileupload request and trying to post the file to slack channel, but there is no message in slack, but the response is
FilesUploadResponse(ok=true, warning=null, error=null, needed=null, provided=null, file=File(id=F02BGKHGPRU, created=1629359652, timestamp=1629359652, name=Report.txt, title=Report, mimetype=text/plain, filetype=text, prettyType=Plain Text, user=U02BNK1QWMN, mode=snippet, editable=true, external=false, externalType=, username=, size=0, urlPrivate=https://files.slack.com/files-pri/T193TSZFE-F02BGKHGPRU/report.txt, urlPrivateDownload=https://files.slack.com/files-pri/T193TSZFE-F02BGKHGPRU/download/report.txt, thumb64=null, thumb64Gif=null, thumb64Width=null, thumb64Height=null, thumb80=null, thumb80Gif=null, thumb80Width=null, thumb80Height=null, thumb160=null, thumb160Gif=null, thumb160Width=null, thumb160Height=null, thumb360=null, thumb360Gif=null, thumb360Width=null, thumb360Height=null, thumb480=null, thumb480Gif=null, thumb480Width=null, thumb480Height=null, thumb720=null, thumb720Gif=null, thumb720Width=null, thumb720Height=null, thumb800=null, thumb800Gif=null, thumb800Width=null, thumb800Height=null, thumb960=null, thumb960Gif=null, thumb960Width=null, thumb960Height=null, thumb1024=null, thumb1024Gif=null, thumb1024Width=null, thumb1024Height=null, thumbVideo=null, imageExifRotation=null, originalWidth=null, originalHeight=null, deanimateGif=null, pjpeg=null, permalink=https://moneyview.slack.com/files/U02BNK1QWMN/F02BGKHGPRU/report.txt, permalinkPublic=https://slack-files.com/T193TSZFE-F02BGKHGPRU-b6574af7e9, editLink=https://moneyview.slack.com/files/U02BNK1QWMN/F02BGKHGPRU/report.txt/edit, hasRichPreview=false, previewTruncated=false, preview=Hello, previewHighlight=
Is there anything I am missing?

@KruthikHM To share the uploaded file with someone else immediately, you can pass channels parameter in the API call.

it worked correctly for channels, but how to send the files to user instead of channel ?. How to find the id for a user ?

You can open a new direct message with a user by calling https://api.slack.com/methods/conversations.open API.


echo: Convert module to TypeScript.

Fixes:

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@zulipbot add "buddy review"

@zulipbot add "mentor review"

there are some linter errors, that need to be fixed.

The linter error is very wierd.
Run source tools/ci/activate-venv
Using /srv/zulip-py3-venv
ts        | avoid subject in JS code at web/src/echo.ts line 115:
ts        |                 subject: z.string(),
ts        | avoid subject in JS code at web/src/echo.ts line 126:
ts        |                 subject: z.literal(""),
Error: Process completed with exit code 1.

This is suggesting me to remove subject in "JS code" . But subject is one of the fields in the message recieved from the server (and not a keyword or anything else here).

This is ready for another look @Lalit3716

@afeefuddin ready for your another review.

Although we are removing uses of unknown_local_echo_user, I did not remove https://github.com/zulip/zulip/pull/30702/commits/b25f2a60a77e5f6bc138f2dae4793d73d7b28b6b. The reason is that the rest of the frontend codebase still needs it until we have removed all the instances of unknown_local_echo_user -- I thought that might be a shaky refactor.

@afeefuddin I have addressed all the review comments, but this module is not ready for migration yet, as

https://github.com/zulip/zulip/pull/30813
introduces a new module(message_events_util.js) dependency on echo.js. So might need to handle this first. Probably migrating message_events_util.js before echo.js

@afeefuddin rebasing this since

https://github.com/zulip/zulip/pull/31145
is merged now !!

Ready for another review @afeefuddin

Looks good to me!!

@zulipbot remove "buddy review"

@zulipbot add "integration review"

I fixed the comments above that I felt blocking for merging; the rest seem like things we can investigate and address in localized follow-up PRs, since they seem unlikely to contaminate typing for other modules.
Merged, thanks for all the effort on this @LaPulgaaa and @afeefuddin! This is a really big one.


[common-utils] Update meta.env file's path and format

I am looking to implement the devcontainer-info command in our build of Dev Container images.
https://github.com/devcontainers/features/blob/2af02c198adabacff30c400b0bfcad972ce5abcc/src/common-utils/bin/devcontainer-info#L2

Could it also support the new path like /usr/local/etc/dev-containers/meta.env?
Could you add a new field to store the Git commit hash?

@eitsupi A clarifying question, are you looking forward to only modify devcontainer-info file and also source env from /usr/local/etc/dev-containers/meta.env and append something like 👇

if [ ! -z "${GIT_COMMIT_SHA}" ]; then echo && echo "Git commit: ${GIT_COMMIT_SHA}"; fi

OR are you also looking forward to make these changes to the devcontainer images & to the devcontainer-info file?
I believe it's the first one, but would be nice to clarify.

@samruddhikhandale Thanks for your reply. Sorry for the unclear.
Your first understanding is correct.
I am considering incorporating meta.env into images built from https://github.com/rocker-org/devcontainer-images.
We do not plan to generate tags or branches for every build, so I want to show the commit hash as revision. (Using the commit hash as a revision is the same as the OCI spec annotation)
And, I wondered if a new path could be used since the path /usr/local/etc/vscode-dev-containers/meta.env seems to be a legacy of the past.

Thanks for the clarification.

And, I wondered if a new path could be used since the path /usr/local/etc/vscode-dev-containers/meta.env seems to be a legacy of the past.

I agree, we should support the new image path. I believe we should also make a switch for devcontainer images but definitely not a rush.

Could you add a new field to store the Git commit hash?

I think we could.
@Chuxel would appreciate your thoughts on the request here 👀

I have created a PR #359 for now.
I hope you will review it when you have time.


Fireball effect does not match reticle aiming

The reticle for aiming the fireball draws a rectangle around the selected tile. But the fireball consumable uses euclidean distance instead of the max-of-abs distance used by enemies to determine if they're within range 1 of the player (I forget the name).
Because of this, increasing fireball radius and then trying to clip an enemy with the corner of it will fail to affect them.

You are right, I messed up there. I'll have a look soon what parts of the code use the distance calculation. I think the only other part is the lightning scroll. I don't know if using Chebyshev distance should be used for the lightning scroll, as it might make judging the distance unintuitive for players. However, I do like the idea to fully committing to Chebyshev instead of Euclidian.

First of all I really like what you've done with the visuals!
Unfortunately though, I cannot reproduce the bug you're describing. Using the code from part 9 I am now able to affect orcs in the corner of the targeting square, but orcs outside it remain unaffected.
Does the same happen with the lightning scroll? Could you maybe use a breakpoint to check what happens in the distance calculation / fireball scroll?

I am terribly sorry @Devengel, I did not test properly/enough. You were right (at least three quarters right). I forgot to take the absolute values of the relative vector. That means that it works properly in one quadrant, but results in negative distances in the other four. Incidentally, when I tried it out the enemies outside the fireball range happened to be in the right quadrant, which is why it looked to me as if everything worked as it should.
The proper distance calculation looks as follows:
func distance(other_position: Vector2i) -> int:
    var relative: Vector2i = other_position - grid_position
    return maxi(abs(relative.x), abs(relative.y))

I'll soon upload the corrected version.


fix: findDOMNode is deprecated in StrictMode

Description
react-transition-group is removed and replaced with react-transition-state.

Related issue(s)
fixes #816

What kind of change does this PR introduce? (check at least one)

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New Feature (non-breaking change which adds functionality)
[ ] New Feature (BREAKING CHANGE which adds functionality)
[x] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
How has this been tested?
The issue was reproduced to check if there's any error in console.

Screenshots (if appropriate):
The PR fulfils these requirements:

[x] It's submitted to the main branch
[x] When resolving a specific issue, it's referenced in the related issue section above
[ ] My change requires a change to the documentation. (Managed by Tremor Team)
[ ] I have added tests to cover my changes
[x] Check the "Allow edits from maintainers" option while creating your PR.
[x] Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
[x] By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@iamtouha  🫡


building complete gobot.json without separate slotfiller.json and ner.json

Hi!
I have a gobot, based on dstc2 gobot example.
gobot.json references to slofiller.json and slotfiller.json references to ner.json.
There is a problem of embedders duplicating (one for ner and one for gobot needed) at runtime resulting in excessive memory usage.
So I supposed, that it is possible to build one big.json, made of 3 above jsons.
Is it possible?
How to do it?

Hi there!
I could not find embeddings usage in ner_dstc2.json nor in slotfill_dstc2.json.
Intents config  uses fasttext embeddings, but [gobot config)(https://github.com/deepmipt/DeepPavlov/blob/master/deeppavlov/configs/go_bot/gobot_dstc2.json) that references it does not.
If you do want to combine multiple configurations into one, you should replace component description that has config_path parameter with pieline elements from the referenced configuration file, properly connecting inputs and outputs. Then, if you have multiple identical components, you can replace later uses with refs as described in documentation.

Sorry for siminformation.
I built ner component based on ner_rus.json. It uses fasttext embedder and gobot_dstc2_best.json uses it too. And, yes, intents classifier uses.
The example in documentation shows a case when both elements are in the same pipeline.
But, for example, embedder in gobot_dstc2_best.json is not a pipeline element, it is a parameter of go_bot element.
And slotfiller is a go_bot parameter too.
Let's consider an example:
      {
        "in": ["x"],
        "in_y": ["y"],
        "out": ["y_predicted"],
        "main": true,
        "class_name": "go_bot",
        "load_path": "{MODELS_PATH}/my_gobot_rus/model",
        "save_path": "{MODELS_PATH}/my_gobot_rus/model",
        "debug": false,
        "word_vocab": "#token_vocab",
        "template_path": "{DOWNLOADS_PATH}/dstc2_v2_rus/dstc2-templates.txt",
        "template_type": "DualTemplate",
        "database": "#phone_database",
        "api_call_action": "api_call",
        "use_action_mask": false,
        "network_parameters": {
          "learning_rate": 0.002,
          "end_learning_rate": 0.00002,
          "decay_steps": 10,
          "decay_power": 0.5,
          "dropout_rate": 0.45,
          "l2_reg_coef": 2e-3,
          "hidden_size": 128,
          "dense_size": 64,
          "attention_mechanism": {
            "type": "cs_bahdanau",
            "hidden_size": 32,
            "depth": 3,
            "action_as_key": true,
            "max_num_tokens": 100,
            "projected_align": false
          }
        },
        **"slot_filler": {
          "config_path": "{CONFIGS_PATH}/ner/slotfill_dstc2_rus_colab.json"
        },**
        "intent_classifier": "{CONFIGS_PATH}/classifiers/intents_dstc2_big_rus.json",
        **"embedder": {
          "class_name": "fasttext",
          "load_path": "{DOWNLOADS_PATH}/embeddings/lenta_lower_100.bin"
        },**
        "bow_embedder": null,
        "tokenizer": {
          "class_name": "stream_spacy_tokenizer",
          "lowercase": false
        },
        "tracker": {
          "class_name": "featurized_tracker",
          "slot_names": ["surname", "name", "pos_confirm", "neg_confirm", "phone"]
        }
      }

Have I understood right that to include a slotfiller.json pipeline into a gobot_dstc2_best.json I should take a "pipe" component of file: {CONFIGS_PATH}/ner/slotfill_dstc2_rus_colab.json.
And copy-paste the content of "pipe" it to config_path instead of "{CONFIGS_PATH}/ner/slotfill_dstc2_rus_colab.json"?

Hmmm. No, sorry, i don't think it will work like that. For now there is no way to use pipelines as a component constructor argument without using a config reference...
I'll think about what we can do about it.

Hey! The separation of GO-bot units onto separate pipeline units is planned though is not implemented yet.


MonetarySummation.tax_total is parsed incorrectly

Hi,
I noticed that MonetarySummation.tax_total is parsed incorrectly due to MonetarySummation.tax_total_other_currency. They share the tag TaxTotalAmount and therefore the amount string gets split by
https://github.com/pretix/python-drafthorse/blob/5ed87a6f99919156609408b2ecf619f2c82e9b31/drafthorse/models/container.py#L60
For instance, <ram:TaxTotalAmount>0.00</ram:TaxTotalAmount> will end up as <ram:TaxTotalAmount currencyID=".">0</ram:TaxTotalAmount>.
Models:
https://github.com/pretix/python-drafthorse/blob/5ed87a6f99919156609408b2ecf619f2c82e9b31/drafthorse/models/accounting.py#L148

Uh, interesting! Do you have capacity to create a PR? We currently use drafthorse only for generation, not parsing, so it is not a priority for us, but we'd fix it at some point probably

How about
diff --git a/drafthorse/models/container.py b/drafthorse/models/container.py
index 8219378..eb1755e 100644
--- a/drafthorse/models/container.py
+++ b/drafthorse/models/container.py
@@ -61,10 +61,7 @@ class CurrencyContainer(SimpleContainer):
         el._currency = child[1]

     def add_from_etree(self, root):
-        if root.attrib.get("currencyID"):
-            self.add((root.text, root.attrib["currencyID"]))
-        else:
-            self.add(root.text)
+        self.add((root.text, root.attrib.get("currencyID")))

 class IDContainer(SimpleContainer):

Looks consistent with child_type=(tuple, list), which btw isn't enforced since isinstance(self.child_type, type) is false.


change a typo from "fron" to "from"

@Powerhelmsman : Thanks for your contribution! The author, @MightyPen, has been notified to review your proposed change.

@powerhelmsman Thank you for this fix.  Nice catch. We will Merge it into our master documentation source.  (GeneMi , 2018/09/26 10:05am)

@PRMerger18 First, please do Merge this good PR 1004.
.
As an aside, I looked at all three internal Help documentation articles that the TOC filter box can find, and none of them list the special # keywords we Writers are supposed to use - given that we cannot use '# sign - off'.  So I can only use this freeform textual mode of communication.  If there is a # keyword I am supposed to use here, can you tell me what the keyword is?  Thanks.
.
https://review.docs.microsoft.com/en-us/help/contribute/contribute-vendor-public-prs?branch=master
.
https://review.docs.microsoft.com/en-us/help/contribute/contribute-how-to-manage-act-guidelines-public-pr?branch=master
.
https://review.docs.microsoft.com/en-us/help/contribute/contribute-authors-in-public-repo?branch=master

#sign-off


Contest Page

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #301

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Explain the Testing instructions
Test Configuration:

Operating system: Windows
Version: 11
Text-editors used: Code pen

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@sirilalithaadapa the template is not up to the mark to be merged please improve your template

@sirilalithaadapa the template is not up to the mark to be merged please improve your template

Yeah sure will make changes...

@sirilalithaadapa make a new PR when its ready


KeyError: 'sshd'

Hello,
I get the following error when I try to start the exporter:
Traceback (most recent call last):
  File "/f2b-exporter/fail2ban-exporter.py", line 127, in <module>
    REGISTRY.register(F2bCollector(conf))
  File "/usr/lib/python3.7/site-packages/prometheus_client/registry.py", line 24, in register
    names = self._get_names(collector)
  File "/usr/lib/python3.7/site-packages/prometheus_client/registry.py", line 64, in _get_names
    for metric in desc_func():
  File "/f2b-exporter/fail2ban-exporter.py", line 76, in collect
    self.get_jailed_ips()
  File "/f2b-exporter/fail2ban-exporter.py", line 59, in get_jailed_ips
    bantime = config[j[0]]['bantime'].split(';')[0].strip()
  File "/usr/lib/python3.7/configparser.py", line 958, in __getitem__
    raise KeyError(key)
KeyError: 'sshd'

same here

@vdcloudcraft  do you check in on this repo, or is it abandonware?

same here.
is it still supported ?

Hi, I've come into the same exact issue. Found out it was because my jail's config file was a *.conf, when the software actually looks for *.local. Rename that and it should work ! cheers

This issue belongs to: https://github.com/vdcloudcraft/fail2ban-geo-exporter/issues/19


Segments governed by BroadcastDistributionRules shouldn't be moved away from decommissioning servers until all non-broadcasted segments are moved away

Broadcasted segments not only should not be moved away from decommissioning servers until they hold none non-broadcasted segments. Coordinator may actually need to continue loading broadcasted segments on decommissioning servers while it moves non-broadcasted segments away from them.
Similar to #7354.

I would go so far as to call this a bug.

There are many small and large inconsistencies in the current coordination/balancing algorithm which are inter-dependent and are hardly fixable in separation. An overhaul is proposed here: #7458.


Misc event issues

i added followings 2 days ago and seems disappeared for some reasons. adding again
Codeunit 13
local procedure OnProcessLinesOnAfterPostGenJnlLines( GenJournalLine: Record "Gen. Journal Line"; GLRegister: Record "G/L Register"; var GLRegNo: Integer; PreviewMode: Boolean)
Should be
local procedure OnProcessLinesOnAfterPostGenJnlLines( var GenJournalLine: Record "Gen. Journal Line"; GLRegister: Record "G/L Register"; var GLRegNo: Integer; PreviewMode: Boolean)
GenJournalLine param not byref makes it useless
codeunit 5988, PostDocumentLines() function
OnPostDocumentLinesOnAfterFillInvPostingBuffer(ServHeader, ServLine);
this function parameters should include TempInvoicePostBuffer also. otherwise nothing to do in subscriber
codeunit 5986, FillInvoicePostBuffer() function
OnAfterFillInvoicePostBuffer(InvoicePostBuffer, ServiceLine, TempInvoicePostBuffer, SuppressCommit, ServiceLineACY);
UpdateInvoicePostBuffer(TempInvoicePostBuffer, InvoicePostBuffer, ServiceLine);
OnAfterFillInvoicePostBuffer() should be after UpdateInvoicePostBuffer() so i can touch TempInvoicePostBuffer in subscriber
codeunit 5986, UpdateInvoicePostBuffer() function
OnAfterUpdateInvPostBuffer(InvoicePostBuffer);
OnAfterUpdateInvPostBuffer() should have TempInvoicePostBuffer as parameter. nothing to do with InvoicePostBuffer at this stage

off-topic - correct repo is https://github.com/microsoft/AlAppExtensions/issues - and ideally you would also fix the formatting before posting there ;-)


Build consensus in GitHub actions

Add MacOS builds
Add consensus builds as separate jobs
Introduce CACHE_VERSION to make it easy to "invalidate" the cabal store cache
Work around setup-haskell, ghcup bugs
Build with cabal-3.4-rc4 for better caching and faster builds

I think something went wrong while rebasing?

I think something went wrong while rebasing?

It failed because ouroboros-consensus doesn't have tests.

I think something went wrong while rebasing?

It failed because ouroboros-consensus doesn't have tests.

No, I'm talking about the three commits in this PR that are from master.
The tests of ouroboros-consensus live in ouroboros-consensus-test (-test-consensus and -test-storage).

No, I'm talking about the three commits in this PR that are from master

Ah yes.  I've removed them.  Not sure how they got there.

I pushed some changes to make the consensus stuff build on Linux only.

MacOS test failures can be seen here: https://github.com/input-output-hk/ouroboros-network/pull/2839

MacOS test failures can be seen here: https://github.com/input-output-hk/ouroboros-network/pull/2839

MacOS test failures can be seen here: #2839

Executive summary: A test involving IP sees a different result for v4 and v6.

MacOS test failures can be seen here: #2839

Executive summary: A test involving IP sees a different result for v4 and v6.

I chatted with John on Slack. Here's my summary.
He listed out two primary reasons for adding these builds to the this repository's GitHub Actions.

Our networking code does not support running in WINE, which is an emulation of Windows.  Our Hydra builds do not yet provide a way to run tests on Windows proper.  In particular cardano-node test failures when run in WINE could point to an emulation problem so we want to see the same test failures in a Windows VM.  Github Actions provide us to a way to actually run our tests in a Windows VM.

Github Actions provides us a way to build and test against multiple GHC versions, which is also another feature that our Hydra builds do not yet support.  We have downstream projects that are still on ghc-8.6.5 and so rely on our libraries building on ghc-8.6.5.  Having CI check this compile version reduces the amount of risk that code is introduces that causes breakages downstream.  We anticipate further GHC upgrades in the future and not forcing the entire organisation to an atomic switch from one GHC version to another reduces upgrade risks.

He and I also agreed that it makes sense for him to maintain these as a Good Samaritan, but it'd be good to identify others who could proxy/takeover for him if need be. The Consensus Team hasn't owned the CI -- we just know who to ask for help when it hiccups in an interfering way. John suggested @rvl might be a good fit to start with.
Thus, we're fine with this PR proceeding. I'll review the details now. 👍

I chatted with John on Slack. Here's my summary.
He listed out two primary reasons for adding these builds to the this repository's GitHub Actions.

Our networking code does not support running in WINE, which is an emulation of Windows.  Our Hydra builds do not yet provide a way to run tests on Windows proper.  In particular cardano-node test failures when run in WINE could point to an emulation problem so we want to see the same test failures in a Windows VM.  Github Actions provide us to a way to actually run our tests in a Windows VM.

Github Actions provides us a way to build and test against multiple GHC versions, which is also another feature that our Hydra builds do not yet support.  We have downstream projects that are still on ghc-8.6.5 and so rely on our libraries building on ghc-8.6.5.  Having CI check this compile version reduces the amount of risk that code is introduces that causes breakages downstream.  We anticipate further GHC upgrades in the future and not forcing the entire organisation to an atomic switch from one GHC version to another reduces upgrade risks.

He and I also agreed that it makes sense for him to maintain these as a Good Samaritan, but it'd be good to identify others who could proxy/takeover for him if need be. The Consensus Team hasn't owned the CI -- we just know who to ask for help when it hiccups in an interfering way. John suggested @rvl might be a good fit to start with.
Thus, we're fine with this PR proceeding. I'll review the details now. 👍

bors merge

bors merge

Thanks for this, @newhoggy for introducing it and owning it (for the foreseeable future at least). I look forward to seeing it catch some Windows/8.6.5/etc regressions! :)

Thanks for this, @newhoggy for introducing it and owning it (for the foreseeable future at least). I look forward to seeing it catch some Windows/8.6.5/etc regressions! :)

Thanks for all your help getting this through.  It means in future, when there are down stream compile issues we can very quickly rule out upstream issues by pointing to recent successful CI builds.  😁

Thanks for all your help getting this through.  It means in future, when there are down stream compile issues we can very quickly rule out upstream issues by pointing to recent successful CI builds.  😁


GitHub Description URL change

Just wanted to point out the project's URL is broken.
http://indexzero.github.com/api-easy - no longer works
http://flatiron.github.com/api-easy - i believe to be the new url.

Hey! Thanks for the heads-up.

lol np, i'm sure someone will change it soon ;) hah

Fixed.


Fixing the Position of the Score board.

@YadavAkhileshh i can fix the scoreboard place so it doesnt overlap with the gameboard. can you please assign me this task.

@YadavAkhileshh bhai

i have merged 2 PRs before

im assuming #47 was level2 becasue of dark mode and #87 was level3 becasue of backend integration , can you please assign the levels ,
Thank you so much.


Rule wiring at build time via annotation processing

Currently package scanning is performed at runtime which has pros and cons.
It is probably more robust and safer to wire the logic at build time.
The idea:
have an annotation processor similar to the RuleBookRunner that looks for @Rule annotated classes and groups them into rulebooks according to the packages they're found in.
A registry would then permit to retrieve the fully wired rule books.
This is a little less dynamic than the runtime scanning, but has the huge benefit to not depend at all on JAR formats etc. It's as robust as plain Java.

Hmm... that's an interesting idea. I don't think I would want to change or remove the ability to have RuleBooks built at runtime. And there are many reasons for this - it uses a similar approach to Spring's component scanning, which it what many people are used to and the implementation is of POJO rules is really just an adapter, which makes it relatively simple.
However, I could see having an option (or a different kind of POJO RuleBook) that built the rules differently. I think that could work.


Compiling not possible

I want to create
I tried it 30 times with different conditions:

restart (real restart) Raspi
Delete
Add Limit the amount of resources used for compiling

Here is the log:
INFO ESPHome 2023.12.6
INFO Reading configuration /config/esphome/dgzi3bildschirm.yaml...
INFO Updating https://github.com/Blackymas/NSPanel_HA_Blueprint@main
INFO Updating https://github.com/esphome/esphome.git@pull/6051/head
INFO Detected timezone 'Europe/Berlin'
INFO Generating C++ source...
INFO Compiling app...

Dependency Graph
|-- ArduinoJson @ 6.18.5
Compiling .pioenvs/dgzi3bildschirm/src/main.o
xtensa-esp32-elf-g++: fatal error: Killed signal terminated program as
compilation terminated.
*** [.pioenvs/dgzi3bildschirm/src/main.o] Error 1
========================= [FAILED] Took 183.90 seconds =========================

It looks like the as available memory (RAM) is too small.

How can I make it bigger at the Raspberry Pi 4?

I would spin up a virtual machine on a full blown PC. If you still want to use a Raspi probably a swap partition or compressed memory (zram) could be a workaround.


Standardize validator env var

Summary
Follow-on to #21 . Standardizes the environment variables used for the different test suites, now we can just use the default FHIR_RESOURCE_VALIDATOR_URL and remove the url line from the validator definition block
Testing Guidance
There should be no visible impact to the env var change - sessions should start up and work when running via ruby or via docker

This seems like an intermittent failure unrelated to this branch.

I confirmed the issue locally and via validator.fhir.org, I think the error message from tx.fhir.org is breaking the parsing somewhere because of a null character:
"Error from http://tx.fhir.org/r4: The attribute name \u0000 is illegal at Line 580, Column 20" (it's not encoded like that in the actual response, it's a true null character)


[Airbrake] [Production] undefined method `reject' for nil:NilClass

Airbrake error: #1543
Airbrake project: ETMoses
Error type: NoMethodError
Error message: undefined method reject' for nil:NilClass`
Occurred at: Mar 15, 2016 16:01:57 UTC
First seen at: Mar 15, 2016 16:01:57 UTC
Occurrences: 1 (1 since last deploy on Mar 15, 2016 14:31:50 UTC)
URL: https://moses.energytransitionmodel.com/testing_grounds/424/business_cases/188/render_summary
File: [PROJECT_ROOT]/app/services/finance/business_case_summary.rb
Backtrace:
[PROJECT_ROOT]/app/services/finance/business_case_summary.rb:30:in financials_without_freeform
[PROJECT_ROOT]/app/services/finance/business_case_summary.rb:10:in summarize
[PROJECT_ROOT]/app/controllers/business_cases_controller.rb:28:in render_summary
[GEM_ROOT]/gems/actionpack-4.1.8/lib/action_controller/metal/implicit_render.rb:4:in send_action

Related to -> https://github.com/quintel/etmoses/issues/570

Closing due to issue related being closed.


bug: Error thrown when user rejects request is not type UserRejectedRequestError

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.7.9
Current Behavior
When using useSignMessage() and the user clicks on the cancel button, the error thrown is not of type UserRejectedRequestError.
Expected Behavior
Expect to get an error of type UserRejectedRequestError.
Steps To Reproduce
Executing the code:
const { signMessageAsync } = useSignMessage();

let signature: string;
try {
  signature = await signMessageAsync({ message});
} catch (error) {
  console.log(error instanceof UserRejectedRequestError);
  console.log(error instanceof ProviderRpcError);
  console.log(isErrorWithCode(error));
  console.log(isErrorWithMessage(error));
  console.log(getErrorMessage(error));
}

I get the following when I click on the cancel button:
false
false
false
true
user rejected signing (action="signMessage", from="n0x2756f6D40ED4E4df0003CAE", messageData="localhost:3000 wants you to sign in with your Ethereum account:\n0x2756f6D40ED4E4df0003CAE\n\nSign in with Ethereum to the app.\n\nURI: http://localhost:3000\nVersion: 1\nChain ID: 5\nNonce: JIzUBnI6Cee1aUsXT\nIssued At: 2022-12-15T16:23:35.809Z", code=ACTION_REJECTED, version=providers/5.7.2)

It seems the error is not UserRejectedRequestError neither ProviderRpcError. It's a simple Error with a message property.
I used the following methods:
// eslint-disable-next-line @typescript-eslint/no-explicit-any
export const isErrorWithMessage = (error: any): error is { message: string } =>
	typeof error === "object" &&
	error !== null &&
	typeof error.message === "string";

// eslint-disable-next-line @typescript-eslint/no-explicit-any
export const isErrorWithCode = (error: any): error is { code: number } =>
	typeof error === "object" &&
	error !== null &&
	typeof error.code === "number";

export const getErrorMessage = (error: unknown): string | undefined => {
	if (isErrorWithMessage(error)) return error.message;
	return typeof error === "string" ? error : undefined;
};

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
Tested using MetaMask 10.22.2 browser extension.

Unfortunately<EMAIL_ADDRESS>started wrapping RPC errors with a custom error so that's why it's not bubbling up the same way. Can look into a workaround for this.

Thank you @tmm for all the great work!


Document testing

This PR adds information about how this chart is being tested.

Ok waiting on input from @webwurst before merge

I assume you did not found anything, otherwise just open a separate PR :)