luci-app-statistics: Wrong Totals for Iptables Matching Rules

I am here to submit an issue where in luci-app-statistics under firewall category/tab the iptables matching rules for counting up/down internet traffic produce wrong totals. The 1-hour figures seem to be okay but if you change the time span to more lengthy period the totals get distorted a lot.

The above picture is from 1-day time period. As I have a 6mb ADSL connection, I only get around 750+ kb/s download speeds and at this rate I can never download almost 78 GBs data in just 6-8 hours as the picture shows (just talking about one device labeled as ahmar-lap-in but I am sure other figures are incorrect too). Now changing the time period to 1-week and we have:

Now it shows usage about in TBs in just one week which is not possible on my connection. I am not quite sure if the problem is with collectd or with the actual package but if you manually calculate the totals with average value of kb/s in the graph the figures seem reasonable to believe. So maybe a bug somewhere in the code. Please correct the issue ASAP. Thanks for continued support.
P.S. I am not sure who to ask for help directly but I think @jow- and @hnyman are relevant guys here.

Doe not seem like a LuCI issue to me

Well the issue still relates to displaying total figure, so I guess maybe rrd-tool is the culprit here. But in any case you'll have a more thorough knowledge. Please tell me where to report the issue then.

Please provide the output of rrdtool dump /tmp/rrd/*/iptables-*/ipt_bytes-*.rrd

Here is the dump you requested: https://pastebin.com/4ishR4y3

@ahmar20 Did you tried the master or openwrt-19.07 relaese?
There was a version update on collectd.

I am not using collectd and the issue is too old. I think it's best if we close the issue for now. If in the future it happens again, I'll just reopen it. Thank you


Feature Request: Getting a collection of variable from specific Graph

Hi,
For debug purposes, I need to create a collection variables from a specific graph.
I have defined my model in a predefined graph using something like:
pg=tf.Graph()
with pg.as_default():
...
I define my session as:
sess = tf.Session(config=config, graph=pg)
If I need to create a collection of trainable variable in graph pg, I try to use:
tf.get_collection(tf.GraphKeys.TRAINABLE_VARIABLES) or simply tf.trainable_variables(), It doesn't return anything .
If I do the same experiment, using the default 'default graph', and without using 'with', constructs, I am able to get the collection of variables.
I suspect, tf.get_variables is not looking in pg, I believe a method for extracting collection of variables from a given graph, or device would be useful for everybody.
If the feature already exist, please accept my apology for wasting your precious time.
I did check on stack overflow and other avenues suggested by Google.
-Regards

It exists. I could call the get_Collection on the graph itself. Sorry for confusion.


New API to wait for handler executions to complete and warnings on unfinished handler executions

Closes #538
Implementation ready for review; names are still under discussion.
What was changed

Added a new API to wait for update and signal handler executions to complete. Provisionally named workflow.all_handlers_finished().
Issue warnings on workflow exit if any handlers are unfinished.
Allow warnings to be disabled on a per-handler basis via a signal/update decorator parameter.

Why?
Workflows exiting while handler executions are in progress is an important category of run-time workflow incorrectness.

This PR was missing one thing -- it didn't address cancellation. Discussed with @cretz in a different channel and we agreed that it was a bug that the CancelWorkflowExecution command was not being defined to be a workflow "completion" by the SDK. Recent commits fix that bug and add the test coverage that this PR had been missing regarding cancellation.


fix: x-axis scrollbar

close #58

I was wondering, why do you have 4 merge commits? I mean are you facing difficulties when pulling from "dev"?

I was wondering, why do you have 4 merge commits? I mean are you facing difficulties when pulling from "dev"?

I think these are previously pulled by me and pushed through this PR

you have to do 4 pull... that's what I am saying. normally, 1 pull is enough. If you re facing issue or have confusions, then do tell


Wild memory usage and failing to index files with no apparent reason

I installed VS Chromium about 4 days ago and used it with no problems until today.
Today I hit "Code Search" and noticed the index was empty and Vs Chromium was "Busy" reloading it. Note that I had not closed VS since yesterday (when it was working fine).
The indexing is still busy loading but remains totally empty, and looking at the Task Manager I noticed the RAM used by the plugin is oscillating wildly between ~1GB and ~5GB (it scales up from 1 to 5, then it resets to 1 and so on). Restarting Visual Studio doesn't change the plugin's behaviour.
I'm trying to index about 13500 files, fyi.
What baffles me is that this behaviour started with no apparent reason and no dramatic change in the project, and it's also happening to a colleague of mine who installed the plugin the same day as me.
It's a particularly annoying situation, as this plugin was INCREDIBLY useful to replace the pathetic default File Search function, and I was enjoying the speedup a lot :(

In VsChromium.log (the regular one, not the "errors" one), do you see any message similar to this:
[2020-02-03 14:49:08.9768][Server    ][ 11132-7][Info ] ProcessPathsChangedEvent: 1 items left out of 1 after filtering (showing max 5 below).
[2020-02-03 14:49:08.9768][Server    ][ 11132-7][Info ]   Path changed: "<blah blah>", Pathkind=File, Changekind=Created
[2020-02-03 14:49:08.9768][Server    ][ 11132-7][Info ] Some file change events are create or delete events.

I am wondering if there is some disk activity that forces vschromium to rescan the whole directory tree.

@rpaquay Yes, there are multiple instances of that pattern in the log file.
In particular, near the end of the log, that same pattern repeats over and over, saying things like
[2020-01-23 17:50:40.8210][Server    ][ 25312-7][Info ] ProcessPathsChangedEvent: 3 items left out of 4 after filtering (showing max 5 below).
[2020-01-23 17:50:40.8210][Server    ][ 25312-7][Info ]   Path changed: "Z:\XXX.fdb", Pathkind=File, Changekind=Changed
[2020-01-23 17:50:40.8210][Server    ][ 25312-7][Info ]   Path changed: "Z:\XXX.log", Pathkind=FileOrDirectory, Changekind=Changed
[2020-01-23 17:50:40.8210][Server    ][ 25312-7][Info ]   Path changed: "Z:\XXX.suo", Pathkind=FileOrDirectory, Changekind=Changed
[2020-01-23 17:50:40.8210][Server    ][ 25312-7][Info ] All file change events are file modifications.

@silverweed
Ok, I am still not sure what is going on, but let's see if we can try to isolate the source of the problem:
Can you try to change your "vs-chromium-project.txt" to something along the lines of:
[SourceExplorer.ignore]
*.fdb
*.log
*.suo
# Plus whatever you had here

[SearchableFiles.include]
* # Or whatever you had here

[SearchableFiles.ignore]
# Whatever you had here

And see if this solves the problem.
Also, another question: the "Z:" drive you mention in your previous comment, is this a regular driver or some sort of network shared (or something else?).

@rpaquay
Ok, I tried adding a (long) list of ignored extensions and directories, and it looks like now it's working!
No more memory spikes and the indexing seems to work perfectly.
One thing I don't quite get is why I need to have two separate lists for SourceExplorer and SearchableFiles, given that I have disabled the Source Explorer integration in the SolutionExplorer.
Anyway, thanks a lot for your help :)
(The Z: drive is a normal ssd drive, just fyi)

One thing I don't quite get is why I need to have two separate lists for SourceExplorer and SearchableFiles, given that I have disabled the Source Explorer integration in the SolutionExplorer.

This is merely the result of iterative design, and indeed not obvious. Basically, to build the list of "searchable files", VsChromium first uses the SourceExplorer section to filter out files, then uses the SearchableFiles filter as a 2nd pass filter. The 2 features (source explorer and code search) are not very well isolated because they were designed together, and the ability to disable source explorer only came much later.
I am still puzzled why these file changes were causing so much re-indexing and memory usage spike though. VsChromium has been designed to be much more resilient than that.
I hope I am not asking too much, but would you mind sending a log file "sanitized", i.e. where all file paths are removed? I don't think there is not much else in there in terms of user specific data.
If you can't, then maybe just the lines talking about GC memory, for example:
[2020-02-05 08:53:57.2739][Server    ][17116-66][Info ] << FileSystemSnapshotManager: Computing snapshot delta from list of file changes completed in 35 msec - GC Memory: 475,272,832 bytes.

@rpaquay here is the file with all the grepped GC lines:
vschromium_gc.txt.gz
I hope it's enough for you to get some insight about this.

@silverweed thank you for the log file extract. There is not enough information in there to give me hints about what was going on. It looks like you have an enlistment of about 250,000 files. Most of the changes seem to be simple file changes (as opposed to directory deletion, etc.), so VsChromium should be pretty efficient dealing with these changes.
I also see a few "List of projects has changed", which indicate that you maybe closed VS or closed and re-opened the solution you were working with. These operations are heavier because VsChromium has to re-index everything from scratch. I am working on fixing issue #47. This may help if you quickly close and re-open the same solution, for example, if the .sln or .proj files are changed on disk outside of VS.

Ok, thank you for all your help :)

@silverweed I wonder if your issue was somehow related to issues #60 and #61
Maybe give version 0.9.34 a try (it is still pre-release, but I will release it this week unless major issues are found)

Thanks, I'll give it a try when I have some time available 👍

@silverweed I released  version 0.9.36 which contains, among other things, a fix for issue where VsChromium does not show an Index or stop responding after using "Find in Files" in VS 2019. Feel free to give it a try when you have a chance.


Exponential families and natural parameters

It would really great if there is a way of constructing an easy way of switching between standard and natural parameters. This particularly is to address more advanced techniques such as Structured VAEs - https://arxiv.org/abs/1603.06277. However, this would require significant thought on how to incorporate this in the API and so I think a discussion here would be good to make. I have not seen so far a good abstraction for this in any of the existing probabilistic frameworks in the community.

Great idea. Exponential families are always linked to conjugacy, which is very hard to have an automated design. I guess that's why existing frameworks don't have a good support (though some claim to ). But we may start from the easy case. Maybe first a general distribution named ExponentialFamily? And let all subclasses to have the natural parameter attributes.

Hi,
Any updates on this?


WIP: Experimentation with coverage

Signed-off-by: Dave Tucker<EMAIL_ADDRESS>

Refer to this link for build results (access rights to CI server needed):
http://jenkins.socketplane.io/job/socketplane-verify/16/
Success!

Refer to this link for build results (access rights to CI server needed):
http://jenkins.socketplane.io/job/socketplane-verify/17/
Build Failed!

Refer to this link for build results (access rights to CI server needed):
http://jenkins.socketplane.io/job/socketplane-verify/18/
Success!

Refer to this link for build results (access rights to CI server needed):
http://jenkins.socketplane.io/job/socketplane-verify/19/
Success!


Update azure-pipelines.yml

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: avaloniaui-team sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

You can test this PR using the following package version. 0.10.999-cibuild0017600-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json)


Some questions about the dsdl file under /uavcan/equipment/power

What is the meaning of hours_to_empty_at_10sec_avg_power_variance in 1. PrimaryPowerSupplyStatus(message type id:1090), and whether the calculation method is directly calculated by the variance formula?

CircuitStatus（message type id:1091）：
2.1  What does circuit_id refer to?
2.2  Whether the voltage and current here are consistent with the voltage and current of 1092 does not represent what it means

BatteryInfo(message type id:1092)
3.1 temperature：Only one temperature? How to send if there are multiple temperatures?
3.2 battery_id：If one battery pack is 0, but there are multiple battery packs, how to allocate this ID? ? ?
3.3 Bit5  STATUS_FLAG_OVERLOAD : Does it mean that the power is too large, or the current is too large? ? ? ?

Are there any real examples of dynamic nodes, or the source code?
Ask for answers, thank you very much！！！

Your questions appear to be rooted in certain architectural deficiencies of UAVCAN v0 that have been addressed in v1.

What is the meaning of hours_to_empty_at_10sec_avg_power_variance in 1. PrimaryPowerSupplyStatus(message type id:1090), and whether the calculation method is directly calculated by the variance formula?

If hours_to_empty_at_10sec_avg_power is the estimated time to empty, then hours_to_empty_at_10sec_avg_power_variance is the error variance of said estimate. Make it zero if unknown.

2.1 What does circuit_id refer to?
3.2 battery_id：If one battery pack is 0, but there are multiple battery packs, how to allocate this ID?

This is the most critical design fault of v0: the data type definition makes undue assumptions about the architecture of the distributed system it is supposed to facilitate. The field in question is intended to segregate different electrical circuits within the vehicle. For instance, your primary power source could bear the ID of 0, the power supply of a servo would be id=1, and so on.
In v1, this is handled in an entirely different manner that is aligned with the principles of modern software design: instead of dealing with IDs, your data types contain only the application-level items, and the task of functional segregation is implemented based on port-IDs instead of instance IDs. This is reviewed in The Guide.

Whether the voltage and current here are consistent with the voltage and current of 1092 does not represent what it means

The semantics of these measurements are application-defined. You need to know the architecture of the vehicle to understand what does every ID represent. Similarly, in v1, you need to know the architecture of the vehicle to understand what port-IDs should be used.

3.1 temperature：Only one temperature? How to send if there are multiple temperatures?

Find a sensible reduction. For instance, send the maximum temperature, or average.

3.3 Bit 5 STATUS_FLAG_OVERLOAD: Does it mean that the power is too large, or the current is too large?

This flag indicates that a critical parameter that is directly coupled with the instantaneous power output of the device is outside of the recommended operating conditions. This could be the electric power, electric current, temperature, voltage, or any other quantitiy depending on the construction of the device. The objective of this flag is to communicate to the controller (whether human or automatic) that the current conditions are abnormal and the controller should seek to reduce the power consumption.

You should know that UAVCAN v0 will become obsolete in the foreseeable future. The UAVCAN Consortium is currently working on the new application-layer standard that will replace the design that you are currently working with. If you want to take part in this effort, consider applying here: https://uavcan.org/consortium
Also, the correct place for discussions of this variety is on the forum at https://forum.uavcan.org/. If you have any further questions, please, post them over there. I am going to close this issue now.

Your questions appear to be rooted in certain architectural deficiencies of UAVCAN v0 that have been addressed in v1.

What is the meaning of hours_to_empty_at_10sec_avg_power_variance in 1. PrimaryPowerSupplyStatus(message type id:1090), and whether the calculation method is directly calculated by the variance formula?

If hours_to_empty_at_10sec_avg_power is the estimated time to empty, then hours_to_empty_at_10sec_avg_power_variance is the error variance of said estimate. Make it zero if unknown.

2.1 What does circuit_id refer to?
3.2 battery_id：If one battery pack is 0, but there are multiple battery packs, how to allocate this ID?

This is the most critical design fault of v0: the data type definition makes undue assumptions about the architecture of the distributed system it is supposed to facilitate. The field in question is intended to segregate different electrical circuits within the vehicle. For instance, your primary power source could bear the ID of 0, the power supply of a servo would be id=1, and so on.
In v1, this is handled in an entirely different manner that is aligned with the principles of modern software design: instead of dealing with IDs, your data types contain only the application-level items, and the task of functional segregation is implemented based on port-IDs instead of instance IDs. This is reviewed in The Guide.

Whether the voltage and current here are consistent with the voltage and current of 1092 does not represent what it means

The semantics of these measurements are application-defined. You need to know the architecture of the vehicle to understand what does every ID represent. Similarly, in v1, you need to know the architecture of the vehicle to understand what port-IDs should be used.

3.1 temperature：Only one temperature? How to send if there are multiple temperatures?

Find a sensible reduction. For instance, send the maximum temperature, or average.

3.3 Bit 5 STATUS_FLAG_OVERLOAD: Does it mean that the power is too large, or the current is too large?

This flag indicates that a critical parameter that is directly coupled with the instantaneous power output of the device is outside of the recommended operating conditions. This could be the electric power, electric current, temperature, voltage, or any other quantitiy depending on the construction of the device. The objective of this flag is to communicate to the controller (whether human or automatic) that the current conditions are abnormal and the controller should seek to reduce the power consumption.
You should know that UAVCAN v0 will become obsolete in the foreseeable future. The UAVCAN Consortium is currently working on the new application-layer standard that will replace the design that you are currently working with. If you want to take part in this effort, consider applying here: https://uavcan.org/consortium
Also, the correct place for discussions of this variety is on the forum at https://forum.uavcan.org/. If you have any further questions, please, post them over there. I am going to close this issue now.

Thank you so much


Is it possible to have more than 2 LED channels, or is it possible to run “two instances” from a single Arduino?

Not sure if this is the correct place to post this but I’m new to GitHub so I apologize. If not the correct place for this, I’d appreciate some direction. Thank you.
I am brand new to RGB lighting, controllers and hardware programming. I recently built my first PC and decided to go with the Corsair lighting platform. My RGB capable devices and their connections are:
• ASUS TUF Gaming B660 Plus Wifi D4 (Aura Sync)
• 2x 1TB XPG NVMe SSD ~> RGB control from Mobo (Aura Sync)
• 24 pin ATX 90° adapter ~> Connected to Mobo ARGB Header (Aura Sync)
• Lian Li Strimer (24 & 6 pin) ~> Lian Li Controller ~> Corsair Commander Pro (iCUE)
• Lian Li Galahad 240 AIO ~> Corsair Commander Pro (iCUE)
I would like to migrate all RGB devices not currently controller by iCUE to use iCUE. I also want to have all future RGB devices to also be controlled by iCUE. To accomplish this, I need additional LED channels due there are only two available on the Commander Pro.
I saw the the Lighting Node Pro is not sold alone, but as an included item on Corsair LED strips and the LS100 triangles. The strips are low density and I don’t like how few LEDs they have and I’m not interested in the triangles…not for $150, specially when all I really want is the Lighting Node Pro.
This has led me directly to this page and the possibility of creating my own with Arduino. I have purchased the items I need for this, but while doing this, I was wondering if I should buy TWO Arduino UNO’s so I can make two of these and have 4 channels.
However, I was wondering is it possible to program the Arduino for 4 channels instead of just two?
OR, is it possible to run “two instances” of this in order to achieve 4 channels total?
Forgive my ignorance if this is simply not possible…again, this is my first time learning about all this.

You can only have two channels per Arduino. Also it's much easier to use Arduino Leonardo or SparkFun Pro Micro boards than Arduino uno boards.

Hi! Thank you for the reply. Can I follow the same process if I go with your suggestion of using Arduino Leonard instead of the Uno?

The process of setting up Arduino Leonardo is simpler than the Arduino uno. It is described here https://github.com/Legion2/CorsairLightingProtocol#create-a-lighting-node-pro-with-avr

Thank you!


Part of the content in the table is not displayed when converting to PDF

Expected Behavior

Actual Behavior

When inserting content into a table, if there is too much text, part of the content in the table will not be displayed
Possible Solution

Steps to Reproduce

1.Generate a .dita file, insert a table into it
2.Add many and many texts or codes to the table content
3.Convert it to PDF format, some of the content is not displayed

Copy of the error message, log file or stack trace

Environment

DITA-OT version: 3.4
Operating system and version:
( macOS, Windows)
How did you run DITA-OT?
(dita command,CMS,)
Transformation type:
(PDF)

Would it be possible to attach such a DITA topic for tests?
Also is it possible that content does not show up because the table width is too large and there is no room to display it in the page?

https://github.com/guanganyuan/pptest1/blob/master/t1845523.dita
https://github.com/guanganyuan/pptest1/blob/master/expect.png
https://github.com/guanganyuan/pptest1/blob/master/not display.png

Would it be possible to attach such a DITA topic for tests?
Also is it possible that content does not show up because the table width is too large and there is no room to display it in the page?

I`ve known what was the problem,thx


Fix: storybook-react version

Codecov Report
Base: 42.29% // Head: 43.17% // Increases project coverage by +0.88% :tada:

Coverage data is based on head (f923105) compared to base (9e2ab4d).
Patch coverage: 63.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   42.29%   43.17%   +0.88%
==========================================
  Files          77       77
  Lines         480      491      +11
  Branches       40       41       +1
==========================================
+ Hits          203      212       +9
- Misses        240      241       +1
- Partials       37       38       +1

Impacted Files
Coverage Δ

src/containers/Home.container.tsx
0.00% <0.00%> (ø)

src/pages/index.tsx
0.00% <0.00%> (ø)

src/store/room/room.slice.ts
81.25% <73.33%> (-3.75%)
:arrow_down:

src/mocks/http.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Strange results from ox.consolidate_intersectons

[x] I have read the OSMnx contributing guidelines
[x] I have read the OSMnx documentation and usage examples
[x] I have searched the open/closed issues and StackOverflow for problems similar to mine

Problem description

What did you do? Tried to use the consolidate_intersections to merge intersection nodes to a single point
What did you expect to happen? See images below
And what actually happened instead?

# Project the graph to meters
G = ox.project_graph(G, to_crs='epsg:2950')

# Filter edges based on highway type
allowed_highway_types = ["primary",
                         "secondary",
                         "tertiary",
                        ]
edges_subset = []
for u, v, data in G.edges(data=True):
    if data['highway'] in allowed_highway_types:
        edges_subset.append((u, v, 0))

G_subset = G.edge_subgraph(edges_subset)
gdf_links_raw = ox.graph_to_gdfs(G_subset, nodes=False)

G_consolidated = ox.consolidate_intersections(G_subset, rebuild_graph=True, tolerance=15, dead_ends=False)
gdf_links_consolidated = ox.graph_to_gdfs(G_consolidated, nodes=False)

# Then plot those graphs using folium for example

Unconsolidated intersections:

Consolidated intersections:

Question: why isn't it merged like this?

Note: I tried changing the tolerance to 10m and 20m but I never seem to get the intended result. Perhaps I am misunderstanding the results that consolidate_intersections should offer.
Note: The OSM XML file is attached, but it's basically just an export of highway=* from Overpass.
Here is the intersection in OpenStreetMap: https://www.openstreetmap.org/#map=18/45.55885/-73.59832
Thanks!
osm_network_agglomeration_montreal.xml.zip

Please provide the OSM IDs of the nodes that were merged together into this single consolidated node, and which of them you believe should not have been merged.

Hi, I think I had misunderstood the "tolerance" parameter and accidentally set it larger than it had to be, thus merging nodes that shouldn't be merged. Closing this issue :)


Large navigation header

Add navigation header for large screens
Link theme
Fix deep linking

TODO:

Tests

Future work:

Implement logout flow in backend
Small screen navigation header

in mobile the view, the navigator only shows one route, I'd expect at least also the logout button there

Mobile will have a different header (drawer). I thought it's ok to leave it semi-broken for now as we mostly develop on web, but we should do another pr soon for the mobile header.

/lgtm

/lgtm


Nkas

[Current coverage][cc-pull] is 10%

Merging [#126][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #126   diff @@
==========================================
  Files            12         12
  Lines           332        332
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             34         34
  Misses          298        298
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [03d26c9...3820cd9][cc-compare]
[cc-base-branch]: https://codecov.io/gh/lanit-tercom-school/grouplock/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/lanit-tercom-school/grouplock/compare/03d26c98606f780e03a9e5e865586435558d6379...3820cd91278bd1fad760626ff1fa723f683ff93d?src=pr
[cc-pull]: https://codecov.io/gh/lanit-tercom-school/grouplock/pull/126?src=pr

@NIKKAS29: если бранч больше не нужен - удалитье его.


Imported namespaces aren't recognized in --checkJs

TypeScript Version:  nightly (2.5.0-dev.20170613)
Code
test-externclassdef.js
class Foo {
  constructor() {}
}

exports.Foo = Foo;

test-externclass.js
const {Foo} = require('./test-externclassdef');
const Stuff = require('./test-externclassdef');

// this works now
/** @type {Foo} */
let a = new Foo();

// this is still an error
/** @type {Stuff.Foo} */
let b = new Stuff.Foo();

Expected behavior:
No error
Actual behavior:
test-externclass.js(9,12): error TS2503: Cannot find namespace 'Stuff'.

#16316 fixes the first kind of import (which I'm really thankful for), but the second kind is still an error.

Actually, the above example works because of type inference, and not because of the annotation.
const {Foo} = require('./test-externclassdef');
// this doesn't work foo is still of type any
/** @type {Foo} */
let a;
a = new Foo();

I think I have a similar issue, it might even be the same one but I'm not entirely sure.
I'm trying to reference a type from an npm package that I required in a JSDoc type comment like this:
// some-module.js

declare function SomeModule(opts?: SomeModule.Options);

declare namespace SomeModule {
  interface Options {
    enabled?: boolean
  }
}

export = SomeModule;

// my-code.js

const SomeModule = require('./some-module');

// Causes "Cannot find namespace 'SomeModule'" error
/** @type {SomeModule.Options} */
const options = {
  enabled: true
};

Would the fix for this issue help my case too?

@lumaxis yes, I believe so.

I didn't want to open up another issue but this seems like it could be related to the issue I'm having.
import will load a module's .d.ts file but require wont. I can't use import on NodeJS and have to use require
Works with --checkJS, but won't run in NodeJS
import moment from 'moment';
/**
 * @return {moment.Moment}
 */
function getTime() {
  return moment();
}

Doesn't work with --checkJS, but works with NodeJS:
const moment = require('moment');

/**
 * @return {moment.Moment}
 */
function getTime() {
  return moment();
}

Error: Cannot find namespace 'moment'.

+1 on this. I can't annotate JS-doc style to get some intellisense when I'm in a node JS project using commonjs, which is very annoying.

Will this also allow to import an interface from a ts file?

I think you are looking for https://github.com/Microsoft/TypeScript/issues/14377

Should be fixed by https://github.com/Microsoft/TypeScript/pull/21974 and https://github.com/Microsoft/TypeScript/pull/22161


⚠ SceneTime has degraded performance

In 56016fa, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 4089 ms

Resolved: SceneTime performance has improved in 48ac10b after 5 minutes.


Manage heketi.db with a pv/pvc

The actual process create a separated gluster volume to hold the heketi.db
But it could be managed via a pvc/pv, it simplifies the setup and have a unified way to manage all the gluster volumes (no exception).
For example, one usecase is that you can clean up the whole cluster by using only kubectl delete ...
and create it again from scratch without extra actions
As a poc, I tryied the following with success:

created the 'deploy-heketi' resource
boostraped the heketi.db with the topology file
created a glusterfsvolume + the pv/pvc
created the final heketi-deployment with the pvc mounted(modified template:  heketi.yaml)
copied the heketi.db from deploy-heketi to this volume

$ kubctl get pv
NAME          CAPACITY   ACCESSMODES   RECLAIMPOLICY   STATUS    CLAIM
heketidbstorage  4Gi        RWX           Retain       Bound   glusterfs/heketi

$ kubectl get pvc --namespace glusterfs
NAME      STATUS    VOLUME            CAPACITY   ACCESSMODES   AGE
heketi    Bound     heketidbstorage   4Gi        RWX

Would you be interested to move to a such configuration? and discuss the correct way to achieve this?

@ant31 IMO This will still not solve anything. We are more interested on removing the deploy-heketi part(ideas are welcomed) :).

@ant31 @MohamedAshiqrh See #37 for a possible solution to not needing deploy-heketi or even a volume for the DB.

@MohamedAshiqrh It's not solve the deploy-heketi , but it give a direction of the final setup.
My target is to do everything in a single command like:
kubectl create -f heketi --namespace glusterfs
and also be able to remove/rollback it
kubectl delete ns glusterfs
this is issue is part of this goal. Of course the bootstrap steps with deploy-heketi is the biggest issue.
I'm trying first to remove other manual steps before.
Is there a thread to discuss removing deploy-heketi?

@ant31 This goal is unattainable. The administrator must have knowledge of and provide a description for the block devices heketi will manage. There is no way to automatically or even safely detect storage and know what can and cannot be used. It should also be noted that a simple kubectl delete operation of any kind would not be able to properly remove all traces of heketi and GlusterFS on the nodes and their storage, and would require additional administrative tasks.
At present you can use the gk-deploy script to deploy heketi (and optionally GlusterFS) with a single command, provided you have a properly configured topology file. While the script does provide an --abort option in case the deployment fails partway, the clean and complete removal of a storage solution is a tricky and very site-specific endeavour, and is thus currently not in scope for this project.
To address the initial comment, in the current context it would not make much sense to manage the heketi DB storage volume as a PVC since heketi, as part of the current deployment process, assumes management and control over its own volume. If the intent is to simply the deployment and usage of heketi, I again point you to #37 as a likely step in that direction.

The administrator must have knowledge of and provide a description for the block devices heketi will manage
Thi is not about 'auto device' discovery, as proposed in #46, topology can be configured via configmap.

As for #37, I don't think deploying an etcd cluster is any easier than simply mounting a volume.
Thanks for your answers

@ant31 I'd just like to point out, you can do a simple kubectl create -f etcd.yml to deploy an etcd cluster in Kubernetes. If you're not using the gk-deploy script, this would greatly simplify the manual deployment of heketi on Kubernetes, which seems in line with the spirit of your original comment.


[Core] CUDA Graphs for Multi-Step Chunked Prefill

PR 8378 uses cuda-graphs sparsely. When a scheduler step schedules prefills with the decode, all the steps in the multi-step runs in eager mode. But in fact, only the first step in the multi-step will have both prefills and decodes and the rest of the steps are fully decode-only. This PR leverages that fact and pads the necessary data structures so to use CUDA graphs in all steps expect the first-step. This improves performance.
This PR is based out of https://github.com/vllm-project/vllm/pull/8378 and should land after that does.
I plan to keep all the cuda-graph related changes in a single commit (the latest commit), so it is easier to understand the delta.
Benchmarks
Machine : H100
Benchmark Throughput
Command : python3 benchmarks/benchmark_throughput.py --model meta-llama/Meta-Llama-3-8B    --use-v2-block-manager   --tensor-parallel-size ${tp}   --gpu-memory-utilization     0.90  --num-scheduler-steps ${ms} --max-num-batched-tokens 8192  --num-prompts 1000  --dataset ./ShareGPT_V3_unfiltered_cleaned_split.json

Branch |   |   |   |
-- | -- | -- | -- | --
  | Multi-Step | Chunked Prefill | Requests / Sec | Tokens / Sec
main - TP 1 | 8 | No | 44.27 | 18305
PR 8378 - TP 1 | 8 | Yes | 43.66 | 18053
This PR - TP 1 | 8 | Yes | 44.66 | 18462
main - TP 2 | 8 | No | 59.97 | 24801
PR 8378 - TP 2 | 8 | Yes | 60.35 | 24955
This PR - TP 2 | 8 | Yes | 64.06 | 26490
Benchmark Serving
Server command : python3 -m vllm.entrypoints.openai.api_server --model meta-llama/Meta-Llama-3-8B  --port 9000 --swap-space 16 --disable-log-requests  --use-v2-block-manager   --tensor-parallel-size ${tp} --worker-use-ray --pipeline-parallel-size 1 --gpu-memory-utilization 0.90  --num-scheduler-steps 8 --enable-chunked-prefill  --max-num-batched-tokens 8192
Client command : python3 benchmarks/benchmark_serving.py     --backend vllm      --model meta-llama/Meta-Llama-3-8B     --dataset-name sharegpt     --dataset-path ./ShareGPT_V3_unfiltered_cleaned_split.json --port 9000 --num-prompts 1000 --request-rate ${qps}
####### Config : TP = 1 , MS = 8
main
============ Serving Benchmark Result ============
Successful requests:                     1000
Benchmark duration (s):                  23.41
Total input tokens:                      215196
Total generated tokens:                  128169
Request throughput (req/s):              42.72
Output token throughput (tok/s):         5475.78
Total Token throughput (tok/s):          14669.62
---------------Time to First Token----------------
Mean TTFT (ms):                          4627.92
Median TTFT (ms):                        3641.24
P99 TTFT (ms):                           15246.19
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          42.38
Median TPOT (ms):                        32.78
P99 TPOT (ms):                           208.42
---------------Inter-token Latency----------------
Mean ITL (ms):                           227.65
Median ITL (ms):                         232.94
P99 ITL (ms):                            642.93
==================================================

PR 8378 with --enable-chunked-prefill --max-num-batched-tokens 8192
============ Serving Benchmark Result ============
Successful requests:                     1000
Benchmark duration (s):                  22.02
Total input tokens:                      215196
Total generated tokens:                  128079
Request throughput (req/s):              45.41
Output token throughput (tok/s):         5815.49
Total Token throughput (tok/s):          15586.56
---------------Time to First Token----------------
Mean TTFT (ms):                          4685.13
Median TTFT (ms):                        4024.45
P99 TTFT (ms):                           14324.25
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          22.01
Median TPOT (ms):                        25.09
P99 TPOT (ms):                           34.38
---------------Inter-token Latency----------------
Mean ITL (ms):                           192.59
Median ITL (ms):                         211.36
P99 ITL (ms):                            337.90
==================================================

This PR with --enable-chunked-prefill --max-num-batched-tokens 8192
============ Serving Benchmark Result ============
Successful requests:                     1000
Benchmark duration (s):                  21.43
Total input tokens:                      215196
Total generated tokens:                  125650
Request throughput (req/s):              46.66
Output token throughput (tok/s):         5863.25
Total Token throughput (tok/s):          15905.01
---------------Time to First Token----------------
Mean TTFT (ms):                          4365.88
Median TTFT (ms):                        3754.86
P99 TTFT (ms):                           13553.57
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          22.27
Median TPOT (ms):                        24.68
P99 TPOT (ms):                           35.56
---------------Inter-token Latency----------------
Mean ITL (ms):                           189.40
Median ITL (ms):                         186.68
P99 ITL (ms):                            343.67
==================================================

####### Config : TP = 2, MS = 8
main
============ Serving Benchmark Result ============
Successful requests:                     1000
Benchmark duration (s):                  19.96
Total input tokens:                      215196
Total generated tokens:                  126602
Request throughput (req/s):              50.11
Output token throughput (tok/s):         6343.54
Total Token throughput (tok/s):          17126.18
---------------Time to First Token----------------
Mean TTFT (ms):                          3899.19
Median TTFT (ms):                        3045.08
P99 TTFT (ms):                           13019.69
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          35.41
Median TPOT (ms):                        28.81
P99 TPOT (ms):                           162.29
---------------Inter-token Latency----------------
Mean ITL (ms):                           195.12
Median ITL (ms):                         178.06
P99 ITL (ms):                            484.17
==================================================

PR 8378 with --enable-chunked-prefill --max-num-batched-tokens 8192
============ Serving Benchmark Result ============
Successful requests:                     1000
Benchmark duration (s):                  20.17
Total input tokens:                      215196
Total generated tokens:                  126059
Request throughput (req/s):              49.57
Output token throughput (tok/s):         6249.33
Total Token throughput (tok/s):          16917.60
---------------Time to First Token----------------
Mean TTFT (ms):                          4297.16
Median TTFT (ms):                        3625.66
P99 TTFT (ms):                           13590.24
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          21.16
Median TPOT (ms):                        24.71
P99 TPOT (ms):                           29.83
---------------Inter-token Latency----------------
Mean ITL (ms):                           188.39
Median ITL (ms):                         235.91
P99 ITL (ms):                            288.30
==================================================

This PR with --enable-chunked-prefill --max-num-batched-tokens 8192
============ Serving Benchmark Result ============
Successful requests:                     1000
Benchmark duration (s):                  17.35
Total input tokens:                      215196
Total generated tokens:                  126261
Request throughput (req/s):              57.64
Output token throughput (tok/s):         7277.34
Total Token throughput (tok/s):          19680.65
---------------Time to First Token----------------
Mean TTFT (ms):                          3623.76
Median TTFT (ms):                        3235.93
P99 TTFT (ms):                           10632.75
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          16.77
Median TPOT (ms):                        19.21
P99 TPOT (ms):                           23.95
---------------Inter-token Latency----------------
Mean ITL (ms):                           149.88
Median ITL (ms):                         170.52
P99 ITL (ms):                            284.91
==================================================

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops.  See tests/kernels for examples.
When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Converted the PR to draft so it can land after #8378


Removed authorship deduplication.

Not really required, but I suppose we can remove this and make it a data consistancy issue going forward.

@qjhart you are handling dedupe of Authorship in the data now?

@jrmerz.  Yes, that should have been fixed with. https://github.com/ucd-library/rp-ucd-harvest/pull/57


Added ability to attach driver logs to Selenoid logs (fixes #68)

Codecov Report

Merging #222 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   75.63%   75.37%   -0.27%
==========================================
  Files           5        5
  Lines         669      670       +1
==========================================
- Hits          506      505       -1
- Misses        141      145       +4
+ Partials       22       20       -2

Flag
Coverage Δ

#unittests
75.37% <100%> (-0.27%)
:arrow_down:

Impacted Files
Coverage Δ

main.go
62.57% <100%> (+0.23%)
:arrow_up:

selenoid.go
74.78% <0%> (-0.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98f704...fe4ce69. Read the comment docs.


visit.llnl.gov redirect broken?

Describe the bug
It might be a be a browser cache issue, but sometimes when I type: visit.llnl.gov, I get directed to:
https://wci.llnl.gov/codes/visit/

It would be good if that page could forward to the new website as well.

I just tried Edge and Chrome and both brought me to the github web site.

@cyrush to get where you want to go (old execs) go to https://visit-dav.github.io/visit-website/dev-resources/ and then to Older releases links from there.

Describe the bug
It might be a be a browser cache issue, but sometimes when I type: visit.llnl.gov, I get directed to:

It may not be a browser cache as much as an autocomplete issue. I have similar problems in Safari because it autocomplets to some place I've been to many times before instead of going to the real URL I want but neglected to fully type in.

The link to the old llnl web site is:
https://wci.llnl.gov/simulation/computer-codes/visit
It is a single page that gives a high level overview of VisIt and some information on the history of VisIt and has a link to the GitHub one.

Yeah -- https://wci.llnl.gov/simulation/computer-codes/visit
works.
https://wci.llnl.gov/codes/visit/
That must be older, not sure how I ended up there.

This is confusing, but there is still an issue -- we had 2 redirects:
http://visit.llnl.gov ==> ok (https://visit-dav.github.io/visit-website/)
http://www.llnl.gov/visit ==> bad (https://wci.llnl.gov/codes/visit/)

http://www.llnl.gov/visit ==> bad (https://wci.llnl.gov/codes/visit/)

I can request to deactivate that one. I had forgotten it existed.

This redirect has been fixed


RTD build for the project is broken

This is due to:

Problem in your project's configuration. Invalid configuration option "build.os": build not found

Evening All,
is there anything I need to do to avoid this error? I've jusProblem in your project's configuration. Invalid configuration option "build.os": build not found added RTD to my list of OAuth applications and it has successfully cloned my repo -- it was failing previously -- however, a build now gives this errors:
Problem in your project's configuration. Invalid configuration option "build.os": build not found

Any advice gratefully received, thanks.
Cheers,
Norm.

Please synchronise your branch with the latest main branch.

Hi @pradyunsg and thanks for your advice. I am building with the "master" branch as this is a documentation repo. My branch is up to date. Unfortunately, this isn't the cause of my current problem.
Cheers,
Norm.

Ok, I think I've "fixed" it now! In case anyone is still having build problems, here's what I ended up having to do:

Update .readthedocs.yaml, in the root of my repository, to the following:

# .readthedocs.yaml
# Read the Docs configuration file
# See https://docs.readthedocs.io/en/stable/config-file/v2.html for details

# Required
version: 2

# Set the version of Python and other tools you might need
build:
  os: ubuntu-22.04
  tools:
    python: "3.11"
  jobs:
    post_create_environment:
      - python -m pip install sphinx_rtd_theme

# Build documentation with Sphinx.
sphinx:
  builder: html
  configuration: sphinx/source/conf.py
  fail_on_warning: false

# We recommend specifying your dependencies to enable reproducible builds:
# https://docs.readthedocs.io/en/stable/guides/reproducible-builds.html
# python:
#   install:
#   -

I had to add the build details, which does match up with the error message I was seeing.
The jobs detail was also necessary as it seems that the sphinx_rtd_theme isn't installed automagically as part of the build now/any more. This bit was required:
jobs:
    post_create_environment:
      - python -m pip install sphinx_rtd_theme

Update sphinx/source/conf.py  (in my case) and add:

extensions = ['sphinx_rtd_theme']

I already had it in as the html_template but it seems that's no longer all that is required.
Thanks for the help.
Cheers,
Norm.


When no internet available, Then also MQTT endPublish() returns success(1), and data also not uploaded to server.

I  am using esp32, I am sending data over MQTT Broker, but, In testing when I disconnect Internet in midway, and then I use beginPublish(), write() and endPublish(). In Library source file, it is state that for endPublish(), that
// Returns 1 if the packet was sent successfully, 0 if there was an error
But When There is no internet available, how this function returns success.
Thank You

I am using esp32, I am sending data over MQTT Broker, but, In testing when I disconnect Internet in midway, and then I use beginPublish(), write() and endPublish(). In Library source file, it is state that for endPublish(), that
// Returns 1 if the packet was sent successfully, 0 if there was an error
But When There is no internet available, how this function returns success.
Thank You

Defeats the whole MQTT purpose!
If this is true, how was it not picked up by now and in initial testing!?

Sorry for delay reply, I have tested this many times and result is same.
Please try this.
Thank You

It is waste of code to check endPublish() state. If you are look at the sourse code you can see this
int PubSubClient::endPublish() {
 return 1;
}


[Discussion] Compound variants

First of all, kudos for the library, awesome work 👍
I've got a question on the recommended approach for handling compound styles.
Lets say we have a button outer shell
const ButtonRoot = styled(TouchableOpacity, {
  display: "flex",
  flexDirection: "row",
  justifyContent: "center",
  alignItems: "center",
  width: 200,
  padding: 12,
  variants: {
    type: {
      solid: {},
      outline: {
        borderWidth: 1,
      },
    },
    colorScheme: {
      primary: {},
      positive: {},
      negative: {},
    },
  },
},
});

How should we handle the compound variants in a dynamic styling function?
 compoundVariants: {
    "outline+primary": {
      borderColor: "#087ea4",
    },
    "outline+positive": {
      borderColor: "#527717",
    },
    "outline+negative": {
      borderColor: "#ff393f",
    },
    "solid+primary": {
      backgroundColor: "#087ea4",
    },
    "solid+positive": {
      backgroundColor: "#527717",
    },
    "solid+negative": {
      backgroundColor: "#ff393f",
    }

Hey @atanaskanchev thanks for the question.
I would move veriants to the theme:
export const theme = {
   // your colors
   // your other props
   variants: {
       // your structure for variants
   }
}

and then I would create a base component:
export const ButtonRoot = props => {
  // you can access all your variants with theme
   const { styles, theme } = useStyles(stylesheet)

   // based on props select variant from theme
   const dynamicVariant = props.solid
           ? theme.variants.solid
           : theme.variants.outline

   return (
        <TouchableOpacity
              // props
              style={{
                    ...styles.baseStyles,
                    ...dynamicVariant
              }}
        />
   )
}

const stylesheet = createStyles(theme => ({
      baseStyles: {
           ...theme.variants.baseVariant
      }
})

Makes sense, thanks


[E2E] Torchbench float16 training timm_efficientnet accuracy regression

🐛 Describe the bug
xpu  train timm_efficientnet
[WARNING] Failed to create Level Zero tracer:<PHONE_NUMBER>
(I): Detected 2048 spills, recompiling the kernel using large GRF mode
(I): Kernel has now 0 spills
(I): Detected 1024 spills, recompiling the kernel using large GRF mode
(I): Kernel has now 0 spills
(I): Detected 1024 spills, recompiling the kernel using large GRF mode
(I): Kernel has now 0 spills
(I): Detected 1024 spills, recompiling the kernel using large GRF mode
(I): Kernel has now 0 spills
E0907 00:54:25.073000 2172206 site-packages/torch/_dynamo/utils.py:1798] RMSE (res-fp64): 0.00040, (ref-fp64): 0.00010 and shape=torch.Size([4, 96, 1, 1]). res.dtype: torch.float16, multiplier: 3.000000, tol: 0.001000, use_larger_multiplier_for_smaller_tensor: 0
E0907 00:54:25.074000 2172206 site-packages/torch/_dynamo/utils.py:1670] Accuracy failed for key name blocks.1.0.se.conv_reduce.weight.grad
fail_accuracy
Versions
last known good:
pytorch:<PHONE_NUMBER>50b477e3a09cbf487288de5d8af616
torch-xpu-ops: https://github.com/intel/torch-xpu-ops/commit/aae765ae17596404696015165fe383297b3103cb

Passed in latest weekly test https://github.com/intel/torch-xpu-ops/actions/runs/10852406075

Aligned with Mengfei, this issue passed with the local reproducer and weekly test. Will double-check if it fails in the future test.

@mengfei25 can we close this issue now?

pass in the latest weekly test


[BUG]: The Overview text never loads (despite waiting >10 seconds)

Scenario: Compare Models
Step: 4.3
Link to the project: https://app.staging.terarium.ai/projects/5352e859-0832-4ad2-9cd8-7a77d4b152ca/workflow/d7c8c2bd-babb-41a6-9c0e-f8e12c74e4e4?operator=ccb70f8f-609a-4445-bc33-938b6f500d9c

Describe the issue
The Overview section of the Compare Models operator should be populated with some text but that never happens, even after waiting for >10 seconds.

duplicate


header inclusion issues for STM32U545 series

In trying to get Zephyr RTOS working on the Nucleo U545RE-Q board, I discovered header inclusion issues building the HAL for the STM32U545 SoC.
Zephyr RTOS makes use of the "stm32u5xx_hal_driver" for some interactions with the ST hardware, and builds the HAL by copying the default "stm32_hal_conf_template.h" to "stm32_hal_conf.h", leaving all options enabled.
However, some of the modules (specifically HAL_SRAM_MODULE_ENABLED, HAL_NAND_MODULE_ENABLED and HAL_NOR_MODULE_ENABLED) do not compile for the STM32U545.  Based on recommendations from a engineer in the Zephyr forums, I modeled changes to four files ((stm32u5xx_hal_sram.h, stm32u5xx_hal_nor.h, stm32u5xx_hal_nand.h and stm32u5xx_ll_fmc.h) with appropriate "#ifdef" checks using the example for the "stm32g4xx_hal_driver", and this allows the code to build for the U545 series.  Clearly, I'd appreciate ST (and others) review of these changes to ensure correctness.
I'll submit a PR shortly so the changes can be reviewed.

Hello @rob-the-dude,
Thank you for your contribution. You are absolutely right about this point.
Actually, the point you raised has already been dealt and fixed internally. The fix will be made available in the frame of a future release.
please allow me to close this issue and ensure that our conversation remains focused on this pull-request https://github.com/STMicroelectronics/stm32u5xx_hal_driver/pull/7
Thank you again for your contribution. We are looking forward to reading from you again.
With regards,

Thanks very much!  Cheers!


Americanize "favourite"

The names of favorite-related methods should be changed to reflect how they are spelled in the Twitter API.

Sorry for the merge and revert; I'm still a git noob

Thanks for the PR, this will now be merged.


Update basilisk_crowdloan.md

Hi again!
It is second page.
Regards,
R.
p.s: if you want some pages to be translated before the others, please give me know (links) which ones you would prefer to see translated ASAP.

outdated / irrelevant


M3-2007 Update inline tag error

To reproduce:

Navigate to LinodesDetail page
Create Tag
Attempt to create tag with the same name
Observe misaligned error message

Error for tags should now be vertically aligned, along with improved styling for dark theme.

Coverage remained the same at 32.73% when pulling 8e84e620becf8000a4df71ae6573d75e86854047 on WilkinsKa1:M3-2007 into 327454a9fac2450d7e851c4de3389bf932ba2ae6 on linode:develop.

Mine don't quite match your screenshots, think it might be the shorter error message

The error still seems to be overlapping the text field. IMO, it should be off to the right, since the user can still type into that field after the error appears

@Jskobos and @martinmckenna thanks for reviewing! I made adjustments to address both your callouts- after talking with @alioso we'll display the error above the select so user can still interact but we don't get any layout jumps if on a smaller screen/have a lot of tags.


Fast incoming trade offers don't get served and disappear.

I was playing around with SteamBot when i encountered this bug.
When i send 5 consecutive trade offers from my account to Bot's account as fast as i can, every time either one or two offers don't get served. The funny thing is that the offers are still active on my account and are awaiting acceptance. But when i log to Bot's account from a browser, there are no active trades. I downloaded a fresh copy of SteamBot, just to be sure that it isn't a problem with my custom code and the bug still occurs.

If i do it when Bot isn't running, they all arrive as normal.
If i send another trade offer to the Bot, the stuck one(s) get somehow unstuck and are then sent as normal and notifications appear.
If i send the offers more slowly one after another, everything goes smooth.
It seems that it only happens when the Bot is going to accept these offers. If they are to be declined, there is no problem

Hope it only happens when offers are sent from the same user, i can't really test it with multiple users.
Regards

This is a Steam bug.
I ran into this issue over 7 months ago: https://gist.github.com/scholtzm/8af1cc037caede283a1c


Re-add linter, get standardrb to pass again

Summary
We want to use a  linter to help minimize surprises when submitting PRs and reviewing them
Things to Consider
@abachman started a PR, #168, that looks like what we want, but our branching/merging churn was very heavy at the time so he decided to postpone
His follow-up, #170, shows where in the pipeline you need to remove comments to enable linting again
Criteria for Completion

[ ] A linter that checks for standardrb compliance runs
[ ] The linter will flunk non-standard code
[ ] The linter adds a green check to PRs that pass the standard
[ ] The PR enabling the linter passes the standard

can I work on this

@Naraveni Go for it! I look forward to seeing your PR


flush runs

See the below situation: step 3 cannot run because step 2 failed
Question: why does step 2 block step 3, there is no dependency between them
Feature request: allow to flush a run, or provide a way to remove the cancel a scheduled action, in this case the action to uninstall a vdcuser service, as defined in a separate blueprint

node.ovc references a vdc that references a uservdc service. In 8.2.0 you have delete runs from database option.
@zaibon I was told you are working on a way to unschedule action

Should not be an issue with the new run model: https://github.com/Jumpscale/jumpscale_core8/issues/839


Fix HtmlEditor testcafe CI checks after the devextreme repo update.

Changed the build command for the devextreme package.

 Fix the quill html-editor testcafe CI after the devextreme repo update.


Send some events when calls finish

Fixes #178
Opening this up just to bring some code to the table. Last year something similar (but with a separate event type for each call) worked well for me.
This is based on #53, but adds more feedback for bevy_jornet users.

Thanks!


⚠ Mobitopup has degraded performance

In 5d5998a, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 7129 ms

Resolved: Mobitopup performance has improved in c5250fe.


Bug Report: downscroll arrows reversed

If you are playing a downloaded version of the game, what operating system are you using?
Windows (x86), Windows (x86_64), Linux, or macOS? Specify below.
I am on Windows 10 64bit
What version of the game are you using? Look in the bottom left corner of the main menu.
<IP_ADDRESS> FNF, 1.3.1 Kade Engine
Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.
Set to downscroll in Options.
The rest of the settings are as follows:
DFJK (doesn't matter which one it's on, WASD also does it)
New Input
Accuracy On
Song Position Off
Eterna Mode Off
Please describe your issue. Provide extensive detail and images if possible.

The Up and Down arrows are reversed when downscroll is enabled. I did confirm that upscroll works as expected.

Did you download the latest 1.3.1-KE version? If yes, try the latest Nightly build, this has already been fixed.

I didn't see the Nightly build, thank you so much!


Draft proposal for join command

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

https://github.com/kubermatic/kubeone/issues/816

As discussed offline, we will go with Static Workers #834 instead of this.


Compatibility issues with ZF3

Hello everyone.
I'm currently running through the process of migrating my ZF2 application to ZF3. I got stuck in a nasty issue which I cannot get around.
Essentially, when Memcached is called for the first time during the application bootstrap phase, the extension throws a response error code (@see http://php.net/manual/en/memcached.getresultcode.php) RES_HOST_LOOKUP_FAILURE.
However, if I simply try to create a server and connect, set and get a key via php -a, I'm able to do it. Do we have support for ZF3 here? Or for Memcached?

@drgomesp zend-cache should be fully compatible with zend-eventmanager, zend-servicemanager and zend-stdlib since version 2.6.1.
RES_HOST_LOOKUP_FAILURE means that the DNS lookup failed. Please recheck your host setup and debug what values gets used here: https://github.com/zendframework/zend-cache/blob/master/src/Storage/Adapter/MemcachedResourceManager.php#L163 and report back if you thing zend-cache does something wrong incl. your configuration and findings.
Thanks

Duplicate of zendframework/zendframework#7742
Issue spawns from doctrine caching, apparently.
Closing here, as it's cross-posted.


Fix ngoptions selected

wip

Can you review this? Atm, the test would pass with jqlite without the patch, but it would fail in jquery. I think we can handle the jqlite at a later point, as the issue is quite low impact anyway.

LGTM


Suggestions for "Build your first analyzer and code fix" tutorial

In this section, this sentence has an extra "of" word:

A Microsoft.CodeAnalysis.SemanticModel represents of all semantic information in a single source file.

I think the code examples should declare variables with the explicit type instead of var (basically, apply IDE10008. It would make it easier to understand what a method is returning, instead of having to guess.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6e3fc905-7aa1-7f5e-9bfe-fbcef461ad5e
Version Independent ID: a286e20b-1e43-dc57-e0fb-5a9dee7ec3f6
Content: Tutorial: Write your first analyzer and code fix
Content Source: docs/csharp/roslyn-sdk/tutorials/how-to-write-csharp-analyzer-code-fix.md
Product: dotnet-csharp
Technology: csharp-roslyn
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for writing this @carlossanlop
I'll address it when I next update this article.

@carlossanlop I have addressed this while updating the article and the sample. The only occurrences that I left using var are existing from the template :(
The template in roslyn-sdk repository will need this to get updated first.

Fixed in #23066


Update HttpClient Dependencies

What is this PR for?
HttpClient dependencies of the stack needs to be addressed as below (due to end of life of commons-httpclient and security issues)
1] Need to identify all components that are still using commons-httpclient. This is already end-of-lived by apache and consumers need to move to HttpComponents.HttpClient 4.3.6 or later
2] All consumers of HttpComponents.HttpClient needs to be on at least 4.3.6
What type of PR is it?
[Improvement]
Todos

[x] - migrate all commons-httpclient to org.apache.httpcomponents

What is the Jira issue?

ZEPPELIN-860

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

CI is green, ready for review.

LGTM

Merging this if no more discussion.


unresolved import help: a similar path exists: 'stm32_metapac::usb'

im trying to build a project for stm32l432kc but it gives the error in title when compiling embassy-stm32
im using the following code:
`
#![no_std]
#![no_main]
#![feature(type_alias_impl_trait)]
use embassy_executor::Spawner;
use embassy_stm32;
use panic_probe as _;
use defmt_rtt as _;
#[embassy_executor::task]
async fn blinker() {
loop { }
}
#[embassy_executor::main]
async fn main(spawner: Spawner) {
}
`
In Cargo.toml i have the following code. The statement for 457vg will build, but the 432kc will not.
[dependencies]
embassy-executor = { version = "0.1.0", path = "../embassy/embassy-executor", features = ["nightly"] }
embassy-stm32 = { version = "0.1.0",  path = "../embassy/embassy-stm32", features = ["stm32l475vg"]  }
embassy-stm32 = { version = "0.1.0",  path = "../embassy/embassy-stm32", features = [ "stm32l432kc"]  }
defmt-rtt = "0.3"
cortex-m = { version = "0.7.6", features = ["critical-section-single-core"] }
cortex-m-rt = "0.7.0"
panic-probe = { version = "0.3" }

make sure to git submodule update inside the embassy repo.


Cargo by default saves credentials to .cargo/credentials.toml

What does this PR try to resolve?
Cargo team discussed this in the triage meeting and agree that it has been long enough to write to .cargo/credentials.toml by default.
Fixes #11509.
cc rust-lang/crates.io#5730 rust-lang/crates.io#5732
How should we test and review this PR?
Integration tests included.
Additional information
We also talked about theoretically dropping the support of the old credentials for any new features. That might “force” people to migrate, though doing that has low benefits.

Fixed. Thank you for the review!

Thanks!
@bors r+

:pushpin: Commit cff549ba3831788fed723d0d021f12504934f9c1 has been approved by ehuss
It is now in the queue for this repository.

:hourglass: Testing commit cff549ba3831788fed723d0d021f12504934f9c1 with merge 8c5cae1843a1dfe127f78ee2ba1fc21d6f04fa81...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 8c5cae1843a1dfe127f78ee2ba1fc21d6f04fa81 to master...


Fix bower version issue

Bower version issue will be fixed with the next release.

Fixed in 2.5.0


How do I load pictures on the FTP server?

How do I load pictures on the FTP server?

It's not supported.

It's not supported.


Remove all umbrella libs from project templates as they are unreliable

See #487
Not only are they a moving target, the umbrella libs in the forthcoming SDK are actually broken. Best to avoid them entirely. Fortunately, C++/WinRT does not depend on any functions offered only through umbrella libs and only requires ole32.lib and oleaut32.lib beyond the default libs that the Visual C++ includes. ole32.lib itself is only required for Visual Studio debugger support.
May want to consider inlining IIDFromString as it is only used by NATVIS and that would avoid the extra link dependency for Visual Studio builds.
https://gist.github.com/kennykerr/6c948882de395c25b3218ad8d4daf362

Still not fixed as the OS build doesn't like ole32.lib...

May just remove all externs from C++/WinRT. A few are already loaded dynamically. We can do that for the rest and then only need a lib for LoadLibrary/GetProcAddress.

Feel free to reopen if there's interest in exploring this further.


Create ER Diagramm

There is currently no ER Diagramm for the Database.
We need to define the relations between user, company, garden, bed etc..
Especially for the permission system proposed in the User Stories 2 we need a clean DB design.


Implement manual ordinance file upload

The page and the API route is already created - but not working yet - feel free to scratch everything that's been done already and create your own route. This is critical, as many cities still don't have ordinance uploaded in the official registry (but you can find the file on their web).

Fixed in cce0618ed2156a2e3df88c6fc74b525b20c18b51


Is This Project Still Active?

Hi, I started writing a Loupedeck plugin from scratch for the PMDG variant and came across this.
I am wondering if this project is still active, I see this PR #247  (which in my view is a good refactor). But hasn't been merged.
Is this still active?.
(BTW, thank you for this project. Worked well for GA planes!)

Hi,
It is not heavely active but I follow all comments. I have time this weekend to work on it so I will merge the PR


Router fails to configure when several services use the same port but different protocol (HTTP and HTTPS)

Is there an existing issue for this?

[X] I have searched the existing issues

Run a Diagnostic and Paste Link Here
When I've configured the same port number on different projects with different protocols (HTTP and HTTPS), the router restarts without errors, but starts to show "503: No ddev back-end site available" errors on the projects URLs (80 and 443 ports too).
Expected Behavior
I guess that this is not possible to make this work well, but it's better to throw some error with the explanation than just restarting without errors.
Actual Behavior
The ddev-router stops working well.
Steps To Reproduce

Configure a port, eg 3000 on one project to use HTTPS protocol:

    environment:
      - VIRTUAL_HOST=$DDEV_HOSTNAME
      - HTTPS_EXPOSE=3000:3000

Configure the same port on another project to use HTTP protocol:

    environment:
      - VIRTUAL_HOST=$DDEV_HOSTNAME
      - HTTP_EXPOSE=3000:3000

Restart projects - they should restart without any errors.
Try to open that port, or even web interface ports (80, 443) of that projects - you will see the "503: No ddev back-end site available" errors.

Anything else?
No response

Hi @MurzNN
I believe you need to set both HTTP_EXPOSE and HTTPS_EXPOSE for this to work.
See ddev/ddev-browsersync's docker-compose.browsersync.yaml for an example of exposing port 3000.
Note, the addon is only interested in sharing over HTTPS but we used a "fake" port for HTTP to keep DDEV happy.

See ddev/ddev-browsersync's docker-compose.browsersync.yaml for an example of exposing port 3000.

@tyler36 But they're using different ports for HTTP (3001)  and HTTPS (3000), isn't it?
      - HTTP_EXPOSE=...,3001:3000
      - HTTPS_EXPOSE=...,3000:3000

Due to a quirk in the (old) ddev-router, you have to have HTTP_EXPOSE for HTTPS_EXPOSE to work.
But please test using the upcoming traefik router, which will be the default in v1.22.0.

Due to a quirk in the (old) ddev-router, you have to have HTTP_EXPOSE for HTTPS_EXPOSE to work.

Thanks, but still using different port numbers like 3001 (shim) for HTTP and 3000 (desired) for HTTPS?

People do this everywhere. If the hostname is different for the two projects, it should work. You can easily test it with one of the many add-ons available. Set them up in two projects, they'll work.
However, if you have a ports statement in either of your projects, that will mess everything up; you need expose, not ports.
If you want to go forward with this, please create a demonstration repo. It can be a trivial repo based on just a simple PHP file. And add your docker-compose.demo.yaml to it. Then run it in two different projects.
DDEV itself does exactly this all the time, has http and https ports all on 80 and 443, and as you know you can run many DDEV projects at the same time.

If you're saying that you want one project or service to be able to expose port 3000 via HTTP_EXPOSE as HTTP and another project or service to expose port 3000 the same router port via HTTPS_EXPOSE, no, it could never work.

I don't think what you want is possible if I understand it right. You can't serve both HTTP and HTTPS on the same port. Happy to continue the conversation here or elsewhere.

You can't serve both HTTP and HTTPS on the same port.

I know, but I'm talking about different projects that unintentionally reuse the same port.
For example, Grafana uses by default the 3000 port, and it's better to use HTTPS to get rid of warnings in browsers when submitting forms with passwords.
But many React apps by default use 3000 port, and pretty often without HTTPS.
So, if someone starts a ddev project "my-react-app" that uses HTTP_EXPOSE=3000:3000  - it will start ok and works well at http://my-react-app.ddev.site:3000/
But then when they try to start another project "not-my-react-app" that uses HTTPS_EXPOSE=3000:3000  (with keeping "my-react-app" running) - it will start successfully, but with broken routing with the error: "503: No ddev back-end site available" at the url https://not-my-react-app.ddev.site:3000/
So, my suggestion is to check these conflicts and display an error or at least a warning on startup.

And the same when the single project tries to configure both on the same port like this:
      - HTTP_EXPOSE=3000:3000
      - HTTPS_EXPOSE=3000:3000

because now it start without any errors.

Hi @MurzNN - What you're doing could never work, because you're using https and http on port 3000.  The router can't serve both HTTP and HTTPS on the same port.
That's the same answer I've given several times. You have to use different router ports for http and https.

Hi @MurzNN - What you're doing could never work, because you're using https and http on port 3000. The router can't serve both HTTP and HTTPS on the same port.
That's the same answer I've given several times. You have to use different router ports for http and https.

I totally understand that this will not work, and don't ask to make this work.
I'm asking only to throw an error or a warning, if the such broken configuration is detected on a project startup process!
And this improvement is mostly not for me, but for all other users to eliminate the time to find the source of the problem, because I spent a lot of time when first time tried to find the source of the "503: No ddev back-end site available" error!
So, to get into this trouble, the user can just clone two different projects, that reuse the same port (eg 3000) with different schemes (HTTP and HTTPS) and start them, and as result - will get just the 503 error and no clue how to fix it.
So, the warning will be much helpful!

Sorry, I didn't realize you were just asking for an error. Unfortunately, this all happens at a very low level. If DDEV were to try to figure out all the things you could do wrong in a docker-compose.*.yaml it would be pretty interesting. docker-compose.*.yaml is definitely an advanced use case.
One thing we could do is tell people "Please, please, never use port 3000". I'm not sure why every node app in the world thinks it's OK to re-use port 3000.

Thank you for the explanation, I'm not a go programmer, but have looked into the code, and seems here:
https://github.com/ddev/ddev/blob/bd1a05e258d645f699c171dc16a933ed49ddf7df/pkg/ddevapp/router.go#L263-L273
we're collecting all http and https ports, right?
So, maybe add here a check for intersections (at least the same port for HTTP and HTTPS inside a single project) and throw an error?
And, if it possible, collect port numbers for all running projects and do the intersections check too.

With the ddev 1.22 release and Traefic - seems the issue is resolved, now I can configure HTTP and HTTPS for the same port! Example with sharing port 3000:
    labels:
      com.ddev.site-name: ${DDEV_SITENAME}
      com.ddev.approot: ${DDEV_APPROOT}
    environment:
      - VIRTUAL_HOST=$DDEV_HOSTNAME
      - HTTP_EXPOSE=3000:3000
      - HTTPS_EXPOSE=3000:3000

I didn't believe too ;) But it somehow works!!! At the same time - HTTP and HTTPS opens well! Seems some Traefik magic here! Here is a proof:

I tested this with ddev/ddev-phpmyadmin and I confirm your results, at least with Chrome/macOS and curl. I don't think it's a very good idea though. It must be something super special about Traefik, but I found nothing with the searches I tried.
But what are you going to do if somebody's not using traefik? How will they understand the breakage? Maybe you have to add something to your install.yaml that tests to see if they're using traefik?


Add a DEVELOPING.md file to document the development process

GitHub automatically shows the contents of CONTRIBUTING.md to both bug reporters and potential contributors, so we should have a separate document to explain the development workflow.
Possible items to cover:

Setting up a development environment
Coding style (see #805)
Branching and git workflow for this project
How to test changes locally

Got my vote :)
We might need to go in depth in how to set up a Ruby environment and such or maybe recommend a docker container for development purposes (although that means setting up docker, replacing one setup with another). The "problem" is that there are also quite a few non-ruby developers using backup as their backup tool, and a guide to help them setup a dev environment would be very helpful.
I'm working on #805 in #814
The git branching process is quite simple right now. We merge everything on master and use feature branches and PRs to merge changes. But we might want to follow semver better than we do now by incorporating it in our branch setup. and use master for patch releases and develop for minor/major releases.

I'm currently thinking that I'd like to get something in place for #807, and then come back to this.
If you don't already know Ruby then setting up a Ruby development environment is probably challenging, since the tools are scattered (chruby/rbenv/rvm, Bundler, RubyGems, plus native dependencies). Once we use containers for testing, then I'd be interested in seeing if we can get a usable (and probably optional) container-ized development environment.

I'm currently thinking that I'd like to get something in place for #807

Okay 👍


Add error variant and validation design to NativeSelect when it is a required field

Hello,
we need to show validation error with NativeSelect, when NativeSelect is required field.
Could NativeSelect incorporate error variant and helpertext design as Textfield validation errors?

Yes the NativeSelect should probably have the same error variants as autocomplete


[BUG] opensearch_channel_configuration config_id field change detected in TF plans

What is the bug?
Persistent Terraform plan change detected with field config_id
How can one reproduce the bug?

Create a new opensearch_channel_configuration resource

resource "opensearch_channel_configuration" "escalations" {
  body = <<EOF
{
  "config": {
    "name": "name",
    "description": "description",
    "config_type": "slack",
    "is_enabled": true,
    "slack": {
      "url": "${var.slack_escalations_channel_webhook}"
    }
  }
}
EOF
}

Plan and apply
Then trigger a new plan
Bug: The plan will try to remove the config_id field (That was added  by OpenSearch dashboard)

What is the expected behavior?
No changes detected in plan
What is your host/environment?
Operating system, version.
Do you have any screenshots?

Screenshot of TF cloud UI showing diff

Do you have any additional context?
Add any other context about the problem.

@prudhvigodithi yes Im on the latest version.

Hi @prudhvigodithi, can you assign this issue to me?

Thanks assigned to your @afrodidact.

Thanks!

I’ve implemented a fix for this in the pull request here.


blender: Build with Draco support

See https://github.com/NixOS/nixpkgs/issues/217921
Blender sets WITH_DRACO=OFF if WITH_PYTHON_INSTALL=OFF, however that’s not totally necessary. Removing that forced-set then builds with WITH_DRACO=ON, however Blender fails to launch because this creates e.g. share/blender/3.6/python, and Blender then sets this as Python’s home dir, so Python fails to init since it expects Python core to be there (and it’s not). I couldn’t figure out how Blender sets Python’s home dir, and explicitly setting PYTHONHOME in the env didn’t have any effect. So instead just rename that dir to python-ext to avoid this behavior. All that is left then is to adjust where Blender is looking for the Draco lib.
This functionality may be verified by:

Visiting File → Export → glTF 2.0
In the right side panel (press the gear icon in top-right if not visible), expanding “Data”
Enabling “Compression”
Press “Export glTF 2.0”
Verifying no error or warning message and exported file exists

Description of changes

Things done
Have verified functionality as described in the commit message.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks for looking into this! I'll give it a spin later in the evening.
Another option would be to leave draco out of the build like before and patch the extension to point to the nix store path of the standalone draco package. I believe from a Nixpkgs perspective this would be preferred, too. The main question is how stable the API/ABI of draco is...

1.5.6 and 1.5.2 should be trivially compatible so dropping blender's patch (looks like it only silences some warnings) and modifying the CMakeLists.txt to link the prebuilt version instead would be an interesting option to try. But if that doesn't work ootb then whatever.


Added key as text feature

This feature if keyAsText is set to trueon configuration, translations keys will work also as value for this translation.
You can see an example on test/fixtures/index_key_as_text.html and master/test/expected/11_en_US.json.

I need that option, is very usefull and is very similar to how works i18n translation in node with EJS.
Here is possible to see how it works,
http://www.drzon.net/i18n-for-node-express/

+1
Me too. I would like to see this feature merged to the master. Hope it happens.


Changing theme of the website based on the weather

solved the issue #4

Hi there . I will like to take up this issue.

@sumana2001 What lock file is accepted for the project? package-lock.json or yarn.lock or both?

Only yarn.lock should be used but in case someone has used npm tu run and package-lock is generated then make sure it is not committed

hey, I think I solved all conflicts but the file is still not merged


MethodDataSource doesn't interact well with other attributes

Hello,
I'm trying to migrate our tests from xUnit to TUnit, and I'm fiddling with MethodDataSource to async initialize some test context.
Right now, I'm stubbling upon a Matrix test, so naturally I tried to do the following:
    [Test]
    [MethodDataSource(nameof(CreateTestContext))]
    public async Task MyTest(MyTestContext ctx,
            [Matrix(MyEnum.Val1, MyEnum.Val2)] MyEnum firstVal,
            [Matrix(MyEnum.Val1, MyEnum.Val2)] MyEnum secondVal) {
    }

But the compiler screams There is no argument given that corresponds to the required parameter [...].
The workaround is to write a different CreateTestContext and unroll the Matrix myself, which is a bit painful.
Isn't there a way to combine both MethodDataSource and attributes like Matrix or Arguments?
I'm no C# wizard by any stretch of the imagination, so there surely are language constraints that I'm unaware of.

E.g:
public class MyGenerator : DataSourceGeneratorAttribute<MyTestContext, MyEnum, MyEnum>
{
    public override IEnumerable<(string, string, string)> GenerateDataSources(DataGeneratorMetadata dataGeneratorMetadata)
    {
        foreach (var myEnum1 in Enum.GetValues<MyEnum>())
        {
            foreach (var myEnum2 in Enum.GetValues<MyEnum>())
            {
                yield return (MyClass.CreateTestContext(), myEnum1, myEnum2);
            }
        }
    }
}


Equinix Metal: Initial machine deployment creation fails

What happened?
When bootstrapping a new cluster with KubeOne on Equinix Metal, sometimes the initial machine deployment creation gets stuck with:
admission webhook "machinedeployments.machine-controller.kubermatic.io" denied the request: validation failed: failed to list metros: Get "https://api.equinix.com/metal/v1/locations/metros": remote error: tls: handshake failure

We consider it a transient error since it happens randomly. We need to investigate a bit why this is happening and if there are any possible workarounds for this.

How to reproduce the issue?

Just create a cluster on Equinix Metal with initial_machinedeployment_replicas set to >0.
What KubeOne version are you using?

Reproducible with Kubeone 1.5.x and 1.6.x.

/remove-lifecycle stale

Recent e2e install tests worked


change some translations for locale_zh

Some translations in Chinese seems much strange and I fixed some of them.
And also my respect for your work.

Thank you @alfred-zhong!
I'm going to add the immutable flag to these lines so they are preserved during automatic translation.

@alfred-zhong Can I include your name in the supporters section?   I very much appreciate your contribution.

@mayfield Sure. My pleasure.


Update webpack deps

Changes

Updates webpack and webpack-stream to latest.

Testing

./frontend.sh should pass.

looks, good and build appeared to run a little faster.


Make missing app-id annotation have a clearer log message

If a Dapr k8s deployment is missing an dapr.io/app-id annotation or uses the deprecated dapr.io/id annotation, the logs only show the k8s string parsing error:
Error creating: admission webhook "sidecar-injector.dapr.io" denied the request: invalid app id: a lowercase RFC 1123 label must cons  ist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for val  idation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')
Instead, the sidecar injector should fail the admission request and log a proper error message.

error message from code below.
https://github.com/dapr/dapr/blob/445972d1c3ca69ad34b7039fd6ca7b5d7c1dd6aa/pkg/validation/validation.go#L26

I'm on it.
I'll add check app-id string len is 0 or not and add error message.


Streams which default to "720p60 - Source" do not work

Description
GUI fails when attempting to open a live stream for which the highest available quality is 720p60 - Source
Expected / Actual behavior
Should initialize stream
Reproduction steps

attempt to watch twitch.tv/dreamleague
gui fails

Environment details
linux x64
Comments
leaving the 'stream info box' open on all failures would help to diagnose further for the end-user

see #323

ah, okay, I'll close this then


Added new game - Go fish

PR Description 📜
This PR adds the card game Go-fish.
Fixes #4411
Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

![Uploading Screenshot 2024-06-10 at 7.52.29 PM.png…]()

Thank you @tanyagupta01 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ishita-43 I have made the changes that you asked for.  Kindly check them and please also assign level to this PR.

@ishita-43 @kunjgit kindly review this PR.

@ishita-43 Done. Kindly review.

@ishita-43 if you find it suitable, kindly give me a higher level on this PR as you have given to the other games according to the complexity and individuality of it.

@tanyagupta01  resolve merge conflicts

@kunjgit Done. Kindly review and merge.

@ishita-43 if you find it suitable, kindly give me a higher level on this PR as you have given to the other games according to the complexity and individuality of it.

We appreciate your hard work but Lots of card games are already present in the repo thats why we placed this as an enhancement of the repo

@ishita-43 if you find it suitable, kindly give me a higher level on this PR as you have given to the other games according to the complexity and individuality of it.

We appreciate your hard work but Lots of card games are already present in the repo thats why we placed this as an enhancement of the repo

Oh okay. Thanks . Please merge if everything else is fine.

@ishita-43 if you find it suitable, kindly give me a higher level on this PR as you have given to the other games according to the complexity and individuality of it.

We appreciate your hard work but Lots of card games are already present in the repo thats why we placed this as an enhancement of the repo

Oh okay. Thanks . Please merge if everything else is fine.

Will soon be merged by the Admin.

Thank you  @tanyagupta01 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Bitmap text when fonts may not be embedded

I'm going to save a docx to pdf file:
doc = word.Documents.Open(input_file)
doc.SaveAs(output_file, FileFormat=17)
If a do the same action by simple using the "File > SaveAs > .pdf" on Microsoft Word i actually have to remove the flag "Bitmap text when fonts may not be embedded" (inside the pdf format option) in order to generate a text-searchable pdf file (See attached image).

Is there a way to do the same operation (removing the flag) by python-docx?

No, not currently.


Shopiiing Cart should be added - CartLine

As far I have checked the SellingPlanAllocation  is not available in Checkout and the CheckoutLineItem
You should must add shopping cart module as the CartLine includes the SellingPlanAllocation

same issue,bro.

I have no plan to add the new feature as I am already fully occupied.
You are free to create a PR

The Shopping cart module has been added in v2.1.0 but SellingPlanAllocation is yet to be added. It will be added soon.

Is there any update to SellingPlanAllocation

Brother is there any update about SellingPlanAllocation its important and please add it ASAP
Thank you for your cooporation.

Apologies.
Too stuck up in my tasks. Haven't got the chance yet


Fix sharing bug that would prevent the display of tags

The wagtail_hooks.py file deletes the latest revision and creates a new one. It's not known why a new revision would lose the tag references, but modifying the latest instead of deleting it and creating a new one seems like a better choice anyway.
Changes

sharing a page now modifies the wagtail created revision instead of deleting it and creating a new one

Testing

Create, save, share, publish a page with tags.
Verify that the tags are saved at each step.

Review

@kave

:+1: make sense


How to explain a scikit-learn model?

Can I write on this?

@Bennykillua yes of course, welcome!
My colleague @luca-martial will be available to help.

@Bennykillua feel free to join our community writing program here: https://www.giskard.ai/write-for-the-community

Thanks @alexcombessie and @luca-martial . I just applied.
I guess I can only start writing after I have receive the conformation email from you team?


attachGestureHandler called with a null viewTag – problem with React 16.3

Haven't verified it 100% but I think I was getting error that native method attachGestureHandler gets called with a null viewTag.
I believe the root cause could be that in React 16.3 the order of calling didMount and ref handler changed and so this._viewNode is now empty in componentDidMount which causes the aforementioned attachGestureHandler call.
Can you verify this @osdnk and think of some fix for it?

Have just updated locally project with React 16.3 and put some hook on every RNGestureHandlerModule.attachGestureHandler. It seems to be perfectly mind.
How did you observe it? Would you mind giving me some details?

Could've been some weird setup issue my side. Closing