Cognito redirect URI restriction

When working with Cognito OAuth, the Amplify CLI forces you to use a trailing slash in the redirect URI.
For example, if I try to use:
__http://localhost:3000/profile__
The CLI gives me this error message:
The value must be a valid URI with a trailing forward slash. HTTPS must be used
instead of HTTP unless you are using localhost.

It forces you to use a URI that looks something like this: __http://localhost:3000/profile/__ (notice the trailing slash)
The problem is that, when using the trailing slash, the client does not authenticate the user upon redirect.
The only way to fix this is to wait for the deployment to complete, then manually update the local configuration in aws-exports.js and also manually update the redirect uri in the cognito dashboard.
I've recorded a video of the issue and uploaded it here
Notes:

The root domain does work, i.e. if I set it to be just __http://localhost:3000/__ it works fine, only when adding a path does it fail.
The code I'm using to sign the user in is this: Auth.federatedSignIn({ provider: "Google" })

Mitigation suggestion: Disable the CLI check that tries to ensure there is a trailing slash. If this was disabled, there would be no issue for me. It would be nice if the Cognito service would parse the URL properly though (or maybe this is something to do with the Amplify Client libraries?)  but for now this would be a good way to mitigate.

Discussed with @undefobj offline. We need to brainstorm and come with a better DX in the CLI to come up with a warning or a workaround.
Just FYI, Cognito service has a limitation around the usage of "trailing slashes" for URL's and hence the CLI enforces it.

Discussed with @undefobj offline. We need to brainstorm and come with a better DX in the CLI to come up with a warning or a workaround.
Just FYI, Cognito service has a limitation around the usage of "trailing slashes" for URL's and hence the CLI enforces it.

Update here: It looks like since I was using Next.js, there is a way to configure the trailing slash to make this work. There is a good blog post here that I will post:
https://creativedesignsguru.com/next-js-aws-amplify-cognito-oauth/
Using this configuration, everything works properly. I will go ahead and close this issue since I opened it and it seems like there is a simple workaround built into the framework. This works fine on other frameworks out of the box from what I can tell.
Thanks for everyone's guidance here.


Add EverDrive Save and CIC support

See title.
Recommended resources:
https://github.com/N64-tools/ED64/blob/develop/docs/rom_config_database.md)
https://github.com/N64-tools/ED64/tree/develop/usb64/usb64

The ED uses an UltraCIC, no way to manually change the CIC through USB according to the KRIKzz source code.

Added in 247d0fe, needs testing...
Also needs filename support.

Very close, 08c07ad got EEPROM working. SRAM still needs testing...

ED save filenames are fixed in e6aad80. SRAM not working for unknown reasons, KIRKzz is investigating.

Turns out this was working all a long and might just be a padding issue on the ED's side. :weary:
Closing.


Bugfix: rename "cache_version" parameter to "cv"

The package was using cache_version as the parameter name to specify the cache version to use within requests, however the name of this parameter should be cv according to the documentation.
I've tested the requests with cache_version, which is not working and with cv which is working.
This PR also introduces a new constant, so that future changes only need to happen in one location.

I did some extra testing and it seems that cache_version is working as well.


Handle EmptyResultDataAccessException

Description
When attempting to delete an entity which has already been deleted, or simply does not exist, an EmptyResultDataAccessException is thrown.  Handle this exception gracefully to ensure the REST service client receives a consistent response.
Sample
org.springframework.dao.EmptyResultDataAccessException: No class com.leanstacks.ws.model.Greeting entity with id 1 exists!
	at org.springframework.data.jpa.repository.support.SimpleJpaRepository.delete(SimpleJpaRepository.java:154) ~[spring-data-jpa-1.11.0.RELEASE.jar!/:na]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_102]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_102]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_102]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_102]
...

Added @ExceptionHandler to BaseController for this type of Exception. Return HTTP 404 with empty response body.  Chose status code 404 over 410 because we do not know if the specific resource is temporarily or permanently unavailable. Also, from a security perspective, 404 is preferred because it obfuscates the disposition of the resource.
See HTTP Status Codes for additional reference.

The above  not enough to solve my problem, how do you do it？

SimpleJpaRepository source of the delete () method, add @Transactional,  delete the data that does not exist will throws Exception


Managed node group limits to 1 instance type (TF resource allows multiple)

I have issues
I'm submitting a...

[x] bug report
[ ] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
The new managed node groups addition only allows specifying a single instance type, whereas
the underlying terraform resource accepts a list of instance types so this seems needlessly limiting and inconsistent.
Are you able to fix this problem and submit a PR? Link here if you have already.
My suggestion is to replace this:
instance_types  = [lookup(each.value, "instance_type", null)]

with:
instance_types  = lookup(each.value, "instance_types", [])

This changes the expected key in node_groups but as that isn't released yet that seems acceptable.
I'll add a PR shortly.
Any other relevant info
Originally reported in #620

Gave it a try. Ran into TF errors resulting in: https://github.com/terraform-providers/terraform-provider-aws/issues/11414
(Reading back on #602 I surprisingly can't find any mention of the instance_type/instance_types discrepancy. All in all, with also some quirks in the provider, managed nodes atm feels like a minefield with a lot of trial-and-error. Besides the examples already present I plan to add a /docs/managed_nodes.md page in #644)

This is a fairly typical trick from Terraform AWS documentation. If you write it vague then you won't be out of date when AWS moves the goal posts 😄 . Highly frustrating from a user point of view where you often have to guess if the provider wants a list or string.
The upstream API takes a list and specifies in the documentation that currently only a single option is supported. Which explains the provider's choice.
Although the provider does enforce the max 1 item 🤷♂
Short term usability would support going with the singular. No telling how long it will take before AWS supports multiple, or even how that would look.


Question about seed and the number of GPUs when you train

Hi,
Thanks for your great efforts.
Currently, I reproduce the results that you shared in this repo.
But, when I followed the recipes that you announced, the loss and accuracy is not exactly followed with your released logs.
Even if utilized with the same seed, the loss could be different.
and, in my case, I currently use a single GPU(RTX3090).
I just want to know how many GPUs are used when you trained the models.
Thank you.

We use single V100 for training.
From my personal experience, it is impossible for us to reproduce exactly the same results. Hardware and software differences can have an impact on the results. It is okay if the results are slightly different.


WIP: support self hosted etcd recovery

Is this superseded by #528?

closing this in favor of #528


Not using cached files

PDF.js keep fetching/requesting the file even if it is cached in the browser?
PDF file response headers
Access-Control-Allow-Origin: *
Cache-Control: public, max-age=31536000
Content-Encoding: gzip
Content-Length: 45378
Content-Type: application/pdf
Date: Fri, 06 Oct 2023 19:04:08 GMT
Expires: Sat, 05 Oct 2024 19:04:08 GMT
Last-Modified: Fri, 06 Oct 2023 18:54:40 GMT
Server: nginx

https://i.stack.imgur.com/dPx40.png

PDF.js keep fetching/requesting the file even if it is cached in the browser?

The PDF.js library simply requests the URL using either the Fetch API or XMLHttpRequest, and it's then up to the browser to serve a cached resource if such exists. It's unfortunately not clear what, if anything, the PDF.js library could do differently here!

When opening an issue, please provide all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md rather than removing the template.
Also, in cases such as these, please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.

When reading this you can actually force the browser to used any cached resource instead of fetching the same resource over and over again
https://rapidapi.com/guides/cache-data-fetch


Publish to crates

Last version (0.2.3) does not appear to have been published to crates.io (as per https://crates.io/crates/holochain_anchors).

Pinging @zippy and @freesig .


Parse SubjectAlternativeNames from CSR into Lemur Certificate

@castrapel I have adapted it for working with any.
Since cryptography.x509 classes do correspond to Lemur's API, the generalization is quite straightforward

Coverage increased (+0.007%) to 60.55% when pulling a98710003637c5beac0f3d3d5670f199b4c4e1c2 on jramosf:master into a865675537def161ddbffb28f7133293f839c3a9 on Netflix:master.

Javier, it would be really great, if you could also add automated testing for parsing SANs. This would make the integration easier.
Thanks

Javier, it would be really great, if you could also add automated testing for parsing SANs. This would make the integration easier.
Thanks

Hi @hosseinsh, I've added test_certificate_input_schema_parse_csr to cover the new functionality.
Since we don't supply complete dicts from the tests to API and Python dicts don't have autovivification built-in, I've changed schemas.py accordingly. I've detected this edge case from running the new test.
Regards,

This looks great! Thanks for the PR, I'll merge it. Tested by going through certificate creation flow, including CSRs, and setting breakpoints at modified code.


How to deploy on Heroku

First of all, thanks for making this great queue wrapper. It was quite easy to set up and I'm very happy with it 👍
Now for my question: I have an Adonis web app running on Heroku and would like to run a queue in a worker dyno. I can run it locally and it works great, but when I deploy to Heroku, I get the following error: Error: AdonisJS requires "@adonisjs/assembler" in order to run typescript source directly
This is my Procfile:
web: node build/server.js
worker: node ace queue:listen

I noticed when I run the build command (node ace build --production), it doesn't make a new JS file for the queue/worker. Is there some way to make it generate something I can run on Heroku, like a build/queue.js?

I got it to run with the following:
web: node build/server.js
worker: node build/ace queue:listen

But it looks like it runs the rest of the app lifecycle, since it runs the clear redis cache code that I have running on boot for the web app. Any idea how to get around this?

on pm2 just command pm2 start ace -- queue:listen


Fat jar as single dependency in example

In grobid-example you have it calling the directory with grobid-home. How can I bundle grobid home in the core jar? Is there a way to reduce the file sizes (uploading to aws lambda)

Hello!
see #245, not possible because of the JNI libs...
You can always decrease the size of GROBID home by including in a deployment only the models that you need to use - the loading of models is lazy.


Save and Save As does not work for new projects

Summary:
Save and SaveAs returns "no such file" when saving a new project.
Steps to Reproduce:

Create a new project (File->New Project)
Add a component
Save the project (File -> Save or Save As)
Prick a random location, say a new folder in downloads.
Press save

Expected results:
The project is saved.
Actual results:
No such file or directory exception is thrown. Unable to save project error is displayed in GUI.

Solved in https://github.com/DEIS-Tools/H-Uppaal/pull/50


Reveal ignores scroll in Firefox

Hi,
It seems there's a bug in Firefox where you try to read $(body).scrollTop() in HTML5 page. You get zero.
The fix is simple, get the $(document).scrollTop() instead. It only needs to be nicely merged with settings.root_element, as it's not exactly an "root element".

Sorry, what is the component you are referring to?

Just tested 5.5.2 in Firefox 40.0.3 and cannot see an issue. Can you describe what you are trying to do and what is happening? Have an example?

Looks like it was fixed in 5.5.2 and I was still using 5.5.0. Now it's checking the window.scrollTop not the root_element.scrollTop. Thanks for your answer and sorry about the fuss.


Implement ability to pin emails

Right now, when I read a message and need to return to it, I mark it as unread in K9Mail. However, this has the unfortunate effect of increasing my unread count, so that I don't know how many messages are actually unread and how many are just waiting for me to return to them.
Google Inbox solves this quite nicely: instead of "Mark as unread", it has a pin feature, which lets one pin messages to return to. It also allows showing only pinned messages and archiving all messages except for pinned messages (for "inbox zero").
Please consider replacing "Mark as unread" with pinning.

I don't think removing the ability to mark unread is a good idea. Note Google does also allow you to mark unread. However adding pinning is something we could do.
One question is how to implement pinning - whether it's purely a client thing or whether it should be synched to the server as a flag.
If the later we should consider trying to use the same flag as other clients (e.g. Google Inbox) if possible.

@philipwhiuk Google doesn't allowing marking as unread in Inbox. (It does in Gmail, but there are no pins in Gmail.) Pins are a direct replacement for Mark as unread, it doesn't make sense to have both at once.

I would like to add my voice to this old request. I use stars, but they don't work well for emails I want pinned for a long time. I have several accounts in my unified inbox (default view). Starred emails stay on top only until the unified inbox fills up. Then I have to scroll down and select 'show 25 more' over and over until I restore my starred messages. Sometimes these are for travel bookings months in advance, or bills to pay. It would be really nice to pin them to the top for as long as I want them there :)

It would be really nice to pin them to the top for as long as I want them there :)

I agree, maybe a setting to "Download and keep all pinned messages" would be possible? Already missed bills because of not being on my PC regularly and my phone swallowing pinned mails from earlier 🙄 Setting the app to synchronize all mails is not feasible for me.


Compiler To Generate Re-usable Constraints

The auto-generated constraints are not always re-usable by the end user to copy and modify. User has to write constraints from scratch even for a simple OTA circuit. The compiler should generate constraints that are applicable on the original netlist and thereby re-usable by the end user.

@kkunal1408 , can we scope the effort it takes and what the gaps are to achieve this?

After annotation, for the grouped blocks the individual block name information is not stored in the current database.
e.g. two identified groups DP(MN7, MN8), DP(MN2, MN3) create only one subcircuit hierarchy DP(MN1, MN2) if the devices are equal.  Changing the database would take lots of effort.
There are two tricks that I can think of now:

The name information is stored as a string x_MN7_MN8 which can be used to break it down. (It assumes names do not have a '_')
The pre annotation database can be stored separately and names from this can be used for matching.

We can do a brainstorming session on this to figure out the best way.

@kkunal1408 , I think the value of user-consumable constraints is significantly higher than reducing redundancy in the subcircuit hierarchy. Furthermore, such a redundancy/duplication can be identified procedurally and be simplified before calling the primitive generator if needed.

Per your example, constraints would look like:
{"constraint": "GroupBlocks", "instances": ["mn7", "mn8"], "name": "<uuid1>", "generator":{<...>}},
{"constraint": "GroupBlocks", "instances": ["mn2", "mn3"], "name": "<uuid2>", "generator":{<...>}},

Is there any other roadblock that you can think of?

No major roadblocks right now and the group block extension with generator constraint was done thinking this issue in mind. I will soon provide an update on this.
One minor roadblock is due to some name-based transformations during primitive generation (primitive/main.py) may fail in case the user changes the name. I will try to fix this with minimal disturbance but some PDK interfaces may break.

@kkunal1408 , should we start a PR to do this?

I will do it by this weekend.

Notes:
TODAY:
{
    "constraint": "GroupBlocks",
    "instances": ["mn1", "mn2"],
    "name": "<subcircuit name>",
}

After this PR:
{
    "constraint": "GroupBlocks",
    "instances": ["mn1", "mn2"],
    "name": "<instance name>",
    "template": "<subckt name>"   // Optional
}


chore(dev-environment): Add Docker Compose and script for local testing environment

Description
Add Docker Compose and a script to set up the local testing environment
Related Issues

Closes # 568

:tada: This PR is included in version 0.30.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


The env variable identifiers shouldn't include dots.

https://github.com/brocaar/loraserver-docker/blob/master/docker-compose-env.yml
For example: INTEGRATION.MQTT.AUTH.GENERIC.SERVER. This is not a valid env variable idtentifier and fails when trying use with a compose file.
It also fails with simple bash command like:
export INTEGRATION.MQTT.AUTH.GENERIC.SERVER=tcp://mosquitto:1883
bash: export: `INTEGRATION.MQTT.AUTH.GENERIC.SERVER=tcp://mosquitto:1883': not a valid identifier

You probably want to file a bug against the affected server component. I've had no issues with dotted variables in either docker-compose (including docker-compose-env.yml) or Kubernetes, but as you've noted, shells don't like it.

yes you are right I tried a different docker-compose cli version and it worked.
btw most repos still reference different env variable names.
for example
https://github.com/brocaar/lora-gateway-bridge/blob/8f8bf2c65eb1cce18962026c60e515c5b06c7f74/docker-compose.yml#L14


What about Maui?

This library was supported by Maui?

Yes this library allows can render to SkiaSharp and that supports Maui.

Is there any simple sample on how to use CSharpMath on MAUI?
Thanks.

Finally got it working. If anyone interested, here is an example on how to use it in MAUI.
https://github.com/syaifulnizamyahya/MauiSkiaCsharpMath

I have the MathView component from CSharpMath.Forms.
How can I use it in MAUI?

I am still waiting for the maui control for csharpmath. This repo is active or not?

The current documentation for SkiaSharp is: https://github.com/verybadcat/CSharpMath#2-csharpmathskiasharp
Some SkiaSharp documentation: https://learn.microsoft.com/en-us/xamarin/xamarin-forms/user-interface/graphics/skiasharp/

I am still waiting for the maui control for csharpmath. This repo is active or not?

The repo hasn't had commits or reviews in a reasonably long time. If you are interested in maintaining this repo, create a separate issue.


Nested includes and compound documents

Currently in one of our projects we have a resource that we include all of its relationships to prevent multiple api calls. One of the relationships of the parent resource also has has relationships we would like to include all in one payload. For example let's say I have bars resource that has many beers and each beer has a manufacturer.  In my payload I would like to include all the beers a bar sells and then include the manufacturers inside each beer object.  After running through the code it looks like when processing relationship resources, saule is not also processing that relationships resources recursively even if the object being serialized includes that information. I suspect this may have been due to circular references?  If this is possible and I have something setup incorrectly then let me know.  I am currently on the commute home but when I get home I can provide a code example if needed.  I believe if this isn't currently possible, the method that processes the top level resource in the serializer could be refactored to be called recursively for each included resource.  Please excuse any typos as I am typing this on a phone :(

You are exactly right. When first implementing this I decided not to add this feature for fear of infinite loops.
However I'm pretty sure Saule already checks for circular references, so this should be relatively straightforward to implement.

Hi. Is this feature available in the latest beta NuGet package (saule.<IP_ADDRESS>5-beta)? Currently running some tests and I'm not getting the nested includes. Thanks.

I just built from source and it's definitely not working. My models look like this:
namespace api.Models.Db {
    public class RefreshToken {
        [Key]
        public string Id { get; set; }
        [Required]
        [MaxLength(100)]
        public string Subject { get; set; }
        [Required]
        [MaxLength(50)]
        public string Client { get; set; }
        public DateTimeOffset Issued { get; set; }
        public DateTimeOffset Expires { get; set; }
        [Required]
        public string ProtectedTicket { get; set; }
        public virtual ConnectionSource ConnectionSource { get; set; }
    }
    public class ConnectionSource {
        [Key]
        public string Id { get; set; }
        public string OS { get; set; }
        public string UserAgent { get; set; }
        public string Device { get; set; }
        public string RemoteIp { get; set; }
    }
}

namespace api.Models.JsonApi {
    public class RefreshTokenResource : ApiResource {
        public RefreshTokenResource() {
            Attribute("Client");
            Attribute("Issued");
            Attribute("Expires");
            BelongsTo<ConnectionSourceResource>("ConnectionSource");
        }
    }
    public class ConnectionSourceResource : ApiResource {
        public ConnectionSourceResource() {
            Attribute("OS");
            Attribute("UserAgent");
            Attribute("Device");
            Attribute("RemoteIp");
        }
    }
}

What's missing here? Thanks.

So I made the changes necessary to get this working and made a pull request: #110. Also modified the HandlesRecursiveProperties test.

Hi rhyek,
i am new to github, perhaps it might not be a place to discuss, please spare me for that.
Actually i am not able to generate the output with having data in relationship section and included members. I can only see the link in the relationship section.
I had installed Saule using this command Install-Package saule as mentioned in the github, and this package does not have paging implementation either.
I have tried some of the url in the jsonapi.org like filtering the attributes, paging but none of them work.
Below is how my Resources are arranged:
public class NumberResource : ApiResource
{
    public NumberResource()
    {
        OfType("numbers");
        Attribute("Number");

        BelongsTo<ServiceNumberPlanResource>("plans");
    }
}

public class PlanResource : ApiResource
{
    public PlanResource()
    {
        OfType("plans");
        Attribute("Description");
    }

}

Din't I download the correct version or what should i do in order to download the correct version of Saule? Please help me its too urgent.

@dhirajdhakal09 the code that you have provided does not really go completely into the issue you are describing. The saule api resource definitions help the serializer know what the output of the object should look like but for them to work your model objects need to actually have nested data in them. Are you using entity framework? If so you can use the include function(https://msdn.microsoft.com/en-us/library/bb738708(v=vs.110).aspx) to retrieve a compound object and then saule should handle the output formating.  In regards to the jsonapi spec, saule(at least when I was using it) only implements some of the translation of the json api spec. If you want your web api code to support things like paging and filtering you either need to return an iqueryable back to your controller or you will need to implement that logic yourself. I may not be answering your question but I don't know that I will be able to with the information you have given.

@jrexdepew Thanks for your quick response.
Yes I am using Entity framework, ok please have a look into my models too
public class Number
{
public Guid? Id { get; set; }
public string Number {get; set; }
public Plan plan {get; set; }
}
public class Plan
{
public Guid? Id {get; set;}
public string Description {get;set;}
}
And you said regarding returning Iqueryable back, is it in the web api
controller itself like
IQuerable GetAll()
{
return new IQuerable();
}
Please let me know if I have to modify something in order to have all the
elements back.
Thanks in advance.
On Wed, Jun 1, 2016 at 8:53 AM, Justin DePew<EMAIL_ADDRESS>wrote:

@dhirajdhakal09 https://github.com/dhirajdhakal09 the code that you
have provided does not really go completely into the issue you are
describing. The saule api resource definitions help the serializer know
what the output of the object should look like but for them to work your
model objects need to actually have nested data in them. Are you using
entity framework? If so you can use the include function(
https://msdn.microsoft.com/en-us/library/bb738708(v=vs.110).aspx) to
retrieve a compound object and then saule should handle the output
formating. In regards to the jsonapi spec, saule(at least when I was using
it) only implements some of the translation of the json api spec. If you
want your web api code to support things like paging and filtering you
either need to return an iqueryable back to your controller or you will
need to implement that logic yourself. I may not be answering your question
but I don't know that I will be able to with the information you have given.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joukevandermaas/saule/issues/61#issuecomment-222881187,
or mute the thread
https://github.com/notifications/unsubscribe/ASxFneHISoZPE8SIRwFpCygepkSKMR3Lks5qHPfIgaJpZM4G6S27
.

Your controller method code that you have should allow saule to append code to it for filtering and pagination.  If you want to test what saule is doing, you can just call the linq methods directly on your IQueryable.  To implement pagination, you would normally use the IQueryable skip and take methods(https://msdn.microsoft.com/en-us/library/bb357513(v=vs.100).aspx).  If you look at the example pagination code here: https://github.com/joukevandermaas/saule/wiki/Pagination you will see that the controller returns the IQueryable generic for a type of Person.  When you decorate your controller method with the attribute Paginate, then saule will just apply a linq query using the methods skip and take to the Person queryable collection.  Saule is able to perform this because IQueryable methods are usually chainable and will return IQueryable collections.
Now for the included objects, I would suggest testing returning an object that is nested that you have self created so that you can follow the code and know what is going on.  You can use object initializers to test this with something like:
`
public IQueryable MockupGetSomeNumbers()
{
var myNumber = new Number{Id = new Guid(),
Number = "12345",
plan = new Plan{Id = new Guid(),
Description = "Some Description"}};
var someQueryableNumbers = new List();
someQueryableNumbers.Add(myNumber);
return someQueryableNumbers.AsQueryable();
}
[HttpGet]
[ReturnsResource(typeof(NumberResource))]
[Route("api/numbers"]
public IHttpActionResult GetSomeNumbers()
{
return Ok(MockupGetSomeNumbers());
}
`
After writing that out it might be better to just use a linq select to return the iqueryable to test it but I will let you figure out how you would best like to do it.  Note: no guarantees that code will compile :)
Also if your question is general it may be better to open a new issue instead of posting on this enhancement issue.  I will leave that up to @joukevandermaas .  Hope that helps!

@jrexdepew  : Thanks for your reply, ya pagination now works, in the wiki, there is a typo where it says  to use [Paginate(PerPage = 25)]  which should be [Paginated(PerPage=25)] :)
And I tried to run with the code you provided in order to return included columns, but doing that also din't help out, it is not returning included column yet.
This is what I got,
{
"data": [
{
"type": "numbers",
"id": "00000000-0000-0000-0000-000000000000",
"attributes": {
"number": "12345",
  },
  "relationships": {

    "plans": {
      "links": {
        "self": "http://localhost:58739/api/numbers/00000000-0000-0000-0000-000000000000/relationships/plans/",
        "related": "http://localhost:58739/api/numbers/00000000-0000-0000-0000-000000000000/plans/"
      }
    }
  },
  "links": {
    "self": "http://localhost:58739/api/numbers/00000000-0000-0000-0000-000000000000/"
  }
}

],
"links": {
"self": "http://localhost:58739/api/numbers"
}
}

@jrexdepew  : Thanks for your reply, ya pagination now works, in the wiki, there is a typo where it says  to use [Paginate(PerPage = 25)]  which should be [Paginated(PerPage=25)] :)
And I tried to run with the code you provided in order to return included columns, but doing that also din't help out, it is not returning included column yet.
This is what I got,
{
"data": [
{
"type": "numbers",
"id": "00000000-0000-0000-0000-000000000000",
"attributes": {
"number": "12345",
  },
  "relationships": {

    "plans": {
      "links": {
        "self": "http://localhost:58739/api/numbers/00000000-0000-0000-0000-000000000000/relationships/plans/",
        "related": "http://localhost:58739/api/numbers/00000000-0000-0000-0000-000000000000/plans/"
      }
    }
  },
  "links": {
    "self": "http://localhost:58739/api/numbers/00000000-0000-0000-0000-000000000000/"
  }
}

],
"links": {
"self": "http://localhost:58739/api/numbers"
}
}

@jrexdepew : Did you get chance to look into my earlier message in this thread? Please help me its too urgent here :(

I just published a new pre-release with this functionality. Thanks very much, @rhyek!

@joukevandermaas: No problem 👍


Fix syntax error in adapter-web client.js

Introduced in 0fa4a3247be8dd932349038cbd598d032b85aeed
Detected by LGTM

ugh! Thanks.


Hide Wi-Fi widget when disabled

Is there a way to hide the wi-fi widget when wi-fi is disabled?
If not, how would I go about adding it?
And maybe consider adding a checkbox toggle in the settings for the official release?

I added an option doing exactly that in the latest commit.

Thank you very much. Works just like I wanted. 😊


feat: add  to sitemap

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[x] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation
Add <lastmod> to sitemap, should fix https://github.com/facebook/docusaurus/issues/2604.
Test Plan
Extend existing sitemap tests to expect generated lastmod date.
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/sitemap.xml
Related issues/PRs

https://github.com/facebook/docusaurus/issues/2604

Thanks for submitting this @pmarschik ! Have you gotten any feedback on this PR?  We use Docusaurus at Unleash and were just trying to add last mod to our docs since it is becoming increasingly important for Google. Would love to see this merged.

@ardeche07 I've not gotten any feedback, however I've been using the changes for our published docusaurus page for some time. When I get around it, I'll update the PR with the latest changes (its not actually 170 files changed, this PR was based on docusaurus v2)

Thanks for your contribution @pmarschik and sorry for the late review

Thank you for reviewing the MR @slorber.

Your PR is not really in a state I could merge, and try to implement things that are not really needed according to Google recommendations.
It should also target main and not docusaurus-v3 branch

I'm aware, this is just what I use to pnpm patch our build and have a working lastmod until the feature is available upstream.

Let me know if you want to give it another try, otherwise I'll create another PR.

I'm currently occupied with other projects and I don't know when I next have time to circle back to this.
So I think it would be best if you create another PR.

Thanks
I'll close this one in favor of a new one, track https://github.com/facebook/docusaurus/pull/9954


[UX Test]: Sources / Landing Page Test

Issue Name
Sources / Landing Page Test
Test Purpose
We recommend a Lyssna test to learn more about user expectations regarding the landing page table and where they prefer to find information about sources to support the ongoing discussion about how/where to store this information on the site.
Test Approach
The test would be conducted with 25 users on Lyssna. It will show 4 potential landing page mock ups (2 with landing page table and 2 without landing page table) based on the designs generated by OCGR. The test will ask users to select their preferred design, provide an explanation as to why they made that selection. It will then show them a picture of the landing page table and ask them to rate how important it is for the table to be on the landing page. Lastly, it will ask them for the rationale behind their rating.
Test Cost
$75
Test Time
We already have questions drafted, so 1 day to set up, 1 day to collect results, and 1 day to analyze results.
Writeup URL
https://app.lyssna.com/do/eafeb60d7be0/48f8
Related WBS task
https://github.com/NIAID-Data-Ecosystem/nde-roadmap/issues/16
For internal use only. Assignee, please select the status of this issue

[ ] Not yet started
[ ] In progress
[ ] Blocked
[ ] Will not address

Status Description
No response
Test status check list

[X] This test has yet to be discussed between NIAID, Scripps, Leidos
[ ] This test has been discussed/reported between NIAID, Scripps, Leidos
[X] This test has been scoped out
[X] This test has been drafted in the platform in which it will be conducted
[ ] This test has been conducted
[ ] The results of this test have been analyzed

We expect to conduct this test the week of July 22, 2024

@hartwickma @rshabman @lisa-mml @sudvenk
The results of the Lyssna study on the placement of the landing page table are now available: https://docs.google.com/presentation/d/1m6oEb46YG79HhYB086eGJHtwlqz_E56w/edit?usp=sharing&ouid=114065631315523104759&rtpof=true&sd=true

Hi @gtsueng, thank you for this update. It is not clear what the request is for NIAID. Please provide more details or consider if it should be part of an upcoming bi-weekly meeting.

Hi @hartwickma @lisa-mml @rshabman @sudvenk
There is no exact "Ask" for this issue as we simply meant to keep the team informed of the results from the latest Lyssna study. This study examined whether or not the resource table should be included on the landing page (or if it should be moved elsewhere). Users preferred the table on the landing page, but were split on whether they preferred the original design, or the new color schema/design provided by OCGR. Test details and results can be found at :https://docs.google.com/presentation/d/1m6oEb46YG79HhYB086eGJHtwlqz_E56w/edit#slide=id.g28e2c7be71b_0_42
As there is no decision pending for this issue, we will include it as a discussion item for the bi-weekly meeting ONLY if you'd like to discuss the results. Otherwise, the results are just there for your information.


Remove duplicate implementation of getPrototypeFactory

@phillipm I just noticed that this is assigned to Clayton, but am assuming that's just to bring it to his attention, not because he's the only person you want to merge this. Let me know if that's not the case.


Create wrapper for the mjModel and mjData structs

[x] Use Clang.jl to autogen structs and enums
[x] Clean up the code written by Clang.jl
[x] Make a script to clone the original mujoco repository
[x] Using PyCall to parse the introspect autogenerated files for the description
[x] Convert the python AST objects to Julia ones
[x] Use the documented objects to comment Clang generated data
[x] Write a basic test which loads a model and steps it using the autogenerated code
[x] Create API wrappers for the internal objects such as Model and Data (see https://github.com/JamieMair/MuJoCo.jl/issues/7)
[x] Create a basic binding wrapper for accessing via getproperty to directly access the underlying data
[ ] Create a binding wrapper that allows for writing to structs via pointers
[ ] Add a way to access the array properties via an UnsafeArray or equivalent

Added in changes in https://github.com/JamieMair/MuJoCo.jl/pull/6


Radio playback app crash

OS:
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.1 LTS
Release:	16.04
Codename:	xenial
Kernel: 4.4.0-30-generic
Issue Descriptions:
Bug: During radio playback, after the second commercial the app freezes and stops working.
Additional Info:
Bug between version 3.2.4 -> 3.3.0
Running version 3.2.4 does not have this issue. The first commercial works fine, and music playback works fine. However once the second commercial finishes playing, the app does not continue to play and stops completely. I have tested on both this linux machine and my windows 7 64bit desktop.
Steps to Reproduce:

No google music subscription.
Must have 3.3.0 installed
Choose radio from either the "Listen Now" featured stations or an artist radio.
Allow playback of first commercial and additional songs.
Wait for second commercial and watch for app failure once completed.

P.S. I love your app keep up the good work.

This is an upstream chromium crash and will be fixed in the next release when we update Electron versions


Android 9 Frame Rate Slowed Down

After upgrading different Samsung phones to Android 9, the apps using GearVRf are now rendering slow at about 1-2 FPS. I tested this using the most recent build on GearVRf-Demos - gvr-360video. Can anyone confirm this behavior?

I met same issues.
It happened after PIE os update.
@Override public void onStep() {     getGVRContext().getActivity().getFullScreenView().invalidate(); }
It works but It is not proper fix for this issue.
Please check this frame issue.

Fix has been merged in master. The master snapshots on maven have been updated too. Thanks for letting us know.

The fix is working for my applications. Thank you for the quick turnaround. Closing the issue.


[Feature Request] Hide specific users on feeds

Requested Idea In Depth:
The ability to right click a friend and toggle blacklisting them from appearing in your feeds.
Example reason why this feature is useful. This friend is funny but this feature is annoying.

Dupe https://github.com/pypy-vrc/VRCX/issues/266


Automation for generating the file on a nightly basis?

Hey there! Many thanks for this awesome script. Is it somehow possible auto generate those files every night and add it to this github repo? For example like: https://github.com/sapics/ip-location-db

Hmm I'm not too sure tbh since there's heavy reliance on logging in via etherscan first and using selenium.
Main challenge would be

Clearing Captcha + automation for etherscan login

Alternative I suppose could be to leave an instance logged in running and simply scrape everything from the last pages of each recorded column.
Not sure about the compute costs though and perhaps a soln that relies on attaching cookies https://github.com/brianleect/etherscan-labels/issues/9 would be much more efficient.


utf8 keys rather than utf16?

Is there any reason why keys cannot be stored in UTF8 format rather than UTF16?
Under the lmdb hood they're just a bunch of bytes and as most keys tend to be Latin using 2 bytes per char seems pretty wasteful.
If you have 30M+ keys (which we do) it can add up to much larger databases which need to be paged in and out of memory.

@russtee That'd defeat the 'zero-copy' promise of node-lmdb. V8 Treats strings as UTF-16, and if you store it as UTF-8 it will have to make a copy in UTF-16 first before you can use them.

So this idea would not only waste memory by introducing an extra memcpy for every string key, but also introduce a conversion from UTF-8 to UTF-16...

(Generally this is not a fault of V8: the JavaScript spec treats all strings as UTF-16)

Isn't the extra memcpy a transient thing though? I don't understand the waste memory part. If my database is 25% bigger (say 5GB) because the keys are 50% larger than they need to be then more memory will be need to be paged in from disk which ultimately constrains the database size or unduly slows the machine down for all the other processes.

@russtee I think I get your point. In this case, it would be a trade between disk storage space and application speed.

Indeed, it could be different for others depending on the application. We have 50+ servers and our biggest cost in terms of performance and capacity is SSD space and memory both of which are consumed when the lmdb database is larger.  If all of your keys are 50% bigger then you inadvertently end up doing a lot more work. Larger keys lead to more page fragmentation which increases the load considerably, at least in our experience.
Also we use application level indexing and replication which adds a lot more keys thus exacerbating the problem. In this context the switch to utf16 hurts performance as we store the key references as utf8 binary strings and so need to convert them each time they're used. With utf8 keys we wouldn't need to do this and this aspect could be zero copy.
In the end it depends on the application, we have a large global network with lmdb at the core and the bottlenecks become really obvious when you're under load. I know in our case it would make a huge difference.
Great work btw, it's really appreciated, lmdb is a great kv store and having a stable and flexible node library can only help with its adoption.

I agree that it depends mostly on the application. To be honest, since javascript always uses UTF-16 for strings it never occoured to me to expose the ability to store stuff in other encodings with this module.
But of course, if you access the database from other processes and those processes use UTF-8 then yeah, you'd have to make a choice and I can see why you would choose to use UTF-8.
(I would personally still vote UTF-16 because .NET, Java and Qt all use it and it'd be more important for me to interface with these than to save some storage. But, I see your point.)
Here is a suggested solution (this was already proposed a while ago, but the implementation isn't produced yet): instead of implementing the UTF-8 <=> UTF-16 conversion, what would you say if the API would change in such a way that it would allow to work with keys as Buffers. This would benefit everyone because it'd enable to use any other arbitrary encoding too.

Yes, I was thinking of keys as buffers as an option, it would certainly solve our problem.
As a proof of concept I'll take a look at casting our utf8 keys to utf16 at the application level, we're not particular CPU bound and so it would probably keep us going in the interim.

I agree, keys as buffers would be a good option to have.

Is this still being worked on? I am currently unable to use this module in our node.js regression testing framework as unfortunately, the keys we use when creating and populating the LMDB database in C code are plain ASCII. Having this feature would help us tremendously.

@mux Yes, sorry for the slowness. This is still a planned feature and it will arrive eventually.
To be honest, I currently don't have any projects that would depend on node-lmdb so that's why it's going forward slowly these days.

Added support to use buffers for keys in this PR: https://github.com/Venemo/node-lmdb/pull/83

Thanks @braydonf
I'm gonna review all the latest changes and if everything's okay, I'll do a new release on npm.

Hi @Venemo ! Thank you for taking care of this. Any ETA on the npm release?

@mux Sorry for my late reply. A new version has now been published on npm! :)

Awesome! Thank you a so much @Venemo!

Now that the buffer-based API is in place, I'll close this. I also added some documentation regarding working with UTF-8: https://github.com/Venemo/node-lmdb/commit/524a3bef216e8273872ad59acdc5d3a5dcfac6a5


permissions error

I always encounter errors like the following when executing commands such as apt install:
E: Sub-process /usr/bin/dpkg returned an error code (1)
And during the initial installation, I encounter permission issues with install.sh.

container@pterodactyl~ Starting installation process, this could take a few minutes...
bash: /mnt/install/install.sh: Permission denied
[Pterodactyl Daemon]: Checking server disk space usage, this could take a few seconds...
[Pterodactyl Daemon]: Updating process configuration files...
[Pterodactyl Daemon]: Ensuring file permissions are set correctly, this could take a few seconds...
container@pterodactyl~ 服务器运行状态更新为: starting...
[Pterodactyl Daemon]: Pulling Docker container image, this could take a few minutes to complete...
Pulling from ydrag0n/pterodactyl-vps-egg
Digest: sha256:62f74ca4dc7e746af989108ba2ce6f6c30f1d32213ec2abcef32f475e747800a
Status: Image is up to date for quay.io/ydrag0n/pterodactyl-vps-egg:latest
[Pterodactyl Daemon]: Finished pulling Docker container image

Setting up ssh-import-id (5.11-0ubuntu1) ...
Setting up libwrap0:amd64 (7.6.q-31build2) ...
Setting up publicsuffix (20211207.1025-1) ...
Setting up ncurses-term (6.3-2ubuntu0.1) ...
Setting up openssh-server (1:8.9p1-3ubuntu0.6) ...
ucf: do not have write privilege to the state data
dpkg: error processing package openssh-server (--configure):
 installed openssh-server package post-installation script subprocess returned error exit status 1
Processing triggers for libc-bin (2.35-0ubuntu3.6) ...
Errors were encountered while processing:
 openssh-server
E: Sub-process /usr/bin/dpkg returned an error code (1)

Hi, please download the newer vps-egg.json or egg-vps-arm64.json according to your arch...
Second error is fixable via running:
PACKAGE_NAME=openssh-server
sudo rm /var/lib/dpkg/info/$PACKAGE_NAME.*
sudo dpkg --configure -a
sudo apt update
sudo apt-get install $PACKAGE_NAME


Feature/12 add installation script

Want to test this on someones machine who hasn't already set it up. Any ideas?
Happy to release potentially as a 1.1 version and fix any bugs with it going forward.
The commands themselves look fine and I suppose you would know if something fails but I'm not sure if some checks should be added at certain intervals e.g. after setting up apache or php etc to verify nothing went wrong otherwise you just have a load of changes happen without their dependencies.

Lets just push this in and worry about bug fixes once it is out in the wild.


dynatrace_notification reorders receivers on subsequent runs

After creating a dynatrace_notification, subsequent executes result in a reordering of receivers in cases where two or more are specified.

Hi Joseph,
The resource dynatrace_notification is one of the three remaining resources that haven't gotten migrated to manual serialization (still uses golang reflection). I'd have to confirm to be certain, but it looks like it suffers from the same issues that led me to re-implement all resources in the first place.
By the end of next week I'm hoping to have all currently supported resources migrated. I'll take a close look at your example before releasing that version.


Enable dhcp agent notification

For testing purpose in adoption job in order to test dhcp agent

This looks good for me and makes sense as by default this is disabled in the neutron-operator but in case of adoption we are testing adoption of the neutron-dhcp-agent too so we should have it enabled.
One additonal thing: maybe you can also add note in the docs: https://github.com/openstack-k8s-operators/data-plane-adoption/blob/main/docs_user/modules/proc_adopting-the-networking-service.adoc about this. Something like:

If neutron-dhcp-agent was used in the OSP-17.1 deployment and should still be used after adoption, please enable also dhcp_agent_notification for neutron-api service. This can be done with command:
...

/cherry-pick 18.0-fr1


chore: add v2 to peer dependencies

closes #27

Nice!  I just came to do this - mind adding a patch changeset and I'll get these both released?

huh - yeah maybe we don't have the CI bot configured the same in here 🤔


[🐛]

launchImageLibrary is not visible in some android devices ..it is trying to show a bottomsheet gallery but its not visible completely ..
Device info :
Redmi Note 10
Modal: M2101K7AI
package veriosn:
@7.0.0

+1, new Intent(MediaStore.ACTION_PICK_IMAGES) opened transparent

+1, new Intent(MediaStore.ACTION_PICK_IMAGES) opened transparent

did u find the solution


Event admin page start/finish date-time adds offset on saving, editing displayed time

Whenever you save an event in the admin interface (even if you have made no changes to the event finish time), the event finish date/time will add the offset associated with the selected timezone.
Eg 04/03/2024 10:59am becomes 03/03/2024 11:59pm, when timezone is set to UTC+10 Sydney time (Sydney is currently on +11 on daylight savings so I think the labelling is also incorrect)
I have replicated on UTC-8 Los Angeles time, seeing the offset subtracted.
https://github.com/microsoft/azure-openai-service-proxy/assets/7269759/aef50796-e7cc-4c87-8b44-5932347c5829
https://github.com/microsoft/azure-openai-service-proxy/assets/7269759/7b4dfadf-9580-4130-87af-27cac768b079

fixed


Added a root option to the run-android command

Added a root option to the run-android command allowing to run it from a parent directory.
Use case: project is organized like this
- api
- apps
---- web
---- react-native
- package.json

You can use the root option on react-native start but not on run-android. This pr fixes that.

Looks useful, thanks! Did you test that it still works fine when you don't pass --root (asking about path.join with an empty string).

Yes, I did test with the root option. It works fine

@djhi I meant testing without the root option.

Sorry, that's what I meant: I did test without it

The usage is e.g. react-native run-android --root .., correct?
One last nit, sorry I didn't catch it earlier.

Yes, react-native run-android --root="./app/react-native" for example

Oh wait now you've shown an example how to use the option I realized this is the root for Gradle, not for the packager, correct?
In that case the description should say something like "Root directory for the Android build, containing the android directory."

Thanks for the PR, makes sense to have apps structured like that.

You're right. Btw I haven't applied this to the iOS code but it might be a cool thing to add too.

Cool! Btw, there's a risk that the behavior of path.join for empty string arguments changes, e.g. throws an exception, which would break this code. It's changed in the past: https://nodejs.org/api/path.html#path_path_join_path1_path2
Don't think the risk in this case is high but in general programming defensively and checking for all special cases is safer.

Let's merge this.
@facebook-github-bot shipit


DO NOT MERGE: test results bump

vetting https://github.com/openshift-pipelines/pipeline-service/pull/966 with appstudio e2e's
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

/hold

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/redhat-appstudio_infra-deployments/3425/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-hac-e2e-tests/1767601071355596800 failed for unrelated reasons, but since it failed, we got must gather artifacts
api and watcher logs clean, with storage and retrieval of records, and storage of logs
good to go

e2e failed as well but only with a jvm bld svc flake
again results functional per logs


Move Vue from dependencies to peerDependencies

Could you please move vue to peerDependencies
https://github.com/nicolasbeauvais/vue-social-sharing/blob/592adddd9ebe46fa969e75b847258470f0db221c/package.json#L82
It cause to dublicate vue as dependency in bundle

ooups, out of date, miss that)


[1.21 - Crash] Conflict with PolyLib

What's the issue?
Mixin conflict with the mod PolyLib 0.3-159
@Redirect conflict. Skipping polylib-fabric.mixins.json:AbstractContainerScreenMixin from mod polylib->@Redirect::redirectHighlight(Lnet/minecraft/class_332;III)V with priority 1000, already redirected by camerapture-client.mixins.json:HandledScreenMixin from mod camerapture->@Redirect::drawSlotHighlight(Lnet/minecraft/class_332;III)V with priority 1000
Screenshots
No response
Mod and Minecraft version
Camerapture 1.6.1 - MC 1.21

Thank you for the report! That should be a pretty easy fix!


New pypi release to fix dependency issue with Django 1.11.x

We are using Django 1.11.4, which should totally work, but the installation is failing due to a conflict:
error: Django 1.11.4 is installed but Django<=1.11,>=1.8 is required by set(['django-defender'])

Seems to be ok with master -- but we'd need something from pypi. Thanks!

0.5.2 is now on pypi : https://pypi.python.org/pypi/django-defender/0.5.2

Thanks! It would be great to get another release once https://github.com/kencochrane/django-defender/pull/115 is merged. We are packaging defender into RPMs and these extra dependencies are not making life easier at all.

@livenson yes, I was hoping to have everything in this release, but didn't want to keep everyone waiting, hopefully we can get the other PR's merged, and once we do, I'll do another release.

@kencochrane , any chance of doing a 0.5.3 release with dropped mock dependency?

0.5.3 is on PyPi https://pypi.python.org/pypi/django-defender/0.5.3


Skip smushing images with no changes

Would be great if it could detect images that have had no change and skip smushing them during the build process.

https://github.com/middleman/middleman-smusher/issues/3


Revert "Re-enable AAR plugins when an AndroidX failure occurred"

Reverts flutter/flutter#40810
Broke flutter_gallery__back_button_memory and flutter_gallery__image_cache_memory

Actually, reverting this PR, doesn't seem to make the test happy. The crash is being followed up on: https://github.com/flutter/flutter/issues/41010


add setChannel

added select channel function, and structure of enum of channels also delete print (No Data RX1 and No Data RX2) message when is not received nothing in update function and finally added example in send class a

@ivan28823 let us know whenever ready and merge :D

Is ready to merge, the only thing is that i've removed the uart support in commands.h, i think that this feature have to be in other library

Sorry for the delay @ivan28823  i was on a very long travel


Fix Optimism badge

Fixes a bug of missing op mask in optimism badge

This was caused by multiple svgs in the document that had the same maskId (#OP). Changing this to unique maskIds is good enough IMO.

LGTM, although why do we need a mask there?
I want to have a transparent cutout.


No Bottom bar or livereload on macOS

I'm not seeing a bottom bar or livereloading work by default. I can get livereloading working separately by using the livereload app in the mac app store..
however, I'm not seeing the bar at the bottom that I see in the documentation, on my mac..

Hmm. Can you check and paste two things for me:

Version of Breakfast (cat Gemfile.lock | grep breakfast)
Version of breakfast-rails npm package (cat package.json | grep breakfast)

breakfast (0.6.2)
 "breakfast-rails": "^0.6.2"
Will double check on the developer console logs asap

don't see any relevant errors in console logs..


Switch Connections to use ValueSets to initialize them

⚠ targets #10067
Summary of the Pull Request
This PR does one big, primary thing. It removes all the constructors from any TerminalConnections, and changes them to use an Initialize method that accepts a ValueSet of properties.
Why?
For the upcoming window/content process work, we'll need the content process to be able to initialize the connection in the content process. However, the window process will be the one that knows what type of connection to make. Enter ConnectionInformation. This class will let us specify the class name of the type we want to create, and a set of settings to use when initializing that connection.
IMPORTANT: As a part of this, the constructor for a connection must have 0 arguments. RoActivateInstance lets you just conjure a WinRT type just by class name, but that class must have a 0 arg ctor. Hence the need for Initialize, to actually pass the settings.
We're using a ValueSet here because it's basically a json blob, with more steps. In the future, when extension authors want to have custom connections, we can always deserialize the json into a ValueSet, pass it to their connection's Initialize, and let then get what they need out of it.
References

Tear-out: #1256
Megathread: #5000
Project: https://github.com/microsoft/terminal/projects/5

PR Checklist

[x] Closes https://github.com/microsoft/terminal/projects/5#card-50760298
[x] I work here
[n/a] Tests added/passed
[n/a] Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments
ConnectionInformation was included as a part of this PR, to demonstrate how this will eventually be used. ConnectionInformation is not currently used.
Validation Steps Performed
It still builds and runs.

ARGH I didn't realize this targeted the other one...


Cart doesn't revalidate data on Server Action with client-side routing

The add-to-cart Server Action should revalidate the /cart to refetch data from the database (e.g. showing the new items added to the cart) without a full page load (just using the Link component). The revalidatePath function seems to work with mutations on the same page, however, doesn't seem to cause a revalidation on other pages (in this case the cart page).
Current temporary work around - using  tags for linking to cart page in header and toast notifications, but this is far from ideal.

I can reproduce this bug on my project with a similar use case.


Fix numbered list on live_leaderboard example

perhaps merge this into the other Kapacitor doc updates and retire this branch?

I've added these changes directly into the Kapacitor 1.4 release branch...
https://github.com/influxdata/docs.influxdata.com/commit/b1c9a19dad0284b76e9739d59227955b8d8060a4

@karel-rehor so i can close this one?

I think this can be closed


Testing on external dataset

Hi, I'm now trying to test the model you provided on the PI-CAI dataset. Could you please let me know what does the test csv file look like? Thank you very much!
I have seen the yaml file but still cannot figure it out by myself.

You can get the csv's for the test set, I have used here:
https://doi.org/10.5281/zenodo.6592345
basically it is a simple table like this:

image
label

path/to/image/
path/to/label

For PI-CAI you will need to do the data wrangling yourself.

Thanks for responding me so quickly! I see, I will check this test data.
Thank you very much!


feat: rounded borders on original comment box

This adds "border-radius: 20px;" to the original comment window on new/old Reddit, this should improve view-ability and make the visual styling slightly more appealing
Sorry if this was an already considered suggestion that was rejected as I couldn't find anything

Oh great point, I didn't think to check what rounding other elements were using

Cheers!


python310Packages.logilab_astng: remove

Description of changes
This package has not been updated since 2013, its homepage has disappeared, and its tests don't run against the latest version of logilab-common.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1531


Fix detection that python3.6 or python3.7 is already installed

python3.6 python3.7: python
ifneq ($(shell which $@ 2> /dev/null),)
        @echo ">>> $$($@ --version) already installed"
else
        @echo ">>> Installing $@"
        sudo add-apt-repository -y ppa:deadsnakes/ppa
        sudo apt update
        sudo apt install -y $@-dev $@-venv
endif

The issue is that $@ is not resolved at the time ifneq is evaluated and thus the rule always proceeds with an installation.

Fixed in c6837c682194dc0f1b46452f964f40e078336d41 by removing the installation check.


Aggregate Queries

Adding support for aggregate queries.
Fixed regression with idSet bind variables introduced in the fix for #19
Added more info to what gets returned and then displayed on datatable errors with stacktraces

Just realized you submitted this already (I have notifications off, but might turn them back on now that this lib is "released").
Will look at this next week!

LGTM, tests now pass!

You have my thanks, from one James to another


Add ability to use MSBuild from Visual Studio Preview

I only have Visual Studio 2017 Preview installed, and no non-preview version of Visual Studio 2017. Currently, Resolve-MSBuild is not able to find the MSBuild 15.0 that is installed as part of Visual Studio 2017 Preview.
This PR makes Resolve-MSBuild search for MSBuild 15.0 in the Visual Studio Preview directory if it cannot find MSBuild 15.0 in the non-preview Visual Studio 2017 directory.

Hi @mark-raymond
Thank you, I understand why this is needed and it looks good. But need some time to think of this.
Do you know how VSSetup or vswhere deal with Preview? Do not worry if you do not, just asking.

Just tried them - both will detect the preview installation, but only if you pass -prerelease to them. So a comparable change could be made to Get-MSBuild15VSSetup to pick up preview installations.

Added support for getting the preview installation via VSSetup too.

Could you please get the dump of properties of VS instance that you get by VSSetup?

Get-VSSetupInstance -Prerelease:
InstanceId          : 5164423e
DisplayName         : Visual Studio Professional 2017
InstallationVersion : 15.5.27128.1
InstallationPath    : C:\Program Files (x86)\Microsoft Visual Studio\Preview\Professional
InstallDate         : 25/09/2017 10:12:52

If you try | Format-List * then IsPrerelease is true, I hope.

Yes :smiley:
Get-VSSetupInstance -Prerelease | Format-List *:
PSPath              : Microsoft.PowerShell.Core\FileSystem::C:\Program Files (x86)\Microsoft Visual Studio\Preview\Professional
InstanceId          : 5164423e
InstallationName    : VisualStudioPreview/15.5.0-pre.5.0+27128.1
InstallationPath    : C:\Program Files (x86)\Microsoft Visual Studio\Preview\Professional
InstallationVersion : 15.5.27128.1
InstallDate         : 25/09/2017 10:12:52
State               : Complete
DisplayName         : Visual Studio Professional 2017
Description         : Professional developer tools and services for small teams
ProductPath         : C:\Program Files (x86)\Microsoft Visual Studio\Preview\Professional\Common7\IDE\devenv.exe
Product             : Microsoft.VisualStudio.Product.Professional,version=15.5.27128.1
Packages            : {Microsoft.VisualCpp.PGO.X64,version=14.10.25830.2, Microsoft.VisualCpp.VCTip.hostX86.targetX64,version=14.10.25830.2, Microsoft.VisualStudio.Web.Mvc,version=15.0.51007.0, Microsoft.VisualStudio.Web.Mvc.Common,version=15.0.51007.0...}
Properties          : {[CampaignId, ], [SetupEngineFilePath, C:\Program Files (x86)\Microsoft Visual Studio\Installer\vs_installershell.exe], [Nickname, ], [ChannelManifestId, VisualStudio.15.Preview/15.5.0-pre.5.0+27128.1]}
Errors              :
EnginePath          : C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service
IsComplete          : True
IsLaunchable        : True
CatalogInfo         : {[Id, VisualStudioPreview/15.5.0-pre.5.0+27128.1], [BuildBranch, d15rel], [BuildVersion, 15.5.27128.1], [LocalBuild, build-lab]...}
IsPrerelease        : True
ChannelId           : VisualStudio.15.Preview
ChannelPath         : C:\Users\mark.raymond\AppData\Local\Microsoft\VisualStudio\Packages\_Channels\48CDB76F\catalog.json
ChannelUri          : https://aka.ms/vs/15/pre/channel
ReleaseNotes        : https://go.microsoft.com/fwlink/?LinkId=660693#15.5.0-pre.5.0
ThirdPartyNotices   : https://go.microsoft.com/fwlink/?LinkId=660708

Thank you for your help, this is very useful. This will not take long.

Please review and ideally try my changes:
(1) In commands, switch parameters normally go after non-switches, so I moved $Prerelease to the end.
(2) Get-MSBuild15VSSetup is called once because if VSSetup is installed and Visual Studio exists then this function should get something, one way or another, right? It is called without -Prerelease so that preview versions, if any, are not included at this point. If it finds something then it's done. Else it calls itself with -Prerelease and gets a preview version, if any. If nothing is found at this point then nothing probably exists at all.
(3) Get-MSBuild15Guess uses the same parameters and the same approach for the same reasons. $Folder is not a parameter, it is calculated internally per -Prerelease.
(4) Get-MSBuild15 is restored to its original code. Preview versions are now handled by called functions.


Request: Upgrade HandBrake to 0.10.2

A PR is welcome. It’s an extremely easy change, and we’re here to help.

Made a pull request with the updated version and sha256 here: https://github.com/caskroom/homebrew-cask/pull/11920. (Hope I am doing this right(?)). Cheers

Fixed in #11920

Thanks!


Fixed getting started mistake for n_offsprings

I noticed a mistake in the Getting Started page:

We chose a population size of 40 (pop_size=40) and decided instead of generating the same number of offsprings to create only 10 (n_offsprings=40).

I fixed it by setting n_offsprings=10

Great! Thank you!
Let me know if you find something else. Such mistakes happen so quickly.


Make dev mode CLI a bit more friendly.

For #2753

I've added a --verbose option to the server:start command that cuts out a bit of the noise so that the altair URL is better highlighted.

The ticket also wants us to put in message that points the user to /admin so they can make it to their CMS. However we're not really doing anything besides running next dev in the starters to get their site up and running. So:
@jamespohalloran
Do I just tack on something to the server:start command that tells the user to go to /admin?
a) They can technically run server:start separately
b) Technically the server:startcommand has nothing to do with their Next site actually running.
The ticket seems to imply you that this is maybe what you want, but just want to double check.

Do I just tack on something to the server:start command that tells the user to go to /admin?
a) They can technically run server:start separately b) Technically the server:startcommand has nothing to do with their Next site actually running.

Yeah, I think that's fine for now! All our examples/starters have them running together, so if they're running them independently, they are probably rolling with an advanced use-case and won't get too tripped up by the console.log

need a documentation update for the verbose flag?: https://github.com/tinacms/tinacms/blob/main/packages/%40tinacms/cli/README.md


WIP: Translate tasks/manage-kubernetes-objects/declarative-config into Japanese

resolve #27596

The current WIP translation is based on the original article as of May 2021. it needs the update.

/assign

/remove-lifecycle rotten

Hello folks, there has been no activity on this PR since ~6 months and I'll be therefore, closing this PR off.
We understand that the localization cadence is different & that contributors/approvers may dip in & out based on their bandwidth. Please feel free to reopen this once you have the cycles to work on this together.
/close


SMBus write_i2c_block_data error

I found a problem with the SMBus.py write_i2c_block_data definition.  The command self.mcp2221.I2C_Write(addrs,[cmd,vals]) has a problem.  Specifically, the parameter [cmd,vals] ends up sending a LIST of LISTS into the I2C_Write function and triggers the error "TypeError: 'list' object cannot be interpreted as an integer."
I changed the code to the following:
    def write_i2c_block_data(self, addrs,cmd,vals):
        vals.insert(0, cmd)  # Insert the CMD into the beginning of the vals LIST.
        self.mcp2221.I2C_Write(addrs,vals)

This fixes the error.

Fixed in Pull Request #20.


Mail configuration document improvements

It seems Ghost 1.0.0 is still using nodemailer 0.7, please replace this link (https://github.com/nodemailer/nodemailer/tree/0.7) in the document.
Or users may configure mail settings as the newest nodemailer documents show.
And, the Ghost 1.0.0's config file is in JSON format, all the keys and values should be quoted, the document may cause misunderstanding.
Technical details:

Ghost Version:1.0.0
Node Version:v6
Browser/OS: N/A
Database: N/A

Documentation has been fixed. 😄
In the future, please use the "Suggested Edits" feature of docs.ghost.org, as that's what it's there for - Github issues should be used for bug reports and ongoing feature work 😉

@acburdine Noted with thanks :)

@acburdine One more typos, according to the source code of Ghost, (https://github.com/TryGhost/Ghost/blob/master/core/server/mail/GhostMailer.js#L22),
"mail": {
    "from"<EMAIL_ADDRESS>}

should be
"mail": {
    "fromaddress"<EMAIL_ADDRESS>}

I have submitted a suggested edit on the site, maybe you could approval it later
the configuration has been tested on my own blog and passed.

I merged it and then realized that from works as well, and is probably simpler. If you look at that line from is also accepted as a valid key.

from  is correct. fromaddress should really be removed from the code as well as documentation.

The documentation was already updated for 1.0, i guess @acburdine did it.
I will delete the fromaddress config key support from the code base later, because it's a really quick thing.


Register without user but secure sending notification

Hi.
We have set up pushd as our notification service. As far as I have found it is possible to enable a user so you have to login before being allowed to register a push token and sending out push notifications.
In our case we want no authentication for registering and pinging a token, but for everything else, like sending out a push notification.
Is there a way to achieve this with the current settings.coffee or is this not possible at the moment?
Thank you.
Regards,
Mike

no more activity here. will close this.


bugfix: should set data of the iterator.

TEST case below failed,  /equal1 match nothing.
=== TEST 3: multiple path with overlap
--- config
location /t {
content_by_lua_block {
local radix = require("resty.radixtree")
local rx = radix.new({
{
paths = {"/equal*"},
metadata = "metadata multipe path 1",
},
{
paths = {"/equal123*"},
metadata = "metadata multipe path 2",
},
})
        ngx.say(rx:match("/equal1"))
    }
}

--- request
GET /t
--- no_error_log
[error]
--- response_body
metadata multipe path 1

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@dongbeiouba please sign the CLA, thx

@dongbeiouba many thx. Merged already


Fix NullPointer exception in PDFALTOOutlineSaxHandler

I observed the following error.
févr. 12, 2021 3:20:44 PM org.grobid.core.document.Document addTokenizedDocument
GRAVE: Cannot parse file: my_dir/grobid-0.6.1/grobid-home/tmp/ZW3PpM4E9g.lxml_outline.xml
févr. 12, 2021 3:20:44 PM org.grobid.core.document.Document addTokenizedDocument
GRAVE: Cannot parse file: my_dir/grobid-0.6.1/grobid-home/tmp/ZW3PpM4E9g.lxml_outline.xml
févr. 12, 2021 3:20:46 PM org.grobid.core.engines.ProcessEngine createTraining
INFOS: 2 files processed.
it originates in an illegal nullPointer access in file PDFALTOOutlineSaxHandler.java.
In understand that the error is not  that "GRAVE". According to @kermitt2, it is simply one of the generated XML file resulting from the PDF parsing which is not XML valid (very frequent) - it has no impact because the outline file (containing the table of content outline if available embedded in the PDF) is not exploited by GROBID for the moment - it's to allow some possible improvements in the future. The error is more a reminder for the developers... the XML parser that classifies it as "GRAVE" but it would be rather INFO for us.
Unfortunately, a side effect might have been overlooked. If father is null, then father.addChild(currentNode) is called with a nullPointer exception.
This exception is caught by catch (Exception e) at line 372 in grobid-core/src/main/java/org/grobid/core/document/Document.java where the error message "Cannot parse" is misleading.
I think an additional else is just missing.

Coverage remained the same at 38.164% when pulling 62599b4347b2007f84610fe6763e7c5d068c0b64 on lucbouge:patch-1 into bfc10f77998a141e14e1a88483ef42954e0d30b2 on kermitt2:master.

Thanks. I proceed today. Luc.

Le 18 févr. 2021 à 23:25, Luca Foppiano<EMAIL_ADDRESS>a écrit :
@lfoppiano requested changes on this pull request.

Here is a test file
test.pdf
Here is the outcome with the original installation grobid-0.6.1. I singled out the trace of the bug.
I also include below the trace with the pull request.
Regards,
Luc.
With the original installation
$ java -Xmx4G -jar grobid-core/build/libs/grobid-core-0.6.1-onejar.jar -gH grobid-home -dIn Input -dOut Output -exe createTraining

févr. 19, 2021 7:33:22 PM org.grobid.core.main.GrobidHomeFinder getGrobidHomePathOrLoadFromClasspath
AVERTISSEMENT: No Grobid property was provided. Attempting to find Grobid home in the current directory...
févr. 19, 2021 7:33:22 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: ***************************************************************
févr. 19, 2021 7:33:22 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: *** USING GROBID HOME: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home
févr. 19, 2021 7:33:22 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: ***************************************************************
févr. 19, 2021 7:33:22 PM org.grobid.core.main.GrobidHomeFinder getGrobidHomePathOrLoadFromClasspath
AVERTISSEMENT: No Grobid property was provided. Attempting to find Grobid home in the current directory...
févr. 19, 2021 7:33:22 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: ***************************************************************
févr. 19, 2021 7:33:22 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: *** USING GROBID HOME: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home
févr. 19, 2021 7:33:22 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: ***************************************************************
févr. 19, 2021 7:33:22 PM org.grobid.core.main.GrobidHomeFinder findGrobidPropertiesOrFail
AVERTISSEMENT: Grobid property file location was not explicitly set via 'org.grobid.property' system variable, defaulting to: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/config/grobid.properties
févr. 19, 2021 7:33:22 PM org.grobid.core.utilities.GrobidProperties getEnvironmentVariableOverrides
INFOS: environment variables overrides: {}
févr. 19, 2021 7:33:22 PM org.grobid.core.main.LibraryLoader load
INFOS: Loading external native sequence labelling library
févr. 19, 2021 7:33:22 PM org.grobid.core.main.LibraryLoader load
INFOS: Loading Wapiti native library...
févr. 19, 2021 7:33:22 PM org.grobid.core.main.LibraryLoader load
INFOS: Native library for sequence labelling loaded
févr. 19, 2021 7:33:22 PM org.grobid.core.lexicon.Lexicon initDictionary
INFOS: Initiating dictionary
févr. 19, 2021 7:33:22 PM org.grobid.core.lexicon.Lexicon initDictionary
INFOS: End of Initialization of dictionary
févr. 19, 2021 7:33:22 PM org.grobid.core.lexicon.Lexicon initNames
INFOS: Initiating names
févr. 19, 2021 7:33:22 PM org.grobid.core.lexicon.Lexicon initNames
INFOS: End of initialization of names
févr. 19, 2021 7:33:22 PM org.grobid.core.lexicon.Lexicon initCountryCodes
INFOS: Initiating country codes
févr. 19, 2021 7:33:22 PM org.grobid.core.lexicon.Lexicon initCountryCodes
INFOS: End of initialization of country codes
test.pdf
1 files to be processed.
Input/test.pdf
févr. 19, 2021 7:33:22 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/fulltext/model.wapiti (size: 21913642)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/fulltext/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/fulltext/model.wapiti

############## Here is the bug!
Warning, father not yet encountered! id is 1
févr. 19, 2021 7:33:25 PM org.grobid.core.document.Document addTokenizedDocument
GRAVE: Cannot parse file: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/tmp/9bHVcUR99j.lxml_outline.xml
##########################

févr. 19, 2021 7:33:25 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/segmentation/model.wapiti (size: 27668093)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/segmentation/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/segmentation/model.wapiti
Warning, father not yet encountered! id is 1
févr. 19, 2021 7:33:29 PM org.grobid.core.document.Document addTokenizedDocument
GRAVE: Cannot parse file: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/tmp/9bHVcUR99j.lxml_outline.xml
févr. 19, 2021 7:33:29 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/reference-segmenter/model.wapiti (size: 4921245)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/reference-segmenter/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/reference-segmenter/model.wapiti
févr. 19, 2021 7:33:30 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/citation/model.wapiti (size: 16412787)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/citation/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/citation/model.wapiti
févr. 19, 2021 7:33:32 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/figure/model.wapiti (size: 422671)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/figure/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/figure/model.wapiti
févr. 19, 2021 7:33:32 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/header/model.wapiti (size: 15734670)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/header/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/header/model.wapiti
févr. 19, 2021 7:33:57 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/affiliation-address/model.wapiti (size: 2699936)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/affiliation-address/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/affiliation-address/model.wapiti
févr. 19, 2021 7:34:03 PM org.grobid.core.engines.ProcessEngine createTraining
INFOS: 1 files processed.

With the pull request
$ java -Xmx4G -jar grobid-core/build/libs/grobid-core-0.6.1-onejar.jar -gH grobid-home -dIn Input -dOut Output -exe createTraining

févr. 19, 2021 7:38:56 PM org.grobid.core.main.GrobidHomeFinder getGrobidHomePathOrLoadFromClasspath
AVERTISSEMENT: No Grobid property was provided. Attempting to find Grobid home in the current directory...
févr. 19, 2021 7:38:56 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: ***************************************************************
févr. 19, 2021 7:38:56 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: *** USING GROBID HOME: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home
févr. 19, 2021 7:38:56 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: ***************************************************************
févr. 19, 2021 7:38:56 PM org.grobid.core.main.GrobidHomeFinder getGrobidHomePathOrLoadFromClasspath
AVERTISSEMENT: No Grobid property was provided. Attempting to find Grobid home in the current directory...
févr. 19, 2021 7:38:56 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: ***************************************************************
févr. 19, 2021 7:38:56 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: *** USING GROBID HOME: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home
févr. 19, 2021 7:38:56 PM org.grobid.core.main.GrobidHomeFinder findGrobidHomeOrFail
AVERTISSEMENT: ***************************************************************
févr. 19, 2021 7:38:56 PM org.grobid.core.main.GrobidHomeFinder findGrobidPropertiesOrFail
AVERTISSEMENT: Grobid property file location was not explicitly set via 'org.grobid.property' system variable, defaulting to: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/config/grobid.properties
févr. 19, 2021 7:38:56 PM org.grobid.core.utilities.GrobidProperties getEnvironmentVariableOverrides
INFOS: environment variables overrides: {}
févr. 19, 2021 7:38:56 PM org.grobid.core.main.LibraryLoader load
INFOS: Loading external native sequence labelling library
févr. 19, 2021 7:38:56 PM org.grobid.core.main.LibraryLoader load
INFOS: Loading Wapiti native library...
févr. 19, 2021 7:38:56 PM org.grobid.core.main.LibraryLoader load
INFOS: Native library for sequence labelling loaded
févr. 19, 2021 7:38:56 PM org.grobid.core.lexicon.Lexicon initDictionary
INFOS: Initiating dictionary
févr. 19, 2021 7:38:56 PM org.grobid.core.lexicon.Lexicon initDictionary
INFOS: End of Initialization of dictionary
févr. 19, 2021 7:38:56 PM org.grobid.core.lexicon.Lexicon initNames
INFOS: Initiating names
févr. 19, 2021 7:38:56 PM org.grobid.core.lexicon.Lexicon initNames
INFOS: End of initialization of names
févr. 19, 2021 7:38:57 PM org.grobid.core.lexicon.Lexicon initCountryCodes
INFOS: Initiating country codes
févr. 19, 2021 7:38:57 PM org.grobid.core.lexicon.Lexicon initCountryCodes
INFOS: End of initialization of country codes
test.pdf
1 files to be processed.
Input/test.pdf
févr. 19, 2021 7:38:57 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/fulltext/model.wapiti (size: 21913642)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/fulltext/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/fulltext/model.wapiti

Warning, father not yet encountered! id is 1
Warning, father not yet encountered! id is 1
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 11
Warning, father not yet encountered! id is 11
Warning, father not yet encountered! id is 11
Warning, father not yet encountered! id is 11

févr. 19, 2021 7:39:00 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/segmentation/model.wapiti (size: 27668093)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/segmentation/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/segmentation/model.wapiti

Warning, father not yet encountered! id is 1
Warning, father not yet encountered! id is 1
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 3
Warning, father not yet encountered! id is 11
Warning, father not yet encountered! id is 11
Warning, father not yet encountered! id is 11
Warning, father not yet encountered! id is 11

févr. 19, 2021 7:39:05 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/reference-segmenter/model.wapiti (size: 4921245)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/reference-segmenter/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/reference-segmenter/model.wapiti
févr. 19, 2021 7:39:05 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/citation/model.wapiti (size: 16412787)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/citation/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/citation/model.wapiti
févr. 19, 2021 7:39:07 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/figure/model.wapiti (size: 422671)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/figure/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/figure/model.wapiti
févr. 19, 2021 7:39:07 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/header/model.wapiti (size: 15734670)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/header/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/header/model.wapiti
févr. 19, 2021 7:39:32 PM org.grobid.core.jni.WapitiModel init
INFOS: Loading model: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/affiliation-address/model.wapiti (size: 2699936)
[Wapiti] Loading model: "/Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/affiliation-address/model.wapiti"
Model path: /Users/bouge/Repositories/no_save/tmp/grobid-0.6.1/grobid-home/models/affiliation-address/model.wapiti
févr. 19, 2021 7:39:38 PM org.grobid.core.engines.ProcessEngine createTraining
INFOS: 1 files processed.

I think the parsing has to fail at this point, explicitly, not to continue, because the overall outline is not valid and we should not use it. So raising an exception is needed... and for me there is no bug, it's a necessity to have a parsing failure, though I agree that the "GRAVE" or "SEVERE" is misleading (there is no impact on GROBID output because outline is not used currently).
We could have this:
if (father == null)
	throw new GrobidResourceException(Father not yet encountered! id is " + currentParentId, e);
currentNode.setFather(father);

and then catch this particular exception to log it as warn in the calling class DocumentSource.java.

Yes, I agree. An important point is to raise a GrobidResourceException right there. Let me update my pull request agreeingly, labeling the error with something less stressing that SEVERE.
NB: I spotted another occurrences of the same phenomenon. In that case, the exception is caught at line 356 in Document.java. It seems to be of the same nature. Let me have a closer look at it.

I think the parsing has to fail at this point, explicitly, not to continue, because the overall outline is not valid and we should not use it. So raising an exception is needed... and for me there is no bug, it's a necessity to have a parsing failure, though I agree that the "GRAVE" or "SEVERE" is misleading (there is no impact on GROBID output because outline is not used currently).
We could have this:
if (father == null)
	throw new GrobidResourceException(Father not yet encountered! id is " + currentParentId, e);
currentNode.setFather(father);

and then catch this particular exception to log it as warn in the calling class DocumentSource.java.

I made the correction. Is it clear that it only aborts processing the faulty file, without interrupting the correct ones?

@lucbouge the test file that you shared, is it public? can be committed as a test case?

I've integrated only the outline in the test cases.
I've found few more bugs in that class, that I should have fixed hopefully without breaking anything else 😅

@lucbouge maybe we can update this PR if you position yourself in your repository and pull from the branch lucbouge-patch-1... I'm not sure it will work... something like...
git pull https://github.com/kermitt2/grobid.git lucbouge-patch-1