modem_quectel_bg9x does not initialize properly

Describe the bug
Zephyr BG9x driver does not work with Quectel BG95 modem's very well.
Please also mention any information which could help others to understand
the problem you're facing:

What target platform are you using? Custom board based on nRF52840 + BG95 modem
What have you tried to diagnose or workaround this issue? Yes, no solution
Is this a regression? If yes, have you been able to "git bisect" it to a
specific commit? Not sure.

To Reproduce
Steps to reproduce the behavior:

build project with config:

CONFIG_NETWORKING=y
CONFIG_NET_SOCKETS=y
CONFIG_MODEM=y
CONFIG_MODEM_QUECTEL_BG9X=y
CONFIG_MODEM_QUECTEL_BG9X_APN="hologram"

west build
west flash
check terminal (check full logs below):

modem_cmd_handler: command ATH ret:-5

Expected behavior
Modem should power up and initialize properly.
Impact
Unclear how the modem can be used considering this issue.
Logs and console output
# SEGGER J-Link RTT Viewer V7.66a Terminal Log File
# Compiled: 15:16:36 on May 19 2022
# Logging started @ 15 Mar 2023 11:15:03
00> [00:00:00.250,183] <inf> modem_quectel_bg9x: Setting Modem Pins
00> [00:00:01.004,821] <dbg> modem_cmd_handler: cmd_handler_process_rx_buf: RECV
00>                                             4e 4f 52 4d 41 4c 20 50  4f 57 45 52 20 44 4f 57 |NORMAL P OWER DOW
00>                                             4e                                               |N
00> [00:00:03.000,335] <inf> modem_quectel_bg9x: ... Done!
00> [00:00:03.000,366] <inf> modem_quectel_bg9x: Waiting for modem to respond
00> [00:00:53.000,427] <err> modem_quectel_bg9x: Timeout waiting for RDY
00> [00:00:53.000,640] <inf> main: Board: custom_nrf52840
00> [00:00:53.000,671] <inf> main: end program

Reset button pressed here

00> [00:00:00.250,183] <inf> modem_quectel_bg9x: Setting Modem Pins
00> [00:00:02.752,258] <dbg> modem_cmd_handler: cmd_handler_process_rx_buf: RECV
00>                                             52 44 59                                         |RDY
00> [00:00:02.752,319] <dbg> modem_cmd_handler: cmd_handler_process_rx_buf: match cmd [RDY] (len:3)
00> [00:00:03.000,305] <inf> modem_quectel_bg9x: ... Done!
00> [00:00:03.000,305] <inf> modem_quectel_bg9x: Waiting for modem to respond
00> [00:00:03.000,335] <dbg> modem_cmd_handler: modem_cmd_send_ext: SENT DATA
00>                                             41 54 45 30                                      |ATE0
00> [00:00:03.000,701] <dbg> modem_cmd_handler: cmd_handler_process_rx_buf: RECV
00>                                             41 54 45 30                                      |ATE0
00> [00:00:03.000,854] <dbg> modem_cmd_handler: cmd_handler_process_rx_buf: RECV
00>                                             4f 4b                                            |h cmd [OK] (len:2)
00> [00:00:03.051,025] <dbg> modem_cmd_handler: modem_cmd_send_ext: SENT DATA
00>                                             41 54 48                                         |ATH
00> [00:00:03.051,422] <dbg> modem_cmd_handler: cmd_handler_process_rx_buf: RECV
00>                                             45 52 52 4f 52                                   |ERROR
00> [00:00:03.051,452] <dbg> modem_cmd_handler: cmd_handler_process_rx_buf: match cmd [ERROR] (len:5)
00> [00:00:03.101,623] <err> modem_cmd_handler: command ATH ret:-5
00> [00:00:03.101,867] <inf> main: Board: custom_nrf52840
00> [00:00:03.101,867] <inf> main: end program
00> [00:00:05.446,899] <dbg> modem_cmd_handler: cmd_handler_process_rx_buf: RECV
00>                                             41 50 50 20 52 44 59                             |APP RDY
(Connection lost)

Environment (please complete the following information):

OS: Windows
Toolchain: gnuarmemb
Commit SHA or Version used: Zephyr version: 3.2.0

Additional context
BG95 modem internally has mdm-power-gpios connected to the same pin as mdm-reset-gpios. Because of this reason the custom board does not have control over mdm-power-gpios. Since this pin is mandatory from DTS file perspective, mdm-power-gpios is mapped to the same pin as mdm-reset-gpios.

BG95 modem internally has mdm-power-gpios connected to the same pin as mdm-reset-gpios. Because of this reason the custom board does not have control over mdm-power-gpios. Since this pin is mandatory from DTS file perspective, mdm-power-gpios is mapped to the same pin as mdm-reset-gpios.

If the driver has been designed around having a power pin and a reset pin, and you are combining those 2 into a single pin, then you're misusing the driver.

this is the information that is provided by Quectel (from BG95 datasheet). Because of this, there is no need for controlling the mdm-power-gpios pin since its the same as mdm-reset-gpios ?

One option may be to make mdm-power-gpios optional instead of required.

That is a good suggestion, however I've noticed that actually mdm-reset-gpios is not [actually] used, so I've made a patch to remove this dependency. However, this did not fix the issue, the same issue is present.
From 7db204ce8a37e8025009fb1b6e15cdf460000906 Mon Sep 17 00:00:00 2001
Date: Wed, 15 Mar 2023 17:12:38 +0100
Subject: [PATCH] hotfix: removed mdm_reset_gpios pin dependency

---
 drivers/modem/quectel-bg9x.c         | 4 ++++
 dts/bindings/modem/quectel,bg9x.yaml | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/modem/quectel-bg9x.c b/drivers/modem/quectel-bg9x.c
index 75d49c4caf..f06f751c3f 100644
--- a/drivers/modem/quectel-bg9x.c
+++ b/drivers/modem/quectel-bg9x.c
@@ -22,7 +22,9 @@ static K_KERNEL_STACK_DEFINE(modem_workq_stack, CONFIG_MODEM_QUECTEL_BG9X_RX_WOR
 NET_BUF_POOL_DEFINE(mdm_recv_pool, MDM_RECV_MAX_BUF, MDM_RECV_BUF_SIZE, 0, NULL);

 static const struct gpio_dt_spec power_gpio = GPIO_DT_SPEC_INST_GET(0, mdm_power_gpios);
+#if DT_INST_NODE_HAS_PROP(0, mdm_reset_gpios)
 static const struct gpio_dt_spec reset_gpio = GPIO_DT_SPEC_INST_GET(0, mdm_reset_gpios);
+#endif
 #if DT_INST_NODE_HAS_PROP(0, mdm_dtr_gpios)
 static const struct gpio_dt_spec dtr_gpio = GPIO_DT_SPEC_INST_GET(0, mdm_dtr_gpios);
 #endif
@@ -1195,11 +1197,13 @@ static int modem_init(const struct device *dev)
 		goto error;
 	}

+#if DT_INST_NODE_HAS_PROP(0, mdm_reset_gpios)
 	ret = gpio_pin_configure_dt(&reset_gpio, GPIO_OUTPUT_LOW);
 	if (ret < 0) {
 		LOG_ERR("Failed to configure %s pin", "reset");
 		goto error;
 	}
+#endif

 #if DT_INST_NODE_HAS_PROP(0, mdm_dtr_gpios)
 	ret = gpio_pin_configure_dt(&dtr_gpio, GPIO_OUTPUT_LOW);
diff --git a/dts/bindings/modem/quectel,bg9x.yaml b/dts/bindings/modem/quectel,bg9x.yaml
index 3cc1eb01c9..795650ec91 100644
--- a/dts/bindings/modem/quectel,bg9x.yaml
+++ b/dts/bindings/modem/quectel,bg9x.yaml
@@ -14,7 +14,7 @@ properties:

     mdm-reset-gpios:
       type: phandle-array
-      required: true
+      required: false

     mdm-dtr-gpios:
       type: phandle-array
--
2.38.1.windows.1

I think the problem is that maybe later BG95 documentation show this difference:

Hence, I think that by using "APP RDY" instead of "RDY" fixes the issue for BG95 (specifically).

That is a good suggestion, however I've noticed that actually mdm-reset-gpios is not used, so I've made a patch to remove this dependency. However, this did not fix the issue (it behaves the same).
From 7db204ce8a37e8025009fb1b6e15cdf460000906 Mon Sep 17 00:00:00 2001
Date: Wed, 15 Mar 2023 17:12:38 +0100
Subject: [PATCH] hotfix: removed mdm_reset_gpios pin dependency

---
 drivers/modem/quectel-bg9x.c         | 4 ++++
 dts/bindings/modem/quectel,bg9x.yaml | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/modem/quectel-bg9x.c b/drivers/modem/quectel-bg9x.c
index 75d49c4caf..f06f751c3f 100644
--- a/drivers/modem/quectel-bg9x.c
+++ b/drivers/modem/quectel-bg9x.c
@@ -22,7 +22,9 @@ static K_KERNEL_STACK_DEFINE(modem_workq_stack, CONFIG_MODEM_QUECTEL_BG9X_RX_WOR
 NET_BUF_POOL_DEFINE(mdm_recv_pool, MDM_RECV_MAX_BUF, MDM_RECV_BUF_SIZE, 0, NULL);

 static const struct gpio_dt_spec power_gpio = GPIO_DT_SPEC_INST_GET(0, mdm_power_gpios);
+#if DT_INST_NODE_HAS_PROP(0, mdm_reset_gpios)
 static const struct gpio_dt_spec reset_gpio = GPIO_DT_SPEC_INST_GET(0, mdm_reset_gpios);
+#endif
 #if DT_INST_NODE_HAS_PROP(0, mdm_dtr_gpios)
 static const struct gpio_dt_spec dtr_gpio = GPIO_DT_SPEC_INST_GET(0, mdm_dtr_gpios);
 #endif
@@ -1195,11 +1197,13 @@ static int modem_init(const struct device *dev)
 		goto error;
 	}

+#if DT_INST_NODE_HAS_PROP(0, mdm_reset_gpios)
 	ret = gpio_pin_configure_dt(&reset_gpio, GPIO_OUTPUT_LOW);
 	if (ret < 0) {
 		LOG_ERR("Failed to configure %s pin", "reset");
 		goto error;
 	}
+#endif

 #if DT_INST_NODE_HAS_PROP(0, mdm_dtr_gpios)
 	ret = gpio_pin_configure_dt(&dtr_gpio, GPIO_OUTPUT_LOW);
diff --git a/dts/bindings/modem/quectel,bg9x.yaml b/dts/bindings/modem/quectel,bg9x.yaml
index 3cc1eb01c9..795650ec91 100644
--- a/dts/bindings/modem/quectel,bg9x.yaml
+++ b/dts/bindings/modem/quectel,bg9x.yaml
@@ -14,7 +14,7 @@ properties:

     mdm-reset-gpios:
       type: phandle-array
-      required: true
+      required: false

     mdm-dtr-gpios:
       type: phandle-array
--
2.38.1.windows.1

for this particular issue (the DTS part) I've created a PR to address it: https://github.com/zephyrproject-rtos/zephyr/pull/57110

I think the problem is that maybe later BG95 documentation show this difference:
Hence, I think that by using "APP RDY" instead of "RDY" fixes the issue for BG95 (specifically).

For this particular issue, the expected unsolicited mdm response has to change. This means there is need for another BG95 define so that the correct string is picked up on the initialization of the modem? e.g.:
CONFIG_MODEM_QUECTEL_BG9x_UNSOL_RDY="APP RDY" // BG95 --> where default case (BG96) should be "RDY"

?

I think the problem is that maybe later BG95 documentation show this difference:
Hence, I think that by using "APP RDY" instead of "RDY" fixes the issue for BG95 (specifically).

For this particular issue, the expected unsolicited mdm response has to change. This means there is need for another BG95 define so that the correct string is picked up on the initialization of the modem? e.g.:
CONFIG_MODEM_QUECTEL_BG9x_UNSOL_RDY="APP RDY" // BG95 --> where default case (BG96) should be "RDY"

?

Give it a try!

This fix is included now so this issue can be closed.


No close method on test client

Trying to update a cookbook to mysql cookbook 6.x and database 3.x. When calling mysql_database_user, I get a NoMethodError on close.
Code at error is:
        def close_test_client
          @test_client.close
        rescue Mysql2::Error
          @test_client = nil
        end

I'm not sure right now why @test_client is nil at this point. Will try to debug this and provide more information and maybe a fix, why not :).
NoMethodError: mysql_database_user[git] (gitlab::database_mysql line 44) had an error: NoMethodError: undefined method `close' for nil:NilClass
/tmp/kitchen/cookbooks/database/libraries/provider_database_mysql_user.rb:164:in `close_test_client'
/tmp/kitchen/cookbooks/database/libraries/provider_database_mysql_user.rb:46:in `ensure in block in <class:MysqlUser>'
/tmp/kitchen/cookbooks/database/libraries/provider_database_mysql_user.rb:46:in `block in <class:MysqlUser>'
/opt/chef/embedded/apps/chef/lib/chef/provider/lwrp_base.rb:60:in `instance_eval'
/opt/chef/embedded/apps/chef/lib/chef/provider/lwrp_base.rb:60:in `recipe_eval_with_update_check'
/opt/chef/embedded/apps/chef/lib/chef/provider/lwrp_base.rb:45:in `block in action'
/opt/chef/embedded/apps/chef/lib/chef/provider.rb:145:in `run_action'
/opt/chef/embedded/apps/chef/lib/chef/resource.rb:582:in `run_action'
/opt/chef/embedded/apps/chef/lib/chef/runner.rb:49:in `run_action'
/opt/chef/embedded/apps/chef/lib/chef/runner.rb:81:in `block (2 levels) in converge'
/opt/chef/embedded/apps/chef/lib/chef/runner.rb:81:in `each'
/opt/chef/embedded/apps/chef/lib/chef/runner.rb:81:in `block in converge'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/resource_list.rb:83:in `block in execute_each_resource'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:116:in `call'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:116:in `call_iterator_block'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:85:in `step'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:104:in `iterate'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/resource_list.rb:81:in `execute_each_resource'
/opt/chef/embedded/apps/chef/lib/chef/runner.rb:80:in `converge'
/opt/chef/embedded/apps/chef/lib/chef/client.rb:315:in `converge'
/opt/chef/embedded/apps/chef/lib/chef/client.rb:400:in `block in run'
/opt/chef/embedded/apps/chef/lib/chef/client.rb:399:in `catch'
/opt/chef/embedded/apps/chef/lib/chef/client.rb:399:in `run'
/opt/chef/embedded/apps/chef/lib/chef/application.rb:261:in `block in fork_chef_client'
/opt/chef/embedded/apps/chef/lib/chef/application.rb:249:in `fork'
/opt/chef/embedded/apps/chef/lib/chef/application.rb:249:in `fork_chef_client'
/opt/chef/embedded/apps/chef/lib/chef/application.rb:215:in `block in run_chef_client'
/opt/chef/embedded/apps/chef/lib/chef/local_mode.rb:38:in `with_server_connectivity'
/opt/chef/embedded/apps/chef/lib/chef/application.rb:201:in `run_chef_client'
/opt/chef/embedded/apps/chef/lib/chef/application/solo.rb:245:in `block in interval_run_chef_client'
/opt/chef/embedded/apps/chef/lib/chef/application/solo.rb:234:in `loop'
/opt/chef/embedded/apps/chef/lib/chef/application/solo.rb:234:in `interval_run_chef_client'
/opt/chef/embedded/apps/chef/lib/chef/application/solo.rb:224:in `run_application'
/opt/chef/embedded/apps/chef/lib/chef/application.rb:58:in `run'
/opt/chef/embedded/apps/chef/bin/chef-solo:25:in `<top (required)>'
/opt/chef/bin/chef-solo:40:in `load'
/opt/chef/bin/chef-solo:40:in `<main>'

The problem was that the client was unable to connect to the database. I thought that using nil for socket would be ok, but it seems not. Hence, the method test_client was failing and then the ensure block in the user present query code was called.
Since the @test_client was nil, instead of reporting the right error saying Can't connect to local MySQL server through socket '/var/lib/mysql/mysql.sock' (2), it was failing with a NoMethodError.
I prepared a PR where mysql clients closing are guarded by nil test to ensure the method close is called only when the instance is set.

FYI, setting nil as :socket is probably not related to why I was not able to connect to MySQL in the first place, sorry for this false information. The rest of the bug report is still correct however.

And for my connection problem, here the trick. I was specifying the host as localhost. It appears that localhost is kind of magic for mysql as it forces socket connection if available. Since with the new mysql cookbook, the service is not at the default location anymore, the default socket /var/lib/mysql/mysql.sock is not working.
Using <IP_ADDRESS> instead of localhost` make it worked correctly.

I'm getting the same error:
================================================================================
Error executing action `create` on resource 'mysql_database_user[gogs]'
================================================================================

NoMethodError
-------------
undefined method `close' for nil:NilClass

Cookbook Trace:
---------------
/root/chef-solo/cookbooks-2/database/libraries/provider_database_mysql_user.rb:164:in `close_test_client'
/root/chef-solo/cookbooks-2/database/libraries/provider_database_mysql_user.rb:46:in `ensure in block in <class:MysqlUser>'
/root/chef-solo/cookbooks-2/database/libraries/provider_database_mysql_user.rb:46:in `block in <class:MysqlUser>'

Resource Declaration:
---------------------
# In /root/chef-solo/cookbooks-3/paas/definitions/database_user.rb

 16: 		mysql_database_user params[:name] do
 17: 			connection  mysql_connection_info
 18: 			password    params[:password]
 19: 			host        params[:host] || "localhost"
 20: 			action      :create
 21: 		end
 22:

Compiled Resource:
------------------
# Declared in /root/chef-solo/cookbooks-3/paas/definitions/database_user.rb:16:in `block in from_file'

mysql_database_user("gogs") do
  params {:action=>:enable, :password=>"xxx", :name=>"gogs"}
  provider Chef::Provider::Database::MysqlUser
  action [:create]
  retries 0
  retry_delay 2
  username "gogs"
  host "localhost"
  privileges [:all]
  cookbook_name :hosting
  recipe_name "databases"
  connection {:host=>"<IP_ADDRESS>", :port=>3306, :username=>"root", :password=>"xxx", :socket=>"/run/mysql-default/mysqld.sock"}
  password "xxx"
end

It seems that I had the 5.6 mysql client installed from dotdeb. I pinned the 5.5 debian package and now it works.


Nested components

Hi,
The component's doc said component can be nested
But my sample example doesnt work ?
https://jsfiddle.net/zepg5b09/13/
Did i forgot something ?

Your uipanel component has a template of:

This is a Component!

Since this template does not contain a uibutton, it will not display uibutton. To use a uibutton inside, you have to change the template:

This is a Component! <uibutton></uibutton>

Alternatively, you can use a <slot>.
Moon.component('uipanel', {
  template: "
This is a Component! <slot></slot>
"
});

As you can see, I added the slot element in the template. This is a special component that will replace itself with the elements passed to the component like you attempted. You can use it like:
<uipanel>
  <uibutton></uibutton>
</uipanel>

Thank you for the answer and the example.
It's clearer on how to use it.

No problem @mfaessel. I'm closing this issue, but feel free to reach out for other help.


Feat: add flags to the CLI

Add flags to the CLI (https://github.com/line/create-liff-app/issues/19)
I added some flag descriptions, but I am unsure if they sound natural (I am not a native speaker).
Please double-check the descriptions in README.md and the CLI help message!
Changes:

create-liff-app now accepts one optional argument and various flags: @line/create-liff-app [project name] [options].
After running @line/create-liff-app -h, will print the following help message:

Usage: @line/create-liff-app [project name] [options]

Options:
  -v, --version              output the version number
  -t, --template <template>  Choose a template to bootstrap the app with (choices: "vanilla", "react", "vue", "svelte", "nextjs", "nuxtjs")
  -l, --liffid <liff id>     Liff id. For more information, please visit https://developers.line.biz/ja/docs/liff/getting-started/
  --js, --javascript         Initialize as a JavaScript project
  --ts, --typescript         Initialize as a TypeScript project
  --npm, --use-npm           Bootstrap the app using npm
  --yarn, --use-yarn         Bootstrap the app using yarn
  -h, --help                 display help for command

NOTE:
The answers object currently has no type, as I do not know how to automatically infer the values from questions.
Rather than explicitly create a type for it I decided to leave it like that since answers will not be referenced by anything.
But still, I'll make it full type-safe if that sounds better to you.

Thank you so much for the help!
I learned a lesson and will stay away from testing until I know what I'm doing😅

I see!

The documentation release will be on July 11th :sweat_smile:
It sounds too late so we will release this PR first and will wait for the doc update.
Thank you!


Extra Claims mapping requires cache solution

@damienbod can you give me some more information about that fix as I used the claims transformation solution from the before version?

fixed


Slideshow favorites button

Good day dev.
Please add a favorites button to the slideshow viewer, for ease of use.

Slideshow is not there for interaction. You can use the regular mode for that.

With all due respect, it serves me how I see fit.
The thing is it's a waste of time to leave the slideshow to like a picture.
If the button was right there, I'd never have to leave the slideshow to like another one. Please understand.


show gif overlay on non transcoded gifs

@keybase/react-hackers this is ready

(pending flow fix)


⚠ Bofrost.at has degraded performance

In be8e292, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1241 ms

Resolved: Bofrost.at performance has improved in 6afcf9a.


import: Fix import and export parallelism defaults.

I went with the"half of the number of (available) cpus" approach https://docs.python.org/3/library/os.html#os.sched_getaffinity Or do we want to just use 2?
Fixes #14960.
The default of 6 thread may not be appropriate in certain
configurations. Taking half of the numer of CPUs available to the
process will be more flexible.

This is great, merged, thanks @mateuszmandera!  We find nobody needs to actually set the setting with this, but I don't think it hurts to have it.


No way to issue a 'yum install srvadmin-all'

On dell hardware it's useful to be able to install the full srvadmin package so you can get the web interface up and running.  This is currently missing from the vendortools automation however.
It's also the default approach provided by dell here: https://linux.dell.com/repo/hardware/OMSA_7.4.0/
It would be great to have a simple hiera flag that defaults forces an 'install everything' command. ie: "vendortools::dell::installall: true"

I'd like to leave this issue open, as I'd eventually like to incorporate this idea.

Fine with me!  One thing I'm discovering unfortunately is that the dell tools don't always update cleanly, which isn't the fault of this package that's on dell.  It seems some older repositories still installed 32-bit libraries (dell_ie* packages) which eventually causes updates to fail.  If I get a chance I may make a few adjustments to this piece and the vmware piece (doesn't work in rhel7 but there's no error checking in the code currently) and send over a pull request.


Fix monochrome logo spacing and mac tray icon (fixes #293 and #294)

Issue: closes #294 (also closes #293)
Requirements

[x]  issue was opened to discuss proposed changes before starting implementation.
[x]  during development, node version specified in package.json was used.
[x]  package versions and package-lock.json were not changed (npm install --no-save).
[x]  app version number was not changed.
[x]  all new code has tests to ensure against regressions. (No new code; no new tests)
[ ] npm run lint reports no offenses. (There were many error outputted, but none were related to my commits)
[x] npm run test is error-free.
[ ]  README and CHANGELOG were updated accordingly. (Not sure how to do this)

Description of the Change

The stretchly logo (stretchly.svg) was changed from aligning the path from the center:

to aligning to the edges:

The menu bar icons in app/images have been re-exported with the correct dimensions (16x22px)

Verification Process
I verified that the fixed icon was the correct size by measuring the pixel width and height of the icon in the menu bar.
Before:

After:

Other information
There are other assets/screenshots in the project that could be updated to reflect the fixed icon.

Looks good! I guess other screens will be updated if there is something else changed, this is small change for those screens.

Please add yourself to readme https://github.com/hovancik/stretchly#contributors ;]

Just added myself to the readme, anything else I should do?


Adds ESP32-WroverKit LUA config and fixes LEDs setup

Summary
This PR adds a new configuration to Xtensa esp32-wrover-kit board that includes Lua Interpreter, MMCSD SPI support, User Leds and also Buttons.
It fixes an issue with conflicting User LEDs in this board when a combination of MMCSD and Buttons is selected.
User LEDs uses GPIO 0, 2 and 4.
MMCSD uses GPIO 2 as MISO
Buttons uses GPIO 0 as Input
Therefore, the fix tests if any of those are used and sets the remaining GPIOs for User LEDs, depending on the selected configuration.
Impact
None.
Testing
Using Configs: leds, buttons, mmcsd and lua. All of them worked correctly.

@SuGlider please squash and rebase your branch

@SuGlider please squash and rebase your branch

Done. Let me know if this is all fine.

Thank you guys!


fix some typos and general improvements

I fixed some typos and made some suggestions, feel free to merge them or make changes to it.

Thank you @takahser, you are officially an Imbue contributor!


Wagtail 6.0

Support ticket
Wagtail 6.0 release notes
Summary of changes

Added Wagtail 6.0 compatibility
Added tests for Django 5.0
Added tests for Python 3.12
Replace deprecated wagtail.contrib.modeladmin with wagtail_modeladmin
Wagtail 6.0 upgrade consideration: Deprecated WidgetWithScript base widget class

Current blocker

The test_blocks_can_render_widget_code test case is failing with the error

AttributeError at /admin/example_app/product/create/
'BlockWidget' object has no attribute '_block_json'

The issue is similar to this one:
https://github.com/labd/wagtailstreamforms/issues/200
There might have been a rework on the ChooserWidget or a deprecation which took effect on Wagtail v6.0

Any update on the issue? I'm facing the same error with wagtail v6.1. But, it was fine with v6.0.3.


Use onKeyDown rather than onKeyPress consistently across HoistInputs.

Also added onKeyDown prop to desktop TextArea, for symmetry with other inputs & mobile.
#1040

This looks great to me.  See my tiny tweak to help ensure a safe transition to the API.


Suggestion: Support the "Powah" mod

Let grow uraninite on a uraninite block.

OK, it is supported in Forge-1.17.0.


Read repair - configure to repair primary only

By default, the behaviour should be unchanged.  however it is now configurable to read repair primary vnodes only - fallback vnodes will not be repaired on failing GETs, they will only receive new PUTs.
See schema change for more details.
https://github.com/basho/riak_test/pull/1369

The change from do_diffobj_put/3 to do_handoff_put/3 breaks the test https://github.com/basho/riak_test/blob/develop-3.0/tests/overlap_with_crdt_tag.erl

Need to consider UpdateHooks as well - https://github.com/basho/riak_kv/blob/riak_kv-3.0.12/src/riak_kv_vnode.erl#L3665-L3667 - if we use the general PUT code should the reason by a PutArg, and passed through?  Only impacts the deprecated Yokozuna.


Fix file_system dependency

Hi :wave:
We recently hit a dependency resolution failure where a package (lightning_css) depended on not-too-old file_system ~> 0.2.10 and hence conflicted with phoenix_live_reload's dependency. I've submitted a patch to this package as well to bump the dep to v1.0.0, but some more research led to the following interesting find:

file_system used to be called ExFsWatch more than 7 years ago. This package had versions going up to v0.4.2
After the rename to file_system, version numbering started again at v0.1.1 and went up to v0.2.10 until version was bumped to v1.0.0. Weirdly enough, this all happens in the same repository and there are tags for all versions.
There never was a file_system v0.3.0 and the dependency in mix.exs is wrong. Looking at recent changes, it seems safe to still include v0.2.10.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


Readme.md code fails when using tensorflow==2.0.0 but works with tensorflow==2.3.1

If I install ISR using pip install ISR, then try to run code per the readme.md, I get errors. For instance, attempting to run the following:
from ISR.models import RDN
rdn = RDN(weights='psnr-small')

produces an error regarding failure to .decode('utf8')
However, if I force the installation of tensorflow==2.3.1 rather than the required tensorflow==2.0.0, I don't get any errors and I'm able to run the readme.md code. As suggested by https://github.com/idealo/image-super-resolution/issues/126, others seem to be having similar issues that are resolved by using the most recent tensorflow version.

Hello What was the solution to the
AttributeError: 'str' object has no attribute 'decode' error? How did you fix the .decode('utf8') issue?


Beta release code review

This PR is simply to review recent developments before the upcoming Beta release. The change-set is limited to changes since the last review process ended with PR #8

At our next meeting I would like to see a full demonstration of the driver, maybe running through the test scenarios / IOCs that you have

OK, I'm all reviewed out now! Done ✔
We can discuss the comments above, most are small and relatively easy to improve on.
I think the big things to focus on to really improve this code-base would be:

Adding Doxygen documentation - and CI to autobuild it.
Refactor the very long/complex parsing functions even further and add in a unittest framework.

See for example areaDetector Boost unittests: https://github.com/areaDetector/ADCore/tree/master/ADApp/pluginTests
Or perhaps pick up Catch2 like another popular EPICS framework competitor

Some very nice-to-have to improve code quality would be to add code linting to CI. Modern static analysis tools can often find potential future bugs 😄

Closing this pull request as most of the requests have been implemented now directly on the main branch.


Client stops accepting skill inputs

I am playing from the EU on the NA datacentre and I discovered a problem where while using this my client will completely stop reacting to all skill inputs after a brief time. This follows this log message: https://github.com/Soreepeong/XivMitmLatencyMitigator/blob/0d853f3a396fb77d44414f9cfe0a2efee0685cae/mitigate.py#L479
I was seemingly able to get around the problem by raising EXTRA_DELAY (to 0.125) but it is still quite worrying as it could suddenly turn me into a waste of space during an instance and I'm not sure how reliable my workaround is. The only way to make the client accept skill input again is to log out and back in. Do you have any idea what's happening?

Pretty sure the reason for this is the message after this will show a modified animation lock of a negative number (i.e. -500ms~ for me), I added a check to see if hte wait time is below 0 and corrected it to EXTRA_DELAY if that happens as a temporary fix but i dont know if this is the way to go

Rawrington's right - Yeah, the animation lock would become not right when a negative value is given. Comparing source code with the Windows version of the addon, I missed adding non-negative guarantee for this one. I just fixed it and am testing it right now.
Also, it now saves log to a file in /tmp too. If it's still causing problems, please attach the log file.

The problem was actually about me writing opcode for action rejection wrong. It's now fixed. curl'ing might not reflect the most recent changes right way, in which case, you might have to use git clone https://github.com/Soreepeong/XivMitmLatencyMitigator.git instead.

I have played a five hour session just now and did not encounter the issue again, thank you for fixing it, and also for making this in the first place. The difference is night and day, and classes like MCH are actually unplayable without.


Moving and updating "aspnet-webpack" package in templates

Updated packages.json in templates regarding #203 issue.

Hi @dopare, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dopare, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;


optimize messages for scholars for mobile

Such  as the leaderboard and !mydata command

Maybe use something like this instead of inline=True, https://plaintexttools.github.io/plain-text-table/

Is this really necessary, since we need to write a custom script for generating those tables


--atomic --cleanup-on-fail with leftover objects from original release leads to rollback failure

Output of helm version:
 version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"clean", GoVersion:"go1.13.12"}
Output of kubectl version:
 Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.2", GitCommit:"59603c6e503c87169aea6106f57b9f242f64df89", GitTreeState:"clean", BuildDate:"2020-01-18T23:30:10Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.15-gke.4300", GitCommit:"7ed5ddc0e67cb68296994f0b754cec45450d6a64", GitTreeState:"clean", BuildDate:"2020-10-28T09:23:22Z", GoVersion:"go1.13.15b4", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): GKE
Take any helm chart (I tried it on helm guestbook). Follow these steps

helm install guestbook helm-guestbook
Add nameOverride: foo_bar in the values.yaml
Run helm upgrade --atomic --cleanup-on-fail guestbook helm-guestbook
Upgrade fails and throws the following error
Error: UPGRADE FAILED: an error occurred while rolling back the release. original upgrade error: failed to create resource: Service "guestbook-foo_bar" is invalid: metadata.name: Invalid value: "guestbook-foo_bar": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?'): no Service with the name "guestbook-helm-guestbook" found

To be specific, no Service with the name "guestbook-helm-guestbook" found is the error thrown when rollback is attempted. This is because, when the upgrade fails, resources from the older release were still present and when helm attempts to rollback, it comes to this piece of code
https://github.com/helm/helm/blob/5d08a0d00e4f0d31d6db55e71bccbcd665366c9a/pkg/kube/client.go#L215
Helm expects that the objects from the older release would be present in the failed release but they aren't which leads to the above error. We could modify the code slightly to continue if it comes across a scenario where the objects from the older release are present but are not a part of the failed release. Helm can safely ignore them. However, since this change would be in a generic piece of code which is also used for upgrade, I don't have the complete idea of its impact on other pieces of code.
Another thing we could do is, add some documentation around this scenario so the user is aware of what's happening in case they run into the above issue because the error is not very helpful (since the object from the old release exists)

Hi @vadasambar. Can you please test and verify this is still an issue with a newer version of Helm? Helm v3.5.0 is the latest release. I do recall there was some patches to the upgrade/rollback resource resolution recently. It is possible that this behaviour has already been fixed in a more recent release.

Hi @vadasambar. Can you please test and verify this is still an issue with a newer version of Helm? Helm v3.5.0 is the latest release. I do recall there was some patches to the upgrade/rollback resource resolution recently. It is possible that this behaviour has already been fixed in a more recent release.

Hey @bacongobbler , sorry for the late reply. Ran into the same issue for both master and 3.5.0.
With master (6c010ec6)
Error: UPGRADE FAILED: an error occurred while rolling back the release. original upgrade error: failed to create resource: Service "guestbook-foo_bar" is invalid: metadata.name: Invalid value: "guestbook-foo_bar": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?'): no Service with the name "guestbook-helm-guestbook" found

With 3.5.0 commit ID,
Error: UPGRADE FAILED: an error occurred while rolling back the release. original upgrade error: failed to create resource: Service "guestbook-foo_bar" is invalid: metadata.name: Invalid value: "guestbook-foo_bar": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?'): no Service with the name "guestbook-helm-guestbook" found

With the PR fix
Error: UPGRADE FAILED: release guestbook failed, and has been rolled back due to atomic being set: failed to create resource: Service "guestbook-foo_bar" is invalid: metadata.name: Invalid value: "guestbook-foo_bar": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')


Please push a release to Hackage

Amongst other things, this will allow me to undo https://github.com/NixOS/nixpkgs/pull/22268 which I have been itching to do for months.

@gibiansky please?

@Anrock Thank you for the bump. Will do this week.

@Anrock @vaibhavsagar Version <IP_ADDRESS> has been uploaded. I also pushed a commit updating the version number in the cabal file. This may affect other packages; if it does so, let me know. I also only uploaded ihaskell, not versions of ipython-kernel or other packages.

Hey @gibiansky, can you push a new ghc-parser (and preferably ipython-kernel) release as well? I can't use ihaskell as a dependency because it depends on updates and changed version bounds in ghc-parser that are not on Hackage.

Alright, how about now?

Waiting for the new ipython-kernel to propagate to the mirror I'm using, give me a few more minutes :smile:.

Okay, it works for me if I set the binPkgDb flag to False in my stack.yaml. Would you consider merging my PR and cutting a new ihaskell release, maybe <IP_ADDRESS>?

Done.

Wonderful, thanks so much!


Adding configuration for class loading matching and logging class source

Related to https://discuss.elastic.co/t/kibana-apm-not-showing-capturespan-and-capturetransaction/173026 - even if not fixes this one, class loading has side effects and needs to be configurable

Why do you think disabling the class loader matcher may help in the linked case? Is the class loader pre matcher problematic when there are annotations on the class path twice? What negative side effects are there when loading a class which would otherwise not be loaded?

Codecov Report

Merging #548 into master will decrease coverage by 2.16%.
The diff coverage is 73.68%.

@@             Coverage Diff              @@
##             master     #548      +/-   ##
============================================
- Coverage     65.21%   63.04%   -2.17%
  Complexity       68       68
============================================
  Files           180      180
  Lines          7189     6813     -376
  Branches        860      779      -81
============================================
- Hits           4688     4295     -393
- Misses         2252     2258       +6
- Partials        249      260      +11

Impacted Files
Coverage Δ
Complexity Δ

...tic/apm/agent/configuration/CoreConfiguration.java
96.12% <100%> (-2.07%)
0 <0> (ø)

...java/co/elastic/apm/agent/bci/ElasticApmAgent.java
75.62% <50%> (+0.15%)
0 <0> (ø)
:arrow_down:

...apm/agent/bci/bytebuddy/CustomElementMatchers.java
83.78% <60%> (-9.08%)
0 <0> (ø)

.../apm/agent/report/serialize/DslJsonSerializer.java
81.84% <0%> (-6.41%)
0% <0%> (ø)

...pm/agent/report/IntakeV2ReportingEventHandler.java
76.23% <0%> (-5.15%)
0% <0%> (ø)

...a/co/elastic/apm/agent/report/ReporterFactory.java
78.26% <0%> (-0.91%)
0% <0%> (ø)

.../main/java/co/elastic/apm/agent/impl/MetaData.java
100% <0%> (ø)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659570d...2ceefc6. Read the comment docs.

Why do you think disabling the class loader matcher may help in the linked case?

The user gets Caused by: java.lang.LinkageError: loader (instance of  org/apache/catalina/loader/ParallelWebappClassLoader): attempted  duplicate class definition for name: "javax/ws/rs/Path" in his logs. I didn't bother to look for the WebappClassLoaderBase code to see why it doesn't find the defined class and tries to define it again during the execution of findClassInternal. It could even be something weird that prevents it from finding a defined class even if it uses the same jar. However, it happens with the agent and doesn't happen without it, and that's the only reason I could see how that might be, other than a BB bug that we never encountered before.

What negative side effects are there when loading a class which would otherwise not be loaded?

For example- it might have dependencies that are either missing or that you are going to cause loading on a wrong timing (where other dependencies are not available or where a static init does something). It is always risky to change the order/location of class loading in an existing environment. In many cases it is exposes problems that were not occurring just due to order of execution. I would even argue that you may want to set this config option to false by default, but we can wait and see if we get more of those. We currently load very limited number of classes, but should be aware of that.

Caused by: java.lang.LinkageError: loader (instance of org/apache/catalina/loader/ParallelWebappClassLoader): attempted duplicate class definition for name: "javax/ws/rs/Path"

That really sounds like the class loader matcher may be causing this. But I think it's probably worth verifying that first. So let's wait for the user's feedback?

But I think it's probably worth verifying that first. So let's wait for the user's feedback?

Sure, we can wait, but I think we need this (hidden) config and logging regardless (as I explained in the former comment), which is why I did this PR without waiting for the response.


Minecraft server envMap values that default to true can't be made false

In this line of the envMap snippet, you can see that if a value, like onlineMode, is set to false, it won't even include the variable.  The problem is that if ONLINE_MODE defaults to true, it's absense will make it true, even though it's set to false in the helm chart values.
The fix would be to remove the if and always include a variable or you could default everything to false in the minecraft container.  I think you would have a big support problem if you defaulted everything to false, so I'd assume you want to just remove the if statement here and always set an env variable.
https://github.com/itzg/minecraft-server-charts/compare/minecraft-4.5.0...minecraft-4.7.4#diff-6388d0bd6acdc6fb5c4741f9392e7f16a04efd7dcd4ebde73fe24af5db7e4c00R29

Maybe there's a CI thing we can do here to pull the tagged image down if it's changed in values & update the deployment; or just completely delegate configuration to the image instead of duplicating efforts here

just completely delegate configuration to the image instead of duplicating efforts here

That's exactly what I've been trying to push for.
In any case, PRs are very welcome @ClashTheBunny 😀

...in the meantime I'll revert that commit. That was just me trying make helm less annoying.

I really like the way you did it, but I do appreciate the revert until it can solve this edge case!

That's exactly what I've been trying to push for.

Without a major version bump on the chart, the only way I can conceive of deprecating .Values.minecraftServer predictably would be to:

throw the envMap back in with the chart defaults, but prefix the target names they're rendered to with something like MIGRATE_.
add an initContainer that compares the [default] variables set in the tagged server container

weaves in the delta between the two, sets of variables
optionally throw a depreciation warning up in the console (perhaps include a a reformatted Helm values.yaml for ease of migration to the next major chart version)

Tag a major version after this, rip all the complexity out of the chart, winner winner 🍗

If we can get itzg/docker-minecraft-server#1439 somewhere, it would be a neat way to avoid things like this.
Akin to API versions, the config structure could contain the schema version and could be transformed between versions in a more consistent way.

@billimek @gtaylor can one of you step in here and take over? I don't have the time or mental energy to maintain these charts anymore.

Hey @itzg, I don't think I'm interested in maintaining these anymore. It may be time to mark these as archived and move on to other things.
Thanks for carrying them forward as long and well as you did!

I had an epiphany: in PR #157 I am introducing the concept of a "default" value for the boolean fields. When those fields are "default", they will be left out of the rendered manifest. When the usual true or false, they will be included.


Separate free mint and follow mint to different processes

Thanks for the free mint tool, jungleninja!
I saw the free_mint was blocked by follow_mint, and separated the free_mint and follow_mint to different processes. Long time no touch of Python, hope it make the mint info more up to date instead of screwing up the process, lol.
Best.

Hi, you are amazing, thank you for your work, but eth blockchain single account with multiple transactions at the same time causes lag, which creates uncertainty, that's why I added "loop_status" and "cancel_mint", ( ps: my code level is very poor, this requires us to work together)

Ah, got it. Did not get that far with eth api. Could you please point out which lines you are mainly concerned about? I can try to add process lock around them when I get time. Thx!

Hi, you are amazing, thank you for your work, but eth blockchain single account with multiple transactions at the same time causes lag, which creates uncertainty, that's why I added "loop_status" and "cancel_mint", ( ps: my code level is very poor, this requires us to work together)

AltLayer Airdrop Season One Announcement

Exciting news! AltLayer token (ALT) is set to launch on Binance on January 25, 2024. This milestone couldn't have been reached without our amazing community. Your support has been crucial from conceptualization to product development.
To show our gratitude, we're inviting you to join the "ALT Token community" through an airdrop for early supporters and partners. Below is a summary:

Total Allocated ALT Tokens: 300,000,000 (3% of total supply)
Distribution Categories:

NFT Holders
Altitude Campaign Participants
EigenLayer Restakers
EigenLayer Ecosystem Partners
Celestia Stakers and others

For detailed criteria and information, check the full announcement here.
Claim opens from January 25 to February 25, 2024. Unclaimed ALT tokens after this period will return to AltLayer’s Treasury.
Thank you for being part of AltLayer's success! More to come in Season One, stay tuned.
Note: Certain regions are restricted from the airdrop. Please review the disclaimer before participating.
Winners: @nothingnix, @codewithgun, @plotchy, @lynnsir-102, @DariusPrzydzial, @Tosadguy, @CJParry, @aussedatlo, @whchengaa, @ZandtLavish, @surajsrivats, @angtsusiong, @Fcukkkkkkman, @128jku9j, @ycyraum, @rkreutz, @jekkos, @Chenxinjie65, @Code0x2, @sragss

Blastoff.zone Airdrop: Win 0.1 ETH + $100 Bonus!

Hello crypto community! Blastoff.zone is offering an exciting Airdrop for the first 10 users! You can win 0.1 ETH plus a $100 bonus just by participating and connecting your wallet.
How to participate:

Click Connect Wallet to access the Blastoff.zone website.
Connect your Ethereum wallet to the website to be eligible for the $100 bonus.
Use the "Claim Now" method to receive your tokens.

Don't miss out on this amazing opportunity! Hurry and claim your prize before the 0.1 ETH runs out.
Remember, tokens will be distributed on a first-come, first-served basis. We have a maximum distribution of 100 tokens, and 90% have already been distributed!
CootieShots, @PilotDebug, @yjlolo, @zohra-moh, @anusssss34, @shcorya, @hzj5016, @ernieyang09, @jontstaz, @nosalt99, @BI-NOP, @LenBob2021, @Soonogo, @jeremi, @ksbg, @Tovi-A, @crispspruce, @johnrjj, @caijikun, @rheostat


Chrome 114 profiler output change result in speedscope not rendering the stack trace anymore

I noticed the Chrome 114 has changed the profiler json output (also increased the size by a factor of 5-30 in some cases!). Loading the new format in speedscope results in speedscope not rendering the actual JavaScript stack trace, but something like this. I also noted there are multiple "tracks" now (whatever the top dropdown is basically):

In 113 the normal flamegraph is shown... Not sure if this is a Chrome-side issue or a speedscope side problem right now.
I check all of the "Tracks" and the stack trace is no where to be found...

Ahhh thanks for the heads up. That's a huge bummer -- a fatal problem with building tools on proprietary file formats.
Not sure when I'll have time to look at this, but good to know.
If someone else would like to take a crack at this, https://github.com/jlfwong/speedscope/blob/main/src/import/chrome.ts is the code that deals with current versions of the chrome profile format.
On a chance guess, I'll bet they switched to using the trace event format described here: https://github.com/jlfwong/speedscope/blob/main/src/import/trace-event.ts

Thanks for the quick response. It's a huge disappointment indeed. I use speedscope almost daily just for the merged flamegraph (left heavy) so I can see the hotspot of an application. I guess I can downgrade to 113 but it's a hassle. If I have some time I might look into this, but it's unclear if I'll have time.
Further, what was like a 10MB trace can be now like 400+MB. Just processing this file will be quite time and memory consuming...

Okay, I can repro the issue. I'll look into it

@shuhaowu Thanks for the report, the fix should be live on https://www.speedscope.app/ now!


Keras backend

Task list:
WGAN_GP
Evaluation metric
Loss specific

@Sinha-Raunak
Keras needs to be added to requirements.txt , can you add another commit with the change?

@Sinha-Raunak couple of things ?
can you please briefly describe in pull request comment, whats are things have been added for For keras backend ?

What you mean by keras backend.
What are GANs supported ? I see, there are couple of models added by you.
https://github.com/IBM/gan-toolkit/blob/74b8a9f786cb88b6c0a1d34d0890e1cebe9881fc/agant/argument_parser.py#L53 in help text you are asking query to user, just say provide the backed information and also tell 0 for pytorch and 1 keras.
isn't it better to have some default value ? if its not specified by user ?
Please try to add more descriptive comment for commits like: adding cgan, wgan, vanila gan for keras backend

Could you please follow best practices in following direction

Add doc string comment at top of every file py file, about what that code is. Instead of one common line.
Please follow this naming module_name, package_name, ClassName, method_name, ExceptionName, function_name, GLOBAL_CONSTANT_NAME, global_var_name, instance_var_name, function_parameter_name, local_var_name
following should be lower case.
https://github.com/IBM/gan-toolkit/blob/74b8a9f786cb88b6c0a1d34d0890e1cebe9881fc/agant/make_models.py#L33


Update Ug for duplicate and near duplicates

Fixes #296
Where do u want me to add the duplicate message warning on start up.

Where do u want me to add the duplicate message warning on start up.

Hmm... I think this might be a good place: Editing the data file?

Where do u want me to add the duplicate message warning on start up.

Hmm... I think this might be a good place: [Editing the data file](https://github.com/AY2122S1-CS2103T-W16-1/tp/tree/master/docs/UserGuide.md#Editing-the-data-fi

Is this really a good place though? Having a duplicate warning doesn't really have anything to do with editing the data file.

Normally yes, but the only way to see a near duplicate warning on start up is to have added the client with add command, or by editing the JSON file. Using the add command has its own warning while editing JSON directly won't throw a warning until donnafin is run. My idea is that if that's the case, the user should just know that this could happen while editing the file.
Tbh I honestly wonder if my PR of watching for near duplicates is more trouble than it's worth.... If this feature doesn't fit well, I strongly recommend reverting my on app start alert message. In other words, keep the add command warning, but don't bother checking at start for duplicates. This would make UG DG easier (and honestly invites less trouble as we don't need to defend against 'new feature' accusations).

:warning:
Affected by #316 , wait on that to merge.


Unable to deny container to container traffic

I can't seem to block traffic container to container within a network. Here's my exact steps to reproduce. I'm running on a Pi, so I'm using the RC (the only tag with an ARM build).
My environment (all sane defaults, deny all for dfw)
root@raspberrypi:/home/zoot/dfw# uname -a
Linux raspberrypi 5.15.32-v8+ #1538 SMP PREEMPT Thu Mar 31 19:40:39 BST 2022 aarch64 GNU/Linux

root@raspberrypi:/home/zoot/dfw# lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux 11 (bullseye)
Release:	11
Codename:	bullseye

root@raspberrypi:/home/zoot/dfw# cat docker-compose.yml
version: '3'
services:
  dfw:
    cap_add:
      - NET_ADMIN
    image: pitkley/dfw:1.3.0-rc.1
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro
      - /home/zoot/dfw:/rules:ro
    command: --config-path /rules
    network_mode: host

root@raspberrypi:/home/zoot/dfw# cat *.toml
[global_defaults]
external_network_interfaces = "eth0"
default_docker_bridge_to_host_policy = "accept"

[backend_defaults]
custom_tables = { name = "filter", chains = ["input", "forward"] }

[container_to_wider_world]
default_policy = "drop"

[container_to_host]
default_policy = "drop"

[container_to_container]
default_policy = "drop"

[[container_to_container.rules]]
network = "test"
verdict = "reject"

root@raspberrypi:/home/zoot/dfw# cat /etc/nftables.conf
#!/usr/sbin/nft -f

flush ruleset

table inet filter {
	chain input {
		type filter hook input priority 0;
	}
	chain forward {
		type filter hook forward priority 0;
	}
	chain output {
		type filter hook output priority 0;
	}
}

Now some setup
function dping(){ docker run --rm --network=$1 alpine ping -W 1 -c 1 <IP_ADDRESS> > /dev/null && echo "Success" || echo "Failure"; }

function c2cping(){
  c=$(docker run --rm -d --network=$1 alpine sleep 100 | head -c12)
  docker run --rm --network=$1 alpine ping -W 1 -c 1 $c > /dev/null && echo "Success" || echo "Failure"
  docker rm -f $c;
}

root@raspberrypi:/home/zoot/dfw# docker network create test
3a1babd472e87033c6ef4780ab2eddab1b9f7a37d8e45ec94641c48f17c2e4af

Now for the test
# The following is expected to fail, a container can't reach out
root@raspberrypi:/home/zoot/dfw# dping test
Failure

# This SHOULD have failed, but the containers were able to ping each other
root@raspberrypi:/home/zoot/dfw# c2cping test
Success
0a5c210b53a6

# For good measure, here's my nft rules
root@raspberrypi:/home/zoot/dfw# nft list ruleset
table inet filter {
	chain input {
		type filter hook input priority filter; policy accept;
		ct state invalid drop comment "DFW-MARKER:defaults;filter;input;ct-state-invalid-drop"
		ct state { established, related } accept comment "DFW-MARKER:defaults;filter;input;ct-state-relatedestablished-accept"
		meta mark & 0x000000df == 0x000000df accept comment "DFW-MARKER:defaults;filter;input;meta-mark"
	}

	chain forward {
		type filter hook forward priority filter; policy accept;
		ct state invalid drop comment "DFW-MARKER:defaults;filter;forward;ct-state-invalid-drop"
		ct state { established, related } accept comment "DFW-MARKER:defaults;filter;forward;ct-state-relatedestablished-accept"
		meta mark & 0x000000df == 0x000000df accept comment "DFW-MARKER:defaults;filter;forward;meta-mark"
	}

	chain output {
		type filter hook output priority filter; policy accept;
	}
}
table inet dfw {
	chain input {
		type filter hook input priority filter - 5; policy accept;
		ct state invalid drop
		ct state { established, related } accept
		iifname "docker0" meta mark set 0x000000df accept
		iifname "br-4dec2f473c5f" meta mark set 0x000000df drop
		iifname "br-9c563ed167fd" meta mark set 0x000000df drop
		iifname "br-3a1babd472e8" meta mark set 0x000000df drop
		iifname "br-c4abb2913698" meta mark set 0x000000df drop
	}

	chain forward {
		type filter hook forward priority filter - 5; policy drop;
		ct state invalid drop
		ct state { established, related } accept
		iifname "docker0" oifname "eth0" meta mark set 0x000000df accept
		iifname "br-3a1babd472e8" oifname "br-3a1babd472e8" meta mark set 0x000000df reject
		iifname "br-4dec2f473c5f" oifname "eth0" meta mark set 0x000000df drop
		iifname "br-9c563ed167fd" oifname "eth0" meta mark set 0x000000df drop
		iifname "br-3a1babd472e8" oifname "eth0" meta mark set 0x000000df drop
		iifname "br-c4abb2913698" oifname "eth0" meta mark set 0x000000df drop
	}
}
table ip dfw {
	chain prerouting {
		type nat hook prerouting priority dstnat - 5; policy accept;
	}

	chain postrouting {
		type nat hook postrouting priority srcnat - 5; policy accept;
		oifname "eth0" meta mark set 0x000000df masquerade
	}
}
table ip6 dfw {
	chain prerouting {
		type nat hook prerouting priority dstnat - 5; policy accept;
	}

	chain postrouting {
		type nat hook postrouting priority srcnat - 5; policy accept;
		oifname "eth0" meta mark set 0x000000df masquerade
	}
}

Hi @Nayruden, thank you for reaching out and sorry for this delayed response. This problem is actually documented, although it is not trivial to find (https://dfw.rs/latest/dfw/types/struct.ContainerToContainer.html#filtering-traffic-within-the-same-bridge):

Filtering traffic within the same bridge
Depending on how your host is configured, traffic whose origin and destination interface are the same bridge is not filtered by the kernel netfilter module. This means that this default policy is not honored for traffic between containers that are on the same Docker network, but only for traffic that traverses two bridges.
If your kernel has the br_netfilter kernel-module available, you can set the sysctl net.bridge.bridge-nf-call-iptables to 1 to have the netfilter-module act on traffic within the same bridge, too. You can set this value temporarily like this:
sysctl net.bridge.bridge-nf-call-iptables=1

To permanently set this configuration, take a look at man sysctl.d and man sysctl.conf.

I hope the above helps your issue. I will see if I can update the documentation within this repository to make finding this information easier! :+1:

Sure enough, that was my problem! Thanks for following up!


fix: reconciliation documentation link display type

inline is the default type for  elements and block causes the links to be stacked vertically.

I think stacking the links vertically was intentional, no? Could you maybe add some screenshots of how it looks before and after?

I don't think it is intentional given how it pushes the main content further down.
Vertically:

Horizontally:

I don't love either version. The horizontal layout doesn't really parse as two separate links to my eye and the vertical version adds unnecessary whitespace (when there's a ton of space available in the header above).

Can the @OpenRefine/designers team help with?

I'd be in favor of removing the "Access service API" link anyway, since it's not designed to be viewed by users directly. We will be displaying the URLs (#5878) with #6118. Then the "Service documentation" link would be alone and it would solve the dilemma.

@Abbe98 would it make sense for you to simply remove the service API link now that #6118 is merged (meaning that the link is displayed earlier)?

@wetneb no I consider that covering a rather different usecase and I think such a change deserves its own thread independently from this.

Okay, so here is a PR for that change: #6284.

@Abbe98 now that we removed the API URL in #6284, this change will not have an effect anymore, although the underlying problem is still there (although it only pushes content down as much as the API URL link used to).
Do you want to revisit this (moving the documentation link elsewhere, perhaps) or should we close the PR?

Closing per above, feel free to reopen to move the link somewhere else.

The display type is unrelated to the above and should be fixed anyway.

Sorry about that then! As far as I can tell the PR does not make a visual difference anymore at least. Can you expand on why the current display type is wrong and should be changed?

The browser default for a elements is inline, suddenly switching it to block might cause side-effects down the road or just cause pain for someone trying to debug the layout.

Ok, if the motivation is to clean this up then I'd suggest migrating to using jQuery's .hide() and .show() instead of setting inline CSS explicitly.

Yes that would be the better approach with the same effect.


fix: datalineageDocLink

What type of PR is this?

[x] bug
[ ] feature
[ ] enhancement

What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:

close: #481


Drum Samples - format and triggering

The readme has question marks on the drum sample format. File formats can be easily changed with Sox:
http://sox.sourceforge.net/
ie
C:\Users\simon\Downloads\B1 FOUR_v1.10_Win_E\effects>"c:\Program Files (x86)\sox-14-4-2\sox.exe" -r 44100 -e signed-integer -b 16 -c 1 Snr1.raw Snr1.wav
Does anyone know whether individual samples can be triggered remotely (via the USB connection)?

here's a batch file I used to conert the samples from v2.00:
convert.zip

I very much doubt they are triggerable externally. There's no sign that the patterns are MIDI data  as far as I remember going through the firmware. Just a simple player with an adjustable clock for deltas to base timings on.

In Linux you can convert all the raw samples to wav, and back to raw with the following two scripts.
This will also work in Windows 10 if you have Linux (eg. Ubuntu) installed under WSL.
You'll need to install "sox" first: "sudo apt get install sox" in Ubuntu.
raw2wav.sh:
#!/bin/sh

for i in *.raw; do
  sox -t raw -r 44100 -b 16 -c 1 -L -e signed-integer $i `basename "$i" .raw`.wav
done

wav2raw.sh:
#!/bin/sh

for i in *.wav; do
  sox $i -r 44100 -b 16 -c 1 -L -e signed-integer `basename "$i" .wav`.raw
done


Is there a way to customize timeout for Http3 request?

I'm using h3::Connection::send_request and send_body to send Http3 request. Is there a way to set a timeout for a particular h3 request? (I cannot find it in the config or h3 API). Thanks.

quiche runs pretty close to the protocol level and while QUIC defines a connection-level timeout, it doesn't define one for streams. quiche allows endpoints to control the idle timeout period as part of the configuration.
quiche's H3 layer is quite thin and focused on the H3 protocol wire format, which also does not have a concept of a stream timeout. so there is no explicit request timeout in quiche.
Since QUIC or H3 protocols don't define request timeouts, such a feature in the quiche library would have to be custom. In addition, its not clear this would be a benefit to applications for the reasons in the next paragraph.
quiche helps people send or receive HTTP messages; there are many aspects of HTTP semantics that need to handled by applications using these messages. Timeouts are a good example, an app using the quiche library could to run its own timers measuring TTFB, time between headers and payload, time between DATA chunks, etc. and decide itself how to act.
I'm not really sure there is anything quiche can do to help that wouldn't already be better handled in a higher level. But maybe you can explain more?


CI for Node

App
✕ Contains the compiled JavaScript
Game
Game
✕ Initializes with two players
✕ Starts the game with a random player
nextPlayer
✕ Sets the current player to be whoever it is not


how does z define the depth information of the key point?

The output coordinates of hand key points are x,y,z y and z, where x and y can be multiplied by the width and height of the image to get the position of the key point in the image, so how does z define the depth information of the key point? Is it the distance between the key point and the camera or the distance between the key point and the wrist?

Hi @lucker26,
The hand model uses a method called "scaled orthographic projection," which combines orthographic projection with scaling to imitate perspective. This assumes that all points on a 3D object are approximately at the same distance from the camera.
The reason for using this method is that it closely approximates perspective, especially when the depth variation along the line of sight is small compared to the fixed average depth. This helps prevent distortion of objects at a distance due to perspective, allowing for uniform scaling instead.
The model predicts a relative depth (z) based on the average depth of a "typical hand" (in scenarios like holding a phone with one hand). The range of z is not limited, but it scales proportionally with x and y through weak projection and uses the same units as x and y.
There is a central landmark point (wrist) to which all other landmark depths are relative. These depths are normalized using weak projection with respect to x and y coordinates.
Additionally, we recommend that you please read through this thread for a better understanding.
Thank you


Update OIDC Okta plugin doc

Summary

Updated the OIDC Okta auth plugin docs because it wasn't clear which values needed to be configured.
Reason

#4578
Testing

/gateway/latest/kong-plugins/authentication/oidc/okta/

Pulled the changes from the other PR into this PR, and added Diana's changes to it.


error in NB2 aez.readCropandCropCycleParameters

hi, there is an error. When I run the aez.readCropandCropCycleParameters. I set these index as nan, but the optional thermal screening function is still activated.

Hi @handuGIS,
Instead of setting nan as #N/A, just nan will do. Hope this helps.
Swun Wunna Htet

hi @NokuzaSezo97,  I took your advice, but the same error still exists

Hi @handuGIS,
I just tested and discovered a minor bug which the thermal screening flag is activated even when the threshold values are not provided, thus encountering this error. I'll fix this bug immediately. Kindly redownload or clone the master repository tomorrow for accessing the revised version. My sincere apologies for the delay.
Regards,
Swun Wunna Htet

ok! thank you very much for your reply. Hope you solve this bug smoothly.


Rename GitHub org to Stolostron for release 2.2

https://github.com/stolostron/backlog/issues/18994
Signed-off-by: Philip Wu<EMAIL_ADDRESS>

/retest

/test all


Start the 3.0.0 cycle

@chrisnojima @mmaxim @maxtaco
Let's go arbitrary version numbers!

I was thinking it would be cool to roll up to 3.0.0 when the wallet is out for everyone. Maybe 2.10?

@mmaxim I didn't want to think about whether we have any accidental lexical comparisons, e.g. 2.10.0 < 2.2.0.  What'd you think?

Think it is unlikely, I'm not aware of anything that uses this number other than the updater which does the normal semver comparison.


aws-sdk-go-v2 - v1.3.0

Description of your changes
aws-sdk-go-v2 latest - https://github.com/aws/aws-sdk-go-v2/releases/tag/v1.3.0
go 1.16 supported for providers as part of https://github.com/upbound/build/pull/140

Fixes #
https://github.com/crossplane/provider-aws/issues/383
I have:

[X] Read and followed Crossplane's contribution process.
[X] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Unit tests only

@chlunde I don't think we have a written plan but having a release -> merging this -> having another release right after that could be a good idea.

I wonder if provider-aws should have a freeze until this is merged?

Most changes coming into provider-aws are code-generated resources which use v1 SDK, so I don't think we need a freeze for PRs.

@chlunde I don't think we have a written plan but having a release -> merging this -> having another release right after that could be a good idea.

seeing that 0.19 was released a few days ago, maybe now is a good time? It would unblock a few things for us (e.g. #610, #338 )

What is the plan for merging this?

Thanks for pushing an update @smcavallo ! The PR was waiting an action from me but I couldn't get to it for quite a while, having a month-long leave in between.
I'll review as soon as possible.

we need this also to support Spot Instances for EKS https://github.com/crossplane/provider-aws/issues/228


vs code can not find source mapping for ts files

Great work and great blog. I have started in minutes.
I have tried to debug as per your guidelines:
$ mocha --debug-brk
vs code attach

I can debug generated js code, but VS Code can not set a breakpoint on ts files (can not find source map file)
It would be great to improve the template with a gulp task to execute 'mocha --debug-brk' automatically on debugger attach click. I am new to javascript, npm, etc... so it is unlikely I can figure it out quickly. Appreciate your help.
It would be great to have some ideas on how to continuously run unit tests (maybe in command line) without wallaby. At the moment I can not afford to buy their license.

Again thanks for the nice template.

Hi @avkonst I will try to work on this when I have a chance but it might take me some time because I'm working a lot on another project. If you know how to do it I would be happy to accept a pull-request. Thanks for the feedback :smile:

Hi, @remojansen  if you give me an idea of what I need to look at and change, I might do something. Otherwise, I have got no idea. Thanks.

I have upgraded this to TS 2.0 added CI and enabled greenkeper so the example is always up to date 🚀
You can use the gulp watch task to observe changes and build and run tests automatically.


Added a count() api

Added a count() public api to return the current number of toasts.

What is the use case?

I keep a history of all alerts with the ability to show/hide them on request.
Show alerts => clear current toasts (if any) then create toasts for all alertsHide alerts => clear current toastsClear alerts => clear current toasts and alerts history
Show alerts: active/visible if alerts.length > 0Hide alerts: active/visible if toasts.length > 0Clear alerts: active/visible if alerts.length > 0
I need toastr.count() to properly activate/show the "Hide alerts" option
Tim
Date: Fri, 20 Nov 2015 07:42:33 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [angular-toastr] Added a count() api (#142)
What is the use case?
—
Reply to this email directly or view it on GitHub.

I am thinking that it is something that should be done in userland. You have a very concrete usage of toasts, and I think that you can keep your own registry of toasts and that registry could give you the length of toasts you have.
I will give this a thought and see if it could be helpful in here or not.

I could keep a registry of toasts etc. but that seems pretty expensive and a little error prone. I think a count() api is a pretty innocent addition and might help others too.But your call, obviously :-)
Date: Fri, 20 Nov 2015 07:55:49 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [angular-toastr] Added a count() api (#142)
I am thinking that it is something that should be done in userland. You have a very concrete usage of toasts, and I think that you can keep your own registry of toasts and that registry could give you the length of toasts you have.
I will give this a thought and see if it could be helpful in here or not.
—
Reply to this email directly or view it on GitHub.

Yeah, not a big deal.
Write tests for it and I merge it.

I don't like your tests to be honest (I wouldn't create that matcher) but don't worry. Will fix that myself and merge it tomorrow.

I renamed it to active and I merged it.


Line 1082: bad argument #1 to 'resolve'

I'm on the most recent CC:T version for 1.18.2 which is 1.101.3. How would I resolve this error?

You need to give it a file to play.

Ah gotcha. Sorry for wasting your time


[BUG] Cannot allocate memory on iOS 16 sometimes

Describe the bug

IOS16.3 选择照片偶尔出现闪退
How to reproduce

Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
Error occurred.

Expected behavior

Screenshots (If contains)

Version information

Device: [e.g. iPhone X]
OS: [e.g. iOS 14.7.1]
Package Version: [e.g. 2.4.1]
Flutter Version: [e.g. v2.5.0]

Additional context

可以尝试新版是否还有问题


In Firefox the animation in buttons is absent when you press the Space key to activate the button

Steps to reproduce the behavior:

Go to https://react-magma.cengage.com/version/2.3.12/api/dropdown/
Click on the first dropdown button 2 times
Press the Space key on the dropdown button 2 times
Pay attention to the button

Expected behavior
The animation in the button is present
Desktop:

Windows 10
Firefox 89.0

Additional context
The animation isn't displayed on any buttons, dropdown buttons, icon buttons
https://user-images.githubusercontent.com/72541410/125260365-f08dcb00-e308-11eb-867a-0bc2c5799394.mp4

Verified the issue. I spent some time trying to figure out the cause and I can't track it down. Our usage for Firefox compared to Chrome is low and the focus behavior is not impeded so we won't be spending more time on this issue.


New benchmark

Could you include benchmark comparing these projects (only for xlsx):
https://github.com/ChrisHodges/ExcelToEnumerable
https://github.com/ChrisHodges/LightweightExcelReader

@mnickw , of course, you can add the project read and save code by PR


Enable auditctl to continue adding rules even if it find errors in some of them

Hi!
We would like to set audit rules for a default set of components/packages, if the package is installed we audit it, otherwise, we ignore it.
Would it be possible to add the "-c" flag to "audit.rules.begin.fragment.erb" to allow auditctl to continue adding rules even if it find errors in some of them?

This should not be fixed by #37


Unique constraints do not detect the changeset unique_constraint/3

So, I have a very simple unique constraint set up, but for some reason it keeps saying this:
If you would like to stop this constraint violation from raising an
exception and instead add it as an error to your changeset, please
call `unique_constraint/3` on your changeset with the constraint
`:name` as an option.

I am using PlanetScale, so perhaps that is the issue? I have no idea.
Versions
MySQL: 8.0.21-Vitess
Elixir: 1.14.2
MyXQL 0.6.3
db_connection: 2.4.3
This is my migration.
defmodule Server.Repo.Migrations.CreateConnections do
  use Ecto.Migration

  def change do
    create table(:connections) do
      add(:sender_id, :string)
      add(:receiver_id, :string)
      add(:status, :string)

      timestamps()
    end

    create(
      unique_index(:connections, [:sender_id, :receiver_id],
        name: :connections_sender_id_receiver_id_index
      )
    )
  end
end

And this is the schema.
defmodule Server.Connections.Connection do
  use Ecto.Schema
  import Ecto.Changeset

  schema "connections" do
    field(:receiver_id, :string)
    field(:sender_id, :string)
    field(:status, Ecto.Enum, values: [:pending, :accepted, :rejected], default: :pending)

    timestamps()
  end

  @doc false
  def changeset(connection, attrs) do
    connection
    |> cast(attrs, [:sender_id, :receiver_id, :status])
    |> validate_required([:sender_id, :receiver_id])
    |> validate_inclusion(:status, [:pending, :accepted, :rejected])
    |> unique_constraint([:sender_id, :receiver_id],
      name: :connections_sender_id_receiver_id_index
    )
  end
end

Am I doing something wrong here? Or is it perhaps another issue? Perhaps something related to Vitess?
This is the entire error.
[error] #PID<0.512.0> running Phoenix.Endpoint.SyncCodeReloadPlug (connection #PID<0.511.0>, stream id 1) terminated
Server: localhost:4000 (http)
Request: POST /api/connections
** (exit) an exception was raised:
    ** (Ecto.ConstraintError) constraint error when attempting to insert struct:

    * connections_sender_id_receiver_id_index' (errno 1062) (sqlstate 23000) (CallerID: l4g61f89hivug6cg702g): Sql: "insert into connections(receiver_id, sender_id, `status`, inserted_at, updated_at) values (:v1, :v2, :v3, :v4, :v5)", BindVars: {REDACTED (unique_constraint)

If you would like to stop this constraint violation from raising an
exception and instead add it as an error to your changeset, please
call `unique_constraint/3` on your changeset with the constraint
`:name` as an option.

The changeset defined the following constraints:

    * connections_sender_id_receiver_id_index (unique_constraint)

        (ecto 3.9.5) lib/ecto/repo/schema.ex:795: anonymous fn/4 in Ecto.Repo.Schema.constraints_to_errors/3
        (elixir 1.14.2) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2
        (ecto 3.9.5) lib/ecto/repo/schema.ex:780: Ecto.Repo.Schema.constraints_to_errors/3
        (ecto 3.9.5) lib/ecto/repo/schema.ex:761: Ecto.Repo.Schema.apply/4
        (ecto 3.9.5) lib/ecto/repo/schema.ex:369: anonymous fn/15 in Ecto.Repo.Schema.do_insert/4
        (server 0.1.0) lib/server_web/controllers/connection_controller.ex:15: ServerWeb.ConnectionController.create/2
        (server 0.1.0) lib/server_web/controllers/connection_controller.ex:1: ServerWeb.ConnectionController.action/2
        (server 0.1.0) lib/server_web/controllers/connection_controller.ex:1: ServerWeb.ConnectionController.phoenix_controller_pipeline/2
        (phoenix 1.7.2) lib/phoenix/router.ex:430: Phoenix.Router.__call__/5
        (server 0.1.0) lib/server_web/endpoint.ex:1: ServerWeb.Endpoint.plug_builder_call/2
        (server 0.1.0) lib/plug/debugger.ex:136: ServerWeb.Endpoint."call (overridable 3)"/2
        (server 0.1.0) lib/server_web/endpoint.ex:1: ServerWeb.Endpoint.call/2
        (phoenix 1.7.2) lib/phoenix/endpoint/sync_code_reload_plug.ex:22: Phoenix.Endpoint.SyncCodeReloadPlug.do_call/4
        (plug_cowboy 2.6.1) lib/plug/cowboy/handler.ex:11: Plug.Cowboy.Handler.init/2
        (cowboy 2.9.0) /home/allyedge/code/reanvue/server/deps/cowboy/src/cowboy_handler.erl:37: :cowboy_handler.execute/2
        (cowboy 2.9.0) /home/allyedge/code/reanvue/server/deps/cowboy/src/cowboy_stream_h.erl:306: :cowboy_stream_h.execute/3
        (cowboy 2.9.0) /home/allyedge/code/reanvue/server/deps/cowboy/src/cowboy_stream_h.erl:295: :cowboy_stream_h.request_process/3
        (stdlib 4.1.1) proc_lib.erl:240: :proc_lib.init_p_do_apply/3

Any help is appreciated, thanks!

thank you for the report!

connections_sender_id_receiver_id_index' (errno 1062)

the trailing ' in …index' looks pretty suspicious, maybe it prevents from matching the constraint name.
I believe it is not a myxql issue but an ecto_sql issue so let’s track it there. Can you reopen it in the latter? Before doing so if you could test your code (and/or come up with a minimal example, ideally a single file one like https://github.com/wojtekmach/mix_install_examples/blob/main/ecto_sql.exs) against stock MySQL server to see if it might be a planet scale related issue after all.


Is there a plan on supporting protobuf3.0

The project is really excellent, We are using it in our project, Is there a plan on supporting them in the near future?

no.
I don't like protobuffers now.

what's your favor now?

https://github.com/cloudwu/sproto

@mayflaver I modify some code to support proto v3. This may be help.
https://github.com/owent-contrib/pbc/tree/proto_v3

@owt5008137 how is your fork going?

@james-callahan
My fork just modify little codes to adapt for the repeated interger types of proto 3 (use packed=true for default), and it works well. But it still do not support the new types such as map、timestamp and etc, these types are useless for my projects now.
Hope helpful.


Update badge links in readme. Add trigger for main branch push.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@dd04023). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage        ?   76.00%
=======================================
  Files           ?        5
  Lines           ?      375
  Branches        ?        0
=======================================
  Hits            ?      285
  Misses          ?       90
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd04023...a764c76. Read the comment docs.


access log: add DYNAMIC_METADATA_UNQUOTED formatter

This is useful when you are using the header-to-metadata filter to clean
up headers and then you want to send that to the access log as plain, non
quoted, text.
Signed-off-by: Raul Gutierrez Segales<EMAIL_ADDRESS>

Per @fishcakez , DYNAMIC_METADATA_TRIM() is possibly a better name for this formatter. Thoughts?

Per @fishcakez , DYNAMIC_METADATA_TRIM() is possibly a better name for this formatter. Thoughts?

FWIW, I prefer DYNAMIC_METADATA_UNQUOTED() since we are already using it like that :-)

I have to say I'm leery of this change. Feels like we're in this perpetual state of adding more and more little tweeks for this format or that.

I know. I am also not super excited about having to add this, but I am not sure what other options we have.
There's no way to add internal formatters and the cleanest way for us to scrub/clean headers that needed to be logged is:

header-to-metadata -> apply regex
DYNAMIC_METADATA

but the latter isn't happy with old school logging (e.g.: plain)....

I think it should be possible to allow extensions to provide their own formatters. But maybe that's one extension type too many.

@zuercher so shall we let this one land or do we want to explore the extensions path?

FWIW we already have an extension point for access log filters. Having one for formatters seems like it might be worth it also.

The only problem I have with landing it that it's forever. I think I'd prefer some change to the parsing of DYNAMIC_METADATA(NAMESPACE:KEY) that triggered quote stripping.

The only problem I have with landing it that it's forever. I think I'd prefer some change to the parsing of DYNAMIC_METADATA(NAMESPACE:KEY) that triggered quote stripping.

Alas, I don't think it would be pretty because:

namespace should have reverse DNS format [0], but we don't really enforce that so we can't assume anything
key is really free form, so same thing

which means we can't -- cleanly -- add more parameters within the parentheses.
After the final ), we must have the max length param. We could make it such that 0 means unset, so
if you wanted an extra param -- without setting max length -- you'd end with:
DYNAMIC_METADATA(envoy.lb:foo.bar):0,true

to get what we want.... which is a bit yucky.
Hmm. Thoughts?
[0] https://github.com/envoyproxy/envoy/blob/master/include/envoy/network/filter.h#L276

FWIW we already have an extension point for access log filters. Having one for formatters seems like it might be worth it also.

Sounds like this would be the way forward then, given my above comment about extending DYNAMIC_METADATA()...

I think moving to extensions would be the best thing.
For the suffix to control output, you could have a further :-separated list of things. So :10:strip would limit length to 10 and strip quotes or just :strip would strip quotes without affecting the length.

Closing this in favor of #13411.


Category with no questions causes issues in review

Create a category with no questions assigned to it. Visit the review page. The table does not show and the graph causes an error.

See sentry error https://sentry.io/impactasaurus/web-app/issues/449156849/


Can I do keypoint occlusion with this library?

Suppose that I want to randomly put another image on top of the training image, or some synthetic erasing, the library has to tell me which points are occluded.
For example, if I have an image of a face with some keypoints, I want to put a finger image with transparent background on top of some of the keypoints (randomly), is this something achievable with this library?

I don't think what you want is part of the library. There is no occlusion flag associated with keypoints. There is also not yet an augmenter that pastes arbitrary images onto training images.

OK. Does this library support random erasing on a small image patch?

Also when I rotate or zoom the image, some of the keypoints will likely be outside the image, how do you deal with this problem for training a coordinate regression model? Do I need to just check the x and y if it's outside the image before calculating heatmap?

The library has CoarseDropout to remove larger sub-areas. Note though that the augmenter currently does not remove keypoints within these dropped areas. Depending on their size that may be desirable (small dropped areas) or undesirable (large dropped areas).
To remove keypoints you currently have to check manually the xy-coordinates. PR #487 will add KeypointsOnImage.clip_out_of_image() and the corresponding augmenter ClipCBAsToImagePlanes, which both remove keypoints outside of the image plane. But the patch is not yet merged.

OK. Got it. Thank you!


backpopulate archive videos

Pre-Flight checklist

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
Closes https://github.com/mitodl/ocw-studio/issues/1739
What's this PR do?
This PR adds a new management command, backpopulate_archive_videos, along with a batchable task behind it that does the actual work involved. The management command takes all Website objects, optionally filtered with --filter and does the following:

For each Website, find WebsiteContent objects where metadata.video_files.archive_url is not null
For each WebsiteContent object, find the associated video in the bucket specified by the --bucket argument and optionally the --prefix argument based on the path portion of metadata.video_files.archive_url
Sync the video we found to the buckets stored in these settings:

AWS_STORAGE_BUCKET_NAME
AWS_PREVIEW_BUCKET_NAME
AWS_PUBLISH_BUCKET_NAME
AWS_OFFLINE_PREVIEW_BUCKET_NAME
AWS_OFFLINE_PUBLISH_BUCKET_NAME

This work is being done as part of https://github.com/mitodl/hq/discussions/1197 and the reason we are moving the videos into all these different buckets is to truly import them into the ocw-studio system, as if the videos had been uploaded by content authors. Putting them into the storage and preview / publish buckets prevents a large sync from having to happen on each site after this command is run for the first time, as all the videos will already be in place. This allows us to deliver videos from legacy sites in mirror drives without having to conditionally pull the videos from a different bucket at build time depending on if the sites is considered "legacy" or not.
How should this be manually tested?

Make sure you have the following prerequisites set up (if unsure, check the readme):

Recent DB restore from production or RC with sync states and gdrive folders reset
Local Concourse integration configured and running
Local Minio integration configured and running
Theme assets pipeline pushed up to Concourse and run at least once
In your .env, these are the settings I used minus the minio user / password and aws access keys:

AWS_STORAGE_BUCKET_NAME=ol-ocw-studio-app
AWS_PREVIEW_BUCKET_NAME=ocw-content-draft
AWS_PUBLISH_BUCKET_NAME=ocw-content-live
AWS_ARTIFACTS_BUCKET_NAME=ol-eng-artifacts
RESOURCE_BASE_URL_DRAFT=https://draft.ocw.mit.edu
RESOURCE_BASE_URL_LIVE=https://live.ocw.mit.edu
STATIC_API_BASE_URL=https://live.ocw.mit.edu
OCW_HUGO_THEMES_BRANCH=main
OCW_HUGO_PROJECTS_BRANCH=main

Create a folder somewhere on your computer and open a terminal inside it
Run aws s3 sync s3://ocw-website-mirror/OcwExport/InternetArchive/MIT6.811F14/ ./
Log into your local Minio instance at http://localhost:9001 and:

Create a new bucket called ocw-website-mirror
In that bucket, create a folder called OcwExport, and in that folder create another folder called InternetArchive
In that folder create a folder called MIT6.811F14, then drag and drop the files we downloaded with the s3 sync command above into it

In ocw-studio, run docker compose exec web ./manage.py backpopulate_archive_videos --bucket ocw-website-mirror --prefix OcwExport/InternetArchive --filter 6-811-principles-and-practice-of-assistive-technology-fall-2014
After the command completes, log back into the Minio web interface at http://localhost:9001
Check the storage, preview and publish buckets listed above and verify that the videos have been copied into the appropriate places
Browse to http://localhost:8043/sites/6-811-principles-and-practice-of-assistive-technology-fall-2014/ and publish the site live
Back in Minio, verify in the preview and publish buckets that the videos have not been removed

Where should the reviewer start?
content_sync/tasks.py/backpopulate_archive_videos_batch

Codecov Report

Merging #1743 (84cc7e1) into master (e57f345) will increase coverage by 3.82%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1743      +/-   ##
==========================================
+ Coverage   87.36%   91.18%   +3.82%
==========================================
  Files         247      124     -123
  Lines       10581     3722    -6859
  Branches     1781      862     -919
==========================================
- Hits         9244     3394    -5850
+ Misses       1174      305     -869
+ Partials      163       23     -140

see 123 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blarghmatey I'm interested on your input regarding the amount of bandwidth doing this in RC / production will require. There are over 500GB of videos in the OCW Archive bucket, and bringing them into the storage bucket and all of the preview / publish buckets means 2.5TB of data transferred per environment when we run this command. The command itself will in theory only be run once per environment though, then the data will just be sitting in S3. It's not the most efficient way we could accomplish this, but it means we don't have to do any weird conditional syncing of videos based on whether the course was imported or not. This won't be a problem will it?


CB-19063 tracing should be configurable in ums clients in order to avoid tracing to block ums related requests in tests

See detailed description in the commit message.

retest this please


capitonidae, ecmnesia (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


TIPs are read after showing About Dialog (F1_key)

as the title says
a valid/whitelisted packet is used but dosen't read after showing the about dialog

a patch has been created.


docs: refactor TLS Context docs to make it more reader friendly

Description
I noticed that some of the sections of the TLS Context docs are very verbose and hard to read. This PR is to make it a little bit more user-friendly.

Commit Message: docs: refactor TLS Context docs to make it more reader friendly
Additional Description: Refining the TLS context docs to make it more user-friendly.
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

/retest

/retest

needs api signoff
cc @ggreenway for TLS docs update


NgxGalleryPreviewComponent generates image with src="#" causing action called twice in Chrome

I have noticed that in line 19 of ng:///NgxGalleryModule/NgxGalleryPreviewComponent.html -
<img #previewImage class="ngx-gallery-preview-img ngx-gallery-center" [src]="src ? src : '#'" (click)="$event.stopPropagation()" (mouseenter)="imageMouseEnter()" (mouseleave)="imageMouseLeave()" (mousedown)="mouseDownHandler($event)" (touchstart)="mouseDownHandler($event)" [class.ngx-gallery-active]="!loading" [class.animation]="animation" [class.ngx-gallery-grab]="canDragOnZoom()" [style.transform]="getTransform()" [style.left]="positionLeft + 'px'" [style.top]="positionTop + 'px'"/>
"src" attribute being set when I click on image to load preview. Unless I see preview, image's src attribute remains as "#". I tried with disabling lazy loading as well.
problem with image's src as "#" is that it calls MVC controller again as mentioned in here

@Aman-Jojra thanks for this bug report. Unfortunately I don't have time lately, PR are welcome.

Ah thanks for quick turn around. It's working perfect now.


Sash bar for Edit Data SQL pane

Sash bar now shows up after clicking show SQL Pane
This PR fixes #9142

could you please attach a screenshot?


Shake+

This was tested against a roughly two-month-old master.
Unable test it on fresh master, due to unrelated problems (extra-utils failures), so submitting it anyway, for it to be checked against the CI.

Do you realize that shake 0.15 is already available in Nixpkgs under the attribute haskellngPackages.shake?

@peti when we are going to drop haskellPackages?

When we switch to GHC 7.10.1. Certainly before forking off the next release branch.

@peti thank you. So maybe close this PR?

@deepfire, please re-open this PR if the other version of shake turns out to be unsatisfactory to you for some reason!


Fix code scanning alert - Use -n instead of ! -z.

Tracking issue for:

[ ] https://github.com/gounthar/MyFirstAndroidAppBuiltByJenkins/security/code-scanning/278

ERROR: Argument "SOURCE" is required
So, no, thank you, but no.
Won't do.


Android Java: 09.02 how to make a video player app in android?

Description :scroll:

Give a step-by-step tutorial in Java along with a brief and clear explanation.
Required Documentation or Video or Audio.

Domain of Contribution :bar_chart:

[x] Android Dev (java)

References :
https://www.geeksforgeeks.org/complete-guide-on-how-to-build-a-video-player-in-android/

Please Read it Carefully Before Contributing

Changes should be made in Android_Development_With_Java/ directory under Android_Development_With_Java branch.
Inside Android_Development_With_Java directory/ creates a directory and names it according to the topic
Inside Topic Name directory/ add your task with subtopic number and name and make changes accordingly.
You have to push your PR to the Android_Development_With_Java branch only.
You can take help to the references but don't simply try to copy it. Just explain in your own word.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.
Will assign you on a first come first serve basis.
Please try to complete your assigned task within 7 days. If you need some more time then, please inform mentors and supervisors.
If you have two previously assigned issues on Android-Java pending then please first complete them.

Supervisor @VikasPandey121

@VikasPandey121 please look into it.
On Sun, 31 Oct 2021, 5:27 pm github-actions[bot], @.***>
wrote:

The assigned contributor has more than 3 open issues, kindly reassign
manually @.***/Mentors)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/girlscript/winter-of-contributing/issues/6094#issuecomment-955685992,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASIF5UBA3CMQBGOOVPBRVQ3UJUVJ5ANCNFSM5GDYYP6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

/assign

PR #8363
@VikasPandey121, @sitamadex11 Sir review the PR.


Duplicated games in installed games list

Hi! First of all I want to say that this is an awesome plugin :)
I've had this plugin since its original name and I always had some of my games show twice in the games list.
I tried uninstalling it, deleting the plugin files in the homebrew folder, deleting steam web browser cache and it does not fix the issue.
I don't know if this is a bug or the expected behavior in some cases.
Is there a way to remove the duplicates? Thanks in advance!
Kind regards.

Hey @obackhoff apologies for the delay in addressing your issue. Life has been busy on my end but I will be sure to take a look at the issue this weekend.
A few follow-up questions - do you have an example or screenshot of a duplicated game? Are the same games always duplicated or does it change?


Fleet: Git Repos: Details: Graph loads in ~30 min when git repo is in active state

Setup

Rancher version: v2.9-b74832dde8f4a272ea4f5fd3cfb846159c681be1-head
Rancher UI Extensions:
Browser type & version: Any

Describe the bug
The graph takes ~30 minutes to load in v2.9 (loads within ~10 sec in v2.8).

To Reproduce

go to fleet > git repos tab
click 'Add Repositories'
input repo URL ('https://github.com/rancher/fleet-examples.git')
click 'Add Path'
input path ('simple')
click 'Create'
wait until it is in Active state
navigate to git repo's details page
click on 'Graph'
notice the time it takes for graph to load

Result
The graph loads in ~30 minutes in v2.9 (loads within ~15 sec in v2.8).
Expected Result
The graph loads within ~15 seconds

Screenshots

Additional context

Possibly related PR per @rak-phillip: https://github.com/rancher/dashboard/pull/11062/files

I had a look at the performance logs. There's no network requests handing around, no errors in console and no cpu churn. Needs debugging

Multiple issues here

$watch fails to trigger https://github.com/rancher/dashboard/blob/7d69ff2b553f00a102ab9cec95e3e4ace5d74e54/shell/components/fleet/ForceDirectedTreeChart/index.vue#L335-L337

for git repos this watches on the prop datas bunldes property (on modal). i added a manual watch on data.bundles works around this in dev land

no state for gitupdating , so cannot access color prop https://github.com/rancher/dashboard/blob/7d69ff2b553f00a102ab9cec95e3e4ace5d74e54/shell/pages/c/_cluster/fleet/GitRepoGraphConfig.js#L95

working around this with a ?. gives the next issue

svg doesn't get created https://github.com/rancher/dashboard/blob/7d69ff2b553f00a102ab9cec95e3e4ace5d74e54/shell/components/fleet/ForceDirectedTreeChart/index.vue#L86

svg not defined