[RFC] Add fixed price reward option in promotion rules

Problem
Allow providing the fixed price amount as a reward of the promotion rule.
Should be done after https://github.com/saleor/saleor/issues/12889

1. General Assumptions

Introduce a new FIXED_PRICE reward type
Allow defining the fixed price amount as a reward of the promotion rule
Update promotion migrations - do not require rewardValueType for FIXED_PRICE reward type, when rewardValueType is provided - ignore if the value is FIXED, raise a ValidationError when the PERCENTAGE is given
The rewardValueType must be required for cataloguePredicate
Update checkout and draft order calculations to override the price. Ensure the taxes are correctly calculated.

Example:
Buy any 3 products from the category Shirt for $100
{
  "promotionRule": {
    "checkoutAndOrderPredicate": {
      "AND": [
        {
          "discountedLineObjectPredicate": {
            "quantity": {
              "range": {
                "gte": 3
              }
            }
          }
        },
        {
          "discountedLineObjectPredicate": {
            "cataloguePredicate": {
              "__typename": "CategoryPredicate",
              "name": {
                "eq": "Shirt"
              }
            }
          }
        }
      ]
    },
    "rewardValueType": "FIXED_PRICE",
    "discountValueType": "FIXED",
    "rewardValue": 100
  }
}

Acceptance Criteria

[ ] The taxes should be correctly calculated for the fixed price

2. API changes
Mutations

Update the following mutations: promotionCreate, PromotionRuleCreate, promotionRuleUpdate as follow:

do not require rewardValueType for FIXED_PRICE reward type
ignore if the value is FIXED
raise a ValidationError when the PERCENTAGE is given

Types

Extend RewardTypeEnum with FIXED_PRICE

enum RewardTypeEnum @doc(category: "Discounts") {
  ...
  FIXED_PRICE
}

3. To Do list

[ ] Extend the rewardType enum
[ ] Update the mutations with proper validation
[ ] Update the order and checkout price recalculations
[ ] Ensure tax for flat rates and Avatax are properly calculated

4. To Test

[ ] Check with price override - the sale should be applied anyway
[ ] Check with flat rates, avatax
[ ] Check with option when taxes are included in prices and not

Postponed for now.


model empty

Im trying with your solution but I have a problem. Model is always null. Only image file was read correctly. This is post request which is send from my video camera after license plate is recognized:
POST /alpv/receive.php HTTP/1.1\r\n  Host: <IP_ADDRESS>\r\n  Content-Length: 7160\r\n  Content-Type: multipart/form-data; boundary=------------------------3df4e8eee91da308\r\n    --------------------------3df4e8eee91da308  Content-Disposition:  form-data;  name="event"; filename="20190204103017_10536event_7000175.json"  Content-Type: application/octet-stream  {   "packetCounter":"7000175",   "datetime":"20190204 103017000",   "plateText":"\u004c\u0042\u0045\u0033\u0039\u0037",   "plateCountry":"SWE",   "plateConfidence":"0.716159",   "carState":"new",   "geotag":{"lat": 50.418114,"lon": 30.476213},   "imageType": "plate",   "plateImageType": "png",   "plateImageSize":  "0",   "carMoveDirection":"in",   "timeProcessing":"0",   "plateCoordinates":[1614, 880, 172, 28],   "carID":"18",   "GEOtarget":"Camera",   "sensorProviderID":"defaultID"  }  --------------------------3df4e8eee91da308  Content-Disposition:  form-data;  name="image";  filename="20190204103016_999776lp_LBE397_7000175.png"  Content-Type: application/octet-stream     <IMAGE DATA>    --------------------------3df4e8eee91da308--
There are two files: "image" and "event".
In controller I write this:
public IActionResult NewEvent([ModelBinder(BinderType = typeof(JsonModelBinder))] DataFromCameraModel @event,     IFormFile  image)  { return Ok(); }
and DataFromCameraModel
public class DataFromCameraModel { public int packetCounter {get;set;} public string Datetime {get;set;} public string plateText {get;set;} }

Hello.
I have the same problem.
Did you find a solution?

Im trying with your solution but I have a problem. Model is always null. Only image file was read correctly. This is post request which is send from my video camera after license plate is recognized:
POST /alpv/receive.php HTTP/1.1\r\n Host: <IP_ADDRESS>\r\n Content-Length: 7160\r\n Content-Type: multipart/form-data; boundary=------------------------3df4e8eee91da308\r\n --------------------------3df4e8eee91da308 Content-Disposition: form-data; name="event"; filename="20190204103017_10536event_7000175.json" Content-Type: application/octet-stream { "packetCounter":"7000175", "datetime":"20190204 103017000", "plateText":"\u004c\u0042\u0045\u0033\u0039\u0037", "plateCountry":"SWE", "plateConfidence":"0.716159", "carState":"new", "geotag":{"lat": 50.418114,"lon": 30.476213}, "imageType": "plate", "plateImageType": "png", "plateImageSize": "0", "carMoveDirection":"in", "timeProcessing":"0", "plateCoordinates":[1614, 880, 172, 28], "carID":"18", "GEOtarget":"Camera", "sensorProviderID":"defaultID" } --------------------------3df4e8eee91da308 Content-Disposition: form-data; name="image"; filename="20190204103016_999776lp_LBE397_7000175.png" Content-Type: application/octet-stream <IMAGE DATA> --------------------------3df4e8eee91da308--
There are two files: "image" and "event".
In controller I write this:
public IActionResult NewEvent([ModelBinder(BinderType = typeof(JsonModelBinder))] DataFromCameraModel @event, IFormFile image) { return Ok(); }
and DataFromCameraModel
public class DataFromCameraModel { public int packetCounter {get;set;} public string Datetime {get;set;} public string plateText {get;set;} }

Hello.
I have the same problem.
Did you find a solution?

I solved as follows:
[HttpPost("newevent")]
        [Consumes("multipart/form-data")]

        public IActionResult NewEvent(IFormFile @event, IFormFile image)
        {
            using (var reader = new StreamReader(@event.OpenReadStream()))
           {
             eventmodel = JsonConvert.DeserializeObject<DataFromCameraModel>(reader.ReadToEnd());

           }
            firstchar = eventmodel.plateText[0];

            if (eventmodel.plateText.Length == 7 && !Char.IsDigit(firstchar))
            {
                var imagepath = _truckService.UploadNewEventImage(image);
                _truckService.SaveNewEvent(eventmodel,imagepath);
                this.HubContext.Clients.All.SendAsync("Refresh", eventmodel);
            }
            return Ok();
        }

public class DataFromCameraModel
    {

        public string Datetime { get; set; }
        public string plateText { get; set; }

    }

Thanks for the reply.
So you did not actually use "JsonModelBinder"!

didnt use, you can get data easily with this:
 using (var reader = new StreamReader(@event.OpenReadStream()))
           {
             eventmodel = JsonConvert.DeserializeObject<DataFromCameraModel>(reader.ReadToEnd());

           }

didnt use, you can get data easily with this:
 using (var reader = new StreamReader(@event.OpenReadStream()))
           {
             eventmodel = JsonConvert.DeserializeObject<DataFromCameraModel>(reader.ReadToEnd());

           }

Thank you. ok.


Missing 3.9.2 jars for Scala 2.11

https://repo1.maven.org/maven2/com/typesafe/scala-logging/scala-logging_2.11/3.9.2/ - 404 Not Found
https://repo1.maven.org/maven2/com/typesafe/scala-logging/scala-logging_2.12/3.9.2/ - OK

@analytically can you please help us ?

I've published scala-logging_2.11-3.9.2

That was fast, thank you @analytically 👍


newsboat 2.23 can't load database

Newsboat version (copy the output of newsboat -v or the first line of git show):
% newsboat -v
newsboat 2.23.0 - https://newsboat.org/
Copyright (C) 2006-2015 Andreas Krennmair
Copyright (C) 2015-2021 Alexander Batischev
Copyright (C) 2006-2017 Newsbeuter contributors
Copyright (C) 2017-2021 Newsboat contributors

newsboat ist Freie Software und steht unter der MIT-Lizenz. („newsboat -vv“ zeigt den vollständigen Lizenztext an.)
Mitgeliefert wird:
- JSON für Modernes C++, unter der MIT-Lizenz stehende Bibliothek: https://github.com/nlohmann/json
- optional-lite, unter der Boost-Software-Lizenz stehende Bibliothek: https://github.com/martinmoene/optional-lite
- expected-lite, unter der Boost-Software-Lizenz stehende Bibliothek: https://github.com/martinmoene/expected-lite

newsboat 2.23.0
System: Linux 4.19.0-14-amd64 (x86_64)
Compiler: g++ 8.3.0
ncurses: ncurses 6.1.20181013 (compiled with 6.1)
libcurl: libcurl/7.64.0 GnuTLS/3.6.7 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3 (compiled with 7.64.0)
SQLite: 3.27.2 (compiled with 3.27.2)
libxml2: compiled with 2.9.4

Config file (copy from ~/.newsboat/config or ~/.config/newsboat/config):
## configuration option: always-display-description
## description: If true, then the description will always displayed even if e.g. a content:encoded tag has been found.
## parameter syntax: [true/false]
# always-display-description false

## configuration option: article-sort-order
## description: The sortfield specifies which article property shall be used for sorting (currently available: date, title, flags, author, link, guid). The optional direction specifies the sort direction ("asc" specifies ascending sorting, "desc" specifies descending sorting. for date, "desc" is default, for all others, "asc" is default).
## parameter syntax: <sortfield>[-<direction>]
article-sort-order date-asc

## configuration option: feed-sort-order
## description: If set to "firsttag", the feeds in the feed list will be sorted by their first tag in the urls file.
## parameter syntax: <sortorder>
feed-sort-order title

## configuration option: articlelist-format
## description: This variable defines the format of entries in the article list. See below for more information on format strings.
## parameter syntax: <format>
# articlelist-format "%4i %f %D   %?T?|%-17T|  ?%t"
articlelist-format  "%4i %f %D   %?T?|%-17T|  ?%t"

## configuration option: auto-reload
## description: If enabled, all feeds will be automatically reloaded at start up and then continuously after a certain time has passed (see reload-time).
## parameter syntax: [yes/no]
# VORSICHT: Automatisches Nachladen (egal ob hier oder über -r) löst ein
# Speicherleck aus.
auto-reload yes

## configuration option: bloglines-auth
## description: Set the Bloglines username and password. This is necessary for the Bloglines synchronization mode.
## parameter syntax: <login>:<password>
# bloglines-auth ""

## configuration option: bloglines-mark-read
## description: If set to yes, it will mark all articles that are downloaded from Bloglines as read.
## parameter syntax: [yes/no]
# bloglines-mark-read no

## configuration option: bookmark-cmd
## description: If set, then <bookmark-command> will be used as bookmarking plugin. See the documentation on bookmarking for further information.
## parameter syntax: <bookmark-command>
bookmark-cmd "/home/andi/bin/newsboat_bookmark.py"

## configuration option: bookmark-interactive
## description: If set to yes, then the configured bookmark command is an interactive program.
## parameter syntax: [yes/no]
bookmark-interactive no

## configuration option: bookmark-autopilot
## description: If set to yes, the configured bookmark command is executed without any further input asked from user, unless the url or the title cannot be found/guessed.
## parameter syntax: [yes/no]
bookmark-autopilot yes

## configuration option: browser
## description: Set the browser command to use when opening an article in the browser. If <browser-command> contains %u, it will be used as complete commandline and %u will be replaced with the URL that shall be opened.
## parameter syntax: <browser-command>
#browser "browserwrapper.sh %u"
browser "/home/andi/bin/textmodebrowser.sh %u"
#browser konqueror

## configuration option: cache-file
## description: This configuration option sets the cache file. This is especially useful if the filesystem of your home directory doesn't support proper locking (e.g. NFS).
## parameter syntax: <path>
# cache-file "~/.newsboat/cache.db"

## configuration option: cleanup-on-quit
## description: If yes, then the cache gets locked and superfluous feeds and items are removed, such as feeds that can't be found in the urls configuration file anymore.
## parameter syntax: [yes/no]
cleanup-on-quit yes

## configuration option: confirm-exit
## description: If set to yes, then newsboat will ask for confirmation whether the user really wants to quit newsboat.
## parameter syntax: [yes/no]
confirm-exit yes

## configuration option: datetime-format
## description: This format specifies the date/time format in the article list. For a detailed documentation on the allowed formats, consult the manpage of strftime(3).
## parameter syntax: <date/time format>
#datetime-format %d.%m.%Y
datetime-format %Y-%m-%d

## configuration option: display-article-progress
## description: If set to yes, then a read progress (in percent) is displayed in the article view. Otherwise, no read progress is displayed.
## parameter syntax: [yes/no]
# display-article-progress yes

## configuration option: download-retries
## description: How many times newsboat shall try to successfully download a feed before giving up. This is an option to improve the success of downloads on slow and shaky connections such as via a TOR proxy.
## parameter syntax: <number retries>
# download-retries 1

## configuration option: download-timeout
## description: The number of seconds newsboat shall wait when downloading a feed before giving up. This is an option to improve the success of downloads on slow and shaky connections such as via a TOR proxy.
## parameter syntax: <seconds>
# download-timeout 30

## configuration option: error-log
## description: If set, then user errors (e.g. errors regarding defunct RSS feeds) will be logged to this file.
## parameter syntax: <path>
# error-log ""

## configuration option: feed-sort-order
## description: If set to "firsttag", the feeds in the feed list will be sorted by their first tag in the urls file.
## parameter syntax: <sortorder>
# feed-sort-order none

## configuration option: feedlist-format
## description: This variable defines the format of entries in the feed list. See below for more information on format strings.
## parameter syntax: <format>
# feedlist-format "%4i %n %11u %t"
feedlist-format     "%4i %n %11u %t"

feedlist-title-format "[%u/%t] %N %V - %?F?Feeds&Your feeds?%?F? matching filter `%F'&?%?T? - tag `%T'&?"
articlelist-title-format "[%u/%t] %N %V - Articles in feed '%T'%?F? matching filter `%F'&? - %U"
searchresult-title-format "[%u/%t] %N %V - Search results%?F? matching filter `%F'&?"
itemview-title-format "[%u/%t] %N %V - Article '%T'"

## configuration option: googlereader-flag-share
## description: If this is set and Google Reader support is used, then all articles that are flagged with the specified flag are being "shared" in Google Reader so that people that follow you can see it.
## parameter syntax: <flag>
# googlereader-flag-share ""

## configuration option: googlereader-flag-star
## description: If this is set and Google Reader support is used, then all articles that are flagged with the specified flag are being "starred" in Google Reader and appear in the list of "Starred items".
## parameter syntax: <flag>
# googlereader-flag-star ""

## configuration option: googlereader-login
## description: This variable sets your Google Reader login for the Google Reader support.
## parameter syntax: <login>
# googlereader-login ""

## configuration option: googlereader-min-items
## description: This variable sets the number of articles that are loaded from Google Reader per feed.
## parameter syntax: <number>
# googlereader-min-items 20

## configuration option: googlereader-password
## description: This variable sets your Google Reader password for the Google Reader support.
## parameter syntax: <password>
# googlereader-password ""

## configuration option: googlereader-show-special-feeds
## description: If this is set, then "special feeds" like "People you follow" (articles shared by people you follow), "Starred items" (your starred articles), "Shared items" (your shared articles) and "Popular items" (articles considered to be popular by Google's magic algorithms) appear in your subscription list.
## parameter syntax: [yes/no]
# googlereader-show-special-feeds yes

## configuration option: goto-first-unread
## description: If set to yes (the default), then the first unread article will be selected whenever a feed is entered.
## parameter syntax: [yes/no]
# goto-first-unread yes

## configuration option: goto-next-feed
## description: If set to yes, then the next-unread and prev-unread keys will search in other feeds for unread articles if all articles in the current feed are read. If set to no, then the next-unread and prev-unread keys will stop in the current feed.
## parameter syntax: [yes/no]
# goto-next-feed yes

## configuration option: history-limit
## description: Defines the maximum number of entries of commandline resp. search history to be saved. To disable history saving, set history-limit to 0.
## parameter syntax: <number>
# history-limit 100

## configuration option: html-renderer
## description: If set to "internal", then the internal HTML renderer will be used. Otherwise, the specified command will be executed, the HTML to be rendered will be written to the command's stdin, and the program's output will be displayed. This makes it possible to use other, external programs, such as w3m, links or lynx, to render HTML.
## parameter syntax: <path>
# html-renderer internal

## configuration option: ignore-mode
## description: This configuration option defines in what way an article is ignored (see ignore-article). If set to "download", then it is ignored in the download/parsing phase (which is the default) and thus never written to the cache, if it set to "display", it is ignored when displaying articles but is kept in the cache.
## parameter syntax: [download/display]
# ignore-mode download

## configuration option: keep-articles-days
## description: If set to a number greater than 0, only articles that are were published within the last <n> days are kept, and older articles are deleted. If set to 0 (default value), this option is not active.
## parameter syntax: <days>
# keep-articles-days 0

## configuration option: mark-as-read-on-hover
## description: If set to yes, then all articles that get selected in the article list are marked as read.
## parameter syntax: [yes/no]
# mark-as-read-on-hover no

## configuration option: max-items
## description: Set the number of articles to maximally keep per feed. If the number is set to 0, then all articles are kept.
## parameter syntax: <number>
max-items 999

## If set the a number greater than 0, only articles that are were published within the last <n> days are kept, and older articles are deleted. If set to 0 (default value), this option is not active.
keep-articles-days 0

## configuration option: notify-format
## description: Format string that is used for formatting notifications. See the chapter on format strings for more information.
## parameter syntax: <string>
#notify-format "newsboat: finished reload, %f unread feeds (%n unread articles total)"
#notify-format       "%d new articles (%n unread articles, %f unread feeds)"
notify-format "Newsboat: neu geladen, %f ungelesene Quellen (insgesamt %n ungelesene Artikel)"
#notify-format "Newsboat: Quellen neu geladen"

## configuration option: notify-program
## description: If set, then the configured program will be executed if new articles arrived (through a reload). The first parameter of the called program contains the notification message.
## parameter syntax: <path>
notify-program "/home/andi/bin/pssst.sh"

## configuration option: notify-always
## description: If no, notifications will only be made when there are new feeds or articles. If yes, notifications will be made regardless.
## parameter syntax: [yes/no]
# notify-always no

## configuration option: notify-screen
## description: If yes, then a "privacy message" will be sent to the terminal, containing a notification message about new articles. This is especially useful if you use terminal emulations such as GNU screen which implement privacy messages.
## parameter syntax: [yes/no]
notify-screen no

## configuration option: notify-xterm
## description: If yes, then the xterm window title will be set to a notification message about new articles.
## parameter syntax: [yes/no]
notify-xterm yes

## configuration option: notify-beep
## description: If yes, then the speaker beep on new articles.
## parameter syntax: [yes/no]
# notify-beep no

## configuration option: opml-url
## description: If the OPML online subscription mode is enabled, then the list of feeds will be taken from the OPML file found on this location. Optionally, you can specify more than one URL. All the listed OPML URLs will then be taken into account when loading the feed list.
## parameter syntax: <url> ...
# opml-url ""

## configuration option: pager
## description: If set to "internal", then the internal pager will be used. Otherwise, the article to be displayed will be rendered to be a temporary file and then displayed with the configured pager. If the pager path is set to an empty string, the content of the "PAGER" environment variable will be used. If the pager path contains a placeholder "%f", it will be replaced with the temporary filename.
## parameter syntax: [<path>/internal]
# pager internal

## configuration option: podcast-auto-enqueue
## description: If yes, then all podcast URLs that are found in articles are added to the podcast download queue. See below for more information on podcast support in newsboat.
## parameter syntax: [yes/no]
podcast-auto-enqueue no

## configuration option: prepopulate-query-feeds
## description: If yes, then all query feeds are prepopulated with articles on startup.
## parameter syntax: [yes/no]
# prepopulate-query-feeds no

## configuration option: proxy-auth-method
## description: Set proxy authentication method. Allowed values: any, basic, digest, digest_ie (only available with libcurl 7.19.3 and newer), gssnegotiate, ntlm, anysafe.
## parameter syntax: <method>
# proxy-auth-method any

## configuration option: proxy-type
## description: Set proxy type. Allowed values: http, socks4, socks4a, socks5.
## parameter syntax: <type>
# proxy-type http

## configuration option: opml-url
## description: If the OPML online subscription mode is enabled, then the list of feeds will be taken from the OPML file found on this location.
## parameter syntax: <url>
# opml-url ""

## configuration option: refresh-on-startup
## description: If yes, then all feeds will be reloaded when newsboat starts up. This is equivalent to the -r commandline option.
## parameter syntax: [yes/no]
# refresh-on-startup no

## configuration option: reload-only-visible-feeds
## description: If yes, then manually reloading all feeds will only reload the currently visible feeds, e.g. if a filter or a tag is set.
## parameter syntax: [yes/no]
reload-only-visible-feeds yes

## configuration option: reload-time
## description: The number of minutes between automatic reloads.
## parameter syntax: <number>
reload-time 60

## configuration option: reload-threads
## description: The number of parallel reload threads that shall be started when all feeds are reloaded.
## parameter syntax: <number>
reload-threads 10

## configuration option: save-path
## description: The default path where articles shall be saved to. If an invalid path is specified, the current directory is used.
## parameter syntax: <path>
# save-path ~/

## configuration option: search-highlight-colors
## description: This configuration command specifies the highlighting colors when searching for text from the article view.
## parameter syntax: <fgcolor> <bgcolor> [<attribute> ...]
# search-highlight-colors black yellow bold

## configuration option: show-keymap-hint
## description: If no, then the keymap hints on the bottom of screen will not be displayed.
## parameter syntax: [yes/no]
# show-keymap-hint yes

## configuration option: show-read-feeds
## description: If yes, then all feeds, including those without unread articles, are listed. If no, then only feeds with one or more unread articles are list.
## parameter syntax: [yes/no]
# show-read-feeds yes

## configuration option: show-read-articles
## description: If yes, then all articles of a feed are listed in the article list. If no, then only unread articles are listed.
## parameter syntax: [yes/no]
# show-read-articles yes

## configuration option: suppress-first-reload
## description: If yes, then the first automatic reload will be suppressed if auto-reload is set to yes.
## parameter syntax: [yes/no]
suppress-first-reload no

# If set to yes, then Newsboat will ask for confirmation whether the user wants
# to mark all feeds as read.
confirm-mark-all-feeds-read yes

## configuration option: swap-title-and-hints
## description: If yes, then the title at the top of screen and keymap hints at the bottom of screen will be swapped.
## parameter syntax: [yes/no]
# swap-title-and-hints yes

## configuration option: text-width
## description: If set to a number greater than 0, then all HTML will be rendered to this maximum line length. If set to 0, the terminal width will be used.
## parameter syntax: <number>
# text-width 0

## configuration option: urls-source
## description: This configuration command sets the source where URLs shall be retrieved from. By default, this is ~/.newsboat/urls. Alternatively, you can set it to "bloglines", which enables newsboat's Bloglines synchronization mode, or to "opml", which enables newsboat's OPML online subscription mode.
## parameter syntax: <source>
# urls-source "local"

## configuration option: use-proxy
## description: If yes, then the configured proxy will be used for downloading the RSS feeds.
## parameter syntax: [yes/no]
# use-proxy no

## configuration option: user-agent
## description: If set to a non-zero-length string, this value will be used as HTTP User-Agent header for all HTTP requests.
## parameter syntax: <user agent string>
# user-agent ""

bind-key j down
bind-key k up
bind-key h quit
bind-key l open
bind-key L toggle-show-read-feeds
bind-key M mark-feed-read
bind-key g home
bind-key G end
bind-key s sort
bind-key S rev-sort

macro v pipe-to ~/bin/newsboat_vlc.sh
macro y pipe-to ~/bin/newsboat_youtube-dl.sh
macro u pipe-to ~/bin/newsboat_youtube-urls.sh
macro q set browser "qutebrowser.sh --target window %u" ; open-in-browser ; set browser "browserwrapper.sh %u"
macro w set browser "w3m %u" ; open-in-browser ; set browser "browserwrapper.sh %u"
macro m set browser "mpv --osd-level=3 %u > /dev/null 2> /dev/null &" ; open-in-browser ; set browser "browserwrapper.sh %u"
macro f set browser "freetube.sh %u > /dev/null 2> /dev/null &" ; open-in-browser ; set browser "browserwrapper.sh %u"
macro , pipe-to /usr/bin/urlview

# =============
# = Podbeuter =
# =============
# Specifies the directory where podbeuter shall download the files to.
download-path "~/Archiv/Synced/Multimedia/Podboat"
# This variable defines the format of entries in podboat’s download list.
podlist-format "%4i [%-5p %%] %-12S %b"
# Specifies how podboat would name the files it downloads.
#download-filename-format "%?u?%u&%Y-%b-%d-%H%M%S.unknown?"
#download-filename-format "%F %t.%e"
download-filename-format "%F_%N_%t.%e"
# Specifies the maximum number of parallel downloads when automatic download is enabled.
max-downloads 3
# Specifies the player that shall be used for playback of downloaded files.
player "vlc_mediainfo.sh"

# EOF

Steps to reproduce the issue:

Run newsboat:

% LANGUAGE=en newsboat -r
Starting newsboat 2.23.0...
Loading configuration...done.
Opening cache...done.
Loading URLs from /home/andi/.config/newsboat/urls...done.
Loading articles from cache...terminate called after throwing an instance of 'std::invalid_argument'
  what():  data for rust::String is not utf-8

Other info you think is relevant:
Seems like there are non-UTF-8 strings in my sqlite database.  It's very old, I had used it with newsbeuter bevore I switched to newsboat.  The same database worked perfectly with newsboat 2.22.1 and earlier versions.

Thank you for the report! These UTF-8 shenanigans are my focus for 2.24 development cycle. Until that work is done, your only option is to roll back to 2.22.1 :( Sorry about this.

Another option would be to recode all non-UTF-8 strings in the database, right?
But I'm fine with 2.22.1, thank you very much.

Another option would be to recode all non-UTF-8 strings in the database, right?

We can't really recode them, since we don't know which encoding they're using. They're supposed to all be in UTF-8, but apparently something, somehow slipped through. The database problem is new; I thought these encoding issues are confined to the runtime and didn't affect storage.
If I'm able, I'll figure out how non-UTF-8 strings got into the database, and then maybe we'll have options. Failing that, we'll have to replace any non-UTF-8 characters with U+FFFD (�), trashing user data. Most likely it's already trashed, either by iconv, ncurses, or the terminal; that too will have to be checked before choosing what to do about this.

I may have used this database since before I switched my desktop systems from ISO-8859-1 to UTF-8.  Maybe there are some ISO-8859-1 artefacts from the old times in my database and Newsboat isn't at fault here.  If this assumption is true, I could have a chance at fixing the database contents.

I consider Newsboat to be at fault because it should handle this more gracefully than a crash :)
One thing you can do is dump cache.db (which is an SQLite database) to a text file and check it for non-UTF-8 content. Something like this should do it:
$ iconv -f utf-8 -t utf-32 < dump.sql > /dev/null

If the dump contains any non-UTF-8 characters, this will fail with an offset. You can then use a text editor to take a peek at what's wrong.
If you find such an item, I'd be very curious to take a look at it! If you send me the relevant part of the SQL dump, it'd be very nice.

I created a dump and wrote a Python script to extract lines with encodings other than ASCII, ISO-8859-1 or UTF-8:
import chardet

with open("newsboat.sql", "rb") as fh:
    for i, line in enumerate(fh, 1):
        e = chardet.detect(line)
        if e["encoding"] not in ("utf-8", "ISO-8859-1", "ascii"):
            print(i)
            print(e)
            print(line)
            print()

Turns out there are a lot of data using other encodings (mainly Windows-1252) in my database:
https://cloud.acat.cc/index.php/s/DxB3u4DfuBrIqYA

Wow, the items at the end of the dump are just a few days old! So Newsboat is definitely at fault; it's not just some old entries from Newsbeuter.
Thank you very much for the analysis, and for the data (which I won't re-upload onto GitHub because you probably want to keep it off the Internet). I'm not yet sure what my next immediate step about this will be; I'll decide after I tackled #1344.

Thank you!

Just an idea, writing down before I forget:
Since you had so much success with the Python script, we can probably incorporate the same logic into Newsboat.

Change the rss_item schema, adding a new utf8_content text field. It's empty by default;
Upon startup, Newsboat checks if there are any records with non-empty rss_item.content. If there is:
a. Pause, asking the user to back up cache.db and confirm the conversion;
b. go through all non-empty rss_item.content records, and for each: 1) detect encoding; 2) convert to UTF-8; 3) write UTF-8 to rss_item.utf8_content; 4) make rss_item.content empty;
c. notify the user that the conversion is done. TODO: find out how Newsboat pre-2.23 handles non-UTF-8 in the database, give users concrete advice on how to check if their items are converted correctly.

(Ditto for rss_item.title, perhaps rss_item.author as well?)
This gives us backward and forward compatibility, and also ensures that the database is now in UTF-8. But there is a risk of mis-identifying the charset and wrecking the data. We could combat that by detecting charset on per-feed basis, rather than per-item basis: concatenate all their content and detect the charset of that. But this in turn might break if the feed changed the charset at some point.


Move SWAPI to Video section

Hi @ianwelsh , thanks for the PR! Can you explain why you think this service belongs in Video?

While there are Star Wars games and comics, the franchise is centered around the film series.
Since the Video section has TV and film franchise inspired API's (An API of Ice And Fire, Ron Swanson Quotes) then the Star Wars API belongs there as well.

Great, thanks!


[Themes] Switching to dark theme doesn't change icon, button, tab label color

As far as I remember before the release of 0.12.0 (when mui changed the ThemeManager initialization and before introducing rawTheme), contextTypes were properly passed down to the child elements (for e.g in case of icons, button labels, tab labels) when switching to dark theme. Dark themes should support light colors icons, button labels, tab labels, etc. Dark text color on buttons, Dialog content are not quite readable.
It can be replicated on mui doc site here

@mairh This looks to be fixed.

I am closing this issue. If you feel this has not been addressed completely feel free to leave a comment below.


Update to require min k8s 1.9

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.15.md#deprecations-and-removals
mentions:
DaemonSet, Deployment, and ReplicaSet resources will no longer be served from extensions/v1beta1, apps/v1beta1, or apps/v1beta2 in v1.16. Migrate to the apps/v1 API, available since v1.9. Existing persisted data can be retrieved via the apps/v1 API.

Also added the minimum supported version in the kube.libsonnet excplicitly.

Addresses some of #22 -- it'd be cool to assert if there are any preset fields
that would need care/adapting.

Addresses some of #22 -- it'd be cool to assert if there are any preset fields
that would need care/adapting.

I tried to figure out what actually changes between v1beta2 and v1 but I failed to find anything interesting. Could it be that they just promoted v1beta2 into v1 without changes in semantics?


selecting lfi data cubes jumps back to home page

Describe the bug
Selecting one of the lfi datasets jumps back to https://test.visualize.admin.ch/
To Reproduce
Steps to reproduce the behavior:

Go to https://test.visualize.admin.ch/browse?includeDrafts=true&order=SCORE&search=lfi
Click on a LFI dataset

Expected behavior
Jump to visualize this chose dataset
Environment (please complete the following information):
Visualize environment and version: TEST v3.2.7 (ba4b7c5)

Sorry for this issue, this is fixed now.


Fix broken links

Update broken link for Async Sample contents, which was cannot find the sample
Fixes #15890

@BillWagner, I think this is a temporary fix. The link should point to samples browser after the sample is migrated to GitHub samples repo. I'd keep the issue open.

@Youssef1313 can you create a new issue for the migration of the sample and update of the link?


chore: tweak babel config

Summary
less is more

Test plan
Green CI. Plus, I've manually run node scripts/build and verified there are zero changes to packages/*/build/** after this tweak

Codecov Report

Merging #11918 (cdc87fe) into main (c3b0946) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #11918      +/-   ##
==========================================
- Coverage   68.76%   68.75%   -0.01%
==========================================
  Files         322      322
  Lines       16591    16591
  Branches     4787     4787
==========================================
- Hits        11408    11407       -1
- Misses       5151     5152       +1
  Partials       32       32

Impacted Files
Coverage Δ

packages/expect/src/utils.ts
95.85% <0.00%> (-0.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b0946...cdc87fe. Read the comment docs.


Increased opacity in overload counter tooltip

This PR fixes #137270
The overload counters in the tooltip are difficult to read, in particular in the default dark mode. Increasing the opacity makes it much more readable.

PR #139963 is already addressing this.

Ah right, I see the user is deleted so maybe it was reasonable going with a new one. I can entirely remove the opacity as suggested by @misolori if that makes sense.

Thanks! Yes merging this since the other user seems to have deleted their account


chore: log hash of the iso everytime

What this PR does / why we need it:
chore: log hash of the iso everytime
modify-windows-iso-file task should log the iso hash everytime not only during error
Release note:
chore: log hash of the iso everytime

Thanks for the improvement!
/lgtm


Remote SyncError: Unable to start subsystem: sftp

I have 20 project directories each configured with a different remote-sync configuration.
Whenever I try to download through remote-sync, the download is partial and I get the following error:
Remote SyncError: Unable to start subsystem: sftp
There is no workaround besides copying files manually.
OS: Windows 7 64 bit
Atom version: 1.13.0 ia32
Remote-sync version: 4.1.5

Same here. Probably transferring many files in one go?
I got the following in my server's auth.log:
Feb  6 11:11:12 * sshd[4010]: Disconnecting: Could not create socket pairs: Too many open files
It seems that file connections are not closed properly upon completion.


Add simpler read-ahead cache

Needs tests, but can confirm that the s3fs suite is happy with it, except for the one test which specifically depends on BytesCache behaviour.

Defer whether to make ReadAheadCache the default to the future, would like people to try this first.


Contribution guidelines

Closes #5
I've written up a few details on how to go about using this library as well as a bit of the philosophy behind the design decisions. Can you let me know if it is clear or not.
Feel free to push edits across to this in this PR or later.
When both Ben and Aidan have approved, the second person to approve should merge this to master.

I'm merging this now. It's not quite perfect and is an opinionated piece, but it's got useful information that we should have available.


Relative sopsPGPKeyDir fails with nix develop from subdirectory

I'm working on a project with /project/flake.nix and sops-nix, with a mkShell { sopsPGPKeyDir = "./secrets/keys" }.
Then the following works as expected:
$ cd /project
$ nix develop
[nix-develop]$

But this doesn't:
$ cd /project/src
$ nix develop
path '/project/src' does not contain a 'flake.nix', searching up
find: ‘./secrets/keys’: No such file or directory

I'm finding it hard to say if this is due to an issue with the sops-nix config, or if nix's "searching up" functionality is broken (whether by design or implementation). Any insight appreciated!

How about this?
mkShell { sopsPGPKeyDir = "${toString ./.}/secrets/keys"; }

How about this?
mkShell { sopsPGPKeyDir = "${toString ./.}/secrets/keys"; }

That works, thanks!
Would it make sense to prepend ./. automatically, or is this just something that users should do?

There might be case where one wants absolute directories... I just improved the documentation instead: https://github.com/Mic92/sops-nix/pull/176/commits/d27137c0a1daa745d45ee2c1886cafbc5afef04c


Pin Rack to 1.x

2.x doesn't install on some versions of Ruby we test against, so we can
add this to our Gemfile like we did with ActiveSupport in order to
support those (the CLI works with them either way, though).

Codecov Report

Merging #223 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   91.31%   91.31%
=======================================
  Files          44       44
  Lines        1532     1532
=======================================
  Hits         1399     1399
  Misses        133      133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17327f8...1e2067f. Read the comment docs.


wrong this context with inheritance in resolver

TypeGraphQL seems to break the "this" context when using inheritence in resolvers
example:
@Resolver()
class A {
    @Query()
    getName(): string{
        return this.constructor.name;
    }
}

@Resolver((_of) => Test)
class B extends A {}

let b = new B()
console.log(b.getName())

Now when I try to ask for the className I got an A instead of a B. When I use this code in a normal JS environment I get the right answer B.
Enviorment (please complete the following information):

OS: Windows
Node 11.13.0
Package version 0.17.1
TypeScript version 3.4.1

It shouldn't happen, I have a lot of assertions for that (expect(thisVar.constructor).toEqual(childResolver);):
https://github.com/19majkel94/type-graphql/blob/f49923d64dda059397b89c704d92c41f340069a7/tests/functional/resolvers.ts#L1683-L1687
https://github.com/19majkel94/type-graphql/blob/f49923d64dda059397b89c704d92c41f340069a7/tests/functional/resolvers.ts#L1878-L1887
@Eluminati
Please describe the issue in more details, with code example, a reproduction repository or even a pull request with a failing test case.

Example code:
// ./TestResolver.ts
import { Resolver, Query } from 'type-graphql';

class BaseResolver {
    @Query()
    public resolverName(): string {
        return this.constructor.name;
    }
}
@Resolver()
export default class TestResolver extends BaseResolver { }

// Server.ts
import 'reflect-metadata';
import * as express from 'express';
import * as expressGraphQL from 'express-graphql';
import TestResolver from './TestResolver';
import { buildSchema } from 'type-graphql';

(async function(){
    let app = express();

    app.use("/api", expressGraphQL({
        schema: await buildSchema({ [TestResolver] }),
        graphiql: process.env.NODE_ENV === 'development' ? true : false
    }));

    app.listen(3000);
})()

That's enough to reproduce the bug. If you now start the server, go to the localhost:3000/api and request the following query:
{
    resolverName
}

You get:
{
  "data": {
    "resolverName": "BaseResolver"
  }
}

But because of TestResolver is the only exportet resolver the value of resolverName should be TestResolver and not BaseResolver. That means that this in BaseResolver is the BaseResolvers this and not Testresolvers which schould be the expected one if I am only able to initialize the TestResolver.
The case is that I need the current used resolver in the frontend and later (the project is in a very early state) every Resolver will have a BaseResolver. If the the this context is wrong it is impossible to execute more complex code because I always use the wrong methods.
May be there is a misunderstanding from my side but I am pretty sure to use it in the right way.
Until here I wish a good night to all =)


Can't replicate the results

Hello,
running the code with the default settings i can't replicate the results of the given pretrain.
Have you changed some parameters in order to obtain SotA results with the deterministic model?
The default epochs number is 50, but i suppose you have increased the number of epochs.
Thanks a lot!

Hi,
I assume that the results you reproduce are not very different from ours (for no other more essential reason), in which case you can reduce the number of training epochs, for example to 40.
Best regards.

Hi,
thanks for the answer.
With your pretrain running in test mode i get 108.4119 mm of error (test on subject 5)
Training the model from scratch, the best result that i had is 113.2632 (subject 5 too).
The performance gap is quite important, obviusly i'm taking the checkpoint with the minimum error in valid test during the train, using the default code. The only thing that i changed is the path of the dataset and the output frames from 10 to 25 to measure the performances with 25 frames of prediction. I even tried to train using subject number 5 as valid test, but the results are not changing, still the same results with a variation of +-1mm of error.
I don't think it's a version problem due to the big gap, even if the code don't present any seed to replicate the results.
By the way, i'm running the code on a RTX 3090 with cuda 11.6 and cudnn 8
It would be very helpful having your configuration setup that you used to reach SotA results, in order to have a better understanding of the code. Can you please check if you are able to get the results written on the paper with this version of the code? maybe it's just a versioning problem.
Thanks a lot for your time!

Hi,
Could you provide your command for training?
Following the same settings in the paper, the command to predict local motion with 25 frames should be,
python main.py --input_n 10 --output_n 25 --skip_rate 2 --n_pre 35 --data_dir ./data --version long
Best.

I launched the training with the same exact settings that you wrote (even the same relative path though!).
Can you kindly launch the training with the fresh code of the repo to check if the results are the same?

Yes, we are running the code based on current version.
Regarding what you mentioned, "obviously i'm taking the checkpoint with the minimum error in valid test during the train", that's not actually what we did. As I recall we trained directly for 40 (maybe 50) epochs and used the checkpoint for the last epoch.

Sure, i ran the tests even on the pretrain given every 10 epochs. So the model obtained at epoch 40 and 50, but with this pretrains the gap is even worse (7/8 mm gap between the results of the paper), that's why i didn't mentioned that results.
If you are running the code, in a couple hours we should have the actual results.

Hi,
Thanks for bringing this to my attention. I have discovered that there is indeed a version issue, which results in much worse performance compared to the results in an old version: https://github.com/Sirui-Xu/STARS/tree/708c1edac44f1f18c346b50e0fb08ff1969d4977
We are working to figure out the cause and will make the necessary updates. In the meantime, you can use this old version if you'd like.
Many thanks.

Hi,
The issue has been fixed.
Best.

Thank you very much!
There is still an error, line 84 of the code, in the dataloader.

Hello,
i tested the code with the same tests that i did for the previous version of the code and i still cannot replicate the results.
With this new version the error is lower, i got 112.91 mm in testing.
I tried to retrain the model with your settings, i tested every checkpoint (not only the last one) including the best one.
I also retrained using the test set as the validation set (in order to get the best model pretrain that suits the test set, even if it's "cheating" but just to try every configuration that can help the model).
The error given is far from the 108 mm of the paper, don't know what else to try.
I assume that in this new version you tried to train with this exactly version of the code and that you get Sota results.
Can you please share all the details? Thank you very much!

Hi,
I re-ran the experiment on the existing code.
For training, I used the following command:
python main.py --input_n 10 --output_n 25 --skip_rate 2 --n_pre 35 --data_dir ../../dataset/ --version long
The log file can be found here: log
For testing, I tested on the model at epoch 50:
python main.py --input_n 10 --output_n 25 --skip_rate 2 --n_pre 35 --data_dir ../../dataset/ --version long --mode test --model_path checkpoints/CKPT_3D_H36M/h36_3d_25frames_ckpt_50 -- test_output_n 25
The log file can be found here: log.  The results are even slightly better than those reported in the paper.
If you have any further questions or require additional information, please feel free to contact me.
Best.

Also, I re-ran more experiments with different seeds based on the existing code and tested on epoch 50. The error appears between 108.1-108.5
Best.

Thank you very much for the log files, it was very useful!
I discovered that with the same code, when i load the training set it loads 180077 samples, but yours is loading 181584 samples.
Probably there is a problem with the data and not with your architecture.
I tried to download the data from your link but its not working, can you fix the link in the deterministic repo readme?
Hopefully, i will be able to find the problem with my tests with this last step!
Thanks again very much for your help!

I downloaded again the dataset from the link in the repo (http://www.cs.stanford.edu/people/ashesh/h3.6m.zip) and the latest fresh code.
As reported in your log file, you are loading more sample than the normal dataset linked.
I'm supposing that the lower error is caused by this problem, can you please download again the dataset and retrain the model?
Let me know the results!
Best.

Thank you very much!
Best.

Hi,
We found some issues when we extracted the poses from the source, resulting in inconsistencies with the standard h3.6m dataset used in the deterministic predictions. The new log file can be found here: train logtest log. We've updated the repo and will update the standard results in the paper.
We have checked that the diverse prediction part is fine and not affected by this issue.
Thanks again for your help!
Best.


Django 1.6: User.post_save usersettings creation fails.

https://github.com/rossp/django-helpdesk/commit/f0156cfcb3ca0337ed3fea556a814c566269d6fd changed the post_save connector of the usermodel to create a corresponding usersetting.
However, in Django < 1.7 this fails if settings.AUTH_USER_MODEL is defined, since the sender is expected to be the actual instance, not a string. To be conform to https://docs.djangoproject.com/en/1.7/topics/auth/customizing/#referencing-the-user-model we need to check for django version explicitly and connect with the appropriate sender.

Ran into this issue last week as a temporary solution consider adding an additional step at the end of the installation steps in README...
$python manage.py create_usersettings


Minor: name some groups

Oh, one small thing, when I merge this to master locally, the build fails:
npm WARN prepare removing existing node_modules/ before installation
npm ERR! Invalid Version: git+https://github.com/alexei/sprintf.js.git#36b04b33975e597b03737c3ed0a2a49ec1b2e8c4
Deleting package-lock.json and node_modules and reinstalling fixes this. I'll see if github will let me push a fix to your PR...

This looks fine as far as I can see! I'm guessing you move the camera around with your own code that isn't part of this?

Yes, exactly.  I'll see if I can repro your build failure today.

I've submitted a PR for my package-lock.json ( #771 )


feat(container) - Add container resource management

Closes #1040
This PR add resource management for createContainer
This add 3 fields :

Cpu Limit
Memory Limit
Memory Reservation

I push a memory slider version
After some tests, I choose to fix 256MB steps and force value in MB
Tell me what you think about it ?
Thanx

Yep will try that

Ok I add an input, tell me if it's ok for you
I have some cleaning to do after that :D

@WTFKr0 sorry for the late update, the input is a nice addition ! It's OK now, could you clean the code?

Clean OK

Done

I applied small changes:

I reviewed the layout and specified the unit MB for memory limit & res in the legend
Changed the memory max calculation method

As you can see here the max memory was not really coherent in my environment and now makes more sense.

Thanks @WTFKr0 :+1:

Thanx


Add Locationiq as a Provider

https://locationiq.org/#docs Looks like a nice provider with generous free tier!

Send a PR and I'll merge it.

all looks good 👍
closing the issue !


356 fix room name on button in lobby

Fixed featrue

Fix the room name by setting his ID and a separator at the beggining

Codecov Report

Merging #358 (d47d7bf) into master (c44610b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   16.40%   16.41%
=======================================
  Files         146      146
  Lines        4071     4070    -1
  Branches     2253     2252    -1
=======================================
  Hits          668      668
+ Misses       2858     2857    -1
  Partials      545      545

Impacted Files
Coverage Δ

Client/ClientRoom.cpp
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Move to Github actions for CI

Description
Moving from travis to GH actions for CI

I'm an impatient fool, and assumed not seeing an action run in this PR was due to the workflow not being merged into main when it was actually because I can't write valid yaml.
Here's the fix that gets CI working: https://github.com/Shopify/web-configs/commit/6341b899767e4d756944233b7b80d0764ae84ee9


add HGVS expression to gene adv search

Backend support exists for this. Parameter name is hgvs_expressions and it supports all the standard string operations (like we use for name, description, etc)


System.ArgumentNullException (Value cannot be null)

2016-02-08 14:21:26.9720 #5872 [Error] SyncTrayzor.Bootstrapper: An unhandled AppDomain exception occurred. Terminating: True System.ArgumentNullException Der Wert darf nicht NULL sein.
Parametername: path System.String NormalizeLongPath(System.String, System.String)
bei Pri.LongPath.Path.NormalizeLongPath(String path, String parameterName)
bei SyncTrayzor.Services.FileWatcher.OnRenamed(Object source, RenamedEventArgs e) in C:\projects\synctrayzor\src\SyncTrayzor\Services\FileWatcher.cs:Zeile 185.
bei System.IO.FileSystemWatcher.CompletionStatusChanged(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* overlappedPointer)
bei System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pOVERLAP) System.ArgumentNullException: Der Wert darf nicht NULL sein.
Parametername: path
bei Pri.LongPath.Path.NormalizeLongPath(String path, String parameterName)
bei SyncTrayzor.Services.FileWatcher.OnRenamed(Object source, RenamedEventArgs e) in C:\projects\synctrayzor\src\SyncTrayzor\Services\FileWatcher.cs:Zeile 185.
bei System.IO.FileSystemWatcher.CompletionStatusChanged(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* overlappedPointer)
bei System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pOVERLAP)

SyncTrayzor 0.12.17 x64 portable
Do you need additional info?

Oh, it occurred twice so far, restarting SyncTrayzor (and killing/restarting Syncthing) worked fine.

Dup of #227, fixed in v1.1.7 (released earlier today).

Oh, it occurred twice so far

Have you seen it occur in v1.1.7?

No, still need to upgrade.

Phew! Was worried I haven't managed to fix it there.
Yep, upgrading should sort it out.


Feign logger - no sleuth headers attached

Hi,
I provided own implementation of  feign.Logger and set log level on feign.Logger.Level.FULL.
In the method logRequest I read Request.headers and don't get there sleuth headers like X-B3-,... .
I know for sure that TraceFignClient  is executed. When turn log level on DEBUG for org.springframework.cloud.sleuth.instrument.web.client.feign  I see  statements like
o.s.c.s.i.w.c.feign.TraceFeignClient     : The modified request equals POST.
with missing headers included.
/Tomek

Should go in https://github.com/spring-cloud/spring-cloud-sleuth/issues


Wrongly worded closing handshake timout warning

Here:
https://github.com/crossbario/autobahn-python/blob/0c38a7ea759f353e6d096fa553dab96910cb3d3b/autobahn/websocket/protocol.py#L832
We have
'WebSocket closing handshake timeout (peer did not finish the opening handshake in time)'
Surely this should read:
'WebSocket closing handshake timeout (peer did not finish the closing handshake in time)'

uups, yes of course;) that's a typo.

https://github.com/crossbario/autobahn-python/pull/1311


[DPE-1626] Add support for certificates and CA renewal

Issue
This PR implements DPE-1626, namely this PR implements:

Replace the certificates / keys formats to using pkcs12 trustores / keystores
Allow replacement of CA and regeneration of certificates on all nodes
Fix bug when TLS relation removed and reestablished

Notes:
This PR is pending more info on the following raised issue upstream, background being that it seems we can only have the changes reflected after a full cluster restart which is not expected nor ideal. ElasticSearch supports the rolling restart in such a scenario

@Mehdi-Bendriss: there was quite some work on this topic from @reneradoi. Do we still need to keep this PR or are we okay to close it?


how fine-tune ems2 with DNA glycosylases?

question about fine-tune ems2 with DNA glycosylases? how to retrain esm2
thanks

We use the same config with esm2 to finetune the model with DNA glycosylases data, and the code is from another project.
For your convenience, you can refer to this link to find training details :)
Thank you for leaving messages! Have a good day!

thanks for your reply! @zhoubay

thanks for your reply! @zhoubay

You're welcome! Contact me if there's more issues! Gonna close this issue:)


import-x/no-unresolved

Thanks for good lib
when checking 'import-x/no-unresolved' rules
Can't we evaluate this by taking tsconfig.compilerOptions.path?

tsconfig paths can be resolved with the corresponding resolver

@error-four-o-four Thanks


Delegate function

Will the delegate screen be able to show more information around latency of the delegates server, uptime etc?
When blocks are forged it created coins? Will it show the delegate how many coins have been forged from blocks?
Where does it show the transactions fees earned during forging process?  Will they be highlighted in some way?

yes

i've seen a screenshot or two where it shows the transaction earnings whilst forging in the android client, but not currently in 0.1.1 desktop, will that change in future versions

Same comment that in #7 . There's some good features for delegates currently in the explorer and mobile apps. Better to keep the wallet app lean
https://github.com/ArkEcosystem/ark-explorer
https://github.com/ArkEcosystem/ark-android-monitor
https://github.com/ArkEcosystem/ark-ios-monitor


SHA library

Now, async_mqtt is using picosha2.h.
https://github.com/redboltz/async_mqtt/blob/main/include/async_mqtt/external/picosha2.h
A part of broker code use it. https://github.com/redboltz/async_mqtt/blob/main/include/async_mqtt/broker/security.hpp
It is for sha256 password digest.
https://github.com/redboltz/async_mqtt/blob/8d3ef845e22de78e19e3542becbd427887c33367/include/async_mqtt/broker/security.hpp#L76-L83
If I propose async_mqtt to the Boost Libraries, this external dependency should be solved.

Moved to discussion #93.


[Feature]: 2FA Login

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Have the option of requiring an OTP code to connect to the panel.
Why should this be worked on?
It would greatly improve security

You mean 2FA?

Yes

@vasani-arpit  @andrasbacsai
Hey! I can work on that if no one is working on it already! 👍

@vasani-arpit @andrasbacsai Hey! I can work on that if no one is working on it already! 👍

@themarkwill  did u able to start working on it

It is available on v4.
I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.
Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.
Thanks for your understanding.


custom List.extend

At the moment znsocket.List.extend does not make use of sending multiple messages at a time.

same might be true for dict.update


Add actions

Please tell me if anything needs improved, I hope this helps anyone.

jobs:
  build:
    runs-on: macos-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v3

      - name: Install Procursus
        uses: dhinakg/procursus-action@main
        with:
          packages: ldid trustcache

      - name: Install Homebrew
        run: |
          set -x
          /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
          brew install gnu-sed
          brew install make

      - name: Install THEOS
        run: |
          set -x
          export BASEDIR="$(pwd)"
          export THEOS="${BASEDIR}/theos"
          mkdir -p $THEOS
          curl -fsSL https://raw.githubusercontent.com/theos/theos/master/bin/install-theos >> install-theos.sh
          gsed -E "/^\s*get_theos\s*$/,+1 s/^(\s*)(get_sdks)\s*$/\1mkdir -p \${THEOS}\/sdks\n\1touch \${THEOS}\/sdks\/sdk\n\1\2/g" -i install-theos.sh
          bash install-theos.sh
          cd $BASEDIR

      - name: Build
        run: |
          set -x
          sudo security import Exploits/fastPath/arm.pfx -k /Library/Keychains/System.keychain -P password -A
          export BASEDIR="$(pwd)"
          export THEOS="${BASEDIR}/theos"
          gmake
          mv Dopamine/Dopamine.tipa Dopamine.ipa

Now, you do not need to modify Makefiles.

Why homebrew?

Why homebrew?

just my taste. I need gsed and gmake from brew. You can use them in Procursus instead.

alright i'll just remove those commits and use security import later

It doesn't take that long to clone, but, I'm not sure, does theos on macOS default to xcode sdks?


ISSUE-574 Dropping FK without constraint name…

Dropping FK without constraint name causes unwanted dropping of PK in Postgres
Issue: https://github.com/cakephp/phinx/issues/574

Thanks!


Update pinned ontologies

Note: The required ontologies will be updated at the last possible minute for Q3.
Required Ontologies
The following ontology dependencies are pinned for this version of the schema.

Ontology
OBO Prefix
Required version

Cell Ontology
CL
cl.owl : 2021-06-21

Experimental Factor Ontology
EFO
efo.owl : 2021-06-15 EFO 3.31.0

Human Developmental Stages
HsapDv
hsapdv.owl : 2016-07-06 (0.1)

Mondo Disease Ontology
MONDO
mondo.owl : 2021-06-01

Mouse Developmental Stages
MmusDv
mmusdv.owl : 2016-07-06 (0.1)

NCBI organismal classification
NCBITaxon
ncbitaxon.owl : 2021-06-10

Phenotype And Trait Ontology
PATO
pato.owl : 2021-06-15

Uberon multi-species anatomy ontology
UBERON
uberon.owl : 2021-02-12

Is there a plan to check if all data currently hosted will be supported after updating the ontologies?

There is a plan or process, but this issue is specific to the schema changes. See Migrate Corpus in Submit Find Manage.


[1.0.8] battletower resetcooldown  only resets properly over a restart

Challenge BT
Check /battletower, see you have a cooldown
/battletower resetcooldown Rasgnarok
Check /battletower, see you have a cooldown (1h, 54min in my case)
Restart server
Check /battletower, see your cooldown is gone

Fixed in latest


API Reference: some @example contents not rendered

URL (minimal example if possible)

sap.ui.model.FilterOperator.BT and .NB:

API ref: https://sdk.openui5.org/nightly/#/api/sap.ui.model.FilterOperator%23properties
https://github.com/SAP/openui5/blob/cdbfd8787ca83b5dd97b56cc62378474fe2a0d45/src/sap.ui.core/src/sap/ui/model/FilterOperator.js#L70-L79

sap.ui.layout.BoxesPerRowConfig

API ref: https://sdk.openui5.org/nightly/#/api/sap.ui.layout.BoxesPerRowConfig
https://github.com/SAP/openui5/blob/8ab3d101a96ae070e9d5305cca7a5885590ee64e/src/sap.ui.layout/src/sap/ui/layout/library.js#L933-L940

Any other information? (attach screenshot if possible)
Unlike https://github.com/SAP/openui5/issues/3800, the "description" HTML is valid and the api.json file, but the enum and namespace API reference pages don't seem to incorporate examples.

Hello @boghyon ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Siyana


concat filename and line number with colon for better redirection

Thanks for adopting previous pull request.
I noticed that the filename is also added to the message. And I come up with this further improvement. So that we can make redirection to source code line by "Cmd+Click" on editors such as VSCode.
The following is the sample output:
INFO: Start testsuite << FFD Testsuite >> (@ 0) (ffd_testbench.sv:53)

INFO: Starting << Test 0: Check reset is applied >> (@ 0) (ffd_testbench.sv:74)
I will test if Q output is 0 after reset (@ 100000) (ffd_testbench.sv:76)
SUCCESS: Test 0 pass (@ 110000) (ffd_testbench.sv:81)

INFO: Starting << Test 1: Drive the FFD >> (@ 110000) (ffd_testbench.sv:83)
I will test if Q output is 1 after D assertion (@ 210000) (ffd_testbench.sv:85)
SUCCESS: Test 1 pass (@ 236000) (ffd_testbench.sv:94)

INFO: Stop testsuite 'FFD Testsuite' (@ 236000) (ffd_testbench.sv:96)
  - Warning number:  0
  - Critical number: 0
  - Error number:    0
  - STATUS: 2/2 test(s) passed

ffd_testbench.sv:118: $finish called at 236000 (1ps)
SVUT (@ 22:47:49) Stop ffd_testbench.sv

SVUT (@ 22:47:49) Elapsed time: 0:00:00.087769

Good to me :)


Rails 8.0.1

This updates the Starter Repo from Rails 7.2 to 8.0. It also activates the new framework defaults in config/initializers/new_framework_defaults_8_0.rb. If you have trouble with this update it's probably worth checking that file to see if any of the config options there relate to the problem you're seeing.
Fixes https://github.com/bullet-train-co/bullet_train/issues/1774

@jagthedrummer Thanks! I'm considering this a definite xmas gift!


Replace Perl with shell script in LSP snippet insertion

Snippet support is currently broken on NixOS because of perl not being on path by default, and I don't really see why Perl is even needed for this, so I figured I would try to rewrite this part in shell.

I'm not 100% confident that this works; from my tests snippets work fine but since posix sh doesn't have the concept of a map, if a snippet has multiple of the same identifier, it won't substitute properly. I'm hoping there's some way around this, but I'm not particularly experienced in writing shell, so any suggestions are appreciated.
Example:
'${0:thing} $0' comes out to set-register dquote 'thing' 'thing' with the existing Perl script, but set-register dquote 'thing' ' ' with my shell script.

Is it really that much of a problem to install something as ubiquitous as Perl on NixOS?
In addition to not being feature-complete, the shell implementation is much slower:
+ export kak_quoted_selections='${0:expression}' '${1:const void *p}' '$0'
+ hyperfine --warmup 3 -N perl test.pl dash test.sh bash test.sh
Benchmark 1: perl test.pl
  Time (mean ± σ):      15.6 ms ±   2.5 ms    [User: 10.0 ms, System: 5.0 ms]
  Range (min … max):    10.1 ms …  22.0 ms    246 runs

Benchmark 2: dash test.sh
  Time (mean ± σ):     146.1 ms ±   5.1 ms    [User: 109.8 ms, System: 44.1 ms]
  Range (min … max):   134.4 ms … 153.9 ms    19 runs

Benchmark 3: bash test.sh
  Time (mean ± σ):     171.5 ms ±   5.7 ms    [User: 121.4 ms, System: 66.4 ms]
  Range (min … max):   159.7 ms … 178.1 ms    17 runs

Summary
  'perl test.pl' ran
    9.38 ± 1.53 times faster than 'dash test.sh'
   11.02 ± 1.80 times faster than 'bash test.sh'

150ms will likely produce a noticeable latency between running the command and seeing the result.

We could require perl in the kak-lsp nix derivation.
At a glance, I think we might need to add this to the propagatedBuildInputs of the kak-lsp nix derivation, though I haven't tried this out.

Kakoune's git.kak and diff.kak already depend on Perl. The first is warranted because Git already depends on Perl. The second is a historical accident. If you're not using <ret> in git/diff buffers, you're missing out ;)
It's probably a good idea to remove the dependency. A close relative of Perl would be POSIX awk which would enable a more elegant implementation than shell.

Is it really that much of a problem to install something as ubiquitous as Perl on NixOS?

It's not an issue with installation, but to maintain a truly clean derivation (I, with my current knowledge of Nix, believe) I have to maintain a patch upstream to fix the perl path, which I don't really want to do.

In addition to not being feature-complete, the shell implementation is much slower:

Hmm... I guess I didn't consider this. I guess I'm a bit confused by the architecture of the lsp.kak file: why aren't we doing most of the string processing on the Rust side? I'd much rather implement the formal BNF from the LSP definition than use a regex to parse it.

I think we might need to add this to the propagatedBuildInputs of the kak-lsp nix derivation, though I haven't tried this out.

I'm fairly sure that propagatedBuildInputs is for development purposes only, but I guess I couldn't really tell from the sparse documentation... I have a PR upstream that I'd love for someone to code review, if you'd be willing to.

Kakoune's git.kak and diff.kak already depend on Perl.

Ah, I didn't even realize this was a thing! Guess I have a lot to discover in kakoune still.

A close relative of Perl would be POSIX awk which would enable a more elegant implementation than shell.

While I'm fine with reimplementing this in awk, I'm still a bit curious to why string parsing isn't mostly handled in Rust? lsp.kak looks like it does a lot of work here where I feel like it shouldn't.


Add support to 'nearby_stations' feed.

Hi,
There are some services, such as https://barcelona.publicbikesystem.net/ube/gbfs/v1/gbfs.json, that support a "nearby_stations" endpoint, combining the  "station_status" endpoint with the station_id tag. So here is a PR to support any kind of feed that must contain a tag to be formated.
If you feel the helper function should be implemented in other pattern, I'm happy to modify it.
Ismael

Hi Ismael,
Thank you for your contribution!
I was not previously aware of the 'nearby_stations' endpoint. I'll check out your PR later today and run some tests. If everything looks good I'll merge your changes and push a new release to PiPY.
Best,
Jake

Thanks!
Yep, it seems is not an official endpoint, but all the GBFS published at publicbikesystem.net have it. I dig it up a little bit and ended in this webpage: https://www.pbsc.com/, so it assumable that the company who sells/rents the bikes to the local hubs maintains their GBFS APIs and has this endpoint.
Cheers,
Ismael

Hi Ismael,
I verified your changes manually against the bespoke BCN feed. Nice work, I like the flexibility this change introduces!
Change looks good from Python3, however the typing syntax breaks Python 2.
I want to maintain compatibility for python>=2.7, so if you would kindly remove the typing annotations, I'll be happy to move forward with merge/release.
(If you have tox installed (pip install tox), you can run tox . from the repo root, which will run tests from py2.7 and 3.6.)
Thanks,
Jake

Done it, tested also and works with both distributions.
================================================================== 8 passed in 0.44s ==================================================================
_______________________________________________________________________ summary _______________________________________________________________________
  py27: commands succeeded
  py36: commands succeeded
  congratulations :)

Cheers,
Ismael

Merged. I'll comment below when the update is published to PyPI. Thanks again for contributing!

@isman7 your changes are now pushed to PyPI on new (latest) version 0.1.8
pip install gbfs-client -U  should get you there.
Cheers,
Jake

Great, thank you very much!!


Implement PEP517 with PyAEDT

Description of the feature
poetry is based on PEP517.
To be able to use pyaedt as a dependency in a pyproject.toml, it must comply with PEP517.
Steps for implementing the feature
No response
Useful links and references
No response

Duplicate of #1646

Duplicate of https://github.com/pyansys/pyaedt/issues/1646


Run rustfmt in travis.

Also rustfmt the codebase.
This builds on #13 since otherwise rustfmt hangs.

Ping. (Note here are the changes ignoring whitespace).


DoubleMAD outlier detector based on the Harrell-Davis quantile estimator

Hello, I read this blog post from the maintainers of BenchmarkDotNet,
It talks about an alternative and better suitable outlier detection for non normally distributed data. As benchmarks has high variance I thought it interesting even if I myself did not understand the exact math around it. Is this something Tango.rs may consider?

I looked at your IQR and tried copy it to use a double MAD, I am not confident enough to try to implement the Harrell-Davis quantile estimator.
Double MAD perform better when we have unsymetric distributions, ex when we have long tails. in one direction.
https://eurekastatistics.com/using-the-median-absolute-deviation-to-find-outliers/
fn double_mad_thresholds(mut input: Vec<f64>) -> Option<RangeInclusive<f64>> {
    const C: f64 = 1.4826;
    const K: f64 = 3.0;

    input.sort_unstable_by(|a, b| a.partial_cmp(b).unwrap_or(Ordering::Equal));

    let m = median(&mut input);

    let x_l: Vec<f64> = input
        .iter()
        .filter(|v| **v <= m)
        .map(|v| f64::abs(*v - m))
        .collect();
    let x_u: Vec<f64> = input
        .iter()
        .filter(|v| **v >= m)
        .map(|v| f64::abs(*v - m))
        .collect();

    let mad_l = C * median(&x_l);
    let mad_u = C * median(&x_u);

    let lower = m - K * mad_l;
    let upper: f64 = m + K * mad_u;
    println!("lower: {}, upper: {}", lower, upper);

    // Calculating the indicies of the thresholds in an dataset
    let low_threshold_idx = match input[..].binary_search_by(|probe| probe.total_cmp(&lower)) {
        Ok(idx) => idx,
        Err(idx) => idx,
    };

    let high_threshold_idx = match input[..].binary_search_by(|probe| probe.total_cmp(&upper)) {
        Ok(idx) => idx,
        Err(idx) => idx,
    };

    println!(
        "low_threshold_idx: {}, high_threshold_idx: {}",
        low_threshold_idx, high_threshold_idx
    );

    Some(input[low_threshold_idx]..=(input[high_threshold_idx - 1]))
}


Bottom offset

Hi @d-oliveros include bottom offset of sticky.
sticky area overlapping other elements include bottom property of sticky.
thanks.

Solve this issue using offset of every element that have attribute du-smooth-scroll.


Filter matching example syntax

https://github.com/tangrams/tangram-docs/blob/gh-pages/pages/Filters-Overview.md#matching-collisions
These examples have sublayers with a field called 'style', is this legal or does there need to be a 'draw' wrapping it?

According to this. draw is a mandatory field for layer/sublayers. And style should be a field under draw.

Yup, looks like a boo boo. I'll fix this one.

Fixed: 4d7e0a2b96fbaa5430b42c3ab4e8167624b9fe77

yep – that example was wicked old, and somehow escaped the Great Purge. thanks!


.monokle should store settings that can safely be commited to a repo

We should review everything that gets saved to .monokle and decide if it's a Project setting or a User setting.
The file should only contain project settings that can safely be committed to a Git repo.

Review what is stored in the .monokle. We want to make sure that what is there is safe to share


Creating eth object based on BIOS attributess

ethernet interfaces1 for vmi should only initialised if corresponding BIOS attribute exists for the same
Fix for Defect : https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=586842
Tested By :

Network hypervisor tree on Rainer system

root@rain111bmc:~# busctl tree xyz.openbmc_project.Network.Hypervisor
`- /xyz
  `- /xyz/openbmc_project
    `- /xyz/openbmc_project/network
      `- /xyz/openbmc_project/network/hypervisor
        |- /xyz/openbmc_project/network/hypervisor/config
        |- /xyz/openbmc_project/network/hypervisor/eth0
        | |- /xyz/openbmc_project/network/hypervisor/eth0/ipv4
        | | `- /xyz/openbmc_project/network/hypervisor/eth0/ipv4/addr0
        | `- /xyz/openbmc_project/network/hypervisor/eth0/ipv6
        |   `- /xyz/openbmc_project/network/hypervisor/eth0/ipv6/addr0
        `- /xyz/openbmc_project/network/hypervisor/eth1
          |- /xyz/openbmc_project/network/hypervisor/eth1/ipv4
          | `- /xyz/openbmc_project/network/hypervisor/eth1/ipv4/addr0
          `- /xyz/openbmc_project/network/hypervisor/eth1/ipv6
            `- /xyz/openbmc_project/network/hypervisor/eth1/ipv6/addr0

2)Network hypervisor tree on Bonnel system
 root@bonn027:~# busctl tree xyz.openbmc_project.Network.Hypervisor
`- /xyz
  `- /xyz/openbmc_project
    `- /xyz/openbmc_project/network
      `- /xyz/openbmc_project/network/hypervisor
        |- /xyz/openbmc_project/network/hypervisor/config
        `- /xyz/openbmc_project/network/hypervisor/eth0
          |- /xyz/openbmc_project/network/hypervisor/eth0/ipv4
          | `- /xyz/openbmc_project/network/hypervisor/eth0/ipv4/addr0
          `- /xyz/openbmc_project/network/hypervisor/eth0/ipv6
            `- /xyz/openbmc_project/network/hypervisor/eth0/ipv6/addr0

Can one of the admins verify this patch?

jenkins run tests please

jenkins run tests please

jenkins run tests please

jenkins run tests please

jenkins run test please

add to approvelist

Code looks good. Please fix CI and then its ready to go.

jenkins run tests please

yes verified for ipv6


realm ocnBgchem

There may be an inconsistency between the CV and the data request in the use of ocnBgchem. It is consistently capitalised this way in the CV. However in the data request it is consistently ocnBgChem. Is this an inconsistency and should one of them change?
Thanks,
Jon
cc @martinjuckes

@jonseddon nice pickup, this issue was discussed in https://github.com/WCRP-CMIP/CMIP6_CVs/issues/285#issuecomment-294946964 and after considering the change keeping ocnBgchem was the final decision.
We need to get both the dataRequest and ES-DOCs updated to the latest CVs in this repo

Credit should go to @cdr30 for spotting that. Thanks for getting this sorted!

Maybe we should wait for the final finalisation of the CVs?

@martinjuckes the only anticipated changes are new registrations of institution_id and source_id, the controlled vocabularies contained in the CMIP6_CVs repo are not expected to change - some formatting/informational changes are being discussed, see #166, but we are not expecting any CV changes
@taylor13 do you have anything else to add?

The CV's are now completely consistent with the WIP's document on global attributes, DRS, etc.  All known issues have been addressed except that we may at some point adopt in the experiment_id CV the "descriptions" that Charlotte Pascoe has collected for ES-DOC (see https://github.com/WCRP-CMIP/CMIP6_CVs/issues/339).  We have not heard from her in a long time, so I wouldn't wait on that.
Also, as Paul indicates,  the json files where the CV's are recorded may be modified at some point in two ways:

The "version" information at the bottom of each file will be augmented.  (see discussion at https://goo.gl/TdzjRC )
As Paul noted, we may add some information about frequency and/or realm to the table_id CV (see #166)

@jonseddon @martinjuckes @taylor13 I'll attach this to the standing issue #28 which we are planning to implement soon to ensure that CV versioning is more comprehensive. When #28 is closed I will also close this issue.
@jonseddon we can only ask @martinjuckes  and the ES-DOC folks (@esdoc-system-user, @momipsl, @eguil) to sync with the stable CVs, so hopefully this occurs within the next week or so and we're all in agreement

@jonseddon I believe everything required is contained in #28, we'll review this issue when #28 is finalised and we are preparing to close


Merge scrapy-fake-useragent into fake-useragent

Hey @alecxe!
I have proposal to merge our libs.
What do You think about it?

@hellysmile Hi! I'm perfectly okay with it if you think this is something that should be a part of fake-useragent.
We should probably have this middleware implemented inside fake-useragent and then I'll update the README and the PyPI page to point others to the fact that the middleware is now a part of fake-useragent. What do you think? Thanks.

@hellysmile, @alecxe: Haven't come to any agreement? I think it's logical to have middleware within fake-useragent, not a big burden, but then we'll have everything under one roof.

Seems we are both ok, but someone need to do that...

@hellysmile, do you need the project manager?:)
Looks like a trivial thing, and each of you has his own things to do. You cannot update the PyPI page for him, and he probably has no write access to your repo. Depends on how much time you have:)

@alexce, can you make a PR to @hellysmile, merging the middleware there? I can then make the is_pc thing. Or you wanted to do it?

Any further work being done here?

Closing as it seems we are expanding capabilities a bit (#27) and it does not seem we can fit just fake-useragent.


💄 Change Capture in the sidebar

#508  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RTLS and the rest of your teammates on  Graphite


Spread Props With Union Types into JSX Incorrectly Compares Defaults

this flow.org/try demonstrates that when providing a default value in jsx, and spreading props into the jsx, flow states that the union type is an invalid spread.
erroring snippet:
import * as React from 'react'

type A = {
  a: string
}

type ObjA = {
  a: { [key: string]: A }
}

type EitherA = A | ObjA

function Comp(props: EitherA) {
  return

}

However, if I move the defaults out into an object, the error is resolved. See this flow.org/try
working snippet:
import * as React from 'react'

type A = {
  a: string
}

type ObjA = {
  a: { [key: string]: A }
}

type EitherA = A | ObjA

function Comp(props: EitherA) {
  const defaults = { a: 'someString' }
  return

}

Tried looking at this, in effect
 is translated by jsx_mk_props in statement.ml to be equivalent to:
({
  a: "foo",
  ...{a: 42},
}: {
  a: number | string,
});

The working example is then equivalent to:
({
  ...{a: "foo"},
  ...{a: 42},
}: {
  a: number | string,
});

I would expect both of those to type check, so this seems like a more general issue with object spreads. I'm hitting the limit of my understanding of flow and OCaml to be able to debug further unfortunately.

Still seeing this in<EMAIL_ADDRESS>Happy to provide more information if needed.


Combine consecutive comments / synopsis to blocks

Consecutive comments and synopsis paragraphs could be combined to one block like editors do bulleted / numbered lists.
Benefit: Comment & synopsis blocks have one entry in the index. This could encourage writing longer synopses.
Modifications
First, of course, we need editor to combine blocks.
Second, we need to change file format:
Now:
<comment>...</comment>
<comment>...</comment>

Change to:
<comment>

...

...

</comment>

Same for synopses.

After implementing scene content types (scene, synopsis, notes), this is no longer as necessary as before. It would be good feature, but now you can write longer synopses and notes to yourself in separate foldable blocks.


How to prevent Guest Users in our Tenant seeing the Company Communicator with Teams?

We need to understand how to control access to the Company Communicator App, currently guest users are able to see messages sent for internal use when they login to their teams account.
Can you advise how to prevent this?

What version are you running? I believe in the older versions of the app when you selected the send to everyone options guests were included. I believe they are now filtered out automatically in the latest version. The option to send to M365 groups etc was also introduced in a later version too. Also the option to proactively install the end user app if its not already installed was added, which removes the need to pin the app globally or install it globally in the app setup policies.

What version are you running? I believe in the older versions of the app when you selected the send to everyone options guests were included. I believe they are now filtered out automatically in the latest version. The option to send to M365 groups etc was also introduced in a later version too. Also the option to proactively install the end user app if its not already installed was added, which removes the need to pin the app globally or install it globally in the app setup policies.

You can also leverage app setup policies to block access from guests to the CC application.

Step 1. Create a dynamic group with guests and another with all internal users. info
Step 2. Create and assign policies to those groups. info

Hello @JoeSMGraham,
Let us know if issue still persists.
Thanks

There is no issue here. You just need to use the app setup policies. Do not use the global policy to install cc. That policy also covers guests. Use a new policy to install the app just for non-guests. Disable the proactive installation.
Get Outlook for iOShttps://aka.ms/o0ukef

From: hunaidhanfee20 @.>
Sent: Thursday, June 3, 2021 9:49:25 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Cristiano Goncalves @.>; Comment @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] How to prevent Guest Users in our Tenant seeing the Company Communicator with Teams? (#298)
Hello @JoeSMGrahamhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJoeSMGraham&data=04|01||359710f47fbf4df5fcf108d9268e0504|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637583213675565491|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Tm8JsPpck2O5FUNMKPuafIYY8%2FuCFqugdZa0cSLUzL8%3D&reserved=0,
Let us know if issue still persists.
Thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2Fmicrosoft-teams-apps-company-communicator%2Fissues%2F298%23issuecomment-853842458&data=04|01||359710f47fbf4df5fcf108d9268e0504|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637583213675575478|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=gn4layCpSDovQMRe4gsZHF2xsVXnJk%2BDlOBkd1sIP3A%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALSAPKTMXGYKRGEAR66N5HLTQ525LANCNFSM4WHMYKFQ&data=04|01||359710f47fbf4df5fcf108d9268e0504|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637583213675575478|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Wyr2OYoTkJA4%2FC5uoaV%2B6ALLWVvZ1oeCsAVo5Deo7s0%3D&reserved=0.


BENCH: optimize: more comprehensive linprog benchmarking

92 Netlib LP test problem definitions have been included in SciPy's benchmarks folder since interior-point was added, but only two very easy problems run by default in the benchmark suite. I believe this was mostly because simplex had trouble with the more difficult problems. Now that revised simplex is available and simplex is retained only as a legacy method, revised simplex should replace simplex in the benchmarks and more benchmarks should be run.
This PR:

replaces simplex with revised simplex
runs the benchmarks for both dense and sparse interior point
adds the magic square problem (LP-relaxation of a 0-1 integer program for finding a magic square) as a benchmark
adds many additional Netlib problems to run by default (and corrects an issue with the bounds)
separately benchmarks linprog's redundancy removal routines

Some questions (thoughts @tylerjereddy @andyfaff ?):

[x] how long should the entire linprog benchmark suite take to run with default options? Update: I'll shoot for about a minute, then allow slow benchmarks with environment variables.
[x] should slow benchmarks be enabled separately using environment variables? Update: Probably. I'll add this.
[x] is it appropriate to check accuracy in benchmarks? currently I've added assertions to check whether the solutions are within a given tolerance, but it would be even better if I could measure and report the error (just as time is measured and reported) Update: I see I can use track benchmarks. Great. I'll do that.
[x] revised simplex does not terminate successfully for some of the problems it finds numerically challenging, which is OK. If it is appropriate to check solution accuracy/success, I'll keep them. If not, should I skip them? Update: won't skip; I'll keep them since I can track successes

Update: I'll base tracking and controlling with environment variables on BenchGlobal.
Reference issue
Addresses items in gh-9269

how long should the entire linprog benchmark suite take to run with default options? Update: I'll shoot for about a minute, then allow slow benchmarks with environment variables.

this didn't quite work, I hit Ctrl-C on time_netlib after half an hour or so

@rgommers I haven't made that change yet.

If SCIPY_XSLOW evaluates false or isn't defined, the subset of benchmarks takes 3-5 min.
If SCIPY_XSLOW evaluates to true, the full set of benchmarks takes .
A few final questions:

This probably needs a rebase in for doc build to succeed on circleci. Should I do that?

ASV documentation states that the attribute number for timing benchmarks sets the number of times the benchmark runs. Is there an equivalent for track benchmarks, or do they always run only once?

The documentation also states that:

If there are changes in the source code of the benchmark in the benchmark suite, the version number changes, and asv will ignore results whose version number is different from the current one.

Does anyone know of a way I can force asv to display the old results even though the version number will change? I'd like to still see the old results on airspeed velocity of an unladen scipy, as I don't think the changes will substantially affect the timing results.

Closes gh-10647

@Kai-Striega Thanks for taking care of gh-10602. I'd also like to get this merged before the proposed enhancements so we can track improvements.

@mdhaber I haven't done all that much with asv, so I'm afraid I won't be too helpful. I'll play around with it over the next few days and get back to you.

@pv I think this one is getting close. Are you able to answer questions 2 and 3 above? In short:

I am trying to measure function execution time and track error in the result, but I don't want to repeat (time-consuming) function execution in a track_ method. To accomplish this, the time_ method of my subclass of Benchmark stores the result as an attribute. The track_ method then retrieves the result from the attribute, calculates the error, and returns the error. Is this a way to accomplish the goal?

This PR changes the benchmarks, but not so much as to invalidate past results. Is there any way to force airspeed velocity of an unladen scipy to continue to show old results along with the new?

Each benchmark runs in a new process, and they cannot communicate with each other. There is no support for "multi-result" benchmarks as of now. So you'd have to cobble it together with setup_cache.

I suggest to not care about that for now, it's easier to just rerun the benchmarks.

@Kai-Striega I think this is done if you have a chance to try running the benchmarks both with and without environment variable SCIPY_XSLOW=1 (if you can spare the CPU time)

Sure thing. I'll try run it when I get home from work.
As a rough estimate, how long would you expect it to take?
On Mon, 6 Jan 2020 at 13:43, Matt Haberland<EMAIL_ADDRESS>wrote:

@Kai-Striega https://github.com/Kai-Striega I think this is done if you
have a chance to try running the benchmarks both with and without
environment variable SCIPY_XSLOW=1 (if you can spare the CPU time)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/pull/10762?email_source=notifications&email_token=AHFOJNKFAAVLJCGTARIPDF3Q4LAJHA5CNFSM4ITGBW32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIEPJAA#issuecomment-571012224,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHFOJNLJ4LEOLTJ5QE6YOS3Q4LAJHANCNFSM4ITGBW3Q
.

With the environment variable, it took 2.5hr on my machine.

@mdhaber the benchmarks all ran in a little under two hours.  Here are the full results if required.
There are some things that I think need to be looked at:

track_* returns min(self.abs_error, self.rel_error). When we discussed it I thought it would be good to keep only a single number. Looking at the data now, I think that being unable to distinguish between absolute and relative error makes the results more confusing. Perhaps this should return both or only one (in which case this should be documented).

Some benchmarks fail, and do not return any time or error statistics. Did these also fail on your system and how should we treat failing benchmarks?

As an afterthought; currently, the benchmarks test the entire linprog function. What we're really comparing are the different solvers used. Perhaps it would be better to presolve the problem somewhere, cache the result and call the internal solvers directly?

I think that being unable to distinguish between absolute and relative error makes the results more confusing

What we're interested in is the behavior over time, so I don't think it matters much. The two numbers are related for a given problem, so I don't see a need to track both for every problem. I didn't want to choose either absolute or relative error across the board because for some problems one of these can be larger than what we typically would consider to be "good" (without knowing anything about the particular problem). The compromise was to take the minimum of the two.

No, none were failing last time I ran these. Maybe NumPy upgrade caused issues? I'll have to investigate.

I disagree. I think we want to see how the performance of linprog changes with each commit. I don't want changes to inadvertently decrease performance, and I want to see how much targeted changes improve performance.

I'll be happy to accept the compromise.

If they are not failing on your system I can dig around on mine to see if I can find the errors

You're right. I think I'm starting to hyper focus on just the solvers and losing sight of the big picture.

@Kai-Striega I'm getting some failures now. I'll look into it.

I think the revised simplex failures have always occurred; I knew that revised simplex couldn't solve all of these problems. I think we should let it fail and if/when we improve revised simplex it will be good to see them start to pass.
This is really strange, though. The interior-point failures do not occur when I run the problem without ASV. I have a script that basically just executes the Netlib.track_netlib  from optimize_linprog.py, and when I run it from my IDE it doesn't fail. I wonder if it's timing out?
Stranger still, though, is that 'sparse'=True is a lot slower for many problems; it used to be faster almost universally. And for the problems that interior-point 'sparse'=True is failing, it is taking a lot longer than 'sparse'=False and a lot longer than it used to. It seems like something has changed under the hood that is causing a regression. I'll have to take a closer look later.

@Kai-Striega I re-ran the benchmarks from a different computer that has NumPy 1.16.4 and for which the commits of this PR are based on c0dc7fccc53d8a8569cde5d55673fca284bca191. There are still a few failures, which must be due to timeouts, but there are no failures for sparse interior-point, and it is as expected much faster than dense interior point. I'll try to figure out whether the difference is due to the platform, BLAS, NumPy, or a later SciPy commit.

Ok. Let me know if you would like me to verify anything.

@kai-striega it's hard to interpret your results file. Can you tell me how long the Netlib (not RR) CYCLE  benchmark took for both sparse and dense interior-point? Did any other sparse tests fail? What OS, BLAS, and NumPy did you test with?

@mdhaber the file is a copy of the json file under scipy/benchmarks/results/KAI-T470/. It came out more clearly when opened as a json file but github wouldn't allow me to upload it, maybe try to convert it back to json? Either way here is the terminal output  in plain text.
The CYCLE timings are:
sparse: 8.27±0.02s
dense: 29.5±0.04s
The numpy verison was 1.18.0
My OS:
arch: "x86_64"
cpu: "Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz"
num_cpu: "4"
os: "Linux 4.4.0-17763-Microsoft" -> This is Ubuntu 18.04 LTS for WSL,  I've re-run some tests on vanilla Ubuntu, and they still fail.

In that case, it doesn't look like you're seeing the behavior I'm concerned about, where sparse is slower than dense.
So I don't think the failures are a problem. Most seem to be just timeouts, and that will be machine dependent. The rest aren't problems with the benchmarks themselves but with linprog, so the failures are doing their job in pointing us to issues with the linprog code.

@mdhaber there is another result I'm sceptical of:
optimize_linprog.Netlib_RR.track_netlib_rr
=====================================================
<function _remove_redundancy_sparse at 0x7fb01af56598>    WOOD1P    -129.0

I can't see a way that would come up naturally, are you getting this on your system?

Yes, I do get that.

I'm happy with it, and I don't think there's much to fear since it only modifies the linprog benchmark file. It will be helpful to have in, since we can use it to monitor performance changes due to other PRs e.g. gh-11226, gh-11245.

Thanks Matt. I've done some more experiments, the failures do seem to reflect failures of the underlying solver not an error in the benchmarks themselves. I'm happy to merge this.


Contains operator should be supported in OData query/UI

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Problem
i'm unable to use contains operator in storage explorer as i don't find this option
Desired Solution
Contains or string search operator should be supported.
Alternatives and Workarounds
No response
Additional Context
No response

Hi @Umapathymicrosoft unfortunately the table API only supports a subset of OData operators for entity queries. See here for more information: https://learn.microsoft.com/en-us/rest/api/storageservices/querying-tables-and-entities#supported-comparison-operators


Best sellers page added

resolve conflicts please

thankyou @ramyamahi, but please consider writing on the given PR template, don't remove that.


Update Test Features Herdoc

Although the current syntax works, it's not very "readable".
This does not change any functionality.

Thanks!!!