Feature: Make Money, Currency and ExchangeRate classes natively JSON serializable

Overview
I've been frequently using the money package to store values that needs to be persisted in a database or sent to some endpoint and, thus, need to serialize the classes. In all these applications, I end up writing a similar logic to serialize these objects, but it is sometimes hard to achieve without having to write other classes just to store the value, as the Money class is sealed. It would be much more convenient if the classes are natively (and safely) JSON serializable, which is why I'm opening this pull request.
Changes

Add fromJson and toJson methods to Money, Currency and ExchangeRate classes.
Add tests for all serialization/deserialization methods.

Additional Notes
When serializing the Fixed values for Money and ExchangeRate, the stored value will generate two keys: one for the minorUnits in double and the other for the scale as int. This choice is to preserve the integrity of the number, as it is not possible to save BigInt directly to Json and the serialization could end up truncating the values if saved as int. Despite double not being adequate for handling money, in this case there is no problem as the Fixed.minorUnits will always be a round number, only saved as double because of the range of this type on all languages. No fractional values will be saved as double, which could lead to lost in precision.
This update does not alter in any way the behavior of the classes, only adding the serialization/deserialization methods.

thanks for the PR. I'm not in love with using double. Can we not just use a string?

My mais reason to go with double instead of string was to allow for filtering or comparing the serialized values. If we are to store it on a database or any other place where we can filter results, using a numerical value can be used alongside the scale to perform calculations, and will occupy less space than storing strings.

so my next question is, given we are dealing with money do we really expect to see a value bigger than int64?
bit coin uses 8 digits which leaves 11 digits for the int part or 100,000,000,000 or 100 billion bit coins. There is a max of 21 million bit coins.
for standard usd that is 100,000,000,000,000,000.00  or 100,000 trillion. Total private net wealth of the world is 454 trillion.

In fact the largest number a double can store is 2^53, so now I think about it we should just be using an int64 as a double gives us no advantage.

The json spec doesn't actually put a limit on the size of an int but for practical matters it looks like 2^53 is the upper limit - as javascript doesn't support ints only doubles.
So I'm still inclined to think there is no value in using a double. We just store it as an int (by converting the bigint to a string but not quoting the json value).  The correct handling of values larger than 2^64 is then up to the end that parses these values.
The likes of mysql is also limited to 2^64 so if a user wants to store a large value then they are going to probably store it as a string anyway.

Your argument is totally right and gave me a better idea of how to serialize the amount as number without needing double and ensuring precision for valid money values. Instead of storing Fixed.minorUnits, which can get bigger than integer due to the scale of the currency, I changed to store the amount as separate Fixed.integerPart and Fixed.decimalPart, both as integers. The reconstruction can be safely performed concatenating them as a decimal string and this even facilitates numeric comparisons later on the serialized values. To ensure no lost in precision, I added a test with your example of a very large money number.
What do you think of this approach?

I'm wondering if we should add leading zeros to the decimalPart.
e.g. scale 4
10.0002
is written to json as:
amountIntegerPart: 10
amountDecimalPart: 0002
Whilst what you have done will work, I wonder if the above formatting would make the json easier for a human to read?
Also are we been overly verbose with the key names?
could we just use:
integer: 10
decimal: 0002
scale:  4
I'm also wondering if we should use decimals rather than scale, so maybe:
integerPart: 10
decimalPart: 0002
decimals:  4
isoCode: AUD
I'm not hung up on any of these changes, just throwing some ideas out there.  I will let you decided.
Otherwise I'm happy to merge.

can we add a test with a scale of say 10 just check the extreme end of large numbers of decimals.

just saw the formatting for the exchange rate:
/// instance using the [ExchangeRate.fromJson] factory.
Map<String, dynamic> toJson() => {
'exchangeRateIntegerPart': exchangeRate.integerPart.toInt(),
'exchangeRateDecimalPart': exchangeRate.decimalPart.toInt(),
'decimalDigits': exchangeRate.scale,
'fromIsoCode': fromCurrency.isoCode,
'toIsoCode': toCurrency.isoCode,
'toDecimalDigits': toDecimalDigits,
};
we should be consistent on naming conventions between the twol.

I'm wondering if we should add leading zeros to the decimalPart.
e.g. scale 4 10.0002
is written to json as:
amountIntegerPart: 10 amountDecimalPart: 0002
Whilst what you have done will work, I wonder if the above formatting would make the json easier for a human to read?
Also are we been overly verbose with the key names?
could we just use: integer: 10 decimal: 0002 scale: 4
I'm also wondering if we should use decimals rather than scale, so maybe:
integerPart: 10 decimalPart: 0002 decimals: 4 isoCode: AUD
I'm not hung up on any of these changes, just throwing some ideas out there. I will let you decided.
Otherwise I'm happy to merge.

Just simplified the key names - they were indeed more verbose than necessary - and standardized between Money and ExchangeRate. And I agree that adding leading zeros to the decimal part would make the JSON more human-readable, but I think it would add too much complexity with no benefits from the code perspective. In the end, the decoded values would lose the leading zeros, as they are integers. Otherwise, because toJson return a Map - not the JSON string itself - we would need to have integerPart as integer and decimalPart as string, which wouldn't make much sense.

can we add a test with a scale of say 10 just check the extreme end of large numbers of decimals.

I made one already with the scale of 12. Do you think we need another?

released as 5.4.0.
Greatly appreciate your work!!!

Thanks a lot! It was a pleasure to contribute!!


integrate graphql

issue is no longer relevant, as I have moved away from a webapplication model, and to a localhost, jupyter graph


Fixed  Overlapping of paragraph #171

Description
This Pr is about to fixes the unexpected behaviour of text paragraph this was fixed by changing some css .
closes : #171
Changes
Changes max-height of card2 to 20rem
removed height:100% from div under card2
changes max-height of img from auto to 18rem
Screenshots (if applicable)

Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I am working on this issue under GSSOC

Hii @Satyam1923 please put level label as well to be counted for leaderboard


ReplyKeyboardMarkup with RequestLocation Button Does not Reply any Messages

Steps to reproduce
Hey, there is a problem in your IOS Telegram Client
please read this note Carefully
Problem:
i used this code in my C# Telegram BOT:
var keyboard = new ReplyKeyboardMarkup(new[]
{
new KeyboardButton("Share location please")
{
RequestLocation = true
}
});
long Chat_id = Bot.SendTextMessageAsync(message.Chat.Id, "Custom Text", replyMarkup: keyboard).Result.Chat.Id;
What Code do ?
This code send a keyboard with Share Location Button to Client and when Client click on the button his location will share and location message have reply message id
So what is problem ?
This Code Works Fine on Andriod and Desktop Version of Telegram but in IOS version when Client Click on Button that Location was sended is not reply
its just a Normal Location Message without Reply any other message
and its important for my Bot that receive a replied Location Message
Actually i just Receive a Location without this => "ReplyToMessage.MessageId;" Value in C#
Output in Andriod: (Works Fine)

Output in iOS: (Problem)

in this picture you see Location is not replied Message but Client clicked on ReplyKeyboardMarkup Button
Expected  behavior
it must send a Location Message that Replied a Text Message
Actual behavior
In Telegram IOS version ReplyKeyboardMarkup does not reply any thinks
NuGet Package Version: <IP_ADDRESS>
.NET Version: 4.6
IDE: VS2013
App: iOS

Dear saswn,
This sounds like an issue with the Telegram platform itself, and not the library. Please contact https://telegram.me/BotSupport, they will probably be able to help you with your problem.
If the problem is not caused by the library, please close this issue, otherwise clarify how this problem comes from the library.
Kind regards,
Martijn Verbakel

@saswn,
It can be solved by set for the Selective property false value.
Take a look here.


chore: added asb and reorg'd

Separated out the parts for the library entry and added asb to simplify the building.  Also updated readme.

This looks great! Thanks for the contribution @willemneal & @jtenner.


Specify which columns to keep

Currently, I think pandas-profiling auto-rejects the columns that are highly correlated to previous columns. This is nice.
However, there are some important features that I would like to include in the final data frame (for the purpose of interpretability of a Machine Learning model). Is there a way for me to specify some important columns that I want to keep? It means that if this column is highly correlated with a previous column, the previous column will be rejected.

I had a similar request. But, for now, hopefully, this workaround will be a welcome contribution to the conversation on this issue?
import pandas as pd
import pandas_profiling

# I am a fan of this data set.
df = pd.read_stata('http://www.stata-press.com/data/r15/auto2.dta')

# Length left out due to correlation with weight.
pandas_profiling.ProfileReport(df)

# Pass rejected variables to new profile report.
rejected = pandas_profiling.ProfileReport(df).get_rejected_variables(threshold=0.9)
pandas_profiling.ProfileReport(df[rejected])

@adamrossnelson thank you for helping, there is indeed the correlation_overrides parameter, @tqa236 does this solve your problem?

Hello, thank you for the code, I just reinstall version 2.0.0 of this package (which doesn't exist on Anaconda yet) and I think my problem is just half solved.
The part that is

solved: I can keep the columns I want to keep.
not solved: A general column is not automatically rejected even if there's a correlation.

For example, column 2, 4 and 5 are highly correlated in my data frame. By default, this package will eliminate column 4 and 5.
df.profile_report()

However, I want to keep column 4, in this case, only column 5 is rejected. Column 2 is still kept.
df.profile_report(correlation_overrides="Column 4")

I would like to reject both column 2 and 5 in this case and I think it's better than just reject column 5.
What is your opinion?

IMHO a simple 'reject nothing, but report high correlation warning anyway' option would be nice. With the solution above, I have to run the report twice, and I don't get the warning.

I'm a fan of this package. This enhance would be pretty helpful. GitHub just marked it stale?
I might be able to contribute code for this enhancement I'm March. But, I'd also ask from the creator of am enhancement is in the works?

This issues shouldn't have been closed. The Github Actions does not remove the no-issue-activity label on comments (see https://github.com/actions/stale/issues/21).
@adamrossnelson Thank you for picking this up. A PR is welcome :) The behaviour towards rejecting variables has changed in the time since this issue was opened, please make sure you check how the latest version handles these, to prevent double work.

I am contributing three more work around options. These were inspired by @tobycheese who said: "IMHO a simple 'reject nothing, but report high correlation warning anyway' option would be nice. With the solution above, I have to run the report twice, and I don't get the warning." This comment got six thumbs up. For what it is worth I think this problem has been solved by the addition of the check_correlation attribute (also demonstrated below).
The first new work around is to leverage the existing correlation_overrides attribute. To do this pass df.columns.tolist() to the attribute:
import pandas as pd
from pandas_profiling import ProfileReport
df = pd.read_stata('http://www.stata-press.com/data/r15/auto2.dta')
ProfileReport(df, correlation_overrides=df.columns.tolist())

The second new work around is to leverage the existing correlation_threshold attribute. To do this pass the value 1 to the attribute:
import pandas as pd
from pandas_profiling import ProfileReport
df = pd.read_stata('http://www.stata-press.com/data/r15/auto2.dta')
ProfileReport(df, correlcorrelation_threshold=1))

The third new work around is to leverage the existing check_correlation attribute. To do this pass False to the attribute:
import pandas as pd
from pandas_profiling import ProfileReport
df = pd.read_stata('http://www.stata-press.com/data/r15/auto2.dta')
ProfileReport(df, check_correlation=False))

These solutions do not fully solve the issue(s) as it is described by @tqa236. However, I would propose that the best solution for picking and choosing which columns to include or not include would be to re-order the columns. Place the column you desire to keep ahead of the other columns. Reordering columns in Pandas is not a simple task, really. But here is a useful reference:
https://towardsdatascience.com/reordering-pandas-dataframe-columns-thumbs-down-on-standard-solutions-1ff0bc2941d5
I'm planning a PR that will elaborate on the descriptions of these attributes. Will reference this issue in the PR.


lighttpd: fix build on darwin x86_64

Motivation for this change
#157021 broke build of lighttpd on darwin x86_64. Notably not darwin aarch64 because it uses a newer macos SDK.
Upstream have already noticed and fixed this.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Thanks!


[ISSUE #6722]Bugfix timer thread has error when timer not enable

Which Issue(s) This PR Fixes

Fixes #6722
Brief Description
关于timer延时消息的开关不严谨导致broker error log 过多的问题。当关闭timer延时消息功能时broker上的timer 相关thread任然在运行导致触发error log。
How Did You Test This Change?

The code is ok, code style need to format.

done,commit:27e9aa8;
format code

Codecov Report

Merging #6723 (27e9aa8) into develop (f33ac2a) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6723      +/-   ##
=============================================
+ Coverage      42.89%   42.91%   +0.02%
+ Complexity      9007     9006       -1
=============================================
  Files           1113     1113
  Lines          78591    78593       +2
  Branches       10221    10223       +2
=============================================
+ Hits           33709    33726      +17
+ Misses         40659    40646      -13
+ Partials        4223     4221       -2

Impacted Files
Coverage Δ

...a/org/apache/rocketmq/broker/BrokerController.java
46.39% <0.00%> (+2.84%)
:arrow_up:

...apache/rocketmq/broker/slave/SlaveSynchronize.java
4.16% <0.00%> (-0.03%)
:arrow_down:

... and 21 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Escape html data to not break layout

Copied html is being displayed a bit weird when we use the v-html attribute. This fix escapes text content, but leaving other content like images untouched. Pasting into the clipboard is not affected.
Before:

After:

It's still not 100% perfect. For some reason the copied html is clipped/hidden, but I still think it's better than before :)

Sorry, didn't realise this was already handled in the dataShow computed. The regex needs a little love though, I'll see if I can have a look at it.

Should work now. All elements except b-tags are escaped. That way highlighting works as expected as well.

Sorry, didn't realise this was already handled in the dataShow computed. The regex needs a little love though, I'll see if I can have a look at it.

After your reminder, I found that tags starting with <b****> will not be filtered, and blank items will not be filtered either. I can consider directly filtering this kind of content that has no other content except html tags when reading the clipboard.

I've found that there are always bugs with regex.
Like this case <img src='https://xxx.xxx.com/case.png'/> , if i search case regex can't work.
Thanks, I fix it in Rust way.
https://github.com/ChurchTao/Lanaya/commit/c98c464378ff0c32e0ecfeb4e4c1cc1892a7bf9b


Possibility to use Local Sendmail?

I wounder if I can actually use my local sendmail daemon (which pipes system-wide mail to an external SMTP server) with isso? The config file only demonstrated with SMTP, and I would like to know if sendmail support is possible.

This is linked to the syscall pr. Y ou can try it by cloning the pr or wait for it to be reviewed and merged.

I was curious about this, too, I think this PR is meant https://github.com/posativ/isso/pull/457

This might be implemented during a more comprehensive overhaul of the whole logging and notification architecture. Closing as stale since no one wants to work on this.


years ago should up to 1 decimal place

Description
This is a v.v.v.v.v Minor issue but I've been running a memcache container for a while on one of our hosts:
$ docker ps
CONTAINER ID        IMAGE               COMMAND                CREATED              STATUS              PORTS                      NAMES
acbf82de3747        5a3c40e344ce        "/bin/sh -c '/usr/bi   2.007922 years ago   Up 2.004308 years   <IP_ADDRESS>:11211->11211/tcp   memcache

I think the "years ago" could be formatted as a integer or maybe 1 decimal place. 6 decimal places seems excessive :exclamation:
Steps to reproduce the issue:

Run a container for a couple of years. (:stuck_out_tongue_winking_eye: )
Do docker ps

Describe the results you received:
CREATED and STATUS shows time as "2.007922 years ago".
Describe the results you expected:
I think simply 2 years ago would make a nice UX for docker ps.
Output of docker version:
Docker version 1.3.0, build c78088f

Output of docker info:
Containers: 1
Images: 44
Storage Driver: devicemapper
 Pool Name: docker-202:1-271321-pool
 Pool Blocksize: 65.54 kB
 Data file: /var/lib/docker/devicemapper/devicemapper/data
 Metadata file: /var/lib/docker/devicemapper/devicemapper/metadata
 Data Space Used: 1.103 GB
 Data Space Total: 107.4 GB
 Metadata Space Used: 2.699 MB
 Metadata Space Total: 2.147 GB
 Library Version: 1.02.82-git (2013-10-04)
Execution Driver: native-0.2
Kernel Version: 3.13.0-36-generic
Operating System: Ubuntu 14.04.5 LTS
Username: xxxx
Registry: [https://index.docker.io/v1/]
WARNING: No swap limit support

Additional environment details (AWS, VirtualBox, physical, etc.):
AWS - c3.2xlarge.
(If anyone responds with "Please re-test with a later version of docker", I will laugh and get back to them in 2 years, ho ho ho.)

Rounding to whole years seems reasonable. Do you want to do a PR?

@justincormack

Do you want to do a PR?

Sorry, My Go fu isn't up to it. I found where the code for docker ps is (cli/command/container/list.go) but not where the CREATED table column is formatted. The HumanDuration function (vendor/src/github.com/docker/go-units/duration.go) already looks like years would output as a integer.

Does seem somewhat precise! Do you want to make a PR? I think whole years
is OK.
On 25 Oct 2016 10:51 a.m., "Tom Fotherby"<EMAIL_ADDRESS>wrote:

Description
This is a v.v.v.v.v Minor issue but I've been running a memcache
container for a while on one of our hosts:
$ docker ps
CONTAINER ID        IMAGE               COMMAND                CREATED              STATUS              PORTS                      NAMES
acbf82de3747        5a3c40e344ce        "/bin/sh -c '/usr/bi   2.007922 years ago   Up 2.004308 years   <IP_ADDRESS>:11211->11211/tcp   memcache
I think the "years ago" could be formatted as a integer or maybe 1 decimal
place. 6 decimal places seems excessive ❗
Steps to reproduce the issue:

Run a container for a couple of years. (😜 )
Do docker ps

Describe the results you received:
CREATED and STATUS shows time as "2.007922 years ago".
Describe the results you expected:
I think simply 2 years ago would make a nice UX for docker ps.
Output of docker version:
Docker version 1.3.0, build c78088f
Output of docker info:
Containers: 1
Images: 44
Storage Driver: devicemapper
Pool Name: docker-202:1-271321-pool
Pool Blocksize: 65.54 kB
Data file: /var/lib/docker/devicemapper/devicemapper/data
Metadata file: /var/lib/docker/devicemapper/devicemapper/metadata
Data Space Used: 1.103 GB
Data Space Total: 107.4 GB
Metadata Space Used: 2.699 MB
Metadata Space Total: 2.147 GB
Library Version: 1.02.82-git (2013-10-04)
Execution Driver: native-0.2
Kernel Version: 3.13.0-36-generic
Operating System: Ubuntu 14.04.5 LTS
Username: pphrobot
Registry: [https://index.docker.io/v1/]
WARNING: No swap limit support
Additional environment details (AWS, VirtualBox, physical, etc.):
AWS - c3.2xlarge.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/27726, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdcPPkOGuy1XZvAs55_IkYkwvngAwdVks5q3dEcgaJpZM4Kfxta
.

Looks like this was an issue in docker 1.3.0, but fixed since. Docker 1.3.0 used a float; https://github.com/docker/docker/blob/v1.3.0/pkg/units/duration.go#L30
This is a duplicate of https://github.com/docker/docker/issues/12852, and was fixed in https://github.com/docker/docker/pull/12888, so I'm closing this. Perhaps time to upgrade :smile:


WIP: Finer-grained parallelism for Parquet Scan

Which issue does this PR close?
Part of #944
It's currently and WIP since it relies on a new Arrow release. To be specific, it needs https://github.com/apache/arrow-rs/commit/2bca71e322fcab6c6d93a47ef71638a617e29f6c
Rationale for this change

An easier and more feasible way to parallelize parquet file scan.
By introducing a new configuration max_bytes_per_partition (TODO), we could generate partitions each of desirable size. And likely to scan only part of the row groups from a big parquet file.
The file range is passed down to the parquet crate and filter row groups according to its position in the parquet file.
What changes are included in this PR?

Are there any user-facing changes?

Yes, a new configuration to set desirable scan partition size.

cc @tustvold

I'm not sure I follow how this will work, parquet files have a block structure internally that is not amenable to seeking. Particularly with RLE data, it is common for a column chunk to consist of a single page. Could you maybe expand a bit on this?

Hi @tustvold , the filter is based on row-group midpoint position. It was introduced recently in parquet crate with https://github.com/apache/arrow-rs/commit/2bca71e322fcab6c6d93a47ef71638a617e29f6c. The midpoint filtering is modeled after the ParquetSplit and MetadataConverter
The parquet row groups level parallelism is used in MapReduce and Spark. In Spark splitFiles is used to generate task partitions based on partition size settings. And it may partition bigger parquet file parts to different partitions.
Currently, this PR is still WIP, since only physical plan changes are implemented. And we translate Spark physical plan to DataFusion physical plan to run natively in DataFusion https://github.com/blaze-init/spark-blaze-extension/blob/master/src/main/scala/org/apache/spark/sql/blaze/plan/NativeParquetScanExec.scala#L57-L63

Oh I think I misunderstood, this is using byte ranges to filter row groups, not to filter within row groups?

Yes, to filter row groups, based on RowGroup Metadata as well.

@liukun4515  there are already some configuration settings related to parallelism
target_partitions (like degree of parallelism)
https://github.com/apache/arrow-datafusion/blob/4994eda81c2280fa78aea1ae0d92ce918947eebd/datafusion/src/execution/context.rs#L822-L823
batch_size (that controls how many batches are processed)
https://github.com/apache/arrow-datafusion/blob/4994eda81c2280fa78aea1ae0d92ce918947eebd/datafusion/src/execution/context.rs#L909-L914
I am not sure how well these two parameters are respected in all DataFusion operators, but I think the configurations settings are reasonable

Since @tustvold is working on the new task scheduler in DataFusion, I keep this PR containing only physical plan changes. Leave planner or API unchanged.
The current changes are still helpful for downstream projects like Ballista or our Blaze, where query planning is done separately, no matter what we take later in DataFusion core. In Blaze, we use the Spark way of deciding InputSplits based on total dataset size and assigning parts of a big parquet file to multiple tasks.
@alamb @tustvold @liukun4515, please let me know what you think about this.

Makes sense to me, regardless of what happens with scheduling, having a mechanism to cheaply subdivide the input streams directly, as opposed to streaming the output through a repartitioning operator, seems like a useful feature to have.
My expectation is scheduling will help with  over-provisioned parallelism in the plan, but will still need mechanisms to express that parallelism in the first place 👍

@alamb @tustvold, could you please give another look at this? Thanks!

🎉


connecting to host with path

Hello how do I connect to a host using and address in the form "wss://host_ip:port/ws"
for now I notice  mqtt::make_tls_sync_client_ws( m_ioService, "host_ip", soaPort );
the prefix "wss" is added by the lib but I can't add the "/ws"
Thanks for any help

mqtt_cpp doesn't provide URL parse functionality.
So, you need to parse by yourself.
And then, you can pass the arguments as follows:
auto client = make_tls_client_ws(ios, "host_ip", port, "/ws");

Thanks for your reply redboltz  but for now I don't need to parse the URL but it seem if I pass these arguments to like "auto client = make_tls_client_ws(ios, "host_ip", port, "/ws");"
I would be connecting to something like ws://host_ip:port
But I would like to connect to something like ws://host_ip:port/mosquitto/ws
since I'm connecting to a reverse-proxy how to I set " /mosquitto/ws" part
thanks for any comments.

auto client = make_client_ws(ios, "host_ip", port, "/mosquitto/ws");

Great! thanks.


Parse error. Cycle detected in inheritance chain

/** @type {!Array<!MyItem2>} */
var MyList;

/**
 * @record
 * @struct
 */
var MyItem = function() {};

/**
 * @record
 * @struct
 * @extends {MyItem}
 */
var MyItem2 = function() {};

WARNING - Parse error. Cycle detected in inheritance chain of type MyItem2
/** @type {!Array<!MyItem2>} */
                   ^

There is no warning when:

MyList declaration goes after MyItem2 OR
MyItem is annotated with @interface instead of @record OR
MyList is defined as @type {!Array<!MyItem>}

https://closure-compiler-debugger.appspot.com/#input0%3D%252F**%2520%2540type%2520%257B!Array%253C!MyItem2%253E%257D%2520*%252F%250Avar%2520MyList%253B%250A%250A%252F**%250A%2520*%2520%2540record%250A%2520*%2520%2540struct%250A%2520*%252F%250Avar%2520MyItem%2520%253D%2520function()%2520%257B%257D%253B%250A%250A%252F**%250A%2520*%2520%2540record%250A%2520*%2520%2540struct%250A%2520*%2520%2540extends%2520%257BMyItem%257D%250A%2520*%252F%250Avar%2520MyItem2%2520%253D%2520function()%2520%257B%257D%253B%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1

Maybe the typechecker does something strange when you have an @record with no fields or methods?

Looks like it. When MyItem2 has a property, the warning goes away.
https://closure-compiler-debugger.appspot.com/#input0%3D%252F**%2520%2540type%2520%257B!Array%253C!MyItem2%253E%257D%2520*%252F%250Avar%2520MyList%253B%250A%250A%252F**%250A%2520*%2520%2540record%250A%2520*%2520%2540struct%250A%2520*%252F%250Avar%2520MyItem%2520%253D%2520function()%2520%257B%257D%253B%250A%250A%252F**%250A%2520*%2520%2540record%250A%2520*%2520%2540struct%250A%2520*%2520%2540extends%2520%257BMyItem%257D%250A%2520*%252F%250Avar%2520MyItem2%2520%253D%2520function()%2520%257B%257D%253B%250A%250AMyItem2.prototype.p2%253B%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1
@vobruba-martin When MyItem and MyItem2 have no properties, they are actually equivalent types, since they are both records, so they're checked structurally. So, the warning is somewhat legit, because a type is extending itself. (But the location of the warning is completely wrong; I don't know why that happens.)

That makes sense but why there is no warning when MyList is moved after MyItem2?
https://closure-compiler-debugger.appspot.com/#input0%3D%252F**%250A%2520*%2520%2540record%250A%2520*%2520%2540struct%250A%2520*%252F%250Avar%2520MyItem%2520%253D%2520function()%2520%257B%257D%253B%250A%250A%252F**%250A%2520*%2520%2540record%250A%2520*%2520%2540struct%250A%2520*%2520%2540extends%2520%257BMyItem%257D%250A%2520*%252F%250Avar%2520MyItem2%2520%253D%2520function()%2520%257B%257D%253B%250A%250A%252F**%2520%2540type%2520%257B!Array%253C!MyItem2%253E%257D%2520*%252F%250Avar%2520MyList%253B%250A%250A%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1

I'm not sure why.
To be clear, I agree that there is a compiler bug here. I'm just saying it's not super high priority to fix, because having an empty record extend an empty record isn't useful in practice.

Actually it's any record (not just empty) extended by an empty record. I did it this way because I knew that MyItem2 will have new properties in future and I wanted to prepare my code for this new type. Anyway I will add a dummy property. Thanks!

I just hit this.  Here's the externs I was using:
/**
 * @fileoverview An extern for the doctrine, a JSDoc parser at
 * https://github.com/eslint/doctrine
 * @externs
 */

/** @const */
const Doctrine = {};

/**
 * @typedef {(
 *     !Doctrine.NullableLiteral
 * )}
 */
Doctrine.TagType;

/** @record */
Doctrine.Typeable = function() {};
/** @type {string} */
Doctrine.Typeable.prototype.type;

/** @record @extends {Doctrine.Typeable} */ Doctrine.NullableLiteral = function() {};
/** @record @extends {Doctrine.Typeable} */ Doctrine.AllLiteral = function() {};
/** @record @extends {Doctrine.Typeable} */ Doctrine.NullLiteral = function() {};

/** @record @extends {Doctrine.Typeable} */ Doctrine.ArrayType = function() {};
/** @type {!Array<!Doctrine.TagType>} */ Doctrine.ArrayType.prototype.elements;

Closure compiler debugger - doctrine externs
The error goes away if:

I make !Doctrine.Typeable an interface.
I remove the typedef.
I inline the type attribute onto NullLiteral.

Heres' another repro (we're hitting this too). Oddly enough, even the exports assignment below seems to be load bearing, at least it doesn't repro without it.
goog.module('x');

/** @record */
function RequestOptionsArgs() { }
/** @type {string} */
RequestOptionsArgs.prototype.url;

/**
 * @record
 * @extends {RequestOptionsArgs}
 */
function RequestArgs() { }
exports.RequestArgs = RequestArgs;
/** @type {string} */
RequestArgs.prototype.url;

/** @param {RequestArgs} args */
function x(args) {}

I believe this got fixed as part of the cleanups that @nreid260 has done.
At any rate the original repro link no longer produces an error.


Allows the user to configure the default integrated shell for debugging in launch.json

This extension needs the "terminal.integrated.shell.windows" set to
"C:\Windows\System32\cmd.exe" for "Python: Current File (Integrated Terminal)" and if "terminal.integrated.shell.windows" in settings.josn has been changed, debugger will not work.
For the convenience of testing, I set the "terminal.integrated.shell.windows" to python.exe that allow me to use python shell in vs code Integrated Terminal, is works like IDLE interactive mode.
But when I press F5 to run my code, the launch.json is set to use "terminal.integrated.shell.windows" to launch the program, due to I changed the "terminal.integrated.shell.windows" to python.exe so the debugger tries to launch the program, using python, that is definitely won't work.
The terminal window shows below
`>>> cd "c:\Users\Chores\Desktop\Python" && cmd /C "set "PYTHONIOENCODING=UTF-8" && set "PYTHONUNBUFFERED=1" && "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe" c:\Users\0.0.vscode\extensions\ms-python.python-2019.6.22090\pythonFiles\ptvsd_launcher.py --default --client --host localhost --port 7077 "c:\Users\Chores\Desktop\Python\Test.py" "
File "", line 1
cd "c:\Users\Chores\Desktop\Python" && cmd /C "set "PYTHONIOENCODING=UTF-8" && set "PYTHONUNBUFFERED=1" && "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe" c:\Users\0.0.vscode\extensions\ms-python.python-2019.6.22090\pythonFiles\ptvsd_launcher.py --default --client --host localhost --port 7077 "c:\Users\Chores\Desktop\Python\Test.py" "
^
SyntaxError: invalid syntax

`

I hope the extension debugger could add a setting item in launch.json which allows the user to select another "terminal.integrated.shell.windows" in different launch configurations. When the debugger is going to run(F5 pressed), using the shell which selected in the launch.json to replace the shell which was selected in the settings.json.
In other words, it means to allow the user to select a "Runtime shell" in launch.json

Using python as default terminal

Explain:
Using a cmd terminal or other user set terminal for debugging (after press F5), using user set terminals like python, bash or other when not in debugging.

I'm closing this issue as this is not a scenario that we intend to support.
You cannot use the python executable as a shell for debugging.
If you want to just launch the Python REPL, then please use the command Python: Start REPL


Is it possible to create different channels using different consensus algorithms in one system and have access to each other?

Current Status
Can I create multiple channels in a fabric-based system, with different channels configured with different consensus algorithms, and can different channels access data in each other's channels?
Expected
Implement a system in which different channels can be created, different channels can be configured with different consensus algorithms, and channels can access each other's data in each other's channels。
Solution
No response
Please let us know if you plan to work on this.
No response

Yes you can run an orderer with a chain running BFT and a different chain running Raft.
I've seen it happen live in the demo here: https://www.youtube.com/watch?v=4taLwa_pl9U


[EXPERIMENTAL] Add option :as for Mapper

This override the table_name
Resolves #120
The idea is to allow collection to have custom table name, this comes useful for the inherited entity usecase. Please see #120 for more details.

I close this PR for now


WebglRenderer

Why is it possible for my browser to look at the proton-sun example with webglrenderer
But when I try using a WebGLrenderer on my own pages, the browser complaoins that it doesn't support webgl ?
How can I make my pages able to use webglrenderer (without enabling webgl bits in browsers) ?
Or is there a way to blend particles with CanvaRenderer ?

what system and version of browser are you using

Thanks for your feedback. I was answering you when I hade the idea to make another test.
I updated my simple html page and managed to use the WebglRenderer in Chrome & Firefox (on my ubuntu box).
In fact,The Webglrender issue I'm seeing only affects the local webapp I'm writing with sveltekit & node
So, this is not an issue with Proton which works just fine, but probably with either
I'll test in a few weeks (when I build the production app) if the issue appears on the production webapp too
node.js
sveltekit (I should update that to a newer version)
{
npm: '7.17.0',
node: '14.17.0',
v8: '8.4.371.23-node.63',
uv: '1.41.0',
zlib: '1.2.11',
brotli: '1.0.9',
ares: '1.17.1',
modules: '83',
nghttp2: '1.42.0',
napi: '8',
llhttp: '2.1.3',
openssl: '1.1.1k',
cldr: '38.1',
icu: '68.2',
tz: '2020d',
unicode: '13.0'
}
This is a NON issue, so I'm closing it.
I wish you a good day, sir ! :)


My console is full of this when i start the server with pma-voice

Did you update server artifacs?

Seems like a author issue, I don't know how you're on a build that old, but pma-voice is designed for the latest version & onesync infinity.


fix a problem with tautomeric systems being extended too far

The major changes here:

The aromaticity of atoms is no longer checked to determine whether or not they are candidates for being in a tautomeric system; the condition now is simply that they must have either an unsaturation or an implicit hydrogen.
The condition for a bond to be considered a starting bond for a tautomeric system is that the bond must have a heteroatom on one end and an unsaturated atom on the other (it's fine for both ends to be heteroatoms and/or for both ends to be unsaturated).

First example molecule, from @d-b-w :

The current version of the code finds a tautomeric region here, and all atoms are involved, so the hash is:
[C]:[N]1:[C]:[C]:[C]:[C]:1_7_0

After this PR no tautomeric region is found because all valences on the N are filled, so the hash is:
[CH3]-[n]1:[cH]:[cH]:[cH]:[cH]:1_0_0

Second example molecule, from @rachelnwalker:

The current version of the code produces the hash:
[C]1:[C]:[N]:[N](:[C]:[C]2-[CH2]-[NH]-[CH2]-[CH2]-[O]-2):[C]:1_6_0

The tautomeric region here includes the 5-ring, as expected, but also extends to the bridging atom and the chiral atom in the 6-ring.
After this PR, the tautomeric region only includes the 5-membered ring:
[C]1:[C]:[N]:[N](-[CH2]-[C@H]2-[CH2]-[NH]-[CH2]-[CH2]-[O]-2):[C]:1_3_0

Third example: the following two molecules were previously not recognized as being tautomers of each other:

They now prodouce the same tautomer hash.
Fourth example: these two molecules are no longer considered to be tautomers of each other:

@d-b-w @rachelnwalker : you may want look at this one too.


Automatically add SSH client/demon

Would it be possible to extend the command to also install the SSH client and/or daemon if these are not found?
It would be cool to just Enable-SSHRemoting and know that it just works to enable fully SSH on this host.

Check pull request, I have added few commands what will install OpenSSH Server & Client on Windows platform


Code cleanup + some bug fixes

Refactor the code so that the variables are easily identifiable + some robustness improvements (the variables should be quoted) and general clutter cleanup.
This time I've tested the script (last time I was checking the wrong branch) 🙂

Wow! Another amazing effort.
Again, i'll review the changes and test them and will then merge the pull request.
Can we say that the script is now more reliable on various types sh of shells?

Can we say that the script is now more reliable on various types sh of shells?

As of now the script is bash specific unless you call it with other shells like: zsh nmapAutomator.sh or sh nmapAutomator.sh (though sh may be bash itself as it is system specific).
This said, the script is now more robust (meaning: less chances to break under unexpected input/grep-parsing, etc).
But don't worry as I plan to make this script 100% POSIX so that it can be executed in any shell (sh, bash, zsh, ash, dash, etc).
Reaching POSIXness is important as it will allow to run the script in any machine with a POSIX shell, really useful for the PWK course and OSCP exam as you would be able to run the script in any victim's machine (providing they have nmap installed, though sending a static nmap to the victim is always possible) targeting the internal network (hugely increasing the speed of the nmap scan).

Excellent. This should really increase the use cases and productivity in general of the script.
Thanks again for the amazing efforts.

What I think it is important is to have a "coding standard" document (or section in the README), basically saying to:

Respect the current indentation and code structure (maybe you should be more explicit about what you want your code to look like)
Naming convention for variables and functions (and be more explicit about what you'd like)
Enclose all variables in ${}, for example ${my_var}, as it makes the code more readable (it is easier to see where the variables are at glance)
Always quote the variables except when intentionally wanting to use the IFS/shell-splitting, for example echo "${my_var}"
Use POSIX commands (or open an issue if they don't know how to re-write what they want to add in a POSIX way)
Anything else I am forgetting 🙂

Yeah definitely, to ensure it doesn't break POSIX and readability. I'll add that either to README or its own document.
I think being 100% POSIX would be huge, especially for lateral movement and internal network scanning and enumeration.
In this case i may add a flag for nmap path, that defaults to the default path if not specified. This is to enable using a static nmap when needed.
I'll also wait on testing and reviewing the changes if you have any more changes coming, so that i don't have to go through them twice :)

I'll create a different pull request for the POSIX changes, you can wait if you prefer though I will only have time to start working on them in around 6 hours 🙂

Great effort @caribpa. Well done.

I think once you're done i'll work on adding a --remote mode, where the script switches to using POSIX commands only, even for basic recon.. i'll also add --nmapDir to allow for transferring nmap for --remote mode.
This'll make nmapAutomator great for lateral movement.


make GitHub action for compiling API documentation and posting to readthedocs

It would be good to test out locally first with Sphinx to make sure there's no doc compilation errors.
See here for example:
https://github.com/UC-Davis-molecular-computing/scadnano-python-package/blob/master/.github/workflows/docs-check.yml

Note that the above just checks there are no errors in running sphinx. To automatically post to readthedocs involves pointing a readthedocs project at the GitHub repo. I don't remember exactly how to set that up. But eventually it involves having a page like this on readthedocs:


Selecting 6 for Ventura actually downloads Sonoma

Which operating system are you trying to install?
macOS Ventura
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Run setupArch.sh
Select Ventura with 6

Expected behavior
Ventura should be downloaded and run.
Screenshots

Desktop (please complete the following information):

OS: Arch Linux

Additional context
I don't think a cosmic ray flipped a bit, changing 6 to 7, but I suppose it's possible.

Are you on the latest version of the repository?

@notAperson535 Yes, I had just cloned it.

I know I'm not the original issue reporter, but as far as I can see, it seems to be correctly downloading Ventura now (I get an option to reinstall Ventura in the recovery program). Hopefully @askiiart can say if it's fixed for them too?

I'll just close the issue. Multiple server members have been downloading ventura, so I think it's fixed. Feel free to let me know if it's not @askiiart .


There are no docs around creation of specific service triggered functions on VSCode (i.e. timer, eventhub, etc.)

Currently, there is no documentation around creation of any other triggered function besides HTTP triggered.  Each of the creation paths contain important steps that might not be immediately obvious to users and so better documentation in the short description below or dedicated documentation page might be useful to have (even if it's a reference style page with each of the steps laid out with more explanations).
However, I'd like to examine what exactly needs to take place in order to fill this gap.  For the time being, we can take a look at some of the telemetry around how many people exit out of a function creation process in order to see how relevant this is.
An example around this is during some customer interviews, NCRONTAB is not super obvious and so they exited out to look it up and could be a point where users churn.

See comments elsewhere https://github.com/microsoft/vscode-azurefunctions/issues/2644#issuecomment-767781767 https://github.com/microsoft/vscode-azurefunctions/issues/2646#issuecomment-767810833. My team generally does not own the documents or templates.

See comments elsewhere https://github.com/microsoft/vscode-azurefunctions/issues/2644#issuecomment-767781767 https://github.com/microsoft/vscode-azurefunctions/issues/2646#issuecomment-767810833. My team generally does not own the documents or templates.


Link to travis if .travis.yml is found

It'd be nice to have a small indicator/icon next to the title, that links out to travis. Example:

If we can steal GitHub's own marker from the commits list, it'd be great, otherwise just a link to travis would suffice.

@bfred-it Why not all ci's?

Sure, if we can actually use GH's own indicator + link we're set, otherwise it might not be as easy.

This is the core functionality:
const doc = await fetch('/sindresorhus/refined-github/commits/').then(r => r.text()).then(domify);
const status = select('.commit-build-statuses', doc);
if (status) {
    select('.pagehead [itemprop="name"]').append(status);
}

I needs styling fixes

I still think this would be much better if we detect whether this is Travis CI, Circle CI etc. (via filenames or another method) and add the respective icon next to the repo name. On Travis CI they link back to the GitHub repo with a GitHub icon.
Also, keep in mind a repo could use multiple services adding a commit status so this becomes more tricky. We might not have a single link to add.
I've previously used this: https://chrome.google.com/webstore/detail/github-travis-ci-builds/dphnhapafaimelkockemokgfdocadbdo But it had its problems and I found myself using it mostly to find out if the repo has Travis CI and go to the latest build.

Why would a link be better than the GitHub’s own status indicator? I think the commits page automatically includes all CIs

@bfred-it The status indicator is fine and should be there, but I think a direct link to the latest build is superior in terms of experience.

Yep that's part of the indicator itself:

I think this is a killer feature and GitHub should implement it. Just by looking at the amount of build badges people care a whole lot about it being green.


Mark Fabrishot to be 1.19.3 compatible on CurseForge and Modrinth

Hello, can you mark Fabrishot to be 1.19.3 compatible on both CurseForge and Modrinth?

Is it actually compatible? If so I'll do it

I will try testing if that mod works on 1.19.3 too, then I will let you know


DNM, copy pr of #3965, trigger action test only

What problem does this PR solve?
DNM, copy pr of #3965, trigger action test only
What is changed and how it works?
enable DM github action tests on pull request to master
Check List
Tests

Unit test
Integration test

Release note
None

/hold

Codecov Report

Merging #3966 (c138878) into master (3873d39) will decrease coverage by 1.7436%.
The diff coverage is 61.7801%.

Flag
Coverage Δ

cdc
58.4275% <61.7801%> (+0.1909%)
:arrow_up:

dm
52.6990% <ø> (-3.3356%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #3966        +/-   ##
================================================
- Coverage   57.0741%   55.3304%   -1.7437%
================================================
  Files           478        484         +6
  Lines         56551      59141      +2590
================================================
+ Hits          32276      32723       +447
- Misses        20978      23093      +2115
- Partials       3297       3325        +28


Offset differences in Chrome and Firefox.

So i'm using a fix navbar, so i had to put an offset so that when the user clicks on one of the nav's buttons the header of that section doesn't get covered by the navbar.
It works perfectly on chrome, but on firefox it's as if it isn't recognising the offset.
You can see for yourself on my WiP:
http://www.opinatus-solutions.com/
All i did was add an offset of 64px by editing line 205 of the Js file:
$('html, body').animate({
scrollTop: offset - 64
}, this.config.scrollSpeed, this.config.easing, callback);
},
Is there a way i can make this work on firefox as well?

+1 for an option to adjust the offset, heaving the same issue with fixed navbar


python3Packages.aiowatttime: init at 0.1.1

Motivation for this change
Python library for interacting with WattTime
https://github.com/bachya/aiowatttime
This is a Home Assistant dependency.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 139360 run on x86_64-linux 1

2 packages built:

python38Packages.aiowatttime
python39Packages.aiowatttime

Result of nixpkgs-review pr 139360 at c3875017 run on aarch64-linux 1

2 packages built successfully:

python38Packages.aiowatttime
python39Packages.aiowatttime


Using DateFilter with pattern yyy-MM-dd

When I try to use the DateFilter with the pattern yyy-MM-dd and the value 2001-01-01, I got the following error :
Caused by: java.time.DateTimeException: Unable to obtain Instant from TemporalAccessor: {},ISO,Z resolved to 2001-01-01 of type java.time.format.Parsed 	at java.base/java.time.Instant.from(Instant.java:380) 	at io.streamthoughts.kafka.connect.filepulse.filter.DateFilter.apply(DateFilter.java:115) 	... 29 more Caused by: java.time.temporal.UnsupportedTemporalTypeException: Unsupported field: InstantSeconds 	at java.base/java.time.format.Parsed.getLong(Parsed.java:209) 	at java.base/java.time.Instant.from(Instant.java:375) 	... 30 more
Is there a solution to parse only a date (day, month, year) with this filter or is it only for a full timestamp ?
Thanks

Hi @bertrandcedric, this is an issue of the DateFilter.  You should be able to use the AppendFilter with the to_timestamp expression function. e.g. {{ to_timestamp($value.YOUR_DATE_FIELD, 'yyy-MM-dd') }}


Functions free trial signup loop

When I try to use the service to test run a function for 1 hour I end up in a loop.
Here's what I'm doing:

Visit https://tryfunctions.com/ng-min/try?trial=true
Select "Webhook + API" & "Javascript"
Click "Create this function", pick GitHub as authentication provider
Authorize app
I'm redirected to https://tryappservice.azure.com where if I select "Function App" from the list, I start again from step 1

Please see the video recording for more info:

This would happen if you already had a trial app from try app service and then tried to get a free function app in the same experience/browser session.  We have revamped the experience and plan to make more changes soon for tryfunctions.  Sorry about the delay in addressing this, and thanks for reporting the issue.


test-branch/execute-job/quoted-authorization/509eb2e6-7a50-4dbe-837a-c1cfbbf46282

PR for testing b415ad41744ac8affb9148f75e5c55c84a6fc88c

/canonical/self-hosted-runners/run-workflows b415ad41744ac8affb9148f75e5c55c84a6fc88c


@craigspaeth => get rid of the "notify me of an upcoming auction" option on mobile web

This PR removes the "Notify me when an auction is upcoming" feature from mobile web. It was removed from desktop with the big auction page overhaul earlier this year. Just an oversight that it's stayed in mobile web for so long!
For reference, here is what is being removed:

and replaced with (we'll now just prompt uses and non-users to register to bid):

Thanks! Easy peasy. Feel free to merge when 💚


Temporarily exclude cent7 machines for sanity.external

Sanity.external test will run on Rhel and Ubuntu machines
Cent machines have different docker versions and caused failure
Related Issue: runtimes/backlog/1383

Simulated Test Scenario with if (JOB_NAME.contains ("sanity.external") || JOB_NAME.contains ("Grinder")),
The in Grinder, the machine label is 16:19:54  LABEL: ci.role.test&&hw.arch.x86&&sw.os.linux&&!sw.os.cent.7 (hyc_grinder 39202)

Do we have a separate issue to track reversing this?

@LongyuZhang could you back port the change in https://github.com/adoptium/aqa-tests/tree/v1.0.1-release? Thanks


PHP Agent test app not working

I’ve installed latest PINPOINT PHP agent on CentOS 7 and activated pinpoint-php-module and collector agent successfully.
But I’m not able to bind given test PHP application and return "pre_init_shared_object: open address with:Permission denied" error.
Operating System:CentOS 7
PHP Version:7.3
php-fpm or apache: apache
php.ini:
_extension=pinpoint_php.so
pinpoint_php.CollectorHost=unix:/tmp/collector-agent.sock
pinpoint_php.SendSpanTimeOutMs=0
pinpoint_php.TraceLimit=-1
pinpoint_php.DebugReport=true
error_reporting = E_ALL
log_errors = On
error_log = /opt/pinpoint-c-agent/logs/http_error.log
pinpoint_agent.conf:
collector.grpc.agent.ip=<IP_ADDRESS>
collector.grpc.agent.port=9991
collector.grpc.stat.ip=<IP_ADDRESS>
collector.grpc.stat.port=9992
collector.grpc.span.ip=<IP_ADDRESS>
collector.grpc.span.port=9993
[Common]
Web_Port=80
Log_Level=DEBUG
LOG_DIR=/opt/pinpoint-c-agent/logs/
Isdocker = false
[Agent]
Address=/tmp/collector-agent.sock
/opt/pinpoint-c-agent/logs/http_error.log
[15-Mar-2021 02:40:18 Asia/Colombo] [pinpoint] [3038] [3038]#0 pinpoint_start start
[15-Mar-2021 02:40:18 Asia/Colombo] [pinpoint] [3038] [3038]#128 add clue key:uri value:/app/index.php?type=get_date
[15-Mar-2021 02:40:18 Asia/Colombo] [pinpoint] [3038] [3038]#128 add clue key:client value:<IP_ADDRESS>
[15-Mar-2021 02:40:18 Asia/Colombo] [pinpoint] [3038] [3038]#128 add clue key:server value:<IP_ADDRESS>
[15-Mar-2021 02:40:18 Asia/Colombo] [pinpoint] [3038] [3038]#128 add clue key:stp value:1500
[15-Mar-2021 02:40:18 Asia/Colombo] [pinpoint] [3038] [3038]#128 add clue key:name value:PHP Request
[15-Mar-2021 02:40:18 Asia/Colombo] [pinpoint] [3038] [3038]#128 add clue key:appname value:APP-2
[15-Mar-2021 02:40:18 Asia/Colombo] [pinpoint] [3038] [3038]#128 add clue key:appid value:app-2
[15-Mar-2021 02:40:18 Asia/Colombo] [pinpoint] [3038] [3038]pre_init_shared_object: open address with:Permission denied
collector.agent.log
[2021-03-15 02:39:07,204] [3033] [INFO] [CollectorAgentConf.py:136] CollectorSpanIp:<IP_ADDRESS>
[2021-03-15 02:39:07,205] [3033] [INFO] [CollectorAgentConf.py:137] CollectorStatIp:<IP_ADDRESS>
[2021-03-15 02:39:07,205] [3033] [INFO] [CollectorAgentConf.py:138] CollectorAgentIp:<IP_ADDRESS>
[2021-03-15 02:39:07,205] [3033] [INFO] [CollectorAgentConf.py:139] CollectorSpanPort:9993
[2021-03-15 02:39:07,205] [3033] [INFO] [CollectorAgentConf.py:140] CollectorStatPort:9992
[2021-03-15 02:39:07,205] [3033] [INFO] [CollectorAgentConf.py:141] CollectorAgentPort:9991
[2021-03-15 02:39:07,205] [3033] [INFO] [CollectorAgentConf.py:142] collector_type:gRpc
[2021-03-15 02:39:07,205] [3033] [INFO] [CollectorAgentConf.py:143] log_dir:/opt/pinpoint-c-agent/logs/
[2021-03-15 02:39:07,205] [3033] [INFO] [CollectorAgentConf.py:144] log_level:DEBUG
[2021-03-15 02:39:07,205] [3033] [INFO] [CollectorAgentConf.py:145] webPort:80
[2021-03-15 02:39:07,205] [3033] [INFO] [CollectorAgentConf.py:146] agentIsDocker:False
Regards,
Sam

@snmsmanager
Check the  ownership of "/dev/shm/pinpoint.shm"

Hi eelu,
It dosen't has pinpoint.shm but pinpoint-php.shm is there.
-rw------- 1 root root 4096 Mar 15 12:49 /dev/shm/pinpoint-php.shm
Does this file need ownership  as apache user ?

Hi eelu,
It dosen't has pinpoint.shm but pinpoint-php.shm is there.
-rw------- 1 root root 4096 Mar 15 12:49 /dev/shm/pinpoint-php.shm
Does this file need ownership as apache user ?

Yes

hi eelu,
Thanks a lot for pointing this and now test application is working fine after changed the permission.
Now I have pointed to the YII dev app and able to see initial transaction properly. But not able to see any internal transactions like MySQL PDO, curl requests. Also bellow error line in http error log
{"success":false,"error":"Something went wrong, please try again later","exception":"Class 'Plugins\CommonPlugin' not found","url":"","request":null}
http error log
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#0 pinpoint_start start
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#128 add clue key:uri value:/O2A-Retailer-STG/
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#128 add clue key:client value:<IP_ADDRESS>
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#128 add clue key:server value:<IP_ADDRESS>
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#128 add clue key:stp value:1500
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#128 add clue key:name value:PP_PHP Request
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#128 add clue key:appname value:APP-O2A
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#128 add clue key:appid value:APP-O2A
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#128 add clue key:tid value:APP-O2A^1615965553193^53
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#128 add clue key:sid value:1450149405
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]#128 add clues:46:200
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]this span:({"E":109,"FT":1500,"S":1615966078535,"appid":"APP-O2A","appname":"APP-O2A","client":"<IP_ADDRESS>","clues":["46:200"],"name":"PP_PHP Request","server":"<IP_ADDRESS>","sid":"1450149405","stp":"1500","tid":"APP-O2A^1615965553193^53","uri":"/O2A-Retailer-STG/"})
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]agent try to connect:(unix:/opt/pinpoint-agent/logs/collector-agent.sock)
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]connected to /opt/pinpoint-agent/logs/collector-agent.sock
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]15 send size 268
[17-Mar-2021 12:57:58 Asia/Colombo] [pinpoint] [12696] [12696]collector-agent starttime:1615965553193
index.php
require_once DIR."/vendor/autoload.php";
define('APPLICATION_NAME','APP-O2A');
define('APPLICATION_ID','APP-O2A');
define('AOP_CACHE_DIR',DIR.'/Cache/');
define('PLUGINS_DIR',DIR.'/Plugins/');
define('PINPOINT_USE_CACHE','YES');
//define('PP_REQ_PLUGINS', '\Plugins\PerRequestPlugins');
define('PP_REQ_PLUGINS', '\Plugins\Framework\yii2\Yii2ReqPlugins');
//define('USER_DEFINED_CLASS_MAP_IMPLEMENT',"\Plugins\Framework\app\ClassMapInFile");
require_once DIR. '/vendor/pinpoint-apm/pinpoint-php-aop/auto_pinpointed.php';


Fatal error in Artax socket pool

PHP Fatal error:  Uncaught Error: Unknown socket: 0 in /www/jaumo/vendor/amphp/socket/lib/BasicSocketPool.php:116
Stack trace:
#0 /www/jaumo/vendor/amphp/artax/lib/HttpSocketPool.php(104): Amp\Socket\BasicSocketPool->clear(Object(Amp\Socket\ClientSocket))
#1 /www/jaumo/vendor/amphp/artax/lib/DefaultClient.php(706): Amp\Artax\HttpSocketPool->clear(Object(Amp\Socket\ClientSocket))
#2 [internal function]: class@anonymous->__destruct()
#3 {main}  thrown in /www/jaumo/vendor/amphp/socket/lib/BasicSocketPool.php on line 116

Do you use the latest version of Artax?

I updated from 3.0.8 => 3.0.10 right now. Let's see if it's still there
2017-11-09 14:33 GMT+01:00 Niklas Keller<EMAIL_ADDRESS>
Do you use the latest version of Artax?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/amphp/artax/issues/147#issuecomment-343155361, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAUQZ-zvWKgVZHyCG2IspKVJ95rX02YJks5s0v8XgaJpZM4QX9Zh
.

v3.0.10 explicitly mentions it fixed it, so closing for now. Please upgrade directly to v3.0.12, which is the latest version.

Saw this issue in my email ... nice to see folks using amp for real world projects. Wish I had time to contribute these days 😕


feat: build Information dialog component to show confirmation or alert

Jira: https://issues.redhat.com/browse/FLPATH-853
Build a information dialog component to ask user to confirm or show alert to user.

@jkilzi Thanks for the review! Just modified the PR based on feedbacks, please review again, thanks!

@yzhao583 PTAL at this.


url lib support no auth for https

access twitter api, the error will occur: urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:852)>
so. the patch will support the parameter whether to enable verify context.

Coverage increased (+0.2%) to 30.343% when pulling 7057f0e819ec96b681e81d57a58e5db4662af521 on guangtaopi:master into dc27f09749744ccef81c90a8a893842a61ed133e on sixohsix:master.

Coverage increased (+0.2%) to 30.343% when pulling 7057f0e819ec96b681e81d57a58e5db4662af521 on guangtaopi:master into dc27f09749744ccef81c90a8a893842a61ed133e on sixohsix:master.

Hi again,
As travis reports, there are still issues with this : the context argument does not exist in some Python versions (2.6, 3.2 and 3.3). It's true these are deprecated, although the code was working with them anyways and I'd like to keep this as such. Could you condition the use of context?

good news, since we dropped these versions for good now, it can now finally be merged seemlessly :)
I just rebased and pushed your commits with a minor change to master https://github.com/python-twitter-tools/twitter/commits/master

good news, since we dropped these versions for good now, it can now finally be merged seemlessly :)
I just rebased and pushed your commits with a minor change to master https://github.com/python-twitter-tools/twitter/commits/master


Add contributors to current nwo

/cc #26
/cc @benbalter

I am silly. This seems to be done! https://github.com/jekyll/github-metadata/blob/4eca1c92e0c52968fa882d3b8ff50fedd35f988b/lib/jekyll-github-metadata.rb#L84


Main dev

fix tracer report:

when es merge job stagein premerge files, the filesize is not filled.
when es merge job stagein premerge files, the eventtype is 'get_sm', it should be 'get_es'

Thanks Wen


Wrong password on Keychain Access

I successfully inserted the password and completed the remaining steps of the installation process. However, upon reaching the final stage, I realized that I had mistakenly entered the wrong password at this point:
  security add-generic-password -s 'PlugNPlayMac'  -a 'MY USERNAME' -w 'MY MACBOOK PASSWORD'

To rectify this error, I attempted to remove the incorrect password from the Keychain app. I tried two different methods: pressing the delete key and navigating to Edit > Delete. Unfortunately, in both cases, my efforts were in vain, as no changes occurred, and no error messages were generated. This left me perplexed and in need of a solution to correct this issue.

Find it in the list without searching and then delete.
U can find the solution here


Transition Delay which shows blank screen from stacknavigator to fluidnavigator

Hi @chrfalch I am experiencing a delay which shows a blank transition screen when moving from StackNavigators to FluidNavigator. What could be the problem. Should I write a custom transition?
Please find my example code below
> Dashboard.js
--------------------------

const Navigator = FluidNavigator({
    AdminEventScreen: { screen: AdminEventScreen, navigationOptions: { gesturesEnabled: false } },
    ImagePreview: { screen: ImagePreview },
    VideoPlayer: { screen: VideoPlayer },
  }, {
    navigationOptions: {
      gesturesEnabled: true,
    },
  }
);

> StackNavigator
-------------------
createStackNavigator(
  {
    Home: {
      screen: HomeScreen,
      header: null
    },
    Profile: Profile,
    Dashboard: Dashboard,
    ScreenX: ScreenX
}, {
  // navigationOptions here
});

> From ScreenX in Stack navigator
this.props.navigation.navigate('Dashboard');

This is very similar to #80 Is there a fix now?


Angular 8+ support

Any plans to support Angular 8+? :)

It seems like Angular 8 is now supported https://github.com/atularen/ngx-monaco-editor/commit/069f4c8299c6961e3b20fa3c89b537513d5df92b


writeStatus uprobe gets context from argument not struct

https://github.com/open-telemetry/opentelemetry-go-instrumentation/blob/9fe05d9b79965cd1c42c12c13d27d2607825621c/internal/pkg/instrumentation/bpf/google.golang.org/grpc/server/bpf/probe.bpf.c#L199
This passes true to get_Go_context as the 4th arg. However, the context is passed as a struct field, not an argument. Meaning this should be false.
I'm not sure how this is currently working. An investigation is needed.

I can take this if you haven't already committed to it @MrAlias

FWIW, in my work on https://github.com/open-telemetry/opentelemetry-go-instrumentation/issues/1421 I have changed the value to false and things pass the e2e tests. But I haven't dug into why this is working in the first place and if the test are just false-nagatives.


wifi_status() method throws exception

It looks like they have added some new attributes in the latest software version.  I was able to reproduce this error on version <IP_ADDRESS>2.

#2 Accepted PR to fix this issue.


Not working on real Android device

Hi!
There is a some kind of bug, that is relevant for me only on real device.
What I have:

Real device with stock Android 10.
Application using simple function FilePickerWritable().openFile():

final fileInfo = await FilePickerWritable().openFile((fileInfo, file) async {
      return fileInfo;
});

What happens further:

The file open dialog opens normally
I find my file
I click on it
The dialog freezes for a while, and then simply disappears / closes. Returning nothing! My debugger cannot catch the moment when the value is returned, it seems to be detached from the process and no longer stops at a breakpoint.

There are no errors in the log, but there are some messages:
D/FilePickerWritable(30527): Got method call: openFilePicker
I/Choreographer(30527): Skipped 76 frames!  The application may be doing too much work on its main thread.
W/ActivityThread(30527): handleWindowVisibility: no activity for token android.os.BinderProxy@b858bba
D/FilePickerWritable(30527): onNewIntent(null)
D/PathProviderPlugin(30527): Use TaskQueues.
D/FilePickerWritable(30527): We have no active result, so activity result was not for us.

The last one is most interesting.
It is hardcoded in your FilePickerWritableImpl.kt:
val result = filePickerResult ?: return false.also {
  plugin.logDebug("We have no active result, so activity result was not for us.")
}

We come here because we really have filePickerResult = null.
But in openFilePicker() method it is aclually set to not null result, I checked this:
fun openFilePicker(result: MethodChannel.Result) {
  ...
  this.filePickerResult = result
  ...
}

It is strange... It looks like setting this value and then checking this value happen on different threads... Or some other reason, I don't know.
Another strange thing is that on emulator it is always working correctly!
I thought there might be some problem in my application.
But I tried a simple application that just opens a file open dialog and then shows the returned file identifier in the dialog.
It is relevant also for this simplest app.
To recreate the simplest application, just place the main.dart file from the archive into the lib folder of the created template application (and add a dependency on file_picker_writable).
Please take a look at this issue!
Try to reproduce this. Perhaps this is not reproduced on every device, but I have a stock Android on my phone, without third-party launchers, etc. That is, the problem may not be that rare.
As a last resort, please try to think theoretically what could be the problem and try to fix it.
Thanks in advance!

I am curious if your issue still arises with the the example app.
Can you clarify which Document Provider you are selecting from in the System UI file picker? I expect Downloads or Google Drive to work, but I've had less success with Dropbox, etc.

Hi @bradyt

I am curious if your issue still arises with the the example app.
I had a hard time getting your example running because it is outdated. But anyway this example works with the same error mentioned above.

First time when I ran into this error was the case of opening files from Google Drive.
But then I tried the simplest case, trying to open a file from the "downloads" folder.
The same result. So the reason is not the Document Provider, but the file picker itself.

I don't have a physical Android. So I would find it difficult to help here. But for what it's worth, I installed the example app, tried Create New File, selected the Downloads location in System UI picker, and pressed SAVE, which created a file like newfile.<some integer>.codeux, removed the file in app UI, pressed Open File Picker, and was able to select the recently created file successfully. If I understand correctly, you are saying that doesn't work on your physical Android device.
This was with flutter channel stable, 2.8.1, by the way. I didn't notice any issues with the app being outdated, but I was only able to test on a physical iPhone, an iPhone simulator, and an Android emulator.

I found an Android device, the example app worked fine here. But it's Android 8.1.

Did you already try the provided example?
I'm using this plugin in AuthPass and haven't heard of any problems...

@bradyt @hpoul
Now this is starting to clear up.
The thing is, some time ago I was playing with the Android settings in the "Developer options" section on my device.
There I changed the setting "Don't keep activities" ("Destroy every activity as soon as the user leaves it"), setting it to On.
After that, this behavior began to reproduce.
This can be reproduced on any device now, even on an emulator, by setting this option.
That is, during normal use of the device, this behavior, it seems, should not be relevant.
So maybe it is not the bug.
On the other hand, if you want, you could improve it. Up to you.
The reason, as I understand it now, is that when this option is turned On, activities can be unloaded by Android itself unexpectedly for the application. And then, can be restarted.
Which is what happens in this case...
Method openFilePicker() is called from existing instance.
But when we get the result in onActivityResult() method, it checks filePickerResult field in another instance.
So it is uninitialized and equals to null, so we have an error.
As far as I understand, applications can be prepared to save and load their state when forced to be unloaded by Android.
I haven't read much about this, but it seems to be done using methods onSaveInstanceState() / onRestoreInstanceState() that allow an application to save the data it needs and restore it to a new instance.
But again, since this can hardly be called very critical, it is up to you.

Thanks for the update. Yes, that's a problem especially on memory constraint devices, but flutter support for state restoration is still very limited: https://github.com/flutter/flutter/pull/60375
I honestly didn't look too much into it. I see this as a minor problem, I'll leave the issue open.. but i don't plan to work on it any time soon.. but if anyone would be interested in working on it, I'd be happy to review and merge PRs


Custom Layer API is not working like functional API

Please make sure that the boxes below are checked before you submit your issue.
If your issue is an implementation question, please ask your question on StackOverflow or on the Keras Slack channel instead of opening a GitHub issue.
Thank you!

[x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/keras-team/keras.git --upgrade --no-deps

[x] Check that your version of TensorFlow is up-to-date. The installation instructions can be found here.

[x] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

I have implemented a custom Layer for a residual network but it failed to generalize, when I tested with simple MNIST.
I thought the model was too simple to behave like this, so I additionally implemented the code again, using the functional API. This gives an improve from ~20% to 90% test accuracy.
Code:
class ResidualLayer(Layer):  # This does not generalize!

def __init__(self, conv_layer1, conv_layer2, **kwargs):
    self.__conv_layer1 = conv_layer1
    self.__conv_layer2 = conv_layer2
    super(ResidualLayer, self).__init__(**kwargs)

def build(self, input_shape):
    self.__in_shape = input_shape
    self.bn1 = BatchNormalization()
    self.bn2 = BatchNormalization()
    self.rel1 = Activation(activation='relu')
    self.rel2 = Activation(activation='relu')
    self.add = Add()
    self.scale_conv = Conv2D(filters=self.__conv_layer1.filters,
                             strides=self.__conv_layer1.strides,
                             kernel_size=(1, 1),
                             padding=self.__conv_layer1.padding)
    super(ResidualLayer, self).build(input_shape)

def call(self, x):
    input_layer = x
    tmp_layer = self.__conv_layer1(input_layer)
    tmp_layer = self.bn1(tmp_layer)
    tmp_layer = self.rel1(tmp_layer)
    tmp_layer = self.__conv_layer2(tmp_layer)
    tmp_layer = self.bn2(tmp_layer)
    if self.__conv_layer1.output_shape == self.__in_shape:
        tmp_layer = self.add([tmp_layer, input_layer])
    else:
        scaled_layer = self.scale_conv(input_layer)
        tmp_layer = self.add([tmp_layer, scaled_layer])
    tmp_layer = self.rel2(tmp_layer)
    return tmp_layer

def compute_output_shape(self, input_shape):
    return self.__conv_layer2.output_shape

def reslayer(x, conv_layer1, conv_layer2): # This works!
    input_layer = x
    tmp_layer = conv_layer1(input_layer)
    tmp_layer = BatchNormalization()(tmp_layer)
    tmp_layer = Activation(activation='relu')(tmp_layer)
    tmp_layer = conv_layer2(tmp_layer)
    tmp_layer = BatchNormalization()(tmp_layer)
    if conv_layer1.output_shape == keras.backend.shape(x):
        tmp_layer = Add()([tmp_layer, input_layer])
    else:
        scale_conv = Conv2D(filters=conv_layer1.filters, strides=conv_layer1.strides, kernel_size=(1, 1), padding=conv_layer1.padding)
        scaled_layer = scale_conv(input_layer)
        tmp_layer = Add()([tmp_layer, scaled_layer])
        tmp_layer = Activation(activation='relu')(tmp_layer)
    return tmp_layer

I would like to understand where the mistake with using the Custom Layer API happened.

Keras Layers currently don't support having sublayers inside of them. You can subclass the Model class and use ResidualLayer as a nested submodel

I think this is dangerous for the user, because it is an easy way to use the Sequential API, is there a way to give a warning? Mind that this code was executing, but not running properly for the validation set.

Agreed. We're working on a new approach for this, to either allow layers to have sublayers, or to throw a warning when this happens. I'll update this thread when the solution's in, please feel free to comment ideas

I'm have also run into this problem. I'm working on a custom layer, which uses 3 Conv2D models and transforms them using keras.backend and keras.tf functions combined with some trained weights.
At first I thought I could maybe include the weights manually using self.add_weight, but that also doesn't seem to be possible. It appears to remove them from the graph completely. I'm looking forward to the solution (or alternatively an explicit "unsupported" statement)


Bump to xDSL supporting inplace bufferization

Just bump to xDSL supporting inplace bufferization and support inplace
Stacked on:

#118

Depends on upstream:

xdslproject/xdsl#3077

Self-note: There's an issue with an unlowered memef.alloc
Which might mean the bufferization is not acting as expected, as I wouldn't expect an allocation in the in place case

Okay so, Devito here is doing that (turning on OpenMP for clarity):
for (int x = x_M; x >= x_m; x -= 1)
    {
      #pragma omp parallel num_threads(nthreads)
      {
        #pragma omp for schedule(static,1)
        for (int y = y_m; y <= y_M; y += 1)
        {
          u[t0][x + 1][y + 1] = r0*(-u[t0][x + 1][y + 1]) + r0*u[t0][x + 2][y + 1];
        }
      }
    }

So it sees there's a dependency only on y and expresses the computation to be sequential over x so that it can indeed do this one in place.
This is just not something the stencil dialect can express at this point :smiling_face_with_tear:
@georgebisbas There are multiple ways from here onwards, let's discuss it when you have time. But indeed I don't see how to manage this without an extra allocation in xDSL in the time I have on my side

Okay so, Devito here is doing that (turning on OpenMP for clarity):
for (int x = x_M; x >= x_m; x -= 1)
    {
      #pragma omp parallel num_threads(nthreads)
      {
        #pragma omp for schedule(static,1)
        for (int y = y_m; y <= y_M; y += 1)
        {
          u[t0][x + 1][y + 1] = r0*(-u[t0][x + 1][y + 1]) + r0*u[t0][x + 2][y + 1];
        }
      }
    }

So it sees there's a dependency only on y and expresses the computation to be sequential over x so that it can indeed do this one in place. This is just not something the stencil dialect can express at this point 🥲 @georgebisbas There are multiple ways from here onwards, let's discuss it when you have time. But indeed I don't see how to manage this without an extra allocation in xDSL in the time I have on my side

Thanks for that @PapyChacal , does xdsl produce one level of parallelism + correct results?
Let's discuss this yes.

Okay so, Devito here is doing that (turning on OpenMP for clarity):
for (int x = x_M; x >= x_m; x -= 1)
    {
      #pragma omp parallel num_threads(nthreads)
      {
        #pragma omp for schedule(static,1)
        for (int y = y_m; y <= y_M; y += 1)
        {
          u[t0][x + 1][y + 1] = r0*(-u[t0][x + 1][y + 1]) + r0*u[t0][x + 2][y + 1];
        }
      }
    }

So it sees there's a dependency only on y and expresses the computation to be sequential over x so that it can indeed do this one in place. This is just not something the stencil dialect can express at this point 🥲 @georgebisbas There are multiple ways from here onwards, let's discuss it when you have time. But indeed I don't see how to manage this without an extra allocation in xDSL in the time I have on my side

Thanks for that @PapyChacal , does xdsl produce one level of parallelism + correct results? Let's discuss this yes.

For the record, this does not seem to happen in TTI


Latest release for Linux is not supported in recent Ubuntu / Pop Revisions

The latest linux release (2020.3618, September 21, 2020) requires libwebkitgtk-3.0.so.0:
/home/brian/CoronaSimulator/CoronaSimulator: error while loading shared libraries: libwebkitgtk-3.0.so.0: cannot open shared object file: No such file or directory
This version of libwebkit has been removed from newer distributions and it is not practical to install. There are dependencies to build this library which are also deprecated, such as "icu-config". The version presently shipping is libwebkit2gtk-4.0-37.
(I tried just creating a link to trick the tool into thinking one version was another, and it seems apparent that they are not API or ABI compatible).
Additional non-detail:
sudo apt install "libwebkitgtk-3.0-0"
Reading package lists... Done
Building dependency tree
Reading state information... Done
Package libwebkitgtk-3.0-0 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
E: Package 'libwebkitgtk-3.0-0' has no installation candidate

I'd suggest using and supporting the actively developed Linux fork, Solar2DTux.


Prometheus service account namespace fix

Hi @Nopik. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nopik: please update with master. That should fix your ci/circlecli: e2e-pilot failure.

Nopik
Thanks for the contribution - although someone else has fixed this issue and it has merged.
Cheers
-steve

Nopik, thanks for the contribution!  Someone else has just fixed this with the correct namespace and passed all tests.  Look forward to your future contribution!


feat: initial text and todos

Issue: https://github.com/NebraLtd/maker-starter-app/issues/11
Summary: Need to update assets so that app will have our branding and sensible text.

@posterzh is this the only change I need to revert to fix the name change? https://github.com/NebraLtd/maker-starter-app/pull/21/commits/0d2aba3f08e9c7ec0d8d57f4f0667e626f38b1ad

@posterzh is this the only change I need to revert to fix the name change? 0d2aba3

Correct.

@posterzh @Andrewsopoku just converted this to a real PR. We can still use the convo as a list of todo items, but I want to start getting things merged.

@posterzh @Andrewsopoku can you please review?

Thanks @Andrewsopoku I hadn't seen that README. I'll create some tickets accordingly.

@Andrewsopoku @posterzh  I've updated the PR so it only touches the text. I've updated the original ticket with all the specific UI details: https://github.com/NebraLtd/maker-starter-app/issues/11. Created additional tickets that you can both help with:

https://github.com/nebraltd/maker-starter-app/issues/25
https://github.com/nebraltd/maker-starter-app/issues/26


Release v3.1.1 @W-13960441@

Description

Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

(change1)

How to Test-Drive This PR

(step1)

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

Marking in draft as we're waiting on other changes to be included in this release

Moved to #1436


why cannot turn off  sonoff from automation?

why cannot turn off  sonoff from automation?
I cant in the last update,
I use
switch.turn_off   , I try homeassistant.turn_off
but nothing
Thanks

such a problem, what can help?

'1558179512434':
alias: PORTERILLO
sequence:

data:
entity_id: switch.sonoff_1000646fec
service: switch.turn_on
delay: 00:00:01
data:
entity_id: switch.sonoff_1000646fec
service: switch.turn_off

This is a script, I calle from automation

id: '1557254386808'
alias: PORTERILLO ON
trigger:

entity_id: switch.sonoff_1000646fec
platform: state
to: 'on'
condition: []
action:
data: {}
service: script.1558179512434

When I switch on sonoff , not go to OFF
sorry for my english
Thanks in advanced

I have the same problem with outgoing home automation to turn off all lights

pretty much duplicate of https://github.com/peterbuga/HASS-sonoff-ewelink/issues/92
TLDR; ewelink doesn't support toggle of multiple devices in the same time (or very fast), add a 1-2sec (or increase the value) delay between different switches
@violgore in your case you could use the inching option available in the latest firmwares


"BULK" is being flagged on emails sent to a single recipient

Similar to issue: https://github.com/MicrosoftDocs/microsoft-365-docs/issues/7546
I can understand actual bulk email "email with more than x recipients" being flagged as bulk. However, this new algorithm now defaults "bulk" when a user sends a single email to another email. a single email should never be flagged as "bulk". Bulk should never be applied below 15 recipients.
This is impacting me as well as my clients ability to communicate with clients on legitimate business transactions.

I just got off the phone with support who has stated this is a "known issue" and affecting thousands of users.  I was told they have reported this to product development but have not heard back yet.  This is a legal issue as Microsoft is preventing paying customers from doing business due to a glitch and there seems know way to get anyone from Microsoft to actually respond.  I am advising all of my clients to contact legal counsel since there appears to be no other way to resolve.

@FluidNets-DamianS Thank you for your feedback. You have done the right thing by contacting support. That is the only way to be able to report a product bug. We at the documentation team do not have access to report bugs.
Hope this helps!
Thanks
Sri

@yogkumgit This can be closed.


Question: How to put action if fetching took too much time

Hello! I'm trying to put loading action only if fetching data request took more than 500ms. If it is less than 500ms I should show response data. If more, I should put loading for 1s and then show data.
I tried to use race:
const { timeout, response } = yield race({
  timeout: delay(500),
  response: call(fetchingData),
});
if (timeout) {
  yield put({ FETCHING_DATA });
  yield delay(1000);
} else {
  yield put({
    type: FETCHED_DATA,
    data: response.data,
    searchResultCount: response.data.length,
  });
}

But this didnt work for me because in case of 500ms delay my FETCHED_DATA cancelled and I couldnt show it later.
So I tried use setTimeout and clearTimeout:
export function* showLoading() {
  yield put({
    type: FETCHING_DATA,
  });
  yield delay(1000);
}

export async function* fetchValue(action) {
  const timeout = setTimeout(showLoading, 500);
  const response = await axios.get('myUrl');
  clearTimeout(timeout);
  try {
    yield put({
      type: FETCHED_DATA,
      data: response.data,
      searchResultCount: response.data.length,
    });
  } catch (err) {
    yield put({ type: FETCHED_WITH_ERR });
  }
}

After 500 ms if timeout is not cleared by getting data I try to call showLoading(). But this solution didnt work.
Can you help me please? What is better way to resolve this problem?

Finally could solve it by using delay in showLoading function and comparing state.data


Benchmark parameters matching those in #174 for baseline data

I had to change the benchmark parameters (specifically the number of columns in the BlockLayout) for #174. I want to run a PR through the benchmark suite on Jenkins to verify what I'm seeing locally: that #174's changes don't dramatically alter performance aside from the changes in benchmark parameters.

Got the benchmark numbers I needed. We're done here. For posterity:
RES. value     reference % tol. p_diff ref type nres suite                        test
----|---------|---------|------|------|--------|----|----------------------------|--------------------|
pass 1.787e+07 0         0       +0    config   0    DataTableBenchmark           ConcurrentRandomRead
pass 5.51e+06  5.296e+06 10      +4    history  10   DataTableBenchmark           ConcurrentInsert
pass 1.228e+07 0         0       +0    config   0    DataTableBenchmark           SequentialRead
pass 3.332e+06 0         0       +0    config   0    DataTableBenchmark           RandomRead
FAIL 6.144e+06 8.177e+06 10     -24    history  10   DataTableBenchmark           SimpleInsert
FAIL 1.221e+07 2.452e+07 10     -50    history  10   TupleAccessStrategyBenchmark SimpleInsert
pass 5.441e+06 5.158e+06 10      +5    history  10   TupleAccessStrategyBenchmark ConcurrentInsert

Coverage decreased (-0.1%) to 96.676% when pulling fc3c6c44bf8505640e00efa84fc73bb8bac05ac6 on mbutrovich:benchmark_parameters_for_174 into 67c20d49851a754fcd102f0fddc771cb5089cd2a on cmu-db:master.


Fix typos

Found via typos --hidden --format brief

Thanks for this! A couple of comments:

"Fulfilment" is standard spelling in British English.
"Reuse" is commonplace so I think we should leave this as is.
"Intensional" is correct in the contex of type theory.

Could you revert these back and make a new commit?

Fixes look good, could you remove the _typos.toml file?

Thanks for this!

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


In Location object, move "provider" one level up (make it a foreign member instead of a property)

In the Location object, of which the format is GeoJSON, the "provider" object is currently a member of the properties. However, it is not a property, but information about the system that generates the response. Hence it should be removed from the properties.
The GeoJson-standard supports members at a top level (so called foreign members), so we will move the "provider" object one level up.

Specs have been adjusted accordingly.


Configure ArgoCD to not prune signing-secrets secret

We use Vault to store signing-secrets as a way to backup this secret and get it recreated on the cluster it its get deleted. To get it back in the cluster, ExternalSecret is used as usual to extract value from Vault and put in in signing-secrets secret.
Since this secret is created by created/managed by TektonInstallerSets, the ExternalSecret is configured to create the secret as orphan if it does not exists, meaning that it creates it without setting the owner reference so ES and TIS do not fight over the ownership.
Because ES is not setting ownership, the secret created was getting pruned by ArgoCD as soon as ES was creating it.
Fix this issue by adding the annotation
argocd.argoproj.io/sync-options: Prune=false to the secret being created by ES.

I forgot to regenerate deployments...


Strange TX burst before intended transmission

More: https://discourse.myriadrf.org/t/strange-tx-burst-before-intended-transmission-limesdr-mini/3485

I believe this is for TX calibration.


:sparkles: Added tls configuration flags for CAPM3.

We found out that TLS 1.0 and TLS 1.1 are enabled despite being insecure. These changes are backported to release-1.3 branch, but without the configuration flags. Min version is set to TLS12 and Max version set to TLS13, with no config to change those.

/hold

@tuminoid do we allow setting cipher suites using the cipher suite flag for the hardcoded version release 1.3?

/test-ubuntu-integration-release-1-3

@tuminoid do we allow setting cipher suites using the cipher suite flag for the hardcoded version release 1.3?

No configuration flags are added here. Just apply the default TLS config.

/retitle :bug: Disable TLS 1.0 and TLS 1.1

/test all

/test-ubuntu-integration-release-1-3

/assign @mboukhalfa

/approve

/unhold


Autoload Import extensions

Right now you have to manually set importing type when you use import or apply except for pickle imports, because all other implementations (pandas) are a part of ext and are not loaded by default. But if you are importing csv file we should understand that we need to try to import pandas ext if it is available.
For this we should introduce multiple names for ABC implementation for entrypoints and register each extension as an entrypoint like import_type.csv = ....PandasHook, import_type.parquet = PandasHook etc

Related to this, maybe even part of the same problem:
>>> res = apply_remote("http", "data/Churn_Modelling_0.csv", method="predict")
mlem.core.errors.MlemObjectNotFound: MLEM object was not found at `data/Churn_Modelling_0.csv`

We should resolve this automatically.

From the API the intended usage is to call import_object explicitly


Error under Flutter 3.19

lib/src/tree_search.dart:82:17
╷
82 │                 primary: theme.colorScheme.onPrimary,
│                 ^^^^^^^
╵

Hi Christophe - thanks for catching that!  Should be all set now.

Hi John,
Thanks you. I will try later.
Best regards from France ;-)
Le mar. 12 mars 2024 à 21:09, John Rager @.***> a
écrit :

Hi Christophe - thanks for catching that! Should be all set now.
—
Reply to this email directly, view it on GitHub
https://github.com/john-rager/mika_treeview/issues/19#issuecomment-1992493246,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH55YBYJQGEMGNQ3CSCURX3YX5OGPAVCNFSM6AAAAABEQRH6OGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJSGQ4TGMRUGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


[Beta] - How to add custom instrumentation?

Nice with new versions, and that you are keeping up getting tracing into app services! However, I tried to go from 3.0.0-beta.6 to 3.0.0-beta.9. But I'm having a really hard time to converting my old config to your new format. As an example, how do I add a custom instrumentation? I.e what was described here in 3.0.0-beta.6

Telemetry can now be added through the Open Telemetry Instrumentation package. Here's an example:
import { AzureMonitorOpenTelemetryOptions, useAzureMonitor } from 'applicationinsights';
import { registerInstrumentations } from '@opentelemetry/instrumentation';

  const config: AzureMonitorOpenTelemetryOptions = {
    azureMonitorExporterOptions: {
      connectionString: process.env[process.env.APPLICATIONINSIGHTS_CONNECTION_STRING],
    }
  }

  useAzureMonitor(config); // Must be BEFORE instrumentation registration

registerInstrumentations({
    instrumentations: [
      new GraphQLInstrumentation({ allowValues: true, }),
      new DataloaderInstrumentation(),
    ],
  });

Closing as the question was answered in this thread.


Removing aggregation from modules

Removing the references to aggregation, as we're planning to have this handled by webpack.
Taking this as a step towards simplifying meanio for 0.9.0
This may make 0.9.0 unusable in the short term, because there's no testing we won't know.  But this is intended as a non-functional step towards cleaning the code.

Holding off on this until we have a solution to put in place.


Fix Prewarming

This is a 🐞 bug fix.

[x] I've added tests (if it's a bug, feature or enhancement)
[x] The test suite passes (run bundle exec rspec to verify this)

Summary
Fixes 2 issues with prewarming

The PreHeatJob is no longer included during stack build so prewarming never happens
At the end of deploy the call to prewarm! has a spelling error and enqueues a :warn event instead of :warm

Context
Prewarming was broken in Jets 5
How to Test
Create a new Jets project and deploy it. Notice there is no lambda function for prewarming. Also notice at the end of the deployment it says prewarming but it actually does not trigger a call to warm.
Version Changes
5.0.10

Converting to draft while I fix a 3rd issue. The preheat job is no longer scheduled using rate which would create an AWS::Events:Rule to invoke the preheat job on a schedule. I'm working on a fix for that to add to this.

Added the rate scheduling of the PreheatJob warm function and added specs to ensure that the prewarm enabled properly builds the correct Cloudformation template.

I have confirmed with one of my projects which uses prewarming that the PreheatJob is now created and invoked on a schedule (in my case 5 minutes).  See attached screenshot.