invite: Fix invite modal bug for users who can't subscribe others.

First commit fixes the bug of invite modal not opening for users who cannot subscribe others.
Second commit is to fix the UI.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

The second commit is to fix the UI to make the margins consistent with other banners.
Before -

After -

@timabbott this should be quick to review. The bug surfaced as there were some typescript related changes in the file and I missed testing the PR after those changes.
I think this commit has been deployed on CZO, but the bug would not be reproduced on CZO due to the permission configuration, so there is no necessity to deploy this urgently.

Could yo?u also include a screenshot with other onboarding banners present, to confirm the placement / how they look together?

Merged, thanks @sahil839!


Unable to access profile's details

Sometimes (~50%) clicking on the "Details" link does nothing.
No error messages in the dev console.

Is this on a dev build? Svelte has really weird bugs like this sometimes, try restarting the dev server and refreshing if so.

Sorry I forgot the env, I'm talking about the production: https://coracle.social
The problem persists even if I force a reload.

Got it, was able to reproduce, fixed on master.


Incorrect override functions with optional parameter

When using ADVANCED_OPTIMIZATIONS option, the compiler ignores overriden functions that just call base class method without passing optional arguments:
/**
 * @param {number=} width
 * @param {number=} height
 */
Foo.prototype.resize = function(width, height) {}

it is ok when undefined height is passed explicitly
/** @inheritDoc */
Bar.prototype.resize = function(width, height) {
    goog.base(this, "resize", width, undefined);
};

However, if height is not passed, the compiler throws away Bar.prototype.resize method completely
/** @inheritDoc */
Bar2.prototype.resize = function(width, height) {
    goog.base(this, "resize", width);
};

this bar will be removed from output code
    bar.resize(100, 200);
    console.log(bar.width(), bar.height()); // 100 undefined

    bar2.resize(100, 200);
    console.log(bar2.width(), bar2.height()); // 100 200

Minimal code to reproduce this issue: main.txt

Looks like a too aggressive optimization to me, but your code is actually confusing :)

I think there was an optimization added recently that removes overrides that do nothing but call the base method. Sometimes you need these so you can add more specific type annotations, but at runtime there's no value in keeping them. I'll see if I can find it.

https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/RemoveSuperMethodsPass.java


Replace the CircleCI build status badge with GHA badges

We no longer use CircleCI to test/build the keep-core code. We need to
replace the CircleCI build status badge in the projec'ts README with the
similiar badges for GitHub Actions builds.
Two badges have been introduced in place of the old one:

Contracts (showing status of the last Solidity workflow executed on
master branch and triggered by the push event),
Go client (showing status of the last Go workflow executed on
master branch and triggered by the push event).

The badges are displayed using shields.io tool, which was already used
for the Discord badge.
Also a badge was added in the README of the Token Dashboard:

Token Dashboard / Testnet (showing status of the last Token Dashboard / Testnet workflow on master branch and triggered by the push event).

This time standard GitHub badge was used, as shields.io tool currently
does not support workflows with slash character in their name (see
https://github.com/badges/shields/issues/4559).
Refs:
https://github.com/keep-network/keep-ecdsa/pull/835
https://github.com/keep-network/tbtc/pull/809

Once this PR gets merged, we will need to update the https://github.com/keep-network/keep-core/pull/2521 (changing branch used to display badges from master to main).
If the https://github.com/keep-network/keep-core/pull/2521 gets merged before the https://github.com/keep-network/keep-core/pull/2502, the aforementioned change would need to be done as part of https://github.com/keep-network/keep-core/pull/2502.

I'm merging this PR @michalinacienciala . Please remember to update https://github.com/keep-network/keep-core/pull/2521


launch password

can it open without password input when there is an application using root?
or just use touch id

No it cannot. It uses an insecure applescript hack to invoke scripts as root (read the readme). The alternative is significantly more complicated and requires full code signing. I'd love I if someone wanted to contribute that but I don't plan to.


add list structure for the To-do-list

-Setup Webpack for the project
-Add /dist and /src folders for proper documentation
-Add an array of objects in index.js  for description [string]. completed [bool]. index: [number].

Great review, thanks for the recognition and approval. 👍👍👍


[Draft] Add unbind callback

I'm removing this from the review queue since it is marked as a draft, please re-request (or mark as ready for review) if that's incorrect!

Removing the review request until https://github.com/matrix-org/synapse/pull/13227 is merged.

Superceded by #3.


Handling of next subscription type for trial periods

I accidentally forgot to merge this within 0.38. Do you need it as a hotfix, or will you be able to wait until 0.39?

Merged in internal master.

we are already using this branch, it can wait, thanks


Feature Request: Easier AMP installation using provisioning tools.

Feature Request
Feature Information:
Currently it is a pain to set up AMP using provisioning tools like Ansible. Executing ampinstmgr quickstart user password will cause AMP to start up the server and wait for the user to finish the process in the browser. It would be nice to be able to provide the required information via the command line arguments. The process should then do all the setup stuff automatically and exit when done.
I confirm:

[x] that I have searched for an existing feature request matching the description.

Is this what you are looking for?

Closed because this is already both implemented and documented.


Change metadata for plugin ref docs and deprecation doc

- What I did
Updated metadata of plugin docs and deprecation doc from TOML to YAML
Synced metadata title to H1 headers, removed H1 headers
Follow-up fro #28174
@thaJeztah @dnephin @johndmulhausen PTAL

Fixed. PTAL again.


[prim_fifo_async] Unifying prim_fifo_async and prim_fifo_async_sram_adapter

This issue is a follow-up of #7678 . The prim_fifo_async_sram_adapter module in the PR #7678 has a common logic (managing pointers) that is used in prim_fifo_async. This issue is to suggest changes:

[ ] Create a submodule to manage pointers and instantiate the module in both FIFO Async primitives.
[ ] Use prim_fifo_async_sram_adapter inside the prim_fifo_async for the DPSRAM FIFO implementation.

CC: @tjaychen @msfschaffner

This sounds like a good idea.
Another "common" thing we could add to our prims are ready / valid protocol checkers.


Draft type of post

People can still the post as it is in Draft - i do not see an issue with this as long as it clearly states DRAFT at the top.


Fixes issues about setting cookies in multi-language

Fixes issues about setting cookies in multi-language

Coverage increased (+0.06%) to 50.768% when pulling e6b5714f7d829d0a6b954ca10c3144bddce51eed on wknet123:dev-language-cookies into 35217b251c79cb70992d4480a24f285833305cb9 on vmware:dev.

Coverage increased (+0.06%) to 50.761% when pulling 0f553aa4e2bf1569cbeb3b72f32085d281f4cd3f on wknet123:dev-language-cookies into 35217b251c79cb70992d4480a24f285833305cb9 on vmware:dev.


works on ubuntu-12.04, fails on 14.04

running chef-12.06 on ubuntu-14.04. happens with and without event queue. besides, it works perfectly fine on 12.04. testing done using test-kitchen of both simultaenously.
           * monit_service[carbon-cache-d] action enable (up to date)
           * monit_service[carbon-cache-d] action start

       ================================================================================
             Error executing action `start` on resource 'monit_service[carbon-cache-d]'
             ================================================================================

             Mixlib::ShellOut::ShellCommandFailed
             ------------------------------------
             Expected process to exit with [0], but received '1'
             ---- Begin output of ["/usr/bin/monit", "-c", "/etc/monit/monitrc", "start", "carbon-cache-d"] ----

             STDERR: monit: action failed -- Other action already in progress -- please try again later
             ---- End output of ["/usr/bin/monit", "-c", "/etc/monit/monitrc", "start", "carbon-cache-d"] ----
       Ran ["/usr/bin/monit", "-c", "/etc/monit/monitrc", "start", "carbon-cache-d"] returned 1

             Cookbook Trace:
             ---------------
             /tmp/kitchen/cache/cookbooks/poise-monit/files/halite_gem/poise_monit/resources/monit_service.rb:176:in `monit_shell_out!'
             /tmp/kitchen/cache/cookbooks/poise-monit/files/halite_gem/poise_monit/resources/monit_service.rb:135:in `start_service'
             /tmp/kitchen/cache/cookbooks/poise-service/files/halite_gem/poise_service/service_providers/base.rb:74:in `block in action_start'
       /tmp/kitchen/cache/cookbooks/poise-service/files/halite_gem/poise_service/service_providers/base.rb:134:in `call'
             /tmp/kitchen/cache/cookbooks/poise-service/files/halite_gem/poise_service/service_providers/base.rb:134:in `notify_if_service'
       /tmp/kitchen/cache/cookbooks/poise-service/files/halite_gem/poise_service/service_providers/base.rb:73:in `action_start'
       /tmp/kitchen/cache/cookbooks/poise-service/files/halite_gem/poise_service/service_providers/base.rb:61:in `action_enable'

             Resource Declaration:
             ---------------------
             # In /tmp/kitchen/cache/cookbooks/xpl_graphite_ng/recipes/_carbon.rb

       135:   poise_service res_name do
       136:     command cmd
       137:     user node['graphite']['carbon']['user']
       138:     directory node['graphite']['base_path']

             140:     # templates.uniq.each do |t|
       141:     #   subscribes :restart, "template[#{t}]", :delayed
             142:     # end
             143:     # carbon daemons do not support signals, so KILL is the only thing we can do
       144:     stop_signal 'KILL'

             146:     options :monit, checks: "if failed host localhost port #{tcp_port} then alert", pid_file: pidfile
             147:     supports :restart => true, :reload => false, :status => true

             149:     retry_delay 3
       150:   end
             151:   # store hash of services to audit on later
             152:   instances << { 'daemon_name' => daemon_name, 'res_name' => res_name, 'instance' => instance, 'cmd' => cmd, 'config' => config }
             153: end
             154:

             Compiled Resource:
             ------------------
             # Declared in /tmp/kitchen/cache/cookbooks/xpl_graphite_ng/recipes/_carbon.rb:135:in `block in from_file'

       monit_service("carbon-cache-d") do
        action [:enable]
        supports {:restart=>nil, :reload=>nil, :status=>nil}
        retries 0
        retry_delay 2
        default_guard_interpreter :default
        service_name "carbon-cache-d"
        enabled true
         pattern "carbon-cache-d"
        init_command "/etc/init.d/carbon-cache-d"
        parent monit[monit]
        monit_config_path "/etc/monit/conf.d/carbon-cache-d.conf"
       end

Does it work if you use the binaries provider to install a more recent monit?

while i have to use :system i did try - yes, it fails in the same way.

Hrmm, so it sounds like Monit is being asked to run too many commands in close succession? There is code to automatically retry for 20 seconds. You can try (hackily) extending that from your recipe by adding PoiseMonit::Resources::MonitService::DEFAULT_TIMEOUT = 60. It will yell at you for redefining a const but it should allow it and that should let you try longer timeouts. If that ends up fixing it, I'll add that as a configurable option on monit_service.

the error message is quite famous and can have other reasons besides the obvious. today i had a single converge for ubuntu-14.04 which worked - next one failed again as described. the services managed are python scripts which ususally start and shutdown immediately. additionally, it's a aws c3.xlarge ssd-backed instance which is low on latencies overall.
i wonder if the restarts (or just reloads?) of monit itself can be a possible reason. could you possibly make the 'start delay' configurable on the resource?
set daemon  60              # check services at 1-minute intervals
    with start delay 5      # optional: delay the first check by 4-minutes (by
#                           # default Monit check immediately after Monit start)

I avoided putting set daemon in the config in favor of -d on the command line so that you can still run it one-off from the command line to update things. The loop in monit_service retries on any failure so if waiting longer will fix it, that should catch it.

unfortunately, the start delay can not be set on the command line.
i don't feel like chanhing something i chef to compensate for a configuration statement in a component that should actually get managed by chef - not the other way around.

You can add it yourself by providing your own template :)
monit 'monit' do
  provider :system
  config_source 'monit.conf.erb'
end

Or add it via a monit_config:
monit_config 'daemonize' do
  content 'SET DAEMON 60 WITH START DELAY 5'
end

so the latter one would replace the entry on SET DAEMON already present?

There is no SET DAEMON in the default config, so it wouldn't replace it. There would still be a -d on the command line, not sure how that would interact.

ah sure that was what i meant, sorry. well it's ambigous at least.

Better solution to this: I'll add the start_delay as a property to the monit resource. If that is set to false or 0, I use the current solution, if you want a start delay it puts it in the config instead of command line.

Opinion, daemon_delay, daemon_start_delay, or daemon_splay?

start_delay in an options hash that would also take verbose for -v :)

Good point on the verbose, how about if Chef is at log_level debug I make all commands verbose?

(does running the monit service itself with -v do anything useful?)

as a default value log_level be fine but i'd love to have it at different levels. yeah it does dump lots more info could be useful for debugging, like you said, with chef at debug.

may i also suggest that var_path is bit misleading in comparison to the statement in the config file?

What do you mean?

doh i am stupid. i was assuming it's been used to have the statefile from -s there.

It does, along with the ID file and event queue.

should get some sleep anyways :) it'd be nice to have both configurable too. on EC2 the statefile and queue can be put on a EBS volume so they do survive reboot on system with ephemeral storage.

My solution there was you can set var_path false and it disables that whole chunk of the config so you can write your own. https://github.com/poise/poise-monit/blob/master/chef/templates/monit.conf.erb#L9
I'll CC you on the pull request so you can review it in the morning.

thanks. btw, i'd love to have more than one monitor line per service. sort of a feature request. shall i open issues accordingly?

You mean for the poise_service provider?

yup, yes.

You can pass an array for the checks option to have as many things as you want. https://github.com/poise/poise-monit/blob/master/chef/templates/monit_service.conf.erb#L4-L6
Does that cover it?

oops, sure, i did not notice. thanks.

I should probably also allow straight up replacing the template too. Will add that to my mental todo list.

i also imagine something like a monit_host resource which would manage check host statements. configs. could be done with templates of course but i guess lots of people including me would like a DSLish approach. personally, i use monits lots for host monitoring and other custom stuff.

so the checks option would also make me have statements like
check host wtf with address wtf.foo.local
  if failed ping then alert
  if failed ping6 then alert
  depends on switch
  group kali

but then setting depends and groups on the checks var.. :)

# set up alias (virtual mapping)
ruby_block 'template-changed' do
  block do
    Chef::Log.warn("Configuration files changed!")
    node.set['audit']['config_changed'] = true
    # FIXME: hardcoded
    cmd = Mixlib::ShellOut.new("monit restart all")
    cmd.run_command
  end
  ignore_failure true
end

can you think of a more elegant way to achieve this?

@coderanger kindly pinging

@gretel the monit_config resource does set its updated flag as you would expect, but Chef doesn't have anything to support sending a notification to all resources of a type. The correct-est way to do it would be to make a subresource of monit so it can find the right path to monit and use the right config file.


ci: Remove reference to CHANGELOG in release workflow

This file is no longer updated since 0.24.

softprops/action-gh-release already seems to be doing that :) If not, we can do something about this with the next release :)


Component import problem

Last day i updated my npm packages and got this error:
./node_modules/its-fine/dist/index.mjs
Can't import the named export 'Component' from non EcmaScript module (only default export is available)

Which tool are you using for this? Webpack?

i started getting this too.. simply by deleting node_modules and running npm i

Some basic information about your environment would go a long way to solving this.

ok so this is hot i ended up here.

developing with create-react-app
faced this issue https://github.com/facebook/create-react-app/issues/12212
did what is suggested there and in similar issues, one of steps is downgrading react-scripts
previous errors go away and now I get this error
has nothing to do with my code, everything was working fine, until today with npm i ...

Downgrading react-scripts puts you to v4 which does not understand Node ESM (related: https://github.com/facebook/create-react-app/issues/10356). Could you try with a clean install on v5?

sorry my bad, i get a different set of errors with v4 with v5.0.1 I get the below error on start
./node_modules/its-fine/dist/index.mjs
Can't import the named export 'Component' from non EcmaScript module (only default export is available)
all packages
"@emotion/react": "^11.10.4",
"@emotion/styled": "^11.10.4",
"@mui/icons-material": "^5.10.6",
"@mui/material": "^5.10.6",
"@react-three/drei": "^9.32.1",
"@react-three/fiber": "^8.8.2",
"@react-three/postprocessing": "^2.6.2",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "^13.5.0",
"moment": "^2.29.4",
"nanoid": "^4.0.0",
"nipplejs": "^0.9.1",
"react": "^18.2.0",
"react-animated-cursor": "^2.5.1",
"react-dom": "^18.2.0",
"react-favicon": "^1.0.1",
"react-ga": "^3.3.1",
"react-joyride": "^2.5.3",
"react-scripts": "5.0.1",
"simple-peer": "^9.11.1",
"socket.io-client": "^4.5.2",
"three": "^0.144.0",
"use-sound": "^4.0.1",
"web-vitals": "^2.1.4"

I published a workaround in v1.0.3. Can you try another clean-install (remove lockfiles, node_modules)?

in my project its-fine is a sub-dependency of react-three-fiber, so I'll still get v1.0.2

Alright, I bumped its-fine in v8.8.5 of react-three-fiber if you could try now.

yes everything is working now. Thank you for looking into it

@hakancunier let me know if there are any withstanding issues on your end. This looks to be resolved between CRA and vanilla Webpack with the work around.

still cant get prod environment run.


Custom css class for tooltips

Say I want to customize a tooltip that I am using to show a validation message at a specific input in my form.
It would be nice to have the ability to specify a class name for a tooltip, something like:
$("#my_input").tooltip({
	title : 'Esse CPF já está cadastrado',
	trigger : 'focus',
	placement : 'top',
	cssClass : 'error'
});

Better yet if it had styles to match warning, success, error and info.

We have an open issue now I think for adding classes to popovers—this should extend to tooltips too I think. More on that in a future release.


revert cpu model / feature tests

What this PR does / why we need it:
revert cpu model / feature tests
With labeller PR these tests were changed, but when labeller
was reverted, these tests were not. This PR return old tests back.
Release note:
NONE

Signed-off-by: Karel Simon<EMAIL_ADDRESS>

/override pull-kubevirt-e2e-kind-k8s-1.17.0-ipv6

Merging with some CI fixes.


Add a command for running Bevy for web

The web (through WASM) is a common platform for game jams, but it currently requires jumping through some hoops to get it working with Bevy. We should make this process easier, specifically for during the development cycle.
We could have a bevy web or bevy run --web command that does the following:

Builds project for wasm32-unknown-unknown target
Sets up a basic index.html if you have none
Runs wasm-bindgen
Copies the assets to be served
Starts a local HTTP server
Opens the browser

IIRC cargo-bavy already does most of these, so we can borrow code from there.

Just as a note, I edited Jan's original message as part of my issue-pass in #34.

The edit swallowed up one major point: passes flags along to cargo. This is the one thing that is annoying me the most about Trunk, since it means we cannot have dedicated Wasm profiles when using it.


Fix Mercury News parser for large counties

The Mercury News spreadsheet is hand-entered; sometimes it comes with digit grouping characters, which ended up truncating the numbers in the scraper. This change removes the grouping characters, restoring the full numbers. Unfortunately, this spreadsheet only tracks current numbers, and change tracking doesn’t seem to be enabled. A number of incorrect days will need to be removed or replaced by hand by looking at county dashboards. This will result in inconsistencies, because the Mercury News was tracking only the latest reported figures, not adjusting the numbers as the counties have been retroactively updating old numbers.
Fixes #370.
/ref https://github.com/covidatlas/li/issues/363#issuecomment-668190268

Thanks @1ec5 !


Cannot rename Nodes

Godot version
4.0beta16 and 4.0beta15
System information
Linux(Endeavor OS)
Issue description
Since 4.0 beta 15 I cannot rename nodes, or animations in an animated sprite 2d, I suspect I cannot rename anything in the editor though. Typing works fine in scripts, or in save dialogs.
Steps to reproduce
Node:

Create a node
Try to rename

Animated Sprite:

In the Inspector under the Animation section choose New Sprite Frames (double click to then open the animation menu)
In the Animations menu click on default to rename, I can highlight text but deleting, overwriting, adding charters does not work
Also tired adding a new animation which pops up as new_animation, click on that, also cannot rename

Minimal reproduction project
Rename-Issue.zip

Duplicate of #72074


which version of mxnet does support cuDNNv2 ?

Unfortunately, we don't have that since mxnet is established after cuDNN v3 releases

got it. :smile:

why not use cuDNN v3

tk1 does not support V3.


feat: clusterQueue add status field

Signed-off-by: kerthcet<EMAIL_ADDRESS>
What type of PR is this?
/kind feature

What this PR does / why we need it:
Which issue(s) this PR fixes:

Part of https://github.com/kubernetes-sigs/kueue/issues/134
Special notes for your reviewer:

/ok-to-test

I changed the implement as now we will insert CQs to cohort in any case and we will not remove them unless the delete action. But we will still maintain the status both in qManager and cache, so that when popping elements in scheduling, we will filter out not ready CQs, which is more efficiency. Also in snapshotting, we will exclude not ready CQs also. @ahg-g

Sorry for the force-pushed due to some conflicts. I changed the implement:

Only cache will manage the clusterQueue status
We'll filter inactive clusterQueues in Snapshot.
When resourceFlavor created, scheduler will be waked.

@ahg-g PTAL if you have time.

updated @ahg-g

Thanks, please squash

squashed, thanks @ahg-g a lot.

/lgtm
/approve


Got denied callback for cellular when cellular is allowed

Some of my applications are unable to connect to the internet when on cellular networks only.
I have already gone through all the steps listed on https://www.imobie.com/support/how-to-fix-cellular-data-issue-on-iphone.htm
Some interaction between AFNetworking & Core iOS libraries seems to be failing
The most incriminating evidence is

Jun  7 11:08:23 iPhone advomobo(CFNetwork)[4515] <Error>: NSURLSessionTask finished with error - code: -1009 Jun  7 11:08:23 iPhone CommCenter[81] <Notice>: #I New CTServerConnection from pid 4515 (conn=0x1076efb80) Jun  7 11:08:23 iPhone CommCenter[81] <Notice>: #I CTServerConnection from pid 4515[<private>] is named '<private>'. Jun  7 11:08:23 iPhone advomobo(CFNetwork)[4515] <Error>: HTTP load failed (error code: -1009 [1:50]) Jun  7 11:08:23 iPhone advomobo(CFNetwork)[4515] <Error>: NSURLSessionTask finished with error - code: -1009 Jun  7 11:08:23 iPhone CommCenter[81] <Notice>: #I CTServerConnection from pid 4515 has closed (conn=0x1076efb80) Jun  7 11:08:23 iPhone advomobo(CFNetwork)[4515] <Notice>: TIC TCP Conn Start [42:0x17019ce50] Jun  7 11:08:23 iPhone CommCenter[81] <Notice>: #I Got denied callback for cellular when cellular is allowed Jun  7 11:08:23 iPhone CommCenter[81] <Notice>: #I Ignoring access denied callback for bundle id: <private> Jun  7 11:08:23 iPhone advomobo(CFNetwork)[4515] <Notice>: TIC TCP Conn Event [42:0x17019ce50]: 3 Err(50) Jun  7 11:08:23 iPhone advomobo(CFNetwork)[4515] <Error>: TIC TCP Conn Failed [42:0x17019ce50]: 1:50 Err(50)
pay special attention to I Got denied callback for cellular when cellular is allowed
Any help debugging this would be greatly appreciated

I’m not sure from this what the problem would be or how you’ve set up the code. If you can provide a code sample that you think should work but doesn’t, please re-open, but you might have more luck asking this on StackOverflow.


Improve the public interface

At the moment the interface is quite unusable, especially for Saha's algorithm. We should think about a straightforward and intuitive interface.

Something like a BisimulationPack should be returned by paige_tarjan, dovier_piazza_policriti and saha to be passed to saha (or also other algorithms to skip the graph_decorator part.


DBZ-8414 Catch exception from stopping the connector

Otherwise engine shutdown may get stuck as in such case the count down
of shutDownLatch would be skipped and engine would wait for shutDownLatch forever.
https://issues.redhat.com/browse/DBZ-8414

DBZ server constantly fails with
 Error:  Failed to execute goal on project debezium-system-tests: Could not resolve dependencies for project io.debezium:debezium-system-tests:jar:3.0.3-SNAPSHOT
Error:  dependency: io.debezium:debezium-connector-db2:jar:3.0.3-SNAPSHOT (test)
Error:  	io.debezium:debezium-connector-db2:jar:3.0.3-SNAPSHOT was not found in https://s01.oss.sonatype.org/content/repositories/snapshots during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of oss has elapsed or updates are forced
Error:  	io.debezium:debezium-connector-db2:jar:3.0.3-SNAPSHOT was not found in https://packages.confluent.io/maven/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of confluent has elapsed or updates are forced
Error:  	io.debezium:debezium-connector-db2:jar:3.0.3-SNAPSHOT was not found in https://s01.oss.sonatype.org//content/groups/public/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of ossrh has elapsed or updates are forced
Error:  -> [Help 1]
Error:

No idea what is the root cause, probably some issue in GH infrastructure or something?
I can download these bits locally without any issue, build of DBZ server locally passes as well (and of course I can see the bits in https://s01.oss.sonatype.org/content/repositories/snapshots/io/debezium/debezium-connector-db2/3.0.3-SNAPSHOT/)

@vjuranek Applied, thanks. The missed test is not affected by the change.


Why BATS syntax raises so many shellsheck errors?

I wrote the following add-channel.tests.bats tests suite, works fine. However shellsheck keep raising errors.
Shellcheck errors
All the test case are seen has buggy and shellcheck stop on:
 ^-- SC1070: Parsing stopped here because of parsing errors.

output:
$ shellcheck -s bash ./test/add-channel.tests.bats

In ./test/add-channel.tests.bats line 1:
#!/usr/bin/env bats
^-- SC1008: This shebang was unrecognized. Note that ShellCheck only handles sh/bash/ksh.

In ./test/add-channel.tests.bats line 21:
@test "should raise error without NAME parameter" {                                                                                ^-- SC1083: This { is literal. Check expression (missing ;/\n?) or quote it.

In ./test/add-channel.tests.bats line 25:
    [[ $(remove_ansi ${lines[1]}) == "NAME missing (see 'mast-utils list-host')" ]]
                     ^-- SC2086: Double quote to prevent globbing and word splitting.

In ./test/add-channel.tests.bats line 26:
}
^-- SC1070: Parsing stopped here because of parsing errors.

Question
How do I fix those BATS/shellcheck issues?
P.S.: cross-posting AtomLinter/linter-shellcheck#84.

The test files are not purely BASH, hence why the extension of the filename is .bats not .sh, and why the shebang is to bats.  It is not reasonable to apply shellcheck to bats file as they are not parsed properly by shellcheck.

@jhmartin there is a branch to support bats in shellcheck and an issue koalaman/shellcheck#417


set output messages to external command (terminal output)

HI !!!
How do I set output of VIM command or using
:python os.system("javac -d . *.java")
it is show => "test" at bottom statusline , but i want to output it to external command (not using she bang external command)
Purpose : I'm creating java auto compiler , and using "PYTHON MODULE in VIM script " , I want all output are put to external command (without shebang external command)
Thank you !!!!

I don't understand what you want. Please discuss user questions at vim-use ml or use stackoverflow. This is for issues only.


CSM doesn't source texture maps

When creating a CSM based off MeshStandardMaterial and assigning a map prop referencing a texture, the texture will only be used when not passing a fragment shader chunk to the CSM, or passing a fragment shader chunk that doesn't have a main entrypoint. As soon as you pass a chunk with a main, the diffuse/fragment colors will always reset to red (or whatever color you end up setting yourself in the shader.)
Currently, you need to work around this by sourcing the texture yourself:
void main() {
  csm_FragColor = texture2D(map, vUv);
}

Quickly updating this to mention that I was no longer able to reproduce this, so I'm self-closing it for now until I can.

3.4.0 should button this up even if its not fixed

Correction to my previous comment: I could reproduce it, the bug occurred when I had a code comment that included the string csm_DiffuseColor. But since a fix is coming up, I will leave it closed. Thanks!


feat: add max-fee support

Currently, we're encouraging users to use --rpc. However, using alchemy and infura since the v0.12 the transactions fail very frequently due to FeeTransferError:
PY_TRANSACTION_EXECUTION_ERROR
Transaction from sender address 0x7c0ea427ddca72a6bdd66746e9c0c0651e5eac76977ab9b7bbf796a410f8929 has failed.
FeeTransferError { max_fee: Fee(1899000516528), actual_fee: Fee(2490000677280) }

So the multiplier 1.5 is not enough in that case.
Is that due to latency? To the missing pending state in the v0.12 which is causing this?
To allow users not be dependent on that, this PR adds max-fee support for declare, deploy, invoke and account deploy.

This is weird. It actually looks like a pathfinder bug in estimating declare fees. @Mirko-von-Leipzig

This is not due to latency. The pending state was also not removed with v0.12. This seems to simply be a pathfinder bug. I added a workaround in starkli here: https://github.com/xJonathanLEI/starkli/commit/a8d0eb793690a8d088a310439fc23905c452418b.
It's rather hacky but at least declaring would now work via RPC.

afaik we haven't changed anything here at all. Wonder if this isn't a descrepency between the new blockifier used by the sequencer and the cairo-lang vm.. Will TAL

Back to the PR itself. I don't think it's the best UX to ask for raw field element input for max_fee, given how this number is usually rather large.
I think it would be better UX to default to Ether unit (18 decimals), and at the same time provide another (conflicting) option for raw input.

Superseded by https://github.com/xJonathanLEI/starkli/commit/7c197e0cf90a5c3d9bf717e530ade2e60df0a925.
Added --max-fee and --max-fee-raw.


Fix CSV output format

Add project ID to csv output
Reorder CSV output columns to reflect order of original vcf file (Sample ID, variant hgvs ID first then vcf info, then annovar annotation, then myvariant.info annotation)
Read in correct design file and include this in output

CSV output has changed considerably, and Katie has signed off on new output format.


staging-next 2022-10-13

workflow docs: https://nixos.org/manual/nixpkgs/unstable/#submitting-changes-commit-policy
important jobs:
https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
https://hydra.nixos.org/job/nixos/staging-next-small/tested
jobsets:
https://hydra.nixos.org/jobset/nixpkgs/staging-next
https://hydra.nixos.org/jobset/nixos/staging-next-small
nix-review reports: https://malob.github.io/nix-review-tools-reports/
previous staging-next: https://github.com/NixOS/nixpkgs/pull/193494

systemd build is fragile because of https://github.com/mesonbuild/meson/issues/10919

systemd build is fragile because of mesonbuild/meson#10919

Oooooh this explains something I ran into

systemd: for now I'd suggest PR https://github.com/NixOS/nixpkgs/pull/195934

[ ] rustc 1.64.0 fails to build on x86_64-darwin @zowoq @alyssais

The cc-wrapper arg deduplication seems to have broken netcat-openbsd on x86_64-linux, bisected failure to 0bea4a194f7103fcedc0226a74e50657875a7c4d

0bea4a194f7103fcedc0226a74e50657875a7c4d also broke iortcw

I'm not aware of anything really blocking this PR. (Perhaps wait a while to finish almost all the builds.)  Comparisons:

3 platforms: https://hydra.nixos.org/eval/1783854?compare=1783856
aarch64-darwin: https://hydra.nixos.org/eval/1783854?compare=1783841
We have significantly more newly succeeding than newly failing builds, at least numerically right now.  I hope it's not just because I've done multiple of restart-failed steps due to some transient errors.


ES6 controller class with angular 1.5.5 has $onInit called before constructor

Bug
I'm using ES6 with angular 1.5.5 and using babel to convert to ES5.
export class ReportConfigColumnDialogController {
    constructor($mdDialog, column) {
        'ngInject';

        // fired after $onInit
        this.column = column;

        console.log(this.column.Alias);  // has expected value
    }

    $onInit() {
        // fired first
        console.log(this.column.Alias); // this.column undefined at this point
    }
}

According to the docs at https://code.angularjs.org/1.5.5/docs/guide/component:
$onInit() - Called on each controller after all the controllers on an element have been constructed
That's not what I'm seeing in my code.  $onInit got called before the constructor.
BTW, the ES5 code generated by babel looks like this:
var ReportConfigColumnDialogController = exports.ReportConfigColumnDialogController = function () {
        ReportConfigColumnDialogController.$inject = ["$mdDialog", "column"];
        function ReportConfigColumnDialogController($mdDialog, column) {
            'ngInject';

            _classCallCheck(this, ReportConfigColumnDialogController);

            this.column = column;

            console.log(column);

            this.$mdDialog = $mdDialog;
        }

        _createClass(ReportConfigColumnDialogController, [{
            key: '$onInit',
            value: function $onInit() {
                this.aliasQuestion.Answer = this.column.Alias;
            }
        }, {
            key: 'save',
            value: function save() {}
        }, {
            key: 'close',
            value: function close() {
                this.$mdDialog.cancel();
            }
        }]);

        return ReportConfigColumnDialogController;
    }();

@opadillaintegrify, I wasn't able to reproduce it (here).
Could you create a live demo of the problem (you can form my CodePen or use anything else that works for you, e.g. plnkr, etc).

Here is a CodePen in which $onInit() doesn't get fired at all: https://codepen.io/anon/pen/YqvjLB.  Click on Launch Dialog and see console logs.
That CodePen is a fork of https://codepen.io/marcysutton/pen/PwJrrG but with babel turned on and the DialogController converted to an ES6 class.
class DialogController {
  constructor($scope, $mdDialog){
    console.log('DialogController constructor');
  }

  $onInit() {
    console.log('DialogController $onInit');  // nothing in CodePen console
  }
}

Maybe my problem is specific to angular material design's dialog?  I only see the problem when using ES6 classes as controllers to the dialog as shown in the code pen above.  Typical controllers and components work correctly as demonstrated in your CodePen.

Yep, looks like angular-material doesn't support the new lifecycle hooks for a variety of things right now.
https://github.com/angular/material/blob/master/src/core/services/compiler/compiler.js#L117

@dcherman is right. This is an issue with ngMaterial not supporting lifecycle hooks (yet).
Please, open an issue over there.
(BTW, classes or Babel don't seem to have anything to do with this afaict.)

@opadillaintegrify  Have you tried this.
class DialogController {
  constructor($scope, $mdDialog){
    console.log('DialogController constructor');

    this.$onInit() {
        console.log('DialogController $onInit');
    }
  }
}

This works for me.

I have the same problem, i think that the problem is comming from version of angular-material.
I don't need to use this proposition:

constructor($scope, $mdDialog){ console.log('DialogController constructor'); this.$onInit() { console.log('DialogController $onInit'); } }

because the $onInit here it will be called on constructor phase and not after that.

Also, if the controller instanciated by the router and not by the directive, the $onInit can not be fired.


build jenkins-contribution-aggregator instead of jenkins-top-contributor

With the move of the application to the jenkins-infra org, the repository application has also been renamed. For tidyness, this implies that the executable has to be rename.
### Tasks
- [x] Rename main file to `jenkins-contribution-aggregator`
- [x] update make file
- [x] update goReleaser
- [x] test release process
- [x] test codecoverage

The required changes have been performed 👍


Modal for upload and select files

LIke google file uploader and selector and add this feature in: https://github.com/wejs/we-plugin-file

done in we-plugin-file master https://github.com/wejs/we-plugin-file/commit/6eb149cffb04272ce2baed08bbfaf1b73b17146c


Less intellisense broken after 0.10.10 release

After the latest release less intelisense is broken.
Please see the attached images for the difference in intellisense when selected mime is less vs. css

Also when changing mime type from less to css you get syntax errors as expected, but when changing from css to less the syntax errors do not refresh it keeps the same state until you close the file in working files and reopen

Thanks

If I understand right, this is a similar snippet:
.btn-group {
  .btn:

}

and you try to do code completion after the :
This is a bit of a tricky case for the LESS parser to detect, and never worked. Why you get some results in CSS is that the CSS parser went into error recovery after seing the inner class name.

Yes your snippet is similar.
I though previously I had used it.
CSS though the pseudo's already work when there is no error(using straight CSS)


The example in the readme is not compatible with Circuitpython

The example in the readme gets 2 errors in Circuitpython:
print("Current UTC time: ", datetime.now(timezone.utc))

Traceback (most recent call last):
  File "code.py", line 13, in <module>
  File "adafruit_datetime.py", line 1356, in now
  File "adafruit_datetime.py", line 1328, in fromtimestamp
  File "adafruit_datetime.py", line 1306, in _fromtimestamp
NotImplementedError: CircuitPython does not currently implement time.gmtime.

print(
    "The {1} is {0:%d}, the {2} is {0:%B}, the {3} is {0:%I:%M%p}.".format(
        dt, "day", "month", "time"
    )
)

Traceback (most recent call last):
  File "code.py", line 23, in <module>
ValueError: invalid format specifier

Should it be replaced with the simpletest example code ?

yes plz!


weighted record howto?

We try to created a weighted record according to route53 if all the weighted entries are 0 then it loadbalances it equally.
so we already have 2 entries like this:
test.example.com CNAME work.example.com WEIGHT 0 ID BLABLA1
test.example.com CNAME work.example.com WIGHT 0 ID BLABLA2
Now I try to automate this in opsworks with this module and I use the following:
include_recipe "route53"

instance_info = search(:aws_opsworks_instance, "self:true").first

route53_record "create a record" do
  name  "test.example.com"
  value "work.example.com,"
  type  "CNAME"
    ttl 300
  weight "0"
  set_identifier "#{instance_info[:hostname]}"
  zone_id               "xxxx"
  aws_access_key_id     "xxxxx"
  aws_secret_access_key "xxxxx"
  overwrite true
  action :create
end

But we keep getting the following error:
[2016-10-14T12:52:40+00:00] ERROR: Error with UPSERTrequest: {:hosted_zone_id=>"/hostedzone/XXXXXXX", :change_batch=>{:comment=>"Chef Route53 Resource: test.example.com.", :changes=>[{:action=>"UPSERT", :resource_record_set=>{:name=>"test.example.com.", :type=>"CNAME", :ttl=>300, :resource_records=>[{:value=>"work.example.com"}]}}]}} :::
[2016-10-14T12:52:40+00:00] ERROR: RRSet with DNS name test.example.com., type CNAME cannot be created as other RRSets exist with the same name and type.

Do you see what we do wrong?

My colleague helped out and created a small fix so the weight will work we tested this also to make sure it works.
However we both think that the way this is done currently to detect "geo_location" and "weight" is not very nice.
Perhaps a better alternative is to add an additional option such as "routing_policy" and then you should be able to select:
simple
weighted
latency
failover
geolocation
and then it should select the required things route 53 needs.

The route53_record resource in this cookbook has been merged into the aws cookbook itself and improved quite a bit. There's also been a new aws_route53_zone resource added for creating / deleting zones. At this point in time we're deprecating this cookbook in favor of the aws cookbook. If you're still having this issue feel free to open it up in the aws cookbook.


Where is content folder?

Do you use netlify cms for managing your content? I see your config.yml file and you set folder for post to content/posts but i don't see content folder.
Cool personal web btw :)

I no longer used it. I just edit the content as code in text editor.


Suggestion: add native utility types

Linking to the utility types provided by TypeScript would be really handy imho, though it might be outside the scope of this plugin, as we would not link to MDN.
Let me know what you think, I'd be happy to create a PR!

I really like this idea, though I agree it doesn't really fit with this plugin... I think this would be a good fit for a new plugin. I'm somewhat tempted to say it should go in typedoc itself, but since nothing else links to external websites (except for the generator link in the footer), it feels more appropriate to delegate to a plugin for now.

Cool, I'll create a separate plugin and get back to you once it's ready!

Ended up deciding to add support for it, under an option which defaults to being on in case someone doesn't like it, but since they're also under the TS package it doesn't seem too weird to have it here.


Update Jeeliz FaceFilter

Hi,
I have pushed some major bugfixes on Jeeliz FaceFilter ( https://github.com/jeeliz/jeelizFaceFilter ) these last weeks.
There are some important compatibility improvements (related to https://github.com/jeeliz/jeelizFaceFilter/issues/186 )
it would be worth updating :)
Best,
Xavier

Hey @xavierjs sorry for the late reply!
Ok so I thought this would be a simple update, I pulled the latest but doing so broke all the filters that I had pulled and modified from the demos. I guess there are some breaking changes there. I don't have the time to go through and update those right now so I think I'll skip the update for now.

@xavierjs I updated the lib to the latest (commit hash 06afda0ea88a0fe30ff43d586c89024795747caa). This time didn't encounter any issues with prior scripts breaking!


Insufficient permissions to execute the AdminLinkProviderForUser command

Environment information
System:
  OS: Linux 6.5 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
  CPU: (12) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
  Memory: 53.89 GB / 62.64 GB
  Shell: /usr/bin/zsh
Binaries:
  Node: 18.15.0 - ~/.nvm/versions/node/v18.15.0/bin/node
  Yarn: 1.22.19 - ~/.nvm/versions/node/v18.15.0/bin/yarn
  npm: 9.6.2 - ~/.nvm/versions/node/v18.15.0/bin/npm
  pnpm: 8.5.1 - ~/.nvm/versions/node/v18.15.0/bin/pnpm
NPM Packages:
  @aws-amplify/backend: 0.13.2
  @aws-amplify/backend-cli: 0.13.0
  aws-amplify: 6.0.30
  aws-cdk: 2.138.0
  aws-cdk-lib: 2.138.0
  typescript: 5.4.5
AWS environment variables:
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Description
I have a function that needs to use the AdminLinkProviderForUserCommand command, but the "manageUsers" action does not seem to contain the 'cognito-idp:AdminLinkProviderForUser' action.
// amplify/auth/resource.ts

import { linkProviderForUserFunction } from '@/amplify/functions/link-provider-for-user/resource'

export const auth = defineAuth({
  ...
  access: allow => [
    allow.resource(linkProviderForUserFunction).to(['manageUsers']),
  ],
})

// amplify/functions/link-provider-for-user/handler.ts

import { env } from '$amplify/env/link-provider-for-user'
import type { Schema } from '@/amplify/data/resource'
import {
  AdminLinkProviderForUserCommand,
  CognitoIdentityProviderClient,
  InvalidParameterException,
} from '@aws-sdk/client-cognito-identity-provider'
import { AppSyncIdentityCognito } from 'aws-lambda'

const client = new CognitoIdentityProviderClient()

export const handler: Schema['linkProviderForUser']['functionHandler'] =
  async event => {
    const { providerName, providerUserId } = event.arguments
    const identity = event.identity as AppSyncIdentityCognito

    const command = new AdminLinkProviderForUserCommand({
      UserPoolId: env.AMPLIFY_AUTH_USERPOOL_ID,
      DestinationUser: {
        ProviderName: 'Cognito',
        ProviderAttributeValue: identity.username,
      },
      SourceUser: {
        ProviderName: providerName,
        ProviderAttributeName: 'Cognito_Subject',
        ProviderAttributeValue: providerUserId,
      },
    })

    const response = await client.send(command)
    ...
  }

The following error occurs:
2024-04-26T01:10:30.391Z	5eada46c-eea6-4093-8b5e-0f4557193695	ERROR	Invoke Error 	{
    "errorType": "AccessDeniedException",
    "errorMessage": "User: arn:aws:sts::089370838833:assumed-role/amplify-drinkshopbackend--linkproviderforuserlambda-Hji1xUz2DDsw/amplify-drinkshopbackend--linkproviderforuserlambd-GNHSJOXwO4To is not authorized to perform: cognito-idp:AdminLinkProviderForUser on resource: arn:aws:cognito-idp:us-east-1:089370838833:userpool/us-east-1_SPrRZH9Kd because no identity-based policy allows the cognito-idp:AdminLinkProviderForUser action",
    ...
}

Is there any solution? Thanks.

Hey @eechih, thank you for reaching out. The issue appears to be similar to https://github.com/aws-amplify/amplify-backend/issues/1375, refer to the comment https://github.com/aws-amplify/amplify-backend/issues/1375#issuecomment-2079388509 using override to add the permissions
Marking this as feature request.

@ykethan Thanks a lot, that worked :)

Hi @ykethan , I checked the doc, seems like we still don't have the AdminLinkProviderForUser  option, and that could cause some issue, for example when we try to assign this action or permission to pre-signup trigger, right?  And I don't think we can directly access this trigger using backend.auth.resources and add the action manually. So what is your opinion?


[Feature request]: Use pull-request for new commits

I suggest that new commits be merged via pull request, not directly pushing them to the master branch.
Users watching this repo will get notified of new changes if a pull request is used. Also, it is easier to review
the changes and leave comments.

@csukuangfj
Sometimes I push small changes straight to main. I'll try to make pull requests for any additions or fixes from now on.

I suggest that new commits be merged via pull request, not directly pushing them to the master branch.我建议通过拉取请求合并新提交，而不是直接将它们推送到主分支。
Users watching this repo will get notified of new changes if a pull request is used. Also, it is easier to review如果使用拉取请求，观看此存储库的用户将收到新更改的通知。另外，审核也比较容易 the changes and leave comments.更改并留下评论。

I suggest that new commits be merged via pull request, not directly pushing them to the master branch.我建议通过拉取请求合并新提交，而不是直接将它们推送到主分支。
Users watching this repo will get notified of new changes if a pull request is used. Also, it is easier to review如果使用拉取请求，观看此存储库的用户将收到新更改的通知。另外，审核也比较容易 the changes and leave comments.更改并留下评论。

你也要搞Rust吗？


Fix name of peer dependency in README

Either the sentence doesn't make sense, or there is a small mistake :)

indeed it's a mistake! :)


Changed IsNullable for OpenApi3

Using NSwag to genereate OpenApi3 with 'openapi2csclient' the default was Mandatory for properties, this is not matching the OpenApi3 schema default, what has as default Optional. This resulted in not validated the jsonrequest-instances correctly.
Please merge this PR so I can use the openapi2csclient from you again instead of using my local one.

@RicoSuter, we still use a local version of this because of the change I made for this. Is there a reason not to change this in your version?
I hope to hear from you.


[fix] content basename validation

#1313

Coverage decreased (-2.1%) to 82.608% when pulling 3a5435a61643dccfcf2dc791206b2b0e2307ce9c on itowtips:fix-content into ff697f9f35bc92c5879b363d5db6bcd658eb6edd on shirasagi:master.

Coverage decreased (-1.9%) to 82.855% when pulling 34d115dfbce981bbb1e40efbd1872beb5561ceb8 on itowtips:fix-content into ff697f9f35bc92c5879b363d5db6bcd658eb6edd on shirasagi:master.

Coverage increased (+0.08%) to 84.783% when pulling cf6c92021727d873199310b9807cd8f24c887a00 on itowtips:fix-content into ff697f9f35bc92c5879b363d5db6bcd658eb6edd on shirasagi:master.

Changes Unknown when pulling e0992f6ca5643b3f34201b9e089267d415e3a90c on itowtips:fix-content into ** on shirasagi:master**.


⚠ Bofrost.es has degraded performance

In b9d719e, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1795 ms

Resolved: Bofrost.es performance has improved in d09935c after 53 minutes.


Fix a possible memory leak in dtBuildTileCacheLayer

I've opted not to introduce a RAII class here as data is output anyway, so it would mostly benefit for buffer; but this file only uses this pattern in this one place, so I don't think it would be worth it.

Nice catch!  Looks good to me. 👍

Good spot! Weird that Coverity didn't notice this!

it could be that you need to instruct coverity that dtAlloc() is a custom memory allocator and should always have a dtFree() pair.
You can find more details at https://scan.coverity.com/tune and https://scan.coverity.com/models#c_checker_checkerconfig , in particular

_coverity_alloc_() - indicates function allocates memory
_coverity_free_() - indicates function frees the memory allocated for the pointer


Unhighlighting remove all classes from the span

Hi,
Any chance to revert (unhighlight) text and only to remove the added class that was added by this library?
If we are highlighting an element that has other classes they will be lost when unhighlighting

Hi @mp3il,
thanks for submitting.
Please read the Contribution Guideline and provide the things named there.

I'm closing this issue for now because I lack the necessary information.


:arrow_up: coffee-script

Just a friendly reminder to occasionally update coffee-script.
Allows new syntax to be used and also provides better source maps.
After merging, make sure to clear compile-cache for updated source maps to take effect.
Changelogs can be found at http://coffeescript.org/#1.12.0 and then by scrolling up.

Works fine on Windows 10 (x64)

[X] Run tests successfully
[X] Build
[X] Use Atom after building

I don't know what's wrong with CI but I've had the build running for a while now and diff against the parent build only shows differences in sourcemaps, so I would say that it is safe to merge this.

Hey @Ingramz. Thanks for this.
Unfortunately, after watching the ecosystem evolve we have realized that never should have baked transpilation into Atom. If we upgrade the bundled CoffeeScript transpiler, there is a high probability of breaking a bunch of existing code.
Long term, the solution is for us to fix our package publishing system to allow transpiled assets to be published along with the release in addition to source files that are checked into Git. We haven't gotten there yet 😞.
In the short term, to use a newer CoffeeScript or any other language you want, you can bundle a custom transpiler with your package that will cache the transpiled sources the first time the package is started. This is great for development but it's unfortunate that it forces you to bundle the transpiler as a dependency of the package which increases its storage footprint and install time. If you can accept that trade-off, then the github package is a good example of how a custom transpiler can be used.
My apologies for this situation. Baking in transpilation was a short-sighted design decision I made early on in this project and we really need to do the work to allow artifacts to be published with packages, but haven't.

Okay, after further discussion with the commit author and the rest of the team, I've changed my mind on this.
Bundled transpilation is not something we plan to stick with over the long term, but this minor upgrade seems to be low risk. If it breaks packages, which seems unlikely, we can lint for the offending construct across the ecosystem.
I just want to say right now that merging this upgrade is not a promise to merge future upgrades. We'll have to take it on a case-by-case basis and judge the risk in each scenario. Specifically, it's extremely unlikely that we'll be able to upgrade bundled transpilation to CoffeeScript 2.0.

Part of my promise to @nathansobo during that discussion was to check for compilation output differences between the old and the new version across all the packages.
Compilation differences between 1.11.1 and 1.12.7 were found in following .coffee files using atom-package-downloader and find . -name "*.coffee" -type f. This resulted in 13242 files that needed to be checked. I crafted a script that ran coffeescript.compile(contents) for both versions and compared their outputs whether they are equal or not. Files that failed to compile with 1.11.1 were excluded.
Differences were found in following files:
atom-beautify/src/beautifiers/index.coffee
atom-beautify/src/beautifiers/sqlformat.coffee
atom-gibo/lib/atom-gibo.coffee
atom-latex/spec/main-spec.coffee
cubic-bezier/lib/cubic-bezier-curve.coffee
ever-notedown/lib/markdown-helper.coffee
file-header/lib/file-header.coffee
find-and-replace-fix/lib/project/results-view.coffee
forcedotcom-builder/lib/build.coffee
git-control/lib/dialogs/flow-dialog.coffee
git-control/lib/views/file-view.coffee
git-controlhub/lib/dialogs/flow-dialog.coffee
greppen-grok/lib/greppen-grok-model.coffee
imdone-atom-github/lib/plugin.coffee
quick-editor/lib/quick-editor.coffee
rot13/lib/rot13.coffee
sf-tools/lib/build.coffee
simple-git/lib/editor.coffee
super-duplicate/lib/super-duplicate.coffee
tnote/lib/tnote.coffee
ult-terminal/lib/term-view.coffee
you-complete-me/lib/get-issues.coffee

List is small enough that I can go through those by hand.

Fabulous. Thanks for the quick follow-up.

Differences are mostly that code which compiled to ternary expressions, the conditional is now surrounded by parentheses, which is harmless.
There are three files that have a different change, which need to be looked at case by case:
atom-latex/spec/main-spec.coffee (original)
quick-editor/lib/quick-editor.coffee (original)
you-complete-me/lib/get-issues.coffee (original)

Please change your dependency to coffeescript rather than coffee-script. coffeescript is the primary module now for CoffeeScript.


Bug fix/shadow not respecting flag

Using the flag to disable the elevation on API 21+
Using the flag to remove the margin on API 20-

Coverage decreased (-0.07%) to 63.388% when pulling 6a92d10e6696a2c4bf9d1207145cf2e48a514259 on bug_fix/shadow_not_respecting_flag into 9bfea75734acaf2cad7a025ee763b6c8eafa5448 on development.

@roughike can you have a look at this? If not I will merge it tomorrow

It's all good, nice job.

@roughike well i don't know how i missed that in the first place, i guess i was too focus on making the shadow work perfectly that i totally forgot about the case when you don't want a shadow :(


Request to provide an interface for judgment screen

Provide a way to determine whether the device is Liu Haiping or the water drop screen. I saw some methods in the source code, hoping to provide an interface....

this should be resolved in version 1.0 which was released today, thanks for reporting!


iohk-nix: reset qa/ff environments from genesis

resets friends and family and shelley qa environments in preparation of the new released version.

bors r+


feat: timer functionality

I saw timer functionality in your TODO...
I changed a few things in window.lua for easier integration with the timer. Also, I added an option to quit scrambler with q.
Preview:
https://github.com/user-attachments/assets/904b04c1-1162-468a-9ae5-bca0f1e74e3f
Ofc, if you don't like this PR feel free to reject it, or if you want me to revert some changes (or add something else to this PR) I'm here for it.

Ofc, if you don't like this PR feel free to reject it, or if you want me to revert some changes (or add something else to this PR) I'm here for it.

I'm just surprised that someone seems to be using this plugin. :)
I love that you give me a PR with improvements on this. If you like the plugin and want to do work on it then I'll gladly take it.


Add "view on WorkflowHub" link

A nice feature to add would be a link to the workflow's page on the source registry (for workflows that do come from a registry).

addressed in 0.1.0-alpha2


Microsoft login page loop

Had been trying to setup ibex-dashboard using Azure deploy. every time, it is looping after saving the settings. it's not allowing me to go bac to the dashboard. and without authentication, I cannot do anything

@alokraj68 atm you have to click the apply button to confirm you don't want to use auth -

@alokraj68 - If you're not entering the right properties in the authentication fields, this can cause some problems which we haven't gotten around to checking yet.
Is it possible the problem is caused by entering the wrong credentials?
We'll try checking it anyway this week or next one.

If you want to turn off auth for now - go to your Web App in Azure portal

Select Advanced Tools and select 'Go' to open Kudu in new window
Select CMD under Debug console menu
In file explorer navigate to 'sites/wwwroot/server/config'
Delete the 'setup.private.json' file or else edit the json enableAuthentication property to false.
In Azure portal web app Overview blade select 'Restart' app
Refresh /setup in a few seconds and it should be back to normal

That helped.
But I can only see errors as of now. everything else is not loading.

@alokraj68 -

Which template did you choose?
did you connect your bot (from the portal) to application insights?
Did you connect the instrumentation to your bot?

I choose the first 2 templates.
Yes, I did.
Yes, I did.

The error is coming correctly, everything else is not loading.
Thanks and Regards,
[image: Astro-Vision Future Tech] https://htmlsig.com/t/000001C1E7PD
Alok Rajasukumaran / Developer - Innovation Team
<EMAIL_ADDRESS>/<PHONE_NUMBER>7654
Astro-Vision Future Tech
Kuthappadi, Thamannam, ErnakulamKerala, India - 682032
alokraj68.in
[image: Twitter]  https://htmlsig.com/t/000001BVYZJE [image: Facebook]
https://htmlsig.com/t/000001BX9HG8 [image: Google +]
https://htmlsig.com/t/000001BV7H1J [image: LinkedIn]
https://htmlsig.com/t/000001C065D9 [image: Youtube]
https://htmlsig.com/t/000001C06RDJ [image: Github]
https://htmlsig.com/t/000001BYKTTT [image: Soundcloud]
https://htmlsig.com/t/000001BX996X [image: Stack Overflow]
https://htmlsig.com/t/000001BVE8RR
On 13 July 2017 at 14:45, Mor Shemesh<EMAIL_ADDRESS>wrote:

@alokraj68 https://github.com/alokraj68 -

Which template did you choose?
did you connect your bot (from the portal) to application insights?
Did you connect the instrumentation to your bot?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CatalystCode/ibex-dashboard/issues/238#issuecomment-315021024,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIyDmyl0Q7AQTX3reIaXPEgS2DVHJy-eks5sNeAUgaJpZM4OVPiD
.

@alokraj68 - can you try to redeploy the application and follow the instructions?
We've updated the instructions to be more precise as well as the links.
LMK if that works.

p.s. don't forget to get the updated version from master branch

I'm getting the same issue. And yes, I have followed the instructions thoroughly.

Same issue meaning an endless login loop.

Same issue, an endless login loop


Rest API for triggering Jobs.

I have raised a discussion here
https://groups.google.com/forum/#!topic/gobblin-users/8kGgFWt49QY
I am raising an issue for it it too.

Hi Shankar,
Currently, you can run Gobblin in standalone mode to poll a directory for
job files. Then, you can run a simple web server that uploads the job files
to a directory. Previously, Gobblin supported polling only local file
system for job files. In our latest release (0.8.0), we have added support
for polling any Hadoop file system (e.g. HDFS).
We are also working on some improvements on how jobs are launched which
will address directly your use case (uploading Jobs through a REST API) and
add support for other use cases such as creating/triggering jobs from Kafka
events. We hope to introduce those enhancements in our next release - 0.9.0.
Thanks.
On Mon, Sep 5, 2016 at 7:47 PM, Shankar<EMAIL_ADDRESS>wrote:

I have raised a discussion here
https://groups.google.com/forum/#!topic/gobblin-users/8kGgFWt49QY
I am raising an issue for it it too.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/linkedin/gobblin/issues/1254, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4sG_TjEKWXx3se0Cp500FAZphxwMg8ks5qnNQrgaJpZM4J1anm
.


Fix #177 Replace Alpine to Debian as a builder for krakend

There is a fix for a problem #177 when krakend with custom plugin could not be started.
Developers in #krakend slack channel noticed that replace alpine to another distro helps with this issue. I've dropped alpine support and replace it to debian:buster.
It slightly increases docker image size, but makes plugins work.

This is great!
I'd rather offer both images: the traditional, lightweight one and the one ready for plugins, so users could choose whatever fits best their requirements
@taik0 what do you think?

This is great!
I'd rather offer both images: the traditional, lightweight one and the one ready for plugins, so users could choose whatever fits best their requirements
@taik0 what do you think?

I thought about it as well, but there is an issue with plugins when it used with alpine image

yes, but not everyone requires plugins and the extra MB of the new image would impact them as well (we try to keep the image as small as possible for quicker build and release processes)

How about make debian image by default and alpine with alpine tag?

Updated targets in Makefile:
make krakend_docker builds devopsfaith/krakend:1.0.0 based on debian buster
make krakend_docker_alpine builds devopsfaith/krakend:1.0.0-alpine based on alpine builder (uses Dockerfile.alpine with multi-stage build)
But yes, it breaks backward compatibility and from next version will need to update image version if someone wants to use alpine version

Hi @disc and @kpacha
Looks good to me.
IMHO the alpine  should be deprecated because of the lack of plugins so I don't mind to trade the some size of the container for the ability to use plugins in the default image.
Thank you!

It will about 25% image size downsizing
(debian:buster-slim) devopsfaith/krakend    1.0.0   de8b01299d31    12 minutes ago  147MB
(debian:buster) disc/krakend                1.0.0   cf76c37d3a91    4 days ago      192MB

What about -alpine should I keep it in this PR or drop it?

We should maintain it as an option for those who don't need plugins and want a smaller container.

@disc thank you for the contribution!!!


Adjust screen for Navbar

The Issue
Navbar looks fine on Desktop, but on smaller screens, padding-left is 15px on the left-navbar when it should be 23px as per Zeplin, and there's no space above the entire navbar. It just doesn't look good having the logo touching the top of the screen, no space in-between.
Suggestion to Fix
Adjust padding-left on left-navbar
If we can't keep the same height value for some reason then maybe:
Add padding-top on navbar
Add the same amount in margin-top of the "Help Board" bar-tab which is below
(idk if this is the tidy way to do this, but yeah)
Edit: Same space for the top should be in the bottom!
Front end, front end clean up, mobile
P4 level

Ok thanks, I will close #1572 if it is my request that I opened.
Regards
Vijay
On Tue, Oct 6, 2020 at 3:11 PM Josue V<EMAIL_ADDRESS>wrote:

Closed #1572
https://github.com/FightPandemics/FightPandemics/issues/1572 via #1597
https://github.com/FightPandemics/FightPandemics/pull/1597.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FightPandemics/FightPandemics/issues/1572#event-3847144519,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARG6ZUAAENFH7MU5QQD7KMTSJNTX3ANCNFSM4SB6AQ6Q
.

Verified in STG as working fine. Refer below screenshot.
https://share.getcloudapp.com/7Ku8mdEb


Can we loop time cells from 08:00 to 08:00 next day?

Hi,
I have seen in doc that you can do time-from and time-to, but max value of time to is 24 * 60 so the cells stop at 24:00. Can we loop them from a given time to the same time next day, so that I can still get 24 cells ?
PS: If you don't have this feature I can raise a PR!

Hi @psengh,
time-from & time-to are used to defined the daily time range you are interested in, anything outside of this range will be hidden refer to this example https://antoniandre.github.io/vue-cal/#ex--timeline.
So if you don't set any time-from & time-to by default it will go from 00:00 to 24:00 just as a normal day.
Thanks for suggesting a PR, but I don't think it makes much sense to go over 24 hours as a day does not have more than 24 hours.
That would also cause troubles naming the day cells, what would be the title if it spans on multiple days?
If you want an event that spans on multiple days though you can already do it: https://antoniandre.github.io/vue-cal/#ex--multiple-day-events, and you can remove the time-from & time-to to see the full event on week view.
Hope it helps.

Hey @antoniandre,
I understood what you are trying to say. It's not a good thing to do.
In case if you need any help in any other PR's please let me know.
Cheers.

Thanks for your enthusiasm @psengh!
Well there's always work if you want to help on vue-cal,
First if you have experience with #127 or #168 please have a look. Otherwise #184 seems to be the easiest issue for a start. Then #139 may be just slightly more complex.
If you start anything, please email me, (you can find my email is in the package.json file) and I will give you more instructions on what you pick.
Cheers!


Update CategorySelector and MapKey

This is rebased on the DisplaySelectedCatFigures component introduced in https://github.com/ONSdigital/census-atlas/pull/127 so that one should go in first.
Contents:

CategorySelector
MapKey
Table text overlap fix

Ready for review.

Well, now.


ARROW-14656: [Python] sort helper for Array, ChunkedArray and StructArray

This is currently blocked by:

array_sort_indices not working on ChunkedArray: https://issues.apache.org/jira/browse/ARROW-12042
array_sort_indices not implemented for StructArray

@amol- Why don't you just sort_indices instead?

@amol- Why don't you just sort_indices instead?

That's what I'm ending up doing for ChunkedArray, I tried passing None as the column name but it explicitly requires a string, so I'll just end up passing an empty one

That's what I'm ending up doing for ChunkedArray, I tried passing None as the column name but it explicitly requires a string, so I'll just end up passing an empty one

Yes, using "dummy" name is also what we do elsewhere:
https://github.com/apache/arrow/blob/92ee2952155070f7c0bfe3c05f9ccddebf7620db/python/pyarrow/compute.py#L722-L723

@amol- What is the status on this? Do you want to take it up?

I think I can take it up if @Jedi18 can't work on it anymore. Or even better would @AlvinJ15 be able to tackle it? He can probably do it faster than me.

@amol- I think this PR can be closed?
The python API additions have been merged in https://github.com/apache/arrow/pull/14781, and the C++ additions are also included in the open PR https://github.com/apache/arrow/pull/14369

@amol- I think this PR can be closed?
The python API additions have been merged in #14781, and the C++ additions are also included in the open PR #14369

I think so, I think it was still open only to take the pieces and move them into the other PRs


"Reset PV Discovery" action

We should consider implementing a "reset PV discovery" UI action. Since the controller chooses default storageclasses on the first pass, if the user realizes that there's a missing storageclass on dest (i.e. ceph isn't available, etc.) and adds it post-discovery, the controller won't overwrite the initial default values on the next pass since it has no way of knowing whether it's overwriting user-entered values. Adding a "reset" action, which would result in migplan update that removes the entire persistentVolumes array, would allow PV discovery to start over for the plan, selecting new defaults based on the newly-added storage classes.

@sseago could we pass something to the api that would signify that we are rerunning PV discovery? We are using UI state to determine if we are rerunning pv discovery or if it being run for the first time on a mig plan. We could pass this flag to the back end if that could trigger a reset?

We've implemented something like this on previous kubernetes controllers with a dedicated field that is a monotonically increasing value who's sole purpose is to force a re-reconcile.
Ex: relistPersistentVolumes: 0. Editing this value to 1 would force a refresh of the data. It can be done from the cli, or from the UI. I think this would be a useful feature as a "force refresh".


Best practice for error handling in pools - No pool.on('error'

In the docs, it is recommended to watch connection.on('error', yet I'm not sure how this ties into pool.query(...).  Does the pool.query method watch that event and provide the error via the callback?
I want to ensure I'm not missing errors.  The pool.query method adds a ton of simplicity, so I would ideally like to stick with it.

Hi @bitsoflogic , sorry for the delay. So with the pool, the way it was designed to work is such that you do not need to add any error listeners at all; simply acting on the err arguments to your callback functions should be enough with the pool.

Awesome, thanks!


Typographical improvements, and bug fixes

The changes seem to be major as I removed the file entirely and replaced with the update version, but changes are minor.

This pull request is now managed with CodeReviewHub. Refresh.


Add Result to swift compatibility check

I have created a PR to https://github.com/apple/swift-source-compat-suite to add Result to this suit. Please check, in case you think any changes are required.
https://github.com/apple/swift-source-compat-suite/pull/34

apple/swift-source-compat-suite#34 was merged, thanks @aksswami!