HADOOP-16202. Enhance/Stabilize openFile()

Roll-up of the previous PR #2046
Change-Id: Ib0aec173afcd8aae33f52da3f99ac813bd38c32f

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
25m 11s
Docker failed to build yetus/hadoop:cce5a6f6094.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2168/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
28m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 52s
trunk passed

+1 :green_heart:
compile
20m 19s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
17m 32s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
2m 57s
trunk passed

+1 :green_heart:
mvnsite
2m 19s
trunk passed

+1 :green_heart:
shadedclient
19m 49s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 41s
hadoop-common in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 41s
hadoop-aws in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
1m 37s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 11s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 21s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 26s
the patch passed

+1 :green_heart:
compile
19m 43s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
19m 43s
the patch passed

+1 :green_heart:
compile
17m 23s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
17m 23s
the patch passed

-0 :warning:
checkstyle
2m 40s
root: The patch generated 6 new + 152 unchanged - 0 fixed = 158 total (was 152)

+1 :green_heart:
mvnsite
2m 19s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m  4s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 44s
hadoop-common in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 37s
hadoop-aws in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 40s
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 generated 6 new + 4 unchanged - 0 fixed = 10 total (was 4)

-1 :x:
findbugs
0m 36s
hadoop-aws in the patch failed.

_ Other Tests _

-1 :x:
unit
10m 22s
hadoop-common in the patch passed.

-1 :x:
unit
0m 37s
hadoop-aws in the patch failed.

+1 :green_heart:
asflicense
0m 52s
The patch does not generate ASF License warnings.

197m 58s

Reason
Tests

Failed junit tests
hadoop.fs.contract.localfs.TestLocalFSContractOpen

hadoop.fs.contract.rawlocal.TestRawlocalContractOpen

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 54af983b3294 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 05b3337a460

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/artifact/out/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/testReport/

Max. process+thread count
1626 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 16s
Maven dependency ordering for branch

-1 :x:
mvninstall
25m 52s
root in trunk failed.

-1 :x:
compile
12m 57s
root in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
compile
18m 59s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-0 :warning:
checkstyle
2m 42s
The patch fails to run checkstyle in root

+1 :green_heart:
mvnsite
2m 21s
trunk passed

+1 :green_heart:
shadedclient
19m 30s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 15s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 11s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 14s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 24s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 23s
the patch passed

+1 :green_heart:
compile
18m 42s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
javac
18m 42s
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 210 new + 1844 unchanged - 0 fixed = 2054 total (was 1844)

+1 :green_heart:
compile
16m 50s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
16m 50s
the patch passed

-0 :warning:
checkstyle
2m 27s
The patch fails to run checkstyle in root

+1 :green_heart:
mvnsite
2m 19s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  9s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 13s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 13s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
3m 42s
the patch passed

_ Other Tests _

-1 :x:
unit
9m 33s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 39s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 56s
The patch does not generate ASF License warnings.

168m 46s

Reason
Tests

Failed junit tests
hadoop.fs.contract.rawlocal.TestRawlocalContractOpen

hadoop.fs.contract.localfs.TestLocalFSContractOpen

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux<PHONE_NUMBER>ac 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c7e71a6c0be

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

mvninstall
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/7/artifact/out/branch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/7/artifact/out/branch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/7/artifact/out/buildtool-branch-checkstyle-root.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/7/artifact/out/diff-compile-javac-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/7/artifact/out/buildtool-patch-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/7/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/7/testReport/

Max. process+thread count
2313 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/7/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 19s
Maven dependency ordering for branch

-1 :x:
mvninstall
26m 20s
root in trunk failed.

-1 :x:
compile
13m 47s
root in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
compile
17m 53s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-0 :warning:
checkstyle
2m 51s
The patch fails to run checkstyle in root

+1 :green_heart:
mvnsite
2m 28s
trunk passed

+1 :green_heart:
shadedclient
23m 25s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 13s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 18s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 23s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m  4s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 39s
the patch passed

+1 :green_heart:
compile
24m 33s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
javac
24m 33s
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 210 new + 1844 unchanged - 0 fixed = 2054 total (was 1844)

+1 :green_heart:
compile
21m 43s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
21m 43s
the patch passed

-0 :warning:
checkstyle
3m 28s
The patch fails to run checkstyle in root

+1 :green_heart:
mvnsite
2m 27s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
18m  1s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  1s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 17s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
4m 14s
the patch passed

_ Other Tests _

-1 :x:
unit
10m 44s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 28s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 46s
The patch does not generate ASF License warnings.

190m 55s

Reason
Tests

Failed junit tests
hadoop.fs.contract.localfs.TestLocalFSContractOpen

hadoop.fs.contract.rawlocal.TestRawlocalContractOpen

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux e35029546da3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c7e71a6c0be

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

mvninstall
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/6/artifact/out/branch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/6/artifact/out/branch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/6/artifact/out/buildtool-branch-checkstyle-root.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/6/artifact/out/diff-compile-javac-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/6/artifact/out/buildtool-patch-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/6/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/6/testReport/

Max. process+thread count
2424 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/6/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m  1s
trunk passed

+1 :green_heart:
compile
19m 43s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
16m 54s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 43s
trunk passed

+1 :green_heart:
mvnsite
2m 23s
trunk passed

+1 :green_heart:
shadedclient
19m 57s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 16s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 18s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 16s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 31s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 26s
the patch passed

+1 :green_heart:
compile
18m 54s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
18m 54s
the patch passed

+1 :green_heart:
compile
16m 55s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
16m 55s
the patch passed

-0 :warning:
checkstyle
2m 43s
root: The patch generated 16 new + 153 unchanged - 0 fixed = 169 total (was 153)

+1 :green_heart:
mvnsite
2m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 10s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 13s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 22s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
3m 47s
the patch passed

_ Other Tests _

-1 :x:
unit
9m 21s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 42s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 56s
The patch does not generate ASF License warnings.

176m 36s

Reason
Tests

Failed junit tests
hadoop.fs.contract.rawlocal.TestRawlocalContractOpen

hadoop.fs.contract.localfs.TestLocalFSContractOpen

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 7c35c49c94b5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b3660d01470

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/8/artifact/out/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/8/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/8/testReport/

Max. process+thread count
2429 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/8/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
28m 48s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 15s
trunk passed

+1 :green_heart:
compile
19m 43s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
16m 52s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 48s
trunk passed

+1 :green_heart:
mvnsite
2m 23s
trunk passed

+1 :green_heart:
shadedclient
20m 13s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  4s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m  5s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 10s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 26s
trunk passed

-0 :warning:
patch
1m 29s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 27s
the patch passed

+1 :green_heart:
compile
24m 18s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
24m 18s
the patch passed

+1 :green_heart:
compile
22m  7s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
22m  7s
the patch passed

-0 :warning:
checkstyle
3m 33s
root: The patch generated 14 new + 158 unchanged - 0 fixed = 172 total (was 158)

+1 :green_heart:
mvnsite
2m 31s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
19m 24s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  5s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 27s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
4m 34s
the patch passed

_ Other Tests _

-1 :x:
unit
10m 39s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 53s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 55s
The patch does not generate ASF License warnings.

223m 21s

Reason
Tests

Failed junit tests
hadoop.fs.contract.rawlocal.TestRawlocalContractOpen

hadoop.fs.contract.localfs.TestLocalFSContractOpen

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux cfc95ba3564f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5346cc32637

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/9/artifact/out/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/9/artifact/out/whitespace-eol.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/9/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/9/testReport/

Max. process+thread count
1716 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/9/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/OpenFileOptions.java:31:@InterfaceAudience.Public:1: Utility classes should not have a public or default constructor. [HideUtilityClassConstructor]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/OpenFileParameters.java:22:import java.util.stream.Collectors;:8: Unused import - java.util.stream.Collectors. [UnusedImports]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/OpenFileParameters.java:23:import java.util.stream.Stream;:8: Unused import - java.util.stream.Stream. [UnusedImports]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/S3AOpenFileOperation.java:52:  public class S3AOpenFileOperation extends AbstractStoreOperation {: 'class def modifier' has incorrect indentation level 2, expected level should be 0. [Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/S3AOpenFileOperation.java:106:    /** SQL string if this is a SQL select file*/: First sentence should end with a period. [JavadocStyle]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/S3AOpenFileOperation.java:280:  /**: First sentence should end with a period. [JavadocStyle]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/TestOpenFileHelper.java:215:  /**: First sentence should end with a period. [JavadocStyle]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3AOpenCost.java:169:          byte[] out = new byte[(int) longLen];: 'block' child has incorrect indentation level 10, expected level should be 6. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3AOpenCost.java:170:          intercept(EOFException.class,: 'block' child has incorrect indentation level 10, expected level should be 6. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3AOpenCost.java:172:          in3.seek(longLen - 1);: 'block' child has incorrect indentation level 10, expected level should be 6. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3AOpenCost.java:173:          assertEquals("read past real EOF on " + in3,: 'block' child has incorrect indentation level 10, expected level should be 6. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3AOpenCost.java:175:          in3.close();: 'block' child has incorrect indentation level 10, expected level should be 6. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3AOpenCost.java:176:          return null;: 'block' child has incorrect indentation level 10, expected level should be 6. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3AOpenCost.java:177:        },: 'block rcurly' has incorrect indentation level 8, expected level should be 4. [Indentation]

tests
[ERROR] Errors:
[ERROR]   TestLocalFSContractOpen>AbstractContractOpenTest.testOpenFileNullStatus:358 ? IllegalArgument
[ERROR]   TestRawlocalContractOpen>AbstractContractOpenTest.testOpenFileNullStatus:358 ? IllegalArgument
[INFO]

plan to switch copyToLocal & distcp to openFile with sequential read policy. This ensures that on clusters where the default policy has been set to random will not see performance collapse here. It will be left to the ORC/Parquet projects to consider when/how to move to this API too.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 15s
trunk passed

+1 :green_heart:
compile
19m 25s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
17m 16s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 48s
trunk passed

+1 :green_heart:
mvnsite
4m  0s
trunk passed

+1 :green_heart:
shadedclient
21m 34s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 46s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
4m  0s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m  0s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
6m 22s
trunk passed

-0 :warning:
patch
2m 22s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
18m 57s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
18m 57s
the patch passed

+1 :green_heart:
compile
16m 52s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
16m 52s
the patch passed

-0 :warning:
checkstyle
2m 51s
root: The patch generated 7 new + 441 unchanged - 1 fixed = 448 total (was 442)

+1 :green_heart:
mvnsite
4m  6s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
14m 16s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 44s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
3m 59s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
6m 54s
the patch passed

_ Other Tests _

-1 :x:
unit
9m 22s
hadoop-common in the patch passed.

+1 :green_heart:
unit
4m 17s
hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
12m  1s
hadoop-distcp in the patch passed.

+1 :green_heart:
unit
1m 43s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 55s
The patch does not generate ASF License warnings.

209m 19s

Reason
Tests

Failed junit tests
hadoop.fs.contract.rawlocal.TestRawlocalContractOpen

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux e54c99411ae6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fc2435cb5cf

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/10/artifact/out/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/10/artifact/out/whitespace-eol.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/10/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/10/testReport/

Max. process+thread count
2482 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-tools/hadoop-distcp hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/10/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

I'm wondering if on distcp I should leave off the file length.
why so: if someone updates a file between distcp being scheduled and it being executed, the length will be different. I know people aren't "meant" to do that, but inevitably people already do.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
28m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
11m 41s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 16s

trunk passed

+1 :green_heart:
compile
19m 53s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
17m 20s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 49s

trunk passed

+1 :green_heart:
mvnsite
4m 10s

trunk passed

+1 :green_heart:
shadedclient
22m 13s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 47s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
4m  0s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 15s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
6m 24s

trunk passed

-0 :warning:
patch
1m 37s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 36s

the patch passed

+1 :green_heart:
compile
19m 20s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
19m 20s

the patch passed

+1 :green_heart:
compile
17m 17s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
17m 17s

the patch passed

-0 :warning:
checkstyle
2m 46s
/diff-checkstyle-root.txt
root: The patch generated 5 new + 441 unchanged - 1 fixed = 446 total (was 442)

+1 :green_heart:
mvnsite
4m  9s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
14m 59s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 45s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
javadoc
0m 45s
/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 1 new + 88 unchanged - 0 fixed = 89 total (was 88)

+1 :green_heart:
findbugs
6m 52s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 41s

hadoop-common in the patch passed.

+1 :green_heart:
unit
4m 22s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
13m 36s

hadoop-distcp in the patch passed.

+1 :green_heart:
unit
1m 44s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

244m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux ca7bedf9f6f9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7f8ef76c483

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/12/testReport/

Max. process+thread count
1593 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-tools/hadoop-distcp hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/12/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.1.3

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

javadoc
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2168/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/S3AOpenFileOperation.java:48: warning: empty <p> tag

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 59s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 54s

trunk passed

+1 :green_heart:
compile
20m  6s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 21s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
2m 58s

trunk passed

+1 :green_heart:
mvnsite
5m  2s

trunk passed

+1 :green_heart:
shadedclient
23m 39s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
3m 55s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
4m 43s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m 17s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
7m 35s

trunk passed

-0 :warning:
patch
1m 39s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  6s

the patch passed

+1 :green_heart:
compile
19m 20s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m 20s

the patch passed

+1 :green_heart:
compile
17m 17s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m 17s

the patch passed

-0 :warning:
checkstyle
3m 27s
/diff-checkstyle-root.txt
root: The patch generated 10 new + 762 unchanged - 1 fixed = 772 total (was 763)

+1 :green_heart:
mvnsite
5m  1s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 18s

patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
1m  2s
/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 generated 7 new + 92 unchanged - 7 fixed = 99 total (was 99)

-1 :x:
javadoc
0m 44s
/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 2 new + 88 unchanged - 0 fixed = 90 total (was 88)

+1 :green_heart:
findbugs
8m 16s

the patch passed

_ Other Tests _

-1 :x:
unit
9m 36s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
4m 19s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
8m 37s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
12m  1s

hadoop-distcp in the patch passed.

+1 :green_heart:
unit
1m 45s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

237m 34s

Reason
Tests

Failed junit tests
hadoop.util.TestJsonSerialization

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux ed7e019c2cc2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a7b923c80c6

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/14/testReport/

Max. process+thread count
1443 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-distcp hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/14/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

legit failure of hadoop.util.TestJsonSerialization.
As well as fixing, maybe for  the serializer, map MismatchedInputException to EOFException for better handling up the stack
Error Message
`file:/tmp/Keyval3692109174763841309.json': Failed to read JSON file com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input
 at [Source: (org.apache.hadoop.fs.ChecksumFileSystem$FSDataBoundedInputStream); line: 1, column: 0]: No content to map due to end-of-input
 at [Source: (org.apache.hadoop.fs.ChecksumFileSystem$FSDataBoundedInputStream); line: 1, column: 0]
Stacktrace
org.apache.hadoop.fs.PathIOException:
`file:/tmp/Keyval3692109174763841309.json': Failed to read JSON file com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input
 at [Source: (org.apache.hadoop.fs.ChecksumFileSystem$FSDataBoundedInputStream); line: 1, column: 0]: No content to map due to end-of-input
 at [Source: (org.apache.hadoop.fs.ChecksumFileSystem$FSDataBoundedInputStream); line: 1, column: 0]
	at org.apache.hadoop.util.JsonSerialization.load(JsonSerialization.java:275)
	at org.apache.hadoop.util.JsonSerialization.load(JsonSerialization.java:246)
	at org.apache.hadoop.util.TestJsonSerialization.lambda$testFileSystemEmptyPath$2(TestJsonSerialization.java:180)
	at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:498)
	at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:384)
	at org.apache.hadoop.util.TestJsonSerialization.testFileSystemEmptyPath(TestJsonSerialization.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)
Caused by: com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input
 at [Source: (org.apache.hadoop.fs.ChecksumFileSystem$FSDataBoundedInputStream); line: 1, column: 0]
	at com.fasterxml.jackson.databind.exc.MismatchedInputException.from(MismatchedInputException.java:59)
	at com.fasterxml.jackson.databind.ObjectMapper._initForReading(ObjectMapper.java:4360)
	at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4205)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3251)
	at org.apache.hadoop.util.JsonSerialization.fromJsonStream(JsonSerialization.java:163)
	at org.apache.hadoop.util.JsonSerialization.load(JsonSerialization.java:273)
	... 18 more

looking @ jackson code, MismatchedInputException covers a lot of cases -and I don't want to do anything "clever" about choosing specific IOEs based on the exception text.
Modifying test to look for a PathIOException rather than EOFException

latest patch follows on from HADOOP-17318 and passes in status when opening .pending and .pendingset files.
for the magic committer this saves 1 HEAD per file in task commit; 1 HEAD per task in job commit
For max speedup/scale we'd need to also adopt incremental listing. Later.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 53s

trunk passed

+1 :green_heart:
compile
19m 59s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 42s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
2m 48s

trunk passed

+1 :green_heart:
mvnsite
4m 35s

trunk passed

+1 :green_heart:
shadedclient
24m 36s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
3m 37s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
4m 18s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m 18s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
7m 35s

trunk passed

-0 :warning:
patch
1m 39s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 10s

the patch passed

+1 :green_heart:
compile
19m 10s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m 10s

the patch passed

+1 :green_heart:
compile
17m 46s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m 46s

the patch passed

-0 :warning:
checkstyle
3m  3s
/diff-checkstyle-root.txt
root: The patch generated 10 new + 765 unchanged - 1 fixed = 775 total (was 766)

+1 :green_heart:
mvnsite
4m 47s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 26s

patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
1m  5s
/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 generated 7 new + 92 unchanged - 7 fixed = 99 total (was 99)

-1 :x:
javadoc
0m 42s
/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 2 new + 88 unchanged - 0 fixed = 90 total (was 88)

+1 :green_heart:
findbugs
8m 16s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 44s

hadoop-common in the patch passed.

+1 :green_heart:
unit
4m 13s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
8m 36s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
11m 48s

hadoop-distcp in the patch passed.

+1 :green_heart:
unit
1m 47s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

236m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux df3d2662525f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5fee95076b5

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/15/testReport/

Max. process+thread count
1428 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-distcp hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/15/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 30s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 56s

trunk passed

+1 :green_heart:
compile
22m 17s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
19m 39s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
3m  2s

trunk passed

+1 :green_heart:
mvnsite
4m 29s

trunk passed

+1 :green_heart:
shadedclient
25m 35s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
3m 16s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
4m  5s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m 12s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
7m 23s

trunk passed

-0 :warning:
patch
1m 33s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 16s

the patch passed

+1 :green_heart:
compile
21m 42s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
21m 42s

the patch passed

+1 :green_heart:
compile
18m 29s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
18m 29s

the patch passed

+1 :green_heart:
checkstyle
3m  4s

root: The patch generated 0 new + 763 unchanged - 1 fixed = 763 total (was 764)

+1 :green_heart:
mvnsite
4m 30s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
17m 31s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
3m 27s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

-1 :x:
javadoc
0m 38s
/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 2 new + 88 unchanged - 0 fixed = 90 total (was 88)

+1 :green_heart:
findbugs
8m 29s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
10m 35s

hadoop-common in the patch passed.

+1 :green_heart:
unit
4m  5s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
8m 30s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
13m 16s

hadoop-distcp in the patch passed.

+1 :green_heart:
unit
1m 44s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

250m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/16/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 905a3ef3695c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5fee95076b5

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/16/testReport/

Max. process+thread count
1345 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-distcp hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/16/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 47s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m  6s

trunk passed

+1 :green_heart:
compile
19m 51s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m  3s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
2m 57s

trunk passed

+1 :green_heart:
mvnsite
4m 59s

trunk passed

+1 :green_heart:
shadedclient
23m 36s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
3m 54s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
4m 39s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m 16s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
7m 34s

trunk passed

-0 :warning:
patch
1m 39s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 10s

the patch passed

+1 :green_heart:
compile
19m  9s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m  9s

the patch passed

+1 :green_heart:
compile
17m  3s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m  3s

the patch passed

+1 :green_heart:
checkstyle
2m 57s

root: The patch generated 0 new + 763 unchanged - 1 fixed = 763 total (was 764)

+1 :green_heart:
mvnsite
5m  0s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 21s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
3m 54s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

-1 :x:
javadoc
0m 43s
/diff-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 2 new + 88 unchanged - 0 fixed = 90 total (was 88)

+1 :green_heart:
findbugs
8m 13s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 37s

hadoop-common in the patch passed.

+1 :green_heart:
unit
4m 17s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
8m 34s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
11m 53s

hadoop-distcp in the patch passed.

+1 :green_heart:
unit
1m 36s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

234m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/17/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 4f32b747f3fe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fa773a83265

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/17/testReport/

Max. process+thread count
2735 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-distcp hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/17/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
26m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 54s

trunk passed

+1 :green_heart:
compile
19m 55s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 13s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
3m  3s

trunk passed

+1 :green_heart:
mvnsite
6m 40s

trunk passed

+1 :green_heart:
shadedclient
25m 32s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
5m 11s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
6m  0s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m 18s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
9m 54s

trunk passed

-0 :warning:
patch
1m 41s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  9s

the patch passed

+1 :green_heart:
compile
19m  6s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m  6s

the patch passed

+1 :green_heart:
compile
17m  7s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m  7s

the patch passed

-0 :warning:
checkstyle
2m 56s
/diff-checkstyle-root.txt
root: The patch generated 3 new + 796 unchanged - 1 fixed = 799 total (was 797)

+1 :green_heart:
mvnsite
6m 38s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 27s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
5m  8s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
6m  0s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
10m 51s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 35s

hadoop-common in the patch passed.

+1 :green_heart:
unit
4m 21s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
7m  3s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
8m 28s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
unit
0m 56s

hadoop-mapreduce-examples in the patch passed.

+1 :green_heart:
unit
13m 38s

hadoop-distcp in the patch passed.

+1 :green_heart:
unit
1m 48s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

285m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/18/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2168

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux c12e9b5d2665 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f94e927bfbe

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/18/testReport/

Max. process+thread count
1570 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2168/18/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The latest patch rounds things off. This thing is ready to go in.

We now have the option to specify the start and end of splits; the input formats in the MR client do this.
everywhere in the code where we explicitly download sequential datasets request sequential IO. (actually, I've just realised hadoop fs -head <path> should request random IO as well as declare split lengths...we don't want a full GET).

its important that FS implementations don't rely on split length to set max file len, because splits are allowed to overrun to ensure a whole record/block is read. Apps which pass split info down to worker processes (hive &c) need to pass in file size too if they want to save the HEAD request. It could still be used by the input streams if they can think of a way

For sequential IO: end of content length = min(split-end, file-length) for that initial request,
2 For random IO, assume it's the initial EOF.

because openFile() declares FNFEs can be delayed until reads, we could also see if we could do an async HEAD request while processing that first GET/HEAD, so have the final file length without blocking. That would make streams more complex —at least now we have the option.

Hindsight is 20-20, but it might still be worthwhile to break this up into multiple PRs: 1) the hadoop-common changes with the default implementation, 2) the consumers (avro, distcp, mapreduce, yarn, etc), and 3) updates to the filesystem implementations (AWS, etc).  That should help the reviewers to focus.

@ThomasMarquardt -thanks for the feedback; will respond/update the PR
I've been doing it as one PR as it lets me

do interface and impl together, plus contract tests
rebase on a regular basis on a patch that's had little attention from reviewers
test it downstream in a PoC fork of parquet just to see what works/doesn't.

FWIW passing in the file status/length makes a big difference in code which goes from list dir -> opening every file in it. Other than that, changing the seek policy is the big one.
Feel free to not review those s3a bits, except to look and see if there are things you'd want/want to avoid. open() has got a lot more complicated than it used to be.

going to close this PR and open a new one as I've rebased to trunk; will merge everything back into a single patch

going to close this PR and open a new one as I've rebased to trunk; will merge everything back into a single patch


fix ECDSARegistry test script

Summary

This pull request addresses a specific issue found during the review of the ECDSARegistry test script. It was discovered that there was a duplicated test, and improvements were made to enhance the readability of the test script.
Related Issue: # (issue number)
Change Type

[ ] Bug Fix
[x] Refactor
[ ] New Feature
[ ] Breaking Change
[ ] Documentation Update
[ ] Performance Improvement
[ ] Other

Checklist

[x] My code follows this project's style guidelines
[x] I've reviewed my own code
[ ] I've added comments for any hard-to-understand areas
[ ] I've updated the documentation if necessary
[x] My changes generate no new warnings
[ ] I've added tests that prove my fix is effective or my feature works
[x] All unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published

Thanks for the sample of the PR info layout!
How should the Checklist be used? Is it the PR author who checks them?

@zakrad Would it be possible to merge the changes into develop?

@zakrad Would it be possible to merge the changes into develop?
Thanks, Changed the base branch


API-METADATA-NOT-FOUND

ApiMeta data:
Request PApiMetaData=apiId: 52 apiInfo: "Servlet Process" line: -1 type: 100
Span  data:
version: 1 transactionId { agentStartTime:<PHONE_NUMBER>815 sequence:
4574 } spanId: -6752218818390780500 parentSpanId: -1 startTime:<PHONE_NUMBER>545 elapsed: 27 apiId: 52 serviceType: 1010 acceptEvent { rpc: "/actuator/prometheus" endPoint: "<IP_ADDRESS>" remoteAddr: "<IP_ADDRESS>" } annotation { key: 46 value { intValue: 200 } } spanEvent { depth: 1 endElapsed: 27 serviceType: 1011 apiId: 51 } spanEvent { sequence: 1 depth: 2 startElapsed: 1 endElapsed: 26 serviceType: 5051 apiId: 20 } applicationServiceType: 1210
Pinpoinot Ui's Method column shows API-METADATA-NOT-FOUND

hi @jefry86
If you delete Hbase data after requesting ApiMetadata, you can experience a  situation mentioned.
If not, please post the log if you can see an error message while putting the ApiMetadata in the collector.
thanks :)

To simplify development, use API-TAG Annotation
https://github.com/naver/pinpoint/blob/master/commons/src/main/java/com/navercorp/pinpoint/common/trace/AnnotationKey.java#L167

Just assign a string to the annotation.

//    @Deprecated  // moved apiId to spanEvent and span. dump by int
//    API_DID(10, "API-DID"),
//    @Deprecated  // you should remove static API code. Use only API-DID. dump by int
//    API_ID(11, "API-ID"),
    // Dump api by string.
    AnnotationKey API = AnnotationKeyFactory.of(12, "API");
    AnnotationKey API_METADATA = AnnotationKeyFactory.of(13, "API-METADATA");
    AnnotationKey RETURN_DATA = AnnotationKeyFactory.of(14, "RETURN_DATA", VIEW_IN_RECORD_SET);
    AnnotationKey API_TAG = AnnotationKeyFactory.of(10015, "API-TAG");

@koo-taejin @emeroad  thinks,I have found the solution to the problem, the startTime value of metadata is different

@jefry86 @koo-taejin @emeroad  - I am facing the same issue API-METADATA-NOT-FOUND and It would be really if could you elaborate on how to make startTime value of metadata same, likewise what was the fixed you did which helped solving this.
Thanks for your extended help @jefry86 @koo-taejin @emeroad

@koo-taejin @jefry86 - can someone pls show some direction on how to fix the api meta data not found issue... it would be really great if someone could share some insights to resolve it... @emeroad

@jefry86 - It would be really great and helpful if you could shed some lights on how did you solve the issue " the startTime value of metadata is different",  As I am encountering the similar issue which blocks my critical deployments. https://github.com/naver/pinpoint/issues/6496
Appreciate your time and extended support here. @koo-taejin @emeroad

@koo-taejin @jaehong-kim @emeroad @Xylus @jefry86 - Can someone please shed some light or definite pointers on how to solve API-METADATA-NOT-FOUND issue which is almost deteriorating my usage of pinpoint in my cloud system and it seems like @jefry86  mentioned very clearly that "the startTime value of metadata is different"
It would be really great and kind if someone could help me address this.


Icon Conflict on 'All-Pages' Page

Subject: Issue Report: Icon Conflict on 'All-Pages' Page
I hope this message finds you well.
I am writing to report an issue I've encountered with your plugin while using it in Logseq. On the 'all-pages' page, I've noticed that the icons from your plugin are conflicting with Logseq's native icons, resulting in duplicate icons being displayed. This could potentially affect the user experience.
Here are my system details:
Logseq Version: v0.10.10
Operating System: macOS ARM
For your reference, I have attached a screenshot (image.png) that illustrates the issue with the icons.
I would appreciate it if you could look into this matter. If you require any additional information, please let me know.
Thank you for your attention to this issue.

            <input type="checkbox" id="label-840" class="form-checkbox">

            

                    
                    test-page-name-001

        3

        2024-10-10 21:29

        2024-10-10 21:29

Upon reviewing the HTML code, it appears that the conflict between the following two segments is causing the page to display two icons:




Implement authentication long polling

AuthenticationServer has a setting for revoking authentication after a period of inactivity. To handle that on the client side, metadata clients, after a period of inactivity, will retry after getting Unauthenticated code. However, due to nature of streaming, data clients can not retry after getting the error because they might have pipelined more data before seeing the error. And since this revocation will not change the connection state, they used to continue getting Unauthenticated. See https://github.com/Alluxio/alluxio/issues/9089 for an instance of this problem.
This PR introduces long polling to authentication handshake. Client and server will not complete streams used for authentication and instead will use it for notifying end of an authentication session. With this change, revocation on server will be propagated to client channel via health status, causing a client recreation for later use of the same channel. Also client closing the channel will notify server and it'll clean its state of the recently closed channel.
Periodic cleanup has not been disabled in order to not prolong a duration for a channel to remain authenticated.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3881/
Test PASSed.

@gpang Updated PR after your feedback. PTAL.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3886/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3887/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3908/
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3950/
Test FAILed.

Jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3960/
Test FAILed.

Jenkins, test this please

@ggezer I think this looks good, but the tests keep failing

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3963/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3968/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3978/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3979/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3994/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3999/
Test PASSed.

alluxio-bot, merge this please

@gpang Can you help cherry-pick this PR to 2.0 branch?

alluxio-bot, cherry-pick this to branch-2.0 please.


Back swiping then dropping the gesture back where it started breaks

Seems like https://github.com/flutter/flutter/pull/30422 broke this again

Hello!
I climbed into the source and found the following, I hope he will help you. As it was written here
https://github.com/flutter/flutter/issues/29596#issuecomment-485114430, this happens after a certain number of uses, but this is not what you see in the GIF, this is because if you finish scrolling on your own, the screen cannot be rejected by scrolling. I already had this error earlier and your team has already solved it https://github.com/flutter/flutter/issues/27774 , https://github.com/flutter/flutter/issues/27333

Hello!
Came because I hit: https://github.com/flutter/flutter/issues/29596
Switched to master and it works.
About to release my app and a bit worried by this one.
Do you have any more information about the issue?
I can't reproduce it on a physical iPhone 6S.
but...
I can reproduce it on a iPhone X emulator.
@1AlexFix1 Any tip for reproducing it on a physical device?
@xster Any time frame for a fix?
Thanks!

Hello!
Came here because I hit: #29596
Switched to master and it works.
About to release my app and a bit worried by this one.
Do you have any more information about the issue?
I can't reproduce it on a physical iPhone 6S.
but...
I can reproduce it on a iPhone X emulator.
@1AlexFix1 Any tip for reproducing it on a physical device?
@xster Any time frame for a fix?
Thanks!

i was test on simulator XS, no real device

@1AlexFix1 Ahhh, sorry, false alarm/hopes...
I now understand the technique.
Start a drag and then fully drag back to original position.
Now getting the error on the physical device too... (bad words here):-(
@1AlexFix1 Thank you!
Have to go with a workaround then...

Embarrassingly the fix is one line. I'm adding tests at the moment.

Thanks for the fast solution. Again, any clue when it’s in master 😉?

Unfortunately the PR was reverted because it made a test flaky. Will try again.


Izhang index list

This PR is trying to fix the inefficient list operation with deployable.
Before when we only want to find the generate deployable, we will have to list all the deployable and check their annotations for it.
To address this issue, the idea is adding some sort field to the deployable resource when the controller manager is starting/building up the cache. Later on, when we are listing, we use this field to narrow down the return results.
FYI:
Step 2 and the Setup Section give us example of the above idea.
https://book.kubebuilder.io/cronjob-tutorial/controller-implementation.html
The above part is mainly at the controller/deployable.go .
Since we are leveraging the manager's cache, we need to adopt some test cases.
In addition, I also made some changes to function and variable names to make them a bit more readable.


What does the parameter 'reference' mean in the lightgbm dataset API?

I used to think that the parameter means the bins cutoffs created in the training data would be used in the validation data if while creating the validation dataset I specify the training dataset as the value to the reference argument. However, I am not able to see any difference with or without passing anything to the reference parameter. Following is the code I used to study the parameter:
train = lightgbm.Dataset(xtrain,ytrain.target_variable,feature_name=feature_name,params={'verbose':-1}).construct()

val_ref = lightgbm.Dataset(xval,yval.target_variable,reference=train,free_raw_data=False,\
                           feature_name=feature_name,params={'verbose':-1}).construct()
val_noref = lightgbm.Dataset(xval,yval.target_variable,feature_name=feature_name,\
                             free_raw_data=False,params={'verbose':-1}).construct()
model1 = lightgbm.train(params={'metric':['auc']},train_set=train,valid_sets=[val_noref],\
                        early_stopping_rounds=50,num_boost_round=10000)
model2 = lightgbm.train(params={'metric':['auc']},train_set=train,valid_sets=[val_ref],\
                        early_stopping_rounds=50,num_boost_round=10000)
model1.predict(xtest)
output: array([0.01691352, 0.21934348, 0.12057389, ..., 0.40199047, 0.27511304,
       0.41782435])
model2.predict(xtest)
output: array([0.01691352, 0.21934348, 0.12057389, ..., 0.40199047, 0.27511304,
       0.41782435])
np.allclose(model1.predict(xtest),model2.predict(xtest))
output: True

The train, test and validation datasets are 40k, 30k and 10k records respectively. If the reference parameter was used to alter the binning I think the two models would have trained slightly differently and test results would have been somewhat different but, as you can see, they are exactly the same.
So, Can you please explain what the 'reference' parameter does and if possible give an example that showcases the difference between using it and not using it.
Thank you for your time!

Reference is to align the bin mapper (feature float values to bucketed int values) to the train set.
bin mapper will be calculated based on feature values, if without reference.
In your case, the val_noref may have a slightly different bin mapper as the train set, but almost the same. If the distribution of val and train is very different, the bin mapper could be very different.
And as you only use val for early stopping, and use the exact same training set, the final model is likely to be the same.
BTW, I don't remember, But LightGBM may check the bin mapper of train set and val set. If they are different, LightGBM may re-align the valset to trainset.
cc @StrikerRUS  to confirm this detail.

@guolinke

BTW, I don't remember, But LightGBM may check the bin mapper of train set and val set. If they are different, LightGBM may re-align the valset to trainset.

Looks like LightGBM produces an error in a such case:
https://github.com/microsoft/LightGBM/blob/b78175b7468c727d1bd8d45bf675557598272c8b/src/boosting/gbdt.cpp#L140-L144

So, to summarise

If the distributions of val set and train set are so similar that they result in same bin mappers then it does not matter if or not you reference the train set while creating the val set
If the distributions of val set and train set are different (there's covariate shift) and the bin mappers thus produced are different then in that case:

If the val set references the train set then the bin mapper of train set would be used

If the val set does not reference the train set then this raises an error as pointed out by @StrikerRUS

Have I got this correct?

@nitinmnsn I think the conclusion is basically correct. On the other hand, if the Dataset is not explicitly constructed (construct method is not called), when passed to the train method as valid data, the method will set reference of the valid data to the training data automatically, according to
https://github.com/microsoft/LightGBM/blob/29857c8adb3c879268cddc23037e0651c2ec4df6/python-package/lightgbm/engine.py#L225


Bad XML format for packaging permissions when downloading profiles in new versions

Describe the bug
In new versions, for example 3.3.4, when retrieving profiles from a sandbox some packaging userPermissions are downloaded with bad format:
<userPermissions>
        <enabled/>
        <name>CreatePackaging</name>
</userPermissions>

To Reproduce
Steps to reproduce the behavior:
Install v3.3.4 and retrieve a custom profile

sfdx sfpowerkit:source:profile:retrieve

Expected behavior
<userPermissions>
        <enabled>false</enabled>
        <name>CreatePackaging</name>
</userPermissions>

Desktop (please complete the following information):

OS: macOS 11.3
Node Version v16.4.0
Version of sfpowerkit v3.3.4
Salesforce Org Version Winter '22

@genoud  can you have a look into this?


Added Example (Show PokeStop timeout)

This example just shows the timeouts for PokeStops in the description of the stop

Nice idea and realization -  thank you for the contribution & cheers!


The example code doesn't work for me

error case 1
When I open the project on AndroidStudio. Gradle has occurred a problem. like this below the image.
https://github.com/corymsmith/react-native-fabric/issues/200
Suggestion

before

// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
    repositories {
        jcenter()
        google()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.1.2'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

(...)

after

// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
    repositories {
        jcenter()
        google()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.1.2'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

(...)

error case 2
I read the README.md about this project, but this example code follows a legacy version.
So, This example can't resolve the class that name 'GlobalApplication' at android.
I think you'd better maintain this example. kind regards.

Please put the jcenter at the very bottom. Recent Android version has issue with this one so you must put that to very bottom currently.


Upgrade net.bytebuddy:byte-buddy 1.12.23 -> 1.13.0

This PR contains the following updates:

Package
Type
Update
Change

net.bytebuddy:byte-buddy
compile
minor
1.12.23 -> 1.13.0

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Byte Buddy 1.12.23 -> 1.13.0

See https://github.com/raphw/byte-buddy/compare/byte-buddy-1.12.23...byte-buddy-1.13.0

Hmmm, I think we need to tweak some things in the suggested commit message bot. Anyway, if there will not be an actual release I can open a GH issue maybe. But let's give it some time first :).


Visualize memory

Using either script or some other nice way (like struct descriptor also should work)

Moved to https://prodbg.phoreplay.com/T53

Dupe of #140


listener: allow TCP and UDP on the same port

Fixes https://github.com/envoyproxy/envoy/issues/15562
Risk Level: Low
Testing: Modified unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

cc @ggreenway @lambdai

I think we may be better off adding ipproto (tcp or udp) to the address type, so that equality comparison works as expected. I think most people would intuitively expect that <IP_ADDRESS>:80:TCP != <IP_ADDRESS>:80:UDP. The OS considers them completely separate addresses, so probably our abstraction should also.

I think we may be better off adding ipproto (tcp or udp) to the address type, so that equality comparison works as expected. I think most people would intuitively expect that <IP_ADDRESS>:80:TCP != <IP_ADDRESS>:80:UDP. The OS considers them completely separate addresses, so probably our abstraction should also.

OK, I can take a look at this. It will likely be a much larger change.

OK, I can take a look at this. It will likely be a much larger change.

Yes, but I think it's the right way to do it. Probably can default to TCP to have a much smaller change. UDP is used far less at this point. Could later make a mechanical change to remove the default and specify TCP in all the places it is needed, if we want that for clarity.

@ggreenway I looked at this briefly and I'm not sure that I agree that making the Address interface include TCP/UDP is the right thing to do. It's used in various places that don't care about that at all (DNS, IP tagging, etc.) and I think it's not a great abstraction.
How about this: a wrapper AddressAndProto which contains both the underlying address and the proto, and then define equality on that correctly. Then, we can use that inside the listener manager code and fix effected call sites. I think this will be more targeted and clear. WDYT?

@ggreenway I looked at this briefly and I'm not sure that I agree that making the Address interface include TCP/UDP is the right thing to do. It's used in various places that don't care about that at all (DNS, IP tagging, etc.) and I think it's not a great abstraction.
How about this: a wrapper AddressAndProto which contains both the underlying address and the proto, and then define equality on that correctly. Then, we can use that inside the listener manager code and fix effected call sites. I think this will be more targeted and clear. WDYT?

I think we currently use it for two use cases: IP address, or IP:port. Maybe those two should be separate, and TCP/UDP should only be in the IP:port version. But that may turn into an enormous change. Or maybe leave the interfaces as they are, but replace all uses of port with a tuple of port:ipproto, but keep it optional (and defaulting to TCP for now). But i feel like anytime we have a port number, we need to know whether it is tcp or udp; it's not meaningful generically.

Or maybe leave the interfaces as they are, but replace all uses of port with a tuple of port:ipproto, but keep it optional (and defaulting to TCP for now). But i feel like anytime we have a port number, we need to know whether it is tcp or udp; it's not meaningful generically.

I still think this is going to be incredibly invasive as there are string versions of address that would need to take into account proto, etc. I agree it's doable but I'm just not sure it's worth the churn. I will keep this going as a side project but given the scope of this change I will put it on hold for now as I don't have the near term time.
/wait

OK, let me open a tracking issue for a better fix.

Cross linking https://github.com/envoyproxy/envoy/issues/17429 for posterity on a better long term fix.


Brackets crashes

Running: Windows 7
No extensions installed

To go back a ways for context, I was having crash issues with Sprint 35 as a new release so I reverted to Sprint 33.  This worked for some months until today when the program started crashing for unknown reasons.  After two crashes, I upgraded to Sprint 36.  The same problem persisted.  I reloaded without extensions despite not having any installed, and still the program crashed.
It does not appear to crash on any particular event that I initiate, nor does it crash after a set amount of time open.  Each time I have to use Task Manager to kill the program as the initial Windows Close Program alert only causes it to hang.
I have the error details that MS spits out once Brackets crashes, and the details associated with the hang after I initially attempt to Close Program if either of these will help.
Thanks.

I'm getting crash if i had some open which was on NAS. if Brackets don't find this file, i freezes. dialog appears, but I cannot close the dialog.

No more crashing for me with 1.4 and possibly since 1.3.

I have 1.4. Well actually it didn't crash, it just took like 5 min to start working. So for 5 min it was in freeze. I have Win10.

If you project lives in a network drive with a large number of files, set the preference "findInFiles.nodeSearch": false . The preference will disable brackets from indexing all project files in the network drive on startup/project change.
N.B.: This would disable instant search.

@abose: thanks, will try!


Copilot Chat: Feature/tesseract ocr Issue #1440

Motivation and Context

Extends the copilot-chat-app (https://github.com/microsoft/semantic-kernel/tree/9ba5c6b044e9697393e34129acf383c19b786d60/samples/apps/copilot-chat-app) sample to allow for importing images with text using the Tesseract library (https://github.com/charlesw/tesseract/)
Issue:  [Support Tesseract / OCR in Copilot Example #1440]
Description

Added a new "Tesseract" section within appsettings.json to specify Tesseract language file (eg: eng)
Added corresponding TesseractOptions class and set up appropriate DI for use within the DocumentImportController.
Added appropriate file extension mappings for common rasterized image formats: png, jpg, tiff.
Updated frontend Web App to default to allowing these file extensions when selecting the File Import (paper clip icon) button.
Added content to README.md within the webapi to explain usage.
Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

@microsoft-github-policy-service agree

Tested and will approve after the formatting warnings have been fixed. Great work, thank you very much!
I have created a couple follow-up tasks to keep improving this amazing feature:

https://github.com/microsoft/semantic-kernel/issues/1929
https://github.com/microsoft/semantic-kernel/issues/1931
https://github.com/microsoft/semantic-kernel/issues/1932


Switch asset count to include video frames

Switch project metrics to track video frames as assets when calculating total assets

@PIC123 - Couple minor UI things to sort out

Hover popup wraps and renders weird. Need more spacing after color cube
Need margin between the 2 charts, they are very close together
Stilling seeing negative value in one of my projects (Not Visited Assets)

Lots of styles inline, but perhaps par for the course for using this component.


Save Current

``
Save Current

[x] CLI to take save command for open puzzle

[x] Puzzle to be saved into a JSON file

[x] Throw error if there is no open puzzle

[x] Ask user to open puzzle

Primary: @Joperezc

Secondary: @nrhoopes

Size: MEDIUM

Actual Size: LARGE

Actual Time: 4 HR
``

Save current is working for both new saves and overwrites through the state.save method

Finished save


PyQt4/PySide importing

I'm using qtpandas as a module in a PySide project, so I want all the calls from the compat imports to be from PySide.
I also have PyQt4 installed system-wide as well, but it is not going to be imported anywhere in the project. Unfortunately, following the default order, compat tries to import PyQt4 first, it finds it, so classes like QtGui are overwritten by the ones from PyQt4. This makes trouble when later I create objects that are, for instance, a subclass of QtGui.QWidget et similia.
The easy patch for my case is to switch the try cases, but one is simply re-phrasing the problem in this way...
There should be a way to look if one of the modules is already imported, like is done in pyqtgraph:
https://github.com/pyqtgraph/pyqtgraph/blob/develop/pyqtgraph/Qt.py
AFAIU, their Qt module should do the same job as the compat one...

Sorry, this applies to the version I got from PyPI (1.0.3) i guess, but the latest master branch already relies on qtpy to solve the compatibility.


[5.6] PHPDoc to prevent use of Request::get() the most we can

See #24689 and https://github.com/laravel/ideas/issues/114.

While this never been used in Laravel before I'm more leaning forward to adding trigger_error() here.

I'm with anything that makes people aware to avoid this method.

I've been using  $request->get() since forever and never had a problem with it. From what I've seen the issue seem to only present itself if you use the same name in different containers of data in your http request, which is something questionable on it's own.

Same here. I  se it in every project. Confused by this.

I read those topics and understood exactly what you're saying. But since I always write the full feature (since request until response), I never put the same name in two different containers of data. If URL is using that name, why should the post request use it for a different data, anyway?
I don't know the reason Laravel chose a different order and now it's just pointless to keep it consistent with Symfony, but I still think there is no problem with using get because you shouldn't use the same name for different data in a single request on different containers.

I made the wording a little softer.


Fixing formatting issue in raiden-ts readme [skip ci]

Fixes #277

Is this really going into this update-readme branch? Shouldn't go to master?

@andrevmatos thanks :-) this is wrong