static import assertThat, like the documentation suggests

Codecov Report

Merging #2439 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2439   +/-   ##
=========================================
  Coverage     86.45%   86.45%
  Complexity     5281     5281
=========================================
  Files           458      458
  Lines         21057    21057
  Branches       2288     2288
=========================================
  Hits          18204    18204
  Misses         2036     2036
  Partials        817      817

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485c204...d322080. Read the comment docs.

See section 2 of https://google.github.io/truth/ . I think one reason is that we have both Truth.assertThat and Truth8.assertThat for Java 8 stuff. static imports, surprisingly, lets you import both and picks the right one on each call site.


Add Iterator implementation

Closes: #122

@tshemsedinov this is WIP I am open to suggestions and there no tests, I will add them later.

@tshemsedinov can we proceed with this one? It's quite useful to have forEach, some, any etc on any Iterator. Though tests should be ported to metatests.

Rebase needed only for single file, even for single line

@tshemsedinov PTAL at tests, is it the right way to write tests with metatest?

I don't like the fact that all of the methods on these Iterators have a behavior different to the built-in method's behavior in terms of this reference usage.
Built-in methods allow to provide thisArg as the last argument to the method, which then has an effect on callback calls as described on MDN (on an example of Map.prototype.forEach):

If a thisArg parameter is provided to forEach, it will be passed to callback when invoked, for use as its this value.  Otherwise, the value undefined will be passed for use as its this value.  The this value ultimately observable by callback is determined according to the usual rules for determining the this seen by a function.

And if you take a look at all other similar built-in methods, they all seem to have this behavior.
@nechaido, can you, please, change this Iterator implementation to have similar behavior in terms of this usage?

@belochub I would prefer not to, but if @tshemsedinov approves your request I will implement the desired behaviour.

@nechaido I'd agree with @belochub, it will be good to be contact compatible if it have no significant performance influence

@tshemsedinov what do you think about:
  collect(Class) {
    return new Class(...this);
  }

.toCollect(CollectionClass)

How about .collectTo(CollectionClass)?

@tshemsedinov please take a look at Trevis, this looks to me like a problem with the metarhia/metatests itself.
It appears that on node v6 it places every test in a queue and starts executing them only after every test is placed in the queue, while on node v7 and higher test are executed at the time api.metasync.test() is called.

@nechaido it works for me with node 6.14.1 locally. I'll try to update metatests to my latest patch

I'd like to have forEach synonym each

I would prefer not to add any new functionality at his point this PR is already too big.

@tshemsedinov imo each maybe be confusing with every in JS and all in other languages.
Though I agree with @nechaido that we should land this one and add more functionality in follow up PRs.

@aqrln ping.

LIFAS
Land it for Allah's sake!

Landed in https://github.com/metarhia/common/commit/03f102e312d8f7ffabdc42b06fc918671afc3175.


I should have not specified "--prompt" as an argument


support for multiple http port listen

support for multiple http port listen:
the code already does but not the command line/image
multiple simple echo srv at least
and maybe 1 report and 1 full UI on different ports too
cc @ZackButcher for his health checks tests. @danehans  as it relates to #91

let's do this through #160


Extensions break on path change

Taken from Reddit comment :

Not sure if you are aware of it. But firefox ever since version 67 and up has changed the way the profile works. So if you change the firefox folder name or move it on the same system or to another system, the extensions dissapear in the portable versions. They still show in the extensions added Section, but they didn't show up on the toolbar or seem to work. So you basically have to re add them again, which kind of defeats the purpose of being portable. Maybe its something you can figure out how to fix? By the way, you did an excellent job with Brave !

Based on MrAlex94/Waterfox#329, the problem lies with addonStartup.json.lz4 that specifies the full path to the extension. I can play with proprietary MozLz4 format and fix this issue.

Fixed (see 67.0.1-15)


how to set redis auth

hi,
i want to know how to set redis auth,
because there is just user and password to set in config.toml.i set it
but master error is
"error":"ERR wrong number of arguments for 'auth' command"

Could paste your Redis URL? You could replace username and password with *

cache_store = "redis://*:Qyj22QjyT82JJg4zDdhPD54@XU3d$q@myredisurl:port/2"
and following is the tencent redis warning

Could paste your Redis URL? You could replace username and password with *

cache_store = "redis://*:Qyj22QjyT82JJg4zDdhPD54@XU3d$q@myredisurl:port/2"
and following is show on tencent redis warning

I think this link may help: https://stackoverflow.com/questions/67613484/redis-err-wrong-number-of-arguments-for-auth-command

I think this link may help: https://stackoverflow.com/questions/67613484/redis-err-wrong-number-of-arguments-for-auth-command

ok,thank you very much,it's been resolved,
redis://:<password>@<url>:<port>
there is a : before password but without username


StartAdvertising doesn't have a status callback for success or failure.

Can it be added?

The startAdvertising method returns a Future, this future will complete when the status is success or throws an error when the status is failed. You can try catch this method and await it to know the status.


Add libc definitions for Megaton-Hammer, a Switch Homebrew toolchain

I'm working on a pure-rust toolchain to write homebrew for the Nintendo Switch called Megaton-Hammer. I'm hoping to get those definitions upstreamed to simplify my life :).
This toolchain does not depend on a C compiler or a libc (it reimplements everything in rust) - but given many crates in the Rust ecosystem rely on the libc crate for the definition of various common types, this is what I came up with.
I was wondering what a good target triple would be ? I currently gate the implementation behind target_os = "switch", but if this goes upstream I figure that might cause trouble for people using the Nintendo SDK (they might already be using target_os = "switch" for some things). Would it be better to go with target_env = "megatonhammer"?

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

Thanks for the PR! I think target_os is fine to use, but could this use a separate file instead of inlining the definitons? (like most other platforms use)

It's fixed :)

@bors: r+

@bors: r+

:pushpin: Commit 8ff70b6a4c8feeba9e9c00bb4d1a0af4b94d4bb1 has been approved by alexcrichton

:hourglass: Testing commit 8ff70b6a4c8feeba9e9c00bb4d1a0af4b94d4bb1 with merge 9be97c961f8dbb53f3c7ff40129b1f6c4bd60304...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 9be97c961f8dbb53f3c7ff40129b1f6c4bd60304 to master...


Update interactions export from search

Description of change
This changes how exports work from search (starting with interactions – the other exports have been removed for now).
Unfortunately, it's a bit complicated as the search is performed from the filter pages (which uses Elasticsearch) but the data needs to come from the RDBMS (for multiple reasons, including that the data needed in the exports comes from a lot of models so getting it from Elasticsearch isn't practical).
So the process is to get a list of IDs that match the query from Elasticsearch and then those IDs with the Django ORM. (Another approach would be to put the IDs in a temporary table, but it starts getting more complicated so I haven't gone down that route.)
The number of results is limited to 5000, so it's not huge and performance should be reasonable. (Note: the front end won't show the export button at all if there are more than 5000 results.)
A placeholder set of fields is included in the interactions export for now – will update them in a follow-up PR.
Checklist

[x] Have any relevant search models been updated?
[x] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[x] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[x] Has the admin site been updated (for new models, fields etc.)?
[x] Has the README been updated (if needed)?

Codecov Report

Merging #1057 into develop will increase coverage by 0.01%.
The diff coverage is 96.49%.

@@             Coverage Diff             @@
##           develop    #1057      +/-   ##
===========================================
+ Coverage     96.1%   96.12%   +0.01%
===========================================
  Files          213      213
  Lines         6038     6032       -6
  Branches       583      577       -6
===========================================
- Hits          5803     5798       -5
  Misses         168      168
+ Partials        67       66       -1

Impacted Files
Coverage Δ

datahub/search/investment/views.py
100% <100%> (ø)
:arrow_up:

datahub/search/contact/views.py
100% <100%> (ø)
:arrow_up:

datahub/search/interaction/views.py
100% <100%> (ø)
:arrow_up:

datahub/core/csv.py
100% <100%> (ø)

datahub/search/company/views.py
100% <100%> (ø)
:arrow_up:

datahub/search/event/views.py
100% <100%> (ø)
:arrow_up:

datahub/investment/report/spi.py
94.73% <100%> (ø)
:arrow_up:

datahub/admin_report/views.py
100% <100%> (ø)
:arrow_up:

datahub/search/views.py
94.69% <92.85%> (+0.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f8bf5...dd4af8e. Read the comment docs.

Just noticed that the normal entity search view and the export view use get_search_by_entity_query a bit differently – will push another commit to fix that.

@reupen it looks good but it would be good to have live document on who needs this and how they will be using the data. Let's wait for Anthony before merging this.

@reupen I've added a blocked label so that we don't forget about this ;)

Discussed and agreed to:

limit the number of columns and rows in the export
use data analytics to monitor its usage
ideally add some copy saying that this subject to change without notice


Fixes a small spelling mistake (Themeing -> Theming)

Saw there was a spelling mistake on the website, made a fix there
came to check the repo out and saw the mistake here too. Thought I'll push a quick fix 😅

thanks @BharatKalluri !

@BharatKalluri  fixed it on the website as well 👍

:tada: This PR is included in version 0.23.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[FEATURE] Add option to allow navigation between visible dates.

Added showNavigation option. When enabled a header section with navigation arrows and the current presented month will be visible. This should resolve issue #105

This should be made generic, not just for months. Unfortunately I'm not sure when I can free up some time to change this.


Elevated profile doesn't open Quake terminal

Windows Terminal version
main 7061c54
Windows build number
10.0.19044.0
Other Software
No response
Steps to reproduce

add new profile and set "elevate": true
open new profile
close previous terminal window
open Quake terminal

Expected Behavior

quake mode terminal

Actual Behavior

no quake mode terminal window:

This is likely what happened

You started the terminal, and it took the win+` hotkey
You started an elevated terminal. It trued to take the win+` hotkey, but found it was already bound, so it failed.
You closed the unelevated Terminal. Nothing here tells the elevated Terminal to take over the keyboard shortcuts
You press win+`, but no one has that key bound.

I suspect this isn't the only time we're going to hear this on this release. Not sure what a good solution is. Maybe an elevated flag to globalSummon, as a bool?, that can filter to {any window, unelevated only, elevated only}?
This would be the release to handle this, that's for sure.

Coming here from #9996. I'd like to have a way to enforce that the new headless terminal from #14944 is the only thing registering the Win+` quakeMode hotkey. This is so that I can ensure quakeMode windows are always unelevated (my preference) by launching the headless terminal as unelevated.
As it currently stands, there's a race as too which terminal starts first and captures the hotkey. If I open an elevated terminal immediately on login, I can find myself locked into elevated-only quakeMode terminals.


Don't leak secure variables to log

Fixes #24.
The old Travis log files can be deleted if necessary.

I'm not convinced this is a security issue, but it is definitely defensive coding. I'm adding it to my branch: https://github.com/jbdeboer/travis_after_all/commit/778201a88a09433d6bff7d9c4c700ad9ef4c17b7


Parser edits

Updated the way the parser parses strings and handles errors.
Major changes:

parser now separates string at new lines and parses each line separately
error message indicating where the error was in the line
only lines that have an error in them are discarded, the rest of the recipe will parse

Things I still have to change before merging:

make parser separate lines by all acceptable new line characters
update error message to show user friendly message indicating error
update line counter for error message to properly indicate which line message has an error

So far the error message indicates what token trips up the parser. It uses the token definitions from the Cooklang.y file and prints out the token. To me the token names seem pretty clear as to what they represent, but I'm wondering if anyone thinks they should be updated to be more clear. You can look at them here: https://github.com/Seth-Harlaar/cooklang-c/blob/a29c84a6ebc43170e7f562d694367bb2e1c81e6d/src/Cooklang.y#L40

Could you please share an error message example?

Sure!
Let's say the user forgot the right curly bracket in the example input:
Put @ingredient 4} in pot.
The output error message would be the following 2 lines:
Error, syntax error, expected RCURL.
Error at column 16 on line 1.

Hello !
If the PR is not ready to be merged, you can convert if to "draft PR", so it is clear for everyone

also I don't understand the changes in cooklang.l file. We don't want to support UTF-8 anymore ?

Oh, thanks for picking that up, I was making some changes to the parser and removed the UTF-8 to make testing easier. I will revert the changes.

Oh ! Ok !

Hello !
Maybe you are aware of this, but the make parser comment doesn't work. Both on main branch and in this PR. As you're working on it, maybe if you fix it you could then add a github action to check that it doesn't break in the future

parser now separates string at new lines and parses each line separately
How do you plan do manage to parse multi-block comments ?

Was not aware of make parser not working. It seemed to be working perfectly fine on my system. I will look into it.
Maybe in the parseMultipleLineString function we can check a return value from the parser and see if there is an opening and no closing to a block comment. From there we can tell the parser not to parse anything until it has detected a closing tag.


External chain does not support

custom_css: 'https://cdn.example.com/prism-tomorrow.css'

Please describe your issue in more detail.

I want to use my own CDN CSS
But there is no configuration
custom_css is Relative path
const prismThemeFilePath = custom_css === null ? prismTheme.path : path.join(hexo.base_dir, custom_css);

Some clarification before we continue:
Prism and Prism-themes only offer static CSS files. We are not responsible for loading them into your website.

But there is no configuration

Configuration for what?
I'm sorry but you are not providing enough information.
I get that you want to load a CSS file, but Prism is not responsible for that. Also, what is an "external chain"?

Sorry, my English is not very good
Maybe external links are better
I may have written in the wrong place
I want to ask hexo prism plugin
I am Sorry:smile:

No problem.
And yes, hexo-prism-plugin seems like the right place to ask your question.


CrowdStrike Solution using inconsistent capitalization breaking case-sensitive KQL.

Describe the bug
CrowdStrike Solution using inconsistent capitalization breaking case-sensitive KQL.
To Reproduce
Throughout multiple files the solution uses inconsistent capitalization of CrowdStrike.
Opening the solution and looking at the query you will find the red_underlined errors of KQL stating that the package does not exist.
Expected behavior
CrowdStrike should be capital 'C' and 'S' for its propername. This is not spaces, Camel cased, nor is it underscored.
Screenshots
If applicable, add screenshots to help explain your problem

As an example the provider should be changed
from "providers": ["Crowdstrike"],
to "providers": ["CrowdStrike"],

The files should be renamed as well.

Hi @cs-shadowbq we have fixed the issue in the parser that we were using in rules and queries in our latest package, for other content we are working on analyzing the impact it would have on end users, we will make the changes based on the impact they might create, please let us know if we can assist you with anything else, thanks!


fix(CI/CD): Use GH_TOKEN instead of FABRIC8CD_GH_TOKEN

Once this https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/1721 is resolved, FABRIC8CD_GH_TOKEN will be renamed to GH_TOKEN and the master build would fail.
This PR fixes the master build.
DO NOT MERGE until https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/1721 is resolved.

@jarifibrahim Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2594 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2594 and visit http://localhost:5000 to access it.


[bot] Update to version 2.0.8

Auto-update version number to 2.0.8

@conda-forge-admin please rerender


Splitting conferences year wise

Please check & merge. Thanks.
Fixes #28.

@nikhita Done, pls check.

done more changes. please check.

@techsethi It looks good, why did you close the PR? :)

Great. Thanks.
Sent from my iPhone

On 14-Oct-2017, at 6:22 PM, Nikhita Raghunath<EMAIL_ADDRESS>wrote:
Merged #39.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Add francoisefd78's file

create test file 0000-01-02-francoisefd78.md

Make changes live by merging your PR.

Make changes live

test


Feature request: Different rules for different directories

Would be great to have different rules for different directories, like ls-lint can do, but I'd much rather use your eslint plugin.

this can be achieved with normal eslint "overrides" config.
I'm working to set up my project now to enforce PascalCase.tsx for react components and camelCase for everything else, and it working pretty good so far.
https://stackoverflow.com/a/55808520/1383268


perf: global intersection observer for prefetching

Still in draft. Feedback welcome!
Resolves #8672 one day :D
Open Questions:
"General purpose" Observer (similar to nuxt-image) or dedicated to smart prefetching only?
Pros of a general purpose one:

can be used by module authors (e.g. nuxt image) + developers to avoid multiple IntersectionObservers

Cons:

Harder to draft out API - more scenarios to consider
Has to be documented properly then 😜

Tests?

Now the smart prefetching capabilities cannot be unit-tested (I think) and a new fixture must be included.

It starts to look pretty good, thank you for your current work on it @manniL 😊

It starts to look pretty good, thank you for your current work on it @manniL 😊

Closing here as #8672 is closed + focusing on Nuxt 3 development.


Material Drawer Theming Support?

This is the best theming library i have found so far!
I hope you add support for Mike Penz's Material Drawer Library (also MaterialDrawerKt which is based on the original Library)
I tried using the Colorful's
                .setCustomThemeOverride(R.style.AppTheme)

with the theme attributes specified here
but it doesnt seem to work or maybe I'm doing it wrong?

What exactly isn't working? At it's core, colorful is very simple. It uses Android's native style engine, just as if you set a style in xml. How different libraries react and use the Android styles is up to them, not colorful.

If you set a custom theme, or disable theme overriding you will disable dark theme functionality, please see the wiki for more info on this.
Other than that, the library you're using not respecting the Android style isn't a colorful issue, you would run into the same issue with or without colorful. Colorful uses Android's style engine and just provides more features to it.
Closing as this is a issue unrelated to colorful. If you have any further questions please open another ticket.


Adding functionality to check for Roo-Cline updates

Adding functionality to Roo-Cline to automatically check for updates from CodeArtifact

[!IMPORTANT]
Adds functionality to Roo-Cline for automatic update checks from CodeArtifact, with user prompts and tests.

Behavior:

Adds scheduleUpdateChecks and checkForUpdates functions in version-check.ts to periodically check for updates from CodeArtifact.
Integrates update check in activate() in extension.ts, prompting users to update before starting new tasks.
Handles user choices for update prompts, including 'Update Now', 'Continue Anyway', and 'Cancel'.

Testing:

Adds version-check.test.ts to test update check functionality, including scenarios for available updates, no updates, missing login script, and errors.

Misc:

Updates version in package.json from 2.1.1 to 2.1.2.
Updates files in package.json to include roo-cline-2.1.2.vsix.

This description was created by  for 648f05c1d0159ae9cf7b323ec29c06c5886a9e97. It will automatically update as commits are pushed.

Should we close this one now?

Should we close this one now?

Yup, I'll close it out as this should no longer be needed


Add panel and dialogs for creating and editing measure scripts

This PR adds a new panel for creating, editing and running measure scripts. I have also added a point-and-click dialog for creating a measure script (or editing an existing one). Running a measure script currently just prints to the log as I still need to hook up the OPUS integration (the first step is #79, but other changes will be needed).
@dalonsoa I'm afraid this PR is a bit on the longer side too. I worked on it a few months ago before the measure script stuff was properly in place so it represents a fair bit of work (albeit now squashed into one commit). Let me know if you'd like me to break it up.

I've added the confirmation dialog and opened an issue to add tests: #83.
I'll add the tests later, if that's ok. I'm working on a couple of other bits right now, so I think it'd be good to have this bit merged in as it is for now (partly for ease of demoing on Monday). I promise I'll do it soon though!

(I've also slightly rearranged the GOTO button + angle spinbox for aesthetic reasons.)

Thanks for the review @dc2917 :smile:


Vault operations on closed/empty vault

Changes 👷♀

add hasToDepositCollateralOnEmptyVault error + message
add stories
add tests
add calculating initial stage for otherAction/adjustPosition if vault has 0 locked collateral.

How to test 🧪

test in UI/Storybook

Definition of done ✔

[ ] Acceptance criteria for each issue met
[ ] Unit tests written where needed and passing
[ ] End-to-end tests for happy path
[ ] Documentation updated
[ ] Project builds without errors
[ ] Non-functional requirements met
[ ] Code reviewed and functionality tested by the reviewer (locally, Heroku, etc.)
[ ] Feature verified and accepted by Product Owner
[ ] Project deployed to production environment

I guess this behaviour is acceptable ass user can't perform any action until slider is moved and then everything is fine

:heavy_check_mark:

:heavy_check_mark:

after clicking close this vault on bottom of form


chore: updated action to v0.2.0 and added contracts input

Do we need to add the contracts input to the docs?

Closing as this change is no longer relevant


File Path Things

Current coverage is 94.87% (diff: 100%)

Merging #29 into master will decrease coverage by 1.12%

@@             master        #29   diff @@
==========================================
  Files             5          5
  Lines            75         78     +3
  Methods           0          0
  Messages          0          0
  Branches          4          6     +2
==========================================
+ Hits             72         74     +2
- Misses            1          2     +1
  Partials          2          2

Powered by Codecov. Last update f1e66ad...6b56be4


Date constructors with more than one argument missing

The Date constructor takes up to seven arguments. web-sys currently only supports zero and one arguments.

Added in https://github.com/rustwasm/wasm-bindgen/pull/1759!


[Question] Embedding Boo

I rediscovered Boo today. Does Boo provide an API for embedding it with other ,NET applications? For example, compiling on the fly, or an embeddable scripting API like IronPython?

This is a more complete example of using embedding Boo and using it as a DSL https://github.com/ayende/rhino-dsl

Short answer: Yes; look at the Boo.Lang.Interpreter assembly, and booish.exe in particular as an example.
Long answer: Feel free to discuss questions about how to use Boo over on our community forum.  We can tell you all about using Boo.Lang.Interpreter, in as much detail as you need.  But this issues list is really for posting bug reports and feature requests.
Closing this to keep the issues list clean. :)


Update tabs-requirements.md

Updating this documentation - https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/tabs/tabs-requirements
@clearab

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: gaurav16goel sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Docs Build status updates of commit 4b1f851:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/tabs/tabs-requirements.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Invedsstigate Tungsten integration/support

We should look into and explore the use of Tungsten for FiloDB query side and native support for it too.

I've just wrapped up a performance comparison, and by the way you can run the SparkReadBenchmark using jmh:run and uncomment the tungsten disable to see what the effect is.

Tungsten is automatically used by default for all DataFrame queries in Spark 1.5.x and up
It introduces a ~1 second startup time for the first time a query is run, due to code gen
Perhaps 20% improvement in in-memory scan speeds over having Tungsten off, in the benchmarks.  However in real life Spark Shell use, the improvements are not necessarily visible.  Perhaps more visible in joins.
Major areas of use includes UnsafeRow, an off-heap, byte-serialized representation of intermediate rows;  and more efficient cache friendly structures for joins and grouping aggregations.  UnsafeRow is not really useful for us, we already have our data in a much more efficient columnar byte-serialized representation.

I think until the vectorized computation stuff comes in, there won't be too much of a gain yet.


Setup initial open file diff event from pr description

Summary
When comments on files show up in the PR description, the file has no way of being opened/ opening the full diff of that file.
This PR is to discuss and add a Show Diff / Open File button(s) to the file name bar on comments in the description view.

This is a WIP.

@RMacfarlane This my first blind attempt at the feature you mentioned in your Github Universe talk to open the file/file-diff from the comment preview in the PR description.
Right now - the command to open the diff view fails, and I'm not sure how to debug further. This approach probably needs other improvements. #IDontKnowWhatI'mDoing :)

@kyle-rader thanks for your help on this. This is an interesting feature but a bit complex. The workflow of opening the diff view in my mind can be

Users click on the link of a diff hunk in the description page
PullRequestOverviewPanel handles the clicking event and analyze which file to open by reading the comment info.
Based on the comment info, we know which line/column we should scroll to when the editor is being opened.
Pull Request Tree View should focus on the file change node, which is determined above
We open the diff editor for the file change node and scroll to the target line/column, which is determined above.

Thanks @kyle-rader, sorry for the delay in looking at this! This looks like a great start, you've correctly added something to the Description page and sending the message back to pullRequestOverview.ts is correct.
It looks like we've made things harder for you by having the wrong types on the pr.openDiffView command. The first two arguments, parentFilePath and filePath, should be type vscode.Uri instead of string. You can take the file path and convert it into this using the toPrUri function.

Hey @kyle-rader, thanks for giving this a shot! We implemented this feature with cfcb1f74f06669fe42087216f2b0b10be0285d65 so I will close this out.

@RMacfarlane thanks for the update - sorry I never got back to it. Glad to see it got in though!


Stacker News Sheriff's Badge

Is your feature request related to a problem? Please describe.
Stacker News introduced a cowboy hat feature a while ago, and it has seen some good adoption to date. However, the cowboy hat can be improved and augmented with a new feature called the Sheriff's Badge.
Describe the solution you'd like
Each day, one stacker will earn a Sheriff's Badge based on the top spender numbers from the previous day. That stacker will become the new "Stacker News Sheriff" for the next 24 hours. The username to all their posts and comments will now display a badge instead of a cowboy hat, and hovering over the badge will have the same effect as hovering over the cowboy hat (viewing the length of one's streak).
This feature will also be for status purposes (just like the cowboy hat) to start, but could evolve along with the cowboy hat to grant the stacker special privileges like extra treasure hunt opportunities each day.
When visiting a stacker's profile page, there will now be up to two icons (a cowboy hat and a sheriff's badge) with a number next to each icon. The number next to each icon should denote the total number of days that a stacker has either earned a cowboy hat or a sheriff's badge (regardless of how long their streaks were, to help those who get burned by losing long cowboy hat streaks). Competing for Sheriff's Badge streaks also doesn't make for a fun environment, as all users are now forced to compete against each other for a single Sheriff's Badge in a zero-sum match every day. The odds of any user achieving a 10+ day streak are vanishingly small.
To really make this feature fun and engaging for Stackers, Stacker News could replace the username field in the navbar with the profile picture of each stacker, and overlay a cowboy hat (near the top) or a sheriff's badge (near the lower-left corner) ontop of their photo when they earn either one of those items. The cowboy hat can even have a tilted position to notify a stacker they are at risk of losing their cowboy hat.
The same icon overlays could be applied to the profile page where stackers already see their profile photo.

Would you mind writing the notification text for gaining and losing a sheriff badge like for the cowboy hat?

Would you mind writing the notification text for gaining and losing a sheriff badge like for the cowboy hat?

Sure, updated the original comment with notification copy


Wrap long emails of a Next Steps message

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/32286
PROPOSAL: https://github.com/Expensify/App/issues/32286#issuecomment-1853885506
Tests

Precondition:

User is an employee of a Collect workspace. (I can invite you to my own).
Admin that approves your expense requests, must have a really long email.

Log in to ND as the employee.
Go to the workspace chat > + > Request money.
Create a manual request.
Submit the request.
Tap on the expense preview to open the paid expense report.
Verify that an admin's email is wrapped.

[X] Verify that no errors appear in the JS console

Offline tests

Same as "Tests".
QA Steps

Same as "Tests".

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

![Uploading Desktop 4.png…]()

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.14-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.14-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.14-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


DUP: minor home page text edits [XS]

Description:
Small text change to https://reserve.bcparks.ca/dayuse/ as described in this document.

Acceptance Criteria:

[ ] Text on https://reserve.bcparks.ca/dayuse/ matches that in the word document.
[ ] Hyperlink to "https://bcparks.ca/reservations/day-use-passes/" is included in the text

Development Checklist:

[ ] ...
[ ] ...
[ ] ...

Dependencies

Blocked by
Blocking

Relevant documentation as reference
Definition of Ready

[ ] Acceptance criteria are included
[ ] Wireframes are included (if applicable)
[ ] Design / Solution is accepted by Product Owner (if applicable)
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done

In progress:

[ ] Acceptance criteria are tested (Functionality meets the acceptance criteria defined in the ticket)
[ ] UI meets accessibility requirements
[ ] Unit tests are written
[ ] Work is traceable in GitHub
[ ] PR linked to ticket number
[ ] If needed/required - Dev adds flag/label to highlight any migration steps necessary prior to PROD deployment

Code review:

[ ] Code is peer reviewed and has passed CI/CD tests

QA:

[ ] Acceptance criteria are tested (Functionality meets the acceptance criteria defined in the ticket)
[ ] Code is potentially shippable to the production environment
[ ] Functional features have been tested and passed by QA
[ ] UI components tested by designer
[ ] Code is deployed to PROD when moved to 'done' column (unless requested otherwise by PO)

PO Review:

[ ] Acceptance criteria are tested (Functionality meets the acceptance criteria defined in the ticket)
[ ] Reviewed and approved by Product Owner

Notes:

@MarshallHenson can you link the doc again? It's sending me to a 404 error.

https://bcgov.sharepoint.com/:w:/r/teams/031072/Shared Documents/[Product] Parking Services/DUP Reso Site Content/Copy drafts/1. day-use-pass-system-home-v1.0-APPROVED.docx?d=w008eae2483be4f84b144f77470b79c29&csf=1&web=1&e=AldLw1

Tested on https://test-dup.bcparks.ca/dayuse/: Passed

Verified that this change request has been implemented.
Passing to PO review.

looks good in test - moving to done


Version 3.14.1 about plugin is vulnerable to stored XSS

Describe your problem
I found a XSS vulnerability on about plugin which is inside the admin panel
Steps to reproduce the problem

login to the admin panel of the website.
select theme tab

activate theme Alternative to Blog X.

click back or navigate to the home page for the admin panel.
click and open the plugins tab.

Select About setting tab.

Insert the XSS payload on the input tab.

save it and open the home page of the website.

Here it is image which is proof for the xss.

(Note: it only execute in blog x theme )
Bludit version
V3.14.1
PHP version
PHP 8.2.6 (cli) (built: May  9 2023 16:47:59) (NTS)

You need to have access to the admin panel to change plugin/theme configurations and add XSS. Thank you for reporting the issue.

It is old cve which is found in 2021


Trigger prod cli release for v0.20.2

Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Fix #1616, Incorrect OSAL Format in Users Guide Reference

Describe the contribution
Fixes #1616
Expected behavior changes
Users know where to find autogenerated documents and other documents.
Additional context
Did not keep the table in case files change names, location, or documents are added/removed.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

CCB:2021-09-01 APPROVED


[google_maps_flutter] Should have a callback when map finished rendering

Google map package should expose the API to notify when the map finished rendering. This is to be distinguish with onMapCreated. [onMapCreated] is called when the view is ready, not necessarily when the content of the map is rendered.
mapViewDidFinishTileRendering: on iOS.
onMapLoaded: on Android.

It exist as onMapCreated ..

@imeDevelopers  ASAIK, onMapCreated is called when platform view is ready; not necessary when the map is rendered.

Rendring map are passed on internet .. its not really important idea , because the user see the map directly and you can see all objects even if map not renderd yet like markers , you can use onCameraIdle to change something , its my opinion

@imeDevelopers Interesting point about onCameraIdle, thanks!

@cyanglaz were you able to simulate a render-complete callback with onCameraIdle?  The map widget in my app has 500ms-1200ms of draw time when navigating back to the map view from another route. I'm trying to cover the redraw using takeSnapshot and Stack. The best I've come up with is using a Future.delayed() in onCameraIdle() to remove the cached image and expose the completed map. However, the draw time worst case range is long enough the user may try to interact with the image. I'm passing through gestures but it pops if the user tries to scroll.

@Proberts onCameraIdle seems working fine for me.
Are you talking about the duration from opening a map view to the content of the map view is drawn? It might take time based on the network AFAIK

A typical scenario for this is to center the camera around a marker "once" when the map is finished rendering. with onCameraIdle you will need a flag to set to false to prevent it from re-centering again when the map is idle again after dragging.
I think we should have a callback when the rendering is finished for 1 time calls.

A typical scenario for this is to center the camera around a marker "once" when the map is finished rendering. with onCameraIdle you will need a flag to set to false to prevent it from re-centering again when the map is idle again after dragging.
I think we should have a callback when the rendering is finished for 1 time calls.

I have a scenario .
I need to take a snapshot when the google map is loaded.
I take snapshot inside the onMapCreated() but it takes snapshot while the google map is rendering on some devices . I get blurry unrendered snapshot.
so I wait for 1 secs then I take the screenshot!
/// state
class GoogleMapWidgetState extends State<GoogleMapWidget> {
  final Completer<GoogleMapController> _mapController =
      Completer<GoogleMapController>();

  ///
  Uint8List? imageBytes;

  @override
  Widget build(BuildContext context) {
    return imageBytes != null
        ? Image.memory(imageBytes!, fit: BoxFit.cover)
        : GoogleMap(
            onMapCreated: (GoogleMapController controller) {
              _mapController.complete(controller);
              takeSnapShot();
            },
            initialCameraPosition: CameraPosition(
              target: widget.latLng,
              zoom: widget.zoomLevel,
            ),
            markers: widget.disruptionMarkers,
            compassEnabled: false,
            indoorViewEnabled: false,
            myLocationEnabled: false,
            myLocationButtonEnabled: false,
            zoomControlsEnabled: false,
            zoomGesturesEnabled: false,
            tiltGesturesEnabled: false,
            scrollGesturesEnabled: false,
            rotateGesturesEnabled: false,
          );
  }

  ///
  void takeSnapShot() async {
    GoogleMapController controller = await _mapController.future;
    Future<void>.delayed(const Duration(milliseconds: 1000), () async {
      imageBytes = await controller.takeSnapshot();
      setState(() {});
    });
  }
}

To avoid this,
please provide the callback when the map finished the rendered!!!

This is an issue when we try to load the data based on the visible region, if we try using mapcreated the getVisible region is giving 0.0 for lat and lon.

@stuartmorgan Any chance we can up the priority on this issue? Currently there's a workaround in the google maps  for Android integration tests that adds up to 5 unnecessary seconds delay each time the tests are run. i.e. await Future<void>.delayed(const Duration(seconds: 1)) is called 5 times. This proposal could potentially speed the tests up.

Currently there's a workaround in the google maps for Android integration tests that adds up to 5 unnecessary seconds delay each time the tests are run. i.e. await Future<void>.delayed(const Duration(seconds: 1)) is called 5 times. This proposal could potentially speed the tests up. It may also help alleviate some of the flakiness if 1 second is not quite long enough.

Is the test waiting for a specific value? If so, we can address both of those issues by just putting the test in a poll loop with short interval and longer max. E.g., check if we have the expected values every 0.1 seconds for up to 5 or 10 seconds.

Maybe @cyanglaz has more context, but from what I can tell, polling won't be sufficient in this particular case, as the visible region needs to be checked only when the map has completely finished rendering (i.e. fully visible and not blurry to the human eye). The only way to guarantee the correct value is to have access to the callback. e.g. https://github.com/flutter/packages/blob/33dacd6d67e62fee910be02eac04ec5402bf270b/packages/google_maps_flutter/google_maps_flutter_android/example/integration_test/google_maps_tests.dart#L907

Maybe @cyanglaz has more context, but from what I can tell, polling won't be sufficient in this particular case, as the visible region needs to be checked only when the map has completely finished rendering (i.e. fully visible and not blurry to the human eye). The only way to guarantee the correct value is to have access to the callback. e.g. https://github.com/flutter/packages/blob/33dacd6d67e62fee910be02eac04ec5402bf270b/packages/google_maps_flutter/google_maps_flutter_android/example/integration_test/google_maps_tests.dart#L907

Yeah this most of the tests, polling would work. This particular one seems to be waiting for the "visibleRegion" to be "stabilized" so it is not checking a particular value. I think the implementing the callback in this issue would help. However, we can def implement polling for other tests to speed the tests up and deflake them.


Tweak: Patch Prometheus for v.3.0.0

Description
Remove some parts for 3.0.0 https://github.com/prometheus/prometheus/releases/tag/v3.0.0
Fixes #92
Reference https://github.com/community-scripts/ProxmoxVE/pull/300
Type of change
Please check the relevant option(s):

[x]  Bug fix (non-breaking change that resolves an issue)
[ ]  New feature (non-breaking change that adds functionality)
[ ]  Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
[ ]  New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:

[x]  Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
[x]  Testing performed (I have tested my changes, ensuring everything works as expected)
[x]  Documentation updated (I have updated any relevant documentation)

Thanks for this!


[BugFix] Fix Digit Identifier parse error to decimal lex bug

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes https://github.com/StarRocks/StarRocksTest/issues/1702
Problem Summary(Required) ：

zh.111_a will be parsed as identifier dot decimal_literal identifier. This is not expected, so we added DOT_IDENTIFIER for direct parsing in Lexer
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 15 / 15 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
15
15
100.00%
[]

run starrocks_admit_test

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 15 / 15 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
15
15
100.00%
[]

@Mergifyio backport branch-2.5

@Mergify backport branch-2.5


[TEST] [DO NOT MERGE] mocking odb._init

The Windows tests are painfully slow because they make 256 makedirs call on every initialization.
I was trying to understand why that's the case for just 13 tests, and the issue is very likely from that initialization logic.

 Configuration
	 Before
	 After

 Windows + Python 3.10
	 219.48s
	 19.64s

 Windows + Python 3.9
	 214.45s
	 20.75s

 Windows + Python 3.8
	 229.37s
	 17.72s

Closing as the tests are no longer slow in Windows.


Zero SameDiff Gradients

Issue Description
I've written a minimal code to reproduce the issue:
        SameDiff sd = SameDiff.create();

        SDVariable i0 = sd.placeHolder("i0", DataType.FLOAT, 2,5);
        SDVariable w0 = sd.var("w0", new OneInitScheme('c'), DataType.FLOAT, 5, 3);
        SDVariable b0 = sd.var("b0", new OneInitScheme('c'), DataType.FLOAT,3);

        SDVariable w1 = sd.var("w1", new OneInitScheme('c'), DataType.FLOAT, 3,3);
        SDVariable b1 = sd.var("b1", new OneInitScheme('c'), DataType.FLOAT,3);

        SDVariable i1 = i0.mmul(w0).add(b0);
        SDVariable i2 = i1.mmul(w1).add(b1).add(i1);
        SDVariable l = i2.sum();

        sd.setLossVariables(l);
        INDArray gd = sd.calculateGradients(Map.of("i0",Nd4j.rand(2,5)),"w0").get("w0");
        System.out.println(gd);

I would expect non-zero gradients, instead, I get:
        [[         0,         0,         0],
         [         0,         0,         0],
         [         0,         0,         0],
         [         0,         0,         0],
         [         0,         0,         0]]

Version Information
I am using the following packages:
nd4j-native-platform, version: 1.0.0-M2
deeplearning4j-datasets, version: 1.0.0-M2
deeplearning4j-core, version: 1.0.0-M2

Additional Information
The issue does not appear when using:
nd4j-native-platform, version: 1.0.0-M1.1
deeplearning4j-datasets, version: 1.0.0-M1.1
deeplearning4j-core, version: 1.0.0-M1.1

@f14-bertolotti thanks for flagging. Will look in to this. We'll be doing a quick follow up release after implementing a few features.


Add Service layer and api endpoints for Interventions

What does this pull request do?
Adds the ability to create and find interventions
What is the intent behind these changes?
Build on the intervention model to provide access to intervention data and associate a referral with an intervention

Note. Additional tests are still to be added for this.

Note. Additional tests are still to be added for this.


Updated the manifests to add DEFITVL

Signed-off-by: Krasi Georgiev<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 456181802

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 35.5%

Totals

Change from base Build 456123095:
0.0%

Covered Lines:
1453

Relevant Lines:
4093

💛  - Coveralls

Pull Request Test Coverage Report for Build 456181802

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 35.5%

Totals

Change from base Build 456123095:
0.0%

Covered Lines:
1453

Relevant Lines:
4093

💛  - Coveralls


Fix Policy report link

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Welcome @nlamirault! It looks like this is your first PR to falcosecurity/falco-website 🎉

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nlamirault
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nice catch. could you also add the new outputs from falcosidekick 2.29?

Dynatrace
Sumologic
OTLP Traces
Talon

@Issif May we postpone those additions to a follow-up PR? 🤔

nice catch. could you also add the new outputs from falcosidekick 2.29?

Dynatrace
Sumologic
OTLP Traces
Talon

@Issif May we postpone those additions to a follow-up PR? 🤔

Without any answer from @nlamirault before end of the next week, I'll merge this PR and create another one.

nice catch. could you also add the new outputs from falcosidekick 2.29?

Dynatrace
Sumologic
OTLP Traces
Talon

@Issif May we postpone those additions to a follow-up PR? 🤔

Without any answer from @nlamirault before end of the next week, I'll merge this PR and create another one.

@Issif pls open another PR. I'm approving this meanwhile. Thanks

LGTM label has been added.  Git tree hash: 4145e1df85dcef48ab28b5877d0d40f5cb7b482a


Update README

Issue is #49.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.015%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
965

Relevant Lines:
1214

💛  - Coveralls


fix(whl): py36 support at init image for build whl

Fix py36 problem at scripts/whl/manylinux2014/init_image.sh

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your<EMAIL_ADDRESS>seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

这个 PR 与 https://github.com/MegEngine/MegEngine/pull/439 重复了，我们就先看那个啦。感谢对 MegEngine 的贡献，期待后续你的关注哦！


Suggestions to your project

I think the header tag should be included in the body tag as its child element.

May I ask you to check your semantic tags. If you used them correctly.

I think you can try to change the  width to one that will make it responsive.


Ensure backward-compability with 4.0

Motivation:
Each different *ChannelOption did extend ChannelOption in 4.0, which we changed in 4.1. This is a breaking change in terms of the API so we need to ensure we keep the old hierarchy.
Modifications:

Let all *ChannelOption extend ChannelOption
Add back constructor and mark it as @deprecated

Result:
No API breakage between 4.0 and 4.1

@trustin @Scottmitch please review

LGTM!

@netkins build

LGTM

Cool will merge into 4.1 only

Am 19.04.2015 um 12:15 schrieb Trustin Lee<EMAIL_ADDRESS>LGTM
—
Reply to this email directly or view it on GitHub.

Cherry-picked into 4.1 (b4b14ea19f343fbe7a0993a92856d573683de810)


local proxying: set a default resolver ttl of 10s

https://trello.com/c/H53K45It
This is needed because internal ("private") PaaS routes are load-balanced simply on a DNS trick and our blue-green deployment procedure may make an instance disappear at any time with little notice.
While I'd love to be able to test this without merging, that slightly defeats the point because it's a problem with deployment & releasing that this is trying to fix, and we need to go through a proper release cycle to see if it works.
Note I've added this rule for connections to our frontend apps too even though we don't yet use internal routes for them - this is because I anticipate someone trying to switch them too sooner or later and I'd rather they don't have to rediscover this problem from scratch then.

To elaborate on the "DNS trick" used by cf, it should in most cases "just work" because their DNS server responds with a 0s ttl, which compliant clients should take to mean "re-lookup every time", but nginx notoriously takes to mean "whatever". So that's why we're only seeing it as a problem in the router.

Can you test without merging then revert to test the deployment process? Just to check that the config isn't going to break routing?


IR Pointer

I noticed that the green dot pointer in the demo jumps to a random location during a swing. Is there a remedy to this? I am trying to analyze a swing, but unfortunately this jumps makes it inaccurate.

For analysis, you could maybe try a kalman filter. I'm not too sure about that.
You could also try doing a linear interpolation to smooth out the movement of the pointer.
ex.
Vector3.Lerp(current position, target position, Time.deltaTime)

The green dot calculation uses the accelerometer to account for rotation of the remote (you may notice that if you rotate the remote the white IR dots turn as well in the viewer, this is because the onboard IR camera is being turned).  The actual calculation can be found here.  This means that if you shake the remote, the pointer will go all over the place due to this rotation calculation - it assumes that the accelerometer is pointing in the direction of gravity (down).  This issue is also present on the actual console, by the way.
If you want to have accurate IR while swinging, here are a few things you can try (you will have to make some changes to GetPointingPosition() in any case):

Have some sort of calculation that determines whether or not the remote is still.  Record the most recent "still" pointing position, and only use that in GetPointingPosition().  To determine stillness, you can take the standard deviation of the readings over the last half second or so. I did something similar for my experimental DS4 API - check that out for reference.
Use the Wii Motion Plus for the rotation reading instead of GetPointingPosition() - in this case of course you need to make sure you are using a Wii Motion Plus.
Remove the rotational correction entirely (this only works if you can guarantee that the controller is level with the ground, which it sounds like you can't).

I have the Motion Plus extension added to the Wiimote. How would you integrate the motion plus rotation data with the IR points? Would I combine PitchSpeed and RollSpeed with IR Midpoint? Any guidance with this would be helpful. Thank you!

@Flafla2 I have the Motion Plus extension added to the Wiimote. How would you integrate the motion plus rotation data with the IR points? Would I combine PitchSpeed and RollSpeed with IR Midpoint? Any guidance with this would be helpful. Thank you!

@andreierdoss I've been tackling this problem for the past week or so... I am getting closer to a solution but I still need to work out some glitches in the rotation solver.
The basic idea is to treat the Wiimote as a rudimentary IMU when the Wii Motion Plus is attached.  So the accelerometer can be used for an absolute frame of reference (when the Wiimote is still) and the Wii Motion Plus can be used for more precise adjustments (but it has the issue of falling out of sync over time).  It is also worth noting that the accelerometer only gives pitch and roll data, not yaw.  You can use the Wii motion plus alone to solve for yaw, and you can "zero out" the yaw when the player points the remote at the screen.

@Flafla2 any luck putting a solution together? Please let me know how I could help.


dd: return UResult from uumain() function

See #2464.
I updated one unit test so that it better matches the behavior of GNU dd in the case where there is no outfile.

I have added a fixup commit making the suggested changes.


To test Dmaas DAO and retention feature in 1.11.0-RC1

This is the new feature in 1.11.0. We need to test this manually and update to dev team. later on, we need to automate the same.

Reference issue
https://github.com/mayadata-io/director/issues/496

There is one issue in dmaas where schedule creation is failing. maya-ui image needs to rebuild to test this feature.
Comment from Rahul
 After schedules route point to files instead schedule-table

The new build for maya-ui is given. Need to test Dmaas in 1.11.0-RC2 build.

Got below issues while testing Dmaas.
1> Got error when tried to create a schedule

2> The retention count is set to 4 but I was able to view 5 Full backup list

3>In Ui got failed status for couple of backups and then the status changed to completed.

4>Retention count is not working for restic based backups. I have configure the count as 5 but it showing more than that.

5>  For minio application using sc openebs-hostpath. I have uploaded the file more than 18 MB but the size is not reflected in the backups

6> It is is this state. It been more than 15 hours since I trigger the restore. It should get failed or some error message should have been shown. There should not be any infinite loop scenario

dmaas-agent logs says waiting for backup to sync
Got error message in velero pod log
time="2020-06-30T14:29:41Z" level=error msg="Error getting backup metadata from backup store" backup=sch-esmaa-20200630142521-20200630142521 backupLocation=newaws-ap-southeast-1 controller=backup-sync error="rpc error: code = Unknown desc = error getting object backups/sch-esmaa-20200630142521-20200630142521/velero-backup.json: NoSuchKey: The specified key does not exist.\n\tstatus code: 404, request id: F2115283DA258AC3, host id: Qr8+NXe9DVEXbIlWesTB5EFmiNM50woUJcW+Pv23xluDKcYIdMHFF+DWZBheu0PvBYiSKKr8XDA=" error.file="/go/src/github.com/vmware-tanzu/velero/pkg/persistence/object_store.go:264" error.function="github.com/vmware-tanzu/velero/pkg/persistence.(*objectBackupStore).GetBackupMetadata" logSource="pkg/controller/backup_sync_controller.go:208"

Closing this issue and created individual issues.


Update Spanish translation (up to 2.5.0)

Update the Spanish translation of wp-cli.org website up to v2.5.0

Thanks for the PR, @YordanSoares !
Sorry for merging this one so late, I had missed the notification when you submitted the PR. Next time, when you submit something as timely as that, don't hesitate to ping me directly on Slack if I'm not acting on it.


Update unmaintained packages

NOTE: All these patches were fetched from monitor.nixos.org and were marked green, which means (AFAIK) that the patch builds.
I did not build them locally, but I will now start building them on a VM I have in my universitys cloud and then report back.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Removed the patches which updated pinned packages.

So far, libva-full and rabbitmq_server failed on my build machine. The other packages are not yet build (I also build the patches from the branch before removing the pinned package update patches).
I will remove the patches which did not build on my build machine as soon as the build is finished.

Failed on my build machine:

libva-full
rabbitmq_server
vlc
impressive
geis
gemrb
graphicsmagick137
graphicsmagick_q16
belle-sip
bluez
bluez5_28

Will remove these commits from the branch now.

Would you mind moving the dbus update to a separate PR? Then I think we can merge.

Removed dbus update patch


Be able to disable flatpickr input

We should be able to prevent toggling of flatpickr when disabled prop is passed
https://github.com/chmln/flatpickr/releases/tag/v1.7.1

This should work right now actually, can you provide an example where it's not working?

Ahh @jacobmischka I see what's going on. Passing in any additional props invalidates disabled
So something like this doesn't work for me:

Ideally I could view the flatpickr's current value but be unable to edit it due to props.disabled

(would love this to be able to be disabled)

Ah, it's because you're using altInput. The new input field that flatpickr creates doesn't get disabled, because the disabled prop is being passed to the original input field (which flatpickr has hidden).
I'm not really sure what the best way to handle this would be, react-flatpickr doesn't really have access to the input field created by flatpickr.
I think your best option if you want that level of control will probably be to not use altInput, but if you have an idea that would make this work cleanly I'd be happy to hear it and reopen this.

Or you can use clickOpens: false and add your own open/close handler on another element, something like this:
        <Flatpickr
          disabled
          options={{altInput: true, clickOpens: false}}
          data-enable-time
          onOpen={() => { console.info('opened') }}
          ref={fp => { this.fp = fp }}
          onChange={this.state.onChange} />
        <button type='button'
          onClick={() => { if (this.fp && this.fp.flatpickr) { this.fp.flatpickr.open() } }}>
          open
        </button>

Unfortunately because of #19 you can't just toggle clickOpens, you need to add your own handler if you want to do it this way.

Hi, are there any update on this issue?

No, controlling altInput is outside the scope of this package. You'll need to either stop using altInput if you want the disabled prop to work or use a custom solution like the one above. Sorry!

oh ok. Can you suggest alternative way to display date in more legible way? Given that altInput is disabled. If possible?

I'd do what I did above and set clickOpens to false and add my own handler probably, or you should be able to set the regular format to be pretty and then access the flatpickr moment object to extract the date. I'm not able to provide a snippet at the moment, I'm not at a computer right now, sorry!

So, I fixed it by using the dateFormat to the desired output format and disabling altInput option.
@jacobmischka  Thanks for the input.

Glad to hear!

https://github.com/coderhaoxin/react-flatpickr/pull/61
Will this PR resolve this issue? Or am I missing something?

I was able to solve this similar to how @s7dhansh did. But instead, just wrapping it in a new component:
class AltInputDatePicker extends React.Component {
  componentDidUpdate(prevProps) {
    if (prevProps.disabled !== this.props.disabled) {
      if (this.fp && this.fp.flatpickr) {
        this.fp.flatpickr.altInput.disabled = this.props.disabled;
      }
    }
  }

  render() {
    return (
      <DatePicker
        ref={(fp) => { this.fp = fp; }}
        {...this.props}
      />
    );
  }
}

kinda janky updating the DOM element directly, but it works without having to rewrite Flatpickr code.

I used this solution and worked with me
const AppDatePicker = ({ onChange, placeholder, value, disabled }) => {
  const inputRef = useRef();
  useEffect(() => {
    inputRef.current.flatpickr.altInput.disabled = disabled;
  }, [disabled]);

  return (
    <Flatpickr
      ref={inputRef}
      style={{ marginTop: "18px" }}
      placeholder={placeholder}
      readOnly={false}
      value={value}
      className="form-control m-0"
      options={{ altInput: true, altFormat: "F j, Y", dateFormat: "Y-m-d", mode: "range" }}
      onChange={onChange}
    />
  );
};

When using a custom render function I had to use the reference to flatpickr's input instead:
useEffect(() => {
    inputRef.current.flatpickr.input.disabled = disabled;
  }, [disabled]);


Enable dashboard alarms deep linking

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the change
Enable dashboard alarms deep linking

@spryor,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Data: Public and Private Option and Settings

Public/Private: We only need this option, if we require authentication from a user.

Public - everything that is public on the Internet should be public.
Private - this option can only be used when we add apps, that require user specific authentication.

Prashant is working on adding apps that require authentication. If a user shares data that requires authentication, the user should stay in control of the data. That means, we can temporally keep the data in loklak, but if the user deletes it from his/her account, others should neither be able to see it.
Follow up to https://github.com/loklak/loklak_webclient/pull/502#issuecomment-132975310

Mail discussions concerning public/private data :
@zyzo:
The use case of private data is different from public data in several ways : the user that imports the data, is in control of the data. That means only that user is allowed to update/delete, allow/prohibit other people from seeing the data. In order to implement these criterias, I believe following code additions are needed :

Add new privacy_status field to MessageEntry, that could be PUBLIC or PRIVATE (PrivacyStatus class is implemented in ImportProfileEntry)
Add visibility boolean field value to MessageEntry. For public data this field is of no use. For private data (privacy_status == PRIVATE), if visibility is set to true, other people can search for the data. Otherwise, only the owner can see the data. (this field can also be created as an enum, for extensibility reason).
Change the message search method in QueryEntry to match these constraints.
As you have a more global view of loklak_server codebase, do you think these changes are appropriate ?

@Orbiter:
I don't know why we need that, but the proposed solution is not flexible enough. This should be solved using a mandant model where each mandant can apply their access right. This enables that once created record can change their access right without actually changing the content of the records itself. The requiremennts would be simple:
add a field 'collection' with empty default value
each mandat has a name which is written to the mandant value
each mandant can write an access right attribute to a new data structure. This should define access rights to groups 'all', 'group' and 'user' (like in unix groups)
each user of the search interface must be identified to be member of none, one or several mandants. This must be trannslated to a filter query to the collection field.

The content of the collection field would not directly denote that a message is either private or public. It would refer to a profile where the profile owner can set the private or public status.
So by default the field collectionshould be empty or NULL to show that there is no collection assigned; such messages should be public.
Then a user should be able to set a collection metadata with a collection name and the collection access status. For each new message  which the user creates, the collection name should be set into the message field collection. The search api must then evaluate that value according to the user`s settings of the collection.


Package isn't working anywhere I've tried it

I've tried this package, both in the REPL and on a local project, on Chromium/Firefox on Linux, and in Chrome on macOS. None of them are trapping focus anywhere.
Am I missing something?

Its been awhile since I've touched it. It could be that I let the sveltekit get stale. I'll look at it sometime this week or next.
Sorry about that.

Hmm, the repl still works in Firefox/Chrome on Mac are still working. With the REPL, if you tab into the text area, it'll reset the context / reload the repl.
Also, keep in mind that it does not lock you into the specific focus group explicitly so you can still tab into the browser chrome (title bar, tabs, etc) rather than hijack keypress.
I may end up deprecating this package though as the current ARIA recommends hijacking the keyboard: https://www.w3.org/WAI/ARIA/apg/patterns/dialogmodal/


Validation fails on required boolean fields when they have valid data

When a required boolean field is set to False, validation fails.  I would expect validation to fail if the field's value was NOT set, or something other than a boolean value.  But a required boolean field should validate successfully if it's set to True or False.
Actual Behavior
Python 3.8.5 (default, Jul 21 2020, 10:48:26)
[Clang 11.0.3 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import wtforms
>>> wtforms.__version__
'2.3.3'
>>> class F(wtforms.Form):
...      foo = wtforms.BooleanField('Has Foo', [wtforms.validators.InputRequired()])
...
>>> f = F(foo=False)
>>> f.validate()
False

Expected Behavior
Python 3.8.5 (default, Jul 21 2020, 10:48:26)
[Clang 11.0.3 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import wtforms
>>> wtforms.__version__
'2.3.3'
>>> class F(wtforms.Form):
...      foo = wtforms.BooleanField('Has Foo', [wtforms.validators.InputRequired()])
...
>>> f = F(foo=False)
>>> f.validate()
True

Environment

Python version:  3.8.5
wtforms version:  2.3.3

Duplicate of #402


add python 3.11 to test matrix

What

adds python 3.11 to test matrix in the testing workflow

How to Test

make sure the CI on this branch runs tests for four python versions, 3.8-3.11

numba (shap dependency, leveraged in logging-feature-plots.ipynb) is not yet available for python 3.11

addressed in #334


Update apt repo GPG key URL

Update apt repo GPG key URL to redirect. Fixes #42144

Thanks @mrgiles
preview looks good to me: https://deploy-preview-42156--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#installing-kubeadm-kubelet-and-kubectl
/lgtm

/sig cluster-lifecycle

/assign @sftim

Thanks
/approve

/sig release


Fix negative duration for a running task on a failed dependsOn

closes #326
The issue is that when a task fails we stop the playbook and show the summary of all processed tasks.
However, some tasks still have state running playbook is closed. The will be displayed in the summary, but because the end time was not updated will show with minus.

Nice explanation + solution :+1:


Typo fix in, L10 line1083

I guess you mean "subspecies", because there is no word about "subpieces"

no, meant subspaces!


disable "keepGenerate.." option when "Scribus" output format is selected

make the "keepGenerate.." label and checkbox disabled when "Scribus" output format is selected, and enabled for any other format.

I cannot find a way to make it work at https://github.com/berteh/ScribusGenerator/blob/93a12de4be28054344533ad8fc424e37180668de/ScribusGenerator.py#L278
test to detect if checkbox should be enabled or disabled works, but state is not updated... or not paint/redrawn accordingly.


Revert "Fix typo"

Reverts docker/distribution#737
This incorrectly fixed the type.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "revert-737-patch-1" git@github.com:docker/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.


Use short neat && instead of if ... else

@bors r+

:pushpin: Commit 7e6be9dc6e38222402a3fd022e71b0cf21abdd20 has been approved by Amanieu

:hourglass: Testing commit 7e6be9dc6e38222402a3fd022e71b0cf21abdd20 with merge 629fa19b871763ed7a1204783765ec78eaf228b1...

:sunny: Test successful - checks-travis
Approved by: Amanieu
Pushing 629fa19b871763ed7a1204783765ec78eaf228b1 to master...