Add image alt text and hover effect

Page title: No issues found
Image text alternatives: Added alternative texts to all images
Text headings: No issues found
Color contrast: No issues found
Resize: No issues found
Interactions: No issues found
Moving content: No issues found
Multimedia: Scaled images to make them larger on hover
The basic structure of the page: No issues found

For the license I didn't add a license when I created the repo.
On Tuesday, December 20, 2022 at 11:37:02 AM GMT+1, TufoinNkuo @.***> wrote:
@tufoinnkuo10 requested changes on this pull request.
Hi @Divinity-dev
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight
✅ You used the correct Github flow
✅ Descriptive pull request message
✅ linter error checks validated
✅ Documented your work professionally
Required Changes ♻
Check the comments under the review

kindly add the license(MIT) section in your README file. nice work
Optional suggestions
_Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In index.html:

@@ -26,7 +26,7 @@
About
Contact

kindly use a professional page tittle eg Mark's portifolio

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

As for the the page title, the correction has been made
On Tuesday, December 20, 2022 at 12:01:03 PM GMT+1, Divine Asiriuwa<EMAIL_ADDRESS>wrote:

For the license I didn't add a license when I created the repo.
On Tuesday, December 20, 2022 at 11:37:02 AM GMT+1, TufoinNkuo @.***> wrote:
@tufoinnkuo10 requested changes on this pull request.
Hi @Divinity-dev
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight
✅ You used the correct Github flow
✅ Descriptive pull request message
✅ linter error checks validated
✅ Documented your work professionally
Required Changes ♻
Check the comments under the review

kindly add the license(MIT) section in your README file. nice work
Optional suggestions
_Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In index.html:

@@ -26,7 +26,7 @@
About
Contact

kindly use a professional page tittle eg Mark's portifolio

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

But I stated the reason I couldn't add a license to my readme file. I said I didn't add license when I created the repo. How do I add license now?
Sent from Yahoo Mail on Android
On Tue, Dec 20, 2022 at 12:54 PM, Tuyishimire @.***> wrote:
@TuyishimireEric requested changes on this pull request.
Status: REQUIRED CHANGES ♻
Hi @Divinity-dev 👋 👋
I'm @TuyishimireEric, Your code reviewer,
You've done well implementing some of the requested changes, but there are still some changes you still need to work on before you move on to the next project but you are almost there!
Highlights
✔ No Linter Errors 👍
✔ Professional PR 👍
Required Changes ♻

As suggested by the previous reviewer Some of the necessary headers are missing in your Readme 😨

I think it would be better to provide a LICENSE link in your README as open source software needs to be licensed to provide rights to modify, distribute other than creator 😂
we recommend using the MIT license - you can set it up quickly by using templates available on GitHub. You can also use any other license if you wish.

Optional suggestions
NA
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Ok. So I just opened the link and it took me to my GitHub account. So if I was to add a file, what's the content to add?
Sent from Yahoo Mail on Android
On Tue, Dec 20, 2022 at 1:12 PM, Tuyishimire @.***> wrote:
@Divinity-dev the license file can be added to a repository anytime, it is just a normal file kindy follow this link to add the license to your repository 🙏
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Bio Weekly - Update Figure 11

Update Figure 11 to include a second trend line showing HealthPartner's weekly number of clinical collections.
The updated Figure 11 should look like/have the same format as Figure 7 (Weekly Biospecimen Collections at Henry Ford).
Requestor(s): Domonique
Table or Figure title: Figure 11. Weekly Biospecimen Collections at HealthPartners
Variables needed (include variable name and Concept ID):

RcrtES_Site_v1r0 (827220437)
BioSpm_Setting_v1r0 (650516960)
BioRec_CollectFinal_v1r0 (410912345)

Specify numerator and denominator by variable name where applicable:

Denominator = All finalized collections at HP - RcrtES_Site_v1r0 (827220437) = 0; BioRec_CollectFinal_v1r0 (410912345) = 1
Numerator = Clinical and research collection settings at HP - BioSpm_Setting_v1r0 (650516960) = 0 [Research] & 1 [Clinical]

Notes: N/A
Approved by:

@KELSEYDOWLING7 HP's first clinical collections were scheduled for this week (today actually), so they should show up in the next report.

@HopkinsDC  Oh ok perfect. Well the code is set up and I'll check on Monday to see if its reflected here. I won't add it to the automation just yet, I'll just check manually and then upload a screenshot here

@HopkinsDC  The clinical collection showed up on today's report. Is this ok to include in the ALL folder report?

@KELSEYDOWLING7 Yes, that would be great. Thank you!

@HopkinsDC  Great! That's been uploaded. Because I had to manually run the report this week, the following issues should be reflected on the report now:
#92
#93
#98

Update successfully implemented in 12/11 weekly biospecimen metrics report.


Can an Interface poll multiple SocketSet now?

For example, I want to use one interface to poll first SocketSet first and then poll second SocketSet, can the interface determine which SocketSet the received packet is from?

Thanks for your explanation.


AQAvit meeting Oct 14, 2020

AQAvit Meeting Oct 14, 2020
Wednesday, Oct 14th 11:30am – 12:00pm (GMT-04:00)
Description: Bi-weekly meeting to discuss AdoptOpenJDK Quality Assurance (AQA) topics.
Join with Google Meet
meet.google.com/ejp-yjon-vec
Join by phone
PIN: 754 815 097#
Proposed Agenda:

Review of PARALLEL modes [None, Dynamic, Subdir, NodesByIterations] with focus on PARALLEL=NodesByIterations - @llxia
Using run-aqa action with JDK main-line - @sophia-guo / @smlambert
Updates to github teams and access - @smlambert
Reviewing existing openjdk-tests issues, closing stale ones, ensure openjdk-tests project reflects activity - @smlambert

Meeting Minutes
PARALLEL=NodesByIterations

Lan demoed the Grinder enhancement which allows users to send X number of iterations of a test to Y number of nodes/machines.  This will allow us to better utilize machine resources (since there is overhead in setup and compilation of test materials, once setup on a machine the ability to tune how many iterations run on it is valuable).

Invoking run-aqa github action from JDK mainline

Sophia showed 2 ways that a JDK developer working in their fork of the mainline can leverage the run-aqa github action by:

directly editing the submit.yml file to invoke any of the AQA test targets (her example showed execution of sanity.system targets)

grabbing the build artifact from your JDK mainline fork and using it in a separate workflow file (in a separate repo if desired), to execute any of the targets in the AQA suite

We will write a blog post with examples to more broadly share how others can take advantage of this

Project Hygiene

Shelley also mentioned some github teams cleanup that is underway, there are 3 github teams related to test:

test-core which is a small set of people who have write access to TKG and openjdk-tests along with the other peripheral test repos (the update here is to limit write access to openjdk-tests repo, as if something is merged there without proper testing, it can break all testing at AdoptOpenJDK, OpenJ9 and several partner site projects.)

test which has triage access to openjdk-tests and write access to peripheral test repos

test-triage which has triage access to all test related repos

additionally reviewing openjdk-tests issues and closing stale ones, will review openjdk-tests project to reflect activity better

Meeting Recording


Maintaining marker size with various pixelRatio values

Fix for issue https://github.com/plotly/plotly.js/issues/3246.
Kindly visit PR https://github.com/plotly/plotly.js/pull/3637 for more information.
@dy
cc: @etpinard

@dy @etpinard OK. The tests are tweaked with half sizes and passed noting that we should maintain sizes identical to (the old use of) pixelRatio=2 in plotly.js baselines. If all is good we may publish a minor and include these changes in the next plotly.js minor.

@dy Possibly any updates on this?
If you still think that this is not the right fix, please let me know. Maybe we could find another way to tweak the API on the plotly.js side?
Thank you in advance.

@archmoj I did not mean to delay, sorry. Yes, I think that now pixelRatio is handled correctly - it scales points up depending on the device or passed pixelRatio. If we remove that support, the regl-scatter2d will render points with 1:1 pixels binding, which makes pixelRatio option useless.
If you want to fix pixelRatio to some value, you can do that externally, that option is exactly for that.

@dy Thank you very much for the follow ups.
In fact we prefer not to pass a constant value there.
Here is (another codepen](https://codepen.io/MojtabaSamimi/pen/yrVoGK?editors=0010) comparing pixelRatio values equal to 1 and 2 that uses current regl-line2d & regl-scatter2d modules. The line widths are identical but the marker sizes are not.

Yep, the problem is on the regl-line2d side. It just doesn't account for pixelRatio. regl-scatter2d works as intended.

Thanks for your hard work @archmoj - your patch appears to make scattergl consistent with how markers are drawn in scatter3d so
As this repo remains in @dy 's hands, we could perhaps make this new/consistent pixelRatio behaviour an opt-in e.g. by adding a boolean flag to regl-scatter2d that we would turn on upon instantiating in plotly.js

Great idea @etpinard.
Applied in https://github.com/gl-vis/regl-scatter2d/pull/20/commits/9c0933a1df175f0bb6ba39a5e71e351e67161f2d.
@dy this should be good to go as tested on plotly side as well as here without any changes to the tests.
Would you mind reviewing it again?
Thanks in advance.

Gentlemen, I can't understand - why passing plotly's pixelRatio at all, if you need that constant? Just initialize regl-scatter2d with {pixelRatio: 2} from any trace and we're good to go, it will behave the same way as the other gl components. It is also shorter than {pixelRatio: plotlyPixelRatio, constantPixelRatio: true}.

, I can't understand - why passing plotly's pixelRatio at all, if you need that constant?

We offer that option to users on static exports (example) - which can make a appreciable difference in the quality of the exported images.

@etpinard that's great option, but no need to pass it to regl-scatter, pass {pixelRatio: constant} instead and that's it. Eg. here
https://github.com/plotly/plotly.js/blob/225521271f2eb7f5803713a28d8a7e0ef16ccc57/src/traces/scattergl/index.js#L116
just add an extra-line
// fix pixel ratio to accommodate other gl-components api
opts.marker.pixelRatio = 2.

@dy Thanks for the suggestion.
Unfortunately it does not seem to help fix the issue : (
Here is a codepen based on the fix you suggested.
Please notice how the markers are getting bigger with greater pixelRatio values.


Add qx install from external URL/file

Add the following ways to install a library:

qx contrib install https://www.domain.org/path/to/mylibrary.zip
qx contrib install file:///home/user/mylibrary.zip

This will allow to use libraries from any location.
See also https://github.com/qooxdoo/qooxdoo-compiler/issues/279#issuecomment-455765841

so while you are at it ... how about making file://home/user/mylibrary work if it is just a directory

https://github.com/qooxdoo/qooxdoo-compiler/pull/366 does it this way:
qx contrib install <uri> --from-path path/to/library allows to use a locally stored version of the contrib
qx contrib install --from-path path/to/library simply adds an "anonymous" (in terms of the registry) library. This could later be aliased with qx contrib install file:///path/to/library, but that's just syntactic sugar.
I am not implementing URL support at this point, since there doesn't seem to be an urgent need for it.

Partially implemented with #366 . https:// installs can go into separate issue, if there is demand.


Exact location

We see "GEOPOLITICAL INFORMATION" and the options to choose a country/region w narrative, we are unable to spot the field where we can add and exact geo-location for an activity. Is this hidden or not available?

Hi Siem, have you checked "Location" in the settings under "Choose elements to show/ hide"?
https://aidstream.org/settings
There should be a separate link "Location" under "Geopolitical information" in the right-hand column then.

Aha!
Thanks @rolfkleef , could you also tell me if all IATI fields are availble yet?

I don't know about that, I think it was discussed in a check-in call. Maybe specify what you miss under that issue (#31) and we could discuss the roadmap in the next call (scheduled coming Wednesday).


GDEV-72 - FastAPI boilerplate

Please have a look at the example on how to use it:
https://github.com/ghga-de/ghga-service-chassis-lib/tree/feature/rest/examples
This PR also includes changes from #2. You might such review #2 first.

Hi @deepakunni3, thanks for testing it. No I am not getting that error nor does the CI (which is also running these tests).
How are you running the tests? Are you using the devcontainer?

@KerstenBreuer can you please resolve the conflicts so that we can merge this branch?

@alamgirmani, thanks for the reminder. The merge conflicts were fixed. Let's wait for @deepakunni3 to follow up on the error he reported and then we can merge it.

Yes, can confirm that the errors are not there when running in a dev container


Start command platforms, devices, and emulators fixes

If corber/cordova/package.json is not available, uses config.xml to determine available platforms.
Shows an explicit error if no platforms are available.
Removes extra emulator arg from call to list Android emulators.
Updates promise flow in run() method of start command, cleans up error logging.
Updates corber-error object.

Rebased to include config.xml fallback test.


'defines' are activated with inverted booleans

Hi Jetiny,
According to the documentation, given the below options:
{
  defines: {
    IS_SKIP: false,
    IS_REMOVE: true,
  }
}

The below input should produce the below output:
input
// #if IS_SKIP
  console.log('!Skip!')
// #endif
// #if IS_REMOVE
console.log('!Remove!')
// #endif

output
// #if IS_SKIP
  console.log('!Skip!')
// #endif

However the real behaviour is the opposite. In order to produce the output above described the configuration should be:
{
  defines: {
    IS_SKIP: true,
    IS_REMOVE: false,
  }
}

Actually I think the real behaviour is more intuitive than the one explained on the documentation. So the fix would suffice by just updating the documentation.

Oops! Some wrong code was given mistaken results. Your code and documentation is perfectly fine! Closing this ticket.

Sorry Jetiny, but after further testing it looks like actually, yes, the defines are activated in the opposite way. Could you double check this behaviour?

Sorry Jetiny, but after further testing it looks like actually, yes, the defines are activated in the opposite way. Could you double check this behaviour?

I have the same problem...


Feature Request: Generate polygon with given points

Thank you guys for this amazing Sceneform.
I have some points in the world coordinate system. I want to use this points as vertices to generate a polygon.
By giving you some points(count must be >= 3), could you please generate a polygon(irregular-shaped polygon)?

You can create a Renderable from a set of vertices by using the RenderableDefinition API.


Add Multi Column Values to influxDB

I use JMX-Agent GraphitePlainTextTcpOutputWriter.java writing values into influxDB, but I find just insert one column, and I see the Graphite demands the Message Format is "metric_path value timestamp\n". So how could I insert multi column into influxDB.

The graphite protocol does not support multi-field data (in InfluxDB terms). But the InfluxDB graphite input in version 0.9.1+ does allow for defining a template, so you can add tags (which are "columns", too). So it depends on what you mean with "colums", maybe give an example of what you're trying to achieve.

I'm closing this. The proper solution is to implement native Influx support - #24.


Revert back to original documentation

Revert back to Phinx documentation until the cake documentation is sorted out?
IMO, the Phinx documentation should be standalone and not be included alongside all of the CakePHP documentation. The Cake documentation also doesn't have a phinx-specific search, which makes it much more difficult to find what you're looking for.
Is there a specific reason why we can't stick to the original Phinx site anyway?

Codecov Report

Merging #1219 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1219   +/-   ##
=======================================
  Coverage   72.19%   72.19%
=======================================
  Files          35       35
  Lines        5549     5549
=======================================
  Hits         4006     4006
  Misses       1543     1543

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa84c8...32d0718. Read the comment docs.

I think we can just merge the whole sphinx documentation into a single page, so you can search the page using your browser search function.
One of the reason to have it in the same place is (apart that it is easier to deploy) that in the newer future we will be using the cake database layer. So looking for its documentation will make sense there as well.
Do you think having the whole docs in a single page would help with the search?

@lorenzo Yes, single page could work as a solution - if you're happy with that? Another issue for me is the left nav - https://book.cakephp.org/3.0/en/phinx.html - all related to Cake framework. Isn't helpful and is cluttered for users who do not use Cake

@JayPHP we are considering having a different book installation for each "plugin" in cake. So I guess sphinx will be covered by that soon. For the time being a single page doc is the way to go imo. Would you like to do that?

no worries


Last character NOT showing when typing password/obscure on iOS only

Steps to reproduce

Create default project
create TextField
set obscure to true
Run on iOS
type anything

You'll notice that the last character is not displayed when you type your password.
Is this the expected behavior on iOS?
Expected results
I was expecting it to behave as usual on mobile (showing last typed character [on mobile] for a short moment during password input) as discussed at this PR: https://github.com/flutter/flutter/issues/51218
Actual results
Android works as expected but iOS don't.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {

    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: const Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            TextField(
              obscureText: true,
              decoration: InputDecoration(
                border: OutlineInputBorder(),
                labelText: 'Enter your password'
              ),
            ),
          ],
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
iOS

Android

Logs
No response
Flutter Doctor output
Doctor output
✓] Flutter (Channel stable, 3.19.1, on macOS 14.3.1 23D60 darwin-arm64, locale pt-BR)
    • Flutter version 3.19.1 on channel stable at /Users/fernandorocha/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision abb292a07e (2 days ago), 2024-02-20 14:35:05 -0800
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/fernandorocha/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.15.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.86.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.82.0

[✓] Connected device (3 available)
    • Fernando R (mobile)    • 00008120-000C38393C68C01E            • ios            • iOS 17.3.1 21D61
    • iPhone 15 Pro (mobile) • 2C6891FC-C0D4-43FC-8A12-6B27AE4606E1 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 121.0.6167.184
    ! Error: Browsing on the local area network for iPad. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Thanks for the report!
This is a known issue being tracked at https://github.com/flutter/flutter/issues/115359. Closing this issue as a duplicate, so please follow up on it for further updates.


Saved applications contains the applications saved by all users rather than only the logged in user.

@tahreemm Added functionality to fix this. Works on my end.

Working on my end tested again @shaziamuckram so closing the issue


--config=cuda overrides explicit options, instead of augmenting them

Please:

[x] Check for duplicate issues.
[x] Provide a complete example of how to reproduce the bug, wrapped in triple backticks like this:

import jax.numpy as jnp
print(jnp.arange(10))
# [0 1 2 3 4 5 6 7 8 9]

[x] If applicable, include full error messages/tracebacks.

I am trying to build cuda-enabled jaxlib on conda-forge. I am running into a problem where the --config=cuda flag replaces the custom toolchain. I understand this is outside the scope here, but getting cuda-enabled jax on conda-forge seems to be a very valuable contribution, and I hope you can help us achieve that. We do build cuda-enabled tensorflow, and we follow our method almost exactly. The option --config=cuda works fine in our tensorflow builds.
WARNING: option '--config=cuda' (source command line options) was expanded and now overrides the explicit option --crosstool_top=//bazel_toolchain:toolchain with --crosstool_top=@local_config_cuda//crosstool:toolchain

Once the above happens, the local_config_cuda parameters essentially cannot see any of the system libraries and everything  breaks. I haven't looked too deeply into this yet, so bringing it here first in case you have a quick answer/shortcut.
Corresponding PR in conda-forge: https://github.com/conda-forge/jaxlib-feedstock/pull/97
Tagging @hawkinsp who's been involved in issues related to the builds before. Thanks!

I believe I have managed to patch it successfully, but I will keep this open for now. I will update the conda-forge PR with details.

@yashk2810 could you take a look?

What command did you use to build jaxlib?

something like:
python build/build.py  --bazel_options=--crosstool_top=//custom_toolchain:toolchain --bazel_options=--cpu --enable_cuda

More verbosely,
  ${PYTHON} build/build.py --target_cpu_features default --enable_mkl_dnn ${CUSTOM_BAZEL_OPTIONS} --bazel_options=--cpu --bazel_options=${TARGET_CPU} --bazel_options="--local_cpu_resources=${CPU_COUNT}" ${CUDA_ARGS:-}

with the various expansions:

CUSTOM_BAZEL_OPTIONS="--bazel_options=--crosstool_top=//custom_toolchain:toolchain"

CUSTOM_BAZEL_OPTIONS="${CUSTOM_BAZEL_OPTIONS} --bazel_options=--logging=6 --bazel_options=--verbose_failures --bazel_options=--toolchain_resolution_debug --bazel_options=--define=PREFIX=${PREFIX} --bazel_options=--define=PROTOBUF_INCLUDE_PATH=${PREFIX}/include"

export TF_CUDA_COMPUTE_CAPABILITIES=sm_35,sm_50,sm_60,sm_62,sm_70,sm_72,sm_75,sm_80,sm_86,compute_86

CUDA_ARGS="--enable_cuda \
               --enable_nccl \
               --cuda_path=$CUDA_HOME \
               --cudnn_path=$PREFIX   \
               --cuda_compute_capabilities=$TF_CUDA_COMPUTE_CAPABILITIES \
               --cuda_version=$TF_CUDA_VERSION \
               --cudnn_version=$TF_CUDNN_VERSION"

see recipe/build.sh in the above PR: https://github.com/conda-forge/jaxlib-feedstock/blob/009b2fe3f774570476da47fac0479d05c9ded67a/recipe/build.sh

Here how I see it:

--enable_cuda triggers --config=cuda in build.py
--config=cuda is passed as command-line arg to bazel
in bazelrc, --config=cuda sets a toolchain for the nvcc compilation
that in turn results in this: WARNING: option '--config=cuda' (source command line options) was expanded and now overrides the explicit option --crosstool_top=//bazel_toolchain:toolchain with --crosstool_top=@local_config_cuda//crosstool:toolchain
this override results in our custom_toolchain getting ignored completely (thus missing system libs, etc.)

The breaking point imo is that --crosstool_top=@local_config_cuda//crosstool:toolchain should be augmented (since it is only for the nvcc compilation anyway) and not completely override what the user wants. I have no idea if this is something that's set here or elsewhere, but it is worth looking into, especially vis-a-vis tensorflow build.

The arguments to bazel are ordering sensitive. I'm wonder if the fix would be to reorder the arguments here:
https://github.com/google/jax/blob/7d4d15e260e24c54f9fbc1685a45d910edb61e43/build/build.py#L493
so that the user-provide --bazel_options override --config=cuda (i.e., come later), rather than the other way around?

so that the user-provided --bazel_options override --config=cuda (i.e., come later), rather than the other way around?

I attempted a version of this and it didn't work, but there is a good chance I did it badly/wrongly...

Another thing you can try is to add things at the end to .jax_configure.bazelrc (Make sure you are adding your custom things at the end of the file -- not the python file but the .jax_configure.bazelrc file.)


font stability

this is concerning: mac has a very wonky first run (or first few runs?), so I built this

https://arkenfox.github.io/TZP/tests/fontstability.html

You should run this with RFP off, and IDCare about TB, just use Firefox, so we cover the most fonts. The list is the same regardless: I just merged all the various lists per OS and de-duped and sorted. I am not checking all those "faces", we can reproduce instability in mac without those, and they may muddy the waters
Here is my windows on a cold app load: i.e open app, sanitized cache etc (I don't think sanitizing matters), and the very first site loaded is the test, which auto runs the first test - than manually re-run until stable

This is surprising, and hints at some sort of lazy/async loading. Maybe a bit like the fallback char mapping where it renders as tofu and catches up later.
The diffs are from the previous result, and are split into new (in the new result) and missing (in the new result)

I cold loaded, went to two websites: a twitter feed and LW matrix room, then loaded the test and it was stable first pop
I cold loaded the app again, waited 30 seconds, went to the test index then to the test and got a different result
RUN2 1 27cbaa83
"new:Arial Narrow, Calibri Light Italic",

I wonder if a dummy run with no dimension measuring before a font test would fix this - just on page load. Note; apparently the font fallback test is also wonky, at least on mac (and after multiple reruns on font test and font fallback test): not too worried about it, but it would have been handy to use that for diffs with the holy grail,
I also wonder if I can repro on creepy fonts tests (will have to check if has Arial Narrow, Arial Black, Calibri Light*, etc).

Win11 Nightly

MacOS Beta (browserstack)

Win11 ... but do you have Arial Black, Arial Narrow, Calibri Light*
https://bugzilla.mozilla.org/show_bug.cgi?id=1670199

Arial Narrow (does not come with windows, but comes with at least MS Office)
Calibri Light + Calibri Light Italic (optional win7 MS update) [1]

There's definitely something going on with these optional system fonts. They end up added to the font family (i.,e you ony have one Arial in windows/fonts, and it holds all these

black, bold, bold italic, italic, narrow, narrow bold, narrow bold italic, narrow italic,  regular

And they're not false positives (narrow/black) because I do have them and others that don't never have them detected.

Arial Black, Arial Narrow, Calibri Light

Got all, but Arial Narrow. Actually, Arial Narrow is on the OS, but not detected in Firefox. I used the MS installation tool to create the build. It comes with the MS Office app, but no MS Office 365 desktop apps or the like.

https://github.com/arkenfox/TZP/commit/d441126c7901542ef451276de28d8a3a2548a25d
so using my file:// scheme, I can consistently get an unstable first run in the test. On TZP I cannot get any instability - which is why I have never noticed it - this whole thing started because of mac instability BTW.
In the test, I have to be really quick, load FF, quick paste into URL bar, hit enter.
Once I added a setTimeout, which TZP has many of before the font test is run, I can no longer replicate. This however, does not fix the mac or underlying issue which I suspect is a timing/async/lazy loading font map thing

Arial Narrow .. ugh, one problem at a time :)

https://github.com/arkenfox/TZP/commit/d441126c7901542ef451276de28d8a3a2548a25d
actually, that makes no difference, and why should it. Doh. I actually think this is a delay caused by the OS reporting back to the app what fonts are available. I can reproduce easily (100%) on a cold portable - I have 50 odd portable FF's here. But then it gets harder to reproduce if tried again and again. But give the app a little downtime and it gets easier.
I guess the thing is, if fxbrit can reproduce easily on mac, then all that needs to be done is to see what could be run first to stop it - such as a priming run, or first adding a a for each font - offscreen - like I did for the unicode glyphs. Perf and especially reflow may be an issue

I've narrowed this down. It's absolutely the app and how it lazily loads some fonts - AFAICT, there is no hard and fast rule as to how a font is handled, e.g. supplemental, font-family, initial, lazy - which would explain Arial Narrow and not Arial Black for example (both are inside the single Arial font-family file on windows) or Calibri Light (which is it's own font-family file, not inside Calibri). Font OS mapping, GDI etc is a mystery to me and I don't have 5 years to learn about it
So as you know, I have like 50 firefox portables with test profiles, and an older machine. ANd it's actually very easy for me to clear system caches, system memory to make a FF version load slow - takes 2 or 3 seconds to render and become usable - like if you had just booted the system
And I can test so fast, that I can usually paste the test file:// URL into the address bar and hit enter before the toolbar icons are rendered, and the test file:// URL is going to be faster than a live website. So I can 100% always reproduce instability
So I tested, bisecting until I found it started in FF90 - windows, super cold FF app, pasting and requesting file:// test even before toolbar icons populating
FF90

1707655 Move the activation of supplemental fonts on macOS to a separate thread and try to get it started earlier
1708768 Defer initialization of gfxPlatformFontList until really needed, to allow more time for the RegisterFonts thread to run

debug sPlatformFontList ?
I wonder what fonts on each platform are lazy loaded
gfx.font-list.lazy-init.enabled // renamed to omt (off main thread)
gfx.font-list-omt.enabled // false on windows FF90+

1708768 seems to indicate this was done for all platforms, and then the last patch (of the three) renamed the pref just for macOS. So I'm not 100% sure WTF is going on, because there's definitely some change in windows.
That pref is still around and default false on windows, and default true on mac. Look for it in searchfox if you want. Flipping it to false on macOS (just for testing, it's an old pref that hasn't moved for 13 versions and may cause weird bugs) might show that this is the cause on macOS. I obviously can't flip it on windows
So, waiting for the 🐟 fxbrit to reliably get instability and a list of fonts. And then he could test flipping that pref, even if he had to go back to an ESR91

also, the omt font list timing can differ per user, based on number of fonts = e.g. 1688951
One question I have is how/when the "full" font list update. Is it when the omt list is done (soon after app start), or is it on demand, or on demand for each "omt" font? Can I get a list of omt fonts?

AFAICT, there is no hard and fast rule as to how a font is handled, e.g. supplemental, font-family, initial, lazy

so 1773752 the patch is interesting, re font dirs, e.g. noto fonts, supplemental
there are no such dirs in windows, it's just /windows/fonts/

just to keep the info in this thread up to date as well, I've been testing on macos:

89, 90, ESR91, 92 -> they all look the same with 40 fonts in the diff
100, 101, 103 ->  they all look the same with 41 fonts in the diff
ESR91.10 -> a single font in the diff
omt does nothing
setting gfx.font_loader.delay to 0 sends all the diffs to 0, except ESR91.10 which stays the same

gfx.font_loader.delay: this is 60000 on windows, what is it on mac - just interested
I will dig deeper into this, including 1284993, as to how it works exactly
gfx.*delay - I only see 3 and all three are listed in that bugzilla

now we know the cause, testing these no longer matters: we can't change them: we need to work around them

ESR91.10 -> a single font in the diff

what is that font? sounds like a different issue, and we could just exclude it from the lists as a known unstable item

So moving forward, I need to check a few things. I'd like to know when the delay ends and when the system fonts are updated to be available to web content. Let's say the timeout is 6 seconds, is this just from when the app boots and system fonts are updated regardless of web traffic etc, in a timely fashion
We could test this, (default prefs) by loading FF, waiting 30 seconds and then testing. If fonts are then stable, then this is not something we can really do anything about, or should - it's edge case?. If fonts are still unstable, then maybe we can nudge it to update by doing a priming run (and assuming 6 seconds have passed?). If the priming run fails, can we hardcode one of the known fonts to render in the HTML - as page content happens before scripts run. If that all fails, then we can just mark all those fonts as assholes and exclude them from tests?
 Then I think this is just a known limitation that we can't do anything about. Would you agree?

yes, I think this is just the intended behavior of the browser. at least we know nothing is broken and also not to trust flawed results when testing fonts.

Indeed, all tests face the same issue. We've only landed on it because 1) you have a mac and 2) when testing we (and you) flip open a new session and are fast to load a test

and also not to trust flawed results when testing fonts.

Well, to at least know ourselves that we should wait 8 seconds minimum

Avenir Next Demi Bold may come right in ESR102 (changes to SDK's, a bug fix? IDK) - in which case maybe it stays, since old releases become edge cases

* there exist more delay prefs (look for `gfx.*delay`) I haven't tested

FYI - 1786210 FF105+ gfx.font_loader.interval removed, it was a dead pref

also - https://bugzilla.mozilla.org/show_bug.cgi?id=1786209#c1

that explains why we only saw the delay in older ESRs, thx!

ESR102 doesn't have the one font diff anymore 🎉

and that font diff was Avenir Next Demi Bold right?
I am in the process of hooking up isTZPSmart (all engines) and isTZPSmartMinVer (min FF and TB version) is upped to v102, then no one cares
when not smart, TZP just reports the values returned: no lie detection/bypasses/notifications whatsoever. Fonts are also only isFF
	isTZPBlock = false,
	isTZPBlockMinVer = [78, 10], // [FF, TB version]
	isTZPSmart = false,
	isTZPSmartMinVer = [91, 91, 11], // [FF, TB, TB version]

	// block/smart
	if (isFF & isVer < isTZPBlockMinVer[0]) {isTZPBlock = true // block old gecko
	} else if (isEngine == "edgeHTML") {isTZPBlock = true // block edgeHTML
	} else if (isTB && isVer >= isTZPSmartMinVer[1]) {isTZPSmart = true // minTB
	} else if (isFF && isVer >= isTZPSmartMinVer[0]) {isTZPSmart = true // minFF
	}
	// note: everything else is dumb: we can add blink/webkit or brave later

I treat TB differently, because they can seriously lag in getting out a new stable based on ESR
so here I can set any browser to block based on any parameters (such as engine, FF version, isBrave, isTB etc), and if not blocked, then it's dumb by default: so I can switch on gecko as smart for starters, add isBrave later, maybe blink.
switching on isBrave will be fun: I can just hook up isBraveMode to every applicable metric and return lies.


feat: Pre-commit hooks for linting and tests

Is your feature request related to a problem? Please describe.
Currently, there is a lack of testing and linting enforcement before committing code, which can result in unsupervised code being pushed and have detrimental effects on code quality and the code review process.
Describe the solution you'd like
I propose adding a pre-commit hook that includes running test scripts and performing linting checks on the codebase. To optimize the linting process for the growing codebase, we can leverage the 'lint-staged' npm package. 'lint-staged' enables us to selectively lint and fix only the files that are staged for commit, reducing potential delays caused by the entire codebase's linting. By implementing this pre-commit hook, we ensure that testing and linting are enforced before code is committed, leading to improved code quality and a more effective code review process
Acknowledgement

We thank you for your valuable contribution and would like to acknowledge it
on our contributors page. To help us with that, we would like
to kindly request that you help us with this by commenting on this issue with
a request to the @all-contributors bot of the form
@all-contributors please add @YOUR_GH_HANDLE for TYPE_1, TYPE_2, ..., where
TYPE_1 etc. refer to contribution types supported by the All Contributors
Specification, e.g., idea.

@git-anurag-hub Since Turborepo already has a caching feature, it doesn't matter if we run lint command for all the files or not, in that case, staged-lint would be a redundant layer imo. Is that right? if so a simple turbo lint and turbo test scripts in the pre hook should do the job or does the staged-lint path seems more appropriate ?

@JaeAeich: Well, if you are not a regular developer and you only check out the repo for a small fix, you'd have to run the linting for all packages. Still, I tend to agree. If the repo ever gets so big that it becomes a problem, we can still change that. So probably best to keep it agile here :)

Yeah agree with @uniqueg, you can just run npm run lint & npm run test as the pre-commit hook & it will do the thing ig!

@uniqueg @git-anurag-hub Just a question do we assume that the developer has already cached a dev instance by running npm run dev before committing any changes otherwise, since the dependencies need to be active when running the lint and test script otherwise the process will fail. If so, this would just be a matter of adding the lint and test script to the pre-commit hook else we might need other dependencies.

From my PoV: As long as such assumptions are documented, I think that's totally valid.

In that case, I'll update the concerning REAMDE and create the PR.


redo API

var nanorouter = require('nanorouter')

var router = nanorouter()
router.route('default', function (params) {
})

router.route('/foo/:bar', function (params) {
})

router.match(window.location)

Base it on prototypes - and that's it I think :sparkles:

why route instead of on? (I like on since it's sort of like an event emitter -- we're going to trigger this function when this event happens.  Its just that the event is the browser's URL being changed)

For API parity with server-router mostly, I was thinking
On Wed, Jun 28, 2017, 18:08 Todd Kennedy<EMAIL_ADDRESS>wrote:

why route instead of on? (I like on since it's sort of like an event
emitter -- we're going to trigger this function when this event happens.
Its just that the event is the browser's URL being changed)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/yoshuawuyts/nanorouter/issues/6#issuecomment-311708473,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlel431qaolkluFDmiUc5vE9pA46LNks5sInprgaJpZM4OIFEb
.

Also on might imply multiple handlers would be called if you defined them, and I assume that's not the case (though maybe?).
The use of default as a route like that feels smelly to me, but not sure what to propose instead and you may have already thought about this. What if the way you defined the default route was to define a .route('*', ...) route at the very end? In theory that would work with no code changes, and is thus less API to memorise. Right? Or would it be called in addition to matched handlers..

Oh, I like the wildcard thing - def makes sense (:
On Thu, Jun 29, 2017 at 1:45 AM Tim Wisniewski<EMAIL_ADDRESS>wrote:

Also on might imply multiple handlers would be called if you defined
them, and I assume that's not the case (though maybe?).
The use of default as a route like that feels smelly to me, but not sure
what to propose instead and you may have already thought about this. What
if the way you defined the default route was to define a .route('*', ...)
route at the very end? In theory that would work with no code changes, and
is thus less API to memorise. Right? Or would it be called in addition to
matched handlers..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/yoshuawuyts/nanorouter/issues/6#issuecomment-311822691,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWleo7B0nePacFYgzC1vLzoI6S4Si1xks5sIuWsgaJpZM4OIFEb
.


Move service calls to persistent connections

http://docs.python-requests.org/en/master/user/advanced/
Requests sessions will use a persistent HTTP connection, so I should get the HTTP requests to be low overhead

done as of ac828deb


[BUG] - Double check occupancy & time thresholds

There's is maybe a bug / issue with using the time_threshold in occupancy computations - that presumably relates back to create_position_df (where the time_threshold is applied).
Notes:

need to add explicit tests for time thresholding
double check how this gets enacted when doing trial level (compute_trial_occupancy)

I don't think there was actually bug in the time threshold, it was just sorta confusingly described.
This topic is now addressed in #185 so I'm going to close this here so that future discussion can move there.


feat: Skip running setup_for_CMAQ

Description
Add option to not run the setup_for_cmaq step during the CMAQ preprocessing step. This is useful for monthly runs where the cmaq data has already been calculated.
I don't think we need the MCIP output anymore in that case which is great as that can be 100s of GB to download.
Checklist
Please confirm that this pull request has done the following:

[ ] Tests added
[ ] Documentation added (where applicable)
[ ] Changelog item added to changelog/)

Notes

This solution is a workaround to avoid needing to modify the workflow definition for any half run daily workflows.  Long-term the setup for cmaq and template file generation could be different steps. That would be more prescriptive of what is run.

This might need to be modified or backed out as it's hard to test this without running and seeing what breaks

Right, I was going to comment that you needed the MCIP output but not CMAQ


Markdown blockquote support missing from CSS files

It doesn't appear that any of the css files define the blockquote layout, and as a result it isn't marked up at all.
I'll try to add the fix in later today/this week when I'm at home and push it over; I'm just writing this down for posterity now.

Markdown formatting is handled with "Pagedown" a js based markdown converter:
https://github.com/brittohalloran/notestack/blob/master/js/stack.js#L85
Here's where it's used:
https://github.com/brittohalloran/notestack/blob/master/js/stack.js#L642
Does the "marked-down" html have the proper blockquote tags? If so they you're right, it's the CSS, if not then it's the markdown conversion.

Good find - switch the order of the stylesheet in your branch and see if it
messes anything up much. I've tried to keep structure in structure
(position, height, width, padding, margins...) and style in themes (colors,
fonts, borders, shadows, gradients) but I may not have been 100% strict on
that.
Lets start with the stylesheet re-order, because the css reset (as you
said) is going to destroy the layout and require a lot of work to
incorporate. Another option, which the HTML5 boilerplate team took, is a
CSS normalization - http://necolas.github.com/normalize.css/
Britt
On Tue, Dec 6, 2011 at 9:50 AM, eykanal <
<EMAIL_ADDRESS>
wrote:

I checked using FireBug; the blockquote tag is present, it's just not
being styled.
Interestingly enough, I found another small problem while styling the
page; you have the following in <head>:

This caused problems, because I was trying to add padding to the
blockquote, and the structure.css file - which was read second, and thus
overrode my changes to themes.php - contains the lines *{ margin:0; padding: 0; }. I'd suggest two things:

simply move the call to themes underneath structure, so that themes can
override structure if necessary (as in this case)
try out eric meyer's css reset and see how badly it messes up
the site structure. While initial incorporation can be a real pain in the
behind, it can significantly reduce cross-browser inconsistencies.

I'll try these things at home later and push any resulting changes.

Reply to this email directly or view it on GitHub:
https://github.com/brittohalloran/notestack/issues/16#issuecomment-3033913


skywalking debug

2020-09-30 16:13:08,860 - org.apache.skywalking.oap.server.core.storage.model.ModelInstaller -62577 [main] INFO  [] - table: alarm_record does not exist. OAP is running in 'no-init' mode, waiting... retry 3s later.
2020-09-30 16:13:11,863 - org.apache.skywalking.oap.server.core.storage.model.ModelInstaller -65580 [main] INFO  [] - table: alarm_record does not exist. OAP is running in 'no-init' mode, waiting... retry 3s later.
2020-09-30 16:13:14,866 - org.apache.skywalking.oap.server.core.storage.model.ModelInstaller -68583 [main] INFO  [] - table: alarm_record does not exist. OAP is running in 'no-init' mode, waiting... retry 3s later.
2020-09-30 16:13:17,868 - org.apache.skywalking.oap.server.core.storage.model.ModelInstaller -71585 [main] INFO  [] - table: alarm_record does not exist. OAP is running in 'no-init' mode, waiting... retry 3s later.

Don't know what do you mean.


congrats on latest release!

I know you put a lot of work into supporting amazon.com so just wanted to thank you!  Been waiting for this! :)

@Skrell Thanks!


Multiple helm sources: skipping app of type '' because it's not of supported source type

Describe the bug
The problem is that when you store helm values files in a separate repo you use spes.sources instead of spes.source in your Application manifests. Thus instead of sourceType  string in application status we will have sourceTypes array.
status:
  sourceTypes:
  - Helm

Unfortunately argocd-image-updater check for sourceType only:
https://github.com/argoproj-labs/argocd-image-updater/blob/49825ec4df76b3d2571515525ac71b83efd30acc/pkg/argocd/argocd.go#L520-L533
To Reproduce
Replace values surrounded by << >> and create Application with 2 sources and follow the logs:
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: test
  namespace: argocd
  annotations:
    argocd-image-updater.argoproj.io/write-back-method: git
    argocd-image-updater.argoproj.io/image-list: test=<<REPO_URL/test>>
    argocd-image-updater.argoproj.io/test.force-update: "true"
    argocd-image-updater.argoproj.io/test.helm.image-tag: deployment.image.tag
    argocd-image-updater.argoproj.io/test.helm.image-name: deployment.image.repository
    argocd-image-updater.argoproj.io/test.update-strategy: latest
    argocd-image-updater.argoproj.io/test.allow-tags: regexp:(tested-dev-)
spec:
  project: default
  sources:
    - repoURL: <<rREPO_URL>>
      chart: test
      targetRevision: 0.1.0
      helm:
        releaseName: test
        valueFiles:
          - $values/dev/values/test.yaml
    - repoURL: "git@github.com:<<YOUR_ORG>>/gitops-backend.git"
      targetRevision: HEAD
      ref: values
  destination:
    server: "https://kubernetes.default.svc"
    namespace: dev
  syncPolicy:
    automated:
      prune: true
      selfHeal: true
      allowEmpty: false
    syncOptions:
      - Validate=true
      - CreateNamespace=true
      - PrunePropagationPolicy=foreground
      - PruneLast=true

Version
0.12.2
Logs
time="2023-04-24T08:48:37Z" level=info msg="Processing results: applications=0 images_considered=0 images_skipped=0 images_updated=0 errors=0"
time="2023-04-24T08:50:38Z" level=warning msg="skipping app 'test' of type '' because it's not of supported source type" application=test

I have the same issue, thanks for reporting it @admssa
Until this problem gets fixed, the only thing we can do in order to continue using the image updater with helm is to use only one source repository in the application manifest.

Thank you for reporting!
We have the same problem

Same problem here. Pretty important for us as it breaks our preferred development flow.

Any news on this one?

What's the status on this one? We would really like to be able to use a common helm chart and the image updater together and this is blocking.

First time today wanted to play with image-updater , but we also plan to use multiple sources : (((

Tested @deferraz PR#578 by building image from feature branch. However, sources worked, but only with argocd-image-updater.argoproj.io/write-back-method: argocd.
If the first source is helm repository, it cannot push file to git. I further edited the code to try override repoURL (I can imagine adding an annotation to specify to which repository to push the image updater source file). The file was pushed to git (you also need to specify spec.sources[0].path so it is placed to correct location in git. This could possibly be set by annotation when using helm? as path is "ignored" as described in ArgoCD documentation). However, even after file is pushed with correct image and tags specified in annotations, the image is not changed in application, no error shown.

@filipprosovsky , I opened this PR #636 that may help with the "git" write back method. Just let me know if that helps.

Hi.
It's there any workaroun to make multiple sources work with this tool?

2024 here :)
I see a fix was merged to master - any news on when it will be released as a stable version?

Any news?

any news ?

looking forward for that fix.

Checking in as well. Can see that PR #636 is merged. Does that cover all the needed use cases? Is there a release where this functionality is targeted?

Update please?

A new release has been published a few days back, please check if it solves for you. For me, the fix is working!

Hi @mecsys , could you please share application example that works for your scenario. Because for me when values.yaml file with tag field is in separate repo I got error like described in the issue

@zagr0
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: podinfo
  namespace: argo-cd
  annotations:
    argocd-image-updater.argoproj.io/image-list: podinfo=ghcr.io/stefanprodan/podinfo:6.x.x
    argocd-image-updater.argoproj.io/podinfo.helm.image-name: image.repository
    argocd-image-updater.argoproj.io/podinfo.helm.image-tag: image.tag
    # argocd app strategy
    argocd-image-updater.argoproj.io/write-back-method: argocd
    # git strategy
    # argocd-image-updater.argoproj.io/write-back-method: git:secret:argo-cd/argocd-repo-creds-ops-mecsys
    # argocd-image-updater.argoproj.io/git-repository: git@github.com:mecsys/mecsys-gitops.git
    # argocd-image-updater.argoproj.io/git-branch: main:image-updater{{range .Images}}-{{.Name}}-{{.NewTag}}{{end}}
spec:
  destination:
    namespace: podinfo
    server: https://kubernetes.default.svc
  project: infra
  sources:
    - chart: podinfo
      repoURL: https://stefanprodan.github.io/podinfo
      targetRevision: 6.5.1
      path: infrastructure/production/apps/ # this is for image updater to know where to store the .argocd-source-appName.yaml file.
      helm:
        releaseName: podinfo
        valueFiles:
          - $values/infrastructure/production/infra-values/podinfo/values.yaml
    - ref: values
      repoURL: git@github.com:mecsys/mecsys-gitops.git
      targetRevision: main
  syncPolicy:
    automated:
      prune: true
      selfHeal: true
    syncOptions:
      - CreateNamespace=true

@mecsys , thank you! It becomes more clear now. I see it still works with parameter overrides, but my expectations were to have changes commited directly in values.yaml file in the image.tag

Hi @zagr0 ,
I think that the annotation "argocd-image-updater.argoproj.io/write-back-target: helmvalues" is missing in the configuration. This annotation is used to specify the values file you want to use for the writeback.
I checked the argocd-image-updater documentation for release v0.13.0 and it seems that it's not updated with the changes of the PR #636 . This is a direct link to the file of that PR with the "helmvalues" documentation. I hope this helps.
Cheers!

Hi @askhari , thank you! I tried it, but it leads to error: "Could not update application spec: could not find an image-name annotation for image foo/bar". Hoping this issue should be a fix for that

@zagr0 , could you please share the current configuration you are using for the application manifest please? That may help to understand if there is some misconfiguration or the code does not support it yet.

sure, my app is:
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: stage-app
  annotations:
    argocd-image-updater.argoproj.io/image-list: main=my.repo.domain:5353/common/app
    argocd-image-updater.argoproj.io/main.pull-secret: pullsecret:argocd/registry
    argocd-image-updater.argoproj.io/main.helm.image-name: image.repository
    argocd-image-updater.argoproj.io/main.helm.image-tag: image.tag
    argocd-image-updater.argoproj.io/main.update-strategy: newest-build
    argocd-image-updater.argoproj.io/write-back-method: git:secret:argocd/git-creds
    argocd-image-updater.argoproj.io/write-back-target: helmvalues:./stage/app-helm/values.yaml
    argocd-image-updater.argoproj.io/git-repository: https://my.repo.domain/deploy.git
    argocd-image-updater.argoproj.io/git-branch: master
spec:
  project: stage
  sources:
    - repoURL: https://my.repo.domain/api/v4/projects/123/packages/helm/stable
      chart: common
      targetRevision: 2.*
      helm:
        releaseName: app
        valueFiles:
          - $values/stage/app-helm/values.yaml
    - repoURL: https://my.repo.domain/deploy.git
      targetRevision: master
      ref: values
  destination:
    server: https://kubernetes.default.svc
    namespace: stage
  syncPolicy:
    syncOptions:
      - CreateNamespace=true

the repo tree:
stage
  app-helm
    values.yaml

values file content:
image:
  repository: "my.repo.domain:5353/common/app"
  tag: "dev"

@zagr0 , maybe this comment will help to understand the behaviour.
The thing is that argocd-image-updater uses to different pieces of information that should match in order to work properly, one is the "alias" name that you use for the image and the other one is the docker image name. If those names do not match, then it will throw that error.
You may tray to change the alias name and see what happens. If you do that, you'll also need to change the references to the alias name in the rest of the annotations. I don't know if this changes have a big impact on your configurations, but you may try.
I understant that this is a bug that should be addresses, I just did not have more time to spend since the last time I did the PR. I'm sorry about that.
I hope the info will help.

@askhari , thank you very much to make it clear! Unfortunately I'm not able use alias with the value of image name common/app. Because of annotations key naming constrains:
metadata.annotations: Invalid value: a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')

Hi @zagr0 ,
I did a quick read to the code again and I'm not really quite sure if this will work, but could you try to use this configuration for your annotations and see what happens please?
annotations:     argocd-image-updater.argoproj.io/image-list: my.repo.domain:5353/common/app     argocd-image-updater.argoproj.io/common_app.pull-secret: pullsecret:argocd/registry     argocd-image-updater.argoproj.io/common_app.helm.image-name: image.repository     argocd-image-updater.argoproj.io/common_app.helm.image-tag: image.tag     argocd-image-updater.argoproj.io/common/app.helm.image-name: image.repository     argocd-image-updater.argoproj.io/common/app.helm.image-tag: image.tag     argocd-image-updater.argoproj.io/common_app.update-strategy: newest-build     argocd-image-updater.argoproj.io/write-back-method: git:secret:argocd/git-creds     argocd-image-updater.argoproj.io/write-back-target: helmvalues:./stage/app-helm/values.yaml     argocd-image-updater.argoproj.io/git-repository: https://my.repo.domain/deploy.git     argocd-image-updater.argoproj.io/git-branch: master
I know that this configuration is a bit crappy as there are two annotations that just repeat themselves with a slight different syntax. There is a function called normalizedSymbolicName() that substitutes the "/" character for "_", but it's not used in all the references used to build annotation names in the code. For what I read in the code I think it may work only for this case and configuration.
This behaviour comes from the details explained in this conversation on the original PR. I may change the c.ImageName for a img.normalizedSymbolicName() . It may solve the duplicated annotations, but it won't solve the problem of using an alias name for the images. That would need some more digging and changes into the code.
Not sure if this helps. I'm sorry for the inconveniences.

hi @askhari ,
I tried the example but got error complaining about annotation key names: metadata.annotations: Invalid value...
To be honest I didn't catch the idea, could you please check if formatted annotations I applied are correct?
annotations:
  argocd-image-updater.argoproj.io/image-list: my.repo.domain:5353/common/app
  argocd-image-updater.argoproj.io/common_app.pull-secret: pullsecret:argocd/registry
  argocd-image-updater.argoproj.io/common_app.helm.image-name: image.repository
  argocd-image-updater.argoproj.io/common_app.helm.image-tag: image.tag
  argocd-image-updater.argoproj.io/common/app.helm.image-name: image.repository
  argocd-image-updater.argoproj.io/common/app.helm.image-tag: image.tag
  argocd-image-updater.argoproj.io/common_app.update-strategy: newest-build
  argocd-image-updater.argoproj.io/write-back-method: git:secret:argocd/git-creds
  argocd-image-updater.argoproj.io/write-back-target: helmvalues:./stage/app-helm/values.yaml
  argocd-image-updater.argoproj.io/git-repository: https://my.repo.domain/deploy.git
  argocd-image-updater.argoproj.io/git-branch: master

Hi @zagr0 ,
It was my mistake thinking that I could use the "/" character. I'm sorry for the error.
I though it was worth to try it because the code reads the annotations in multiple parts. But in some of them uses a function which replaces the "/" from the image name with "_" characters. And in other parts of the code uses directly the ImageName value without replacing the "/".
In the end it's not possible to use another slash in the annotation name because it just allows one.
Again, sorry because I may wasted some of your time with this tests. I'll try to free some time to work on a fix for this asap, but I'm not sure if it will be this week.

@zagr0 , I opened #725 which aims to fix the problem of not finding the right annotations.
Let's see if I did the PR in the right way, because it's the first time I try to send a fix for a specific version.

@zagr0 , the PR #725 has been merged into master but there isn't a new tag yet. You may try building the master branch or the code of the PR. It should solve the issue when using image aliases.

Thank you very much @askhari ! Most probably there are image builds with latest tag from master, I will check it.

Hi @askhari ,
I have verified with my scenario and now there is no issues with finding image name, this part works, but the changes committed to values.yaml file looks really strange.
Image updater was not able to discover image: hierarchy and tag inside and just added new entries of image.tag and image.repository in the file:
...
image:
  pullPolicy: IfNotPresent
  repository: my.repo.domain/common/app
  tag: 0.0.6-SNAPSHOT_3ced321a
image.repository: my.repo.domain/common/app
image.tag: 0.0.5
...

In addition to that image updater recreated content of the values.yaml to format it, ordered all values alphabetically.

here is the issue

@zagr0 , thank you for the feedback.
As I understood there are two different issues (please correct me if I'm wrong):

Right now, this feature does not search into the YAML hierarchy. Instead, it searches for a key that includes the dots.
And it messes up with the order of the keys in the YAML file when writing it back to the repository.

The first thing was fine for us, but I understand that it makes more sense to navigate the hierarchy.
The second one it a bit trickier to solve because it's the natural behaviour of the golang YAML library. To solve it we need to use MapSlice type and it makes more complicated (at least for me).
I'm already working to solve this two issues on this branch of my fork and I'll make a PR shortly: https://github.com/askhari/argocd-image-updater/tree/fix/helm-values-wbc.
Again, thank you for noticing it.
Cheers!

Hi @zagr0 ,
I opened #748 to solve these problems. Let's see if it gets approved :)
Cheers!

@admssa , now that #725 and #748 have been merged into master, could you please test if they solve the problem you  explained in this issue?
If the problem is solved, we may close this issue :) .

@askhari thank you so much for working on this! Aren't we waiting for a new version of the image-updater here...to get the fixes you've done?
Thanks.

Just to follow up before this gets closed, is there any way to get the updater to publish the .yaml config in the second provided source?
From @mecsys example:
 - ref: values
    repoURL: git@github.com:mecsys/mecsys-gitops.git
    targetRevision: main


[PowerToys Run] Open whatsapp numbers

Description of the new feature / enhancement
Allow option to type phone number and after enter it will open the number in whatsapp
Scenario when this would be used?
Every time I want to contact someone,
There is no simple and known way to do it without adding the person to contacts.
The only way to do it without adding to contacts is with the url trick.
Supporting information
To open whatsapp number, type this url:
wa.me/XXXYYYYYYYYYY
XXX = country code
YYYYYYYYYY = phone number
It will open the number in whatsapp.
PT run should just do it for me

I think this should work when we use the protocol whatsapp://send?phone=

@Aaron-Junker
Do you if there are other url parameter too. Like ?name=

There's the text parameter. I'm not aware of any other parameters. The official WA docs say btw that you should open numbers with https://wa.me/<number>. But I think both works

Why use custom protocols?
It will fail if the app is not installed.
Better to use https://wa.me/<number>

I'd love to see this as plugin

I think we should open local if the app is installed. Otherwise in browser via https. We can add a setting to always open it in wen browser.

PT plugin syntax can be <number>[:<message>].

Why use custom protocols?
It will fail if the app is not installed.
Better to use https://wa.me/<number>

@gileli121
Does the app open if installed with this link or does the browser opens?

I want to type just number and it should be smart to suggest me to open in whatsapp

What I mean is that

only number opens chat.
number and text opens chat with draft text.
only text opens wa with message and asks for the chat.

I think this should work when we use the protocol whatsapp://send?phone=

This should work too:
whatsapp://send?phone=xxx&text=abcdefg

I think this should work when we use the protocol whatsapp://send?phone=

This should work too:
whatsapp://send?phone=xxx&text=abcdefg

According to a stackoverflow post this should work. But I'm currently not able to test it

Does the app open if installed with this link or does the browser opens?

Actually, it forcing me to use the app.
After it loaded in the browser, there is page that force to open in the app

I suggest that it will use this protocol
whatsapp://send?phone=XXXYYYYYYYYYY
It works for me and open in the app.
If you use wa.me/XXXYYYYYYYYYY it will open in the browser and show you page that forcing you to open the app

It should use the whatsapp:// if this protocol found on the system (that is if the app installed)

I think this should work when we use the protocol whatsapp://send?phone=

This should work too:
whatsapp://send?phone=xxx&text=abcdefg

According to a stackoverflow post this should work. But I'm currently not able to test it

verified it a few seconds ago.
I suggest to check if the app is installed. If yes use WhatsApp:// else https://wa.me/.

This is not a plugin PowerToys itself would build. This is deep app integration with an external application/service.  #3200 would help enable this for a community member to do it.
I totally understand the request but this is not something we'll directly build.


Changes to LPT and other modifications from CRG

I've absorbed it into develop instead of master - I've gonna go ahead and close it.


Generic version of IPOPT

Hello
IPOPT comes with a number of interfaces to linear solvers (MUMPS, LAPACK, HSL) and others.
I tried to create a dll of ipopt with none of these solvers in order to focus o Eigen.
the build fails because it looks for these libs.
Is there a clean version of IPOPT ? i.e., one that does not depend on any solver a priori ?
then the build of IPOPT+EIGEN could be much cleaner and simpler.
best
jac

The one you install from the Linux command line (sudo apt install coinor-libipopt-dev) has Mumps already linked and works out of the box. There's nothing else do be done or configured.

Thanks
the problem is that I work under windows and MSVC
I have found a CMAKE build of IPOPT

hi
I am also interested in building IPOPT on MSVS
could you please indicate where to find the CMAKE build ?
thanks
jac

I haven't tried building on Windows. But you should be able to generate the vsproject files (.sln, vcxproj) by running cmake on windows. Then, if you installed the additional c++ build tools with visual studio, you could use msbuild from the command line on the vsproject files. (This link might be helpful: https://dmerej.info/blog/post/cmake-visual-studio-and-the-command-line/)
But as you correctly pointed out, the problem will be for cmake to find and link against the installed version of IPOPT. And you will need at least one solver (e.g. MUMPS) to do anything, that's why it's so convenient that sudo apt install coinor-libipopt-dev installs that automatically on ubuntu.
Unfortunately there is no plan on adding windows support at this time.


add boost mpi, boost build and dependencies

Submission Checklist

[ ] Run unit tests: ./runTests.py test/unit
[ ] Run cpplint: make cpplint
[X] Declare copyright holder and open-source license: see below

Summary:
Add boost MPI and boost build.
Intended Effect:
Prepare for MPI codes.
How to Verify:
Side Effects:
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): boost
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

I guess this pull should figure out how we pull in mpi and its dependencies. I used bcp as stated above and bcp is very conservative in pulling in any possible dependency. I already tried with the find commands above to counter this a little bit. It is still a bigger amount of files.
Another attempt I did was to use the scan option from bcp. If you scan the mpi_cluster.hpp file from the mpi branch it will come up with a slightly smaller set of libraries, but not a lot smaller though. If we want to minimize what we include, then we will probably need to put a bit more effort into this. I figured going the safe way and include more than less is fine.

@syclik I feel like Sebastian's question is maybe for you as Math Tsar - how do you feel about how strict we are in adding these headers? Should we try to eliminate some of them by scanning what we're currently using in the MPI branch? Or just put everything we might need in now? I'm kind of leaning towards the latter as well, though maybe we need to do some of that header elimination work eventually for RStan anyway.

For RStan, we're going to need to get changes into the BH package.  I don't know if they only do the header-only ones. @bgoodri will probably know.

@bob-carpenter BH is header only. I think we would need to deploy these with StanHeaders which also includes CVODES.
@seantalts Do I need to update anything locally to avoid autoformatting of libs? The hooks seem to have not changed, so I guess that this is part of other config files which are updated whenever I merge develop, right?

I'll ping Dirk about BH before doing it ourselves, but I'm OK either way.

There was a commit (here) that changed the hooks to not touch libraries. If you have develop up to date and your hook was installed via the script (or otherwise symlinks to hooks/pre-commit then you should be good to go.

@bob-carpenter and @bgoodri are we going to support MPI under R anytime soon? Like I said, I am concentrating on cmdstan which I thought we all agreed on.

I think it's fine to roll it our initially for CmdStan and Linux.
As far as stan-dev/math goes, we need to include everything we need from Boost there.  R is a different question.  I was responding to the  previous message about StanHeaders, which is the R package.

If it can be built for Stan Math, it is fair to assume it can be built for
R, although we likely have to do it ourselves because it is not header-only
at that point.
On Sat, Feb 3, 2018 at 11:34 AM, Bob Carpenter<EMAIL_ADDRESS>wrote:

I think it's fine to roll it our initially for CmdStan and Linux.
As far as stan-dev/math goes, we need to include everything we need from
Boost there. R is a different question. I was responding to the previous
message about StanHeaders, which is the R package.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/737#issuecomment-362830352, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADOrqlFwXcvWDWN4BQbtMs-73oB1lu0fks5tRIp5gaJpZM4RvPjw
.

Dirk confirmed on the BH issue tracker that BH is going to remain header only.

We're already building a shared object for CVODES. We'll probably
instantiate the model class whenever it is ready. So, building part of
Boost is not that big of a deal.
On Sat, Feb 3, 2018 at 1:04 PM, Bob Carpenter<EMAIL_ADDRESS>wrote:

Dirk confirmed on the BH issue tracker that BH is going to remain header
only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/737#issuecomment-362840696, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADOrqlM8r2Nu5BcxBG-QPUBO_WhLzuCvks5tRJ_GgaJpZM4RvPjw
.

In response to @wds15 in https://github.com/stan-dev/math/pull/737#issuecomment-362175793

I guess this pull should figure out how we pull in mpi and its dependencies.

Yes, is that not what this pull request does? If not, can you update the original PR comment to mention what this PR does?

If we want to minimize what we include, then we will probably need to put a bit more effort into this. I figured going the safe way and include more than less is fine.

Yes, that's fine.
From @seantalts in https://github.com/stan-dev/math/pull/737#issuecomment-362301276

how do you feel about how strict we are in adding these headers? Should we try to eliminate some of them by scanning what we're currently using in the MPI branch? Or just put everything we might need in now? I'm kind of leaning towards the latter as well, though maybe we need to do some of that header elimination work eventually for RStan anyway.

I think we should just include everything. But that puts additional work on RStan and PyStan, so we've done some ad hoc trimming of includes in the math library. We may want to do something different for how we manage dependencies in the near future with MPI / GPU + optional headers + minimal includes. Our current includes weren't put together with that sort of complexity in mind.

@wds15, I'll review this one.

@wds15, can you update to develop which includes Boost 1.66.0?

@syclik This is ready for review again


PHOENIX-6525 Use the defined version properties for building phoenix-…

…connectors-phoenixX-compat modules

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
10m 45s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
16m 50s
master passed

+1 :green_heart:
compile
0m 31s
master passed

+1 :green_heart:
javadoc
0m 20s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
16m 40s
the patch passed

+1 :green_heart:
compile
0m 32s
the patch passed

+1 :green_heart:
javac
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 19s
phoenix-connectors-phoenix4-compat in the patch passed.

+1 :green_heart:
unit
0m 22s
phoenix-connectors-phoenix5-compat in the patch passed.

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

51m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-61/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/61

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux 9550439eb0f1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / 6c0771a

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-61/1/testReport/

Max. process+thread count
93 (vs. ulimit of 30000)

modules
C: phoenix-connectors-phoenix4-compat phoenix-connectors-phoenix5-compat U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-61/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[JBMETA-452] At WebMetaDtaParser, add a requireNocontent(reader) afte…

…r finding deny-uncovered-http-methods element.
The goal is to finish parsing that element before reading the next XML element. Also: add tests for deny-uncovered-http-methods parsing.
Signed-off-by: Flavia Rainone<EMAIL_ADDRESS>Jira: https://issues.redhat.com/browse/JBMETA-452

requires #172 to pass the tests

oops @ehsavoie my bad! I was certain I had run the test after catching the exception, but clearly I did not.
I just fixed it, and I also updated the comments in the testcase class btw.


Fix QuickPickItem JSDoc links in vscode.d.ts

This PR fixes a formatting issue in the vscode.d.ts file with JSDoc links for the picked & buttons properties of the QuickPickItem interface.
The current syntax renders the links in the documentation as empty round brackets:

Thanks for fixing this @HiDeoo!


added better readme

added a more clear readme, with more broad context, and contribution room.

Awesome, thanks!


TypeError: The 'compilation' argument must be an instance of Compilation

Operating System: Ubuntu
Node Version: v14.16.0
NPM Version: 6.14.11 (but we're using pnpm 6.0.1 with a monorepo)
webpack Version: 5.37.0
karma-webpack Version: 5.0.0

When running karma, the following error is printed out:
START:
Webpack bundling...
14 05 2021 14:20:43.679:ERROR [karma-server]: TypeError: The 'compilation' argument must be an instance of Compilation
    at Function.getCompilationHooks (/path/to/project/node_modules/.pnpm/webpack@5.37.0_webpack-cli@4.6.0/node_modules/webpack/lib/NormalModule.js:195:10)
    at /path/to/project/node_modules/.pnpm/webpack-manifest-plugin@3.1.1_webpack@5.37.0/node_modules/webpack-manifest-plugin/lib/index.js:56:24
    at _next24 (eval at create (/path/to/project/node_modules/.pnpm/tapable@2.2.0/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:50:1)
    at _next2 (eval at create (/path/to/project/node_modules/.pnpm/tapable@2.2.0/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:97:1)
    at Hook.eval (eval at create (/path/to/project/node_modules/.pnpm/tapable@2.2.0/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:105:1)
    at Hook.CALL_DELEGATE [as _call] (/path/to/project/node_modules/.pnpm/tapable@2.2.0/node_modules/tapable/lib/Hook.js:14:14)
    at Compiler.newCompilation (/path/to/project/node_modules/.pnpm/webpack@5.37.0/node_modules/webpack/lib/Compiler.js:1031:26)
    at /path/to/project/node_modules/.pnpm/webpack@5.37.0/node_modules/webpack/lib/Compiler.js:1073:29
    at Hook.eval [as callAsync] (eval at create (/path/to/project/node_modules/.pnpm/tapable@2.2.0/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/path/to/project/node_modules/.pnpm/tapable@2.2.0/node_modules/tapable/lib/Hook.js:18:14)
    at Compiler.compile (/path/to/project/node_modules/.pnpm/webpack@5.37.0/node_modules/webpack/lib/Compiler.js:1068:28)
    at /path/to/project/node_modules/.pnpm/webpack@5.37.0/node_modules/webpack/lib/Compiler.js:496:12
    at Compiler.readRecords (/path/to/project/node_modules/.pnpm/webpack@5.37.0/node_modules/webpack/lib/Compiler.js:908:11)
    at /path/to/project/node_modules/.pnpm/webpack@5.37.0/node_modules/webpack/lib/Compiler.js:493:11
    at Hook.eval [as callAsync] (eval at create (/path/to/project/node_modules/.pnpm/tapable@2.2.0/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/path/to/project/node_modules/.pnpm/tapable@2.2.0/node_modules/tapable/lib/Hook.js:18:14)
rake aborted!

What version of karma are you using?

We're on Karma 4.1.0... eventually I got this to work by removing random bits of Webpack config but I could never track down exactly which config value it was complaining about. Our webpack config is very complex so I'm not surprised there was something weird in it 😃

Glad to hear it is working : )


Unify container builds for sqlite and postgres images and publish semver tags.

Clear and concise description of the problem
I am curious what is the reason for splitting these up into two separate containers and if there's any plan to unify these images into one? I am not a rust programmer so pardon me if there's a reason I cannot see. I also selfhost https://github.com/atuinsh/atuin which is also rust and has a single container that work with either postgres or sqlite.
Also, I've been using podfetch but would love it if the container tagging could adhere to semver. What I mean is that if the container tagging could be v4.3.0 instead of v4.3.0-postgres-b6d7f1b. This helps with automation tools like renovate that can scan the container registry and discover new versions.
Suggested solution

Build a single container image for both sqlite and postgres
Adhere container tags to semantic versioning

Alternative
Thanks for this wonderful app, there are really great design choices you have made that truely kick ass.
Additional context
Feel free to convert this into a discussion if you think that's a better way to discuss.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Good idea. It is unfortunately a bit complicated. Rust is statically typed so it needs to know everything at compile time. Vaultwarden solves that with an insane macro rule. Unfortunately when I was asking them for help back then I was reminded that it is a GPL project and if I take any piece of code of vaultwarden I also have to obey to the GPL license which I don't want to.
So I need to come up with my own solution but generally speaking a unified Docker image would save me so much time/complicated pipelines/headaches in general.

Good to know you're thinking about that, have you looked at how https://github.com/atuinsh/atuin has handled it? That is a MIT licensed.

I'll have a closer look tomorrow. There are two different "ORMs" in the Rust world. SQLX and Diesel. Seems like the creator of attain used SQLX and PodFetch is based on Diesel.


Switch go_modules from getUpdatedVersion to a public go command

See discussion here: https://github.com/dependabot/dependabot-core/pull/3590#discussion_r622817120
In particular:

there's a lot of custom code whose sole goal is to identify what the latest version of a go module. That's the only reason we need https://github.com/dependabot/dependabot-core/blob/main/go_modules/helpers/updatechecker/main.go which is the only reason we need an entire repo: https://github.com/dependabot/gomodules-extracted/.

And @thepwagner pointed out:

I think something like go list -m -mod=mod -versions -json <dep> is a better solution than the current getUpdatedVersion helper. I've experimented with it here: https://github.com/thepwagner/action-update-go/blob/2ba2b9a3d49a3285b327622fbd5daccb4fe64e19/gomodules/check.go#L141 .

The one thing to note is that go list, go get etc download modules. I'm not sure the existing getUpdatedVersion does that. I haven't looked into how it works. But from a speed/network chattiness, avoiding downloading modules is a big win. Although on the flip side, from a correctness point of view, public APIs like go list, go get etc will probably do a better job of navigating any issues such as retracted versions, pre-release versions, etc.
Also the guts of how all that upstream code works, regardless of whether accessed via getUpdatedVersion or go list and friends, is going to change a lot in go 1.17 when lazy module loading lands. That may also greatly affect correctness/speed, unclear at this point.
Fixing this would implicitly fix #3569.

This was investigated and decided against (or at least: deferred) in https://github.com/dependabot/dependabot-core/pull/3630

Completely agree that given the current behavior this isn't the right move.
However, this is probably worth holding open until https://github.com/golang/go/issues/36460 lands, as it may change the behavior. See https://github.com/dependabot/dependabot-core/pull/3630#issuecomment-833779506.

This was done as part of https://github.com/dependabot/dependabot-core/pull/4434


Disabled deposit

Summary
Cannot proceed to the deposit screen
Environments

Android OS v11
iOS v14.7

Version

App: 3.1.0-132
Wallet: 2.8.2-HF01

Steps to reproduce

Open the app.
Navigate to Wallet screen.
Go to a wallet
After you activate BTC, hit deposit

Current behavior
Redirected to "disabled deposit" screen
Expected behavior
Should be redirected to the "actual deposit" screen
Relevant screenshots

As designed, deposits have been disabled until a new solution is found.
https://github.com/threefoldtech/threefold_wallet/issues/259


Multi-Colum-Sorting: Click and keyboard combination does not work

Steps to reproduce:
ATable with :is-sorting-multi-column="true" and sorting-multi-column-key="shift". Reproducible on DOCS page aloha/#/table-sort
Expected Result:
Click + shift sorts table by multiple selected columns.
Current behavior:
Table sorted by a single column, combo has no effect. (If relevant, reproduced with Chrome on Linux)

at work

fixed


Log Cluttering

https://github.com/NotAtomicBomb/TerminalApi/blob/93e62f75877c7ab92d55a871cae95923e4fb0238/TerminalApi/TerminalApi.cs#L172C11-L172C11
Hi one of my mods depends on this API and my keywords are run pretty frequently so i was wondering if you could reduce some of these log outputs in the logger just to remove the clutter

I will implement this to thunderstore and nuget tomorrow.

Eh, implemented it now.


Switch to hsl color scheme

Theme tweaks will be easier
You iz can readz it

I iz canz

[x] better semantics on class names and theme object
[x] minor styling bug fixes

Oh, yes...
@gigatexal
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
Gucci Gang
...that was the last one


ZeroDivisionError: float division by zero

Hi there,
I have cloned project at VPS server and created snapshot of account and  run next command:
python main.py --output print and I received next error at console:
Traceback (most recent call last):
  File "main.py", line 54, in <module>
    main()
  File "/home/manager/binance-trade-bot/binance-trade-bot/venv/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/manager/binance-trade-bot/binance-trade-bot/venv/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/manager/binance-trade-bot/binance-trade-bot/venv/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/manager/binance-trade-bot/binance-trade-bot/venv/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "main.py", line 49, in main
    figname = bot.crypto.plot_symbol(reports, plot_symbol)
  File "/home/manager/binance-trade-bot/binance-report-bot/bot/crypto.py", line 92, in plot_symbol
    Y.append(report['total_usdt']/ticker)
ZeroDivisionError: float division by zero

Hey!
Could you paste your conf.py file?
Please censor your binance keys

Here it is:
COINS = ["BTC","ADA","ATOM","BAT","BTT","CAKE","DASH","EOS","ETC","ICX","IOTA",>
CURRENCY = "USB" #Or USD
CURRENCY_SYMBOL = "$"
RICH_PRINTING = True

You have your currency set at "USB", set it at "USD". That's why it can't find your price. Then delete the /db/crypto.npy file and run again

Oops.
Sorry.. Seems like I am not attentive.)
But thanks for supporting :)

No problem, thanks for the PRs by the way!


OTR: GO:0008282 ATP-sensitive potassium channel complex

The def needs broadening to allow for Kir6.1 and Kir6.2 subunits as well as SUR1, SUR2A and SUR2B subunits:
"The opening and closing of the channel is regulated by ATP: binding of ATP to the Kir6.x subunit inhibits channel activity, whereas binding of Mg2+-complexed ATP or ADP to the SURx subunit stimulates channel activity."
Also, the more commonly know name for this complex is "inward rectifying potassium channel". It should be at least a synonym.
Further synonyms to be added:
inward rectifying K+ channel
Kir6.x complex
Kir6.x-SURx complex
Kir6-SUR complex
Kir6.1-SUR complex
Kir6.2-SUR complex
KCNJ8-SUR complex
KCNJ11-SUR complex
Kir6.1-SURx complex
Kir6.2-SURx complex
KCNJ8-SURx complex
KCNJ11-SURx complex
As we are at it, it also has these relationships:
is_a GO:0034705 potassium channel complex (instead of GO:0034702 ion channel complex)
capable_of GO:0005267 potassium channel activity, or even GO:0022841 potassium ion leak channel activity (it can let some K+ through even if the MgADP doesn't bind as ATP is a weak inhibitor)
capable_of GO:0005524 ATP binding
capable_of GO:0043531 ADP binding
capable_of GO:1904517 MgATP(2-) binding (new in TG)
capable_of GO:NEW MgADP(2-) binding (to be created when MgADT2+ = CHEBI:87194 released)
capable_of GO:0030955 potassium ion binding
capable_of GO:0019808 polyamine binding
capable_of_part_of GO:0010107 potassium ion import
capable_of_part_of GO:1990573 potassium ion import across plasma membrane
[the latter two have no relationship in GO but maybe GO:1990573 should be child of GO:0010107?]
Thanks,
Birgit

I'm not sure the annotations
GO:0005244 voltage-gated ion channel activity
GO:0005249 voltage-gated potassium channel activity
GO:0015272 ATP-activated inward rectifier potassium channel activity
GO:0015467 G-protein activated inward rectifier potassium channel activity
and
GO:0008076 voltage-gated potassium channel complex
and even
GO:0005242 inward rectifier potassium channel activity
are correct as:
A) ATP inhibits the channel, and
B) activation is either by mechanical means (in cardiac cells) or by changing the intracellular ATP or MgADP or extracellular glucose concentration (in pancreatic beta-cells) rather than voltage change (see def of GO:0005242 inward rectifier potassium channel activity, last annotation above). In fact, Kir6 channel activity results in voltage change and at least in pancreatic beta-cells this activates the Ca2+ channels which results in insulin release.
The names of the above terms are in parts misleading but the defs clearly refer to either ATP-dep or voltage-gated activation.

Hi Birgit, can you share some refs?  Struggling to put all the pieces toghether here.
BTW - I think there are problems with the definition of inward rectifier channel activity - the def is more restricted than it should be - actually seems to refer to a subclass of inward rectifiers.  Hoping to discuss definitions of main axes of classification of general channel classification for ion channels at next synapse working group meeting.

Hi David,
Here are some (unstructured!, copy/paste) notes and a list of references:
https://docs.google.com/document/d/1ebFJLwv8yorBb1mjrBVhMcJgKK4xr-B7oxCY7dzNcQs/edit?usp=sharing
Fairly recent, comprehensive review: 20086079
Paper I curated for exp evidence: 25236767
And yes, if the def for inward rectifier potassium channel activity was broadened it could work. It's just its reliance on 'voltage-gated' that I don't agree with for Kir6.x channels.
Thanks,
Birgit

Hi David,
Looks like the def got updated (in the latest GO release report) but only adjusting the Kir subunit, not the SUR subunit. It should refer to both, SUR1 and SUR2 types (or SURx).
Thanks,
Birgit

Hi @bmeldal
I made the following changed (lines starting with "-" are removed, lines starting with + are new):
id: GO:0008282
-name: ATP-sensitive potassium channel complex
+name: inward rectifying potassium channel
namespace: cellular_component
def: "A protein complex that comprises four pore-forming (Kir6.x) and four regulatory sulphonylurea receptor (SURx) subunits and forms a transmembrane channel through which ions may pass. The opening and closing of the channel is regulated by ATP: binding of ATP to the Kir6.x subunit inhibits channel activity, whereas binding of Mg2+-complexed ATP or ADP to the SURx subunit stimulates channel activity." [GOC:bhm, PMID:16308567, PMID:16956886]
-is_a: GO:0043234 ! protein complex
+synonym: "ATP-sensitive potassium channel complex" EXACT []
+synonym: "inward rectifying K+ channel" EXACT []
+synonym: "KCNJ11-SUR complex" RELATED []
+synonym: "KCNJ11-SURx complex" RELATED []
+synonym: "KCNJ8-SUR complex" RELATED []
+synonym: "KCNJ8-SURx complex" RELATED []
+synonym: "Kir6-SUR complex" RELATED []
+synonym: "Kir6.1-SUR complex" RELATED []
+synonym: "Kir6.1-SURx complex" RELATED []
+synonym: "Kir6.2-SUR complex" RELATED []
+synonym: "Kir6.2-SURx complex" RELATED []
+synonym: "Kir6.x complex" RELATED []
+synonym: "Kir6.x-SURx complex" RELATED []
+is_a: GO:0034705 ! potassium channel complex
is_a: GO:0044459 ! plasma membrane part
relationship: capable_of GO:0005267 ! potassium channel activity
+relationship: capable_of_part_of GO:1990573 ! potassium ion import across plasma membrane
relationship: part_of GO:0005887 ! integral component of plasma membrane
Does this address your points?
Also - if you think some annotations need review, please open a ticket in the annotation tracker.
Thanks, Pascale

Another thing: I didn't add capable of x binding; I don't know if we do that systematically, I could not find other examples.

Happy with the changes - Thanks @pgaudet - and copied the annotation question into the right tracker.
Binding x question - to be discussed in Complex WG next week. I will add this ticket to the project as a reference.

great, thanks !

https://github.com/geneontology/go-annotation/issues/1701

We might come back to this when we get an answer to wether users use the binding to X relationships.