delete blacklisted site: chrome.storage.local is updated when a site is removed from blacklist

done


feature: ClusterTreeService.ts add Deactivation Intent to node name suffix if intent not set to 'invalid'

add deactivation intent to node name suffix if intent not set to 'invalid' to assist in administration and triaging of cluster
a couple of examples:

very slow update, im sorry.
This is a solid addition, one request though. Can you also add it in the SfxWeb section too, that is for the v2 sfx stuff, which will eventually replace the previous version.


Add supported vpd pages to zbc vpd pages

The supported vpd pages page is required by SPC. It should be included in itself.
This resolves an issue where expected sysfs attributes (specifically scsi_device/vpd_pg0 in new kernels)
is not populated on devices emulated with file_zbc.c.

Specifically, it states The supported VPD page list shall contain a list of all VPD page codes (see 7.7) implemented by the logical unit in ascending order beginning with page code 00h. which makes the current implementation non-compliant.

See existing code for other plugins: https://github.com/open-iscsi/tcmu-runner/blob/ddc7d14169540fdfe9e75c6e9e31ba09a25c9dd1/scsi.c#L104

I found a bug in this patch during verification, I'll push out a squashed up commit after I've run additional testing.

Verified 1fd43f2 by generating an emulated ZBC device and issuing the VPD command.  I ran the libzbc test suite and some IO against the disk just to be double sure.
# Before Update
root@mymachine:~# sg_vpd -p 0x0 /dev/sdf  -rr | xxd
00000000: 1400 0005 83b0 b1b6 4c                   ........L
root@mymachine:~# find /sys/block/sdf/device/vpd*
/sys/block/sdf/device/vpd_pg83

# Post Update
root@mymachine:~# sg_vpd /dev/sdf -rr | xxd
00000000: 1400 0006 0083 b0b1 b600                 ..........
root@mymachine:~# find /sys/block/sdf/device/vpd*
/sys/block/sdf/device/vpd_pg0
/sys/block/sdf/device/vpd_pg83

LGTM. @ryanattard Thanks.


Enable cron job if credentials

If the AWS secret key is NOT set, do not enable the cron job or run the one-off job.

/lgtm
/approve


RadioGroup and CheckboxGroup: option to be able to set legend as a 'page heading'

Describe the bug
We would like the ability to set the legend in the RadioGroup and CheckboxGroup component, as a 'page heading' when there is only one question on the page.
Examples,

Legend on its own (current rendering of the FormGroup component): https://design-system.service.gov.uk/components/radios/without-heading/index.html
Legend as a heading: https://design-system.service.gov.uk/components/radios/hint/index.html

Proposal to be able to set the legend as a 'page heading' (which add a child <h1> element inside the legend element) and the ability to pass a class prop to the <h1>

Hi, this ticket is no longer needed as the functionality is present to turn a legend into a heading in release 6. @cg-julian-taylor @daniele-zurico sorry about any confusion caused.


Uninstall?

Is there a way to uninstall this automatically, or manually?

Hi, simply remove the folder where you installed it. It is self contained app so it doesn't mess up with your local python or your other tools. It installs a miniconda environment and keeps everything in there except your personal folder that you can choose to put elsewhere. But by default it is put in the same folder


Adding documentation for WriteBatch size limit

Reference: b/70222712

Apologies for not checking my work more clearly.


[Youtube] Downloading of automated captions is not working (or at least very unpredictable)

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.12.05
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

$ youtube-dl -v --list-subs https://www.youtube.com/watch?v=48sCx-wBs34
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--list-subs', 'https://www.youtube.com/watch?v=48sCx-wBs34']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.12.05
[debug] Python version 3.7.1 (CPython) - Darwin-20.1.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.1, ffprobe 4.3.1, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] 48sCx-wBs34: Downloading webpage
[youtube] 48sCx-wBs34: Looking for automatic captions
WARNING: Couldn't find automatic captions for 48sCx-wBs34
48sCx-wBs34 has no automatic captions
Available subtitles for 48sCx-wBs34:
Language formats
zh       vtt, ttml, srv3, srv2, srv1
en-US    vtt, ttml, srv3, srv2, srv1
$ youtube-dl -v --list-subs https://www.youtube.com/watch?v=48sCx-wBs34
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--list-subs', 'https://www.youtube.com/watch?v=48sCx-wBs34']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.12.05
[debug] Python version 3.7.1 (CPython) - Darwin-20.1.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.1, ffprobe 4.3.1, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] 48sCx-wBs34: Downloading webpage
[youtube] 48sCx-wBs34: Looking for automatic captions
Available automatic captions for 48sCx-wBs34:
Language formats
af       vtt, ttml, srv3, srv2, srv1
sq       vtt, ttml, srv3, srv2, srv1
am       vtt, ttml, srv3, srv2, srv1
ar       vtt, ttml, srv3, srv2, srv1
hy       vtt, ttml, srv3, srv2, srv1
...
yo       vtt, ttml, srv3, srv2, srv1
zu       vtt, ttml, srv3, srv2, srv1
Available subtitles for 48sCx-wBs34:
Language formats
zh       vtt, ttml, srv3, srv2, srv1
en-US    vtt, ttml, srv3, srv2, srv1

Description

Hi, I think there is a bug in the way that youtube-dl retrieves if a youtube video has auto captions because if you run --list-subs on any video with automatic captions, the output is inconsistent. This is also probably related to atleast #27306 and #27292.

yes it seem to be a bug.
I also met this issue today.

I have been facing the same problem for the past few days. I сan't download automatically generated subtitles using --wirte-auto-sub option, although in fact they are present. (youtube-dl version 2020.12.07 and earlier). But it seems like the issue isn't reproducing regularly. Sometimes I can download subtitles, sometimes I can't. And in some cases, even if it is the same video.

Yeah, it's definitely some type of bug with checking if there are automated subtitles but the author of #27344 mentioned that it might not be a bug with youtube-dl but with the youtube Data API.

I agree. The problem may be that YouTube has changed something. Today I tried to download subtitles of a certain video many times, but with no success. I used versions 2020.12.07 and 2020.11.19. However, after a while I suddenly succeeded.

For the record, I ran "youtube-dl --list-subs https://www.youtube.com/watch?v=pwcZF12yx4M" 50 times in a loop.
youtube-dl reported 42 times that the video had no subs. The other 8 times, it reported that automatic captions were available.

I also tried downloading automatic subtitles for a video and it didn't work, though it reported previously that there are automatic subtitles available for that video (and there is). :T
So... subtitle downloading isn't working right now? Maybe this should be the title of the issue (and maybe a pin issue)?

youtube-dl --write-auto-sub --sub-lang en --skip-download "https://www.youtube.com/watch?v=GWGbOjlJDkU"
[youtube] GWGbOjlJDkU: Downloading webpage
[youtube] GWGbOjlJDkU: Looking for automatic captions
[info] Writing video subtitles to: Who are you-GWGbOjlJDkU.en.vtt

I expect to use this command to download automatically generated subtitle file, but it always download the manual subtitles.

已经三天了，ydl无法下载自动生成的字幕，7号之前下载字幕都正常。
但是火狐用的几个月前更新的YouTube字幕下载脚本，下载字幕正常

I can also confirm this issue. It started three days ago, and appears to be present on both the current and previous version of youtube-dl. I suspect Youtube have changed something on their API.
youtube-dl --list-subs https://www.youtube.com/watch?v=pwcZF12yx4M
[youtube] pwcZF12yx4M: Downloading webpage
WARNING: video doesn't have subtitles
[youtube] pwcZF12yx4M: Looking for automatic captions
WARNING: Couldn't find automatic captions for pwcZF12yx4M
pwcZF12yx4M has no automatic captions
pwcZF12yx4M has no subtitles
In short, youtube-dl is not able to detect and download automatically generated captions!

已经三天了，ydl无法下载自动生成的字幕，7号之前下载字幕都正常。
但是火狐用的几个月前更新的YouTube字幕下载脚本，下载字幕正常

可以先用着我这个替换顶着

@RogerRordo I'm quite unfamiliar with the inner workings of youtube-dl, but if the gist that you shared can fix this bug, could you open a PR?

已经三天了，ydl无法下载自动生成的字幕，7号之前下载字幕都正常。
但是火狐用的几个月前更新的YouTube字幕下载脚本，下载字幕正常

可以先用着我这个替换顶着

我用的ydl是win版exe文件

@RogerRordo I'm quite unfamiliar with the inner workings of youtube-dl, but if the gist that you shared can fix this bug, could you open a PR?

The problem is that the structure of ytplayer.config has changed, and it can no longer be explicitly obtained from the webpage. So the function _get_ytplayer_config used for getting automatic captions is not available any more.
My code fetches automatic captions from another object ytInitialPlayerResponse. However, I don't know how to fix the function _get_ytplayer_config which is still being called elsewhere. So I don't want to open a PR to submit this incomplete code.

已经三天了，ydl无法下载自动生成的字幕，7号之前下载字幕都正常。
但是火狐用的几个月前更新的YouTube字幕下载脚本，下载字幕正常

可以先用着我这个替换顶着

It works! Awesome

I also cannot get auto-generated subtitles, I updated to the latest version today -2020.12.12 but the issue persists.

For me the issue happened after the beginning of december, or at least i saw there is a bug at the start of december. im the author of an other issue related to subtitle (#27292)and you can see the latest version 2020.12.12 doesnt dl the sub when version2020.12.02 does so it seems to be related to youtube-dl too or youtube API changed between again.

For me the issue happened after the beginning of december, or at least i saw there is a bug at the start of december. im the author of an other issue related to subtitle (#27292) and you can see the latest version 2020.12.12 doesnt dl the sub when version2020.12.02 does so it seems to be related to youtube-dl too or youtube API changed between again.

I only started using youtube_dl in the last few days, so I have not tested the previous version. But I compared the related code of the two versions, and found no significant difference. I believe that the random running result of the previous version is most likely due to the transition of the youtube API change. You can compare my code with the webpage of any youtube video to understand the cause of the bug.

已经三天了，ydl无法下载自动生成的字幕，7号之前下载字幕都正常。
但是火狐用的几个月前更新的YouTube字幕下载脚本，下载字幕正常

可以先用着我这个替换顶着

用pip装了ydl，用你代码替换后果然能下载字幕了，谢谢！

Here as well. With 2020.12.12
youtube-dl --list-subs "https://www.youtube.com/watch?v=_3fusAQT0-U"
[youtube] _3fusAQT0-U: Downloading webpage
WARNING: video doesn't have subtitles
[youtube] _3fusAQT0-U: Looking for automatic captions
WARNING: Couldn't find automatic captions for _3fusAQT0-U
_3fusAQT0-U has no automatic captions
_3fusAQT0-U has no subtitles
When I watch it, it does have subtitles.


Installing gems to network drives in Windows domain environments is slow and painful

ref #338
Please document issues installing gems to network drives in Windows domain environments.
Issues

Gem installs (e.g. chef gem install, bundle) to network drives can be very slow.
berks install to network drives can be very slow since your .berkshelf directory will be on a network drive.
Using gems (e.g. kitchen converge, berks) from network drives can be very slow.
Obviously, you can't do local cookbook testing (kitchen test, rspec) unless you connect to your corporate network via VPN.

Solution
The only way I could get gems to install on my local drive instead of my P:\ drive was to override $env:HOME before calling chef shell-init powershell. See below:
# Set HOME to be c:\users\<username>
# chef shell-init relies on `Gem.user_dir` which is $env:HOME on Windows
# If your $env:HOME is a network drive, using gems from a network drive can be very slow
$env:HOME = $env:USERPROFILE

# let ChefDK set up our environment variables properly
chef shell-init powershell | Invoke-Expression

NOTE: I didn't need to change HOMEDRIVE or HOMEPATH env vars, just HOME.
Background Context
My basic issue is that HOME related environment vars are set to a network drive by AD Group Policy. chef shell-init powershell sets GEM_HOME and other GEM* env vars by calling Gem.user_dir which is $env:HOME on Windows. This will cause issues for anyone who has their HOME referencing a network drive.
HOME          P:\
HOMEDRIVE     P:
HOMEPATH      \

USERPROFILE   C:\Users\doug

I'd rather make this awesome out of the box than just document it (though documenting is fine as a first pass). Is there a different place we could be storing things by default on Windows that would avoid this issue?

Well, you might use  %LocalAppData% directory. See these links for more info:

http://superuser.com/questions/632891/what-is-appdata
https://github.com/atom/electron/issues/1404

@smurawski Doug's suggestion looks promising and I think it would be a big boost to UX on Windows in corp environments. I think we can make the rubygems part of it work by updating the rubygems customization "software" in omnibus-chef, though we probably need something more general, like in the Chef config; for example, when using policyfiles, cookbooks fetched from supermarket are cached in the home dir also. Any suggestions?
Also, I wonder what the best way to switch from using HOME to using LocalAppData would be. In a naive implementation, all of the user's existing gems and such would be orphaned.

We added a bunch of scaffolding for this problem in Chef::Util::PathHelper.home in and #3088 which fixed #2939.
We've got a task on the Ecosystem Engineering team board to spend some time scoping out related work like this and we'll definitely include this then.

Just adding a couple comments from our experience in the field.  Users with network-mapped home drives have trouble using ChefDK and related tools like Test Kitchen, etc.  Our workaround has been to put a bit of powershell into the user's local powershell profile.ps1 to fix it.
https://github.com/ChefRycar/chef-preflight/blob/master/set_home.ps1
Anything you can do to help make this more delightful for corporate users is much appreciated.

I agree - we do need a unified way of handling where and how things get installed.  We currently simply use ENV['HOME'] in a number of places such as within knife.rb, client.rb, inside providers such as the git provider (we look at ENV['HOME']/.gitwhatever), ssh keys, cache files (they sometimes go into ~/.chef/whatever_the_cache_path_is).  On Windows, there is no sensible single place where all these should go and no simple "home" directory that we can work off of.
By default, ruby initializes ENV['HOME'] to be the value of the environment variable %HOME% if it's defined, or the value of %HOMEDRIVE%%HOMEPATH% if defined or the value of %USERPROFILE%.  See https://github.com/ruby/ruby/blob/trunk/win32/win32.c#L509 .  What it doesn't do is check of those paths actually exists or not.  In the case of a user who's administrator has network mounted their home drive, Ruby's defaults will continue to let ENV['HOME'] point to a location that isn't currently available.  chef/chef#3088 was an attempt to fix that by constantly falling back until we were able to find a path we could use.  Unfortunately, that's a workaround in and of itself.  If the user runs a local chef client run and the local caches get populated on their network home drive, a subsequent run without the drive mounted will result in it falling back to the user's profile path.  In the case of a cache..  I guess that's no big deal.  If they wanted a configuration file or dropped their knife.rb in their home directory, now we have a problem.  And for any given particular file (say with the location of ssh keys), one could make the argument that we shouldn't randomly fall back and should really fail if the network mounted home drive isn't available.  The argument could also be made that we be consistent with other external binaries we invoke (such as bundler or gem - which all resolve where the home directory exists in their own way).  Or we could as best as we can to make every dependency we call explicitly place their files in a locally available profile path or LocalAppData path.
Yet other difficulties emerge when we consider that Ruby's File.rename method throws an exception if invoked with paths that aren't on the same volume.  Ruby does a similar sort of dance as above to discover where the best location to put temp files is.  An issue we had was that chef-client (and some other binaries we invoked) would perform actions such as downloading a file to a temporary location (using Tempfile.new or something similar), and then would attempt to move the file to the destination.  Changing these to copies + deletes aren't always straightforward because sometimes the code assumes the move to be atomic (such as when moving a cookbook into the cache).  The issue has been somewhat mitigated in Ruby 2.2 but hasn't been backported to 2.1.5 or 2.0 yet (which is what we use for our windows ChefDK builds).
I guess the tl;dr is: we should be fixing this on a scenario by scenario basis and we should really discourage the use of ENV['HOME'] and Dir.home and File.expand_path('~') etc. throughout all our code-bases and explicitly decide where a file is expected to go in any particular situation.  We should also remember to consider what action is appropriate if that file location is not available such as if HOME is not declared on Linux because you are running as a daemon or if HOMEPATH and HOMEDRIVE point to some network mounted drive because you're on Windows.

Jay is working on this for chefdk gem installs using local app data. We can totally put our own config there also. 3rd part software like git and so on will be hard.

Fix is merged, should be shipped in ChefDK 0.7 https://github.com/chef/omnibus-chef/pull/406


Deployment - Aug 9

Deploy on Aug 9
Planned tickets

1198
617
1251
1253
1235

Follow-up needed - prep work for future deployments needed.


Fix logging

Use readable date-time format in MCO operator and endpoint-operator logs

/test test-e2e

/lgtm


Clarify the use of buildah config options

Make it clearer to the user which options can be executed
multiple times, versus those that can only used once.
Cleanup some documentation issues
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

Fixed https://github.com/projectatomic/buildah/issues/591

bot, retest this please

@rh-atomic-bot r+

@taqtiqa-mark Could you add a PR with the changes you want.


GitClientBase.get_item_text always returns the file metadata

To retrieve the content of a file, it is mandatory to send the 'text/plain' Accept header, otherwise the file metadata is always returned.
There are two issues:

the VSSClient._send hard codes application/json as Accept header
the generated GitClientBase.get_item_text must somehow pass text/plain as Accept header

Similar for the get_item/blob_content/zip functions, they all return meta.

@tedchamb any news on this one?


Fix ORCID API calls

[ ] Added entry into CHANGELOG.md
[x] Documentation updated

Changes proposed in this pull request:

Replace the python-orcid package because it doesn't support the new ORCID API

@pr-omethe-us/chemked

Do we need some tests for the new function?

No, it should all be covered by the existing test suite

CHANGELOG?

I'm good with this other than that change.

In #110


Nipin/issue2038 nurbs

This PR attends to fix #2038 (which fixes #1863 and fixes #2031 ) by intercepting the exception caused by a singular matrix. That way the testing of the number of control points can continue and the NURBS fitting can be done even if a singular matrix is encountered.
Thus, the hanning filtering will not be necessary anymore (if the number of slices if sufficient). Moving away from the hanning filtering is something @benjamindeleener suggested when discussing this problem.
However, no change in the method has been done, should I search for methods to improve the NURBS fitting ?

if this PR is supposed to also fix #1863 and #2031, i would explicitly mention it (so the issues can be closed upon PR merging)
done

Agreed, new issue referenced as #2043

Agreed, new issue referenced as #2043


nvidia-ml-py version conflicts with other packages (e.g., gpustat)

Context: https://github.com/wookayin/gpustat/pull/107 trying to use nvidia-ml-py, Related issues: #4
Hello @XuehaiPan,
I just realized that nvitop requires nvidia-ml-py to be pinned at 11.450.51 due to the incompatible API, as discussed in wookayin/gpustat#107. My solution (in gpustat) to this bothersome library is to use pynvml greater than 11.450.129, but this would create some nuisance problems for normal users who may have both nvitop and gpustat>=1.0 installed.
From nvitop's README:

IMPORTANT: pip will install nvidia-ml-py==11.450.51 as a dependency for nvitop. Please verify whether the nvidia-ml-py package is compatible with your NVIDIA driver version. You can check the release history of nvidia-ml-py at nvidia-ml-py's Release History, and install the compatible version manually by:

Since nvidia-ml-py>=11.450.129, the definition of nvmlProcessInfo_t has introduced two new fields gpuInstanceId and computeInstanceId (GI ID and CI ID in newer nvidia-smi) which are incompatible with some old NVIDIA drivers. nvitop may not display the processes correctly due to this incompatibility.

Is having pynvml version NOT pinned at the specific version an option for you? More specifically, nvmlDeviceGetComputeRunningProcesses_v2 exists since 11.450.129+. In my opinion, pinning nvidia-ml-py at too old and too specific version isn't a great idea, although I also admit that the solution I accepted isn't ideal at all.
We could discuss and coordinate together to avoid any package conflict issues, because in the current situation gpustat and nvitop would be not compatible with each other due to the nvidia-ml-py version.

Hi @wookayin, thanks for raising this.
The reason for pinning the version of nvidia-ml-py == 11.450.51 is to support Ubuntu 16.04 LTS. For the same reason, I also do not drop the support for Python 3.5 (the default Python on Ubuntu 16.04 LTS). Although both Ubuntu 16.04 and Python 3.5 are out of maintenance.
The maximum NVIDIA driver version in ppa:graphics-drivers is the R430 driver (the maximum supported CUDA version is 10.1). The struct nvmlProcessInfo_v2_t was introduced in CUDA 11.x, which requires at least R450 driver. Although the admin can upgrade the NVIDIA driver on UBuntu 16.04 to R465 with a CUDA .deb file. I think the goal of a PyPI package should be usable for users who do not have sudo privileges.
I'm going to add an optional argument to pip and let the user choose the version of nvidia-ml-py themself as:
pip3 install 'nvitop[11.450.51]'
pip3 install 'nvitop[11.450.129]'

We might need to add some fallback mechanisms --- I don't have an universal solution yet without bundling and copy-paste-ing the source code of the nvmlProcessInfo struct or nvmlDeviceGetComputeRunningProcesses_v2 function.

I haven't found a way to solve this either :(. The module pynvml.py provides either the v1 or the v2 struct of nvmlProcessInfo_t, not both. We need to copy-paste the source code.

We could discuss and coordinate together to avoid any package conflict issues, because in the current situation gpustat and nvitop would be not compatible with each other due to the n vidia-ml-py version.

@wookayin I have loosened the dependency constraints to nvidia-ml-py >=11.450.51,<11.500.00.
In gpustat, which are nvidia-ml-py >=11.450.129,<11.495.46 (in nvitop, an extra version 11.450.51 provided for CUDA 10.x drivers).
https://github.com/wookayin/gpustat/blob/cd65b1ef5fe115fd057691a2246263844dffed86/setup.py#L77-L82
For a fresh installation, both gpustat and nvitop will install nvidia-ml-py == 11.495.46:
pip3 install gpustat
pip3 install nvitop

Hi @XuehaiPan,
I'm running into the same issue when trying to install nvitop with cuml in a conda environment:
micromamba create -n test -c conda-forge -c rapidsai -c conda-forge cuml cuda-version=11.8 nvitop

This installs a really old version of cuml (0.6.1), because cuml depends on dask-cuda, which depends on pynvml.
I don't know much about how conda packages are built and don't fully understand the discussion above about Nvidia driver internals, but a fix that resolves this for the conda package would be much appreciated. Thanks!

Hi @mjkanji, maybe you can use pipx to install nvitop in an isolated environment. You can also set it as an alias:
alias nvitop='pipx run nvitop'


Mistake in documentation

"To set the SPEECH_REGION environment variable, replace your-region with one of the keys for your resource."
This is not a key from the resource, it is the region, like "eastus", isn't it?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 064d7074-3ea4-21e4-60b4-b09976bbdf7e
Version Independent ID: 1fdefc18-e765-9fe8-0652-ca18122cb0fa
Content: Text-to-speech quickstart - Speech service - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/get-started-text-to-speech.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @eric-urban
Microsoft Alias: eur

@TonyAtLilly
Thanks for your feedback! We will investigate and update as appropriate.

@TonyAtLilly
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Fix minor grammatical errors

Fixes #382
Minor improvements to sentence structure in development documentation.
Signed-off-by<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 886

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.66%

Totals

Change from base Build 881:
0.0%

Covered Lines:
948

Relevant Lines:
1287

💛  - Coveralls


Analysis server doesn't work correctly if a workspace folder/analysis root does not exist

After pulling latest changes in the SDK, the analysis server didn't work correctly when working on the SDK code. Every request returned:
1700565754126:Res:{"id"::5,"jsonrpc"::"2.0","error"::{"code"::-32007,"data"::"C::\\Dev\\Google\\dart-sdk\\sdk\\pkg\\analysis_server\\lib\\src\\analysis_server.dart","message"::"File is not being analyzed"}}

It seems like this is being triggered by having nnbd_migration in my .code-workspace file (that folder was recently deleted). My guess is that something is going wrong during initialisation that results in no analysis roots being set if one of them does not exist.

Seems like we're getting stuck here:
https://github.com/dart-lang/sdk/blob/742715e57a65275f4914e33a63df40ae4da89b97/pkg/analysis_server/lib/src/context_manager.dart#L669C78-L669C78
It might be Windows-specific. The FS watcher is not becoming "ready" for a folder that doesn't exist. I thought this had some up/been fixed in the past, but maybe it was non-windows (IIRC each platform might have its own watcher implementation).
There's an existing unit test for this that passes (probably because it's specific to the real watcher) but I can reproduce the failure in an integration test. I'll commit that as failing for now since this might require package:watcher changes to be rolled in to fix.

While debugging this, I got to the point of just hard-coding some code here that creates a FileWatcher (which is coming from the real FileWatcher in third_party/pkg/watcher with no extra wrapping/abstractions, and DEPs points at the very latest watcher):

However, a near identical test in the pkg:watcher repo passes:

Will need some more investigation 🤷♂

It turns out there was indeed a bug in watcher, but it was masked because the test setup produced slightly different behaviour in tests to what happened for real.
Working on a fix at https://github.com/dart-lang/watcher/pull/157 and will roll that here once that's done.


Update readme

You are right. This is necessary only for multiplatform app

if this is needed for MPP then its actually a bug, we should be adding that task as a dependency as part of the gradle plugin. Mind opening an issue instead with your MPP target and gradle file?

Take a look at https://github.com/touchlab/DroidconKotlin

yea thats there from the pre-1.0 release when it was necessary, but has since been resolved. That repo just hasnt updated it yet


Enterprise user management API redesign

Fixes #6318
I think I covered all suggestions.
Updated quick start to come.
UPDATE: New quick start: https://gist.github.com/gfiorav/d65f14b32827ce7c7fec
cc/ @juanignaciosl @xavijam @javisantana

I think you're missing the tests, which still send plain text payload instead of JSON, isn't it?

@juanignaciosl yes, right, on it!

Ok, let me know when you want next CR.

I've done some minor comments. Take into account as many as you can. :+1: afterwards.


(SSR) Layout changes after client hydration

Using the storage prop with the new NextJS app directory in a client component causes this error on the SSR step as localStorage is not defined - which is to be expected:
-- error src\components\Panels.tsx (46:48) @ localStorage
-- error ReferenceError: localStorage is not defined

The panel group is set up like this:
<PanelGroup direction="horizontal" storage={localStorage}>

The lack of localStorage on the server doesn't seem to actually cause a problem, at least not an obvious one. Only the error which I'd rather not have.

Reproduced here
https://github.com/bchilcott/react-resizable-panels-144-repro

Thank you for this example! Very helpful.
There are two separate things going on here.
The server error
This first one is easy to fix. Your example code is passing localStorage as a prop. You can fix the server side error by accounting for it being undefined:
  let storage;
  try {
    storage = localStorage;
  } catch (error) {}

  return (
    <PanelGroup direction="horizontal" storage={storage}>

Or better yet, just don't pass anything– since PanelGroup defaults to use localStorage (and won't try to access it server side). All you really need to do is specify an autoSaveId prop 😄
The flickering bug
That being said, there is a flicker after server rendering (between the default size and the async local storage size). Replay 5c0489d5-2845-4413-8b7d-69542d50516c shows this bug happening.
Here is a Loom I recorded where I looked into the issue and kind of just thought out loud:
https://www.loom.com/share/42d87330d06a483896266bc3b831cdd4
tl;dr is that I think you'd need some kind of custom persistence for this– that saved values to both localStorage and remotely (if you want to avoid the size flicker for the initial render. (This is psuedo code)
function Example() {
  const [sizeA, sizeB] = getDefaultSizes();

  return (
    <PanelGroup autoSaveId="whatever" storage={customStorage}>
      <Panel defaultSize={sizeA} />
      <PanelResizeHandle />
      <Panel defaultSize={sizeB} />
    </PanelGroup>
  )
}

function getDefaultSizes() {
  if (typeof window === undefined) {
    // Read from DB
  } else {
    // Read from localStorage (or fall back to undefined)
  }
}

const customStorage = {
  getItem: (key: string) => {
    localStorage.getItem(key);
  },
  setItem: (key: string, value: string) => {
    localStorage.setItem(key, value);

    // Do some fetch() API call
  }
}

Wow - you have no idea how valuable this. Thanks so much for the explanation.
I was definitely using storage wrong - I wasn't too worried about actually persisting the sizes, just making the flickering go away. Out of interest, why does specifying storage={localStorage} with no autoSaveId stop the flickering from happening?

I'm glad it's helpful!

why does specifying storage={localStorage} with no autoSaveId stop the flickering from happening?

PanelGroup will only persist the size if an autoSaveId prop is specified 😄

Sorry, I'm probably misunderstanding it. Does that mean there should be no functional difference between the following, if no autoSaveId is specified?
<PanelGroup direction="horizontal">

<PanelGroup direction="horizontal" storage={localStorage}>

Because using the first example I get this layout shifting from 50/50 to the specified default sizes:

And with the second example, although the sizes obviously aren't persisted, they initialize to their defaults immediately:

I wouldn't expect specifying a storage option to make any difference here.

We are talking about two "defaults"
One default comes from the size you pass to <Panel defaultSize> and gets used when the user first sees the panel group.
If you pass an autoSaveId to PanelGroup– the second "default" is when a user resizes a panel, and then returns to the page later. In this case, the group should show the previous sizes the user chose.
That's the flicking with SSR, for reasons I mentioned in the Loom. The reason you don't see this if you just pass storage is because– without an autoSaveId– the PanelGroup doesn't try to save or restore the sizes.

Ah, got you. Thanks. Enjoy your coffees 😉

Oh! Thank you :)

Okay, either I'm just totally misunderstanding, or I'm having a different issue altogether. The fix you suggested fixes the localStorage undefined error, but brings the flickering back:
// Flickering happens
  let storage;
  try {
    storage = localStorage;
  } catch (error) {}

  return (
    <PanelGroup direction="horizontal" storage={storage}>

// Flickering happens
  return (
    <PanelGroup direction="horizontal">

// Flickering happens
  return (
    <PanelGroup direction="horizontal" autoSaveId="something">

// Flickering *doesn't* happen, but localStorage undefined error
  return (
    <PanelGroup direction="horizontal" storage={localStorage}>

To be clear, I'm not worried about persistence. As long as the values provided to Panel in defaultSize are the first thing the user sees, that's fine. I don't actually need the sizes to be persisted in localStorage or anywhere, it just so happens that passing storage={localStorage} to PanelGroup stops the layout from shifting. I understand that if I did want persistence, the sizes would have to be stored somewhere accessible to the server.
All I really want is to do is the following, with no flicker on the initial render:
<PanelGroup direction="horizontal">

Sorry this has been a bit of a rollercoaster of me confusing myself. I feel like storage shouldn't even be playing a part here.

Agreed! In hindsight, I should have spotted this last night but it was late 😄
What's actually happening is that the PanelGroup doesn't compute its default sizes until it mounts:
https://github.com/bvaughn/react-resizable-panels/blob/a5108d9db370711dedc01a043718f1ee384223c1/packages/react-resizable-panels/src/PanelGroup.ts#L230-L233
I think I need to find a way to move this initialization logic into the render.

but it was late 😄

Yeah.. 4am clearly isn't the best time for me to do this 😅 Good to know though, and the discussion around SSR and storage is still good to have.
I'll think about this some more.

I think I have an idea that could work. Will try to test it out soon.

Maybe it wouldn’t need to be required except for SSR use cases. I think it will work though.
I’m traveling today but I’ll try to get an update published for this within the next day or two.

I think 259d794 should fix this, provided you specify a defaultSize prop for all Panels.

And 264f4c5 will detect and warn about this case if you forget that prop:

This fix will ship in 0.0.44 in a few minutes.
Thanks so much for the repro project. It was very helpful for me to verify this fix.

0.0.45 released

Btw I added an FAQ section here showing how to use a Cookie to avoid "flicker" for persisted layouts:
https://github.com/bvaughn/react-resizable-panels#how-can-i-use-persistent-layouts-with-ssr


docs: new doc website lacks documentation of service and ingress

What happened?
Wanted to review "ingress" configuration info, but seems to be missing.
What did you expect to happen instead?
How can we reproduce the bug? (as minimally and precisely as possible)
Local Environment:

DevSpace Version: [use devspace --version]
Operating System: windows | linux | mac
Deployment method: helm | kubectl apply

Kubernetes Cluster:

Cloud Provider: google | aws | azure | DevSpace Cloud | DevSpace Cloud Enterprise | other
Kubernetes Version: [use kubectl version]

Anything else we need to know?
Hmm... you had "search" -- right? Can we re-enable?

/kind bug

There is actually a separate documentation site for this now: https://devspace.sh/component-chart/docs/introduction
The reason for this is that the component-chart is independent of DevSpace, i.e. it can be used with helm directly, and it also has an independent release cycle, i.e. the versions are not the same and the code is also in a different GitHub repository. There are a couple of links in the DevSpace CLI docs which point to the docs of the component-chart. Maybe, I need to add a couple more to make it more obvious ;)
PS: Search had to be disabled because Algolia needs 24h to index a page after the URL has changed. I will enable search on all 3 docs sites (cli, cloud, component-chart) later today, when the index should be filled again.

Ok -- great. Yes ... a couple more links please! :)


Rename code-of-conduct.md to CODE-OF-CONDUCT.md

[x] Please merge this PR for me once it is approved.

@tbpg changed.


[Bug]: Clipboard does not work

Steps to reproduce the bug
I can copy and paste things into the clipboard, but I cannot use any Alt or Command keys to get the text into any TW form.
When I am transcribing data into the comprehensive specimen digitization form, I often have many specimens with the same determination. I can copy and paste that info into the clipboard. When I go to the next specimen, I can copy and paste the info from the clipboard back into the form, but I cannot use any hotkeys or shortcuts to move the text.

Screenshot

Expected behavior
I expect to be able to use short cuts or hotkeys like Alt-1 to make my transcribing easier and faster.
Additional Screenshots
No response
Environment
Production
Sandbox Used
No response
Version
No response
Browser Used
Chrome

@mmkohler what OS, PC, mac, or linux?

I can't replicate it. Looking the screenshot I assume it's Windows 10/11.
Could you try again using incognito mode, @mmkohler ? Maybe your bug could be related to an browser extension

I tried it in incognito mode and the clipboard worked. Why is that?

I think Chrome disables extensions in incognito mode? Maybe you could try disabling extensions one by one until you see it starts working (in regular browsing mode)?

Like @LocoDelAssembly said, the incognito mode doesn't use any extension. So, you may have an extension that is interfiering with the hotkeys. Follow @LocoDelAssembly advice and see if that fix your issue

@mmkohler I'm going to close this as agnostic to your browser setup.  Please re-open if you think it is not, for example if you can replicate on another browser on a different machine.


Error in running with flag_nms= True

When I run demo_video_mobile.py after setting flag_nms = True I get the following error :-
TypeError: list indices must be integers or slices, not tuple
For the following code inside the function def apply_nms :-
keep = np.where((cls_dets[:, 4] >= min_scores) &
((cls_dets[:, 3] - cls_dets[:, 1]) * (cls_dets[:, 2] - cls_dets[:, 0]) >= min_box_size))[0]
When I first convert cls_dets into numpy array by cls_dets = np.array(cls_dets) and then execute, the following error is shown :-
IndexError: too many indices for array
This is because the shape of cls_dets is (4,) while the code written is for a 2 dimensional array.
Please suggest a solution so that I can apply non max suppresion with this code.

Hi Atishaysjain,
could you please share your env dependencies file with all the version numbers? and the cuda toolkit version.
When you first ran demo_video_mobile.py did you see the following error?
Traceback (most recent call last):   File "demo_video_mobile.py", line 28, in <module>     from nms.gpu_nms import gpu_nms ImportError: /home/peeterson/Desktop/lighttrack/HPE/../lib/nms/gpu_nms.cpython-36m-x86_64-linux-gnu.so: undefined symbol: __cudaPopCallConfiguration
If you did could you share how you solved it? thanks.


Can't save state: Error writing file

When I try to save state i receive this message:

Even though I allowed writing to the application:

More Details
:video_game: Device Type
I am using an Anbernic RG505 handheld.
Kind of Emulator
SNES - Super Nintendo Entertainment System

I think this is related to emulator itself?

I think this is related to emulator itself?

Really you are right. The problem was in snes9x.
To resolve. Open the snes9x app
Option >> System >> Save Path: snes >> Select Folder to save
I appreciated your help.


Online OSX machine

Machine dci-mac-build-313 was taken offline from the osx.1200.amd64.open queue for investigation. We'll need to put it back online when @michaelgsharp has completed his work.

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

Done


Sub is not removed if ride was added from a shared link

https://github.com/andyblarblar/queue_alert/blob/6204f308e5bf37f477b877deccbaa3a35c8a4d8d/queue_alert_frontend/app/src/components/UseConfigSave.tsx#L22
Not sure why this occurs. Should be related to above line.

This only occurs if the ride is immediately removed. If the ride is reloaded from the db, the error does not occur.

It looks like this is caused not by the shared link, but by the trash can delete. The trash can delete doesn't reset the config when empty, preventing the park from becoming 'none'

nvm this is caused by only a single shared ride being deleted by the trash can. It seems to be an issue with the table not rendering, and thus the unsub event not firing.

It looks like swapping https://github.com/andyblarblar/queue_alert/blob/6204f308e5bf37f477b877deccbaa3a35c8a4d8d/queue_alert_frontend/app/src/components/configTable.tsx#L25
with https://github.com/andyblarblar/queue_alert/blob/6204f308e5bf37f477b877deccbaa3a35c8a4d8d/queue_alert_frontend/app/src/components/configTable.tsx#L32 may be solve this, as the config may be saved (and thus not none yet) before its reset. Effects are run in order.


Name of job set by displayName() must be honoured by Schedule

Queue jobs could have displayName() method providing a better naming than just a plain classname. This name is currently honoured by a queue worker but a queue scheduler. This PR fixes this inconsistency

Added a check to make sure the container hasn't instantiated a job.

@SanderMuller , @RobertBoes , please check this out


Don't set defaulttime when no date selected yet

When we have a datetime picker setup we'd like to be able to cancel a date selection by clicking outside the picker. Currently when you do this the current datetime is set in the input. (see https://jsfiddle.net/whba0e4o/) and click the input and click outside.
If you don't set the defaulttime when there are not dates selection your are able to cancel the datetime selection and leave the input empty. And you can remove the input to clear the datetime as well which you are not able to do currently
fix for #2094

@chmln Can this PR (or similar) be included for the next release? It's an annoying issue and has been mentioned by multiple users: #1972 #2028 #2060 #2106 #2113

@chmln Could you please check this issue?

@jmadkins Yes.


changeState instead of file rollback

@h1alexbel thank you for reporting this. I'll assign someone to take care of it soon.

@h1alexbel this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2023-08-20T18:59:15.027817.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

<states>
  <changeState id="1" author="test">
    <files>
      <file path="001-initial-keyspace.cql"/>
      <file path="002-queries-table.cql"/>
    </files>
  </changeState>
</states>

@h1alexbel 2 puzzles #36, #37 are still not solved.

@h1alexbel 4 puzzles #36, #37, #47, #48 are still not solved.

@h1alexbel 5 puzzles #36, #47, #48, #49, #50 are still not solved; solved: #37.

@h1alexbel 4 puzzles #36, #47, #48, #49 are still not solved; solved: #37, #50.

@h1alexbel 4 puzzles #36, #49, #64, #65 are still not solved; solved: #37, #47, #48, #50.

@h1alexbel 4 puzzles #36, #49, #64, #98 are still not solved; solved: #37, #47, #48, #50, #65.


Highlight foreign key relations on click

Highlights foreign key relations (bold red lines) to be able to better follow where they lead.

Thanks!


get rid of several deprecation warnings

Amazing! Many thanks :)

I see that the build is failing after this pull request. @eleurent, do you have any idea why?

I just checked, it was the test that checked the simulation speed (fps) that failed (it was lower than some threshold).
I think it may have been a fluke, maybe related to the computation load on the test server?
Anyway, I ran the test again and it passed, so it's probably fine (or unrelated to this change anyway).


List users that are created

Please add the ability to list created users.

Added a link in "User" page for admin user to view all existing users. Click the link will display all existing users in a table. Click again will hide the table.

Hi Xrao, works perfectly, thanks.

Thanks for the fast response!


webui - "cgi" handler and multiple fixes

implement a handler for calling c++ functions via uri.
e.g. /cgi/cfg_hyperion
calls CgiHandler::cfg_hyperion() this will output the current hyperion config.
Parameters are also possible. /cgi/myfunc/param1/param2/param3
will call myfunc with a stringlist containing the args param1-3
other fixes:
try to fix #688 effect python scripts filehandle not released - seemed works for me, but needed feedback from others
zeroconf works again. hyperiond needs extensive refactoring - hyperiond.cpp should be splitted in several files and classes!
fix webconfig won't compile on some platforms.
Hyperion object saves the jsonConfig. All classes with access to hyperion object can query configuration via hyperion->getJsonConfig()

https://github.com/hyperion-project/hyperion/commit/52062025685f341f6d1bbf82412bc35e00b74294


Feature/validate submission

Description
Adds basic submit, validate and error reporting
Fixes #
https://finrms.atlassian.net/browse/GEO-76
https://finrms.atlassian.net/browse/GEO-70
https://finrms.atlassian.net/browse/GEO-71
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Some new backend unit tests

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have already been accepted and merged

Unit tests and sonar issues will be fixed in another code merge


program 3 and Hangman game are same

hello supreeth m :)
the program3 and hangman game are same..need to change the file name and delete the duplicate

i have deleted the duplicate one.please accept the pull request


Where Is The DIP Switch Settings and Explaination?

There are dip switches on the board.  But I haven't found anywhere that describes what these do if you change them.

There are dip switches on the board. But I haven't found anywhere that describes what these do if you change them.

I was also looking for that, but they seams to rush it up with the documentation. Thankfully, there is a schematic showing the configuration.


Migrate to Jest (mostly)

Karma + Jasmine + PhantomJS is slow.
PhantomJS is unstable. (CI has been failing since b5b8e29 due to PhantomJS crashing in the middle of tests; I am unable to reproduce this behavior locally.)
Jasmine

I'd love to migrate the whole project to Jest because it's much faster. Unfortunately a couple of components (AutoSizer and CellMeasurer) depend on a more robust browser than JSDOM and currently that's all that Jest supports.
So my proposal for now:

Split NPM test:unit script into 2 child tasks: test:unit:jasmine and test:unit:jest
Rename all tests that can be run in Jest from *.test.js to *.jest.js

On a related note, this seems to work for anyone who needs to mock out AutoSizer for snapshot testing:
// __mocks__/react-virtualized.js
import React from 'react';

const reactVirtualized = jest.genMockFromModule('react-virtualized');

const MockAutoSizer = () => {
  return <div />;
};

reactVirtualized.AutoSizer = MockAutoSizer;

module.exports = reactVirtualized;

Then at the top of your test file, do:
jest.mock('react-virtualized');

Thanks for sharing that approach @elevine. 😄  My suggestion for testing RV components in an external project is actually to structure your code like so:
/** components/MyAutoSizedComponent.js **/
import React, { Component, PropTypes } from 'react';
import { AutoSizer } from 'react-virtualized';

// Production code uses this for convenience.
export class MyAutoSizedComponent extends Component {
  render () {
    <AutoSizer>
      {({ width, height }) => (
        <MyAutoSizedComponentImpl
          {...this.props}
          height={height}
          width={width}
        />
      )}
    </AutoSizer>
  }
}
export default MyAutoSizedComponent;

// Test code imports this and injects explicit size peops.
export class MyAutoSizedComponentImpl extends Component {
  static propTypes = {
    height: PropTypes.number.isRequired,
    width: PropTypes.number.isRequired
  };

  // Other stuff ...
}

And then your test might look like this:
/** components/MyAutoSizedComponent.testjs **/
import { MyAutoSizedComponentImpl } from './MyAutoSizedComponent'

// Inject explicit size props for easier testing
<MyAutoSizedComponentImpl
  {...otherProps}
  height={200}
  width={400}
/>

Thank you @bvaughn ! That totally makes sense.
One concept I'm struggling with though is how would you apply that approach as you get higher up in your app's hierarchy.  For example, let's say I have a modal with a search input and a list of results that is structured like this:
<MySearchModal>
  <MyModal>
    <MySearchComponent>
      <MySearchBox />
      <MySearchResultsList>
        <AutoSizer>
          <List />
        </AutoSizer>
      </MySearchResultsList>
    </MySearchComponent>
  </MyModal>
</MySearchModal>

One thought I have is that you can apply your approach to testing MySearchResultsList and use Jest mocking to handle RV components while testing MySearchModal.  This way you get coverage for everything.  I'd love to hear your input though.

You could use Jest to mock the component (swap the auto-sized with manually sized).
I've also, occasionally, used props like heightForTest and widthForTest and used those instead of the AutoSizer values if present. That's kind of a hack though.

@bvaughn Thanks for all your work!

Jest because it's much faster

Unless I'm missing something, the build now takes around 4 min while it was taking 3 min before.
From my experience at @doctolib jest runs about 7 tests/minutes while mocha + karma handles 20 tests/minutes. I don't understand that performance argument, I guess the value come from somewhere else. Please enlighten me 💡 .

I'd love to learn more about your benchmarking experience with Jest and Mocha. Jest's running of tests in parallel is much faster in my anecdotal experience (within this project).
More to your point though, build times were never a concern for me with this project. Iterating on tests (running in watch mode) was. Jest is much more responsive for the use-case. I'd like to eventually migrate everything to use Jest but...I'm stuck with a few tests in PhantomJS because of lack of certain JSDom layout features.

I'd love to learn more about

We have around 1800+ tests, we have tried to migrate to jest, but that was way too slow.
We reverted to our Mocha + Karma + PhantomJS test suite.

Iterating on tests (running in watch mode) was.

I guess that's what I was looking for! We haven't looked at the iterating response time.
That need more investigation from my part. Thanks.

No problem. That's interesting to learn! I'm not using Mocha so that may
also account for some of the difference in our impressions.
I've been really impressed by Jest's mocking and snapshot functionalities.
I hope to take advantage of both going forward.
Also worth pointing out that PhantomJS has been crashing for me in CI
environment for weeks. Could not reproduce locally. Overall seemed very
flaky. Despite its limitations, JSDom seems more robust.
Given its limitations for that matter- I'm surprised you would see faster
results from Mocha+PhantomJS than from Jest+JSDom just because of the
browsers alone.
Oh well. :grin: Glad you started this conversation either way. It's
interesting.
On Jan 28, 2017 1:04 PM, "Olivier Tassinari"<EMAIL_ADDRESS>wrote:

I'd love to learn more about
We have around 1800+ tests, we have tried to migrate to jest, but that was
way too slow.
We reverted to our Mocha + Karma + PhantomJS test suite.
Iterating on tests (running in watch mode) was.
I guess that's what I was looking for! We haven't looked at the iterating
response time.
That need more investigation from my part. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bvaughn/react-virtualized/issues/539#issuecomment-275874551,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABznXTzSvMTfwlnvOIx98-fI5wroIfqks5rW61kgaJpZM4Lj-Jm
.


[FEATURE] Use newtype pattern for email addresses

Feature Description
This issue covers one of the problems mentioned in #119, about using the newtype pattern for email addresses. The requirement is that email addresses must be validated once during construction/deserialization and should never be validated again. This would also eliminate the validation being performed at the time of masking email addresses (specifically line 97 in the snippet):
https://github.com/juspay/hyperswitch/blob/d107b44fd356f172ef7c9535567d266a6301e43d/crates/common_utils/src/pii.rs#L87-L109
Please also include unit tests in your PR.
For external contributors, clarify any questions you may have, and let us know that you're interested in picking this up. We'll assign this issue to you to reduce duplication of effort on the same task.
Possible Implementation
You can use a newtype like so:
use masking::Secret;

struct Email(Secret<String>);

let email = Email::from_str("..."); // You can use the `FromStr` trait for this purpose

For validating emails, the existing regex validation should suffice. Also, implement Serialize, Deserialize and masking::Strategy for Email.
Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to submit a PR?
None

Hi,
I am not accustomed to the hyperswitch code base, but I would like to take a look at this issue. Will probably need some help though.

Hey @phillyphil91, I'm afraid there's already a WIP PR for this issue by @nachiketkanore.
If you're interested, you can take a look at #606. I can answer any questions you may have about that issue.

Ah sorry. I overlooked that. #606 sounds good.

No problem, please leave a comment on the issue that you're interested, and I'll assign it to you.


Facebook image post

Hi everyone, how I can add facebook image of post? Thanks

Hi @didsun have a look at the jQuery template that we're using https://github.com/christianv/jquery-lifestream#jquery-templates and https://github.com/christianv/jquery-lifestream/blob/2fb537ade49de5b4097753ea263ff9c61428cad3/src/services/facebook_page.js


Getting raw input for split messages.

In some cases it would be helpful to have the bot not split sentences.
In particular, sentence splitting makes it difficult to work with raw user input - as the split messages carry a the raw original message in the properties and not the raw component.
Some possible solutions:

adding a property like rawChunk to the message object that provided the raw input for that message chunk
enabling a global option to turn off sentence splitting.

Correcting above from rawChunk - originalChunk is actually what would be preferred for the purpose of working with original user input.

I have added a global option to disable message chunking. You need to pass an option into the superscript constructor called chunking with false to disable it.
ie:
new superscript({chunking:false /* other options */ }, function(err, bot) {
...
});


Hotfix - Fix branding logo on login screens

Removes the GetCandy logo stamp component and replaces it with the new Lunar logo.

We OK to merge this? Just a simple change @glennjacobs


能提供下baidu网盘的下载地址吗

interactive_data/data.json is the dataset used in the experiments of the paper (5500 instances in total). interactive_data/data_zhihu.json is additional dataset collected alongside this paper (~900 instances), with the question sourcing from Zhihu, you can use this for data augmentation.

See https://cloud.tsinghua.edu.cn/d/eaac53d406a540bb9434/

See https://cloud.tsinghua.edu.cn/d/eaac53d406a540bb9434/

三克油，非常的感谢，yyds


Changes to build_artifact_python.sh not reflected when building artifacts

gRPC version: 1.11.0.dev0 (Built from source)
OS: Ubuntu 16.04 xenial
Kernel: Kernel: x86_64 Linux 4.4.0-112-generic
This is (probably) more of a question and less of an issue. I made some changes to build_artifact_python.sh for adding grpc_testing to the artifact build process.
Specifically, I started by adding the relevant lines after the instructions to build the health-checking source distribution as follows:
...
  # Build gRPC reflection source distribution
  ${SETARCH_CMD} "${PYTHON}" src/python/grpcio_reflection/setup.py \
      preprocess build_package_protos sdist
  cp -r src/python/grpcio_reflection/dist/* "$ARTIFACT_DIR"

  # Build gRPC testing source distribution
  ${SETARCH_CMD} "${PYTHON}" src/python/grpcio_testing/setup.py \
      sdist
  cp -r src/python/grpcio_testing/dist/* "$ARTIFACT_DIR"
fi

cp -r dist/* "$ARTIFACT_DIR"
...

But when I run task_runner.py as given in run_tests README for building artifacts, the change doesn't seem to be reflected at all. It simply skips over the added lines (actually, doesn't see it even).
Command: tools/run_tests/task_runner.py -f python artifact linux x64
Here's the relevant part of the build logs:
copying grpcio_reflection.egg-info/requires.txt -> grpcio-reflection-1.11.0.dev0/grpcio_reflection.egg-info
copying grpcio_reflection.egg-info/top_level.txt -> grpcio-reflection-1.11.0.dev0/grpcio_reflection.egg-info
Writing grpcio-reflection-1.11.0.dev0/setup.cfg
creating dist
Creating tar archive
removing 'grpcio-reflection-1.11.0.dev0' (and everything under it)
+ cp -r src/python/grpcio_reflection/dist/grpcio-reflection-1.11.0.dev0.tar.gz /var/local/git/grpc/artifacts/python_linux_x64_cp27-cp27mu
+ cp -r dist/grpcio-1.11.0.dev0.tar.gz /var/local/git/grpc/artifacts/python_linux_x64_cp27-cp27mu
+ cp -r tools/distrib/python/grpcio_tools/dist/grpcio-tools-1.11.0.dev0.tar.gz /var/local/git/grpc/artifacts/python_linux_x64_cp27-cp27mu
+ '[' artifacts '!=' '' ']'
+ docker cp build_and_run_docker_00c32b22-584a-46da-a7b8-6975f1c9b873:/var/local/git/grpc/artifacts /root/grpc
+ docker rm -f build_and_run_docker_00c32b22-584a-46da-a7b8-6975f1c9b873
build_and_run_docker_00c32b22-584a-46da-a7b8-6975f1c9b873
+ '[' '' '!=' '' ']'
PASSED: build_artifact.python_linux_x64_cp27-cp27mu [time=1421.6sec, retries=0:0]

I've tried doing this with a fresh git clone & build and a complete docker system prune. Tried running the task_runner script both inside a virtualenv and out. Been stuck with this for about 2 days now.
Is this expected behaviour or am I missing something? Please help.

Simple sanity-check question, but: have you tried changing the script to do the wrong thing? Like crash? If so, does it crash? If it doesn't, does that mean there's some broken link along the line from code that you know is being run to code that you think should be run but isn't? If so... put crashes in every link in the chain and trace how things are getting run in a way that's different than your expectation?

I did indeed try breaking the file by removing one of the existing build instructions, but the artifacts were getting created nonetheless (i.e. changes not reflected even in that case). I didn't attempt breaking the entire chain though. I'll definitely give it a shot in the morning!

Fixed in #15819. The only extra differences seem to be changes to MANIFEST.in.


[6.x] Add make:config command

In the spirit of all of the other great artisan make commands, I found my self wanting a make:config [name] command, as it's one of the few things that I always have to manually create.
This should not introduce any breaking changes, as it's simply registers a new generator with a simple stub.
Let me know if there are any additions you'd like made, I'd be happy to push this further.
Thanks 👍

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Should scope of prefer-await-to-then rule be limited to functions?

Description
I'm just wondering if the scope of prefer-await-to-then should be limited to functions.
// Valid, case for await, has to be in a function
a = async () => (await something())

// However this is invalid Await apparently can't be in the root
a = await something(); // invalid

// So we have to use `.then`, however it gets caught in the prefer-await-to-then rule
something().then(a => {...})

Expected behavior:
Scope of prefer-await-to-then should be limited to functions

Ah, this case makes sense. I think it'd be good to revisit this rule and add support for what you're expressing. 👍

any idea when this will be merged?


Disable Auto Pan (false) not working on Android

Without passing disableAutoPan: false, the effect is working on iOS, also if we add that attribute while creating the marker still not working on Android. So at the moment this attribute is always true on Android.

Um, I could not reproduce your issue.
map.addMarker({
  position: {"lat": -33.867487, "lng": 151.20699},
  disableAutoPan: true,
  draggable: true,
  'title': 'infoWindow',
  'markerClick': function(marker) {
    marker.showInfoWindow();
  }
});

I can try to record the screen on iOS as well but there are no issues on that platform.
https://drive.google.com/file/d/0BzzwDw5jEO0xc211S2RKN0UwYjg/view?usp=docslist_api
I'm using cordova 6 + ionic 2. Let me know if you need something else.
BTW, can you share that apk with me?

Oops, I mis-read your question... :(
You asked disableAutoPan = false does not work.

Fixed: I'm sorry, long long time ago, I created a wrong patch.
https://github.com/mapsplugin/cordova-plugin-googlemaps/commit/fc88d129676397eed81853761b50853f01bead59#diff-a1ab80937241428ba084115768af12e4R1125
Please use the master branch.


require third party dependencies

I don't see a way to set third party dependencies for a given module.
For example, 2 out of 3 modules require D3 but are not accessed often. I could load D3 on initial page load or compile it in with each module script but that would lead to loading it unnecessarily or more than once.
I've also tried wrapping my feature modules like so:
define(function(require) {
    require(['d3'], function() {
        angular.module('myModule', [])
        //... my app code here
    })
});

But this causes the module to be loaded after overmind has already booted the module and throws a " Failed to instantiate module "myModule" due to:
Is there a way of doing this somehow?
Thanks!

Yeah just use the module as a regular dependency:
define(function(require){
  require('d3');
});

And then in your require.js build config exclude that module (d3) from each of your build modules:
{
modules: [
  {
  "name": "myModule",
  "exclude": ["d3"]
  },
  {
  "name": "myOtherModule",
  "exclude": ["d3"]
  }
]
}

Now when either of your apps are loaded, d3.js will also be loaded but only once.


Fix self_signed_should_fail for macOS.

I'm not sure what exactly happened in #11928, but that PR changed this error text in what I think is an incorrect way. At least, I cannot reproduce what happened. The original text seems to be correct and this PR restores it to the original text which works correctly on my systems.

@bors r+
Thanks!

:pushpin: Commit a2ed96df6ab6bee824aa5669bb744b7815408ec7 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit a2ed96df6ab6bee824aa5669bb744b7815408ec7 with merge 5409b7f59ba623f9d291e56f6a21faf5de7d80e1...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 5409b7f59ba623f9d291e56f6a21faf5de7d80e1 to master...


Fix user creation without token return

Problem
When an unexpected HTML or non JSON return (but an existing return instead of error) was returned from Patreon API (potentially due to a maintenance page, or cloudflare error page in cases like the ones from last summer) a new user logging in via Patreon was still being registered in the remote WP site.
This could have potentially caused creation of spammy accounts in remote WP sites if Patreon API was returning HTML for a duration, only for the duration HTML returns lasted. The situation did not have any security concerns attached.
Solution
Added a check for a proper return from Patreon API that prevents user registration/login if return from Patreon API is received in HTML form. Added a notice to tell users that they are not able to log in because their details werent acquired from Patreon.
Verification
Tested in live test site, works.
Does this need tests
Not necessary.

Yeah, its a bit sloppy - i used what the plugin already had before we started work on it, to cut any need for design passes since it was urgently needed. We may do a design pass in future whenever we have the time and resources.


Setup the Analytics and the user consent in the iOS documentation

Description
As a User of the dev documentation
I want be asked if I consent to share the information of my usage of the site
So that I can decide to accept or refure to contribute to the data analytics gathering
As a Product Owner of the Design System
I want to view the dev documentation usage
So that I can drill down all the plateform specific usage
Requirement

The current Analytics tag used in the ODS documentation should be used in this dev documentation as well
The current consent request used in ODS setup should be used in this dev documentation as well

@B3nz01d We need more details about this feature.

What is the analytics solution?
How should it be used?
How should it be integrated?
What for?

We only have a very small HTML pages generated on the fly, seem boring and complicated to add a consent and analytics solution for the documentation. Do we got useful inputs and data with the ODS experience?


Feature: TestSeed  needs to be set in TestRun Model

Currently we are not setting the TestSeed in the TestRun model.
After further discussion we should set this.  We should set this per sendReport depending on how we process multiple xml

(Ginko-client) is currently setting this to be the timestamp.
We can for now set this also as timestamp up to nano seconds.
This needs to be unique

Later we will need to add a suffix to this

What is the suffix?

Later we will need to add a suffix to this

What is the suffix / what was the reason for adding a suffix?

i have removed that as it is not time yet for adding a suffix and would require a bigger group coordination


Fix py3 compatibility

Fix one case of using "except Exception, e"
Replace all uses of print with print()
Quieten flake8

Wait for it... there's more :)

This can now successfully run a simple Py3 test suite [unittest based].


0.3.5 Failed setup for HA ONVIF integration

Hi
My Camera is a Yi Home 1080p
BFUS type
Using the y20ga (0.3.5) firmware
I tried HA ONVIF integration and had the following 'Warning': -
Source: config_entries.py:432
First occurred: 19:11:07 (1 occurrences)
Last logged: 19:11:07

Config entry 'YiCamTest - 38:01:46:d0:2d:9a' for onvif integration not ready yet: Could not connect to camera: ActionNotSupported: <Element {http://www.w3.org/2003/05/soap-envelope}Detail at 0x5d01d868> (code:env:Receiver) (subcodes:{http://www.onvif.org/ver10/error}ActionNotSupported); Retrying in background

Maybe this log is of some use to you?
By the way, I have the camera integrated as a Generic Camera and was having some connection issues where the snapshot kept going black and then coming back again. Since upgrading to the 0.3.5 firmware, it's been a far more stable connection to the camera. I can't really see a benefit of me going back to the ONVIF integration but I thought I'd let you know anyway.
Thanks

Apart from the warning, does the onvif integration work?
Did you try my integration?
https://github.com/roleoroleo/yi-hack_ha_integration
And another problem: 0.3.5 is not yet released, probably you managed to download it while i was preparing the release page.
This shouldn't be a problem, but you should reinstall it when I will release.

No it doesn't work. I thought it was strange that it shows as a warning rather than an error because it doesn't actually create the entity.
I installed the pre-release of 0.3.5; something that was so easy I was shocked! I thought I'd have to faff about with reconnecting the camera but obviously your firmware doesn't overwrite the wifi settings, etc. Superb!
TBH I've got the camera working with Generic Camera and it's fine for my purposes, although it's great to know your integration exists, if I have problems in the future.
As always, thank you so much for this fantastic firmware and for your readiness to respond and find solutions to problems, it's very much appreciated.

I can confirm that everything is now working again with 0.3.6.
Many thanks


Support forward references for Alternative type (simple case)

Motivation and Context
Support forward resolution (works for Bexpress example)

could work for other Alternative forward references, by reordering generated code.

Approach
For Alternative, support overlapping members with different types -- accessors will return a OneOf type in that situation.
Forward references are represented as a Forward type, with small adjustments to make the python forward references work in the c++ case.
How Has This Been Tested?
Trigger test with "make cpptests".  Simple tests created for NamedTuple and Alternative direct c++ types.

superseded


Integrate knex

Integrate knex into QueryBuilder and Connection. This will allow handling easier connection pooling implementation and will come handy when building better schema management support (like computing differential updates).
Knex instance will be used as an SQL client in newly created AbstractSqlConnection. It will allow executing plain SQL statements (strings) as well as knex query builder instances. Current QueryBuilder class will use this knex client under the hood to build the query. Users will be able to get this configured knex instance and build custom queries with knex directly.
It should allow us to simplify schema generator and remove some parts of Platform implementations.
This will probably bring some breaking changes. Follow up to #56.

Available for testing via next tag.


Weird-looking obook page is the evil twin of a real obook page

https://oboacademy.github.io/obook/lesson/ontology_pipelines/ looks weird
The correct page is https://oboacademy.github.io/obook/lesson/ontology-pipelines/ but I got to the underscore mutant version from https://oboacademy.github.io/obook/reference/troublehooting-robot/  (which I notice has a typo in the URL, not that that really matters), which I got to by searching for ROBOT in the obook search.

You might want to consider running a link-checker on https://oboacademy.github.io/obook/!


Increase NotSupportedWarning height according to design

I've put 96px equiv. height - prev. height was equal to 78px. Also 96px is a target height from figma

I would make it a bit higher, even if it'll be different from designs. Maybe h-28 or even h-32. I think 96px is still a bit to small to be easily noticed. I would go with h-28 personally.

h-28 works well too but imo its max we should go with. On h-32 paddings starts to be bigger than content inside, that looks unnatural


Layer SRID

With the introduction of Openlayers (XYZ v2+) we want endpoints to be able to work with different SRID geometries.
The SRID parameter which is required will be set as default but may be altered depending on the layer geometry.
The defaults are 4326 for grid, cluster, geojson and 3857 for mvt layer.
The bounding box must be provided in the SRID defined and geometries will be returned in the same SRID.

is this still relevant now we have support for map/layer SRID?


Annotator overlay forces shared axes

ALL software version info
Python              :  3.9.18 | packaged by conda-forge | (main, Aug 30 2023, 03:53:08) [Clang 15.0.7 ]
Operating system    :  macOS-13.5.2-arm64-arm-64bit
Panel comms         :  default
holoviews           :  1.18.0
bokeh               :  3.3.0
hvplot              :  0.9.0
jupyterlab          :  4.0.7
holonote : 0.1.0a11
Description of expected behavior and the observed behavior
Overlaying an annotator object on the source plot of a RangeToolLink forces the axes to be shared across the source and target plots, which makes the minimap unuseable.
@Hoxbro, I vaguely remember you showing me a potential fix/workaround for this at some point...?
Complete, minimal, self-contained example code that reproduces the issue
import holoviews as hv; hv.extension('bokeh')
from holoviews.plotting.links import RangeToolLink
from holoviews import Dataset
from holonote.annotate import Annotator, SQLiteDB
import numpy as np

connector = SQLiteDB(table_name="demo")
spec = {"time": np.int64}
annotator = Annotator(spec, connector=connector, fields=["type"])
annotator.set_regions(time=(5,6))
annotator.add_annotation(type="type1")

time = np.arange(0, 1000, 1)
amp = np.sin(0.1 * time)

ds = Dataset((time, amp), ["time", "Amplitude"])

target = hv.Curve(ds, 'time', ['Amplitude']).opts(
    width=800, height=400, shared_axes=False)

source = hv.Curve(ds, 'time', ['Amplitude']).opts(
    width=800, height=150, shared_axes=False, alpha=.5,
    yaxis=None, toolbar='disable', xlabel='')

RangeToolLink(source, target, axes=["x"], boundsx=(time[0], time[len(time)//20]))

(annotator * target + annotator * source).cols(1)

Stack traceback and/or browser JavaScript console output
Screenshots or screencasts of the bug in action
What it currently looks like:

What it should look like:

[ ] I may be interested in making a pull request to address this

Try swapping the multiplication so annotator is last.

yea, I had thought that was the previous solution, but it no longer seems to work

Nevermind! I got it working by applying these opts to the layout
layout = (annotator * target + annotator * source).cols(1)
layout.opts(opts.Layout(shared_axes=False, merge_tools=False))


Double "user joined" message when changing room with isolate rooms mode

On changing room the "user joined" message is caused to display twice. It only occurs in isolate rooms mode, so the problem is probably with PublicRoomManager. Reported by Corwin.
[19:31:03] <Bob> has joined the room: 'Foo'
[19:31:07] <Bob> has joined the room: 'Bar'
[19:31:08] <Bob> has joined the room: 'Bar'
[19:32:17] <Alice> has joined the room: 'bar'
[19:32:17] <Alice> has joined the room: 'bar'

To reproduce join a public server with no file open, then join a second room still with no file open.


CrosscurrentActivity for iOs

Hello,
What is the equivalent of crosscurrent activity plugin on iOs ?
Thank you,
cjacquel

Hello James;
Does Media.plugins needs Permission.Plugin on iOS ?
ThxChristophe Jacquelin,
Le jeudi 1 mars 2018 à 18:47:36 UTC+1, James Montemagno<EMAIL_ADDRESS>a écrit :

Closed #361.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

This is for library creators and doesn't' expose it cross-platform as iOS you can easily get to the app running window.


Deploy ci-trigger automatically with Cloud Build

Create a cloudbuild.yaml file to auto-deploy ci-trigger.
After merging, the Cloud Build trigger will need to be created/enabled in GCP.  This trigger will only run on the main branch when a change in tools/ci-trigger (or protos) occurs.

Pull Request Functional Test Report for #1866 / fe757971621c81af31ca9aff0f3a7c58f6087a58
No tests identified for validation.
Help


MGDCTRS-1625: Elasticsearch sink connector fails with wrong body type exception (tests)

@lburgazzoli can you return the Ignore to azure eventhubs? They are still failing eventually.

@lburgazzoli can you return the Ignore to azure eventhubs? They are still failing eventually.

done

@rinaldodev ok to merge ?


Mysterious crown logo misalignment

Problem:
The crown part of the logo was incorrectly aligned vertically:

A small hack was used to shift the crown up by 1 pixel:

This should be aligned correctly without any adjustment - see @36degrees comment for further information.

compare the height attribute on the SVG against the DS: 32 vs 30


Don't flatten and expand on each cell.call

http://stackoverflow.com/questions/41549784/can-tensorflow-rnncell-have-more-dimensions-than-3d

Use the following rnn wrapper:
def _rnn_wrapper(cell, inputs, timestep, batch_size, i):
  with tf.variable_scope(str(i) + "-clstm") as scope:
    state = cell.zero_state(batch_size)
    inputs = tf.unstack(inputs, axis=1)
    outputs = []
    for i in range(timestep):
        if i > 0:
          scope.reuse_variables()
        output, state = cell(inputs[i], state)
        outputs.append(output)
    outputs = tf.stack(outputs, axis=1)
  return outputs, state

Moving the operations into another function doesn't change the fact that reshaping happens. I'd like to avoid it entirely.

Check my repo at https://github.com/qinenergy/Conv-LSTM-Cell.
I've modified the lstm cell so it accepts 4D input.
Using the new cell along with the _rnn_wrapper should enable you to avoid the reshaping stuff.

Thanks for the link. It looks like you've implemented an alternative to tf.nn.dynamic_rnn instead. Your RNN API doesn't use initial_state, or handle variable sequence lengths (repeat cell state after sequence ended, up to end of minibatch), etc. You also seem to assume unrolling is wanted. Am I right?

Yeah, haven't done them yet. Currently I only use this for batchsize=1. My point is that we have to implement our own wrapper in order to avoid reshaping.

It would be preferable if TensorFlow's RNN API supported more dimensions instead. We should not have to reinvent the wheel.

agree with @carlthome... I really hate the fact that reshape is needed. Btw I don't think using vanilla for loop is efficient. dynamic_rnnuses scan operation if I correctly understood.

Possibly fixed on TensorFlow master: https://github.com/tensorflow/tensorflow/pull/5142#issuecomment-292239105

https://github.com/carlthome/tensorflow-convlstm-cell/commit/f92dbf41a79ef1cc5ca8b451b2769f54d6846f23

I didn't have time to check, but does it work with variable batch and sizes?

Variable batch size should be fine. Variable height and width will not work (zero pad images before instead). I think it should be fine to have variable sequence lengths but I'm not sure.


Empty connection pool not establishing connections

If you start an empty connection pool (minConnections: 0) and try to get a connection you receive a TimeoutException.

Thanks for this. Merged and published to pub in 0.3.2.


Update line 29, according to https://office.visualstudio.com/OC/_work…

Update line 29, according to https://office.visualstudio.com/OC/_workitems/edit/4554929

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@kaarins PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@kaarins  Is there progress on this, can we release document update?

Thank you! I made additional updates after discussing with PM and product marketing.


Add more supported deck image types

Sorry, but I haven't tested this, but it should (😅) work. :)
For .svg files the mime type is image/svg+xml so we need an extra check in there.

Ah, I'm sorry I've updated the file before noticing your PR.
Would you wish to resolve the conflicts, or can I push your changes myself?
I think it could look something like this:
--- a/src/utils/customdeck.ts
+++ b/src/utils/customdeck.ts
@@ -10,7 +10,7 @@ export class CustomDeck {
   deckCards: TFile[];
   flip: number[] = [0];

-  private supportedExtensions = ["jpg", "jpeg", "png"];
+  private supportedExtensions = ["jpg", "jpeg", "png", "webp", "bmp", "svg"];

   constructor(vault: Vault, folder: TFolder) {
     this.vault = vault;
@@ -72,9 +72,10 @@ export class CustomDeck {
     }

     const bytes = await this.vault.readBinary(file);
-    const value =
-      `data:image/${file.extension.replace("jpg", "jpeg")};base64,` +
-      arrayBufferToBase64(bytes);
+    const contentType =
+      "image/" +
+      file.extension.replace("jpg", "jpeg").replace("svg", "svg+xml");
+    const value = `data:${contentType};base64,` + arrayBufferToBase64(bytes);
     return {
       image: value,
       flip: randomFrom(this.flip),


(iOS) Could not find or use auto-linked framework 'UniformTypeIdentifiers'

OS target (iOS):
Godot version 3.2.3:
Issue description:
When building for debug I get the following errors:
ld: warning: Could not find or use auto-linked framework 'UniformTypeIdentifiers'
ld: warning: Could not find or use auto-linked framework 'FBLPromises'
Undefined symbols for architecture arm64:
"___darwin_check_fd_set_overflow", referenced from:
_connecthostport in initialExport.a(connecthostport.iphone.debug.arm64.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
I have retried many times from the beginning in both debug mode and release mode along with setting "Build Active Architecture Only". I have also tried compiling my own .a files and using precompiled files.
I am attempting to run on a real Iphone not a simulator.
Any help would be appreciated.

Sorry for delay, try to run these commands:
scons p=iphone tools=no target=release arch=arm
scons p=iphone tools=no target=release arch=arm64
lipo -create bin/libgodot.iphone.opt.arm.a bin/libgodot.iphone.opt.arm64.a -output bin/release/libgodot.iphone.release.fat.a
If you still are facing with problems, try to check out this new module: https://github.com/Poing-Studios/Godot-AdMob-Android-iOS
He already have compiled files, so you dont need to compile by yourself: https://github.com/Poing-Studios/Godot-AdMob-Android-iOS/releases/tag/iOS_v3.0%2B

hey @apdisant , probably you will need to add a Library Called "UniformTypeIdentifiers", try to do that

hey @apdisant , probably you will need to add a Library Called "UniformTypeIdentifiers", try to do that

I have determined that the issue was that I was using an old version of Xcode (11.3.1).
By updating to 12.3, the latest version at the time of writing this, I was able to build and run on real hardware with test ads.
Unfortunately neither of the fixes mentioned above were successful and the only real fix was to update.
For those of you using much older hardware like me it is possible to update to a newer version of Mac OS that can run the latest version of xcode by searching for "mac os patcher tool" and choosing the most recent version of Mac OS that your hardware supports. It is unfortunate that apple stops updating their old software versions when a new one comes out.
Thanks for the support gustavottc!

I have determined that the issue was that I was using an old version of Xcode (11.3.1).
By updating to 12.3, the latest version at the time of writing this, I was able to build and run on real hardware with test ads.
Unfortunately neither of the fixes mentioned above were successful and the only real fix was to update.
For those of you using much older hardware like me it is possible to update to a newer version of Mac OS that can run the latest version of xcode by searching for "mac os patcher tool" and choosing the most recent version of Mac OS that your hardware supports. It is unfortunate that apple stops updating their old software versions when a new one comes out.
Thanks for the support gustavottc!


[meta] update backport config for 7.12 branch

This commits update sqren/backport config to handle 7.12 branch.
Also remove 7.10 and 7.11 branchs.

jenkins test this please


Fix session state issues

Fixes part of #474: log out whenever api and keystore are not both logged in. This fixes the issue with sessionStorage attributes from the api module remaining after the idle logout enforced by the keystore.

Ah, right. That was intentional because the logout function in SessionContext clears both sessionStorage and localStorage, so if user1 triggers logout because user2 logged in, then the logout call from user1 will immediately log user2 out right after login. But you're right that it makes sense to also clear the api session when the keystore closes due to a different user logging in. Commit 95b8bed fixes this.

Heh, interesting, I had also started on a similar refactorization I hadn't pushed :slightly_smiling_face: but with a (mostly) different goal than you had in #488. I've pushed this too as PR #489, please have a look! Maybe there's some useful overlap between these PRs.


Compression stuck on iPhone XS Max iOS 17.0.3

On my iPhone XS Max with iOS 17.0.3 (inside of an Ionic mobile app), the compression using imageCompression() is stuck at 5% progress. I get no error, the compression just seems stuck.
This works perfectly fine on my MacBook Pro M2 Max.
Here are the options that I'm using:
const options = {
    maxSizeMB: 0.2,
    fileType: 'image/jpeg',
    onProgress: (progress: number) => {
    console.log('Progress:', progress)
    },
    useWebWorker: true,
    preserveExif: false,
    maxIteration: 30
}

Ok, I found out that the problem was caused by a plugin that I was using in my Ionic app which was modifying the native File() constructor of JavaScript...


Add a License

Our repository does not have a license added to it, which can cause confusion for potential users of the code. Without a license, users may not know how they can use or distribute the code.

fixed in #16


Update highlighting colors in Algolia

Description: $title

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


area rectangle ratio

Hi, I would like to set the default area to 270*70px, here is my settings:
<ui-cropper image="myImage" area-type="rectangle" aspect-ratio="3.85" result-image="myCroppedImage" result-image-size='{w: 270,h: 70}' area-init-size='{w: 270,h: 70}' init-max-area="true"></ui-cropper>
When I upload a png with that ratio (270x70), the canvas size is 385x100, is it possible to import my image in a crop area of max 270x70 ?
Thanks !

export dataUrl is not at max up to 270*70?

@CrackerakiUA what do you mean ?
Here is a screenshot of the result:

I would like my canvas to have an area init size of 270 x 70 as specified and not 385 x 100

So your project is that canvas it self has bigger size? If result image is correct. Or did i get you wrong?

Here is a use case, I warn my user to upload an img of 270 x 70, when he is uploading is image the peview (canvas) is 385 x 100 instead of 270 x 70. The result image is good (270 x 70) but it might be confusing to have a preview (canvas) with a different size and a pixelised image.
I would like to have a canvas of 270 x 70px, like that if the user upload a 270x70 image he will not be able to crop it (because of min-size...), however if the user upload a bigger image he will then be able to crop it to 270 x 70

Sounds crazy :)
keep your canvas as big as you can to work nicely, and have your result image as you wish.
Besides if you really want to have what you are asking, use your css.


Feature: export image using the Transfer API

Superseded by #8191
Ref #7592
Summary
Implement exporting image using the new Transfer API.
Implementation Details
Invoke the Transfer API with a dummy image.Store as source and archive.ImageExportStream as destination.
The reason why a dummy image.Store is chosen as source here is I learnt that the images to export are actually read on the containerd side, not ctr and we need to distinguish the export scenario from the others, so I choose to send a dummy image.Store to tell the local transfer service about that.
In addition, I have added some options to the archive.ImageExportStream to gain the same ability as "non-local" export. These options are hold in a config struct, does not follow the functional options pattern, b/c I think this would save me some typings. This might be opinionated, I could switch to functional options if that's necessary.
/cc @dmcgowan

Thanks @knight42! I'm still testing this locally and have a few changes in the process. I am planning on carrying those changes though after I finish testing to make sure we can get this in for 1.7. It'll keep your commit history though. I'll comment here when done, thanks!

Thanks @knight42! I'm still testing this locally and have a few changes in the process. I am planning on carrying those changes though after I finish testing to make sure we can get this in for 1.7. It'll keep your commit history though. I'll comment here when done, thanks!

Got it, sorry for the late response. I guess I cloud close this PR then, thank you.


Fix Github Action pending problem

Purpose of this pull request

This patch is trying to fix the pending problem of Github Action.
Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] Change does not need document change, or I will submit document change to https://github.com/apache/incubator-seatunnel-website later

Hi @CalvinKirs . Thanks for your comment. The jdk.version option is not necessary, however we can use this option to ensure the version of JDK to avoid affected by environment variables.

Hi @CalvinKirs . Thanks for your comment. The jdk.version option is not necessary, however we can use this option to ensure the version of JDK to avoid affected by environment variables.

@kezhenxu94 hi WDYT?

hi @asdf2014, we should remove the hard code jdk.version, because we already setup the JDK version in github action.
https://github.com/apache/incubator-seatunnel/blob/dev/.github/workflows/backend.yml
It will limit us when we want to use other JDK version to build the SeaTunnel project, we can set different JDK env by using github action.

Hi @leo65535 @zhongjiajie @CalvinKirs , thanks for your comments, which have been addressed, PTAL


Fixed Magic unexpected return issue

It was leaving an issue org.jruby.exceptions.RaiseException: (LocalJumpError) unexpected return
at RUBY.block in (root)(C:\Users\jesse\Desktop\apollo.\data\plugins\skill\magic\magic.rb:153)
at org.jruby.RubyProc.call(org/jruby/RubyProc.java:308)
at RUBY.handle(C:\Users\jesse\Desktop\apollo.\data\plugins\bootstrap.rb:88)
there was no reason for the returns?

Can you put the enchantment part inside an else clause - with this change we're going to check if the spell is an enchantment spell even if we know it's not (because if it's an alchemy spell then it's definitely not an enchantment spell).

Shouldn't it just be next?


Fix dropdown admin

On admin menu dropdown, after click on dropdown icon, the menu icon was hiding behind the menu and adjust the menu dropdown size.
Before:

After:

@matheuscla olha o que pode acontecer ainda:

A ideia da task não seria corrigir esse problema?

@igorrfc Nao tinha percebido esse bug, pra mim era so o botão que tava sendo escondido. Vlws

Coverage remained the same at 81.435% when pulling 5b28ce88b1db295add82aa36b24f02193e018994 on bug-menu into 122c0a09904d2bb983367255d2951ee50374b543 on master.

Coverage remained the same at 81.435% when pulling 6f597f979d478b0aec611c7dff8833066c349281 on bug-menu into 122c0a09904d2bb983367255d2951ee50374b543 on master.


fix: show correct details for pending ethereum transactions

fixed #2789
Also removes timestamp and block number from pending transactions
(getBlock will return a block even if blockHash is missing)

Fixed, LGTM


Add files via upload

Hi Andela, this looks interesting. Can you describe a little the problem you are looking to solve, and how you are solving it?

the world may never know


fill in filter bar when navigating back

In the /inspect page, if you select a component then navigate away (say the curate page) and then come back, the filter bar is not filled in but the data for component you were inspecting is still there/re-populated.
We should use the selected prop on the Typeahead component in the FilterBar to show the current value to the user.
note that this may be relevant for other pages as well.

I'm new to react, so will try to tackle this one.

Hey @jeffmcaffer just to make sure I understand the problem here. The Component search bar is currently cleared after you select from the suggestions. Are you implying the Search bar shouldn't be cleared after a selection? Seems like we should fix that first if so, and then make sure that the value stays there if you navigate away and come back.

This is on the Inspect page (recently renamed from Component. I updated the initial comment just now). there you are looking at one thing and the selection should" stay while you are looking at it. If you go away and come back, that selection was disappearing.  At least, that is what was happening when this issue was created.


fix open-commands path in kws

https://github.com/k2-fsa/icefall/blob/3b257dd5ae79bff99470ec1cbbeaa8fae84f956a/egs/wenetspeech/KWS/prepare.sh#L66
As shown in the figure below, the path of open-commands->scripts is incorrect, this MR just fix open-commands path in kws.

@yulianjie  Thanks! Merging.


Should we recalculate our DOY% variables using only the growth in b-a?

Because of our discussions around using a and b for our total growth, and further explanation of the modeled curves from Sean, i've been rethinking how we calculated our timing variables.
So our current DOY% variables use the modeled lg5 dbh to find 25, 50, and 75% growth. Should we recalculate using only the growth within the a and b variables? Ie, only consider actual growth, not the entire model?
To illustrate, here is a modeled growth curve with the % variables calculated using total modeled growth (blue lines) and % variables calculated using only the modeled change in dbh which falls between a and b (red lines):

The green line represents the final dbh in the previous year, illustrating the point that using our current DOY% variables is incorrect (though, this is an extreme case. When applying this, most change by <10 days). I've already started working on changing them over and a prelim run of the bayesian analysis hints that the results will be slightly different but the conclusion is the same (i'm glad we caught this before any journal accepted it....). This will also involve rerunning the climwin script with the new DOY25's.

@camerondow35 , I need to understand this better, and hopefully our talk today will clear it up for me, although we might need some input from Sean.
Are you using data from previous and following years to inform estimation of  a and b? Sean's paper states that this is possible, although I'd caution that the shrinkage that occurs overwinter is likely to confound this.
Here's an example image annotated with my current underestimating of the values that might be selected for a and b if we use (green lines-- paralleling your green line above, at least for a) or don't use (blue lines) data from previous and following years:

These could obviously give very different results. I intentionally picked an example with fairly dramatic overwinter shrinkage to illustrate the point, but we'd still expect this to matter.
Based on your comment above, it seems that you're using values illustrated by the green lines, or maybe the green line for a and blue line for b.  While I think it's valuable to try running it this way, I don't think I trust that, as it cuts off a large portion of the stem expansion phase. Note also that it would bias results of the first and last years, when data from previous and following years (respectively) were not available.
Based on my current understanding, I'd recommend that you:
(1) have the main analysis use a and b determined independently from one year to the next (i.e., blue lines in the example figure)
(2) mention what results would be if a and b were informed based on previous and following years (I believe this is the analysis you just tried).
(3) clarify that ∆DBH is NOT net annual growth, but gross annual growth. Retain this as the primary variable of interest.
(4) consider trying to calculate  ∆DBH_net based on corrections relative to previous or following year (one, not both). But note that (a) this would lose a year of data, (b) it could add some mess/ need for additional data screening,  and (c) ∆DBH is not hugely interesting in this analysis, as the tree-ring analysis is far more comprehensive.

update after our discussion yesterday:

a and b were not informed based on previous and following years
Thus, the new results correspond to recommendations (1) and (3) above. We will not pursue (2) and (4)

I think we can close this.