conditional compilation of embed-resource and tempfile to speed up the build?

I noticed that cargo install cargo-quickinstall now takes ~6s on my mac. The bulk of this is compiling the build dependency embed-resource, which pulls in toml_edit and serde.

[ ] This seems to have been added as part of https://github.com/cargo-bins/cargo-quickinstall/issues/254 to make 32bit windows happy. I manually commented this out and got rm target; cargo build --release down to ~3s. Can we make this conditional?
[ ] Might be worth adding a cargo-deny check in CI to make sure we're never including serde as a dep or build dep by accident

The bulk of the rest of the time is tempfile + libc. Annoyingly there isn't a way to unzip a zipfile without making a temporary file. We are not using the fancy libc "tempfile that goes away once you close it" - we're using https://docs.rs/tempfile/latest/tempfile/struct.NamedTempFile.html which can be trivially implemented using https://doc.rust-lang.org/nightly/std/env/fn.temp_dir.html and a drop impl (might still need fastrand if we want to include randomness in the path, but maybe we don't need to bother if we're not expecting parallel invocations?)

[ ] a) could we kill off tempfile by vendoring something similar to NamedTempFile?
[ ] b) could we get cargo-binstall to also provide .tar files for all architectures, or switch to using the cargo-binstall tarballs from the cargo-quickinstall repo, which are already .tar files?
[ ] c) could we conditionally skip tempfile on linux (doesn't help macos and windows though)?

Removing tempfile and embed-resource would bring the build down back down to ~2s.
... edit: it turns out guess_host_triple also pulls in libc, so I guess that's why we're not winning that much by killing off tempfile. This is https://github.com/cargo-bins/cargo-quickinstall/pull/136 . Killing this off too gets us down to 1.37s. Killing off the build.rs entirely gets us down to 1.17s, but I don't know if it's possible to conditionally enable a build.rs.
I reckon we should definitely do the embed-resource tweak, because it's a big win with no downsides. I don't know how far I would go with the other bits though.

For embed-resource introduced in #262 , I don't think we could do that without breaking cross compilation.
If we do
[target.'cfg(windows)'.build-dependencies]

Then it would break cross compilation for windows on linux.
I think maybe we can help embed-resource to be more lightweight, by disabling default features of toml?
https://docs.rs/crate/toml/0.8.19/features
I think they probably only need parse but the default also enables display.

I was thinking about killing it, by running embed-resource in CI and then commit the manifest into our github repository, however that doesn't seem possible.
https://docs.rs/embed-resource/latest/src/embed_resource/non_windows.rs.html
embed-resource actually compiles using cc-rs and link it.

I think embed-resource, we should open a ticket in upstream to make toml optional and provide the information manifest through the build-script?

Then it would break cross compilation for windows on linux.

We don't cross compile for windows though, do we? We use windows-latest for x86_64-pc-windows-msvc and aarch64-pc-windows-msvc so we should be fine?

Well but our user could do that, if they decide to do cargo install cargo-quickinstall for windows, on a linux machine.

I'm not completely sure what the use case is for this. I will have a go at making the cross compilation thing work anyway, and get back to you.

I'd imagine speeding up cargo-quickinstall is to mainly benefit users who are compuling cargo-quickinstall?

The original use case for cargo quickinstall was so that you can use rust-based tools in CI without having to compile them yourself or learn about how to use the github actions cache.
Github's ubuntu-latest runners come with a copy of rust already installed, so you could copy-paste:
cargo install cargo-quickinstall && cargo quickinstall ast-grep && ast-grep scan

and it will quickly run any ast-grep based linter rules you have. For linter rules like this, the run time is dominated by the installation step, and quick feedback on your PR is super-useful.
This is a bit of a contrived example (and most tools have snippets that you can copy-paste into github actions for quick installation anyway) but I still feel a bit of pride that you can be really lazy and not bother reading anyone's docs and still get quick CI runs using cargo-quickinstall exactly as you would use it locally.


[feature-request] Add travel time configuration to goodservice app

(Redo of #976)
Hello!
I love using this and the default NYC subway time apps, but one thing I feel is missing is the ability to only show trains that will be arriving after a certain delay. I personally live around 10 minutes away from the subway, and I think being able to account for travel time to the subway would be an amazing addition!
I'm also looking to make the same edit to the default NYC subway time app if possible, but I'm not sure where to find it. Would I be able to get a pointer to where it lives in code?
Also, I'm very open to changing the way travel times are configured if there are any suggestions there.
Please let me know if there are any edits that I can make!

@blahblahblah- Thoughts on this one?

This is awesome! Thanks @connernilsen, LGTM!


Depricate nuxt-session

We will be deprecating Nuxt Session. The main reasons for this are:

With the release of NuxtAuth we have improved the session system used in the background. We recommend switching to NuxtAuth. Through the new local provider, we also allow:

Your own backend
Static rendering
Better connections to OAuth and more!

There are more integrations to store data into the browser for local storage. Have a look at the composables from VueUse.

Steps for deprecation:

[ ] Updated ReadMe to inform of the deprecation (13.11.2023)
[ ] Deprecate the repository (11.12.2023)
[ ] Remove NuxtSession from the https://sidebase.io homepage (11.12.2023)
[ ] Remove NuxtSession from https://nuxt.com/modules (11.12.2023)

Steps for deprecation:

Can you put concrete dates behind each step? I'd recommend doing the readme change ASAP and the actual deprecation in ~4 weeks.
Please also remember to recommend alternatives (most prominently, the nuxt native session management)

Remove NuxtSession from the https://sidebase.io/ homepage
Remove NuxtSession from https://nuxt.com/modules

Let's not take down the documentation in case people still need it

Let's not take down the documentation in case people still need it

The documentation was never moved to the website. The website only links to the ReadMe of the repo, so no documentation would be lose, we would only remove the website link.

Please also remember to recommend alternatives (most prominently, the nuxt native session management)

May I ask where I can find more information on nuxt native session management? I checked their documentation pages and could not find anything to the term "session". when googling Nuxt 3 Sessions, I only get this module (maybe our SEO is too good 😆)

May I ask where I can find more information on nuxt native session management? I checked their documentation pages and could not find anything to the term "session". when googling Nuxt 3 Sessions, I only get this module (maybe our SEO is too good 😆)

At the moment AFAIK Nuxt 3 doesn't have it directly documented. It is integrated in h3, see here: https://github.com/unjs/h3#session


Bookmark Management Solution for iPad/iPhone

It is currently a nightmare attempting to move a significant number of bookmarks around.
I imported bookmarks to DDG yesterday and found that many of the bookmarks were in the wrong file tree. Normally, this is a quick fix: just drag and drop a bunch of bookmarks into the right folder or use a select all command. But this is not currently possible.
The way it is right now requires the user to click on each individual bookmark or folder… and manually… one… by… one…. switch the bookmark to the right location.
If the Apple API doesn’t allow for drag and drop or select all functions, then some workaround, app, or web app is needed to avoid switching to DDG being a being a big nuisance for prospective users.

Hello, please take a look at our desktop apps. You can use the "Sync" feature to connect them and use the desktop app's re-ordering capability.  Hope that helps.  Please re-open if you're still having trouble.  Thanks.


[Enhancement]: Restructure repo to have main.tf plan be global rather than in plans/localhost

Through @jedel1043's experimentation, we have identified that as long as we have the necessary Juju controller deployed to our target cloud, the localhost plan can be used to deploy a Charmed HPC cluster to it.
Having the plan stored in plans/localhost is a misnomer however as it leads folks to believe that this plan can only be used to deploy a Charmed HPC cluster on top of LXD when in reality the plan can be used to deploy to other clouds.
We should structure this repository to similar to the https://github.com/canonical/sunbeam-terraform repository, and store permutations and custom cloud configurations a variables and/or submodules.

Since plans/localhost doesn't exist anymore - misnomer dead :coffin: - I consider this issue resolved by PR #5. We can open subsequent issues and/or PRs for permutations that we need to share or include.


0.4.29

fix camera change update

Codecov Report

Merging #41 (1d6e37e) into main (b9b1b93) will decrease coverage by 0.03%.
The diff coverage is 16.66%.

:exclamation: Current head 1d6e37e differs from pull request most recent head 283df68. Consider uploading reports for the commit 283df68 to get more accurate results

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   41.68%   41.65%   -0.04%
==========================================
  Files         113      113
  Lines        9483     9490       +7
  Branches     1415     1416       +1
==========================================
  Hits         3953     3953
- Misses       5113     5119       +6
- Partials      417      418       +1

Impacted Files
Coverage Δ

...gine/script/render/WebGLGlobalPostProcessVolume.ts
7.57% <0.00%> (-0.90%)
:arrow_down:

src/engine/render/CameraContainer.ts
62.26% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update to openapi spec file

a small fix for the spec file for creating an api client.
also beautify the json file

updated for the new client


Only perform chart lint, remove install step (#1227)

For the chart install to work, the Kubernetes cluster needs to be able
to talk to an OpenStack cloud which cannot be done in the CI. Therefore,
only perform the lint test and disable install.
(cherry picked from commit 534bf325c1412c62e753a8ac2e93d166066376e3)

What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

@brtknr is the failure of CI related to this PR ?

/ok-to-test

@ramineni yes it is failing because the chart has changes but we are not bumping up the verison. Best to merge is like this for now.

If possible, can we avoid squashing this one on merge please? Thanks

If possible, can we avoid squashing this one on merge please? Thanks

@brtknr I doubt its possible, it automatically gets squashed on merge

/lgtm

shall we merge? The lint job will not pass for this one.

/cc @lingxiankong

/lgtm
/approve


Use of next() crashes Node 8+ (TypeError: parser.getAsyncId is not a function)

Any use of next crashes Node 8+ with:
_http_common.js:220
      emitDestroy(parser.getAsyncId());
                         ^

TypeError: parser.getAsyncId is not a function
    at freeParser (_http_common.js:220:26)
    at socketOnClose (_http_server.js:396:5)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at TCP._handle.close [as _onclose] (net.js:548:12)

Hi @jaredreich the entire Express test suite runs without issue in Node.js 8 and a simple app (that includes next() doesn't error, either. Can you provide all the following so we can work to reproduce your issue?

The exact version of Node.js 8 (8.0.0 or 8.1.0).
The exact version of Express you are using.
The full app that reproduces the issue.
The call to make to the app that causes the above error.

Thanks!

@dougwilson So sorry, it was a very strange side-effect that I accidentally introduced that happened to show itself through my use of next().
Thanks so kindly for your response and valuable time put into this project, it's extremely appreciated.
Take care!


4.9.5 GUI changed; Config incorrect

I updated to 4.9.5, and the GUI has Stone in all the filler spaces. The config for the GUI says stained_glass_pane. I can change it to black_stained_glass, but then the display name is too long. I think I saw issue #312 mention the length of the glass name.
A display-name option would help, maybe.
This is mostly cosmetic, though.
Thanks

https://github.com/Zrips/Jobs/commit/432cbbbd093833508e468e099d8b344aac348697#diff-2bbefed2dca880e596848b248efa0102


Internal server error 500

following this url https://iag.me/socialmedia/build-your-first-twitter-app-using-php-in-8-easy-steps/
when i am trying to run the app i am getting 500 error on the server although curl is working fine on my server when i test it..

@iamaamir
The first thing I would look at is to turn off safe error processing temporarily or to add some error checking. This will hopefully direct you to the line that is causing the issue. Also check to see what your CURLOPT_SSL_VERIFYPEER is set to. Try setting this to false.

@iamaamir
The first thing I would look at is to turn off safe error processing temporarily or to add some error checking. This will hopefully direct you to the line that is causing the issue. Also check to see what your CURLOPT_SSL_VERIFYPEER is set to. Try setting this to false.

thx i got it ..


Missing bars on some unique stats

When I use item info on uniques, some items are consistently missing bars for specific stat rolls. Examples in images.

Note that other cases of life regen have their bars.

Thanks for reporting and also including screenshots, very helpful. Yeah, there are a few edge cases I was prepared to tweak manually. I thought I fixed the first case already (it gets thrown off by the numerical value of the stat requirement), but I don't know what's wrong with the other two. The second one might be a rounding error since it's almost bottom roll.

For the second one, I have another copy with almost perfect roll and it's still missing the bar.

v1.29.4-hotfix2 fixes these issues.

A similar case, with the bar being full when it shouldn't.

Another case, missing bar in the last stat.

As always, much appreciated. Will be fixed in the next release, hopefully out later today.


add augur-status

Add Augur Status information to account summary

refactored BlockInfo to use a shared selector for block data and rewrote in typescript.
added Augur Status box to the Account Summary

This pull request fixes 1 alert when merging 7624f48c6af7f15f88d3c13a5f71f608ebbb50bc into 80ca48fffafb2587853ee538c38b40dea26e9d59 - view on LGTM.com
fixed alerts:

1 for Potentially inconsistent state update

Comment posted by LGTM.com


Document usage/examples

There's very little to go off of for a new user. For example, what's the best way to create a client?
I'm using some mechanism I cobbled together from other clients of etcd, but I'm not sure it's correct.
Another example, what's SetCluster and why would I use it? Why doesn't NewClient* use SetCluster?

Also: Is go-etcd goroutine safe? Afaik I saw in some issue it is not.

@xiang90, @yichengq - could we use this issue for the examples + documented best practices.


[1769] Add provider details page

Context
We need to kill the c# app ASAP
Changes proposed in this pull request
Add provider details view
Guidance to review
Example - /organisations/2CG/2019/details
#After

 Move provider enrichments to rails

I assume if this information isn't yet published we will need some sort of "To publish this contact […]" message?

The page is missing accredited body enrichments:
/organisations/1CS/2019/details
New

Old

The page is missing accredited body enrichments:
/organisations/1CS/2019/details
New

Old

It's missing something in the backend to grab the provider_code and provider name

select distinct(acp.provider_code), acp.*
from provider as p

join course as c on
c.provider_id = p.id

join provider as acp
c.accrediting_provider_code = acp.provider_code

(This probably means preview has a bug too)

@fofr @defong will raise a new ticket on trello for this bug

The page is missing accredited body enrichments:

Good catch. Let's ticket his up separately.

@dankmitchell Can we actually remove the sidebar stuff from this PR and do it with a separate ticket? Just because of the logic behind published/not published, etc. We're starting to ticket up the provider enrichment stuff now anyway.


Publish-NAVApp does not recognize a certificate

Please include the following with each issue:
1. Describe the bug
I try to upgrade BC20.0 to BC24.3.21517.W1 on customer server onprem version.
Customer license is without module 'Implemented code is not cloud-optimized'
Publish-NAVApp did not recognize a certifiacate for the 'Microsoft_Base Application.app' file. I was not able publish it.
When I use -SkipVerivication I upgraded the system!
But when I try to login to the system I got an error:
Sorry, we can???t sign you in. You're using a customized version of the following Microsoft applications, which doesn???t meet our Universal Code requirement:
_Exclude_APIV1_ by Microsoft
_Exclude_APIV2_ by Microsoft
_Exclude_Bank Deposits by Microsoft
_Exclude_ClientAddIns_ by Microsoft
_Exclude_Email Logging Using Graph API by Microsoft
_Exclude_PlanConfiguration_ by Microsoft
_Exclude_ReportLayouts by Microsoft
API Reports - Finance by Microsoft
Application by Microsoft
Audit File Export by Microsoft
Bank Account Reconciliation With AI by Microsoft
Base Application by Microsoft
Business Foundation by Microsoft
Company Hub by Microsoft
Contoso Coffee Demo Dataset by Microsoft
Data Archive by Microsoft
Data Search by Microsoft
E-Document Core by Microsoft
E-Documents Connector with External Endpoints by Microsoft
Email - Current User Connector by Microsoft
Email - Microsoft 365 Connector by Microsoft
Email - Outlook REST API by Microsoft
Email - SMTP API by Microsoft
Email - SMTP Connector by Microsoft
Enforced Digital Vouchers by Microsoft
Error Messages with Recommendations by Microsoft
Essential Business Headlines by Microsoft
EU 3-Party Trade Purchase by Microsoft
Intrastat Core by Microsoft
Late Payment Prediction by Microsoft
OnPrem Permissions by Microsoft
Payment Links to PayPal by Microsoft
Payment Practices by Microsoft
Permissions Mock by Microsoft
Recommended Apps by Microsoft
Review General Ledger Entries by Microsoft
SAF-T by Microsoft
Sales and Inventory Forecast by Microsoft
Send To Email Printer by Microsoft
Service Declaration by Microsoft
Shopify Connector by Microsoft
Simplified Bank Statement Import by Microsoft
Statistical Accounts by Microsoft
Sustainability by Microsoft
Sustainability Contoso Coffee Demo Dataset by Microsoft
System Application by Microsoft
Troubleshoot FA Ledger Entries by Microsoft
Universal Print Integration by Microsoft
VAT Group Management by Microsoft
You must either upgrade the apps to meet the requirement or license the non-Universal Code module that grants an exception to the requirement.
For more information, see https://aka.ms/bcUniversalCode.

2. To Reproduce
Steps to reproduce the behavior:

Use Publish-NAVApp to publish Microsoft_Base Application.app without -SkipVerivication option.

3. Expected behavior
Use Publish-NAVApp to publish Microsoft_Base Application.app with certificate.
4. Actual behavior
Publish-NAVApp did not recognize certificate on 'Microsoft_Base Application.app' file
5. Versions:

AL Language: N/A
Visual Studio Code: N/A
Business Central: BC24.3.21517.W1 onprem on customer server
List of Visual Studio Code extensions that you have installed: N/A
PSVersion                      5.1.17763.1971
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17763.1971
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Get-AuthenticodeSignature returns
D:\Nav\Install\BC24.3.21517.W1\applications\BaseApp\Source\Microsoft_Base Application.app
Signature Type: None
Status: UnknownError
Status Message: The form specified for the subject is not one supported or known by the specified trust provider
Final Checklist
Please remember to do the following:

[x] Search the issue repository to ensure you are reporting a new issue

[x] Reproduce the issue after disabling all extensions except the AL Language extension

[x] Simplify your code around the issue to better isolate the problem

Internal work item: AB#545237

We're currently investigating this issue.
@jmaciejewskitozepterit can you share the properties of this file: D:\Nav\Install\BC24.3.21517.W1\applications\BaseApp\Source\Microsoft_Base Application.app? Specifically the Digital Signatures tab.

@jmaciejewskitozepterit can you please make sure navsip.dll is registered on the machine where you do not see the signature?
regsvr32 \navsip.dll
Remember to reboot after registering.

an error occurred:

I installed the newest version MS C++ 2015-2022 14.40.3810,
Publish-NAVApp works fine.

12


Add a macro to simplify manual definition of codecs for ADT

There are 2 reasons why I'd like to do that:

the generic derivation mechanism isn't practical for now
quite often you want to explicitly describe your mapping

Here is a suggestion:
sealed trait Base
case class A(d: ZonedDateTime) extends Base
case class B(i: Int, s: String) extends Base

implicit val baseCodec: Codec[Base] = Codec.forADT[Base] {
  case _: A => "a"
  case _: B => "b"
  // exhaustive checks
}

// by referencing members we guard against re-ordering of the fields
// if you don't want that kind of guarantee, you can always use a product codec.
implicit val aCodec: Codec[A] = Codec.generate[A]{ a => a.d -> "d" :: Nil }
implicit val aCodec: Codec[B] = Codec.generate[B]{ b => b.i -> "age" :: b.s -> "name" :: Nil }

I'm closing this as the generic derivation got better with scala 2.12.1


add readme badges

Description
hello,
i want to add readme badges, image for the reference is attached, this image is just for the reference, to make it clear of what im talking about.
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

Thanks @UjjwalSharma01 but i guess we don't need it. As all the information is available in the repo itself :)


NI.ni-daqmx version 24.6.0

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:
2024-09-15 17:34:11.637 [REPO] Parsing link file at C:\ProgramData\Microsoft\Windows\Start Menu\Programs\StartUp\NI Error Reporting (64-bit).lnk

Installation failed with exit code -1978335226
2024-09-15 17:34:08.076 [CLI ] ShellExecute installer failed:<PHONE_NUMBER>
MSI (s) (C8:90) [17:15:50:598]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (C8:90) [17:15:50:598]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (C8:90) [17:15:50:598]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (C8:90) [17:15:50:598]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (C8:90) [17:15:50:598]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
MSI (s) (C8:F8) [17:15:51:551]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (C8:F8) [17:15:51:551]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (C8:F8) [17:15:51:551]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (C8:F8) [17:15:51:551]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (C8:F8) [17:15:51:551]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
MSI (s) (C8:B8) [17:15:57:926]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (C8:B8) [17:15:57:926]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (C8:B8) [17:15:57:926]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (C8:B8) [17:15:57:926]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (C8:B8) [17:15:57:926]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
MSI (s) (C8:C8) [17:15:58:754]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (C8:C8) [17:15:58:754]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (C8:C8) [17:15:58:754]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (C8:C8) [17:15:58:754]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (C8:C8) [17:15:58:754]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.

Automated error analysis suggests -1978335226 may mean Running ShellExecute failed
(Automated response - build 895.)

Verify:


Check funtionality of push in quarkus with Atmosphere 2.7

No extra work needs to be done if the feature doesn't work, but if it does then the documentation should be updated.

This should be taken under work again when we finally get Atmosphere updated to 2.7.


feat: Add Next.js & Express cookie helpers.

What kind of change does this PR introduce?
This adds cookie helpers for Express and Next.js to make auth & SSR easier. The proposed user experience:
Step 1:

Create a pages/api/auth.js api route file with the following:

import { supabase } from '../../utils/initSupabase'

export default function handler(req, res) {
  supabase.auth.api.setAuthCookie(req, res)
}

This will take care of setting/deleting the cookie.
Step 2:

Forward onAuthStateChange events to your auth API route:

useEffect(() => {
    const supabaseAuthSession = supabase.auth.session()
    setSession(supabaseAuthSession)
    setUser(supabaseAuthSession?.user ?? null)

    const { data: authListener } = supabase.auth.onAuthStateChange(
      async (event, supabaseAuthSession) => {
        console.log(`Supbase auth event: ${event}`)

        // This is what forwards the session to our auth API route which sets/deletes the cookie:
        await postData('/api/auth', {
          event,
          session: supabaseAuthSession,
        })

        setSession(supabaseAuthSession)
        setUser(supabaseAuthSession?.user ?? null)
      }
    )
    return () => {
      authListener.unsubscribe()
    }
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [])

Step 3:

Get user in getServerSideProps (SSR):

export async function getServerSideProps({ req }) {
  const { user } = await supabase.auth.api.getUserByCookie(req)

  if (!user) {
    // If no user, redirect to index.
    return { props: {}, redirect: { destination: '/', permanent: false } }
  }

  // If there is a user, return it.
  return { props: { user } }
}

Todos:
There are still a bunch of TODOS but at this point I'd love to get some feedback on the DX outlined above @kiwicopple @awalias @leerob @ykdojo

This one is awesome thanks @thorwebdev . Should we merge?
YK, perhaps we can add some docs on our site?

This one is awesome thanks @thorwebdev . Should we merge?
YK, perhaps we can add some docs on our site?

@kiwicopple sounds good. I'll think about how to add it to our doc

@kiwicopple sounds good. I'll think about how to add it to our doc

@ykdojo thanks for taking on the docs. Can I assign this PR to you so you can merge in conjunction with the docs?

@ykdojo thanks for taking on the docs. Can I assign this PR to you so you can merge in conjunction with the docs?

@thorwebdev sure!

@thorwebdev sure!

Should we merge in then document later? I'd love to use this in the server components repo: https://github.com/supabase/next-server-components/

Should we merge in then document later? I'd love to use this in the server components repo: https://github.com/supabase/next-server-components/

Yes merging and documenting later sounds good!

Yes merging and documenting later sounds good!

I wonder if there's any 'harm' or significant impact/difference if we make this an async/await fn. Something like:

If we don't make it an async/await this would run synchronously, so does it matter?
@thorwebdev  What are your thoughts on this?


deprecate old C-core API for creating server credentials

PR #12644 introduced new API for creating server credentials. this issue is to track deprecation of the old API as discussed in that PR (https://github.com/grpc/grpc/pull/12644#issuecomment-339404267). the two functions to deprecate:

grpc_ssl_server_credentials_create()
grpc_ssl_server_credentials_create_ex()

cc @justinburke @jboeuf @markdroth

fyi: https://github.com/grpc/grpc/pull/13188 is taking care of python

I think this still needs to be done.


deps: Upgrade to RN v0.68.7, from v0.68.5

Aimed at fixing #5729.
This small upgrade is nice and easy; the upgrade helper doesn't show any other changes we need to make:
https://react-native-community.github.io/upgrade-helper/?from=0.68.5&to=0.68.7
Release notes:
https://github.com/facebook/react-native/releases/tag/v0.68.7
Incidentally we also get facebook/react-native@c3ad8ec7e in this release, which makes the change we've been patching in with patch-package to fix an Xcode build failure, so we can remove our patch-package patch.
Tested on an iOS simulator (iPhone 14 Pro running iOS 16.4), and on the office Android device (Samsung Galaxy S9 running Android 9). We haven't managed to reproduce #5729 ourselves so I can't report an observation of how this upgrade affects that issue. But upstream discussion is promising, and from a quick look nothing seems to break.
Fixes: #5729

Thanks for taking care of this!


New version: Jackett.Jackett version 0.21.2458

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

As per always, there's no issue with Jackett.

Hi @ilike2burnthing,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 877.)

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-04-24 23:23:21.747 [FAIL] Installer failed security check. Url: https://github.com/Jackett/Jackett/releases/download/v0.21.2458/Jackett.Installer.Windows.exe Result: 0x80004005

(Automated response - build 877.)

@wingetbot run


Kitchen Sink: Build A Recipe Meal Planner

Build a meal planning app that suggests recipes and generates shopping lists that you'll add to the kitchen sink. Feel free to use any existing projects of yours or start one from scratch.
For more information about the Kitchen sink; check out:

https://sink.million.dev/
https://github.com/aidenybai/million/blob/main/packages/kitchen-sink/README.md

N.B: Upon PR review, your usage of Million.js is a plus

@tobySolutions I would like to work on this issue. Please assign this issue to me.

Hey @Roar022! Sure thing! Go ahead. I really hope you are able to manage all these issues 😁


Cach2 instead of lighthouse

Not to be annoying, but I think I just figured out the Lighthouse cache thing.
Should I post a PR and instructions for how to set it up here?

Not to be annoying, but I think I just figured out the Lighthouse cache thing.
Should I post a PR and instructions for how to set it up here?
Edit: Check this commit with the fix.
We get the proper ID from the "fullyQualifiedID" here: feeds.dev.azure.com/${your_organization_name_here}/_apis/packaging/feeds?api-version=5.0-preview, so: feeds.dev.azure.com/atomcommunity/_apis/packaging/feeds?api-version=5.0-preview (you need admin authorization to the Azure DevOps organization to view that).
The description should say "Default feed for ${organization}" i.e. "Default feed for atomcommunity". If the description says something else or "null", then it's the wrong feed.
Edit 2: Working run with Lighthouse set up properly. It's a cache miss since this is the first time it's being run, but there's no warnings. dev.azure.com/DeeDeeG/b/_build/results?buildId=65&view=logs&j=e2cf4b02-5697-54ad-cf7c-fc2a840d53af&t=cf8e3cfb-de27-5959-c474-2e21b7dd5cf4

Yes, Sure! Make a pull request to this repository so we can see how it works.

Will do later. I am logging off for the day.

will delete this comment in a bit. -

On topic again: I think if we cache the entire repository, it will overwrite the entire repository the next time around when the "cache" is restored. I suppose we could do a git reset --hard to make sure everything tracked by git is current... But if any package.json or package-lock.json in the whole repo changed... or any substantial piece of code... I feel like Atom truly does need to be rebuilt then, for CI purposes.
(Caching/restoring the entire project is also rather slow!)
Boostrapping only sets up the main node_modules, script/node_modules and apm/node_modules folders.
https://github.com/atom/atom/blob/110b05baf7cb1e50ad7d679173e6fc8f698cab0d/script/bootstrap#L37-L44

This does npm install from in script/ (script/bootstrap runs from its own dir, which is script/)
Does npm install from apm/ (uses the cwd option to "change working directory" into apm/)
Then uses apm to install the packages in the project root ([repo_root]/node_modules, including the bundled packages in [repo_root]/packages, such as atom-dark-ui.)

So I think we should only cache those three node_modules folders for the bootstrap.
Everything else is Atom code that might have changed, or stuff from the build process, including the out/ folder with the atom installer, etc... Which is a separate thing from bootstrapping.
It's true that the Cache@v2 step only allows one file or folder to be cached, but we can run the cache three times, one per node_modules folder.
[I had this comment sitting open as a draft for a while. I posted my attempt at using Cache@v2 here: #30.]

I will close this in favor of #30

By the way, caching on Linux will be much faster if we can get past Electron 5. The Electron 5 binary for v5 on Linux is massive (433 MB) and gets downloaded at least once or twice during npm install in the script/ directory and in the [repo_root] directory.


User guide

This look promising!
Are there plans to write a user guide? If so, any timeline in mind?

I don't know how to write the user guide, because only Anki uses this crate.

Here is the API of FSRS-rs crate:
https://github.com/open-spaced-repetition/fsrs-rs/blob/main/src/lib.rs
If you have any question about them, please feel free to ask here.

if you only need that algorithm, check https://github.com/open-spaced-repetition/rs-fsrs


Problem with destroying entities

I tried running this code:
import star.entity;

class Foo {
  int foo;
  this(int f) {
    this.foo = f;
  }
}
void main()
{
  auto eng = new Engine;
  auto ent = eng.entities.create();
  ent.add(new Foo(1));
  ent.destroy();
}

And got the following error:
$ dub
Target star-entity 1.0.6 is up to date. Use --force to rebuild.
Building star-test ~master configuration "application", build type debug.
Compiling using dmd...
Linking...
Running ./star-test
core.exception.AssertError@../../../.dub/packages/star-entity-1.0.6/source/star/entity/entity.d(1002): Assertion failure
----------------
./star-test() [0x808f83d]
./star-test(const(void function()) star.entity.entity.EntityManager.__invariant1+0xc4) [0x808e3d4]
./star-test(const(void function()) star.entity.entity.EntityManager.__invariant+0x11) [0x808ed01]
./star-test(void invariant._d_invariant(Object)+0x16) [0x8093416]
./star-test(pure nothrow @safe void star.entity.entity.EntityManager.destroy(star.entity.entity.ID)+0x166) [0x808e0a6]
./star-test(pure nothrow @safe void star.entity.entity.Entity.destroy()+0x4c) [0x808d47c]
./star-test(_Dmain+0x51) [0x8084849]
./star-test(_D2rt6dmain211_d_run_mainUiPPaPUAAaZiZ6runAllMFZ9__lambda1MFZv+0x12) [0x809339a]
./star-test(void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).tryExec(scope void delegate())+0x18) [0x8093310]
./star-test(void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).runAll()+0x27) [0x809335f]
./star-test(void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).tryExec(scope void delegate())+0x18) [0x8093310]
./star-test(_d_run_main+0x117) [0x80932a7]
./star-test(main+0x14) [0x808c3bc]
/lib/i386-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0xb74d3a83]
Error executing command run: Program exited with code 1

Building in release mode just makes the program crash, so it's not the invariant that's a problem. Destroying an entity apparently kills the program.
Also, note that the error only happens if a component has been added to an entity(but even if the entity being destroyed has no components).
Am I using Entity.destroy() wrong, or what?
EDIT: I should note that, when building in release mode, the program only crashes if you try to do  eng.entities.entities!(Foo).

UPDATE: Changing the line _componentMasks[index] = null; to
for (int i = 0; i < _componentMasks[index].length; i++)
  _componentMasks[index][i] = false;

Seems to have fixed this issue for me.

Should be solved in the latest version (1.0.8).


What is the status of the project?

I see that the last contribution was 2 years ago, what is the status of this project?

This project looks good but haven't been updated. Any alternation to this with Firebase for CMS ?

I guess you can find something here https://firebaseopensource.com/

Sorry for leaving you unattended. It is not up to my standards of community support. The project was asleep and I guess I was overwhelmed with other things. We're working on a little rewrite right now.


Autocommand errors for TextChanged/TextChangedI

Hi, thanks for your plugin. I recently started having this issue with LuaSnip and can't figure out why (I'm on the latest version).
Error detected while processing TextChangedI Autocommands for "*":
Error executing lua callback: .../.local/share/nvim/lazy/LuaSnip/lua/luasnip/util/log.lua:105: attempt to index local 'msg' (a nil value)
stack traceback:
        .../.local/share/nvim/lazy/LuaSnip/lua/luasnip/util/log.lua:105: in function 'warn'
        ...seng/.local/share/nvim/lazy/LuaSnip/lua/luasnip/init.lua:490: in function <...seng/.local/share/nvim/lazy/LuaSnip/lua/luasnip/init.lua:472>

I'm using it with nvim-cmp and it's configured like so:
      require('luasnip').setup({
        history = true,
        update_events = "TextChanged,TextChangedI",
      })

This is what my snippets file looks like:
local ls = require('luasnip')

local s = ls.s
local i = ls.insert_node
local f = ls.function_node
local rep = require("luasnip.extras").rep
local fmt = require("luasnip.extras.fmt").fmt

-- i(1) means insert at the first position
-- i(0) means insert at the last position
ls.add_snippets("all", {
  -- Insert current datetime
  s("now", f(function()
    return os.date("%m.%d.%Y %H:%M")
  end))
})

--- HTML
local html_snippets = {
  s("", fmt("{}", { i(1), i(2) }))
}
ls.add_snippets("html", html_snippets);
ls.add_snippets("typescriptreact", html_snippets);

--- Markdown
ls.add_snippets("markdown", {
  -- To do item
  s("o", fmt("- [ ] {}", { i(1) }))
})

--- Python
ls.add_snippets("python", {
  s("l", fmt("print(\"{}\");", { i(1) })),
  s("d", fmt("import ipdb; ipdb.set_trace()", {}))
})

--- C#
ls.add_snippets("cs", {
  -- Logging
  s("l", fmt("Debug.Log(\"{}\");", { i(1) })),
  s("lv", fmt("Debug.Log(\"{}: \" + {});", { i(1), i(2) })),

  -- Function/method definitions
  s("void", fmt([[
  {} {}({}) {{
      {}
  }}
  ]], { i(1, "void"), i(2, "Function"), i(3), i(4) })),
  s("pub", fmt([[
  public {} {}({}) {{
      {}
  }}
  ]], { i(1, "void"), i(2, "Function"), i(3), i(4) })),

  -- Loops
  s("foreach", fmt([[
  foreach (var {} in {}) {{
      {}
  }}
  ]], { i(1), i(2), i(3) })),

  -- Conditionals
  s("nc", fmt([[
  if ({} == null) return;
    ]], { i(1) })),

  s("if", fmt([[
    if ({}) {{
        {}
    }}
    ]], { i(1), i(2) })),

  s("elif", fmt([[
  else if ({}) {{
      {}
  }}
  ]], { i(1), i(2) })),

  s("else", fmt([[
else {{
    {}
}}
]], { i(1) }))
})

--- Rust
ls.add_snippets("rust", {
  s("l", fmt("println!(\"{}\");", { i(1) })),
  s("ld", fmt("println!(\"{{}}\", {});", { i(1) })),
  s("lv", fmt("println!(\"{} {{:?}}\", {});", { i(1), rep(1) })),

  s("readfile", fmt([[
  let {} = fs::read_to_string({})
      .unwrap_or_else(|_| panic!("Couldn't read file: {{:?}}", {}));
  ]], { i(1, "contents"), i(2, "&path"), rep(2) })),

  s("writefile", fmt([[
    fs::write({}, {})
      .unwrap_or_else(|_| panic!("Couldn't write file: {{:?}}", {}));
  ]], { i(2, "&path"), i(1, "data"), rep(2) })),

  s("tests", fmt([[
  #[cfg(test)]
  mod tests {{
      use super::*;

      {}
  }}
  ]], { i(0) })),

  s("test", fmt([[
  #[test]
  fn test_{}() {{
      {}
  }}
  ]], { i(1), i(0) }))
})

I don't know if this is related, but I also started having an issue where, after using a snippet, I'd start to get a persistent multiple-cursor like behavior in the area around the snippet. Lines would be duplicated and I'd have to restart nvim for insert behavior to return to normal.

Ahhh yup, I missed that, thank you!

I don't know if this is related, but I also started having an issue where, after using a snippet, I'd start to get a persistent multiple-cursor like behavior in the area around the snippet. Lines would be duplicated and I'd have to restart nvim for insert behavior to return to normal.

Could you record that the next time it happens? I'd expected that specifically issues like this should be fixed with the last few commits :((

(BTW, fixed in 3cfa0c7f11ba8c02c5637bf4821647b74235d6c3) :sweat_smile:

Wow, thank you so much for the quick fix! I will definitely catch the other bug the next time it occurs and reopen an issue for it.
Thanks again :)


Unknown save bug

(broken)save.zip
Using this save file causes an error. I didn't modify it manually, so I think it must be a bug.

This is downstream of #31 (the 'correct answer' was out of bounds of the list of answers), I will try and fix it bc we've had some other issues from that during debate sessions too


Profile picture urls are wrong after import [Low Priority]

Default profile picture doesn't show for users after importing, because when the field membership.people.photoUpdated is null, it gets set to the time of the import instead of staying as null.

Just a note that we do import the photo too if one is provided, so when fixing this be sure the date still gets set if there is indeed a photo imported.


Figure out jpa pagination for returning only a page of results not all.

implemented in spring boot demo.


CIV-10069 Refactor Judicial Decision options

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-10069
Change description
Update Judicial landing page to include " Free form order " and existing wording
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No


"may be converted to an ES6 module" is a lie

Bug Report
🕗 Version & Regression Information
tsc 4.4.3
vscode 1.60
webpack 5.57.1
💻 Code
file webpack.config.cjs:
/** @type {import("webpack").Configuration} */
const config = {};
module.exports = config;

🙁 Actual behavior
vscode shows the hint

File is a CommonJS module; it may be converted to an ES6 module. ts(80001)

which is a lie, since the file is a .cjs module, and webpack doesn't have support for loading config from an .mjs module.
I don't see any way to squelch that lie, other than disabling JS hints entirely, which is undesirable because the JS hints are otherwise quite helpful.

https://github.com/microsoft/TypeScript/blob/08361e3d3c1e5fe2e1d19267d72c8292345c695e/src/services/suggestionDiagnostics.ts#L10-L13
@DanielRosenwasser Should I raise a PR adding necessary checks in here?

@sidharthv96 looks like the right place to me 👍


Monitoring Memory and Disk Metrics

What would you like to be added:
Seeing as we specify an AMI for the worker nodes I think it would be great if the official eks ami supported exporting of memory and disk metrics. Instead of having to create a custom AMI and then following this guide below.
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/mon-scripts.html
Why is this needed:
If using Cloudwatch, these are super useful for alerts and monitoring. Perhaps this is an unreasonable request but I think it would be great.

This is definitely something we're interested in doing, but it most likely won't be a part of the AMI. This will likely be a daemonset installed on EKS clusters. Can you create an issue on https://github.com/aws/containers-roadmap?

Thanks @micahhausler


test: install Cilium before creating any pods in upgrade test

As Cilium is installed with with the clean state it can delete the
connectivity endpoints recently created before deploying Cilium causing
the test to fail.
Signed-off-by: André Martins<EMAIL_ADDRESS>

This change is

test-me-please

test-me-please

test-me-please


export url

the example usage references a non-existant export
this PR

exports the page URL
and uses it in the readme example usage

(as well as some minor cleanups)

fwiw having the github action in the first place inspired us to do much more documentation! I think it's nice to have around even if folks eventually inline it!


broken $path and $PATH  if nodenv exists

This change fixes a bug where no command can be found
(e.g. ls) due to the $path array being set to one element
with all the previous paths separated by spaces.
This makes zsh break $PATH, instead of colons there are
spaces, and nothing works.
The idea is to have the array be set laveraging the word splitting
that we usually are told to avoid by quoting.
Please be sure to check out our contributing guidelines before submitting your pull request.
Proposed Changes

Unquote the $path array so it's redefinition contains all elements it contained before.

Good catch! Thanks for your contribution.

That was fast!

It won't normally be that fast, but it was clearly bug, it was a simple fix, you documented it well, and I had prezto open already. :P


A Question about Transaction For Mongo&MySQL

I'm from an old note.--Here--https://groups.google.com/forum/?fromgroups=#!topic/vertx/duFVIcSR0zg[1-25]
This is a small idea. About transaction...
In future versions. Will we add some new methods? For simpler transaction usage.
And I didn't find a good way to use transactions in VertX.
Recently I've been using VertX and Mongo.VertX much more interesting than SpringBoot.It's just that there's a problem here in transactions.

Closing as duplicate of https://github.com/eclipse-vertx/vert.x/issues/2781


Don't make cursor moves when closing cmdwin with nosplitscroll

When set nosplitscroll, sometimes the cursor position of the current window is changed after closing cmdwin.
It shouldn't happen since no cursor moves on the current window happens when leaving command-line.
Steps to reproduce

Open vim with vim -u NONE --cmd "set nosplitscroll | call setline(1, range(1, &lines)) | normal L".
Type q:<C-w>q and check the cursor position.

Images

before

after

Oh sorry, information about my environment is missing.

OS: macOS Monterey
Terminal: wezterm 20220905-102802-7d4b8249
Vim: v9.0.461

Hmm scrolling happens when the cursor is at the end of a buffer.

@luukvbaal How can I reproduce it?

Wow that was a hard find @mityu @brammool. I noticed the issue in some dotfile on my system, but figuring out a repro command proved difficult. The issue somehow only happens when the cursor is on a matched character i.e. (){}[]. AFAIK matchparen is responsible for adding this highlighting so to reproduce it you need matchparen enabled. Seems very unrelated I know, but it seems to be what causes the scrolling...
vim +"set nospsc nowrap | call setline(1, range(100)) | call setline(100, '()') | norm GL"

Reproduced with Vim9.0.465.

Open Vim with vim -u NONE --cmd "set nosplitscroll | call setline(1, range(&lines)) | autocmd WinEnter <buffer> call line('w0')"
Type Gq:<C-w>q

It doesn't happen with Vim9.0.464, so it's must a new bug caused by this PR.  I'll looking into this later.

Yeah I had noticed the cursor changing seemingly unnecessarily while developing the option. Didn't investigate further yet as it seemed complicated. I think I found a fix now for the cursor issue that doesn't mess up the scrolling for autocmd case. I'll open the PR, thanks for pointing me in the right direction @mityu.


Drop slurmd-peer integration

Description
This pull request aims to drop the slurmd-peer integration from the slurmd operator. This peer integration was being used to propagate the configured partition name to all of the slurmd nodes within a specific namespace. However, this peer integration is not necessary because all the slurmd units can just pull the same configured partition name from the application-level config. By just using the application config, it reduces the total overall amount of events emitted/processed since Juju will not need to process slurmd-peer integration events.
How was the code tested?
I ran both the integration and unit tests locally on my Ubuntu 22.04 LTS workstation. They passed with no issue.
One thing to keep an eye out for however is when the integration tests run in the GitHub Actions CI pipeline. I noticed that slurmd was still complaining in /var/log/slurm/slurmd.log about not having access to cgroups even though in an earlier pull request I was able to fix it by updating the default LXD profile. If it's still a problem, I will see if there are any other configuration options I could apply to the default LXD profile.
Checklist

[x] I am the author of these changes, or I have the rights to submit them.
[x] I have added the relevant changes to the README and/or documentation.
[x] I have self reviewed my own code.
[ ] All requested changes and/or review comments have been resolved.

Let's wait to merge this since we are having a great discussion in the Matrix server: https://matrix.to/#/!ZbfygnnFzRUCtDyBYH:matrix.org/$2gZ8rsY9Jty0fcdbgqgC8pvUBkFr90wgeOa09h53gDo?via=matrix.org


Unexpected any with project references

Bug Report

🔎 Search Terms

project references composite fromEntries lib dom iterable function return type
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about project references

⏯ Playground Link
N/A
💻 Code
Full reduced test case: https://github.com/OliverJAsh/ts-project-references-any-bug
Contents inlined below.
shared/tsconfig.json:
{
    "compilerOptions": {
        "rootDir": "..",
        "outDir": "../target/",

        "composite": true,
        "lib": ["DOM", "DOM.Iterable", "ES2017", "ES2019.Object"]
    }
}

shared/url-helpers.ts:
export const toDictionary = (
    urlSearchParams: URLSearchParams,
  ) =>
    Object.fromEntries(urlSearchParams.entries());

app/tsconfig.json:
{
    "compilerOptions": {
        "rootDir": "..",
        "outDir": "../target/"
    },
    "references": [
        {
            "path": "../shared/tsconfig.json"
        }
    ]
}

app/test.ts:
import { toDictionary } from "../shared/url-helpers";
const test = toDictionary(new URLSearchParams());
test;

🙁 Actual behavior
The type of test in app/test.ts is any.

🙂 Expected behavior
The type of test in app/test.ts should be { [k: string]: string; }.
Notes
When I inspect the definition of toDictionary, I can see it has the correct inferred return type:

However, when I try to use toDictionary in another module, the return type appears as any:

Note there are 0 build errors when I run tsc --build --verbose app/tsconfig.json.

This is completely expected and explainable, but not great. Your shared project includes dom.iterable, which augments the URLSearchParams interface in a way that makes it use a resolve overload of Object.fromEntries(urlSearchParams.entries()) than it does in your app project, which lacks that augmentation. The editor, by default, uses the source files, not the built .d.ts files for referenced projects, which means it has to infer the return type of toDictionary. If you enable disableSourceOfProjectReferenceRedirect, and when you run tsc --build, it uses the declaration files instead, which include the return type annotation { [k: string]: string }, so that’s obviously what you get there.
I’m not sure what we could/should do differently here. I think the best workaround is to add an explicit return type annotation on toDictionary since it’s dependent on lib inclusion, and you’ve intentionally set different libs in your different projects.

Interesting, that makes sense.
I guess this highlights a difference in type checking between the editor and tsc --build. I wonder if there's a way to make the editor match the behaviour of tsc --build without resorting to disableSourceOfProjectReferenceRedirect. I understand the downside of disableSourceOfProjectReferenceRedirect is poor dev UX (you have to run tsc --build before you can use the editor). Perhaps TS could build dependencies from source on the fly, so the dev UX still feels seamless but it's always consistent with the behaviour of tsc --build?


Allowing callers of tentacle client to drive orchestration themselves

Background
In the ExecutionsV2 pipeline, all tentacle communications are done asynchronously via events.
Results
Before
The TentacleClient.ExecuteScript method does the entire communication stack, from starting, to getting status, to completing etc.
After
We now expose the required operations needed to interact with Tentacle.
Considerations
Script Ticket
Tentacle V1 creates the script ticket on the Tentacle itself, whereas Tentacle V2 onwards are given the script ticket. This concept was hidden in the TentacleClient.
But now that we are driving the orchestration in Octopus Server, we need to expose this to the caller.
Orchestration vs Execution
We had to split apart the execution away from orchestration. This is because our new methods on the client are purely execution. But we want to make sure we are executing in the same way we do during orchestration.
Cancelling/Completing During Start
One thing we had to maintain when splitting execution and orchestration is that we try to cancel/complete in orchestration if we started attempting to start during execution.
This is why the ScriptExecutionCancelledAfterPotentiallyStartingException was introduced.
We also need to respect this contract in the ExecutionsV2 pipeline.
Using Latest Command/Response
The code became far simpler when the orchestrators and executors respected the contract that parameters and return values were always using the latest version (in this case V3Alpha).
This prevented the need for many generic arguments between layers.
It also simplified mapping.
ClientOperationMetricsBuilder
This PR does not have a good solution for the metrics we are currently gathering.
ClientOperationMetricsBuilder gets all the metrics about an operation, and reports back on that. But the operation is now split up into separate calls. So we cannot do this.
We need to revisit this at some point.
Testing
We should write our own set of tests on the new methods of the TentacleClient if this draft is considered worth progressing.
How to review this PR
This PR moves logic around so that it can be exposed. It would be great if we could please see if they are still logically equivalent.
Quality :heavy_check_mark:
Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.

I think in general this is rather good.

Summary of discussion of PR:
What the PR achieves:

It separates orchestration and execution logic inside tentacle client.
It adds new methods to allow callers to manage orchestration, leaving client responsible for execution.

What the PR does not address:

It does not allow the determination of what features the tentacle supports, so does not allow us to detect when we are dealing with a V1 tentacle which does not support idempotent script execution, and generates a new script ticket on the tentacle.

Benefits of getting this PR merged:

It does separate orchestration and execution concerns in TentacleClient and moves us towards being able to fully orchestrate tentacle interactions (with the exclusion of handling V1 tentacle limitations).
It would allow us to stop using FudgedTentacleClient and reduce filesystem usage that that is involves.

Cost of getting this PR merged:

Still requires further review before we can consider merging (It's had some attention from Luke).
It does not move us towards our cycle goal, and could distract from that.

Risks management:

The PR would need to be re-worked if we want to roll it out via a feature toggle.
The changes in the PR should not change behaviour for existing usages of TentacleClient, and this behaviour is well covered by automated tests.
New methods (for external orchestration) are not covered by automated tests to the same level.
Even if we wanted to address all required changes to tentacle client as a contiguous piece of work (including the missing tentacle version management concerns), we would likely want to split it up into smaller PRs, and this PR would be a reasonable first step.

A few thoughts:

ITentacleClient is used by the classic execution pipeline and Dynamic Workers.  Would it make sense to create a different interface for the resilient pipeline so you can freely experiment with it in isolation?
The Modern Deployment Team will prepare a mini RFC re how to expose the new K8s feature in the Tentacle Client. I don't think this should affect this PR and it is more of FYI.


Add activationHook

As mentioned in the Atom documentation, activationHooks (or activationCommands) will improve startup performance by deferring the package activation. Since this package is grammar agnostic, the core:loaded-shell-environment hook is the only suitable one.

It seems the unit tests fail because of this change @idleberg 😕
I found some solutions online for when the activationHook refers to another package, but not when it is set to core:loaded-shell-environment. Some quick tries with atom.packages.triggerDeferredActivationHooks() doesn't seem to do the trick for me... Do you have more knowledge on the topic and can you fix the tests @idleberg?

It would be helpful if the version I installed using apm would complete the specs, but they all fail.
$ atom -v
Atom    : 1.44.0
Electron: 4.2.7
Chrome  : 69.0.3497.128
Node    : 10.11.0

$ apm -v
apm  2.4.3
npm  6.2.0
node 10.2.1 x64
atom 1.44.0
python 2.7.16
git 2.25.0

I used GitHub's code search to find occurences of triggerDeferredActivationHooks and came up with this:
atom.packages.triggerDeferredActivationHooks()
atom.packages.triggerActivationHook('core:loaded-shell-environment')

But since I cannot run the unmodified specs of v1.2.0, I don't know how to help with the tests.

Thanks for the research @idleberg, I missed the triggerActivationHook function 😅
Once I added those two lines and ran the tests locally and everything worked like a charm again! I created a PR with a fix for you (in your fork), if you merge that this PR's CI should succeed 👍


Parse inline styles

Description

Updated our fetch logic to call a new function: fetchInlineStyles
This looks for any element with a style attribute that includes the word 'anchor'
For the selector, it uses either the element's ID but if there is not an ID, then the class list
Then it formats the styles with the selector to resemble CSS from style tags so that we can pass it to the parsing function and use it the same way

Steps to test/reproduce

In the demo, there is now an example for anchor positioning with inline styles. When the polyfill is applied, it should also correctly anchor the floating and anchor elements with inline styles.

 Parse inline styles via style attributes


Breaking Issue - Accounts not being reported as Locked when they get locked.

I have been running this for a while and there appears to be an issue that just popped up on one of my internal engagements. I used ldap relaying to get a list of all user accounts, then used the enumeration feature of Talon to look for valid and non valid accounts to test against. Once I got a list of valid accounts that were not locked (I found it odd they had no disabled accounts), I started my password spray and this morning the client said they had over 500 accounts locked in a 10 minute period. They confirmed that they were doing a lockout of three failed attempts in 30 minutes, I ran my test with 2 in 35 minutes. During my test it appears that 536 of 571 accounts I was spraying were locked in the first 10 minutes. Something tells me that 536 of their users did not enter a password wrong in the first 10 minutes of my scan.
The concerning part is that through the testing, only three accounts were reported back to Talon as being locked. All others were reported as a failed login attempt.

After doing some additional research, we think their domain was acting weird, and we are waiting for more information to confirm. We are looking to see if their domain was seeing the enumeration part of it as a failed attempt for some reason. Will post back when I have more information.


Support graphql file upload

Hi there
This pr provides capability to upload file (#640) using graphql according to this spec: https://github.com/jaydenseric/graphql-multipart-request-spec.

@sav007 @digitalbuddha Could you help suggest me how can I fix 2 failed checking. I try to fix them but really no idea.

CI failed: The unit test runs successfully on my machine but failed on Travis CI
Deploy preview failed: Error: watch /opt/build/repo/docs/gatsby-config.js ENOSPC

Seems like integration tests failing on CI. The second don't bother as not that not really relevant, will ask some folks from Apollo to take a look.
Meantime I will take a closer look at your PR.

I can't find the file SingleUploadMutation.java, is it missing in PR?

@sav007 Thank you for your comment. I revised my code as your comment and rebased my pr. Please have a look.
I also fixed compile error in ApolloServerInterceptorTest so that I can run the unit test.

Could you pls comment this line in travis.yml:
# - .buildscript/integration_tests_composite.sh

So that the build will pass, as composite build requires to changes to api module published first to maven.

Commented the line in travis.yml

Any idea about when this feature will be released? Thanks in advice

The snapshot should be live, Ideally we'd wait a week or two to make sure it didn't break anything


Revert "Runtime: Remove retainCount entry points."

This reverts commit 51e0594e1cdadc6beec7cf4dfb01bd32bf9dbd58. The retainCount
entry points are used by Instruments.

@swift-ci Please test

@slavapestov Mind reviewing this for inclusion in 2.2?

@swift-ci Please test

Looks good.

:+1:


containerd can't use private repositity pause to create pod

When I install kubernetes 1.10 with containerd and I config the kubelet.service --pod-infra-container-image=registry/mdelder/pause:3.0.After the whole cluster running,I found that containerd pull the k8s.gcr.io/pause:3.1to create pods.How I config to use my private repositity pause image?Did I make the wrong configuration？

You shouldn't configure kubernetes flag --pod-infra-container-image. That flag is for dockershim. You should use sandbox_image in containerd config instead (see https://github.com/containerd/cri/blob/master/docs/config.md).
containerd doesn't support pulling pause image from private registry which requires authentication. Does your registry/mdelder registry require authentication?

@Random-Liu Yes, this is my configuration for containerd.
[plugins]
  [plugins.cgroups]
    no_prometheus = false
  [plugins.cri]
    stream_server_address = ""
    stream_server_port = "10010"
    enable_selinux = false
    sandbox_image = "{{ k8s_pause_image }}"
    stats_collect_period = 10
    systemd_cgroup = false
    [plugins.cri.containerd]
      snapshotter = "overlayfs"
      [plugins.cri.containerd.default_runtime]
        runtime_type = "io.containerd.runtime.v1.linux"

sandbox_imageis my private registry pause image which I use ctr cri loadto load to contaienrd,but when the pod running,I inspect it,it use k8s.gcr.io/pause:3.1image.
crictl inspectp 97f9718d71e1e| grep info -A 15
  "info": {
    "pid": 2953,
    "processStatus": "running",
    "netNamespaceClosed": false,
    "image": "k8s.gcr.io/pause:3.1",
    "snapshotKey": "97f9718d71e1ea814985d356619bb1834ad0cb9bd016d5dd6c316c0ce4cd0839",
    "snapshotter": "overlayfs",
    "runtime": {
      "runtimeType": "io.containerd.runtime.v1.linux",
      "runtimeEngine": "",
      "runtimeRoot": ""
    },
    "config": {
      "metadata": {
        "name": "k8s-master-<IP_ADDRESS>",
        "uid": "000737af6f45ed5f4e62c3865f41391a",

@hmtai Hm, Let me look into it.

I tried changing sandbox image to nginx, and it works for me.
$ cat /etc/containerd/config.toml
disabled_plugins = ["restart"]
[plugins.linux]
  shim_debug = true
[plugins.cri]
  sandbox_image = "nginx"
$ crictl inspectp e | grep info -A 15
  "info": {
    "pid": 0,
    "processStatus": "deleted",
    "netNamespaceClosed": false,
    "image": "docker.io/library/nginx:latest",
    "snapshotKey": "e50a2079080a0f168e38dc93fd530c70d95adc0b68b1e826665c2ebd58f7f74d",
    "snapshotter": "overlayfs",
    "runtime": {
      "runtimeType": "io.containerd.runtime.v1.linux",
      "runtimeEngine": "",
      "runtimeRoot": ""
    },
    "config": {
      "metadata": {
        "name": "nginx-sandbox",
        "uid": "hdishd83djaidwnduwk28bcsb",

Can you show me your complete containerd config on that node? (Without the template string).

Thanks a lot:)
root = "/var/lib/containerd"
state = "/run/containerd"
oom_score = 0

[grpc]
  address = "/run/containerd/containerd.sock"
  uid = 0
  gid = 0
  max_recv_message_size = 16777216
  max_send_message_size = 16777216

[debug]
  address = ""
  uid = 0
  gid = 0
  level = ""

[metrics]
  address = ""
  grpc_histogram = false

[cgroup]
  path = ""

[plugins]
  [plugins.cgroups]
    no_prometheus = false
  [plugins.cri]
    stream_server_address = ""
    stream_server_port = "10010"
    enable_selinux = false
    sandbox_image = "{{ pause_image }}"
    stats_collect_period = 10
    systemd_cgroup = false
    [plugins.cri.containerd]
      snapshotter = "overlayfs"
      [plugins.cri.containerd.default_runtime]
        runtime_type = "io.containerd.runtime.v1.linux"
        runtime_engine = ""
        runtime_root = ""
      [plugins.cri.containerd.untrusted_workload_runtime]
        runtime_type = ""
        runtime_engine = ""
        runtime_root = ""
    [plugins.cri.cni]
      bin_dir = "/opt/cni/bin"
      conf_dir = "/etc/cni/net.d"
    [plugins.cri.registry]
      [plugins.cri.registry.mirrors]
        [plugins.cri.registry.mirrors."docker.io"]
          endpoint = ["https://registry-1.docker.io"]
  [plugins.diff-service]
    default = ["walking"]
  [plugins.linux]
    shim = "containerd-shim"
    runtime = "runc"
    runtime_root = ""
    no_shim = false
    shim_debug = false
  [plugins.scheduler]
    pause_threshold = 0.02
    deletion_threshold = 0
    mutation_threshold = 100
    schedule_delay = "0s"
    startup_delay = "100ms"

Thanks a lot :).I follow your steps and hard code in the config.toml but containerd use the old image.
root = "/var/lib/containerd"
state = "/run/containerd"
oom_score = 0

[grpc]
  address = "/run/containerd/containerd.sock"
  uid = 0
  gid = 0
  max_recv_message_size = 16777216
  max_send_message_size = 16777216

[debug]
  address = ""
  uid = 0
  gid = 0
  level = ""

[metrics]
  address = ""
  grpc_histogram = false

[cgroup]
  path = ""

[plugins]
  [plugins.cgroups]
    no_prometheus = false
  [plugins.cri]
    stream_server_address = ""
    stream_server_port = "10010"
    enable_selinux = false
    sandbox_image = "registry.ng.bluemix.net/mdelder/pause:3.0"
    stats_collect_period = 10
    systemd_cgroup = false
    [plugins.cri.containerd]
      snapshotter = "overlayfs"
      [plugins.cri.containerd.default_runtime]
        runtime_type = "io.containerd.runtime.v1.linux"
        runtime_engine = ""
        runtime_root = ""
      [plugins.cri.containerd.untrusted_workload_runtime]
        runtime_type = ""
        runtime_engine = ""
        runtime_root = ""
    [plugins.cri.cni]
      bin_dir = "/opt/cni/bin"
      conf_dir = "/etc/cni/net.d"
    [plugins.cri.registry]
      [plugins.cri.registry.mirrors]
        [plugins.cri.registry.mirrors."docker.io"]
          endpoint = ["https://registry-1.docker.io"]
  [plugins.diff-service]
    default = ["walking"]
  [plugins.linux]
    shim = "containerd-shim"
    runtime = "runc"
    runtime_root = ""
    no_shim = false
    shim_debug = false
  [plugins.scheduler]
    pause_threshold = 0.02
    deletion_threshold = 0
    mutation_threshold = 100
    schedule_delay = "0s"
    startup_delay = "100ms"

crictl inspectp 52e7efc8fd7a8 | grep info -A 10
  "info": {
    "pid": 16512,
    "processStatus": "running",
    "netNamespaceClosed": false,
    "image": "k8s.gcr.io/pause:3.1",
    "snapshotKey": "52e7efc8fd7a813934b0aa7763dc1d79352f51a6c43c6c7a09f4caa320bb8239",
    "snapshotter": "overlayfs",
    "runtime": {
      "runtimeType": "io.containerd.runtime.v1.linux",
      "runtimeEngine": "",
      "runtimeRoot": ""

@Random-Liu Thanks for you help.I want to use /etc/containerd/config.toml to change default config,but it seems that the config.toml didn't work.Any other steps that I missed?

Can you check

Whether your config is our at /etc/containerd/config.toml
containers log. The loaded log should be logged. You can check whether
the config is correct there.
crictl info to check the config in the output.

On Tue, Jun 12, 2018 at 7:12 PM huimin<EMAIL_ADDRESS>wrote:

Thanks a lot :).I follow your steps and hard code in the config.toml but
containerd use the old image.
root = "/var/lib/containerd"
state = "/run/containerd"
oom_score = 0
[grpc]
address = "/run/containerd/containerd.
sock"
uid = 0
gid = 0
max_recv_message_size = 16777216
max_send_message_size = 16777216
[debug]
address = ""
uid = 0
gid = 0
level = ""
[metrics]
address = ""
grpc_histogram = false
[cgroup]
path = ""
[plugins]
[plugins.cgroups]
no_prometheus = false
[plugins.cri]
stream_server_address = ""
stream_server_port = "10010"
enable_selinux = false
sandbox_image = "registry.ng.bluemix.net/mdelder/pause:3.0"
stats_collect_period = 10
systemd_cgroup = false
[plugins.cri.containerd]
snapshotter = "overlayfs"
[plugins.cri.containerd.default_runtime]
runtime_type = "io.containerd.runtime.v1.linux"
runtime_engine = ""
runtime_root = ""
[plugins.cri.containerd.untrusted_workload_runtime]
runtime_type = ""
runtime_engine = ""
runtime_root = ""
[plugins.cri.cni]
bin_dir = "/opt/cni/bin"
conf_dir = "/etc/cni/net.d"
[plugins.cri.registry]
[plugins.cri.registry.mirrors]
[plugins.cri.registry.mirrors."docker.io"]
endpoint = ["https://registry-1.docker.io"]
[plugins.diff-service]
default = ["walking"]
[plugins.linux]
shim = "containerd-shim"
runtime = "runc"
runtime_root = ""
no_shim = false
shim_debug = false
[plugins.scheduler]
pause_threshold = 0.02
deletion_threshold = 0
mutation_threshold = 100
schedule_delay = "0s"
startup_delay = "100ms"
crictl inspectp 52e7efc8fd7a8 | grep info -A 10
"info": {
"pid": 16512,
"processStatus": "running",
"netNamespaceClosed": false,
"image": "k8s.gcr.io/pause:3.1",
"snapshotKey": "52e7efc8fd7a813934b0aa7763dc1d79352f51a6c43c6c7a09f4caa320bb8239",
"snapshotter": "overlayfs",
"runtime": {
"runtimeType": "io.containerd.runtime.v1.linux",
"runtimeEngine": "",
"runtimeRoot": ""
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containerd/cri/issues/813#issuecomment-396791169, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFjVu8r7obDWIN_vIaIXT2Z4Hiq6LQRlks5t8HUEgaJpZM4UirvA
.

Sorry, I mean containerd log.
On Tue, Jun 12, 2018 at 8:05 PM huimin<EMAIL_ADDRESS>wrote:

@Random-Liu https://github.com/Random-Liu Thanks for you help.I want to
use /etc/containerd/config.toml to change default config,but it seems that
the config.toml didn't work.Any other steps that I missed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containerd/cri/issues/813#issuecomment-396799174, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFjVu055CeTBJGtuQoTim2n2-ohi-B4oks5t8IGAgaJpZM4UirvA
.

@Random-Liu Thanks,it works well now.
root@kvm-016081:/etc/containerd# crictl inspectp 2f037b9a2bf1d71ed68b851200fe61e77a94a612e7ee3fcdc16512b77a208a92 | grep info -A 10
  "info": {
    "pid": 0,
    "processStatus": "deleted",
    "netNamespaceClosed": false,
    "image": "registry.ng.bluemix.net/mdelder/pause:3.0",
    "snapshotKey": "2f037b9a2bf1d71ed68b851200fe61e77a94a612e7ee3fcdc16512b77a208a92",
    "snapshotter": "overlayfs",
    "runtime": {
      "runtimeType": "io.containerd.runtime.v1.linux",
      "runtimeEngine": "",
      "runtimeRoot": ""

Hm? Why it works now?
On Tue, Jun 12, 2018 at 8:19 PM huimin<EMAIL_ADDRESS>wrote:

Closed #813 https://github.com/containerd/cri/issues/813.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containerd/cri/issues/813#event-1677735218, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFjVu7GSCuxpyS7EutVzxoI_GmvAPMHVks5t8ITQgaJpZM4UirvA
.

@Random-Liu that ole do we support live config updates question :-)


Enable add_param chaining

One of the nuisances of using a logging package to me is the tedious adding of parameters. This PR introduces a new object t_console that is used to enable the chaining of console.add_param like this:
...
console.add_param('p1', p1)
  .add_param('p2', p2)
  .add_param('p3', p3);
...

To enable the chaining, a new function is introduced for every overloading procedure of the add_param procedure. This will return an object of type t_console that in turn can be used to call add_param again, this time, as a member function/procedure.
This is not only more straightforward to use, it is also much faster, according to my benchmarks (around 800x faster than manually chaining console.add_param calls)

Hi Jakob,
sorry for my late response. I am a little bit busy these days. I really like your enhancement. Thank you that you have chosen the development branch as the merge target. I need some time to look deeper into your changes and do some testing, before I will merge it into main. Next week I am at the DOAG conference in Nuremberg. By any chance: Are you there also? If so, I would like to meet you in person then.
Best regards
Ottmar

Hey Ottmar,
don't worry about reply delays. You do it in your free time after all!
Unfortunately, I won't be at the DOAG this year. We will have to postpone the in-person meeting but I want to stress: "Aufgeschoben ist nicht aufgehoben" ;)
About testing: As I indicated in the desceiption, I did my own testing and found the objet approch to be much faster with multiple parameters. Are more robust test-suite for something as critical as logging might be a good next step. One could use utPL/SQL to enhance the existing test scripts and add more detail. I might take a first shot at it, if you agree on the general direction.
Kind regards
Jakob


Label image has more than two classs

Hi,
I was running the code and there was a warning WRANING: the label has more than 2 classes. Set normalize_label to False
After changing the normalization parameter to False I am facing this error.
_File "train.py", line 113, in
vis.compute_scores(suffix=it)
File "/home/mitali/unet-tensorflow-keras/utils.py", line 60, in compute_scores
meanIU_per_cls = np.mean(np.array(self.cls_iu), axis=0)
File "/home/mitali/tensorflow/lib/python3.5/site-packages/numpy/core/fromnumeric.py", line 2957, in mean
out=out, **kwargs)
File "/home/mitali/tensorflow/lib/python3.5/site-packages/numpy/core/_methods.py", line 82, in mean
ret = ret / rcount
TypeError: unsupported operand type(s) for /: 'list' and 'int'
I think this has to do something with the mask image. can you help fix me this? Attached label image

Can I have a look of your files and folds tree? I am stuck here too.


Check JAVA_HOME environment variable when detecting installed JVM

When detecting JVM check JAVA_HOME variable value, if set identify JVM version and use it if valid.

I think that a user hit this issue during a Usability study.
it took him 20 minutes to find a way to have it working and i'm pretty sure that he would have abandoned if it wasn't in a usability study.
@dgolovin I notice that you set "in progress" 2 weeks ago, so it should be soon fixed?

@apupier It has not happen for this release, because we had to update java detection for version 9+ first.
If you have any info about that usability study, could you forward it to me by email?
Thanks!


Additional slotStartTime/slotRange properties

Issue Number
#466
Overview

[x] Added: f timeRange ⊆ timeRange (where f = fmap slotStartTime . slotRange)
[x] Added: f^n == f  (where f = fmap slotStartTime . slotRange)
[x] Added: slots in slotRange [t1, t3] are also in one or more of slotRange [t1, t2] or slotRange [t2, t3] if t1 < t2 < t3

Skipping for now: Remaining (looking for some thoughts on direction first):

[ ] Some general polish
[ ] We never hit the interesting cases where slots exist in both subranges. That would require perfectly generating an UTCTime on the boundary. This is kind of essential. We could bias generators to hit slot boundaries, but that would require some re-work.

Comments

Thanks @jonathanknowles!

However, given that we don't have this requirement just yet, should we define properties to that end?

Regardless, being able to paginate with closed bounds is something I'd expect to hold from the outside, but something I wasn't completely confident from knowing how it was implemented.
I'm not sure what the plan is but I fear people will use this for pagination.
Still, I don't want to well on it, it was tricky to implement well, and we'll hopefully have more clarity soon, so I removed it.

Thanks @jonathanknowles!
You're welcome.

Regardless, being able to paginate with closed bounds is something I'd expect to hold from the outside, but something I wasn't completely confident from knowing how it was implemented.
I'm not sure what the plan is but I fear people will use this for pagination.

If people start to use the feature for this, then we are still on safe ground, as the filtering feature is fairly well-defined. I think we can be confident that it works, as we've tested it fairly thoroughly.

Still, I don't want to well on it, it was tricky to implement well, and we'll hopefully have more clarity soon, so I removed it.

Fair enough! I think we will be in a better position to have a more in-depth discussion about paging further down the road. If our users start to demand it, then this will also help to clarify our requirements.


 Can you confirm that it still won't go to the next challenge?
Might be related to #6833

Google chrome @AkiraLaine

@amruthpolavarapu Will it still not go to the next challenge?

Nope. I am manually going to map and going to other challenges

Is this happening for all challenges? What is the name of the challenge you labeled as #109?

Learn how Script Tags and Document Ready Work in jquery

Are there are error messages showing up in the browser's console?

Just a sec. I will tell you

Refused to load the script 'http://<IP_ADDRESS>:15871/cgi-bin/blockpage.cgi?ws-session=1824636845' because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'unsafe-inline' .google-analytics.com .gstatic.com https://.cloudflare.com .cloudflare.com https://.gitter.im https://.cdnjs.com .cdnjs.com https://.jsdelivr.com *.jsdelivr.com .twimg.com https://.twimg.com vimeo.com 'self'".
http://www.freecodecamp.com/completed-challenge/ Failed to load resource: the server responded with a status of 502 (Connection reset by peer)

Is that all?

Ya. This is the error shown in console application

@QuincyLarson @BerkeleyTrue - Could you guys look into this?

Could you give this a try and report back?
https://github.com/FreeCodeCamp/FreeCodeCamp/wiki/Using-browsec-for-securing-your-connection-to-fcc

kk..

I am on my company's network. I am not able to install the plugin. I will let you know later.

You should test submitting and loading the next challenge without the plugin first when you get home. If it's the case that it is your work network causing the problems you won't need the plugin when using FCC at home.

kk... Thanks for helping..

@amruthpolavarapu Did Browsec work for you?

It worked on my home computer without browsec but I am not supposed to install browsec on my company computer. But I believe it will work.

Ok, since it seems that your work connection is the problem, I will close this.

This issue is still persisting for me. I am using Chrome.Even though I have completed my challenge, I am not getting the challenge # 110. Attached is the error from console.

@tusharacc Did you try https://github.com/FreeCodeCamp/FreeCodeCamp/wiki/Using-browsec-for-securing-your-connection-to-fcc ?
Indian ISPs have significant issues with monitoring and modifying web traffic, which is probably why you're seeing the CSP violations - the responses are not coming from valid sites.


some tampered zip / jar files (which java can still read) are not registered as jar files in helios

instead its taken as binary file and hex is shown

i cant share the jar file though

actually i only had an old version


Reduce Packet Delay Settings

Hello, what are the optimal settings for the options in the image below?
I've been using them as default so far, but was wondering if there is an option for further improving latency mitigation.

Also, my logging window shows as below, Does this show that the program is running ok and effectively?

If you see pairs of ActionRequest and ActionEffect (ignoring ActionEffect with single digit actionId), then it means that the program works. You can see the reduced latency by checking out wait=600ms->561ms, and by comparing it with latency=42ms in the same line, the latency decrement is working fine.
Keep those options turned on, and you're good. Uncheck Use Delay Detection and Use Latency Correction if your VPN software does strange stuff, like reporting that the ping is 0ms. Also, uncheck those, if your ping is pretty high (200+?) to begin with.


Avoid unnecessarily creating numpy array of Var objects

The array is unused in the code path for any currently supported version of Gurobi (>= v9.5) so can be removed to avoid unnecessary overhead. Additionally, in Python 3.12, creating this array triggers a memory leak due to a bug in gurobipy, so it would be good to remove it from cvxpy to reduce user impact.
Figured I'd start with a minimal change, but I'm happy to do a larger rewrite to remove the old workarounds in gurobi_qpif.py.
Description
Please include a short summary of the change.
Issue link (if applicable):
Type of change

[ ] New feature (backwards compatible)
[ ] New feature (breaking API changes)
[x] Bug fix
[ ] Other (Documentation, CI, ...)

Contribution checklist

[ ] Add our license to new files.
[x] Check that your code adheres to our coding style.
[ ] Write unittests.
[x] Run the unittests and check that they’re passing (pytest cvxpy/tests/test_qp_solvers.py passes with gurobipy v11.0.3)
[ ] Run the benchmarks to make sure your change doesn’t introduce a regression.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

If it's not needed for anything we support, any reason to not just delete the code?

I should clarify: by "supported" I mean versions that Gurobi still officially supports. As of now that's gurobi 9.5 and later. I'm not sure what cvxpy still intends to support in terms of Gurobi versions.

I'm not sure what cvxpy still intends to support in terms of Gurobi versions.

We only support what Gurobi supports is our policy as of today.

@simonbowly To move forward with this PR, I propose that we delete the old code since cvxpy only supports the same versions as Gurobi. What do you think?

To move forward with this PR, I propose that we delete the old code since cvxpy only supports the same versions as Gurobi. What do you think?

Works for me! This is now done with deafe23. The tests pass against gurobipy 9.5.2, 10.0.3, and 11.0.3.
Note that I also removed the update() calls. They're no longer needed in between adding variables and constraints in recent versions of Gurobi.

Thank you! I set the CI to run, should be good to merge once it passes!


updated travis scripts for new container environments

fixes #16

Also added coveralls integration, which we seemed to be missing before.

I think this is merge-ready.  Anyone else want to sign off?

I'll buy that for a dollar.  :fire_engine:

Merged. Please rebase the other outstanding PRs to get the coverage reports.


Memory leak

After adding this recently to an app, it started leaking memory. I've written a small JS snippet that reproduces the issue:
var LRUCache = require('lru-fast').LRUCache;
var cache = new LRUCache(5000);

setInterval(function () {
  cache.put(Date.now(), {
    text: new Array('1024').join(new Date().toISOString())
  });
}, 1);

setInterval(function () {
  console.log(new Date().toISOString(), process.memoryUsage());
}, 10000);

The memory will keep growing until the process is killed by the OS. Perhaps a reference to the deleted items, but I couldn't see anything obvious in the code.

 Remember, JavaScript is garbage-collected and memory usually grows and shrinks in a non-deterministic way.
Also, if there's a memory leak, you should be able to repro w/o timers.
Question: Do you run this test in a terminal with nodejs or in a web browser? The reason I ask is the fact that whatever you send to the console in Chrome will remain in memory until you clear Chrome's developer console, which might be what you're seeing in terms of memory growth.
Here's what I suggest:

Make the test simpler by removing timers (i.e. don't use setInterval)
At some interval (maybe for every 10000 put calls), call gc() to force a collection
Run the test in nodejs (v7) with the flag --expose_gc (e.g. node --expose_gc test.js)

This way you minimize side effects and it should also run faster (w/o timers.) If memory does grow uncontrollably, try disabling the put call and instead just write the value to a global variable (must be global or somehow outlive the code that's running.) If memory is no longer growing uncontrollably, there's a bug in LRUCache and we can start investigating. Also, if this is the case, I'd ask you to provide the test you used, what exact version nodejs and OS used.
Thanks for looking into this

I was curios, so I did it myself and there's no memory leak in LRUCache at master, so I'm closing this issue.
mem-test.js
const LRUCache = require('./lru').LRUCache
const Limit = 5000
const Iterations = 100

let cache = new LRUCache(Limit);

while (true) {
  for (let i = Iterations; --i;) {
    for (let x = Limit; --x;) {
      cache.put(Date.now(), {
        text: new Array('1024').join(new Date().toISOString())
      });
    }
  }
  gc();
  console.log(new Date().toISOString(), process.memoryUsage());
};

Output:
$ node --expose_gc mem-test.js
2016-11-14T03:09:21.037Z { rss: 49008640, heapTotal: 41938944, heapUsed: 4858008 }
2016-11-14T03:09:23.002Z { rss: 57040896, heapTotal: 42987520, heapUsed: 5249528 }
2016-11-14T03:09:24.918Z { rss: 61026304, heapTotal: 45084672, heapUsed: 5255184 }
2016-11-14T03:09:26.835Z { rss: 60792832, heapTotal: 45084672, heapUsed: 5179536 }
2016-11-14T03:09:28.738Z { rss: 60862464, heapTotal: 45084672, heapUsed: 5176320 }
2016-11-14T03:09:30.632Z { rss: 60878848, heapTotal: 45084672, heapUsed: 5176392 }
2016-11-14T03:09:32.507Z { rss: 58937344, heapTotal: 45084672, heapUsed: 5176584 }
2016-11-14T03:09:34.393Z { rss: 60653568, heapTotal: 45084672, heapUsed: 5176232 }
2016-11-14T03:09:36.316Z { rss: 58228736, heapTotal: 41938944, heapUsed: 5177136 }
2016-11-14T03:09:38.246Z { rss: 58458112, heapTotal: 41938944, heapUsed: 5173160 }
2016-11-14T03:09:40.222Z { rss: 56172544, heapTotal: 41938944, heapUsed: 5173320 }
2016-11-14T03:09:42.160Z { rss: 58191872, heapTotal: 41938944, heapUsed: 5174976 }
2016-11-14T03:09:44.132Z { rss: 57233408, heapTotal: 41938944, heapUsed: 5173640 }
2016-11-14T03:09:46.101Z { rss: 57614336, heapTotal: 41938944, heapUsed: 5173760 }
2016-11-14T03:09:48.074Z { rss: 61583360, heapTotal: 46133248, heapUsed: 5177192 }
2016-11-14T03:09:50.033Z { rss: 61485056, heapTotal: 46133248, heapUsed: 5177352 }
2016-11-14T03:09:51.967Z { rss: 61132800, heapTotal: 45084672, heapUsed: 5177352 }
2016-11-14T03:09:53.886Z { rss: 59764736, heapTotal: 45084672, heapUsed: 5177632 }
^C
$ node --version
v6.4.0
$ uname -a
Darwin Rasmuss-MBP-2.lan 15.6.0 Darwin Kernel Version 15.6.0: Thu Sep  1 15:01:16 PDT 2016; root:xnu-3248.60.11~2/RELEASE_X86_64 x86_64 (maOS 10.11.6 15G1108)
$

Apologies for the convoluted test snippet. I can confirm the issue does not exist in master, but it does with the version published to npm, I guess https://github.com/rsms/js-lru/commit/99bb1f40ddcd645eb574b0bdc085336922f5403c was never published?
Would you mind pushing a newer version with the fix? Sorry again for the trouble!

I strongly recommend not using NPM for this. It's so tiny that you're likely to end up paying more in maintenance than what it's worth. For instance, right now when you depend on a copy published to some 3rd party website. I'd just copy the lru.js file (and the d.ts file if you're writing TypeScript) into your project, or use submodules or subtree.

Thanks for the recommendation, but as soon as I install the module I don't depend on any 3rd party anymore. It really depends on how the application is built and distributed. If you don't publish, we'll copy it, but npm is preferable.

Thanks for publishing it ;)


Add mediation policies

This PR adds a few more mediation policies to the builtin policies.

Remove header
Set header
Add query param
Remove query param
Log message
Sample logs from the above policy:

Default behaviour

time = 2022-10-28T15:35:16.578+05:30 level = INFO module = choreo/mediation.log_message message = "" mediation-flow = "REQUEST" request-id = "12345" http-method = "GET" resource-path = "/menu/1"

- With header logging enabled

time = 2022-10-28T15:35:16.578+05:30 level = INFO module = choreo/mediation.log_message message = "" mediation-flow = "REQUEST" request-id = "12345" http-method = "GET" resource-path = "/menu/1" headers = {"Accept":"*/*","Host":"localhost:9090","User-Agent":"curl/7.84.0","x-request-id":"12345"}

- With payload logging enabled

time = 2022-10-28T15:35:16.706+05:30 level = INFO module = choreo/mediation.log_message message = "" mediation-flow = "RESPONSE" request-id = "<request-id-unavailable>" http-method = "GET" resource-path = "/menu/1" payload = "{\"resource\":\"GET /*\"}"

In addition to the above, this also improves the Rewrite Resource Path policy to handle path params and query params.

Disabled the release for query param related policies and the rewrite resource path policy. Will enable these once we migrate to the new mediation context.


Hide shop button

Hide the shop button above the DM list for the hide nitro upsetting theme.

Small PR, but I can't let Discord try and sell me nitro


Network initialization

Hi, @rishizek. Thanks for sharing your code. I am a bit of confusing about the weight initialization of Deeplabv3.
As described in the original paper, the backbone of deeplabv3 is ResNet, which is pre-trained with ImageNet. How about the ASPP module? It is not applicable to ImageNet right? How do you initialize ASPP module?

Hi, @qilinli ,
You are right. Because ASPP doesn't exit in ResNet, its weights are initialized default initializer of each layer.
For example, the weights of layers_lib.conv2d is, I believe, initialized by xavier_initializer(), etc.

@rishizek I see. It seems that nowadays no one explains random initialisation anymore :).
BTW, I am also curious about the use of Batch Normalisation (BN) layer.

It claimed that BN is trained with OS=16 on COCO and trainaug set of voc, then frozen BN and fine-tuning  on trainval set with OS=8. So what parameters are frozen? mean, variance? alpha, beta? or all of them?
In the stage of inference, the size of input could be different from the one in training, how could BN work, x - mean should not match right?
Even with OS=16, I couldn't train crop_size=[513,513] with batch_size=16 using GTX1080Ti. The author  is using somewhat enterprise -level GPU right?

Hi @qilinli , let me answer your questions as far as I know,

Good question! I thought we only need to freeze beta and gamma and implemented like so. But reconsidering it after your question and googling that, it seems better to fix moving mean and variance as well.
Right, during inference the size of input could be different. However, here, BN is applied on ConvNets. So unlike the case of fully connected layers, its mean and variance are computed over each feature map, namely, mean or variance of batch x height x width by each feature. Thus, the size of input image is irrelevant for this model.
The paper says they use K80, which has larger memory than GTX 1080Ti. So with K80, one can train the model with batch_size=16. Also, for another potential reason, they implement model better :)

Hi @qilinli ,
No problem. Thank you for shareing your thoughts. Let me comment about Q1:

You are right. BN can be learned even with batchSize=1. However, I am thinking that the reason they freeze BN with OS = 8 is not for theoretical reason, but they simply cannot fit them in GPU memory with OS = 8.  With OS = 8 the model requires even more GPU memory than OS = 16.  Also, apparently they freeze BN to save GPU memory as you can look at their code.

Yes, I'm aware with that even though I don't have sufficient time to investigate their code in detail yet ;)


Chromedriver LATEST_RELEASE_116 Issue

Summary
Dockerfile
FROM maven:3.8.6-jdk-11
ARG CHROME_VERSION="google-chrome-stable"
RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add -
&& echo "deb http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google-chrome.list
&& apt-get update -qqy
&& apt-get -qqy install
${CHROME_VERSION:-google-chrome-stable}
&& rm /etc/apt/sources.list.d/google-chrome.list
&& rm -rf /var/lib/apt/lists/* /var/cache/apt/*
&& sed -i 's/"$HERE/chrome"/"$HERE/chrome" --no-sandbox/g' /opt/google/chrome/google-chrome
#ChromeDriver
ARG CHROME_DRIVER_VERSION
RUN if [ -z "$CHROME_DRIVER_VERSION" ];
then CHROME_MAJOR_VERSION=114
&& CHROME_DRIVER_VERSION=$(wget --no-verbose -O - "https://chromedriver.storage.googleapis.com/LATEST_RELEASE_${CHROME_MAJOR_VERSION}");
fi
&& echo "Using chromedriver version: "$CHROME_DRIVER_VERSION
&& wget --no-verbose -O /tmp/chromedriver_linux64.zip https://chromedriver.storage.googleapis.com/$CHROME_DRIVER_VERSION/chromedriver_linux64.zip
&& rm -rf /opt/chromedriver
&& unzip /tmp/chromedriver_linux64.zip -d /opt
&& rm /tmp/chromedriver_linux64.zip
&& mv /opt/chromedriver /opt/chromedriver-$CHROME_DRIVER_VERSION
&& chmod 755 /opt/chromedriver-$CHROME_DRIVER_VERSION
&& ln -fs /opt/chromedriver-$CHROME_DRIVER_VERSION /usr/local/sbin/chromedriver
Debug Info
Try building the above Dockerfile but getting the following error as there is no 116 version released
Error:
---> Running in 2b6b9bcf22af
https://chromedriver.storage.googleapis.com/LATEST_RELEASE_116:
2023-08-24 09:37:26 ERROR 404: Not Found.

Webdrivers version: chromedriver
Ruby version: nil
Operating system / CI Environment: Linux
Browser and version: chrome

Expected Behavior
chromedriver should be installed with latest release 116
Actual Behavior
chromedriver for 116 version is not present, so docker build failed

Chrome for testing changed the locations of drivers for download.
Please read the Readme for current recommendations.
https://github.com/titusfortner/webdrivers#update-future-of-this-project