Migrating from dotnet and all other .NET Core project types

We had multiple ways to create .NET Core projects prior to the MSBuild/csproj-based assets that are shipping for RTM of .NET Core tooling.  There were different project types in VS (xproj, PCL csproj with some packages) and different TFMs.  We need a doc which explains how each of the project types are obsolete, and what the upgrade path looks like for them.
This is motivated by a bug in TFS where a customer got bit my dotnet being deprecated when he upgraded some packages.

@cartermp would this be added to https://docs.microsoft.com/en-us/dotnet/core/migration/? can you give us more info on this so we know how to proceed?

I think this is pretty well-satisfied by that doc.  Closing!


Feat/add rerun on change

fixes #3111

I voluntarily break the commits into more succinctone in order to discuss about implementation easily

I don't think it makes sense to have these at the same level as the others, especially since they're explicitly not versioned. Instead of .onchange.sql, I think it should be a subfolder,
I'd propose migrations/after-migrate/ for less ambiguity (what does "change" mean? it's not as obvious as you might think). This also gives us room to extend it in the future, e.g.:

migrations/after-migrate-up/, executed only after upgrading from a previous version.
migrations/after-migrate-down/, executed only after downgrading from a previous version.
migrations/before-migrate/ and -up and -down variants, for executing scripts before migrating (maybe to kick off a backup or something).

You should also not rely on the filesystem returning entries in any defined order. It can differ between platforms and filesystems. For this reason, I'd recommend using the same filename format and applying scripts by version number just like migrations are.

Do we discuss about the choices and implementations here or in the related issue?
About the meaning of "change"
I may have poorly explained the process and the underlying logic in the related issue. As I think about it, a change is a modification of an entity. This leads to the question of what is an entity? An entity is a thing that has a unique and identifiable identifier.
In the implementation of Simple, ReverseUp and ReverseDown migrations, the identifier of a script is its version, extracted from the file name numeric prefix. And the changes are calculated from its checksum. So, in this case, a change is a checksum change for a given version.
As we agree that OnChange migrations does not have a version as it is irrelevant, the proposed implementation uses the description of the file as its identifier. So, in this case, a change is a checksum change for a given description.
For the design choice between the file suffix .onchange.sql and the sub-folder strategy
I think I see your point, I see the migrations folder as de default location where sqlx finds its scripts. It can be overridden. I think this is the user responsibility to organise its scripts as he wants to, I wouldn't base some behaviours based in the script location.
About the logic behind the migrations/[after|before]-migrate-[up|down], if we choose to use the proposed implementation, we can think of an Always migration with a .always.sql suffix and it is the responsibility to the user to move its scripts to relevant folder and to proceed to a potential workflow as follows:
# Say the user has this structure
.
├── after_migrate
│   ├── clean_logs.always.sql
│   └── update_ref_table.always.sql
├── before_migrate
│   ├── backup_database.always.sql
└── migrations
    ├── 0001_my_simple_script.sql
    └── 0002_another_simple_script.sql

We can perfectly do:
sqlx migrate run --source before_migrate --ignore-missing
sqlx migrate run  # --source migrations
sqlx migrate run --source after_migrate --ignore-missing

The main downfall (if it is really one) with the current capacities of the sqlx CLI is the need of --ignore-missing option to not trigger the validation process as we use different folder but it works perfectly in this use-case. But, as we do not track versions for OnChange or Always migrations, it is perfectly understandable and fine.
Overall, SQLx already provides quite all the mecanisms to do it.
About the order to apply OnChange migrations
There is two orders to think about. The first is, at which time do we apply the OnChange migrations? Before of after the regular ones with a version? I think the answer is explained above with the proposed workflow. Another possibility if all the scripts are in the same folder is to add a parameter like --run-always-first, --run-always-last, etc.
For the order between the OnChange (and potential Always ) migrations that do not have a version, I see three possibilities:

We enforce a sequential or timestamp version like the current behaviour
We leave the choice to the user to add or not the possibility to add a version
The order is random, like you said, order can differ between platforms and filesystems.

I htink to leave the choice to the user is the best choice, as I really think some workflows are not sensitive to order.
I hope my explanations are clear, I truly want to enhance this great lib.

Hello @abonander, any news about the suggestions? :)
The main points are:

.onchange.sql scripts vs subfolder strategy
scripts execution order


GUI: break long forms into step-by-step wizzards

Maybe even break the long forms into Tabs (like: Step 1: Properties, Step 2: Behaviors, etc... where appropriate) , saving the data at each step?

:+1:


feat(velodyne_ros_wrapper): add profiling log to velodyne

PR Type

Improvement

Related Links

@mojomex created profiling scripts in this PR: https://github.com/tier4/nebula/pull/37
Description

Thanks to @mojomex, it is easy to measure performance of the driver. However the necessary logging code wasn't added for Velodyne. I added the logging to velodyne_decoder_ros_wrapper.cpp so that it is possible to use existing scripts to mesure process time for also Velodyne lidars.
Review Procedure

The only modification is on velodyne_decoder_ros_wrapper.cpp. I added logging code according to hesai_decoder_ros_wrapper.cpp.
After building the package, go to the scripts directory and run:
./profiling_runner.bash vlp16 -m VLP16 -b <your_bag_file_which_includes_/velodyne_packets>
./profiling_runner.bash vls128 -m VLS128 -b <your_bag_file_which_includes_/velodyne_packets>

python3 plot_times.py vlp16

Here is the result I got for VLP16 and VLS128:

vlp16
vls128

d_total AVG
6.90601
30.3898

n_out AVG
15358.4
198887

d_total STD
2.60609
9.6811

n_out STD
103.414
87.4213

d_total AVG % rel to vlp16
100
440.048

n_out AVG % rel to vlp16
100
1294.97

d_total STD % rel to vlp16
100
371.479

n_out STD % rel to vlp16
100
84.5355

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[ ] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR: Required to pass before the merge.

Codecov Report
Patch coverage has no change and project coverage change: -2.12% :warning:

Comparison is base (f82a6f8) 13.36% compared to head (d165c0c) 11.24%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   13.36%   11.24%   -2.12%
==========================================
  Files         111       33      -78
  Lines       10986     4623    -6363
  Branches     1725     1145     -580
==========================================
- Hits         1468      520     -948
+ Misses       8342     3160    -5182
+ Partials     1176      943     -233

Flag
Coverage Δ

differential
11.24% <0.00%> (?)

total
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

..._ros/src/velodyne/velodyne_decoder_ros_wrapper.cpp
0.00% <0.00%> (ø)

... and 78 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Safari IOS 17: Error from chart in div instrument_candle_chart_2

By scrolling CandleStick:
SciChartSurface.js:
this.sciChartRenderer.render(context);
In SciChartSurface.prototype.doDrawingLoop.

I'm facing the same problem, the chart just disappear without reason. IOS >= 17

error here: OhlcSeriesDrawingProvider.prototype.draw, first call:
this.nativeDrawingProvider.DrawPointsVec(nativeContext, xDrawValues, openValues, highValues, lowValues, closeValues, renderPassData.xCoordinateCalculator.nativeCalculator, renderPassData.yCoordinateCalculator.nativeCalculator, this.args);

T

error here: OhlcSeriesDrawingProvider.prototype.draw, first call:
this.nativeDrawingProvider.DrawPointsVec(nativeContext, xDrawValues, openValues, highValues, lowValues, closeValues, renderPassData.xCoordinateCalculator.nativeCalculator, renderPassData.yCoordinateCalculator.nativeCalculator, this.args);

Great i'll try this, my bug just occuring with IOS>=17 , so in IOS 16~ it's working normally, android browsers working too.

Can you confirm which version of SciChart you are using, and if not the latest, does it occur with the latest code?  Does the error occur on demo.scichart.com or only in your own application?

Sorry for the delay.  We finally tracked down and solved this issue.  Safari seems to have a limitation on the number of parameters to a webassembly call.  Fix is released in v 3.2.549.  changelog


Formatter undocumented deviation: annotation wrapping

Black formatting
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb: Bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb = (
    Bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb()
)

Ruff formatting
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb: (
    Bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb
) = Bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb()

Use ruff 0.0.289.
Both are set to a line length of 100.

Thanks for reporting this deviation. Black seems to preserve parentheses in type annotation positions without ever introducing new parentheses.
This is inconsistent with other places where expression appear as a direct child of a statement (other than expression statement) where Black prefers to strip any unnecessary parentheses (and applies the custom "can omit parentheses" layout).
This can be solved "easily" by changing this line to use annotation.format() instead of maybe_parenthesize but it means that Ruff is more likely to exceed the line width
https://github.com/astral-sh/ruff/blob/c05e4628b1d385d106e7e3d355f5d1d76fbfe401/crates/ruff_python_formatter/src/statement/stmt_ann_assign.rs#L22-L30
This is probably related to https://github.com/astral-sh/ruff/issues/7322

Copied over from #7322

I can see how Black's formatting may seem better but Black's code exceeds the configured line width of 100, whereas Ruff's formatting stays in the limit.

Black is also a bit inconsistent here because it uses the same formatting as ruff if you change this to an assignment:

animation_data = (
    bpy.types.AnimData
)  # TODO(jonathan): Change to Optional when fake-bpy-module is updated

I propose that we stick to Ruff's layout because:

It is more consistent with other syntax
It stays within the configured line length

I'll leave this open for now to let other people chime in.

This is a known deviation -- can be closed once it's documented.


Delete resources script in Teraform

Hi Team,
Can we also include a terraform tear down script for removing all the resources created in an AWS account ?

You can run terraform destroy ...  and it'll clean up your environment on ALL cloud providers. If you could, clarify your question.

I'm using the docker container to run terraform from a vm and hence not sure how terraform destroy would apply directly. I'm a CFN user not an expert on TF.

Please review this documentation on how to Tear Down Resources If that answers your question please close this issue. Thx.

@dilipmrajan9 were you able to delete your items?

Thanks @thpang Havent had a chance to test it unfortunately. But let me close it out for the moment. Will reopen if I run into any issues.


[BUG] Order of elements in list[Link] is not preserved

Describe the bug
Something strange happening: after inserting an element in a list[Link] and saving to the db, the order of the elements is not preserved when fetching the Document from the database.
To Reproduce
import asyncio

from beanie import Document, Link, init_beanie
from beanie.odm.fields import WriteRules
from motor.motor_asyncio import AsyncIOMotorClient, AsyncIOMotorDatabase

class Item(Document):
    s: str

    class Settings:
        name = "items"

class User(Document):
    items: list[Link[Item]] | None = None

    class Settings:
        name = "users"
        use_state_management = True

async def main() -> None:
    cli = AsyncIOMotorClient("mongodb://beanie:beanie@localhost:27017")
    db = cli["test_id"]
    await init_beanie(
        database=db,
        document_models=[User, Item]  # type: ignore
    )

    new_item1 = Item(s="first")
    new_item3 = Item(s="third")
    new_user = User(items=[new_item1, new_item3])
    user_db = await new_user.insert(link_rule=WriteRules.WRITE)

    new_item2 = Item(s="second")
    item2_db = await new_item2.insert()
    item2 = await Item.get(item2_db.id)
    assert item2

    user = await User.get(user_db.id, fetch_links=True)
    assert user
    user.items.insert(1, item2)
    await user.save_changes()  # or user.save() or user.replace()

    user = await User.get(user_db.id, fetch_links=True)
    assert user
    assert len(user.items) == 3
    print([item.s for item in user.items])

    await cli.drop_database(db)

asyncio.run(main())

Output:
Random: at times, it works as expected; other times it might output:
['second', 'first', 'third']

['first', 'third', 'second']

Expected behavior
['first', 'second', 'third']

I realized this was already mentioned in:
https://github.com/roman-right/beanie/issues/414#issuecomment-1443671486
https://github.com/roman-right/beanie/issues/414#issuecomment-1444126740


Collect crash data for Los Angeles, CA

there's a pretty extensive dashboard made up of different data sources here - https://visionzero.geohub.lacity.org/

Article stating when Vision Zero program was started in LA - https://laist.com/news/transportation/traffic-violence-la-vision-zero-audit

Link to collision codebook - https://drive.google.com/file/d/0Bwxbq6vwGK_1UDA3eTkyR3ZOTDA/view?resourcekey=0-MPODvQJgl_UrhqeCZARBMQ


Upload to maven repo

This library is really nice but I found that I cannot use it via Maven repo.
I hope this library can be uploaded to maven repo. It will be easier for developers to use.

How do I do this?

Well.... In fact, I haven't tried to do this, too.
Here is a possible way: http://central.sonatype.org/pages/ossrh-guide.html

Hi!
Easy to publish on JitPack:) In fact MaterialPreferenceLibrary is already there: https://jitpack.io/#AndroidDeveloperLB/MaterialPreferenceLibrary/2d3add8596
Btw, if you add a GitHub release then we'll be able to use that as the version instead of a commit:
https://github.com/AndroidDeveloperLB/MaterialPreferenceLibrary/releases

Doesn't this include the sample inside too?
How do I make it exclude what's not needed?

The app now has a release and an easy-to-use gradle repo. closing this issue.


permutation test: account for node degree

Hi @vargasr39 - one thing that we discussed with Ed and that also came up as a reviewer comment for the application note is to, optionally, account for the node degree distribution in the complex being tested. That means in addition to accounting for the bait:prey ratio in the complex, we would like to pull out in each random sample the same amount of baits and same amount of preys, but also pull out nodes in a way that we have node degrees as in the complex that we test.
A simple example: if we would have a complex of two baits and one prey protein, and overall the first bait has 3 edges, the second bait has 2 edges, and the prey has one edge, than we would like to pull in each random sample a bait with 3 edges, a bait with 2 edges, and a prey with one edge. (an enhancement to this would be to account for directionality, ie incoming node degree and outgoing node degree, but I would ignore that for the first time around).
This should be a boolean argument to the function, ie something like preserve.node.degree = FALSE to perform the test as it is right now, ie without accounting for node degree, and something like preserve.node.degree = TRUE to account for node degree as described above.

This functionality has been implemented into the permutation_test_for_uniprot_list() function.


Build osgearth with optional dependence dacro

Among the dependencies of osgearth, some dependencies are optional, such as draco, so how to add optional dependencies at build time?

Hi @showintime
Thanks for posting this issue. In this case, we can consider to add these optional dependencies as features for osgearth.
If we want to build with some of them, such as draco, we can build like this ./vcpkg install osgearth[draco].

Hello @NancyLi1013
Good Idea
by the way, how do you plan to implement this feature?

If you have the demand, we will add the options for the feature and also need to do some changes.
Please let me know which features you are required except for draco.

draco & gdal

I will try to add these two features later and also verify if they can build fine.

Confirm!
Thank you for your help.

Hi @showintime
I submitted a PR #13243 to add these two features.
Could you please help confirm if these can work for you?
Thanks.

Hi @NancyLi1013
Did you mean git pull https://github.com/NancyLi1013/vcpkg.git dev/NancyLi/add-feature-for-osgearth?
Sorry for my git.

Hi @showintime
You can do as the following steps:

git clone https://github.com/NancyLi1013/vcpkg.git
cd vcpkg
git checkout -b dev/NancyLi/add-feature-for-osgearth origin/dev/NancyLi/add-feature-for-osgearth

Note: This can only work fine with the old version of geos. Since current version cannot build with osgearth. Please see #13292.
So if your local hasn't updated geos, you can make a try. You'd better make these changes manually. Otherwise, it still cannot work now.

i will try soon

Hi @showintime
Currently, draco has been added as the dependency of osgearth. gdal will also be built by default. Please see the result:
PS F:\20210929\vcpkg> .\vcpkg.exe install osgearth:x64-windows --editable
Computing installation plan...
The following packages will be built and installed:
  * basisu[core]:x64-windows -> 1.11#5
  * boost-algorithm[core]:x64-windows -> 1.77.0
  * boost-align[core]:x64-windows -> 1.77.0
  * boost-any[core]:x64-windows -> 1.77.0
  * boost-array[core]:x64-windows -> 1.77.0
  * boost-assert[core]:x64-windows -> 1.77.0
  * boost-atomic[core]:x64-windows -> 1.77.0
  * boost-bind[core]:x64-windows -> 1.77.0
  * boost-chrono[core]:x64-windows -> 1.77.0
  * boost-concept-check[core]:x64-windows -> 1.77.0
  * boost-config[core]:x64-windows -> 1.77.0#2
  * boost-container[core]:x64-windows -> 1.77.0
  * boost-container-hash[core]:x64-windows -> 1.77.0
  * boost-conversion[core]:x64-windows -> 1.77.0
  * boost-core[core]:x64-windows -> 1.77.0
  * boost-date-time[core]:x64-windows -> 1.77.0
  * boost-detail[core]:x64-windows -> 1.77.0
  * boost-dynamic-bitset[core]:x64-windows -> 1.77.0
  * boost-endian[core]:x64-windows -> 1.77.0
  * boost-exception[core]:x64-windows -> 1.77.0
  * boost-filesystem[core]:x64-windows -> 1.77.0
  * boost-foreach[core]:x64-windows -> 1.77.0
  * boost-function[core]:x64-windows -> 1.77.0
  * boost-function-types[core]:x64-windows -> 1.77.0
  * boost-fusion[core]:x64-windows -> 1.77.0
  * boost-integer[core]:x64-windows -> 1.77.0
  * boost-interprocess[core]:x64-windows -> 1.77.0
  * boost-intrusive[core]:x64-windows -> 1.77.0
  * boost-io[core]:x64-windows -> 1.77.0
  * boost-iostreams[bzip2,core,lzma,zlib,zstd]:x64-windows -> 1.77.0#1
  * boost-iterator[core]:x64-windows -> 1.77.0
  * boost-lambda[core]:x64-windows -> 1.77.0
  * boost-lexical-cast[core]:x64-windows -> 1.77.0
  * boost-math[core]:x64-windows -> 1.77.0
  * boost-move[core]:x64-windows -> 1.77.0
  * boost-mpl[core]:x64-windows -> 1.77.0
  * boost-multi-index[core]:x64-windows -> 1.77.0
  * boost-numeric-conversion[core]:x64-windows -> 1.77.0
  * boost-optional[core]:x64-windows -> 1.77.0
  * boost-phoenix[core]:x64-windows -> 1.77.0
  * boost-pool[core]:x64-windows -> 1.77.0
  * boost-predef[core]:x64-windows -> 1.77.0
  * boost-preprocessor[core]:x64-windows -> 1.77.0
  * boost-program-options[core]:x64-windows -> 1.77.0
  * boost-proto[core]:x64-windows -> 1.77.0
  * boost-random[core]:x64-windows -> 1.77.0
  * boost-range[core]:x64-windows -> 1.77.0
  * boost-ratio[core]:x64-windows -> 1.77.0
  * boost-rational[core]:x64-windows -> 1.77.0
  * boost-regex[core]:x64-windows -> 1.77.0
  * boost-serialization[core]:x64-windows -> 1.77.0
  * boost-smart-ptr[core]:x64-windows -> 1.77.0
  * boost-spirit[core]:x64-windows -> 1.77.0
  * boost-static-assert[core]:x64-windows -> 1.77.0
  * boost-system[core]:x64-windows -> 1.77.0
  * boost-thread[core]:x64-windows -> 1.77.0
  * boost-throw-exception[core]:x64-windows -> 1.77.0
  * boost-tokenizer[core]:x64-windows -> 1.77.0
  * boost-tti[core]:x64-windows -> 1.77.0
  * boost-tuple[core]:x64-windows -> 1.77.0
  * boost-type-index[core]:x64-windows -> 1.77.0
  * boost-type-traits[core]:x64-windows -> 1.77.0
  * boost-typeof[core]:x64-windows -> 1.77.0
  * boost-unordered[core]:x64-windows -> 1.77.0
  * boost-utility[core]:x64-windows -> 1.77.0
  * boost-uuid[core]:x64-windows -> 1.77.0
  * boost-variant[core]:x64-windows -> 1.77.0
  * boost-vcpkg-helpers[core]:x64-windows -> 1.77.0
  * boost-winapi[core]:x64-windows -> 1.77.0
  * coin[core,simage,zlib]:x64-windows -> 4.0.0#4
  * curl[core,non-http,schannel,ssl,sspi]:x64-windows -> 7.79.1
  * draco[core]:x64-windows -> 1.4.3
  * expat[core]:x64-windows -> 2.4.1
  * freeglut[core]:x64-windows -> 3.2.1#7
  * freetype[brotli,bzip2,core,png,zlib]:x64-windows -> 2.11.0#2
  * gdal[core]:x64-windows -> 3.3.2#3
  * geos[core]:x64-windows -> 3.9.1#3
  * giflib[core]:x64-windows -> 5.2.1
  * glew[core]:x64-windows -> 2.2.0
  * hdf5[core,szip,zlib]:x64-windows -> 1.12.1
  * ilmbase[core]:x64-windows -> 2.3.0#1
  * jasper[core]:x64-windows -> 2.0.33
  * libflac[core]:x64-windows -> 1.3.3#6
  * libgeotiff[core]:x64-windows -> 1.6.0#4
  * libgta[core]:x64-windows -> 1.0.8#3
  * libiconv[core]:x64-windows -> 1.16#11
  * liblas[core]:x64-windows -> 1.8.1#8
  * liblzma[core]:x64-windows -> 5.2.5#4
  * libogg[core]:x64-windows -> 1.3.5
  * libpng[core]:x64-windows -> 1.6.37#15
  * libsndfile[core,external-libs]:x64-windows -> 1.0.31
  * libsquish[core]:x64-windows -> 1.15#9
  * libvorbis[core]:x64-windows -> 1.3.7#1
  * libwebp[core,nearlossless,simd,unicode]:x64-windows -> 1.2.1
  * libxml2[core]:x64-windows -> 2.9.12#4
  * libzip[bzip2,core,default-aes,wincrypto]:x64-windows -> 1.7.3#2
  * lodepng[core]:x64-windows -> 2020-03-15#1
  * netcdf-c[core,dap,netcdf-4]:x64-windows -> 4.7.4#4
  * nvtt[core]:x64-windows -> 2.1.2#2
  * openexr[core]:x64-windows -> 2.5.0#3
  * opengl[core]:x64-windows -> 0.0#9
  * openjpeg[core]:x64-windows -> 2.4.0
  * opus[core]:x64-windows -> 1.3.1#6
  * osg[core,plugins]:x64-windows -> 3.6.5#10
    osgearth[core,tools]:x64-windows -> 3.2#1
  * proj4[core,tiff]:x64-windows -> 7.2.1#7
  * protobuf[core]:x64-windows -> 3.18.0
  * sdl1[core]:x64-windows -> 1.2.15#14
  * simage[all,avienc,core,gdiplus,oggvorbis,sndfile]:x64-windows -> 1.8.1#3
  * sqlite3[core,tool]:x64-windows -> 3.36.0#1
  * szip[core]:x64-windows -> 2.1.1#7
  * tiff[core,jpeg,lzma,zip]:x64-windows -> 4.3.0#2
  * tinyxml[core]:x64-windows -> 2.6.2#8
  * zstd[core]:x64-windows -> 1.5.0#1
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-windows...

Please try to update to the latest vcpkg to rebuild this port. So I'm closing this issue for now.


Opcode Extensions

Fixes issue #87

Please rebase/update. I think after that it's mergeable.

@XVilka There is still one more case missing. Sign extension for right shifting (corresponding to x86 SAR instruction that fills in the shifted bits based on the sign of the unshifted/original argument).
Are there any more instructions that may perform SignExt that we haven't considered?


fix: shader mask draws incorrectly on Flutter Web(html renderer) due to incorrect canvas size

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

clone this repo: https://github.com/Kingtous/dora_demo with branch bug/html_radial_color.
flutter run -d chrome --renderer html
bug shows. (The second text is not fully rendered, see Actual results below).

I've successfully found the problem in the engine, and pr will be available soon.
Note that it's easy to reproduce this issue, just placing two text with ShaderMask, and make them have the same width but different height, vice versa.
Expected results
the two texts are rendered correctly.

Actual results

the mask is incorrect:

Code sample
Code sample
import 'dart:math';
import 'dart:typed_data';

import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'dart:ui' as ui;

void main() {
  runApp(const App());
}

class App extends StatelessWidget {
  const App({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Stack(
        children: [
          Home(),
        ],
      ),
    );
  }
}

class Home extends StatefulWidget {
  const Home({super.key});

  @override
  State<Home> createState() => _HomeState();
}

class _HomeState extends State<Home> {
  final colors = [Colors.red, Colors.orange, Colors.blue];

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.black,
      body: SingleChildScrollView(
        child: Row(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Column(
              crossAxisAlignment: CrossAxisAlignment.center,
              children: [
                SizedBox(
                  width: 400,
                  child: ShaderMask(
                    shaderCallback: (rect) {
                      return RadialGradient(colors: colors).createShader(rect);
                    },
                    child: Text(
                      "This is the first text which has 400 width, let make them same width.",
                      style: TextStyle(fontSize: 30, color: Colors.grey.shade500),
                    ),
                  ),
                ),
                SizedBox(
                  height: 50,
                ),
                SizedBox(
                  width: 400,
                  child: ShaderMask(
                    shaderCallback: (rect) {
                      return RadialGradient(colors: colors).createShader(rect);
                    },
                    child: Text(
                      "This is the first text which has 400 width, let make them same width but different height. place holder  place holder  place holder  place holder  place holder",
                      style: TextStyle(fontSize: 30,color: Colors.grey.shade500),
                    ),
                  ),
                ),
              ],
            ),
          ],
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
no

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.3, on macOS 13.5 22G74 darwin-x64, locale zh-Hans-CN)
    • Flutter version 3.10.3 on channel stable at /Users/kingtous/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f92f44110e (3 months ago), 2023-06-01 18:17:33 -0500
    • Engine revision 2a3401c9bb
    • Dart version 3.0.3
    • DevTools version 2.23.1
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/kingtous/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • Java binary at: /usr/local/opt/openjdk@11/bin/java
    • Java version OpenJDK Runtime Environment Homebrew (build 11.0.20+0)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Users/kingtous/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.9526055/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.70.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.5 22G74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 116.0.5845.96

[!] Network resources
    ✗ An HTTP error occurred while checking "https://github.com/": Connection closed before full header was received

! Doctor found issues in 2 categories.

Thanks for the report and potential fix.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.13.0, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.13.0 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision efbf63d9c6 (27 hours ago), 2023-08-15 21:05:06 -0500
    • Engine revision 1ac611c64e
    • Dart version 3.1.0
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.14.0-8.0.pre.21, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.14.0-8.0.pre.21 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c328d03928 (2 hours ago), 2023-08-20 23:21:32 -0400
    • Engine revision e7d7451117
    • Dart version 3.2.0 (build 3.2.0-90.0.dev)
    • DevTools version 2.26.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.


Documentation installing from scratch is missing a reference to the configuration SUPERSET_CONFIG_PATH variable

Description
When a new user try to install Superset step by step following the installing-superset-from-scratch.mdx documentation is missing two pieces of information:

How to give access to superset to the superset_config.py file
How to export FLASK_APP=superset prior to the database generation

Trying to revisit the conversation on this PR. We might want to close this since it's not really a Superset bug, but I'll leave it open for now in hopes that we can get your PR addressed.

Closing this as stale, especially since the PR is closed too... but happy to pick this up again if you're interested.


💪  Typesafe Keys.filter([], {})

Found this great example of TypeScript method overloading: https://blog.mariusschulz.com/2016/08/18/function-overloads-in-typescript

Somehow #d0b7512 worked on Node 8, but not Node 7. Starting poor attempts at fixing them...


fixes #173

Juraj said "I believe that here is quite evident that the problem is unknown operator ... not missing field".
Could you add a test for that?

Codecov Report
Base: 96.35% // Head: 96.15% // Decreases project coverage by -0.20% :warning:

Coverage data is based on head (c8bb56c) compared to base (3d66fb7).
Patch coverage: 83.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   96.35%   96.15%   -0.20%
==========================================
  Files          60       60
  Lines        7081     7133      +52
==========================================
+ Hits         6823     6859      +36
- Misses        258      274      +16

Flag
Coverage Δ

unittests
96.15% <83.50%> (-0.20%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

test/connection/test_connection.py
91.89% <ø> (ø)

weaviate/client.py
98.30% <ø> (ø)

weaviate/wcs/crud_wcs.py
98.50% <ø> (ø)

integration/test_authentication.py
89.09% <57.89%> (-6.52%)
:arrow_down:

weaviate/connect/connection.py
90.05% <68.00%> (-3.66%)
:arrow_down:

test/gql/test_filter.py
100.00% <100.00%> (ø)

test/test_client.py
100.00% <100.00%> (ø)

test/test_version.py
100.00% <100.00%> (ø)

weaviate/auth.py
100.00% <100.00%> (ø)

weaviate/batch/crud_batch.py
91.66% <100.00%> (-0.03%)
:arrow_down:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@dirkkul The test are checking if none of the operators are present or if multiple are present: https://github.com/weaviate/weaviate-python-client/blob/fix/gh-173/test/gql/test_filter.py#L559-L565
The error for none of the operators includes the accepted operators: https://github.com/weaviate/weaviate-python-client/blob/fix/gh-173/weaviate/gql/filter.py#L777-L780

I see thanks! Could you change the PR title to something more meaningful and then we can merge?


Start automated aggregation and surfacing of internal documentation with Rustdoc

First PR for leveraging rustdoc to surface existing documentation in the code. This reduces the need for redundant documentation on complex and quickly-evolving systems such as configuration files and stores.
This PR focuses on requested improvements and aggregation of information on configuring Nativelink, as well as establishing rustdoc patterns to use on the rest of the monorepo as it is continuously documented.
The change surfaces the below information from the existing nativelink-config documentation for the rust doc:

Example READMEs (For examples from In-flight PR from @MarcusSorealheis & Kubernetes deployment examples)

In order to thoroughly document the requested cas.json , scheduler.json, cas.yaml,  and scheduler.yaml examples they require updating in one place

After running cargo doc in the repository, this page can be reviewed in the browser at:
file:///Path/to/repo/nativelink/target/doc/nativelink_config/index.html
This change also surfaces existing documentation and mildly enhances with examples for:

nativelink-config/stores.rs -> enum StoreConfig

After running cargo doc in the repository, this page can be reviewed in the browser at:
file:///Users/blakehatch/Projects/nativelink/target/doc/nativelink_config/stores/enum.StoreConfig.html
Upcoming PRs will focus on improving the existing now surfaced and aggregated documentation as well as the formatting of the generated Markdown in nativelink-config/src/lib.rs
#681
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

This change is

Yup there goes CI blowing up lol, let me fix I thought rust format would save me 😄

Nit: ```json5

It seems like the lines in lib.rs pulling in the READMEs with relative paths
#![doc = include_str!("../examples/README.md")]
are causing issues with CI and creating the OCI image.
Any idea on a workaround @aaronmondal?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Outdated.


STAT v2 Preview - Problems with the Sample-STAT-Triage Playbooks

Describe the bug
I'm testing STAT v2. So far it looks very nice. Thank you for this big update! 💯
I have discovered the following bug. I am deploying the version 2 module with a user-assigned managed identity. When I deploy the sample STAT triage playbook and run it on a playbook, I get the following error (picture 1 and picture 2) for all three modules (AAD Risks Module / Related Alerts Module / Threat Intel Module) in the playbook.
But when I create a new clean playbook and rebuild the hole sample playbook in this new playbook. The modules run without this errors (see third screenshot).
Module Name
AAD Risks Module / Related Alerts Module / Threat Intel Module
To Reproduce
Deploy Stat Version 2 with a user-assigned managed identity.
Run the Sample Playbook on an incident.
Expected behavior
Call the different modules with no errors
Screenshots
Sample-STAT-Triage error:

Sample-STAT-Triage error:

New created playbook:

@lorisAmbrozzo thanks for the detailed description.  I will take a look into it

Fixed in latest preview deployment update: https://github.com/briandelmsft/SentinelAutomationModules/tree/statv2_preview/Deploy


Implement perfdash support for ContainerRestarts measurement.

/kind feature
/assign @jprzychodzen

/hold
It's quite to read. Let me change it slightly

/hold cancel
I changed the code to present all containers on a single graph. The reasoning is that it should be 0 for most of the containers and having one view makes it easier to find restarting components.

/lgtm


test: fix coverage for Button class

Description
Fixes the decrease in test coverage introduced by https://github.com/openedx/paragon/pull/2149
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

Thanks for the pull request, @keithgg!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@adamstankiewicz this is ready for review. The coverage in #2149 is 90.93% whereas on this PR it's 90.92%. This is due to the total number of tracked lines decreasing.
Before: 4172 tracked lines - 3794 covered == 90.93% with 371 lines not tracked
After   : 4097 tracked lines - 3725 covered == 90.92% with 365 lines not tracked

:tada: This PR is included in version 20.30.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 21.0.0-alpha.19 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Include update with playground enabled features

Currently blocked by https://github.com/uuid-rs/uuid/pull/155
This will address the original issue of #192

Thanks! However, I don't really want to accept one-off updates for a single crate. Instead, these types of changes just get rolled into periodic updates of all the crates. Once the UUID crate accepts the change, releases, then our update occurs, it will be magically available!


feat: implemented Equality Of Opportunity metric and some improvements on testing and demos

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

2.2.0
GitHub release

Your semantic-release bot :package::rocket:


Get some new attributes when calling hooks

When calling updated and created callback hooks there might be some new data to add to the model.
This is where I felt like a deadend when I was working with "serverSide: false" in datatables which will not reload the data after edit or create and use the response from the server. So I had to add some columns to the returning data to fix it and this parts that I've added might be good for other usages too.

Looks good, will check this on actual project as soon as I can. Thanks!

BTW, can you please provide some snippets on how you would use this PR? TIA.

Released on v1.8.0 🚀 thanks!

If we turn the "serverSide" option in the datatables to false, the editor will use the response from server to update tables data on an edit request to server. So if we have some additional columns which we would like to update, we need an option to do that, like this:
    public function updated(Model $model, array $data)
    {
        $model->setAttribute('grade_system', ['id' => $model->gradeSystem->id, 'name' => $model->gradeSystem->name]);
        return $model;
    }

So I've used the "setAttribute" to add my custom column to the server response.
I think the DataTableEditor should use DataTable in the middle for responses so we could use more attributes like 'options'.

@yajra @aminprox Please update the documentation on event hooks.  All the code samples return $data instead of $model, this merge breaks any existing code that returns $data instead of $model.

@Xint0 thank you for reporting the docs. In can be updated on this repo: https://github.com/yajra/laravel-datatables-docs
Will fix the docs when I got the chance or a PR is most welcomed. Thanks!

BTW, I think returning the data or model should not affect the existing codes since we are not mapping it back to the data variable?
There is also a missing event docs for saved :) .

Will work on PR for the documentation change, in the mean time this is my take on the issue.
The potential problem is when existing hooks return $data as in the code example (or don't return anything at all), then line 210 will throw exception since now $model is replaced by the return value (an array or null).
public function updated(Model $model, array $data)
{
   // This causes exception in DataTablesEditor.php line 210 because $model was replaced by
   // an array in line 203
   return $data;
}

I think the changes to lines 81, 85, 203, and 207 are unnecessary, since $model is an object reference and mutations inside the hooks will be preserved on the instance after completion:
public function updated(Model $model, array $data)
{
    // No need to return $model to preserve new attribute, since the reference is not being
    // changed.
    $model->setAttribute(
        'grade_system',
        ['id' => $model->gradeSystem->id, 'name' => $model->gradeSystem->name]
    );
}

The changes would only be required if the hook code changes the reference (i.e. replaces $model with a new instance):
public function updated(Model $model, array $data)
{
    // Will need to return $model only if instance reference is replaced
    $model = Model::find($model->id);
    return $model;
}

I don't think this is a good idea since it breaks compatibility with current interface definition which doesn't define a return type for the event hook methods.

@Xint0 good and valid points.
@aminprox can I have your opinion on @Xint0 suggestions?
If @aminprox agrees, I will revert this PR. He might have some edge case that works only with this PR that we might be missing.

I do agree with @Xint0 about this, but I think there should be another way to pass the DataTable object in return without breaking the compatibility and because the compatibility is more important its not necessary to keep these changes.


asadiqbal08/Don't link to courses that aren't open yet

Pre-Flight checklist

[ ] Screenshots and design review for any changes that affect layout or styling

[ ] Desktop screenshots

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
fixes: #130
What's this PR do?
If the course start date is before the current date or end date is after current date the show the course title as link otherwise as simple text on user's dashboard.
How should this be manually tested?
Change the course run start date as described above to verify it.
Screenshots (if appropriate)

Codecov Report

Merging #139 (6ff52a9) into main (252dace) will decrease coverage by 5.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   90.19%   84.45%   -5.75%
==========================================
  Files         205       87     -118
  Lines        5976     3287    -2689
  Branches      284      284
==========================================
- Hits         5390     2776    -2614
+ Misses        501      426      -75
  Partials       85       85

Impacted Files
Coverage Δ

static/js/containers/pages/login/LoginPages.js

...tainers/pages/register/RegisterConfirmPage_test.js

static/js/components/forms/ProfileFormFields.js

static/js/components/Expandable_test.js

...tic/js/components/forms/ChangePasswordForm_test.js

...atic/js/components/forms/RegisterEmailForm_test.js

webpack.config.shared.js

...atic/js/containers/pages/register/RegisterPages.js

static/js/lib/queries/users_test.js

static/js/babelhook.js

... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252dace...6ff52a9. Read the comment docs.


Added the alternating square pattern question and solution

I added the question and solution in C++ for the same

Hi, has this project been excluded now? I'm seeing this repo as being excluded though the label has been given.


feat(operators): initial support for like/ilike

What kind of change does this PR introduce?
Support for like/ilike operators
What is the current behavior?
#193
What is the new behavior?
Filter operators added for like/ilike
Additional context
I've only tried this out in the DB from Supabase CLI so I could only run rebuild_schema() to refresh my changes, but I was unable to get either operator to appear when introspecting the gql endpoint. Running queries regarless with like/ilike worked perfectly though.
Missing:

Introspection (may have been due to how I was testing this?)
not like/not ilike. I'm not sure how to go about this
Tests are missing

resolves #193

closing due to inactivity


feat(icons): add occupancy icons

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #325   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          39     39
  Lines         457    457
=====================================
  Hits          457    457

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f8348b...7513eb1. Read the comment docs.


[rtl] Replace X assignments

This PR:

Replaces all X assignments in the RTL with defined values.
Imports a new file from OpenTitan containing macros for SystemVerilog assertions (SVAs).
Rewrites existing SVAs using these macros.
Adds SVAs to catch invalid signal values in simulation.

Once we have found agreement, I would be happy if

@msfschaffner could check if this PR removes the linting errors, and
@udinator could check that no assertion unintentionally fires.

Thanks for your work on this @vogelpi. Looks like there's a couple of issues with building the UVM testbench on VCS which I'm currently sorting out and will push a new version once I've got something that works.

Found some failures, I think all related to an assert in ibex_load_store_unit.sv
`ASSERT_KNOWN(IbexDataOffsetKnown, data_offset, clk_i, !rst_ni)

I'll see if I can work out what's failing. I'll hand over to @udinator if it's not straight-forward

I've fixed the UVM TB build issue and an X issue (compressed instruction decoder still had an explicit X assignment in it). Wasn't sure of the best way to update this PR directly so here's the diff instead:
diff --git a/dv/uvm/ibex_dv.f b/dv/uvm/ibex_dv.f
index 410d85f..55a8090 100644
--- a/dv/uvm/ibex_dv.f
+++ b/dv/uvm/ibex_dv.f
@@ -10,6 +10,7 @@ ${PRJ_DIR}/ibex/shared/rtl/prim_clock_gating.sv

 // ibex CORE RTL files
 +incdir+${PRJ_DIR}/ibex/rtl
+${PRJ_DIR}/ibex/shared/rtl/prim_assert.sv
 ${PRJ_DIR}/ibex/rtl/ibex_pkg.sv
 ${PRJ_DIR}/ibex/rtl/ibex_tracer_pkg.sv
 ${PRJ_DIR}/ibex/rtl/ibex_tracer.sv
diff --git a/rtl/ibex_compressed_decoder.sv b/rtl/ibex_compressed_decoder.sv
index 3a285ae..ba607d6 100644
--- a/rtl/ibex_compressed_decoder.sv
+++ b/rtl/ibex_compressed_decoder.sv
@@ -23,7 +23,8 @@ module ibex_compressed_decoder (

   always_comb begin
     illegal_instr_o = 1'b0;
-    instr_o         = 'X;
+    // Default instruction is NOP (ADDI x0, x0, 0)
+    instr_o         = {12'd0, 5'd0, 3'd0, 5'd0, OPCODE_OP_IMM};

     unique case (instr_i[1:0])
       // C0
diff --git a/rtl/ibex_id_stage.sv b/rtl/ibex_id_stage.sv
index 215cd1e..abd80f1 100644
--- a/rtl/ibex_id_stage.sv
+++ b/rtl/ibex_id_stage.sv
@@ -630,7 +630,7 @@ module ibex_id_stage #(
   `ASSERT_KNOWN(IbexWbStateKnown, id_wb_fsm_cs, clk_i, !rst_ni)

   // Branch decision must be valid when jumping
-  `ASSERT(IbexBranchDecisionValid, branch_in_dec |-> !isunknown(branch_decision_i), clk_i, !rst_ni)
+  `ASSERT(IbexBranchDecisionValid, branch_in_dec |-> !$isunknown(branch_decision_i), clk_i, !rst_ni)

   // Instruction delivered to ID stage can not contain X
   `ASSERT(IbexIdInstrKnown,

Though still getting a few failures in debug_branch_jump_test, debug_ebreakmu_test, unaligned_load_store_test, mem_error_test and reset_test. None of them is due to an assertion failure or obvious X related issue from the logs but something more subtle may be happening.
@udinator if you've got some time today could you apply my patch above to this PR and take a look? Otherwise I'll continue investigating tomorrow.

Thanks for the clean-up - let me know once you sorted out the remaining issues. I ran lint using @GregAC's patch and that is lint-clean.

Thanks for the cleanup @vogelpi , and for the patch @GregAC! Sanity regressions after applying the patch are clean except for a failure in debug_branch_jump_test, which I think is due to some subtle error I accidentally introduced in https://github.com/google/riscv-dv/pull/336 to the instruction generator, and shouldn't be an issue with Ibex.

Thanks everybody for the nice team work! I applied Greg's patch to this PR. If someone can approve this, we can merge it.

I have pushed the following changes:

Replace the immediate assertion with clocked assertions as requested. For this I had to feed the clock and reset into the purely combinational decoders.
Rework a bit the compressed decoder to by default feed the incoming instruction to the output and declare it as legal. Most of you suggested to the opposite, i.e., to by default declare it as illegal. I am not convinced that this is the way to go as outline here: https://github.com/lowRISC/ibex/pull/528#discussion_r359485040  but maybe there is just a misunderstanding. Please let me know if you don't agree with my suggestion. I have no problem to change it back if can tell me why it is better.

Thanks @GregAC for approving the PR!


add bcd to binary code converter

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
i wud like to work on this issue

Go ahead
Deadline 20 May,2021


Should not set 'shoud-wait' in 'settings.autoscaling' to true in Bottlerocket userdata

Description
How can the docs be improved?
If the Bottlerocket userdata is configured as follows, node fails to join the cluster.
[settings.autoscaling]
should-wait = true

It would be good to have documentation updated to address this situation.
Alternatively, since Karpenter doesn't utilize AWS Auto Scaling Groups in any case, it might be good to ensure in the source code that this configuration is always set to false. If this idea is good, I want to contribute directly to the source code.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

@wkd3475 I understand the concern and would like to contribute the documentation/Code to change the default setting to "false" Pls confirm!! I will create an issue and send out an PR!!
Thanks!!!


Fix 364

This bug is caused by the relationship between the following components:

The func (b *BundleBuilder) InitWorkspace(workspace string, runtimeValues map[string]string) error function in
internal/engine/bundle_builder.go
The BundleBuilder.files field
The BundleBuilder.mapSourceToOrigin field
The func (b *BundleBuilder) getInstanceUrl(v cue.Value) string
function in internal/engine/bundle_builder.go

When called, the InitWorkspace goes through the list of files stored
in b.files, parses them and writes the result in new files (let's call
them "result files") located under the path indicated by workspace. In
parallel, b.mapSourceToOrigin maps a "result file" path to the
original file the result is based on.
At the end of the function, the original list b.files is replaced with
the list of "result files".
The next invocation of InitWorkspace then uses b.files again, but
this time it contains the previously computed "result files" paths.
So, for a given:

b.files == ["/path/to/a/bundle.cue"]

calling InitWorkspace("/tmp/workspace1/"), will yield:

b.files == ["/tmp/workspace1/bundle.cue"]
b.mapSourceToOrigin["/tmp/workspace1/bundle.cue"]="/path/to/a/bundle.cue"

Then calling InitWorkspace("/tmp/workspace2/"), will yield:

b.files == ["/tmp/workspace2/bundle.cue"]
b.mapSourceToOrigin["/tmp/workspace2/bundle.cue"]="/tmp/workspace1/bundle.cue"

The getInstanceUrl relies on the mapSourceToOrigin being accurate to
propely resolve relative file:// paths.
When getInstanceUrl() is called for the first bundle, it will propely
resolve ./examples/redis/ to /path/to/a/examples/redis/.
When getInstanceUrl() is called for the second bundle, it will erroneously
resolve ./examples/redis/ to /tmp/workspace1/examples/redis/.
This commit fixes this.
However it is worth noting that using a relative path for a file://
URI feels strange. Should it be allowed in the first place?

This fix doesn't work if -f - is used instead of an actual path to a file.

However it is worth noting that using a relative path for a file:// URI feels strange. Should it be allowed in the first place?

This is how many tools work, for example Docker Compose, so I don't find it strange but actually useful.


Update "Release Notes" section in web documentation - especially Release Notes for version 2.0

To be discussed:

Pekko switch
GraalVM switch
Python
Debugging
Stream Input Sources support mutliple directories, i.e. Folders
Microsoft Teams service (server ticket 342)
Input Frame Committer processor
Dark mode
Stream Output should support "empty files" (ticket #276 - 2.0.4)
Automatic reprocessing of changed files (ticket #344 - 2.0.0)


Carthage build from 3.0.0 branch failed

There is an issue in 3.0.0 branch when trying to build framework:
target 'AFNetworking tvOS' has bitcode disabled (ENABLE_BITCODE = NO), but it is required for the 'appletvos' platform

What version of carthage are you using?

@kcharwood hello! Carthage version is 0.10.0

I was just able to build it without issue. Can you provide more information around what you are doing?
02:44:05 {master branch} ~/GIT/Test $ carthage update
*** Fetching AFNetworking
*** Checking out AFNetworking at "3.0.0-beta.1"
*** xcodebuild output can be found in /var/folders/r_/lwz89qf17kzg37z7z7wk1hrm00022z/T/carthage-xcodebuild.EMy6kZ.log
*** Building scheme "AFNetworking OS X" in AFNetworking.xcworkspace
*** Building scheme "AFNetworking watchOS" in AFNetworking.xcworkspace
*** Building scheme "AFNetworking tvOS" in AFNetworking.xcworkspace
*** Building scheme "AFNetworking iOS" in AFNetworking.xcworkspace
02:45:33 {master branch} ~/GIT/Test $ carthage version
0.10.0

Cartfile:
github "AFNetworking/AFNetworking" ~> 3.0

$ carthage update
*** Fetching AFNetworking
*** Checking out AFNetworking at "3.0.0-beta.1"
*** xcodebuild output can be found in /var/folders/hs/0w1vs16j69bg159vqz8lzc680000gn/T/carthage-xcodebuild.leBCMA.log
*** Building scheme "AFNetworking OS X" in AFNetworking.xcworkspace
*** Building scheme "AFNetworking tvOS" in AFNetworking.xcworkspace
** BUILD FAILED **

The following build commands failed:
	Check dependencies
(1 failure)
A shell task failed with exit code 65:
** BUILD FAILED **

The following build commands failed:
	Check dependencies
(1 failure)

Build log here: https://dl.dropboxusercontent.com/u/5680827/cartlog.log

What version of Xcode are you using?

$ xcodebuild -version
Xcode 7.1
Build version 7B91b

Same here
Xcode 7.1
Build version 7B91b

Hmm. So now we get to play "what else could be different on our machines?".
Any other ideas? I'm still a bit of a carthage newbie.

Here is my verbose update:
$ carthage update --verbose
*** Fetching AFNetworking
*** Checking out AFNetworking at "3.0.0-beta.1"
*** Building scheme "AFNetworking OS X" in AFNetworking.xcworkspace
Build settings from command line:
    ONLY_ACTIVE_ARCH = NO

=== BUILD TARGET AFNetworking OS X OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies

Write auxiliary files
write-file /Users/kevin.harwood/Library/Developer/Xcode/DerivedData/AFNetworking-coqwcjehsnaffkazjhunczndijmt/Build/Intermediates/AFNetworking.build/all-product-headers.yaml

** BUILD SUCCEEDED **

*** Building scheme "AFNetworking tvOS" in AFNetworking.xcworkspace
Build settings from command line:
    BITCODE_GENERATION_MODE = bitcode
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = appletvos9.0

=== BUILD TARGET AFNetworking tvOS OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies

Write auxiliary files
write-file /Users/kevin.harwood/Library/Developer/Xcode/DerivedData/AFNetworking-coqwcjehsnaffkazjhunczndijmt/Build/Intermediates/AFNetworking.build/all-product-headers.yaml

** BUILD SUCCEEDED **

Build settings from command line:
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = appletvsimulator9.0

=== BUILD TARGET AFNetworking tvOS OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies

Write auxiliary files
write-file /Users/kevin.harwood/Library/Developer/Xcode/DerivedData/AFNetworking-coqwcjehsnaffkazjhunczndijmt/Build/Intermediates/AFNetworking.build/all-product-headers.yaml

** BUILD SUCCEEDED **

*** Building scheme "AFNetworking watchOS" in AFNetworking.xcworkspace
Build settings from command line:
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = watchsimulator2.0

=== BUILD TARGET AFNetworking watchOS OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies

Write auxiliary files
write-file /Users/kevin.harwood/Library/Developer/Xcode/DerivedData/AFNetworking-coqwcjehsnaffkazjhunczndijmt/Build/Intermediates/AFNetworking.build/all-product-headers.yaml

** BUILD SUCCEEDED **

Build settings from command line:
    BITCODE_GENERATION_MODE = bitcode
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = watchos2.0

=== BUILD TARGET AFNetworking watchOS OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies

Write auxiliary files
write-file /Users/kevin.harwood/Library/Developer/Xcode/DerivedData/AFNetworking-coqwcjehsnaffkazjhunczndijmt/Build/Intermediates/AFNetworking.build/all-product-headers.yaml

** BUILD SUCCEEDED **

*** Building scheme "AFNetworking iOS" in AFNetworking.xcworkspace
Build settings from command line:
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = iphonesimulator9.1

=== BUILD TARGET AFNetworking iOS OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies

Write auxiliary files
write-file /Users/kevin.harwood/Library/Developer/Xcode/DerivedData/AFNetworking-coqwcjehsnaffkazjhunczndijmt/Build/Intermediates/AFNetworking.build/all-product-headers.yaml

=== BUILD TARGET AFNetworking iOS Tests OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies

** BUILD SUCCEEDED **

Build settings from command line:
    BITCODE_GENERATION_MODE = bitcode
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = iphoneos9.1

=== BUILD TARGET AFNetworking iOS OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies

Write auxiliary files
write-file /Users/kevin.harwood/Library/Developer/Xcode/DerivedData/AFNetworking-coqwcjehsnaffkazjhunczndijmt/Build/Intermediates/AFNetworking.build/all-product-headers.yaml

=== BUILD TARGET AFNetworking iOS Tests OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies

** BUILD SUCCEEDED **

03:24:00 {master branch} ~/GIT/Xcode64Test $

@Dreddik would you be able to show the output of carthage build --verbose?

@kcharwood yes, but later today.

Last messages of verbose
*** Building scheme "AFNetworking tvOS" in AFNetworking.xcworkspace
Build settings from command line:
    BITCODE_GENERATION_MODE = bitcode
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = appletvos9.0

=== BUILD TARGET AFNetworking tvOS OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies

Write auxiliary files
write-file /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Intermediates/AFNetworking.build/all-product-headers.yaml

ProcessInfoPlistFile /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework/Info.plist Framework/Info.plist
    cd /Users/romantruba/Documents/projects/vk-admin/Carthage/Checkouts/AFNetworking
    export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/AppleTVOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/go/bin:/Users/romantruba/Downloads/infer-osx-v0.2.0/infer/infer/bin"
    builtin-infoPlistUtility /Users/romantruba/Documents/projects/vk-admin/Carthage/Checkouts/AFNetworking/Framework/Info.plist -expandbuildsettings -format binary -platform appletvos -o /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework/Info.plist

GenerateDSYMFile /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework.dSYM /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework/AFNetworking
    cd /Users/romantruba/Documents/projects/vk-admin/Carthage/Checkouts/AFNetworking
    export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/AppleTVOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/go/bin:/Users/romantruba/Downloads/infer-osx-v0.2.0/infer/infer/bin"
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/dsymutil /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework/AFNetworking -o /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework.dSYM

Touch /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework
    cd /Users/romantruba/Documents/projects/vk-admin/Carthage/Checkouts/AFNetworking
    export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/AppleTVOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/go/bin:/Users/romantruba/Downloads/infer-osx-v0.2.0/infer/infer/bin"
    /usr/bin/touch -c /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework

CodeSign /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework
    cd /Users/romantruba/Documents/projects/vk-admin/Carthage/Checkouts/AFNetworking
    export CODESIGN_ALLOCATE=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/codesign_allocate
    export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/AppleTVOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/go/bin:/Users/romantruba/Downloads/infer-osx-v0.2.0/infer/infer/bin"

Signing Identity:     "iPhone Developer: Роман Труба (9A9C975X66)"

    /usr/bin/codesign --force --sign 775E55D5ACD2895B2DF67D5982FBEE31CE414F21 --timestamp=none /Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework
/Users/romantruba/Library/Developer/Xcode/DerivedData/AFNetworking-ahxskezyvfsmjnefodqezeejsoik/Build/Products/Release-appletvos/AFNetworking.framework: replacing existing signature

** BUILD SUCCEEDED **

Build settings from command line:
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = appletvsimulator9.0

=== BUILD TARGET AFNetworking tvOS OF PROJECT AFNetworking WITH CONFIGURATION Release ===

Check dependencies
target 'AFNetworking tvOS' has bitcode disabled (ENABLE_BITCODE = NO), but it is required for the 'appletvos' platform

** BUILD FAILED **

The following build commands failed:
	Check dependencies
(1 failure)
A shell task failed with exit code 65:
** BUILD FAILED **

The following build commands failed:
	Check dependencies
(1 failure)

Hmm so the simulator build is failing for you, while you can clearly see it succeed for me above.
Which carthage command are you using? I'm doing carthage update

carthage update --verbose

@cnoon any ideas here?

I downloaded the 3.0.0 branch code, and I don't see ENABLE_BITCODE flag in tvOS target. Maybe we are facing a different default settings behavior?

Bitcode is enabled using the User-Defined Settings, which was advised here

@NachoSoto Wanted to tag you here. We're prepping AFNetworking to support bitcode, and I'm not sure what else to do about this issue. I can't repro it, and I'm not sure what else to ask @Dreddik for. Any ideas?

I'm testing this myself now. In the mean time, @dreddik can you verify that you have an Apple TV simulator? I've had issues with Xcode failing to build targeting the tvOS simulator SDK when I accidentally removed it (you can manually create one in Window -> Devices).

@NachoSoto I'll try later today

Could you also try to clear Carthage's cache?
rm -rf ~/Library/Caches/org.carthage.CarthageKit

Lastly, I'd recommend that you re-generate your (probably wildcard) provisioning profile. It's a long shot, but certain things are encoded in them so I wouldn't be surprised if the issue is just an old provisioning profile. One may think that given the error message this would have nothing to do with it, but I've seen weirder things :P

Much appreciated @NachoSoto. Hopefully we'll track this one down here.

My pleasure!
Insert sparky comment about Apple here

Thanks for the help @NachoSoto! I dug through this here @kcharwood and I can't think of any other project changes that would help. Seems like you've covered all the cases we've had to cover in Alamofire. 👍🏼

@Dreddik Did you get a chance to try any of the feedback above?

@kcharwood I wasn't able to try last two days, but I check today. I almost sure problem is in tvos simulator missing

@Dreddik Wanted to circle back on this. Let me know if we can close this one out.
:beers:

I was having the same issue and following @NachoSoto's suggestion of adding a Apple TV simulator to Xcode (mine didn't have one) did the trick.

TV iOS Simulator did the trick.

Thanks everyone!

@NachoSoto Thank you~
Clear Carthage's cache and derived data is right.

carthage update --platform iOS
target for Specific platform

dfgdfgdfg

Hi, I am having in creating build issue due to AFNetworking. I have many times removed and reinstall AFNetworking to sort out issue but not understanding what is the problem, cleared every time derived data as well. Can someone help me out in this ?


Alternative approach via stubfiles

This is not an issue. I just wanted to crosslink an approach with the same goal that might be of help for some use cases (and eventually save us all from doing work twice).
TypeLogger from pytypes can observe types at runtime and then write a PEP-484 stubfile from that information.
All versions of typing are supported and it runs on Python 2.7, 3.3, 3.4, 3.5, 3.6, PyPy and Jython.
See https://github.com/Stewori/pytypes#usage-example-with-profiler.
The approach differs from pyannotate in that it does not write into existing code, but always creates an external PEP-484 conform stubfile that should be suitable for use with mypy (pytypes itself can use it for runtime typechecking).
A nice goody is that it can take existing type annotations into account and extend them by information acquired from runtime observations.
The tool supports OOP -- classes, inner classes, static methods, class methods and properties -- and automatically writes a proper import section for the types in use.
Disclaimer: It is not yet perfect and still in beta. Please file issues as they come up. Help is welcome!

Thanks for the link! We should combine the best of our tools.


feat: provide param to control whether to build FTS index with positions

The positions can be very large, it's a waste for users who don't need phrase query, so provide a param to build the index without positions, don't build FTS index with positions by default

Codecov Report
Attention: Patch coverage is 54.16667% with 44 lines in your changes missing coverage. Please review.

Project coverage is 78.55%. Comparing base (9d335f6) to head (a0edb57).

Files
Patch %
Lines

rust/lance-index/src/scalar/inverted/builder.rs
67.21%
15 Missing and 5 partials :warning:

rust/lance-index/src/scalar.rs
28.57%
10 Missing :warning:

rust/lance/src/index.rs
0.00%
8 Missing :warning:

rust/lance-index/src/scalar/inverted/index.rs
70.00%
3 Missing :warning:

rust/lance-index/src/scalar/inverted.rs
0.00%
2 Missing :warning:

rust/lance/src/index/scalar.rs
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2795      +/-   ##
==========================================
- Coverage   78.57%   78.55%   -0.02%
==========================================
  Files         227      227
  Lines       68508    68553      +45
  Branches    68508    68553      +45
==========================================
+ Hits        53832    53855      +23
- Misses      11606    11639      +33
+ Partials     3070     3059      -11

Flag
Coverage Δ

unittests
78.55% <54.16%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Space Age compatibility

Is mod going to be updated for SA?

Absolutely but I've been very busy with real life. I got SA yesterday from a friend and will likely spin it up this weekend.

Let me know if I can help

Fixed right?

yep. played yesterday, was fine. will get back if smth breaks

why didn't you want major version to match factorio major version?


Add undo / redo buttons

Undo and redo currently only work for edits made directly into the textarea, but dendriform has its own history stack so should use that.

Done in 1.3.0


popover doesn't close on some element click outside

when the popover is open and you click an element outside the popover that opens a modal window (might be with all click events) the popover does not close

The event might be Intercepted, I'll check that

I've also encountered that

This is browser behaviour , I can't fixe it.


Sync with upstream Prometheus

Gets https://github.com/prometheus/prometheus/pull/11992

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 13 committers have signed the CLA.:white_check_mark: bboreham:white_check_mark: beorn7:white_check_mark: codesome:white_check_mark: trevorwhitney:white_check_mark: leizor:white_check_mark: colega:x: SuperQ:x: pbudner:x: roidelapluie:x: g3offrey:x: mabhi:x: aldernero:x: bwplotkaYou have signed the CLA already but the status is still pending? Let us recheck it.

The lint fail (which failed on building tsdb tests) showed that the unit tests are not in sync with upstream. It might mostly be the OOO tests since it was first written here and then ported. Possibly something to verify in the future but not critical.

@codesome What's about this failing test?
--- FAIL: TestChunkDiskMapper_WriteUnsupportedChunk_Chunk_IterateChunks (0.01s)
    head_chunks.go:894:
        	Error Trace:	/home/runner/work/mimir-prometheus/mimir-prometheus/tsdb/chunks/head_chunks_test.go:201
        	            				/home/runner/work/mimir-prometheus/mimir-prometheus/tsdb/chunks/head_chunks.go:894
        	            				/home/runner/work/mimir-prometheus/mimir-prometheus/tsdb/chunks/head_chunks_test.go:194
        	Error:      	Not equal:
        	            	expected: 0xc1
        	            	actual  : 0x41
        	Test:       	TestChunkDiskMapper_WriteUnsupportedChunk_Chunk_IterateChunks

Please hold on before merging this PR, cause I would like to merge it after https://github.com/grafana/mimir-prometheus/pull/458.

Should be fixed now. UnsupportedMask was 0b11000000, while the out-of-order was already using the first bit for out-of-order. Since it is only used in tests, I changed UnsupportedMask to 0b01000000. Now ChunkDiskMapper treats the last 7 bits as the chunk encoding and the first bit for OOO information.

Ok, merging with merge commit 🚀


DCOS 21173: Update status bar styles

We have some old legacy styles from the dark UI in the status bars. This PR removes the dark line on status bars and removes the CSS that was making the bar smaller in headers. Making these more inline with our UI kit vision.
Before

After

run integration tests


The camera follows the player

Player following camera behaviour. This is the perfect refefence video.

Right now we have 1-1 camera-target following.

Now we have a focus rectangle, to be tweaked in gameplay test.
Closed in f72aa1b9043791cf6cab5a31c48cba2af7f88c56


x/vuln: govulncheck integration with go (mod) and GOPROXY

Please consider merging govulncheck cmd/api into go audit (go mod audit?) to avoid separate cmd and allow audit requests to be passed via GOPROXY. This would allow one to use internal proxies like athens for handling dependency audits not just module caching/fetching.
Such solution is now possible in JS world with npm audit + Verdaccio + npm_config_registry env variable.

@golang/vulndb

The intention was to eventually add a go audit subcommand, but first we needed to experiment with govulncheck and make sure it pulled its weight, and then think about what other features an audit command might want to be able to have, to make sure we allow for them to be added in the future in it's design.
This is unlikely to happen soon.
In the mean time, you can use the -db flag to govulncheck to point it at a vulndb proxy (or an offline copy)

Thank you for pointing out the offline copy workaround.
In the future would be nice to have env var to specify vulndb address if no -db flag is present. Maybe same GOPROXY for go mod and go audit if possible.


Behavior of met.getAnnotationString()

The code at
https://github.com/Porthmeus/MeMoMe/blob/7aaf56576e9ccd43dca96ba8dc7702b350f44035/src/parseMetaboliteInfoFromSBML.py#L36-L42
specifically, line 40. What is that supposed to do?
Because for whatever reason the function met.getAnnitationString() returns a list with an empty string  i.e. [""] when no annotation source is present. Thus we run into len(urls) >0. I suppose that is not the wanted behavior.
To reproduce load M2_bacter.. and set a breakpoint at L42 in the aforementioned file or look the content of urls for the first metab.

Probably put a simple if url != "" somewhere in the code to circumvent unwanted behavior. However, we want to extract all metabolites in that list, which are also in the model. Thus it makes sense to keep them in the list, even if there is no annotation for in the model. It would be probably better to replace "" with None-type though.


GPT4 rate limit

Hi, I am trying to evaluate our model output using alpaca_eval.
Here is the command:
export OPENAI_API_KEY="sk-xxxxxx"
alpaca_eval --model_outputs 'output/alpaca_eval/outputs.json'

Problem: While running, there are always "Rate limit reached" error.
NFO:openai:error_code=rate_limit_exceeded error_message='Rate limit reached for default-gpt-4 in organization org-0Ibh47ogWcbeM3DJsyr3EC29 on tokens per min. Limit: 40000 / min. Please try again in 1ms. Contact us through our help center at help.openai.com if you continue to have issues.' error_param=None error_type=tokens message='OpenAI API error received' stream_error=False
WARNING:root:OpenAIError: Rate limit reached for default-gpt-4 in organization org-0Ibh47ogWcbeM3DJsyr3EC29 on tokens per min. Limit: 40000 / min. Please try again in 1ms. Contact us through our help center at help.openai.com if you continue to have issues..
WARNING:root:Hit request rate limit; retrying...

Question:

How could I control the GPT4 access rate (e.g. add some delay in the code)?
After evaluation, I got n_total = 800, does this mean that there are 5 tests failed? Are these failures related to GPT4 rate limit error?

Great questions!

Concerning the rate limit, there are 3 ways to avoid/mitigate it.

Decreasing number of processes: by default we use 4 concurrent processes for querying GPT4. This will hit the rate limit faster. If that's an issue you can change it in the evaluators configs. e.g. add num_procs: 2 in the completion kwargs
Increasing sleep time: we are already adding a 2 seconds sleep time here. If this is not sufficient for you, you can change it in the evaluators configs. e.g. add sleep_time: 10 in the completion kwargs
Using multiple API keys: in case you have multiple API keys you can set them separated by commas OPENAI_API_KEYS=key1,key2 and we will switch between them when you get rate limited.

When you hit a rate limit we will simply retry (as seen in the warning) so that's not the issue. If there are missing evaluation results it typically means that the annotations could not be parsed. we also raise a warning for that so you see the reason in your terminal!

Feel free to reopen if you have further questions

For future reference, here's the way to deal with multiple keys now: https://github.com/tatsu-lab/alpaca_eval/tree/main/client_configs
one can also use Azure


Google as Service Provider - Given admin credentials in the Basic Auth, redirects to a specific admin gmail account

Steps to re-create
Make sure Google domain, wso2support.com, is SSO enabled and configuration done.

Create a user in the domain - wso2support.com<EMAIL_ADDRESS>Configure Google as the SP and use Basic Authentication.
Navigate to mail.google.com
In the Gmail screen, provide the email address you created<EMAIL_ADDRESS>Now user would be navigated to Basic Auth.
Provide admin/admin as the credentials.

Expected: It should result an error.
Actual: User is navigated to an admin email account which owns under a specific name.
Please refer the email 'Google as Service Provider - Given admin credentials in the Basic Auth, redirects to a specific admin gmail account'

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


Relax hackney dependency

Currently the version of hackney is locked at ~> 1.12.1. The most recent version of hackney is 1.13 and I don't believe there are any conflicts. Could we bump to the most recent version?

Ping

@paulcsmith Can we get a release for this?

New release is up 1.1.0!


Switch LB servers to new Cloudscale flavor

Checklist

[x] Keep pull requests small so they can be easily reviewed.
[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog

@simu Do you think we should mark those changes as breaking?

@simu Do you think we should mark those changes as breaking?

I don't think that's necessary, since the cloudscale.ch Terraform provider will refuse to change a VMs flavor unless allow_stopping_for_update is set to true.


Grouping and Reorganisation for Currency Input Widget

Based on the following Figma File and Notion doc, Group the properties of the Currency Input widget into Content & Style Tabs and re-organise the property sections.
Figma:
https://www.figma.com/file/hlOcM5LasxcRqEwHPXe5lm/UI-|-Content-Property-Pane?node-id=3751%3A69510
Property Library:
https://www.notion.so/appsmith/853275adc3524c0390f7599b66f74859?v=8004de7cc9b74523a496388ad812ebc2

closing in favour of #15583


Improve homescreen backlighting to depend on external light

Instead of relying on what power remains in the battery, rely instead on the external lighting to adapt the brightness of the screen.
Note that this might need a bit more fine-tuning.

Ideally the code for reading the light sensor should be put into a function in onboard.py, similar to the battery voltage sensor.

@thinkl33t Thanks, I was using what was already there, but I've now changed it to read what already exists: onboard.get_light()

@thinkl33t Thanks, updated!


Migrate integration cluster to a newer k8s version

This will also help debugginng the current kronos connection errors.
I have asked cmsweb on the proper way to proceed, I'll report here any update.

https://its.cern.ch/jira/browse/CMSKUBERNETES-228


[FBX] [document parser, Cinema4D] Crash on importing version 7100 file due to deconstruction of tokens

**Godot version: Godot 3.2 beta 2
**OS/device including version: Microsoft Windows [Ver 10.0.17763.864]
Issue description:
massive errors when import fbx

Steps to reproduce:
drag this fbx below to Godot 3.2 editor
Minimal reproduction project:
CMotion.zip

CC @RevoluPowered @fire

FBX is being improved here https://github.com/godotengine/godot/pull/38966 .

Yeah so we are rewriting the importer, I'll take a note that your file is broken and test it while I work on the importer

Confirmed this causes a crash on b38f7af4fd a79293e0fc

Again I need to know how the file was made, where it was exported from and you need to enable verbose debugging with -v on output.

Notes:

File version 7100:  2018 FBX SDK
Crash is destruction of the tokens object.reset()

FBX File version 7100, and 7200 are now depreciated and should be upgraded to 7700 using the original modelling application.

As for the leak this will still be resolved as it will happen even if the file is not ingested.

Can you please open the file in the original application and upgrade the file and try again?

I have allowed for 7200 files again. I will see if this is now fixed with the latest PR.

File will not load correctly due to bugs in other places:

memory leak is fixed
version 7100 seems to import

Manual intervention required:

clear skins & skeleton
orient X - 90 degrees.

Result:

This is probably fixed with the new FBX importer using FBX2glTF.
You can test it in Godot 4.0 alpha 6: https://godotengine.org/article/dev-snapshot-godot-4-0-alpha-6
This new importer might also be backported for the 3.x branch eventually.
If you still find issues with these models using the new importer, we suggest opening a new issue with details about the problems in Godot 4.0 alpha 6 or later.


ci: Clean coverage info before running

Codecov Report

Merging #53 (14017a1) into main (1659eeb) will increase coverage by 7.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   85.55%   92.75%   +7.20%
==========================================
  Files          16       16
  Lines        1571     1463     -108
==========================================
+ Hits         1344     1357      +13
+ Misses        227      106     -121

Impacted Files
Coverage Δ

uguid/src/lib.rs
98.27% <0.00%> (+53.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1659eeb...14017a1. Read the comment docs.


Fix bug when changing mask and model on same digest

Fix issue #1

Well, I don't know why af9a07f failed, I just generated the dist files.
I found out that the validity also was not set. So I did another commit to fix it.

Thanks !


AKSv2 provisioning does not support the use of Kubenet with existing VNET

SURE-5140

Setup

Rancher version: 2.7.2
Browser type & version:

Describe the bug

The customer needs to provision AKS clusters in Rancher that are configured with Kubenet network option using an existing VNET subnet. This was supported in in earlier version of Rancher (using the AKS v1 provider) and is also officially supported in the Azure CLI.
https://docs.microsoft.com/en-us/azure/aks/configure-kubenet
Since Rancher 2.6.x this configuration can no longer be set: When selecting the "Kubenet" option in the AKS v2 provisioning UI there is no dropdown field to select an existing VNET. Instead, Rancher will configure a new VNET for each cluster.
This seems like a breaking change between AKS v1 and AKS v2 provisioning. It also blocks the customer who has a requirement of provisioning AKS clusters via the Rancher UI.
See https://github.com/rancher/rancher/issues/38560

Looks like we need both https://github.com/rancher/aks-operator/pull/163 and https://github.com/rancher/aks-operator/pull/158 merged before starting (see https://github.com/rancher/rancher/issues/38560#issuecomment-1493832862)

Looks like we need both rancher/aks-operator#163 and rancher/aks-operator#158 merged before starting (see rancher/rancher#38560 (comment))

Both PR https://github.com/rancher/aks-operator/pull/189 and https://github.com/rancher/aks-operator/pull/158 were merged

Q3 is the plan per PM.

We need clarification on how this is intended to work and on the differences between v1 and v2, in addition to how we fetch the list of vnet.

@kkaempf is there anything written up to clarify what's different between the v1 & v2 versions?
Looks like the milestone was taken off the related backend issue so need to confirm milestone.

ping @mjura 👆🏻

Based on concerns that we're diverging from the Azure setup, more planning would be required so this looks more like a Q4 issue now.
@kkaempf and @mjura keep us in the loop based on activity here and then the related backend ticket(s).

Related backend no longer has a milestone but SURE-5140 still points at Q3. Marked as blocked for now though again, this looks more like Q4.

We would like to change UI and kubenet in this same way as azurecni plus add new option which is called OutboundType with list LoadBalancer (default) and UserDefined
So for kubenet it is:

and it should looks like similar to Azure CNI

Included in AKS ember->vue port https://github.com/rancher/dashboard/pull/9669

Blocked on https://github.com/rancher/dashboard/issues/10431

https://github.com/rancher/rancher/issues/38560#issuecomment-2220440031

@valaparthvi this looks like a duplicate of an issue @cpinjani reported recently - https://github.com/rancher/aks-operator/issues/574#issuecomment-2205326165 it was determined to be working as intended. The virtualNetwork field is null which the ui is correctly reflecting

@valaparthvi this looks like a duplicate of an issue @cpinjani reported recently - https://github.com/rancher/aks-operator/issues/574#issuecomment-2205326165 it was determined to be working as intended. The virtualNetwork field is null which the ui is correctly reflecting

In that case, I will close the issue. Thank you for clearing that up.


docs: unify GH Actions interpretation tips into one file

Issue #338
Folds If-CI-checks-fail-on-your-PR.md into Interpreting-GitHubActions-Results.md

Hi @gutoslv, I've actually made some more sweeping changes to these files recently -- see https://github.com/oppia/oppia-web-developer-docs/pull/406 . Since the changes in this PR will become obsolete with those, I'll close this one for now, if that's OK. (Sorry about that, I didn't realize there was an issue open for this already!)

Hey @seanlip that's ok! I'll leave on comment on the original issue mentioning that, so other folks don't pick up the task as well, since it's labeled as a good first issue. Thanks for letting me know!


How to traslate name of the days in other language(italian in my case)

Version of flutter_calendar_carousel
Expected behavior
Actual behavior
flutter doctor result (run flutter doctor in terminal)
Steps to reproduce the behavior

So my main problem is to change days name beacuse i'm making an app for italian people so I must nedd to translate names in [Lun Mar Mer Gio Ven Sab Dom]. I hope you can help me.
This calendar is amazing!