Why bedorck seed searching  slow

@crackedMagnet I am looking for 3 structures within a 60-block radius, but with a maximum speed value of around 100,000-110,000.  seeds/sec Please, you may utilize all the computer gpu cores to potentially expedite the process.

100,000 seeds per second is actually not to bad.  Given that its running at that rate it's likely very few are actually getting to the biome check, which means most (if not all) of seeds don't even attempt to place structures that meet your criteria.
What is your criteria?  It could be an impossible set of criteria.
As for using gpu cores... I don't have the expertise to do this from java.

100,000 seeds per second is actually not to bad. Given that its running at that rate it's likely very few are actually getting to the biome check, which means most (if not all) of seeds don't even attempt to place structures that meet your criteria.
What is your criteria? It could be an impossible set of criteria.
As for using gpu cores... I don't have the expertise to do this from java.

Mansion 100 block Villager 90 block Pillager Outpost 64 block

If its java edition you are finding the seed for I can see why you have a problem. Outposts can't generate within 10 chunks of a village.  I'd suggest increasing the outpost range to 200 blocks.

If its java edition you are finding the seed for I can see why you have a problem. Outposts can't generate within 10 chunks of a village. I'd suggest increasing the outpost range to 200 blocks.

no im finding for bedrock

Just to confirm, you're using "/findseed next_bedrock" ?  and the bedrock structures in the criteria?

Just to confirm, you're using "/findseed next_bedrock" ? and the bedrock structures in the criteria?

yes

And if you drop the outpost criteria it finds seeds?

And if you drop the outpost criteria it finds seeds?

I haven't tried this but I'm sure I'm looking for possible criteria.

I guess what I'm trying to do is identify the problematic bit of criteria.  because if it still doesn't find seeds after removing the outpost criteria it means there is a problem with the village and mansion combo.  I would have thought the village and mansion should have been fine though and would have only taken a few minutes on their own to find.

I guess what I'm trying to do is identify the problematic bit of criteria. because if it still doesn't find seeds after removing the outpost criteria it means there is a problem with the village and mansion combo. I would have thought the village and mansion should have been fine though and would have only taken a few minutes on their own to find.

I waited 1 hour for this and I added my old criteria: mansion 100 blocks village 80 pillager outpost 80 blocks but it still couldn't find it when I first tried to find it, it found it in 10-15 minutes.

Can you do "/findseed criteria list" and copy/paste it?  If its worked previously that suggests there is a mistake in the criteria.

but i used /findseed criteria remove structure 0 and 1 still there is no seed.

Wait, you ran a search with no criteria and it still could find a seed?
And there is no biome criteria?

When you get back to looking for seeds, paste the criteria here and I'll see why its not working.

When you get back to looking for seeds, paste the criteria here and I'll see why its not working.

Actually, logically, I want the pillager outpost village and the mansion to be created in the same place.

When you get back to looking for seeds, paste the criteria here and I'll see why its not working.

Actually, logically, I want the pillager outpost village and the mansion to be created in the same place.

and i think bedrock is not impossible for this

It's possible, but because outposts don't generate in dark Forrests the mansion has to be right on the edge of the biome and rotated into the outpost.  Searches like that can take a very long time.

It's possible, but because outposts don't generate in dark Forrests the mansion has to be right on the edge of the biome and rotated into the outpost. Searches like that can take a very long time.

but how you find pillager outpost mansion village stronghold treasure monument in same place????

It's possible, but because outposts don't generate in dark Forrests the mansion has to be right on the edge of the biome and rotated into the outpost. Searches like that can take a very long time.

do you have discord?

It's possible, but because outposts don't generate in dark Forrests the mansion has to be right on the edge of the biome and rotated into the outpost. Searches like that can take a very long time.

but how you find pillager outpost mansion village stronghold treasure monument in same place????

This generating in -20000 weirdness 20000


[Snyk] Upgrade tsd from 0.28.1 to 0.30.4

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade tsd from 0.28.1 to 0.30.4.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 6 versions ahead of your current version.
The recommended version was released a month ago, on 2024-01-17.

Release notes

Package name: tsd

0.30.4 - 2024-01-17
Add decorator-related diagnostic codes to expectError (#207)  8eeab3d

v0.30.3...v0.30.4

0.30.3 - 2024-01-03
Add code 2561 to known errors (#205)  6896a11

v0.30.2...v0.30.3

0.30.2 - 2024-01-02
Actually add ts2353 to known errors (#204)  9b8dc9b

v0.30.1...v0.30.2

0.30.1 - 2023-12-26
Add ts2353 to known errors (#202)  f75a8b4

v0.30.0...v0.30.1

0.30.0 - 2023-12-17
Upgrade to TypeScript 5.3  5859b92

v0.29.0...v0.30.0

0.29.0 - 2023-08-31
Upgrade to TypeScript 5.2  701e314

v0.28.1...v0.29.0

0.28.1 - 2023-03-28
Fix error messages when tsd fails (#189)  c785d9c

v0.28.0...v0.28.1

    from tsd GitHub release notes

Commit messages

Package name: tsd

332a992 0.30.4
8eeab3d Add decorator-related diagnostic codes to `expectError` (#207)
bb28db1 0.30.3
6896a11 Add code 2561 to known errors (#205)
0d3756f 0.30.2
9b8dc9b Actually add ts2353 to known errors (#204)
34dfd0f 0.30.1
f75a8b4 Add ts2353 to known errors (#202)
c412a13 0.30.0
5859b92 Upgrade to TypeScript 5.3
50dfdc2 Update repository field
256adde Update badge and test Node.js 20
28e2ad0 0.29.0
701e314 Upgrade to TypeScript 5.2

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ed9e7df) 89.54% compared to head (22a5445) 89.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   89.54%   89.21%   -0.33%
==========================================
  Files          10       10
  Lines         306      306
==========================================
- Hits          274      273       -1
- Misses         32       33       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Configurable framerate and diff-rendering

          @leostera This is awesome sauce! I think the situation has improved for me but not entirely.

I still see an issue from #34 but it happens not so frequently to me. Previously, I had to restart my app 7 times to avoid hanging. Now I need to restart it 7 times to observe hanging, which is an improvement!
At this point, I started thinking that my view function may generate lots of garbage, and the GC struggles to process everything at 60 FPS (default).
I wonder if Mint Tea can add something like has_diff : 'model -> 'model -> bool to t
https://github.com/leostera/minttea/blob/3e386136d315c60c16ea39b94789fbb7761003f5/minttea/app.ml#L1-L5
So that it can avoid calling view entirely if the model didn't change unlike the current implementation where we compare already rendered buffer:
https://github.com/leostera/minttea/blob/3e386136d315c60c16ea39b94789fbb7761003f5/minttea/renderer.ml#L26

Alternatively, exposing the fps setting from start may help app developers reduce their resource usage (I don't really need 60 fps)
https://github.com/leostera/minttea/blob/3e386136d315c60c16ea39b94789fbb7761003f5/minttea/minttea.ml#L9-L26
Originally posted by @chshersh in https://github.com/leostera/minttea/issues/38#issuecomment-2021312464

@chshersh these are good ideas! super open to PRs to do a little diffing here and avoid unnecessary renders.
Also like the idea of passing in config for how Minttea should behave, and probably want it to be a little config record since I can imagine in the future apps that do not take user input (just render things out).
let () =
  let config = Minttea.config ~fps:10 () in
  Minttea.start ~config ~initial_model app

This would let us add more options with sensible defaults while being backwards compatible.

@leostera Agree with the idea of having a config 👍🏻
I can try experimenting with these ideas in my Mint Tea fork to see if they actually work for me (before contributing something that doesn't really fix the problem).
But it may take a while 😅 So don't wait for me!


Extra menu draw

Doing this:
Menu -> Rest all -> No

results in a double draw of the "Reset all" menu before going back to the top menu.

After analysis, the problem is due to a bad design for menus.  Rethink the module.

Rethinking the module.


Project Webhook fails on Gitea1.11.4

Gitea version (or commit ref):1.11.4
Git version:2.24.1
Drone version:1.6
Operating system:Debian 4.19.98-1
Log gist:
docker logs drone --tail=20
"error":"client is not authorized","event":"push","level":"warning","msg":"trigger: cannot find yaml","ref":"refs/heads/master",

Description
Today I don’t know why one of the project push changes did not trigger the deployment.
Screenshots

用管理员账号在drone对应的项目settings里面关闭然后重启项目，对应的gitea仓库里面的web钩子就更新了~目前只找到这个方法~

There will be no fix for Gitea 1.11.x even if there is an error. You may update your installation.


Updates for Minecraft release 1.21.50

AUTOMATED PR
Updating minecraft-editor-extension-starter-kit for Minecraft release 1.21.50

Not checking in a stable release, editor uses a beta API.


Minor refactor in ConfigMapPropertySourceLocator

@ryanjbaxter though these PRs (3 of them) might seem a bit "dumb", the point is that in this way I am trying to expand my total understanding in the implementation of config maps in this project. Once I get a full understanding, I would like to close and contribute to some open defects. If you have the time, please take a look. Thank you.


Workspaces filePath reproduction test cases

For demonstration purposes only. Not to be merged.
This change introduces and recreates the reproduction test cases for incorrect test file path when using Ember JS with workspaces. Given a file path such as:
packages/nonstandard-workspaces-app/tests/unit/with-hooks-test.js,
packages/nonstandard-workspaces-app/nonstandard-workspaces-app/tests/unit/with-hooks-workspace-test.js
is output instead. The workspace directory (e.g., nonstandard-workspaces-app) is duplicated by Broccoli/Babel.
yarn test:scenarios

Built project successfully. Stored in \"/var/folders/c5/w1hrxnv55sx_303npp2r5q_h000510/T/tests-dist-2022431-51162-265117.aon31h\".
    not ok 1 Chrome 102.0 - [25 ms] - Acceptance | with-hooks-test: example
        ---
            actual: >
                packages/nonstandard-workspaces-app/nonstandard-workspaces-app/tests/unit/with-hooks-workspace-test.js
            expected: >
                packages/nonstandard-workspaces-app/tests/unit/with-hooks-workspace-test.js
            stack: >
                    at Object.<anonymous> (http://localhost:7357/assets/tests.js:21:14)
            negative: >
                false
            browser log: |
        ...
    not ok 2 Chrome 102.0 - [8 ms] - Acceptance | with-multiple-modules-test: example
        ---
            actual: >
                packages/nonstandard-workspaces-app/nonstandard-workspaces-app/tests/unit/with-multiple-modules-workspace-test.js
            expected: >
                packages/nonstandard-workspaces-app/tests/unit/with-multiple-modules-workspace-test.js
            stack: >
                    at Object.<anonymous> (http://localhost:7357/assets/tests.js:36:14)
            negative: >
                false
            browser log: |
        ...
    not ok 3 Chrome 102.0 - [6 ms] - Acceptance | with-multiple-modules-test 2: example
        ---
            actual: >
                packages/nonstandard-workspaces-app/nonstandard-workspaces-app/tests/unit/with-multiple-modules-workspace-test.js
            expected: >
                packages/nonstandard-workspaces-app/tests/unit/with-multiple-modules-workspace-test.js
            stack: >
                    at Object.<anonymous> (http://localhost:7357/assets/tests.js:47:14)
            negative: >
                false
            browser log: |
        ...
    not ok 4 Chrome 102.0 - [6 ms] - Acceptance | without-hooks-test: example
        ---
            actual: >
                packages/nonstandard-workspaces-app/nonstandard-workspaces-app/tests/unit/without-hooks-workspace-test.js
            expected: >
                packages/nonstandard-workspaces-app/tests/unit/without-hooks-workspace-test.js
            stack: >
                    at Object.<anonymous> (http://localhost:7357/assets/tests.js:62:14)
            negative: >
                false
            browser log: |
        ...
    ok 5 Chrome 102.0 - [1 ms] - ember-qunit: Ember.onerror validation: Ember.onerror is functioning properly·
    1..5
    # tests 5
    # pass  1
    # skip  0
    # todo  0
    # fail  4
    Testem finished with non-zero exit code. Tests failed.

The issue was fixed via PR #165.


How to convert to EKRule?

How can I add the recurrence rule generated with this library to an EKEvent?

since i stumbled upon this looking for the same as you did, maybe have a look at this:
https://github.com/GargoyleSoft/RFC5545


Download Offline Blocks Editor and Download All OpModes return "Internal Error"

Updated to 10.1 and connected to the Control Hub over Wifi "Download Offline Blocks Editor" and "Download All OpModes" return "Internal Error" now.

I tested this on 10.1 and both operations successfully resulted in a downloaded zip file.
Please provide the following to help us root cause your problem.

A screenshot of the error.
Any errors in the browser's console log.
The robot controller logs, which may be obtained by going to the Manage page and clicking on the Download Logs button.

robotControllerLog.txt

The robot controller logs show a possible problem with a file named, "Posssible new auto.blk".
If you use the REV Hardware Client to downgrade to 10.0 do you still see this problem?

Downgraded to 10.0 and the issue persists. Deleted the OpMode named "Posssible new auto" thinking that would resolve the issue but that didn't work either.

Can you attempt to reproduce again after deleting the "Possible new auto" and send a new set of robot controller logs?
I'd like to see if the exception in the logs related to that blocks program is now gone or not.  Ideally, you'd reproduce and immediately grab the logs so that when searching through them I can focus on a smaller period of time.

robotControllerLog(3).txt
Attached log after deleting "Posssible new auto".

I'm curious if this might be a browser issue. I see you're using Firefox, does this also happen with chrome?
This is likely going to require you making a full backup of your control hub (using the REV Hardware Client) and putting the backup file onto a google drive for us to access. This will allow us to hopefully replicate your problem - this really sounds like some kind of file naming issue that is silently killing the task on the backend (likely an internal file like a config file or something) but the backup will hopefully tell us for certain.

I tried Chrome and the Rev Hardware Client as well. Rev Hardware Client opens the file save dialog like it's going to work but it doesn't save anything.
Control Hub 21536-RC_9-22-2024-<IP_ADDRESS>4.revbkp.zip

I'm somewhat confused?  You said, "Rev Hardware Client opens the file save dialog like it's going to work but it doesn't save anything.", but the zip file you attached is 8mb and appears to contain a dozen or so blocks opmodes.

Edited previous comment so it's clearer.

Edited previous comment so it's clearer.

Oh that makes sense.  The REV Hardware Client is going to use the same HTTP endpoint as the Program and Manage page for the Download operations.  It's the Control Hub that's returning HTTP 500, so any client will encounter that failure.  The REV Hardware Client should however, not fail silently.
It does appear however that the backup feature of the REV Hardware Client does not use the HTTP route as it succeeded.

The control hub backup was very helpful.
The problem is that parsing of 'Posssible new auto.blk' is throwing an exception.   And if an exception is thrown it aborts the entire process.
Your file looks like this.  As an aside, I have no idea how you got the file into this state.  I was not able to do so using the browser based Blocks editor alone.
<xml xmlns="https://developers.google.com/blockly/xml"/>
<?xml version='1.0' encoding='UTF-8' standalone='yes' ?>
<Extra>
<OpModeMeta flavor="TELEOP" group="" autoTransition="" />
<Enabled value="true" />
</Extra>

Apparently the Control Hub parser is not tolerant of the shortcut trailing slash in the xml element.  Modifying the file so that it looks like this results in a successful parse.
<xml xmlns="https://developers.google.com/blockly/xml">
</xml>
<?xml version='1.0' encoding='UTF-8' standalone='yes' ?>
<Extra>
<OpModeMeta flavor="TELEOP" group="" autoTransition="" />
<Enabled value="true" />
</Extra>

Note I removed the trailing slash in the opening xml element and added the formal end tag for that element.
The only way that I know, at present, how to fix this is to use adb to remove the offending file.  The referenced website describes how to obtain it if you don't already have it (it is installed along with Android Studio if you have a laptop with Android Studio already installed).
Using GitBash on Windows with adb, the following sequence of commands will delete the offending Blocks file.
adb shell
cd /sdcard/FIRST/blocks
rm Posssible\ new\ auto.blk
rm Posssible\ new\ auto.js

Ctrl-c will exit out of adb shell when finished.

I agree with everything Craig said, but I think the more likely scenario is that perhaps you used an external xml file editor (the edit that caused this issue is a common artifact with visual studio's auto complete feature) and uploaded the file via the Windows File Explorer (or a similar tool that uses the USB file storage protocol). ADB is a handy tool but not necessary.

A fix wherein a malformed file will prevent these two operations from succeeding, malformed files are skipped/ignored, is scheduled for 10.2.


Deployment failing with below error.

Deployment failed. Correlation ID: b6887f5f-84ef-4374-ac6e-b25a25b57392. {
"status": "Failed",
"error": {
"code": "ResourceDeploymentFailure",
"message": "The resource operation completed with terminal provisioning state 'Failed'.",
"details": [
{
"code": "DeploymentFailed",
"message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
"details": [
{
"code": "BadRequest",
"message": "{\r\n  "error": {\r\n    "code": "RoleAssignmentUpdateNotPermitted",\r\n    "message": "Tenant ID, application ID, principal ID, and scope are not allowed to be updated."\r\n  }\r\n}"
}
]
}
]
}
}

thanks for sharing this @nitinkhandelwal26 could you please what path you have followed to deploy the cluster? have you try to deploy this more than one AKS cluster?

Thanks for your response. We have followed manual using ARM templates, we are now getting an error related to certificates, trying to resolve the same, we have used your scripts only to generate certificates in Linux vm:
crt  location=eastus
Deployment failed. Correlation ID: b0a6fada-0cbc-49e3-9e77-25863e96a73f. {
"status": "Failed",
"error": {
"code": "ResourceDeploymentFailure",
"message": "The resource operation completed with terminal provisioning state 'Failed'.",
"details": [
{
"code": "ApplicationGatewayKeyVaultSecretException",
"message": "Problem occured while accessing and validating KeyVault Secrets associated with Application Gateway '/subscriptions/c824e797-2017-4901-91d4-5254ae8c1cf8/resourceGroups/rg-bu0001a0008/providers/Microsoft.Network/applicationGateways/apw-aks-zg6gqwsidy4fi'. See details below:",
"details": [
{
"code": "ApplicationGatewaySslCertificateInvalidData",
"message": "Data or Password for certificate /subscriptions/c824e797-2017-4901-91d4-5254ae8c1cf8/resourceGroups/rg-bu0001a0008/providers/Microsoft.Network/applicationGateways/apw-aks-zg6gqwsidy4fi/sslCertificates/apw-aks-zg6gqwsidy4fi-ssl-certificate is invalid."
},
{
"code": "ApplicationGatewayTrustedRootCertificateInvalidData",
"message": "Data for certificate /subscriptions/c824e797-2017-4901-91d4-5254ae8c1cf8/resourceGroups/rg-bu0001a0008/providers/Microsoft.Network/applicationGateways/apw-aks-zg6gqwsidy4fi/trustedRootCertificates/root-cert-wildcard-aks-ingress-contoso is invalid."
}
]
}
]
}
}

great to hear you guys troubleshooted it @nitinkhandelwal26 please ensure you have got values for the env variables:

APP_GATEWAY_LISTENER_CERTIFICATE
AKS_INGRESS_CONTROLLER_CERTIFICATE_BASE64

These are set from https://github.com/mspnp/aks-secure-baseline/blob/73ba0003b6d373258a8c319c1abc57b5ec2bed98/02-ca-certificates.md

@ferantivero Thanks for the response, now below error is there :
Deployment failed. Correlation ID: e96f1f76-fd2b-4c51-bc7c-d11b7ea3c520. {
"status": "Failed",
"error": {
"code": "ResourceDeploymentFailure",
"message": "The resource operation completed with terminal provisioning state 'Failed'.",
"details": [
{
"code": "DeploymentFailed",
"message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
"details": [
{
"code": "BadRequest",
"message": "{\r\n  "error": {\r\n    "code": "RoleAssignmentUpdateNotPermitted",\r\n    "message": "Tenant ID, application ID, principal ID, and scope are not allowed to be updated."\r\n  }\r\n}"
}
]
}
]
}
}

That's the same error message you posted originally.  Have you validated you have the permissions necessary to perform role assignments and grant other users the same?  This is covered in our pre-req section, under the first step.

@ckittel I am following exactly what is given in pre-req section, but it's giving same error now, I have already registered in AAD V2 and that service principal attache reference role.

Now I am allocating Owner role to this and retrying.

my id from where I am deploying this AKS application is having Global admin role and owner access to the subscription.

thanks for sharing this information @nitinkhandelwal26,
It seems some Role Assignments will need to be re-created. Please let's try to execute the following troubleshooting steps:

identify Role Assignments that are failing to be deployed:  az deployment operation group list -g <resource-group> -n <failed-deployment-name> --query "[?properties.statusMessage.status=='Failed']"
delete the Role Assignments that finished with the code RoleAssignmentUpdateNotPermitted by using their field id (command shared above might help): az role assignment delete --ids <space-separated-failed-role-assignment-ids>
re-deploy the ARM template

Execution of step 1 gave below error:
az deployment operation group list -g rg-bu0001a0008 -n cluster-stamp --query "[?properties.statusMessage.status=='Failed']"
[
{
"id": "/subscriptions/c824e797-2017-4901-91d4-5254ae8c1cf8/resourceGroups/rg-bu0001a0008/providers/Microsoft.Resources/deployments/cluster-stamp/operations/C985C0A5474C9CA6",
"operationId": "C985C0A5474C9CA6",
"properties": {
"duration": "PT4.6434236S",
"provisioningOperation": "Create",
"provisioningState": "Failed",
"request": null,
"response": null,
"serviceRequestId": "98d11669-10c6-4f6c-bc4a-0c9ff1e1da4d",
"statusCode": "Conflict",
"statusMessage": {
"error": {
"code": "ResourceDeploymentFailure",
"details": [
{
"code": "DeploymentFailed",
"details": [
{
"code": "BadRequest",
"message": "{\r\n  "error": {\r\n    "code": "RoleAssignmentUpdateNotPermitted",\r\n    "message": "Tenant ID, application ID, principal ID, and scope are not allowed to be updated."\r\n  }\r\n}"
}
],
"message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details."
}
],
"message": "The resource operation completed with terminal provisioning state 'Failed'."
},
"status": "Failed"
},
"targetResource": {
"id": "/subscriptions/c824e797-2017-4901-91d4-5254ae8c1cf8/resourceGroups/rg-enterprise-networking-spokes/providers/Microsoft.Resources/deployments/EnsureClusterSpHasRbacToVNet",
"resourceGroup": "rg-enterprise-networking-spokes",
"resourceName": "EnsureClusterSpHasRbacToVNet",
"resourceType": "Microsoft.Resources/deployments"
},
"timestamp": "2020-07-21T15:18:36.311420+00:00",
"trackingId": "125e561f-03d6-4ddb-8b8d-8684aeae692c"
},
"resourceGroup": "rg-bu0001a0008"
}
]
On Step 2 in deletion of Role Assignment.
az role assignment delete --ids /subscriptions/c824e797-2017-4901-91d4-5254ae8c1cf8/resourceGroups/rg-enterprise-networking-spokes/providers/Microsoft.Resources/deployments/EnsureClusterSpHasRbacToVNet
Getting below error:
The api-version '2018-09-01-preview' is invalid. The supported versions are '2020-06-01,2020-05-01,2020-01-01,2019-11-01,2019-10-01,2019-09-01,2019-08-01,2019-07-01,2019-06-01,2019-05-10,2019-05-01,2019-03-01,2018-11-01,2018-09-01,2018-08-01,2018-07-01,2018-06-01,2018-05-01,2018-02-01,2018-01-01,2017-12-01,2017-08-01,2017-06-01,2017-05-10,2017-05-01,2017-03-01,2016-09-01,2016-07-01,2016-06-01,2016-02-01,2015-11-01,2015-01-01,2014-04-01-preview,2014-04-01,2014-01-01,2013-03-01,2014-02-26,2014-04'.
So, need to change API version to 2020-06-01 instead of 2018-09-01-preview mentioned in ARM template. You also change API version in Cluster-Stamp.json.
Will try it tomorrow and keep you updated. Thanks for all your support @ckittel @ferantivero

@nitinkhandelwal26 to obtain the proper id for step 2 that needs to be deleted, please execute the following command:
az role assignment list --all --query "[?contains(scope,'rg-enterprise-networking-spokes')].id" -o tsv

if you get more than one result from above execution, please let's ensure the role assignment you are about to delete correspond to your own deployment instance.

Thanks for your input @ferantivero @ckittel , After adding to owner role in Azure AD group I was able to provision the cluster-stamp.json template but now stuck in Azure policy part in 07-workload-prerequisites.md
Confirm policies are applied to the AKS cluster
kubectl get constrainttemplate
it's giving no resource exists.
then I deployed a complete template and added WAF public IP in /etc/hosts file, still it's not accessible.
Will try again tomorrow, and keep you updated.

kubectl get constrainttemplate -- I got that as well, but was able to proceed.  @ferantivero -- can we clarify what the "correct" response should be to that command.  After I got the same message as @nitinkhandelwal26 I just moved on and it all worked in my last dry run yesterday.

thanks for pointing this out @nitinkhandelwal26 we solved an issue that prevented from getting deployed the Azure Policy for Kubernetes, and also added some details to validate the outcome from kubectl get constrainttemplate.
If you are really looking forward to this feature, please consider re-creating the AKS cluster to ensure Azure Policy is properly deployed as well as avoid RoleAssignmentUpdateNotPermitted:

delete the cluster first
delete all the Role Assignments
deploy the cluster-stamp again.

Please let us close this issue for now as it seems the original post had been already addressed. But please do not hesitate in re-open this one or create new issues if necessary.


Linking to specific functions using # doesn't work until the page is loaded.

Create a new tab in your browser and paste this — http://package.elm-lang.org/packages/elm-lang/core/2.1.0/List#head — is your window scrolled to the function head, or is it in the beginning of the page?
Now focus on browser's address bar and press Enter. Now the window is scrolled down starting from head function.
Because the API description is dynamically generated, the browser doesn't know what #head is. But when the page is finally generated and the DOM is changed, now you can position yourself using internal links.

Can you check this again in your setup, @sindikat? It should be fixed now.

It works!


Doesn't find New Zealand Radio Stations

Can't find Radio Hauraki http://www.iheart.com/live/radio-hauraki-6191/ or
ZM http://www.iheart.com/live/zm-6190/
But have discovered some interesting US stations
Thanks

The official iHeartRadio app won't bring them up on a search for me, either (in the US), although I can follow your links and listen. Unless I can get access to packet captures (e.g. from wireshark) of a "foreign" device/app searching for and playing stations (or unless someone else does the work), I don't see how I'll figure out what they do differently from the captures I've been able to study.
I'll leave this open, but I don't think you can expect progress (unless you can get a wireshark dump to me!)

At some point in the past two years these stations have mysteriously started working for me; there has been at least one API change in that time.

Couldn't help but notice i'm having the exact same issue in Straya.
Using ID 6179 or searching for "The Edge" does not return expected results. https://www.iheart.com/live/the-edge-6179/

Welp, that didn't last long, the New Zealand ones are broken again too. Same problem as before, I'm afraid, I have no idea if/how the iHeartRadio app(s) behave differently outside the US, and the website (and I presume the app, once I get time to check) won't show these stations for me, even though (again) I can follow the link and listen.

I should be able to try getting a dump i should have some free time after Christmas. If i manage to get anything i'll let you know.


python312Packages.great-expectations: init at 1.2.1

Init python312Packages.great-expectations, a package for writing tests against data sources and distributions.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[NA] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 353677

x86_64-linux

:white_check_mark: 2 packages built:

python311Packages.great-expectations
python312Packages.great-expectations

aarch64-linux

:white_check_mark: 2 packages built:

python311Packages.great-expectations
python312Packages.great-expectations

x86_64-darwin

:white_check_mark: 2 packages built:

python311Packages.great-expectations
python312Packages.great-expectations

aarch64-darwin

:white_check_mark: 2 packages built:

python311Packages.great-expectations
python312Packages.great-expectations


Executing custom text command causes cursor in editor to move down

I set up custom text commands so that I can run them with a keystroke while I'm editing a file and they'll post the custom command to the terminal. However, when I execute any of my custom commands from within the editor pane, it causes the cursor in the editor pane to move down one row, as if I had pressed the down arrow key.

Please retest again with platformio-atom-ide-terminal 2.9.0 is using node-pty-prebuilt instead unmaintained and outdated pty.js


Eliminate extra check to GetFileSize when uploading files

The 2nd check is not required as you can see in the logs below.
# UploadFile("D:\Github\hgupta\FluentFTP\README.md", "/public_html/temp/README.md", Overwrite, False, None)

# FileExists("/public_html/temp/README.md")
Command:  SIZE /public_html/temp/README.md
Response: 213 56985

# DeleteFile("/public_html/temp/README.md")
Command:  DELE /public_html/temp/README.md
Response: 250 Deleted /public_html/temp/README.md

# OpenWrite("/public_html/temp/README.md", Binary)
Command:  TYPE I
Response: 200 TYPE is now 8-bit binary

# GetFileSize("/public_html/temp/README.md")
Command:  SIZE /public_html/temp/README.md
Response: 550 Can't check for file existence
Command:  EPSV
Response: 229 Extended Passive mode OK (|||31852|)
Status:   Connecting to <IP_ADDRESS>:31852
Command:  STOR /public_html/temp/README.md
Response: 150 Accepted data connection
Response: 226 1.265 seconds (measured here), 43.98 Kbytes per second
Response: 226-File successfully transferred

Done in 17.6.2


General Updates

Update Time, Yeah boi.

I have no clue how this works. GitHub asked me to do it.


xmake silently hides compiler warnings

Xmake Version
2.8.5
Operating System Version and Architecture
macOS
Describe Bug
I normally compile with -Werror, so I'm not sure how long this has been an issue, but I recently started using -Wno-error= to make warnings back into warnings in some third-party code and was surprised that xmake did not report the warnings.
Even with xmake -v (which I need to use to make xmake not annoyingly truncate error messages in the middle), I don't get any output.
Expected Behavior
Warnings should be reported to the programmer!
Project Configuration
Minimal example:
ex.c:
#warning xmake hides this!

int main() {}

xmake.lua:
target("example")
	add_files("ex.c")

Running xmake:
$ xmake
checking for platform ... macosx
checking for architecture ... arm64
checking for Xcode directory ... /Applications/Xcode.app
checking for Codesign Identity of Xcode ... no
checking for SDK version of Xcode for macosx (arm64) ... 14.0
checking for Minimal target version of Xcode for macosx (arm64) ... 14.0
[ 25%]: cache compiling.release ex.c
[ 50%]: linking.release example
[100%]: build ok, spent 3.404s

No warnings!
Running xmake -v after deleting .xmake and build:
$ xmake -v
$ xmake -v
checking for platform ... macosx
checking for architecture ... arm64
checking for Xcode directory ... /Applications/Xcode.app
checking for Codesign Identity of Xcode ... no
checking for SDK version of Xcode for macosx (arm64) ... 14.0
checking for Minimal target version of Xcode for macosx (arm64) ... 14.0
checking for zig ... no
checking for zig ... no
checking for /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang ... ok
checking for the c compiler (cc) ... clang
checking for /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang ... ok
checking for flags (-fPIC) ... ok
[ 25%]: cache compiling.release ex.c
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -c -Qunused-arguments -target arm64-apple-macos14.0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -o build/.objs/example/macosx/arm64/release/ex.c.o ex.c
checking for flags (-MMD -MF) ... ok
checking for flags (-fdiagnostics-color=always) ... ok
checking for /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ ... ok
checking for the linker (ld) ... clang++
checking for /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ ... ok
checking for flags (-fPIC) ... ok
[ 50%]: linking.release example
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -o build/macosx/arm64/release/example build/.objs/example/macosx/arm64/release/ex.c.o -target arm64-apple-macos14.0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -stdlib=libc++ -lz
[100%]: build ok, spent 0.224s

No warnings!
But running the command that xmake tells me it ran:
$ /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -c -Qunused-arguments -target arm64-apple-macos14.0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -o build/.objs/example/macosx/arm64/release/ex.c.o ex.c
ex.c:1:2: warning: xmake hides this! [-W#warnings]
#warning xmake hides this!
 ^
1 warning generated.

Additional Information and Error Logs
N/A.

It's not a bug but a design choice, see this page of the doc.
You can either pass -w to xmake to make it print warnings: xmake -w, enable it globally with xmake g --build_warning=y or enable it for everyone on this project using set_policy("build.warning", true).

It looks as if that policy needs to be in the root file, so I can't turn it on globally in the SDK's xmake.lua.  It's a staggeringly dangerous default.  I can't imagine any project actually wanting that behaviour.  I need to tell every consumer of our SDK 'If you actually want the warnings that you've enabled to be visible, you need to opt into this non-default bahaviour'.
What is the rationale for this?  It's even worse than the 'silently throw away valid compiler flags because xmake doesn't know about them' behaviour.
Warnings exist for a reason.  If they're enabled, it's because the user wants to know when they do the thing that the warning warns for.  You can disable any warnings that you don't want to see with compiler flags (if you remember {force = true}, otherwise xmake silently doesn't pass these flags to the compiler.

Your sdk/xmake.lua is the project root file, and you should be able to turn it on in the global root scope. It's the same as this configuration.
https://github.com/microsoft/cheriot-rtos/blob/7280f24899042996f395341f011ccd9ef50eff56/sdk/xmake.lua#L6
Only developers need to see the warnings in real time, while for users they simply want to compile your project and then use your framework and library binaries. They don't care about the warnings.
A large number of warnings can lead to frequent output from the terminal, preventing users from viewing progress information. They don't care about the warnings.
For developers, they have the ability to configure set_policy("build.warnings", true) in xmake.lua or use xmake -w to see the warnings, and it's not a big deal.
Also, set_policy("build.warning", true) is perfectly fine for letting your project modify the default warning output behaviour, which only needs to be configured once and doesn't need to be configured every time by another user.

Your sdk/xmake.lua is the project root file, and you should be able to turn it on in the global root scope. It's the same as this configuration.

I tried that and it does not work.  The line that you link to also does not work and so I need {force = true} scattered all over the place.

Only developers need to see the warnings in real time, while for users they simply want to compile your project and then use your framework and library binaries. They don't care about the warnings.

Most users do not build software.  Two kinds of people build software:

Developers
Packagers

Both of these want to see warnings.  Packagers typically disable anything that hides output because they need it for their auditing.

A large number of warnings can lead to frequent output from the terminal, preventing users from viewing progress information. They don't care about the warnings.

That's an incentive to fix the warnings.  It's also a reason to fix the output.  Ninja does a much better job than xmake here:

The progress line is always at the bottom of the screen
Tool output appears above the progress line.
Tool output is always coupled with the exact command to reproduce that build step and so it can be run.

For developers, they have the ability to configure set_policy("build.warnings", true) in xmake.lua or use xmake -w to see the warnings.

I shouldn't have to do anything explicit to get a sensible default behaviour.

Also, set_policy("build.warning", true) is perfectly fine for letting your project modify the default warning output behaviour, which only needs to be configured once and doesn't need to be configured every time by another user.

It needs to be in every single xmake.lua that consumes our SDK.  It's another thing that we have to educate users of our SDK to do.  Onboarding people to a new build system (xmake) is already hard enough.

It should work, unless you're talking about other projects that use your sdk, rather than building the sdk itself.

The SDK does not build itself, it is included in other projects.

If you want other projects that consume your sdk to be on by default as well. you can set it in function firmware(name).

Does that then apply to all targets or just to the firmware target?

so they can add -w option or use set_policy("build.warning", true) to enable it.

Sane defaults are about ensuring that users don't have to explicitly do anything unless they have unusual requirements.  Hiding warnings is never the right thing to do.  If you don't want to see warnings, disable those warnings.

xmake also support it. you need only to switch to ninja theme.

Oh, nice!  It doesn't respect NINJA_STATUS (I have NINJA_STATUS=%p [%f:%s/%t] %o/s, %es in my shell config to get nicer output from Ninja) and it still randomly truncates error messages (which also breaks editors that parse the compiler output to provide warnings), is there another magic setting that can turn that off?  It's especially bad for C++ because it always manages to remove the bit of the error message that tells you the line that is actually responsible for the bug.

But not everyone will see this as a default behaviour. Even if I have it enabled by default. There will be other users configuring set_policy("build.warnings", false) to disable it, or opening issues to complain about too many warnings and how to disable them.

Have you had feedback about that?    It's something that most secure coding guidelines and corporate policies have explicitly disabled.  At the very least, a status line saying 'warnings are hidden by default, use xmake -w to show them' would reduce the surprise.

Does that then apply to all targets or just to the firmware target?

for all

Oh, nice! It doesn't respect (I have in my shell config to get nicer output from Ninja) and it still randomly truncates error messages (which also breaks editors that parse the compiler output to provide warnings), is there another magic setting that can turn that off? It's especially bad for C++ because it always manages to remove the bit of the error message that tells you the line that is actually responsible for the bug.NINJA_STATUSNINJA_STATUS=%p [%f:%s/%t] %o/s, %es

? xmake -D will show all messages

Have you had feedback about that?  It's something that most secure coding guidelines and corporate policies have explicitly disabled. At the very least, a status line saying 'warnings are hidden by default, use xmake -w to show them' would reduce the surprise.

no, you can only use xmake -w or set_policy("build.warning", true) to enable it.

I have to say that not showing warnings seems like the wrong default. Somebody preferring clean output is surely less important than somebody wanting to see the same warnings they get with other build systems, without having to read the manual first.
Hiding warnings by default breaks The Principle of Least Astonishment imo.

I've started a poll, and if the majority of people agree that warning output should be turned on by default, I'll consider changing the default behaviour.
https://github.com/xmake-io/xmake/discussions/4642

I have enabled it. https://github.com/xmake-io/xmake/pull/4651


Update AntiBotMain.lua

Fixes a few bugs and makes it better

Looks good

Merged, sorry for the delay.


[native_assets_builder] Caching when helper packages are updated

When native_toolchain_c is updated, we want to rerun the build.dart hook. However, we don't want to rerun on every pub get. How can we do this?

https://github.com/dart-lang/native/pull/1322


[geoip] Fix population of anonymous headers

Currently, when IP is looked up in the anonymous database and lookup result is empty, geolocation anonymous headers will not be populated, while they should be populated with "false" value instead (meaning that IP is not anonymous).
Commit Message:
Additional Description:
Risk Level: Low (wip extension)
Testing: Unit test
Docs Changes: Done
Release Notes:
Platform Specific Features:

/wait-any


Add Exemplars for http_request_duration_seconds histogram

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
The Prometheus HTTP handler now enables OpenMetrics as response format upon content negotiation.
You can test it by running curl -s -H 'Accept: application/openmetrics-text' localhost:10904/metrics
This allows us to pass a traceID to ObserveWithExemplar.
A lot of the other changes are actually changing the order of calling the middlewares.
Going forward we need to make sure to first call the tracing middleware so that by the time our monitoring/instrumentation middleware gets hit the tracing spans are already populated.
Verification
Tested locally with Jaeger and Prometheus running --enable-feature=exemplar-storage.

Closes #3944

Let's iterate over it @yeya24 good points. Also I would see GetTraceID as some helper function tbh (:


Are camera pose also released in the groundtruth annotation?

Hi, thanks for releasing this dataset.
May I ask if the camera pose is also released? If so, where can I find them?
Thanks.

An easy way is to use the inverse of an annotated static object. Since our object annotation is in the camera frame, so the camera pose is just the inverse of it.

I thought your object pose annotation is the transformation of current frame object pose w.r.t. the CAD coordinate coordinate framework. And different objects may have different canonical coordinate framework, hence inverse of different static objects may give different poses.
Am I interpreting wrong here?

It is not, actually the object pose is the transformation of current object w.r.t. the current camera frames. In other words, it is in camera frame rather than the world frame.


Button "back" on result page not work

on "Create Virtual Machine" wizard, fill proper data and go through the the "result" page. Click "back" does nothing.

@suomiy has created a PR to allow disabling the Back and Cancel buttons from the results page since they don't make sense to allow once the VM has been created:
https://github.com/kubevirt/web-ui-components/issues/61

will be fixed once we will pull a version of pf-react with this change. Leaving opened until then.

fixed in 1.3.-9

For this situation, I actually want to go back to change the VM name.

For this situation, I actually want to go back to change the VM name.

That is actually one bug and one feature request what you say :)
1: So, the bug is that the validation of the subdomain on frontend is not correct and it fails on server
2: the feature request is to allow to return from the "results" page if the submit to the server fails
can you please open those?

The reopen button is not visible to me.

@andybraren - Would you mind thinking about how we could represent an error state here? We'd want to allow the user to go back and make changes, too.

@andybraren
We are validating frontend validations in each tab because it is easier to fix them in place.
So I think the step with validating configurations, should give the user more clue what is actually happenning. E.g. sending request/trying/attempting to create VM? Because the thing is that also Please wait does not uphold to the meaning. The VM will be created even if you close the window (the request is already in the backend).
Also I don't think you should have an option go back when the VM was successfully created. I know you may want to create similar VM again, but I think that is confusing.

@andybraren @suomiy
So the 1 screen is ok,
2. screen should say Creating Virtual Machine instead of Validatin Configuration
3. screen is ok. When VM cannot be created, we show error and allow user to do Back and edit.
4. screen should have Back button disabled as VM is already created
Am I right ?

@andybraren @suomiy
So the 1 screen is ok,
2. screen should say Creating Virtual Machine instead of Validatin Configuration
3. screen is ok. When VM cannot be created, we show error and allow user to go Back and edit.
4. screen should have Back button disabled as VM is already created

I'd agree with all of this - @andybraren thoughts?

I agree as well. "Validating configuration" was a mislabel because, as @suomiy said, the VM creation process is what's really going on in the backend.
Here's an updated image with what we've discussed above. I also disabled the Cancel button in step 4, since at that point the process is already in motion and can't be "cancelled".

I'm not familiar with how long VMs typically (or could) take to be created, but I notice that screen 2's buttons currently "trap" the user into either waiting for it to finish or clicking Cancel. Can users actually "cancel" the creation process halfway through? If not, maybe Cancel should be disabled in this screen and Close should be enabled (but not blue) as seen below. Thoughts on this?

If not, maybe Cancel should be disabled in this screen and Close should be enabled (but not blue) to allow them to escape, as seen below. Thoughts on this?

I think this is a great idea if the creation doesn't take too long. I especially like the idea of "Close" becoming a secondary button styling at this point since it's really not the main action we want to be calling out to the user yet.

If not, maybe Cancel should be disabled in this screen and Close should be enabled (but not blue) to allow them to escape, as seen below. Thoughts on this?

I think this is a great idea if the creation doesn't take too long. I especially like the idea of "Close" becoming a secondary button styling at this point since it's really not the main action we want to be calling out to the user yet.

AFAIK we cannot cancel the request, so disabling Cancel & enabling Close as non-primary button sounds good to me


Accessibility standard?

I can't seem to find in the documentation, which accessibility standards does axe-playwright use as default. For example, if I were to just run await checkA11y(page);?  Thanks.

It took me some time too but it should be like this


Fix syncing headers state while syncing blocks

#1132  👈
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lazynina and the rest of your teammates on  Graphite


Add podspec for CocoaPods

When will this change be merged

I am working on react native 0.60.4 and autolinking is not working for it because it says
!] use_native_modules! skipped the react-native dependency 'rn-apple-healthkit'. No podspec file was found.

Can we get this merged? Can't make a RN 0.61.1 release build without this fix.

Temporary fix for now:
add to Podfile:
  pod 'RCTAppleHealthKit', :podspec => '../RTCAppleHealthKit.podspec'

Create a file RCTAppleHealthKit.podspec in react native project root directory:
# https://github.com/terrillo/rn-apple-healthkit/pull/96

Pod::Spec.new do |s|
  s.name         = "RCTAppleHealthKit"
  s.version      = "0.6.5"
  s.summary      = "A React Native package for interacting with Apple HealthKit"
  s.license      = "MIT"
  s.homepage     = "https://github.com/terrillo/rn-apple-healthkit"
  s.authors      = "Terrillo Walls"
  s.platform     = :ios, "9.0"
  s.source       = { :git => "https://github.com/terrillo/rn-apple-healthkit.git", :tag => "0.6.5v" }
  s.source_files = "RCTAppleHealthKit/**/*.{h,m}"

  s.dependency "React"
end


Updated sql db cli get started

@jaredmoo,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@jaredmoo : Thanks for your contribution to the Azure documentation! The author, @CarlRabeler, has been notified to review your proposed change.

#sign-off

@tysonn please merge this PR


Connection pool leak issue - 1.0

in Styx 1.0 there is a connection pool leak issue, the pool sometime stuck in a state where is the borrowed connection count equal to the MaxConnectionPerHost count, in this state no new connections can be created and the styx will start returning 500s.
Steps to reproduce:
1- create a connection pool with:
a- low number of MaxConnectionPerHost & MaxPendingConnections
b- low number of MaxPendingConnectionTimeOut for example 1s
2- set a breakpoint in the SimpleConnectionPool class at line 77 Connection connection = dequeue(); inside the borrowConnection method.
3- open the browser and open an N number of tabs where N = MaxConnectionPerHost + MaxPendingConnections.
4- make a request for the origin in each tab.
5- start releasing the breakpoint one by one.
After these steps you should start seeing the behaviour of the 500s. any request you will make after this will return a 500 response code.

Root cause analysis
Overview
I see a problem in the connection pool (thanks for providing the necessary pointers @salahqasem ).
There is definitely a window for a race condition, when:

A waiting subscriber has been disposed (cancelled, pending connection timeout, etc), but not yet removed from the waitingSubscribers queue.
A TCP connection becomes available, and it is handed out to this waiting subscriber. A borrowed count is incremented, but the connection itself leaks because the Mono subscriber is already in the terminal state.
The leaked connection cannot be returned back to pool, therefore the borrowed count drifts up permanently.


Explicitly state NaN-box behavior for vfmerge.vfm and vfmv.v.f

As chuanhua commented on issue #312, please can you explicitly state in the specification that vfmerge.vfm and vfmv.v.f do not require NaN-boxed inputs. This is not mentioned anywhere and contravenes the statement in section 11.1, item 3 of the vector-scalar operand form list.
(I have promoted his comment to an issue so that it is not lost.)

After some discussion with @kasanovic, I am not sure that the resolution of #312 is the right thing to do.  My current thinking is that vfmerge.vfm, vfmv.v.f, and vfmv.s.f should check for a NaN box when FLEN > SEW (and correspondingly vfmv.f.s should check for a NaN box when SEW > FLEN).  This is a semantic change to the move instructions, so the task group will have to weigh in.
Part of my rationale is that it's simpler for the hardware if all f-register operands to vector instructions are checked for a NaN box.  (Otherwise, the f-register check becomes opcode-dependent in addition to SEW-dependent, as e.g. vfadd and vfmerge would perform different checks.)  And it does provide a smidge more error checking, but I think this is a minor point.
In the presumably rare circumstance that checking for a NaN box is undesirable, one can first transfer the f register to an x register and use the integer merge instruction.

BTW, thanks for making sure this issue didn't get lost!

Hello Andrew,
I agree with your logic. The implementation in riscvOVPsim is cleaner if the NaN-box test also applies to vfmerge.vfm and vfmv.v.f and I would expect that the same would be true in hardware. Assuming that this is agreed by the task group, it should then be explicitly clarified for these two instructions in the specification, since behavior is different to similar-looking instructions in the base floating point ISA.
James.

Thanks for the feedback.  I've written this up in the spec, but am leaving the issue open until the task group reaches consensus.

I believe vfmv.s.f and vfmv.f.s should check for NaN boxing, same as vfmv.v.f .
Because vector registers are unified float and integer, it is straightforward to use integer moves to copy bits around without interpretation if needed.
Will bring up with TG.

I'm going ahead to merge this change for vfmv.f.s and vfmv.s.f as I believe it will be uncontroversial, as it removes an inconsistency where the odd behavior has no real purpose.


Using link_to_remove_association without deleting associated object

Hello! How can I use link_to_remove_association only for removing the association, not actually deleting the associated object?

Going to have to be way more specific ... do can you link to repo of your senario?
Several senario's ....

You want to delete the foreign key entry from a single entry (schema would be has_many & belongs_to )

You want to ONLY delete the join table entry row linking the two tables.  The schema would be self-referential table or join table M:M / M:1:M ala has_many+through:`

On a side note ... the other thing I was thinking ...
Just don't use the dependent: :destroy part leaving any children of the owning object if you delete it?

Well you give us no data-model, so it is a little bit of guesswork, but did you check out the demo-project?
There we demonstrate for example

a project :has_many tags :through project-tags. Either you select an existing tag, or create and link to a new one. When unlinking from a tag, the tag is not deleted, only the link.

If you need more specific information/help, you will have to provide more information yourself.

Closed due to inactivity.


Fixed some engine traces failing

[#] Fixed some engine traces failing.
Related issue:
fixes #128

@Joshua-Ashton out of curiosity, would this also possibly get merged or is there something you dislike about it?


Issue with k8s.io/docs/tasks/access-application-cluster/port-forward-access-application-cluster/

Direction of port forwarding is unclear, because 6379 is used as port of pod and port of host-interface.

@c5253458  I am agree with you on this . First time reader will get confused with same local and pod port number. I will fix this to have different port number so that people will understand concept easily.  Thanks for this issue.

/language en

Port 6379 is the port that Redis normally uses
I'm not sure there is anything that needs fixing.

/triage awaiting-evidence

/priority awaiting-more-evidence

Port 6379 is the port that Redis normally uses

The proposed change of documentation is not about default behaviour (which might change),
but on how to define well defined port forwarding.

/close


[CAMEL-9500] CamelVersionHelper cannot handle version qualifier

If the version source code is taken from OSGi you would need to add a 2nd license header like we do here: https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/impl/osgi/tracker/BundleTracker.java#L19


ssh config settings outside of a Host block show a warning and fail

When directives are present that are outside of a Host block a warning is shown and the program exits with status code 1.
I have the following at the top of my ssh config file:
PermitLocalCommand yes
Include config.d/*

and some hosts
$ grep -c -w ^Host ~/.ssh/config
16

but I am getting the following warning unless I comment the first two settings
$ uvx --from sshclick sshc hosts
WARNING:root:Config info without Host definition on SSH-config line number 0

$ head -2 ~/.ssh/config
#PermitLocalCommand yes
#Include config.d/*

$ uvx --from sshclick sshc hosts
┌──────┬─────────┬────────┬────────────────┬────────────┐
│ name │ group   │ type   │ param:hostname │ param:user │
├──────┼─────────┼────────┼────────────────┼────────────┤
│ g    │ default │ normal │ ***            │ root       │
│ am   │ default │ normal │ ***            │ root       │
...

Hi,
In your case, here we have basically 2 different issues.

Handling of global keywords (PermitLocalCommand) without prior definition of Host xxxx

From what I understand, if this is defined like that, it is applied for all hosts that are defined below this line, unless of course more specific Host definition is matches by "pattern" or explicit name/fqdn, and that one specifically overrides the argument.
This can be also achieved same way by defining it like this at the top of the ssh config:
Host *
    PermitLocalCommand yes
...

This would result with same behavior and sshclick will be able to parse it normally, and also when viewing host details present all those "inherited" attributes when establishing connection.
This also seems to me as more "explicit" approach in my view
Regarding support for such "host-less" config attributes, since they are supported by current clients, I will consider how to integrate that into the features for next releases...

Include keyword

This one was on my radar from the beginning, and I still don't have good idea how to approach it...
It is really not a problem to follow "include" directives and slurp other config files.
Also the problem is not displaying it once it is all parsed and ready for printing or displaying in TUI mode...
For me problem is then how to optimally approach adding/editing configurations, and re-rendering configurations.
Which file should be updated, and under what rules. How to distinct what goes into what file... should it be based only on initial read? Should sshc or ssht interfaces be allowed to "move" hosts or groups between files?
I think all this is possible, but it would require a lot more code and time. :D
If you have any proposals how to approach it, I'm open for ideas and discussions.

I already have a generalized Host * at the bottom of the file. I was keeping this preamble for Canonicalization rules which I no longer use. You are correct that PermitLocalCommand can be moved to Host *. I would rather keep the include on top though.
On the support of includes - you already have SSH_Config to parse files. I guess they need to be loaded in some tree or DAG and make the hosts and groups aware of their own source.

In terms of "includes" you are right, I fully support it being on top for clarity, as openssh clients (ssh, sftp, etc...) treats this keyword similary like C pre-processor... basically when this line is reached, it is during processing just replaced with content of linked files.
This makes pure ssh config very flexible in use, such as adding bunch of common Keyword/Args pairs to separate file, and then in main file use Include keyword to load common args to multiple Host definitions.


ASP.NET Core SPA Angular 7 SSR

I was able to successfully create an Angular 7 SPA rendering on the client side, There's no documentation however for how to render it on the server side.
The only documentation I found is kind of obsolete today because it's for older versions of Angular, here: https://docs.microsoft.com/en-us/aspnet/core/client-side/spa/angular?view=aspnetcore-2.1&tabs=visual-studio#server-side-rendering
Can we have the above link updated to reflect Angular 7 SSR?
Thank you!

@ahamidou 	would you mind opening this issue at the bottom of the page? That will help get your issue considered.


How to publish back MS apps that are uninstalled and unpublished from container

Is there a way to Publish, Sync and Install back Microsoft app that has been removed from container?
I did:
UnInstall-NavContainerApp -containerName $containerName -appName _Exclude_QuickBooksSynchronization_
Unpublish-NavContainerApp -containerName $containerName -appName _Exclude_QuickBooksSynchronization_

And now when I try to create new tenant:
New-NavContainerTenant -containerName $containerName -tenantId newtenant

I receive error about this extension missing:
...
Putting database tenant back online
Mounting Database for delivery on server localhost\SQLEXPRESS
Sync'ing Tenant
The tenant delivery could not be mounted because the following installed NAV extensions are missing, matching content could not be found,
or have a higher version than those that are published and synchronized: "_Exclude_QuickBooksSynchronization_" by Microsoft, version
2.0.22490.0.
At C:\Program Files\WindowsPowerShell\Modules\navcontainerhelper\<IP_ADDRESS>\TenantHandling\New-NavContainerTenant.ps1:32 char:5
+     Invoke-Command -Session $session -ScriptBlock { Param($tenantId,  ...
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (0:Int32) [Mount-NAVTenant], FaultException`1
    + FullyQualifiedErrorId : MicrosoftDynamicsNavServer$NAV/delivery,Microsoft.Dynamics.Nav.Management.Cmdlets.MountNavTenant
    + PSComputerName        : 145c373ed64540101024cb5b150b240cde4bc661171cdf1b463d318763520148

I had to install again newer version of Exclude_QuickBooksSynchronization app 2.0.22621.0 and run upgrade. After that I was able to use New-NavContainerTenant  to create new tenants.
I think somehow template tenant that's used for creating new tenants had different app id for Exclude_QuickBooksSynchronization even though I installed that same app again which was preventing tenant to mount.
This was a good insight for me.


Replace radians with degrees in servo/unit.hpp

Radians are pretty hard to work with directly for humans where degrees makes far more sense even if they are pretty arbitrary in nature.

embed::percent was chosen for controlling servo position and no longer direct radians or degrees. #291


in_app_purchase not retrieving past purchases when redeemed using promo codes on iOS

#50071  Steps to Reproduce
Using the latest in_app_purchase 0.3.0+2
My app and IAPs are already approved in the apple app store since February 4

Redeem a promo code successfully via App Store (IAP or Subscription)
Then query past purchases in your app

Expected results:
Expecting to see/retrieve the redeemed in-app-purchase to be included in the past purchases when queried
Actual results:
The empty array of past purchases

Logs
[✓] Flutter (Channel beta, v1.13.6, on Mac OS X 10.15.2 19C57, locale en-PH)
• Flutter version 1.13.6 at /Users/nemoryoliver/Development/flutter
• Framework revision 659dc8129d (5 weeks ago), 2019-12-30 09:24:47 -0800
• Engine revision bdc9708d23
• Dart version 2.8.0 (build 2.8.0-dev.0.0 c547f5d933)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/nemoryoliver/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C504
• CocoaPods version 1.8.4
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] VS Code (version 1.41.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.8.0
[✓] Connected device (4 available)
• BBD100 2      •<PHONE_NUMBER>                               • android-arm64  • Android
8.1.0 (API 27)
• Oliver's iPad • caedeff388555a61b1d1f579d9f3cf3b2c17c42e • ios            • iOS
12.4.4
• Chrome        • chrome                                   • web-javascript • Google
Chrome 79.0.3945.130
• Web Server    • web-server                               • web-javascript • Flutter
Tools
• No issues found!

Can you write up a tiny example that will demonstrate the problem?  Is the promo unlocking then after you uninstall and reinstall it isn't showing up?  Did you try using restoreTransactions?

Hi @nemoryoliver
Please take a look a this comment above and please provide the details asked
Thank you

Hi @nemoryoliver
Without additional information, we are unfortunately not sure how to resolve this issue. We are
therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the
bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Refactor to use Python classes in blue-green deploy lambda

@alicefuzier I did a bit of an experiment with extending namedtuple into a class. Gives you an (immutable-ish) case-class-esque thing that I think makes it easier to follow what's going on. I don't think this is that weird from a Python point of view (/cc @alexwlchan).
I've also run flake8 over the code (and fixed the errors - they were all whitespace or line length) on @alexwlchan's advice.
There were some places where you were doing:
if true:
  wrap_main_execution_in_if_statement()
  etc()

When I think it's more idiomatic to just return on the "bad" case:
if false:
  return

Closing in favour of existing PR.


--nobundle option does not appear to work

From @chrisfelix82 on March 2, 2016 4:23
Short description of the problem:
I have been using Browserify and a custom gulpfile since v1, and would like to keep using this in v2.  I already had a root "app" directory with source and build to www.  I have updated my gulpfile to support TypeScript (e.g. tsify with Browserify is pretty simple).  The issue is that I would like to run in live preview mode via ionic run ios --nobundle, but it is not working.  Seems that webpack stuff is always run.  As such I have had to stick to live preview of an Ionic 2 app using an ionic 1 project structure and cli.
What behavior are you expecting?
I expect that when I run any of the ionic run/serve etc commands with --nobundle, that all the cli does is start the live preview server, and delegates to the developer to bundle/build as was the case in Ionic 1
Steps to reproduce:

Run ionic run ios --nobundle
webpack is still run

Ionic Version: 2.x
Browser & Operating System: iOS
Copied from original issue: driftyco/ionic#5673

Hey thanks for the issue. This flag is going to be going away soon we move to a gulp build: https://forum.ionicframework.com/t/attention-upcoming-ionic-2-starter-changes/45058
I'll leave this open until it lands.  Let us know if you have any questions/concerns, thanks!

Awesome!  I like that you guys will be switching to gulp and browserify as it is much simpler to work with and can support using regular non typescript common js modules without additional work.

Closing as the starters now use Browserify by default and the build has been handed off to Gulp, so this shouldn't be an issue anymore.


add account screen

Codecov Report
Patch and project coverage have no change.

Comparison is base (8d1889b) 37.33% compared to head (3c72932) 37.33%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   37.33%   37.33%
=======================================
  Files           9        9
  Lines         675      675
=======================================
  Hits          252      252
  Misses        398      398
  Partials       25       25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


403 when trying to load .pyhtml template?

I know I have been posting about silly path errors here before. It has finally been solved. But there is one thing I can't get to work. I have to .pyhtml-templates, and when I try to load these, I just get a "403 forbidden" error with the kind of strange message "Request forbidden -- authorization will not help.". Authorization is not the option, so what do I do?
Template names:
about.pyhtml and network.pythml
Request URLs:
<IP_ADDRESS>/templates/about.pyhtml (same response as mentioned above)
<IP_ADDRESS>/templates/network.pyhtml (same response as mentioned above)
Rootpath:
/flash/server/www
The templates are in the "templates" folder, a subfolder of www.

I only needed variables in the HTML file, so I had to do a non-optimal but working solution using format() instead, as I haven't gotten a response yet. I guess I will close this (for my case), although I technically still have the issue.

Had the same issue. Seems it was an error while processing some variables inside the .pyhtml. After removing them and starting with a clean html file instead - it worked.


revert sharkpool change

it breaks projects that change the render size

nevermind the person who reported the bug had no idea what they were talking about >:(

Me when this is garbomuffins change :trollface:


It seems that visualize_attention_scores can only visualize either mask-mod-only or score-mod-only

https://github.com/pytorch-labs/attention-gym/blob/75867424a1d4391bff49527029d3612a09dd67e2/attn_gym/utils.py#L68

Do you have an example that needs both? It should deff be possible to extend it to visualize both

For example, if we want to apply Alibi positional embedding/soft-cap within the sliding window, a visualize_attention_scores that supports both will be very useful.


Unable to publish vstest.console code coverage results to VSTS

This seems almost identical to closed issue https://github.com/Microsoft/vsts-tasks/issues/825.
I have a step to publish (xUnit via VSTest) test results that picks up the *.trx report correctly, but although the *.coverage report is generated and picked up as an attachment, it does not display any code coverage information in the build summary or on the "Code Coverage" tab.
As in the linked issue, I was also updating the build number in VSTS (although without colons), but I have completely removed that build number update in case it was related. No change in behavior.
I have tried using v1 and v2 of the "Publish Test Results" task and I have tried using the "Hosted" and "Hosted 2017" build agents.
From a recent build log:
2017-04-26T16:36:28.9703665Z ##[debug]Find-Files -SearchPattern d:\a\1\s\**\Test*\**\*.trx
2017-04-26T16:36:28.9913666Z ##[debug]FindFiles.FindMatchingFiles(rootFolder = , matchPattern = d:\a\1\s\**\Test*\**\*.trx, includeFiles = True, includeFolders = False
2017-04-26T16:36:29.0033651Z ##[debug]FindFiles.GetMatchingItems(includePatterns.Count = 1, excludePatterns.Count = 0, includeFiles = True, includeFolders = False
2017-04-26T16:36:29.3993659Z ##[debug]FindFiles.GetMatchingItems - Found: d:\a\1\s\.build\TestResults\xUnit\TestResults\buildguest_FACTORYVM-21 2017-04-26 16_36_11.trx
2017-04-26T16:36:30.2683650Z ##[debug]FindFiles.FindMatchingFiles - Found 1 matches
2017-04-26T16:36:30.2863658Z ##[debug]matchingTestResultsFiles = d:\a\1\s\.build\TestResults\xUnit\TestResults\buildguest_FACTORYVM-21 2017-04-26 16_36_11.trx
2017-04-26T16:36:30.2863658Z ##[debug]Calling Publish-TestResults
2017-04-26T16:36:30.3213662Z Publishing Test Results...
2017-04-26T16:36:30.3273664Z ##[debug]Get - SecretService and EndpointService from TaskContext
2017-04-26T16:36:30.3313655Z ##[debug]Fetched Endpoint:SystemVssConnection
2017-04-26T16:36:30.3343663Z ##[debug]AuthorizationType : OAuth
2017-04-26T16:36:31.0210730Z ##[debug]VssConnection created
2017-04-26T16:36:31.1440735Z ##[debug]Attachment location: d:\a\1\s\.build\TestResults\xUnit\TestResults\buildguest_FACTORYVM-21 2017-04-26 16_36_11\In
2017-04-26T16:36:31.1480976Z ##[debug]Setting run start and finish times.
2017-04-26T16:36:31.1510743Z ##[debug]Adding run level attachment: d:\a\1\s\.build\TestResults\xUnit\TestResults\buildguest_FACTORYVM-21 2017-04-26 16_36_11\In\FACTORYVM-21\buildguest_FACTORYVM-21 2017-04-26 16_32_37.coverage
2017-04-26T16:36:31.1610733Z ##[debug]Total test results: 67
2017-04-26T16:36:31.3291888Z Test results remaining: 67
2017-04-26T16:36:33.1449115Z Published Test Run : https://(redacted).visualstudio.com/(redacted)/_TestManagement/Runs#runId=693&_a=runCharts
2017-04-26T16:36:33.1459094Z ##[debug]Leaving script PublishTestResults.ps1
2017-04-26T16:36:33.1703419Z ##[section]Finishing: Publish Test Results **/Test*/**/*.trx```

Hi @fahnzmode,
Is your account url hsem.visualstudio.com? If yes can you provide your build number for the failed build? Please attach the complete logs too. Thanks

I attempted to send more detailed information to that email address, but I am unable:

The groups only accept messages from people in their organization or on their allowed senders list, and your email address isn't on the lists.

Hi, did this got resolved?

Please re-open this issue if it's not resolved. Happy to help you out.


Stories that don't work

Existing Issues

[X] I have searched for existing issues, this is not a duplicate.

Unmodded Twitch

[X] I have checked and this issue only occurs using bttv-android and not with the unmodded Twitch App

What happened?
after updating your application to the latest version, I have noticed 2-3 errors so far

Streamers' stories do not work
I cannot tag people in the chat in the new version of the chat/chat as an overlay on the stream screen
guess (to be confirmed) auto claiming
points. channel does not work when the chat is in the form of an overlay on the stream image, and when the stream is displayed in the "picture in picture" function, a small window above other applications

bttv-android version
0,41,0 -beta
android version
11
device
Realme C25Y
Anything else?
No response

I was a bit afraid of that, when I rebased to the app version that supports stories, none of the streamers I follow had stories up, so I couldn't actually test them. However, seeing as we didn't change anything about this feature and it's basically untouched by the patches, I would guess it's a bug in the base app.
If you could, can you check if stories work with this app here  ? This is the base twitch app without any of our changes but the same version, so if stories also don't work there it's a base twitch bug that will probably be resolved when we rebase to a newer version.

indeed, the errors I described seem to be caused by manufacturing defects in the main application without your modifications. The stories are not displayed at all in the base application of the given compilation, so there is probably a problem there, there is also an identical bug with the text. I apologize for the de facto incorrect reporting, as the fault is not yours. When I described the problem, I referred to the newest version of the base twitch application


update loadslim package name(docs)

I forgot that package after checking twice! Can you please fix the readme in the components/vue3 folder? Thanks!

I forgot that package after checking twice! Can you please fix the readme in the components/vue3 folder? Thanks!

done

Thanks!


Implement quick fix for disconnects sending all varb data

I think this fails for longer disconnects since the flow is CONNECTION_LOST -> LOGGED_IN -> varb changes. Checking LOGGED_IN on its own causes issues since you change to that gamestate while running around
Can test using dev mode -> dev tools -> disconnect. Might want to add logging while testing to see when VarData objs are created

This is strictly inferior to #29


How to add new Tab dynamically?

As mentioned in TABS directive documentation (https://github.com/valor-software/ng2-bootstrap/tree/development/components/tabs), tabs has 3 events - select, deselect and removed.
How to add new Tab dynamically? and is there a event available to do a functionality on onLoad kind of event?

Keep the tabs in a collection and display them with NgFor. Then you can simply add or remove items from the collection as needed.


Created allowlist feature

Created allowlist to add a list of users who are allowed to trigger the bot aside from the public members and the author of the PR.
This resolves #6

/merge


Recipe app

In this PR @edubew  and @shubhambhoyar077  did the following:

A login page.
A registration page.
A food list (with all CRUD implementation, except for 'update').
A recipes list (with all CRUD implementation, except for 'update').
A general shopping list view (all missing food for all your recipes and total price).
A list of all public recipes from other users with their names and total prices.

Project requirements

You should follow the layout of the wireframes provided. You should personalize the rest of the design including colors, typographies, spacings, etc.
Login page and registration page:

Should be built with Devise.

Food list (only for a group that has less than 3 members):

Should display a list of food added by the logged-in user as in the wireframe (display also quantity of a given food).
Should lead to a form that allows users to add new food.

Recipes list:
-Should display a list of recipes created by the logged-in user as in the wireframe.
-Should lead to recipe details.
-If the user is the owner of the recipe, should allow the user to delete it.
Public recipe list:
-Should display a list of all public recipes ordered by newest as in the wireframe.
-Should lead to recipe details.
Recipe details:
-Should display a toggle button that allows for a recipe to be made public or private.
-If the recipe is public or the user is the owner of the recipe, should display the recipe details as in the wireframe.
-If the user is the owner of the recipe, should lead to the form that allows the user to add new food.
General shopping list view (only for a group that has less than 3 members):
-Should show the list of food that is missing for all recipes of the logged-in user (compare the list of food for all recipes with the general food list of that user).
-Should count the total food items and total price of the missing food.
Make sure there are no N+1 queries happening.
Create a navigation menu that allows users to open all of the pages you created.
Write unit and integration tests.

Hi @brytebee,
Thanks for Approval. :smile:
We will add validation. :+1:


BETA APP CRASHES DURING LAUNCH

Beta app crashes EVERYTIME I launch it, I had to uninstall it...
It seems it is because i'm a Beta user: even after reinstalling the beta version, the app keeps crashing...
The app works when I quit the Beta and reinstall the public version.
My phone: Android 9 with MIUI 11 (Xiaomi).

java.lang.OutOfMemoryError
at android.graphics.Bitmap.nativeCreate(Native Method)
at android.graphics.Bitmap.createBitmap(Bitmap.java:1046)
at android.graphics.Bitmap.createBitmap(Bitmap.java:1000)
at android.graphics.Bitmap.createBitmap(Bitmap.java:950)
at android.graphics.Bitmap.createBitmap(Bitmap.java:911)
at com.tommasoberlose.anotherwidget.helpers.BitmapHelper.getBitmapFromView(BitmapHelper.kt:24)
at com.tommasoberlose.anotherwidget.helpers.BitmapHelper.getBitmapFromView$default(BitmapHelper.kt:16)
at com.tommasoberlose.anotherwidget.ui.widgets.MainWidget$Companion.generateWidgetView(MainWidget.kt:107)
at com.tommasoberlose.anotherwidget.ui.widgets.MainWidget$Companion.updateAppWidget$app_release(MainWidget.kt:100)
at com.tommasoberlose.anotherwidget.ui.widgets.MainWidget.onUpdate(MainWidget.kt:49)
at android.appwidget.AppWidgetProvider.onReceive(AppWidgetProvider.java:66)
at android.app.ActivityThread.handleReceiver(ActivityThread.java:3412)
at android.app.ActivityThread.access$1300(ActivityThread.java:200)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1684)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:201)
at android.app.ActivityThread.main(ActivityThread.java:6810)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:873)

Getting this now just after the most recent update (beta i believe) v2.0.5. OnePlus 7 Pro Android 10 OxygenOS 10.0.5.

Happens on 2.0.4 as well, the widged does not appear UNTILL added to the homescreen manually. OP5 with Android 9. Also the ADD button in app wasn't visible at least on first launch...

A new beta version of the app will be published asap.

Happens on 2.0.4 as well, the widged does not appear UNTILL added to the homescreen manually. OP5 with Android 9. Also the ADD button in app wasn't visible at least on first launch...

The "ADD" button is shown only when you add the widget from the launcher.

A new beta version of the app will be published asap.

The latest version updated on Play Store fixed the crash, and also allowed calendar events to update in a minute after calendar/event update on my OnePlus 7 Pro running Android 10 without need to manually refresh, and no need to disable battery optimisation at all. Seems fixed, great job!

A new beta version of the app will be published asap.

The latest version updated on Play Store fixed the crash, and also allowed calendar events to update in a minute after calendar/event update on my OnePlus 7 Pro running Android 10 without need to manually refresh, and no need to disable battery optimisation at all. Seems fixed, great job!

The new beta stills crash for me: java.lang.OutOfMemoryError...

A new beta version of the app will be published asap.

The latest version updated on Play Store fixed the crash, and also allowed calendar events to update in a minute after calendar/event update on my OnePlus 7 Pro running Android 10 without need to manually refresh, and no need to disable battery optimisation at all. Seems fixed, great job!

The new beta stills crash for me: java.lang.OutOfMemoryError...

I'm working on this problem. I can't figure out why on some devices the widget can't generate the view and throw the OutOfMemory exception.
I've just added a few log events in the latest beta version (code 74) and from now on you can check for any updates on #78.


tips in geoplot only works when column is passed

The tips argument in geoplot, which controls the list of attributes to be displayed when hover=True only works when col is passed. It'd be useful to have it work even when only geometries are being displayed (and hence col=None). This can be seen in L.825, where tips are only acted upon when col exists.

Hey can I take this one up as my hopefully to be "first" contribution to the group?

@djokester have at it, all pull requests are much appreciated.

Can you give me just a little broader description of what is required of me here?

I suggest you get familiar with how geoplot works in general. A good starting point as a user level is this notebook. There you'll see that, when you plot to the bokeh backend, there's an option to have attributes from the DataFrame display as you hover over the choropleth. That works when you have a choropleth (a variable being displayed with a color scheme). However, that option does not work when you simply plot the geometries. It'd be cool if it did. That's this ticket. Does it make sense?

@darribas Yes!

@darribas but dosen't col provide the key and entries that should be displayed when hover = True.
If col is empty. What should we display on hover.

@kris-singh col provides the column in the geotable to be used for the choropleth. What appears as you hover should be controlled by tips. I think that'd make the hover functionality much more flexible. If tips is not modified and col is passed, we can have the current default of showing that.

A PR addressing this issue was merged. Can this be closed?

Yes, this can be closed - thanks for flagging this.


declare_legacy cheatcode in cairo1 tests

We need to make declare_legacy cheatcode working in cairo1 and add integration tests for it.
This task being finished means

test which declares contract passes
test which fails to declare a contract provides proper error code

It should use old declare HintLocal logic


Minor Issues in the setup/deploy instructions

https://github.com/Alvearie/health-patterns/tree/main/clinical-ingestion/helm-charts/alvearie-ingestion
cd clinical-ingestion/helm-charts/alvearie-ingestion
should be
cd health-patterns/clinical-ingestion/helm-charts/alvearie-ingestion
https://github.com/Alvearie/health-patterns/tree/main/clinical-ingestion/helm-charts/alvearie-ingestion/charts/fhir#installation
cd clinical-ingestion/helm-charts/fhir
should be
cd health-patterns/clinical-ingestion/helm-charts/fhir
https://github.com/Alvearie/health-patterns/tree/main/clinical-ingestion/helm-charts/alvearie-ingestion/charts/fhir#using-the-chart
kubectl exec  -c fhir-server -- cat server.xml | grep -A2 BasicRealm
should be
kubectl exec  -c server -- cat server.xml | grep -A2 BasicRealm
https://github.com/Alvearie/health-patterns/tree/main/clinical-ingestion/helm-charts/alvearie-ingestion/charts/deid#installation
cd clinical-ingestion/helm-charts/deid
should be
cd health-patterns/clinical-ingestion/helm-charts/deid
https://github.com/Alvearie/health-patterns/tree/main/clinical-ingestion/helm-charts/alvearie-ingestion/charts/nifi-registry#installation
cd clinical-ingestion/helm-charts/nifi-registry
should be
cd health-patterns/clinical-ingestion/helm-charts/nifi-registry

I have updated the kubectl command to reflect the renaming of "fhir-server" to "server".
The other concerns I don't believe should be updated.  It is standard practice to assume you are already in the project the documentation is referring to (health-patterns) and all paths are relative to that.


Prevent stripping of format specifiers from -exec commands. (#1277)

This prevents MIEngine from stripping (what appear to be) format specifiers from debug console commands prefixed by -exec or backtick. Fixes #1277.
I'm afraid that I could not figure out how to write a test case, as there do not seem to be any tests cases for -exec commands, so I had nothing to go on. If someone can give me advice on writing a test case for this, I'd be happy to add one. In the mean time I tested it by hand; see the screenshot below in Visual Studio Code 1.64.2:

Thank you for taking the time to fix this. But this isn't the right spot to fix this problem. I believe what, you want to do is update StripFormatSpecifier to do:
            if (EngineUtils.IsConsoleExecCmd(exp, out string _, out string _))
            {
                return exp;
            }

This isn't the right spot to fix this problem. I believe what, you want to do is update StripFormatSpecifier

Thanks for reviewing. Your suggestion corresponds to my solution (2) in #1277, which I was not sure was safe, because AD7DebugSession.HandleEvaluateRequestAsync is not the only place where StripFormatSpecifier gets called. However, if you are confident that it's safe to modify StripFormatSpecifier like this, then I'm happy to give it a try, and accordingly I've updated the pull request to use your suggestion.

The continuous integration failure does not seem to be related to this pull request — you can see the same failure on #1280.

@gareth-rees: your changes look good to me
@WardenGnaw Do you know what is going on with the PR failure?
If I am reading the log correctly, the response looks right:
 <--   C (setVariable-8): {"command":"setVariable","arguments":{"name":"myint","value":"39+nonexistingint","variablesReference":1000},"seq":8,"type":"request"}

 --> R (setVariable-8): {"type":"response","request_seq":8,"success":false,"command":"setVariable","message":"error: <user expression 0>:1:4: use of undeclared identifier 'nonexistingint'\n39+nonexistingint\n   ^\n","body":{"error":{"id":1107,"format":"error: <user expression 0>:1:4: use of undeclared identifier 'nonexistingint'\n39+nonexistingint\n   ^\n"}},"seq":113}

Here is the test link in case this is helpful: https://github.com/microsoft/MIEngine/blob/86bf7c95ca5239c9aa6d8f2309bdc88a6761a202/test/CppTests/Tests/ExpressionTests.cs#L444

@gareth-rees: BTW: it looks like you still need to sign the CLA

@gareth-rees: BTW: it looks like you still need to sign the CLA

Yes, just waiting for my employer to agree. Should be able to sign it on Monday.

@gareth-rees: your changes look good to me
@WardenGnaw Do you know what is going on with the PR failure?
If I am reading the log correctly, the response looks right:
 <--   C (setVariable-8): {"command":"setVariable","arguments":{"name":"myint","value":"39+nonexistingint","variablesReference":1000},"seq":8,"type":"request"}

 --> R (setVariable-8): {"type":"response","request_seq":8,"success":false,"command":"setVariable","message":"error: <user expression 0>:1:4: use of undeclared identifier 'nonexistingint'\n39+nonexistingint\n   ^\n","body":{"error":{"id":1107,"format":"error: <user expression 0>:1:4: use of undeclared identifier 'nonexistingint'\n39+nonexistingint\n   ^\n"}},"seq":113}

Here is the test link in case this is helpful:
https://github.com/microsoft/MIEngine/blob/86bf7c95ca5239c9aa6d8f2309bdc88a6761a202/test/CppTests/Tests/ExpressionTests.cs#L444

Something changed within the build system that is causing this test to fail. It is on my backlog to investigate what changed.
This is also failing during our nightly builds: https://github.com/microsoft/MIEngine/runs/5312098531?check_suite_focus=true

I've signed the CLA. Sorry about the delay!

@gregg-miskelly You're welcome. Thanks for the quick review and merge.


Add button "Get it on F-Droid"

Please, add a button "Get it on F-Droid" with a PNG file from https://commons.wikimedia.org/wiki/File:Get_it_on_F-Droid.svg in your README.md file on GitHub with the appropriate link to the page of your app on F-Droid.

I like this idea +1

For reference implementation, see https://github.com/PanderMusubi/trickytripper/commit/9e0a1da3e9dfe164791f1cd6ad988ea8c61a9e6d


Test translation on GCP

With the data downloaded using the downloader script on a Google Cloud instance, test whether the translation code works for each of the datasets in Multinet v0.

https://github.com/ManifoldRG/MultiNet/pull/60


Google Hangouts Chat: auth on Heroku/Dokku nodes etc

Hello
I am testing BotKit with the Google Hangouts Chat Bot, and it working really well locally ! Good job ! (https://github.com/howdyai/botkit-starter-googlehangouts)
I am planning to deploy it on a Dokku/Heroku instance and I am hitting a wall:
I need to set to set the environment variable GOOGLE_APPLICATION_CREDENTIALS as a link to the google json auth file (like auth.json) but I don't want to put this file on git so I can't push it to Dokku.
The solution proposed by Google seems pretty easy to implement buy I don't know how to do this in my BotKit :)
Here is my code for another project using Google Hangouts Bot auth that is working well with that:
// load the environment variable with our keys
const creds = process.env.CREDS
if (!creds) {
  throw new Error('The $CREDS environment variable was not found!');
}
const keys = JSON.parse(creds)
const client = auth.fromJSON(keys)
client.scopes = ['https://www.googleapis.com/auth/chat.bot']

module.exports = google.chat({
  version: 'v1',
  auth: client
});

Do you have an idea ?
Thanks !

Hello
I have created a pull request that allow this behavior : #1543
Thanks !

Hi @bobman38, i'll take a look asap.
Thank you ;)

This will be in the next published version of Botkit.


Explicitly add the File backend for local storage

Local storage is an example where glance is adopted with a dummy backend.
While we decide what should be used as base use case, this patch fixes the local backend adoption by adding type:single, otherwise the webhook will deny the deployment, and we explicitly add the file config to avoid unexpected parsing behaviors.

/lgtm


Fixes to NCMC procedures and logging infrastructure

This PR includes a bunch of fixes to the NCMC infrastructure and some complementary upgrades/changes to the reporting utilities.
Ready to merge if travis tests pass.
Summary of features (see individual commit messages for more details)
Feature additions/changes

[x]  Cumulative work steps can be stored less frequently, or omitted. This saves gigabytes of disk space if this data is not necessary.
[x] Proposal probabilities are stored in reporters
[x] Salt identities are stored in reporters
[x] Added protection against infinite while loop in salt proposal
[x] Internal tracking of ProtonDrive properties has been improved
[x] Reporter tests including ions have been added
[x] The fully deprecated record module has been removed from this version on.
[x] Tests featuring netCDF have been made more robust to segmentation faults, which occur occasionally when running through py.test

Major Bugfixes

[x] Work values for saltswap proposals were not being set properly. This has been addressed in
04f7de1
[x] The saltswap proposal class no longer runs into an infinite while loop when point charges are not rounded correctly. 4844652

Codecov Report

Merging #122 into master will decrease coverage by 2.68%.
The diff coverage is 48.88%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   62.63%   59.95%   -2.69%
==========================================
  Files          38       36       -2
  Lines        5072     5072
==========================================
- Hits         3177     3041     -136
- Misses       1895     2031     +136

Impacted Files
Coverage Δ

protons/app/__init__.py
100% <ø> (ø)
:arrow_up:

protons/tests/test_samsreporter.py
22.72% <0%> (ø)
:arrow_up:

protons/tests/test_metadatareporter.py
35.89% <0%> (ø)
:arrow_up:

protons/app/samsreporter.py
95.45% <100%> (+1.83%)
:arrow_up:

protons/tests/test_simulation.py
100% <100%> (ø)
:arrow_up:

protons/tests/test_explicit.py
94.47% <100%> (+0.03%)
:arrow_up:

protons/app/metadatareporter.py
94.52% <100%> (+2.11%)
:arrow_up:

protons/tests/test_ncmcreporter.py
13.95% <5.37%> (-21.95%)
:arrow_down:

protons/tests/test_titrationreporter.py
12.56% <5.55%> (-1.28%)
:arrow_down:

protons/app/ncmcreporter.py
77.14% <51.16%> (-16.53%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d17a6...0743a2a. Read the comment docs.

Awesome! This is a lot to review, but let us know if you'd like someone to attempt to read through the changes carefully.

Thanks for taking a look! I will make the naming more consistent.