Mass Action Logs consuming 110% of the Data Storage on a Dev Org

Have Mass Action Scheduler running on a Dev Org and noticed the Mass Action Logs are consuming 110% of the data storage - 2700 logs.
@douglascayers
Attempted to delete Ids from dca_mass_action__Mass_Action_Log__c using WorkBench and getting an error saying
Dca_mass_action.MA_MassActionLogTrigger: Execution Of BeforeDelete Caused By: System.DmlException: Delete Failed. First Exception On Row 0 With Id A016g000005xgGqAAI; First Error: SELF_REFERENCE_FROM_TRIGGER, Object (id = A016g000005xgGq) Is Currently In Trigger Dca_mass_action.MA_MassActionLogTrigger, Therefore It Cannot Recursively Delete Itself: [] (dca_mass_action)
I can delete individual logs fine from the Mass Action Logs tab in Salesforce but not able to delete via WorkBench.
What is the recommended process to delete multiple Mass Action Logs at a time?
Is there a setting to set the max size of the Mass Action Log table?

OK figured it out

Delete the Child Records first via Workbench
SELECT Id FROM dca_mass_action__Mass_Action_Log__c where dca_mass_action__Parent_Log__c <> ''

Delete the Parent Records
SELECT Id FROM dca_mass_action__Mass_Action_Log__c

That did the trick.
Still curious if there is a Mass Action Log size limit that can be set, delete all logs via Salesforce option, and a way to disable/enable logging when want to debug something.
I'd be up for adding this functionality in a fork and sending you a PR if the functionality isn't already available.

@daveb-501commons that indeed would be a welcome feature.

A solution for log management is really required for an app like this which is intended for production environments. I'll probably be using a scheduled apex class to delete old log records, unless anyone has a better solution?

I'm using MAS to delete it's own logs @Garywoo

@JeroenSfdc Ah yes, I just realised I could do this. Are you using a flow to do it?
I've had issues cleaning up old records using flows in the past, but only when there are over 10k of them, and that was before I had a solution for batching them, which MAS now provides a friendlier method for.

@JeroenSfdc Ah yes, I just realised I could do this. Are you using a flow to do it?
I've had issues cleaning up old records using flows in the past, but only when there are over 10k of them, and that was before I had a solution for batching them, which MAS now provides a friendlier method for.

To be honest, I house-keep daily. In my VTO org I'll unlikely every go 10k on a single day...


feat: add more configuration options

There are many options currently set by constants.
This is limiting when applications want to override these for
application-specific networks.
Several interesting options are now overridable via the constructor:

heartbeatInterval
fanoutTTL
mcacheLength
mcacheGossip
seenTTL

These options are optional with fallback values defaulting to the prior "constant" values.

Codecov Report

Merging #165 (a3189ea) into master (751ea73) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   76.58%   76.58%
=======================================
  Files           2        2
  Lines        1905     1905
  Branches      144      142    -2
=======================================
  Hits         1459     1459
  Misses        446      446

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751ea73...a3189ea. Read the comment docs.


code-style modification: make ColumnLimit larger

What changes were proposed in this pull request?
The limitation of Column is set to 80 because the display device was too narrow 40 years ago.
The world changed,  the display became larger and the resolution ratio increased.
but we still keep this rule, it takes unnecessary changing lines and hurts code-looking, and downgrades the review experience.
so, I think making this limitation larger is reasonable.
I have talked about this with Hongze and some other developers, and we made an agreement on the number 120
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

I am good with the new 120-column limitation. Ping @rui-mo for the bridge.h changes since she has more backgrounds about the code there.

It seems that linters don't accept previous codes. Maybe we can start from C++ code (e.g. 80 -> 100) then force a reformat to see how many changes are needed.

I am good with the new 120-column limitation. Ping @rui-mo for the bridge.h changes since she has more backgrounds about the code there.

==
well


Fix crash in - [ARTiledImageView drawRect:], line 112

Version: 2.0.1 (2015.06.26) | net.artsy.artsy
Stacktrace
ARTiledImageView;drawRect:;ARTiledImageView.m;112
Reason
objc_msgSend() selector name: bounds
Link to HockeyApp

https://rink.hockeyapp.net/manage/apps/37029/crash_reasons/39027489

Closed in favour of #773.


dunst: 1.7.0 -> 1.7.1

Motivation for this change
dunst: 1.7.0 -> 1.7.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 145041 run on x86_64-linux 1

1 package built:

dunst


TURNClient.accept_peer() raises exception

TURNClient.accept_peer() seems to think its base class is BaseStream which has tup_to_sub() defined, however its base class is actually BaseProto which does not have this (nor likely subscribe() etc) which means that a call to accept_peer() crashes.

cheers, is fixed in the current branch but still need to finish a little more coding before its merged


doc(1000.yaml): add entries for 100 theorems

This is exhaustive.

[ ] depends on #20111
[ ] depends on #20112

bors d+

Thanks for the quick review! CI is green, so:
bors merge


Use ENV variable to name index by default

Is your feature request related to a problem? Please describe.
I'm always frustrated when I run the tests and my DEV index is reset (because I need real ElasticSearch index testing). So, I solved it after ~2 years by setting name pattern in an initializer. There is too many devs who has this problem and don't know about solution, especially when it's a dev who started using ES and just development.
Describe the solution you'd like
Would be fine to provide built-in patter of naming indexes that use something like this:
Chewy.settings = { prefix: Rails.env }

Describe alternatives you've considered
nothing
Additional context
nothing

I gues would be fine to do that not only for rails. If it is relevant, I can open a PR to solve it


A field in the workspaces window to add extra rules

Thank you so much for your work on this application. Just the one I was looking for. Though for the workspaces section, I was wondering if it were possible to add an extra field, to enable more flags.

For example, in my case I like to use persistent workspaces on my default monitor. An option to add that would be great!

Couldn't you just add your extra rules to the main config file?

Oh are you saying, if I will do something like:
workspace = 1, persistent:true
workspace = 2, persistent:true
workspace = 3, persistent:true

source = ~/.config/hypr/workspaces.conf
source = ~/.config/hypr/monitors.conf

The the rules from workspaces.conf will add to the existing rules? I thought the rules would get overwritten

We just include some lines from the workspaces.conf file to the hyprland.conf file. You're free to add whatever afterwards.

I just tried using nwg-shell. I installed everything, and setup persistent workspaces. I setup binds in hyprland config such that I can switch to those workspaces using split-workspaces. But when I use nwg-shell, I am unable to switch to the empty persistent workspaces even though they show up in the hyprland workspace pager. The same command works just fine with my old config. I checked the same by executing the command from the terminal, that works too. But through the keybind it does not, and only happens with nwg-shell. Any idea why that might happen?

I have no idea what persistent workspaces are.

Here is a link which explains persistent workspaces: https://github.com/hyprwm/Hyprland/issues/658. The workspaces have an option persistent:true, which lets the workspace live even when it is empty. Hope this makes it clear.

I think I found the issue, it seems that I am able to change the workspace, but the workspace pager is not getting updated when the workspace is empty and is not next to an occupied workspace. I can try to change the hyprland_workspaces.py and submit a PR. It should not affect the functionality in anyway, and makes sure that when persistent workspaces are used, the pager is updated correctly.

Sure, go ahead. Remember to describe your changes.


fix illegal return width for cmp operators in restricted bits analysis

@regehr pushed a test for this that crashes souper-check atleast in Debug build (some assertion failure in LLVM). I don't have a release build to test yet but i think it will crash release build as well down the line.
Can update you again on the results of release build if you prefer that. Otherwise, feel free to merge this.

nah, I don't care about release mode, just wanted something that triggers this bug, thanks!


Investigate errors in models perf pipeline as of morning of March 12th

@tt-asaigal has fixed the first issue - now we're looking for the current falcon problem

d1253da1d4e35270b370efe6b2d801ca196a9983 still has the GS issue for falcon, wormhole is clean
@skhorasganiTT I believe 41555da44366b8217dc4129292cc884faf7c98f4 is causing the WH issue, please check. These are API changes to the tensors
This is a run of 1 commit before 41555da44366b8217dc4129292cc884faf7c98f4 with @tt-asaigal 's fixes: https://github.com/tenstorrent-metal/tt-metal/actions/runs/8252265596

Reverting commit 5c3d4bf makes the WH failure go away @tt-asaigal @tt-rkim

We need that commit to fix another problem we were seeing

Taking a look after meeting

@tt-rkim can we close?

Yes


Healthy instances get marked as "unhealthy" and recreated.

Server version - Build from master
Steps to reproduce the problem:
Set up has 2 hosts.
Had a service with scale 15.
There were few instances in host1 and few in host2.
Stopped host1.
This resulted in existing instances in host1 being marked for "deletion" and new instances being created in host2 , so that all instances of the service are in host2.
Started host1.
When host1 got to "Active" state , I see the instances that are stuck in "removing" state getting removed.
But this also triggered few existing instances in host2 to be marked "unhealthy" , which triggered new instances to be created in host2.
After host1 went to "reconnecting" state and healthcheck triggered new instances to be created.

mysql> select id,name,state,health_state from instance where name like "%myhealth%";
+-----+------------------------+---------+--------------+
| id  | name                   | state   | health_state |
+-----+------------------------+---------+--------------+
| 224 | test494388_myhealth_1  | purged  | unhealthy    |
| 225 | test494388_myhealth_2  | purged  | unhealthy    |
| 226 | test494388_myhealth_3  | purged  | unhealthy    |
| 227 | test494388_myhealth_4  | purged  | unhealthy    |
| 228 | test494388_myhealth_5  | purging | unhealthy    |
| 229 | test494388_myhealth_6  | purged  | healthy      |
| 230 | test494388_myhealth_7  | purging | unhealthy    |
| 231 | test494388_myhealth_1  | purging | unhealthy    |
| 232 | test494388_myhealth_2  | purging | unhealthy    |
| 237 | test494388_myhealth_3  | running | healthy      |
| 238 | test494388_myhealth_4  | running | healthy      |
| 239 | test494388_myhealth_6  | running | healthy      |
| 240 | test494388_myhealth_8  | running | healthy      |
| 241 | test494388_myhealth_9  | purging | unhealthy    |
| 242 | test494388_myhealth_10 | running | healthy      |
| 243 | test494388_myhealth_11 | running | healthy      |
| 244 | test494388_myhealth_12 | purging | unhealthy    |
| 245 | test494388_myhealth_13 | purging | unhealthy    |
| 246 | test494388_myhealth_14 | running | healthy      |
| 247 | test494388_myhealth_15 | purging | unhealthy    |
| 248 | test494388_myhealth_16 | running | initializing |
| 249 | test494388_myhealth_17 | purging | initializing |
| 250 | test494388_myhealth_17 | running | healthy      |
| 251 | test494388_myhealth_18 | running | healthy      |
| 252 | test494388_myhealth_19 | running | healthy      |
| 253 | test494388_myhealth_20 | running | healthy      |
| 254 | test494388_myhealth_21 | running | healthy      |
| 255 | test494388_myhealth_22 | running | healthy      |
| 256 | test494388_myhealth_23 | running | healthy      |
+-----+------------------------+---------+--------------+
29 rows in set (0.00 sec)

After host1 went to "Active" state. I see 7 instances being recreated in host1.

mysql> select id,name,state,health_state from instance where name like "%myhealth%";

+-----+------------------------+---------+--------------+

| id  | name                   | state   | health_state |

+-----+------------------------+---------+--------------+

| 224 | test494388_myhealth_1  | purged  | unhealthy    |

| 225 | test494388_myhealth_2  | purged  | unhealthy    |

| 226 | test494388_myhealth_3  | purged  | unhealthy    |

| 227 | test494388_myhealth_4  | purged  | unhealthy    |

| 228 | test494388_myhealth_5  | purged  | unhealthy    |

| 229 | test494388_myhealth_6  | purged  | healthy      |

| 230 | test494388_myhealth_7  | purged  | unhealthy    |

| 231 | test494388_myhealth_1  | purged  | unhealthy    |

| 232 | test494388_myhealth_2  | purged  | unhealthy    |

| 237 | test494388_myhealth_3  | removed | unhealthy    |

| 238 | test494388_myhealth_4  | removed | unhealthy    |

| 239 | test494388_myhealth_6  | removed | unhealthy    |

| 240 | test494388_myhealth_8  | removed | unhealthy    |

| 241 | test494388_myhealth_9  | purged  | unhealthy    |

| 242 | test494388_myhealth_10 | removed | unhealthy    |

| 243 | test494388_myhealth_11 | removed | unhealthy    |

| 244 | test494388_myhealth_12 | purged  | unhealthy    |

| 245 | test494388_myhealth_13 | purged  | unhealthy    |

| 246 | test494388_myhealth_14 | removed | unhealthy    |

| 247 | test494388_myhealth_15 | purged  | unhealthy    |

| 248 | test494388_myhealth_16 | running | healthy      |

| 249 | test494388_myhealth_17 | purged  | initializing |

| 250 | test494388_myhealth_17 | running | healthy      |

| 251 | test494388_myhealth_18 | running | healthy      |

| 252 | test494388_myhealth_19 | running | healthy      |

| 253 | test494388_myhealth_20 | running | healthy      |

| 254 | test494388_myhealth_21 | running | healthy      |

| 255 | test494388_myhealth_22 | running | healthy      |

| 256 | test494388_myhealth_23 | running | healthy      |

| 265 | test494388_myhealth_1  | running | healthy      |

| 266 | test494388_myhealth_2  | running | healthy      |

| 267 | test494388_myhealth_3  | running | healthy      |

| 268 | test494388_myhealth_4  | running | healthy      |

| 269 | test494388_myhealth_5  | running | healthy      |

| 270 | test494388_myhealth_7  | running | healthy      |

| 271 | test494388_myhealth_9  | running | healthy      |

+-----+------------------------+---------+--------------+

But this also triggered few existing instances in host2 to be marked "unhealthy" , which triggered new instances to be created in host2.

Where was the heatlchecker for those instances, on host1 or host2?

Looked at the DB, instances were reported unhealthy by host id=2 (checked for instance 237 and 238)
mysql> select instance_id, host_id, reported_health from service_event where instance_id in (237,238) order by id;
+-------------+---------+-----------------+
| instance_id | host_id | reported_health |
+-------------+---------+-----------------+
|         237 |       2 | DOWN            |
|         237 |       2 | DOWN 1/2        |
|         237 |       2 | INIT            |
|         237 |       2 | UP              |
|         238 |       2 | INIT            |
|         238 |       2 | UP              |
|         237 |       2 | DOWN            |
|         238 |       2 | DOWN            |
+-------------+---------+-----------------+
host id=2 (I assume its host1? instances were running on host id=3, lets assume its host2) by some reason reported those instances as down. So the bug here would be - host1 went to disconnecting state, yet healthchecks running on it, weren't moved to host2. Should be fixed with https://github.com/rancher/cattle/pull/1043.
Please reopen if you see this bug again.

Tested with recent build:
I noticed the same behavior of healthy instances being recreated in the following scenario:
Set up with 2 hosts:
Started a service with scale 5 - "testhealthnow" . All instances reported "healthy" state.
Started another service with scale 10 - "yello1" .When instances for this instance is getting deployed , I saw that couple of instances of the service - "testhealthnow" being recreated.
Instance Id - 3 and 5 get marked "unhealthy" and gets recreated.
mysql> select id,health_state,state,name from instance;
+----+--------------+---------+-------------------------+
| id | health_state | state   | name                    |
+----+--------------+---------+-------------------------+
|  1 | healthy      | running | Default_testhealthnow_1 |
|  2 | healthy      | running | Default_testhealthnow_2 |
|  3 | healthy      | purged  | Default_testhealthnow_3 |
|  4 | healthy      | running | Default_testhealthnow_4 |
|  5 | healthy      | purged  | Default_testhealthnow_5 |
|  6 | NULL         | running | Network Agent           |
|  7 | NULL         | running | Network Agent           |
|  8 | healthy      | running | Default_yello1_1        |
|  9 | healthy      | running | Default_yello1_2        |
| 10 | healthy      | running | Default_yello1_3        |
| 11 | healthy      | running | Default_yello1_4        |
| 12 | healthy      | running | Default_yello1_5        |
| 13 | healthy      | running | Default_yello1_6        |
| 14 | healthy      | running | Default_yello1_7        |
| 15 | healthy      | running | Default_yello1_8        |
| 16 | healthy      | running | Default_yello1_9        |
| 17 | healthy      | running | Default_yello1_10       |
| 18 | healthy      | running | Default_testhealthnow_6 |
| 19 | healthy      | running | Default_testhealthnow_7 |
| 20 | healthy      | running | Default_yello2_1        |
| 21 | healthy      | running | Default_yello2_2        |
| 22 | healthy      | running | Default_yello2_3        |
| 23 | healthy      | running | Default_yello2_4        |
| 24 | healthy      | running | Default_yello2_5        |
| 25 | healthy      | running | Default_yello2_6        |
| 26 | healthy      | running | Default_yello2_7        |
| 27 | healthy      | running | Default_yello2_8        |
| 28 | healthy      | running | Default_yello2_9        |
| 29 | healthy      | running | Default_yello2_10       |
+----+--------------+---------+-------------------------+
29 rows in set (0.00 sec)

Figured out the reason why it happens. By some reason, haproxy reports INIT state for the same instance twice over time:
mysql> select id, reported_health, host_id, created from service_event where instance_id=3 order by id;
+----+-----------------+---------+---------------------+
| id | reported_health | host_id | created             |
+----+-----------------+---------+---------------------+
|  2 | DOWN            |       2 | 2015-11-12 03:17:04 |
| 13 | DOWN 1/2        |       2 | 2015-11-12 03:20:07 |
| 15 | INIT            |       2 | 2015-11-12 03:20:09 |
| 16 | UP              |       2 | 2015-11-12 03:20:11 |
| 18 | INIT            |       2 | 2015-11-12 03:20:43 |
| 21 | UP              |       2 | 2015-11-12 03:20:45 |
+----+-----------------+---------+---------------------+
6 rows in set (0.00 sec)
INIT reported state at 03:20:43 is considered as unhealthy, and that triggers instance removal by the service reconcile.
mysql> select process_name, start_time from process_instance where resource_id=3 and resource_type='instance';
+--------------------------+---------------------+
| process_name             | start_time          |
+--------------------------+---------------------+
| instance.create          | 2015-11-12 03:16:05 |
| instance.updatehealthy   | 2015-11-12 03:20:11 |
| instance.updateunhealthy | 2015-11-12 03:20:43 |
| instance.updatehealthy   | 2015-11-12 03:20:45 |
| instance.remove          | 2015-11-12 03:20:57 |
| instance.stop            | 2015-11-12 03:20:57 |
| instance.remove          | 2015-11-12 03:20:59 |
| instance.purge           | 2015-11-12 03:22:47 |
+--------------------------+---------------------+
8 rows in set (0.00 sec)
mysql> select id, process_name, start_time from process_instance where resource_id=2 and resource_type='service';
+-----+------------------+---------------------+
| id  | process_name     | start_time          |
+-----+------------------+---------------------+
|  76 | service.create   | 2015-11-12 03:16:02 |
|  77 | service.activate | 2015-11-12 03:16:05 |
| 196 | service.update   | 2015-11-12 03:20:43 |
| 428 | service.update   | 2015-11-12 04:17:13 |
| 571 | service.update   | 2015-11-12 04:19:37 |
+-----+------------------+---------------------+
INIT health state reported twice can be caused by many reasons - healtcheck go process restart, agent instance restart. Just reproduced this issue very easily:

Have just one host in the setup.
Start service with one instance, healtcheck enabled.
Wait for the healthcheck to become green.
Restart the network agent that does the healtcheck. Your container created on step 2) will get restarted.

Very good bug, very worth fixing

Sangeetha, fix is in master. Could you please run 2 tests - one that I've provided (network agent restart), and another yours. See if any of it results in the same kind of failure.

Tested with build from master:
All the scenarios mentioned in the bug work as expected and does not result in  marking healthy instances as "unhealthy".


Update llama-index-vector-stores-lantern's index method to 'lantern_hnsw' to maintain compatibility with latest Lantern builds

Description:
Updates llama-index-vector-stores-lantern integration's  index method / postgres access_method from hnsw to  lantern_hnsw, this change is needed due to LanternDB removing support for 'hnsw' in early February 2024.
The current version of llama_index is only compatible with Lantern's
They've also just updated their docs with the change.
Why?
Due to LanternDB now expecting lantern_hnsw, the current version of llama-index-vector-stores-lantern is only compatible with LanternDB builds up to v0.1.1  (while the latest Lantern build is now at 0.2.4)
This PR fixes https://github.com/run-llama/llama_index/issues/13115.

New Package?
Not applicable
Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[X] Yes

Type of Change

[X] Bug fix (non-breaking change which fixes an issue)

Note - this PR seems be classified as size:L due to the addition of tests.  However I only changed 1 line of core module code.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[X] Added new unit/integration tests
[X] I stared at the code and made sure it makes sense

Testing:

I attempted to import my fork of the repo into my own vector-db project that uses Lantern to test that my change works with the lantern_hnsw index method expected by the latest build of LanternDB. (by importing repo into my requirments.txt file)

Unfortunately,  I was unable to figure out how to ensure my local fork of llama_index was being used specifically for the 'llama-index-vector-stores-lantern' python module.
I was able to import my fork as -e git+https://github.com/nataliachodelski/llama_index.git#egg=llama-index but this doesn't seem to update the code being used for the llama-index-vector-stores-lantern module.
I also tried as -e git+https://github.com/nataliachodelski/llama_index.git#egg=llama-index-vector-stores-lantern but this resulted in an error.

I also added some unit tests for llama-index-vector-stores-lantern, as I noticed there were none.

I wasn't sure how to run these in the llama_index project with an active connection to postgres, so some of the tests I added were skipped when run locally (my project is running in a kubernetes cluster, and without being able to import my repo into my project in a usable way, I don't know how to run it against the postgres database within our kubernetes cluster)
If the tests are run with a postgres connection to a database running the latest Lantern, I believe they should reveal if the hnsw error if still present, as I added 2 unit tests that insert nodes into the database

Suggested Checklist:

[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[X] My changes generate no new warnings
[X] I have attempted added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I ran make format; make lint to appease the lint gods

Just wanted to update that I've tested the 0.1.3 version of llama-index-vector-stores-lantern in my project with the latest lanterndata/lantern build (which is now lantern v0.2.5and can confirm that this PR has fixed the incompatibility issue between llama_index and lantern builds > v0.1.1.


Dashboard worker tab, 500 internal server error

What happened:
Launched a Dask cluster using dask-mpi.  Connecting to it from a Jupyter notebook, I note that the client reports Memory: 0 B.  The workflow is fine, but the dashboard worker tab returns 500 internal server error.  The logs show that the problem is a ZeroDivisionError:
File "/usr/local/lib/python3.7/dist-packages/distributed/dashboard/components/scheduler.py", line 1947, in update
    ) / sum(ws.memory_limit for ws in self.scheduler.workers.values())
ZeroDivisionError: division by zero

What you expected to happen:
Worker tab with lovingly rendered worker information, not 500 Internal Server Error message of cold indifference. :)
Minimal Complete Verifiable Example:
This is happening in a supercomputer deployment.  I can try to replicate the setup at least with a docker-compose setup if necessary.  Or if debugging in situ would help, we could talk access, but I'm guessing the 0 B and traceback may be enough to track things down.
Anything else we need to know?:
Full error log/traceback:
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/distributed/utils.py", line 656, in log_errors
    yield
  File "/usr/local/lib/python3.7/dist-packages/distributed/dashboard/components/scheduler.py", line 2022, in workers_doc
    table.update()
  File "/usr/local/lib/python3.7/dist-packages/bokeh/core/property/validation.py", line 93, in func
    return input_function(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/distributed/dashboard/components/scheduler.py", line 1947, in update
    ) / sum(ws.memory_limit for ws in self.scheduler.workers.values())
ZeroDivisionError: division by zero
tornado.application - ERROR - Uncaught exception GET /workers (<IP_ADDRESS>)
HTTPServerRequest(protocol='http', host='jupyter.nersc.gov', method='GET', uri='/workers', version='HTTP/1.1', remote_ip='<IP_ADDRESS>')
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/tornado/web.py", line 1703, in _execute
    result = await result
  File "/usr/local/lib/python3.7/dist-packages/bokeh/server/views/doc_handler.py", line 52, in get
    session = await self.get_session()
  File "/usr/local/lib/python3.7/dist-packages/bokeh/server/views/session_handler.py", line 120, in get_session
    session = await self.application_context.create_session_if_needed(session_id, self.request, token)
  File "/usr/local/lib/python3.7/dist-packages/bokeh/server/contexts.py", line 218, in create_session_if_needed
    self._application.initialize_document(doc)
  File "/usr/local/lib/python3.7/dist-packages/bokeh/application/application.py", line 171, in initialize_document
    h.modify_document(doc)
  File "/usr/local/lib/python3.7/dist-packages/bokeh/application/handlers/function.py", line 132, in modify_document
    self._func(doc)
  File "/usr/local/lib/python3.7/dist-packages/distributed/dashboard/components/scheduler.py", line 2022, in workers_doc
    table.update()
  File "/usr/local/lib/python3.7/dist-packages/bokeh/core/property/validation.py", line 93, in func
    return input_function(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/distributed/dashboard/components/scheduler.py", line 1947, in update
    ) / sum(ws.memory_limit for ws in self.scheduler.workers.values())
ZeroDivisionError: division by zero

Environment:

Dask version: 2.21.0
Python version: 3.7.3
Operating System: Debian 10.4 in Docker
Install method (conda, pip, source): pip

Full pip freeze:
asn1crypto==0.24.0
astropy==4.0.1.post1
backcall==0.2.0
bokeh==2.1.1
click==7.1.2
cloudpickle==1.5.0
cryptography==2.6.1
cycler==0.10.0
dask==2.21.0
dask-mpi==2.0.0
decorator==4.4.2
distributed==2.21.0
entrypoints==0.3
fitsio==1.0.5
fsspec==0.7.4
HeapDict==1.0.1
ipykernel==5.3.3
ipython==7.16.1
ipython-genutils==0.2.0
jedi==0.17.2
Jinja2==2.11.2
jupyter-client==6.1.6
jupyter-core==4.6.3
keyring==17.1.1
keyrings.alt==3.1.1
kiwisolver==1.2.0
locket==0.2.0
MarkupSafe==1.1.1
matplotlib==3.3.0
mpi4py==3.0.3
msgpack==1.0.0
numexpr==2.7.1
numpy==1.19.0
packaging==20.4
pandas==1.0.5
parso==0.7.0
partd==1.1.0
pexpect==4.8.0
pickleshare==0.7.5
Pillow==7.2.0
prompt-toolkit==3.0.5
psutil==5.7.2
ptyprocess==0.6.0
pycrypto==2.6.1
Pygments==2.6.1
PyGObject==3.30.4
pyparsing==2.4.7
python-dateutil==2.8.1
python3-customs==0.1.0
python3-customs-mods==0.1.0
python3-modster==0.1.0
python3-nerscjson==0.9
pytz==2020.1
pyxdg==0.25
PyYAML==5.3.1
pyzmq==19.0.1
SecretStorage==2.3.1
six==1.12.0
sortedcontainers==2.2.2
tables==3.6.1
tblib==1.6.0
toolz==0.10.0
tornado==6.0.4
traitlets==4.3.3
typing-extensions==<IP_ADDRESS>
wcwidth==0.2.5
zict==2.0.0

Worker tab with lovingly rendered worker information, not 500 Internal Server Error message of cold indifference. :)

:)
@jsignell @jacobtomlinson any interest?
This is in the WorkerTable.  The easiest change here would be to add an or 1 to the end of the sum computation before dividing.
There might be more clever things we could do though, like blank out the cell.

I can take a look.


Smartypants disable can't find the pegdown processor

Error: java.lang.NoClassDefFoundError: org/pegdown/PegDownProcessor

Are you running OT using the dita command? This error comes when the classpath is not set up correctly.

Yes, using dita command. Transformed with Oxygen and it worked.

The probable cause for this has been fixed in 26f8cc5025bae4be9893017d30eca17e7fb91408


Tweaks to release candidate script, mainly to fix building Windows MS…

…I installer

Commit 5061ed004f updated the SBT native packager plugin we use to
build artifacts like the RPM and MSI installers. That plugin update
changed where it looks for the candle.exe and light.exe executables
used to build the MSI, so we need to change how we modify WiX so that
it runs with wine.
Removes the installation of .NET 4.5. It is unclear why that was
originally needed, but it now causes the MSI build to fail with it
installed. Perhaps building the container now installs an updated
version of wine that comes with a working .NET version
Fixes a typo when displaying a git clone command in the release
candidate script
Adds sbt-native-packager "maintainer" option globally rather than just
for RPM and Windows to remove "missing maintainer" warning when
building zip/tar
Modifies release candidate script to display available signing keys
for ease of use. Required moving the gpg timeout change to earlier in
the script

DAFFODIL-2428

+1 as a top-level "Conversation" comment


Adding YAML support

Need to add YAML configuration file support to define layers structure.

Define structure that users use to define their structure according to needs.
Structure should arbitrary but must have a unique name for each layer.

Build a module that exports an object with a defined API to support:

Reading from an existing YAML file
Creating a YAML file and saving it
Modifying an existing YAML file
Displaying the layers structure defined by a YAML file

please checkout this line:
https://github.com/hagaika/Configs-dev/blob/e01bd0c3975d5c055e75c7d1837e68aaaf01213c/configs/yaml_sample.py#L39

could also be here:
https://github.com/hagaika/Configs-dev/blob/e01bd0c3975d5c055e75c7d1837e68aaaf01213c/configs/yaml_sample.py#L61-L64


kubernetes controller and agent keeps restarting

Rancher Version: 0.63.1
Docker Version:1.10.2
OS: CentOs 7
Steps to Reproduce: 1. change to Kubernetes environment 2. add a host
Results:  The kubernetes controller and agents keeps restarting again and again.
** error logs in controller: **
E0315 17:55:20.929428       1 nodecontroller.go:227] Error monitoring node status: couldn't get version/kind; json parse error: json: cannot unmarshal string into Go value of type struct { APIVersion string "json:"apiVersion,omitempty""; Kind string "json:"kind,omitempty"" }
E0315 17:55:20.929855       1 controllermanager.go:233] Failed to get api versions from server: unexpected error: invalid character '<' looking for beginning of value
error logs in agent：
time="2016-03-15T17:51:18Z" level=info msg="Connecting to event stream." url="ws://master/api/v1/services?watch=true"
time="2016-03-15T17:51:18Z" level=warning msg="Error connecting to ws://master/api/v1/services?watch=true. Try 0 of 6. Will wait 1 seconds and try again. Error: &errors.errorString{s:"websocket: bad handshake"}"
time="2016-03-15T17:51:18Z" level=info msg="Initializing event router" workerCount=50
time="2016-03-15T17:51:18Z" level=info msg="Connection established"
time="2016-03-15T17:51:19Z" level=warning msg="Error connecting to ws://master/api/v1/services?watch=true. Try 1 of 6. Will wait 2 seconds and try again. Error: &errors.errorString{s:"websocket: bad handshake"}"
time="2016-03-15T17:51:21Z" level=warning msg="Error connecting to ws://master/api/v1/services?watch=true. Try 2 of 6. Will wait 4 seconds and try again. Error: &errors.errorString{s:"websocket: bad handshake"}"
time="2016-03-15T17:51:25Z" level=warning msg="Error connecting to ws://master/api/v1/services?watch=true. Try 3 of 6. Will wait 8 seconds and try again. Error: &errors.errorString{s:"websocket: bad handshake"}"
time="2016-03-15T17:51:26Z" level=info msg="Received event: Name: compute.instance.providelabels, Event Id: 64185e51-f862-4600-92e3-7380231ab730, Resource Id: 1ihm51"
time="2016-03-15T17:51:33Z" level=warning msg="Error connecting to ws://master/api/v1/services?watch=true. Try 4 of 6. Will wait 16 seconds and try again. Error: &errors.errorString{s:"websocket: bad handshake"}"
time="2016-03-15T17:51:39Z" level=info msg="Received event: Name: compute.instance.providelabels, Event Id: 84a82519-4cd3-44a4-8ab7-093f7d43dfef, Resource Id: 1ihm51"
Expected:
The host can be added successfully and the kubernetes containers can be started successfully.

Rancher Version: 0.63.1
Docker version 1.10.3, build 20f81dd
CentOS Linux release 7.2.1511 (Core)
I am able to add a host successfully to a kubernetes environment.
Controller and agent start successfully.
I am also able to deploy service - "K8s Example Guestbook" from catalog successfully.

@tyhoho Do you have a fresh setup or an upgraded setup?
Did you add a new k8s environment or did you change the default one to k8s?

@deniseschannon I used to have an old version of rancher, then I stopped and deleted the old version rancher containers, and begin to install the new version.
After installing, I add a K8s env, and set it as default one, and switch current env to it.
ps: uname -a.
Linux localhost 3.10.0-327.10.1.el7.x86_64 #1 SMP Tue Feb 16 17:03:50 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

@tyhoho Would you be willing to test out v1.0.0-rc1 to see if you are still facing the same k8s issues? We are preparing to GA and would love our community to test out our release candidate (esp if they are doing a fresh install).
We haven't been able to reproduce your issue.

@tyhoho We've made a lot of improvements in k8s in the last couple of releases. If you could test out v1.1.0-dev2 and see if you still have issues, then please re-open.


RPG Maker 2000/2003 Games via EasyRPG Player (Yume Nikki)

Project link: https://github.com/EasyRPG/Player
Project license: GPLv3
Does it work on 64-bit only Linux: YES
Is source code available?: YES
Is source code stored in Git?: YES
List of Steam AppIds of supported games:

https://steamdb.info/app/650700/
There may be more, but I'm only aware of Yume Nikki

Additional information
Yume Nikki is free on Steam. I can personally confirm that EasyRPG Player works flawlessly with this game, as well as not requiring the RTP package (default RPG Maker assets) as it's already prepackaged with Yume Nikki.
For any games that require the RTP package (which uses a non-free license), EasyRPG made a replacement package with freely licensed assets (https://github.com/EasyRPG/RTP). However, I doubt any RPG Maker 2000/2003 games on Steam wouldn't already package it with the game as it would require an external download.
Running the games themselves are pretty straightforward (running "easyrpg-player" in the game's directory).

Here's a few more potential games for this engine:
Ara Fell Demo https://steamdb.info/app/441750/
DEEP 8 https://steamdb.info/app/1037460/
Desolate City: The Bloody Dawn Enhanced Edition https://steamdb.info/app/965410/
Fantasya Final Definitiva REMAKE https://steamdb.info/app/656120/
Firon https://steamdb.info/app/1024250/
GALER: Plague of Heroes https://steamdb.info/app/508330/
Grimm's Hollow https://steamdb.info/app/1170880/
Island sky RPG https://steamdb.info/app/955730/
Ludu https://steamdb.info/app/563400/
LunarLux Chapter 1 https://steamdb.info/app/1258970/
Melon Journey 2 https://steamdb.info/app/1074030/
Metal Quest https://steamdb.info/app/754300/
Metallic Metronome https://steamdb.info/app/1260830/
Mystic Ruin: A New Dawn https://steamdb.info/app/1203950/
Nyanco Project https://steamdb.info/app/1122290/
Orpheus https://steamdb.info/app/959960/
Super Crystal Hunter https://steamdb.info/app/1208460/
Tales from Zilmurik https://steamdb.info/app/1423610/
Three Treason Theories RPG https://steamdb.info/app/955850/
TinkerQuarry https://steamdb.info/app/651280/
Toymaker https://steamdb.info/app/607780/
There's undoubtedly more, RPG Maker is popular.

Looks like it may make sense for this to be created as a "default" engine, similar to scummvm or dosbox-staging, where lux does not have each one defined, but you can pick from the default list, including easyrpg player.

Added in https://github.com/luxtorpeda-dev/packages/pull/391


Create Channels page needs animated GIFs for mobile app workflows

Context
Add visuals and short animated GIFs on the Create Channels page to help visual learners learn how to perform tasks using the Mattermost mobile app.
Parent Issue: #6657
Docs Request

Add appropriate visuals/GIFs for the To create a public or private channel sub-section under the mobile app tab.
Add appropriate visuals/GIFs for the To start a direct or group message sub-section under the mobile app tab.

Additional Notes

Use the latest Mattermost mobile app and the standard Mattermost Denim theme to capture all workflows.
Avoid drawing lines, arrows, boxes, or callouts on images.
Don't forget to include ALT Text descriptions for all new image assets.
Use existing docs pages with images as a starting point for code guidance. The Docs team can help provide RST syntax support for publication.
Save static image files in PNG format within the docs repository's /images directory.

QA Validation Criteria
In a generated docs preview:

Visiting the docs page results in 4 new mobile-specific screenshots in each subsection from the Mobile tab.

@cwarnermm Please assign this issue to me. Thanks.


It is possible to to submit the form (not using the model) ?

I can do the "regular" submit using :
<form method="post" action="#wathever" name="vm.form" novalidate>
    <formly-form model="vm.model" options="vm.options" form="vm.form" fields="vm.fields">
                <button class="btn btn-info" type="submit">Send</button>
    </formly-form>
</form>

But, the data sent are not correct, eg:
"formly_form_horizontalInput_street_0" => "somewhere"
"formly_form_horizontalInput_postal_1" => "45910"
"formly_form_horizontalInput_city_2" => "Over the rainbow"

which should be :
"street" => "somewhere"
"postal" => "45910"
"city" => "Over the rainbow"

How can I send the correct data via "regular" submit (not AJAX powered) ?

Do you mind creating an example of what you're trying to accomplish? Please follow the instructions here: http://help.angular-formly.com
This will make it easier for you to get help. Because the github issues are reserved for bug reports and feature requests, I'm going to go ahead and close this issue. See you on chat! Thanks!


[TreeView] TreeItem (v5) can not be made draggable using react-dnd

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
The v5 version  of the TreeItem component can not be made draggable using react-dnd.
Expected Behavior 🤔
It should be possible to make the v5 version of the TreeItem component draggable using react-dnd.
Steps to Reproduce 🕹
Steps:

Got to v5 demo: https://codesandbox.io/s/mui-v5-treeview-react-dnd-of9rt?file=/src/Demo.tsx
Try to drag tree items around.
Nothing happens.
Then go to v4 demo: https://codesandbox.io/s/mui-v4-treeview-react-dnd-5rb54?file=/src/Demo.tsx
Try to drag tree items around.
Works as expected.

Both demos are backed by the same DnD implementation, only the underyling MUI components have changed.

Context 🔦
When I upgraded from v4 to v5, the DnD functionality of my componentes backed by the TreeView component got broken.
So it seems obvious that the implementation of the TreeView in v5 breaks the way how I have used react-dnd to make my trees draggable. I don't know if this is a bug or I am doing somehting wrong. Any guidance how I might solve this issue would be appreciated.
Your Environment 🌎

`npx @mui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

I'm closing for #21474

@sebastianfrey If you can identify how to fix this with react-dnd, and the fix is lightweight, then we would be happy to review a PR. Now, I suspect that it's not possible, that the integration won't be great, so I have moved the request to the built-in issue feature request.

@oliviertassinari Ok, I did further research and this seems quite complex.
First of all, the reported behavior occurs only in Chromium based browsers. In Firefox everything works as expected.
When you start dragging in the v5 demo, the TreeItem gets immediately re-rendered in the DOM and so the ref passed to react-dnd has changed. I don't know why this happens, but I guess this has something to do with the switch from makeStyles to styled API.
After I have noticed that, I searched through the issues of react-dnd and stumbled up on https://github.com/react-dnd/react-dnd/issues/2177, which describes exactly the problem I am facing.
There is also a workaround available, which might  solve the problem: https://github.com/react-dnd/react-dnd/issues/2177#issuecomment-607171231. (I haven't tried it yet in my environment)

Unfortunately https://github.com/react-dnd/react-dnd/issues/2177#issuecomment-607171231 did not solve my problem. So I built the same demo using native dnd events:
https://codesandbox.io/s/mui-v5-treeview-native-dnd-forked-73588?file=/src/Demo.tsx.
But this also did not work...
Than, after digging further through the TreeView components source code, I think I have identified the problematic line here:
https://github.com/mui-org/material-ui/blob/3f58dd9208c5aa8daed74c74d97cd63c2c35a785/packages/mui-lab/src/TreeItem/TreeItem.js#L267
When this focus call is wrapped by setTImeout, dragging in chrome works as expected:
diff --git a/packages/mui-lab/src/TreeItem/TreeItem.js b/packages/mui-lab/src/TreeItem/TreeItem.js
index c4322e9d6c..1d8f8b3d59 100644
--- a/packages/mui-lab/src/TreeItem/TreeItem.js
+++ b/packages/mui-lab/src/TreeItem/TreeItem.js
@@ -262,15 +262,17 @@ const TreeItem = React.forwardRef(function TreeItem(inProps, ref) {
   }

   function handleFocus(event) {
-    // DOM focus stays on the tree which manages focus with aria-activedescendant
-    if (event.target === event.currentTarget) {
-      ownerDocument(event.target).getElementById(treeId).focus({ preventScroll: true });
-    }
+    setTimeout(() => {
+      // DOM focus stays on the tree which manages focus with aria-activedescendant
+      if (event.target === event.currentTarget) {
+        ownerDocument(event.target).getElementById(treeId).focus({ preventScroll: true });
+      }

-    const unfocusable = !disabledItemsFocusable && disabled;
-    if (!focused && event.currentTarget === event.target && !unfocusable) {
-      focus(event, nodeId);
-    }
+      const unfocusable = !disabledItemsFocusable && disabled;
+      if (!focused && event.currentTarget === event.target && !unfocusable) {
+        focus(event, nodeId);
+      }
+    });

Here is an update working demo, which leverages the above solution:
https://codesandbox.io/s/mui-v5-treeview-react-dnd-fix-ul2l8
When this solution seems applicable for you, I will soon provide a PR.

It makes me think of https://github.com/mui-org/material-ui/issues/24480#issuecomment-762220427. I wouldn't trust any new setTimeout. Let's wait for MUI to hire somebody to own this component. Nobody has the bandwidth to properly review changes yet. Q1 2022 shuod do it.

@oliviertassinari You're right, setTimeout is not ideal. While it seems to fix the DnD functionality, it breaks keyboard navigation and focus management.

I actually find a hack to make it work.
It probably have some consequences on focus system but it is fine for my use case.
I share it without any guarantee that it work for other cases.
I just register a focusin event on TreeItem dom ref to stop propagation of this event.
  const ref = useCallback((elt: Element) => {
    elt?.addEventListener('focusin', (e) => {
      // Disable Treeview focus system which make draggable on TreeIten unusable
      // see https://github.com/mui-org/material-ui/issues/29518
      e.stopImmediatePropagation();
    })
    drag(elt);
  }, [drag])

  return <TreeItem
        ref={ref}
        draggable={true}
        onDragStart={onDragStart}
        onDragEnd={onDragEnd}
        ....

I actually find a hack to make it work. It probably have some consequences on focus system but it is fine for my use case. I share it without any guarantee that it work for other cases.
I just register a focusin event on TreeItem dom ref to stop propagation of this event.
  const ref = useCallback((elt: Element) => {
    elt?.addEventListener('focusin', (e) => {
      // Disable Treeview focus system which make draggable on TreeIten unusable
      // see https://github.com/mui-org/material-ui/issues/29518
      e.stopImmediatePropagation();
    })
    drag(elt);
  }, [drag])

  return <TreeItem
        ref={ref}
        draggable={true}
        onDragStart={onDragStart}
        onDragEnd={onDragEnd}
        ....

Great! Thank you dude. You saved my time.

I actually find a hack to make it work. It probably have some consequences on focus system but it is fine for my use case. I share it without any guarantee that it work for other cases.
I just register a focusin event on TreeItem dom ref to stop propagation of this event.
  const ref = useCallback((elt: Element) => {
    elt?.addEventListener('focusin', (e) => {
      // Disable Treeview focus system which make draggable on TreeIten unusable
      // see https://github.com/mui-org/material-ui/issues/29518
      e.stopImmediatePropagation();
    })
    drag(elt);
  }, [drag])

  return <TreeItem
        ref={ref}
        draggable={true}
        onDragStart={onDragStart}
        onDragEnd={onDragEnd}
        ....

onFocusCapture works.
const DraggableTreeItem = React.forwardRef(function DraggableTreeItemComponent(
  props: TreeItemProps
) {
  return (
    <TreeItem
      ContentComponent={DraggableTreeItemContent}
      onFocusCapture={(e) => e.stopPropagation()}
      {...props}
    />
  );
});

I actually find a hack to make it work. It probably have some consequences on focus system but it is fine for my use case. I share it without any guarantee that it work for other cases.
I just register a focusin event on TreeItem dom ref to stop propagation of this event.
  const ref = useCallback((elt: Element) => {
    elt?.addEventListener('focusin', (e) => {
      // Disable Treeview focus system which make draggable on TreeIten unusable
      // see https://github.com/mui-org/material-ui/issues/29518
      e.stopImmediatePropagation();
    })
    drag(elt);
  }, [drag])

  return <TreeItem
        ref={ref}
        draggable={true}
        onDragStart={onDragStart}
        onDragEnd={onDragEnd}
        ....

However, this would invalidate the keyboard navigation behaviour.


Update http4s-client, http4s-dsl, ... to 0.23.5

Updates

org.http4s:http4s-client
org.http4s:http4s-dsl
org.http4s:http4s-server

from 0.23.0 to 0.23.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-patch

Superseded by #196.


Adds a more readable,idiomatic and single loop solution for 42. Trapping Rain Water in Kotlin

File(s) Modified: 42-Trapping-Rain-Water.kt
Language(s) Used: Kotlin
Submission URL: _https://leetcode.com/submissions/detail/783610987/_

Thanks, @t3chkid!


Add initial TAA acceptance admin routes

Codecov Report

Merging #144 into master will decrease coverage by 0.11%.
The diff coverage is 56.06%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   73.46%   73.35%   -0.12%
==========================================
  Files         188      189       +1
  Lines        8220     8283      +63
==========================================
+ Hits         6039     6076      +37
- Misses       2181     2207      +26

Apologies; I should have an opportunity to test this in the near future.


Sync with Resolver/polyfills/require.js

I don't know which version is better, but it should sync with Resolver/polyfills/require.js: 168
    // keep args in sync with with defineModuleCode in
    // packager/react-packager/src/Resolver/index.js
    // and packager/react-packager/src/ModuleGraph/worker.js
    factory(global, require, moduleObject, exports, dependencyMap);

Hi, can you please provide more details about the change, why it is needed, and what you have done to test it and avoid breaking things?

@ericvicenti
I have update the test spec.
ModuleGraph is Not in used yet, but the code it yield is mismatch with current version of __d, the detail is current use __d(function(global, require, module, exports) {/**/}, moduleName), while ModuleGraph use __d(function(require, module, global, exports) {/**/}, moduleName), the order of params of module definion mismatch.
Relative code:

Resolver/polyfills/require.js: 168
Resolver/index.js: 245
ModuleGraph/worker/transform-module.js: 38

this PR jest change the order of definition's params.

Good catch, thank you. I’m happy to merge this, but we need you to sign the CLA.


Bug: apache_beam.io.gcp.pubsublite.ReadFromPubSubLite not working

What happened?
Problem description
The function apache_beam.io.gcp.pubsublite.ReadFromPubSubLite is not working. This can be seen as a simple data processing pipeline for reading messages from a Google Cloud Pub/Sub Lite subscription and logging the messages' content is not working for apache-beam=2.50.0 and google-cloud-pubsublite=1.8.3.
Code to reproduce issue
This is the Python file defining the pipeline:
import logging
import apache_beam
from apache_beam.io.gcp import pubsublite
from apache_beam import Pipeline
from apache_beam.options.pipeline_options import PipelineOptions

def run(pipeline_args=None):
    pipeline_options = PipelineOptions(
        pipeline_args, streaming=True, save_main_session=False
    )

    with Pipeline(options=pipeline_options) as pipeline:
        elements = (
            pipeline
            | "Read from Pub/Sub" >> pubsublite.ReadFromPubSubLite(subscription_path="projects/<PROJECT_ID>/locations/<LOCATION>/subscriptions/<SUBSCRIPTION_NAME>")
            | "Print Elements" >> apache_beam.Map(lambda x: logging.info(x.getMessage()) or x)
        )

if __name__ == "__main__":
    logging.getLogger().setLevel(logging.INFO)

    run()

When running the pipeline locally the only logs printed are the following:
INFO:root:severity: INFO
timestamp {
  seconds:<PHONE_NUMBER>
  nanos: 949000000
}
message: "Fn Harness started"
log_location: "org.apache.beam.fn.harness.FnHarness"
thread: "1"

INFO:root:severity: INFO
timestamp {
  seconds:<PHONE_NUMBER>
  nanos: 579000000
}
message: "Entering instruction processing loop"
log_location: "org.apache.beam.fn.harness.FnHarness"
thread: "1"

Now I post a message on the Pub/Sub Lite topic the subscription has subscribed:
gcloud pubsub lite-topics publish <TOPIC_NAME> --location <LOCATION> --project=<PROJECT_ID> --message="Hello world"
This message is not printed despite the pipeline process still running.
Issue Priority
Priority: 1 (data loss / total loss of function)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

@dpcollins-google, can you check this?

@TimKleinlein Does the same code work with the previous Beam version?

Please respond to @liferoad 's questions. If this has never previously worked, likely it is a permissioning or connectivity issue. If it has worked previously, please send the full topic and subscription path with a timeline to<EMAIL_ADDRESS>

Thank you for your help. We are not able to create a functioning pipeline with previous Beam versions. However, since we are both using Docker on Mac, we think this might be the problem here. There is already an issue that sounds related https://github.com/apache/beam/issues/23440. Unfortunately, the solution
# By default Beam expects workers (of the SDK worker pool) to connect to a Spark worker on `localhost`. When running
# the worker pool in docker on a Mac this isn't possible due to the lack of `host` networking. Using
# BEAM_WORKER_POOL_IN_DOCKER_VM=1, Beam will use `host.docker.internal` to communicate via the docker host instead.
export BEAM_WORKER_POOL_IN_DOCKER_VM=1

# DOCKER_MAC_CONTAINER=1 limits the ports on a Spark worker for communication with SDK workers to the range 8100 - 8200
# instead of using random ports. Ports of the range are used in a round-robin fashion and have to be published.
export DOCKER_MAC_CONTAINER=1

didn't work for us.
This is the whole log
python main.py
INFO:root:Missing pipeline option (runner). Executing pipeline using the default runner: DirectRunner.
/Users/rome/.conda/envs/beam-test/lib/python3.9/site-packages/apache_beam/transforms/external.py:676: BeamDeprecationWarning: options is deprecated since First stable release. References to <pipeline>.options will not be supported
  self._expansion_service, pipeline.options)
INFO:apache_beam.utils.subprocess_server:Using cached job server jar from https://repo.maven.apache.org/maven2/org/apache/beam/beam-sdks-java-io-google-cloud-platform-expansion-service/2.50.0/beam-sdks-java-io-google-cloud-platform-expansion-service-2.50.0.jar
INFO:root:Starting a JAR-based expansion service from JAR /Users/rome/.apache_beam/cache/jars/beam-sdks-java-io-google-cloud-platform-expansion-service-2.50.0.jar
INFO:apache_beam.utils.subprocess_server:Starting service with ['java' '-jar' '/Users/rome/.apache_beam/cache/jars/beam-sdks-java-io-google-cloud-platform-expansion-service-2.50.0.jar' '65272' '--filesToStage=/Users/rome/.apache_beam/cache/jars/beam-sdks-java-io-google-cloud-platform-expansion-service-2.50.0.jar']
INFO:apache_beam.utils.subprocess_server:Starting expansion service at localhost:65272
INFO:apache_beam.utils.subprocess_server:Sep 07, 2023 12:20:22 PM org.apache.beam.sdk.expansion.service.ExpansionService loadRegisteredTransforms
INFO:apache_beam.utils.subprocess_server:INFO: Registering external transforms: [beam:transform:org.apache.beam:pubsub_read:v1, beam:transform:org.apache.beam:pubsub_write:v1, beam:transform:org.apache.beam:pubsublite_write:v1, beam:transform:org.apache.beam:pubsublite_read:v1, beam:transform:org.apache.beam:spanner_insert:v1, beam:transform:org.apache.beam:spanner_update:v1, beam:transform:org.apache.beam:spanner_replace:v1, beam:transform:org.apache.beam:spanner_insert_or_update:v1, beam:transform:org.apache.beam:spanner_delete:v1, beam:transform:org.apache.beam:spanner_read:v1, beam:transform:org.apache.beam:schemaio_jdbc_read:v1, beam:transform:org.apache.beam:schemaio_jdbc_write:v1, beam:transform:org.apache.beam:schemaio_pubsub_read:v1, beam:transform:org.apache.beam:schemaio_avro_write:v1, beam:transform:org.apache.beam:schemaio_bigquery_write:v1, beam:transform:org.apache.beam:schemaio_pubsub_write:v1, beam:transform:org.apache.beam:schemaio_bigquery_read:v1, beam:transform:org.apache.beam:schemaio_avro_read:v1, beam:transform:org.apache.beam:schemaio_datastoreV1_write:v1, beam:transform:org.apache.beam:schemaio_datastoreV1_read:v1, beam:external:java:generate_sequence:v1]
INFO:apache_beam.utils.subprocess_server:
INFO:apache_beam.utils.subprocess_server:Registered transforms:
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:pubsub_read:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@265adfad
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:pubsub_write:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@a3d9978
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:pubsublite_write:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@61544ae6
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:pubsublite_read:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@4b41dd5c
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:spanner_insert:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@3b96c42e
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:spanner_update:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@5d066c7d
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:spanner_replace:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@1e461e41
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:spanner_insert_or_update:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@5ba88be8
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:spanner_delete:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@56928307
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:spanner_read:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@3899782c
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:schemaio_jdbc_read:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@1603cd68
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:schemaio_jdbc_write:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@9ebe38b
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:schemaio_pubsub_read:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@4b23c30a
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:schemaio_avro_write:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@38089a5a
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:schemaio_bigquery_write:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@30e868be
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:schemaio_pubsub_write:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@66c92293
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:schemaio_bigquery_read:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@332796d3
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:schemaio_avro_read:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@4f0100a7
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:schemaio_datastoreV1_write:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@3cdf2c61
INFO:apache_beam.utils.subprocess_server:	beam:transform:org.apache.beam:schemaio_datastoreV1_read:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@13ad5cd3
INFO:apache_beam.utils.subprocess_server:	beam:external:java:generate_sequence:v1: org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader$1@1c33c17b
INFO:apache_beam.utils.subprocess_server:
INFO:apache_beam.utils.subprocess_server:Registered SchemaTransformProviders:
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:jdbc_write:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:spanner_cdc_read:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:bigtable_write:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:spanner_write:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:pubsublite_read:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:bigquery_storage_read:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:bigquery_fileloads_write:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:bigquery_export_read:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:jdbc_read:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:bigquery_storage_write:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:pubsub_read:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:pubsub_write:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:bigtable_read:v1
INFO:apache_beam.utils.subprocess_server:	beam:schematransform:org.apache.beam:pubsublite_write:v1
WARNING:root:Waiting for grpc channel to be ready at localhost:65272.
INFO:apache_beam.utils.subprocess_server:Sep 07, 2023 12:20:26 PM org.apache.beam.sdk.expansion.service.ExpansionService expand
INFO:apache_beam.utils.subprocess_server:INFO: Expanding 'Read from Pub/Sub/_ReadExternal(beam:transform:org.apache.beam:pubsublite_read:v1)' with URN 'beam:transform:org.apache.beam:pubsublite_read:v1'
INFO:apache_beam.utils.subprocess_server:Dependencies list: {}
INFO:apache_beam.utils.subprocess_server:Sep 07, 2023 12:20:26 PM org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader payloadToConfig
INFO:apache_beam.utils.subprocess_server:WARNING: Configuration class 'org.apache.beam.sdk.io.gcp.pubsublite.internal.ExternalTransformConfig$ReadConfig' has no schema registered. Attempting to construct with setter approach.
INFO:apache_beam.utils.subprocess_server:Sep 07, 2023 12:20:27 PM org.apache.beam.sdk.expansion.service.ExpansionService$ExternalTransformRegistrarLoader payloadToConfig
INFO:apache_beam.utils.subprocess_server:WARNING: Configuration class 'org.apache.beam.sdk.io.gcp.pubsublite.internal.ExternalTransformConfig$ReadConfig' has no schema registered. Attempting to construct with setter approach.
INFO:apache_beam.typehints.native_type_compatibility:Converting string literal type hint to Any: "Message"
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function annotate_downstream_side_inputs at 0x116409b80> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function fix_side_input_pcoll_coders at 0x116409ca0> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function pack_combiners at 0x11640a1f0> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function lift_combiners at 0x11640a280> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function expand_sdf at 0x11640a430> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function expand_gbk at 0x11640a4c0> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function sink_flattens at 0x11640a5e0> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function greedily_fuse at 0x11640a670> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function read_to_impulse at 0x11640a700> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function impulse_to_input at 0x11640a790> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function sort_stages at 0x11640a9d0> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function add_impulse_to_dangling_transforms at 0x11640aaf0> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function setup_timer_mapping at 0x11640a940> ====================
INFO:apache_beam.runners.portability.fn_api_runner.translations:==================== <function populate_data_channel_coders at 0x11640aa60> ====================
INFO:apache_beam.runners.portability.fn_api_runner.worker_handlers:starting control server on port 65290
INFO:apache_beam.runners.portability.fn_api_runner.worker_handlers:starting data server on port 65291
INFO:apache_beam.runners.portability.fn_api_runner.worker_handlers:starting state server on port 65292
INFO:apache_beam.runners.portability.fn_api_runner.worker_handlers:starting logging server on port 65293
INFO:apache_beam.runners.portability.fn_api_runner.worker_handlers:Created Worker handler <apache_beam.runners.portability.fn_api_runner.worker_handlers.DockerSdkWorkerHandler object at 0x11670bbb0> for environment external_1beam:env:docker:v1 (beam:env:docker:v1, b'\n\x1dapache/beam_java11_sdk:2.50.0')
INFO:apache_beam.runners.portability.fn_api_runner.worker_handlers:Attempting to pull image apache/beam_java11_sdk:2.50.0
2.50.0: Pulling from apache/beam_java11_sdk
Digest: sha256:2205d75d227f9d1eb816fded539bb0f4c6b138f4f1e3baafadf10cafe835e248
Status: Image is up to date for apache/beam_java11_sdk:2.50.0
docker.io/apache/beam_java11_sdk:2.50.0
INFO:apache_beam.runners.portability.fn_api_runner.worker_handlers:Waiting for docker to start up. Current status is running
INFO:apache_beam.runners.portability.fn_api_runner.worker_handlers:Docker container is running. container_id = b'e2b119f64211d7d86fb99fc25f2bb3b0927eda10e17229c82e84e532b88cfe02', worker_id = worker_0
INFO:apache_beam.runners.worker.statecache:Creating state cache with size 104857600
INFO:apache_beam.runners.portability.fn_api_runner.worker_handlers:Created Worker handler <apache_beam.runners.portability.fn_api_runner.worker_handlers.EmbeddedWorkerHandler object at 0x116725ca0> for environment ref_Environment_default_environment_2 (beam:env:embedded_python:v1, b'')
INFO:root:severity: INFO
timestamp {
  seconds:<PHONE_NUMBER>
  nanos: 225000000
}
message: "Fn Harness started"
log_location: "org.apache.beam.fn.harness.FnHarness"
thread: "1"

INFO:root:severity: INFO
timestamp {
  seconds:<PHONE_NUMBER>
  nanos: 535000000
}
message: "Entering instruction processing loop"
log_location: "org.apache.beam.fn.harness.FnHarness"
thread: "1"

Have you by chance tried running this on Dataflow runner? I wonder if this is a Beam Direct Runner problem  or some local connectivity issue.


Time left wrong?

Starting today I noticed 2 times the same issue; according to the scanner, a certain Pokémon has an amount of time left, but there is no Pokémon there. I suppose the probblem is that it despawned before. Any of you noticed the same? Might it be that Niantic changed some spawn times?

Since I haven't seen this anymore, and none else is reporting the same, I'm closing the issue.


⚠ ClamAV has degraded performance

In 4eb7e9a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 346 ms

Resolved: ClamAV performance has improved in d4303f0 after 541 days, 23 hours, 54 minutes.


Double encoding of '%' in start url

I am having a similar issue as #272  with double encoding of the '%' sign.
My start url is https://github.com/search?q=stars%3A>500&type=Repositories but it is getting encoded into https://github.com/search?q=stars%253A%253E500&type=Repositories .
When rendering this double encoded url, the search results page say "We couldn’t find any repositories matching 'stars%3A%3E500' ".

Hi,
Are you using portia development or master branch?
This should have been addressed here: https://github.com/scrapinghub/portia/commit/733e7c7448c7b2a87462be88463fc71bd34a2833 but It's not on master branch or hosted portia yet.

Hi,
I was using the one hosted on https://portia.scrapinghub.com.
I'll try using the development branch thanks!

Hello,
I'm trying to test out this encoding issue on the "develop" branch. I'm getting the following error:
u'https://github.com/search?q=stars%3A>500&type=Repositories' is not a u'url'.


BUG, DOC, TST: combine_pvalues: Fixing Tippett’s and Pearson’s method and improving documentation.

Reference issue
Closes #15373.
What does this implement/fix?

Fixes #15373 and includes test for monotony as described therein.
Includes warnings in documentation that this can only be applied to continuous tests.
Better explain the different methods in the documentation, removing technical details that I doubt to be useful to any reader.
Minor formatting fixes to documentation.

Additional information
I am currently in the process of writing a Monte Carlo-based module for combining p values (mainly of discrete tests): I used this to further test all methods.

There are some lint errors:
scipy/stats/_stats_py.py:8118:80: E501 line too long (87 > 79 characters)
scipy/stats/_stats_py.py:8196:80: E501 line too long (98 > 79 characters)

Link

There are some lint errors:

I know, but I don’t know how to (reasonably) fix either of them: The first is a long URL that cannot be wrapped to 80 chars. Even if this could be wrapped somehow, docstring readability would inevitably suffer. The second is an overly long parameter description that does not get appropriately rendered when wrapped, or at least I don’t know how. The first one is also not by me, but the lintdiff doesn’t recognise that it is.
Ceterum censeo: Manual wrapping of texts is an annoying archaism: It breaks everything once you view something at a smaller width and computers can perfectly do it automatically since decades for every width.

@steppi since you had a close look at the issue, could you review this?

Sure thing. Curiously, the project I was working on that lead to my first PR to SciPy, gh-13979, involved implementing and comparing different methods for combining p-values when working with only the log p-values.

@steppi: I streamlined the docstring once more, including your comments. In addition, I removed the redundancy of the methods list in the arguments listing all the test statistics. It now only spells out the names of all the methods. I think the detailed information about the different methods only needs to be in one place and that are is the Notes.

@steppi @tupui I also noted that the statistics for Pearson’s method has an odd sign in context. Although there is no clear consensus on what to use as a statistics for Pearson’s method, most sources that compare methods give statistics for both Fisher’s and Pearson’s method such that a higher statistics corresponds to a lower p value and Mudholkar’s and George’s method averages Fisher’s and Pearson’s statistics (or is their sum). See for example Heard and Rubin-Delanchy (2017, referenced in the docstring).
I therefore have also changed the sign of Pearson’s statistics. The clear drawback of this is that it’s backwards-incompatible, but then Pearson’s method was erroneous until this pull request anyway.

I therefore have also changed the sign of Pearson’s statistics. The clear drawback of this is that it’s backwards-incompatible, but then Pearson’s method was erroneous until this pull request anyway.

Personally I prefer having the sign the way you've done it, but defer to @tupui as to whether it's worth breaking backwards compatibility.

I would suspect that the statistic is less used than the p-value, so there should be a limited impact. In case of a clear bug, we should fix it.

In case of a clear bug, we should fix it.

@tupui That’s the conundrum: It’s not a clear bug. There are several possible choices for the statistics for this method, which are all easily transformable into each other. The one chosen before is just unusual, in particular in the context of the other methods. However, the p value produced by the method in question was blatantly wrong and fixing that is one of the most important parts of this pull request. Thus, the only people who might stumble upon this sign change would be those who use the method only for the statistic, which I suspect are none because I don’t see a reason to further process it and it’s straightforward to compute (in whatever variant you want).

In case of a clear bug, we should fix it.

@tupui That’s the conundrum: It’s not a clear bug. There are several possible choices for the statistics for this method, which are all easily transformable into each other. The one chosen before is just unusual, in particular in the context of the other methods. However, the p value produced by the method in question was blatantly wrong and fixing that is one of the most important parts of this pull request. Thus, the only people who might stumble upon this sign change would be those who use the method only for the statistic, which I suspect are none because I don’t see a reason to further process it and it’s straightforward to compute (in whatever variant you want).

Although perhaps not a clear bug, I agree with you that it would be good to have the returned statistic be consistent with what is typically seen in the literature. I think any hypothetical person using this method just for the statistic wold have to be aware of the bug in the p-value calculation and will be happy that it has been fixed.

Let's do this then 👍

@steppi could you update the release notes?

@tupui @Wrzlprmft
I've updated the release notes here. I've pasted what I've written below. Let me know if you think there are any changes that should be made.
The methods "pearson" and "tippet" from scipy.stats.combine_pvalues have been fixed to return the correct p-values, resolving #15373. The sign of the test statistic returned for the method "pearson" has been flipped so that higher values of the statistic now correspond to lower p-values, making the statistic more consistent with those of the other methods and with the majority of the literature. In addition, the documentation for scipy.stats.combine_pvalues has been expanded and improved.

Thanks @steppi it's a good description. I would just put it instead in the backward incompatible section (at least the sign change part).

I would just put it instead in the backward incompatible section (at least the sign change part).

Good catch. Done!


[MM-14767] Sorting BOTs at the bottom of channel member list below offline users is not working

Summary
Forces bots to the bottom of channel user list
Ticket Link

Jira
GitHub
Related Pull Requests

Has redux changes (May be necessary)

So this change works, but seems a bit sloppy. Based on this sort function, and the origin of user statuses (redux)... It seems that bots would need a "bot status", in order to force them to the bottom of this list, as well as enable the alphabetical sorting that is called at the end of this function.
I'm happy to make that change, but didn't know if it was appropriate for this small fix.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-0ef31f4e4e3f7e3c1.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Internal IP: <IP_ADDRESS>
Instance ID: i-0ef31f4e4e3f7e3c1

Spinmint test server destroyed


ESP32-C3 Linux Install Requirements - User needs 'dialout' group membership to access serial port (IDFGH-11199)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.2-dev-3065-g272b4091f1
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
What is the expected behavior?
When following documentation section Flash onto the Device, as a standard Ubuntu user, I expect the  'idf.py -p "$PORT" -b 460800 flash' command will flash the device.
What is the actual behavior?
Preceding documentation does not advise a 'user' as requiring permissions to access a serial terminal. Consequently, when running "idf.py -p "$PORT" -b 460800 flash" command fails to connect to the serial port with an error "Could not open serial port /dev/ttyACM0" will be displayed.
This bug was found and corrected by googling, discovering that standard Ubuntu users are not automatically placed in 'dialout' group which is required for access to serial ports under /dev/ in the system.
Please update  For Linux Users 'Requirements' to reflect that the user wishing to run idf.py, and flash the device successfully, requires permissions to open a serial console under  /dev.
For Ubuntu 22.04.3 that means user needs to be added to the 'dialout' group by using the following command:
sudo usermod -G dialout <username>
Preceding documentation when followed logically, does not advise that the 'user' as requiring  permissions to access a serial terminal, prior to this particular point of the documentation.
Suggest you include a note or the above command to illustrate this for your users. if idf code generates the error message encountered you may wish to put a permissions hint in it too.
Steps to reproduce.

Follow install idf per site documentation instructions as a standard Ubuntu user
Connect device
Move to esp-idf/examples/getting-started/hello-world directory
run 'idf.py build'
run 'idf.py -p "$PORT" -b 460800 flash'

Build or installation Logs.
Host OS = PRETTY_NAME="Ubuntu 22.04.3 LTS"
uname -r = 6.2.0-33-generic
board = ESP32-C3-DevKit-RUST-1

More Information.
preceding the  'idf.py -p "$PORT" -b 460800 flash' command with sudo also fails as well due to root not having required environment hooks for idf.py to work.

Happy for this to be tagged as 'Documentation update' or moved to a 'Documentation' queue as required.

found the 'Tip' below this point in the documentation.  Still feel howerver that permissions needs to be included as a 'Requirment' of the idf user. Granted this is not the case for all Linux distro's, however it may be of use moving the 'Tip' to a point that precededs the 'idf.py -p "$PORT" -b 460800 flash' command's use in the documentation.


adding proper options + updating readme

it looks like you were treating options as an array instead of an object, so I took the liberty of rewriting this

Thanks for the pull request, @Zamiell!
It seems like nice additions, so I'll merge it immediately. :)
By the way, I've been quite busy as of lately, but I will likely return to this plugin during the summer. So make sure to check the repository for updates if you're still using it then.


Dig

I got test working locally by changing "jest --verbose" to "jest --coverage" in package.json. I did not commit package.json.
Please review the test. Thanks.

You have some file conflicts. You should fix those


fix(e2e): remove taker fee non-determinism affecting geo twap in e2e

Closes: #https://github.com/osmosis-labs/osmosis/issues/6259
What is the purpose of the change
See investigation analysis in: https://github.com/osmosis-labs/osmosis/issues/6259
Summary of the problem:
The taker fee e2e tests asynchronously set taker fee for both chains A and B.
Due to asynchrony, twap tests sometimes ran before and other times after taker fee being set.
However, geometric twap depends on specific swap amounts to function without jitter.
To work around the issue, taker fee is now set deterministically on chain B while chain A has zero taker fee.
As a result, concentrated liquidity tests that depend on non-zero taker fee now use chain b and geometric twap tests that depend on taker fee not being set use chain A.
Testing and Verifying
Tested by running e2e in CI muliple times. Also, tested by completely removing the taker fee e2e test in a separate PR and rerunning CI multiple times: https://github.com/osmosis-labs/osmosis/pull/6272
Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

954f49d failed because there was another TWAP test that I didn't notice.
It is different from the geometric twap test. Having fixed the geo twap test, I observed no failures for 4 e2e runs.
Therefore, I applied the same fix to CreateConcentratedLiquidityPoolVoting_And_TWAP test 9cdca10. It should eliminate flakiness completely.


Hide Markdown block titles

Hi, this is a feature request, not a bug report.
Currently, when parsing Markdown including check boxes, the extension shows Markdown titles as directories. This is great.
But when all check boxes under a "directory"/Markdown title are checked, there should also be an option to hide the enclosing "directory".
As an illustration, here is what my Markdown To-Do sidebar list looks like:

Satisfying to know you've accomplished a lot of work, but not very efficient visually...

Hi, great extension!
This pull-request would hide the branches with 0 todos;
https://github.com/TomasHubelbauer/vscode-markdown-todo/pull/11


fix: fix and test getu and getp with empty arrays

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
[ ] Any new documentation only uses public API

Additional context
Add any other context about the problem here.

Missing a format right now. Waiting for CI to avoid rerunning it, will then push format and merge once it passes

SciMLBase failure is due to adjoint hotfix


Implement Search?

The Docker Hub API spec calls for a /v1/search endpoint on the index.

Is this spec against the index? The registry code has search implemented using SQLalchemy as a backend.

@rikkuness unsure. I just threw the issue up for me to follow up on it sometime. Once upon a time the index spec called for it, but it could have just been a proxy through to the registry or it might have changed entirely.

There's some definition in the docker-registry readme.md https://github.com/docker/docker-registry#search-engine-options I've managed searching via that API in the past without any real issues.

Interestingly, now I've got push working I've noticed that the registry doesn't seem to index search data.
Configured on the registry SEARCH_BACKEND:sqlalchemy and SQLALCHEMY_INDEX_DATABASE:sqlite:////data//search-index.db the sqlite file is created but it would appear nothing gets appended on a push. All queries to /v1/search on the registry return 0 results.

Search is in fact an index feature but I've never implemented it.
Sent from my iPhone

On Mar 26, 2015, at 09:13, Darrian<EMAIL_ADDRESS>wrote:
Interestingly, now I've got push working I've noticed that the registry doesn't seem to index search data.
Configured on the registry SEARCH_BACKEND:sqlalchemy and SQLALCHEMY_INDEX_DATABASE:sqlite:////data//search-index.db the sqlite file is created but it would appear nothing gets appended on a push. All queries to /v1/search on the registry return 0 results.
—
Reply to this email directly or view it on GitHub.

Will implementing search require another backend datastore that allows retrieving multiple records or does your datastore abstraction (https://github.com/ekristen/docker-index/issues/19) need to allow for this capability?

I'm not sure I'll be implementing search, once I revert things back to 1.4.x I might take a look but all my focus is on v2 right now. Docker's v2 registry will not longer need the index and the they are building a search system too for v2.

Docker registry v1 is about to be deprecated entirely from the docker engine, this project will soon be deprecated as well.


[API Management] az apim api export: Add command to export an API Management API

Related command

az apim api export -g Api-Default-Central-US-EUAP --service-name arpishahtestapim --api-id echo-api --format OpenApiJson --file-path C:\Users\arpishah\examples\cli-examples\exported-results\exported-apim-results
Description

This PR is to add export apim cli command. The import command was already present but the export command was not present. This change exports an API present in the APIM instance to a file based on the format specified or to a link. This is controlled by the format parameter
Testing Guide

az apim api export -g Api-Default-Central-US-EUAP --service-name arpishahtestapim --api-id echo-api --format OpenApiJson --file-path C:\Users\arpishah\examples\cli-examples\exported-results\exported-apim-results
Here the api echo-api present in arpishahtestapim apim instance is exported to the file C:\Users\arpishah\examples\cli-examples\exported-results\exported-apim-results --subscription-id a200340d-6b82-494d-9dbf-687ba6e33f9e in the format openapi json
History Notes

`az apim api export: Add export api from apim capability

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Thank you for your contribution! We will review the pull request and get back to you soon.

please fix the CI issues

Please not that CLI only review the code style and specification, but not responsible for business logic.
Thus, it is better to involve service team to review PRs as well.

@arpishahmsft The PR looks good to me

yanzhudd The PR has been reviewed by APIM Team member - Alan yingru97
Alan, however, is not able to approve PR, he does not get an option to join as a reviewer.
Could you please help hoim add as a reviewer or approve this PR as its also reviewed by Alan. Thanks!


Create diff when copying labels

Post requests will fail when the label is already present. one can requerst all labels beforehand, create a diff and only post the labels that do not exist already.

182b9af


FQDN: incrementally update selectors on DNS message

(Note: This is based on #29691, but does not actually rely on that PR. It's based on that just for a meaningful performance comparison. Only the last commit is new.)
This change removes a full recalculcation of FQDN policy when a DNS response is received.
When a response is received, one of two things can occur:

One or more selectors select additional IPs / identities
Nothing has changed

Not possible is the case that selectors lose IP addresses; that happens only upon gabage collection / entry expiration. This means we can skip a full recalculation of selectors in the critical path.
This change is relatively small; it adds an incremental update method to the SelectorCache, and then changes the NameManager to utilize that. It does a bit of bookkeeping to compute the delta, and passes those directly to the selectors.
This results in a 70% improvement in benchmark speed, as well as a 99% reduction in memory usage.
                     │  0_main.out  │            1_pr-29691.out            │          2_incremental.out          │
                     │    sec/op    │    sec/op     vs base                │   sec/op     vs base                │
UpdateGenerateDNS-12   3558.2m ± 1%   2157.2m ± 1%  -39.37% (p=0.000 n=10)   606.4m ± 1%  -82.96% (p=0.000 n=10)

                     │   0_main.out   │             1_pr-29691.out             │          2_incremental.out           │
                     │      B/op      │      B/op       vs base                │     B/op      vs base                │
UpdateGenerateDNS-12   902.866Mi ± 0%   532.115Mi ± 0%  -41.06% (p=0.000 n=10)   3.914Mi ± 0%  -99.57% (p=0.000 n=10)

                     │  0_main.out   │            1_pr-29691.out             │          2_incremental.out          │
                     │   allocs/op   │   allocs/op    vs base                │  allocs/op   vs base                │
UpdateGenerateDNS-12   9033.94k ± 0%   1008.96k ± 0%  -88.83% (p=0.000 n=10)   49.02k ± 0%  -99.46% (p=0.000 n=10)

The latency when updating the FQDN policy subsystem in response to a DNS packet has been significantly reduced.

Marking as needs-discussion while we decide if this should wait for v1.16 or can go in for v1.15.

/test


feat(kademlia): restrict peer quick pruning on net errors only

This PR adds a very small addition to the quick pruning to prone only on network related errors. Thanks @acud for the idea.

This change is

Codecov Report

Merging #2599 (1882a07) into master (e53b36c) will decrease coverage by 0.16%.
The diff coverage is 19.04%.

@@            Coverage Diff             @@
##           master    #2599      +/-   ##
==========================================
- Coverage   63.54%   63.38%   -0.17%
==========================================
  Files         232      232
  Lines       25937    25946       +9
==========================================
- Hits        16482    16445      -37
- Misses       7958     7998      +40
- Partials     1497     1503       +6

Impacted Files
Coverage Δ

pkg/topology/kademlia/kademlia.go
74.64% <19.04%> (-1.43%)
:arrow_down:

pkg/p2p/libp2p/stream.go
70.58% <0.00%> (-11.77%)
:arrow_down:

pkg/p2p/libp2p/upnp.go
59.37% <0.00%> (-6.25%)
:arrow_down:

pkg/localstore/subscription_push.go
75.72% <0.00%> (-5.83%)
:arrow_down:

pkg/p2p/libp2p/libp2p.go
59.68% <0.00%> (-1.95%)
:arrow_down:

pkg/localstore/mode_put.go
58.90% <0.00%> (-1.15%)
:arrow_down:

pkg/localstore/mode_set.go
54.10% <0.00%> (-1.12%)
:arrow_down:

pkg/retrieval/retrieval.go
64.06% <0.00%> (-0.32%)
:arrow_down:

cmd/bee/cmd/cmd.go
65.83% <0.00%> (-0.22%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53b36c...1882a07. Read the comment docs.

Thanks for this, but it's still discouraging if you have a network connectivity issue when you have just started a bee node.  You can watch the 100,000+ entry accumulated address book disappear within minutes!


partial fix for 1290

partial fix for 1290
another batch will follow in separate PR
Signed-off-by: Christopher Ferris<EMAIL_ADDRESS>

rebased - note, there are no code changes - just license header replacement to correct an incorrect license header statement. If there's a better way of handling this change, I am all ears

restarted build, but there are no code changes, so hard to fathom how the tests are failing other than randomly

same two errors - I am baffled unless the tests themselves are broken.

closing this and submitting another PR


Mention and_return in "Allowing messages" feature

Even though and_return is covered in detail in following features, it would make sense to mention how to return a value while allowing a single message because it's more likely the use case a reader is looking for when they start reading the Basics topic.

Hi as this isn't just a documentation change, (you've added a scenario) can you please amend your commit removing [skip ci] so the build runs?
We also do have a whole file dedicated to responding with and_return that makes this a bit superfluous, but I'm ok including it as a simple example, maybe it's worth mentioning that file in the preamble however

Given that we've got an entire feature file on and_return, it seems organizationally odd (to me) to put this scenario here.
Instead, what do you think about updating the narrative to link to the configuring responses section?  That'll allow people who come to this feature file to easily navigate to where it explains how to configure responses (such as and_return).

I gave it more thought (as I should have in the first place) and now I agree that it's superfluous. Configuring responses also applies to expecting messages and mentioning it in that section as well would be too much. I really like how succinct the features are.


Why can't I choose an interface language in the login screen?

This functionality has been added in the branch 'improveuserexperience' :)


feat: prompt users without fzf for the zoxide plugin

Also fixed some local variables that were redefined.
Closes #1851.

Zoxide already provides a clear error message when fzf is not found:
❯ zoxide query -i
zoxide: could not find fzf, is it installed?

I think we could just display that error message to the user when zoxide query fails, instead of checking for fzf existence beforehand. This way, we can avoid unnecessary fzf process creation overhead.

Ahhh I see, I'll update it to use that.
Sorry, I don't use zoxide.

No worries, you're doing great!
Thanks for your PR, merging now