[RFC] Remove JSON.mapping and YAML.mapping

Now that we have JSON::Serializable and YAML::Serializable I think we should remove JSON.mapping and YAML.mapping as usual: first deprecate them (warning), then remove them.
I believe the Serializable approach is superior:

it just generates a constructor (mapping will generate getters and setters too, from which you can opt-out, but it feels a bit messy)
it's DRY: with mapping you need to specify the type of instance vars, and you have to do this if you have multiple mappings (like JSON and YAML in a single class)
it supports inheritance but mapping doesn't

I'd like to deprecate mapping in 0.32.0 and remove it in 0.33.0.

It might be worth making extracting it to a shard and keeping it in the crystal-lang org for a little while.

If someone want's to preserve this in a shard, this is fine. But I don't think we should burden crystal-lang with it.

Maybe the crystal-community would be a good place.
This seems like something that people might want for compatibility for a while.  It does not seems like something that was inherently done wrong.  I just thing it might be worth preserving for people keeping up with crystal releases and some people might prefer it.

Yes as a shard but not inside the organization (it's fine in crystal-community though... I think).


[Transaction] RetryException should not be return

Fix https://github.com/apache/pulsar/issues/13792
Motivation
when TC get a RetryException, it will try that operation again and return the exception to client.But if the operation is executed again, we don`t need to return this RetryException to client.
Modification
Add a future as param of endTransaction(...)
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

/pulsarbot run-failure-checks


Switch seems bricked.

I tried to flash a generic wifi switch (sadly, I don't have a model/version) which is controlled via smart life app. The script detected correctly the device and tried to install the tasmota firmware, but the device ended up unresponsive and after a couple of minutes waiting for the process to finish, I stopped the script.
I tried to reconnect the power line on the device waiting for some signal without success. It is still unresponsive and I'm not sure what else to do.
It's important to notice that the vtrust-recovery or the sonoff-**** SSID never appear on my phone.
Any help on this? thanks!
smarthack-mqtt.log
smarthack-psk.log
smarthack-udp.log
smarthack-web.log
smarthack-wifi.log

Your logs are empty, can you check both scripts and backups directories for logs?

weird. I'll post it here then. Here's the info that is located in the log files that lives within the scripts/ folder:
mqtt
^C1587596356: mosquitto version 1.5.7 terminating
1587596464: mosquitto version 1.5.7 starting
1587596464: Using default config.
1587596464: Opening ipv4 listen socket on port 1883.
1587596464: Opening ipv6 listen socket on port 1883.
^C1587596770: mosquitto version 1.5.7 terminating
1587596895: mosquitto version 1.5.7 starting
1587596895: Using default config.
1587596895: Opening ipv4 listen socket on port 1883.
1587596895: Opening ipv6 listen socket on port 1883.

psk
^CTraceback (most recent call last):
  File "./psk-frontend.py", line 113, in <module>
    main()
  File "./psk-frontend.py", line 106, in main
    r,_,_ =  select.select(readables, [], [])
KeyboardInterrupt
^CTraceback (most recent call last):
  File "./psk-frontend.py", line 113, in <module>
    main()
  File "./psk-frontend.py", line 106, in main
    r,_,_ =  select.select(readables, [], [])
KeyboardInterrupt

udp
^CListening for Tuya broadcast on UDP 6666
Listening for encrypted Tuya broadcast on UDP 6667
^CListening for Tuya broadcast on UDP 6666
Listening for encrypted Tuya broadcast on UDP 6667

wifi
wlan0: AP-STA-CONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-DISCONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-DISCONNECTED d8:f1:5b:bb:0f:bb
wlan0: AP-STA-CONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-DISCONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-CONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-DISCONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-CONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-DISCONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-CONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-DISCONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-CONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-DISCONNECTED 36:4a:8e:0c:99:32
wlan0: interface state ENABLED->DISABLED
wlan0: AP-DISABLED
wlan0: CTRL-EVENT-TERMINATING
nl80211: deinit ifname=wlan0 disabled_11b_rates=0
AP closed
Stopping DNSMASQ server...
System info
===========
31856ad
Linux raspberrypi 4.19.97+ #1294 Thu Jan 30 13:10:54 GMT 2020 armv6l GNU/Linux
OpenSSL 1.1.1d  10 Sep 2019
Dnsmasq version 2.80  Copyright (c) 2000-2018 Simon Kelley
Compile time options: IPv6 GNU-getopt DBus i18n IDN DHCP DHCPv6 no-Lua TFTP conntrack ipset auth DNSSEC loop-detect inotify dumpfile

This software comes with ABSOLUTELY NO WARRANTY.
Dnsmasq is free software, and you are welcome to redistribute it
under the terms of the GNU General Public License, version 2 or 3.
hostapd v2.8-devel
User space daemon for IEEE 802.11 AP management,
IEEE 802.1X/WPA/WPA2/EAP/RADIUS Authenticator
Copyright (c) 2002-2019, Jouni Malinen<EMAIL_ADDRESS>and contributors
Python 3.7.3
===========
Configuring AP interface...
RTNETLINK answers: File exists
RTNETLINK answers: File exists
Starting DNSMASQ server...
Starting AP on wlan0...

System info
===========
31856ad
Linux raspberrypi 4.19.97+ #1294 Thu Jan 30 13:10:54 GMT 2020 armv6l GNU/Linux
OpenSSL 1.1.1d  10 Sep 2019
Dnsmasq version 2.80  Copyright (c) 2000-2018 Simon Kelley
Compile time options: IPv6 GNU-getopt DBus i18n IDN DHCP DHCPv6 no-Lua TFTP conntrack ipset auth DNSSEC loop-detect inotify dumpfile

This software comes with ABSOLUTELY NO WARRANTY.
Dnsmasq is free software, and you are welcome to redistribute it
under the terms of the GNU General Public License, version 2 or 3.
hostapd v2.8-devel
User space daemon for IEEE 802.11 AP management,
IEEE 802.1X/WPA/WPA2/EAP/RADIUS Authenticator
Copyright (c) 2002-2019, Jouni Malinen<EMAIL_ADDRESS>and contributors
Python 3.7.3
===========
Configuring AP interface...
RTNETLINK answers: File exists
RTNETLINK answers: File exists
Starting DNSMASQ server...
Starting AP on wlan0...
Configuration file: /dev/stdin
wlan0: Could not connect to kernel driver
Using interface wlan0 with hwaddr b8:27:eb:19:99:25 and ssid "vtrust-flash"
wlan0: interface state UNINITIALIZED->ENABLED
wlan0: AP-ENABLED
wlan0: AP-STA-CONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-DISCONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-CONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-DISCONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-CONNECTED 36:4a:8e:0c:99:32
wlan0: AP-STA-DISCONNECTED 36:4a:8e:0c:99:32

web
^CReceived SIGINT, exiting...
Listening on <IP_ADDRESS>:80
^CReceived SIGINT, exiting...
Listening on 10.42.

then, there two folders within the backups folder:
pi@raspberrypi:~/tuya-convert/backups $ ls
20200422_230826  20200422_235528

For the 20200422_230826, there's only two files:
pi@raspberrypi:~/tuya-convert/backups/20200422_230826 $ ls
device-info.txt  firmware-bb0fbb.bin
pi@raspberrypi:~/tuya-convert/backups/20200422_230826 $ cat device-info.txt
VTRUST-FLASH 1.5
(c) VTRUST GMBH https://www.vtrust.de/35c3/
READ FLASH: http://<IP_ADDRESS>/backup
ChipID: bb0fbb
MAC: D8:F1:5B:BB:0F:BB
BootVersion: 7
BootMode: normal
FlashMode: 1M DOUT @ 40MHz
FlashChipId: 144051
FlashChipRealSize: 1024K
Active Userspace: user2 0x81000

for the 20200422_235528 folder, there's a couple of smarthack logs:
pi@raspberrypi:~/tuya-convert/backups/20200422_235528 $ ls
device-info.txt  firmware-bb0fbb.bin  smarthack-mqtt.log  smarthack-psk.log  smarthack-udp.log  smarthack-web.log  smarthack-wifi.log

device-info:
VTRUST-FLASH 1.5
(c) VTRUST GMBH https://www.vtrust.de/35c3/
READ FLASH: http://<IP_ADDRESS>/backup
ChipID: bb0fbb
MAC: D8:F1:5B:BB:0F:BB
BootVersion: 7
BootMode: normal
FlashMode: 1M DOUT @ 40MHz
FlashChipId: 144051
FlashChipRealSize: 1024K
Active Userspace: user2 0x81000

smarthack-mqtt.log
smarthack-psk.log
smarthack-udp.log
smarthack-web.log
smarthack-wifi.log

Try to run tuya-convert again, it might be running the intermediate software. I had this as well. Switch looked bricked, until I restarted tuya-convert and the process picked up the device.

I tried that a couple of times without success 😕


Using GitHub Pages for the landing page

It would be ideal if we could make use of GitHub pages for our landing page at TheCannon.io. That way all the page content would be stored in the gh-pages branch of this repository.
Currently TheCannon.io domain just points to the Read the Docs page.
Only one custom domain can be used with GH pages per user or organization. I already have a GitHub pages account set up for my personal website, which means the GH page URL redirects from https://andycasey.github.io/AnniesLasso/index.html to astrowizici.st/AnniesLasso/index.html
That means we need to create an organization or username then specify TheCannon.io as our custom domain.
So, what organization name should we use, @davidwhogg? Once selected, we will have to move this repository to that new organization.

Actually through a hack I have learned we can do this using any username/organization.
I'm going to close this and open a new issue about moving this repository to @AnnieJumpCannon for later on.


fix(service): only discover devices and add the devices if there are no devices in data store

Only discover devices and add the devices if there are no devices in data store.
Marked the failed adding devices to unavailable status in PR: https://github.com/Seagate/cfm/pull/54

Please remove line 71-78 which was added back by the merge. Then you should be good.


OfflineVirtualMachine implementation

This PR introduces the OfflineVirtualMachine kind to the kubernetes ecosystem and add its support to the KubeVirt.
Currently it is a heavy work in progress and this PR is meant to support discussion.
All remarks, tips and comments are welcomed.
Fixes #668
@fabiand @rmohr @davidvossel @mpolednik @michalskrivanek @stu-gott

This change is

[x] Basic controller logic
[x] OfflineVirtualMachine Client
[x] OnDelete update strategy
[x] Unit Tests
Functional Tests

[ ] cover restart of guest-side stopped vm (vm in final or failed state)

@petrkotas any news here?

Yes the expectations are pushed. You  can look.
Sent from my iPhone

On 14 Feb 2018, at 08:44, Roman Mohr<EMAIL_ADDRESS>wrote:
@petrkotas any news here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@petrkotas you commited the binary by accident.

Thanks for the review. Working on it.

Thanks for the review. Working on it.

ok to test

@rmohr I have finished cleaning up. If you are okay with it, can we merge?

@petrkotas we will have to wait for ci results (we wiped the CI caches, so that will take some time). Also I am giving it a final review round.

@petrkotas could you verify the functiona tests locally too?
I see errors like that:
•! Panic [0.432 seconds]
OfflineVirtualMachine
/root/go/src/kubevirt.io/kubevirt/tests/ovm_test.go:42
  A valid OfflineVirtualMachine given
  /root/go/src/kubevirt.io/kubevirt/tests/ovm_test.go:53
    should update OfflineVirtualMachine once VMs are up [It]
    /root/go/src/kubevirt.io/kubevirt/tests/ovm_test.go:63

    Test Panicked
    runtime error: index out of range
    /gimme/.gimme/versions/go1.9.2.linux.amd64/src/runtime/panic.go:491

That smells like real bugs.

ok to test

ok to test

retest this please

OK to test

Seems like a rebase is needed. Also it seems like the guest-side shutdown + restart is missing. Look for our console-expect tests on how to add it (I think the pr does not handle restarts after guest-shutdowns correct yet).

OK to test

OK to test

Retest this please

Retest this please

retest this please

ok to test

OK to test

retest this please

@petrkotas travis should not choke on the code generator step anymore after a rebase.

@rmohr the code is already rebased
--
s pozdravem,
Petr Kotas
On Wed, Feb 28, 2018 at 11:49 AM, Roman Mohr<EMAIL_ADDRESS>wrote:

@petrkotas https://github.com/petrkotas travis should not choke on the
code generator step anymore after a rebase.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubevirt/kubevirt/pull/667#issuecomment-369201693,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AISOCeIvwUGrJEqTHRG8XG70_NQxeciIks5tZS8dgaJpZM4RldYP
.

Remaing items:

[ ] Fix smaller nits from this review https://github.com/kubevirt/kubevirt/pull/667#pullrequestreview-100738713
[ ] Fix issue in this review https://github.com/kubevirt/kubevirt/pull/667#pullrequestreview-100743604

From the checklist at the top of the PR, fix:

cover restart of guest-side stopped vm (vm in final or failed state) (https://github.com/kubevirt/kubevirt/pull/667#discussion_r171823082)

retest this please

retest this please

It seems that our CI is broken.
Here are the links for two consecutive runs of make functest on my machine to prove that it works:

Run 1
Run 2

This seems like the kubernetes is not fully installed and is missing
CustomResourceDefinion resource. Which indeed, is weird.
--
s pozdravem,
Petr Kotas
On Wed, Mar 7, 2018 at 2:38 PM, Artyom Lukianov<EMAIL_ADDRESS>wrote:

@rmohr https://github.com/rmohr @fabiand https://github.com/fabiand
our CI is broken on some strange message

cluster/vagrant-kubernetes/.kubectl -n default delete crd -l kubevirt.io
the server doesn't have a resource type "crd"

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubevirt/kubevirt/pull/667#issuecomment-371136910,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AISOCZK7izYfxgf151r002gsmufaEuBsks5tb-AXgaJpZM4RldYP
.

retest this please

@fabiand, @rmohr, the pending issues seem quite trivial for a followup and overall the feature seem to be ready for quite some time, could we get it in and unblock people keen to try play with offlinevms?

retest this please

retest this please

retest this please

@rmohr @fabiand since the CI still seems to be broken I did another make functest on my machine with the kubevirt test setup (no changes). This time I had 1 master and 3 nodes. IT passed, except one test. I did configured the connection to the internet.
The result is [here] (http://pastebin.test.redhat.com/562923).

@petrkotas I am just running CI a few times to see if some unexpected things happen. I would let you konw if I expect something from you.

retest this please

retest this please


The agora_rtm pod failed

ERROR | attributes: Missing required attribute homepage.

WARN  | license: Missing license type.
WARN  | [iOS] keys: Missing primary key for source attribute. The acceptable ones are: git, hg, http, svn.

Hi Guys, @Matrixbirds @LichKing-2234 @PRWrl @masashi-sutou
I fixed the issue on this PR
Can you take a look? We need this change in order to go make a realese into the App Store.
Thanks.

Guys, the temporary solution is to go back to agora_rtm 0.9.12

fixed 0.9.14


Give bot a custom status

Give the Rev Bot a custom status so it looks very cool (this is entirely cosmetic).

Gave it the status:

Playing Verifying ✅


Allow specifying environment variables from secrets in generated CloudFunction

There's a mechanism already in place to specify custom args to the auto-generated functions created as the result of callbacks defined for bucket's onObjectEvents, but unfortunately this option supported by CloudFunction is not whitelisted in the type.
This should be all that it takes for our use-case to be able to customize this value.

/run-acceptance-tests

/run-acceptance-tests

Hey @kpitzen, I believe I was missing an import statement. Would you mind running tests again?

Hi @tjsousa - apologies for the delay here! I'll get those running now.

Hey @tjsousa - this all looks good on our end! I'll go ahead and get this merged in. Thank you for your contribution!

Can confirm that this is working for us in GCP after integration of the latest release.


Fixing domain-mode reload

Jira: https://issues.jboss.org/browse/WFCORE-855

Core - Full Integration Build 1422 is now running using a merge of 1cd48e5c9172bc90f4990cf3f55719f11e3942a5

Windows Build 1805 is now running using a merge of 1cd48e5c9172bc90f4990cf3f55719f11e3942a5

Linux Build 2286 is now running using a merge of 1cd48e5c9172bc90f4990cf3f55719f11e3942a5

Windows Build 1805 outcome was SUCCESS using a merge of 1cd48e5c9172bc90f4990cf3f55719f11e3942a5
Summary: Tests passed: 3421, ignored: 64 Build time: 0:35:07

Linux Build 2286 outcome was SUCCESS using a merge of 1cd48e5c9172bc90f4990cf3f55719f11e3942a5
Summary: Tests passed: 3421, ignored: 64 Build time: 0:37:05

Core - Full Integration Build 1422 outcome was SUCCESS using a merge of 1cd48e5c9172bc90f4990cf3f55719f11e3942a5
Summary: Tests passed: 2983, ignored: 358 Build time: 0:47:53


Svg copied message sub-merging

Current state :
When a user clicks on an icon and alert message is displayed, the alert message looks sub-merged in the background as both background and foreground(alert) colors are same.
https://user-images.githubusercontent.com/67755381/159544393-cac1f444-34fa-4ef6-91fa-0ee462ca5e0c.mp4
Expected state :
The alert message should consist of a bit of darker color such as the on hover color so that it can look more like an alert.

I am working on this issue


Adjusted the Export script

Resolves #17

adjusted the export script to include connected elements for generating the grid topology.
changed the logic to mention fields to include rather than fields to exclude to make developing easier and add necessary parameters step by step.

Is this still up 4 review? I thought we discussed that it might not make sense to have it that way? 🤔
If it's not up 4 review pls consider either close it or convert it to a draft.

Is this still up 4 review? I thought we discussed that it might not make sense to have it that way? 🤔
If it's not up 4 review pls consider either close it or convert it to a draft.

@johanneshiry
Do you refer to the export connected elements part (1) or the include rather than exclude fields (2) ?
Regarding 1: We still need the connected elements for building the grid topology to map the different components to the nodes they are connected to.
Regarding 2: I thought we came to the conclusion that it would make sense to go for that approach while developing, as it makes the process of incrementally including new parameters much more seamless.
So I think that it still makes sense, but I am happy to discuss it.

!test

I really like, that you do not overwhelm the user with documentation. ;-)

THANKS! Finally someone who noticed 😂

!test

!test

Added Issue #48


Add a version compatibility check to ChefDK's chef verify

As a first pass, just run through the chef-provisioning versions in ChefDK and verify that all of the included drivers have at least one compatible version. Once the foundation is in place, I'll look at expanding the version checks and also look for other things that verify can check.

Blocked on:

Releasing -provisioning 0.7 that works with chef-provisioning 1.x.
Rolling 0.7 into ChefDK so `chef verify

Blocked on:

Releasing chef-provisioning-docker 0.7 which works with chef-provisioning 1.x.
Updating chef-dk's chef-provisioning-docker to 0.7 so chef verify chef-provisioning doesn't break the chef-dk build.

So chef-provisioning-docker 0.7 has been released, and we determined that we don't actually package it inside the ChefDK.  If we are going to add it to chef verify then we probably need to start including it in the ChefDK, but that shouldn't be hard.  What do you think about that plan?

Yup: since it's not, https://github.com/chef/chef-dk/pull/433 is now decoupled and can ship any time, pending review/fix/merge.

Waiting on some test infrastructure.

Passed CI tests, hopefully this can go into 0.7.0.

Closing this because https://github.com/chef/chef-dk/pull/433 got merged and will be released in 0.7.0


compilation error

error: 'fcvt' was not declared in this scope
I followed each and every step in readme.md instructions, event though I'm getting this problem.
I installed all the mentioned libraries. I'm using DHT22 sensor and mkr1000 board.

Having the same issue, have you found a solution? Thanks!


Add support for Athena WorkGroup

Add support to specify the Athena's WorkGroup to use. Example:
athena:
  s3_bucket: bucket_name
  path: ''
  workgroup: workgroup_name

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Rodolfo Martinez Cardenas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @rmtzcx!
LGTM, @jordan-wright @kylelady this can be merged.


Fix Downlink Bandwidth Plan Frequency 915

Hello,
Based on https://www.thethingsnetwork.org/docs/lorawan/frequency-plans.html
The Bandwidth from most Frequency 915 is BW500, so I make some shenanigans to fix.
I just force downlink to change to BW500 when the frequency is 915, but I guess the right way is to create a LoraDown.bwTx  and check the package datr.
👍

The 915 plan has an uplink with BW125 and downlink with BW500, that's why I created the variable bw500_4_5 to use only on the txLoraModem function.
Probably was not the best solution but fixed the downlink problem.


The type 'Threading.Tasks.Task' is not compatible with the type 'Threading.Tasks.Task<'a>'

I am not sure if I am doing something wrong or if this is a bug, but I am getting the following error when trying to do a do! binding:
The type 'Threading.Tasks.Task' is not compatible with the type 'Threading.Tasks.Task<'a>'

This is a netcoreapp2.1 project, with the latest TaskBuilder.fs and built on the latest 2.1.400 SDK.
I also opened open FSharp.Control.Tasks.V2.ContextInsensitive.
Did I miss something?

Are you sure the error is not in next line? Different result type than inside the try/catch that happened to me a lot and error is always reported to early

Yeah I'm pretty sure, because the compiler throws the error on this line
too and the same code doesn't have a type problem with the TaskBuilder
which has the unitTask.
On Mon, 20 Aug 2018, 07:50 Steffen Forkmann<EMAIL_ADDRESS>wrote:

Are you sure the error is not in next line? Different result type than
inside the try/catch that happened to me a lot and error is always reported
to early
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rspeele/TaskBuilder.fs/issues/23#issuecomment-414214414,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEXlapK573Lq6ITpz4K-5B1ZxVWm38z7ks5uSlwpgaJpZM4WDalN
.

Ok. Was just one thing that I was seeing a lot...

Can you provide small repro?

Ok, I found the issue. It was between my chair and my keyboard. Thanks for the help!

Could you please be more specific? I think we still have at least a error
reporting issue here - probably inside of the F# compiler itself. (at least
that's what I was referring to in the stuff I was seeing)
Dustin Moris Gorski<EMAIL_ADDRESS>schrieb am Mo., 20. Aug.
2018, 21:09:

Ok, I found the issue. It was between my chair and my keyboard. Thanks for
the help!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rspeele/TaskBuilder.fs/issues/23#issuecomment-414428898,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNBk3Y_TDjq-6lZgJYpN0uehvklFAks5uSwlxgaJpZM4WDalN
.

@forki In my case I missed one place where I didn't change from FSharp.Control.Tasks to FSharp.Control.Tasks.V2.


Invalid CSS in 1.11.5

I'm using Semantic UI 1.11.5 via http://rails-assets.org and hitting a CSS syntax error which didn't exist in 1.11.4
The erroneous CSS is:
/* Menu Item */

.ui.selection.dropdown .menu > .item {
  border-top: 1px solid rgba(0, 0, 0, 0.05);
  padding-left: 1.1em !important;
  /* Add in spacing for scroll bar */
  padding-right: -webkit-calc( 1.1em  + 1em) !important~;     // <--- here
  padding-right: calc( 1.1em  + 1em) !important~;             // <--- here
  white-space: normal;
  word-wrap: normal;
}

Problem code seems to be introduced in 776b6542, and to my eye looks to have imbalanced ~ characters. I'm not familiar enough with LESS to say what this should be, otherwise this would be a pull request.

This is a typo, and shouldn't be in there.


Please provide composer link for php < 7

I"d love to use this plugin, but i'm not in a situation to update my server to PHP 7. Please provide the composer link for previous versions.

If you would like to do a pull request with a PHP 5.x compliant version of the code I will offer it in a separate branch. It is only few changes overall as the codebase is small.

Sure please.

OK, I am waiting for your pull request. I don't have time to do this myself right now.

Is anyone working on this? If not, then I am willing to "strip" the plugin so that it can run on PHP 5.5.9 (min. required) - and I plan to start basically ASAP.
From what I can see it's mostly scalar and return type hints - and there could be some traps regarding the Uniform Variable Syntax (and I found also null coalesce operator in a quick review).

PS I have it ready. I was able to render a table (had minor JS hiccups - but using latest js from CDN fixed it). I will continue developing my project - and if everything works I will be more than happy to share.

Thank you for the offer, can you do a pull request, I will then maintain in a separate branch.

Yes - please allow a few days more for testing (I have already integrated the plugin and I am hacking some serious tablework here now). Apart from that I'd gladly contribute also to examples in the wiki/doc. If I stumble upon some limitations - you can expect more pull requests from my side.

Any contributions to the docs are also highly appreciated, especially as documentation of some features is completely lacking right now.

Hi,
Here PHP5 version http://www.filedropper.com/datatables-php5
Good Luck

Thank you!
@Tartoob I used your file as a base for the new php5 branch.
@micdobro I am still happy to receive any contributions from your side!
Everybody needing PHP5 support please use the php5 branch, e.g.:
    "require": {
        "ypnos-web/cakephp-datatables": "dev-php5",
    },

@ypnos-web It works very well, except pagination not working after search. I don't know how to fix it

Could you please edit read me file, so people would know there is php 5 version


Unable to use it in Objective C projects.

Added Package to Objective C project and able to import the module. However, DotLottieAnimation is not available to use.

The support will be added? or should refer to https://github.com/dotlottie/dotlottie-ios?

hi @Nookaraju as this package is in early development I hadn't checked objective C projects. Will see how to fix, not sure how long it will take, if you're savy with packages and objective-c please feel free to submit a PR yourself!
Cheers


feat: upgrade spring boot 3.0 (java 17)

Codecov Report

Merging #36 (32962ef) into main (116462d) will increase coverage by 0.40%.
The diff coverage is 96.15%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main      #36      +/-   ##
============================================
+ Coverage     84.36%   84.76%   +0.40%
- Complexity      369      371       +2
============================================
  Files            32       32
  Lines          1765     1792      +27
  Branches        250      251       +1
============================================
+ Hits           1489     1519      +30
+ Misses          161      158       -3
  Partials        115      115

Flag
Coverage Δ

tests
84.76% <96.15%> (+0.40%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...stdocs/apispec/generator/ApiSpecificationWriter.kt
81.81% <ø> (ø)

...on/restdocs/apispec/generator/OpenApi3Generator.kt
90.37% <ø> (ø)

.../restdocs/apispec/generator/ParameterExtensions.kt
54.54% <ø> (ø)

...on/restdocs/apispec/generator/SchemaConstraints.kt
88.23% <ø> (ø)

...con/restdocs/apispec/generator/SchemaExtensions.kt
85.10% <ø> (ø)

...tdocs/apispec/generator/SecuritySchemeGenerator.kt
83.14% <ø> (ø)

...com/keecon/restdocs/apispec/gradle/OpenApi3Task.kt
100.00% <ø> (ø)

...eecon/restdocs/apispec/RestDocumentationWrapper.kt
78.43% <86.66%> (+0.17%)
:arrow_up:

...econ/restdocs/apispec/ResourceSnippetParameters.kt
90.38% <97.22%> (+2.50%)
:arrow_up:

...eecon/restdocs/apispec/model/ConstraintResolver.kt
86.48% <100.00%> (ø)

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Bug fix in GVRScene.removeAllSceneObjects

Fixes issue #1962

Improve thread-safety when accessing the main camera rig in GVRScene
Remove the detachAllComponents for all children when removeAllSceneObjects is called; it is a problem if you intend to add some of the removed children again - the scene objects would be broken due to the missing components
Some thread-safety improvements in GVRGearCursorController whenever the scene changes

Ultimately the major problem was the detachAllComponents in removeAllSceneObjects. Has been verified as fixing #1962.
GearVRf-DCO-1.0-Signed-off-by: Mihail Marinov<EMAIL_ADDRESS>

Ready for review

Planning to merge on Wednesday


Error in the (apparently) default HTML template

Describe the bug
When the documentation is generated with the default template, this HTML error (apparently a non-closed tag) appears
Screenshots

Raku version is 2020.06, documentable version 1.3.1

I have added a message to see what template is being used. The template used in that case looks incomplete, so I think is not using the latest one.
Anyway,  while looking into this I have found two errors in the template:

Index page has a submenu:

Extra quoting in toc.


Fixes podspec errors.

Fix: #20
Fixes podspec errors.
Some attributes are referenced from package.json.

Thank you! ❤


Enable one unit test in a bunch of Unit Tests

We have a package that has 15 unit tests, Is there any possibility to run only one of them instead of mentioning --%disabled on the others 14 tests?

ut.run('schema.package.procedure');
That sould do the trick.

You can run individual test procedure from UI too.

ut.run('schema.package.procedure');
That sould do the trick.

Much appreciate mate

You may also have a look into utPLSQL documentation for more details or look in the resouces page for some good blogs/videos.


Remove filling from selected squares

Once the user selects a square (on click) the style should switch from solid color to just outline. This allows to see footprints and background map better. The edge of selected squares could be made ticker to indicate the current selection.

@cgiovando The outline of the selected square may potentially be confused with the outline of the footprints. We can take a look at the opacity of the selected color to see where improvements can be made.

How about just using different colors and thickness for image footprints and grid lines?


Struggling with Registering Two VEDO Volume Data

Struggling with Registering Two VEDO Volume Data
I'm currently engaged in a task where I need to register two volume data from VEDO. I've been attempting to utilize various libraries like SimpleITK with its Elastix registration capabilities to get this done.
I know that accurate registration of volume data is essential for further analysis and understanding, especially when it comes to dealing with the complex 3D data that VEDO offers. However, despite my numerous tries and adjustments of parameters according to the library documentation, I just can't seem to make it work.
I've explored different aspects such as setting up the initial transforms, choosing appropriate similarity metrics, and tweaking the optimization algorithms, but still, no success.
So, I'm really hoping that there are some good examples out there that can demonstrate how to effectively register these two VEDO volume data using libraries like SimpleITK's Elastic or other relevant ones. Any guidance or references to such examples would be extremely helpful and would surely save me a great deal of time and headache in this rather frustrating process.
Thanks a lot in advance for any kind of assistance!

Hi @skhwhu I can only offer support for vedo and indeed you may find other tools that offers registration capabilities...
I see basically 2 options.

doing it directly at the level of Volume needs assuming you know e few corresponding points that are supposed to match
use a preliminary step by creating an isosurface to determine such points more easily.
If the registration is meant to be automatic then it becomes an optimization problem.
you may want to share some image of your specific task to have a better intuition of your objectives.


Possibility to add authorization headers to the GraphQLTestSubscription

Describe the bug
Hi all, I'm getting the following error when attempting to create a subscription to one of our endpoints, which is protected by OAuth2. The exception makes sense, however I'm unable to find a way to attach the token as a header to the connection that's being made.
I can see that headers can be added through the TestWebSocketClientConfigurator, but no way to add custom headers to it, neither switch it out for a different implementation. Is there something I'm missing on the session that would allow this?
Caused by: javax.websocket.DeploymentException: Failed to handle HTTP response code [401]. Unsupported Authentication scheme [Bearer] returned in response
	at app//org.apache.tomcat.websocket.WsWebSocketContainer.processAuthenticationChallenge(WsWebSocketContainer.java:524)
	at app//org.apache.tomcat.websocket.WsWebSocketContainer.connectToServerRecursive(WsWebSocketContainer.java:396)
	at app//org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer(WsWebSocketContainer.java:185)
	at app//com.graphql.spring.boot.test.GraphQLTestSubscription.initClient(GraphQLTestSubscription.java:532)
	at app//com.graphql.spring.boot.test.GraphQLTestSubscription.init(GraphQLTestSubscription.java:105)

To Reproduce
Steps to reproduce the behavior:

Create an subscription resolver protected by isAuthorized()
Attempt to fetch data from this endpoint in a test:

graphQLTestSubscription
            .init("some-subscription.graphql")
            .awaitAndGetAllResponses(Duration.ofSeconds(1))

Expected behavior
It should take into account @MockUser or ideally allow setting custom headers especially for authentication. GraphQLTestTemplate specifically has graphQLTestTemplate.withBearerAuth().

@BlasiusSecundus might you have a recommendation here?

Hi @maxkramer were you able to figure out how to send oAuth access tokens to Spring Boot based GraphQL dynamically / programmatically? We are trying to do the same thing where we are launching GraphQL from  a web page. We want the web page to pass the oAuth JWT access tokens so that GraphQL can enforce authorization when user executes queries using the information in the token.

Hi @maxkramer, sorry for not responding earlier. AFAIK there is no standard way to handle authentication via GraphQL subscriptions.
One possibility is to put the auth token in the connection_init (via providing  a payload for the GraphQLTestSubscription.init method) or the start message payload. Then handling it on the other side by providing an implementation of ApolloSubscriptionConnectionListener.
Then verifying the token and putting necessary things into Spring Security context. See also https://github.com/graphql-java-kickstart/graphql-java-servlet/discussions/134

See also a similar approach of the Apollo Server JS implementation: https://www.apollographql.com/docs/apollo-server/data/subscriptions/#onconnect-and-ondisconnect

Hi @vikforfda, @BlasiusSecundus, I did indeed manage to get a working solution. I can't remember the exact resource I used for it, but the links you shared are very close. (Kotlin) Code. I'm not very happy with the solution in the sense that I would've hoped the library would've supported this case specifically as it's something supported by Apollo out of the box with the connection params. I know there's no "best practice" or even recommended practice for handling auth tokens with subscriptions, but it needs to start from somewhere! Hope this is helpful!
@Component
internal class GraphQLSubscriptionAuthenticationListener(
    private val authenticationProvider: AuthenticationProvider,
) : ApolloSubscriptionConnectionListener {
    override fun onConnect(session: SubscriptionSession, message: OperationMessage) {
        val authToken = (message.payload as Map<*, *>)[AUTH_TOKEN_PAYLOAD_KEY] as? String
        if (authToken != null) {
            val authentication = authenticationProvider.authenticate(BearerTokenAuthenticationToken(authToken))
            SecurityContextHolder.getContext().authentication = authentication
            session.userProperties[AUTHENTICATION_USER_PROPERTY_KEY] = authentication
        }
    }

    override fun onStart(session: SubscriptionSession, message: OperationMessage) {
        val authentication = session.userProperties[AUTHENTICATION_USER_PROPERTY_KEY] as? Authentication
        SecurityContextHolder.getContext().authentication = authentication
    }

    companion object {
        private const val AUTH_TOKEN_PAYLOAD_KEY = "authToken"
        private const val AUTHENTICATION_USER_PROPERTY_KEY = "AUTHENTICATION"
    }
}

@maxkramer  @BlasiusSecundus Will this work with the embedded /playground? please see my question here.
https://github.com/graphql-java-kickstart/graphql-spring-boot/discussions/928

@skesani we're just discussing the webhooks here, but re the headers, I haven't personally played around with setting them automatically via yaml as our access tokens aren't long living. Somebody I worked with in the past created a bookmark that ran some js that fetched a new token and injected it automatically into the http headers section. But according to the docs, I believe it should be this in the application.yaml:
graphql:
    playground:
        headers:
            Authorization: Bearer ey.someToken

There's also a graphql.playground.settings.editor.reuse-headers that perhaps is related?
@vikforfda we're using the graphql kickstart spring boot starter, I'm not sure which one that's using as we haven't had a need to look into anything further.

In your case did you use the Apollo Server version of GraphQL since we want to use the Open source version of GraphQL

@vikforfda ApolloSubscriptionConnectionListener is actually part of this library: https://github.com/graphql-java-kickstart/graphql-java-servlet/blob/master/graphql-java-kickstart/src/main/java/graphql/kickstart/execution/subscriptions/apollo/ApolloSubscriptionConnectionListener.java

@skesani Yes, it will work. The variables set in the "HTTP headers" tab will be sent to the server as the payload of the connection_init message.

@skesani Yes, it will work. The variables set in the "HTTP headers" tab will be sent to the server as the payload of the connection_init message.

@BlasiusSecundus  could you provide any sample to set the token programmatically?

@skesani Variables from configuration are already passed to Playground in PlaygroundController. That would be the natural place to extend its functionality so that it can take headers from sources other than configuration properties. (E.g. some configurator bean as you proposed).

Returning to the original question / bug report, I think this issue should be closed:

I don't see any bug or necessary improvement as far as GraphQLTestSubscription  is concerned. It is possible to send the authorization token to the server as part of the payload of the connection_init message, which is sort of the preferred way. Playground automatically does this (sending the "HTTP Headers" as payload of  connection_init) out of the box.
There are two related, but functionally independent improvement suggested in this discussion:

built-in support for authenticated subscriptions (currently, the necessary credentials processing, Spring Security integration etc. has to be done by the user of the library)
more flexibility when configuring default headers for developer utilities (Playground and others) - currently, it is only possible using configuration properties, which may not be suitable for some more advanced scenarios (e.g. obtaining access token from an authentication server when opening Playground)

These two should be handled as separate issues (flagged as enhancement).

@skesani Variables from configuration are already passed to Playground in PlaygroundController. That would be the natural place to extend its functionality so that it can take headers from sources other than configuration properties. (E.g. some configurator bean as you proposed).

@BlasiusSecundus I created this repo and added MyConfig and MyPlaygroundController extends PlaygroundController however, I am unable to override the headers, could you please take a look?
https://github.com/skesani/graphql-playground


issues

https://github.com/DonSqualo/Naext-one-for-RemNote/blob/f9307f3554121efe52b35ac8254374dee0225aa2/src/widgets/index.tsx#L42
there's no ae-tag file
https://github.com/DonSqualo/Naext-one-for-RemNote/blob/f9307f3554121efe52b35ac8254374dee0225aa2/src/widgets/index.tsx#L38
you're registering in the right sidebar rather than the right side of editor
https://github.com/DonSqualo/Naext-one-for-RemNote/blob/f9307f3554121efe52b35ac8254374dee0225aa2/src/widgets/sample_widget.tsx#L7
you misspelled priority, you should create a file like consts.ts and export variables for powerup / slot codes to avoid this
after fixing:

Sorry, the ae-file didn't get uploaded, still struggling with GitHub after switching to SSH
Also the RightSidebar is still example code I think
And the misspelling is something I catched earlier, interesting that it's back again


How to use with Nuxt?

Hi there,
I was wondering if this is usable with Nuxt?
Kind regards

It should! If not, please provide a reproduction repo to help me debug. Thanks!

Could you hook me up with an example? Im very new to Nuxt so I'm having a hard time figuring out how I should add it.
I attempted creating a Nuxt plugin and using doing Vue.useComponent(SkinRender3d) but it didn't seem like a working or the right solution.

I created a plugin like this:
`import Vue from 'vue';
import { SkinView3d } from 'vue-skinview3d/index';
Vue.component('SkinView3d', SkinView3d);`
then imported it like this:
  plugins: [     "~/plugins/skinrender3d.ts",   ],
and attempted to use it like this
`

`

Managed to find the issue, seems to be working great. Thanks

You don't have to register a global component, just import it and use in the template:
<script setup lang="ts">
import { SkinView3d } from "vue-skinview3d";
</script>

<template>
  <SkinView3d />
</template>


Fix clang tidy workflow

@vgvassilev This PR makes the same changes to the clang tidy workflow as was made in clad.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.31%. Comparing base (60fb73d) to head (bcefee0).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   79.31%   79.31%
=======================================
  Files          17       17
  Lines         609      609
  Branches       59       59
=======================================
  Hits          483      483
  Misses        126      126


feat(services/gcs): Add customed token loader support

May need more doc

reqsign is not stable yet, we just expose this function directly. We could add our own trait instead.


Attach remote kuzu database

This PR allows user to introduce a remote kuzu database.
To load an attached kuzu database, users must have to install/load httpfs extension first by:
install httpfs;
load extension httpfs;

Then they can attach using:
attach 'https://testdb' (dbtype 'kuzu')

Finally, they can query any tables in testdb as querying local database.
match (p:person) return p

This is beautiful <3 I'll start tinkering with it soon!


Rollup Field document issue: Actual, In-progress, Custom Rollup Field

[Enter feedback here]
Hi,
There is a little bit confusion inside this definition
Current definition: "Rollup Field. Select a rollup field where the metric rollup data will be displayed in the goal. You can display an integer or money, depending on the Metric Type you chose. You can't select a field you already added to the metric."
Note: in Rollup Field Option Set I can't chose an item "Money" or "Integer". I must chose an item between "Actual (metric type)", "In-progress (metric type)" or "Custom Rollup Field (metric type)"
My proposed definition: "Rollup Field. Select a rollup field where the metric rollup data will be displayed in the goal. You can display an Actual,In-progress or Custom Rollup Field.  You can't select a field you already added to the metric."
In my opinion it would be nice to add the definition of "Actual", "In-progress" or "Custom Rollup Field" here! In particular, what is "Custom Rollup Field" for? Because there isn't a definition about these values.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7590f9ea-3cd2-8f52-07cb-d70cdd715be4
Version Independent ID: c04f03c9-71d2-0a0b-d37d-ef7a89a01d3d
Content: Define a goal metric (Dynamics 365 Sales)
Content Source: ce/sales-enterprise/create-edit-goal-metric.md
Service: dynamics-365-sales
GitHub Login: @shubhadaj
Microsoft Alias: shujoshi

Hi @DavidPezzoli,
Sincere apologies for the delay and thank you so much for your feedback. I've updated the doc with your inputs.
I'm closing the issue. Please feel free to reopen it if you think the issue is not addressed to your satisfaction.
Regards,
Lavanya Krishnamurthy


wrong error when imported file ends with expression

mybug.nim:
let a = @["a", "b", "c"]
echo a
a

inim
import mybug
/private/tmp/inim_1531877xxx.nim(1, 6) Error: undeclared identifier: 'a'

here we probably want to give nim's error un-modified:
mybug.nim(3, 1) Error: expression 'a' is of type 'seq[string]' and has to be discarded
a

Fixed in v0.4.1
👑 INim 0.4.1
Nim Compiler Version 0.18.1 [Linux: amd64] at /home/user/.nimble/bin/nim
nim> import mybug
/home/user/mybug.nim(3, 1) Error: expression 'a' is of type 'seq[string]' and has to be discarded
nim>


Add HTML  tag to core components

What is the expected behaviour?
Add the HTML <data> tag, as specified here: https://www.w3schools.com/tags/tag_data.asp

Closed via #298


Datamap sheet field issues

If a sheet-block (however many rows pertaining to a particular sheet) of rows in the datamap has its sheet field missing/blank, then that row will now migrate during the export process, However, if the first row of the block is intact and the other sheet fields are missing for that particular block, then the data will actually be migrated.
This will cause a problem if the gap in the sheet entries spans the boundaries between blocks because the program won't know where the change in sheet happens.
Example:
cell_key,template_sheet,cellreference,type
Project/Programme Name,,C11,TEXT  # missing sheet herel the rest of the `Introduction` sheets will migrate
Department ,Introduction,C9,TEXT
Delivery Body ,Introduction,C10,TEXT
GMPP - IPA ID Number,Introduction,C12,TEXT
Controls Project ID number,Introduction,C13,NUMBER
Project Type (for IPA use),Introduction,C14,TEXT
Classification,Introduction,C15,TEXT
GMPP (GMPP - formally joined GMPP),Introduction,C16,TEXT
Reporting period (GMPP - Snapshot Date),Introduction,C17,DATE
Snapshot Date,Introduction,C18,DATE
Senior Responsible Owner (SRO),Introduction,C21,TEXT
Senior Responsible Owner (SRO) - Email,Introduction,C22,TEXT
Senior Responsible Owner (SRO) - ID number,Introduction,C23,NUMBER
SRO Sign-Off,Introduction,C24,DATE
Bad Spacing , Introduction, c35,TEXT
String Key,Summary,B3,TEXT
Big Float,Another Sheet,F17,NUMBER
Funny Date,Another Sheet,H39,DATE

cell_key,template_sheet,cellreference,type
Project/Programme Name,Introduction,C11,TEXT
Department ,,C9,TEXT  # second row sheet missing - all `Introduction` sheets will export
Delivery Body ,Introduction,C10,TEXT
GMPP - IPA ID Number,Introduction,C12,TEXT
Controls Project ID number,Introduction,C13,NUMBER
Project Type (for IPA use),Introduction,C14,TEXT
Classification,Introduction,C15,TEXT
GMPP (GMPP - formally joined GMPP),Introduction,C16,TEXT
Reporting period (GMPP - Snapshot Date),Introduction,C17,DATE
Snapshot Date,Introduction,C18,DATE
Senior Responsible Owner (SRO),Introduction,C21,TEXT
Senior Responsible Owner (SRO) - Email,Introduction,C22,TEXT
Senior Responsible Owner (SRO) - ID number,Introduction,C23,NUMBER
SRO Sign-Off,Introduction,C24,DATE
Bad Spacing , Introduction, c35,TEXT
String Key,Summary,B3,TEXT
Big Float,Another Sheet,F17,NUMBER
Funny Date,Another Sheet,H39,DATE

cell_key,template_sheet,cellreference,type
Project/Programme Name,Introduction,C11,TEXT
Department ,Introduction,C9,TEXT
Delivery Body ,Introduction,C10,TEXT
GMPP - IPA ID Number,Introduction,C12,TEXT
Controls Project ID number,Introduction,C13,NUMBER
Project Type (for IPA use),Introduction,C14,TEXT
Classification,Introduction,C15,TEXT
GMPP (GMPP - formally joined GMPP),Introduction,C16,TEXT
Reporting period (GMPP - Snapshot Date),Introduction,C17,DATE
Snapshot Date,Introduction,C18,DATE
Senior Responsible Owner (SRO),Introduction,C21,TEXT
Senior Responsible Owner (SRO) - Email,Introduction,C22,TEXT
Senior Responsible Owner (SRO) - ID number,Introduction,C23,NUMBER
SRO Sign-Off,Introduction,C24,DATE
Bad Spacing , , c35,TEXT # missing last `Introduction` and..
String Key,,B3,TEXT #.. first summary. This row likely end up targeting `Introduction` sheet
Big Float,Another Sheet,F17,NUMBER
Funny Date,Another Sheet,H39,DATE

The code handling this is currently at engine/repository/templates.py(39), _populate_workbook().  The test is test_populate_templates_from_master.py.test_export_continues_with_missing_sheet_in_datamap`.
The best solution here is to use the initial datamap check to ensure that every datamap row has the requisite fields, and warn the user before it procedes.

New test required in test_datamap_parser.py - stub created. Need to focus on engine.utils.extraction.datamap_reader() which should reject any badly formatted datamap file. All exceptions raised here should be passed to main() and handled with appropriate log messages.

New test required in test_datamap_parser.py - stub created. Need to focus on engine.utils.extraction.datamap_reader() which should reject any badly formatted datamap file. All exceptions raised here should be passed to main() and handled with appropriate log messages.

Fixed by raising exception when sheet field is missing, and datamaps quits, asking the user to correct the datamap.


nRF54L15 FLPR misc test fixes

All these commits are merged upstream, so it would be better to cherry pick them as [nrf fromtree].

@anangl done

@anangl done

[nrf fromtree] commits should refer to SHAs of the merged commits, not those from PRs, so you need to use:

e17b3fd884c8090ae2a1e56d4c999103800254da
68c48cd1168e409cb64170f6fb5c7925e1e935f8
8999446ab81a479fd74d6dab329a65c653c47f3c
809c6c34d376d8dd91822f5cda93bc5f23c52fdc

@anangl My bad, fixed.


Accept request changes from PR #20

Changed log

Remove unused class namespace.
Using the $invalidFileUrl variable , not using value directly.

Thanks a lot for the PRs, much appreciated :)

@JeroenDeDauw, thank you for your concern.
I also appreciate your effort about merging this PR :-).


Wrapping code in #if UNITY_WSA for cross-platform support per #387

See https://github.com/Microsoft/HoloToolkit-Unity/issues/387
Prior to this PR, including HoloToolkit-Unity in a cross-platform Unity project would break all non-Windows Store (UNITY_WSA) platforms.  There are a huge number of files in the project so this PR undoubtedly #if's out code that could safely be included in other platforms but at least it no longer takes down other platforms when included in projects.
There are zero functional changes in this PR other than wrapping code in #if UNITY_WSA blocks and changing a couple #if UNITY_METRO's to #if UNITY_WSA (UNITY_METRO is a deprecated #define for the code paths now referred to as UNITY_WSA).
As part of adding these changes, I started out by adding all the #if/#endif pairs at the top and bottom of the files, which led me to spot and correct a number of files that were missing standard Microsoft copyright comment blocks. After making that first pass at doing the outermost wrapping of the code, I realized that the #if's needed to be moved inside the MonoBehaviour class definitions so behaviors added to GameObjects in the editor would remain visible and connected to the objects when the build platform changed. Moving the #if's inside the MonoBehaviour class definitions forced many/most of the misc. classes in the project to be treated the same way (because they were involved as interfaces or generics in the MonoBehaviour-derived class declarations). This led me to do a pass moving all the #if UNITY_WSA's just inside the class definitions for all the classes. And that led to a final pass where a few of the classes needed hand-tweaked inner exclusions to prevent missing interface members and contained structs/classes from breaking the build.
There was a large set of files that were auto-generated using SWIG (https://github.com/Microsoft/HoloToolkit-Unity/search?utf8=✓&q=swig). These files contained a standard banner heading indicating they were auto-generated and should not be modified directly, so I didn't. Fortunately their presence doesn't appear to impact the cross-platform compatibility of the toolkit.
At this point the modified Toolkit can be included in cross-platform projects without breaking the build.

Hi @yoDon, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@HodgsonSDAS: are your sufficiently familiar with the automated build test suite for the project to be able to wrap the build process it in a loop that builds for both say UNITY_WSA, UNITY_STANDALONE_WIN, and UNITY_ANDROID (or some similar mix that would start to test that at a minimum builds are not broken on non-UNITY_WSA platforms)? The cross-platform tests would be limited initially to "does it not break the build?" since that's all we're trying to guarantee today.
Adding the automated build testing would prevent new build breakage from creeping in accidentally and would give us a lot more confidence in a future PR to start removing a ton of the unnecessary/overly conservative #if wrappers added in this PR, in order to begin restoring/providing actual cross-platform support.
Also, just for completeness, the issue this PR is designed to address was written solely around "the toolkit should not break cross-platform builds." A separate issue of "the toolkit should work cross platform" would be great but would be a separate issue.

Understood.

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

Hi @yoDon, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

I still feel as though it's important keep as much functionality as possible without just excluding everything in each class.

Specifically, what parts of the toolkit are needed in your cross platform apps?

Add the toolkit to a project (or open the toolkit itself in Unity). Open a new scene (standard empty scene, just a camera). File->Build Settings..., switch to Android or Or iOS or OSX or anything non-WSA. Boom.   Doesn't matter what you want to do, you have to delete the toolkit and give up your plans to integrate it in your project because you just completely broke your builds without even adding any functionality.
On Jan 4, 2017, at 8:25 AM, Stephen Hodgson <notifications<EMAIL_ADDRESS>wrote:
Specifically, what parts of the toolkit are needed in your cross platform apps?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/HoloToolkit-Unity/pull/443#issuecomment-270414147, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABrdwVPJL1id1Om2ZMx40RMqxrcpgBwkks5rO8fegaJpZM4LY0qQ.

I understand the problem and fully support the cross platform capabilities, but I think it's important to first understand the requirements of that capability to better understand the changes needed.

Again, the initial requirement/issue already reported is "Don't break the build." Until that issue is resolved there's really no way for me to answer any questions about what functionality I want to use cross platform because I can't try it at all.
Please don't block solution of the "don't break the build" issue with broad/deep/open-ended questions like these. Please instead open a second issue that says something like "Many Toolkit features should work cross platform" and copy this great discussion into that issue so it can be tracked properly and resolved/addressed. It's important, but until the "don't break the build" issue is resolved those of us with actual cross-platform projects can't actually provide any feedback on any of the features we might need available because we can't even add the toolkit to our projects let alone start trying to use it.
On Jan 4, 2017, at 8:42 AM, Stephen Hodgson <notifications<EMAIL_ADDRESS>wrote:
I understand the problem and fully support the cross platform capabilities, but I think it's important to first understand the requirements of that capability to better understand the changes needed.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/HoloToolkit-Unity/pull/443#issuecomment-270419159, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABrdwYkzG7lx-UrgcccXww0oejbAcoFRks5rO8v4gaJpZM4LY0qQ.

My apologies, it's not my intention to "block" your solution, but I was trying to add to the discussion the possibility of other potential solutions.
Discussions like these are important so everyone understands and agrees to the purposed changes.

I second @yoDon.
Main usecase might be: you have an existing project (e.g. one where Oculus/Rift/GearVR packages happily coexist) and you want to also be able to use that project with Hololens. You will most likely import the Hololens package, put the Hololens-specific code into the right places (probably wrapped by other code) and still want to be able to compile for GearVR and all the other things.
And vice versa, you started for Hololens but now want GearVR support for the same project.

In our case we need to do a PC build for Windows 10. So we switch platforms
in Unity in The build target window. When you go to build for the PC about
14 classes show up as build errors. Deleting those classes allows us to
then build for the PC x86. We have to add them back in when we build for
Hololens.
These #if UNITY_WSA will work. It is not unusual in Unity to have more than
one platform target assets and scripts in your project so you can switch at
will. In our case we use our Hololens assets in other build targets as
well. So one build for the Hololens and one build for the PC. This keeps
you from having multiple projects that need updated assets added to them
during dev time.
Hope this helps!
On Wed, Jan 4, 2017 at 9:42 AM, soraryu<EMAIL_ADDRESS>wrote:

I second @yoDon https://github.com/yoDon.
Main usecase might be: you have an existing project (e.g. one where
Oculus/Rift/GearVR packages happily coexist) and you want to also be able
to use that project with Hololens. You will most likely import the Hololens
package, put the Hololens-specific code into the right places (probably
wrapped by other code) and still want to be able to compile for GearVR and
all the other things.
And vice versa, you started for Hololens but now want GearVR support for
the same project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/HoloToolkit-Unity/pull/443#issuecomment-270435130,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJAJprkPPkZf2c_RCm9wRR1VH9VMkxVnks5rO9n3gaJpZM4LY0qQ
.

@studio216 – can you submit a competing PR to mine that just #if UNITY_WSA’s those 14 classes? As much as I’d love to have my PR accepted, your experience sounds like a much smaller more tactical solution that would make it much faster/easier to focus resources on the long term goal of actual cross-platform functionality for the toolkit.
From: Dell Wolfensparger<EMAIL_ADDRESS>Sent: Wednesday, January 4, 2017 10:07 AM
To: Microsoft/HoloToolkit-Unity<EMAIL_ADDRESS>Cc: Don Alvarez<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/HoloToolkit-Unity] Wrapping code in #if UNITY_WSA for cross-platform support per #387 (#443)
In our case we need to do a PC build for Windows 10. So we switch platforms
in Unity in The build target window. When you go to build for the PC about
14 classes show up as build errors. Deleting those classes allows us to
then build for the PC x86. We have to add them back in when we build for
Hololens.
These #if UNITY_WSA will work. It is not unusual in Unity to have more than
one platform target assets and scripts in your project so you can switch at
will. In our case we use our Hololens assets in other build targets as
well. So one build for the Hololens and one build for the PC. This keeps
you from having multiple projects that need updated assets added to them
during dev time.
Hope this helps!
On Wed, Jan 4, 2017 at 9:42 AM, soraryu <notifications<EMAIL_ADDRESS>wrote:

I second @yoDon https://github.com/yoDon.
Main usecase might be: you have an existing project (e.g. one where
Oculus/Rift/GearVR packages happily coexist) and you want to also be able
to use that project with Hololens. You will most likely import the Hololens
package, put the Hololens-specific code into the right places (probably
wrapped by other code) and still want to be able to compile for GearVR and
all the other things.
And vice versa, you started for Hololens but now want GearVR support for
the same project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/HoloToolkit-Unity/pull/443#issuecomment-270435130,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJAJprkPPkZf2c_RCm9wRR1VH9VMkxVnks5rO9n3gaJpZM4LY0qQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/HoloToolkit-Unity/pull/443#issuecomment-270441618, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABrdwZnYpBO3nwC-O8AoZeTOzJJVyICNks5rO9_YgaJpZM4LY0qQ.

@yoDon
Well in our case we still end up with warnings after the build... Not sure
if that would be suitable for a release repro. There are more elegant
solutions. But thanks for the idea of a subset. I'm curious how this turns
out as I am sure this is a typical use case.
On Wed, Jan 4, 2017 at 10:14 AM, yoDon<EMAIL_ADDRESS>wrote:

@studio216 – can you submit a competing PR to mine that just #if
UNITY_WSA’s those 14 classes? As much as I’d love to have my PR accepted,
your experience sounds like a much smaller more tactical solution that
would make it much faster/easier to focus resources on the long term goal
of actual cross-platform functionality for the toolkit.
From: Dell Wolfensparger<EMAIL_ADDRESS>Sent: Wednesday, January 4, 2017 10:07 AM
To: Microsoft/HoloToolkit-Unity<EMAIL_ADDRESS>Cc: Don Alvarez<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: Re: [Microsoft/HoloToolkit-Unity] Wrapping code in #if UNITY_WSA
for cross-platform support per #387 (#443)
In our case we need to do a PC build for Windows 10. So we switch
platforms
in Unity in The build target window. When you go to build for the PC about
14 classes show up as build errors. Deleting those classes allows us to
then build for the PC x86. We have to add them back in when we build for
Hololens.
These #if UNITY_WSA will work. It is not unusual in Unity to have more
than
one platform target assets and scripts in your project so you can switch
at
will. In our case we use our Hololens assets in other build targets as
well. So one build for the Hololens and one build for the PC. This keeps
you from having multiple projects that need updated assets added to them
during dev time.
Hope this helps!
On Wed, Jan 4, 2017 at 9:42 AM, soraryu<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

I second @yoDon https://github.com/yoDon.
Main usecase might be: you have an existing project (e.g. one where
Oculus/Rift/GearVR packages happily coexist) and you want to also be
able
to use that project with Hololens. You will most likely import the
Hololens
package, put the Hololens-specific code into the right places (probably
wrapped by other code) and still want to be able to compile for GearVR
and
all the other things.
And vice versa, you started for Hololens but now want GearVR support for
the same project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/Microsoft/HoloToolkit-Unity/pull/443#
issuecomment-270435130>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJAJprkPPkZf2c_
RCm9wRR1VH9VMkxVnks5rO9n3gaJpZM4LY0qQ>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/
Microsoft/HoloToolkit-Unity/pull/443#issuecomment-270441618>, or mute the
thread<https://github.com/notifications/unsubscribe-auth/ABrdwZnYpBO3nwC-
O8AoZeTOzJJVyICNks5rO9_YgaJpZM4LY0qQ>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/HoloToolkit-Unity/pull/443#issuecomment-270443465,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJAJpiGQOx0gK57xIOaM2jz03ufXLrxTks5rO-F5gaJpZM4LY0qQ
.

I'm really interested in the delta from the HTP-5.4.0f3 editor and the 5.5.0f3 that broke the existing cross platform support.
This project used to be cross platform until Unity changed the way they handle UWP/METRO

Does it makes sense for the HoloToolkit-Unity to be cross platform?
We have the vanilla HoloToolkit.
We could also provide just the glue for network connectivity for companion applications using the sharing library is a separate Unity Package.

"Does it makes sense for the HoloToolkit-Unity to be cross platform?"
Yes.
Unity is a cross-platform development environment. Most (many?) large Unity projects are cross-platform. At present, simply checking out the files HoloToolkit-Unity into your project (without even adding any of the functionality to your application) is enough to break the build on all non-WSA projects. This is a complete deal-breaker preventing any such project from even considering using the HoloToolkit-Unity.
In the notes to my PR, @studio216 suggested there is a lower-impact way to do the #if-defing, which is great but no one has had time to wrap it up as a competing PR.
What's really needed most is an extension to the test harness that checks for errors when the build settings are set to non-WSA platforms, because cross-platform "don't break the build" support needs to be maintained not just in the moment but going forward.

Awesome discussion. Thank you for raising the importance of the issue.
Scenario: Anne is a developer who wants to ship her HoloLens app to the Windows Store. She also would like to use the same code base, extend it to work on other VR platforms and ship on their store.
I am a supporter of ensuring HoloToolkit-Unity compiles with different target platforms in the same Unity project. Also it should work for all devices that support Windows Holographic or Mixed Reality.
However, to burden the toolkit with ensuring everything works across different platforms (like iOS / oculus etc.) is overkill for it's current majority developer audience who are still growing as the ecosystem grows.
About this PR: I agree and super support the intent of the change. But not a fan of having every file having an #ifdef inside it :( Some approaches that we all could investigate and report back?

What if we change the build settings to a different platform and evaluated the exact files that need the #ifdef ?
Then only those files get updated instead of the entire repository.
Research any other techniques? Perhaps checking on the Unity forums for ideas?

I agree with point 1. That is what I do and it works. Add #ifdef for only
the files needed. (I think there are about 14). My suggestion is to start
with using #ifdef for the PC/Windows target on the Unity Engine.  Most devs
will be start by compiling for both. Many use cases will involve the
Hololens app running on the device and another version of it running under
Windows/PC builds even though the Windows/PC build is not a VR target.
On Thu, Jan 19, 2017 at 12:44 PM, Neeraj Wadhwa<EMAIL_ADDRESS>wrote:

Awesome discussion. Thank you for raising the importance of the issue.
Scenario: Anne is a developer who wants to ship her HoloLens app to the
Windows Store. She also would like to use the same code base, extend it to
work on other VR platforms and ship on their store.
I am a supporter of ensuring HoloToolkit-Unity compiles with different
target platforms in the same Unity project. Also it should work for all
devices that support Windows Holographic or Mixed Reality.
However, to burden the toolkit with ensuring everything works across
different platforms (like iOS / oculus etc.) is overkill for it's current
majority developer audience who are still growing as the ecosystem grows.
About this PR: I agree and super support the intent of the change. But not
a fan of having every file having an #ifdef inside it :( Some approaches
that we all could investigate and report back?

What if we change the build settings to a different platform and
evaluated the exact files that need the #ifdef ?
Then only those files get updated instead of the entire repository.
Research any other techniques? Perhaps checking on the Unity forums
for ideas?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/HoloToolkit-Unity/pull/443#issuecomment-273893001,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJAJpjqXP-ImOmp6V54rbclH9etsniW2ks5rT8sugaJpZM4LY0qQ
.

Please for the love of god implement this.
Every time I update holotoolkit I must put in the #if UNITY_WSA tags so that I can build my app for non hololens / windows versions...
It was explained several times in these posts that this is imperative, why does it take so long for the pull request to be approved.

I cannot merge while there are conflicts with the master.
This branch has conflicts that must be resolved

There are conflicts because it took months of debating instead of implementing it from the start. Next time I go through the effort to put in the pre-compiler tabs I will do a pull request, if someone else doesn't do it before then.

I will do a pull request

Thanks, that sounds great, looking forward to it!

I will do a pull request

Thanks, that sounds great, looking forward to it!

Closed in favor of https://github.com/Microsoft/HoloToolkit-Unity/pull/740.


add detection for mac randomization

If OUI is not found from manuf package, attempt to detect if client MAC is an LAA MAC, and note that the client is using MAC randomization.
Notes from Adrian:

When Apple started randomizing MACs in iOS 8, they would randomize every byte of the MAC but still generating LAA MACs. Then, in iOS 10, they started using an Apple OUI, flipping the LAA bit and randomizing the remaining 3 bytes of the address.
There's another IEEE registry database called CID (company identifier) that provided OUIs to be used as LAAs but only a few companies have registered there. Google is one and I think they have used their CID OUI for randomization in Android. Apple is not there. http://standards-oui.ieee.org/cid/cid.csv
You can look at the vendor specific IEs and see if there’s information there that can help you identify the vendor. In some cases, like Apple, there’s no more confusion. In others, the presence of a vendor-specific IE doesn’t mean the device is from that manufacturer.

basic detection added in https://github.com/joshschmelzle/profiler2/commit/976cec7d48e0e049ed0f4b9fa9eab2aaf4365464
CID detection has not been added.


Fix refresh parser initialization bug

As a result of refactor introduced by commit
b7fae038b3d70e55a4e22a45e4a0661ed9958a67, the attempt
to initialize the refresh parser failed.
The PR is changed to support the new class which is responsible
to parser the VM data.

@miq-bot assign @borod108

@miq-bot add_label euwe/no, providers/rhevm, refactoring

@miq-bot add_label euwe/no
@miq-bot add_label providers/rhevm
@miq-bot add_label refactoring

@miq-bot assign @durandom
This is quite urgent some automation things will not work properly without this fix.

@miq-bot assign @durandom

@durandom hi, any news on this?

oh, miq-bot was on PTO, sorry

@miq-bot assign @agrare
@agrare can you merge this please?

@durandom agreed this should be covered by spec tests, there are tests for the refresh_new_target code here https://github.com/ManageIQ/manageiq/blob/master/spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_target_vm_spec.rb but it looks like that is only covering the second stage of refreshing a new vm.
@borod108 @masayag can you look into adding spec coverage for refresh_new_vm in a follow-up PR?

@agrare sure, added as a task in trello once @durandom raised this issue earlier in the review of this PR. We'll address that soon.

Thanks @masayag


Rework of 6.2.2405

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11942057061.

For linux aarch64 wrong name:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1086573&view=logs&j=5b44946f-b0b5-570f-e735-950feabb4722&t=d53332be-ec07-565d-9b53-75513afd6eda&l=2035
For osx_arm64 compilation fails due to trying to run a tool that was compiled few steps before. So is it actually possible to x-compile netegen?


Zero dsl

Introduction of inline functions generated with new zero dsl

Beautiful!

Soon we can post a short article describing all the new stuff to the forum or subreddit: we can see what people thing of the extension mechanism and the lib vs eventual Nim high order iterators thing


Propagate UserState to PollingMasterInquireClient

Currently PollingMasterInquireClient uses a new Subject when querying master. If the call needs authentication using credentials from Subject, it will fail the request because the credentials are missing. This change add parameters to APIs to allow passing in the required Subject.
Manually tested with external Subject from Hadoop client.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6102/
Test PASSed.

@gpang @ggezer PTAL.

This should pass in the UserState, instead of Subject.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6114/
Test PASSed.

Thanks @gpang! I updated the PR. PTAL.

Thanks @gpang! PTAL.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6130/
Test PASSed.

alluxio-bot, merge this please

@bf8086 does this need to be cherry-picked to branch-2.0?

@gpang yeah it looks like the same code path exists in branch-2.0 as well

alluxio-bot, cherry-pick this to branch-2.0 please

@bf8086 the auto-cherry-pick doesn't merge cleanly, so you will have to cherry-pick manually.


support gevent 20.x: new hub destruction incompatible with gipc's child handler approach

After https://github.com/gevent/gevent/pull/1604/ it seems to be the case that https://github.com/jgehrcke/gipc/blob/c8125872fa263f93e920f3041cac2d51063c614c/gipc/gipc.py#L344 may hang indefinitely in https://github.com/gevent/gevent/pull/1604/files#diff-94cf0d2f0e2386d3392cf0e1908536efR766.
Added two print statements:
792         # things will go VERY, VERY wrong.
793         print("destroy: PRE THROW")
794         try:
795             self.throw(GreenletExit)
796             print('AFTER THROW')
797         except LoopExit:
798             # Expected.

During execution of pytest --log-level=debug -vvv -s -k childchild the last thing we see is
16:39:38,932.5  [22187]_child# Destroy hub and default loop.
destroy: PRE THROW
^CKeyboardInterrupt

hub.destroy hanging is fixed in gevent 20.12.1, using gipc 1.1.1 seems to work for our app with 20.12.1.
I'm curious if there are other outstanding compatibility issues that need to be resolved with gipc before using it there, I pulled the gevent update branch and pushed it to our local pip repository and it hasn't had trouble thus far.

@TylerWilley I had another look. There are tests in gipc's test suite that make a child process crash when it exercises https://github.com/gevent/gevent/blob/83c9e2ae5b0834b8f84233760aabe82c3ba065b4/src/gevent/hub.py#L807 -- from here, things are a little more challenging to debug: I assume that the crash happens somewhere around https://github.com/gevent/gevent/blob/83c9e2ae5b0834b8f84233760aabe82c3ba065b4/src/gevent/libev/corecext.pyx#L576.

@TylerWilley I had another look. With gevent 21.1, there are tests in gipc's test suite that make a child process crash when it exercises https://github.com/gevent/gevent/blob/83c9e2ae5b0834b8f84233760aabe82c3ba065b4/src/gevent/hub.py#L807 -- from here, things are a little more challenging to debug: I assume that the crash happens somewhere around https://github.com/gevent/gevent/blob/83c9e2ae5b0834b8f84233760aabe82c3ba065b4/src/gevent/libev/corecext.pyx#L576.

any update on the compatibility issue?

I posted a PR that fixes the unit tests here: https://github.com/jgehrcke/gipc/pull/110
It relies on forcing python3.8 from using spawn as the default back to fork to preserve how gipc passes file descriptors, and makes use of gevent's reinit method instead of the dirty cleanup it was doing before.
Tested it on python 3.6.9 + gevent 1.2.2 and 3.8.6 + gevent 20.12.1

I use gipc with multiprocess.queue, after upgrade gevent to 20.x, program broken.
errors:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/util.py", line 328, in _exit_function
    p.join()
  File "/ib/python2.7/site-packages/gipc/gipc.py", line 590, in join
    self._returnevent.wait(timeout)
  File "src/gevent/event.py", line 127, in gevent._event.Event.wait
  File "src/gevent/_abstract_linkable.py", line 192, in gevent.__abstract_linkable.AbstractLinkable._wait
  File "src/gevent/_abstract_linkable.py", line 165, in gevent.__abstract_linkable.AbstractLinkable._wait_core
  File "src/gevent/_abstract_linkable.py", line 169, in gevent.__abstract_linkable.AbstractLinkable._wait_core
  File "src/gevent/_greenlet_primitives.py", line 60, in gevent.__greenlet_primitives.SwitchOutGreenletWithLoop.switch
  File "src/gevent/_greenlet_primitives.py", line 60, in gevent.__greenlet_primitives.SwitchOutGreenletWithLoop.switch
  File "src/gevent/_greenlet_primitives.py", line 64, in gevent.__greenlet_primitives.SwitchOutGreenletWithLoop.switch
  File "src/gevent/__greenlet_primitives.pxd", line 35, in gevent.__greenlet_primitives._greenlet_switch
error: cannot switch to a different thread
Error in sys.exitfunc:


[WIP] dbc file for 2017 Honda CR-V

Issue #70 Still missing some message definitions for GAS command and BRAKE command.

Glad to see you working on this. Let me know when you are ready to merge.

Forum says you are in Philly. On a train there right now. If you are around tomorrow, I could help hack on the CR-V.

Awesome, I'll be here

@geohot Messaged you on the forum

Having a tough time tracking down the adas heartbeat message (get the LKAS, ACC, collision mitigation errors when i plug into NEO), as well as gas command and brake command.
This is an ASC dump of can lines with LKAS and ACC engaged.
can.asc.zip

What does _BOH stand for in:
 SG_ ZEROS_BOH : 7|17@0+ (1,0) [0|127] ""  BDY
 SG_ APPLY_BRAKES_FOR_CANC : 23|1@0+ (1,0) [0|15] ""  BDY
 SG_ ZEROS_BOH2 : 22|1@0+ (1,0) [0|1] ""  BDY
 SG_ RESUME_INSTRUCTION : 21|1@0+ (1,0) [0|15] ""  BDY
 SG_ ACC_ALERTS : 20|5@0+ (1,0) [0|15] ""  BDY
 SG_ ZEROS_BOH2 : 31|8@0+ (1,0) [0|127] ""  BDY
 SG_ LEAD_SPEED : 39|9@0+ (1,0) [0|127] ""  BDY
 SG_ LEAD_STATE : 46|3@0+ (1,0) [0|127] ""  BDY
 SG_ LEAD_DISTANCE : 43|5@0+ (1,0) [0|31] ""  BDY
 SG_ ZEROS_BOH3 : 54|7@0+ (1,0) [0|127] ""  BDY

Will this dbc file work for 2016 CRV?
Thanks!
liangpi

@pinglianghan No

@geohot This is more or less complete, there are some signals marked with XXX that might need might need some more work.

energee: Good to merge?

Good to merge.


Update installation methods on Windows

gopass can be installed by Chocolatey or Scoop.
BTW, I am using gopass on Windows daily. Although I use it only for basic tasks, it works fine.
Thank you!

Codecov Report

Merging #1102 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1102   +/-   ##
=======================================
  Coverage   62.57%   62.57%
=======================================
  Files         184      184
  Lines       10239    10239
=======================================
  Hits         6407     6407
  Misses       3033     3033
  Partials      799      799

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8adabdb...e3fd642. Read the comment docs.


feat: add . as a valid option to create or allow no argument

Description
As a user of the very_good_cli I want to be able to use . as the argument for very_good create.
If no argument or . is given, the cli uses the current folder's name as the project name.

Notes

The flutter create command works the same way, allowing . to automatically pull in the current directory name
This should not override the current default which is to error out to the help output. If a user wants to use this option they should be explicitly adding . to the command.

Hi @a-wallen 👋 given the notes we have added here would you be willing to help out and submit a PR for this change?

yeah I'm down


refactor: Plugins can be adapted to both the left and right side panels

English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our Commit Message Guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Built its own designer, fully self-validated

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Background and solution
左右侧插件面板适配插件

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Summary by CodeRabbit

New Features

Enhanced clarity in settings management with new naming conventions for properties.
Introduced additional control states in layout behavior.
Improved error handling in plugin logic to enhance stability.

Bug Fixes

Fixed potential errors related to undefined values in plugin handling.

Style

Adjusted alignment properties for enhanced visual layout across components.

Refactor

Renamed references from SETTING_NAME to PLUGIN_NAME for consistency and clarity within the application.

部分提交没有签名


"Microsoft accounts" can be an ambiguous term

"These are groups of specific customers, created from the email addresses associated with their Microsoft accounts."
Through a bit of testing, it appears that this feature doesn't support "Work or School" Microsoft accounts. If that is indeed the case, it could be made more explicit that it only works for personal Microsoft accounts and the Work or School accounts do not work.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96b0cb0b-7d5e-cfd7-2bc4-071503570874
Version Independent ID: f4d91bc4-6467-eca7-b9e3-e7316f24397b
Content: Create customer groups - UWP applications
Content Source: windows-apps-src/publish/create-customer-groups.md
Product: uwp
Technology: publish
GitHub Login: @hickeys
Microsoft Alias: hickeys

We are changing the way we track issues filed from our documentation pages: please see this blog post for more details. The Microsoft Store documentation has been updated several times since your issue was reported, and there's a good chance your problem has been addressed. Right now, this issue is being closed but if you feel it is still valid and has not been addressed, please re-open it with any more available information. Please note that if you question is more general and not related to documentation, Microsoft Q&A is a great way to get questions answered.


pyfa: init at 2.58.2

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This application has an auto update feature, where it calls back home to Github to check for an update. It opens a dialog asking if the user wants to update.
This is crashing the program for me, I suspect its due to my Nvidia graphics card, but I'm not 100% sure. I'd like to disable the update prompt, since its not really useful for nixpkgs anyway.
Are there any patterns that already exist around disabling automated updates? If so, I would appreciate if someone could point me in the right direction, or give some advice. Thanks!


[SPARK-42783][SQL] Infer window group limit should run as late as possible

What changes were proposed in this pull request?
https://github.com/apache/spark/pull/40142 have an unrelated change and is actually a regression. The change let infer window group limit runs early.
Infer window group limit should run as late as possible, it is more safe.
Why are the changes needed?
Infer window group limit should run as late as possible.
Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
Exists test cases.
Manually generate the micro benchmark.


Adding an item resets the carousel to the beginning

It would be desirable to be able to add 1 or more elements to the end of the carousel without losing the current position you are viewing.

I understand that this is an old close one, but just in case somebody else lands here facing the same issue with owl 1.3.3, you can simply call jumpTo immediately after having called addItem to reset the position to wherever necessary.

1.3.3 is a different project that you can find here


_cluster block build

I'm trying to doc OTG_FS_DEVICE peripheral for STM32F4. and I encounted a problem.
There is only 4 End Point for OTG_FS_DEVICE in F429 (RM0090), thus only 1-3 for DIEP%s and DOEP%s, but in fs_device_cluster.yaml, it clusters 1-5. As long as I don't _add or _delete fields of the real exist registers, svdtools and svd2rust can generate correct libs (only 1-3 generated). But if this registers have been modified, then svdtools refuse patch svd files.
Here is the log from CI. The line of yaml file and another line of yaml file I think may related to this.
Since fs_device_cluster.yaml is included in fs_v1 and fs_v2, I'm not sure should I split this file into 2 (or even more?) versions to include in different devices (which may affect many devices), or svdtools may need to do some modification, that it will check whether a member of cluster real exist before generate patches?

but in fs_device_cluster.yaml, it clusters 1-5

It is not true.
DIEPCTL[1-5] pattern means it takes all registers matches this pattern.
So if there is no DIEPCTL4 and DIEPCTL5 it just ignore them. It fails only if no matches.
You need first delete DIEPCTL4 if it is not really present in chip before collecting registers in cluster.

You need first delete DIEPCTL4 if it is not really present in chip before collecting registers in cluster.

I have try to _delete DIEPCTL4 and DIEPCTL4, but _cluster still report error.
Then I comment out entire _delete and fs_device_cluster.yaml. Libs are generated, and no DIEP*[4-5] and DOEP*[4-5] exist. There are only end point 0-3.
I might think originally there are no end point 4 and end point 5 exist for these devices, but _cluster some how create them.

I just comment out include line from device yaml, and it works. thanks!


RuntimeError when formatting sparse-backed DataArray in f-string

What happened?
On upgrading from xarray 2022.3.0 to 2022.6.0, f-string formatting of sparse-backed DataArray raises an exception.
What did you expect to happen?

Code does not error, or
A breaking change is listed in the “Breaking changes” section of the docs.

Minimal Complete Verifiable Example
import pandas as pd
import xarray as xr

s = pd.Series(
    range(4),
    index=pd.MultiIndex.from_product([list("ab"), list("cd")]),
)

da = xr.DataArray.from_series(s, sparse=True)

print(f"{da}")

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output
# xarray 2022.3.0:

<xarray.DataArray (level_0: 2, level_1: 2)>
<COO: shape=(2, 2), dtype=float64, nnz=4, fill_value=nan>
Coordinates:
  * level_0  (level_0) object 'a' 'b'
  * level_1  (level_1) object 'c' 'd'

# xarray 2022.6.0:

Traceback (most recent call last):
  File "/home/khaeru/bug.py", line 11, in <module>
    print(f"{da}")
  File "/home/khaeru/.local/lib/python3.10/site-packages/xarray/core/common.py", line 168, in __format__
    return self.values.__format__(format_spec)
  File "/home/khaeru/.local/lib/python3.10/site-packages/xarray/core/dataarray.py", line 685, in values
    return self.variable.values
  File "/home/khaeru/.local/lib/python3.10/site-packages/xarray/core/variable.py", line 527, in values
    return _as_array_or_item(self._data)
  File "/home/khaeru/.local/lib/python3.10/site-packages/xarray/core/variable.py", line 267, in _as_array_or_item
    data = np.asarray(data)
  File "/home/khaeru/.local/lib/python3.10/site-packages/sparse/_sparse_array.py", line 229, in __array__
    raise RuntimeError(
RuntimeError: Cannot convert a sparse array to dense automatically. To manually densify, use the todense method.

Anything else we need to know?
Along with the versions below, I have confirmed the error occurs with both sparse 0.12 and sparse 0.13.
Environment

INSTALLED VERSIONS
------------------
commit: None
python: 3.10.4 (main, Jun 29 2022, 12:14:53) [GCC 11.2.0]
python-bits: 64
OS: Linux
OS-release: 5.15.0-41-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_CA.UTF-8
LOCALE: ('en_CA', 'UTF-8')
libhdf5: 1.10.7
libnetcdf: 4.8.1
xarray: 2022.6.0
pandas: 1.4.2
numpy: 1.22.4
scipy: 1.8.0
netCDF4: 1.5.8
pydap: None
h5netcdf: 0.12.0
h5py: 3.6.0
Nio: None
zarr: None
cftime: 1.5.2
nc_time_axis: None
PseudoNetCDF: None
rasterio: None
cfgrib: None
iris: None
bottleneck: 1.3.2
dask: 2022.01.0+dfsg
distributed: 2022.01.0+ds.1
matplotlib: 3.5.1
cartopy: 0.20.2
seaborn: 0.11.2
numbagg: None
fsspec: 2022.01.0
cupy: None
pint: 0.18
sparse: 0.13.0
flox: None
numpy_groupies: None
setuptools: 62.1.0
pip: 22.0.2
conda: None
pytest: 6.2.5
IPython: 7.31.1
sphinx: 4.5.0

This comes from #5981, I think it's better to just let the backend array (numpy, dask, sparse etc.) determine how to handle string formatting instead of forcing to numpy arrays.

Thanks @Illviljan for the fix! 🙏🏾